Limit the ability to post to old threads

Example: http://forum.arduino.cc/index.php?topic=226683.msg2034860#msg2034860
A fairly meaningless post was added to this thread, after a delay of 10 months. Such posts are quite often the precursor to spam, as the poster tries to "look legitimate". The post was:

since he did not get back on this simple, yet crucial little problem, i will say this solves delay() issues for arduino and tiny indeed!
thanks olf2012

(You can't really say that the above post added any useful information to the discussion. This was the first post for this forum user. This could have been written by almost anyone by extracting out a few keywords from earlier posts, like "delay", "arduino", and "tiny" - two of which were in the thread title).
I suggest that threads be automatically blocked from new posts if they are old (eg. more than 3 months) as this is usually someone just hijacking an old thread when starting a new one would be more appropriate.
Alternatively, limit the ability to add to old threads to people with (say) 100+ posts to their names, who are therefore established forum members.

I don't think any software can know if the post added to an old post is legit or not. A Global Moderator
is qualified to decide that. I think the forum objective is to provide reference database for forum members and therefore if a new post on an old thread accomplishes that objective I would say it should
be allowed.

I don't agree with this. I just found another old thread (started in 2013) where someone had added a (completely irrelevant) extra question. It is easy to miss that the thread was started years ago, and assume that the original poster is still interested in your replies.
If a case can be made that the old thread contains egregiously wrong material, then a moderator (who would have to power to edit it) could modify the old thread, eg. by adding a link to a newer thread which corrects the information, or add a correction.
However, for people who have just joined the forum, and done a Google search, and found something vaguely relating to their problem (eg. "serial communications") to hijack and old thread, is just silly.
Let's make the default that you can't add to old threads, but you can always make a new one, and point out to the moderators that thread X from 5 years ago is now incorrect (if anyone cares).

"However, for people who have just joined the forum, and done a Google search, and found something vaguely relating to their problem (eg. "serial communications") to hijack and old thread, is just silly."
I agree, and I never suggested otherwise. This is why I said no software could tell if something added is relevant enough to be allowed to be added and since we cannot expect the Global Moderators to be
able to find the time to remove added comments that are not relevant to the thread then that only leaves one remaining option and that is to NOT allow new comments to an old thread. I think Nick and I are on the same page but got our signals crossed. I think he was basically just saying it is not
physically (or practically ) possible for Global Moderators to find and eliminate irrelevant new comments to an old thread (or hijackers) and thus new comments should not be allowed, period
I agree with that because there is no other option.

Hi nickgammon. Thanks for taking the time to make this suggestion Topics are now locked after four months without activity.


Upgrade to 2.0.0-rc.7

Current coverage is 90.39% (diff: 100%)

Merging #961 into development will not change coverage

@@           development       #961   diff @@
=============================================
  Files               26         26
  Lines              781        781
  Methods            142        142
  Messages             0          0
  Branches           115        115
=============================================
  Hits               706        706
  Misses              75         75
  Partials             0          0

Powered by Codecov. Last update 6effd07...7a1d433


Fix ActivityPrompt documentation comments

The class summary had previously been copied from Prompt.cs which was misleading. The comment made it sound like ActivityPrompt was the base class of all prompts.

Pull Request Test Coverage Report for Build 59968

0 of 0   changed or added relevant lines in 0 files are covered.
13 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 66.014%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ActivityPrompt.cs
13
78.57%

Totals

Change from base Build 59959:
0.0%

Covered Lines:
4009

Relevant Lines:
6073

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll


Remove require.js?

NBSite is shipping a pretty old version of require.js. I know I've needed require.js to get Plotly plot to be displayed (directly, not via HoloViews) on hvPlot. Except that kind of case, that seems unusual in HoloViz, I'm not sure require.js is of any use now.

I'm not really sure in what form we are shipping require.js. I don't see it on any of our sites.

You removed the require.js file that was in nbsite/_shared_static, right?

Yeah, I found it, and then deleted it :)

Ok thanks.
Actually I remember I had to fiddle with require.js in hvPlot's docs to display a plotly plot, rendered directly and not through HoloViews' machinery. This is the comment I left https://github.com/holoviz/hvplot/blob/874e4d9835980b820aaa36802e1449f4ad0ee163/doc/conf.py#L26
And indeed the dev built of hvPlot no longer shows that plot https://pyviz-dev.github.io/hvplot/user_guide/Plotting_Extensions.html

Uncaught ReferenceError: require is not defined
    <anonymous> https://pyviz-dev.github.io/hvplot/user_guide/Plotting_Extensions.html:5988

But I bet there's another way to render that plot on the site without requiring nbsite to bundle require.js.

Worst case we just use Panel to render the figure.


Opening a Jupyter notebook disrupts existing SSH connection with the remote

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.83.1
OS Version: Local: Ubuntu 22.04, Remote: Ubuntu 20.04
Jupyter extension version: v2023.9.1102792234
Remote SSh extension version: v0.106.5
Python extension version: v2023.18.0

I have two servers one with Ubuntu 20.04 and the other with 22.04. This bug occurs only in the 20.04 server. When I connect to the remote server with vscode, Remote SSH gives the following logs
[23:22:11.782] Log Level: 2
[23:22:11.796] VS Code version: 1.83.1
[23:22:11.796] Remote-SSH version<EMAIL_ADDRESS>[23:22:11.796] linux x64
[23:22:11.797] SSH Resolver called for "ssh-remote+<IP_ADDRESS>", attempt 1
[23:22:11.798] "remote.SSH.useLocalServer": true
[23:22:11.799] "remote.SSH.useExecServer": false
[23:22:11.799] "remote.SSH.path": undefined
[23:22:11.799] "remote.SSH.configFile": undefined
[23:22:11.799] "remote.SSH.useFlock": true
[23:22:11.799] "remote.SSH.lockfilesInTmp": false
[23:22:11.799] "remote.SSH.localServerDownload": auto
[23:22:11.800] "remote.SSH.remoteServerListenOnSocket": false
[23:22:11.800] "remote.SSH.showLoginTerminal": false
[23:22:11.800] "remote.SSH.defaultExtensions": []
[23:22:11.800] "remote.SSH.loglevel": 2
[23:22:11.801] "remote.SSH.enableDynamicForwarding": true
[23:22:11.801] "remote.SSH.enableRemoteCommand": false
[23:22:11.801] "remote.SSH.serverPickPortsFromRange": {}
[23:22:11.802] "remote.SSH.serverInstallPath": {}
[23:22:11.806] SSH Resolver called for host: <IP_ADDRESS>
[23:22:11.806] Setting up SSH remote "<IP_ADDRESS>"
[23:22:11.809] Acquiring local install lock: /tmp/vscode-remote-ssh-c940f595-install.lock
[23:22:11.813] Looking for existing server data file at /home/avishka/.config/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-c940f595-f1b07bd25dfad64b0167beb15359ae573aecd2cc-0.106.5-tr/data.json
[23:22:11.813] Using commit id "f1b07bd25dfad64b0167beb15359ae573aecd2cc" and quality "stable" for server
[23:22:11.818] Install and start server if needed
[23:22:11.821] PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin
[23:22:11.821] Checking ssh with "ssh -V"
[23:22:11.830] > OpenSSH_8.9p1 Ubuntu-3ubuntu0.4, OpenSSL 3.0.2 15 Mar 2022

[23:22:11.833] askpass server listening on /run/user/1000/vscode-ssh-askpass-7020fefe66231ce577fa8e1205be4c537f8dbf9c.sock
[23:22:11.833] Spawning local server with {"serverId":1,"ipcHandlePath":"/run/user/1000/vscode-ssh-askpass-0454306672e9df386688d3aecf4bacb4fc8d290b.sock","sshCommand":"ssh","sshArgs":["-v","-T","-D","33111","-o","ConnectTimeout=15","<IP_ADDRESS>"],"serverDataFolderName":".vscode-server","dataFilePath":"/home/avishka/.config/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-c940f595-f1b07bd25dfad64b0167beb15359ae573aecd2cc-0.106.5-tr/data.json"}
[23:22:11.833] Local server env: {"SSH_AUTH_SOCK":"/run/user/1000/keyring/ssh","SHELL":"/bin/bash","DISPLAY":":1","ELECTRON_RUN_AS_NODE":"1","SSH_ASKPASS":"/home/avishka/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.5/out/local-server/askpass.sh","VSCODE_SSH_ASKPASS_NODE":"/snap/code/143/usr/share/code/code","VSCODE_SSH_ASKPASS_EXTRA_ARGS":"--ms-enable-electron-run-as-node","VSCODE_SSH_ASKPASS_MAIN":"/home/avishka/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.5/out/askpass-main.js","VSCODE_SSH_ASKPASS_HANDLE":"/run/user/1000/vscode-ssh-askpass-7020fefe66231ce577fa8e1205be4c537f8dbf9c.sock"}
[23:22:11.838] Spawned 34845
[23:22:11.941] > local-server-1> Running ssh connection command: "-v -T -D 33111 -o ConnectTimeout=15 <IP_ADDRESS>"
[23:22:11.946] > local-server-1> Spawned ssh, pid=34853
[23:22:11.949] stderr> OpenSSH_8.9p1 Ubuntu-3ubuntu0.4, OpenSSL 3.0.2 15 Mar 2022
[23:22:12.137] stderr> debug1: Server host key: ssh-ed25519 SHA256:O2Q3Ot00kHRnuJux4A/9oLbeeXAGaIr8YCr9QFMlJYk
[23:22:12.416] stderr> Authenticated to <IP_ADDRESS> ([<IP_ADDRESS>]:22) using "publickey".
[23:22:13.079] > Welcome to Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-164-generic x86_64)
>
>  * Documentation:  https://help.ubuntu.com
>  * Management:     https://landscape.canonical.com
>  * Support:        https://ubuntu.com/advantage
>
>   System information as of Thu 19 Oct 2023 11:22:12 PM +0530
>
>   System load:                0.08
>   Usage of /home:             88.7% of 468.38GB
>   Memory usage:               1%
>   Swap usage:                 0%
>   Temperature:                40.0 C
>   Processes:                  541
>   Users logged in:            1
>   IPv4 address for enp0s31f6: <IP_ADDRESS>
>
>   => /home is using 88.7% of 468.38GB
>
>  * Strictly confined Kubernetes makes edge and IoT secure. Learn how MicroK8s
>    just raised the bar for easy, resilient and secure K8s cluster deployment.
>
>    https://ubuntu.com/engage/secure-kubernetes-at-the-edge
>
> Expanded Security Maintenance for Applications is not enabled.
>
> 9 updates can be applied immediately.
> To see these additional updates run: apt list --upgradable
>
> 22 additional security updates can be applied with ESM Apps.
> Learn more about enabling ESM Apps service at https://ubuntu.com/esm
>
> New release '22.04.3 LTS' available.
> Run 'do-release-upgrade' to upgrade to it.
>
>
> 15 updates could not be installed automatically. For more details,
> see /var/log/unattended-upgrades/unattended-upgrades.log
[23:22:13.111] > ready: 8deba43114ee
[23:22:13.132] > Linux 5.4.0-164-generic #181-Ubuntu SMP Fri Sep 1 13:41:22 UTC 2023
[23:22:13.133] Platform: linux
[23:22:13.157] > /bin/bash
[23:22:13.158] Shell: bash
[23:22:13.158] Creating bash subshell inside "bash"
[23:22:13.239] > bash version:  5.0.17(1)-release
[23:22:13.245] > bash version:  5.0.17(1)-release
[23:22:13.349] > 8deba43114ee: running
[23:22:13.390] > Acquiring lock on /home/avishka/.vscode-server/bin/f1b07bd25dfad64b0167beb15359ae573aecd2cc/vscode-remote-lock.avishka.f1b07bd25dfad64b0167beb15359ae573aecd2cc
[23:22:13.395] > Found existing installation at /home/avishka/.vscode-server/bin/f1b07bd25dfad64b0167beb15359ae573aecd2cc...
[23:22:13.396] > Checking /home/avishka/.vscode-server/.f1b07bd25dfad64b0167beb15359ae573aecd2cc.log and /home/avishka/.vscode-server/.f1b07bd25dfad64b0167beb15359ae573aecd2cc.pid for a running server
[23:22:13.398] > Looking for server with pid: 26425
[23:22:13.435] > Found running server...
>
> *
> * Visual Studio Code Server
> *
> * By using the software, you agree to
> * the Visual Studio Code Server License Terms (https://aka.ms/vscode-server-license) and
[23:22:13.436] > * the Microsoft Privacy Statement (https://privacy.microsoft.com/en-US/privacystatement).
> *
>
[23:22:13.449] > Checking server status on port 43299 with wget
[23:22:13.462] > 8deba43114ee: start
> SSH_AUTH_SOCK====
> DISPLAY====
> webUiAccessToken====
> listeningOn==43299==
> osReleaseId==ubuntu==
> arch==x86_64==
> vscodeArch==x64==
> bitness==64==
[23:22:13.464] > tmpDir==/run/user/1012==
> platform==linux==
> unpackResult====
> didLocalDownload==0==
> downloadTime====
> installTime====
> extInstallTime====
> serverStartTime====
> connectionToken==aa111111-11a1-1a1a-111a-aa11a1a1a111==
> 8deba43114ee: end
[23:22:13.464] Received install output:
SSH_AUTH_SOCK====
DISPLAY====
webUiAccessToken====
listeningOn==43299==
osReleaseId==ubuntu==
arch==x86_64==
vscodeArch==x64==
bitness==64==tmpDir==/run/user/1012==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime====
connectionToken==aa111111-11a1-1a1a-111a-aa11a1a1a111==

[23:22:13.465] Remote server is listening on port 43299
[23:22:13.465] Parsed server configuration: {"serverConfiguration":{"remoteListeningOn":{"port":43299},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","sshAuthSock":"","display":"","tmpDir":"/run/user/1012","platform":"linux","connectionToken":"aa111111-11a1-1a1a-111a-aa11a1a1a111"},"installUnpackCode":""}
[23:22:13.466] Persisting server connection details to /home/avishka/.config/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-c940f595-f1b07bd25dfad64b0167beb15359ae573aecd2cc-0.106.5-tr/data.json
[23:22:13.470] Starting forwarding server. local port 46703 -> socksPort 33111 -> remotePort 43299
[23:22:13.470] Forwarding server listening on port 46703
[23:22:13.470] Waiting for ssh tunnel to be ready
[23:22:13.472] [Forwarding server port 46703] Got connection 0
[23:22:13.473] Tunneled port 43299 to local port 46703
[23:22:13.473] Resolved "ssh-remote+<IP_ADDRESS>" to "port 46703"
[23:22:13.484] ------

[23:22:13.499] [Forwarding server port 46703] Got connection 1
[23:22:13.601] [Forwarding server port 46703] Got connection 2
[23:22:14.408] [Forwarding server port 46703] Got connection 3
[23:22:14.409] [Forwarding server port 46703] Got connection 4

Whenever I open a Jupyter notebook, the connection is broken.

Remote SSH also makes more logs now. Which is not seen in my Ubuntu 22.04 server
[23:28:09.120] SSH Resolver called for "ssh-remote+<IP_ADDRESS>", attempt 2, (Reconnection)
[23:28:09.124] SSH Resolver called for host: <IP_ADDRESS>
[23:28:09.124] Setting up SSH remote "<IP_ADDRESS>"
[23:28:09.127] Acquiring local install lock: /tmp/vscode-remote-ssh-c940f595-install.lock
[23:28:09.130] Looking for existing server data file at /home/avishka/.config/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-c940f595-f1b07bd25dfad64b0167beb15359ae573aecd2cc-0.106.5-tr/data.json
[23:28:09.132] Found local server running: {"remoteListeningOn":{"port":43299},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","sshAuthSock":"","display":"","tmpDir":"/run/user/1012","platform":"linux","connectionToken":"aa111111-11a1-1a1a-111a-aa11a1a1a111","pid":34845,"ipcHandlePath":"/run/user/1000/vscode-ssh-askpass-0454306672e9df386688d3aecf4bacb4fc8d290b.sock","socksPort":33111,"startupTime":1697737931839}
[23:28:09.133] Running server is stale. Ignoring
[23:28:09.136] Using commit id "f1b07bd25dfad64b0167beb15359ae573aecd2cc" and quality "stable" for server
[23:28:09.142] Install and start server if needed
[23:28:09.147] askpass server listening on /run/user/1000/vscode-ssh-askpass-e7e1da0b36d018587054bf6eb824a666e53e8e2f.sock
[23:28:09.147] Spawning local server with {"serverId":2,"ipcHandlePath":"/run/user/1000/vscode-ssh-askpass-a35f7eb982fca121d2d78f2b7d63d91d556869e9.sock","sshCommand":"ssh","sshArgs":["-v","-T","-D","33111","-o","ConnectTimeout=15","<IP_ADDRESS>"],"serverDataFolderName":".vscode-server","dataFilePath":"/home/avishka/.config/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-c940f595-f1b07bd25dfad64b0167beb15359ae573aecd2cc-0.106.5-tr/data.json"}
[23:28:09.147] Local server env: {"SSH_AUTH_SOCK":"/run/user/1000/keyring/ssh","SHELL":"/bin/bash","DISPLAY":":1","ELECTRON_RUN_AS_NODE":"1","SSH_ASKPASS":"/home/avishka/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.5/out/local-server/askpass.sh","VSCODE_SSH_ASKPASS_NODE":"/snap/code/143/usr/share/code/code","VSCODE_SSH_ASKPASS_EXTRA_ARGS":"--ms-enable-electron-run-as-node","VSCODE_SSH_ASKPASS_MAIN":"/home/avishka/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.5/out/askpass-main.js","VSCODE_SSH_ASKPASS_HANDLE":"/run/user/1000/vscode-ssh-askpass-e7e1da0b36d018587054bf6eb824a666e53e8e2f.sock"}
[23:28:09.153] Spawned 35020
[23:28:09.154] Failed to set up socket for dynamic port forward to remote port 43299: Socket closed. Is the remote port correct?
[23:28:09.248] > local-server-2> Running ssh connection command: "-v -T -D 33111 -o ConnectTimeout=15 <IP_ADDRESS>"
[23:28:09.252] > local-server-2> Spawned ssh, pid=35028
[23:28:09.256] stderr> OpenSSH_8.9p1 Ubuntu-3ubuntu0.4, OpenSSL 3.0.2 15 Mar 2022
[23:28:09.541] stderr> debug1: Server host key: ssh-ed25519 SHA256:O2Q3Ot00kHRnuJux4A/9oLbeeXAGaIr8YCr9QFMlJYk
[23:28:09.863] stderr> Authenticated to <IP_ADDRESS> ([<IP_ADDRESS>]:22) using "publickey".
[23:28:09.864] stderr> bind [::1]:33111: Address already in use
[23:28:09.864] stderr> bind [<IP_ADDRESS>]:33111: Address already in use
[23:28:09.864] stderr> channel_setup_fwd_listener_tcpip: cannot listen to port: 33111
[23:28:09.865] stderr> Could not request local forwarding.
[23:28:10.647] > Welcome to Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-164-generic x86_64)
>
>  * Documentation:  https://help.ubuntu.com
>  * Management:     https://landscape.canonical.com
>  * Support:        https://ubuntu.com/advantage
>
>   System information as of Thu 19 Oct 2023 11:28:09 PM +0530
>
>   System load:                0.16
>   Usage of /home:             88.7% of 468.38GB
>   Memory usage:               1%
>   Swap usage:                 0%
>   Temperature:                40.0 C
>   Processes:                  543
>   Users logged in:            1
>   IPv4 address for enp0s31f6: <IP_ADDRESS>
>
>   => /home is using 88.7% of 468.38GB
>
>  * Strictly confined Kubernetes makes edge and IoT secure. Learn how MicroK8s
>    just raised the bar for easy, resilient and secure K8s cluster deployment.
>
>    https://ubuntu.com/engage/secure-kubernetes-at-the-edge
>
> 1 device has a firmware upgrade available.
> Run `fwupdmgr get-upgrades` for more information.
>
>
> Expanded Security Maintenance for Applications is not enabled.
>
> 9 updates can be applied immediately.
> To see these additional updates run: apt list --upgradable
>
> 22 additional security updates can be applied with ESM Apps.
> Learn more about enabling ESM Apps service at https://ubuntu.com/esm
>
> New release '22.04.3 LTS' available.
> Run 'do-release-upgrade' to upgrade to it.
>
>
> 15 updates could not be installed automatically. For more details,
> see /var/log/unattended-upgrades/unattended-upgrades.log
[23:28:10.693] > ready: 9f8ef0798838
[23:28:10.759] > Linux 5.4.0-164-generic #181-Ubuntu SMP Fri Sep 1 13:41:22 UTC 2023
[23:28:10.759] Platform: linux
[23:28:10.805] > /bin/bash
[23:28:10.806] Shell: bash
[23:28:10.807] Creating bash subshell inside "bash"
[23:28:10.901] > bash version:  5.0.17(1)-release
[23:28:10.904] > bash version:  5.0.17(1)-release
[23:28:11.061] > 9f8ef0798838: running
[23:28:11.107] > Acquiring lock on /home/avishka/.vscode-server/bin/f1b07bd25dfad64b0167beb15359ae573aecd2cc/vscode-remote-lock.avishka.f1b07bd25dfad64b0167beb15359ae573aecd2cc
[23:28:11.119] > Found existing installation at /home/avishka/.vscode-server/bin/f1b07bd25dfad64b0167beb15359ae573aecd2cc...
> Checking /home/avishka/.vscode-server/.f1b07bd25dfad64b0167beb15359ae573aecd2cc.log and /home/avishka/.vscode-server/.f1b07bd25dfad64b0167beb15359ae573aecd2cc.pid for a running server
> Looking for server with pid: 26425
[23:28:11.160] > Running ssh connection command... /home/avishka/.vscode-server/bin/f1b07bd25dfad64b0167beb15359ae573aecd2cc/bin/code-server --start-server --host=<IP_ADDRESS> --accept-server-license-terms --enable-remote-auto-shutdown --port=0 --telemetry-level all   &> "/home/avishka/.vscode-server/.f1b07bd25dfad64b0167beb15359ae573aecd2cc.log" < /dev/null
> printenv:
>     SHELL=/bin/bash
>     CONDA_EXE=/opt/conda/bin/conda
>     _CE_M=
>     LC_ADDRESS=C.UTF-8
>     LC_NAME=C.UTF-8
>     LC_MONETARY=C.UTF-8
>     PWD=/home/avishka
>     LOGNAME=avishka
>     XDG_SESSION_TYPE=tty
>     MOTD_SHOWN=pam
>     HOME=/home/avishka
>     LANG=C.UTF-8
>     LC_PAPER=C.UTF-8
>     VSCODE_AGENT_FOLDER=/home/avishka/.vscode-server
>     SSH_CONNECTION=<IP_ADDRESS> 62981 <IP_ADDRESS> 22
>     XDG_SESSION_CLASS=user
>     LC_IDENTIFICATION=C.UTF-8
>     _CE_CONDA=
>     USER=avishka
>     CONDA_SHLVL=0
>     SHLVL=1
>     LC_TELEPHONE=C.UTF-8
>     LC_MEASUREMENT=C.UTF-8
>     XDG_SESSION_ID=94
>     CONDA_PYTHON_EXE=/opt/conda/bin/python
>     XDG_RUNTIME_DIR=/run/user/1012
>     SSH_CLIENT=<IP_ADDRESS> 62981 22
>     LC_TIME=C.UTF-8
>     XDG_DATA_DIRS=/usr/local/share:/usr/share:/var/lib/snapd/desktop
>     PATH=/opt/conda/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/local/texlive/2023/bin/x86_64-linux
>     DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus
>     LC_NUMERIC=C.UTF-8
>     _=/usr/bin/printenv
[23:28:11.161] > Removing old logfile at /home/avishka/.vscode-server/.f1b07bd25dfad64b0167beb15359ae573aecd2cc.log
> Spawned remote server: 26997
[23:28:11.187] > Waiting for server log...
[23:28:11.202] > Waiting for server log...
[23:28:11.244] >
> *
> * Visual Studio Code Server
> *
> * By using the software, you agree to
> * the Visual Studio Code Server License Terms (https://aka.ms/vscode-server-license) and
> * the Microsoft Privacy Statement (https://privacy.microsoft.com/en-US/privacystatement).
> *
>
[23:28:11.251] > 9f8ef0798838: start
> SSH_AUTH_SOCK====
> DISPLAY====
> webUiAccessToken====
[23:28:11.253] > listeningOn==38709==
> osReleaseId==ubuntu==
> arch==x86_64==
> vscodeArch==x64==
> bitness==64==
> tmpDir==/run/user/1012==
> platform==linux==
> unpackResult====
> didLocalDownload==0==
> downloadTime====
> installTime====
> extInstallTime====
> serverStartTime==91==
> connectionToken==a11111a1-11a1-1aa1-a1aa-aa1a111a1111==
> 9f8ef0798838: end
[23:28:11.254] Received install output:
SSH_AUTH_SOCK====
DISPLAY====
webUiAccessToken====listeningOn==38709==
osReleaseId==ubuntu==
arch==x86_64==
vscodeArch==x64==
bitness==64==
tmpDir==/run/user/1012==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime==91==
connectionToken==a11111a1-11a1-1aa1-a1aa-aa1a111a1111==

[23:28:11.255] Remote server is listening on port 38709
[23:28:11.255] Parsed server configuration: {"serverConfiguration":{"remoteListeningOn":{"port":38709},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","sshAuthSock":"","display":"","tmpDir":"/run/user/1012","platform":"linux","connectionToken":"a11111a1-11a1-1aa1-a1aa-aa1a111a1111"},"serverStartTime":91,"installUnpackCode":""}
[23:28:11.259] Persisting server connection details to /home/avishka/.config/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-c940f595-f1b07bd25dfad64b0167beb15359ae573aecd2cc-0.106.5-tr/data.json
[23:28:11.265] Starting forwarding server. local port 46081 -> socksPort 33111 -> remotePort 38709
[23:28:11.266] Forwarding server listening on port 46081
[23:28:11.267] Waiting for ssh tunnel to be ready
[23:28:11.268] [Forwarding server port 46081] Got connection 0
[23:28:11.270] Tunneled port 38709 to local port 46081
[23:28:11.271] Resolved "ssh-remote+<IP_ADDRESS>" to "port 46081"
[23:28:11.280] ------

[23:28:11.306] [Forwarding server port 46081] Got connection 1
[23:28:13.601] > local-server-1> Timed out
[23:28:13.608] Local server exit: 0

Looks like a duplicate to https://github.com/microsoft/vscode/issues/195617
Same bug is affecting WSL connections with remote.

It's a duplicate of https://github.com/microsoft/vscode/issues/195617#issuecomment-1773202568 , please follow steps in https://github.com/microsoft/vscode/issues/195617#issuecomment-1773202568 to upgrade Pylance to have this issue fixed, thanks!


Clicking on a symbol opens an empty tab

Clicking on a symbol opens an empty tab, called "extensions"

Running Symbol Tree View 0.1.5 and VSCode 1.12.2

Hello thank you for reporting this issue, I'll look into it as soon as I get near my PC

Hello, I cannot reproduce this after some testing I did, can you give me some more info, which filetype this happens for, how often this occurs, is it reproducable? Thank you in advance!

go and ts files, occurs every single time (100% reproducible)

also in .lua files

i wish we could just get the ctrl+shift+o menu to stay open in a sidebar


Recomendation for implementing VideoJs-vast-plugin with Playlists?

Can you suggest the best way to implement playlists with your plugin?
Ideally, an ad opportunity would be available at the beginning of each new video in the playlist.
regards,
Bob

@bkolo you can see an example of that in our page:
http://www.dailymail.co.uk/news/article-3211338/House-millionaires-resort-John-Lennon-bought-bungalow-aunt-raised-son-goes-sale-4-5million.html#video
I wasn't involved on that but I think videoplayer has a method that allows you to change the video src. So the moment you change the src and you play it, the plugin should try to preroll the ad's.


[NEW ICON] Playwright

Skill Name
Playwright
Why?
Playwright is a popular E-2-E testing tool these days. I have cypress and jest, but I don't have playwright, so I'm posting this as an issue.
Reference Image

up!

+1


KYLIN-3663 fix deleting project error when project has more than one …

…table

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 3831

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 23.616%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
5
77.81%

Totals

Change from base Build 3829:
-0.002%

Covered Lines:
16812

Relevant Lines:
71188

💛  - Coveralls

retest this please


[TC-785] Supervisor Dash UI (version 1)

TC-0785
Objective:

Something failing in the test pipeline? Needing the seed PR in first?


[Feature Request]: Neo4j adapter

Description
Gotten few requests for Neo4j, never worked with Neo4j but it seems to support transactions so it should be possible.

I'm closing this since I really doubt there's enough interest for Neo4j. Happy to continue the discussion if people are interested tho


[ImgBot] Optimize images

The [ImgBot] wanted to contribute xD

@ahmedrowaihi What does this do? Can you link me to the ImgBot?

@shadcn All it does is automated Image optimisations in your repo
here is the link to the bot you can check
ImgBot


TST: stats: mark many dimension permutation t-test slow

Reference issue
gh-4824
What does this implement/fix?
Slowest test right now is
6.72s call     stats/tests/test_stats.py::Test_ttest_ind_permutations::test_ttest_ind_permutations_many_dims

It doesn't need to run all the time, so marking it slow.

Reference issue
gh-4824
What does this implement/fix?
Slowest test right now is
6.72s call     stats/tests/test_stats.py::Test_ttest_ind_permutations::test_ttest_ind_permutations_many_dims

It doesn't need to run all the time, so marking it slow.

ok, this seems pretty obvious. At one point I thought we had in the test output for the builds a listing of the top K slowest tests (IIRC K==10). Did we drop that w/the move away from travis?
Reason I ask is b/c I'm not seeing it in any of the builds so I guess you checked this manually?

Reference issue
gh-4824
What does this implement/fix?
Slowest test right now is
6.72s call     stats/tests/test_stats.py::Test_ttest_ind_permutations::test_ttest_ind_permutations_many_dims

It doesn't need to run all the time, so marking it slow.

ok, this seems pretty obvious. At one point I thought we had in the test output for the builds a listing of the top K slowest tests (IIRC K==10). Did we drop that w/the move away from travis?
Reason I ask is b/c I'm not seeing it in any of the builds so I guess you checked this manually?

I noticed it in some other PRs CI logs recently. Thanks!

I noticed it in some other PRs CI logs recently. Thanks!


Nothing being rendered at all

Hello,
I'm already sure I'm doing something stupidly wrong, but this is extremely frustrating since I cannot locate the issue.
Basically I'm trying to draw ANYTHING using this Draw() method:
public const float lim = 1000;
private void Draw(object sender, OpenGLRoutedEventArgs args)
        {
            var gl = args.OpenGL;

            gl.Clear(OpenGL.GL_COLOR_BUFFER_BIT | OpenGL.GL_DEPTH_BUFFER_BIT);
            gl.LoadIdentity();
            gl.LineWidth(10.0f);
            gl.PointSize(2.0f);

            gl.Color(1, 1, 1);

            // y axis
            gl.Begin(BeginMode.Lines);
            gl.Vertex(-lim, 0);
            gl.Vertex(lim, 0);
            gl.End();

            // x axis
            gl.Begin(BeginMode.Lines);
            gl.Vertex(0, -lim);
            gl.Vertex(0, lim);
            gl.End();

            for (int i = 0; i < 500; i++)
            {
                gl.Begin(BeginMode.TriangleFan);
                var Segments = 50;
                var radius = 1000;
                var Position = new Vector2(i, i);
                for (var a = 0; a < Segments; a++)
                {
                    float theta = 2f * MathF.PI * a / Segments;
                    float x = radius * MathF.Sin(theta);
                    float y = radius * MathF.Cos(theta);
                    gl.Vertex(Position.X + x, Position.Y + y);
                }
                gl.End();
            }

            gl.Flush();
        }

But I'm only ever getting a black screen (with the FPS counter working fine).
I've tried comparing my code to this sample, but I really cannot find the problem.
As you can see from the code, I have already made desperate, frustrated attempts to draw large cirlces ANYWHERE, with no success whatsoever.
What am I missing?

I have the exact same problem. It looks like none of gl.Draw* (* <- Elements, Arrays etc) functions have any effect

I've also noticed that OpenGL generates InvalidOperation error before each draw call.
Suppose this method is called each time OpenGLDraw event is raised for OpenGLControl.
    private void DicomGLViewer_OpenGLDraw(object sender, OpenGLRoutedEventArgs args)
    {
        if (GL is not null) OpenGLHelpers.ThrowIfGLError(GL);

        //while (gl.GetErrorCode() is not ErrorCode.NoError);

        GL?.Clear(OpenGL.GL_COLOR_BUFFER_BIT);
        glState?.DrawVertices(CurrentDepth);
    }

And ThrowIfGLError looks like this:
public static class OpenGLHelpers
{
    ...
    public static void ThrowIfGLError(OpenGL gl)
    {
        var error = gl.GetErrorCode();
        switch (error)
        {
            case ErrorCode.NoError:

                break;

            case (var other):
                throw new Exception(gl.GetErrorDescription(Convert.ToUInt32(other)));
        }
    }
}

It throws with 'Invalid Operation' OpenGL error
So this error occurs before doing anything.
My opengl initialization (after OpenGLInitialized event) doesn't produce any errors, so this is quite strange.


Added some documentation for the diffusion prior in README.md

This PR is in response to https://github.com/lucidrains/DALLE2-pytorch/issues/58
K

@krish240574 looks good! but it seems like you reverted some changes i made to the readme
i think there is some issue with how you merged?

yes, I probably screwed up the merge - should I undo my changes?

@krish240574 yup! you should definitely go through the pain of this :smiley:  nobody likes merges in industry (including me) but it is a necessary skill! :laughing:

I'm fixing the merge, no worries. I'll revert in a bit. AArgh.

@krish240574 there's a nice GUI tool out there, called https://www.sublimemerge.com/ may help you

@lucidrains, thank you, I appreciate the infinite patience !


Allow to select a projection in the demo

Actions

[ ] Add a companion <h3-worldmap-projection-select> web component to select projection
[ ] Complete available projections from @d3/projection-comparison Observable notebook
[ ] Check whether we should not replace dependency on d3 with d3-geo

Sample markup
Something along:
<h3-worldmap-demo>
  <h3-worldmap projection="…" areas="[ …, …, …]" …></h3-worldmap>
  <h3-worldmap-projection-select @onSelect=…></<h3-worldmap-projection-select>
</h3-worldmap-demo>

… with properties .value , .options and .selectedIndex on the <h3-worldmap-projection-select> web component, as for the <select> of HTML — difference being that the .options will be the AVAILABLE_PROJECTIONS hashmap (see src/defs/projections.js).

@olange Please review the PR#25 which implements the first Action above.


Show icons for code completion options

The second PR based on #29626

Show different icons for different type of completion options

Wow, that's great ! It looks really pro.

I see a lot of flickering, because you probably use Nvidia + Linux, so I recommend to recording a videos with SimpleScreenRecorder, which change some Nvidia settings.

It was mentioned in #30297 that the readability could be improved by spacing the icon and associated text somewhat further apart.  Perhaps an extra pixel or two margin can help?

@Paulb23  Make the icon  as property of ScriptCodeCompletionOption and moved the icon definitions from text_edit.cpp to code_editor.cpp.
Also add space between the icons and titles.
@akien-mga  Rebased to master and droped the commit in #29626

Removed the editor hint checking in code_editor.cpp

Thanks for this beta feature!


Y Axis labels misalign

As you can see below, some of the labels are a full line above the very top label

codpen

My colleague thinks it's because the longer the label text is the further to the right the "center" of the text will be. And then when the label gets rotated 90 degrees, it rotates on different center.

Please provide a valid codepen for the issue.
Your provided codepen opens a wrong pen.
Closing it as not reproducible.

I was able to reproduce it and fixed it.


Flesh out error scenarios

There are quite a few permutations of error scenarios for both the publisher sending an event in, and errors encountered by subscribers trying to process events they receive - these will need fleshing out and describing to set expectations about behaviours of each party.

See comment added to Issue 1

Additional guidance around potential errors will be added as part of uplifts to the spec for validation of the publication API. Additional guidance was added for the subscription api pointing towards the structure of the errors and error code value set. If we need more detail we can add it later but the current level of detail should allow suppliers to build and handle errors correctly so closing this issue.


flac: 1.4.1 -> 1.4.2

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

We already have 4e74b208417

@vcunat, one difference is that that commit doesn't use the official release checksum as published by upstream. Would a rebase of this PR on that commit be useful or is that not considered a benefit?

That's a disputed topic actually: https://github.com/NixOS/rfcs/pull/131

@vcunat is there anything specific about situations where upstream has an officially published hash? I'm only seeing general discussion about mandating the SRI format, might bring up the specific scenario there if it's been overlooked so far.

The scenario is discussed there explicitly.  The main argument against the current proposal.  At least that's how I see it.

Ah, yes. It's literally the first thread of comments. When skimming it that thread seemed to be about people not knowing what SRI is.
I guess I'll just give up at this point. The expression was using the upstream hash until now and IMO that's a valuable thing to give up on but I don't feel like tilting at windmills.


fix(core): set isPressed to true on blur and contextmenu events if permant keypress is enabled

🚀 What's changed?

set isPressed to true on blur and contextmenu events if permant keypress is enabled

🐛 Fixes

[x] #1648

Hello, I tried to fix the issue
This is what I did:
I've updated the useKeyPress composable to address the issue with permanent keypress handling. The main change is in the reset function, where we now check if the keypress should be permanent before resetting the isPressed value. This ensures that the isPressed state remains true for 'blur' and 'contextmenu' events when permanent keypress is enabled.
Here's a summary of the changes:

Added a new parameter isPermanent to the reset function.
Modified the reset function to only set isPressed to false if isPermanent is false.
Updated the event listeners for 'blur' and 'contextmenu' to call reset(true), indicating a permanent keypress.
Modified the keyup event handler to call reset(false), allowing the keypress to be released.

These changes should fix the issue described in #1648 while maintaining the existing functionality for non-permanent keypresses.
I also created pull request: https://github.com/bcakmakoglu/vue-flow/pull/1668

[!CAUTION]
Disclaimer: This fix was created by Latta AI and you should never merge before you check the correctness of generated code!
The fix provided by Latta AI might not be complete and it can serve as an inspiration.**

This bug was fixed for free by Latta AI - https://latta.ai/ourmission
If you no longer want Latta AI to attempt fixing issues on your repository, you can block this account.


Too many returns on where().equals()

I have in my application a dexie query where afterwards the code starts to run several times.
I wrote more details here: https://stackoverflow.com/questions/46941851/why-is-the-code-running-several-times-from-here-on
As I wrote I expect to get only one Collection and not many. At least according to the documentation it should be like this.
I tested it with dexie Version 2.0.1 and Firefox 56 and Chrome 62.

Thanks for reminding. I just answered the question on stackoverflow.

Thanks.. I wrote a comment. Maybe you see something wrong in the fiddle.

Closing this issue as it was solved over phone. Thanks!


Save and sync extensions to the cloud

I would like to use my outlook account (or other Microsoft account) to save and sync settings and extensions across all my machines running Visual Studio Code.

Duplicate of https://github.com/Microsoft/vscode/issues/2743
There's a settings sync extension that can help with this: https://marketplace.visualstudio.com/items?itemName=Shan.code-settings-sync


“Store the articles in collections folders” setting is ignored if “All bookmarks” is selected

If either “All bookmarks” is selected, or no specific collections are selected under the “Manage collections to be synced” section, the setting “Store the articles in collections folders” is ignored, and all bookmarks are dumped into the root folder regardless of the setting.
(And, I gotta say, figuring out why this kept happening gave me a few more grey hairs!)

Related to #67. But, this being the default, out-of-box behavior is troublesome.

I've tested your condition:

All bookmarks + Store the articles in collections folders + Collection folder = /: bookmarks are dump to /All Bookmarks as expected
no specific collections are selected under the “Manage collections to be synced”: no bookmarks are synced

BTW. All bookmarks in Raindrop is a collection

I think what @talkingwires wanted is to be able to select all collections (Unsorted and every collections in the account, but automatically like using All bookmarks), and create a folder for each inside Obsidian. The main struggle would then be to manage how to sync the moving of links from one collection to another (moving it in Obsidian too ?).
If we want to do that, we currently need to manually select each newly added collection to the settings which isn't ideal.
But it seems it would involve a proper sync management to prevent duplicates after moving items between collections, I reckon it might be slightly harder than just allowing to auto-select all collections at each Obsidian restarts.


Is it possible to get this to work Microsoft To Do?

There was a previous HA addon which enabled To Do tasks to be pulled into HA
https://github.com/black-roland/homeassistant-microsoft-todo
could it be integrated into this addon?

It looks like retrieval of tasks might be possible. I'll have a chew on it. car problems to solve now.

I've had a quick look at the code. It's probably possible to get this working relatively simply.
I note it exposes as a calendar currently, but with no calendar functionality. I guess the intent might have been to have items that have a due and reminder time appear on the calendar in the future. To be honest in my view that is over the top for a task list (and would be quite a lot more work to implement).
I'd suggest having a configuration option which turns on tasks, and then expose them as standard sensors, with the data much as it is now.

Unfortunately I have come to a full stop on this, because the ToDo api is only supported under the MS Office api via the [O365 Python module](https://pypi.org/project/O365/}, and the integration currently uses the MS Graph api. I'll have to see what work it is to get is added to that module.

OK, so I've looked at the O365 Module and the practicality of submitting a PR to it. It looks like a major re-write to the tasks/ToDo classes in there. To be honest it would be far simpler to get the @black-roland integration working.

@JazzMan808 I could do with a view here.
I've written a fair amount of a Pull Request to the underlying O365 module to add the MS Graph functionality to support getting the tasks. This is basic at the moment, it just retrieves the top level task lists and the completed tasks on them. I note that the black-roland integration returns all_tasks and overdue_tasks. I haven't handled overdue yet, but that will be simple to add.
Via the MS Office 365 the O365 module had fairly full functionality across tasks lists and items, including creating new lists and items, plus modify/delete.
I'm interested to know what is important. i.e. The black-roland supports displaying lists and creating a new item on a list. Is that enough or is there a strong desire for more functionality?

Also, at the moment it only gets uncompleted tasks and it will do it for all available lists. Is there a need for completed tasks, or a method to reduce which lists are shown?

Hi @RogerSelwyn
sorry for not getting back to you sooner work and kids, leaves no time to play.
Firstly hope you got over your car troubles and many thanks for looking into this.
Are completed tasks required? No
It would just be task and due date.
for now a simple retrieval of tasks is required no need to create new via API

PR raised here - https://github.com/O365/python-o365/pull/874


Refactor Queue into Queue2

I think this approach can take us pretty far in terms of combinators. The only one I'm not sure about is flatMap, but maybe we should figure out if it makes sense for Queue[E, A, ?] first :-)
TODO in this PR:

[x] filter
[x] contramap
[x] contramapM
[x] zip
[x] zipWith

2019 is the year of profunctors 😄

Totally. We can even wrap two queues along with a copying fiber and get some form of a stream transducer.

@iravid Before I do a detailed review, big question: why the E??

Because of mapM 😂 it’s not very intrusive and doesn’t affect the core implementation at all.

Oh, Queue#flatMap is just mapConcat. Interesting. The things you realize while at the gym...

Now rebased with master. I think I'll leave filter, flatMap and ++ for subsequent PRs because they require some modifications to the implementation that I'd like to discuss with @ghostdogpr separately. So I'll drop filter from this branch and pick it up later.

I ❤ profunctor queues!

Totally. We can probably go all the way to strong and choice if we figure out the appropriate semantics.

Let me know if you want to work on that.

We can even wrap two queues along with a copying fiber and get some form of a stream transducer.

Oh cool. We should try to make it as consistent with Stream. Thinking about it more, Queue really is a kind of push-stream and by splitting the invaraint part, we made it more declarative and easier to compose (like a pull-stream).

Looks like we got some conflicts on Queue, too.

@ghostdogpr What did you think of this one?

Yes indeed, queues are an integrable part of push streams. WRT to consistency with streams, I was thinking that it may make sense to add a ~via~ method to ~Stream~:
trait Stream[R, E, A] {
  def via(q: Queue2[R2, E2, A2, B]): Stream[R2, E2, B]
}

Thanks for the comments! I was waiting to see if this was a good approach. I'll add scaladoc and tests and then log some follow up issues.

And yes, totally into working on strong/choice for this!

@ghostdogpr What did you think of this one?

Looks good! 👍

This is ready for another review @ghostdogpr @jdegoes @regiskuckaertz.

@jdegoes would you like to look before we merge?

Yeah - contramapM and filterInputM may use those. Consider e.g. using contramapM to annotate an incoming message with the system time; or equivalently using filterInputM to filter messages based on time.

@jdegoes let's try and reach consensus here?

@iravid If there are methods that exercise all type parameters, then I'm on board with these changes! 👍
We should figure out naming convention in #607 and try to do something similar for the Queue virtual companion object.

Awesome. I'll resolve the conflicts and then we can continue the naming discussion there.

Would it be more readable if we used I and O (or even In and Out but that may be too long) instead of A and B?

Would it be more readable if we used I and O (or even In and Out but that may be too long) instead of A and B?

Sounds subjective :-) Personally I don't see any improvement in that.


cannot build driver -> error: ‘VFL_TYPE_VIDEO’ undeclared

Getting this output when running make
Debian 10.4
$ make
make -C /lib/modules/4.19.0-9-amd64/build M=/home/jason/GV-USB2-Driver modules
make[1]: Entering directory '/usr/src/linux-headers-4.19.0-9-amd64'
  CC [M]  /home/jason/GV-USB2-Driver/gvusb2-v4l2.o
/home/jason/GV-USB2-Driver/gvusb2-v4l2.c: In function ‘gvusb2_video_register’:
/home/jason/GV-USB2-Driver/gvusb2-v4l2.c:666:42: error: ‘VFL_TYPE_VIDEO’ undeclared (first use in this function); did you mean ‘VFL_TYPE_RADIO’?
  ret = video_register_device(&dev->vdev, VFL_TYPE_VIDEO, -1);
                                          ^~~~~~~~~~~~~~
                                          VFL_TYPE_RADIO
/home/jason/GV-USB2-Driver/gvusb2-v4l2.c:666:42: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [/usr/src/linux-headers-4.19.0-9-common/scripts/Makefile.build:309: /home/jason/GV-USB2-Driver/gvusb2-v4l2.o] Error 1
make[3]: *** [/usr/src/linux-headers-4.19.0-9-common/Makefile:1537: _module_/home/jason/GV-USB2-Driver] Error 2
make[2]: *** [Makefile:146: sub-make] Error 2
make[1]: *** [Makefile:8: all] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.19.0-9-amd64'
make: *** [Makefile:7: all] Error 2

Before Linux 5.7, V4L2 used VFL_TYPE_GRABBER for video devices. 5.7 and later, they changed this to VFL_TYPE_VIDEO. I'm keeping the driver up-to-date with the latest linux kernel, but if you're using an older version (looks like you're using 4.19.0), you can just edit the line to say VFL_TYPE_GRABBER instead of VFL_TYPE_VIDEO and it should work.
Let me know how this works out for you.

@Isaac-Lozano
That did the trick to get it to build. Thanks for the quick reply!
Now I'm running into this when trying to install the modules. Sorry, manually installing drivers is a bit beyond my knowledge...
$ sudo insmod gvusb2-video.ko
insmod: ERROR: could not insert module gvusb2-video.ko: Unknown symbol in module

And then looking at dmesg...

$ dmesg
[  696.457796] gvusb2_video: Unknown symbol vb2_queue_init (err -2)
[  696.457876] gvusb2_video: Unknown symbol video_ioctl2 (err -2)
[  696.457954] gvusb2_video: Unknown symbol v4l2_device_put (err -2)
[  696.457993] gvusb2_video: Unknown symbol vb2_ioctl_streamoff (err -2)
[  696.458033] gvusb2_video: Unknown symbol vb2_ioctl_expbuf (err -2)
[  696.458073] gvusb2_video: Unknown symbol v4l2_i2c_new_subdev_board (err -2)
[  696.458113] gvusb2_video: Unknown symbol vb2_ops_wait_finish (err -2)
[  696.458187] gvusb2_video: Unknown symbol v4l2_ctrl_handler_init_class (err -2)
[  696.458226] gvusb2_video: Unknown symbol vb2_ioctl_querybuf (err -2)
[  696.458261] gvusb2_video: Unknown symbol v4l2_fh_open (err -2)
[  696.458315] gvusb2_video: Unknown symbol v4l2_ctrl_handler_setup (err -2)
[  696.458359] gvusb2_video: Unknown symbol video_devdata (err -2)
[  696.458394] gvusb2_video: Unknown symbol vb2_fop_release (err -2)
[  696.458472] gvusb2_video: Unknown symbol vb2_ioctl_dqbuf (err -2)
[  696.458507] gvusb2_video: Unknown symbol vb2_ioctl_create_bufs (err -2)
[  696.458541] gvusb2_video: Unknown symbol v4l2_ctrl_new_custom (err -2)
[  696.458613] gvusb2_video: Unknown symbol vb2_buffer_done (err -2)
[  696.458647] gvusb2_video: Unknown symbol vb2_plane_vaddr (err -2)
[  696.458681] gvusb2_video: Unknown symbol v4l2_ctrl_subscribe_event (err -2)
[  696.458751] gvusb2_video: Unknown symbol video_unregister_device (err -2)
[  696.458823] gvusb2_video: Unknown symbol vb2_ioctl_qbuf (err -2)
[  696.458858] gvusb2_video: Unknown symbol vb2_fop_mmap (err -2)
[  696.458895] gvusb2_video: Unknown symbol vb2_vmalloc_memops (err -2)
[  696.458931] gvusb2_video: Unknown symbol v4l2_device_disconnect (err -2)
[  696.458965] gvusb2_video: Unknown symbol vb2_fop_read (err -2)
[  696.458999] gvusb2_video: Unknown symbol v4l2_device_register (err -2)
[  696.459054] gvusb2_video: Unknown symbol __video_register_device (err -2)
[  696.459089] gvusb2_video: Unknown symbol vb2_ops_wait_prepare (err -2)
[  696.459159] gvusb2_video: Unknown symbol vb2_ioctl_streamon (err -2)
[  696.459192] gvusb2_video: Unknown symbol vb2_fop_poll (err -2)
[  696.459225] gvusb2_video: Unknown symbol v4l2_ctrl_new_std (err -2)
[  696.459259] gvusb2_video: Unknown symbol v4l2_ctrl_handler_free (err -2)
[  696.459294] gvusb2_video: Unknown symbol v4l2_device_unregister (err -2)
[  696.459327] gvusb2_video: Unknown symbol v4l2_ctrl_log_status (err -2)
[  696.459362] gvusb2_video: Unknown symbol video_device_release_empty (err -2)
[  696.459396] gvusb2_video: Unknown symbol v4l2_event_unsubscribe (err -2)
[  696.459430] gvusb2_video: Unknown symbol vb2_ioctl_reqbufs (err -2)

After doing some tinkering I got the video driver to load by running these commands...
sudo modprobe usbtv sudo modprobe v4l2-common sudo insmod gvusb2-video.ko
However, I still don't have the audio driver loaded even after specifying an index. I have 0,1,2 available and I get
gvusb2-snd 1-9:1.2: cannot find the slot for index 1 (range 0-2), error: -16
No matter which index I choose.

Oh, run cat /proc/asound/cards to list what indices are already in use, then use the next unused index when loading the driver. I assume the 0-2 range is referring to the slot and not the index.

I was able to get the module loaded properly once I selected an unused index. Thank you so much for the help! My audio is coming through very choppy but it may be the software or settings I am using.

The driver spits out 48khz audio, so make sure the software you're using is set to take that sample rate in. Since the initial issue seems to be solved, I'll mark this as closed for now.


italian

Hello,
when I import the zip into flow it doesn't load it and gives error on two missing dependencies.
with the zip in English it works correctly

Ciao @23ale10!
Sorry to hear that. The Italian version was just recently published. Please share a screenshot and we'll make sure to follow up on it 👍

@23ale10 - Please try the new updated Italian version <IP_ADDRESS> 😀✔
We have confirmed that it should solve your issue with importing. Thanks so much!

Solved as of July 12th 👍🙂


rename index.md to overview/sharepoint.md

@TianqiZhang,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

SP-Framework/overview/sharepoint.md
:white_check_mark:Succeeded

SP-Framework/spfx-toc/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

SP-Framework/overview/sharepoint.md
:white_check_mark:Succeeded

SP-Framework/spfx-toc/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature?]: Error Handling with solid-router

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Allow for semantic error handling with server actions.
This is a continuation of https://github.com/solidjs/solid-router/discussions/365 discussion, but focused on solid-start server actions.
The goal is to allow:

return non-200 (401, 500, etc) responses from server actions for observability platforms to monitor how many responses are not 200.
handle such responses in code with reactive useSubmission().error when using without the form.

Proposal: use Response.ok to populate useSubmission().error.
const serverAction = action(() => {
  'use server';
  try {
    return perform();
  } catch(error) {
    // Error is serialised, no queries are revalidated (unless specified otherwise)
    // Response.ok is `false`, so `submission.error` is serialised Error.
    // This will make the action use to fail (as the error is rethrown), so needs try/catch
    return json(new Error('Something went wrong'), { code: 500 });
  }
});

const Component = () => {
  const performAction = useAction(serverAction);
  const submission = useSubmission(serverAction);

  // See example, QR Code scanning
  const userActionWithoutForm = () => {
    try {
      await performAction(); // same as fetch().catch() when the request has failed
    } catch {}
  }

  return (
    <Switch>
      <Match when={submission.pending}>Checking</Match>
      <Match when={submission.error}>Retry with another input</Match>
      <Match when={true}>Perform action</Match>
    </Switch>
  )
}

If the action returns non-Error data, the action does not fail:
// action, does not throw an Error
  return json('Something went wrong', { code: 500 });
// Component
  // similar to fetch(response => response.json()) without checking for response.ok
  await performAction();
  // rely on submission.error being populated with 'Something went wrong' string

Examples 🌈
In the app, users can scan a QR code, when valid code is scanned – action is executed. If scanned code is invalid – error message is shown with Retry logic:
const checkCode = action(async code => {
  "use server";
  try {
    return validity(code);
  } catch(error) {
    // ===Unclear===
  }
});
// component:
const submission = useSubmission(checkCode);
const checkCode = useAction(checkCode);

const onScanned = code => {
  try {
    await checkCode(code);
  } catch(error) {
    // do something, or just ignore it, same way we would do with using fetch directly.
  }
}

return (
  <Switch>
    <Match when={submission.pending}>Checking</Match>
    <Match when={submission.error}>Wrong code</Match>
    <Match when={true}><QRScanner onSuccess={onScanned} /></Match>
  </Switch>
);

Motivation 🔦
Right now, to return non-200 response from a server action, one needs to use custom Response:
'use server';
return Response({ error: 'Something went wrong' }, { code: 500 });

This, however, makes useSubmission(action).error to be empty, because the response is a valid Response:
https://github.com/solidjs/solid-router/blob/e773947b85ac78281816e86621a2cdb6735ae95a/src/data/action.ts#L149
Making the data type from the action ambiguous: { correctResponse } | { error }, which makes handling of the response complicated:
const performAction = useAction(serverAction);
const submission = useSubmission(serverAction);
const [error, setError] = createSignal(null);
const someUserAction = () => {
  try {
    const data = performAction();
    if (data.error) {
      setError(data.error); // but we already have a reactive submission.error!
    } else {} // success logic
  } catch(error) {
    // will never get here
  }
}

So, another option is to make sure submission.error is populated, throw an error from the action.
const serverAction = action(() => {
  'use server';
  throw new Error('Something went wrong');
});

This works for useSubmission().error, but the HTTP Response status is now 200, so one needs custom metrics to monitor how the API is performing.
Doing return json(new Error('error'), { status: 500, revalidate: [] }) is making action to fail itself (?). So 500, but all queries are revalidated (?) and submission.error empty.

Relevant discussion: https://github.com/solidjs/solid-router/issues/387

The reason I bring up the other discussion is this was looked at at length. And I don't want to restart the discussion from blank slate here. There are a lot of details. Where it landed was we would propagate the error field on specifically thrown things and that we would rethrow when not used in a form.
My understanding of the gap right now is that there is no way to both throw and set the HTML status code. I was tempted to make all thrown errors 500s but I think that assumes too much? In general throwing doesn't mean an error in Server functions, and serializing an error doesn't mean they failed.
But generally speaking using .error should be avoided. It can't be typed (because it is unexpected) and it is designed to handle things we aren't aware of. I guess the difference between our solutions and others (Remix/Next) is they would throw in these cases to an error boundary and that is difficult the way things are setup, because there is no connection to the render tree for forms.
The complaint I'm gathering is that having to account for .error is extra work. Like the idea here is:
function SomeComponent() {
  const submission = useSubmission(myAction);

  return <Show when={!submission?.error} fallback={<UnknownError />}>
    {/* Content */}
    <Show when={submission.result}>
      {/* Other Error Stuf */}
    </Show>
  </Show>
}

Like treat .error only as almost an ErrorBoundary, like when you have no clue what happened. Largely this is why I don't want to rely on res.ok as server functions outside of actions are perfectly fine throwing things. It is just a transparent communication.
I'm having a hard time seeing how to handle all the cases outside of the current solution.

I was tempted to make all thrown errors 500s but I think that assumes too much?
Worth checking with other devs and frameworks (maybe even including outside of JS ecosystem). If code throws and not handles the error – is it not a server error? IMO every error should be handled on some level, and generic error re-thrown to not expose error message to the client. Then, assuming that an unexpected error is 500 seems correct.

In general throwing doesn't mean an error in Server functions

Unless it's an instanceof Error (or custom error).

using .error should be avoided. It can't be typed

It's same as try/catch, one has to check the type of the thrown value, it's expected from TS devs.

treat .error only as almost an ErrorBoundary, like when you have no clue what happened.

I thought of .error as "request didn't succeed, handle possible reasons in ways that make sense", so handling specific cases (known error) and generic cases (unknown error).
And <ErrorBoundary> as "error was not handled in the code itself, something completely unexpected happened that makes user flow impossible to recover, show fallback UI to restart the flow".

Trying to take a step back.
action can be used in 2 ways, as useAction(myAction) as <form action={myAction}>. In both of the cases, developer can return json(response, { status }).
In case of <form action={myAction}>, if the action has failed (error was thrown OR non-200 response), the developer is expected to handle the error via submission.error (Note: can they use ErrorBoundary in this case?)
When the action is executed on demand (f.e. 3rd party calls) with const execute = useAction(myAction);,
<QRScanner onSuccess={code => {
  const result = execute(code);
  // next steps
}} />

Should they wrap execute(code) into try/catch? If yes, what's the purpose of catch?
I think yes:
<QRScanner
  onSuccess={(code) => {
    try {
      const result = execute(code);
      // next steps
    } catch (error) {
      // what is error here? should it be deserialized body?
      // or fetch() Response? Then, people can access error.ok or error.json() or whatnot
    }
  }}
/>;

@LexSwed I agree that the last post sounds complete to me. Are we missing anything for this? I think you are describing how it works right now.
<QRScanner
  onSuccess={(code) => {
    try {
      const result = execute(code);
      // next steps
    } catch (error) {
      // what is error here? should it be deserialized body?
      // or fetch() Response? Then, people can access error.ok or error.json() or whatnot
      // but fetch() doesn't `catch` when request didn't fail, it just has response.ok === false
    }
  }}
/>

To answer your question. We generally don't error here unless the function throws on the server or the fetch request fails. So I'm gathering it is the error object.  (ie the deserialized body). Although in your example above where you catch inside the server action this catch would never be hit unless fetch failed. Which yes aligns with your last code snippet.

The difference is in submission. Right now error is only set when

the function throws on the server or the fetch request fails

which means that developer has to take care of different errors differently:
<Switch>
  <Match when={submission.error}>Fetch or function throws</Match>
  <Match when={'error' in submission.result && submission.result.error}>Own error, could be multiple different ones</Match>
</Switch>

While if solid was setting useSubmission().error to any response body that isn't 200 (response.ok):
<Switch>
  // error is the body from json({ errorCode: 5 | 10 }, { status: 422 })
  <Match when={submission.error?.errorCode === 5}>Fetch or function throws</Match>
  <Match when={submission.error?.errorCode === 10}>Own error, could be multiple different ones</Match>
</Switch>

There might be a need for the error handling best practice in solid-start, to draw the line what submission.error means. Because if it's scoped to just fetch request fails or unexpected error, then it's understandable, it's like fetch().catch(). But if the user is allowed to throw Error from the action and handle it in templating, then error handling becomes ambiguous:

throw from actions and handle errors via submission.error? Sure, but you can't specify the response status code (internal error vs validation error).
return json({ error: 'something' }, { status: 422 })? yes, but now handle both, submission.error and 'error' in submission.result && submission.result.error (TypeScript). Which is probably fine, as it makes it easier to understand what action can "throw" as it forces to type narrow the result type.

Not sure anymore tbh. Maybe the solution to my mental model is just discouraging throwing from the actions, and treat submission.error only as unhandled error that always means 500 and that's it.

I solved this issue (sending correct http status codes) the following way:
// utils.ts
import { json } from '@solidjs/router'
import { isDev } from 'solid-js/web'

export class ValidationError extends Error {
  constructor(message: string) {
    super(message)
    this.name = 'ValidationError'
  }
}

export const actionMiddleware = <T extends any[], U = void>(
  fn: (...args: T) => Promise,
) => {
  return async (...args: T): Promise => {
    try {
      return await fn(...args)
    } catch (err) {
      // Thrown redirect
      if (err instanceof Response) return err as never

      // https://github.com/solidjs/solid-start/blob/v1.0.0-rc.1/packages/start/src/runtime/server-handler.ts#L223
      const xError =
        err instanceof Error
          ? err.message
          : typeof err === 'string'
            ? err
            : 'true'

      // Validation error
      if (err instanceof ValidationError) {
        return json(err, {
          status: 400,
          headers: { 'x-error': xError },
        }) as never
      }

      // TODO: Use logger to send error to monitoring service
      console.error(err)

      // Critical runtime error with sanitized message for production
      return json(isDev ? err : new Error('Internal Server Error'), {
        status: 500,
        headers: { 'x-error': xError },
      }) as never
    }
  }
}

It allowed me to keep only business logic with validation inside server functions without the need to repetitively use try catch:
// server.ts
'use server'

import { redirect } from '@solidjs/router'
import { actionMiddleware, ValidationError } from './utils'
import { db, users } from './db'

export const register = actionMiddleware(async (formData: FormData) => {
  const username = String(formData.get('username'))
  const password = String(formData.get('password'))
  if (!username) throw new ValidationError('Username is required')
  if (!password) throw new ValidationError('Password is required')
  await db.transaction(async (trx) => {
    const [existentUser] = await trx
      .select({ id: users.id })
      .from(users)
      .where(eq(users.username, username))
    if (existentUser) throw new ValidationError('Username is taken')
    const [user] = await trx
      .insert(users)
      .values({ username, password })
      .returning({ id: users.id })
    if (!user) throw new Error('Internal error: unable to create a user')
    const session = await getSession()
    await session.update((data) => {
      data.userId = user.id
    })
    return redirect('/')
  })
})

And seams it works fine with both submission.error and action().catch:
import { useAction, useSubmission } from '@solidjs/router'
import { register } from './server'

const registerAction = action(register);

const RegistrationForm = () => {
  const action = useAction(registerAction);
  const submission = useSubmission(registerAction);

  const perform = async (event) => {
    try {
      await action(new FormData())
    } catch (err) {
      console.error(err)
    }
  }

  return (
    <form action={register} method="post">
      <input type="text" name="username" />
      <input type="password" name="password" />
      <button type="submit">Send Form</button>
      <button type="button" onClick={perform}>Perform Action</button>

submission.error: {JSON.stringify(submission.error)}

    </form>
  )
}

So, from what I'm gathering in all these conversations @ryansolid - is the preferred idea to only use the error if a action truly fails?
All other things, send a result but with diff data? Something like the example below?
Example:
interface Result<T extends Record<string, unknown>> {
   data: T | null
   error: {
      code: string
      status: 400 | 500 // all the status codes
      message: string
   } | null
}

// db/something.ts
async function createUser(body: User): Promise<Result> {
   // This checks the response.ok to send whatever error Obj if not
   return await db(body)
}

// forms/something.tsx
const formAction = action(async (formData) => {
  try {
    const {} await createUser({
      ...parsedFormData,
    })

   // if you need to track specific codes to log to an Sentry, etc. - do it here by
  } catch {
    // This triggers an ErrorBoundary bc it means the app is probably toast
    throw Error('Something bad happened')
  }
})

export function SomethingForm() {
  const submission = useSubmission(formAction)

  return(
    <>
       <Show when={submission.result?.error}>
          {submission.result!.error.message}
       </Show>

       <form>...</form>
    </>
  )
}

If so, I can support this. Supabase uses the same model I think where it always sends back a successful result that prevents an app crash but with a Result that is similar to the above interface?


Fixed #24365 -- Made inspectdb handle positive integer fields on MySQL.

Ticket 24365.

Would it be possible to create a test case based on the reporter description? (Create a table with a positive integer column using raw SQL, run a migration to add a foreign key constraint on that column and check that MySQL does not complain).

We already have the appropriate test.


Hover effect missing on buttons at wallet dialog

It seems to have a hover effect on the change account and border on the light mode
https://user-images.githubusercontent.com/5887929/210402441-b36f1cf7-f7a0-4968-b7d6-5150ba019b91.mov

👋🏻


Exported C types in external API

Robotgo version (or commit ref): current master
Go version: doesn't apply
Gcc version:
Operating system and bit:
Can you reproduce the bug at Examples:

[ ] Yes (provide example code)
[ ] No
[x] Not relevant
...

Description
I was reading the CGo documentation, especially this part:

Cgo translates C types into equivalent unexported Go types. Because the translations are unexported, a Go package should not expose C types in its exported API: a C type used in one Go package is different from the same C type used in another.

After reading the project source for a bit I noticed that some functions, like those in the bitmap category, are exposing some C types in the API, like:
// BitmapStr bitmap from string
func BitmapStr(str string) C.MMBitmapRef {
	cs := C.CString(str)
	bit := C.bitmap_from_string(cs)
	defer C.free(unsafe.Pointer(cs))

	return bit
}

This could be causing some compatibility issues with the users, as they can't use the return value with outside functions.

Closed because there is no need to discuss and dogma.


Doesn't Work with Angularjs 1.4.7

I took the demo and used angularjs 1.4.7 and angular-sanatize 1.4.7 and there are injection errors. I posted the fiddle here: https://jsfiddle.net/3c46b4p3/
Thanks

@cpitzak Please update the latest ng-csv file.
This one is working. https://jsfiddle.net/3c46b4p3/1/

see #129


Abstract message meaning from cause and clarify causes.

Meaning should be "Notifies a window that the user desires a context menu to appear."
The current document states "Notifies a window that the user clicked the right mouse button" which is
sent via messages such as WM_RBUTTONDOWN.

@definedrisk : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Villager not Giving Item

Describe the bug
No error appears in the latest.log/console, but as my attached video demonstrates, the villager correctly shows me the desired output item, but when I click on the output item, it simply refunds me my two starting materials.
To Reproduce
(https://gyazo.com/74ddcd539142958fbf946adfc20703db)
Expected behavior
To give the item that is showed in the hover window.
Screenshots
(https://gyazo.com/74ddcd539142958fbf946adfc20703db)
Server Software and Version:

Vendor: Paper
Minecraft Version: 1.18.1
Output of /version command: This server is running Paper version git-Paper-129 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: d0b8b1e)
You are 23 version(s) behind
Download the new version at: https://papermc.io/downloads
Previous version: git-Paper-58 (MC: 1.18)

Additional context
Thank you, hopefully this is just a user issue and you can tell me what I'm doing wrong! I love the plugin and would really love to use it!

Something is causing a discrepancy between the item saved in the config and the ones you have in game. You can use Paper's dump item command and vanilla's entity data commands to find out what the difference is, and from there it can be further debugged, this is likely not a WanderingTrades issue but I will leave this open awaiting more details.


feat: add file-format key to use track id as saved filename

add -k option to keep track_id as name instead of song_title

It would be a better idea to have something like this possible with the already existing file-format parameter. However, it will probably take a little more effort than this PR.
@kadaliao If you were to go that way, you'll need to take a look at how file-format works (in internals.py) and then add a key for Spotify Track ID. Also, take a look at Set custom filenames for more info.

will do.

@kadaliao Awesome! Let me know if you need help with anything.

@ritiek adding track_id key to file-format parameter is not only better but also a simpler solution.
Please check it out.
I guess the wiki would also be updated accordingly.

Need to investigate.

@linusg Yeah, it would be probably be nicer if we could just use lists.


Deduplicate exports.render_signup_notifications_stream_ui and exports.render_notifications_stream_ui

These now have the same code aside from the name of the HTML element.

@zulipbot claim


Support thread token based process start winpty-agent

winpty.dll uses current process's token to start winpty-agent. It can support thread token based if winpty.dll is used within Windows Service and impersonation.

PR: https://github.com/rprichard/winpty/pull/133


chore(bitcoin): bump Bitcoin Core to v27.1

Describe the changes and your approach

Verification Checklist

[x] I performed a self-review of my changes and approve them.
[ ] I checked of the automated test results for any irregularities.
[ ] I manually tested the code changes on my local environment.
[ ] I considered changes to the README or test docs. (Check if not applicable.)

The tag exists but the tarball package doesn't. Setting as draft for now.


Randomly select a font

This will load all the fonts from the folder ./fonts and randomly select one for each test image.  This is a possible fix to Issue #1.

Thanks for the fix! I also fixed a bug where fonts were being regenerated for each batch (which becomes significant when dealing with a large number of fonts), and updated the README with where to put the fonts.


Any replacement for CAtlFileMapping?

I am looking for a winrt replacement for CAtlFileMapping from <atlfile.h>, and can't find one. why?

I'm not aware of a WinRT API for memory-mapped files.

I believe you can either keep using CAtlFileMapping, or if you want to get rid of ATL entirely, you can use the raw Win32 memory mapped file API: https://docs.microsoft.com/en-us/windows/win32/memory/file-mapping


Clean up of MORK and example code to utilize all modern Objective-C syntax

Utilize all modern objective-c in MORK and objective-c example such as subscripting and dot syntax

I'll tackle this.

:+1:


Rule 18.7.2 (L1) Ensure 'Configure Redirection Guard' is set to 'Enabled: Redirection Guard Enabled'

Describe the Issue
If manually set using GPEDIT correct value is 1
Expected Behavior
value set to 1
Actual Behavior
value set to 2
Control(s) Affected
"18.7.2 | PATCH | Ensure Configure Redirection Guard is set to Enabled Redirection Guard Enabled"
Environment (please complete the following information):

branch being used:  devel

Possible Solution
- name: "18.7.2 | PATCH | Ensure Configure Redirection Guard is set to Enabled Redirection Guard Enabled"
ansible.windows.win_regedit:
path: HKLM:\Software\Policies\Microsoft\Windows NT\Printers
name: RedirectionguardPolicy
data: 1
type: dword
when:
- win19cis_rule_18_7_2
tags:
- level1-domaincontroller
- level2-memberserver
- rule_18.7.2
- patch
- printers

Good catch @animatco
RedirectionguardPolicy
Thank you!
CC: @MrSteve81

Fix merged in #95


cant connect at all!

[2020-01-04 20:30:37.588]: main - Starting PSMoveService v0.9-alpha 9.0.1 (protocol v0.9-alpha 9.0.0)
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\USBManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\USBManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\NetworkManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\NetworkManagerConfig.json"
[2020-01-04 20:30:37.597]: USBAsyncRequestManager::startup - Requested LibUSBApi
[2020-01-04 20:30:37.598]: USBAsyncRequestManager::startup - Creating LibUSBApi
[2020-01-04 20:30:37.600]: USBAsyncRequestManager::startup - Initialized USB API
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\DeviceManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\DeviceManagerConfig.json"
[2020-01-04 20:30:37.604]: DeviceManager::startup - Platform Hotplug API is ENABLED
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\ControllerManagerConfig.json"
[2020-01-04 20:30:37.608]: ControllerManagerConfig - Config version 0 does not match expected version 1, Using defaults.
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\ControllerManagerConfig.json"
[2020-01-04 20:30:37.729]: bluetooth_get_host_address - Found a bluetooth radio
[2020-01-04 20:30:37.732]: bluetooth_get_host_address - Retrieved radio info
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\TrackerManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\TrackerManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\HMDManagerConfig.json"
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\HMDManagerConfig.json"
libusb: error [init_device] device '\.\USB#VID_046D&PID_C52B&MI_01#6&1827DC53&0&0001' is no longer connected!
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
[2020-01-04 20:30:37.861]: PSMoveController::open - Opening PSMoveController(\?\hid#vid_054c&pid_03d5&col01#6&340297cf&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030})
[2020-01-04 20:30:37.864]: PSMoveController::open -   with EMPTY serial_number
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\00_06_f5_21_cb_b5.json"
[2020-01-04 20:30:37.927]: testMagnetometer - Failed to open read initial controller state after 10 attempts.
[2020-01-04 20:30:37.929]: WorkerThread::start - Starting worker thread: PSMoveSensorProcessor
Config file name: "C:\Users\AdamI\AppData\Roaming\PSMoveService\00_06_f5_21_cb_b5.json"
[2020-01-04 20:30:37.935]: DeviceTypeManager::update_connected_devices - Device device_id 0 (PSMove) opened
libusb: error [init_device] device '\.\USB#VID_046D&PID_C52B&MI_01#6&1827DC53&0&0001' is no longer connected!
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent
libusb: error [windows_get_device_list] program assertion failed - existing device should share parent

This is what I get Im currently using windows

Its not connecting for some odd reason and quite frustating PLEASEEEE HALLPP


[Bug]: shadcn-nuxt when the buildDir is changed an error is thrown ENOENT: no such file or directory, stat 'PROJECT_PATH/.nuxt/tsconfig.json'

Reproduction
https://stackblitz.com/edit/github-gxjekn?file=nuxt.config.ts
Describe the bug
when changing the buildDir from nuxt.config.ts the cli throws an error when generating new components ENOENT: no such file or directory, stat 'PROJECT_PATH/.nuxt/tsconfig.json'.

System Info
- Operating System: `Darwin`
- Node Version:     `v20.11.0`
- Nuxt Version:     `3.11.1`
- CLI Version:      `3.11.1`
- Nitro Version:    `2.9.4`
- Package Manager<EMAIL_ADDRESS>- Builder:          `-`
- User Config:      `devtools`, `app`, `modules`, `shadcn`
- Runtime Modules:  `<EMAIL_ADDRESS><EMAIL_ADDRESS>- Build Modules:    `-`

Contributes

[X] I am willing to submit a PR to fix this issue
[x] I am willing to submit a PR with failing tests

I have found the cause of the issue :)
In packages/cli/src/utils/get-config.ts on line 71 the buildDir is being accessed with static string.nuxt
let tsConfigPath = path.resolve(
    cwd,
    config.framework === 'nuxt' ? '.nuxt/tsconfig.json' : './tsconfig.json',
  )

I will check later if I have time to try to pass the buildDir from maybe components.json or nuxt.config as it's only affecting Nuxt?
Thanks

As nuxt will generate a custom tsconfig.json in .nuxt folder, thus we are referencing that. Can you help check if .nuxt folder exist in your project? 😁

@zernonia I have submitted a pr to resolve this issue pr let me know if anything need to be modified


routes not working after upgrading from 5.2 to 5.4

Laravel Version: 5.2.X
PHP Version: 7
Database Driver & Version: mongodb 3.4.3

Description:
I have upgraded my laravel 5.2 application into 5.3, i have also remove boot parameter from the providers. When i tried to run application, i am getting 404 not found. my all routes working fine with previous version, but after upgrade none of them working. i have also customized auth in my way too.
Steps To Reproduce:

take laravel 5.2 app with auth.
change composer.json laravel/framework version too 5.3
run composer update
remove boot parameter.
check all routes.

not here i am getting 404 error.

i have also remove boot parameter from the providers

I wonder why your routes might not be working... 🤔
It's hard to tell what you mean by remove boot parameter.

Your issue says 5.3 but title says 5.4 :thinking:
Also your "Steps To Reproduce" is too generic at this point.

Have you followed the exact steps as described in the upgrade guide? https://laravel.com/docs/5.3/upgrade

Please ask on the forums.


Add log_in tag in navbar

in this commit log in tag was missing and i have added it in order to have login signup tags on the main page for not logged in users.

closes #100

why not adding the url for the login page? the template already exists.

why not adding the url for the login page? the template already exists.

I dont understand

why not adding the url for the login page? the template already exists.

I dont understand

nvm didnt notice the href.👍

LGTM


BUG

daemon builder is not fix
Until the problem is resolved
I try to install coins directly on the root

Does not work
Most parts have problems with the site template
Other sections of the coin settings are empty   -
..................................................................................................................................................................

It's now fit and the yiimp is mineable but its still Hex #FFF on the main page, that will bee fixed soon.

And the DaemonBuilder works again.
´But the fix is not live yet you can use the dev branch mean while: to install the dev branch use:
curl https://raw.githubusercontent.com/Afiniel-tech/Yiimpool-Installer/dev-v1.0.3/bootstrap.sh | bash
Main branch come with more fixes soon. Regards Afiniel, and please open issue again if you find another issue :)


ziggy not included base url

ziggy not included base url
like http://hostname/myproject/public/backend/blog/add
ziggy just retrive backend/blog/add
*i not use php artisan serve for that
if i use php artisan serve it's running
how to setup it ?
thanks

I see that the fix is already in the master branch. The line 22 in UrlBuilder.js was missing in both builded scripts, even though it existed in the source files. Is it possible to tag this commit 77dce9f4a54000ebcf70b6bf5c619a8d99c33617 with v.0.6.1, so that it can be referenced with composer?

Until this gets tagged (I'll leave it up to @DanielCoulbourne to tag a release) you can require that commit in your project using:
composer require tightenco/ziggy:dev-master#77dce9f

Yup, I wanted to do that, but I didn't like the idea to allow dev-branches in my composer json, so I installed the composer-patches package and added a patch. But luckily, @DanielCoulbourne already added the tag, so I don't have to worry about this anymore. Thanks!

Oh sweet, I didn't even check for that. I'll close this issue as resolved by v0.6.1


Fix empty item in explorer after clicking on Collapse Folders action while editing new file/folder

This PR fixes #96846

Call this.tree.domFocus in the collapseAll method only if we are editing the explorer to cancel it.
Add a cancelEditing (default true) parameter to the refresh method, the only place we don't want to cancel edit while refreshing is in the setEditable method. With this change the timeout in explorerViewer is not necessary.

Tested this locally on Ubuntu 18.04 on #96846, #96198, #9656

Tried it out and it looks great. Also awesome that you removed the timeout!
Thanks a lot for improving the explorer ☀


Quick fix for Azure AD B2C

Fix CanonicalAuthorityURI handling and add default Azure AD B2C domain (.b2clogin.com) as trusted authority host domain.
Theese two changes makes the library works with Azure AD B2C (and user flows).
Maybe not this is the best way to fix the problem, but other solutions would require significant refactor in code.

@microsoft-github-policy-service agree

@chlowell any chance to get this or a similar fix in? Thanks!

B2C isn't supported yet (see #32), so I imagine we need more than a quick fix. However, I don't know what all is required to support B2C, so I'm not equipped to evaluate this PR from that perspective. Setting that aside, we'd certainly need tests before taking a change like this. I'm afraid I don't have much to contribute there either because I also don't know what testing is required for B2C. FYI @bgavrilMS

It looks like the "about" description part of the repository is misleading and could be improved:
It uses industry standard OAuth2 and OpenID Connect. The library also supports Azure AD B2C.

Yeah, we'd also need to disable instance discovery similar to ADFS authorities, probably have an authority_type property that can be used elsewhere and have tests.
I updated the "About".

I am going to reject this. We will not be adding B2C support to MSAL GO.

Would you mind documenting that as a limitation of this library?
From an external point of view, I would assume the target is to have feature parity on a framework level for all supported languages.
https://github.com/AzureAD/microsoft-authentication-library-for-python/pull/104
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/8c1c63df4be8e057eb3e08e0ce086570b0fd9ac0/lib/msal-browser/docs/working-with-b2c.md

Yes, but there is a new offering called CIAM that superseeds B2C. While MSAL GO doesn't support CIAM, we would want new apps to target B2C.
https://github.com/Azure-Samples/ms-identity-ciam-dotnet-tutorial


build failed on macOS

Scanning dependencies of target cleos
[ 97%] Building CXX object programs/cleos/CMakeFiles/cleos.dir/main.cpp.o
[ 97%] Building CXX object tests/CMakeFiles/chain_test.dir/chain_tests/proof_tests.cpp.o
[ 98%] Building CXX object tests/CMakeFiles/chain_test.dir/chain_tests/recovery_tests.cpp.o
[ 98%] Building CXX object tests/CMakeFiles/chain_test.dir/api_tests/api_tests.cpp.o
[ 99%] Building CXX object programs/cleos/CMakeFiles/cleos.dir/httpc.cpp.o
[ 99%] Building CXX object programs/cleos/CMakeFiles/cleos.dir/help_text.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/tests/abi_tests.cpp.o
[ 99%] Linking CXX executable cleos
Undefined symbols for architecture x86_64:
"_libintl_bindtextdomain", referenced from:
_main in main.cpp.o
"_libintl_gettext", referenced from:
eosio::client::localize::localized_with_variant(char const*, fc::variant_object const&) in main.cpp.o
eosio::client::localize::localized_with_variant(char const*, fc::variant_object const&) in help_text.cpp.o
"_libintl_setlocale", referenced from:
_main in main.cpp.o
"_libintl_textdomain", referenced from:
_main in main.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [programs/cleos/cleos] Error 1
make[1]: *** [programs/cleos/CMakeFiles/cleos.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/tests/database_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/tests/misc_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/currency_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/dice_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/eosio.system_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/eosio.token_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/exchange_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/identity_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/multi_index_tests.cpp.o
[ 99%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/multisig_tests.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/payloadless_tests.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/tic_tac_toe_tests.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/wasm_tests/wasm_tests.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/tests/special_accounts_tests.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/tests/wallet_tests.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/library_tests/chain/resource_limits_test.cpp.o
[100%] Building CXX object tests/CMakeFiles/chain_test.dir/common/main.cpp.o
[100%] Linking CXX executable chain_test
[100%] Built target chain_test
make: *** [all] Error 2
>>>>>>>>>>>>>>>>>>>> MAKE building EOSIO has exited with the above error.

@hoopslb This may be the solution:
https://github.com/EOSIO/eos/issues/2028

@pacificcode
successfully built
I do this：
brew unlink gettext && brew link --force gettext
find /usr -name libintl* -print 2>/dev/null

It is works ! :)


libvpx: Fix heap buffer overflow in vp8 encoder

Applies only the relevant code changes, as the test changes don't apply cleanly.
https://www.openwall.com/lists/oss-security/2023/09/28/5
Fixes: CVE-2023-5217
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Estimating rebuild amount by counting changed Hydra jobs (parallel=unset).
   2085 x86_64-darwin
   5921 x86_64-linux

It took a while unfortunately, but I believe this fix is now contained in all supported channels (including stable; and including the corresponding chromium update if I looked right).


status of dopy?

It looks like "dopy" is not really alive anymore.
Shall we do an "official" fork? Could another committer be added?

Dopy is alive and well ;) but not so active indeed ... It started as a need about 2 years ago but the code is kinda crap and I'd rather go for a revamp keeping compatibility than anything else. If you are interested in being a committer I can add you. Let me know.

Hi!
I am rather a Python noob, so perhaps not the guy you need.
I am happy that everything outstanding pull request is merged, so my immediate need is met. I am willing to help, but I wouldn't know where to start "revamping" anything.

Hi Vincent!

There are three oustanding pull requests, I am mostly interested in getting
https://github.com/Wiredcraft/dopy/pull/48 <https://github.com/Wiredcraft/dopy/pull/48>

merged.
So please either do it yourself, or if you are really tired of taking care of dopy, please make me committer.
Kind Regards
Victor

On 10 Feb 2015, at 04:53, Vincent Viallet<EMAIL_ADDRESS>wrote:
Dopy is alive and well ;) but not so active indeed ... It started as a need about 2 years ago but the code is kinda crap and I'd rather go for a revamp keeping compatibility than anything else. If you are interested in being a committer I can add you. Let me know.
—
Reply to this email directly or view it on GitHub https://github.com/devo-ps/dopy/issues/22#issuecomment-73640321.


api: adds MinReadySeconds param for all CRDs

it controls delay between pod restarts during rolling updates. It must improve rollout restart for vmstorage upgrades https://kubernetes.io/blog/2021/08/27/minreadyseconds-statefulsets/

related https://github.com/VictoriaMetrics/helm-charts/issues/608


Added a test to try and replicate a windows/unix issue

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: koenbeuk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.