Remove version: 7S2P.Effie version 3.11.5

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://download.effie.pro/effie/effieapp_setup_3.11.5.exe
Response status code does not indicate success: 403 (Forbidden).
(Automated message - build 896)


musly: add patches for FFmpeg 7, C++17, and external deps; kissfft: build with CMake; libresample: 0.1.3 -> 0.1.4-unstable-2024-08-03

Description of changes
More time spent on software that probably nobody cares about at this point. One fewer FFmpeg 4 dependency in the world, and a couple more packages that work on macOS!
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Against all odds, libresample upstream… is accepting my pull request to add a complete rewrite of the build system!
Drafting this for now until I can get it merged and integrated.

Result of nixpkgs-review pr 332035 run on aarch64-linux 1

18 packages built:

ardour
kissfft
kissfft.bin
kissfft.dev
kissfftFloat
kissfftFloat.bin
kissfftFloat.dev
libresample
libresample.bin
libresample.dev
loudgain
musly
musly.bin
musly.dev
musly.doc
qm-dsp
sonic-pi
zrythm

Result of nixpkgs-review pr 332035 run on aarch64-darwin 1

15 packages built:

kissfft
kissfft.bin
kissfft.dev
kissfftFloat
kissfftFloat.bin
kissfftFloat.dev
libresample
libresample.bin
libresample.dev
loudgain
musly
musly.bin
musly.dev
musly.doc
qm-dsp

Tried musly with a bunch of audio files in the following way:
musly -N # initialize collection
musly -a . # add audio files from the current directory
musly -m sim # print similarity matrix to a file

and it seems to work fine.

Result of nixpkgs-review pr 332035 run on x86_64-darwin 1

1 package marked as broken and skipped:

zrythm

14 packages built:

kissfft
kissfft.bin
kissfft.dev
kissfftFloat
kissfftFloat.bin
kissfftFloat.dev
libresample
libresample.bin
libresample.dev
musly
musly.bin
musly.dev
musly.doc
qm-dsp

Looks ok to me, although that's a lot of patches to maintain.
My only gripe is that I think we shouldn't be merging branches with random names.

The libresample Meson patch has been provisionally accepted upstream and I’m just waiting on final review. As soon as a new release is tagged I’ll update the package and drop the patches we have here. So there shouldn’t be any ongoing maintenance cost there and the new build system has already been incorporated into the Debian package.
The kissfft one I also sent a PR for, but no idea if or when it will be merged. It’s a one line patch that is smaller than the patch we were having to carry for the Make build system, so I think it’s fine.
The musly ones… yeah, no argument there. Upstream hasn’t done anything in half a decade, so it’s very unlikely the patches will require any ongoing maintenance cost. I have no idea if they’ll merge my PR or not. Given that it was already broken with a newer C++ standard and FFmpeg 4 is very close to completely removed from Nixpkgs now the alternative would probably be to drop the leaf package. Since the patches are already written and @ggPeti has been responsive as a maintainer I don’t think there’s any need to consider doing that at the present juncture, but I wouldn’t stand in the way of its removal either.
The branch name is a Jujutsu change ID and makes pushing out changes a lot easier for me. I know I’m not the only Nixpkgs contributor using Jujutsu, although I may be the most prolific. Agreed that they don’t make for fantastic merge commit subject lines, but scanning the merge log of Nixpkgs is kind of hopeless anyway, and I’ve seen many merged PRs with manually‐written branch names that are somewhere between unhelpful and actively inaccurate. The PR title is included in the second line of the merge commit messages, which is a much more sensible way to browse the merge history, but I do wish that GitHub would include it in the subject line instead. If you’re implacably opposed I can attach another branch name, but it would require closing this PR and opening another so I’m not sure it’s exactly worth it.

If you’re implacably opposed I can attach another branch name, but it would require closing this PR and opening another so I’m not sure it’s exactly worth it.

No, it would be pointless. I don't have strong feelings in this case. We can merge this.
Now, if you ask me about that jj tool design choices (which I didn't know), then I would start arguing that having developed a tool that puts random branches names is not so useful and not very Git-compatible 🤭

Back to a draft again as the libresample PR was merged upstream; will update this as soon as there’s a tag and get rid of those patches 😅

Okay, I don’t know how long it’ll be before upstream cuts a release and this is one of the few things remaining for the big FFmpeg 4 PR so I’ve just bumped it to drop the vendored Meson patch for libresample but keeping the smaller tests one for now. Now it just needs merging before any further developments happen!

Result of nixpkgs-review pr 332035 run on x86_64-darwin 1

1 package marked as broken and skipped:

zrythm

14 packages built:

kissfft
kissfft.bin
kissfft.dev
kissfftFloat
kissfftFloat.bin
kissfftFloat.dev
libresample
libresample.bin
libresample.dev
musly
musly.bin
musly.dev
musly.doc
qm-dsp


Gitpod.io project setup - nangohq/nango-server image pull fails

crowd.dev edition
Community (self hosted)
Version
v0.30.0
What happened?
I don't know if that's a rootless docker issue, I tried many workarounds but didn't succeed even with sudo.

Command / Request
./cli start
./cli clean-start-dev

Relevant log output
failed to register layer: ApplyLayer exit status 1 stdout:  stderr: failed to Lchown "/usr/nango-server/src/node_modules/content-type/HISTORY.md" for UID<PHONE_NUMBER>, GID 0 (try increasing the number of subordinate IDs in /etc/subuid and /etc/subgid): lchown /usr/nango-server/src/node_modules/content-type/HISTORY.md: invalid argument

Hey! Thanks for reporting. Is this still an issue?

yes


Add example for rrt

In /examples/rrt.py add a short example of how PRM can be used by an external user

@sushant1212


feat: checkbox-group component

Includes:

checkbox-group component of which the implementation was discussed in #291:

 <bl-checkbox-group id="sportSelection" label="Choose sports you like" name="sports" required value='["basketball","tennis"]'>
  <bl-checkbox value="football">Football</bl-checkbox>
  <bl-checkbox value="basketball">Basketball</bl-checkbox>
  <bl-checkbox value="tennis">Tennis</bl-checkbox>
</bl-checkbox-group>

<script>
  sportSelection.value; // ['basketball', 'tennis']
</script>

accessibility and form control improvements of checkbox component mentioned in #290,

checkbox focus state screenshots will be added after #322 resolves.
Closes #290, #291.

After searching and discussing checkbox-group examples with @buseselvi, we decided to change the keyboard navigation. Pressing tab will always switch to the next element in the group rather than focusing outward.
Example : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox
But navigating with arrow keys will be the same as now.
I'll make these changes shortly if that's final @muratcorlu  @buseselvi .


Add kafka log parse utility classes/functions and write time sync kafka log parser

PR Details
Description
Added python scripts to parse Kafka log data for SPAT and Time Sync messages into csv format.

Related GitHub Issue

Related Jira Key
CDAR-535

Motivation and Context
Data Analysis

How Has This Been Tested?
Local Testing

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

functions and classes into separate files is unnecessary. They are all required for data parsing and are used only for this purpose (i.e., they are not library files).
Following the above point, the code can be combined into a single script, possibly called extract_kafka_msgs_from_logs.sh. It would look something like this:

Separating these improve modularity and reusability of parsing logic. My vision here is to have a python module that is responsible for parsing all carma streets kafka data regardless of use case. Then possibly have a dependent python module that is able to generate a lot of the common use case data analysis plots. Obscuring our implementation for data analysis presents very little value here to me, especially since this is no some script to be copied into 16 different common repos but more of a python package that will evolve with every data analysis

Separating these improve modularity and reusability of parsing logic.

Combining the functions and classes into a single Python module does not reduce modularity. They are all related to extracting Kafka messages from logs, so it would make more sense to combine them into a single module.

My vision here is to have a python module that is responsible for parsing all carma streets kafka data regardless of use case. Then possibly have a dependent python module that is able to generate a lot of the common use case data analysis plots.

What you are describing here is similar to the analysis scripts for the Eclipse MOSAIC Real-Time Factor (see #19).

Obscuring our implementation for data analysis presents very little value here to me, especially since this is no [sic] some script to be copied into 16 different common repos but more of a python package that will evolve with every data analysis

Why would we have to copy this to several repos?

@adamlm Please resolve any concerns that you feel have been addressed. I am unsure which of these comments are still relevant


do not add column prefix in the query

refs: #3620
When building the query, the table prefix is automatically added, and the changes we did in https://github.com/Laravel-Backpack/CRUD/commit/8aef333c86e958c3132e4826ba0184e6ec742953 broke this part of the functionality because we get the table name with prefix and then it gets prefixed again.
This ensures we keep fixing what we fixed in the mentioned commit (adding table name prefix in queries), but when using global prefixes they will be added, no need to add it there.

A new inspection was created.

@pxpm I solved it in a different way, I think we could keep the getColumnWithTableNamePrefixed, but remove only the prefix, take a look at changes on; https://github.com/Laravel-Backpack/CRUD/pull/3634
Let me know what you think 🙌

FetchOperation also has this problem with laravel 8.
Backpack\CRUD\app\Models\Traits\HasRelationshipFields.php


Failed to scale down the self hosted etcd clusters

The pluton test for bootkube is trying to scale down from 3 to 1, and it often gets stuck.
Here is some artifacts I got:
etcd cluster TPR object:
$ kubectl get clusters -n kube-system -o yaml
apiVersion: v1
items:
- apiVersion: etcd.coreos.com/v1beta1
  kind: Cluster
  metadata:
    creationTimestamp: 2017-04-04T00:28:46Z
    name: kube-etcd
    namespace: kube-system
    resourceVersion: "1785"
    selfLink: /apis/etcd.coreos.com/v1beta1/namespaces/kube-system/clusters/kube-etcd
    uid: aa4ecb7d-18cd-11e7-9d37-42010af0000e
  spec:
    TLS: null
    pod:
      antiAffinity: false
      nodeSelector:
        master: "true"
      resources: {}
    selfHosted:
      bootMemberClientEndpoint: http://<IP_ADDRESS>:12379
    size: 1
    version: 3.1.0
  status:
    conditions:
    - reason: 'Current cluster size: 0, desired cluster size: 1'
      transitionTime: 2017-04-04T00:28:46.309813657Z
      type: ScalingUp
    - reason: ""
      transitionTime: 2017-04-04T00:30:47.275086856Z
      type: Ready
    - reason: 'Current cluster size: 1, desired cluster size: 3'
      transitionTime: 2017-04-04T00:33:42.513059964Z
      type: ScalingUp
    - reason: 'Current cluster size: 2, desired cluster size: 3'
      transitionTime: 2017-04-04T00:36:00.546899788Z
      type: ScalingUp
    controlPaused: false
    currentVersion: 3.1.0
    members:
      ready:
      - kube-etcd-0000
      - kube-etcd-0001
    phase: Running
    reason: ""
    size: 3
    targetVersion: ""
kind: List
metadata: {}
resourceVersion: ""
selfLink: ""

etcd operator logs: here
kube-etcd logs: here
@xiang90 @hongchaodeng
I also keep the cluster running, so you can ssh into them and do more debug.
gcloud compute ssh yifan-bootkube-test-16f15d65500a0db42e11 --zone us-central1-a
cd /home/core
export KUBECONFIG=/etc/kubernetes/kubeconfig
sudo ./kubectl get nodes

@yifan-gu
$ gcloud compute ssh yifan-bootkube-test-16f15d65500a0db42e11 --zone us-central1-a

ERROR: (gcloud.compute.ssh) Could not fetch instance:
 - The resource 'projects/coreos-k8s-scale-testing/zones/us-central1-a/instances/yifan-bootkube-test-16f15d65500a0db42e11' was not found

@hongchaodeng Oh it's in the coreos-gce-testing project.
gcloud config set project coreos-gce-testing

pod kube-etcd-0002 exited before it's removed by operator.

pod kube-etcd-0002 logs:
2017-04-04 00:37:41.908054 E | etcdserver: the member has been permanently removed from the cluster
2017-04-04 00:37:41.908145 I | etcdserver: the data-dir used by this member must be removed.

It seemed like there is previous data dir left.
etcd pod use hostPath. The data dir should be cleaned up after each test.

Any idea why that happens?
The pluton test code is here
Seems it does a scale up and then a scale down.

@yifan-gu
When etcd pod starts up, it uses hostpath /var/etcd/${namespace}-${cluster-name}.
I don't know the details on what happened. You can check if the data dir exists before the test. It could be left by other tests.

@hongchaodeng Hmm, I only ran 1 single test, so it doesn't seems like this is "left be other tests". Besides, even running tests in parallel, the pluton tests are running in a separate cluster. I could take a look tomorrow.

@yifan-gu
Any update?

@hongchaodeng nope

I'm closing this since this isn't an issue anymore.
Feel free to reopen it if you still encounter problems

I'm closing this since this isn't an issue anymore.

I don't feel the issue is solved yet, cc @pbx0 if you can provide more info for the selfhosted etcd scale test flakiness.

@yifan-gu
If it happened again, let's create a new issue in bootkube or pluton with more logs and detailed repro steps.


Extract IMAGE tag as optional argument to docker-build and deploy-operator

@aslakknutsen can you add more description in the issue? I'm not sure what is the goal here. Do you want $(DOCKER_REPO)/$(DOCKER_IMAGE):$(COMMIT) to be an argument called IMAGE with that as default value for docker-build target?
Then deploy-operator should replace the value of the image in yaml descriptors based on that argument? If so should it simple shell text replace or do you want OpenShift template?

Do you want $(DOCKER_REPO)/$(DOCKER_IMAGE):$(COMMIT) to be an argument called IMAGE with that as default value for docker-build target?

Essentially optionally parameterize DOCKER_IMAGE

Then deploy-operator should replace the value of the image in yaml descriptors based on that argument? If so should it simple shell text replace or do you want OpenShift template?

Either way is fine, but I guess making it a Template would do.
IMAGE=my-whatever/whatever make docker-build
IMAGE=my-whatever/whatever make deploy-operator

Thanks, on it.

Essentially optionally parameterize DOCKER_IMAGE

Seems to be already there (same with repo):
https://github.com/aslakknutsen/istio-workspace/blob/05d609a3beab15c86d1691f5c487914084becac2/Makefile#L72
so it's only a matter of introducing the templates I think.


fix(ui/fieldDecorator): placeholder width exceeds container size

Checklist

[x] Fix linting errors
[x] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #1015 (38cb3a6) into dev (272ffd5) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##              dev    #1015   +/-   ##
=======================================
  Coverage   95.98%   95.98%
=======================================
  Files         324      324
  Lines       21203    21203
  Branches     1407     1407
=======================================
  Hits        20352    20352
  Misses        805      805
  Partials       46       46


Is podman run -dt command option defined or deprecated?

/kind feature
podman run -dt option not defined or labeled deprecated
The current podman-run.1.md page does not list this option. It should be listed if valid or marked deprecated if it been replaced.

Several reliable source tutorials and websites are using the option "-dt" yet the official documentation doesn't contain this option.
Examples

Blog Article - Podman: Managing pods and containers in a local container runtime in the section labeled Add a container to a pod.

Enable Sysadmin Article - Configuring container networking with Podman in the section labeled Communicate between a root full container and the host.

-dt is not a single option, but a combination of -d and -t - run detached, with a terminal. Docker allows merging single-letter flags together like this (-dit is also valid, for example - -d, -i, -t), and Podman has inherited this support; I'm honestly not a fan because of issues of clarity, as seen here.

In most command line tools a single - indicates single letter options,  As @mheon Says they can be combined.
For example
ls -latr
Double -- indicates long options  --detach --tty for example.
I don't believe this is an issue.


Add quiet option to disable console log output from validations

Fixes #57.
Adding "-q" or "--quiet" to the vladiate execution disables the console log generated by validations.
If used programatically, the feature can be enabled adding disable_console_log=True to the class initialization
The overall result can still be captured by return values.

Thanks for the feedback di!
I updated the pull request.
What makes me doubt is how to get the arguments variable from the _vladiate function in main.py.
Making arguments global or passing it as parameter don't seem clean approaches.

Thanks! Released in vladiate==0.0.22.


VRTK_Height Adjust Teleport causes problems with grabbing objects with hinges

Using the Height Adjust teleport script causes objects with hinges to move away from their hinge area and attach itself to the controller, rather than swinging open where it is. Upon letting go of the object, it will snap back into place.
To replicate:
Open the example scene 021_Controller_GrabbingObjectsWithJoints and add the VRTK_Height Adjust Teleport script to the [CameraRig] object and VRTK_Beziel Pointer script to one of the controllers. Play the scene and try opening the door or the case.
Edit: I just found that it's related to the "Play Space Falling" option. With it unchecked, everything works as normal.

confirmed, looking to fix it now

Try this PR and see if it fixes your problem https://github.com/thestonefox/SteamVR_Unity_Toolkit/pull/451

Yep, that did the trick! Thanks!

Cool, I'll merge that pr in the morning!

I may have spoke too soon. I'm still seeing the same issue only on certain hinged objects. They're the only hinges that aren't reachable from the ground floor. Have to walk on top of a wing and open hatches. Looking at your updated code, I'm wondering if it's related to walking on an uneven mesh collider.

Yes I think it is. I have another fix, try setting the interactable object of the hinged item to have a specific tag like "excludeteleport" then on the teleporter set the ignore tag or class to the string "excludeteleport".
See if that works, I'm guessing it won't yet but I can apply a fix to make that set up work.

Nope, still the same. I did change the line:
if (floorY != previousFloorY)
to
if (Mathf.Abs(floorY - previousFloorY) > 0.1f)
and that seemed to fix it for my needs, at least.

I'll look into a proper fix in the morning. Your solution will only work under specific circumstances. Really needs a way of setting an item to not be able to teleport with when grabbed.

The PR has been updated with a more robust solution:
https://github.com/thestonefox/SteamVR_Unity_Toolkit/pull/451
There is now another option on an interactable object to prevent it from being able to be teleported when you're grabbing it:

Stay Grabbed On Teleport: If this is checked then the object will stay grabbed to the controller when a teleport occurs. If it is unchecked then the object will be released when a teleport occurs.

If you set any handle or hinged item to have the Stay Grabbed On Teleport to false then they won't follow the controller on teleport.
This "should" fix your issue. Let me know how you get on with it.


fix: applyTextEdit may give an error when used with another buffer

This PR fixes https://github.com/uga-rosa/deno-denops-lsputil/issues/6.

I think a vim script of this scale will significantly impact maintainability.
Could you tell me why it's necessary?

The reason why applyTextEdit for non-current buffers is necessary is at least it's necessary to implement textDocument/rename feature of LSP.
Sometimes textDocument/rename requests to change not only the current file but also other files.

I see. Certainly, the overhead of the first option is not desirable. And I wasn't aware of the second option.
Understood. Let me approve it.


Deploy Checklist: New Expensify 2023-01-27

Release Version: 1.2.61-0
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/App/pull/14249
[x] https://github.com/Expensify/App/pull/14412
[x] https://github.com/Expensify/App/pull/14442
[x] https://github.com/Expensify/App/pull/14506
[x] https://github.com/Expensify/App/pull/14515
[x] https://github.com/Expensify/App/pull/14542
[x] https://github.com/Expensify/App/pull/14586
[x] https://github.com/Expensify/App/pull/14592
[x] https://github.com/Expensify/App/pull/14595
[x] https://github.com/Expensify/App/pull/14602
[x] https://github.com/Expensify/App/pull/14606

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.61-0 :rocket:

Regression is completed. No blockers

:shipit:


feat(linter/tree-shaking): support DoWhileStatement and IfStatement

#2994  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on  Graphite


Use 4.1 as the default cookbook branch

retest this

retest this please

moving on. thanks for the PR thou @viglesiasce :-)


WebTorrent silently set itself as default magnet handler

What version of WebTorrent Desktop?
0.3.3
What operating system and version?
OSX 10.11
What did you do?
Open app
What did you expect to happen?
App should not silently modify user settings
What actually happened?
WebTorrent silently set itself as default magnet handler

Agree. We wanted to get magnet link handling working first. Planning to add an option once we have a prefs window.

This really needs to be a blocking issue for v.0.6.1, and it shouldn't be too hard to fix now that the preference panel is there.
I understand that it's not intentionally malicious, but right now this feels kinda malware-ish. Applications you install shouldn't change system settings like default home page or magnet handler without asking first, and especially set it at every launch of the application.
I can't keep Webtorrent installed until this is fixed.

@kristofferR I feel your pain and agree with you. We're working as fast as we can to fix issues. This should be fixed pretty soon.

Same here. I didn't know what was happening until I realised it was WebTorrent :)
Has to uninstall for now. I will install again this magic app when this gets fixed.
Thank you very much!

I was so pissed off when webtorrent set itself as the default Application for opening the magnet links. I just wanted to try it before setting it as my default torrent app. Felt like a malware

I don't understand why this is not yet fixed, it was reported ages ago.
On Aug 9, 2016 5:36 PM, "Kiran"<EMAIL_ADDRESS>wrote:

I was so pissed off when webtorrent set itself as the default Application
for opening the magnet links. I just wanted to try it before setting it as
my default torrent app. Felt like a malware
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/367#issuecomment-238573308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdpURFIdCufObIoINZuFhC4MjF97l26ks5qeJB7gaJpZM4IDmEO
.

Will be fixed in the next version
On 9 Aug 2016 08:25, "Dmitry Wolf"<EMAIL_ADDRESS>wrote:

I don't understand why this is not yet fixed, it was reported ages ago.
On Aug 9, 2016 5:36 PM, "Kiran"<EMAIL_ADDRESS>wrote:

I was so pissed off when webtorrent set itself as the default Application
for opening the magnet links. I just wanted to try it before setting it
as
my default torrent app. Felt like a malware
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/feross/webtorrent-desktop/issues/367#
issuecomment-238573308>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAdpURFIdCufObIoINZuFhC4MjF97l26ks5qeJB7gaJpZM4IDmEO>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/feross/webtorrent-desktop/issues/367#issuecomment-238589124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKVQPxu6cPlA6rfFpqF0yfaApFNE6Asks5qeJu6gaJpZM4IDmEO
.


⚠ Mobitopup has degraded performance

In c42de99, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 8581 ms

Resolved: Mobitopup performance has improved in b84313a.


Compiler warnings fixes for unused variable and incorrect type

Fixes for Compilation warnings/errors:
  include/zephyr/net/buf.h - casts assignment to prevent warning
  include/zephyr/net/hostname.h - Just prevents a compiler warning due to unused arg. Should use "ARG_UNUSED() rather than "(void) ;"
  include/zephyr/net/net_context.h - casts and ARG_UNUSED() to prevent compiler warnings.
  include/zephyr/net/net_if.h - several ARG_UNUSED().
  include/zephyr/net/net_ip.h - cast in an assignment (presumably to prevent warning).
  include/zephyr/posix/time.h - cast to prevent warning
  include/zephyr/sys/byteorder.h - lots of casts to prevent warnings
  include/zephyr/sys/util.h - cast to prevent warnings
edited by @ycsin: This PR is a re-incarnation of #69300

This seems to be re-incarnation of #69300. There is normally no need to close and then re-create a new PR, you can always force push over the existing PR. This way the already written comments are not lost.

Please have a look at the contribution guidelines (the bot message in your previous PR) - your commit is missing a valid title, message & sign-off and it will fail the compliance checks

I just submitted a commit with changes according to
https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines
Let me know if it needs more TLC :-)
Thanks
Chauncy
On Tue, Feb 27, 2024 at 9:18 PM Yong Cong Sin @.***>
wrote:

Please have a look at the contribution guidelines (the bot message in your
previous PR) - your commit is missing a valid title, message & sign-off and
it will fail the CI's compliance checks
—
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/pull/69440#issuecomment-1968066354,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7W4WZC5ZAIVL3A766JMPL3YV2HWLAVCNFSM6AAAAABDZPLX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGA3DMMZVGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I thought I have all spaces with tabs. I was wrong. I blamed expandtab option in vim :-). Should be fixed now. Thanks

I see no failures on "Build with Clang/LLVM / clang-build ...". Can someone explain why this didn't pass? Thanks

Looking at the error message:
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 3d0d0295bec7496b54dec80cd231ac738ec28c6d: author email (LIU, CHAUNCY<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
3d0d0295bec7496b54dec80cd231ac738ec28c6d: author email (LIU, CHAUNCY<EMAIL_ADDRESS>does not follow the syntax: First Last <email>.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.

Make sure that your git config looks like the following:
$ git config --list
user.name=Chauncy Liu
<EMAIL_ADDRESS>
To match your commit signed-off:
Signed-off-by: Chauncy Liu<EMAIL_ADDRESS>
also, additional indentation issue:
 CODE_INDENT: code indent should use tabs where possible
File:include/zephyr/net/net_context.h
Line:1008
 LEADING_SPACE: please, no spaces at the start of a line
File:include/zephyr/net/net_context.h
Line:1008

Done git commit --amend -s

@cliu5764 - is there any possibility that you could paste the warnings into this PR in a code block?

@cliu5764 - is there any possibility that you could paste the warnings into this PR in a code block?

include/zephyr/net/buf.h:
In file included from /b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net      _l2.h:16,
                  from /b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net      _if.h:29:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/buf.h: In function 'net_b      uf_simple_save':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/buf.h:868:25: warning: co      nversion from 'size_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconve      rsion]
  868 |         state->offset = net_buf_simple_headroom(buf);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~

include/zephyr/net/hostname.h:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/hostname.h: In function '      net_hostname_set_postfix':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/hostname.h:74:59: warning      : unused parameter 'hostname_postfix' [-Wunused-parameter]
   74 | static inline int net_hostname_set_postfix(const uint8_t *hostname_postfix,
      |                                            ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/hostname.h:75:48: warning      : unused parameter 'postfix_len' [-Wunused-parameter]
   75 |                                            int postfix_len)
      |                                            ~~~~^~~~~~~~~~~

include/zephyr/net/net_context.h:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h: In functio      n 'net_context_set_accepting':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:397:35: war      ning: conversion from 'long unsigned int' to 'uint16_t' {aka 'short unsigned int'} changes the value of '42949      66783' [-Wconversion]
  397 |                 context->flags &= ~NET_CONTEXT_ACCEPTING_SOCK;
      |                                   ^
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h: In functio      n 'net_context_set_closing':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:429:35: war      ning: conversion from 'long unsigned int' to 'uint16_t' {aka 'short unsigned int'} changes the value of '42949      66271' [-Wconversion]
  429 |                 context->flags &= ~NET_CONTEXT_CLOSING_SOCK;
      |                                   ^
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h: In functio      n 'net_context_set_family':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:509:24: war      ning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  509 |                 flag = family << 3;
      |                        ^~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h: In functio      n 'net_context_set_iface':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:669:26: war      ning: conversion from 'int' to 'int8_t' {aka 'signed char'} may change value [-Wconversion]
  669 |         context->iface = net_if_get_by_iface(iface);
      |                          ^~~~~~~~~~~~~~~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h: In functio      n 'net_context_is_proxy_enabled':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:713:69: war      ning: unused parameter 'context' [-Wunused-parameter]
  713 | static inline bool net_context_is_proxy_enabled(struct net_context *context)
      |                                                 ~~~~~~~~~~~~~~~~~~~~^~~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h: In functio      n 'net_context_create_ipv6_new':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:826:67: war      ning: unused parameter 'context' [-Wunused-parameter]
  826 | static inline int net_context_create_ipv6_new(struct net_context *context,
      |                                               ~~~~~~~~~~~~~~~~~~~~^~~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:827:63: war      ning: unused parameter 'pkt' [-Wunused-parameter]
  827 |                                               struct net_pkt *pkt,
      |                                               ~~~~~~~~~~~~~~~~^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:828:70: war      ning: unused parameter 'src' [-Wunused-parameter]
  828 |                                               const struct in6_addr *src,
      |                                               ~~~~~~~~~~~~~~~~~~~~~~~^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_context.h:829:70: war      ning: unused parameter 'dst' [-Wunused-parameter]
  829 |                                               const struct in6_addr *dst)
      |                                               ~~~~~~~~~~~~~~~~~~~~~~~^~~

include/zephyr/net/net_if.h:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h: In function 'ne      t_if_oper_state_set':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:731:24: warning:       comparison is always true due to limited range of data type [-Wtype-limits]
  731 |         if (oper_state >= NET_IF_OPER_UNKNOWN && oper_state <= NET_IF_OPER_UP) {
      |                        ^~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h: In function 'ne      t_if_ipv6_set_base_reachable_time':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1643:71: warning      : unused parameter 'iface' [-Wunused-parameter]
 1643 | static inline void net_if_ipv6_set_base_reachable_time(struct net_if *iface,
      |                                                        ~~~~~~~~~~~~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1644:65: warning      : unused parameter 'reachable_time' [-Wunused-parameter]
 1644 |                                                        uint32_t reachable_time)
      |                                                        ~~~~~~~~~^~~~~~~~~~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h: In function 'ne      t_if_ipv6_get_reachable_time':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1664:70: warning      : unused parameter 'iface' [-Wunused-parameter]
 1664 | static inline uint32_t net_if_ipv6_get_reachable_time(struct net_if *iface)
      |                                                       ~~~~~~~~~~~~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h: In function 'ne      t_if_ipv6_set_reachable_time':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1694:71: warning      : unused parameter 'ipv6' [-Wunused-parameter]
 1694 | static inline void net_if_ipv6_set_reachable_time(struct net_if_ipv6 *ipv6)
      |                                                   ~~~~~~~~~~~~~~~~~~~~^~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h: In function 'ne      t_if_ipv6_set_retrans_timer':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1711:65: warning      : unused parameter 'iface' [-Wunused-parameter]
 1711 | static inline void net_if_ipv6_set_retrans_timer(struct net_if *iface,
      |                                                  ~~~~~~~~~~~~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1712:59: warning      : unused parameter 'retrans_timer' [-Wunused-parameter]
 1712 |                                                  uint32_t retrans_timer)
      |                                                  ~~~~~~~~~^~~~~~~~~~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h: In function 'ne      t_if_ipv6_get_retrans_timer':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_if.h:1732:69: warning      : unused parameter 'iface' [-Wunused-parameter]
 1732 | static inline uint32_t net_if_ipv6_get_retrans_timer(struct net_if *iface)
      |                                                      ~~~~~~~~~~~~~~~^~~~~

include/zephyr/net/net_ip.h
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_ip.h: In function 'net_ipv6_is_prefix':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/net/net_ip.h:686:16: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  686 |         mask = ((0xff << (8 - remain)) ^ 0xff) << remain;
      |                ^

include/zephyr/posix/time.h:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/posix/time.h: In function '_t      s_to_ms':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/posix/time.h:82:44: warning:       conversion from 'time_t' {aka 'long long int'} to 'int32_t' {aka 'int'} may change value [-Wconversion]
   82 |         return (to->tv_sec * MSEC_PER_SEC) + (to->tv_nsec / NSEC_PER_MSEC);
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

include/zephyr/sys/byteorder.h:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_be16':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:311:18: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  311 |         dst[0] = val >> 8;
      |                  ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:312:18: warning: conversion from 'uint16_t' {aka 'short unsigned int'} to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  312 |         dst[1] = val;
      |                  ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_be24':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:326:18: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  326 |         dst[0] = val >> 16;
      |                  ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:327:22: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  327 |         sys_put_be16(val, &dst[1]);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_be32':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:341:26: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  341 |         sys_put_be16(val >> 16, dst);
      |                      ~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:342:22: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  342 |         sys_put_be16(val, &dst[2]);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_be48':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:356:26: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  356 |         sys_put_be16(val >> 32, dst);
      |                      ~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:357:22: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
  357 |         sys_put_be32(val, &dst[2]);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_be64':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:371:26: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
  371 |         sys_put_be32(val >> 32, dst);
      |                      ~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:372:22: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
  372 |         sys_put_be32(val, &dst[4]);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_le16':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:386:18: warning: conversion from 'uint16_t' {aka 'short unsigned int'} to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  386 |         dst[0] = val;
      |                  ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:387:18: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  387 |         dst[1] = val >> 8;
      |                  ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_le24':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:401:22: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  401 |         sys_put_le16(val, dst);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:402:18: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  402 |         dst[2] = val >> 16;
      |                  ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_le32':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:416:22: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  416 |         sys_put_le16(val, dst);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:417:26: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  417 |         sys_put_le16(val >> 16, &dst[2]);
      |                      ~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_le48':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:431:22: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
  431 |         sys_put_le32(val, dst);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:432:26: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
  432 |         sys_put_le16(val >> 32, &dst[4]);
      |                      ~~~~^~~~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h: In function 'sys_put_le64':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:446:22: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
  446 |         sys_put_le32(val, dst);
      |                      ^~~
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/byteorder.h:447:26: warning: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
  447 |         sys_put_le32(val >> 32, &dst[4]);
      |                      ~~~~^~~~~

include/zephyr/sys/util.h:
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/util.h: In function 'bcd2bin':
/b/mros/no_zephyr_patch/microros_ws/firmware/zephyrproject/zephyr/include/zephyr/sys/util.h:503:36: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion]
  503 |         return  ((10 * (bcd >> 4)) + (bcd & 0x0F));
      |                 ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~

No objections to the actual changes, but as I said in the original PR, please split the changes to logical components, all network related fixes to one commit, posix to one, and utility fixes to one commit inside this PR.
Also there is this CI reported compliance issue
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 6d9c64186eb99fb0502c2f9c49bef87d7e995220: author email (LIU, CHAUNCY<EMAIL_ADDRESS>does not follow the syntax: First Last <email>.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 1: UC2 Signed-off-by: must have a full name

No objections to the actual changes, but as I said in the original PR, please split the changes to logical components, all network related fixes to one commit, posix to one, and utility fixes to one commit inside this PR. Also there is this CI reported compliance issue
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 6d9c64186eb99fb0502c2f9c49bef87d7e995220: author email (LIU, CHAUNCY<EMAIL_ADDRESS>does not follow the syntax: First Last <email>.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 1: UC2 Signed-off-by: must have a full name

No objections to the actual changes, but as I said in the original PR, please split the changes to logical components, all network related fixes to one commit, posix to one, and utility fixes to one commit inside this PR. Also there is this CI reported compliance issue
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 6d9c64186eb99fb0502c2f9c49bef87d7e995220: author email (LIU, CHAUNCY<EMAIL_ADDRESS>does not follow the syntax: First Last <email>.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

 1: UC2 Signed-off-by: must have a full name

fixed the full name format. please check. All the changes are include header files and the changes are small. I can see the benefit of splitting the changes for big code changes. I think the changes are pretty straight-forward here.

All the changes are include header files and the changes are small. I can see the benefit of splitting the changes for big code changes. I think the changes are pretty straight-forward here.

It is not about whether the change is small or big, the point is that if some commit needs to be reverted, it is best if the commit is only dealing with related changes. In this PR you are mixing different changes to one commit. Probably there is no need to revert this commit, but it is a good habit to take that into account in advance. So that is why I wanted to see changes separated to individual commits.

Hm... a lot of these changes are introducing truncations.  Those are hard to review in isolation and can introduce bugs (even security bugs!) if the types don't actually match.  To pick just one from the reviews above:
- context->flags &= ~NET_CONTEXT_CLOSING_SOCK;
+ context->flags &= (uint16_t)~NET_CONTEXT_CLOSING_SOCK;

What happens if context->flags is a uint32_t?  Well, where we used to clearing just the one bit.  Now we'd be that one bit, and also the whole top half of the word.   There's no way to know at review time which is which, right?  Now imagine if those extra cleared bits had security impact.   To be clear, I'm absolutely not accusing you of introducing security bugs!  But at the same time, if you did want to sneak a vulnerability into an open source project, you'd probably hide it in a PR just like this one.   Basically I'm making a smell argument that changes like this are ones we shouldn't be in the habit of approving in big hygine PRs.
Can we maybe rework this to avoid hard-to-audit truncations?  In that example, you could define NET_CONTEXT_CLOSING_SOCK to evaluate to short.   Or introduce a "clear_flags_bit" API for contexts, etc...  Lots of options.

what's the build command u used that generated build time warnings?
We see the warning during our micro ros instegration. You can build with
git clone git@github.com:beechwoods-software/microROS-installer.git mros
cd mros
./docker_setup.sh

docker_setup.sh will setup the docker image for building the installer. It also give instruction how to start the build.

Can someone point to me what are the requested changes needed to be addressed? Thanks

Can someone point to me what are the requested changes needed to be addressed? Thanks

Just commenting as a volunter:

@jukkar is requesting the changes to be "separated to individual commits".
and @andyross is suggesting you to "rework this to avoid hard-to-audit truncations"

broken down to https://github.com/zephyrproject-rtos/zephyr/pull/70076, https://github.com/zephyrproject-rtos/zephyr/pull/70074 and https://github.com/zephyrproject-rtos/zephyr/pull/70072.

broken down to https://github.com/zephyrproject-rtos/zephyr/pull/70076, https://github.com/zephyrproject-rtos/zephyr/pull/70074 and https://github.com/zephyrproject-rtos/zephyr/pull/70072.

@cliu5764 - I think what Jukka requested was to have individual commits in one pull request.
Since these are all fixing warnings, it's fair to bundle the commits together. I would maybe suggest closing the other PRs since they duplicates this one.

broken down to #70076, #70074 and #70072.

@cliu5764 - I think what Jukka requested was to have individual commits in one pull request.
Since these are all fixing warnings, it's fair to bundle the commits together. I would maybe suggest closing the other PRs since they duplicate this one.

broken down to #70076, #70074 and #70072.

@cliu5764 - I think what Jukka requested was to have individual commits in one pull request.
Since these are all fixing warnings, it's fair to bundle the commits together. I would maybe suggest closing the other PRs since they duplicate this one.

Hm... a lot of these changes are introducing truncations. Those are hard to review in isolation and can introduce bugs (even security bugs!) if the types don't actually match. To pick just one from the reviews above:
- context->flags &= ~NET_CONTEXT_CLOSING_SOCK;
+ context->flags &= (uint16_t)~NET_CONTEXT_CLOSING_SOCK;

What happens if context->flags is a uint32_t? Well, where we used to clearing just the one bit. Now we'd be that one bit, and also the whole top half of the word. There's no way to know at review time which is which, right? Now imagine if those extra cleared bits had security impact. To be clear, I'm absolutely not accusing you of introducing security bugs! But at the same time, if you did want to sneak a vulnerability into an open source project, you'd probably hide it in a PR just like this one. Basically I'm making a smell argument that changes like this are ones we shouldn't be in the habit of approving in big hygine PRs.
Can we maybe rework this to avoid hard-to-audit truncations? In that example, you could define NET_CONTEXT_CLOSING_SOCK to evaluate to short. Or introduce a "clear_flags_bit" API for contexts, etc... Lots of options.

Hm... a lot of these changes are introducing truncations. Those are hard to review in isolation and can introduce bugs (even security bugs!) if the types don't actually match. To pick just one from the reviews above:
- context->flags &= ~NET_CONTEXT_CLOSING_SOCK;
+ context->flags &= (uint16_t)~NET_CONTEXT_CLOSING_SOCK;

What happens if context->flags is a uint32_t? Well, where we used to clearing just the one bit. Now we'd be that one bit, and also the whole top half of the word. There's no way to know at review time which is which, right? Now imagine if those extra cleared bits had security impact. To be clear, I'm absolutely not accusing you of introducing security bugs! But at the same time, if you did want to sneak a vulnerability into an open source project, you'd probably hide it in a PR just like this one. Basically I'm making a smell argument that changes like this are ones we shouldn't be in the habit of approving in big hygine PRs.
Can we maybe rework this to avoid hard-to-audit truncations? In that example, you could define NET_CONTEXT_CLOSING_SOCK to evaluate to short. Or introduce a "clear_flags_bit" API for contexts, etc... Lots of options.

I just pushed a new commit which reverts the casting of (uint16_t). I fixed by change the define from BIT(9) to (1<<9). The kernel BIT() tends to use hardcoded UL. I will let the compiler to do the right type conversion. Can you review it? Thanks

@ycsin I am still seeing one requested change from you. I answered it in https://github.com/zephyrproject-rtos/zephyr/pull/69440#issuecomment-1984240914. Can we resolve this? Thanks

what's the build command u used that generated build time warnings?

@cliu5764 - if you're unable to provide the build command, I would suggest maybe simply adding -Wno-conversion to your CFLAGS. That would eliminate the entire category of warnings that you have reported.
With that, this change should be more or less equivalent to adding ARG_UNUSED() in a few places, which should be considerably easier to review and merge.


Make DateTime.cast support a less awkward subset of ISO 8601 datetime…

… format. Week dates and ordinal dates are still missing.

My goal here was to make the subset of ISO 8601 strings that Ecto.{Date,Time,DateTime}.cast can handle less awkward. This branch should make them able to handle everything except week dates and ordinal dates. I was running into issues myself when trying to cast strings in the following format:
2015-01T23:50:07+0000
This should be the same as 2015-01T23:50:07Z, but the functions could not handle it.

Is this something that is likely to get accepted? I'm sure the changes need review from more experience Elixir developers :)

I agree it would be nice to be a little bit more flexible out of the box, on the other hand I feel like this adds much complexity.
I also believe this makes you loose information - specifically the one about the time-zone. There would be no way to recover this information once the data is converted into Ecto.DateTime. If you care about time-zones, you should really consider one of the more advanced time libraries - timex or calendar - they both have ecto bindings via custom types.
I know the +0000 timezone issue comes mostly from ruby's DateTime (that's how it renders UTC times), contrary to Time class that uses the Z format.
Maybe as a compromise we could support both Z and +0000 time-zone indicators?
\cc @josevalim

@michalmuskala Thanks for the feedback. I agree with your comments. I think it would be much nicer to support any ISO 8601 string eventually, but I guess there should be more discussions before tackling that. I know that it would be nice to me personally if +0000 was supported. I'm not sure how much this would help others though. I wouldn't mind changing my pull request to add just that support if that is desired. I'm mainly looking for ways to get involved and this seemed like low hanging fruit. :)

The goal of Ecto is exactly to do some subset. If you need robust parsing, then you need to use a proper date time library. :) Thank you for the PR in any case!  :heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Width fixed to viewport

I want to use the tree menu in a sidebar. Items with a width wider than the sidebar result in a y-overflow as the width of the <ul class="rstm-tree-item-group"> is set to width: 100vw and not width: 100%. Is there any reason why it's done like this? Is there any possibility to overwrite the style or pass a modified class?

You're right. It should be 100% instead of 100vw. PR is welcome 😉
Though you can overwrite it by specifying more specific rules, for example:
ul.rstm-tree-item-group {
   width: 100%;
}

When will the corresponding PR: https://github.com/iannbing/react-simple-tree-menu/pull/142 be published to NPM?

This fix has been released in v1.1.13 🙂


same FindElementByAccessibilityId

Hi All,
I have script with same  FindElementByAccessibilityId ("txtBox") is there a better way to handle in WinAppDriver. I am unable to  click on the third element in the form. Any help would be highly appreciated.

We use the linq library.
var thirdBox = window.FindElementsByAccessibilityId ("txtBox").ElementAt(2);

Thanks Jonathan - Do you have any example of passing those value (ThirdBox)  with  FindElementsByAccessibilityId

Issue closed


[RFC] @keyframes and @font-face proposal

I'm still not sure about the API yet, but I was thinking it might look roughly something like the following:
Additional instance methods on the core Styletron class

constructor()
injectDeclaration(decl : object) -> string
injectFontFace(font : object) -> string (new)

returns name of injected font

injectKeyframes(keyframes : object) -> string (new)

returns name of injected keyframe animation

Core vs mixins
Maybe these are in the core or maybe they are mixins. Probably some minor internal refactoring needed either way. Need to think about additional features that might be desired to see if a mixin interface is warranted.
With media queries?
There needs to be more investigation into nesting@font-face and @keyframes inside of media queries as this will affect the interface. The spec seems to disallow this, but apparently some browser support it?
Naming/scoping?
Should there be a way to manually set animation/keyframe names? I think they should just be sequential (a, b, c, etc) with an optional namespace (just like atomic declarations).
Caching
For declarations, there's only 4 properties with string values required to check equality. @font-face rules and @keyframes rules are much trickier. I think simple reference equality might be sufficient here, as typically these are defined separately. See below for why reference equality is probably OK in my opinion, as it's reasonable to expect these are hoisted outside of render.
New primitives for styletron-react and friends
// Note: just an idea...
const {styled, fontFace, keyframes} from 'styletron-react';

const myFont = fontFace({...fontProperties}); // no side effect
const myAnimation = keyframes({...keyframeProperties}); // no side effect

const Box = styled('div', {
  fontFamily: myFont, // injects once on first render
  animationName: myAnimation // injects once on first render
});

Great to see movement on this!
I don’t love the idea of adding new magic to styletron-react, since we’ve written our own HoC to replace styled. I’d prefer having these features in one of the core libs.
I also wonder if tracking the new classes (e.g., myFont or myAnimation) is a feature that ought to be provided by styletron, rather than the app. These features are global by design. So one way or another, the application needs to give components a global cache, either on context, through a global store, or (see below) directly managed by styletron. These classes have zero likelihood of being manipulated in code -- they're set-and-forget -- which is why they might make sense to track in styletron:
import {addFontFace, retrieveFontFace} from 'styletron-utils';

// at startup:
addFontFace(‘icons’, {...fontProperties});

// then:
const iconStyle = {
  fontSize: ‘12px’,
  fontFamily: retrieveFontFace(‘icons’)
};

Having the application keep track of globals is fine though; I wouldn't object if you said that's not the lib's role.

@jbellsey I agree that the new primitives for font face and keyframes would be better candidates for styletron-utils. But I prefer letting the app have ownership of its font faces and keyframes like the example @rtsao provided.  I would prefer exporting it from a module instead.

Good point, indeed fontFace and keyframes have nothing to do with React. Agreed it definitely belongs in a lower-level library.

Any update on the keyframe animation support? I think the biggest parity deficit between styletron and styled-components features is react native and keyframe animation support. Closing that gap would be awesome.

I should get to this in the next few weeks. Happy to review/accept a PR for this though if anyone wants to give it a shot.

Just some input here. What I love about styletron is that you don't explictly name anything, you just declare what you want. We did our own take on implementing @keyframes

{
  '@keyframes': [
  {'20%' : { background : 'red'}},
  {'100%' : { background : 'blue' }}
  ]
}

from this styletron would generate an animation name, and override the animation name property. Something similar could be done for @font-face.

Closed in https://github.com/rtsao/styletron/pull/217


Adjust the post build script

This will create and install a standard binary instead of a shared library (better for most use cases)

LGTM!


Failure on SMP When complete power loss and no one on the server

Issue description:
Catastrophic Failure on SMP When complete power loss and no one on the server
What happens:
Catastrophic Failure on SMP When complete power loss and no one on the server, Loses all information stored for Imports/exports, Terminals refuse to "refresh" once power is resupplied, introduction of new interfaces work but existing remain broken, screenshot below
What you expected to happen:
Logged off of my SMP server that i recently started, chunkloaded but apparently doesnt work, power emptied from the system and when i return i am presented by https://i.gyazo.com/87b4da252c74f440b7e1086942078ae3.png
More photos will follow
Steps to reproduce:
Not quite sure but this is what i did
1.Build system
2.log off
3.log back on when power is completely gone
...
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>5
Refined Storage:1.2.12

Does this issue occur on a server? [yes/no]
Yes
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]
gonna link as many on topic photos as i can to help
https://i.gyazo.com/a8568afb4842ffa0dc80df1c76ddada7.png Connected Devices and "apparent" system being functional however in the background you can see the blacked out screens
https://i.gyazo.com/3cea4f285aa97e8d48f5512daf274c19.png View of the system thru the eyes of the terminal
https://i.gyazo.com/aff2ff729f7dacdfc4918482da5a611a.png added a terminal that is attached to a "blacked out" pattern terminal, works without an issue
As stated, Import refuse to import, Export the same, crafters are seen and recipes inside them work however when requested nothing happens

Update:

Relogged
Crafting Terminal still off, Pattern Terminal Working and Crafting Monitor working
Autocrafting still inactive

Update:

Relogged
Crafting Terminal still off, Pattern Terminal Working and Crafting Monitor working
Autocrafting still inactive

Fixed in 1.11. might get backport to 1.10 at some point

Fixed in 1.11. might get backport to 1.10 at some point


preact-router not resolving route with params after refresh

I'm having this issue when I refresh the page and the route is using parameters:

When I navigate to TestPage, it works as expected, but after refresh it throws:
GET http://localhost:5173/test/src/index.jsx net::ERR_ABORTED 404 (Not Found)
I'm using vite, no special config, just:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I can't reproduce this: https://stackblitz.com/edit/vitejs-vite-deqijd?file=src%2Fmain.jsx


Error in smi-ted load.py after commit 7ae8e79

Error after Commit 7ae8e79 in the smi-ted load.py
66%|██████▌   | 37/56 [00:04<00:02,  7.44it/s]
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
[<ipython-input-17-4b5887d6e225>](https://localhost:8080/#) in <cell line: 2>()
      1 model_type = "SMI-TED"
----> 2 train_emb, test_emb = fm4m.get_representation(train_smiles_list,test_smiles_list, model_type, return_tensor=False)

6 frames
[/usr/local/lib/python3.10/dist-packages/transformers/tokenization_utils_base.py](https://localhost:8080/#) in _call_one(self, text, text_pair, add_special_tokens, padding, truncation, max_length, stride, is_split_into_words, pad_to_multiple_of, return_tensors, return_token_type_ids, return_attention_mask, return_overflowing_tokens, return_special_tokens_mask, return_offsets_mapping, return_length, verbose, split_special_tokens, **kwargs)
   3112
   3113         if not _is_valid_text_input(text):
-> 3114             raise ValueError(
   3115                 "text input must be of type `str` (single example), `List[str]` (batch or single pretokenized example) "
   3116                 "or `List[List[str]]` (batch of pretokenized examples)."

ValueError: text input must be of type `str` (single example), `List[str]` (batch or single pretokenized example) or `List[List[str]]` (batch of pretokenized examples).

Hi @indra-ipd! Thanks for noticing that. Could you please provide me the dataset or the SMILES that caused that error? I think it's due to null values in SMILES normalization, but I want to make sure about it.

Hi @vichShir, I'm running the example code in examples/battery_example.py and the dataset is data/lce/train.csv and data/lce/test.csv

Thanks @indra-ipd ! I've tested the script above and indeed was due to null values in SMILES normalization. I have fix that in the linked pull request.
Could you review, please?


UX/UI/URI improvements proposal

Hi,
I'm The Dwarf, a very friendly guy : )
I have the following suggestions and improvement proposals.

Auto-loading state URI scheme. This would be soooooooo useful. Example:
User points browser to http://website.com/v86/v86statexyz and the state loads automatically.

Open maximized. It should be possible to make the Terminal window fill the whole screen without that frankly not-so-great looking button tool bar at the top. Just the Terminal covering the whole screen. Not full screen but the full width of the browser real estate.

Save and load state shortcuts. And shortcuts in general. For those of use that want to hide the menu it should be possible to load and save the state using shortcuts. A quickload and quicksave option would also be really useful and even improve on the real Linux OS's that don't provide state > bin file functionality as far as I know.

OS:
https://copy.sh/v86/?profile=buildroot
This is the best OS I have tried so far. It's small, loads relatively fast and has Internet access.
I also offer a bounty of 1 Astral token on Polygon and 1 custom NFT for anyone that completes the above points successfully.
I test a lot of apps and I know when I'm right. My design suggestions above should be implemented to facilitate the mainstreaming of v86.

Auto-loading state URI scheme. This would be soooooooo useful. Example: User points browser to http://website.com/v86/v86statexyz and the state loads automatically.

Can you clarify what you mean by this? Something like https://copy/v86/?state=https://myfileserver.com/arch.bin (where the user hosts their own statefile, but points at my website)? At the moment, the state images doesn't have all settings embedded, so perhaps something json-based like https://github.com/copy/v86/issues/448

Open maximized. It should be possible to make the Terminal window fill the whole screen without that frankly not-so-great looking button tool bar at the top. Just the Terminal covering the whole screen. Not full screen but the full width of the browser real estate.

Agreed. Ideally, we'd have an sidebar menu similar to novnc for maximised/fullscreen.

Save and load state shortcuts. And shortcuts in general. For those of use that want to hide the menu it should be possible to load and save the state using shortcuts. A quickload and quicksave option would also be really useful and even improve on the real Linux OS's that don't provide state > bin file functionality as far as I know.

Sure, why not. Agree on in-memory state saving/restoring, too. Or even in localStorage.

Or even in localStorage.

I have some doubts that localStorage is not particularly suitable for this, because there is a maximum limit of 5 MB per webpage. IndexedDB and OPFS seem to have no such restrictions.

Update:

Being able to save state files to web3 storage such as IPFS or Arweave would also be cool. Or possibly to akash.

I read #448 and that might be one way to do it. Maybe the URL will get super long if there are a lot of settings? Or maybe it would work.


Update link to solarized-dark-syntax

The existing link to https://github.com/atom/solarized-dark 404s

Can you please also update the link text?

Done @50Wliu !

@dgm34 Thanks for this! 🎉


Allow  and  to accept components as children

As reported in #168 and #250, Phoenix's link and label functions depend on content_tag, i.e. they don't allow including components in their inner block. If you try to do that, you get  the following error:
** (exit) an exception was raised:
    ** (ArgumentError) cannot convert component Surface.Components.Form.Checkbox with id nil to HTML.
A component must always be returned directly as part of a LiveView template.
For example, this is not allowed:
    <%= content_tag :div do %>
      <%= live_component @socket, SomeComponent %>
    <% end %>
...

We should roll our own implementation without depending on link and label just like we did for LivePatch and LiveRedirect.

I could work on this over the weekend.
Does this issue depend on #255 being finished first?

Hi @miguel-s!
Thanks for stepping in.

Does this issue depend on #255 being finished first?

I don't think so as its implementation should be consistent with the other existing components like LivePatch and Liveview. When #255 is ready it will change the behaviour of all of them.


Update the readme with the last available release

@rocboronat thanks for bringing this to our attention... Since we've already moved on to 0.4.2, I made the update to the readme separately.
https://github.com/layerhq/Atlas-Android/commit/2aa3e720a54e283e7cdd88becbc3adde8c9e8a4a


Update UG import section

Codecov Report

Merging #140 (87cb9ba) into rework-UG (690a669) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             rework-UG     #140   +/-   ##
============================================
  Coverage        73.78%   73.78%
  Complexity         658      658
============================================
  Files               95       95
  Lines             1812     1812
  Branches           194      194
============================================
  Hits              1337     1337
  Misses             406      406
  Partials            69       69

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


DPL-126-plate-state

Closes #
Changes proposed in this pull request:

added endpoint to access cherrytrack plates

...

Codecov seems to indicate that the following is not covered by tests:


mask laplacian pyramid

In the paper, it is said that you calculate the Laplacian pyramid for Xmask and then use its appropriate level to solve the proposed Gaussian-Poisson Equation in every iteration of the for-loop. However, I did not understand why you would need to make the Laplacian pyramid for the mask. It seems like in your implementation too you simply resize the mask and use it in different iterations of the for-loop. (maybe I missed something?)
This is the equation on how you calculate v from the paper. (' u is the discretized divergence of v')

I'm not sure but I think if you make the pyramid for the mask and use it then you would not merely have 0's and 1's in the mask matrix. So the question is: how would you then calculate v if the mask is not only 1's and 0's? Also I was not able to find where in your code you make the Laplacian pyramid for the mask. Are we doing something different than what the paper says?

Paper is cheap, see the code : )


hacktoberfest2022

add it in the specific folder and raise a pr again :) @priyanshuengine

Added the files in a specific folder

@priyanshuengine nope it's still not in the specific folder

do it for this file just like u did in the latest pr that i've just merged @priyanshuengine


Replace Dts flash with improved internal flashing

Also, please check if this works on some platform. You'll need to update the ${FW_NO_EC_SYNC_DOWNLOAD_LINK} flag and set ${DTS_FIRMWARE_FLASHING_SUPPORT} to true

@wiktormowinski pls fix precommit


Issue when control is inside modal with overflow: scroll

The calendar popup appears 'inside' the modal when it is show with overflow set to scroll. Here is an example fiddle:
http://jsfiddle.net/4w00f7sf/

I think I tried every possible option with z-Index and position relative and I never been able to make the calendar go outside.  I'm out of idea and I need a workaround fast

I tried widgetParent but with no luck.

@GearTheWorld  Have you found a solution for this issue?

Ok I'm doing the repro now.  Give me a few minutes

Well it seems that if I update everything using Nuget TODAY, I don't have the issue anymore.  We can consider this resolved somehow with fixes made on Github versions of the libraries.

https://stackoverflow.com/questions/12978254/twitter-bootstrap-datepicker-within-modal-window

+1

any solution for this?
+1

I'm going to give a straight forward "simple" way to solve this, we willl just need a class.
The thing is that the widget by default use position: absolute the problem with that is that then will render inside of the modal body if overflow-y is used, so how do we fixed? Simple, we change it to a fixed position :D (no pun intended...)
So just add to your modal that use this scroll thing this rule:
.overflow-y {
  overflow-y: scroll;
}

And then we can add this beautiful hack that maybe you will need to chagen a little for your own case:
.modal-body.overflow-y .bootstrap-datetimepicker-widget {
  position: fixed;
  top: 80px !important;
  right: 50px !important;
}

And with that, is all done.
Is this gonna be add to the code... NO. why? Not all case are the same so this will broke other peoples things

I'm going to give a straight forward "simple" way to solve this, we willl just need a class.
The thing is that the widget by default use position: absolute the problem with that is that then will render inside of the modal body if overflow-y is used, so how do we fixed? Simple, we change it to a fixed position :D (no pun intended...)
So just add to your modal that use this scroll thing this rule:
.overflow-y {
  overflow-y: scroll;
}

And then we can add this beautiful hack that maybe you will need to chagen a little for your own case:
.modal-body.overflow-y .bootstrap-datetimepicker-widget {
  position: fixed;
  top: 80px !important;
  right: 50px !important;
}

And with that, is all done.
Is this gonna be add to the code... NO. why? Not all case are the same so this will broke other peoples things

Tricky, but help. thanks


Enable build 2.3 for macosx

macos ci failed due to: https://github.com/milvus-io/knowhere/issues/800.


Removed SQL2008 connection, should use the config.

This caught me out when trying to use Runtime services with SQLCE 4.

So, will this still pull from the app.config for the connection string, etc?

Merged.


Height of the graph

Checklist

[x ] I updated the card to the latest version available
[ x] I cleared the cache of my browser
[ x] I verified that I'm really running the lastest version in my browser console
[ x] I checked if there is another issue opened with the same problem

Describe the bug
I try to implement the chart as single card on the view (Panel settings). In this case the chart is good on width and not good on height (the chart is bigger than page).
When I try to set height manually I need to set 350%. I think that it is not right. Please check auto height calculations.
Version of the card
Version:
To Reproduce
This is the configuration I used:
`  - theme: Backend-selected
title: Energy Total
path: energy-total
icon: mdi:lightning-bolt-circle
type: panel
badges: []
cards:
- type: custom:apexcharts-card
apex_config:
chart:
height: 350%
    graph_span: 7d
    span:
      end: day
    now:
      show: true
      color: red
    header:
      show: false
    yaxis:
      - id: power
        decimals: 0
        min: 0
        apex_config:
          tickAmount: 5
      - id: energy
        opposite: true
        decimals: 2
        apex_config:
          tickAmount: 5
    series:
      - entity: sensor.XXX
        yaxis_id: energy
        type: column
        name: Energy
        stroke_width: 2
        group_by:
          func: sum
          duration: 1h
      - entity: sensor.YYY
        yaxis_id: power
        type: line
        name: Power
        stroke_width: 2
        group_by:
          func: avg
          duration: 1h
      - entity: sensor.ZZZ
        yaxis_id: energy
        type: line
        name: ZZZ
        stroke_width: 2

``yaml

**Screenshots**
If applicable, add screenshots to help explain your problem.
![image](https://user-images.githubusercontent.com/108026974/179856271-42a5f0de-4097-4dd7-bc5f-dd93f90e7f50.png)

**Expected behavior**
A clear and concise description of what you expected to happen.

**Desktop (please complete the following information):**
 - Browser I tested on MS Edge, Opera, FireFox, Safary
 - Version [e.g. 22]

**Smartphone (please complete the following information):**
 - Device: [e.g. iPhone6]
 - OS: [e.g. iOS8.1]
 - Browser [e.g. stock browser, safari]
 - Version [e.g. 22]

**Additional context**
Add any other context about the problem here.


[BEAM-13219][Playground] Initialise structure to find and validate tagged files

Added base structure to find and verify beam examples

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @pabloem

LGTM


New Minecraft Bedrock version 1.21.50

Chatbot is unable to connect after update.
We are waiting for underlaying protocol library to be updated.
https://github.com/PrismarineJS/bedrock-protocol

Dependencies updated.


(JUP-12) Updated Contact Buttons and Minor fixes to Other Pages

CONTACT BUTTONS:
Contact Buttons were updated to adhere better to Design Team's Figma. Colors were also changed and icons are more distinguishable when hovered over by mouse.
MINOR FIXES:
Capitalization of the settings page for unsigned users was fixed.
About Page had redundant code dealing with max width removed.

Run npm run build and fix the issues to be able to view the deploy. Some issues with eslint when build

I ran npm run build and the issues were fixed

I moved the object into a new file called ContactIcons.


create module for sqlServer db extension

Shouldn't the new module be: legend-engine-xt-relationalStore-pure-sqlServer

We may want to add connection acquisition code in module for each db. Hence I skipped the 'pure' part.


Error in Advance video recorder

Hi @triniwiz. I need the advanced functions. I have installed https://triniwiz.github.io/nativescript-plugins/api-reference/video-recorder.html#installing. Has the code changed significantly or will previous code work.
Is this link for the advanced version, getting error:-
ERROR in ./video/video-page.xml
Module not found: Error: Can't resolve '@triniwiz/nativescript-videorecorder/advanced' in '/Users/nick/Documents/NativeScript/Projects/MyApp/app/video'
@ ./video/video-page.xml 1:91-147 2:109-165
@ . sync (?<!\bApp_Resources\b.)(?<!./\btests\b/.?).(xml|css|js|(?<!.d.)ts|(?<!\b_[\w-]*.)scss)$
@ ./app.js

It's not there any more I'll be moving it over to nativescript-fancy-camera

Ah ok, when will that be usable. Why have you split the functions to a new plugin.


Global variable that can store settings fetched from database

Hello and thank you for this great package. I really appreciate your hard work. Tried many tenancy packages but this is the best.
Just a question regarding the performance of the app. Is there any recommendation from you of where to store a global variable that will keep a tenant settings fetched from database?
Tried to search the documentation but I didn't find anything helpful (correct me if I'm wrong).
Note that this global variable needs to be declared after tenancy logic bootstraping. Thank you.

Once the tenant is identified, it's stored in the service container. The tenant() helper will retrieve it.
Also, there's "cached tenant lookup" in the docs. This lets you get the tenant from e.g. Redis rather than having to make a DB query.


[Feat] Release of OpenPack Dataset (v1.0.0)

Overview
This PR transforms and initializes this repo for the official release of OpenPack Dataset (v1.0.0).
Originally, this repo was used to manage metadata and annotations. However, we decided to use this repo to gather necessary information and track changes on our datasets.
Major Changes

[x] Add dataset features.
[ ] Move release notes from HP.
[ ] Move Dataset docs from HP and optk repo.
[x] Move download tools

Todo

Setup CopyBara to sync between repos.

Sample of Data Sheet
Datasheet seems useful and I want to know this before writing our dataset paper.
But I think it's better to split PR for the datasheet because it gonna be a heavy task.
https://github.com/TristaCao/into_inclusivecoref/blob/master/GICoref/datasheet-gicoref.md


DBZ-6535 Cleanup duplicit jobs from jenkins

https://issues.redhat.com/browse/DBZ-6535

@MartinMedek  upstream-artifact-server-prepare.sh is empty on puprose?

@MartinMedek upstream-artifact-server-prepare.sh is empty on puprose?

I think it is a PR issue, the file is not empty https://github.com/MartinMedek/debezium/blob/DBZ-6535/jenkins-jobs/scripts/upstream-artifact-server-prepare.sh


Query priority

Use case: Set the priority of queries that modify data
Feature description: When I issue an update statement and it may affect a large number of rows, it would be great if I could set the priority. The idea is to allow expected long running queries to be ran in the background without causing noticeable performance degradation.
UPDATE TABLE SET colA = someVal priority=2;

hi @bputt, thanks for your suggestion. we put it on the backlog. i'll keep you up to date.


Fix handling of virtualenv and poetv plugins

Fix #2148
If airline#extensions#poetv#enabled is not set, get(g:, 'airline#extensions#poetv#enabled', 1 will return 1 (same for airline#extensions#virtualenv#enabled).  Thus, if both extensions are not set and $VIRTUAL_ENV exists, the last elseif evaluates as True and the virtualenv will be automatically appended using fnamemodify($VIRTUAL_ENV, ':t').  With this PR the virtualenv will be automatically appended only if either extension is enabled.
It may be good idea to include in the docs an example of how one could set a section or part explicitly to fnamemodify($VIRTUAL_ENV, ':t') if they do not have/want either extension.

hm, this means I have to manually enable either the poetv or virtualenv extension and it does no longer work by default?

It looks like it.

Let's merge it, as people prefer to have it disabled unless explictly enabled.


swaggertype only supports basic types

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I am trying to use custom type with generic and would like to overwrite it when generating swawgger output, however looks like swaggertype only support basic types
ex:
type Client struct {
	Id string `json:"id" validate:"required"`
	Dob      optional.Optional[string]   `json:"dob" validate:"omitempty" swaggertype:"string"`
	Location optional.Optional[Location] `json:"location" validate:"omitempty" swaggertype:"Location"`
}

The swag init will fail as it does not understand the Location type.
Describe the solution you'd like
A clear and concise description of what you want to happen.
swaggertype should be able to overwrite to any type, as long as it is available in the go app, or there should be some way to define custom types to only parse the generic type.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

After playing around with the swag more it looks like we are able to override any type to any other type with the global override:
https://github.com/swaggo/swag#use-global-overrides-to-support-a-custom-type
Simple .swaggo file with something like:
replace nullable.Nullable[Location] model.Location
replace nullable.Nullable[Image] model.Image
replace nullable.Nullable[Date] model.Date
replace nullable.Nullable[string] string

will do the job


Improve non-DI usage of built-in feature filters

After Microsoft.FeatureManagement 3.1.0, we exposed feature manager and ConfigurationFeatureDefintionProvider to public and the non-DI usage of Feature Management is supported:
IConfiguration configuration = new ConfigurationBuilder()
    .AddJsonFile("appsettings.json")
    .Build();

var featureDefintionProvider = new ConfigurationFeatureDefinitionProvider(configuration);

var featureManager = new FeatureManager(featureDefintionProvider)();

bool res = await featureManager.IsEnabledAsync("MyFeature");

However, the built-in feature filters are designed for DI usage originally. If users want to use feature filters in non-DI Feature Management. The usage will be like:
IConfiguration configuration = new ConfigurationBuilder()
    .AddJsonFile("appsettings.json")
    .Build();

var featureDefintionProvider = new ConfigurationFeatureDefinitionProvider(configuration);

ILoggerFactory loggerFactory = new LoggerFactory();

var targetingFilter = new ContextualTargetingFilter(Options.Create(new TargetingEvaluationOptions()), loggerFactory);

var timeWindowFilter = new TimeWindowFilter(loggerFactory);

var featureManager = new FeatureManager(featureDefintionProvider)
{
    FeatureFilters = new List<IFeatureFilterMetadata>() { targetingFilter, timeWindowFilter },
    Logger = loggerFactory.CreateLogger<FeatureManager>()
};

bool res = await featureManager.IsEnabledAsync("MyFeature");

Notice that the current constructor of built-in filters are:
public PercentageFilter(ILoggerFactory loggerFactory)
{
    _logger = loggerFactory.CreateLogger<PercentageFilter>();
}

public TimeWindowFilter(ILoggerFactory loggerFactory)
{
    _logger = loggerFactory?.CreateLogger<TimeWindowFilter>() ?? throw new ArgumentNullException(nameof(loggerFactory));
}

public ContextualTargetingFilter(IOptions<TargetingEvaluationOptions> options, ILoggerFactory loggerFactory)
{
    _options = options?.Value ?? throw new ArgumentNullException(nameof(options));
    _logger = loggerFactory?.CreateLogger<ContextualTargetingFilter>() ?? throw new ArgumentNullException(nameof(loggerFactory));
}

public TargetingFilter(IOptions<TargetingEvaluationOptions> options, ITargetingContextAccessor contextAccessor, ILoggerFactory loggerFactory)
{
    _contextAccessor = contextAccessor ?? throw new ArgumentNullException(nameof(contextAccessor));
    _contextualFilter = new ContextualTargetingFilter(options, loggerFactory);
    _logger = loggerFactory?.CreateLogger<TargetingFilter>() ?? throw new ArgumentNullException(nameof(loggerFactory));
}

The current non-DI usage looks kind of messy.
There are two inconsistent things:

Built-in feature filter constructors require an ILoggerFactory parameter which cannot be null. FeatureManager has a public ILogger property which can be null.
Currently, the constructor of FeatureManager has a default value for FeatureManagementOptions #363. Targeting filters still require an IOptions parameter which does not have a default value.

I propose that we should at least support such non-DI usage for built-in feature filters:
IConfiguration configuration = new ConfigurationBuilder()
    .AddJsonFile("appsettings.json")
    .Build();

var featureDefintionProvider = new ConfigurationFeatureDefinitionProvider(configuration);

var targetingFilter = new ContextualTargetingFilter();

var timeWindowFilter = new TimeWindowFilter();

var featureManager = new FeatureManager(featureDefintionProvider)
{
    FeatureFilters = new List<IFeatureFilterMetadata>() { targetingFilter, timeWindowFilter }
};

bool res = await featureManager.IsEnabledAsync("MyFeature");

by enabling logger of built-in filters to be null and giving a default value for TargetingEvaluationOptions.
This change will make non-DI usage simpler.
My further thought is to make built-in feature filters have the same pattern as FeatureManager where Logger and TargetingEvaluationOptions are public properties instead of parameters of constructor.

@jimmyca15 @rossgrambo @zhenlan What do you think?

It's reasonable for the logger parameter to be optional.
Should we add built-in filters automatically?
It will be nice to have featureManager.FeatureFilters.Add(IFeatureFilter).

@zhenlan

It's reasonable for the logger parameter to be optional.

Agree.

Should we add built-in filters automatically?

For DI usage, built-in filters have already been added automatically.

It will be nice to have featureManager.FeatureFilters.Add(IFeatureFilter).

Do you mean that it would be better to have the usage look like:
var timeWindowFilter = new TimeWindowFilter();

var featureManager = new FeatureManager(featureDefintionProvider);

featureManager.FeatureFilters.Add(timeWindowFilter);

Should we add built-in filters automatically?

For DI usage, built-in filters have already been added automatically. Did you mean we should add them automatically when feature manager is constructed?

Right, for non-DI usage.

It will be nice to have featureManager.FeatureFilters.Add(IFeatureFilter).

Do you mean that it would be better to have the usage look like:
var timeWindowFilter = new TimeWindowFilter();

var featureManager = new FeatureManager(featureDefintionProvider);

featureManager.FeatureFilters.Add(timeWindowFilter);

I wish people couldn't set featureManager.FeatureFilters but add items.

After discussed with Jimmy, we thought we should keep the current usage:
var featureManager = new FeatureManager(featureDefintionProvider)
{
    FeatureFilters = new List<IFeatureFilterMetadata>() { targetingFilter, timeWindowFilter }
};

Currently, FeatureFilters is a public property with the init accessor. The reason of this design is the idea that we want feature filters to be static after FeatureManager is constructed.
var featureManager = new FeatureManager(featureDefintionProvider);

featureManager.FeatureFilters.Add(timeWindowFilter);

This usage will break this idea.
@jimmyca15 @zhenlan

I understand featureManager.FeatureFilters cannot be set to another List object once it's initialized, but can't people call Add on the existing list object anyway?

@zhenlan

but can't people call Add on the existing list object anyway

FeatureManager.FeatureFilters is an IEnumerable, no filters can be added. By design so that the feature manager is constructed as intended from the onset.

I see. Thanks. I don't have any better ideas, but kind of a bummer users have to know IFeatureFilterMetadata even just to use built-in filters.


Secret auction smart contract

Checklist

[x] Auction
[x] AuctionFactory
[x] AuctionPricer

Refer to https://github.com/PortalNetwork/Secret-Auction-Demo


read: connection reset by peer", received prior goaway: code: NO_ERROR

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
im getting a random read: connection reset by peer in my application using istio-proxy as sidecar. When i check istio-proxy's logs, there is a lot of warn: xdsproxy        upstream [6396] terminated with unexpected error rpc error: code = Unavailable desc = closing transport due to: connection error: desc = "error reading from server: read tcp <IP_ADDRESS>:60692-><IP_ADDRESS>:15012: read: connection reset by peer", received prior goaway: code: NO_ERROR. It happens sometimes when i try to access external services.
Version
client version: 1.20.0
control plane version: 1.18.2
data plane version: 1.18.2 (654 proxies)
Client Version: v1.25.0
Kustomize Version: v4.5.7
Server Version: v1.25.15-eks-4f4795d

Additional Information
No response

Any other information you can provide about the setup? Clean install?  Recent upgrade? New pod deployment/re-deploy to an existing istio installation? Anything suspicious in istioctl proxy-status output (STALE?).  Anything from istioctl analyze?  If 15012 is having problems, the sidecar probably isn't receiving updates


Added missing . in changelog.

Fixed changelog (added missing period) from previous PR (#483)

😄

Btw, we rolled out Danger in Grape, it now warns you when such terrible things as missing periods are in CHANGELOG. See https://github.com/ruby-grape/grape/blob/master/Dangerfile. I am trying to figure out how to make a package that can be reused across all Grape projects.


Add missing ofMain includes

It is needed for ofLogError. If the coller code does not include ofMain itself, it doesn't build.

Makes sense
Sometimes it’s better to just include the ofLog header for faster compile times (most people don’t use precompiled headers)
Apologies for being really late to pull this


Plays audio from linked YouTube video

I pasted a YouTube link and it started playing audio - what I assume were ads from YouTube - in the background until I quit Obsidian entirely...

Fixed in the latest version!

Many thanks! :tada: