Alternate Norm definition for IterativeSolvers

In #3448, I asked about solving a positive semi-definite system with a known, low-dimensional null space. The suggested solution was to create a wrapping Operator around the system that manually removed the projection of the vector into the null space, i.e., to project into the system range space.
This worked very well for the small problems I was considering at the time, but I have found it does not work as well as the problem size scales. I believe the problem may be due to the fact that IterativeSolver implements a non-virtual Euclidean Normfunction that (implicitly) measures contributions to the residual from the null space of the range space projected Operator, which we in general do not expect to decrease.  As a result, the solver uses the specified max number of iterations without converging, although a manual check I do on the projected final residual shows it has an acceptable residual, and therefore should have returned at some earlier iteration.
The cleanest modification, I think, would be to make IterativeSolver::Norm virtual so that I can override it in a derived type, e.g. a class MySpecializedLBFGSSolver : public LBFGSSolver. Would you agree? If so, I can open a PR making the change.

We have something like that in a draft branch, solver-monitor-controller, (see diff here: https://github.com/mfem/mfem/compare/master...solver-monitor-controller) that allows derived classes from IterativeSolverMonitor to be used to indicate early convergence using any kind of logic they want. We use that to change the stopping criterion of CG to be relative $\ell_2$ norm reduction of the residual. The branch is fairly early draft but I believe it can be extended to LBFGSSolver and other iterative solvers to allow more general stopping criteria. Take a look if you want and let us know what you think.

Thanks for linking that branch. I agree the HasConverged method would fix the performance issue I have with taking unnecessary steps by allowing a manual "early" return. On the other hand, the norm values reported (when requested) will be nonsensical - admittedly a lesser concern.
Could this be an "either or both" fix where I could override the current Norm and use standard convergence criteria, and/or use custom criteria?

I don't see a problem with making IterativeSolver::Norm virtual, if you want to have the option to override it.

I will open a PR doing this next week. Thank you for the feedback.


Bundle exonum-configuration service into EJB App [ECR-1323]

Overview
Configuration service bundled into EJB App (without possibility to disable it).

See: https://jira.bf.local/browse/ECR-1323
Definition of Done

[ ] The continuous integration build passes

Rebased, no more experimental


exp run: Explicitly document repro options.

Report
https://dvc.org/doc/command-reference/exp/run doesn't document or list all the actual options of the command but instead mentions repro options in the Synopsis and a small note:

The page should be self-contained and list all options, matching the dvc exp run -h output in the CLI.
During support duty, at least a couple of times I answered questions where the users were not aware of dvc exp run supporting a flag that is par of those repro options.

Semi-related to https://github.com/iterative/dvc/issues/7866. I think this gets us closer to having a single command for running pipelines.


[BUG] useHashLocation not syncing with state

With the useHashLocation hook, the active route does not sync with the current state/location, once it is updated. The initial location loads the correct route.
For example/reproduction:

Set up a project with wouter and hash routing.
Create a route, let's call it test. Add a link from it to the index (#/) or a navigate() call (using useLocation)
Go to a #/test
Click the link you added. The location will be updated, but the active route will not change.

Hi! I can't reproduce this, would you mind sharing your code?

Hey! Yeah so it is really simple, just a home page and an App component:
export default function App() {
	return (
		<>

				<Router hook={useHashLocation}>
                    <Switch>
                       <Route path="/config" component={Config} />
                       <Route path="/" component={Home} />
                    </Switch>
                  </Router>

		</>
	);
}

Hello — I think I stumbled on this issue today and can share a reproduction.
Here's a replit link that has runnable code: https://replit.com/@neoeno/Reproduction-of-wouter-active-links-issue-with-hash-location
An example of how it looks in the browser:
https://github.com/molefrog/wouter/assets/1007202/0a75aaaf-dd43-4e7c-a561-9417cba3148e
And here's the relevant code:
// App.jsx

import "./App.css";
import { Route, Router, Link } from "wouter";
import { useHashLocation } from "wouter/use-hash-location";

export default function App() {
  return (
    <>

Default useBrowserLocation activates the links

      <Router>

            <Link
              href="/route-one"
              className={(active) => (active ? "active" : "normal")}
            >
              Link to Route One
            </Link>

            <Link
              href="/route-two"
              className={(active) => (active ? "active" : "normal")}
            >
              Link to Route Two
            </Link>

        <Route path="/route-one">

Route One

        </Route>
        <Route path="/route-two">

Route Two

        </Route>
      </Router>

useHashLocation does not activate the links

      <Router hook={useHashLocation}>

            <Link
              href="/route-one"
              className={(active) => (active ? "active" : "normal")}
            >
              Link to Route One
            </Link>

            <Link
              href="/route-two"
              className={(active) => (active ? "active" : "normal")}
            >
              Link to Route Two
            </Link>

        <Route path="/route-one">

Route One

        </Route>
        <Route path="/route-two">

Route Two

        </Route>
      </Router>
    </>
  );
}

/* App.css */

.active {
  border: 1px solid red;
}

I believe the issue occurs here: https://github.com/molefrog/wouter/blob/v3/packages/wouter/src/index.js#L239
  return asChild && isValidElement(children)
    ? cloneElement(children, { onClick, href })
    : h("a", {
        ...restProps,
        onClick,
        href,
        // `className` can be a function to apply the class if this link is active
        className: cls?.call ? cls(path === href) : cls, // <------
        children,
        ref,
      });

From debugging, href ends up having the #, while path does not. Could be related to #421?
Thanks for all your hard work on wouter! Please do say if you'd appreciate a PR to fix.

hi @neoeno, this is indeed a bug. the href gets transformed using the hrefs() function a few lines above. so I guess we need to keep the original href and store the transformed one somewhere else. feel free to file a PR 💁♂


V3.9

We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FF5APCVVRGPTK4P4M9CDDC3G

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FFFF0AZ9ZDYAXYK29ZSF4NCA

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FFFF0AZ92K0TW58G4363JCZK

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQ13CCPMQ0ZTKE3DHRTXJSWN

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQ14R5C33QS8801C1SQYY3ZJ

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQGS7W1TM8RJP3RM27FAGYW5

RunTestJar RESULT: Total tests run: 257, Failures: 22, Skips: 0 Reviewers , please check that the changes in this PR did not cause the failures in  http://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-1506.html


chore: get rid of urfave

Motivation
Changing urfave/cli in cmd/merge-nodes in favor of cobra.
Description
Removing this unnecessary dependency. We already depend and use cobra and urfave is just used in one command.

Test Plan
Tests passing.
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed
[ ] Update changelog as needed

bors try

bors merge


contrib: Add rebase-bindata shell function

This new function allows easy rebase of commits with changes to the bpf
directory when there are merge conflicts with daemon/bpf.sha.
To use, you need to source contrib/shell/util.sh.
Expected usage:
$ git rebase origin/master
<Merge failure on daemon/bpf.sha>
$ rebase-bindata
<For each conflict, your editor opens to review the commit. Save&exit>
Signed-off-by: Joe Stringer<EMAIL_ADDRESS>

Isn't bindata.sh apply idempotent and correct such that you can resolve the conflict by just running it and clobbering the conflicted file?

@raybejjani Unfortunately not. The problem is that the daemon/bpf.sha is actually included in the Makefile which evaluates the statements inside. The git <<<<, ====, >>>> are not valid Make syntax, so it causes make to fail completely.

I'm not sure I follow. Do you mean something like this?
$ make reset-bindata
echo "XXX" > daemon/bpf.sha
echo "YYY" >> daemon/bpf.sha

I think my problem was trying to consistently come up with the BPF_FILES in the way that apply-bindata does. This does sound useful though, and could perhaps make this script more robust by reusing such a target. I'll probably mull it over on a train some time.

test-me-please

This change is only in contrib/, and should not affect any builds/CI. Marking ready-to-merge despite CI failure, because the CI failure is a flake.

I meant in bindata.sh itself, making it the source template of that file:
$ cat <<EOF | sed 's/thing/thang/'
> hello
> thing
> x=thing
> EOF
hello
thang
x=thang

Not a big deal in any case, it doesn't change your script in a big way (but does make the bpf.sha file more deterministic in content).


FunctionValuesConverged with relative = true

For checking the convergence based on function values, we have the condition:
info.length >= 2 && (state.adjustedValue - info.max).abs <= tolerance * (if (relative) state.initialAdjVal else 1.0)
My understanding is that it checks whether the absolute difference between the recent maximum and current adjusted value is less than or equal to the tolerance scaled by the initial adjusted value (for relative = true). If that's correct, then imagine a function having negative values from the initial point till the minimum. Then this condition can never be satisfied, right? Shouldn't we use abs also on the RHS of the inequality?

yep, good catch!


ambient: match multiple svc VIPs in waypoint

Please provide a description of this PR:
Fixes #51886
Istio will store all cluster VIPs for service entries, but these VIPs will be applied only to waypoint listeners for now -  I will fix sidecars in a follow-up PR.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

/test integ-ambient-ipv6

@jewertow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jewertow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test unit-tests-arm64

release-notes_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test release-notes

lint_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jewertow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test unit-tests-arm64

release-notes_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test release-notes

lint_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test lint

integ-ambient-ipv6_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
false
/test integ-ambient-ipv6

integ-ambient_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jewertow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test unit-tests-arm64

release-notes_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test release-notes

lint_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test lint

integ-ambient-ipv6_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
false
/test integ-ambient-ipv6

integ-ambient_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test integ-ambient

integ-security-multicluster_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test integ-ambient-ipv6

/test integ-ambient

/test all

@jewertow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test unit-tests-arm64

lint_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test lint

integ-ambient_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test integ-ambient

integ-security-multicluster_istio
75d1bdd4703521de7758b43ad6a4b82227f1f006
link
true
/test integ-security-multicluster

release-notes_istio
275e92bb65b0664cf2b905a3cc12d5fbf368d787
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test integ-ambient-ipv6

/test integ-ambient-ipv6

+1 to on by default in ambient (as we have done in other areas for dual
stack)
On Tue, Jul 9, 2024, 4:14 AM Jacek Ewertowski @.***>
wrote:

@.**** commented on this pull request.
In pilot/pkg/model/service.go
https://github.com/istio/istio/pull/51939#discussion_r1669970539:

@@ -1275,7 +1275,7 @@ func (s *Service) GetExtraAddressesForProxy(node *Proxy) []string {
// GetAllAddressesForProxy returns a k8s service's extra addresses to the cluster where the node resides.
// Especially for dual stack k8s service to get other IP family addresses.
func (s *Service) GetAllAddressesForProxy(node *Proxy) []string {

if features.EnableDualStack && node.Metadata != nil && node.Metadata.ClusterID != "" {

if (features.EnableDualStack || features.EnableAmbient) && node.Metadata != nil && node.Metadata.ClusterID != "" {

I would rather say that dual-stack is enabled by default in ambient mode.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51939#discussion_r1669970539, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKAX65ZJO72H5AIAKDZLOLXXAVCNFSM6AAAAABKQ2QAWGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRVGQZDQMZRG4
.
You are receiving this because your review was requested.Message ID:
@.***>


Can you please help me with File upload and read from it in assistant?

Hi @JZO001,
my code was working perfectly fine. but now they have decided to work with vector store.
my complete scenario is like below.
upload file then
create assistant with all details
attach this file to current assistant(CreateAssistantFileRequest). (here i was using below code and now its giving false result.)
create the thread.
create MessageResponse
create RunResponse
if run response true then get all MessageData from MessagesService.
after all these i was deleting file and assistant in finally block.
so what to do now to fix this?

var createAssistantFileRequest = new CreateAssistantFileRequest()
{
    AssistantId = assistantId,
    FileId = assistantFileId
};

var createAssistantFileResult = await openAi.AssistantFileService.CreateAsync(createAssistantFileRequest, CancellationToken.None);

can anyone please help me? i am stuck.

@JZO001 , can you please help? if this is possible with current code then can you please tell me how to do it?


Move “LinkToTop” icon to the center of the page. In the bottom right it is visually conflicting with Intercom

Issue 13 https://github.com/near-daos/astro-ui/issues/91

Verified on dev. Fixed


Move package future from extended to core

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR moves package future from the extended packages to core packages. This package is a requirement for pytorch golden container (pytorch spec will be added to Mariner soon).
Change Log

Package future is moved from SPECS-EXTENDED to SPECS, which results in the package becoming a core package.

Does this affect the toolchain?

NO
Associated issues

Links to CVEs
Test Methodology

Tested locally as well as in buddy build.

AMD64 Buddy Build Pipeline Build Id: 296930
ARM64 Buddy Build Pipeline Build Id: 296931

Quick question first- are we building PyTorch with caffe2 support? Just wondering if we truly need this dependency. A PR was merged to the PyTorch upstream a few days ago to remove this dependency from the caffe2 codebase. It looks like this dependency is only in the caffe2 codebase. For reference, caffe2 is a deprecated framework that isn't build by default as part of PyTorch, but lives in the same source tree.

Thanks for bringing the point about caffe2, Olivia. You're right, we don't need the future package for pytorch at runtime. I will be closing this PR.


Decide what errors are Fatal

We need to figure out what sorts of errors are recoverable and what aren't.
For instance, if a plugin wants to log a message and some error happens, do we kill the process? Or do we try to continue.
Or: if a plugin crashes, do we kill the whole framework or try to restart it?

I tend to lean toward making as many errors as possible Fatal.


Differences with postcss-cssnext?

Is there any (beside the fact that this plugin do not disable some features when the browsers scope don't need some) ?

Yea, this project was made from my confusion of your cssnext project, like which one do I use? Seems like I could use that instead, but I'm not looking for fallbacks, so I am just using the plugins that are necessary for me.

That's why this project have a "browsers" option: to disable the thing you don't need (like autoprefixer does).

Does that prevent it from being installed or exclude from processors? If it does then it should speed up the compile time. I might check it out, thanks for pointing that out!

For now it just avoid to run the plugins, but that might be an enhancement to not even download them (=> only npm install packages that are required by the user scope)

Can you explicitly turn off all fallbacks?

Yes via the "features" option http://cssnext.io/usage/#features
The only two options that will be kept after official migration to postcss-cssnext will be "browsers" and "features" :)


Check tuple size on multiple assignment

Motivation

Requested by a user a way to mitigate future production incidents.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_QfVEdmFqptEhdf
→ https://go/builds/bui_QfVEcKXV4u4NTR
→ https://go/builds/bui_QfVEP9uhxpVDSp

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_QfVrHfjmInQT1x
→ https://go/builds/bui_QfVrFziCBTjwHV
→ https://go/builds/bui_QfVr0vSP6cd59A


Fix documentation

Map is only called once (already fixed on #714)
.toObject() returns a JS Object, not a Map.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron do you need any help to review all PRs?

I do need help reviewing!
However both of the changes in this PR are incorrect and were correct before being changed

Ah no wait, I'm reading the diff upside down! Quick someone get me coffee!

LOL! Nice =)


[Storage] AWS S3 Bucket Share between two specific users

** Which Category is your question related to? **
Storage
** What AWS Services are you utilizing? **
Auth and Storage
** Provide additional details e.g. code snippets **
I am building an app where I would like to send a picture to another authenticated user that is only visible to the user that receives it (if the sender can see it that is fine).  The protected level looks promising but as far as I understand allows for anyone that is authenticated to see the uploaded content. I was wondering if this is even possible using amplify or if I am misunderstanding something.

Transferring over to the CLI team. If we decide to pursue this, this will need to be implemented on CLIs side first.

Hello guys, I have a similar case and I am wondering why cannot we achieve what is explained in the question with protected level? I read this issue https://github.com/aws-amplify/amplify-js/issues/2203 and it turned out that basically it is not possible to fetch other users' protected files if we don't know their user_identity_id.
I understand that a file is publicly open to anyone but without knowing a user_identity_id you won't be able to construct a path to a file. So, answering this question, why cannot we save User one identity ID in the database, and if User two wants to see his/her file, we can construct a correct path?
@manueliglesias, @sammartinez, am I correct with this (I understand that a file is public anyway)? Thank you.

@turakvlad I'm experiencing the same frustration here, I know it's a 2 years old issue, but any progress on this?  Or workarounds?


How much data can I send through event bus?

I am using this client in my iOS application and when I publish JSON object:
{"id": 1, "secId": 2, "userId": 5, "msg": "0", "session" : "d0dab4fe26e52b745ea430d9c24345a6575a844de478b8db41cb30fc6bde23dd" }
I'm receiving an error as "Fatal error: Not enough bits to represent a signed value" and application crashes. And when I remove "session" parameter then object sent without any problem.
Any solution?
update1:
crashing in Util.swift file, at line number 38 --> bytes.append(UInt8(value >> Int32(x * 8)))
update2:
We can only send 256 bytes of data as we have used UInt8 to convert JSON string to bytes, can we increase this limit?

Resolved the issue by implementing another UInt8 initializer as follows
UInt8(truncatingIfNeeded: value >> Int32(x * 8))
A big thanks to @garrialmighty.


[AutoRelease] t2-vmwarecloudsimple-2022-11-02-62501(Do not merge)

https://github.com/Azure/sdk-release-request/issues/3356
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=978
BuildTargetingString
azure-mgmt-vmwarecloudsimple
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3356

/check-enforcer override

/check-enforcer override


How to add videos from different scenarios into the same JSON file for training?

Hi, thank you for sharing the great work!
I have 10 sets of scene data, how do I combine them into a JSON file to train SUDS?

You need to create a "metadata.json" file where all of the poses across videos are mapped to the same coordinate system, and where the frames are labeled with the appropriate "video_id" parameters.

Thanks a lot!


Include file path in Syntax error messages

When using ES6 modules it was not possible to identify which module
an error originates from.
This PR changes the error message to also include the file path using
the file:line:column format, and updates the source context printing for
unhandled exceptions to use the correct file.
Co-authored-by: Marko Fabo<EMAIL_ADDRESS>JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai<EMAIL_ADDRESS>

@dbatyai Please rebase the PR.


Add feature to add labels when adding the card

It would be great to apply a label to the card you are creating via Add To Trello
Hope you will consider adding this.
Thanks!

Thumbed up, this plugin is almost perfect for our QA team but lacks the ability to label an issue as a bug.

similarly, adding a due date would be round out the logical additional fields given how the chrome extension interacts


[spark]Support get full table name include database

Purpose

Support get full table name include database
ranger spark auth plugin check auth error

Tests

API and Format

Documentation

This is the define of String name()
  /**
   * A name to identify this table. Implementations should provide a meaningful name, like the
   * database and table name from catalog, or the location of files for this table.
   */
  String name();

I don't think it is a good idea for range to get database through it, because this interface is just a name and users may define it arbitrarily.
However, enriching this name helps display information in spark UI, I remember iceberg is catalog.db.name now.

This should be fixed in kyuubi range plugin

But it's not unique if there is only one table name, which doesn't feel good.

But it's not unique if there is only one table name, which doesn't feel good.

Yes, as I said before, this name will eventually be displayed in the UI, it'll be greate to like catalog.db.name
The current implementation requires modifying the constructor, it would be nice if the paimonTable could include it.

https://github.com/apache/paimon/pull/3680 focus on the same porblem and merged, sorry for that

Fixed in:
https://github.com/apache/paimon/pull/3680
https://github.com/apache/paimon/pull/3686


Set up a LibGDX project on a flash-drive or on GitHub with dependencies?

Is there any way to setup an eclipse project on a flash drive or on GitHub that i can easily just import from any eclipse on any computer with dependencies already packaged so I don't have to download them again?
I can't find any documentation or tutorials on how to do this.

I have a branch on my fork which does this, its the relative branch and it will pull in the dependencies and make them local to the project, allowing you to use your project from a USB. Note that it's specific to eclipse, and you lose gradle ide features this way.
----- Reply message -----
From: "Andrew"<EMAIL_ADDRESS>To: "libgdx/libgdx"<EMAIL_ADDRESS>Subject: [libgdx] Set up a LibGDX project on a flash-drive or on GitHub with dependencies? (#3588)
Date: Sun, Nov 22, 2015 11:58
Is there any way to setup an eclipse project on a flash drive or on GitHub that i can easily just import from any eclipse on any computer with dependencies already packaged so I don't have to download them again?
I can't find any documentation or tutorials on how to do this.

Reply to this email directly or view it on GitHub:
https://github.com/libgdx/libgdx/issues/3588

Gradle was added for dependency management among other things. Moving away from dependency management invites trouble on many levels.
I don't know if there is a way to 'migrate' the gradle dependency cache from an installation to another machine. Perhaps you should set up your own artifact repository and draw from there?

https://github.com/libgdx/libgdx/wiki/Issue-Tracker


Is py31compat.py still necessary?

There still seems to be a py31compat file in the tree, but Python 3.1 is no longer supported. I see a few hits for it not under version guards (e.g. here).
There's also a similar one in pkg_resources.
Are these still necessary?
Maybe it would be a good idea to re-organize all the pyXYcompat functions into a single _compat.py file, and put them under version guards, that way we can be confident that as soon as we drop compatibility for a version, we can drop all the compatibility shims as well.

Py31compat is necessary until we drop support for Python 2 also. But where Python 2.7 also added support, that functionality can be removed.
The imports are meant to be without version guards in order to keep the main implementation clean and simple (not lots of guards in the import section of every package). All of the compatibility is managed in the compatibility module, acting as an adapter and guaranteeing the requisite interface on all supported versions.
I named the modules as I did so they would ideally clearly designate when they can be removed. So when Python 3.1 (and earlier) support is dropped, one goes through the codebase and replaces all instances of py31compat with their native counterpart and removes that module. Moving all of these compat modules into a single file takes away that signal. Of course, you could do it as you describe, with version guards, but then when you're ready to drop support for that version, you have to read through the code and search the codebase for each usage separately.

@jaraco I think one thing about putting them under version guards is that you'll naturally see when they've "aged out" because once you stop testing against a version, the coverage under that guard will go to zero and they can just be safely deleted.
If you have to specify which specific module they come from, then you have to dig it out of more files. Still, I do think it's a reasonable enough approach - since that will allow you to quickly find all the files that are using functions from pyXYcompat and remove the shim entirely.
Maybe all the py31compat stuff that still applies to Python 2.7 should be moved into py27compat.py, and the rest should be deleted?

I think of pyNNcompat as performing a similar role to what six does, except for arbitrary Python version campatibility... provides a uniform interface for imports and a clear signal as to why it's there.

Maybe all the py31compat stuff that still applies to Python 2.7 should be moved into py27compat.py, and the rest should be deleted?

There's just one class there. At this point because support for Python 3.3 is dropped, Python 2.7 is the only motivation, so it would not be crazy to move it to the other module. Same would apply to py33compat.py. I personally find it useful designate the precise version compatibility it supplies - in case you ever wanted to copy that functionality to another project. If you wish to consolidate these modules into one, I wouldn't object.


Not able to use custom content after upgrade to ver 6

"@angular/core": "6.0.4",
"angular2-cookie-law": "^6.0.2",
When I use
<cookie-law position="bottom" expiration="30">
 Lalala
</cookie-law>

It still shows the default text: By continuing to browse the site ...
Expected behaviour:
Would like to see Lalala text instead of the default one.

Sorry, please ignore. After reinstalling it works as expected.


where 1 / where true generates parse error

SELECT * from myTable where 1 and myDate < current_date()

or simply
SELECT * from myTable where 1
SELECT * from myTable where TRUE
SELECT * from myTable where 0
SELECT * from myTable where FALSE


[Feature Request] For IAP, allow and/or document a way to use max available workers the device supports

Description

IMPORTANT: if the defect is reproduced only in a workflow from within the Visual Studio IDE then do not report the issue here - instead, please report it using Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com.
For a defect specific to the MSTest V2 test framework, describe the issue you've observed.

Steps to reproduce

What steps can reproduce the defect?
Please share the setup, sample project, target platform (desktop, core, uap)
N/A

Expected behavior

Share the expected output
N/A

Actual behavior

What is the behavior observed?
N/A

Environment

Please share additional details about the test environment.
Operating system, Build version of vstest.console, Package version of MSTest
framework and adapter
N/A

This is a feature request.
Right now (at least from what I've seen documented), this is the recommended way to include a number of workers for IAP.
[assembly: Microsoft.VisualStudio.TestTools.UnitTesting.Parallelize(Workers = 8, Scope = Microsoft.VisualStudio.TestTools.UnitTesting.ExecutionScope.MethodLevel)]

However, it would be good to know if there is a way to specify Workers = MAX_AVAILABLE.  We run our tests on different environments (dev, CI, etc.) and they have different number of cores.
If this is already possible, it should be documented somewhere.
Thanks!
Joe

@singhsarab I'm wondering if this is something that could be achieved through the .runsettings file?
If so, what do you think of something like this:
<RunConfiguration>
  <Parallelize>
     <UseMaxNumberOfWorkers>true</UseMaxNumberOfWorkers> <!-- to use all the available cores -->
     <NumberOfWorkers>4</NumberOfWorkers> <!-- optional if above tag is set -->
  </Parallelize>
</RunConfiguration>

let me know your thoughts, and if i'm in the right path. I'll be willing to work on it ;)

@parrainc
Revisiting this.
It seems like a good idea.
We could also possibly set to 0 like MaxCPUCount set in the RunConfiguration.

Sounds good to me. I'll be working on it to have a PR created soon

I will close this issue, AFAIK we do support 0 similarly to Test Platform.


Support for DVD subs

Please provide support for DVD subtitles

DVD subtitles (VobSub) aren't currently supported by ExoPlayer: https://github.com/google/ExoPlayer/issues/8260

Closing as this is an upstream issue.


[SOAR-0013] Idiomatic naming strategy

Motivation
See proposal
Modifications
N/A
Result
N/A
Test Plan
N/A

Thanks @czechboy0! Review started: https://forums.swift.org/t/proposal-soar-0013-idiomatic-naming-strategy/76242.

@hactar thanks for taking the time to provide your feedback.

Personally I'd argue to make idiomatic the default and bump the version number to signify the "break", documenting that the old behavior is still available via a config change: if we're doing this to make it easier for new people to use this, then they shouldn't have to configure it.

If we were to release a new major version, that would be on the table, but we cannot do this in a SemVer minor release.

When I started using this generator: pretty much any config file that I was provided never contained operationId.

That's an interesting thought. This proposal currently doesn't do anything different to address operations without an operation ID.

I hope the proposal can be amended to have an idiomatic approach for naming operations with slashes in them, as I'm pretty sure this will have snagged others as well when they started.

OOI, what would you write by hand for an operation that did have an operationId but that ID contained a slash?

Default setting: I understand - then I think we should at least ensure it is in the default example of the tutorials so anyone starting out will see it and use it if they copy/paste.
Operations:
get_sol_claims_sol__lcub_claimId_rcub__sol_notifications awesome, yes maybe I remember incorrectly about the _ being the first char then, but still this to me looked more like a debug string than anything else, especially not knowing what sol and lcub were (and the tutorials appeared to generate nice names, so I thought it was broken).
So I'm going to approach this from the other side, what would the perfect easy to read swift function be (assuming claimId is a String)? To me it would be
func getClaimNotifications(for claimId: String) async throws -> [Notification]
So what happened?

the "sol" were dropped, because usually the slashes are more a "space" than anything else
the "mid path" variable was removed from the function name because its actually a function parameter
the "s" from claims was removed because it only makes sense for the root case (GET /claims) but not as soon as any id is present, there you're actually only getting a claim's notification typically in REST Apis

Now I do understand that my function is very idiomatic and makes assumptions on how things should be (I'm a SwiftUI guy, thats how we role 😄). If we want to be less idiomatic about it, some of the steps above could be removed:

getClaimsNotifications would still be great
getClaimsClaimIdNotifications is still readable
getClaims_lcub_claimId_rcub_Notifications is beginning to look like a debug string and mixes camel case and string case , so getClaimsLcubClaimIdRcubNotifications would be a bit better, still not pretty though.

And as far as I understand the whole sol thing was done to prevent naming clashes - but in an idiomatic
as soon as we start adding any sol or lcub or double underscore I'd argue that things become difficult to read. Swift is a camel case and not a snake case language, so I'd try to prevent underscore usage whenever possible.

Question about name overrides in the config file: does that affect properties, types, or both, and is there a way to do it for only a specific property on a specific type? Use case would be fixing the occasional confusing name in the API I'm consuming.

@hactar had some good ideas, but I wanted to address this one:

the "s" from claims was removed because it only makes sense for the root case (GET /claims) but not as soon as any id is present, there you're actually only getting a claim's notification typically in REST Apis

Inflections for plurals are very irregular, and many singulars are also plurals. Rails gave up on auto inflections for this reason (I contributed an inflection patch in the last version where they were being accepted). This wil just chew up people points, especially once you get to things like correct inflections for octopus or correct singular for hooves.
The folks who wrote the API specified claims as plural, and we should stick to that without a compelling reason to deviate.

Inflections for plurals are very irregular, and many singular forms are also plurals. Rails gave up on providing comprehensive auto inflections for this reason (I contributed an inflection patch in the last version where they were being accepted), and instead allowed people to specify mappings. This will just chew up people points, especially once you get to things like correct inflections for octopus or correct singular for hooves.

I agree with this. Inflections are difficult. I was describing my perfect generated function name for the provided example. A generic version would be making a lot of assumptions, like the API in english. If we could do this close to perfectly in most cases it would be awesome, but its not as simple as "remove an 's' if its at the end of a word.

@hactar One possibility might be allowing a struct (or YAML file) to help with inflections e.g.:
struct Inflection {
    let className: String   // Client
    let singular: String    // client
    let plural: String      // clients
}

When you get to languages with noun cases (e.g., many Eastern European languages), plural noun forms get more complex, but we're not generating plural forms, just trying to determine the singular from a given plural used in the openapi.yaml file, so this might be enough for most languages. It even offers a path for those that use pronouns to indicate number, e.g., Polynesian languages.

Thanks again @hactar for bringing up the important topic of synthesized operationIds. I updated the proposal with a solution that's close to your generalized solution: by turning slashes into underscores, and dropping curly braces. In concrete terms, that means that an operation without an explicit operationId that looks like:
GET /claims/{claimId}/notifications

would get the method name: get_claims_claimId_notifications. We also considered dropping the underscores, which would result in getClaimsClaimIdNotifications, but felt that it loses the separation between path components, which is important for understanding the purpose of the path. It's still hopefully a big improvement over get_sol_claims_sol__lcub_claimId_rcub__sol_notifications. And we should always nudge adopters to add explicit operationIds to the OpenAPI doc, which offers the ultimate flexibility.

Question about name overrides in the config file: does that affect properties, types, or both, and is there a way to do it for only a specific property on a specific type? Use case would be fixing the occasional confusing name in the API I'm consuming.

It affects all strings from the OpenAPI document that the generator needs to turn into type/method/property names in the generated Swift code. So currently there isn't any way to only do it for one property in one type, but not for an identically named property in another type. You either use the original generated name, or you override it for all occurrences by using nameOverrides.
Also, thanks @hactar and @deirdresmtoo for the exploration of a more sophisticated automatic naming strategy, but as you correctly identified, that'd be much more complex due to the assumptions about the language and patterns used, and I'd consider that out-of-scope for now.

@czechboy0 Awesome, thanks! Yes, this will make things without operationIDs much useable.
I'd still argue that the resulting API should strive for camel case and not snake case - it is a Swift API guideline after all - it feels really weird to me that the Swift OpenAPI generator would generate API that does not comply to the guidelines: https://www.swift.org/documentation/api-design-guidelines/#conventions . The capitalization would still give away the separation between path components, so I don't see the added benefit of snake case?

But, even if you guys do decide to stick to snake case, this will proposal will be a great improvement!

The capitalization would still give away the separation between path components, so I don't see the added benefit of snake case?

I was thinking that if you have a path like GET /foo/{fooId}/bar, that get_foo_fooId_bar is less ambiguous than getFooFooIdBar, as from the latter, you could assume the path is really GET /fooFoo/idBar, for example. But maybe that's not as important to map back in.
What do you think, @simonjbeaumont? I'm actually fine with either now.

I'd still argue that the resulting API should strive for camel case and not snake case - it is a Swift API guideline after all - it feels really weird to me that the Swift OpenAPI generator would generate API that does not comply to the guidelines

What do you think, @simonjbeaumont? I'm actually fine with either now.

IMO there's an important distinction here that I think has been missed: the goal of avoiding snake case is a good one but it should not be confused with avoiding underscores in all places.
There is no snake case in the proposal—because snake-case and camel-case are about word separation.
The goal is to generate the most idiomatic code we can, within reason, from a generalisable, opinionated strategy. That means we should aim to generate code that is most similar to what would be written by hand, even if that does have underscores.
The clearest example is how to handle the translation of version2.0. For this we have suggested version2_0 as it felt hard to argue that version20 would be acceptable. This is also what I would have written by hand—and, it turns out, it is what we wrote by hand, in the generator when dealing with different version constants for the OpenAPI spec. @hactar I'm curious if you have any different opinion on the underscore here, or alternative spelling you would use in hand-written code?
If we agree that we shouldn't remove the . from version2.0, then we've arrived at a question that needs generalising that has nothing to do with casing: which symbols should we simply remove, and which should we replace, and with what.
If the feedback is that / should be removed, I'm OK with us taking that stance. But IMO it should be on the grounds that we've thought about it distinct from casing, and that we're not striving for a zero underscore policy.

I agree with you that we need to be careful not to mix different aspects of the generator.
In the case of an operation, the generator is taking the http method, a word, and the path components, also usually words - frequently even forming sentences if read together.  For the example of GET /map/styles, this can be read as a sentence:  "get map styles". These words now need to be joined in a way that makes them readable to a swift developer, because '/' and ' ' is not valid within a function name. So some options would be

join them without modification and without a separator, then we get: "GETmapstyles()". Not really good.
normalize case and use "_" for joining: "get_map_styles()". This is snake case.
adjust case and use no separator: "getMapStyles()". This is camel case.

As I see it the goal of the Swift OpenAPI Generator is to take an OpenAPI spec and turn it into an API that feels like a native Swift API. Swift APIs are camel case, so I'd pick the last option here.
Now "version2.0" is a different pair of shoes. I'm assuming you're referring to something like GET /map/styles/version2.0. Here version2.0 is a path component. The . is a separator within the component, not a separate component itself. So yes, here we need to find something to replace the "." with, and that can be a "_" without turning the API itself into snake case. The generated function name would be "getMapStylesVersion2_0()", which is still very readable, and still camel case - even though there is an underscore in it.

Thanks @hactar for continuing to reason this one through with us.

For the example of GET /map/styles, this can be read as a sentence: "get map styles".

If one views the slash separators in a path as equivalent to word separators, then it follows that substituting them with underscores results in snake case. My position was/is that the slashes held more semantic meaning than just word separation, so the use of underscores in their place felt as natural to me as in the version2.0 to version2_0.
However, I think for those that do see them as word separation, the use of underscores is quite an eye sore. So, I'm happy in this case to remove them and treat them like word separators as I think, averaging across the pool of users, this will cause the least surprise.
What's your thinking on this one now @czechboy0?

Yeah, I'm happy to change the proposal to reflect that.

I agree with what @hactar and @simonjbeaumont have said about their slash and underscore comments.
In particular, Si's comment about slashes holding more semantic meaning. An API that has GET /map/styles implies there might be more under map, e.g., GET /map/settings, where the slash is serving a function much like an aisle in a library, grouping related topics.
Where an api that had GET /mapstyles implies that's all there is there.
Path component cleanup via _ seems sensible (e.g., the Version2.0 -> version2_0 example).

I think in the most recent comments, we seem to have landed on just dropping the slashes rather than replacing them with underscores. Is that still okay with you, @deirdresmtoo?

Absolutely, apologies for leaving that unclear.

Ok folks, here's the diff of the latest proposal changes (version 1.2): https://github.com/apple/swift-openapi-generator/pull/683/commits/e1f5e429db5c1061b5e270268966217184b22608

Pushed a revision of the proposal: v1.3: 73fd986
These changes are the result of needing to further clarify a few points that came up during implementation.

@simonjbeaumont Updated the status as implemented in 1.6.0 (the next minor to go out, since the code is now merged).
I'm preparing a PR for the examples/integration test.

But this PR is ready to get reviewed/merged.


[Question] how to setup in confing gas mining fluids?

how to setup in confing  fluid names that can be harvested as Gas. (I know that I must use f.e. minecraft:water but i dont know where) there is no list space like f.e.
S: <
minecraft:water
>

there was a bug with 1.0.0RC2 where there was a name conflict in the config.  Should show up as "harvestableGasses" under "gasmining" in the next update.  Fluids are also not locallized by mod so the correct entry I believe would actually be just
S: <
water

ok thanks :)


Continuous package publishing

Ideally, each Monday, once polkadot-js scoped deps publish a new release we can try to automatically merge the new polkadot-js deps and then do an automated release with changelog generation, new tag, and publish to NPM.

Closing in favor of our current release process.


add Elixir ESpec runner

the alternative test framework, inspired by RSpec - ESpec

Awesome, thank you! I really appreciate the complete PR with tests as well.

@janko-m my pleasure, you have a great ecosystem here(docs/specs/examples), so it was the easy task :)


Omni for Gedit

Add a new theme to the organization
If you have already created a theme, make sure you check the following requirements:

[x] The theme follows the template;
[x] The theme follows the Omni Color Palette;
[x] The branch name is main (we will keep this name pattern from now on);
[x] The theme has correct instructions on how to install it;
[x] The repository name is lowercase and contains just the application name. E.g. visual-studio-code.

Application: Gedit
Application URL: https://wiki.gnome.org/Apps/Gedit
GitHub URL: https://github.com/heyloh/gedit

Hey @heyloh! Thanks for creating another theme; it looks great. 💜
We can include the theme in the organization. 🎉
Since you are a member of the org, you can transfer your repository!
Just make sure to open a PR and include the theme on the main repository 👊🏻
Also, after the transfer, make sure to change all URLs to match the new repository link.

Instructions followed! 🚀

Great job, @heyloh. 💜
Don't forget to share it on social media, forums, and communities!


Returns the correct image creation timestamp on Get volume function

fixes #12

When inspecting a volume the field Mountpoint will be returned only when the volume is already mounted on the host.

e.g
Inspecting a volume mounted on the current host
$ docker inspect volumes/bindman-data
[
    {
        "CreatedAt": "2019-09-03T21:24:42Z",
        "Driver": "cepher:latest",
        "Labels": {
            "com.docker.stack.namespace": "reverse-proxy"
        },
        "Mountpoint": "/mnt/cepher/volumes/bindman-data:rw",
        "Name": "volumes/bindman-data",
        "Options": {
            "size": "5000"
        },
        "Scope": "global"
    }
]

Inspecting a volume mounted in another host
$ docker inspect volumes/consul-data
[
    {
        "CreatedAt": "2019-09-03T21:24:48Z",
        "Driver": "cepher:latest",
        "Labels": null,
        "Mountpoint": "",
        "Name": "volumes/consul-data",
        "Options": null,
        "Scope": "global"
    }
]

@werberson thanks


.NET smoke Test Sample

Performs functionalities with Key Vault, Identity, Event Hubs and Blob Storage Track 2 SDKs.

@JonathanCrd I'd suggest having a look at https://github.com/Azure/azure-sdk-for-net/pull/6678 which is doing something very similar to what you are doing and so the pattern might be interesting here as well.

Is the intent here to have a set of samples or to have a set of tests?

Is the intent here to have a set of samples or to have a set of tests?

The intent is actually to run a set of samples for each of the services in a single application. For now we are just writing samples independently but the goal is to eventually pull in all the samples from the library directory into this single application.

The way it's written right now looks like an attempt to reinvent testing framework.

The way it's written right now looks like an attempt to reinvent testing framework.

I agree and we should definitely avoid duplicating a testing framework. I kind of like what @jsquire did in https://github.com/Azure/azure-sdk-for-net/pull/6678 which is why I pointed to that as an example.

I wonder if we can build on that idea but avoid ISample all together. Like, have every file be a self-contained copy-pastable app with Program.Main but also have a common runner that is able to run multiple samples.

I wonder if we can build on that idea but avoid ISample all together. Like, have every file be a self-contained copy-pastable app with Program.Main but also have a common runner that is able to run multiple samples.

I used an interface just to enforce structure;  in the context of Event Hubs, I wanted to ensure that every sample had a consistent method to execute which accepted a common set of connection parameters (to avoid ambient context and the need to set environment variables; I wanted to enable the F5 experience in Visual Studio.)     I could have made implicit assumptions about the structure to avoid the interface, but preferred to make it explicit in case there were community contributions.
With respect to a generic approach that would span client libraries, I'd expect that to be tough without ending up with the need for ambient environment requirements again.  In my opinion, having an approachable "it just works" experience for being able to launch the debugger is the more desirable side of that trade off.

I agree it is something to build on and I'm fine making them standalone but we still need a way to aggregate them together.

With respect to a generic approach that would span client libraries, I'd expect that to be tough without ending up with the need for ambient environment requirements again. In my opinion, having an approachable "it just works" experience for being able to launch the debugger is the more desirable side of that trade off.

I wonder if we can use System.CommandLine (https://github.com/dotnet/command-line-api) inside sample apps themselves making them explicit and directly callable.


RFC: Adding arbitrary '-dev' bindings

Hi all,
My company is investigating using Cloud Foundry, and as part of the research process has noted that some C bindings are not part of the linuxfs2 image.
I see that a recent request for python-dev was rejected, and I'm wondering whether it's worth requesting the addition of libprotobuf-dev and libxapian-dev or if I should just go down the path of rolling my own?
What are the criteria for inclusion?
Thanks,
-- Rob

Hi,
libpython-dev isn't included because we believe that python applications are all being staged with the python-buildpack, which itself includes this development dependency.
Can you help us understand your use case for libpython-dev?
We're very open to adding dependencies to the rootfs, particularly if we have the runtime library but not the development library (and it's not something that's being vendored in the core buildpacks). What libraries did you have in mind? Any besides libprotobuf-dev and libxapian-dev?

Can you help us understand your use case for libpython-dev?

I don't have one - I misunderstood the reasoning behind excluding it from the build, as per #34.

What libraries did you have in mind? Any besides libprotobuf-dev and libxapian-dev?

I think I also need the protobuf compiler. Let me get you a complete list, now that I know you're open to adding packages to the base image.
Thanks!

It's worth noting that while we're open to it in theory, it's a very narrow and stingy gate.
Anything added to the rootfs affects every single app. Because of the wide impact this tends to be a made as a product decision.

@qnm any update on the complete list of libraries you need?

@qnm any update on the complete list of libraries you need?

@sesmith177 Thanks for getting in touch Sam. At this stage it's unlikely that we'll be looking further into Cloud Foundry, but I will re-open the ticket if and when I need those extra packages! Thanks.


When using discovery url and a self signed certificate for the provider a connection cannot be established

Hi!
I've ran into a scenario where a keycloak instance is running behind a self signed ssl certificate. I am unable to change that fact as it's company policy. They're doing custom CA stuff, blah blah.
So right now I am looking for a way to either configure the reqwest::Client inside the pub async fn discover_jwks(issuer: &str) -> Result<String, InitError> function or pass my own client.
I'd prefer passing one, as I am already creating one for use in other parts of my program.
What do you think?
I'm also more than down to create a pull request to help with this :)

closing this, #42 merged.


add modals for notifications, setting and user profile in navbar component

made notification modal

user profile modal

i don't know what to make in settings modal

i don't know what to make in settings modal

Let's make a different lage for settings where we can add dark mode/light mode, maybe some terms & conditions, volumes, about, version, logout, etc stuffs what do u say?

yeah we can do that because there's not much left to place there


[$250] Reports w/ 404 are stuck in LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.8-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721060374459769
Action Performed:

[Alice] Add someone to a room
[Bob] (the room should show up in their LHN)
[Alice] Remove Bob from the room
[Bob] Click on the room

Expected Result:
You should see a Hmmm it's not here (404 error), then when you navigate away the report should disappear from the LHN.
Actual Result:
You see a Hmmm it's not here, but the report is stuck in your LHN with a red dot (RBR indicator), and can't be cleared.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/5ffa4369-4240-4b89-bbb9-57e87bac6afe

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016fe03af3d662fd8f
Upwork Job ID:<PHONE_NUMBER>014111029
Last Price Increase: 2024-09-18

Issue OwnerCurrent Issue Owner: @ikevin127

Working on this now, sorry for the delay.

What timing, I have a chat that follows this pattern in my LHN right now that showed up this morning 😂. There's no way to dismiss it and it's stuck with a RBR in my LHN all day so far.

Mac/Chrome

Here's the Onyx Data for that chat:
{
    "chatType": "",
    "currency": "USD",
    "description": "",
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "isCancelledIOU": false,
    "isOwnPolicyExpenseChat": false,
    "isPinned": false,
    "isWaitingOnBankAccount": false,
    "lastActionType": "CREATED",
    "lastActorAccountID": 17680685,
    "lastMessageHtml": "hi",
    "lastMessageText": "hi",
    "lastReadSequenceNumber": 0,
    "lastVisibleActionCreated": "2024-06-26 08:59:07.758",
    "lastVisibleActionLastModified": "2024-06-26 08:56:07.301",
    "managerID": 0,
    "nonReimbursableTotal": 0,
    "notificationPreference": "always",
    "oldPolicyName": "",
    "ownerAccountID": 0,
    "participants": {
        "2644835": {
            "hidden": false
        },
        "17680685": {
            "hidden": false
        }
    },
    "permissions": [
        "read",
        "write"
    ],
    "policyID": "_FAKE_",
    "reportID": "3860266512989981",
    "reportName": "Chat Report",
    "stateNum": 0,
    "statusNum": 0,
    "total": 0,
    "type": "chat",
    "unheldTotal": 0,
    "welcomeMessage": "",
    "writeCapability": "all",
    "isEdited": false,
    "errorFields": {
        "notFound": {
            "1720457339876689": "Report not found",
            "1720478844867650": "Report not found",
            "1721845816001669": "Report not found",
            "1721845828999863": "Report not found",
            "1721845837355611": "Report not found",
            "1721846910100562": "Report not found"
        }
    },
    "lastReadTime": "2024-07-08 22:47:30.782"
}

Proposal
Please re-state the problem that we are trying to solve in this issue.
You see a Hmmm it's not here, but the report is stuck in your LHN with a red dot (RBR indicator), and can't be cleared.
What is the root cause of that problem?
After the user is removed from the room, the report data is still present in Onyx and it has a not found error when the removed user clicks on the room again.
That makes hasErrorsOtherThanFailedReceipt is true
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/SidebarUtils.ts#L123-L127
And then here we always put this report in LHN if hasErrorsOtherThanFailedReceipt is true
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/SidebarUtils.ts#L130-L136
So this report is always displayed in LHN
What changes do you think we should make in order to solve the problem?
We should check if the report has not found an error we will not push this report here.
if (hasErrorsOtherThanFailedReceipt && !report?.errorFields?.notFound) {

https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/SidebarUtils.ts#L130-L136
Then when we go to shouldReportBeInOptionList check, it already has the check to return false if the report is not found
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/ReportUtils.ts#L5531-L5533
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/ReportUtils.ts#L5373-L5375
What alternative solutions did you explore? (Optional)

@strepanier03 @nkdengineer I cannot reproduce the issue, I followed the steps and the result on my side is:

as soon as the invited user [Bob] is removed from the room, the LHN report goes away and if the report is opened while the removal happens -> it also goes away and [Bob] is redirected to last report (e.g. Concierge).

Note: The room was freshly created when I attempted reproducing.
Here's a video of how it looks on my side:

Web: Chrome / Safari
https://github.com/user-attachments/assets/bd25d9e8-41ac-4894-8f1c-5925056fb828

To me ^ this looks like the correct and expected behaviour, meaning: silently being removed, without any Not found page being shown or RBR errors.

If anyone has clear / more detailed steps as to how this can be consistently reproduced, please let me know so we can move forward with a fix.
Otherwise, I'd add the Needs Reproduction label and have a few other prople try reproducing this and if no dice then close as non-reproducible (probably BE pusher event related [not removing the data correctly from {Bob}]).
cc @roryabraham (since you reported this)

@strepanier03 are you still able to reproduce this?

I can't reproduce it now. Yesterday, when the user was removed, the user didn't receive any pusher data so we can reproduce this bug. But now, the pusher data clears the report data and then this issue cannot be reproduced.

Needs Reproduction

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.

Issue not reproducible during KI retests. (First week)

Looks like issue is not reproducible anymore (reference).

Issue not reproducible during KI retests. (Second week)

Looks like issue is not reproducible anymore (reference, 2nd week test reference).

Looks like issue is not reproducible anymore (reference, 2nd week test reference).
@zanyrenney Maybe we can close this, wdyt ?

Looks like issue is not reproducible anymore (reference, 2nd week test reference).
@strepanier03 Maybe we can close this, wdyt ?


Remove some leftovers

Looks like there were some leftovers. This removes them.

@bartlomiejzuber thank you!


Added writeup for cps remastered from amateursctf

did I test build the jekyll?
no I did not

I rate this a solid 5/7


Custom Jingle from URL Does Not Function Correctly

I copy/pasted this url into the "Custom path" field of the plugin settings:
https://www.myinstants.com/media/sounds/gta-san-andreas-mission-complete-sound-hq_4ZVTov6.mp3
And my "Custom Jingle" option is checked. However, when I complete a slayer task I do not hear the jingle.
Downloading the same jingle and then typing the file path into "Custom path" works fine, though.

Working properly in newest version


Build error: cc1: warning: unrecognized command line option '-Wno-absolute-value'

Expected behaviour
Expecting to build a binary package on an Orange Pi 3 running Armbian:
python setup.py bdist_wheel
Actual behaviour
CMake Error at /usr/share/cmake-3.10/Modules/FindQt4.cmake:1320 (message):
  Found unsuitable Qt version "" from NOTFOUND, this code requires Qt 4.x
Call Stack (most recent call first):
  cmake/OpenCVFindLibsGUI.cmake:30 (find_package)
  CMakeLists.txt:669 (include)

-- Configuring incomplete, errors occurred!
See also "/home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeOutput.log".
See also "/home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeError.log".
Traceback (most recent call last):
  File "/home/weiwang/env/lib/python3.6/site-packages/skbuild/setuptools_wrap.py", line 574, in setup
    languages=cmake_languages
  File "/home/weiwang/env/lib/python3.6/site-packages/skbuild/cmaker.py", line 232, in configure
    os.path.abspath(CMAKE_BUILD_DIR())))

An error occurred while configuring with CMake.
  Command:
    "cmake" "/home/weiwang/ai/opencv-python/opencv" "-G" "Unix Makefiles" "-DCMAKE_INSTALL_PREFIX:PATH=/home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-install" "-DPYTHON_EXECUTABLE:FILEPATH=/home/weiwang/env/bin/python" "-DPYTHON_VERSION_STRING:STRING=3.6.8" "-DPYTHON_INCLUDE_DIR:PATH=/usr/include/python3.6m" "-DPYTHON_LIBRARY:FILEPATH=/usr/lib/aarch64-linux-gnu/libpython3.6m.so" "-DSKBUILD:BOOL=TRUE" "-DCMAKE_MODULE_PATH:PATH=/home/weiwang/env/lib/python3.6/site-packages/skbuild/resources/cmake" "-DPYTHON3_EXECUTABLE=/home/weiwang/env/bin/python" "-DBUILD_opencv_python3=ON" "-DOPENCV_SKIP_PYTHON_LOADER=ON" "-DOPENCV_PYTHON3_INSTALL_PATH=python" "-DINSTALL_CREATE_DISTRIB=ON" "-DBUILD_opencv_apps=OFF" "-DBUILD_SHARED_LIBS=OFF" "-DBUILD_TESTS=OFF" "-DBUILD_PERF_TESTS=OFF" "-DBUILD_DOCS=OFF" "-DWITH_QT=4" "-DWITH_V4L=ON" "-DENABLE_PRECOMPILED_HEADERS=OFF" "-DWITH_IPP=OFF" "-DCMAKE_BUILD_TYPE:STRING=Release"
  Source directory:
    /home/weiwang/ai/opencv-python/opencv
  Working directory:
    /home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build
Please see CMake's output for more information.

Found in /home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeError.log:
===== BUILD LOG =====
Change Dir: /home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeTmp

Run Build Command:"/usr/bin/make" "cmTC_d561a/fast"
/usr/bin/make -f CMakeFiles/cmTC_d561a.dir/build.make CMakeFiles/cmTC_d561a.dir/build
make[1]: Entering directory '/home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_d561a.dir/src.c.o
/usr/bin/cc   -fsigned-char -W -Wall -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Wstrict-prototypes -Wundef -Winit-self -Wpointer-arith -Wuninitialized -Winit-self -Wno-comment -Wimplicit-fallthrough=3 -Wno-strict-overflow -fdiagnostics-show-option -pthread -fomit-frame-pointer -ffunction-sections -fdata-sections    -fvisibility=hidden -Wno-implicit-function-declaration -Wno-uninitialized -Wno-missing-prototypes -Wno-unused-but-set-parameter -Wno-missing-declarations -Wno-unused -Wno-shadow -Wno-sign-compare -Wno-strict-overflow -Wno-pointer-compare  -O3 -DNDEBUG -fPIE   -Wno-absolute-value -o CMakeFiles/cmTC_d561a.dir/src.c.o   -c /home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeTmp/src.c
/home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeTmp/src.c:1:0: warning: ignoring #pragma   [-Wunknown-pragmas]
 #pragma

cc1: warning: unrecognized command line option '-Wno-absolute-value'
Linking C executable cmTC_d561a
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_d561a.dir/link.txt --verbose=1
/usr/bin/cc    -fsigned-char -W -Wall -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point -Wformat -Werror=format-security -Wstrict-prototypes -Wundef -Winit-self -Wpointer-arith -Wuninitialized -Winit-self -Wno-comment -Wimplicit-fallthrough=3 -Wno-strict-overflow -fdiagnostics-show-option -pthread -fomit-frame-pointer -ffunction-sections -fda
ta-sections    -fvisibility=hidden -Wno-implicit-function-declaration -Wno-uninitialized -Wno-missing-prototypes -Wno-unused-but-set-parameter -Wno-missing-declarations -Wno-unused -Wno-shadow -Wno-sign-compare -Wno-strict-overflow -Wno-pointer-compare  -O3 -DNDEBUG    -Wl,--gc-sections  CMakeFiles/cmTC_d561a.dir/src.c.o  -o cmTC_d561a
make[1]: Leaving directory '/home/weiwang/ai/opencv-python/_skbuild/linux-aarch64-3.6/cmake-build/CMakeFiles/CMakeTmp'

===== END =====

Steps to reproduce

example code: git clone git@github.com:skvark/opencv-python.git
operating system: Armbian Ubuntu 18.04.3 LTS
architecture (e.g. x86): aarch64
opencv-python version: git clone git@github.com:skvark/opencv-python.git

This is the actual issue:
CMake Error at /usr/share/cmake-3.10/Modules/FindQt4.cmake:1320 (message):
  Found unsuitable Qt version "" from NOTFOUND, this code requires Qt 4.x
Call Stack (most recent call first):
  cmake/OpenCVFindLibsGUI.cmake:30 (find_package)
  CMakeLists.txt:669 (include)

To turn Qt4 off, use:
export CMAKE_ARGS="-DWITH_QT=OFF"
python setup.py bdist_wheel

Yes, the build generates single statically linked binary which ends on Linux with .so.
That python3-opencv: /usr/lib/python3/dist-packages/cv2.cpython-36m-aarch64-linux-gnu.so is the OpenCV version which you have installed via your system package manager (apt-get or similar). That's completely different binary. The binaries created with the toolchain in this repository end up in cv2 subfolder under dist-packages after you install the generated wheel file.


5-10-5 related Issue (?) in the Stars Without Number Game System

Hello,
I was testing out homebrew for the Stars Without Number revised edition game system when I realized that, through the use of Elevation Ruler, Space Combat could potentially be three-dimensional. However, when I updated Elevation Ruler from a previous version to 0.8.12 (I believe 0.8.7) to play-test this theory, this started happening:

I tried playing around with active modules to see if it was a mod conflict, but disabling Elevation Ruler fixed the problem:

The same happened on a Odd and Even hex map, with different tokens. After some research, this may be Elevator ruler confusing the system's 5 - 10 - 5 ruleset with a 5 -10 - 10 ruleset (which has been reported in the past). Interesting note: Elevation ruler was not having this problem in the same game system before I updated the module.
Is there anything that can be done about this, or is it better to wait for FoundryV12's grid updates?
Thanks,
Hermit

Is this still an issue in v12 now?

Unfortunately, the Stars Without Number system has not been updated to be compatible with V11 as of the time of this comment. Considering closing the topic and re-opening it if the update comes out and it isn't fixed yet


Create a logo/icon

This is very unimportant, but it will be a good choice for the sake of polish.

We could potentially enlist the help of Linh for the SVG creation process, if we want to try that.

This was closed with commit e52ae86719d16907d9f7f262832a901044d701ac


Add server support for PKINIT

Is your feature request related to a problem? Please describe.
This is a tracker for the server side of PKINIT #95.
Describe the solution you'd like
Implement PublicKeyPreAuthenticationHandler : KdcPreAuthenticationHandlerBase that queries IRealmService for the KDC signing key. Extract the SignedCms signing certificate from the request and validate it is acceptable for the requested user. Expose a delegate or method overload that lets implementers specify their own validation logic.

Closed by https://github.com/SteveSyfuhs/Kerberos.NET/pull/117


[New Cop] Style/PreferInterpolation

I'd like to request a new cop, similar to eslint's prefer-template rule. It would check for places where string interpolation could be used in place of concatenation.
Here's the "bad/good" example:
# bad
a = "abc"
b = a + "def"

# good
a = "abc"
b = "#{a} def"

This sounds like a good idea to me. For the most part, I think this would involve checking both sides of a call to +. If one of them is a string and the other is a variable, interpolation can be used. Can anyone think of any potential edge cases that could cause issues?

@rrosenblum the left hand side matters the most. In JS a + "b" will always result in string due to fancy type conversions.
Here's the real world example on why the things are not so bright in Ruby. Consider Pathname#+:
home = Pathname.new('/Users/jane')
home + 'Documents' # => #<Pathname:/Users/jane/Documents>
"#{home}Documents" # => "/Users/janeDocuments"

That being said, the left hand side must be a string.

@akhramov thanks for the example with Pathname. That should help prevent several issues after this is implemented.

That being said, the left hand side must be a string.

That should make this easier to implement.

Hmm, it's shame it can't be checked on both sides, but that is a valid point, @akhramov

I thought of a few more things that we will need to account for. We will want to make sure that the correction does not exceed the configured line length. This should only be an issue when the offense spans more than one line to begin with. We will also need to make sure that we don't change the meaning of the string '\t' vs "\t". Some of these checks have already been implemented in other cops.

Any news on this matter? This rule is included in the styleguide but not cop about it.

There hasn't been much activity on this ticket and our Core Team is spread too thin on so many tasks, so I'll just close it for the sake of having a cleaner lists of tasks to focus on. We'd gladly review a PR, but it's unlikely that'd we're going to tackle this ourselves in the foreseeable future.


permanent redirect when running createKeyData

Describe the bug
When I run createKeyData() with the following parameters:

create key data
input:  "be_alientaxa_info.csv"
output: "keys.csv"
createKeyData(dataDir = processingFilePath, bucket = bucket)

I get the following error (part of):
List of 6
 $ Code     : chr "PermanentRedirect"
 $ Message  : chr "The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future "| __truncated__

To Reproduce
Steps to reproduce the behavior:

Go to 'inbo/aspbo/src/upload_processing_to_uat.R
Run 'L13 - L23'
Scroll down to 'L52' & run
See error

Expected behavior
be_alientaxa_info.csv is processed as it should & no permanent direct error.
Additional context
Issue also occurs with:

createTabularData(dataDir = processingFilePath, type = "occurrence", bucket = bucket)
all the tests

probably fixed by adding the region parameter to save/load functions from the aws.S3 package (see https://github.com/inbo/alien-species-portal/pull/64/commits/13a6778484788f129dd5c525daf21ed16b0e3cba)

I think s3write_using() needs the region parameter as well in:
https://github.com/inbo/alien-species-portal/blob/ed5379bf4f5b9b8da1ddf01da742245aba7f5cfc/alienSpecies/R/data_create.R#L136-L138

ps I'm using v0.0.5


Remove remnants of Tracing Strategy

Description:
Noticed a couple places referencing tracing strategy - removed them.

:shipit:
I believe that the types file is still called tracingStrategy maybe we can add it to this one or a new PR , your call

@aledustet I was thinking this too - I will take care of it in this PR.


[spi_device] Block the passthrough with BUSY status

This commit addresses the issue #10785.
The BUSY @ SYS_CLK is set when SPI_DEVICE receives commands that satisfy:

busy field in the CMD_INFO of the opcode is set
CSb is de-asserted (SPI transaction completion)

When BUSY is set, SW may process the received command (assuming upload
field is set). After the command is processed by SW, SW may clear the
BUSY @SYS_CLK, which then will be propagated into SPI CLK (SCK) domain
at the next SPI transaction.
This commit is to turn off the passthrough interface if BUSY is set. So,
that the SW does not have to manually turn off the passthrough.
Keep in mind that this change cannot fully cover the corner cases:

CSb is about to asserted (Beginning of the SPI transaction) at the
same time BUSY is cleared by SW.

It is due to the CDC path of CSb to be used in SYS_CLK domain. It needs
to pass through 2FF synchronizer to be used in SYS_CLK safely. The delay
is 2 SYS_CLK. If BUSY falls in that window, the BUSY clearing may
unblock passthrough while SPI is active. The behavior of the IP is
undetermined.

this looks okay to me given all the discussion that was had, and the understanding that we will follow up with a different PR to address the corner cases pointed out.
I think the general consensus now is to move towards using CSb as a clock signal to drive the eventual passthrough enable indication?
@a-will @eunchan does that sound right to you guys?

Thanks for the review Tim. I will update the following PR accordingly.


Prepend table name to enum types

Previously, generating on a db with multiple tables with the same enum name produced conflicting types.
I've tested the changes on a decently complex DB.
Also, I've changed the enum constant values to start at zero so the models' zero values can be worked with properly.
Fixes #57

I can't accept this PR in this form for a couple reasons:

#ae62fde and #45db5a4 are not related to each other (see below), and should not be in the same commit
#ae62fde would be acceptable, if it was wrapped in a --mysql-* option to enable this behavior. Without wrapping this as a cli option, it would break the way existing xo generated code works, which isn't acceptable. The reason for this is that in PostgreSQL, enums are an actual, separate database type, and their names/values are shared across tables.
#45db5a4 is not acceptable at all, and I don't think I would accept it even if it was wrapped with an option. Some of this is getting down into the nitty/gritty of schema design (of which there are a thousand different, valid viewpoints, none of which I am interested in arguing here). In PostgreSQL, enums start their numbering at 0, and I am not aware of any way to change this. I am assuming this is being submitted due to using xo with MySQL, and needing to mimic the behavior of other code. The problem is that the enum should have been declared with a '0' value then if you wanted significant ordering / values to actually start at 1. I would thus suggest the problem exists with your schema design (ie, the enum should have a 0th value)

Also, in aggregate, I would suggest possibly that if you need to reuse enum names between tables in MySQL, that you rename them accordingly, and prefix them with the table. This results in better modeling within Go, as the types are indeed different types.

Thanks.

Please note that I'm definitely willing to accept the #ae62fde if it's changed up a bit -- for #45db5a4 I would need some kind of argument as to why it should be added, and it would definitely need a cli option.


File uploader

I would like to add file uploader extension please assign this to me under gssoc

Already exists closing this #1404


[Server] Extensions: API Support for proxying feedback/help requests

Will you add an API in meshery server that proxies this support request to remote provider and then the provider (in the backend) handles this?
Originally posted by @MUzairS15 in https://github.com/meshery/meshery/pull/11004#discussion_r1609860661

@MUzairS15 is this need not covered by a wildcard after /api/provider/extension/?

@leecalcote We are covered here, we already have a proxy handler.

Thank you, sir. For my own reference, is this covered under a wildcard or is this explicitly defined?


Preference injection?

This was an idea I had, but not really sure it's significant enough to warrant its own project and wanted to see if you'd be open to a pull request for it. It's not strictly view injection (preferences are mutants), but I feel like it could fall under the sort of swiss army knife of utilities that Butterknife offers.
Often times when dealing with shared preferences, I end up with a case like this.
public class MyPreferenceFragment extends PreferenceFragment {

    CheckboxPreference someCheckbox;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        someCheckbox = (CheckboxPreference) findPreference("key_some_checkbox");
        someCheckbox.setOnPreferenceChangeListener(new OnPreferenceChangeListener {
            @Override
            public boolean onPreferenceChange(Preference preference, Object newValue) {
                // Do something
                // Return something
            }
        }
    }

}

It would be very nice to do something like this instead:
public class MyPreferenceFragment extends PreferenceFragment {

    @InjectPreference("key_some_checkbox")
    CheckboxPreference someCheckbox;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
    }

    @OnPreferenceChange("key_some_checkbox")
    boolean checkboxChanged(Preference preference, Object newValue) {
        // Do something
        // Return something
    }

}

There's also OnPreferenceClickListener, binding multiple keys to a listener, and easy casting of the newValue's type as other pros. It's admittedly a niche use-case, but I think it would be a useful tool.

This is the same as #209.

Actually yours is more logical, but I don't want duplicate issues and they'll be linked anyway.

Ah oops! I'll chime in on that thread with my examples


Create a custom cloudwatch metric for subscription failures and bot failures

Add to CDK as well

Fixed in https://github.com/medplum/medplum/pull/3727


Simple TorchScript test fails

This test will run exactly 4 iterations and then print an error:
def test_really_simple():
    n_atoms=10
    zs = torch.tensor([1, 6, 7, 8, 9], dtype=torch.long)
    z = zs[torch.randint(0, len(zs), (n_atoms,))]
    pos = torch.randn(len(z), 3)
    batch = torch.zeros(len(z), dtype=torch.long)
    batch[len(batch) // 2 :] = 1
    args = {"model": "tensornet",
            "embedding_dimension": 128,
            "num_layers": 2,
            "num_rbf": 32,
            "rbf_type": "expnorm",
            "trainable_rbf": False,
            "activation": "silu",
            "cutoff_lower": 0.0,
            "cutoff_upper": 5.0,
            "max_z": 100,
            "max_num_neighbors": 128,
            "equivariance_invariance_group": "O(3)",
            "prior_model": None,
            "atom_filter": -1,
            "derivative": True,
            "output_model": "Scalar",
            "reduce_op": "sum",
            "precision": 32 }
    model = create_model(args).to(device="cuda")
    z = z.to("cuda")
    pos = pos.to("cuda").requires_grad_(True)
    batch = batch.to("cuda")
    model = torch.jit.script(model).to(device="cuda")
    for i in range(0, 10):
        print("Running iteration {}".format(i))
        y, neg_dy = model(z, pos, batch)

The error:
self = RecursiveScriptModule(
  original_name=TorchMD_Net
  (representation_model): RecursiveScriptModule(
    original_name=...      (1): RecursiveScriptModule(original_name=SiLU)
      (2): RecursiveScriptModule(original_name=Linear)
    )
  )
)
args = (tensor([7, 6, 7, 7, 8, 7, 8, 7, 8, 8], device='cuda:0'), tensor([[-0.6791,  0.2550, -0.8304],
        [-0.4754,  0.60...107, -1.6600,  0.7560]], device='cuda:0', requires_grad=True), tensor([0, 0, 0, 0, 0, 1, 1, 1, 1, 1], device='cuda:0')), kwargs = {}, forward_call = <torch.ScriptMethod object at 0x7f9d363cd4e0>

    def _call_impl(self, *args, **kwargs):
        forward_call = (self._slow_forward if torch._C._get_tracing_state() else self.forward)
        # If we don't have any hooks, we want to skip the rest of the logic in
        # this function, and just call forward.
        if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
                or _global_backward_pre_hooks or _global_backward_hooks
                or _global_forward_hooks or _global_forward_pre_hooks):
>           return forward_call(*args, **kwargs)
E           RuntimeError: The following operation failed in the TorchScript interpreter.
E           Traceback of TorchScript (most recent call last):
E             File "/shared/raul/torchmd-net/torchmdnet/models/model.py", line 292, in forward
E                       print("Shape of pos")
E                       print(pos.shape)
E                       dy = grad(
E                            ~~~~ <--- HERE
E                           [y],
E                           [pos],
E           RuntimeError: The following operation failed in the TorchScript interpreter.
E           Traceback of TorchScript (most recent call last):
E           RuntimeError: The following operation failed in the TorchScript interpreter.
E           Traceback of TorchScript (most recent call last):
E           RuntimeError: The size of tensor a (128) must match the size of tensor b (3) at non-singleton dimension 3

../../mambaforge/envs/openmmtorch-test/lib/python3.10/site-packages/torch/nn/modules/module.py:1501: RuntimeError

If one does not jit.script the model then no error is produced.
The number of atoms does not seem to affect this and I only see it with tensornet.
Tried to use the old Distance module to check for problems related to C++ extensions, but the error is the same.
Even for something like 10 atoms, each iteration takes increasingly more time, in the order of 5 seconds.
128 is the embedding dimension, changing it to 32 does indeed change the error to 32.

Saving and loading the model each iteration solves the issue, and it is in fact faster than not doing it:
    for i in range(0, 10):
        print("Running iteration {}".format(i))
        import io
        buffer = io.BytesIO()
        torch.jit.save(model, buffer)
        buffer.seek(0)
        model = torch.jit.load(buffer).to(device="cuda")
        y, neg_dy = model(z, pos, batch)

This is the offending line. Making tensor_m = tensor or using 0 layers makes the problem go away.
https://github.com/torchmd/torchmd-net/blob/fd8395463370c6b0510d4fe24b25d937382247a1/torchmdnet/models/tensornet.py#L331
Replacing it by this does NOT solve the issue:
tensor_m = torch.zeros_like(tensor).scatter_add(0, (edge_index[0])[:,None, None, None].expand_as(msg), msg)

But my suspicion is scatter_add is the same thing being used by scatter anyway...

5 is a magic number we have encountered before when dealing with CUDA torch models. See for instance https://github.com/openmm/openmm-torch/pull/122
I just made the connection with this issue now while reading about torch.jit fusion operation mechanism with NVFuser:
https://github.com/pytorch/pytorch/blob/main/torch/csrc/jit/codegen/cuda/README.md#general-ideas-of-debug-no-fusion
What I believe is going on here is that there is some kind of collision between jit.script, the nvfuser backend and autograd.

This issue goes away with pytorch>2.0.0, so I am going to assume it is a bug there. Will leave this open until there is a conda-forge package for pytorch 2.1.


Option for/Intrinsic disablement of male performer auto-tagging

Male performers currently affect the presence of tags like "tattoo", "piercings", and "tattoos.and.piercings". They also affect the presence of tags relating to nationality (e.g. "american", "australian", etc).
I recall seeing some efforts in the code to discount male performers from certain tags when I read the PR adding this functionality, so I'm not sure if this is an oversight/bug or not. I'm not even sure that this needs to be an option/setting (i.e. males should just always be discounted from tagging, or if they're tagged then they should use the male tag variants). Emp either doesn't care about male performers when it comes to tags, or in the cases that they do, they use separate tags with 'male' in them—it's almost universally true that any genderless tag implies female on Emp.
E.g. "tattoo" is the popular tag, but it's pretty much only applied to the female talent, there's a separate tag "tattooed.male" for males. It's worth noting that "tattooed.female" also exists but only has like 7% of the popularity of the "tattoo" tag—this is often the case with the more specific "female" gendered tags, this specificity is just not as widely used because the genderless tags are assumed female.
I'd need to test more widely to see what other tags are inherited from the male performers—these might be the only ones, or there might be others that have been missed.

Makes sense to me. This is a pretty easy change because all of these performer tags are handled by one single method in the taghandler class, and simply nesting the relevant tags under something like if performer["gender"] == "FEMALE:" should achieve what you're describing.


change: deprecated samuel/go-zookeeper to github.com/go-zookeeper.

The repo "github.com/samuel/go-zookeeper" is archived. Thats why I changed it to "github.com/go-zookeeper". I also add missing go.mod files.
make test show me that everything is fine. I also rebuild mesos-dns against these changes and it's working quite well. :smiley:
Regards,
Andreas

I found a problem. So I remove these PR to investigate what's wrong.


NATIVE-451: Make german the default language

Could not reproduce the issue, for me it's falling back to german, yes.

Oke should be oke then. Lets see if we encounter this again.


Please use fonts (like fontawesome fonts) instead of images

Hi I wanted to suggest that you use fonts instead of images to improve http request performance
I suggest Fontawesome fonts or you can combine the images into a single sprite or svg file

Hi! I wanted use fontawesome but,
I did not use it because I wanted to maintain a pure JavaScript-based identity.
I will use single sprite or svg file after modularization.
What do you think?

SVG is a great option, so it scales proportionately

Hi ~
merged svg files and applied them as web fonts.
now suneditor do not download many files : )
v1.10.3