Automatically create metric directory if metric directory is not created yet

Is your feature request related to a problem? Please describe.
The current metric system requires users to create the metrics directory before starting the Alluxio cluster, otherwise, it will keep poping warning message as follows:
2021-01-05 13:43:03,305 WARN  CsvReporter - Error writing to Cluster.BytesReadRemoteThroughput
java.io.IOException: No such file or directory
	at java.io.UnixFileSystem.createFileExclusively(Native Method)
	at java.io.File.createNewFile(File.java:1012)
	at com.codahale.metrics.CsvReporter.report(CsvReporter.java:319)
	at com.codahale.metrics.CsvReporter.reportGauge(CsvReporter.java:312)
	at com.codahale.metrics.CsvReporter.report(CsvReporter.java:228)
	at com.codahale.metrics.ScheduledReporter.report(ScheduledReporter.java:253)
	at com.codahale.metrics.ScheduledReporter.lambda$start$0(ScheduledReporter.java:182)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Describe the solution you'd like
Auto-create metrics directory if it's possible.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Urgency
Explain why the feature is important
Additional context
Add any other context or screenshots about the feature request here.

@JySongWithZhangCe  can you take a look at this issue?

@JySongWithZhangCe  can you take a look at this issue?

@JySongWithZhangCe can you take a look at this issue?

Sure

@JySongWithZhangCe can you take a look at this issue?

Sure


Added BlobIdTransformer and test

Codecov Report

Merging #980 into master will increase coverage by 0.1%.
The diff coverage is 93.44%.

@@             Coverage Diff             @@
##             master     #980     +/-   ##
===========================================
+ Coverage     67.77%   67.87%   +0.1%
- Complexity     4520     4532     +12
===========================================
  Files           371      372      +1
  Lines         29178    29239     +61
  Branches       3696     3701      +5
===========================================
+ Hits          19775    19847     +72
+ Misses         8375     8361     -14
- Partials       1028     1031      +3

Impacted Files
Coverage Δ
Complexity Δ

...java/com.github.ambry/store/BlobIdTransformer.java
93.44% <93.44%> (ø)
8 <8> (?)

.../main/java/com.github.ambry.router/EncryptJob.java
92.1% <0%> (-5.27%)
4% <0%> (-1%)

...src/main/java/com.github.ambry.commons/BlobId.java
84.02% <0%> (-0.52%)
53% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
90.01% <0%> (-0.2%)
82% <0%> (ø)

.../main/java/com.github.ambry.store/HardDeleter.java
81.61% <0%> (ø)
41% <0%> (ø)
:arrow_down:

.../main/java/com.github.ambry.router/PutManager.java
87.82% <0%> (+0.64%)
26% <0%> (ø)
:arrow_down:

.../main/java/com.github.ambry/store/MessageInfo.java
85.71% <0%> (+1.42%)
19% <0%> (+1%)
:arrow_up:

...in/java/com.github.ambry.store/BlobStoreStats.java
70.88% <0%> (+1.9%)
82% <0%> (+2%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a25ce7...1164606. Read the comment docs.


Official Discord Support Server

A centralised Discord server for official support would be nice so it's easier to find help.

Hey, there is already a server in the README.md. https://discord.gg/m3tNPpwmRg


[cli/serve command] connectionParams sent from the client isn't used when dealing with websockets

Hello everyone!
Describe the bug

When dealing with subscriptions, we need a way to send some authentication token to the remote GraphQL API.
Using graphql-ws, the recommended way is to put the token within the connectionParams option when building the client :
const wsClient = createWSClient({
    async connectionParams() {
      const token = await getAccessTokenSilently();

      // this is an arbitrary payload of type Record<string, unknown>
      return {
        headers: {
          Authorization: `Bearer ${token}`,
        },
      };
    },
    url: env.VITE_HASURA_SUBSCRIPTION_URL,
  });

The issue is that graphql-mesh default server implementation isn't using this connectionParams : https://github.com/Urigo/graphql-mesh/blob/1c2667489108783a140efbec2d1bbbb2c75d4b91/packages/cli/src/commands/serve/serve.ts#L108-L123
The connectionParams is present in every callbacks, under ctx.connectionParams.
After a chat with @enisdenjo (the author of graphql-ws), one solution could be to augment the request headers when building the context :
context: async (ctx) => {
                const { contextBuilder } = await mesh$;
                const extraHeaders = Object.fromEntries(Object.entries(ctx.connectionParams.headers ?? {}).map(([key, value]) => [key.toLowerCase(), value]));
                ctx.extra.request.headers = { ...ctx.extra.request.headers, ...extraHeaders };
                return contextBuilder(ctx.extra.request);
            },

Either by convention we spread only the connectionParams.headers key so it reduces the chances of side-effects, or we could also spread the whole connectionParams as extra headers.
Another solution would be to allow the user of graphql-mesh to provide their own context callback so it's less rigid and the end user can chose how to map connectionParams to the contextBuilder.
I'm not sure about how it's implemented, but when I used Hasura directly with subscriptions-transport-ws (so no graphql-mesh in between), this is what I had to do :
const subscriptionClient = new SubscriptionClient(
    env.VITE_HASURA_SUBSCRIPTION_URL,
    {
      async connectionParams() {
        const token = await getAccessTokenSilently();

        return {
          headers: {
            Authorization: `Bearer ${token}`,
          },
        };
      },
      reconnect: true,
    }
  );

For reference : https://hasura.io/docs/latest/graphql/core/databases/postgres/subscriptions/index.html#communication-protocol
I guess Hasura is looking into connectionParams.headers to add headers to the request in its implementation of the protocol server-side.
To Reproduce
Steps to reproduce the behavior:

Expected behavior

Environment:

OS:
@graphql-mesh/...:
NodeJS:

Additional context

@jgoux We were able to use mesh as a proxy for ws service protocol translation, here is our setup:

We do not use the mesh cli to start the mesh (we leverage nestjs graphql and use executable schema coming from mesh as a base)
When initializing the nestjs graphql module we pass in the executable schema from mesh. You can generate that by using findAndParseConfig and getMesh.import { findAndParseConfig } from '@graphql-mesh/config';
import { getMesh } from '@graphql-mesh/runtime';

import { getMeshDirectory } from './utils';

export async function getResolvedMesh() {
  const meshConfig = await findAndParseConfig({
    dir: getMeshDirectory(),
  });

  return await getMesh(meshConfig);
}

export const mesh = getResolvedMesh();

So far the general setup, the key step to get ws-graphql  support working is adding a ws server manually:// create and use the websocket server
const wsServer = new ws.Server({
  server: server,
  path: '/graphql',
});

wsServer.on('connection', () => {
  console.log('connected');
});

wsServer.on('close', () => {
  console.log('closed');
});

useServer(
  {
    schema: () => mesh.then(({ schema }) => schema),
    onConnect: async (ctx) => {
      const authenticated = await authenticateBearerToken(
        ctx.connectionParams?.authorization as string
      );

      if (!authenticated) {
        return ctx.extra.socket.close(4403, 'Forbidden');
      }

      (ctx as any).headers = {
        ...ctx.connectionParams,
      };
    },
    onSubscribe: async (ctx) => {
      const authenticated = await authenticateBearerToken(
        ctx.connectionParams?.authorization as string
      );

      if (!authenticated) {
        return ctx.extra.socket.close(4403, 'Forbidden');
      }

      (ctx as any).headers = {
        ...ctx.connectionParams,
      };
    },
  },
  wsServer
);

While the above is specific to usage with the nest graphql module, the general steps are generic:

generate an executable schema from the emsh config via the methods mentioned above
create a grphql server and attach use the executable schema that was generated
add the websocket code (might differ slightly from express to other server frameworks but the ws-grpahql lib documentation should have you covered

Let me know if you have any more questions.

Just ran the following test in the project above:

started mesh via mesh cli
graphiql will open
running subscriptions does not work right away as mesh initializes graphqil for SSE by default instead of websockets
to change that execute the following in the browser console (replace 7417 with the port you are using):GraphQLHelixGraphiQL.init({
        defaultQuery: undefined,
        defaultVariableEditorOpen: undefined,
        endpoint: "\/graphql",
        headers: undefined,
        headerEditorEnabled: undefined,
        subscriptionsEndpoint: "ws:\/\/localhost:7417\/graphql",
      });

Afterwards I was able to execute subscriptions as usual
The only different to using hasura directly is that the connection to mesh uses the new protocol and mesh connects via the old protocol to hasura (incl retaining auth)

version used:
    "@graphql-mesh/cli": "^0.29.5",
    "@graphql-mesh/config": "^0.15.6",
    "@graphql-mesh/graphql": "^0.17.0",
    "@graphql-mesh/runtime": "^0.14.1",

Those are likely pretty outdated by now. Try and use these to see if you still see the auth error, if not there might be a bug in one of the newer version.

@ntziolis You would lose the benefits of Mesh artifacts and stuff if you use runtime and config packages directly. And you can also replace Mesh's server with your own;
https://www.graphql-mesh.com/docs/recipes/build-mesh-artifacts <- See how to use artifacts
https://www.graphql-mesh.com/docs/recipes/custom-server <- See how to replace the server

@ntziolis Thanks for sharing! It validates that the current issue with mesh default server implementation is that connectionParams aren't used.
@ardatan What do you think about spreading connectionParams (or connectionParams.headers) into the request's headers?

@ntziolis Thanks for sharing! It validates that the current issue with mesh default server implementation is that connectionParams isn't used.

I don't think that's the correct conclusion. As I described in my second comment I ran a test if the passthrough of connection params works when just using the cli and it did. At least in the versions I outlined.
What might be true is that there is a bug in a later version of mesh / graphql-tools that doesn't do it correctly anymore. I will have a quick look.
@ardatan Thank you for bringing build / artifacts to my attention. I didn't know that those existed, it had been quite a while when we first set this up.

@jgoux I took a quick look at the source and collected a few key places in the code to figure out what is going on:
This is where mesh creates the url loaders (based on what part of the downstream schema you are trynig to access):
https://github.com/Urigo/graphql-mesh/blob/9108709bf5dd969f0dd014bc4e01b6624eca301c/packages/handlers/graphql/src/index.ts#L93
Since queries and mutations work just fine in your current setup (assumption on my end), we can safely assume that the contents of headers is correct. At this point the headers object is already computed (no async anything anymore, this happens prior).
The below is the code in the loader that tales the parameters incl headers from above and initilizes the downstream client (in our case the legacy ws client):
https://github.com/ardatan/graphql-tools/blob/9a13357c4be98038c645f6efb26f0584828177cf/packages/loaders/url/src/index.ts#L597
The above code uses the headers and creates a sync connectionParams method from it to match the params rthe subscription clients are expecting.
The last step is then to use the legacy client factory method, which passes the arguments straight into the clients constructor. again connectionParams is now a sync method that simply returns and object with the headers key on it:
https://github.com/ardatan/graphql-tools/blob/9a13357c4be98038c645f6efb26f0584828177cf/packages/loaders/url/src/index.ts#L462
When looking at the above:

From the point on when headers are computed
They get passed through correctly and at the end are applied correctly via a connectionParams method to the legacy client

So that would lead me to assume that the headers are not correctly computed before this process starts.
How to address:

In general it helps to think about mehs in the following terms:

the way you connect to mesh (incl auth), has no connection to how mesh connects to the data (incl auth)

If you want there to be a connection, like pass through auth headers you need to configure that
If dealing with a graphql source there are 2 types of auth headers you need to know about
schema headers (that's what mesh uses to access read schema from the downstream source)
and operation headers (thats what the user of the mesh uses to connect to the downstream schema)
from what I understand you want that for operations the headers provided from the client connecting to mesh should be passed through to when making the requests against the downstream schema

You can achieve that by following the below example:
https://www.graphql-mesh.com/docs/handlers/graphql#from-context-http-header-for-mesh-dev-or-mesh-start
If you already have this configuration in place and it doesn't work, please let me know.

Available in the latest version! Thanks @enisdenjo for the fix! 🙏


update in place fails CRC32 check on crash between data write and header write

In issue #2 we added a CRC32 of the data into the header. That protects against the data spanning disk structures that are not flushed on a crash. The update of the payload that matches the CRC32 and the update of the header is not atomic. If we crash between the two writes then when we open the file and try to read the data it will fail the CRC check.
This bug was caught by the tests that inject IOExceptions into the write paths of the junits.

fixed in 0.8.0


[core] Case sensitivity problem

When there are multiple errors on the class
on my case starting with a number (so it needs to insert AnonymousClass on the begin) and having repeated names in different cases
the classes fail to decompile properly
ex:
with case sensitivity, valid identifier and printable flags set
classes 12A  and 12a becomes AnonymousClass12A and AnonymousClass12a so it crashes the case sensitivity
with case sensitivity and printable flags set
classes 12A  and 12a becomes C12A and C12a so it crashes the case sensitivity too

@gkillershots Can you please add the info in which Jadx version you have encountered this issue?

<IP_ADDRESS>-b873c6ae
also I noticed that with only the with case sensitivity and printable flags set and forced deobfuscation with a min length of 6 (to generate a random string on the end so the case sensitivity wont screw up) the R.java (which may be because it's really huge, so it won't load even on the editor) but, if I export without deobfuscation it exports successfully the R.java


Avoiding recursive behaviour at locale errors

If the locale folder cannot be found, or the default language "en" is not present, this method will start a recursive loop with no exit criteria.
This change updates the code to first try and load the selected locale. It that fails, it will try to load default locale but only once. If that also fails, it will raise an alert and no longer hang the application.

Thanks!


Breaking Change Request: Remove support for armv6

Intended change in behavior: Remove support for ARMv6 in Dart VM.
Justification/rationale: Flutter doesn't officially support ARMv6 (see also flutter faq) and neither does Dart. We have no test coverage of it either (afaik).
Expected impact of this change: Should not impact any direct users of Flutter / Dart SDK. It will no longer be possible build custom Dart VM for ARMv6 and run on ARMv6 devices (known affected devices: old Raspberry Pi 1 & Zero).
Clear steps for mitigating the change: None
/cc @Hixie @vsmenon @mit-mit @a-siva  @franklinyow

Related 2.5 year old flutter issue: https://github.com/flutter/flutter/issues/22380

Breaking change email has been sent to dart-announce@

can we trade armv6 support for thumb2 only support? windows arm devices don't support anything but.

cc @Hixie @matanlurey @vsmenon for review and approval.

I'm all for deleting code in principle. Have we check with Alibaba and other companies that asked for this feature? They may be building custom engines with it. cc @zoeyfan

Hey Kang,
I want to bring this to your attention since this is a breaking change. Let
me know if you have any concerns.
Thanks,
Zoey
On Fri, May 29, 2020 at 3:30 PM Ian Hickson<EMAIL_ADDRESS>wrote:

I'm all for deleting code in principle. Have we check with Alibaba and
other companies that asked for this feature? They may be building custom
engines with it. cc @zoeyfan https://github.com/zoeyfan
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/42069#issuecomment-636220912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMR3237TD7JDVZTZBR2254DRUAZRZANCNFSM4NL7MRKA
.

Have we check with Alibaba and other companies that asked for this feature?

We've reached to a number of entities offline and have not heard any concerns. I also see no concerns listed in the present issue. @Hixie @matanlurey @vsmenon can we approve this change?

Note: once/if you agree, we still need to get this posted on dart-announce for broad feedback.

I defer to @zoeyfan; I have no personal objection.

It's already announced:
https://groups.google.com/a/google.com/g/dart-announce/c/3UJRSrIq7-0

@vsmenon can you give the final approval?

It's already announced:
https://groups.google.com/a/google.com/g/dart-announce/c/3UJRSrIq7-0

Hey is that a google only group, I can't access it and can't see any see any ARMv6 announcement in
https://groups.google.com/a/dartlang.org/forum/#!forum/announce
I don't have an issue with the removal of armv6 support, I do wish the Raspberry Pi people would stop selling armv6 boards, maybe some part of google could somehow help the Pi people to move the pi zero to a more modern processor.

@sebe You are right, the announcement went to the wrong group.
I copied the announcement over:
https://groups.google.com/a/dartlang.org/g/announce/c/U50WhgzD8t0

@sebe Heh. I second the RPI idea. It's a real pain having two architectures to deal with.

The one thing I would ask about this change is that you guys tag the commit before the first change in some way that is easy to find. I do have a couple of armv6 devices that run flutter. I don't mind sticking to an older version for them, but it'd be helpful to be able to easily find the end commit.

@JakeSays Due to the lack of current build/testing on our continuous integration system, it might already be broken. If not you could take any commit atm.
We haven't removed the code in the Dart VM yet - though I've made now a CL to do that which will probably land soon cl/152322

lgtm
@franklinyow - are we clear to land?

Mark this as approved.  @mkustermann please go ahead and land.

can someone please clarify this in the docs: https://docs.flutter.dev/reference/supported-platforms
I am unsure what "support for the platforms on which built Flutter might be deployed" means. What is built flutter? Does it mean that the table is regarding which platforms are supported to build the app? Or does it mean these are the target platforms that are supported? Or is it that this entire page is just talking about support for host machines that deploy the app? I'm super confused and need clarification which Raspberry pi OS and cpu would run a flutter app that I code on my macbook and cross compile with docker.
Why is there no mention of CPU architectures supported if the latter is true?
Thank you

/cc @mit-mit regarding about our supported platforms

Hi @talksik. Yeah, that sentence wasn't so easy to read. I'm updating it in https://github.com/flutter/website/pull/9005/files
Yes, this page lists the supported target platforms, i.e. the platforms on which we support running apps that have been built with Flutter.

awesome thank you for the edit and clarification!

It would be good to keep ARMv6 support. I would also like to write an embedder of flutter for the Nintendo 3ds.
It shouldn't be that difficult to keep it backwards compatible.


OpenSSH broken on Nodejs20

Possibly related to this.
Steps to reproduce:

docker run -it --entrypoint /bin/bash public.ecr.aws/lambda/nodejs:20
dnf update -y && dnf install -y openssh-clients
ssh -V

Results in
bash-5.2# ssh -V
OpenSSL version mismatch. Built against 30000080, you have 30100050

I believe the solution is to get openssh upgraded to 3.1.0: https://github.com/msys2/MSYS2-packages/issues/3660#issuecomment-1472076356

Tested it out on a sporadic number of other Lambda images, seems to be isolated to nodejs:20, sorry for the exaggerated initial title.

Any updates on this one ? On running ssh -V , we are getting OpenSSL version mismatch. Built against 30000080, you have 30100040


GROOVY-5139: GroovyTestCase's shouldFail {...} should return the throwable and not the enclosed message

http://jira.codehaus.org/browse/GROOVY-5139
As a part of GroovyTestCase shouldFail should return the entire throwable and not just the enclosed message. There may be other items on the exception that bears inspection, assertion.
The easy workaround to fix existing code is to tack a '?.message' on existing tests.

to update on this... there are several comments on the issue in our JIRA. So far we have the tendency to use instead a static import and a new class, containing the method(s)

I merged in the idea but not the code since I started from scratch creating a new file. Colin, that means you don't appear in the git history related to this change but I added you into the contributors within the pom. Hope that's OK.

Its fine that I don't appear in the git history.  Just glad to help :-)  and its also fine that you added me as a contributor within the pom


Cell update bug with tables and mo.ui.run_button (race condition?)

Describe the bug
When mo.ui.run_button is used to create a list of dict, any cells referencing this list show the table empty of values.
However, when the output is triggered by a state change, the table display works correctly.

This bug first appeared in marimo version "0.9.15"
Environment
{
"marimo": "0.9.20",
"OS": "Linux",
"OS Version": "6.10.14-linuxkit",
"Processor": "aarch64",
"Python Version": "3.10.12",
"Binaries": {
"Browser": "--",
"Node": "--"
},
"Dependencies": {
"click": "8.1.7",
"docutils": "0.21.2",
"itsdangerous": "2.2.0",
"jedi": "0.19.2",
"markdown": "3.7",
"narwhals": "1.14.1",
"packaging": "24.2",
"psutil": "6.1.0",
"pygments": "2.18.0",
"pymdown-extensions": "10.12",
"pyyaml": "6.0.2",
"ruff": "0.7.4",
"starlette": "0.41.3",
"tomlkit": "0.13.2",
"typing-extensions": "4.12.2",
"uvicorn": "0.32.1",
"websockets": "12.0"
},
"Optional Dependencies": {
"altair": "5.4.1",
"pandas": "2.2.3"
}
}
Code to reproduce
import marimo

__generated_with = "0.9.20"
app = marimo.App(width="full")

@app.cell
def __():
    import marimo as mo
    return (mo,)

@app.cell
def __(mo):
    sel_start = mo.ui.run_button(label='Create list of dict')
    sel_start
    return (sel_start,)

@app.cell
def __(mo):
    get_finished, set_finished = mo.state(value=0)
    return get_finished, set_finished

@app.cell
def __(sel_start, set_finished):
    # Create a large list of dicts
    my_list_of_dict = []
    if sel_start.value:
        my_list_of_dict = [{
            'Column1': 'Value1',
            'Column2': 'Value2',
            'Column3': 'Value3'
        }]
        set_finished(1)
    return (my_list_of_dict,)

@app.cell(hide_code=True)
def __(mo):
    mo.md(r"""## This table does not display correctly due to race condition""")
    return

@app.cell
def __(mo, my_list_of_dict):
    mo.ui.table(my_list_of_dict)
    return

@app.cell(hide_code=True)
def __(mo):
    mo.md(r"""## This table is correctly shown as it waits for the state change""")
    return

@app.cell
def __(get_finished, mo, my_list_of_dict):
    if get_finished() == 1:
        mo.output.replace(mo.ui.table(my_list_of_dict))
    return

if __name__ == "__main__":
    app.run()

This is an odd bug, thanks for finding this. I am even printing out the time and the execution order looks like it should be ok:

We will look into this

Printing out the dictionaries look correct too


Add Circle CI

Add Circle CI for PR Requests and testing

Need a paid plan for Mac OS

Closing this and going with Travis since it is free for open source projects


[BACKPORT][TC-518] ToCDUCheck and ToCHRCheck: Value formatted as float instead of int #1090

Convertion was auto-applied by MySQL, but not with Postgresql resulting in errors in logs

Cherry-picking 5cb898398f7fe4bba165e99c84a6c119d898d5b7
Fixes #1090

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/247/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/205/


Prompt just returns the Nunjucks template

Expected Behavior
The prompt dialog to open, asking for the value.
Actual Behavior
The Nunjucks template gets returned:
{% prompt 'password', '', '', '', false, false %}

Reproduction Steps

Create a POST request to https://httpbin.org/post that uses Multipart for the body
Use Prompt for one of the form fields
Get something that looks like this:

{
	"args": {},
	"data": "",
	"files": {},
	"form": {
		"username": "{% prompt 'Hey', '', '', '', false, true %}"
	},
	"headers": {
		"Accept": "*/*",
		"Content-Length": "something (I removed some stuff from the response so it wouldn't be right)",
		"Content-Type": "multipart/form-data; boundary=X-INSOMNIA-BOUNDARY",
		"Host": "httpbin.org",
		"User-Agent": "insomnia/2023.2.2",
		"X-Amzn-Trace-Id": "[redacted]"
	},
	"json": null,
	"origin": "[redacted]",
	"url": "http://httpbin.org/post"
}

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2023.2.2
What operating system are you using?
Windows
Operating System Version
Windows 11 22H2 (22621.1702)
Installation method
Download from insomnia.rest
Last Known Working Insomnia version
No response

Were you able to solve it? I do have this problem as well for several weeks.

Were you able to solve it? I have this problem as well for several weeks.

Unfortunately no, I ended up just not using Insomnia in the end

Were you able to solve it? I have this problem as well for several weeks.

Unfortunately no, I ended up just not using Insomnia in the end

I just found the option which was the problem.

When you unselect "Raw template syntax" it looks better again. I was just blind, when opening the settings.


Different behavior with clang-tidy: open local folder with CMakeLists vs. VS sln file generated by cmake

Trying to understand some different behavior running clang-tidy through clang-power-tools on Visual Studio 2022 Community Ed.  Running clang-tidy is started by clicking the Tidy icon from the Clang Power Tools.
Quick summary:  can't get clang-tidy to run through VS 2022 when local folder (with CMakeLists.txt) is opened.  Works with CMake generated VS Soln file opened with VS 2022.
More details below:
Opening the local folder of a very simple CMake project with VS 2022 Comm Ed and attempting to run clang-tidy, selecting the Tidy button, I get the following in the Output tab:
--- CLANG TIDY STARTED ---

At line:1 char:132
+ ... \EXTENSIONS\vfkd2wds.v0j\Tooling\\v1\clang-build.ps1' -proj ) -file ( ...
+                                                                 ~
Unexpected token ')' in expression or statement.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : UnexpectedToken

--- CLANG TIDY FINISHED ---

and clang-tidy does not run as I would expect.
However, if I use cmake to generate the VS Solution file and open the solution into VS 2022 Comm Ed, clang-tidy runs as I would expect.
cmake -G "Visual Studio 17 2022" ..
In this case, the beginning of the output looks like this:
--- CLANG TIDY STARTED ---

VERBOSE: Current Clang Power Tools VSIX version: <IP_ADDRESS>4
VERBOSE: Loaded assembly C:\Program Files\Microsoft Visual
Studio\2022\Community\MSBuild\Current\Bin\Microsoft.Build.Utilities.Core.dll
VERBOSE: clang-build.ps1 invocation args:
....

Not sure what may be causing this different behavior.  I'm using
clang power tools version <IP_ADDRESS>4
Visual Studio 2022 Comm Ed Version 17.3.3
the code I've been testing this with is very simple:
https://github.com/willemsn/clangTestCase
Any thoughts on what may be causing this behavior or if I'm doing something that might be causing this?

Hi,
Sorry for delay answer, we are looking into it and working towards a fix.
I will keep you updated as progress is made.
Best regards,
Marina

Hi!  No worries!  If there is something I can do to help, let me know.

Hi @willemsn,
I am pleased to introduce a fix to the Clang Power Tools extension. I would really appreciate it if you could take the time to test it out v2<IP_ADDRESS> and provide your feedback. Your input is invaluable to us, and I thank you in advance for your help.
Don't forget to add cmake in path
Best regards,
Marina

Hi @mariru27,
I can confirm that the fix solves the issue for me.

Hi @gian21391,
Thank you for your quick response
I will notify you here when release is available
Have a nice day,
Marina

Just tried it with a CMake-based project and it works!  I'll do some more testing today with some other projects.
Thank you!!!

Thank you for letting me know @willemsn and @gian21391. I'm glad the fix worked and that you're happy with the result.
Have a nice day,
Marina

Hi,
A release with bugfix for this issue is available in new v2023.2.1 of Clang Power Tools
Thank you for your help
Have a nice day,
Marina


Still same problem, with cloudlaunch

Cloudlaunch has the AdministratorAccess policy, now.
After a while, the instance tries to start and configure itself, I get the same message.
UNABLE TO CHECK STATUS
Health check failed: CloudBridgeBaseException: Unable to locate credentials from exception type: <class 'botocore.exceptions.NoCredentialsError'>

This is not the same error as the one indicating insufficient permissions.
This is due to the fact that you are using temporary credentials rather than saving credentials to your profile. In this case, CloudLaunch does not keep a copy of your credentials after the initial launch, meaning it doesn’t have the necessary credentials to check on the status of the instance. Note that the instance most likely did get booted, so remember to terminate them from the AWS console or you may incur unnecessary costs.
If you want to not have this error post-launch, you will have to give CloudLaunch the right to store your credentials (by saving them to your profile), in which case the status of the machine can be checked from the CloudLaunch page.

Closing this as a duplicate of https://github.com/galaxyproject/cloudlaunch/issues/207 . Please reopen if it seems like there is another issue


Testing: Easy File upload testing

We currently don't have a great way to test file uploads for end users.
It would be nice to be able to simply provide a CodeIgniter\Files\UploadedFile object to the request and have it recognize it correctly, set the enctype header, and just work...

Duplicate of #7987


⚠ Bofrost.de has degraded performance

In fdb1d49, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1047 ms

Resolved: Bofrost.de performance has improved in abaeb37 after 6 minutes.


Does World Host do any kind of E2E (End to End Encryption)? Would be nice to have an explanation and to know that these port-forwarded tunnels aren't open for hackers to jump in and abuse.

The Minecraft protocol itself has its own E2E encryption.

Yeah, I don't do any extra encryption.


Blobs' folder names are not displayed in the new blob explorer if the list mode is switched from Hierarchical to Flat

Storage Explorer Version: 1.31.0-dev
Build Number: 20230726.3
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Previous release (1.30.2)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Right click the blob container -> Click 'Open in React'.
Create a folder -> Upload a blob to the folder.
Open the view options panel -> Select 'Flat' as the list mode.
Check whether the blob is displayed as the full name.

Expected Experience
The blob is displayed as the full name.

Actual Experience
The folder name doesn't display.

Additional Context
This issue doesn't reproduce if set the default list mode to 'Flat'.

Verified this issue on the main build 20230727.4. Fixed. So, we are going to close it.


Migration tool feedback

Describe the bug
Three issues I noticed that may be able to be automatically migrated:

typo +page.server.js vs +page.js https://discord.com/channels/457912077277855764/571775594002513921/1009951261279387781
it could probably migrate /** @type {import('@sveltejs/kit').PageLoad} */ to /** @type {import('./$types').PageLoad} */
fetch wasn't added in load so I ended up using global fetch accidentally. not the worst though because I got a console warning about that

Reproduction
noticed when working on https://github.com/sveltejs/sites/pull/371
Logs
No response
System Info
n/a

Severity
annoyance
Additional Information
No response

fetch wasn't added in load so I ended up using global fetch accidentally. not the worst though because I got a console warning about that

Where did that happen specifically? AFAIK nothing is removed/added to the load function, so this was likely an existing bug

it could probably migrate /** @type {import('@sveltejs/kit').PageLoad} / to /* @type {import('./$types').PageLoad} */

I'm hesitant to do this, because people could have a reason for this. We don't know if they use TypeScript at all (or rather, have TypeScript in their package.json) in this case; if they don't the $types aren't generated.

The fetch thing happened several places. It looks like you're right about it being an existing bug: https://github.com/sveltejs/sites/blob/1c83a81d3957812a2986c6c50667d3cfca790980/sites/svelte.dev/src/routes/examples/__layout.svelte#L5
I'm not sure I understand what you were suggesting about the types migration. I assumed if they already had a type declaration then they were using type checking, but it sounds like they could have that comment without TypeScript installed which would cause issues if we were to automatically migrate?
Thanks for fixing the typo and reviewing this issue!


Moves error handling to write_headers instead

See my comment at the end of #146 here. I'm seeing the Errno::EPIPE much less frequently, but it still pops up from a couple other places that make calls to write outside of <<.
This PR moves the error handling to write_headers which is called from everywhere else that's been raising the error, including <<. I now have write_headers return a boolean of whether it was successful in writing those headers, and the methods that call write_headers check that it returned true before writing the rest of their response.
The only hiccup I came across was trying to make a one-liner in the check in write_and_close: my test didn't have an async_response object to give to the client, so an error was raised when the check looked like if @io && write_headers:
NoMethodError: undefined method `<<' for nil:NilClass
    /Users/rob/Sites/gems/message_bus/lib/message_bus/client.rb:221:in `write_and_close'
    /Users/rob/Sites/gems/message_bus/lib/message_bus/client.rb:99:in `<<'
    spec/lib/message_bus/client_spec.rb:56:in `block (3 levels) in <top (required)>'

I found an example of setting async_response in the ConnectionManager spec but I don't feel like I should be crossing concerns and trying to add fake responses into this Client spec. Could I stub async_response in the Client spec to respond to << and done?
Or maybe it's safe to leave that as two separate checks and only have @async_response set if @io is initially nil and not if it becomes nil as a result of write_headers failing? Could a message get lost?

hmmm ... implementation wise maybe we should be more consistent.
We handle this here:
https://github.com/SamSaffron/message_bus/blob/master/lib/message_bus/connection_manager.rb#L26-L32
and here:
https://github.com/SamSaffron/message_bus/blob/master/lib/message_bus/rack/middleware.rb#L207-L214
Maybe we are just missing another spot? Maybe we can just pull out the handling from client.rb and ensure stuff that attempts to send messages always catches.

Every one of the errors has this block of code as the "lowest common denominator" in the backtrace: https://github.com/SamSaffron/message_bus/blob/master/lib/message_bus/rack/middleware.rb#L147-L151
client.synchronize do
  client.deliver_backlog(backlog)
  add_client_with_timeout(client)
  client.ensure_first_chunk_sent
end

We're using long polling and have rack.hijack so that's the only block we enter, but there are a couple of client.synchronize blocks nearby by that have similar logic.
Is it safe to rescue in the middleware and just return a static response or could a message get dropped? That particular block returns a 418(!) right after the synchronize. The last else in the chain returns [200, headers, ["[]"]].
I do see an undocumented feature at the end of the method there:
rescue => e
  if @bus.on_middleware_error && result = @bus.on_middleware_error.call(env, e)
    result
  else
    raise
  end
end

So just defining an on_middleware_error block in my config will allow me to do whatever I want with the error, including just discarding it?
Maybe my PR should just be adding documentation to this feature instead of swallowing the error? :)

Maybe my PR should just be adding documentation to this feature instead of swallowing the error? :)

I support that. Maybe just do that? and revert the original rescue. feels somewhat cleaner

Sounds good! I'll close this one and open a new one.


Suggestion: a branch for every architecture

Hello and thank you for the plugin!
I wonder if it would be possible to create a separate branch for every architecture (apple-darwin, pc-windows etc.), so that the plugin could be installed on a specific machine without running the installation script?

That will misuse Git branches and will be hard to maintain.

Thank you for the quick response. I'll keep doing it by hand then.


Adding more models in enum package.json

@ex3ndr, hi,
is it possible to add to enum package.json absolutely all models? Very few 70b models

Why you need it though? You can always pick a custom one


Error: Incompatible units: 'rem' and 'px'.

Hi, when I try run gulp command to compile sass files , this is result:
**Error: Incompatible units: 'rem' and 'px'. **
$ gulp
[00:40:25] Using gulpfile E:\Work\Bootstrap4\gulpfile.js
[00:40:25] Starting 'bower'...
[00:40:25] Using cwd:  E:\Work\Bootstrap4
[00:40:25] Using bower dir:  ./bower_components
[00:40:25] Starting 'icons'...
[00:40:25] Starting 'css'...
[00:40:25] Starting 'js'...
[00:40:27] Finished 'js' after 1.89 s
[00:40:27] Finished 'icons' after 1.95 s
Error in plugin 'sass'
Message:
    bower_components\bootstrap\scss\_variables.scss
 Error: Incompatible units: 'rem' and 'px'.
        on line 284 of bower_components/bootstrap/scss/_variables.scss
>> $input-height:                   (($font-size-base * $line-height) + ($input-p
   -----------------------------------^

[00:40:27] Finished 'css' after 1.99 s
[00:40:31] Finished 'bower' after 5.74 s
[00:40:31] Starting 'default'...
[00:40:31] Finished 'default' after 55 μs

and here is my codes : https://github.com/mmdsharifi/Bootstrap4-RTL

This doesn't happen with vanilla v4-dev. Presumably your error is caused by you overriding one of the Sass variable values to something that ends up being nonsensical.

thanks alot , but how to install this package v4-dev form bower?

Please ask how-to questions on StackOverflow, IRC, or Slack, rather than this bug tracker. Thanks!

Hi @cvrebert
I just got same issue.
feryardiant ~/.../Projek.xyz/Codes/slim-app (master)
[19:36:57] $ gulp styles
[19:43:52] Using gulpfile ~/Workspaces/Projects/Personal/Projek.xyz/Codes/slim-app/gulpfile.js
[19:43:52] Starting 'styles'...
[19:43:53] Finished 'styles' after 772 ms
[19:43:53] gulp-notify: [Error running Gulp] Error in plugin 'gulp-sass'
Message:
    res/vendor/bootstrap/scss/_popover.scss
Error:
Incompatible units:
'rem/px' and 'rem'.
        on line 112 of res/vendor/bootstrap/scss/_popover.scss
>>   @include border-radius(($border-radius-lg - $offset-border-width) ($border-r
   --------------------------^

I'm using gulp-sass and twbs-bootstrap4-alpha2 installed via bower.
Here my gulp config.
// some scripts

var sassConfig = {
  precision: 6,
  indentedSyntax: false,
  sourceComments: false
}

gulp.task('styles', function () {
  gulp.src(paths.src)
    .pipe(sourcemaps.init())
    .pipe(sass(sassConfig))
    .pipe(autoprefixer(autoprefixerConfig))
    .pipe(csscomb())
    .pipe(sourcemaps.write())
    .pipe(gulp.dest(paths.dest))

  return gulp.src(paths.src)
    .pipe(cssmin())
    .pipe(rename({ extname: '.min.css' }))
    .pipe(gulp.dest(paths.dest))
    .pipe(browserSync.reload({ stream: true }))
})

And.

Presumably your error is caused by you overriding one of the Sass variable values

yes, I override some default variable including $border-radius-lg, I've tried to remove my overrides but still no luck.
Any clue?
Thanks

@feryardiant Please ask personal support questions on StackOverflow, IRC, or Slack.


Hi there,
Thanks for reaching out! Unfortunately DataFire clients don't yet support the browser, so I'm not surprised that webpack failed.
In general, it's not recommended that you connect to Gisgraphy from the browser, as that would expose your API key. I would suggest using @datafire/gisgraphy in a NodeJS backend (where your API key can be stored) and connecting to that from the frontend.
Hope that helps!


[T4A2][W09-B4] Loh Jia Shun Kenneth

Need to change the code where you use parseCommand() as well since now it's static. Next time please only include code change for the particular activity :). Please close the issue.


Select ticket types for projects similar to ticket status

This would give the manager more control per project.
Some project may require the type "Bug", others may not.
Being able to choose the types similar to the statuses would make the tags more practical.

This would be solved with the tristate control.


how to use kto_pair loss in the latest version ?

I can see that kto_pair losstype is no longer available in the latest version of dpo trainer. You suggest to use ktotrainer instead.
But kto_pair loss worked much better than kto_trainer on my dataset, so how do I continue to use kto_pair if I'm using the latest version of the trl library?
thanks a lot!

maybe you can try trl < 0.9.5

maybe you can try trl < 0.9.5

fine

Do you mind sharing your dataset?

Closing as not enough information to reproduce that kto_pair is worst than using KTOTrainer


Command doesn't work in zsh

   kubectl get svc istio-ingress -o jsonpath={.spec.ports[0].nodePort}

listed in https://istio.io/docs/samples/bookinfo.html

fixed


doc: Add STM32H745I-DISCO dual-core documentation

Summary
Added STM32H745I-DISCO documentation for dual-core support.
Impact
Testing

@hartmannathan I'm just asking if Makefile is supported and why the text is saying it is recommend to use CMakefile. In theory Makefile and CMakefile needs to be kept in sync. If it is not, there is an Issue and it needs to be reported

@hartmannathan I'm just asking if Makefile is supported and why the text is saying it is recommend to use CMakefile. In theory Makefile and CMakefile needs to be kept in sync. If it is not, there is an Issue and it needs to be reported

@acassis Okay. Should it be reported in an issue? What to do with this PR in the meantime?

@hartmannathan I'm just asking if Makefile is supported and why the text is saying it is recommend to use CMakefile. In theory Makefile and CMakefile needs to be kept in sync. If it is not, there is an Issue and it needs to be reported

@acassis Okay. Should it be reported in an issue? What to do with this PR in the meantime?

Wait for the author to reply :-D
He opened the PR today, we need to give time for more people to review it.

Hello @acassis, sorry for the late reply. It is prefer to build with CMake because CMake can build multiple instances in different directory, which is great in dual-core case. When using Make to compile, 2 NuttX instances needs to be created which is harder compare to CMake.

Makefile is supported, but CMake is preferred!

Hello @acassis, sorry for the late reply. It is prefer to build with CMake because CMake can build multiple instances in different directory, which is great in dual-core case. When using Make to compile, 2 NuttX instances needs to be created which is harder compare to CMake.

Don't worry, take your time. I think it is important to include this information there.
Did you try to compile with "make -j", how is compares to compiling with cmake ?

I haven't tried that. I will try that tomorrow since I'm not with my work machine.

I haven't tried that. I will try that tomorrow since I'm not with my work machine.

Perfect! Thank you! Normally I compile this way, the compilation time drops from minutes to few seconds (5s for stm32f4discovery:nsh for instance)

Your welcome! I will let you know. @acassis

Using make to build images for AMP applications doesn't make any practical sense now, so recommending to use cmake makes perfect sense - compilation is usually faster and allows for out-of-tree build which makes the whole process faster and more enjoyable. It's a good practice to give users recommendations so that they don't waste their precious time :)

Hi @acassis, I have tried building with make -j the building speed compare to CMake is similar for me.

@nonpawite thanks for confirming my suspect!


ACAPY repos

Sorry for the dumb question — what is “read” and why do we need a group that has that privilege. Since it is a public repo, can’t anyone see it and submit issues and PRs?  Longstanding question for me — it’s occured to me before.  Same with Triage — what does it add vs. Read vs. nothing.
Approving as regardless of the answer, we can deal with it later.

so you can assign issues to them


Resizing images for each model

Even though it's fixed here on git, when you install deepface through pip install deepface there's a problem in functions.py.
Code inside function detectFace:
	detected_face = cv2.resize(detected_face, (240, 240))

	img_pixels = image.img_to_array(detected_face)
	img_pixels = np.expand_dims(img_pixels, axis = 0)

	#normalize input in [0, 1]
	img_pixels /= 255

	return img_pixels

Should probably be:
        detected_face = cv2.resize(detected_face, target_size)

that's sent as a parameter of a function.
This causes warnings from tensorflow about incompatible image sizes.

The code repo and pypi versions include target_size as argument
Repo: https://github.com/serengil/deepface/blob/master/deepface/commons/functions.py, line 303
Pip: https://pypi.org/project/deepface/0.0.33/#files -> deepface-0.0.33.tar.gz (43.8 kB)
What was your deepface version?

C:\Windows\system32>pip show deepface
Name: deepface
Version: 0.0.33
Summary: A Lightweight Face Recognition and Facial Attribute Analysis Framework (Age, Gender, Emotion, Race) for Python
Home-page: https://github.com/serengil/deepface
Author: Sefik Ilkin Serengil
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: c:\users\user\appdata\local\programs\python\python38\lib\site-packages
Requires: Flask, numpy, keras, gdown, tensorflow, pandas, opencv-python, Pillow, tqdm
Required-by:

I'm pretty sure I didn't change anything. Doesn't matter if it's fine for others, I just didn't want other people to spend 2 hours looking for a problem like I did.
Probably there was a mistake on my end, but still not sure where and why.

It is very interesting. Could you uninstall and reinstall deepface again? Then I would ask you to check that line in your deepface folder.

Sure will. But I'm doing a project right now with your framework and not really in the mood of risking anything again. 😄
Will do it right after I'm done and I'll come back with an answer.


Simple docs

Currently running a full docs build locally to check it's okay.

Cool - I've found a couple of mistakes in the Markdown; will fix those, push again, then merge.


Add Minigui Study mode support to Python engine

We need to add support for the following required GTP commands:

playsgf
select_position

And optionally:

prune_nodes
winrate_evals

python engine i think also needs support for value_init_penalty flag.


missing --dbt  packages

Add these packages explicitly to avoid ModuleNotFound errors when using data-diff --dbt before installing the [dbt] extras

https://github.com/datafold/data-diff/pull/544 will resolve this as well


[Feature] Form Arrays

Currently, with the introduction of nested field support, we're able to support array-style fields something like the following:
<Field name="test[0].name">
	// ...
</Field>
<Field name="test[1].name">
	// ...
</Field>

This should work, but there is a problem with this; when submitting a form, it will not treat test as an array but rather as an object:
{test: {0: {name: "val"}, 1: {name: "val"}}}

It would be nice to add a better story for field arrays in HouseForm.
Further, it would also be nice to have the ability to validate these field arrays using Zod's z.array() type to provide validation for these values.
Potential APIs
There are multiple different APIs we could use to achieve this effect.
Option 1: Reusing <Field>s
<FieldArray name="people" onChangeValidate={z.array(z.any()).min(3, "You must have three items in your array"}>
  {({ fields, setFields }) => (
    <>
      {fields.map((field, index) => (
        <Field key={field.key} name={`people.${index}.username`}>
          {({ value, errors, setValue }) => (

              <input
                value={value}
                onChange={e => setValue(e.target.value)}
                placeholder="Username"
              />
              {errors.map(error => {error}}

          )}
        </Field>
      ))}
      <button onClick={() => setFields([...fields, { name: "" }])}></button>
    </>
  )}
</FieldArray>

Pros:

Less tribal knowledge to setup form arrays
Potentially smaller codebase with code sharing

Cons:

High ambiguity about what should be stored in an array or not
Challenging implementation (conditional logic using contexts between FormContext and ArrayContext?)

How to store data with setField but also create a new Field instance?
How to tell Field to update ArrayContext with errors and more

How to handle listenTo? How to link all related field elements?
Poor treeshaking support

Option 2: Use dedicated components
<FieldArray name="people" onChangeValidate={z.array(z.any()).min(3, "You must have three items in your array"}>
  {({errors, fields, setFields}) => (
    <>
      {fields.map((_, index) => (
        <ArrayField key={fields.key} name={`people.${index}.username`} onChangeValidate={z.string()}>
          {({value, setValue, errors}) => (

              <input
                value={value}
                onChange={e => setValue(e.target.value)}
                placeholder="Username"
              />
               {errors.map(error => {error}}

          )}
        </ArrayField>
      ))}
      <button onClick={() => setFields([...fields, { name: "" }])}></button>
    </>
  )}
</FieldArray>

Notes:

field.key is a unique ID within the form to discourage people from using the array index

UUIDv4? (probably not, RN support)
Simple counter (SSR?)
Internal array index? (Reordering?)

Pros:

More manageable from the maintainer's perspective

Cons:

Wonky form behavior with setFields logic - run into issue with reordering fields and losing values, etc

Option 3: Use dedicated components with helper functions
<FieldArray name="people" onChangeValidate={z.array(z.any()).min(3, "You must have three items in your array"}>
  {({fields, add, remove, insert, move}) => (
    <>
      {fields.map((_, index) => (
        <ArrayField key={index} name={`people.${index}.username`} onChangeValidate={z.string()}>
          {({value, setValue, errors}) => (

              <input
                value={value}
                onChange={e => setValue(e.target.value)}
                placeholder="Username"
              />
               {errors.map(error => {error}}

          )}
        </ArrayField>
      ))}
      <button onClick={() => add({ name: "" })}>Add</button>
      <button onClick={() => remove(-1)}>Remove last</button>
      <button onClick={() => insert(3, {name: ""})}>Insert at third</button>
      <button onClick={() => move({from: 0, to: 1})}>Move the first array item to the second place</button>
    </>
  )}
</FieldArray>

This is the winner
Other Implementations

Formik
Angular

Work is being done on this branch:
feat/field-array


Ukrainian Upper case not appearing

@marella thanks, very usefull project
I use llama ggml model
With latest llama.cpp it says Привіт, but with ctransformers only ривіт
It is related to all words, not only first in a responce. Банан -> анан
I'm not sure if it's related to encoding or something else

Can you please provide a prompt and if possible seed to reproduce the output.

Thanks
Here is the demo
You can clone and run it
prompt "<human>: Привіт\n<bot>:"
Got оброго дня instead of Доброго дня

In llama.cpp no such problems
Also I looked in more detail about how it works
It appeared that upper latters are represented as sequence of two tokens <0xD0><0x91> = Б for example
Maybe it's somehow related

Important note, I'm using openllama
But still it works with llama.cpp

It appeared that upper latters are represented as sequence of two tokens <0xD0><0x91> = Б for example

Thanks, this helped debug the issue. In UTF-8 encoding, some characters are encoded using multiple bytes and if those bytes are part of different tokens instead of one token, I was not decoding them properly.
I pushed a fix. Will release it in the next version. Can you please try installing from source and see if it works:
pip install git+https://github.com/marella/ctransformers

Thanks, it's solved issue


Clean up the code a bit

Most of these changes were proposed in the previous PR. You also pushed your  .editorconfig by mistake.
I think it's best to have a look at what got currently pushed into the testing branch and start improving from there.


Melody compiler should warn for mounts with no keys (no 'as')

The compiler should warn if a mount has no key:
{% mount 'component.js' %}
Should be:
{% mount 'component.js' as 'key' %}
Especially in for-loops mounts should have keys.
Also update the documentation and emphasise on this.

@jamesb3ll @pago Should all mount decelerations without as key parameters have warning or should it only be in for-loops ?
I think, we can check this here https://github.com/trivago/melody/blob/27745d7531aed047f1491c33b9306adb7df87993/packages/melody-extension-core/src/parser/mount.js#L45

Hey, @ayusharma
It should be for all of them AFAIK. It can be problematic in case of for loops, we are planning to enforce it.

we are planning to enforce it.

It's better to throw an error in that condition.
Please let me know the error format.
I am thinking of this.
parser.warn({
              title: "Missing 'as' key with mount.",
              pos: tokens.la(0).pos,
              advice: "There should be an 'as' argumnet with a 'key' in mount statement."
            });


Improve grouping

Can we add more groups like left hand/right hand/face, just grouped so that it can be found easily, maybe it doesn't have grouping behavior just grouping, and when the group is collapsed, the scrollbar is smaller. Thanks.

I don't think it would be better to introduce more nested structure here. From my personal experience, I spend very little time on that list structure. It is only used if I want to know what the keypoint correspond to or I want to make an invisible keypoint visible again.
I would reconsider this if more users report the same issue.


As an Admin user I'd like to be able to manage other admin users...

...so that I can control who can administer the application
Part of Epic #11

From the authorization point of view this can be already done. Eaither the superAdmin or the OrgAdmin can create new users and assign them the "admin" policy.


Show suggested actions horizontally with line-break

Stacking the suggested actions takes up to much real estate. Most efficient way to show multiple suggested actions is horizontally with line-breaks with the option (nice to have) to align right, middle or center.
Good example sceenshot is in https://github.com/microsoft/BotFramework-WebChat/pull/2596

Looks like a suggestion for a new suggested actions layout. We have "carousel" and "stacked" today. This one is "flow" layout.

@compulim  Any Update regarding this ? ,
In stacked option can't we make it align left  ? so suggestions  all wrap like this ??

+1 on the need for flow layout (or a workaround please)

Adding a 'flow' layout in stead of carousel will also allow for styling on :hover of a suggested action resulting in a more pleasant user experience.

Looks like quite some votes.
Will bring this one up on our next planning meeting. Next vehicle is May, then Aug.

Can we have also have a option for suggested actions to stay relative just below the last message from bot.
Currently the suggested actions are sticky and take up permanent space if user scrolls up.
Could you suggest a fix for this?

https://github.com/microsoft/BotFramework-WebChat/issues/2745#issuecomment-570126555
is this feature introduced?

Is there any plans to introduce this feature? It is quite common to see in other chat components. The webchat component currently has terrible UX if there are too many suggested actions but this feature would solve it! Thanks.

would it be possible to also add the ability to configure, if the text of the buttons get too long, be able to word wrap?

@sam-sam-med  You can do it from Css trick for right now

@keshansandeepa I was hoping there be something out-of-the-box that can do this without having to use custom css.  the custom css is sort of like a workaround to get the text to word wrap.

@sam-sam-med Could you file a new feature-request and add that link to this conversation? I think button word wrap is a good option to have, but due to time limitations I'm not sure compulim would be able to add that to this change.

Hi team. What  happened with this feature  request? Do you still plan to implement it or should I stick with custom css for now?

hi @corinagum , how do I file a new feature-request ?  i've never done one on github before.  thank you.

@HesselWellema this item is still high priority on our list. It has been moved to our next milestone.
@sam-sam-med Please see the GitHub tutorial: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/creating-an-issue

hi @corinagum , thank you for the link to the info on creating an issue.  i have just created issue 3562.

Good luck with this one @compulim 👍


doc: add basic Gradle setup using Kotlin

What's changed?

I added a basic setup for those using Gradle + Kotlin
What's your motivation?

Making the basic setup easier for the readers, especially as Kotlin has become the default for gradle
Anything in particular you'd like reviewers to focus on?

no
Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

no
Any additional context

Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've added the license header to any new files through ./gradlew licenseFormat
[x] I've used the IntelliJ auto-formatter on affected files
[x] I've updated the documentation (if applicable)

Thanks a lot for adding this! It's indeed been missing in the docs, but should become more prevalent.
@mike-solomon would you mind going over this? Ties in nicely with the plans we had over on https://github.com/openrewrite/rewrite-recipe-markdown-generator/issues/66


Specify custom webpack entry points for the client and server

What problem does this feature solve?
Currently specifying config.entry in build.extend(config) is ignored.
The client entry is assigned without merging the value of config.entry that might have been set in build.extend:
https://github.com/nuxt/nuxt.js/blob/dcdbaba710c88c2f2b4c848aaa5f881074764556/packages/webpack/src/config/client.js#L178
The server config.entry is the result of merging a default config—overriding any config.entry value passed in build.extend:
https://github.com/nuxt/nuxt.js/blob/89f88669c10ce9100b109749aeab445638b851a8/packages/webpack/src/config/server.js#L71
It would be great if custom entry points could be specified in build.extend so that custom chunks could be generated independently of the Nuxt app.
Specify a custom entry name of app could throw an error notifying the user that this is reserved by Nuxt.
What does the proposed changes look like?
// nuxt.config.js
import { resolve } from "path"

export default {
  build: {
    extend(config, { isClient }) {
      if (isClient) {
        console.log(config.entry) // { app: [ "path/to/client.js", "eventsource-polyfill", "etc..." ] } (currently undefined)
      } else {
        console.log(config.entry) // { app: [ "path/to/server.js" ] } (currently undefined)
      }

       // This is ok
      config.entry.custom = resolve("custom-entry.js")

      // Throws error "entry.app is reserved by Nuxt"
      // Could use Object.defineProperty for the
      // config object passed to build.extend to
      // throw an error when attempting to set entry.app
      config.entry.app = resolve("app.js")
    }
  }
}

Running dev|build|generate would create another chunk called custom.

This feature request is available on Nuxt community (#c8543)

@wagerfield #5236 should fix it in next release. Please ping to reopen if still can't extend.

ping. I still can't seem to extend... and still get undefined from console.log(config.entry) as above. any chance of getting a working example? thanks

I still get undefined in v2.9.2.

I still get undefined in v2.9.2.

Yes, but you can just assign new...
config.entry = {worker: resolve('./client/lib/worker.ts')}; // work for me (v2.9.2)

sorry, but i want to know what the default entry is. But when i console config.entry, it's undefined


Can push props through the build wall

You can push props through the build wall by just scrolling out a bunch while standing in front of it, maybe we should look into dropping objects if they're being pushed into shit too hard and are way far away from desired position, or clamp the scroll distance if the distance is above a certain amount.

https://github.com/apetavern/sbox-fortwars/commit/2a018b797cc564de01186647d9fc50901f617b20 attempt at sort of mitigating it, makes it less common/easy to do at least.


New Project - Django Action Triggers (django-action-triggers)

Project Information

Project Name: Django Action Triggers
Project URL: https://github.com/Salaah01/django-action-triggers
Description: A Django library that asynchronously triggers actions based on database changes. Supports webhook integration, message brokers (Kafka, RabbitMQ), and flexible configurations.

Criteria
Please answer the following questions about the project you are submitting. This will help us evaluate if the project should be included in the Awesome Django list.

Is the project new?

[X] Yes
[ ] No

How long has the project been maintained?
1 month

How many releases has it had if it's a library or package?
5 - https://github.com/Salaah01/django-action-triggers/releases

Are you the author or are you submitting the project on behalf of a company?

[X] I am the author
[ ] I am submitting on behalf of a company
[ ] Other (please specify)

What makes it awesome?
Django Signals are awesome. They allow you to introduce the observer pattern and trigger events based on some kind of trigger. Typically, in Django, you define your specific signals in a signals.py file, which is essentially hard-coding “if this happens, do that” logic. If you want to change or add new signals, you have to write more code, update the signals, and redeploy the app.

Django Action Triggers builds on that concept, but with more flexibility. Instead of hard-coding signals, this library allows you to manage signals dynamically via the UI or API. You can set up, modify, or remove triggers without touching the codebase or redeploying. This makes it easier for teams to iterate and adjust workflows on the fly.
Additionally, it includes built-in integrations with services like AWS SNS, Kafka, RabbitMQ, and Redis—so you don’t need to reinvent the wheel every time you want to connect to an external service or message broker.
Additional Information

100% test coverage
Highly compatible with different versions of Python and Django. This is my test matrix:

strategy:
      matrix:
        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
        django-version: [32, 42, 51]
        db: [postgres, mysql, sqlite]
        broker: [rabbitmq, kafka, redis, aws_sqs, aws_sns]
        exclude:
          # Django 5.1 does not support Python <3.10
          - python-version: "3.8"
            django-version: 51
          - python-version: "3.9"
            django-version: 51

Detailed README
Extensive documentation: https://salaah01.github.io/django-action-triggers/
Nothing out there seems to offer the ability to manage signals at runtime.
Can easily integrate with the following services:

Kafka
RabbitMQ
Redis
AWS SQS (Amazon Simple Queue Service)
AWS SNS (Amazon Simple Notification Service)

Continuously adding more integration - In the pipeline, I am planning to add the following:

AWS Lambda integration
Google Clouds Function Integration
Google PubSub Integration

This is pretty cool, but I haven't quite wrapped my head around it. Are there any blog posts or videos that step through it?


Update fraise to 3.7.7

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

I would appreciate if homebrew would follow @abentele and use his fork of Fraise.
The original Fraise hasn't been updated since 2013 and is incompatible with MacOS Sierra.

@StephenKing: thanks for supporting my request!
The author of the original Fraise has definitely discontinued maintenance years ago. I've started to maintain Fraise in 2016 to support MacOS Sierra and add some improvements and bug fixes, and I will continue to maintain it in future.
There are already a few people who tell me that they are very happy with my current release. I hope updating the cask will distribute the release to more people.
Thanks!

That’s all well and good, but you have to realise we’ll not just start imposing specific versions of forks on users. It has 16 stars, so it isn’t even that popular, there’s no reason to make this the default. The token reference is clear.
If you want this added, add it as a new cask as abentele-fraise.
Alternatively, you can change your fork to have a differently named app and submit it as that.

Ah, one other way. You may also get the original developer to officially say the app was discontinued and linking to your fork. With that official endorsement, your fork would become the official cask.

Thanks for fast response.
But it's not that simple: the current maintainer already said that he discontinued the project (sorry, but I don't find the source of this information any more), but doesn't respond to my mails: I already asked him to officially say that he discontinued his project. But it's ovious that there will be no new release from the original maintainer. He even doesn't respond to comments on issues in his repository.
It simply doesn't make sense for me to have a cask definition for an about seven years old software release that isn't working with the current macOS release.
And I don't want to publish it with a name like abentele-fraise. I want to publish it as "fraise".
For this and other reasons (e.g. there are many software update sites in the internet that publish the old Fraise 3.7.3), I think about renaming the software. But until that is done, I would appreciate if you publish my updated release.

It simply doesn't make sense for me to have a cask definition for an about seven years old software release that isn't working with the current macOS release.

That is already being addressed.

And I don't want to publish it with a name like abentele-fraise. I want to publish it as "fraise".

Respectfully, that is your problem, not ours. This project is for all users, not your personal preferences. You don’t get to decide on your own to take ownership of the cask. We have rules for a reason. Even if the original app is discontinued, it still is more well-known than your fork (going by number of stars). Your fork is also relatively unknown (again, judging by number of stars). It’s fair to assume users will want a fork, but assuming they’ll want your fork is not.
Again, we don’t impose choices on users and won’t trick them into something they are not expecting.

But until that is done, I would appreciate if you publish my updated release.

Submit it with the requested changes, and it’ll be accepted. Otherwise it won’t.

Thanks for the discussion. I completely understand your principles. I think it's really important to have such rules for a software like this.
As I said, it makes more sense to first rename the software (because it's not only a conflict in this case...), and then come back with the request to add a completely new cask.

Thanks for the discussion. I completely understand your principles. I think it's really important to have such rules for a software like this.

Thank you as well, and for understanding.

it makes more sense to first rename the software (…), and then come back with the request to add a completely new cask.

As you prefer. Looking forward to the contribution when it’s time.


We are getting bad closes on syncRetry

Take a look here specifically at the 8-10 09:50:24.741 entry where we are getting Error!: Not Running exceptions. This is a close call on a socket that is already closed. This shouldn't happen. It means our state model is broken since we should know if the socket is already closed.

@yaronyg is this a fix to be bolted onto story 0 or moved to story 00?

Let's figure out what the fix is. The important part is NOT the throw/catch. The important part is that there is something fundamentally wrong with how we are managing connections because we shouldn't have gotten that error in the first place.

As a side note, if you look at the log it seems like the real issue is that we got a Bluetooth error and we aren't handling it correctly. It's sort of an existence proof that our testing isn't modeling how connection failure actually happens. So I personally wouldn't sleep well until we can recreate this bug in a test and only THEN "fix" it.

@mattpodwysocki - Does this bug still exist?

@yaronyg this error is not actually Cordova nor the native layer, but the node.js/JXcore layer that is throwing this error.   And not as far as I know does it exist.

So can we close the bug?

@yaronyg yes, let's close this


Support add images

I would also like this functionality

It's very important for me too.

I would also like this functionality

I would also like to put images into cells.  Great work on this node module!

@guyonroche what are your approximate plans on this feature?
Just found this example generated by another library – it might work as a source for inspiration:
http://excelbuilderjs.com/cookbook/insertingPictures.html

UPD: The above links don’t work any more as the project is no longer maintained. See stephenliberty/excel-builder.js for details :–)

@lgaticaq do you think this can be closed now?

yes @kachkaev


Add Storybook stories for every component

create a story for <Dropdown/> and <DropdownMenu/> components.

Added a story to <DropdownMenu/> since <Dropdown/> is useless without other components.


Signed setup files

Version
0.4.1
Description
Greg stated again, that he would like to see setup files to distribute. He says, that signed setup files are state of the art and should have enough security to distribute.
Pulling in @greg-szabo

How Tor did it:
https://blog.torproject.org/deterministic-builds-part-two-technical-details

Windows

Two Types

Standard
EV (Extended Validation) takes longer, costs more, required for hardware products

Distributed on USB (globalsign.com link)
Location Required (globalsign.com link)
Timestamp from here required (globalsign.com link)
Can be bought from anyone listed here (microsoft.com link)

Mac

Need Apple Developer Certificate
Electron Signing (electron-userland/electron-osx-sign link)

Electron

Electron Docs (electron.build link)
Windows Installer (electron/windows-installer link)
Mac Electron Installer (mongodb-js/electron-installer-dmg link)

Tutorial (christianengvall.se link)
Unable to sign (issue link)

Uses squirrel for auto-updates and signing certs (github.com/Squirre mac, github.com/Squirre windows)

Windows needs to be run from a windows machine or VM

Auto-deploy tutorials

pracucci.com link
medium.com/heresy-dev link

Packing Tutorial (medium.com/how-to-electron link)

Electron Builder (electron-userland/electron-builder link
Electron Packer (electron-userland/electron-packager link)

Other Links

Deterministic build that Tor uses (devrandom/gitian-builder link)

Nice writeup. Thank you.

Hurdles:

We need to sign the mac app on an OSX machine.
We need to sign the windows app on wine or a windows machine.
Mac would have the developer account that needs to be made by a cosmos/tendermint admin and then the private key would need to be managed somehow.
Basically the same would need to happen for windows, but they would be managing the private key on a USB stick.

It looks like there are two separate problems to solve here:

making a deterministic installer
signing the installer

There's a lot of information in this issue about signing so I've created https://github.com/cosmos/voyager/issues/969 for the deterministic installer.

Wait for decision on outsourcing

We do not longer aim to ship an installable application.


Callback for file rejection

Maybe it will be nice to have a attribute like ngf-file-reject='fileReject(file, evt)' to enable user to deal with the file rejection.
Now I am using $watch and ngf-model-rejected to handle the rejection, but I have to find the exact reason for rejection every time.
I know in current implementation ngfChange will be invoked when file is rejected, but it seems that neither rejection info nor error logs was passed to the ngfChange.

+1

+1

Reading through the source code, there's an inner attribute $rejectedFiles which can be used to track rejected files.
ngf-change="myController.upload($files, $rejectedFiles)"

+1

Since version 5.1.0 you can see the rejection reason with file.$error.


chore: bump flutter required version to 3.10.1

@marfavi a new Flutter version is available. 3.10.2, do you want to bump this instead?


Obtaining my own critic data

First of all congratulations on the impressive work!
I am looking to extend SELF_RAG for long context tasks and planning to create my own training data. I had 3 questions about obtaining my own critic data.

What is the input file? Are the inputs obtained from the tasks themselves?
How do we create the jsonl for the input files? Where do we get those parameters from? (There is no README in process_data as mentioned here data_creation/critic/gpt4_reward/README.md). Does each critic data need a separate input file?
Once I have obtained the critic data for each of the four tokens, how do I combine them into one file for training the critic model?

YES! There is no README in process_data as mentioned here data_creation/critic/gpt4_reward/README.md

Hi, thank you so much for opening an issue! Sorry that the README is not really easy-to-follow.
I addressed some questions briefly here and try to improve the documentation in the coming weeks.


Exceptions with handlers are replaced in a background task

When a background task raises an exception that has a FastAPI handler, that exception is replaced by FastAPI and the original error cannot be found in the server logs. This makes debugging and investigations incredibly hard as it's impossible to know where the error occurred.
FastAPI should preserve the original exception so that it can be logged and investigated server-side.
Example
from fastapi import FastAPI, Request, BackgroundTasks
from fastapi.responses import JSONResponse

class UnicornException(Exception):
    def __init__(self, name: str):
        self.name = name

app = FastAPI()

@app.exception_handler(UnicornException)
async def unicorn_exception_handler(request: Request, exc: UnicornException):
    return JSONResponse(
        status_code=418,
        content={"message": f"Oops! {exc.name} did something. There goes a rainbow..."},
    )

async def process_unicorn(name: str):
    if name == "yolo":
        raise UnicornException(name=name)
    # else do_something(name)

@app.get("/unicorns/{name}")
async def sync_process_unicorn(name: str, background_tasks: BackgroundTasks):
    await process_unicorn(name)
    return name

@app.get("/unicorns_async/{name}")
async def async_process_unicorn(name: str, background_tasks: BackgroundTasks):
    """Accept the unicorn and process it in the background"""
    background_tasks.add_task(process_unicorn, name=name)
    return f"Processing {name} asynchronously."

Description

/unicorns/yolo correctly returns an error response
/unicorns_async/yolo returns the correct response to the client. I expect error logs and traceback of a UnicornException on the server. However, that exception is replaced with one that FastAPI generates, without context.

INFO:     <IP_ADDRESS>:32848 - "GET /unicorns_async/yolo HTTP/1.1" 200 OK
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/home/luyao/.local/lib/python3.8/site-packages/uvicorn/protocols/http/h11_impl.py", line 394, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File "/home/luyao/.local/lib/python3.8/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in __call__
    return await self.app(scope, receive, send)
  File "/home/luyao/.local/lib/python3.8/site-packages/fastapi/applications.py", line 190, in __call__
    await super().__call__(scope, receive, send)
  File "/home/luyao/.local/lib/python3.8/site-packages/starlette/applications.py", line 111, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/luyao/.local/lib/python3.8/site-packages/starlette/middleware/errors.py", line 181, in __call__
    raise exc from None
  File "/home/luyao/.local/lib/python3.8/site-packages/starlette/middleware/errors.py", line 159, in __call__
    await self.app(scope, receive, _send)
  File "/home/luyao/.local/lib/python3.8/site-packages/starlette/exceptions.py", line 86, in __call__
    raise RuntimeError(msg) from exc
RuntimeError: Caught handled exception, but response already started.

Environment

OS: Linux (Ubuntu 20.10)
FastAPI Version: 0.62.0
Python version: occurs on both 3.8.6 and 3.7.9

I don't see the question. :thinking:
A BackgroundTask runs after the successful response is sent. You should not have HTTPExceptions there.

I don't see the question. thinking
A BackgroundTask runs after the successful response is sent. You should not have HTTPExceptions there.

It's not specifically a HTTPException, it's a custom exception with registered handler. This allow us to for example do somethings like raise UnicornExistsError in the business logic parts of the application, regardless of how API routing works.
At the same time, I think it also makes sense to handle UnicornExistsError in the router, as opposed to write something like this in every single route:
try:
   await do_something(...)
except UnicornExistsError as e:
   raise HTTPException(process_exception(e))
except UnicornMissingError as e:
   raise HTTPException(process_exception(e))

I agree that exceptions are not automatically handled in the background task, nor should it. What I'm asking for is that when such an exception occurs, FastAPI should not mask over it completely. I'll update the issue to make it clear.

That's not a FastAPI issue. To be honest, that's how it is designed. In case you want more clarification, that's more suitable in Starlette.
The code that makes those decisions is here.
In case you want to understand the reason for async bkg tasks: https://stackoverflow.com/questions/60287285/starlette-asyncio-create-task-doesnt-log-error-if-task-object-is-stored-in
For sync the reason is even clearer, as it runs in a different thread.

Hmm, you're right that it seems to be an issue with Starlette. I'll open an issue there instead.
I don't think this particular issue has to do with forgetting to await the result or threading though. The exception is clearly there - in fact, if I go to the code quoted in the traceback and insert print(exc) before the raise, it literally prints out the exact exception that the application has raised. So the original exception is available in the context; it's just being replaced with a less helpful error instead of surfaced through the logs.

You're right. My bad. :sweat:
But well, still looks a conscious decision:
            if handler is None:
                handler = self._lookup_exception_handler(exc)

But asking clarifications about it seems a good idea. :+1:

@snazzyfox Did you ever open an issue in Starlette? I could not find anything.
Also, thank you for this thread! It did help a lot with my problem.

@snazzyfox @johachi How did you overcome this error? I still couldn't get HTTP errors defined in the background task function.

@Matthieu-Tinycoaching
I needed a message broker (e.g. Rabbit MQ) to send events to other services. I solved this problem by also using the messaging broker to trigger these events async without using BackGroundTasks. However, that will probably be overkill to solve only this problem.
There is also a good blog post here on how to mitigate this problem (I'm the author) as well as this library that can also solve this problem for you.


Add chains of transforms

Description
This PR follows on from #1018 and #885 and the work of @jni and @GenevieveBuckley by adding support for a ChainTransform (first described in #885) and consolidating our current 3 types of transform - view2data, data2world, and world2grid inside it.
This PR is not designed to change any functionality, but makes it easier to chain our transforms together. We still have to think about what does it look like when a user wants to provide many transforms of mixed types etc as described in #1016, this PR is only a small step in that direction.
The next step after this will be to introduce the concept of a world coordinate system that our dims sliders obey too.
Would love your feedback @GenevieveBuckley @jni and others
Type of change

[x] Refactor (non-breaking change which fixes an issue)

How has this been tested?

[x] adds napari/layers/_tests/test_transform_chain.py

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works

@GenevieveBuckley @jni this has now been updated with all the requested changes and is ready for re-review. Once merged I will update #1053 and we can press on fixing all the pyramid stuff, at which point I think things will be much cleaner :-) Thanks both for all your help on this!!

Merging now, very excited to get this in, thanks for all the help @GenevieveBuckley @jni! Will merge this into #1053 and then press on with things there


"Open Links in New Window" option

Could you add this option to the script?
(Not adding the “_blank” tag but unobtrusive and that validates in XHTML 1 strict, like window.open )
Thanks!

Ok I understand.
Yes I will use example 6.
Thanks
Michael


add support for prometheus metrics

Somehow, I missed the notification about your PR. I can definitely accept IT, but chart development moved on https://github.com/jitsi-contrib/jitsi-helm, could you target you PR here ?

Will do.

I opened a PR in the helm repo: https://github.com/jitsi-contrib/jitsi-helm/pull/6


Network v2 requires you to subscribe to the CSR1000V instance

This isn't clearly documented and throws an error during the first attempt at running the playbook
TASK [manage_ec2_instances : Create EC2 instances for rtr1 node (NETWORKING MODE)] ************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Instance creation failed => OptInRequired: In order to use this AWS Marketplace product you need to accept terms and subscribe. To do so please visit https://aws.amazon.com/marketplace/pp?sku=5tiyrfb5tasxk9gmnab39b843"}

Current Marketplace URL

https://aws.amazon.com/marketplace/pp/B00NF48FI2/

This should be noted in the documentation or in the FAQ

Hey @steven-ellis sucks you are so far away on time zones, hopefully this fixes the issue for you, thanks for opening!!  This kind of information is super helpful.  Fixed with https://github.com/network-automation/linklight/tree/master/provisioner

meant: https://github.com/network-automation/linklight/commit/10fa1b3e68516e61f87baa5846c9053fc043de0b


Request level vars don't update it's value after set first value while read from .bru file on app load

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
I use template for many requests (~ 2.6k) and setting up each request, if it have specific settings. But majority setting work automatically via JS.
Settings like endpoint url. On screenshots example how i change url by change "findOneId" var. After update on 1.20 version, request level var's stop updating it's value when change values in 'vars' tab.
On screenshot 1 have see that initial var's value work correctly.
Then i change value by adding query params. (No difference how change the var, result is same) And request sends with old initial value. Also sent var's value into console.
Also, at now no way to change request level vars, like bru.setRequestVar('name', value).
.bru file to reproduce the bug
No response
Screenshots/Live demo link

This new behavior is indeed very irritating: Newly created variables can be changed and the current value is always used. However, as soon as the configuration is saved, only the content of the bru file is decisive and changes in the GUI are no longer taken into account.

Yep, have many saved request and not want change it. But sometimes need quick check something based on already exist request. Before 1.20 version i "broke" existing request, check what i need and close request without saving. It was quite convenient.

1.26 now works fine


@produck/charon: add array namespace.

Array native static
extend Array.empty, Array.isEmpty

Array.isArray function same as  Type.isArray, should determinet which one is implementation and which one is alias.


Remove secondary nav

Important

can be only merged after: https://github.com/RedHatInsights/insights-chrome/pull/175
Please someone go through all the links in App. There substantiation changes in routing and paths and i would like if someone could double check that it all works properly

Changes

removes secondary navigation
updates routes

routes are now divided into sub sections based on root components
the are new 3 main masks and every route must match its parent
root routes

/portfolios
/platforms
/orders

slight update in styling for card, will continue in separate PRs

Codecov Report

Merging #109 into master will increase coverage by 0.88%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   44.88%   45.77%   +0.88%
==========================================
  Files          61       60       -1
  Lines         528      509      -19
  Branches       36       33       -3
==========================================
- Hits          237      233       -4
+ Misses        271      258      -13
+ Partials       20       18       -2

Impacted Files
Coverage Δ

src/SmartComponents/Portfolio/PortfolioItem.js
0% <ø> (ø)
:arrow_up:

src/Routes.js
0% <ø> (ø)
:arrow_up:

...PresentationalComponents/Portfolio/PorfolioCard.js
0% <0%> (ø)
:arrow_up:

src/SmartComponents/Portfolio/Portfolio.js
0% <0%> (ø)
:arrow_up:

...nalComponents/Portfolio/PortfoliosFilterToolbar.js
0% <0%> (ø)
:arrow_up:

src/App.js
0% <0%> (ø)
:arrow_up:

src/SmartComponents/Portfolio/Portfolios.js
0% <0%> (ø)
:arrow_up:

...martComponents/Portfolio/AddProductsToPortfolio.js
0% <0%> (ø)
:arrow_up:

.../PresentationalComponents/Platform/PlatformCard.js
100% <100%> (ø)
:arrow_up:

...c/SmartComponents/ContentGallery/ContentGallery.js
100% <100%> (ø)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28de003...9be95e2. Read the comment docs.


generate the data files

can't find the file  gen-examples in  deepcoder/scripts

Forgot to commit that script- should run now

thx，you help me a lot！
well, another question i want to ask is that when i run the solve-problems procedure following  your steps in the README file, i just get one or tow problems solved.
                        Soldier Icesun

<EMAIL_ADDRESS>
Signature is customized by Netease Mail Master
On 07/06/2018 10:44, dkamm wrote: Forgot to commit that script- should run now
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dkamm/deepcoder","title":"dkamm/deepcoder","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/dkamm/deepcoder"}},"updates":{"snippets":[{"icon":"PERSON","message":"@dkamm in #8: Forgot to commit that script- should run now"}],"action":{"name":"View Issue","url":"https://github.com/dkamm/deepcoder/issues/8#issuecomment-402909241"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dkamm/deepcoder/issues/8#issuecomment-402909241",
"url": "https://github.com/dkamm/deepcoder/issues/8#issuecomment-402909241",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [dkamm/deepcoder] generate the data files (#8)",
"sections": [
{
"text": "",
"activityTitle": "dkamm",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@dkamm",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "dkamm/deepcoder",\n"issueId": 8,\n"IssueComment": "{{IssueComment.value}}"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/dkamm/deepcoder/issues/8#issuecomment-402909241"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "MuteNotification",\n"threadId": 352424160\n}"
}
],
"themeColor": "26292E"
}
]

oh， the dataset i used  was downloaded from the site in the readme file. maybe that is the difference. so, could you please give me a copy of your dataset? Thanks a lot!
                        Soldier Icesun

<EMAIL_ADDRESS>
Signature is customized by Netease Mail Master
On 07/09/2018 10:24, Soldier Icesun wrote: This picture is my result.  That' s so strange, i didn't modify any files.2018-07-09 9:25 GMT+08:00 dkamm notifications@github.com:Are you referring to step 3?  I ran it just now and it gave the same results for me.  Are you by chance using a different command or data file?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

Apologies for the delay!  I can confirm that I used the same link in the readme (https://storage.googleapis.com/deepcoder/dataset.tar.gz) and it worked for me.
I'm having trouble viewing the image you attached.  Can you perhaps try uploading it again?


french - corrected grammar/spelling

#26
fr
datetime & text : corrected minor grammar/spelling errors
personal : corrected occupations titles (& fixed the ones that were broken in multiple lines) + deleted the duplicates

@jeromechrist Thank you very much!


Fix : field validation and projects and chart repo fields

Description

Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

[x] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

https://github.com/devtron-labs/devtron/issues/3475


Conflict between Entrust::save() and Ardent::save()

I am using the latest Ardent version with entrust 5.2.x-dev on Laravel 5.2 framework
Entrust with Laravel Ardent is having a conflict and the following error message is displayed:
Declaration of Zizaco\Entrust\Traits\EntrustUserTrait::save() should be compatible with LaravelArdent\Ardent\Ardent::save(array $rules = Array, array $customMessages = Array, array $options = Array, Closure $beforeSave = NULL, Closure $afterSave = NULL)
Kindly provide a fix for this issue.

Sorry, have you tried opening this issue on THEIR side? As the message
clearly states, their declaration extending our code is incompatible. I'm
not sure I should change an important method signature just because of this.
Try downgrading, their last release might be faulty.
Igor Santos
-- Desenvolvedor Web
[enviado do meu celular]
On 14 Apr 2016 08:03, "george1974"<EMAIL_ADDRESS>wrote:

I am using the latest Ardent version with entrust 5.2.x-dev on Laravel 5.2
framework
Entrust with Laravel Ardent is having a conflict and the following error
message is displayed:
Declaration of Zizaco\Entrust\Traits\EntrustUserTrait::save() should be
compatible with LaravelArdent\Ardent\Ardent::save(array $rules = Array,
array $customMessages = Array, array $options = Array, Closure $beforeSave
= NULL, Closure $afterSave = NULL)
Kindly provide a fix for this issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/laravel-ardent/ardent/issues/296

I tried opening this issue on their side but no response. Not sure if there exists any other solution before making a localized change in either code at my end.

Have you tried downgrading?
Was that motivated by an update you made or is it just your first install
of Entrust?
Igor Santos
-- Desenvolvedor Web
[enviado do meu celular]
On 16 Apr 2016 05:37, "george1974"<EMAIL_ADDRESS>wrote:

I tried opening this issue on their side but no response. Not sure if
there exists any other solution before making a localized change in either
code at my end.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/laravel-ardent/ardent/issues/296#issuecomment-210770692

I tried opening this issue on their side but no response. Not sure if there exists any other solution before making a localized change in either code at my end.


Admin Dashboard is not showing icons related to font-awesome

Once, I installed the gem, and tried to open the admin dashboard, all of the icons are missed.
I tried to add this line manually in
<link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css" rel="stylesheet"> in camaleon_cms-<IP_ADDRESS>/app/views/layouts/camaleon_cms/admin.html.erb
So do you have any idea about fixing the issue? or should I open a PR to merge the fix I added?

@salmagomaa it is strange, I tested the last version and it worked well for me.
Could you please review if your site is loading "http://localhost:3002/assets/fontawesome-webfont-....woff2" ?
Cheers!