My Team's Requests Queue - Unable to Search by Team Name

Describe the bug in current situation
When in the 'My Team's Requests' queue, you are unable to search for team names, under the 'Assigned To' column, when using the search bar.
Link bug to the User Story
Impact of this bug
Low
Chance of Occurring (high/medium/low/very low)
High
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

As an IAO or ministry user, go the 'My Team's Requests' queue
Confirm there is >=1 request that is assigned to a team (rather than an individual)
In the search bar, enter the team name, or a portion of the team name
The results will not include the team names matching your search criteria

Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
GIVEN a user is on the 'My Team's Requests' queue
AND there is >=1 request assigned to a team
WHEN the user searches for the team name
THEN all the requests assigned to the team (name) will be displayed
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

No results searching by team

No results for 'Flex Team'. Only Foiflex, which is a user.

cc: @m-prodan @liseandtea @lmullane

Thanks Kyle - looks good to me


Send dynamic data in response using agent.add()

Hello All,
Is it possible to send dynamic data with response which we got that from backend api ? There are cases where we need to send real time data to dialogflow agent ( in turn to client) by calling a API . I tried below code to implement this but seems like not working , here " value" is the data that we are getting from api response and the same has been parsed / navigated to extract value.
agent.add(stock price is  + JSON.parse(value).IRXML.StockQuotes.Stock_Quote[0].Trade)
Prior above code execution , i'm making a synchronous external API call using promotion so that the result is replaced in the agent.add section.
At present, i'm not able to execute agent.add function inside promotion then  function. Could you please assist me here.
Let me know for more information required.
Thanks,
Karthik

You'll need to wrap your async call in a promise and return the promise in the handler function as seen in this example: https://github.com/dialogflow/fulfillment-bike-shop-nodejs/blob/master/functions/index.js#L61
If you don't return a promise in the handler function the function will return without having added any responses.


Build list needs bottom padding

The "saved build" list on the right needs some padding between that and tree comparison.  Right now if you have enough builds the tree comparison button will be on top of the bottom build.

Thx for the report. This is fixed and will be in the next release.


Rename TokamakCLI executable to plain tokamak

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   57.95%   57.95%
=======================================
  Files          66       66
  Lines        1446     1446
=======================================
  Hits          838      838
  Misses        608      608

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1f2d9...e706f9a. Read the comment docs.


fix: fix occasional e2e failure

Fixes #N/A
Description
When I run make e2etests, one failure is: https://github.com/kubernetes-sigs/karpenter/actions/runs/10590933040/job/29347492851
The context is as follows:
nodeclaim:

corresponding node:

So this PR tries to re-enqueue the item.
How was this change tested?
It always has failure if you try about 8 times, and I tried 20+ times, the following failure disappear
 [FAIL] Performance Provisioning [It] should do complex provisioning and complex drift
  /home/runner/work/karpenter/karpenter/test/suites/perf/scheduling_test.go:134

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

By the way, should we re-enqueue the item if an unexpected error happens, like a broken Internet connection?
For example, the following code:
https://github.com/kubernetes-sigs/karpenter/blob/14f12dd82b6c8dfc9bff634df0527ae718faa748/pkg/controllers/nodeclaim/lifecycle/registration.go#L59
I prefer to re-enqueue them, make the logic robust

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 80.753%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/disruption/consolidation.go
4
87.25%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
8391

Relevant Lines:
10391

💛  - Coveralls


task semantics rebuild behavior

The current behavior of input/target combination feels a bit odd, which could lead to suprises for new users.
Current Implementation
1) rebuild on input change
  build:
    input: *
    cmd: go build -o run
    target: run

2) no input =>  will only build once
  build:
    cmd: go build -o run
    target: run

3) no input, no target => will only build once (creates a target not known to bob)
  build:
    cmd: go build -o run

4) no input, no target => will only build once
  build:
    cmd: echo Hello World

5) no target => rebuild on input change
  build:
    input: *
    cmd: echo Hello World

6) rebuild when dependecy changed (the task does nothing)
  build:
    dependOn: [ generated ]

7) rebuild when dependency or input changed (the task does nothing)
  build:
    input: *
    dependOn: [ generated ]

Changing the default value for input to be *

rebuild on input change
rebuild on input change
rebuild on input change (creates a target not known to bob which is problematic)
rebuild on input change
rebuild on input change
rebuild on input change & dependency change
rebuild on input change & dependency change

Taking target into account

Default value for input to be *
Assuming tasks without targets as PHONY ( this must be explicitly declared in Makefiles, but here it's possible to detect this case)
Tasks without a cmd: are not allowed to have target: or input: defined

rebuild on input change
rebuild on input change
always rebuild (task with input but without a target is invalid)
always rebuild
invalid task (input without target)
Never build ( only dependencies)
Invalid task (input, target without command)

Appendix
Case 3) could be detected by a bob verifytaskintegrity (please use a better command name) which would build tasks  one by one and track filesystem & docker registry changes. At the end it prints some target suggestion for specific tasks. This could also be helpful when migrating from other build systems or adding docker builds. In that cases targets usually are hidden deep down in the build instruction (e.g. Dockerfile)

Suggestion for task name bob verify and then add what you want to verify  tasks --> bob verify tasks.
In my opinion bob should act this way: Whenever bob can't verify it input or target is changed it should build. Probably this would result in default rebuild: always if input and target are unset.

rebuild on input change
always rebuild
always rebuild
always rebuild
rebuild on input change

We could also take dependencies into account.
5) no input, no target, with dependency
  build:
    cmd: echo Hello World
    dependsOn: otherTask

build whenever dependency was build

I think we should try to mimic the make behavior "PHONY" tasks of rebuilding as often as possible.
For tasks that can not be cached I suggest we add that information to the console summary at the end of bob build. That helps the user to identify possible optimizations.
Besides taking the presence of input and target into account I want to make explicit that the absence of the target file or no files in the target folder qualifies as reason to rebuild.
I suggest to following behavior:

rebuild on input change
always rebuild
always rebuild
always rebuild
always rebuild
rebuild on dep change
always rebuild

About 5 and 7:
I argue that if you don't know if the target is still present or if it was deleted or changed then you should always rebuild. In the current implementation failures are hard to debug. Bob says "cached" which is not true since if bob was asked to show the "cached" files it would have no answer. IF it was to stay the current way, bob should at least change the information in the summary to something like "not-rebuild".
Further, a call of bob clean targets should let ALL tasks rebuild. In the current implementation there is no way to trigger a rebuild of case 5) without changing the input.

Bob is a simpler Bazel alternative for multi-language projects of any size.
It's simpler then Bazel as it allows to build targets/outputs directly in the repository.
With that in mind let's go one step back and bring this down to the physics to answer the following questions.

What default behavior of inputs is desirable?
When to define targets?

Analysis
We have to deal with three kind of tasks:

(A) Tasks which analyze a Codebase. [lint, security checks]
(B) Tasks which alter a Codebase. [lint --fix, go fmt, go tidy]
(C) Tasks which create binaries, code or files which could also be consumed/used by one or more other tasks. [go build]

A (Verify/Analyze a Codebase)
Impacted Scenarios: 4) 5)
A task which analyzes a codebase needs inputs in some cases to avoid unnecessary executions.
Linting can be an expensive operation, and avoiding task execution can be beneficial.
lint:
 input: ui/**/*.ts
 cmd: npm run lint

B (Alter a Codebase)
Impacted Scenarios: 1) 4) 5)
A task altering a codebase needs inputs & outputs.
The case of fmt and lint
For something like go fmt or lint --fix the input & output are the same files.
fmt:
  input: */**/*.go
  cmd: go fmt ./…
  target: */**/*.go # Which is not possible.

Defining those kind of targets is tedious and maybe even unnecessary as those are changes which are best  transported through a repository/git and NOT through an shared artifact cache.
Though it can be useful in a pipeline to assure code quality standards like formatting. This can usually be done by using a task like this test -z $(go fmt ./…)
The case of go mod tidy
Let's also look at go mod tidy which could also be interpreted as a task which should be done manually. But due to its nature of only changing two files it is tempting to define go.mod & go.sum as targets.
gomodtidy:
  input: */**/*.go
  cmd: go mod tidy
  target: |
    go.mod
    go.sum

It modifies go.mod and go.sum up to the current state defined in the sources and download dependency to a local cache directory which is not located in the repository. It is usually used to bring the system into a state on which it is possible to build the project. Therefore it's beneficial to have it in a build graph. Hint: For this to succeed all code must be available.
Here is a discussion on go mod tidy when used in bazel, https://github.com/bazelbuild/rules_go/issues/2262
C (Create)
Impacted Scenarios: 1)
These tasks are actually doing the main work and they require inputs and outputs and usually they also depend on other tasks to span the build-graph.
worker:
  input: */**/*.go
  cmd: go build -o run
  target: run
  dependsOn:

Conclusions
Why should we enforce the default input be empty and a rebuild policy of "No Input Never Built"?

Better performance due to less inputs.
Smart builds are very crucial on big repositories. With that in mind Bob should enforce the definition of inputs whenever we can and provide help through future tooling & verification (of a bob.yaml) as good as it's possible.
The initial idea of using "*"(which is not implemented) as an input was to force people to think about rebuild behavior. This can be better achieved by forcing users to provide inputs (No Input Never Built) and allow to opt out using rebuild: always
Removing rebuild: always in favor of another type of task can be subject of a future discussion.

Can a plugin system make the life of users easier (e.g. thinking less about inputs)?
I guess so. Lot of input, targets or combinations of both are task specific and can be reused.
What kind of tasks need NO targets?
Tasks which outputs are transported through the repository like go fmt or npm lint --fix.
Files which are put on a .gitignore like binaries or node_modules.
When advising users to do thing like go fmt ./... outside of the build tree. How to assure the sane go version as in the bob.yaml?
As already suggested by @dketterer a nice solution would be to spawn a shell into the environment of a task, similar to what nix-shell does.
@dketterer

Further, a call of bob clean targets should let ALL tasks rebuild. In the current implementation there is no way to trigger a rebuild of case 5) without changing the input.

Use bob clean system to  trigger a rebuild. Maybe a better solution would be a command like bob clean . to only remove  buildinfo from the current project.
@puengel  I can't think of any real world scenario. Would be nice to find one. Otherwise i tend to ignore that case to reduce possible scenarios.

no input, no target, with dependency
build:
cmd: echo Hello World
dependsOn: otherTask

Behavior based on those changes:
1: rebuild on input change (or invalidated target).
2: error, no input provided!
3: error, no input provided!
3: error, no input provided!
4: error, no input provided!
5: rebuild on input change => As @dketterer  change summary to "not-rebuild" instead of "cached".
6: Never build ( only dependencies). Usually a sum task or main entry point.
7: Invalid task (input, target without command)
This hopefully removes some confusion as there are less valid cases which must be considered.
Appendix
Why do input & target exist in Bob?
input: Skip the task
target: Share / Performance (Bob Internal)
Inner working
Before doing any work Bob builds an internal view of the repository based on inputs & output files. It does not yet read the contents of the files, though it removes outputs of child tasks from the current tasks inputs. Only when actually sending a task to the task queue the file content is read and input & target hashes are computed and compared which still has some potential for optimizations but runs already in parallel.

I have some comments that we already discussed:
About case 3/4/5:
Just to be explicit about it: They should not return errors if the rebuild: always flag is set.
Regard bob clean target or bob clean .:
I think it would be valuable to trigger the rebuild of all tasks in a bob.yaml be deleting all targets defined in it and their cache / cache status.
There is already an old issue (https://github.com/benchkram/bob/issues/73) with this topic which needs refinement since it was before the introduction of targets and system.

I agree with the above suggestion by @Equanox and the additional comment from @dketterer; cases where the user would get 'error: no input specified' should not return the mentioned error if the rebuild: always flag is set.
The tasks mentioned in case (6) are called "compound tasks" (per vscode & intellij's docs, for example) and I agree in that they should always just be a way to group tasks together.
Regarding the discussion we had today offline, I think we do not have to introduce a new task type, but just consider tasks with rebuild: always and their dependents as simple run tasks. Caching and incremental builds should be turned off for these and their dependents, and users will not have to resort to separate makefiles etc. if we treat them that way. This solution can also be quite robust, as a part of the DAG can use the incremental build system and the rest can just exist as a task runner. The run tasks we currently have were also modeled with this behavior, albeit with little integration with the actual build system part.
Additionally, for tasks with inputs and no targets, we should consider capturing stdout/stderr of them and storing that text as target. I'm thinking of a lint step where you ideally don't want to execute it multiple times for the same filetree, but in case of errors during lint you want these to continue showing up.


Issue 1 launguage order backend queries

Languages order preference UI and functionality enhancement.
Fixes #5826
What changes did you make and why?
Gradle Files:
Some fo the gradle code was outdated and didn't work on our latest emulators. I had to remove code that was no longer supported.
Preferences.XML:
Added a new preference category in the preferences UI for secondary language picking
Prefs.java was also changed to hold a serialised string of secondary language codes
Strings.XML:
Added new strings that represent additions in UI
SettingsFragments:

Had to accommodate new preference in OnCreate
Made a new dialog called prepareSecondaryLanguageDialog().
Made helper methods for that dialog that use a new language adapter SavedLanguagesAdapter
modified saving and getting key value methods to accommodate the new category in Prefs

NearbyController and NearbyPlaces:
Injected the KV store into the controller and passed the serialised string as a new argument to the json API client in NearbyPlaces
OkHttpJsonApiClient:
changed the getPlaces method to make use of the new parameter (the serialised language code)
made stringbuilders to automatically generate further SparQL queries based on the serialised code list
(Also modified the SparQL file itself to add placeholders for the additional strings created by the method)
Tests performed (required)
Apart from extensive manual software testing, the following unit tests were created:
StringBuilderTest.java
SettingsFragmentSecondaryLanguageTests.kt
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Ill work on name changes and the change in the res file is unintentional sorry about that...

Also, please rebase or merge from master. Thanks! :-)

@nicolas-raoul Ive squashed merge conflicts and resolved above points.

I am so sorry for leaving it for so long, would you mind this other conflict? Thanks a lot!

Ill look into it

@nicolas-raoul Sorry again for being late. Ill fix it today.

Hi @nicolas-raoul this is (@Adeeth101) im on my alt account because I'm on my phone.
A lot of the java classes I edited are now deleted and replaced kotlin versions. Not a huge deal but it does mean I basically cant auto merge and it will take some time to redo my work in kotlin. Give me another day please and thanks for the patience.

I made a new MR, which should now be good for the updated Kotlin version of the app.


add modeling tutorial notebooks

First draft of notebooks for modeling tutorial using LIS-SnowModel output and non-SnowEx data from SNOTEL and SNODAS.
Currently data doesn't seem to be accessible on the SnowEx JupyterHub. The bucket should have read access for the AWS role that Scott provided, but it's not currently working. I will reach out to Scott and Aaron Skolnik at NASA GSFC to see what I need to do to get the data open and accessible.

@scottyhq - sorry for the delay, but I just made those changes. I also made an index.md page for the modeling tutorial to be a starting page for the two notebooks

@scottyhq I think this is the final version of the modeling notebook. I see that it's failing the checks, but I'm not sure what I need to fix to resolve everything.

why the spellcheck is catching "te" in the code cells and causing an error? I would think that code inputs (here an argument name in a function definition) don't have to be "real" words?

not sure, codespell definitely still misses a lot and has some false positives! but it's easy to add to the ignored words list: https://github.com/snowex-hackweek/website2022/blob/4ae619ebc5c504c2d492b7fd9dcbb4e76b695352/.github/workflows/qaqc.yaml#L36

@mlwrzesien these notebooks and visualizations look great! The GitHub Actions CI checks do not have access to s3://eis-dh-hydro (thus the failing checks) so I think I will just commit rendered notebooks here and exclude them from executing in CI...

That sounds great, thanks @scottyhq! I appreciate your help with my tutorial, especially figuring out the data access!

hmm, i can't seem to find a way to copy rendered HTML pages over to jupyterbook, and the rendered notebooks are quite big with all the visualizations. So I'm going to directly commit the rendered HTML to the gh-pages branch and commit empty notebooks here. cc @jomey
jovyan@jupyter-scottyhq: website2022$ ls -lh book/_build/html/tutorials/modeling/
total 23M
-rw-r--r-- 1 jovyan jovyan  15M Jul  6 18:01 1_snowmodeling_tutorial.html
-rw-r--r-- 1 jovyan jovyan 8.0M Jul  6 18:01 2_snowmodeling_extra.html
-rw-r--r-- 1 jovyan jovyan  24K Jul  6 18:01 index.html

jovyan@jupyter-scottyhq: website2022$ ls -lh book/tutorials/modeling/*ipynb
-rw-r--r-- 1 jovyan jovyan 22M Jul  6 17:41 book/tutorials/modeling/1_snowmodeling_tutorial.ipynb
-rw-r--r-- 1 jovyan jovyan 16M Jul  6 17:40 book/tutorials/modeling/2_snowmodeling_extra.ipynb

@scottyhq - is it too late to make a few additional changes to the notebook? Just minor text updates. To do that, is it best to create a new branch and a new PR?

not too late, yes, just start a new branch off the most recent 'main' (git checkout main, git pull, git checkout -b modeling2)


Support for Tarantool?

Hi,
It would be awesome if you guys can add support for Tarantool.io which is a blazing fast database both disc and memory based.
It also supports SQL syntaxes which I want (if possible) you guys to implement in this project.
Heads up and keep up the good work !
Regards

I don't know about it. However if this product supported using PDO and executing SQL query, it can use with Medoo without additional implement. If not, there is nothing can do to for this.

There is not PDO instead there is a package called PHP client for Tarantool which is used to connect to Tarantool and can execute SQL queries.
@catfan would you mind to think about it? It would be appreciated.
Tarantool is blazing fast and has both in memory storage and in disk storage .
Here is the link to PHP client for Tarantool just in case you change your mind.
Regards

@zilveer Sorry, I don't understand what's your mean called support for this with Medoo. Medoo is only and always a PDO-based framework for connecting and manipulating SQL database.
Calling us to support for this, is calling the project to be reconstructed and be recreated. That's not make sense.

Thanks for your reply but I don't think that it needs to be in the way you describe, once you see that Tarantool works in the same way SQL behaves you will then understand that it wouldn't need any refactoring.
Regards


Doc: Fix typo in howto/storage_backup

Signed-off-by: Hiroaki Nakamura<EMAIL_ADDRESS>

This pull request didn't trigger Jenkins as its author isn't in the allow list.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.10821/


Test if bootstrap CSS works, and use it

Notes and warnings should be displayed as such.
Technical details should be in a specific style.

I was wondering if we could use the notes available in jupyterbook: https://jupyterbook.org/content/content-blocks.html#notes-warnings-and-other-admonitions
We can even have a custom style if I am not wrong (for technical notes for instance).
FYI in o'reilly books, you have three types of notes:

tips or suggestions;
general notes;
warning cautious.

Sorry ignore my previous comment, I forgot that we actually giving notebooks as a final support :)

By the way, on the topic on supporting MyST-specific syntax inside Jupyter notebook, there are some discussions
https://github.com/executablebooks/MyST-NB/issues/148#issuecomment-632407608 or https://discourse.jupyter.org/t/should-jupyter-recommend-a-text-based-representation-of-the-notebook/3273/22 but this is probably not going to happen very soon.
An approach that might be worth thinking about is something like this: https://github.com/executablebooks/MyST-NB/issues/148#issuecomment-632776843. Basically we try to be more clever in the generation of the notebook by detecting MyST-specific syntax and trying to render in a slightly better way when we generate the notebook.

As a side note, I added notes using the admonition feature from jupyter book. It is not a final choice but it already highlight some location where I thought having notes would be useful

admonition transform idea
import jupytext
nb = jupytext.read('python_scripts/python_scripts/linear_regression_non_linear_link.py')
nb['cells']

You get the list of cells then:

use myst_parser to figure out wich markdown cells have admonition
generate the HTML for the admonition with myst_parser.main.to_html (hmmm maybe an issue with rendering nested markdown inside the admonition see below)
replace the admonition with its HTML

my_str = """
```{warning}
In scikit-learn, by convention `X` should be a 2D matrix of shape
`(n_samples, n_features)`. If `X` is a 1D vector, you need to reshape it
into a matrix with a single column if the vector represents a feature or a
single row if the vector represents a sample.

"""
print(to_html(my_str))

The markdown inside the admonition has not been transformed to HTML ...

In scikit-learn, by convention `X` should be a 2D matrix of shape
`(n_samples, n_features)`. If `X` is a 1D vector, you need to reshape it
into a matrix with a single column if the vector represents a feature or a
single row if the vector represents a sample.

bootstrap idea

  danger

  warning

  info

seems to render fine in Jupyter notebook classic, JupyterLab and JupyterBook. With the bootstrap idea, you can only use HTML within the div and not markdown. Also the rendering is not going to be as nice as the JupyterBook admonition ...

The last suggestion seems to work well, doesn't it? I think that it's more than good enough.
Is there, in the variant of markdown that we are using, a short-hand for div+class? In some variants of markdown, the following works:
.alert.alert-danger [danger]

The main issue is that it looks less than great in the notebook (which means in FUN since people will be following the notebook in FUN). This is the same "Tip" admonition as previously as seen in the notebook:

Sorry, I was unclear, I had in mind the suggestion to use bootstrap CSS. @lesteve : is this what you are mentioning?

This makes it clearer indeed that you prefer boostrap CSS, I wasn't entirely sure which one was the "last suggestion".
I find it a bit annoying that we have to write full HTML inside admonitions in our .md files.
On the other hand, I haven't managed to put together a hakcy proof-of-concept to generate the HTML automatically. Also even generating the HTML we still woud need the JupyterBook CSS and adding CSS within a notebook without having a boiler plate code cell like the one below does not seem possible (from some googling):
from IPython.core.display import HTML
HTML("""

""")

HTML generated by JupyterBook for the admonition above (about random_state):

Tip

random_state parameter allows to get a deterministic results even if we
use some random process (i.e. data shuffling).

I'm not in favor of this boiler-plate.
Does the markdown syntax that I listed above work?

I could have guessed :wink:. I think we have to chose between:

bootstrap CSS with full-HTML inside admonition. Not great but maybe good enough ...
generating some degraded HTML for admonitions in the notebook e.g. something at the bottom of my previous post. This probably needs some work to make the idea work but at least we can keep using admonitions in our .md files ...

Your markdown syntax (I guess remark.js-like?) does not work in a notebook:
.alert.alert-danger [danger]

Hum...
If you think that 1. is viable, I'm happy to go with it.

It took a bit of time but I have a working solution for 2. I'll commit it this morning.

Great! Thanks!!


Archiving fails without sample names

with error:
{
  "timestamp":"2022-08-16T10:53:19.824+0000",
  "status":400,
  "error":"Bad Request",
  "message":"JSON parse error: Cannot construct instance of `uk.ac.ebi.biosamples.model.Sample`, problem: Sample name must be provided; nested exception is com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `uk.ac.ebi.biosamples.model.Sample`, problem: Sample name must be provided\\n at [Source: (PushbackInputStream); line: 1, column: 862]",
  "path":"/biosamples/samples"
}
JSON parse error: Cannot construct instance of `uk.ac.ebi.biosamples.model.Sample`,
problem: Sample name must be provided; nested exception is com.fasterxml.jackson.databind.exc.ValueInstantiationException:
Cannot construct instance of `uk.ac.ebi.biosamples.model.Sample`,
problem: Sample name must be provided

Solution: fallback to biomaterial_core.biomaterial_id?

PR: https://github.com/ebi-ait/ingest-archiver/pull/93

Approved

@MightyAx to test on staging and deploy to prod

dev biosamples was down so could not be tested, contacted Dipayan

biosamples dev is back staging test

biosamples dev is down again

Managed a test on staging and can confirm that sample names are no longer required


To list all new files since last watcher run

Hi,
Is watcher able to list all new files created since last watcher run ? We have a situation we are continuously watching a directory and if the watcher was stopped interrupted and resume again, are anyway to to list all new files creation in between or any alternatives ?
Thank you !

@tklew Your request is definitely out of scope. You should create this logic yourself.
There is no way to do it without external resources as a local file or a database.
There is a simple example which use a local file. It's not optimized and it don't cover events which can occur during an initialization. But it can be a good start for you :smiley:.
package main

import (
	"bufio"
	"fmt"
	"io/ioutil"
	"log"
	"os"
	"time"

	"github.com/radovskyb/watcher"
)

const dirNameExample = "directory"

type snapshot struct {
	DirName  string
	fileName string
	snapFile *os.File
}

func (sn *snapshot) Ensure() (files []os.FileInfo, err error) {
	sn.fileName = sn.DirName + "_snapshot"
	// TODO set your own permissions
	sn.snapFile, err = os.OpenFile(sn.fileName, os.O_CREATE|os.O_RDWR|os.O_APPEND, 0777)
	if err != nil {
		return
	}
	scanner := bufio.NewScanner(sn.snapFile)
	scanner.Split(bufio.ScanLines)

	snaps := map[string]struct{}{}

	for scanner.Scan() {
		snaps[scanner.Text()] = struct{}{}
	}

	if len(snaps) == 0 {
		// the snap file is empty
		return
	}

	currentFiles, err := ioutil.ReadDir(sn.DirName)
	if err != nil {
		return
	}
	for _, file := range currentFiles {
		if _, exist := snaps[file.Name()]; !exist {
			// a new file name doesn't exist in the snaps map
			files = append(files, file)
			// put the new file in the snap file
			err = sn.Snap(file.Name())
			if err != nil {
				return
			}
		}
	}

	return
}

func (sn *snapshot) Snap(fileName string) (err error) {
	_, err = sn.snapFile.WriteString(fileName + "\n")
	if err != nil {
		return
	}
	return
}

func (sn *snapshot) Close() {
	sn.snapFile.Close()
}

func main() {

	sn := snapshot{
		DirName: dirNameExample,
	}

	files, err := sn.Ensure()
	if err != nil {
		log.Fatalln(err)
	}
	defer sn.Close()

	for _, file := range files {
		println(file.Name())
	}

	w := watcher.New()

	go func() {
		var err error
		for {
			select {
			case event := <-w.Event:
				fmt.Println(event)

				// snap
				if event.Op == watcher.Create {
					err = sn.Snap(event.Name())
					if err != nil {
						log.Fatalln(err)
					}
				}

			case err := <-w.Error:
				log.Fatalln(err)
			case <-w.Closed:
				return
			}
		}
	}()

	// Watch this folder for changes.
	if err := w.Add(dirNameExample); err != nil {
		log.Fatalln(err)
	}
	// Start the watching process - it'll check for changes every 100ms.
	if err := w.Start(time.Millisecond * 100); err != nil {
		log.Fatalln(err)
	}
}

@radovskyb I think you can close the issue.


ssh-to-age: 1.1.4 -> 1.1.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Mic92/ssh-to-age/releases.
meta.description for ssh-to-age is: Convert ssh private keys in ed25519 format to age keys
meta.homepage for ssh-to-age is: https://github.com/Mic92/ssh-to-age
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.5 with grep in /nix/store/8xkaf3q5y7wqz4aplvngfcw7h0s27hcq-ssh-to-age-1.1.5
found 1.1.5 in filename of file in /nix/store/8xkaf3q5y7wqz4aplvngfcw7h0s27hcq-ssh-to-age-1.1.5

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
ssh-to-age

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8xkaf3q5y7wqz4aplvngfcw7h0s27hcq-ssh-to-age-1.1.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ssh-to-age https://github.com/r-ryantm/nixpkgs/archive/e7011961344285c3f5e9828ef6dd79f899901dc0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8xkaf3q5y7wqz4aplvngfcw7h0s27hcq-ssh-to-age-1.1.5
ls -la /nix/store/8xkaf3q5y7wqz4aplvngfcw7h0s27hcq-ssh-to-age-1.1.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ssh-to-age

Maintainer pings
cc @Mic92 for testing.

Result of nixpkgs-review pr 251755 run on x86_64-linux 1

1 package built:

ssh-to-age


KeyVault name not accepted

Expected behavior
Successful template deployment
Actual behavior
"keyVaultName": "[concat(uniquestring(resourceGroup().id), 'vault')]", returns an invalid name for a KeyVault
e.g.: 7paczw7bqb76yvault
Steps to reproduce the problem
use "PartnerSmartOffice" as Resource Group name ? hoping that uniquestring returns a string with a leading digit.
proposed fix
"keyVaultName": "[concat('vault',uniquestring(resourceGroup().id))]",

@ManuInNZ thank you for this feedback. I have incorporated the changes you recommended in the 0.0.2 release that was just published.


clarify that package provides C++ library

This package provides a C++ library, but not a Python frontend, which is provided by the iminuit package. This was clarified and a reference to iminuit was added.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Travis integration

Since there are more people contributing, it would be good to have some Continuous Integration service building up PRs and the like. Travis is the most famous (IMHO) so I think we should give it a try. Besides this is almost as easy as adding a file (whcich we can base upon plug's for example). After that, we should add the Travis badge to README.

Sounds good! I'm all for it.

I turned it on and builds are passing! https://travis-ci.org/bryanjos/joken
I also added the badge to the README.md. Thanks for setting this up!


Better notification image support

Automatically convert binary image data to a png on disk, that can be read by eww. The conversion already works, but for some reason it is still very slow.

Turns out indexed access to regular Haskell list is a linear, not a constant operation. Interesting that this made such a large difference even for 160x160 pixels.

Seems to work!


fix: ponyfill instance type

@markcellus Object.create() in TypeScript has an any return type

Nice, thanks! We probably should just force noImplicitAny so that similar issues are caught during development. What do you think @TechQuery?

noImplicitAny

Yes, I agree.

Nice, thanks! We probably should just force noImplicitAny so that similar issues are caught during development. What do you think @TechQuery?

Yes, I agree.

@markcellus When will this fix be released ?

@TechQuery released this in latest next.3 version. Give that a try! :rocket:


Type of Lense

Hi can you add the specs for the needed lense ?

I tried a 18mm MCWlaser CO2 Fokus Lens from Amazon with focal length 2in (50.8mm). The original camera focus is set to almost infinity, so this lens sets the new focus also to around 2in if you place it directly in front of the camera. In hindsight a slightly longer focal length would have been better for my applications, like the 4inch or even 7.5inch found on amazon, since you have to get pretty close to the PCB and the field of fiew is quite limited then. You can identify 0402 components easily with the 2in lens though.


ecds: add network filter dynamic config provider

Additional Description: Continuing the templatization work that has been done in order to support network filters for ECDS, as a similar feature to listener and HTTP filters. Linked issue: #14696. This PR adds dynamic config providers for network filters without listener consuming.
Risk Level: low
Testing: Unit tests
Docs Changes: none
Release Notes: none
Platform Specific Features: none

/assign @kyessenov
As you're familiar with the ECDS for HTTP and were involved reviewing the templatization work, will appreciate your first pass on this one.

/retest

/assign @htuch
Will appreciate your second pass review

@kyessenov I hoped to split this to multiple PRs so it doesn't get too many lines of change. Do you think it should be all in a single PR?
I guess that if there would be issues with the interfaces I could adjust the deltas in the following one, as this PR doesn't really change any behavior.
Please lmk what you think

I think it's fine to have separate PRs provided the changes needed subsequently are not major.

@kyessenov I followed your suggestion to add the interface integration, and indeed there was a small change needed. However it added some boilerplate changes. This PR only uses the network config provider interface for static config, therefore no real behavior change. Will appreciate if you can take another look. Next PR will be adding the dynamic config part along with integration tests. Thanks

@kyessenov let me know when LGTM on changes and I'll do a pass.

Done. Thanks for reviewing @kyessenov


Use the classical_function compiler instead of Oracle components

What is the expected enhancement?
In the last release of Terra, the classical function compiler has been added which uses the tweedledum library to compile a classical function to a circuit. This compiler yields much more efficient circuits than the Oracle components LogicalExpressionOracle and TruthTableOracle.
Oracle for the logical expression not a or (b and c):
@classical_function
def leo(a: Int1, b: Int1, c: Int1) -> Int1:
      return (not a) or (b and c)

circuit = leo.synth()

yields
q_0: ──■────o───────
       │    │
q_1: ──o────┼───────
       │    │
q_2: ──■────■───────
     ┌─┴─┐┌─┴─┐┌───┐
q_3: ┤ X ├┤ X ├┤ X ├
     └───┘└───┘└───┘
Optimized circuit count (basis set 'u x cx'): OrderedDict([('u', 29), ('cx', 26), ('x', 5)])

whereas
leo = LogicalExpressionOracle('~a | (b ^ c)', optimization=True)
circuit = leo.construct_circuit()

yields
     ┌───┐     ┌───┐┌───┐                          ┌───┐
v_0: ┤ X ├──■──┤ X ├┤ X ├───────────────────────■──┤ X ├───────────────
     └───┘  │  └───┘├───┤     ┌───┐             │  └───┘┌───┐     ┌───┐
v_1: ───────┼────■──┤ X ├──■──┤ X ├─────────────┼────■──┤ X ├──■──┤ X ├
     ┌───┐  │    │  ├───┤  │  ├───┤             │    │  ├───┤  │  └───┘
v_2: ┤ X ├──┼────■──┤ X ├──■──┤ X ├─────────────┼────■──┤ X ├──■───────
     └───┘┌─┴─┐  │  ├───┤  │  └───┘      ┌───┐┌─┴─┐  │  └───┘  │
c_0: ─────┤ X ├──┼──┤ X ├──┼─────────■───┤ X ├┤ X ├──┼─────────┼───────
          └───┘┌─┴─┐├───┤  │         │   ├───┤└───┘┌─┴─┐       │
c_1: ──────────┤ X ├┤ X ├──┼─────────■───┤ X ├─────┤ X ├───────┼───────
               └───┘└───┘┌─┴─┐┌───┐  │   ├───┤     └───┘     ┌─┴─┐
c_2: ────────────────────┤ X ├┤ X ├──■───┤ X ├───────────────┤ X ├─────
     ┌───┐               └───┘└───┘┌─┴──┐└───┘               └───┘
o_0: ┤ X ├─────────────────────────┤0   ├──────────────────────────────
     └───┘                         │  X │
a_0: ──────────────────────────────┤1   ├──────────────────────────────
                                   └────┘
Optimized circuit count (basis set 'u x cx'): OrderedDict([('u', 48), ('cx', 38), ('x', 17)])

The truth table oracle for a xor b:
@classical_function
def tto(a: Int1, b: Int1) -> Int1:
    return (not a and b) or (a and not b)

circuit = tto.synth()

yields
q_0: ──■───────
       │
q_1: ──┼────■──
     ┌─┴─┐┌─┴─┐
q_2: ┤ X ├┤ X ├
     └───┘└───┘
Optimized circuit count (basis set 'u x cx'): OrderedDict([('cx', 2)])

whereas
tto =TruthTableOracle('0110')
circuit = tto.construct_circuit()

yields
          ┌───┐
v_0: ──■──┤ X ├──■──
     ┌─┴─┐└───┘  │
o_0: ┤ X ├───────┼──
     └───┘     ┌─┴─┐
o_1: ──────────┤ X ├
               └───┘
Optimized circuit count (basis set 'u x cx'): OrderedDict([('cx', 2), ('x', 1)])

Since the Grover algorithm now works on circuits as oracles, I think we should remove these oracle classes. Alternatively, if there's some convenient functionality we want to keep, we should either
(1) augment the classical compiler to allow that functionality, or if not possible
(2) replace the oracle components by QuantumCircuits that leverage the classical function compiler internally.

How does it do with the 3-Sat example?
Is the Truth Table function able to alleviate the memory issue here #1186 such that it can be done.
If the functionality is able to cover what the existing Oracles and more efficiently then it certainly seems like its a good case to deprecate the current ones in favor of this. Can you confirm the existing Oracle capabilities are covered? And as you suggest utilizing this to build out the circuits internally if there are interface aspects that need to be preserved is an option.

The 3-SAT example from the readme sample with the current Oracle is:
OrderedDict([('u', 172), ('cx', 116), ('x', 18)])
Width, Depth: 12 222

versus Tweedledum:
OrderedDict([('u', 32), ('cx', 27), ('x', 7)])
Width, Depth: 4 47

And it seems to work with Grover's algorithm, though it needs some pre-processing to convert the bit-flip oracle to a phase-flip and define the good_state function.

In regards of

augment the classical compiler to allow that functionality, or if not possible

another alternative is to provide some utility capabilities here to facilitate building out oracles, such as parsing the cnf and giving back the classical function, same for a truthtable as otherwise it looks awkward to build out the more bits there given the above example of an equivalent. Maybe this nets out to be similar to custom classes for getting a circuit like is there today.

I was discussing with @a-matsuo and we we're thinking of library circuits in Aqua that did this job, like
def fun(x1: Int1, x2: Int1) -> Int1:
    return x1 and not x2

expr = 'x1 ^ ~x2'
tto = '0100'

oracle = LogicalFunctionOracle(fun)  # type: QuantumCircuit
oracle = LogicalExpressionOracle(expr)  # type: QuantumCircuit
oracle = TruthTableOracle(tto)  # type: QuantumCircuit

and possibly
sat_cnf = """
DIMACS etc.
"""
oracle = DIMACSOracle(sat_cnf)
post_processing = oracle.post_processing  # maps result bitstring to DIMACS format

We have a document on that that I'm happy to share!


Double slash problem on card pop-ups

The card's pop-up links to
http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb
Note the double slash //b, if I remove one slash, it works as expected. Also, navigating to the boards doesn't suffer from this.
I believe apache2 is at fault here, but I'm not sure. There are two similar issues: https://github.com/wekan/wekan/issues/679 and https://github.com/wekan/wekan/issues/671
I've set my root url export ROOT_URL='http://<IP_ADDRESS>/wekan'
I've tried some Rewrite Rules on apache2, but I couldn't find out the right one to use.
    RewriteEngine on
    LogLevel alert rewrite:trace6
    #RewriteRule ^/wekan$ /wekan/ [R]
    #RewriteRule ^(.*)/+$ $1 [R=301,L]

    #ProxyRequests Off
    #ProxyPreserveHost On

    ProxyPassMatch  "^/(sockjs\/.*\/websocket)$" "ws://localhost:3000/wekan/$1"
    ProxyPass /wekan http://localhost:3000/wekan
    ProxyPassReverse /wekan http://localhost:3000/wekan

a log:
[Thu Dec 15 17:21:59.925460 2016] [rewrite:trace2] [pid 10949] mod_rewrite.c(475): [client <IP_ADDRESS>:49205] baldrik.local - - [<IP_ADDRESS>/sid#7fd0e53fa748][rid#7fd0e52f90a0/initial] init rewrite engine with requested uri /wekan/sockjs/594/w943hlqy/xhr_send, referer: http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb
[Thu Dec 15 17:21:59.925520 2016] [rewrite:trace1] [pid 10949] mod_rewrite.c(475): [client <IP_ADDRESS>:49205] baldrik.local - - [<IP_ADDRESS>/sid#7fd0e53fa748][rid#7fd0e52f90a0/initial] pass through /wekan/sockjs/594/w943hlqy/xhr_send, referer: http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb
[Thu Dec 15 17:21:59.946285 2016] [rewrite:trace2] [pid 10951] mod_rewrite.c(475): [client <IP_ADDRESS>:49181] baldrik.local - - [<IP_ADDRESS>/sid#7fd0e53fa748][rid#7fd0e52520a0/initial] init rewrite engine with requested uri /wekan/sockjs/594/w943hlqy/xhr, referer: http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb
[Thu Dec 15 17:21:59.946314 2016] [rewrite:trace1] [pid 10951] mod_rewrite.c(475): [client <IP_ADDRESS>:49181] baldrik.local - - [<IP_ADDRESS>/sid#7fd0e53fa748][rid#7fd0e52520a0/initial] pass through /wekan/sockjs/594/w943hlqy/xhr, referer: http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb
[Thu Dec 15 17:22:00.048906 2016] [rewrite:trace2] [pid 10951] mod_rewrite.c(475): [client <IP_ADDRESS>:49181] baldrik.local - - [<IP_ADDRESS>/sid#7fd0e53fa748][rid#7fd0e52fb0a0/initial] init rewrite engine with requested uri /wekan/sockjs/594/w943hlqy/xhr, referer: http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb
[Thu Dec 15 17:22:00.048934 2016] [rewrite:trace1] [pid 10951] mod_rewrite.c(475): [client <IP_ADDRESS>:49181] baldrik.local - - [<IP_ADDRESS>/sid#7fd0e53fa748][rid#7fd0e52fb0a0/initial] pass through /wekan/sockjs/594/w943hlqy/xhr, referer: http://<IP_ADDRESS>/wekan//b/Gtw5WWes4kvanupHu/devel/HduAsvhiCJLPJF4Hb

Somebody has a better idea?

@quimnuss
At https://github.com/wefork/wekan/wiki/Install-from-source
in "Run Wefork" section, please setup correct ROOT_URL.

Thanks xet7 for the prompt response
That's one of the installation instructions I've followed. In my case, webkan is accessed thought /webkan because there's another webpage at /, hence the modified ROOT_URL, which I deem correct.
The rewrite rules do work, but only if I refresh the page since I suspect the supplementary backslash is added after evaluating the rules.
Maybe you don't encounter the problem because you're running webkan at /, I'm not sure.
Could the problem be related to sockjs ?

@quimnuss
I have always used ROOT_URL like https://wekan.example.com or http://localhost that have worked for me, I have not tried running on suburl. My Apache-fu has become a little rusty after getting used to easyness of Caddy and automatic Let's Encrypt SSL.

Yes, if I set the config with:
  export ROOT_URL='http://<IP_ADDRESS>'

and
   ProxyPassMatch  "^/(sockjs\/.*\/websocket)$" "ws://localhost:3000/$1"
   ProxyPass / http://localhost:3000/
   ProxyPassReverse / http://localhost:3000/

That could be it:
https://github.com/wekan/wekan/issues/133

@quimnuss
In the wekan#133 issue you mentioned is already some code linked that could fix this, so it only requires someone with time to get that fix as pull request to Wefork.

I couldn't figure out which version of meteor / flow-router fixed the issue and wether or not is already on webfork, but it should already there, since I'm building from source, not using the docker.

The fix was introduced on https://github.com/wekan/wekan/commit/a78debc461944f55de246db15a1dd29353dec4ae but I don't see the changes in wefork, so I presume wefork was forked from a precedent commit? I'll check it out.

Sorry, i was wrong, the changes are there.

This seems to be an issue present on nginx as well. It seems that the card links end up creating are incorrect.

@Serubin
Did you use Nginx settings from:
https://github.com/wefork/wekan/wiki/Install-from-source
When I tried it previously it did work, if I remember correctly.

@xet7 I tried using that standalone and it did not work. I'm using a custom config that is functionally the same. I am using the prefix /board though. I'm not sure if wekan is limited to /wekan?
I've pulled this from flowrouter: I went through and added some logging to the FlowRouter.url() function and found this output:
  var completePath = this.path.apply(this, arguments);
  // /board/b
  var basePath = this._basePath || '/';
  // /board
  var pathWithoutBase = completePath.replace(new RegExp('^' + basePath), '');
  // /b
  return Meteor.absoluteUrl(pathWithoutBase);
  // https://mydomain.net/board//b

The router should definitely be taking out the leading slash. Also, all the hrefs on the card details include that second slash.
This is my config - somewhat redacted if it's any help.
upstream gitlab-workhorse {
  server unix:/home/git/gitlab/tmp/sockets/gitlab-workhorse.socket fail_timeout=0;
}

# Wekan Stuff
upstream wekan_local {
  server <IP_ADDRESS>:8123;
  keepalive 8;
}

# this section is needed to proxy web-socket connections
map $http_upgrade $connection_upgrade {
    default upgrade;
    ''      close;
}

## Redirects all HTTP traffic to the HTTPS host
server {
  ## Either remove "" from the listen line below,
  ## or delete the /etc/nginx/sites-enabled/default file. This will cause gitlab
  ## to be served if you visit any address that your server responds to, eg.
  ## the ip address of the server (http://x.x.x.x/)
  listen <IP_ADDRESS>:80;
  listen [::]:80 ipv6only=on ;
  server_name example-url; ## Replace this with something like gitlab.example.com
  server_tokens off; ## Don't show the nginx version number, a security best practice
  location / {
    return 301 https://$http_host$request_uri;
  }

  access_log  /var/log/nginx/gitlab_access.log;
  error_log   /var/log/nginx/gitlab_error.log;

}

## HTTPS host
server {
  listen <IP_ADDRESS>:443 ssl;
  listen [::]:443 ipv6only=on ssl ;
  server_name example-url; ## Replace this with something like gitlab.example.com
  server_tokens off; ## Don't show the nginx version number, a security best practice

  ## Strong SSL Security - REMOVED IN EXAMPLE
  ## https://raymii.org/s/tutorials/Strong_SSL_Security_On_nginx.html & https://cipherli.st/

  ## Individual nginx logs for this GitLab vhost
  access_log  /var/log/nginx/gitlab_access.log;
  error_log   /var/log/nginx/gitlab_error.log;

   merge_slashes on;

   location / {
    ## SNIPPED - Gitlab root
  }

 # Wekan config
 location /board {
    proxy_read_timeout      300;
    proxy_connect_timeout   300;
    proxy_redirect          off;

    proxy_http_version 1.1;

    proxy_set_header    X-Real-IP           $remote_addr;
    proxy_set_header    X-Forwarded-Ssl     on;
    proxy_set_header    X-Forwarded-For     $proxy_add_x_forwarded_for;
    proxy_set_header    X-Forwarded-Proto   $scheme;
    proxy_set_header Upgrade $http_upgrade; # allow websockets
    proxy_set_header Connection $connection_upgrade;
    proxy_pass http://wekan_local;
      # the root path (/) MUST NOT be cached
      if ($uri != '/board') {
            expires 30d;
      }

  }

  error_page 404 /404.html;
  error_page 422 /422.html;
  error_page 500 /500.html;
  error_page 502 /502.html;
  location ~ ^/(404|422|500|502)\.html$ {
    root /home/git/gitlab/public;
    internal;
  }
}

@Serubin
If you run wekan as service, then in your:
<EMAIL_ADDRESS>file is this line, that needs to include correct address of wekan:
Environment=ROOT_URL=https://example.com/board

@xet7 I made a simple startup script that definitely covers this
You can see in the example above that flowrouter is respecting the prefix, but it's adding a lead slash to it's url as if it's a base url.
cd /var/www/wekan/.build/bundle/
export PORT=8123
export HTTP_FORWARDED_COUNT=1
export MONGO_URL=mongodb://<IP_ADDRESS>:27177/admin
export ROOT_URL=https://myurl.com/board
export MAIL_URL='smtp://me@smtp.google.com:25/'

node main.js

cd -
``

@Serubin
I can reproduce this bug on Nginx and Caddy webservers.

I think this pull request is about same issue:
https://github.com/kadirahq/flow-router/pull/691
I'll try to figure out how to use it.

@xet7 Do you think it's due to FlowRouter or something within wekan? It seems like FlowRouter to  me. It looks like they've discontinued development on it.

@Serubin
Yes, that pull request is fix for bug in FlowRouter. Easiest way would be to try to use that fix.
There was update to FlowRouter git repo 13 days ago, so it does not look like discontinued.
https://github.com/kadirahq/flow-router

@xet7
Seems like the actual code hasn't been changed in about a month. The latest update was to the readme. Nothing has been merged in in almost a year.
Correct me if I'm wrong - I haven't used meteor much - but in order to use their fix they would have to merge the PR.
I did try to fork my own version and fix it (which included uploading it to the meteor package site) but it seems another package that wekan uses was still pulling in the original FlowRouter and overriding my version.

@Serubin
Yes, fixed FlowRouter fork needs to be used in all places of Wekan.

waiting for your updates guys, https://github.com/wekan/wekan/issues/423 I wish I could help with meteor

Yup, seems to only be a problem when using wekan as a service.
Why is ROOT_URL in<EMAIL_ADDRESS>= http://localhost/wekan and in run-wefork.sh it's http://localhost:3000 ?

@jLouzado It's a problem with wekan in general.

Sorry so do we know how to fix this yet? I'm asking because Wekan as such is pretty unusable till this gets sorted out yes?

No.
@Serubin tried to get that FlowRouter fix https://github.com/kadirahq/flow-router/pull/691 merged, with process like forking multiple other repos that would then be hosted under Wekan GitHub organization, but was not able to make Wekan build process working correctly.
@shtefcs can you help ?

I will post additional details shortly. I got extremely busy last week and
wasn't able to work on the project further
On Mon, Feb 6, 2017, 03:46 Lauri Ojansivu<EMAIL_ADDRESS>wrote:

No.
@Serubin https://github.com/Serubin tried to get that FlowRouter fix
kadirahq/flow-router#691
https://github.com/kadirahq/flow-router/pull/691 merged, with process
like forking multiple other repos that would then be hosted under Wekan
GitHub organization, but was not able to make Wekan build process working
correctly.
@shtefcs https://github.com/shtefcs can you help ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wefork/wekan/issues/49#issuecomment-277617092, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABLWIQSGXNRuCizo9g0TjZpm-_hb-Bmxks5rZt3LgaJpZM4LOPpr
.

Moving this issue to https://github.com/wekan/wekan/issues/785 , please continue discussion there.


Support relative dimensions for mo.image

Description
Hello,
Currently mo.image only support width/height in pixels
Supporting relative dimension (in percent) like
mo.image("pics/3bus-system.png", width="50%").center()

Could be a nice feature to have.
Best regards
Suggested solution
I don't know if dimension should be relative to :

page width
column width

Maybe column width have more sense.
Alternative
No response
Additional context
No response

Thanks @mscolnick


Add dashboard page after login

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


after upgrade redisson-spring-boot-starter to 3.13.5, can`t load config file anymore

Expected behavior
load config file from classpath
Actual behavior
applicaton goes error when bootstrap
Steps to reproduce or test case
upgrage to 3.13.5 and use spring.redis.reddison.file instead of spring.redis.reddison.config in the application.yml
Redis version
5.0.5
Redisson version
3.13.5
Redisson configuration
{
"singleServerConfig": {
"address": "redis://localhost:6379",
"password": null,
"pingConnectionInterval": 10,
"database": 12
},
"codec": {
"class": "org.redisson.codec.JsonJacksonCodec"
},
"transportMode": "NIO"
}

Fixed! Thanks for report


remove StorableAccounts.pubkey()

Problem
moving to not mmapping append vec files. Soon, lifetimes of borrowed account data will be limited to a callback.
Summary of Changes
remove StorableAccounts.pubkey()
This simplifies the api and allows the single call for account() to get a pubkey and the account itself. Everyone who uses the api needs both pieces of data.
Fixes #

Codecov Report
Attention: Patch coverage is 97.29730% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (7f16e84) to head (c41ac05).

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #829     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%
=========================================
  Files         851      851
  Lines      231616   231585     -31
=========================================
- Hits       189603   189548     -55
- Misses      42013    42037     +24

I don't really understand why we are removing StorableAccounts::pubkey(). I understand adding fn pubkey() to AccountForStorage and switching callers to use this method instead. Do we need to remove StorableAccounts::pubkey() to help the compiler disambiguate which fn to call?

we'd have to implement a callback for pubkey also if we want to use a ref for the pubkey. It is easier, cleaner and correct to leverage the work to use the callback for account that also returns pubkey.


feat: Improve config generation

closes #309

After the PR is merged, I'd argue we would need a follow-up issue to refactor config package into something more cohesive. The cache feature is mostly useless as it is now, for example. But that's a discussion for later 😉

I agree that we should refactor config. Not sure if we should some of that here (like i proposed).

After some discussions we are going to merge this PR as is . The problems mentioned by @renan061 will be resolved right after on top of the issue #325

After some discussions we are going to merge this PR as is . The problems mentioned by @renan061 will be resolved right after on top of the issue #325

Since this PR will break the main branch, I think it is best to merge the other config PRs on top of this branch.
And then we continue with the proposed changes.


Thermo RAW files will not open after previously importing correctly

Basic information

My operating system and version: Windows 10/11
My MZmine version: 3.9.0

What happened
Last week Thermo RAW files (SIM data) imported without issue, but after acquiring new data with the same method I receive a "no scans found" error with the same MS method when trying to import. I also receive the same error when attempting to open raw files that worked last week and I cannot open saved MZmine projects derived from these data (the projects were not standalone). I am however able to open data I previously exported as mzml. I have attached logs and a zip file containing an example file that will not open now along with a previously converted mzml file that will open. I have tried installing MZmine on a seperate machine and transferring the files there for processing but have the same issue.
exampledata.zip
mzmine_0_0.log

Hi,
I can reproduce your error on macOS as well. Just to clarify, the attached .mzml file is from the exact same .raw file and was created with the .mzml export function from MZmine? What happens when you try to convert the same .raw with MSConvert? Do you also get an error or a valid mzml?

Yes, the mzml was previously converted with MZmine from this raw file. I obtain the same error with MSConvert. It is very strange behavior as no system or software changes were made since last week.

internally we use the ThermoRawFileParser.
There is a pending update internally in MZmine but we had some issues on macOS that we have to fix first.
Try see if there is a folder mzmine_thermo_raw_parser in Temp and delete it:
C:\Users###YOUR-USER-NAME###\AppData\Local\Temp\mzmine_thermo_raw_parser\
May also look into your actual MZmine temp folder and also delete it there

I also have this problem, i could not find the file mentioned to delete it to solve the problem. Any solutions?


Created Event Classes under ..model/event

Event class
EventName class
Description class
Location class
Attendees class

Error encountered by travis:
The command "./config/travis/run-checks.sh && travis_retry ./gradlew clean checkstyleMain checkstyleTest headless allTests coverage coveralls asciidoctor copyDummySearchPage" exited with 1.
Please help debug

Seems to be issue with checkstyle. Need to change accordingly.


File organization issues

Hey Aaron,
I stumbled upon your project through your video on YouTube and very much like what you're doing here. Peeking at the code, I noticed a few problems with how you organize your files, so I'd like to throw some suggestions your way:

The 'Classes' folder is obsolete and no longer required. You can now put UObject declarations into Public and Private

Your public header files in Classes include BluPrivatePCH.h. This is not desirable, because that forces your users to include a private header. By definition, the "Private Pre-Compiled Header" file should only be used internally and not be accessible outside your module.

BluPrivatePCH.h should be included only by your .cpp files, not any of the private or public header files. If your private/public header files require other headers in your module, then you should include those header files explicitly.

In general, you should minimize the number of other header files that any given header file depends on. Ideally, no header file should include any other header files. This can almost always be accomplished by using forward declaration of types. One of the common exceptions is when you derive from an external type, i.e. IModuleInterface. Note that most types declared in Core do not require explicit inclusion as the majority of Core headers are always included automatically.

You may want to limit your plug-in to those platforms that actually support and are set up to compile CEF by white-listing them in your .uplugin file.

I'm looking forward to seeing how you send JavaScript events back to UE4. Some Blueprint integration would be nice. Good luck :)

Hello! Thank you very much for giving some advice, it's nice to hear from someone at EPIC.
The UI plugin has mostly been a side project of mine, up until now I've been making it up as it goes along. However that changed when I saw this could become a very helpful system.
I will work on reorganizing the header files (mostly removing the PCH from Classes header files. I'll be doing some testing on other platforms including Linux. (Testing OSX will be difficult as I don't have an Apple computer at my disposal) But I will white-list those that are supported.
Passing JS events back into UE4 works perfectly in tandem with the custom sub-process (https://github.com/aaron524/BluBrowser) which will be packaged with releases here on GitHub. But the feature is currently undocumented. You can call blu_event(event_name, event_data) to send a JS event back into UE4 (see https://github.com/aaron524/BLUI/blob/master/Source/Blu/Classes/BluWidget.h#L81)
Thanks for all the feedback!

You wouldn't happen to know the uplugin syntax for platform white listing would you? I can't find it documented anywhere. I did add checks in the build cs file.

Hey Aaron, the settings go into the "Modules" section as "WhitelistPlatforms" and/or "BlacklistPlatforms". For example:
{
    // other settings here

    "Modules" :
    [
        {
            "Name" : "UdpMessaging",
            "BlacklistPlatforms" : [ "HTML5" ]
        }
    ]
}

Yes, looking much better :)
One more suggestion.... this:
#include "../Public/BluInstance.h"

...can be simplified to:
#include "BluInstance.h"

... because all sub-directories in the Public directory are discovered automatically by UBT.

@gmpreussner oddly enough, when I change this, Visual Studio (and the compiler) complains about not being able to find these header files.

Hmm... that is rather unexpected. A module should always find its own Public header files. I wonder if something in your Build.cs breaks the logic. I took a quick look and couldn't see anything obvious, but something must be wrong somewhere. We're not using relative include paths for module headers anywhere in the engine or in plug-ins :/

@gmpreussner looked into it, seems I did break something in the build.cs, all fixed now with the above commit, thanks for the help!


[FEAT] Update API to display BPMN Elements with Overlays

Closes #9

Prior 96b272e, the BPMN diagram wasn't displayed anymore: the R binding had changed (pass an object instead of only the bpmn content) and the JS binding hadn't been updated. So the bpmn input passed to bpmn-visualization was empty and a alert window was displayed with the "parsing error".
This is now working, I have tested the display with
bpmn_file <- system.file("examples/Travel_Booking.bpmn", package = "bpmnVisualization")
bpmnVisualization::display(bpmn_file)

I have been able to display an overlay by following the README explanations
overlays <- list(bpmnVisualization::create_overlay("_6-203", "9"))
bpmnVisualization::display(bpmn_file, overlays)

Note about robustness
If a list is not provided for the overlays but a single overlay, there is no error but the overlay is not displayed.
For instance, with the following
> overlays <- bpmnVisualization::create_overlay("_6-203", "9")
> bpmnVisualization::display(bpmn_file, overlays)


Clock icon is missing in Charter column in RSunstone

Description
When VM has actions defined a clock icon is expected to appear in VM menu in Charter column in RSunstone (Admin view in RSunstone -> Instances -> VMs -> Charter column).
To Reproduce
Instantiate VM. As soon as it reaches the status RUNNING define actions for it (Admin view in RSunstone -> Instances -> VMs -> Select certain VM -> Actions tab -> create an action. Go back to Instances -> VMs and check for clock icon in Charter column (it is missing).

Expected behavior
At least in 5.12 version such clock icon is present.

Details

Affected Component: RSunstone
Hypervisor: any
Version: development

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

That issue was created under wrong GH account. Was re-created under proper one.


Clicking on "Copy Query" gives Gateway Timeout

This may be a short lived problem. I have tried 3 times to copy this Query:
https://lasair-iris.roe.ac.uk/query/203/
All received a Gateway Timeout. Will try again in 1 hr and report back.

I can confirm the problem persists 1 hr later so probably not a database locking issue/

It is because the query has active=2, meaning it puts out a kakfa stream. When such a query is modified, saved, or copied, its kafka topic and stream log are deleted, then the new query is run with LIMIT 10 and those results pushed into kafka and stream log. This is so that these collections of results synchronise with the query as it is now, not as it was then. Clearly something is busted in this complicated chain of events.
I'll try to figure out exactly what is wrong, see if I can use the public kafka system from the dev webserver. Then simplfy this complicated behaviour.

All fixed! Thanks Roy!!


MosaicML commands with S3

I have try to implement MPT-7b-chat based on MosaicML platform.
I have executed the first step to convert c4 data set to steaming type and store my shards files on s3 path, after that I have executed composer command to train my MPT-7B model with the shards stored under S3.
It's showing some errors.
I have change yaml file to commented the data local path,  - and provide data-remote path to execute its always says index.json file took too long to download, bailing out.
--Any one help me out with this. I need to execute the composer command with my shards on s3

HI ashoksmavd,
Can you provide your yaml so I can have a look?

hi @codestar12
Here I have attached my yaml file.
mpt-7b.txt

Have you double checked the correctness of your s3 path and aws permissions? I was going to take a look at how you formated your s3 path but I assume you kept it generic for privacy reasons.

Closing as stale -- please re-open if you continue to have issues!


[Question] Unexpected results when running on custom PDF files

Hello, thank you for the effort you've put into this repository. I've recently tried to run it against my own pdfs (converted to images)

Click here to see the image

And this was result:

Click here to see the image

My code to draw:
import argparse
import json
import logging
import os
import cv2

import skimage.io

from docparser import stage1_entity_detector

image_name="outputname-01.png"
sample_img_path = "/home/ubuntu/projects/pdf-expirements/DocParser/images/{}".format(image_name)
output_dir = "/home/ubuntu/projects/pdf-expirements/DocParser/demos/output"

entity_detector = stage1_entity_detector.EntityDetector()
entity_detector.init_model(default_weights="highlevel_wsft")

sample_img = skimage.io.imread(sample_img_path)
results = entity_detector.predict(sample_img)

image = cv2.imread(sample_img_path)

shapes = []
for pred in results["prediction_list"]:
  box = pred["bbox_orig_coords"].tolist()
  label = pred["class_name"]
  score = pred["pred_score"]
  shapes.append({"box": box, "label": label, "score": score})

for shape in shapes:
  y1, x1, y2, x2 = shape["box"]
  image = cv2.rectangle(image, (x1, y1), (x2, y2), (255, 0, 0), 2)

cv2.imwrite("{}/{}".format(output_dir, image_name), image)

Most of the bounding boxes were drawn very incorrectly. Am I doing the drawing wrong, or does it not work with files, which contain a structure like this. ? Thank you for your time.

Hey, thanks for your interest in the project!
From the code you shared it looks like you generated the outputs with the default WS+FT model. Generally, I'd expect it to need to be finetuned on a small set of images from your custom dataset in order to produce higher accuracy predictions, if the domains are not sufficiently similar in appearance and style.


White line in 3D view in editor using Metal on MacOS

Tested versions
Happens in v4.4.dev.custom_build [3b3d622]
It says custom due to my spotty internet not being able to successfully git clone the repository. I used the ZIP download which doesn't include the .git folder. This is just a normal build using 3b3d622.
System information
Godot v4.4.dev unknown - macOS 14.3.1 - Metal (Mobile) - integrated Apple M1 (Apple7) - Apple M1 (8 Threads)
Issue description
When loading in a newly created project a white line can be seen in the 3D view.

Steps to reproduce

Use an editor build with Metal on MacOS (3b3d622 in my case)
Create a new project
Observe the white line

Minimal reproduction project (MRP)
N/A

CC @stuartcarnie @clayjohn @bruvzg

Hi @stuartcarnie I can confirm that it does not happen when launching with --rendering-driver metal
I assumed that Metal would be enabled by default as is written in https://github.com/godotengine/godot/pull/88199
Together with the rather confusing OpenGL API 4.1 Metal message when using OpenGL and just Metal 3.1 when using Metal. I just assumed it was using Metal when I saw it in the first message.
Is it correct behaviour that OpenGL is used by default even when Metal is available?

@clayjohn ahh TIL! Sorry for the confusion.

Related to https://github.com/godotengine/godot/issues/91107.

Help -> System Info shows the driver and method only based on project settings and ignore command line arguments/fallback (should be fixed by https://github.com/godotengine/godot/pull/95887)
And macOS native OpenGL renderer does have Metal in the name at least on Apple Silicon. So it might be confusing.


testsuite input should be deterministic

The use of the random module and test/python/_random_circuit_generator.py for creating input in the testsuite should be avoid. Ideally, the output of the tests in test/python should be deterministic and well define. I understand that, because the nature of QISKit, that's not always possible.
Expected Behavior
if I'm passing the tests locally, I should be quite confident that the same situation will hold in the future. Changing nothing and get tests failing is frustrating. Feed random input to tests is good and desired in a context of fuzzing. The random input can be moved to a different place with the goal of generating new tests.
Possible Solution
Remove as much as possible sources of non-determinism in the testsuite.

So far, the tests that depend on random are:

test/python/test_projectq_cpp_simulator.py
test/python/test_qi.py
test/python/test_quantumprogram.py (trivial, random is used to generate a random hostname)
test/python/test_projectq_cpp_simulator.py
test/python//test_unitary_python_simulator.py
test/python//test_qasm_python_simulator.py
test/python//test_projectq_cpp_simulator.py

@1ucian0, does this overlap somehow with your efforts on #697? I mention it because we've discussed several times that the tests attacking the mock servers should be as deterministic as possible.
As a side note, avoiding the random module is a solution but finding a way of fixing the seed of the random functions could be another and it might require fewer changes.

This issue is about test files that call random as part of the test. The list of file is outdated tho. I can have a new look to it to see if this is still relevant.

As far as I know, all the random functions depend on the same random generator so if we get some way of restoring the seed before each test, we won't remove the randomness but we can ensure it is deterministic from run to run.

We should not fix the random seed in tests that rely on asserts. Namely tests that pass for any random seed, as long as the code is correct. The random seed should be fixed in the testsuite only for tests that fail otherwise.

A reminder, we are talking about random inserted just for testing, not about the intrinsic random used by Terra.
@delapuente: Using only constant-seeded generators is equivalent of using constants directly.
@yaelbh I disagree. Making sure that the tests pass with a big variety of inputs it's the job of a fuzzer, not the test suite. If I write code and the test suite fails, I want to make sure it is because my new code broke something, not because in that particular execution of the test suite the input covered a different path of existing buggy code.
Fuzzing Terra is something definitely worth trying, and it is something I did in the past. Let me know if you are interested in this effort.

I just updated the list. I'm moving the previous list here for archiving porpouses.
This list is old (Dic 2017):
  test/python/test_projectq_cpp_simulator.py
  test/python/test_qi.py
  test/python/test_quantumprogram.py (trivial, random is used to generate a random hostname)
  test/python/test_mapper.py
  test/python/test_unitary_python_simulator.py
  test/python/test_qasm_python_simulator.py
  test/python/test_job_processor.py
  test/python/test_local_qiskit_simulator.py (the problem here looks deeper, in how the seed is consumed. Probably non-trivial.)

@1ucian0 can you update the list here if it's still relevant? many of these tests no longer exist.

Update:

[ ]  test/python/test_visualization.py: The method TestLatexSourceGenerator.random_circuit generates a random circuit (used in test_tiny_circuit, test_normal_circuit, test_deep_circuit, and test_huge_circuit.

[ ] test/python/test_quaternions.py: Calls Numpy random.

[ ] test/python//test_qi.py: Uses random_density_matrix, which does not have a seed.

[ ] test/python//quantum_info/test_states.py: Uses random_state, which does not have a seed.

The visualization part will be fixed with a better version of https://github.com/Qiskit/qiskit-terra/pull/1617 (i.e. meta-test for visualizers)

Reopening as #1800 was "partially fixing" this issue

I have to say I disagree with this idea. It should be a mix of both. Experience shows that letting tests be random can identify edge cases, or donains of invalidity. Indeed, several swap mapper errors have been found via random circuit generation.

@nonhermitian Please see related comments https://github.com/Qiskit/qiskit-terra/issues/205#issuecomment-412488072 and https://github.com/Qiskit/qiskit-terra/issues/205#issuecomment-412510620.

I have no idea what fuzzying is, but it sounds like a fancy name for randomized testing, which agrees with my point above.
I would also say that finding bugs via randomized teststing out weighs the difficulty in determining if a new piece of code caused the error or not.  Given their random, and typically rare nature, they usually do not overlap with code that is actually modified in a PR, and are easy to spot. Fixing them tends to be the challenge.

The value of the test suite is in its reproducibility. If I modify code, and a test is not passing, there is something wrong with my modification. If a test fails sometimes, there is little information that I can extract from that fact.
In fuzzing, random inputs are provided to find the "edge cases" that you are referring in https://github.com/Qiskit/qiskit-terra/issues/205#issuecomment-463588187. If one of this randomly generated inputs breaks the invariant, the input is saved so you can reproduce the failure. Then you can add this input into the test suite as a new case.
We can have fuzzing testing and run it periodically (o continuously) to find new cases. However, we are going to need some parallel infrastructure for it. This infrastructure should have a way to extract the cases that are breaking code so we can add them as new cases. We are not currently doing this but I would support this effort.

I agree with Paul. There are cases in quantum where we need random for a reason. To test all possible states is not feasible

I don't disagree with that. We need parallel infrastructure for it where we can preserve the reproducibility of the breaking state.


Color class lacks Hue, Saturation, and Luminosity properties.

The Xamarin.Forms Color struct has Hue, Saturation, and Luminosity properties. The Maui.Graphics Color class does not. This makes the upgrade path from Forms to MAUI that more frustrating.
I get that converting a Color to HSL every time the Color changes isn't efficient (which is what Forms did, IIRC), when the chances are that most users aren't interested in HSL. But for anyone who did use them, well, their apps are now broken until they rewrite to call GetSaturation() etc., and restructure their code to avoid keep calling GetSaturation() etc (which recalculates the value each time) rather than just accessing a property.
At the very least, I'd have hoped for Hue, Saturation, and Luminosity properties that are marked as obsolete for the first release.

I ran into this same issue last night.
I used Color.FromHsv(hue, saturation, value) and I'm assuming value is equivalent to luminosity?
I found this confusing because there is a Color.Luminosity property (getter, no setter), but no Color.Value 🤔
Maybe some of the language could be tightened-up to avoid confusion and make it more obvious what to reach for when trying to lighten/darken a color without changing its hue or saturation

Actually, by naivety in the color space (pun) is showing here. HSL and HSV are clearly different https://en.wikipedia.org/wiki/HSL_and_HSV
... but it would be nice to be able to get value if we are able to set it 🤷


python3Packages.afdko: fix build against fonttols-4.28

Without the change afdko fails to build in staging as:
$ nix build -f . python3Packages.afdko
...
python3.9-afdko> AttributeError: 'Options' object has no attribute 'allowVID'

Part of #157350


Several pagination improvements

This PR adds pagination to the Home timeline and the Follows page.
A couple of caveats:

The Follows were ordered by the username, but we can't do that efficiently now without traversing the whole unpaginated queryset (which would defeat the purpose of pagination). They're now ordered by id, which should equate to creation order.
I removed a lot of slices in the paginated querysets. I don't know if those were deliberate or leftovers from before pagination was added.
I added buttons to go back to previous pages. Again, I don't know if that omission was deliberate.

Fixes  #126 and partially fixes #168.

Take a look, @andrewgodwin. The only thing is that follows are now treated individually, so if user A follows B, and B follows A, that will show as two separate items in the list. I don't see an obvious and efficient way of fixing that without some kludgy SQL.

No problem - I think I know a way to maybe fix that, I'll merge it in and see what I can accomplish. Thanks for doing this!


Android pending transaction status

To accurately communicate the current state of sent transactions the SDK should correctly reflect the status of pending transactions so that wallet developers can monitor them.

This becomes easier with the data access layer in librustzcash


Comment out of date in regards to new url

Here, the time.google.com is referenced but the end host for the request is grpc-web.myhbarwallet.com. I think it's confusing and wanted to let you guys know.
https://github.com/hashgraph/hedera-sdk-js/blob/c8623b029eaa873182e758f0809f902cb5b49886/src/sync.js#L6

Fixed: https://github.com/hashgraph/hedera-sdk-js/commit/5f9fc0b4ad16fc69dd07348c995e4af34eb98167


Don't allow optional operands for non-negated operators

This might be supported in the future to allow e.g. for nodes to be not included in the result output, but the current behavior is neither tested or well-defined so disallow this scenario for now.

bors r+


Error doesn't show up if I use a .deb package, so I assume it's related to the bundling process.
To Reproduce
Steps to reproduce the behavior:

Create a Tauri app.
Compile it inside an Ubuntu 18.04.
Try to execute the .AppImage in an Ubuntu 19.04.
See error

Expected behavior
The error doesn't happen.
Screenshots

Tauri info

Operating System - Ubuntu, version 18.04 X64

Node.js environment
  Node.js - 12.22.6
  @tauri-apps/cli - 1.0.0-beta.10
  @tauri-apps/api - 1.0.0-beta.8

Global packages
  npm - 6.14.15
  yarn - 1.22.11

Rust environment
  rustc - 1.54.0
  cargo - 1.54.0

App directory structure
/public
/tests
/.git
/.github
/node_modules
/src-tauri
/src
/scripts

App
  tauri.rs - 1.0.0-beta.8
  build-type - bundle
  CSP - default-src blob: data: filesystem: ws: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'
  distDir - target/webpack_dist
  devPath - target/webpack_dist
  framework - Vue.js (Vue CLI)
  bundler - Webpack

Just for clarity sake, can you please share the data provided by tauri info

Yes yes sorry, was unclear if they were needed here, I updated the issue.

Can you try this solution ?
https://askubuntu.com/a/872397

also, as an FYI - your rust is out of date. (pretty sure its not the problem here though)
> rustc --version
rust version 1.55.0 (c8dfcfe04 2021-09-06)

just run rustup update

Well I can't yet, there is a problem with some dependencies of the holochain crate that make it not compile in 1.55. But I have that noted down. @amrbashir I'll try it, thanks :D

@amrbashir doesn't solve the problem, although the initial warnings are not present anymore. Now what I get is:
guillem@guillem:~/Baixades$ ./holochain-launcher_0.3.3_amd64.AppImage
/usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitNetworkProcess: symbol lookup error: /usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitNetworkProcess: undefined symbol: NetworkProcessMainUnix
/usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitWebProcess: symbol lookup error: /usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitWebProcess: undefined symbol: WebProcessMainUnix

I had the exact same error message as OP, but interestingly I received that error when building in a Centos 7.3.1611 docker image and deploying to the same OS version (not a container though).
This PR did fix it for me though (thanks @FabianLars !):
https://github.com/tauri-apps/tauri/pull/2940

I experience the same error cargo tauri dev. when using the compiled appImage it works.


feature request

great project, can you add dark mode and a way to pick local llm such as koboldcpp or ollama

Thank you.
Since this widget is basically a WebEngine, I don't think we can use local LLM.
But, I  am planning to create a new widget to be used with Ollama.
I worked in a widget in the past that I can use as a base for the new widget.

You can use this widget to use local models: https://github.com/DenysMb/ChatQT-Plasmoid


Don't add OneHotEncoder to pipeline for text features

Problem
Our make_pipelines code builds a pipeline based on the feature types present in the data. The _get_preprocessing_components method will currently add a one-hot encoder component if there are any features of type object or category in the pandas dataframe. However, in the case where the data includes text features but no categorical features, this is unnecessary.
Fix
Short-term (this PR): during pipeline creation, exclude text features when determining whether or not to add an encoder for categorical features.
Long-term: use woodwork to get categorical cols, not pandas! (#1229 ). The make_pipelines code should be given a woodwork datatable, and we should instead use woodwork's select method.

This can be closed! We now use woodwork in make_pipeline to select categorical features and to determine whether or not we need to add categorical encoding to the pipeline. Thanks @freddyaboulton for reminding me to close this :)


Update bourbon in package.json

https://github.com/thoughtbot/bourbon/pull/303#issuecomment-72073068

No, this reference is OK, since Bourbon on npm some weird Ruby implementation and toolchain. Closing this.


Suggestion: Add agnostic definition

At: https://ubc-library-rc.github.io/intro-docker/uses/#what-is-docker-useful-for
Original: "Docker lets you create static and reproducible environments, saved into an image which will run the same way on any computer with Docker set up (agnostic to hardware and operating system)."
Suggestion: "Docker lets you create static and reproducible environments, saved into an image which will run the same way on any computer with Docker set up (agnostic to hardware and operating system)."

Great suggestion, thanks @ElizabethFernandes! I've just updated the text with that link.


Cannot complete step 8 - Activate All

Cannot complete step 8 in Readme
After cloning the github project and having copied the files in the package structure,
trying to Activate All in cities package I get the following error:
Error while activating files under /cities:
cities/data/user.hdbrole: invalid object name: cities.data::cities.City: line 1 col 25 (at pos 24) at /sapmnt/ld7272/a/HDB/jenkins_prod/workspace/FA_CO_LIN64GCC48HAPPY_rel_fa~newdb100_rel/s/ptime/query/checker/check_priv.cc:1380
Line 1 in user.hdbrole has only 23 columns....

Hello,
I'm getting the same error. Please help us.
Thanks.

Hello @kranz ,
I have solved it, try activating first only cities.hdbdd and cities.hdbti , then everything.
Thanks


when prop called repeat is true，the onEnd is not called

Current behavior
Describe what happens when you encounter this issue.
Reproduction steps
A 1, 2, 3, etc. list of what's needed to see the issue happen.
Expected behavior
Describe what you wanted to happen
Platform
Which player are you experiencing the problem on:

iOS
Android ExoPlayer
Android MediaPlayer
Windows UWP
Windows WPF

Video sample
If possible, include a link to the video that has the problem that can be streamed or downloaded from.

I am facing the same issue.
onEnd won't be called on Android when repeat props is true.
However on IOS it works fine.
Any solution ?


Cannot import files from Figma due to missing checkbox in setting in latest AE

Describe the bug
I am asked to tick a checkbox on the settings, but this checkbox was removed in AE 2019.
To Reproduce
Steps to reproduce the behavior:

Import layers from Figma
Popup is triggered in AE saying I need to tick the checkbox
Settings are loaded with no checkbox available

Screenshots

Desktop

OS: MacOS 10.15.5
AE: 17.1.4

Good catch. I need to reword that popup. Are layers still building ok, or are images missing?
Adobe moved this pref under the Scripting and Expressions tab of the Ae prefs. If you enable it there does that clear things up?

Thanks for the quick reply. It was not working, it got caught in a loop of pressing "OK" on the preferences panel and then showing the error and sending me to preferences. But at the time I had not found where they moved the checkbox to. I checked it now and it's working fine. Thanks for your help.


Export my view in excel

[QUESTION].
Package version 2.0.8, Laravel version 5.1
I'm using my maatwebsite to export to excel from my view, but can't find the way to passing my $results array to controller, I look here and found a solution, but does not work for me...!
this is my view

                Nombre
                Pais
                Tipo
                CC_PMC

          @foreach($results as $result)

               {{$result->nom}}
               {{$result->pais}}
               {{$result->tipo_cont}}
               {{$result->cc_pmc}}

          @endforeach

Excel

and the solution I found here...
class ExcelController extends Controller
{
    public function index(){
        Excel::loadView('listados.listados', array('results' => $results))->export('xls');
    }
}

this is my route...
Route::get('index', ['as' => 'pagina', 'uses' => 'ExcelController@index']);
and.... the error...
ErrorException in ExcelController.php line 14: Undefined variable: results
any idea...?

I solve it...! thank u...!

how did u solve it?

Well looking at his code:
public function index(){
        Excel::loadView('listados.listados', array('results' => $results))->export('xls');
    }

there's indeed an  Undefined variable: results.
Should be something like:
public function index(){
        $results = ['test'];
        Excel::loadView('listados.listados', array('results' => $results))->export('xls');
    }


Multiple versions of the same package

Disclaimer
I'm using pino in the context of a nestjs application and the boilerplate is quite large so i won't have a minimal reproducible case, although...
Error message
Here's the stack-trace at the time of crash of my application:
/Users/julien/Work/[redacted]/node_modules/.pnpm/thread-stream@1.0.0/node_modules/thread-stream/lib/worker.js:61
  destination.on('error', function (err) {
              ^
TypeError: destination.on is not a function
    at start (/Users/julien/Work/[redacted]/node_modules/.pnpm/thread-stream@1.0.0/node_modules/thread-stream/lib/worker.js:61:15)

I was clueless until I decided to add some log to the worker's script and see where it goes. I've added a simple console.log({ filename }) right here:
https://github.com/pinojs/thread-stream/blob/6f6375f24e6d5d43bead9e8746c502cabe98fb4a/lib/worker.js#L60-L62
...which led me to discover this:
{ filename<EMAIL_ADDRESS>}

...and it's a bit confusing because my package.json has pino-pretty@9 installed. BUT... some of my dependencies have dependencies on<EMAIL_ADDRESS>which seems not compatible with the new thread api.
After a quick check it seems that I have multiple versions of pino-pretty installed, and the wrong one get picked:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
So, i think, there's extra-check which needs to be done at some point to avoid picking the wrong version of a package if there's sadly 2 of them in the node_modules.

pino-pretty v4.7.1 is pretty old. I would recommend finding out the dependency chain and updating it.

thanks a lot. i ran into every place and upgraded all. 🙏


feat(core/progress-bar): add new web component 'ix-progress-bar'

💡 What is the current behavior?

🆕 What is the new behavior?
Added a new core web component "ix-progress-bar".
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):

[x] 🦮 Accessibility (a11y) features were implemented
[x] 🗺 Internationalization (i18n) - no hard coded strings
[x] 📲 Responsiveness - components handle viewport changes and content overflow gracefully
[x] 📄 Documentation was reviewed/updated (pnpm run docs)
[x] 🧪 Unit tests were added/updated and pass (pnpm test)
[x] 📸 Visual regression tests were added/updated and pass (Guide)
[x] 🧐 Static code analysis passes (pnpm lint)
[x] 🏗 Successful compilation (pnpm build, changes pushed)

👨💻 Help & support

Some linting and tests seem to be failing on other components that I have not touched.

@rouven-s Thank for your PR. We have to address some points before we can proceed here.

Accessibility has to be implemented for for new components e.g https://www.w3.org/WAI/ARIA/apg/patterns/meter/
Merge conflict in pnpm-lock.yaml
Component tests are missing
Visual Regression tests are missing

If this points are fulfilled we can further proceed with the code review.

@rouven-s Lint fails on your component:

@rouven-s please read the first sentence of the linked visual regression test guide: https://github.com/siemens/ix/blob/main/CONTRIBUTING.md#visual-regression-testing. Its not allowed to add windows based snapshots these snapshots cannot be checked via github workflow.

@danielleroux I added a11y and regression tests.
Following the instructions for the screenshot creation, running pnpm --filter @siemens/ix run visual-regression progress-bar -u with playwright installed locally only created win32 pngs, no linux ones.
Running docker run -p 8080:8080 -v $(cd):/work/ -w /work -it mcr.microsoft.com/playwright:v1.30.0-focal /bin/bash and then pnpm --filter @siemens/ix run visual-regression progress-bar -u with webServer.reuseExistingServer=true configuration results in this error:
Error: page.originalGoto: net::ERR_EMPTY_RESPONSE at http://<IP_ADDRESS>:8080/src/tests/progress-bar/basic?theme=theme-classic-dark
Do you have a hint on what I'm doing wrong?

@rouven-s I have looked a little bit more into detail and also tried setting up an docker development enviroment but it just seems that windows making strange symlinks and pnpm seems not really capable of dealing with multiple filesystems and volumes (when mounting folders). (https://pnpm.io/faq#:~:text=Does pnpm work across multiple,address a location in another.)
For further development i would suggest to you:

WSL2 - Inside the WSL setup iX again, then you can connect remotely connect to the instance via your IDE

https://www.jetbrains.com/help/webstorm/remote-development-starting-page.html#run_in_wsl_ij
https://learn.microsoft.com/en-us/windows/wsl/install
https://learn.microsoft.com/en-us/windows/wsl/tutorials/wsl-vscode

Doing everything in docker (you can also remote connect and develop there)

https://code.visualstudio.com/docs/devcontainers/containers

I generally would you suggest to use the WSL2 approach, but i also wrote a small Dockerfile, so  it is also possible to use:
FROM node:20 RUN corepack enable pnpm USER node:node WORKDIR /home/node RUN git clone https://github.com/siemens/ix WORKDIR /home/node/ix RUN pnpm i USER root RUN pnpm exec playwright install-deps RUN pnpm exec playwright install
Build the Dockerfile: docker build -t ix-docker-image -f .\Dockerfile .
Deploy container: docker run -p 3333:3333 -it --name ix-docker-container ix-docker-image /bin/bash

@rouven-s PR review + adaptions will be part of our next sprint

Hi, i'm interested by this component; is this still planned ?

Hello @BastLast, yes, this component is planned for the next quarter of 2025 and will also be aligned with the new form components.


Could you provide all of demo set up project ?

I have a problem that [ Could not render widget] So could you show me or upload of your set up

Can you please share with me your domain model and the microflows you defined?

A demo set up project can be found here: https://github.com/DevrimBaran/SimpleScheduler/releases/tag/v1.0.0. Just open a blank mendix project, go to file, and then click "Import App Package". I hope this helps and sorry for responding so late.

I would also need help, can I send you my domain model ?

Hi, did you try the demo project? The demo project contains the working widget. You can just download it here and import it to mendix. You could try to adapt your domain model and microflows to it. And also set the properties in the widget like in the demo project.


feat: support requestOptions prop

📑 Description
Implements #4 – requestOptions prop to support request customization.
✅ Checks

Make sure your pr passes the CI checks and do check the following fields as needed

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

@codeacme17 Do I need to build the library and push its output to the repo for this PR?

Yeah, if it's convenient for you！

oh sorry, I may need to do some manual work when I package this project, I'll agree to this pr first and then I'll package it. Thank you for your help!

@VanishMax I sent a request to invite you to become a collaborator on this repo. You can agree to the request if you wish, thanks again for your contribution! and I will close the related issue.

@codeacme17 Thank you, appreciated