Not assigning ranks lower than species level

Hi, thanks for your great program! In the new version, I am not getting any identifications higher than species level. Take for example this sequence:

COMB_000009819
actttcaagtaatattgctcatgctggtagagctgttgactttgctattttttctcttcatcttgctggtgcaaggtctattttaggggcagtaaactttatttctactgttggtaaccttcgttcctttggtataatagcagacctcataccactatttaggtgggctgtagtaattacagctgtattacttttattgtctttaccagtactggctggggcaattactatacttttaactgatcgaaatttaaactcttctttttatgatgcggggggtgggggagaccctattctttaccaacaccttttt

In the final table it just says NoMatch, but if you run it manually within BOLD it has 20+ matches of 80% or more in the All Sequences database, including 3 of 90% or more (should be assigned as family level). This is the case for every sequence in my fasta, no exceptions. Is there something I am missing in the code? The previous version of Boldigger successfully assigned higher ranks.

Can you please upload the fasta so I can check this?
eershova01 @.***> schrieb am Sa., 3. Aug. 2024, 18:44:

Hi, thanks for your great program! In the new version, I am not getting
any identifications higher than species level. Take for example this
sequence:
COMB_000009819
actttcaagtaatattgctcatgctggtagagctgttgactttgctattttttctcttcatcttgctggtgcaaggtctattttaggggcagtaaactttatttctactgttggtaaccttcgttcctttggtataatagcagacctcataccactatttaggtgggctgtagtaattacagctgtattacttttattgtctttaccagtactggctggggcaattactatacttttaactgatcgaaatttaaactcttctttttatgatgcggggggtgggggagaccctattctttaccaacaccttttt
In the final table it just says NoMatch, but if you run it manually within
BOLD it has 20+ matches of 80% or more in the All Sequences database,
including 3 of 90% or more (should be assigned as family level). This is
the case for every sequence in my fasta, no exceptions. Is there something
I am missing in the code? The previous version of Boldigger successfully
assigned higher ranks.
—
Reply to this email directly, view it on GitHub
https://github.com/DominikBuchner/BOLDigger2/issues/22, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH6ILEABU6BU7KUWSM7JPTZPUCFPAVCNFSM6AAAAABL6BPKVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DMNBYGI2DIMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

mats20.fasta.txt

With the recent updates on the website strange things happen will see what
I can do
Dominik Buchner @.***> schrieb am So., 4. Aug.
2024, 09:44:

Can you please upload the fasta so I can check this?
eershova01 @.***> schrieb am Sa., 3. Aug. 2024, 18:44:

Hi, thanks for your great program! In the new version, I am not getting
any identifications higher than species level. Take for example this
sequence:
COMB_000009819
actttcaagtaatattgctcatgctggtagagctgttgactttgctattttttctcttcatcttgctggtgcaaggtctattttaggggcagtaaactttatttctactgttggtaaccttcgttcctttggtataatagcagacctcataccactatttaggtgggctgtagtaattacagctgtattacttttattgtctttaccagtactggctggggcaattactatacttttaactgatcgaaatttaaactcttctttttatgatgcggggggtgggggagaccctattctttaccaacaccttttt
In the final table it just says NoMatch, but if you run it manually
within BOLD it has 20+ matches of 80% or more in the All Sequences
database, including 3 of 90% or more (should be assigned as family level).
This is the case for every sequence in my fasta, no exceptions. Is there
something I am missing in the code? The previous version of Boldigger
successfully assigned higher ranks.
—
Reply to this email directly, view it on GitHub
https://github.com/DominikBuchner/BOLDigger2/issues/22, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH6ILEABU6BU7KUWSM7JPTZPUCFPAVCNFSM6AAAAABL6BPKVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DMNBYGI2DIMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Another issue I noticed: when the API server gets overloaded, the program says "trying again in a few minutes" and then waits 10 minutes, but no matter how many times it tries server remains overloaded so that just repeats on a loop forever. It ran overnight, and didn't get anywhere. I killed the process and started over, and it connected OK immediately, so it wasn't because the served was down.
Maybe instead of trying again in 10 minutes, it could log out/log in again to somehow reset the process?

A login is not required for the API, I'll also check this... I really hope most of those issues will be fixed with BOLDv5, at the moment it's really a pain.

Okay, I think you spotted a bug here with the missing 80% assignments I can reproduce it and think I know the reason. I'll let you know as soon as I fixed it.

Thank you!! And thanks for the quick responses (especially on a Sunday!)

Fixed with 2.0.5. It should work as expected now (see example file). Have a nice rest of your weekend :)
mats20.fasta_identification_result.xlsx

Thank you - works perfect now!


MH-12739 Transcription Service updated to support Paella

Changes:

Dfxp captions are now attachments.
Captions are flavored as 'captions/+' to work with Paella.
Documentation updated.

Detailed discussion in PR #98.

So to test this we would need to set up a Watson account, correct?

I have verified that transcription works as expected - the normal demo media actually works surprisingly well considering the audio quality.  Paella is not included in my current build however, so I'm unable to merge this just yet.  Will look at this tomorrow.

My only major complaint here is that the workflow which submits the transcription request completes (which is good), but there's no indication that things are still processing on Watson's end (which is bad).  I don't, however, see a clear way to do this right now - what we need is a separate tab at the Events & Series tab which handles async jobs, but that's waay outside of the scope of this PR.  Will accept once I've verified that Paella's support is working, but I can see that the transcription itself is working.

Subtitles are available in both players, approved!


Keyboard settings on the language pack level

It would be very useful when ASK could provide specific settings on the LanguagePack level.
For example in my keyboard there is one layout which could simply be modified:

swap y and z
enable/disable multitap
enable/disable popup
enable/disable physical mapping

Note: There was the specific feature request on G+ about preservation of QWERTY/Z selection on Latin keyboards.

@menny do you think this is possible? This would have to be implemented in https://github.com/AnySoftKeyboard/AnySoftKeyboard, correct?

Yea, this should be implemented in ASK main app. But, I'm not sure why we'd want that on a layout specific setting and anot global.
Also, about the z/y swap, we should just provide additional layout. I was not aware it was a thing, "QWERTZ"


Can i train the data of 48k??

Why not? Just increase the taps in the encoder filter accordingly (e.g. it was 21 for 8kHz -> 121 for 48kHz)


improvementWrite audit log while doing drop stats. (#34433)

backport https://github.com/apache/doris/pull/34433

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0


Update example output in README.md

@ungoldman
Notes:

Added 'date' keys to example in README.md (fixes #16).
No changes to production code.

Thanks again @jrmykolyn!


Typo error in Flutter code lab

Below is the url to the issue including image.
"becausehot reload" should be editted as "because hot reload"
https://codelabs.developers.google.com/codelabs/flutter/index.html?index=..%2F..index#3

Hey @hieuwu , this issue tracker is used for bugs and feature requests in the flutter tool and some packages.
Please open this issue here - https://github.com/flutter/codelabs/issues

Sorry for my mistake.
But that repository has no issue part to be opened. Would you mind finding
one for me?
Vũ Hoàng Hiếu
University of Science - VNU HCM City
Mobile: (+84) 963 877 417
Email<EMAIL_ADDRESS>LinkedIn: linkedin.com/in/hieuvu99/
https://www.linkedin.com/in/hieuvu99/
Facebook: fb.com/vu.hieu.5500
Vào Th 5, 15 thg 10, 2020 vào lúc 11:22 Aneesh Rao <
<EMAIL_ADDRESS>đã viết:

Hey @hieuwu https://github.com/hieuwu , this issue tracker is used for
bugs and feature requests in the flutter tool and some packages.
Please open this issue here - https://github.com/flutter/codelabs/issues
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/68169#issuecomment-708887591,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOWBOINMCLCORX7QKUF3YTSKZ2G5ANCNFSM4SRMVETQ
.


KubeMemOvercommit alert wrong?

KubeMemOvercommit started firing recently so I took a look at the expression defined here: https://github.com/coreos/prometheus-operator/blob/master/contrib/kube-prometheus/manifests/prometheus-rules.yaml#L573=L588
sum(namespace_name:kube_pod_container_resource_requests_memory_bytes:sum)
          /
        sum(node_memory_MemTotal_bytes)
          >
        (count(node:node_num_cpu:sum)-1)
          /
        count(node:node_num_cpu:sum)

it's checking how much memory is used on all nodes from what's available and then compares this value to the total CPUs -1 / total CPUs ? Why is a comparison to the CPUs a factor in alerting of over committing memory? Am I reading this wrong/missing something?

That looks wrong indeed.
Can you open the same issue over at https://github.com/kubernetes-monitoring/kubernetes-mixin which is the correct upstream repository this is coming from.
It seems to be a direct copy of this (and thus a copy&paste mistake)
https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/2728a81295761a9031b8152b37c2efb05ca949aa/alerts/resource_alerts.libsonnet#L14

Done: https://github.com/kubernetes-monitoring/kubernetes-mixin/issues/162
Thanks!


Let's put CodeRefinery hubs on a map?

Such as Aalto, KTH, Trondheim, Oslo. This will hopefully motivate institutes to also become a hub.

Yes, under project/hubs.

Put these on a map
Describe how to become a hub
Link to this page from "get involved"


Missing result file in notebook

This repo is so cool, thanks for sharing!
I saw that this file is missing: results/all_annotations_alpaca_eval_gpt4.json from this notebook.
Would it be possible to add it or to document how to get it?

Good catch. It should be this one: all_annotations_alpaca_eval_gpt4.json


Updated readme, adding two missgin refs to functionality

Resolves #29

Changes Unknown when pulling f2af2ff703083f3aa9451acf641292830b199ce1 on issue-29 into ** on master**.


Crash when mapping a nested object when the server provides a string in place of the expected dictionary

To reproduce this crash, set up a relationship mapping, and return a string where the nested dictionary should be.
    frame #0: 0x01a64e52 libobjc.A.dylib`objc_exception_throw
    frame #1: 0x025e6fb1 CoreFoundation`-[NSException raise] + 17
    frame #2: 0x01510d1d Foundation`-[NSObject(NSKeyValueCoding) valueForUndefinedKey:] + 282
    frame #3: 0x0147d00b Foundation`_NSGetUsingKeyValueGetter + 70
    frame #4: 0x0147cfbd Foundation`-[NSObject(NSKeyValueCoding) valueForKey:] + 260
    frame #5: 0x0149b247 Foundation`-[NSObject(NSKeyValueCoding) valueForKeyPath:] + 409
    frame #6: 0x000ca946 Inspection Tool (iOS)`-[RKMappingSourceObject valueForKeyPath:](self=0x0a28c570, _cmd=0x0164370f, keyPath=0x077bfbd0) + 822 at RKMappingOperation.m:281
    frame #7: 0x000cfe4c Inspection Tool (iOS)`-[RKMappingOperation applyAttributeMappings:](self=0x0a282e10, _cmd=0x001a4a91, attributeMappings=0x0a290010) + 1660 at RKMappingOperation.m:613
    frame #8: 0x000d779e Inspection Tool (iOS)`-[RKMappingOperation main](self=0x0a282e10, _cmd=0x01641fe4) + 4062 at RKMappingOperation.m:992
    frame #9: 0x0149d453 Foundation`-[__NSOperationInternal start] + 736
    frame #10: 0x0149d164 Foundation`-[NSOperation start] + 79
    frame #11: 0x000d0c9f Inspection Tool (iOS)`-[RKMappingOperation mapNestedObject:toObject:withRelationshipMapping:metadata:](self=0x0a2bc420, _cmd=0x001a4861, anObject=0x077d7380, anotherObject=0x0a2eb080, relationshipMapping=0x077bfd60, metadata=0x0a28b630) + 1647 at RKMappingOperation.m:653
    frame #12: 0x000d18bf Inspection Tool (iOS)`-[RKMappingOperation mapOneToOneRelationshipWithValue:mapping:](self=0x0a2bc420, _cmd=0x001a498b, value=0x077d7380, relationshipMapping=0x077bfd60) + 1455 at RKMappingOperation.m:701
    frame #13: 0x000d5518 Inspection Tool (iOS)`-[RKMappingOperation applyRelationshipMappings](self=0x0a2bc420, _cmd=0x001a4aa9) + 6872 at RKMappingOperation.m:896
    frame #14: 0x000d7840 Inspection Tool (iOS)`-[RKMappingOperation main](self=0x0a2bc420, _cmd=0x01641fe4) + 4224 at RKMappingOperation.m:994
    frame #15: 0x0149d453 Foundation`-[__NSOperationInternal start] + 736
    frame #16: 0x0149d164 Foundation`-[NSOperation start] + 79
    frame #17: 0x000bdbc9 Inspection Tool (iOS)`-[RKMapperOperation mapRepresentation:toObject:atKeyPath:usingMapping:metadata:](self=0x077d1560, _cmd=0x001a374b, mappableObject=0x077ccc60, destinationObject=0x0a26da90, keyPath=0x002154d0, mapping=0x077bd2e0, metadata=0x0a29e8b0) + 1881 at RKMapperOperation.m:243
    frame #18: 0x000bd248 Inspection Tool (iOS)`__63-[RKMapperOperation mapRepresentations:atKeyPath:usingMapping:]_block_invoke(.block_descriptor=0xb05ff2e8, mappableObject=0x077ccc60, index=2, stop=0xb05ff167) + 456 at RKMapperOperation.m:215
    frame #19: 0x02557e7c CoreFoundation`__NSArrayEnumerate + 572
    frame #20: 0x02557a16 CoreFoundation`-[NSArray enumerateObjectsWithOptions:usingBlock:] + 102
    frame #21: 0x02557925 CoreFoundation`-[NSArray enumerateObjectsUsingBlock:] + 53
    frame #22: 0x000bceff Inspection Tool (iOS)`-[RKMapperOperation mapRepresentations:atKeyPath:usingMapping:](self=0x077d1560, _cmd=0x001a37a5, representations=0x077d1340, keyPath=0x002154d0, mapping=0x077bd2e0) + 2335 at RKMapperOperation.m:212
    frame #23: 0x000bec6f Inspection Tool (iOS)`-[RKMapperOperation mapRepresentationOrRepresentations:atKeyPath:usingMapping:](self=0x077d1560, _cmd=0x001a381b, mappableValue=0x077d1340, keyPath=0x002154d0, mapping=0x077bd2e0) + 527 at RKMapperOperation.m:298
    frame #24: 0x000bf6c7 Inspection Tool (iOS)`-[RKMapperOperation mapSourceRepresentationWithMappingsDictionary:](self=0x077d1560, _cmd=0x001a3892, mappingsByKeyPath=0x0a1c3050) + 2199 at RKMapperOperation.m:346
    frame #25: 0x000c0091 Inspection Tool (iOS)`-[RKMapperOperation main](self=0x077d1560, _cmd=0x01641fe4) + 1409 at RKMapperOperation.m:385
    frame #26: 0x0149d453 Foundation`-[__NSOperationInternal start] + 736
    frame #27: 0x0149d164 Foundation`-[NSOperation start] + 79
    frame #28: 0x00146469 Inspection Tool (iOS)`__73-[RKManagedObjectResponseMapperOperation performMappingWithObject:error:]_block_invoke() + 4809 at RKResponseMapperOperation.m:472
    frame #29: 0x0068c98f CoreData`developerSubmittedBlockToNSManagedObjectContextPerform + 95
    frame #30: 0x01f63014 libdispatch.dylib`_dispatch_client_callout + 14
    frame #31: 0x01f52d5f libdispatch.dylib`_dispatch_barrier_sync_f_invoke + 58
    frame #32: 0x01f52aa3 libdispatch.dylib`dispatch_barrier_sync_f + 108
    frame #33: 0x0068c90a CoreData`-[NSManagedObjectContext performBlockAndWait:] + 202
    frame #34: 0x00144cae Inspection Tool (iOS)`-[RKManagedObjectResponseMapperOperation performMappingWithObject:error:](self=0x0a170010, _cmd=0x001a8c77, sourceObject=0x077ca4c0, error=0xb05ffdbc) + 990 at RKResponseMapperOperation.m:427
    frame #35: 0x00142665 Inspection Tool (iOS)`-[RKResponseMapperOperation main](self=0x0a170010, _cmd=0x01641fe4) + 2373 at RKResponseMapperOperation.m:337
    frame #36: 0x0149d453 Foundation`-[__NSOperationInternal start] + 736
    frame #37: 0x0149d164 Foundation`-[NSOperation start] + 79
    frame #38: 0x01529a31 Foundation`__block_global_6 + 150
    frame #39: 0x01f5153f libdispatch.dylib`_dispatch_call_block_and_release + 15
    frame #40: 0x01f63014 libdispatch.dylib`_dispatch_client_callout + 14
    frame #41: 0x01f542e8 libdispatch.dylib`_dispatch_root_queue_drain + 335
    frame #42: 0x01f54450 libdispatch.dylib`_dispatch_worker_thread2 + 39
    frame #43: 0x90585e72 libsystem_c.dylib`_pthread_wqthread + 441

It seems to me that -[RKMappingOperation mapOneToOneRelationshipWithValue:mapping:] should simply return NO when the first parameter is not a dictionary.
The best way I can think of to do that is to check if it responds to -objectForKey:. It's possible that could break some KVC-compliant custom dictionary implementations which do not respond to -objectForKey:.
What do you think about that tradeoff to prevent this crash?

@segiddins can you elaborate on using a value transformation in this context?
My original issue is @ https://github.com/RestKit/RestKit/issues/2213 and I'm having difficulty understanding the best practice to avoid a crash in the condition that an API sends back an unexpected value. If I catch the NSUndefinedKeyException in RKResponseMapperOperation.m and cancel the operation like so:
@try {
    [self.mapperOperation start];
    blockError = self.mapperOperation.error;
    mappingResult = self.mapperOperation.mappingResult;
}
@catch (NSException * e) {
    [self cancel];
    return;
}
@finally { }

then the failure block of my caller runs, which feels expected and works great and I see no negative performance hits from this. I'm really curious how I should be handling this. Thanks for any guidance.

@csdco I can't for the life of me remember what I was talking about over a year ago

Well, was worth a shot. I've been searching all over for methods on how people catch these kinds of exceptions in RestKit. Certainly it doesn't make sense that bad data from an API request should crash the app.

I am facing the same problem. Is there a fix for this out yet ?


Verification failure (4002 error) on auth method

For fix it:
Add connection option:
...
function init() {
var ws = new WebSocket(WS_URL, {
agent: false,
});
...

APPRECIATE!!!!!!!!!!!!!!!!!!!!!!! THANK YOU!!!! @Nikolja174  You're god!!!


Add match_payload method to Envelope

Description of the changes being introduced by the pull request:
match_payload method checks for the payoad if deserializes into
the provided class type. This method is essential in order to
add DSSE compatibility in in_toto.
This method will provide interface similar to current in_toto's
Metablock property _type. Which is used at various places in
in_toto project to identify type of the payload.
Please verify and check that the pull request fulfils the following requirements:

[x] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[x] Docs have been added for the bug fix or new feature

match_payload will not be upstreamed, see corresponding note in https://github.com/secure-systems-lab/securesystemslib/issues/370#issuecomment-1317414319. Thanks for the efforts, @PradyumnaKrishna, this work was helpful for path finding!


Fire DestructEntityEvent.Death when setting a player's health to zero.

When setting a player's health to zero via the Data API, the DestructEntityEvent.Death event is not fired, and the normal Minecraft death code does not run, for example, a player's inventory might not get dropped, and no death message is fired. This is due to the folllowing lines calling attackEntityFrom:

https://github.com/SpongePowered/SpongeCommon/blob/bleeding/src/main/java/org/spongepowered/common/data/processor/multi/entity/HealthDataProcessor.java#L69
https://github.com/SpongePowered/SpongeCommon/blob/bleeding/src/main/java/org/spongepowered/common/data/processor/value/entity/HealthValueProcessor.java#L117

The issue with this is that there is a line in that method in EntityLivingBase (and a similar method in the non-overwritten EntityPlayer class method) that bails out early if the health is zero - which we've already set it to! Thus, nothing happens once health is set to zero, other than the client/server just recognising that the player needs a respawn as they have no health and telling them as such.
So, there are three potential fixes, depending on what we're trying to achieve:

In HealthDataProcessor and HealthValueProcessor, call onDeath instead of attackEntityFrom, like it did previously, and send the death sound ourselves.
In HealthDataProcessor and HealthValueProcessor, call attackEntityFrom before setting the health. I rejected this approach as the value processor has some try/catch block which I would then end up having to undo the "attack" if it failed. In theory, you could just perform that attack without setting the health after - but I didn't do that because I figured it wouldn't then be obvious what was going on.
The approach in the first commit, where the EntityPlayer#attackEntityFrom method is overriden and the health check is bypassed in EntityLivingBase#attackEntityFrom if using the Sponge damage source.

If there is no real reason to use attackEntityFrom over onDeath, then I actually suggest the first approach and would be happy for the first commit to be ignored.
The second commit in this PR fixes an issue I uncovered after writing the first commit, it causes Minecraft to use the generic death message if the translation for the key provided for the death message from the DamageSource is just the key. Without it, when a player dies via setting health, it printed "death.attack.spongespecific" to the game, with it, it simply states "dualspiral died".
Tested on both the lastest SpongeForge and SpongeVanilla codebases.
Test Plugin
Plugin: testplugin.zip
Source: https://gist.github.com/dualspiral/13392996ee94c40e6d0e9b31e4981b9c
To use, run /death <player>. Prior to this PR, the player dies, keeps inventory, and no DestructEntityEvent.Death is fired. With this PR, the player dies, standard Minecraft processing applies, and a message is printed to all players with the name and type of death of the player (which should be custom).

I've updated this for 1.11 (bleeding). The 1.10 version is at https://github.com/SpongePowered/SpongeCommon/compare/stable-5...dualspiral:bugfix/ondeathviahealth110


Bug: Fix Best Deals Section

Best Deals Section needs to be fixed.

I can help in solving this issue. You can assign it to me if no one is working on it

@shikharg1110 Assigned

@Karamraj, I want to fix this issue, kindly assign me under hacktoberfest.

Assigned


I get this the error

Can't bind to 'ngModel' since it isn't a known property of 'monaco-editor'.

Are you importing FormsModule?


Add ability to set/cancel Do-Not-Disturb for Ring Virtual Chime

I updated my local Ring Virtual Chime with the ability to set/cancel Do-Not-Disturb. Here is the diff if you are willing to add it to your version.
35a38,39
>     command "snooze", [[name: "Set Snooze Length (in minutes)*", type: "NUMBER", range: "1..1440", description: "Choose a value between 1 and 1440 (24 hours)"]]
>     command "cancelSnooze"
89a94,106
> void snooze(snoozetime) {
>     // Value must be in [1, 1440]
>     snoozetime = Math.min(Math.max(snoozetime == null ? 1 : snoozetime.toInteger(), 1), 1440)
>
>     final Integer sentValue = snoozetime
>
>     parent.apiRequestDeviceControl(device.deviceNetworkId, "chimes", "do_not_disturb", [time: sentValue])
> }
>
> void cancelSnooze() {
>     parent.apiRequestDeviceControl(device.deviceNetworkId, "chimes", "do_not_disturb", null)
> }
>
175a193,200
>   else if (action == "do_not_disturb") {
>       if (query == null) {
>         logInfo "Device ${device.label} snooze cancelled"
>       }
>       else {
>         logInfo "Device ${device.label} snooze set to ${query?.time} minutes"
>       }
>   }

Thanks,
Brian Ujvary

Added in a6da481


Roll Flutter Engine from dda82d905f37 to a3d1934c2684 (1 revision)

https://github.com/flutter/engine/compare/dda82d905f37...a3d1934c2684
2024-06-20<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from tD5pof7jVnbXPwP7l... to iU-B6rJxy0wUYSmmp... (flutter/engine#53493)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tD5pof7jVnbX to iU-B6rJxy0wU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Certificates not renewed after traefik renewal

Classification

[X] Serious bug

Reproducibility

[X] Sometimes

Docker information
docker info

Containers: 22
 Running: 22
 Paused: 0
 Stopped: 0
Images: 103
Server Version: 18.03.1-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 773c489c9c1b21a6d78b5c538cd395416ec50f88
runc version: 4fc53a81fb7c994640722ac585fa9ca548971871
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.0-6-amd64
Operating System: Debian GNU/Linux 9 (stretch)
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.769GiB
Name: vps372101
ID: HG3N:AU5S:2ZDE:OA7F:CEPF:CBDZ:QNGF:JOBS:B5NT:ZBRM:HN53:SS67
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

docker images hardware/mailserver --digests --filter "dangling=false"

REPOSITORY            TAG                 DIGEST                                                                    IMAGE ID            CREATED             SIZE
hardware/mailserver   1.1-stable          sha256:3dbb863ed5c714d9b15ff46271bae9c37adfdf57ded53b4f9ea3fefb093129df   e9c99615f126        3 months ago        363MB

Description
After traefik renewed my certificates, my mailserver wasn't using the new ones. When I did a ls -al in the mailserver container to view the certificate folder, I noticed that only the privkey and the fullchain were recently changed.
To fix it, I had to docker-compose down then up again to force the run.shscript to do its job.
Steps to reproduce

Let's traefik renewing certificates
Use SMTP on 587 with Apple Mail for example

Expected results
We expect it to work normally.
Actual results
It will complain about an expired certificate.
Debugging information
docker logs mailserver

[INFO] Search for SSL certificates generated by Traefik
[INFO] acme.json found, dumping into pem files
[INFO] Let's encrypt live directory found
[INFO] Using /etc/letsencrypt/live/mail.tiralarc-grand-est.fr folder
[INFO] Found DKIM key pair for domain tiralarc-grand-est.fr - skip creation
[INFO] Found DKIM key pair for domain listes.tiralarc-grand-est.fr - skip creation
[INFO] Override : owner_request_special = no
[INFO] Override : transport_maps = regexp:/opt/mailman/core/var/data/postfix_lmtp
[INFO] Override : local_recipient_maps = regexp:/opt/mailman/core/var/data/postfix_lmtp
[INFO] Override : relay_domains = regexp:/opt/mailman/core/var/data/postfix_domains
[INFO] Custom Postfix configuration file loaded
[INFO] MariaDB/PostgreSQL hostname not found in /etc/hosts
[INFO] Container IP found, adding a new record in /etc/hosts
[INFO] Redis hostname not found in /etc/hosts
[INFO] Container IP found, adding a new record in /etc/hosts
[INFO] ClamAV is disabled, service will not start
[INFO] Fetchmail forwarding is disabled
[INFO] Automatic GPG encryption is disabled
[INFO] ManageSieve protocol is enabled
[INFO] DKIM/ARC signing is enabled
[INFO] Greylisting policy is enabled
[INFO] Ratelimiting policy is enabled
[INFO] POP3 protocol is enabled
[INFO] Unbound DNS resolver is enabled
[INFO] clamav-unofficial-sigs is enabled (user configuration found)

Configuration (docker-compose.yml, traefik.toml...etc)
mailserver:
    image: hardware/mailserver:${MAILSERVER_DOCKER_TAG}
    container_name: mailserver
    restart: ${RESTART_MODE}
    domainname: ${MAILSERVER_DOMAIN}                    # Mail server A/MX/FQDN & reverse PTR = mail.domain.tld.
    hostname: ${MAILSERVER_HOSTNAME}
    labels:
      - traefik.enable=true
      - traefik.frontend.rule=Host:spam.${MAILSERVER_DOMAIN}
      - traefik.port=11334
      - traefik.docker.network=http_network
      - traefik.frontend.headers.SSLProxyHeaders=X-Forwarded-Proto:https
      - traefik.frontend.headers.STSSeconds=15768000
      - traefik.frontend.headers.STSIncludeSubdomains=true
      - traefik.frontend.headers.STSPreload=true
      - traefik.frontend.headers.frameDeny=true
      - traefik.frontend.headers.contentTypeNosniff=true
      - traefik.frontend.headers.browserXSSFilter=true
      - traefik.frontend.headers.contentSecurityPolicy=default-src 'self'; script-src 'self' 'unsafe-inline'; img-src 'self' data:; style-src 'self' 'unsafe-inline'; font-src 'self'; frame-src 'self'; object-src 'self'
      - traefik.frontend.headers.referrerPolicy=no-referrer-when-downgrade
    # extra_hosts:                          - Required for external database (on other server or for local databases on host without docker)
    #  - "mariadb:xx.xx.xx.xx"              - Replace with IP address of MariaDB server
    #  - "redis:xx.xx.xx.xx"                - Replace with IP address of Redis server
    ports:
      - "25:25"       # SMTP                - Required
      - "110:110"     # POP3       STARTTLS - Optional - For webmails/desktop clients
      - "143:143"     # IMAP       STARTTLS - Optional - For webmails/desktop clients
    # - "465:465"     # SMTPS      SSL/TLS  - Optional - Enabled for compatibility reason, otherwise disabled
      - "587:587"     # Submission STARTTLS - Optional - For webmails/desktop clients
      - "993:993"     # IMAPS      SSL/TLS  - Optional - For webmails/desktop clients
      - "995:995"     # POP3S      SSL/TLS  - Optional - For webmails/desktop clients
      - "4190:4190"   # SIEVE      STARTTLS - Optional - Recommended for mail filtering
    environment:
      - DBPASS=${DATABASE_USER_PASSWORD}       # MariaDB database password (required)
      - RSPAMD_PASSWORD=${RSPAMD_PASSWORD}     # Rspamd WebUI password (required)
    # - ADD_DOMAINS=aa.tld, www.bb.tld...      # Add additional domains separated by commas (needed for dkim keys etc.)
      - ENABLE_POP3=true                       # Enable POP3 protocol
    # - ENABLE_FETCHMAIL=true                  # Enable fetchmail forwarding
      - DISABLE_CLAMAV=true                    # Disable virus scanning
    # - DISABLE_SIGNING=true                   # Disable DKIM/ARC signing
    # - DISABLE_GREYLISTING=true               # Disable greylisting policy
    # - DISABLE_RATELIMITING=true              # Disable ratelimiting policy
      - RELAY_NETWORKS=<IP_ADDRESS>, <IP_ADDRESS>
      - ADD_DOMAINS=listes.${MAILSERVER_DOMAIN}
    #
    # Full list : https://github.com/hardware/mailserver#environment-variables
    #
    volumes:
      - ${VOLUMES_ROOT_PATH}/mail:/var/mail
      - ${VOLUMES_ROOT_PATH}/mailman/core/var/data:/opt/mailman/core/var/data
      - /mnt/docker/traefik/acme:/etc/letsencrypt/acme
    depends_on:
      - mailman-core
      - mariadb
      - redis
    networks:
      mail_network:
      http_network:
      mailman_network:
        ipv4_address: <IP_ADDRESS>

defaultEntryPoints = ["https","http"]

[api]
entryPoint = "traefik"
dashboard = true

[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
    entryPoint = "https"
  [entryPoints.https]
  address = ":443"
  compress = true
    [entryPoints.https.tls]
    minVersion = "VersionTLS10"
    cipherSuites = [
      "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",
      "TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305",
      "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
      "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
      "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
      "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
      "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256",
      "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256",
      "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA",
      "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA",
      "TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA",
      "TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA"
    ]
  [entryPoints.traefik]
  address = ":8080"
  [entryPoints.traefik.auth.basic]
  users = ["blabla"]

[acme]
email = "blabla"
storage = "/etc/traefik/acme/acme.json"
entryPoint = "https"
onHostRule = true
onDemand = false
  [acme.httpChallenge]
  entryPoint = "http"

[docker]
endpoint = "unix:///var/run/docker.sock"
domain = "tiralarc-grand-est.fr"
watch = true
exposedbydefault = false

This is not a bug. Hot-reload SSL certificates is not possible with postfix and dovecot so you need to find a way to restart your mail server when certificates are renewed, with inotify for example.

Thank you for your quick answer! Maybe I've missed it, but I think it should be a very good thing to add this advice in the README file?

This is not a bug. Hot-reload SSL certificates is not possible with postfix and dovecot so you need to find a way to restart your mail server when certificates are renewed, with inotify for example.

@hardware watchman, fswatch, modd, inotify, entr, inotify-tools, etc ?

@julien1619 If you have a working example using one of these tools, you can add it in the readme with a pull request.

# docker-compose -f mailserver/docker-compose.yml exec mailserver killall -HUP postfix

watchman watch /mnt/docker/ssl/certs/live

watchman trigger -j <<EOT
["trigger", "/mnt/docker/ssl/certs/live", {
   "name": "reload postfix updated mailserver letsencrypt",
   "expression": ["match", "*/fullchain.pem", "wholename"],
   "command": "/usr/local/bin/docker-compose -f mailserver/docker-compose.yml exec mailserver postfix reload"
}]
EOT

watchman trigger -j <<EOT
["trigger", "/mnt/docker/ssl/certs/live", {
   "name": "reload dovecot updated mailserver letsencrypt",
   "expression": ["match", "*/fullchain.pem", "wholename"],
   "command": "/usr/local/bin/docker-compose -f mailserver/docker-compose.yml exec mailserver doveadm reload"
}]
EOT

This solution should works :

Install incron apt-get install incron
Add root user in /etc/incron.allow
Create the following incron job with incrontab -e :

/mnt/docker/traefik/acme IN_MODIFY docker-compose -f /path/to/yml restart mailserver

Just to be sure: we really need to restart the whole container?
Maybe we can't just reload the configuration? I didn't test it, so I don't know.

You need to parse the acme.json file generated by Traefik and split it into pem files, only the run script at boot up can do that. And I'm not sure about handling soft reloading with s6 supervisor.

Yeah, I forgot about the acme.json, tricky.
Well, I didn't measure time, but, looks the parts who take more time to boot up are the rspamd and the clamav, right?
This is another subject, but maybe we can separate those to speed up the restart process? I'm just throwing ideas 😛
[]'s

The restart process is relatively fast, it takes a few seconds without clamav. If clamav databases mounted are up to date, the container is ready very quickly.

This is another subject, but maybe we can separate those to speed up the restart process ?

All services after postfix (dovecot, rspamd and clamav) are loaded asynchronously :
https://github.com/hardware/mailserver/blob/master/rootfs/services/_parent/run
I don't think we can go faster or I misunderstood what you meant by separate those to speed up the restart process.

The incron documentation needs to be changed, the traefik/acme/ folder can cause a cyclic restart when processing traefik/acme/dump.log.

hardware/mailserver#265

I see the issue, inotify only on acme.json.
If I change the command to :
/mnt/docker/traefik/acme/acme.json IN_MODIFY docker-compose -f /path/to/yml restart mailserver

Should work as expected, no ?


Fix exception bugs

This PR fixes a number of bugs that were introduced due to interactions between the JPackage upgrade and exception updates.

JPackage take over of JImports removed the error handling routines so they needed to be replaced.
The hidden constructor token was leaking into the args list for exceptions.
Using certain exceptions as base classes was triggering internal fatal errors.
The wrong constructor was called in some cases.

To fixed this the exception arguments are now generated internally.  And JPackage has a special method _handler so that JPackage can redirect exceptions to ImportError as needed.
(This will be checked once the release is merged)

@marscher I am going to have to push this one in without a review.  The bugs in the master need to be fixed.   Two of the PRs had an odd interaction that slipped through while was missed when azure was not functioning.   I need this one to continue development.  Sorry.
I did a review that outlined the changes.   If you see something retroactively we can back this out or use another PR to clean it up.


The first hero on the hero selection screen is missing in Descent in v0.81

Not sure I understand.  I can't see anything obviously wrong can you please provide more detail? Perhaps a screen shot?

It's always been like that, the empty selection is to clear the spot.
You can reopen if I have misunderstood.

Ah sorry, did not know that.


renaming: pushLocation -> pushEVSEStatuses

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

pushLocations is wrong name because only the EVSE statuses (no locations) are pushed.
renaming: pushLocation -> pushEVSEStatuses

PR not attached to the issue.
Just did it.


feat: Add suppress exceptions decorator

Q
A

Bugfix?
❌

Breaks BC?
❌

New feature?
✔

Issues
#...

Docs PR
spiral/docs#...

This request adds a decorator to suppress errors when making requests to the metrics service and logging them.
Use case
For example, metrics can be involved in payment transactions. The loss of a metric is less critical than the loss of a transaction, so the drop in the metric can be suppressed.
Client code example
$metrics = new \Spiral\RoadRunner\Metrics\SuppressExceptionsMetrics(
    new \Spiral\RoadRunner\Metrics\Metrics(\Spiral\Goridge\RPC\RPC::create('dsn'),
));

Codecov Report
All modified lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (3.x@2733196). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff           @@
##             3.x       #9   +/-   ##
======================================
  Coverage       ?   72.04%
  Complexity     ?       37
======================================
  Files          ?        3
  Lines          ?       93
  Branches       ?        0
======================================
  Hits           ?       67
  Misses         ?       26
  Partials       ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @ArtARTs36,
Thank you for the contribution.


excludeGlobs

Hello, Justin from Gifthealth here.
This is a nice service! We use minitest and if we wanted to achieve the same functionality we'd have to spend the time incorporating the parallel_tests gem. Captain saved us a lot of work!
The issue I have is we run our Rails system tests in a separate Github action job so need to exclude them from our non-system partitioned tests. I checked out the captain source code and ultimately it's using path#Match which wouldn't allow us to exclude via globs. If you could add a excludeGlobs key that would be fantastic!
We currently use a glob like this:
- test/{foo,bar,car}/**/*_test.rb

And forgot to add an entire directory and was excluding 128 test files for a month ... whoops!

Thank you for the feedback! We just released v1.17.0 with support for negative globbing.
Now when you define globs, you can prepend an ! to make the glob remove the matched files. The last glob that matches a file wins.
For example, if you had these files:
dir1/a.txt
dir1/b.txt
dir2/c.txt

and these globs:
- "*/*.txt"
- "!dir1/*.txt"
- "dir1/b.txt"

You would match dir1/b.txt, because it matches the third glob, and dir2/c.txt, because it matches the first glob and neither the second nor third globs match it, but you would not match dir1/a.txt, because it matches the second glob but not the third glob and the second glob is negated.


hello.txt file testing

Hi I added a file for testing, look out for it.

Make the changes with following.


Update jquery.timeago.js from 1.0.2 to 1.4.1.

The child of #1476.

@christopheschwyzer please review.

lgtm


TypeError: (0 , _url.pathToFileURL) is not a function

What is the problem
When I start the cmusd, it is fine;
but when I play my music, the program crash with error prompt
TypeError: (0 , _url.pathToFileURL) is not a function.
...
...

Environment
Platform: Ubuntu 18.04 LTS
NodeJS Version: 8.x
Soulution
After my research, I find that the version of NodeJS causing this problem ( function pathToFileURL is introduced in NodeJS 10 but I am using 8.x).
So, I update Node, delete all the cmusd build dependencies, rebuild;
then eventually, everything works fine.
Suggestion: I think we should remind others to use NodeJS 10 in the README.md

Good to know you resolved the issue.
We could do that
Or, I could polyfill that function.
I'll get to work on that soon.
Or you could open a PR to make it faster.


UML-962 - check state of user in login on actor.

Purpose
To Fix UML-962
Approach

Actor Triage page now detects if logged in and redirects to Lpa dashboard or lpa add accordingly.
follows the same approach as login code.
viewer home page has not changed

Learning
Checklist

[x] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] The product team have tested these changes

Coverage remained the same at 81.663% when pulling 7a16d7bbd338257c3221c75f877fb9c6941401f4 on UML-962-fix-loggedin-issue into 832e2b50f5aa8da79863d53b4fe873bfb33323a6 on master.


IndexPostRequest.Keys should use []Field instead of []string

Not urgent, but the Keys argument in IndexPostRequest uses dotted strings for fields, which does not work when "." is in the field name.
There coud be an api.Field type that is a []string or it could use field.Static from zq/pkg/field.

This will be important when we want to add the ability in Brim for users to create indexes.

This was done in #2931 by giving lake/index.FieldRule.Fields the type field.List.
https://github.com/brimdata/zed/blob/9e3960c4f5e052c65528fd90c57a71c397570074/lake/index/rule.go#L23-L28


Accented characters in emails are failing validation

This example email used to validate fine until ZF2 2.9.0<EMAIL_ADDRESS>As far as I can see, it's supposed to be valid according to RFC 6532 http://stackoverflow.com/a/760151/1381550
In theory it should not fail validation, and what was brought in ZF2 2.9.0 is a breaking change.
Was this on purpose?

Validator does support internationalized local part, previously it was passing due to IDNA false positive bug.

@Xerkus but if the validator yields false for them, it means it clearly doesn't support them.

sorry,  that was a typo. "does not"*
internationalization brings in support for utf characters where there were
none, which complicates things a lot
I will try to add proper support for them, will need to do research on the
topic
--
Aleksei Khudiakov
Developer at Roave LLC
https://roave.com
On Apr 6, 2017 18:39, "Attila Szeremi"<EMAIL_ADDRESS>wrote:

@Xerkus https://github.com/Xerkus but if the validator yields false for
them, it means it clearly doesn't support them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-validator/issues/155#issuecomment-292107386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsTUkZlB4vwRuV2C1igcAY2Ht7WCNh6ks5rtKS6gaJpZM4MkBba
.

This repository has been closed and moved to laminas/laminas-validator; a new issue has been opened at https://github.com/laminas/laminas-validator/issues/21.


[TA] Added RecognizeCustomEntities Functionality

This PR contains the implementation of the Recognize Custom Entities API interface as explained in #24054

@maririos @mssfang @deyaaeldeen Thank you all for your great review! I've made all the changes, I've also generated the code based on the new swagger as @mssfang told me.
Since @AhmedLeithy rebased his other PR I will wait for his to get merged, to not rebase 2 times.

@ZulaMostafa after you make changes to samples that use snippets, don't forget to run eng\scripts\Update-Snippets.ps1 textanalytics so the snippets are updated everywhere and you don't get build breaks like this one:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1147189&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f

I think we are good to go now!

I think we are good to go now!

Almost. Still need to delete file sdk/textanalytics/azure.ai.textanalytics/src/JobManifestTasks.cs

I think we are good to go now!

Almost. Still need to delete file sdk/textanalytics/azure.ai.textanalytics/src/JobManifestTasks.cs

My bad, I read your comment from the mail so I thought you was talking about session records. Anyways, I deleted the weirdo file :p

/azp run net - textanalytics - ci


Allow only one team for each user

Some existing functionality assumes that a user can be linked to multiple teams (see #92). This ticket reviews current functionality that is based on this assumption and will make changes to support only one team per user.
Server Tasks (app_server.py)

Remove /changeTeamID
Remove /removeTeamID
Remove /getTeams

HTML Tasks

base.html:

Remove Line 123 (link to change research team)
Remove Lines 159-166 (check for team ID)
Remove Lines 136-154 (popup to change research team)

application_main.js: Remove Lines 1-27 (loads and submits popup)

Changes made.


Fixed bug with numeric value of font-weight

The line edited cause value of font like italic 500 36px Aria to treat 500 as fontSize instead of font-weight. Edited to handle such values.
Is needed a Grunt :)

Oh great. I didn't think about font weight. Thanks


======== Exception caught by widgets library ======================================================= The following assertion was thrown building MediaQuery(MediaQueryData(size: Size(360.0, 732.0), devicePixelRatio: 3.0, textScaleFactor: 1.0, platformBrightness: Brightness.dark, padding: EdgeInsets.zero, viewPadding: EdgeInsets.zero, viewInsets: EdgeInsets.zero, alwaysUse24HourFormat: false, accessibleNavigation: false, highContrast: false, disableAnimations: false, invertColors: false, boldText: false, navigationMode: traditional, gestureSettings: DeviceGestureSettings(touchSlop: 8.0), displayFeatures: [])): 'package:flutter/src/widgets/framework.dart': Failed assertion: line 4606 pos 14: 'owner!._debugCurrentBuildTarget == this': is not true.

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

Logs

self duplicate of https://github.com/flutter/flutter/issues/114255


Test docker build job

Signed-off-by: Asmund Tokheim<EMAIL_ADDRESS>*Issue number of the reported bug or feature request: #56
Describe your changes
This introduces a root level dockerfile to build a docker image along with github actions to release the container. Just like the author of #56 I'd really need a docker image to be published in order to make use of this very promising project. The docker job is mostly based on the plain example in https://github.com/docker/metadata-action, and should push versioned images whenever you tag the repo. Still there's a lot of customization options you might want to do, so merely a suggestion from me.
Testing performed
I've tested the new dockerfile locally to be working. I also tested the github action on my branch, but haven't published any images, as that seemed like I was overstepping. You can see the result in https://github.com/tokheim/amqpprox/runs/4061595492
Additional context
Before merging you will need to change the image name, and add DOCKERHUB_USERNAME and DOCKERHUB_TOKEN secrets.

Thanks for the PR Asmund. I agree that having a published Docker image (or any kind of published, built, artifact is going to make it easier for people to use this project.
We never asked around internally about using Dockerhub but we'll do that now.
One unanswered question here is how the docker image would allow configuring of the amqpprox instance. Did you have any thoughts on how this would work for you?

So I hope to experiment a bit on how we could make use of this. But we would likely want to run it in kubernetes and want some way to dynamically change config across all the amqpproxies.
What I'd hope would work is to run amqpprox in one container, and some project  that controls the proxy through amqpprox_ctl in another container (sidecar pattern). The two containers would communicate by both mounting a shared volume like https://stackoverflow.com/questions/45637587/connection-between-docker-containers-via-unix-sockets. TCP sockets would be a more standard docker-pattern and allow a bit more flexibility in the setup, but I'm still hopeful this should work well. What do you think?
By the way, you shouldn't feel any obligation to make use of this PR, I just wanted to do whatever I could to speed up the resolution for #56


clarify that k3s-root is not pure "apache-2" licensed

My understanding is that the license declaration is just for the k3s-root specific part, not for the embedded components like busybox. we could be more careful and specify GPLv2?

The stuff in the repo is covered by the license; I don't think we're making any claims about the software produced by running the build scripts?


fix: check type(owner) == "string" to avoid https://github.com/foo/bar, fixes #71

lgtm. thanks for this PR! 👍


Add sensu_cluster_member type

Pull Request Checklist

Description

Add a custom type that can add cluster members.
Related Issue

Part of #901
Motivation and Context

sensuctl supports adding members.  The members won't actually be fully added until the new member is started with the proper configuration.  The necessary configuration is printed by this custom type in the info output which comes from output of the sensuctl command to add the member.
How Has This Been Tested?

Added new way to run acceptance tests that spawn 3 backend servers.  Using only 2 caused issues (see https://github.com/sensu/sensu-go/issues/1890).  When BEAKER_sensu_cluster is yes or true the cluster acceptance tests are run.
General

[x] Update README.md with any necessary configuration snippets

[x] Tests pass - bundle exec rake validate lint spec

@treydock please squash and rebase and this should pass tests once #948 is merged.

@ghoneycutt Squashed and rebased.  Updated README with instructions on how to setup a cluster and also how to add a member to an existing cluster.

This strangely had an error with amazon linux 2018.3. Perhaps the service just took too long to start?

The docs assume that two backends are running, which I thought is not good since you need one or three for quorum. If you have only two does is put the cluster is a not-good state? Could you give me a step by step in the README of why you have to setup one node, then can add more.

Added a few bits of text to hopefully make it clear that adding members to an existing cluster differs from setting up a cluster from scratch.

@treydock Could you please rebase. Is this ready to merge?

@ghoneycutt rebased and squashed.

I'd say ready for merge.  Open issue upstream but not sure would impact this PR since issue I opened was going from one to two node cluster and sensuctl hanging.  That's why acceptance tests go from two to three node cluster, seems keeps quorum.


Let's make it universal rc/telemetry/video transmission system

I have a crazy idea that it would be nice to make another branch of opensolo to create something like ligtbridge / Cuav Hacklink
Hardware: only solo link board and controller link board (no buttons, lcd screen, etc.)

ppm input pin (RC control) on controller board
wifi hotspot on controller board (to connect to Tower / QGroundcontrol for video and telemetry)
telemetry input on solo link board
video input on solo link board (hdmi)

Software:

simple video downlink, telemetry and rc passthrough + failsafe
removed other scripts / programs (smart shots, display control, buttons control, etc.)

It should work like CUAV Hacklink (https://www.banggood.com/en/CUAV-HACK-LINK-2_4G-UAV-Digital-Link-System-HDMI-PPM-Mavlink-Data-Transmission-For-PIXHACK-PIXHAWK-p-1130256.html):

you connect controller link to GCS via WIFI (QGroundcontrol / Tower)
rc ppm/sbus signal is transmitted to drone over WIFI from external transmitter connected to controller board
video can be watched i GCS in widget window (solo video stream or custom UDP)

I would love to do it myself but current software has so many components and pins on controller link board are not documented :-(. Plus I'm not a very good programmer.

The Cuav Hacklink uses the same source code as sololink.

PPM feature is really essential for DIY people. There is not much of rc control channels on solo controller makes it impossible  to use it for DIY project.
CUAV Hacklink supports ppm and their software and hardware is open :
https://github.com/cuav

From what I understand we only have 2 gpio pin 19 and 21 that are used for switching usb devices. Other then that I dont know what could be use to output the ppm signal.

@FLYBYME  Is it possible to configure current dsm pin for cppm or usb select gpio? The idea is to have sololink as generic data and video link for any kind of transmitter with cppm like Taranis and any kind of Pixhawk based FC with any kind of firmware (rover,vtol, plane ....). In these cases those USB pins will not being used at all.  Right now I am doing the same but I am stock with Solo transmitter with potentially just 8 channels over DSM.

DSM goes over serial and I dont think you can manipulate the tx or rx pins in the way you need to for ppm.

Then at least sbus could be posible :)

issues list is for issues/bugs, not feature requests.  If someone plans to actually implement anything discussed here, fabulous, and please raise a PR for it, we'd love to see .

Where should we me making feature requests?


Fixes/ci failures

Ideally the drbg should come from the application. This requires the corresponding changes in the other crypto layers. Fixing this in a quick way right now for CI to continue passing

I do not understand the crypto layer, so I trust your judgement here.

I'll need an 'approve' to merge

I do not understand the crypto layer, so I trust your judgement here.

I'll need an 'approve' to merge

oh you've already approved, strange, I still can't merge it

I do not understand the crypto layer, so I trust your judgement here.

I'll need an 'approve' to merge

oh you've already approved, strange, I still can't merge it

The PR says you need an approval from reviewers with write access.


R1.10 rocm release branch

Don't Merge, this PR is to kick off the CI and compare between r1.10-rocm with the r1.10 branch.

@sunway513 has there been a CI test set for this PR?

jenkins: retest this please

jenkins:  retest this please

jenkins: retest this please

FYI - We currently can't do PR builds off of other branches, but the r1.10-rocm branch is being built every night here:  http://<IP_ADDRESS>:21096/job/tensorflow-upstream-rel1.10-nightly/
Here's the summary of job 17:
ERROR: /workspace/tensorflow/contrib/eager/python/examples/densenet/BUILD:5:1: file '//tensorflow:tensorflow.bzl' does not contain symbol 'cuda_py_test' (did you mean 'tf_py_test'?)
ERROR: /workspace/tensorflow/contrib/eager/python/examples/densenet/BUILD:17:1: name 'cuda_py_test' is not defined
DEBUG: /home/jenkins/workspace/tensorflow-upstream-rel1.10-nightly/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/pkg/pkg.bzl:224:17: @//tensorflow/tools/lib_package:common_deps: you provided a non dictionary to the pkg_tar `files` attribute. This attribute was renamed to `srcs`. Consider renaming it in your BUILD file.
DEBUG: /home/jenkins/workspace/tensorflow-upstream-rel1.10-nightly/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/pkg/pkg.bzl:224:17: @//tensorflow/tools/lib_package:cheaders: you provided a non dictionary to the pkg_tar `files` attribute. This attribute was renamed to `srcs`. Consider renaming it in your BUILD file.
ERROR: package contains errors: tensorflow/contrib/eager/python/examples/densenet
DEBUG: /home/jenkins/workspace/tensorflow-upstream-rel1.10-nightly/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/pkg/pkg.bzl:224:17: @//tensorflow/tools/lib_package:eager_cheaders: you provided a non dictionary to the pkg_tar `files` attribute. This attribute was renamed to `srcs`. Consider renaming it in your BUILD file.
DEBUG: /home/jenkins/workspace/tensorflow-upstream-rel1.10-nightly/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/pkg/pkg.bzl:224:17: @//tensorflow/tools/lib_package:clib: you provided a non dictionary to the pkg_tar `files` attribute. This attribute was renamed to `srcs`. Consider renaming it in your BUILD file.
DEBUG: /home/jenkins/workspace/tensorflow-upstream-rel1.10-nightly/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/pkg/pkg.bzl:224:17: @//tensorflow/tools/lib_package:clicenses: you provided a non dictionary to the pkg_tar `files` attribute. This attribute was renamed to `srcs`. Consider renaming it in your BUILD file.
ERROR: Skipping '//tensorflow/python/distribute:distribute_coordinator_test': no such package 'tensorflow/python/distribute': BUILD file not found on package path
WARNING: Target pattern parsing failed.
[...]
Executed 533 out of 533 tests: 533 tests pass.
All tests passed but there were other errors during the build.

FAILED: Build did NOT complete successfully


--dirty does not work on Windows

Duster appears to make use of the Project & GitPathsRepository classes from Laravel Pint to build up the array of 'dirty' files from Git.
However as Duster pins Laravel Pint to version 1.5 it does not include the fix from Pint which resolves the --dirty flag working on Windows due to the differences in slashes in directory paths.
https://github.com/laravel/pint/pull/150
https://github.com/laravel/pint/releases/tag/v1.6.0
Unfortunately this doesn't look like a straight forward change from 1.5 to 1.6 due to the fact that Laravel Pint requires both PHP 8.1 (at a minimum) and Laravel Zero 10.
Unsure whether it would be easier in the short term to bring the GitPathRepository class into Duster itself to resolve the issue until such a time that Duster is updated in line with Laravel Pint.

Yeah, that makes sense.  I've also considered updating Duster to Zero 10 and downgrading PHP when releasing.

@Rigby90 I just released version 2.0, which drops support for older versions of PHP to allow Duster to update Pint.


Restructure Repo w/ Go Modules and Add Darwin arm64 support

Issue #, if available:
https://github.com/aws/session-manager-plugin/issues/1
https://github.com/aws/session-manager-plugin/issues/9
Description of changes:

Move go src and repo structure to a more conventional and modern go structure

Move any main packages to the top-level cmd dir
Upgrade go build version to 1.16
Use go modules (using the repo as the module name) and remove all checked-in vendor deps
Remove unmaintained uuid lib and replace w/ google/uuid

Support Darwin arm64 builds and packaging
Make bash packaging scripts safer by exiting if an error occurs w/ set -euo pipefail
Add proper github PR template w/ correct license
Add github actions workflow w/ checkstyle and quick-test targets to check PRs automatically

Testing:

make checkstyle quick-test PASSED
make  build-darwin-arm64 package-darwin-arm64 PASSED
Built binary and tested connecting an ec2-instance. PASSED

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+5000 files changed, there might be a problem somewhere? just wondering.

@cguertin14 Hi! The 5,000 files changed are mainly removing the vendor (dependency source code) checked in to this repo in favor of using Go modules to pull dependencies at compile time.

Any chance of this getting updated with resolved conflicts and merged?


Contribute colors instead of settings

There is a way to contribute colors in vscode extension:
https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributescolors
That will allow for users to change colors per theme and hot reload of colors.
You can also set it to theme default color (error/warning - some themes don't use red/orange).

@usernamehw Do you close this on purpose??
I am looking to open issue for hot reload colors, but this issue already contains it, so not sure if I missed something.

Don't really remember ... I forked it and used color contributions in local version.

Hey @usernamehw - how do I access the theme color (e.g. "errorLens.errorColor") via an API? I've added things as a color contribution, but I'm not sure how to get these now.

@phindle like that:
const errorColor = new vscode.ThemeColor("errorLens.errorColor");

You should probably create issue in vscode docs if it's not obvious.


RSS feeds

This is just a reminder to enable RSS feeds at some point.
I'm not sure how they are currently generated, but it would be great if we had feeds for news, data uses, events, and perhaps a feed combining all of them.
To be able to better track traffic generated from RSS readers, it would be great if the links in feeds could include UTM paramaters for Google Analytics.

I believe these are all driven of ES now and Fede have already implemented them. But they aren't on prod yet it seems? See https://github.com/gbif/portal16/issues/466

The rss feeds are in place but not yet added to news and datause.

Could we have an official note of the actual endpoints of all the feeds available? I can make a lot of educated guesses, but it would nice to have on record. Thanks!

Reopening this because the news and datause feeds don't contain correct links to posts, e.g.
<item>
      <title>Top tip: The GBIF network: country by country, region by region</title>
      <description>The GBIF node community is the heart and soul of GBIF's activities at national, regional and global scales, and the new [GBIF network](/the-gbif-network) page provides a fresh take on navigating essential details about our Participant countries and organizations, as well as non-member countries.

The map clearly focuses on GBIF's national members. Click on any of the coloured countries, and you'll get a quick abstract showing the main national contacts and counts of its endorsed data publishers, occurrence datasets and records. But selecting a greyed-out, non-member country will also highlight any available data resources.

Below the map, you'll find contact information for the elected representatives of the global nodes community and a complete list of all GBIF Participants (sortable by any column). But for member and non-member nations alike, the map on the network page now provides the most direct path to the detailed information pages we maintain for all of the world's countries, islands and territories (some tips on those will follow later this week). Just follow the links embedded in the country names at the top of any pop-up summary.

The network page also provides quick access to GBIF's six regional networks, and the tabs above the map show the way. [Africa](/the-gbif-network/africa), [Asia](/the-gbif-network/asia), [Europe](/the-gbif-network/europe), [Latin America](/the-gbif-network/latin-america), [North America](/the-gbif-network/north-america) and [Oceania](/the-gbif-network/oceania)â€”click your pick, and the map will zooms to display the region. The rest of the page refreshes as well, displaying contact information for the region's node representatives and a Participant list refreshes to show the region's members.

Even in this simple presentation, the addition of this regional view fulfills a long-standing request from the nodes community to represent their largely self-organized and self-organizing activities. We're eager to hear suggestions on how to build on this view and display additional information consistently across all regional pages. As with all feedback, just click the chatbox in the upper right of every page.</description>
      <pubDate>Tue, 29 Aug 2017 12:01:16 GMT</pubDate>
      <dc:date>2017-08-29T12:01:16Z</dc:date>
    </item>

RSS feeds are also usually HTML, but I realize that might be tricky.

It is now deployed to dev:
https://www.gbif-dev.org/resource/search?contentType=news
https://www.gbif-dev.org/resource/search?contentType=dataUse
The RSS links are XML

It seems that the XML  still don't have a proper link to the actual content item they represent?
Take the first item in https://api.gbif-dev.org/v1/newsroom/news/rss, for example. It contains no links, but should link to https://www.gbif-dev.org/news/3OjHxpWdlKQ0cAWeuMgCek/top-tip-sorting-out-top-species-in-search-results
My comment about HTML was imprecise. Of course the RSS feeds are XML, however, usually the text contained in the main body, i.e. "description" is HTML or plain-text.

Here's another example comparing the old Drupal-generated to the new one:
OLD:
      <item>
    <title>iDigBio joins GBIF as organizational member</title>
    <link>http://www-old.gbif.org/news/83368/idigbio-joins-gbif-as-organizational-member</link>
    <description>
iDigBio, which coordinates projects to digitize natural history collections in the United States with funding from the National Science Foundation, has become the latest non-country Participant in the GBIF network.

Formally known as Integrated Digitized Biocollections and based at the Florida Museum of Natural History, iDigBio is a collaboration between the University of Florida and Florida State University and serves as the central resource for the Advancing Digitization of Biodiversity Collections programme. iDigBio’s efforts make information about biological and paleontological specimens in U.S. research collections freely open and available online, improving research and outreach to scientists, researchers, students, educators and other user communities for the benefit of all sectors of society.

"Enhancing our relationship with GBIF will greatly increase the exposure and information content of biodiversity data”, said Larry Page, Director of iDigBio. “We hope that joining GBIF as a Participant will lead to improved environmental research and decisions related to habitat loss, climate change and other factors impacting biodiversity."

In addition to promoting uses of collections data by scientific and stakeholder communities, iDigBio also develops and shares digitization standards, workflows and best practices. These efforts rely on iDigBio’s own Thematic Collections Networks to connect U.S.-based institutions to digitize specimens and integrate biocollections resources and tools and support a growing constituency of collections partners worldwide. The ongoing Darwin Core Hour webinar series, for instance, provides data publishers everywhere with practical skills and approaches for making biodiversity data more accessible, interoperable and reusable across many research domains.

“iDigBio is important to the GBIF network not just as a national hub for digitizing vouchered natural history collections, but also as a key partner that shares its knowledge resources internationally,” said Donald Hobern, Director of the GBIF Secretariat. “Its emphasis on developing training and standards makes an enormous contribution toward establishing the integrated, interconnected data needed to create a virtual natural history collection for the 21st century."

 </description>
     <pubDate>July 24th, 2017</pubDate>
 <dc:creator />
 <guid isPermaLink="false" />
  </item>

NEW:
 <item>
      <title>iDigBio joins GBIF as organizational member</title>
      <description>[iDigBio](https://www.idigbio.org/), which coordinates projects to digitize natural history collections in the United States with funding from the [National Science Foundation](http://www.nsf.gov/), has become the latest non-country Participant in the GBIF network.Â Â

Formally known as Integrated Digitized Biocollections and based at the [Florida Museum of Natural History](https://www.floridamuseum.ufl.edu/), iDigBio is a collaboration between the [University of Florida](http://www.ufl.edu/) and [Florida State University](https://www.fsu.edu/) and serves as the central resource for the Advancing Digitization of Biodiversity Collections programme. iDigBioâ€™s efforts make information about biological and paleontological specimens in U.S. research collections freely open and available online, improving research and outreach to scientists, researchers, students, educators and other user communities for the benefit of all sectors of society.

"Enhancing our relationship with GBIF will greatly increase the exposure and information content of biodiversity dataâ€, said Larry Page, Director of iDigBio. â€œWe hope that joining GBIF as a Participant will lead to improved environmental research and decisions related to habitat loss, climate change and other factors impacting biodiversity."

In addition to promoting uses of collections data by scientific and stakeholder communities,Â iDigBio also develops and shares digitization standards, workflows and best practices. These efforts rely on iDigBioâ€™s own [Thematic Collections Networks](https://www.idigbio.org/content/thematic-collections-networks) to connect U.S.-based institutions to digitize specimens and integrate biocollections resources and tools andÂ support a growing constituency of collections partners worldwide. The ongoing [Darwin Core Hour webinar series](https://www.idigbio.org/content/darwin-core-hour-webinar-series), for instance, provides data publishers everywhere with practical skills and approaches for making biodiversity data more accessible, interoperable and reusable across many research domains.

â€œiDigBio is important to the GBIF network not just as a national hub for digitizing vouchered natural history collections, but also as a key partner that shares its knowledge resources internationally,â€ said Donald Hobern, Director of the GBIF Secretariat. â€œIts emphasis on developing training and standards makes an enormous contribution toward establishing the integrated, interconnected data needed to create a virtual natural history collection for the 21st century."</description>
      <pubDate>Mon, 24 Jul 2017 14:37:41 GMT</pubDate>
      <dc:date>2017-07-24T14:37:41Z</dc:date>
    </item>

Notice that the link to the post is missing.

@fmendezh could you take a look on this?

Note the disappearance of this line, too:

http://www-old.gbif.org/news/83368/idigbio-joins-gbif-as-organizational-member

My RSS feed reader is sending me to the first link in the text, which is definitely not the intent—we want them to go to the link for the news/event/whatever.

Was just reminded about this one while going through my own RSS feeds:
The gbif.org RSS feeds still don't contain links to the individual posts, effectively making them useless.

/v1/newsroom/news/rss looks good for most parts, the most recent entries at least. There are still a few odd ones, e.g.
 <title>Fernandes becomes second consecutive Brazilian to win GBIF Young Researchers Award</title>
      <link>https://www.gbif.org/dataset/914c3b86-f2a1-4d5e-b343-b2597b9d4542</link>
...
 <title>Escribano becomes first Spaniard to win GBIF Young Researchers Award</title>
      <link>https://www.gbif.org/dataset/dfddad59-5bc5-4e35-8b35-334eed43bba9</link>
...
<title>Job opportunities for software developers</title>
      <link>https://assets.contentful.com/uo17ejk9rkwj/6TXmNMw8KIAky8I6as4ueU/ad0215afb68a34be7590f0b40ec51419/Advert_for_GBIF_Software_Developer_2_-_2017.pdf</link>

It seems that items with primaryLink uses this instead of the link to the news item? To be clear, rss feed items should always link to the news items themselves, not any links inside the news items.
The same appears to be the case for /v1/newsroom/uses/rss, only the use of primaryLink here is much more frequent and thus they are all linked to the original papers, not the dataUse items.

Every time I post a new data use story on gbif.org, I'm reminded that the RSS feed doesn't link correctly to the post, but rather to whatever primarylink is in that post, e.g.
<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:dc="http://purl.org/dc/elements/1.1/" version="2.0">
  <channel>
    <title>GBIF news feed</title>
    <link>http://www.gbif.org/newsroom/news/rss</link>
    <description>GBIF News</description>
    <language>en</language>
    <dc:language>en</dc:language>
    <item>
      <title>Port Stephens, Australia - a sea hare haven?</title>
      <link>https://doi.org/10.1080/13235818.2016.1207280</link>   <----- SHOULD be link to post on gbif.org
      <description>
Sea hares are heterobranch sea slugs of the Aplysiidae family with large ear-like rhinophores, responsible for the vernacular of the group. Members of this globally distributed family usually only live up to one year, while producing up to 180 million eggs, and in some species growing to a size of up to two kilograms.

In a recent study, researchers investigated and documented the diversity of aplysiid diversity in Port Stephens, NSW, Australia, home to more species than anywhere else in the world. With the most diverse algal flora in the world, the waters of southern Australia provide the ideal living conditions for sea hares whose diets consists of marine plants- mostly algae.

While reviewing the taxomomy and nomenclature of the group, the authors describe the morphology and distributions of 16 species found in the region, including the first observation of Petalifera sp. in Australian waters. Highlighting the global significance of Port Stephens for Aplysiidae and an obvious target for further sea hare studies, this study forms a baseline for detecting changes to aplysiid diversity in future, changing climates.
</description>
      <pubDate>Fri, 04 May 2018 09:01:11 GMT</pubDate>
      <guid>https://doi.org/10.1080/13235818.2016.1207280</guid>
      <dc:date>2018-05-04T09:01:11Z</dc:date>
    </item>

Could we pls fix this?

Hi guys.
I've just noticed that Altmetric pulls our RSS feed for data use as mentions of paper. Because our links are wrong, people are taken directly to the paper and NOT to our website, for example:
https://www.altmetric.com/details/18186157/blogs
"Climate change - a double-edged sword for invasive species?" is the title of my post, but if you click the link, you're taken to the paper landing page.
Pretty PLEASE with sugar on top - can we fix this?

https://github.com/gbif/content-ws/blob/master/src/main/java/org/gbif/content/utils/ConversionUtil.java#L53
entry.setLink(getNestedField(source, "primaryLink", "url", locale)
                    .orElseGet(() -> altBaseLink + '/' + searchHit.id()));

I'm guessing this should simply set the link to altBaseLink + '/' + searchHit.id()) and ignore the first line. For Data use and news we want to link to our own pages. For events it is acceptable to link to our own instead of the primaryLink (external event pages).
The only place where doing this would be odd is id we added RSS feed to tools, and even then it would still work ok. As far as I can see.
@thomasstjerne and @fmendezh you might see something I haven't? Else I suggest:
entry.setLink(altBaseLink + '/' + searchHit.id()); //assuming altBaseLink is the urls we use aka tool/datause/news etc

As a work-around for this, I'm currently avoiding using primaryLink in data use items...

All rss feeds and calendar cars (vCards) point to the GBIF event or news


Add annotations for done tasks

In this PR:

Add annotations for done tasks

Lukker denne siden mvp.feature ikke lenger brukes


perf: tree-shake spinners

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


BUG: jobs-to-start was not passed

@eldeveloper, can you review?

👍 this looks good, but would need to test that it indeed is working.

I don't know how to write one to assert that without doing some terrible terrible things with travis...

For the record, we tested this by monitoring the CPU time vs walltime of a job submission that used jobs > 1.


Emacs lisp docstring too dark in doom-molokai theme

It looks like this, on line 108:

It's even worse when flycheck highlights it with a warning:

The text becomes readable when it's in a marked region, however.

Along the same lines, I noticed that text becomes black on black in helm find files when simultaneously marked and active.
Before (Makefile is active and unmarked):

After (log is active and marked):

It seems that the docstring issue is resolved when solaire-mode is installed alongside the doom-molokai theme. The second issue isn't, though.

I've pushed fixes for these issues. Let me know if they persist.

The second issue is solved, but the first one hasn't changed. It's still unreadable in daemon emacs but ok in non-daemon emacs.

Yes, I could reproduce it, and I've found the culprit. It had to do with terminal-emacs translating the 24-bit color of font-lock-doc-face to an 8-bit color (for the terminal) incorrectly. A slight change nudged it in the right direction. It should be fixed now.

The more I tussle with this issue, the more it seems to not be doom-themes' fault.
There seem to be four scenarios when dealing with daemon Emacs:

You start GUI Emacs and use it: emacs
You start terminal emacs and use it: emacs -nw
From GUI Emacs you start a server with (server-start), then:
a. Open a GUI frame with emacsclient -c
b. Or open a tty frame with emacsclient -nw
You spawn an emacs daemon (emacs --daemon) and:
a. Open a GUI frame with emacsclient -c
b. Or open a tty frame with emacsclient -nw

What I've discovered is scenarios 1, 2 and 3a/3b work just fine with doom-themes, but 4a/4b do not.
In 4a/4b new frames seem to forget whether they are tty or a GUI frames, confusing Emacs' theme display engine and causing it to treat all frames as tty frames. Thus, you get 8-bit colors in GUI frames (some 16-bit colors bleed through because I specify no 8-bit fallbacks for them). This is what causes the problems you're seeing.
In any case, to fix this I've had to add something like this to my emacs.d:
(defun my-init-theme (&optional _frame)
  (load-theme 'doom-one t))

(defun my-reload-theme-in-daemon (frame)
  (when (or (daemonp) (not (display-graphic-p)))
    (with-selected-frame frame
      (run-with-timer 0.1 nil #'my-init-theme))))

(add-hook 'after-make-frame-functions #'my-init-theme)
(add-hook 'after-make-frame-functions #'my-reload-theme-in-daemon)

;; for GUI sessions
(my-init-theme)

What it does is forcibly reload the theme when a new frame is created from a daemon or in the terminal. It isn't ideal, but it works.
Give that snippet a try and see if that fixes the problem.

Ah, that does it. Thank you so much! :+1:
Note: Any settings that override doom-theme's settings must be put in my-init-theme after (load-theme 'doom-xxx t) in order for them to take effect. I put some linum-related settings in there.

For anyone like myself who's been dealing with this issue, and falls under workflow scenario 4a like myself, I finally found a solution which addresses the load-on-every-frame issue by using the solution from this comment. I hope this helps someone. I for one can now sleep at night.


Default macos

Hi, I did notice your extension by default searches for new releases on claudiodekker/ungoogled-chromium-macos.
Imho I think it could be better if that could be setted automatically based on the operating system or maybe redirect to the option page so the final user will be aware of the setting.
Thank you.
Davide

Hey Dave,
That's not a bad idea. I'll consider adding this once I find some time to pick this back up!
With that said, if you know how to do this yourself and wouldn't mind contributing, feel free to PR a change to auto-open the settings page on installation!


KYLIN-4974 Kylin does not handle fucntion CURRENT_TIME().

Proposed changes
Add time serializer.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 7080

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
13 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.005%) to 28.089%

Files with Coverage Reduction
New Missed Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java
1
81.08%

server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java
1
47.62%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java
1
56.82%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
5
77.81%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
5
66.67%

Totals

Change from base Build 7067:
-0.005%

Covered Lines:
26710

Relevant Lines:
95092

💛  - Coveralls

Codecov Report

Merging #1637 (b9b2f4f) into kylin3 (fef7803) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             kylin3    #1637      +/-   ##
============================================
- Coverage     25.12%   25.11%   -0.01%
+ Complexity     6775     6772       -3
============================================
  Files          1518     1518
  Lines         95184    95185       +1
  Branches      13294    13294
============================================
- Hits          23917    23910       -7
- Misses        68888    68892       +4
- Partials       2379     2383       +4

Impacted Files
Coverage Δ

...he/kylin/metadata/datatype/DataTypeSerializer.java
63.41% <100.00%> (+0.91%)
:arrow_up:

...ream/core/storage/columnar/ColumnarStoreCache.java
50.00% <0.00%> (-5.69%)
:arrow_down:

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0.00%> (-5.41%)
:arrow_down:

.../apache/kylin/tool/query/ProbabilityGenerator.java
71.05% <0.00%> (-5.27%)
:arrow_down:

...va/org/apache/kylin/tool/query/QueryGenerator.java
80.00% <0.00%> (-1.12%)
:arrow_down:

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
70.21% <0.00%> (-0.92%)
:arrow_down:

...he/kylin/job/impl/threadpool/DefaultScheduler.java
75.86% <0.00%> (+2.29%)
:arrow_up:

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
66.15% <0.00%> (+2.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef7803...b9b2f4f. Read the comment docs.

LGTM


Remove NIO umbrella target

The NIO target is only an umbrella for NIOCore, NIOPosix and NIOEmbedded. Its only purpose is to guarantee backwards compatibility. In the next major version of NIO, we should remove it completely.
We will also need to remove any remaining dependencies on it, like NIOHTTP1 and NIOWebSocket. They can't yet remove the dependency because users of NIOHTTP1  and NIOWebSocket might depend on NIO implicitly.

@dnadoba can we close this? See above


Add attributes section

I want to merge this change because it adds attributes section to the new dashboard.
Screenshots

What if adding a new value was as easy as clicking the last row that says "New value" in grey?

Could be a simple text input field with a submit button that can be triggered by hitting 'enter' and that doesn't lose focus when hit 'enter' (submit).
So we can add quickly all the values we want without ever touching the mouse.


issue 11: setting up the vr_room

hello everbody :)
the name of the pull request sums up pretty much all i did (which was very little compared to issue 12).
i set up the vr room in "zdd_adventure.py" by adding it to the ground floor and referring to the next important file, "zdd_rooms.py".

i have already merged the vr room and nice work


Use crates.io libc.

Using a different version can cause annoying conflicts when used with packages that do use the crates.io version, like gl-rs:
 expected `extern "C" fn(u32, *const libc::types::common::c95::c_void) -> u32`,
    found `extern "C" fn(u32, *const libc::types::common::c95::c_void) -> u32`
(expected enum `libc::types::common::c95::c_void`,
    found a different enum `libc::types::common::c95::c_void`) [E0308]

I'm not sure if a catchall version is appropriate, though.

@bfops you'll want to remove #![feature(libc)] from src/lib.rs:4 and sdl2-sys/src/lib.rs:3

@alexandercampbell Ah right, thanks. Done!

Cool, cheeeeeeers :)


Installation using vcpkg, detailed definition of evp_md_ctx_st is missing

#include <stdio.h>
#include <openssl/evp.h>

int main()
{
    OpenSSL_add_all_digests();

    EVP_MD_CTX mdctx;
    unsigned char md_value[EVP_MAX_MD_SIZE];
    unsigned int md_len;

    const char* _buf = "123";
    EVP_DigestInit(&mdctx, EVP_sha256());
    EVP_DigestUpdate(&mdctx, (const void*)_buf, 3);
    EVP_DigestFinal(&mdctx, md_value, &md_len);
}

The detailed definition of the evp_md_ctx_st structure is in crypto / evp / evp_locl.h, however, the compiled vcpkg header file does not have crypto / evp / evp_locl.h

EVP_MD_CTX *mdctx = EVP_MD_CTX_new();

emmm didn't pay attention, it should be created this way, not defined from the structure


DNS resolver does not account for timing

Summary
Upon specifying the -r flag, the retryResolve function is called whenever there is a need to resolve the hostname again. This can be useful when the target is geographically distributed and when there are GSLBs involved. The function is defined here: https://github.com/pouriyajamshidi/tcping/blob/2464548e1a5e59a0e172461ff3e31692d26c26e1/tcping.go#L262
Problem
The function does not account for timing. For instance, when the internet connection is down, this function takes 4~5 seconds to timeout while nothing gets added to the respective timers here:
https://github.com/pouriyajamshidi/tcping/blob/2464548e1a5e59a0e172461ff3e31692d26c26e1/tcping.go#L415-L418
Solution
The retryResolve function needs to control and add to those timers as well.

After virtualized a webserver for demo, I still cannot simulate any situation when that function takes 4~5 seconds to timeout. Could you give more information for that scenario?

Uhm, I tried your scenario on my machine (Arch Linux - amd64 - go1.18.4). Previously using wifi, I disconnected my internet access by command nmcli radio wifi off. I also add line into printRetryingToResolve() that print out total down time to the terminal. Eventually, retrying to resolve does not take any extra second to timeout. Everything seems to be smooth.

yea, I also tried again and I don't see any hiccups like before. Now I wonder how it had occurred. Because it was the reason to open a ticket for it.
Let's try some more and if it does not occur again, we can close this for now.

@t-ohtaki do you know a situation which this can be triggered?

@pouriyajamshidi
I can see the event happening with the procedure that pouriya mentioned (tcping example.com 443 -r 2 and wifi on/off).

Thanks a lot @icemint0828. Helpful as always.
I hope this clears the issue @sonarypt


fix: snapshot tests

:tada: This PR is included in version 7.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BEAM-1871] Move ProtoCoder to new sdks/java/extensions/protobuf package.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Note that I got rid of ProtoCoder as a fallback coder after discussing with @kennknowles with a plan to replace the mechanism with a different override mechanism which is better with an automatic service registration scheme.

R: @kennknowles

Filed BEAM-2067


updated proper grammar for dos and don'ts in guideline titles

This change: (check at least one)

[ ] Adds a new feature
[x] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[x] Changeset added?

What does this change address?
https://github.com/ithaka/pharos/issues/115#issue-926633314
Fixes #115
How does this change work?
This change updates the apostrophes used as plurality and missing from contractions with proper grammar.
Additional context
Add any other context here.

Thanks for the submission @facelessfool! When you get a chance, please create a changeset, and (optionally) add yourself as a contributor.

I'll make sure to follow the conventions from next time.

Thanks again @facelessfool!


GRU implementation has different behavior with numpy.int64 than LSTM implementation

Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[ x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[ x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I get an error when running the script below because the GRU version behaves differently with numpy.int64 as input than the LSTM version. This is a problem because you would expect to simply change the implementation from LSTM to GRU without having to change any other inputs to the model. This came up because I was getting some of my parameters from a pandas dataframe that had numpy.int64 dtypes. I recently wanted to try implementing a GRU and when I simply changed my exisiting LSTM implementation to GRU without changing anything else, I got the error from the GRU implementation. The other inputs like input_shape=() does not seem to care about numpy.int64 but the first argument specifying number of units does. Using Keras 2.1.5  and gpu tensorflow 1.7 as that is latest I can install easily. I found same issue running on windows and running on an AWS instance of ubuntu using cpu version of tensorflow.
from keras.models import Sequential
from keras import layers
import numpy as np

data_dim = 21
timesteps = 8
num_classes = 10
num_neurons = 32
num_neurons = np.int64(num_neurons)

def test_model_GRU(data_dim,timesteps,num_classes):
    # expected input data shape: (batch_size, timesteps, data_dim)
    model = Sequential()
    model.add(layers.GRU(num_neurons,
                         name='gru_1',
                         input_shape=(timesteps, data_dim,),
                         ))
    model.add(layers.Dense(10,
                           activation='softmax',
                           ))
    model.compile(loss='categorical_crossentropy',
                  optimizer='rmsprop',
                  metrics=['accuracy'])
    return model

def test_model_LSTM(data_dim,timesteps,num_classes):
    # expected input data shape: (batch_size, timesteps, data_dim)
    model = Sequential()
    model.add(layers.LSTM(num_neurons,
                         input_shape=(timesteps, data_dim,),
                         ))
    model.add(layers.Dense(10,
                           activation='softmax',
                           ))
    model.compile(loss='categorical_crossentropy',
                  optimizer='rmsprop',
                  metrics=['accuracy'])
    return model

# Generate dummy training data
x_train = np.random.random((1000, timesteps, data_dim))
y_train = np.random.random((1000, num_classes))

# Generate dummy validation data
x_val = np.random.random((100, timesteps, data_dim))
y_val = np.random.random((100, num_classes))

model = test_model_LSTM(data_dim,timesteps,num_classes)
model.fit(x_train, y_train,
          batch_size=64, epochs=5,
          validation_data=(x_val, y_val))

model = test_model_GRU(data_dim,timesteps,num_classes)
model.fit(x_train, y_train,
          batch_size=64, epochs=5,
          validation_data=(x_val, y_val))

I'm getting exactly the same error with Keras 2.2.4:
In LSTM if the units is an int64 there's no error, but in GRU (the normal GRU or the CuDNNGRU) throws an error about no len for int64.
@boulderZ  have you found the reason?
By now I'm just casting to int before calling the GRU function.

Yeah, I just cast as well. I was just wanting to point out to the developers the issue.

Got the same issue: no problem with LSTM but problems with GRU.

@boulderZ , The issue has been resolved in recent Tensorflow version 2.5, I'm able to run the code without any error, please find the gist here.


Conjugation operation for nodes

Many tensor networks used in practice are invariant under complex conjugation. An example is the energy expectation value of an MPS, which is used in variational minimization procedures.
Such networks typically consist of two parts, one a set of complex tensors A,B,C, ... and the other a set of the complex conjugate of the first set, conj(A), conj(B), .... Currently, building such networks with TensorNetwork is done by adding A,B,C,... and e.g. tf.conj(A), tf.conj(B), ... (for the tensorflow backend) into the network. As far as I know, the supported backends will create a copy of A upon calling the conj method on it. This uses twice as much memory as would be necessary if the conj method would be called on the fly when contracting the tensors, which can become a bottleneck for large networks and/or large bond dimensions. It would be nice to have a way of telling TensorNetwork if an added node should be conjugated prior to contraction, or to have an optional argument to contract which determines if tensors should be conjugated prior to contraction.

At least with the TF backend, I don't think it matters whether conj() is called just before the contraction, or a lot before, if within a single computational graph - the memory for the copy will be allocated just the same. If tensordot() had conjugate flags, we could pass them on to matmul(), but IIRC matmul() just calls conj() on the input if you set the flag, rather than calling a conjugate version of GEMM... It's a bit sad.

JAX uses XLA by design and TF is going to switch to XLA very soon, so I think these optimizations will likely happen at compile time.


Unable to match test files recursively

In my project, I use the same directory structure in my test folder as I do my root folder. This looks like the following:
bin/bin-file.js
lib/plugins/plugin-file.js
lib/lib-file.js
lib/other-lib-file.js
test/bin/bin-file.test.js
test/lib/plugins/plugin-file.test.js
test/lib/lib-file.test.js
test/lib/other-lib-file.test.js
test/.eslintrc

I could very well be (and probably am) misunderstanding glob, but I can't seem to get all the appropriate files to test.
When I try with tap test/*.test.js, it doesn't match anything. When I try tap test/**/*.test.js, it only matches files one directory deep (i.e. everything in test/bin and test/lib, but not test/bin/plugins). Is this a bug, or am I doing it wrong?

You're probably using a version of Bash that doesn't support globstar, and since the pattern isn't quoted, the shell unpacks the args before tap ever gets them.
Try tap "test/**/*.test.js" instead, with quotes.  You can also do tap test and it'll walk the dir running all the files in it.

Another fix would be to install Bash version 4.3, and put shopt -s globstar in your .bashrc or .profile or .bash_profile files.