[SPARK-27936][K8S] Support python deps

What changes were proposed in this pull request?
Supports python client deps from the launcher fs.
Why are the changes needed?
This is a feature that was added for java deps. This PR adds support fo rpythona s well.
Does this PR introduce any user-facing change?
yes
How was this patch tested?
Manually running different scenarios and via examining the driver & executors logs. Also there is an integration test added.
I verified that the python resources are added to the spark file server and they are named properly so they dont fail the executors. Note here that as previously the following will not work:
primary resource A.py: uses a closure defined in submited pyfile B.py, context.py only adds to the pythonpath files with certain extension eg. zip, egg, jar.

Test build #111078 has started for PR 25870 at commit 40fe23c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16163/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/16163/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16163/
Test PASSed.

Test build #111078 has finished for PR 25870 at commit 40fe23c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111078/
Test PASSed.

@erikerlandson @holdenk pls review. I know there are some other changes related to the tests, I can always rebase if they get merged first.

cc @ifilonenko who I think did some related work?

@erikerlandson if you have some free time pls have a look :)

@skonto this LGTM

@holdenk this is because spark-submit add the resource in sparks.jars:
19/10/11 13:01:30 WARN Utils: Your hostname, universe resolves to a loopback address: <IP_ADDRESS>; using <IP_ADDRESS> instead (on interface wlp2s0)
19/10/11 13:01:30 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to another address
Parsed arguments:
  master                  k8s://https://<IP_ADDRESS>:443
  deployMode              cluster
  executorMemory          1G
  executorCores           null
  totalExecutorCores      null
  propertiesFile          null
  driverMemory            1G
  driverCores             null
  driverExtraClassPath    null
  driverExtraLibraryPath  null
  driverExtraJavaOptions  null
  supervise               false
  queue                   null
  numExecutors            2
  files                   null
  pyFiles                 null
  archives                null
  mainClass               org.apache.spark.examples.SparkPi
  primaryResource         local:///opt/spark/examples/jars/spark-examples_2.12-2.1.2-2.4.4-lightbend.jar
  name                    spark-pi
  childArgs               [100]
  jars                    null
  packages                null
  packagesExclusions      null
  repositories            null
  verbose                 true

Spark properties used, including those specified through
 --conf and those from the properties file null:
  (spark.kubernetes.driver.pod.name,spark-pi-driver)
  (spark.executor.instances,2)
  (spark.driver.memory,1G)
  (spark.executor.memory,1G)
  (spark.kubernetes.authenticate.driver.serviceAccountName,spark-sa)
  (spark.kubernetes.namespace,spark)
  (spark.kubernetes.container.image,lightbend/spark:2.1.2-OpenShift-2.4.4-rh-2.12)
  (spark.kubernetes.container.image.pullPolicy,Always)

19/10/11 13:01:31 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Main class:
org.apache.spark.deploy.k8s.submit.KubernetesClientApplication
Arguments:
--primary-java-resource
local:///opt/spark/examples/jars/spark-examples_2.12-2.1.2-2.4.4-lightbend.jar
--main-class
org.apache.spark.examples.SparkPi
--arg
100
Spark config:
(spark.kubernetes.namespace,spark)
(spark.jars,local:///opt/spark/examples/jars/spark-examples_2.12-2.1.2-2.4.4-lightbend.jar)
(spark.app.name,spark-pi)
(spark.driver.memory,1G)
(spark.executor.instances,2)
(spark.submit.pyFiles,)
(spark.kubernetes.container.image.pullPolicy,Always)
(spark.kubernetes.container.image,lightbend/spark:2.1.2-OpenShift-2.4.4-rh-2.12)
(spark.submit.deployMode,cluster)
(spark.master,k8s://https://<IP_ADDRESS>:443)
(spark.kubernetes.authenticate.driver.serviceAccountName,spark-sa)
(spark.executor.memory,1G)
(spark.kubernetes.driver.pod.name,spark-pi-driver)
Classpath elements:

So since the PR here manages that property we dont need to do double work. For python its different.

Test build #112169 has started for PR 25870 at commit 3245e4e.

Test build #112171 has started for PR 25870 at commit 4ed8524.

@erikerlandson I added one test which uses a zip file as we discussed previously:

Thanks @skonto!

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17161/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17161/

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17161/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17163/

Test build #112171 has finished for PR 25870 at commit 4ed8524.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112171/
Test PASSed.

Test build #112169 has finished for PR 25870 at commit 3245e4e.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112169/
Test PASSed.

Test build #112275 has started for PR 25870 at commit f8df227.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17258/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17258/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17258/
Test FAILed.

Test build #112275 has finished for PR 25870 at commit f8df227.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@erikerlandson can I get a merge? Gentle ping :)

@holdenk gentl ping.

@dongjoon-hyun could you merge this one?

Thank you for pinging me, @skonto . I'll take a look now.

Retest this please.

Test build #112745 has started for PR 25870 at commit f8df227.

Test build #112745 has finished for PR 25870 at commit f8df227.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112745/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17690/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17690/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17690/
Test FAILed.

Ok I will fix this over the weekend, sorry for the delay.

@dongjoon-hyun  could you re-open it pls? I will work on it.

Sure, no problem. Thanks, @skonto .

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25908/
Test FAILed.

Test build #121220 has started for PR 25870 at commit f8df227.

Test build #121220 has finished for PR 25870 at commit f8df227.

This patch fails build dependency tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121220/
Test FAILed.

Test build #122325 has started for PR 25870 at commit 1959956.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/26995/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/26995/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26995/
Test PASSed.

Test build #122325 has finished for PR 25870 at commit 1959956.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122325/
Test PASSed.

Test build #122415 has started for PR 25870 at commit 7fca5e4.

Test build #122415 has finished for PR 25870 at commit 7fca5e4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122415/
Test FAILed.

Test build #122416 has started for PR 25870 at commit b0bc40f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27079/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27080/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27079/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27079/
Test PASSed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27080/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27080/
Test FAILed.

Merged build finished. Test FAILed.

@dongjoon-hyun ready for a review round. Refactored a few stuff. Thank you for your patience :)

@skonto . I visited this PR two days ago when you refreshed and visited now again.
But, my comments are still not addressed. That's the reason I didn't review this again.

Test build #122416 has finished for PR 25870 at commit b0bc40f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122416/
Test FAILed.

@dongjoon-hyun sure will have a look.

Test build #122444 has started for PR 25870 at commit eb67283.

Test build #122444 has finished for PR 25870 at commit eb67283.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122444/
Test FAILed.

Test build #122445 has started for PR 25870 at commit a9f055b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27105/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27106/

@dongjoon-hyun I think addressed your comments, I missed a few earlier, had to scroll up a bit. There is a discussion about the use of Eventually but I have explained why I used this way to make sure the resources are cleaned up. Same for the use of the grace period there, it is no harm afaik.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27105/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27105/
Test PASSed.

Merged build finished. Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27106/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27106/
Test PASSed.

Test build #122445 has finished for PR 25870 at commit a9f055b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122445/
Test PASSed.

@dongjoon-hyun gentle ping, pls let me know if I need to do anything more.

Very sorry for the delay. Since last Friday, I was very busy for the other stuffs. (The Jenkins outage and SparkSummit slide due). Since this is for 3.1.0, I'll try to re-visit here before this weekend. Hopefully, sooner than that.

Retest this please

Test build #122599 has started for PR 25870 at commit a9f055b.

Test build #122599 has finished for PR 25870 at commit a9f055b.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122599/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27261/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27261/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27261/
Test FAILed.

@dongjoon-hyun thanks! I checked the failures but dont seem to be relevant. I will try re-test.

Retest this please

Test build #122630 has started for PR 25870 at commit a9f055b.

Test build #122630 has finished for PR 25870 at commit a9f055b.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122630/
Test FAILed.

The dependency issue is fixed.

Retest this please.

Test build #122647 has started for PR 25870 at commit a9f055b.

Test build #122647 has finished for PR 25870 at commit a9f055b.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122647/
Test FAILed.

The job was running on amp-jenkins-worker-05 which seems to have a corrupted Maven local info. This is another issue.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install (default-cli) on project spark-parent_2.12: ArtifactInstallerException: Failed to install metadata org.apache.spark:spark-parent_2.12/maven-metadata.xml: Could not parse metadata /home/jenkins/.m2/repository/org/apache/spark/spark-parent_2.12/maven-metadata-local.xml: in epilog non whitespace content is not allowed but got > (position: END_TAG seen ...</metadata>\n>... @13:2) -> [Help 1]

Retest this please

Test build #122650 has started for PR 25870 at commit a9f055b.

Test build #122650 has finished for PR 25870 at commit a9f055b.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122650/
Test FAILed.

It's still assigned to amp-jenkins-worker-05.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27309/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27312/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27309/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27309/
Test FAILed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27312/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27312/
Test FAILed.

Retest this please

Test build #122747 has started for PR 25870 at commit a9f055b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27406/

Test build #122747 has finished for PR 25870 at commit a9f055b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122747/
Test PASSed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27406/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27406/
Test FAILed.

Back to this.

I'm also back after my motorcycle crash last year, let me know when it's up to date and I'd be happy to take another look. Thanks for sticking with this.

I notice this is targeted for 3.1, is it worth trying to get on the 3.0.1 train?

I think the plan is to cut 3.0.1 pretty soon since there are some almost show stopper bugs in 3.0 so I’d leave it targeted to 3.1 and once it’s in we can discuss if backporting makes sense.

+1 for @holdenk 's comment. Also, in general, we cannot backport the improvement JIRA.

Gentle ping, @skonto . Apache Spark 3.1.0 Feature Freeze is scheduled on Early Nov 2020

https://spark.apache.org/versioning-policy.html

@dongjoon-hyun I will try update, sorry it has been too long, my bad.

Gentle ping, @skonto .

ack

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35889/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35889/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35889/
Test PASSed.

@dongjoon-hyun I finally updated it pls review.

Test build #131286 has finished for PR 25870 at commit 0145183.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131286/
Test PASSed.

Thank you so much for updates, @skonto !

Just saw your comment thanks!!!


No test bench file?

Hi, this work is amazing.And I am interested in your hls files.I want to do Test Bench by vivado hls, can you release the code?
And, I want to know how to generate the bin file of weights and bias in your work? Can you release the train code? The total pipeline must be much more amazing, I think.Thank you.

你好，我想了解一下您这个项目用的目标检测网络是R-CNN、SSD、YOLO还是其他网络？


how to switch user/schema during the migrate?

hi guys, I'm a DevOps consultant and one of our client using Oracle 11.2
they have multiple schemas in a database aka multiple projects and project teams.
and they also have one common schema which all teams may touch on.
what they current do now is they can switch user during do the migration with their own BAT/Shell scripts. things like below.
1.user01_create_view.sql
2.user02_create_table.sql
they can identify which user they should use during the migrate within sql file name.
so I suggest the flyway tool for them and we are doing tools validations now. everything working perfect. except this req.
Q1:what is the best practise with flyway switch user/schema during the migrate?
Q2:and another question I wonder is it possible to buy your tool with unlimited schema and time.
because the client cant apply for budget every year

For question 2 you want to email<EMAIL_ADDRESS>

@Lyeeedar thanks, what about Q1?

As for Q1, You can do this by putting an ALTER SESSION SET CURRENT_SCHEMA=schema1 at the top of each migration file, or prefixing all your statements like CREATE TABLE schema1.mytable.

@Lyeeedar so it means i have to use a user that have permission for multiple schema. right?

That is correct. If you want to have different users, then you need to invoke flyway multiple times, and structure your migrations into seperate locations that can be independently executed.


The "notification" event is not fired on iOS 9.0.2

Hi,
The notification is received successfully on the phone. When I tap on it the AppDelegate.didReceiveRemoteNotification method is called successfully but the app state is inactive and the notification is saved for later.
Immediately after that, the applicationDidBecomeActive method is called which does
    [pushHandler performSelectorOnMainThread:@selector(notificationReceived) withObject:pushHandler waitUntilDone:NO];

but the PushPlugin.notificationReceived method is never called and the "notification" event on the javascript side is never fired.
Any ideas on how I could eventually fix this?
Thanks in advance for your help.

Silvio

@smanuel I downgraded one of my devices to iOS 9.0.2 and I cannot reproduce this issue.

i have the same problem too in ios 9.0.2

i have a same problem too in iOS devices greater then 9.0

@macdonst The problem was in some changes I had done at a totally different place but which resulted in the above mentioned behavior. Reverted all the changes and everything works as expected.
Sorry for the false alarm.

@smanuel can you please tell us how we can fix this issue?
becasue at my side there is no notification at devices above 9.0 but devices 8.0 working fine.

Closed as per @smanuel


chore(dependencies): Update dependency eslint-plugin-jsdoc to v46.8.2

This PR contains the following updates:

Package
Type
Update
Change

eslint-plugin-jsdoc
devDependencies
minor
46.5.1 -> 46.8.2

Release Notes

gajus/eslint-plugin-jsdoc
v46.8.2
Compare Source
Bug Fixes

fall back to deprecated getSourceCode(); fixes #1159 (8374349)

v46.8.1
Compare Source
Bug Fixes

require-description-complete-sentence: allow all inline tags at beginning of sentence; fixes #1150 (e8b1475)

v46.8.0
Compare Source
Features

require-returns: add publicOnly option; fixes #1137 (8dbcb6f)

v46.7.0
Compare Source
Features

require-returns: add optional fixer (dfd2a8a)

v46.6.0
Compare Source
Features

informative-docs: add excludedTags; fixes #1153 (6f1b50b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Merge "Relax path related params" from typeshed

Summary of changes
Staying updated with Typeshed for #2345
There's a bunch of small changes that could be done to support StrPath in more places, but this PR is only meant to update annotations to work as-is.
Pull Request Checklist

[x] Changes have tests (type-checking tests)
[x] News fragment added in newsfragments/. (no user facing changes yet as pkg_resources' typing is still prefered from typeshed)
(See documentation for details)

Thank you very much!


button to remove all fonts and get to normal

Hello!
Can I work on this issue?

Sure @shrey27tri01

This is actually removing all the applied fonts and getting to default

I will work on this?

Go on!


Value highlighting (works for single-line values so far)

The regex pattern actually matches mutli-line values,
but I think Sublime Text is doing some optimization
to prevent performance issues.
Eventually closes #15
Regex diagram
TODO:

[ ] re-write the regex, possibly using additional rules ie: single line value, multi-line value, and maybe even continuation of a multiline value
[ ] clean up the endCaptures list
[ ] remove TODOs from the JSON file since that's breaking the test runner

Here's what the test conf file looks like:

Closing, #21 is better 😃


Cross-account region specification

Hello,
I've been looking into the repo and AWS tutorials on this cross-account matter. However, I wasn't able to find any reference to region specification when deploying cross-account.
The deployment environment of the account is seen as a single unit, when there could possibly be multiple regions where to deploy in.
Is there an example on how we change the cross-account deployment region rather than the pipeline's default?
I've tried setting up a new region in the deployment stage, as well as another ArtifactBucket for the corresponding region.
    ArtifactStores:
        - Region: "eu-west-1"
          ArtifactStore:
            Type: S3
            Location: !Sub ${BucketName}-eu-west-1
            EncryptionKey:
              Id: !GetAtt KMSKey.Arn
              Type: KMS
        - Region: "ap-southeast-2"
          ArtifactStore:
            Type: S3
            Location: !Sub ${BucketName}-ap-southeast-2

But the end result is either:

Failed replicating 'Deployment Artifact': Invalid Arn (if I specify the  KMS key in the new bucket)
Access Denied on S3 when the KMS key is only specified on the main artifact store, even with Role permissions and bucket policies extended to the new bucket.

Thanks.

For anyone reading this issue and having the same problem. My steps on solving this were:

Remove the Encryption Key from the main pipeline's region - it will use S3 defaults
Create a KMS Key on secondary region you are trying to deploy in
Use that key in the Artifact Store of the corresponding region
Move your CodeBuild to that secondary region as well
Update your permissions in the cross-account to allow the key usage, as well as your pipeline policies in the main account

Having your KMS Key and CodeBuild in the region you are trying to deploy in will allow you to create the pipeline.


what happened to ox discord account? was it turned off?

for some reason, he hasn't been responding for several days, and I'm just wondering why he's been offline for so long in the discord, if you have it disabled can you tell your new account? @oxiKKK

Hi, I was on vacation, sorry for not responding. 😁


Please merge additional modules

New pull request as advised -
re-instated the "count" parameter on the get request, class variable can be used to omit it if required (see the change in /lib/ansible/modules/network/solace/solace_bridge_remote_vpn.py)
changed the cluster password used in the DMR example.

Please fix the merge conflict and I'll get this in,

This should do it, thanks.


Nasty Windows deadlock (was Windows support)

Probably with Appveyor CI? https://github.com/ogrisel/python-appveyor-demo

Ok, we have Windows CI! https://ci.appveyor.com/project/oconnor663/duct/branch/master
Unfortunately our tests are hanging on some versions of Windows. It looks like everything works on Windows 8.1, but test_pipe hangs on Windows 7. (VirtualBox VM, Python 3.5 in both cases.)

When I ran into this on Linux it was an inheritable fd's problem in exactly the same test. Unfortunately the details of fd inheritance on Windows are pretty complicated... https://www.python.org/dev/peps/pep-0446/

It looks like the deadlock happens with Popen specifically runs at the same time on two different threads. It doesn't matter that wait is running at the same time. I think I've been able to demonstrate this on the experiment and windowsfix branches by using threading.Event to guarantee that the two Popen's happen at exactly the same time.
My current best guess is that the Windows version of Popen creates some new temporary file descriptors before spawning, and it's those that make it into the child process on the wrong side of the pipe? I'll need to read the code to make sure.
In any case, it sounds like a reasonable fix will be to use a single lock around just Popen, and then have the waits proceed outside the lock.

I would love to know why this repros on Win 7 but not Win 8.1.

Nailed it. The _make_inheritable function seems to do exactly what I suspected, and only on Windows.
Still not sure why this is so Windows-version-specific? That could also be timing -- I need to retry Windows 8.1 with my new Event repro.

Any why was it that I didn't see any of those descriptors when I was printing the results of stat on everything. Were the fd's too large?

Indeed, it looks like _make_inheritable has been around since subprocess was introduced in Python 2.4.

It looks like the fd's are in the 200-300 range when I print them in _make_inheritable. But then when I log that range, they're still not visible to os.stat. Maybe os.stat isn't capable of showing all types of valid Windows fd's?

https://gist.github.com/oconnor663/b1d39d58b232fc627d84

https://bugs.python.org/issue25565

Locking Popen is a workaround. Done in 2939eda5708bbb12c221f122e3d3e56e5e42304d.

6b5bbd80a5c808b82cd24e71abb4e5aad68bd3f9 fixed universal newlines mode in Python 2.7.

With e452a55c59f7c370328560a111c324c22878f68b, stop trying to test Python 2.6 on AppVeyor. This would require importing a bunch more files from the demo project, and I don't think it's worth it.

Tests are green!


Use persistent storage

What kind of storage are you looking for, mongoDB? Do you have any additional thoughts around this?


Watch All Namespaces

I would like the ability to watch all namespaces when deploying with OLM.

that's already the behavior. Let me know if I can close this.

So even with this in the olm deployment section

name: WATCH_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.annotations['olm.targetNamespaces']

which will render to the deployed namespace it will still watch all namespaces?

it's a bug.
On Thu, Apr 9, 2020 at 1:22 PM mathianasj<EMAIL_ADDRESS>wrote:

So even with this in the olm deployment section

name: WATCH_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.annotations['olm.targetNamespaces']

which will render to the deployed namespace it will still watch all
namespaces?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/redhat-cop/cert-utils-operator/issues/35#issuecomment-611649303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPERXDX2TFJBEZBVV4OZC3RLX76TANCNFSM4ME4CDWQ
.

--
ciao/bye
Raffaele

I will take a look at this


HttpClient response headers are empty

I'm trying to read custom headers from the HttpResponseHeaders using the following code.
public static class ExtensionMethods
{
    #region HttpClient

    public static async Task<IPage<T>> GetPageAsync<T>( this HttpClient httpClient, string requestUri ) where T : class
    {
        using ( var response = await httpClient.GetAsync( requestUri ) )
        {
            response.EnsureSuccessStatusCode();

            var entries = Json.Deserialize<List<T>>( await response.Content.ReadAsStringAsync() );
            var totalCount = response.Headers.ParseInt( "X-Total-Count" );
            var offset = response.Headers.ParseInt( "X-Offset" );
            var limit = response.Headers.ParseInt( "X-Limit" );

            return await Task.FromResult( new Page<T>
            {
                TotalCount = totalCount,
                Entries = entries,
                Offset = offset,
                Limit = limit,
            } );
        }
    }

    private static int ParseInt( this HttpResponseHeaders headers, string key )
    {
        var value = headers?.FirstOrDefault( x => x.Key == key ).Value?.FirstOrDefault();

        if ( string.IsNullOrEmpty( value ) )
            return 0;

        int.TryParse( value, out var number );

        return number;
    }

    #endregion
}

Helper classes:
public interface IPage<T>
{
    int TotalCount { get; }

    List<T> Entries { get; }

    int Limit { get; }

    int Offset { get; }
}

[DataContract]
public class Page<T> : IPage<T> where T : class
{
    [DataMember]
    public int TotalCount { get; set; }

    [DataMember]
    public List<T> Entries { get; set; }

    [DataMember]
    public int Offset { get; set; }

    [DataMember]
    public int Limit { get; set; }
}

I can see the headers in Postman and the code works when I run it in ConsoleApp without any problems. But in Blazor the response.Headers are always missing. The only value that I can get is Content-Type.
Is there any way that I can get custom headers with the HttpClient in Blazor?

This is my client code that works only when I connect to the API on localhost:
fetch(requestUri, {
    method: "GET",
    mode: "cors",
    headers: {
        "Accept": "application/json",
        "Content-Type": "application/json",
        "Authorization": "Bearer " + token
        }
        //credentials: "include"
    })

But it's still not working when I try to connect to my production API. I have tried everything I can think of. Currently I have this in my REST API project.
services.AddCors( options =>
{
    options.AddPolicy( "CorsPolicy", builder =>

    // TODO: this should be limited only to specified sources
    builder.AllowAnyOrigin()
            .AllowAnyMethod()
            .AllowAnyHeader() );
    //.AllowCredentials()
    //.Build() );
} );

// and in Configure()
app.UseCors( "CorsPolicy" );
I have also tried to set specific origins(WithOrigins), and headers(WithHeaders), but nothing helps.

@stsrki Take a look at https://docs.microsoft.com/en-us/aspnet/core/security/cors#set-the-exposed-response-headers and see if it helps.

That actually worked!! Both client call examples work. I cannot believe that I didn't see it before in the documentation.

I have this problem too, there is no cross origin problems because I can send custom headers with HttpClient, but the response hearders is always empty.


Minor: reorder Dockerfile layers for better cache use

Move package installs and prisma client generation to before copying the src directory into the image. Regular source code changes in src do not warrant rerunning those steps.

💯


Proofread - added tags and full name of IIS

@hansthen - there is a link here to https://esus1.mendixcloud.com/index.html#mce_temp_url# which is supposed to have information about IIS error responses, but it seems to be a real app doing something else. Any idea what the real link should be, or should I remove it?
Let me know if I should be asking someone else.
Thanks,
Mark

This PR is now so far behind development that I will close it.
Taking the changes and putting them into the file manually as part of restructuring the deployment section of the documentation site.


Refactor/split tests

Split tests into different files (closes #90 )
Put all write requests into a queue in StoreProvider (closes #94 )

Hopefully the tests will be more reliable now and quicker. Next step is to mock the store interactions. Using the hosted store slows the tests down 3x.
NOTE: when running the tests locally you will need 15 accounts on your testrpc client

Pull Request Test Coverage Report for Build 510

26 of 77 (33.77%) changed or added relevant lines in 5 files are covered.
309 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-40.8%) to 29.764%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/abstractWrappers/Disputes.js
0
1
0.0%

src/abstractWrappers/EventListeners.js
0
1
0.0%

src/abstractWrappers/Notifications.js
1
2
50.0%

src/contractWrappers/ArbitrableTransactionWrapper.js
0
3
0.0%

src/utils/StoreProviderWrapper.js
25
70
35.71%

Files with Coverage Reduction
New Missed Lines
%

src/utils/Web3Wrapper.js
1
27.03%

src/abstractWrappers/Arbitrator.js
2
55.56%

src/abstractWrappers/ArbitrableContract.js
3
50.0%

src/utils/StoreProviderWrapper.js
6
36.19%

src/kleros.js
8
56.52%

src/contractWrappers/ArbitrableTransactionWrapper.js
20
21.43%

src/abstractWrappers/EventListeners.js
25
14.55%

src/contractWrappers/KlerosWrapper.js
35
47.89%

src/abstractWrappers/Notifications.js
70
10.81%

src/abstractWrappers/Disputes.js
139
18.65%

Totals

Change from base Build 501:
-40.8%

Covered Lines:
296

Relevant Lines:
838

💛  - Coveralls

thanks for the review @epiqueras


maybe rewrite three regexps for XS compatibility

We noticed three regexps in babel-standalone which are rejected by the XS regexp parser. These showed up as test failures in the agoric-sdk XS integration CI run. That test uses XS to compile a program that incorporates the tests from two of our agoric-sdk modules, and those test files recently acquired a dependency upon SES (in https://github.com/Agoric/agoric-sdk/pull/1244), and SES uses babel-standalone. The first time XS was exposed to babel-standalone, we got an error like this:
https://github.com/Agoric/agoric-sdk/runs/824570388?check_suite_focus=true#step:10:75
The regexps it rejected were:
/home/runner/work/agoric-sdk/agoric-sdk/node_modules/@agoric/babel-standalone/babel.js:21342: error: ^\)] invalid character!

line 21341:
  function parseSourceMapInput(str) {
    return JSON.parse(str.replace(/^\)]}'[^\n]*\n/, ''));
  }

/home/runner/work/agoric-sdk/agoric-sdk/node_modules/@agoric/babel-standalone/babel.js:66549: error: ^(?:] invalid character!

line 66548:
        } else if (!hasUnicodeFlag && (res = matchReg(/^(?:]|})/))) {
          return createCharacter(res);

/home/runner/work/agoric-sdk/agoric-sdk/node_modules/@agoric/babel-standalone/babel.js:68362: error: \\[pP]{ invalid quantifier!

line 68362:
      if (hasFeature$1(features, FEATURES$1.unicodePropertyEscape) && /\\[pP]{/.test(pattern)) {
        unicodePropertyEscape = true;
      }

I'm not sure what's going on with them, they don't look particularly unusual to me.
Ideally/eventually, XS would be fixed to accept these. A shorter-term solution might be for us to rewrite/replace them in this (@agoric/babel-standalone) fork. Such a change may or may not be appropriate for pushing upstream.
cc mainly @michaelfig and @phoddie , also @FUDCo

The first is coming from source-map (we get version 0.6.1, but current trunk does the same thing):
https://github.com/mozilla/source-map/blob/ac518d2f21818146f3310557bd51c13d8cff2ba8/lib/util.js#L432-L434
The second comes from regjsparser:
https://github.com/jviereck/regjsparser/blob/1325cad7b3dc22d8a9ea88136e5c424f0d4b7a11/parser.js#L628-L636
The third comes from babel itself:
https://github.com/agoric-labs/babel/blob/e258fafb3e3e41617712d7f3b4021d0fd75ff664/packages/babel-helper-create-regexp-features-plugin/src/util.js#L11-L21
The fact that two are coming from upstream libraries means this will be a lot harder to patch locally, we'd have to fork both of those libaries too.

Your call on how to deal with this in your code. My advice would be to wait a day or two to give us time to investigate. There's some chance it is an easy fix.

Cool, thanks!

cc @dckc

Update. These RegExps are not standard JavaScript. ;) They rely on Annex B.
We have updated XS to support this particular Annex B behavior. We'll push that in the coming days.
Still, none of these projects need to rely on Annex B. They likely aren't even aware of the dependency. The RegExps can (even should) be updated to eliminate the dependency.

@phoddie thanks for the fix!
https://github.com/Moddable-OpenSource/moddable/issues/383#issuecomment-668827911


[Needs Testing]

A possible checks that gets the owner id from appinfo! I'm too tired to test it and i got school.

does it work

To be tested, haven't had time yet.

Failed testing stage; No modules could be loaded after the change.
Reason: Unknown
No Sentry errors logged.
PR left open to accommodate proper changes.

Ok, opinions on check being a required module?

Having it as a module instead of utils?
I won't see how that would work/fix the issue.

Making it a required import, we can import it then do get_cog() to get the cog and get the function for it. We could also use this to make a command to store other users id's which could support multiple owners.

I'll make a pr later.

that would make it uselessly complicated tho, alternatively we could resort to Liara's way of fetching application owner ID.
Please note that Xeili was heavily influenced by Liara so it should not be an issue.

What was Liara method? The code shouldn't be hard to make

Need to see from the Liara's code, shouldn't be hard to replicate.


missing end-of-line character when writing to $GITHUB_OUTPUT

The problem
VersionGitHubActionsOutput.write_if_possible is writing to $GITHUB_OUTPUT, but fails to add an end-of line afterwards.
If one tries to echo another variable to $GITHUB_OUTPUT, it is then added to the previous line instead of a new line, and can't be used later in the workflow.
Here are the command from the workflow:

And the printed output:

Adding echo "" >> $GITHUB_OUTPUT before the next echo to $GITHUB_OUTPUT solved the issue as a workaround.
Expected behavior
Semantic release should write properly to $GITHUB_OUTPUT, finding out where the issue lies is time-consuming since this happens in the background.
Returning "\n".join(f"{key}={value!s}" for key, value in outputs.items()) + "\n" in VersionGitHubActionsOutput.to_output_text solves the issue.
Context
Linux runner
semantic release v9.3.1
Looking at the latest version, the issue seems still present.

:tada: This issue has been resolved in version 9.4.1 :tada:
The release is available on:

PyPi package
GitHub release


Update regex tests for Platformer Game Step 82 to accept multiple valid solutions

Describe the Issue
in .every the rule section is required to be wrapped in parenthesis even though it doesn't effect the functionality.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-intermediate-oop-by-building-a-platformer-game/step-82
Your code
if (collisionDetectionRules.every(rule => rule)) {
    player.velocity.y = 0;
    return;
  }

Expected behavior
I expected to pass. this is what the checker is actually asking for:
if (collisionDetectionRules.every((rule) => rule)) {
    player.velocity.y = 0;
    return;
  }

Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

I can help with that. I will fix the regex and open a pull request soon! :)

Thank you for reporting this issue.
This is a standard message notifying you that the problem you mentioned here is present in production, but that it has already been fixed in codebase. This means that the next time deployment is made, this problem should be fixed. Because of this, we're closing this issue.
If you think we're wrong in closing this issue, please request for it to be reopened and add further clarification. Thank you and happy coding.

great thanks guys!


Pin to archaius2 rc.30

NetflixOSS » karyon » karyon-pull-requests #150 FAILURE
Looks like there's a problem with this pull request


remove version number

I create a PR which include this one https://github.com/micronaut-projects/micronaut-docs-index/pull/79


Dimension typo (?)

Matrix W is supposed to be 10 x 3073 (for module continuity).

If the dimensions (3073 x 10) were supposed to be for W.T, then the sentence should be changed to "...since the dimensions of W^T are 3073 x 10." (Right?)


Update calendar.py and Add test_calendar.py from CPython 3.8.5

Update calendar.py from CPython 3.8.5
Add test_calendar.py
Skip test_option_encoding that caused error

======================================================================
FAIL: test_option_encoding (__main__.CommandLineTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "Lib/test/test_calendar.py", line 831, in test_option_encoding
    stdout = self.run_ok('--encoding', 'utf-16-le', '2004')
  File "Lib/test/test_calendar.py", line 794, in run_ok
    return assert_python_ok('-m', 'calendar', *args)[1]
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/test/support/script_helper.py", line 157, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/test/support/script_helper.py", line 143, in _assert_python
    res.fail(cmd_line)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/test/support/script_helper.py", line 84, in fail
    err))
AssertionError: Process return code is 1
command line: ['/home/clemado1/workspace/RustPython/target/release/rustpython', '-X', 'faulthandler', '-I', '-m', 'calendar', '--encoding', 'utf-16-le', '2004']

stdout:
---

---

stderr:
---
Traceback (most recent call last):
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/calendar.py", line 770, in <module>
    main(sys.argv)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/calendar.py", line 764, in main
    result = result.encode(options.encoding)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/_codecs.py", line 118, in encode
    res = codec[0](v, errors)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/_codecs.py", line 463, in __call__
    return self._f(*args, **kwargs)
  File "/home/clemado1/workspace/RustPython/vm/pylib-crate/Lib/_codecs.py", line 421, in utf_16_le_encode
    res = bytes(res)
TypeError: Expected type 'int', not 'str'
---

anybody has any idea what's happened to newline here?

That error should be fixable in _codecs.py, that code is from python 2 so it just needs to be converted to use ord or not use chr, or something along those lines.

@youknowone what do you mean?

@coolreader18 See the failed test in windows CI. it seems the text is included in text file, but somehow it includes \r\n instead of \n in the test - which leads error

Oh, hmm -- we might need to change stdio to use raw/binary mode instead of text mode. I think I read a blog post about someone compressing an executable on windows and windows converted a 0a byte in the machine code to 0a 0d because stdout was in "text" mode -- maybe this is something similar.

https://docs.microsoft.com/en-us/cpp/c-runtime-library/text-and-binary-mode-file-i-o?view=vs-2019
Not sure if there's something to do this in Rust

I marked skip as a temporary fix on all the 5 test cases that had errors in Windows.
@unittest.skipIf(sys.platform == 'win32', 'TODO: RUSTPYTHON Windows')


[4/4] Remove TensorBuffer::JPEG, DecodedTensor, TensorDecodeCache

Part of https://github.com/rerun-io/rerun/issues/6844
Closes https://github.com/rerun-io/rerun/issues/3803

⚠ This breaks any existing JPEG-encoded RRDs
Rust API

Removed TensorBuffer::JPEG
Removed TensorData::from_jpeg_bytes
Deprecated Image::from_file_path and from_file_contents

For all of these, use ImageEncoded instead.
PR train

Prev: https://github.com/rerun-io/rerun/pull/6882
Prev: https://github.com/rerun-io/rerun/pull/6874
Prev: https://github.com/rerun-io/rerun/pull/6883

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check

@rerun-bot full-check


markdown -> mdx

📝Changed routes:

/

(view full size)

Commit ff189486cc5c522f8873be9d65564392becf21ba (https://swr-site-git-fork-vassbence-master.vercel.now.sh).


Not working with fish

Hello
I'm using latest version of Atom (1.7.3) with all updates on OS X 10.11.4 with fish as default shell.
When I opens terminal and launching env I can see various defined variables including GOPATH.
But when I'm launching Atom the autocomplete-go package (that requires environment package as dependence) tells me that it can't found gocode tool that already installed.
I can confirm that problem not in autocomplete-go but  in this package because when I opens DevTools and printing process.env.GOPATH I see undefined, but after launching env-from-shell the process.env.GOPATH becomes defined and autocomplete-go working correct.
BTW, env-from-shell had the same problem, and they have a solution. Can you apply something like that?
Thanks

This package is deprecated; you should uninstall it. See https://github.com/atom/atom/pull/12562 for more information.


Folo To Cassandra Storage Implementation

MMENG-145 & MMENG-708: Implemented creating of cassandra table for. storign. folo. records with appropriate partition key based on trackingKey and path
MMENG-742: Implemented config flag 'folo.cassandra' with values  true , false for selecting storage  type for folo records ( infinispan or cassandra at this point  ).
MMENG-709: Implemented Folo to Cassandra Storage to replace existing  Infinispan cache when clustered environment is used  for indy deployments of  several instances.

Generally LGTM except a typo
One thing I want to know is the migration. Seems before the cassandra enablement we need a way to migrate the legacy ispn folo tracking records to this new cassandra db. Not sure if a separate migrator is needed, or just a StartupAction to do this.

There is separate ticket for doing migration of legacy folo records.

I think we need to avoid the second table for sealed records, since it doesn't provide any real value (see below)

That. table is just placeholder if. we. need. it. in future, right. now. it is not used in implementation. So question will be should i. keep it (because of. future. use) or should. i delete. it?

We need to consolidate the hasXXXRecord() method calls in the Cassandra implementation, and take them out of the interface. These are only used for testing access, as far as I can tell. Consolidating will allow us to streamline the data model more, I think.

I agree. It will be present in next commit.

We need to consolidate the getXXXTrackingKey() methods in the Cassandra impl + interface, and push the branching logic from FoloAdminController into the ISPN impl. This will allow us to streamline the queries a bit more

I agree. it will. be. present. in. next commit.

@jdcasey @ruhan1 i was. thinking that. we have merge this PR but. when i. check today. i see that there. is some build error (RetrievedPomInAlwaysOnTrackingReportTest.run:97, RetrievedPomInSuffixTrackingReportTest.run:99) which. weren't there before.
So should i recreate new. branch and. make new. PR with same changes or should. i. try to. fix this error ) I'm asking. because when i try. to build master. branch locally with integration tests cassandra was unable to start and build failed so i'm. afraid. that there is some changes which could cause. some problems

@jdcasey i don't get it why  it is feiling on  "RetrievedPomInAlwaysOnTrackingReportTest" and "RetrievedPomInSuffixTrackingReportTest"  when we are commenting/disabling  those tests  for running   at  all!?


[Feature][Connector-V2] add sqlserver connector

Purpose of this pull request

support sqlserver connector
Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

是否应该是jdbc-connent

PTAL @ic4y @EricJoy2048 @CalvinKirs thanks.

PTAL @ic4y @EricJoy2048 @CalvinKirs thanks.

e2e test pass

LGTM @Hisoka-X

PTAL @CalvinKirs @TyrantLucifer @EricJoy2048 .thanks

@Hisoka-X @ashulin @TyrantLucifer @ic4y  change /tmp/spark/seatunnel/ to /tmp/seatunnel/ PTAL ,thanks.

@TyrantLucifer please rerun the CI.

@ashulin @TyrantLucifer @CalvinKirs @Hisoka-X @EricJoy2048 PTAL thanks.

PTAL @CalvinKirs @TyrantLucifer @Hisoka-X .thanks

LGTM

please rerun CI thanks @TyrantLucifer

please rerun CI thanks @TyrantLucifer

Wait until the running workflow is finished before restarting. Please be patient.

@TyrantLucifer @Hisoka-X    PTAL

rerun CI? I don't think this mistake affects @TyrantLucifer

rerun CI? I don't think this mistake affects @TyrantLucifer

CI had been optimized, so some steps will be enabled, before your pr is merged CI must run successfully. It's a community norm.

There are some problems with the dependency checking step, pls check again.

rerun CI? I don't think this mistake affects @TyrantLucifer

CI had been optimized, so some steps will be enabled, before your pr is merged CI must run successfully. It's a community norm.

There are some problems with the dependency checking step, pls check again.

At now the dependency have some problem because st-engine bring some dependency but not update LICENSE file, we will update it later.

rerun CI? I don't think this mistake affects @TyrantLucifer

CI had been optimized, so some steps will be enabled, before your pr is merged CI must run successfully. It's a community norm.

There are some problems with the dependency checking step, pls check again.

At now the dependency have some problem because st-engine bring some dependency but not update LICENSE file, we will update it later.

rerun CI? I don't think this mistake affects @TyrantLucifer

CI had been optimized, so some steps will be enabled, before your pr is merged CI must run successfully. It's a community norm.

There are some problems with the dependency checking step, pls check again.

At now the dependency have some problem because st-engine bring some dependency but not update LICENSE file, we will update it later.

Good, let's waiting other steps of CI. I had restarted the failed steps


Add Pylon widget to Rill Cloud for admins

This is a follow-up to #3397 and #3428 but we'd like to add the in-app chat widget to Rill Cloud but limit this to only admin users at the moment. From a design perspective, we could either:

Tie this to the Profile > Ask for help button on all pages (see screenshot)
Have the widget show up normally (default - bottom right) on all pages except when a dashboard is open in the UI, in which case the end user can only access it when clicking on Profile > Ask for help

Based on talking with the Pylon team, we can leverage their javascript API to have the in-app chat appear expanded once the help button is pushed. Similarly, if we wanted to hide the collapsed version of the chat, there should be an onChangeUnreadMessagesCount handler that we can register a callback with, so we can do things like show the chat only if there is a new message for the customer, etc.

FYI @mindspank for input on the correct product design
FYI @cohenscottr @ericpgreen2 for awareness

As per the reqs above:
Only applicable for deployed projects in Rill Cloud. Not for local.
For Admin users

On every Cloud UI page, display the standard pylon widget.

For All users

For dashboards we would hide the standard pylon widget and instead trigger the chat window on Profile -> Ask for help

@mindspank Updating this GH issue to reflect our desire to broadly enable Pylon in Rill and you can check the original comment for the proposed approach. Please let me know if we feel comfortable with approaching (alternative would be to not introduce another button but simply replace Profile > Ask for help with Pylon instead of a link to Discord).

@ericpgreen2 Requirements should be updated to reflect the latest and we should feel free to implement


virl2node.tf: Update to match virl2node.tf.orig

did the merge since some bits did actually belong...the files should be in sync now


Can't use template in single file component

Version
2.3.4
Reproduction link
https://github.com/wansj/shift
Steps to reproduce
1.meteor create project-name --full
2.meteor remove blaze-template reactive-var standard-minifier-css
3.meteor add akryum:vue-component static-html juliancwirko:postcss
4.create App.vue and NotFound.vue in the imports/ui/pages directory, The content can be found https://github.com/wansj/shift/blob/master/imports/ui/pages/App.vue and https://github.com/wansj/shift/blob/master/imports/ui/pages/NotFound.vue
5.Replace the imports/startup/client/routes.js with https://github.com/wansj/shift/blob/master/imports/startup/client/routes.js
6.Replace the imports/startup/client/index.js with https://github.com/wansj/shift/blob/master/imports/startup/client/index.js
7.meteor run
What is expected?
Help!
What is actually happening?
I got:
[Vue warn]: You are using the runtime-only build of Vue where the template compiler is not available. Either pre-compile the templates into render functions, or use the compiler-included build.

I'm writing a vue   meteor app, and I used the<EMAIL_ADDRESS>package.My vue version is 2.3.4, meteor version is 1.5.

Vue ships in 2 variants, runtime-only has no template-compiler in runtime, to use standalone build you can use import Vue from 'vue/dist/vue.esm.js' instead of import Vue from 'vue'.
P.S. please to ask questions use forum or gitter instead of opening issues on github.

thank you, I will have a try.

import Vue from 'vue/dist/vue.esm.js' caused Uncaught SyntaxError: Unexpected token export. Because vue.esm.js uses es6 module export, which can't be recoginized by meteor even if I add the poorvavyas:es6-shim package. But import Vue from 'vue/dist/vue.js' works for me.


TES-290 Include helper scripts in AWS AMI

Description
Added helper scripts that perform the following tasks:
Search for an available EBS volume to attach to the instance. If no volume is found - create new one, attach, format and mount the volume.
Register the instance in Route 53, using the volume id for the sub-domain.
Configure the GraphDB backup cron job
Related Issues
https://ontotext.atlassian.net/browse/TES-290
https://ontotext.atlassian.net/browse/TES-212
https://ontotext.atlassian.net/browse/TES-270
Changes
Added three new files:
create_backup.sh
ebs_volume.sh
register_route53.sh
Screenshots (if applicable)
Checklist

[x] I have tested these changes thoroughly.
[x] My code follows the project's coding style.
[x] I have added appropriate comments to my code, especially in complex areas.
[x] All new and existing tests passed locally.

This is quite outdated, closing it.