menuconfig on Windows doesn't work if mingw32 gcc is installed

I have the msys32 installed as per the install script. I also have mingw32's gcc installed. If you run the mingw32 shell, that gcc runs. However it is not capable of compiling the output of flex. I get the following:
In file included from zconf.tab.c:2448:0:
zconf.lex.c:1076:10: fatal error: wordexp.h: No such file or directory
#include <wordexp.h>
^~~~~~~~~~~
compilation terminated.
Not sure what can be done with that since there is no flex for mingw32, only msys. And that only builds with the msys gcc. The workaround is to do the menuconfig with the msys shell and the rest from mingw32.

Hi @dschaefer,
I see. I think you're right that there's currently no way to support "wordexp" in a pure mingw32 environment. (For what it's worth, the problem is less with flex and more with kconfig itself, the input zconf.l file already has wordexp.h hardcoded into it.)
The only other workarounds I can think of are to keep a separate MSYS root for IDF use only, or to override CC & LD via make's environment. ie:
CC=/usr/bin/gcc LD=/usr/bin/ld make menuconfig

I'm going to close this because I don't think there's anything we can do to fix it properly in IDF, but hopefully anyone who bumps into this error will find this issue when they search. Please reopen if you think we should address it in some other way.

OK. Thanks! The workarounds are fine. But they should probably be in the documentation in case someone else runs into it..

Fair enough. Reopening until we add a note to the docs.

Ended up being easier to work around this transparently in the Makefile than add a note to the docs.
We have just discovered one remaining known issue though, Eclipse on Windows will still use the wrong compiler - Python is a mingw32 Python and it prepends C:\msys32\mingw32\bin to the PATH which causes cc & ld to still be the mingw32 versions.
Reopening until we have this fixed in Eclipse as well...

BTW, I will be publishing an article on how to use CDT's new Core Build with esp-idf. It's a lot simpler than the older managed build and shows off how to add support for a platform and toolchain without writing an Eclipse plugin.
I still have to figure out how to run make menuconfig. Maybe in the terminal view, maybe in an external msys2 shell. A Kconfig editor would be really helpful ;) but I'll leave that to the community.

BTW, I will be publishing an article on how to use CDT's new Core Build with esp-idf. It's a lot simpler than the older managed build and shows off how to add support for a platform and toolchain without writing an Eclipse plugin.

This is very interesting!

I still have to figure out how to run make menuconfig. Maybe in the terminal view, maybe in an external msys2 shell. A Kconfig editor would be really helpful ;) but I'll leave that to the community.

We have had some discussion about this internally as well, but no plans yet.


Readme: add docker partial message example before Docker 18.06.

Follow-up of https://github.com/fluent-plugins-nursery/fluent-plugin-concat/issues/56

Thanks!!


Testing upstream containers in OpenShift 4 environment

This issue is going to be used as a tracker for testing SCL containers in OpenShift 4 environment.
Please reference all PRs in container-common-scripts into this issue.
Tests are run by PR comment [test-openshift-4].
What should be done:

set path to oc binary to version 4 ct_os_set_path_oc
set docker registry by Image Registry Operator (https://docs.openshift.com/container-platform/4.3/registry/configuring-registry-operator.html)
???

PR:

[x] https://github.com/sclorg/container-common-scripts/pull/145
[x] https://github.com/sclorg/rhscl-container-ci/pull/35

Proof of Concept: https://github.com/sclorg/s2i-php-container/pull/286

This can be closed.
Relevant PR are:
https://github.com/sclorg/container-common-scripts/pull/150
https://github.com/sclorg/s2i-nodejs-container/pull/249


Optimize Muse connection code for different phones

Some more work should go into making sure the connection code works for all types of phones (e.g. Google Pixel seemed to have problems, surprisingly). Support from Interaxon team would be nice here

Interaxon team reassured me that the way we're connecting to Muses now is still the best way to connect to Muse on any Android.
However, there were a number of recommendations on how to refactor and improve our ConnectorModule code. Those changes will be coming in an update soon.


updates and fixes

closes https://github.com/ericphanson/TravelingSalesmanExact.jl/issues/27
updates Asciicast, Documenter, suggests HiGHS, tests with HiGHS

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.88%.  Consider uploading reports for the commit d17dd1f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   97.87%   97.88%   +0.01%
==========================================
  Files           1        1
  Lines         188      189       +1
==========================================
+ Hits          184      185       +1
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


cf-tooling-ELB-IG0IDYIGK1IM is completely unused

Bad certificate and no instances running

Needs to be deleted.


ROBOT preprocessing fails due to null value

The ROBOT relax fails because of the following error when parsing DOID_617:
ROBOT encountered an error:

  RAN: /home/harry/BioPortal-to-KGX/robot relax --input /tmp/tmpq3t8cyv0 --output transformed/ontologies/DOID/DOID_617_relaxed.json --vvv

  STDOUT:
2022-03-07 14:01:21,081 DEBUG org.obolibrary.robot.IOHelper - Loading ontology /tmp/tmpq3t8cyv0 with catalog file null
2022-03-07 14:01:21,082 DEBUG org.semanticweb.owlapi.utilities.Injector - Loading file META-INF/services/org.semanticweb.owlapi.model.OWLOntologyManager
2022-03-07 14:01:21,083 DEBUG org.semanticweb.owlapi.utilities.Injector - Loading URL for service jar:file:/home/harry/BioPortal-to-KGX/robot.jar!/META-INF/services/org.semanticweb.owlapi.model.OWLOntologyManager
2022-03-07 14:01:21,083 DEBUG org.semanticweb.owlapi.utilities.Injector - Loading URL for service jar:file:/home/harry/BioPortal-to-KGX/robot.jar!/META-INF/services/org.semanticweb.owlapi.model.OWLOntologyManager
2022-03-07 14:01:21,083 DEBUG org.semanticweb.owlapi... (24347 more, please see e.stdout)

  STDERR:
java.lang.NullPointerException: Cannot invoke "String.toString()" because "lv" is null
        at org.geneontology.obographs.owlapi.FromOwl.generateGraph(FromOwl.java:409)
        at org.geneontology.obographs.owlapi.FromOwl.generateGraphDocument(FromOwl.java:63)
        at org.obolibrary.robot.IOHelper.saveOntologyFile(IOHelper.java:1684)
        at org.obolibrary.robot.IOHelper.saveOntology(IOHelper.java:838)
        at org.obolibrary.robot.CommandLineHelper.maybeSaveOutput(CommandLineHelper.java:671)
        at org.obolibrary.robot.RelaxCommand.execute(RelaxCommand.java:113)
        at org.obolibrary.robot.CommandManager.executeCommand(CommandManager.java:248)
        at org.obolibrary.robot.CommandManager.execute(CommandManager.java:192)
        at org.obolibrary.robot.CommandManager.main(CommandMa... (97 more, please see e.stderr)
ROBOT relax of DOID_617 failed - skipping.

The next transform continues as expected, but DOID doesn't get transformed.

This also happens with NIFSTD_27

I think the error starts here in obographs:
https://github.com/geneontology/obographs/blob/1a892a802dfb362018a7deea879ce75b54bbb563/obographs-owlapi/src/main/java/org/geneontology/obographs/owlapi/FromOwl.java#L410-L413
suggesting that lv is null in a comment in the source triples.
(and maybe this block should be preceded by if (lv != null))

Tried this but the output seemed to be missing too much content:
robot remove -vvv --input e67d70df45f6f4cc5b70b1296091 --axioms annotation --output DOID_617_fixed.json

Including --trim false raised a similar error as before:
robot remove -vvv --input e67d70df45f6f4cc5b70b1296091 --axioms annotation --trim false --output DOID_617_fixed.json
...
OBO GRAPH ERROR Could not convert ontology to OBO Graph (see https://github.com/geneontology/obographs)
For details see: http://robot.obolibrary.org/errors#obo-graph-error
java.io.IOException: errors#OBO GRAPH ERROR Could not convert ontology to OBO Graph (see https://github.com/geneontology/obographs)
        at org.obolibrary.robot.IOHelper.saveOntologyFile(IOHelper.java:1720)
        at org.obolibrary.robot.IOHelper.saveOntology(IOHelper.java:846)
        at org.obolibrary.robot.CommandLineHelper.maybeSaveOutput(CommandLineHelper.java:667)
        at org.obolibrary.robot.RemoveCommand.execute(RemoveCommand.java:202)
        at org.obolibrary.robot.CommandManager.executeCommand(CommandManager.java:244)
        at org.obolibrary.robot.CommandManager.execute(CommandManager.java:188)
        at org.obolibrary.robot.CommandManager.main(CommandManager.java:135)
        at org.obolibrary.robot.CommandLineInterface.main(CommandLineInterface.java:60)

Alternate option: http://robot.obolibrary.org/query#sparql-update
Other alternate: just parse the file and remove offending lines with a regex prior to robot relax

This should work:
robot remove -vvv --input e67d70df45f6f4cc5b70b1296091 --term rdfs:comment --output DOID_617_fixed.json


Addition to Screen Markers

This isn't really anything new, rather combining the features of a few other plugins.
But I think it would be neat to have a plugin or an addition to the Screen Markers plugin that would allow you to save your screen markers, camera position + client size together as Custom "Scenes".
This then allowing you to have multiple scenes you can select through dependent on what content you're doing in-game.
For myself who doesn't play fixed, I often will adjust my client size depending on what I'm doing and how many accounts I'm playing on. Having the ability to quickly switch between different client sizes and the option to include camera angle + screen markers would be a great addition for those who often jump between different content.

This already exists in a plugin called "Camera Positions". It's similar to 'inventory setups' but with camera zoom and angle being saved

This already exists in a plugin called "Camera Positions". It's similar to 'inventory setups' but with camera zoom and angle being saved

Does it also save client size?

This already exists in a plugin called "Camera Positions". It's similar to 'inventory setups' but with camera zoom and angle being saved

Does it also save client size?

I do not believe it has client size but that would be a great addition.

yeah it would be nice to be able at least group screen markers, when you have 50 of them it becomes bit unmanageable

Duplicate of #3195
Duplicate of #3205
Duplicate of #3784


Update documentation

This includes deployment information

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

criproxy.dot, line 3 at r1 (raw file):

digraph criproxy {
        criproxy [label="CRI Proxy\nServer"];
        dockershim [label="dockershim"];

Whitespaces.

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

criproxy.dot, line 3 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Whitespaces.

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


ci: test Node.js 6, 8, 10 and 11

Current LTS branches are 6, 8 and 10 and 11 is stable. We should test on all of them to ensure that there are no breaking builds on newer versions.

Coverage remained the same at 94.828% when pulling c16e555a456c37244cdfef0b252748185f74c165 on DanielRuf:ci/test-nodejs-6-8-10-11 into 08e8bbeaa76c5ec194abea388a193bedac7f35fc on fridays:master.

Coverage remained the same at 94.828% when pulling c16e555a456c37244cdfef0b252748185f74c165 on DanielRuf:ci/test-nodejs-6-8-10-11 into 08e8bbeaa76c5ec194abea388a193bedac7f35fc on fridays:master.

Bump. This is still relevant.


Helm: sanitize resource name lengths

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR addresses a but in the Helm chart. Some of the resources generated by the Helm chart are very long. Combined with the release name, they can easily get too long.
Example
Let's look at the resource {{ include "kueue.fullname" . }}-controller-manager-metrics-service of kind: Service. When generated for a somewhat long release name like project-foo-cluster-bar-kueue, the resulting resource name is project-foo-cluster-bar-kueue-controller-manager-metrics-service which is 65 characters long and we get the following error when trying to apply/install:
Service "project-foo-cluster-bar-kueue-controller-manager-metrics-service" is invalid: metadata.name: Invalid value: "project-foo-cluster-bar-kueue-controller-manager-metrics-service": must be no more than 63 characters

Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE (it only affects names for resources that would have been too long and therefore failed anyway. Existing resources remain unchanged)

Helm: Sanitize resource names by truncating them to a maximum length of 63 characters

/ok-to-test

/hold
I tried to test with "project-foo-cluster-bar-kueue-controller-manager-metrics-service" and it's not working.
Error: INSTALLATION FAILED: clusterroles.rbac.authorization.k8s.io "kueue-project-foo-cluster-bar-kueue-controller-manager-metrics" already exists

I think we need to add some test cases for helm.
@mimowo @tenzen-y WDYT?

+1 on e2e tests, feel free to open the issue and follow up. I guess they could have a dedicated run like mk, but we can discuss details later.
We often have issues with helm which are hard to see just by static code analysis. Thanks for checking.

I tried to test with "project-foo-cluster-bar-kueue-controller-manager-metrics-service" and it's not working.

Yeah okay, if the release name itself is longer than 63 chars, all-the-things are named the same. I haven't seen any chart accounting for that, though. But one could change the order (start with the specific resource name and suffix it with the release name)

I think we need to add some e2e test case for helm.

Agreed. Especially these bulk search-and-replace fixes don't come without risks...

Or obviously: truncate the release name to a max length instead of the resulting resource name...

We already do that https://github.com/kubernetes-sigs/kueue/blob/main/charts/kueue/templates/_helpers.tpl#L21.

Or obviously: truncate the release name to a max length instead of the resulting resource name...

We already do that https://github.com/kubernetes-sigs/kueue/blob/main/charts/kueue/templates/_helpers.tpl#L21.

I see. But it should be truncated to a length that is 63 - charlength(longsest_suffix) if you know what I mean.

I see. But it should be truncated to a length that is 63 - charlength(longsest_suffix) if you know what I mean. This would make the changes in this PR redundant. But it's harder to maintain.

Can we calculate charlength(longsest_suffix)?

Can we calculate charlength(longsest_suffix)?

I don't think you can do that globally in _helpers.tpl. You could probably do it in each resource's template...

Or obviously: truncate the release name to a max length instead of the resulting resource name...

We already do that https://github.com/kubernetes-sigs/kueue/blob/main/charts/kueue/templates/_helpers.tpl#L21.

I see. But it should be truncated to a length that is 63 - charlength(longsest_suffix) if you know what I mean. This would make the changes in this PR redundant. But it's harder to maintain.

I would say 63 - {{.Release.Namespace}} - charlength(longsest_suffix)

Can we calculate charlength(longsest_suffix)?

I don't think you can do that globally in _helpers.tpl. You could probably do it in each resource's template...

Probably we can calculate it in update-helm.sh when templates generating and after that update longsest_suffix_length in _helpers.tpl.


[multistage] returning empty string('') instead of null for Case/When

Case/When Query  is failing because of returning '' empty string instead of null.
SELECT intCol, CASE WHEN boolCol = true THEN 'Yes' END AS boolVal, strCol FROM {tbl1}
java.lang.AssertionError: Not match at (1,1)! Expected: [2, null, two] Actual: [2, , two]
Expected :0
Actual   :1

It should return NULL but returns '' (empty string) when the case is not matched.
cc @ankitsultana @walterddr

cc @61yao as it is related to the null support

It's not specific to the above query. It's happening for all queries without the ELSE clause. Here are more examples
SELECT intCol, CASE WHEN intCol % 2 = 0 THEN intCol END AS intVal, strCol FROM {tbl1}
SELECT intCol, CASE WHEN floatCol > 4.0 THEN floatCol END AS floatVal, strCol FROM {tbl1}
SELECT intCol, CASE WHEN doubleCol > 6.0 THEN doubleCol END AS doubleVal, strCol FROM {tbl1}
SELECT intCol, CASE WHEN longCol > 10 THEN longCol * 4 END AS longVal, strCol FROM {tbl1}

I checked the code. It should be calling the scalar case when functions. And seems like it has been fixed. @abhioncbr @walterddr

This calls caseWhenTransform function. It doesn't handle return null when condition is not matched. This is a known issue we will fix soon.
Please refer https://github.com/apache/pinot/issues/10252 for progress and design doc

Thanks, @61yao for the information and for sharing the design doc. Let me know, if I can pick/contribute some work. Thanks

Fixed.


Dropdown and Custom selection for Section field

Fixes #91
What was changed?
Changed default input field type in sections field to select options with first, last and custom as options. and data field in onSubmit and fetchDocumentPreview the sections is changed to so that objects is converted to array and match the backend data fields
Why was it changed?
#91 issue is to have a dropdown feature for sections field with first, last and custom as options. whereas first gives section 1 data, last gives last sections data and custom is similar to earlier input field where we can give 1,2,3... or range of values (1-5) .
How was it changed?
*files that I changed: in client-app->src->components->(DraftOrcaDashboard.js and OrcaDashboardComponents.js) files.
exact sections and lines of code where I changed:
in DraftOrcaDashboard.js:
onSubmit and fetchDocumentPreview part
const data = {}
lines changed: 100 - 107 and 175 - 182
and
Number of sections?
from single input filed to dropdown options first, last and custom (when custom selected new input field to enter sections will be created.
lines changed: 270 - 302)
same changes are made in OrcaDashboardComponent.js file
onSubmit and fetchDocumentPreview lines changed: 40 - 53; 80 - 93
Number of sections? lines changed: 150 - 183*
Screenshots that show the changes (if applicable):

@hmunjampally - Thank you for your contribution to the project! I will review the PR and let you know if any changes are required.

@hmunjampally - Great work! Tested it, and the frontend implementation looks good! However, this PR should wait until the backend changes are implemented, since merging this now would break the Preview and Download features.
@vakhil-98 - Please use these frontend changes and implement the backend functionality for the issue #91


Allow click-through for Find Account Window

After the account is found and displayed in find account window allow users to click on the account and navigate towards it.


x509-certificate-exporter crash loop on ARM64

Describe the bug
CrashLoop of the container.
To Reproduce
See the kustomization for Homelab
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
❯ kubectl -n monitoring logs prometheus-x509-certificate-exporter-84844bbdc5-grht6
standard_init_linux.go:228: exec user process caused: exec format error

Configuration (please complete the following information):

Kubernetes: [e.g. GKE] k3s
Version [e.g. 22] 1.21

Additional context
Add any other context about the problem here.

See : https://github.com/enix/x509-certificate-exporter/pull/19


Captcha leads to throttle errors on the site

Description
It is unclear what all the errors are but it is clear that when the captcha box shows up, it  is capable of breaking existing flows including but not limited to:

Search autocomplete
Comment posting

Moved to https://github.com/ResearchHub/issues/issues/21


support for useMutation return value in react-apollo-hooks 0.5.0

Is your feature request related to a problem? Please describe.
useMutation react-apollo-hooks 0.5.0-alpha.0 returns a tuple with the mutation function and an object with properties such as data, loading, error, called, etc.  Ex:
const [mutate, { data, loading, error }] = useMutation(GQL);

It would be nice to be able to use useMutation as specified in react-apollo-hooks 0.5.0

Hi @gentleShark !
Thank you for reporting it.
Can you please let us know what preventing you from using it now?
The generated hook is just a wrapper around the original useMutation (for example, see https://github.com/dotansimha/graphql-code-generator/blob/master/dev-test/githunt/types.reactApollo.hooks.tsx#L517-L518), so I'm not sure why it doesn't work as needed.

You're right @dotansimha. After digging into it a bit more I can confirm that the useMutation hook generated by graphql-codgen returned the correct types for the tuple returned by useMutation in react-apollo-hooks  0.5.0-alpha.0. Thanks!


Missing documentation for hpx::util::annotated_function

hpx::util::annotated_function is completely absent from the documentation (http://stellar-group.github.io/hpx/docs/html/) and the examples.

We'd be happy to accept a patch adding this missing documentation.

@hkaiser Hello I am new to STELLAR-GROUP and I want to start working on this issue . Please guide me how to start ..

@victor-ludorum This is a documentation task. We'd very much appreciate it if you worked on this.
I think for you to start working on this issue you should first do two things: a) understand what is the functionality of hpx::util::annotated_function, and b) familiarize yourself with the documentation toolchain we use for HPX. The first can be done by looking at the source code (naturally there is no documentation for hpx::util::annotated_function). For the second you may want to start installing things as described here: https://stellar-group.github.io/hpx/docs/html/hpx/manual/build_system/building_hpx/doc_tools.html and make sure that you can build the existing docs. Then you might want to browse the quickbook documentation (http://www.boost.org/doc/libs/1_66_0/doc/html/quickbook.html), as this is the tool used to parse our .qbk files.
Once those tasks are accomplished it shouldn't be difficult to extend the existing docs by adding text describing what you've learnt.

@hkaiser Okay sir thanks for the reply . I will do as you have mentioned .


updated

improvised the UI and added a few new links #3

@PavvanPradeep you have merge conflicts please resolve them and add your changes after that

Hey @PavvanPradeep - I noticed you've directly added the entire covid19india.org website, which has been a standing example of community effort during tough times.
We shall go ahead and not award you any bounty points for this, and we'll go ahead and close this PR.


BOSH release properties validations before deployment

Hey, all.
A lot of errors can occur because of a "human factor". I mean that errors in BOSH manifests can be caused by misspelling or misunderstanding of BOSH release properties. Even if BOSH can check some type of errors in manifest properties, often it is not enough.
I am pretty sure that teams that are implementing BOSH release are the best people who can put reasonable validations to properties fields. That's why I'm sure that it will be a good thing to provide a way to add validations to BOSH release properties during implementation. At this moment job spec (example) contains only following fields: description, default and the name of the property. I suggest adding type and validations fields to this sections. The easiest way to validate properties will be checking their types and validating across regexp.
This feature will allow to aware user to set database schema to postgresql, not postgres and will save user's time to find out what's wrong.
What do you think about this feature?

We are planning to add some kind of types for the properties. I have not had a chance to write something up yet.
Imho there are several common high level types and few basic types that we should introduce. For example basic types could be: string, int, float, array of X. For the high level types I think there are a few ones centered around networking: port, IPs, domain, etc. and some around credentials: SSL certs, passwords, usernames, uuids.
Different levels of validations could also be involved here: some basic checks against the types, and more complex dependency like validations. For example if some property is specified, user must specify another property, possibly with specific set of values. I'm not sure we can easily describe more complex case without making an extremely verbose definition. At that point it's probably not worth it, but for the simple cases when we could check on the length, etc it's definitely something I'm looking forward to.

Hey, @cppforlife. I decided to move our discussion here.
I like an idea to run validations on bosh-director side, still there are lots of questions for me:

do you plan to implement a validators only for properties (such as checks for property types) or do you plan to validate in more complex way the whole deployment manifest (checking for using unnecessary properties, checking if jobs support selected stemcells)?
What about job specific validations (for example, when one job should not be colocated with another)?
How do you plan to extend validators? Will it be possible to provide custom validators?
Are you going to create a bosh director endpoint to return release properties? (I'm interested because it will allow to build meta services based on BOSH)

Thank you.

I've finally collected my notes and pushed https://github.com/cloudfoundry/bosh-notes/commit/5301f6fa4c8f73b20337900b95a0a5f63d20bb3a. Hopefully that gives you an idea of what I'm currently planning.
And to answer your questions above:

do you plan to implement a validators only for properties (such as checks for property types) or do you plan to validate in more complex way the whole deployment manifest (checking for using unnecessary properties, checking if jobs support selected stemcells)?

unnecessary properties validation is planned
stemcell version checking is not quite there

What about job specific validations (for example, when one job should not be colocated with another)?

this one is an interesting one. can you give me few concrete examples you are thinking about?

How do you plan to extend validators? Will it be possible to provide custom validators?

i'm not eager to introduce custom validators just yet. may be that would be something that config server could be expanded to do. any concrete examples?

Are you going to create a bosh director endpoint to return release properties? (I'm interested because it will allow to build meta services based on BOSH)

i think it makes sense to expand API bosh inspect release uses to return more job metadata. PR welcome for this one.

Thank you for the answer. I will dig deeper into bosh inspect release later.
Talking about examples of job specific validations, here are some I can think of:

cluster of etcd jobs shouldn’t contain even number of instances.
login job shouldn't not be used if you use cf v214 and higher
check situation if job uses the same path on file system to store data with another job and this can cause a conflict
some time ago (in times of login=>uaa transition) Login and UAA templates could not work together on a same job.

It also would be nice to have possibility to print warning messages (enabled by some flag), if you are trying to run HA / production deployment. For instance, the verificator could print warning for the case if you don't have redundancy on some job or something. Using metadata from release you can even calculate expected downtime during upgrade and do other great stuff.


Fix problem with DNS on generic installation

CC @balloob @frenck
I should move this out to a repo like hassio-generic...

@pvizeli @balloob Docker 18.09 is now beta stage (3rd version). That actually solves all the issues people are having.

@pvizeli The daemon.json file can be created before the installation of Docker. That removes the need to restart Docker during the setup.


Package release/prerelease status

Hi Stephen,
Firstly, thanks for all of the helpful resources you have produced over the years regarding how to best incorporate asynchronous programming into WPF/MVVM applications. They have been extremely helpful, especially as the combination of WPF, MVVM, and async/await seems to be something that there is no "perfect" solution for.
Next, apologies if creating an issue wasn't the right thing to do here, as all I really have is a quick question regarding the status of this NuGet package:
I am mainly interested in using the NotifyTask type (basically for the same reason as this question) but was just wondering if there is a specific reason why you haven't moved this package out of its "prerelease" state yet? Should I take that to mean it's not "prod ready"?
Thanks again,
Adam

The NotifyTask type is certainly production ready. The Mvvm.Async package as a whole is not production ready yet because there's still some work to do on AsyncCommand and friends.

@StephenCleary Any ideas on when this might be done?

No. I don't have the bandwidth to work on async commands right now.


Property 'manage' doesn't exist on type 'ProtractorBrowser'

I am trying to use browser.manage().window().maximize() in my config and specs, The typescript compiler throws the above error. I think the method is not yet exported! Similar case is for browser.switchTo().alert() few of the properties are still not exported!

Protractor Version: 4.0.3

This is an issue. For now, could you use browser.driver.manage and browser.driver.switchTo?

Yup, using browser.driver as a workaround !
Also Craig I have one other issue which i commented here https://github.com/angular/protractor/issues/3431 .Its kinda blocker when using onPrepare function in config.ts.


Proposal: All input and selection controls should implement IInputValidationControl Interface

Proposal: All input and selection controls should implement IInputValidationControl Interface

All controls should implement the interface so that the underlying viewmodel can provide error information regardless of the intended use case of the control.   DatePicker for instance does not implement the interface, and thus consistent validation of fields cannot be performed.
Summary

Implement IInputValidationControl Interface on all controls
Rationale

Consistency of Control features
Dev may have a use case for the control other than originally intended
DatePicker (and others) do not have the interface -possibly because the creator thought that the data input is controlled in such a way that the data is always valid.  Unfortunately, a valid date input can be outside of a given range and be invalid.  Since this control does not validate, there is neither a UI indicator of validation failure, nor a way to query the control for such condition.
It is common, and desirable to validate a page of various fields, and if one or more validations fail, focus the first failed control.  This is highly desired by end users to reduce their interaction to select a failed input.
While we can query the viewmodel for validation, this is not good enough.  The UI must be capable of being responsive to invalid input at the Control level to provide the best UX.  Therefore, each control must expose the validation state of the bound data.

Duplicate/Related to #5859 and #4567. Also see comment here about existing IDataNotifyErrorInfo interface: https://github.com/microsoft/microsoft-ui-xaml/issues/5859#issuecomment-1108994525

Also see #179.


Better Styling for Options Menu

The options menu in the abstract-output-component has a different look and feel than the rest of the application. It should be possible to css style it so that we can re-use the theia styles for it.

Picking up this issue


image: Add shellcheck to the image

/cc @0xFelix
What this PR does / why we need it:
This needs to be a separate step in order for our post submit jobs to trigger and build the new image. This then needs to be used by our pre-submit job before adding the use of shellcheck to the lint script.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/hold
Just need to wait for https://github.com/kubevirt/project-infra/pull/2432 before we merge this.

/retest

/lgtm
/approve

/hold cancel


Update documentation: passwords will be cleared

Fixes #3

@dgryski is this what you meant?

Yes, if we're overwriting an input parameter, the docs should make this clear.
(Note that I'm still not convinced we should be zeroing out the password...)

I think it would be better to leave that responsibility with the caller as with x509.DecryptPEMBlock.

@paulmey keep or close this PR?

Depends on #3, but right now this is the case so having documentation that matches makes sense.

@ahmetalpbalkan I put you on point to decide #3 and hence whether to merge this or revert the bits of code that clear the password arrays

closing in favor of #21


pubsub: iterator.Next() needs to take its own context?

Because the iterator.Next() request doesn't take a context and uses the client's context it's a bit awkward to manage timeouts in Next().   For example when we get the following RPC error, it puts the Next() request into a deadlock since Invoke will retry forever:
err:rpc error: code = 14 desc = A pull requests for subscription '/subscriptions/TUNC' went to a server that is temporarily overloaded. Please try the request again.

But we can't add a timeout to the client's context since it's expected to run for days.
Our current workaround it to cancel the context provided to the client and then completely recreate the client.  But it would make for cleaner code if we could just do:
      for {
 		ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
		psMsg, err := iter.Next(ctx) //giving Next it's own context.
		if err != nil {
			switch err {
                        case context.ErrDeadlineExceeded:
 				continue
			case iterator.Done:
				break
			default:
				return err
			}
              }
              cancel()
              //process message
      }

I understand why this is useful in the abstract, but I don't understand your specific example. Do you actually encounter an UNAVAILABLE error like that which never goes away? Are you experiencing that against the production service?

@jba sorry it's taken me a bit to get back too you, have been busy putting out fires pubsub... :p
In the last week all our touch points with the pubsub package have started hanging.  We first noticed it with topic publish.  The fix for all of them except message iterating were easy, and involved adding a context with a timeout.
The stack dumps in most cases show that pubsub package was stuck in the pubsub's invoker, which seems to retry forever until the give context is canceled/time-outed.   The following is an example were it got stuck in the message iterator call.
goroutine 678 [select]:
github.com/lytics/all/vendor/google.golang.org/grpc/transport.(*Stream).Header(0xc421cebf00, 0x561f4c1efb10, 0xc42067f880, 0x561f4c6ecf20)
	/home/sniffe/go/src/github.com/lytics/all/vendor/google.golang.org/grpc/transport/transport.go:244 +0x299
github.com/lytics/all/vendor/google.golang.org/grpc.recvResponse(0x7f70ddca8720, 0xc4219fc090, 0x0, 0x0, 0x561f4c6e9a40, 0x561f4c723db0, 0x0, 0x0, 0x0, 0x0, ...)
	/home/sniffe/go/src/github.com/lytics/all/vendor/google.golang.org/grpc/call.go:63 +0xaa
github.com/lytics/all/vendor/google.golang.org/grpc.invoke(0x7f70ddca8720, 0xc4219fc090, 0x561f4c1875b4, 0x21, 0x561f4c0d9b20, 0xc421bdbc20, 0x561f4c0ec960, 0xc421bdbc60, 0xc4201dc240, 0x0, ...)
	/home/sniffe/go/src/github.com/lytics/all/vendor/google.golang.org/grpc/call.go:252 +0x92d
github.com/lytics/all/vendor/google.golang.org/grpc.Invoke(0x7f70ddca8720, 0xc4219fc090, 0x561f4c1875b4, 0x21, 0x561f4c0d9b20, 0xc421bdbc20, 0x561f4c0ec960, 0xc421bdbc60, 0xc4201dc240, 0x0, ...)
	/home/sniffe/go/src/github.com/lytics/all/vendor/google.golang.org/grpc/call.go:143 +0x19c
github.com/lytics/all/vendor/google.golang.org/genproto/googleapis/pubsub/v1.(*subscriberClient).Pull(0xc420142248, 0x7f70ddca8720, 0xc4219fc090, 0xc421bdbc20, 0x0, 0x0, 0x0, 0x8, 0xc420130118, 0x0)
	/home/sniffe/go/src/github.com/lytics/all/vendor/google.golang.org/genproto/googleapis/pubsub/v1/pubsub.pb.go:658 +0xd2
github.com/lytics/all/vendor/cloud.google.com/go/pubsub/apiv1.(*SubscriberClient).Pull.func1(0x7f70ddca8720, 0xc4219fc090, 0x561f4bb71da9, 0xc42067fb88)
	/home/sniffe/go/src/github.com/lytics/all/vendor/cloud.google.com/go/pubsub/apiv1/subscriber_client.go:326 +0x7b
github.com/lytics/all/vendor/github.com/googleapis/gax-go.invoke(0x7f70ddca8720, 0xc4219fc090, 0xc421bdbc40, 0x0, 0x561f4c1ef3d8, 0x561f4ba6e0d8, 0x20)
	/home/sniffe/go/src/github.com/lytics/all/vendor/github.com/googleapis/gax-go/invoke.go:70 +0x4d
github.com/lytics/all/vendor/github.com/googleapis/gax-go.Invoke(0x7f70ddca8720, 0xc4219fc090, 0xc421bdbc40, 0x0, 0x0, 0x0, 0xc42067fc58, 0x561f4ba6e0d8)
	/home/sniffe/go/src/github.com/lytics/all/vendor/github.com/googleapis/gax-go/invoke.go:48 +0xc5
github.com/lytics/all/vendor/cloud.google.com/go/pubsub/apiv1.(*SubscriberClient).Pull(0xc4203f6420, 0x7f70ddca8720, 0xc4219fc090, 0xc421bdbc20, 0x0, 0x0, 0x0)
	/home/sniffe/go/src/github.com/lytics/all/vendor/cloud.google.com/go/pubsub/apiv1/subscriber_client.go:328 +0x1a3
github.com/lytics/all/vendor/cloud.google.com/go/pubsub.(*apiService).fetchMessages(0xc420284290, 0x7f70ddc1eec8, 0xc420914980, 0xc420d28230, 0x4b, 0x561f000003e8, 0x561f4c723db0, 0x0, 0x0, 0x0, ...)
	/home/sniffe/go/src/github.com/lytics/all/vendor/cloud.google.com/go/pubsub/service.go:252 +0xc9
github.com/lytics/all/vendor/cloud.google.com/go/pubsub.newPuller.func1(0x561f4c723db0, 0x0, 0x0, 0x0, 0x0)
	/home/sniffe/go/src/github.com/lytics/all/vendor/cloud.google.com/go/pubsub/puller.go:55 +0x5e
github.com/lytics/all/vendor/cloud.google.com/go/pubsub.(*puller).Next(0xc420d5a9b0, 0x0, 0x0, 0x0)
	/home/sniffe/go/src/github.com/lytics/all/vendor/cloud.google.com/go/pubsub/puller.go:82 +0x124
github.com/lytics/all/vendor/cloud.google.com/go/pubsub.(*MessageIterator).Next(0xc420914a40, 0x0, 0xc420685260, 0x0)
	/home/sniffe/go/src/github.com/lytics/all/vendor/cloud.google.com/go/pubsub/iterator.go:93 +0x33
github.com/lytics/lio/src/eventstore/pubsubstore.(*pubsubIterator).runFetcher(0xc420d3cd70, 0x1, 0xc420d5c450)
{RM'ing MY CODE}

After fixing all the calls to the pubsub package the last remaining one was the calls to MessageIterator.Next(), which resulted in a pretty hacky workaround :(.  Basically I created a monitoring go routine that detects if a MessageIterator's rate drops to zero.  If it does, then it cancel's the iterator's context and recreates the MessageIterator.   It works but has some downsides, like not being able to ack any in-fight messages after the original iterator is killed.
I'm not sure what the exact error was that caused the invoker to retry forever as canceling the context just returns DeadlineExceeded error.  But I have seen the following two errors over the last couple of days in our logs.
2017/01/30 19:04:24 Failed to decode ("google.rpc.debuginfo-bin", "Q2xkamIyMHVaMjl2WjJ4bEx...TRUNCED...a3hNVFEzTmpnME1BPT0"): illegal base64 data at input byte 2056

rpc error: code = 14 desc = A pull requests for subscription '/subscriptions/foobar/events-aid-123' went to a server that is temporarily overloaded

When it locks up, it seems to only hit a subset of the topics/subscriptions but it effects that subscription across the board.  For those that do lock up, it happens to all message iterators from multiple machines within a few mins.
We consume between 20,000 and 80,000 messages per second, at about 20/80MB sec.  We consume the subscriptions from about 30 machines.  We have a few hundred topic/subscriptions.  We are currently vendor'ed at revision: 9150c396a4e2301b019900c8241a303518dfae11

BTW I opened this the same day we started seeing these hangs: https://github.com/GoogleCloudPlatform/google-cloud-go/issues/491
And we're seeing hangs in GCS readers/writers but so far only a handful.

Im guessing these issues are related to this: https://groups.google.com/forum/#!topic/cloud-pubsub-discuss/dGOXiL118Sw

Looks like the underlying pubsub problems will be fixed in a couple of days.
Couldn't you build a simpler workaround by wrapping the call to Next in a select with a timeout, then canceling the context and restarting the Pull? In either case, I do understand that you'll still have the problem of dropped acks.
I'm hesitant to introduce a context arg into Next because (a) this is (in the scheme of things) a transient issue, and (b) we'll be rolling out a new implementation that uses streaming, so is more performant, and may not have this failure mode. In fact, in the streaming case I'm pretty sure canceling a single Next's context won't be any different from canceling the entire iterator's context.
Sorry this is biting you.

@jba thank you!  At this point I'm only concerned with long-term solutions, so I can wait for the streaming implementation you mentioned.
possible workarounds (just in case anyone reading this needs some ideas):
They both have the issue of dropping buffered ack'ed messages and for subscriptions with low volume restarting when no messages arrives within the timeout.  But I can live with them for now, especially with the fixed back-end rolling out today.
	ctx, cancelIter := context.WithCancel(context.Background())
	t := time.AfterFunc(cancelIter(), time.Minute)
	iter, err := subscription.Pull(ctx)
	t.Stop()
	if iter == nil || err == context.Canceled {
		return ErrPullerCreationTimeout
	}
	defer cancelIter()
	// ...
	for {
		t := time.AfterFunc(cancelIter(), time.Minute)
		msg, err := iter.Next()
		t.Stop() // Next returned in a timely manner
		if err != nil {
			switch err {
			case context.Canceled:
				return ErrPullerNextTimeout
			case iterator.Done:
				break
			default:
				return err
			}
		}
		results <- msg
	}

	ctx, cancelIter := context.WithCancel(context.Background())
	t := time.AfterFunc(cancelIter(), time.Minute)
	iter, err := subscription.Pull(ctx)
	t.Stop()
	if iter == nil || err == context.Canceled {
		return ErrPullerCreationTimeout
	}
	defer cancelIter()
	msgs := make(chan *pubsub.Msg)
	errs := make(chan error)
	go func() {
		for {
			if msg, err := iter.Next(); err != nil {
				errs <- err
				return
			} else {
				msgs <- msg
			}
			select {
			case <-ctx.Done():
				return
			default:
			}
		}
	}()
	for {
		select {
		case <-ctx.Done():
			return nil
		case msg <- msgs:
			results <- msg
		case err <- errs:
			return err
		case <-time.After(time.Minute):
			return ErrNextTimeout
		}
	}

Im closing this issue since the latest version of the pub-sub client uses a different access pattern.


Make links automatically be formatted super pretty, as with "language>intro"

This issue is a part of TODO.

Not clear what you mean here...

I think the idea was that things like L<say> would automatically be displayed as routine>say, or something like that. IMO if no better explanation is given we can reject this, because most of the text actually expects the name to be displayed as-is without any category.

No clarification here, so I'm closing this.

I've clarified that a bit. Of course you did. Thanks.


Unable to drag to the last column (sunday) on low resolution devices + Scrolling not working with dragging event

Q1: If dividing the width of the screen in the ratio of like 20% to the left side menus and the remaining 80% to the calendar (.calendarContOuter), then the user can't drag the event to the last column (Sunday) for resolution 1368x768 (16:9), it works fine for 1920x1080 (16:9), Also If increase the browser zoom level to 125% or 150% user can't even drag to the second last column (Saturday) too.
Q2: Dragging not working as expected while scrolling up/down to the screen to move an event. Like if you have an event at 08:00 AM and want to drag it to 09:00 PM.
Any help will be appreciated.

Did you ever found a solution for Q1?

Hi,
It is because the values of the containment of ui.draggable are not correct. This is because if you center the agenda for example, the left margins are not calculated correctly.
This can be fixed by changing this:
iCalendarMarginLeft = $(to.elem).css("margin-left");
iCalendarMarginLeft = parseInt(iCalendarMarginLeft.replace("px", ""));

Into this:
iCalendarMarginLeft = $(to.elem).offset().left;
It occurs a few times in the code.


ansible_runner doesn't accept ansible's user password via ansible_password variable

When using testinfra with ansible_runner the only acceptable variable that can contain the password for ansible's user is ansible_ssh_pass. Based on ansible documentation if the user wants to use ansible with a password the ansible_password must be set.
The reason why only ansible_ssh_pass is accepted is that the password parameter is directly pulled from ansible_ssh_pass. See code here
I plan to create a PR to fix this if it is okay.

Hi @lmesz-bitrise thanks for adding this issue. It took me a long time to find the solution to this. I have always used the ansible_password: variable name for my ansible inventorys..
Some google phrases i used

testinfra promts for password
testinfra ask for password
testinfra ansible promts for password

as of 2024, issue still reproduced.
Ansible deprecates ansible_ssh_pass way long ago, maybe it's time to finally fix it?


Mapster.Async sometimes does not await all tasks

I have a more complex mapping defined which uses multiple calls to AfterMappingAsync. Sometimes, AdaptToTypeAsync() does correctly await the complemation of all code defined in the different AfterMappingAsync calls.
I confirmed with the debugger that not all expected tasks are present in the task list in AdaptToTypeAsync(). E.g., I made 4 calls to AfterMappingAsync() but only two tasks are registered in the task list.
Note, that I am also using the dependency injection plugin and I use it to access a DataManager (connection to database) which is provided by the dependency injection.

Could you provide working sample? All tasks seemed to be tracked. Make sure you await  all async methods in AfterMappingAsync.

Could you provide working sample? All tasks seemed to be tracked. Make sure you await  all async methods in AfterMappingAsync.

From inside the AfterMappingAsync(), I access MongoDB. Both Mapster and the MongoDB driver use of AsyncLocal. My guess is, that this causes some conflict.
I found this article https://nelsonparente.medium.com/a-little-riddle-with-asynclocal-1fd11322067f, which states that there might be issues if you try to update the data inside an AsyncLocal.
Unfortunately, I do not have time to create a working sample right now and it might be a bit tricky to get the timing right.

From inside the AfterMappingAsync(), I access MongoDB. Both Mapster and the MongoDB driver use of AsyncLocal. My guess is, that this causes some conflict.
I found this article https://nelsonparente.medium.com/a-little-riddle-with-asynclocal-1fd11322067f, which states that there might be issues if you try to update the data inside an AsyncLocal.
Unfortunately, I do not have time to create a working sample right now and it might be a bit tricky to get the timing right.

I was finally able to reproduce the issue reliably. The issue occurs when AdaptToTypeAsync() is used inside AfterMappingAsync(). I have created a pull request with a test which reproduces the issue: https://github.com/MapsterMapper/Mapster/pull/310.
It looks like the issue is located in the MapContextScope. As it does not allocate a new MapContext everytime, it can happen that the special parameter which holds the tasks is overwritten and some tasks which should be awaited are not properly registered. I have attempted a fix in https://github.com/MapsterMapper/Mapster/pull/311, but this breaks 4 other tests.

Thank you for your deep analysis. I can say this issue is the most complicated bug.


Server State - Null Ptr or "UNKNOWN_ATTRIBUTE"

I am trying to use the API to create a server, by cloning a template.
I believe I am doing the "right" thing, based on this documentation: https://www.upcloud.com/api/1.2.6/8-servers/#create-server
Essentially this is the code I have:
	    ServerApi serverAPI = new ServerApi(client);

	    Server server = new Server();
	    server.setZone("uk-lon1");
	    server.setTitle(fullServerName);
	    server.setHostname(fullServerName);
	    server.setCoreNumber(new BigDecimal(2));
	    server.setMemoryAmount(new BigDecimal(2048));

	    ServerStorageDevices devices = new ServerStorageDevices();
	    StorageDevice sd = new StorageDevice();
	    sd.setAction("clone");
	    sd.setStorage("014a041c-7eb3-48fb-9c7c-e09e70c8274f");
	    sd.setTitle(fullServerName);
	    sd.setSize(new BigDecimal(50));
	    sd.setTier("maxiops");
	    sd.setPartOfPlan(PartOfPlanEnum.YES);
	    devices.addStorageDeviceItem(sd);
	    server.setStorageDevices(devices);
	    server.setBootOrder(BootOrderEnum.DISK);
	    server.passwordDelivery(PasswordDeliveryEnum.NONE);

	    CreateServerRequest createServerRequest = new CreateServerRequest();
	    createServerRequest.setServer(server);

	    return serverAPI.createServer(createServerRequest);

However, there is an issue when actually sending the request to the RESTful API. If I do not include a ServerState value on the Server object, I get a Null Pointer Exception:

2018-03-07 15:35:33,292 ERROR [http-nio-8086-exec-6] () Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.NullPointerException] with root cause
java.lang.NullPointerException
at com.upcloud.client.models.ServerState$Adapter.write(ServerState.java:63)
at com.upcloud.client.models.ServerState$Adapter.write(ServerState.java:60)
at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.write(TypeAdapterRuntimeTypeWrapper.java:68)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.write(ReflectiveTypeAdapterFactory.java:99)
...

If I include a ServerState on the Server object, I get an "UNKNOWN_ATTRIBUTE" response from the server:

2018-03-07 15:06:12,453  INFO [http-nio-8086-exec-5] () Request Content-type: application/json
Bad Request
{
"error" : {
"error_code" : "UNKNOWN_ATTRIBUTE",
"error_message" : "The request body contains an unknown attribute state."
}
}

As a side note, I have fixed the issue locally with the following pattern:
Replacing this code where you have Enums:
public void write(final JsonWriter jsonWriter, final ServerState enumeration) throws IOException {
        jsonWriter.value(enumeration.getValue());
}

With the following:
public void write(final JsonWriter jsonWriter, final ServerState enumeration) throws IOException {
  if (enumeration != null) {
        jsonWriter.value(enumeration.getValue());
  } else {
        jsonWriter.nullValue();
  }
}

This change worked for me, allowing me to optionally provide Server State (and some other Enums that were affected). So, I can submit a pull request with these changes - if you would like?

@michaelfclarke thanks for reporting this in! And please do submit a PR if you have fixed this issue :)

Finally got around to sending in a pull request - only a year later!


Unable to upload ISO nor templates from local

ISSUE TYPE

Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

N/A
OS / ENVIRONMENT

CentOS 7
SUMMARY

When you try to upload a ISO or a template using Cloudstack UI function "Upload from local" you receive error: Upload Failed
Failed to upload ISO. - Error: Request failed with status code 502
STEPS TO REPRODUCE

Open the page Images/ISO and upload an ISO from local.
EXPECTED RESULTS

The ISO is uploaded

ACTUAL RESULTS

We receive error 502.

From the logs we can see the following:
2023-02-09 20:16:32,104 WARN  [c.c.a.AlertManagerImpl] (Upload-Monitor-1:ctx-a90ee4fd) (logid:e8671b09) alertType=[28] dataCenterId=[2] podId=[null] clusterId=[null] message=[Template 29d91b99-6d23-4c77-b4a8-f06238109302 failed to upload. Error details: file receive failed or connection closed prematurely.].

Looks like it doesn't read correctly the podId and clusterId parameters.

@cdfgallo do you see more errors before this or do you see any errors in the log on the ssvm?

@cdfgallo can you try rebuilding the SSVM and upload again?
are you able to download a snapshot?
are you using a proxy, cause this is bad gateway error, also from your report I don't see how did you came to the conclusion it cannot reaad podId or clusterId?

@DaanHoogland I attach here the "complete" log of the operation from the SSVM, unfortunatelly no, no other errors.
ssvm-log.txt

@borisstoyanov
I'm not using any proxy.
I'm able to download any template from the ssvm (not sure how I can download a snapshot).
The error refer to "java.lang.NumberFormatException: null" while it's expecting an integer value but receiving the value "null", that's why I'm pointing at that.

@cdfgallo when you create a snapshot of a volume you have the option to download it, it's the same process as uploading but in the other direction, can you try that.
Also can you destroy your SSVM and wait until the new one is up and try again to upload. Maybe also share an image of the upload form in the UI before clicking upload.

The NPE is in this line:
        long defaultMaxSecondaryStorageInGB = cmd.getDefaultMaxSecondaryStorageInGB();

so it has nothing to do with the Pod or cluster. It is an implicit conversion failing. What is your value for "max.account.secondary.storage"? This is the setting propagated to that command.

@borisstoyanov I tried to rebuild the ssvm but I receive the same error. Also it's a bit strange that the agent is still the same as <IP_ADDRESS> when the template is of version 4.17.2

Here the screen you requested

@DaanHoogland the value of max.account.secondary.storage is 5000

@borisstoyanov I can't find the option to download the snapshot. I can revert it to a template and download it, I can revert to a volume, revert vm to snapshot or delete it.

@borisstoyanov I tried to rebuild the ssvm but I receive the same error. Also it's a bit strange that the agent is still the same as <IP_ADDRESS> when the template is of version 4.17.2

do you mean the agent on the host or in the ssvm?

or

@DaanHoogland the value of max.account.secondary.storage is 5000

Ok, that value should have been propagated. the value default value is 400 but in itself is this value is no issue.

please check what template you have and destroy the ssvm to be recreated
the version you show is indeed not good

After updating the agent correctly on the ssvm I got no more issues. Strangely the agent wasn't updating at first.
Thank you @DaanHoogland @borisstoyanov for your support!


SimpleStorageResource not resolved in spring-boot 2.1.x

In the documentation this snippet can be found:
public class SimpleResourceLoadingBean {

    @Autowired
    private ResourceLoader resourceLoader;

    public void writeResource() throws IOException {
        Resource resource = this.resourceLoader.getResource("s3://myBucket/rootFile.log");
        WritableResource writableResource = (WritableResource) resource;
        try (OutputStream outputStream = writableResource.getOutputStream()) {
            outputStream.write("test".getBytes());
        }
    }
}

This works in Finchley.RC2 as expected. But when I run the same code with only spring cloud updated to Finchley.RELEASE, I get the following class cast exception: org.springframework.web.context.support.ServletContextResource cannot be cast to org.springframework.core.io.WritableResource
In my debugger I see that the Resource should be an instance of a SimpleStorageResource, instead it is an instance of a ServletContextResource.
That is caused by the resourceLoader which shoud be a org.springframework.cloud.aws.core.io.s3.PathMatchingSimpleStorageResourcePatternResolver, instead it is an instance of a AnnotationConfigServletWebServerApplicationContext.
I use spring-boot 2.0.3

Thanks  @JurrianFahner for reporting. This is unfortunately a regression as we have utilized some new Spring features for loading resources (to solve some other bugs). It seems that this does not work with the Web Application context. I will add test cases with a web application context and see how to solve it.
In the meantime you could inject a org.springframework.cloud.aws.core.io.s3.SimpleStorageProtocolResolver and use that directly (pass in the location and the application context to the resolve method)

Well that's not so easy. Because SimpleStorageProtocolResolver needs an S3 client with credentials.
So I use RC2, until this is fixed. My project is in dev phase, so I have some time. I imagine that it will be fixed soon.

This makes the S3 resource loader indeed unusable. RC2 does work though.
Is there a plan to fix this with 2.0.x ?

Is this related to #384 ?

Is this related to #384 ?

Nope, because I didn't use devtools. So removing devtools wouldn't fix the issue.

I have used this inline workaround for now
Resource resource = resourceLoader.getResource(location);

// workaround for https://github.com/spring-cloud/spring-cloud-aws/issues/348
// TODO: wait the bug to be solved and remove the "if" below
if (!resource.getClass().getName().endsWith("SimpleStorageResource") && resourceLoader instanceof DefaultResourceLoader) {
  for (ProtocolResolver protocolResolver : ((DefaultResourceLoader) resourceLoader)
      .getProtocolResolvers()) {
    if (protocolResolver instanceof SimpleStorageProtocolResolver) {
      resource = protocolResolver.resolve(location, resourceLoader);
      break;
    }
  }
}

@denis111 It's a nice workaround, but it's fixing the outcome, but not the root of the problem. @aemruli already mentioned that the root of the problem is due to the regression in spring cloud aws. So it should be fixed in 2.x.x branches...

@denis111 Thanks! I just started using Spring Cloud AWS and this was very helpful to me.
In my project, the same workaround looks like this (in Kotlin):
    /**
     * Override the [DefaultResourceLoader] to force resolving resources that start with `s3://` using [SimpleStorageProtocolResolver].
     *
     * Workaround for https://github.com/spring-cloud/spring-cloud-aws/issues/348.
     */
    @Bean
    @Primary
    fun resourceLoader(defaultResourceLoader: DefaultResourceLoader): ResourceLoader =
        object : ResourceLoader {
            override fun getClassLoader(): ClassLoader? =
                defaultResourceLoader.classLoader

            override fun getResource(location: String): Resource {
                return if (location.startsWith(S3_PROTOCOL_PREFIX))
                    defaultResourceLoader.protocolResolvers.findFirstInstance<SimpleStorageProtocolResolver>()!!.resolve(location, this)!!
                else
                    defaultResourceLoader.getResource(location)
            }
        }

However, while this works for a ResourceLoader, I also have this problem in a ResourceResolver,
when using a s3:// path as static resource location (ResourceHandlerRegistry.addResourceLocations). In that case I also get a ServletContextResource instead of a SimpleStorageResource as location parameter in my PathResourceResolver.
My workaround looks like this
/**
 * A [PathResourceResolver] that is able to resolve resources from S3.
 */
open class S3ResourceResolver(
    val resourceLoader: ResourceLoader
) : PathResourceResolver() {

    private val log = KotlinLogging.logger {}

    override fun getResource(resourcePath: String, location: Resource): Resource? =
        // Workaround for https://github.com/spring-cloud/spring-cloud-aws/issues/348
        if (location is ServletContextResource && location.path.startsWith("/$S3_PROTOCOL_PREFIX")) {
            val s3location = location.path.substringAfter("/")

            log.debug { "Resolving resource $resourcePath under $s3location" }
            val resource = resourceLoader.getResource(s3location.appendPath(resourcePath))
            if (resource.exists())
                resource
            else
                null
        }
        else {
            log.debug { "Resolving resource $resourcePath under $location" }
            super.getResource(resourcePath, location)
        }
}

but I believe this is caused by the same bug, and should be fixed as well.

Hi, I've also encountered this issue, but the workaround suggested by @denis111 does not work (same error), and doesn't really address the issue. Any other approaches that have worked, or any news on when this may be fixed?

I can confirm that in Greenwich.RELEASE the problem is fixed, and SimpleStorageResource is working.
But that's only true for spring-boot 2.1.x

Hello,
seeing the same issue - unfortunately quite a lot of spring dependencies/not sure when what got updated (but no devtools) - Anyway: I tried to update to a newer version:
... <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.1.3.RELEASE</version>
    </parent>
...
+
...
 <spring-cloud.version>Greenwich.SR1</spring-cloud.version>
...

Since this was reopened - can we assume that Greenwich.SR1 is not/not completely resolving this issue?
@denis111 the workaround works, very much appreciated, thanks!
Regards,
Andy

Works fine for me with Spring Boot 2.1.x...

I am experiencing the same issue of the s3 protocol not resolving and getting a FileNotFoundEzveprionSpring Boot starter 2.1.3-RELEASE and Spring Cloud Greenwich.RELEASE.
Will try workaround by @denis111 and post back if it works.

Update: Upgraded to Greenwich.SR1 and added spring-cloud-aws-autoconfigure, instead of spring-cloud-aws-context.
Despite the s3: protocol, my resource is a ServletContextResource and no protocol resolvers are found in DefaultResourceLoader.
When I try to wire in SimpleStorageProtocolResolver, I get the following:
_

No qualifying bean of type 'org.springframework.cloud.aws.core.io.s3.SimpleStorageProtocolResolver' available
_

AWS Context XML:
<aws-context:context-resource-loader/>
POM excerpt:
<parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.1.3.RELEASE</version>
        <relativePath/>
    </parent>

<dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-config-server</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-actuator</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-security</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-sleuth</artifactId>
        </dependency>

         <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-aws-autoconfigure</artifactId>
        </dependency>

<dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.springframework.cloud</groupId>
                <artifactId>spring-cloud-dependencies</artifactId>
                <version>Greenwich.SR1</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>

Any help would be greatly appreciated.

I also have this issue with Spring Boot 2.1.5 and Greenwich.
@amgapuz do you have a more detailed example on how to configure the SimpleStorageProtocolResolver? I'm not sure how to do it without XML.

I have upgraded to Spring Boot 2.1.5 and Spring Cloud Context 2.1.1 and I found that this is working now if I remove Spring Boot Devtools from the classpath.
This might explain why it's working for @JurrianFahner now, but not for others. It seems like something has been fixed, but this issue is also caused by #384.  This problem has also been reported with Spring Boot, but has not been resolved yet: https://github.com/spring-projects/spring-boot/issues/9331.
When autowiring ResourceLoader (or ApplicationContext), and calling resourceLoader.getResource(location), having Spring Boot Devtools on the classpath, the location is incorrectly resolved as a ServletContextResource with path starting with /s3://. Without Devtools it is correctly resolved to a SimpleStorageResource.
The GenericApplicationContext.getResource method calls it's own ResourceLoader instead of super.getResource. Without Devtools there is no resourceLoader set in GenericApplicationContext, so super.getResource gets called and it works correctly.
When I try to add a S3 resource location in WebMvcConfigurer.addResourceHandlers with ResourceHandlerRegistry.addResourceLocations, the same happens:
ResourceHttpRequestHandler.resolveResourceLocations calls applicationContext.getResource(location) for each location, but with Devtools on the classpath, the GenericApplicationContext.getResource method calls it's own ResourceLoader instead of super.getResource.

@darioseidl We should maybe list projects which aren't working with specific combinations.
But for me it's working with spring-boot 2.1.4 and greenwich.SR1. I don't have devtools on my classpath, so that's no problem for me.

@gysel
I have to manually create a SimpleStorageProtocolResolver by auto-wiring in AmazonS3 to my bean and passing it in to the constructor:
@Autowired
private AmazonS3 amazonS3;

// Spring Core IO ResourceLoader - AWS context XML sets this correctly
// If you are looking to set and configure the AWS context in code, I have no example for that
@Autowired
private ResourceLoader resourceLoader;

public void myMethodToFetchFromS3() {
SimpleStorageProtocolResolver simpleStorageProtocolResolver = new SimpleStorageProtocolResolver(amazonS3);

Resource aResource = resourceLoader.getResource("s3://bucket/path/to/resource");

// The workaround
if (!aResource.getClass().getName().endsWith("SimpleStorageResource") &&
         resourceLoader instanceof DefaultResourceLoader) {
  aResource = simpleStorageProtocolResolver.resolve("s3://bucket/path/to/resource", resourceLoader);
  }
}

Hope that helps.

I get the following error if Devtools is active
java.nio.file.InvalidPathException: Illegal char <:> at index 18: src\main\webapp\s3:\swooop\rootFile.log

	at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)
	at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)
	at java.io.File.toPath(File.java:2234)
	at org.springframework.core.io.FileSystemResource.<init>(FileSystemResource.java:82)
	at org.springframework.core.io.FileSystemResourceLoader$FileSystemContextResource.<init>(FileSystemResourceLoader.java:65)
	at org.springframework.core.io.FileSystemResourceLoader.getResourceByPath(FileSystemResourceLoader.java:54)
	at org.springframework.core.io.DefaultResourceLoader.getResource(DefaultResourceLoader.java:168)
	at org.springframework.mock.web.MockServletContext.getResourceAsStream(MockServletContext.java:345)
	at org.springframework.web.context.support.ServletContextResource.getInputStream(ServletContextResource.java:156)
	at com.housescent.sweeep.SweeepCoreApplicationTests.resourceLoadingMethod(SweeepCoreApplicationTests.java:30)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.springframework.test.context.junit4.statements.RunBeforeTestExecutionCallbacks.evaluate(RunBeforeTestExecutionCallbacks.java:74)
	at org.springframework.test.context.junit4.statements.RunAfterTestExecutionCallbacks.evaluate(RunAfterTestExecutionCallbacks.java:84)
	at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:251)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
	at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

@RunWith(SpringRunner.class)
@SpringBootTest
public class SweeepCoreApplicationTests {

    @Autowired
    private ResourceLoader resourceLoader;

    @Test
    public void contextLoads() {
    }

    @Test
    public void resourceLoadingMethod() throws IOException {
        Resource resource = this.resourceLoader.getResource("s3://swooop/rootFile.log");
        Resource secondResource = this.resourceLoader.getResource("s3://myBucket/rootFolder/subFile");

        InputStream inputStream = resource.getInputStream();
        //read file
    }

}

The problem just returned to me with Spring Boot 2.2.1 (maybe 2.2.0 also). But my previous workaround didn't work so I used workaround by @annagapuz but instantiating SimpleStorageProtocolResolver only once in the constructor of my bean.

The problem just returned to me with Spring Boot 2.2.1 (maybe 2.2.0 also). But my previous workaround didn't work so I used workaround by @annagapuz but instantiating SimpleStorageProtocolResolver only once in the constructor of my bean.

Good to know - about to upgrade to spring boot 2.2.x

@denis111 and @annagapuz It is nice that you both are testing spring cloud aws on spring-boot 2.2.x. But were you also aware that spring-cloud is not yet ready for spring boot 2.2.x (when you reported the bugs)?  I can't figure it out from your feedback, whether which spring-cloud version you used.
Spring cloud uses a release train, as you can learn from: https://spring.io/projects/spring-cloud

Release Train
Boot Version

Hoxton
2.2.x

Greenwich
2.1.x

Finchley
2.0.x

Edgware
1.5.x

Dalston
1.5.x

So in order to get spring-boot 2.2.x working with spring cloud, you'll need Hoxton.RELEASE. Can you please let us know whether the problem persists when you upgrade to Hoxton.RELEASE?

This seems to be fixed with Spring Boot 2.2.1 and Spring Cloud AWS 2.2.0 for me. The bug, where the SimpleStorageProtocolResolver would not be resolved when DevTools was on the classpath, has been fixed in Spring Boot and Spring Framework: https://github.com/spring-projects/spring-boot/issues/17214
I have a simple test here: https://github.com/darioseidl/s3demo. With and without Spring Boot Devtools on the classpath, the SimpleStorageResource is resolved correctly now.

@JurrianFahner yes, I was on Greenwich and can confirm that with Hoxton I don't need the workaround.

No, It just happend to me again running with Gradle's bootRun java.io.FileNotFoundException: Could not open ServletContext resource [/s3://...
But worken one time running from IDE.

@JurrianFahner I saw the error with Boot 2.1.3-RELEASE and Cloud Greenwich.RELEASE. I have not tested with 2.2.X + Hoxton. Will be doing an upgrade soon though.

Ran into the issue with Boot 2.2.2.RELEASE + Cloud Hoxton.SR1
Workaround by @annagapuz helped

I am not able to reproduce this bug with Spring Boot 2.3 and Spring Cloud AWS 2.2.2.
If you are still facing this issue please comment ideally with a link to github repo that reproduces the bug.

@maciejwalkowiak here is a repo with the latest versions, where s3 integration from the guide doesn't work. Unless custom resource loader is defined.
https://github.com/PP-etc/spring-boot-with-s3-example/blob/master/src/main/java/com/pavelpolyakov/s3example/S3ExampleApplication.java#L33
When it's not available, I have this exception:
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 's3ExampleApplication': Invocation of init method failed; nested exception is java.lang.ClassCastException: class org.springframework.web.context.support.ServletContextResource cannot be cast to class org.springframework.core.io.WritableResource (org.springframework.web.context.support.ServletContextResource and org.springframework.core.io.WritableResource are in unnamed module of loader 'app')

Thanks @PavelPolyakov! We will look into it.


Bug with latest version?

Since updating to the latest release I'm not able to import the module into my webpack project.
Example code:
import { tns } from "tiny-slider/src/tiny-slider.module"
Output:
application.js:15239 Uncaught ReferenceError: prop is not defined
    at whichProperty (application.js:15239)
    at Object.keys.keys (application.js:12477)
    at __webpack_require__ (application.js:677)
    at fn (application.js:88)
    at Object.<anonymous> (application.js:12176)
    at __webpack_require__ (application.js:677)
    at fn (application.js:88)
    at Object.window.KBA (application.js:10295)
    at __webpack_require__ (application.js:677)
    at fn (application.js:88)

Trace:
/***/ }),
/* 137 */
/***/ (function(module, __webpack_exports__, __webpack_require__) {

"use strict";
/* harmony export (immutable) */ __webpack_exports__["a"] = whichProperty;
function whichProperty(props) {
  var el = document.createElement('fakeelement'),
      len = props.length;
  for (var i = 0; i < props.length; i++) {
    prop = props[i];
    if (el.style[prop] !== undefined) {
      return prop;
    }
  }

  return false; // explicit for ie9-
}

+1

This should be fixed in v2.1.2
Would you be able to check it?

Works! Great and fast job thank you :)


Budget not adding up

https://opencollective.com/study-into-action/projects/artcoop
It shows $6000 coming in, $174.30 payment processor fee, $300 disbursed,$5,525.70 balance and $5,825.70 total raised.

Total raised should be $6000
There have been zero expenses and no other transactions. Where is the $300 disbursed coming from?
What happened to host fees?

This is related to the recent ledger refactor.

Payment processor (stripe) fee was $174.30, this number is correct
Host fee is $300 (5% x $6000). This should be displayed in the transaction details, I need to investigate why it's not in this case
The Total disbursed: $300 metric is wrong: we should not count fees as disbursed money
The balance is right: $3000 - $174.30 - $300 = $5525.70

I've fixed the total disbursed metrics.
The host fee is still not displayed in the transaction details, and that's because it is now a separate transaction. The proper way to look at it is by using the kind filter on the transactions page, I just recorded a demo to explain how to do that: https://www.loom.com/share/d3c3f6c28d354c948b52ca9b6d75d475. I started https://github.com/opencollective/opencollective/issues/4438 to discuss transaction details further.


wxformbuilder: unstable-2020-08-18 -> unstable-2022-09-26

Description of changes
Also added myself as a maintainer.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build wxFormBuilder

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1315


chore: Updated typeorm

The build is failing because of this commit: https://github.com/typeorm/typeorm/commit/12e9db07b6b9676e63fff5f55a45b1d269716ed9#diff-815ba40c56c4edb31c2cd63e2a75d0bf046d93831b4c2e7ea8f3c861d0cbb593

I tried the update locally and noticed stuff no longer working, will fix the issues soon so it can be released. Just thinking on how to release it as I'm not sure the changes will be backwards compatible with older TypeORM versions.

Replaced by #129


[Bug]: Error obtaining cookies with -sc and --browser brave on Windows 10

What happened?
I have been trying to download a course using my Udemy personal subscription. I used the commands -sc and --browser brave to get the cookies from my Brave browser, but when attempting to retrieve the cookies, I encounter a privilege error. It doesn't work even when I open a terminal with administrator rights.

Expected Result
Cookies should be successfully retrieved without any errors.
Branch
master/main
What operating systems are you seeing the problem on?
Windows
Relevant log output
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\Jorge\\AppData\\Roaming\\..\\Local\\BraveSoftware\\Brave-Browser\\User Data\\Default\\Network\\Cookies'

Other information
No response

close brave lol

close brave lol

I solved this error with the --browser file and putting my cookies into the file cookies.txt

I mean... all you need to do is close brave... but sure


Unicode Support

So I think unicode support will work with dNSName because dNSName is effectively limited to ascii and will always have punicode names in ssl:connect(Host) because erlang doesn't have support for unicode name resolution. However, some CAs will put unicode in the common name field. So you need a way of converting unicode->punycode to do the correct matching for common name certs. More details here: https://bugzilla.mozilla.org/show_bug.cgi?id=280839

Can you give me an example where CN has unicode encoded hostname [it has to be added to test certs anyway]? I have a feeling that today most certificates generated with proper altName and maybe it copied to CN for backward compatibility. Also we are looking at CN only if altNames are not present. So it has to be very interesting case: certificate without altName but with hostname presented in CN and unicode encoded, right?

yeah i think you are right and this is not a problem. i don't think firefox handles this so i don't see the point of handling it erlang.


Please fix the cron ci job

Thanks for creating this awesome project.
Could you please fix the travis ci?
Thanks

Hello, @sinchang thanks for the comment. I will be updating the project this weekend and also setting up the auto-update and deployment pipeline


remove global.context

wait, there may be some tests you might wanna remove too.

@cpojer i ran the suite before git commit. all passed!


Add a way in the API to fill the context and pass that to placeholder resolver

Closing this as the current placeholder resolver system essentially provides this functionality. I've provided an example below.
public class MyContextualPlaceholderResolver implements PlaceholderResolver {
  public MyContextualPlaceholderResolver(Context context) {
    // impl
  }
}

// later on...
MiniMessage.miniMessage().serialize(someString, new MyContextualPlaceholderResolver(player));


GEODE-9704: Ensure that register interest is called before ready for events

In QueueManagerImpl, it was possible to have a ReadyForEventsOp go out before RegisterInterestOps which would lead to events being missed.
This changes forces the order always be correct and has a test to verify it.

DurableRegistrationDUnit has a few extra changes to swap the ready for events to be after the registration


implement spyOnProperty method

Summary
In order to be able to spy on getters/setters we need to backport spyOnProperty method from Jasmine.

~implement spyOnProperty method~
implement tests

Test plan

WIP (help wanted)

Any reason why we cannot make spyOn work on getters?

@SimenB i was thinking about it too. in the end i just followed the original jasmine PR to be more compliant with the origin library.

Making spyOn work itself would be awesome.

i've reverted the commit for editor.formatOnSave and fixed the indentation.

yesterday evening i tried to fix every errors in the tests.. one snapshots is still failing.
Summary of all failing tests
 FAIL  integration_tests/__tests__/jest.config.js.test.js (10.23s)
  ● traverses directory tree up until it finds jest.config

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot 2.

    - Snapshot
    + Received

    - "PASS ../../../__tests__/a-banana.js
    + "PASS ../../../__tests__/a-banana.js (6.798s)
        ✓ banana
        ✓ abc

      "

      60 |   const {rest, summary} = extractSummary(stderr);
      61 |   expect(status).toBe(0);
    > 62 |   expect(rest).toMatchSnapshot();
      63 |   expect(summary).toMatchSnapshot();
      64 | });
      65 |

      at Object.<anonymous>.test (integration_tests/__tests__/jest.config.js.test.js:62:16)

what's the next steps for this feature? at the moment i had to disable the unit tests in a firebase project due to the fact that i can't spy on getters with jest but i would like to restore the tests in these days..

what's the next steps for this feature?

We need tests showing that the new function works

ok, i will rebase this branch when #5132 is merged. in the meanwhile i will try to implement some tests for this feature.

Codecov Report

Merging #5107 into master will decrease coverage by 0.47%.
The diff coverage is 1.75%.

@@            Coverage Diff             @@
##           master    #5107      +/-   ##
==========================================
- Coverage    60.7%   60.23%   -0.48%
==========================================
  Files         201      201
  Lines        6691     6747      +56
  Branches        4        4
==========================================
+ Hits         4062     4064       +2
- Misses       2628     2682      +54
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-jasmine2/src/index.js
5.63% <0%> (ø)
:arrow_up:

packages/jest-runtime/src/index.js
73.72% <0%> (+0.09%)
:arrow_up:

...ackages/jest-jasmine2/src/jasmine/jasmine_light.js
0% <0%> (ø)
:arrow_up:

packages/jest-jasmine2/src/jasmine/spy_registry.js
0% <0%> (ø)
:arrow_up:

packages/jest-jasmine2/src/jasmine/Env.js
0% <0%> (ø)
:arrow_up:

packages/jest-mock/src/index.js
78.66% <4.34%> (-6.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74fbff...65d884d. Read the comment docs.

@SimenB i've implemented the tests and CI is green.. can you please review the code changes? thanks.

Why can't we use jest.spyOn? I don't understand why a new method is needed

in the end i just followed the original jasmine PR to be more compliant with the original library.

@SimenB as i said above, to maintain consistency with jasmine apis.

Parity with Jasmine's APIs is non-goal (we want to drop jasmine entirely, #4362).


[ADD] Comma seperators for large numbers on send and verify screens

To have a better visibility for large numbers and amounts please add comma seperators for every 1000 .
Add this on send screen , verify screen and done screen

@yvebe can we close the issue? as also #1317 will improve it


Document events map

Added missing documentation for the events map as requested in https://github.com/cklmercer/vue-events/issues/16

Thanks a ton!

No worries, I was actually even considering adding this functionality myself when I noticed it already existed and it just wasnt documented!


preserve query params when navigating

preserve query params when navigating

When doing something like toggling the theme or channel, preserve any sample or id query param.

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Oops, I already implemented this in https://github.com/dart-lang/dart-pad/pull/2659. Would you mind taking a look at that version instead @devoncarew?

Oops, I already implemented this in #2659. Would you mind taking a look at that version instead @devoncarew?

No worries; lets land your PR and I can double check that its a superset of this one in terms of functionality.

closing in favor of https://github.com/dart-lang/dart-pad/pull/2707


Aditi dev

Added test_application.py and unit_test.py

Maybe it's the problem with file structuring.


[FR] Allow trigger functions to receive additional arguments

Currently, the only two arguments that a trigger can receive are context and redirect but I find myself needing to reuse some trigger functions that are very similar, except for small changes, which would be very easy to apply if it were possible to pass in additional arguments to the function.

I think you can use currying or JS bind function for this purpose.
Currying
function buildTrigger(prefix) {
  return function (context, redirect) {
    var path = prefix + context.path;
    redirect(redirect);
  };
}

FlowRouter.route("/old-route", {
  triggersEnter: [buildTrigger("/new/url")]
});

FlowRouter.route("/very-old-route", {
  triggersEnter: [buildTrigger("http://myapp.io")]
});

####.bind
function redirectTrigger(prefix, context, redirect) {
  var path = prefix + context.path;
  redirect(redirect);
}

FlowRouter.route("/old-route", {
  triggersEnter: [redirectTrigger.bind(null, '/new/url')]
});

FlowRouter.route("/very-old-route", {
  triggersEnter: [redirectTrigger.bind(null, 'http://myapp.io')]
});

Hm, I keep forgetting that this is indeed javascript. Or perhaps I need a little rest :)
Thanks!

:)


Add test for get_qstat_info to also test tenacity

Local tests suggest this is fixed in versions>=8.0, so added a test to check for this
Closes #301

Coverage remained the same at 42.326% when pulling bb1c1aeae6b33d2b7a07feb2918acbc0f61eb627 on issue-301 into 63a5571dd1cb3b5de250db40ceb8c90a3a7657a3 on master.


install Kestrel without stix-shifter data source interface or docker interface

5 sub-packages will be install now when pip install kestrel-lang. Could we only install the main sub-package?
This may be achieved by using package options. Need to check possible ways to use it.
Related specific request: https://github.com/opencybersecurityalliance/kestrel-lang/issues/118

dup as #118


[BUG] Not able to pull csi registrar docker image

What is your environment(Kubernetes version, Fluid version, etc.)
Kubernetes version: 1.20.x
Describe the bug
Not able to pull docker image registry.aliyuncs.com/acs/csi-node-driver-registrar:v2.3.0-038aeb6-aliyun
What you expect to happen:
Should be able to pull registrar docker image
How to reproduce it
dokcer pull registry.aliyuncs.com/acs/csi-node-driver-registrar:v2.3.0-038aeb6-aliyun
Additional Information
Error,
Error response from daemon: Get https://registry.aliyuncs.com/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

@Sharathmk99
Pls try with this image k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0.
Found in https://github.com/kubernetes-csi/node-driver-registrar

@Sharathmk99 you can use fluidcloudnative/csi-node-driver-registrar:v2.3.0 now.


Update all references in Cargo.lock for patched crates

Works around https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544
Comparing https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544, which failed to compile polkadot-node-subsystem-test-helpers with errors such as
error[E0053]: method `authority_set_proof` has an incompatible type for trait
    --> /builds/parity/mirrors/substrate/extra_dependencies/polkadot/runtime/rococo/src/lib.rs:1882:31
     |
1882 |         fn authority_set_proof() -> beefy_primitives::mmr::BeefyAuthoritySet<Hash> {
     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |                                     |
     |                                     expected struct `sp_beefy::mmr::BeefyAuthoritySet`, found struct `BeefyAuthoritySet`
     |                                     help: change the output type to match the trait: `sp_beefy::mmr::BeefyAuthoritySet<H256>`
     |
     = note: expected fn pointer `fn() -> sp_beefy::mmr::BeefyAuthoritySet<H256>`
                found fn pointer `fn() -> BeefyAuthoritySet<H256>`

with https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2116743#L1811, which got past that point, I think that the fix is effective.
ref https://github.com/paritytech/substrate/pull/12837#issuecomment-1336975421

I think this bug fix might have uncovered more issues in the integration check. Let me move it to Draft in the meantime.


Minor updates

Taking note on some of the issues reported to create a small PR:

There are 2 files with the incorrect API version (searchResults and productDetails LWCs)
There is an extra entry on the package.xml of the sharing setting example for a missing object (Product Media)

I think the changes are safe to merge and will better help with custom deployments,  but happy to make any changes needed. Thanks!

Just signed the CLA. Will close this one and create a new PR.


SelectableTextBlock does not update theme correctly if it contains a LineBreak

Describe the bug
If you have a SelectableTextBlock with a LineBreak in it, changing the application theme using Application.Current.RequestedThemeVariant does not update the text block theme. It only updates when the block is clicked on.
To Reproduce
Create a window containing this XAML:
<SelectableTextBlock>
    Foo bar<LineBreak/>
    baz
</SelectableTextBlock>

Add a method of changing the theme at runtime, build and run and change the theme.
Expected behavior
The theme updates immediately when changed.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Version 11.0.2

Additional context
A minimal reproduction can be found here: https://github.com/SamVanheer/AvaloniaSelectableTextBlockBug

I tested this again and it looks like what's actually happening is the text color is using the opposite color of what it should be. When switching to light theme the text color is white, when switching to dark theme the text color is black. So this might just be a case of the wrong color being used to update the text color?
I don't see any XAML definition for TextBlock and SelectableTextBlock doesn't specify a color for the foreground color so maybe it's inheriting the background color here?
Assuming i understand themes correctly:
TextBox defines the foreground color in this file: https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Themes.Fluent/Controls/TextBox.xaml
And SelectableTextBlock doesn't define that color here: https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Themes.Fluent/Controls/SelectableTextBlock.xaml
There is no TextBlock version.
Would adding a definition in the relevant XAML file fix this?

@SamVanheer you can give it a try by cloning the source and add a test case into src/samples/Sandbox. Then add the xaml as suggested and test if that fixes the issue. If yes, a PR is welcome imo.


clone loses constructor methods

I recently started using Ramda and overall I have been very happy, I have s simple Maybe monad that I use and when I clone the monad with R.clone is loses the instance methods of the monad while keeping the static. So as not to find out it is me with the problem. I tried underscore-contribs _.snapshot and the instance methods were back and working where they should be. Is this a known behavior? Is it scheduled to be changed or fixed? Thanks

Yes, this is a known, and expected, behavior of Ramda.
Ramda does not try very hard to work well with OO code.  Working with constructors and the prototype chain has never been a strong motivation for us.  Moreover, there is, as far as I know, no bulletproof way to clone a constructed object.  Perhaps _.snapshot has some tricks that Ramda doesn't try, but I'm betting that there are still fairly normal JS objects that it cannot clone well either.
For a Maybe, however, you should have a straightforward option.  Simply myMaybe.map(clone) should return a cloned version of myMaybe.
OTOH, why in the world do you want a clone of a Maybe?  A well-behaved Maybe is likely to be immutable, so what can you do with a clone that you can't do with the original?

Hi and thanks, the maybe is incidental and merely part of the flow, it is the data that I am cloning. I could have extracted the data and then cloned but was avoiding a couple of statements to wrap and unwrap. I do appreciate the quick reply, I'll just package snapshot and use that. I really like I said have enjoyed the library and it fits with my approach better than the underscore or lodash libraries. Thanks for Ramda and Cheers!

Ok, glad to hear you have something that should work.  But again, unless it's the content of the Maybe that has the missing methods, .map(clone) should do what you need.
Best of luck!

Thanks, and yes I'm fine. It is good to know the limitations of the clone in any event. Precisely what the structure is, is, a Maybe -> array -> (maybe)s -> data. I leave the Maybe's on to use the check methods as to the state of the data, this being a big part of what makes maybe's useful. Basically what was happening is the methods of the inner maybe that wrap around the individual data pieces not the main maybe that wraps the array, were losing the check methods (isJust, etc), but the basic structure was still intact. THis stopped me from checking the data state. it was actually popping on the use of the getOrElse method, even though in debug is still showed as a maybe and the data was there. The code for snapshot is not that involved but still seems to capture the methods. As seen here.
function snapshot( obj ) {
if ( obj == null || typeof(obj) != 'object' ) {
return obj;
}
var temp = new obj.constructor();
for ( var key in obj ) {
if ( obj.hasOwnProperty( key ) ) {
temp[ key ] = deepClone( obj[ key ] );
}
}
return temp;
}
Thanks again for the quick replies I'm good just added a copy of this to a library file.


[error]A positional parameter cannot be found that accepts argument

If a project contains space, createBlueprint.ps1 fails with subj error.
The possible reason: lack of single quotes ' for $BlueprintName parameter to handle spaces in paths:
Invoke-Expression "Import-AzBlueprintWithArtifact -Name $BlueprintName -InputPath $BlueprintPath $BlueprintScope -Force"

@Jagstangushka thanks for entering this issue. I am looking into it now.

Fix is in version 1.5.5.
https://github.com/neilpeterson/azure-blueprints-pipeline-tasks/pull/47
Thanks again for raising the issue.


File/Folder Reorg Changes

File/Folder Reorg Changes (include/half)
With backward compatibility support option enabled (ON) by default.

@pfultz2 , @nunnikri All review comments are addressed, This is replacement of https://github.com/ROCmSoftwarePlatform/half/pull/4. Kindly review and approve, for proceed to merge.

@pfultz2 Kindly approve to merge. Thanks in advance.


test(#2017): Add cypress test for configuration

Purpose
 Add cypress e2e tests for the two UI modules general configuration and labels.
Remarks

PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no

Welcome to StreamPipes @Marcelfrueh and congratulations to your first PR 🎉