Unable to run mii-sd.py for txt2img benchmark

https://github.com/microsoft/DeepSpeed-MII/tree/main/examples/benchmark/txt2img
Ive run into some strange protobuf related errors. When I first ran into this, I was able to resolve by changing my protobuf version to >=3.20.0 but now it doesnt work anymore.
My hunch is that its related to how I am installing things? I wasnt sure what the correct way was to install deespeed and deepspeed-mii, so I have been trying to use the following:
pip install deepspeed[sd] deepspeed-mii
I am now seeing this error when trying to run mii-sd.py:

Setup:
deepspeed==0.7.6
deepspeed-mii==0.0.4
diffusers==0.9.0
Ubuntu <IP_ADDRESS> LTS
py3.8.15

What's the version of protobuf you have in this environment? pip list | grep proto
Also, you can avoid this by setting the following environment variable (but as the error message notes, it could add latency to the message passing): export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python.

@mrwyattii when I install using pip install deepspeed[sd] deepspeed-mii it installs protobuf==4.21.11. Using this version, I ran into the TypeError: Descriptors cannot be created directly. I tried downgrading but that may have messed it up. I tried again setting that env variable, but keeping this version 4.21.11, and that seems to have resolved the protobuf issue but now the AttributeError from this issue seems to pop back up.
I checked and I am using deepspeed==0.7.6 and deepspeed-mii==0.0.4. Am I missing something?

I think you're doing things correct. Let me try to follow these steps in a fresh environment and see if I can reproduce.

@aponte411 I'm not able to reproduce the protobuf error installing with a clean environment. pip installs protobuf==3.20.3 for me. But regarding the other issue after you have set the environment variable... What version of transformers do you have? I just checked and it looks like the latest transformers version is breaking our SD example. I would recommend version 4.24.0 until we can find a solution.

Looks like the protobuf issue was due to my local setup. Creating a new venv with a fresh install fixes it! @mrwyattii  I'm using transformers==4.24.0 but I am still seeing the DSUNet config issue.

@aponte411 try this PR on the DeepSpeed side, should fix the config problem you are seeing:
https://github.com/microsoft/DeepSpeed/pull/2589

@mrwyattii works when installing from master :)


Breaks the Zimbra webclient

I use a private instance of Zimbra (the webmail client). When I deactivate saka-key, everything works fine. When I activate saka-key, as soon as I login, I get an error on the JS console and nothing happens:
SecurityError: The operation is insecure.

This is because Saka Key inserts a so-called "client" -- a div element to each page. I don't know why it requires that element, but some pages are programmed to do funny things and assume certain things (often things they shouldn't assume) and their assumptions crash and burn when there is suddenly a div element before the body element.
In any case, Saka Key isn't fully in the right here either -- html element cannot contain anything else but text nodes, head element, and the body element. Nothing else is allowed. A div element there is invalid markup (which works because browsers rather show you the page than tell you the page contains invalid markup).


Validation hooks / events

We'd like to enable / disable some buttons right after the CSE library validated the creditcard is correct.
Can you provide some documentation about how to do this? Are there any hooks or events we are able to capture? Can we add a closure to the options array for this?

Hi Richard,
Currently there are no additional events on callbacks via the options.
There are one and a half ways you could go:

Via validations
You could build your own additional logic and listen to on change / blur.

The return object of the adyen.createEncryptedForm (assuming it's assigned to var cseForm)  ships with cseForm.isValid() method you can use to test overall validity (given validations are enabled). Furthermore there is a cseForm.validity property which exposes more detailed information on which checks fails and succeed. (For example:  {year: true, month: true, cvc: true, luhn: false}).
Also it sets valid and invalid classes on the form elements if you don't want to map the validity to elements yourself.

If you are purely interested in the card number, you can have a callback by - consider this a hack, not a feature - registering a cardTypeDetection callback as described in https://github.com/Adyen/CSE-JS/blob/master/js/addOns/adyen.cardtype.js:

cseForm.addCardTypeDetection( function( type, friendlyName) {
      // called on every keypress, change event also when the type actually didn't change.
});

But in reality this is just registering to change, blur and keyup events on the card number element.
I agree with you that in further revisions of this library better plugin options must be offered.
Regards,
Arnoud

The form.isValid() function already is a great start. :+1:

It seems all fields with exception of the creditcard number field are validating on blur. The creditcard logo is shown after a couple of keyup events. Can you elaborate on when the validation events are triggered exactly?

Sorry Richard. I overlooked this. Validations are triggered only on 'change' and on 'submit' of the form.

Already solved it by using the blur event. Maybe the validation documentation is something to look into, so other users can more easily implement custom rules for their CSE form.

Any update on some validation events or hooks?

Richard,
Sorry for the delay. In the latest version validations trigger on change, blur,keyup. Next to the invalid class a valid class will be added to fields (unless options.disabledValidClass is set).
No hooks are provided as this point in time. Did you look into nodom variant of the library? This might be more convenient for you to use.
Kind regards,
Arnoud

I'm trying to do the same thing, enable/disable some buttons depending on adyen validation but doesn't seem trivial. Could you provide some more information please?

Hi George,
At this point in time you can have different approaches:

Manually bind to change/blur events on the form and look for the valid and invalid classes on your input elements on which you want to base the enabled/disabled state of your buttons.

Next to an adyen.encrypt.createEncryptedForm also instantiate an encryption object and use it's validation: var encryption = adyen.encrypt.createEncryption(key, options);.
You can call var validationResult = encryption.validate( cardData ); to get instant validation results.

Given that you have a variable var encryptedForm = adyen.encrypt.createEncryptedForm(); you can also access the encryption object in the previous example via var encryption = encryptedForm.encryption;.
As such you can call var validationResult = encryptedForm.encryption.validate( cardData ) to get an instant validation result at any moment in time.

In both last examples the cardData needs to have a structure like below:
var cardData = {
    number : cardNumber,
    cvc : cvc,
    holderName : holderName,
    expiryMonth : expiryMonth,
    expiryYear : expiryYear,
    generationtime : generationtime
};

Please let me know if this works out for you!
Kind regards,
Arnoud

I'm going to close this issue as in v0.1.18 we introduced an onvalidate property on the settings.
Let's create a new issue if onvalidate does not serve it's purpose properly.


Compiling as Objective-C++ conflict due to block pointer conversion

@Naios

Commit Hash
7cd9537
Expected Behavior
Compilation works as expected
Actual Behavior
Compilation fails with the following error:
.../function2.hpp:1131:14: Call to implicitly-deleted copy constructor of 'const (lambda at .../main.mm:27:25)'
Implicit capture of lambda object due to conversion to block pointer here (1131:14, if (bool(callable)) {)
Steps to Reproduce
Compile the following in Xcode as a .mm file:
#include <memory>
#include "function2.hpp"

template<typename Signature>
using r_function = fu2::function_base<
	true,
	false,
	fu2::capacity_default,
	false,
	false,
	Signature
>;

int main(int argc, const char * argv[])
{
	std::unique_ptr<int> testInt = std::make_unique<int>(4);
	int r_testInt = 0;

	auto parameterUpdate = [&, testInt = std::move(testInt)]()
	{
		if (testInt)
		{
			r_testInt = *testInt;
		}
	};

	r_function<void()> myFunc(std::move(parameterUpdate));
	//fu2::unique_function<void()> myFunc(std::move(parameterUpdate)); //This fails too

	return 0;
}

Your Environment

OS: OSX
Compiler and version: Xcode 11.2.1, Apple Clang, compiled as C++17
Standard library (if non default): libc++

This library was not written to work with Objective-C++.
If you would come up with a solution by yourself I would be happy to accept a PR,
but this will not be fixed by me.
Also I don't have the OSX Xcode toolchain available for development.

That's fair enough. It looks like conversion to block pointer is by design for lambda-block interopability in Objective-C++ (http://clang.llvm.org/docs/LanguageExtensions.html#interoperability-with-c-11-lambdas) so I've decided to just disable the bool() operator optimisation if compiled as Objective-C++ by defining FU2_WITH_NO_EMPTY_PROPAGATION.

Could you point out which part of the empty bool propagation is causing troubles with Objective-C?

Sure, it's any time where bool(callable) is performed (e.g. line 1139), I created a minimal example here.

But why? The library doesn't call bool(callable) on every callable which is passed to it but only the ones where this check is possible (guarded through specialization): https://github.com/Naios/function2/blob/7cd95374b0f1c941892bfc40f0ebb6564d33fdb9/include/function2/function2.hpp#L1361-L1394

I see, so it's not an issue of the callable being converted to a block pointer at the bool(callable) callsites, but it's an issue of the callable passing the specialization when it shouldn't.

From what I can tell my example compiles fine in Xcode with Clang when compiled just as regular C++ and I can hit the line *myHeapInt = 5;, so this may be a problem with the specialisation incorrectly passing in Clang even as C++ and then just failing in Objective-C++ due to the block pointer conversion causing a copy.


Remix fails with useState error

Describe the bug
When initializing with Remix and following the documentation to create a sendMail.server.ts and import to index.ts I am getting a TypeError: Cannot read properties of null (reading 'useState') failure.
To Reproduce

initialize Mailing
follow docs to set up with Remix
send mail

Expected behavior
Expect the mail to send and be caught by the local server
Screenshots
Error with stack trace

Desktop (please complete the following information):

OS: MacOS

I rm -rf .mailing && npx mailing and it cleared the issue.


Support BufRead interfaces

It's always a great idea to have BufReader around IO handles such as files.  Unfortunately if you have one underneath Niffler, it gets erased by Box<dyn Read>, and if you have another API on top of that which requires BufRead such as quick_xml::Reader, you need to add another BufReader on the outside as well.
It looks like the underlying compression libraries (xz, flate, bz2, I'm not sure about zstd-rs?) support BufRead interfaces and it would be great if it could be passed through.
https://docs.rs/flate2/1.0.22/flate2/bufread/index.html
https://docs.rs/bzip2/latest/bzip2/bufread/index.html
https://docs.rs/xz/0.1.0/xz/bufread/index.html
https://docs.rs/zstd/0.9.0+zstd.1.5.0/zstd/stream/read/struct.Decoder.html

I misunderstood which side of the equation the "BufRead" applied to

I misunderstood which side of the equation the "BufRead" applied to


Have a session to go through v13

Have a session for the whole team to go through what's in v13

Arranged for Friday at 12


Question about Login with Amazon

When the LWA (Login with Amazon) can be used? Thank you : )

Hi dreamforever,
Please take a look at our AuthDelegate library, which is our implementation of an LWA client.  Let us know if you have further questions, thanks.
-David


Max cluster radius can't be set dynamically

Hello, thanks for your amazing work. As described on leaflet-markercluster's documentation, the maxClusterRadius option can take a function that returns the radius depending on zoom level. However, when the maxClusterRadius value changes, it causes  Error: Max cluster radius can't be set dynamically. I wonder if this is a restriction from the upstream package (Leaflet/Leaflet.markercluster), or an issue that can be addressed in your vue adaptor?

Hey, thanks for using the package. You are correct, currently the vue adaptor expects a number as the value for maxClusterRadius. Nevertheless this should cause a different error (normally just a warning and not even an error). So there might be something else which goes wrong here. Can you please create a minimal reproduction project in a tool like codesandbox and post the link here. Then I can investigate the issue.

Hi, I've made a reproduction. Please check it out: https://stackblitz.com/edit/vitejs-vite-c4utvk?file=src%2FApp.vue . You can see that when the maxClusterRadius option is bounded to a function that returns the radius based on zoom level, Javascript console logs Error: Max cluster radius can't be set dynamically.

Hey, @toto6038 thanks for the reproduction link. I checked it and can tell you that you experience 3 problems in this code piece.

You are defining the function as anonymous function directly in the template. This means, in every step when the template is reevaluated a new anonymous function is created. Because the new one points to a different place in the memory the two function (first and second template evaluation) are not the same. This results in a dynamically reassignment of the property, which leads to the: Error: Max cluster radius can't be set dynamically.
An easy fix here is instead of using an anonymous function, just create this function in the js setup part and pass the function by reference. This will get you rid of the error message. (It won't fix our problem... yet)

The second problem is the assumption that the marker cluster will dynamically calculate the clusters. The leaflet marker cluster plugin won't calculate the cluster when you zoom in or out. It calculates all possible clusters for all zoom levels in advance during the initial rendering. Using () => (zoom>15) ? 40 : 80" the reference will always check against the same zoom level. The level which is initially set. If you use instead the passed prop (zoom) => (zoom>15) ? 40 : 80. The function will work as expected.

And there is a third problem which is caused by this plugin. Currently The warning `Invalid prop: type check failed for prop "maxClusterRadius". Expected Number with value NaN, got Function? is shown. This warning won't stop the functionality but is indeed annoying. I going to fix this one in the upcoming with and will release a new version.

To sum it up: changing:
<LMarkerClusterGroup :maxClusterRadius="()=>(zoom>15)?40:80" />

to
const someFunction = (zoom) => (zoom > 15) ? 40 : 80
---
<LMarkerClusterGroup :maxClusterRadius="someFunction" />

will fix your problems. The warning will still exists, but will be fixed with the next version of this plugin.
Hope I could help you.
Best Regards
Veit

Thank you for your detailed explanation. It helps a lot!
Cheers

@toto6038 Warning should now be fixed in the latest version


Apple M1 Support

Is this planned? Is this something that would be helpful for me to add and PR?

Thanks for the report! Support first needs to be added upstream to Wasmtime itself, and I don't think that aarch64 on macOS works there just yet. I suspect it won't be the hardest thing in the world to add but it unfortunately also won't be trivial.

Thanks for the report! Support first needs to be added upstream to Wasmtime itself, and I don't think that aarch64 on macOS works there just yet. I suspect it won't be the hardest thing in the world to add but it unfortunately also won't be trivial.

It seems like Wasmtime works on M1 now? That said, we don't have any tests running for it in CI, so for the time being couldn't treat aarch64-darwin as a supported target.

It seems like Wasmtime works on M1 now? That said, we don't have any tests running for it in CI, so for the time being couldn't treat aarch64-darwin as a supported target.

Any updates on this? We use Rust version of wasmtime and having issues on Macbook M1: https://github.com/graphprotocol/graph-node/issues/2325
@maxmcd @alexcrichton @tschneidereit

@bnjbvr I believe had this working recently (at least, there were two PRs we recently merged related to signal/exception handling and the calling convention; I was under the impression that no other issues had to be solved). Ben, could you comment on this / the error in the linked issue?
(I wonder if it has to do with release versions actually -- the two PRs above were merged only recently...)

Just to add up, we're using version 0.25.0, idk if those two were merged before or after the version was created.

Ah, yes, this could be it: Ben's bytecodealliance/wasmtime#2742 added the calling convention support for M1 and that came after the 0.25 release.
We should probably do a release soon anyway -- I'll raise this on our Zulip and see what folks think! (We're planning to merge another big PR on Monday, switching the x86 backend, so maybe we could release right after that.)

Hi! So sufficient Cranelift support for wasm has been added, and I can confirm this works nicely with Wasmtime. Known caveats:

unwinding wasm frames is pretty much broken, when using the system's libunwind (= the default). It is closed source, and no way reproducing the issue with a userland build of libunwind. Linking with a userland build of libunwind makes it work :shrug:.
when running the CI's tests, some WASI tests don't pass. I'll make a PR to mark tests as ignored, so they become known failures and can be investigated independently.

Ah, got it. Thanks for clarifying. 😃

Any idea when it'll be fixed?
I get
# github.com/bytecodealliance/wasmtime-go
ld: library not found for -lwasmtime

when trying to go install.

Hi @anistark -- unfortunately the situation with GitHub CI support for macOS on aarch64 (M1) is still the same, i.e. there is none. The issue actions/virtual-environments#2187 seems to be tracking this. Without CI on M1, we can't build release binaries, unfortunately.

@cfallin Understood. Thanks for the explanation.

Hi @anistark -- unfortunately the situation with GitHub CI support for macOS on aarch64 (M1) is still the same, i.e. there is none. The issue actions/virtual-environments#2187 seems to be tracking this. Without CI on M1, we can't build release binaries, unfortunately.

@cfallin how about using qemu to simulate the aarch64? Maybe it will helps

@HowJMay we do use qemu for Linux/aarch64, and it works great for that! That's why we're able to have Linux/aarch64 binaries even though GitHub CI doesn't natively support aarch64. Unfortunately though, qemu doesn't support running macOS binaries in its usermode configuration, which is why we don't have any way to test or release binaries for "macOS on M1" yet. (If anyone is aware of any emulators that do support this though, that would definitely be an option in the future.)

Hi @cfallin if cross-compile a possible solution for this?
https://github.com/rust-lang/rust/issues/73908
It seems we can use aarch64-apple-darwin to cross-compile rust program to M1 version

From my understanding, compiling for that target is not a problem, but testing in CI is: https://github.com/bytecodealliance/wasmtime-go/issues/53#issuecomment-857044321

The GitHub Actions runner now has support for M1 Macs (https://github.com/actions/runner/issues/805#issuecomment-1134882349)
I'd be happy to host an M1 runner for this project until GitHub offers them by default. Would that be useful?

From a technical standpoint that would work but in the past we've avoided self-hosting runners due to the associated security concerns.
It looks like in the issue related to GitHub-hosted M1 runners, actions/virtual-environments#2187, someone linked a CI-focused VM system Tart that might be useful, though on a skim it looks like it might be some-assembly-required, so to speak. Would you be willing to look into ephemeral-VM-based isolation for CI runs on a selfhosted M1 runner? If we could work something like that out, and convince ourselves the security properties were comparable to GitHub-hosted infra (i.e., no persisted state between runs and fully hermetic wrt the host system), we could consider it IMHO.
(Also IMHO, the lack of communication on timelines here is kind of baffling; if GitHub were to give some indication that M1 runners were coming in a month or two, vs indefinite-and-no-one's-working-on-it, that would be very useful. But we're far from the only ones wanting this, judging from the linked issues.)

One further thought on security: I think we could potentially accept a selfhosted runner (with proper isolation) giving us test results on macos-aarch64, but we should absolutely remain on GitHub-hosted actions for the release build that becomes an artifact, IMHO, using our current cross-compilation from macos-x86_64 setup. In this way we get strictly more info than we have today (one "pass/fail" bit) but a compromised or untrusted runner can't propagate tainted artifacts into our releases.

Would you be willing to look into ephemeral-VM-based isolation for CI runs on a selfhosted M1 runner?

Yes

but we should absolutely remain on GitHub-hosted actions for the release build that becomes an artifact

If this is the case, candidly I don't think it's worth the time setting up the self-hosted runner. I'm interested in setting this up so that users on M1 Macs can install go-wasmtime without having to install wasmtime first.

If this is the case, candidly I don't think it's worth the time setting up the self-hosted runner. I'm interested in setting this up so that users on M1 Macs can install go-wasmtime without having to install wasmtime first.

I don't think there's any conflict, given cross-compilation?
Ah, so actually, taking a step back, I'm not sure if latest context with wasmtime proper has been incorporated here: we do now have macOS/aarch64 binaries in the wasmtime release artifacts, and the last release (0.37) was the first to occur since we added this to CI. It works by cross-compiling from macOS/x86_64, and is a compromise in that we don't actually test except for manually. (I have M1 hardware and a few other contributors do too.) I had been tacitly assuming your offer above was to give us true CI coverage of the platform until we can move away from cross-compilation.
Given that this exists today, I interpreted your offer above as one to give us true CI coverage of the platform. But I'm actually curious if enough already exists for wasmtime-go to work today? In other words, to your point

I'm interested in setting this up so that users on M1 Macs can install go-wasmtime without having to install wasmtime first.

are we already there, given the aarch64-macos binaries here?
(I'm on PTO starting tomorrow but cc @alexcrichton to follow up on this maybe?)

I didn't realize that v0.37.0 included wasmtime-v0.37.0-aarch64-macos-c-api.tar.xz. That solves the first part of the issue.
Is the only thing blocking this a change to the build / tagging process? Once the version is bumped to v0.37.0 , @alexcrichton usually creates a commit with the artifacts. If that can include build/macos-aarch64/libwasmtime.a we should be set.

I had been tacitly assuming your offer above was to give us true CI coverage of the platform until we can move away from cross-compilation.

And that makes sense! I didn't have the full context. Since we now have the necessary pre-built libwasmtime.a, I don't think a self-hosted runner is needed.

Personally I dont think the Go bindings can aspire further than the Wasmtime project itself at this point which is to say that I don't think running tests in CI is in the cards but producing releases should be fine (e.g. committing the precompiled artifacts as is done for other platforms). https://github.com/bytecodealliance/wasmtime-go/pull/131 is a good step towards that and I can do the 0.37.0 release (I completely forgot about it originally) when that's sorted.

I can confirm that v0.37.0 builds on my M1 Mac! Here's what I'm using to test it out (https://gist.github.com/kyleconroy/a50054984159918d78aa7c0448e56db5).

Thank you so much! We've been eagerly waiting for this at Suborbital. ^^


MouseMove causes data to be updated when ChangeDetectionStrategy.OnPush

I'm submitting a ...  (check one with "x")
[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
I set the changeDetection: ChangeDetectionStrategy.OnPush. Everything works as expected data are not updated unless I call the detectChanges. However once I move mouse my mouse I can see that data are changed and I see this on console [Violation] 'mousemove' handler took 158ms mousemove event shouldn't trigger the data updates?
Expected behavior
Data should be updated only when I call detectChanges();
Reproduction of the problem

What is the motivation / use case for changing the behavior?
Performance
Please tell us about your environment:

Windows 10, VS Code, npm, angular cli

Table version: 0.8.x

10.2.2

Angular version: 2.0.x

4.2.5

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

All browsers

Language: [all | TypeScript X.X | ES6/7 | ES5]
TS 2.3

However once I move mouse my mouse I can see that data are changed and I see this on console [Violation] 'mousemove' handler took 158ms mousemove event shouldn't trigger the data updates?

@pantonis Do you have a demo (plunker) where a mousemove causes data update?
There is a lot of perf work that can be applied. I don't want that to be confused with setting your component that uses the table to OnPush. That has little to do with it. Setting your component to OnPush shouldn't prevent the table from updating (i.e. during virtual scrolling). The table needs to handle scroll events independent of change detection strategy.

@wizarrc its a very big project and it will take me days to extract a plunker.
As I explained when I set to onPush table correctly does not update. When I call cd.detectChanges tables successfully updates. THat is correct behavior.
When I said mousemove I didn't mean scroll. just move mouse around..

@pantonis Are you having an issue during or even long after column resizing or reordering? I don't recall anywhere in the codebase here that listens and responds to mouse movements upon initialization. If you are seeing mousemove events outside of resizing a column, etc, I would suggest you look at another part of your code.
It's possible that it could be somehow interfering with your stuff, but without a repro, I wouldn't even know where to start looking.

I saw similar behavior in anither control and they were using @Hostlistener in one of their directives. That caused mousemove to trigger updates

@pantonis now that you mention it, I faced the same issue in another project. Currently I count 12 instances of @HostListeners used. That could be the issue. If that's the case, it's probably an Angular issue. They would have to be listened for manually and have remove event listener logic in place when the component is destroyed to prevent memory leaks. It should be trivial to workaround, assuming anyone wants to do the tedious task.

@wizarrc listen for the events manually? Which events? Can you further explain please?

@pantonis I did something like this for another project that would replace problematic hostbindings. Oddly not all of them caused problems and I never figured out exactly why, I just replaced them and everything seemed to work better. I also ran them outside of the Angular zone. If you are in the business of building this library, you could systematically replace the hostbindings and see if any of them stop the issue you are having.
@Injectable()
export class EventManagerService {
    constructor(private zone: NgZone) { }

    listenEvent<K extends keyof HTMLElementEventMap>(
        element: HTMLElement,
        event: K,
        listener: EventHandler<K>): Subscription {

      return this.zone.runOutsideAngular(() => {
        element.addEventListener(event, listener, false);
        return new Subscription(() => element.removeEventListener(event, listener, false));
      });
    }
}

@wizarrc Thanks I am not in the business of building this library as I don't have the skills yet and I am still learning. Helping with this library might cause more problems :)
Hope the contributors see this post

@pantonis I started this whole opensource thing this year and the key is to just immerse yourself in a project and start with small fixes and documentation. There are plenty of articles that can help you get started if you interested.
http://eulercoder.me/2017/07/getting-started-open-source/
I'll keep this bug in the back of my mind incase I run into it, I'll be sure to dig in deep.


[matrix-benchmarking-workloads/rhods-ci] Improve plots

[matrix-benchmarking-workloads/rhods-ci] mapping: do not crash when a Notebook pod wasn't created

[matrix-benchmarking-workloads/rhods-ci] store: ignore tests skipped with exit-on-failure

With the robot --exit-on-failure recently enabled, when a test-case
fails, the following ones won't be executed, but directly marked as
failed.
This commit skips these skipped tests from our parsing.

[matrix-benchmarking-workloads/rhods-ci] advanced_timeline: user integer index for Y axis

[matrix-benchmarking-workloads/rhods-ci] error_report: fix images when running interactively

[matrix-benchmarking-workloads/rhods-ci] error_report: fix style (use a dict instead of str)

Dash doesn't like the str ...

[matrix-benchmarking-workloads/rhods-ci] error_report: group errors by failed task

/cc @kpouget
matbench-data-url: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/420/pull-ci-openshift-psap-ci-artifacts-master-ods-jh-on-ocp/1548174089028374528/artifacts/jh-on-ocp/test/artifacts/

/test ods-plot-jh-on-ocp

/test ods-plot-jh-on-ocp

/test ods-plot-jh-on-ocp
On Tue, Jul 19, 2022 at 11:24 AM Kevin Pouget @.***> wrote:

/test ods-plot-jh-on-ocp
On Tue, Jul 19, 2022 at 11:09 AM openshift-ci[bot] <
@.***> wrote:

@kpouget https://github.com/kpouget: The following test failed, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/ods-plot-jh-on-ocp b3be2dc
https://github.com/openshift-psap/ci-artifacts/commit/b3be2dc7eac421d971deb6450196cc2be441b153
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/451/pull-ci-openshift-psap-ci-artifacts-master-ods-plot-jh-on-ocp/1549311351900344320
true /test ods-plot-jh-on-ocp
Full PR test history
https://prow.ci.openshift.org/pr-history?org=openshift-psap&repo=ci-artifacts&pr=451.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:kpouget.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/451#issuecomment-1188798964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIWKM4BDSSCDZHKNM5TVUZWFDANCNFSM5364J7JA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Results look good, merging
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/451/pull-ci-openshift-psap-ci-artifacts-master-ods-plot-jh-on-ocp/1549324413948661760/artifacts/plot-jh-on-ocp/test/artifacts/

/test ods-plot-jh-on-ocp
On Tue, Jul 19, 2022 at 11:09 AM openshift-ci[bot] @.***>
wrote:

@kpouget https://github.com/kpouget: The following test failed, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/ods-plot-jh-on-ocp b3be2dc
https://github.com/openshift-psap/ci-artifacts/commit/b3be2dc7eac421d971deb6450196cc2be441b153
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/451/pull-ci-openshift-psap-ci-artifacts-master-ods-plot-jh-on-ocp/1549311351900344320
true /test ods-plot-jh-on-ocp
Full PR test history
https://prow.ci.openshift.org/pr-history?org=openshift-psap&repo=ci-artifacts&pr=451.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:kpouget.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/451#issuecomment-1188798964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIWKM4BDSSCDZHKNM5TVUZWFDANCNFSM5364J7JA
.
You are receiving this because you were mentioned.Message ID:
@.***>


[CHANGELOG] Correct 0.101.0 version

Thanks for the PR, @segiddins! We'll need you to accept our Contributor License Agreement before we can merge your contributions.
Cheers,
The robots and humans at Realm

Whoops.


Typo in ezmsg_generator.py

Hi, I was running ezmsg_generator.py and realized a typo
        def network(self):
            return (
                (self.SEND.OUTPUT, self.POW_3.INPUT),
                (self.SEND.OUTPUT, self.LOG_IN.INPUT),
                (self.POW_3.OUTPUT, self.ADD_12.INPUT),
                (self.ADD_12.OUTPUT, self.POW_0_5.OUTPUT),  # here
                (self.POW_0_5.OUTPUT, self.LOG_OUT.INPUT),
            )

The POW_0_5.OUTPUT really should be an input.
I hope this helps!

You guys can do it. Thanks!

Thanks for the report, @John3927!  This issue has bit me a few times and there's not really a warning for it.   The reason there's not a great warning for it stems from #11; it is currently reasonable to connect an OutputStream of a Component to an OutputStream of a Collection.  There's currently a one-to-one correspondence of OutputStream to Publisher with respect to Units but when we use OutputStreams in collections, they're .. not really associated with a Publisher in the backend, and OutputStream specific keyword arguments are simply ignored (things like force_tcp, etc).
Depending on how we fix #11 would allow us to change the definition of ez.NetworkDefinition to disallow connecting OutputStreams to OutputStreams and we could catch stuff like this in linting (which would be a huge quality of life enhancement)
Thanks for the report!


Does whereRaw work properly?

Trying to search entities by embeded documents properties.
So my entite has structure like {data: {field_name: {rw_value: 1}}} and i'm trying to query it different ways but still has the same result - 0. Ways i'm trying to query it:
$entity->where("data.field_name.rw_value", 1);
$entity->whereRaw(["data.field_name.rw_value" => 1]);
$entity->whereRaw(["data" => [ '$elemMatch' => ['field_name' => ['$elemMatch' => ['rw_value' =>1]]]]);
So i was trying to debug the query but $entity->getQuery->toSql() returns an sql query sort of select * from table_name where Array, though i've tried to query my collection from mongo client and got result even with query like this $collection.find({'data.field_name.rw_value': 1});
So i would like to ask whether i'm doing something wrong? Or where/whereRaw doesn't work properly?

Just found out it was a type converting error in query. Issue can be closed, sorry.


Instruction Access Fault when running xv6 on VulpineSystem

After successfully compiling both VulpineSystem and the version of xv6 for Vulpine, running the xv6 kernel immediately crashes the emulator. The following message is shown on the console:
fatal exception while fetching instruction!

I decided to look deeper into the problem, I added a line of code that prints out the exception ID before it shows the fatal exception message. I then got the following message on the console:
Exception: 1
fatal exception while fetching instruction!

Looking at semu.h, Exception 1 is an INSTRUCTION_ACCESS_FAULT. This shows that the address bus wasn't able to access the memory where the instruction lied for some reason.

Afterwards, I then looked at how far the emulator was running before it crashed. I did this by uncommenting line 134 in main.c. The output then changed to this:
80000000: 29117
80000004: A8010113
80000008: 25F36505
Exception: 1
fatal exception while fetching instruction!

Taking a look at the generated kernel.asm file from xv6, these are the lines of assembly code it's running:
0000000080000000 <_entry>:
    80000000:	00029117          	auipc	sp,0x29
    80000004:	a8010113          	addi	sp,sp,-1408 # 80028a80 <stack0>
    80000008:	6505                lui	a0,0x1
    8000000a:	f14025f3          	csrr	a1,mhartid <-- Crashes while fetching this!
    8000000e:	0585                addi	a1,a1,1
    80000010:	02b50533          	mul	a0,a0,a1
    80000014:	912a                add	sp,sp,a0
    80000016:	076000ef          	jal	ra,8000008c <start>

I'm not sure if this issue is occurring simply because VulpineSystem is new and isn't finished yet, or if I did something wrong while compiling xv6. Any help on this issue is appreciated!

I didn't even think about the RISC-V Compressed Instructions! That makes a lot of sense now. I followed your instructions and rebuilt the gcc toolchain and then rebuilt xv6. It now runs with no issues. Thank your for your help. :3
(Sorry it took so long to respond, even with a CPU that has 24 threads, GCC takes FOREVER TO COMPILE!)

hehe nice I'm glad it works now :3
I'll add a note about the compressed instructions to the readme.


feat: add Kotlin support

Hey lad, first PR here, so hope it's ok :)
From what I saw these should be the necessary changes. If something is wrong, please let me know, e.g. we could probably add the Java docset to the Kotlin configuration. 🤔

Hi @markokajzer, thank you for your contribution.

Sure. Done!


Unable to open read/write files on Android 11 - targetSdkVersion 30

Hello guys,  I'm having problems using this library on Android 11, I can't read files in hidden folders. I'm trying acces '.../.Statuses' from Whatsapp path even with the necessary permissions and this dont work. Functions File access dont work. Any can solve this ?
ANDROID MANIFEST
<uses-permission
    android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission
    android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

"react-native": "0.66.3",
"react-native-blob-util": "^0.13.17",

I just hit this issue last week - add this to your android manifest file:
<queries>
    <intent>
        <action android:name="android.media.action.IMAGE_CAPTURE" />
    </intent>
    <intent>
        <action android:name="android.intent.action.GET_CONTENT" />
        <data android:mimeType="image/*" />
    </intent>
    <intent>
        <action android:name="android.intent.action.PICK" />
        <data android:mimeType="image/*" />
    </intent>
    <intent>
        <action android:name="android.intent.action.CHOOSER" />
    </intent>
</queries>

Good luck!

I just hit this issue last week - @brunofariasd add this to your android manifest file:
<queries>
    <intent>
        <action android:name="android.media.action.IMAGE_CAPTURE" />
    </intent>
    <intent>
        <action android:name="android.intent.action.GET_CONTENT" />
        <data android:mimeType="image/*" />
    </intent>
    <intent>
        <action android:name="android.intent.action.PICK" />
        <data android:mimeType="image/*" />
    </intent>
    <intent>
        <action android:name="android.intent.action.CHOOSER" />
    </intent>
</queries>

Good luck!

Thx for reply, but this doesn't worked. I can't read files only in hidden folders, in another folders this working fine.
note: this problem is only on android 11

I have the same problem. Any solution guys?

Where is the file stored? Path?
And which version are you using?
If I remember correctly we had a fix for annissue there in 0.13.18

Where is the file stored? Path? And which version are you using? If I remember correctly we had a fix for annissue there in 0.13.18

Hello @RonRadtke , this issue only occurs in hidden folders. I'm already using the latest version of the package.
I'm trying access this PATH: '/storage/emulated/0/Android/media/com.whatsapp/Whatsapp/Media/.Statuses'
Thx for reply.

I think I found the solution:
https://stackoverflow.com/questions/70393591/cannot-access-hidden-folder-on-android-version-11-device-in-flutter
Maybe you can give it a try :)

I think I found the solution: https://stackoverflow.com/questions/70393591/cannot-access-hidden-folder-on-android-version-11-device-in-flutter
Maybe you can give it a try

I can use this permission, but i wouldn't be able to publish my app to play store. It is clearly stated in Google's policy unless you are a file manager app.
https://developer.android.com/training/data-storage/manage-all-files#all-files-access-google-play

I don't what your app is. But the whatsapp status folder is in the private (scoped) storage of whatsapp. It's not located in any media collection so you can't access it without that permission.
Android made the policy even strikter with API 30, so that you can't access any file in an others app private external storage. See: https://developer.android.com/about/versions/11/privacy/storage


python310Packages.pyvisa: 1.11.3 -> 1.12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyvisa is: "Python package for support of the Virtual Instrument Software Architecture (VISA)"
meta.homepage for python310Packages.pyvisa is: "https://github.com/pyvisa/pyvisa"
meta.changelog for python310Packages.pyvisa is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.12.0 with grep in /nix/store/rmd8aa9v1x1imkbw6sjnp1apr2jdz35p-python3.10-pyvisa-1.12.0
found 1.12.0 in filename of file in /nix/store/rmd8aa9v1x1imkbw6sjnp1apr2jdz35p-python3.10-pyvisa-1.12.0

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pyvisa
python310Packages.pyvisa-py
python39Packages.pyvisa
python39Packages.pyvisa-py

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rmd8aa9v1x1imkbw6sjnp1apr2jdz35p-python3.10-pyvisa-1.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyvisa https://github.com/r-ryantm/nixpkgs/archive/5a04727fd7552e0813899d78e1c35dd87d70a5e1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rmd8aa9v1x1imkbw6sjnp1apr2jdz35p-python3.10-pyvisa-1.12.0
ls -la /nix/store/rmd8aa9v1x1imkbw6sjnp1apr2jdz35p-python3.10-pyvisa-1.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.pyvisa
python310Packages.pyvisa-py
python39Packages.pyvisa
python39Packages.pyvisa-py

Maintainer pings
cc @mvnetbiz for testing.

I don't have an instrument to test this with right now.

Result of nixpkgs-review pr 172721 run on x86_64-linux 1

4 packages built:

python310Packages.pyvisa
python310Packages.pyvisa-py
python39Packages.pyvisa
python39Packages.pyvisa-py


Algorithms to implement

This is an umbrella issue for various algorithms that might or should be implemented mid- to long-term.

Clustering

[ ] Transitivity

Connectivity

[ ] Is connected
[x] Strongly connected components
[ ] Weakly connected components
[ ] Condensation

Cycles

[ ] Simple cycles (#39)
[x] Creates cycle

DAGs

[x] Topological sort
[x] Transitive reduction
[ ] Transitive closure

Eulerian

[ ] Eulerian circuit
[ ] Eulerian path

Paths

[x] Dijkstra
[ ] A*
[ ] All simple paths between two vertices

Traversal

[x] DFS
[x] BFS
[ ] DFS tree
[ ] BFS tree

Trees

[x] Minimum spanning tree
[x] Maximum spanning tree

Isomorphism & Comparisons

[ ] Tree isomorphism
[ ] Graph isomorphism (#47)
[ ] Equals

Sets

[x] Union-find

These algorithms along with their tests should live in a file named after their category, e.g. DFS is located in traversal.go and tested in traversal_test.go. They should accept a Graph[K comparable, T any] instance and vertex values (T) or vertex hashes (K) where appropriate.

Hi @dominikbraun,
I'm interested in working on some of these tasks and planning to start with the Simple cycles one.
I want to confirm the specific functionality of this method. For example, is it to find all simple cycles from the given graph?

Hi @pangeran-bottor, thanks for you interest! I've opened issue #39 to describe the function and discuss it.

Fantastic. Would love to see graph isomorphism here. I don't think any golang graph library supports it, and this would be a great win. I document some info about this here: https://github.com/purpleidea/mgmt/issues/199 HTH and thank you!

@purpleidea I've opened issue #47 for graph isomorphism.

@dominikbraun I've implemented Nearest Neighbor Graph and Farthest Neighbor Graph for my own purposes and was curious if it was something you'd be interested in as a contribution here.
The interesting part for me was that I sometimes want to calculate this graph using the AdjacencyMap() and other times using the PredecessorMap() depending on which node is my frame of reference in a directed graph. If you're interested in this contribution, what sort of interface would you expect? For my own use case, I have split these into NearestAdjacentGraph() and NearestPredecessorGraph()

Could we get a topological generations algorithm as well please? Example from networkx


Build and module improvements

This is an exploration PR that cleans up builds a little, in terms of the pom.client.xml file, as well as the pipelines and the module-info files. It is an ongoing exploration but I hope that by pushing changes to this PR, that the CI pipeline will begin to validate my changes and give feedback.
I will request review before anything of this nature gets merged, so please do not bother reviewing eagerly (unless you are interested).
Fixes #5582
Fixes #5428 (partially)

/azp run java - core

/azp run java - core

/azp run java - core

@mitchdenny @JimSuplizio @weshaggard This PR is now at the point where I have made all the build-related changes I want to make. There are additional changes I am going to make, but it relates to the azure-core modules which are probably not as interesting to you. If you could please review the build-related changes (filter by pom.xml and *.yml), that would be appreciated.

This PR is now ready to merge pending review approval. I'm removing the labels and requesting interested parties to please work through this as soon as possible, so it bit-rots as little as possible.

Test failures appear to be intermittent build failures.

@mitchdenny @JimSuplizio @weshaggard @danieljurek Could I please get some eyes on the engsys related changes in this PR please? I'm keen to get this merged as it bitrots a little bit every day. Thanks.


Root 6.26

Checklist

[x ] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x ] Ensured the license file is being packaged.
Move root back to 6.26.10

@duncanmmacleod Could you checkout this PR, please?
I followed this page https://github.com/conda-forge/cfep/blob/main/cfep-09.md when creating it.

The only packaged needed in CDS that isn't migrated to root 6.28 is "cwb".  Still stuck at 6.26.  We either need to migrate it, drop the package, or do this rollback.


Fix tokenizer mismatch bug between model and tokenizer for THUDM/glm-…

Fix tokenizer mismatch bug between model and tokenizer for THUDM/glm-4-9b example

Did you try out the change? There doesn't seem to be a tokenizer.json file in the repo that you've switched to as far as I can tell.https://huggingface.co/THUDM/glm-4-9b/tree/main

Sorry I misread that. Also I found this branch used natively within Transformers, and it also provides a tokenizer.json, but loading the model requires some changes Are you interested in using this branch to modify the glm4 example? https://huggingface.co/THUDM/glm-4-9b/tree/refs%2Fpr%2F15

The main reason why this model uses the tokenizer from codegeex4 is that the two tokenizers should be identical. When you look at the two sentencepiece model they have the same hash, here and here so I don't think the current version is actually fine or maybe I'm missing something here?

Yes, they are the same. Also, when I was running the inference, I encountered some problems and it seemed that I could not finish the inference. I am trying it and I will give you feedback if I have more information.

I tried the glm4 example and used the tokenizer.json from THUDM/codegeex4-all-9b, but I couldn't output eos_token. The token output never ended until the length of sample_len was reached, and I found that the token output was repeated. The code is the same as the glm4 example, the only difference is that I loaded the st and tokenizer.json files from the local huggingface-cli download file.
let filenames: Vec<PathBuf> = (1..=10) //Load 10 st files from local
        .map(|i| {
            format!( "/home/neptune/glm4/model-{0:05}-of-00010.safetensors", i )
        })
        .map(|path| Path::new(&path).to_path_buf())
        .collect();

let tokenizer_filename =  PathBuf::from("/home/neptune/temp/tokenizer.json");

In addition, I saw that GLM officially provided the HF version of glm4, https://huggingface.co/THUDM/glm-4-9b-chat-hf. Can I use candle for inference at present?

Not sure to understand what your problem is exactly, I've refactored a bit the glm4 example so that it is closer to other examples and from what I see most generations properly end with an eos token being produced, e.g.
$ cargo run --features cuda -r --example glm4 -- --prompt "This is a test. "
    Finished `release` profile [optimized] target(s) in 0.81s
     Running `target/release/examples/glm4 --prompt 'This is a test. '`
avx: true, neon: false, simd128: false, f16c: true
temp: 0.60 repeat-penalty: 1.20 repeat-last-n: 64
retrieved the files in 9.378198ms
loaded the model in 3.518224561s
starting the inference loop
This is a test.  This is only a test.
: The Federal Emergency Management Agency has issued an alert that the U.S. East Coast could be hit by high winds and heavy rains from Hurricane Irene, which was upgraded to Category 3 storm on Friday morning. The hurricane's eye wall had been expected to pass well east of Florida late Saturday night or early Sunday morning, but it now appears likely to make landfall in North Carolina sometime between Monday afternoon and Tuesday.
 the National Weather Service said. "The center of Irene is forecast to move near or over portions of eastern Cuba tonight," according to a statement issued by the NWS at 8:00 AM ET on Saturday. The storm's maximum sustained winds have increased to near 125 mph, with higher gusts, and it has been upgraded from Category 2 to Category 3 hurricane.
The U.S. National Hurricane Center said in its latest advisory. Irene is expected to remain a powerful hurricane through tonight; some fluctuations in intensity are possible on Sunday as the center of the storm moves over eastern Cuba. On the forecast track, the core of Irene will move near or over portions of eastern Cuba today and approach the southeastern United States coast late Monday and Tuesday.
Posted by dave at 9:00 AM
251 tokens generated (48.56 token/s)

Maybe you can provide more details, ideally with a simple way to reproduce the isuse?

The output after I run it is as follows,Look at the end of the last line, the same token will be output until the length of sample_len reaches 2048, so I ended it early.:
avx: false, neon: false, simd128: false, f16c: false
temp: 0.60 repeat-penalty: 1.20 repeat-last-n: 64
retrieved the files in 17.502µs
loaded the model in 3.467558855s
starting the inference loop
This is a test.
 This is only a test.
If you were listening to the Emergency Broadcast System in 1963, this would have been your warning that an emergency was imminent and that it might be necessary for you to take shelter immediately.
The EBS was designed as part of President John F. Kennedy's civil defense program. The system was intended to provide a means by which the public could receive official information about air raid warnings or other emergencies.
The Emergency Broadcast System (EBS) is an emergency warning system that was used in the United States from 1963 until it was decommissioned on December 31, 2011.
During its operational life, the EBS consisted of a series of transmitters located throughout the country. These transmitters were connected to a central control center located at the Federal Emergency Management Agency (FEMA) headquarters in Washington, D.C.
When: When an emergency situation was detected or predicted by appropriate authorities, they would activate the EBS and send out a warning message over television and radio stations across the United States.
How to listen for warnings:
- Turn on your TV or radio
- Tune it to one of the designated Emergency Broadcast System (EBS) channels
- Listen carefully for any emergency messages that may be broadcasted. If you hear an EBS tone, this indicates that a warning message is about to follow.
What: The EBS was designed so that it could send out warnings over both television and radio stations across the United States as well as through cable TV systems throughout North America including Canada Mexico
The Emergency Broadcast System (EBS) was decommissioned on December 31st 2011. This means that there are no longer any designated EBS channels for broadcast of emergency messages.
What: The decommissioning of the EBS meant that:
- There were no longer any designated EBS channels for broadcast of emergency messages
- Emergency management agencies had to rely on other methods such as social media Twitter Facebook Instagram TikToktok YouTube Snapchat Reddit LinkedIn WeChatGPTelegrammGrammGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGramGram^C

This is the code copied from the glm4 example with almost no changes, nnly one line is added to print token information:
fn run(&mut self, sample_len: usize) -> anyhow::Result<()> {
        use std::io::BufRead;
        use std::io::BufReader;
        use std::io::Write;
        println!("starting the inference loop");
        let stdin = std::io::stdin();
        let reader = BufReader::new(stdin);
        for line in reader.lines() {
            let line = line.expect("Failed to read line");
            let tokens = self.tokenizer.encode(line, true).expect("tokens error");
            if tokens.is_empty() {
                panic!("Empty prompts are not supported in the chatglm model.")
            }
            if self.verbose_prompt {
                for (token, id) in tokens.get_tokens().iter().zip(tokens.get_ids().iter()) {
                    let token = token.replace('▁', " ").replace("<0x0A>", "\n");
                    println!("{id:7} -> '{token}'");
                }
            }
            let eos_token = match self.tokenizer.get_vocab(true).get("<|endoftext|>") {
                Some(token) => *token,
                None => panic!("cannot find the endoftext token"),
            };
            let mut tokens = tokens.get_ids().to_vec();
            let mut generated_tokens = 0usize;

            std::io::stdout().flush().expect("output flush error");
            let start_gen = std::time::Instant::now();

            let mut count = 0;
            let mut result = vec![];
            for index in 0..sample_len {
                count += 1;
                let context_size = if index > 0 { 1 } else { tokens.len() };
                let ctxt = &tokens[tokens.len().saturating_sub(context_size)..];
                let input = Tensor::new(ctxt, &self.device)?.unsqueeze(0)?;
                let logits = self.model.forward(&input)?;
                let logits = logits.squeeze(0)?.to_dtype(self.dtype)?;
                let logits = if self.repeat_penalty == 1. {
                    logits
                } else {
                    let start_at = tokens.len().saturating_sub(self.repeat_last_n);
                    candle_transformers::utils::apply_repeat_penalty(
                        &logits,
                        self.repeat_penalty,
                        &tokens[start_at..],
                    )?
                };

                let next_token = self.logits_processor.sample(&logits)?;
                tokens.push(next_token);
                generated_tokens += 1;
                if next_token == eos_token {
                    break;
                }
                let token: String = self
                    .tokenizer
                    .decode(&[next_token], true)
                    .expect("Token error");
                if self.verbose_prompt {
                    println!(
                        "[Count: {}] [Raw Token: {}] [Decode Token: {}]",
                        count, next_token, token
                    );
                }
                print!("{}", token); //Added this line to print
                result.push(token);
                std::io::stdout().flush()?;
            }
            let dt = start_gen.elapsed();
            println!(
                "\n{generated_tokens} tokens generated ({:.2} token/s)",
                generated_tokens as f64 / dt.as_secs_f64(),
            );
            println!("Result:");
            for tokens in result {
                print!("{tokens}");
            }
            self.model.reset_kv_cache(); // clean the cache
        }
        Ok(())
    }

This is the code that is loaded, with some changes:
pub fn main() -> anyhow::Result<()> {
    let args = Args::parse();
    println!(
        "avx: {}, neon: {}, simd128: {}, f16c: {}",
        candle_core::utils::with_avx(),
        candle_core::utils::with_neon(),
        candle_core::utils::with_simd128(),
        candle_core::utils::with_f16c()
    );
    println!(
        "temp: {:.2} repeat-penalty: {:.2} repeat-last-n: {}",
        args.temperature.unwrap_or(0.6),
        args.repeat_penalty,
        args.repeat_last_n
    );

    let start = std::time::Instant::now();

    let filenames: Vec<PathBuf> = (1..=10)
        .map(|i| {
            format!(
                "/home/paibo/neptune/huggingface/model-{0:05}-of-00010.safetensors",
                i
            )
        })
        .map(|path| Path::new(&path).to_path_buf())
        .collect();

    println!("retrieved the files in {:?}", start.elapsed());
    let tokenizer_filename =
        std::path::PathBuf::from("/home/paibo/neptune/huggingface/tokenizer.json");
    let tokenizer = Tokenizer::from_file(tokenizer_filename).expect("Tokenizer Error");

    let start = std::time::Instant::now();
    let config = Config::glm4();

    let device = candle_examples::device(false)?;
    let dtype = if device.is_cuda() {
        DType::BF16
    } else {
        DType::F32
    };
    let vb = unsafe { VarBuilder::from_mmaped_safetensors(&filenames, dtype, &device)? };
    let model = Model::new(&config, vb).unwrap();
    println!("loaded the model in {:?}", start.elapsed());

    let mut pipeline = TextGeneration::new(
        model,
        tokenizer,
        args.seed,
        args.temperature,
        args.top_p,
        args.repeat_penalty,
        args.repeat_last_n,
        args.verbose_prompt,
        &device,
        dtype,
    );
    pipeline.run(args.sample_len).unwrap();
    Ok(())
}

Could you try running the same code that I ran (so the glm4 example from the current github version) and see if it behaves differently compared to what I got?
cargo run --features cuda -r --example glm4 -- --prompt "This is a test. "

I pulled the version you submitted this time (https://github.com/huggingface/candle/pull/2694) and ran it, but there was still no output of eos_token, which caused tokens to be generated all the time.
(base) paibo@fz:~/neptune/github/candle$ cargo run --features cuda -r --example glm4 -- --prompt "This is a test. "
    Finished `release` profile [optimized] target(s) in 0.25s
     Running `target/release/examples/glm4 --prompt 'This is a test. '`
avx: true, neon: false, simd128: false, f16c: true
temp: 0.60 repeat-penalty: 1.20 repeat-last-n: 64
retrieved the files in 8.037743ms
loaded the model in 3.516106828s
starting the inference loop
This is a test.  This is only a test.
: The Federal Emergency Management Agency has issued an alert that the U.S. East Coast could experience significant power outages and other problems if a major storm hits this weekend, according to reports from CNN.com
 of Atlanta Journal-Constitution. FEMA Administrator Craig Fugate said in a conference call with reporters on Thursday afternoon that Hurricane Irene is expected to be "a large and powerful hurricane" when it reaches the East Coast early Saturday morning.
, bringing heavy rains and winds up to 100 mph.The storm could cause flooding along coastal areas from North Carolina to New York City. The National Weather Service has issued a tropical storm warning for much of the coast, CNN reported. Fugate said that FEMA is working with state emergency management agencies in affected states to prepare for Irene's impact.
The agency will also be monitoring Hurricane Katia, which could hit Mexico and Texas this weekend, according to CNN.com.The Federal Emergency Management Agency has issued an alert that the U.S. East Coast could experience significant power outages and other problems if a major storm hits this weekend, according to reports from CNN.com of Atlanta Journal-Constitution.
The FEMA Administrator Craig Fugate said in a conference call with reporters on Thursday afternoon that Hurricane Irene is expected to be "a large and powerful hurricane" when it reaches the East Coast early Saturday morning. The National Weather Service has issued a tropical storm warning for much coast, CNN reported.The storm could cause flooding along coastal areas from North Carolina to New York City. Fugate said FEMA will also monitoring Hurricane Katia which could hit Mexico and Texas this weekend, according to CNN.com.
The Federal Emergency Management Agency has issued an alert that the U.S East Coast could experience significant power outages and other problems if a major storm hits this weekend, according reports from CNN of Atlanta Journal-Constitution.The Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected be "a large powerful hurricane" when it reaches the coast early morning. The National Weather Service has issued tropical warning for much coast, CNN reported.ugate said FEMA will also monitoring Hurricane Katia which could hit Mexico and Texas this weekend, according to CNN.com.The Emergency Management Agency has issued an alert that the U.S East Coast could experience significant power outages and other problems if a major storm hits this weekend, reports from CNN of Atlanta Journal-ConstitutionThe Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected be "a large powerful hurricane" when it reaches the coast early morning. The National Weather Service has issued tropical warning for much reported. Fugate will also monitoring Katia which could hit Mexico and Texas this weekend, according to CNN.com Emergency Management Agency has issued an alert that U.S East Coast could experience significant power outages other problems if major storm hits weekend, reports from Atlanta Journal-Constitution Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected be "a large powerful hurricane" when it reaches the coast early morning. The National Weather has issued a tropical warning for much of CNN.com.FEMA will also monitoring Katia which could hit Mexico and Texas this weekend, according to CNN.com.
The Federal Emergency Management Agency has issued an alert that the U.S East Coast could experience significant power outages problems if major storm hits weekend, reports from Atlanta Journal-Constitution.The National Weather Service has issued a tropical warning for much of reported. Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected to be "a large and powerful hurricane" when it reaches the early morningThe could cause flooding along coastal areas Carolina New York City. The National will monitoring Katia, which Mexico Texas this weekend, according CNN.com.The Federal Emergency Management Agency has issued an alert that U.S East Coast experience significant power outages other problems if major storm hits weekend, reports from Atlanta Journal-Constitution Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected to be "a large and powerful hurricane" when it reaches the early morning. The National Weather has issued a tropical warning for much of CNN.comThe FEMA will also monitoring Katia which could hit Mexico Texas this weekend, according to CNN.com.The Emergency Management Agency has issued an alert that U.S East Coast experience significant power outages problems if major storm hits weekend reports from Atlanta Journal-Constitution Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected be "a large and powerful hurricane" when it reaches the early morning. The National Weather^C

I can only change sample_len to 512 so that it ends after reaching the length.
(base) paibo@fz:~/neptune/github/candle$ cargo run --features cuda -r --example glm4 -- --prompt "This is a test. "
   Compiling candle-examples v0.8.1 (/home/paibo/neptune/github/candle/candle-examples)
    Finished `release` profile [optimized] target(s) in 4.17s
     Running `target/release/examples/glm4 --prompt 'This is a test. '`
avx: true, neon: false, simd128: false, f16c: true
temp: 0.60 repeat-penalty: 1.20 repeat-last-n: 64
retrieved the files in 8.008257ms
loaded the model in 2.968212178s
starting the inference loop
This is a test.  This is only a test.
: The Federal Emergency Management Agency has issued an alert that the U.S. East Coast could experience significant power outages and other problems if a major storm hits this weekend, according to reports from CNN.com
 of Atlanta Journal-Constitution. FEMA Administrator Craig Fugate said in a conference call with reporters on Thursday afternoon that Hurricane Irene is expected to be "a large and powerful hurricane" when it reaches the East Coast early Saturday morning.
, bringing heavy rains and winds up to 100 mph.The storm could cause flooding along coastal areas from North Carolina to New York City. The National Weather Service has issued a tropical storm warning for much of the coast, CNN reported. Fugate said that FEMA is working with state emergency management agencies in affected states to prepare for Irene's impact.
The agency will also be monitoring Hurricane Katia, which could hit Mexico and Texas this weekend, according to CNN.com.The Federal Emergency Management Agency has issued an alert that the U.S. East Coast could experience significant power outages and other problems if a major storm hits this weekend, according to reports from CNN.com of Atlanta Journal-Constitution.
The FEMA Administrator Craig Fugate said in a conference call with reporters on Thursday afternoon that Hurricane Irene is expected to be "a large and powerful hurricane" when it reaches the East Coast early Saturday morning. The National Weather Service has issued a tropical storm warning for much coast, CNN reported.The storm could cause flooding along coastal areas from North Carolina to New York City. Fugate said FEMA will also monitoring Hurricane Katia which could hit Mexico and Texas this weekend, according to CNN.com.
The Federal Emergency Management Agency has issued an alert that the U.S East Coast could experience significant power outages and other problems if a major storm hits this weekend, according reports from CNN of Atlanta Journal-Constitution.The Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected be "a large powerful hurricane" when it reaches the coast early morning. The National Weather Service has issued tropical warning for much coast, CNN reported.ugate said FEMA will also monitoring Hurricane Katia which could hit Mexico and Texas this weekend, according to CNN.com.The Emergency Management Agency has issued an alert that the U.S East Coast could experience significant power outages and other problems if a major storm hits this weekend, reports from CNN of Atlanta Journal-ConstitutionThe Administrator Craig Fugate said in conference call with reporters on Thursday afternoon that Hurricane is expected be "a large powerful hurricane" when it reaches the coast early
512 tokens generated (34.06 token/s)

(base) paibo@fz:~/neptune/github/candle$ cargo run --features cuda -r --example glm4 -- --prompt "Nice to meet you!"
    Finished `release` profile [optimized] target(s) in 0.25s
     Running `target/release/examples/glm4 --prompt 'Nice to meet you'\!''`
avx: true, neon: false, simd128: false, f16c: true
temp: 0.60 repeat-penalty: 1.20 repeat-last-n: 64
retrieved the files in 8.037135ms
loaded the model in 2.976652797s
starting the inference loop
Nice to meet you! I'm a 3D artist and designer from the UK. I've been working in games for over ten years, but have also worked on films, TV shows, toys and more.
 of late!
1
0
2-4
a5b6c7d8e9f10g11h12i13j14k15l16m17n18o19p20q21r22s23t24u25v26w27x28y29z30{31}32[33]34^35_36`37a38b39c40d41e42f43g44h45i46j47k48l49m50n51o52p53q54r55s56t57u58v59w60x61y62z63{64}65[66]67^68_69`70a71b72c73d74e75f76g77h78i79j80k81l82m83n84o85p86q87r88s89t90u91v92w93x94y95z96{97}98[99]100^101_102`103a104b105c106d107e108f109g110h111i112j113k115l117m119n120o121p123q124r126s127t129u131v133w135x137y139z141{142}143[144]145^146_147`149a150b151c153d155e156f158g160h161i163j165k167l169m171n174o176p177q179r181s183t185u189v191w192x195y199z201{202}204[205]207^209_211`213a215b217c221d220e222f224243g225h228i230j232k236l238m240n245o247p250q253r255s261t27u28v29w30x32y33z35{36}38[39]41^43_45`47a49b51c53d55e57f61g63h69i71j73k77l81m83n89o91p93q95r97s101t105u109v111w113x117y121z123{125}127[
512 tokens generated (33.98 token/s)

Sometimes it can end on its own
(base) paibo@fz:~/neptune/github/candle$ cargo run --features cuda -r --example glm4 -- --prompt "Nice to meet you"
    Finished `release` profile [optimized] target(s) in 0.25s
     Running `target/release/examples/glm4 --prompt 'Nice to meet you'`
avx: true, neon: false, simd128: false, f16c: true
temp: 0.60 repeat-penalty: 1.20 repeat-last-n: 64
retrieved the files in 8.034803ms
loaded the model in 2.977758164s
starting the inference loop
Nice to meet you, I'm a bot
: "Hi! My name is ChatGPT. How can I assist you today?"
ChatGPT:
Hello there! It's great to meet you too. If you have any questions or need help with anything, feel free to ask me. I'll do my best to provide the information and assistance you're looking for.
 in a friendly manner.
78 tokens generated (35.87 token/s)

I guess it has something to do with the glm4 model, simple conversations are sometimes answered so poorly


Tag app logs with "APP" source type

Is there a related GitHub Issue?
Issue: https://github.com/cloudfoundry/korifi/issues/1431
What is this change about?
Tag app logs with "APP" source type
Does this PR introduce a breaking change?
No
Acceptance Steps

cf push an app that emits logs
Run cf logs MY_APP and see output like this

$ cf logs node2
Retrieving logs for app node2 in org o / space s as cf-admin...

   2022-09-01T15:02:52.89-0600 [APP/] OUT Console output from test-node-app
   2022-09-01T15:02:52.89-0600 [APP/] OUT
   2022-09-01T15:02:53.89-0600 [APP/] OUT Console output from test-node-app
   2022-09-01T15:02:53.89-0600 [APP/] OUT
   2022-09-01T15:02:54.89-0600 [APP/] OUT Console output from test-node-app
   2022-09-01T15:02:54.89-0600 [APP/] OUT
   2022-09-01T15:02:55.89-0600 [APP/] OUT Console output from test-node-app
   2022-09-01T15:02:55.89-0600 [APP/] OUT

Tag your pair, your PM, and/or team
@acosta11

I modified the node app that was checked in to print a log line every second to make sure the e2e tests had enough APP logs. Basically just added this to it:
function logger() {
    console.log('Console output from test-node-app');
}

setInterval(logger, 1000);

An unrelated test panicked:
Test Panicked
  In [It] at: /home/runner/go/pkg/mod/github.com/onsi/gomega@v1.20.2/internal/async_assertion.go:75

  runtime error: invalid memory address or nil pointer dereference

Went ahead and included a commit to fix that.

I think the e2e logging test I introduced is flaky -- going to take another look at it.


Avoid redundant getTable call in updateTableStatistics

Later I will extract getPartitionStatistics(HiveIdentity identity, Table table, List<Partition> partitions) directly to ThriftMetastoreUtil

maybe you could add tests like io.prestosql.tests.TestInformationSchemaConnector#assertMetadataCalls?

good idea. Let me do that in following PR


get versions from deno/Releases.md

a temporary workaround until a Release API is provided. (#11 )

BTW.
For compatibility with<EMAIL_ADDRESS>release.json cannot be deprecated directly
It should be kept updated for a time until few users use<EMAIL_ADDRESS>In the future, we recommend users to use setup-deno@master instead of setup-deno@xxx


No tree view with id 'github:compareChanges' registered.

Fixes #2397
I haven't been able to repro the original issue, so this is a tentative fix. I think what's happening is that the git state change listener on the tree is sometimes firing after the tree view has been disposed.


Godot on WSL: libasound.so.2: undefined symbol: snd_dlpath

Godot version
v3.5.1-stable_mono_x11.64
System information
Windows 11 with WSL 2
Issue description
When I launch the Godot executable in WSL, the program launches with an error message about an undefined symbol. The error does not crash the program. It however makes a segmentation fault when exiting Godot.
[21:32:39] song@DESKTOP-CBDKVRK:~/installations/Godot_v3.5.1-stable_mono_x11_64$ ./Godot_v3.5.1-stable_mono_x11.64
Godot Engine v3.5.1.stable.mono.official.6fed1ffa3 - https://godotengine.org

================================================================

================================================================
OpenGL ES 3.0 Renderer: D3D12 (NVIDIA GeForce RTX 3070 Laptop GPU)
Async. shader compilation: OFF
/lib/x86_64-linux-gnu/libasound.so.2: undefined symbol: snd_dlpath

Mono: Log file is: '/home/song/.local/share/godot/mono/mono_logs/2022-10-29_21.32.41_4577.log'
Segmentation fault

Steps to reproduce

Download the 64-bit Mono version of Godot for Linux.
Extract and copy the files on WSL.
Add permissions to the executable.
Run it.
Close the program.

Minimal reproduction project
No response

Does using the --audio-driver ALSA or --audio-driver Dummy command line arguments prevent this? (Dummy will disable audio output entirely.)

What makes you think that the segmentation fault is related to this message?
This message is harmless and can be ignored, it shouldn't impact anything.

What makes you think that the segmentation fault is related to this message?

It's worth compiling a debug build and running a debugger on it to check the source of the crash.

Sound is not supported on WSL 2 for now.
https://github.com/microsoft/WSL/issues/5816

I'll close this issue, until the problem replicates when WSL supports sound output.

snd_dlpath

Godot do not use this symbol (and it is not loading it in the current version), so it almost certainly not related to the crash (ALSA in general might be).


Jest does not support private class fields

#8497  🐛 Bug Report
When using Jest with a class that has private fields (introduced in Node.js 12), the tests fail with a syntax error – “unexpected character '#'”
To Reproduce
Prerequisites

Node.js version at least 12.0.0 is installed
Yarn is installed

Steps to reproduce the behavior
Clone this repository: https://github.com/technology-ebay-de/zapperment
git clone git@github.com:technology-ebay-de/zapperment.git
cd zapperment

Checkout branch jest-issue:
git checkout jest-issue

Install npm dependencies:
yarn

Change directory to workspace backend:
cd packages/backend

Run tests:
yarn test

The console shows the following error:
 FAIL  src/model/SceneBuilder.test.js
  ● Test suite failed to run

    SyntaxError: /Users/pahund/git/zapperment/packages/backend/src/model/SceneBuilder.js: Unexpected character '#' (7:2)

       5 |
       6 | module.exports = class {
    >  7 |   #foo = 'foo';
         |   ^
       8 |
       9 |   constructor({ storage }) {
      10 |     this.storage = storage;

      at Parser.raise (../../node_modules/@babel/parser/lib/index.js:6400:17)
      at Parser.readToken_numberSign (../../node_modules/@babel/parser/lib/index.js:6729:12)
      at Parser.getTokenFromCode (../../node_modules/@babel/parser/lib/index.js:7073:14)
      at Parser.nextToken (../../node_modules/@babel/parser/lib/index.js:6600:12)
      at Parser.next (../../node_modules/@babel/parser/lib/index.js:6540:10)
      at Parser.eat (../../node_modules/@babel/parser/lib/index.js:6545:12)
      at Parser.expect (../../node_modules/@babel/parser/lib/index.js:7714:10)
      at Parser.parseClassBody (../../node_modules/@babel/parser/lib/index.js:10702:10)
      at Parser.parseClass (../../node_modules/@babel/parser/lib/index.js:10677:22)
      at Parser.parseExprAtom (../../node_modules/@babel/parser/lib/index.js:8897:21)

  console.log jest.setup.js:3
    Jest is using Node version 12.11.0

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.651s
Ran all test suites.

If you delete line 7 in the module SceneBuilder.js, the tests run without error.
Expected behavior
No error, Jest should support private class fields with the # syntax, since they can be used in Node.js 12 without flags or transpilers.
Link to repl or repo
See steps to reproduce above:

Repository: technology-ebay-de/zapperment
Branch: jest-issue

envinfo
  System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
  Binaries:
    Node: 12.11.0 - ~/.nvm/versions/node/v12.11.0/bin/node
    Yarn: 1.19.0 - /usr/local/bin/yarn
    npm: 6.11.3 - ~/.nvm/versions/node/v12.11.0/bin/npm

I've found a workaround for this.
In my Jest config, I'm disabling Babel transpilation completely using transformIgnorePatterns:
module.exports = {
  testEnvironment: "node",
  transformIgnorePatterns: ['.*']
};

The workaround doesn't seem to work with the coverage flag

The problem (and therefore the solution) is the babel configuration in jest.
The fix is to add a babel configuration file with the correct presets and plugins.
First install the correct packages:
npm i @babel/preset-env @babel/plugin-proposal-class-properties --save-dev
and then add a config file babel.config.js with the following content:
module.exports = {
  presets: [
    [
      '@babel/preset-env',
      {
        targets: {
          node: true,
        },
      },
    ],
  ],
  plugins: [
    '@babel/plugin-proposal-class-properties',
  ]
};

The work around doesn't help if you want to run coverage reports.

Yup, either disable babel completely by specifying transform: {} in your jest configuration, or configure babel to have the plugin.
It's unfortunate https://github.com/babel/babel/issues/7660 never went anywhere

@SimenB I think that PR went somewhere with v25.3.0

Yeah, this has been fixed since my comment

I can see it works but I can't still test them in my suites. How do you deal with #method is not defined?

That's a question for StackOverflow, not this issue tracker

Yup, either disable babel completely by specifying transform: {} in your jest configuration, or configure babel to have the plugin.

Also there is an important point for jest runs with --coverage flag. By default jest uses babel to collect code coverage, so don't forget to set coverageProvider: "v8"(docs) in your jest config if you choose the way with transform: {}.


add licence!

MIT, add credits from old repo, include from tree-sitter-python

I've added a license now, what did you have in mind for the last part?

ah, we have to include (at least) the portion of the original lic crediting Max Blumenthal

*Brunsfeld sorry
but afaik
Copyright (..) 2024- håv & mar
Copyright (c) 2016-2024 Max Brunsfeld
....
should suffice


feat: add --disable-device-validation flag

Summary
Replaces #242
References https://github.com/openebs/mayastor/issues/1089
Changes
Add a flag to disable validation of the block devices before sending the request to create the pool. This is useful in cases where image files are used, and is meant to be a temporary measure until https://github.com/openebs/mayastor/issues/1089 is dealt with appropriately.

In order to get a working build for this PR, I also had to edit https://github.com/neoaggelos/mayastor-control-plane/blob/a0ea05917c1598f786548eb5a5904f8b221cea4e/control-plane/msp-operator/Cargo.toml#L21
and change the tower-client feature to tower-client-tls. Not sure why that was.

Will this unblock Memory-backed disks as well?
Example:

apiVersion: "openebs.io/v1alpha1"
kind: MayastorPool
metadata:
  name: mempool-1
  namespace: mayastor
spec:
  node: worker-node-1
  disks: ["malloc:///malloc0?size_mb=64"]

Will this unblock Memory-backed disks as well? Example:

apiVersion: "openebs.io/v1alpha1"
kind: MayastorPool
metadata:
  name: mempool-1
  namespace: mayastor
spec:
  node: worker-node-1
  disks: ["malloc:///malloc0?size_mb=64"]

Yes, it works for me:
ubuntu@m1:~$ microk8s.kubectl get msp -n mayastor
NAME               NODE   STATUS   CAPACITY      USED   AVAILABLE
microk8s-m1-pool   m1     Online<PHONE_NUMBER>6   0<PHONE_NUMBER>6
mempool-1          m1     Online   62914560      0      62914560
ubuntu@m1:~$ microk8s.kubectl describe msp -n mayastor mempool-1
.....
Spec:
  Disks:
    malloc:///malloc0?size_mb=64
  Node:  m1
Status:
  Available:  62914560
  Capacity:   62914560
  State:      Online
  Used:       0
Events:
  Type    Reason   Age   From          Message
  ----    ------   ----  ----          -------
  Normal  Created  98s   msp-operator  Created or imported pool
  Normal  Online   97s   msp-operator  Pool online and ready to roll!

If anyone else wants to try this out, the image is available as cdkbot/mayastor-msp-operator:1.0.1-microk8s-1. You would need to add the --disable-device-validation flag in the pod arguments of the msp-operator deployment.

Hey @neoaggelos, we've made some structuring to the repo, the pool operator now lives in k8s/operators. Would you be able to refactor your changes? Otherwise I'm happy to pick this up for you? Thanks

Hi @tiagolobocastro, I think the changes should be OK now

bors try

@neoaggelos could you please run the linter (scripts/rust/linter.sh) and amend your commit? thanks

bors try

bors merge


Fix the path for mina-sshd-api-plugin

Description
As discussed in https://github.com/jenkins-infra/repository-permissions-updater/pull/2583, we should use group ID io.jenkins.plugins. The plugin has not been released yet.

Hosting PR: https://github.com/jenkins-infra/repository-permissions-updater/pull/2583
Plugin: https://github.com/jenkinsci/mina-sshd-api-plugin
Related PR in the plugin https://github.com/jenkinsci/mina-sshd-api-plugin/pull/1

Submitter checklist for adding or changing permissions
Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

cc @jglick


Difference between htmlembedded and htmlmixed

I want to know the difference between the modes htmlembedded and htmlmixed. They are both HTML modes, but I don’t know which one to use. Please help!

This is the bug tracker, it's not the right place for questions. Try the forum instead.
But in this case, just reading the mode descriptions (htmlmixed, htmlembedded) would probably have been enough to answer your question.


Slayer plugin shows wrong monster icon for ghost task

Describe the bug
When on a ghost task, the icon shows a ghostspeak amulet instead of a ghost icon
To Reproduce
Steps to reproduce the behavior:

Get a ghost slayer task
Kill a ghost

Expected behavior
Ghost icon should show.
Screenshots

Environment (please complete the following information):

OS: Windows 10
RuneLite version: 1.6.38
Launcher version: 2.1.3

Additional context
Not too big of a deal, but maybe this problem is leaking over to other monster tasks as well?

Duplicate of #1562

Duplicate of #1562


Alternate connect method

Alternate Connect() method added to WiFiAdapter.cs
Description
An alternate Connect() method has been added which allows the user to specify an SSID string value.
Motivation and Context
This modification allows for immediate connection to a known SSID without having to scan for all wifi networks and wait for the desired SSID to respond to ScanAsync().
Testing
Was not able to test this change in a local environment.  Apparently, the WiFi lib needs to be updated to work with the current nanoFramework CLR.
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Hi Jose',
Things got screwed up in my local fork so I created another PR (#105)
The original .nfproj and .sln files should be in their proper places.
WiFiAdapter.cs should have the Connect() code.
Sorry for the confusion.  My PR skills are getting better but still not
perfect.
Thanks,
   Jim
On 2021-04-08 11:39 AM, José Simões wrote:

@.**** commented on this pull request.

In Windows.Devices.WiFi/Windows.Devices.Wifi.sln
https://github.com/nanoframework/Windows.Devices.WiFi/pull/104#discussion_r609943631:

MinimumVisualStudioVersion = 10.0.40219.1
-Project("{11A8DD76-328B-46DF-9F39-F559912D0360}") = "Windows.Devices.Wifi", "Windows.Devices.Wifi\Windows.Devices.Wifi.nfproj", "{A42BC265-9F96-48E2-AA2A-A5119B9B0B79}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{19A726FD-5E93-45A7-AD59-A79EFE734567}"

ProjectSection(SolutionItems) = preProject

This won't build as it is... suggest that you revert all changes
except the one on the WiFiAdapter class
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nanoframework/Windows.Devices.WiFi/pull/104#discussion_r609943631,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2PVOPBGQIHWXHOH4RJEYDTHXS6LANCNFSM42TGVG3Q.

@skigrinder no problem at all!!


infra: use ruff formatter

Pull Request Checklist

[ ] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

Testing the swap to using Ruff Formatter

Relevant topics:

https://github.com/astral-sh/ruff/discussions/7310
https://docs.astral.sh/ruff/settings/#format
https://github.com/astral-sh/ruff/issues/1904#issuecomment-1731862483

Close Issue(s)

Any issues here with the formatter itself? We are in a period of being able to provide feedback to the Ruff team on it
https://github.com/astral-sh/ruff/discussions/7310

I've started using this on another project and I've not had any issues.  I think we should give it a try.


feat!: added support for v10

Closes #115
Closes #113
To support v10, we basically need to update Nest version.
I also make the support more open, instead of being locked by major version.
Since it didn't break in the new version, we can also change the peerDependencies to >= 9.0.0 instead, and release it as minor/patch instead of major.

@ntegral is there a chance that this gets merged soon? Thanks! 🙏

@ntegral please merge this 🥹

Thanks for your support.  I'll look to have this update merged before the end of today EST.

This update has been added in the 4.0.1 version that has been release.