chore: Removing unused region tag

Really, just removing one unused tag.

@m-strzelczyk , I'm going to close this PR due to inactivity but please feel free to re-open it.


Change the UI of the feedback screen

I am using the HockeyApp.feedback() for displaying the feedback screen.
I need to pre-populate Name and Email and change the UI of it. Is there a way to replace the Feedback activity completely with RN so that I can have complete control over it?

+1 this would be great because I realize when my users submit feedback, they don't like to include their email, so I have no way of responding to them...

+1, it would be great to be able to keep the look and feel of the app when sending feedback


APP name choose

Icespotting
Icebreaker
Moje dwie propozycje

IceSearching

IceFinder,
IceCreamSpy

Icespot - favorite flavors in your neighbourhood


feat(compaction): cut file by table

Signed-off-by: Little-Wallace<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
close https://github.com/risingwavelabs/risingwave/issues/5299
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

The left is current PR while the right is main branch. We can see that after compact by table we save some resource and could make trivial move more effective.


fix scan should output all invisiable column

Proposed changes
Issue Number: close #xxx

cherry pick from master #23003
commit id: 0594acfcf16fee6330fc8d9dc37a5a96be60de79
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.98 seconds
stream load tsv:          519 seconds loaded<PHONE_NUMBER>9 Bytes, about 137 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>6 Bytes


error for adding audio folder

hey there,
I tried a lot to add audio folder but it throws error, even I made one folder for one file and changed the code but still  its shows error
as such :-
Traceback (most recent call last):
File "speechEmotionRecognition.py", line 62, in
bk.diarizeFromFolder(f'{INPUT_FOLDER_PATH}{subdir}{"/"}',(f'{OUTPUT_FOLDER_PATH}{subdir}{"/"}'))
File "/content/emotion/src/bulkDiarize.py", line 29, in diarizeFromFolder
diarizeAudio(TOTAL_PATH,TOTAL_OUTPUT_PATH,expectedSpeakers=2)
File "/content/emotion/src/speakerDiarization.py", line 242, in diarizeAudio
main("filterTemp.wav", embedding_per_second=0.6, overlap_rate=0.4,exportFile=exportFile,expectedSpeakers=expectedSpeakers)
File "/content/emotion/src/speakerDiarization.py", line 170, in main
feats = np.array(feats)[:,0,:].astype(float)  # [splits, embedding dim]
IndexError: too many indices for array: array is 1-dimensional, but 3 were indexed
please could u explain me .

Check this out #2


how to add linuxbrew permanantly to my .bashrc or .zshrc

Each time I close my terminal from my Vitual box biolinux 8, I have to write these commands again
export PATH="$HOME/.linuxbrew/bin:$PATH"
export MANPATH="$HOME/.linuxbrew/share/man:$MANPATH"
export INFOPATH="$HOME/.linuxbrew/share/info:$INFOPATH"
Is there a way not to do that each time?

Put them in your $HOME/.bash_profile file.
Things in there will be run for every shell you start.


Error when running local integration tests using the latest nodeshift and openshift-rest-client

A new version of rhoaster was published and it is using the latest version of nodeshift and openshift-rest-client.
The previous rhoaster version 0.2.0 was pointing to the deprecated bucharest-gold image:
15:31 $ npm run test:integration

><EMAIL_ADDRESS>test:integration /home/hf/Documents/nodejs-rest-http
> tape test/integration/*.js | tap-spec

    No deployment found. Deploying...
    2019-10-24T18:31:51.700Z INFO loading configuration
    2019-10-24T18:31:51.701Z INFO using namespace myproject at https://<IP_ADDRESS>:8443
    2019-10-24T18:31:51.704Z INFO creating archive of package.json, app.js, public, bin, LICENSE, licenses
    2019-10-24T18:31:51.719Z INFO using existing build configuration nodejs-rest-http-s2i
    2019-10-24T18:31:51.724Z INFO using existing image stream nodejs-rest-http
    2019-10-24T18:31:51.724Z INFO uploading binary archive /home/hf/Documents/nodejs-rest-http/tmp/nodeshift/build/archive.tar
    2019-10-24T18:31:54.446Z INFO binary upload complete
    2019-10-24T18:31:54.446Z INFO waiting for build to finish
    2019-10-24T18:31:57.516Z TRACE Using bucharestgold/centos7-s2i-nodejs:latest as the s2i builder image
    2019-10-24T18:31:57.516Z TRACE ---> Installing application source
    2019-10-24T18:31:57.516Z TRACE ---> Building your Node application from source
    2019-10-24T18:31:57.516Z TRACE Current git config

So a new version was published to fix that, but an issue was found:
$ npm run test:integration

><EMAIL_ADDRESS>test:integration /home/hf/Documents/nodejs-rest-http
> tape test/integration/*.js | tap-spec

kubernetes-client deprecated require('kubernetes-client').config, use require('kubernetes-client/backends/request').config. node_modules/openshift-rest-client/lib/openshift-rest-client.js:25:17
kubernetes-client deprecated require('kubernetes-client').config, use require('kubernetes-client/backends/request').config. node_modules/openshift-rest-client/index.js:23:39
TypeError: openshift is not a function
    at Object.deploy (/home/hf/Documents/nodejs-rest-http/node_modules/rhoaster/index.js:40:12)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>test:integration: `tape test/integration/*.js | tap-spec`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test:integration script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/hf/.npm/_logs/2019-10-24T18_45_17_405Z-debug.log

TypeError: openshift is not a function
at Object.deploy (/home/hf/Documents/nodejs-rest-http/node_modules/rhoaster/index.js:40:12)

Yup,  the 2.x version of the openshift-rest-client changed how it gets instantiated,  so it makes sense that it would break

fixed thanks!
2019-10-25T18:19:40.227Z INFO Using s2i image nodeshift/centos7-s2i-nodejs with tag latest


[Draci Hlidka] v1.2.0

Changes / Comments
Changed

changed modifiers are counted to attributes

Added

added custom roll templates
added npc/monster sheet

Fixed

fixed skill level ups
fixed max and zo modifiers
fixed printexts for skills and abilities
fixed titles for macro support
fixed merging settings

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[x] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


TN-2981 ironman-v5-3orgs brazilian

https://jira.movember.com/browse/TN-2981

@mcjustin Ran all three of these orgs through flask preview-site-update with the respective retired dates - no problems found.


colorbox content misaligned

With version 0.4.0 of typst the content of the first example box (colorbox) is misaligned.
I have "fixed" it by adding an empty line XOR a #v(0pt)  statement between the two boxes inside the outer box in the module file. But I doubt  that this is more than a workaround for some other problem.

Thanks for pointing it out. It looks rather bizarre for me. I will take a closer look tomorrow.

I couldn't wait.
The Typst documentation defines a box as

An inline-level container that sizes content.

As you said, you could add a new line or add #v(0pt) to force a line break. I think changing box to block would be a better way to solve the problem. However, I will release the fix tomorrow.

Thank you! :-) I'm not that familiar with typst to know that the switch to block is the better solution.


7572: FileSystemStorageProvider shouldn't allow creating folders with "&" in their name

Changes made to prevent ampersand in folder names, especially for Media.
Fixes #7572
To avoid the issues with the '&' character in folder names I made changes on different levels:

Input validation in the forms where the user inserts the folder name, both for new folders and while renaming them.
Validation in MediaLibraryService, in the CreateFolder and RenameFolder methods, in case we get around the html validation.
Validation in FileSystemStorageProvider, because the same path issues will present themselves also for files that we do not access through the MediaLibrary Module.

I tested these correctly prevented me to create/edit folder with an '&' character in the name.

The list of invalid characters is obtained at runtime and is based on web.config.
Additionally, this also handles the fact that the '/' and the '' characters would cause folders to move, or creation of subfolders. Those two characters are added to those obtained from web.config, in case the defaults have been changed.

@sebastienros I added the static regex in MediaFolder and used it in the viewmodels and the services. The view is unchanged, as it reads the pattern from the viewmodel

@MatteoPiovanelli-Laser can you please take care of the review feedback? I'll review/test after so we can include this in 1.10.4/1.11.
Related: #6748

I think I updated this PR correctly. I also added the characters referenced in RFC 1378 as discussed in #6792.

@MatteoPiovanelli-Laser can you please update the PR so I can push a few changes to this branch (Allow edit from maintainers) or I alternatively I can push to my PR (#6792) some of your changes including the following adjustments/remarks:

In the template changes, the title values of the fields contain the validation error messages, but that can be misleading if the input is empty or has valid value. We can change it to describe what it's for and list the characters that are not allowed. Adding client-side validation is nice btw, I only added server-side validation.
In your PR, the path validation is applied to CreateFolder and RenameFolder. I think it should applied to file operations too (upload, rename, move, copy).
In your PR, the path validation is applied to not just to the MediaLibraryService, but also to the FileSystemStorageProvider. That's a good idea, because you can use file storage (in this case file system, but Azure Blob Storage too) without Media Library. I think we should have some common logic in the Framework (StorageHelper or something like that) to pass the strings into for validation. This should include everything from the 0-31 control characters + RFC 1378 (so this would cover HttpRuntimeSection.RequestPathInvalidCharacters and RFC 3986, which is for URIs). I would apply all this to MediaLibraryService, FileSystemStorageProvider and AzureBlobStorageProvider.

@sebastienros do you agree?

The PR is set to allow edit from maintainers already.

Yes, I did not notice that I set that value for the title. It should be changed.
Don't files already have something? There is a GetUniqueFilename method, but I don't remember where/how it's used.
I agree there should be a "centralized" place where invalid characters are controlled.

Thanks Matteo for your work on this and sorry that it took this long to finally get this improved validation done, #6792 was inspired by this PR too.


After fullfil there a bug that make you can not fulfill it again

I see this too...

i have implement my own mo


Support for Google Vertex Models

Support for Google Vertex Models - Gemini 1.5
This PR adds a provider module for Google Vertex AI Models and implements support for Gemini 1.5-flash and Gemini 1.5-pro. In order to use these model providers, you need Google Cloud Authentication, which you can get by installing a command line tool and then authenticating with Application Default Credentials. The configuration file to use when running the DataAgentServer needs to contain two extra fields, for project id and project location.
  "prompt": "You are a helpful customer service representative for a credit card company who helps answer customer questions about their past transactions and spending history. Today's date is January 18th, 2024. You provide precise answers and use functions to look up information. You DO NOT provide general answers and only give an answer after you retrieved all the data you need via functions. Only invoke one function at a time and wait for the results before invoking another function.When you have worked out your answer, you answer the user question in one of two ways: 1) in markdown syntax using tables where appropriate to show data or 2) by calling the data_visualization function to display the data in a suitable fashion. Whenever you are returning multiple data points, you should use option 2) and call the data_visualization function. You should only call the data_visualization function when you already have all the data to display.",
  "api-url": "http://localhost:8888/graphql",
  "auth-field": "customerid",
  "auth-is-integer": true,
  "plot-function": "oneD",
  "model" : {
    "provider" : "vertex",
    "name": "gemini-1.5-flash",
    "project_id": "vertex-gemini-424313",
    "location": "europe-west4"
  }
}

Implementation Details

Since Vertex treats FunctionCall and FunctionResponse as separate models, it was necessary to be able to save and load these two different objects from the Backend. Thus, the functionality of GenericChatMessage, and the GraphQL Queries in the tools and the sqrl files needed to be extended. This will be supported in a different PR, which should be merged before this one.
The implementation of the vertex module was done around the Content class from Google, which represents the basic type of message, containing Parts, which in turn contain, text, images, function calls or function responses.

@mbroecheler I have added configuration files for the other use cases, but was unable to test them due to my docker issues 😢 I really need an EC2 instance pls 🙏  After merging this PR, we need to update the .sqrl and the .grphqls files in the datasqrl-examples Repo as well.

This branch is now rebased on top of https://github.com/DataSQRL/apiRAG/tree/feat/extendedapi and it should be merged afterwards

This branch is ready to be merged

@mbroecheler This PR has been rebased and I have also fixed a small bug with the TokenCounter based on HuggingFace. This is ready to be merged, pending your approval.


Preloading through associations with nils throws error

Environment

Elixir version (elixir -v): 1.5.1
Database and version: PostgreSQL 9.6.1
Ecto version (mix deps): 2.2.2
Database adapter and version (mix deps): 0.13.3
Operating system: macOS 10.12.6

Current behavior
Preloading 'through' associations with 'nil' intermediary causes error (but only if intermediary is already loaded):

defmodule User do
   use Ecto.Schema

   schema "users" do
       belongs_to :city, City
       has_one :country, through: [:city, :country]
   end
end

user = struct(User)
%User{city:  #Ecto.Association.NotLoaded<association :city is not loaded>, country: #Ecto.Association.NotLoaded<association :country is not loaded>}
user = Repo.preload(user, [:city, :country])
%User{city: nil, country: nil}
user = Repo.preload(user, [:city, :country])
** (UndefinedFunctionError) function nil.__struct__/0 is undefined or private
    nil.__struct__()
    (elixir) lib/enum.ex:1255: Enum."-map/2-lists^map/1-0-"/2
user = Repo.preload(user, [:city])
%User{city: nil, canton: nil}

Expected behavior
Repo.preload shouldn't try to preload through nils but set them to nil/[]
(This was probably broken in 483fa649dd2adc7afb49a44e0084ed2df794619a)

Thank you, fixed in v2.2 and master. A new release will be out in the next minutes.


Document Management Application

Merge

Changes Unknown when pulling 6b03bfad026f14473db4c3987aaa666cb1ad77a8 on develop into ** on master**.

Changes Unknown when pulling 0c895c1b474930f3e0648e31067c8f766f6b21c4 on develop into ** on master**.

Changes Unknown when pulling<PHONE_NUMBER>a6c434a9060b8e1246814b56574522 on develop into ** on master**.

Changes Unknown when pulling 28d58e9466c9ba67c5a0585bb924be0888fc6d22 on develop into ** on master**.


EDA vectorbase: enable

I think we need to add Vectorbase to the pass app in https://github.com/VEuPathDB/EdaDataService/blob/8ed5f9c225576c6075347db4d63b1b219a67d54a/src/main/java/org/veupathdb/service/eda/ds/metadata/AppsMetadata.java#L88

we want this in all genomic sites..  JB is asking fo r it in plasmo

Looks like vectorbase already has a project set up, so if you need i can add vectorbase to the pass app in the data service.
For plasmo, is there more to it than simply adding a new PLASMO_PROJECT = "PlasmoDB" in the data service? Does the whole project need to be set up or initialized somewhere with eda things?


Mat Menu doesn't respect angular typography

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Angular Material Typography should apply to the menu items in a mat menu
What is the current behavior?
Angular Typography doesn't get applied to mat menu items
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
https://stackblitz.com/edit/angular-zaxsjr
What is the use-case or motivation for changing an existing behavior?
Consistency/need to leverage typography for all things in site.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Current version (see stackblitz depedencies)
Is there anything else we should know?
I forked the most basic menu example from the angular material web site (https://material.angular.io/components/menu/overview) trying to figure out why my custom typography isn't being applied to the mat menu items in a mat menu.
Following the angular typography guide on the material website (https://material.angular.io/guide/typography), I created a custom typography config. I want to use that file to manage all typography for my entire site. According to the documentation, I need to us:
// Override typography for all Angular Material, including mat-base-typography and all components. @include angular-material-typography($custom-typography);
When doing this, it works fine. For simplicity sake, I have configured my typography file to just change the font-family to webdings font. If you look at the stackblitz provided, you can see that the mat menu label and other elements respect the typography. However, the menu items within mat menu do not.
Looking in the debugger, it make sense why it's not applying. The MatManu Component created the dropdown menu outside of the parent element. That class for the typography doesn't have the MatMenuItems in scope and therefore doesn't apply it.
Is there a workaround or a recommended approach to getting MatMenuItems to respect the typography?

This is covered under our "Multiple themes and overlay-based components" section of the docs. Here's a fork of your example that works correctly.

Perfect. THanks @crisbeto


feat(#228): files_in_repo for percentile filter

@yegor256 take a look, please
In this pull request, I've introduced method files_in_repo for aggregating a number of files in the repository, as required to filter out repositories by number of files using percentiles.
ref #228

@h1alexbel are you planning to count the files before cloning the repo?

@yegor256 yes, I planned to count them in the discovery phase. However, files count after cloning repository will make it more reasonable and remove the bottleneck with GitHub API in discovery-repos.rb.


Update secrets path

In a conversation with @alexellis  we saw an issue in Derek using the latest master version of openfaas.
failed to report status github.RepoStatus{State:"success", TargetURL:"http://<domain>:8080/function/alexellis-hallo", Description:"function successfully deployed as: alexellis-hallo", Context:"DEPLOY"}, error: unable to read private key path: /run/secrets/derek-private-key, error: open /run/secrets/derek-private-key: no such file or directory

This is due to openfaas/faas#692
Possible Solution

Update the path to search /var/openfaas/secrets

Thanks @rgee0 for working on this 👍

Marking as high priority due to need to enable testing for developers using newer OpenFaaS versions.

Derek close: Addressed in #69


Player arms tilted forward

Using this mod causes the player's arms to be tilted slightly forward.
Version: 1.19.2
Mods installed:
Pluckable arrows
Fabric Language Kotlin
Quilted Fabric API

Possibly caused by any of these

It's almost certainly this.


Fix: Kubelet restarts for vSphere CloudProvider

In vSphere CloudProvider, when node restarts, kubelet doesn't start. This PR fixes the same.

Where are the phase2 changes?

@colemickens they are in docker image "docker.io/ashivani/k8s-ignition:v4".  I just added dependency to docker.service in kubelet.service systemd unit file. Not sure if that will work for other cloudproviders, therefore didn't checked in.

Would you mind pushing a commit so we can look? It's likely that's necessary for Azure/GCE as well, since that is an OS-level config detail rather than cloud-level.
What OS are you using with vSphere phase1?

NP, will push the commit that includes this change. I am using Photon OS with vSphere phase1.

@mikedanese Can you remove the cla/google bot from this repo so I can merge this?

@kubernetes/sig-testing why is there still a google cla check on these?

We switched over to the linuxfoundation cla, right? @foxish probably need to update the required list

Fixed. It wasn't actually doing the check, but the status was still set to required for master.

Thanks, @spxtr


Fix tensorrt inference to take multiple boxes and points

Fix deployment/sam/tensorrt/inference.py and deployment/sam/tensorrt/inferencer.py

Hi xuanlinli17,
Thank you for bringing up the issue. We truly appreciate your efforts in helping us solve it!
After carefully reviewing your pull request, I noticed that there might be a misunderstanding regarding the input format of points. Specifically, for ONNX/TensorRT inference, the default image batch size is 1. As for args.point, it should be in the shape [B, N, 3], where B represents the number of output masks (not the image batch size), N denotes the number of prompt points you provide for each mask (pad the same point if it is smaller than N), and 3 refers to the coordinates and the label in format (x, y, label).
I have made the necessary updates to the code to address the issue. Your pull request is really helpful for my modifications. You can try it out whether it works for you now. Should you have any further questions, please don't hesitate to reach out. Once again, thank you for your valuable contribution!
Best,
Zhuoyang

It works! Thanks a lot!

Fix deployment/sam/tensorrt/inference.py and deployment/sam/tensorrt/inferencer.py

Hi thanks for your fix. Is there any tensorrt python inference code for Segmentation variant? If yes, would you please provide?


Fix Rock Head Crash

...this is a bug in Last Will, not in Rock Head. The Rock Head code is working correctly. Don't mess with it.

Please tell me you haven't screwed up any other good code this way, trying to fix Last Will...............

No, I havent...
I felt that this would be better instead of adding a mod, and I dont think it breaks anything

It literally just checks if effects exists instead of letting it cause an error in case it doesn't. While it's true only Last Will brought this up so far, it kind of can be considered a Rock Head bug.

@Nixola, I don't think you understand.
effect not existing is a bug, that should be fixed by not passing a nonexistent effect into the Damage event, not by checking for effect literally everywhere it's used, which would make the code a whole lot messier/slower.

In other words, the Damage handler signature is (damage: number, target: Pokemon, source: Pokemon, effect: Effect) => (damage: number | undefined | null | false)
effect should always be an Effect, not Effect | undefined. Passing an incorrect value into the event is a bug in the thing that passed it in, not the handler function.

This is the wrong approach because the crash isn't due to effect being null, it's due to activeMove being null.
This is because Last Will kind of causes a nested move execution, it does a new move while not being done executing the old one - recoil being an example of something that'd be done after the last will. If the last will move fails, then it sets activeMove to null.
What might work would be storing activeMove before the last will and re-setting it afterwards?

The correct solution seems to be doing the Last Will onAfterMove?

Wouldn't onAfterMove be called after the fainting, meaning the last will wouldn't have a valid source? There's also the issue of fainting for reasons not related to moves - weather, status, hazards, whatever. I think that limits it to onBeforeFaint?

All work. The last will already doesn't have a valid source, which is why we wrap the entire thing in a try block.

Hm, maybe on onAfterMove to cover moves, and then onAfterDamage for all non-move effects that might have fainted something.

Ok just tested, that works, @Spandamn do you want to it or should I make a PR?

@asgdf, make a PR.

Heh, so it turns out that by chance http://www.smogon.com/forums/posts/7333466 was right all along... I would never have guessed that activeMove was the problem though.

Me neither; I'm pretty sure PS supports nested moves because we do use it for move calling iirc.

Oh, it's because it's runMove and not useMove. Yes, you can't call runMove when an active move already exists; PS doesn't support that.

@Spandamn, so yeah, I hope you understand the problem now?

you can't call runMove when an active move already exists; PS doesn't support that.

Looks like Dancerability got lucky then?

Dancer calls runMove after the active move has resolved, it's written very carefully to work properly.

Dancer itself does, but Dancerability, the OM, doesn't, thus it got lucky.

Oh, yeah, probably.


webview not working on android version 4.x

i try open a url in my webview , but going to this message >> webpage not available
Screenshots/Videos:

Environment:

OS: win
OS version: 10
react-native version: 0.62.2
react-native-webview version:10.9.1

Crashes for me on 4.x as well. 5.x is fine.


[OSLogOptimization]  emitCodeForSymbolicValue should not attempt generating code for closures created by callers of os_log

Make emitCodeForSymbolicValue generate code for closures iff the closure is not created by the caller function where the code is generated. Otherwise, when the closure is created
by the caller, just reuse it after copying and extending its lifetime.
Before this change new closures were created as long as all captures of the closures were symbolic constants. This patch updates it so that even if all captures are symbolic constants no code is generated for closures that are already available in the caller. This avoids doing
needless work and also fixes the following bug, which arises because the emitCodeForSymbolicValue does not handle all possible constants (particularly, metatype constants) that are tracked by the constant evaluator .
rdar://problem/61465764

@swift-ci Please test and merge


chore: Add script to restore from aws codecommit (#148968)

Add Script to restore from repos from aws codecommit

https://pedigreetechnologies.tpondemand.com/entity/148968


add brute force search

to implement brute force function, as in going over all possible combinations and test them. Probably the function needs a stopping rule to avoid getting stuck on a nearly endless loop, for example for N>10. Goal is to implement then following function on utils:
static public int[] findStableMatchesUsingBruteForce(int[,] menPrefs, int[,] womenPrefs)


Issue locked but a better solution is now available

https://github.com/Microsoft/vscode/issues/12006#event-1166754547 has been locked "so solutions don't get buried". That probably seemed like a good idea at the time but there is actually a better, more legit solution now. Unfortunately that issue (which is now sub-optimal) is one of the first results in a Google search.
Cmder now has an official guide for integration with VS Code: https://github.com/cmderdev/cmder/wiki/Seamless-VS-Code-Integration
It works perfectly, and it uses Cmder's built-in init.bat instead of the user having to create a special file just for integration with VS Code.
It would be good if that issue can be reopened so this information can be added. I doubt too many people will comment after the link to the official guide has been posted.

Perfect. @Tyriar you have been assigned and were the one who locked it.  Good to see the universe is in balance.

@jazoom lol. Sorry about the delay, swamped in issue notifications 😱
I think the guide on our website might be a little more complete than cmder's because it has a workaround to set the CWD. But I'll update that issue with the new links 👍

5000 open issues and 50000 closed issues. 😱 is right.


OracleCoherence: Fix warnings while building image

Got the following warning while building the image:
"useradd: warning: the home directory already exists.
Not copying any file from skel directory into it."
This patch intends to fix it.
Signed-off-by: Dong Zhu<EMAIL_ADDRESS>

@thegridman can you take a look at this, please?

It was a warning, not an error. This just makes it neater.

hey @thegridman, are we good with merging this?

Yes, it should be good to merge


Horizontal lines glitch in editor selection (Edge)

#8229

Edge, open https://microsoft.github.io/monaco-editor/index.html
Select some text in editor -> notice horizontal lines in selection that have the color of the editor background (both in light and dark theme)

This has already been fixed for August


[IOS] AlertDialog on IOS don't have animation to avoid keyboard

Describe the bug
I'm using AlertDialog and having TextField inside it.
On Android when I focus the TextField, when keyboard appear, the AlertDialog's move up animation work perfectly, but on IOS there is no animation for that, and IOS don't have animation for appearing that AlertDialog
Another Problem with TextField, I have multiple TextField in Dialog, I'm focusing 1 TextField and select to another TextField, the keyboard of IOS auto closed and reopened, but in Android there is no problem.
Affected platforms
Select one of the platforms below:

iOS

Versions

Kotlin version*: 1.9.21
Compose Multiplatform version*: 1.6.0-beta01
OS version(s)* (required for Desktop and iOS issues): 17.2
OS architecture (x86 or arm64): arm64

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

Use AlertDialog
Add TextField to it
Focus TextField
Dialog don't have move up animation to avoid keyboard

Expected behavior
Dialog must have move up animation to avoid keyboard on IOS.
Keyboard don't reopen when change focus on another TextField

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Request for editing generated_map_object_locators

In my community they request for gfx/map/map_object_data/generated_map_object_locators_{type}.txt for initiate the location of generated_map_object_locators. In-game editor, though much more accurated, but are too hard.

It can be a supplement, such as gfx/map/map_object_data/generated_map_object_locators_{type}_ supplement.txt, it orginally came at there


Crash

https://bytebin.lucko.me/FV2jD0HOpC

this is caused by the fabric version using internal classes which changed in later fabric api version. since they are internal, those methods should not have been used and were not part of the exposed api (implementation classes not api classes)
you may be able to downgrade your fabric api version to fix this temporarily while the dev fixes it


Add missing functional header include at general_utility

Without this header when trying to build the engine from source it throws C2096: 'function': is not a member of 'std'.
After adding this it builds correctly.

@HKunogi  FYI #61, #62


Upload data error - HNN gui

I am new to this, so I hope not to waste too much of your time, and I am trying to use the hnn-gui to plot my own source localized data but I am encountering the following issues:

When trying to upload my data it gives me an error on window lenght (even if I changed the tstop and dt according to my data):
"ValueError: Window length too long: 15000.0 samples; data length is 2101 samples."

When creating the .txt file I followed the instructions on https://jonescompneurolab.github.io/hnn
-tutorials/starting_with_data/getting_started and it is not specified if I have to make sure to have a certain number of data to plot, and do I also have to upload external drives at the same time?

I can't delete the uploaded data, if I upload new ones it appears like I have 2 uploaded file at the same time (but still since there is an error, I think hnn is not reading any of them and just running the defoult simulation).

I can't exit hnn from anaconda, neither deactivate the environment, if I want to exit hnn then I have to shut off anaconda and turn it on again.

Thank you for your help,
Sara

The window length error makes me suspect it's trying to convolve your experimental current dipole data with a smoothing window or wavelet function. Any thoughts here @chenghuzi?

As discussed on email, the time column should be in milliseconds rather than seconds.


Drop shell.nix

Once https://github.com/arrterian/nix-env-selector/issues/53 is done.

https://github.com/srid/haskell-template/commit/57b31188f44e28b895adb75f5e69fd949c3a7bf4


Does not work on source files installed in ~/.idris2/

Does this require Idris to copy the .ipkg to work?

I think this requires Idris to install the .ttms.


DateRangeParam.isDateWithinRange(Date theDate) needs to account for intervals.

See #1645 / #1646
We're matching exactly but need to account for intervals such that
[parameter]=eq2019-12-30
would match
2019-12-30T18:28:17.500-05:00
See Other Notes section of spec here: https://www.hl7.org/fhir/search.html#date

Working branch: 1652-daterangeparam-isdatewithinrange-date-thedate--needs-to-account-for-intervals-

Pull request: #1653

See also related issue #1499.

This and the previous related changes in #1645 / #1646 are unnecessary. Rolling them back.
Doing this via commit instead of a revert to preserve the fixed typos. : )


Cannot read property 'message' of null

Issue Id: 79bf1bbb-c999-0dee-c637-8ed9f055dccbVersions - 1.28.0Stack TypeError: Cannot read property 'message' of null/vs/workbench/parts/tasks/electron-browser/task.contribution.ts#1329:31 (onError)/vs/base/common/winjs.base.js#1230:0 (_notify)/vs/base/common/winjs.base.js#916:0 (enter)/vs/base/common/winjs.base.js#1089:0 (_run)/vs/base/common/winjs.base.js#1062:0 (_error)/vs/base/common/winjs.base.js#758:0 (onError)/vs/base/common/winjs.base.js#1230:0 (_notify)/vs/base/common/winjs.base.js#916:0 (enter)/vs/base/common/winjs.base.js#1089:0 (_run)/vs/base/common/winjs.base.js#1062:0 (_actualErr)/vs/workbench/services/extensions/node/lazyPromise.ts#72:8 (resolveErr)/vs/workbench/services/extensions/node/rpcProtocol.ts#422:15 (_receiveReplyErr)/vs/workbench/services/extensions/node/rpcProtocol.ts#323:9 (score)/vs/base/parts/quickopen/common/quickOpenScorer.ts#434:27

Fixed.


NgbButtons don't show active state

The yellow active state is no longer visible for ngb-buttons.
https://design-system.post.ch/#/ng-bootstrap-samples/buttons

Checkbox and Radio buttons are no longer a part of ng-bootstrap since version 13.0.0.


Change DefaultApiConventions

Introduce attributes for matching by name and type.

Move discovery of ApiConventionAttribute to ApiBehaviorApplicationModelProvider. This is required
for us to detect during startup if the convention is incorrectly authored.

🆙 📅


order by size does not consider the unit

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.24.1
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20220510.2
Platform
Windows
OS Version
No response
Bug Description

the order by size only consider the number without unit.
Steps to Reproduce
order by size
Actual Experience
cannot find the biggest one immediately.
Expected Experience
No response
Additional Context
No response

The same folder in v1.23.0 of the explorer sorts properly. It appears as though the units are Megabytes and not Mebibytes

I see the bug now. We are trying to parseInt from the number string including the units. A number string "1.4 MiB" will become 1 after parse int causing it to appear smaller than "8 B" whose parse result is 8.

We will switch to use a new implementation of File Explorer which will have this issue fixed.

This bug has been fixed in our 1.25.0 release.


net/http: ServeContent for a directory unexpectedly closes the socket

Using http's ServeContent, a GET on a directory opened by os.Open unexpectedly closes the socket. The Content-Length header contains a non-zero size but then not a single byte is written in the HTTP body.
This is because a directory opened with os.Open seeks to a positive size but fails when read. I report this as an issue for net/http, instead os, since I am not sure if this is allowed behaviour for a directory. For HTTP, reporting a non-zero Content-Length with an empty body during GET in my understanding isn't.
How to reproduce this issue
GET a directory served by http.ServeContent on a real filesystem:
$ curl -i http://localhost:8080/
HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-Length: 68
Content-Type: text/plain; charset=utf-8
Last-Modified: Thu, 19 Mar 2015 07:57:56 GMT
Date: Thu, 19 Mar 2015 07:57:56 GMT

curl: (18) transfer closed with 68 bytes remaining to read

Source: https://play.golang.org/p/Tm5SPq9uag
$ go version
go version devel +ecd630d Wed Mar 18 00:59:49 2015 +0000 darwin/amd64

Same for Go 1.4.1 and 1.4.2 on OS X and Linux.
Demo that a directory seeks to a positive size but fails when read
seekdir.go seeks a directory, rewinds and tries to read:
$ go run seekdir.go
seekSize: 374
2015/03/19 09:09:29 read /tmp: is a directory
exit status 1

Source: https://play.golang.org/p/aeJkT4OsPV
How to fix this
Unfortunately I couldn't come up with a good solution. In my understanding, http.ServeContent is fine.
I had hoped that inspecting the return values of CopyN in fs.go line 257 for zero or error would help. But at this point, one can't rewrite the Content-Length header.
If a directory should remain seekable but not readable, a workaround in ServeContent could be to try to read the first n bytes in a buffer before calling WriteHeader.

I'm inclined to do nothing here. It's the caller's fault for passing bogus values to ServeContent.
I don't see the value in hiding the problem.
Please argue if I'm missing the point.

No need to argue, I agree (but had hoped to see this fixed here). I'll check back with Nigel Tao if he wants to work around this in net/webdav. Thanks.


Cleanup : Unify group type check in ResourceMapper extractField method.

Describe the Issue
Unify group type check which currently present twice in extractField method.
Review Comment
i think this needs a bit of cleanup. line 233 and line 260 both check if the item is a group. can this logic be unified rather than scatted around in different places?
https://github.com/google/android-fhir/pull/676/files#r713841089
Would you like to work on the issue?

Working on it.


Support Pascal Syntax highlighting

lapce dont know what pascal is

https://github.com/Isopod/tree-sitter-pascal

Added to #272


Minimal viable library imports

MVP library imports
If we want to start putting things like keccak256 behind imports so that one has to write from std.crypto import keccak256 I believe we can with something pretty simple.

Maintain a hashmap of builtin functions and their paths (e.g. `"keccak256" => "std.crypto")
Validate imports against such hashmap
Put imported functions onto module scope
On usage site (e.g. keccak256(some_val) validate that keccak256 is brought into module scope
Ensure imported functions are placed into runtime functions

This would be ignoring a lot of the complexities that come with proper imports but should be enough to introduce imports for builtin methods so that we don't have to pollute the global namespace.

We have a module system now


E2E test of issue #8785: Undefined when reading getUpdated

Motivation and context

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features

Introduced a new end-to-end test for job metadata consistency after frame deletion.

Bug Fixes

Validated behavior when saving a job after frame deletion, ensuring proper error handling and recovery.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.91%. Comparing base (54534e8) to head (3099ab4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8843      +/-   ##
===========================================
+ Coverage    73.88%   73.91%   +0.02%
===========================================
  Files          408      408
  Lines        44086    44086
  Branches      3986     3986
===========================================
+ Hits         32575    32588      +13
+ Misses       11511    11498      -13

Components
Coverage Δ

cvat-ui
78.44% <ø> (+0.06%)
:arrow_up:

cvat-server
70.06% <ø> (ø)


run_microbenchmark.py should use bazel

Followup for https://github.com/grpc/grpc/pull/23813
The PR actually broke the grpc_performance_profile_master and grpc_performance_profile_daily jobs on master.
The fix is to make sure run_microbenchmark.py uses bazel for building the microbenchmarks.

Broken jobs links:
https://source.cloud.google.com/results/invocations/8664de19-7476-4380-bb22-f211b16109ac/targets
https://source.cloud.google.com/results/invocations/a86462f0-8e70-40aa-9263-da1c90fca6f8/targets

Adhoc runs of the two jobs on master:
https://sponge2.corp.google.com/34fd3e67-dbe4-4a00-a1d6-f97c96ff64e9
https://sponge2.corp.google.com/10997104-999c-4f44-8a59-37bbfbb47d37

Both adhoc jobs have passed, so this seems to be fixing the tests on master as intended.
I don't understand the details of the outputs of the "profile" jobs, but since the only changes I've made was to change the build from make to bazel and the build is passing, I'm assuming the outputs still make sense.
@vjpai  feel free to take a look at the outputs of the adhoc runs and check if the results are making sense (I'm actually not sure if this data is still being used for something to be honest).

CC @yashykt  who's the build nurse for this week.


One app to rule them all

GitHub Issue: https://github.com/Islandora/documentation/issues/731
What does this Pull Request do?
Moves Alpaca from an OSGI bundle to a single runnable jar with all the various services inside.
What's new?

Removes OSGI bindings

Pulls SparqlUpdateProcessors in from fcrepo-camel code (it was causing problems with Jena libraries otherwise)

Create single runnable jar that takes configuration from a properties file.

Does this change require documentation to be updated? Docs are updated

Does this change add any new dependencies? No

Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? No

Could this change impact execution of existing code? Deployment will need to be altered.

How should this be tested?
Using a playbook or ISLE instance, build the jar and then copy it into the system (somewhere it can access Fedora, Blazegraph, ActiveMQ, the microservices).
Shutdown Karaf and copy the settings from all the various configuration files to a single properties file.
Start the jar with that properties file and it should perform all the various actions.
ie.
java -jar islandora-alpaca-app-2.0.0-all.jar -c config.properties

Additional Notes:
There are some stacktraces thrown that I left in place but are not actually a problem (for instance when you choose a media file, Drupal triggers us to send an event but it doesn't have all the necessary URLs yet. It can be ignored but could also be a sign of a problem.
Could leave the less verbose in the INFO level and move the stacktrace to the DEBUG logging level, but I don't want anyone to miss an actual problem. 🤷
Interested parties
@Islandora/8-x-committers (especially those you don't hate Java or at least will do Java, @dannylamb, @elizoller, @adam-vessey, etc)

Sorry for the delay on this, I have reverted the URL changes and then I had to work out a way of testing as the old way did not seem to work.

@whikloj Sorry, I'm about to show how little I understand Alpaca and this pull request but is it possible to have gradle do the "build the jar and then copy it into the system (somewhere it can access Fedora, Blazegraph, ActiveMQ, the microservices)."?

Ok there are still 2 PMD rule issues we need to make a decision about, but otherwise they are cleaned up.
@DonRichards once Alpaca is finalized we can deploy a build jar to Maven and Github then people deploying it can just download the pre-built jar instead of having to compile it themselves.

So, did realize something with the concurrent consumer stuff: It wouldn't really allow multiprocessing without the additional asyncConsumer parameter... throwing together another little PR to introduce it:  https://github.com/whikloj/Alpaca/pull/2

So I think it depends on what you mean by multiprocessing. For instance in our Islandora Legacy I use camel to kick off tesseract, it will run concurrentConsumers equal to the number of cores - 1, but each message is processed completely before the a new one is started. I'm not against the PR for including asyncConsumer, I'm just not completely clear how it decides when to grab a new item to start processing. Perhaps this is where the difference between concurrentConsumers and maxConcurrentConsumers` comes in?

Possibly... my interpretation of concurrentConsumers vs maxConcurrentConsumers is somewhat analogous to the -Xms and -Xmx values to the JVM... initial value when starting, and the max to which things can grow if called for.
Without asyncConsumer, it seems like only a single thing for each queue can be processed at a time (per instance of consumers listening, anyway... as in, running multiple instances of the jar could allow for multiple, in a round-about way), but that said... and it's entirely possible that I'm missing something, but given how it's described, I'm not sure of the value of being able to specify concurrentConsumers without also specifying asyncConsumer=true offers much... maybe a alleviating some amount of overhead?

I think we are in somewhat agreement, the only difference (I think) is that I now believe that without asyncConsumers the concurrentConsumers would never rise from its initial value and maxConcurrentConsumers might be irrelevant.
I do know that you can set concurrentConsumers to a number greater than 1 and have multiple messages processed at the same time. Async is (I think) that once the message has been pulled from the JMS queue and handed off (maybe just to the route or maybe to a secondary route) then a new message is grabbed from the JMS queue. In normal processing it would wait until the first message completed the entire route.
I'll give your PR a build today and I have no issue adding it as a configurable option.

Hmm... yeah, giving things a further poke, and seeing multiple convert instances at a time, from Houdini; however... I wonder... is it because of the streaming? Not really familiar with Camel's lifecycle WRT JMS messages... wondering if it's more, when the to() gets a response, that it would acknowledge the message (removing from the queue, allowing another thing to be handled), even though it's not quite done of the message?

Yeah I think that is why they don't guarantee the order if you use asyncConsumers. If you have a route like
from("input")
.to("processing")
.to("output");

and queue with
A, B, C

with a single consumer but asyncConsumers=true then depending on how long each thing takes in processing the output endpoint could see A, C, B, C, A, B or C, B, A...

Since... I've now got code in this, I'm not really supposed to merge it, so... yeah... but I would if I could. :P

Yeah we'll have to drag some other @Islandora/8-x-committers in to this

@whikloj / @adam-vessey  - do you want me to give it another round of smoke tests?

Great job @whikloj and @adam-vessey for working through this!

sounds like @alxp already got to it here: https://github.com/Islandora-Devops/islandora-playbook/pull/208#issuecomment-988931232

@elizoller if you're able to have a look, please do.

Thank you all for seeing this through. I'm going to try and release it, see how that goes.


Error: exec: "xdg-open": executable file not found in $PATH

In WSL2, I don't have a GUI environment or browser, so it fails when trying to show the generated HTML.
I found out I can specify the --no-browser-open flag to bypass this behavior, but it only prints the HTML path in the temp folder because the file is always saved.
Maybe it always should print the HTML path, no matter if the flag is specified or not?

If the open succeeded, there's no much value in printing the path, but if the open failed, it would be wise to print the path instead, it can redirect the open error to stderr and the HTML path to stdout so that users can use it.

it only prints the HTML path in the temp folder because the file is always saved.

I though about this while doing it, and it might be wiser to redirect the the HTML output itself to stdout rather than automatically dump it in a file. Something like:
dep-tree my/project/entrypoint --no-browser-open > ~/my-html-file.html

That way users have a more flexible way of dumping the file wherever they want to.


Implement connection reuse

Vaultenv currently opens a new connection for every request it sends. This causes an unnecessarily heavy load on the receiving Vault server as every request requires a new TCP socket and potentially a TLS handshake. We can avoid this by reusing connections using Connection: keepalive.
As far as I can tell, the Network.HTTP.Client has support for this and we just don't use it yet. The requests are also missing the required Connection header.

The single shared HTTP manager should already ensure that connections are reused where possible, as connection reuse is a property of the Manager it seems.
But the reason why it's not happening in practice might be that we send all of the requests in parallel:
https://github.com/channable/vaultenv/blob/fe8ccad1e4f50710e53749f901ca3812cd6bd61f/app/Main.hs#L430-L431
Apparently, mapConcurrently performs all actions concurrently, so maybe just limiting that to a maximum of n concurrent requests (where n is significantly lower than the total amount of secrets to fetch) would help.

That's part of the mystery and it also helps to explain why loading certain secrets file is such a heavy load. However, if I intercept the request headers of a HTTP request from vaultenv, I still don't see the correct Connection header:
# In one terminal
nc -l 9001

# In another:
VAULT_ADDR=http://localhost:9001 vaultenv true

# Shown in the nc terminal
GET /v1/sys/mounts HTTP/1.1
Host: localhost:9001
Accept-Encoding: gzip
x-vault-request: true
x-vault-token: REDACTED

If connection reuse was enabled, I'd expect to see a Connection: keep-alive header.

If connection reuse was enabled, I'd expect to see a Connection: keep-alive header.

According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection, "having a persistent connection is the default on HTTP/1.1 requests", so I'd assume that's not a requirement.


Android Chrome

Android Chrome will only scroll skrollr elements. The rest of the page doesn't respond to the scroll.
This only occurs in Android Chrome and no other desktop or mobile browser.

I'm reproducing in iOS Safari. Any ideas what's going on?

I'm having the same issue.

I've managed to sort my issue out, I moved the content that was above the skrollr-body previously inside it and removed forceHeight:false - it seems to be working now.

Any ideas what's going on?

not without a demo/example page

I removed forceHeight:false and it works for me now. This is pretty critical to skrollr not working in iOS.

I'm also having this issue. You can see the issue at http://cellularadvantage.webspec.org on Android at least Chrome and Firefox. It also reproduces using Chrome mobile emulation when navigating via click-and-drag but not scroll wheel.

Codepen - http://codepen.io/ethanclevenger91/full/WbVOoO
On a desktop, I can scroll down the page just fine and Skrollr behaves as expected. Open that on mobile (tested in Android 4.4.2 with Chrome 41) and you can't scroll down the page, though skrollr will still fire its events.

@ethanclevenger91 I don't see a skrollr-body in your codepen

Ah, yep. Went ahead and fixed that, thanks. Though I still have an issue - if you get to scrolling on mobile before skrollr has loaded, you end up with whitespace on the bottom that seems to be equal to as far as you've scrolled, and then that much of the top can't get scrolled back to. I tried adding $(window).scrollTop(0) before the call but it doesn't seem to be helping. Let me know if anything strikes you off the bat as wonky.

I'm having the same problem as you just described, @ethanclevenger91.
Here's the site: http://www.wassersportcenter-berlin.de
As it was stated already: If I scroll down on mobile (Android Chrome, iOS Safari) before Skrollr is loaded, the site cannot be scrolled to the top anymore - instead it now "starts" in the middle of the page (the spot I reached before Skrollr was loaded) and extends the page on the bottom. Is there any way to avoid that?

I did not come up with a solution. Hopefully we get a response. I'll tinker with the Codepen maybe this weekend to emulate the issue so that they've got a test case.

I can reproduce it with the codepen but I haven't looked into it. skrollr already does compensate for scrolling happening before initialization (http://codepen.io/ethanclevenger91/full/WbVOoO).
Could it be a codepen issue? I mean, it's using an iframe. Please create a codepen-less demo.

Same as the CodePen, but served natively.


Update README to remove MyRedis.

The service has since been shut down. http://www.joshuakehn.com/2013/7/21/myredis-fiasco-aka-avoid-hosted-databases.html

Crazy drama. Had no idea about this.


CPU optimizations

This PR is changes from https://github.com/dmlc/xgboost/pull/4278 without pre-processing optimizations (it has been merged yet https://github.com/dmlc/xgboost/pull/4310)
In addition I refactored the code to make it simple. In previews version I used omp tasks, but they are not supported in MSVS by default, so I replaced them by simple omp parallel for.
Code changes looks massive, but it is hard to split them on small parts.

It seems this is based on a old commit.  Is it possible to make a clean rebase?

I'll review this pull request after the 0.90 release

@SmirnovEgorRu Looks like this pull request is breaking some distributed training tests: https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/PR-4433/7/pipeline#step-145-log-581

@hcho3 Yes, now I want to understand how distributed mode works. Do we have some materials about this?
Potentially, my changes should optimize distributed mode too, but need to change code.

@SmirnovEgorRu The XGBoost paper have some details about distributed training. Roughly speaking, every occurrence of AllReduce causes synchronization of all nodes

Let me look at this over the weekend

Hi, @SmirnovEgorRu @hcho3 @RAMitchell  I want to revert part of #4310 .  That PR improved performance by allocating buffer, specifically:
https://github.com/dmlc/xgboost/blob/8ddd2715eefa21555c77bbf1ac2ea314ac9f279e/src/common/hist_util.cc#L111
This makes it very hard to load sparse dataset. For example the first line of URL dataset from  #2326 has largest index 3224681.    And just for future reference, allocating memory based on feature index might not be a good idea.

@hcho3 , looks like all issues are resolved, including distributed mode.


⚠ Jenkins Plugins Artifactory has degraded performance

In 292df34, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1198 ms

Resolved: Jenkins Plugins Artifactory performance has improved in feb2380 after 12 minutes.


Create runelogger

Added new plugin. This plugin collects data from the player (for example level ups, duel results, quest completions) and stores and display them on runelogger.com.

You must add a warning to your plugin since it makes calls to external services.

I've added the warning to this commit.


Vanishing comments in markdown code blocks

In the oauth2 package's README, all lines but the first in block comments in the README seem to have vanished. I can't reproduce this with the markdown package alone, so I guess it must be something in the server?

This is a problem for all packages.
At the moment the pub-site use a custom version of markdown due to upstream patches were slow to land. This should have been fixed with the transfer of ownership of that package, so we can probably get rid of the custom version.
However the issue might of cause not be related to the custom version of markdown used.

This is same issue as #26


Cannot GET doesn't indicate why...

🚀 feature request
Relevant Package

 This feature request is for @angular/cli or compiler
Description

We had issued ng serve which was watching for changes.  On a dependency change to an internal angular library, which compiled ok... We received this message above.
Going back to the terminal window we saw this:
PS C:\Users\name\source\repos\J\mglib> ng serve demo

chunk {main} main.js, main.js.map (main) 2.06 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 169 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.15 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 14 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 343 kB [initial] [rendered]
Date: 2020-06-24T13:51:46.683Z - Hash: 2091c10c953f6c16c475 - Time: 6335ms

 // this error was our fault, shouldn't this shown in the served page?
 ERROR in The target entry-point "lib" has missing dependencies:
 - projects/MG/src/mg/services/signalr.service

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

Clearly our fault but....
Here's the prod compile of our library.
File change detected. Starting incremental compilation...

------------------------------------------------------------------------------
Building entry point 'lib'
------------------------------------------------------------------------------
Compiling TypeScript sources through ngc
Bundling to FESM2015
WARNING: 'OnInit' and 'AfterViewInit' are imported from external module '@angular/core' but never used
Bundling to FESM5
WARNING: '__read' is imported from external module 'tslib' but never used
WARNING: 'OnInit' and 'AfterViewInit' are imported from external module '@angular/core' but never used
Bundling to UMD
WARNING: No name was provided for external module '@fortawesome/free-solid-svg-icons' in output.globals – guessing 'freeSolidSvgIcons'dSvgIcons'                                                                                gularSvgIcons'
WARNING: No name was provided for external module '@fortawesome/free-regular-svg-icons' in output.globals – guessing 'freeRe 'signalr_service'gularSvgIcons'                                                                                ntawesome'
WARNING: No name was provided for external module 'projects/MG/src/mg/services/signalr.service' in output.globals – guessing 'signalr_service'
WARNING: No name was provided for external module '@fortawesome/angular-fontawesome' in output.globals – guessing 'angularFontawesome'
WARNING: No name was provided for external module '@aspnet/signalr' in output.globals – guessing 'signalr'
Minifying UMD bundle
Writing package metadata
Built lib

------------------------------------------------------------------------------
Built Angular Package
 - from: C:\Users\myName\source\repos\John-Peters\mglib\projects\MG
 - to:   C:\Users\myName\source\repos\John-Peters\mglib\dist\lib
------------------------------------------------------------------------------

Compilation complete. Watching for file changes...

Describe the solution you'd like

It's ok to serve the page, but show the error instead of cannot get.
We don't understand how ng build --prod did not catch this error.

Describe alternatives you've considered
 Fix the library dependeny issue.

Duplicate of https://github.com/angular/angular-cli/issues/17487


WIP Add get_tile_rectangle_by_id

This is still a work in progress
Helper function for #35
This method return the rectangle where the sprite is located on the image texture.
I tested the math with a few tilesheets (with and without margin/spacings). Seems fine, but I'm not 100% sure!
The rendering code looks like this(using tetra):
for layer in map.layers.iter() {
    let tile_width = map.tile_width as f32;
    let tile_height = map.tile_height as f32;
    let texture = ...

    for (j, row) in layer.tiles.iter().enumerate() {
        for (i, tile) in row.iter().enumerate() {
            if tile.gid == 0 {
                continue;
            }
            let p = Vec2::new(i as f32 * tile_width, j as f32 * tile_height);
            let rect = self.map.get_tile_rect_by_id(tile.gid);

            graphics::draw(ctx, texture, DrawParams::default().position(p).clip(rect));
        }
    }
}

Since this is still a work in progress, I'll label it as a draft.

There has not been any progress in this PR for more than a year, so I'll close it. If it gets an update I'll reopen it.


Transaction: "Review transaction" modal

From reqs:

Show a “Review transaction” view after selecting the amount(s) and token(s) to shield, which highlights shielding fee.

UI inspo from uniswap

UI inspo from uniswap

Screenshot for reference


Sync .swift-version as 5.0

Package.swift indicates that we are using swift 5.0, but .swift-version is 4.2.

thanks!


2.0 beta's "zero_output_for_mask" produces unexpected zero-filling behaviors for GRU, LSTM.

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.2 LTS in GOOGLE COLAB
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: None
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.0.0-beta0-16-g1d91213fe7 2.0.0-beta1
Python version: Python 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: CUDA Version: 10.0
GPU model and memory: Tesla T4 (16G)

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
The call() methods of tf.keras.layers.GRU and others (e.g. LSTM) does not produce output as expected for "zero_output_for_mask"  when the layer is created with "return_sequences=True".
Regardless of the value "zero_output_for_mask", the result of call() fills zeros for masked timestamps.
Describe the expected behavior
It should produce outputs as the masked timestamps should be filled zeros if zero_output_for_mask is True. If false,  the masked timestamps should be filled with previous outputs.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf
import numpy as np

for zero_output_for_mask in [False, True]:
  #tf.keras.Sequential Model
  model = tf.keras.Sequential([
      tf.keras.layers.Embedding(16, 5, mask_zero=True),
      tf.keras.layers.GRU(5, return_sequences=True, zero_output_for_mask=zero_output_for_mask)
  ]
  )

  model.compile(
      optimizer='rmsprop',
      loss='mse'
      )

  np_x = np.ones((2, 5), dtype=np.float32)

  # masking timestamp 3,4 of sample index 1.
  np_x[1, 3:] = 0
  #print(np_x)

  # model's call()
  result_mask_call = model(np_x)

  print("---- zero_output_for_mask is {} ------".format(zero_output_for_mask))
  print(result_mask_call[1,:].numpy())

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
I suspect that tf2.0 alpha's GRU's call() is changed in tf2.0 beta version.
PLEASE refer FINAL line of both snippets.
beta version snippet of GRU's call() in recurrent_v2.py
  def call(self, inputs, mask=None, training=None, initial_state=None):
    # GRU does not support constants. Ignore it during process.
    inputs, initial_state, _ = self._process_inputs(inputs, initial_state, None)

    if isinstance(mask, list):
      mask = mask[0]

    input_shape = K.int_shape(inputs)
    timesteps = input_shape[0] if self.time_major else input_shape[1]

    if not self.could_use_cudnn:

alpha version snippet of GRU's call() in recurrent.py (UnifiedGRU)
  def call(self, inputs, mask=None, training=None, initial_state=None):
    # GRU does not support constants. Ignore it during process.
    inputs, initial_state, _ = self._process_inputs(inputs, initial_state, None)

    if isinstance(mask, list):
      mask = mask[0]

    input_shape = K.int_shape(inputs)
    timesteps = input_shape[0] if self.time_major else input_shape[1]

    if mask is not None or not self.could_use_cudnn:

@jangmino Please provide us the error log. And also provide us the complete code to replicate the issue on our environment. Thanks!

@jangmino Please provide us the error log. And also provide us the complete code to replicate the issue on our environment. Thanks!

I downloaded my colab file as ipynb and packed as zip file.
There was no error but only UNEXPECTED output.
You can watch the output by running my colab.
Reproducing_Code_Unexpected_zero_filling_behaviors_for__zero_ouputput_for_mask__[TF_2_0_beta].zip

I was able to reproduce the reported issue on Colab with tensorflow-gpu 2.0.0.beta1.Thanks!

@jangmino Could you check whether the issue with latest TF. I ran your code with !pip install tf-nightly-gpu-2.0-preview. Here is the gist.
Please close the issue if you think the issue was resolved. Thanks

Automatically closing this out since I understand it to be resolved, but please let me know if I'm mistaken.Thanks!


Flesh out README a bit more.

[x] Add more information to the summary section.  I'd like to generally explain what we are doing (e.g. creating a diff between the ember-cli blueprint output of the --from version to the --to version, and then applying that diff to their project).
[x] Explain the end / conflict workflow (aka lots of links about git mergetool).
[x] Update error message (and link back to our README?) for dirty working directory (see https://github.com/kellyselden/ember-cli-update/issues/64).

FYI - I added the following to the list in the description:

Update error message (and link back to our README?) for dirty working directory (see https://github.com/kellyselden/ember-cli-update/issues/64).

I think everything is covered here.


Getting data from lazy loaded child component doesn't work

Is this a regression?
No
Description

Set data in your lazy loaded route:

Subscribe to data changes:

If you run the application, logged data will be empty object: {}
It seems that lastRouterState is never updated in this case.

Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
@ngneat/elf-ng-router-store: 1.0.4

Anything else?
No response
Do you want to create a pull request?
No

Did you read the section about lazy loaded modules in the readme?

If you mean, if I have set paramsInheritanceStrategy: 'always', then yes, I have set it.


[ADAM-1463] Rename recalibateBaseQualities method as recalibrateBaseQualities

Fixes #1463

Coverage decreased (-0.02%) to 81.569% when pulling 9a54478e3693489c7aa764726d8b7ee80750baf8 on heuermh:recalibate into 462db97d9b2ba89f715c0856f36c3803346312e8 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1923/
Test PASSed.

Merged! Thanks @heuermh!


The claim of 100% mutation coverage is no longer holds true

bundle exec mutant -Ilib -rasset_packer --use rspec 'AssetPacker*':
Mutant configuration:
Matcher:         #<Mutant::Matcher::Config match_expressions: [AssetPacker*]>
Integration:     Mutant::Integration::Rspec
Expect Coverage: 100.00%
Jobs:            2
Includes:        ["lib"]
Requires:        ["asset_packer"]
Subjects:        16
Mutations:       1205
Kills:           998
Alive:           207
Runtime:         111.06s
Killtime:        63.75s
Overhead:        74.22%
Coverage:        82.82%
Expected:        100.00%

Also, the rake task seems to be broken for the latest mutant(0.8.7):
➜  asset_packer git:(master) ✗ bundle exec rake mutant
invalid option: --score
rake aborted!

/home/ch1c0t/sources/ruby/aliens/asset_packer/Rakefile:14:in `block in <top (required)>'
Tasks: TOP => mutant
(See full trace by running task with --trace)

Hi @ch1c0t , thanks for reporting. I haven't looked at asset_packer for a while, it might be in a somewhat broken state at the moment. Are you using it (or Slippery, which is the main reason asset_packer exists) for anything?

Hi, @plexus. I only use it to experiment with mutant. Thank you for the article.


too many values to unpack (expected 2)

I'm getting an error during running the infer.py:ValueError: too many values to unpack (expected 2)
This error occurs at line 53 of onnx_runner/lightglue.py。Can you help me with the answer

Hi @czy-1234, thank you for your interest in LightGlue-ONNX.
It seems that you are using a model version <1.0.0, but your version of infer.py is >=1.0.0. Please checkout the corresponding release tag.


Get test coverage back up to 100%

Test coverage is currently at 96%, ideally we'd be at 100% 😄.

It can help to set a strictness on files: https://github.com/nedbat/coveragepy/issues/691 - There's a script on this issue that can be used for it.

A note from working on this a bit: in order to effectively cover these lines:
https://github.com/pydantic/pydantic/blob/b7d92817ac2223237b5d341227de3eff7a84b350/pydantic/_internal/_typing_extra.py#L170-L172
https://github.com/pydantic/pydantic/blob/b7d92817ac2223237b5d341227de3eff7a84b350/pydantic/_internal/_model_construction.py#L587-L588
You need to create a model class in the initial stack frame, i.e. in the actual __main__ module. This might be possible while still using pytest and the coverage CLI by invoking a subprocess but it'll probably be messy. The simplest approach might be to run a script separately from the other tests, call the coverage API directly from within the script, and then construct the model.

I'm at PyCon US 2024 and am working on increasing the test coverage of the fields module.

Now, I will work on the test coverage of the types module.

Hi @sydney-runkle, folks,
I am trying to add a tiny case to increase coverage, but I've stopped because I do see[^1] a huge difference in coverage of
Name                                              Stmts   Miss Branch BrPart   Cover
------------------------------------------------------------------------------------
pydantic\mypy.py                                    593    587    315      0   0.88%
------------------------------------------------------------------------------------
TOTAL                                              9255    854   4086    189  89.58%

compared to coverage shown at https://smokeshow.helpmanual.io/1z3s4a3o5l1i1b365u0t/ (90.97%).
Can anyone reproduce or explain the issue?
Thank you :)
pydantic version: 2.8.0a1
        pydantic-core version: 2.19.0
          pydantic-core build: profile=release pgo=true
               python version: 3.12.4 (tags/v3.12.4:8e8a4ba, Jun  6 2024, 19:30:16) [MSC v.1940 64 bit (AMD64)]
                     platform: Windows-11-10.0.22631-SP0
             related packages: mypy-1.1.1 pydantic-extra-types-2.8.0 pydantic-settings-2.2.1 typing_extensions-4.10.0
                       commit: c08dacde

[^1]: both running pdm run coverage report locally and make all (thus trying to reproduce the CI checks)

if I got it right, the coverage-combine's CI step is doing the trick. make test runs the tests unrelated to mypy (all skipped at first), make test-mypy runs the mypy ones (which are indeed slower) and coverage reports are eventually combined. So one would get the proof that the total coverage has increased after the push. Is this somewhat correct? Thank you!

Yep, you have to run the mypy tests separately. You should be able to do that locally as well.
As a side note, you might want to work on test coverage for tests that aren't mypy oriented, as they can get pretty difficult to write pretty quickly. You're welcome to take on the challenge though, if you'd like!
Feel free to ping me if you have any other questions.

Relevant opportunity for tests: https://github.com/pydantic/pydantic/pull/9183#issuecomment-2187670605
Idea for improving coverage and CI: https://github.com/pydantic/pydantic/pull/9740#issuecomment-2186698277


Remove loading text when scrolling to bottom

Currently when the user scrolls to the bottom of the page, a progress bar and text stating that the items are being loaded is present. The text stating that items are being loaded is unnecessary and adds clutter to the app design. Many other popular apps just use the progress bar with no text, which I feel is a lot cleaner and should be adopted by this app.
Another benefit (though less important) is maintenance of page loading strings in other languages is no longer needed as a progress bar is universally understood.

PocketHub
Instagram
Twitter
Facebook

Not much to say, sounds like a good idea. Feel free to do it.

I can submit PR for this @veyndan @Meisolsson
Let me know if I should start on it.

Sure go for it!


Update targeting and tracking tests

Would be useful if this branch made its way to master as it has better self checking of dates combinations the analytics can't handle and will save my time in future tracking down issues - I have chased this issue twice, hence the specific check and Exception thrown for poor user configuration of T&T dates

@PhilipTB what are the new date checks in this branch? Apart from changes to your test framework, I can see some refactoring of the open/close times and a new exception being thrown from the solar analysis. Am wondering what date combinations are being tested/handled here.

@PhilipTB what are the new date checks in this branch? Apart from changes to your test framework, I can see some refactoring of the open/close times and a new exception being thrown from the solar analysis. Am wondering what date combinations are being tested/handled here.

I think from recollection it was the circumstance where the first target date was before the 1st actual meter reading, something the analytics currently doesn't support and which has happened twice (Wimbledon being the second example) and which took me an hour or so to debug and then realised I had seen the problem before and it was probably better if I checked and threw an explicit exception.

Can you confirm that the expected changes are in this PR? The codes changes are:

some changes for your test harness, include a test for Wimbledon
catching an exception from statssample
a refactoring of how OpenCloseTimes is initialised

There's nothing relating to target start dates. And we don't want an exception for that, as in the revised approach it will be legal to do that.
Am really just checking all the expect changes are in the PR.


If available, ensure that Analytics' regions are "us" and "de" (not "eu")

We've recently discovered that at least one API client was exposing "eu" as a
valid region for the Analytics client implementation, which is wrong. Only the
following regions are available at the moment to the Analytics client:

"us"
"de"

For now we allow any string there.


Tests triggered even if labels are absent

@lsm5 reported two PRs first and second where packit triggered tests even though labels were absent (and the other way around in the first link).
Looking at the logs (for the second link) seems like we selected a job config even though the release label was present in the PR and the config required it absent:
[2024-12-10 12:59:08,265: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: [], label.absent: ['release'])
[2024-12-10 12:59:08,376: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: [], label.absent: ['release'])
[2024-12-10 12:59:08,537: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:08,545: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: ['release'], label.absent: [])
[2024-12-10 12:59:08,608: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:08,619: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: ['release'], label.absent: [])
[2024-12-10 12:59:08,732: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:08,744: DEBUG/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] Matching handlers: {<class 'packit_service.worker.handlers.copr.CoprBuildStartHandler'>}

[2024-12-10 12:59:08,764: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: [], label.absent: ['release'])
[2024-12-10 12:59:08,816: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:08,829: DEBUG/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] Matching handlers: {<class 'packit_service.worker.handlers.copr.CoprBuildStartHandler'>}

[2024-12-10 12:59:08,852: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: [], label.absent: ['release'])
[2024-12-10 12:59:08,950: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:08,960: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: ['release'], label.absent: [])
[2024-12-10 12:59:09,085: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:09,094: INFO/MainProcess] task.steve_jobs.process_message[f24cd144-3404-4bfa-97fa-2b4c4402ff6a] About to check whether PR labels in PR 24747 match to the labels configuration (label.present: ['release'], label.absent: [])
[2024-12-10 12:59:09,194: INFO/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7] Labels on PR: ['approved', 'do-not-merge/work-in-progress', 'release-note-none', 'release']
[2024-12-10 12:59:09,220: DEBUG/MainProcess] task.steve_jobs.process_message[e46e6af3-8c4d-4ded-8bba-a4a979c4e4b7]

But it could also be related with #2669 because it is the copr_build_start_handler to set the testing-farm check
[2024-12-10 12:59:37,272: DEBUG/MainProcess] task.run_copr_build_start_handler[db535663-3c37-470f-88d1-c57b275452c5] Setting Github status check 'in_progress' for check 'testing-farm:fedora-rawhide-aarch64:dev': RPM build is in progress...

@lsm5 reported two PRs first and second where packit triggered tests even though labels were absent (and the other way around in the first link).

In the latest run of https://github.com/containers/podman/pull/24369 I see now that the tests not meant to run are not run as intended, but simply listed. I guess it'd be great if we could hide the untriggered ones from the list entirely.


Sematic difference from Ruby : Syntax Suggestion

Going through the API I found these:
Array#[]? #=> may return nil
Array#[]  #=> fails if out of bounds

In Ruby the ? is a sign that a method returns a boolean. Contrast this with these methods from Rails:
Model#save   #=> returns false if not saved due to validations.
Model#save!  #=> fails loudly if not saved due to validations.

Semantically it makes more sense for these to be the methods in Crystal:
Array#[]   #=> may return nil
Array#[]!  #=> fails if out of bounds

This will keep it in line with the "meaning", the semantics of the Ruby API without changing any functionality. As Crystal is before v1 this would be the perfect time to do this breaking change.

@rebelwarrior that won't play nice with other parts of the std-lib design. It will force []! to be more common than [].
A related discussion can be found at #1034 to get into details of it.
I'm confident you won't find the current behavior disturbing at all. In Crystal Nil has a special treatment.

Hi and welcome!
This has been discussed to death in the past: https://github.com/crystal-lang/crystal/issues/1034
This is never going to change. Changing it will mean breaking all code out there. It would be really bad to do so right before 1.0.
@Blacksmoke16 and everyone: can we please stop using 👎 without giving a reason? Imagine you enter a forum or discussion, take the time to ask something, and immediately get a 👎 . How would you feel?

The TL;DR is that a ? suffix in crystal has dual meaning: it may mean that it returns nil (typically with a raising method without ?), or it may mean that it's a query method and returns a boolean (the same as ruby).
We find that in practice this is fairly unambiguous and works well.

The more differences there are with the say expectations set by Ruby the harder it is to port code and then more effort you have to put into watching the gotchas of the Crystal language like include? vs includes?
While this is fine the cost should not be tossed away because it would cause a breaking change. In a pre-v1 is the time to massively change the language to experiment to try new things and see how they work.
This would not be a terribly difficult thing to change either. First you'd alias []! to [] so people can change the code leisurely then warn of the change to [] and deprecation of []? Then complete the swap. It takes a few versions but the first is not a breaking change as it adds an alias.
The reason I'm proposing this is not cause I have a hard time learning a new API or that []? is difficult. Not at all. It just that it introduces two unexpected changes:

doesn't return a boolean
2 . doesn't follow the behavior of [] which return nil in Ruby.

I'd feel remiss if I didn't at least state my case. It's inevitable that crystal will differ from Ruby syntax as they are different languages but they more they can follow the same "language expectations" the more synergy you get between them. The includes? include? change makes semantic sense. So it's a pain but a pain with a purpose.
This change just introduces a new semantic rule ? can return nil or the normal value in addition to being a sign the method returns a boolean, while the ! is already established as a fail rather than return nil symbol, at least, in Rails.
Thanks to all who explained your perspectives so kindly especially RX14 & asterite

This change just introduces a new semantic rule ? can return nil or the normal value in addition to being

This semantic rule is considered idiomatic in Crystal and used in many places, not just for Hash/Array accessors. Since Crystal has static type checking and special Nil type handling, it's necessary to be more specific with these things than Ruby. So there are essentially two alternative sets of methods:

foo? is nilable and foo is non-nilable (raises)
foo is nilable and foo! is non-nilable (raises)

Both are actually used in Crystal and it depends on the specific use case. No. 1 is used if the typical use case of the method expects it to usually work and return a value, and if not raise a meaningful error message. No. 2 is used if the method's success is optional and not having an actual return value in expectd to be normal behaviour.
In both cases there's always a different method (with ! or ?) suffix that provides the alternate behaviour if necessary. But the suffix-free method is always used as the default behaviour and varies between nilable and raising depending on the use case.
For hash/array accessors, you would usually expect to get a value and not have to deal with nilable return types. That's why the main method without suffix raises if the key is not found.
A related reason is the special meaning of Nil to designate a missing key doesn't work if the collection may contain Nil values. When calling hash["foo"] on a Hash(String, String?) returns nil, there's no way to know whether nil is the actual value for "foo" or it indicates that key doesn't exist. Such an ambiguity should be avoided in the default accessor, hence it raises in the latter case. You can use []? to get a nilable return value, but this might not make sense when the values are nilable (in that case you need to use #fetch(key, &) which yields on missing key).


Cocoapods bug

Hello, I can't install the library with cocoa pods:
pod install
Analyzing dependencies
[!] Unable to find a specification for `SwiftInstagram (~> 1.0.4)`

Hi @MarcoCarnevali,
It seems that your local Cocoapods repo is outdated. Try to run the following command and then try again:
pod repo update


front camera do not have zoom ?

Zoom was for some reason disabled for the front camera - had to manually alter the code to get it to work again

Did you find a solution ? Need too

@aurora14 Could you post your solution to this? Would really appreciate it!

@aurora14  could you please post your solution I was unable to zoom both in front and back camera also


Hololens status page

Docs Build status updates of commit 727722d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/hololens-status.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#donotmerge

Docs Build status updates of commit 99c988a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/hololens-status.md
:warning:Warning
View
Details

mixed-reality-docs/hololens-status.md

Line 4: [Warning] Invalid value for author: 'todmccoy; Teresa-Motiv' is not a valid GitHub ID

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4874e94:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/hololens-status.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3210be3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/hololens-status.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

apparent PR error; recreating


fix regional-mom6 link in docs/index.rst

fix md-style link in rst file.
(why are the doc files a mix of md and rst?)

for historical reasons: @angus-g started it with rat but I'm more comfortable with Markdown, so that's why...
we should homogenize it at some point, but it's low priority...


ARROW-8193: [C++] Fix gcc 4.8 compilation error with non-copyable types in Iterator::ToVector

This fixes the failure for me in arrow/util/future_test.cc.

cc @bkietz, it seems that copy elision to the move-based constructor for Result doesn't work right in gcc 4.8, though maybe the problem is something else

Test failure is unrelated.


[BEAM-2033] Add HadoopResourceId

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[X] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[X] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[X] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[X] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Based on https://github.com/apache/beam/pull/2671 - now with more licenses! Also a serializable HadoopResourceId.
We'd like this to go into a new feature branch.
R: @tgroh

Is the proper way to do this to have you create the feature branch separately, and then mark the PR as going into that other branch? (or are you going to have to manually choose the branch anyway when you do the merge?)

Changes Unknown when pulling c1e6cbcf2360c43b93a33acd65f45204e3c34869 on ssisk:hfs-pre-req into ** on apache:master**.


Develop upstream sync 210802

jenkins: retest Ubuntu-sanity please

jenkins: retest Ubuntu-sanity please

jenkins: retest Ubuntu-CPU please

jenkins: retest Ubuntu-GPU-single please

jenkins: retest Ubuntu-GPU-multi please


Building redistributable only on x86_64 and updating golang version to 1.13

We dont need redistributable package building
on multiple architectures as it is happening right
now (case in point internal scratch build)
Eg:

openshift-odo-redistributable-1.2.3-1.el8.s390x.rpm
openshift-odo-redistributable-1.2.3-1.el8.ppc64le.rpm
openshift-odo-redistributable-1.2.3-1.el8.x86_64.rpm

We only need last one as individual rpms for specific architectures
is fine but not the redistributable ones.
Internal build system now supports golang 1.13
Signed-off-by: Mohammed Zeeshan Ahmed<EMAIL_ADDRESS>What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind cleanup
What does does this PR do / why we need it:
See above
Which issue(s) this PR fixes:
None, this is cleanup in preparation of new build system
How to test changes / Special notes to the reviewer:
You can double check by building using golang 1.13 for any breakages

/retest

/retest

/retest

/approve

Actually
/approve cancel
We need Z arch because there is a team dependent on that

@girishramnani that will happen automatically in build system .The redistributable package will be build in x86_64 just not in all other architectures as there is no point having redistributable package on 3 different archs

/approve

/lgtm


Multiple role assignments

"The addition of the Contributor permissions and the Reader permissions is effectively the Contributor role for the resource group. "
better wording:
The net effect...
or
The sum of...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e21d4b9-f574-e01d-8676-fb23d6a4ab67
Version Independent ID: 85e74a1b-3bb3-8bdd-8fca-38256c8a46c1
Content: What is role-based access control (RBAC) for Azure resources?
Content Source: articles/role-based-access-control/overview.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

@HughDevlin, Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

Hi @HughDevlin
Thanks for the feedback. I'll work on making this update.
thanks

Hi @HughDevlin
This update has been published:
https://docs.microsoft.com/en-us/azure/role-based-access-control/overview
thanks

#please-close


AdMob.prepareInterstitial is not working on Android (Interstitial Ads can only be shown once)

I can only show interstitial ads only once in Android App. I have called AdMob.prepareInterstitial after showing the first Ads and also tried to add listener function. However, none of this works. I can not show interstitial Ads for the second time because the ads was not loaded although I have called AdMob.prepareInterstitial function. This is not an issue in iOS platform. Thank you.

Thanks @anggariskyraharja for report this. It is now fix.
@rdlabo can you please release a 2.x.x patch when you have time?

Thank you very much to fix this issue


fix(readme): Update README with new collector component links

As the issue tracking moving exporter/receiver components from otel-arrow to open-telemetry/opentelemetry-collector-contrib has been marked as completed, we can update the "Project deliverables" in readme doc.
This PR also fixes some dead links.

Thank you!


Separate add unit table property from add waveforms

Motivation
This is the first PR to break down all the code changes in #450 as requested by @CodyCBakerPhD .
It just adds a different function called add_wave_forms_to_units_table that works separately from add_units.

Nice and simple first PR, thanks for the work splitting it.


The version of torch and metrics to evaluate SSIM and PSNR？

Dear author, thank you for your great job~
I would like to know the detailed version of pytorch and python in your model environment. Since when I use the model you release,  the PSNR & SSIM results on the postcard and object datasets are a little different from those in your paper.
Here the metrics I use to evaluate PSNR & SSIM are skimage.metrics.peak_signal_noise_ratio and skimage.metrics.structural_similarity, the python and pytorch version in my device are 3.7.3 and 1.2.0.
Looking forward to your reply~

👍


Implement entity scale

Possibly as a component. Care needed as bbox and view should listen for scale values. Also, negative values should be considered.

This should combine position and rotation and become TransformComponent?

Done in 11.0


How to add custom font file inside the plugin

Hi Team,
I need to add our own created custom font file inside he plugin .
Kindly provide the solution.

if you have then font installed on your computer, just add it to the fontFace property in the slides.addText() function. I don't think you can add font files directly to power point files, so the font would have to be installed on the person opening the files system. ( i might be wrong though)