A Feature Suggestion: Settings > About

Issue Summary
In the Wagtail Admin UI, within ‘Settings’, add a section named ‘About’.  This displays read-only information about the version of Wagtail and the version of Python.  The programmer does not have to do any work to create this section.
As an extension, there could be a field that the programmer can populate with an arbitrary string.  I can imagine putting a  GIT branch name, or a release identifier in that field.

Hey @wtorcaso, thank you for the suggestion. You might have noticed already but in the admin's nav area the Wagtail logo shows the Wagtail version number on hover, which serves a similar purpose. I can see the value in having this on a separate page with more information though.
I think this could be built first as a separate third-party package, which we could then consider for integration in Wagtail if it seems valuable to have this built-in. How does that sound?

That sounds fine – I have thought about doing it myself, as a learning exercise.
I think it is important to have all of the execution-environment information available in one place; I am working with Wagtail projects based on both Python 2 and Python 3, therefore both Wagtail 1.x and 2.x.  My tiny little brain sometimes gets confused about what I am working with.
I see this as a pyramid:
    Which release of my code?
                Which release of Wagtail?
            Which release of Python?

And that leads me to the suggested extension in which the admin of the Wagtail site can identify all three levels by looking in Admin UI location.
From: Thibaud Colas<EMAIL_ADDRESS>Reply-To: wagtail/wagtail<EMAIL_ADDRESS>Date: Wednesday, February 14, 2018 at 11:26 AM
To: wagtail/wagtail<EMAIL_ADDRESS>Cc: William Torcaso<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [wagtail/wagtail] A Feature Suggestion: Settings > About (#4225)
Hey @wtorcasohttps://github.com/wtorcaso, thank you for the suggestion. You might have noticed already but in the admin's nav area the Wagtail logo shows the Wagtail version number on hover, which serves a similar purpose. I can see the value in having this on a separate page with more information though.
I think this could be built first as a separate third-party package, which we could then consider for integration in Wagtail if it seems valuable to have this built-in. How does that sound?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/wagtail/wagtail/issues/4225#issuecomment-365662003, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXhBqQJk1pVI1fOQ1y2sldwoZ1CqA5XVks5tUwkrgaJpZM4RxBh-.

I’m going to close this now since things have moved a bit compared to three years ago – we’re now displaying Wagtail’s version number in the Settings menu.
If people want to add other environment metadata, they can override that templat (https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/shared/menu_settings_menu_item.html), or use our branding overrides (https://docs.wagtail.io/en/stable/advanced_topics/customisation/admin_templates.html).


Feature/info tab edit

ga4gh/dockstore#745
This is the third pull request.

Moved workflow and tool info tabs to its own component
Allows workflow and tool info tabs to be edited
Fix for old DAG displaying when new DAG is error

Hmm, I don't think GitHub is showing me a proper subset of changes as expected

Not sure what changed, but it looks like it's showing the correct changes now.


Q: How to style font icon div

I previously rendered front icons in react like <div className="icon-class" style={icon styling}/> Is there a way to create a styled component from the styling, but have the ability to pass the className of the icon through as a property? i.e concatenate the additional className onto a one generated by styled component

Styled components adds the passed classname by default.
const Icon = styled.div``
<Icon className="icon-class" />


bash stops echoing commands typed at the bash prompt after sbt package

Don't know if this is specific to this project or not, but I've never seen it happen anywhere else.
After running the following, my bash prompt no longer echoes my comands as they are typed, e.g.
$ cd mesos-in-action-code-samples/chapter02/spark-primes-example
$ sbt package
$ # now I can't see anything typed at the bash prompt - weird stuff - but it responds normally

Using Ubuntu 16.04, never seen anything like this before.  OK by me if you close this as off-topic and cannot replicate it, but very curious to know if anyone else has this problem on this project.

I found a solution, using reset, from this blog post:

https://askubuntu.com/questions/171449/shell-does-not-show-typed-in-commands-reset-works-but-what-happened


Too short harvested video can fail

Bug Report
Expected behavior/code
No matter the record length, the harvesting should not fail
Actual Behavior
Some short recording slice, less then 4 seconds most of the time, are not harvested and the harvest job fails.
Steps to Reproduce

Configure and start a webinar
Start recording and stop it immediately.
Stop the webinar
Convert it in VOD

The harvest job service is a black box. No information is provided when a job fails, why it fails, etc.
I think about this solution to avoid failing job:

do not authorize recording length lower than a segment length. The segment length is known and defined in the settings: LIVE_SEGMENT_DURATION_SECONDS
To not authorize, the record button should be disabled while the recording length is lower than the segment length. So we have to expose the segment length to the front application.
The API should reject the stop recording action if the recording length is lower than the segment length.

Morevoer, we have to define a strategy when a recording slice fails. Should we fail all ? Should we harvest all other slices ? etc.


fileName is null if photo from camera

[x] Explain the motivation for making this change.
[x] Provide a test plan demonstrating that the code is solid.
[x] Match the code formatting of the rest of the codebase.
[x] Target the master branch, NOT a "stable" branch.

Motivation (required)
The fileName in response is nil  if photo from camera.
Fixed it.
Test Plan (required)
take a photo by device and response have key of fileName

Pls consider merge this @janicduplessis @Johan-dutoit


On Linux the device doesn't enumerate if the power is connected second

Describe the bug
If the power is connected second, a Linux system won't recognize the attached device.
To Reproduce

Connect a USB-A to C cable to the computer and plug it into the device.
Connect the power cable to the device.
Use the AzureKinectFirmwareTool to list the device.
The tool says no devices are connected.

Expected behavior
The order of the USB vs Power shouldn't matter and the device will enumerate if both cables are connected.
Desktop (please complete the following information):

OS with Version: Ubuntu 18.04.2 LTS
SDK Version:  1.1.0-beta.0
Firmware version: 1.6.987014

This appears to only affect one of my computers. The other computer everything works as expected. One other side effect is that instead of giving an error about not being able to open the device when running without the power connection, it just doesn't show up. In addition after the Firmware Update step where the device is rebooted, the device never enumerates.

This is a computer with an Asus P8Z77-V PRO/THUNDERBOLT motherboard. The USB ports are from the Intel Z77 Chipset and are USB 3.1 Gen 1. The ASMedia host controller does not appear to work at all.

USB View when the Kinect is working:

USB View when the Kinect is not working:

It looks like the USB hub in the device is enumerating, but that the devices downstream of that are not.

I can't repro this. Lets treat this as a one off issue until we get a signal this is happening on more than 1 PC.

I also have this problem. When Azure Kinect died (it died quite ofen), I have to unplug the power and USB, and first plug in the power adapter, second plug in the USB to the pc. The other way around will lead to unable to start the camera.
The USB cable is a custom 3-meter usb-c to USB-A cable. (I'm using ubuntu 18.04 with ros)

Over 2 years later and this exact issue is still very much present on Jetson Nanos running Ubuntu 18.04


[HW]

Name: Xinyu Su
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/xinyu-su-414a451b2/
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:

Hey Xinyu Su, great job! Congrats!  Please delete your token via the Astra UI to ensure there are no security issues.


Add BGP datapath interface and implement goBGP integration

Required by #6203

@hongliangl I was going to review the PR but found there is no description about what it does and how it does it, to build my expectation on the code, the same for the dependent PR #6203. Could you write a summary for reviewers to better understand the code? See the example.

Done, but not sure if the commit message could provide enough information. Please tell me if you need more information that is not covered by the commit message.

Please update PR description and link to issue.

I haven't reviewed this in-depth yet (I will give a round of review after Quan's initial comments are addressed), but I have a high-level comment about the file organization. It seems that having the engine sub-directory is not providing much value. I was picturing something like this:
pkg/agent/bgp/
    # Interface used by Antrea, independent of actual BGP implementation
    interface.go
    # Utility functions / objects which are independent of the actual BGP implementation
    utils/
    # Implementation of the interface based on gobgp
    gobgp/

Much better! Will refactor.

Please update PR description and link to issue.

Will do.

LGTM once the go mod comment is addressed

Done. Sorry for forgetting to address the go mod comment.


Rework cpu.c to make room for x86 path

The main change is to switch the nesting of the #if's. This used to be first #if on platform/OS, then #if on CPU architecture.  But actually the fact that the platform/OS needs to be involved is a ARM-ism; it is the CPU architecture that drives the higher level approach. And structuring the code this way makes it possible to later split it into separate files for each architecture (not doing it for now because this opens questions of what we do with the Bazel+CMake build system, so deferring that until there's a concrete need).
And even for the existing code, having the #if on CPU architecture at the top results in simplification as a couple of platform/OS-centric functions don't need a fallback anymore now that they only exist within a CPU-architecture-specific section.
Also flattened some helpers, IMO making code more readable.
UPDATE: also renamed cpu_data identifiers to be shorter, and to share them across 32bit/64bit variants of ARM for now (and soon x86), I think this at least eliminates some boilerplate and I suspect it's not impossible that ensuring that the same bit has the same meaning across 32bit/64bit variants of ISAs might avoid some headache in the future, as, although they are separate ISAs, they are more likely to be coexisting in some fashion (eg fat binaries) than 2 totally unrelated ISAs.

@benvanik see UPDATE on the PR description


[High prior] GitHub Pages for prototyp

@idrice24  Can  you set up  github page for prototyping
I  have  created a docs file where all html resources are stored.!!
Go to settings --> scroll until GitHub Pages  section -- enable github page --> select master -- and /docs
Open browser and run the links  https://idrice24.github.io/mns/

done!!


Incorrect handling of qualified function calls

This works:
julia> @chain df begin
       DataFrames.transform(_)
       end
1×2 DataFrame
 Row │ a      b
     │ Int64  Int64
─────┼──────────────
   1 │     1      2

julia> @chain df begin
       transform
       end
1×2 DataFrame
 Row │ a      b
     │ Int64  Int64
─────┼──────────────
   1 │     1      2

but this fails:
julia> @chain df begin
       DataFrames.transform
       end
ERROR: Can't prepend first arg to expression DataFrames.transform that isn't a call.

and clearly DataFrames.transform is a qualified call.
Is this documented? (I could not find a reference)

@jkrumbiegel - this is actually problematic in JuliaData context, as some packages like CSV.jl or JSON3.jl do not export their functions.

Ah yeah I figured this could become a problem. I have to think about it a bit, in which way this problem can be solved most cleanly. If this is just about adding logic so X.Y.func works or if this needs to work with arbitrary expressions that reference functions. Like find_module_dynamically().func

I guess we should allow things that can be resolved statically (during compile time), so:
find_module_dynamically().func

has to be expaned to:
find_module_dynamically(_).func

I guess and not to (you would have to write this explicitly to get the correct behavior):
find_module_dynamically().func(_)

DataFramesMeta's @eachrow also is able to correctly identify getproperty calls. It's a bit complex though and I'm not sure I fully understand it.

find_module_dynamically().func

has to be expaned to:
find_module_dynamically(_).func

I don't think so. Currently, the rule is that an implicit first argument is only spliced in when the expression is a function call, a macro call, or a symbol in which case it's expanded to a function call.
julia> dump(:(find_module_dynamically().func))
Expr
  head: Symbol .
  args: Array{Any}((2,))
    1: Expr
      head: Symbol call
      args: Array{Any}((1,))
        1: Symbol find_module_dynamically
    2: QuoteNode
      value: Symbol func

The Symbol . head doesn't qualify as a call, so it would currently error. But I could extend the rule so that Module.Submodule.func is recognized as well. The first argument would not be spliced into an arbitrary upper part of the syntax where there happens to be a function call, such as in find_module_dynamically(_).func

an implicit first argument is only spliced in when the expression is a function call, a macro call, or a symbol

OK - you are right. I have not read the README.md carefully enough.
However, I have to say that the rules when you do not have to write _ are tricky (I have been kicked by it several times already). The issue is that when one knows one can omit _ one will tend to try to omit it (assuming that it will be introduced automatically in a most sensible place). But I agree it is hard to cover all cases and one has to learn and remember when it can be omitted.

I have corrected the use of Module.Submodule.func etc. here https://github.com/jkrumbiegel/Chain.jl/pull/21
Additionally, this is hopefully a more informative error in the future:
error(
        """Can't insert a first argument into:
        $expr.

        First argument insertion works with expressions like these, where [Module.SubModule.] is optional:

        [Module.SubModule.]func
        [Module.SubModule.]func(args...)
        [Module.SubModule.]func(args...; kwargs...)
        [Module.SubModule.]@macro
        [Module.SubModule.]@macro(args...)
        @. [Module.SubModule.]func
        """
    )

Thank you!


Search page is broken (probably very rare)

It seems that I'm one of the few people left that still has older search page style, therefore I'm getting these kind of problems:

What old search page style? If you're talking about the old search filters button, I highly doubt that would cause this. Did you test in a Private Window? Do you have any other extensions and/or scripts that affect YouTube enabled? CustomTube is only compatible with uBlock Origin and Return YouTube Dislike right now.
I remember one user had a similar problem with the homepage only showing 1 video per row, and the cause was an old "Sort by Oldest" extension they forgot to uninstall.

 Tried running it in private window, no changes.
I use Microsoft Edge (Chromium version obviously).

Could you try it in Firefox? Try it both signed in and signed out. That should help determine where the issue is coming from.

Downloaded latest release of Firefox, installed CustomTube from Add-ons page, tested both signed in and signed out. Same results.

Alright, I just looked into it, and you were actually right; the fact that you still have the old Search Filters design is indeed the cause. I'm honestly baffled, I had no idea such a thing could happen. Luckily, the fix is very easy.
Paste this code into Stylus:
#header.ytd-search {
  display: none;
}

Hopefully this helps.

Yep, that fixed it!
Thanks for help.

Good to hear! Just know that once you get the new design, the search filters will be completely invisible, so you'll want to disable that code when that happens.

Please tell me, I have the same problem with the search, what should I do? I didn't understand anything from this topic. (


[Event Request] Application “Tests-Graph”, Codeunit 142081 "Test Intrastat DACH"

[Event Request] Application “Tests-Graph”, Codeunit 142081 "Test Intrastat DACH"

Could you please insert the OnTestInitialize Event at the beginning of the procedure Initialize?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add Linear Type/Affine Type/other substructural logic

They dont need to respect abmonoid

No monoid anymore, question irrelevant


CDASyncedSpace lastSyncTimestamp is not set to the timestamp of the last synchronization operation

The lastSyncTimestamp property in CDASyncedSpace appears to represent the newest sys.updatedAt date among all items, rather than the "timestamp of the last synchronization operation" as indicated in the docs.
As far as I can tell, the property gets updated in these two places:

-[CDASyncedSpace updateLastSyncTimestamp]
-[CDASyncedSpace handleSynchronizationResponseWithArray:success:failure:]

The problem with this is the date of the most recently updated item is not very useful for synchronization. I think the lastSyncTimestamp property was really meant to help decide if enough time has passed and another sync is needed.

Hi @va7map , it looks like you are correct, and that the lastSynceTimestamp property on CDASyncedSpace is misleading. As far as moving forward with a fix, there are two considerations to take into account:

The /sync endpoint does not actually send a timestamp in the response, which means that if we want to save a timestamp...
The timestamp should likely be marked locally by the SDK using NSDate. However, as NSDate uses the system clock, if the end-user has changed the date/time on his or her device, this time will be inconsistent from the real world time.

I'm curious to hear your thoughts about a preferred solution, as my sense is that you are optimizing to reduce network requests.

I was looking for other solutions to get the timestamp when I found the Date HTTP response header from the /sync endpoint. It seems to indicate when the response is generated and is present in both initial and subsequent synchronizations.
Can that be used to set the lastSyncTimestamp property?

This is a great solution, we just need to beware of timezones as the header is always returned in GMT. I think it would probably be best to leave the logic of timezone adjustment up to the SDK consumer.
I will begin working on a pull request for this issue later in the week—if this delay is too long for you, just let me know if you would like to work on an implementation on your own.

Sounds good. I think NSDate handles timezone logic and conversion pretty well, so it shouldn't be an issue as long as it's parsed with the GMT timezone intact.
And no rush! I have a temporary workaround in place until the SDK is fixed.
While we're at it, would it make sense to add the lastSyncTimestamp property to the NSCoding methods so it can be retrieved from a serialized synchronized Space file?

Hey @va7map , I will have to do this first thing next week. Got bogged down with work this week.

Thanks for the update. Let me know if you need more details from me.

Hey @va7map , just a heads up that I started working on this today. It turns out that the lastSyncTimestamp was used internally by the SDK for auxiliary reasons despite it's outward facing documentation. I expect this to take another day or two.

After some serious investigation and experimentation, I am unsure if changing the date that is stored in the lastSyncTimestamp is something that can be done at the moment. It turns out that the intention of this property is not necessarily to signal how much time has passed since the last sync operation was performed. Rather, it is intended to be used to implement logic about updates to Entry and Asset instances. If the timestamp does not reflect the most recently updated entry that was delivered during the last sync, records that were unpublished then published again will be represented in CoreData as a delete and then a create. This is in contrast to the current implementation, in which an unpublish/publish is reflected as an update in CoreData. I've copied some relevant text from the reference documentation below:
Regardless of the intended functionality, there are many complex test cases and scenarios which have network stubs that will take a lot of work to recreate. Currently, the test network stubs are just pure JSON and therefore do not contain the HTTP response headers. Since an initial sync always returns all records currently available in a Space, recreating intermediate sync stubs will take quite some time, and therefore changing the behavior of lastSyncTimestamp will break the testing suite and  cause more work than is worth the reward. For now, it will have to remain the responsibility of the SDK consumer to keep track of the date of the last successful sync operation.
Reference docs
/**
 *  Timestamp of the last synchronization operation.
 *
 *  Store this alongside the `syncToken` and restore it on a newly created synchronized Space to
 *  ensure that the `delegate` will be correctly informed about updates. If you fail to restore it,
 *  only create and delete operations will be reported to the delegate of a shallow synchronized Space.
 *
 */
@property (nonatomic) NSDate* __nullable lastSyncTimestamp;

Thanks for looking into this. If lastSyncTimestamp is used internally for another purpose, I agree that we shouldn't change that. However, perhaps it would make sense to update the documentation to clarify its role. I think that describing it as the "timestamp of the last synchronization operation" is a bit misleading because it really is the timestamp of the most recently updated entry or asset.
On the other hand, do you think it should be added to the NSCoding methods so it can be retrieved from a serialized synchronized Space file? Right now when I call +[CDASyncedSpace readFromFile:client:], the lastSyncTimestamp property will remain null.

It definitely makes sense to update the documentation for this property, and I will make sure to do that this week.
and yes, I do think it should be added to the NSCoding methods. I will fix this in the same PR as the documentation fix.

@va7map feel free to leave comments on #86.

@loudmouth I appreciate your help on this


fix: Fix event URL serialization

Correct value set against URL when serializing.

Looks good, the location field should indeed be used for things like "conference room" or and address, but not a URL. http://www.kanzaki.com/docs/ical/location.html


Update requirements.txt

There are more requirements than the argparse and colorama.

Hi,
These requirements are for the spoofcheck program. The version included in this repository has been deprecated and removed. The current spoofcheck program is now hosted at https://github.com/bishopfox/spoofcheck.


Report fields - Report fields values do not update when changed for submitted expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.21-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Preconditions: Existing workspace with report fields enabled and report fields set up

Navigate to workspace chat
Create new manual expense
Open the expense and submit it
Change any of the report fields value
Repeat step 4. if issue not reproduced on first change

Expected Result:
Correct report field value should be displayed
Actual Result:
The value selected by the user is briefly displayed and reverts to the previous value
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/6b04590b-2746-4f5d-978c-129161dd761c
View all open jobs on GitHub

@anmurali  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Changing the report field value resets back to the old value even though the updates are applied on the backend.
What is the root cause of that problem?
I think the root cause is passing wrong update IDs to the GetMissingOnyxMessages API which merges the the new state with the old state.
https://github.com/Expensify/App/blob/76158981580aa046592df17c940fb6b289b0924d/src/libs/actions/OnyxUpdateManager/index.ts#L136-L143
Here the previousUpdateIDFromServer value is off by some updates and lastUpdateIDFromClient value will also include the old updates as well which overrides the new state while merging.
What changes do you think we should make in order to solve the problem?
I think changing the updates id range from lastUpdateIDFromClient -> previousUpdateIDFromServer to previousUpdateIDFromServer -> lastUpdateIDFromServer will apply the correct changes.
What alternative solutions did you explore? (Optional)

Proposal Updated
https://github.com/Expensify/App/issues/47566#issuecomment-2294804511
Added demo video

https://github.com/user-attachments/assets/17fbd93d-4cfa-4c4f-8c25-2b67ddd9aec4
Seems to be working as expected.

QA team can reproduce this issue, build - v9.0.27-0
https://github.com/user-attachments/assets/6b13f075-b3de-4b08-9618-c387e63270b0

@aimane-chnaif - there is a proposal above from @codewaseem for you to review.

Report fields are being built in #wave-control, moving this over to that project.

@aimane-chnaif yes. I think this is a backend issue.

Issue not reproducible during KI retests. (First week)

@aimane-chnaif Issue not reproducible anymore
https://github.com/user-attachments/assets/0b755921-0b2a-4e07-8f8b-b2966e09a870


torch.save() error with PL 2.0 and PyTorch 2.0

Bug description
The error arises when pickling a model with torch.save(). The source is this line from PyTorch DataLoader
https://github.com/pytorch/pytorch/blob/92eb9d363a7110a43746cc3e704a393837d5047c/torch/utils/data/dataloader.py#L658
PL and PyTorch versions == 2.0.
Specifically, it looks like the error occurs when torch.save() is called in on_train_epoch_end in a Callback class.
How to reproduce the bug
from typing import Tuple
import os
import torch
import pytorch_lightning as pl
from torch.utils.data import DataLoader
from pytorch_lightning.callbacks import Callback

class CustomCallback(Callback):
    def __init__(self) -> None:
        super().__init__()

    def on_train_epoch_end(self, trainer: pl.Trainer, pl_module: pl.LightningModule):
        # executed every epoch of the training
        with open(os.path.join(os.getcwd(), "min_repro.pkl"), "wb") as fb:
            torch.save(pl_module, fb)

class CustomPL(pl.LightningModule):
    def __init__(self, model: torch.nn.Module):
        super().__init__()
        self._model = model

    def configure_optimizers(self) -> torch.optim:
        opt = torch.optim.Adam(self.parameters(), lr=3e-4)
        return opt

    def forward(self, x: torch.Tensor) -> torch.Tensor:
        return self._model(x)

    def training_step(self, x: Tuple[torch.Tensor, ...], batch_idx: int) -> torch.Tensor:
        ypred = self(x)
        loss = torch.mean((ypred - torch.zeros_like(ypred)) ** 2)
        return loss

pl_module = CustomPL(torch.nn.Linear(1, 1))
data = torch.randn(10, 1)
dloader = DataLoader(data, batch_size=10)
trainer = pl.Trainer(callbacks=[CustomCallback()], max_epochs=4)
trainer.fit(pl_module, dloader)

Hoping to get some pointers from the developers to see if this is an actual issue concerning PL, or is it more of a PyTorch issue?
On that note, the relevant PyTorch code has not been changed since at least PyTorch 1.3 so I am guessing there have been some backward incompatible changes in PL 2.0
https://github.com/pytorch/pytorch/blob/49444c3e546bf240bed24a101e747422d1f8a0ee/torch/utils/data/dataloader.py#L646
Error messages and logs
NotImplementedError: ('{} cannot be pickled', '_SingleProcessDataLoaderIter')

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response
cc @justusschock @awaelchli

I'll look into this. Note however that serializing an nn.Module (or pl.LightningModule) is strongly discouraged. You should instead serialize the pl_module.state_dict()
You can work around this error by patching it in the meantime:
def getstate_patch(*_):
    return {}
from torch.utils.data.dataloader import _BaseDataLoaderIter
_BaseDataLoaderIter.__getstate__ = getstate_patch

Thanks for the workaround!

Opened a PR in #17130


fix: bootArtisan should be called last, otherwise the settings after that will not take effect in artisan console

…will not take effect in artisan console
📑 Description
Closes https://github.com/goravel/goravel/issues/?

@coderabbitai summary

✅ Checks

[ ] Added test cases for my code

Good catch 👍  About the failed Lint CI, you can rebase the v1.14.x branch, I solved it.


The Object can represent invalid game states

The existing  Object structure can be used to create invalid game objects. For example, a Bear that is a consumable.
Object {
    label: vec!["Bear".to_string()],
    description: "A bear (enemy)".to_string(),
    location: Some(LOC_CAVE),
    destination: None,
    item: false,
    enemy: true,
    health: Some(100),
    attack: Some(20),
    consumable: true,
},

Looks like this has been changed in the new PR


Adding Animate on Scroll (AOS) animations to Social Media Dashboard

Is your feature request related to a problem? Please describe.
The feature is to add scroll animations to all the components in the Social Media Dashboard
Describe the solution you'd like
I am using AOS (Animate On Scroll) plugin to animate the components in Social Media Dashboard. AOS is an open-source vanilla JS plugin.

@Ayush7614 I would like to work on this as a part of HCSSoC'21


[kubeservice-custom-limitrange] Not auto installCRDS

Not auto installCRDS in kubeservice-custom-limitrange helm charts

fix on version 1.2.0.
See: https://github.com/kubeservice-stack/kubservice-charts/releases/tag/kubeservice-custom-limitrange-1.2.0


ZAP allows an attribute with type "char_string" and length 256.

  But if the XML has that set, ZAP happily consumes it and ends up code-generating things that don't make sense.
Not sure where the right place for this sort of validation is: importer, UI, endpoint_config generation, or multiple places.

So I see that we can have string type references in attributes, command arguments and struct items.
A user can run into issues with this in the xml and exceed the limits in the attribute UI and that will take these things into generation. For attributes, I can add sql constraints on the attribute table such that user does not add the wrong values in the xml or during attribute UI’s default value editing.
For the use case of command arguments given, struct item values and change of attribute values during run time we need to handle all of these use cases through our generated code by making sure that the string values don’t exceed the limits.

2 is just for a better UI experience for the user creating an app but 3 is what will make sure errors like these do not happen.

My point is that having a char_string with length 256 is like having an int8u with a maxValue of 256.  It's an obvious mistake that should get flagged.


Support Counting Messages on Subtopics

Hey,
for our project we have a very complex message on our topics. So they didn't contain any usefull information for monitoring.
But what I'd like to do is monitoring my subtopics.
For example I have a topic structure like /Version/+/Services/+
So I wan't to monitor when something was published on one of my services.
In my head this isn't to hard to implement.

Subscribe to a topic
Each subtopic which appears gets a value in the grahp
Each time a new message arrives on the subtopic create point with timestamp

I tried to implemented myself. But I am very new to Grafana an Go. So any help would be nice.

First question is:
How to get subtopic of a topic?
As far as I can see a topic contains only an array of messages.


Move deploy blocker notification to open source channel

We are posting it in the #deployers room now, I am just moving it to the open source channel to involve contributors and changing the copy, since I don't think posting it twice is useful.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173930
Tests
None, is there a way to test this before merging?
QA Steps

Create a deploy blocker issue
Check it was posted in #expensify-open-soruce slack channel

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @roryabraham in version: 1.0.85-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

https://expensify.slack.com/archives/C01GTK53T8Q/p1629234420484400 this was a pass 🎉


Add support for command DUMP

Add support for the DUMP command in DiceDB similar to the DUMP command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

Hey. I would like to take this up!

@SyedMa3 Go for it.

DUMP Command Design Doc
Created a design document to be sure about the implementation. Can you please go through can provide comments? Thanks.
Quick Queries:

Should we include TTL in the response?
Should we include DiceDB version in the response?

cc: @arpitbbhayani @JyotinderSingh @soumya-codes @yashs360
PS: Please request access for editing/commenting on the doc since I do not have your emails.

@SyedMa3 are you working on this?
I would like to work on this issue.

Hey @ashwaniYDV  I am currently working on it. Waiting on maintainers to provide comments. I will remind them again.

hi @SyedMa3  Desing doc LGTM. @JyotinderSingh can review this.

Hey @ashwaniYDV  I am currently working on it. Waiting on maintainers to provide comments. I will remind them again.

Apologies, this skipped my mind. @soumya-codes could you also take a look?

@ashwaniYDV Hey. You can continue on this. Can't work this week, therefore un-assigning myself.

@JyotinderSingh sorry missed this. Will take a look right away.

@soumya-codes @JyotinderSingh please assign it to me, would like to work on this.

Hi @soumya-codes / @JyotinderSingh any work happening on this ? Would be great to work on this if possible

@lucifercr07 ^^

@lucifercr07  I have tried to implement this command. Can you assign this to me?

@TheRanomial assigned, thanks

#633

#633 raised a PR for the issue. @lucifercr07 kindly review it.

Hello @TheRanomial,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

#633 referenced this issue and has been successfully committed and closed.

Closing, merged as part of #633


Enable Multi-Targeting & Simplify Projects

Please take a moment to fill out the following:
Fixes #68.
Changes Proposed in this pull request:

Changes all project to multi-targeting
Changes tests to MSTest
Rename to Xamarin.Toolkit
Update readme with VSTS builds

Maybe it would be an idea to use Directory.Build.Props and Target files to gather the common properties.
https://github.com/MvvmCross/MvvmCross/blob/develop/Directory.build.props
https://github.com/MvvmCross/MvvmCross/blob/develop/Directory.build.targets
Docs are at: https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build

I have now implemented Directory props and targets.
Fixed up samples.

I think we are good to go. I will work on final copyright stuff and try to get into the .net foundation


Slove club cards are above footer

Fixes Issue

My PR closes #472
Changes proposed
What were you told to do ?

The club cards were above the footer, so I had to solve the issue of overlapping the cards and footer.
What did you do ?
I had solve the issue of overlapping of club cards over the footer, added distance between cards and footer

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Screenshots

Changes for the cards overlapping the footer

Is my pull requested has been accepted to main?

@Anuragwagh It has been 8 days, if there is no response from you within the next 12 hours (starting now) i would be closing the PR


[Packaging] Drop Python 3.6 support

Description
Close https://github.com/Azure/azure-cli/issues/19858
Since we have dropped Python 3.6 tests (https://github.com/Azure/azure-cli/pull/20865), now we remove Python 3.6 from classifiers.

I didn't update the command for OpenSUSE since we haven't worked on it for some time:
https://github.com/Azure/azure-cli/blob/bd9d24f43285c9a723c70f9a1f68e5e63cc1bfa9/doc/install_linux_prerequisites.md#L29-L37
I also doubt if there is really someone to use Flatcar to install Azure CLI (https://github.com/Azure/azure-cli/pull/18644#discussion_r912764215).

Packaging


⚠ Melody Beta has degraded performance

In f034253, Melody Beta (https://canary.melody.api.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 4058 ms

Resolved: Melody Beta performance has improved in f94b6af.


Fix of depricated BearSSL method call in sample for ESP8266.

Please correct the spelling mistakes in the comment.  This also needs a changelog entry


Add ping hook method

This change is

and?

any replies?

things move like molasses here, huh? i have PR open fixes branch protection functionality and no one seems to care.


Add PeopleForce to the list of companies using ViewComponent

What are you trying to accomplish?
Add PeopleForce to the list of companies using ViewComponent.

Thanks!


[Feature request] Context calendar view

Thanks for building such awesome plugin!
It came to my mind that calendar view would be an amazing add-on to context current views.
I think it can show files in calendar by getting date from file create / modification time, or date metadata property if it exists.

This will be in a future update that will address use cases around time: daily notes, calendar, timeline. Thanks for the feedback!


Release 1.6.1

This release includes:

Disabling HPA and clearing resource requests for XS clusters https://github.com/giantswarm/nginx-ingress-controller-app/pull/34

This nginx IC App release is to be included in

AWS 9.0.1
AWS 9.2.1
KVM 11.2.1
Azure 11.2.1
together with cluster-operator 0.23.5 https://github.com/giantswarm/cluster-operator/pull/959

Going with a ping


Remove Windows simulator command for memory_attributes

Existing Sample Changes
Description
Currently running simulator for this design on Windows will hang, so we are removing Windows simulator command for this design.
External Dependencies
Type of change
Documentation Change
How Has This Been Tested?

I think we might need to modify src/CMakeLists.txt so that one can only run fpga_sim target on Linux not on Windows. I will need to confirm with Yohann.


luci-base: column sorting

Hello,
Thanks for your work, I have gotten my colleagues to use LuCI, but we have so many static leases that we would like to sort the columns by their IP addresses.

I think this should be done browser side in javascript, also with a javascript search form.
The same for firewall port forwards.
Will have a look one day.

https://github.com/openwrt/luci/pull/2623

The Network/Hostnames page already has the ability to move entries up and down to change the order of the list. Would it not be a simple affair to add this function to the Static Leases page as well?

Dupe of #1370


[IPC/Client] Get rid of an unnecessary stopChan sending

There's no need to send struct{}{} to notify a waiting goroutine with an infinite loop about the stop.
It's enough to close stopChan. Moreover it could lead to a deadlock if driver.Stop is called before driver.handleSubprocessExit.

@noxiouz This is clearly a bug. This change may be required but IPC is actually disabled in the build for now, pending merge of docker/libchan#79.
@AndreyKostov @BrianBland Is this safe to merge?

LGTM


[fix] create redis vector index before adding docs, add prefix to doc…

Fix Description:
For Redis Vector integration in add_texts method, there were two issues that lead to this bug.

Vector index is not being created leading to no such_index error
doc:index prefix was also missing for Redis Keys.

resolves #11197
Maintainer: @baskaryan

@hwchase17 @eyurtsev
Can someone take a look at this? I am getting
google-github-actions/auth failed with: retry function failed after 4 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

for backwards compatibility + optionality, updated to check if prefix is already in the key and only add if it isn't. what do we think?

@Spartee @baskaryan LGTM >> My only input is that the current implementation, and this adjustment, still don't provide flexibility to allow for users to define their own index prefix right? It uses _redis_prefix() to generate this everytime. This will eventually need to change, but just highlighting that for future improvements.

@tylerhutcherson
The current implementation does provide users the ability to define their own index prefix.
While creating the Redis vector store object, user can provide the index_name argument, (see base.py#L251) which is then used to generate the prefix for the document. _redis_prefix(self.index_name)  (see base.py#L684)
For example,
vector_store = Redis(
        redis_url = "localhost:6379",
        index_name = "custom_prefix",
        embedding = embedding)

will generate documents with key prefix doc:custom_prefix:1234

@a9raag, what Tyler is talking about is the “doc:” portion. You’re code shows the custom index name.
Users may want the flexibility to have multiple indicies with different prefixes, yet similar keys. (Or some combination of this). The previous methodology seemed introduced as a convenience, but limited the functionality.
Maybe we add the ability to define prefix? Seems like it might be a footgun.

@a9raag, what Tyler is talking about is the “doc:” portion. You’re code shows the custom index name.
Users may want the flexibility to have multiple indicies with different prefixes, yet similar keys. (Or some combination of this). The previous methodology seemed introduced as a convenience, but limited the functionality.
Maybe we add the ability to define prefix? Seems like it might be a footgun.

^^ exactly -- redis is meant to be multi-tenant by design. So requiring the key prefix with doc: up front is an anti-pattern for redis. This should be a configurable setting, but could come in a later revision for the sake of simplicity. happy to help :)


Trim MAC addresses when submitting (e.g. on services_dhcp_edit.php)

Small patch to trim MAC address input on POST. This eases copy & paste which sometimes grabs a little extra whitespace on either end. Previously this would cause input validation to fail.

[x] Redmine Issue: https://redmine.pfsense.org/issues/13109
[x] Ready for review

I actually had that same thought, but somehow this looks easier to read to me, and also thought it's not going to make a measurable difference. If someone is pasting 64k of text into that field, then... well... 🤷♂


Integration-Tests is running before Application is running

How do you know that the Mock-Server and Application has started before the integration-test is running?
https://github.com/bszeti/kubernetes-integration-test/blob/e23a921742bcb67fc5e4feb76c980116883be51f/Jenkinsfile-declarative#L146

As I remember Jenkins waits for all the containers to reach the ready state before executing the stages. So it's important to have proper readinessProbe for each to avoid an early test execution.

After about 100 secondes unhealthy state the pod will be killed. A new pod will be created and starts. The problem is that my application needs more than 100 seconds to start. The config for the readiness probe settings is 60 *10 =600 seconds.

Pods are restarted because of the "livenessProbe" not the "readinessProbe". If livenessProbe is not set for any of the containers, then they are restarted because of another reason. Maybe the memory limits are reached, because -Xmx was not set for a java process?
Just right after the Pod is killed, the status may indicate why it was stopped.

Thank you very much. I think that I need to put the timeout higher. Unfortunately I don't have the permission to change it and I can't convince my associate that he change it.


Update doc-v2 branch to dev-tree head

You are making the PR in the reverse direction.
Again, if we merge the doc into devel, it will become a nightmare for the very next release of Pinocchio.

I am proposing to bring doc-v2 up-to-date with devel. I am not proposing to merge into devel until the time doc-v2 is ready.

Yes, I understood later. In fact, your title makes me confused.


adapt cmdline search to api v1.1

adapt cmdline search to twitter standard search api v1.1
new get_time_string format in SearchFormatter
tidy up output by replacing \n with space

Coverage increased (+0.3%) to 30.362% when pulling fe8f1770849f4921ebce45607e3fc1bc32d4a295 on ja70d:fix_cmdline_search_to_adapt_api_v1.1 into 3a8674afcf279c6a57289c9767be201065c3176b on sixohsix:master.

Seems legit, thanks and apologies for the delay!

Seems legit, thanks and apologies for the delay!

no problem :-)


ghstack: init at 0.9.4

Added package for ghstack. Not sure if I'm using meta.sourceProvenance correctly.
Closes #341572
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 354100 run on x86_64-linux 1

2 packages built:

ghstack
ghstack.dist

resolved via #341572


Cryptos lack of Ranking number

Dear All,
I have looked to get the Ranking number of any given symbol such as "BTC" 1 "ETH" 2.
However, either API does not have such a function or it is not documented.
Thanks.

I have seen this functionality in Coingecko API, but not in Binance.

Well, Binance gives ranking numbers on their Trading page so, I thought that this feature is missed or forgotten to be documented.

Recently, I've digged into Binance Api and to check what endpoints have been implemented in python-binance and what not.
Here is the result https://github.com/sammchardy/python-binance/blob/master/Endpoints.md
You can also check official documentation here https://binance-docs.github.io/apidocs/
I have found nothing in API as far as I remember. Please tell me if you find something.


👾 Merge main to develop

This PR was generated via github actions workflow
Don't squash merge this PR

Will be handled separately.


When removing a TileMap node (or its parent), remove_child method sometimes causes a crash.

Edit:
This comment is outdated / misleading. The core issue is TileMaps and physics processing - see below.
Issue:
I have a situation where I need to switch a node between being "active" and "inactive" - so that when inactive (or disabled) its script and processes etc. stop running. However, using remove_child() will (almost always) cause the whole game/engine to crash (at least on Win10) - tried using call_deferred, set_process_internal(false) and waiting some idle_frames too. Using queue_free(), there will not be a crash but the node cannot be added back to the tree (because it's not in memory anymore).
Workaround hacks:

My workaround now is to hold the original node in memory, and when I want to insert it, I duplicate the node and insert that duplicate - upon "disabling" the node, I call queue_free() on the duplicate. As is clear, this is not optimal in any sense (especially if a very complex node with a lot of kids), and it also brings other problems (eg. with AnimationPlayers inside the duplicated node - at least autoplay won't trigger, didn't check what the problem exactly is yet).
I know one other kind of workaround is to save the original node as a PackedScene and then just load and instance it again, but it is not the same as remove_child + add_child (which holds all the node's properties in memory). More importantly, this method also adds other complications - such as instead of saving some scene (eg. some place in a world) should make a "export mini scenes" functionality (eg. a dock tool), and handle all its special cases (tried it initially), as well as keeping book of all the miniscenes after renaming the main scene etc.

Suggestion:
I think either of the below two suggestions would fix this "problem":

A queue_remove_child() or similar method - would function like queue_free() but only removes from the tree, not from memory.
A disable_node() method, which would stop the scripts and processes etc. from running - or at least so, that remove_child could be called without crash after this. ... Or maybe a call_queued() method..? (I know "disabling node" has been discussed - but didn't found a solution in the discussions that would work in my case.)

Thanks for the suggestion. If you mean doing yield(get_tree(), "idle_frame"), then yes. Tried it along with using call_deferred. If I remember correctly the crashes did not happen that often, but they still happened.

Do you have an example project of the crash? Removing children shouldn't cause a crash in most cases unless other systems require it as a dependency.

Are there any messages when it crashes?

I'm so sorry, I have to rebuild that situation to do further checks. Will be back later with more info. Thanks!
(I did the system some weeks ago, but now was getting annoyed by the further problems (like the AnimationPlayer thing), so came back to it now.)

Okay. I don't have a project yet to share (have to separate the case from the other systems). But here is some error reports (quite new to Godot, please bear that in mind) :

Output tab gives me: drivers/windows/stream_peer_tcp_winsock.cpp:203 - Server disconnected! when the crash happens - ie. after calling remove_child.

Then Debugger's Errors tab gives twice: Condition ' !area_in && !E ' is true. With further info:

C Error: Condition ' !area_in && !E ' is true.
C Source: scene/2d/area_2d.cpp:262
C Function: _area_inout

... So possibly some Area2D node has problems when inside a child to be removed..?

And rechecked that "idle_frame" thing. So, was like I said: the crashes happen less frequently when using idle_frame signal, but they still happen (about 50% of the time). Without idle_frame happens every time.
... Just thought that maybe this is related to

Sounds like the game is looking for a collision check with a Node that isn't there.

Okay, thanks. Any ideas what to do about it? At this point, I'm not sure whether this is a bug or my misuse of the engine (tho queue_free works without any problems). Trying to rebuild a simplified scene, but so far no errors.

Did some further tests:

The issue happens only with TileMaps. So when removing a node that is a TileMap or has a TileMap nested within. It does not happen with, say, a StaticBody2D.
Also, it does not happen if I put collision_layer and collision_mask to 0 and then wait an idle_frame. (This is perfectly fine for my case - just have to keep track of what the layers were originally.)

However, in conclusion, I think this is a bug, and it's related to TileMap class and remove_child() method. The bug is that when removing a TileMap (or its parent) from the tree, the internal physics are still being processed (although not always), which causes a crash. To stop processing must manually nullify collision layers (see above) and then wait until the next frame. Changed the title to reflect this, and will try to make a simplified scene to reproduce the problem later. Thanks all for help!

Could this be an issue with the physicsserver not updating emmediately when the node is removed from the tree?

Thanks for the comment. I initially tried waiting several idle_frames (and tried a timer too), because thought it would be something like this, but made no difference. (One idle_frame makes a difference tho, see above.)
More info:
While modifying the system yesterday, found out that after I put the collision masks to 0, if I then do not put them back to something else (when readding the nodes), there will be another crash when removing another tilemap whose collision layer was at 0... In other words, perhaps it has something to do with removing tilemaps that have overlapping colliders (on same collision layers). .. I'l try to do further tests later.
Also found out that the second error (that Area2D thing) is perhaps not related. After switching from queue_free to remove_child approach, I now get that error all the time (no crash). Found this issue about overlapping Area2D's - it's closed, but I do have overlapping Area2D's. Anyway, not the core issue here.

I have the same issue. It happens when a a kinematicbody2d with a collision area is overlapping another area and then I try to remove it from there scene with get_tree().current_scene.remove_child(kinematicbody2d_node). It doesn't crash my game, just prints an error. My current hack-around is to move the object inside a _physics_process so that it isn't overlapping the area and only then remove it from the scene.

Can anyone still reproduce this bug in Godot 3.2.3 rc2 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.

I am running into this problems on version Godot v3.2.3. My use case is very similar my player is a kinematicbody2d and on the body_entered of my area2d pickup I am trying to remove_child which causes a crash.

@EricWRogers Can you provide a minimal reproduction project for the issue?

I can reprocude the error.
$> /opt/godot/godot --version
3.2.3.stable.official

$> lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 21.04
Release:	21.04
Codename:	hirsute

$> uname -a
Linux padlizsan 5.11.0-17-generic #18-Ubuntu SMP Thu May 6 20:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Also did it successfully in a minimal reproduction project:
bug_remove_child.zip
The Project consists of:

a navigation node

navigation mesh
mesh instance (ground)

static body

collision shape

Inherent Node 1 from Node (MeshInstance -> Area -> CollisionShape)
Inherent Node 2 from Node (MeshInstance -> Area -> CollisionShape) [Duplicate of Inherent Node 1]
Camera
Player (Kinematic Body -> MeshInstance, CollisionShape)

The player will move_and_slides along the x-axis and will collide with 2 inherent Node. First one will float above the ground, while the second overlaps the ground.
The nodes' area event bodyEntered will emits a signal on _on_Area_Body_entered to the player, which will remove the child from the root with get_node("/root/Spatial").remove_child(body).
The player passes the first one and the Object disappears. When hitting the last one the application crashes. Even former debug prints will be obmitted.

I guess it is caued by wrong usage due to area entered/exited events and using remove_child, but I think the application shouldn't crash.
In the debugger I got this error, which lead me to https://github.com/godotengine/godot/issues/21459 and https://godotengine.org/qa/1754/how-to-change-the-parent-of-a-node-from-gdscript suggestion to use call_deferred in this situation.
E 0:00:01.951   _clear_monitoring: This function can't be used during the in/out signal.
  <C++ Error>   Condition "locked" is true.
  <C++ Source>  scene/3d/area.cpp:221 @ _clear_monitoring()
  <Stack Trace> Player.gd:11 @ _on_Node_entered()
                Node.gd:15 @ _on_Area_body_entered()

Do I understand it correctly that it crash because my second Node is still waiting for the ground to exit again and locked ?

Bug seems to be closed in 4e52b84011b4b3c9edb7646731c3ffe451d26316
Compiled it with my system described https://github.com/godotengine/godot/issues/22589#issuecomment-853223858 and updated the project's script to newer version:
bug_remove_child_latest.zip
If anyone can confirm this, I guess the bug and be closed again ?

I've just seen this very bug with v3.4.stable.official [206ba70f4]
E 0:00:24.569   remove_child: Parent node is busy setting up children, remove_node() failed. Consider using call_deferred("remove_child", child) instead.
  <C++ Error>   Condition "data.blocked > 0" is true.
  <C++ Source>  scene/main/node.cpp:1183 @ remove_child()

Interesting right after that I had its opposite too:
E 0:00:24.588   add_child: Parent node is busy setting up children, add_node() failed. Consider using call_deferred("add_child", child) instead.
  <C++ Error>   Condition "data.blocked > 0" is true.
  <C++ Source>  scene/main/node.cpp:1135 @ add_child()

In my case it has nothing to do with collisions. I'm working on game that has a generic purpose dialog scene, using Control-derived nodes only. When the errors happened, the dialog content was updated, which first clears any old content (which can be a list of custom scenes, or just a single RichTextLabel), then adds the new content (again, this can be a list of custom scenes or a RichTextLabel).
This has happened when I was clicking a button very quickly in a "shop" selling items. But I don't think I should be that fast.


Defines a Kind trait to represent HKTs

Ironically i ended up doing other changes and removing the Kind trait. I'm going to open it again with another name


Personal Status, Contest Status

Add Personal Status and Contest Status
You can test by these urls:

Personal Status http://<IP_ADDRESS>:8000/status/hernyyang42
Contest Status http://<IP_ADDRESS>:8000/contest/692/

+1, @bruce3557 please check this.

+1


adjust max and min curves at the same time

It would be nice to adjust the curve offset for both min and max value at the same time to keep the range unmodified. thanks for considering! :)

Do you have a specific idea of how this would be accessible? SHIFT is already used for fine adjustment.

Maybe an offset mode added to F4?

@soporus I consider that a break from the current design because the function buttons are used to select layers. Each layer represents a piece of per-step data and is represented exactly once. Adding an offset button would imply there is another layer, but that is not the case as it would change the existing min/max layers. In addition, these additional function buttons will probably be used in the near future for other layers that I'm considering to add to curve sequences. So I'm afraid I'm not too fond of that idea.

Just to be clear, I think there would be some value in being able to "offset" curve segments, I'm just not sure what the best way of achieving this could look like.

@westlicht I'll have a think, maybe by holding max and min while turning the encoder?

maybe by holding max and min while turning the encoder?

had the same thought, but it also doesn't fit too well with the existing UI

I've just implemented a version where you can keep holding min or max (not and) function keys to offset the curve segment. I'm not sure I like this yet, but it's an option.

Will be part of the 0.1.27 release.


[FLINK-21401] Consolidate JobGraph generation to properly instantiate streaming and batch JobGraphs

This PR consolidates the JobGraph generation into as few places as possible. Moreover it introduces explicit factory methods for streaming and batch JobGraphs (JobType.STREAMING and JobType.BATCH) in order to better classify which tests can be run with the AdaptiveScheduler and which strictly require the DefaultScheduler.
This PR also introduces a JobGraphBuilder which can be used to make the JobGraph an immutable data structure. This builder is then used for the more complex JobGraph creations for tests.
Last but not least, this PR adapts some failing tests (mainly DispatcherTest) to also work with the AdaptiveScheduler.

Thanks for the review @rmetzger. I've addressed your comments. I will merge this PR once AZP gives green light.


Generate documentation site from NatSpec comments

@ajsantander if you won't be able to work on it let us know so someone else can pick it up. 🙂

I've given a shot to doxity, and uploaded the output here for review (source and ABI should be showing OK though, there was a problem with the directory structure when I rsync'ed).
There is much room for improvement:

Contracts are not listed in folders, which makes navigation difficult
Every contract lists its functions and its ancestors', without distinction
Several comments, such as devdoc annotations in the contract itself, are not shown (because they are not being picked up by natspec, it only picks devdoc from functions; see this issue for more info)
Multiline comments are not shown properly (see MintableToken functions), though this could be a problem on our comments, and not in the renderer
Cosmetic details, such as OpenZeppelin branding, look and feel, etc

Also, I had to fork Doxity since it is using an out-of-date compiler, and remove truffle.js or the compilation via truffle failed. And, in order to compile all contracts in all nested folders, had to run:
doxity.js compile --src "$(find contracts -name *.sol | paste -sd ' ')"

I'm not sure how much this documentation provides in terms of help to a user. Perhaps with a bit more time, a better natspec parser (either patching solc's, or using a custom one), and a better template (I've been following docusaurus closely) we can build something more interesting.
WDYT? Should I automate the process for building/deploying those docs, so we have something working now, or aim directly for a better option?

I agree with all your comments. Additionally, there are no docs for internal functions, which we need for stuff like FinalizableCrowdsale#finalization.


Exception JSONDecodeError

I get this error when I try to run the script:
Traceback (most recent call last):
  File "main.py", line 232, in <module>
    org_boards_data['me'] = requests.get(my_boards_url).json()
  File "/usr/local/lib/python3.5/site-packages/requests/models.py", line 826, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/local/Cellar/python3/3.5.2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/json/__init__.py", line 319, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python3/3.5.2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/Cellar/python3/3.5.2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I have double checked that the environment variables are set.
I have installed requests via "pip3 install requests"
I'm running python 3.5.2 on Mac OS X El Capitan installed via homebrew (python3)

Any idea? thanks

Hi,
Quickest way to debug it would be to add a print statement to display the my_board_url variable to check its value.
It should be something like this: https://api.trello.com/1/members/me/boards?key=YOUR_KEY&token=YOUR_TOKEN
Paste the URL in a web browser to see what you get. Could it be related to the environment variables being reset when restarting the shell?
Let me know if it helps!

I am getting a similar error:
`==== Backup initiated
Backing up to: 2018-03-13_20-58-40_backup
Incremental: False
Tokenize: False
Backup closed board: False
Backup archived lists: False
Backup archived cards: False
Attachment size limit (bytes): 100000000
Traceback (most recent call last):
File "/usr/local/bin/trello-full-backup", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.6/site-packages/trello_full_backup/init.py", line 5, in main
cli()
File "/usr/local/lib/python3.6/site-packages/trello_full_backup/backup.py", line 286, in cli
org_boards_data['me'] = requests.get(my_boards_url).json()
File "/usr/local/lib/python3.6/site-packages/requests/models.py", line 886, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/local/lib/python3.6/json/init.py", line 354, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.6/json/decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.6/json/decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)`

Are the credentials (TRELLO_API_KEY and TRELLO_TOKEN) provided when using the docker run command?
docker run -t -e TRELLO_API_KEY=YOUR_KEY -e TRELLO_TOKEN=YOUR_TOKEN ...

Yes they are.

I also tried to create a new Trello account and tested it out, same results. I am trying from an iMac and a Macbook as well as a Synology NAS, same results on each.

I've had this happen intermittently, with a large board where sometimes the API fails with status 504 Gateway Timeout.
I've created https://github.com/jtpio/trello-full-backup/pull/37 which makes it a bit clearer what's happening by raising an HTTPError instead of JSONDecodeError. (It was trying to JSON-decode the HTML error body.)

For reference, I got that error again today.
I fixed it by replacing  the following parameter: --env-file ./.env (file in which TRELLO_API_KEY and TRELLO_TOKEN are defined) by -e TRELLO_API_KEY="xxx" -e TRELLO_TOKEN="xxx", in the docker command.


Add example to CLI section of Add a new SSH key

Why:
I was going through the instructions for Generating and adding a new ssh key and got a little confused with what file exactly to put in the gh ssh-key add <file> command, so I decided it might be helpful to add an example for those who are following the whole guide.
What's being changed:
Just adds an example code block.
Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@kalvinpearce
Thanks so much for opening a PR! I'll get this triaged for review :zap:


Leetcode Question Number 66

Leetcode Question Number 66 soultion needs to be added in the repo .
The link for the question is this.
Accepted Languages C++ / JAVA .
You Only need to add the  class Solution in the file.
Make Sure you have read the contributions guidelines before creating an PR.

Hey can I solve this question Plus One in java?


mention there is a "intel" branch that is meant to be a reference to enable full HW acceleration on Intel devices

 Front conversations

Hm, this link is not acceptable. Could you link the discussion here as well?

hey @kristjanmik this repository is optimised for Intel chipsets and grants hw acceleration https://github.com/resin-io/resin-electronjs/tree/intel

@curcuz Are there details posted somewhere on what hardware the Intel branch is meant to work with? My team tried using the Dockerfile from that branch on two Intel Compute Stick models, and it improved performance on our Atom stick but not our Core M3 stick.


Clarifying open terminal in project directory

Change-type: patch
Signed-off-by: Gareth Davies<EMAIL_ADDRESS>

balena-cli retest

@balena-ci retest


Arch.yml to Acme

modified:   src/rosdiscover/cli.py
modified:   src/rosdiscover/interpreter/summary.py
new file:   test.acme

I fixed all the issues mentioned.


Change web root for Docker image behind reverse proxy

As far as I can tell, there is no way to tell the Docker image what its web root is.

The dockerized app is always running on /
It's possible to forward https://example.com/~user/ota/ to http://<IP_ADDRESS>/ , however, there is no way to pass the ~user/ota/ part using the Forwarded header.
As such, the URLs that LineageOTA generates will be incorrect.

It would be nice if there was a way to specify the web root either via the environment or as a header.
I noticed that there is code to read it from ro.build.ota.url, but that doesn't seem to be present in the .prop files I got from docker-lineage-cicd.

Hi @CyberShadow,
Thanks for having approached with this issue.

I noticed that there is code to read it from ro.build.ota.url, but that doesn't seem to be present in the .prop files I got from docker-lineage-cicd.

The code over this project is meant to be used by multiple Android distributions if you look at the PRs. Therefore the property might be there either because of legacy reasons ( this project still supports CyanogenMod ) or because other ROMs do read that property. Although it's getting forward, the project full remains backward compatible as much as it can.

As far as I can tell, there is no way to tell the Docker image what its web root is.

The container was never meant to change that because it was always though to be used with a Reverse Proxy on top where you can redirect paths however you like. See other issues here and how other users have solved them.
All the best,
Julian

The container was never meant to change that because it was always though to be used with a Reverse Proxy on top where you can redirect paths however you like.

Perhaps it is I who is misunderstanding you, but I feel like it is more likely that you have misunderstood me.
The point of this issue is exactly that there is no way to specify the URL root path to the software running in the container.

To elaborate:

LineageOTA needs to generate full, absolute URLs to ROMs in its /api endpoint (specifically the .result[].url field)
In order to do that, it needs to know the full external URL to itself
When running behind a reverse proxy, the full external URL may not match the internal URL (in the HTTP request seen by the Docker image / LineageOTA)
It is possible to partially work around this by passing some information about the external HTTP request / configuration from the reverse proxy to the application using a side channel (in this case, the Forwarded header)
An URL consists of:

Scheme - passed as the proto= token in the Forwarded header
Username/password - not relevant here
Hostname - passed in the host= token in the Forwarded header
Port - also passed in the host= token in the Forwarded header
Path - not passed anywhere

As such, LineageOTA currently has no way of knowing the full URL to itself.

Here you can find an example of how it's currently being used, with a Reverse Proxy: https://github.com/julianxhokaxhiu/vps-powered-by-docker/blob/master/modules/lineage.lan.sh
I've personally used this container for long time and never had issues with it :)

@julianxhokaxhiu  Maybe it will be clearer to you if I show you what the problem is based on your script.
Here is a line from the file you linked:
https://github.com/julianxhokaxhiu/vps-powered-by-docker/blob/master/modules/lineage.lan.sh#L10
It is not possible to change that line from:
OTA_URL="https://$LINOTA_DOMAIN/api"

to:
OTA_URL="https://$LINOTA_DOMAIN/put-something-here/api"

There is currently no way to get the above to work, without any code changes. Hence this issue.

That's because in my script I prefer to have a domain, but again in your reverse proxy settings you can have something like this ( nginx example ):
server {
    listen                  443 ssl http2;
    listen                  [::]:443 ssl http2;
    # Your custom domain
    server_name             $LINOTA_DOMAIN;
    # Your custom path
    root                    /put-something-here;

    # reverse proxy
    location / {
        proxy_pass http://container-hostname:8080;
    }
}

And this is how you can accomplish what you need. But again it's totally up to you using a reverse proxy.

No, that doesn't work. The URLs that LineageOTA generates in the JSON emitted by the /api endpoint will be wrong.

No, that doesn't work. The URLs that LineageOTA generates in the JSON emitted by the /api endpoint will be wrong.

Did you actually test it? Feel free to drop a PR and I'll be happy to review it in case something has to be changed. As said, other users are being using this setup and is working fine for them, so I don't see why it shouldn't work for you.
Finally, as this is a FOSS project if you see something not fitting for you it's perfectly fine to contribute with your own idea, then we can discuss about it and improve it if needed, or accept it as it is. At the current state I don't see what has to be changed as, again, other users are using this setup and is working perfectly fine for them. Maybe they are not using the container, or maybe yes, no idea. But that's totally up to your own discretion how you do your own setup.

Did you actually test it?

Of course... that's how I discovered the problem.
How could it possibly work? Did you even try to understand my explanation? :(

Feel free to drop a PR and I'll be happy to review it in case something has to be changed.

I will do that, maybe it will be easier to understand from the fix.

Maybe they are not using the container, or maybe yes, no idea. But that's totally up to your own discretion how you do your own setup.

Probably because:

Without Reverse Proxy
With  Reverse Proxy

With app root on /
Works
Works

With app root on /something/
Works
Doesn't work

Thanks for the table resume. Than if that case doesn't work, let's find a solution to it. Feel free to shoot a PR and I'll be happy to check :)
Looking forward to it!

OK, here it is: https://github.com/julianxhokaxhiu/LineageOTA/pull/76


service selector for jaeger-query service is incorrect

I'm using jaeger-operator version 1.8.2
When installing jaeger with agent mode as daemonset and following spec:
apiVersion: "io.jaegertracing/v1alpha1"
kind: "Jaeger"
metadata:
  name: jaeger
  labels:
    app: jaeger
    chart: "jaeger-operator-0.1.0"
    release: "jaeger"
    heritage: "Tiller"
spec:
  strategy: allInOne
  allInOne:
    image: jaegertracing/all-in-one:1.8
    options:
      log-level: debug
      query:
        base-path: /
  storage:
    options:
      max-traces: 50000
      memory: null

  agent:
    strategy: DaemonSet
    options:
      log-level: debug
  ingress:
    enabled: false

Pods are generated with following labels:
NAME                               READY   STATUS    RESTARTS   AGE   LABELS
jaeger-547b6fc6cd-cj7vx            1/1     Running   0          3m    app=jaeger,jaeger=jaeger,pod-template-hash=1036297278
jaeger-agent-daemonset-6b77g       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-7lkfv       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-8s7m7       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-9tr46       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-crrch       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-flcx4       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-g8s49       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-gtltt       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1
jaeger-agent-daemonset-n5pqn       1/1     Running   0          3m    app=jaeger,controller-revision-hash=424870228,jaeger-component=agent-daemonset,jaeger=jaeger,pod-template-generation=1

And jaeger-query service is created with the following selector:
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: "2019-01-03T14:36:05Z"
  labels:
    app: jaeger
    jaeger: jaeger
  name: jaeger-query
  namespace: tracing
  ownerReferences:
  - apiVersion: io.jaegertracing/v1alpha1
    controller: true
    kind: Jaeger
    name: jaeger
    uid: e6fe3819-0f64-11e9-991a-0a2f2f061794
  resourceVersion: "120613599"
  selfLink: /api/v1/namespaces/tracing/services/jaeger-query
  uid: e708f3fc-0f64-11e9-991a-0a2f2f061794
spec:
  clusterIP: None
  ports:
  - name: query
    port: 16686
    protocol: TCP
    targetPort: 16686
  selector:
    app: jaeger
    jaeger: jaeger
  sessionAffinity: None
  type: ClusterIP

This results in jaeger-query pointing to all agent pods as well instead of pointing to just the pod created by jaeger deployment. This seems incorrect and the jaeger deployment should create a specific label for pods created by jaeger deployment which the service could use in its selector
something like component: jaeger-query

Thanks for reporting this - we have recently been discussing whether we should change the labelling approach, so will factor this issue in.


[Automation] Generate Fluent Lite from TypeSpec mongocluster

[Automation] Generate Fluent Lite from TypeSpec mongocluster

Test.


RFC: Introduce setup, teardown, and fixture attributes for cargo test

Problem
The current testing framework in Rust, as implemented by cargo test, lacks a convenient way to define and manage setup teardown, and fixtures objects for tests. While it is possible to implement such functionality using structs, implementing the Drop trait in case of teardown, and such, this approach can be cumbersome and lacks the expressiveness and convenience of more declarative fixture management.
The absence of a dedicated mechanism for defining fixtures and their lifecycles results in the following issues:

Test authors often need to implement repetitive and error-prone setup teardown code and common structs instance for fixtures, making tests less maintainable.
Complex test setups, teardowns, and resource management require a non-trivial amount of boilerplate code.
There is no standard way to share setup/teardown, and fixtures across multiple tests or test modules, potentially leading to duplication of setup/teardown code and fixtures.

Proposed Solution
This RFC proposes the introduction of three new attributes #[setup], #[teardown], and #[fixture] which can be used in Rust test functions to indicate functions that should serve as setup/teardown functions, and fixture objects respectively. Test authors can define setup functions/teardown functions, and common objects with these attributes, and the testing framework will ensure that they are executed appropriately before and after test functions that use them. For instance:
use std::fs;
use tempfile::TempDir;

#[fixture]
fn temp_dir() -> TempDir {
    let temp_dir = TempDir::new().expect("Failed to create temporary directory");
    temp_dir
}

#[setup]
fn setup() {
   // Setup before tests
}

#[teardown]
fn teardown() {
   // Cleanup after tests
}

#[test(setup, teardown)] // The usage of these functions is debatable
fn test_with_temp_dir(temp_dir) { // fixtures are passed to the test function as args
    // Test logic with temp_dir fixture arg
    // ...
}

With these attributes, test authors can set up necessary fixtures or resources in a clear and standardized manner before the test execution and ensure proper cleanup afterward. This feature will streamline the development of tests, particularly in cases where complex setup and teardown operations are required.
Notes
Introducing setup, teardown, and fixture attributes in Cargo Test will improve the test development experience by simplifying resource management, enhancing test predictability, and enabling developers to write more complex tests with ease. This RFC aligns with the goal of making Rust testing more ergonomic and developer-friendly.
P.S. Just stumbled upon rstest which provides fixtures, but lacks a setup/teardown mechanism.

FYI this is owned by libtest which is in the rust repo, and not cargo.  We've also recently formed a testing-devex team to focus on improving the workflows around tests in a cross-team way.
As this is a fairly fundamental change,  I would recommend experimenting in a library first for these ideas (pytest-rs is where my experiments live) and then bringing that proposal forward on internals.
However, this is unlikely to happen, directly.  Last I talked to the libs team, we walked away with the idea that we'd work to make harness=false harnesses first class citizens and focus on feature development there, rather than in libtest.  pytest-rs is my experiment towards that goal.
For myself, I see setup and teardown to be redundant with fixture and anti-patterns as they tend towards "god fixtuures" that encompass too much and slow down tests.  The proposal given also doesn't provide a way to pass state from setup to the test to teardown and doesn't cover process-wide vs test-wide setup/teardown.


add a config command

Some observations:

The -h and -p flags do not appear to be honored, changing them locally prints that it's using my override, but doesn't actually leverage them.
It also seems that the help displays far more options than are valid.
If the command is provided no parameters, a null.cfg is used rather than providing a response with "these are the expected flags"
I'm not sure I understand offline mode. If I provide no flavor to a running emissary, I would expect it to return it's effective configuration. If I DO provide a flavor, I would expect it to return a config based on what I gave, offline or not. If I'm trying to use the command and there is no running emissary then I can see needing to tell the command "don't try to connect". Would it make sense to simplify the options and say, "if flavor is provided, run in offline mode"?

The -h and -p flags do not appear to be honored, changing them locally prints that it's using my override, but doesn't actually leverage them.

If used in offline mode, h and p are used as startup params to generate the configs. If the configs have a call out to host and/or port, it'll use whatever you feed it. Otherwise, it is mainly needed for connecting to a specific node.

It also seems that the help displays far more options than are valid.

That is an Emissary thing. Same thing happens for agents command. We'll need a framework change to fix it. I'm happy to look into it to see if there is a way to toggle or override params from parent classes.

If the command is provided no parameters, a null.cfg is used rather than providing a response with "these are the expected flags"

Fixed this - made --place required

I'm not sure I understand offline mode. If I provide no flavor to a running emissary, I would expect it to return it's effective configuration. If I DO provide a flavor, I would expect it to return a config based on what I gave, offline or not. If I'm trying to use the command and there is no running emissary then I can see needing to tell the command "don't try to connect". Would it make sense to simplify the options and say, "if flavor is provided, run in offline mode"?

I added some validation to handle this. The output now looks like:
Command threw an exception: [config, --place, SamplePlace, --flavor, GRAPE]
com.beust.jcommander.ParameterException: --flavor can only be specified in offline mode


Colors are outdated

The new colors from v34 are not in the docs: https://windicss.org/posts/v34.html

slate
zinc
neutral
stone

Also, seems gray-900 is not 18181b as the current docs say as it was replaced by zinc-900

Updated, if it didn't update, refresh the web page or cleanup service worker and try again.

Thanks @hannoeru !


bash-it enable completion doesn't enable completions

Before installing bash-it, I could do
git che<TAB> ->
git checkout f<TAB> ->
git checkout feature/b<TAB> ->
git checkout feature/barcode
This stopped working after installing bash-it.
I have enabled the git and git_flow_avh completions in bash-it with bash-it enable completion git git_flow_avh, then I opened a new terminal to be sure that bash-it got reloaded with the new config.
HOWEVER when I manually source . ~/.bash_it/completion/enabled/git.completion.bash, then my bash completion does work as expected. I was wrongly assuming that bash-it enable completion works, apparently it doesn't.

Hey Amedee,
First of all, great seeing you here! :)
I noticed you submitted this issue a while ago. I just tested this by enabling the git completion script in bash-it. The example commands you provided seem to be working as expected now.
Are you still experiencing this issue?

The example given above works for me.
However git ls-f<tab> does not do the completion to git ls-files as desired

This issue is very stale, so I close it. Thanks for contributing and posting!


for connect framework to correctly resolve if it is sink or source

This change is

Nope. Thr code does a check on isAssignable from the interfaces SourceConnector SinkConnector

@Antwnis so renaming the class isn't the cause?


Add ELK as APIM on premise analytics solution

Describe your problem(s)
Add ELK as APIM on-premise analytics solution
Currently, APIM 4.x.x does not have any on-premise analytics solution. So we are planning to Support ELK as the official on-premise analytics solution
Describe your solution
With this solution. APIM can publish analytics events to a log file and ELK setup will listen to the log file and process and display the data.

Added support through https://github.com/wso2/carbon-apimgt/pull/11129


Allow workflow like promotion to bypass readonly flag

I cherry-picked it to 1.7.x. https://github.com/Commonjava/indy/pull/1179


Back-end - design API endpoints

Create document that drafts api endpoints and expected result from back-end. Better to do it in .md so we'll copy it in back-end repository.
--
completed criteria: .md file with documentation

apiDocumentation.md

These are the routes, so it is more about front-end, since we are talking about single page app:

HTTP GET https://www.mywebapp.com/login - It will retrieve the login page of our web application
HTTP GET https://www.mywebapp.com/signup - It will retrieve the signup page of our web application

I've added couple of changes, but now it should be fine for the beginning
apiDocumentation.md


Add black box testing

#12 was caused by the absence of black box testing, since there was no testing that the package was working successfully on a clean machine.

With The Things Network V2 shut down, we're going to archive this repository. This issue will be locked.


multi entry split

Just an idea. But consider a very large application with lots of javascript. It would be nice if we could just deliver the javascript required to display and run the current route for quick load and display time and only after that start reading in the rest in the background.
I believe the following could be a good start:
https://github.com/webpack/react-proxy-loader

Worth mentioning new react router supports that out of the box

Link?

https://github.com/rackt/react-router/blob/master/docs/guides/advanced/DynamicRouting.md#dynamic-routing

Hm, they seem to be using require.ensure not sure yet how to handle that on server side.

That works great! I'll port it over to este eventually.

Feel free to add wiki entry about your use case and how it should be solved. Thank you.


Updated ZIO to 1.0.0

Updated ZIO to 1.0.0.

@vpavkin Hi!
IMO PR is ready but some random checks are failing - the (yes, yes, yes) passed but (yes, yes, no) failed, in previous build was the opposite. I couldn't reproduce it locally - all pass, so it feels random to me. I've seen that such failed builds have been merged before.
Should we merge it?

@mtsokol hi. I think yes. I remember that some tests were flaky and I even remember filing an issue, but I can't find it now :thinking:. Maybe I remember a different repo :)
So let's maybe have a separate issue for flaky tests. Could you file one? I'll merge this PR


Azure Service Principal authentication using certificates

The Velero documentation authenticates against azure using Service Principal and a client secret.
However, you can also authenticate using a certificate. We're in quite a strict environment and have no secrets.
This is a feature request to add the ability to authenticate using a certificate also.
Relevent code: https://github.com/heptio/velero/blob/0fd7872ef48ce617e561e6e45f8ccb0f11637f58/pkg/cloudprovider/azure/common.go#L57
Azure autorest/adal method to use certificates: https://github.com/Azure/go-autorest/blob/master/autorest/adal/token.go#L535
Related to this issue: https://github.com/heptio/velero/issues/379
Longer term it's probably best to move to using https://github.com/Azure/aad-pod-identity

Cloud provider: Azure

@philwinder thanks for submitting this. Do you have any interest in working on a contribution here?

I'd love to, but it's not a priority at the moment. We're working around it for the time being. I will try and find some time. If anyone else fancies it, please go ahead.


feat: Handling Failed Uploads

Adding the ability to handle failed uploads. This is done by adding the 'load' event on the XMLHttpRequrest and looking for a status < 400. Instead of bubbling an error I went with the approach of setting the file UploadStatus to Failed (new enum value) and pushing it in the observable state with a type of 'failed'.
I felt this would be the least disruptive and most simple to implement.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for your PR. can you please amend commit message to follow guidelines and update readme for documentation.

Can you point me to the guidelines? Also, I have updated the sample application to show usage. There was no reference to documentation that I could find.

please check https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
so we can generate changelog with new feature.

I amended the commit message. Is it ok?

please do;
git rebase -i HEAD~3

mark second and third commit with s and leave commit message feat: add handling of failed uploads then save.
git push origin master -f

then please let me know.

also, please update version in package.json so we can publish new version to npm.

Bump to minor or patch? 7.2.0 or 7.1.1

to minor.

All requested changes done. :)

Hi, this is not in production yet, right? Thx!

Hi, this is not in production yet, right? Thx!

Not that I am aware of. PR is still open.

@jkuri can u please merge this pr? This is important feature.
Without this - uploader show UPLOAD DONE when server response with error

bump


Angle is not built for UWP

Steps to reproduce

Clone latest vcpkg
Run bootstrap-vcpkg.bat
Run vcpkg.exe install angle:x64-uwp

Actual behaviour
Vcpkg produces following error:
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: C:/Users/konsoletyper/devel/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe --build . --config Debug --target install -- /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /m
    Working Directory: C:/Users/konsoletyper/devel/vcpkg/buildtrees/angle/x64-uwp-dbg
    See logs for more information:
      C:\Users\konsoletyper\devel\vcpkg\buildtrees\angle\install-x64-uwp-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:96 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/angle/portfile.cmake:35 (vcpkg_install_cmake)
  scripts/ports.cmake:73 (include)

Error: Building package angle:x64-uwp failed with: BUILD_FAILED

Expected behaviour
Vcpkg installs Angle successfully.
Additional notes
Looks like it's regression introduced by 7a3818f575fadf1ded97244f803930fe2464f190#diff-f08e5b272610fce9183fc679c06667e3.

Windows uwp does NOT currently support pipe, which is the main reason for the build failure.
I am not sure what problem will be caused by disabling the pipe code of angle under uwp, so this issue is more reasonable by official fix.
See documentation.

@JackBoosY I don't care for the reason. I only care for Angle working in my project. What additional steps should I take to force this issue fixed? Should I report it somewhere else? Who is responsible for Angle package?

@konsoletyper Google::angle does not support uwp. In the previous versions, we supported uwp by modifying its source files (commenting some code and replacing some functions in ports/angle/001-fix-uwp.patch), but now more code needs to be changed due to source upgrades.
I don't know what it would be to just comment on the pipe-related code. So please report this to google.
Thanks.

Fixed.