Recursive extra dependencies compiles wrong requirements.txt

When pyproject.toml references its own local package to recursively include extra dependencies, it outputs a requirements.txt file which references the local package with the absolute path which is a problem as its not portable and should instead just list the dependencies
It was previously possible with setup.py with this configuration:
from setuptools import find_packages, setup

extra_require_tools = ["build"]
extra_require_test = ["pyyaml"]

setup(
    name='package',
    version='1.0.0',
    packages=find_packages(),
    extras_require={
        "dev": extra_require_tools + extra_require_test,
        "tools": extra_require_tools,
        "test": extra_require_test,
    },
)

Environment Versions

OS Type: Ubuntu 22.04.4 LTS
Python version: Python 3.11.6
pip version: pip 23.2.1
pip-tools version: pip-compile, version 7.4.1

Steps to replicate

Create a pyproject.toml with this content:

[project]
name = "package"
version = "1.0.0"

[build-system]
requires = ["setuptools>=69.1", ]
build-backend = "setuptools.build_meta"

[project.optional-dependencies]
dev = ["package[test,tools]"]
tools = ["build"]
test = ["pyyaml"]

Generate the requirements-dev.txt

pip-compile --extra=dev --no-emit-index-url --output-file=requirements-dev.txt pyproject.toml

Expected result
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
#    pip-compile --extra=dev --no-emit-index-url --output-file=requirements-dev.txt pyproject.toml
#
build==1.2.1
    # via package
packaging==24.1
    # via build
pyproject-hooks==1.1.0
    # via build
pyyaml==6.0.1
    # via package

Actual result
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
#    pip-compile --extra=dev --no-emit-index-url --output-file=requirements-dev.txt pyproject.toml
#
build==1.2.1
    # via package
package[test,tools] @ file:///tmp/example
    # via package (pyproject.toml)
packaging==24.1
    # via build
pyproject-hooks==1.1.0
    # via build
pyyaml==6.0.1
    # via package

Linked issues

https://github.com/jazzband/pip-tools/issues/204#issuecomment-1574051140
https://github.com/jazzband/pip-tools/issues/1685
https://github.com/jazzband/pip-tools/issues/2062

This is an edge case; we probably need to add some logic to drop the origin requirements if they are recursive extras, as they are redundant if the dependencies they imply are already part of the requirements file. That should happen directly after the resolution process. It's rather low priority, I presume, we have a lot of other issues to tackle right now - you're welcome to try and draft a fix, of course.

I encountered this issue too - as workaround for now, I stopped using nested optional-dependencies groups. Using the example above:
[project.optional-dependencies]
dev = ["build", "pyyaml"] # instead of `["package[test,tools]"]`
tools = ["build"]
test = ["pyyaml"]

optional-dependencies groups

To eliminate the ambiguity: these are not dependency groups, but extras. Dependency groups are a separate concept that basically standardize what pip's requirements files solve across the ecosystem through PEP 735. They are exposed to project contributors (those who work with Git checkouts, usually).

The line:
dev = ["package[test,tools]"]

Declares "a dependency of this package is package with extras test,tools".
That makes the package package a dependency of `package. I don't think that this should be considered valid input.
I understand the intent of wanting to specify that an extra depends on other extras, but that's not what this syntax means, and not how pip will interpret it.

The line:
dev = ["package[test,tools]"]

Declares "a dependency of this package is package with extras test,tools".
That makes the package package a dependency of package. I don't think that this should be considered valid input.
I understand the intent of wanting to specify that an extra depends on other extras, but that's not what this syntax means, and not how pip will interpret it.

@WhyNotHugo I think, pip started supporting this at some point, but it's tribal knowledge. Hynek said it's since pip 21.2: https://hynek.me/articles/python-recursive-optional-dependencies/. The change log does not call it out explicitly, though: https://pip.pypa.io/en/stable/news/#v21-2. It's not really documented prominently anywhere: https://github.com/pypa/pip/issues/11296. And the maintainers don't even know what enabled the feature: https://github.com/pypa/pip/issues/10393#issuecomment-942771191.
It's supported in pip-tools since v6.13.0: https://github.com/jazzband/pip-tools/issues/1685#issuecomment-1500457061. And uv has it too: https://github.com/astral-sh/uv/issues/1987#issuecomment-1965234484.

Thanks for the clarification. I had no idea. I hope you'll forgive my ignorance, given that the devs themselves didn't even know about it 😂


Dealing with circular references

Say I have two models M1 and M2 that need to query each other. They have no logical relations (i.e. no relationMappings() )
What is the proper objection.js way of handling this circular dependency? Right now I'm dropping down to doing knex queries, so I don't have to require M1/M2, but that doesn't feel right :)
Thanks,
Sebastian

There is no objection.js way. This is not objection's problem if you don't use relationMappings. You have this problem with any two modules that require each other. The solution is to understand what is happening and change the order of the require calls accordingly. I cannot help you without seeing the code. Could you post it here?

Usually you can solve this by moving the require after you set the export value in one of the files.

If you use ES6 modules and import you can probably use the dynamic import await import() inside the function.

@koskimas - thanks for the feedback. I'll have a look at your suggestions.
I don't have a concrete example to share with you, but my reasoning is that one model that needs to lookup up stuff in another model, and the other way around (which is a pretty common scenario in any relational model), will sooner or later run into a circular ref. So I'm just checking if there is a best practice when using objection.js (apart from relationMappings).
If I DO set up a relationMappings between M1 and M2, what is the correct way to get to the M1 class from M2? E.g.:
class M1 extends Model
// ...
static get relationMappings() { /* M2 ... */ }

static someQueryOnM2() {
  // what do I do here to get the equivalent of:
  M2.query()...
  // through relationMappings ?
}

Thanks :)

Aside using ES6 import(), I previously lazy loaded all models, so by example:
// models/ModelOne.js
const ModelTwo = () => require('./ModelTwo')
class ModelOne extends objection.Model {}

// models/ModelTwo.js
const ModelOne = () => require('./ModelOne')
class ModelTwo extends objection.Model {}

// index.js
const ModelOne = () => require('./models/ModelOne')
ModelOne()
  .query()
  ...

These days I stuff a Map which acts as a registry which I monkey patch onto objection lib.

@sebbarg What I meant was that objection doesn't offer any solutions for this problem since it is a fundamental programming problem and has absolutely nothing whatsoever to do with objection, or any library in existence for that matter.

@fl0w 's example of lazy loading is one solution. Here's another:
class M1 extends Model
// ...
static someQueryOnM2() {
  const M2 = require('./M2');
  // what do I do here to get the equivalent of:
  M2.query()...
  // through relationMappings ?
}

Here's another:
// allModels.js

// Don't reassign the exports object. The whole reason this solution works
// is that we use the original `exports` object.
module.exports.M1 = require('./M1');
module.exports.M2 = require('./M2');

// Don't destructure or get the `M2` value here. The whole reason this solution
// works is that we use the original `exports` object.
const models  = require('./allModels');

class M1 extends Model
// ...
static someQueryOnM2() {
  models.M2.query()...
}

@koskimas good stuff, thanks!

Babel + default exports / imports solve this problem also because babel transpiles the code to look like the example above.
import M2 from './M2';

class M1 extends Model
// ...
static someQueryOnM2() {
  M2.query()...
}

actually gets transpiled into something like this:
const _M2 =  require('./M2');

class M1 extends Model
// ...
static someQueryOnM2() {
  // `default` is the property Babel generates when you use `export default`
  _M2.default.query()...
}


Create without xib or storyboard?

Is it not possible to create this class like the following:
let rootController = MySwipableTabBarController();
UIApplication.shared.keyWindow?.rootViewController = UINavigationController(rootViewController: rootController);

@sbrioux can you add a more detailed description? Are you getting an error/crash? an empty screen?

Currently you can't even compile because there is not init() constructor in the SwipeableTabBarController class.  Has to use the init(coder aDecoder: NSCoder) method.
The MySwipableTabBarController is basically:
import SwipeableTabBarController;

class MySwipeableTabBarController: SwipeableTabBarController {

    private var oneVC = OneViewController()
    private var twoVC = TwoViewController()
    private var threeVC = ThreeViewController()
    private var fourVC = FourViewController()

    override func viewDidLoad() {
        super.viewDidLoad()
        delegate = self;

        // Add the controllers to the tab bar
        oneVC.tabBarItem = UITabBarItem(title: "One", image: #imageLiteral(resourceName: "one"), tag: 0);
        twoVC.tabBarItem = UITabBarItem(title: "two", image: #imageLiteral(resourceName: "two"), tag: 1);
        threeVC.tabBarItem = UITabBarItem(title: "three", image: #imageLiteral(resourceName: "three"), tag: 2);
        fourVC.tabBarItem = UITabBarItem(title: "four", image: #imageLiteral(resourceName: "four"), tag: 3);
        let tabBarList = [oneVC, twoVC, threeVC, fourVC];
        viewControllers = tabBarList;
}

However, currently you can't build because of the line
let rootController = MySwipeableTabBarController()

Get the error:
Missing argument for parameter 'coder' in call

@sbrioux Good catch! I forgot to make the initializer public on SwipeableTabBarController. A fix has already been deployed on release 1.0.14

Not sure if it's a side effect or not but now trying to use any of the following methods crashes the application:
Inside the viewDidLoad:
setSwipeAnimation(type: SwipeAnimationType.sideBySide)
setDiagonalSwipe(enabled: true)

As well the swipe gestures don't seem to work until a tab is selected from the bottom.

Sorry for that @sbrioux I made a better fix and tested it :). There's a new release.


How to embed a video into a webpage using HTML and CSS

Proposed title of an article
How to embed a video into a webpage using HTML and CSS.
Introduction paragraph (2-3 paragraphs):
Embedding is incorporating videos, images, GIFs, links, or other social media contents like Electronic books (pdf or HTML files), tweets, Scribd, etc. into web pages or any other social media posts.
Embedding allows you to lend a video from a different platform to another one without worrying about any compatibility issues like dissimilar software versions or formats.
Embedding has various terminologies depending on the context is being used. For instance, embedding in computing is merging both software and hardware computer components to execute a highly tailored task.
Key takeaways:

What is embedding or generally video embedding?
HTML or HTML5.
Advantages and Disadvantages of embedding.
Embedding using URL.
How to embed videos from video sharing website.

References:
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Hello

@annwawesh my apologies for the delayed reply - please always refer to contacting me via Slack - for a quicker response 👍

sounds like a cool topic - approved @annwawesh

merged


Include Screenshots of Views

Include screenshots reflecting the resulting view after code samples/examples for each available View.
At an early stage, this will give new developers (to this package)  a preview on how a specific View (control) looks like without the need to code/build.

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin Community Toolkit. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI Community Toolkit is the replacement for Xamarin Community Toolkit and its documentation can be found here.


network/VR: fix dhcp/password/metadata issues on shared networks with multiple subnets

Description
This PR fixes #4943
This PR contains two changes
(1) assign ip in new subnet as alias of guest IP in first subnet.
If there are free IPs in first subnet, cloudstack acquires a IP from them as alias, which is obviously wrong(dhcp does not work).
Java code changes in this PR fixes it.
(2) add missing iptables rules for port 80(apache2/metadata) and port 8080 (password server).
The rules are added in python but not applied in VR, which cause password server and metadata/userdata not work in new subnet.
Python code changes in this PR fixes it.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Trillian test result (tid-660)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52807 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5013-t660-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-659)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57177 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5013-t659-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_isolate_network_FW_PF_default_routes_egress_false
Failure
272.24
test_routers_network_ops.py

test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
Failure
310.15
test_routers_network_ops.py

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
Failure
307.80
test_routers_network_ops.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
423.80
test_vpc_redundant.py

@NuxRo @ccycv @Spaceman1984 @rhtyd
this PR is ready for review and testing !

Great, once is released I will update the ACS and test.

Trillian test result (tid-659)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57177 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5013-t659-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:
Test	Result	Time (s)	Test File
test_02_isolate_network_FW_PF_default_routes_egress_false	Failure	272.24	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	Failure	310.15	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	Failure	307.80	test_routers_network_ops.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Failure	423.80	test_vpc_redundant.py

@rhtyd I will address test errors above.

@NuxRo @ccycv @Spaceman1984 @rhtyd
this PR is ready for review and testing !

Great, once is released I will update the ACS and test.

@ccycv there is a easy way to test it.
(1) log into existing VR
(2) open /opt/cloud/bin/configure.py , add new line
                               ("ip_aliases",        {"process_iptables": True,  "executor": []}),

(3) stop/start a vm, or create a new vm. the rules in VR will be reprogrammed.
(4) password and userdata/meta-data should work.

I'll test

I created a basic network with multiple IP ranges with different CIDRs and I am not able to create more instances after the first range is exhausted. Not sure if this PR is meant to address this issue.

I created a basic network with multiple IP ranges with different CIDRs and I am not able to create more instances after the first range is exhausted. Not sure if this PR is meant to address this issue.

@Spaceman1984 which branch did you test ? can you share some error logs ?

I created a basic network with multiple IP ranges with different CIDRs and I am not able to create more instances after the first range is exhausted. Not sure if this PR is meant to address this issue.

@Spaceman1984 which branch did you test ? can you share some error logs ?

Are you sure that the VR IP is not used by any of those VMs?

The VR addresses are
Guest IP Address
<IP_ADDRESS>
Link Local IP Address
<IP_ADDRESS>

Ranges are

IPv4 Start IP | IPv4 End IP | IPv6 Start IP | IPv6 End IP | Gateway | Netmask |
-- | -- | -- | -- | -- | -- | --
<IP_ADDRESS> | <IP_ADDRESS> |   |   | <IP_ADDRESS> | <IP_ADDRESS> |
<IP_ADDRESS> | <IP_ADDRESS> |   |   | <IP_ADDRESS> | <IP_ADDRESS>

The VR addresses are
Guest IP Address
<IP_ADDRESS>
Link Local IP Address
<IP_ADDRESS>

Ranges are
IPv4 Start IP	IPv4 End IP	IPv6 Start IP	IPv6 End IP	Gateway	Netmask
<IP_ADDRESS>	<IP_ADDRESS>	 	 	<IP_ADDRESS>	<IP_ADDRESS>
<IP_ADDRESS>	<IP_ADDRESS>	 	 	<IP_ADDRESS>	<IP_ADDRESS>
VMS are using <IP_ADDRESS> and <IP_ADDRESS>

Investigated with @Spaceman1984 , this looks like a primate UI bug.
podid is passed in legacy UI, but not passed in primate UI, when create vlan ip range.

Tested LGTM


Add client autogenerated key for share

Add client autogenerated key for share code live between 2 clients

added via client side


Exception thrown in the example: Message handler encountered an exception System.InvalidOperation exception

Hello,
I followed the same steps in the tutorial yet I got the error in the screenshot. The piece of code that throws this is this:
await queueClient.CompleteAsync(message.SystemProperties.LockToken);

Can you please advise what should I do? Especially that I learn how to use Service Bus in order to include it in our business application.
Thanks,
Nabil

@nblx2k4
Thanks for your feedback! We will investigate and update as appropriate.

Hi @nblx2k4 Could you provide us with the URL of the documentation that you following?

Hi @nblx2k4 Since we haven't heard back, we will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Correct reward per episode values from PPOSGD

PPOSGD rollouts currently aren't sliced into individual episodes before being fed into the predictor. This makes our episode calculation incorrect

We have a couple options:

Change the rollout behavior of PPO to match what we do in TRPO
Correct the episode calculation logic in the predictor to handle paths that have multiple episodes

I currently think that 1 would be a better option. This would also be an opportunity to parallelize the traj_segment_generator like we do in parallel_trpo, giving us improved performance.
Interested in your thoughts here, @Raelifin

Fixed by cutting PPO rollouts into episodes


Accelerate: The Science of Lean Software and DevOps: Building and Scaling High Performing Technology Organizations

I've reached page 100


Fix sizehint deprecation on julia 0.4

Coverage increased (+0.02%) when pulling 0c31538c3aee4ae8087aaf03d9fee00ac1da5bcf on timholy:pull-request/0c31538c into c9b431737f9992224cac980e6e4e6a5a9923017a on JuliaLang:master.

Oops, I duplicated this in #162.


Add options for Content options

is there any way I can choose to overwrite content for the deploy?

Hi fjhixiuxiu,
This is currently not available for the plugin. I will add it to our backlog.
Thank you


Revert "feat: add --serialize-image-pulls flag to kubelet config flag…

…s (#4815)"
This reverts commit 81c450d06f1e5778b9dd86436a2186da7f428074.
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 71.005%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.04%

Covered Lines:
2564

Relevant Lines:
3611

💛  - Coveralls


Fix bug where cart can not be got or created when user has multiple carts

The checkoutCreate or checkoutCustomerAttach could create multiple checkouts for a same user. Then get_or_create_user_cart will raise saleor.apps.checkout.models.Cart.MultipleObjectsReturned: get() returned more than one Cart error since it can not handle this case. This PR fixes this issue.
Pull Request Checklist

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] Database migration files are up to date.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] GraphQL schema and type definitions are up to date.
[x] Changes are mentioned in the changelog.

@jxltom Could you provide steps to reproduce the issue?

Sure, I created an issue for tracing that https://github.com/mirumee/saleor/issues/3728.

Continued in #3761.


python311Packages.griffe: 0.34.0 -> 0.35.0

Diff: https://github.com/mkdocstrings/griffe/compare/refs/tags/0.34.0...0.35.0
Changelog: https://github.com/mkdocstrings/griffe/blob/0.35.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251226 run on x86_64-linux 1

1 package marked as broken and skipped:

netbox_3_3

9 packages built:

griffe (python310Packages.griffe)
griffe.dist (python310Packages.griffe.dist)
netbox
python310Packages.mkdocstrings-python
python310Packages.mkdocstrings-python.dist
python311Packages.griffe
python311Packages.griffe.dist
python311Packages.mkdocstrings-python
python311Packages.mkdocstrings-python.dist


Java style comments are invalid in .sql files

A sample - https://github.com/cloudspannerecosystem/machmeter/blob/3e04ab4b6face17a1126fd2a0ff03fcec6946056/machmeter/usecases/entertainment/movies-database/templates/schema.sql#L1
This results in errors like -
eb 22, 2023 8:46:12 AM com.google.cloud.machmeter.Orchestrator executeOrchestrator
INFO: Plugin infraSetup completed.
Feb 22, 2023 8:46:12 AM com.google.cloud.machmeter.Orchestrator executeOrchestrator
INFO: Executing ddlPlugin plugin.
/*
 * Copyright 2022 Google Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License")

Error executing: /*
 * Copyright 2022 Google Inc.

Already fixed


no runs

I'm using the badge in my repository https://github.com/elgohr/cf-jetbrains-license-server
Sadly the badge shows "no runs" since ever. When you click on the badge, you get to the successful build.

I wonder if it's cached in your browser? It's not doing that on mine. Can you try an incognito window? I recently pushed a new cache update so I wonder if that fixed it.

This also happens in incognito mode. I also disabled the cache in Firefox (65.0.1).

That is so weird. It's showing success for me:

Honestly not sure how to fix this. We're serving ETags now and no-cache headers. Honestly I'm going to have to call this weird github/browser caching.

Same here, thank you!


Improved PopupMenu visuals. Removed x-y margin, made it 'padding' instead

Improved look as per discussion in #45607
Helps modernise the UI. If you take a look, most applications I have tested have a margin on top and bottom, and little/none on the sides. The item highlight goes all the way across, and there is some padding on either side.
Before:

After:

Maybe smaller vertical paddings on the popup itself, so that it looks like the same spacing is between the border and an item as there is between items?

Does this change things for PopupMenu used in game?

Can you show a screenshot on how it looks with the scrollbar?

This looks better but a little bit wider. Though, our popups are already big, so maybe less padding would be good?

@akien-mga Yeah, it will. The padding is currently calculated from the margin container vertical margin. Counter intuitive maybe, but it's just so that it all meshes together and there are no hardcoded values. A custom constant could potentially be made for item_left_padding and item_right_padding if that seems better.
@YeldhamDev

@groud @YeldhamDev @akien-mga
I changed the setup to use custom theme constants. I toned it down for the editor, as below.

Users can easily edit it via themes now - the default is small, only 2px (also shown in the below gif). NOTE that Window, and thus PopupMenu, although they do support get_theme_constant, etc, do NOT allow for overrides so currently this can only be done through a custom theme resource.

The padding/margin above "Version Control" is bigger than below. Probably because the seperator has an asymetric margin. Not a big deal, but i think it's nicer if the margin is the same top and bottom.

Once rebased, this should probably be good to go. Maybe also addressing the comment above?

All done

Thanks!


Documentation

There is a documentation mistake in the readme file. Can I improve it?

Send across a PR

There are some typo and documentation mistake in the readme file. please assign it to me so that i can contribute under GSSOC'24.

PR is sent.


Workflow: Add "Help" and "How It Works"

Adding "Help" and "How It Works" in Skydive Workflow in-order to make it more generic and user-friendly.

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch


Enable extension-specific proxy settings

Support extension-specific proxy settings (don't rely on http(s)_proxy).
Support using a unix domain socket as a proxy.
Add a CA cert setting to enable using proxies with self-signed or not-public certificates.
Closes CODY-3092
Test plan
To test locally:

Install socat and mitmproxy (brew install socat mitmproxy)
Switch to this branch: git switch peterguy/vscode-add-proxy-settings
In one terminal, start up socat to listen on a UDS and send TCP connections to mitm

socat -d -d unix-listen:${HOME}/mitm-proxy.sock,fork tcp:localhost:8080

In another terminal, launch mitmproxy. I like to use mitmweb because it opens a web view of the traffic that is friendly.

mitmweb

Add the following to VSCode's settings.json (It's at ~/Library/Application Support/Code/User/settings.json for me; you can also get to it by opening the Command Palette (Cmd-Shift-P), typing "settings" to filter, then selecting "Open User Settings (JSON)".

"http.proxySupport": "on",
"cody.proxy.path": "~/mitm-proxy.sock",
"cody.proxy.cacert": "~/.mitmproxy/mitmproxy-ca-cert.pem"

In addition to specifying proxy settings for the Cody extension, it also toggles VSCode's proxy support from override to on. If it's in the default override mode, it won't use the proxy agents we set up. I'd like to avoid this requirement, but until we figure out how to do that (probably with more "monkey patching", to quote @RXminuS 😄 ), we have to toggle the proxy support to either on or fallback.
5. Launch the Cody extension via the Run And Debug pane (Cmd-Shift-D), by clicking the green "play" icon at the top of the pane, when "Launch VSCode Extension (Desktop, recommended)" is selected (it's the default).
6. Note the outputs of socat and mitmproxy in the two terminals, and if you launched mitmweb, see the requests in the browser. If you are using mitmweb you can use the web interface to see the types of requests being made.
7. Execute a completion. I used Document Code as a simple triggerable one. If you launched mitmweb and are using a non-local LLM model (not Ollama), you should see calls to the completions endpoint in the mitm web page.
8. Optional: change the proxy settings to use mitmproxy directly. Remove the proxyPath setting and add proxyHost and proxyPort:
"cody.proxy.host": "localhost",
"cody.proxy.port": 8080

Then verify again that the extension is still operative. You should still see activity in the terminal that's running mitmproxy (or mitmweb), and the mitmweb web page should show more traffic, but there should be no activity in the socat terminal.

@peterguy @RXminuS This is an interesting new addition to the proxy space but I wanted to add that its entirely possible certain edge cases be not covered by this.
We would also test all the cases with this google sheet just to extra sure that this actually works. I think using Fiddler Mitm etc is fine but we have sourcegraph based proxies too so using those could also be helpful just to be extra certain.
Aside from what rik already pointed out about the keep alive stuff.  We also had a long long history of changes around this as mentioned in this PR . We did use proxy agent before but then caused more issues so we reverted it although perhaps it might be okay to use it just for your case coz pnpm update-agent-recordings  worked fine.
You can read the whole history here  and if the PR still concedes I am happy to do a deep dive by manually running all the cases etc. There's other issues also with the proxy stuff like the ability to load local windows certs and self signed certs loading being specifically an issue(You are very likely fully aware of all of these).
I am sure you have probably covered many to almost all of these but maybe not ALL of these and that's my concern(Unless you do in-fact cover all of the cases atleast for now).
So a question for you both(Rik and Peter):

If we were to use ProxyAgent library mainly for the proxy stuff then what if we face the same issues as before?
Would it be feasible to wait for Rik's solution here for the stripe thing also?

@arafatkatze this affects VSCode. Do you have a setup where you can test on Windows? I'm working on getting a dev environment set up in Windows, but if you have a setup already, it'll be faster to test.

@peterguy When I tested proxy stuff on Windows I would just make the VSIX File(in my macbook environment) by

cd vscode
CODY_RELEASE_TYPE=stable pnpm release:dry-run

This would make a cody.vsix file in cody/vscode/dist directory and then I would take the file to windows and install cody from that vsix file in Windows to test stuff. So basically I didn't have to deal with any of the dev setup in windows.

I assume you do already have a windows machine so that should help out with the rest and you probably don't have to worry about the licensing stuff etc?
Also as for the real testing I only just used [this website](https://devproxy.sgdev.org/) for proxies so that would cover the cases?

IS that something that would work for you? Or are you perhaps looking at a more complex setup with some sort of packet capture etc?

Moved to #5883


Text annotations not rendered

File: https://drive.google.com/open?id=0B6YhVF9p-y2Ad3VsWDRHRkRxY2c
Using latest demo viewer with Chrome, Safari, Firefox on OS X 10.10.4
No text annotations were rendered by PDF.js.
This is how it look like in OS X Preview

And OS X Adobe Acrobat Reader DC

PDF 110dd61fd57444010b1ab5ff38782f0f [1.4 pdfeTeX-1.21a; modified using iText® 5.5.6 ©2000-2015 iText Group NV (AGPL-version) / TeX] (PDF.js: 1.1.326 [WebGL])

According to http://brendandahl.github.io/pdf.js.utils/browser/, all annotations have Subtype = /FreeText.

/FreeText is not completely implemented yet. https://github.com/mozilla/pdf.js/blob/master/src/core/annotation.js#L285 seems to indicate it is not implemented at all, but I have seen some examples that do render.

This is now tracked in #6810.

Has the problem been solved? I ran into the same problem. I used iText5.5 to add annotations to PDF that Google Browser can`t see


Add CI

linter
test
coverage reports

above list is done by fb50ca0c5aed4144e2014a3dc424adcaaad383c5
should add some publish workflow

above list is done by fb50ca0c5aed4144e2014a3dc424adcaaad383c5
should add some publish workflow


Add property to TransactionId which returns the hash of the transaction as sent to the network

Getting the hash of a transaction is the responsibility of a client using the SDK. It would be useful to integrate this capability in the SDK such that the SHA-384 hash of the bytes sent to the network are available as a property of the TransactionId entity returned after the call is executed.

Currently this is supported through the TransactionResponse class since it returns both the TranasactionId and the hash of the transaction that was sent. Even though this question was for v1 of the SDK, and v2 is the SDK that has resolved this issue I'm still going to mark it closed.


Don't show "Don't ask me again for this token on any website" when the asset is ether

It's resolved in boost-component and will be resolved soon in add-link.


Python OverflowError when binaryview length is >= 0x8000000000000000

When a binaryview length is over 0x8000000000000000 it subtly breaks the python api (and prevents some plugins from being used). Whenever the __len__ method is called it triggers a python OverflowError. This situation can occur in binaries such as coredumps where the mapping for vsyscall is present and vsyscall is at the far end of the address space.

binaryview_len_bug.zip

Here is an explanation for what is happening: https://stackoverflow.com/a/4754427.
It turns out that we should not use len to return the length of the binary view. In Python, len returns the number of elements in a collection, e.g., a list. The semantic is different here. Maybe we should just have a length attribute on BinaryView. We also need to check the whole Python API to look for similar issues.

...  def __len__(self):
...   return 0x8000000000000000
...
>>> len(Foo())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: cannot fit 'int' into an index-sized integer

This is a limitation of Python and really has nothing to do with BinaryNinja. We need to deprecate the usage of len(BinaryView)

I think besides any plugins, the only places we need to change are:
API:
https://github.com/Vector35/binaryninja-api/blob/5435b69c1e109d275a2cff4e4249b6dea7c383b2/python/fileaccessor.py#L51-L54
https://github.com/Vector35/binaryninja-api/blob/dev/python/binaryview.py#L1365
https://github.com/Vector35/binaryninja-api/blob/dev/python/binaryview.py#L1416-L1422
https://github.com/Vector35/binaryninja-api/blob/dev/python/binaryview.py#L1445-L1452
Test related:
https://github.com/Vector35/binaryninja-api/blob/dev/suite/testcommon.py#L424
https://github.com/Vector35/binaryninja-api/blob/dev/suite/api_test.py#L160
https://github.com/Vector35/binaryninja-api/blob/dev/suite/api_test.py#L174
I would note that having len() on a raw file view probably /does/ make sense.

For reference, Python decided this is a wontfix https://bugs.python.org/issue21444

This issue is addressed in 2.4.3000

Fixed again https://github.com/Vector35/binaryninja-api/commit/683b07bba5adad52811c324725ebce783ad3ec84


Does not work when the registry is using self-signed certificates

I'm running an API v2 registry and wanted to use this UI for it.
The registry is configured to use self-signed ssl certificates for the TLS setup.  When I fire this frontend app, it does not list the repositories on the registry.
I'm using these arguments to the docker run command
-e ENV_DOCKER_REGISTRY_HOST=<IP_ADDRESS> \
-e ENV_DOCKER_REGISTRY_PORT=5000 \
-e ENV_REGISTRY_USE_SSL=1

Is there anything else I need to make this work?  I couldn't find any reference to using this setup on the documentation.

First of all, thank you for your comment.
This is a saved reply. There have been numerous questions like yours and I highly recommend that you take a look at the example-setup directory. It contains a README on how to set up a registry with a backend and it contains a ready-to-use docker-compose.yml file for you to run.
I sorry but I cannot help with every setup request coming in. If you find out something that wasn't documented well enough, please contribute back and open a pull request with your changes to the documentation.
Thank you!


Inconsistency on the theme on different screens

As you can see left side on the desktop monitor view
right side latop view

@sanjay-kv
i would like to work on this issue

@dhruv8433 Im wondering were you be able to fix it?

Hey @sanjay-kv
I am unable to find that page in code index.html

@dinxsh


Support for Arrays in ApiPlcProgramData

The ApiPlcProgramData should create the Children when ArrayDimensions are set (that's why the order is of value 1 => last information).
Either the Children Array should be filled (should the "Has_children" be set (prob. not)) or another List "ArrayChildren" or maybe "ArrayElements" should be filled (since its different to the "normal" children (it's not (necessarrily) a struct - it's an array!)...

pro using Children:

The implementation for the Children will also suit the array children (prob.)

tendency is to still use ArrayElements since has_Children false with Children.Count != 0 seems weird,
Also children are set by browse for struct - arrayelements will be set by arrayDimensions.


Wait for out instead of regular_input

The test is supposed to ensure that out builds before validation_input.
For #102

Whoops 😬


Translate Module 2. Exploring and Comparing different LLMs

Is your feature request related to a problem? Please describe.
People benefit from reading content in their own language
Describe the solution you'd like
Module 2 translated to Spanish language
Describe alternatives you've considered
.
Additional context
.

This issue has been closed (manually) by the successful merge of PR #21


Clean up some leftovers from the alarms removal.

Removes some unused records and their respective documentation.

[approve ci autest]

[approve ci autest]

[approve ci autest]

[approve ci autest]

[approve ci fedora]


Fix CI

I silenced the funlen check and avoided the global variable.

Redoing on top of renovatebot PR.


CB-17388 Fix infinite loop in case of custom image not found and disable change catalog for custom image catalog

See detailed description in the commit message.

This should be 2.57.0 since it is broken on prod as we speak.


[BUG] Groupby requires groupby_cols in column selector

Describe the bug
Grouby requires gropuby_cols to be present in column selector. Reading the tests, my understanding is that if you don't include groupby_cols in column selector the op should run and the groupby_cols will not be included in the output?
Having gropuby_cols in output is problematic. You might start having numerical columns mixed with ones indicating a category and that renders many downstream nvt operations that you might want to perform on the output of Groupby impossible.
I created a PR that demonstrates this issue in a test and maybe can be helpful for working on this. #1598
Steps/Code to reproduce bug

import nvtabular as nvt
import cudf
import numpy as np

df = cudf.DataFrame(data={
    'product_id': list('abbcc'),
    'sales': np.random.randint(0,10,5),
})

out = ['product_id', 'sales'] >> nvt.ops.Groupby(groupby_cols=['product_id'], aggs='sum')

ds = nvt.Dataset(df)
wf = nvt.Workflow(out)

o = wf.fit_transform(ds).compute()
o

Expected behavior
Running Groupby without groupby_cols in column selector doesn't include gropuby_cols in output and the operation runs as intended.
Environment details (please complete the following information):
nvcr.io/nvidia/merlin/merlin-tensorflow-training:22.05, current main

Just to provide a bit more background on the above, the test that I added currently fails, but I believe it should run, that would be the desired outcome.
We even have a test for this scenario that tests that this works on the schema side of things, but doesn't work when actual calculations are run.
def test_groupby_selector_cols():
    input_schema = Schema(["name", "id", "ts", "x", "y"])

    # Include the groupby col in the selector
    groupby = ColumnSelector(["name", "id", "ts", "x", "y"]) >> ops.Groupby(
        groupby_cols=["name"],
        sort_cols=["ts"],
        aggs={
            "x": ["list", "sum"],
            "y": ["first", "last"],
            "ts": ["min"],
        },
        name_sep="-",
    )
    workflow = Workflow(groupby).fit_schema(input_schema)

    # If groupby_cols are included in the selector, they should be in the output
    assert "name" in workflow.output_node.output_schema.column_names

    # Don't include the groupby col in the selector
    groupby = ColumnSelector(["id", "ts", "x", "y"]) >> ops.Groupby(
        groupby_cols=["name"],
        sort_cols=["ts"],
        aggs={
            "x": ["list", "sum"],
            "y": ["first", "last"],
            "ts": ["min"],
        },
        name_sep="-",
    )
    workflow = Workflow(groupby).fit_schema(input_schema)

    # If groupby_cols aren't included in the selector, they shouldn't be in the output
    assert "name" not in workflow.output_node.output_schema.column_names

The reason this is problematic is that because of groupby_cols being included in the output, there is a lot of ops we might want to run on the output of Groupby that we are unable to. The big case here is feeding data to a NN (any of the Merlin Models). In order for the NN to function well, we would need to first normalize the input data. But looking at even the example I included above, we cannot do this, because the workflow would try to attempt to normalize product_id as well and would fail.

@radekosmulski , please triage your bug with severity and priority


RLayerWMTS fetches the wmts file twice

The RLayerWMTS always fetches the WMTS file twice when added to a map.
This is also visible in the Reprojection example which uses a wmts layer.

As a workaround and to implement global caching I reimplemnted  RLayerWMTSCached class, unfortunately I had to duplicate the createSource() method.
https://github.com/mmomtchev/rlayers/blob/2ba67c817e0a6f2055d536b6e3654ab4c298140b/src/layer/RLayerWMTS.tsx#L44
My workaround:
export default class RLayerWMTSCached extends RLayerWMTS {
  protected fetchSource(url: string) {
    if (!(url in CACHED_WMTS)) {
      CACHED_WMTS[url] = fetch(url).then((r) => r.text());
    }

    return CACHED_WMTS[url];
  }

  protected createSource(): Promise<SourceWMTS> {
    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
    // @ts-ignore
    return this.fetchSource(this.props.url)
      .then((text) => {
        const caps: unknown = this.parser.read(text);
// … duplicated code

It would be nice to have a separate method like fetchSource(url: string) that could be used to override the fetching with custom logic.

Are you sure this happens in production mode? React refreshes the component in dev mode on purpose - to make sure that everything works correctly.

@mmomtchev Yes, in the dev mode is fetches the WMTS four times.
I verified it with our own application, the same happens on the rlayers examples (I assume these are not running in dev-mode either)

In case you haven't seen my profile, I am currently living on social welfare because an ex-employer is extorting me with the help of the French police and the French judiciary over a series of false judicial proceedings, including some very serious allegations, in order to cover up his intimate personal problem. In order to further intimidate me, people are simultaneously posting on my projects. Yours is one. You don't happen to know anything about this affair?


Fix to enable building with STATIC_UNROLL=1.

This small patch allows staghmc_spv target to build with the environment setting STATIC_UNROLL=1.

Thank you! I've accepted the pull request.


VSCode plugin: package manager option seems to be ignored

I have a workspace in which I installed the required packages globally via yarn, and no matter what I set tslint.packageManager to in my settings, it would not work, and I would get error messages about installing with npm.  Globally installing with npm fixed my problem, but it seems like that shouldn't be necessary given that there seems to be logic for locating the global package directories for yarn and pnpm as well.
While trying to debug this, I happened to notice that several configuration options are not included when runTsLint is invoked in plugin.ts.  I'm not sure if this omission is intentional, but I think that passing through the packageManager option here would solve the problem.

Good find. Should be fixed in 0.5.4 by 071ebb724b1765a3d1295454f157bf96bfcb9cc8


[ART-7542] fix SSL, add localhost <IP_ADDRESS> to ALLOWED_HOSTS

ref https://issues.redhat.com/browse/ART-7542

Following model https://github.com/openshift-eng/ocp-build-data-validator/pull/93/files

/lgtm


Response contentType always follows Request

I have an endpoint that receives formdata as request and returns application/json as response.
If I set type of endpoint to formdata, the swagger documentation automatically receives response as formdata as well.
It would be better if there's way to set the contentType of response

Same here! any news ?


alloc feature works with no_std

Hi. Unfortunately, this crate doesn't build in no_std-contexts when the alloc-feature is used. There is no technical reason for this limitation. Furthermore, even custom kernels can use things that need alloc, if you provide a custom global allcoator. (I did some kernel development with Rust; I can confirm).
Github CI needs an update to check the no_std-build as well. I recommend the two following commands for the CI (I do it in my own projects):

$ rustup target add thumbv7em-none-eabihf (install some no_std target)
$ cargo build --target thumbv7em-none-eabihf
(cargo test will not work, because the crates std and test are not available for thumbv7em-none-eabihf)

I didn't include it in this PR, because I'm not that familiar yet with the github CI yaml syntax and the workflow file of this project looks different to the ones I'm used to.

Thanks for the PR! This must have slipped through.
However, I thought that test required std, as it gives the following error when I try to run cargo test --target thumbv7em-none-eabihf if however this is not the case I would of course like to add testing for no_std.

In the end I could also just add building the crate to the CI but if testing is possible this would of course be preferred.

In my understanding, no_std-targets (such as the embedded ARM targets) are not meant to execute tests, because the test-crate itself depends on std. Therefore, tests are always executed with a "fully-fledged" target and the no_std-check is just a cargo build --target <some_no_std_target-execution. I do it in all my no_std-projects the same way. @NULLx76

Any update here @NULLx76 ?

Oh yeah sorry, forgot about this :sweat_smile:, I've added the CI and will merge

and now published under 0.8.4 on crates.io: https://crates.io/crates/ringbuffer/0.8.4


NEXT-7222 - Issue with listing, minimum quantity and quantity pricing

Description
There is no relation between pricing, minimum quantity, and price shown in the listing.
You can define a product as follows :
Minimum quantity : 5
Pricing

Minimum qty
Maximum  qty
Price

10
20
$10

20
50
$9

50
infinity
$6

Shopware will allow us to save product with above setting.

This will break the following

Listing page will always try to search for the price of 1 quantity which will be empty in the above case
User cannot order minimum quantity since the price for minimum quantity is not defined

Possible Solution

Make a connection between minimum quantity and pricing, that there should be pricing entry for minimum quantity.
In the listing, instead of trying to find the price for quantity 1, search for the price for the minimum quantity

Additional context

Issue can be recreated by changing quantity of pricing to more than 1 for any product and see the listing of the category of that product.

Hello,
thank you for creating this issue.
I have opened a ticket on our Issue Tracker for you. See the ticket link: https://issues.shopware.com/issues/NEXT-7222
Please use this ticket to track the state of your issue.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37874.
[created from NEXT-37874, comment 488530]


Subscriber filtering on API Publisher does not work as expected

Description
There is a filtering issue with subscriber names not getting populated in the filter dropdown.
Steps to Reproduce

Create an API and subscribe to it with many applications created by different users.
In Publisher, navigate to Relevant API > Portal Configurations > Subscriptions> Manage Subscriptions

Affected Component
APIM
Version
4.2.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
APIM-4.2.0

Hi all,
Closing this since the corresponding U2 update was released.
Thanks!
Dulith


Tag 1.0 release

Since we're going to be changing this tool and we have potentially many invocations each day that we'd like to not break. We're going to create stable tags and change our deployment to use those stable tags while we're doing development work

I think it's working well to deploy directly from master (or main). We shorten the feedback loop if things are broken.


ajinkya made changes

fixed first issue

Thank you @Suyash-Purwar
It's really good to know you put in the time to look into my first issue fixing it was really nice of you.
Thank you 😊

Thank you @Suyash-Purwar
It's really good to know you put in the time to look into my first issue fixing it was really nice of you.
Thank you 😊

No problem mate! 😄

No problem mate! 😄

Thanks for the review @Suyash-Purwar
Thanks @ajinkyak423  for your PR, Welcome to the community!! Goodluck with Open source!

Thanks for the review @Suyash-Purwar
Thanks @ajinkyak423  for your PR, Welcome to the community!! Goodluck with Open source!


Some links are broken in the documentation

I was reading the readme to try to test the nerTagger, and I found that some links in these paragraphs are broken (or at least I cannot access them).
I fixed what I could, but I'm reporting the rest here.
I did not find a better way to just reference the source:
For re-training a model, the CoNLL-2003 NER dataset (eng.train, eng.testa, eng.testb) must be present under data/sequenceLabelling/CoNLL-2003/ in IOB2 tagging scheme (look here for instance ;) and here. The CONLL 2003 dataset (English) is the default dataset and English is the default language, but you can also indicate it explicitly as parameter with --dataset-type conll2003 and specifying explicitly the language --lang en.

For re-training, the assembled Ontonotes datasets following CoNLL-2012 must be available and converted into IOB2 tagging scheme, see [here](https://github.com/kermitt2/delft/tree/master/utilities) for more details. To train and evaluate following the traditional approach (training with the train set without validation set, and evaluating on test set), use:

Thanks you ! this is fixed with 80c4595fe4cd6921de47edee87a368870bd53d8c


chore: finalize fork by changing all import paths

Fix fetch.pb.ts to properly handle gRPC errors.

/m


[CLI] Tensorboard not working in Jupyter notebooks

Description
Running the tensorboard patch in a notebook causes an error that tensorboard is not installed, even when it is.
Wandb features
wandb.tensorboard.patch(save=False, tensorboardX=True)
How to reproduce

Environment

OS: Linux nvcr.io/nvidia/pytorch:20.11-py3
Environment: Jupyter Lab
Python Version: eg. 3.7.10

Nevermind, restarting the notebook fixed this.


fix(strutil.h): ensure proper constexpr of string hashing

The underlying farmhash algorithm (which is the basis for Strutil::strhash, and thus ustring's hash representation) turned out to not be properly constexpr under certain circumstances and needed to be expressed a different way to be fully constexpr on all platforms and for all strings.
New implementation suggested by Alex Wells.
Also, make sure string_view ctr from char* can be constexpr, even for
C++14. This is related for the sake of the strhash calls that, when
taking string literals, actually choose the variety that accepts a
string_view.

@AlexMWells, can you confirm if this totally fixes your problem?

Yes it does fix the issue and allow global constexpr variables and consteval expressions.  Thanks for adding a test by the way.

Updated: Also, make sure string_view ctr from char* can be constexpr, even for
C++14. This is related for the sake of the strhash calls that, when
taking string literals, actually choose the variety that accepts a
string_view.


Fix CMake error

Try to fix this error :
CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "math_utils" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:55 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "trajectories" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:41 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "hqp_solvers" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:56 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "constraints" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:40 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "tasks" links to target "Boost::unit_test_framework" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:46 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "robot-wrapper" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:43 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "contacts" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:49 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "set_gravity" links to target "Boost::unit_test_framework" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:58 (ADD_TESTCASE)

CMake Error at cmake/test.cmake:76 (ADD_EXECUTABLE):
  Target "tsid-formulation" links to target "Boost::unit_test_framework" but
  the target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  tests/CMakeLists.txt:26 (ADD_UNIT_TEST)
  tests/CMakeLists.txt:52 (ADD_TESTCASE)

Ì'd suggest to add those guards on ADD_SUBDIRECTORY(tests) instead of removing them there

Done ^^


Newer Versions do not work with Radiant Gear

Hello, the newer versions of this mod do not work with Radiant Gear, whereas previous versions do.
The last known version to work with Radiant Gear is version 1.60 from 9/1/2023.

Same problem here on forge 47.3.0 1.20.1: https://www.curseforge.com/minecraft/mc-mods/radiant-gear

the old version is very out of date with upstream LambDynLights, so the API has changed. Any mod supporting the old API will need to be updated to support the new one


Mark services as GA or "Preview"

According to this page https://docs.microsoft.com/en-us/azure/app-service/networking/private-endpoint App Service private links are in preview. It is not mentioned on your page. I think it would be nice to have the info on the general page. Otherwise one might get errors like this in Powershell:
New-AzPrivateEndpoint : Operation returned an invalid status code 'BadRequest'
StatusCode: 400
ReasonPhrase: Bad Request
ErrorCode: BadRequest
ErrorMessage: Call to Microsoft.Web/sites failed. Error message: GroupId is invalid.
At line:1 char:20

$privateEndpoint = New-AzPrivateEndpoint -ResourceGroupName $rgName `

               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : CloseError: (:) [New-AzPrivateEndpoint], NetworkCloudException
FullyQualifiedErrorId : Microsoft.Azure.Commands.Network.NewAzurePrivateEndpoint

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b006a616-2f2f-8ecf-8b80-fd0a3cc62090
Version Independent ID: 92c54dc6-8ddf-b1f7-4a58-d61b8cd7fe25
Content: What is an Azure Private Endpoint?
Content Source: articles/private-link/private-endpoint-overview.md
Service: private-link
GitHub Login: @malopMSFT
Microsoft Alias: allensu

@SvenSowa Thank you for catching this. We will have this forwarded to the content authors to review and take action as needed.

@malopMSFT Could you please review this requirement and take action on it as you see fit ?

it's listed here:
https://docs.microsoft.com/en-us/azure/private-link/private-link-overview#availability
https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-overview#private-link-resource
https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns
#please-close


Introduce AsMacroCall trait

This PR introduce AsMacroCall trait to help convert ast::MacroCall to MacroCallId. The main goal here is to centralize various conversions to single place and make implementing eager macro calls without further ado.
pub trait AsMacroCall {
    fn as_call_id(
        &self,
        db: &(impl db::DefDatabase + AstDatabase),
        resolver: impl Fn(path::ModPath) -> Option<MacroDefId>,
    ) -> Option<MacroCallId>;
}

:+1:
bors r+


[SPARK-46834][SQL][Collations] Support for aggregates

What changes were proposed in this pull request?

This PR is part of collation effort. For details please refer to umbrella JIRA ticket with linked designed document.
This PR adds support for Aggregates and GROUP BY against strings with collation.
This PR adds following:

SortAggregate support for columns with collation.
Rule that will force SortAggs in case of non-binary collations.
Tests.
Golden file for collations (which includes basic filters and aggs).

Why are the changes needed?

Please refer to document in JIRA for overall collation effort.
Does this PR introduce any user-facing change?

With this PR users will have proper support for aggregates against strings that are collated with non-binary collations (e.g. UTF8_BINARY_LCASE).
How was this patch tested?

Tests in CollationSuite plus golden file tests.
Was this patch authored or co-authored using generative AI tooling?

Yes.

thanks, merging to master!


Add the ability to set the insertion filter into CLI

Adds tap.insertion-filter field to the configuration of the CLI which allows you to set the insertion filter of Basenine.
The value can be a string which is the filters itself:
$ ./cli/bin/mizu__ tap -n sock-shop --set tap.insertion-filter=http

or a path to a BFL file:
$ ./cli/bin/mizu__ tap -n sock-shop --set tap.insertion-filter=/tmp/example.bfl

example.bfl can be any filter. For example;
Only inserts HTTP or AMQP traffic:
http or amqp

Only inserts when it's HTTP and the response status is 202:
http and response.status == 202

Replaces the value of request.path field with [REDACTED] string before the insertion:
redact("request.path")

@gadotroee for 1 the CLI should programmatically depend on Basenine means that this PR is required https://github.com/up9inc/basenine/pull/11 I'm about to merge that actually so I agree that we need to check against syntax errors on CLI level.
http1 is not a syntax error without macros (with macros expanded it depends) but these are for example syntax errors in any case;
> request.path.= "something"
1:14: unexpected token "=" (expected Expression)
> request.path == "something
1:27: literal not terminated

For 2 I understand we shouldn't panic. So, I'm going to make it log an error instead.

@gadotroee for 1 the CLI should programmatically depend on Basenine means that this PR is required up9inc/basenine#11 I'm about to merge that actually so I agree that we need to check against syntax errors on CLI level.
http1 is not a syntax error without macros (with macros expanded it depends) but these are for example syntax errors in any case;
> request.path.= "something"
1:14: unexpected token "=" (expected Expression)
> request.path == "something
1:27: literal not terminated

For 2 I understand we shouldn't panic. So, I'm going to make it log an error instead.

sounds good.
I will review once those changes will be added.

from this PR the DB files will be called *.db and not *.bin.
we need to be aware of this in cases of upgrade mizu instance because it will not be aware of the files it is looking. (If I understand correctly)

@gadotroee with 5003be4 it will change legacy .bin files to .db files.

Ok sounds good so this will do the "migration" in case you have old data, right?

@gadotroee with 5003be4 it will change legacy .bin files to .db files.

Ok sounds good - so this will do the "migration" in case you have old data, right?

Yeah exactly, it will not destroy the old data.


fix: vendor and data_dir issues for bert-pytorch case

fix vendor for argparser
fix issues for data_dir and train_dir check


[bug]: AttributeError: 'NoneType' object has no attribute 'replace'

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cpu
VRAM
No response
What happened?
When I ran /invoke.sh and choose the CLI, I tried running --prompt "a student studying in a cyber cafe that's orbiting jupiter", and after 50 samples I got the error "AttributeError: 'NoneType' object has no attribute 'replace'", suggesting that the prompt variable was None (see screenshot).
I just setup invoke AI for the first time and got this error, so I'm not sure if I used it wrong?
Screenshots

Additional context
Running InvokeAI 2.2.5
Contact Details
No response

This is happening from the invoke> prompt??

I have found and fixed the bug. The fix will appear in the next release candidate.


Fixes 3463 replace assert with assert that

Description (required)
Fixes #3463
What changes did you make and why?
I replaced all instances of assert() with assertThat() where appropriate.
assertThat() error messages are easier to understand and the assertThat method has a wider range of abilities to determine if the output of a function is appropriate. For example assertThat will not complete compiling instead of failing if the expected input is an integer instead of a string.
Tests performed (required)
Tested AccountUtilUnitTest with Pixel 2 API 30

Closing this as now stale


Reduce size of images in the template

We're sorry, something went wrong.
We were unable to clone minicomp/wax's contents into [...] The template you used includes files that are larger than 10 megabytes. Please ask minicomp to remove those files from the template and try again.

@brimwats a patch for this is in the works. as a sneak peek, the new version of the repo will load the source data from a git submodule so it's not in the demo/theme repo: https://github.com/minicomp/wax/tree/data-from-submodule
does this seem like it would work for your use case(s)?

I still want to pull the original source images into a submodule at some point, but "use this template" seems to be working on GitHub's end now. Closing this issue.


Better Android support

As done here https://github.com/rmtheis/language-detection

language profiles as Java code files
separate Maven modules to cut away the code not required at runtime (to create profiles), and the profiles stored as text files.

Just tried 0.5 on android 'com.optimaize.languagedetector:language-detector:0.5'
I get Caused by: java.lang.ClassNotFoundException: Didn't find class "java.lang.Character$UnicodeScript"when I try to recognize with
    public class Translator {

    private LanguageDetector languageDetector;

    public Translator() {
        try {
            List<LanguageProfile> languageProfiles = new LanguageProfileReader().readAllBuiltIn();
            languageDetector = LanguageDetectorBuilder.create(NgramExtractors.standard())
                    .withProfiles(languageProfiles)
                    .build();
        } catch (IOException e) {
            Log.e("AAA", "ERROR", e);
        }
    }

    public LdLocale recognize(String text) {
        TextObjectFactory textObjectFactory = text.length() > 10 ? forDetectingOnLargeText() : forIndexingCleanText();
        Optional<LdLocale> locale = languageDetector.detect(textObjectFactory.forText(text));
        return locale.isPresent() ? locale.get() : null;
    }
}

translator = new Translator();
translate.recognize("this is a text really big that I am trying to write")

@fabiankessler You know why?

@danielgomezrico because on android the Character.UnicodeScript doesn't exist, but the RemoveMinorityScriptsTextFilter uses this class.

@epfisztner @caipivara Character.UnicodeScript has recently been added into Android API 24
https://developer.android.com/reference/java/lang/Character.UnicodeScript.html


Fails to compile, "thread 'main' panicked at 'Box'" in built-0.2.0

Which operating system does the issue occur on?
Manjaro Linux, Ubuntu Linux 16.04
rust=1.22.1
cargo=0.23.0
If on linux, are you using X11 or Wayland?
X11
I've tried clearing out ~/.cargo and re-cloning the alacritty repo; same result.
$ RUST_BACKTRACE=1 cargo build --release
   Compiling alacritty v0.1.0 (file:///home/jonathon/src/alacritty)
error: failed to run custom build command for `alacritty v0.1.0 (file:///home/jonathon/src/alacritty)`
process didn't exit successfully: `/home/jonathon/src/alacritty/target/release/build/alacritty-8bce53a622b9f242/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Box<Any>', /home/jonathon/.cargo/registry/src/github.com-1ecc6299db9ec823/built-0.2.0/src/lib.rs:339:18
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
             at /checkout/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at /checkout/src/libstd/sys_common/backtrace.rs:69
   2: std::panicking::default_hook::{{closure}}
             at /checkout/src/libstd/sys_common/backtrace.rs:58
             at /checkout/src/libstd/panicking.rs:381
   3: std::panicking::default_hook
             at /checkout/src/libstd/panicking.rs:397
   4: std::panicking::rust_panic_with_hook
             at /checkout/src/libstd/panicking.rs:577
   5: std::panicking::begin_panic
             at /checkout/src/libstd/panicking.rs:538
   6: built::write_built_file_with_opts
             at /home/jonathon/.cargo/registry/src/github.com-1ecc6299db9ec823/built-0.2.0/src/lib.rs:339
             at /home/jonathon/.cargo/registry/src/github.com-1ecc6299db9ec823/built-0.2.0/src/lib.rs:807
   7: built::write_built_file
             at /home/jonathon/.cargo/registry/src/github.com-1ecc6299db9ec823/built-0.2.0/src/lib.rs:835
   8: build_script_build::main
             at ./build.rs:32
   9: __rust_maybe_catch_panic
             at /checkout/src/libpanic_unwind/lib.rs:99
  10: std::rt::lang_start
             at /checkout/src/libstd/panicking.rs:459
             at /checkout/src/libstd/panic.rs:361
             at /checkout/src/libstd/rt.rs:59
  11: __libc_start_main
  12: _start

This started a few commits ago, but:
$ git log -1
commit 8ff3c5d170abe47554f5d2a41ad35ddc451d254d (grafted, HEAD -> master, origin/master, origin/HEAD)
Author: Joe Wilm <joe@>
Date:   Mon Nov 20 09:30:57 2017 -0800

    Revert "Wait to display window until initialization is complete (#907)"

    This reverts commit a931d691a21a851ca4653cbab3542c600b72ff36.

    Please see https://github.com/jwilm/alacritty/pull/907#issuecomment-345666727
    for rationale w/ GIF.

    > now alacritty starts "in stages". First it paints some small
    > rectangle, and in a second in "boots" and fills up the available
    > space.

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/7.2.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc-multilib/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --enable-libmpx --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp
Thread model: posix
gcc version 7.2.0 (GCC)

Same problem on macOS

After a git bisect the "offending" commit was https://github.com/jwilm/alacritty/commit/8a09917dd1b51fee7a4f55fb79ff133822754304 , which isn't too surprising as this is where built was introduced.

If git-information is requested, there is a git repository yet libgit fails to retrieve information, built used to panic(). I've bumped built to 0.2.1, which silences the error condition for now. Bump you Cargo.lock and try.

@lukaslueg from your explanation it became clear to me that my problem was git history depth, I tested git clone --depth 1 https://github.com/jwilm/alacritty.git and it fails while full clone compiles.

This shouldn't be an issue with the latest alacritty and rust anymore. If the problem still exists, please let me know and I will re-open this issue.


drivers: sensor: Update drivers to use devicetree Kconfig symbol

@galak Are you gonna also remove the unnecessary Kconfig symbols from samples? For example https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/sensor/ina219/prj.conf#L5=

@galak Are you gonna also remove the unnecessary Kconfig symbols from samples? For example https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/sensor/ina219/prj.conf#L5=

Not in this PR.  Happy to have help from others on that.