Fix delete untracked branch feature if git repo unavailable

Root cause:
If git repository is not available - fetch command throws exception and null is returned instead of FetchResult object.
In this case enabled "delete untracked branch feature" will brake flow of retrieving local copy.
Resolution summary:
Added null check for fetch result.
PS: sorry, I've missed this earlier...

Codecov Report

Merging #955 into 1.4.x will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             1.4.x    #955   +/-   ##
=======================================
  Coverage     76.4%   76.4%
- Complexity     725     726    +1
=======================================
  Files           83      83
  Lines         2797    2797
  Branches       402     402
=======================================
  Hits          2137    2137
  Misses         503     503
  Partials       157     157

Impacted Files
Coverage Δ
Complexity Δ

.../server/environment/JGitEnvironmentRepository.java
82.62% <100%> (ø)
81 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6402ec0...82665f4. Read the comment docs.

@ryanjbaxter Can we cherry-pick it to master?

@tdanylchuk we merge forward.

@tdanylchuk I just merged it forward, it should be in master now


Feat: Caching in BaseController

Enabled Caching of Apis in BaseController.java at  Controller level

@bvinayakumar  ADDED response class instead of object class


[Delivers #84266864 and #84266720] Removing deprecated classes: boundedv...

...iew, boundslayout, shrinktofit and simplelayout. Also cleaned up formatting in docs/api/index.html

:+1:


desc_id -> description_id and have values with desc- prefix

came up in the course of

https://github.com/bids-standard/bids-2-devel/issues/65

_ids which are  named for 3 out of 4 {entitylongname}_id (and value is {entityshortname}-{value} )
❯ grep '_id:$' objects/columns.yaml
desc_id:
participant_id:
sample_id:
session_id:

but I guess could be generalized for any entity (context: #54 ).
I think we should harmonize desc_id -> description_id and ensure we have value to be desc-{label} not just {label} as it is now in https://github.com/bids-standard/bids-specification/blob/master/src/derivatives/common-data-types.md?plain=1#L331 .
ATTN @bids-standard/bep016  folks (no team yet, sorry, hence @CPernet @tsalo as added/touched relevant stuff)
TODOs

[ ] fixup for desc_id -> description_id within bids 2.0 branch
[ ] formulate it as a "common principle" that for any entity there could be {entitylongname}_id in a corresponding {entitylongnameplural}.tsv .

@bids-standard/derivatives-mri-dwi Would probably be the BEP16 team.

Not sure if BEP016 is the right ping here; not doing anything in particular with _desc- there.


NPM 404

Is anyone else getting a 404 when trying to add this package?
Running yarn add react-google-maps I receive:
error An unexpected error occurred: "https://registry.yarnpkg.com/-cache/-/-cache-0.2.1.tgz: Request failed \"404 Not Found\"".

Seems to be an issue with yarn not npm.


Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash (dependency of async)

Snyk reported a vulnerability with lodash, which is a dependency of this package.
https://snyk.io/vuln/SNYK-JS-LODASH-450202
Updated to<EMAIL_ADDRESS>as it removes the dependency on lodash.
Updated other dependencies reported by npm audit.

Can we please get this one merged? @indexzero

Closing in favor of https://github.com/winstonjs/winston/pull/1686


fix: fixing upgrade of mongo-migrate on the migrations

This PR is related to https://github.com/shellhub-io/shellhub/issues/4343

PR closed due to Mongo-driver incompatible beta features, No substantive changes planned.


Add dependabot config for release 2.10

Add dependabot config for release 2.10

Now that we are tagging m0 much earlier, do we need to revisit this?

/retest

/approve

/lgtm


Add state file, as well as functions for safely getting/setting data in it

JSON encoded.
@juga0, if I do this, I'd like to replace your started_at file with a field in the state file. Is that okay?
Initially, it would look something like
$ cat ~/.sbws/state
{
    started_at:<PHONE_NUMBER>
}

In principle yes.  Some comments:

there's a branch using started_at that still haven't been merged, let's change this after that branch is merged
timestamp should be ISO formatted
i was thinking to change the name of the file to generator_started so that it match name of variable an KeyValue
depending on the other data in that file (which is?), could be any case where 2 parts of the code want to read/write at the same time?


[PRM-2601] - Refactor integration tests

Got a couple of places where the ComplianceStub is specifically called where it doesn't need to be, may be worth removing?
https://github.com/hmrc/penalties-frontend/blob/8592c6734868ada3109e4ee7383bbae6588f0acf/it/connectors/PenaltiesConnectorISpec.scala#L65
In addition, in the ComplianceStub, invalidComplianceDataStub and upstreamErrorStub are not called anywhere, so can be removed

Thanks for spotting the compliance stub stuff, I've refactored that and the penalty details stub also. I couldn't find occurrences of ComplianceStub is specifically called where it doesn't need to be? Have you got a link to where this is occurring?

Got a couple of places where the ComplianceStub is specifically called where it doesn't need to be, may be worth removing?
https://github.com/hmrc/penalties-frontend/blob/8592c6734868ada3109e4ee7383bbae6588f0acf/it/connectors/PenaltiesConnectorISpec.scala#L65
In addition, in the ComplianceStub, invalidComplianceDataStub and upstreamErrorStub are not called anywhere, so can be removed

Thanks for spotting the compliance stub stuff, I've refactored that and the penalty details stub also. I couldn't find occurrences of ComplianceStub is specifically called where it doesn't need to be? Have you got a link to where this is occurring?

In the code I linked originally, I believe you can remove the ComplianceStub. section and just have complianceDataStub()?


The delete documents by batch route ignores the payload limit setting

The POST /indexes/{index_uid}/documents/delete-batch route ignores the --http-payload-size-limit parameter and restricts the payload to be 2 Mib. The reason is highly due to the default Json actix deserializer limit.
To Reproduce
Send more than 2 MiB of JSON document IDs in a single call on the batch document deletion route.
Expected behavior
The engine must accept the limit defined by the --http-payload-size-limit parameter.
Screenshots
If applicable, add screenshots to help explain your problem.
Meilisearch version:
Every version of Meilisearch since we use Actix Web.

Hey @Kerollmops ,
I reproduced the issue with a really large dataset.
I confirm that this fix works when the payload is more than 2MiB as I have tested with the IDs payload having 2.7MiB.


feat: ensure ETH_FROM is checksummed

setting a unchecksummed address results in the ethsign lookup failing and the behavior defaults to using the node keystore. this updates the script to ensure the provided address is checksummed and valid.

wait yikes this should probably be upstreamed into ethsign, not sure how ppl would discover this easily if they're not using the template


linux-62 lost external connection from phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
linux-62 lost external connection from phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Rebooting the phone device to restore external connection.


fix #4

and rename RsRedis into RsRedisWrapper

maybe my PR is bad , I have some difficulty to inderstand what is a connectionPool

RediStick-Connection-Pool is based on the idea of Ramon Leon's article
"Making a Connection Pool for Glorp in Seaside".
http://onsmalltalk.com/making-a-connection-pool-for-glorp-in-seaside
Client-key is used for fine-grained control of max concurrent connections for each client's use-case.
I'll close the issue for now. But PR is always welcome!


keychain: add fish shell integration

The shell command is added in the interactiveShellInit, as it is the
equivalent of initExtra in bash or zsh.

Thanks! Looks good to me :+1:


feat: set default theme in src/config.ts

Purpose: Allow you to modify default theme in src/config.ts.
Behaviour change: I did not invoke localStorage.theme = '<theme>'; when user did not manually set the colour, which I believe this is not good experience.
Note: Using the name colorScheme instead of dark_mode or else familiar name is because I guess you may want to pre-set some pre-set themes based on different colour. The name design is for redundancy consideration in case you want to add more features based on this.

Fixed in #71.


Custom mana_regeneration

is there any way to register "mana_max" and "mana_regeneration" as attribute to enhance with other plugins ?
I try to write a plugin to bridge rpg attributes with magic, and register "mana_max, mana_regeneration" in magicprovider, but it doesn't work.

when disable skillapi and other mana taking over plugin in config, I finally found a solution:
register and handle onWandActivated, onWandDeactivated, onWandPreActivated events, to set wand manaMax and manaRegeneration value.
I don't know if it was the finally solution, or still need to improve...


Pass properties object in trackDependency

Is there a plan to introduce properties in the trackDependency API (ref) like trackException or other API's?
In my case, I want to track some custom properties with my Ajax call which signifies the source component of the call (for eg.)

It will be available in the next .NET SDK version: https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/src/Core/Managed/Shared/DataContracts/DependencyTelemetry.cs#L201 Nothing stops us implementing it for JS. @kamilszostak I'd suggest to pick up the latest public schema for JS SDK. I can give you details tomorrow


[objs] update ECC384 binaries

OT PR 19380 updated ecc384_serial.c and p384_ecdsa_sca.s to enable trace capturing with the latest setup.
Binaries should be updated.

Hey @vrozic , @bilgiday, @wettermo ,
I've updated lowRISC/OpenTitan#19380 and intend to merge it once CI passes again. Do you maybe want to try it out again on the board?

#204 Updates this binary and should close this issue.


Update ?

Hello,
Any update on this ?
Thanks

Hello, do you the new API KEY for FP, JD and Size ?
Thank you

Hey there, this project is unmaintained and even with proper API keys, probably isn't working. Sorry.


refactor text system

The vision is to have a use_font hook. so it would be like:
#[function_component]
fn my_comp(p: MyProps, c:Elements)->Elements {
  let f=use_font(FontSpec::new("thefont").size(10).charset(Charset::Ascii));
  f.get_line_width("blabla") // the with of a line of text
  f.get_paragraph_height("blasdf\nasdfasf",100) // the height of a paragraph, if fit into a width of 100

  apx!{
    <text text="hello" font=f/>
  }
}

currently there is a gpu cache thingy, but it doesn't work well at all. look at:

https://crates.io/crates/glyph_brush/
https://docs.rs/glium_text/latest/glium_text/

The gpu cache wasn't that bad, it just needs to update its size dynamically, which it now does...
The syntax for using fonts:
#[function_component]
fn my_comp(p: MyProps, c:Elements)->Elements {
    let f=use_font_data(||include_bytes!("./thefont.ttf"));
    f.get_str_width("blabla",10) // the with of a line of text

    apx!{
       <text text="hello" font=f size=Dp(10.0)/>
    }
}```


snoRNA_primary_transcript issues

What is the SO term name and accession?
snoRNA_primary_transcript (SO:0000232)
Describe what you would like to change.
i) Typo in def. Currently says "A primary transcript encoding a small nucleolar mRNA (SO:0000275)" - 'mRNA' should just be 'RNA'.
ii) Some transcripts encode multiple snoRNAs (i.e. they are polycistronic units.), .e.g. fly Uhg1, human SNHG1
These can't accurately be annotated with this term as it's currently defined.  Can we broaden the definition to "A primary transcript encoding one or more small nucleolar RNAs (SO:0000275)", or should we have a different term to annotate these?  (Maybe they are just 'lncRNA'?)
Relevant Publications
https://pubmed.ncbi.nlm.nih.gov/11302516/
https://pubmed.ncbi.nlm.nih.gov/8559254/

Steve, thank you for bringing this to our attention. We agree with your new definition and think that no new term needs to be created. I've committed the change and will close this issue. The SO browser should update within the next 24 hours.

Steve, thank you for bringing this to our attention. We agree with your new definition and think that no new term needs to be created. I've committed the change and will close this issue. The SO browser should update within the next 24 hours.

Great, thanks Evan.

Great, thanks Evan.


Update README with a Laravel UUID type configuration example

Hi @thicolares what did you do to get this working on Laravel?
Added a new blueprint field type, for it. Or did you use a different package?
Thanks

Hi @Arjan-de-W. Could you please give me more details about what do you have so far?
For the record, I'm using: http://www.laraveldoctrine.org/ packages to use Doctrine with Laravel.
Then after setting up the packages and proper moving the config file to config/doctrine.php, I:
(1) change the doctrine configuration file as described in this current PR. Alternatively:
   // config/doctrine.php:110
    'custom_types'               => [
        'uuid' => \Ramsey\Uuid\Doctrine\UuidType::class
    ],

(2) setup my mapping files (I'm using XML):
<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
                  xmlns:gedmo="http://gediminasm.org/schemas/orm/doctrine-extensions-mapping"
                  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
                          https://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd">

    <entity name="App\DomainModel\MyModel" table="models">
        <id name="id" column="id" type="uuid"/> <!-------------- HERE
        ...

(3) My PHP entity class is something like (PHP 7.4):
class MyModel
{
    ....

    private UuidInterface $id;

Note: in case you need auto-generated uuid, you could use this tags bellow -- I'm not using it due to DDD practices:
    <id name="id" column="id" type="uuid"/>
        <generator strategy="CUSTOM"/>
        <custom-id-generator class="Ramsey\Uuid\Doctrine\UuidGenerator"/>
    </id>

Thank you for contributing! 🎉


Erase does not work

I tried to change the drawing mode to sketcher.mode = 'erase' - does not seem to work in the new version.
Its also not working in your demo anymore: http://fiala.uk/atrament.js/demo/

thanks for the heads up @davidlr99. I feel like I'm gonna have to write some tests at some point.. will fix the erase function in the next update ASAP.

Hi @davidlr99 - this should now be fixed in v1.1.0. Feel free to reopen if you still encounter issues.


No list of "workarounds" for this error even though workarounds are referenced in the error and this page.

Please provide links to appropriate workarounds for this error.  Do not make an API obsolete without provide links or direction on resolution.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b872cf4f-7dcc-07b7-1419-248e8d1351c6
Version Independent ID: 7dc0d15f-b309-0755-1547-2ecc00876f26
Content: SYSLIB0009 warning - .NET
Content Source: docs/fundamentals/syslib-diagnostics/syslib0009.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

Hi @davidfordaus. One possible workaround would be to make your own class that inherits IAuthenticationModule. The AuthenticationManager inherits from it, but usage of the interface does not appear to be obsoleted. If you implement IAuthenticationModule, you just have to implement Authenticate() and PreAuthenticate(). If that helps, I could update the docs.


Auto deploy is not removing old files

In gh-pages branch, old files are not removed with new commit.. increasing the number of files in the gh-pages repository
https://github.com/covid19india/covid19india-react/tree/gh-pages/static/js

Resolved with 545cc5c99


press event not working in ionic4

i have installed hammerjs using npm.
I have imported in main.ts file
still press event is not working

Try adding HammerModule into app.module.ts. It worked for me.

Try adding HammerModule into app.module.ts. It worked for me.

Can you explain why my press events are being detected on chrome browser, but when i run the app on my phone, it no longer detects them ?


Getting warnings from Sass

Description of the issue

On startup the kit now has warnings from Sass:
DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ┌──> node_modules/govuk-prototype-kit/lib/assets/sass/manage-prototype.scss
35  │     padding-left: 0;
    │     ^^^^^^^^^^^^^^^ declaration
    ╵
    ┌──> node_modules/govuk-prototype-kit/node_modules/govuk-frontend/dist/govuk/vendor/_sass-mq.scss
229 │ ┌         @media #{$media-type + $media-query} {
230 │ │             @content;
231 │ │         }
    │ └─── nested rule
    ╵
    node_modules/govuk-prototype-kit/lib/assets/sass/manage-prototype.scss 35:3  root stylesheet

The warnings dont affect the kit running, but if you want to silence them, you can add an override to package.json as I've done here:
https://github.com/joelanman/govuk-prototype-kit-prototype/blob/main/package.json#L12-L14
After that you'll need to npm uninstall govuk-prototype-kit then npm install govuk-prototype-kit
As an aside, I wonder if its best to pin versions in the govuk prototype kit package.json so this sort of thing doesnt happen
Related GOV.UK Frontend issue here:

https://github.com/alphagov/govuk-frontend/issues/5143

Hi @joelanman 👋🏻
That's a neat workaround. I've added this to the list of small stories our team might look at outside of the main stream of work currently prioritised as your suggestion of pinning the versions sounds neat to avoid the situation arising in the future (maybe to tilde prefixed ones rather than set version numbers to enable patches).


count number of triples fast

Problem description
Counting the number of all triples in the store is currently time consuming. Both:
sizeInternal
https://github.com/eclipse/rdf4j/blob/75b97f6106e6a73776d7f0f663f18a3edfb0a4ae/core/sail/base/src/main/java/org/eclipse/rdf4j/sail/base/SailSourceConnection.java#L403
and
select (count(*) as ?c)  where {?s ?p ?o} limit 10
iterate over all the triples. How easy would it be to keep track of it using a counter? Was this ever considered?
Preferred solution
No response
Are you interested in contributing a solution yourself?
Perhaps?
Alternatives you've considered
No response
Anything else?
No response

The implementation in SailSourceConnection is merely a default fallback. Concrete store implementations can override this behavior with something more efficient.


Add more exact details on how the log command works

More exact details on all its working features.

Codecov Report

Merging #143 (f3bc714) into master (35d6dd0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage     61.07%   61.07%
  Complexity      437      437
=========================================
  Files            91       91
  Lines          1652     1652
  Branches        162      162
=========================================
  Hits           1009     1009
  Misses          593      593
  Partials         50       50

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


⚠ Bofrost.at has degraded performance

In 1317273, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1023 ms

Resolved: Bofrost.at performance has improved in 8ea3ac7 after 16 minutes.


Ensure PyPI secret in repository settings

For publishing relaton-py I’m adding the same GHA workflow as in https://github.com/relaton/relaton-bib-py/blob/06bbf3c46d8fae23049d4cb172d9be070c0c2b85/.github/workflows/release.yml#L1-L33. It requires secrets.RIBOSE_PYPI_API_TOKEN to be available, can we ensure the repository has it?

Yes it's around!


Request: ability to set a default for a blank item or easily clear an existing item

I have dates in mind as I am adding this feature request but I think applies to other types as well.

I would like to have a button on this dialog that sets the field value (a date in this case) to a specified default value (eg. today).  The other way round this is that the increment button sets date to today if field is blank.

Ideally also a button that clears the existing value.

thank you 🙏🏻


Loading repo pages on docker takes 5 seconds

Host is Sierra 10.12.2 (16C67)

Directions used: https://github.com/gogits/gogs/tree/master/docker
28dc5bb
❯ docker version
Client:
 Version:      1.12.5
 API version:  1.24
 Go version:   go1.6.4
 Git commit:   7392c3b
 Built:        Fri Dec 16 06:14:34 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.12.5
 API version:  1.24
 Go version:   go1.6.4
 Git commit:   7392c3b
 Built:        Fri Dec 16 06:14:34 2016
 OS/Arch:      linux/amd64

❯ docker-compose version
docker-compose version 1.9.0, build 2585387
docker-py version: 1.10.6
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2j  26 Sep 2016

Any ideas how we can get default instructions to be faster?

Hi, how many files+directories in the page you view?

OK.. then I think it's your machine problem: https://try.gogs.io/gogs/gogs/src/develop/models

Have you tried this with Docker on Sierra @Unknwon

Yes, all default settings latest Docker Toolbox:

I'm tempted to just close this and troubleshoot next time I try gogs on docker. Since I ended up moving onto something else for the moment.
I'm in the process of learning more about docker, so if anyone else has this issue please re-open.

Thank you @Unknwon. I love the project very much

No problem. Run Gogs natively isn't that bad :D


fs: fuse: ensure S_IFxxx macros are available

set _XOPEN_SOURCE appropriately to avoid compilation errors due to missing S_IFxxx macros on some systems.

Out of curiosity in which distro did you see this problem?

Ubuntu 24.04 😶 on WSL

Ubuntu 24.04

Thanks, I can also repro in plain Ubuntu 24.04 :)

@kartben would you be so kind as to create an issue so we can backport this fix?


textmesh pro fonts do not work correctly

I actually have this problem:
every time you start the game, the game seems to skip random parts of the font,
so after the restart, completely different letters may not be displayed

there are still problems with displaying the interface of the translator itself ...
I understand that in this game there are no standard assets for the old interface.
but it's not important, it's more important to fix the problem above, can you help in any way?
I'll add the logs, maybe it will clear up the situation somehow
MelonLoader_22-05-29_12-03-08.435.log
MelonLoader_22-05-29_06-49-01.495.log
MelonLoader_22-05-29_06-47-03.465.log
MelonLoader_22-05-29_06-45-42.145.log
MelonLoader_22-05-29_06-44-02.757.log
MelonLoader_22-05-29_06-31-46.326.log
MelonLoader_22-05-29_06-28-46.048.log
MelonLoader_22-05-29_06-26-52.177.log
MelonLoader_22-05-29_12-07-28.547.log
MelonLoader_22-05-29_12-06-02.021.log
the situation with BepInEx is even worse
the combination still doesn't work
CTRL + ALT + NP6: Print out entire GameObject hierarchy to file hierarchy.txt
crash game
I need this file to set up resizes

Here is some more info about where the problem occurs
[12:46:29.972] Setting text on 'TMPro.TextMeshProUGUI' to '<color=#21E713>B Ixia os ect yo ngn ing branch Рекрутирует!
Основные члены этой секты выдадут это рекомендательное письмо тем, кто, по их мнению, способен.
Если вы получили один, вас приглашают присоединиться к испытаниям секты.
Пропустите испытания, и вы можете присоединиться к секте!'
[12:46:29.974] Path : /Game/UIRoot/Canvas/Root/UI/PropInfo/G:goRoot/G:imgBG/Grid/G:goText/G:ptextInfo

temporary solution
found in the Internet mod on Melon Loader
he helped me to fix
the font for this game

game build in IL2CPP
you need
MelonLoader IL2CPP
to use this mod
https://mega.nz/file/CIRDwYqQ#MQ4UUHP8pZWobL28NQsLng-0M8J1rGTAbvDr-uhpGFY

i just dont know how to add font in the config folder, i tried using the path of the file with the file name but no work for me. still sqaures

i just dont know how to add font in the config folder, i tried using the path of the file with the file name but no work for me. still sqaures

just don’t add the font to the game, you need to make an asset or use dynamic font generation during the game (the processor eats up a little) - for this, install the mod using the links above, try it, whatever version suits you

i just dont know how to add font in the config folder, i tried using the path of the file with the file name but no work for me. still sqaures

just don’t add the font to the game, you need to make an asset or use dynamic font generation during the game (loads a little processor) - for this, install the mod using the links above, try it, whatever version suits you

i dot have unity or anything to make the file sdf rather than ttf.
i want to make the game into to arabic language.
i have been researching the whole web for 7 hours to make that work :(

i just dont know how to add font in the config folder, i tried using the path of the file with the file name but no work for me. still sqaures

just don’t add the font to the game, you need to make an asset or use dynamic font generation during the game (loads a little processor) - for this, install the mod using the links above, try it, whatever version suits you

never mind i managed to make an asset bundle and it works great now, am just facing text direction:
Arabic Letters orders. It's like reading "Hello" as "olleH". السلام is displayed as: م ا ل س ل ا
Arabic Letters connectivity. As seen here: “السلام is displayed (in-game) as: م ا ل س ل ا” the letters are no disconnected.


Fix optimizeSvgs script

Switch SVGO.optimize function to returning a promise instead of accepting a callback - https://github.com/svg/svgo/releases/tag/v1.0.0
Pin prettier to the last version before 1.18.0 which removed the self closing JSX brackets.  On a clean install without a package-lock.json a higher version would automatically be installed - https://prettier.io/blog/2019/06/06/1.18.0.html#stop-converting-empty-jsx-elements-to-self-closing-elements-6127-by-duailibe

Add { parser: babel } option to format to avoid warnings on each iteration

Fix some incorrect arguments for writing the SVGs to disk

Nice work!
I will test it tomorrow.

I saw that the current script is also did some optimizations for 137 icons.
I think we need to update them.
Maybe we can also create a github action for it, auto reviewing icons or something.

I saw that the current script is also did some optimizations for 137 icons.
I think we need to update them.
Maybe we can also create a github action for it, auto reviewing icons or something.

I agree, these should be updated to keep the whole package consistent.  You could either add a Github Action or a pre-commit hook with something like husky to ensure icons are optimized before a PR is submitted.  I have implemented the latter before and it is very straightforward so I could add it if you'd like!

I saw that the current script is also did some optimizations for 137 icons.
I think we need to update them.
Maybe we can also create a github action for it, auto reviewing icons or something.

I agree, these should be updated to keep the whole package consistent.  You could either add a Github Action or a pre-commit hook with something like husky to ensure icons are optimized before a PR is submitted.  I have implemented the latter before and it is very straightforward so I could add it if you'd like!

I agree, these should be updated to keep the whole package consistent.  You could either add a Github Action or a pre-commit hook with something like husky to ensure icons are optimized before a PR is submitted.  I have implemented the latter before and it is very straightforward so I could add it if you'd like!

@csandman Yeah true and good idea,  adding husky is very easy to implement and contributes to the code quality.
I appreciate it, feel free to submit!

I agree, these should be updated to keep the whole package consistent.  You could either add a Github Action or a pre-commit hook with something like husky to ensure icons are optimized before a PR is submitted.  I have implemented the latter before and it is very straightforward so I could add it if you'd like!

@csandman Yeah true and good idea,  adding husky is very easy to implement and contributes to the code quality.
I appreciate it, feel free to submit!


Incorrect name shown for "Live Vicariously"

Another skill that gw2 has mapped to the wrong name...

Fixed in 2.1rc1 (b0eac66ef121a743c79193d3969dd090f0037411)


[beta] Applied Responsive Web Design Projects - guide links are broken

Challenge Name

Applied Responsive Web Design Projects
Issue Description

When i click get hint on any of the Applied Responsive Web Design Projects it redirects me to a non-existing guide url.
e.g
build a tribute page
Build a Personal Portfolio Webpage
Browser Information

Browser Name, Version: Google Chrome Version 64.0.3282.186
Operating System: Windows 7 32-bit

@a7mam7ma Hello the projects do not have a Hint Guide for them. Within the instructions there is a working example link you can click on to view what is required. To find out the user stories, you need to click on the 'Run Tests' button and once its completed you need to select the green 'Tests' button to see the requirements.

@mstellaluna so get hint button should be disabled for projects, right?

@a7mam7ma
I agree, I suggest to leave this issue open so it can be reviewed and discussed.
Thanks for opening the issue.
Happy Coding !

Agreed.  I am of the opinion that the button could be removed for the projects

@raisedadead We have created stubs for the projects and do indeed want guide articles that correspond to the projects.
We have an open PR on guides that will add these stubs - we're just working on a way to merge it: https://github.com/freeCodeCamp/guides/pull/8026


Phind Codelamma prompt templates are not used properly (among other param issues)

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: MacOS 14
- Continue: 0.5.2
- Ollama: 0.1.8

Description
The ollama phind model is not properly hooked up, leading to terrible output from the leading local code generation model.
There are several problems here:

The template messages are wrong (they are set to llama2_template_messages instead of phind_template_messages
The context length is wrong (phind-codellama is 16k context, not 2k)
The max_tokens field is wedged at 600; should be 8k
The name of the model is not how ollama actually names it

To reproduce

Because I'm on a mac, I have plenty of vram for phind-codellama:34b-v2-q6_K, so I did ollama pull phind-codellama:34b-v2-q6_K. Note that with ollama and phind-codelamma, you must actually specify a full tag, especially if you want v2 and quantization.
Select Ollama Phind CodeLamma in Continue.dev.
Try to talk to it. Because the prompt templates are wrong, it will give you nonsense answers, often echoing the (incorrect) INST tags from llamma2 prompt template
Inspect the request to see that the model is using the wrong template

Log output
I managed to config the context_length in config.py, but I can't seem to find a way to fix either the prompt template, or the max_tokens parameter.

If you inspect the prompt, you get:

This is the exact prompt sent to the LLM:

Settings:
context_length: 16000
model: phind-codellama:34b-v2-q6_K
max_tokens: 600

############################################

[INST] hi [/INST]

Note that these INST tags are not right. The prompt format is totally different: https://huggingface.co/Phind/Phind-CodeLlama-34B-v2
I did find a function that looks like it has this template (phind_template_messages() in server/continuedev/libs/llm/prompts/chat.py), but I can't find a way to hook it up via config.py.
I have a super-ugly patch to get everything working, which I will attach just for reference.

This patch hacks things to work, but obviously you don't want to merge this:
phind.patch
I am new to the codebase, so I am not sure the best way to fix all of these issues cleanly :/
Maybe they can actually be fixed from config.py, but I tried for a couple hours and could not get it to override max_tokens correctly, let alone the prompt template. That's why the patch just changes the default for max_tokens... It was the only way I could get it to not be 600.
Oh, also you do have to edit config.py to name the model correctly. phind-codelamma is not enough. I had to do:
 default=Ollama(
                        title="Phind CodeLlama",
                        model="phind-codellama:34b-v2-q6_K",
                        context_length=16000
                ),

@dflatline
a) This setup is way harder than it should be and we've decided to make this the sole topic of next week, so this whole experience will improve.
b) I'm fixing the template message right now to point to the correct one. context_length I'm going to wait on as we design a better experience because I want to be careful about cranking that up to 16_000 for users who might not have such powerful hardware. But will address this is one way or another
To hook up phind_template_messages you can do this in config.py:
from continuedev.libs.llm.prompts.chat import phind_template_messages
...

 default=Ollama(
     title="Phind CodeLlama",
     model="phind-codellama:34b-v2-q6_K",
     context_length=16000,
     template_messages=phind_template_messages
 ),

Nice! I am glad to hear this is being worked on. To continue's credit, it is the only project I have found so far that even had some kind of support for different model prompt templates, other than ollama itself. Every project seems to be a nightmare to use with any other than a single specific model (and for open source models, the best-in-class seems to change weekly...)
What about the max_tokens problem? I could not seem to set that from either the Ollama model param arguments there, or where temperature was set, in config.py. Neither location had any effect.

What about the max_tokens problem?

I am also looking for an option to change the max_tokens value. I set it in the config file, but the extension ignores it. I am tired of receiving incomplete messages from the LLM. 600 is too small.
`This is the exact prompt sent to the LLM:
Settings:
context_length: 16384
model: wizardcoder:13b-python
temperature: 0.01
max_tokens: 600
############################################`

@dflatline @mantukin There was a bug causing override not to work. I've just fixed this and it will be ready in pre-release version 0.7.4 within the next 20 minutes. In the pre-release we now use a .json config file format, and you can set "max_tokens" in one of two ways:
{
  "models": [
    {
      "title": "GPT-4",
      "provider": "openai-free-trial",
      "model": "gpt-4",
      "api_key": "",
      "context_length": 8192,
      "completion_options": {
        "max_tokens": 1002
      }
    }
  ],
  "completion_options": {
    "max_tokens": 1001
  },
...
}

Here, the model-specific completion_option (1002) will take precedence over the base completion_options (1001).
I've also changed the default value so that it increases along with the context length of the model. Will be half of the model's context length, capped at 2048.

@sestinj Thank you for fixing it and explaining. Now everything works as it should.
Additionally, I think it would be more convenient for the user if max_tokens and context_length values were options in the settings window, along with the temperature slider.

nice! and absolutely yes, I can make this happen.

going to close this issue since main problem was addressed.
As for sliders in the UI settings, I think we are going to keep the options in .json. Reason for this is mainly an attempt to curb complexity and I think we can do a good enough job for most users that even thinking about context length or max tokens shouldn't necessary. The UI would get pretty cluttered / confusing for new users when there's a different max_tokens + context_length for each model


Information

Windows 11 23H2 update patches this method causing BSOD after mode change, so stay on 22H2 if you want to use it 🤗

Windows 11 23H2 update patches this method causing BSOD after mode change, so stay on 22H2 if you want to use it 🤗

windows 10 22h2 sometime BSOD ci.dll
you know what cause ? thanks you a lot


Minimum width for both panels

Looking at the Horizontal Splitter Panes example http://codepen.io/rstrahl/pen/eJZQej
Although the right panel has min-width: 200px; set, it seems you can still drag it beyond the minimum width. Is there something I'm missing?

Hmmm... yeah I see that as well - seems to be due to the fact the inside panel isn't fixed sized (ie. appears to flow past the edge of the viewbox. It's more of a layout issue though than an issue of the resizer.

Definitely a deal breaker for me. I can't figure out how to give the right column a minimum width, or the bottom column a minimum height. And here I thought I was great with CSS...

+1 to that problem...Would be great to set min-width to both panels

@kristjan07 I ended up using http://layout.jquery-dev.com/ for the project that I needed it for, and it worked well. Its not well documented but they added a minHeight and minWidth recently: https://groups.google.com/forum/#!topic/jquery-ui-layout/zohRG5DDvpM

@gregblass Thanks for a great link. I'll test this out and if it works for me i have to ditch jquery-resizable. Sadly.

I've looked at this in a number of different ways and I can't figure out a way to make this work without explicitly specifying the min width/height for both panels as part of the plug-in.
The issue is that manual resizing of the primary panel will create the main panel in a new size and that size will be fixed in size. Setting a min-width in the related panel just forces the panel to stay that size and push out beyond the borders of the container (invisibly).
To fix this would require widening the scope of this small resizable component to more of a layout module, which isn't really the goal. That resizing works the way it does is more of a bonus feature.
If anybody has any ideas without being explicit about each of the sizes outside of CSS, I would love to hear it.

@RickStrahl For me the min width/height for both of the panel is totaly fine. It would be a bonus because i have content in both panels that i don't want to be "squashed" under somekind of min-width.
Lets be honest.

Set a max-width in left panel to have a min-width in right panel

@0rsa This solution worked for me as well. I set a max-width of the left panel with the below code, where "200" would be whatever you want the min-width of the right panel to be.
maxWidth = $('.panel-container').width() - 200;
$('.panel-left').css('max-width', maxWidth);


need ue4.26 support

my vr device and my cesium project is almost under ue4.26,Can this project support ue4.26?

Hi @martin416
Yes all of the functionality within the tutorials at this point should be compatible with your project version.

closing because resolved


500 error getting articles

Testing with zap-api-scan.py I have discovered various 500 status codes in the API. For example:
curl -X GET "http://localhost:8000/api/articles?tag=%00&author=author&favorited=favorited&limit=20&offset=0" -H  "accept: application/json"
The complete report look like this:
ZAP Scanning Report
Generated on Thu, 25 Feb 2021 15:54:01
Summary of Alerts

Risk Level
Number of Alerts

High
0

Medium
0

Low
3

Informational
1

Alerts

Name
Risk Level
Number of Instances

A Server Error response code was returned by the server
Low
3

Unexpected Content-Type was returned
Low
3

X-Content-Type-Options Header Missing
Low
3

A Client Error response code was returned by the server
Informational
435

Alert Detail
A Server Error response code was returned by the server
Low (High)
Description
A response code of 500 was returned by the server.This may indicate that the application is failing to handle unexpected input correctly.Raised by the 'Alert on HTTP Response Code Error' script

URL: http://localhost:8000/api/articles?tag=tag&author=author&favorited=%00&limit=20&offset=0

Method: GET

Evidence: HTTP/1.1 500

URL: http://localhost:8000/api/articles?tag=tag&author=%00&favorited=favorited&limit=20&offset=0

Method: GET

Evidence: HTTP/1.1 500

URL: http://localhost:8000/api/articles?tag=%00&author=author&favorited=favorited&limit=20&offset=0

Method: GET

Evidence: HTTP/1.1 500

Instances: 3
Solution

Reference

CWE Id : 388
WASC Id : 20
Source ID : 4
Unexpected Content-Type was returned
Low (High)
Description
A Content-Type of text/plain was returned by the server.This is not one of the types expected to be returned by an API.Raised by the 'Alert on Unexpected Content Types' script

URL: http://localhost:8000/api/articles?tag=tag&author=author&favorited=%00&limit=20&offset=0

Method: GET

Evidence: text/plain

URL: http://localhost:8000/api/articles?tag=tag&author=%00&favorited=favorited&limit=20&offset=0

Method: GET

Evidence: text/plain

URL: http://localhost:8000/api/articles?tag=%00&author=author&favorited=favorited&limit=20&offset=0

Method: GET

Evidence: text/plain

Instances: 3
Solution

Reference

Source ID : 4
X-Content-Type-Options Header Missing
Low (Medium)
Description
The Anti-MIME-Sniffing header X-Content-Type-Options was not set to 'nosniff'. This allows older versions of Internet Explorer and Chrome to perform MIME-sniffing on the response body, potentially causing the response body to be interpreted and displayed as a content type other than the declared content type. Current (early 2014) and legacy versions of Firefox will use the declared content type (if one is set), rather than performing MIME-sniffing.

URL: http://localhost:8000/api/articles?tag=tag&author=author&favorited=favorited&limit=20&offset=0

Method: GET

Parameter: X-Content-Type-Options

URL: http://localhost:8000/api/tags

Method: GET

Parameter: X-Content-Type-Options

URL: http://localhost:8000/openapi.json

Method: GET

Parameter: X-Content-Type-Options

Instances: 3
Solution
Ensure that the application/web server sets the Content-Type header appropriately, and that it sets the X-Content-Type-Options header to 'nosniff' for all web pages.If possible, ensure that the end user uses a standards-compliant and modern web browser that does not perform MIME-sniffing at all, or that can be directed by the web application/web server to not perform MIME-sniffing.
Other information
This issue still applies to error type pages (401, 403, 500, etc.) as those pages are often still affected by injection issues, in which case there is still concern for browsers sniffing pages away from their actual content type.At "High" threshold this scan rule will not alert on client or server error responses.
 If anyone still wants to submit a fix PR with that, they can safely do so, although I'll archive this repository soon, so I'm not sure if it will be useful.


Linux broken (Missing Library)

Hiya, when I run the Linux version of this app, nothing opens. But when I open it with terminal, this happens:

I'm not sure what to do here.
Thanks!

I use Ubuntu Cinnamon, by the way.

Rename the so.6.4.1 to so.6


mangareader: init at 2.0.3

Description of changes
Qt manga reader for local files.
https://github.com/g-fb/mangareader
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

2.0.4 is already out


⚠ Auth has degraded performance

In 902368d, Auth (https://auth.k2lin.com) experienced degraded performance:

HTTP code: 200
Response time: 15360 ms

Resolved: Auth performance has improved in f93d91b.


Creating Blogs and Media Pages

Is your feature request related to a problem? Please describe.
There is no Blogs and Media pages on the website
Describe the solution you'd like
Proper blogs and media pages following the website's theme colors and link them to footer
Additional context
Add any other context or screenshots about the feature request here.

@Priyaaa1 kindly assign me this issue


Fix StatusCode.DEADLINE_EXCEEDED when dequeuing an empty queue

When task queue is empty and worker is meant to block, PubSub RPC pull can result in StatusCode.DEADLINE_EXCEEDED. I still haven't found a consistent way to force the failure, but eventually it always happens.
This fix allows psqworker to have a custom sleep time (default to 0) when dequeuing an empty queue. If no value is provided, or value is 0, dequeue will keep blocking as it does now.

Coverage decreased (-0.3%) to 99.749% when pulling afd9bccea71e342dba807978a9f715568be19ce7 on ichinaski:empty_delay into 2203d392548f3a63a81ed3754ce2fc66a5bf7afd on GoogleCloudPlatform:master.

@ichinaski thanks for this, but help me understand how this fixes the StatusCode.DEADLINE_EXCEEDED error?

Thanks for the quick reply @jonparrott,
The pull call to pubsub.Subscription is always set to block the thread: https://github.com/GoogleCloudPlatform/psq/blob/2203d392548f3a63a81ed3754ce2fc66a5bf7afd/psq/worker.py#L45
This eventually resulted in the aforementioned StatusCode.DEADLINE_EXCEEDED.
With the fix, if the empty-delay param is provided, the call will not block (avoiding potential timeouts), and instead we sleep the thread for the given amount of time.
Does it make sense? I could provide more info about my environment, but this has happened consistently both locally and in GCP's flexible VM's.

I'd rather see two PRs here:

One PR to catch the DEADLINE_EXCEEDED error and continue.
Another PR to add this new behavior.

Come to think about it, with a single PR that handles this exception and continues, as you suggest, it may suffice. The initial proposal is after all a similar trick to just avoid the potential error.
Let me know what you think about this:
diff --git a/psq/worker.py b/psq/worker.py
index 1143688..83f6d0f 100644
--- a/psq/worker.py
+++ b/psq/worker.py
@@ -20,6 +20,9 @@ import signal
 import time

 from retrying import retry
+from grpc import StatusCode
+from google.gax import errors
+from google.cloud import exceptions

 from .utils import measure_time

@@ -42,7 +45,12 @@ class Worker(object):
             wait_exponential_multiplier=1000, wait_exponential_max=10000,
             retry_on_exception=lambda e: not isinstance(e, KeyboardInterrupt))
         def inner():
-            return self.queue.dequeue(max=self.tasks_per_poll, block=True)
+            try:
+                return self.queue.dequeue(max=self.tasks_per_poll, block=True)
+            except errors.GaxError as e:
+                # Ignore timeouts and retry later
+                if not _is_timeout(e):
+                    raise
         return inner()

     def listen(self):
@@ -160,3 +168,10 @@ def _execute_task_in_worker(task):  # pragma: no cover
     with measure_time() as summary, _worker_queue.queue_context():
         task.execute(_worker_queue)
         summary('{} finished {}'.format(worker_name, task.summary()))
+
+
+def _is_timeout(err):
+    # Check whether a given GaxError is a timeout exception
+    exc = err.cause
+    return isinstance(exc, exceptions.GrpcRendezvous) and \
+        exc.code() == StatusCode.DEADLINE_EXCEEDED

Ensuring the error is indeed DEADLINE_EXCEPTION is a little cumbersome, but I cannot figure out a better way than checking the cause of the GaxError that gets propagated.

@ichinaski that looks pretty close. Send a new PR for it?


Expose Cookie via the main interface

Currently the Cookie module has to be imported standalone but it would be nice to provide it via Web.Scotty and Web.Scotty.Trans

Closed via #395


destroy-cluster hangs on Capture ASG deletion

Description
When calling destroy-cluster, the CLI call hangs indefinitely while trying to tear down the Capture Nodes stack.  Going into the AWS Console and manually terminating the ASG's instances and deleting the ASG causes the Stack deletion to become un-stuck.  This appears to be due to the ASG being protected from termination, possibly due to scale-in protection on the instances in the ASG.  A quick search indicates there isn't a way to turn this protection off via CloudFormation specification, so we may need to run a boto command before we attempt to tear down the stack.

This is called out in a GitHub issue for the CDK Repo [1].  From the issue:
I believe the reason for this is because the default for managed termination protection is set to true. This means that Cloudformation cannot delete the ASG associated with the ASG capacity provider because the instances are protected from scale-in.

Two ways you can get around this:
    1. Manually delete the ASG using the AWS EC2 console or AWS CLI, then delete the CFN stack.
    2. Set enableManagedTerminationProtection on the ecs.AsgCapacityProvider to false.

(2) seem easy to implement/test, and likely sufficient for our use-case.
[1] https://github.com/aws/aws-cdk/issues/14732#issuecomment-855054581

Hmm, the easy fix didn't appear to work.  I had to manually remove scale-in protection from the Capture Node instance, at which point the ASG was torn down.

Actually - I think it did work.  The issue was that I applied the updated termination protection settings via Cfn Update to an existing ASG, and that didn't seem to work... but if you create a new ASG with the updated setting, it will work?  Currently testing with a full teardown...

Yeah - I was able to tear down the stack entirely with that change, so it was fixed in https://github.com/arkime/aws-aio/pull/119.
Marking as resolved.


Feature Request: Implement create_period_dataset()

Feature Idea
Implement
create_period_dataset <- function(dataset,
                                  new_vars,
                                  subject_keys = vars(STUDYID, USUBJID))

dataset expects an ADSL dataset
new_vars expects a named list of variables, e.g., new_vars = vars(APERSDT = APxxSDT, APEREDT = APxxEDT, TRTA = TRTxxA) or new_vars = vars(PHSDTM = PHwSDTM, PHEDTM = PHwEDTM, APHASE = APHASEw)

The function creates a dataset with one observation per subject and phase/period/subperiod and the variables specified by new_vars. Additionally APERIOD is added if variables containing "xx" are specified, ASPER if variables containing "xx" and "w" are specified, and APHASEN if variables containing "w" but not "xx" are specified.
Example code for transposing:
period_ref <- pivot_longer(
  adsl,
  matches("AP\\d\\d[ES]DT"),
  names_to = c("APERIODC", ".value"),
  names_pattern = "AP(\\d\\d)([ES])DT"
) %>%
  rename(APERSDT = S, APEREDT = E) %>%
  mutate(
    APERIOD = as.integer(APERIODC),
    APERIODC = paste("Period", APERIODC)
  )

Relevant Input
adsl <- tribble(
  ~USUBJID, ~AP01SDT,     ~AP01EDT,     ~AP02SDT,     ~AP02EDT,
  "1",      "2021-01-04", "2021-02-06", "2021-02-07", "2021-03-07",
  "2",      "2021-02-02", "2021-03-02", "2021-03-03", "2021-04-01"
) %>%
  mutate(
    across(matches("AP\\d\\d[ES]DT"), ymd)
  )

Relevant Output
#> # A tibble: 4 x 5
#>   USUBJID APERIODC  APERSDT    APEREDT    APERIOD
#>   <chr>   <chr>     <date>     <date>       <int>
#> 1 1       Period 01 2021-01-04 2021-02-06       1
#> 2 1       Period 02 2021-02-07 2021-03-07       2
#> 3 2       Period 01 2021-02-02 2021-03-02       1
#> 4 2       Period 02 2021-03-03 2021-04-01       2

Reproducible Example/Pseudo Code
No response

The last example for derive_vars_joined() should be updated such that it uses the new function.

I see we have create and consolidate as the start of the function names for these new features.  Shall we consider a new class of functions that start with these verbs and update the dev document.
Or  use derive.  I sort of like not having derive in everything, but then what is the difference between create and derive?
Sorry just musing a bit.  @pharmaverse/admiral  Any thoughts?
https://pharmaverse.github.io/admiraldev/devel/articles/programming_strategy.html#function-names

The derive_*() functions add variables or observations to the input dataset. The create_*() or consolidate_*() functions create a dataset without keeping the source observations.

Function name prefix
Description

assert_ / warn_ / is_
Functions that check other functions’ inputs

derive_
Functions that take a dataset as input and return a new dataset with additional rows and/or columns

derive_var_ (e.g. derive_var_trtdurd)
Functions which add a single variable

derive_vars_ (e.g. derive_vars_dt)
Functions which add multiple variables

derive_param_ (e.g. derive_param_os)
Functions which add a single parameter

compute_ /  calculate_ / ...
Functions that take vectors as input and return a vector

create_  /  consolidate_
Functions that create datasets without keeping the original observations

derive_merge_
Functions that add variable(s) to the input dataset based on variables from another dataset

_derivation (suffix)
High order functions that takes another function as input

Will make into separate issue, but wanted to get the conversation going around new function names and trying to name appropriately so increases findability.

I would remove the derive_merge_ prefix because we have derive_vars_merged() and derive_var_merge_*() and not all functions which match to the description have the suffix, e.g., derive_var_base(). Otherwise we would need much more explanation to avoid confusion.

Hey Stefan I made a new issue for this so not to derail your feature request


bad character while parsing json

I have faced trouble when I was trying to get value from json.
When I am trying to get value from json  key with dash I get ERROR:  bad character U+002D '-'.
my json stored in etcd as testdata key:
{
  "Release": {
    "version": "1.0.0",
    "my_components": {
      "some-component": {
        "images": [
          "registry/myimage:baseline"
        ],
        "annotation": {}
      }
}

{{$data := json (getv "/testdata")}} {{ (index $data.Release.my_components.some-component.images 0 ) }}
With underscore symbol everything works fine.

This seems to be an restriction of the Go template parser/lexer.
See also: https://github.com/spf13/hugo/issues/1474
https://github.com/golang/go/issues/9685

Please, reopen if you'll find a way to fix this in confd.


⚠ Homepage (omg.lol) has degraded performance

In 9fad77b, Homepage (omg.lol) (https://8bit.lol/) experienced degraded performance:

HTTP code: 503
Response time: 176 ms

Resolved: Homepage (omg.lol) performance has improved in bf6b629 after 52 minutes.


Register a birth abroad in Turkey

PT story: https://www.pivotaltracker.com/story/show/109527156
Updates the outcome for Register a birth abroad in Turkey to include the name of the local birth certificate.
Fact check
https://pt-109527156.herokuapp.com/register-a-birth
Expected changes

URL on gov.uk
Adds the name of the local birth certificate ‘Formül A’

Before

After

I've just rebased this with the master branch and forced back to this PR's branch

I guess Turkey is not on the set of inputs for regression tests?
If so then it LGTM, otherwise artefacts should have changed :) :+1:

It's not in the [sample answers[(https://github.com/alphagov/smart-answers/blob/master/test/data/register-a-birth-questions-and-responses.yml#L2), but given it wasn't a logic change - I didn't add it


DEV: Copy link to clipboard automatically.

Clicking links next to headings will copy to clipboard automatically

This is conflicting now ... sorry for the huge delay.
I am going to close this for now and leave it to @hnb-ku  to decide if we want to add a theme setting here to enable auto clipboard, by default this seems somewhat aggressive to me.

Fine. Let me know if I can help.


New code quality test is failing due to variable neither read nor wri…

…tten on Subscription

Coverage remained the same at 100.0% when pulling b5a059dc1bcbd2868bd10294997d3e9e93621496 on bug#3 into 572c44629525bdd45f650d9def26582324e5d314 on master.


Owlet Care Baby Monitor Component

Description:
This PR replaces PR #20258 since I blew up something during a rebase.
Add support for monitoring stats from Owlet Care baby monitoring sock.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8217
Example entry for configuration.yaml (if applicable):
owlet:
  username: USER
  password: PASSWORD
  name: BABY_NAME

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

https://github.com/home-assistant/home-assistant.io/pull/8608


Multiple python venvs to resolve conflicts on parallel workload runs

Description
Bug fix to create multiple python virtual environments to resolve conflicts on parallel workload runs.
Before bug fix
Before this bug fix when triggered multiple workloads in parallel on a host, both the workload used /tmp/ripsaw as the virtual python environments. So in the final step of a workload execution when the garbage collection happens if one of the workload finishes fist, it removes the directory /tmp/ripsaw which was also being used by the other workload ultimately resulting in the following cleanup error.
Relevant Screenshots :

Fix
In order to separate each execution in a unique manner we are creating separate virtual environment directories using a unique uuid to avoid conflicts between multiple parallel runs.
After bug fix
Relevant Screenshots:

After this fix both the parallel runs ran and cleaned up successfully.

Can one of the admins verify this patch?

@vishnuchalla Please also take a look at ci/run_ci.sh as it blindly removes /tmp/ripsaw-cli. We might be able to remove that line.

This PR won't fix parallel runs, as the operator's namespace is always benchmark-operator.

This PR won't fix parallel runs, as the operator's namespace is always benchmark-operator.

But this can be taken as an action item to support parallel executions in the same cluster as a long-term perspective. But this will definitely take good amount of effort in making code changes at multiple places and thoroughly testing each and every workload to ensure nothing breaks.

This PR won't fix parallel runs, as the operator's namespace is always benchmark-operator.

@rsevilla87 yes, this is not to support parallel runs on same cluster but to use same server to run  on multiple cluster. Sometimes we run multiple workload across different cluster from same machine/vm, will hit this run time conflict. Recent slack convo.

@vishnuchalla Please also take a look at ci/run_ci.sh as it blindly removes /tmp/ripsaw-cli. We might be able to remove that line.

Thanks for pointing out. It had no effect on our test from the start itself. But i remove this code as a best practice

/rerun all

Reran all the tests on my host. Here is the attached report
Results for e2e-benchmarking CI Tests

Workload
Test
Result
Runtime

router-perf-v2
./ingress-performance.sh
PASS
00:10:17

etcd-perf
./run_etcd_tests_fromgit.sh
PASS
00:03:16

scale-perf
./run_scale_fromgit.sh
PASS
00:14:13

network-perf
./run.sh
PASS
00:06:22

kube-burner
WORKLOAD=cluster-density ./run.sh
PASS
00:05:25

kube-burner
WORKLOAD=node-density ./run.sh
PASS
00:05:12

kube-burner
WORKLOAD=node-density-heavy ./run.sh
PASS
00:06:06

kube-burner
WORKLOAD=pod-density-heavy ./run.sh
PASS
00:05:48

kube-burner
WORKLOAD=max-services ./run.sh
PASS
00:04:44

kube-burner
WORKLOAD=max-namespaces ./run.sh
PASS
00:05:23

upgrade-perf
./run_upgrade_fromgit.sh
PASS
00:01:33


cannot

Do you use Cocoapods? If so, you need to follow the instructions on README like below.
Because the example project is for the carthage...


Add missing "private readonly" modifiers to _userManager and _logger fields

Two small fixes for missing "private readonly" modifiers in Identity UI.

This needs to target the release/2.2 branch I believe

The code has moved to https://github.com/aspnet/AspNetCore/tree/master/src/Identity this is reasonable change we would take for 3.0 if you were to reopen this PR over there


Copper and Netherite Backtanks are unable to have mending applied to them

Describe the Suggestion
Mending despite it normally not being able to be applied to either backtank doesn't have a situation that matches what the elytra does (it just stops working at 0 durability) and actually breaks at 0. Making mending applicable to backtanks would definitely help with this since you can probably lose it fairly easily. There is also proof of the durability being on the backtanks if needed.
Screenshots and Videos
Durability Proof:

Additional Context
There is also a glitch that would technically become a feature if you change this, netherite backtanks can be enchanted with mending through a seconday method, as shown here:

Suggestions should be made to the forge repo if it's not a fabric specific inconsistency.

working properly on patch F 1.18, will test newer versions later

Able to apply mending just fine on 1.20.1 patch f, them taking durability is wrong behaviour as on forge they do not lose durability


Add Line Items

Is there a way to use any of the additional request properties, such as order line items and shipping address?  Those defined here: https://developer.authorize.net/api/reference/#payment-transactions
If not, is this going to be added?  Without it, it is very limited functionality.
It would be a good idea to have a method to add generic properties into the request, so we are not limited to what is specifically defined in AIMAbstractRequest.
EDIT: Nevermind!  I see there are CreditCard and ItemBag from the main OmniPay package that deal with this.

It appears that only the CreditCard class is used, the ItemBag is not.
As suggested, making AbstractRequest::setParameter() public would allow us to use payment gateway features without it being implemented in OmniPay.

Yes you are right, the lineItems/ItemBag seems to have been totally overlooked.


Dataset properties consistency

@davidsebfischer I just randomly came across some inconsistencies in the code of the Dataset class attributes:
https://github.com/theislab/sfaira/blob/61547eb782a89eeb94dc848e652263cffce03d2c/sfaira/data/base.py#L948
shouldnt this say:
            if self.meta is None and self._ADATA_IDS_SFAIRA.author not in self.meta.columns:

and this one:
https://github.com/theislab/sfaira/blob/61547eb782a89eeb94dc848e652263cffce03d2c/sfaira/data/base.py#L992
shouldn't this say:
            if self.meta is None and self._ADATA_IDS_SFAIRA.doi not in self.meta.columns:

Just want to double check in case I'm misunderstanding some of this code

Being able to evaluate self._ADATA_IDS_SFAIRA.healthy not in self.meta.columns  implies that self.meta is not None, so this should be or I think, ie first check if there is meta data to start with and if there is, check if the attribute is in there. or groups all cases in which this attribute is not in meta.

makes sense, just asking because it's and for all the other properties, such as here:
https://github.com/theislab/sfaira/blob/61547eb782a89eeb94dc848e652263cffce03d2c/sfaira/data/base.py#L974

We should probably change these?


Fixes bug when attaching a belongsToMany relation that has an orderByPivot

Description
When trying to attach a BelongsToMany relation through the RelationManager where the belongsToMany relation has an orderByPivot method it will give an error in the SQL query.
This used to work but seems to give an error since filament v3.
I think its because of the distinct query that has been added in RelationshipJoiner.php class.
As the orderBy query with a distinct needs that orderBy field to be added to the select.
I added a simple foreach that adds the existing orderBy columns to the select.
This seems to fix the error and has no extra side effects afaik.

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

For extra info also see this discussion I found discussing this exact problem:
https://github.com/filamentphp/filament/discussions/8022

Thanks!

@danharrin this caused some type of regression for me.

foreach() argument must be of type array|object, null given

Fixed in upcoming version


Bridge BUG - Token type and balance display errors

Describe the bug
Overview: After switching networks, the displayed token type and balance do not update.
Steps to reproduce
Details:
Issue presentation:
When I use the bridge to transfer HORSE tokens on the Holesky network, the balance is displayed as 50.

Next, I switched to the Katla network, and the quantity of HORSE tokens still displays as 50, although the actual value is not this number.

Now, even if I open the token list and click on HORSE again to try to refresh the balance, it does not work.

Ultimately, only when I first click on another token, such as ETH, and then click on HORSE in the second step, does the balance display correctly. The correct balance is shown in the following image.

The balance display issue has been ongoing. The first time was when switching wallets did not refresh the balance, which seems to have been resolved now. The second time involves switching networks not refreshing token types and balances. It appears that token types are now refreshing, but the balance still displays incorrectly. Please review and resolve this issue.
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Thanks for reporting this, it is already fixed in the next testnet version.


Simplify non-client hit testing in NCIslandWindow to fix doubleclick

It turns out that our WM_LBUTTONDOWN handler wasn't even necessary, as
our NCHITTEST tells win32 that all of the titlebar is actually
non-client area. This brings the code in line with
NonNonClientIslandWindow.
Fixes #2513
Validation Steps Performed
Went wild with the clicking and dragging.

Does this regress #2028/#2438?

Nah, I tested :)


Cannot install CocoaPods

Hi, I am new to all this and trying to get in to flutter and learn it, while going through the install process on my MacBook after running "flutter doctor" I have these errors:
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
✗ Android licenses not accepted.  To resolve this, run: flutter doctor
--android-licenses
[!] Xcode - develop for iOS and macOS
✗ CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin
code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install see
https://guides.cocoapods.org/using/getting-started.html#installation for
instructions.
I am trying to fix the cocoapods one first then I'll move on to the Android issue, I've done the "sudo gem install cocoapods" command multiple times to install cocoapods but I keep errors every time. This is the full error:
Building native extensions. This could take a while...
ERROR:  Error installing cocoapods:
ERROR: Failed to build gem native extension.
current directory: /Library/Ruby/Gems/2.6.0/gems/ffi-1.15.0/ext/ffi_c

/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby -I /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0 -r ./siteconf20210328-35795-2hn7gj.rb extconf.rb
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.
Provided configuration options:
--with-opt-dir
--without-opt-dir
--with-opt-include
--without-opt-include=${opt-dir}/include
--with-opt-lib
--without-opt-lib=${opt-dir}/lib
--with-make-prog
--without-make-prog
--srcdir=.
--curdir
--ruby=/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/$(RUBY_BASE_NAME)
--with-ffi_c-dir
--without-ffi_c-dir
--with-ffi_c-include
--without-ffi_c-include=${ffi_c-dir}/include
--with-ffi_c-lib
--without-ffi_c-lib=${ffi_c-dir}/lib
--enable-system-libffi
--disable-system-libffi
--with-libffi-config
--without-libffi-config
--with-pkg-config
--without-pkg-config
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mkmf.rb:467:in try_do': The compiler failed to generate an executable file. (RuntimeError) You have to install development tools first. 	from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mkmf.rb:546:in block in try_link0'
from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/tmpdir.rb:93:in mktmpdir' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mkmf.rb:543:in try_link0'
from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mkmf.rb:570:in try_link' 	from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mkmf.rb:672:in try_ldflags'
from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mkmf.rb:1832:in pkg_config' 	from extconf.rb:9:in system_libffi_usable?'
from extconf.rb:42:in `'
To see why this extension failed to compile, please check the mkmf.log which can be found here:
/Library/Ruby/Gems/2.6.0/extensions/universal-darwin-19/2.6.0/ffi-1.15.0/mkmf.log
extconf failed, exit code 1
Gem files will remain installed in /Library/Ruby/Gems/2.6.0/gems/ffi-1.15.0 for inspection.
Results logged to /Library/Ruby/Gems/2.6.0/extensions/universal-darwin-19/2.6.0/ffi-1.15.0/gem_make.out
Also here is the attached log file:
mkmf.log
If anyone could help me get this installed so I could move on and start using flutter that would be great thanks.

The gem script can't seem to locate your Xcode developer toolchain.
If you use Homebrew, you could try installing cocoapods via the homebrew package:
brew install cocoapods

Alternatively, you could try the following to ensure Xcode is properly setup in your environment:
# Install Xcode
sudo xcode-select --install
# View/agree to the Xcode license
sudo xcodebuild -license
# Switch to the typical location for developer tools
# (if this path doesn't exist, you can get a hint by running `clang --version` and
# checking the `InstalledDir` field for location of the `Developer` directory)
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer

Thank you so much sir, I used homebrew and it fixed the xcode issue instantly! Awesome. Now to work on the Android toolchain/license issue.


bug: Check for existing wallet before importing/creating wallets

Expected behavior
A user will be warned early if a wallet name is already taken.
Actual behavior
On the create or import page, if a duplicate wallet name is given, the user is not warned and will error only later in the process (e.g. after providing a mnemonic phrase).
Steps to reproduce the problem

Imit the regtest environment
Try to create or import a wallet names "Satoshi" (which already exists)
Notice that an error occurs when submitting the last step - which could be known earlier

Thanks to @editwentyone for reporting this.

Resolved in #720. Thank you @zmjohnso :pray:


Turtle Egg missing from Miscellaneous tab

The Turtle Egg is not next to the Sniffer Egg in the Creative Miscellaneous tab. This can be seen in creative_tab_listing.json where minecraft:turtle_egg is misspelled as "minecraft:creturtle_egg".

Thanks for reporting this mistake, it will be fixed in the next update.


Support for rendering list links from xwing-builder.co.uk

The bot currently supports parsing lists mentioned with https://geordanr.github.io/xwing/ links, but a large majority of users use xwing-builder.co.uk (including list juggler escrow for the vassal league).
I'm currently working on a separate chatbot for league stuff that will eventually include posting messages when a match has been escrowed.  This will likely just post the URLs to the lists they used in the escrow.  If both squad builders are supported, this would enable the league chat bot (lobot) to show the full list contents via r2-d7.
Is there any technical reason this cannot be done or won't be done?  I'd be up for contributing if needed.
Thanks!

(Sorry for the delay, apparently yo don't watch your own repos by default)
I looked into this a while ago and the problem I hit was that the xwing-builder links don't encode the list like YASB does, so you need to either scrape the page or get xwing-builder to generate XWS (and then scrape that because it doesn't provide it in an easy to reach API), so you're effectively creating a whole new list printer. It's not impossible, but it's quite a lot of work and I never use xwing-builder (YASB is way better, IMO) so I'm not motivated to do it.
I would absolutely be up for integrating it if someone else wants to do the work.

Cool.  I was looking into the codebase after I made this issue and then realized how closely integrated it was with YASB.
Looks like xwing-builder.co.uk has XWS export via http://xwing-builder.co.uk/xws/487314?dl=1
I didn't immediately see anywhere on YASB where it can export XWS.

Ah-ha, I couldn't find a way to get the XWS outside the HTML page. That would make it easier.
YASB has an export to XWS button at the bottom of the page, but I don't see a way to just request the XWS.
Writing a separate list printer to parse XWS (maybe using https://github.com/guidokessels/xwing-data rather than the YASB data) and having that respond to xwing-builder links wouldn't be too difficult.

@geordanr is there a way to get XWS from a permalink via an "API" call?

Given a permalink you can get XWS by sending the query string to https://yasb-xws.herokuapp.com
E.g.
Permalink
XWS link

Awesome, thanks @geordanr.

I've got this mostly working. It needs some more testing, but should be done this weekend.

Thanks!  This is awesome!


PR: Allow to not show again message about DPI screen changes

Description of Changes

That message can become very annoying for people that use several screens and turn them on/off all the time.
This moves all code related to showing that message to the Application plugin.
It also removes some unused imports in the Console plugin.

Issue(s) Resolved

Fixes #14479
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/app/mainwindow.py:

Line 52:1: E402 module level import not at top of file

to see the dialog again you will need to reset your preferences or manually change the spyder.ini file, right?

Yeah, that's correct. The problem is several people have requested us to avoid showing that dialog ever again because it's triggered many times when switching screens.

If that's the behavior wanted then this LGTM +1

Great! Thanks for the review @dalthviz!


Repeat Table Headers on Every Pages

I have problem to configure a table to repeat the header row for every pages. Does anyone have ideas to make this happen?

And what is wrong with this?
WordTable wordTable = document.AddTable(4, 4, WordTableStyle.TableNormal);
wordTable.RepeatHeaderRowAtTheTopOfEachPage = true;
wordTable.Rows[0].Cells[0].Paragraphs[0].Text = "Test 1";
wordTable.Rows[1].Cells[0].Paragraphs[0].Text = "Test 2";
wordTable.Rows[2].Cells[0].Paragraphs[0].Text = "Test 3";
wordTable.Rows[3].Cells[0].Paragraphs[0].Text = "Test 4";

There are other properties available too


Issues/225

See https://github.com/oras-project/oras-go/issues/225 for details, but here's the tldr:
% oras pull<PHONE_NUMBER>87.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Error: GET "https://080565210187.dkr.ecr.us-west-2.amazonaws.com/v2/my.repo/manifests/my.tag": empty response Docker-Content-Digest

The expected outcome (what this PR claims to fix):
% oras pull<PHONE_NUMBER>87.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Downloading 3cd22ae067a3
Downloaded empty artifact
Pulled<PHONE_NUMBER>87.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Digest: sha256:32aef68c20b6f25d69ecbc2f3f98e28f6f6fdacade75ee879459b61f610583f0

Resolves #225

repro prior to the change:
➜  DoodleContainers git:(mainline) ✗ make
################################################################################
#------------------------------------------------------------------------------- oci:/home/nima/docker/config.json
aws --profile nima@ecr --region us-west-2 ecr get-login-password | docker login --username AWS --password-stdin<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com
WARNING! Your password will be stored unencrypted in /home/nima/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded

#------------------------------------------------------------------------------- oci:/home/nima/docker/config.json
aws --profile nima@ecr --region us-west-2 ecr get-login-password | oras login --username AWS --password-stdin<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com
Login Succeeded

#------------------------------------------------------------------------------- oci:setup
aws --profile nima@ecr --region us-west-2 ecr create-repository --repository-name my.repo --image-scanning-configuration scanOnPush=true | jq .
{
  "repository": {
    "repositoryUri": "12345678901.dkr.ecr.us-west-2.amazonaws.com/my.repo",
    "imageScanningConfiguration": {
      "scanOnPush": true
    },
    "encryptionConfiguration": {
      "encryptionType": "AES256"
    },
    "registryId": "12345678901",
    "imageTagMutability": "MUTABLE",
    "repositoryArn": "arn:aws:ecr:us-west-2:12345678901:repository/my.repo",
    "repositoryName": "my.repo",
    "createdAt":<PHONE_NUMBER>
  }
}

#------------------------------------------------------------------------------- oci:setup
docker image build --tag my.repo:my.tag .
Sending build context to Docker daemon    276kB
Step 1/8 : FROM alpine:latest
 ---> e66264b98777
Step 2/8 : RUN mkdir -p /docked
 ---> Using cache
 ---> b70ff30822c5
Step 3/8 : WORKDIR /docked
 ---> Using cache
 ---> adbf13e74342
Step 4/8 : RUN apk add --no-cache socat
 ---> Using cache
 ---> 10673949eac4
Step 5/8 : EXPOSE 1234
 ---> Using cache
 ---> fe6e2db39608
Step 6/8 : EXPOSE 4321
 ---> Using cache
 ---> 69b73391ecf3
Step 7/8 : ENTRYPOINT [ "socat" ]
 ---> Using cache
 ---> 7ed365f9b91e
Step 8/8 : CMD [ "TCP4-LISTEN:1234", "TCP4-LISTEN:4321" ]
 ---> Using cache
 ---> cffeefdfa844
Successfully built cffeefdfa844
Successfully tagged my.repo:my.tag

#------------------------------------------------------------------------------- oci:setup
docker image tag my.repo:my.tag<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag

#------------------------------------------------------------------------------- oci:setup
docker image push<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
The push refers to repository [12345678901.dkr.ecr.us-west-2.amazonaws.com/my.repo]
336abb34c67c: Pushed
26a6b0d4e0cf: Pushed
24302eb7d908: Pushed
my.tag: digest: sha256:b9b2c380a97b8b4ab2acfd3d88850bc3ce2b95e803af33ac382e002b6683fbfd size: 945

#------------------------------------------------------------------------------- oci:main
docker image rm my.repo:my.tag
Untagged: my.repo:my.tag

#------------------------------------------------------------------------------- oci:main
oras pull<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Error: GET "https://12345678901.dkr.ecr.us-west-2.amazonaws.com/v2/my.repo/manifests/my.tag": empty response Docker-Content-Digest

make: *** [oci.main] Error 1
➜  DoodleContainers git:(mainline) ✗

compiling the client against local lib...
git diff|cat
diff --git a/go.mod b/go.mod
index 958afdf..418ab8f 100644
--- a/go.mod
+++ b/go.mod
@@ -2,6 +2,8 @@ module oras.land/oras

 go 1.18

+replace oras.land/oras-go/v2 => /Users/nima/Development/github/oras-go
+
 require (
 	github.com/docker/cli v20.10.17+incompatible
 	github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6

run test again...
➜  DoodleContainers git:(mainline) ✗ make
################################################################################
#------------------------------------------------------------------------------- oci:/home/nima/docker/config.json
aws --profile nima@ecr --region us-west-2 ecr get-login-password | docker login --username AWS --password-stdin<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com
WARNING! Your password will be stored unencrypted in /home/nima/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded

#------------------------------------------------------------------------------- oci:/home/nima/docker/config.json
aws --profile nima@ecr --region us-west-2 ecr get-login-password | oras login --username AWS --password-stdin<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com
Login Succeeded

#------------------------------------------------------------------------------- oci:setup
aws --profile nima@ecr --region us-west-2 ecr create-repository --repository-name my.repo --image-scanning-configuration scanOnPush=true | jq .
{
  "repository": {
    "repositoryUri": "12345678901.dkr.ecr.us-west-2.amazonaws.com/my.repo",
    "imageScanningConfiguration": {
      "scanOnPush": true
    },
    "encryptionConfiguration": {
      "encryptionType": "AES256"
    },
    "registryId": "12345678901",
    "imageTagMutability": "MUTABLE",
    "repositoryArn": "arn:aws:ecr:us-west-2:12345678901:repository/my.repo",
    "repositoryName": "my.repo",
    "createdAt":<PHONE_NUMBER>
  }
}

#------------------------------------------------------------------------------- oci:setup
docker image build --tag my.repo:my.tag .
Sending build context to Docker daemon    276kB
Step 1/8 : FROM alpine:latest
 ---> e66264b98777
Step 2/8 : RUN mkdir -p /docked
 ---> Using cache
 ---> b70ff30822c5
Step 3/8 : WORKDIR /docked
 ---> Using cache
 ---> adbf13e74342
Step 4/8 : RUN apk add --no-cache socat
 ---> Using cache
 ---> 10673949eac4
Step 5/8 : EXPOSE 1234
 ---> Using cache
 ---> fe6e2db39608
Step 6/8 : EXPOSE 4321
 ---> Using cache
 ---> 69b73391ecf3
Step 7/8 : ENTRYPOINT [ "socat" ]
 ---> Using cache
 ---> 7ed365f9b91e
Step 8/8 : CMD [ "TCP4-LISTEN:1234", "TCP4-LISTEN:4321" ]
 ---> Using cache
 ---> cffeefdfa844
Successfully built cffeefdfa844
Successfully tagged my.repo:my.tag

#------------------------------------------------------------------------------- oci:setup
docker image tag my.repo:my.tag<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag

#------------------------------------------------------------------------------- oci:setup
docker image push<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
The push refers to repository [12345678901.dkr.ecr.us-west-2.amazonaws.com/my.repo]
336abb34c67c: Pushed
26a6b0d4e0cf: Pushed
24302eb7d908: Pushed
my.tag: digest: sha256:b9b2c380a97b8b4ab2acfd3d88850bc3ce2b95e803af33ac382e002b6683fbfd size: 945

#------------------------------------------------------------------------------- oci:main
docker image rm my.repo:my.tag
Untagged: my.repo:my.tag

#------------------------------------------------------------------------------- oci:main
oras pull<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Downloaded empty artifact
Pulled<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Digest:

#------------------------------------------------------------------------------- oci:teardown
docker image rm my.repo:my.tag
Error: No such image: my.repo:my.tag

make: [oci.teardown] Error 1 (ignored)
#------------------------------------------------------------------------------- oci:teardown
docker image rm<PHONE_NUMBER>1.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Error response from daemon: conflict: unable to remove repository reference "12345678901.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag" (must force) - container 799004d623e6 is using its referenced image cffeefdfa844

make: [oci.teardown] Error 1 (ignored)
#------------------------------------------------------------------------------- oci:teardown
aws --profile nima@ecr --region us-west-2 ecr batch-delete-image --repository-name my.repo --image-ids imageTag=my.tag | jq .
{
  "failures": [],
  "imageIds": [
    {
      "imageTag": "my.tag",
      "imageDigest": "sha256:b9b2c380a97b8b4ab2acfd3d88850bc3ce2b95e803af33ac382e002b6683fbfd"
    }
  ]
}

#------------------------------------------------------------------------------- oci:teardown
aws --profile nima@ecr --region us-west-2 ecr delete-repository --repository-name my.repo | jq .
{
  "repository": {
    "repositoryUri": "12345678901.dkr.ecr.us-west-2.amazonaws.com/my.repo",
    "registryId": "12345678901",
    "imageTagMutability": "MUTABLE",
    "repositoryArn": "arn:aws:ecr:us-west-2:12345678901:repository/my.repo",
    "repositoryName": "my.repo",
    "createdAt":<PHONE_NUMBER>
  }
}

GUIDE            : https://www.freecodecamp.org/news/the-docker-handbook/
DEMO             : oci
TARGET           : oci
ORAS_CLIENT_PATH : /home/nima/bin/oras
ORAS_CLIENT      : 0.13.0+unreleased
DOCKER_CLIENT    : 20.10.7
DOCKER_SERVER    : 20.10.7
################################################################################
➜  DoodleContainers git:(mainline) ✗

Thanks @nima for the PR! Please let us know if this is ready for review. 😀

Thanks @nima for the PR! Please let us know if this is ready for review. 😀

Thanks for taking a look @Wwwsylvia -- I have another PR out now, it's not intended to be approved, only to be inspected because I'm still not sure how to deal with the current issue.  I'm maintaining a log of my thoughts in a thread in the #oras slack channel, and also in the git commit message body.

[INFO] Current slack thread for this round.

I've set this to R4R despite the failure to expose the PR.  The failure is due to the fact that one of the dependencies of this package, go-digest, has also been modified as part of this change.  Locally, I've been using thereplace directive in go.mod to point it to the locally modified version, but I'm not sure how to go about it here, other than get that change separately approved and merged in first, then continue with this.

Few general comments to make this PR better.

Please follow conventional commits for PR title and body.
Please link this PR to an issue.
It is better to have a ruler at 80 chars for comment blocks so that people with small screens can read the code easily.
Try not to modify the code of dependencies. If it is really needed, try proposing and merging the required changes to the upstream first.

Thanks for the pointers Shiwei, the first doc is specially useful.  I can retrospectively update my commit messages.
As for the second item, I've used the branch name issues/225; trying to do it the correct way manually, I don't seem to get the gear icon and unable to make the connection.
The third point, I believe I have done that already; can you point me to where I haven't?
And finally the last point, yes I'll keep that in mind; in this case I believe the change is still required; further clarity will no doubt come out at review time.

Few general comments to make this PR better.

Please follow conventional commits for PR title and body.
Please link this PR to an issue.
It is better to have a ruler at 80 chars for comment blocks so that people with small screens can read the code easily.
Try not to modify the code of dependencies. If it is really needed, try proposing and merging the required changes to the upstream first.

The ORAS community also has a simple version of Git Conventions for references.

I've published a new PR; I have hopefully addressed all comments (which by the way were very helpful).
The only item I have not addressed in this PR, is to split this PR into two (one for the bug-fix, and one for changes to reference*.go).
I also have a few items that I have addressed, but are requesting further feedback; nothing major.

Codecov Report

Merging #237 (8b267fc) into main (1c2d196) will decrease coverage by 0.45%.
The diff coverage is 47.91%.

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   70.63%   70.17%   -0.46%
==========================================
  Files          36       36
  Lines        3293     3363      +70
==========================================
+ Hits         2326     2360      +34
- Misses        718      750      +32
- Partials      249      253       +4

Impacted Files
Coverage Δ

registry/remote/repository.go
63.23% <45.05%> (-1.73%)
:arrow_down:

registry/reference.go
75.53% <100.00%> (+1.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

And a final double-check...
% oras pull<PHONE_NUMBER>87.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Downloaded empty artifact
Pulled<PHONE_NUMBER>87.dkr.ecr.us-west-2.amazonaws.com/my.repo:my.tag
Digest: sha256:410bc64c7dbbc3286211561a0f6ca43affdca5c92c568f838a37e34640f5f76e

Thanks @nima for chasing this issue down, and @shizhMSFT @Wwwsylvia  for the reviews!
@shizhMSFT @FeynmanZhou do we plan to release this fix with a patch release?

We plan to release this in the next rc release.

Nope! That’s my Java showing 😇… carry on.
On Thu, Aug 18, 2022 at 17:25 Nima Talebi @.***> wrote:

@.**** commented on this pull request.
In registry/remote/repository.go
https://github.com/oras-project/oras-go/pull/237#discussion_r949699977:

  return fmt.Errorf("%s: mismatch digest: %s", expected, contentDigest)

}
return nil
}
+// verifyContentDigests is a superset of verifyContentDigest; it takes in the actual (calculated) digest, and
+// verifies against that, the other two digests, both of which may or may not be set to the empty digest.  If empty,
+// there is no validation error, however is not empty, it ensures that the given digest is valid (matches the actual
+// digest)
+func verifyContentDigests(actualDigest digest.Digest, digests map[string]digest.Digest) error {

for src, d := range digests {

if len(d.String()) == 0 {

Because you can't set a string to a nil; it's not a *digest.Digest
(pointer). Am I missing something?
—
Reply to this email directly, view it on GitHub
https://github.com/oras-project/oras-go/pull/237#discussion_r949699977,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIDST5SMDJGM3IW22JF4CDVZ3IBBANCNFSM53IDEHXQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Missing Title: Star Wars Republic Commando

Could you please add Star Wars: Republic Commando to the games list? Thanks!

I have added the game(s) you requested in the most recent release: https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/v1.1.3
Thank you for checking out the project, reach out if you have any more suggestions!


Install dependencies from GitOps operator

The GitOps operator should be capable of configuring and installing GitOps specific dependencies on your OpenShift cluster. This will eliminate the hassle of manual configuration by creating all the required resources out of the box.
Since OLM doesn't support cross-namespace dependency resolution, only the pipeline operator will be installed by OLM. The GitOps operator will manually create namespaces(argocd/<prefix>-cicd) and install ArgoCD/SealedSecret operators by creating operator groups and subscriptions.
prefix field will be introduced in the GitOpsService API for accepting prefix from the user. --prefix flag from kam bootstrap command will be deprecated to maintain consistency between operator created resources and kam CLI. The bootstrap command can directly fetch the prefix from the cluster. In the future, the CR can support more fields and provide control over the installation of ArgoCD/SealedSecrets
Example:
apiVersion: pipelines.openshift.io/v1alpha1
kind: GitopsService
metadata:
  name: example-gitopsservice
spec:
  prefix: example       # The reconciler will use this prefix while creating <prefix>-cicd namespace

Workflow:

User will install the GitOps operator from OperatorHub. OLM will install the dependent OpenShift pipeline operator.
User will create the GitOps CR and specify the prefix.
The reconciler will read the prefix and install ArgoCD and SealedSecret operators in the right namespace.
The reconciler will then create CRs for ArgoCD and SealedSecret.

Co-authored by: @gaganhegde
Edit 1: Based on the recent discussion, the prefixes will be maintained by a Configmap created by the gitops operator. This is due to the fact that the operator should support multiple GitOps workflows(multiple prefixes). The operator will create a Configmap named gitops-config to store configuration information such as timeout and prefixes. Example
kind: ConfigMap
apiVersion: v1
metadata:
  name: gitops-config
  namespace: openshift-operators
data:
  timeout: 2m
  gitops-prefixes: alpha, beta,gamma,""'

For the above Configmap, the controller will reconcile and create cicd namespaces with the prefixes in gitops-prefixes.
Changes in KAM CLI:
During the bootstrap process, the CLI will add <prefix> to the existing Configmap thereby creating the required prefix-cicd namespace.
Edit 2: Since the sealed secret operator cannot handle multiple instances, this PR will only add ArgoCD and Pipelines Operator as dependencies.

@bigkevmcd @wtam2018 Removed sealed secret operator dependency. Please consider it for review

/retest

/retest

/approve

/approve

/lgtm


gtk-{2,3,4}: add changelog url

Motivation for this change
Just add a changelog
Notify Maintainers
@worldofpeace @7c6f434c @vcunat @lethalman
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Is there a changelog link which does not require a login?

Is there a changelog link which does not require a login?

E. g., https://gitlab.gnome.org/GNOME/gtk/-/raw/4.1.0/NEWS works for me without login.

E. g., gitlab.gnome.org/GNOME/gtk/-/raw/4.1.0/NEWS works for me without login.

I visited https://gitlab.gnome.org/GNOME/gtk/-/raw and it prompted me for a login.


Add community page with Keybase how-to

Description
Following an action point in the last dev meeting, this PR adds a Community section to the website with:

links to Keybase, forum, and mailing list
information about how to join the main keybase team
information about the bi-weekly meetings and links to meeting notes and agendas

Preview

@quentinlesceller @nijynot wyt?