How to yarn/npm link pixi.js into a webpack

This is not a bug request as such but is for anyone else who ends up searching the issues for a solution to this.
When you yarn link or npm link pixi.js into a webpack built application you will likely come across the error:

Cannot read property 'start' of undefined

This is because of the way node_modules are handled in the monorepo. Where each package contains a node_modules folder which symlinks to the other packages in the monorepo it requires. Because each package ends up with its own symlink webpack loads each import for each module again (depending on your webpack symlink following rules).
The simplest solution I found to this is adding the following resolve.alias config to webpack:
{ '@pixi': 'pixi.js/node_modules/@pixi' }

This tells webpack to route any @pixi/* import to the node_modules in bundles/pixi.js which contains all the dependencies except @pixi/jsdoc-template so if you need that you will need to add another rule for that.
Note: This could be resolved in pixi.js by using yarn workspaces to manage the pixi.js monorepo which hoist monorepo imports to top level node_modules to prevent this.

Yeah, not possible to just link pixi.js to the project like I did with v4. That's a problem.

 Did you find a workaround?

@bigtimebuddy I didn't see this problem per say. My local template's Webpack config is:
const HtmlWebPackPlugin = require('html-webpack-plugin');
const CopyWebpackPlugin = require('copy-webpack-plugin');
const path = require('path');

module.exports = {
    mode: 'development',
    entry: './src/index.js',
    output: {
        path: path.resolve(__dirname, 'dist'),
        filename: 'app.bundle.js',
    },
    module: {
        rules: [
            {
                test: /\.(js)$/,
                exclude: /node_modules/,
                use: {
                    loader: 'babel-loader',
                },
            },
            {
                test: /\.html$/,
                use: [
                    {
                        loader: 'html-loader',
                    },
                ],
            },
            {
                test: /\.jpeg$/,
                use: {
                    loader: 'file-loader',
                },
            },
        ],
    },
    plugins: [
        new HtmlWebPackPlugin({
            template: './src/index.html',
            filename: './index.html',
        }),
        new CopyWebpackPlugin([{
            from: './src/assets', to: './assets',
        }]),
    ],
    watchOptions: {
        aggregateTimeout: 300,
        ignored: ['/node_modules/(?!pixi.js)/'],
    },
};

I don't see anything special here.

@ivanpopelyshev  @bigtimebuddy I remember now, I couldn't link pixi.js using npm link. So I import as:
const PIXI = require('../../pixi.js/bundles/pixi.js/lib/pixi');
import * as PIXI from '../../pixi.js/bundles/pixi.js/lib/pixi.es';

I don't see anything special here.

This may be due to my resolve.symlinks settings then . I have it set to false.

I created pixi-fiddle to make it easier for new developers to work on PixiJS. You can clone this repo (https://github.com/SukantPal/pixi-fiddle).

Create a fiddle.config.json file and add a pkgWatch object telling the package where your local pixi.js build is (make sure it points to the .cjs bundle):

{
    "pkgWatch": {
         "pixi.js": "relative/path/to/pixi.js/"
    }
}

npm run open -- --fiddle myfiddle

An index.js file with a const PIXI = window.PIXI || require('../relative/path/to/pixi.js') will already be present. You can add code to experiment with PixiJS.
npm run start will run your fiddle in the local browser.


Rock Crystals Not Found

Are rock crystals from Astral Sorcery actually enabled in the ore gen?
Based on astralsorcery.cfg, they are disabled:
# Generate rockcrystals [default: true]
B:Generate=false
Now, there could be custom gen somewhere, but I don't know how to find that =)
I tried looking at the "orespawn" files, but didn't see any mention of them there.
I've tried using the resonating wand to locate them, but that doesn't work (even if I place them in creative).
I've tried clearing out dozens of chunks worth of blocks near bedrock, but found none that way either.
Am I wasting my time?

Astral Rock Crystals do spawn, they are in deep coal veins between Y levels 0-20.
Config is located at: \config\cofh\world/05_new_ore_gen.json.

Looks like this

Ah, cool. I've found those, but can't mine diamond yet, so maybe it's stuck inside.
Thanks!

No problem, thanks for the report! I'm looking into why Rockcrystal ore doesn't glow.

My guess is the glow is tied to the default ore gen, marking the locations as it generates chunks.
Since that's disabled, nothing is "marked" along the way.
No idea if it's possible to hook into that in "configuration" without it being built into to the custom ore gen mod (or maybe do a post-gen scan).

Seems to be the case. I’m testing turning it back on, as well as keeping the crystals in the deep ore veins


How to translate L2 score to accuracy?

With the output of the neural network (face embeddings), we can compute similarity score or euclidean distance between embeddings. Then, we can define a threshold and perform verification tasks.
But, is there a method to translate this metric into accuracy?
Thanks!

@erinehoo  Did you get any solution?
Please share!
Thanks!!


Documentation of language basics "Conditional Compilation" is wrong and broken for Windows

The documentation for Conditional Compilation references the source of basic defined variables such as "UNAME_SYSNAME" and others using the following phrasing:
corresponding to the values returned by :func:`os.uname`.

This is technically incorrect because the actual source of these variables in Cython is platform.uname(), but the serious problem is that os.uname does not even exist on the Windows platform. This makes it difficult for new users to understand what to expect when using Conditional Compilation if they are developing on Windows.
I recommend updating the source of the documentation to reflect this. I am new to this community and not certain of the pull request rules (especially regarding documentation), so I have not yet prepared a pull request.

Please just send a PR. Platforms specific fixes are generally maintained by people using that platform.


Vizualize VmType

Label denoting VM's type is displayed on VmDetail.
Handles Desktop, Server, HighPerformance.
Depends on not yet merged https://gerrit.ovirt.org/#/c/77961
Fixes: https://github.com/oVirt/ovirt-web-ui/issues/239

I think concept of labels is fine for this purpose.
@jniederm , would you change styling of them? Colors?

I'd visualize it just like other regular properties (for example State or Description) because

there already are two types of label in the engine (standard and SLA ones) and a time may come when we will need to visualize these
a time may come when we will need to change or set "Optimized for" property in edit/new pages. In such situation it will be natural to visually just replace a text by a dropdown.

Right, this makes sense.

@jniederm , what do you think?

Cc @sgratch

Looks very good to me.
Few small comments to consider:

desktop->Desktop (capitalize the first letter).
Consider locating this property under/after the 'Template' property, since changing the Template may change the 'Optimized For' value since it is inherited from it (the properties displaying order has some logic I guess..)
What about displaying this property also for Templates now or in the future?

@sgratch , thanks

Done
Done
Good point, we will think about it when adding Templates view

Merging since agreed otherwise


Release sqlite website files

I just released the website files, finally!
You can see this is some pretty old stuff. But I am working on a new version that works with SQLite. However I don't want to publish it until the SQLite data import works well (#3).

I have the TrainView data from 2008 until present. Maybe nobody is interested in that.
Otherwise database import is now documented in https://github.com/fulldecent/septa-regionalrail-otp/tree/master/website/databases


Release azure-cli-redis 0.2.1

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Codecov Report

Merging #3074 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3074   +/-   ##
=======================================
  Coverage   70.72%   70.72%
=======================================
  Files         357      357
  Lines       22906    22906
  Branches     3526     3526
=======================================
  Hits        16201    16201
+ Misses       5610     5607    -3
- Partials     1095     1098    +3

Impacted Files
Coverage Δ

src/azure-cli-core/azure/cli/core/util.py
66.42% <0%> (ø)
:arrow_up:

...-cli-role/azure/cli/command_modules/role/custom.py
35.74% <0%> (ø)
:arrow_up:

...dback/azure/cli/command_modules/feedback/custom.py
34.69% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7f2b0...343588a. Read the comment docs.

Started releasing azure-cli-redis 0.2.1...

Release of 'azure-cli-redis' with version '0.2.1' successful. View at https://pypi.python.org/pypi/azure-cli-redis/0.2.1.

GitHub release created. https://github.com/Azure/azure-cli/releases.


⚠ AGEG website (redirect) has degraded performance

In 5514f4a, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2867 ms

Resolved: AGEG website (redirect) performance has improved in 93a837e.


Add hostAliases to Helm values for Flow Aggregator

Add hostAliases to Helm values for Flow Aggregator
User might want to use hostAliases field when connecting Flow Aggregator to ClickHouse through Ingress/LoadBalancer.
It is also convenient for e2e test.
Signed-off-by: Yun-Tang Hsu<EMAIL_ADDRESS>

/test-all


Only x264 or H264 results

I'm currently using a Raspberry Pi3B+.
It doens't have h265/x265 hardware decoding capabilities.
Is there a way that I can filter the results for only h264/x264 torrents?
Thanks

Yes, you can put keywords to be excluded in the settings.

Thanks to @axelsimon I found a way to workaround my issue.
Solved.


[Kubeflow on AWS] Build and linkcheck in Docker - WIP - DO NOT MERGE

Experimenting with this linkchecker https://github.com/linkchecker/linkchecker.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+1
Lets try to add a Github action which can build the website and check broken links on PR creation

Feel free to reopen the PR when ready


Fused function copies return values

import numpy
import cupy

@cupy.fuse()
def f(x):
    return x

for xp in (numpy, cupy):
    x = xp.array([1, 2, 3])
    y = f(x)
    print(x is y)

True
False

I just checked this and it still is not working cupy 5.1

(Cont. from https://github.com/chainer/chainer/issues/5799)
@cems2 Anyway, your code should work correctly. There is a bug.
At first sight, it might look like the bug can be solved by adding write-back to every array passed as an argument, if it is performed in-place updated.
But this is not enough. Consider the case input arrays are partially overlapped. CUDA kernel can't handle such inputs, unless global sync on CUDA 9.0 or handmade spin-lock via atomicCAS is used. Probably it is better to disable fusion or split kernels for such input, but such remedies requires analysis of overlapping.
If we become pessimistic, such analysis is not hard; this is one option. Then performance benefit achieved by array reusing will disappear.
Recent NumPy has a good heuristic for this analysis. https://github.com/numpy/numpy/pull/8043 Adding such analysis is another option. If we take this way, the thing like #1870 is not required for performance, though I still personally likes ufunc-like keyword argument support.


[Feature]: Developer can apply a minimal space manifest to map a single route to an app

Blockers/Dependencies
No response
Background
As an App Developer
I want to be able to provide route configuration for my App as a declarative manifest
So that I can configure routes to my App without scripting imperative CLI commands or orchestrating API calls
For this story, we focus on the creation of explicitly defined routes in the routes field of the manifest spec.
---
version: 1
applications:
  - name: my-app
     ...
     routes:
     - route: my-app-host.example.com

Acceptance Criteria
Scenarios
Happy Path (Route does not exist)
GIVEN I have a cluster with a cfdomain already created for "example.com" and a manifest that specifies a route that does not currently exist
WHEN I send it to the CF API Shim with the following request
curl "https://api-shim.example.org/v3/spaces/<space-guid>/actions/apply_manifest" \
  -X POST \
  -H "Authorization: bearer [token]" \
  -H "Content-type: application/x-yaml" \
  --data-binary @/path/to/manifest.yml

where the filepath refers to a file of the form:
---
version: 1
applications:
  - name: app1
    routes:
      - route: my-host.example.com

THEN I I see a CFRoute created in the appropriate namespace with the specified FQDN mapped to app1.
HTTP/1.1 202 Accepted
Location: https://api-shim.example.org/v3/jobs/sync-space.apply_manifest-<space-guid>

Happy Path (Route exists but is not mapped to app)
GIVEN I have a cluster with a cfdomain already created for "example.com" and a manifest that specifies a route that already exists
WHEN I send it to the CF API Shim with the following request
curl "https://api-shim.example.org/v3/spaces/<space-guid>/actions/apply_manifest" \
  -X POST \
  -H "Authorization: bearer [token]" \
  -H "Content-type: application/x-yaml" \
  --data-binary @/path/to/manifest.yml

where the filepath refers to a file of the form:
---
version: 1
applications:
  - name: app1
    routes:
      - route: my-host.example.com

THEN I I see the CFRoute with the specified FQDN updated to be mapped to app1.
HTTP/1.1 202 Accepted
Location: https://api-shim.example.org/v3/jobs/sync-space.apply_manifest-<space-guid>

Happy Path (newly created Route includes a path)
GIVEN I have a cluster with a cfdomain already created for "example.com" and a manifest that specifies a route that does not currently exist
WHEN I send it to the CF API Shim with the following request
curl "https://api-shim.example.org/v3/spaces/<space-guid>/actions/apply_manifest" \
  -X POST \
  -H "Authorization: bearer [token]" \
  -H "Content-type: application/x-yaml" \
  --data-binary @/path/to/manifest.yml

where the filepath refers to a file of the form:
---
version: 1
applications:
  - name: app1
    routes:
      - route: my-host.example.com/some-path

THEN I I see a CFRoute created in the appropriate namespace with the specified FQDN and path mapped to app1.
HTTP/1.1 202 Accepted
Location: https://api-shim.example.org/v3/jobs/sync-space.apply_manifest-<space-guid>

Unhappy Path
GIVEN I have a cluster and a manifest that specifies an invalid route (E.G. domain not yet created)
WHEN I send it to the CF API Shim with the following request
curl "https://api-shim.example.org/v3/spaces/<space-guid>/actions/apply_manifest" \
  -X POST \
  -H "Authorization: bearer [token]" \
  -H "Content-type: application/x-yaml" \
  --data-binary @/path/to/manifest.yml

where the filepath refers to a file of the form:
---
version: 1
applications:
  - name: app1
    routes:
      - route: my-host.example.com

THEN I I see the CFRoute with the specified FQDN is NOT created.
HTTP/1.1 422 Unprocessable Entity
Content-Type: application/json

{
   "errors": [
      {
         "detail": "Manifest contains invalid attributes",
         "title": "CF-UnprocessableEntity",
         "code": 10008
      }
   ]
}

Dev Notes

We want the manifest to function the same as the individual endpoints for various actions it can take. Try and factor out logic into reusable pieces where possible. The main difference here should be in the request parsing layer.
Much of the logic for route manifest apply is in https://github.com/cloudfoundry/cloud_controller_ng/blob/a63cfe80d92e8f153db89d10963f10f9173a2f69/app/actions/app_apply_manifest.rb#L88-L121
Only support the first route in the routes field for now and ignore related unsupported fields. We will follow up with further field support in separate issues.
Only support HTTP routing initially (so port may not be specified on the route)

WIP is on issues/354

Closing: Issue addressed by https://github.com/cloudfoundry/cf-k8s-controllers/pull/372/


Hasan.mahmood/build fixes

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

@hmahmood The HTTP PRs this depended on, have merged if you want to rebase and get this ready for review.


Add support for arm64/armhf builds

This change adds support for multi-arch images (arm64/armhf) which includes devices like a Raspberry Pi. I've also changed the base build image to ldez/traefik-certs-dumper instead of docker which simplifies the image and makes it smaller.
This won't do anything by itself, you'll need to update your build process to build each Dockerfile individually, push them to Docker Hub individually and then create and push a manifest file with the proper tags.
I personally use GitHub Actions for all of this and although I don't have the most simplified process, here's an example for you:

https://github.com/rfgamaral/docker-gphotos-uploader/tree/master/.github

I've also did a similar thing to my fork just for testing purposes:

https://github.com/rfgamaral/traefik-certs-dumper/tree/preview/.github
https://hub.docker.com/repository/docker/rfgamaral/traefik-certs-dumper

Hi,
the current image uses Docker due to restart functionality. However, #8 addresses this issue indirectly which means it's not a bad idea to use ldez/traefik-certs-dumper as a base image. It would have been fine too to add multi-arch images as well.
I quickly scanned over it and it looks fine to me, but we may

have to update run.sh to check the availability of Docker inside the container
think about how to name the tags

About #8: Maybe we can consider combining issues together

the current image uses Docker due to restart functionality.

I wasn't aware of this, sorry... I guess #8 needs to be done first. Or maybe I shouldn't have made two changes in one PR, sorry about that.

Ah, don’t worry. :D
With your multi-arch suggestion, I guess it’s a good time now to start with #8 and maybe combine it with your PR or something. I start working on it.
Von: Ricardo Amaral<EMAIL_ADDRESS>Gesendet: Samstag, 29. August 2020 12:28
An: humenius/traefik-certs-dumper<EMAIL_ADDRESS>Cc: humenius<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Betreff: Re: [humenius/traefik-certs-dumper] Add support for arm64/armhf builds (#21)
the current image uses Docker due to restart functionality.
I wasn't aware of this, sorry... I guess #8 https://github.com/humenius/traefik-certs-dumper/issues/8  needs to be done first. Or maybe I shouldn't have made two changes in one PR, sorry about that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/humenius/traefik-certs-dumper/pull/21#issuecomment-683270967 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYIHYNNMQGW6A4ZHX2H2LTSDDJ4LANCNFSM4QK4W75Q .  https://github.com/notifications/beacon/ABYIHYNI3YNHOJTP2CBAVW3SDDJ4LA5CNFSM4QK4W752YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFC46GNY.gif

* have to update `run.sh` to check the availability of Docker inside the container

What do you mean? I don't think you need to do much...

* think about how to name the tags

My recommendation is to follow what I have done here: https://hub.docker.com/repository/docker/rfgamaral/traefik-certs-dumper/tags?page=1 (replace preview with latest or a version number).

* have to update `run.sh` to check the availability of Docker inside the container

Yeah, I figured you can check if the docker command exists via [ -x "$(command -v docker)" ]

* think about how to name the tags

My recommendation is to follow what I have done here: https://hub.docker.com/repository/docker/rfgamaral/traefik-certs-dumper/tags?page=1 (replace preview with latest or a version number).

Yep, looks fine. Also, we can prepend the version number and omit it for latest releases.
I try to start working on it. 👍

Sorry that this took some time. I really like your suggestion of using GitHub Actions and how it works. Looks pretty neat. I cherry-picked your commit and modified it a little bit.
I also added the image variations docker and alpine. Best way to find out if the images work is to build them and check for errors. Maybe we can add another workflow or step for test-building the images.

Looks good.
But I don't recommend custom actions like I originally did on my repo, makes it harder to maintain (although I haven't touched that code since I first added it). I believe there are third-party actions available in the marketplace that perhaps you could use to simplify the build process but I haven't personally looked much into that yet.

I probably have to merge this one as of GitHub, secrets cannot be passed to forked repositories.

I probably have to merge this one as of GitHub, secrets cannot be passed to forked repositories.

You can always merge it and give the finishing touches on the develop branch until it's ready to be merged to master :)


Fix a typo in packages/react-scripts/template/README.md

s/allows to easily makes/allows you to easily make/

@petent makes sense, thank you
fixed

Thanks!


ImportError: cannot import name spec

Hi sir,
amqp Version: 2.1.4
djang version: 1.11.1
celery version: 4.0.2
apache version: 2.4

I want to use celery in my django project. The project is served by apache-server.
When the server is started. There are an error display:
[Wed May 24 04:03:26.076766 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534] mod_wsgi (pid=10092): Target WSGI script '/opt/lampp/htdocs/dpcm/dpcm1/wsgi.py' cannot be loaded as Python module.
[Wed May 24 04:03:26.076836 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534] mod_wsgi (pid=10092): Exception occurred processing WSGI script '/opt/lampp/htdocs/dpcm/dpcm1/wsgi.py'.
[Wed May 24 04:03:26.076891 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534] Traceback (most recent call last):
[Wed May 24 04:03:26.076936 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm1/wsgi.py", line 18, in <module>
[Wed May 24 04:03:26.077076 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     application = get_wsgi_application()
[Wed May 24 04:03:26.077101 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/django/core/wsgi.py", line 13, in get_wsgi_application
[Wed May 24 04:03:26.077187 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     django.setup(set_prefix=False)
[Wed May 24 04:03:26.077210 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/django/__init__.py", line 22, in setup
[Wed May 24 04:03:26.077288 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     configure_logging(settings.LOGGING_CONFIG, settings.LOGGING)
[Wed May 24 04:03:26.077312 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/django/conf/__init__.py", line 56, in __getattr__
[Wed May 24 04:03:26.077487 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     self._setup(name)
[Wed May 24 04:03:26.077507 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/django/conf/__init__.py", line 41, in _setup
[Wed May 24 04:03:26.077545 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     self._wrapped = Settings(settings_module)
[Wed May 24 04:03:26.077562 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/django/conf/__init__.py", line 110, in __init__
[Wed May 24 04:03:26.077587 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     mod = importlib.import_module(self.SETTINGS_MODULE)
[Wed May 24 04:03:26.077652 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
[Wed May 24 04:03:26.077791 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     __import__(name)
[Wed May 24 04:03:26.077813 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm1/__init__.py", line 5, in <module>
[Wed May 24 04:03:26.077876 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from .celery import app as celery_app
[Wed May 24 04:03:26.077894 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm1/celery.py", line 3, in <module>
[Wed May 24 04:03:26.077958 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from celery import Celery
[Wed May 24 04:03:26.077977 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/celery/local.py", line 509, in __getattr__
[Wed May 24 04:03:26.078311 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     module = __import__(self._object_origins[name], None, None, [name])
[Wed May 24 04:03:26.078330 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/celery/app/__init__.py", line 5, in <module>
[Wed May 24 04:03:26.078427 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from celery import _state
[Wed May 24 04:03:26.078445 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/celery/_state.py", line 15, in <module>
[Wed May 24 04:03:26.078583 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from celery.utils.threads import LocalStack
[Wed May 24 04:03:26.078601 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/celery/utils/__init__.py", line 10, in <module>
[Wed May 24 04:03:26.078856 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from .nodenames import worker_direct, nodename, nodesplit
[Wed May 24 04:03:26.078880 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/celery/utils/nodenames.py", line 7, in <module>
[Wed May 24 04:03:26.078984 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from kombu.entity import Exchange, Queue
[Wed May 24 04:03:26.079002 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/kombu/entity.py", line 6, in <module>
[Wed May 24 04:03:26.079555 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from .abstract import MaybeChannelBound, Object
[Wed May 24 04:03:26.079576 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/kombu/abstract.py", line 6, in <module>
[Wed May 24 04:03:26.079758 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from .connection import maybe_channel
[Wed May 24 04:03:26.079784 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/kombu/connection.py", line 15, in <module>
[Wed May 24 04:03:26.080421 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from kombu import exceptions
[Wed May 24 04:03:26.080441 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/kombu/exceptions.py", line 6, in <module>
[Wed May 24 04:03:26.080550 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from amqp import ChannelError, ConnectionError, ResourceError
[Wed May 24 04:03:26.080569 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/amqp/__init__.py", line 47, in <module>
[Wed May 24 04:03:26.080747 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from .connection import Connection  # noqa
[Wed May 24 04:03:26.080787 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]   File "/opt/lampp/htdocs/dpcm/dpcm/local/lib/python2.7/site-packages/amqp/connection.py", line 29, in <module>
[Wed May 24 04:03:26.081249 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534]     from . import spec
[Wed May 24 04:03:26.081306 2017] [wsgi:error] [pid 10092] [client <IP_ADDRESS>:48534] ImportError: cannot import name spec

amqp/connection.py", line 29:
from . import spec

What's the problem?

sorry, i made a mistake, this is not python amqp.


[SPARK-27812][K8S][2.4] Bump K8S client version to 4.6.1

What changes were proposed in this pull request?
Backport of #26093 to branch-2.4
Why are the changes needed?
https://issues.apache.org/jira/browse/SPARK-27812
https://issues.apache.org/jira/browse/SPARK-27927
We need this fix https://github.com/fabric8io/kubernetes-client/pull/1768 that was released on version 4.6 of the client. The root cause of the problem is better explained in https://github.com/apache/spark/pull/25785
Does this PR introduce any user-facing change?
No
How was this patch tested?
This patch was tested manually using a simple pyspark job
from pyspark.sql import SparkSession

if __name__ == '__main__':
    spark = SparkSession.builder.getOrCreate()

The expected behaviour of this "job" is that both python's and jvm's process exit automatically after the main runs. This is the case for spark versions <= 2.4. On version 2.4.3, the jvm process hangs because there's a non daemon thread running
"OkHttp WebSocket https://<IP_ADDRESS>/..." #121 prio=5 os_prio=0 tid=0x00007fb27c005800 nid=0x24b waiting on condition [0x00007fb300847000]
"OkHttp WebSocket https://<IP_ADDRESS>/..." #117 prio=5 os_prio=0 tid=0x00007fb28c004000 nid=0x247 waiting on condition [0x00007fb300e4b000]

This is caused by a bug on kubernetes-client library, which is fixed on the version that we are upgrading to.
When the mentioned job is run with this patch applied, the behaviour from spark <= 2.4.0 is restored and both processes terminate successfully

cc @dongjoon-hyun

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thank you, @igorcalabria .

ok to test

BTW, @igorcalabria .
FYI, from GitHub email setting, you can add your additional email<EMAIL_ADDRESS>as a secondary email.

Test build #112247 has started for PR 26152 at commit 0a358f1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17233/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/17233/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17233/
Test PASSed.

Test build #112247 has finished for PR 26152 at commit 0a358f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112247/
Test PASSed.

Attempting to start Spark 2.4.0 in Azure using AKS with Kubernetes version 1.14.6, we ran into the error referenced here: https://github.com/kubernetes/kubernetes/issues/82131
I attempted to build an image from tag v2.4.0-rc5 but with https://github.com/apache/spark/pull/25641 applied, and encountered the same error when trying to start Spark in AKS with K8s 1.14.6. I also attempted the same, but with the changes from this PR (see https://github.com/sethhorrigan/spark/commit/8f96a5ea3d078a205ceb5924bf7aa2af04e6ced1), but with the exact same error:
java.net.ProtocolException: Expected HTTP 101 response but was '403 Forbidden'
at okhttp3.internal.ws.RealWebSocket.checkResponse(RealWebSocket.java:216)

Is it possible to apply this as a patch to 2.4.0, or will it absolutely require switching to the branch-2.4 code with this fix merged in?

Hi, @sethhorrigan . What do you mean by Is it possible to apply this as a patch to 2.4.0?
The next version of Apache Spark is 2.4.5. There is no such thing <IP_ADDRESS>.

If AKS breaks something in your production environment, please file an issue to them. That's the best way you get the commercial support you paid.

Put another way, use 2.4.4 at least. 2.4.0-rc5 is some release candidate of an old release, not even a final release.

@dongjoon-hyun in the commit referenced above, you can see what I mean Is it possible to apply this as a patch to 2.4.0; I forked the Spark repo and applied the changes to the code as of v2.4.0 as I said, then built the Spark image and tried to start it.
I am aware that v2.4.5 will be the next release, but your comments on https://github.com/apache/spark/pull/25641 suggest that will likely not be available until January 2020, so if we are going to have to build the Spark image from source until then, it makes as much sense to me to try to patch the code we have been using (v2.4.0) as patching another version (v2.4.4) and trying to get that working or trying to build from the current build-2.4 that will have other flaws that will need to be worked out before v2.4.5 is ready for release.
@srowen the tag v2.4.0 and v2.4.0-rc5 both refer to same commit, which I believe was the release v2.4.0

@sethhorrigan This PR also fixes the issue with kubernetes you mentioned(kubernetes-client was upgraded to a higher version). If you are building from source, I recommend that you start with the latest released minor(2.4.4) and apply this patch. Or, you could simply use branch-2.4 where this patch was merged


Feature request

Great work BTW!  Is it possible to store our ESPN credentials in a config file so that the docker image activates automatically after a restart?

If you set a config directory it should be saving the tokens that are generated by the authentication.

Here is my Docker Compose:
  eplustv:     image: m0ngr31/eplustv     container_name: eplustv     environment:       - PUID=1000       - PGID=1000       - TZ=America/Chicago       - ESPN_USER=***omitted***       - ESPN_PASS=***omitted***       - START_CHANNEL=7000     volumes:       - /media/Data/EPlusTV/app/config:/app/config       - /media/Data/EPlusTV/app/tmp:/app/tmp     ports:       - 8000:8000     restart: unless-stopped
Everytime I restart the container I get:
Please open a browser window and go to: https://www.espn.com/watch/activate


npm run test was outputing npm.debug.log files

Just running npm test fixes that problem and does the same thing

Ping @niieani

Ping @niieani

@niieani Feel free to merge at will :)


DATAFilter change for deletion of objects before insertion

Hey @3lvis! Sync is a great library and its helped out a lot to manage and sync data between our network fetches and core data. However, we've run into a small issue and was hoping for some feedback from you.
We have an object that goes through various statuses during its lifecycle. Our API provides these objects in a paginated manner for a particular status. We specify which status and page we want using NSPredicate and pass it to Sync. However, the problem arises when the object has changed its status. Sync creates a new Core Data object instead of replacing/updating the old one that already exists in Core Data with the old status. The solution we are looking into rectifying this problem is to add an option in the DATAFilter library so that before an object is inserted into Core Data, a check is performed if an object with the same 'id' already exists without any predicates. If this object exists, it is deleted before inserting the object with the new status. Again, this wouldn't be the default behaviour but rather an option in Sync that would trigger this new behaviour. What do you think?
if (operations & DATAFilterOperationInsert) {
    for (id fetchedID in insertedObjectIDs) {
        NSDictionary *objectDictionary = remoteIDAndChange[fetchedID];
        if (inserted) {
            NSDictionary *dictionaryOldObjectIDs = [DATAObjectIDs objectIDsInEntityNamed:entityName
                                                                      withAttributesNamed:localPrimaryKey
                                                                                context:context];
            NSManagedObjectID *oldObjectID = dictionaryOldObjectIDs[fetchedID];
            if (oldObjectID) {
                NSManagedObject *object = [context objectWithID:oldObjectID];
                if (object) {
                    NSLog(@"DATAFILTER DELETE BEFORE INSERT:- Fetched ID: %@", fetchedID);
                    [context deleteObject:object];
                }
            }
            NSLog(@"DATAFILTER INSERT:- Fetched ID: %@", fetchedID);
            inserted(objectDictionary);
        }
    }
}

Hi @kikanny
I'm happy that you have found this library useful, personally I use it in all my projects and I'm always happy to see that some use cases have already been solved thanks to the community.
Regarding your problem. I think this could be solved be removing the status from the NSPredicate that you send to Sync.
Is there a reason why that wouldn't work? Then Sync would just update those entries instead of making new ones. I hope you don't find dumb this question, just trying to understand the full scope of the problem to find different solutions.
Have a great weekend!

Thanks for you reply @3lvis. If I don't pass the status and page predicates, Sync would update the existing objects like you said. However, it would also delete other entries that are not in this status or page. I've tested it without predicates and thats what seems to happen. I hope that made sense?

You could remove the predicate and to avoid objects being deleted you can limit the operations to Insert and Update.
Sync.changes(secondImport, inEntityNamed: "User", dataStack: dataStack, operations: [.Insert, .Update]) {
    // Here new users have been imported, existing users have been updated, and not found users have been ignored
}

That got implemented here: https://github.com/hyperoslo/Sync/pull/223

Closing this waiting for further response, last suggestion should fix the issue.

Hi @3lvis ! Apologies for the really late reply. Got a bit busy! With regards to your suggestion about limiting the operations to Insert and Update, here's the problem. For example, if object A exists in the second page that we receive from the API and it doesn't exist any more in a consecutive call because the status has changed or the object has been removed, we would want to perform a delete operation for this object within that page.

I guess to summarize this, would be great if there was an option where, even when using a predicate, DATAFilter made sure that there's only one item for one id, and did a insertOrUpdate instead of the current behaviour.

Hi @3lvis I'm having the same issue and I think I found a way to fix this. The only thing is I'm not sure where I should add the insertOrUpdate parameter. First I though about adding an extra Operation but that doesn't play nice with the .all operation. But adding an extra argument to the sync function also doesn't seem a good idea. Any thoughts?

Hi @batjo! Any chance to get a failing unit test?

Of course, please have a look here: https://github.com/3lvis/Sync/tree/fix/227

What about something like this?
// https://github.com/3lvis/Sync/issues/227
func test227() {
    let dataStack = Helper.dataStackWithModelName("227")

    // Here the user wants to get all tags with status 0
    var tags = Helper.objectsFromJSON("227-status-0.json") as! [[String: Any]]
    let status0IDs = (tags as NSArray).value(forKey: "id") as? [Int] ?? [Int]()
    dataStack.sync(tags, inEntityNamed: "Tag", predicate: NSPredicate(format: "ANY id in %@", status0IDs), completion: nil)
    XCTAssertEqual(Helper.countForEntity("Tag", inContext: dataStack.mainContext), 1)

    // Now the user wants to get all tags with status 1, but meanwhile the status of Tag with id has changed to 1.
    // Currently this creates a second tag object with the same ID
    tags = Helper.objectsFromJSON("227-status-1.json") as! [[String: Any]]
    let status1IDs = (tags as NSArray).value(forKey: "id") as? [Int] ?? [Int]()
    dataStack.sync(tags, inEntityNamed: "Tag", predicate: NSPredicate(format: "ANY id in %@", status1IDs), completion: nil)
    XCTAssertEqual(Helper.countForEntity("Tag", inContext: dataStack.mainContext), 1)
    let tag = Helper.fetchEntity("Tag", predicate: NSPredicate(format: "id = 1"), inContext: dataStack.mainContext).first
    let status = tag?.value(forKey: "status") as? Int
    XCTAssertEqual(status, 1)

    dataStack.drop()
}

Of course, this assumes that you either get an endpoint that returns objects just for a certain status or you do some preprocessing to remove objects with a certain status.

Thanks, this works indeed.
Only thing that I still find hard is that currently I use an attribute called synced to determine if an object has local changes. If the object has local changes, I want to ignore updates from the backend on this object. Therefore I use the predicate but that generates duplicate primaryKeys (this issue). In my project the predicate would look like this:
NSPredicate(format: "ANY id in %@ AND synced == true", status0IDs)

But I guess in this situation I should just make sure to push all objects with localChanges first before requesting the list of objects from the server, right? Because now it would create new objects that have synced == false

@batjo I think pushing local elements first sounds like the most sensible approach to keep your local database always in sync.

Haven't seen any other issues related to this so might be an isolated case and not something related to the library, closing unless anything changes.


GatewayConfiguration merging support

Problem Statement
In #33 we added basic support for a GatewayConfiguration API which allows configuration of ControlPlanes and DataPlanes from the Gateway level. The current implementation doesn't however support having more than one GatewayConfiguration and then merging those configurations intelligently. The purpose of this task is to add priority and allow merging of these configurations.
Acceptance Criteria

[ ] as a user I can attach a GatewayConfiguration to both my Gateway and it's GatewayClass, and the configurations will be combined
[ ] combination of the GatewayConfigurations is based on a priority, as the user I can manually set that priority
[ ] when two GatewayConfigurations have equal priority, the oldest config wins priority
[ ] when two GatewayConfigurations have equal priority and somehow have the same timestamp, reconcilation fails, statuses reflect this on the Gateway and GatewayConfigurations and errors are thrown in the manager to indicate the problem

This one recently changed, need to update


Schema generation issue for cascaded type in NJsonSchema.Net4

Given this simple hierarchy:
public class Root
{
	[Required]
	public Node SubNode { get; set; }
}

public class Node
{
	[Required]
	public string Leaf { get; set; }
}

private static void BuildSchema()
{
	var schema = JsonSchema4.FromType<Root>();
	var schemaData = schema.ToJson();
}

the generated schema lacks the definition of 'Node' type
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "x-typeName": "Root",
  "additionalProperties": false,
  "required": [
    "SubNode"
  ],
  "properties": {
    "SubNode": {
      "oneOf": [
        {}
      ]
    }
  }
}

And this works with the non-legacy DLL (ie with .NET 4.5+)?

yes, the schema output of the non-legacy project is
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "x-typeName": "Root",
  "additionalProperties": false,
  "required": [
    "SubNode"
  ],
  "properties": {
    "SubNode": {
      "oneOf": [
        {
          "$ref": "#/definitions/Node"
        }
      ]
    }
  },
  "definitions": {
    "Node": {
      "type": "object",
      "x-typeName": "Node",
      "additionalProperties": false,
      "required": [
        "Leaf"
      ],
      "properties": {
        "Leaf": {
          "type": "string"
        }
      }
    }
  }
}

I think I found a solution. Hope it doesn't break something else!
In legacy part of ReflectionChache.GetProperties adding additional binding flags solves the problem for me:
var declaredProperties = type.GetTypeInfo().GetProperties(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance);
var declaredFields = type.GetTypeInfo().GetFields(BindingFlags.Public | BindingFlags.Instance);

https://github.com/NJsonSchema/NJsonSchema/commit/0ab7b3c228d29997bcd0b0670d74078616304cc4
but it does not fix all unit tests

It seems to fix all but 2 unit tests, which might have unrelated reasons. Without the BindingFlags-change almost all tests fail.

Yes. But these 2 unit tests also have a problem with reflection somewhere...
Try Release v4.27

Yes, the MinLengthAttribute and MaxLengthAttribute aren't defined in .NET 4.0.
(not sure why it compiles anyway)

I've added a second unit test project with the same tests but for the .NET 4 library:
https://github.com/NJsonSchema/NJsonSchema/commit/8bc3e1d8fa0fbda2c512dbdeb5f5fdbd77b41045
Now we have to fix the broken tests...

Ok, now all unit tests are fixed: https://github.com/NJsonSchema/NJsonSchema/commit/e63014c2086ee6ade073f0e79d8aa9015c8e06ad
Release v4.28, soon

Great! Thanks!
Am 11. Oktober 2016 17:19:10 MESZ, schrieb Rico Suter<EMAIL_ADDRESS>
Ok, now all unit tests are fixed:
https://github.com/NJsonSchema/NJsonSchema/commit/e63014c2086ee6ade073f0e79d8aa9015c8e06ad
Release v4.28, soon


Consider using integration test instead of unit test

          how about splitting `src/stream/src/` and `src/stream/src/test`? In other words, the test in this PR will be in `src/stream/src/test/executor/over_window`. This arrangement of test may not be able to access some private field, but currently most of our test does not acquire access them at all.

          Btw, I remember we have mentioned that we can move the unit test into a separate because our streaming executor's tests do not need access private field and methods. And after that we can depend on more utils such as frontend crate. But I can not find that comments or issue.

Originally posted by @st1page in https://github.com/risingwavelabs/risingwave/issues/9787#issuecomment-1546952169

I've tried this change in fae044a (#9787)
Changing one line in /src (even under mod tests) takes 10s to re-compile, while changing one line in /tests takes only 2s to re-compile.
The former (UTs) are slower to compile because you need to compile the whole lib with --cfg tests. (btw, another fact is that the library is recompiled twice: once with, and once without --test). The latter can reuse the compiled lib, so it's much faster and offers much better DX when developing unit tests (without changing the code).

after that we can depend on more utils such as frontend crate

We might be able to simplify executor creation which is also painful (not sure). (Note that #9787 simplified deriving outputs in the tests, without changing executor creation).

This also applies to other packages especially those compile slowly. 😇 Although I'm not sure about the frequency of adding new tests. Anyway if you feel painful about that you may consider writing new tests in /tests
❯ cargo test -p risingwave_meta --no-run
   Compiling risingwave_test_runner v1.0.0-alpha (/Users/xxchan/Projects/risingwave/src/test_runner)
   Compiling risingwave_meta v1.0.0-alpha (/Users/xxchan/Projects/risingwave/src/meta)
    Finished test [unoptimized + debuginfo] target(s) in 36.69s

A crate will be compiled twice, once for lib and once for UTs (even if it doesn't have any UTs). Splitting out integration tests (and then set test = false) can also reduce quite some compilation time. 🤣


Add pod locality in updateEDS

Without this change, new endpoints added in this method will be missing
the locality. This generally means only the first replica will get a
locality assigned to it. This means if locality LB is enabled, only one
replica will receive traffic.
Fixes: https://github.com/istio/istio/issues/13994

You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
d45133097b8a5606f34eed6d74b0bc1f8ad68794
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve
Nice find!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
d45133097b8a5606f34eed6d74b0bc1f8ad68794
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


updated changelog for v2.3.2

update changelog for v2.3.2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.799%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
38152

Relevant Lines:
40996

💛  - Coveralls


Implement the functionality to read SIP headers

I can see functions for adding and removing SIP headers, but not actually reading them.
Is it possible to add such a feature, or was it left out for a reason?

Hello!
No specific reason, feel free to open a pull request with new features! :)


added bower

Hi, thanks for the pull request, but I'm making a personal point not to support Bower anymore for any of my projects. Please read up on http://nolanlawson.com/2015/10/19/the-struggles-of-publishing-a-javascript-library/ for why I've made this decision.
Most open-source libs are moving away from Bower, and npm nowadays is more than capable of handling frontend code. In the case of this lib, you can npm install --save worker-pouch and the distributed file is already available in the dist/ folder.


Show diff of config before applying

... and allow for a --force flag to override.
/cc @embark

@steved should this still be open?

If you want to add it to the CLI, otherwise no.


Fix typo in Performance page title

@srinjoym : Thanks for your contribution! The author(s) have been notified to review your proposed change. @keveleigh


String index into a generic type having a string index signature isn't assignable to indexed access type

Bug Report
🔎 Search Terms
string index signature; indexed access; generic; 2322; not assignable
🕗 Version & Regression Information
This seems to be there all the way back to TS3.5, maybe introduced by #30769, although I'm not sure I understand why.
-This changed between versions 3.3.3 and 3.5.1
⏯ Playground Link
Playground link with relevant code
💻 Code
interface Foo {
    a: { [k: string]: string | undefined };
    b: { [k: string]: number | undefined };
    c: { [k: string]: boolean | undefined };
}
function get<K extends keyof Foo>(foo: Foo, k: K, x: string): Foo[K][string] {
    return foo[k][x]; // error!
    // Type 'string | number | boolean | undefined' is not assignable to type 'Foo[K][string]'.
}

🙁 Actual behavior
Reading a property with a string key from a Foo[K] object does not produce a value of type Foo[K][string], even in a non-widening position.
🙂 Expected behavior
Indexing into a Foo[K] value with a string key should produce a property of type Foo[K][string] if such a type is in a non-widening position.

This might be similar to #31661 and #33181 but I can't tell.
Note that numeric index signatures work as expected:
interface Foo {
    a: { [k: number]: string | undefined };
    b: { [k: number]: number | undefined };
    c: { [k: number]: boolean | undefined };
}
function get<K extends keyof Foo>(foo: Foo, k: K, x: number): Foo[K][number] {
    return foo[k][x]; // okay
}

And known literal keys work as expected:
interface Foo {
    a: { x: string | undefined };
    b: { x: number | undefined };
    c: { x: boolean | undefined };
}
function get<K extends keyof Foo>(foo: Foo, k: K, x: "x"): Foo[K]["x"] {
    return foo[k][x]; // okay
}

But string index signatures (and symbol also) fail for some reason.
This can be worked around easily enough:
function get<K extends keyof Foo>(foo: Foo, k: K, x: keyof Foo[K]): Foo[K][keyof Foo[K]] {
    return foo[k][x]; // okay
}

But I'm wondering what's going on.
Playground link with above examples
(note to self: go back to this SO answer if I acquire more cluefulness here)

It seems like maybe over-eager reduction to constraint, i.e. you're getting a concrete Foo[keyof Foo][string] instead of the generic Foo[K][string]

Indexing into a Foo[K] value with a string key should produce a property of type Foo[K][string] if such a type is expected from context.

There's currently not any effect from contextual typing to whether indexed access produces a deferred or non-deferred type.
It's pretty weird that there's a difference between string and number index signatures here, though. @ahejlsberg any thoughts on the motivation here?

There's currently not any effect from contextual typing to whether indexed access produces a deferred or non-deferred type.

Really?  Maybe I'm not using the term "contextual typing" properly?  What accounts for this difference:
interface Foo {
    a: { x: string | undefined };
    b: { x: number | undefined };
    c: { x: boolean | undefined };
}
function get1<K extends keyof Foo>(foo: Foo, k: K, x: "x"): Foo[K]["x"] {
    return foo[k][x]; // Foo[K]["x"]
}
function get2<K extends keyof Foo>(foo: Foo, k: K, x: "x") {
    return foo[k][x]; //  string | number | boolean | undefined
}

Playground link to code

That's a widening, the same as you'd see in m here:
    function get2<K extends keyof Foo>(foo: Foo, k: K, x: number) {
        const fk: Foo[K] = foo[k]
        let m = fk[x];
    }

Okay, then I guess I meant "in a non-widening position" instead of "contextually" or something. Unless that's wrong too.


feat: Added Elestio as one-click deploy option

This PR introduces new one-click deployment option - Elestio
Fixes #1928

Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

I strongly prefer that links to public cloud hosting services be offered from the Jenkins download page rather than being offered from the docker repository README file.
The Jenkins download page already includes public cloud hosting instructions for:

AWS
Azure
Google Cloud
CIVO
Oracle Cloud
Bitnami

The improve this page link on the downloads page will take you to the file that needs to be extended.
If we add the public cloud hosting providers to the Docker documentation, we should also add them to the helm chart documentation.  I think it is better to place public cloud provider links in the central location rather than spread it into multiple repositories.  We could link from the Docker and Helm chart documentation to that location as a way to increase visibility.

We discussed this in the Platform SIG meeting 24 Sep 2024 and decided this needs to be proposed to the downloads page rather than the container image documentation.

Thanks for letting me know @MarkEWaite, Can you please share the link for the downloads page? I will make a pr to it :)


jsii 1.0.0 fails aws-cdk build

:bug: Bug Report
When upgrading the CDK to use jsii 1.0.0, the build is failing.
See aws/aws-cdk#6407

This seems caused by missing code generation of nullable markers in certain interface implementation scenarios (possibly generated proxies for interfaces / structs). I'm looking into this.


[fx] support module with bias addition

what does this PR do

Patch the torch.nn.Linear module, use torch.nn.functional.linear without bias and operator.add to substitute origin computation.
Patch the torch.nn.Convxd module, use torch.nn.functional.convxd without bias and operator.add to substitute origin computation.

Note: the bias addition for convxd can't use PyTorch broadcast mechanism because the last dimension of conv output is not channel dimension while bias only has the out channel dimension. Therefore, an additional view node is added to make sure patched module working correctly.

The conv2d module after substituting looks like:

The linear module after substituting looks like:

The linear module after substituting looks like:

Should the target be F.linear?


Reduce configuration to one (or max two) short properties

Right now, there's a long description of creating a properties file which includes all but one property. Each of these are in long form, like zipkin.collector.eventhub.connection-string. To get a similar experience with other services, we'd ideally have one or two required properties in short form (like EVENTHUB_CONNECTION_STRING, taking anything we can from host installed defaults (if exist)
The following are good examples of where a short env variable is available, which allows people to literally hand type a commandline in as needed!

elasticsearch-http-aws is integrated with built-in credentials. Ex you only need to supply ES_AWS_DOMAIN to use hosted storage.
stackdriver-zipkin similarly only needs PROJECT_ID

Currently only 2 conf params are mandatory:

EVENTHUB_CONNECTION_STRING
Azure Storage Connection String

The first one being passed using the property launcher which leaves only the second one - I have not tried but I guess we can pass system variables via command line.
I will check.

here's an implementation along with some fixes and other suggestions https://github.com/openzipkin/zipkin-azure/pull/9

actually, it doesn't completely solve this because I still don't have good docs or instructions to derive the mandatory properties.. @aliostad maybe you can help with that after the fact?

Is it not better to read environment variables in the auto configuration so not having to rely on the YAML file? e.g. System.getenv("EVENTHUB_CONNECTION_STRING"), etc

Is it not better to read environment variables in the auto configuration
so not having to rely on the YAML file? e.g. System.getenv("EVENTHUB_
CONNECTION_STRING"), etc

This is only to support the server profile, which can be disabled. The
auto-configuration files itself shouldn't read the environment, as things
like profiles address that concern.


Visually separate class constructors from other methods in docs

Sometimes it tends to be bothersome to find class constructors amongst other class methods - see docs for HTTP::Client as an example.
Since methods are listed in alphabetical order, self.new lands in between self.head and self.patch.
I'd like to open discussion would it be sensible to group constructors under their own headline (or sth similar), to ease visual grepping of the list in this particular case.
WDYT?

Implemented in #4216.


User Manager field for 'User Name' allows characters that must be disallowed

For example: Joe Bloggs
If a user is added with that username then User Manager shows:
Joe (User &)
User Name Joe
Full Name User &
Home Dir Path /home/Joe

Fixed!
https://github.com/trueos/sysadm-ui-qt/commit/76d988d4056ab56b2459af899ec0ffbe2cd18b62


Custom OkHttpClient

Added ability to set custom OkHttpClient, e.g. for custom caching, authententicator, timeouts, etc.

Nice feature add! I have a couple comments I'll make inline, then we can wait for @btkelly to take a look also.

Regarding the CI failure:
* What went wrong:
A problem occurred configuring root project 'gandalf'.
> A problem occurred configuring project ':example'.
   > A problem occurred configuring project ':gandalf'.
      > Failed to notify project evaluation listener.
         > You have not accepted the license agreements of the following SDK components:
           [Android SDK Platform 24].
           Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
           Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html
         > Could not get unknown property 'generateReleaseJavadocJar' for object of type org.gradle.api.internal.artifacts.dsl.DefaultArtifactHandler.

Not sure if this is a Travis issue or our issue, @btkelly?

If we want to merge this without reverting the dependency updates, @jeffbordon you will need to update the .travis.yml file in the root of the repository so that the requested versions of the SDK components align with your changes.

Ah, very interesting, this probably explains why the CI build failed the way it did:
https://developer.android.com/studio/intro/update.html#download-with-gradle

add a second
-tools
line to the travis yml, also specify version 24 for the build tools etc eg:

tools
tools
platform-tools
build-tools-24.0.3
android-24
extra-android-m2repository
extra-android-support
doc-24

Thanks for the feedback! I'm new to this and since I'm unsure about Travis config I reverted the dependency bumps. Hope that works :)

Solid, thanks for reverting those changes - this is a really nicely-focused change now! 💯

I think Bryan is on vacation all next week, but he should be able to take a look at this once he's back :)

This looks good to me, nice feature!

Approved


Call to a member function enableHttpMethodParameterOverride() on a non-object

Hi when I Run my phpunit tests I got:
ions\Laravel.php on line 22```

I do as your instruction in readme.md.
What do I do wrong?

Is $this->app being set in the TestCase class that extends Integrated? This is a method being called on the Request class, through the request IoC binding.

My code look like this:
<?php

use Laracasts\Integrated\Extensions\Laravel as IntegrationTest;

class MenuControllerTest extends IntegrationTest {

	/** @test */
	public function it_verifies_that_pages_load_properly() {
		$this->visit('/');
	}

	/**
	 * Creates the application.
	 *
	 * Needs to be implemented by subclasses.
	 *
	 * @return \Symfony\Component\HttpKernel\HttpKernelInterface
	 */
	public function createApplication() {
		// TODO: Implement createApplication() method.
	}
}

How can I check $this->app ?

Isn't this where Laracasts forum is for? https://laracasts.com/discuss

No, this is an Integrated-related issue. What you need to do, is extend TestCase in MenuControllerTest, and extend IntegrationTest in TestCase. This was changed in an earlier update of Integrated to allow for custom methods in the base class.

I have solved it with adding code below to createApplication method.
		$app = require __DIR__ . '/../../bootstrap/app.php';
		$app->make('Illuminate\Contracts\Console\Kernel')->bootstrap();
		return $app;

You shouldn't do that, the TestCase has that code already. Like this you're gonna have to paste it in every one of your test classes.

I have now created a new TestCase for only integration testing and one for unit testing.

Thanks Guys,
I beat my head on my desk for a couple hours with this issue.
Appreciate you sharing the solution.


kinect2_viewer catkin_make error: VTK?

I am having a linker error that I can't seem to shake while building the kinect2_viewer. I added extra language to the CMake file to link to VTK 5.8, but there was no change. The other three executables built just fine. Using Ubuntu 14.04 and Indigo. libfreenect2 also installed okay.
Linking CXX executable /home/matt/catkin_ws/devel/lib/kinect2_viewer/kinect2_viewer
/usr/bin/ld: cannot find -lvtkRenderingFreeTypeFontConfig
/usr/bin/ld: cannot find -lvtkRenderingFreeType
/usr/bin/ld: cannot find -lvtkRenderingCore
/usr/bin/ld: cannot find -lvtkCommonExecutionModel
/usr/bin/ld: cannot find -lvtkCommonDataModel
/usr/bin/ld: cannot find -lvtkCommonMath
/usr/bin/ld: cannot find -lvtkCommonCore
/usr/bin/ld: cannot find -lvtkCommonMisc
/usr/bin/ld: cannot find -lvtkCommonSystem
/usr/bin/ld: cannot find -lvtkCommonTransforms
/usr/bin/ld: cannot find -lvtkFiltersExtraction
/usr/bin/ld: cannot find -lvtkFiltersCore
/usr/bin/ld: cannot find -lvtkFiltersGeneral
/usr/bin/ld: cannot find -lvtkCommonComputationalGeometry
/usr/bin/ld: cannot find -lvtkFiltersStatistics
/usr/bin/ld: cannot find -lvtkImagingFourier
/usr/bin/ld: cannot find -lvtkImagingCore
/usr/bin/ld: cannot find -lvtkFiltersGeometry
/usr/bin/ld: cannot find -lvtkFiltersSources
/usr/bin/ld: cannot find -lvtkIOImage
/usr/bin/ld: cannot find -lvtkIOCore
/usr/bin/ld: cannot find -lvtkIOXMLParser
/usr/bin/ld: cannot find -lvtkIOXML
/usr/bin/ld: cannot find -lvtkIOGeometry
/usr/bin/ld: cannot find -lvtkRenderingParallel
/usr/bin/ld: cannot find -lvtkFiltersParallel
/usr/bin/ld: cannot find -lvtkFiltersModeling
/usr/bin/ld: cannot find -lvtkParallelCore
/usr/bin/ld: cannot find -lvtkIOLegacy
/usr/bin/ld: cannot find -lvtkRenderingOpenGL
/usr/bin/ld: cannot find -lvtkImagingHybrid
/usr/bin/ld: cannot find -lvtkRenderingAnnotation
/usr/bin/ld: cannot find -lvtkImagingColor
/usr/bin/ld: cannot find -lvtkIOLSDyna
/usr/bin/ld: cannot find -lvtkIOAMR
/usr/bin/ld: cannot find -lvtkFiltersAMR
/usr/bin/ld: cannot find -lvtkIOMINC
/usr/bin/ld: cannot find -lvtkFiltersHybrid
/usr/bin/ld: cannot find -lvtkImagingSources
/usr/bin/ld: cannot find -lvtkNetCDF
/usr/bin/ld: cannot find -lvtkNetCDF_cxx
/usr/bin/ld: cannot find -lvtkInfovisCore
/usr/bin/ld: cannot find -lvtkIOImport
/usr/bin/ld: cannot find -lvtkFiltersParallelStatistics
/usr/bin/ld: cannot find -lvtkIOODBC
/usr/bin/ld: cannot find -lvtkIOSQL
/usr/bin/ld: cannot find -lvtksqlite
/usr/bin/ld: cannot find -lvtkPythonInterpreter
/usr/bin/ld: cannot find -lvtkFiltersFlowPaths
/usr/bin/ld: cannot find -lvtkInfovisBoostGraphAlgorithms
/usr/bin/ld: cannot find -lvtkFiltersProgrammable
/usr/bin/ld: cannot find -lvtkRenderingVolumeOpenGL
/usr/bin/ld: cannot find -lvtkRenderingVolume
/usr/bin/ld: cannot find -lvtkIOPLY
/usr/bin/ld: cannot find -lvtkInteractionStyle
/usr/bin/ld: cannot find -lvtkViewsCore
/usr/bin/ld: cannot find -lvtkInteractionWidgets
/usr/bin/ld: cannot find -lvtkImagingGeneral
/usr/bin/ld: cannot find -lvtkRenderingGL2PS
/usr/bin/ld: cannot find -lvtkRenderingContext2D
/usr/bin/ld: cannot find -lvtkIOInfovis
/usr/bin/ld: cannot find -lvtkFiltersReebGraph
/usr/bin/ld: cannot find -lvtkCommonColor
/usr/bin/ld: cannot find -lvtkDomainsChemistry
/usr/bin/ld: cannot find -lvtkIOExport
/usr/bin/ld: cannot find -lvtkIOFFMPEG
/usr/bin/ld: cannot find -lvtkIOMovie
/usr/bin/ld: cannot find -lvtkIOMPIImage
/usr/bin/ld: cannot find -lvtkParallelMPI
/usr/bin/ld: cannot find -lvtkViewsGeovis
/usr/bin/ld: cannot find -lvtkGeovisCore
/usr/bin/ld: cannot find -lvtkInfovisLayout
/usr/bin/ld: cannot find -lvtkViewsInfovis
/usr/bin/ld: cannot find -lvtkFiltersImaging
/usr/bin/ld: cannot find -lvtkRenderingLabel
/usr/bin/ld: cannot find -lvtkTestingIOSQL
/usr/bin/ld: cannot find -lvtkFiltersParallelGeometry
/usr/bin/ld: cannot find -lvtkFiltersSelection
/usr/bin/ld: cannot find -lvtkGUISupportQt
/usr/bin/ld: cannot find -lvtkLocalExample
/usr/bin/ld: cannot find -lvtkInteractionImage
/usr/bin/ld: cannot find -lvtkWrappingTools
/usr/bin/ld: cannot find -lvtkRenderingLOD
/usr/bin/ld: cannot find -lvtkImagingStencil
/usr/bin/ld: cannot find -lvtkIOGDAL
/usr/bin/ld: cannot find -lvtkRenderingQt
/usr/bin/ld: cannot find -lvtkFiltersTexture
/usr/bin/ld: cannot find -lvtkIOMySQL
/usr/bin/ld: cannot find -lvtkGUISupportQtWebkit
/usr/bin/ld: cannot find -lvtkViewsQt
/usr/bin/ld: cannot find -lvtkImagingMath
/usr/bin/ld: cannot find -lvtkChartsCore
/usr/bin/ld: cannot find -lvtkIOParallelNetCDF
/usr/bin/ld: cannot find -lvtkFiltersCosmo
/usr/bin/ld: cannot find -lvtkWrappingJava
/usr/bin/ld: cannot find -lvtkFiltersVerdict
/usr/bin/ld: cannot find -lverdict
/usr/bin/ld: cannot find -lvtkIOXdmf2
/usr/bin/ld: cannot find -lvtkxdmf2
/usr/bin/ld: cannot find -lvtkViewsContext2D
/usr/bin/ld: cannot find -lvtkIOParallel
/usr/bin/ld: cannot find -lvtkIONetCDF
/usr/bin/ld: cannot find -lvtkIOParallelLSDyna
/usr/bin/ld: cannot find -lvtkIOVideo
/usr/bin/ld: cannot find -lvtkIOEnSight
/usr/bin/ld: cannot find -lvtkRenderingFreeTypeOpenGL
/usr/bin/ld: cannot find -lvtkjsoncpp
/usr/bin/ld: cannot find -lvtkFiltersParallelFlowPaths
/usr/bin/ld: cannot find -lvtkRenderingHybridOpenGL
/usr/bin/ld: cannot find -lvtkWrappingPythonCore
/usr/bin/ld: cannot find -lvtkRenderingMatplotlib
/usr/bin/ld: cannot find -lvtkIOParallelExodus
/usr/bin/ld: cannot find -lvtkIOExodus
/usr/bin/ld: cannot find -lvtkImagingMorphological
/usr/bin/ld: cannot find -lvtkGUISupportQtSQL
/usr/bin/ld: cannot find -lvtkImagingStatistics
/usr/bin/ld: cannot find -lvtkTestingGenericBridge
/usr/bin/ld: cannot find -lvtkTestingRendering
/usr/bin/ld: cannot find -lvtkIOPostgreSQL
/usr/bin/ld: cannot find -lvtkFiltersGeneric
/usr/bin/ld: cannot find -lvtkFiltersHyperTree
/usr/bin/ld: cannot find -lvtkFiltersParallelMPI
/usr/bin/ld: cannot find -lvtkIOMPIParallel
/usr/bin/ld: cannot find -lvtkRenderingVolumeAMR
/usr/bin/ld: cannot find -lvtkRenderingImage
/usr/bin/ld: cannot find -lvtkFiltersParallelImaging
/usr/bin/ld: cannot find -lvtkGUISupportQtOpenGL
/usr/bin/ld: cannot find -lvtkIOVPIC
collect2: error: ld returned 1 exit status
make[2]: *** [/home/matt/catkin_ws/devel/lib/kinect2_viewer/kinect2_viewer] Error 1
make[1]: *** [iai_kinect2/kinect2_viewer/CMakeFiles/kinect2_viewer.dir/all] Error 2
make: *** [all] Error 2
Invoking "make -j4 -l4" failed

Thank you for the assist!

kinect2_viewer does not depend on VTK, PCL is using VTK. Do you use packages from the official repositories or do you have some custom installations?

The short answer is both; I had an official repository and a build from trunk, but seeing where your question was going, I removed the trunk build and wrestled with the VTK and ROS packages installed on my computer until I had a successful compile.
Now I'm experiencing a different error (segmentation fault) with respect to the viewer, but I'll close this issue and start a new one after taking a few cracks at it.  Thanks.


[NuGet.org Bug]: Download package Microsoft.Extensions.Configuration.Abstractions v6.0.0 returns a zero-length .nupkg

Impact
It's more difficult to complete my work
Describe the bug
We use Sonatype Nexus Repository Manager to fetch packages from nuget.org and make them available in an on-premises development environment.
Today, Nexus logs indicated issues downloading the package Microsoft.Extensions.Configuration.Abstractions v6.0.0 from nuget.org. Specifically, the error message is:
org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 67,830; received: 0), Cause: Premature end of Content-Length delimited message body (expected: 67,830; received: 0)

The issue is not specific to Nexus RM. It can be also observed by attempting to download the specific version of the package from a browser.
On the package page at https://www.nuget.org/packages/Microsoft.Extensions.Configuration.Abstractions/6.0.0, clicking the Download package link in the sidebar point to https://www.nuget.org/api/v2/package/Microsoft.Extensions.Configuration.Abstractions/6.0.0.
This redirects to https://globalcdn.nuget.org/packages/microsoft.extensions.configuration.abstractions.6.0.0.nupkg, which responds with these headers:
content-length: 67830
content-md5: AEtFGYgfyXDXs/Svsym4yw==
content-type: application/octet-stream
date: Fri, 28 Oct 2022 15:10:10 GMT
etag: 0x8D9A2821DFD2A82

Note, in particular, content-length indicates a response body of 67830 should follow. However, the response size is actually zero.
This confirms the HTTP protocol violation reported by Nexus RM, and results in the download of a zero-sized microsoft.extensions.configuration.abstractions.6.0.0.nupkg file.
In case it matters, the server IP address that returns the zero-length response is <IP_ADDRESS>.
Repro Steps

On this page https://www.nuget.org/packages/Microsoft.Extensions.Configuration.Abstractions/6.0.0
Open the browser developer tools, and click the Download package link in the sidebar.
The initial request to https://www.nuget.org/api/v2/package/Microsoft.Extensions.Configuration.Abstractions/6.0.0 is redirected to https://globalcdn.nuget.org/packages/microsoft.extensions.configuration.abstractions.6.0.0.nupkg
Note in the browser developer tools that the final response includes a content-length: 67830 header.
Examine the microsoft.extensions.configuration.abstractions.6.0.0.nupkg as saved by the browser, and note that its size is zero.

The mismatch between the declared content-length and actual response body size is an HTTP protocol violation. The impact is that an invalid NuGet package file is served to clients.
Expected Behavior
A 66.24 KB microsoft.extensions.configuration.abstractions.6.0.0.nupkg to be served, matching the information shown at https://www.nuget.org/packages/Microsoft.Extensions.Configuration.Abstractions/6.0.0
Screenshots
No response
Additional Context and logs
Response metadata and headers as captured by browser developer tools:
Request URL: https://globalcdn.nuget.org/packages/microsoft.extensions.configuration.abstractions.6.0.0.nupkg
Request Method: GET
Status Code: 200
Remote Address: <IP_ADDRESS>:443
Referrer Policy: strict-origin-when-cross-origin
accept-ranges: bytes
access-control-allow-origin: *
access-control-expose-headers: x-ms-request-id,Server,x-ms-version,Content-Length,Date,Transfer-Encoding
age: 28866
cache-control: max-age=86400
content-length: 67830
content-md5: AEtFGYgfyXDXs/Svsym4yw==
content-type: application/octet-stream
date: Fri, 28 Oct 2022 15:26:08 GMT
etag: 0x8D9A2821DFD2A82
expires: Sat, 29 Oct 2022 15:26:08 GMT
last-modified: Mon, 08 Nov 2021 06:36:38 GMT
server: ECAcc (via/F3B3)
strict-transport-security: max-age=31536000; includeSubDomains
x-cache: HIT
x-cdn-rewrite: Root path in dist
x-content-type-options: nosniff
x-ms-blob-type: BlockBlob
x-ms-lease-status: unlocked
x-ms-meta-da7b2905_0f3c_4262_921c_b1593d1336f1_esrp_requestid: e657510e-e51e-4997-9f0e-f1a9f17c75dc
x-ms-meta-sha512: gl/XhBjDcfWRQwcPt4jgOBz4pSzY/lHTTDE8XRgH77WX3pf6iGDdNDpiHg4fAbcL0Hq83rA4UNyMfsEPbgnWrQ==
x-ms-request-id: 00e02cfe-d01e-0011-069e-ea2743000000
x-ms-version: 2009-09-19

Hey @nil4, apologies on the delay in my response. I have a response saved in this form but for some reason, I never clicked "Comment" 🙄.

Does this issue still reproduce?
Does this happen for all packages, or just this one?
Does this URL have the same problem? https://api.nuget.org/v3-flatcontainer/microsoft.extensions.configuration.abstractions/6.0.0/microsoft.extensions.configuration.abstractions.6.0.0.nupkg
It is possible to configure Nexus to point to our V3 endpoint, https://api.nuget.org/v3/index.json instead of this legacy URL?

To be clear, this should not be happening but we've received no similar report from any other users.

@joelverhagen no worries, I appreciate the follow-up.
Checking again today, the issue no longer reproduces -- the full package content is downloaded as expected now, both by Nexus and via browser access to https://globalcdn.nuget.org/packages/microsoft.extensions.configuration.abstractions.6.0.0.nupkg.
Microsoft.Extensions.Configuration.Abstractions v6.0.0 was the only package where we saw this issue, which caused internal builds to fail. Other Microsoft packages, and other versions of this package, were downloaded without problems.
Nexus is and was configured to use https://api.nuget.org/v3/index.json as its upstream source.
The details in this issue are due to attempting to confirm the issue independently of Nexus -- the /api/v2/* URLs, as provided by the NuGet gallery (nuget.org site), were used to verify the issue is not specific to Nexus, but rather any access to this package failed to download the expected content.
Since the package is now accessible again, this issue can be closed. Thank you!


How does reducing the server prompt_limit impact response time?

We need to determine the impact of the server's prompt_limit on response time.

Run the server locally with prompt_limit = 10000
Run notebook 56 with delay_seconds = 0 and search_results_only = True
Write down how long it took to issue 90 queries to the server with that prompt limit.
Subtract 1000 prompt_limit and repeat at step 2 until prompt_limit = 1000
The goal of this task is to create a table:

prompt_limit
time taken

10000
?? seconds

9000
?? seconds

down to prompt_limit = 1000

Prompt limit min:sec
10k 22:41
9k 19:12
8K 18:17
7k 15:08
6k: 17:25
5k: 13:38
4k: 11:42
3k: 11:43
2k: 12:37
1k: 16:01


Fix typo in OpenAI implementation name in documentation (fixes #298)

"Fixes a typo in the documentation where 'Sprig AI' is corrected to 'Spring AI' in the OpenAI implementation section."

@magnet107 thank you for the contribution.
However we've restructured the [embeddings.adoc](file:///Users/ctzolov/Dev/projects/spring-projects-experimental/spring-ai/spring-ai-docs/target/antora/site/api/embeddings.html) page.
The PR affected lines doesn't exist anymore.
Feel free to review (and correct) the new page content.


Some checks fail when grep is searching for files that do not exist

Some checks fail because grep attempts to read files that do not exists using a wildcard. This is a very minor bug, but could be confusing to some users when a redediation is implemented, but the audit fails.
From "1.5.4 | L1 | Ensure core dumps are restricted | security/limits.conf" :
root@server:~# grep -E "\*.*hard.*core.*0" /etc/security/limits.conf /etc/security/limits.d/*
/etc/security/limits.conf:* hard core 0
grep: /etc/security/limits.d/*: No such file or directory

This results in  a exit code of 2 and results in a failed test.
Expected Behavior
The tasks should only check these files if they exist.
Actual Behavior
Some checks fail when the control is in place.
Control(s) Affected
This issue could effect any check where a wildcard is used with grep.
Files that may match this pattern based on a quick search:
section_1/cis_1.3/cis_1.3.2.yml
section_1/cis_1.5/cis_1.5.2.yml
section_1/cis_1.5/cis_1.5.4.yml
section_1/cis_1.7/cis_1.7.1.yml
section_3/cis_3.2/cis_3.2.1.yml
section_3/cis_3.2/cis_3.2.2.yml
section_3/cis_3.3/cis_3.3.1.yml
section_3/cis_3.3/cis_3.3.2.yml
section_3/cis_3.3/cis_3.3.3.yml
section_3/cis_3.3/cis_3.3.4.yml
section_3/cis_3.3/cis_3.3.5.yml
section_3/cis_3.3/cis_3.3.6.yml
section_3/cis_3.3/cis_3.3.7.yml
section_3/cis_3.3/cis_3.3.8.yml
section_3/cis_3.3/ipv6/cis_3.3.1.yml
section_3/cis_3.3/ipv6/cis_3.3.2.yml
section_3/cis_3.3/ipv6/cis_3.3.9.yml
section_4/cis_4.1/cis_4.1.3.yml
section_4/cis_4.1/cis_4.1.4.yml
section_4/cis_4.1/cis_4.1.5.yml
section_4/cis_4.1/cis_4.1.6.yml
section_4/cis_4.1/cis_4.1.7.yml
section_4/cis_4.1/cis_4.1.8.yml
section_4/cis_4.1/cis_4.1.9.yml
section_4/cis_4.1/cis_4.1.10.yml
section_4/cis_4.1/cis_4.1.11.yml
section_4/cis_4.1/cis_4.1.12.yml
section_4/cis_4.1/cis_4.1.13.yml
section_4/cis_4.1/cis_4.1.14.yml
section_4/cis_4.1/cis_4.1.15.yml
section_4/cis_4.1/cis_4.1.16.yml
section_4/cis_4.1/cis_4.1.17.yml
section_4/cis_4.2/cis_<IP_ADDRESS>.yml
section_4/cis_4.2/cis_<IP_ADDRESS>.yml
section_4/cis_4.2/cis_<IP_ADDRESS>.yml
section_4/cis_4.4/cis_4.4.yml
section_5/cis_5.2/cis_5.2.2.yml
section_5/cis_5.2/cis_5.2.3.yml
section_5/cis_5.3/cis_5.3.18.yml
Environment (please complete the following information):

goss version: goss version v0.3.16
OS version: Ubuntu 20.04.4 LTS
Additional Details:

Additional Notes
Possible Solution
Something like this may work to get a list of non-empty files and add them to the grep command without ifs:
root@server:~# files=$(shopt -s nullglob dotglob; echo /etc/security/limits.d/*) && grep -E "\*.*hard.*core.*0" /etc/security/limits.conf $files
* hard core 0
root@server:~# echo $?
0

hi @criley10
Thank you for your feedback, apologies for not responding sooner. There has recently been a rewrite of alot of rules for Ubuntu (devel branch). I believe this issue has been addressed. You should see a big increase in the number of tests that actually take place also.
Please let us know if this works for you?
Many thanks
uk-bolly


Add subtitle to annotation when there's only one object in the cluster

Maybe this isn't desired behavior- but it seems like map annotations should show the subtitle in the callout when there's only one object in the annotation's cluster.

Yeah that should be the expected behavior thanks for finding it and fixing!


Google Guava Dependency causes Version Mismatch Error with Java 7

The build.gradle file specifies that any version greater than 15 of Google Guava should be used.
Google has just released Guava 21.0.rc1, which requires Java 8.  Due to this, projects using JFairy that are being compiled with Java 1.7 fail with a Java Version Mismatch, for instance:
java.lang.UnsupportedClassVersionError: com/google/common/collect/Sets : Unsupported major.minor version 52.0

Additionally Guava 20 is required for jfairy.

Released version with fix: https://github.com/Codearte/jfairy/releases/tag/release-0.5.6 . Closing bug.


[SPARK-46728][PYTHON] Check Pandas installation properly

What changes were proposed in this pull request?
This PR proposes to check Pandas installation properly
Why are the changes needed?
Checking Pandas installation is not working correctly, but raising improper exception when Pandas is not installed.
This issue occurs because the deleted Pandas was not actually deleted properly for some reason, and Python tries to reference an empty pandas package path.
Does this PR introduce any user-facing change?
No API change, but user-facing error message is now showing proper error message to guide:
Before
>>> import pyspark.pandas
AttributeError: module 'pandas' has no attribute '__version__'

After
>>> import pyspark.pandas
pyspark.errors.exceptions.base.PySparkImportError: [PACKAGE_NOT_INSTALLED] Pandas >= 1.4.4 must be installed; however, it was not found.

How was this patch tested?
Manually tested
Was this patch authored or co-authored using generative AI tooling?
No.

Could you do the same things for the other packages like PyArrow, @itholic ?

Sure. I just confirmed that other packages work as expected without any changes unlike Pandas (e.g. PyArrow)
>>> import pyspark.pandas
pyspark.errors.exceptions.base.PySparkImportError: [PACKAGE_NOT_INSTALLED] PyArrow >= 4.0.0 must be installed; however, it was not found.

Do you have any other packages reproduce the same issue such as Pandas?

@itholic can you actually check why this happens only in pandas though?

My concern is that, this is sort of a hacky bandaid fix. It is a bit weird that we do this only for pandas without knowing what's exactly going on.

I roughly suspect that this happened due to the same package names in our project here and there (such as pyspark.pandas, pyspark.sql.pandas), so the namespace conflicts issue occur for some reason, but could not figure out the actual root cause right now. I can do some deeper investigation.

I roughly suspect that this happened due to the same package names in our project here and there (such as pyspark.pandas, pyspark.sql.pandas), so the namespace conflicts issue occur for some reason only in pandas, but could not figure out the actual root cause right now.

This one I know because the test fails sometimes with IDE for the reason.

The reason why I suspect in this way is that because the path /../site-packages/pandas is only not deleted clearly with PySpark dev env when uninstalling pandas.

This one can also happen in other packages as well. If that's the case, we should also address the same thing in other packages, e.g., pandas udf and spark connect. It'd be great if we can at least googling and it only happens in pandas before merging this.

It'd be great if we can at least googling and it only happens in pandas before merging this.

Yeah, I googled when I submitting this PR, but unfortunately couldn't figure out any clue. Let me have some more investigation today.

It seems like if there are extension packages that use parts of the package we're trying to remove, pip uninstall adds those dependencies to the Would not remove list and doesn't actually remove them.
In our case, pip uninstall prints out Would not remove list and doesn't actually remove them when pandas-stubs is still installed, and that's why pandas is not completely removed:
(pyspark-dev-env) haejoon.lee@NQ679Q495F spark % pip uninstall pandas
Found existing installation: pandas 2.1.4
Uninstalling pandas-2.1.4:
  Would remove:
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas-2.1.4.dist-info/*
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/*
  Would not remove (might be manually added):
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/__init__.pyi
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/_config/__init__.pyi
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/_config/config.pyi
    ...
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/util/_tester.pyi
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/util/_validators.pyi
    /Users/haejoon.lee/anaconda3/envs/pyspark-dev-env/lib/python3.9/site-packages/pandas/util/testing.pyi

So, to completely remove pandas, we need to uninstall pandas-stubs first and then uninstall pandas.

Updated PR description and comment accordingly.

On second thought, this issue seems like a corner case according to https://github.com/apache/spark/pull/44745#issuecomment-1894850179. Both pandas and pandas-stubs are specified as required packages, so I think it would be a good idea not to deal with problems caused by deleting required packages.

Let me close this PR for now, but please feel free to ping me if there is any other opinions!

Hmm... actually I just noticed that this harms dev testability for some case such as https://github.com/apache/spark/pull/44778, so I think maybe we better bandaid this?? WDYT @HyukjinKwon @dongjoon-hyun ?

okay, let's go ahead.

Merged to master.


No entries found

First of all i must say that I love the apk you made. But recently i have a bug where i cant find doujins anymore because when i go to the mainsite or online favorites it says "no entries found" I can only look at the ones that I have in my favorite galleries. It would be lovely if you can find a way to patch the bug. So I can use the app again.

Everything works normal again

I'm having the same issue, i wonder if it has something to do with the api


Thorsten Sasse, Microsoft Employee

Hi team, I find the following confusing:
1.) "You can connect your bot to existing Azure Bot Service channels. This can be helpful if you want to connect your bot to end users on Azure Bot Service channels."
In this article we are talking about connecting the Power Virtual Agent to an existing Azure Bot Service channel, right?
2.) I find the term "Power Virtual Agent bot"  on the webpage misleading. The official product name is: "Power Virtual Agent", right?
Thanks, Thorsten Sasse

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f021302-c22b-04cb-db6a-91ded1835057
Version Independent ID: 9348c068-b8be-bf05-d94a-df03147fa0ad
Content: Add a Power Virtual Agents bot to Azure Bot Service channels - Power Virtual Agents
Content Source: power-virtual-agents/publication-connect-bot-to-azure-bot-service-channels.md
Service: dynamics-365-ai
GitHub Login: @iaanw
Microsoft Alias: iawilt

That's correct, it's for adding to existing ABS channels. @pawant-ms to confirm.
The correct name is 'Power Virtual Agents', within which you can create bots. So for this article, it's about adding a specific bot you've created in Power Virtual Agents to an ASC channel.


Create Task to Add Article Created Activity to Logged-In User

GitHub Issue: Create Task to Add Article Created Activity to Logged-In User
Objective: Develop a task that adds an article created activity to the logged-in user's activity feed. This task should run automatically after an article is created successfully.
Description:
Tasks:

Create Article Created Activity Task:

Develop a task named AddArticleCreatedActivity that accepts the articleId as a parameter.
This task will be responsible for adding an article created activity to the logged-in user's activity feed.

Task Execution Logic:

Within the AddArticleCreatedActivity task, implement the logic to identify the newly created article and the logged-in user.
Add the article created activity to the logged-in user's activity feed.

Integration with Article Creation:

Integrate the AddArticleCreatedActivity task with the article creation process so that it runs automatically after an article is created successfully.

Error Handling:

Implement error handling within the task to handle any exceptions or issues that may occur during the addition of the article created activity.

Acceptance Criteria:

The AddArticleCreatedActivity task is implemented and accepts the articleId as a parameter.
The task identifies the newly created article and the logged-in user.
An article created activity is added to the logged-in user's activity feed after an article is created successfully.
The task runs automatically after an article is created.
Proper error handling is in place to address any exceptions or issues during the addition of the article created activity.

you can close this


[Backport 1.11] fix(NestedServiceLinks): group link

Fix group link when searching/filtering by name
on services.
Closes DCOS-28721
Before

After

Checklist

[ ] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

hm, this should be a subtask of #2949 - shouldnt it? 🤔Also adding WIP label.

@DanielMSchmidt Sorry but I didn't get what you mean.


Add auto corrected date time pipe

@FacundoGFlores Thanks.  Is this PR to replace #576?
Could you update the createAutoCorrectedDatePipe addon to support time instead of creating another addon that does essentially that same thing.  I  don't see the point in duplicating an existing addon when the first one could be made to support time.
Thanks

closed in favour of #651


Only first sprite repostions on resize

Look through the code moves the sprites when the page is resized and see why it isn't able move multiple sprites

Bug was a typo in the test script


Statically declaring handler functions

Currently the only way to declare new handler functions from ManagerHandlers is to dynamically allocate listeners along with state structs.
However, often it's not necessary since the same handler function is used and is part of a zero sized type (so there's no state). So it should be possible to avoid allocation in this case.
This can be achieved by adding a new option to the compositor::Builder that takes a <manager_type>::Builder for each function. Once it takes a static builder it will be a runtime error (at builder time) to construct a dynamic manager handler for that resource.
For actually allocating that static handler so that we can access the handler functions afterwards (which currently is achieved by using a repr(C) boxed struct) we could have the manager handler builder passed to us from the compositor builder internally build out to a repr(C) type that is somehow statically allocated (and implements the manager handler trait to call the functions it has as members).
Another option is to use a lazy_static! internally, but that incurs branching overhead on each access even if it is safe.
The last problem is how to solve this in the context of wayland_listener!, which currently assumes a handler is dynamically allocated along with its listener state. Ultimately the "correct" option might be to take all the $code that currently exists there and abstract it out to a function that takes an &ManagerTrait. That way it can reference a dynamically allocated or static object.

This should work, as a means to statically allocate the listeners:
struct Bar;

struct Foo {
    first: Option<unsafe extern "C" fn(&mut Bar, *mut ())>
}

static mut foo: Foo = Foo { first: None };

This will compile down to a nullable pointer, while also being safe to check against at runtime. All we need is to write the boiler plate code that takes a builder that replaces the static instance with those functions and then re-write the wayland_listener! code so that it can reuse as much as that well oiled code as it can. That code is very annoying, so I'd rather not write it twice.

Adding the unsound until I have looked at the code in practice and ensured it is sound.

One issue with this approach is that it effectively adds two code paths to arrive at the same place.
Currently, we just use boxed ManagerHandler traits to arrive at resource objects which are responsible for cleaning themselves up properly (e.g. by Box::from_raw and then letting that drop after removing the listeners from the wl_list). Those ManagerHandlers are passed boxed into the compositor builder, prompting an initial allocation we want to also avoid.
We could change the resource creation to instead of returning a Box<ManagerHandler> to instead return a Builder, for example keyboard::Builder that will have internal options on how to build out the object. That way even from dynamically defined ManagerHandlers you can construct static resource objects that don't dynamically allocate.
However we still need a struct that has pointers to static functions passed to the builder for static manager handlers (which again, is mutually exclusive with the dynamic option because it doesn't make sense to listen for it twice, especially with our memory model) and that now means we need to define the signature for these callback functions twice: once in the struct for static allocation and again in the trait for dynamic allocation.
If there is a way to allow passing a T: ManagerHandler to the compositor builder this will solve this issue since it will all have the same interface (even with the useless &self that's fine).

Actually now that I work on this more I've come to the rather startling conclusion that the manager handlers don't actually need to be dynamically dispatched ever! There is only ever one variant and the data you want to store in them can just as easily be stored in the global compositor state instead.
This means you'll never have to pass Box into the compositor::Builder and instead you'll just pass the static functions with a sub-builder.
This can also change the return types of the managers to not be a box but rather a builder result that can either be None (for not dealing with it) or of the result of constructing a builder and either building up the functions and then calling build_static() or passing a boxed trait object in build_dynamic(Box::new(object)).
I think the easiest way to attack this whole problem is splitting this into two issues: one is that the managers should always be static, and the second being you should be able to choose for the resource handlers.
See #238.