cpackget index -f  does not work on Windows

Describe the bug
Running cpackget on Windows to update the index.pidx file fails with:
$ cpackget index -f https://www.keil.com/pack/index.pidx
I: Using pack root: "C:\Users\xxx\AppData\Local\Arm\Packs"
I: Updating index [https://www.keil.com/pack/index.pidx]
I: Overwriting public index file C:\Users\xxx\AppData\Local\Arm\Packs\.Web\index.pidx
E: Can't move file "C:\Users\xxx\AppData\Local\Arm\Packs\.Download\index.pidx" to "C:\Users\xxx\AppData\Local\Arm\Packs\.Web\index.pidx": rename C:\Users\xxx\AppData\Local\Arm\Packs\.Download\index.pidx C:\Users\xxx\AppData\Local\Arm\Packs\.Web\index.p
idx: Access is denied.
E: rename C:\Users\xxx\AppData\Local\Arm\Packs\.Download\index.pidx C:\Users\xxx\AppData\Local\Arm\Packs\.Web\index.pidx: Access is denied.

To Reproduce
Steps to reproduce the behavior:

Run the cpackget command
See error

Expected behavior
It is expected that cpackget overwrites the existing index.pidx.
Environment (please complete the following information):

OS: Windows
Version 20H2 (19042.1586)

@chaws, please note that you need to manage file permissions in the $CMSIS_PACK_ROOT folder. My bad, I guess. Since we don't want to people temper with the content of the pack folder, we set file permissions to read-only. However in case files/directories need to be modified or deleted, the read-only flag needs to be removed or the operation forced. Note that cpackget shall also set read-only flags on downloaded and installed files and directories.
In this case the user has probably used a different tool (MDK pack installer) to setup the pack directory and therefore sees the permission problem.

@chaws, @jkrech, indeed, the pack folder was initially created by MDK's PackInstaller. I'll update the bug report above, accordingly.
Sounds like we should somehow pin down the spec (layout) of the pack folder including such tweaks like setting files read-only. This should not only be done on Windows but on all platforms to prevent a user from unintentionally modifying shared files.

I confirm, removing the read-only file flag manually solves the issue.

@chaws  do you have a timeline for addressing this defect?

@jkrech This took a bit more effort than I imagined, but I'm close to send a PR with setting the read-only flag in the CMSIS_PACK_ROOT installation folder.
Before I push the PR, I wanted to check if there will be any file that won't need to have read-only flag set?
I'm changing cpackget to set read-only for all files and directories including .Web/*, .Local/*, pack.idx, .Download/* and the installed packs, including all sub-directories.

@chaws this sounds reasonable, as we don't want people to manually edit the content of the CMSIS-Pack root folder. Being primarily a windows user, I maybe overlooking a specific use-case, since the windows permission handling is not great and read-only is ignored by many commands e.g. del


CSTAR-536: SyntaxWarning: assertion is always true

This removes this warning
Running setup.py install for cstar-perf.tool
Skipping installation of /usr/local/lib/python2.7/dist-packages/cstar_perf/__init__.py (namespace package)
/usr/local/lib/python2.7/dist-packages/cstar_perf/tool/fab_dse.py:89: SyntaxWarning: assertion is always true, perhaps remove parentheses?
assert(len(correct_sha) == 64, 'Failed to download sha file: {}'.format(correct_sha))

+1 - merge it, if that fixes it! I haven't tested DSE at all :)

+1


Adds example of mongoose failure

Example code of NextJS api paradigms + bumping everything + reorganizing package.json
The described bug was a coding error, in that server side code was attempted to be accessed from the client side. This PR adds in a sample API route and client side action to call that API, then renders the result on the client side.
How to Test

Open the modal

Important Changes

bumped all packages; run npm install
replaced .env with .env.local, rerun the secrets script or rename .env to .env.local

Related Github Issues

#83

Related PRs

#PRNUMBER

Checklist

[ ]  Database schema docs have been updated or are not necessary
[ ]  Code follows design and style guidelines
[ ]  Code is commented with doc blocks
[ ]  Tests have been written and executed or are not necessary
[ ]  Latest code has been rebased from base branch (usually develop)
[ ]  Commits follow guidelines (concise, squashed, etc)
[ ]  Github issues have been linked in relevant commits
[ ]  Relevant reviewers (Senior Dev/EM/Designers) have been assigned to this PR

need @cvxluo to review the coding style and enforce his own api guidelines


Rate limit AWS EC2 API call to refresh AWS instance types

As implemented in https://github.com/cilium/cilium/pull/30308, the refresh API call occurs once a minute. This is unnecessary because instance types are rarely updated (a few times a year). My proposal would be twice a day, every 12h.

I'm not sure about it - for clusters that utilize auto-managed node groups (like Karpenter AFAIK) the new instance can be created in a short window right after when a new instance type becomes available, 12h might be too long. We could probably do it every 15 minutes or so instead.

@marseel I read a bit for the code and thinking using 15 mins timer will sacrifice the user experience a lot. With the current implementation, I do think 1-2 min might be the best balance between the AWS API call  rate and the user experience.
Here is my understanding, please correct me if I'm wrong
https://github.com/cilium/cilium/pull/30308 this resync logic happens every 1 min on operator. It will fetch all instances https://github.com/cilium/cilium/blob/85abef42891bf9b6f76ac34fb4a84a5e54664e05/pkg/aws/eni/instances.go#L182 since the instance list is empty . It's a full sync for all EC2 instances, that's where we have the concern about the rate limit.
If we decide to only run https://github.com/cilium/cilium/blob/85abef42891bf9b6f76ac34fb4a84a5e54664e05/pkg/aws/eni/instances.go#L249-L254 every 15 mins . The converge time can be 15 mins at the extreme situation just for cilium. If Karpenter takes 2-3 mins to get the new instance, it doesn't make a lot of sense to delay the whole process because of waiting for operator's next resync to happen.
Feel free to let me know if I didn't understand it correctly.

@christarazi I think you can just close this issue now.

IMHO,  issue is still valid:

We can refetch instances only if there is a need for that - i. e. instance was not recognized
We could deprecate UpdateEC2AdapterLimitViaAPI so it's always enabled
Cleanup static mappings once deprecation is done

totally agree with it. I think we will need to change the name of the issue

@marseel @liyihuang @christarazi
I would like to confirm for implementation.
Please correct me if I am wrong.
We will not refresh for every 12 hours but will refetch when needed (instance is not recognized), and UpdateEC2AdapterLimitViaAPI will be always true. Is that correct?


Timeline for Phase 2 is March 31 -> May 11

We see May 11 (extended) now as the Phase 2 timing, but given the severity of us misunderstanding the communications/emails we have to date -- can you 100% confirm the March 31 timing has been universally moved back to May 11? I don't see document history etc and the consequences of us getting this wrong are high.

Sorry, I assumed the article would be linked via metadata. I'm talking about https://docs.microsoft.com/en-us/azure/azure-cache-for-redis/cache-remove-tls-10-11

@SitecoreAgent I do know this document was updated recently. But I am checking with the team regarding this again.

Thanks Microsoft team for extending redis pahse2 start date(May 11, 2020 (extended)) and please let me know any changes in the phase2 start date as we have dependency on redis cache TLS 1.0

@SitecoreAgent Yes I can confirm that we've extended the deadline to May 11.

#please-close


ES6 Bare imports generates invalid Javascript

The following typescript (using the new module system syntax)
import "foo";

generates the following invalid javascript:
define(["require", "exports", "foo"], function (require, exports, )

looks like a duplicate of #2801. should be fixed in the latest in master/release-1.5


flutter run --profile --trace-startup hangs when run on iPhone 6 iOS 9.3.4

Steps to Reproduce
Run:
flutter run --profile --trace-startup -d YOUR_IPHONE_ID
Observe a SocketException after which the process continues to run. Killing the outer flutter command does not completely clean up the processes, as the Dart snapshot process continues to run:
$ ps -ef | grep flutter
  501 46443     1   0  5:06PM ttys002    0:01.82 /Users/mac4/.cocoon/flutter/bin/cache/dart-sdk/bin/dart /Users/mac4/.cocoon/flutter/bin/cache/flutter_tools.snapshot run --profile --trace-startup -d f2943620b1e218437e4014a75d136d5121f199d9

Flutter Doctor
[✓] Flutter (on Mac OS, channel unknown)
    • Flutter at /Users/mac4/.cocoon/flutter
    • Framework revision c09a1101d2 (4 hours ago), 2016-10-05 13:21:13
    • Engine revision f97caf271c
    • Tools Dart version 1.20.0-dev.10.1

[x] Android toolchain - develop for Android devices
    x Android Studio / Android SDK not found. Download from https://developer.android.com/sdk/
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).

[✓] iOS toolchain - develop for iOS devices (Xcode 7.3.1)
    • XCode at /Applications/Xcode.app/Contents/Developer
    • Xcode 7.3.1, Build version 7D1014

[x] Atom - a lightweight development environment for Flutter
    x Atom not installed; download at https://atom.io.

[✓] Connected devices
    • Emily Fortuna’s iPhone • f2943620b1e218437e4014a75d136d5121f199d9 • ios

/cc @eseidelGoogle @chinmaygarde

@danrubel

I think i got the same problem. When I do flutter run -d <divice-id>, it runs well the first time. Then, if i quit it and then try to run it again, it throws the following error:
Launching loader on iPhone...
Exception from flutter run: SocketException: OS Error: Connection refused, errno = 61, address = <IP_ADDRESS>, port = 59815
dart:io                                                           WebSocket.connect
package:flutter_tools/src/vmservice.dart 28                       VMService.connect.<async>
===== asynchronous gap ===========================
dart:async                                                        Future.Future.microtask
package:flutter_tools/src/vmservice.dart                          VMService.connect
package:flutter_tools/src/resident_runner.dart 106                ResidentRunner.connectToServiceProtocol.<async>
===== asynchronous gap ===========================
dart:async                                                        Future.Future.microtask
package:flutter_tools/src/resident_runner.dart                    ResidentRunner.connectToServiceProtocol
package:flutter_tools/src/hot.dart 248                            HotRunner._run.<async>
dart:async                                                        _SyncCompleter.complete
package:flutter_tools/src/ios/devices.dart 292                    IOSDevice.startApp.<async>
dart:async                                                        _SyncCompleter.complete
package:flutter_tools/src/ios/devices.dart 308                    IOSDevice._acquireAndForwardPort.<async>
===== asynchronous gap ===========================
dart:async                                                        _asyncThenWrapperHelper
package:flutter_tools/src/hot.dart                                HotRunner._run
package:flutter_tools/src/hot.dart 149                            HotRunner.run.<fn>
dart:async                                                        runZoned
package:flutter_tools/src/hot.dart 148                            HotRunner.run

I checked and found that there is nothing listening on <IP_ADDRESS>:59815.

Is this still an issue?

Nope. Closing.


fft(::Double64s) ok on v1.3.0-DEV, not ok on v1.1.1

julia> VERSION # v"1.3.0-DEV.263"
julia> using DoubleFloats, FastTransforms, FFTW

julia> let df64s = rand(Double64, 2^10)
         ComplexDF32( sum(df64s .- ifft(fft(df64s))) )
       end
3.9988234e-30 + 0.0im

julia> VERSION # v"1.1.1"
julia> using DoubleFloats, FastTransforms, FFTW

julia> let df64s = rand(Double64, 2^10)
         ComplexDF32( sum(df64s .- ifft(fft(df64s))) )
       end
ERROR: type DoubleFloat{Float64} not supported
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] _fftfloat(::Type{DoubleFloat{Float64}}) at C:\Users\jas\.julia\packages\AbstractFFTs\PUqOK\src\definitions.jl:22
 [3] _fftfloat(::DoubleFloat{Float64}) at C:\Users\jas\.julia\packages\AbstractFFTs\PUqOK\src\definitions.jl:23
 [4] fftfloat(::DoubleFloat{Float64}) at C:\Users\jas\.julia\packages\AbstractFFTs\PUqOK\src\definitions.jl:18
 [5] complexfloat(::Array{DoubleFloat{Float64},1}) at C:\Users\jas\.julia\packages\AbstractFFTs\PUqOK\src\definitions.jl:31
 [6] fft(::Array{DoubleFloat{Float64},1}, ::UnitRange{Int64}) at C:\Users\jas\.julia\packages\AbstractFFTs\PUqOK\src\definitions.jl:198 (repeats 2 times)
 [7] top-level scope at REPL[3]:2

Could it be that you are using release 0.4.2 of FastTransforms on julia 1.1, but the current master on version 1.3? This is the only way I can reproduce your error locally.
The "generic fft" part of FastTransforms overrides the complexfloat function in order to avoid throwing this error. It seems this has not made it into a release yet.

Yes, I noted a couple of days ago in https://github.com/JuliaMath/AbstractFFTs.jl/pull/29#issuecomment-496008870 that the feature is not yet in a released version of FastTransforms.jl

Okay, thanks for confirming.

fixed in v0.5 of FastTransforms, thank you


[tests-only][full-ci] Tests for listing drives after sharing resource with Denied role

Description

This PR adds acceptance tests to verify drive listing behavior when resources are shared with denied permission role.
Key test scenarios:

Verifies that users can only see their own personal spaces when sharing with denied permissions
Ensures correct JSON response structure for drive listings including driveType, name and id

Related Issue

Related to: https://github.com/owncloud/ocis/issues/10656

Motivation and Context

How Has This Been Tested?

CI
Locally

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[x] Acceptance tests added
[ ] Documentation ticket raised:

This PR is subsequent to the PR: https://github.com/owncloud/ocis/pull/10696. So waiting for that to be merged.


Add PHQ-9 questionnaire fhir as .json file (same as others in the sys…

…tem)
Per https://github.com/uwcirg/asbi-screening-app/issues/2

@ivan-c  flagging that after rebasing this branch from master, the PR diff is ugly but I think it's as-expected due to the rebase approach I took. I likely could have done it more cleanly, will check w/ you next time.


Beginner walkthrough

Hey y'all! Thanks for making this. Wondering if it would be possible to add to the Wiki a walkthrough for beginners.
I'm super new to Neovim and it would help me a ton. Ideal walkthrough:

start from nothing
set up Neovim
install basic plugins like language server stuff
get autocomplete/intellisense

Other things I'm unsure about:

what does :PackerInstall do? i'm using a container based environment so need to make sure whatever gets installed persists, or can be scripted in a install.sh script.
changing the theme

python3 -m pip install --user --upgrade pynvim

sudo cpan install Neovim::Ext
sudo cpan install App::cpanminus
cpanm --local-lib=~/perl5 local::lib && eval $(perl -I ~/perl5/lib/perl5/ -Mlocal::lib)

sudo gem install neovim
gem environment

None of that is required.


[Epic] v1 release

This is a placeholder issue for tracking all the working items to get this new IPFS-in-JS implementation released.  More details will be added soon...

Roadmap. Expected date for initial release is late Q1 2023 (and ideally in time for IPFS Thing).

v1 has been quietly released: https://github.com/ipfs/helia/releases/tag/helia-v1.0.0.  We are going to address project hospitality items (https://github.com/ipfs/helia/issues/35 ) before we announce this further to maximize the impact of the "launch announcement".

Helia has had multiple public talks and announcements, closing this because we have other tracking items covering things still to-do.


SwiftUI Wrapper(Page View) refactoring

Currently, PageView cannot save the state of the view due to the view life cycle of SwiftUI. (ex. scroll offset)
I changed the init design of the view to be similar to TabView, and solved the problem by utilizing UIHostingController.
In addition, I wrapped some delegates for personal use.
Added support for the scrollToPosition binding property.
Thanks for providing a good library.

https://github.com/fermoya/SwiftUIPager
If I have time later, I'll try to fix it again in the above library way.

https://github.com/fermoya/SwiftUIPager
If I have time later, I'll try to fix it again in the above library way.

Thank you so much for this PR 🙌 This looks like a much better API, but I'm a bit worried about using the private @_functionBuilder API. I think we need to wait until Swift has official support for result builders before doing this change.

Thank you so much for this PR 🙌 This looks like a much better API, but I'm a bit worried about using the private @_functionBuilder API. I think we need to wait until Swift has official support for result builders before doing this change.

Oh I think you are right.
Then apply that part later.
Can only the wrapping part of the delegate be applied?
If possible, I will clean up and commit again.

Yes, absolutely!

It's corrected :D


Add REP-144 check list to pr template, and split pull request template files

Adds REP-144 information and updates the DOC INDEX TEMPLATE
Since the PR template becomes rather large and readability is reduced, I have also split the pull request templates into mupltiple templates which can be selected from the root pr template.
Improvements to language and formatting to increase readability of templates.

Supercedes #39987.

Is the PULL_REQUEST_TEMPLATE feature new?  I believe that we had tried this in the past without success, you had to put it all in a single markdown file

As far as I can tell, this feature has been available for a few years. One caveat is that GitHub lacks a user-friendly interface for selecting templates, unlike GitHub issue templates (eg. ros2-gbp's issue template selection).
Without a user-friendly interface, to access the other templates, one needs to utilize a query string in the URL (e.g., ?template=rosdep_rule_template.md). To circumvent this lack of interface, the root PR template is designed to include links to the other specialized PR templates.

As far as I can tell, this feature has been available for a few years. One caveat is that GitHub lacks a user-friendly interface for selecting templates, unlike GitHub issue templates (eg. ros2-gbp's issue template selection).
Without a user-friendly interface, to access the other templates, one needs to utilize a query string in the URL (e.g., ?template=rosdep_rule_template.md). To circumvent this lack of interface, the root PR template is designed to include links to the other specialized PR templates.
Here's a screenshot of the root PR:

Please remove the 'stale' label, this is waiting for review

Before I approve and merge this, I want to bring it to a ROS 2 meeting.

I haven't done this yet. It slipped my mind for the last ROS 2 meeting I attended. I've put it on the prospective agenda for the next ROS 2 meeting.

In the intervening weeks I realized that a more radical alternative would be to separate the official rosdep sources into their own repository, thus focusing the pull request guidelines and template on rosdistro operations, which may reduce the need to work around things in this manner. It seems like the gh CLI allows specifying a template but only from local files, not starting a browser tab with a selected PR template.


alias eq to equals

This pull request is related to Automattic/mongoose#3953

Thanks :beers:

@vkarpov15 I think it should be 1.8.1 milestone because 1.8.0 has been released?

Yep thanks


profile json added

This will need a rebase:
https://www.nhcarrigan.com/notes/#/git-commands/rebase-branch

Closing as seems like another PR was created https://github.com/EddieHubCommunity/LinkFree/pull/271


fix py3.6 optional + literal dtypes in SchemaModel

With python 3.6, class-based API with an optional column of type pandera.typing.* (i.e. a Literal) raises a TypeError
Closes #378

@cosmicBboy  What's going on with codecov? :(

@cosmicBboy What's going on with codecov? :(

since the migration from travis to github actions, codecov updates in realtime, so it appears to have less coverage when the tests begin. Need to look into how to make it so that coverage is updated only after all tests are run

@cosmicBboy What's going on with codecov? :(

since the migration from travis to github actions, codecov updates in realtime, so it appears to have less coverage when the tests begin. Need to look into how to make it so that coverage is updated only after all tests are run


Rename media_proxy to mediacontrol

Rename the media proxy to media control.
Exact name (media-control, media_control, media-ctl, mctl) TBD

Closed as no longer relevant, as we removing the Media Proxy


feat(community): add filters to LibSQLVectorStore

add filters to LibSQLVectorStore

The diff is a little smaller if this PR get merged first

Thanks for this!
Can you also please add a usage example to docs/core_docs/docs/integrations/vectorstores/libsql.mdx?


[MLP-94] Add CRUD generator

Background
@mravinale recently suggested that it would be great to have a generator in order to quickly scaffold the code to perform the basic CRUD operations. Here is a basic proposal that helps in that matter.
Sorry but this is a long one. I guess you can trust on the templates and skip those.
Changes

Added a CRUD generator.
Updated docs.
Opportunistic minor fixes and indentation adjustments (sorry about that).

Notes

Since editing/updating a file is not a trivial task we are not going to invest time on that at least for now (specially if the seed is not autogenerated). It will be error prone. But... in order to speed up the development process I documented in the README.md file what is needed to do manually. At least is something.
Here is a generator demo video: https://www.screencast.com/t/Ovo1wHFVVd
Here is the app demo video: https://www.screencast.com/t/ZtzBKldGAYK

Folks, now create is working (fixed the issue). I also addressed all the comments (I guess). Could you take another look? Thanks in advance.

Appreciated @juampick!


evaluator should remove rejected players from the 'proposed' ignorelists

Evaluator needs a pass either way; it's crufty and hasn't gotten much of an update since 0.1.0.  If 0.4.0 turns it into a long-lived process then I'll take care of this then.  Otherwise, just leaving this as a reminder so I don't forget to fix this.  Belongs around this line - that rejected proposed ID needs to be removed from the proposed ignorelist so it will be seen by later MMFs.

This is in the gdcbackports branch and will be in when that gets merged


fix: Fixes for build-tools for LTS branch

The LTS branch is in quite a different state than the main branch, and as such the build-tools have regressed such that they don't work on that branch. I made the following changes to accomodate:

Fixed a bug that caused the --root flag to be ignored.
If the external config file is not found, use the git root as the inferred root.

I am assuming you are moving the rest of the LTS fixes through separate PRs?

Yeah, I am working through those changes in #15909.


Dark mode

The Table view should feature a dark mode to best fit with VSCode dark mode themes,

I am willing to develop dark mode, but I cannot design a good-looking UI. If you can give some reference, it will promote the development of dark mode.

@cweijan I will do it if you wish...

@dhonx Thanks, you can implement it and create PR.

@dhonx  I didn’t create a dev-server for the webview page, and I reopened the webview after modifying the page source. Modifying the page is cumbersome.

Sure! I can setup it

Looking forward to this!
@cweijan I've been looking for a good MySQL extension for VSCode, I tried a lot, yours is perfect for me!

New version 2.3.0 has bean add dark theme.

How do you enable it?

Found it, just update the setting to "dark"

or just update it in the results page itself

Theme switching is extremely friendly.

It will be maybe good idea to make the background #1e1e1e, so it has same color as other editor windows.


Fix "similar-code" issue in tests/components/templates/ImportFileZone.test.js

Similar blocks of code found in 4 locations. Consider refactoring.
https://codeclimate.com/github/LD4P/sinopia_editor/__tests__/components/templates/ImportFileZone.test.js#issue_5ec3bed3aa4ca40001000225

Closing, no longer valid after 3.0.0 refactoring


Aggregate release branch rc3 migrations to 2.0.0-rc3

Description
The aggregation of the current migrations within the dev branch to a '2.0.0-rc3' migration is needed in preparation for https://github.com/eclipse-tractusx/portal/issues/264

the following script needs to be executed on the rc database after the merge:
update public.__efmigrations_history_portal
set migration_id = '20240423033553_2.0.0-rc3'
where migration_id = '20240418104402_593-AddNewDimProcess';


Consensus logging

Adds basic logging to consensus. None of the logging statements are wrapped in a if build.DEBUG as they are all logging errors that should not occur frequently.

We definitely need some call to logging that will only log the message in DEBUG mode.

Agreed, more logging in DEBUG mode is good. I'm not very familiar with consensus code outside of synchronizing, so I don't know where else logging might be useful.

As you can see from my comments, pretty picky about what types of logging statements should be making production. Basically, only statements which indicate that the developer has done something wrong (like peers failing to disconnect) or that the user machine is having errors. Things that are triggered by bad peers, etc. shouldn't be logged unless in DEBUG mode.
One-time statements such as 'IBD complete with x peers' also make sense.

I added Logger.Debug, Logger.Debugf, and Logger.Debugln. There's not testing for them as build.DEBUG is a constant that's always true during testing.
I changed the noted log statements to use Debugln.

Build is failing because of https://github.com/travis-ci/travis-ci/issues/5806

Don't we already only have a Println for the logger? I don't think adding all 3 was necessary, though strictly speaking I don't think it's harmful


Custom outDir and hydration breaks build

[x] I have read the troubleshooting section before opening an issue.
[x] I have tried upgrading iles and vite.

Description 📖
When using custom outDir and hydrated components i.e <Welcome client:load /> the build fails with the following error:
✖ writing pages
build error:
 [ENOENT: no such file or directory, open '/home/projects/iles-slj6as/temp/build/manifest.json'] {
  code: 'ENOENT',
  errno: -2,
  path: '/home/projects/iles-slj6as/temp/build/manifest.json',
  syscall: 'open'
}

Reproduction 🐞
https://stackblitz.com/edit/iles-slj6as?file=src%2Fpages%2Fabout.vue,src%2Fcomponents%2FWelcome.vue,iles.config.ts

Dependencies Info
Run npx iles info and pnpm list (or npm list) and provide the output:
iles v0.7.38 vite v2.9.9

Screenshots 📷

Hey @ElMassimo would love to get your thoughts or inout on this. Happy to do a PR if you can help point me in the right direction 😃

Hi Giles! @gilesbutler
Seems like the outDir option is not being used when building islands. If you run build in your reproduction, you can see that it's still writing in dist instead of temp/build.
Setting outDir explicitly when building islands should fix the problem.
Pull requests are welcome!

Awesome, thanks @ElMassimo I'll take a look 👍


Add a reset method to Angel

This will allow entirely clearing out the router, injections, etc. so that a server can be reconfigured on-the-fly. This could be better for angel_hot's memory usage.

Doesn't seem to be necessary.


Add outscale's api access rule system.

Changes Title (replace this with a logical title for your changes)
Description
Replace this with the PR description (mention the changes you have made, why
you have made them, provide some background and any references to the provider
documentation if needed, etc.).
For more information on contributing, please see Contributing
section of our documentation.
Status
Replace this: describe the PR status. Examples:

work in progress
done, ready for review

Checklist (tick everything that applies)

[ ] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[ ] ICLA (required for bigger changes)

@tgn-outscale ready to merge?

@tgn-outscale ready to merge?

@outscale-fne still the typing of list in parameter to change and a little mistake in ex_create_api_rule for CNS parameter verification but looks good overall
I will merge everything when you will have make those changes

@outscale-fne still the typing of list in parameter to change and a little mistake in ex_create_api_rule for CNS parameter verification but looks good overall
I will merge everything when you will have make those changes

not sure I understood "the typing of list in parameter to change" but it should be fixed now! @tgn-outscale

not sure I understood "the typing of list in parameter to change" but it should be fixed now! @tgn-outscale


Using SCRIPT_NAME breaks transaction grouping

Environment
How do you use Sentry?
Self-hosted, 21.9.0
Which SDK and version?
Python (Django / DRF), 1.4.3
Steps to Reproduce

Host Django using Gunicorn
Pass SCRIPT_NAME header with HTTP request

Expected Result
Requests to /api/endpoint/123/ and /api/endpoint/456/ should be aggregated as either /api/endpoint/{pk}/ or /endpoint/{pk}/.
Actual Result
Requests appear as /api/endpoint/123/ and /api/endpoint/456/ because RavenResolver doesn't seem to take into account the SCRIPT_NAME contained in the WSGI request object.

@sl0thentr0py do you have any insights about this?

Hi @JannKleen, we just pick up the url patterns from the django resolver here.
I'm not sure what SCRIPT_NAME would do here? What is the value of SCRIPT_NAME in your example?

An alternative here is to add an event processor and manually set the transaction names.
There are docs for javascript here. The python version would look like
from sentry_sdk.scope import add_global_event_processor

@add_global_event_processor
def processor(event, hint):
    if event.get("type") == "transaction":
        event["transaction"] = sanitize_transaction_name(event["transaction"])

    return event


Allow marking an argument as constant in the function signature

Description
See #3993
CC: @kagamiori @bikramSingh91 @kgpai @jinchengchenghh

According to your discussion in #3993 here are two aspects to this enhancement,

This function signature supports marking an argument as a constant/deterministic
Function signature constant arguments can be perceived by the Fuzzer, generating constant/deterministic expressions as input arguments.
@mbasmanova Do I understand your point correctly?

PS: I reproduced the bug mentioned in #3993 , which is caused by no constant folding in the simplified eval, and it can be fixed by #3983. I patched the diff in #3983 and the test succeeded.
log without patch
spark_expression_fuzzer_test  --velox_fuzzer_enable_complex_types --enable_variadic_signatures --only="sort_array,array_intersect,array_sort,isnotnull"
E20230301 13:59:14.623225 663856 Exceptions.h:68] Line: /Users/macduan/work/native/velox-3/velox/functions/sparksql/ArraySort.cpp:273, Function:makeSortArray, Expression:  sort_array requires a constant bool as the second argument., Source: USER, ErrorCode: INVALID_ARGUMENT
E20230301 13:59:14.635332 663856 Exceptions.h:68] Line: /Users/macduan/work/native/velox-3/velox/functions/sparksql/ArraySort.cpp:273, Function:makeSortArray, Expression:  sort_array requires a constant bool as the second argument., Source: USER, ErrorCode: INVALID_ARGUMENT
E20230301 13:59:14.635847 663856 FuzzerToolkit.cpp:131] Only simplified path threw exception:
libc++abi: terminating with uncaught exception of type facebook::velox::VeloxUserError: Exception: VeloxUserError
Error Source: USER
Error Code: INVALID_ARGUMENT
Reason: sort_array requires a constant bool as the second argument.
Retriable: False
Function: makeSortArray
File: /Users/macduan/work/native/velox-3/velox/functions/sparksql/ArraySort.cpp

log with patch
spark_expression_fuzzer_test  --velox_fuzzer_enable_complex_types --enable_variadic_signatures --only="sort_array,array_intersect,array_sort,isnotnull"
E20230301 10:01:33.850122 448366 Exceptions.h:68] Line: /Users/macduan/work/native/velox-3/velox/functions/sparksql/ArraySort.cpp:276, Function:makeSortArray, Expression:  sort_array requires a constant bool as the second argument., Source: USER, ErrorCode: INVALID_ARGUMENT
E20230301 10:01:33.853060 448366 Exceptions.h:68] Line: /Users/macduan/work/native/velox-3/velox/functions/sparksql/ArraySort.cpp:276, Function:makeSortArray, Expression:  sort_array requires a constant bool as the second argument., Source: USER, ErrorCode: INVALID_ARGUMENT
E20230301 10:01:33.853178 448366 Exceptions.h:68] Line: /Users/macduan/work/native/velox-3/velox/functions/sparksql/ArraySort.cpp:276, Function:makeSortArray, Expression:  sort_array requires a constant bool as the second argument., Source: USER, ErrorCode: INVALID_ARGUMENT
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

@duanmeng Thank you for helping with this.

This function signature supports marking an argument as a constant/deterministic
The above can be perceived by the Fuzzer, generating constant/deterministic expressions as input arguments.

That sounds right.

For item 1, we could add a constant flag field in class TypeSignature and overload FunctionSignatureBuilder::argumentType, do you think this is appropriate? @mbasmanova
class TypeSignature {
...
 private:
  const std::string baseName_;
  const std::vector<TypeSignature> parameters_;
  const bool isConstant; // constant flag, false by default
}

FunctionSignatureBuilder& argumentType(const std::string& type, const bool& isConstant) {
    argumentTypes_.emplace_back(parseTypeSignature(type));
    argumentTypes.setIsConstant(isConstant);
    return *this;
  }

// add constant flag explicitly
exec::FunctionSignatureBuilder().argumentType("bool", true);

@duanmeng Sounds reasonable to me. For readability, perhaps, we could introduce FunctionSignatureBuilder::constantArgumentType(const std::string& type)

const bool& isConstant

Pass booleans and other primitive types by value: bool isConstant = false.

@duanmeng That would be great. Thanks.

@duanmeng is-constant doesn't seem to be the property of the type. How about we extend CallableSignature to add a list of booleans to identify constant arguments?
struct CallableSignature {
  // Function name.
  std::string name;

  // Input arguments and return type.
  std::vector<TypePtr> args;

  // Boolean flags identifying constant arguments.
  std::vector<bool> constantArgs;

  bool variableArity{false};
  TypePtr returnType;

  // Convenience print function.
  std::string toString() const;
};

We can then modify ExpressionFuzzer::generateArgs to check 'constantArgs':
  for (auto i = 0; i < input.args.size(); ++i) {
    if (input.constantArgs[i]) {
      inputExpressions.emplace_back(generateArgConstant(input.args[i]));
    } else {
      inputExpressions.emplace_back(generateArg(input.args[i]));
    }
  }

Once we make these changes, we should be able to update signatures of the like, empty_approx_set and regexp_replace functions and remove ExpressionFuzzer::generateLikeArgs, generateEmptyApproxSetArgs, generateRegexpReplaceArgs functions.

Once we make these changes, we should be able to update signatures of the like, empty_approx_set and regexp_replace functions and remove ExpressionFuzzer::generateLikeArgs, generateEmptyApproxSetArgs, generateRegexpReplaceArgs functions.

@mbasmanova I've created a follow-up pr #4237 to enhance the fuzzer and fix the issue of the sort_array argument. For this requirement, should we raise another issue or reuse the current issue and create another pr to implement it?


Don't print lexer errors to stderr

Hi Fede,
This is a quick PR that avoid printing lexing errors to stderr. I removed the lexer's default error listener, and use the same one that the parser's instead.

Thanks @alcuadrado! Please remove the .only in the test before I can merge.

Ouch 😅
Done!


Contour package fails to reconcile when using LoadBalancer service in environment without LoadBalancer provider

Bug Report
A user is attempting to install the latest Contour package on a standalone TCE cluster running on an Ubuntu 21 VM.
The package installs, the contour and envoy pods start and the certgen job completes. Everything appears fine except that the reconciliation fails.
The "Useful Error Message" is kapp: Error: Timed out waiting after 15m0s
At this time, this does not appear to be the issue covered in #1184.
Expected Behavior
The contour package should install successfully.
Steps to Reproduce the Bug

Create a TCE standalone cluster

tanzu standalone-cluster create -i docker fred
kubectl config use-context fred-admin@fred

Install the TCE package repository

tanzu package repository add tce-repo --namespace default --url projects.registry.vmware.com/tce/main@sha256:984450d3b1367f761da43e443c36428614c8ce9012d9fc1f2149733de0149cf4

Install Contour

tanzu package install contour -p contour.community.tanzu.vmware.com -v 1.17.1

Wait for about 5-10 minutes, the install command will timeout.

Describe the contour app for more details, kubectl get apps contour -o yaml

kubectl get apps contour -o yaml

apiVersion: kappctrl.k14s.io/v1alpha1
kind: App
metadata:
  creationTimestamp: "2021-09-14T20:38:32Z"
  finalizers:
  - finalizers.kapp-ctrl.k14s.io/delete
  generation: 1
  name: contour
  namespace: default
  ownerReferences:
  - apiVersion: packaging.carvel.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: PackageInstall
    name: contour
    uid: 32ffe6af-3125-4961-8b11-fa0a657e959c
  resourceVersion: "6992"
  uid: 11cbc92f-7a42-45c0-80a4-fd1f2030959f
spec:
  deploy:
  - kapp: {}
  fetch:
  - imgpkgBundle:
      image: projects.registry.vmware.com/tce/contour@sha256:6a90a760b8851a23527bd778b4470cc6982bf5d6e27cd828c004b2ad1b634ccc
  serviceAccountName: contour-default-sa
  template:
  - ytt:
      paths:
      - config/
  - kbld:
      paths:
      - '-'
      - .imgpkg/images.yml
status:
  conditions:
  - status: "True"
    type: Reconciling
  deploy:
    exitCode: 0
    finished: false
    startedAt: "2021-09-14T20:38:37Z"
    stdout: |-
      Target cluster 'https://<IP_ADDRESS>:443' (nodes: fred-control-plane-g6c78, 1+)
      08:38:37PM: info: Resources: Ignoring group version: schema.GroupVersionResource{Group:"stats.antrea.tanzu.vmware.com", Version:"v1alpha1", Resource:"networkpolicystats"}
      08:38:37PM: info: Resources: Ignoring group version: schema.GroupVersionResource{Group:"stats.antrea.tanzu.vmware.com", Version:"v1alpha1", Resource:"antreanetworkpolicystats"}
      08:38:37PM: info: Resources: Ignoring group version: schema.GroupVersionResource{Group:"stats.antrea.tanzu.vmware.com", Version:"v1alpha1", Resource:"antreaclusternetworkpolicystats"}
      Changes
      Namespace       Name                                         Kind                      Conds.  Age  Op      Op st.  Wait to    Rs  Ri
      (cluster)       contour                                      ClusterRole               -       -    create  -       reconcile  -   -
      ^               contour                                      ClusterRoleBinding        -       -    create  -       reconcile  -   -
      ^               extensionservices.projectcontour.io          CustomResourceDefinition  -       -    create  -       reconcile  -   -
      ^               httpproxies.projectcontour.io                CustomResourceDefinition  -       -    create  -       reconcile  -   -
      ^               projectcontour                               Namespace                 -       -    create  -       reconcile  -   -
      ^               tlscertificatedelegations.projectcontour.io  CustomResourceDefinition  -       -    create  -       reconcile  -   -
      projectcontour  contour                                      ConfigMap                 -       -    create  -       reconcile  -   -
      ^               contour                                      Deployment                -       -    create  -       reconcile  -   -
      ^               contour                                      RoleBinding               -       -    create  -       reconcile  -   -
      ^               contour                                      Service                   -       -    create  -       reconcile  -   -
      ^               contour                                      ServiceAccount            -       -    create  -       reconcile  -   -
      ^               contour-certgen                              Role                      -       -    create  -       reconcile  -   -
      ^               contour-certgen                              ServiceAccount            -       -    create  -       reconcile  -   -
      ^               contour-certgen-v1.17.1                      Job                       -       -    create  -       reconcile  -   -
      ^               envoy                                        DaemonSet                 -       -    create  -       reconcile  -   -
      ^               envoy                                        Service                   -       -    create  -       reconcile  -   -
      ^               envoy                                        ServiceAccount            -       -    create  -       reconcile  -   -
      Op:      17 create, 0 delete, 0 update, 0 noop
      Wait to: 17 reconcile, 0 delete, 0 noop
      8:38:37PM: ---- applying 6 changes [0/17 done] ----
      8:38:37PM: create clusterrolebinding/contour (rbac.authorization.k8s.io/v1) cluster
      8:38:37PM: create clusterrole/contour (rbac.authorization.k8s.io/v1) cluster
      8:38:38PM: create namespace/projectcontour (v1) cluster
      8:38:39PM: create customresourcedefinition/tlscertificatedelegations.projectcontour.io (apiextensions.k8s.io/v1) cluster
      8:38:39PM: create customresourcedefinition/extensionservices.projectcontour.io (apiextensions.k8s.io/v1) cluster
      8:38:39PM: create customresourcedefinition/httpproxies.projectcontour.io (apiextensions.k8s.io/v1) cluster
      8:38:39PM: ---- waiting on 6 changes [0/17 done] ----
      8:38:39PM: ok: reconcile clusterrolebinding/contour (rbac.authorization.k8s.io/v1) cluster
      8:38:39PM: ok: reconcile clusterrole/contour (rbac.authorization.k8s.io/v1) cluster
      8:38:39PM: ok: reconcile customresourcedefinition/tlscertificatedelegations.projectcontour.io (apiextensions.k8s.io/v1) cluster
      8:38:39PM: ok: reconcile customresourcedefinition/extensionservices.projectcontour.io (apiextensions.k8s.io/v1) cluster
      8:38:39PM: ok: reconcile namespace/projectcontour (v1) cluster
      8:38:39PM: ok: reconcile customresourcedefinition/httpproxies.projectcontour.io (apiextensions.k8s.io/v1) cluster
      8:38:39PM: ---- applying 6 changes [6/17 done] ----
      8:38:39PM: create role/contour-certgen (rbac.authorization.k8s.io/v1) namespace: projectcontour
      8:38:39PM: create configmap/contour (v1) namespace: projectcontour
      8:38:39PM: create serviceaccount/contour (v1) namespace: projectcontour
      8:38:39PM: create serviceaccount/contour-certgen (v1) namespace: projectcontour
      8:38:39PM: create serviceaccount/envoy (v1) namespace: projectcontour
      8:38:39PM: create rolebinding/contour (rbac.authorization.k8s.io/v1) namespace: projectcontour
      8:38:39PM: ---- waiting on 6 changes [6/17 done] ----
      8:38:39PM: ok: reconcile rolebinding/contour (rbac.authorization.k8s.io/v1) namespace: projectcontour
      8:38:39PM: ok: reconcile serviceaccount/contour-certgen (v1) namespace: projectcontour
      8:38:39PM: ok: reconcile configmap/contour (v1) namespace: projectcontour
      8:38:39PM: ok: reconcile role/contour-certgen (rbac.authorization.k8s.io/v1) namespace: projectcontour
      8:38:39PM: ok: reconcile serviceaccount/contour (v1) namespace: projectcontour
      8:38:39PM: ok: reconcile serviceaccount/envoy (v1) namespace: projectcontour
      8:38:39PM: ---- applying 5 changes [12/17 done] ----
      8:38:39PM: create job/contour-certgen-v1.17.1 (batch/v1) namespace: projectcontour
      8:38:39PM: create deployment/contour (apps/v1) namespace: projectcontour
      8:38:39PM: create daemonset/envoy (apps/v1) namespace: projectcontour
      8:38:39PM: create service/envoy (v1) namespace: projectcontour
      8:38:39PM: create service/contour (v1) namespace: projectcontour
      8:38:39PM: ---- waiting on 5 changes [12/17 done] ----
      8:38:39PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:38:39PM:  ^ Load balancer ingress is empty
      8:38:39PM: ok: reconcile service/contour (v1) namespace: projectcontour
      8:38:40PM: ongoing: reconcile job/contour-certgen-v1.17.1 (batch/v1) namespace: projectcontour
      8:38:40PM:  ^ Waiting to complete (0 active, 0 failed, 0 succeeded)
      8:38:40PM:  L ongoing: waiting on pod/contour-certgen-v1.17.1-9ktpg (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending
      8:38:40PM: ongoing: reconcile daemonset/envoy (apps/v1) namespace: projectcontour
      8:38:40PM:  ^ Waiting for generation 1 to be observed
      8:38:40PM:  L ongoing: waiting on pod/envoy-b2c9s (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending
      8:38:40PM:  L ok: waiting on controllerrevision/envoy-6df6bb6dc5 (apps/v1) namespace: projectcontour
      8:38:40PM: ongoing: reconcile deployment/contour (apps/v1) namespace: projectcontour
      8:38:40PM:  ^ Waiting for generation 2 to be observed
      8:38:40PM:  L ok: waiting on replicaset/contour-646f996cf (apps/v1) namespace: projectcontour
      8:38:40PM:  L ongoing: waiting on pod/contour-646f996cf-wcm65 (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending
      8:38:40PM:  L ongoing: waiting on pod/contour-646f996cf-fs79f (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending
      8:38:40PM: ---- waiting on 4 changes [13/17 done] ----
      8:38:40PM: ongoing: reconcile job/contour-certgen-v1.17.1 (batch/v1) namespace: projectcontour
      8:38:40PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
      8:38:40PM:  L ongoing: waiting on pod/contour-certgen-v1.17.1-9ktpg (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending: ContainerCreating
      8:38:40PM: ongoing: reconcile daemonset/envoy (apps/v1) namespace: projectcontour
      8:38:40PM:  ^ Waiting for 1 unavailable pods
      8:38:40PM:  L ongoing: waiting on pod/envoy-b2c9s (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending: PodInitializing
      8:38:40PM:  L ok: waiting on controllerrevision/envoy-6df6bb6dc5 (apps/v1) namespace: projectcontour
      8:38:40PM: ongoing: reconcile deployment/contour (apps/v1) namespace: projectcontour
      8:38:40PM:  ^ Waiting for 2 unavailable replicas
      8:38:40PM:  L ok: waiting on replicaset/contour-646f996cf (apps/v1) namespace: projectcontour
      8:38:40PM:  L ongoing: waiting on pod/contour-646f996cf-wcm65 (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending
      8:38:40PM:  L ongoing: waiting on pod/contour-646f996cf-fs79f (v1) namespace: projectcontour
      8:38:40PM:     ^ Pending
      8:38:41PM: ongoing: reconcile deployment/contour (apps/v1) namespace: projectcontour
      8:38:41PM:  ^ Waiting for 2 unavailable replicas
      8:38:41PM:  L ok: waiting on replicaset/contour-646f996cf (apps/v1) namespace: projectcontour
      8:38:41PM:  L ongoing: waiting on pod/contour-646f996cf-wcm65 (v1) namespace: projectcontour
      8:38:41PM:     ^ Pending: ContainerCreating
      8:38:41PM:  L ongoing: waiting on pod/contour-646f996cf-fs79f (v1) namespace: projectcontour
      8:38:41PM:     ^ Pending: ContainerCreating
      8:38:45PM: ongoing: reconcile job/contour-certgen-v1.17.1 (batch/v1) namespace: projectcontour
      8:38:45PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
      8:38:45PM:  L ok: waiting on pod/contour-certgen-v1.17.1-9ktpg (v1) namespace: projectcontour
      8:38:46PM: ok: reconcile job/contour-certgen-v1.17.1 (batch/v1) namespace: projectcontour
      8:38:46PM:  ^ Completed
      8:38:46PM: ---- waiting on 3 changes [14/17 done] ----
      8:38:48PM: ongoing: reconcile deployment/contour (apps/v1) namespace: projectcontour
      8:38:48PM:  ^ Waiting for 2 unavailable replicas
      8:38:48PM:  L ok: waiting on replicaset/contour-646f996cf (apps/v1) namespace: projectcontour
      8:38:48PM:  L ongoing: waiting on pod/contour-646f996cf-wcm65 (v1) namespace: projectcontour
      8:38:48PM:     ^ Condition Ready is not True (False)
      8:38:48PM:  L ongoing: waiting on pod/contour-646f996cf-fs79f (v1) namespace: projectcontour
      8:38:48PM:     ^ Pending: ContainerCreating
      8:38:50PM: ongoing: reconcile deployment/contour (apps/v1) namespace: projectcontour
      8:38:50PM:  ^ Waiting for 2 unavailable replicas
      8:38:50PM:  L ok: waiting on replicaset/contour-646f996cf (apps/v1) namespace: projectcontour
      8:38:50PM:  L ongoing: waiting on pod/contour-646f996cf-wcm65 (v1) namespace: projectcontour
      8:38:50PM:     ^ Condition Ready is not True (False)
      8:38:50PM:  L ongoing: waiting on pod/contour-646f996cf-fs79f (v1) namespace: projectcontour
      8:38:50PM:     ^ Condition Ready is not True (False)
      8:38:55PM: ongoing: reconcile daemonset/envoy (apps/v1) namespace: projectcontour
      8:38:55PM:  ^ Waiting for 1 unavailable pods
      8:38:55PM:  L ongoing: waiting on pod/envoy-b2c9s (v1) namespace: projectcontour
      8:38:55PM:     ^ Condition Ready is not True (False)
      8:38:55PM:  L ok: waiting on controllerrevision/envoy-6df6bb6dc5 (apps/v1) namespace: projectcontour
      8:39:10PM: ok: reconcile deployment/contour (apps/v1) namespace: projectcontour
      8:39:10PM: ---- waiting on 2 changes [15/17 done] ----
      8:39:12PM: ok: reconcile daemonset/envoy (apps/v1) namespace: projectcontour
      8:39:12PM: ---- waiting on 1 changes [16/17 done] ----
      8:39:40PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:39:40PM:  ^ Load balancer ingress is empty
      8:40:12PM: ---- waiting on 1 changes [16/17 done] ----
      8:40:40PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:40:40PM:  ^ Load balancer ingress is empty
      8:41:13PM: ---- waiting on 1 changes [16/17 done] ----
      8:41:41PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:41:41PM:  ^ Load balancer ingress is empty
      8:42:13PM: ---- waiting on 1 changes [16/17 done] ----
      8:42:41PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:42:41PM:  ^ Load balancer ingress is empty
      8:43:13PM: ---- waiting on 1 changes [16/17 done] ----
      8:43:41PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:43:41PM:  ^ Load balancer ingress is empty
      8:44:13PM: ---- waiting on 1 changes [16/17 done] ----
      8:44:42PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:44:42PM:  ^ Load balancer ingress is empty
      8:45:14PM: ---- waiting on 1 changes [16/17 done] ----
      8:45:42PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:45:42PM:  ^ Load balancer ingress is empty
      8:46:14PM: ---- waiting on 1 changes [16/17 done] ----
      8:46:42PM: ongoing: reconcile service/envoy (v1) namespace: projectcontour
      8:46:42PM:  ^ Load balancer ingress is empty
      8:47:14PM: ---- waiting on 1 changes [16/17 done] ----
    updatedAt: "2021-09-14T20:47:25Z"
  fetch:
    exitCode: 0
    startedAt: "2021-09-14T20:38:32Z"
    stdout: |
      apiVersion: vendir.k14s.io/v1alpha1
      directories:
      - contents:
        - imgpkgBundle:
            image: projects.registry.vmware.com/tce/contour@sha256:6a90a760b8851a23527bd778b4470cc6982bf5d6e27cd828c004b2ad1b634ccc
          path: .
        path: "0"
      kind: LockConfig
    updatedAt: "2021-09-14T20:38:37Z"
  friendlyDescription: Reconciling
  observedGeneration: 1
  template:
    exitCode: 0
    stderr: |
      resolve | final: docker.io/envoyproxy/envoy:v1.18.3 -> index.docker.io/envoyproxy/envoy@sha256:55d35e368436519136dbd978fa0682c49d8ab99e4d768413510f226762b30b07
      resolve | final: docker.io/projectcontour/contour:v1.17.1 -> index.docker.io/projectcontour/contour@sha256:3e2eb259697ad21415902436ba7d6544a2da007a8cb6d0a4abd46fa956a95d49
    updatedAt: "2021-09-14T20:38:37Z"

Environment Details

Build version (tanzu version):  0.7.0
Operating System (client): Linux csvm107 5.11.0-7633-generic #35-1630100930-21.04-ae2753e-Ubuntu

so that one could easily use 127-0-0-1.sslip.io as DNS name for ingresses on the cluster.

We also have local.projectcontour.io as a public DNS record for <IP_ADDRESS> for this exact purpose!

We also have local.projectcontour.io as a public DNS record for <IP_ADDRESS> for this exact purpose!


Versioning & Release process

We should define a way to version this, I can't find any version numbers.
Also, what's the release process? This should be documented so that everyone knows how it works.
Happy to propose something... just quickly opening this issue so that I don't forget.

Disclaimer: I'm not sure whether there's a best practice for versioning ML models.
We could version these models in a simple way I think, just incrementing numbers (e.g. v1, 2, 3 etc). We probably don't need minor (0.x.0) or patch versions (0.0.x).
Right now there are no version numbers associated with the release: https://github.com/fieldsoftheworld/ftw-baselines/releases
That makes it difficult in provenance to track the models. It also doesn't allow to simply reuse the (non-existing) version number to release on pip, so it's hard to release there in a way that there's a direct relation between model and software releases. The missing versioning also results in the question: What would be the next release? Overrriding the old one?
We couldthen  also release the software to pip alongside the model releases, but we should then break out software that's not used for the model creation, see #28 . This would allow to iterate on tools faster than the models evolve.


Fix handling of newlines in empty files

Summary
#7456 regressed our similarity index significantly because it enforced a trailing newline for all files, including files that only contain non-newline whitespace.
This diverges from Black that only inserts a trailing newline if the source isn't all empty and contains one or multiple newlines. The reason why this caused a big regression is because most
__init__.py files are all-empty, not needing a trailing newline. .py`
Test Plan
Newly added tests.
The similarity index is now back on track (with one fixed transformer test!)

project
similarity index
total files
changed files

cpython
0.76083
1789
1632

django
0.99982
2760
37

transformers
0.99957
2587
398

twine
1.00000
33
0

typeshed
0.99983
3496
18

warehouse
0.99929
648
16

zulip
0.99962
1437
22

Current dependencies on/for this PR:

main

PR #7473   👈

This comment was auto-generated by Graphite.


Scope for code optimization

Hi,
In render.js:
Inside for loop in ParticleSystemBatcher.prototype.push
var x = p.position[0] * lasBuffer.scale[0] + lasBuffer.offset[0];
Later on:
positions[ 3*i ] = p.position[0] * lasBuffer.scale[0] + (lasBuffer.offset[0] - this.corrective.x);
This is same as:
positions[ 3*i ] = x - this.corrective.x
Similar for y and z coordinates.
With huge number of points, avoiding this recomputation may help in improving the performance.
PS:If permitted, I can commit this change.

Please submit a PR and we can take it from there.


No class feats after level 10

Maybe this isn't an issue, but Players are going to hit level 15 in December and they will either run out of class feats to choose or will get a second class feat balanced for level 5. I recommend that we add a document to the level 10 folder that contains class feats that are balanced for level 15+ play.
As a comparison, 4E DnD would have whole separate classes for characters that reached level 10 called Heroic Classes. They also had classes that one could swap to at level 20 called epic classes. I'm not saying that we should use this model, but I do insist that we convey a continued sense of progression and things to explore after level 10.

Class feats are currently built to go up to 20? there are 2 types of feats for each class, and two tiers of each. they aren't both level 5 / level 10 feats.

alright. If you don't think it's an issue, we can close it out.

I think the current state is fine because there is at least progression, even if there isn't necessarily large jumps in power

I do eventually come up with another pair of feats for each class, and maybe another tier of current feats. Maybe we can make that a stretch goal?

I like stretch goals. :smile:


The instruction in the article "Duplicating a repository" is a little confusing and can be made more clear.

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/repositories/creating-and-managing-repositories/duplicating-a-repository
What part(s) of the article would you like to see updated?
https://user-images.githubusercontent.com/20169829/156549749-c2aa279a-c79c-4a68-aac5-e3e84bc55bb3.png
As you can see in the image above, this is not really correct.
When I --bare clone a repository, the folder that gets pulled into my local is my_folder.git instead of my_folder.
While reading this doc, it got me super confused as to which one to cd into and then which one to rm -rf.
Because in my case, I had a proper clone of a repo in a directory. Then I made a --bare clone in the repo. There were two directories my_folder and my_folder.git and it was not super clear to me which one to use.
Additional information
No response

Closed in https://github.com/github/docs/issues/16017


Marker icon labels appear off-center on initial load

Upon loading the page and the map, all of the icon labels are offset a bit to the bottom-right. The marker itself is fine.

I'm running OS X and this occurs on Chrome, Firefox, and Safari (most extremely offset on Safari). However, it does not occur on my Android phone using Chrome. Yes it does.
I've found that manually zooming in or out on the map will fix it and the icons will be centered inside the marker, even upon returning to the original zoom level. This likewise works if I zoom programmatically by calling map.setZoom(x) where x is a valid zoom level that is not equal to the current zoom level.
The above block is true. But the real takeaway was that causing the map to reload fixed the issue (you'll see why below).
Nevertheless, the problem is that the icons initially appear offset and stay that way unless zooming is performed.
EDIT:
Here's the rundown of what was actually going on. The icon font is loaded via css using @font-face. However, the browser does not actually fetch the font and "load" it until the browser finds it convenient to do so (probably when it notices the font is actually going to be used). This is problematic, because Google Maps wants to know (well in advance) how much space the icon label is going to take up when placed on top of the marker. The current map-icons.css specifies a line-height of 48px, so Google Maps can use that as a basis for the height the icon label will take up. But, Google Maps has no basis for guessing the width that will be taken up by the icon label. So naturally, it assumes it will be 0px. Thus, the offset at which the icon label was being drawn was based on the assumption that the icon label had a width and height of 0px x 48px. This explains why I was observing that strange offset.
Now, the things I crossed out above about zooming and it working on my phone are true. However, the reason those things were true is due to caching. When testing this in Chrome, I had caching disabled for the most part. So long story short, it took me a while to realize that this weird offset only occurred either when I had caching disabled, or when I hard-refreshed/visited the page for the first time. In other words, I eventually observed that whenever the font was cached, this issue did not occur. The reason being that, when the font is already cached and available, Google Maps can use the font information to figure out how much space the icon label will take up. Otherwise, Google Maps does not wait for the font to be fetched and just assumes a dimension of size zero if it has no information to go on.
Thus, I hope this explains what the fix in my PR does.

Fixed this in #36

I just started getting something similar in https://github.com/scottdejonge/map-icons/issues/39


dbt fake profiles cleanup and month_of_year dimension group option

Codecov Report
Base: 81.63% // Head: 81.42% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (81dea8c) compared to base (337500e).
Patch coverage: 37.03% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   81.63%   81.42%   -0.21%
==========================================
  Files          46       46
  Lines        5047     5067      +20
  Branches     1057     1065       +8
==========================================
+ Hits         4120     4126       +6
- Misses        706      716      +10
- Partials      221      225       +4

Impacted Files
Coverage Δ

metrics_layer/core/model/field.py
82.58% <ø> (ø)

metrics_layer/core/sql/merged_query_resolve.py
88.20% <0.00%> (-1.85%)
:arrow_down:

metrics_layer/core/parse/project_reader_base.py
71.57% <25.00%> (-4.29%)
:arrow_down:

metrics_layer/core/parse/project_reader_dbt.py
85.23% <53.33%> (-3.42%)
:arrow_down:

metrics_layer/core/sql/query_design.py
86.45% <0.00%> (+1.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Dependabot configuration changed to act only on main branch

Fixes: https://github.com/quarkiverse/quarkus-openapi-generator/issues/227

Cherry-picked to quarkus2 branch: https://github.com/quarkiverse/quarkus-openapi-generator/pull/233


maximum recursion depth exceeded

Hello,
When i use nplusone with rest_framework.authtoken, i get in the fallowing errors in the admin page
RecursionError at /admin/authtoken/tokenproxy/
maximum recursion depth exceeded

The same problem

The same problem

Same


add xpro users_user staging

Description
This pr creates the staging model for users user
The users_user table has the following columns
id - int postgres id for the table, keeping it as is
name - varchar renamed to full_name since user_legaladdress has first_name and last name
email - varchar keeping as is
is_staff - boolean dropping as per the discussion
password - varchar dropping
username - varchar keeping
is_active - boolean flag used to "delete" users. Keeping as is for now. We should separate users with is_active=False into a separate table in the intermediate layer
created_on- iso8601 string renamed to joined_on. Postgres sets this automatically when a row is created in the users table
last_login -  iso8601 string keeping
updated_on - iso8601 string, this is a field updated by postgres when the row is updated, Dropping, since it mostly tracks app internals. It should be just after last_login most of the time, whenever the script that updates that field actually runs
is_superuser - boolean dropping as per the discussion
Motivation and Context
https://github.com/mitodl/ol-data-platform/issues/351
How Has This Been Tested?
Tested locally
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Enhancement (improves on existing behavior)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@abeglova There is a failing test related to "Env var required but not provided: 'DBT_TRINO_USERNAME'"? Did the profile have DBT_TRINO_USERNAME?


Generate EPUB For Essay Collection

This is irrelevant with bypassing the app blocker, so maybe create a python/go script instead of pack it into chrome extension.


Fix datum add workflow

Brings in some changes that were never brought in to the original crate, runs a formatter, and introduces some Github Actions.

This was supposed to go into the other repo.


TapSigner & SeedSigner Remote sharing and signing

Feature Description
Enable remote sharing and signing flow for TapSigner and SeedSigner.

Verified this issue on keeper app v 1.2.21(424)


Not all strings are modified when editing VID

Current behaviour:
When editing VID to a different value not all strings are edited. Following will still say "VID":

"Choose the VID you'd like to share with NN" (popup to select the VID to share)
"Connected to device. Waiting for VID..." (displayed when requesting VID while "Sharing VID" is displayed on other device

Expected behaviour:
The strings now displaying VID should also be affected when editing the VID

Verified on a52253a. Working as expected

Verified on 0.2.0rc3. Working as expected.


Clean shutdown

When I stop this container, does it perform a clean shutdown of the server? In other words, does it command the Terraria server to save the world file before killing the process? Or is it possible that world data could be lost upon stopping the container if the world file was not saved recently?
If not, then can the container be modified to include this feature so that world data will not be lost?
docker-compose config:
version: '3.5'
services:
  terraria:
    image: beardedio/terraria
    container_name: terraria
    environment:
      - world=world.wld
    ports:
      - 7777:7777
    volumes:
      - ./config:/config
    restart: unless-stopped
    stdin_open: true
    tty: true

The world definitely saves periodically, and as far as I can tell as long as I do a "soft" shutdown of the container it saves the world before exit.

The container is just a wrapper for the server code itself. So how ever the server handles a shutdown is how that works. I assume it will attempt to send a normal shutdown command and it should only issue a kill command if the process doesn't close in a certin amount of time.

After some testing I dont think ether Vanilla or Tshock will do a save before closing. I will re-open this and see if I can add it to the startup script. Tho It may take a while.

Thanks for looking into this! Based on my own testing, I agree. It doesn't seem to do a save before closing, it seems to just kill the process. It would be nice if we could send the "exit" command to the Terraria server when the container is stopped.

How is this looking? Came across this the other day and was super happy to see it being talked about. Was interested in trying my hand at it, but if it is already in the works or anything then I'll leave it to whomever.

Super subscribed! Appreciate the work on this.

@AustinMcPhail I have not had time to work on this feature, feel free to take a crack at it.

I was looking at this too, and think it should be possible to install screen into the container for running the server. There is an AUR package that uses screen as part of running as a systemd service https://aur.archlinux.org/cgit/aur.git/tree/terraria-server@.service?h=terraria-server
The relevant bits are:e
# Screen is used, because the terraria server binary crashes if called on its own.
ExecStart=/usr/bin/screen -DmS terraria-server-%i /usr/bin/terraria-server -config /opt/terraria-server/%i.conf
# Send a warning message to all players and the exit command through screen to let the program terminate itself gracefully
ExecStop=/usr/bin/screen -S terraria-server-%i -X stuff "say Server shutting down. Saving world.\015"
ExecStop=/usr/bin/screen -S terraria-server-%i -X stuff "exit\015"

I bet this could be adapted into a startup script for docker, so I am going to give this a try today.

I finally settled with the following scripts: https://gist.github.com/Noutbuk/85d455a90fa68862c9437678f89d27d7
I don't know if this is the recommended way, but works well for a small server with some friends.
Maybe they are useful for some of you as well.


ambiguous empty issue (WIP)

We should fix this to let argmin/max return null if the argument list is
empty.
this should simplify a lot of real world code, e.g.
datastructure-synthesizer/followup/eval/mongo/spec.ds
Test:
cozy argmin.ds

For whatever it's worth, here are my thoughts on various designs for partial functions like argmin in Cozy. Note that the the operator is another partial function that could also return null instead of behaving how it does now, so it is also related to this topic.

Have partial functions return a "default" value of the appropriate type (e.g. 0 for integers). This can be surprising because adding an element to a set might cause the minimum to increase: if the set changes from {} to {-1} because you added -1 to it, then the minimum goes from 0 to -1.
Use design 1, but forbid specifications where a partial function could return a default value. This is what Cozy does today, and it is why you need to add additional assumptions and if-conditions to specifications when you use primitives like argmin. I like this design because it forces programmers to think more carefully about what should happen when you try to extract elements from an empty collection.
Throw an exception at run time when a partial function would fail. This is what Java does so it might feel more familiar to programmers, but the synthesis engine does not reason about exceptions so it is very difficult to implement. (Issue #19 exists to track progress on this.) Unlike design 2, this would allow programmers to write specifications with methods that fail at run time even when the method preconditions written in the specification are satisfied. Therefore I don't like this design as much.
Introduce a safe "Maybe" or "Optional" type for the output of partial functions. This was actually how Cozy behaved at one point in the past, but I removed it in favor of design 2 because it required many more internal primitives and much longer synthesis times. Instead of using the output of a min computation directly, synthesis would need to introduce lots of extra primitives to "unpack" the optional value, which makes solutions have more AST nodes and therefore harder to discover.
Extend all existing types (integers, booleans, collections, etc.) with a null value. This would require a lot more run time checks from the code generator, and would introduce more overhead into the generated code. It also means that we cannot use, say, the native C++ bool type because it does not have a null value.
Have min return the set of all smallest elements in the collection rather than one of those smallest elements. This design is very elegant from an implementation standpoint: it does not introduce an optional type but represents the "optional" output using an empty or nonempty collection. Cozy already has many good heuristics for working with collections. However, I decided this design was too confusing from a specification-writer standpoint.


Fix example link and some typo in Readme

The examples link was wrong, and I fixed minor typo & punctuation in the sentence about SkimItemReader

Could you also change the old repository url to the new org please ?

@LoricAndre Good catch! I updated the url to this repository

Have you proofread the rest of the README ? I'd like to avoid merging a PR this small if we can

Have you proofread the rest of the README ? I'd like to avoid merging a PR this small if we can

I haven't. Good idea, I'll proof read the rest of the readme and add a new commit


Dependency issue with latest Ionic Angular release

Hi all,
I have used Ionic + Capacitor for years but this is my first time attempting to use Sentry so I apologize in advance if I'm missing anything obvious.
Environment
Windows 10
nvm-windows: 1.1.12
node.js: 20.14.0
npm: 10.7.0
@ionic/cli: 7.2.0
@sentry/capacitor: Installation of latest version fails; see error list below
Steps to Reproduce
Quick summary:
Starting from a fresh installation of the latest Node.JS LTS, I installed only the latest Ionic CLI (no other packages).  I then created a new blank Ionic project using the Angular framework.  In that project folder I tried installing @sentry/capacitor and @sentry/angular following the Sentry.IO docs.  This is about as clean an installation as I can imagine so I'm not sure what I could be doing wrong.
Detailed steps to reproduce:

Install latest nvm-windows (1.1.12)
Install latest LTS version of node.js: nvm install 20.14.0
Install latest Ionic version: npm install -g @ionic/cli
Start a new Ionic project: ionic start
When asked about using the app creation wizard, select 'No'
When asked which framework to use, select Angular
When asked for a project name, enter 'sentry-test'
When asked which starter template to use, select 'blank'
When asked about using NgModules or Standalone, choose NgModules
When asked about creating a free Ionic account, select 'No'
Navigate to the newly created project folder
Try to install sentry: npm install --save @sentry/capacitor @sentry/angular

Expected Result
Sentry installs as outlined in the documentation.
Actual Result
Sentry fails to install with the following dependency errors:
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/@angular/common
npm error   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@angular/forms
npm error     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@ionic/angular
npm error<EMAIL_ADDRESS>from the root project
npm error<EMAIL_ADDRESS>from the root project
npm error   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@angular/platform-browser
npm error     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@angular/forms
npm error       peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error       node_modules/@ionic/angular
npm error<EMAIL_ADDRESS>from the root project
npm error       1 more (the root project)
npm error     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@angular/platform-browser-dynamic
npm error<EMAIL_ADDRESS>from the root project
npm error     2 more (@angular/router, the root project)
npm error   3 more (@angular/platform-browser-dynamic, @angular/router, the root project)
npm error
npm error Could not resolve dependency:
npm error peer @angular/common@">= 10.x <= 15.x" from<EMAIL_ADDRESS>npm error node_modules/@sentry/angular
npm error   @sentry/angular@"" from the root project
npm error   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@sentry/capacitor
npm error     @sentry/capacitor@"" from the root project
npm error
npm error Conflicting peer dependency<EMAIL_ADDRESS>npm error node_modules/@angular/common
npm error   peer @angular/common@">= 10.x <= 15.x" from<EMAIL_ADDRESS>npm error   node_modules/@sentry/angular
npm error     @sentry/angular@"" from the root project
npm error     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@sentry/capacitor
npm error       @sentry/capacitor@"" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
In case it helps, here is the result of 'npm list' inside my blank Ionic project.  The only package that I installed is @ionic/cli.  All other packages were installed automatically when Ionic created the blank project.  Ionic does not provide any way to pick which package versions are used so I'm stuck with these versions.
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>Any help would be appreciated.  Thanks in advance!

Hey for the time being Angular 18 is not supported, I'll check with the internal team what's the best solution for this case, sorry for that  :/

In regard to this conversation, lets keep this conversation on this issue to avoid duplicated issues #671


Fix of occasional loss of custom data. Extraction of a trace from a crash report (but disabled for now).

Description of the change

Fixed edge cases when some of the user-defined custom data could be erroneously omitted from a payload.
Implemented extraction of a Trace from a CrashReport-like payload and attaching it to the payload
side-by-side with the initial crash report. This feature is disabled for now (until the backend is ready to accept this change).

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

n/a

Checklists
Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

@akornich In the description, can you explain why the custom data was lost and what the fix is?
Also, in the future can you put separate units of work (e.g. a fix and a separate feature) into two PRs. Each PR will be smaller and focused on the described work, and this will be easier on your reviewers.

@akornich In the description, can you explain why the custom data was lost and what the fix is?
Also, in the future can you put separate units of work (e.g. a fix and a separate feature) into two PRs. Each PR will be smaller and focused on the described work, and this will be easier on your reviewers.

@akornich In the description, can you explain why the custom data was lost and what the fix is?
Also, in the future can you put separate units of work (e.g. a fix and a separate feature) into two PRs. Each PR will be smaller and focused on the described work, and this will be easier on your reviewers.

@waltjones , adding more details about the fix...
the issue was discovered while developing a new feature. while there the fix was applied. that is the reason both the fix and the new feature ended up in the same PR.
Planned ahead fixes usually do go into separate PR. Agree completely.

@akornich In the description, can you explain why the custom data was lost and what the fix is?
Also, in the future can you put separate units of work (e.g. a fix and a separate feature) into two PRs. Each PR will be smaller and focused on the described work, and this will be easier on your reviewers.

@waltjones , adding more details about the fix...
the issue was discovered while developing a new feature. while there the fix was applied. that is the reason both the fix and the new feature ended up in the same PR.
Planned ahead fixes usually do go into separate PR. Agree completely.

@bishopb , @waltjones , thanks a lot for the review!

@bishopb , @waltjones , thanks a lot for the review!


[Nomination]

Who are you nominating?
@the-frey
What are you nominating them for?
there clear documentation not only for Cosmovisor but all the other content he has contributed his time to.
Please provide links to their work.
https://docs.junochain.com/validators/setting-up-cosmovisor

A great nomination! Closing as a duplicate of: #9


Documentation of scipy.signal.cwt error

There is probably an error in the documentation of scipy.signal.cwt:
It is:
Returns:
cwt: (M, N) ndarray
Will have shape of (len(data), len(widths)).
It should be:
Returns:
cwt: (M, N) ndarray
Will have shape of (len(widths), len(data)).

Looks correct, care to submit a PR with a fix?

Sorry but I am not familiar with this project nor with GitHub in general, can you do that for me?
Thanks


Adding  DIVD-2024-00051

Adding  DIVD-2024-00051

Thanks @oscar-vlugt, the requested changes have been made and the pull request is ready for re-review.


Footer not showing properly on mobile

For some reason footer isn't showing any text on mobile, weird

This is fixed with #13


Added [User Guide] Module Outputs to Wiki

Overview/Summary
This Pull Request adds a new page [User-Guide]-Module-Outputs.md to the Wiki which details all the outputs for the module and how to use them effectively.
This PR fixes/adds/changes/removes

Added a new page of documentation.
Changed _sidebar.md to include new page.

Breaking Changes
No Breaking Changes (Documentation).
Testing Evidence
No Testing Evidence (Documentation).
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.

Thanks Luke! Will check this out tomorrow

/azp run unit

@matt-FFFFFF I've added a new commit fixing the markdownlint violations, should be good now.

/azp run unit


Run analyzers that sonar cloud runs

This enables analysers that Sonar Cloud runs so that they can be caught in local development instead of the slow cycle of getting an issue in sonar cloud.
This is part of #730, because I changed these to warning in .editorconfig because it made the sonar cloud issues easier to find. I think this could be reviewed separately.
Verification

[x] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

nice! are you adding SonarAnalyzer.CSharp as well or is this just about catching builtin warnings that sonar also complains about?

This is part of #730, and I seem to have not fixed all warnings here.


Support for OAuth2 token authentication for API?

I've been working on an OAuth2 extension to allow Zulip to generate access tokens, allowing clients to call with the Bearer token in the Authorization header. Currently using the django-oauth-toolkit (https://django-oauth-toolkit.readthedocs.org/en/latest/index.html).
That library provides various ways to hook in the token authorization - hooks into djangorestframework; "@protected_resource()" decorator for functional views; and a middleware: "oauth2_provider.middleware.OAuth2TokenMiddleware".
None of these authenticators seem all that compatible with the "rest_dispatch" method in zerver/lib/rest.py, particularly due to the Basic auth requirement:
...
        if not request.path.startswith("/api") and request.user.is_authenticated():
            # Authenticated via sessions framework, only CSRF check needed
            target_function = csrf_protect(authenticated_json_view(target_function))
        elif request.META.get('HTTP_AUTHORIZATION', None):
            # Wrap function with decorator to authenticate the user before
            # proceeding
            target_function = authenticated_rest_api_view(target_function)
        else:
...

Would you recommend any approach to supporting Oauth or potentially other auths? The best thing I can think of is to add a "request.user.is_authenticated()" check to bypass the API authorization, and let the user auth take place in the middleware - Oauth2TokenMiddleware. Any other suggestions?

Maybe something like this. How do you feel about authenticating users at the Middleware layer?
 # A more REST-y authentication decorator, using, in particular, HTTP Basic
 # authentication.
 def authenticated_rest_api_view(view_func):
     @csrf_exempt
     @wraps(view_func)
     def _wrapped_view_func(request, *args, **kwargs):
+        if request.user.is_authenticated():
+            profile = request.user
+        else:
-        # First try block attempts to get the credentials we need to do authentication
-        try:
...
-        request.user = profile
-        process_client(request, profile)
+            # First try block attempts to get the credentials we need to do authentication
+            try:
...
+            request.user = profile
+            process_client(request, profile)
+
         if isinstance(profile, UserProfile):
             request._email = profile.email
         else:
             request._email = "deployment:" + role
             profile.rate_limits = ""
         # Apply rate limiting

Can you give a bit more detail on what you're trying to do?  If the goal is SSO-style authentication for logging into the website, you could define another auth backend in zprojects/backends.py.
If the goal is to support Oauth-based API bots/integrations, then authenticated_rest_api_view is probably the right place to put the oauth check; I'd just patch the elif request.META.get('HTTP_AUTHORIZATION', None): to check for the relevant Oauth headers as well before dispatching to authenticated_rest_api_view.

I am supporting Oauth-based API - on behalf of a user, rather than bots/integrations (though no reason to exclude them).
Thanks for the feedback!

Ahh, OK, that makes sense.  Yeah, then I think authenticated_rest_api_view is the place to do it.

Was it successfully. ? Are you able to generate authorisation tokens to allow other clients to call the api and successfully login.! Kindly help the steps.
Thanks in advance.


yaml file for Task 1

Hello Rohit,
The yaml file in the repository is corresponding to Task 3.
Can you please share the yaml file for Task 1?
Thank You

Hi Team,
We would like to check the Yaml file for Task 1 for reproducing the results described in the paper.
I have tried reproducing paper but the results don't match up


Upload stage timing from perf pipeline to kusto

Description
Today, the pipelines get broken frequently and we do not have a way to generate alerts whenever it happens. As a proof of concept, this change adds a stage to the performance benchmark that makes a simple REST call to the timeline API from dev azure to request information about the current build id. With that information in hand, we upload to ARIA and, as a result, we will be able to create monitors and alerts based on the stage results as well as find out avg duration of each stage.
The idea is to do something similar to other pipelines as the need arises.
@alexvy86  I believe there is a way to dynamically get the name of all previous stages and use them to make sure the last one to be run is the one we've created. For now, I kept it hardcoded but ideally, we should move in that direction. Thoughts?
Also, notice I'm only using the stages and not the tasks (there are TOO many tasks and for now I will not upload them).

I will merge but please let me know if there are any concerns and we can address them.


Implement Vault plugin mechanism to return data asset credentials from OpenMetadata

OMD catalog in the getAssetInfo call returns a vault path to the data asset credentials.
Fybrik modules ask vault to get these credentials. We need to implement a vault plugin to achieve the credentials from OMD.

Completed: https://github.com/fybrik/vault-plugin-secrets-kubernetes-reader/pull/1


[BugFix] Pagination and Serial number column issue is fixed

Pagination is working now and serial number column is also working. You have to write keyName='sno' to get serial number.

Please squash this PR.

Great work @prateek-yojak 👍


Render problem

Hello
I have read your source code and I think it's a very good job.
but I found some problem during rendering.
when I move my view port to some certain location，there will be some remnant traces on the
screen.
may i ask you how to to solve this problem●ˍ●？
thxXD

The reason is that the algorithm has a buffer to cache pixels (position/color) for exploiting frame-to-frame coherence. The size of the octree is 2048 or 4096. If you go outside, then the position will be set to pos % (2048,2048,248) which means that the position in the octree changes, but the cached positions are only modified a bit, so artifacts will remain

●0●thanks for answering my question
however,i just move my viewport close to one of the model,not ouside....

ok, that can be either because of concurrent zbuffer writes (if its remaining pixels). The noise when getting close is due to the imperfect reprojection, there are always gaps between reprojected pixels

ok.thanks for your patient answering agaInXD
how can i improve this imperfect thing?

for the permanent pixels you can use atomic operations. the other noise is hard to solve. alternatively you can render each frame from scratch without re-projection


WIP fix for #79

This makes it so that the test case in #79 validates, and all the wasmparser tests pass, but introduces failures in this whole repo's round trip tests:

failed test: tests/testsuite/proposals/reference-types/unreached-invalid.wast

Caused by:
    2 test failures in tests/testsuite/proposals/reference-types/unreached-invalid.wast:

    	--------------------------------

    	failed directive on tests/testsuite/proposals/reference-types/unreached-invalid.wast:690:2

    	Caused by:
    	    no wasm validation error found

    	--------------------------------

    	failed directive on tests/testsuite/proposals/reference-types/unreached-invalid.wast:701:2

    	Caused by:
    	    no wasm validation error found
failed test: tests/testsuite/unreached-invalid.wast

Caused by:
    2 test failures in tests/testsuite/unreached-invalid.wast:

    	--------------------------------

    	failed directive on tests/testsuite/unreached-invalid.wast:689:2

    	Caused by:
    	    no wasm validation error found

    	--------------------------------

    	failed directive on tests/testsuite/unreached-invalid.wast:700:2

    	Caused by:
    	    no wasm validation error found

I'm not sure I totally understand how wasmparser's stack polymorphism handling works, but the bug seems to orbit that code. It looks like wasmparser is trying to avoid memory overheads of representing the operand stack as Vec<Option<Type>> where None is a stack polymorphic value, and is instead keeping track on the side of how many stack polymorphic values we have at what index in the stack? I'm not 100% sure it is relevant to this bug, but what happens when there are two places in the operand stack where we have stack polymorphic values? I guess that once you start popping from a stack polymorphic section, you should never be able to get past it again to earlier values (other than exiting the control frame) right?
Anyways, since you're more familiar with wasmparser's validator, I was hoping you could help investigate what's going on here, @yurydelendik. Thanks!

wasmparser: add a validation example program

there is cargo run --bin wasm-validate-rs ...
The complete fix can be found at #80. Closing this one.


confirm: calling navigate with the same route but different params does not reload browser pane

I was working on some refactoring of how I am handling some code that modifies a query string parameter in one of my routes for my application.  Currently the route url might look like the following
http://somehost:9005/stamp-web#stamp-list?$filter=(countryRef eq 5)

if I call the router with navigate() like the following:
this.router.navigate(this.router.generate('stamp-list', {$filter: '(countryRef eq 7)'}));

Is it safe to assume this will not cause a browser page reload (it will reload the route stamp-list only)?  I also did not see the change in the query string cause the route to

re-execute attached()
re-execute activate()
re-execute bind()

I am perfectly happy with this, however I wanted to verify this is indeed correct and modifying the query string and calling navigate on the same route will not cause a re-execution of the route's view-model lifecycle.

(this was phrased as a question - but I can not set labels on the issues)

That's correct. By default a query string change won't run lifecycle methods. You can control this behavior by implementing a determineActivationStrategy method on your view model.
import {activationStrategy} from 'aurelia-router';
...
class MyViewModel {
  determineActivationStrategy() {
    return activationStrategy.replace; //replace the viewmodel with a new instance
    // or activationStrategy.invokeLifecycle to invoke router lifecycle methods on the existing VM
    // or activationStrategy.noChange to explicitly use the default behavior
  }
}


Make token optional

The token is actually optional depending on which domain you send to, fixing this as per a support thread between Hussam Hebbo & Ivan Žužak (GH).

Hi @Seldaek, would you mind adding a corresponding test to ensure that the token is indeed now optional?
You'll also need to accept the GitHub CLA that's listed in the failing checks directly below this message.

Done and done :)

Hi @Seldaek, this looks good 👍. I intend on deploying this within the next week.


Update encrypted API key

Merging since this change is trivial, autogenerated, similar to previously approved, and needed for test cycle.


TEST revert 1

Signed-off-by: Romy<EMAIL_ADDRESS>Explain the changes

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

[ ] Doc added/updated
[ ] Tests added

Closing as it is not needed anymore -
https://github.com/noobaa/noobaa-core/pull/7062 fixed


DataSource.Error: Web.Contents with the Content option is only supported when connecting anonymously.

I keep getting this error even when I have edited my data source setting to anonymous.

Have you setup the OAuth environment on the Genesys Cloud ORG as well as changed ALL the locations in the script on where the login URL is.... as im based in the ".com.au" region if you are in another region you will need to change all references to this location or you will get OAuth issues. details on the GC regions can be found here: https://developer.genesys.cloud/platform/api/

Thank You for the response, I think I'm having a hard time because the query has too many moving parts, would be so kind to put a simple "get all users" query?

@azeedo here is a example of a query where you will be able to call the /api/v2/users endpoint which is a GET request to return a simple array object or "List" in PowerBi that you can then use for testing. NOTE you will need to put in your own region and clientId/Secret into the query. You will also still need to "ignore" the privacy levels. I just tested this and it worked fine if this is working please let me know so i can close the issue.
let
//Get the API Token
login_url = "https://login.mypurecloud.com.au/",
token_path = "oauth/token",
ClientID = "ENTER_YOUR_CLIENTID",
Secret = "ENTER_YOUR_SECRET",
EncodedCredentials = "Basic " & Binary.ToText(Text.ToBinary(ClientID & ":" & Secret), BinaryEncoding.Base64),
Token_Response = Json.Document(Web.Contents(login_url,
[
RelativePath = token_path,
Headers = [#"Content-Type"="application/x-www-form-urlencoded",#"Authorization"=EncodedCredentials],
Content=Text.ToBinary("grant_type=client_credentials")
])),
//API query conversation details job endpoint
token = Token_Response[access_token],
api_url = "https://api.mypurecloud.com.au",
query_path = "/api/v2/users",
data= Json.Document(Web.Contents(api_url,
[
RelativePath = query_path,
Headers = [#"Authorization"="Bearer "&token,#"Content-Type"="applicaiton/json"]
])),
users = data[entities],
#"Converted to Table" = Table.FromList(users, Splitter.SplitByNothing(), null, null, ExtraValues.Error)
in
users

Thank You so much for the sample, it did help me find out where the issue was.  It appears that under I had failed to assign roles to my Client Credentials.  Once I added the roles it worked like a charm.

Glad to hear it is now working I'll close this issue.