(fix): fixed debounce mechanism

Notes for Reviewers
This PR fixes #11306
Signed commits

[x] Yes, I signed my commits.

Fixed debounce mechanism by implementing a useDebounce hook for searching functionality which reduces the API calls drastically. Below Screen recorder is evident for this.
Before:
https://www.loom.com/share/db39c55461eb4d16b2f26b5f08ec529c?sid=459fa63c-d66a-480b-a74d-dab4129ec48f
After:
https://www.loom.com/share/8e7a0b1238724ba5b46dd1c282aed534?sid=7f22369a-c457-444e-b75c-e83b300d6419

@senthil-k8s
Let's discuss this in Meshery Dev meeting starting 7:30 PM IST Today. Adding this as an agenda item....
Meeting minutes: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit?pli=1#
Meeting link: https://meet.layer5.io/meshery

The aim is to reduce the code repetitive of debounce() in multiple places. Current scenario leads to me call the debounce one more again,
             <SearchBar
                onSearch={debounce((value) => setSearch(value), 300)} // calling debounce
                expanded={isSearchExpanded}
                setExpanded={setIsSearchExpanded}
                placeholder={`Search ${pageTitle.toLowerCase()}...`}
              />

const SearchBar = ({ onSearch, placeholder, expanded, setExpanded, value = '' }) => {
  const [searchText, setSearchText] = useState(value);
  const searchRef = useRef(null);

  const debouncedOnSearch = debounce(onSearch, 500); // calling debounce

  const handleSearchChange = (event) => {
    debouncedOnSearch(event.target.value);
    setSearchText(event.target.value);
  };

  const handleClearIconClick = () => {
    setSearchText('');
    debouncedOnSearch('');
    setExpanded(false);
  };

  return (
    <div style={{ display: 'flex', alignItems: 'center' }}>
       ....
    </div>
  );
};

The search bar should have the ability to implement a debounce effect without requiring its parent component to call the debounce function.
            <SearchBar
                onSearch={(value) => setSearch(value);}
                expanded={isSearchExpanded}
                setExpanded={setIsSearchExpanded}
                placeholder={`Search ${pageTitle.toLowerCase()}...`}
              />

const SearchBar = ({ onSearch, placeholder, expanded, setExpanded, value = '' }) => {
  const [searchText, setSearchText] = useState(value);
  const searchRef = useRef(null);

  const debouncedValue = useDebounce(searchText, 500);
  const handleSearchChange = (event) => {
    setSearchText(event.target.value);
  };

  const handleClearIconClick = () => {
    setSearchText('');
    onSearch('');
    setExpanded(false);
  };

  useEffect(() => {
    onSearch(debouncedValue);
  }, [debouncedValue]);

Ohh ho! DCO check is failing

Thanks for helping improve Meshery, @senthil-k8s

@aabidsofi19 I've made changes based on your feedback.

@Yashsharma1911 Any updates on these PR? Changes made based on feedback.


[Enhancement]: Promote 1.4 to stable

What changes would you like?
Hi,
it looks like 1.4 works well enough and fixes a few of the outstanding bugs in this tracker.
Would it make sense to promote it to stable?
I recently hit the mesa issue https://github.com/diddlesnaps/supertuxkart/issues/23 on a new installation and it took me a while to figure out that it defaulted to 1.3. I guess the same might happen to others.
Any extra information?
No response

ping


LUCENE-9971: SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

Description
Unlike other org.apache.lucene.facet.Facet interface implementations, SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts throw an exception in case of unseen dimension in the getTopChildren() method.
It is inconsistent with Facet interface documentation and not pleasant to deal with: in our case, the requested dimensions can be manually specified by the user, so we should always catch that and check the exception message to be sure of the exact cause (exception as a control flow anti-pattern).
Hopefully, it is not a big backward compatibility concern. Current implementation may return null before these changes, so users should be prepared for this.
Solution
Return null instead of throwing exceptions. The second commit also includes a minor debug prints cleanup.
Tests

TestSortedSetDocValuesFacets

Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.

Hi Greg,
You are right, TaxonomyFacets fail with IllegalArgumentException in the case when we are trying to search for a field that has a different indexFieldName. Although here we are not even checking that the dimension is present for the configured indexFieldName - this error is only related to the field mismatch.
That behavior actually looks more or less consistent with SSDVFF implementation. There, if we try to create a SortedSetDocValuesReaderState for a field that was never indexed with facets, we fail with IllegalArgumentException.
Although those IllegalArgumentExceptions are thrown in slightly different situations, I think in both cases they are pointing to a field name misconfiguration (or a bug in the code), rather than "user requested unseen dimension" scenario. As far as I understand in most of the cases the facet field name is a single/constant set of values, so most likely we indeed want to make sure that user does not ignore it. Also, this behavior can't be easily changed for SSDVFF, since the field check happens in SortedSetDocValuesReaderState constructor - we can't return null there.
@gsmiller let me know what do you think!

Thanks for diving into this @sqshq! Yeah, I think I agree with all this. I suppose the subtle difference here is that in taxonomy-based facet counting, FacetsConfig would never have been told about a custom index field (because presumably it's not a valid dimension). You could get in a weird scenario though where you're using some custom index field for all your taxonomy faceting (and have never indexed anything in $facets). In other words, you've specified one or more custom index fields to hold the doc values via FacetsConfig and your index doesn't contain the $facets field at all. In this (somewhat unusual) case, if calling code were to ask for a dimension that was never indexed (same scenario you're describing in SSDVFC), you'd still get an IllegalArgumentException in TaxonomyFacets#verifyDim (because it would try to look up the configured index field for the dimension, wouldn't find it, fall back to $facets and then also not find that). That said, I don't think fixing that as well necessarily needs to be part of this change. It would be nice though if that could also consistently return null.
Well, +1 for making the change you proposed, particularly since it's consistent with the Javadoc as you point out as well.

@gsmiller I got your point, and certainly don't mind making the Taxonomy part consistent for this edge case as well.
Please take a look: https://github.com/apache/lucene/pull/149/commits/fd01e65c45b16cf94098aa2b199bd34494d192be

Thanks for taking this on @sqshq!

Looks great @sqshq! Thanks for taking this up.


Adding scope for PIM for group reviews creation

Adding the scope for PIM for group reviews creation.

[!NOTE]
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.

do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Hi @clairechiu1004 , @leherpel - Based on our internal conversations, I think closing this PR is the proper course of action? Please feel free to reopen it and review the thread if otherwise.


[iOS SPXSpeechSynthesizer]: Can we cache the synthesizer result, then speak it out at a later time.

Every time we synthesizer a sentence, it takes 2-3 seconds to start speaking due to the network delay maybe. We need every sentence be spoken fluently one followed by another one.
So we'd like to cache the synthesizer result first (without speaking it), util the previous sentence speaking finished. And it will use the cached result, and no need to fetch it from the server.
Do we have some API to accomplish this?
Thanks.

@maxxfire may I ask you for an example of your implementation of the synthesizer?
I have this issue (other developers too) and no answer/solution has been provided:
https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/2150
Curious to know if you're facing the same issue. Else, know what your implementation looks like to prevent this crash.
Thanks!

I would suggest setting the synthesizer output to a file or stream, rather than setting it for automatic playback to the default audio device. Then you will have control over when you play back the audio.  If you are using things like word level timing events, it would also allow you to more tightly sync highlight text in a read along scenario, to when the audio is header by the user, as opposed to when the audio was generated and streamed to the client...
you can find several examples of using push and pull output streams with TTS at https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/f57dcd21de09a8dca64e7c577e11b0b683b632dc/samples/csharp/sharedcontent/console/speech_synthesis_samples.cs#L373

If you would like an example of using word level timing data, take a look at this sample.
https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/f57dcd21de09a8dca64e7c577e11b0b683b632dc/samples/csharp/sharedcontent/console/speech_synthesis_samples.cs#L671

Sorry, I just noticed the iOS in the issue title.
you can see some Objective C example of stream output here https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/f57dcd21de09a8dca64e7c577e11b0b683b632dc/samples/objective-c/ios/synthesis-samples/synthesis-samples/ViewController.m#L240

Closed as answered, please open a new issue if more support is needed.


Add options

Add

description field for cdn resource struct
webp optimization option
browser cache settings option

After acceptance of this PR next one will be created: https://github.com/G-Core/terraform-provider-gcorelabs/compare/master...skyeng:additions_from_skyeng?expand=1

@ujhgj thank you for PR, will be reviewed ASAP

@ujhgj I close it as all options have been added. I'll add them to https://github.com/G-Core/terraform-provider-gcorelabs as well.


Can the 'MaxPingsOut' parameter be specified when connecting?

	// PingInterval is the period at which the client will be sending ping
	// commands to the server, disabled if 0 or negative.
	PingInterval time.Duration

	// MaxPingsOut is the maximum number of pending ping commands that can
	// be awaiting a response before raising an ErrStaleConnection error.
	MaxPingsOut int

I can find the PingInterval configuration interface but can't find the MaxPingsOut
// PingInterval is an Option to set the period for client ping commands
func PingInterval(t time.Duration) Option {
	return func(o *Options) error {
		o.PingInterval = t
		return nil
	}
}

Thanks.

Right functional option for MaxPingsOut is currently missing... as a workaround you can set it directly by using the defaults from a connection using GetDefaultOptions().

Thanks we will make sure to add this functionality.


Way to disable via environment variable

When developing locally I don't really need to send logging data to Logtail. It would be nice to be able to set the token to null and have it just silently continue instead of throwing. null being be different from undefined, which could have been unintentional.
Is there way convenient way to do this already?

Hi @KevinBatdorf,
Thank you for the suggestion. I will add it to our internal ticketing system.
I will make sure to keep you posted.

Hello @KevinBatdorf,
I'm proposing to add two boolean options (sendLogsToBetterStack and sendLogsToConsoleOutput) to our logger in https://github.com/logtail/logtail-js/pull/67
When you don't want logs sent to Better Stack you'll be able to initialize with those flags, for example:
const { Logtail } = require("@logtail/node");
const logtail = new Logtail("$SOURCE_TOKEN", {
  sendDataToBetterStack: false,
  sendLogsToConsoleOutput: true,
});

logtail.error("Something bad happend.");
// error will be sent only to console.error()

(of course, these flags can be set via ENV variables in the real code)

I'll post here the required version when it's merged and released.

Hello @KevinBatdorf,
version 0.4.3 of our JS client has been released, which should help you with the configuration you want 🙂
Thanks for bringing it up!


Reef Detail Page Temperature Data

This pull request concerns the temperature data on the reef detail page.


Istio/proxy prow post-submit step doesn't test built artifacts

Bug description
In the https://github.com/istio/proxy repo we use  a mix of CircleCI and prow for builds. CircleCI is used for building & testing whereas prow is used for building & pushing. Currently, these two different CI systems use different base images (different OS distros) which can cause variances in what we are building, testing & pushing.
Either prow should do all the 3 steps - build, test, push (in which case CircleCI is not needed) or use the artifacts produced by CircleCI (which is tested) and only push and not rebuild. The current combination can lead to security escapes.
This is the prow log from master which shows that it builds a new binary:
No URLs matched: gs://istio-build/proxy//home/bootstrap/istio-proxy-debug-2011544571a28461331322ed2274c9d7b6693294.deb+ echo 'Building a new binary.'
and copies over the artifacts without testing.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Prow is also used for testing, two CIs run basically the same pipeline in presubmit. Istio repos are shifting away from circle, we should do the same for proxy once we make sure two CIs run identical workflow.

If I look at the checks on any commit in istio/proxy repo I only see prow/post-submit.sh and 5 CircleCI checks.
Am I missing something/somewhere else I should look at?

There are three prow jobs in presubmit. For example, in this PR from you https://github.com/istio/proxy/pull/2364, if you scroll the list of checks down you will see them.

Sorry about the confusion, I'm not talking about PRs but after the merge is done

This only runs 6 checks so the prow/post-submit.sh rebuilds the binary afaict.

In the presusbmit it run
prow/proxy-presubmit-asan.sh
prow/proxy-presubmit-tsan.sh
prow/proxy-presubmit.sh

though? in the PR it is the same binaries as what is the postsubmit?
Or are you suggesting that we need to test and release the exact same binary, rather than building+testing then building+publishing (even if the build step is the same)?

@howardjohn normally you want to test and release the same binary. You save the artifacts after the test step and publish them (debian or container). Re-building after testing is always tricky but if you're using the same builder image and steps it's probably fine.
In this case, PR builds seem to be ok. It would be better if the post-submit consumed pre-submit binaries but rebuilding is not horrible.
After the merge though, not running tests again on the new commit (prow only runs post-submit again) looks weird/incorrect to me. Tests are only run by CircleCI which has a different builder image than prow.

My understanding is the main point of running postsubmit tests is so we can look at the history of a testwith no noise (all failures in postsubmit are real, but presubmit ones may have failures from the PR)
The actual code being merged though is still tested the same amount - it is the exact same code being tested in presubmit and postsubmit.
I agree we should run them, but I don't think it is leading to us publishing under tested code, unless I am misunderstanding something?
Anyhow in the near future we do plan to move everything to prow and have the same tests run in postsubmit I believe


Manifest file strategy

As described in #13
Minor todos, not sure if you'd want them:

[ ] add setter methods to match current strategies a bit more closely
[ ] what about all the copyright/authorship stuff in the file docblock

@pjcdawkins Thanks for the PR! I'll review over the next week time allowing.
On your two questions:

I'd keep setter names as consistent as possible with existing API (where it makes sense).
Best practice is to include the license block at file head. Also, by all means include your name for author and copyright credit. I do not require copyright assignment, only a compatible license. If the code includes any pre-existing code, do include a line indicating the original source, author and copyright to ensure we abide by the terms of any prevailing license it may fall under, e.g. "Adapted from xxx ". It will also let me double check we're legal ;).

Apparently the review stage took longer than expected.

Ah yes... I also have extended this a bit where I'm using it (in the Platform.sh CLI), to add support for timeouts and for upgrade notes:
https://github.com/platformsh/platformsh-cli/blob/development/src/SelfUpdate/ManifestStrategy.php
I'll roll that into an update for this PR, if there is still interest.

I'll roll that into an update for this PR, if there is still interest.

👍

Sorry for the delay folks - my review times suck recently :grin: We'll work around to this much faster this time.

Note: Will complete a refresh PR over the weekend - we don't have write access back to the originating branch so will be a basic merge, resolve review pts, and check the additional work noted in comments.

@pjcdawkins I've updated this PR in #37 and it should be compatible with your final version. The API has been altered to prefer setters, and SHA1 has been moved to an optional downgrade from a SHA-256 default, but otherwise the overall internals are unchanged. If/When #37 is merged, this PR will be closed. Thanks again for opening this PR!


twitchConnection.NewAPI.Users.GetFollows throws error when retrieving large list of followers

Tried something like:
FollowersCount = (await twitchConnection.NewAPI.Users.GetFollows(null, Streamer.UserId, int.MaxValue)).Count();
Error:
System.ArgumentException: An item with the same key has already been added. Key: after
at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
at Twitch.Base.Services.NewAPI.NewTwitchAPIServiceBase.GetPagedDataResultAsync[T](String requestUri, Int32 maxResults)
at Twitch.Base.Services.NewAPI.UsersService.GetFollows(String fromID, String toID, Int32 maxResults)
Assuming Twitch API is duplicating accounts in the returned list.  Looking into the API it seems that the max number of followers that can be returned is 100.   I do see that the JSON response to the https://api.twitch.tv/helix/users/follows?to_id=<user ID> API includes a total field.
Maybe need to create a variation of the GetFollows method that only returns the count, or update the response object to include the total and then a dictionary of followers.

If you're intention is to simply get the follower count and not a list of follower, than that should be a separate method to be added.


Publish 5/19/2020 10:30 AM PT

close > reopen

Docs Build status updates of commit d45b3c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/failoverclusters/Set-ClusterLog.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d45b3c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/failoverclusters/Set-ClusterLog.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(packages/core): allow controllers to stream to stderr

This PR adds createErrorStream() to go alongside existing createOutputStream()
Fixes #7293

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm


[TSan] Deflake positive TSan+libdispatch test

TSan does not guarantee the detection of races [1].  This means that any
positive test, i.e., a test that asserts the detection of a race, comes
with inherent flakiness.  In the LLVM TSan test suite this unfortunate
circumstance is mitigated via the deflake utility [2] (plus lit
substitution) which executes a test multiple times.
Since we currently only have 3 positive TSan tests in the Swift test
suite [3] (the remaining ones test the absence of false positives), we
decided against bringing over this utility for now. Instead this change
attempts to "deflake" as part of the test itself.
[1] https://groups.google.com/d/msg/thread-sanitizer/KIok3F_b1oI/RwrMNhyHafwJ
[2] https://github.com/llvm/llvm-project/commit/233f401c2bf247d9764c3ca641513dafb623e00c
[3] Positive TSan tests:
test/Sanitizers/tsan.swift
test/Sanitizers/tsan-libdispatch.swift
validation-test/Sanitizers/tsan-inout.swift
rdar://51730684

@kubamracek  @delcypher
Please check my work and explanation.
@benlangmuir @gottesmm @jrose-apple
CC'd for awareness.

@swift-ci Please test


Support filters for Charts

In a new design, filters are a list of actions contained in a menu that is adjacent the overflow menu in a Dashboard Widget.
One filter can be active at a time. The developer changes the content of the Dashboard Widget when receiving an action payload fired when the user activates a non-active menu item.

I believe this was implemented in #111.


FAQ enhancing

In the FAQ section, the question and the answer are not on separate lines, which makes it visually unappealing. I want to separate the question and the answer to improve readability.

the design right now aligns well with the theme !


Unknown Platform Linux-armv6l (Raspberry pi zero) (IDFGH-11767)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3-dev-1157-g341a8f2d65
Operating System used.
Linux
How did you build your project?
Other (please specify in More Information)
If you are using Windows, please specify command line type.
None
What is the expected behavior?
Running ./install.sh esp32c3 should install all of the requirements and set up everything needed
What is the actual behavior?
But instead I get this error:
Traceback (most recent call last):
  File "/home/ziyad/esp/esp-idf/tools/idf_tools.py", line 207, in <module>
    CURRENT_PLATFORM = parse_platform_arg(PYTHON_PLATFORM)
  File "/home/ziyad/esp/esp-idf/tools/idf_tools.py", line 202, in parse_platform_arg
    fatal(f'unknown platform: {platform}')
NameError: name 'fatal' is not defined

After research and reading what is in this pull request Use Linux i386/AMD64 binaries on FreeBSD I think that this error is happening because the raspberry pi zero isn't supported.
Also I'm not sure why name 'fatal' is not defined that could be another bug.
Steps to reproduce.

Open a raspberry pi zero
Make sure it's platform and cpu is Linux-armv6l
Git Clone the esp-idf repository
cd into the esp-idf folder
run ./install.sh esp32-c3 (I think writing all instead of esp32-c3 will also give the same error)

Build or installation Logs.
$ ./install.sh esp32c3
    Detecting the Python interpreter
    Checking "python3" ...
    Python 3.9.2
    "python3" has been detected
    Checking Python compatibility
    Installing ESP-IDF tools
    Traceback (most recent call last):
      File "/home/ziyad/esp/esp-idf/tools/idf_tools.py", line 207, in <module>
        CURRENT_PLATFORM = parse_platform_arg(PYTHON_PLATFORM)
      File "/home/ziyad/esp/esp-idf/tools/idf_tools.py", line 202, in parse_platform_arg
        fatal(f'unknown platform: {platform}')
    NameError: name 'fatal' is not defined

More Information.
This is what I ran to know the system and machine:
$ python
Python 3.9.2 (default, Mar 12 2021, 04:06:34)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> print(platform.system() + '-' + platform.machine())
Linux-armv6l

Hi @ZXTube.
Yes, you are right about fatal() not working. We will fix it.
As regarding the Linux-armv6l support, could you please try to add the following line:
 'Linux-armv6l': PLATFORM_LINUX_ARM32,

at
https://github.com/espressif/esp-idf/blob/master/tools/idf_tools.py#L161C14-L161C14.
Please report back to us if the given hack is sufficient and everything works as should be after installing the tools.

I met same problem. I try adding line as @dobairoland mentioned, but the same error arise.
esp-idf/tools/idf_tools.py
PLATFORM_LINUX_ARM32: PLATFORM_LINUX_ARM32,
'arm-linux-gnueabi': PLATFORM_LINUX_ARM32,
'Linux-armv7l': PLATFORM_LINUX_ARM32,
'Linux-arm': PLATFORM_LINUX_ARM32,
'Linux-armv6l': PLATFORM_LINUX_ARM32,

Error
./install.sh
Detecting the Python interpreter
Checking "python3" ...
Python 3.11.2
"python3" has been detected
Checking Python compatibility
Installing ESP-IDF tools
Traceback (most recent call last):
  File "/home/rasp-find/esp/esp-idf/tools/idf_tools.py", line 208, in <module>
    CURRENT_PLATFORM = parse_platform_arg(PYTHON_PLATFORM)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rasp-find/esp/esp-idf/tools/idf_tools.py", line 203, in parse_platform_arg
    fatal(f'unknown platform: {platform}')
    ^^^^^
NameError: name 'fatal' is not defined

Additional information
Linux raspberrypi 6.1.0-rpi7-rpi-v6 #1 Raspbian 1:6.1.63-1+rpt1 (2023-11-24) armv6l
The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.
Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.


No HTML is rendered even when using the basic example

I'm trying to use the example and publish it with wrangler but it doesn't work, all it renders is an empty html page. Using vite dev works though

Hey Kyiro, I'm going to check it out. Thanks for the report.

I've updated the basic example, I guess now it works.
let me know.

Yeah, it works. Thank you for fixing it


flow restart command

Proposal
I would like to see a yarn flow restart command that runs yarn flow stop && yarn flow.

Use case
Sometimes when there is a single large write to the codebase such as flow-typed install or maybe git pull flow craps itself and doesn't recheck. A really simple way to fix this is to run yarn flow stop && yarn flow which is a stop and restart. It would be pretty great if I can just run yarn flow restart as a standard cli command so I don't need to configure every repo with npm scripts that does this for me because I manage multi repos

i'd selfishly like this too because during development I often switch between different binaries, and trying to use bash history but changing flow stop && flow start to flow-dev stop && flow-dev start is annoying :)
having to restart the server is bad though. I think we should add this command, but also try to understand the root cause any time someone needs to use it.

Just as a potential data point, by far the most common reason I stop flow is to free up system memory :stuck_out_tongue:

@mroch checking does this mean that this will be in your future todo that we can expect?


Implement RDM

Lots of work to be done here :)
Depends on #21
I personally don't have much experience with RDM. I do understand the concept and benefits. However, I don't have any real fixtures to test it, only the "Arduino RDM responder".

Lots of work to be done here :) Depends on #21

You don't need the hard bit of #21 in break detection for RDM, but you will need a lot of other input stuff.

I personally don't have much experience with RDM. I do understand the concept and benefits. However, I don't have any real fixtures to test it, only the "Arduino RDM responder".

The Arduino responder ( https://github.com/mathertel/DmxSerial2 ) should be fine, I've run the OLA tests against it and keep fixing issues. I can test with some proper gear too if I build myself a real version of this.

Cool :+1:
We should also re-check what parts of the JaRule-project can be re-used since that does RDM as well


SOV-2915: Fix token name in staking-related history tables

Resolves https://sovryn.atlassian.net/browse/SOV-2915

Will be merged in https://github.com/DistributedCollective/sovryn-dapp/pull/520


only calculate layer aggregated hash after block validity is determined

Motivation

Closes #2695

Changes

remove processed layer hash. this was used to as a cache of aggregated hash for the latest layer. now with GetAggregatedHash(layerID), this field is no longer needed
calculate layer hash and aggregated hash after tortoise validate a layer

Test Plan

unit tests
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

i ran a system late-node test and confirmed that these logs disappeared @dshulyak

bors merge


[VL] Minor follow-ups for #6942

Following #6942,

Remove prefix org/apache/gluten for library pathes in Jar
A test to assert on the runtime error message when Gluten build is used on unsupported platform.

@wForget

Related failures
VeloxListenerApiSuite:
- Unsupported arch *** FAILED ***
  Expected exception java.lang.RuntimeException to be thrown, but no exception was thrown (VeloxListenerApiSuite.scala:27)

- csv scan *** FAILED ***
  org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 730.0 failed 1 times, most recent failure: Lost task 0.0 in stage 730.0 (TID 540) (f98bd9d27030 executor driver): java.lang.IllegalStateException: error loading native libraries: java.io.FileNotFoundException: unknown-arch/libarrow_dataset_jni.so
	at org.apache.arrow.dataset.jni.JniLoader.load(JniLoader.java:95)


rename gitignore -> .gitignore in various examples

Is this a bug report?
Yes
Environment

react-static -v: @current
node -v: v8.2.1
npm -v: 5.6.0

Then, specify:

Operating system: Mac osx
Browser and version (if relevant): N/A

Steps to Reproduce

(Write your steps here:)

$ react-static create
fill out interactive prompts
cd <new-project>

Expected Behavior

I expected the gitignore files to be functional and properly named.
Actual Behavior

a few .gitignore files in the various /examples directory were without the preceeding . in their filename. i couldn't think of an actual reason for this so had to assume some of the examples were based off the same core files that had the mis-named .gitignore filename

This is intentional. When attempting to handle/copy/generate them into examples using react-static create, they would be ignored themselves or not copied. This is a common solution that is also used in CRA.

To be clear, when using react-static create the .gitignore file should be there and function as expected.

ah, I didn't realize. I had to abort the yarn install bc it seemed to hang. I didn't realize files would be renamed later in the process than that.
that said, in some /examples the file is already named .gitignore and when I just ran a test with   /examples/firebase-auth, i got this error:
Error: ENOENT: no such file or directory, stat '~/Sites/null/testproject/gitignore'

should I PR updates to make them all gitignore?

Yeah. Most of them should be already
On Wed, Feb 21, 2018 at 5:57 PM Kyle MacDonald<EMAIL_ADDRESS>wrote:

ah, I didn't realize. I had to abort the yarn install bc it seemed to
hang. I didn't realize files would be renamed later in the process than
that.
that said, in some /examples the file is already named .gitignore and
when I just ran a test with /examples/firebase-auth, i got this error:
Error: ENOENT: no such file or directory, stat '~/Sites/null/testproject/gitignore'
should I PR updates to make them all gitignore?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/pull/404#issuecomment-367531004,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCTX-1mZLkIAunCQfkXvSbYeK3B6Fks5tXLtigaJpZM4SOZDp
.


Refresh all VCR cassettes

What was the end-user problem that led to this PR?
The problem was our VCR cassettes contain responses recorded a long time ago, but the real APIs might have changed or give different results since then.
What was your diagnosis of the problem?
My diagnosis was that we should re-record the cassettes every once in a while.
What is your fix for the problem, implemented in this PR?
My fix removes old the previous cassettes and re-records them.
Why did you choose this fix out of the possible options?
I chose this fix because I'm not sure how to do it otherwise.

@bundlerbot r+


Invalid YAML in pvc annotations

Describe the bug
The YAML generated by Helm is invalid for pvc in the nginx-php-persistent template
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: nginx-php
  labels:
    helm.sh/chart: nginx-php-persistent-0.1.0
    app.kubernetes.io/name: nginx-php-persistent
    app.kubernetes.io/instance: nginx-php
    app.kubernetes.io/managed-by: Helm
    lagoon.sh/service: nginx-php
    lagoon.sh/service-type: nginx-php-persistent
    lagoon.sh/project: REDACTED
    lagoon.sh/environment: production
    lagoon.sh/environmentType: production
    lagoon.sh/buildType: branch
  annotations:
    lagoon.sh/version: "21.2.2"
    lagoon.sh/branch: "production"
  annotations:
    k8up.syn.tools/backup: "true"
spec:
  accessModes:
    - ReadWriteMany
  storageClassName: bulk
  resources:
    requests:
      storage: "20Gi"

Notice the double annotations key.
To Reproduce
Do a deploy, notice the the YAML is not valid.
Expected behavior
Valid YAML being generated by Helm

what's not valid on it? http://www.yamllint.com/ and https://codebeautify.org/yaml-validator both say it's valid yaml.
creating an object with it works:
❯ cat <<EOF | kubectl apply -f -
pipe heredoc> apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: nginx-php
  labels:
    helm.sh/chart: nginx-php-persistent-0.1.0
    app.kubernetes.io/name: nginx-php-persistent
    app.kubernetes.io/instance: nginx-php
    app.kubernetes.io/managed-by: Helm
    lagoon.sh/service: nginx-php
    lagoon.sh/service-type: nginx-php-persistent
    lagoon.sh/project: REDACTED
    lagoon.sh/environment: production
    lagoon.sh/environmentType: production
    lagoon.sh/buildType: branch
  annotations:
    lagoon.sh/version: "21.2.2"
    lagoon.sh/branch: "production"
  annotations:
    k8up.syn.tools/backup: "true"
spec:
  accessModes:
    - ReadWriteMany
  storageClassName: bulk
  resources:
    requests:
      storage: "20Gi"
EOF
persistentvolumeclaim/nginx-php created```

The linter you mentioned, says it is valid, but it also has changed the format of the result
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    k8up.syn.tools/backup: "true"
  labels:
    app.kubernetes.io/instance: nginx-php
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: nginx-php-persistent
    helm.sh/chart: nginx-php-persistent-0.1.0
    lagoon.sh/buildType: branch
    lagoon.sh/environment: production
    lagoon.sh/environmentType: production
    lagoon.sh/project: REDACTED
    lagoon.sh/service: nginx-php
    lagoon.sh/service-type: nginx-php-persistent
  name: nginx-php
spec:
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 20Gi
  storageClassName: bulk

Notice the single annotations key now? Perhaps it is ignoring one of the keys.
from the spec https://yaml.org/spec/1.2/spec.html

JSON's RFC4627 requires that mappings keys merely “SHOULD” be unique, while YAML insists they “MUST” be. Technically, YAML therefore complies with the JSON spec, choosing to treat duplicates as an error. In practice, since JSON is silent on the semantics of such duplicates, the only portable JSON files are those with unique keys, which are therefore valid YAML files.

what's not valid on it? http://www.yamllint.com/ and https://codebeautify.org/yaml-validator both say it's valid yaml.

I think those validators just aren't very good. yamllint says it's invalid:
$ yamllint /tmp/my.yaml
/tmp/my.yaml
  1:1       warning  missing document start "---"  (document-start)
  19:3      error    duplication of key "annotations" in mapping  (key-duplicates)

There's also this kubernetes bug, which seems to say that repeated keys will eventually warn: https://github.com/kubernetes/kubernetes/issues/14791

it's now a single block
    lagoon.sh/version: "22.12.1"
    lagoon.sh/branch: "test6"
    k8up.syn.tools/backup: "true"


False positive MD053 for image inside link

I'm seeing a false-positive when wrapping referenced image inside a link:
[![Binder]](test)

[Binder]: https://mybinder.org/badge_logo.svg

FYI, the equivalent syntax [![Binder][]](test) should not trigger a violation in the current version.

This is not in fixed in https://github.com/DavidAnson/vscode-markdownlint/tree/next yet, correct?

Right, it's fixed for the next release of the library which will be part of the next release of the extension. But neither exists yet.

Is anything blocking a new release? Still encountering this issue on a regular basis.

Nothing blocking, though I am still working through some other issues that have been reported.


[DI] Support definite initialization for composed property wrappers.

Emit the initialization of the backing storage of a wrapped property into its own SIL function, the "property wrapper backing initializer." This SIL function captures the complete initialization, which may involve multiple property wrapper types (when they are composed) and any default arguments for wrappedValue initializers.
Teach Definite Initialization (DI)'s formation of assign_by_wrapper instructions to refer to the property wrapper backing initializer rather than trying to partially apply the init(wrappedValue:) initializer. This is both cleaner and more general.

@swift-ci please smoke test

Hmm, I think I got the visibility of the property wrapper backing initializer wrong. We probably don't want to expose it for members of resilient structs, because you can't write an initializer that initializes the stored properties.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test source compatibility


Paging months/year causes the date select dropdown to close immediately when using FastClick

Selecting the next month or year using the datepicker on a web application using the FastClick js library (https://github.com/ftlabs/fastclick) for mobile devices causes the calendar selector to hide itself immediately.
This seems to be an issue with touchstart versus click listeners, as discussed here https://github.com/ftlabs/fastclick/issues/48 and here https://github.com/twbs/bootstrap/pull/6488.

do you still have this issue with v4?

This still fails on V4, it's currently unusable when using FastClick.
Adding the 'needsclick' class to all tappable elements should fix it.

I can't reproduce this in the current version.
Please provide a fiddle or a demo page exhibiting the issue

https://jsfiddle.net/bradpitcher/gLsqtzjs/2/
Open on mobile or enable "device mode" in chrome developer tools to witness the issue

I'm also having this problem when combining fastclick and https://github.com/smalot/bootstrap-datetimepicker.
Adding the 'needsclick' class to the form input element is not helping.  Tried adding that class to @brad's jsfiddle and it does not help there either.

Egg on my face, my issue is with an alternative datetime picker, sorry.

Same - adding needsclick class to all of the th/td elements is what is required for this to work with fastclick. This is specifically testing it on iPad.  It would be helpful to be able to add classes to clickable elements to get around this, or you can make a nasty hack like this:
if ('ontouchstart' in document.documentElement) {
  $('#datesAvailable').on("dp.update,dp.show", function(e) {
    $('#datesAvailable').find('th,td').addClass('needsclick');
  });
}

Im trying to use datetimepicker together with fastclick without success. I've tried your hack coxw but somehow when the layout changes (for example when switching between months) without calling update/show/change function, which in turns closes the popup the next click. Why is this issue closed when the issue seems to be unresolved?

This can be fix with touchstart. I'll do a PR


Bump provider version to 5.18 to fix non-empty plan for google_notebooks_instance

Bump provider version to 5.18, so fix non-empty plan for google_notebooks_instance

Checklist

I applicable, I acknowledge that I have:

[x] Read the contributing guide
[ ] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Successful E2E run


nhost config pull could use a "force" mode

I have nhost config pull in a startup script, but that action requires a user to confirm.

nhost/nhost.toml already exists. Do you want to overwrite it? [y/N]

It would be nice to add a -f force option to the CLI here.  I do not see it in the help.

That's a good, idea. Fixed by #791


[OTHER] Adding a Preview "How to use LinkFree with GitPod" in GIF format

What would you like to share?

Tutorial - How to use LinkFree with GitPod and view it in the browser.
Adding GIF below GitPod Button

Additional information
No response

I am working on this issue :)


v1.9.0 performance regression

Description
After upgrading to v1.9, I was able to observe a significant slowdown for the setTexture method. While I was creating a minimal reproduction demo for setTexture, I noticed that initial load performance also suffered a regression. I imagine this stems from the same issue.
Live Demo
https://codepen.io/citylights/pen/qBXRwvX
The Codepen above serves as a primitive way to measure load performance. Alternate between version 1.8.0 and 1.9.0 by changing the script tag at the top of the template.
Top left of the view shows the visible model count followed by the duration taken to load those models.
On my machine I am consistently measuring ~1500ms for v1.8 and ~10,000ms for v1.9 for 10 models.
Version

model-viewer: v1.9.0

Browser Affected

[x] Chrome, Win 10 Version 94.0.4606.81 (Official Build) (64-bit)
[ ] Edge
[x] Firefox
[ ] IE
[ ] Safari

OS

[ ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[x] Windows

AR

[ ] WebXR
[ ] SceneViewer
[ ] QuickLook

Reopening, since I  had to revert the fix since it was causing a bigger problem: #2949. A proper fix is  coming in three.js, but  it'll take our next release cycle to resolve.

Oh no :(
When will the next release cycle happen? It makes whole pages unusable :-/

@sprengerst you're welcome to pin to either v1.8 or v1.9.1 until our next release comes, e.g. <script type="module" src="https://unpkg.com/<EMAIL_ADDRESS>It's the  holidays, so it'll probably be after the new year.

@elalish Thank you. Holidays? What country do you live in, I think I should join you. :D


chore(localize): updated translation from Crowdin

:tada: This PR is included in version 2.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Question] How to use Yapf and other tools?

Some context: This is my first time using this template, and only my third-ish attempt to create a Python package.
My question is, what is the proper way to use tools like yapf and flake8 with a project made from this template? In setup.cfg, I see several settings for yapf and flake8, but I am not sure how the settings are used.
In a similar vein, would one add yapf and flake8 to the dependencies in setup.py, or would one add them to a development Conda environment, for instance devtools/conad-envs/dev.yml?
Thanks!

@Lnaden @janash @jaimergp

@btjanaka - you may find it helpful to review our Python Package Development workshop material, available at https://molssi-education.github.io/python-package-best-practices/
This material will walk through creating a package with the cookiecutter.
YAPF is discussed in the lesson on Python coding style (https://molssi-education.github.io/python-package-best-practices/05-function-style/index.html). If you wish to use yapf, you can install it into your environment using conda or pip. You run yapf on the command line (see lesson for example). When you run it, yapf will check the directory you are working in for local style settings. This is what is set in setup.cfg. YAPF will look at the format of the python file that you specify, and the information in setup.cfg, and format that file according to your settings.
You can see more on yapf usage on the yapf GitHub: https://github.com/google/yapf
In my opinion, you do not need to add it as a dependency as your package does not need it to run.
Comments by others also appreciated!

@janash Thanks! I do use yapf already (actually, I have a Vim plugin that runs it automatically), but I was not aware that yapf checks for a setup.cfg. This is good to know. Thank you for providing the links; I'll make sure to take a look.

yep! See this section of YAPF documentation (https://github.com/google/yapf#id7). There are four places YAPF looks for style settings. If none of these are set, it will default to pep8. The settings in the cookiecutter differ from pep8 mainly in that we set a 119 character column width and pep8 specifies a 79 character column width.


0.5.0 release

[fix] Fix crash when pending migrations check fails
[add] default_or_test function
[add] Added deep_merge_dicts function
[add] formatter: black<=19.10b0
[add] OPENWISP_API_INFO setting
[add][api] Require authentication for API docs if DEBUG is False
[add][api] Implement ScopedRateThrottle by default
[add][api] Introduced api.ApiAppConfig
[add][rest] optional swagger API endpoints
[add][rest] django-filter
[docs] Re-ordered, added information and improved existing docs
[update] Added support for flake8 flake8<=3.9
[change] Renamed test_api to api for consistency
[change] Rename openwisp-utils-qa-checks to openwisp-qa-check
[change][api] Renamed /api/v1/swagger/ to /api/v1/docs/
[improvement] Moved to importlib for Dependency loader & staticfiles for importing files
[improvement] Added "Related to #" for commit-check
[enchancement] Added strict mode to run-qa-checks

Signed-off-by: Ajay Tripathi<EMAIL_ADDRESS>

Coverage remained the same at 99.458% when pulling 51937691bb97098ca9ecee70a983cd9457e462fe on atb00ker:master into a13ce3e090b3fd32333f74928fcaa007c0f24388 on openwisp:master.

@nemesisdesign release required for releasing next version of network-topology as it has pip install --upgrade https://github.com/openwisp/openwisp-utils/tarball/master#egg=openwisp_utils[qa] in it's requirements.


Client transitions don't handle data request errors well

Repro:

Go to Page A
Click on a link to execute a client transition to Page B. Page B should make a data request that 500's
Attempt a client transition back to Page A

Result:
Get the following console error, and navigation fails:
error: [react-server.core.ClientController] onNavigate error Object {status: 404, message: "No Route!"}
Expected Result:
Transitioning away from a page that had a data request error should succeed
Note that this repros when bundleData is on or off

Whoa... that's not good.  Thanks for reporting @nampas.

Hi @nampas.  I'm having trouble reproducing this.
Please have a look at #197 and see if anything jumps out at you.

Hrm ok thanks for throwing that example together, I'll take a look and get back to you.

Ok, so it turns out that we had a RootElement that didn't resolve in the case of a data request failing. That made react-server think that page B never finished rendering (Navigator.finishRoute was never invoked). Then, when we tried to execute the transition back to page A, Navigator.startRoute wouldn't emit navigateStart because it was waiting for the current page load to finish.
Closing this ticket, but it might be worth adding a timeout for finishRoute()


Fix issue whereby when an incorrect command was entered, the buffer w…

…asn't cleared and the next command was appended on the end of the incorrect one

I did my own review comments!


Add in the BSD license.

Recently, there have been some questions raised on what license this repository is under.  While it is largely a set of configuration files for the various ROS distributions, there is also a bunch of code in here.  I think we should add a license to clarify the situation for this repository.
I've gone with the BSD license here as it is the most broad, there are already a couple of files in this repository that claim it, and it is compatible with both ROS 1 and ROS 2.  While adding in the top-level LICENSE file, I took the liberty of adding the BSD license clause header to the files that were written by current Open Robotics employees.  This included relicensing one file from Apache 2.0 to BSD, but that was written completely by @tfoote so it should be fine.
I did not add the license header to files that had one or more authors outside of Open Robotics.  I'm not sure whether we can add that header, or whether we need explicit permission from the outside authors.
@ros2/team I'm looking for opinions on whether this is a viable thing to do, and whether I've gone about it properly.
@chapulina FYI

All right, I think we've had broad agreement that this is OK to do here.  I'm going to go ahead and merge this.  Thanks everyone for the feedback.


VW - Instructions for Vetting Summary

Provide instructions for vetting summary so vetting agent knows that stuff written in that box will be seen by the Site Assessors - so they should provide helpful information for site assessors...
[Dan, if you want to provide actual verbage, feel free to do so here]

Text used;
Information provided here will be visible to Site Assessors, and should give useful context for when they visit the client's home.  (DO NOT provide private (e.g. specific health and/or financial) information.
Also for Site Assessment explanation:
Look for messages, if any, from Site Assessors in the area below.  Site Assessors have provided this to the Vetting Agents for potential follow-up with the client.


⚠ Samsung has degraded performance

In 02c7693, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2495 ms

Resolved: Samsung performance has improved in f79cddd.


Allow for function as child

Function as a child is a very powerful pattern employed in react.  It allows the consumer of a component to choose how to render a component, while having access to data passed down by the parent.
It is similar to slots, in a way, except slots only gain you access to the data in the hosting component.
For more information on the possibilities that this pattern enables, please see this blog post, this presentation from Ryan Florence at React Rally, as well as the new API for React Router 4.0.
Before I go on, I do want to say that the pattern is achievable right now using props:
It is possible now to mimic this using props with the following pattern:
const ComponentWithInfo = {
    props: ['render'],
    render (h) {
       return this.render('Hello, World');
    }
}

new Vue({
    render (h) {
         return <ComponentWithData render={data => {data}}></ComponentWithData>
    }
})

However, "first-class" support would be nice.
As far as the vue flavor, the API looks like this:
const ComponentWithInfo = {
    render (h) {
       return this.$slots.default('Hello, World')
    }
}

new Vue({
    render (h) {
         return <ComponentWithData>{data => {data}}</ComponentWithData>
    }
})

A couple of things:

In my implementation, if an array is passed for children, and any of the children are a function, that will throw away all children, except for the function
I understand that there is an API freeze, but this is not breaking any existing APIs, only adding on.
Please feel free to reject this specific PR, although if you do, I think this is worthwhile feature to consider.

I like the idea and thanks for the PR. One thing I'm not sure about is that this essentially makes this.$slots.default's type indeterministic - it can sometimes be an Array and sometimes be a function depending on how the component is used. This just doesn't feel right to me.
Maybe instead it could be just a separate thing like this.$slotFn - since this is basically a different usage pattern from pre-rendered slots anyway.

I have implemented this, complete with tests that actually tests things this time (sometimes we need tests for the tests...)
Not entirely happy about the implementation, but I'd like to here your thoughts.

+1 for this feature. It will enable users to write powerful component for abstracting UI pattern and manipulating data rendering.
My concern here is API consistency.

Double mustache is for interpolation in vue. Interpolating function is potentially confusing

Function as child only works well in render function. In template code, users cannot write code like  <ComponentWithData>{{ (data) => Hello {{data}}}}</ComponentWithData>
because vue does not translate expression.

Hard to specify to which slot the child function is passed. It is not ideal to pass multiple child functions and to distribute them by the order they are passed.

To my best knowledge, I guess @blocka is inspired by JSX expression. But the problem here is that JSX isn't the default template method.

My idea is introducing a new builtin component: template. A template component can declare new variable in its scope. It looks like Angular2's structural directive, sorry for that but I cannot come up with better API. It is compiled into a function that return vnodes. Allowing function for child is the common goal.
<component-with-data>
  <template let-data slot="mySlot">
     Hello {{data}}
  </template>
</component-with-data>

Compiled to render function
_h('component-with-data', _tpl('mySlot', function(data) {
  return _h('span', data);
}));

Because template is a tag, it works like other tags and would not introduce new behavior to interpolation.
It works in vue's template code. And for render function, users can just pass a function as default child function, or passing _tpl for named slot. For JSX usage in render function, content in template will be compiled to normal vnode rather than functions so users cannot use it. This is confusing for JSX users, indeed.
Adding a slot mark on template tag is easy. The slot name may need changed so it does not break $slot's type consistency.
Bike shedding is never enough for introducing an important feature like child function in vue. Looking forward to your feedback.

Not exactly why you consider this bike shedding. I'm using this in actual production code right now.
I am definitely biased towards JSX. I'm not going to deny that, and this feature would definitely line up with the "advanced" features. The render method itself is an "advanced" feature, so I'm not expecting anybody to want this feature with templates.
This PR assumes only one function will ever be used, and there is really no reason to have more then one. A function can always pass in more functions that can be used for "named" slots.
That said, the ultimate motivation behind this is the inflexibility of slots. Perhaps we can just modify slots they always functions, and we can pass them properties.
// Child

  {{data_passed_in}}

// Parent
<template>
<slot name="myslot" :data_passed_in="Hello, World"></slot>
</template>

Which would compile to
render (h) {
    return this.$slots.myslot({data_passed_in: "Hello, World"})
}

My two problems with this are the injected variables are not explicit, and, of course, would break the current APIs.

Hey, just a note I'm not leaving this hanging - will probably be part of 2.1 along with a template slot equivalent, thanks for the patience!


Examples with joins

It would be great to see how to do basic joins in examples.

My bad, I found them on http://hexdocs.pm/ecto/


Deadlocks with nested Subscriber

Can I "nest" subscribers?
Let's say I have this application, with a "main" subscriber, always listening; and in the receiver I create a new subscriber (for another subscription), with an awaitTerminated with a timeout.
Not always, but some times the application remain "stuck"; when this happen it's in the  awaitTerminated.
is there a way to debug this problem?
BTW: it's more common to get stuck if I run the code on kubernets than on my developer pc...

Thanks for posting this issue. I had a quick look yesterday and was able to recreate using below code.
I believe you also observed the innerMessageReceiver continue to live on even after specified time is passed (childSubs.awaitTerminated(2, TimeUnit.MINUTES);). Unfortunately, I would not be able to take a look at it now. Adding my findings on this thread.
public class TestListener {

  private static final Logger LOG = Logger.getLogger(TestListener.class.getName());
  private static final String PROJECT_ID = ServiceOptions.getDefaultProjectId();

  private static final List<MessageReceiver> childMessageReceiver = new ArrayList<>();

  private static final String SUBS_1 = "test_pubsub_sample";
  private static final String SUBS_2 = "test_pubsub_sample_2";

  static class OuterMessageReceiver implements MessageReceiver {

    @Override
    public void receiveMessage(PubsubMessage message, AckReplyConsumer consumer) {
      String messageData = message.getData().toStringUtf8();
      LOG.info("OUTER SUBS=> Message Id: " + message.getMessageId() + " Data: " + messageData);
      consumer.ack();

      if (messageData.startsWith("START_INNER_LISTENER")) { // Listener for another Subscription
        ProjectSubscriptionName subscription2 = ProjectSubscriptionName.of(PROJECT_ID, SUBS_2);
        try {

          MessageReceiver messageReceiver = new InnerMessageReceiver();
          childMessageReceiver.add(messageReceiver);

          Subscriber childSubs = Subscriber.newBuilder(subscription2, messageReceiver).build();
          childSubs.startAsync().awaitRunning();

          // This should stop the subscriber after 2 mins but it is continue to live on.
          childSubs.awaitTerminated(2, TimeUnit.MINUTES);

        } catch (TimeoutException e) {
          throw new IllegalStateException("Exception occurred while closing the inner subscriber");
        }
      }
    }
  }

  static class InnerMessageReceiver implements MessageReceiver {

    @Override
    public void receiveMessage(PubsubMessage message, AckReplyConsumer ackReplyConsumer) {
      LOG.info(
          "INNER_SUBS=> Message Id: "
              + message.getMessageId()
              + " Data: "
              + message.getData().toStringUtf8());
      ackReplyConsumer.ack();
    }
  }

  public static void main(String[] args) throws Exception {
    ProjectSubscriptionName subscriptionName = ProjectSubscriptionName.of(PROJECT_ID, SUBS_1);
    try {
      Subscriber outerSubscriber =
          Subscriber.newBuilder(subscriptionName, new OuterMessageReceiver()).build();
      outerSubscriber.startAsync().awaitRunning();

      outerSubscriber.awaitTerminated();
    } catch (IllegalStateException e) {
      LOG.log(Level.SEVERE, "Subscriber unexpectedly stopped: ", e);
    }
  }
}


[Feedback] node-sass

Hi,
I try to find an open source editor with sass.
It's work with this cmd npm install node-sass -g ; now it's OK :)
(on Mac OS Sierra)

Great to hear ;) Thanks!


Please provide parts for combining emojis

Thanks for giving us these emoji. I'm so love them that I want to make something to bring them to the web for all platforms, like Twemoji.
I've done quite a lot, and the next thing I need to do is supporting combining emojis (I have a way to combine parts) , so I need parts.
I know you're trying to bring out intact combining emojis, but while you do it, just provide their parts first.
Thanks!

By the way, if I use those emojis which are not included in this repository (for item mentioned above), is this a copyright violation?

Well, I just want to use parts, and if there aren't parts, can I extract parts from Segoe UI Emoji?

We'll look at the issue with the parts and try to resolve that. Regarding copyright, the intent is that you can use these assets as you'd like, like code that is released under MIT license. We are trying to get licensing evaluated per other requests about CC vs MIT and will address that as soon as we can.

What's the next for this? Will you provide parts first, or just bring out all full variants?

The current intent would be to provide parts

Great! I'll wait for them~😋

@jasoncuster @spencer-nelson any updates?
It would be incredibly helpful, if you would provide the script to build the actual font.
Some of us did not want this change, and have been trying on our own to revert the change, or switch to emoji we can read - having the source code to build the proper font would be extremely helpful, so we can fork it and make changes.
 That's what this feels like. I'm obviously making a somewhat hyperbolic comparison here, but only barely. Emoji have become an essential part of our day to day visual language. I can't make any sense of these new emoji. Even if I could switch my Android phone to use them, I'm not sure I could get used to them. I also just don't personally like them. It doesn't feel like these were designed for adults.
I realize that's just my personal experience - but that's the point: how you experience this change is personal, and for a lot of us, this isn't a helpful or welcome change.
And I understand it's not a priority for you to maintain the old set of emoji, or provide options - but then, please, provide us with the source code to build the font, and dump the old emoji in a repository, so we can go and fix this on our own.
Please. 🙏

as of the latest Windows update, replacing the emoji font now appears to be impossible.

is Microsoft now actively preventing the replacement of the font? wtf 😥


Integration test framework  allowing kafka to be run in-VM and within containers.

This is work towards #83.
This proposed change introduces a test API ClusterFactory that allows an integration test to provision a kafka cluster tailored to its needs.

number of brokers in the cluster
kraft/in-VM
SASL authentication

By default the provided cluster runs "in VM", meaning kafka (and zookeeper if required) run within the same VM as the test giving the fastest developer experience.  There is also a "container mode" that means those dependencies are run within containers (uses native images).  The intent is tests are written to be agnostic.
What's currently missing:

Support for running different kafka versions (this will only be supported by container mode)
Support for TLS

I also took the opportunity to refactor out the integration tests into their own module.

@tombentley @robobario @SamBarker @showuon  thanks for all the great feedback!  the biggest change is the incorporation the use of native kafka/zookeeper (and the elimination of bitnami).  Hopefully this is approaching mergeable! Please re-review.


Protobuffers

Hi, is there a way to get this to work with protobuf?

Sure ... I will take a look and publish here my research. :muscle:

Hi @repejota,
I did a bit of experimenting myself using https://github.com/skrz/meta and I can seem to send messages, but the response bodies seem to get lost.
When I send data as json it works fine, but when I switch to protobuf, only requests from php-nats work, reply bodies are empty.

Printing in the receive function I get the following:
INFO {"server_id":"ff331bd33f1fda7518cf2822ca9446b2","version":"0.7.2","go":"go1.5.2","host":"<IP_ADDRESS>","port":4222,"auth_required":false,"ssl_required":false,"tls_required":false,"tls_verify":false,"max_payload":1048576}

PONG

MSG _INBOX.572747b760a34 572747b760a72 89

So that would indicate that the message I should be receiving is length 89 right?

https://github.com/repejota/phpnats/pull/46
Any pointers on how to best test this?


[m1] [ti] textual inversion embedding loaded but doesn't work

GPU: M1
CPU arch: arm
OS: MacOS
Python: miniconda
Branch: development / release-candidate-2
Commit: [b296933] / [3d7bc07]
ugly-sonic.bin loaded:
>> Model loaded in 10.24s
Added terms: *, <ugly-sonic>
>> Setting Sampler to k_lms
then:
dream> photo of <ugly-sonic>
produces:
RuntimeError: Tensors must have same number of dimensions: got 2 and 1
>> Could not generate image.
OR:
dream> photo of *
produces: photo of random guy.
the same for other models or styles from hugging face. bin size is correct.

It works for me.
photo of <ugly-sonic>

ok @Any-Winter-4079  i will start from scratch. Testing right now...

CLI

@ppogorze does it work?
uglysonic.bin.zip

@Any-Winter-4079 same sh...

when I use web ui and type: photo of  = stuck on preparing...
cli = RuntimeError: Tensors must have same number of dimensions: got 2 and 1 >> Could not generate image.
 Is it working?

Oh, I just downloaded it from the website, suggested from someone here! Never knew it was not the ugly version.
If you point me to the url with your ugly sonic I can test it

@Any-Winter-4079 this will be more obvious:
[https://huggingface.co/sd-concepts-library/cat-toy]

@ppogorze Sorry, long day. I did it so fast I forgot to load the embedding lol.
Yes, you are right.
In my bin it runs without error, but the output is not correct.

This functionality worked here https://github.com/invoke-ai/InvokeAI/issues/513#issuecomment-1244850160

Update: The embedding seems to work, because if I use the same seed from above without the embedding
"a photo of <ugly-sonic>" -s 50 -S<PHONE_NUMBER> -W 512 -H 512 -C 7.5 -A k_lms
I get the real sonic

and not ugly sonic

@lstein But there seems to be an error running a command with the embedding loaded.
new_embed_row = torch.cat(
RuntimeError: Tensors must have same number of dimensions: got 2 and 1

@ppogorze try setting num_vectors_per_token: 1 in v1-inference.yaml
The behavior looked super weird, but I guess depending on the prompt (whether it detects e.g. <cat-toy> or *) it goes one route or another in embedding_manager.py and when using those concepts, it failed because num vectors did not match.

So the first fix seems to be num_vectors_per_token: 1 in v1-inference.yaml
This seems to work.

A second fix may be necessary, to get * to work.

Thank you guys, testing...

Works.
cat-toy

vs

@lstein please include the fix in the release. Otherwise embeddings won't work on main.

M1 Mac, 32GB
I looks like fix broke it for me.
"a painting of a * as batmans joker" -s 50 -S<PHONE_NUMBER> -W 512 -H 512 -C 7.5 -A k_lms
where * is my photo
produces random guy
When reverted num_vectors_per_token to 6 here am I again

Yes, the file should be manually edited depending on the num_vectors_per_token the concept was trained on. We changed back to 1 because it's more of a default value, but if you used 6 to train, you have to update to 6.

interesting thing is, that I have trained on 1, but it is not working until I change it here to 6


[WIP] Add multitenancy to admin

This PR attempts to solve #1 to an extent. As of now, all the fields in the admin seem to be fine. Just need to check the multitenant features now.

Coverage increased (+2.9%) to 75.177% when pulling a1d277bcc1ac7d370908ce60e5a7c4d7cef70455 on multitenant-admin into f84e7e210a3cea88ea6fba4cb6cbbd8b4c521f26 on master.

@rohithasrk great!
Proceed by adding a test_admin.py file with the tests for the main cases.

Coverage increased (+2.9%) to 75.177% when pulling 5db171f3c6a2a28d0a9c4b9174b92d212b477812 on multitenant-admin into f84e7e210a3cea88ea6fba4cb6cbbd8b4c521f26 on master.

Coverage increased (+2.9%) to 75.177% when pulling 1d52fd5eb63b7d8ef75715598d9690275068333e on multitenant-admin into f84e7e210a3cea88ea6fba4cb6cbbd8b4c521f26 on master.

Coverage increased (+22.2%) to 94.483% when pulling 89f85746fe34a993cdcd5b8409359adfcf996422 on multitenant-admin into f84e7e210a3cea88ea6fba4cb6cbbd8b4c521f26 on master.

Coverage increased (+24.1%) to 96.403% when pulling edb8728678da71b250684fd88da03e98bf522bd5 on multitenant-admin into f84e7e210a3cea88ea6fba4cb6cbbd8b4c521f26 on master.

Coverage increased (+24.1%) to 96.403% when pulling 31e5a556ce4e52beb43896ba0973d71e158a4d1f on multitenant-admin into f84e7e210a3cea88ea6fba4cb6cbbd8b4c521f26 on master.

Thank you @nemesisdesign. I'm on it :smile:


Input type file support

Hi,
Thanks for the great formbuilder plugin.
We have cloned the plugin and tried using it. One thing I came across is that the input type "file" ("field_type": "file",) is not working in our end. Can you please advice us on the same?
Thanks,
Lekshmi

Hello did anyone figure out this?


BucketSinging error in ritualEngine

See dspeyer/ritualEngine#113.

Has this been seen again since 5 days ago? Does it get seen often?
I added some more checks in various places to try to nail it down, but so far I haven't heard anybody mention hitting any of them (or mention hitting this again, but I could imagine maybe people are ignoring it or something -- please do let me know if you hit it, this is a "should never happen").

I don't think this is happening anymore


Access raw depth value for threshold

Required Info

Camera Model
D415

Firmware Version
Latest

Operating System & Version
Win10

Platform
PC

Language
C++

Issue Description
I can successfully get the color and depth images. However, I would like to access the raw depth value for threshold out the background object, and I don't know how can I do it.
I'm thinking of something like:
//Pseudocode********
Get depth image from realsense sdk
Mat thresResult(Size(depth.cols, depth.rows), CV_8UC1);
for(int i = 0; i < depth.rows; i++)
for(int j = 0; j < depth.cols; j++)
if( depth[i][j] > userDefinedValue && depth[userDefindedValue] < userDefinedValue2 )
thresResult[i][j] = 255;
else
thresResult[i][j] = 0;
I've read from somewhere that get distance for each pixel like this is expensive, is there any to access the raw depth data, then do the threshold directly? Thanks.

@MartyG-RealSense Thanks for the swift reply even during weekends.  The third link looks like exactly what I want, I will look into it! Much appreciated.

@MartyG-RealSense I've modified the remove_background() function a little from the third link you posted to simply threshold out foreground and background in black(0) and white(255) (Store the foreground/background in Mat from OpenCV).  Please take a look at the code in the following:

As you can observe, the result shown in bw window look weird. To me it looks like there's a indexing error, but the code looks good to me.  Can you please take a look at it? Thanks.

@MartyG-RealSense opencv and realsense sdk are both rows major, so the situation is a bit different.  But I might know where the issue might be. But I've some question regarding functions of rs2::colorizer and the depth data acquired from rs2::frameset data = feed.wait_for_frames(); data = align.process(data); rs2::depth_frame depth = data.get_depth_frame();.
I used colorizer to colorize the depth from colorizer(data.get_depth_frame()) then copy the data to Mat.  If not colorized the depth data, is the depth data contain 1-channel depth info or 3?  If depth data is 1-channel data, does colorizer map depth data to 3-channel for showing colors?
The earilier image I posted is the result that remove_background() took depth data after colorizering.  However, if I removed the colorizering process, the result still has the mirroring effect.

@MartyG-RealSense opencv and realsense sdk are both rows major, so the situation is a bit different. But I might know where the issue might be. But I've some question regarding functions of rs2::colorizer and the depth data acquired from rs2::frameset data = feed.wait_for_frames(); data = align.process(data); rs2::depth_frame depth = data.get_depth_frame();.
I used colorizer to colorize the depth from colorizer(data.get_depth_frame()) then copy the data to Mat. If not colorized the depth data, is the depth data contain 1-channel depth info or 3? If depth data is 1-channel data, does colorizer map depth data to 3-channel for showing colors?
The earilier image I posted is the result that remove_background() took depth data after colorizering. However, if I removed the colorizering process, the result still has the mirroring effect.

Colorizer questions go outside of my programming knowledge, so I will have to let the Intel guys answer that one.  Sorry, and good luck!

[Realsense Customer Engineering Team Comment]
The raw depth is 1 channel 16 bits image(Z16).
The colorized image is 24-bits image(RGB8).
My question is how to display "bw" onto the window in your code?
It seems, there is a 24-bit image is shown as a 16-bit image, in the bw window.
the function remove_background looks good.


Staffing logic improvements

This PR does four things around staffing in StaffBot:

A more efficient JOIN query in one of the staffing implementations
Allows us to disable StaffBot inquiries for Workers who would otherwise be certified for a task using staffbot_enabled
Allows us to priorities workers who receive StaffBot inquiries via staffing_priority
Adds settings.ORCHESTRA_ENFORCE_NO_NEW_TASKS_DURING_REVIEW to toggle whether workers are eligible for more work if they currently have work returned from a reviewer.

Coverage increased (+0.01%) to 91.499% when pulling ad9c3470ee528eae158dbaeda6b847dd3cb05586 on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage increased (+0.01%) to 91.499% when pulling ad9c3470ee528eae158dbaeda6b847dd3cb05586 on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage increased (+0.01%) to 91.499% when pulling 2018bb00d7718622bfce9320e00f9ddf36355609 on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage decreased (-42.5%) to 48.942% when pulling d574c443ce5b41236dfbe19b7f88ab508807ce1e on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage increased (+0.01%) to 91.501% when pulling d574c443ce5b41236dfbe19b7f88ab508807ce1e on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage increased (+0.01%) to 91.501% when pulling b82c79519329eff3c955d4cd720935e4be0fe4a1 on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage increased (+0.01%) to 91.499% when pulling b82c79519329eff3c955d4cd720935e4be0fe4a1 on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

Coverage increased (+0.01%) to 91.499% when pulling a616e933ff8eda6f19269c741774e356b7aff306 on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.

lgtm! So we'll manually toggle the staffbot enabled bool on workers? Maybe add a line to the docs about this and the priorities?

Yup that's right!  Just pushed docs

lgtm yallah

Coverage increased (+0.01%) to 91.499% when pulling d8f27aa592866388d01720014a44a301917dfcfd on certification-priorities into 1e41e67449c7556d087fffd4ec81e51eea45595e on master.


Terminal closes sometimes when re-opening VSCode despite terminal.integrated.persistentSessionReviveProcess

Does this issue occur when all extensions are disabled?: Yes/No

VS Code version: Code 1.88.0 (https://github.com/microsoft/vscode/commit/5c3e652f63e798a5ac2f31ffd0d863669328dc4c, 2024-04-03T13:26:18.741Z)
OS version: Windows_NT x64 10.0.17763
attempt to re-open https://github.com/microsoft/vscode/issues/210019 as it was closed without being solved
the property was already set to "OnExit", now i event set it to "OnExitOrWindowClose", but still - a lot of times when I restart this, the console is not being restored but only the task that gets run.
could it maybe be that there's a conflict between the terminal restoration and the scheduled task?

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.88.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

re-checked with 1.88.1 - issue persisting.

A gif reproducing the problem would help to narrow this down.

not a gif but i made a video with nvidia, this should show what issue i have
https://drive.google.com/file/d/1HYY14-sW6j47dzeUVS8PL72xSYSoMpz2/view?usp=sharing

in order for a terminal to persist, there has to have been input / interaction. try typing in that terminal and you'll see it persist

man you really need to stop closing issues without any feedback, i don't want to open the same bug x times because closed bug get no feedback...


[Suggestion] It would be better to change the "resource" to "Resource" in the input box

OS: All
Build Version: 20231007.1
Regression: Not a regression
Repro steps:

F1 -> Click "Cosmos DB: Delete Document...".
Check the tip in the input box.

Actual:
Show "Select resource" tip in the input box.

Suggestion:
It would be better to change the "resource" to "Resource" in the input box. Like below:

More Info:
This issue also reproduces when more than one subscription is selected.

I personally prefer the non-branded resource names to be lower-case.  I do agree that we should be consistent about this though

The string is pulled from the childTypeLabel of the database node's AzExtTreeItem object by the utils package. Since this is a minor issue and changing the value of childTypeLabel may carry unknown impact, let's not worry about this string for now.


No suggestion for null keyword in statement level or module level

Description:
$title

@rdulmina what's the exact use-case for that? We do not suggest the null keyword at these contexts since simply having null is not a valid expression. We suggest new since we can start writing something like new http:getHeaders() and then use the code actions to generate variables.

@rdulmina what's the exact use-case for that? We do not suggest the null keyword at these contexts since simply having null is not a valid expression. We suggest new since we can start writing something like new http:getHeaders() and then use the code actions to generate variables.

I was trying to write var declaration statement with nil type ie null a = null;

@rdulmina what's the exact use-case for that? We do not suggest the null keyword at these contexts since simply having null is not a valid expression. We suggest new since we can start writing something like new http:getHeaders() and then use the code actions to generate variables.

I was trying to write var declaration statement with nil type ie null a = null;

That makes sense. We will look in to this @rdulmina


Can't deploy updated deployment package for Lambda with ACK

Describe the bug
I have created a lambda fuction with ACK. I am using a file from s3 to deploy lambda.
Now, I have a new deployment package and want ack to deploy the new package. Unfortunately, ack is giving me following error.
This resource already exists but is not managed by ACK. To bring the resource under ACK management, you should explicitly adopt the resource by creating a services.k8s.aws/AdoptedResource

Steps to reproduce
Create deployment package and upload it to s3
Create a lambda fuction with ACK with newly updated deployment package to s3
Make any code change, package it and upload it to s3 with a seperate name
Update yaml with new deployment package name
Deploy changes
Expected outcome
It should update lambda package
Environment

Kubernetes version
1.23
Using EKS (yes/no), if so version?
EKS 1.23
AWS service targeted (S3, RDS, etc.)
Lambda

Hey @A-Hilaly
I have created a helm chart with following yam.
apiVersion: lambda.services.k8s.aws/v1alpha1
kind: Function
metadata:
  name: {{ .Values.function_name }}
  namespace: {{ .Values.namespace }}
  annotations:
    services.k8s.aws/region: {{ .Values.aws_region }}
spec:
  name: {{ .Values.function_name }}
  code:
    s3Bucket:  {{ .Values.artifact_bucket }}
    s3Key: {{ .Values.function_name }}/{{ .Values.artifact_tag }}
  role: {{ .Values.iam_role }}
  runtime: {{ .Values.runtime }}
  memorySize: {{ .Values.memory }}
  timeout: {{ .Values.timeout }}
  handler: {{ .Values.handler }}
  description: {{ .Values.function_name }} created by ACK lambda-controller
  environment:
    variables:
      {{- range $key, $val := .Values.env_vars }}
        {{ $key }} : {{ $val | quote }}
      {{- end }}
  vpcConfig:
    securityGroupIDs:
      - {{ .Values.security_group_id }}
    subnetIDs:
      {{- range .Values.subnet_ids }}
        - {{ . | quote }}
      {{- end }}

Next i have created a argocd pipeline. To deploy this helm chart. I supply all the helm values from a seperate (deployment) git repo.
I was able to successfully create lambda with this approch. The problem is, when I update the value of artifact_tag in deployment git repo, argocd syncs it but the updated package doesn't get deployed.

This resource already exists but is not managed by ACK.
I deleted and recreated the lambda, the issue was resolved however, i am still enable to deploy updated package with ack-lambda with mentioned approch.

Same here. It seems like the lambda's code is getting updated just once when the function was created. BTW the environment variables of lambda are updated when you update the function manifest.
Of course, you can delete and then recreate the function resource, so the lambda's code will be updated according to the function manifest. However, that does not suit for GitOps approach.

/assign

Closing this issue as the PR to support updating deployment package for Lambda functions in ACK is merged.

/close


test-basic: Draw Polygon: extra segment sometimes gets created

It looks like the code is getting confused with how to handle overlapping 'circles'.

Reinetgrate


Turn NodeId into a newtype, refactor findTopShape

Fixes #1002.

I just re-checked that the the inspection dialog still works!
So this should be good to go unless you have any suggestions on my comments above or any other concerns.


[camera package]: Updating the camera plugin for ios 17

With the introduction of IOS 17 the camera apis for ios have changed quite a bit. One of the introductions is external webcam support for iPadOS. It would be great if the camera plugin could support this out of the box.

It looks like this would require passing AVCaptureDeviceTypeExternal to the discovery session. It's unclear if that will impact any of the rest of the plugin code, or it's just that.

I did some initial testing and found that passing AVCaptureDeviceTypeExternal does infact allow the camera to be detected and see a preview  using CameraPreview, however, take picture does not work. I have not tested with taking video or any of the other features.
The WWDC session on this could be helpful in implementing this https://developer.apple.com/videos/play/wwdc2023/10106/
Unfortunatly running flutter apps on IOS 17 is broken and only allows running from xcode and attaching flutter so its cumbersome to develop and test on. Fixing that and then adding this would be really great.


[BLOG] Monitoring Apache Spark using opensearch

Describe the blog post your would like to write
Opensearch can be an ideal choice for continuous monitoring of apache spark jobs in production.
This year , we released the Guidance for Analytics Observability on AWS  reference solution , which enhances Any spark ditro (OSS, Glue , EMR)  with a plugin JAR that outputs various spark metrics to Opensearch via Data Prepper. This solution also provides multiple operational dashboards for apache spark for root causing common issues like Data  Skew , and also provides a Vega visualization for historical Spark-SQL plans as a Graph.
The blog will also demonstrate how opensearch anomaly detection features can further enhance the spark monitoring capabilities.
What is the title of the blog post?
Monitoring Apache Spark using opensearch
Who are the authors?
Avichay Marciano, Vincent Gromakowsky
What is the proposed posting date?
September 1st

Thank for the blog idea. When you are ready, please feel free to load a draft of the blog here or send me a copy to<EMAIL_ADDRESS>

@avichaym - Following up to see if you still intend to write and contribute this blog, or if we are able to close this issue? Please advise.

@avichaym - Moving this into backlog and awaiting input from the the author about whether they plan to m0ve this forward.


ExecutionInfo doesn't work

@nulls this does not work. Looks like it is the one of the reasons why we don't see logs for INTERNAL_ERROR
I fixed debug info, but this part with execution info was lost while we were migrating to S3.

Originally posted by @akuleshov7 in https://github.com/saveourtool/save-cloud/pull/2635#discussion_r1341720749

Cannot reproduce


[Better CI] Add code coverage and push to codecov.io

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6570cdb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #36   +/-   ##
========================================
  Coverage          ?   91.7%
========================================
  Files             ?       2
  Lines             ?     398
  Branches          ?       0
========================================
  Hits              ?     365
  Misses            ?      33
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6570cdb...e03040f. Read the comment docs.


Bad body serialization creating a Schedule Trigger in Data Factory

Package Name: azure-mgmt-datafactory
Package Version: 1.1.0
Operating System: Windows
Python Version: 3.8

Describe the bug
Using the library to create a Data Factory trigger, calling DataFactoryManagementClient.triggers.create_or_update method is not serializing the request body correctly
Serialized example:
{
    "type": "ScheduleTrigger",
    "description": "My scheduler trigger",
    "pipelines": [
        {
            "pipelineReference": {
                "type": "PipelineReference",
                "referenceName": "PL_ADW_IMPORT_MASTER"
            },
            "parameters": {
                "datacenter_name": "datacenter1",
                "schedule_name": "schedule1"
            }
        }
    ],
    "typeProperties": {
        "recurrence": {
            "frequency": "Minute",
            "interval": 15,
            "startTime": "2022-12-12T04:00:00.000Z",
            "endTime": "2022-12-12T05:00:00.000Z",
            "timeZone": "UTC"
        }
    }
}

The correct serealized body is:
{
    "properties": {
        "type": "ScheduleTrigger",
        "description": "My scheduler trigger",
        "pipelines": [
            {
                "pipelineReference": {
                    "type": "PipelineReference",
                    "referenceName": "PL_ADW_IMPORT_MASTER"
                },
                "parameters": {
                    "datacenter_name": "datacenter1",
                    "schedule_name": "schedule1"
                }
            }
        ],
        "typeProperties": {
            "recurrence": {
                "frequency": "Minute",
                "interval": 15,
                "startTime": "2022-12-12T04:00:00.000Z",
                "endTime": "2022-12-12T05:00:00.000Z",
                "timeZone": "UTC"
            }
        }
    }
}

To Reproduce
Steps to reproduce the behavior:
from azure.identity import DefaultAzureCredential
from azure.mgmt.resource import ResourceManagementClient
from azure.mgmt.datafactory import DataFactoryManagementClient
from azure.mgmt.datafactory.models import *

def main():
    credential = DefaultAzureCredential()
    adf_client = DataFactoryManagementClient(credential, 'AAAAA-VVVV-SWESDDS-XCV3-3bb145207'

    # Create a trigger
    rg_name = 'EUNPADWCANRSG01'
    df_name = 'EUNPADWCANDFA01'
    tr_name = 'mytrigger'
    scheduler_recurrence = ScheduleTriggerRecurrence(frequency='Minute', interval='15',start_time='2022-12-12T04:00:00Z', end_time='2022-12-12T05:00:00Z', time_zone='UTC')
    pipeline_parameters = {'datacenter_name':'datacenter1', 'schedule_name':'schedule1'}
    pipelines_to_run = []
    pipeline_reference = PipelineReference(reference_name='PL_ADW_IMPORT_MASTER')
    pipelines_to_run.append(TriggerPipelineReference(pipeline_reference=pipeline_reference, parameters=pipeline_parameters))
    tr_properties = ScheduleTrigger(description='My scheduler trigger', pipelines = pipelines_to_run, recurrence=scheduler_recurrence)
    adf_client.triggers.create_or_update(rg_name, df_name, tr_name, tr_properties)

    # Start the trigger
    adf_client.triggers.start(rg_name, df_name, tr_name)

if __name__ == "__main__":
    main()

Expected behavior
Running this code,
\azure\mgmt\datafactory\operations_triggers_operations.py  trigger an Exception because the response status code is 400
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@csotomon Thanks for your report! Directing this to the right people.

According to https://github.com/Azure/azure-sdk-for-python/blob/7c4cfe236d113c59e66515b6315def256219aa6b/sdk/datafactory/azure-mgmt-datafactory/azure/mgmt/datafactory/operations/_triggers_operations.py#L192-L200,
You should use 'TriggerResource' instead of 'ScheduleTrigger'.

According to
https://github.com/Azure/azure-sdk-for-python/blob/7c4cfe236d113c59e66515b6315def256219aa6b/sdk/datafactory/azure-mgmt-datafactory/azure/mgmt/datafactory/operations/_triggers_operations.py#L192-L200
,
You should use 'TriggerResource' instead of 'ScheduleTrigger'.

I am following the example in https://docs.microsoft.com/en-us/azure/data-factory/how-to-create-schedule-trigger#python-sdk. That example creas an object from ScheduleTrigger class. What’s the correct way?

according to the python package code, it should be  tr_properties = TriggerResource(description='My scheduler trigger', pipelines = pipelines_to_run, recurrence=scheduler_recurrence) instead of tr_properties = ScheduleTrigger(description='My scheduler trigger', pipelines = pipelines_to_run, recurrence=scheduler_recurrence)

I think that you should update the Documentation or fix the code

Using TriggerResource class instead of ScheduleTrigger, i got this error
tr_properties = TriggerResource( TypeError: __init__() missing 1 required keyword-only argument: 'properties'

@lrtoyou1223 Looks like the document for trigger in Python doesn't work as expected, could you please help have a look at this? Thanks!
@csotomon  We will check this and update here later, thanks for your patience.

@chez-charlie could you please help on this? It's about creating trigger using python SDK following the doc below, thanks!
https://docs.microsoft.com/en-us/azure/data-factory/how-to-create-schedule-trigger#python-sdk
@csotomon I tagged the wrong owner before, sorry for that.

@shawnxzq and @chez-charlie how can I help you?

@chez-charlie any update on this? Thanks a lot!

/unresolve

Hi @csotomon ,you can try to use
tr_properties = TriggerResource(properties=ScheduleTrigger(description='My schedulertrigger',pipelines=pipelines_to_run,recurrence=scheduler_recurrence))

instead of
tr_properties = TriggerResource(description='My scheduler trigger', pipelines = pipelines_to_run, recurrence=scheduler_recurrence)

/unresolve

Hi @csotomon ,you can try to use
tr_properties = TriggerResource(properties=ScheduleTrigger(description='My schedulertrigger',pipelines=pipelines_to_run,recurrence=scheduler_recurrence))

instead of
tr_properties = TriggerResource(description='My scheduler trigger', pipelines = pipelines_to_run, recurrence=scheduler_recurrence)

This is throwing ValueError: Unknown type of azure resource: TriggerResource, I've imported TriggerResource from azure.mgmt.datafactory.models


Find a cons modal - Consultants photos are not displayed

Expected behavior
When searching for a consultant and the results are displayed, if the consultant has a photo uploaded it should display.
Actual behavior
When searching for a consultant and the results are displayed, if the consultant has a photo uploaded it does not display on the results:

You can see if you view this consultants webpage CID#505 Dawn Stewart she has a photo uploaded.

Steps to reproduce behavior
Click on find a consultant.
Searched by State Wisconsin and first name Dawn
View results

Reviewed with Jasmine and I sent inquiry to Jared in slack if this should have an API tag.

Changed image base URL to use 'tso.tastefullysimple....' instead of the sandbox url.  This new URL will be used for all environments, per Jared

8-11 SH - fixed


net: tcp: Fix compile error in tcp.h

During build testing for spresense with the latest master, I encountered the following compile error.
tcp/tcp_netpoll.c: In function 'tcp_pollsetup':
./tcp/tcp.h:1191:42: error: expected ')' before ';' token
 #  define tcp_backlogavailable(c) (false);
                                          ^
tcp/tcp_netpoll.c:308:40: note: in expansion of macro 'tcp_backlogavailable'
   if (!IOB_QEMPTY(&conn->readahead) || tcp_backlogavailable(conn))
                                        ^~~~~~~~~~~~~~~~~~~~
Makefile:102: recipe for target 'tcp_netpoll.o' failed

Actually, the line 1191 in tcp/tcp.h was added in 2014-07-06 but not used so far.
And the line 308 in tcp/tcp_netpoll.c was not called on my environment before merging the following commit
commit 90c52e6f8f7efce97ac718c0f98addc13ec880d2
Author: Xiang Xiao<EMAIL_ADDRESS>Date:   Tue Dec 31 09:26:14 2019 -0600

The fix in this PR is very trivial and I think @xiaoxiang781216 enabled CONFIG_NET_TCPBACKLOG on his environments because he did not encounter the error.

BTW: CONFIG_NET_TCPBACKLOG probably should always be enabled.  Otherwise, you will miss connection requests.  That configuration is a candidate to be removed and just have connection backlog support enabled at all times.

BTW: CONFIG_NET_TCPBACKLOG probably should always be enabled. Otherwise, you will miss connection requests. That configuration is a candidate to be removed and just have connection backlog support enabled at all times.

@patacongo Thanks for the comment. I will modify our defconfigs in separate PR later.

@masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be a better solution?  Anyone else have an opinion to the contrary?
The TCP backlog was conditioned originally only to support support super tiny networking.  But with all of the growth in networking, I think super-tiny networking is not really an option and is certainly not advised in this case since the consequences of disabling backlog are so bad.  NuttX now really only supports "small" networking, not super-tiny networking.

@masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be a better solution? Anyone else have an opinion to the contrary?
The TCP backlog was conditioned originally only to support super-tiny networking. But with all of the growth in networking, I think super-tiny networking is not really an option and is certainly not advised in this case since the consequences of disabling backlog are so severe. NuttX now really only supports "small" networking, not super-tiny networking.

@patacongo I think that's a good idea, because we will not use NuttX networking with super-tiny environment. If nobody has an objection on it, please remove support for CONFIG_NET_TCPBACKLOG.


Add resources from SFU Call to project documentation

Our call with Thomas and Bradford from SFU was very insightful to the team. We were also directed to a number of people in academia and beyond for follow-up conversations.
Acceptance Criteria:

[x] Go through interview notes for recommended people
[x] Go through Thomas' follow-up email
[x] Add contacts to Contact Tracker

Thank you @jaimiebutton !


AWS: promote staging web server to main domain

This adds another rake task to help with deploying a new web server. After #158, the rake aws:create_web_asg task will now update the staging.oversight.garden DNS records once the new server is online. This new task, rake aws:promote will perform some sanity checks to make sure the new server's working, then copy the IP address from the staging.oversight.garden records to the oversight.garden records.
So, the new deployment process for the web server is rake aws:create_web_asg, do manual QA by browsing to staging.oversight.garden, rake aws:promote, and delete the old ASG in the console when you're done with it.

This is awesome, thank you!