Eagerly Free Slices in Case of Partial Write

Build off #13367
Fixes an internal bug caused by holding on to a slice in a slice_buffer longer than application code expected. In parallel, I will work with the application code to not depend on when we free memory passed to us, but eagerly freeing up resources is always a good idea

****************************************************************

libgrpc.so

     VM SIZE                                                              FILE SIZE
 ++++++++++++++ GROWING                                                ++++++++++++++
  +0.0%    +232 [None]                                                 +1.50Ki  +0.0%
  +4.6%    +192 src/core/lib/slice/slice_buffer.cc                        +192  +4.6%
      [NEW]    +150 grpc_slice_buffer_partial_reset_and_unref_internal        +150  [NEW]
       +40%     +36 grpc_slice_buffer_reset_and_unref_internal                 +36   +40%
       +22%      +8 grpc_slice_buffer_init                                      +8   +22%
  +0.4%     +32 src/core/lib/iomgr/tcp_posix.cc                            +32  +0.4%
      +4.0%     +38 tcp_flush                                                  +38  +4.0%

  +0.0%    +456 TOTAL                                                  +1.72Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +264  +0.0%

  [ = ]       0 TOTAL     +264  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                              FILE SIZE
 ++++++++++++++ GROWING                                                ++++++++++++++
  +0.0%    +232 [None]                                                 +1.50Ki  +0.0%
  +4.6%    +192 src/core/lib/slice/slice_buffer.cc                        +192  +4.6%
      [NEW]    +150 grpc_slice_buffer_partial_reset_and_unref_internal        +150  [NEW]
       +40%     +36 grpc_slice_buffer_reset_and_unref_internal                 +36   +40%
       +22%      +8 grpc_slice_buffer_init                                      +8   +22%
  +0.4%     +32 src/core/lib/iomgr/tcp_posix.cc                            +32  +0.4%
      +4.0%     +38 tcp_flush                                                  +38  +4.0%

  +0.0%    +456 TOTAL                                                  +1.72Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +264  +0.0%

  [ = ]       0 TOTAL     +264  +0.0%

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                            http2_pings_sent_per_iteration    locks_per_iteration
-------------------------------------------------------------------  --------------------------------  ---------------------
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/0                                            -8%
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/134217728  -21%

****************************************************************

libgrpc.so

     VM SIZE                                                      FILE SIZE
 ++++++++++++++ GROWING                                        ++++++++++++++
  +0.0%    +264 [None]                                         +1.70Ki  +0.0%
  +5.4%    +224 src/core/lib/slice/slice_buffer.cc                +224  +5.4%
      [NEW]    +191 grpc_slice_buffer_partial_unref_internal          +191  [NEW]
       +40%     +36 grpc_slice_buffer_reset_and_unref_internal         +36   +40%
       +22%      +8 grpc_slice_buffer_init                              +8   +22%
  +0.4%     +32 src/core/lib/iomgr/tcp_posix.cc                    +32  +0.4%
      +4.0%     +38 tcp_flush                                          +38  +4.0%

  +0.0%    +520 TOTAL                                          +1.95Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +264  +0.0%

  [ = ]       0 TOTAL     +264  +0.0%

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                            http2_pings_sent_per_iteration
-------------------------------------------------------------------  --------------------------------
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/134217728  -21%

****************************************************************

libgrpc.so

     VM SIZE                                       FILE SIZE
 ++++++++++++++ GROWING                         ++++++++++++++
  +0.0%     +24 [None]                             +408  +0.0%
  +0.4%     +32 src/core/lib/iomgr/tcp_posix.cc     +32  +0.4%
      +4.8%     +46 tcp_flush                           +46  +4.8%
      +1.1%      +2 [Unmapped]                           +2  +1.1%

  +0.0%     +56 TOTAL                              +440  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE                                       FILE SIZE
 ++++++++++++++ GROWING                         ++++++++++++++
  +0.0%     +24 [None]                             +432  +0.0%
  +0.4%     +32 src/core/lib/iomgr/tcp_posix.cc     +32  +0.4%
      +5.2%     +49 tcp_flush                           +49  +5.2%

  +0.0%     +56 TOTAL                              +464  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

Addressed all comments, PTAL,

****************************************************************

libgrpc.so

     VM SIZE                                       FILE SIZE
 ++++++++++++++ GROWING                         ++++++++++++++
  +0.0%     +24 [None]                             +432  +0.0%
  +0.4%     +32 src/core/lib/iomgr/tcp_posix.cc     +32  +0.4%
      +5.2%     +49 tcp_flush                           +49  +5.2%

  +0.0%     +56 TOTAL                              +464  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                       FILE SIZE
 ++++++++++++++ GROWING                         ++++++++++++++
  +0.0%      +8 [None]                             +576  +0.0%
  +0.2%     +16 src/core/lib/iomgr/tcp_posix.cc     +16  +0.2%
      +3.6%     +34 tcp_flush                           +34  +3.6%

  +0.0%     +24 TOTAL                              +592  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                       FILE SIZE
 ++++++++++++++ GROWING                         ++++++++++++++
  +0.0%      +8 [None]                             +480  +0.0%
  +0.2%     +16 src/core/lib/iomgr/tcp_posix.cc     +16  +0.2%
      +3.6%     +34 tcp_flush                           +34  +3.6%

  +0.0%     +24 TOTAL                              +496  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                               cpu_time    real_time
----------------------------------------------------------------------  ----------  -----------
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768  -5%         -5%

All tests are flakes except the C Tsan one. And I think that is an issue with http_proxy_fixture. Will keep digging

****************************************************************

libgrpc.so

     VM SIZE                                       FILE SIZE
 ++++++++++++++ GROWING                         ++++++++++++++
  +0.0%      +8 [None]                             +384  +0.0%
  +0.2%     +16 src/core/lib/iomgr/tcp_posix.cc     +16  +0.2%
      +3.6%     +34 tcp_flush                           +34  +3.6%

  +0.0%     +24 TOTAL                              +400  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Think this worked! Will manually kokoro rerun just TSAN C to be doubley sure

Dbg: #12958
Asan: #13122
Windows & Mac: #13426
Multi Lang: #13461
Tsan C++: infra failure (but it passed in an earlier run, showing only #13122. Link here)


"UpdateUser"-method used by "SetCustomUserClaimsAsync" throws "MISSING_LOCAL_ID"

The serialized "UserRecord" JSON uses the property-names of the "UserRecord"-class. This is wrong and has to be remapped.
Currently:
{    "Uid":"40MgueENCLft6rl5Zs4Et0FuiQF3",    "ProviderId":"firebase",    "EmailVerified":false,    "Disabled":false,    "TokensValidAfterTimestamp":0,    "customAttributes":"{\"Roles\":[\"AAA\",\"BBB\"]}" }
But correct properties would be:

localId
email
disableUser

Edit: ahh I see that you have prepared a pull-request with fixes for that.

Yes, this was correct in the last release: https://github.com/firebase/firebase-admin-dotnet/blob/31e55ef09ccf50f95cc2dd36d5868228ba320163/FirebaseAdmin/FirebaseAdmin/Auth/UserRecord.cs#L37-L49
But since then it has broken in the master branch. #53 should fix it.

This fix was released in 1.5.0


Add Lightson Codeowners

Adds more Lightson codeowners for the frontend portions to reduce friction

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.80%. Comparing base (7e2e993) to head (387df7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   79.80%   79.80%
=======================================
  Files         243      243
  Lines       10355    10355
=======================================
  Hits         8264     8264
  Misses       2091     2091

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Leaving with a main while alts are applied does not remove the alt applications

Repro:

Apply with main, accept
Apply with alts
Leave with main
Check staff pending applications page, alts are still pending, no indication main left

Since it's disallowed to apply an alt without a main, the solution here is probably to auto-reject the alt applications with the leave/withdraw cooldown.
Note that this is a bit at odds with the behavior of what happens if you accept those alts first (since they don't get kicked currently), but that's mostly (again) due to the auth main/whc main issue since we have no notion of swapping whc mains, so if a character drops corp, the auth main is auto-updated and whctools is left with a weird state.
In fact, now I'm kind of curious what happens to the ACL view when an auth main is changed....

The auth main changed : should just shift the chars around. When the page
is built it checks which char is registered as main, and sorts the other
chars under it
On Tue, Jul 23, 2024, 9:41 PM mome-borogove @.***>
wrote:

Repro:

Apply with main, accept
Apply with alts
Leave with main
Check staff pending applications page, alts are still pending, no
indication main left

Since it's disallowed to apply an alt without a main, the solution here is
probably to auto-reject the alt applications with the leave/withdraw
cooldown.
Note that this is a bit at odds with the behavior of what happens if you
accept those alts first (since they don't get kicked currently), but
that's mostly (again) due to the auth main/whc main issue since we have no
notion of swapping whc mains, so if a character drops corp, the auth main
is auto-updated and whctools is left with a weird state.
In fact, now I'm kind of curious what happens to the ACL view when an auth
main is changed....
—
Reply to this email directly, view it on GitHub
https://github.com/EVE-University/whctools/issues/44, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLOBQ72TB2EJ2MHIVHM5TDZN4A4NAVCNFSM6AAAAABLLPZQVSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDMNBRGQZDOMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Gotcha. I was concerned it was a map with mains as keys, but I see that is reconstructed dynamically every time, so it's not an issue.
Thanks.


C# 7.x: Tuples

This (Draft) PR is not quite complete.

This PR adds the new section, "§deconstruction-expressions-new-clause Deconstruction expressions", which defines the grammar rule tuple_deconstruction_expression. However, that rule is not currently reachable, so we need to figure out where to insert it in the expressions rule hierarchy.

This PR adds the new section, "§deconstruction-expressions-new-clause Deconstruction expressions", which defines the grammar rule tuple_deconstruction_expression. However, that rule is not currently reachable, so we need to figure out where to insert it in the expressions rule hierarchy.

Good point! There is grammar missing, and the grammar that does exist is left recursive…
First let’s complete the grammar, but not make it reachable. Currently from the text a tuple_deconstruction_expression can only appear as part of a tuple deconstruction statement, so the grammar would be something like:
tuple_deconstruction_statement
    : tuple_deconstruction_expression '=' expression
    ;

tuple_deconstruction_expression
    : '(' destination (',' destination)* ')'
    ;

destination
    : type? identifier
    ;

Left recursion is gone, and tuple_deconstruction_expression is reachable from * tuple_deconstruction_statement*, but the latter is not reachable yet.
Now how to make it reachable, i.e. where does it fit into the grammar? The text suggests it is a statement_expression however all the subclauses of that are expressions which can occur elsewhere, a tuple_deconstruction_statement can only be at the statement level. (Note that while a * tuple_deconstruction_statement* may only assign to existing variables unlike assignment it cannot be a sub-expression of another expression.)
The other obvious choices are: a subclause of declaration_statement – as one or more variables may be declared; a subclause of embedded_statement – on par with other statement kinds and in the hierarchy which contains assignment; or a subclause of statement itself.
Subjectively I’d lean to one on the last three and away from statement_expression, YMMV and I haven't checked where Roslyn puts it as someone will know!

See #63 for remaining questions

Closed in favor of #664


does not

it does not compile on save.
when is it supposed to?

Hi, can you give me more information to try to recreate it.
Atom version, you configuration comment and maybe an jade code example.
Thanks!

Hi, Atom 1.8, on osx latest, also let me know anything else, I'd love to be
able to get it to work. Here is just simplest jade:
p.
oh hi
On Sat, Jul 16, 2016 at 8:25 PM, Manuel Rueda<EMAIL_ADDRESS>wrote:

Hi, can you give me more information to try to recreate it.
Atom version, you configuration comment and maybe an jade code example.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManRueda/jade-autocompile/issues/21#issuecomment-233163020,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATHz0kNZ_m0NvHKs4DWP24wK5mLO0HWWks5qWaCqgaJpZM4JOGoS
.

Mhhh can you send me your comment config? Because is working for me...

I'm happy to hear that it can work. Please help.
Here is the file:
"":
"atom-idle-autosave":
debounce: 2500
autosave:
enabled: true
"browser-refresh":
googleChromeCanary: true
core:
disabledPackages: [
"chrome-color-picker"
"jade-beautify"
"linter-jade"
"autocompile-jade"
"jade-autocompile"
"browser-plus"
"browser-refresh-on-save"
]
ignoredNames: [
"."
".map"
".css"
".dist.js"
".jpg"
"*.html"
]
editor:
backUpBeforeSaving: true
fontSize: 15
showIndentGuide: true
softWrap: true
"exception-reporting":
userId: "269718f1-a82c-51c4-e87c-e3c643098288"
"jade-beautify":
BEAUTIFY_ON_SAVE: true
BEAUTIFY_ON_SAVE_ALL: true
preview:
_analyticsUserId: "145730b3-2a48-4a9c-9d16-fa1c2271ba4c"
"tree-view":
hideIgnoredNames: true
hideVcsIgnoredFiles: true
welcome:
showOnStartup: false
On Sun, Jul 17, 2016 at 11:06 AM, Manuel Rueda<EMAIL_ADDRESS>wrote:

Mhhh can you send me your comment config? Because is working for me...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManRueda/jade-autocompile/issues/21#issuecomment-233195188,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATHz0phvGSCpxvnUByzfj38P1mKrY26Wks5qWm8xgaJpZM4JOGoS
.

No, look the README.md file, you need to put a comment in the first lines to make it work. I need those comments.

I'm sorry, I'm not able to follow. I installed your project via 'atom gui
install'. There is no config there.
I'm now reading the read me file on home page of git and I don't
understand, not even the first line. 'The two first comment blocks of file
can be used to pass parameters to the compiler.'
I have installed other atom packages w/o a problem, like auto save, or f5
for browser refresh, they work.
Where would such a comment block be?
Here is what I see, just so you can see how lost I am.
help.
[image: Inline image 1]
On Sun, Jul 17, 2016 at 3:22 PM, Manuel Rueda<EMAIL_ADDRESS>wrote:

No, look the README.md file, you need to put a comment in the first lines
to make it work. I need those comments.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManRueda/jade-autocompile/issues/21#issuecomment-233207674,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATHz0iEnBivofzMEaUU3I9FBuhGWroI4ks5qWqsNgaJpZM4JOGoS
.

Got it. (other things had a gui config. It seems odd to edit a readme file).
So still no joy, I edited like so, just removed the comment:
jade-autocompile package [![Build Status](
https://travis-ci.org/ManRueda/jade-autocompile.svg?branch=master)](https://travis-ci.org/ManRueda/jade-autocompile
)
Auto compile JADE files on save
Atom package site
Configuration
The two first comment blocks of file can be used to pass parameters to the
compiler.

The first one must have the name of the output html file, like this:

output:$1.html
If you avoid this comment, the file is omitted by the compiler.

On Sun, Jul 17, 2016 at 3:38 PM, Manuel Rueda<EMAIL_ADDRESS>wrote:

> The README file can be accessed by Atom's Package Installer. Atom uses the
> README file as a "front-page" for each package.
>
> This package require to put a comment in the jade file to be compiled.
> This comment will tell to the package the location to put the html file,
> the name and other things.
>
> I hope that this will clarify your doubts.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/ManRueda/jade-autocompile/issues/21#issuecomment-233208363>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ATHz0rZm5kP_wHdx_pDWvplQk420DT4Xks5qWq7YgaJpZM4JOGoS>
> .
>

No, you don't need to edit the README file, you need to edit your jade file. With the comment as the example in the README

Oh. OK. It works!
I would have docs say this, instead of Configuration, since there is no
Configuration:
" To compile, your jade file must have comments in the first line like
this:
...."
THANK YOU! Nice plug in.
Vic
On Sun, Jul 17, 2016 at 3:54 PM, Manuel Rueda<EMAIL_ADDRESS>wrote:

No, you don't need to edit the README file, you need to edit your jade
file. With the comment as the example in the README
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManRueda/jade-autocompile/issues/21#issuecomment-233209062,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATHz0vU3_ynkvmSc9kYL58i3TA4eK9qGks5qWrKfgaJpZM4JOGoS
.


Fix the default network config for the installed OS

Get rid of the default config generated by NetworkManager during the IPA boot, since it currently limits us to DHCP on only one interface (the wrong one). This is a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=2032717
Since the default config will not be persisted, we need to copy and ip=dhcp/ip=dhcp6 kernel options passed to the IPA boot to the installed OS.

/hold
Not tested yet

It seems to work at least
/hold cancel

/lgtm

/retest
both jobs failed setting up the devscripts-proxy (packet network glitch maybe??)

Error: reading blob sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4: Get "https://quay.io/v2/sameersbn/squid/blobs/sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4": net/http: TLS handshake timeout

and

ssh: connect to host <IP_ADDRESS> port 22: Connection timed out


LMQL lacks supporting integration with Azure Open AI services.

Beside models from Open AI, now there are the same models such as gpt-3, gpt-3.5 on Azure Open AI services.
I attempt to use those service from Azure but it does not seems to support.
LMQL should support integration with Azure Open AI services.

Thanks for raising this. LMQL actually already supports Azure endpoints, see this PR here: https://github.com/eth-sri/lmql/pull/71.
You will need the 'main' version for this, as there was not a release including this yet.
pip install git+https://github.com/eth-sri/lmql

I will keep this issue as a TODO to add this to the docs.


[infra] support rolling goldctl via .ci.yaml instead of recipe changes

Currently to roll a new version of goldctl a CL must be send to the recipe code (example). Instead, it should be managed via .ci.yaml like other dependencies.

This has been implemented.


TypeError: Cannot read property 'data' of null

Operation System: Debian 9 (Stretch)
Beaker version: Beaker 0.8.0-prerelease.3 (commit #f46ce3)
I have repeatedly received the following error (possibly related to Fritter?):
Error
A Javascript error occurred in the main process

Uncaught Exception:
TypeError: Cannot read property 'data' of null
    at Request.onvalue [as_callback] ($PATH_TO_BEAKER/app/node_modules/hypercore/lib/replicate.js:135:19)
    at Request.callback ($PATH_TO_BEAKER/app/node_modules/random-access-storage/index.js:150:8)
    at onread ($PATH_TO_BEAKER/app/node_modules/hyperdrive/node_modules/random-access-file/index.js:80:31)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:658:17)

I have not noticed a pattern about when this error occurs yet, but I am usually using Fritter at the time (however, that could be a sampling bias). It creates a dialog box that will come back every time I click 'OK' until I kill Beaker.

Yikes, thanks for reporting, I'll check into that asap.

Fixed in hypercore 6.12.7, see https://github.com/mafintosh/hypercore/issues/146


Program progress sensor is returning a string

Version of the custom_component

0.5.2
Describe the bug
"Program progress" sensor is returning the percentage as a string and not as numeric values, hence it shows as a bar in history browser instead of graph.

You didn't provide the configuration. If you're using "server" for sensor translation then it will be returned as a string, otherwise it should be a number.


Luigi doesnt show help with --help

In the command line, I have problems printing help:
$ luigi --help
Traceback (most recent call last):
File "/home/alfonso/anaconda2/bin/luigi", line 6, in
sys.exit(luigi.cmdline.luigi_run())
File "/home/alfonso/anaconda2/lib/python2.7/site-packages/luigi/cmdline.py", line 13, in luigi_run
luigi.interface.run(argv, use_dynamic_argparse=True)
File "/home/alfonso/anaconda2/lib/python2.7/site-packages/luigi/interface.py", line 421, in run
tasks = interface.parse(cmdline_args, main_task_cls=main_task_cls)
File "/home/alfonso/anaconda2/lib/python2.7/site-packages/luigi/interface.py", line 329, in parse
import(module)
This works fine though (help is printed):
$ luigi -h

This is a really undesirable bug. We have test cases for exactly this, not sure why it isn't tested in an environment like yours. :-/

closing this issue.

[x] It has been inactive for +4 months.
[ ] It's not about luigi core, so not as many users are affected about this.
[ ] The change seems quite big, it's unlikely to be sporadically picked up.
[x] The owner haven't responded or disappeared.
[ ] I don't understand what this issue is about.
[ ] There exists a reasonable workaround for this.
[x] We need to check if this hasn't been fixed by now (for old issues).
[ ] This is kind of by design and not a bug.
[ ] Resolving this would probably add a lot of complexity.
[x] Cannot reprodue

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.
Feel free to reopen this issue at any point if you have the intent to continue to work this. :)


can you provide some pre-trained models?

hello, I am a fresh hand for text classification. Now I just want use the eval.py to do a simple test. Can you provide a link which contains some good pre-trained models?

@cahya-wirawan  thank your response!


Nginx / Unicorn error when trying to access the app

I created this box and provisioning went well. However when I'm trying to access the app via http://localhost:8080 I get the following in the nginx error.log:
2015/03/22 22:27:02 [crit] 1134#0: *1 connect() to unix:/tmp/unicorn.development.sock failed (2: No such file or directory) while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "GET / HTTP/1.1", upstream: "http://unix:/tmp/unicorn.development.sock:/", host: "localhost:8080"

I read that this might be because it is not possible to store the socket files in /tmp anymore, but I'm not sure if this applies to Ubuntu.

I've just tried to use your railsbox in testapp1 and it worked. I would suggest to ssh into the box (vagrant ssh) and see if unicorn is actually running. If it's not running then try to take a look at /rcheliwiki/log/unicorn.err.log.


Expose default builder

Allows Ceibo users to create their own builders that invoke the default builders. (Kind of like using super().)

I'll merge this one after #2 is merged

@san650 I suppose this would require a version bump to 1.1.0, correct?

@jeradg yes, I guess so.

OK. Added the new version number.


[FEATURE] add/remove/list actor claims with wash

Note that this should probably not start until wasmCloud/wash#538 has been decided upon and implemented.

It would be nice to be able to add claims/capabilities to an actor's wasmcloud.toml file without having to edit it directly. Less chance for squishy human errors.

wash claims add <name>
wash claims list
wash claims remove <name>

As a stretch goal, autocomplete for the  argument would be nice. Could suggest official wasmcloud contracts for add  and list existing claims for remove

Just noting if https://github.com/wasmCloud/wasmCloud/issues/1219 is accepted, I think this becomes unnecessary

Closing in favor of #1219. Work is slated to be added to 1.0 release.


reported issue with CF invalidation

from https://forum.wp2static.com/-181/cloudfront-cache-invalidation-s3-delpyment-v10-alpha-006#post-1

Hi, found some more issues in the S3 module. For cache invalidation, you are using the s3 Key and Secret s3AccessKeyID/s3SecretAccessKey instead of cfAccessKeyID/cfSecretAccessKey - may be confusing to people who store different credentials for each.

Also, passing the credentials into the CloudFrontClient is not working as coded up. I rewrote it locally as
$client = \Aws\CloudFront\CloudFrontClient::factory(
    array(
        'region' => $client_options['region'],
        'version' => 'latest',
        'credentials' => $credentials,
    )
);

And its working correctly. Apparently they implement the factory on the CloudFrontClient in v3 and not on the s3 client.
Would also be handy to have some wp2static logging when the crawl, process, and invalidation jobs end ie
Invalidating CloudFront Complete
Invalidating all CloudFront Items

@sgerlach reported that the CallerReference must be unique each time (see https://docs.aws.amazon.com/cli/latest/reference/cloudfront/create-invalidation.html). This should be fixed at the same time. I'd like to look into this at some point and find a more efficient solution than invalidating the entire cache, as that can get very costly very quickly.

previously fixed


backgroundColor doesn't seem to work

Describe the bug
Setting backgroundColor on the PersistentTabView doesn't seem to have an affect.
To Reproduce
Steps to reproduce the behavior:

Set backgroundColor: Colors.red on the PersistentTabView.

Expected behavior
The color of the nav bar to change.
Screenshots

Desktop (please complete the following information):

OS: macOS Ventura 13.3.1 (a)

Smartphone (please complete the following information):

Device: iPhone SE (3rd gen)
OS: iOS 16.4

Additional context
I'm probably just missing something simple but I can't figure out what.

Ah the docs are outdated for that parameter. The backgroundColor changes the background of the whole tab view, so if you would have any transparent places in your tabs, the color would be seen there. To change the color of your navbar, pass a NavBarDecoration to your Style6BottomNavBar like so:
...
navBarBuilder: (p0) => Style6BottomNavBar(
  navBarConfig: p0,
  navBarDecoration: const NavBarDecoration(
    color: Colors.red,
  ),
),
...

Ah, that makes sense. Perfect, Thank you!!


Web -  Incorrect zip code format shown on some default addresses in personal details page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to settings -> Profile -> Personal details
Then go to Home Address
In address line one type 'P' and select the first shown one i.e "Pearson Airport Terminal 1 Parking, Canada"
Notice that auto filled zip/postal code is "L5P"
Click on save
Notice that it throws error. Invalid zip format

Expected Result:
Either proper zip format should be used or the field is to be left empty. Autocompleting zip/postal code with improper formats leads confusion.
Actual Result:
Incorrect zip code format shown on some default addresses in personal details page
Workaround:
Unkown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/6ef450c5-5009-42e5-b965-6c2b55d93aa8

https://github.com/Expensify/App/assets/93399543/31df3774-01be-48e5-a9e1-d89c3ebd44c4
Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693473068367439
View all open jobs on GitHub

Reproducible!

Thanks @ntdiary!


Insufficient type definitions for partial importing when using only specific version

Describe the bug
When doing partial import type definitions does not recoqnise uuidv*.
How to reproduce
For my project I am using Create React App.
Add uuid as dependency into project.  At this point uuid version 8.3.2 and @types/uuid version 8.3.1 will be installed.
npm install uuid -E && npm install @types/uuid -D
Import only uuidv4 from CDN in index.html.
<!-- With this we can run uuidv4() anywhere we want -->
<script<EMAIL_ADDRESS>
Use uuidv4 in module for importing only specific version.
/**
 * Need to add these ignore blocks in front of import for making it work
 */
// @ts-ignore
// eslint-disable-next-line import/no-unresolved
import uuidv4 from 'uuid/v4';

/**
 * This now works
 */
console.log(uuidv4());

As we have React App Rewired in project we have set configuration to map external packages so they are not included in build bundle, UMD versions of libraries will be used instead.
{
  "uuid/v4": "uuidv4"
}

Expected behavior
Type definitions work correctly if importing only specific version.
Runtime

OS: any
Runtime: any
Runtime Version: any

Sorry for not getting to this earlier!
This package doesn't ship with any typings of its own, so you'll need to open an issue in the DefinitelyTyped repo.


ModuleNotFoundError when importing all from refgenconf

In [1]: from refgenconf import *
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-0fec0feab9eb> in <module>
----> 1 from refgenconf import *

ModuleNotFoundError: No module named 'refgenconf.0'

this is probably due to an invalid module name introduced to perform the config upgrade

I'm not sure what is the problem.  I got the error when from refgenconf import * but not from refgenconf import upgrade_config.

did this get solved?

Not. Yet I'm planning to look into this soon


ENH: Added instance type check for plot_dipole function and also a test for it

Closes #511
I made changes in plot_dipole function in viz.py to type of argument 1. Iteration is used when a list of dipoles is passed. I have included a test in test_dipole.py where [dipole, integer] is passed as an argument to plot_dipole() and the appropriate error message is checked using pytest.

I have removed the flake8 errors

You should use the phrase "closes #511", otherwise the linked PR will not get closed when this PR is merged. See:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Codecov Report

Merging #606 (4df60cc) into master (05a8f09) will decrease coverage by 0.05%.
The diff coverage is 96.42%.

:exclamation: Current head 4df60cc differs from pull request most recent head ff841c6. Consider uploading reports for the commit ff841c6 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   91.94%   91.89%   -0.05%
==========================================
  Files          22       22
  Lines        4257     4259       +2
==========================================
  Hits         3914     3914
- Misses        343      345       +2

Impacted Files
Coverage Δ

hnn_core/gui/_viz_manager.py
89.00% <66.66%> (+0.39%)
:arrow_up:

hnn_core/gui/gui.py
96.44% <100.00%> (-0.02%)
:arrow_down:

hnn_core/viz.py
89.25% <100.00%> (+0.06%)
:arrow_up:

hnn_core/parallel_backends.py
81.38% <0.00%> (-0.84%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Can you update whats_new.rst ?

Should I update in Current Changelog in whats_new.rst?

Also, you'll need to rebase @raj1701. Let me know if you need help with this.

I can give it a shot. I'll contact you if I get stuck.

@rythorpe I thinks I was successful with the rebase. Please check once. Thanks

You're almost done @raj1701, just a minor adjustment to the warning message!

Okay I simplified the logic a bit @raj1701 @rythorpe ... please take a look. It is slightly different from the original logic but I think it's not less correct. Wdyt?

I think its correct and much more simplified. Now I get what you were trying to convey @jasmainak.

Are we ready to rebase and merge @raj1701 @jasmainak?

@raj1701 try not to make too many commits for a simple change. It will make your life difficult with respect to rebasing. Make use of git commit --amend or squash the commits so each commit represents a logical unit of code.

Yes will remember this. I faced many rebase errors here also.

Yep, I changed the PR to MRG. Please squash and merge @rythorpe !

Thanks @raj1701 and @jasmainak!


Impliment support attributes for marshal/unmarshal

Since Delphi 2010 available attributes
http://docwiki.embarcadero.com/RADStudio/2010/en/Declaring_Custom_Attributes
We can use it for improve marshal/unmarshal
For example:
TSomeObject = class
   [TJsonField('fieldA')]
   filedAlpha: string;
end;

it'll be marshaled to (or unmarshal from)
{"fieldA" : "someValue"}

Yeah, that seems great. :+1:

I`ll try implement my idea

This is already supported. SuperObject implements the attributes SOName and SODefault. When using DBX there are the attributes JsonName and JsonDefault defined in DbxJsonUtils unit.
See the code inside TypesToTest.TAllTypes and the tests inside TestDbxJsonUnMarshal
TAllTypes = class
  [SOName('renamed')]
  [JsonName('renamed')]
  fieldNameRenamed: String;

Maybe this could be improved.  Maybe remove the duplicated attribute.
Anyway, The docs should be improved to expose this feature.
Thanks.

Thanks Fabricio


Cannot  combine all scorefiles

Following this discussion, I am trying to create one big scorefile which combines all scorefiles from the catalog.
Hence, I first downloaded all individual scorefiles using
for pgsid in $(cat pgs_scores_list.txt); do echo $pgsid; pgscatalog-download -i $pgsid -o . -b GRCh38
I then try to combine them using
pgscatalog-combine -s PGS*.txt.gz -t GRCh38 -o combined.txt
This leads to the following error:
...
  File "XXX/venv/lib/python3.11/site-packages/pgscatalog/core/lib/genomebuild.py", line 51, in from_string
    raise ValueError(f"Can't match {build=}")
ValueError: Can't match build='NCBI35'

Any ideas on how to proceed?

I found out that PGS000192 seems to lead to problems. Without it, there are no error messages for now.
However, the process is now running for 5 days, and with a current memory usage of 190 Gb I am running into swap memory. Thus, I am afraid it will not finish in reasonable time. Is there a way to reduce resource requirements for the combination of score files?

Which part is using 190 GB, I assume the matching? There's not really a way to get around this - you could match smaller subsets of files and re-combine the matches to make the final scoring file, but we haven't really tested it at this scale.

Hmmm, that's written to be memory-light so we'll have to check on that (cc @nebfield). But you can run it on batches of scores and then concatenate the outputs as they'll have the same column order.

You shouldn't have the memory problem in v0.5.3, it looks like you're using v1.

Yes, I was using v1.0. Thanks for the advice, I am trying version v0.5.3 now. It seemed like a nice performance upgrade first, running to item 65/4488 very quick. But two hours in, at item 78/4488, it seems to slow down and memory is up at 120Gb again.

But you can run it on batches of scores and then concatenate the outputs as they'll have the same column order.

I tried it with batches of 70 scores. This works with all but one batch (PGS003364 to PGS003433) where it stalls forever.

Fixed in the new release:
https://github.com/PGScatalog/pygscatalog/pull/15
Thanks for the bug report 🚀

Is it already possible to use this release in pgsc_calc? AFAICS, it is currently using the docker image ghcr.io/pgscatalog/pgscatalog_utils:v0.4.3

We're planning to integrate pygscatalog with pgsc_calc in the next release of the calculator.
The release should be fairly soon (within a few weeks). The largest amount of work will be setting up some automatic correlation tests to make sure calculated scores remain stable across releases. We normally do slow manual testing 😅

Ok, thank you for the info. I was trying to run pgsc_calc with all the scores (stress test?) and it failed after 6h in the COMBINE_SCOREFILES step. So I am hoping that it will be possible with those fixes included in the next release.

Remember that I had combined scorefiles in batches of 70 before. I want to obtain a list with all locations where there are effect alleles across all studies, to do variant calling on those positions. I find that if I collect those positions from the batched-combined scorefiles, I get 17M positions. If I take them from the one combined scorefile from the new release, I obtain only 2.6 M positions. Is there any reasonable explanation for such a loss in variant locations after combining scores? Unfortunately, I deleted my old parallel processing results.


Drone Id

Hi
How do I find the drone id through mavsdk code.?
Whas is the process of generating a drone id.?

How does that work with MAVLink? Is there a MAVLink message giving the drone id?

yes. There are messages that gives information about the remote id of the drone and related information.
Please check.https://mavlink.io/en/services/opendroneid.html

If you want to differentiate between multiple drones, you can use different "system id"s. You can check https://mavlink.io/en/guide/message_signing.html how this will change the mavlink messages on byte-level.
To do so in PX4, change the MAV_SYS_ID parameter to different values. In MAVSDK you can do different stuff when connecting a new system based on the system id:
    mavsdk.subscribe_on_new_system([&]() {
        for (auto& system : mavsdk.systems())
        {
            uint8_t system_id = system->get_system_id();
            if (system_id >= 250) {
                found_gcs = true;
            } else if (system->has_autopilot()) {
                found_autopilot = true;
            }
            if (found_gcs && found_autopilot) {
                mavsdk.subscribe_on_new_system(nullptr); // stop subscribing to new systems as we got all systems that we want
            }
        }
    }):
    ... use mavsdk.systems() here ...


Terminate process on windows

What type of PR is this:
/kind bug
What does this PR do / why we need it:
This PR fixes how the odo process is terminated on Windows during integration tests
Which issue(s) this PR fixes:
Fixes #5485
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

Tested it locally and it works great on Windows 👍🏿

/approve

Not clear why the "Validate" job on IBM Cloud did not pass.
I guess we will have to run it again?

/override validator/Validate
Validate pass on Prow

Not clear why the "Validate" job on IBM Cloud did not pass. I guess we will have to run it again?

Oups! it seems an infra problem. As the validation passes locally and on Prow, I have overriden it


DCGAN running error: An error ocurred while starting the kernel

I try to run the DCGAN sample code(https://github.com/zsdonghao/tensorlayer) and meet a error at line 125:
errG, _ = sess.run([g_loss, g_optim], feed_dict={z: batch_z})
The error message on red background is
"An error ocurred while starting the kernel"
Among these error message there is a passage：
c:\tf_jenkins\home\workspace\release‑win\device\gpu\os\windows\tensorflow\stream_executor\cuda\cuda_dnn.cc:352] Loaded runtime CuDNN library: 6021 (compatibility version 6000) but source was compiled with 5105 (compatibility version 5100). If using a binary install, upgrade your CuDNNlibrary to match. If building from sources, make sure the library loaded at runtime matches a compatible version specified during compile configuration._
But there is no "c:\tf_jenkins" directory in my Computer at all.
I have install cudnn64_5/6/7. It doesn't work.
The running environment is: win7 64bit，anaconda+spyder，python3.5，CUDA8，GTX 1050Ti.

In stackoverflow I find the same problem(https://stackoverflow.com/questions/45046992/how-to-upgrade-cudnn5-1-to-cudnn6) and the questioner give a solution (Now I palced cudnn directory singlely and add path setting then the problem solved).
OH! YEAH!!!
I copy cudnn-8.0-windows7-x64-v6.0 to my cuda directory and then the problem solved!!!


fix(rest): preserve proto field snake case naming style in json

part of the work for for #12112

This change is

I think having a test that we pass the correct options to the protobuf function is better than no test. Can't we verify the contents of json_payload after the call?

This seems like a slippery slope. Do we really want to test that every function we use from our dependencies does what it says it does?

We would not be testing protobuf's function. We would be testing that our function calls their function with the right options.
If we removed the code from this PR, it would be nice if a unit test broke accordingly. :shrug:


Packet rate limit option (-r) not respected after a point, sometimes

In some testing of zmap with the -r and -B options, I observed that, at least with my systems, once the effective packet rate reaches ~244,000/s, the packet/s or bandwidth rate limit is ignored and zmap runs unbounded.
We run a UDP scan with something like:
/usr/local/sbin/zmap -i eth0 -S <sources> -s <port>  -v1 -b <blacklist_path> -r 350000 --output-filter='success = 1 && repeat = 0 && sport = <port>' -p <port>  -M udp -O csv -f timestamp_ts,saddr,sport,daddr,dport,ipid,ttl,data --probe-args=file:<some_file>

TCP studies are run similarly but with the respective TCP options passed instead.  The same issues is observed there.
The 350000 number was presumably chosen at some point in the past as a result of hardware testing.
  Eventually it starts dropping packets and the system becomes unreachable.
Changing to the bandwidth based limitations and I see the same behavior as the -B option passes 164M, however I suspect this is more a function of the payload size.  Sure enough, with the payload size we have and that bandwidth, the effective packets/s rate is ~244,000.
I've played with the various options I'm specifying and none of them beyond -r or -B seem to have an impact on the rate issue.  It is very odd that there is a specified rate that causes the effective rate to be much higher.  I'm baffled as to what could be causing this.  The only work around I have at this point is to specify a lower rate.
Any ideas?

Hmm. Which metric are you seeing that increases forever? The instantaneous rate bounces around a bit, but the average rate does continue to increase. Is it the average? Can you post more of the monitor log?
Does something like nload support this log-observed increase?
I think the right place to start investigating is that when you specify 244000, your instantaneous Kp/s is 244Kp/s but when you specify 245000 it becomes 484Kp/s.
What's the output of, say, -r 300000?

Also, what is the network hardware for each?

So, this is going to sound really crazy, but can you try changing this line to be a uint64_t instead of uint32_t? https://github.com/zmap/zmap/blob/master/src/send.c#L246
I came across this recently, and while I'm not entirely convinced this is affecting your case, I believe this is overflowing in some scans which would throw off the rate limiting.

@dadrian thanks for the suggestion -- i tried that but saw no change.
@paul-pearce it is the send rate and average that doesn't seem to settle down.  In several tests it remained at > 500kp/s throughout the entire scan.  system 1 is "Intel Corporation I210 Gigabit Network Connection (rev 03)", system2 is "Intel Corporation 82574L Gigabit Network Connection".  I installed nload and observed that with -r 244000 I see ~15-16Mb/s in, ~450Mbs/s out.  With -r 245000 I see ~26Mb/s in, >800Mb/s out.

I'm working my way back through the source code. Some additional thoughts:

Can you add -v5 -l logfile and include as much of the logfile as your comfortable with, both for 244000 and 245000. In particular, the number of threads in use.

Are the number of threads the same between both machines?

Are the blacklists the same between both machines.

Assuming I didn't miss some weird overflow bug, I'm rummaging through the iteration and sharding code, and that relies on stuff like number of threads and size of blacklist/whitelist.

Ah, and I missed something in my initial testing -- system1 initially seemed like it was respecting the option because another scan happened to be running at the same time and sapping resources.  Both systems exhibit the same behavior wrt this rate option in that it is not respected.
I'll update accordingly as I have new information

@paul-pearce
Oct 04 15:57:08.462 [DEBUG] zmap: zmap main thread started
Oct 04 15:57:08.462 [DEBUG] zmap: Loaded configuration file /etc/zmap/zmap.conf
Oct 04 15:57:08.462 [DEBUG] zmap: syslog support enabled
Oct 04 15:57:08.462 [DEBUG] zmap: requested ouput-module: csv
Oct 04 15:57:08.462 [DEBUG] fieldset: probe module does not supply application success field.
Oct 04 15:57:08.462 [DEBUG] zmap: requested output field (0): timestamp_ts
Oct 04 15:57:08.462 [DEBUG] zmap: requested output field (1): saddr
Oct 04 15:57:08.463 [DEBUG] zmap: requested output field (2): sport
Oct 04 15:57:08.463 [DEBUG] zmap: requested output field (3): daddr
Oct 04 15:57:08.463 [DEBUG] zmap: requested output field (4): dport
Oct 04 15:57:08.463 [DEBUG] zmap: requested output field (5): ipid
Oct 04 15:57:08.463 [DEBUG] zmap: requested output field (6): ttl
Oct 04 15:57:08.463 [DEBUG] zmap: requested output field (7): data
Oct 04 15:57:08.463 [DEBUG] filter: will use output filter success = 1 && repeat = 0 && sport = 123
Oct 04 15:57:08.463 [DEBUG] blacklist: no whitelist file or whitelist entries provided
Oct 04 15:57:08.471 [DEBUG] constraint: Painting value 1
Oct 04 15:57:08.504 [DEBUG] constraint:<PHONE_NUMBER> IPs in radix array, 2847143 IPs in tree
Oct 04 15:57:08.504 [DEBUG] constraint:<PHONE_NUMBER> addresses (85% of address space) can be scanned
Oct 04 15:57:08.505 [DEBUG] zmap: found gateway IP a.b.c.d on eth0
Oct 04 15:57:08.505 [DEBUG] send: gateway MAC address 00:01:e8:aa:bb:cc
Oct 04 15:57:08.505 [INFO] zmap: output module: csv
Oct 04 15:57:08.505 [INFO] csv: no output file selected, will use stdout
Oct 04 15:57:08.505 [DEBUG] csv: more than one field, will add headers
Oct 04 15:57:08.505 [DEBUG] zmap: Isomorphism:<PHONE_NUMBER>
Oct 04 15:57:08.505 [DEBUG] send: srcip_first: a
Oct 04 15:57:08.505 [DEBUG] send: srcip_last: b
Oct 04 15:57:08.505 [DEBUG] send: will send from 25 addresses on 1 source ports
Oct 04 15:57:08.505 [DEBUG] send: using bandwidth 165000000 bits/s, rate set to 245535 pkt/s
Oct 04 15:57:08.505 [DEBUG] send: no source MAC provided. automatically detected 00:25:90:aa:bb:cc as hw interface for eth0
Oct 04 15:57:08.505 [DEBUG] send: source MAC address 00:25:90:aa:bb:cc
Oct 04 15:57:08.506 [DEBUG] zmap: Pinning receive thread to core 0
Oct 04 15:57:08.506 [DEBUG] recv: capturing responses on eth0
Oct 04 15:57:08.539 [DEBUG] recv: duplicate responses will be included in output
Oct 04 15:57:08.539 [DEBUG] recv: unsuccessful responses will be included in output
Oct 04 15:57:08.539 [DEBUG] zmap: 1 sender threads spawned
Oct 04 15:57:08.539 [DEBUG] zmap: Pinning a send thread to core 1
Oct 04 15:57:08.540 [DEBUG] zmap: Pinning monitor thread to core 2
Oct 04 15:57:08.540 [DEBUG] send: send thread started
Oct 04 15:57:08.540 [DEBUG] send: source MAC address 00:25:90:aa:bb:cc

Number of threads is unspecified so I assume the default.  Blacklists are identical.

Dumb thing to suggest while I'm reading send.c and being sad, can you move to the head of master and ensure the problem continues? Also, make sure nothing new shows up in the log file while you see the increases continue.

@paul-pearce I reproduced this at the current head of master too after seeing the sharding changes (I discovered this while using sharding but the problem persists without it).  The log file remains unchanged after that last line.
To be clear, the rate does not increase but it does exceed the rate that I specified and seems to hold there:
 6:04 5% (1h59m left); send: 176247616 484 Kp/s (484 Kp/s avg); recv: 40605 107 p/s (111 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.02%

In some testing it seems like https://github.com/zmap/zmap/commit/c04bc6d060f0ce1f198ff7eda6bf1a685d3b8efa is the point where this option started malfunctioning.  I tried increasing the threads but couldn't find a value that resulted in the specified rate being respected.
🤔

Behavior changing at that commit is not surprising, as this has something to do with sharding and number of threads, and in that commit we changed the default zmap invocation from N threads to 1.
Some things to test:

At c04bc6d, try specifying -T 1 and see send rate breaks as it does at master (I suspect it will)

At c04bc6d with no -T specified, add -v5 -l logfile and find how many senders are being created from the log file. Go back to the head of master, and try passing -T N where N is that number of senders. I expect the problem goes away.

@paul-pearce I suspect for 2  you meant before c04bc6d because at c04bc6d  it will use 1 thread if not specified.  Before c04bc6d, it uses 22 senders.  When I switch to the tip of master and use -T 22, the problem goes away as you expected.

I just committed some code to a debug branch, https://github.com/zmap/zmap/tree/rate_debug
We're looking at the code that actually limits send.c. It seems like some assumption is being violated and we don't understand what it is.
The code in that branch adds some assertions to src/send.c. I don't expect any of them will fail, but it's a good starting place.
Run it, and if things continue to escalate (no assertion failures), please go into src/send.c and uncomment the 4 printf's with 'XXX` in them. Run it for a few moments, and then provide me with the output of all the XXX's. I want to understand how the counters are progressing. Please do this for both send rates.

Hmm. I somehow got it in my head you sketched this as 14.04. But you didn't.
What OS is this? How are you building zmap?

@paul-pearce it is Ubuntu 14.04.5 LTS, zmap built from source with cmake . && make -j4 && make install

@jhart-r7 k. Do give the debug branch above a try and let me know.

@jhart-r7 are you using -P by any chance?

Update:
I'm now fairly confident I understand the error. Here's the setup.

Send rate limiting is controlled by a delay variable. This variable controls a busy loop.
At startup, we try to calibrate what this delay value should be. We then, through send iterations, try to converge to a value that will cause the sending thread to slow down enough.
There's a bug here https://github.com/zmap/zmap/blob/0258a49568d56a4f62a0c7df741f6a13df1ce0d7/src/send.c#L318 where we set delay to 1 on the first loop iteration. This causes our sendrate to spike.
Independent of the bug, if send rate is configured over some threshold (I think it's 2x what the box can handle, by nature of the convergence algorithim), and the delay drops to 1, we begin to misbehave.

So the fix is:

Fix the bug that causes us to drop to 1 immediately.
Fail if we hit 1, as it implicitly means were operating up against system limits.

I pushed a fix to the rate_debug branch. Please deploy it and let me know if things are working properly for you. If they are, I'll float this by the others and see if we're happy. (Ideally, you'd like to support delay=1, but it makes everything else awful.)

@paul-pearce I am not using -P.
I've built that rate_debug branch and it appears to be respecting the rate specified :)

Great. I'll PR shortly.
Thank you for the report and helping out! This was a nasty one.

👍


fix - omnidb-config create_connection - values

This is a fix for issue #847
Removed one value from the insert query in create_connection (omnidb-config.py), so that we match the columns.

Hi @everneret ,
Thank you very much for your contribution :)
Sincerely,
The OmniDB Team


fix: transformers update

Please do not create a pull request without creating an issue first.
Changes need to be discussed before proceeding, pull requests submitted without linked issues may be rejected.
Please provide enough information so that others can review your pull request. You can skip this if you're fixing a typo – it happens.

[ ] I have added tests to tests to cover my changes.
[ ] I have updated docs/, if necessary.
[ ] I have updated the README.md, if necessary.

What existing issue does this pull request close?
Put closes #issue-number in this pull request's description to auto-close the issue that this fixes.
How are these changes tested?
This pull request includes automated tests for the code it touches and those tests are described below. If no tests are included, reasons why must be provided below.
These changes are tested with [...]
Demonstration
Demonstrate your contribution.
For example, what are the exact commands you ran and their output, related screenshots, screen-recordings, test runs, anything that can showcase.
Provide additional context.
Provide as much relevant context as you like.

Codecov Report

Merging #562 (42d9f5d) into main (b398a79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   89.59%   89.59%
=======================================
  Files         146      146
  Lines       11548    11548
=======================================
  Hits        10346    10346
  Misses       1202     1202

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Noob Help :(

I'm trying to insert a Combo into the login screen and after the login, redirect to diferente pages depending the option choosed, how to do this ?
Sorry for not having greate skills as you guys...

You can modify the login screen files under Modules > Membership > Account
Also, you'll need to modify LoginPanel.ts around these lines to adjust where you are sending the user. I have not done this, but this is where I would start. The more experienced guys may jump in here and give you much more guidance.
this.byId('LoginButton').click(e => {
                e.preventDefault();

                if (!this.validateForm()) {
                    return;
                }

                var request = this.getSaveEntity();
                Q.serviceCall({
                    url: Q.resolveUrl('~/Account/Login'),
                    request: request,
                    onSuccess: function (response) {
                        var q = Q.parseQueryString();
                        var returnUrl = q['returnUrl'] || q['ReturnUrl'];
                        if (returnUrl) {
                            window.location.href = returnUrl;
                        }
                        else {
                            window.location.href = Q.resolveUrl('~/');
                        }
                    }
                });

            });

Use slack for non bug related questions.

Thanks will try to implement it.


Support for Django 2.0 and Python 3.6

Hi, I found that the main issues were:

deprecation of MIDDLEWARE_CLASSES setting variable in Django 2.0
is_anonymous now is a property, not a function
conversions from bytes to unicode from requests responses.

I also reconfigured the tests config files to be able to run tests on Travis for Python 3.6 and Django 2.0.
Here the results: https://travis-ci.org/rafen/drf-tracking/builds/346883235
But I dropped test support for Python 2.7, Django < 2.0 and DRF < 3.7
So please feel free to use this PR o close it and use it as a reference for changes.
Thanks for the all the good work of this repo 👍

Hey, I wanted to know, you had to drop old tests because of the incompatibility?
Even if I like the idea of moving on, I'm not sure we can drop those tests like that. I mean there is still people using py2.7 and django<2.0

I drop the tests because I'm short on time and some of them were failing, maybe something simple to fix.
If I have more time I will try to push another PR.

Okay, this PR is from February, now we have October, any news regarding this? @triat

@josefkorbel I actually did a PR recently, which was merged and I've updated as much as I could to be compatible with Django 1.11 / 2.0 / 2.1. I guess it should work fine. Maybe you can try to pull it from master until @avelis create a new version.
Let me know if there is something not working as expected

@triat Awesome, good work. I actually have to wait for proper pypi release as I am using this inside a docker container and I dont want to mess with SSH inside it. Will try from source as soon as I will have some free time, just to confirm it is working.

you know that you can also install it from the source with -e git+https://github.com/aschn/drf-tracking@master#egg=drf-tracking and you can even put this line in your requirements file, it will be taken in account like if it was a pypi. So you won't have to mess with your SSH and docker ;)

I apologize for not creating a new release. Been recently stretched thin way too thin to help. But I want to get another release out as soon as possible.

Is this PR bringing something knew on master now ? I'm not sure if we should keep it or not


it does not detect RF signal

Check that the CE and CS pins are connected to the correct hardware pins.


Add exceptions

Do you mean, to the computation system?

Yes. We probably have to wait for @ecavallo's Immortal account of partial functions to fully utilize them, but we can prepare ourselves before that.

I love it! We can use it to realize continuity principles... and maybe Markov’s principle?

On Feb 21, 2018, at 2:52 PM, favonia<EMAIL_ADDRESS>wrote:
Yes. We probably have to wait for @ecavallo's Immortal account of partial functions to fully utilize them, but we can prepare ourselves before that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


[Feat] - Get tags of VM from vSphere SDK Client

With the previous code, the tags did not appear when I did the salt-call vmware_vm.info <minion> command.
By adding the vSphere SDK Client, the tags are ok in the return of the command.
Important: it is mandatory to install the new dependencies.
pip3 install --upgrade git+https://github.com/vmware/vsphere-automation-sdk-python.git

@oijkn thanks for the PR!
I was under the impression that tags were get-able with our current approach but maybe that's a specific version of vSphere or something.
A couple of things - first, tests are required for all code contributions. Meaningful unit tests are fine, but unit+integration are better. If you need help with writing tests - attend one of the Test Clinics on Twitch, and we'll be happy to help you get started :+1:. We also want a changelog entry
But more importantly, the vSphere SDK is a very finicky dependency. It has a known issue about pip-installing for a very long time. Almost a decade long.
I've seen that dependency cause a number of issues in upstream Salt, which gives me very very strong reservations about making it a dependency of our project.
I'm OK with making it an optional dependency that's basically completely isolated. Something to this effect:
import utils.vsphere_sdk

...

    tags = utils.vsphere_sdk.get_tags(vm)

Then it could do something like this:
try:
    from com.vmware.vapi.std_client import DynamicID
    HAS_VSPHERE_SDK = True
except ImportError:
    HAS_VSPHERE_SDK = False

def get_tags(vm):
    if HAS_VSPHERE_SDK:
        try:
            vm_mid = vm._moId
            ...
            tags = [client.tagging.Tag.get(tag).name for tag in tags_list]
        except Exception:  # not sure if this try/except is necessary
            tags = []
    else:
        tags = [tag.name for tag in vm.tag]
    return tags

The create_vsphere_client would also need to be similarly protected. Honestly, I wouldn't put the api_client in connect - I'd keep it completely isolated in the vsphere_sdk module. That's just because of the number of issues I've seen using the SDK.
If we can't get the tags any other way :shrug: we can go ahead and provide the ability here. But if someone can't install the SDK, or it gives some issues, then we shouldn't be broken -- we should just carry on as normal, though we can log at an info or warning level or something, if that's useful.


Basic setup for windows

This issue: https://github.com/axitkhurana/buster/issues/56 so we won't spam in that repository.
@sebie: Yeah, it seems RSS is totally messed up - all links are missing base url, gotta fix that. I basically done everything LeftOrNull done on latest buster version, disabled rewrite wget flag, and added os.remove for duplicate files. Nothing creative on my part
I got it working like this:

Create main folder, with src subfolder containing ghost. Run the ghost on default host and port, so you don't have to add any flags.
Make the main folder your CWD.
If you want to deploy run python buster.py setup - and set your github repo ssh (not https if you're using ssh-agent), now you should have folders src and static - in static one there's your cloned repo.
Run python buster.py generate - if you're running default host:port combo of course
Now if you run buster preview on localhost:9000 you should see everything working
Deploy if you want

Sorry for writing obvious things, for example I was stuck on the static folder as I thought buster needs some additional working dir for its internal files... If you still have missing assets, show us your output log

Fixed RSS with https://github.com/Misiur/buster/commit/7613143daf1d6bb6e64afae6da384702610534ba, but remember to change url in your config.js, so RSS has absolute paths.

Going to try this now. Will update you.

Update #1

What is CWD? Tried using my Google-Fu skills and found a few things, but nothing relevent to the context.
Default ports, is that <IP_ADDRESS>:2368 ?
Folder structure please? It is a bit confusing.

Sorry for my understandings.

Oh, sorry: Current working directory.
Port 2368
It doesn't matter where is your ghost, as this will download all files via <IP_ADDRESS>:2368.
So, if you are in any folder, after running buster setup folder static will be created

Ok, thank you! (And awesome responce time :smile:).
Will update you again, shortly.

So:

Firstly, I updated it to the newst version (yours) -- the one with the RSS fix
When I preview it, it looks fine (with a few url problems), when the static files looks broken if I just click on them?

I don't quite follow you on that. You mean if you access them via file:/// url? Then it will be broken. Run buster preview and check out localhost:9000 to see how it will look like. Also, in your config.js did you set the url you want to be final?

Sorry. What I was trying to say is when Ii run buster preview (after using buster generate) It looks fine, with the exception of the "RSS" link and the "back".
The:
Production URL is -- "sebie.github.io"

Sorry, missed notification mail - in your theme you have to replace links ending with "/rss" to "/rss/index.rss". I don't see "back" in my theme (standard casper one). Where is it located?

The "back" button; was located on the top left side of a post. If click it would redirest you to the homepage.
Are the URL's listed above correct?

Ok, you have now two options:

Set up development url to sebie.github.io (leave the server set to <IP_ADDRESS>)
Set up ghost production config. So, before running buster generate you'd have to use npm start --production.
To be honest I'm using the 1st option and works nicely

Ok lemme try option 1.

Wonderful. Yeah, your RSS link looks now like http:///rss/. Really weird. Could you show me how does that link looks in ghost?

This is my index.hbs.

(Prepare for a long paste):
`
{{!< default}}
{{! The tag above means - insert everything in this file into the {body} of the default.hbs template }}
{{! The big featured header }}

        {{#if @blog.logo}}{{/if}}
        Subscribe

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Scroll Down

{{! The main content area on the homepage }}

{{! The tag below includes the post loop - partials/loop.hbs }}
{{> "loop"}}

`

Change it to<EMAIL_ADDRESS>and it will work

Sorry for the late reply, it got buried in my inbox.
Update you soon.

Yup, anywhere where rss link is. I think I'll add that to buster script.

Ok, tell me if you do. Because then I would have to update buster.
(Btw; buster update?)

Ok, pushed https://github.com/Misiur/buster/commit/150cad19cd294df48506421bb15f4bbb995731f2 (fixes rss link in  as well). Unfortunately I have no idea how to work with PyPI and forks... I have my repository cloned, and copied (symlinked to be exact, but it's not required) my buster.py file to where I want to use it. Sorry about that.

Oh, dw about it. Atleast it works.

Also, do you want clean up the Readme so it has the original, but also a description for your modification of it?

It seems you can install stuff using pip via url, so first uninstall old buster using pip uninstall buster, and then run pip install git+https://github.com/Misiur/buster - and it just works like that!
Hm, maybe when I have spare few minutes.

Nice change. And ok will do the update like you said. Thanks!

Everything is working and thank you for the help. I will open an issue if anything messes up or if I have any ideas / suggestions.

You're welcome. If you see some better fork/project - tell me, I would like to use it too :D

Deffenitly, but for now this seems to be the best working (out of the box) version!
THank you once again!

BTW, how to fix the icon-font of the blog? And the static files of the articles do not work.

Do you have "/assets/fonts/casper-icons.woff" in your scraped version?

@Misiur Yes.
BTW,
Just the featured image of the article and the icon-font do not work.

Alright, if you are using chrome go into dev console -> Network tab -> Filter -> fonts - then take a screenshot and show it here (from scraped version, not the one running in node)

@Misiur
The Ghost that I'm using is the Chinese-simplified one. And there aren't anything in the /assets/fonts folder.
Also, the featured image I set for the article either work well.
Here's the screenshot that I used your buster:

I also use the origin Ghost. Its problem is the same as the Chinese-simplified one.

But I can manually copy the origin /assets/fonts folder to the one in the static folder. And it worked. Also the feature image set for the article.
It seems it's a problem about absolute path and `relative path· I guess.

Yeah, now I tried on fresh build and have the same problem. It seems I copied the manually on my blog earlier and forgot. Moved to #3


[PDI-1495] Implment WebServerShutdownHandler to allow unit tests to disa...

...ble system.exit on server shutdown

Looks good. Just add some javadoc on the interface at least. Thanks!


fix: Ensure Dev*,Microcom and Build Task are builds before Controls

What does the pull request do?

Ensure Dev*,Microcom and Build Task are builds before Controls when build solution in IDE
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0026200-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0026236-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0026251-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Escape image source in resize helper.

@LtSquigs you want to sanity check this one?

Uh this should work, assuming its not escaping the http://www. parts of it or the URL string

Then we should be fine.

Replaces &, <, >, ", ', ` with the HTML entity equivalent value for string values.

http://handlebarsjs.com/reference.html


A lot of empty space in settings pages when viewed on large monitor

I think the image says it all. Right now I am working on an 34" 2560x1440p monitor and the settings waste tons of space.
Would it be possible to have an alternate view once the screen exceeds a certain size? This issue has bugged me with most UWP apps in the past.

@R3voA3 There are plans to add tips and useful information on the settings page in the future but even with that, there will still be a lot of empty space. One possibility is to display a content dialog for the settings page on large displays.

@R3voA3 There are plans to add tips and useful information on the settings page in the future but even with that, there will still be a lot of empty space. One possibility is to display a content dialog for the settings page on large displays.

What about dropping the list on the side on larger display and put the options into a gridView?

What about dropping the list on the side on larger display and put the options into a gridView?

I told Yair already to use a dialog or panel but the design trend seems to be to use full-screen settings pages which waste too much space even if you add content on the right like links. Take the settings app as an example. In my app, I use multi-column layouts on larger displays but don't know whether Files would accept it.

I told Yair already to use a dialog or panel but the design trend seems to be to use full-screen settings pages which waste too much space even if you add content on the right like links. Take the settings app as an example. In my app, I use multi-column layouts on larger displays but don't know whether Files would accept it.

Instead of separate pages with a navigation view, we could use a multi-column layout will all settings on one page

Instead of separate pages with a navigation view, we could use a multi-column layout will all settings on one page

Instead of separate pages with a navigation view, we could use a multi-column layout will all settings on one page

Yes, I like the idea. I have seen that in some other app and it's much better

Instead of separate pages with a navigation view, we could use a multi-column layout will all settings on one page

Yes, I like the idea. I have seen that in some other app and it's much better

Another option could be to display Settings in a pane when the window is particularly wide.

Another option could be to display Settings in a pane when the window is particularly wide.

This issue should be resolved with #5077.


add some test case for sum2 function.

如果是文字类 PR，请按照 中文排版指北 进行编写(提交时可删除该提示)。
What kind of change does this PR introduce? (check at least one)

add some test cases.

The description of the PR:
I've added some test cases for sum2 function :).
Other information:

No need for test code.


How to extend for user profile

Hi great work you did already.
What I am missing is a way to ask user for firstname, lastname, etc... during signup and store these values in his profile.
I already figured out how to add the appropriate fields in the signup form like this
class NewLogin extends Accounts.ui.LoginForm {
    fields() {
        const { formState } = this.state;
        if (formState == STATES.SIGN_UP) {
            return {
                firstname: {
                    id: 'firstname',
                    hint: 'Enter firstname',
                    label: 'firstname',
                    onChange: this.handleChange.bind(this, 'firstname')
                },
                ...super.fields()
            };
        }
        return super.fields();
    }
}

But i cannot figure out how to get them into the options Object when calling the createUser method in line 451 of the LoginForm
Accounts.createUser(options, (error) => {
Can you give advice on it if possible at all or add a possibility for it.
Thx in advance

I've have some thoughts about this, the issue in hand is that I'd like this to tie together with a SimpleSchema on the "users" collection, but if you have a strong argument for it not to tie together, I might change my mind.
Though you're almost there with your solution, you probably want to use one of the hooks to set the data on the user correctly, have a look at the preSignUpHook in accounts_ui.js – I haven't had time to document all the hooks yet.
Tell me how it goes.

The implementation should work just like UserAccounts preSignUpHook, but I have also not yet tested to add extra fields, which I have in my backlog.

I've published a new version that supports extending the options (release-1.0.10)
How about something like this:
class NewLogin extends Accounts.ui.LoginForm {
  fields() {
    const { formState } = this.state;
    if (formState == STATES.SIGN_UP) {
      return {
        firstname: {
          id: 'firstname',
          hint: 'Enter firstname',
          label: 'firstname',
          onChange: this.handleChange.bind(this, 'firstname')
        },
        ...super.fields()
      };
    }
    return super.fields();
  }

  signUp(options = {}) {
    const { firstname = null } = this.state;
    if (firstname !== null) {
      options.profile = Object.assign(options.profile || {}, {
        firstname: firstname
      });
    }
    super.signUp(options);
  }
}

Could you confirm that that works, and I'll adjust the new example in the README.

@radzom when you confirm, I'll close this.

thx for fast response. looks promising. will test it and give feedback later today.
And preSignUpHook was also the way for me to go.

works fine for me.
Just one final remark. I am using  (on server)
import { Accounts } from 'meteor/accounts-base';

Accounts.onCreateUser(function (options, user) {
  user.profile = options.profile || {};
  user.roles = {};
  return user;
});

No need for me to use preSignUpHook.
Issue can be closed

Perfect, I'll add it to the docs.


Fix some subtle bugs in the recent improved basic block alias analysis.

The temporary coalescing has always relied on the assumption that temp
lifetimes can simply be compared for overlap in their min/max
instruction numbers, and this is only possible if their lifetime
doesn't cross a loop boundary. As long as temporaries are restricted
to live within one basic block, this is safe -- and they do so as a
natural consequence of how they are created and used. EXCEPT that as a
result of the new analysis, their values could end up being used
outside their original basic blocks, and then could be inappropriate
coalesced. Oops.
The easy fix for this one is that when we save and restore the alias
list, we exclude temporaries from the copy. The fix is in the
implementation of copy_block_aliases.

There are a couple circumstances in which code transformations call
block_unalias() to say that a block-local symbol alias is no longer
valid. The implementation just looks up that alias and removes it from
the list. EXCEPT... now there is not just one list, but also the ones
in the outer recursive scope. Oops.
The fix here is that we keep track of a stack of such scopes, and
bock_unalias walks up the stack and removes the alias from callers as
well.

There are a couple minor odds and ends, mostly slight renames and
comments and clarifications.

This is a critical fix, so I'm going to merge it without review (perhaps for the first time violating my rule) because everybody else is on vacation and I need to make a fixed build available for production. We can always patch again on Monday if somebody catches something in the review after the fact.


Fixed #25569 -- Improved error message for select_related

Improved the error message when a select_related call is made with a
reverse relational field. If there is at least one reverse relational
field amongst the fields given to select_related, the error message is
improved.

The message could be misleading because single-value reverse relations such as OneToOneField may be used. That's why I was getting at with the suggestion of "Non-single value relation given in...".

Closing per ticket.


[6.2.0] Unable to bypass insecure certificate warning with Firefox

I don't seem to be able to ignore any certificate warnings using the Firefox driver. Is this unexpected behavior, or am I just not using the API properly?
Example code:
require 'watir'

profile = Selenium::WebDriver::Firefox::Profile.new
profile.assume_untrusted_certificate_issuer = false

browser = Watir::Browser.new(:firefox, :profile => profile)

browser.goto 'https://self-signed.badssl.com/'

Unexpected result:
/Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/response.rb:69:in `assert_ok': Selenium::WebDriver::Error::UnknownError
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/response.rb:32:in `initialize'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/http/common.rb:83:in `new'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/http/common.rb:83:in `create_response'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/http/default.rb:107:in `request'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/http/common.rb:61:in `call'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/w3c_bridge.rb:620:in `execute'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/remote/w3c_bridge.rb:126:in `get'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/selenium-webdriver-3.3.0/lib/selenium/webdriver/common/navigation.rb:32:in `to'
	from /Users/bshannon/.rvm/gems/ruby-2.4.0/gems/watir-6.2.0/lib/watir/browser.rb:78:in `goto'
	from /Users/bshannon/Desktop/test.rb:8:in `<main>'

Environment:
Watir 6.2.0
Selenium Webdriver 3.3.0
Geckodriver 0.15
Firefox 52.0
Mac OSX

Thanks

It's done differenently in GeckoDriver:
caps = Selenium::WebDriver::Remote::Capabilities.firefox
caps['acceptInsecureCerts'] = true
driver = Selenium::WebDriver.for(:firefox, desired_capabilities: caps)

Thanks. This was very helpful

Thanks.


Gateway Hosts Don't Match If Host Headers Include Port Number

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
A Gateway object's hosts list doesn't match against host headers that include a port
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Either the list of 'hosts' should match against just the host portion of the header, or the user be allowed to specify host entries with ports included.
Steps to reproduce the bug
This can be reproduced with slight modifications to the httpbin tutorial example. I did everything according to the tutorial, except in my environment I can add a DNS alias to my $INGRESS_HOST. I updated the Gateway and VirtualService objects to use that alias rather than the 'httpbin.example.com' one, so both of their host entries look like:
  hosts:
  - hostname.company.com

...where hostname.company.com is an alias to the $INGRESS_HOST. Also note that in my environment I don't have a functioning LoadBalancer, so I'm forced to use the $INGRESS_PORT
(31380 default). I can then perform the following two curl calls:
# curl -I -HHost:hostname.company.com:80 http://hostname.company.com:31380/status/200
HTTP/1.1 200 OK

# curl -I -HHost:hostname.company.com http://hostname.company.com:31380/status/200
HTTP/1.1 200 OK

All is well. However, the following does not work:
# curl -I -HHost:hostname.company.com:31380 http://hostname.company.com:31380/status/200
HTTP/1.1 404 Not Found

How do I make the 31380 port work? Things I tried:

Set the 'hosts' value to '*'. This works, but obviously undesirable
Add a hosts entry to the Gateway such as 'hostname.company.com:31380'. This is rejected as an invalid domain name.

The host header that includes no port makes sense that it works. However, the host header that includes port 80 seems to be treated as special. Why does that match on the hosts list, while the header that includes a non-standard port doesn't?
Version (include the output of istioctl version --remote and kubectl version)
kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.2", GitCommit:"66049e3b21efe110454d67df4fa62b08ea79a19b", GitTreeState:"clean", BuildDate:"2019-05-16T16:23:09Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.2", GitCommit:"66049e3b21efe110454d67df4fa62b08ea79a19b", GitTreeState:"clean", BuildDate:"2019-05-16T16:14:56Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
istioctl version --remote
client version: 1.2.0
citadel version: 1.2.0
galley version: 1.2.0
ingressgateway version: 1.2.0
pilot version: 1.2.0
policy version: 1.2.0
sidecar-injector version: 1.2.0
telemetry version: 1.2.0
How was Istio installed?
Used helm to install the 1.2.0 release, default configuration
Environment where bug was observed (cloud vendor, OS, etc)
On premises install on RHEL 7.6 VMs
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Maybe related, I think right now port 80 is a special case: https://github.com/istio/istio/pull/14346. @mbanikazemi what is the status on that pr? https://github.com/istio/istio/issues/14033

host in gateway i think is been ignored as seen on #15262
I'm hitting this issue also.
Has some one been able to filter  directly by Host header ? would that work?

host in gateway i think is been ignored as seen on #15262
I'm hitting this issue also.
Has some one been able to filter  directly by Host header ? would that work?

Is this issue still on track with 1.4 release ?


Integrate Chroma with LlamaIndex.TS

Should be pretty easy https://github.com/run-llama/LlamaIndexTS/blob/main/packages/core/src/storage/vectorStore/SimpleVectorStore.ts
This is a great first issue and a great chance to contribute to multiple projects.

Hey, I would like to try to solve this issue.

thanks @abhishek7kalra for taking a crack at this

@abhishek7kalra still taking a crack at this? otherwise ill free it up

Yes please, go ahead @ryanrudd
I am really caught up right now, will pick up another issue. @jeffchuber
Thank you :)

Hey, @jeffchuber What changes need to be introduced on Chroma's side? If I understand correctly, this requires adding a new vector store a la llamaindex/packages/core/src/storage/vectorStore/ChromaDBVectorStore.ts
do you think of doc updates or adding integration tests, perhaps?

good news! this is almost done https://github.com/run-llama/LlamaIndexTS/pull/300 , thanks to @aaravnavani !

this is now complete


Amplify Hosting {"code":"7","message":"No ssrResources.json file"}

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
No response
Region
us-east-1
Amplify Hosting feature
No response
Describe the bug
Hello, I have a Next.js app that we are hosting via amplify.
We are trying to deploy the next.js app as an SSG (Next.js - SSG) and we followed the guidelines outlined in the following docs:
https://docs.aws.amazon.com/amplify/latest/userguide/server-side-rendering-amplify.html#deploy-nextjs-app .
From the article above ^ we did the following to our package.json for the amplify build to recognize our app as a Next.js SSG:
...
"scripts": {
"dev": "next dev",
"build": "next build && next export",
"start": "next start"
},
...
we, furthermore, set the base directory to "out" in the amplify.yml as such:
...
artifacts:
baseDirectory: out
...
And although the build phase seemingly  creates the SSG components the  deploy phase FAILS with the following
2022-05-26T16:38:09 [INFO]: Cannot find any generated SSR resources to deploy. If you intend for your app to be SSR, please check your app Service Role permissions. Otherwise, please check out our docs on how to set up your app to be detected as SSG (https://docs.aws.amazon.com/amplify/latest/userguide/server-side-rendering-amplify.html#deploy-nextjs-app )
2022-05-26T16:38:09 [ERROR]: {"code":"7","message":"No ssrResources.json file"}
Expected behavior
The next.js app is deployed successfully.
Reproduction steps

Run the build
Notice that the deploy fails

Build Settings
frontend:
  phases:
    preBuild:
      commands:
        - yarn install --frozen-lockfile
    build:
      commands:
        - echo 'running build'
        - yarn build
  artifacts:
    baseDirectory: out
    files:
      - '**/*'

Additional information
package.json scripts;
"scripts": {
"dev": "next dev",
"build": "next build && next export",
"start": "next start",
}

Hi @rei-shaholli 👋🏽 It looks like you made the proper adjustments for an SSG app. can you provide your app ID so we can further investigate?

Hi @hloriana I actually got the deployment to build by running:
aws amplify update-app --app-id <APP_ID> --platform WEB --region
I had previously run this command and deployments were working fine, but I noticed that the app had gone back to being WEB_DYNAMIC (by itself?), so I re-run that command and now everything is working fine.  Just fyi!
Thanks for the response!
Rei


Comment the code more

make proper comments in the code...
(ಠ_ಠ) y u no comment, past self

was adding in the raw links feature and i'm like

i have no idea what this piece of code does

let's hope it works if i stuff it here

Not relevant when re-make happens.


After api.setFilterModel call, filterModel is reset immediately in Angular1

The behavior seems happening only when using with angular1, the native one seems worked fine.
Use serverSideFiltering, and call api.setFilterModel to filter the grid, and the filter worked and new data fetched and displayed, but immediately the internal filterModel is reset to empty object. So we api.getFilterModel() is called immediately, you can see it's being correctly set, but right after that, it's reset.
Here is a demo that reproduce this issue: https://jsbin.com/resume/edit?html,js,output

Seems related to this ticket: https://github.com/ceolter/ag-grid/issues/572

can you tell me what i am meant to be looking at in the fiddle?
when i click the filter button, it does filter, from your description i'd expect it to not filter???

Yes, it filters, but right after that, the api.getFilterModel is returning empty object, instead of persisting the filterModel just being set, because there's nothing else happening to reset the filterModel again, so the filterModel should stay as the new value.

how are you including ag-grid?
i see the piece that references the script is commented out

sorry, ignore, i see it
  <script src="https://cdnjs.cloudflare.com/ajax/libs/ag-grid/4.2.6/ag-grid.min.js"></script>

It was included after angular, initially I thought it was the enterprise version that might be the difference from our dev environment, so I left it commented out. But included the non-enterprise version, this is what we are using at the moment.

enterprise vs non-enteprise will make a difference, as the default filter is 'set' for enterprise, and 'text' for non-enterprise
anyway, am looking...

Right, this is why I tried my best to reproduce it without any of the enterprise feature, as close as to our issue. Thank you!

ok i have it, here is the workaround:
{headerName: "Make", field: "make", filterParams: {
      newRowsAction: 'keep'
    }},

basically, the grid is coded to clear the filters when you load new data. it's getting confused with the pagination and server side filtering, it thinks you are loading new rows.
still looking into it, but the above will get you unblocked

Great! Thank you so much, I'll go with that first and update the library later when totally fixed.

looking at the example online https://www.ag-grid.com/javascript-grid-pagination/index.php
it  uses newRowsAction: 'keep' there also, so that looks like the intended usage. can you advise if this is acceptable?
looking at it now myself, i'm not happy with it, but it is what it is. rather than spend 1hr on it now and hack something in, i'd rather keep this open and revisit next time we do a revision of this part of the code - where we will take a step back an improve the whole area at once spending a few days on it.

I think it will solve the problem that we had, and I'll put this newRowsAction: 'keep' as our default column definition.
Thank you for the help, I think we are good for now. You can close this ticket if you like.


25 add select modifications

add select/menu modifications #85

Elements in Select dropdown list are not highlighted when navigate through them using keyboard


Remove APP_RELEASE environment variable

This fixes #796

I have no idea why CI failed, I prefer to not log into ci.balena-dev.com.
Can somebody resubmit/merge this?

@chrisys done

@resin-ci retest


When a component is removed from the UI (click x on top right) the viewport is disabled, should probably be removed

Bug Report
When a component (which is attached to a server side viewport) is removed by clicking the X on the screen, the server side viewport is set to .enabled = false. This will lead to an increase in the collection of viewports over time.
Steps to Reproduce:

Open grid against viewport
Remove grid
11:42:04.038 [nioEventLoopGroup-3-1] INFO  o.finos.vuu.core.CoreServerApiHander - View port disabled (log message will be written to console)

Expected Result:
Viewport deleted on server side (removed from collections)

Should be fixed if you want to try. Its in main


How to use this in HTML form input field?

Searched it but not knowing, to use MultipleDatePicker, in a form input field?

Hi,
nothing to do it, you'll have to do it by yourself with a popin or something alike ;)