[FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics

What is the purpose of the change
As consensus from community code style discussion, in InputGateWithMetrics#updateMetrics we can refactor to reduce the usage of Optional parameter.
cc @azagrebin
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for your review @azagrebin!
I'm not very sure about your addition. IMO it is good to separate code style changes with feature efforts. In your words it seems you also agree this opinion but there is an "although" and following this statement

The small code style improvements are not associated with any feature efforts and clutter the history which makes understanding the original reason for the code lines harder.

What best practice do you suggest here exactly? Could you explain a bit?

ping @azagrebin as a reminder :-)

Sorry @TisonKun something is messed up with my Github notifications :)

IMO it is good to separate code style changes with feature efforts. In your words it seems you also agree this opinion but there is an "although" and following this statement

I did not mean that we should separate code style changes with feature efforts. On the contrary, we usually avoid changes which are not related to some behavioural change, like feature or bug fix.
If you do a lot of changes to some method or class to actually change something in Flink behaviour like feature or bug fix, you can also refactor its code style. This kind of changes are interesting to follow in the git history (annotate lines in IDE: commit, who changed and why) and they have value to understand the code.
If you change just code style, nothing actually changes in Flink behaviour but you rewrite the git history for the changed lines. When somebody looks into the history of the changed lines, she is probably more interested in the previous changes and their description which is hidden after the code style improvement.
All-in-all, it is again a trade-off. We want to have a good code style in the code for readability. On the other hand, we want to have a clear git history for the same purpose of readability. We usually choose the git history over the minor changes like code style because the git history is more valuable for understanding. That is why we prefer not to do unrelated changes as well and do not refactor older parts of code without a related purpose.
Hope it helps.
cc @tillrohrmann @pnowojski


Fix broken links in contribute/server/developer-setup section

Summary
Fixed broken links in the /contribute/server/developer-setup section due to malformed Markdown syntax. The front matter for the affected pages was modified to be consistent with YAML as it is used in the rest of the site.

Hello @neflyte,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@azigler I only caught this locally after refreshing the page a couple times. :wink:
What's happening is the included content doesn't have its frontmatter removed before it's displayed. This is a known issue with Hugo. Luckily there are various solutions around; I was able to resolve this using a solution that simply removes the frontmatter.
I'll make that fix and test a few more pages.

Even better: I don't need to fix how the content is included as I simply removed the frontmatter from that set of included content. The frontmatter, it turns out, exposes the page in the LHS as well and that's undesired in this case.
For reference, there are 2 sections that import content from other files:

/contribute/server/developer-setup
/contribute/desktop/developer-setup


Adding Resolution Paths during appdomain creation (Compatibility Isuue)

Scenario which was broken -
If suppose TestProject has a config file having assembly binding redirect of System.Runtime to 4.1. Our TestAdapter which has a dependency of System.Runtime of 4.0, uses the above config file and tries to load System.Runtime 4.1. Since assembly resolver was not set at the time of loading of adapter, it is unable to find 4.1 version of assembly and bombs.
Fix - Adding resolution paths at the time of creation of appdomains.
Validations-

2 Projects having different adapter versions works fine with enable and Appdomain
Above scenario.

@dotnet-bot Test Windows / Debug Build please

Fixes https://github.com/Microsoft/testfx/issues/384 and https://github.com/Microsoft/testfx/issues/356


Error: [clean] Received one or more unexpected parameters: encoding=utf8

Hello,
When launching any of the bash scripts commands ./generate_geojson.sh or ./generate_topojson.sh it returns me the following error:
Error: [clean] Received one or more unexpected parameters: encoding=utf8 Run mapshaper -h to view help
These are my settings:
OS: Ubuntu 22.04.4 LTS
Mapshaper version:  0.6.65
Node version: v18.13.0

The problem seems to lie with the mapshaper version. In the 0.6.65 version encoding is not an option of parameter -clean but of parameter -i
I have prepared a PR to fix this: https://github.com/openpolis/geojson-italy/pull/20
I have also updated README to pinpoint the mapshaper version in use

Hi Armando, just merged your PR today. Thanks!


Android Basics: Get data from the Internet

name: Android Basics Unit 4 issue
about: Report problems with the Android Basics Unit 4 codelabs
title: 'Android Basics Unit 4 issue:'
labels: ''
assignees: ''

URL of codelab
In which task and step of the codelab can this issue be found?
Describe the problem
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

If you don't mark the api function as suspend it throws an error


C#8 Nullable ref types - returnUrl field is required

Moved from https://github.com/dotnet/AspNetCore.Docs/issues/17145 by @djhmateer
When scaffolding out the Identity code and I have C#8 nullable ref types checking set in the .csproj
<Nullable>enable</Nullable>

I need to change the methods which have a default value set to null eg
public async Task OnGetAsync(string returnUrl = null)

to be a nullable string ie string? otherwise, the UI will set ModelState error giving returnUrl field is required

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 804e24dd-7e30-8cf5-2c99-1ffacb4582f6
Version Independent ID: 3e25547b-e2c9-6634-2c38-2a77207f17d4
Content: Scaffold Identity in ASP.NET Core projects
Content Source: aspnetcore/security/authentication/scaffold-identity.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Similar thing happens inside ExternalLogin.cshtml.cs where the user receives the message "The remoteError field is required." on page visit.


Updating SDK to 8.0.200

cc: @jaredpar @tlmii
Some people are having issues building the repo in VS Int Previews that have newer versions of Roslyn. After investigating, this is expected given that the version of Roslyn there is two versions ahead than the SDK we have in the repo (8.0.101). For this reason, this is bumping the version of the SDK we use, which should fix that issue.
Microsoft Reviewers: Open in CodeFlow

@MichaelSimons is the source build issue a known issue?

Will this cause any issues for external folks? Could we instead configure it to roll-forward to latest feature or major?

Isn't 8.0.200 in 17.9 preview? (which is required for working with Aspire anyway)

The issue with Int Preview is that it is already in 8.0.300, and according to @jaredpar the issue folks are seeing there is due to the fact that the global.json listed in the repo is 2 version bands behind, but said 1 version behind should be fine, which is why I'm updating to 8.0.200

@MichaelSimons is the source build issue a known issue?

@joperezr, For general source-build issues like this, please ping the @dotnet/source-build-internal team for quicker responses. TIA.

@MichaelSimons is the source build issue a known issue?

No, this will need to be investigated.

What's the status of this PR? I just updated VS and now am getting the build error:
error CS8784: Generator 'RazorSourceGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'TypeLoadException' with message 'Type 'Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.HostOutputNode`1[TInput]' from assembly 'Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' is attempting to implement an inaccessible interface.'.

@joperezr - I tried using the SDK version you are using here 8.0.200-preview.24064.2 locally with:
Microsoft Visual Studio Enterprise 2022 (64-bit) - Int Preview
Version 17.10.0 Preview 2.0 [34607.46.main]

But it appears the version of the .NET SDK that comes with that is 8.0.200-preview.24060.48 (at least that is what I have installed in Program Files). Where did you get that build number?

I just ran the command dotnet-install.ps1 -DryRun -Channel 8.0.2xx -Quality Daily to get what the latest version of the sdk from the 8.0.2xx band was.

I just ran the command dotnet-install.ps1 -DryRun -Channel 8.0.2xx -Quality Daily to get what the latest version of the sdk from the 8.0.2xx band was.

That will force everyone to do the same thing. Can we instead use the version that VS brings with it?

That will force everyone to manually install the SDK version. Can we instead use the version that VS brings with it?

Which VS? 8.0.200 will ship till next week so there is no publicly available VS version or SDK yet. We may just want to wait till then to fix this. In the meantime, folks in VS versions that hit this issue may want to try the workaround of using the PackageReference to the Compilers.Toolset package.

Which VS?

Int Preview? Whatever we are telling developers to use? What VS are you using?

It looks like IntPreview has 8.0.300 in it now. If you launch VS directly and don't use .\startvs, this issue doesn't seem to occur. Launching with .\startvs still causes it (because it picks up your local dotnet install from global.json I believe).

Which VS?

Int Preview? Whatever we are telling developers to use? What VS are you using?

8.0.200 is shipping next week. Let's just wait till next week once we have a stable version, and then jus update our global.json then. We then will recommend folks working on the Aspire repo to use VS 17.9 or newer (meaning 17.10 Preview versions)


Xnero: Watch tccons.ae

Xnero requests the watch of the watch_keyword tccons\.ae. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tccons\.ae has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


[Enhancement] Asset Mapper should provide all assets names

Asset Mapper only contains today a part of the assets (mainly the spectral bands) for some collections.
If a collection is given, and to work perfectly with new filter functions from SkyFox (EDS), it should be able to convert each common name to the asset name.

Solved in d0c98060efba910526120d8fc9840da4561672ea


CLI progress/activity indicator

This implements a progress/activity indicator for commands that take longer than a couple of seconds.
Please feel free to comment or push against this PR's branch if you think the code needs improvement in some way or another.

Related to #230
cc: @ahmetalpbalkan @ehazlett @nathanleclaire
Signed-off-by: Jan Broer<EMAIL_ADDRESS>

Pretty interesting patch.  I will check it out soon.

I think we should keep the intermediate steps instead of removing them and using only one line. "Docker pull" also has an animation but at the end you see what's happened on each line (i.e. what layers are downloaded). In this case providing more info about the steps can be better IMO.

+1 @ahmetalpbalkan ... the more info, the merrier.

@ahmetalpbalkan Yeah, we can keep those lines and prefix them with a "+" or similar.

:heart_eyes:
+1 @ahmetalpbalkan

+1
Awesome user experience!

@zchee  :stuck_out_tongue:

@janeczku any plans to move this forward? looks really cool.

@ahmetalpbalkan, the patch is functional as is. Whether it gets moved forward is not really my call: @nathanleclaire @ehazlett

Sorry to be the difficult one here, I appreciate the work, but I think it is best for us if we keep our logging / terminal handling as simple as possible.  However, the good news is that a lot of the work I've been doing with libmachine should make creating your own Go wrapper to do whatever fancy tricks you want with the output a lot easier.

:+1: :clap:

@nathanleclaire, i appreciate your explanation and where you are taking libmachine with the new API capabilities :+1:
I do  however disagree with the characterization of this PR as "fancy trick". I don't think this is a fair characterization of what this patch actually implements: Satisfying a basic principle of UI design.
Currently there is a lack of feedback during long running commands in docker-machine: Often the CLI will just sit there for 10 seconds or even half a minute and longer after the user issued a command -  leaving the user to wonder whether the app has hung-up.
UI Design principle No. 1 according to Jakob Nielsen

Visibility of system status
The system should always keep users informed about what is going on, through appropriate feedback within reasonable time.

That being said, I am sure there are different and maybe better ways to tackle this UX issue than what constitutes this particular PR. I just wanted to stress that there is need for something like this.

That being said, I am sure there are different and maybe better ways to tackle this UX issue than what constitutes this particular PR. I just wanted to stress that there is need for something like this.

I agree, and I think it would be better addressed by a simpler method such as printing a . periodically while waiting for SSH and a o while waiting for the Docker daemon (similar to how b2d-cli worked), and/or printing messages to indicate "This may take a few minutes" where relevant.  Because the Machine CLI and log need to work flexibly in a variety of different situations and OSes, I'm wary of introducing too much complexity.


[BUG] Cannot jump when stamina is disabled in config

Describe the bug
I disables stamina in the config files, and yet in a survival world I often find I cannot jump
To Reproduce
Steps to reproduce the behavior:

Change stamina settings as follows `"stamina settings" {
# Determines if the player will be punished with a slowness effect when stamina bottoms out.
# DEFAULT: TRUE
B:"Apply Slowness On Depletion"=false
     # Determines whether or not stamina will be disabled when on the peaceful difficulty.
     # DEFAULT: FALSE
     B:"Disable Peaceful Stamina"=false

     # Determines whether or not stamina will be disabled.
     # DEFAULT: FALSE
     B:"Disable Stamina"=true

     # Change the amount of stamina that each action takes.
     # To modify an action, fill a new value into the array with the format of {ACTION}:{STAMINA_REQUIRED}
     # Negative numbers are accepted.
     # List of applicable actions: JUMPING, RUNNING, MINING, ATTACKING
     # Enter a range between -100 - 100
     S:"Stamina Depletion" <
      >
 }`

Jump around a bit in a survival world

Expected behavior
I should be able to jump
Details:

OS: Windows 10
Minecraft Version: Forge 1.12.2
Mod Version: 1.1.602

Thank you for your report. I will investigate the issue and make a patch as soon as possible. If you have more information you can add, or additional bug reports, please feel free to post them.

I have identified the issue. If you're curious it's a result of canceling the jump before checking any special conditions.
See Below:
https://github.com/matthe815/matthews-difficulty-mod/blob/eeda99311c259a6ddf74c8f57a5b247fe608eda5/src/main/java/difficultymod/events/LivingEvent.java#L164-L169
I will soon roll out a patch for this issue.

This bug is now fixed and pushed to the master branch. Thank you!

Please add this patch for the next release of this mod


added prefix 51 - Hashed Systems

Some initial docs here if helpful on the background: https://hashed.systems/hashed-chain/

@3yekn please merge master


test bug, ignore

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps and/or AL code to reproduce the behavior:

Go to '...'

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions:

AL Langauge:

Business Central:

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from build number TEST.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://blogs.msdn.microsoft.com/freddyk/2018/04/16/which-docker-image-is-the-right-for-you/

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from build number TEST.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://blogs.msdn.microsoft.com/freddyk/2018/04/16/which-docker-image-is-the-right-for-you/


exclude "<" and ">" from file path detection

Exclude both < at the start and > at the end from filepath detection.
See this screenshot.

The file path is detected but includes the surrounding angle brackets. Doing a Ctrl+click to go to the file causes it to not be found. If one removes the angle brackets from the search manually, then it finds the file.

Weird... 🤔
Yes, it is.
I'm using latest version of vscode (1.76.2) and the integrated terminal is running zsh, on macOS.

Can you try using the Insiders build here? https://code.visualstudio.com/insiders

Sure. Just for completeness, even if I pass the actual relative path, it doesn't work. See the screenshot (still using stable).

Can repro on macOS 👍


Proposal: Promote date, time, and datetime to type so format becomes usable for them

One shortcoming of the type and format options relates to dates and times. Currently, I need to specify type: string and a format of either date, datetime, or time. That's great that we can specify those values, but there is nothing that allows me to specify to my API users what date or time format we use. Is it a unix timestamp, or ISO 8601, or MySQL format, or....? Are timestamps included? Do we cut off times at the minute, second, millisecond?
Every modern language has a whole library for dealing with the complexities of this because it's not trivial. But, in OpenAPI, all I can do is say it's a date, and it's up to you to figure out how it's formatted. I can provide an example, but that doesn't help much with validation and tooling. My best option is to stick a pattern in there, repeat it for every date in my app, and hope users recognize the regex as "Oh, that's ISO 8601."
I'd propose that date, datetime and time be promoted from formats to types in their own right, such that format becomes viable. Common formats can be provided for in the same way that formats for things like email and uuid are today, and for anything not covered by one of those constants, a format string similar to what language libraries use could be employed. This could then be supported by tooling for more flexible validation.
Examples:
type: datetime
format: iso8601

type: datetime
format: "H:i:s A F j, Y"

Those formats have strict definitions: they don't just mean "a timestamp in any format". ref. https://json-schema.org/draft/2020-12/json-schema-validation.html#section-7.3.1
If you want to allow a timestamp in a different format, you can use a regex, e.g.
components:
  schemas:
    mysql_datetime:
      type: string
      pattern: ^[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}$

The idea of specifying a custom date-time format is an intriguing one; the place to explore that would be in a custom JSON Schema library, at https://github.com/json-schema-org/json-schema-vocabularies.

"type" keyword (almost) means JSON types, adding additional ones will add more burden on implementations. It kinda sorta works for "integer" because it's easy to differentiate it from a float in any language, but the meme strings like date will only contribute to interop issues.
And don't return formatted strings in your endpoints, just return an ISO 8601 datetime string with a timezone and let the formatting decision on the consumer.

I think the explanation from @karenetheridge  (thanks!) answers the question here such that further changes aren't needed, so I'm closing the issue.


jQuery execution

Hi,
If I run the following Python script I get a result of 'Between lugs: 20 mm'
from selenium import webdriver
driver = webdriver.Chrome() #Firefox()
driver.get("https://www.omegawatches.com/watch-omega-specialities-first-omega-wrist-chronograph-51652483004001")
driver.execute_script("return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')")

I have translated to Selenium Basic but I get no result.
Option Explicit
Public Sub GetInfo()
    Dim d As WebDriver
    Set d = New ChromeDriver
    Const URL = "https://www.omegawatches.com/watch-omega-specialities-first-omega-wrist-chronograph-51652483004001"

    With d
        .Start "Chrome"
        .get URL
        .ExecuteScript "return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')"
        .Quit
    End With
End Sub

Is there a reason why the second script does not produce the same result? I can't seem to get any CSS selector to work so it is not just because of the pseudo selector part.

Your code seems to be OK but you are not doing anything with the results
returned by the .ExecuteScript.
Something like this should prove that it does return the value as expected:
With d
    .Start "Chrome"
    .get URL
    MsgBox(.ExecuteScript("return jQuery('li:contains(Between

lugs)').text().trim().replace(/\s+/g, ' ')"))
.Quit
End With
On Wed, 14 Nov 2018 at 09:30, quentinharris<EMAIL_ADDRESS>wrote:

Hi,
If I run the following Python script I get a result of 'Between lugs: 20
mm'
from selenium import webdriver
driver = webdriver.Chrome() #Firefox()
driver.get("https://www.omegawatches.com/watch-omega-specialities-first-omega-wrist-chronograph-51652483004001")
driver.execute_script("return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')")
I have translated to Selenium Basic but I get no result.
Option Explicit
Public Sub GetInfo()
Dim d As WebDriver
Set d = New ChromeDriver
Const URL = "https://www.omegawatches.com/watch-omega-specialities-first-omega-wrist-chronograph-51652483004001"
With d
    .Start "Chrome"
    .get URL
    .ExecuteScript "return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')"
    .Quit
End With

End Sub
Is there a reason why the second script does not produce the same result?
I can't seem to get any CSS selector to work so it is not just because of
the pseudo selector part.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/florentbr/SeleniumBasic/issues/179, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AJlnWlxheSqcox1ByU_UdXdUUEnmBNFOks5uu-KhgaJpZM4YdWC0
.

Your code seems to be OK but you are not doing anything with the results returned by the .ExecuteScript. Something like this should prove that it does return the value as expected: With d .Start "Chrome" .get URL MsgBox(.ExecuteScript("return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')")) .Quit End With
…
On Wed, 14 Nov 2018 at 09:30, quentinharris @.***> wrote: Hi, If I run the following Python script I get a result of 'Between lugs: 20 mm' from selenium import webdriver driver = webdriver.Chrome() #Firefox() driver.get("https://www.omegawatches.com/watch-omega-specialities-first-omega-wrist-chronograph-51652483004001") driver.execute_script("return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')") I have translated to Selenium Basic but I get no result. Option Explicit Public Sub GetInfo() Dim d As WebDriver Set d = New ChromeDriver Const URL = "https://www.omegawatches.com/watch-omega-specialities-first-omega-wrist-chronograph-51652483004001" With d .Start "Chrome" .get URL .ExecuteScript "return jQuery('li:contains(Between lugs)').text().trim().replace(/\s+/g, ' ')" .Quit End With End Sub Is there a reason why the second script does not produce the same result? I can't seem to get any CSS selector to work so it is not just because of the pseudo selector part. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#179>, or mute the thread https://github.com/notifications/unsubscribe-auth/AJlnWlxheSqcox1ByU_UdXdUUEnmBNFOks5uu-KhgaJpZM4YdWC0 .

Thanks.


More Docs

Hey,
Notes:

please add setup instructions
add supported shells and systems
add contribution Readme

@mahdi-malv

There you go 4a32e403c7ef504ac00dbea5e841764c40552ce6

I saw it and did not like it brother.


add chain_config system contract, add upMaxBlockSize and upGasPrice func

usage
updateMaxBlockSize
{     "args" : {         "min_vote_percent": "51",         "stop_vote_height": "30"     },     "trigger": {         "height": 35,         "module": "xkernel",         "contract": "$chainConfig",         "method": "updateMaxBlockSize",         "args" : {             "maxBlockSize":  12222222         }     } }
updateGasPrice
{     "args" : {         "min_vote_percent": "51",          "stop_vote_height": "20"      },     "trigger": {         "height": 25,          "module": "xkernel",         "contract": "$chainConfig",         "method": "updateGasPrice",         "args" : {             "gas_price": {                 "cpu_rate": 1,                 "mem_rate": 1,                 "disk_rate": 2,                 "xfee_rate": 2             }         }     } }
rollBackUpdateGasPrice and rollBackUpdateMaxBlockSize 保证区块回滚时数据一起回滚。

Codecov Report
Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (88ca66e) 43.47% compared to head (acc72b4) 43.33%.

Files
Patch %
Lines

bcs/ledger/xledger/state/state.go
0.00%
35 Missing and 1 partial :warning:

bcs/ledger/xledger/state/meta/meta.go
39.47%
13 Missing and 10 partials :warning:

kernel/engines/xuperos/chain.go
50.00%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   43.47%   43.33%   -0.14%
==========================================
  Files         155      155
  Lines       14704    14766      +62
==========================================
+ Hits         6392     6399       +7
- Misses       6834     6879      +45
- Partials     1478     1488      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Codecov Report
Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (d295a7a) 43.97% compared to head (906acaa) 43.28%.
Report is 3 commits behind head on master.

Files
Patch %
Lines

bcs/ledger/xledger/state/state.go
0.00%
36 Missing and 1 partial :warning:

bcs/ledger/xledger/state/meta/meta.go
39.47%
13 Missing and 10 partials :warning:

kernel/network/p2p/util.go
0.00%
6 Missing :warning:

bcs/contract/xvm/aot_creator.go
50.00%
2 Missing :warning:

bcs/contract/xvm/interp_creator.go
0.00%
2 Missing :warning:

kernel/engines/xuperos/chain.go
50.00%
1 Missing and 1 partial :warning:

kernel/engines/xuperos/xtoken/xtoken_contract.go
0.00%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   43.97%   43.28%   -0.70%
==========================================
  Files         149      155       +6
  Lines       13367    14766    +1399
==========================================
+ Hits         5878     6391     +513
- Misses       6306     6888     +582
- Partials     1183     1487     +304

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


createFacade type error with interface

createFacade errors when being used with the interface type. Typescript recommends interfaces over intersections.
type Type = { useX: () => void };
interface Interface { useX: () => void };
createFacade<Type>;
createFacade<Interface>; // Type 'Interface' does not satisfy the constraint 'FacadeInterface'. Index signature for type 'string' is missing in type 'Interface'.

Codesandbox
Maybe the type could be improved, or is the only way around using type instead of interface? I am using this rule to enforce the use of interfaces over types so it will require an exception to the rule :)
Great library btw! Looking forward to start using it more

Hey, that's definitely unintentional.
I can take a look at it in a few days, but feel free to open a PR (with a noop test to verify its working) if you've got a working solution now.

@Aaronkala just published 0.3.1 and this should be fixed.

Wow that was fast. Thanks!


Integrated neetoUI to neetoEditor

Fixes #498
Description

Added: Integrated neetoUI to neetoEditor and did a full UI revamp.

Checklist

[x] I have made corresponding changes to the documentation.
[x] I have added the necessary label (patch/minor/major - If package publish is required).

Reviewers

Now neetoEditor requires neetoUI as a peer dependency for proper usage.
minor _t

Demo: https://vimeo.com/783539323/4e9dca66c0

@praveen-murali-ind _a please do the first review.
Reference to the issue by Neeraj: https://github.com/bigbinary/neeto-desk-web/issues/14564
cc: @goutham-subramanyam
Screenshots
neetoEditor

neetoKB

Looks good to me. @goutham-subramanyam _a Could you please review.

@goutham-subramanyam please review it with some priority.

@goutham-subramanyam _a please verify.

Merging and releasing this PR since it is a priority. @goutham-subramanyam please do verify once again. I'll take up any reviews (if any) separately.


chore: appease the linter (3/?), the big gofumpt

Reason for Change:

Correct gofumpt findings, automatically, by $ gofumpt -w -s .
Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

bypassing lint check since it is just a big false positive


Change add destination of mouseover event listener

Failure to add an event if there is no body element at loading.
Changed document.body to document.

Thanks for your good contribution!


Document a guide for connecting the LBS gateway to a local stack

Summary
The Things Stack users are facing issues while connecting the LBS gateway to the TTS Open source stack running on an IP address.
Why do we need this?
It will be helpful to users to connect their LBS gateways to the local stack.
What is already there? What do you see now?
Ref: https://www.thethingsindustries.com/docs/gateways/lora-basics-station/
What is missing? What do you want to see?
Guide to connect LBS gateway to Open-source local stack.
How do you propose to document this?
Please find the relevant info to document here: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/682#issuecomment-1005456371
cc: @KrishnaIyer
Can you do this yourself and submit a Pull Request?
No.

I'll pick this up.

This is covered in https://github.com/TheThingsIndustries/lorawan-stack-docs/pull/793


I wish I could use the same Android emulator setup script as CI

Spawned from a Discord discussion with @gmackall:

Does anyone have a suggestion (i.e. does this themselves) for how I could quasi-programmatically (i.e. on the command-line) create a new Android emulator, locally? I believe on LUCI/CI, we download a text proto describing the emulator configuration, and make one before each shard that uses an emulator.
That leads to behavior like (https://github.com/flutter/flutter/pull/152383#issuecomment-2259323669), where "first time" dialogs are shown. I am working on mitigating those with other ADB configuration, but I'd love an iteration cycle that is local and not "wait 20-50 minutes for our CI".

@gmackall:

I actually ran into a comment where someone was doing this relatively recently
https://github.com/flutter/flutter/issues/149328#issuecomment-2145599891
if your avdmanager isn't on path its probably at ~/Library/Android/sdk/cmdline-tools/latest/bin/avdmanager
and emulator at ~/Library/Android/sdk/emulator/emulator
though I guess this is creating the AVD and not the emulator?

My hope is someone else has figured this out already, and we could just document how to also do it.

I believe on LUCI/CI, we download a text proto describing the emulator configuration, and make one before each shard that uses an emulator.

TIL. Do we have documentation for this?

TIL. Do we have documentation for this?

This issue is now the documentation :)
Jokes aside, I think the protos come from here:
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/android/avd/proto
And our recipes fetch them and use Chromium infra (?) to set them up.


added a new naming good practice

Use same type of casing style for same type of data in all the project

kindly review this pr

ok I will review this.

Good Luck.

And your welcome since I reviewed this PR.

@thedivloop  Kindly review the changes


How can I handle non suggested terms?

I am looking for an autocomplete that can suggest options from a given list, but can also accept other options.  However when I the AutoComplete component this property:
onSelect={val => console.log(`selection val=${val}`)}
And then in the browser I type into it and press enter, it will only call the function when there is a highlighted suggestion, and call it with the highlighted suggestion as an argument. Is there a way to use any term and with enter send that value?

It seems I can't pass the component an onKeyPress property, to handle an enter press case.

Hi,
you can easily achieve this by using inputProps:
inputProps={{onKeyPress: (e)=>{
 if (e.key === 'Enter') {
  // do whatever
 }
}}}


ml.py: calc_feature_importances, replace show_progress with logger

[ ] Replace show_progress with logger.debug
[ ] Replace warnings.warn with logger.warn

moved to https://github.com/stharrold/dsdemos/issues/9


Patchscope run aggregates memory on GPU

When running a patchscope multiple times on GPU w/o changing anything, the allocated memory increases.
This can quickly fill up the whole GPU and throw OOM errors when the patchscope is run often.
Here is an example with a (ridiculously) long prompt, that shows this behaviour:
import torch
from obvs.patchscope import SourceContext, TargetContext, Patchscope

import sys
from io import StringIO

# suppress patchscope warnings
class SuppressOutput:
    def __enter__(self):
        self.stdout = sys.stdout
        sys.stdout = StringIO()

    def __exit__(self, exc_type, exc_value, traceback):
        sys.stdout = self.stdout

# create some very long prompt
prompt = ''.join(['This will be a long prompt']*100)
source_context = SourceContext(prompt=prompt, model_name='gpt2', device='cuda:0')
target_context = TargetContext.from_source(source_context)
patchscope = Patchscope(source_context, target_context)

# run patchscope
with SuppressOutput():
    patchscope.run()
# print current memory allocated on GPU
print('After 1 run')
print(f'CUDA memory allocated: {torch.cuda.memory_allocated() / (1024**2):.2f} mb')

# run again w/o changin anything, memory should not change
with SuppressOutput():
    patchscope.run()
print('After 2 runs')
print(f'CUDA memory allocated: {torch.cuda.memory_allocated() / (1024**2):.2f} mb')

# run again w/o changin anything, memory should not change
with SuppressOutput():
    patchscope.run()
print('After 3 runs')
print(f'CUDA memory allocated: {torch.cuda.memory_allocated() / (1024**2):.2f} mb')

Run on main branch, on RTX3060 GPU:
python3 gpu_fill_test_script.py

After 1 run
CUDA memory allocated: 1422.82 mb
After 2 runs
CUDA memory allocated: 2227.10 mb
After 3 runs
CUDA memory allocated: 3031.98 mb

Tested with nnsight v0.2.8 -> issue persists

I tried to reproduce this. I believe this is a memory leak issue in nnsight.
import torch
from nnsight import LanguageModel

PROMPT = ''.join(['This will be a long prompt']*160)

def test_reuse_model():
    print("Testing reuse model")

    model = LanguageModel("gpt2", device_map="mps")
    x = None

    for i in range(10):
        with model.trace(PROMPT):
            x = model.transformer.h[1].output.save()

        print(f"After {i + 1} run")
        print(f"Memory usage: {torch.mps.current_allocated_memory() / 1024 ** 2 : .2f}mb")

def test_reinit_model():
    print("Testing reinit model")

    x = None

    for i in range(10):
        model = LanguageModel("gpt2", device_map="mps")
        with model.trace(PROMPT):
            x = model.transformer.h[1].output.save()

        print(f"After {i + 1} run")
        print(f"Memory usage: {torch.mps.current_allocated_memory() / 1024 ** 2 : .2f}mb")

if __name__ == "__main__":
    test_reuse_model()
    test_reinit_model()

Output:
Testing reuse model
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 1 run
Memory usage:  806.33mb
After 2 run
Memory usage:  1051.93mb
After 3 run
Memory usage:  1298.41mb
After 4 run
Memory usage:  1298.41mb
After 5 run
Memory usage:  1544.88mb
After 6 run
Memory usage:  1791.36mb
After 7 run
Memory usage:  1791.36mb
After 8 run
Memory usage:  2037.83mb
After 9 run
Memory usage:  2037.83mb
After 10 run
Memory usage:  2284.31mb
Testing reinit model
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 1 run
Memory usage:  827.47mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 2 run
Memory usage:  731.45mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 3 run
Memory usage:  827.47mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 4 run
Memory usage:  731.45mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 5 run
Memory usage:  827.47mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 6 run
Memory usage:  731.45mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 7 run
Memory usage:  827.47mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 8 run
Memory usage:  731.45mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 9 run
Memory usage:  827.47mb
You're using a GPT2TokenizerFast tokenizer. Please note that with a fast tokenizer, using the `__call__` method is faster than using a method to encode the text followed by a call to the `pad` method to get a padded encoding.
After 10 run
Memory usage:  731.45mb

nnsight fixed the issue and will release a new revision next Monday. I'll try again then.


Segmentation fault with lateast nightly compiler

the rustc is rustc 1.15.0-nightly (7b3eeea22 2016-11-21)

Could you provide more informations?

What code are you running?

What operating system are you running this on?

Running the dialog example for instance with default features works properly on this rustc version.

cargo run --release --example key_codes --no-default-features --features ncurses
my os is ubuntu 16.10

I cannot reproduce the problem locally.
Could you run gdb to find exactly where the segfault occurs?
$ gdb target/release/examples/key_codes
(...)
(gdb) run
(... segfault I guess?)
(gdb) backtrace

(gdb) backtrace
#0  0x00005555555a415d in cursive::views::stack_view::{{impl}}::draw::{{closure}} (printer=0x7fffffffd928) at /home/matrix/Codes/Cursive/src/views/stack_view.rs:83
#1  0x00005555555a7d86 in cursive::printer::{{impl}}::with_color::{{closure}} () at /home/matrix/Codes/Cursive/src/printer.rs:132
#2  0x00005555555aa6ac in cursive::backend::curses::n::{{impl}}::with_color (self=0x7fffffffddc1, color=cursive::theme::ColorStyle::Primary, f=...) at /home/matrix/Codes/Cursive/src/backend/curses/n.rs:63
#3  0x00005555555a7bdf in cursive::printer::Printer::with_color (self=0x7fffffffd928, c=cursive::theme::ColorStyle::Primary, f=...) at /home/matrix/Codes/Cursive/src/printer.rs:132
#4  0x00005555555a4113 in cursive::views::stack_view::{{impl}}::draw (self=0x7ffff69cd000, printer=0x7fffffffd928) at /home/matrix/Codes/Cursive/src/views/stack_view.rs:82
#5  0x00005555555aca0f in cursive::Cursive::draw (self=0x7fffffffdd00) at /home/matrix/Codes/Cursive/src/lib.rs:511
#6  0x00005555555acd1d in cursive::Cursive::run (self=0x7fffffffdd00) at /home/matrix/Codes/Cursive/src/lib.rs:536
#7  0x000055555557529b in key_codes::main () at /home/matrix/Codes/Cursive/examples/key_codes.rs:12
#8  0x00005555555c2b3b in panic_unwind::__rust_maybe_catch_panic () at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/../src/libpanic_unwind/lib.rs:97
#9  0x00005555555ba94b in std::panicking::try<(),fn()> () at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/../src/libstd/panicking.rs:332
#10 std::panic::catch_unwind<fn(),()> () at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/../src/libstd/panic.rs:351
#11 std::rt::lang_start () at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/../src/libstd/rt.rs:57
#12 0x0000555555575783 in main ()

Ok, so it seems it's a ncurses problem:

On my machine, /usr/include/ncurses.h contains:

#if 1 && defined(_LP64)
typedef unsigned chtype;
typedef unsigned mmask_t;
# else
typedef uint32_t chtype;
typedef uint32_t mmask_t;
#endif

On a Ubuntu 16.10 docker image, /usr/include/ncursesw/ncurses.h contains:

#if 0 && defined(_LP64)
typedef unsigned chtype;
typedef unsigned mmask_t;
#else
typedef unsigned long chtype;
typedef unsigned long mmask_t;
#endif

As a result, chtype is 32bit on my computer (and as expected by ncurses-rs), but 64 bits on the ubuntu image - and this is what causes troubles (ncurses overwrites some important bits).
I'll post an issue on ncurses-rs.

This should be fixed in the current master. Can you confirm?

it's ok now


Touch-/Mobile-/Drag-Support in latest Chrome-Version(s)

Hi all,
I'm trying to make webglearth work with a touch-screen. So far no luck.
The readme says it supports mobile devices, but I can't confirm that either.
I am initializing my earth like that:
            var earth = new WE.map('world', {
                zoom: 1,
                altitude: 7000000,
                minAltitude: 3500000,
                maxAltitude: 20000000,
                tilting: false,
                atmosphere: false,
                sky: true,
                dragging: true
            });

What am I doing wrong?

Edit: As it turns out I've done nothing wrong and the framework is touch-able. There seems to be a problem with the latest chrome-version(s) that is blocking this functionality. I'll leave this issue open for anybody also encountering this problem.
As the time of writing I'm using Chrome 56.0.2924.87 (64-bit).
For the NodeWebkit (nwjs) App I'm developing I fell back to Chrome 52 and it works.

Just encountered this problem. Chrome for android still has this issue.

Would updating Cesium fix this?

Just stumbled upon another little thing: after many years, I had to update the application.
But the touch wasn't working anymore on touch-devices.
It turns out, that my wrapper-div needed a css-rule of touch-action: none, to not interfere with the handlers of this library.
"Funny" enough, on their website https://www.webglearth.com/ it works on touch, but on the demos (like http://examples.webglearth.com/examples/helloworld.html) it doesn't. Comparing them, I found that css-rule, and fixed my application.

atmosphere: false,
sky: true,

Would you share what you found ? I'm new to WebGLEarth and spending quite long time to found a fix.


Docker image

Feature Description:
Before Theia joined the EF, we had the theia-apps repo. Because  of its popularity and diversity of contributors, it's a hard repo to re-license, making it difficult to bring under the Foundation.
However, with the move to vscode extensions to support programming languages, it's becoming less important to have multiple, per-language examples, when the main difference is which extensions are bundled. They could essentially all use the same Theia application, in theory.
I think the theia-apps examples can remain, with minimal maintenance, for a while. But we can also make one or a couples, based on our experiences with theia-apps and the lessons learned there.
Let's start with a modest image, a Blueprint-based IDE appliance, for JavaScript/TypeScript software development.
Let's re-use the browser package we'll make in #74

I'd love to see docker support, recently I tried to make up package for theia-full from the apps repo but that try ended up in some bugs in the end and I wanted to check if docker image works alright but it just won't download and seems to not be supported anymore.
So I would really like example of some docker-based stuff that actually works based on theia.
Then I might bodge up example of how to package this stuff for Linux distros, as now i only see the desktop version everywhere but I mostly access stuff remotely and VNC/RDP just doesn't cut it for me, I'd love to have something browser-based on the other side.
Sorry for the occasional ramble, just wanted to highlight that docker-based version would be helpful to at least some people.

Because the last official docker image theia1.17 (and old releases tool) was removed from docker hub, i know a corruption problem on my local registry and not be able to pull theses old theia image.
I've found an alternative here : https://hub.docker.com/r/gitpod/openvscode-server

Because the last official docker image theia1.17 (and old releases tool) was removed from docker hub, i know a corruption problem on my local registry and not be able to pull theses old theia image.
I've found an alternative here : https://hub.docker.com/r/gitpod/openvscode-server

Good news: The default container from the Theia app repo is published here by a contributor:
https://quay.io/repository/zowe-explorer/theia?tab=tags

This still being worked on?

Yes, I've started to prepare a Blueprint Docker Image here: https://github.com/eclipsesource/theia-cloud/blob/main/demo/dockerfiles/demo-theia-docker/Dockerfile
This uses this branch at the moment: https://github.com/eclipse-theia/theia-blueprint/tree/jf/docker
This branch does not include the electron Blueprint however.
Open topics are therefore
a) integrating the Browser-App from the branch into the main branch so that both electron and browser apps may be built. This might require to split some of the existing packages.
b) provide a minimal Dockerfile to package this. The Dockerfile linked above e.g. still contains a sample workspace or sets environment variables that should not be set in a Blueprint template


Allow GraphQLConfig.Documents to be an array

Changes GraphQLConfig.Documents to a string[]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Garancegourdel/refacto output handlers to remove scanable from result

Context
Currently, for every Result we keep the entire file (more precisely Scannable object) in which the secret was found, and only at the very end used it to display the secrets and a bit of it's context. This can cause ggshield to run out of memory if a scan finds many secrets in large files.
What has been done
In #890 we first worked on unifying the make_matches functions in between json and text output. Unfortunately, due to a lack of test on the json output, a breaking change was introduced and work MR was revert.
Then the last 4 commits gradually replace the need for the full content when displaying and ultimatly removes it. In the process it removes a few incoherence's in the tests. Best reviewed by commits.
Validation
Test should still pass.
When finding a lot of secrets in large files the memory consumption should augment much less.
PR check list

[ ] As much as possible, the changes include tests (unit and/or functional)
[ ] If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@agateau-gg  There is only the last commit you have not yet reviewed (it removes completly the Scannable from the Result).

Sorry for the branches confusion and thank you for your patience! #908  addresses your fist comment.


Support for negative "order_by" field value

From what I can tell, when you specify fields for order_by: the result is always positive (ascending).
An example query:
query = from f in MyCollection,
  where: f._userId == ^current_user.id,
  order_by: [^:field_name]

Will result in the $orderby mongo query being {"$orderby", [field_name: 1]}
Is there a way to set the $orderby of a field to -1 so the ordered result is descending?

Sigh, can't believe I missed that! Have been trying to around 2 hours. Huge thanks for the speedy response. Just tried and it works a-ok.


run on custom dataset

Hi @beric7,
I am trying to run the code on my customized dataset and I prepared the dataset using the description you provided. I have 12 classes. Now I am getting an error. Should I have to change the color mapping for 12 classes as this dataset has 4 classes in datahandler_plus.py file? If so, how can I get the exact color code?

@deepai-lab yes you will need to update the color mapping code for the number of classes you are using. To get that exact color code, there are a number of ways you could do this, however, I do not think I have a script for this on this repo. I could try and find the script I used to do this, or you could try and write a customizable one yourself. I would suggest converting the RGB image into a list. Such that if the image was 100x100 that you would have 10,000 positions with (R, G, B). Then turn that list into a set, and your 12 colors will remain. It will be up to you to figure out how to then map those colors to your classes, but at least you will have the exact colors.

I can't download the dataset, can you upload the dataset？

@Wang2207 - Can you confirm that which DOI you followed for downloading the dataset? Are you downloading the correct version?

@deepai-lab Closing this issue in 2 weeks if I do not hear back from you. I hope it worked out!


Offer EPUB download

Rather than having site data be scraped and then processed into an EPUB format, actually offer these EPUBs from the Constellation itself.
Issues:

Downloading the images could pose a security risk, or could be rather large in size; linking to online images means the EPUBs would be smaller but would not work properly offline.
Certain replies would need to be sanitized, especially if they currently involve (hacky) quoting

Old todo related to this: https://github.com/Marri/glowfic/blob/ad00696b4d2eeb0a3e19aec9fe6adf270a45fd79/app/views/posts/show.haml#L34-L38

I once scraped a thread to make an ebook for reading on a Kindle. I removed all images, as well as the timestamp to make it look right. I also removed all extra boxes and margins.
I would love to take a look at implementing this feature server-side — maybe just output a sinmple markdown document for a given thread.

Here's my pass at this:
https://gist.github.com/HalCanary/f9291e75122e60b10ed46dbfd1f272ab

Hey @HalCanary! Thanks for the interest. While that's an interesting proof of concept, I don't think it'll help too much for a few different reasons – I've done some work on EPUB generation before, and the issues mostly aren't in the bare-bones generation. In particular, though:

Our stack mostly runs on Ruby, and due to hosting constraints, we're likely to have trouble executing Python at the same time (especially needing to communicate between the processes, and given your snippet is in Python 2, EOL January last year)
It looks like you're relying on an external process, ebook-convert, for most of the heavy lifting – we might be able to install that, but we'd need to investigate it more thoroughly (and the same hosting constraints probably get in the way here)
It doesn't really consider the main concerns listed in the post body, around security &/ sanitization; but we have additional constraints in recent development around performance, which this is likely to hit into (loading all the pages of a post can be quite memory intensive)

This issue also isn't super high priority right now, and our dev efforts have been quite limited recently.
This could work for individuals looking to scrape ebooks from the site – maybe it would be useful shared in one of the communities focused around Glowfic and the Constellation (e.g. the Discord servers)?

Hal, feel free to contact me on Discord (The Girl Reading This#9490) if you'd like to set this up on glowficrss.com (which provides some auxilliary utilities and has some extra hosting resources).

ebook-convert comes with Calibre.  Providing a single-page simple HTML document for download would allow anyone with Calibre to do the conversion themselves.
I don't know Ruby and don't have the bandwidth to learn it at the moment.
One question: the post.content field is sometimes formatted with
, sometimes with
, and sometimes with newlines. Are you just looking for those strings to determine which it is?  Is it ever a mixture?  I ask because I like indented paragraphs in ebooks.

Flat view for posts exists and might do what you want for this, I haven't tried it with Calibre specifically since you can retrieve replies using the API instead.

I don't remember exactly which format we expose in the API (if we do anything to it), but in the HTML we have three different representations:

If we see
 or
 tags (matches /
]*)?>/ or /
/), we treat it as HTML that wants to handle its own linebreaks
Otherwise, if we see a
 tag (/
)/), we just replace linebreaks with
 -
 and other block elements interact poorly with our simplistic auto-paragraphing below
Otherwise, we chunk it by linebreaks – splitting by \n\n, we wrap each section in paragraphs, filling empty paragraphs with   to ensure they display, and turning any remaining single linebreaks within paragraphs into
s

I hacked on my python script last night:

I split it into three scripts:

One downloads the entire thread and saves the data structure as a single JSON file.
The second converts the JSON file to HTML.  This is where all of my opinions on how to style ebooks so they look nice on a kindle or on a computer screen come in.
The final script calls into Calibre's ebook-convert to convert the HTML into EPUB and MOBI, setting the --title and --authors attribute correctly, as well as putting the source URL into the --comments section.

The scripts run fine on either Python2 or Python3.

I send the post content through the lxml package to clean it up, resulting in well-formed HTML.

https://gist.github.com/HalCanary/f9291e75122e60b10ed46dbfd1f272ab

I did not know about flat view.

Hi,
Just wanted to log here that I've written an alternative converter.

Not really looking for this to be integrated in Glowfic, but it does address a few of the concerns raised in case you'll decide to prioritise epubs in the future:

Downloading the images could pose a security risk

This isn't really addressed, though linking to images is easy of course.

Certain replies would need to be sanitized, especially if they currently involve (hacky) quoting

Currently the content is parsed, sanitised, and then serialised. A full run of the entire database would be needed to find less stringent rules that work well.

Our stack mostly runs on Ruby, and due to hosting constraints, we're likely to have trouble executing Python at the same time (especially needing to communicate between the processes [...])

Not sure how Rust programs are usually called from Ruby, though executing it as a static binary or separate service might work well.
This could also in theory be adapted to work directly in the browser (though possibly a performance no-no given no way of caching) since CORS wouldn't be a problem for you.

relying on an external process

The program is standalone and can be compiled to a static binary.

[...] we have additional constraints in recent development around performance, which this is likely to hit into (loading all the pages of a post can be quite memory intensive)

Presumably caching could take up a lot of the load, but that would require more work unless a hacky file cache like the one I already implemented was used.

As a side note, one thing I missed in the API was a way to get a list of posts in a board or board_section.
Not really asking for it, I can parse the website if needed in the future, but saying so in case there turns out to be something I missed.
That's it. Thank you for working on Glowfic!


attempt to trigger circleci

This is an attempt to trigger circleci. I deleted an unneeded character from a comment

@nick-clean please try merging this pr


fix(ci): build images before running sanity test

Signed-off-by: Niladri Halder<EMAIL_ADDRESS>Why is this PR required? What issue does it fix?:
The GitHub Actions CI runs make sanity-test against existing docker hub images. The images with the changes are not built correctly before running the sanity test. The sanity test does not produce results against the latest changes.
Additionally, the apt install for the nfs-common prerequisite will require interactive Y/N command if the nfs-common prerequisite is absent, and the install needs to go through. Added the -y flag to make the Y option non-interactive.
What this PR does?:
Build workflow: Both the provisioner-nfs and nfs-server-alpine image builds are added before the test run.
Pull Request workflow: The build for the provisioner-nfs image now uses buildx and the build for the nfs-server-alpine image is now added.
The sanity-test now runs in parallel with the multi-arch build tests for the provisioner-nfs and nfs-server-alpine image.
Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Not manually verified.
Any additional information for your reviewer? :
The PR #125 depends on this.

Codecov Report

Merging #129 (e68e276) into develop (59d00f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #129   +/-   ##
========================================
  Coverage    49.79%   49.79%
========================================
  Files           38       38
  Lines         2705     2705
========================================
  Hits          1347     1347
  Misses        1255     1255
  Partials       103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347ab2f...e68e276. Read the comment docs.


Freezing after playing music Windows 10

Windows 10 Anniversary update
Player freezes, no buttons work but sound still plays. Last FM scrobbling is on.
Open player, choose song, wait 5 or so seconds and player wont respond.

Fixed in latest Electron build

I just uninstalled and reinstalled, and it is still happening. Any suggestions?

I'm continuing to experience this as well.

That's because although Electron is fixed.  We have not pushed an update yet


Update dokku version

Would be nice to have the dokku version updated

2024, the Dokku's version from 1-click droplet still hasn't been updated :/
You're better off manually installing from source https://dokku.com/docs/getting-started/installation/#1-install-dokku or upgrading as soon as you enter the droplet.


Bulk edit, fixing column header missing issues #6 32122

Docs Build status updates of commit 73d4202:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/web-service-reference/createfolderpath.md
:white_check_mark:Succeeded
View

docs/web-service-reference/createfolderpathresponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/createitemresponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/generation.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getappmanifests.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getattachment.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getclientextension.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getclientintentresponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/internetmessageid.md
:white_check_mark:Succeeded
View

docs/web-service-reference/movedevent.md
:white_check_mark:Succeeded
View

docs/web-service-reference/mustdisplaycomment.md
:white_check_mark:Succeeded
View

docs/web-service-reference/protectionrulesconfiguration.md
:white_check_mark:Succeeded
View

docs/web-service-reference/routingtype-emailaddresstype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/sender-string.md
:white_check_mark:Succeeded
View

docs/web-service-reference/sortvalue.md
:white_check_mark:Succeeded
View

docs/web-service-reference/statusdescription.md
:white_check_mark:Succeeded
View

docs/web-service-reference/templatedescription.md
:white_check_mark:Succeeded
View

docs/web-service-reference/tokentype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/transitionsgroup.md
:white_check_mark:Succeeded
View

docs/web-service-reference/type-elcfoldertype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/unsubscriberesponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/unsubscriberesponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/updatefolder.md
:white_check_mark:Succeeded
View

docs/web-service-reference/userdisabledextensions.md
:white_check_mark:Succeeded
View

docs/web-service-reference/users-soap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/value-protectionrulevaluetype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/value.md
:white_check_mark:Succeeded
View

docs/web-service-reference/values.md
:white_check_mark:Succeeded
View

docs/web-service-reference/withinsizerange.md
:white_check_mark:Succeeded
View

docs/web-service-reference/workcity.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cb6a2fe:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Apply presets with drag and drop

Support applying presets with drag and drop anywhere in the dashboard.

This issue was opened when the dashboard worked very differently. We don't apply session diffs anymore, but rather set individual values. Custom presets in the new dashboard are planned.


Add sprites of bonuses and abilities

@ForNeVeR I found a bug in Graphics.fs. In particular, stride was incorrectly calculated in odd-width bitmaps.
It seems that there are no such sprites in the game files anymore, but if you want to put this in a external library, you will need to check the 1bpp and 8bpp formats for this bug.


Google Interview Word Sequence Problem's Solution

Take this issue for Google Interview Word Sequence Problem solution.

@rajvijen : Thanks for Contributing


Update readme, save module in project

demonstrate how to add module to project dependencies. Presumably a project using redux-debounce will be shipping with the module to production.

Thank you!


Data from future

Hi
I wanted to ask if the add_all_ta_features uses data from future candles or just current and past only
Thanks
P.S. Great work

Hi,
This library uses data from a Pandas DataFrame with Open/High/Low/Close/Volume columns to get Technical Analysis features.
Best,
Dario

Hi Dario. Thanks for your response. I am just asking if any of the indicators calculated use forward values or just current and lagged

current and past


Exception: Unknown .NET Framework version 4.6.2

Hello
First of all, thank you for psake! I'm watching a PluralSight course on it and TeamCity right now.
I am facing an issue. All my projects are coded against .NET Framework 4.6.2. I have built my PowerShell psake script and in it, I have the following:
# call psake
Invoke-psake -buildFile .\default.ps1 `
              -taskList Test `
              -framework "4.6.2" `
              -properties @{
                "buildConfiguration" = "Release"
                "buildPlatform" = "Any CPU" } `
              -parameters @{ "solutionFile" = "..\BB.sln" }

But this throws an Exception! The exception message is:

[<<==>>] Exception: Unknown .NET Framework version, 4.6.2 specified in 4.6.2.

Any help would be greatly appreciated!

We use Framework "4.6" to build our .NET Framework 4.6.2 projects.

Support for 4.6.2 is in this pull request #209 which is currently pending.

#222 added support for 4.6.2.


Disable VFS overlay on Windows

It looks like we're seeing an issue with the use of the VFS overlay on Windows which leads to manifests being loaded from the current working directory instead of the path mapped by the VFS. While we are investigating a solution, disable the use of the overlay on Windows since its intent is having more correct paths in diagnostics which is mostly cosmetic.

@swift-ci please smoke test

I'm going to merge this for now, it repairs the Windows builds and hopefully will allow us to get a snapshot built with this.


VISTA v.s UniIR

Congratulations on a great work of VISTA retriever. However, could you compare your performance with an existing method UniIR, especially, on the task WebQA (since you both tested on it). I'm confused which method in zero-shot WebQA dataset have higher performance.

Thank you for your attention!
If I understand correctly, UniIR has fine-tuned on their MBEIR, which includes data from WebQA. Therefore, UniIR cannot test the zero-shot results on WebQA. However, a model variant proposed by UniIR, $CLIP_{sf}$, can be used without training, which is the result reported in Table 6 of the UniIR paper for SoTA Zero-Shot.
As you can see in their Table 6, they have split the WebQA candidates into two corpora, one for pure text candidates and one for image-text candidates. In our paper, all of our tests are conducted on the complete corpus of WebQA.
Therefore, if corresponding to the results in UniIR's Table 6, VISTA's $q_{t}$ -> $c_{t}$ is 69.46, $q_{t}$ -> $c_{it}$ is 64.34. If it is a mixed corpus, then it is 60.11. All of these significantly surpass the SoTA Zero-shot reported by UniIR.
If you have any further questions, feel free to discuss with us.

Thank you so much for your prompt and helpful reply. Great work!


ionic-storage item retrieval

Ionic version:  (check one with "x")
[ ] 1.x
[x ] 2.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If there is currently no key/value pair is set using ionic-storage, then while trying to check whether that  key is set using the .get() method, the promise resolves with a value of null, instead of throwing an error.
Expected behavior:
It should throw an error for that. But the thing is even if there is no key, the promise always resolves with a value of null.
Steps to reproduce:

just use ionic-storage
just try to get any arbitrary key you haven't set yet
write anything in the error part of the promise of storage.get()

Related code:
import { Storage } from '@ionic/storage';

@Component({
  template: `<ion-nav [root]="rootPage"></ion-nav>`
})
export class MyApp {
  rootPage: any;

  constructor(platform: Platform, storage: Storage) {
    platform.ready().then(() => {
         storage.get('someKey')
           .then(
               (value) => { // works. it should not work},
               (error) => { // does not work. but it should}
            );
    });

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 4.4
Node Version: v7.2.0
Xcode version: Not installed

Ionic storage is based on localForage. https://localforage.github.io/localForage/#data-api-getitem
"If the key does not exist, getItem() will return null."
This is the expected behaviour imo.

OK. Thanks for pointing out.


fix: Update list of deprecated libs

Sort entries
Remove non-existent sap.dragonfly
Fix typo for sap.landvisz
Add missing sap.sac.grid

Sorry, I think I had mixed up sap.sac.df (dragonfly - still exists) and sap.sac.grid (deprecated and removed after 1.113)

What about sap.fe.common and sap.fe.semantics (both removed after 1.108 and 1.102 respectively)?


Add missing require

This should fix the issue where doing
require 'chef/resource'

throws an exception because Chef::Mixin::ShellOut is not loaded

:+1:


Fix notebook smoke tests: change openFile method implementation

This PR changes the way we open notebook files in smoke tests to clicking on the filename in the quick input result list. The old way (typing the filename into quick input and hitting enter) sometimes failed due to the quick input box no longer being in focus.

Pull Request Test Coverage Report for Build 483139199

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 43.212%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 481550643:
-0.001%

Covered Lines:
24386

Relevant Lines:
51754

💛  - Coveralls

Pull Request Test Coverage Report for Build 483139199

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 43.212%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 481550643:
-0.001%

Covered Lines:
24386

Relevant Lines:
51754

💛  - Coveralls


juggling 'completed' actions

An enhancement request from an academic piloting the tool.
Introduce a column in the "actions' table to identify/show which actions have been executed / completed. At present this is dependent on the user having remembered to download / send a confirmation email to themselves, and cross-referencing the email notification with the dashboard.

This is comming in the next release. There is an extra column, as you suggested, with a link to the Log record documenting that execution. Here is the screen capture:

Solved in Version B.3.0.0


UWP Not Connecting To S3, but works fine in Unity Player

Description
I've been trying to get a program I made in Unity to simply read a line of text from a file I've stored in my totally public S3 bucket, and it works perfectly in the Unity Editor (will return the data in a timely manner etc.) But when I build the application to UWP so I can port it over to my HoloLens (although I have tested it just on my local machine, as well, which resulted in failure) it results in the following error:
Curl error 6: Could not resolve host (my bucket name).s3.amazon.com.
It comes up after the program makes about 100 unsuccessful requests, as the Curl error message limit gets reached.
Like I said, it's not a problem on the bucket end, since it works just fine in the Unity Editor, so I think it's a problem with UWP processing the AmazonS3Client.GetObjectAsync() method.
Reproduction Steps

Here's the code I have:
 private AWSCredentials Credentials
      {
          get
          {
              if (_credentials == null)

               _credentials = new Amazon.Runtime.BasicAWSCredentials("(my access key)", "(my secret key)");
              return _credentials;
          }
      }
 private IAmazonS3 Client
    {
        get
        {
            if (_s3Client == null)
            {
                _s3Client = new AmazonS3Client(Credentials, RegionEndpoint.USEast1);
            }
            //test comment
            return _s3Client;
        }
    }
void GetObject()
{
 _s3Client.GetObjectAsync(S3BucketName, SampleFileName, (responseObj) =>
            {
                string data = null;
                var response = responseObj.Response;
                Debug.Log("Reponse: " + responseObj.Response);
                if (response.ResponseStream != null)
                {
                    using (StreamReader reader = new StreamReader(response.ResponseStream))
                    {
                        data = reader.ReadToEnd();
                    }

                    ResultText.text += "\n";
                    ResultText.text += data;

                }
                Debug.Log(data);
}

Logs

There's typically a wait before all of the requests (I think they're called that?) fail at once. Once they do this is the resulting log times a hundred:
[(Filename: C:\buildslave\unity\build\Runtime/Export/Debug.bindings.h Line: 45)
Exception thrown at 0x749D4662 in MyProgramName.exe: Microsoft C++ exception: Il2CppExceptionWrapper at memory location 0x1D2EF764.
Exception thrown at 0x749D4662 in MyProgramName.exe: Microsoft C++ exception: Il2CppExceptionWrapper at memory location 0x217FF2E4.](url)
Environment

SDK Version: <IP_ADDRESS>
Package Version: 3.5.4 for S3, if that's what this is asking (Sorry, I'm new w/ this)
OS Info: Windows 10 Home Edition
Build Environment Visual Studio 2019
Targeted .NET Platform:  UWP, deploying to x86
Trying to deploy to HoloLens 1
Unsure of where the AWSSDK packages are always supposed to be, so I have them in both the built version and the scripts in unity

Resolution
If you have any tips or suggestions, please let me know! I'm trying to get this finished relatively soon, and this bug has put me in a tight spot since I thought it was working.
Thank you very much for your help!!

This is a :bug: bug-report

That blizzard of Il2CppExceptionWrapper exceptions is similar to what I see in my UWP (Unity) app. See issue #1740

Sorry we're getting back to this so late, but in case you or anyone is still looking for Unity + UWP guidance - I was able to get similar code snippet working with S3 via the following.
Unity Version: 2019.4.17f1
AWS SDK: Version 3.7.38 of the netstandard2.0 DLLs
Build Environment: Visual Studio 2019
Target Architecture: x86
Test Environment: UWP running on Windows 10, not an actual HoloLens
Api Compatibility Level: .NET Standard 2.0
In my Unity project, I have a sample scene with a Text object that we'll write to with the contents of an S3 object.
In the project's Assets folder, I have:

An Assets\AWS SDK folder, which contains the following DLLs downloaded from here

AWSSDK.Core.dll
AWSSDK.S3.dll
Microsoft.Bcl.AsyncInterfaces.dll
System.Runtime.CompilerServices.Unsafe.dll
System.Threading.Tasks.Extensions.dll

To avoid issues related Manged Code Stripping, I have Assets\link.xml with contents:

<linker>
    <assembly fullname="AWSSDK.Core" preserve="all"/>
    <assembly fullname="AWSSDK.S3" preserve="all"/>
</linker>

Then in the scene's script, I have:

using Amazon;
using Amazon.Runtime;
using Amazon.S3;
using System;
using System.IO;
using System.Threading.Tasks;
using UnityEngine;
using UnityEngine.UI;

public class S3Demo : MonoBehaviour
{
    public Text m_MyText;

    async Task Start()
    {
        try
        {
            var config = new AmazonS3Config
            {
                RegionEndpoint = RegionEndpoint.USEast1
            };

            var credentials = new BasicAWSCredentials("<access key>", "<secret>");
            var client = new AmazonS3Client(credentials, config);

            var response = await client.GetObjectAsync("<bucket>", "<object key>");

            string data = null;
            Debug.unityLogger.Log("Reponse: " + response);

            if (response.ResponseStream != null)
            {
                using (StreamReader reader = new StreamReader(response.ResponseStream))
                {
                    data = reader.ReadToEnd();
                }

                // Update Text object with contents from S3 object
                m_MyText = GameObject.Find("Text").GetComponent<Text>();
                m_MyText.text = data;

                // Also log text
                Debug.unityLogger.Log(data);
            }
        }
        catch(Exception ex)
        {
            Debug.unityLogger.Log(ex.Message);
        }
    }
}

I have the internetClient capability enabled both in the Project Settings > Player > Publishing Settings, and in the Package.appxmanifest in the UWP publish folder. I was seeing HTTP exceptions until I manually added it to the manifest in addition to the project settings.

With that, I am able to rewrite the Text upon starting the scene. Let us know if this is helpful and/or you're still hitting issues. Thanks.

Hello!
I have a similar issue, but in my case I think that my problem is with getting the credentians with "TryGetAWSCredentials" (I wouldn't like to use my keys in the code) In the unity player every thing works fine but in the UWP build I can't get the credetials and so, I can't use the AWS APIs.
My code:
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using System;
using System.Collections.Specialized;
using System.Configuration;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Amazon.S3;
using Amazon.S3.Model;
using Amazon.S3.Transfer;
using Amazon.Runtime.CredentialManagement;
using Amazon.Runtime;
using Amazon.S3.Util;
//using Amazon.S3.;
//using UnityEditor.PackageManager;
public class S3Test01 : MonoBehaviour
{
public GameObject awsPanel;
CredentialProfileStoreChain chain;
private AmazonS3Client client;
private AWSCredentials awsCredentials;
private string bucketName = "a-bucket-made-with-csharp";
private string keyName = "simpletextkey";
private bool fileExist;
void Start()
{
    chain = new CredentialProfileStoreChain();

    if (chain.TryGetAWSCredentials("default", out awsCredentials))
    {
        client = new AmazonS3Client(awsCredentials);
        Debug.Log("Credential OK");
    }
    else
    {
        Debug.Log("Credential NO OK");
    }
}

Unity Version: 2020.3.3f1
AWS SDK: Version 3.7.38 of the netstandard2.0 DLLs
Build Environment: Visual Studio 2019
Build Type: Executable Only (for fast iteration and local test)
Build Configuration: Release
Target Architecture: x64
Test Environment: UWP running on Windows 10 Desktop, build 19041.985
Api Compatibility Level: .NET Standard 4.X
Also, link.xml file for preserving my AWS .dlls, and "internet client" anabled in both "player settings" and "appxmanifest"

Sorry for double post
I also built it with Api Compatibility Level: .NET Standard 2.0... Same result


adding runArgs not working as expected

I had (repeatedly)  a hard time to get it work to add "runArgs": ["--publish","12345:12345"], to an existing devcontainer.json.
Changing the config files did not give any result (looking at docker ps)
Repeated dev container build / up including no-cache option did not have any effect.
Even apparent syntax errors in the devcontainer.json file did not result in "error messages"
It finally worked by running docker container prune  once, which I had never used before.
Is there maybe some "caching" somewhere, which ignores when run-args get added into devcontainer.json ?

I get the behaviour which I expect into 'devcontainer up' , when I add "--remove-existing-container".
So I would say, that it is "unclear", which changes into a devcontainer.json file require which "cleaning command" to become effective.
There are quite some possibilities :

devcontainer build
devcontainer up

each having options of "no cache" in some form.

Hi 👋
Wondering, would improving documentation for devcontainer up --help and devcontainer build --help command help avoid the confusion? Let us know if you have other thoughts/ideas.

Closing as stale. Feel free to reopen with details.


feat: Adding Scene Transition

Moving to a Game class instead of a config, as it'll be doing a bit more heavy lifting for scenes
Adding some more scenes to overworld.json
Adding Transition config to IScreenTileChild

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove airgap preview feature log

Signed-off-by: Shivam Kumar<EMAIL_ADDRESS>Description
Dapr Airgap init currently gives a warning that it is a preview feature. We can remove the warning now since there is no breaking change planned  and it has been in preview for 3 releases now.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #928
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@shivamkm07 If possible can you add e2e for https://github.com/dapr/cli/issues/928 in the installer bundle repo?

Then we can move the feature to stable?

@shivamkm07 If possible can you add e2e for #928 in the installer bundle repo?

I have added the e2e test for airgap in cli in the same PR.

Should this PR be rebased to master as the PR has been added to 1.11 milestone?

also related to #1080


Add support for grpc-web and grpc-web-text to the AbstractUnaryGrpcService.

Motivation:
https://github.com/line/armeria/issues/3638. AbstractUnaryGrpcService only supports gproto currently. We could support gproto-web and gproto-web-text as well for better compatibility with frontends.
Modifications:

Add support for grpc-web and grpc-web-text to AbstractUnsafeUnaryGrpcService (parent of AbstractUnaryGrpcService).
Add UnaryGrpcSerializationFormats that represents serialization formats supported by AbstractUnaryGrpcService.
Move GrpcSerializationFormatProvider from armeria-grpc to armeria-grpc-protocol package to reuse serialization formats in AbstractUnaryGrpcService. Should be safe because - it's internal API, doesn't depend on external gRCP libraries, armerial-grpc depends on armeria-grpc-protocol already. Also planning to make use of them for the follow-up work on UnaryGrpcClient mentioned in https://github.com/line/armeria/issues/3638.

Result:

AbstractUnaryGrpcService is compatible with gproto-web and gproto-web-text protocols.

Follow-ups:

Support for gproto-web and gproto-web-text will be added to the UnaryGrpcClient in a separate PR.

We have an integration test with another JVM-based gRPC-Web implementation in GrpcWebServiceTest under /it/grpcweb. How about adding UnaryGrpcWebServiceTest right next to it?

@trustin despite the package and class name, com.linecorp.armeria.server.grpc.GrpcWebServiceTest only tests Armeria grpc-web client and its interop with AKKA grpc-web service. I don't see any test using AKKA grpc-web client and Armeria grpc-web server, I think that's because AKKA grpc-web doesn't have grpc-web client. This PR doesn't implement support for UnaryGrpcClient, so I cannot add similar test under /it/grpcweb.
Did you mean to add this test together with the UnaryGrpcClient support? It's going to be a separate PR. Or do you know any other JVM-based implementation of the gRPC-web client other than Armeria that can be used to test the AbstractUnaryGrpcService? I searched but didn't find any, also https://github.com/akka/akka-grpc/pull/829#issuecomment-593142606 which added grpc-web support to AKKA mentions the same, and doesn't seem to add support to AkkaGrpcClient "... In theory the AkkaGrpcClient could support grpc-web ... ".

I don't see any test using AKKA grpc-web client and Armeria grpc-web server, I think that's because AKKA grpc client doesn't support grpc-web.

Yeah, that's the reason why I didn't add the interop test using AKKA client <-> Armeria service. At that time, I couldn't find any JVM clients that support gRPC web so only made the test using Armeria client <-> AKKA service.
I also thought if we can guarantee that Armeria gRPC client is working, we can be sure that Armeria gRPC service is working well because we have tests with Armeria gRPC client <-> Armeria gRPC service.
 OK to ignore :sweat_smile:

We have an error from the linter though: https://github.com/line/armeria/pull/3716/checks?check_run_id=3159301870#step:4:408

Lint failure should be fixed now

@ikhoon Gentle ping

Thank you for the review! @trustin @ikhoon @minwoox 🚀


bug: dataDisplay/NativeInput

Describe the bug
Please refer https://github.com/wrappid/core/issues/318 for the entire issue
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Stack Trace
The stack trace of the bug if any.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

NativeInput fix label alignment


token-based access: works, but nags that it wouldn't

Default disclaimer: I'm in love with indra, you guys are awesome!
Your Environment

0.6.0 / indra / indra-rc1
moto G5
Android V7
Wi-Fi
0.10.3-dev-20171205 head b27950f2

Brief Explanation of Issue
indra warns to set AUTH_DEFAULT_ROLES even if there's a token-based acces with matching permissions of devicestatus-upload and readable. This seems to be cosmetic only, since data gets uploaded successfully
Uploader Error Code

Steps to Reproduce (for bugs)

set up an access token with permissions devicestatus-upload, readable
set the upload link to contain the access token (ignoring the API secret)
https://<host>.ns.10be.de:<port>/?token=indra-0...
Watch log giving instructions on how to set authDefaultRoles on azure/Heroku :)

Severity Score

1 - This seems to be cosmetic only, since data does get uploaded and backfilled successfully. (sgv and basal changes and pump profile, so it's not xDrip or AndroidAPS sneaking in what they got by xDrip broadcast)

closing fixed and released in v0.6.1


Add root-component-extension

Allow removing the component name from the URLs of a select component

Closed via 013fe28d899e5cd6bc27c0d9c98b3d50ad862550


Multi-line struct field values should begin on the same line

I would like to see struct field values start on the same line as the field name even when the expression takes multiple lines.
Config: version=Two and max_width=50.
Current:
let Struct {
    tuplestruct:
        TupleStruct(
            Foo {
                message: "hi friend",
                array:
                    [
                        loooooooooooooong,
                        loooooooooooooong,
                    ],
            },
            looooooooong,
        ),
    ..
} = x;

Desired:
let Struct {
    tuplestruct: TupleStruct(
        Foo {
            message: "hi friend",
            array: [
                loooooooooooooong,
                loooooooooooooong,
            ],
        },
        looooooooong,
    ),
    ..
} = x;

This draws your attention to the field names more than their values, making it easier to scan the overall structure without getting distracted by the values. Also it can drastically reduce indentation for patterns with a lot of nesting.

Oh, I just discovered that if I change let .. = x to let x = .. then I do get the desired output! So this is just about making patterns consistent with expressions.

Copying https://github.com/rust-lang/rustfmt/issues/5610 for searchability:
Inconsistent formatting in destructuring nested structs
Here's how creation gets formatted:
Outer {
    ...
    inner: Inner {
        ...
    },
}

But here's what happens when you destructure in a method param:
fn foo(
    Outer {
        ...
        inner:
            Inner {
                ...
            },
    }: &Outer,
) {

Here's what it should look like to be consistent and not use excessive indentation:
fn foo(
    Outer {
        ...
        inner: Inner {
            ...
        },
    }: &Outer,
) {