Cannot have more than 2 users connected

Hi, i'm trying to use this project to deploy Jitsi to my AWS Kubernetes Cluster. Whenever I add 3 or more clients to a room, every other webcam goes black and no sound is working anymore.
Here's my installation so far:
$cat 041-ingress.yml
---
kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
  name: jitsi
  namespace: jitsi
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-prod
spec:
  rules:
    - host: visio.redacted.com
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: web
                port:
                  number: 80
  tls:
  - hosts:
    - visio.redacted.com
    secretName: visio-tls-secret

$ cat 010-deployment.yml
---
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    k8s-app: jitsi
  name: jitsi
  namespace: jitsi
spec:
  template:
    metadata:
      labels:
        k8s-app: jitsi
    spec:
      containers:
        - name: web
          env:
            - name: PUBLIC_URL
              value: "https://visio.redacted.com"
          volumeMounts:
            - name: config
              mountPath: /config/custom-config.js
              subPath: custom-config.js
            - name: config
              mountPath: /config/interface_config.js
              subPath: interface_config.js
            - name: images
              mountPath: /usr/share/jitsi-meet/images/redacted.svg
              subPath: redacted.svg
        - name: prosody
          env:
            - name: PUBLIC_URL
              value: "https://visio.redacted.com"
        - name: jvb
          env:
            - name: PUBLIC_URL
              value: "https://visio.redacted.com"
        - name: jicofo
          env:
            - name: PUBLIC_URL
              value: "https://visio.redacted.com"
      volumes:
        - name: config
          configMap:
            name: jitsi-config
        - name: images
          configMap:
            name: redacted-logo

$ cat kustomization.yml
namespace: jitsi
bases:
- https://github.com/jitsi-contrib/kubernetes/doc/kustomize

resources:
- 041-ingress.yml

patchesStrategicMerge:
- 010-deployment.yml

configMapGenerator:
  - name: jitsi-config
    files:
      - custom-config.js
      - interface_config.js
  - name: redacted-logo
    files:
      - redacted.svg

I've allowed port 10000 for <IP_ADDRESS>/32 to the cluster AWS Security Groups. I suspect this issue has to do with the absence of ingress/services to port 10000:
$ kubectl get svc -n jitsi
NAME      TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)           AGE
jvb-udp   NodePort    <IP_ADDRESS>   <none>        30300:30300/UDP   13d
web       ClusterIP   <IP_ADDRESS>    <none>        80/TCP,443/TCP    13d
$ kubectl get ingress -n jitsi
NAME    CLASS    HOSTS                 ADDRESS                                                    PORTS     AGE
jitsi   <none>   visio.redacted.com   a02d4fredacted151-1096927691.eu-west-3.elb.amazonaws.com   80, 443   13d

Any idea how to amend this configuration in order to have more than 2 clients connected simulatneously ?
Thanks !

We are using udp port 30300 instead of udp port 10000 with kubernetes. I believe that is configured by default in the supplied client configuration.

@chazapp Try adding udp port 30300 to your AWS Security Group

same issue here: I deployed jitsi in K3s using this and as soon as a thirds person joins a conference the video dies. Every participant can only see their own video and nothing else.

@marner2 Thanks a lot. Opening UDP port 30300 did the job. I can now have more than 3 users in a room !

@lemmy04 Make sure you have that port we've been discussing opened. It's not standard jitsi configuration because of the way that Kubernetes works with port assignments.
Port 30300 goes to jvb which enables video multiplexing. 1-1 meetings don't actually go through jvb which is why it breaks with the 3rd person.


Add initial support for openebs provisioner

OpenEBS is containerized storage for containers. We want to add openebs provisioner for the kubernetes. We're currently pushing code to https://github.com/openebs/external-storage onopenebs-provisioner-init branch. Looking forward to your thoughts.
Thanks!
Satyam

@satyamz once its in a better shape and after sanity testing, make a WIP PR in this repo.  You can add me and Matthew as reviewers.

@humblec  I have updated code as per comments were given by you. However, I am neither able to add label WIP nor able to add reviewer.
Thanks.

@satyamz nm, I am on it. Thanks

Initial support for OpenEBS Provisioner has been added (PR #315). Therefore, closing this issue.


[WIP] CDN table, DS profiles, and ATS 6.2 support

This is a work in progress, but getting really close. I'll make a wiki page describing the changes in this soon, and still have to do the documentation, but I think it's all working. Fixes a handful of JIRAs and more.

See also https://cwiki.apache.org/confluence/display/TC/PR+%23273

I don't know why it says This branch cannot be rebased due to conflicts - i am merged onto the latest master.

Doesn't look like it...    git merge-base master cdn-table-1 shows me this commit:
Author: Jeff Elsloo<EMAIL_ADDRESS>Date:   Fri Feb 3 11:17:58 2017 -0700

    This closes #250.

and there's a conflict in traffic_ops/app/lib/UI/DeliveryService.pm after rebasing...

Closing this in favor of a rebased one that I'll PR soon.  Thanks for helping with git (again) @dangogh .


[release/5.7][move-function] Remaining _move changes for 5.7

Just adding the remaining changes for supporting _move to 5.7. Will not affect any code that doesn't use _move directly so is very safe. There is a companion set of LLVM level changes.

apple/llvm-project#4775
@swift-ci test


TypeSystem code merge (redo)

Minor, mostly mechanical, changes to make the type system compile in the context of internal code.
Making the repo public required me to resubmit the PR, but it was already signed off in https://github.com/dotnet/corert/pull/291

Hi @morganbr, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


feature request multi yeelight devices

Hi
can you add a name field so that you can add several lamps with labels/names?
Thanks 💯

you can do this already, in the config change the ip address / hostname
you can use the name field to identify different lamps

Hi,
Whether can support discovery yeelight devices in feature ? Now should use yeelight app find the device then input the ip address in yeelight node, it doesn't convenient for multi yeelight devices...
BR,
Chris


Import From Web URL: data frame part is empty at loading

https://raw.githubusercontent.com/Microsoft/RTVS-docs/master/examples/MRS_and_Machine_Learning/Datasets/Bike_Rental_UCI_Dataset.csv

B/c of #1511

Dupe of #1511


Get vector using instance method when name is string

> df = Daru::DataFrame.new(
>   :a => [1, 2, 3],
>   'b' => [4, 5, 6]
> )
> df.a
#=> #works
> df.b
#=> #doesn't work

I propose to let let vectors with string names similarly processed. WDYT?

I can think of at least one edge case which would be weird:
df = Daru::DataFrame.new(
:a => [1,2,3],
'a' => [4,5,6]
)
df.a #=> ????

Not sure about everyone else, but I strongly prefer the array accessor method getting vectors - df[:a].

Something that's always bothered me about this is that when you use df[:a] you get a vector, but when you use df[:a, :b] you get a dataframe.  This could be a problem if I'm creating a new dataframe from a variable list of vectors and it's possible for that list to just have one element.  What would everyone think about using df[:a] to return a dataframe and df.a to return a vector?

This thing is something I've wanted to discuss a long time ago :) Considering not-so-easy Ruby's String/Symbol dychotomy, it could be (maybe) reasonable for all real-life cases to make them indistinguishable from internal point of view (like infamous HashWithIndifferentAccess).
Most of the times, when somebody has :a and 'a' vector in the same dataset, it does NOT what he/she wanted, but rather the result of some logical error.

Something that's always bothered me about this is that when you use df[:a] you get a vector, but when you use df[:a, :b] you get a dataframe.

This thing is normal for Ruby:
arr = ('a'..'e').to_a
# => ["a", "b", "c", "d", "e"]
arr[3]
# => "d"
arr[3,4]
# => ["d", "e"]

Something that's always bothered me about this is that when you use df[:a] you get a vector, but when you use df[:a, :b] you get a dataframe. This could be a problem if I'm creating a new dataframe from a variable list of vectors and it's possible for that list to just have one element.

I've encountered the same problem. You can use df[:a..:a] if you want a dataframe and not a vector. Generalizing it you can do something like following:
# Assume x contains list of vectors names
x.size == 1 ? df[x.first..x.first] : df[*x] # This will return a dataframe even when x has one element.

I think we can also create another method for this type of usage.

It does not make sense to return a DataFrame with a single vector because:

As @zverok pointed out, when you select a single element, the result is an element of a type that makes up that collection (in this case Daru::Vector).
DataFrame still involves duplication of indexes and is heavier than Vector. Thus it would be unnecessary overhead.

We can overcome this problem by having a to_df method on Daru::Vector which will create a DataFrame out of the Vector. The to_df method on Daru::DataFrame will simply return self. @gnilrets thoughts?

@lokeshh about your original issue:
The df.vector_name syntax is more of a convenience syntax. We should support all sorts of vector names irrespective of whether are symbols or strings.
@gnilrets the edge case that you pointed out (where there's a symbol and string name in the same dataframe) will most likely be a fault on part of the user and even if it is intentional the user can easily use the #[] method for accessing vectors.
Therefore I think we should support vector names that use strings.

to_df on vectors would be a great workaround.
As far as the string/symbol, I agree that it would be more natural to internally convert strings to symbols when using df.a.


fix(multi_object_tracker): fix knownConditionTrueFalse

Description
This is a fix based on cppcheck knownConditionTrueFalse warings
perception/multi_object_tracker/src/data_association/successive_shortest_path/successive_shortest_path.cpp:70:7: style: Condition 'sparse_cost' is always true [knownConditionTrueFalse]
  if (sparse_cost) {
      ^
perception/multi_object_tracker/src/data_association/successive_shortest_path/successive_shortest_path.cpp:51:22: note: Assignment 'sparse_cost=true', assigned value is 1
  bool sparse_cost = true;
                     ^
perception/multi_object_tracker/src/data_association/successive_shortest_path/successive_shortest_path.cpp:61:24: note: Assuming condition is false
  if (cost.size() == 0 || cost.at(0).size() == 0) {
                       ^
perception/multi_object_tracker/src/data_association/successive_shortest_path/successive_shortest_path.cpp:70:7: note: Condition 'sparse_cost' is always true
  if (sparse_cost) {
      ^

@technolojin
If this is an acceptable change, then I will make the same changes on object_merger, radar_object_tracker and tracking_object_merger packages in this PR.
Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@technolojin
Thank you for your quick response!

@veqcc I think this is not the case.
sparse_cost may need to be defined outside the function instead.

Understood.
Do you have any idea for avoiding cpocheck warnings, or is there any plan to refactor these packages so that sparse_cost is not hard coded any more?

@technolojin @YoshiRi @yukkysaito
Hi

I will close this PR and create a new PR in which I will solve all the warnings around sparse_cost in object_merger, radar_object_tracker and tracking_object_merger with the same way here

With this statement, I think it's better to define sparse_cost in the arguments and give default true value.


Dark mode

Added files for dark mode

Couple problems. First: please merge into the dev branch, not main. Second, I think the dark-mode colors need reworked. The current styles actually make the interface lighter


gofabric8 start / gofabric8 install loads an old version of kubectl

the download logic needs to be changed; its finding an old version of kubectl. It should be downloading 1.6.2 or later rather than 1.4.x.
So rather than querying github to find the version:
https://github.com/fabric8io/gofabric8/blob/master/cmds/install.go#L230
the code should curl this url https://storage.googleapis.com/kubernetes-release/release/stable.txt instead to find the latestVersion

here's the detailed instructions on how to install kubectl
https://kubernetes.io/docs/tasks/kubectl/install/

Perfect will have a look


Let PipeLine support copy()

Let PipeLine support copy()
Description
now pipeline can be copied and add next-preprocessing step on needs withoud write duplicated append().
Fixes # (issue)
Type of Change
Please check any relevant options and delete the rest.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
class TestPipeLine(unittest.TestCase):
    def test_copy(self):
        pipe = hanlp.pipeline().append(hanlp.utils.rules.split_sentence)
        copied_pipe = pipe.copy()
        test_text = "今天天气真好。我要去散步。"
        assert pipe is not copied_pipe
        copied_pipe.append(lambda sent: "".join(sent))
        assert pipe(test_text) != copied_pipe(test_text)

Checklist
Check all items that apply.

[x] ⚠Changes must be made on dev branch instead of master
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

Thank you!


Extracting tf.Variable() in numpy or tensor format for further processing from a ListWrapper()

Hello there,
I have a simple question, that I don't seem to find any documentation on regarding it. I am using costume code, and during one of my training loops a ListWrapper Object is created containing some tensor variable.
Initially when using tf.print() I was able to see the numerical contents of the tensor but not assign to a variable for further processing.
After using tf.compat.v1.flags.tf_decorator.unwrap(x), where x is the initial ListWrapper, I am indeed able to see the tensor in tf.Variable format like that :
<bound method ListWrapper.append of ListWrapper([<tf.Variable 'Variable:0' shape=(10, 10) dtype=float32, numpy=                                                                                array([[ 0.05768297,  0.        ,  0.        ,  0.        ,  0.        ,                                                                                0.        ,  0.        ,  0.        ,  0.        ,  0.        ],                                                                                [-0.00587903,  0.01599882,  0.        ,  0.        ,  0.        ,                                                                                0.        ,  0.        ,  0.        ,  0.        ,  0.        ],                                                                                [-0.0069333 ,  0.00599516,  0.05650787,  0.        ,  0.        ,                                                                                0.        ,  0.        ,  0.        ,  0.        ,  0.        ],                                                                                [-0.00601203,  0.0059952 , -0.0027298 ,  0.05753344,  0.        ,                                                                                0.        ,  0.        ,  0.        ,  0.        ,  0.        ],                                                                                [ 0.00507043, -0.00599517, -0.00196748,  0.00593348,  0.03158937,                                                                                0.        ,  0.        ,  0.        ,  0.        ,  0.        ],                                                                                [-0.00458831,  0.00599515,  0.00015493, -0.00596476, -0.00691961,                                                                                0.03968148,  0.        ,  0.        ,  0.        ,  0.        ],                                                                                [-0.00672386,  0.00599529,  0.00553486, -0.00642598,  0.00682343,                                                                                -0.00884094,  0.05674272,  0.        ,  0.        ,  0.        ],                                                                                [-0.00481304,  0.00599513,  0.00011724, -0.00551202, -0.0070322 ,                                                                                0.00368161, -0.00388715,  0.05674548,  0.        ,  0.        ],                                                                                [-0.00566915,  0.00599517, -0.00349799, -0.00581874, -0.00713581,                                                                                -0.0043654 , -0.00537512, -0.00558803,  0.05750472,  0.        ],                                                                                [-0.00441868,  0.00599512,  0.00767725, -0.00547412, -0.00668069,                                                                                0.00388396, -0.00506157, -0.00536125, -0.00621854,  0.05662818]],                                                                                dtype=float32)>])>
I am not able to subscript or use attributes to recover the variable and store it in numpy format, which would be the easier way for me to recover it in my training loop.
Any suggesting are highly appreciated.

@kreouzisv
Kindly open a stackoverflow issue for this as it is not a bug or feature request, Please post this kind of support questions at Stackoverflow. There is a big community to support and learn from your questions.
Thanks!

I asked in the documentation tab, wasn't a bug or feature request. I figured that you should document how to manipulate the tensorflow object : ListWrapper().
Anyways, I was able to extract the numerical values of the list wrapper and store it using:
with tf.init_scope():
store_array = x
where x is the Listwrapper object.
Thanks anyway

@kreouzisv
Please move this issue to closed status if resolved.


Example of how to return the four phases

This isn't necessarily an issue, but without an example of how to return the four key phases, I'm not sure how to do so. It might be simple but I can't figure it out.

@nleslie2408 I updated the readme usage section to show an example

Thanks for the quick response I appreciate it.


Fix Rubocop errors

Hi there! Thanks so much for submitting a pull request!
Let's just make sure together that all of these boxes are checked before we
merge this change:

[ ] The code in these changes works correctly.
[ ] Code has tests as appropriate.
[ ] Code has been reviewed by @JacobEvelyn.
[ ] All tests pass on Travis CI.
[ ] Rubocop reports no issues on Travis CI.
[ ] The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

Coverage remained the same at 97.95% when pulling 74df918266557047a18eb6cec83d833252338c0b on fix-rubocop-errors into 1723a812b0781864611e7be73950e1431a8c7421 on master.


Use table alias (task #16481)

Use table alias (if defined) in system saved searches.
The model column has been also removed as it adds no real value and presents the wrong name when the table alias is defined.

@softius how do you want to handle the upcoming ModuleRegistry changes in terms of this PR?


ambee docs

Proposed changes

Merge timing

Related issues (optional)

@giriraj0012 can you please update the directory name from ambee-apis to actions-ambee? this slug has autogenerated links that will cause a 404 if not correct


move libs/** submodules into source tree

Hi,
This PR contains a lot of changes I wish to do to try to clean up duplicate/unused/unpractical code but most of those are mostly independant from each-other. It should be seen primarily as a pool of ideas, of which any number can be merged.
I tried to make readable commit messages but just to give a quick summary :

b5183516d61f418a1184a2dbac23943888e93780..88ecb87e0f0c90869eaa584c6aa109e90c94a3df: I moved everything that was in submodules under the libs/** folder to be checked-out in the repository.

I squashed each one individually to merge in the source tree. It would be possible to keep the entire commit history but that would make the log much more verbose. Here I think the original code attribution is clear and the history stays readable.

115de381a1fc5a98f5eb10dd14274fd31d8bc081 remove untouched files automatically
806fd521da61d37a791805cb730f578f3489c945 remove dummy tests from the ff-* suite (left real tests untouched)
30a503976948362b6e7fdaa171460f1d6556a263 move everything under libs/**to source/**

I think this is more readable, more in line with how most projects manage their folder structure. Might be a matter of taste?

f764fb72e764ee275f76d2bdd69655140e6732a4 remove custom parseUrlParameter function

I don't like homegrown string parsers for such things when they can be avoided. QueryStrings are harder than they sound. Here it's not a security risk, but still. And less code.

90cd054d6e28d4d2f9543c7e720f0da5f2af27b6..558f960064282e3fd49fcf9b1097efdccfa87582 remove all fetch.{text,json,file} references

It was mostly doing nothing more than fetch's defaults (which was already used in most place).
JSONWriter: Everything else is PUT in place without being routed through a writer, I couldn't see why JSON should be different. It makes CVAssetWriter more consistent.

Working on the follow-ups for https://github.com/Smithsonian/dpo-voyager/pull/288, I want to update three.js to r0.160+, which breaks down quite a lot of things from the ff-* libs. I've gone through the changelog and am ready to do the changes once we agree on a course of action on this.

Do you have an example of another project that is managing folders like https://github.com/Smithsonian/dpo-voyager/commit/30a503976948362b6e7fdaa171460f1d6556a263? I'm all for moving the used code over, but I think the /lib organization makes it more obvious that these aren't Voyager libraries. But might feel otherwise if you have an example.

It depends if you think of the ff-* code as voyager's code (as nobody else uses it), in this case, gltf-transform comes to my mind, with some (more or less) internal packages and an external cli package.
If you don't consider them "Voyager code", it is better to show this and keep them as "vendors" in a separate folder.
Either way it's OK for me, I'll edit the PR to cut off the folder rename if you think it better reflects the ownership of this code.

I don't consider the ff-* code as Voyager's code. It was developed outside of the project and a believe is (or at least was) used by its developer in other projects.

I dropped the commit that moved everything to source/.

Working on merging this in now. Some of it seems like preference, but I'm ok with it. Still need to do a little testing, but the main issue I'm seeing right now is that a lot of the library cleanup you did doesn't seem to be coming through when I pull this branch. Something to do with removing that last commit?
There are also a few ff-* file updates for this next release so not sure those will get merged in appropriately...

Some of it seems like preference
Glad if you like it, there is clearly some subjective choices in here.

The submodules removal uses exotic merges that should come through cleanly but they might not. I don't know how a reference change introduced in a previous commit would get handled.
Do you have a working branch where I could get a look ? You just merged this branch over rc43?

I hadn't yet because I was unsure how to merge the other ff-* library updates I made, but I can just redo them. I will merge with rc-43 tomorrow and let you know.

I think I was able to reproduce, using "master", merging my branch fails with a bunch of "existing files would be removed".


Upgrade terraform-provider-aws to v5.80.0

This PR was generated via $ upgrade-provider pulumi/pulumi-aws --kind=provider --target-version=5.80.0.

Upgrading terraform-provider-aws from 5.79.0  to 5.80.0.
Fixes #4883

Mhm, this is odd. The new s3_tables_* resources get schematized as s3.Tables* (e.g. s3.TablesTable).
Looking into this


run npm audit fix 2022-09-29

npm wants us to update our dependencies ... the easy step is to ask npm to do it ...
npm install output before
25 vulnerabilities (4 moderate, 14 high, 7 critical)

after
18 vulnerabilities (4 moderate, 14 high)

maybe we should also look at the 14, or maybe just land this and move on?

Thanks @whscullin


Remove unnecessary DMAC rewrite in the Service CIDR flow

serviceCIDRDNATFlow includes a DMAC rewrite action that rewrites the
the destination MAC to the antrea-gw0 interface MAC. The action was
added for supporting NetworkPolicyOnly with kube-proxy. Since we no
longer support kube-proxy in NetworkPolicyOnly mode, this action is no
longer needed.
Fixes: #1264

/test-all

Codecov Report

Merging #1282 into master will decrease coverage by 9.98%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1282      +/-   ##
==========================================
- Coverage   54.96%   44.97%   -9.99%
==========================================
  Files         110       73      -37
  Lines       10573     5541    -5032
==========================================
- Hits         5811     2492    -3319
+ Misses       4187     2770    -1417
+ Partials      575      279     -296

Flag
Coverage Δ

#integration-tests
44.97% <0.00%> (+0.04%)
:arrow_up:

#unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.


Add Enliven Systems as an adopter.

Awesome, thanks for being a user and willing to put your name to that fact! @zzvara

This is a fantastic project!


Remove JSPM

The dev speed here is amazing!
But, we already have npm and yarn all around, and the jspm repo is not really active that much...
Can we remove the dep. on jspm?

Hi @gilamran,
Good question, I was thinking about it many times, as I'm not comfortable with jspm_packages thing and would be glad to be using only node_modules directory only.
I have found alternative solution already but didn't had time to experiment with it, maybe you could volunteer to investigate and share your findings here or even maybe make some contribution :)
Here is a link to library in question: https://github.com/charto/cbuild

I think this setup has great potential as @gilamran says - the dev speed is amazing and dev speed is king.
I'm going to try out this SystemJS Hot Loader approach in a new project, mostly based on your boilerplate so I'm willing to put a few hours into this topic here and there.
My interests are

keeping the dev cycle as fast as humanly possible.
finding the best CSS scoping solution - I tried typestyle. It's nice, but breaks the editor experience a bit. SASS + scoping, like what webpack's sass/css-modules loader chain provides would be optimal IMHO.
cleaning up the duplication mess between JSPM and node_modules.

If I understand correctly, most of the power of your boilerplate comes from SystemJS 0,17's new features... so where exactly is JSPM needed? E.g. with a brief look at the code, I don't see how JSPM is actually used in the HMR part of https://github.com/piotrwitek/jspm-hmr.
Also if you're using Rollup for production bundling, then shouldn't it be simple, in theory, to remove JSPM from the mix and just rely on SystemJS's features by itself?

Hello @Martaver :)

typestyle - works great for me, not sure what you mean in breaks editor exp, for me it is opposite, I'm using vscode and ts language server is the best tool you can get in this regard
duplication is worst stuff in this approach, if getting rid of it would be perfect
JSPM is only used to generate and update jspm.config.js which defines SystemJS modules map, this is why we need cbuild to get rid of it because it is the only weak point of this boilerplate IMO

On the side note, I have found a better workflow that in dev speed can even outperform this one, moreover it has a TypeScript as first-class citizen and with plugins power of webpack but with dead simple config.
I have already started experimenting with a simple boilerplate you can check it out, but the repo is really early stage but I think you can test it to know what you are dealing with and it is already fulfilling all the interests that you have mentioned :)
It is based on fuse-box bundler, it's on the branch fusebox-rewrite here: https://github.com/piotrwitek/react-currency-converter/tree/fusebox-rewrite

Meanwhile I've created my own FAST starter kit :-) based on webpack.
https://github.com/gilamran/fullstack-typescript

not sure what you mean in breaks editor exp
You get the TS intellisense, but none for the actual CSS which you end up writing as strings. In practice, though, the flexibility & reusability of the TS probably wins, though.

This fuse-box thing looks great. So light. So fast. Much Typescript.
Noticed some weirdness when adding/removing new files/references e.g.

Add a CSS file & reference it from a component/container - do you need to reload to see changes?
Remove the CSS file/reference - Does the old CSS still persist? do you need to reload to see changes?
Add/remove the reference only - same issues...
Create a second CSS file, leaving the old one & just switch the reference to the new one - the old css is still persisted, just overwritten by the new? Try switching back and its broken...

Above can be resolve by a reload, which is fast, but it loses state. Does SystemJS have similar issues?
Fuse-box is really fast, but I feel like the SystemJS no-bundling approach is still more scalable.
With regards to scoped CSS - how can we get feature parity with webpack's css-modules?
The Fusebox API looks great - so maybe we can fork its existing CSS loader to do it.

@Martaver I also like fuse-box very much. SystemJS get pretty slow when you're getting into the hundreds of files and I really don't like that jspm folder.
Regarding your CSS issues, they're probably fixable inside fuse-box.
I had similar issues with SystemJS (old CSS persisting after change etc) and I just fixed the issue myself at the time.

Fusebox does seem to be in winning mode.
I just discovered they're working on version 2.0 (currently in beta) - http://fuse-box.org:3333/
One of the new features include css-modules... http://fuse-box.org:3333/plugins/cssmodules-plugin
Combine that with this bad boy and we're laughing: https://github.com/Quramy/typed-css-modules

@Martaver nice idea :)

I am coming around to the idea of typestyles too... and what you said does make a lot of sense. I think another great benefit of typestyles is that it will tree-shake all CSS that isn't used. Who knows maybe I will end up using it.
How do you use it practically, do you actually switch out CSS in real-time for UI styling updates, or more just use it as a once off style builder?
Also, how do you handle assets like background-images in your typestyles with fuse-box?
For the record, I got fuse-box 2.0 working with sass/css-modules. I based much of it on your experimental branch. I'll push a demo soon!


Custom image form support needed.

Wagtail have a flexible custom image model structure by WAGTAILIMAGES_IMAGE_MODEL but don't have a corresponding WAGTAILIMAGES_IMAGE_FORM support.
In my case, I've added 2 unique together fields in my CustomImage model, it will fire a IntegrityError issue when a image is uploaded twice. But there's no place to catch it.
I would also like to save image hash as a unique key, this will also be take cared of in custom image form.

Thanks for the report @kxxoling!
Rather than offering more 'hooks' into the wagtailimages app to support more and more complex customisations, we plan to convert the wagtailimages views into class-based views (using generic views and viewsets). This way, it'll be possible to define a custom subclass of the wagtailimages app, that inherits as much or as little of the core functionality as you need.

This is available as of 2.12 via WAGTAILIMAGES_IMAGE_FORM_BASE


devicetree: Add helper macros for GPIO element/array initialization

Pull helper macros out of tests/lib/devicetree/src/main.c and make them
generally available for drivers or applications to utilize.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

This is need for use in drivers/lora/sx1276.c

Going to close this, and just implement a driver specific macro for lora/sx1276


Native notebook becomes untrusted after rename

A notebook should stay trusted when only its filename changes, i.e. we should detect renames and call trustNotebook on the new file.

Should hook into VSC FS FileRenameEvent (workspace.onDidRenameFiles)

@joyceerhl isn't this the case even with exising (webview based) notebooks?

Yes it is, IIRC Kim-Adeline opened an issue for that too, although I can't find it now...

Closing for now, as this is an existing issue in standard notebooks.


Can't print in  arabic ?

@AlhassanMousa  Yes. You are right. I checked but arabic is not in available languages.
You can refer this for an alternative workaround .
https://github.com/tr3v3r/react-native-esc-pos-printer/issues/54#issuecomment-1104241671


Add the ability to handle Jupyter magics in code blocks

Several popular packages use Jupyter magics (%) in code cells to set some options.
For example, just to name a few IPython, ipyparallel, and HoloViews do this.
With this PR, blacken-docs is able to format cells that contain %%someoption.

this isn't safe as discussed in #36


[CHUNKCOPY_SAFE] Fix off-by-one error

When chunk size is more than 8 bytes, the comparison logic failed if remaining buffer length was one less than chunk size.

For example when using AVX2 with buffer length of 31 bytes, it would write past end of buffer.
When len is less than remaining buffer length, CHUNKCOPY_SAFE now uses smaller chunks to avoid writing past of end of buffer.

@nmoinvaz

I don't think there is any off by one issue. Having the MIN() is good. But to properly do the limit this is what code I was playing around with. It didn't make a difference with the #979 but it does prevent limiting of the output.

I haven't tested it very well. It ways makes sure that CHUNKCOPY has a multiple of chunksize. Because it is possible in the original function for say (safe - out) = 43. It would then write 32 * 2 or 64 bytes. It does probably decrease performance because it has to do multiple memcpy's to get the initial alignment.
What do you think?

It also has to be combined with this change in chunkmemset:

This may be the off by one issue you are noticing.

I was thinking of adding
len = MIN(len, safe - out + 1);

to top of CHUNKCOPY_SAFE. That would make the comparison cleaner...

@mtl1979 are you able to make the MIN() move into its own PR? There are many places in inflate code that could also benefit from it.

@nmoinvaz I don't think separating the move of MIN() is hard...

Rebased.

I still don't understand why it is off by one.

@nmoinvaz
If you have buffer of 31 bytes, it is indexed from 0 to 30... That is where the - 1 comes from in one of the calling functions. I tested it by removing the + 1inside MIN() and tests started failing. It is only relevant when both len and the safe length are less than size of chunk_t but not equal.
Safe length can calculated by formula 30 (end index) - 0 (start index) + 1 = 31.
In this case it comes to the comparison, which is < and not <=... It has to fall through if safe length is same as size of chunk_t.

Please rebase, so we get the new CI-tests too :)

Even with that code, the performance suffers compared to HEAD. In my comment on #979 I mentioned that we could also do a detection based on whether or not the same buffer is used and in instances where same buffer is used, then we force safe versions, otherwise we don't use safe versions for the speed improvement.

@nmoinvaz I didn't expect it to be magical solution that counteracts whole speed drop... What I was referring to is that this pull request is solely about fixing a single issue and that making improvements that counteract the speed drop would require waiting for merging your pull request first... Doesn't really make sense to do benchmarks until all possible improvements are made.
Obviously we can use both "unsafe" versions if remaining buffer length is at least three times the chunk size due to stricter requirement of chunkmemset. I'm just not sure if adding extra branches in speed critical part of the code is a good thing..

I am considering this PR for Stable as it is pretty small. But I want to postpone #987 to Next Devel since it is pretty much a refactoring of a lot of code and not a bugfix.
If there are smaller self-contained changes we should backport to Stable from #987, I'd like to hear about them.
We can live with a little speed degradation in Stable, it is not optimal but lets prioritize correctness and stability over speed.

@Dead2 I can't really comment about #987 until it is finished... It started as a small patch like this one but now it's pretty much complete rewrite of the related functions. When it is finished, it might be even worth the effort trying to split it as two or more separate pull requests.

Can you split the commit into two? One with the off by one error that you found. The other commit with the fix to inflateBack which I found. On the second commit can you add me as a co-author since it took me several days to hunt it down and come up with possible solutions for?
After that I will try and benchmark this PR so we can qualify the speed degradation.

@nmoinvaz Done.

Thanks. Those are better commit messages too. Nice!

ZLIB-NG (HEAD)
 Tool: minigzip-ng-commit-0.exe Levels: 1-9
 Runs: 70         Trim worst: 40

 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 1     48.014%      1.119/1.135/1.143/0.006        0.781/0.793/0.799/0.004      111,512,026
 2     35.391%      1.891/1.919/1.934/0.011        0.789/0.812/0.819/0.006       82,195,416
 3     34.039%      2.323/2.354/2.368/0.013        0.784/0.793/0.798/0.004       79,055,001
 4     32.751%      2.782/2.811/2.825/0.011        0.761/0.769/0.776/0.005       76,065,070
 5     32.484%      3.001/3.030/3.048/0.015        0.750/0.766/0.773/0.005       75,443,521
 6     32.318%      3.635/3.671/3.693/0.016        0.752/0.764/0.769/0.004       75,057,363
 7     32.061%      4.896/4.934/4.969/0.025        0.750/0.762/0.770/0.006       74,461,300
 8     31.978%      7.486/7.537/7.591/0.028        0.750/0.760/0.767/0.005       74,269,032
 9     31.961%   10.148/10.211/10.270/0.031        0.751/0.762/0.769/0.005       74,230,342

 avg1  34.555%                        4.178                          0.776
 tot                               1128.053                        209.449      722,289,071

ZLIB-NG (COMMIT 1)
 Tool: minigzip-ng-commit-1.exe Levels: 1-9
 Runs: 70         Trim worst: 40

 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 1     48.014%      1.123/1.142/1.150/0.007        0.795/0.811/0.817/0.006      111,512,026
 2     35.391%      1.881/1.902/1.920/0.012        0.843/0.856/0.864/0.006       82,195,416
 3     34.039%      2.295/2.341/2.360/0.015        0.832/0.848/0.855/0.006       79,055,001
 4     32.751%      2.755/2.783/2.803/0.013        0.801/0.815/0.822/0.006       76,065,070
 5     32.484%      2.968/3.008/3.032/0.016        0.799/0.814/0.820/0.005       75,443,521
 6     32.318%      3.604/3.641/3.668/0.020        0.801/0.815/0.825/0.006       75,057,363
 7     32.061%      4.847/4.904/4.943/0.027        0.804/0.814/0.821/0.005       74,461,300
 8     31.978%      7.464/7.510/7.569/0.035        0.802/0.814/0.823/0.005       74,269,032
 9     31.961%   10.110/10.193/10.277/0.052        0.796/0.812/0.820/0.008       74,230,342

 avg1  34.555%                        4.158                          0.822
 tot                               1122.726                        221.977      722,289,071

ZLIB-NG (COMMIT 2)
 Tool: minigzip-ng-commit-2.exe Levels: 1-9
 Runs: 70         Trim worst: 40

 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 1     48.014%      1.133/1.151/1.161/0.008        0.923/0.940/0.947/0.007      111,512,026
 2     35.391%      1.840/1.862/1.873/0.011        0.960/0.971/0.978/0.006       82,195,416
 3     34.039%      2.266/2.290/2.304/0.011        0.932/0.947/0.954/0.005       79,055,001
 4     32.751%      2.723/2.753/2.772/0.016        0.908/0.921/0.927/0.005       76,065,070
 5     32.484%      2.944/2.977/2.996/0.015        0.900/0.913/0.921/0.006       75,443,521
 6     32.318%      3.585/3.613/3.633/0.016        0.902/0.910/0.918/0.004       75,057,363
 7     32.061%      4.925/4.971/5.007/0.025        0.890/0.907/0.913/0.005       74,461,300
 8     31.978%      7.529/7.581/7.636/0.037        0.892/0.905/0.913/0.006       74,269,032
 9     31.961%   10.172/10.265/10.338/0.056        0.886/0.902/0.910/0.006       74,230,342

 avg1  34.555%                        4.163                          0.924
 tot                               1123.917                        249.539      722,289,071

So about 19% slower... That sounds a lot, but I expected it as chunkmemset_safe() isn't currently optimized at all...

@mtl1979 you may be able to cherry pick https://github.com/zlib-ng/zlib-ng/pull/987/commits/f5325ab3b4ba03da2d713140e18e25f8e147c214 for the speed gains.

I think this "off-by-one" should be its own PR with 1 commit and anything else should be a separate PR.

I think this "off-by-one" bug should be its own PR with 1 commit and anything else should be a separate PR.

Maybe... I just wanted to keep them together to test for any side-effects... If I separate, the "remaining" part must be merged in before the "off-by-one" fix. Then I can just rebase over for a really clean diff.

LGTM, but I am not so steady on the intricacies of the chunkset code, so I have not verified its correctness but rather its scope.

@Dead2 From the start nobody was really sure about correctness of the chunkset code, they just assumed it was correct because it didn't crash or fail any CI tests back then... After adding pigz test, this is the first pull request that doesn't fail it and does not introduce new failures either. Codecov test fails only because this pull request replaces direct calls to two functions with indirect calls through another set of two functions.
It's really hard to spot off-by-one errors in any code and even more when there is guard bytes added by user application instead of the C library.

@mtl1979 I am aware. I meant that I'll need to wait for @nmoinvaz or someone else to approve as well. 😄

@Dead2 I know... Controversial patches require two long-time collaborators... I already asked @nmoinvaz to recheck ;)

Baseline 5cfb7f15e32bc16ec4cca82b9c094bb886456e4c
   text    data     bss     dec     hex filename
 111264    1296      32  112592   1b7d0 libz-ng.so.2

 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 1     57.780%      1.874/1.898/1.908/0.008        1.057/1.095/1.107/0.010       90,924,650
 2     43.876%      2.032/2.045/2.051/0.005        0.690/0.702/0.708/0.005       41,427,218
 3     42.490%      2.093/2.109/2.118/0.007        0.562/0.570/0.574/0.003       33,432,016
 4     41.467%      2.021/2.042/2.052/0.009        0.432/0.443/0.448/0.004       26,101,482
 5     41.212%      2.158/2.199/2.209/0.010        0.432/0.441/0.446/0.004       25,940,920
 6     41.039%      1.922/1.933/1.940/0.005        0.321/0.331/0.336/0.004       19,374,021
 7     40.781%      1.658/1.666/1.671/0.004        0.210/0.218/0.221/0.003       12,834,980
 8     40.706%      2.074/2.084/2.090/0.006        0.212/0.217/0.221/0.002       12,811,166
 9     40.695%      2.264/2.280/2.286/0.005        0.209/0.218/0.222/0.003       12,807,941

 avg1  43.339%                        2.028                          0.471
 tot                                547.633                        127.059      275,654,394

PR #982 eb212936dd6da4222f566ea82f8ad48665aa614c
   text    data     bss     dec     hex filename
 111456    1296      32  112784   1b890 libz-ng.so.2

 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 1     57.780%      1.882/1.902/1.910/0.006        1.263/1.280/1.285/0.005       90,924,650
 2     43.876%      2.029/2.041/2.047/0.005        0.814/0.827/0.833/0.004       41,427,218
 3     42.490%      2.091/2.109/2.116/0.006        0.657/0.677/0.683/0.006       33,432,016
 4     41.467%      2.021/2.041/2.049/0.007        0.517/0.527/0.533/0.004       26,101,482
 5     41.212%      2.133/2.195/2.207/0.013        0.517/0.525/0.530/0.004       25,940,920
 6     41.039%      1.916/1.930/1.939/0.006        0.386/0.392/0.395/0.002       19,374,021
 7     40.781%      1.654/1.663/1.669/0.005        0.249/0.259/0.263/0.003       12,834,980
 8     40.706%      2.071/2.086/2.093/0.006        0.243/0.258/0.262/0.004       12,811,166
 9     40.695%      2.261/2.279/2.287/0.008        0.251/0.258/0.261/0.003       12,807,941

 avg1  43.339%                        2.027                          0.556
 tot                                547.381                        150.102      275,654,394

I am getting some warnings now on MSVC:
C:\Users\Nathan\Source\zlib-ng\chunkset_tpl.h(40,35): warning C4244: '=': conversion from '__int64' to 'unsigned int',
possible loss of data [C:\Users\Nathan\Source\zlib-ng\build-x\zlib.vcxproj]
  compare258.c
  compress.c
  crc32.c
  crc32_comb.c
  deflate.c
  deflate_fast.c
  deflate_medium.c
  deflate_quick.c
  deflate_slow.c
  functable.c
  infback.c
  inffast.c
C:\Users\Nathan\Source\zlib-ng\inffast.c(267,88): warning C4244: 'function': conversion from '__int64' to 'unsigned int
', possible loss of data [C:\Users\Nathan\Source\zlib-ng\build-x\zlib.vcxproj]
  inflate.c
  inftrees.c
  insert_string.c
  trees.c
  uncompr.c
  zutil.c
  Generating Code...
  Compiling...
  x86.c
  slide_avx.c
  chunkset_avx.c
C:\Users\Nathan\Source\zlib-ng\chunkset_tpl.h(40,35): warning C4244: '=': conversion from '__int64' to 'unsigned int',
possible loss of data [C:\Users\Nathan\Source\zlib-ng\build-x\zlib.vcxproj]
  compare258_avx.c
  adler32_avx.c
  insert_string_sse.c
  compare258_sse.c
  chunkset_sse.c
C:\Users\Nathan\Source\zlib-ng\chunkset_tpl.h(40,35): warning C4244: '=': conversion from '__int64' to 'unsigned int',
possible loss of data [C:\Users\Nathan\Source\zlib-ng\build-x\zlib.vcxproj]

@nmoinvaz That's because I didn't change the function signatures to use z_size_t instead of unsigned int...

Casting the pointer difference to unsigned int would have introduced possible wraparound bug, as the result is allowed to be -1. Any negative difference except -1 is expected to crash.

How is it allowed to be -1?

@nmoinvaz Because 1 is added to the pointer difference, -1 as difference means the passed-in buffer is full. Because it is now using the safe version of both chunkcopy and chunkmemset, it is allowed (even if it doesn't ever happen in normal circumstances) and essentially no-op. -2 as difference would result in all bits set in safe length, which would most likely overflow.


use snake case

resurrecting #111 as this has been annoying me slightly
it's true that python numpy and pandas are inconsistent here, but we have chance to do things differently and better in this standard - I suggest we just use snake case consistently

+1, especially given that we also use skip_nulls

thanks for your reviews
merging then to keep things moving, can revert if there's objections


Adding support for Vector2f and HapticApply redo

sorry for the duplicate pull request somehow my branch got messed up by the formatting changes. If I remember correctly I fixed all the comments.

Can you resolve the conflict, @peg-danielse?

There you go :)


OnLoad does not execute when loading addon

profile.OnLoad does not execute when using /addon load or /addon reload . Is that expected?
Executes fine with /lac reload and when changing jobs.

Can you give an example of the OnLoad code that isn't executing?  Having difficulty reproducing this one.

For additional clarification, addon load will look for a profile in the format:
Ashita/config/addons/luashitacast/Name_ID/JOB.lua
then, it will look for the format:
Ashita/config/addons/luashitacast/Name_JOB.lua
If either is found, it should load them and execute the onload events.  If luashitacast is on autoload, that will occur when you select a character as you do not initially have a character name until you log in.  OnLoad seems to trigger correctly for me in both cases, if that is not the case I suspect it may be something related to the contents of the OnLoad event.

It is my issue. Apologies for the inconvenience. I thought I had tested with the default Name_ID/JOB.lua, but apparently I didn't.
I have been running a single config for all jobs on a character. I did this with ashitacast to avoid replication of some  light automation that I am mostly migrating to my own addons in v4. Anyway, I was using the chat manager to call /lac load within OnLoad. Turns out that is a bad idea which makes sense. If I call gState.LoadProfileEx directly within OnLoad, it works as expected. There are a couple other ways I can get similar results that I may switch to. I'm still playing around to figure out what works for me.

If your goal was to have a profile for each job that does nothing besides loading the other jobs' profile, you could best accomplish it by using something along the lines of:
return gFunc.LoadFile('alljobs.lua');
You would still need to actually load alljobs.lua to use addset, but this would avoid potential problems caused by calling load from OnLoad, as it would hand over the full file without triggering another load.
A more practical approach would probably be to avoid any automation within LuAshitacast and isolate it to addons.  If there is a distinct reason to tie something to LAC, you can use loadfile, require, or gFunc.LoadFile to load in extra lua documents that multiple profiles will require.


Building Omni Core <IP_ADDRESS> release

Just for the reference and completness, so we're on the same level.
The previous steps are based on:

https://github.com/OmniLayer/omnicore/blob/omnicore-0.0.10/doc/gitian-building.md

If needed, refresh the inputs (from ~/gitian-builder):
make -C ../omnicore/depends download SOURCES_PATH=`pwd`/cache/common

If needed, download the SDK for OS X (stored in ~/gitian-builder/inputs):
wget https://s3.amazonaws.com/ci.omnicore.private/depends-sources/sdks/MacOSX10.7.sdk.tar.gz

Update the local copy of Omni Core:
git clone https://github.com/OmniLayer/omnicore.git

Then set the environment:
SIGNER=dexX7
COMMIT=v<IP_ADDRESS>
RELEASE=<IP_ADDRESS>

Note: the release is tagged with v<IP_ADDRESS> instead of v<IP_ADDRESS>-rel, even though the version suffix in Omni Core itself is -rel.
Build for Windows:
./bin/gbuild --commit omnicore=${COMMIT} ../omnicore/contrib/gitian-descriptors/gitian-win.yml
./bin/gsign --signer ${SIGNER} --release ${RELEASE}-win --destination ../gitian.sigs/ ../omnicore/contrib/gitian-descriptors/gitian-win.yml
mv build/out/omnicore-*.zip build/out/omnicore-*.exe ../

Build Linux:
./bin/gbuild --commit omnicore=${COMMIT} ../omnicore/contrib/gitian-descriptors/gitian-linux.yml
./bin/gsign --signer $SIGNER --release ${RELEASE}-linux --destination ../gitian.sigs/ ../omnicore/contrib/gitian-descriptors/gitian-linux.yml
mv build/out/omnicore-*.tar.gz build/out/src/omnicore-*.tar.gz ../

Build for OS X:
./bin/gbuild --commit omnicore=${COMMIT} ../omnicore/contrib/gitian-descriptors/gitian-osx.yml
./bin/gsign --signer $SIGNER --release ${RELEASE}-osx-unsigned --destination ../gitian.sigs/ ../omnicore/contrib/gitian-descriptors/gitian-osx.yml
mv build/out/omnicore-*.tar.gz build/out/omnicore-*.dmg ../

Finally continue with signing the results, as described in the gitian.sigs guide:

https://github.com/OmniLayer/gitian.sigs/blob/master/CONTRIBUTING.md

For discussion about building <IP_ADDRESS>, see #412.

Windows:
6031f47abb694aea05f275131fdcfc1fe10c84af74cc18aa8beab431038cc50e  omnicore-<IP_ADDRESS>-rel-win32-setup.exe
e60a5b5ff56e9433dd154a437c16db0357f91e35af1c7591c13594c88db2fb72  omnicore-<IP_ADDRESS>-rel-win32.zip
ecc126ac55039c6efca38da10eddf51c8a850f02ab42cca68bfe578865247e75  omnicore-<IP_ADDRESS>-rel-win64-setup.exe
848a16fb8d8ea7114e2903cdab4d6448914cdc5d8b059ee224346461314e2e68  omnicore-<IP_ADDRESS>-rel-win64.zip
ee623b27558ab0849e56ff1310346f66d1ea7ad9bab7b9168887f3d1538d863b  src/omnicore-<IP_ADDRESS>-rel.tar.gz

Linux:
3ae3dbca72b471dc3a96b5a3860a0df3b43204c3d79bf714ea696666d925ba34  omnicore-<IP_ADDRESS>-rel-linux32.tar.gz
796a20be76df9ce68e8a9c23c7ac3f66ae3c41af24e66333097c63b05b7bc1e5  omnicore-<IP_ADDRESS>-rel-linux64.tar.gz
ee623b27558ab0849e56ff1310346f66d1ea7ad9bab7b9168887f3d1538d863b  src/omnicore-<IP_ADDRESS>-rel.tar.gz

OS X:
3f2f317d2d0b2335d2d4a13c995a97f39c40b1e64684d9ca8c43ece512735b3e  omnicore-<IP_ADDRESS>-rel-osx-unsigned.dmg
614c776efb98e2871dc91cff82b20abbaceebdb7e9f432c745d53db96ae4a06a  omnicore-<IP_ADDRESS>-rel-osx-unsigned.tar.gz
9de0a3b67ba213c4dd22f60cb1919ae072c32e92238355d178381e8006ccfcc4  omnicore-<IP_ADDRESS>-rel-osx64.tar.gz
ee623b27558ab0849e56ff1310346f66d1ea7ad9bab7b9168887f3d1538d863b  src/omnicore-<IP_ADDRESS>-rel.tar.gz

Hey dude, thanks for this...  I'm wondering though if we shouldn't call this <IP_ADDRESS>?
The old <IP_ADDRESS> whilst not announced or published with binaries, was however tagged as release in GitHub for a week or so.  Given that was also the time All-Pair trading went live, and older clients would have to upgrade, I think it's at least possible that some of our users are compiling from source & thus we'd have <IP_ADDRESS> out in the wild without the fixes - which would make releasing this in essence two different <IP_ADDRESS>'s.
That broken version (which still reports the same 1100200 version as this build) would activate a faulty version of fees and be out of consensus.
I know we didn't announce or provide binaries, but we did tag the release on GitHub.  Thus perhaps this new build should be <IP_ADDRESS> and just skip <IP_ADDRESS> altogether.  What do you think?
Sorry, I should have thought of this earlier before you did your builds :(

Hmm.. I don't think the tag itself makes much of a difference for users building from source, which usually just clone and build - at least that's what I'd assume.
Given that the release is going to be properly released, with binaries and announcements, we could underline that this is a new version.

lt's not just the tag though - we merged the commit to bump the version to 1100200 ten days before we merged the fees fixes.  That means it's at least possible, that there are version 1100200 clients without the fees fixes.
It therefore makes sense to me to play it safe and use 1100300 for this version and for the fees activation, to remove any possibility of an out-of-consenus 1100200 client.
Hope that makes sense :)

Hmm..
I'm not conviced we should skip a version and go to <IP_ADDRESS>, because .11.2 hasn't been properly released, but I see your point for the activation.
If we do this, we'd need to bump the version (note: we could also bump to 1100201), update the release notes to include the bump PR, then publish a new tag.

I'm happy keeping it as .11.2 if we bump to 1100201 internally (that satisfies my concerns about making sure clients have the fees fix when it comes to activation).
Sorry to raise it so late...

No worries, give me a second to push the version bump. :)

Thanks dude :)

Alright, here is the new tag. :)
https://github.com/OmniLayer/omnicore/releases/tag/v<IP_ADDRESS>

8f28fdeffae88bb9d3e5dc7fb8770b4236430d496af0416bd1c3b7b1e4fde1af  omnicore-<IP_ADDRESS>-rel-win32-setup.exe
56331224e14d31855f92c5148a9abdb55722e2fa5167c2f440ccb890298e1638  omnicore-<IP_ADDRESS>-rel-win32.zip
83995f1da7fcd3baecc25a3050630d7aa7c76e82e42dd8e99baf5db5775becfb  omnicore-<IP_ADDRESS>-rel-win64-setup.exe
7fb65b481abf7c0b2df4784ef741ea23949af7df1359d2631fa7b6b515695214  omnicore-<IP_ADDRESS>-rel-win64.zip
5302626fbd8ec2444485bff304bc83acfde97a89574eaf65bbf050ea3c2d69f0  src/omnicore-<IP_ADDRESS>-rel.tar.gz
e638946d320a386cb6d200c2200380d1cd7604de1aa0d84f1e19ff623e361327  omnicore-win-0.10-res.yml

dda1b72e0ac2b8b0bbbe1e859dc59a69dbc8517520bf4a6208654a46a8315cfe  omnicore-<IP_ADDRESS>-rel-linux32.tar.gz
787e5fef50118f59d76128d3a8435efc355b3a18962c3e209a79556e47a48ec4  omnicore-<IP_ADDRESS>-rel-linux64.tar.gz
5302626fbd8ec2444485bff304bc83acfde97a89574eaf65bbf050ea3c2d69f0  src/omnicore-<IP_ADDRESS>-rel.tar.gz
0f00054e354d0dc4a9e79f9aa4c083d414833d41bab0084ddb1098e0ff8ba704  omnicore-linux-0.10-res.yml

5388f0d3719bad8ea8c4d4b567f58b8044300fcd457b16503d3a7bc40bbe4f0b  omnicore-<IP_ADDRESS>-rel-osx-unsigned.dmg
676cf86ce76b9b5f2699a53b33ce04df3b4799cb2539e57aedee2bebf09fc3cb  omnicore-<IP_ADDRESS>-rel-osx-unsigned.tar.gz
507b0ff33abcf3855d5b82f28c40e22a20605877cd0bb40ac13cb362ec02adff  omnicore-<IP_ADDRESS>-rel-osx64.tar.gz
5302626fbd8ec2444485bff304bc83acfde97a89574eaf65bbf050ea3c2d69f0  src/omnicore-<IP_ADDRESS>-rel.tar.gz
6bbe4c98d33333952538d45af063a9746dd8ecf93614166131a3d5b18c6473ff  omnicore-osx-0.10-res.yml

https://github.com/OmniLayer/gitian.sigs/pull/38

Alright, my results match! :)

Omni Core <IP_ADDRESS> was verified and created successfully. :)
Downloads
You can download Omni Core <IP_ADDRESS> here:
Windows
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-win64-setup.exe
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-win64.zip
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-win32-setup.exe
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-win32.zip
OS X
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-osx64.tar.gz
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-osx-unsigned.dmg
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-osx-unsigned.tar.gz
Linux
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-linux64.tar.gz
https://bintray.com/artifact/download/omni/OmniBinaries/omnicore-<IP_ADDRESS>-rel-linux32.tar.gz


*: more detailed timeout logging

Fix https://github.com/coreos/etcd/issues/3328.

/cc @xiang90

Just fixed test failures...

I feel line942 in server.go is the only reasonable place to add timeout. For other places, we need to ensure the error is actually caused by timeout. If it is hard, then just do not print out timeout at all.

@xiang90 I just kept the one for etcdserver/server.go, as you suggested. PTAL.
Think it will complicate our code base if we try to find out the error was from timeout or not. It makes sense just to keep the obvious one.
Thanks.

@xiang90 Just fixed. PTAL. Thanks.

LGTM

thanks. merging in greens.


[Scope Change] Table Sales Shipment Header - EmailRecords

Request to remove Scope('OnPrem') from function EmailRecords in table "Sales Shipment Header".
It would also be nice if an extra function to email Posted Shipments can be added to page "Posted Sales Shipments" similar to "Posted Sales Invoices".

Same need than @ajkauffmann
Is it on the roadmap ?

Same need than @ajkauffmann
Is it on the roadmap ?

Scope('OnPrem') removed.
This is not the right place to ask about functional changes, instead you can always add new idea on http://aka.ms/bcideas. I think shipment e-mail story already requested here.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


CodeQL PowerShell Support

CodeQL does not currently support PowerShell.  Given that PowerShell is quite a potent language that has been used to great effect by red team and blue team alike, this lack of functionality hurts both CodeQL and PowerShell.
I am deeply familiar with the PowerShell AST and would likely be able to make CodeQL PowerShell language support work, if the team can help provide the right guidance on integration.
Please provide more information about how one can write new CodeQL bindings, so that I might turn this issue into a more useful pull request.

Awesome to hear this! A teammate of mine developed a PowerShell extractor actually, which allows PowerShell source code can be converted to a CodeQL database. The extractor can be found here: https://github.com/github/codeql-action/issues/2366. Please. It doesn't matter if the release version is a bit behind, you can just grab the latest powershell.zip and unzip that folder next to your codeql executable. Once you do this, you should be able to run any commands related to extraction/db creation with "powershell" as the language.
What we really need now to enable analysis is the core CodeQL libraries for PowerShell. We have built out a bunch of these already, but core libraries related to the AST such as AST.qll, Cfg.qll, and Dataflow.qll need to be populated so that we can start building out qlls on top of them. Here is a repository that has been set up recently that shows how this is done for a simple/demo language, kaleidoscope: https://github.com/aibaars/codeql-kaleidoscope/tree/main (go to ql/lib/codeql/kaleidoscope). Some of these core libraries can probably be shared libraries now (and we can update the kaleidoscope repo to reflect that), @aibaars can explain further there.

@dilanbhalla @aibaars Thanks for providing some context.  Please provide a bit more :-)

This looks somewhat workable (I would appreciate setting up a call to understand the implementation, as I am not a codeQL expert).

Please link to building instructions for a *.qll file
Please link to whatever specification you have (EBNF,ANTLR, etc) for the syntax
Please set up time if you are able.

Additionally, if I'm reading the kaleidoscope example correctly, what you're doing is synergistically aligned with a metaprogramming language I build, Pipescript.  A major component of that language is AST manipulation.  Another major component is an open-ended definition of languages.  Here are a couple of items I believe we should also look at:

Using a code QL as a selector for any programming language (aka "select a class named this, regardless of language")
Denoting transformations of code (aka, "find any foldable region named 'Internal', and remove it")

Please let me know what you think of these scenarios, and if you'd expect either of them to be "natively" handled by CodeQL in the near/mid future.
Forgive me if these are foolish questions; I'm a PowerShell expert, not a CodeQL expert.


Update Running.md

line 29, fixed added "" to fix script

First ! #230 ;)

This was fixed in #230 , but thanks for the contribution :)


Add audit log

All financial transactions should be logged for auditability

Maybe Kibana in the ELK stack?

Basic implementation done in https://github.com/macterra/artx-market/commit/10f33fdb61b38f211753ee5ceb3fc93ff5b69c84


popover should include horizontal direction

currently the popover will open right of the target that opens it. This should be configurable to open left, right, up, down, etc. It should also be smart enough to know when it's reached the edge of the window. It currently opens to the right, OFF the screen and has no ability to open to the left of it. This makes the component unusable for targets that sit on the right side of the screen.

I've created a gitter room for this project. https://gitter.im/p-angular2-mdl-ext/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link You can talk to me on there. You should create an official one for your project. Mine is based off my fork. It's free :)

Hi, I have made a PR to make popover position to be configurable same way as it is for mdl-menu component.
Could you please take a look?
https://github.com/mseemann/angular2-mdl-ext/pull/1082


[Feature] Implement a setItems(Collection items) method for ComboxBox

Describe the solution you'd like
A method should exist that lets Developers use a setItems method, so they don't have to manually check for duplicates and don't have to iterate through a set of Items their selves.
Desired Features:

Automatic Deduplication
Passing a list directly without the need to call add for every Item individually

@ckochaneck Have you tried insert method. It is meant for bulk inserting:
https://javadoc.io/doc/com.webforj/webforj-foundation/latest/com/webforj/component/list/DwcList.html#insert(int,com.webforj.component.list.ListItem)

@ckochaneck also check: https://documentation.webforj.com/docs/components/list-components/lists#managing-listitem-objects-with-the-api

The insert method still requires to build a List of ListItems first, which defeats the purpose.

@ckochaneck what are you expecting to pass to the method ? What "T" refers to in Collection ?


Use 'vitest' instead of 'vitest run' to allow watching

vitest defaults to watch mode when in development, but non-watch mode in CI. vitest run always exits after a run.
This PR switches from using vitest run to vitest, so that we automatically use watch mode in local development when running pnpm test inside any package directory.

this broke our turbo.json config, which expects the test script in every package to be non-persistent and be cacheable


fix(iterations): fixes the date shifting when used in GMT-X timezones

Fixes the one day shift of start and end dates of iterations when used in GMT-X timezones (everything west of Europe).

Fixes https://github.com/fabric8io/fabric8-ui/issues/1188

why is this even messing with tz values ? shouldn't we always store/manipulate UTC and just render based on current timezone ?

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1824-fabric8-planner.int.rdu2c.fabric8.io

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1824-fabric8-planner.int.rdu2c.fabric8.io

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1824-fabric8-planner.int.rdu2c.fabric8.io

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1824-fabric8-planner.int.rdu2c.fabric8.io


Fix link about gRPC Server Reflection for Node.js

Node.js now has the package for gRPC Reflection.
https://github.com/grpc/grpc-node/tree/master/packages/grpc-reflection
This PR changes the link to the package.
release notes: no

@murgatroid99 ping


Use Launcher App for Launch at Login

Hi Steve,
As discussed a few weeks ago, there is the way to launch the app on login with a launch helper app.
Basically, you can only register an App to launch at login from outside the app itself, hence we need a helper app that is registered and doesn't do anything but launch the main app when it is started.
I tried to remove IYLoginItems completely but as I have no experience with CocoaPods, please check if I didn't mess up anything.
Let me know if you can test it succesfully:)
Nicolas

Amazing work, thanks!
I'll be away for most of the weekend, but I'll test either towards the end of the weekend or early next week, then hopefully I can get it uploaded to the App Store!

Hey Nicolas!
It all looks good, but I can't quite get it to work! Here's what I'm doing:

In the current version of TopDrawer, uncheck 'open at login' in the settings, so that it's removed from the login items. (so we don't get a false positive)
Build the new version, and overwrite the old one in the applications directory
Open the new TopDrawer and check 'open at login' in the settings
Restart machine
TopDrawer doesn't launch

Took a quick look at the code, and I think there's a couple of things that might be missing.

There should be some point at which the helper application gets registered to be run on launch somehow. I can't see where that is at the moment.
When toggling the 'open at login' checkbox in the settings panel, that results in AppDelegate.launchAtLoginUserDefaultKey being set in UserDefaults, but I think the helper application should probably read that value when it launches and then decide not to launch the main application if it's false.

Let me know if you can get it working and I'll give it another test. Or if you think that I'm not testing it correctly then let me know!

Hi Steve,
Yeah you are right of course. I was a bit sloppy as I thought I'd first push a first draft for review. In the rush I thought it would be all implemented and straightforward - sorry for that.
I added the missing line and fixed a typo I noticed when testing it after all. For my machine I can now assert it runs as expected. Let me know if that fixed it on your side too!

sorry the first PR wasn't where it should have been, but this should be fine now:)
No hurry, but just wanted to make sure it doesn't get lost;)

Hi Nicolas,
Sorry for the delay in getting back to you. I did test it, I've just didn't get round to commenting back on the PR, as I've been pretty busy for the last couple of weeks!
The changes to the code that you've made look good to me, although I was still unable to get it to open at login, again following the steps above.
Can you post the steps that you're following to test it, and I'll see if I can do the same?

Hi Nicolas,
Thanks for making those changes!
There may have some issues with testing on my setup, because I was still on High Sierra. I've updated to Mojave now, so that might resolve things. I don't think Top-Drawer needs to support anything but the latest macOS anyway, so If it works in Mojave then I'm happy with that.
I'm going to be travelling for the next couple of weeks, so I'll probably have to pick this up after that. When I'm back I'll give it another test though, and see if I can get it submitted to the store soon after.

Hi Steve,
Hmm, no I guess the same approach was working on High Sierra as well. I will try to double check everything then.
Enjoy your travels!
Nicolas

@nidegen Sorry for the delay in getting around to testing this again. Happy to confirm it all worked fine for me this time!
I'm not sure if it made any difference that I've updated to Mojave since the last time that I tested or not. Either way, I'm going to raise the minimum version to Mojave now, because I don't have a good way to test on older versions of macOS, and it's probably not worth the additional time investment anyway.
Thanks so much for all of the time that you've put in to this! I'll merge this in now, and I'll try to get a build submitted to the App Store in the next week or so!


Remove Outlook constraint

It would be more efficient to use EWS to periodically poll your phishing mailbox and send the reply than to install an Outlook client and leave it open on a server.
# Build a connection the Exchange Server
        $ExchangeService = New-Object Microsoft.Exchange.WebServices.Data.ExchangeService([Microsoft.Exchange.WebServices.Data.ExchangeVersion]::Exchange2010_SP1)
        $ExchangeService.Credentials = New-Object System.Net.NetworkCredential("DOMAIN\phishing", "<credentials>")
        $ExchangeService.Url = "https://mymailserver/EWS/Exchange.asmx"

        # Find the Inbox for the Phishing Mailbox
        $folderid = new-object Microsoft.Exchange.WebServices.Data.FolderId([Microsoft.Exchange.WebServices.Data.WellKnownFolderName]::Inbox,$Mailbox)
        $Inbox = [Microsoft.Exchange.WebServices.Data.Folder]::Bind($ExchangeService,$folderid)

        # Define a filter to only grab unread items
        $view = New-Object Microsoft.Exchange.WebServices.Data.ItemView(10)
        $SearchFilter = New-Object Microsoft.Exchange.WebServices.Data.SearchFilter+IsEqualTo([Microsoft.Exchange.WebServices.Data.EmailMessageSchema]::IsRead, $false)

        # Search the Inbox for unread items
        $Items = $Inbox.FindItems($searchFilter, $view)
        $itemCount = $Items.TotalCount

This is great, thanks! I'll take a look at this over the next few days.

No problem, I saw the talk on this in Vail and was interested to see how it worked under the hood, went out and started experimenting before this was released to try and self replicate and came away with these shortcuts.
Here is a snippet for sending the response to the reporting user using EWS in case you are interested in that as well.
Just create the HTML formatted email.  Make sure you reference any pictures in the HTML using their cid, and they have to be added as an inline attachment (see the Send-ThankYou snippet)
<img width=220 height=121 style='width:2.2916in;height:1.2604in' id="Picture_x0020_2" src="cid:logo.png" alt="cid:logo.png">

Function to send Thank You E-mail
function Send-ThankYou {
    Param(
        [string]$MailTo,
        [Microsoft.Exchange.WebServices.Data.ExchangeService]$Service,
        [switch]$Error
    )

    $email = New-Object Microsoft.Exchange.WebServices.Data.EmailMessage($Service)

    $email.Subject = "Thank you for your Phishing submission"
    $email.body = Get-Content $scriptPath"\Thank You.html" -Raw
    [void]$email.ToRecipients.Add($MailTo)
    [void]$email.Attachments.AddFileAttachment("logo.png", $scriptPath+"\logo.png")
    $email.Attachments[0].IsInline = $true
    $email.Attachments[0].ContentId = "logo.png"

    $email.SendAndSaveCopy()

}

Thanks!
I actually have the response aspect of the script configured to use the server, via the O365 phishing report account. I'm looking at adapting your scripts into the next piece, which performs analysis of the email that was submitted. If I can get that figured out, there will be no need to leave Outlook open. :-)

I have not had time to dive into this issue just yet, unfortunately. Appreciate the link to this project though - will have to dive into this and see if I can apply this non-interactive mailbox fix to PIE!

I believe that I've inadvertently fixed this problem with the following commit:
https://github.com/LogRhythm-Labs/PIE/commit/9e90ee1cdd522c7a63511a3ac4a72e15ba01238a
I was solving a separate issue and a side-effect is that you actually have to leave Outlook closed now in order to process mail properly in the background. If you have some time, please test and let me know if the updated code works for you.


Use chef-style comment header & proper berkshelf source

Auto-corrected with Cookstyle
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Warning

:warning:
This Pull Request is probably missing tests.

  Generated by :no_entry_sign: Danger

@tas50 a couple delivery issues here, should be a quick fix if you have time?


Document build failed on readthedocs

Describe the bug
Document build failed from v2.2.0 and later.
readthedocs project report

Build #18210121
v3.0.1
Build failed
Error message:
We encountered a problem with a command while building your project. To resolve this error, double check your project configuration and installed dependencies are correct and have not changed recently.
git clone --no-single-branch --depth 50 https://github.com/miurahr/aqtinstall .
git checkout --force e32291267992270f8b62b3b2f1d7da4888d441ab
git clean -d -f -f
git fetch --unshallow
fatal: --unshallow on a complete repository does not make sense
Command time: 0s Return: 128

Expected behavior
Build success and publish up-to-date documents.

Fixed by #587


Problem with extended ASCII characters

First off: let me thank you for implementing this great app!
I've tried to decode some BAS files, which were created around 93-94 by my IT teacher Ágnes Drong in elementary school (Hungary, Budapest). She was also a math teacher that time, therefore she wrote mostly mathematics related educational programs.
I got some strange results, when I tried to decode them, as they contain special Hungarian characters from the extended ASCII set.
Example:
$ ./convert.py matek/stul.bas
   10 CLS
   20 SCREEN 1:KEY OFF:H=0
   30 LOCATE 12,8:PRINT"SokszCONTgek tulajdonsDIMgai"
   40 X$=INPUT $(1):CLS
   45 PRINT:PRINT:PRINT

There the text should be "Sokszögek tulajdonságai". (Properties of polygons).
I've attached all files: matek.zip
EDIT: In the meantime I've figured that these files used the encoding:

Code page 437 (IBM PC)

I've committed a fix for it.
Created a pull request: https://github.com/danvk/gwbasic-decoder/pull/2


Get codenames of modular (linked) items in a newer way

Blocked: We should first decide if using debug is better or not in #12
Motivation
Up until now, the JS SDK was stripping the modular_content array of codenames of content items from the response. It is no longer the case.
Proposed solution
Remove the normalize.refillRichTextModularCodenames method in favor of using the new linkedItemCodenames property of rich text element objects.

Will be obsolete once https://github.com/Kentico/gatsby-source-kentico-cloud/pull/10 is merged.

Fixed via e1dfc74ebe495971ba2bec06aaffb3ae173bbdad


[TBBAS-1745] .NET Bindings - Build .NET Demo in CI

Type of change:

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] Pull request title reflects its content
[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Description:
For now the .NET Demo will be built and stored in the .NET Bindings directory, which can also be found in the setup package.
Later we have to consider to pack it separately including the sources as an example package.

I don't know why, but at the moment the installed directory c:\Program Files\openDAQ\bindings\dotnet\ contains binaries from 2024-01-26 and not the currently built ones.

[ ] I need to investigate where the Setup retrieves the binaries from and how I can update the place.


Restrict Redis to localhost

Admiral would benefit from doing so like https://github.com/cisagov/orchestrator/pull/139

In which repository does this issue belong?

In which repository does this issue belong?

I think the change would be made to this Docker composition file, which means the issue should be in cisagov/ansible-role-admiral.


Error in train.py

Thank you for providing the code.
I am trying to use train.by to train my model，but I encountered the following issue while using train.py
Traceback (most recent call last):
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/train.py", line 402, in
main(config)
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/train.py", line 326, in main
train_eval_loop_nomad(
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/vint_train/training/train_eval_loop.py", line 196, in train_eval_loop_nomad
ema_model = EMAModel(model=model,power=0.75)
TypeError: init() missing 1 required positional argument: 'parameters'
Traceback (most recent call last):
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/train.py", line 402, in
main(config)
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/train.py", line 326, in main
train_eval_loop_nomad(
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/vint_train/training/train_eval_loop.py", line 203, in train_eval_loop_nomad
train_nomad(
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/vint_train/training/train_utils.py", line 661, in train_nomad
loss.backward()
File "/home/iiau-vln/miniconda3/envs/nomad/lib/python3.8/site-packages/torch/_tensor.py", line 522, in backward
torch.autograd.backward(
File "/home/iiau-vln/miniconda3/envs/nomad/lib/python3.8/site-packages/torch/autograd/init.py", line 266, in backward
Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn

Try using EMAModel(model.parameters(), power=0.75) instead of EMAModel(model, power=0.75).

Thanks @zolmaeng!  Does that fix the problem, @zqs010908 ?
We also welcome PRs with reproducible bug reports :)

I have already used EMAModel(model.parameters(), power=0.75)，but a new problem has arisen
/home/iiau-vln/miniconda3/envs/nomad/lib/python3.8/site-packages/diffusers/training_utils.py:361: FutureWarning: Passing a torch.nn.Module to ExponentialMovingAverage.step is deprecated. Please pass the parameters of the module instead.
deprecate(
Traceback (most recent call last):
File "/home/iiau-vln/ws_zqs/nomad/ori_nomad/visualnav-transformer/train/train.py", line 402, in
main(config)
File "/home/iiau-vln/ws_zqs/nomad/ori_nomad/visualnav-transformer/train/train.py", line 326, in main
train_eval_loop_nomad(
File "/home/iiau-vln/ws_zqs/nomad/ori_nomad/visualnav-transformer/train/vint_train/training/train_eval_loop.py", line 203, in train_eval_loop_nomad
train_nomad(
File "/home/iiau-vln/ws_zqs/nomad/ori_nomad/visualnav-transformer/train/vint_train/training/train_utils.py", line 676, in train_nomad
ema_model.averaged_model,
AttributeError: 'EMAModel' object has no attribute 'averaged_model'
I found that the EMAModel class in diffusers.training_utils indeed does not have the averaged_model object. I see that the EMAModel in diffusion_policy has the averaged_model object, as referenced in line 31 of ema_model.py. I'm not sure if this method is correct.

And after I used the EMAModel in diffusion_policy, I found that it solved the previous problem, but now a new issue has arisen. I am using the config from nomad and training with the SACSoN/HuRoN dataset. Have you encountered this issue before?
Traceback (most recent call last):
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/train.py", line 402, in
main(config)
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/train.py", line 326, in main
train_eval_loop_nomad(
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/vint_train/training/train_eval_loop.py", line 203, in train_eval_loop_nomad
train_nomad(
File "/home/iiau-vln/ws_zqs/nomad/visualnav-transformer/train/vint_train/training/train_utils.py", line 860, in train_nomad
loss.backward()
File "/home/iiau-vln/miniconda3/envs/nomad/lib/python3.8/site-packages/torch/_tensor.py", line 522, in backward
torch.autograd.backward(
File "/home/iiau-vln/miniconda3/envs/nomad/lib/python3.8/site-packages/torch/autograd/init.py", line 266, in backward
Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn

Change line 31 of the file ema_model.py in diffusion_policy/diffusion_policy/model/diffusion/ from
self.averaged_model = model to  self.averaged_model = copy.deepcopy(model)


How does SQL know which column is the watermark column

In the instruction for setting looking up a new watermark.
The query uses "item().waternark_column" which looks very similar to item().table_name. However, it is feasible to tell a name of a table, but not straightforward to know which column is for the watermark as there can be many columns of datetime type. I don't see the watermark column is defined or declared anywhere in the instruction.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b540c63f-66b3-d07d-b3a8-284de931176d
Version Independent ID: 4002e018-4320-c978-061d-080d89761c8e
Content: Incrementally copy multiple tables using Azure portal - Azure Data Factory
Content Source: articles/data-factory/tutorial-incremental-copy-multiple-tables-portal.md
Service: data-factory
GitHub Login: @dearandyxu
Microsoft Alias: yexu

@wolftheice Looks like you have closed this issue, were you able to resolve the issue?

Hi Mike,
Thanks for following up. Yes, I saw the definition at the end.
Regards
Lawrence

Sent: Saturday, June 12, 2021 at 5:51 PM
From: "Mike Urnun" @.>
To: "MicrosoftDocs/azure-docs" @.>
Cc: "wolftheice" @.>, "Mention" @.>
Subject: Re: [MicrosoftDocs/azure-docs] How does SQL know which column is the watermark column (#76854)
@wolftheice Looks like you have closed this issue, were you able to resolve the issue?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/MicrosoftDocs/azure-docs/issues/76854#issuecomment-860071595


Do not round voucher net values

Description
Updated version of #915 against Shopware 5.3, please also see the discussion there.
Before this PR the net prices of vouchers were rounded to three decimal places in the basket. Articles in contrast have an exact net price, where the precisions is just limited by PHP itself.
This might seem like a minor thing, as only prices rounded to two decimal places are displayed to the customer. However this breaks the PAYONE plugin for certain baskets which calculates the gross value itself. The calculation itself is correct but is off by one cent with some constellations because of the missing precisions of the vouchers net value and PHPs imperfect internal float handling.
Example basket with 7 % VAT:

Position
Quantity
Value

Sample Article
1
112,50 €

Voucher 5 %

-5,63 €

SUM
106,87 €

But the PAYONE plugin takes the rounded net value of the voucher -5.257 and recomputes it to -5.62499 which is then then rounded to the incorrect value of -5.62 (off by 0,01 €). The code doing this can be found here and is correct, it's just not fed with enough precision in case of vouchers.
Orders like this are rejected by the PAYONE API as the summed basket value displayed to the user is transmitted as well and cross checked against the sum of the individual positions. The error returned is 1610: Article list faulty or incomplete in this case.

Questions
Answers

Why?
see above

BC breaks?
no

Tests exists & pass?
yes

Related tickets?
-

How to test?
Test case is included in the PR.

Requirements met?
sure

Hey @samuelvogel. I can confirm that this is working for the 7% calculation of your example. But I have another question. The calculated voucher values are directly stored into the s_order_basket. Payone, I guess, will use these values for calculation. When we save to the database we also lose precision. Thats why I get 5.62 in the 19% example when I calculate gross with the in s_order_basket stored value. It seems that the result totally depends on the prices that get calculated and in some cases these are correct and in some not. Can you confirm this error with 19% and your example prices? I calculated gross in calculateVoucherValues where full precision is available (5.63 correct) and in sGetBasketData after loadingBasketArticles from s_order_basket which results in 5.62.
How does Payone retrieve these values?

Payone works on the "fresh" PHP basket which gets recalculated on every request and not the "stale" database values. At shop.rapunzel.de the fix is deployed since 6 months and successfully prevents the problem from happening.
Can you reproduce the "wrong" value of 5.62 in the storefront actually? I can't in my own testing.
Also, as stated before, I think we can't go wrong with adding more precision during the calculation. Even if it leads to a corner case which accidentally led to a seemingly more correct value before. Anyhow, we can't even reproduce this drawback in the real world right now, can we?
Also this is not an issue about the rounding strategy in general, as only one voucher can be used per order, therefore concerns about when to round (before multiplying by quantity or after) do not apply.
Just for reference, this get's stored in the s_order_basket when the PR is applied:

Hey. No this was in my tests never an issue in the storefront. It is more that we have to decide between benefit, risks of breaking things etc. That Payone uses the "fresh" values makes then indeed a difference. We´ll discuss that.

Hello @samuelvogel, we evaluated this PR with a bigger group and came to the same conclusion. We do not want to change this behaviour of the basket right now and it will be reimplemented in our new version with the new basket. Thank you for your contribution. We always appreciate that.


Error: Argument list too long

Hi!
First of all, thanks for the great tool. Been using it for few days and really digging it.
I'm trying to publish a plan output of a larger environment, but I get an error "Error: Argument list too long". The  plan output is around ~2800 rows long.

Hey @MattiPuolitaivalGKGAB - sorry it's taken so long to get to this issue...it was an interesting one to investigate!
I've just opened an issue https://github.com/actions/virtual-environments/issues/3257 to see if there's a possibility of changing the underlying GitHub Actions VM.
Unfortunately, if that can't be done, your only option would be to use a self-hosted runner with the stack size bumped up.

SAM;storage allocation method; command ultra prompt;exe?

According to this post the maximum number of characters in a PR comment is 65536.
I have solved it by always truncating the plan before trying to post it.
- name: Format plan
  id: format-plan
  run: |
    plan=$(cat <<'EOF'
    ${{ format('{0}{1}', steps.plan.outputs.stdout, steps.plan.outputs.stderr) }}
    EOF
    )
    echo "PLAN<<EOF" >> $GITHUB_ENV
    echo "${plan:0:65536}" >> $GITHUB_ENV
    echo "EOF" >> $GITHUB_ENV

Would be nice if the action would solve that in some nice and informant way :)

@MattiPuolitaivalGKGAB the issue linked above has been merged in the actions repo and new GitHub VM runners have been rolled out this last week.
While I have not tested this, you should be able to pass in a much longer plan now - up to ~16MB of text. The PR commenter will still truncate it anyway here: https://github.com/robburger/terraform-pr-commenter/blob/c06d8f2ef864a84d4e7809af0946139faed59469/entrypoint.sh#L188 because of the GitHub comment limit...but it should not cause the build to fail anymore.

Excellent, thanks @robburger!

Hi @robburger,
we unfortunately also ran into this problem today with our plan output of ~3500 rows, which made the job fail. We are running on ubuntu-latest machines and use version 1.4.0 of the terraform-pr-commenter.
Did we overlook something?

Hi @JRo-connyun - I don't think you missed anything. Unfortunately, your plan is probably over the new 16MB input limit on the Actions runner instances (or they're not yet fully rolled out...)
In this case, the best option would be to add a new step after the plan to truncate before sending to the commenter step, like @Fresa has above. With that step above, a new PLAN environment variable becomes available to all steps.
A simpler way might be to use the set-output workflow function. e.g.:
- name: Terraform Plan
  id: plan
  run: terraform plan -out workspace.plan

- name: Truncate Plan
  id: truncate-plan
  run: echo "::set-output name=plan::${${{ format('{0}{1}', steps.plan.outputs.stdout, steps.plan.outputs.stderr) }}:0:65536}"

- name: Post Plan
  if: ...
  uses: robburger/terraform-pr-commenter@v1
  with:
    commenter_type: plan
    commenter_input: ${{ steps.truncate-plan.outputs.plan }}
    commenter_exitcode: ${{ steps.plan.outputs.exitcode }}

☝ Note: I haven't (yet) tested if this syntax is correct, or will work...
I will test it this weekend and add to the readme. Thanks for raising this again!

@robburger for what it's worth, the above does not work for me. The action exits with
Error: The template is not valid. System.InvalidOperationException: Maximum object size exceeded
   at GitHub.DistributedTask.ObjectTemplating.TemplateMemory.AddBytes(Int32 bytes)
   at GitHub.DistributedTask.ObjectTemplating.TemplateMemory.AddBytes(TemplateToken value, Boolean traverse)
   at GitHub.DistributedTask.ObjectTemplating.TemplateUnraveler.AllowScalar(Boolean expand, ScalarToken& scalar)
   at GitHub.DistributedTask.ObjectTemplating.TemplateEvaluator.Evaluate(DefinitionInfo definition)
   at GitHub.DistributedTask.ObjectTemplating.TemplateEvaluator.HandleMappingWithAllLooseProperties(DefinitionInfo mappingDefinition, DefinitionInfo keyDefinition, DefinitionInfo valueDefinition, MappingToken mapping)
   at GitHub.DistributedTask.ObjectTemplating.TemplateEvaluator.Evaluate(DefinitionInfo definition)
   at GitHub.DistributedTask.ObjectTemplating.TemplateEvaluator.Evaluate(TemplateContext context, String type, TemplateToken template, Int32 removeBytes, Nullable`1 fileId, Boolean omitHeader)

I am using these steps:
    - name: Terraform Plan
      id: plan
      if: github.event_name == 'pull_request'
      run: terraform plan

    - name: Truncate Plan
      id: truncate-plan
      run: echo "::set-output name=plan::${${{ format('{0}{1}', steps.plan.outputs.stdout, steps.plan.outputs.stderr) }}:0:65536}"

    - name: Post Plan
      if: always() && github.ref != 'refs/heads/main' && (steps.plan.outcome == 'success' || steps.plan.outcome == 'failure')
      uses: robburger/terraform-pr-commenter@v1
      with:
        commenter_type: plan
        commenter_input: ${{ steps.truncate-plan.outputs.plan }}
        commenter_exitcode: ${{ steps.plan.outputs.exitcode }}

Hi,
I am facing same exact situation, what has the final fix?
Thanks in advance

According to this post the maximum number of characters in a PR comment is 65536.
I have solved it by always truncating the plan before trying to post it.
- name: Format plan
  id: format-plan
  run: |
    plan=$(cat <<'EOF'
    ${{ format('{0}{1}', steps.plan.outputs.stdout, steps.plan.outputs.stderr) }}
    EOF
    )
    echo "PLAN<<EOF" >> $GITHUB_ENV
    echo "${plan:0:65536}" >> $GITHUB_ENV
    echo "EOF" >> $GITHUB_ENV

This worked for me.

Hello @menzenski, @robburger
Greetings.
Trying this fix but it doesn't seem to trim the plan.
https://github.com/robburger/terraform-pr-commenter/issues/6#issuecomment-976977894
Run echo "::set-output name=plan::${
/home/runner/work/_temp/0d83a182-527c-48f2-aa62-e77b6a733bee.sh: line 236: syntax error near unexpected token `('
Error: Process completed with exit code 2.

Using exactly same steps:
      - run: terraform plan -input=false -refresh=false
        id: plan-color
        continue-on-error: true

      - name: Truncate Plan
        id: truncate-plan
        run: echo "::set-output name=plan::${${{ format('{0}{1}', steps.plan-color.outputs.stdout, steps.plan-color.outputs.stderr) }}:0:65536}"

      - name: Post Plan PR comment
        if: steps.plan-color.outcome == 'success' || steps.plan-color.outcome == 'failure'
        uses: robburger/terraform-pr-commenter@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_PERSONAL_TOKEN }}
        with:
          commenter_type: plan
          commenter_input: ${{ steps.truncate-plan.outputs.plan }}
          commenter_exitcode: ${{ steps.plan-color.outputs.exitcode }}

I am also getting the Argument list too long error when trying to work with a terraform plan that is ~ 7k characters.


Passing value of datatype interval in parametrized query

I am trying to pass an interval as a query parameter. In the example query below, the table structure is simple - name is of type text, and creation_date is of type timestamp. So when I do something like
>pgo:query("select name from new_table where
current_timestamp - creation_date < '6 days'").

it works nicely. But what I really want to do is get that value of 6 days from the server. So I try something like
>pgo:query("select name from new_table where
current_timestamp - timestamp < $1", ["6 days"]).

it throws an error. I tried '6 days', "'6 days'" and a few other concoctions, all throw errors.
The error message I get (when I pass "2 days" or "'2 days'" as the query parameter) looks like:
{error,{pgsql_error,#{code => <<"08P01">>,file => <<"pqformat.c">>,
                          line => <<"575">>,
                          message => <<"insufficient data left in message">>,
                          routine => <<"pq_copymsgbytes">>,severity => <<"ERROR">>,
                          {unknown,86} => <<"ERROR">>}}}

And when I pass '2 days' as the parameter, it throws a badarg error:
{error,{badarg,'2 days'}}
Most likely, passing '2 days' is confusing to the parser since an Erlang atom is enclosed in single quotes, and a string gets passed as is but doesn't get typecast into type interval by postgres automatically. I am not sure if/how this should be tackled...

One can achieve the desired objective by using a different type of query (as suggested in this SE answer https://dba.stackexchange.com/questions/208580/passing-value-of-datatype-interval-in-parametrized-query)
>pgo:query("select name from new_table
where creation_date > localtimestamp - interval '1 day' * $1", [2])

But that still leaves open the issue of (not) being able to pass an interval as a query parameter.

I'll investigate this today. Likely a format like {interval, Days, Months} or similar will be needed for the argument.
I want to replace the protocol handling with that of https://github.com/epgsql/epgsql so that types like this are supported without duplicating work.

Forgot to reply after looking into it further. It shouldn't be too bad to implement, I'l probably do that before having the time to switch to epgsql decode/encode functionality.

If I may, I would like to suggest that switching out the back end to epgsql should be more meaningful than this formatting issue, because it could, potentially, subsume this problem. The query above that doesn't work is anyways suboptimal (since it leaves no scope to use indexes) and the working alternative is far better - from a database/efficiency perspective. Just my 2¢.
One could of course revisit this issue if it persists even after switching to epgsql. So if you don't disagree, I'm just going to close this issue; and we'll reopen it, if necessary, at a later date. Cheers