Issue/4296 hardcoded strings

Description

Short description here *

closes #4296
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master, iso5 in 28091ef9b750a62c5c135574cefe37557ccf0e59


Game freeze when dying with too much money/items

On the latest develop commit 4a5142c5a35c5efaa18e2dda76dd1c400786a9c9 I was testing the game with 120.000 money, and died on a planet, stuck between a wall and a ground based turret.
The last image I saw was a lot of money coming out of the ship, then the rendering in the game froze. I opened up JVisualVM to check what the game was doing, and it was doing Box2D collision checking.
My theory is that the game spawned too many money/items on death and their collision checking got stuck in an infinite loop. We should:
[ ] Check the number of items emitted on death
[ ] See if collision checking can be skipped/disabled on a large number of collisions

When I re-started the game I had around 80.000 money, so the game really threw out around 40.000 money... Can't remember the stack size for money, but I suppose that would generate a lot of drops.


⚠ Samsung has degraded performance

In f9d3849, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2389 ms

Resolved: Samsung performance has improved in bf44a9e.


Add database icon

Unfortunately, after checking in Grafana I think that the only supported icons for external links are the ones we already have :(
I tried editing the dashboard JSON manually and using database as icon but nothing shows up.

Unfortunately, after checking in Grafana I think that the only supported icons for external links are the ones we already have :(
I tried editing the dashboard JSON manually and using database as icon but nothing shows up.

That's disappointing! Well - then we know


Update investment_policy.md

Suggestions by Andrew Wetmore (andreww), editor for the Infrastructure team.
line 17: removed unneeded "In doing so,"
list starting line 19: added a final period to each item that was missing one, for consistency.
line 38: removed unneeded “In doing so”
line 43: added a comma after “long-term”
list starting line 52: added a final period to each item.
list starting line 69: added a final period to each item.
line 76: if a list starts with ‘such as’ it does not need ‘etc.’ at the end.
line 78: contracts; => contracts and
list starting line 91: added a final period to each item.
line 91: monitor the asset => monitor asset
line 103: removed comma after ‘Board’
line 114: changed passive to active voice to improve readability. If a list starts with ‘such as’ it does not need ‘and others’ at the end.
line 123: removed the comma after ‘fiduciaries’.
list starting line 133: removed punctuation from the end of each item
line 162: removed “established” as unneeded
line 164: contained => reported
line 177: added a comma after “are”
line 192 donor restricted => donor-restricted
line 233: long-term => long term
line 238: individually, => individually;
line 240: impact to => impact on
line 25: serves to assist => assists

Hey Andrew thanks for taking a pass at this.  However in this case the verbiage on this page is the exact verbiage passed in a board resolution.  We can look at updating it to improve clarity and grammar if we ever approach the board with an updated policy.

I would be happy to lend an editor's input at that time.
On Fri, Sep 16, 2022 at 1:36 PM Myrle Krantz @.***>
wrote:

Hey Andrew thanks for taking a pass at this. However in this case the
verbiage on this page is the exact verbiage passed in a board resolution.
We can look at updating it to improve clarity and grammar if we ever
approach the board with an updated policy.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/treasurer-site/pull/6#issuecomment-1249568265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC3RFXN6ISJCWZ37KY2DRZDV6SOZXANCNFSM53IDSTTQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Andrew Wetmore
Editor, Moose House Publications https://moosehousepress.com
Editor-Writer, The Apache Software Foundation https://apache.org


Authentication with header missing Bearer prefix

Moved over from https://github.com/apollostack/react-apollo/issues/320:
I copied the code snippet about authenticating with a header from this page: http://dev.apollodata.com/react/auth.html
But didn't pay close enough attention that it was missing the "Bearer" part, and the result was that authentication was simply ignored.

change the doc to something like this? req.options.headers.authorization = token ? Bearer ${token} : null
throw an error when it has a wrongly formatted auth header, instead of silently ignoring it?

Using Graphcool backend.

I guess 2. is really an issue with Graphcool? Unless you are suggesting that AC could somehow pick this up?

@helfer was it intended to include a Bearer part?

@sedubois thanks, it looks like we should have included the Bearer keyword. I've just fixed it now.


Update Proxy SHA to latest (release-1.0).

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: PiotrSikora
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli
Assign the PR to them by writing /assign @wattli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PiotrSikora: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f31a22f827d03a71ad7f72774c46e93717aa29d1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

You think you can just update the SHA ;)
There's @bianpengyuan 's change that was not pulled in and requires changes to tests.

Sigh, the new proxy is crashing at startup due to a bug in Envoy (I believe it's the same issue as: https://github.com/envoyproxy/envoy/pull/3856), which blocks the update until it's fixed upstream.
cc @jasmine-jaksic @costinm @rshriram

Actually, that might be a different issue.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f31a22f827d03a71ad7f72774c46e93717aa29d1
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
f31a22f827d03a71ad7f72774c46e93717aa29d1
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f31a22f827d03a71ad7f72774c46e93717aa29d1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
49babe74d76ae0226ca2368e43b1e3649b1f211e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f31a22f827d03a71ad7f72774c46e93717aa29d1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
1d271efeb4c9a15a218a11ab2343bf24d97a3bd5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f079e89d94143ca5081deb3bfb2f231aeefc5618
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d9eca6bb232bae8a0c2ff3ebb379bf70dab47d76
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo-envoyv2-v1alpha3

@hklai this needs to go in first before I pull latest proxy SHA...

closing due to memory leaks in proxy


Doesn't render interface api

env:
// to embed Voyager tool
implementation ('com.graphql-java-kickstart:voyager-spring-boot-starter:6.0.1')
api:
type Query {
thing(id: ID): Thing
}
interface Thing{
name: String
}
start my applicaiton and access to http://localhost:8080/voyager, error：
react-dom.min.js:117 TypeError: Cannot read property 'type' of undefined

that is my problem, in the connection  i was wrong with
"""A list of edges."""
edges: [Thing]
should be
"""A list of edges."""
edges: [ThingEdge]


If a single-node contraction has an output_edge_order, its edges should be reordered

Currently if a contractor is passed in a single node, nothing is done.
https://github.com/google/TensorNetwork/blob/a1bcaed7fc1ab9204ca1b48053873562cadc3c9e/tensornetwork/contractors/opt_einsum_paths/path_contractors.py#L74-L76
But if output_edge_order is passed in, I would expect the edges to be reordered accordingly. If this is the desired behavior I'm happy to help with adding the fix!

Hey @verult, thanks for noticing! This is a bug and should be fixed. PR's are very welcome!

Yes def a bug. Also seems like a really nice first PR for a 20%er ;)

Sorry for the scoop. Needed it fixed for something internal


add custom font option

I'm so curious to see what you've added but it's almost impossible using the files tab because you changed the indentation from 2 to 4 spaces. Can you perhaps go back to 2 and push it to your master branch?

sure, sorry for that it's the IDE's fault :D, thanks for the response

will try over later without messing things up this time :)

Yeah your IDE has a will of its own 🤣
Those spaces in < any > below are not ideal, if you can remove superfluous spaces like that then I'll happily review and merge it:

i updated it :)

Super, thank you! 💯
I'll test this and probably add a note about where the dev should put the font.

thanks, also after you test it. there is an open issue asking for this feature i think may be closed :)
https://github.com/EddyVerbruggen/nativescript-feedback/issues/9


Fixed bug with missing "renderer" parameter in widgets.py render methods

In Django 2.1, forms with chained fields get a TypeError "render() got an unexpected keyword argument 'renderer'". Apparently render() now requires a "renderer" parameter.
https://docs.djangoproject.com/en/2.0/ref/forms/widgets/#django.forms.Widget.render

Coverage remained the same at 89.809% when pulling 522d0d4fdbc7e7fec02c2d3b3e7251f40f2b911b on glenngaetz:master into ca55e0bc8ad378dc7a3d1bb5e68e18e8fc51c546 on digi604:master.

@glenngaetz thanks for explaining the problem and pointing to the documentation. This makes sense, merging.


[stable/redis] Fix metrics.extraArgs

Signed-off-by: Alejandro Moreno<EMAIL_ADDRESS>What this PR does / why we need it:
Fixes a bug where metrics.args was being ignored as the arguments where being passed to /bin/bash instead of redis_exporter
Which issue this PR fixes

fixes #18582

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test
/lgtm


BUG: problem building bits/timesize.h not found on Ubuntu 22.04

Describe your issue.
While building SciPy, compilation terminates becauses bits/timesize.h is not found.
Reproducing Code Example
python dev.py build

Error message
[801/1588] Compiling C++ object scipy/stats/_stats_pythran.cp...x86_64-linux-gnu.so.p/meson-generated_..__stats_pythran.cpp.o
FAILED: scipy/stats/_stats_pythran.cpython-310-x86_64-linux-gnu.so.p/meson-generated_..__stats_pythran.cpp.o
/home/gert/.conda/envs/scipy-dev/bin/x86_64-conda-linux-gnu-c++ -Iscipy/stats/_stats_pythran.cpython-310-x86_64-linux-gnu.so.p -Iscipy/stats -I../scipy/stats -I../../../.conda/envs/scipy-dev/lib/python3.10/site-packages/pythran -I../../../.conda/envs/scipy-dev/lib/python3.10/site-packages/numpy/core/include -I/usr/include -I/home/gert/.conda/envs/scipy-dev/include/python3.10 -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++14 -O2 -g -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/gert/.conda/envs/scipy-dev/include -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem /home/gert/.conda/envs/scipy-dev/include -fPIC -DENABLE_PYTHON_MODULE -D__PYTHRAN__=3 -DPYTHRAN_BLAS_NONE -Wno-cpp -Wno-deprecated-declarations -Wno-unused-but-set-variable -Wno-unused-function -Wno-unused-variable -Wno-int-in-bool-context -MD -MQ scipy/stats/_stats_pythran.cpython-310-x86_64-linux-gnu.so.p/meson-generated_..__stats_pythran.cpp.o -MF scipy/stats/_stats_pythran.cpython-310-x86_64-linux-gnu.so.p/meson-generated_..__stats_pythran.cpp.o.d -o scipy/stats/_stats_pythran.cpython-310-x86_64-linux-gnu.so.p/meson-generated_..__stats_pythran.cpp.o -c scipy/stats/_stats_pythran.cpp
In file included from /usr/include/features.h:392,
                 from /home/gert/.conda/envs/scipy-dev/x86_64-conda-linux-gnu/include/c++/12.3.0/x86_64-conda-linux-gnu/bits/os_defines.h:39,
                 from /home/gert/.conda/envs/scipy-dev/x86_64-conda-linux-gnu/include/c++/12.3.0/x86_64-conda-linux-gnu/bits/c++config.h:655,
                 from /home/gert/.conda/envs/scipy-dev/x86_64-conda-linux-gnu/include/c++/12.3.0/type_traits:38,
                 from ../../../.conda/envs/scipy-dev/lib/python3.10/site-packages/pythran/pythonic/include/types/assignable.hpp:4,
                 from ../../../.conda/envs/scipy-dev/lib/python3.10/site-packages/pythran/pythonic/types/assignable.hpp:4,
                 from ../../../.conda/envs/scipy-dev/lib/python3.10/site-packages/pythran/pythonic/core.hpp:41,
                 from scipy/stats/_stats_pythran.cpp:1:
/usr/include/features-time64.h:21:10: fatal error: bits/timesize.h: No such file or directory
   21 | #include <bits/timesize.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

SciPy/NumPy/Python version and system information
sys.version_info(major=3, minor=10, micro=12, releaselevel='final', serial=0)

SciPy version information not available because it cannot be built.

Thanks, @andyfaff, for looking into this. Yes, build-essential is installed and is the most recent version. In fact, timesize.h is present in my installation as well but it is not found. In my case, it is located at /usr/include/x86_64-linux-gnu/bits.

By commenting out compilers, I can get rid of gfortran. The C(++) compilers, however, seem to be a dependency of pythran.

Yes, you'll need compilers. But when you apt install build-essential gfortran you'll have all the compilers you need supplied by the system.

Sorry, that I was unclear. I meant that I got rid of gfortran in the conda environment. gfortran was installed and taken from the system installation during the build. The problem is related to the C compilers which, as far as I understand, are installed into the conda environment as a dependency of pythran.

Did you install pythran via conda? I suggest following the instructions at https://docs.scipy.org/doc/scipy/building/index.html

This was indeed the problem. A pip install of pythran does the job. Thanks again for your help.

After returning from the EuroSciPy sprint, I tried to reproduce the problem on my machine at home which is also running under Ubuntu 22.04. There, proceeding as described in the documentation worked just fine. But as far as I can tell, I did nothing different from what I did during the sprint where I also followed the documentation. So, for the moment, I am unable to reproduce the problem in a simple way. On the other hand, I now have two different machines where one shows the problem and the other does not. I can invest a bit of time trying to identify relevant differences in the two installations.
Just as an information for other people running into the same problem: In order to avoid the problem with bits/timesize.h I created a conda environment based on environment.yml with the following modifications:

I commented out the lines for python, compilers, and pythran
pythran was then pip installed, i.e. I added the three lines- pip
- pip:
   - pythran

Thanks for the context!
It's possible that it was some temporary hiccup that is already fixed, or something very machine-specific.

Just as an information for other people running into the same problem

If anyone else has this problem, I'd like to hear so we can get it properly fixed.

Hello, I am having this issue on Debian. I followed the conda-env approach from the build instructions page:
mamba env create -f environment.yml
mamba activate scipy-dev
python dev.py build

Then, I deleted the conda environment, modified environment.yml as instructed by @gertingold and ran the same steps again, and managed to build scipy successfully.


Dashboard has changed

The Dashboard for reaching the Private Endpoints has changed. Please update this resource.
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6c7151f8-cebf-0019-b028-b414faa1ac24
Version Independent ID: 01d4f188-aefa-5f5a-d0dc-1f4ab54ab2a4
Content: Azure Private Link - Azure SQL Database and Azure Synapse Analytics
Content Source: azure-sql/database/private-endpoint-overview.md
Service: sql-database
Sub-service: security
GitHub Login: @rohitnayakmsft
Microsoft Alias: rohitna

@KrisBethea Thank you for your feedback. We will review this and make an update if appropriate.

Thanks, @KrisBethea for bringing this to our attention. I've updated the image and steps involved.

#assign:VanMSFT


Linking to bug tickets

It might be useful if it is possible to link to Jira tickets on any tests that we mark as 'Ignored' I fear that if we mark things as ignored due to known issues we will forget to un-ignore them once the related Jira ticket is closed.

This was the key usefulness of differentiating between ignoring part the a web page that is not relevant to a development team, and temporarily ignoring a known fail until a fix can be implemented.  I still think it may be useful to either distinguish between these, or include some detail about ignored issues in the output (eg. Tests run: xxx  Passed: xx  Failed: 0  Ignored: xx)

Nice idea, thanks @staylos92. We'll factor this into our ignoring configuration.

I'm actually thinking that we should always ask for a reason for skipping standards, because it's so important to note why you're skipping them...
So maybe we could stop supporting this format:
page "http://some/page.html" do
  skip_standard "some standard"
end

...and only support this instead:
page "http://some/page.html" do
  skip_standard "some standard", reason: "the reason why we are skipping"
end

or something like that anyway

Would that be tracked in some way?

Sounds good @joshski When we have the browser interface, it would be good to see what/why things were being skipped, though only if you could save the output/skips for others to see. Though if people are just running these tests locally with a one time run - then I'm not sure the reason is needed (would just take longer to add the skips), unless it's stored somewhere or tracked like @EmmaJP says? Maybe useful on a nightly build?

I don't really know what you mean by tracking. So let's say you had a Jira ticket ABC123, then you could mention it in the reason:
page "http://some/page.html" do
  skip_standard "Headings: exactly one main heading", reason: "JIRA ABC123"
end

...then running the tool you might see this kind of thing in the console output:
  * Skipped Headings: exactly one main heading, reason: JIRA ABC123

Now, when the ticket is closed then you'd probably want to stop skipping. Is that what you mean by tracking?
In this case you could easily write a script that found "JIRA xxxx" in the output and checked whether those JIRA tickets were closed. Or easier, if we had a formatter API then you could use that to integrate with JIRA.

Is any of this included in the current ability to skip tests or ignore results? And if so, is that in the documentation?

Now the config is in JS, it's really easy to add a comment. e.g.:
page('http://www.bbc.co.uk', {
  skip: [
    'Headings: Content must follow headings', // Awaiting JIRA-1234
    'Minimum Text Size: Text cannot be too small'  // Awaiting JIRA-1235
  ]
})
page('http://www.bbc.co.uk/news', {
  skip: 'Headings: Content must follow headings' // Awaiting JIRA-1236
})

Given this, can we close this issue?

Yeah, I think so 👍


Fixed docs typo in testing smart contracts

Thanks a lot! That's a good catch, I'm going to fix that in another PR, since PreparedContract is no longer a thing, we probably forgot to change it in the docs. Thanks once again, that would be really confusing for users


Constant value not leveraged in simplication if it comes from path constraint

In the following code, the value of export_dir_rva is known to be constant 0x0, but it is not optimized away in HLIL:

I do not know the exact cause of us not removing export_dir_rva, I guess it is because the constantness of the value is coming from a path constraint, but I could be wrong
P.S.: the original binary is obfuscated and the user had to patch the code to simplify it. While doing so, he accidentally inverted the condition, making the value of export_dir_rva to become 0x0 in the true branch (it should be the opposite, i.e., not 0x0 in the true branch). That said, in case of the wrong patching, we should optimize away export_dir_rva since it is known to be 0x0
See binary and more info at https://github.com/Vector35/binaryninja-api/discussions/5629, database is attached:
10wgyf.bndb.zip

This is likely due to the difference in the two different dataflow systems.


Error when Launching Mapview Widget

Hi,
I've started using mapview and had no issues during installation and example code works fine. However, whenever I try to launch the example code outside of the example directory (i.e. copying it verbatum to my own file in another directory) everything breaks. None of the imports register and upon launch of an unedited map with marker example, I get:
 Traceback (most recent call last):    File "D:/Projects/Halo Controller/tests/mapview_test.py", line 33, in <module>      """)    File "C:\Python27\lib\site-packages\kivy\lang\builder.py", line 350, in load_string      parser = Parser(content=string, filename=fn)    File "C:\Python27\lib\site-packages\kivy\lang\parser.py", line 392, in __init__      self.parse(content)    File "C:\Python27\lib\site-packages\kivy\lang\parser.py", line 498, in parse      self.execute_directives()    File "C:\Python27\lib\site-packages\kivy\lang\parser.py", line 464, in execute_directives      mod = __import__('.'.join(package.split('.')[:-1]))  ValueError: Empty module name
Does anyone know what's going on and/or how to fix it?

Are you installing it in your project with garden? If so, use from kivy.garden.mapview import MapLayer.


[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 35)

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG
DocuTune v<IP_ADDRESS>
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db
#docutune

#docutune-review

LGTM


Android -Distance - Distance tab is gray and not highlighted in green when swiping to Distance

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Launch ND or hybrid app.
Open FAB > Submit expense
Go to Manual
Swipe to Scan, then swipe to Distance

Expected Result:
Distance tab will be highlighted in green when swiping to Distance tab (production behavior)
Actual Result:
Distance tab is gray and not highlighted in green when swiping to Distance tab
The tab is only green when it is tapped on
This issue also happens in Scan tab when it is swiped from Distance to Scan
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/9d158542-d61b-4a29-af0b-2b8795ade7d6
View all open jobs on GitHub

Demoting this as it's pretty minor.

Removed Help Wanted for a min... @rayane-djouah , what do you think of the proposals above?

I'm back from OOO on Nov 14th, not assigning another BZ because the PR is on staging so payment will likely be the day or two after I'm back. If one is needed please add or post in #contributor-plus to ask for one to be added, thx.

Contributor: @twilight2294 owed $250 via Upwork
Contributor+: @rayane-djouah paid $250 via Upwork
Test case created, thx @rayane-djouah

https://github.com/Expensify/Expensify/issues/445521

@twilight2294 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021848826866073504646

Thanks @twilight2294 , you've been paid, payment post above has been updated.


Fixed issue where CLI helper keeps getting a 503 from the server when…

Fixed 503 error when using CLI helper in our production environment.

We need information about the environment, what caused the problem and why this is a fix.  I've never  encountered a 503 due to URL construction.

@jhoblit I have now reverted this in our environment and we are no longer getting the issue.
Please feel free to reject this pull request as I don't think it is needed.

Roger that.


Calling resize buffers on AMD graphics throws in the Memory Management project

After some testing with fullscreen transitions, I realized that my code worked on Intel Graphics, but the resize buffers would throw on AMD Graphics. Did some more testing, and even the Memory Management sample with no changes, throws when calling resize buffers on AMD Graphics.

You should check that it's not an exception being thrown and handled inside the runtime/driver. The debugger can be breaking internally on an exception throw which is then handled before the application gets back an HRESULT.

I am not seeing any issues with the Memory Management sample on the Windows 10 Anniversary Update with an RX 480 on the latest driver from AMD.  Can you upload a dxdiag to provide more details about your PC?  Is this a laptop?

I should have been more specific. It's a laptop with hybrid graphics Intel(R) HD Graphics 5500 as the secondary card and AMD Radeon R7 M260 as the primary. The OS is Windows 10. If I choose Intel as the adapter in the sample prompt, it runs with no problems. Choosing AMD makes it throw when calling resize buffers. The exception is not being handled, it breaks even while running without debugging. I will provide a dxdiag as soon as I can.

DxDiag.txt
Adding the DXDiag. Also, just realized I was using my "game account" when I opened the issue. Guess I'm sticking to it now.

Does this issue still happen on modern versions of Windows / drivers?


Hardcoded creation date-time replaced by attribute "docprodtime"

N.B. Requires updates to the github workflow as suggested below.
See issue #457 for discussion of the changes.
Release checklist

[ NA] Authors updated in cf-conventions.adoc?
[ NA] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
[yes] history.adoc up to date?
[ NA] Conformance document up-to-date?

For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.
Replacing the hardcoded document creation date with an AsciiDoc attribute (with more flexible formatting than the builtin {localdatetime}) requires the format specification attribute to be set at the command line. The code changes below have not been tested in a github workflow, but the corresponding shell commands works when run locally.
...
...
 - name: Set draft date-time formatting       ## new
      if github.event_name != 'release'       ## new
      run: |       ## new
        echo "DATE_FMT='+%d %B, %Y %H:%M:%SZ'" >> "$GITHUB_ENV"       ## new
 - name: Set "final" tag and date-time formatting       ## changed
      if: github.event_name == 'release'
      run: |
        echo "FINAL_TAG=-a final" >> "$GITHUB_ENV"; echo "DATE_FMT='+%d %B, %Y'" >> "$GITHUB_ENV"       ## changed
    # Build cf-conventions.html using the Analog-inc asciidoctor-action
    - name: Build cf-conventions.html
      uses<EMAIL_ADDRESS>      with:
        shellcommand: 'asciidoctor --verbose ${FINAL_TAG} -a docprodtime="$(date -u ${DATE_FMT})" cf-conventions.adoc -D conventions_build; cp -r images conventions_build'      ## changed
    # Build cf-conventions.pdf using the Analog-inc asciidoctor-action
    - name: Build cf-conventions.pdf
      uses<EMAIL_ADDRESS>      with:
        shellcommand: 'asciidoctor-pdf --verbose ${FINAL_TAG} -a docprodtime="$(date -u ${DATE_FMT})" -d book cf-conventions.adoc -D conventions_build'       ## changed
    # Upload artifact containing cf-conventions.html, cf-conventions.pdf

Could possibly someone from the Information Management and Support Team have a look at this?
ping e.g. @DocOtak, @sadielbartholomew, @cofinoa, @davidhassell

I am closing this PR, but will shortly open a new one that includes the suggested changes to the workflow.


The new firmware does not support 1106oled! I can't use it, hope to support 1106

Please don't open new issues. There's already #16 on the same topic.
This is not a support repository, and in the other issue it has been already told you to not use any "new firmware"


Update README.md

Added link to Maven repo to simplify search for latest version number.

Even if we wanted to link, search.maven.org is the correct place. mvnrepository is a third-party index that's frequently out-of-date and shouldn't be used.

Even if we wanted to link, search.maven.org is the correct place. mvnrepository is a third-party index that's frequently out-of-date and shouldn't be used.

Oops, sorry for that, my mistake.
Should "same version as OkHttp dependency" recommendation go to readme.md then? How people, for example, that, are using retrofit should check OkHttp version?

Even if we wanted to link, search.maven.org is the correct place. mvnrepository is a third-party index that's frequently out-of-date and shouldn't be used.

Oops, sorry for that, my mistake.
Should "same version as OkHttp dependency" recommendation go to readme.md then? How people, for example, that, are using retrofit should check OkHttp version?

If you’re using the logging interceptor, you should explicitly specify it’s version and the OkHttp version.

Okay. What should i do next then with this PR?

Change the doc to recommend using the same version as your OkHttp artifact? Mind changing our other optional modules also?

Fixed our tools so the latest version is easy.
https://github.com/square/okhttp/pull/5129


As the printSize changes, automatically fit page view to screen

Is it possible to automatically fit the page to the screen when changing printSize?
Using the template provided, when the printSize is change to NA_TABLOID for example, the view of the page is zoomed in. If you set the printSize in the XML layout as NA_TABLOID, then change the printSize to ISO_A5, the view of the page is zoomed out.
<com.otaliastudios.printer.DocumentView
android:layout_width="match_parent"
android:layout_height="match_parent"
app:pageElevation="0.01in"
app:pageInsetTop="20pt"
app:pageInsetBottom="20pt"
app:pageInsetLeft="30pt"
app:pageInsetRight="30pt"
app:pageDividerWidth="0.1in"
app:columnsPerPage="1"
app:pageBackground="@color/white"
app:pagerType="horizontal"
app:printSize="ISO_A5">
<!-- Content here. -->

</com.otaliastudios.printer.DocumentView>

Figured it out...
just call the zoom engine and set zoomTo(1, true)


[Discussion] I tried this mp3，and always be failed

flower road.zip
pls unzip it and get a mp3. I do not know why this song can not be done. Pls help me.

my memory is only 8G，is it too small for the 6.8M song?

Hello
I used the online version of Spleeter (splitter.ai) to process it. The processed vocals.wav is mindblowing, it beautifully separated male/female vocals, speech part and the complete choir section. So what do you mean when you say it fails?
My installation of Spleeter on my machine fails (crashes) if my song is too long, so I split files into smaller chunks to process them.

Hello
I used the online version of Spleeter (splitter.ai) to process it. The processed vocals.wav is ..........

Thank you！The spleeter software is aowsome. The problem is the momery of my computer is only 8G, and it's too small. When I changed to 32G, then it works well.


Lazyload closest images using array

Hello there!
I am using react-slick for our image sliders on the search page. Since there are 20 sliders and we use lazyload: true, it gave a white flash when you click next/prev ( a right to left transition to an empty rectangle before the next image loads)
So I just created this PR to add option to enable lazy load with preloading the closest slides images (for previous and next slide images). Since the lazyload prop already takes string progressive, I overload it by passing an array with two integers, first one is number of items you would like to preload before current image, and second one is after the current image. Ideally it could take an object to config.
Could you please review and let me know your thought?
Thanks!

@akiran can you please review this change? Seems like a very small change and shouldn't take too long to review it, and the benefit is huge in terms of performance.

@akiran any updates on this?

This is great, can this be merged?

anyone can review it ? ;)

@akiran Can this one be merged please?

Anything on this yet?

@wendywy0660 We want to maintain API compatibility with slick-carousel library
https://kenwheeler.github.io/slick/
We don't add new props which are not support by it

Looks like our lazyLoad functionality is different from the slick-carousel.
lazyLoad option in it accept 'ondemand' and 'progressive'
If lazyLoad functionality in slick-carousel works for you, please a send PR which mimic the same behaviour

Looks like our lazyLoad functionality is different from the slick-carousel.
lazyLoad option in it accept 'ondemand' and 'progressive'

It also supports the anticipated value, that loads the next slide only (it's not in the documentation, but it exists)

hey @pesimeao i tried putting the anticipated value but it doesnt seem to work..

@hayzohargettacar this should work.
check https://github.com/kenwheeler/slick/issues/3393 or http://jsfiddle.net/dyfpt14j/
and react-slick is using the latest slick.
I'm using ant design carousel which uses react-slick, it doesn't work their so i want to be sure it's not a antd issue


multilingual.js not found

Laravel Version: 5.5.*
Voyager Version: 1.0.*
PHP Version: 7.1.*
Database Driver & Version:

Description:
When I use multi languaue feature of voyager packages, I get this error: GET http://voyager.dev/vendor/tcg/voyager/assets/js/multilingual.js net::ERR_ABORTED
I have published vendor: php artisan vendor:publish --tag='voyager_assets' --force but it still not working.

Hey @hquangthien.
Have you tried to run just php artisan vendor:publish and select voyager assets?
If it doesn't work, copy tcg/voyager/publishable/assets/js/app.js and place it at public/vendor/tcg/voyager/assets/js/app.js.

Closed due to missing respond from author.


Allow changing paths of qt installation

Currently an installation cannot be moved.
Possible solution:
Keep a .aqtinstall directory and a file patched_files that lists all files that have been patched. This work would be done at installation.
Now a command line switch --update_prefix and --base_path would cause aqtinatall to read .aqtinstall/patches_files from base_path and update prefix to argument of update_prefix for all such files in the list.
Arguably not a frequent use case but just wanted to throw it around

FYI: "Qt  is relocatable"
https://www.qt.io/blog/qt-is-relocatable

As of version 5.14.0 Qt is relocatable, i.e. it is possible to move the Qt installation to a different directory without breaking functionality or loading of plugins.

Thank you. So i wrote this comment after i relocated "knowing" that like earlier things won't work. But they did and i didn't bother to investigate :-)


fix(reg-exp-router): Register path for all the methods if method === METHOD_NAME_ALL.

fixes #574
@yusukebe I think this PR will fix #574!

Thank you! I'll check it and merge it later!

Hi @usualoma !
Thank you! Looks good! I'll merge it.


Document Intelligence 2024-11-30 GA

Data Plane API Specification Update Pull Request
Document Intelligence 2024-11-30 GA.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[X] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document: See internal PR
Previous API Spec Doc: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/ai/data-plane/DocumentIntelligence/preview/2024-07-31-preview
Updated paths:

Added new batch list/delete operations

GET /documentModels/{modelId}/analyzeBatchResults
DELETE /documentModels/{modelId}/analyzeBatchResults/{resultId}

DELETE /documentModels/{modelId}/analyzeResults/{resultId}

Tagging @allenjzhang and @mario-guerra to review the TypeSpec for best practices.


Add a sample for multiple state stores

Describe the proposal
It'd be nice to have a sample showcasing the multiple state store handling capability of dapr.

It would also be good to define what multi-state store handling is, and why it's important as a feature in Dapr... at least that is what I'm wondering.  I'm assuming this is for Actors, and why would an Actor instance what to use it?

@pruthvidhodda multiple state store is just an artifact of how state management is done with Dapr, it doesnt need a new sample.
@codeputer  Actors dont use multiple state stores.
I am closing this usse, please feel free to reopen if you have more questions


testing mode for writing mails to a file instead of sending them

I added an option for mailgun to output mails to a local file instead of actually sending them. I use that for integration testing a single page app, where the tests are run by another process.

Looks great! I have just one small comment

I pushed the changes. Thanks for reviewing so quickly.

Let's make the mode :test instead of :testing and think this is ready to go

do you want the testing_file_path to become test_file_path then, too?

yes please

On Mar 6, 2015, at 11:21 AM, manukall<EMAIL_ADDRESS>wrote:
do you want the testing_file_path to become test_file_path then, too?
—
Reply to this email directly or view it on GitHub https://github.com/chrismccord/mailgun/pull/4#issuecomment-77586803.

ok, changed those.

<3 <3 <3


[jinja_context] Fix, allow for app factory pattern

CATEGORY
Choose one

[X] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Following the ongoing process for converting superset to the app factory pattern.
Docs were unable to build properly since sphinx autofunction imports a method on a module that needs a Flask app context.
Also adding a Travis step to check if docs build correctly
TEST PLAN

Test sqllab jinja templates
Test build docs

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@craig-rueda

Codecov Report

Merging #8693 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8693      +/-   ##
==========================================
- Coverage   65.55%   65.54%   -0.01%
==========================================
  Files         481      481
  Lines       24079    24077       -2
  Branches     2763     2763
==========================================
- Hits        15784    15782       -2
  Misses       8115     8115
  Partials      180      180

Impacted Files
Coverage Δ

superset/jinja_context.py
76.23% <100%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3690fb4...a9506f0. Read the comment docs.

@craig-rueda : Improved the app factory integration


Typo

https://github.com/boilermaker-ben/Google-Sheets-NFL-Pick-Ems-and-Survivor-Pool/blob/4ee6d1df936c0fedf7d47713af5a7b8316ae8173/script.js#L4650C3-L4650C3
Selectiong to Selection

Nice catch. Fixed. Thanks!

Closed


java.lang.IllegalStateException: trailers not available

Hey, I am using the Connect library in my app which works pretty good so far. We have to stick to v0.5.0 for now as some other dependency need protobuf 3.25 which makes it incompatible with 0.6.0 for now.
However, I get some errors from users via Sentry like this:
java.lang.IllegalStateException: trailers not available
    at okhttp3.Response.trailers(Response.kt:180)
    at com.connectrpc.okhttp.ConnectOkHttpClient$unary$1.onResponse(ConnectOkHttpClient.kt:160)
    at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
    at java.lang.Thread.run(Thread.java:1012)

This seems to be the case whenever the network connection is lost / flaky.
I am executing the call to the network function inside a normal try catch block. The stacktrace also suggests that I cannot wrap it in a way that catches the crash as it directly originates from the OkHttp threadpool rather than my code.
Can you have a look at it please? And maybe you have an idea for a quick workaround as this occurs quite regularly.

After looking at the current implementation and copying it to my project it seems like this is fixed in https://github.com/connectrpc/connect-kotlin/commit/16a8b1dc8ba18a2d1fcafa42e87ffe2c6a0bee7f already.

Hi @ln-12 - we've published v0.5.1 (for protobuf-java 3.x) and v0.6.1 (for protobuf-java 4.x) with this fix.

Awesome! Thank you very much 👍


link to "Try asking the Power BI Community"

Under "Next steps", the link to "Try asking the Power BI Community" should direct to https://community.powerbi.com/t5/Desktop/ArcGIS-Maps-for-Power-BI-Preview-Discussion/td-p/72947

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: acf2c48a-66f7-6c38-286e-ae429fc34883
Version Independent ID: 033ec0fc-5c72-8cf2-20fb-1c7a36ebcd5f
Content: Interacting with an ArcGIS map that has been shared with you - Power BI
Content Source: powerbi-docs/visuals/power-bi-visualizations-arcgis.md
Service: powerbi
Sub-service: pbi-visuals
GitHub Login: @mihart
Microsoft Alias: mihart

Thanks for your comment, @rootsmusic . This issue has been assigned to the doc author for review.

Hi again @rootsmusic :-)
Thank you for pointing that out.  I've updated the article and set it to republish tomorrow.


Fix for Full Path Used for Source URL on Single Source Projects

For projects that are from one source file (and do not set sourceRootPath in their conf.json), when displaying the source the full file path is used instead of just the file name.
For example:
Source: /Users/user/work/single-source-file.js

instead of the desired
Source: single-source-file.js

When building the array of sourcePathFiles in publish.js, the path is not checked to see if it already exists before adding it.  When sourcePathFiles is then passed to jsdoc3's path.js to determine the commonPrefix, an array that contains multiple references to the same path is used and the results then fail to shorten the path to create the desired source URL.  The single length route of path.js provides the desired results for the commonPrefix so this fix simply does not add the path to the array if it is already there.

It seems this must be because of a bug in https://github.com/jsdoc3/jsdoc/blob/master/lib/jsdoc/path.js#L54 ? reading the documentation, it should work with an array of 4 identical paths just the same?

I forked jsdoc and have a unit test that replicates what I was seeing and it fails.  The jsdoc documentation on commonPrefix does not say it needs to be a set that is passed in so I will take that up with them.
Another possible fix, which may be more elegant, would be to refactor sourceFilePaths out completely and instead use Object.keys(sourceFiles)  in it's place.  sourcesFiles is a dictionary which means the keys will be a set (also hold the same value as sourceFilePaths) and not cause the issue I am seeing.

Im fine with this change though. Just thought it should be fixed in jsdoc too.


Use Fedora 28 base and update spec file

Summary of changes:
Updates base Fedora image from fc27 to fc28 (ie: Dockerfile, bazel repository, fedpkg command) as well as clean up the RPM spec file to make it a bit more modular and linear.
How to test (optional):
e.g. Run make build-rpm

This change is

Thanks @tonylambiris !

test-me-please


HV-1396 Move non-public classes of annotation processor to org.hibern…

…ate.validator.ap.internal

https://hibernate.atlassian.net/browse/HV-1396

Rebased and applied. Thanks, @gsmet! I've added a note to the migration guide, altough I don't expect any outside usage of these classes anyways. Specifically, the AP isn't part of WF.


Enable Download of APIView Artifact from GitHub

Enables APIView Artifact Download from GitHub using GitHub access token

Closing this since we are sticking with DevOps


144 v7 framework

Params for v7 (final) framework updated
Model performances for final models added (except for _labels files which have text of comments and are therefore sensitive)

Closes #144


Allow delete self access

Describe the task
Remove the router guard checks when user tries to delete the access for themselves, to allow them delete self access
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

duplicate as #1240


Support CQL JSON

As a requirement of the OGC API - Records specification, we need to add support for CQL JSON.
This item was left out of the initial implementation in #670

I guess with the merge of #717 we can close this?


Incorrect TS2304 when using "export = class A {...}"

I am writing an external module (using AMD) that needs to export only a single class. I want to simply import it as import MyClass = require('./MyClass'), therefore in MyClass module I use "export =" syntax:
export = class MyClass {
    // ...
}

This compiles without errors and produces reasonable JS code:
define(["require", "exports"], function (require, exports) {
    return (function () {
        function MyClass() { /* ... */ }
        return MyClass;
    })();
});

Next, I try to import it:
import MyClass = require('./MyClass');
var my: MyClass = new MyClass();

Compiling this gives me error at var my: MyClass: "TS2304: Cannot find name 'MyClass'".
But, when I change my module export to:
class MyClass {
    // ...
}
export = MyClass;

everything works okay, however produced JS code seems to be almost the same:
define(["require", "exports"], function (require, exports) {
    var MyClass = (function () {
        function MyClass() { /* ... */ }
        return MyClass;
    })();
    return MyClass;
});

As far as I can see, the only difference is, it uses temporary variable before return, which has no effect outside of this closure.
I believe both cases should work the same.

this is by design. Declaration of class MyClass has meanings of both type and value. As for class expression if it has name then this name is added to type\value declaration spaces inside the class expression. Outside you can bind class expression to either variable or parameter but this binding will only have value meaning. As a consequence:
var x = class A {
    f() {
        let a: A; // legal - A has type meaning
        a = new A(); // legal = A has value meaning
    }
}
let y1: A; // illegal - A is not visible here
let y2: x; // illegal - variable declaration adds name `x` only to value declaration space
let y3 = new x(); // legal - x has value meaning


Credential operations (only for prism): Issue, Revoke and Verify

https://github.com/roots-id/rootswallet/wiki/Roots-Wallet-Implementation-Proposal#layer-1-utilities-and-ledger-interface

duplicate of https://github.com/roots-id/rootswallet/issues/54


Minor casing error in OTel doc

Describe the issue or suggestion
See https://github.com/dotnet/docs-aspire/pull/828

PR still relevant, but closing this issue since it doesn't add any more info


Editors doesn't have permission to add activityTypes in destination

Give editor role permission to add activityTypes in destination.

eda it must be given to the role from the console. I will fix that.

closing this since we can syrup offline


26666 import controller

Issue:  https://github.com/stolostron/backlog/issues/26666

/lgtm

/unhold

/override ci/prow/sonar-pre-submit


Make sure that spaces are everywhere but not tabs

Verified both ms-rest/ms-rest-azure and generated files. All have spaces, not tabs and indent of two spaces.


Error with info Method for Certain Packages

Issue Description
Encountered an issue with the info method in the Chocolatey class, specifically when retrieving information for certain packages, like dotnet-7.0-desktopruntime.
Steps to Reproduce
Call the info method with pkg_id set to dotnet-7.0-desktopruntime.
Observe that an error is thrown.

Expected Behavior
The method should return package information without any errors.
Actual Behavior
The method fails and returns an error for specific package IDs.
Modified Method
I've made some modifications to the info method to handle this issue:
def info(self, *, pkg_id: str, local_only=False, **kwargs) -> Optional[PackageInfo]:
    """Retrieves package information."""
    self._omit_args(kwargs, "limit_output", "verbose")
    try:
        output = self.cmd.info(pkg_id, limit_output=True, local_only=local_only, **self._capture_output, **kwargs)
    except run.CalledProcessError as exc:
        self._handle_exception(exc)
        return None  # Return None if an error occurred

    if not output.stdout.strip():
        return None  # Return None if the output is empty

    # Processing the command output
    packages = self._packages(output.stdout, klass=PackageInfo)
    if not packages:
        return None  # Return None if no packages are found

    pkg_info = list(packages.values())[0]
    return pkg_info  # Return information about the first found package

Additional Information
This modification seems more like a workaround, but it resolved the issue I was facing.

Fixed in https://github.com/karpierz/chocolatey/releases/tag/0.3.1


core: fix destruction of serial connection

When nothing weas being received over serial the destruction of the serial connection hung waiting for a read to complete.
By using a timeout every second, we can recover after one second. It's not optimal but better than stalling completely.

I have to trust you on that :blush:

I thought closing it was enough but presumably I was wrong.
The right approach might be to switch to some async serial read/write implementation at some point.

I'm gonna ignore the CI failures which are unrelated.


ci(python): install pipenv with apt instead of pip

So that the pipenv installation itself is pinned / reproducible.
Bug: #1182

This will not work due to some python mismatch config in Ubuntu: https://stackoverflow.com/a/74475168/1745064 :(


⚠ SceneTime has degraded performance

In 9b4717b, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 4744 ms

Resolved: SceneTime performance has improved in f976a1c after 6 minutes.


Copy IDE links with mouse right click

Hi,
I'm suggesting an way to copy interface links, like changelog links or link of pages rendered inside de editor.
The motivation is way to open the link with another browser or just to share or other copy and paste uses.
I'm not found this suggestion, sorry if duplicate.
Thanks!

I think this asks about being able to "Copy" a link in a webview, e.g. from a context menu.

@wellington1993 maybe show a screenshot of what link you mean

Many of these are not normal <a href="..."> links, they trigger editor actions that perform an operation. Copying the href like a browser would make no sense as implemented
For links in the terminal and editor, you can already copy the text of the link itself. Adding @Tyriar and @bpasero to see if we want to do anything else here
The welcome page and tweet ones probably shouldn't be copyable as they are internal.
For webviews, we could make the links copyable but will have to do a lot of work to make sure we copy the real href and not the pseudo href we actually use the open the link.

For the terminal I'd need to expose extra API in xterm.js, I'd only want to do that if we make a decision to do this across the workbench. I'm 👎 to this in general right now as there are workarounds and this seems like a lot of work for little pay off when we have plenty of other stuff to do.

I don't think this is worth the effort. For webviews maybe we can revisit this in the future if more people are interested in it. It only really makes sense though for document style webviews, such as the markdown preview


DepCard: Use wider strokes for border nodes

The open issues without blockers are actionable.  Draw extra attention to them to make it easier to identify productive targets.

wonder if this is what should be yellow?


AC-487-get-triggered-workflows-by-payload-api-endpoint

Description
Ability to list Workflow Instance's for a given PayloadId
Also Fixes https://github.com/Project-MONAI/monai-deploy-workflow-manager/issues/411
Status
Ready
Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[x] New tests added to cover the changes.
[x] All tests passed locally.
[ ] Documentation comments included/updated.

Additional
Example requests:
http://localhost:5000/workflowinstances?payloadId=b732a1bc-aab6-45ce-a690-0ea6b9f86e17
http://localhost:5000/workflowinstances?status=created&payloadId=b732a1bc-aab6-45ce-a690-0ea6b9f86e17
http://localhost:5000/workflowinstances?status=created&payloadId=b732a1bc-aab6-45ce-a690-0ea6b9f86e17&pageSize=1000001
Example Response:
{
    "pageNumber": 1,
    "pageSize": 2,
    "firstPage": "/workflowinstances?pageNumber=1&pageSize=2",
    "lastPage": "/workflowinstances?pageNumber=8&pageSize=2",
    "totalPages": 8,
    "totalRecords": 15,
    "nextPage": "/workflowinstances?pageNumber=2&pageSize=2",
    "previousPage": null,
    "data": [
        {
            "id": "0221291c-a994-4a7b-8ec6-42fbaa25185e",
            "ae_title": "Multi_Task_1",
            "workflow_id": "d662639b-30aa-4271-8fcf-b51e6745e72b",
            "payload_id": "b732a1bc-aab6-45ce-a690-0ea6b9f86e17",
            "start_time": "2022-09-06T09:36:03.995Z",
            "status": "Created",
            "bucket_id": "monai",
            "input_metadata": {
                "": ""
            },
            "tasks": [
                {
                    "execution_id": "da69dfb4-10bb-455d-bb6b-32d3eb5e993d",
                    "workflow_instance_id": "",
                    "task_type": "Multi_task",
                    "task_start_time": "0001-01-01T00:00:00Z",
                    "execution_stats": {},
                    "task_plugin_arguments": {},
                    "task_id": "b971c259-c3d5-4ddf-93b2-56c83fb7b474",
                    "previous_task_id": "",
                    "status": "Dispatched",
                    "reason": "None",
                    "input_artifacts": {},
                    "output_artifacts": {},
                    "output_directory": "payloadId/workflows/workflowInstanceId/executionId/",
                    "result": {},
                    "input_parameters": {},
                    "next_timeout": "0001-01-01T00:00:00Z",
                    "timeout_interval": 0
                }
            ]
        }
    ],
    "succeeded": true,
    "errors": null,
    "message": null
}

Does this support the ability to disable pagination? I think Aide need the list of workflows all in one call. This could be done with another query param

Adding integration tests to this


Sync workspace member across devices after removing member(s)

Details

Sync workspace member across device after member(s) removed.
Fixed Issues

$ https://github.com/Expensify/App/issues/7095
Tests

[x] Verify that no errors appear in the JS console

Open workspace member page with same account on two device
Remove member(s) on a device and refresh member page in other device
Members of workspace must be same on those two device
In android must go back to setting page and then go to member page to update the member list.

QA Steps

[x] Verify that no errors appear in the JS console

Open workspace member page with same account on two device
Remove member(s) on a device and refresh member page in other device
Members of workspace must be same on those two device
In android must go back to setting page and then go to member page to update the member list.

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop
[ ] iOS
[x] Android

Screenshots

Web

https://user-images.githubusercontent.com/1313124/151729076-e7d437b3-51b1-4dc9-87f5-e146f4b476f2.mp4
Mobile Web

https://user-images.githubusercontent.com/1313124/151729110-04065df4-ff0b-499c-85f6-80e8a625601a.mp4
Desktop

iOS

Android

https://user-images.githubusercontent.com/1313124/151729126-27f8df6a-67f1-4e2a-a7dc-6f5cec888f0b.mp4

Fix linter

cc: @Luke9389  All checks have passed

There could be unintended side-effects of this change.

@parasharrajat, this concerns me. Before approving I'm going to go read up on Onyx and be sure this change is exactly what we want it to be.

@Luke9389  We have been using Onyx.set in removeMember and there was no problem because of this.
https://github.com/Expensify/App/blob/16d38de1a943bc8393d34b745898f9d546a9e5be/src/libs/actions/Policy.js#L299
Also Kidroca tell to us to using Onyx.set in this issue in slack conversation.
I have tested it on navigating between workspaces, add and remove members and there is no problem.

@Luke9389 main merged.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Luke9389 in version: 1.1.37-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Load too big when parsing in parallel

When parsing some large uploads, there is a parser spawned for every core on the machine (using the default oasis setup with latest git). However the parsers (or maybe normalizers as well) are also using multiple threads each as far as I can see, so on machine with 8 cores the load when parsing some large upload can be up to 50.
I don't think this is optimal. Can something be done to make the default more reasonable to not overload that much?
In the meantime, how can I force just a single thread per parser (normalizer) process? I could probably force something like OMP_NUM_THREADS=1 globally (for the whole docker image, assuming the the threading is using OpenMP?), but I don't know if this is a good idea?

I added OMP_NUM_THREADS=1 to the worker environment in the docker-compose.yaml and the load is now OK. No idea if this is a too big hammer though? This is probably not a bug per se, just the example docker-compose.yaml in https://nomad-lab.eu/prod/rae/docs/oasis.html which I mostly copy-pasted in the beginning might not be optimal?
How about adding the OMP_NUM_THREADS: 1 to the worker environment in the example docker-compose.yaml?
BTW I would probably want to reduce the number of worker processes to something a bit lower than number of cores in order to not slow down rest of the components too much under heavy parsing. How can I do that?

We are using celery to distribute the processing load. The worker container runs a celery worker. The command used in the docker-compose is actually a celery command and can take an additional parameter to configure the concurrency (-c, --concurrency), see celery docs here. This parameter controls the number of processes (default is number of CPUs). You can add this parameter to your docker-compose.
command: python -m celery worker -l info -A nomad.processing -Q celery,calcs,uploads --concurrency=2

The parsers and workers are more or less single process/single thread. The exception is the system/symmetry classification (MatId) that uses spglib and spawns (one? additional process). @lauri-codes are you aware of any thread use in matid?
I am not entirely sure where the threads come from. In principle celery also supports an eventlet based threaded operation mode, but that should not used by default. Otherwise the app (uvicorn) and reprocess command itself (--parallel) use threads.
I can't say much about the any unwanted implications of setting OMP_NUM_THREADS.
I guess the overlying problem is that you don't want to spend all CPU on parsing when the same machine also runs the GUI/app? Limiting the worker to n-2 CPUs should be enough, giving the app 2 cores to do its stuff. Another option would be to use docker to limit CPU usage on the worker container.
This could become a common issue among oasis users. We'll do some more research and update the oasis documentation with more input on this.

Thanks, the --concurrency=x switch is exactly what I was looking for. Regarding where the threading comes from, it could be just  that something calls numpy or something similar which calls threaded BLAS? MatId could be the culprit as I have allowed the system normalizer even for large cases.
I can try to do some profiling if needed?

If the goal is to simply limit CPU utilisation limiting the number of processes should be enough, because all the threading would be limited to cores determined by the number of processes. Even if we knew what causes the threading exactly, we could not do much about it. If limiting the processes for some reason  is not enough, we would need to use tools like docker run --cpu or OMP_NUM_THREADS anyways.

If the goal is to simply limit CPU utilisation limiting the number of processes should be enough, because all the threading would be limited to cores determined by the number of processes.

I'm not sure if I follow here, even if I limit the number of processes, their core affinity would be by default all of the cores so in my specific scenario with 8 cores, having two worker processes can lead to theoretical load of 16 for the whole machine using all cores.
docker run --cpu will help for the other services (app/gui) to run fine, but there is still the issue with the worker itself. If the workers are overloaded, they just take longer than what they would run at single thread each. In my specific case with 8 cores, some example 500GB upload with ~200 VASP entries, using 8 worker processes with OMP_NUM_THREADS=1 leas to 2min:00s parsing time, and without the OMP_NUM_THREADS lead to 2min:45s parsing time (I'm not expert but this is likely some combination of the OpenMP overhead, unnecessary migration between the cores because of the overload, and cache eviction when the unnecessary threads fight for the cores).

I think some of the numpy/scipy functions will make use of BLAS/LAPACK libraries under the hood, which can then use multiple cores if they are available. So any package using numpy/scipy can potentially spawn new threads. I'm not using multiple threads or processes in MatID, but I can't vouch for spglib.

Not much that we can do at the moment. I added information about this (and possible solutions via celery worker, openMP, and docker cpu) to the documentation. It will be part of the next patch release.

I believe the docs were fixed some time ago, so closing.


CXXRTL: nmigen GrayDecoder triggers assert when generated from verilog (rtlil works)

Steps to reproduce the issue
Extract this file:
gray-cxxrtl-bug.tar.gz
change into the directory and execute:
yosys bug.ys
Expected behavior
No assert is triggered and the output file is generated.
Actual behavior
An assert will be triggered and an empty output file is generated:
[...]
Module `gray' contains feedback arcs through wires:
  gray.$13
  gray.$7
  gray.$5
  gray.$3
  gray.$1
  gray.$11
  $flatten\gray.$xor$gray.v:47$3_Y
Warning: Design contains feedback wires, which require delta cycles during evaluation.
$flatten\gray.$xor$gray.v:47$3_Y <=================  name of the wire that triggers the assert (debug print added)
ERROR: Assert `is_lhs' failed in backends/cxxrtl/cxxrtl_backend.cc:906.

Note: When generating from RTLIL like this:
read_rtlil gray.il
write_cxxrtl gray.cc

then everything works fine.

I suspect like a few other bugs this might be the same root cause, can you try applying https://github.com/YosysHQ/yosys/pull/2541 and let me know if this still happens. If not I have another theory that I will try and get around to testing.

@modwizcode I get merge conflicts, when I try to cherry-pick your commits onto master. Your fork is 330 commits behind yosys master. I will try to checkout your fork then.

@modwizcode I checked out your fork, and yes, that fixes the issue.

This is a duplicate of https://github.com/YosysHQ/yosys/issues/2540 and tested fixed by https://github.com/YosysHQ/yosys/pull/2541

@modwizcode I get merge conflicts, when I try to cherry-pick your commits onto master. Your fork is 330 commits behind yosys master. I will try to checkout your fork then.

I'll have to manually pull them up to date.
I'm glad it worked though, hopefully those changes are indeed the fix.

Let's keep this open for now, at least the repro is a lot smaller than in #2540.

Minimized with bugpoint:
module \gray$1
  wire $xor$repro1.v:47$3_Y
  wire \$9
  wire width 8 \o
  cell $xor $xor$repro1.v:47$3
    parameter \A_SIGNED 0
    parameter \A_WIDTH 1
    parameter \B_SIGNED 0
    parameter \B_WIDTH 1
    parameter \Y_WIDTH 1
    connect \A \o [3]
    connect \B 1'x
    connect \Y $xor$repro1.v:47$3_Y
  end
  connect \$9 $xor$repro1.v:47$3_Y
  connect \o [2] \$9
end


Specify config Json in the created Container

When creating the container, here, we should pass it a JsonObject containing both the container parameter (the JsonObject used to create it) and the response JsonObject (which contains only the Id and Warnings).
This is because later we may need to know how the Container was created (e.g. if it has TTY enabled or not), so we should be able to spare some HTTP calls.

@llorllale Do you want to do this?

Job #133 is now in scope, role is DEV

Bug was reported, see §29: +15 point(s) just awarded to @amihaiemil/z

The job #133 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat waiting on review/merge for PR #137

@0crat waiting on review/merge for PR #137  (here)

@llorllale The impediment for #133 was registered successfully by @llorllale/z

Order was finished: +30 point(s) just awarded to @llorllale/z

The job #133 is now out of scope


Create Godot project

We need a project for everyone to work on.

What version of Godot is used to create the project?


[DOC] "Download & Get Started" page is missing "Was this page helpful?"

What do you want to do?

[X ] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
The "Download & Get Started" page is missing a "Was this page helpful?" section for giving feedback.
I will provide feedback on that page in a separate issue.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

Since the Download and Getting Started page is not part of the documentation-website repo, there isn't a feedback mechanism by default. For now, you need to enter feedback the old fashioned way, through an issue. : ) We can look into what it would take to implement the mechanism in the project-website repo, if they are interested. @nateynateynate

How do I move this Issue to the project-website repo?

How do I move this Issue to the project-website repo?

@opensearch-project/admin


Wrong position of the selector in the debugging console

VSCode Version: 1.39.2
OS Version:

Steps to Reproduce:
1.open the selector in the debugging console
2.change the height of the debugging console
3. problem occurs

Does this issue occur when all extensions are disabled?: Yes

I can not reproduce this. Can you reproduce with vscode insiders https://code.visualstudio.com/insiders/
Can you post a screen shot of this issue?

like this：

@cleidigh assiggning to you if you have time to look into this.
I can not reproduce this.


Migrate automation to blueprint

I made this automation into a blueprint, which is a new form of sharing automations. (introduced in 2020.12/1.0)  https://www.home-assistant.io/blog/2020/12/13/release-202012/#blueprints
You can test the blueprint by importing it with this link: https://raw.githubusercontent.com/reesericci/MQTTCarPresence/patch-1/MQTTCarPresence.yaml
If the blueprints panel is not available in settings, then you need to update to the latest version of Home Assistant.
(I'm using the github raw link pointing to my forked repo, if merged you will have to change the import link to link to the main repository's copy. (raw link oc) )

@aderusha

@aderusha

@aderusha

Super cool, thanks @reesericci !

Super cool, thanks @reesericci !

no problem!

no problem!

lemme PR for the docs

lemme PR for the docs


Feat: Adding new issue and PR templates

Is your feature request related to a problem? Please describe.
currently, we are using .md files for issue template and PR template which can be replaced by .yml templates.
Benefits
this will help issue and PR creators to quickly summit them by just filling the data in the placeholder fields. Saving their time and making issue and PR board consistent.
Describe the solution you'd like
Creating new issue and pr .yml templates.
Describe alternatives you've considered
N/A
Additional context
After creating the new templates they will look like this

@frouioui pls. once approve this issue. I would love to open a PR for this
Thank you =)

That's not a bad idea, we have the same type of templates in vitess: https://github.com/vitessio/vitess/tree/main/.github/ISSUE_TEMPLATE.
If you have time to work on this go ahead!

Sure looking forward for this


core.unify on yonder boxen

Hi Brian,
I modified your project.clj file to allow you to pull core.unify's latest snapshot.  I will look into building a non-snapshot version ASAP.

We use core.unify now. (I did this by hand a long time ago.)


AWS: Define new m4 instance types

AWS has defined another instance type family.

@k8s-bot retest this please

Rebased & repushed, on the assumption that the k8s testing bot is testing the actual commit, and not the commit if merged into master.

Aha!  I know the secret now :-)


English Polish dictionary doesn't find 'know'

I have the English-Polish with English flag. When I start to type ' know', up to the 'o' all is fine, the words shown start with kno, but once I've typed the w, the list jumps from 'knob' to 'L' (exactly "L'Aquila (province) (proper noun)	L'Aquila {f}").
This happens always, even changing dictionary, and, because the word just before "kłąb" is Polish and not English, I suspect a bad formatting of the dictionary.
Thanks, Eric

I have a workaround that will appear in the next version and eliminate almost all these cases (I think), but a 100% fix takes more effort (starting with writing a checker for the dictionaries, unfortunately since Android uses its own ICU fork that means it needs to run on Android which means it will be slow and be a pain to use) and I think I won't have time.

The current solution seems to work fine and a fixed version is on the store, so I am closing this.

Looks good to me as well with version 5.4.9. Thanks a lot!


Problem with the assets

I have a problem with this tool. My problem is that I can't include my own assets files. I tried everything. If I don't use the standard textures it always show me the default texture.
Here is the error:
https://pastebin.com/Utw3eY6d

The error says that background.png is not found in the jar file

Yes but I think its because the client can not find the file in the assets folder. So i created a package named 'assets.minecraft.textures' and added there my file. But when I start the client it show this error anyway.

I want to draw a custom background on the MainMenuScreen. So i created a method https://pastebin.com/pcfH2wP8 and this method works because it shows the texture when minecraft misses a texture.
And in the render method from minecraft i execute:
drawTextureAt(new ResourceLocation("textures/background.png"));

It look like it works.
I just switched to eclipse.

Just noticed this and then it said closed 30 seconds ago, lol.

:)


ci: Run tests on pull requests

This PR adds a new Github Action to run tests on submitted pull requests.

Also I have intentionally left out eslint and TypeScript checks because there are lots of errors 😅 We can add those in once we get them to a stable state.

Also I have intentionally left out eslint and TypeScript checks because there are lots of errors 😅 We can add those in once we get them to a stable state.

Cool, opinions of fuzz tests in this workflow?

Cool, opinions on fuzz tests in this workflow?

@esaminu Do we have fuzz tests already in place for near-api-js?


RELATED: FET-803 Upgrade dependencies

Currently destined for release R235.
This release is zero downtime release.
Code drop: 2021-08-12 00:00.

Story FET-803 Upgrade packages in selected UI libs
Status: Hacking
Priority: Major
Assignee: Petr Benes

The code coverage decreased with your change 🤕
Consider an extension of the unit tests covering the changed code, please.
Report (compared to build #241)
Covered lines: 48.95%, change: 0%
Covered branches: 68.11%, change: -0.74% (additional 2 branches are not covered)
Coverage report
https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-unit-tests-zuul-docker-el7/242/artifact/ci/results/coverage/lcov-report/index.html

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-pull-request-compliance-check/150/ : SUCCESS in 6s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-oss-check/5/ : SUCCESS in 7s
https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-unit-tests-zuul-docker-el7/242/ : SUCCESS in 1m 16s

Sonar scan result
More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-typings-gate-PR85
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-pull-request-compliance-gate/51/ : SUCCESS in 5s
https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-unit-tests-zuul-docker-el7/243/ : SUCCESS in 1m 12s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-sonarqube-scan-zuul-gate/1/ : SUCCESS in 1m 15s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-fossa-scanning-zuul-el7/14/ : FAILURE in 2m 31s (non-voting)


Update release notes and reference for upcoming Compose 1.23.0 release

Proposed changes
Update release notes and command reference for upcoming Compose 1.23.0 release
Unreleased project version (optional)
Compose 1.23.0

Deploy preview for docsdocker ready!
Built with commit d5b9b8bf0f66fe30bb64a10420a0812889a59754
https://deploy-preview-7447--docsdocker.netlify.com

@shin- Wanted to clarify the release date for Docker Compose 1.23.0. When is this rolling out?

@bermudezmt Planning to finalize and send it out later today!

@shin- ping me and I'll review and merge. :)


Writeup describing what percolation is

Probably move chart to top and follow up with text, or attempt to make it a two-page app of the simulation and some theory/links of percolation.

Need to make a chart of Probability(maxcluster >50%) for different site occupation thresholds $p$ and some different system sizes to add to the writeup for clarity.


Loan Comparison outputs highlighting

Adds highlighting logic/styling for the outputs with educational notes to match the latest design.
Note: this will be easier to review once #449 is merged, since I branched off that.
Additions

Logic for adding highlights to an output row
Pass scenario prop to row components for highlighting

Changes

Whitespace tweaks for tables, tbody, table row elements
Primary highlighted row gets a wider green background on the left
Primary row heading is bolded to match design
Expandables icon is larger, positioned to match design
Tooltips font style was fixed to match the inputs
Results row has bottom border style
Label updates for the Monthly outputs to remove word "monthly" in each

Review

@stephanieosan
@virginiacc
@huetingj

Preview

:+1: looks good to me!

Looks good!


nla_type is incorrectly parsed for nested attributes

Summary
neli parses nla_type incorrectly for nested attributes.
Version
0.4.3
Expected Behavior
Given a nested attribute with nla_type set to<PHONE_NUMBER>001000b (decimal 32776) in the message payload, neli should parse the nla_type as<PHONE_NUMBER>001000b (decimal 8).
Actual Behavior
neli incorrectly parses attribute type<PHONE_NUMBER>001000b as<PHONE_NUMBER>001000b
Description
The two most significant bits of the nla_type is used to denote if the attribute is nested (bit 0), and if the payload is in network byte order (bit 1).
Since these are meta data for the attribute, those bits should be masked out before setting the nla_type field in the Nlattr struct being parsed.

Reference:
https://github.com/torvalds/linux/blob/90280eaa88ac1a9140dc759941123530d5545bb6/include/uapi/linux/netlink.h#L216-#L228

I remember bumping into that documentation when writing the attribute handling code that I have. While this should definitely be considered a bug and be fixed, there are two reasons it's not there:

I think I meant to provide a way to exact those bits and the type itself separately at some point. That clearly never happened so thank you for reporting this.
The kernel subsystem I work in predominantly doesn't seem to set these bits so I never bumped into this during my testing. I'm not actively involved in kernel development so I'm unsure if this is a bug or an unrelated reason.

Either way, let's talk about fixing this. My initial idea for this is that we make an NlaType struct that has two boolean fields and then mask those two bits out for the type. Does this sound good to both of you? Do you have other ideas?
One note is that I'll merge this into master before my v0.5.0-dev branch because there are significant breaking changes to the API and I'd like to allow you to take advantage of the fix by pinning at that commit and then you can roll over to v0.5.0 as you have the time. Does that sound good?

While this should definitely be considered a bug and be fixed, there are two reasons it's not there

Thanks for explaining here! Bugs happen. 🙂

Either way, let's talk about fixing this. My initial idea for this is that we make an NlaType struct that has two boolean fields and then mask those two bits out for the type. Does this sound good to both of you? Do you have other ideas?

Do you think those fields are useful to consumers of neli? (I'm not sure myself.) I can see the nested bit being useful, but I think it's worth noting that netlink.h chose to just mask out those bits in their implementation of nla_type().
I would vote to do the same for a v0.4.4 release so this doesn't produce a breaking change on the v0.4.x branch. That's my thought, but the decision is up to you of course.

One note is that I'll merge this into master before my v0.5.0-dev branch because there are significant breaking changes to the API and I'd like to allow you to take advantage of the fix by pinning at that commit and then you can roll over to v0.5.0 as you have the time. Does that sound good?

That sounds good, but any chance we can get a v0.4.4 release as well? I do think that would be helpful.

While this should definitely be considered a bug and be fixed, there are two reasons it's not there

Thanks for explaining here! Bugs happen. slightly_smiling_face

Either way, let's talk about fixing this. My initial idea for this is that we make an NlaType struct that has two boolean fields and then mask those two bits out for the type. Does this sound good to both of you? Do you have other ideas?

Do you think those fields are useful to consumers of neli? (I'm not sure myself.) I can see the nested bit being useful, but I think it's worth noting that netlink.h chose to just mask out those bits in their implementation of nla_type().

I do think I need to include those bits but how I go about it is up for debate. It may also be reasonable to add those boolean fields at the Nlattr level as opposed to the nla_type level as that might be easier for a user to interact with. What do you think?

I would vote to do the same for a v0.4.4 release so this doesn't produce a breaking change on the v0.4.x branch. That's my thought, but the decision is up to you of course.

I'm happy to release a version of v0.5.0-rc1 but I cannot release on the v0.4.x track because I've already merged breaking changes into master. This would a allow a released version on crates.io that would contain a minimal number of breaking changes. Does that sound good?

One note is that I'll merge this into master before my v0.5.0-dev branch because there are significant breaking changes to the API and I'd like to allow you to take advantage of the fix by pinning at that commit and then you can roll over to v0.5.0 as you have the time. Does that sound good?

That sounds good, but any chance we can get a v0.4.4 release as well? I do think that would be helpful.

See above, but this seems like a strong argument for supporting minor version branches moving forward. For now, I think a release candidate before merging the very big breaking changes is the best I can do.

For now, I think a release candidate before merging the very big breaking changes is the best I can do.

Ah understood.

I do think I need to include those bits but how I go about it is up for debate. It may also be reasonable to add those boolean fields at the Nlattr level as opposed to the nla_type level as that might be easier for a user to interact with. What do you think?

I do lean towards that. Although these bits are in nla_type, they're really attribute level information so it makes sense from that perspective. The downside of having these at the Nlattr level is that it deviates from the C implementation. I think that's fine but I'm not sure how you feel about that.

For now, I think a release candidate before merging the very big breaking changes is the best I can do.

Ah understood.

I do think I need to include those bits but how I go about it is up for debate. It may also be reasonable to add those boolean fields at the Nlattr level as opposed to the nla_type level as that might be easier for a user to interact with. What do you think?

I do lean towards that. Although these bits are in nla_type, they're really attribute level information so it makes sense from that perspective. The downside of having these at the Nlattr level is that it deviates from the C implementation. I think that's fine but I'm not sure how you feel about that.

I think that even though it deviates from the C implementation, it's more understandable as an abstraction so it would probably be more user friendly. I'll put up a PR, tag you both in it to test, and if it works for you, I'll cut a release candidate.

Thanks, @jbaublitz, for responding to this so quickly!
I agree with @gluxon that if we do want to keep the flags, Nlattr does seem like a better home than having them in NlaType.
Really grateful to the both of you for helping with this.

v0.5.0-rc1 is released.

@jbaublitz Hey John, thanks for the patch. You may be interested in the source of this change, which I believe is this kernel patch last year.
https://github.com/torvalds/linux/commit/ae0be8de9a53cda3505865c11826d8ff0640237c
While applying the fix on https://github.com/gluxon/wireguard-uapi-rs I discovered that kernel versions after this patch require the NLA_F_NESTED set for messages sent. Just a heads up that it may not be enough to just mask away the bit on read.


Closing wse pending writer when the wse session is closed

@jitsni  Can you do a catch up merge.  And should this go into the RC?

Not needed for RC

@cmebarrow do you think we need this one ? If it is required then I will do catchup merge on this branch.

@jitsni Looks like a reasonable change. What motivated making the change? Is there a test case that was failing?

@cmebarrow It just feels like the pending writer is not closed. I don't have a test case. Also, I haven't observed any failure in existing test cases.

@dpwspoon @jitsni Can we merge this PR ?

@jitsni Please do a catch up merge and or close.  We can get this in next rc and run full regression tests to make sure there is no race

Closing this for now.


comments on migrated issues/prs must link to the comment ID (#18630)

Instead of the issue ID which is not a valid anchor.
Backport of https://github.com/go-gitea/gitea/pull/18630

Removing the backport/v1.16 label because it is for prs that need backporting, not for prs that are being backported.

Removing the backport/v1.16 label because it is for prs that need backporting, not for prs that are being backported.

I understand it the other way around, so the backport tags are for the main PR, and the backports themselves are untagged.

Removing the backport/v1.16 label because it is for prs that need backporting, not for prs that are being backported.

I understand it the other way around, so the backport tags are for the main PR, and the backports themselves are untagged.

That's what I tried to write down but in a complicated and unclear way. Thanks for making it clearer.


refactor(footers): updated footer styles

Closes #463
Description
Refactored Footer component examples.
Current behavior (updates)
They had a few design issues.
New behavior
Improved the styles.
Is this a breaking change (Yes/No):
No

@illionillion
This is what would be displayed on an iPhone SE. I do not think users would have a narrower screen than an iPhone SE.

@illionillion
This is what would be displayed on an iPhone SE. I do not think users would have a narrower screen than an iPhone SE.

@taroj1205
Certainly users will not use a device with a smaller screen than the iphone se, but there is a possibility of narrowing the window width.
It's better to fit the screen width than to have a smaller external width that still protrudes.


Add  repr  to function classes

It is currently hard to debug errors in the function classes when they get heavily layered. It would be helpful to show the chain of the functions in the repr:
f = Exp1D(Constant1D(92.1) * Interpolate(x) / Constant1D(2.3)**Gain(x)))

displays as e.g.:
f = e^(92.1 * Interpolate(x) / 2.3**Gain(x))

It may also be useful for users to override the name of classes such as Interpolate, to make the data they are interpolating visible to the user:
f = e^(92.1 * LightIntensity(x) / 2.3**Gain(x))

+1 for this, though I would vote for __repr__ looking like your first code block, and having an additional __str__ for your second block. Then you could directly copy and paste the repr into a terminal to reproduce the object, which may also be useful for debugging.
This would mean the special arithmetic method functions (for __add__, __sub__ etc) would have identical __str__ and __repr__ representations, but more special cases such as the cmath functions, interpolators and Arg and Constant would need both methods.


V2->V1 bemap downgrade patch in 1.10

We need to implement some logic to downgrade from V2 backend map (introduced in PR #17235) to legacy V1 backend map. This logic needs to go into 1.10.

Fixed with above PR merged.


Joomla 5 compatibility

Hello, What are the plans for you to update your extension to be Joomla 5 compatible?

Hello, What are the plans for you to update your extension to be Joomla 5 compatible?

As i check, the explorer is working fine on joomla 5. Kindly check.

Many thanks. It is. Perhaps make it so when people upgrade from 4 to 5, it doesnt come up as an incompatible extension. Thank you for this wonderful extension

Don't worry, I work with ffexplorer on J5 every day, and it seems to have no issues.
Anyway, I do have a plan to upgrade it to Vue 3.
I hope it will be done soon.

any news on updating ffexplorer ?

any news on updating ffexplorer ?

Sorry, I've been busy and couldn't spend much time on ffexplorer. If you encounter any issues, just let me know, and I'll quickly fix them if possible.

any news on updating ffexplorer ?

Sorry, I've been busy and couldn't spend much time on ffexplorer. If you encounter any issues, just let me know, and I'll quickly fix them if possible.


Enhancement: ability to adjust rendering interval.

Background
When running experiments that have 2000+ trials, the web page is overloaded for frequent rendering. We need the ability to adjust rendering interval (manually or automatically).
Without this feature, how does current nni work：slow render
Components that may involve changes: webui
Brief description of your proposal if any:--

Add auto refresh setting drop-down & Refresh button  at the top navigation area.

Users can click the drop down and choose auto refresh 10s, 30s, 60s or disable it.
Users can also click the Refresh button to refresh manually.

overview

Drop down

After secleted 'Refresh every 30s'


Forcelly set QUARKUS_LOG_CONSOLE_JSON to false if the trait is not provided (GH issue #2539)

Ensures that QUARKUS_LOG_CONSOLE_JSON is set to false if the logging.json trait is not provided

Release Note
Ensures that QUARKUS_LOG_CONSOLE_JSON is set to false if the `logging.json` trait is not provided

@orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ?

@orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ?

I believe the warning should go away in this case. I was looking in the code and we are already including the quarkus-logging-json in the classpath when the json logging is true.
Now that we changed the default behavior if unset, I don't think we should get into a situation where it tries to log via json and it is not on the classpath. What do you think?

Looks good to me, wonder if we can add io.quarkus:quarkus-logging-json as transitive dependency o camel-k so this trait would not need to change the dependencies. This would also ensure the dependency to be present inc case you provide your own container image

@orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ?

I believe the warning should go away in this case. I was looking in the code and we are already including the quarkus-logging-json in the classpath when the json logging is true.
Now that we changed the default behavior if unset, I don't think we should get into a situation where it tries to log via json and it is not on the classpath. What do you think?

Looks good to me, wonder if we can add io.quarkus:quarkus-logging-json as transitive dependency o camel-k so this trait would not need to change the dependencies. This would also ensure the dependency to be present inc case you provide your own container image

The only likely downside is that we would need release both the runtime and camel K if we decide to backport this fix ... but, frankly, I am fine with both approaches.
Maybe we could add it here in the Runtime?

@orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ?

I believe the warning should go away in this case. I was looking in the code and we are already including the quarkus-logging-json in the classpath when the json logging is true.
Now that we changed the default behavior if unset, I don't think we should get into a situation where it tries to log via json and it is not on the classpath. What do you think?

Looks good to me, wonder if we can add io.quarkus:quarkus-logging-json as transitive dependency o camel-k so this trait would not need to change the dependencies. This would also ensure the dependency to be present inc case you provide your own container image

The only likely downside is that we would need release both the runtime and camel K if we decide to backport this fix ... but, frankly, I am fine with both approaches.
Maybe we could add it here in the Runtime?

I think we can defer this additional dependency to camel-k 1.6 & camel-k-runtime 1.9

@orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ?

I believe the warning should go away in this case. I was looking in the code and we are already including the quarkus-logging-json in the classpath when the json logging is true.
Now that we changed the default behavior if unset, I don't think we should get into a situation where it tries to log via json and it is not on the classpath. What do you think?

Looks good to me, wonder if we can add io.quarkus:quarkus-logging-json as transitive dependency o camel-k so this trait would not need to change the dependencies. This would also ensure the dependency to be present inc case you provide your own container image

The only likely downside is that we would need release both the runtime and camel K if we decide to backport this fix ... but, frankly, I am fine with both approaches.
Maybe we could add it here in the Runtime?

I think we can defer this additional dependency to camel-k 1.6 & camel-k-runtime 1.9

Deal. Let me merge this as a work-around for now, then I'll backport it to 1.5. I'll add a task to myself to do this cleanup in the 1.6 time frame and will take care of it when I come back from PTO.


Some attachments break JSON encoding

  [InvalidArgumentException]
  json_encode error: Malformed UTF-8 characters, possibly incorrectly encoded

Exception trace:
 () at /app/vendor/guzzlehttp/guzzle/src/functions.php:326
 GuzzleHttp\json_encode() at /app/vendor/guzzlehttp/guzzle/src/Client.php:314
 GuzzleHttp\Client->applyOptions() at /app/vendor/guzzlehttp/guzzle/src/Client.php:273
 GuzzleHttp\Client->transfer() at /app/vendor/guzzlehttp/guzzle/src/Client.php:125
 GuzzleHttp\Client->requestAsync() at /app/vendor/guzzlehttp/guzzle/src/Client.php:131
 GuzzleHttp\Client->request() at /app/vendor/wildbit/postmark-php/src/Postmark/PostmarkClientBase.php:140
 Postmark\PostmarkClientBase->processRestRequest() at /app/vendor/wildbit/postmark-php/src/Postmark/PostmarkClient.php:69
 Postmark\PostmarkClient->sendEmail() at x

Unfortunately I can't provide the attachment for confidentiality, but I'm wondering if there's a way to encode the binary file (e.g. base64) to avoid this issue.

Turns out it's my fault, sending the attachment in the wrong parameter.