fix: makes uri decode platform independent

REQUEST_URI variable content goes automatically through a URL decoding transformation process:
https://github.com/SpiderLabs/ModSecurity/blob/5b094c0ce9044044f740e135df2a60c5f0858d4d/src/transaction.cc#L466
Internally the transformation is based on the HEX2DEC array mapping.
https://github.com/SpiderLabs/ModSecurity/blob/5b094c0ce9044044f740e135df2a60c5f0858d4d/src/utils/string.h#L34-L55
HEX2DEC array returns (char)-1 when the conversion fails. The result is then compared with -1:
https://github.com/SpiderLabs/ModSecurity/blob/5b094c0ce9044044f740e135df2a60c5f0858d4d/src/utils/decode.cc#L102-L103
The C/C++ standard is not strict about the char implementation, allowing it to be signed or unsigned. Because of that, if an environment interprets the char as an unsigned char the conversion is never considered as failed ((char)-1 overflows to 255 and is compared against -1).
This PR proposes to make the comparison more portable, forcing the comparison between a platform-dependant value ((char)-1).
Discovered running the owasp/modsecurity-crs:nginx image on Apple silicon processors.
Example Rule that is failing:
SecRule REQUEST_URI "@rx \x25" \
    "id:920220,\
    phase:1,\
    deny,\
    t:none"

Request:
curl -v "http://localhost:80/?x=%w20"

%w should not be interpreted as a valid encoded sequence, therefore % should still be present in the REQUEST_URI and the regex should match.
Variables affected: REQUEST_URI, REQUEST_FILENAME
Dug into it with: @theseion, @theMiddleBlue, @airween

Hi @M4tteoP, thanks for this PR. I remember this issue, now I reviewed it again and I think both the explanation and solution is very nice. If there won't be any remarks, I will merge it soon.


Orthographic error in the BootConfig properties

There is a property called "WarnningInfo", but it should be "WarningInfo". "Warnning" is also written in the description.

oa, ok, thanks for your report. it looks like i mix this with 'running' grammar  !  🤣 i will fix it on next version.

You're welcome ! ^^
Also I have a question : did you hard-code the Love2dCS Library ? It seems
like you're using a cpp source and a DLL file, then wrapping the code for
C#, which I don't really understand.
Le mar. 14 mai 2019 à 04:17, Yx<EMAIL_ADDRESS>a écrit :

oa, ok, thanks for your report. it looks like i mix this with 'running'
grammar ! 🤣 i will fix it on next version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/endlesstravel/Love2dCS/issues/61?email_source=notifications&email_token=ADJ54UHDG7K6DNFI3HYFXFDPVIOMPA5CNFSM4HMKVJR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVKCAXI#issuecomment-492052573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADJ54UHRGPFFZAIL6TUOJPLPVIOMPANCNFSM4HMKVJRQ
.

sorry, i can't understant the hard-code. but the love.dll is compiled from official code and homemade(in c_api_src folder) code.
First, i build project : https://love2d.org/wiki/Building_LÖVE
Then add export function code into project.
Then re-compile project to get the love.dll.
And last,  i binding the native love.dll with C# language.

I see, you used the LÖVE binary to wrap it into C#. When I said
"hard-coded", I meant "re-coded the Library in C# by yourself". Like if you
translated the (C or Lua code, I Don't know) into C#.
That would have been very useful for open source contribution - at least
for me.
Le mar. 14 mai 2019 à 14:25, Yx<EMAIL_ADDRESS>a écrit :

sorry, i can't understant the hard-code. but the love.dll is compiled
from official code and homemade(in c_api_src folder) code.
First, i build project : https://love2d.org/wiki/Building_LÖVE
Then add export function code into project.
Then re-compile project to get the love.dll.
And last, i binding the native love.dll with C# language.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/endlesstravel/Love2dCS/issues/61?email_source=notifications&email_token=ADJ54UF3EDVQMXDZSB55KGDPVKVU7A5CNFSM4HMKVJR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLJ2QI#issuecomment-492215617,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADJ54UHWZT3AP5RZ2TJYOITPVKVU7ANCNFSM4HMKVJRQ
.


Exception getting optionset metadata info from Dataverse : Failed to resolve....

We have a system integrations using function apps, which when triggered, read data from the Dataverse, and sync it to another systems.
One particular function app runs 50k-60k times a day. It could fail a few times a day due to not being able to get something from the dataverse, which it can easily get thousands of other times.
The error below reads to me that something was not quite right on the Dataverse side. Is there anything I can do/check in the Dataverse to figure out why it was closing the connection?
The errors come in 3 for the same function app integration instance.
************ CommunicationException - RetrieveOptionSet : GetGlobalOptionSetMetadata |=> An error occurred while sending the request.

Source: System.Private.ServiceModel
Method: ProcessGetResponseWebException
DateUTC: 3/19/2023 TimeUTC: 1:35:40 AM
Error: An error occurred while sending the request.
HelpLink Url: Not Provided

Stack Trace: at System.ServiceModel.Channels.HttpChannelUtilities.ProcessGetResponseWebException(HttpRequestException requestException, HttpRequestMessage request, HttpAbortReason abortReason)
at System.ServiceModel.Channels.HttpChannelFactory`1.HttpClientRequestChannel.HttpClientChannelAsyncRequest.SendRequestAsync(Message message, TimeoutHelper timeoutHelper)
at System.ServiceModel.Channels.RequestChannel.RequestAsync(Message message, TimeSpan timeout)
at System.ServiceModel.Channels.RequestChannel.RequestAsyncInternal(Message message, TimeSpan timeout)
at System.Runtime.TaskHelpers.WaitForCompletionNoSpin[TResult](Task`1 task)
at System.ServiceModel.Channels.RequestChannel.Request(Message message, TimeSpan timeout)
at System.ServiceModel.Dispatcher.RequestChannelBinder.Request(Message message, TimeSpan timeout)
at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout) at System.ServiceModel.Channels.ServiceChannelProxy.InvokeService(MethodCall methodCall, ProxyOperationRuntime operation)
at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(MethodInfo targetMethod, Object[] args)
at generatedProxy_1.Execute(OrganizationRequest )
at Microsoft.PowerPlatform.Dataverse.Client.Connector.OrganizationWebProxyClientAsync.<>c__DisplayClass52_0.b__0()
at Microsoft.PowerPlatform.Dataverse.Client.Connector.WebProxyClientAsync`1.ExecuteAction[TResult](Func`1 action)
at Microsoft.PowerPlatform.Dataverse.Client.Connector.OrganizationWebProxyClientAsync.ExecuteCore(OrganizationRequest request)
at Microsoft.PowerPlatform.Dataverse.Client.Connector.OrganizationWebProxyClientAsync.Execute(OrganizationRequest request)
at Microsoft.PowerPlatform.Dataverse.Client.ServiceClient.Command_Execute(OrganizationRequest req, String errorStringCheck, Boolean bypassPluginExecution)
======================================================================================================================
Inner Exception Level 1 :
Source: System.Net.Http
Method: MoveNext
DateUTC: 3/19/2023
TimeUTC: 1:35:40 AM
Error: An error occurred while sending the request.
HelpLink Url: Not Provided

Stack Trace: at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at System.ServiceModel.Channels.HttpChannelFactory`1.HttpClientRequestChannel.HttpClientChannelAsyncRequest.SendRequestAsync(Message message, TimeoutHelper timeoutHelper)
======================================================================================================================
Inner Exception Level 2 :
Source: System.Net.Sockets
Method: ThrowException
DateUTC: 3/19/2023 TimeUTC: 1:35:40 AM
Error: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..
HelpLink Url: Not Provided

Stack Trace: at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Security.SslStream.ReadAsyncInternal[TIOAdapter](TIOAdapter adapter, Memory`1 buffer) at System.Net.Http.HttpConnection.g__ReadAheadWithZeroByteReadAsync|45_0()
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
======================================================================================================================
Inner Exception Level 3 :
Source: Not Provided
Method: Not Provided
DateUTC: 3/19/2023 TimeUTC: 1:35:40 AM
Error: An existing connection was forcibly closed by the remote host.
HelpLink Url: Not Provided

Stack Trace: Not Provided
======================================================================================================================

[TerminalFailure] Failed to Execute Command - RetrieveOptionSet : RequestID=f8beed67-ca9f-4256-8da7-81aefa2190a7 : GetGlobalOptionSetMetadata duration=00:00:18.9689877 ExceptionMessage = An error occurred while sending the request.

************ Exception getting optionset metadata info from Dataverse : Failed to resolve global optionset metadata for msdyn_wosystemstatus.
Source: Not Provided
Method: Not Provided
DateUTC: 3/19/2023 TimeUTC: 1:35:40 AM
Error: ************ Exception getting optionset metadata info from Dataverse : Failed to resolve global optionset metadata for msdyn_wosystemstatus.
HelpLink Url: Not Provided
Stack Trace: Not Provided ======================================================================================================================

Further context.
The integration works like so

Logic App triggers on changes to data in Dataverse
Logic app sends request to Function App to start the integration process.
If the Function App throws an error back to the Logic App, the Logic app starts a retry mechanism.

So in these instances, the integration run is retried and works the second time.
My problem is we are using app insights, and to me it feels like we are logging Exceptions (from the function app) that we don't really need to because the logic app retries eventually and the integration is successful.
So either:

Figure out this issue to stop it completely, so it isn't logging exceptions that we don't need to look into.
Or move the retry mechanism into the function app and ONLY log the exception if all retries fail.

First off:
"An existing connection was forcibly closed by the remote host." is a networking layer failure.
Its generally caused by a network in the middle terminating the connection, if this is happening frequently, I would suspect a misconfigured gateway or firewall.
The ServiceClient does not auto retry these as (historically) they tend to be terminal, and no amount of retry within the few milliseconds will resolve it.  That said, the changes made to the .net 6 + networking stack seem to have caused these issues to appear more frequently when mixed with some firewall / packet filtering solutions.   Depending on how frequently it surfaces in the future, we may provide a retry option (enabled on request) to retry them internally to the client.   We have been discussing that internally.
on the second concern.
You could use a telemetry  processor to skip these exceptions to AppInsights..

Closing this at this point,
If there is a follow up, please reopen with more information.
thanks!


add JS test for alias register and revoke

This is based on #85 which should be merged first.
I wanted to add a test for aliases to it but couldn't.

The client plugin needs a new version after https://github.com/ssb-ngi-pointer/ssb-room-client/pull/1
even with master of the above I get this:

/home/cryptix/ssb/ssb-room-client/lib/plugin-room-client.js:30
                rooms.get(roomKey).rpc.room.registerAlias(alias, sig, cb);

TypeError: Cannot read property 'registerAlias' of undefined
    at Object.registerAlias (/home/cryptix/ssb/ssb-room-client/lib/plugin-room-client.js:30:44)
    at Object.hooked [as registerAlias] (/home/cryptix/go-repos/ssb-rooms/muxrpc/test/nodejs/node_modules/hoox/index.js:10:15)
    at Timeout._onTimeout (/home/cryptix/go-repos/ssb-rooms/muxrpc/test/nodejs/testscripts/modern_aliases.js:12:23)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)

I suspect some namespace/manifest meh-ness. I successfully used room.registerAlias already with go-ssb/cmd/sbotcli which ignores the manifest.

@staltz would be cool if you could take this.
I think this just needs an updated package.json in muxrpc/test/nodejs, updating the deps and running go test -run Aliases should then pass, I think.

@cryptix I updated ssb-room-client (I think in the future I'd like to update secret-stack to support a nicer way of declaring remote APIs that are not implemented locally) and other dependencies, but now I think there are errors from Go:
revokeAlias: not your alias (moderators need to use the web dashboard of the room

Also, registerAlias should respond with a string matching the alias URL. This should also be asserted in tape.

Thank you! I can take this over again.

I think there are errors from Go

There is a missing mock-setup call to have it not flunk out here:
https://github.com/ssb-ngi-pointer/go-ssb-room/blob/07feacb5587e2baa912b8203909cf41fa6f0a672/muxrpc/handlers/alias/handler.go#L118
(background: these tests run with a mocked alias store so it doesn't actually store the alias)

All done and register now returns the URL.
Fixes #86


[Backport 2.x] Remediate CVE-2023-1370 and CVE-2023-20861 via version bumps

Description
Bumps JSON-Smart to version 2.4.10 to address https://github.com/advisories/GHSA-493p-pfq6-5258.
Bumps Spring-core to version 5.3.26 to address https://github.com/advisories/GHSA-564r-hj7v-mcr5.
Backports https://github.com/opensearch-project/security/pull/2606
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2631 (611b7a6) into 2.6 (6e05e7d) will decrease coverage by 0.11%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.6    #2631      +/-   ##
============================================
- Coverage     61.06%   60.95%   -0.11%
+ Complexity     3252     3247       -5
============================================
  Files           258      258
  Lines         18137    18136       -1
  Branches       3232     3232
============================================
- Hits          11075    11055      -20
- Misses         5490     5504      +14
- Partials       1572     1577       +5

see 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Questions about paper

Thanks for sharing great work and dataset!
I have two questions about paper.
First of all, I think that authors mainly follow the losses and architecture of ALBEF. But, CTP do not use the ITM loss as the loss function. Is there any reason? Moreover, do you have any experimental results when ITM loss is added?
Secondly, what is the main difference between "cross-modal retrieval" vs "Multi-modal retrieval" and what is the reason of the experiment about multi-modal retrieval? I guess that the latter use the [CLS] representation of multi-modal encoder and calculate the zero-shot clustering (same class). Similar to the first question, if the ITM loss is added, I wonder about the results of cross-modal retrieval and multi-modal retrieval.

Thank you for your question. I would like to take this opportunity to explain in detail our motivations and considerations behind our design.
Q1:
ITM's classifier is commonly utilized as a post-processing step in retrieval. It involves retrieving the top-K samples based on embedding alignment and then scoring them using the classifier for reranking. However, we chose not to adopt ITM for the following three reasons:

Our research focuses on developing a general continual pretraining approach, rather than a specific multimodal pretraining model. Our primary objective is to investigate the modality alignment and fusion capabilities in continual pretraining and identify effective continual pretraining methods.  Similar to CLIP, modality alignment is achieved through ITC, and embedding alignment is evaluated through cross-modal retrieval, which has met our research objectives about modality alignment. Introducing additional rerank steps through ITM not only makes the settings more complex but also impacts the cross-modal retrieval indicators, making it difficult to accurately evaluate and analyze the ability of various continual learning methods in maintaining modal alignment.
The introduction of ITM will complicate the re-implementation of baseline methods. To re-implement the continual learning method in classification, we move the alignment of 'feature - label' in classification to the alignment of 'image - text' in VLP, Thus, we only need to re-implement each method by changing ITC. Introducing ITM as an additional classifier would lead to more ambiguous re-implementations. Using LWF as an example, on the basis that ITC has already been reimplemented, does ITM align the correct one-hot label or the logit of the previous task model, or both?
In addition, ITM and its rerank post-processing also increase training and evaluation time but rerank is not the focus of our study.

To sum up, we excluded the use of ITM in the baseline model and did not conduct any experiments with ITM loss.
Q2:
The operation of multi-modal retrieval is consistent with what you said. The purpose of multi-modal retrieval is to intuitively evaluate the zero-shot clustering ability of multi-modal fusion features (e.g. image+text) without the influence of fine-tuning on downstream tasks. If the clustering effect of multimodal embedding is better, it indicates that the overall multimodal fusion is more effective in achieving compactness within each class and differentiation between classes.
This task and evaluation method is mostly used for commodity-related tasks. For more materials about similar tasks or related evaluations, please refer to [1][2][3][4][5].
[1] Product1M: Towards Weakly Supervised Instance-Level Product Retrieval via Cross-Modal Pretraining
[2] M5Product: Self-harmonized Contrastive Learning for E-commercial Multi-modal Pretraining
[3] CommerceMM: Large-Scale Commerce MultiModal Representation Learning with Omni Retrieval
[4] VIMER-UMS : https://wenxin.baidu.com/wenxin/modelbasedetail/vimer_ums
[5] TIANCHI: https://tianchi.aliyun.com/dataset/75730

Thanks for the clarification.
Given the minimal performance difference between seqF and continual-based methods in "multi-modal retrieval", it raises the question of whether the multi-modal encoder, when employing the ITM loss, is resilient to catastrophic forgetting in the original evaluation setting in ALBEF ("cross-modal retrieval").

Sorry for keeping you waiting, as I needed to run some experiments. I introduced ITM into the training process (which adds additional ITM classification parameters and consumes more forward memory), but it is not used for the rerank operation. (As mentioned before, the two-stage post-processing of rerank can blur the measurement of cross-modal alignment ability.) In other words, ITM and related parameters are only used for training and not for the final model inference. From this point of view, the final models of all baseline methods still have the same number of parameters, making it fair for comparison. The experimental results are as follows:
| cross-modal retrieval（Rm） | multi-modal retrieval（mAP@1）
-- | -- | --
seqF | 56.31 | 61.93
seqF + ITM | 56.32 | 51.64
JointT | 79.93 | 64.62
JointT  + ITM | 79.17 | 59.54
CTP | 64.39 | 62.04
CTP + ITM | —— | ——
Due to the fact that ’CTP+ITM‘ has exceeded the memory limit of 40G A100, we were unable to obtain results for this experiment. All logs and modified clip_pretrain.py files used in this experiment can be found at this link.
The results indicate that adding ITM does not enhance cross-modal alignment ability. On the contrary, it significantly reduces the multi-modal retrieval capability. This may be due to the introduction of the training loss of ITM, which may lead to insufficient training of the original MLM.
In regards to the issue of why there isn't a significant difference in various methods for multimodal retrieval, we have some speculations in section 5.2 of the original paper titled 'Cross-modal vs. Multi-modal'.:

The redundancy and complementarity of multi-modal information.
the predefined and well-initialized token space in BERT.

Besides, I have another uncertain guess regarding the evaluation method in multimodal retrieval. The current approach of evaluating multiple-to-multiple retrieval may not be as precise in homogeneous product domains as it is in cross-modal retrieval, which uses a one-to-one retrieval approach. This could explain why there isn't a significant difference in multimodal retrieval metrics between different methods. Perhaps a more refined metric is needed to accurately measure multimodal retrieval ?
I understand that it may be difficult for some to accept the similarity in multimodal retrieval results between different continual learning methods. However, as researchers, it is important to convey the information that the data presents, rather than sugarcoat it to avoid controversy. To support our findings, I have provided the experimental logs.
It is also important to note that our goal is to study the changes in cross-modal alignment and multimodal fusion capabilities of pre-trained models under continual pretraining, rather than solely focusing on improving retrieval accuracy like most offline-trained VLP models. Retrieval is merely a tool to evaluate the alignment and fusion capability of continually pre-trained models. Therefore, our research objective does not involve any post-processing or two-stage operations to make the retrieval metrics look better.
If you feel that there are more issues worth exploring, downloading the dataset and code to conduct your experiments is a good option. Please feel free to contact me promptly if there are any bugs in this code repository that I have overlooked.
Best wishes.

Thanks for the detailed and precise explanation and additional experiments!


SSH access to containers

Tell us about your request. If your feature request is related to a problem, please describe.
Allow access to running containers via SSH
i.e. mount a rails console
Describe the solution you'd like
I want to be able to open a shell into any of the containers in my uffizzi environment and run commands.
Describe alternatives you've considered
None available
Additional context
This is useful for troubleshooting


Bug: Does not work on tiktok videos something went wrong

It will not work on tiktok videos at all says something went wrong try to refresh page. The problem is that it detects no video so I can't even exclude tiktok from Better Volume Booster meaning the extension is useless right now as I can't keep it enabled. Can we please either have a quick toggle for enabling or an easier method to exclude?

Hi, do the steps here (issue #10) fix your problem?

Thanks that took care of the problem you may want to change that to be the default value.

Thanks that took care of the problem you may want to change that to be the default value.


Fix issue with tab expansion of duplicate aliases.

Add Pester test for bug.  Fix #421.
Also, fix that duplicate aliases would appear in the command tab expansion list.

Added a few commits to:

Make tests less environment-specific (initially failed for me)
Use --get-all instead of --get-regexp for exact matches
Refactored alias test setup/teardown (I try to avoid try/finally in tests, but would love feedback on this change)
Tested/fixed that duplicate aliases appeared twice in the command completion list


Remove duplicate idp_cert_fingerprint assignment

When https://github.com/onelogin/ruby-saml/commit/39116258fb745a44881cdc6cab568a8fda6e36d4 was merged in, it caused a duplicate call to idp_cert_fingerprint=. This removes the duplicate call.

Hah. Didn't see #336 when I submitted this. Closing.


Deprecate things that should be deprecated in v0.12

Description
Deprecates things that should be deprecated in v0.12. GELU should be a mistake warning as there is no GELU layer in core TF.
Type of change

[ ] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[ ] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@aakashkumarnain @wenmin-wu
You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

Gelu activation is in core but not a Gelu layer. If we want to maintain the Gelu layer here ok.

Yeah I think we should keep it. Pretty minimal maintenance and others may depend on it now.


fix(ssr): renderToString cannot render comment

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fix https://github.com/nuxt/nuxt.js/issues/4458

Don't forget the test case 😄

We could have a test case that manually compiles the template with explicit comments options. A bit tedious but I think a test case is still needed.

Make sense, I’ll add one.

@yyx990803 @posva Test added.


Create dataset loader for CoVoST 2

NusaCatalogue: https://indonlp.github.io/nusa-catalogue/card.html?covost2

Dataset
covost2

Description
With the aim to foster research in massive multilingual ST and ST for low resource language pairs, we release CoVoST 2, a large-scale multilingual ST corpus covering translations from 21 languages into English and from English into 15 languages. This represents the largest open dataset available to date from total volume and language coverage perspective.

License
CC0

#self-assign


September 7 Meetup

Summary

We gotta prepare the September 7 meet-up plan & invites
Deadline
What needs to be done?

[x] Pick topics for the meet-ups
[x] Prepare agenda
[x] Send out email reminder/invites

Who can help?

@GeorgiaHCA
anyone with topic ideas!

Updates

Agenda

Announce user testing and enrolment for it
Discussion on terminology: Experience/Story (c.f. #566)
Platform updates:

@llewelld: #535
@helendduncan: #544

In terms of topic ideas:

My question regarding the wording/terminology could make a topic of discussion, cf. #566
We could chat about potential user testing approaches/open questions
@llewelld, @helendduncan & @obinnaofomah might have potential updates to ask for feedback on?

@llewelld can present the JS-based walkthrough/tutorial

@helendduncan to share progress on #544

That's great, thanks! I've updated the links etc. on the Wiki page for the meetups as well!

Done! Looking forward to the meet-up


Add cppcheck and PVS-Studio

PVS-Studio header was only added in .c files present in Userland and Kernel.

Waiting for shell to be ready to rebase branch and fix PVS-Studio and cppcheck issues

Hi! I think that the output files of cppcheck and PVS-Studio might not be commited. For example, cppout.txt.
May be it would be a great idea to add them in the gitignore to avoid pushing them

Hi! I think that the output files of cppcheck and PVS-Studio might not be commited. For example, cppout.txt. May be it would be a great idea to add them in the gitignore to avoid pushing them

My bad, i forgot to delete output files when check (Makefile action) finally worked


SplashScreen segfault when wallet cannot be loaded

Asa reported in https://github.com/bitcoin/bitcoin/issues/25146, when configured to load with a wallet that cannot be loaded, there is a segfault during the shutdown procedure.
I have been able to trace this segfault to the SplashScreen where the it appears that it is executing an interfaces::Handler that is accessing an object that has already been deleted. This seems to be related to this comment about cleaning up WalletController. Deleting m_splash at the same place appears to resolve the problem. However I am not sure if that is a viable long term fix.
Note that the segfault does not always occur for me. I believe this is due to deletion order which is not always the same. So sometimes m_splash is deleted before contexts are deleted, and sometimes after those contexts are deleted. I believe the segfault is due to accessing those contexts after deletion.

I believe the segfault is due to accessing those contexts after deletion.

I can confirm that segfault is due the context object has been deleted before the context.wallet_load_fns.erase(it); call: https://github.com/bitcoin-core/gui/blob/640eb772e55671c5dab29843cebe42ec35cb703f/src/wallet/wallet.cpp#L161-L166


RTS garage door not detected

Dear Dev team,
I don't know why but the RTS garage doors are not detected.
Thanks by advance.

Hi, support for garage door controller is not implemented. It should be implemented by someone who owns such device and can test the code.

Thanks a lot for your answer, I have some bases in code, so if you guide me a little I can work on it with pleasure.
Thanks a lot by advance.

Le 19 déc. 2021 à 14:25, jbtibor @.***> a écrit :
Closed #12.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.


Chained Entry Infinite Loop - ReadAddress Sample

There appears to be a bug that was introduced in the 2.2.0 release (version 2.1.0 works fine) that effects chained log entries.  After writing chained values, attempting to read using ReadOptions.StartAddress the second call to session.Read results in an infinite loop in Faster.cs line 602.
To reproduce the error, simply run the VersionedRead sample application after merging the bug fix that I've submitted under PR #790.  If you change project dependency to the 2.1.0 Nuget package, the issue will not occur.
See comment below for reference to line to debug...
private static void ScanStore(FasterKV<Key, Value> store, int keyValue)
{
	using var session = store.For(new Functions()).NewSession<Functions>();

	Console.WriteLine($"Sync scanning records for key {keyValue}");

	var output = default(Value);
	var input = default(Value);
	var key = new Key(keyValue);
	ReadOptions readOptions = new() { ReadFlags = ReadFlags.DisableReadCache };
	for (int lap = 9; /* tested in loop */; --lap)
	{
		//INFITE LOOP OCCURES ON THE SECOND CALL
		var status = session.Read(ref key, ref input, ref output, ref readOptions, out var recordMetadata, serialNo: maxLap + 1);

		if (status.IsPending)
		{
			session.CompletePendingWithOutputs(out var completedOutputs, wait: true);
			using (completedOutputs)
			{
				completedOutputs.Next();
				recordMetadata = completedOutputs.Current.RecordMetadata;
				status = completedOutputs.Current.Status;
			}
		}

		if (readOptions.StartAddress >= store.Log.BeginAddress)
			break;

		readOptions.StartAddress = recordMetadata.RecordInfo.PreviousAddress;
	}
}

Merged, thanks!

This commit fixes it: https://github.com/microsoft/FASTER/pull/789/commits/35019e9296dede07be0c4267e7cdc0b3c21ea934 - PR is open.


Add an auto-complete example?

İ have react-select but react-select(event.target.value) == null
Thanks for help. Have a nice day.

If possible, can you reproduce the issue inside of www.esnextb.in ?

it is here.
but react-select  doesn't work with .
i have "react-select": "^1.0.0-beta13" .

The first thing I noticed was that your <Select> component is inside a <Field> that doesn't know what kind of component that is. Have you read the documentation on custom components?

I'll close this for now, since it's a usage question and not an issue. If you encounter any bugs while trying to implement RRF into React-Select, feel free to open another issue.


Advanced sources (ex:Bytes/Tendril)

I use the Bytes type extensively in a project due to its cheap clone/owned_slice semantics.
I was wondering if there's any way/plans to achieve something like the following in the future
struct S(a: Bytes, b: Bytes)

let source = Bytes::from(b"#123#456");
let d_s = BangDeserializer::deserialize_from::<Bytes>(source);
// here a and b fields share the source Bytes buffer

I don't know of plans to achieve something like that. Would you be interested in proposing an API that would handle this case?

I can't think of an api that could support this, other than making the entire stack aware of it (which is a non-started I guess). Hard stuff.

Closing because I don't plan to pursue deep integration of bytes/tendril through the entire stack, but I would be interested to see a prototype if someone figures out a less invasive way to support this better.


Failed to execute Terraform script to deploy service when all deployment variables are null

When all deployment variables are null, the deployment task write null as value of all variables in the variable file 'variables. tfvars. json' in the workspace , the null value resulting in the execution failure of the command 'terraform plan' .

I will fix it.


simulator: delete nodes randomly

What have you changed? (required)
This PR adds a case which dynamically deletes nodes in the simulator.
What are the type of the changes (required)?

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested (required)?

Manual tests

/rebuild

/rebuild


Fixes striped theme selection color

Fixes #95

I merged this, as Travis is broken so we can not trust CI errors right now.


non descriptive getNewPopulatedEntity

@RWOverdijk
dump name. by name i'd expect it to be the same as getPopulatedEntity(data)  = make new entity and populates with data

That might be you then. It's documented, and has a different name for a reason. Naming goes well with getNewEntity().

right. i guess got confused since there is no  getEntity(data, entity). could be added for consistency
same for populateEntity(data) which could be added
on a related note. shouldn't getPopulatedEntity(data, entity) return a new entity instance no matter what?

I believe it does

  getPopulatedEntity(data, entity) {
    entity             = entity || this.getNewEntity();
//...
    return entity.setData(populatedData);
  }

that's the same entity. for a getPopulatedEntity(data,entity) i'd expect a new entity made of 'object.assign({},entity,data)`


replication feature needed

hi:
in my org,replication is very often， when new replication is needed  they must email harbor admin to add, so i think if it possible to give the privileges for project admin? it will improve  User Experience.tks

@sinycn Thanks for the request, technically is easy, but I'm really hearing quite a few different opinions on that, I don't think we can make quick update to support your request.
Leaving it open for future discussion.

#689 makes the same request

dupe of https://github.com/goharbor/harbor/issues/13538


Add extra flowtype stubs for metro

We ignore some metro flowtypes, which made flow check fail on metro-config. I now also added the metro stubs needed by metro-config to make flow check pass.
Test Plan:
flow check

Warnings

:warning:

:clipboard: Release Notes - This PR appears to be missing Release Notes.

  Generated by :no_entry_sign: dangerJS


Add endpoints to update/delete apps3buckets

What
Endpoints:

POST /apps3buckets/:id to update access level
POST /apps3buckets/:id/delete to revoke access

I also updated the template to replace the anchors with forms
(need styling from Clive).
Manually tested locally, I'll add some automated tests.
Why POST?
It's only safe to use POST and GET as form methods in the browsers.
As these requests have a side effects we need to use POST.
Why to pass redirect_to?
As this requests could be made from both the apps.detail page or the buckets.details page we need to know where to redirect the user on success.
Instead of guessing I'm being explicit and just passing this in the form (where I have this information).
Ticket
https://trello.com/c/yYFb0Tax/475-2-add-endpoint-to-update-app-access-level-to-bucket

[ ] Add tests

@axemonkey I'm going to write some automated tests for these handlers but you can start to have a look if you'd like. I don't imagine the code changing much.

It appears Clive already have classes for the buttons, superstar!! 🌟🌟🌟


After any crash, app opens on notifications activity

Steps to reproduce:

Crash the app using one of the current bugs, for instance when trying to upload
Tap "Send feedback"
Send the feedback
The app restarts... on the notifications screen

Is it intended?
The home activity would seem more natural to me, but if there is any special reason then please close this issue :-)
System logs:
12-07 19:13:21.134 20396 20396 I GoogleInputMethod: onFinishInput() : Dummy InputConnection bound                                                                                [233/93013]
12-07 19:13:21.134 20396 20396 I GoogleInputMethod: onStartInput() : Dummy InputConnection bound
12-07 19:13:21.134 20396 20396 I ShortcutsDataManager: startImportContentTask()
12-07 19:13:21.134 20396 20396 I ShortcutsDataManager: onImportAborted()
12-07 19:13:21.223 18305 18340 W UnsafeUtil: platform method missing - proto runtime falling back to safer methods: java.lang.NoSuchMethodException: copyMemory [class java.lang.Object, long, class java.lang.Object, long, long]
12-07 19:13:21.242 18305 18305 D libcrashlytics: Initializing libcrashlytics version 1.1.5
12-07 19:13:21.242 18305 18305 D libcrashlytics: Attempting to load unwinder...
12-07 19:13:21.260 18305 18305 D libcrashlytics: Done; using libunwind
12-07 19:13:21.260 18305 18305 D libcrashlytics: Attempting to register signal handler...
12-07 19:13:21.260 18305 18305 D libcrashlytics: Signal handler registered.
12-07 19:13:21.260 18305 18305 D libcrashlytics: Initializing native crash handling successful.
12-07 19:13:21.262 18305 18336 I KinesisManager: Kinesis Manager initialization successfuly completed
12-07 19:13:21.295 18305 18305 I CrashlyticsCore: Initializing Crashlytics 2.3.17.dev
12-07 19:13:21.307   786  8864 I OpenGLRenderer: Initialized EGL, version 1.4
12-07 19:13:21.307   786  8864 D OpenGLRenderer: Swap behavior 1
12-07 19:13:21.496   786  1753 I ActivityManager: Process com.android.vending (pid 17293) has died
12-07 19:13:21.496   786  1753 D ActivityManager: cleanUpApplicationRecord -- 17293
12-07 19:13:21.497   786  1796 D ConnectivityService: ConnectivityService NetworkRequestInfo binderDied(NetworkRequest [ LISTEN id=753, [ Capabilities: INTERNET&NOT_RESTRICTED&TRUSTED] ], android.os.BinderProxy@3ec09c5)
12-07 19:13:21.524   786   893 E ConnectivityService: RemoteException caught trying to send a callback msg for NetworkRequest [ LISTEN id=753, [ Capabilities: INTERNET&NOT_RESTRICTED&TRUSTED] ]
12-07 19:13:21.549 18305 18367 D NetworkSecurityConfig: Using Network Security Config from resource network_security_config_prod debugBuild: false
12-07 19:13:21.601 18305 18367 W System  : ClassLoader referenced unknown path: /system/framework/tcmclient.jar
12-07 19:13:21.667 18305 18305 I ...h.device.api.MAPInit: Initializing MAP (130050002 / MAPAndroidLib-1.1.200618.0) for app com.amazon.dee.app. MAP release version: 20180329N
12-07 19:13:21.690 18305 18396 I ...IsolatedModeSwitcher: The application is in static isolated mode
12-07 19:13:21.690 18305 18396 I ...th.device.features.b: Caching feature IsolateApplication as true
12-07 19:13:21.690 18305 18396 I ...uth.device.storage.m: Creating new DataStorageFactoryImpl
12-07 19:13:21.690 18305 18396 I ...uth.device.storage.m: Initializing new DataStorage
12-07 19:13:21.695 18305 18396 I ...h.device.attribute.a: Setting device attribute CentralAPK to false
12-07 19:13:21.696 18305 18396 I ...uth.device.storage.m: Creating and using new CentralLocalDataStorage
12-07 19:13:21.696 18305 18396 I ...uth.device.storage.r: Constructing LocalDataStorageV2
12-07 19:13:21.730 18305 18377 D ApplicationLoaders: ignored Vulkan layer search path /data/app/com.google.android.gms-2/lib/arm:/data/app/com.google.android.gms-2/base.apk!/lib/armeabi-v7a for namespace 0xb2f58090
12-07 19:13:21.754 18305 18396 I ...uth.device.storage.r: Constructing LocalDataStorageDBHelper
12-07 19:13:21.756 18305 18396 I ...uth.device.storage.r: Database map_data_storage_v2.db exists: true
12-07 19:13:21.756 18305 18396 I ...uth.device.storage.g: Constructing CentralLocalDataStorage
12-07 19:13:21.764 18305 18399 I ...h.device.framework.z: Get DataStorage instance for initialization
12-07 19:13:21.764 18305 18399 I ...h.device.framework.z: Initialize DataStorage instance
12-07 19:13:21.764 18305 18399 I ...h.device.framework.z: Setup DataStorage instance
12-07 19:13:21.826 18305 18399 I ....device.framework.ar: Trying to use default signature based package trust logic. This should be on 3P device
12-07 19:13:21.826 18305 18399 I ....device.framework.ar: Setting package trust logic as: signature based package trust logic
12-07 19:13:21.851 18305 18305 W Java7Support: Unable to load JDK7 types (annotations, java.nio.file.Path): no Java7 support added
12-07 19:13:21.856 18305 18399 I ...tity.auth.accounts.y: Returning Default multiple profile settings
12-07 19:13:21.895 18305 18305 I CommsIdentityStore: Complete CommsIdentity was not found in shared prefs.
12-07 19:13:21.896 18305 18305 I CommsIdentityStore: Complete CommsIdentity was not found in shared prefs.
12-07 19:13:21.915 18305 18305 I CommsIdentityStore: Complete CommsIdentity was not found in shared prefs.
12-07 19:13:21.915 18305 18305 I CommsIdentityStore: Complete CommsIdentity was not found in shared prefs.
12-07 19:13:21.942 18305 18305 W System  : ClassLoader referenced unknown path: /system/app/webview/lib/arm
12-07 19:13:21.943   786  1114 W GnssLocationProvider: Invalid size of GpsSvStatus found: 0.
12-07 19:13:21.945 18305 18305 D ApplicationLoaders: ignored Vulkan layer search path /system/app/webview/lib/arm:/system/app/webview/webview.apk!/lib/armeabi-v7a:/system/lib:/vendor/lib for namespace 0xb2f580d0
12-07 19:13:22.004 18305 18305 I WebViewFactory: Loading com.android.webview version 59.0.3071.92 (code 1)
12-07 19:13:22.189 18305 18305 I cr_LibraryLoader: Time to load native libraries: 5 ms (timestamps 4911-4916)
12-07 19:13:22.220 18305 18305 I chromium: [INFO:library_loader_hooks.cc(144)] Chromium logging enabled: level = 0, default verbosity = 0
12-07 19:13:22.221 18305 18305 I cr_LibraryLoader: Expected native library version number "59.0.3071.92", actual native library version number "59.0.3071.92"
12-07 19:13:22.241 18305 18305 I DefaultUserProfileManag: Listening for "oobe:profile:selected"
12-07 19:13:22.245 18305 18305 I PersistentUserIdentityS: Retrieving User: A2308YIFD5YW84
12-07 19:13:22.248 18305 18305 I CommsIdentityStore: Complete CommsIdentity was not found in shared prefs.
12-07 19:13:22.385 18305 18305 I KCommsCommsInternal: Comms#start()
12-07 19:13:22.390 18305 18305 I UserIdentity: hasActiveDevices? no
12-07 19:13:22.390 18305 18305 I CommsConversationServic: userHasDevice: no

Commons app version:
2.9.0

Seems fixed.


rp changes for porter show

Resolves #2541
What is being addressed
Reduce Resource Processor call to porter show to save time. Even for a simple bundle this call is ~5 seconds
How is this addressed

Remove redundant call made after an execution (like install). For the firewall shared service this reduces the time by 4-5 minutes.
When RP needs to access outputs it now runs a command for that alone without listing the executions. For the firewall shared service this reduces 1-2 minutes.

/test-extended

/test-extended


Unable to scope provider with @ScopeInstances with Runtime checks

This test fails with runtime checks on, not allowing you to bind providers with @ScopeInstances and @Scope...
https://github.com/stephanenicolas/toothpick/blob/faedb99203abd1ba30cc040305848ccde6c04304/toothpick-runtime/src/test/java/toothpick/AllBindingsTest.java#L237

Hi @philipbjorge , thx for the issue and sorry for the wait. We have been a little busy lately.
Regarding the issue, it is right, there is a problem with @ScopeInstances:
According to the documentation, @ScopeInstances is used together with a scope annotation for providers to determine within which scope the instances are recycled.
However, those provider cannot be bound as we don't allow to bind classes that are annotated with scope annotations. Thus, @ScopeInstances is useless...
We are fixing the issue by allowing scoped annotated targets of bindings as long as the scoped annotation is supported by the scope where the binding is defined.
For example, this will be possible only for the root scope (root scope - singleton):
@Singleton
class Y {....}
...
bind(X.class).to(Y.class);

@dlemures --
I would expect to be able to bind(X.class).to(Y.class); at any scope because Y is a singleton and accessible at any level in the scope chain. That being said, I can't really think of a valid usecase for this -- just pointing out that it is a little surpising.
I see how it will solve the @ScopeInstances issue and I think it will be a good direction for the API.

So for the following example:
// Scope tree

       Scope A
       /    \
      /      \
Scope B       Scope C

Z is a singleton
Scope B contains the binding: X -> Z
Scope C contains the binding: Y -> Z

All them inject the same instance:
@Inject Z (using Scope A) == @Inject X (using Scope B) == @Inject Y (using Scope C)
Is that what you mean?

I think that I don't see how we can implement that :)
Moreover, I think it's just not a very good practice for a scope to define bindings at a upper level, I think the semantic is far from clear. So you wanna change the singleton for the current scope and child scopes or you would like something to be changed in the application scope ? I think it's just confusing. Dagger components do that, but we use scopes to define bindings and thus from a scope changing a binding that is scoped in a different scope seems confusing to me.
And getting the same singleton for (z) in your example @dlemures seems quite impossible to me. I don't see how that could work in all cases. I am not even sure the semantic should mean this. I would really go against anything that adds complexity.

To dig a bit deeper. We jut had a good talk with Daniel about this issue and how our fix should work.
Let's say we have an app scope, and an activity scope.
In the scope we define
X --> Z, Z is @Singleton

Then, when we @Inject X, we get a singleton z0. When we @Inject Z, we get a different singleton z1.
If one wanted to have the same singleton, one would have to use the bindings:
z = new Z(..);
X --> z
Z --> z

That's the state of our current implementation, and we should not change it. It makes sense. A binding defines a "way to provide instances".
So, in the example of Daniel, we can't afford the singleton to be the same between scopes. Not only the implementation would be quite tricky, but we don't even have this behavior inside a single scope itself for now ! And this seems quite far fetched.
If we would enable this, it would be a quite complex code change, just to accommodate this rare situation, which can already be achieved by simpler means (explicitly binding to the same instance).
And this rare use case would actually drive the feature that @philipbjorge requested was wondering about in the original post.
So, the easiest and most consistent change we can do is to:

allow scope annotations to be used on targets of bindings
but this scope annotation  has to be supported by the scope that install the module containing this binding. This is the more consistent, and probably the simplest behavior.
not allow the scope annotation to be supported by a parent, but only by the scope itself.

In short, the scopes of TP, when it comes to defining bindings, are not components a la dagger: they can only define things that will relate to the scope itself, not to a parent scope. This change is the simplest to enforce and the offers the simplest mental model for users I would say. It's just clearly coherent and there is no special rule to learn / remember.
We will start implementing it. We hope it's fine for you @philipbjorge . Thx again for raising this issue.
Btw, if you wanna become a contributor of TP, we can include you after a first PR getting merged in ;)

will be part of RC10


Unable to Display: How can I debug and display an Error message

I am calling the instafeed.min.js at the head, have a div with the id, and calling this script in the bottom with:

However, I'm not getting any feedback about why it is not working or displaying much.
How can I try and solve this problem? I am in my local enviroment.

It could be that you are using get: 'user' instead of get: 'tagged' while supplying a tagName. Try it either without the tagName or with get: 'tagged'

This isn't successful. I have it at the bottom before my </body>

How is it possible to debug this? I'm able to get the API codes from Instagram.

Could you post the full code you are using?

Here is the entire project file, feel free to edit within. Check out
Index.html.
https://www.dropbox.com/sh/8ttl9zgo5e3yo7v/AADpm9nrVVk7juSrPHEemSz_a?dl=0
On Fri, Feb 24, 2017 at 7:18 PM, Ryan Halliday<EMAIL_ADDRESS>wrote:

Could you post the full code you are using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stevenschobert/instafeed.js/issues/481#issuecomment-282447540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2yiZ9ZoH0fdbFigjZq-5NrBKid82g9ks5rf4GCgaJpZM4L84QG
.

Is the code you are having trouble with in index.html? If so, its missing the access token
Also in future its easier for people to help if you just post the snippet you are having problems with

I have an access token in the comments next to the script.
On Fri, Feb 24, 2017 at 7:36 PM, Ryan Halliday<EMAIL_ADDRESS>wrote:

Is the code you are having trouble with in index.html? If so, its missing
the access token
Also in future its easier for people to help if you just post the snippet
you are having problems with
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stevenschobert/instafeed.js/issues/481#issuecomment-282449120,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2yiWXRlYBrqCLLJJUwWoCDsJfvAv38ks5rf4WQgaJpZM4L84QG
.

The snippit is exactly as recomended in the readme.
basic  in the index & called the instafeed.js in head.

I ran that code and its not working because your accessToken needs scope=public_content added to the authorization request. You can read more about that here: https://www.instagram.com/developer/authorization/

Ah, I got a new accessToken then and added it to the script. However, Its not showing anything.
<script type="text/javascript">
    var feed = new Instafeed({
        get: 'tagged',
        tagName: 'awesome',
        clientId: '67ff982107e74b7e93c8de9fc77b46ea',
		accessToken: "3250741546.67ff982.cbd7092dc6e945c9917bf6fb55a979cf"
    });
    feed.run();
</script>

Hmm, this is caused by Instagram's API Sandboxing. You can read up on it here: https://www.instagram.com/developer/sandbox/
The main quote to take from there is:

let's consider an endpoint that returns a list of media: /tags/{tag-name}/media/recent. The response returned by this endpoint will contain only media with the given tag, as expected. But instead of returning media from any public Instagram user, it will return only media that belongs to your sandbox users, restricted to the last 20 for each user.

So you will need to submit your application for Permissions review in order to display a proper list of tagged posts.

I just want it to return the latest 20 posts from the developer's own
instagram. For permissions on my app, selecting the option for posting
instagram posts on my site I get:
You do not need to submit for review for this use case. If you are a
developer and you want to display Instagram content on your website, then
you do not need to submit your app for review. By using a client in sandbox
mode, you can still access the last 20 media of any sandbox user that
grants you permission.
You can find more information in the Permission Review documentation
https://www.instagram.com/developer/review/.
I just don't see how this can be worked in with their rules.
On Sat, Feb 25, 2017 at 7:06 AM, Ryan Halliday<EMAIL_ADDRESS>wrote:

Hmm, this is caused by Instagram's API Sandboxing. You can read up on it
here: https://www.instagram.com/developer/sandbox/
The main quote to take from there is:
let's consider an endpoint that returns a list of media:
/tags/{tag-name}/media/recent. The response returned by this endpoint will
contain only media with the given tag, as expected. But instead of
returning media from any public Instagram user, it will return only media
that belongs to your sandbox users, restricted to the last 20 for each user.
So you will need to submit your application for Permissions review in
order to display a proper list of tagged posts.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stevenschobert/instafeed.js/issues/481#issuecomment-282482836,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2yidHKNrK4VU2xnfhQHFh9D_LLUW5rks5rgCdqgaJpZM4L84QG
.


update GitHub actions

This should fix the warnings you mentioned, @andrewwinters5000

I don't know :shrug:


Add [Phishing] #malicious #unsafe GDGSFK…2FDVCH

Address: GDGSFKCMXJT7F6WOLZPK3ANBAOOEKM7B6EMC2R4BFP23WYFBI72FDVCH
Tags: malicious unsafe
Title: Phishing
Requested by @sysmanalex

Scam, fraud, phishing root of evil

Please continue discussion on original posting on similar types of problems. Please supply any supporting information about these most likely fradulent accounts and activities. Facts need to be supplied to enable flagging a fradulent address.
https://github.com/stellar-expert/public-directory/issues/202

here you go, it simple if you take a look
BV7BHZWV2YUCR5ZP3WU4ZAUIZWGOJ5D6PQ65DSMXIL3BM36T56DJ32S create 5CRE
GA2ZBVLAVXCU47FWJI3WHDMDCPQNXACXONZEOG2WOFCY3ZYZVSIF5CRE - both connected to fraud/scam
DJ32S created by GAQNX247GRSLCULLD3VNZA2IUB2U7HNAYAEEP37RLIVVURNHB64V5VAP -  another scam source
Fake exchange, fake token - stealing from users 970k xlm
https://realestate.indus.exchange
stellartfs.com - web scam
stellarhedgefunds.com phishing
Assets Issued by this Account
ALEXANDRIAGBV7…J32S (989 trustlines)
AVALONBAYGBV7…J32S (878 trustlines)
BEVERLYGBV7…J32S (1,930 trustlines)
BOSTONGBV7…J32S (728 trustlines)
BROOKFIELDGBV7…J32S (1,973 trustlines)
COVIVIOGBV7…J32S (680 trustlines)
CROWNCASTLEGBV7…J32S (1,395 trustlines)
DLFGBV7…J32S (573 trustlines)
EQUINIXGBV7…J32S (800 trustlines)
EQUITYGBV7…J32S (702 trustlines)
ESSEXGBV7…J32S (680 trustlines)
EXSPGBV7…J32S (600 trustlines)
INDIABULLSGBV7…J32S (679 trustlines)
MEDICALGBV7…J32S (823 trustlines)
PBSTGBV7…J32S (1,131 trustlines)
PIKGBV7…J32S (640 trustlines)
PRESTIGEGBV7…J32S (643 trustlines)
PROLOGISGBV7…J32S (1,058 trustlines)
SIMONGBV7…J32S (1,014 trustlines)
STARWOODGBV7…J32S (984 trustlines)
TOWERGBV7…J32S (1,473 trustlines)
WEYERHAEUSERGBV7…J32S (1,381 trustlines)
ANALLYGBV7…J32S (9 trustlines)
ANNALYGBV7…J32S (588 trustlines)
CAREYGBV7…J32S (546 trustlines)
CONVIVIOGBV7…J32S (15 trustlines)
COVIVOGBV7…J32S (10 trustlines)
DLRGBV7…J32S (532 trustlines)
equityGBV7…J32S (1 trustlines)
HEALTHPAKGBV7…J32S (9 trustlines)
HEALTHPEAKGBV7…J32S (563 trustlines)
KIMCOGBV7…J32S (601 trustlines)
LUNDBERGSGBV7…J32S (603 trustlines)
LUNGBERGGBV7…J32S (16 trustlines)
LUNGSBERGGBV7…J32S (7 trustlines)
OBERIOGBV7…J32S (9 trustlines)
OBEROIGBV7…J32S (588 trustlines)
PIXGBV7…J32S (10 trustlines)
PRESTIEGEGBV7…J32S (8 trustlines)
realtyGBV7…J32S (1 trustlines)
REALTYGBV7…J32S (640 trustlines)
SEGROGBV7…J32S (511 trustlines)
VENTASGBV7…J32S (546 trustlines)
VICIGBV7…J32S (510 trustlines)
VRCIGBV7…J32S (8 trustlines)
welltowerGBV7…J32S (1 trustlines)
WELLTOWERGBV7…J32S (676 trustlines)
ZHENDROGBV7…J32S (9 trustlines)
ZHENROGBV7…J32S (510 trustlines)


InvalidCastException in Xpand EnumpropertyEditor

Describe the bug
System.InvalidCastException
HResult=0x80004002
Message=No se puede convertir un objeto de tipo (Unable to convert an object of type)'DevExpress.XtraEditors.Repository.RepositoryItemCheckedComboBoxEdit' al tipo 'DevExpress.XtraEditors.Repository.RepositoryItemComboBox'.
Source=Xpand.ExpressApp.Win
StackTrace:
at Xpand.ExpressApp.Win.PropertyEditors.EnumPropertyEditor.SetupRepositoryItem(RepositoryItem item) in E:\tfs\expand\Xpand\Xpand.ExpressApp\Xpand.ExpressApp.Win\PropertyEditors\EnumPropertyEditor.cs:line 64
To Reproduce
Opening a listview with several enum columns
Expected behavior
no error

fix  included in latest nighlty and had to do with the Enum being a Flag

Still having trouble
System.InvalidCastException
HResult=0x80004002
Message=No se puede convertir un objeto de tipo 'DevExpress.XtraEditors.CheckedComboBoxEdit' al tipo 'DevExpress.XtraEditors.ComboBoxEdit'.
Source=DevExpress.ExpressApp.Win.v18.2
StackTrace:
at DevExpress.ExpressApp.Win.Editors.EnumPropertyEditor.get_Control() in DevExpress.ExpressApp\DevExpress.ExpressApp.Win\Editors\EnumPropertyEditor.cs:line 71

I do not see how to repro the case, in my tests I marked StatusColor in SystemTester as Flag and I tested with success.

Can you provide sample or instructions.

I think this issue is related to the IsDelayedDetailViewDataLoadingEnabled
Attached solution used
Enumtest.zip
and the repro steps (may vary...)

some time the exception happens in other situations (the same call stack)

@apobekiaris

eXpand.lab Installer 18.2.703.2 includes commit EnumPropertyEditor throws when flags are used #344 that relate to this task. Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.
. Thanks a lot for your contribution.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Add support for command EXPIREAT

Add support for the EXPIREAT command in DiceDB similar to the EXPIREAT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

I want to complete this task

I want to complete this task

Assigned

I have a question, that is, after setting the expiration time, do I need to scan it regularly, or do I have to judge it when it is available?
I found this problem when I was testing just now.

I have a question, that is, after setting the expiration time, do I need to scan it regularly, or do I have to judge it when it is available? I found this problem when I was testing just now.

We automatically perform expiry both as a part of the main loop, as well as during GET operations.

Okok, that's good, that means that this function is perfect at present, right? Then I'll test it again

hi @arpitbbhayani  @JyotinderSingh I would like to work on this issue.

hi @arpitbbhayani  @JyotinderSingh I would like to work on this issue.
@JyotinderSingh  would you please assign this task to me.

Assigned


ConversationSummaryBufferMemory doesn't flush the memory at maxTokenLimit

I'm using ConversationSummaryBufferMemory, with maxTokens let's say 40, but It doesn't flush the conversation at '40 tokens' like is supposed, so It ends up getting the 'max_lenght err'.
I was wondering if I was doing something wrong, but after trying in python it worked well. So maybe It's a bug?, Someone have the same problem?
In other hand, in the js documentation I don't see the ConversationTokenBuffer like in Python, so maybe It's related ...

Hey @juandavidGF could you reply with the error message you're getting and a code snippet on how you're initializing the ConversationSummaryBufferMemory class?

Seeing this same issue trying to use ConversationSummaryBufferMemory with UpstashRedisChatMessageHistory + ConversationChain.
Error from OpenAI:
400 This model's maximum context length is 8192 tokens. However, your messages resulted in 8265 tokens. Please reduce the length of the messages.

Code sample:
const chatPrompt = ChatPromptTemplate.fromMessages<{
  chat_history: string;
  input: string;
}>(...);

const chain = new ConversationChain({
  llm: new ChatOpenAI(...),
  memory: new ConversationTokenBufferMemory({
    maxTokenLimit: 4096,
    memoryKey: "chat_history",
    chatHistory: new UpstashRedisChatMessageHistory({
      sessionId,
      client,
    }),
    returnMessages: true,
  }),
  prompt: chatPrompt,
  outputParser: new StringOutputParser(),
});

const { response } = await chain.invoke({ input });

@Burry @bracesproul @juandavidGF I also face this problem, how did you solve it?

The issue appears to be related to the fact that

the summary buffer is only stored in memory, so it's never persisted to the redis chat message history.
when the "old" messages are shifted from the returned getMessages() array, the data in redis is not updated at all, so they stay

This seems to be more of a core issue with BaseChatMessageHistory/BaseListChatMessageHistory, which do not provide any functionality to actually remove messages when using anything other than the "in memory" memory.
The prune call merely calls .shift() on the value returned from chatHistory.getMessages(), which in case of any of the async memory providers won't do anything, but on the in-memory variant, the messages array is modified as expected...

Hi @juandavidGF! I wanted to let you know that the error you reported is no longer occurring. Thank you!

Hi @juandavidGF! I wanted to let you know that the error you reported is no longer occurring. Thank you!

While I didn't try it now (we implemented our own memory/summary class) - the issue described by me and @Burry is probably still open - I don't see any of the required changes in https://github.com/langchain-ai/langchainjs/blob/b9d86b16bd0788144f8f27cf5d18960c43da49af/langchain/src/memory/summary_buffer.ts#L144 (the .shift() will only work for an in-memory history.
Should a new issue be opened for this?


BC provider fails to load certain P12 keystores under Java 17 (pad block corrupted)

The attached example runs fine with BouncyCastle 1.69 on Java 16 and below, yet it fails on Java 17.
java17bc.zip
It is loading a PKCS#12 keystore with the following structure, according to OpenSSL:
    MAC: sha256, Iteration 100000
    MAC length: 32, salt length: 32
    PKCS7 Data
    Shrouded Keybag: PBES2, PBKDF2, AES-256-CBC, Iteration 100000, PRF hmacWithSHA256
    PKCS7 Encrypted data: PBES2, PBKDF2, AES-256-CBC, Iteration 100000, PRF hmacWithSHA256
    Certificate bag

On Java 17 the following exception is thrown:
  java.io.IOException: exception unwrapping private key - java.security.InvalidKeyException: pad block corrupted
          at org.bouncycastle.jcajce.provider.keystore.pkcs12.PKCS12KeyStoreSpi.unwrapKey(Unknown Source)
          at org.bouncycastle.jcajce.provider.keystore.pkcs12.PKCS12KeyStoreSpi.engineLoad(Unknown Source)
          at org.bouncycastle.jcajce.provider.keystore.util.AdaptingKeyStoreSpi.engineLoad(Unknown Source)
          at java.base/java.security.KeyStore.load(KeyStore.java:1473)
          at demo.java17bc.Java17Bc.main(Java17Bc.java:17)

JRE Info:
    openjdk version "17-ea" 2021-09-14
    OpenJDK Runtime Environment Zulu17+81-CA (build 17-ea+35)
    OpenJDK 64-Bit Server VM Zulu17+81-CA (build 17-ea+35, mixed mode, sharing)

Any news on this? Java 17 was officially released in the meantime.

I've got a feeling this is because the PKCS12 implementation was relying on provider precedence for getting the cipher, rather than it's helper. A similar issue was reported for the keytool but it only shows up with Java 17 as well. Now fixed.

So ist this now fixed? In bountycastle? Because we are facing the same issue and had to remove bountycastle as the KeyStore provider when opening pkcs12 files.

Try https://www.bouncycastle.org/betas 170b12 or later. Let me know how it goes.


Added previous names, nino and gender to person view

Context
Users of the support desk need gender and NINO to help identify the correct record.
Changes proposed in this pull request
Add NINO, Gender and previous name(s) to the summary list on the person view, as per the designs.
Guidance to review
CRM query changes + tests
Checklist

[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Add NINO, gender and previous names to person view


Fix header help link

Closes #1043
Code Changes

[x] remove the specific version from the help link

Steps to Confirm

[ ] run the UI locally and click the help link

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[x] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md

Description Of Changes
A truly "I'm doing my part" PR that fixes the help link in the header

@allisonking @ssangervasi I'm seeing the UI container fail when I try to spin it up with nox -s dev, getting the error message next: not found

@allisonking @ssangervasi I'm seeing the UI container fail when I try to spin it up with nox -s dev, getting the error message next: not found

I believe that tends to happen when node modules aren't in the right place, or are being overwritten by a docker volume mount. Normally my node_modules get volume mounted in, so the UI doesn't have to build it, but if I don't have them locally, then https://github.com/ethyca/fides/blob/main/clients/ctl/admin-ui/package.json#L6 should cover it. But if your file system isn't quite in the expected format (i.e. if it's clients/admin-ui instead of clients/ctl/admin-ui) then the command won't really work properly. Cole ran into this a few weeks ago and it was because he hadn't pulled main since nesting everything under ctl. that's probably not your problem, but maybe something with unified fides has your directory setup a lil different than expected?


Remove Min/Max references from AggregateExec::get_minmax_descr

Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/11151 (where we are removing special case uses of Min/Max)
Describe the solution you'd like
Remove the code here:
https://github.com/apache/datafusion/blob/f58df32753a06dd1b67597a12cdf68007e249338/datafusion/physical-plan/src/aggregates/mod.rs#L485-L494
Specifically, the idea is to remove the pattern
       expr.as_any().downcast_ref::<Max>()

and
       expr.as_any().downcast_ref::<Min>()

Describe alternatives you've considered
Perhaps we can add function like this to AggregteExpr and implement it for Min and Max:
impl AggregateExpr {
    /// If this function is max, return (output_field, true)
    /// if the function is min, return (output_field, false)
    /// otherwise return None (the default)
    ///
    /// output_field is the name of the column produced by this aggregate
    ///
    /// Note: this is used to use special aggregate implementations in certain conditions
    pub fn get_min_max(&self) -> Option<(Field, bool)> { None }
...
}

Additional context
No response

take


Watchable head

I want to watch the head and get the field if it changes.
could you expose the reactive getTags or emit some events on adding/removing tag and values change?
Thanks.

Hey @shtse8
Within the v1 RC's, you have access to hooks that let you modify resolved tags before the DOM / SSR is renderered.
const head = createHead()

head.hooks['resolved:tags'].push((tags) => {
   // do something with them
   console.log(tags)
})

You can see a live example here: https://github.com/harlan-zw/nuxt-hedge/blob/main/src/runtime/plugin.ts#L45
Will close as this should solve your issue, let me know if you have any questions or issues though.


"rtx ls-remote java" lists non available version

Describe the bug
rtx ls-remote java lists Azul Zulu OpenJDK builds which does not exists.
To Reproduce

rtx cache clean
rtx ls-remote java | grep zulu-17.46.

zulu-17.46.19
zulu-17.46.27
zulu-17.46.27_1
zulu-17.46.29

17.46.27, 17.46.27_1 and 17.46.29 does not exists - see:
https://www.azul.com/downloads/?version=java-17-lts&package=jdk&show-old-builds=true#zulu
Therefore the version upgrade fails as well:

rtx outdated java

Tool    Requested  Current        Latest
java    zulu-17    zulu-17.46.19  zulu-17.46.29

rtx upgrade java

rtx no metadata found for version zulu-17.46.29
rtx Run with RTX_DEBUG=1 for more information

Expected behavior
Only available versions should be listed with ls-remote.
rtx doctor output
rtx version:
  2023.12.28 macos-arm64 (2023-12-15)

build:
  Target: aarch64-apple-darwin
  Features: DEFAULT, NATIVE_TLS
  Built: Fri, 15 Dec 2023 05:30:05 +0000
  Rust Version: rustc 1.74.0 (79e9716c9 2023-11-13) (Homebrew)
  Profile: release

shell:
  /bin/zsh
  zsh 5.9 (x86_64-apple-darwin23.0)

rtx data directory:
  /Users/.../.local/share/rtx

rtx environment variables:
  RTX_SHELL=zsh
  RTX_DEBUG=0

settings:
  {
    "experimental": true,
    "color": true,
    "always_keep_download": false,
    "always_keep_install": false,
    "legacy_version_file": true,
    "legacy_version_file_disable_tools": [],
    "plugin_autoupdate_last_check_duration": "7d",
    "trusted_config_paths": [],
    "verbose": false,
    "quiet": false,
    "asdf_compat": false,
    "jobs": 4,
    "shorthands_file": null,
    "disable_default_shorthands": false,
    "disable_tools": [],
    "raw": false,
    "yes": false
  }

config files:
  /Users/.../.config/rtx/config.toml

plugins:
  bun            (core)
  bundler        https://github.com/jonathanmorley/asdf-bundler.git#a461ac4
  cocoapods      https://github.com/ronnnnn/asdf-cocoapods.git#d45de04
  deno           (core)
  doctl          https://github.com/maristgeek/asdf-doctl.git#9344c6c
  doctoolchain   https://github.com/joschi/asdf-doctoolchain#d1f0169
  erlang         (core)
  git            https://gitlab.com/jcaigitlab/asdf-git.git#0bfd42e
  go             (core)
  helm           https://github.com/Antiarchitect/asdf-helm.git#a39e17b
  helmfile       https://github.com/feniix/asdf-helmfile.git#818feac
  java           (core)
  k6             https://github.com/grimoh/asdf-k6.git#8e65b77
  k9s            https://github.com/looztra/asdf-k9s.git#2b3af87
  kubectl        https://github.com/asdf-community/asdf-kubectl.git#cbe6df4
  kubectx        https://gitlab.com/wt0f/asdf-kubectx.git#8c0b4aa
  maven          https://github.com/halcyon/asdf-maven.git#625d6e5
  node           (core)
  python         (core)
  ruby           (core)
  starship       https://github.com/grimoh/asdf-starship.git#f546452

toolset:
  starship@latest, node@lts, <EMAIL_ADDRESS>python@miniconda3-latest, kubectl@latest, kubectx@latest, java@zulu-17, k6@latest, k9s@latest, helm@latest, helmfile@latest, doctl@latest, doctoolchain@latest

No problems found

Additional context
It could well be that this is not related to rtx but the metadata repository.
How can I create a bugreport/pull-request there?

looks like this is the issue: https://github.com/joschi/java-metadata/blob/31243ba88296e68897cfbf194c077a3c088c64b6/docs/metadata/ga/linux/i686/jdk/hotspot/zulu.json#L3950

Hi @jdx,
thanks for the quick feedback!
I guess you're on the right track. However, I believe the following entries are causing the issue:

17.46.27
17.46.27_1
17.46.29

I guess I should create a ticket in the https://github.com/joschi/java-metadata/ repository right?

it might be because of the version host, can you try this:
export RTX_USE_VERSIONS_HOST=0
rtx cache clear

if that's it, we can probably disable it for java

what I think might be happening is the set of versions for java are not the same across OS/arch. The asset host figures out what the java versions are and puts them here for rtx to use like a cache: https://github.com/jdx/rtx-versions/blob/main/docs/java

export RTX_USE_VERSIONS_HOST=0 solved the issue 🥳  Many thanks!
❯ export RTX_USE_VERSIONS_HOST=0

~
❯ rtx cache clear
rtx cache cleared

~
❯ rtx outdated java
[INFO] All tools are up to date

~
❯ rtx upgrade java
[INFO] All tools are up to date

Would it be possible for rtx-versions to considered OS & arch?

Would it be possible for rtx-versions to considered OS & arch?

possibly, but I think this might be specific to java. With java it already uses the metadata service so it's not a huge performance boost to use rtx-versions with that language. It's more helpful for projects that use the github api as that is often rate limited on shared hardware.

once I get some time to look at this I think we could maybe use rtx-versions for "quick" lookups  but when installing it could fetch the larger java metadata file and then use that as the source of truth. Something along those lines.
The thing about the java metadata is that it's really large. 4.7mb vs 65kb for the versions metadata.

another idea is maybe I can modify the java metadata (I did fork it for this reason) and add smaller files that only contain the data I need, maybe even using messagepack to pack it down further

Many thanks for the quick feedback! Kudos for this awesome tool 👏🏼


Maintainer need for approval of 2 workflows

https://github.com/solana-labs/token-list/pull/4159
I need 2 workflows approved please asap!

Can someone help me please?

no

Why not?

On 17 Nov 2021, at 08:30, Samoboyz @.***> wrote:

no
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

OK I will. Give me 3 months.

3 months?

On 17 Nov 2021, at 09:06, Samoboyz @.***> wrote:

OK I will. Give me 3 months.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Yes, unless you want to pay the fast track fee.

Some bs bro, your a samo dog holder

On 17 Nov 2021, at 10:08, Samoboyz @.***> wrote:

Yes, unless you want to pay the fast track fee.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Please read the SPL-token README, and ensure your SPL-token info uses the correct Uniswap format.

I am not sure what this means, I just need approval.

On 17 Nov 2021, at 11:50, SolDev @.***> wrote:

Please read the SPL-token README, and ensure your SPL-token info uses the correct Uniswap format.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Follow the instructions in the README and it will be approved.

Ok thank you Sir, I appreciate you replying

On 17 Nov 2021, at 12:27, SolDev @.***> wrote:

Follow the instructions in the README and it will be approved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

My token follows the uni swap format

On 17 Nov 2021, at 11:50, SolDev @.***> wrote:
Please read the SPL-token README https://github.com/SolDev-stack/token-list/blob/main/README.md, and ensure your SPL-token info uses the correct Uniswap format https://github.com/SolDev-stack/token-lists/blob/main/README.md.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/solana-labs/token-list/issues/4287#issuecomment-971505991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWO5U3PAIEBCVTCX5KTBSLLUMOJJFANCNFSM5ICOM7NA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

i think logoURI is a required field

You dont need logourl

closing due to inactivity, please reopen if still an issue


Add CLI option to disable the security certificate check in Python requests

safety version: 1.9.0
Python version: Python 3.8.2
Operating System: Windows 10

Description
I have proxy server which breaks ssl sertificates. So I can't get database though fetch_database_url(). now I manualy change line:
r = requests.get(url=url, timeout=REQUEST_TIMEOUT, headers=headers, proxies=proxy)

to
r = requests.get(url=url, timeout=REQUEST_TIMEOUT, headers=headers, proxies=proxy, verify=False)

Can you add cli option to ignore SSL certficate like https://stackoverflow.com/questions/15445981/how-do-i-disable-the-security-certificate-check-in-python-requests

This x1000. For all corporate coding work.

Until this enhancement is done (or if you do not want to disable ssl verification), this may help some users get safety running in these types of environments.
The root issue appears to be that the requests library doesn't look at system based ca-certs. Instead it looks at certifi certs
A temporary fix to work around the invalid certifi cert is by overwriting it with a valid cert.
For instance on Ubuntu this bash script works, at least until certifi updates and overwrites it:
#!/bin/bash

#Determine the location of the certifi cert in our python env
python_certs=$(echo "from requests.utils import DEFAULT_CA_BUNDLE_PATH;print(DEFAULT_CA_BUNDLE_PATH)" | python3)
#example: /home/someUser/tmpvenv/lib/python3.6/site-packages/certifi/cacert.pem

#Assuming you have installed the custom CA cert on the system, otherwise point it to the correct  CA cert
ubuntu_certs="/etc/ssl/certs/ca-certificates.crt"

echo "Removing python certs at $python_certs"
rm $python_certs

echo "Relinking to $ubuntu_certs"
ln -s $ubuntu_certs $python_certs

A less risky way to accomplish the same goal would be to honor the REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE environmental variables, which is what tools like pip and libraries like requests use:
https://pip.pypa.io/en/stable/topics/https-certificates/#using-a-specific-certificate-store


escape key not work with modal,except i add tabindex="-1".

use Bootstrap v3.3.5.
if not use tabindex="-1",
escape key not work,but enter is ok to close modal in chrome.
both escape and enter is not work in firefox.

Yes, you need to include the tabindex attribute. That's why all the modal examples in our docs use it.

if not use tabindex= "-1", modal can't get focus, so can't handle keydown event.
https://api.jquery.com/focus/
The focus event is sent to an element when it gains focus. This event is implicitly applicable to a limited set of elements, such as form elements (, , etc.) and links (). In recent browser versions, the event can be extended to include all element types by explicitly setting the element's tabindex property.

You must use tabindex= "-1". It is not optional.

您必须包括 tabindex="-1" 。包括它是强制性的。这是不可选的。
（使用谷歌翻译翻译）


.Net Bug: AzureChatExtensionsOptions for Azure AI Search is generating incorrect search queries.

Describe the bug
The AzureChatExtensionsOptions for Azure AI Search is generating incorrect search queries. When passing a simple query like "list plans," the extension alters it to "list azure plans," "azure subscription plans," etc., rather than passing the original or minimally altered query to Azure AI Search. This leads to inaccurate search results. The expected behaviour is that the query should remain close to the user's input, such as "plans" or "list plans."
Also, I'm not passing anything to the RoleInformation field.
Expected behavior
The query generated by AzureChatExtensionsOptions should closely reflect the user's input, without adding unnecessary terms like "azure" or "subscription." For example, if the input is "list plans," the output should be "list plans" or simply "plans."
Platform

AI Model: Azure OpenAI  GPT4o
OS: Windows
IDE: Visual Studio
Language: C#
Source: NuGet package version 1.17.1

Hi @Cobra86 , I'm not sure if the issue is on Semantic Kernel side, because we are not modifying user input. Could you please include some code snippet, which will allow to reproduce the issue? Thanks in advance!

Hi @Cobra86 , I'm not sure if the issue is on Semantic Kernel side, because we are not modifying user input. Could you please include some code snippet, which will allow to reproduce the issue? Thanks in advance!

Sorry, I made a lot of changes since the new update, so i cant replicate or share the code.
I didn't modify anything also I can see it in Intent field, It was set to list azure plan, or something relate to azure.

With the new update 21, it isn't passing modified query because now it's not returning anything when i typed list plans.
I didn't update the index. i can confirm before when i type list plans it was returning some info.


Tree view cell

Hello. In the release notes for version 6, it is mentioned that a basic implementation of the tree view cell has been added. Could you provide an example of usage?

You can find a very basic example in the storybook here. The tree cell is part of the custom cells package and it does not yet have a good documentation. But you can find the available props here.


Paper Writing: Methods -  The Open-source Effort [in need of review]

@imenelydiaker already did good work here. I added a few additional things.
@imenelydiaker do you mind taking a look at this again?

I can help with review and also added a few changes, but here are some general comments.

Some sentences read difficult (I recomend using Hemingway app to check for clarify), see my rewrite of the first sentence.
"Datasets Quality Assurance" should that be really part of this section? Apart from "asking contributors to fill in metadata fields" fragment there's little relevance to the healine above.
I know that point-based system is detailed in sec:contributions appendix, but this sounds like important enough to move it, or at least briefly outline in the main section of the paper.
“near-perfect scores” what does it mean? Should we specify threshold?
I'm afraid that description of collecting metadata fields for dataset may not be clear for someone who has never done it, maybe we should consider providing a brief example of the metadata field as listing or figure?

And the overall goal of this section is a bit unclear to me. A lot of things are mentioned superficially, or referred to only in appendix. How detailed we want it to be? Another question is whether entire "Methods" should really be before "Related Work" as we draw some inspiration from earlier community driven initiatives that are discussed there, so it could read more easily building upon that.

I can help with review and also added a few changes, but here are some general comments.

Would be lovely!

Some sentences read difficult (I recomend using Hemingway app to check for clarify), see my rewrite of the first sentence.

I agree. We should probably do this at the end though. Focus on the main narrative points to start with

"Datasets Quality Assurance" should that be really part of this section? Apart from "asking contributors to fill in metadata fields" fragment there's little relevance to the healine above.

I believe it is related to the open-source effort. Do you have another suggestion on where to put it

I know that point-based system is detailed in sec:contributions appendix, but this sounds like important enough to move it, or at least briefly outline in the main section of the paper.

I would welcome a rewrite if you have a good one - One thing I am afraid of is reviewers getting too caught up on the specifics of a non-perfect point system (we know it is - it can't be perfect).

“near-perfect scores” what does it mean? Should we specify threshold?

We can probably be more clear I agree. However near perfect scores vary from metric to metric though I think most people would understand it as a score close to the maximum of what would be possible for the task (often close to 1). Again a reformulation is very welcome

I'm afraid that description of collecting metadata fields for dataset may not be clear for someone who has never done it, maybe we should consider providing a brief example of the metadata field as listing or figure?

Again def. welcome to suggest a rewrite here

Okay, I gave it another pass, you may have a look. I decided to split Open source efforts and Quality Assurance. Still tempted by moving "Related Work" before "Methods" but as this is a substantial change, decided to leave it right now for later discussion.

I started reviewing the method section, did the first half of it, plan to do the 2nd part this week

Thanks for these suggestion @mariyahendriksen - I have read through the suggestions and applied them.
It should be noted that the benchmark section is stilll a work in progress. I have just started working on that today (though we are still waiting on a few datasets). I can ping you here once the section is in a reasonable state.

@mariyahendriksen I believe this section (on the open-source effort) is done. Would love a pair of eyes on the second part of the method section

sounds good, will take a look!

@KennethEnevoldsen restructured the 2nd part of the methods section!
fyi I also went over the abstract, the introduction and the appendices a couple of times
let me know if there are any urgent tasks that require attention!

Thanks @mariyahendriksen! Will look it over tomorrow


Create an example file showing how to stream data from and to a blob.

This file contains an example of how to stream data from and to a blob. There are no docs and there are no examples on how to do this, and it can be quite confusing; it's a consequential thing to know, so thought I would help get that started.
If any maintainer wishes to make changes, please go ahead and make them.

Hey @ali-elgabri I have created a PR here https://github.com/Azure/azure-sdk-for-python/pull/17435
Let me know what you think.

Given it is added in #17435, close the PR.


Color-vision impairment, icon clarity

Issue
User report of issues distinguishing between PR states: open and closed; because of color indistinguishability, and non-distinct symbol shapes for open vs closed.
Comments on a thread.

I'm red-green colorblind but the only way it noticeably affects my life these days is with the icons on Github's notifications page. A merged PR an an open PR have different shapes and the merged PR is blue and the open PR is green --- very easy to distinguish.
But an open PR and a closed PR have identical shapes and are only distinguished by the open PR being green and the closed PR being red. Or so I'm told anyway, because I cannot for the life of me distinguish between the two. I end up needing to just open the link to the PR to check its status.

The closed PR icon has a tiny little tickmark in the icon I believe.
I had never realized they had different colors btw, and always wondered why GitHub wouldn't give them different colors. Thanks for clarifying that they actually did, just badly.
Tip for anyone using red and green for statuses: do like traffic lights: make the green a whiteish, blueish green and make the red tend a bit towards orange. And for the love of god use wildly different icon shapes!

Diagnosis / Checks
Color blindness web viewer, during development. Like Toptal or WebAIM.
Automated tests for color distinguishability? If it's worth the effort.
Checklist item in design system to ensure broad ease of use concerns. (e.g. here, symbol & color differences for icon-represented states.)

Note, I mistakenly issued this issue elsewhere first, because I didn't know where to issue it, nor where to find out where to issue it. Is this the right place?

Hi @mcint I think this could be more related to https://github.com/primer/css or https://github.com/primer/octicons :)


RRSIG name was not being checked

The RRSIG's header name specify the signer of this signature record. For the leaf query, it should be equal to the FQDN of the querying domain name. e.g. If I query for A records for example.com, I should get back an RRSIG with header name example.com.. Then I follow the auth chain of that name to verify the chain of trust.
However, this library didn't check the equality between the return RRSIG header name, and is using it directly for checking the chain of trust. This means, an attacker can forge RRSIG for any domain by owning a valid domain name. e.g. when a victim query for A records for example.com, an attacker who owns pwn.com can generate a signature for a fake RR response set using its valid DNSKEY, and attach the RRSIG with header name of pwn.com and send it back to the victim. Because this library takes the RRSIG header name without any checks, it query for DNSKEY for pwn.com and use that key to verify the RR set that should answer the query for example.com, and the check would pass.

The RRSIG header name check is done in other DNSSEC libraries. e.g. sdns: https://github.com/semihalev/sdns/blob/3caf4c38f38c9317d241ffc386621f7f47ff6227/middleware/resolver/resolver.go#L1187

The Go Vulnerability database has designated the lack of RRSIG header name validation GO-2022-0979 and CVE-2022-3346, and the lack of root certificate validation GO-2022-1026 and CVE-2022-3347. To add a fixed version or otherwise update these reports, you can reopen and comment on https://github.com/golang/vulndb/issues/979 or https://github.com/golang/vulndb/issues/1026.


health: add hrm info to readme

reference:

The health app on the Bangle only stores data every 10 minutes. The '3 minute' option is for the heart rate - it'll take 3 HRM samples every 10 minute slot and use the best/average value of HRM readings - but it only stores one reading per 10 minutes.

https://forum.espruino.com/conversations/386312/#comment16972306

Nice, thanks for the tweak


[feature request] Please obfuscate/encrypt Passwords in Config Files/Database

Please implement a way to obfuscate the passwords in the config files.
Current Behavior
The Passwords for MYSQL is stored in the /data/gogs/conf/app.ini and the Auth LDAP Connection Password is stored in the MYSQL Database in plain text.
Desired Behavior
The Password is symmetrically encrypted (e.g. AES) with a key store in Gogs Source Code. That will just obfuscating the password for Gogs experts. But for any other person it will hide the password effectively.
The Password in the app.ini could have a semaphore, so that Gogs will encrypt the password if it finds an unencrypted one.

This is security by obscurity, though, making you think that your password is secure while it's trivially readable by anyone with a small program...

@skorokithakis Yes it is, but it's better than having a plain text password in a text file with the label password right before and the user name right above it.

Nope it is not because it gives the normal user a feeling of security while it's trivial to decrypt for people who know what they are doing anyways.

Hi, thanks for the feedback!
However, if someone is targeting your Gogs instance for your MySQL password, the person already has the file system access and can easily get whatever key that is stored and used to encrypt/decrypt. And because Gogs is open source, everyone is potentially knowing what is the algorithm to encrypt/decrypt.
So... I suggest you fork and modify the corresponding source code to achieve the goal in OP.


Support for hosts other than localhost

I like to run grunt inside a vagrant instance and I usually add a host file entry to the box, so I'd hit something like dev.awesomeproject.com.  It would be awesome if the extension used the current tab's host rather than default to localhost.

Default vagrant goes to locahost, unless you change it. The main problem is the port
config.vm.network "forwarded_port", guest: 61750, host: 61750 adding that (if nothing else is using that port) will allow you to use it with vagrant.
You can add
config.vm.network "forwarded_port", guest: 61751, host: 61751
to support multiple projects as well, I am sure vagrant can also do port ranges, but just never had a reason to use it yet.


Update .travis.yml

Test against node_js version 0.12

Ive just signed it.

It would be better if node 4.1 is included.
Also: we need to run the browserstack check only on one of them, and that's the case to use in node 4.1.

If we do 4 it will automatically go for the latest stable 4.x release available.

Without handling the browsertack runner to run on a single node environment, I can't move this on. Otherwise each CI run will overload browserstack.

How would I get browserstack to check only 4.1 or 4.2.

@paladox Honestly I don't know a better way, which probably exists. Maybe checking if the current version (node -v or process.versions.node) is not 0.10 or 0.12.

also, it would be great if you apple the style guidelines on the commits

We need this PR to get in shape before a next review. I'll close it for now and we can reopen it when if it gets ready again.

A version of this PR that runs the browserstack task only in one Node.js version: #997.


Remove github-api-cache-duration flag and code

This removes the flag and code for the legacy GitHub API cache. We already migrated to fully use the new HTTP cache based API cache functionality which had been added via #1127 and available since ARC 0.22.0. Since then, the legacy one had been no-op and therefore removing it is safe.
Ref #1412

Thanks for reviewing ☺