Clarify meaning/utility of fluid:telemetry:ChannelDisposeError

There are a lot of errors in telemetry, with two main error reason being

Registry does not contain entry for the package
No registry for package

But when I look at individual sessions, all of these errors show up after container is closed.
So it seems like something else fails when container is closed and it propagates to this error, which most likely is not worth raising awareness about.
It would be great to understand if this claim is correct and if we want to reclassify it as not an error or maybe remove event altogether.
It would be also great to standard property set (or maybe only to error set) containerClosed: this.closed property:
                all: {
                    clientType, // Differentiating summarizer container from main container
                    loaderVersion: pkgVersion,
                    containerId: uuid(),
                    docId: () => this.id,
                    containerAttachState: () => this._attachState,
                    containerLoaded: () => this.loaded,
                },

#7919

It also feels like we want to report channel loading errors up the stack, i.e. in bindRuntime() & realize() should log an error if we failed to load data store, but probably only if it happened before container closed?

#8065

@vladsud what's the follow-up here once 0.51 gets out there? I have these questions to ask of the data:

Are these new errors happening after close? We can check the containerLifecycleState property to see
If not, then what happens next? Who's awaiting channelDeferred.promise and gets the rejection?

I think analysis of the current error event says that these are happening after close - or at least, no one else is awaiting the context realize before then.  I did see that processAttachMessage doesn't catch after this promise, I wonder if we want a log there too?

Opened https://github.com/microsoft/FluidFramework/issues/8667 to get eyes on what should happen when prefetch of DS at the end of processAttachMessage fails.
As for other follow-up, I think it's just a matter of going through top errors.  These are on there, but not at the top.  container lifecycle state is loaded when this new ResolveFailed event fires.


Add apis client

added api client configs for pilot partners
When a pilot partner requests access to the DMPHub API, we need to create one of these sceptre configs. Eventually, once the new system has been built, we will allow this to happen through the UI and then automate the creation of these.

Added sceptre config and templates to add pilot partners to Cognito so that they can access the API


Reduce the number of github requests in the backport bot

Do a quick assessment of the input before doing any API calls.
Tested some inputs offline:
$text = "@vsmacbot backport release-17.0/devel"

if ($text -match "@(?<botName>.+) backport (?<branchName>.+)") {
 $Matches
}

Name                           Value
----                           -----
botName                        vsmacbot
branchName                     release-17.0/devel
0                              @vsmacbot backport release-17.0/devel

@cadsit @mjbond-msft ping?

@cadsit how do I test this commit?

It seems that this isn't the backport action that's used in the vsmac repo.


Just cleans up the view

just pulls in the standard header and back arrow so that the X series header doesn't break the while thing

yeah, we should just go with it. handles the header in the more standard way now too


Fix label marshalling; small improvement to test script.

I don't know why the boilerplate CL is appearing here...


Initial Temporal code in Golang

We are merging this code to main a little earlier to provide meaningfull structure to main and enable the developement of other modules (Sampler and Manager) in parallel to the Requester


Add portage support for Gentoo Linux

Closes: https://github.com/anchore/syft/issues/998
Signed-off-by: Zac Medico<EMAIL_ADDRESS>

👋 Thanks @zmedico for the PR here. I'm looking at this now. Do you mind if I add some commits to the branch to get the different CI checks passing?
I really appreciate you updating the branch recently. Apologies for merging in other PR which might have broken yours.

wave Thanks @zmedico for the PR here. I'm looking at this now. Do you mind if I add some commits to the branch to get the different CI checks passing?

Yes, please do.

I really appreciate you updating the branch recently. Apologies for merging in other PR which might have broken yours.

No problem.

I'll update the CLI tests here too


Containers being removed each restart

Info:

Docker version (17.09.0-ce-win33 (13620)):
System info ( PC ):
System info disto/version:

Issue:
Every time I restart my PC, docker itself doesn't start correctly - it throws some errors, but that is not the problem.  Usually I just exit it, restart it and it runs fine.  At that point I have to restart the laradock containers, which has been also fine.
However just the last couple of days it seems that every restart with the above workflow is actually removing the containers such that my mysql container is lost and I have to rebuild. Pain!

Expected behavior:
Containers should not be removed.

Reproduce:
Not sure.
Really I just need to know why this might happen - is anyone else seeing it, and should I be raising issue with Docker itself or is it Laradock issue that would be removing containers ? As I said, while not ideal, the docker crash previously would at least not delete the containers so not a big deal really.  Obviously, losing my DB IS.

Relevant Code:

Do you use ./sync.sh down ? this command do docker-compose down and this delete all containers.

no i'm not doing anything down myself - its simply in the process of rebooting windows

I have the same problem.

+1


[NOT A BUG] Removed ioquake manifest?

Hello dear collegues,
some months ago (on November) I created a PR adding the ioquake (opensource quake 3 engine) manifest. The PR was eventually merged. (for reference  PR #5023)
Today I was trying to install ioquake on one of my machines, and I noticed that is was missing from winget.
I see that there were a manifest schema upgrade recently, is this the cause? If so, can I resubmit the manifest?
Thanks a lot,
Luca

@Luca1991 I don't believe that is the cause, but I don't see the package either. Be sure to use the new schema when you submit the manifest.

https://github.com/microsoft/winget-pkgs/pull/6167 removed the manifest because https://ioquake3.org/files/1.36/installer/ioquake3-1.36-3.1.x86.exe does not work anymore..

Just checked their download links and clicked around on the page, stuff seems to be broken and unmaintained for almost 4 months?..

Oh :( yeah, every download link is broken as far as I can see...
Well I'll wait for a fix, and then resubmit the manifest.
Thank you very much!


Cannot pass params between DrawerNavigator's children

I am using react-native and using the Drawer Navigator and I am unable to pass props to other screens. I followed the example from the docs, but still unable to resolve the issue.
My code:

const handleFixNavigator = DrawerNavigator({
Fix: {screen:FixScreen},
Handle: {screen: HandleScreen}
});
this.props.navigation.navigate('Handle', {name:'a'})

It navigate to Handle but params.name is undefined, but if i use StackNavigator instead of DrawerNavigator, it works, what happened?

^ They both should work the same but do not. I do not understand either.

There is an on going issue
https://github.com/react-community/react-navigation/issues/1072
A fix has been put in place, but waiting for it to be approved.


Model occasionally redownloaded on startup

Reported by https://twitter.com/andrekerygma in Twitter, also mentioned by @osanseviero.

Can confirm this bug. Where are models supposed to be stored, somewhere in ~/Library/Containers?

Yes, it's ~/Library/Containers/com.huggingface.Diffusers/Data/Library/Application Support/hf-diffusion-models.
(If you download the code and compile it yourself, then it will be ~/Library/Application Support/hf-diffusion-models for Debug builds).


Fix group can add operations and set completion multiple times when the group start.

Thanks for pinterest contribution to open source!
And I found a _start flag that never used, So I hope to remove it.

          1 Warning

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger

Ah! I think you've actually found a bug! I think _started should be set to YES when the group starts, otherwise it can be run multiple times!

Once the group start, the _operations = nil is executing. So it not  run multiple times. But when the group start, it still can add operations and set completion, It was a bug. I will change the code.

I'm so sorry this never got merged :( Any chance you can rebase it?


TenantInformation Callback uses wrong Loglevel Error instead of Info

cf. https://github.com/d-velop/dvelop-app-template-cs/blob/2e85ed6ecab52473eb7cd02e23e1f962a72b2c4b/Remote/Startup.cs#L191

I fixed this issue with last merge.


Update wording for TypeSpec requirement in our API Readiness apps

July is gone so we need to update the wording on the apps to:

TypeSpec usage for API definition is a mandatory requirement for all new (greenfield) data plane and management plane
services. This requirement is enforced by the ARM API Review Board for management plane services and by the API
Stewardship Board for data plane services. This requirement ensures a consistent, high-quality developer experience across
Azure that aligns with Azure SDK guidelines. For more information on TypeSpec, visit here.


JVM Memory report logs are missing

Steps to reproduce
I have used a notebook on this atoti version: <IP_ADDRESS>68.20211209112808.
Actual Result
Not more JVM Memory report logs.
Expected Result
JVM Memory report logs every 30 seconds.
Environment

atoti: <IP_ADDRESS>68.20211209112808
Python: 3.10.0
Operating System: linux

Fixed in 0.6.4 by https://github.com/activeviam/atoti/pull/3020

@bloussou That link 404s now. Can you pls guide me towards how I can view the jvm memory logs?

They are intertwined with the regular server logs that you can find in Session.logs_path. They look like this:

2024-03-12T10:22:58.095-04:00  INFO 79020 --- [activepivot-health-event-dispatcher] c.a.h.m.ILoggingHealthEventHandler       : [jvm, memory] INFO 2024-03-12T14:22:58.090Z uptime=32519ms com.activeviam.health.monitor.impl.JvmHealthCheck.createEvent:61 thread=activeviam-health-check-worker thread_id=37 event_type=JvmMemoryReport JVM Memory Usage report: G1 Young Generation[count=20 (+0), time=0s (+0)]  G1 Old Generation[count=0 (+0), time=0s (+0)]  Heap[used=28 MiB 630 KiB (30005248) (+(0)), committed=224 MiB (234881024) (+(0)), max=9 GiB<PHONE_NUMBER>) (+(0))]  Direct[used=9 MiB 762 KiB (10218304) (+(0)), count=74 (+0), max=9 GiB<PHONE_NUMBER>) (+(0))]  Threads[count=58 (+0), peak=59 (+0)]


remove cache in CI

cache is not necessary and waste a lot of machine time, so remove it

Codecov Report

Merging #184 (d7fa1b6) into master (7d84620) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   78.99%   78.99%
=======================================
  Files          60       60
  Lines       17249    17249
=======================================
  Hits        13625    13625
  Misses       3624     3624

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d84620...d7fa1b6. Read the comment docs.


Key Vault JCA Readme issue

Section Link:

Suggestion:
For 1:
Change link to https://azure.github.io/azure-sdk-for-java/keyvault.html#azure-security-keyvault-jca
For 2:
Add link for Samples https://github.com/Azure/azure-sdk-for-java/tree/azure-security-keyvault-jca_1.0.0-beta.6/sdk/keyvault/azure-security-keyvault-jca/src/samples/java/com/azure/security/keyvault/jca

Section Link:

Suggestion:
Add link for  API reference documentation https://azure.github.io/azure-sdk-for-java/keyvault.html#azure-security-keyvault-jca
@jongio, for notification

Hi @chenrujun, please take a look at this.


docker-entrypoint.sh: executable shell script test is unreliable

docker-entrypoint.sh uses a .sh file's executable mode to decide whether to source or exec the shell script. Due to a long-standing issue on Docker Desktop for macOS when VirtioFS or gRPC FUSE are used all files mounted into the container from the host are executable according to test -x even if the executable bit is not set, so this test is unreliable. As a result non-executable scripts in /docker-entrypoint-initdb.d are executed, giving a Permission denied error and the script does not run.
Although this really needs fixing in Docker Desktop, it's potentially going to lead to hard-to-diagnose issues in Postgres initialisation so I thought it at least worth reporting here for visibility. A possible workaround for the Docker issue could be to use stat and grep: something like if stat -c '%A' "$f" | grep -q '^-..x'; then ....

We had a similar issue in https://github.com/docker-library/mysql/issues/862; no great conclusion there 😞. I'd rather not introduce hacky/fragile code when test -x is the correct detection. The filesystem presenting differing values is where the fix should happen.
To work around it, you can build an image FROM postgres:[version] that copies in your sh scripts.

Yeah, I'd not be keen on adding the workaround to replace test -x either.
I went with your suggestion in our code. For those who run into this issue the changes came down to the following:

Change the docker-compose.yml file to use a built image instead of the upstream Postgres one:
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -9,7 +9,8 @@ services:
       - db

   db:
-    image: postgres:14
+    build: docker/db-container
+    # image: postgres:14
     restart: always
     ports:
       - '5434:5432'

Create a Dockerfile for the new image:
# docker/db-container/Dockerfile
FROM postgres:14

COPY ./initdb /docker-entrypoint-initdb.d

Move shell scripts into docker/db-container/initdb so their executable bits are preserved by copying in to the image. SQL scripts don't need this workaround so can still be bind-mounted into the image in the docker-compose.yml file.

I'd love to figure out where/why test -x is failing to return the correct answer, but I think that rabbit hole is out of scope here. :bow: :sweat_smile: :heart:


Negative phenotypes did not get entered for Martinotti cell

In the spreadsheet it says: GABA receptor role,Glutamate Receptor,somatostatin, lacks VIP, lacks PV
but the latter two did not get recorded in the NPO.  Please add and please check whether other negative phenotypes were missed for the CUTs.

I don't see that this has been done?

Fixed now via https://github.com/tgbugs/pyontutils/blob/ee09306ad6d68e5f8e2602ad7054b0f862733d3e/neurondm/neurondm/sheets.py#L441-L443. With visible results https://github.com/SciCrunch/NIF-Ontology/blob/5de3761d0e1bb34344f4215df5e58849fc2569cc/ttl/generated/neurons/cut-release-final.ttl#L377-L384 from the sheet.


chore: group editor acccessibility options

Updates the structure of the EditorOptions object to group all accessibility-related options under a new accessibility property.
addresses issue https://github.com/microsoft/vscode/issues/187314
@hediet

Thanks for looking into this!
Unfortunately there are some issues though:

I think there are other references that also need to be renamed. You can do a global search for the setting name.
We should try to be backwards compatible for the monaco editor so that bisect still works (it is okay to break types).

Hi!
It seems like there is only one reference to the properties you mentioned directly from the EditorOptions class. However, there are many instances of the properties being used by calling the EditorOption enum. So refactoring EditorOptions shouldn't affect EditorOption and everything related to it, but given the context of the issue, a broader refactoring may be necessary that also touches EditorOption. Does this issue address this change as well, and should I go ahead and make these changes?


How can I access bootstrap variables?

I want to access variables like $navbar-height in stylesheets.
Is there a way to import all the customized variables?
In the docs I noticed it says:

and your main Sass file that can depend on Bootstrap variables

This makes me think there is only one place I can depend on Bootstrap variables.

Hi @vjpr If you have one sass file, then so long as you defined the variable, you can see it.
By this, I mean, you need to put your sass in this config (name the file as you please). Then you can see all the bootstrap mixins, variables, etc.
  mainSass: "./main.scss", // path to your main SASS file (optional)

I have a lots of sass files and they are required individually using webpack. I just want to import the variables. Sounds like it's not possible?

Hi @vjpr, that's not the way that sass works.

It's how webpack loaders work. Each file is compiled into css. Then it is appended to the header in a style tag.
The way I am thinking is importing the bootstrap variables. Then importing the precustomization file with my modifications to the variables. Then I can access the variables.

@vjpr we're changing the way we're doing the assets parts as shown here: https://github.com/shakacode/react-webpack-rails-tutorial/
See our npm "sass-resources-loader"...
We'll have some more docs on this in the next couple of weeks.
The sass-resources loader will prepend any common definition files, which sounds like what you want!

@vjpr bootstrap-loader + sass-resources loader will solve it.

So I have switched to bootstrap-loader and sass-resources-loader.
I now have a file called variables.scss referenced in webpack.config.js in sassResources which contains:
@import './pre-customizations.scss';
@import '../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_variables.scss';
@import './customizations.scss';

This works well.

@vjpr Great, glad it helped :+1:

After looking high and low for a solution, sass-resources-loader did it. Might be worthwhile to add a note in the bootstrap-loader README. 👍

@damassi Any chance that you can give us a PR note to the README.md. @alexfedoseev and I would super appreciate it! We're slammed with our new product release.

Will do.


Feature: custom todays tasks

This feature allows the user to modify todays tasks:

add/delete task
modify task
set name, icon, progress yes/no, amount (if progress = yes)
reorder tasks

Current bugs:

[ ] ForEach can't handle dynamic values -> app crashes on delete / new tasks not shown until restart

@renaudjenny thank you for your review. I merged your space suggestions and the guard inside the delete part (maybe this will also fix a bug where the app crashed after deleting a task). I’m going to do the other code changes inside Xcode.

@TheVaan I will take a look at the problem this evening. Now it's time for me to actually play Animal Crossing :D.

LGTM

One issue left: When creating a new task pressing on save while focus is inside max amount textfield, the task is created and instant redirected to the new task view. I have no idea why this happens...


Use flit for packaging

Why use Flit? explains reasons for using flit.  Flit is faster and stricter, so it should catch packaging mistakes.
On the downside, we will lose the ability to get scm info when doing a pip list etc (currently we get something like 2.0.6rc5.dev13+g312996a for dev builds which provides more information that can be occasionally useful).  On the upside, setuptools + setuptools_scm is slower, and setuptools_scm broke our workflow (where we used devX tags) without notice.
Also bump version up to 3.0.0.dev0.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 80.954%

Totals

Change from base Build<PHONE_NUMBER>4:
0.4%

Covered Lines:
1349

Relevant Lines:
1645

💛  - Coveralls

Can't have a tag 3.0.0.dev0 because there happens to be a branch with that very name. That leads to odd effects, such as the ones you see above. Opening a new PR.

Updated PR: https://github.com/atlanticwave-sdx/datamodel/pull/146.


Update version: Microsoft.PowerToys version 0.76.0

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Hi @crutkas,
Do you approve of these changes?

Duplicate of https://github.com/microsoft/winget-pkgs/pull/129176


Admin's "View site" link doesn't work with multiple sites

In the admin interface, the "View Site" link isn't sensitive to changes to the current site.
For instance, imagine that two sites are set up under the same Mezzanine installation: a.foo.org and b.foo.org. Consider an admin logging in at a.foo.org/admin. After a while she decides to work on the sister site, b.foo.org, and uses the dropdown menu provided in the admin header to switch sites. Now the "View site" link is broken, since it still points to a.foo.org.

That's by design - the correct content is still loaded, and the correct site will still be identified (via admin user's session). It's just that the correct domain is not used, as per the admin site itself. This is to ensure all admin access is bound to the same domain as the admin site, which may be required for security.

Ah, that sounds right. Thanks for the quick answer!
There is still one thing that seems strange though, and I'm wondering whether that's by design as well, or if I'm doing something wrong. The loading of the index.html template still seems to be bound to the domain name. So in the example above, after switching from a.foo.org to b.foo.org in admin and clicking the "View site" button, you're taken to a.foo.org as expected. b.foo.org is set as the current site in the session, so the content for that site is loaded, but index.html is still fetched from a/templates/index.html instead of b/templates/index.html.

You're right, that's a bug in the host-based template loader. It looks at the domain and not the actual current site.


libtorrent-rasterbar: 1.1.6 -> 1.1.7

Also remove the default/generic split as it seems there's only one version anyway.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build libtorrent-rasterbar

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: libtorrent-rasterbar
Partial log (click to expand)
Cannot nix-instantiate `libtorrent-rasterbar' because:
error: attribute 'libtorrent-rasterbar' in selection path 'libtorrent-rasterbar' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: libtorrent-rasterbar
Partial log (click to expand)
Cannot nix-instantiate `libtorrent-rasterbar' because:
error: attribute 'libtorrent-rasterbar' in selection path 'libtorrent-rasterbar' not found

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: libtorrent-rasterbar
Partial log (click to expand)
Cannot nix-instantiate `libtorrent-rasterbar' because:
error: attribute 'libtorrent-rasterbar' in selection path 'libtorrent-rasterbar' not found

@GrahamcOfBorg build libtorrentRasterbar

Success on x86_64-linux (full log)
Attempted: libtorrentRasterbar
Partial log (click to expand)
make[1]: Leaving directory '/build/libtorrent-libtorrent-1_1_7'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7
shrinking /nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7/lib/libtorrent-rasterbar.so.9.0.0
shrinking /nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7/lib/python2.7/site-packages/libtorrent.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7/lib
patching script interpreter paths in /nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7
checking for references to /build in /nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7...
/nix/store/gx2wcv4gz3mnb6syfxj5cr801rskj1gz-libtorrent-rasterbar-1.1.7

Success on aarch64-linux (full log)
Attempted: libtorrentRasterbar
Partial log (click to expand)
make[1]: Leaving directory '/build/libtorrent-libtorrent-1_1_7'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7
shrinking /nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7/lib/python2.7/site-packages/libtorrent.so
shrinking /nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7/lib/libtorrent-rasterbar.so.9.0.0
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7/lib
patching script interpreter paths in /nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7
checking for references to /build in /nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7...
/nix/store/zwmqys0njr874za001a38lx6xnaz63q1-libtorrent-rasterbar-1.1.7

Success on x86_64-darwin (full log)
Attempted: libtorrentRasterbar
Partial log (click to expand)
make[2]: Nothing to be done for 'install-exec-am'.
 /nix/store/5lkrw9dnsgy62qm1ampvww1c5n1pdm4b-coreutils-8.29/bin/mkdir -p '/nix/store/71gnpgazw99ypqka3qrh82870cbx7lch-libtorrent-rasterbar-1.1.7/lib/pkgconfig'
 /nix/store/5lkrw9dnsgy62qm1ampvww1c5n1pdm4b-coreutils-8.29/bin/install -c -m 644 libtorrent-rasterbar.pc '/nix/store/71gnpgazw99ypqka3qrh82870cbx7lch-libtorrent-rasterbar-1.1.7/lib/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-libtorrent-rasterbar-1.1.7.drv-0/libtorrent-libtorrent-1_1_7'
make[1]: Leaving directory '/private/tmp/nix-build-libtorrent-rasterbar-1.1.7.drv-0/libtorrent-libtorrent-1_1_7'
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/71gnpgazw99ypqka3qrh82870cbx7lch-libtorrent-rasterbar-1.1.7/lib
patching script interpreter paths in /nix/store/71gnpgazw99ypqka3qrh82870cbx7lch-libtorrent-rasterbar-1.1.7
/nix/store/71gnpgazw99ypqka3qrh82870cbx7lch-libtorrent-rasterbar-1.1.7


Atalla module 2

Pull request for singular value decomposition module.
Image/Colab links have been preempted and should correctly link after being merged with main.

This looks good. I want to check if this includes feedback from @rmastand after the review.

I am merging it regardless, but please let me know if the review is complete for this module


update fuse container as root user in sidecar mode

Signed-off-by: zwwhdls<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
fix https://github.com/fluid-cloudnative/fluid/issues/2500
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@zwwhdls could you update chart version？

done

/lgtm
/approve


Any concept/idea to share with NGINX/SSL port 443?

Is there any way, or prior engineering put into sharing a port such as SSL/nginx to allow the 'secret path' to connect?

For authentication to pass thru a proxy such as NGINX, some modifications to the protocol has to be made. Currently the authentication is tied to the QUIC connection authentication, which breaks the proxy model. François has started working on this here, https://github.com/francoismichel/ssh3/pull/89, and more details are available there.
Also, this might be a duplicate of #67.

You currently can already use nginx to do multiplexing based on the server name (not the URI path parameter yet), all you need is nginx version 1.25.3 (with http3 support) and you just need to configure it to proxy QUIC connections towards your ssh3 server based on the server name you chose.
For instance, let's say you have the hostname example.org. You have nginx listening on the UDP open port 443 on your machine and you have your SSH3 server listening on port 4444. You can attribute the ssh3.example.org server name to your ssh3 server (you need the certificate for it).
If you have all that configured, you can do something like below in your nginx config and it should work:
stream {
        map $ssl_preread_server_name $name {
            ssh3.example.org   ssh3;
        }

        upstream ssh3 {
            server <IP_ADDRESS>:443;
        }

        server {
            listen      443 udp;
            proxy_pass  ssh3;
            ssl_preread on;
        }
}

And you can add other HTTP/3 services by adding other upstreams and adding them in the map.

For reverse proxies support (i.e. ones that decrypt the HTTP requests and handle stuff basd on the actual requests), we need more time for quic implementations and HTTP/3 standardisation to move forward:

quic-go currently does not support HTTP/3 datagrams, so we rely on pure quic datagrams that cannot be proxied properly
SSH3 relies on HTTP/3 Extended CONNECT and the specification does not specify ways to proxy the streams and datagrams opened by the peers. The most advanced protocol using Extended CONNECT is WebTransport and it is not standardized yet, no proxy provides support for WebTransport yet. Once it gets standardized and supported by proxies, we would like to have SSH3 adopt its semantics so that it can be proxied properly, but we will probably have to wait a few months for that. :-)

So it is coming and it will  be really nice as we'll be able to run several SSH3 connections with isolated authentication contects over the same HTTP/3 connection, but we need to wait a bit for reverse proxies.

Thanks abunch! I'll give it a shot!

Hi !
The easiest way to do that would be to rely on SNI multiplexing as it does not require implementing a terminating proxy.
Currently, nginx does not support SNI forwarding (I thought it did, but it actually doesn't).
That being said, I recently implemented SNI multiplexing on top of Caddy as a layer4 plugin.
It works, I will clean up the code and release it in the coming days (it is still experimental but already works well for domestic use case).
So if I'm not missing anything, Caddy will probably be the first Open Source server implementation that has QUIC SNI multiplexing. This means you can co-locate ssh3 and your other web servers. I'm already doing it right now. :-)
Right now, the Caddy plugin requires a fork of caddy-l4 as long as an important PR for UDP is not merged (https://github.com/mholt/caddy-l4/pull/141).

Currently, nginx does not support SNI forwarding (I thought it did, but it actually doesn't).

It actually does via the ngx_stream_ssl_preread module, which provides the $ssl_preread_server_name variable.
https://nginx.org/en/docs/stream/ngx_stream_ssl_preread_module.html

I use it to proxy HTTPS connections based on SNI. Didn't test it with ssh3, but as it's also using SNI it should work exactly the same.


Improve consistency/best practices of docker files

We put stuff in / and run as root. We probably shouldn't do either of those things if we can help it.
Make sure our sonobuoy & related dockerfiles behave and follow some conventions. Super bonus to this ticket, document our conventions.

Check the sonobuoy image and https://github.com/heptio/sonobuoy-plugin-systemd-logs/blob/master/Dockerfile
Make sure the base image makes sense and that we follow best practices in general.

I spent some time looking at our current Dockerfiles and possible changes we could make. The following is a summary of what I learned:

We are currently using two separate OS images, debian:stretch-slim for AMD64 and ubuntu:16.04 for ARM64. Looking through the PR that added ARM support, and some related issues (#609), it's not clear why these two are different. It's been questioned a few times but I couldn't find a definitive answer. I would like to try and use the same OS for both to avoid possible differences in behaviour.

Looking at whether we can move the Sonobuoy executable and scripts out of /, I think that is a move that we could make but it would require some care due to how these files are used. If we were only concerned about the images, moving the files would be safe to do. However, the CLI generates a manifest that expects the files to be in a particular location when running the images. If we move the files, that contract is broken. This would be fine in the case where the CLI version matches the image version for new manifests, however it's entirely possible that we could have users with existing manifests, or using a newer image with an older CLI version. We could find a way to transition these locations gradually over the course of a few releases, but I don't know if it's a priority at this stage.

With regard to running as root, I think this is something we should change. I'm not aware of anything within Sonobuoy requiring root permissions so running as the root user seems unnecessary.

My concern with making the above changes is that we don't have any integration testing in place, particularly with ARM. We have nothing that ensures that those builds are good. Before making significant changes that would rely on manual testing to verify, I would like to get some basic integration testing in place. Ideally something for both architectures, but at least something that could verify that any change in user or location of the files is safe. This is being worked on as part of #668.
I'm going to make some follow up issues to deal with each individual point above and will close this in favour of those issues.


[Enchancement] Revamp Features Section with Bento Grid Layout

Is your enhancement request related to a problem? Please describe.
The current Features section lacks a modern, organized layout, leading to poor visual hierarchy and user experience. The grid structure feels outdated and doesn't properly showcase the content in an engaging way.
Describe the enhancement you'd like
I would like the Features section to be redesigned using a Bento Grid layout for a cleaner and more professional look. This layout would offer better visual flow, highlight important features more effectively, and create a modern feel. The grid can be structured to have varying sizes for different content blocks to make the section visually dynamic.

Describe alternatives you've considered
I have considered:

Using a traditional grid or masonry layout, but they don't provide the same flexibility or modern look as a bento grid.
Displaying features in a list, but it would result in a less engaging presentation.

Possible Implementation Details

Implement a Bento Grid layout to restructure the Features section.

Inspirations:

Aceternity UI
Magic UI

Additional context

Add any required animations and hover effects to make interactions smoother.
Ensure that the new layout aligns with the overall visual theme of the website.

Optional Sections:

Priority: Medium
Are you willing to submit a PR for this enhancement? Yes
Does this enhancement require changes in documentation? No

Hi @suryanshsingh2001! This enhancement sounds fantastic, and I’m excited to contribute to revamping the Features section with a Bento Grid layout!
Implementation Plan:
Research: Dive into the Bento Grid layout design principles and review existing implementations for inspiration.
Design Mockups: Create initial mockups to visualize how the new layout will look, incorporating varying block sizes and dynamic arrangements.
Development: Implement the Bento Grid layout, ensuring it aligns with the overall visual theme of the site.
Animations: Add smooth animations and hover effects for an engaging user experience.
Testing: Test the new layout across different devices and screen sizes to ensure responsiveness.
I’m looking forward to bringing a modern touch to the Features section!

@suryanshsingh2001  Can you assign this to me?

@kumariAnjali10 @faresbouzayen, I have assigned you both to this issue. Please feel free to work together.

Hi @suryanshsingh2001! This enhancement sounds fantastic, and I’m excited to contribute to revamping the Features section with a Bento Grid layout!
Implementation Plan: Research: Dive into the Bento Grid layout design principles and review existing implementations for inspiration. Design Mockups: Create initial mockups to visualize how the new layout will look, incorporating varying block sizes and dynamic arrangements. Development: Implement the Bento Grid layout, ensuring it aligns with the overall visual theme of the site. Animations: Add smooth animations and hover effects for an engaging user experience. Testing: Test the new layout across different devices and screen sizes to ensure responsiveness. I’m looking forward to bringing a modern touch to the Features section!

Hey @faresbouzayen, Please proceed with this. Do check the above components for bento grid, to speed up developement process and a good design.

Can i work on the issue?

@faresbouzayen, Any updates on this?

No

@faresbouzayen Check these out. Use them to complete this issue early
https://ui.aceternity.com/components/feature-sections

@faresbouzayen Hi, were you able to work the issue?


Handle case of faulty node dropping just-received transactions

When a transaction first arrives at a node, that node might just drop the transaction, doing nothing with it. (In particular, the transaction wouldn't get written to the backlog table.)
That might happen because the server crashed after receiving the transaction (e.g. because of a thunderstorm) or because the server is compromised. A compromised server might even lie and send a response to the client saying that everything is going great.
A similar problem is if the initial node (or assigned node) says that a valid transaction is invalid, deletes it, and informs the client that it's invalid.
Implement some way(s) to mitigate this problem.
Ideas:

A client could send the transaction to one node, wait a while, and if it hasn't been told that the transaction is invalid, it could query for the transaction: if the transaction is "lost" then the client could re-send the transaction, but to a different node.
A client could just send the transaction to multiple nodes from the start (e.g. using multicast). Surely one will stick...
Push more feedback to clients on the status of their transactions; with more information, they can better reason about what they should do.
Modify the "GET tx_id" query to respond with a variety of possible "current state" messages, enabling the client to better-determine the current state of their transaction.

A client should probably send a query to multiple nodes, just in case some are faulty. (This is a common assumption in the fault tolerance literature.)

Since we are currently not aiming to provide this as a guarantee, it starts to look like a client concern (clients need to be prepared to talk to several nodes and retry if their (valid) transactions are not validated). Can we therefore close this issue?

We should document that we don't guarantee that transactions will get processed. (There are many reasons they might not get processed, including getting lost in transit.)

My comment from February 15, 2017 still holds true for BigchainDB 2.0.
I think @libscott had the right idea. It's a client concern. We should have closed this issue a long time ago, but we didn't. I'm rectifying that now. I'm closing it.


Is it possible to Read messages from Kafka topic between a range of offsets?

Feature request
Is it possible to create a routine load to read messages from Kafka topic with specific offset range.
For example I can use offsets_for_times to get the offsets for the specific time, then I can load these messages into starrocsk to do some analyze.

What does offsets_for_times stand for?
What's the real business scenarios, or do you just want to have a test about a range of data?
Currently, StarRocks doesn't support it.
But, it's not differcult to support it if it's reasonable.

offsets_for_times is an api in python sdk, Java also have a similar api called offsetsForTimes. We can use it to get offsets of a specific time, and retrieve data of that time.
2. Sometimes we don't want to retrieve all messages inside Kafka, but only parts of them based on the timestamp, that's why I need the feature.
partitions = consumer.assignment()

partition_start_timestamp = {part: start_time for part in partitions}
partition_end_timestamp = {part: end_time for part in partitions}

mapping = consumer.offsets_for_times(partition_start_timestamp)
end_offsets = consumer.offsets_for_times(partition_end_timestamp)
...


Ensure that the scroll bridge is working

Also fix the deployment script (deploy-testnet) so it deploys ScrollBridge on Eth sepolia instead of Scroll sepolia

@dragan2234 can I work on this?

Hi @dragan2234 please can I be assigned to this issue?

Hello @dragan2234 Can i take this up. Id love to work on it

@dragan2234 can I be assigned this please?


feat: Added additional fields

Let me know thoughts on these new fields - in particular the unit approach.  Thinking distance will all be the same unit same with temp.   Not sure the correct type though so left it as string.

What will we store in distance unit field? Unit type coming from api response or unit type visible to user?
For some UK users, somw distance units were coming in KM some were Miles from api response, so it might be different per sensor.
i was thinking about using setter functions and having both value and unit as input of setter function and store both of them. As i understand, HA core supports unit conversion on UI side.

I am good with that.  Yes HA can convert if we provide the unit correctly.

Still trying to validate if my assumption is correct :-)


Fix seg-fault when runnign MLfit with --plots options and no signal regions

Remove delete of dataset during iteration

isn't there a more correct way of fixing it? to me this way it seems it will leak memory in the other cases

Why should there be a memory leak? The List is deleted upon completion of
the loop in any case, I just removed the deletion of the temporary pointer
to its elements.
On Mon, Jan 12, 2015 at 2:04 PM, Giovanni Petrucciani <
<EMAIL_ADDRESS>wrote:

isn't there a more correct way of fixing it? to me this way it seems it
will leak memory in the other cases
—
Reply to this email directly or view it on GitHub
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/170#issuecomment-69566540
.

It's a list of heap-allocated pointers, and to my knowledge it doesn't own
the pointers (or at least it didn't in older versions) so deleting the list
leaks all the contents
Giovanni
On Mon, Jan 12, 2015 at 2:14 PM, nckw<EMAIL_ADDRESS>wrote:

Why should there be a memory leak? The List is deleted upon completion of
the loop in any case, I just removed the deletion of the temporary pointer
to its elements.
On Mon, Jan 12, 2015 at 2:04 PM, Giovanni Petrucciani <
<EMAIL_ADDRESS>wrote:

isn't there a more correct way of fixing it? to me this way it seems it
will leak memory in the other cases
—
Reply to this email directly or view it on GitHub
<
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/170#issuecomment-69566540>

.

—
Reply to this email directly or view it on GitHub
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/170#issuecomment-69567630
.

Ok, then as you suggest its best not to remove the delete.
After some more investigation, I find that I can also fix the seg-fault by
commenting this line.
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/development/src/utils.cc#L471
To specific card I am testing this with is from the HIG-14-021 analysis ...
https://svnweb.cern.ch/cern/wsvn/cmshcg/trunk/cadi/HIG-14-021/Combine/datacards/CombinedCards/ChargedHiggs_datacard_Combined_200_CRS.txt
Here the regions with no signal are modelled using a single binned
histogram while the signal region is a proper shape analysis.
I don't understand enough about what is happening in this function to know
why commenting either of the lines remove the seg-fault or why there is a
fault in the first place.
Any ideas?
Nick
On Mon, Jan 12, 2015 at 2:21 PM, Giovanni Petrucciani <
<EMAIL_ADDRESS>wrote:

It's a list of heap-allocated pointers, and to my knowledge it doesn't own
the pointers (or at least it didn't in older versions) so deleting the
list
leaks all the contents
Giovanni
On Mon, Jan 12, 2015 at 2:14 PM, nckw<EMAIL_ADDRESS>wrote:

Why should there be a memory leak? The List is deleted upon completion
of
the loop in any case, I just removed the deletion of the temporary
pointer
to its elements.
On Mon, Jan 12, 2015 at 2:04 PM, Giovanni Petrucciani <
<EMAIL_ADDRESS>wrote:

isn't there a more correct way of fixing it? to me this way it seems
it
will leak memory in the other cases
—
Reply to this email directly or view it on GitHub
<

https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/170#issuecomment-69566540>

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/170#issuecomment-69567630>

.

—
Reply to this email directly or view it on GitHub
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/170#issuecomment-69568307
.

Fixed in 81x


UI graph optimization

[ ] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

This PR contains following changes:
1.Width of lattice name column on dispatch list GUI.
2.Optimzing larger graphs for better performance.

@AlejandroEsquivel Please review this when you get time.
cc @santoshkumarradha @mshkanth


docker: Inherit pkgconfig

If pkgconfig is not part of the recipe sysroot then the docker
build scripts will just plough ahead and get things wrong.
Change-type: patch
Changelog-entry: Ensure docker links with systemd in pyro
Signed-off-by: Will Newton<EMAIL_ADDRESS>

@resin-jenkins retest this please


MatLab Beautifier

Incorporate beautifier for matlab and develop workflow for using it, as it definetly enhances coding velocity and readibility of code.

beautifying is done individually on each machine


Feature Request: Allow creation of factory from existing model

It would be nice to allow
rails g factory_girl:model Post --from-schema

This would read the existing Post model's attributes and generate a fixture from there instead of having to specify the attributes explicitly on the command line. The use case allows for reducing the effort a bit when moving a largish project a lot of models (with lots of attributes) to factory_girl.
Ideas? Thoughts?

This would be very helpful in generating some demo data!

Was this ever implemented?

Was this ever implemented?

Sorry to say, but no. Luckily I found a neat script can somehow automate the feature. But it will break if the table does not have a model definition. We better rescue that situation.


New iAPS Release Available: v5.2.1

Hi @jdtoppin,
The Artificial Pancreas ( iAPS ) project just released v5.2.1.
If you are receiving this message, your current code base is out of sync
with the main repository, and should be updated.
To do this, go to your Github fork, and you will notice a line that says
something like:

This branch is N commits behind ...

Click the 'Sync fork' drop down to the right of that line and choose:

Update Branch

Before building and installing a new version, please make sure to save
your settings.  Although rare, there have been releases in the past that have
forced a reset to default of the preferences.  It is rare, but better
safe then sorry.
v5.2.0 introduced a new GitHub Action to eliminate the need to manually
sync your repo with the main one, and it is highly recommended that this
is enabled.
Please see the v5.2.0 Release Notes for instructions.
If you have any questions, or issues, please let me know and I will be
happy to help.

Why are these messages being sent? I didn’t sign up for this.


chore: Update GItHub actions due to Node 12 deprecation

@TKIPisalegacycipher would you mind reviewing this? I noticed some warnings about using Node.js 12 on your actions runs. This should solve that for you.

Thanks @dylanmtaylor !


core dump on openbsd

Newsboat version (copy the output of newsboat -v or the first line of git show):
2.26 installed via openbsd pkg
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
include /usr/local/share/doc/newsboat/contrib/colorschemes/simple
browser                "qutebrowser"
show-read-feeds        no
max-items              1000
confirm-exit           yes
auto-reload            no #uses up inoreader api tokens
#reload-time            15
urls-source            "inoreader"
inoreader-app-id       "xxx"
inoreader-app-key      "xxx"
inoreader-login<EMAIL_ADDRESS>inoreader-passwordeval "pass login/news/inoreader"
inoreader-flag-share   "a"
inoreader-flag-star    "b"
inoreader-min-items    "300"
Steps to reproduce the issue:

open inoreader

hit R

Other info you think is relevant:
error message says something along the lines of
rust:string "not utf-8"
(sorry am on diff box rn, can provide logs etc if you lmk which verbosity level is needed)
on openbsd it reliably dies every time (though I assume it has something to do with current content on some feed?)
on freebsd it sometimes core dumps without an error message

I assume it has something to do with current content on some feed?

Most likely.
This is a known problem that manifests in different places, e.g. #1738 and #1547. I'll keep your report too, and once we have a fix I'll ask you to test it to make sure that we did fix all known instances of this bug.
In the meantime, your best bet is to downgrade Newsboat, most likely to a year-old version which used less Rust code. Sorry about the mess I've made here ._.

no worries, love it and love rewriting in rust, lmk if you want any logs, core dump etc <3


Add cloneable setting option

This is an evolution from the approach in #100. With this change, settings may be specified with a cloneable option, e.g.
setting :component_dirs, Configuration::ComponentDirs.new, cloneable: true

This makes it possible to provide “rich” config values that carry their own configuration interface.
In the example above, ComponentDirs could provide its own API for adding component dirs and configuring aspects of their behavior at the same time. By being passed to the setting along with cloneable: true, dry-configurable will ensure the setting's values are cloned along with the setting at all the appropriate times (see Setting#initialize_copy).
As the example here suggests, this change is in service of dry-system providing a new ”rich” component_dirs setting, providing an API like this:
# Inside a Dry::System::Container subclass
configure do |config|
  config.component_dirs.add("path/to/dir") do |dir|
    dir.auto_register = true
    dir.add_to_load_path = true
    # etc.
  end
end

FYI, I've tested this in https://github.com/dry-rb/dry-system/pull/155 and it's working nicely there.

FYI, I've tested this in https://github.com/dry-rb/dry-system/pull/155 and it's working nicely there.


[DisplayList] Remove support for inverse-fill path types

Skia paths, used by native code to implement Flutter paths, supports inverted fill types where the interior of the path is inverted (out to infinity in all directions).
Flutter's Dart APIs do not expose this concept and the only uses within the engine are from test code. The DisplayList recording format only supports such paths to match the (no longer used) SkPicture recording format.
We should delete all references to this path type and instead assert inside the DlBuilder and DlCanvas methods that the flag is false on all paths processed...

Eventually, if we move to our own Impeller/DisplayList based path implementation we can simply not provide this feature internally on such classes...


Use java.nio.file for file/path handling #750

Fixes #750
Things to take note of

The performance test in PersonListPanelTest is rather fickle. It fails sometimes, while passes in others. As such, TEST_TIMEOUT will be set to 12000 as a temporary measure until #863 is merged.
Even though many classes in the UI component use String arguments for file names for Class#getResource(String), the file names were changed to be of type Path and then converted to type String when needed. Not entirely sure if this is needed, but since using Strings for file names is still error prone I refactored it anyway. Do let me know if this shouldn't be the case.

Issues to raise

Many parts of the codebase have methods that declare that they throw an IOException even though it is never thrown in the first place. One example is JsonUserPrefsStorage#readUserPrefs(Path).
A few methods have return values that are never used. One such example is FileUtil#createFile(File).
Many methods can be made to have a more restrictive access modifier. One such case would be the methods in AddressBookSystemTest which could be made to be private. Not sure if this was intended for future use though.
UserPrefs#getAddressBookName is unused.

On a side note, I tried to place the conversion of all usages of File in the code base to Path as a separate commit but it almost always results in that commit failing tests since many of the method signatures were changed because of the conversion. So I placed it together with the first commit instead.

@vivekscl

The performance test in PersonListPanelTest is rather fickle. It fails sometimes, while passes in others. As such, TEST_TIMEOUT will be set to 12000 as a temporary measure until #863 is merged.

Resolved :)

Eh, not sure if the whole method needed to be re-written this way.
Some people might complain about "arrowhead code".

Arrowhead code means that there is many nested "if" statements right? But in this case, there's only one "if" statement. So doesn't that mean it's ok to re-write the method this way?

I don't see File#createNewFile() anywhere in the diff.

In this case, should I mention that it was done in the previous commit instead?

@vivekscl

Arrowhead code means that there is many nested "if" statements right? But in this case, there's only one "if" statement. So doesn't that mean it's ok to re-write the method this way?

You can look up "Make the happy path prominent" in https://nus-cs2103-ay1718s2.github.io/website/book/codeQuality/

In this case, is it better to mention that it was done in the previous commit instead?

Actually, I don't see how "Additionally, after the replacement of  File#createNewFile() with Files#createFile(Path), FileUtil#createFile(Path) can be simplified further." is even relevant to "changing the return type to void".
The commit message claims that it somehow makes the code "simpler", but I don't see how the final result is any simpler at all.

Actually, I don't see how "Additionally, after the replacement of File#createNewFile() with Files#createFile(Path), FileUtil#createFile(Path) can be simplified further." is even relevant to "changing the return type to void".

My thought process was that File#createNewFile() returned a boolean value, but now that it has been replaced, we have to separately return true which isn't required since the return type isn't used. And so that is part of the reason for changing the return type to void right? Furthermore, once the return type is changed to void, the if statement would not have any body and so inverting the condition and placing the file creation process within the if statement simplifies the method right?

@vivekscl

My thought process was that File#createNewFile() returned a boolean value, but now that it has been replaced, we have to separately return true which isn't required since the return type isn't used. And so that is part of the reason for changing the return type to void right?

Yes, that part is fine. I'm not objecting to the change of return type.

Furthermore, once the return type is changed to void, the if statement would not have any body and so inverting the condition and placing the file creation process within the if statement simplifies the method right?

In terms of complexity, they are the same.
Note that number of lines of code is just as illusion. If our code style did not require brackets, then it just becomes
if (Files.exists(file))
    return;
createParentDirsOfFile(file);
Files.createFile(file);

vs
if (!Files.exists(file)) {
    createParentDirsOfFile(file);
    Files.createFile(file);
}

i.e. the same number of lines
And if our code style allows guard clauses to be a single line, then it becomes:
if (Files.exists(file)) return;
createParentDirsOfFile(file);
Files.createFile(file);

i.e. 3 lines vs 4
Plus, how about the link I gave you on the "happy path principle"?

In terms of complexity, they are the same.
Note that number of lines of code is just as illusion.

Oh, now it's completely clear! Didn't realised that I misunderstood lesser lines of code as more simple :sweat_smile: . And the "happy path principle" really does make it clearer than trying to reduce the number of lines of code for superficial simplicity. Thanks for clearing that up! :smile:
On a side note, the commit message doesn't require this portion now right?
Additionally, after the replacement of File#createNewFile() with Files#createFile(Path), FileUtil#createFile(Path) can be simplified further.

On a side note, I tried adding more tests for parse but I can't pass in a null path since the app parameters will not accept any null characters in the input String. And since Unix operating systems consider null characters as invalid paths, I couldn't test for that an invalid path either.

@pyokagan a gentle reminder to review :smile:

@vivekscl Sorry, you'll need to wait until the weekend. In the meantime you can do a self-review or ask others to review.

Sorry, you'll need to wait until the weekend. In the meantime you can do a self-review or ask others to review.

Alright, I understand. Is it alright if ask Prof for a review, or is that allowed only after approval from others?

@vivekscl Any of the senior devs or @damithc can merge it if they are confident enough in the PR :-) (approval == reviewer vouches for the PR)

Any of the senior devs or @damithc can merge it if they are confident enough in the PR :-) (approval == reviewer vouches for the PR)

Alright, understood! @Zhiyuan-Amos @yamgent @damithc, if anyone is free, maybe take a look? :smile:

[2/6] Should we set AppParameters constructor to be private since this class is only instantiated through parse(Application.Parameters)?
Also, I'm wondering whether this class should be immutable (i.e. no need for setter method) since there's no reason for us to set the config path right?

The setter method is used in the test, and there's no other way to create this object with the current implementation. So perhaps there can be a AppParameters(string) constructor as well?

[2/6] Should we set AppParameters constructor to be private since this class is only instantiated through parse(Application.Parameters)?
Also, I'm wondering whether this class should be immutable (i.e. no need for setter method) since there's no reason for us to set the config path right?

The setter method is used in the test, and there's no other way to create this object with the current implementation. So perhaps there can be a AppParameters(string) constructor as well?

So essentially, there's no need for a setter method and instead we can replace it with a public constructor that takes in a string?

@yamgent

The setter method is used in the test, and there's no other way to create this object with the current implementation. So perhaps there can be a AppParameters(string) constructor as well?

This will make tests harder to write in the future when we start introducing additional optional configuration properties, since you can't easily create an AppParameters object with all default property values EXCEPT the value that is being tested.

@pyokagan

Should we set AppParameters constructor to be private since this class is only instantiated through parse(Application.Parameters)?

Also, I'm wondering whether this class should be immutable (i.e. no need for setter method) since there's no reason for us to set the config path right?

Do you have any thoughts on this? Implementing AppParameters this way will definitely make tests way harder to write as mentioned by @yamgent. 2 alternatives that I've thought of:

Reflection.
Instead of comparing equality between 2 AppParameters objects, we compare the equality of the configPath only. This is a weaker test though.

Instead of comparing equality between 2 AppParameters objects, we compare the equality of the configPath only. This is a weaker test though.

Just my thoughts on this:
Is there a need to make AppParameters immutable? In cases where AppParameters#parse is called multiple times, the values get modified so it's essentially supposed to be mutable? :thinking:

This will make tests harder to write in the future when we start introducing additional optional configuration properties, since you can't easily create an AppParameters object with all default property values EXCEPT the value that is being tested.

Sorry, I realized that @yamgent was actually saying something like my message.
To make it clear: I'm -1 on making it immutable. It provides no benefit, and just makes tests harder to write.

@Zhiyuan-Amos What problem are you trying to solve by making it immutable?

Sorry, I realized that @yamgent was actually saying something like my message.

Whoops, don't think this statement is right either.
Anyway:

Making AppParameters immutable -- Disagree. No benefit since only one AppParameters will be kept around, makes tests harder to write (you'll need to write a AppParametersBuilder to restore sanity, but this is going into FizzBuzzEnterpriseEdition territory. Just keep it simple)

No default constructor for AppParameters, require callers to use AppParameters(String configPath) constructor. If we have more parameters in the future the constructor will be extended to have more arguments. -- Disagree. This will make tests much more verbose when we start introducing additional optional configuration properties.

Merge commit message:
String operations are used for the construction of file paths. Also,
many APIs in the codebase take in String arguments as file paths.

This method of file/path handling is error prone as creating paths using
string concatenation can lead to the creation of invalid paths.
Furthermore, checking if two paths resolve to the same file using string
equality is incorrect as it only tests if the strings are equal.

Let's refactor the codebase to use java.nio.file for file/path
handling as it provides a safe and platform-independent way to
perform operations on paths and properly separate the concerns of
parsing/stringifying paths and manipulating paths.

Commit message contains the messages for both [2/6] and [3/6].

@yamgent thanks for catching that! Really bad mistake on my part :sweat_smile: .

@vivekscl you can last call review this.

@yamgent I guess this is ready to merge? :smile:


Proper attribution

Looks good, Tomas.
This is a polite request for you to include my copyright notice and license with this software, as it is clearly built very substantially on my hard work.

Hi Mike,
Sure, definitely! I tried to give you the credit already by mentioning you explicitly in the headlines of README.
I'm just thinking how to do it properly as your license talks about big.js and as-big does differ in some aspects.
Would you like to create a PR with a solution that you’d be happy with? Or just tell me your vision. Thanks!
And many thanks for your work, I'm a big fan!

Yes, I think I would class this as a "derivative work", and you've done an impressive job.
As the MIT license is the same for both, the easiest solution is probably just to add my copyright to the existing license.
I'll create a PR.

Merged, thank you!


Add e2e tests using a TUF mirror

Add a test that, instead of overriding trusted keys with environment variables, actually initializes a TUF cache using a local TUF mirror. This will prepare us to safely make changes to the TUF client.
Metadata for the public good instance goes through a different code path, since those keys are embedded in the code. We can't test signing and verifying with the public good instance hermetically, so we rely on conformance tests to catch issues with that path.

Summary

Release Note

Documentation

@cpanato any idea on why the goreleaser snapshot is failing?

hook failed: shell: '/bin/bash -c if [ -n "$(git --no-pager diff --exit-code go.mod go.sum)" ]; then exit 1; fi': exit status 1: [no output]

well that looks fun.

--exit-code looks like a red herring as the test does not actually use the git exit code (because "-n")
$() eats the git diff output so we can't see the what this failed on
...but there might also be a quoting failure here: notice how in the log there is no starting quote after bash -c even though there is in sources

fixing the test to use git exit code instead of comparing strings would at least allow us to see what happens and might avoid the potential quoting issue -- git --no-pager diff --exit-code go.mod go.sum looks like it should work as is: no bash -c needed?

@cpanato we might need to try to free up more disk space, IIRC this is usually the culprit for this test failing

@cpanato we might need to try to free up more disk space, IIRC this is usually the culprit for this test failing

this seems unlikely to be the reason in this case: it's not actually building anything yet at the point of failure.

I can try out the refactor I mentioned: it should give some more leads.

I was not expecting it but turns out the patch does simply create a go mod tidy change.
There's two commits in https://github.com/jku/cosign/commits/tuf-e2e-tests/ -- @cmurphy feel free to take both or just do  a go mod tidy (I can submit the the hook refactor separately).

@jku wow thanks for catching that, I updated go.mod here if you want to submit your git-diff fix as its own PR


Respect package.readme in Cargo.toml

Fixes #1215 by honoring how package.readme is authored in Cargo.toml, if authored. This could be a path or a boolean to disable searching for the path.
Also fixes the existing it_copies_a_readme_provided_path test which was an exact copy - just with fewer empty lines - of it_copies_a_readme_default_path and wasn't honoring any authored path since there was no way to get the authored path.

This fixes some issues with a couple tests that were actually broken before the original PR this replaces. Looking at old runs, it seems that they were effectively broken when the change was made to stop deserializing the manifest in this crate directly and to use a tool instead. Maybe the breaks in the tests weren't fully exposed then - though there were subsequent build breaks exactly the same as after the original PR for this change - but I am happy to fix them because they certainly are related to what I was trying to achieve here: to ignore when a README was explicitly disabled (as I'd expect for a wasm).


Webpacking ms-rest-js results in  TypeError: fetch is not a function

Package Version: 2.0.04

[x] nodejs

nodejs version: 10.16.0
os name/version: Windows 10

[ ] browser

name/version: ____
Describe the bug
We are consuming this library via @azure/storage-blob. For our scenario, we are running some code on our continuous integration pipeline that uploads files to blob storage. To avoid having to do an NPM install on the CI server, our desire is to webpack our file upload utility and just run the bundled JS file on the build server. However, we are seeing an issue resolving fetch that does not manifest when running the script in a non-bundled context.

To Reproduce
Steps to reproduce the behavior:

Create any script that consumes nodeFetchHttpClient.ts. In our case, we are bundling a modified version of the advanced example of the @azure/storage-blob sdk with our blob storage details.
Create a webpack bundle with target "node".
Run that bundle with node [bundlefilename].js

Expected behavior
We expect the library to work in a bundled context, without having any issues relating to fetch.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I dug a bit deeper here and I found that folks are having similar issues in other libraries, with the best example being the discussion here: https://github.com/bitinn/node-fetch/issues/450
It appears that in the case for ms-rest-jest, it is this line that is problematic for webpack:
if (typeof globalWithFetch.fetch !== "function") {
  const fetch = require("node-fetch");
  globalWithFetch.fetch = fetch;
}

It appears to be an issue with commonJS vs ESM module resolution. It seems like webpack would want the import to be require("node-fetch").default. However, I am not sure if this would have implications for folks not consuming this library via webpack.

I guess no one uses this repo, perhaps the js sdk repo will get better responses.
fyi we also have production issues with the same errors.  (typescript)

Any work-around for this issue? We're also facing it.

This is now released in @azure/ms-rest-js 2.0.5.

Thanks @AnthonyMacKinnon working great now.


Lro rehydration with static method

User interface:
      public static ArmOperation<TModel> Rehydrate<TModel>(ArmClient client, string id)
            where TModel : ISerializable, new()

      public static ArmOperation<TResource> Rehydrate<TResource, TModel>(ArmClient client, string id)
            where TResource : IData<TModel>
            where TModel : ISerializable, new()

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Why does rayon not use tokio?

I see that there is rayon-core, and I was almost under an impression that it pretty much just an multithreaded asynchronous programming runtime.
So it made me wonder, couldn't it be replaced by tokio?

The simple answer is that rayon-core predates tokio, by several years. But rayon-core is not asynchronous in the sense of the language async and .await features, so I doubt it would work well within tokio's pool anyway.


fix(reactivity): lose activeEffectScope when effectScope(true)

Vue SFC Playground:

v3.2.30
v3.2.29

v3.2.30 will be lost activeEffectScope and previous version was worked properly.

Does any maintainer want to review this PR?

Can you add a regression test for this?

Sure.

off() is the same problem.

@qq15725 do you have a failing test case so we can add it?

@posva
Vue SFC Playground: 3.2.31
<script setup>
  import { effectScope, onScopeDispose } from 'vue'
  effectScope(true).off()
  onScopeDispose(() => undefined)
</script>

Vue warn

[Vue warn] onScopeDispose() is called when there is no active effect scope to be associated with.

test case:
it('getCurrentScope() stays valid when offed a detached nested EffectScope', () => {
  const parentScope = new EffectScope()

  parentScope.run(() => {
    const currentScope = getCurrentScope()
    expect(currentScope).toBeDefined()
    const detachedScope = new EffectScope(true)
    detachedScope.off()

    expect(getCurrentScope()).toBe(currentScope)
  })
})

Thanks. You don't call off on an effectScope, you call stop() (https://vuejs.org/api/reactivity-advanced.html#effectscope) so that will never happen in a real scenario.


add MacOS installation (both CH/EN)

add MacOS installation (both CH/EN)

Thanks for the PR. I think this was merged prematurely, as there is a Homebrew formula for Drogon that makes the whole process a one-liner, and also takes care of the dependencies.
Would you mind to update the docs with references to the formula, @leeyoyo49?

Thanks for the PR. I think this was merged prematurely, as there is a Homebrew formula for Drogon that makes the whole process a one-liner, and also takes care of the dependencies.
Would you mind to update the docs with references to the formula, @leeyoyo49?

ok!


[component,core] add support for the START BucketStrategy

Codecov Report

Merging #250 into master will increase coverage by 0.02%.
The diff coverage is 68%.

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
+ Coverage     47.45%   47.48%   +0.02%
  Complexity     2537     2537
============================================
  Files           609      609
  Lines         16017    16035      +18
  Branches       1194     1195       +1
============================================
+ Hits           7601     7614      +13
- Misses         7964     7968       +4
- Partials        452      453       +1

Impacted Files
Coverage Δ
Complexity Δ

...potify/heroic/aggregation/AggregationInstance.java
100% <100%> (ø)
4 <1> (ø)
:arrow_down:

...com/spotify/heroic/aggregation/BucketStrategy.java
64.86% <62.5%> (-1.81%)
1 <1> (ø)

.../com/spotify/heroic/metric/LocalMetricManager.java
64% <75%> (+0.16%)
4 <0> (ø)
:arrow_down:

...main/java/com/spotify/heroic/CoreQueryManager.java
75.39% <75%> (+0.12%)
9 <0> (ø)
:arrow_down:

...m/spotify/heroic/aggregation/simple/MinBucket.java
42.85% <0%> (-9.53%)
4% <0%> (-1%)

...ava/com/spotify/heroic/rpc/grpc/GrpcRpcClient.java
71.05% <0%> (+2.63%)
8% <0%> (ø)
:arrow_down:

...om/spotify/heroic/metric/memory/MemoryBackend.java
86.56% <0%> (+2.98%)
15% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253ac64...eca69c4. Read the comment docs.

@udoprog Feel free to merge


discovery: author should match any creator

@dtarb @Lizabrazil @Castronova
I'm reviewing the discovery code and the current definition of "author" is that "the author is the first creator in human-specified order". This is somewhat misleading. "Creator" is multi-valued, and entered by the person who creates the resource. Thus, anyone listed as creator by this person should be considered an author for purposes of discovery and faceting.
I propose that all creators should be treated as authors for purposes of discovery.
(only the first creator is shown in the list, but all should be faceted; currently all creators after the first are ignored)

Addressed by #2578


Adding Varndean College

Computer Science A Level - link
And below is a screenshot of our Google Admin panel with our domains

@sfrench87 First stage of verification passed, official domain is varndean.ac.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@sfrench87 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


skip validate option

SkipAllValidate into ValidateOpts
skip all validate logic of reader when the option is enable

Codecov Report

Merging #1154 (fb288d5) into master (035a010) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
- Coverage   90.07%   90.00%   -0.08%
==========================================
  Files          71       71
  Lines        6732     6743      +11
==========================================
+ Hits         6064     6069       +5
- Misses        401      404       +3
- Partials      267      270       +3

Can we add some tests? This is a pretty major change.

Can we add some tests? This is a pretty major change.

sure, I will add soon

office is off in this week? I don't see any coworker in slack channel

Can we rebase off origin/master when the tests are added? Thanks

Why does this PR include changes that are already on master?

skip-validation option will be run on file/reader's level, not record's level


Duo Client failing

How can I go past this stage for the backend services when I run make deploy. I am using vagrant to do the test:
Downloading/unpacking duo-client==3.0 (from -r requirements.txt (line 8))   Could not find any downloads that satisfy the requirement duo-client==3.0 (from -r requirements.txt (line 8)) No distributions at all found for duo-client==3.0 (from -r requirements.txt (line 8)) Storing complete log in /home/vagrant/.pip/pip.log make: *** [install-python-requirements] Error 1

It's possible this is due to an issue connecting to PyPI. Are you getting this error consistently?
If you would provide the contents of the log file (/home/vagrant/.pip/pip.log) mentioned in the error message, I might be able to help more.

Thanks for the quick response. I took the footer:
`
Downloading/unpacking duo-client==3.0 (from -r requirements.txt (line 8))
Getting page http://pypi.python.org/simple/duo-client
URLs to search for versions for duo-client==3.0 (from -r requirements.txt (line 8)):

http://pypi.python.org/simple/duo-client/3.0
http://pypi.python.org/simple/duo-client/
Getting page http://pypi.python.org/simple/duo-client/3.0
Getting page http://pypi.python.org/simple/duo-client/
Could not fetch URL http://pypi.python.org/simple/duo-client/3.0: HTTP Error 404: Not Found
Will skip URL http://pypi.python.org/simple/duo-client/3.0 when looking for download links for duo-client==3.0 (from -r requirements.txt (line 8))
Analyzing links from page https://pypi.python.org/simple/duo-client/
Skipping link https://pypi.python.org/packages/2d/d4/a3e53834e21558624422fe8ca1cc3c188b9c91e7f5d516d1803c233b5661/duo_client-2.1-py2-none-any.whl#md5=ecf50a95ea33ffab73215be91fe2d80c (from https://pypi.python.org/simple/duo-client/); unknown archive format: .whl
Skipping link https://pypi.python.org/packages/ef/af/b58ff2872f165c98e5d0789b6840698237b9c70b11f45c46ad3a339abbaa/duo_client-3.0-py2.py3-none-any.whl#md5=25cb608553606af59f1f684660e097e2 (from https://pypi.python.org/simple/duo-client/); unknown archive format: .whl
Could not find any downloads that satisfy the requirement duo-client==3.0 (from -r requirements.txt (line 8))
No distributions at all found for duo-client==3.0 (from -r requirements.txt (line 8))
Exception information:
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 126, in main
self.run(options, args)
File "/usr/lib/python2.7/dist-packages/pip/commands/install.py", line 223, in run
requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
File "/usr/lib/python2.7/dist-packages/pip/req.py", line 948, in prepare_files
url = finder.find_requirement(req_to_install, upgrade=self.upgrade)
File "/usr/lib/python2.7/dist-packages/pip/index.py", line 152, in find_requirement
raise DistributionNotFound('No distributions at all found for %s' % req)
DistributionNotFound: No distributions at all found for duo-client==3.0 (from -r requirements.txt (line 8))
`

Looks like you may have an old version of setuptools. You can upgrade with pip install --upgrade setuptools, then re-run. Let me know if that fixes the problem.

Didn't seem to fully work. I am now getting this error when I actually try and to do the upgrade:
`Downloading/unpacking setuptools>=0.7 (from distribute)
Running setup.py egg_info for package setuptools
Traceback (most recent call last):
File "", line 3, in
File "setuptools/init.py", line 10, in
from six.moves import filter, map
ImportError: No module named six.moves
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 3, in
File "setuptools/init.py", line 10, in
from six.moves import filter, map

ImportError: No module named six.moves

Command python setup.py egg_info failed with error code 1
Storing complete log in /home/vagrant/.pip/pip.log`
The full log is:
`------------------------------------------------------------
/usr/bin/pip run on Tue Apr 18 23:05:40 2017
Downloading/unpacking distribute
Running setup.py egg_info for package distribute
running egg_info
writing requirements to pip-egg-info/distribute.egg-info/requires.txt
writing pip-egg-info/distribute.egg-info/PKG-INFO
writing top-level names to pip-egg-info/distribute.egg-info/top_level.txt
writing dependency_links to pip-egg-info/distribute.egg-info/dependency_links.txt
warning: manifest_maker: standard file '-c' not found
reading manifest file 'pip-egg-info/distribute.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'pip-egg-info/distribute.egg-info/SOURCES.txt'

Downloading/unpacking setuptools>=0.7 (from distribute)
Running setup.py egg_info for package setuptools
Traceback (most recent call last):
File "", line 3, in
File "setuptools/init.py", line 10, in
from six.moves import filter, map
ImportError: No module named six.moves
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 3, in
File "setuptools/init.py", line 10, in
from six.moves import filter, map

ImportError: No module named six.moves

Command python setup.py egg_info failed with error code 1
Exception information:
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 126, in main
self.run(options, args)
File "/usr/lib/python2.7/dist-packages/pip/commands/install.py", line 223, in run
requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
File "/usr/lib/python2.7/dist-packages/pip/req.py", line 980, in prepare_files
req_to_install.run_egg_info()
File "/usr/lib/python2.7/dist-packages/pip/req.py", line 216, in run_egg_info
command_desc='python setup.py egg_info')
File "/usr/lib/python2.7/dist-packages/pip/init.py", line 255, in call_subprocess
% (command_desc, proc.returncode))a
InstallationError: Command python setup.py egg_info failed with error code 1
`
😢

It seems like you have some really old packages installed. I don't know much about Vagrant, but is it possible you could update your base image to something more recent? Debian Jessie or Ubuntu Xenial, perhaps?
Otherwise, a pip install --upgrade pip might help.

I upgraded the OS I was using on Vagrant and it worked. Thanks @andrewmwhite for the help


feat: always use stream unless set --no-stream explicitly

Aichat will detect whether tdout is terminal. If it is not, Aichat will automatically switch to non-stream mode.
This will not be true after this PR.
There will be only two conditions for Aichat use non-stream mode:

explicitly pass --no-stream option
pass -c/--code option and stdout is not terminal (for extracting code from markdown)

Users who use aichat in a script should explicitly pass --no-stream.
solve #414

a9a2ca fixed it.

Thank you!


ci(next): add Drupal 10.2 to CI test matrix

This pull request is for: (mark with an "x")

[ ] examples/*
[x] modules/next
[ ] packages/next-drupal
[ ] starters/basic-starter
[ ] starters/graphql-starter
[ ] Other

GitHub Issue: #542
Describe your changes
Runs the next module tests against Drupal 10.2.0-rc1

EntityResourceTest needs file in its $modules array

Matt Glaman, the Drupal test whisperer. 😻


Need to Re-Create all data files regularly!

As working on IBM-Validated-Software List I noticed that after some time some packages in a file get expired or modified.  That's the case for every file that we've in our supported_distro.py. We might be serving the wrong packages to our users through our platform and that's something we can't ignore and might need to correct. Till now we don't update the files till it is Expired or if the file is not being created successfully.
I've attached a Screenshot for your reference. This is the file for IBM_Validated_OSS_List_Ubuntu_2004.json. As you can see, packages change over time.

Therefore, We might need to drop our data files and recreate them after some time regularly. We can also automate this so that we don't have to create each and every file again and again manually.
@pleia2 and @arshPratap Please take a look into this.

@Princee215 yup this sounds like a good addition... Especially for the backend feature that is currently ij development and also for the automation task

As a policy, I try to update the production data on sdt.openmainframeproject.org on a monthly basis. In practice, this is a manual process and I don't actually do it that often.
The good news is that there shouldn't be any changes required to bin/package_build.py since we're already overwriting all the content when the script runs, rather than trying to append, or do any complicated replacements.
Now, to move forward, there are two components to this.

Automate the submitting a regular (weekly? monthly?) PR of files that changed for everything we manage in our -data repository via package_build.py: https://github.com/openmainframeproject/software-discovery-tool-data

Regardless of what we decide for the next step, we should definitely do this one!

Automate updates to production.

We have two options here. Today, I get the raw data for our production instance from our -data repository, I don't run package_build.py on the production server itself. So we could:
2a. Add instructions to our -deploy repository to automate this by pulling from the -data repository, maybe suggest a cron job that calls a script that grabs everything from -data that's in our production supported_distro.py?
OR...
2b. We can also rethink this entirely and maybe we DO run bin/package_build.py in production. In this case we'd document similar to above, maybe with a cron job that runs periodically and emails an admin (me) with any failures.
Once we decide what to do, we can split this off into two issues in the -data and -deploy repositories.

is it still open ? , @pleia2  @rachejazz  can u assign it to me?

is it still open ? , @pleia2 @rachejazz can u assign it to me?

@Rohitrky2021 This one is a bit complicated because it has multiple parts and there isn't a clear answer as to which way we want to go. So before a PR is created, we need to have a discussion in this issue about the best way forward. Did you have some thoughts?


Daily Rollup Bar Chart: Clicking on the Orange Part of the Bar Should Display Cancelled Reports

On the Daily Rollup bar chart, clicking on the blue or orange section of the bar will only display reports that are released, but not reports that are cancelled.  Clicking on the blue section should display only released reports.  Clicking on the orange section should only display cancelled reports.
Reference item 93

@VassilIordanov  Will this still be an Insight as per your project assignment on 30 May 2018?  The requirements owners are expecting this to be implemented on the Daily Rollup bar.

Added to #1966


Should EC2 default to non-spot when spot is not available?

The following error is produced in SFN, when the spot is not available:
{
  "resourceType": "aws-sdk:ec2",
  "resource": "runInstances.waitForTaskToken",
  "error": "Ec2.Ec2Exception",
  "cause": "There is no Spot capacity available that matches your request. (Service: Ec2, Status Code: 500, Request ID: 5b80a392-c6eb-42d1-99e9-d36db1909cf4)"
}

Catching this error, and then defaulting to non-spot would be optimal.
Otherwise, GitHub runners continue running, waiting to be completed and nothing happens.

Good idea. Maybe retry spot a bit and the fallback if the user enabled this option.

It would also be cool to give a list of instance types to increase the pool of eligible servers.
To be honest AWS should build that in to runInstance

I believe they have that with their fleet option. I think I tried using that for EC2 but it didn't work as smoothly as RunInstances. Might be worth another look.

Ah ok. Tbh we'll probably move to Fargate runners eventually, EC2 was just the easiest to get running. Would much rather use a Dockerfile than EC2 Image Builder.

I think this might be easy to implement once #216 is merged.

I think it would make sense to implement both ideas mentioned above...

Default to non-spot instance if no spot instance available
Change instanceType for the runners to a list to add multiple instance-types
@kichik
What`s your opinion ?

Falling back to non-spot should be very possible although won't be perfect. I think at first just any Ec2Exception can fallback to non-spot (Step Functions don't give us the option of filtering on the error message which is not guaranteed to be stable anyway). Then maybe in the future if it has too many false positives, we can consider adding a Lambda in between to check the error message. Parsing the error message will also be a challenge because we have to try all subnets first. Might just have to replace the whole thing with one big Lambda if we really need to check the error message.
Multiple instance types will be harder as RunInstances doesn't support it and the other options didn't work too well when I tried them. If someone can figure out a good way to switch to fleet, I'm happy to hear.
My priority right now is to overhaul runner customization, so if anyone wants to get a PR going for this one, I'd be happy to accept it. At the very least we should be able to quickly get a fallback to non-spot after trying all the subnets with spot.


refactor parsing resource files to directory based

Pull Request Test Coverage Report for Build 190

19 of 22 (86.36%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 54.18%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pybo/pybotrie.py
6
9
66.67%

Totals

Change from base Build 186:
0.3%

Covered Lines:
998

Relevant Lines:
1842

💛  - Coveralls


Secret Assignment "Add another Secret" css invalid

Environment

Python version: 3.9
Nautobot version: 1.3.2

Steps to Reproduce

Edit "Secrets Group"
Click on button "Add another Secret"

Expected Behavior
Line should be formatted same as all lines above

Observed Behavior
Line is not formatted correct

This issue also exists in Custom Field Choice UI (#997), and in the MVP for Dynamic Groups of Dynamic Groups (#1785),

We will likely need to patch nautobot/project-static/jquery/jquery.formset.js in some way to account for the proper CSS/attribute values needed to make the style consistent.

Code complete. Being brought in via #1785 (#1614)


[New Feature] Use http or hyper crate instead of reqwest, make it lighter

As describled in title.

Meaningless


Fix system memory size of tvOS

the sytem memory size of tvOS is hardcoded as 0 currently, updated to use sysctlbyname("hw.memsize") to get the correct info
apple document didn't stat this API is available on tvOS though
found this bug while using libplacebo's vulkan render to play video on tvOS

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

PR is updated to use sysctlbyname to get system memory size for all apple platforms


fix: task worker requeue wrong task. Fixes #8139

Signed-off-by: wujayway<EMAIL_ADDRESS>Fixes #8139
Use for loops instead of for range. Avoid go problems on time.After with closure.

I've just noted, I'm not sure this will make a difference, as the semantics are not changed.


Devtools font 显示不正确

Describe the bug
devtools 里的字体显示不正确
Reproduction
when show devtools pannel

System Info
System:
    OS: macOS 12.3
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 1.78 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.15 - ~/.nvm/versions/node/v16.15.0/bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 105.0.5195.125
    Firefox: 27.0.1
    Safari: 15.4

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

https://github.com/ChromeDevTools/devtools-frontend/commit/21b0aa21a97eacf5dd0dead03813bf1edb1a526e
https://github.com/ChromeDevTools/devtools-frontend/commit/623ea761d226745f18a12d4790f1f5266c6529a1
The issue originates from here. The default font has been changed to monospace.

@draculapile
chrome://settings/fonts
在chrome浏览器上手动修改等宽字体为Consolas就行了


Unable to run the script in Ubuntu/Linux

When I cloned the repo in Linux/Ubuntu and trying to execute the orbitm.py, I end up with the ImportError
ImportError: cannot import name 'COMError' from '_ctypes'. I am using Anaconda as the Python environment.
Is the script only made for Windows? If so, is there a way to get it working in Ubuntu/Linux?

Have you tried running it in Windows?
One possibility is that you might be trying to run it on either of the STK modes when you don't have a licensed copy of STK Integration or STK Astrogator. You need those two licenses on top of either STK 10 or STK 11 installed. In the native orbit maintenance simulation (Sam's mode), the COM library should not even be importing. Let me know if there is still an issue in the native Sam's mode.

Thank you for a quick reply. I did not try in Windows.
I am not able to get the GUI itself (to select the mode). I get the ImportError when I try to do python orbitm.py.

Try importing any of the following libraries in your Python terminal and see which are the libraries you don't have.
numpy, matplotlib, tkinter, PIL, os, math, datetime,

Commenting the line
from codes.orbitm_run_stk import orbm_run_stk
and changing line 91 from
orbitm_logo = orbitm_logo + '\gui\orbm_logo.png'
to
orbitm_logo = os.path.join(orbitm_logo, 'gui', 'orbm_logo.png')
did the job. Now the GUI seems to boot up. Thank you for the guidance.

Thanks for pointing out the bug, Gowtham! I’ll try to see if I can organise the code in such a way where it’s Linux friendlier.


New Generic List cannot be created under folder in Generic List editor

Required Information

[x] AEM Version, including Service Packs, Cumulative Fix Packs, etc: <IP_ADDRESS>
[x] ACS AEM Commons Version: 4.9.2
[x] Reproducible on Latest? yes

Expected Behavior
User should have the ability to create a new Generic List from localhost:4502/generic-lists.html interface underneath a folder created as a child of /etc/acs-commons/lists.
Actual Behavior
While the user does have the ability to create both a new Generic List and a new Folder under /etc/acs-commons/lists using the Touch UI interface, the option to create a new Generic List is hidden when focusing on a folder.
Steps to Reproduce

Navigate to localhost:4502/generic-lists.html/etc/acs-commons/lists
Click on the "Create" blue CTA
Choose "Folder"
After folder is created, click on that folder name (do not click on the thumbnail)
Click on the "Create" blue CTA
The only option available is to create another Folder, not to create a Generic List

Links
http://localhost:4502/generic-lists.html/etc/acs-commons/lists
https://adobe-consulting-services.github.io/acs-aem-commons/features/generic-lists/index.html

Same issue for me as well.