Error during install - ostree container image deploy "no-signature verification"

Used Rufus to write the install image, tried two types of media (USB flash Disk and USB SSD) Bazzite gnome Nvidia, started install using basic graphics.
After I choose the initial options, I get the error:
Error Image
I'm not sure how to proceed with the install.
Thanks.

It says:
The following error occurred while installing the payload. This is a fatal error and installation will be aborted.
The command 'ostree container image deploy--sysroot=/mnt/sysimage--image=ghcr.io/ublue-os/bazzite-gnome-nvidia:38--no-signature-verification exited with the code 1.

Make sure an internet connection is configured prior to install, and that your internet is stable. This is an online installer.

I thought that could be part of it and am definitely connected. It's 5G though, I'll switch to 2.4Ghz and see if it persists.

Seems like that was it. I wired in with ethernet and had no issues. Hopefully wireless will work when I'm done but that's a future problem. Thank you!

Don't know why but had the same issue with ROG Ally, tried installing bazzite at least 10 times with a stable wifi connection, ethernet connection and my Ally was plugged in all the time. Tried one last time with plugging out the power cable and it worked. IDK why, how but keep in mind that it happened :)

Don't know why but had the same issue with ROG Ally, tried installing bazzite at least 10 times with a stable wifi connection, ethernet connection and my Ally was plugged in all the time. Tried one last time with plugging out the power cable and it worked. IDK why, how but keep in mind that it happened :)

This no longer should be an issue with the new ISO images. They can be installed completely offline. It is recommended to have internet connection on first boot however to download updates and remaining software not on the ISO.

Don't know why but had the same issue with ROG Ally, tried installing bazzite at least 10 times with a stable wifi connection, ethernet connection and my Ally was plugged in all the time. Tried one last time with plugging out the power cable and it worked. IDK why, how but keep in mind that it happened :)

This no longer should be an issue with the new ISO images. They can be installed completely offline. It is recommended to have internet connection on first boot however to download updates and remaining software not on the ISO.

IDK I was online all the time but thanks :)

i am getting this same error... i am definitely online with an ethernet connection, if it is offline capable then possibly it is from the fact i am trying to install on a partitioned drive with an existing Win11 installation... but either way any assistance would be appreciated, trying to replace windows with linux, but linux resists this every time

Did you fix the issue yet?

No... I am fairly certain this is a issue with partitioned drives... I tried to install kinoite and rebase to bazzite... But the exact same error occurs... From there I found there is a known issue with kinoite and partitioned drives

unfortunately did not work for me, same error

unfortunately did not work for me, same error

Sorry, I completely forgot to reply that I found a solution. When you're manually creating partitions, You have to create a EFI Boot partition AND a Boot partition, whereas you usually just need a EFI Boot on other distros. I found this out on a Youtube tutorial on how to install Fedora a while back. Doing this, I had no issues installing Bazzite multiple times. The Boot partition was suggested at 1000MB for size, but it might be negotiable, I don't know.

Today I tried installing it again on my ally and had the same problem. Again unplugging the power cable fixed the problems.

I see this is known issue.  I had no problems installing the first time on my Ally and accidentally went into Steam and ended up in a “Verifying Installation” loop.
I thought I’d just reinstall and even if delete and format partitions, I keep getting the no-signature verification issue.  I tried both on and offline (as I was offline on the first install & verify the install can complete completely offline)
Tried 4x and always run into the same error.  Kinda bummed this is my introduction to Bazzite and Fedora after reading so many good things!

unfortunately did not work for me, same error

Sorry, I completely forgot to reply that I found a solution. When you're manually creating partitions, You have to create a EFI Boot partition AND a Boot partition, whereas you usually just need a EFI Boot on other distros. I found this out on a Youtube tutorial on how to install Fedora a while back. Doing this, I had no issues installing Bazzite multiple times. The Boot partition was suggested at 1000MB for size, but it might be negotiable, I don't know.

Thanks, I fixed it this way by following the boot partition setting through this video: https://www.youtube.com/watch?v=RUES5B5j6EU&t=682s


Zts cmc

Updated the governance policy with the reloader deployment pre-requisite checking.

https://github.com/stolostron/policy-collection/pull/304/files
is the new pull request.


SWBD ESPNet2 Update

Added entry in CSV for ESPNet2 SWBD Model with 6.8/14.0 WER

Model test is failing because I use fbank-pitch not raw @sw005320

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3642abf). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 58ad300 differs from pull request most recent head 19b7d2d. Consider uploading reports for the commit 19b7d2d to get more accurate results

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   53.45%
=========================================
  Files             ?        2
  Lines             ?      318
  Branches          ?        0
=========================================
  Hits              ?      170
  Misses            ?      148
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3642abf...19b7d2d. Read the comment docs.

Plugged in a fix for non raw models in ci/test_model.py where input size is based on model input size

Oh, I see.
Actually, espnet model zoo is intended to have a standalone demo like https://github.com/espnet/espnet_model_zoo#asr
So, Kaldi pitch feature based model would not be recommended.
Sorry that this is based on my wrong suggestion…
I’ll close this PR.


Dispose a wiki section for each documentation about dependency's state

Since there are some few questions about this plugin, a directly wiki would be good.

I'm not entirely sure which part(s) you're confused about. Most of the basic usage is covered in the readme, although I do admit some things could be documented better


[iOS][Offline] Fields with nil value are ignored on push operations

When a record is updated locally, and an existing value is replaced with null, this change is not pushed to the server. This causes data loss. A workaround would be to use empty strings instead of null, but this solution doesn't work well for foreign keys.
I inspected the code and found the reason why that issue happens. In the class MSCoreDataStore, the method:
-(id) getRecordForTable:(NSString *)table itemId:(NSString *)itemId asDictionary:(BOOL)asDictionary orError:(NSError **)error
is using NSDictionaryResultType on the fetch request. As a result, the null values are not added to the dictionary which is used to push the changes to the server.

The NSDictionaryResultType was used to support the "selectFields" property of the MSQuery object (via propertiesToFetch).  The readTable:withItemId:orError method appears to be using it for convenience to get a NSDictionary but a simple swap to using tableItemFromManagedObject: method should work here instead.
Also we should consider making tableItemFromManagedObject into an instance method, so MSCoreDataStore could be inherited from and the logic adjusted as needed by the developer better.

This I believe is fixed with Shrirangs PR, closing issue.


Poor longitudinal tuning

Some cars (mostly Hondas) have very poor longitudinal tuning. They undershoot desired acceleration from the planner consistently. This causes the car to never accelerate even if the planner tells it to for 10+ seconds.
These cars need to be retuned so this does not happen. Here is the average difference between desired acceleration (from the longitudinalPlan message) and actual acceleration (from the carState message).

These values should be very close to 0. In the hondas they are not, this will cause the car to drive too slow and the following distance be larger than it should be.
If you have one of the poorly tuned cars, your help would be appreciated! Using plotjuggle to compare desired and actual acceleration on your drives would be the first step.

https://github.com/commaai/openpilot/issues/21697 related

So what parameters should we change to get it to zero?

Any good guides on how to use plotjuggler with the comma2?

@adidasboy517
https://github.com/commaai/openpilot/tree/master/tools/plotjuggler
Has a README
@che220
https://github.com/commaai/openpilot/blob/master/selfdrive/controls/lib/longcontrol.py
This is the longitudinal control loop. It has PID values that are specific to each car/brand.
And then there is some car-specific interface code here
https://github.com/commaai/openpilot/blob/master/selfdrive/car/honda/interface.py
and
https://github.com/commaai/openpilot/blob/master/selfdrive/car/honda/carcontroller.py
I'm not super familiar with it myself, it's likely quite a bit more complicated than just tuning some numbers.

If those Hondas have gas interceptors, then it's probably due to longcontrol outputting an acceleration request, but the pedal taking in a gas percentage, leading to undershoot as 0 m/s/s desired acceleration means that no gas will be applied. I don't think you can tune this out, you need some way to convert acceleration to gas, per car. Or a general conversion function that works well enough for all with the pedal

@sshane If it's just that, shouldn't the PID be able to deal with it?

Eventually, but there's always going to be some oscillation with acceleration. If you want to maintain your speed openpilot will request 0 acceleration (which is really 0% gas if using a pedal) so it slows down and then integral will build up and overshoot. It may be less responsive to gas on Hondas though so it may never overshoot (I'm used to Toyota).

Sounds like you need a gas feedforward term

Related
https://github.com/commaai/openpilot/issues/21803

Basically the main cause of this issue is that honda nidec accel control goes through a strange function, not the long control loop like it does for all cars. I am working on a PR to fix this. But I can only test on our own Civic. So feedback from other cars would be very welcome.
https://github.com/commaai/openpilot/pull/21845/files
If anyone is willing to do some testing that'd be great. @adidasboy517 @che220 @Smurf

Hi HaraldSchafer,
I am brand new to github.  I have the issue on my 2016 Civic.  I would be glad to load you change and test it but I don't know how.  If you can point me to where this is explained (load specified SW) I will do that..

@KevinYoung2 https://github.com/commaai/openpilot/wiki/Forks

Thank you!
From: grekiki @.>
Sent: Thursday, August 5, 2021 10:35 AM
To: commaai/openpilot @.>
Cc: KevinYoung2 @.>; Mention @.>
Subject: Re: [commaai/openpilot] Poor longitudinal tuning (#21697)
@KevinYoung2 https://github.com/KevinYoung2 https://github.com/commaai/openpilot/wiki/Forks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/commaai/openpilot/issues/21697#issuecomment-893653217 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVDG5JEQG745PGHLPZ7AZA3T3LDTVANCNFSM5A3MJOVQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .  https://github.com/notifications/beacon/AVDG5JABVYXYXKM4EBAMJ53T3LDTVA5CNFSM5A3MJOV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGVCBBYI.gif

I have looked at the link from grekiki above.  I created the following command:
https://smiskol.com/fork/github.com/commaai/openpilot/pull/21845/files
This seems to start the loading process.  I get the 'Installing Openpilot' screen with the comma and revolving circle.  But it never finishes.  I imagine there is something wrong with my command,  Can anyone tell me what the error is?
Thanks.

So what until now My problem hasn't been solved?!
#21803.

@Na112786 it's generally preferred to consolidate identical issues into one. Don't worry, this one hasn't been closed and your issue was linked.

https://github.com/commaai/openpilot/commit/a8f3e2b3c26f2b617a1c9c94250b44adce861d04
This should hopefully help with some Hondas. I was not able to test some, so any feedback is welcome.

Feedback,
Nothing change still same problem..
This my Dongle and serial number..

@Na112786 You are on release, which is the stabled released version of openpilot. The changes I made or only on openpilot master. So you would need to install master to test the fix.
https://github.com/commaai/openpilot/tree/master

😅 Firstly, am on release 2
Why u make it complicated, do it on release 2.
Secondly, I don't know how to install master?
Don't send link, just do it for me

That's not how the openpilot release process works. We develop on master and push to release when it is ready.
https://blog.comma.ai/a-2020-theme-externalization/
If you want to learn how this all works and how to switch to master you can do some reading, perhaps check out out discord https://discord.com/invite/avCJxEX
If you feel this is all too complicated I suggest you wait until fixes come to release.

@HaraldSchafer Tried master this afternoon on my drive in to work. As my car (2018 nidec civic) approached the setpoint speed it would start pumping the brakes repeatedly making it unusable, and I had to disengage.
For example, if I set it to 120 km/hr, it would get up to 119km/hr and then repeatedly pump the brakes making it unusable to drive with. (Wasn't aggressive but enough that you could feel it and enough that it was not "chill")
Thanks for taking the time to work out these issues

@madcapclover Can you provide a route or your dongleid? I'll investigate

@HaraldSchafer 41f056ee588d15d0 dongleid, thanks!

Looks like this got merged into master-ci today. I tested 0.8.8 master CI on a 2019 Honda Fit EX and can confirm that OP stays within 1mph of the set cruise.
However, when there is a lead car it seems highly reactive.
52f3e9ae60c0d886|2021-08-13--17-10-34
Shows this behavior towards the end of the drive. I am behind a pickup at around 30mph that is changing speed slightly, OP adjusts a bit much but the follow distance is much improved!

@madcapclover I see what you mean in the logs. Looking into it.
@Smurf I see what you mean. It looks like the car actually did what the planner wanted. The lead policy just needs to be a little more chill, not sure if I can fix by next release. Please let me know if you have more feedback and if you think it's a regression over current release. Ty!

Got to do some more testing at varied speeds today. At speeds of 40mph+ it seems to handle a lead car much better and it allows much more coasting than previous releases.
While I was able to feel the surging at low speeds while concentrating on the display I had a passenger today and they couldn't notice.

I loaded master-ci today and drove for about 20 miles.  2016 Civic.  It performed very well.  Only issue I observed was very active throttle response when following.  This occurred at 75, 65 and 55.  Maintained distance well, but throttle went idle to moderate power pretty often.

I just pushed some changes that should improve the coasting behavior and the pulsing at high speed when following a lead car.

I loaded master-ci today (I assume it had HaraldSchafer's above changes in), and drove for about 50 miles. 2016 Civic.  I think the pulsing when following was better than 2 days ago, but still not as good as the system of 2 months ago.  In all other aspects, system performance was very good.

@KevinYoung2 Yesterday's changes from master have not made it to master-ci yet. Master-ci still needs to be compiled. You can try master or wait until master-ci gets the updates today or tomorrow.

@HaraldSchafer OK!  I'm pretty much a neophyte here.  Not sure how to go to master.  Is it the same command only designate master instead of  master-ci?
If not I can just wait until it's in master-ci.  Can you tell me how to know if it's included?

@KevinYoung2 if you are ssh'd in you'd just have to checkout master, init and update submodules and then reboot. It'll take some time to compile.
git checkout master
git submodule update --init --recursive
sudo reboot

https://github.com/commaai/openpilot/tree/master-ci
You can just see when master-ci was last updated, which is yesterday, before I merged the changes

@HaraldSchafer Loaded master today and drove to work (100kms), all the pulsing is gone and feels smooth, about 3 car lengths between me and the lead car but overall much better than before, thank you!

@adeebshihadeh I was waiting to comment on this until my data was available (routes weren't fully uploading, that should be fixed), but with 0.8.8 my longitudinal control is the worst it's ever been, dangerous in some scenarios.  Still seeing the car not make it up to set speed in a variety of terrains, especially hills.  Lead car behavior is where the biggest problem is though.  It's had sluggish response in the last handful of versions, but with 0.8.8 it takes forever to start speeding up after lead car pulls away, and when coming up on a lead car with maybe a 10-15mph lower speed it attempts to drive right into the lead car with little discernible slowing.  It can see the car fine and even indicates that it's getting way too close.  Overall it feels like a control loop with a super slow response, and this causes the follow space to vary wildly unless the lead car holds constant speed for good amount of time.  I'll follow up with a route and dongle.
-Comma2
-Version: 0.8.8 stock, no pedal
-Car: 2020 Honda Odyssey

and when coming up on a lead car with maybe a 10-15mph lower speed it attempts to drive right into the lead car with little discernible slowing. It can see the car fine and even indicates that it's getting way too close. Overall it feels like a control loop with a super slow response

This sounds similar to what I experienced on another model (Freed).  But first, note that the regular Odyssey is not using the revised longitudinal control:
OLD_NIDEC_LONG_CONTROL = set([CAR.ODYSSEY, CAR.ACURA_RDX, CAR.CRV, CAR.HRV])

@tiki-bug do you have the ODYSSEY_CHN?  Please check the platform column in your useradmin routes list.

Have driven for 100 miles (2016 civic).  It has behaved very well.  No issues noticed.  I did not observe the same behavior as tiki-bug.

@belm0 That's a good catch, I had assumed that the long fix was applied across the board for hondas and that it was in 0.8.8 since it went to master a couple weeks ago, I guess only the second one is true?  And to answer your other question, no it's the ODYSSEY = "HONDA ODYSSEY 2018" not the ODYSSEY_CHN

@tiki-bug This PR applies the new control to the Odyssey. It would be great if you could try it and report any feedback. https://github.com/commaai/openpilot/pull/22104/files

@tiki-bug @belm0
Integrator windup was causing issues with braking. I tried to fix that in master
https://github.com/commaai/openpilot/commit/ebf2a2279d837feb3ce55a7bc44c7f0053e77f27
I also moved the odyssey to new control. If you guys could tell me if that fixed the issues, that'd be great.
It's on master now, will be in master-ci in a couple hours.

Thank you.  It may be a few days before I can try it on Freed.
Are you considering patching 0.8.8 once you get confirmation on the Odyssey?

@HaraldSchafer @adeebshihadeh
Loaded up master-ci for this morning's commute
Car: 2020 Honda Ody
Version: 0.8.9-master-ci
0a96f86fcfe35964|2021-09-03--07-28-57
Timestamp: 7:31:15 to 7:31:50
Short drive, but got some good surging data in some light hills around the max speed mark, shows up real well in AEgo
96f86fcfe35964|2021-09-03--07-42-14
Timestamps and details:
7:45:18 to 7:47:00 - Jerkiness from brake/accel/brake/etc. around max speed, esp. after transition to lower set speed, w/ and w/o lead car
7:50:50 to 7:51:10 - delayed sharp brake due to cut-in
7:52:00 to 7:52:30 - decent follow, when the lead car below max speed and making small changes in speed
7:57:34 to 7:57:45 - delayed second brake jab as cut-in leaves lane
8:01:01 to 8:01:31 - Surging accel to keep up with lead
8:01:55 to 8:02:15 - delayed sharp brake due to earlier cut-in
Overall I would say the long is significantly jerkier than previous builds but way safer than 0.8.8 release2. It's far more conservative on the follow distance and seems like it can come up to much slower/stopped cars again without driving through them. The jerky/surging behavior is new, and is enough to make the lateral control unstable in new places on slower roads (take pity on our hondas).  Seems like it doesn't want to coast at the set max speed, probably handles this a little better on the highway with the added drag.

@tiki-bug Definitely looks like some things are wrong. Best I can tell, it is not responding to the command that limits acceleration the way other Honda NIDECs seem to. I can help make your car great, but would need you to test some things to understand how the Odyssey is responding to commands, and why it is different. Best would be if you could message me on discord Torq_boi#2730, if you're not on discord :
https://discord.com/invite/avCJxEX

Closing this, most Hondas appear to be fixed. Moving Odyssey issue and discussion to here:
https://github.com/commaai/openpilot/issues/22146


Membership Event List Summaries (ie collapsing consecutive membership changed)

now we have FN membership syncing this is getting really important, as fun as it is to scroll through hundreds of joins/parts

Duplicate? https://github.com/vector-im/riot-android/issues/332

@devnoname120 Yes indeed. I knew I had seen this before. ;)

Another related issue: #1038

See https://github.com/vector-im/riot-meta/issues/20


All .arb translations files from CrowdIn have an invalid "@@locale": "en" and are not loaded

e.g.
l10n/intl_fr_FR.arb:
{
"@@locale": "en",
[..]
If this cannot be fixed in the CrowdIn setup, one option could be to have a script to fix the files, that we would run whenever we check-in new translations.

In fact when trying to switch to the new Flutter internationalization introduced in Flutter 1.22, I get this:
flutter pub get
The locale specified in @@locale and the arb filename do not match.
Please make sure that they match, since this prevents any confusion
with which locale to use. Otherwise, specify the locale in either the
filename of the @@locale key only.
Current @@locale value: en
Current filename extension: aa_ER
Generating synthetic localizations package has failed.
`````

I guess one option is just to remove the @@locale :)

Interesting, if I have one app_en.arb + app_fr_FR.arb, Flutter complains I don't have app_fr.arb
flutter pub get
Arb file for a fallback, fr, does not exist, even though
the following locale(s) exist: [fr_FR].
When locales specify a script code or country code, a
base locale (without the script code or country code) should
exist as the fallback. Please create a {fileName}_fr.arb
file.
Generating synthetic localizations package has failed.

For the record, in my other flutter projects I use simply one json translation file per language.
Something like that:
{
  "version": "version #versionNo#",
  "website_menu": "Website",
  "feedback_subject": "About the “#app#” app",
  "feedback_menu": "Contact us",
  "fallback_email": "No mail app found!",
  "fallback_url": "No web browser found!",
  "share_app_subject": "“#app#” app for smartphone and tablet",
...
}

Then, I just call something like AppLocalizations.of(context).translate('feedback_menu').
Et voilà !
No hassle. No pre-compilation. Parameters if I want. Just json files.
I haven't had a look at the new flutter way to deal with translations, but I doubt it can be much simpler than my version.

I use simply one json translation file per language.

Right, all the .arb files etc. certainly seem like overkill now. They'll be useful once we have a cool working app that we want to ship in 200 countries. When we add new translations then, using CrowdIn translators will be able to add them, and they won't have to use git.

I'm not against the concept of translations. I'm again painful processes, and I guess the CrowdIn process could generate json files. Such a suggestion, I won't fight about that.

I guess the CrowdIn process could generate json files.

It can, we use a json file through Crowdin for another sub-project: https://github.com/openfoodfacts/openfoodfacts-hungergames/blob/master/src/i18n/common.json
At this point I'm just trying to do whatever is the recommended way of doing things in Flutter, in the hope that it will be easier for newcomers going forward.
To be honest there are tons of things that I find painful in Flutter (like defining all those nested classes to read a JSON file instead of just accessing values with a syntax like some_hash{some_key}{some_other_key_for_an_array}[10]{another_key} like I'm used to do in Perl or JS). So I do find the internationalization things painful, but not more than the rest. :)

Of course I'm barely scratching the surface of discovering Flutter, so I'm sure there are good reasons for most of the things that I find painful, and hopefully they won't be painful once I understand more about how things work in Flutter.

Of course that's the normal way to access Map fields; I mean, in flutter/dart too.
I don't why in this project you have to declare the type of an empty List.
I highly recommend the flutter training by https://www.appbrewery.co (https://www.udemy.com/course/flutter-bootcamp-with-dart/?referralCode=2B7724A180C0502A2547)
For 12 euros...
Then you'll realize that the translation management is the only painful thing in flutter...
And I don't think there are good reasons for painful programing. For instance I would always discourage people from starting Android/java (Kotlin would be the same I guess).

I highly recommend the flutter training by https://www.appbrewery.co (https://www.udemy.com/course/flutter-bootcamp-with-dart/?referralCode=2B7724A180C0502A2547)

Thanks, I started it.

Fixed by PR https://github.com/openfoodfacts/smooth-app/pull/46


Possible IMDB parser needs updating, Please report on Github.

Since this morning (18/08/2018) around 01:00 (CEST) I got the following errors in flexget logfile while trying to parse the imdb_name using the IMDB parser, the following is just an example:
2018-08-18 12:49 VERBOSE  imdb_lookup   rss_download Parsing imdb for `Nelle pieghe del tempo 2018 iTALiAN AC3 BluRay 1080p x264-DSS
2018-08-18 12:49 ERROR    utils.imdb    rss_download Possible IMDB parser needs updating, Please report on Github.
2018-08-18 12:49 VERBOSE  imdb_lookup   rss_download Unable to set imdb_name for tt1620680 from http://www.imdb.com/title/tt1620680/

the error is thrown with every entry returned by all rss feeds.
I'm using Flexget: 2.14.16 (just updated from 2.13 to see if it was a recently fixed issue), installed using pip and using python 2.7.14 on Linux.
After a very quick look at the imdb.py module, it seems the imdb movie page actually changed, the plugin is looking for:
name_elem = title_overview.find('h1', attrs={'itemprop': 'name'})
but it seems no "h1" exists with "itemprop=name" attribute.

I'm having the same issue


[BUG] - DATEPICKER WITH INTERNALIZATION

NextUI Version
14.2.3
Describe the bug
When using Datepicker with I18nProvider, the Datepicker layout is bugged, as shown in the image
nextui version: 2.4.1

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Wrapper the datepicker with
Expected behavior
The layout adjusts itself
Screenshots or Videos
No response
Operating System Version
windows 11
Browser
Edge

Another bug that occurs is that when opening DatePicker sometimes, it goes to the previous year alone
https://github.com/nextui-org/nextui/assets/160622974/72ddac39-407c-474a-a3a7-af82b2a9f23a

please share a minimal reproducible project

Closing due to inactivity.


Infer target inputs from dependencies

It is currently possible to specify targets dependencies (other targets), inputs, and outputs.
However, it seems that, most of the time, a target has as inputs the outputs of its dependencies. This induces a lot of repetition in the Yaml configuration.
For instance:
https://github.com/fbecart/zinoma-node-example/blob/4412ec4166e8e4c709163353adad0acdfa3aafae/backend/zinoma.yml#L17-L22
https://github.com/fbecart/zinoma-node-example/blob/4412ec4166e8e4c709163353adad0acdfa3aafae/webapp/zinoma.yml#L25-L31
https://github.com/fbecart/zinoma-node-example/blob/4412ec4166e8e4c709163353adad0acdfa3aafae/zinoma.yml#L10-L15
It would be nice to have a way to easily add the outputs of the dependencies as inputs. Doing so entirely automatically probably not be accurate either, as, sometimes, a target depends only on a subset of the resources created by the targets it depends on.

Design suggestion
<target_name>::output would become a resource set, that can be used as the input for a different target.
Example:
targets:
  npm_install:
    input:
      - paths: [package.json, package-lock.json]
    output:
      - paths: [node_modules]
    build: npm install

  npm_test:
    input:
      - npm_install::output
      - paths: [package.json, src, test]
    build: npm run test

The input npm_install::output would be equivalent to having npm_install as a dependency + having its output as input.

We could also use another separator to avoid an ambiguous syntax. For instance:
    input:
      - npm_install.output


Create Coverity issue in ProcessInfo.cpp

Coverity Issue - Logically dead code
Execution cannot reach this statement: "buffer[index] = c;".
Medium Impact, CWE-561
DEADCODE
Issue location
This issue was discovered outside the diff for this Pull Request. You can find it at:
Source/core/ProcessInfo.cpp:555

Coverity Issue - Logically dead code
Execution cannot reach this statement: "buffer[index] = '\0';".
Medium Impact, CWE-561
DEADCODE
Issue location
This issue was discovered outside the diff for this Pull Request. You can find it at:
Source/core/ProcessInfo.cpp:573

Closing test PR


[PoC] Apply spell check to tutorials

Summary
Apply spell check to tutorials by sphinxcontrib-spelling. The output is as follows. The typos are fixed in #63.
https://sphinxcontrib-spelling.readthedocs.io/en/latest/
$ make spell
pylint -rn --disable=all --enable=spelling --spelling-dict=en_US --spelling-private-dict-file=.pylintdict qiskit_optimization test tools

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

make -C docs spell SPHINXOPTS=
Running Sphinx v3.5.3
Initializing Spelling Checker 7.1.0
loading pickled environment... done
Ignoring wiki words
Ignoring acronyms
Ignoring Python builtins
Ignoring importable module names
Ignoring contributor names
Adding contents of /Users/ima/tasks/1_2021/qiskit/opt/docs/spelling_wordlist.txt to custom word list
Adding contents of /Users/ima/tasks/1_2021/qiskit/opt/docs/../.pylintdict to custom word list
Looking for custom word list in /var/folders/vt/58nt4rrd4mz552nj2l96bbnm0000gn/T/tmpo6x_94fe/spelling_wordlist.txt
Scanning contributors
[autosummary] generating autosummary for: apidocs/qiskit_optimization.algorithms.rst, apidocs/qiskit_optimization.applications.rst, apidocs/qiskit_optimization.converters.rst, apidocs/qiskit_optimization.problems.rst, apidocs/qiskit_optimization.rst, index.rst, release_notes.rst, stubs/qiskit_optimization.INFINITY.rst, stubs/qiskit_optimization.QiskitOptimizationError.rst, stubs/qiskit_optimization.QuadraticProgram.rst, ..., tutorials/02_converters_for_quadratic_programs.ipynb, tutorials/03_minimum_eigen_optimizer.ipynb, tutorials/04_grover_optimizer.ipynb, tutorials/05_admm_optimizer.ipynb, tutorials/06_examples_max_cut_and_tsp.ipynb, tutorials/07_examples_vehicle_routing.ipynb, tutorials/08_cvar_optimization.ipynb, tutorials/09_application_classes.ipynb, tutorials/10_warm_start_qaoa.ipynb, tutorials/index.rst
building [mo]: targets for 0 po files that are out of date
building [spelling]: all documents
updating environment: 0 added, 8 changed, 0 removed
reading sources... [100%] tutorials/10_warm_start_qaoa
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/01_quadratic_program.ipynb:1021: Spell check: precicely: You can substitute some of variables with constants or other variables. More precicely, .
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/01_quadratic_program.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/02_converters_for_quadratic_programs.ipynb:256: Spell check: decimla: . Note that we cut off the part after the decimla point in the converted formulation since the left side of the first constraint in the original formulation.
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/02_converters_for_quadratic_programs.ipynb:256: Spell check: symol: can be only integer values. For the second constraint, basically we apply the same approach. However, the symol in the second constraint is .
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/02_converters_for_quadratic_programs.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/03_minimum_eigen_optimizer.ipynb:32: Spell check: refere: , which allows to replace the resulting spin variables by Pauli Z matrices, and thus, an Ising Hamiltonian. For more details on this mapping we refere to [1]..
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/03_minimum_eigen_optimizer.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/05_admm_optimizer.ipynb:70: Spell check: untill: , $) untill termination:.
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/05_admm_optimizer.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/06_examples_max_cut_and_tsp.ipynb:66: Spell check: Gutman:  (QAOA) by Farhi, Goldstone, and Gutman (2014). We frame the algorithm in the context of .
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/06_examples_max_cut_and_tsp.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/07_examples_vehicle_routing.ipynb:14: Spell check: Gutman: locations and back to the depot, so as to minimize vehicle-miles traveled, time spent, or similar objective functions. In this notebook we formalize an idealized version of the problem and showcase its solution using the quantum approximate optimization approach of Farhi, Goldstone, and Gutman (2014)..
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/07_examples_vehicle_routing.ipynb:87: Spell check: Gutman: Here, we demonstrate an approach that combines classical and quantum computing steps, following the quantum approximate optimization approach of Farhi, Goldstone, and Gutman (2014). In particular, we use the variational quantum eigensolver (VQE). We stress that given the use of limited depth of the quantum circuits employed (variational forms), it is hard to discuss the speed-up of the algorithm, as the solution obtained is heuristic in nature. At the same time, due to the nature and importance.
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/07_examples_vehicle_routing.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/09_application_classes.ipynb:9: Spell check: Optimziation: Application Classes for Optimziation Problems.
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/09_application_classes.ipynb:53: Spell check: maximimized: Given an undirected graph, find a partition of nodes into two subsets such that the total weight of the edges between the two subsets is maximimized..
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/09_application_classes.ipynb:61: Spell check: exacly: Given a graph, find a route with the minimum distance such that the route visits each city exacly once..
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/09_application_classes.ipynb:63: Spell check: Vechile: Vechile routing problem.
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/09_application_classes.ipynb:82: Spell check: introdcue: We introdcue examples of the vertex cover problem and the knapsack problem in this page..
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/09_application_classes.ipynb:84: Spell check: avaiable: Examples of the max-cut problem and the traveling salesman problem are avaiable in .
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/09_application_classes.spelling
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/10_warm_start_qaoa.ipynb:585: Spell check: gound: Next, we create the mixer operator for QAOA. When warm-starting QAOA we must ensure that the mixer operator has the initial state as gound state. We therefore chose the Hamiltonian.
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/10_warm_start_qaoa.ipynb:818: Spell check: computs:  which is illustrated below. This solver will solve a QUBO with a warm-start QAOA. It computs .
/Users/ima/tasks/1_2021/qiskit/opt/docs/tutorials/10_warm_start_qaoa.ipynb:818: Spell check: behaviour:  by relaxing the problem. This behaviour is controlled by setting .
Writing /Users/ima/tasks/1_2021/qiskit/opt/docs/_build/tutorials/10_warm_start_qaoa.spelling
writing output... [100%] tutorials/index
WARNING: Found 17 misspelled words
build succeeded, 1 warning.

Details and comments

Yes, spell check while editing is important. Which extension do you recommend?
As for the build time spell check, if other spell check tools of notebooks are available, I would like to discuss which to use.


Fix: Fixed issue where path name wasn't visible when grouping libraries by path

Resolved / Related Issues

[ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #8144...

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Open app ...
Click settings button ...

Screenshots (optional)
Add screenshots here.

LGTM except for one minor point.

Committed.

@ashrafmansuri thank you for contributing to Files.

@ashrafmansuri thank you for contributing to Files.

You're welcome. 😄


Shimmer network support

Adds support for shimmer network https://shimmer.network/
Marked as a legacy because of this issue: https://github.com/iotaledger/wasp/issues/3392

please update the spec by running cargo t --all-features
can't push myself because pr opened from main

Done


Add text-justify to responsive alignment classes

Hello,
Is there any reason why .text-justify isn't part of the responsive alignment classes?
It's also an alignment class, has the same CSS property and has !important, if you get to use, you'll not be able to adapt it.

CC: @mdo

Going to pass on this, thanks though! We don't need to have utilities for every property value, only the most common ones.


Invalid left-hand side in assignment

Describe the bug
I have no idea what is not working apart from its something to do with PostCSS??
Package.json
{
    "private": true,
    "scripts": {
        "dev": "vite",
        "build": "vite build"
    },
    "devDependencies": {
        "@vitejs/plugin-vue": "^3.1.2",
        "axios": "^0.27",
        "laravel-vite-plugin": "^0.6.1",
        "lodash": "^4.17.21",
        "vite": "^3.1.8",
        "vue-loader": "^17.0.0"
    },
    "dependencies": {
        "browser-sync": "^2.27.10",
        "dotenv": "^16.0.3",
        "secure-ls": "^1.2.6",
        "vue": "^3.2.36",
        "vue-persistedstate": "^1.2.5",
        "vue-router": "^4.1.6",
        "vuex": "^4.0.2",
        "vuex-persistedstate": "^4.1.0"
    }
}

vite.config.js:
import { defineConfig } from 'vite';
import laravel from 'laravel-vite-plugin';
import vue from '@vitejs/plugin-vue';

export default defineConfig({
    plugins: [
        laravel(['resources/js/app.js']),
        vue({
            template: {
                transformAssetUrls: {
                    base: null,
                    includeAbsolute: false,
                },
            },
        }),
    ],
});

app.vue:
<template>
      <div>
        <router-view></router-view>
      </div>
</template>

app.js:
import vue from '@vitejs/plugin-vue'
import App from './App.vue'
import router from './routes'
import store from './store'
import '../css/app.css';
import './bootstrap';

new vue({
      router,
      store,
      render: function (h) {
        return h(App)
      }
    }).$mount('#app')

Linked: Linked: https://stackoverflow.com/questions/70993897/vite-and-postcss-issue-invalid-left-hand-side-in-assignment
Reproduction
cant get that far
Steps to reproduce
npm run devnpm run devnpm run dev
System Info
OS X

Used Package Manager
yarn
Logs
no idea?
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hello @matthewhutchings. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

Cant make a public repo but can provide you with invite to ours.

Not sure if this is related:
vite v3.1.8 building for production...
✓ 187 modules transformed.
'resolve' is not exported by __vite-browser-external, imported by node_modules/vite/dist/node/constants.js
file: /var/www/html/node_modules/vite/dist/node/constants.js:1:15
1: import path, { resolve } from 'node:path';
                  ^
2: import { fileURLToPath } from 'node:url';
error during build:
Error: 'resolve' is not exported by __vite-browser-external, imported by node_modules/vite/dist/node/constants.js
    at error (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:1858:30)
    at Module.error (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:12429:16)
    at Module.traceVariable (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:12788:29)
    at ModuleScope.findVariable (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:11440:39)
    at Identifier.bind (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:7439:40)
    at CallExpression.bind (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:5269:23)
    at CallExpression.bind (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:8935:15)
    at VariableDeclarator.bind (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:5269:23)
    at VariableDeclaration.bind (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:5265:73)
    at Program.bind (file:///var/www/html/node_modules/rollup/dist/es/shared/rollup.js:5265:73)
root@0ade5d8020da:/var/www/html#

Vite is shite so far!

Now:
root@0ade5d8020da:/var/www/html# npm i vitejs/plugin-vue
npm ERR! code 128
npm ERR! An unknown git error occurred
npm ERR! command git --no-replace-objects ls-remote<EMAIL_ADDRESS>npm ERR! Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
npm ERR<EMAIL_ADDRESS>Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-10-24T14_57_17_231Z-debug-0.log

Would reccomened avoiding vite and using mix: https://github.com/laravel/vite-plugin/blob/main/UPGRADE.md#migrating-from-vite-to-laravel-mix

You are importing the Vite plugin in app.js:
import vue from '@vitejs/plugin-vue'

Import vue instead:
import vue from 'vue'

According to official documentation, it should be vitejs/plugin-vue
https://laravel.com/docs/9.x/vite#vue

According to official documentation, it should be vitejs/plugin-vue
https://laravel.com/docs/9.x/vite#vue

According to official documentation, it should be vitejs/plugin-vue
https://laravel.com/docs/9.x/vite#vue

You are importing the Vite plugin in app.js:
import vue from '@vitejs/plugin-vue'

Import vue instead:
import vue from 'vue'

According to official documentation, it should be vitejs/plugin-vue
https://laravel.com/docs/9.x/vite#vue


CR-01 Missing Inbound Messages Authentication

The methods process_inbound_messages() used by signer and coordinator do not
authenticate the data received. So while signers and the coordinator sign the messages
they send, the signature is not checked (neither by signers nor coordinator) within the
library and the responsibility is left for the implementers.

The two relevant applications stacks-signer and sbtc-signer handle this out of scope of the library for a variety of reasons.
stacks-signer runs both the Signer and Coordinator state machines, so it checks the signature is good and came from the signer specified in  the packet.msg.  Checking the signatures inside the application would require double the work.
sbtc-signer does not actually use the wsts::net::Packet structure, or its signatures.  It has its own network packet/message format, and embeds the wsts::net::Message enum directly in one of its message types.  These messages are signed at the network layer, and there is code which checks that the wsts::net::Message signer_id owns the key which validates the signature.
Having said that, I do have a branch which implements library layer authentication for both Signer and Coordinator state machines.  It was just low priority given that it was unsuitable for the existing and planned applications.


[!!!][BUGFIX] Set permissions correctly

The change will allow graceful fallback to the default bucket
permissions for new objects to avoid users not being able to
operate on file ACLs via other tools (for example gsutil or
the cloud console).
It also removes the semantics of private and publicRead
CloudStorage API predefined ACLs in favour of default bucket
permissions and properly created additional ACLs on
visibility change.
Fixes: #3

Thanks.  We'll take a look at this shortly.

I have ameded the changeset to your suggestions. Please let me know if I got everything right.

All the changes look good, can we just use an if-else here please, so it reads a bit better.
Something like
if ($originalVisibility === AdapterInterface::VISIBILITY_PUBLIC) {
    $this->publishObject($newpath);
} else {
    $this->unPublishObject($newpath);
}

:+1: after that

Ah I missed / misinterpreted that one. Done. :)

Awesome, thanks. :+1:.
There are just some minor linting issues, but I'll take care of those.

Thanks for taking care! :)
Suggestion: Make Code Style issues fail the build, as a contributor I'd be glad about it.

My pleasure. :)
I agree. Scrutinizer is supposed to lint it after a travis build, but it doesn't seem to be complaining, but I'll look into it tomorrow, before we do a release.


In light of changes to Twitter's API coming Feb 9

I guess adding scraping capabilities to the bot has become a priority.
Using RSS feeds as a source will hopefully continue to work after February 9th (if you can find a working Nitter instance, RSSHub or some other third-party site that's still able to generate an RSS feed).

Hello, I'm using your script for some days and I do agree your statement.
I was wonderring about the support of the Twint python library (https://github.com/twintproject/twint), wich is capable to scrap Twitter content. Could be a good start to add this support.

Just to confirm, if you get a paid access to the Twitter API, you theoretically still can use it as is right @robertoszek ? Providing you use a valid Twitter token of course.

Just to confirm, if you get a paid access to the Twitter API, you theoretically still can use it as is right @robertoszek ? Providing you use a valid Twitter token of course.

Potentially, yes.
Assuming they don't change the baseline API endpoints behavior or add additional steps to authenticate with a paid token, the bot would theoretically continue to work.
The thing is nobody really knows how's it going to change or be implemented.
We'll have to wait until the 9th and see once the dust settles what are our options going forward.

As a potential replacement, this scrapper seems good, to, and quite light : https://github.com/JustAnotherArchivist/snscrape
It's working great, today.

As a potential replacement, this scrapper seems good, to, and quite light : https://github.com/JustAnotherArchivist/snscrape It's working great, today.

It seems to use the unofficial GraphQL endpoint for scraping data:
https://github.com/JustAnotherArchivist/snscrape/blob/23ebdd2a3ce6c3e93012e2b5bc7c2b02c749aaf2/snscrape/modules/twitter.py#L1704
In addition to https://api.twitter.com/2/search/adaptive.json:
https://github.com/JustAnotherArchivist/snscrape/blob/23ebdd2a3ce6c3e93012e2b5bc7c2b02c749aaf2/snscrape/modules/twitter.py#L1549
We already use https://api.twitter.com/2/search/adaptive.json with guest tokens on the bot currently:
https://github.com/robertoszek/pleroma-bot/blob/9a64891385d8321a84c37f3fba1fba6bd7b785ee/pleroma_bot/_twitter.py#L565
However the adaptive.json endpoint was severely limited recently (to only top results for non logged in users, removing any option to scrape by latest).
I'll look into how feasible would be to use the GraphQL endpoint for our own scraping too.

Using snscrape, I just did a request to get last 100 tweets for a specific Twitter user (@transportsidf), it worked well. So I don't know what are the limits, but if we can get at least 100 tweets at time, it seems enough for a bot, I think.
But, using Plroma in guest mode, gives me this error (same Twitter account) :
`Gathering tweets... 0
✖ 2023-02-04 21:17:59,995 - pleroma_bot - ERROR - Unable to retrieve tweets. Is the account protected? If so, you need to provide the following OAuth 1.0a fields in the user config:

consumer_key
consumer_secret
access_token_key
access_token_secret (cli.py:645) `
Should I use my API credential and it's working fine. I don't know if I do something wrong or a limitation/change in how guest mode works.

I guess adding scraping capabilities to the bot has become a priority.

As a bridge solution, maybe pleroma-bot could scrape a Nitter instance? I'd be happy to set up a Nitter instance for my own pleroma-bot to scrape.
Then there's https://github.com/zedeus/nitter/issues/389

Looks like it's finally here https://tapbots.social/@paul/110109551743991074

We just saw our access revoked overnight :/

Same here, it finally stopped working yesterday. I’ll need to start experimenting with using RSS via Nitter.

My API key switched back to free plan so I can't extract tweets anymore, too.
As I previoulsy mentionned, snscrape is also still working to retrieve tweets.

I switched to using rsshub, tried nitter but that was very buggy. I think adopting the full graph endpoints would be the best path forward.

This one, very simple, is working, too : https://gitlab.com/jeancf/twoot

@robertoszek any chance of future developpments to handle the end of the free API using one of the above solutions ?

rsshub isn't perfect either, html ends up being embedded:

I'm also having problems with twitter api. My bots are no longer working and I can't make it work with RSS source.
I've found a python scrapper for nitter called pnyter and I'm starting to explore it to see what I can do.
I've created a matrix channel in case anyone wants to join and exchange ideas #pletomabot:matrix.org https://matrix.to/#/!DmKYBjBcZXoeKlRmMU:matrix.org?via=matrix.org

Hello @AltGrCarlos the main problem here is that the creator of this bot is not active in the current time to make the necessary fixes. I would say 75% of the code is still working, and this bot is doing more than a simple scraper : it also updates the user profile, wich is great, and post tweets to mastodon.
So the part needing a fix is the scrape from Twitter part. Everything else can be kept as-is.
If you could create a fork with an upadated and fonctionnal scrapper, that would be great.
PS : I don't know about Matrix, in term of live chatting Discord must be more used.

Waiting for a fix to make Pleroma work again, I have set Twoot (previously mentionned) as replacement. It's working fine without API key.

After last week's API changes breaking nitter, I'm now using https://github.com/12joan/twitter-client to generate RSS for stork.
Just so you know stork is still working and still useful.  :-)
It'd be nice if I could find some way to get profile updates happening while still getting the tweets from RSS; I'll post here again if I figure out a way to do that.

Hey, sorry for being a lot less active.
I've been moving across countries during the last 6 months and between all the logistics and bureaucracy involved (getting a visa, a work permit, finding an apartment, packing, etc.) in addition to keeping a day job, it basically left little to no time to do anything else.
I'm glad this project was still somewhat useful for some of you during that time with the scraping functionality implementation still pending.
My intention is to get back to it and try to make it work in the current state of affairs.
Thank you all for sharing the different projects you've found success with, I'll take a look at their approach and see what works and doesn't at the moment.

Got profile info and pinned tweet gathering working. https://github.com/robertoszek/pleroma-bot/commit/c96943e6e6cdcd4725d118589686d5282197265e
The user timeline scraping seems a lot more involved, requiring "guest accounts".
These guest accounts seem to be restricted by IP, so only a limited amount can be created from the same host/IP.
I'm thinking about adding a flag so they can be created easily on demand:
$ pleroma-bot --create-guest-account

being dumped to guest_accounts.json, for example.
And if you have access to a list of proxies that could be used to generate more accounts at the same time, perhaps passing them as a text file (by a flag or on the config file):
$ pleroma-bot --create-guest-account --proxies-file my_proxies.txt

And of course the bot would also need to try generating additional guest accounts in the middle of a run if it gets rate limited.
I need to think about it a bit more but there's definitely some progress being made.

I have ~50 accounts in my config and run an pleroma-bot every 15 minutes against a nitter rss feed right now as a workaround. The guest accounts last for 30 days and I've ended up needing ~6k guest accounts to keep it running the whole time without erroring out. I use geonode for proxies FYI.


Womanium Final Assignment - Shreya Rajpal

PR Description
This Pull Request introduces a series of quantum functions designed to facilitate a quantum walk on a linear graph with 16 nodes, implementing essential operators like the Coin and Shift operators which are critical for simulating quantum walks in quantum computing environments.
Some Notes

[x] Please make sure that you placed the files in an appropriate folder.
[x] Ensure that the files have indicative names.
[x] Please note that Classiq runs automatic code linting, which may minorly alter some files.

Good job!
Score: 8/10.


Surprising reformatting of [0][0]

Input:
is_view = bool(
    list(
        self.execute(
            name,
            "SELECT count(*) from sqlite_master WHERE type = 'view' and name=:n",
            {"n": table},
        )
    )[0][0]
)

Output:
is_view = bool(
    list(
        self.execute(
            name,
            "SELECT count(*) from sqlite_master WHERE type = 'view' and name=:n",
            {"n": table},
        )
    )[
        0
    ][
        0
    ]
)

Verified just now using https://black.now.sh/ which says it's running v18.4a4

Should be fixed on master.


Fix bug Heatmap

Hi, after read the R version plot_heatmap, I found a difference in python code. Should take pvals[11:] rather than pvals[12:](first cell-cell interaction in pvalues.csv would be dropped if take [12:]). And I made my code more readable. Could you run a test on this?

I'll check the report

👍🏻


Host toolchains_llvm

Asking to move github.com/grailbio/bazel-toolchain to github.com/bazel-contrib/toolchains_llvm.
Criteria check:

Uses Apache 2.0 license
Used widely in the community.
I can be the point of contact for the SIG.
Code is production quality, and is used by many orgs:

clear README is included.
API documentation; currently only in-code and not generated separately, but in a state where generation should be easy.
examples of use are provided through tests and within documentation.
Continuously tested for every PR and periodically.

Issues and PRs are addressed by members in the community. I can take an active role in triaging these, going forward.
Multiple people participate in PR reviews and merges

Can formalize this as a CODEOWNERS file after the move.

Release versions are semver.
Can support all Bazel LTS going forward, but community prefers to drop support for non-current versions to keep things simple.
Rules are already published to BCR and CI is green.

Some original discussion in https://bazelbuild.slack.com/archives/CDCMRLS23/p1707157866988289.

Could you nominate who should be the other folks that end up in the CODEOWNERS file? I think we want their consent to this before approving.
Maybe @jsharpe or @fmeum is interested?

Yes, either or both of these would work. Also, @rrbutani, would you be open as well?

Absolutely!

If you need more codeowners, feel free to add me as well.

This is amazing @siddharthab. Grail's llvm toolchain has always been the reference implementation for me.
Thanks a ton for doing this. 🙏

Yes, I'm happy to be listed on CODEOWNERS if needed.

Discussed at Bazel Rules Author SIG meeting and approved by those present.

Thank you. I have asked the org admins at github.com/grailbio for a final check. It might take some time.

The transfer is now done. I will set up some branch protection rules, etc. to enforce code reviews and other best practices. Please feel free to close this issue, or let me know if you see something missing.


support https in download API

this brings the download API in line with the other http / grpc apis.

blocked on #254


Show available Kubernetes context for uploaded kubeconfig.

Current Behavior

When a kubeconfig is uploaded, meshery tries to connect to all available k8s_contexts.
Desired Behavior

When a kubeconfig is uploaded, instead of directly trying to connect to all, respond with available Kubernetes context in the kubeconfig and let the user choose which context to connect to.
(Bonus: Report back with connectivity status  for the available contexts inside the kubeconfig).
Implementation

Acceptance Tests

Mockups

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@zakisk Will you do the backend part and @UsmanDev09 the fronted part?

Sure @MUzairS15, Thank you.

@zakisk please let me know when you are done with the backend.

@MUzairS15 I have to make changes in kubernetes/register endpoint to return available contexts, yeah?

@MUzairS15 and I need to create a new endpoint to connect to a context?

@UsmanDev09 yes

@Freedisch Can you take this up?

@MUzairS15, sure I'll dive in it

Completed


Add OneShard page

Thank you for doing all my work, but would have done it. I just did not know that the PR was created.


'Server' object has no attribute 'close'

In the asyncio example, a close method is called on a Server object, but Server has no such method:
https://github.com/bmuller/kademlia/blob/python3.5/examples/example.py#L30
Also, does it perhaps make more sense to call server.close() and loop.close() in a finally clause of the try block at the end there?

Thanks @jMyles - fixed now!


[onTurnError] unhandled error: Error: getaddrinfo ENOTFOUND https https:443

@Narayan22
We need more info that this.
Please give the following information:

[ ] What language are you using?
[ ] What channel are you testing in?
[ ] Which sample are you using?
[ ] What steps did you take before you get this error?

If possible, the fastest way to a resolution is to post a link to your own repository where you have a reproduction of the issue.

Thanks for the reply. but I slove the error just remove https in .env file hostname.


[BUG] [1.12] Inventory/chat player visibility when against a wall

When Shoulder Surfing, if you have your back against a wall, it automatically hides your player to allow for better vision, a fantastic feature. However, if you then are in your inventory or typing in chat, your player becomes visible again. This is irritating if you want to see when organising pots/food in your inventory mid fight and you are in a corner or something.
To reproduce simply go into Shoulder Surfing mode from behind the player and back up to a wall. Press E or T.
Bug occurs with latest version of Shoulder Surfing in Minecraft 1.12.

I dont see a reason to make this a config option but you can do it on your own as follows:
Prerequisites

Install Java 8 Development Kit  and add it to the PATH environment variable
Install git

Build
Open a terminal and run the following commands:

https://github.com/Exopandora/ShoulderSurfing.git
cd ShoulderSurfing
git checkout 1.12.2
Remove && Minecraft.getMinecraft().currentScreen == null from line 58 in src/main/java/com/teamderpy/shouldersurfing/event/ClientEventHandler.java
Linux: gradlew build
Windows:gradlew.bat build

You may have to run gradlew setupDecompWorkspace before the last command.


add link to CNERG Google Meeting room.

I think this is correct - I've lost the old file in my dramatic publishing of the new site.

I'm not really sure how to test this other than just pushing it...

I'm not really sure how to test this other than just pushing it...

looking good.
I left this be because I was unsure if I should just merge it.... will do and see what happened :)

looking good.
I left this be because I was unsure if I should just merge it.... will do and see what happened :)


Adding missing track configs.

Config options were missing for some of the DLC circuits in Assetto Corsa Competizione.
Added:
-COTA
-Indianapolis
-Red Bull Ring
-Watkins Glen

Are the DLCs downloaded by default?

DLC would be needed client side to join the session, but server side all tracks are included.


Pub/Sub: add wrangler pubsub commands

This PR adds support for Pub/Sub (https://developers.cloudflare.com/pub-sub/) via a new wrangler pubsub command group.

[x] Finalize MVP tests
[x] Add beta caveat / notice (?) ala pages - e.g. Pub/Sub is in private beta. See https://developers.cloudflare.com/pub-sub for details on how to get access to Pub/Sub
[x] Bikeshed over API naming conventions
[x] @oliy to sign off as ~co-conspirator~ eng lead for Pub/Sub.

Rebased against master and fixed all of the merge conflicts.

@rozenmd - done:

index.tsx now imports pubsubCommands: export function pubSubCommands(pubsubYargs: Argv, subHelp: CommandModule): Argv
All the commands are isolated in pubsub-commands.tsx
API functions remain in pubsub.ts

Addressed comments. Tests continue to pass.
@rozenmd / @threepointone / @petebacondarwin  - this is ready for review and (ideally) merge.
If we can also get a new Wrangler point release that includes this new surface it'd be great: we want to make sure our docs recommend users "install or upgrade to Wrangler version <X.y.z.> to use the new pubsub commands" so that they aren't wondering why their version doesn't have them.

If you run cd packages/wrangler && npm test -- -u, it'll update the snapshots and pass tests, happy to review, stamp and merge right after!

It looks like you've committed a folder from a previous version of the repo, specifically the examples folder. Delete that?

I'm going to try pushing commits to your branch to see if I can help out here.

Shipped! Available in wrangler@beta, and will be included in the next release 2.0.16

Thanks @threepointone!


Typo "@replicate_ddl"→"@replicate_ddl"

Bold with escape characters
https://docs.microsoft.com/sr-latn-RS/sql/relational-databases/replication/publish/replicate-schema-changes?view=sql-server-2014

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Doc: people are confused if they only import resources created in CDK

Problem
Many of the SST construct examples has an importing example. For example, for AppSyncApi there is an example Importing an existing GraphQL Api that says Override the internally created CDK GraphqlApi instance.
A user was confused if one can only import an Api created using CDK:

Hey – is there a way to import an existing AppSync API to SST that was created via Cloudformation (by way of serverless framework)? I noticed the docs only show such for AppSync created by CDK.

Solution 1
Mention in all example: Instead of creating a new GraphQL Api, you can import one that's been previously created.
Solution 2
new Api(this, "Api", {
  httpApi: Api.importHttpApiFromApiId(httpApiId),
  routes: {
    "GET /notes": "src/list.main",
  },
});

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Update nodejs and npm version to fix build error under WSL

What changes are proposed in this pull request?
Update nodejs and npm version to fix build error under WSL.
Why are the changes needed?
fix #14461.
Does this PR introduce any user facing changes?
No user facing changes.

Codecov Report

Merging #14462 (73a66da) into master (f24cc71) will decrease coverage by 19.86%.
The diff coverage is 74.02%.

@@              Coverage Diff              @@
##             master   #14462       +/-   ##
=============================================
- Coverage     35.49%   15.63%   -19.87%
+ Complexity     7672     2062     -5610
=============================================
  Files          1493     1250      -243
  Lines         87361    70516    -16845
  Branches      10420     8589     -1831
=============================================
- Hits          31012    11023    -19989
- Misses        53747    58845     +5098
+ Partials       2602      648     -1954

Impacted Files
Coverage Δ

...n/src/main/java/alluxio/metrics/MetricsSystem.java
0.00% <0.00%> (-61.45%)
:arrow_down:

...in/java/alluxio/master/AlluxioExecutorService.java
12.50% <12.50%> (ø)

...in/java/alluxio/master/ExecutorServiceBuilder.java
78.37% <78.37%> (ø)

...common/src/main/java/alluxio/conf/PropertyKey.java
97.86% <100.00%> (-1.58%)
:arrow_down:

...main/java/alluxio/master/job/plan/PlanTracker.java
66.27% <100.00%> (ø)

...common/src/main/java/alluxio/grpc/GrpcService.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...common/src/main/java/alluxio/time/TimeContext.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mmon/src/main/java/alluxio/metrics/MetricInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mmon/src/main/java/alluxio/time/ThreadSleeper.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/concurrent/LockMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 822 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a7738...73a66da. Read the comment docs.


add a new peerconnection provider, BridgingPeerConnection, for negotiation and backwards compatilbity

Roughly, this implements the proposal from the associated issue:
https://github.com/uProxy/uproxy/issues/1433
There is a bunch of stuff concerning batching of signalling messages but, really, the key part of all this is BridgingPeerConnection.handleSignalMessage which looks for a supported provider in the signalling message and answers accordingly. I think studying that along with the signalling messages definitions should explain all this. I'd be very interested to discuss a likely scenario you think this can't support.
An immediate followup will be to "pass through" legacy signalling messages, to support older clients. As we've discussed, it's not worth going to the trouble of supporting old one-time connections.
Tested with the sample apps and with uProxy; in-progress switchover here (I haven't touched one-time connections yet):
https://github.com/uProxy/uproxy/compare/trevj-bridge?expand=1

Small update: since BridgingPeerConnection handles batching (kinda) sensibly, copypaste can be simplified a little.

It seems like a lot of the complexity here is designed to handle compatibility with the current signalling.  I think it would help to have more comments explaining the motivation for various bits ... or just roll the passthrough into this pull request.

Review status: 0 of 10 files reviewed, 10 unresolved discussions, all commit checks successful.

src/bridge/bridge.ts, line 61 [r1] (raw file):
Any reason not to make this a map from names to signals?  I  think that would be more elegant

src/bridge/bridge.ts, line 75 [r1] (raw file):
Is this only optional for legacy compatibility?  Worth a comment.

src/bridge/bridge.ts, line 106 [r1] (raw file):
Good place for providers.forEach

src/bridge/bridge.ts, line 108 [r1] (raw file):
What is this for?  Is it for handling legacy signals?  That's not actually implemented right?

src/bridge/bridge.ts, line 127 [r1] (raw file):
Good place for providers.find

src/bridge/bridge.ts, line 171 [r1] (raw file):
This is slightly problematic.  If Alice is unable to reach the STUN server, and doesn't have a public IP address, it might be that she has no sensible public endpoint.  This does not mean that the connection must fail, if Bob has full-cone NAT or better.
Currently we send a local network IP address as the public endpoint, even though this will never work (except when Alice and Bob are on the same LAN).  This is a fine behavior, but it would be nice not lock ourselves into it, which this would do.

src/bridge/bridge.ts, line 332 [r1] (raw file):
establishing setting

src/bridge/bridge.ts, line 397 [r1] (raw file):
Good case for provider.signals.forEach.

src/bridge/bridge.ts, line 413 [r1] (raw file):
Should probably check this.state_ to throw or reject an appropriate error.

src/samples/copypaste-socks-chromeapp/main.core-env.ts, line 140 [r2] (raw file):
Too many des.  Maybe you mean "parse"?

Comments from the review on Reviewable.io

Thanks for the detailed review. Working on pass-through now, then please PTAL.

Review status: 0 of 10 files reviewed, 9 unresolved discussions, some commit checks pending.

src/bridge/bridge.ts, line 61 [r1] (raw file):
Ah...yes, of course. Done.

src/bridge/bridge.ts, line 75 [r1] (raw file):
My stubby mindset tells me required fields are (considered) harmful.

src/bridge/bridge.ts, line 106 [r1] (raw file):
N/A

src/bridge/bridge.ts, line 108 [r1] (raw file):
N/A

src/bridge/bridge.ts, line 127 [r1] (raw file):
Or a map :-)

src/bridge/bridge.ts, line 171 [r1] (raw file):
As discussed, let's not have the bridge do batching upfront. It complicates the design significantly, is error-prone, and is only for use in copypaste scenarios.
I didn't change the message type so anyone using the bridge is free to aggregate signalling messages into one giant messagem if they so wish. Most users won't need to do it, though.
Thanks for the suggestion.

src/bridge/bridge.ts, line 332 [r1] (raw file):
Done.

src/bridge/bridge.ts, line 397 [r1] (raw file):
Done.

src/bridge/bridge.ts, line 413 [r1] (raw file):
Done.

src/samples/copypaste-socks-chromeapp/main.core-env.ts, line 140 [r2] (raw file):
Done.

Comments from the review on Reviewable.io

Review status: 0 of 10 files reviewed, 3 unresolved discussions, some commit checks broke.

src/bridge/bridge.ts, line 67 [r3] (raw file):
Is there something you imagine including here someday other than signals?  If not, maybe we can collapse this interface and remove a layer of nesting.

Comments from the review on Reviewable.io

I've added passthrough support. PTAL!

Review status: 0 of 10 files reviewed, 3 unresolved discussions, some commit checks pending.

Comments from the review on Reviewable.io

BTW, tested with two copypaste instances, and ./bin/connect-pair.py:

giver is built from HEAD
getter is built from this client

Review status: 0 of 10 files reviewed, 3 unresolved discussions, some commit checks pending.

Comments from the review on Reviewable.io

PTAL!

Review status: 0 of 9 files reviewed, 3 unresolved discussions, some commit checks pending.

src/bridge/bridge.ts, line 66 [r3] (raw file):
Yes, although that something doesn't have to go here.
Done, because I also think it will be easier to aggregate batches of signals into one SignallingMessage if signals is a map from string to Object[].

Comments from the review on Reviewable.io

Review status: 0 of 9 files reviewed, 6 unresolved discussions, all commit checks successful.

src/bridge/bridge.spec.ts, line 10 [r4] (raw file):
Delete?

src/bridge/bridge.ts, line 4 [r4] (raw file):
Delete?

src/bridge/bridge.ts, line 19 [r5] (raw file):
"and will pair with any supported provider" ... I think I understand this but it took me a while.  How about "will accept an offer from any ..."?

src/bridge/bridge.ts, line 21 [r4] (raw file):
I think this might be clearer as export var best = basicObfuscation.

src/simple-socks/freedom-module.ts, line 34 [r5] (raw file):
This comment is confusing now.

src/socks-to-rtc/socks-to-rtc.ts, line 103 [r5] (raw file):
Why is this still here?  Is it because SocksToRtc is always the offerer?  Should this be changed to a list of the remote side's supported providers instead?

Comments from the review on Reviewable.io

Review status: 0 of 9 files reviewed, 6 unresolved discussions, all commit checks successful.

src/bridge/bridge.spec.ts, line 10 [r4] (raw file):
Done.

src/bridge/bridge.ts, line 4 [r4] (raw file):
Done.

src/bridge/bridge.ts, line 19 [r5] (raw file):
Done.

src/bridge/bridge.ts, line 21 [r4] (raw file):
Done.

src/simple-socks/freedom-module.ts, line 34 [r5] (raw file):
Changed, and for copypaste SOCKS.

src/socks-to-rtc/socks-to-rtc.ts, line 103 [r5] (raw file):
Yes. It's not needed on the RtcToNet side anymore.
As for changing it, we undoubtedly will in the future but I just didn't have a great idea as to what it should be.

Comments from the review on Reviewable.io

Review status: 0 of 9 files reviewed, 3 unresolved discussions, some commit checks pending.

src/bridge/bridge.ts, line 16 [r5] (raw file):
I still don't get it.  I think it's because you're using "pair" to mean "answer", but I think "pair" means "offer and answer".

src/simple-socks/freedom-module.ts, line 34 [r5] (raw file):
I mean the comment on this line
rtcNet.startFromConfig({ allowNonUnicast: true }, pcConfig); // obfuscate

src/socks-to-rtc/socks-to-rtc.ts, line 103 [r5] (raw file):
OK, please add a TODO explaining why it's asymmetric and describing how it's likely to evolve.

Comments from the review on Reviewable.io

:+1:

Review status: 0 of 9 files reviewed, 3 unresolved discussions, some commit checks pending.

Comments from the review on Reviewable.io

Review status: 0 of 9 files reviewed, 3 unresolved discussions, some commit checks pending.

src/bridge/bridge.ts, line 16 [r5] (raw file):
Oh. Sorry, I thought it was obvious from the context.

src/simple-socks/freedom-module.ts, line 34 [r5] (raw file):
Done.

src/socks-to-rtc/socks-to-rtc.ts, line 103 [r5] (raw file):
Done, for likely-to-change signatures. Regarding asymmetry of parameters, that's just something I'd prefer newcomers to the code never have to think about. Hopefully it's only noteworthy to us, being familiar with the old code.

Comments from the review on Reviewable.io


Add support for using

Browsers render the contents of <single-spa-router> by default, which is undesireable. That element is used to generated the routes, but shouldn't be rendered by the browser. Up until now, I've been using display: none as a workaround for this:
https://github.com/react-microfrontends/root-config/blob/7c4c143058aeeeedee07634fcbca20d91db1ba99/src/index.ejs#L25
However that looks a bit clunky and I think a more obvious solution is two wrap it in a <template> since those are hidden by the browser by default (except IE11, where you'll still have to do display: "none"
<template id="single-spa-layout">
  <single-spa-router>
  </single-spa-router>
</template>

In this case, document.querySelector('single-spa-router') will return null, since the contents of template elements are in a separate document fragment. Instead, to get the single-spa-router element you have to do constructRoutes(document.querySelector('#single-spa-layout').content.querySelector('single-spa-router')). However, that's a bit confusing/clunky as a public API, and gets harder since IE11 doesn't support the content property. So instead of requiring users to do that, I'm thinking we should support passing in a template object directly into constructRoutes: constructRoutes(document.querySelector('#single-spa-layout'))
This PR makes that possible.

Looks good to me.


[SPARK-13656][SQL] Remove spark.sql.parquet.cacheMetadata in SQLConf

What changes were proposed in this pull request?
Remove spark.sql.parquet.cacheMetadata because most of users do not use this.
It is okay to always enable caching mechanisms in ParquetRelation.

Test build #52652 has started for PR 11576 at commit 6332f94.

Test build #52652 has finished for PR 11576 at commit 6332f94.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52652/
Test PASSed.

@yhuai Could you check this?

I'm actually not sure it is OK to completely remove this ...

Any possible case these metadata caches causing some problems?

I think it is a problem when the underlying files change.

Oh, I see. However, I think it is slightly difficult for users to notice this option in that case (the option is true by default). How about automatically detecting the case?

Yea I think evenutally it might make sense -- but one problem is that it is very expensive to detect this, especially when there are a very large number of files, which is also common.

Yes, ... Scanning all files are pretty expensive though, we can add a metadata file for detecting it;
when DataFrameWriter writes something in the files, it updates the metadata.
Then, ParquetRelation checks the metadata to detect updates.

Test build #52876 has started for PR 11576 at commit 6332f94.

@maropu Sorry. My bad. I think we cannot remove this conf right now since it still affects the behavior of SqlNewHadoopRDD. I will close the JIRA.

But, our behavior is still pretty weird. Although SqlNewHadoopRDD uses this conf, we actually does list files when this conf is false. But, looks like the input file paths are all coming from the cache in HDFSFileCatalog. Since we are working on a major improvement on the data source part (https://issues.apache.org/jira/browse/SPARK-13664), let's revisit this issue later.

Test build #52876 has finished for PR 11576 at commit 6332f94.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52876/
Test PASSed.

Merged build finished. Test PASSed.

@yhuai oh, I got you. I'll close this for now and keep an eye on this.


No hard dependency to WCMUse

for now dependency is hardcoded, this basically should be configurable (for example to see simple Use classes).

WCMUse is no longer valid in AEM 6.3 so SightlyBeanFinderImpl.java is failing because of this API. Can this be updated to WCMUsePojo?


NestedJsonProvider - unable to omit empty nested field

Most JsonProviders omit writing their field(s) if their value is null (absent). This is however not the case for the NestedJsonProvider. Consider the following configuration:
<providers>
   <nestedField>
      <fieldName>nested</fieldName>
      <providers>
         <mdc/>
      </providers>
   </nestedField>
</providers>

This configuration produces a JSON similar to the following:
{
   "nested": {
      "mdc1": "value1",
      "mdc2": "value2"
   }
}

However when not MDC keys are present or if none matches the include pattern of the MDC json provider, the "nested" object becomes empty and the output looks as follows:
{
   "nested": {
   }
}

There is unfortunately no option to omit the nested object when it is empty similar to what is available to the PatternJsonProvider.

This issue has been raised in the following discussion.

As proposed in this discussion, an option is to decorate the JsonGenerator to make it filter empty fields. This option would be controlled by a new omitEmptyField configuration property added to the LoggingEventCompositeJsonEncoder. The behaviour would be global and would affect all configured JsonProviders.
Most JsonProvider already omit their fields when they are empty and this behaviour is not configurable (cannot be disabled). Adding a new omitEmptyField global option to the JsonCompositeEncoder may be confusing especially when set to false: people may think that the providers will now output their fields with a null value - which won't be the case unless the implementation is changed.
Instead of adding this feature to the CompositeJsonEncoder we could also limit it to the NestedJsonProvider. In this case the semantic must be clarified:

should the "nested" field be omitted when its value is empty (i.e. an empty object)
or do we want this behaviour to propagate to the nested providers as well?

Hmm.  Brainstorming here...
What about having a global omitEmptyFields boolean property on the encoder honored by all providers, but also being able to be overridden on individual providers?
Maybe something like this:

Add a global omitEmptyFields Boolean property on the encoder, with possible values true, false, and null/unset (the default).
Also add omitEmptyFields Boolean property on the providers as appropriate, with possible values true, false, and null/unset (the default)

The null/unset values mean behave exactly as they do today.  And since the default is null/unset, the behavior is fully backwards compatible with how things work today.
When a provider is contributing to the generator,

if the provider-level value is set, then honor it.
else if the global-level value is set, then honor it
else do whatever the current behavior of the provider is  ("backwards compatible mode")

Not sure how easy that would be to implement.  The providers would need to be able to change the "state" of the token filter before/after the provider contributes to the generator.
My main reasoning for proposing the above is to be able to keep backwards compatibility, while also adding cool new features.  Without the null/unset option, and just providing a true/false option, backwards compatibility is broken no matter if the default value is true or false, since neither represents the current behavior.  And there would be no way to "revert" to the current behavior.
Alternatively, just implementing a new omitIfEmpty option on the NestedJsonProvider that only applies to the nested object itself (not the sub-providers), with a default value of false, is a much more targetted and simpler approach.  I'd be ok doing this as a simple solution first.  And then coming back later to try to do the more complex global solution.

As a consumer,

just implementing a new omitIfEmpty option on the NestedJsonProvider that only applies to the nested object itself

would work fine for me. In my normal configuration use case, I'm only adding a single nestedField, so config duplication isn't a concern.


[SvelteKit] AuthApiError: invalid request: both auth code and code verifier should be non-empty

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
Facing a AuthApiError: invalid request: both auth code and code verifier should be non-empty error when attempting to confirm a signup that was initiated on server-side as per the docs.
Does not occur when the signUp call is made on the client.
To Reproduce

Initiate sign up on server-side as per the docs
Visit confirmation link received via email

Expected behavior
Sign up is confirmed
Screenshots
N/A
System information

OS: Windows
Browser N/A
Version of supabase-js: 2.24.0
Version of Node.js: 18.13.0

Additional context
Add any other context about the problem here.

Same issue here following the nextjs instructions

Same issue. Works fine locally.

Should point out, it seems to actually confirm the email but throws an error. Vercel kicking out:
- error AuthApiError: invalid request: both auth code and code verifier should be non-empty
    at /var/task/.next/server/chunks/928.js:3374:24
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  __isAuthError: true,
  status: 400
}

Are you opening the link in the email in the same browser from which you made the original request? It sets the auth code in a cookie so you need to be in the same browser (not in incognito mode) for it to work. This caught me out and has obvious implications around a common user flow (sending the request on one device, opening the link on another)

I can confirm that this also happens with PKCE OAuth calls.

This is how the pkce flow works as outlined by @hamishtaplin above. The browser in which the request was made has to be the same browser the link should be opened in. If it is the same browser and you are having this issue please create a minimal reproducible example repo with the issue. I have a few example projects using the pkce flow on the server side and don't have this issue with any of them. You can check one out here https://github.com/supabase-community/supabase-by-example/tree/main/reset-flow/sveltekit.

Closing this as it's a duplicate of #545

This is how the pkce flow works as outlined by @hamishtaplin above. The browser in which the request was made has to be the same browser the link should be opened in. If it is the same browser and you are having this issue please create a minimal reproducible example repo with the issue. I have a few example projects using the pkce flow on the server side and don't have this issue with any of them. You can check one out here https://github.com/supabase-community/supabase-by-example/tree/main/reset-flow/sveltekit.

I am calling signUp in a trpc procedure. This is likely failing because accessing/setting the cookie is not possible with my current trpc configuration.

Are you opening the link in the email in the same browser from which you made the original request? It sets the auth code in a cookie so you need to be in the same browser (not in incognito mode) for it to work. This caught me out and has obvious implications around a common user flow (sending the request on one device, opening the link on another)

This is the actual problem, same happens ins nextjs!

same issue happens when on my nextjs server when i use google auth from phone

I believe the issue (at least with SvelteKit) has to due to with invalid CookieMethods config in the documentation: https://github.com/orgs/supabase/discussions/21183#discussioncomment-10184740


improvementSupport inverted index in CCR

Support inverted index in several occasions:

Creating binlog files
Downloading binlog files
During engine clone tasks
Binlog gc

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

please add cases.

run buildall

please add cases.

Case is here: https://github.com/selectdb/ccr-syncer/pull/48

run buildall

run buildall


Come up with a design for setting ModelState.MaxAllowedErrors

Currently this value is set from options inside the MvcRouteHandler. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Core/MvcRouteHandler.cs#L82
This is confusing from a layering standpoint. We should consider what the right design is for this. There had been some discussion about a filter-stage dedicated to this sort of model-binding concerns.

We will move the setting to the entry point of model binding.
We will make the default maxerrors on model state the same as the default in mvc options
We will provide a constructor to model state with max errors, and review all uses of the modelstatedictionary default constructor.

42df4cf2eddd92221104c55fe6bc48a42e2b3030


Translated to Traditional Chinese

I'm doing a Traditional Chinese translate.

I will review it later. Thank you! :)

@awxiaoxian2020
Sorry, I send the wrong branch. Closing and replace new one.


i18n(es): Update of project-structure.md, routing.md, sharing-state.md, buddy.md, edgio.md & vercel.md

What kind of changes does this PR include?

New or updated content
Translated content

Description

What does this PR change? Give us a brief description.


Please review and edit this string

Hello,
please review this string: "This is result in creation of an Azure Event Grid System topic of name - in the same resource group as the storage account. "
Should there be something after "topic of name"? In its current form the sentence is not clear.
Kind regards,
Anne H., QC

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a516ba36-643a-e308-ca42-3cd788bb3488
Version Independent ID: c03780b4-a6f5-0eaa-68fe-100ab085bffa
Content: Common questions - Defender for Storage - Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/faq-defender-for-storage.yml
Service: defender-for-cloud
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

@QueryCoordinator
Thanks for your feedback! We will investigate and update as appropriate.

@QueryCoordinator
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


feat: run zod validation on response interceptor

This PR injects the appRoute to the ApiRouteInterceptor so that zod validations and transformations can run on the response body

This is great! I believe this is something a lot of people might want.
One thing to note, not everyone would probably want to validate their responses, and would be satisfied with just the type-safety. So I'd consider it essential to make sure this is optional and disabled by default otherwise this would be a breaking change.

This is great! I believe this is something a lot of people might want.
One thing to note, not everyone would probably want to validate their responses, and would be satisfied with just the type-safety. So I'd consider it essential to make sure this is optional and disabled by default otherwise this would be a breaking change.

Agree. Also in case @oliverbutler marks the zod peer dependency as optional in future versions, we should absolutely mark this as an opt in feature.

@michaelangrivera Zod IS optional, in that if you don't use it, zod won't get bundled into your contract
but there's an outstanding issue to remove references to zod from the library so zod doesn't need to be a dev dependency
this looks amazing! i've been tight on time this last week but i should be able to take a look today 🤞
thanks for the PR!

Just pushed the requested changes and made the parsing opt-in.
The way I achieved this was at the controller level by using the new @ParseResponses decorator, and by introducing a new parameter to initNestServer that will change the responses types from z.infer to z.input because the response will need to match the input of zod instead of the output
const s = initNestServer(apiBlog, { parseResponses: true });

@Controller()
@ParseResponses()
export class PostController implements ControllerShape {
  constructor(private readonly postService: PostService) {}

  @Api(s.route.getPost)
  async getPost(@ApiDecorator() { params: { id } }: RouteShape['getPost']) {
    const post = await this.postService.getPost(id);

    if (!post) {
      return { status: 404 as const, body: null };
    }

    return { status: 200 as const, body: post };
  }
}

Does this succeed if isParsingEnabled is false, leading the second param of checkZodSchema to be undefined?
Alternatively, maybe we should early return if the validation isn't on 🤔
Also, I'm aware this is a breaking change, primarily if someone is relying on receiving the Zod errors as an object. On the flip side, the Zod error handling was undocumented behaviour, maybe we should discuss this change, then document + test it.

Agree. We should definitely exit early if that decorator does not exist. Something like:
          const statusNumber = value.status;

          const isParsingEnabled = Boolean(
            Reflect.getMetadata(ParseResponsesSymbol, context.getHandler()) ||
              Reflect.getMetadata(ParseResponsesSymbol, context.getClass())
          );

          if (!isParsingEnabled) {
            res.status(statusNumber)
            return value.body
          }

would read easier in my opinion.
Sorry to cause extra work here, but is it possible to separate this logic into another method or util function? You might be able to move to it parse-responses.decorator.ts.
          const responseValidation = checkZodSchema(
            value.body,
            isParsingEnabled ? appRoute.responses[statusNumber] : undefined
          );

          if (!responseValidation.success) {
            const { error } = responseValidation;

            const message = error.errors.map(
              (error) => `${error.path.join('.')}: ${error.message}`
            );

            throw new InternalServerErrorException(message);
          }

Should we migrate to zod being an optional devDependency, this would make that migration easier. We should start doing that from here on out (imo).
@oliverbutler  If we return early, I'm not sure this would be a breaking change?  The logic only runs if the ParseResponses decorator exists from the looks of it. Can you point to the zod errors aspect for response parsing (on main branch)?
A few other notes

Can you write a few tests demonstrating this? You should be able to use post.controller.spec.ts and post.controller.withResponseShapes.spec.ts for an "integration" style test.
Also, can we unit test:

    const responseValidation = checkZodSchema(
           ....
          ⬇
          ...
            throw new InternalServerErrorException(message);
          }

That way, if zod changes anything (unlikely), we'll know.
Can you create an example file off of post.controller.ts that shows this feature working? Or even modify the existing one with a new method showing this new decorator in action.
Can you update the nest documentation with any and all new information about this decorator? You could add a new section on "Response Parsing" or something similar. Please give the nest docs a read if you haven't ready to see the style of how we document features: https://ts-rest.com/docs/nest

Great work here! Thank you so much! Will definitely be useful.

Codecov Report

Merging #121 (a349ba2) into main (1153f4b) will decrease coverage by 3.55%.
The diff coverage is 48.97%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   66.00%   62.45%   -3.55%
==========================================
  Files           9       11       +2
  Lines         250      285      +35
  Branches       61       68       +7
==========================================
+ Hits          165      178      +13
- Misses         75       96      +21
- Partials       10       11       +1

Impacted Files
Coverage Δ

libs/ts-rest/core/src/lib/client.ts
85.36% <ø> (+1.64%)
:arrow_up:

libs/ts-rest/express/src/lib/ts-rest-express.ts
11.84% <0.00%> (-1.40%)
:arrow_down:

libs/ts-rest/core/src/lib/server.ts
28.57% <28.57%> (ø)

.../ts-rest/core/src/lib/response-validation-error.ts
33.33% <33.33%> (ø)

libs/ts-rest/core/src/lib/zod-utils.ts
92.30% <75.00%> (-7.70%)
:arrow_down:

libs/ts-rest/next/src/lib/ts-rest-next.ts
76.47% <87.50%> (-0.20%)
:arrow_down:

libs/ts-rest/core/src/index.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM!

@michaelangrivera @oliverbutler cheers!
@lukemorales thank you so much for taking on this initiative. Very excited to see this go live! 🙌

Thanks for pushing it to the finish line when I had trouble finding time to come back to it @Gabrola, really appreciate the support!


Resolving Listener bug

The Locator.events.listener function doesn't set the newly generated token to nextTokenID. As a result, the events can effectively only hold one callback.

Already merged