Clean up boundary between terminal app and terminal page

This PR is for this project: https://github.com/microsoft/terminal/issues/1878

Refere

PR Checklist

[x] Closes #1878
[ ] Tests added/passed
[ ] ~Requires documentation to be updated~
[x] I've discussed this with core contributors already.

For now, the new TerminalPage class includes;
global error dialogs
ETW global registration
tab management
tab icons
clipboard management
ETW tab logging
key bindings
And App is responsible for:
settings
settings reload
One issue remaining for now is that I have not figured out how to move the four winrt event handlers in App down to Terminal. I have some work-arounds to attach  AppHost methods to the event handlers, but I am still working on this.

Test: According to Griese, we do not have integration/unit tests for now. I have manually tested the app with following actions:
Open new tabs
close tabs
close the last tab
resize window
minimize/restore
ShowTitleBar, true/false
change settings: font size, background color, useAcrylic
Copy/Paste with mouse/keyboard
Tab switch/add/close/ using keys
About button
Split pane vertically and horizontally
Resize panes with keys
Move focus on different panes with keys
Change theme while the app is on.
Change cmd title while the app is on

    std::shared_mutex _dialogLock;

Looks like this is only used in TerminalPage now, which has its own copy.

Refers to: src/cascadia/TerminalApp/App.h:56 in 26d69a5. [](commit_id = 26d69a5a4b235dc6997973e4e894b1e4cf5b99cf, deletion_comment = False)

@microsoft/windows-console-team time to review this! Thanks alL!

The code formatting check failed.

The code formatting check failed.

Format issue fixed, tested again and there is no bug. Merge.


Versioning some compare functions

Updates

Versioning a few compare functions with cfVersion
Update example on README

Ticket: https://github.com/mapbox/vandalism-dynamosm/issues/110


Refactor and port apps to functions repo

Following artifacts/apps need to be released as part of the Fahrenheit GA release train.
List sorted by maven-central's download frequency aka a rough take on priority:

[ ] http-source  - @artembilan @sobychacko (function is ready)
[ ] rabbit-source  - @sobychacko
[ ] rabbit-sink  - @sobychacko
[ ] gemfire-source  -
[ ] gemfire-sink  -
[ ] gemfire-cq-source -
[ ] log-sink - @sobychacko
[ ] jdbc-source  - @sobychacko (function is ready)
[ ] jdbc-sink  -
[ ] ftp-source -
[ ] ftp-sink -
[ ] mongodb-source -
[ ] mongodb-sink -
[ ] sftp-source -
[ ] sftp-sink -
[ ] router-sink -
[ ] counter-sink -
[ ] counter-processor -
[ ] splitter-processor - @artembilan @sobychacko (function is ready)
[ ] time-source - @sobychacko
[ ] httpclient-processor -
[ ] filter-processor -
[ ] transform-processor   -
[ ] bridge-processor -
[ ] jms-source  - @tzolov @artembilan (we will have to make reactive adjustments in SI)
[ ] tcp-source   -
[ ] tcp-sink   -
[ ] tcp-client-source    -
[ ] tcp-client-processor    -
[ ] groovy-filter-processor -
[ ] groovy-transform-processor -
[ ] header-enricher-processor -
[ ] s3-source  -
[ ] s3-sink  -
[ ] file-source  -
[ ] file-sink  -
[ ] mqtt-source  -
[ ] mqtt-sink  -
[ ] aggregator-processor -
[ ] cassandra-sink - @artembilan @sobychacko (function is ready)
[ ] load-generator-source -
[ ] loggregator-source -
[ ] mail-source -
[ ] pgcopy-sink  -
[ ] pmml-processor -
[ ] redis-pubsub-sink -
[ ] scriptable-transform-processor -
[ ] syslog-source   -
[ ] throughput-sink -
[ ] trigger-source   -
[ ] triggertask-source  -
[ ] twitterstream-source  -
[ ] websocket-sink -
[ ] image-recognition-porocessor -
[ ] pose-estimation-porocessor -
[ ] tasklaunchrequest-transform-porocessor -
[ ] tasklauncher-dataflow - @dturanski (in pr)
[ ] tensorflow-porocessor -
[ ] grpc-porocessor -
[ ] python-http-porocessor -
[ ] python-jython-porocessor -
[ ] twitter-sentiment-porocessor -
[ ] object-detection-porocessor -
[ ] hdfs-sink -

Functions Repo:
pivotal/java-functions
App Starters Infra Repo:
spring-cloud-stream-app-starters/stream-apps
Notes:

Since we don't have any CI in place, we need to build them locally first (install function artifacts first)
We may have to rely on the unit-tests in the functions repo; however, a full-blown IT or AT type of tests should surface at each app-starter level. That means, we will need new CI plans, for different binders, too.

Here are the steps:

Clone github.com/pivotal/java-functions

./mvnw clean install

Clone https://github.com/spring-cloud-stream-app-starters/stream-apps

./mvnw clean package (or do it from the corresponding app modules)

@sabbyanandan @sobychacko - I assume for the sftp source we will remove all task launch request related code, including for the new app starter, and show how to use function composition to do the file ingest UC. - We will need to include https://github.com/spring-cloud-stream-app-starters/core/tree/master/common/app-starters-task-launch-request-common in the new function repo.


Very poor documentation! Please explain the sample codes. Please also provide scenarios where it could be used.

For e.g. in the section "Shared-type entity types and property bags", the documentation is so poor that we can't understand anything. I clicked on the property bags link  https://docs.microsoft.com/en-us/ef/core/modeling/shadow-properties#property-bag-entity-types  hoping it will provide a detailed explanation. But that was even worse.  Remember, the documentation is not for Microsoft but the external users/developers. So give proper explanation (especially of the examples) so that we can actually appreciate the feature and start using it (instead of making it very confusing or ambiguous for the developers). These features are of no use if you have it but we can't use it for lack of proper documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32360b50-1129-b3d2-2d71-c6b89cd9f2c6
Version Independent ID: 4f18f8dc-5cd5-cb37-0f59-fb1767609b2b
Content: What's New in EF Core 5.0
Content Source: entity-framework/core/what-is-new/ef-core-5.0/whatsnew.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

Duplicate of #3198

Please do not close it saying it is a duplicate of some ticket. The documentation on this page in general is very unclear. The Shared-type entity types and property bags was just one example. For e.g. "an entity can be mapped to a SQL query " under Flexible Entity Mapping section --- what exactly does it mean. Just giving an example without explaining what exactly it means and what scenario this feature could be used etc renders it unusable for the readers. Please keep the developers in mind when creating documentation.


json/yaml/etc.

It would be quite convenient if this library's config structs supported encoding directives so that an application's user's preferences could be saved.
Is there any plan, or desire to incorporate this?

Hi @kendfss. Can you suggest me what exactly you want? Maybe code that invokes wanting feature may help.

Go allows api developers to create instructions for parsers by using strings. Check out the Set custom attributes in JSON section here. This is convenient on your side because you can easily get things off the ground. I tend to use it myself because it doesn't require downloading/importing extra packages. But there are other ways of doing this, such as with one of the yaml parsers. There are also other json parsers that offer more functionality.
What are your thoughts on the matter? Worth implementing, or nah?
regards,
Kenneth


Add sql connection reference into the operation result.

Hi there:
I would like to see some enhancements for sql connection since sql connection is a little bit different from other async api
it requires closing the connection  manually, so it makes fluent coding style messy when you compose some futures
e.g.
Future.<SQLConnection>future(future ->{
    client.getConnection(future);
}).<UpdateResult>compose(connection ->
    Future.future(future -> connection.update("update table_1 set name = a where id = 001", future))
).setHandler(updateResult ->{
    if(updateResult.succeeded()){

    }else{

    }
    //is there any way to add updateResult.getConnection(); here?
    //thus we could use updateResult.getConnection().close();
});

as we could see here, the 1st step is to get connection from the pool, then do some operations then close the connection, which means return the connection to the pool, however currently we may not be able to do that since most of sql connection apis does not return the reference for the sql connection then the connection is lost when you chain the futures
I would suggest to add sql connection reference to the result then we should be able to close the connection at the end of the fluent future chain.

Issue moved to vert-x3/vertx-sql-common #47 via ZenHub


Backport: bug with duplicate product capture.

Backport with v1.
Looks like a bug-fix slipped through the cracks. This patches up the case where a user were to only specify two products which happened to be duplicates.

@sssangha if its a backport need to commit to v1.

@dbekaert actually what I meant to say that this particular issue was fixed in v1, but not in dev.


Code Lenses are not showing for tests discovered with unittest

I couldn't reproduce it every time
Environment data

VS Code Insiders
Extension version 2019.3.6558

Tests are discovered and displayed in the Test Explorer normally, just the Code Lenses are missing.

This is with pytest:

@karthiknadig are you still able to replicate this issue?

No, not after fixing the trailing comma problem in launch.json.

Closing as the problem hasn't been reported since and most likely related to extension not handing jsonc files correctly


fix(PyPi): build project before publishing

:tada: This PR is included in version 0.0.12 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add chrome extension for checking or detecting weather current opened site contains malware or not ?

@Sulagna-Dutta-Roy  Assign it to me

Can you please use the feature request for opening the issues? It's the guidelines from gssoc.

Can you please use the feature request for opening the issues? It's the guidelines from gssoc.

i used feature template not of bug


Update docs for Almond scala-kernel_2.13.0 ?

The Almond installation docs discuss Almond version 0.4.0, but I see 0.6.0 and 0.7.0 exist for Scala 2.13.0. My Almond build script works for Scala 2.13.0 and Almond 0.7.0. Is there any reason this should not be mentioned in the installation docs?
$ buildAlmond -s 2.13.0 -a 0.7.0 -f
 ... lots of output
Available kernels:
  python3         /home/mslinn/.local/share/jupyter/kernels/python3
  scala           /home/mslinn/.local/share/jupyter/kernels/scala
  scala2.11.12    /home/mslinn/.local/share/jupyter/kernels/scala2.11.12
  scala2.12.8     /home/mslinn/.local/share/jupyter/kernels/scala2.12.8
  scala2.13.0     /home/mslinn/.local/share/jupyter/kernels/scala2.13.0
  python2         /usr/local/share/jupyter/kernels/python2

The docs now have something about versions 0.6.0, 0.7.0, 0.8.0:

https://almond.sh/docs/install-versions

but with Almond 0.9.0 now out, that documentation page
should again be updated.
The release notes at

https://github.com/almond-sh/almond/releases

say 0.9.0 removed support for Scala 2.12.6 and 2.12.7.
See pull request: https://github.com/almond-sh/almond/pull/473


Transaction receipt fails to return when calling contract

Getting the following error when calling a contract function in web3js. The TX seems to execute (according to explorer), but the receipt is failing to return.
https://explorer.nearprotocol.com/transactions/8GbnSufdmz6aEJ3a9qER9RevLRmXbH69gapsRShwZrpe
Code:
const response = await contract.methods.get().send({ from: accounts[0] });

Error:
index.js:58 Uncaught (in promise) Error: Failed to check for transaction receipt:
{}
    at Object._fireError (index.js:58)
    at index.js:271

this message typically means that the receipt translation logic errored, and failed to return a receipt. Can you provide more tx details so I can reproduce?

Picking this up again!
Have everything you need to reproduce in this repo: https://github.com/kcole16/evm-example
Contracts deployed to account "verystable" on testnet. Included the build file with the address in the repo so you don't need to deploy anything.

Thanks for putting that together. I’ll look into it some more. I’ve got a
PR coming that should fix this issue (if it is what I’m thinking of).
On Mon, Feb 24, 2020 at 18:59 Kendall Cole<EMAIL_ADDRESS>wrote:

Picking this up again!
Have everything you need to reproduce in this repo:
https://github.com/kcole16/evm-example
Contracts deployed to account "verystable" on testnet. Included the build
file with the address in the repo so you don't need to deploy anything.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/nearprotocol/near-web3-provider/issues/8?email_source=notifications&email_token=ACOMYV36A4VYBNJLRK6LKCTRER3RZA5CNFSM4KV63PQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM2H4ZQ#issuecomment-590642790,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOMYV57DRG6GJUPOOT4BHLRER3RZANCNFSM4KV63PQQ
.

Can this issue be closed?

This should be good. Closing issue.


⚠ AtmoVantage Appointment Booking has degraded performance

In 471e52d, AtmoVantage Appointment Booking (https://booking.atmovantage.com/#/customer/schedule) experienced degraded performance:

HTTP code: 200
Response time: 23192 ms

Resolved: AtmoVantage Appointment Booking performance has improved in 80a9596 after 9 minutes.


Eve Light Switch History?

Hi,
Elgato sells the Eve Light Switch in the US and interestingly it seems to offer a history for Characteristic.On. As I'm in Germany I can't use this out of the box, however it would be great to know if support for this is underway?
I'd be  looking to add this to my automation switches. Incidentally if I try to expose the history for the switches, the app already shows an On History, but doesn't show any data - so the data format must differ from the others somehow.
Thanks!

In principle it is possible and should not be difficult, but I need a dump of characteristics 116 and 117. So we need someone with a real Eve Switch able to follow the procedure described in the readme.

i would love that too, i'm not good with electricity but i guess someone could modulate 220V -> 120V to make it work ...

That's what I'm currently contemplating: Purchasing one along with the necessary voltage converter to try to reverse engineer it. It shouldn't be too difficult given that I'd pair it with homebridge-ranger and just sniff the traffic along the way.

Any news on this?
I tried adding the 'motion' type history for a switch service. As a result, the History dropdown actually appears in the Eve App, but its always showing "No data available".
(This is the same behaviour as with the 'door' sensor history, if the optional characteristics OpenDuration / OpenDuration are not provided)
I suspect that there is also an optional characteristic missing, that is necessary to show the switching-event history.
Is there anyone who owns a Eve Light Switch, and can investigate?

No, unfortunately I did not receive any communication dump yet.

Great news: Since #75 I found out a very simple way to get the switch history (on/off) working:
Just add TYPE_SWITCH = 'switch';
with
case TYPE_SWITCH:
   this.accessoryType116 = "01 0e01";
   this.accessoryType117 = "01";

(rest of the code can be copy-pasted from motion and just add case TYPE_SWITCH to the further switch-cases for TYPE_DOOR/TYPE_MOTION.)
And voila: History appears (unfortunately only in combination with the Switch-service. In my test it does not appear with Lightbulb or Outlet, but this may be related to Eve's stricter requirements discussed in #76). Here I am gladly open for more information from the community.

Since Eve light switch is coming to most EU countries next month, this would be a great extension.
There will also be a schedule-feature... but I have no plan for this (probably similar to the Thermo-schedule).
Luckily, switch history also appears without this schedule in v3.8.1

@simont77: Have you already tested my suggested characteristics 116 and 117 for this topic?

Sorry, I don't have so much time at the moment, but feel free to submit a PR, and I will try to merge it.

Great, it's working fine!
I tested with homebridge-mqttthing plugin.
I think this issue can be closed...


Proposal: MegaBoard - Revolutionizing Outdoor Advertising with Blockchain

Description

Tokenizes billboards on the blockchain, enabling transparent, decentralized ad bookings.
Offers community investment in billboard shares, generating shared revenue.
Simplifies access to outdoor advertising for advertisers and investors.

Why Proposal?
Boosts transparency, and community revenue, and links real assets to digital.
Bounty track

Real World Assets
NFTs

Hmm... i strongly discourage RWA (that's why there is no RWA track). So I would suggest you to amend the proposal into something like group investments, crowdfunding, with some DAO elements.
why no RWA? RWA has too much red tapes, it's hard for everyone to benefit.


Docks and Fences

Textures Docks around RS; Image order is before then after.
As an added bonus fences are also textured around Port Phasmatys as they use the same texture
Port Sarim:

Catherby:

Karamja:

Port Phasmatys:

bug

Phasmatys changes
master/pr

Rellekka changes
master/pr:

Changed the texture, updated first post with karamja; here is just a shot in Catherby

I want to wait with this one until we have a way to rotate UVs with model orientation. Maybe I can add this tonight.

Would you mind updating this PR with the new UV types introduced by #92? You can use MODEL_XZ to rotate UVs for GroundObjects on the docks, and MODEL_XZ_MIRROR_A on the diagonal joints. For reference, here's how I did it in the following image:
  {
    "description": "port sarim dock planks",
    "objectIds": [ 9541 ],
    "baseMaterial": "INFERNAL_CAPE",
    "uvType": "MODEL_XZ"
  },
  {
    "description": "port sarim dock planks diagonal",
    "objectIds": [ 9542 ],
    "baseMaterial": "INFERNAL_CAPE",
    "uvType": "MODEL_XZ_MIRROR_A"
  }

I'm asking because it would be great if we could test #92 more before merging it, and it was written primarily to help with this PR :slightly_smiling_face:. Also, if you find anything missing or wrong with #92, please let me know!

Waiting for #92

I've patched this to use MODEL_XZ and diagonally mirrored UVs from #92 where applicable, but one final thing came to mind. Would you be open to trying this with a couple of normal maps instead of all of these textures? Something along the lines of:
WOOD_GRAIN_N,
WOOD_GRAIN(WHITE, p -> p.setNormalMap(WOOD_GRAIN_N)),

Don't throw away what you've got though, I'm just curious whether it's feasible to do with normal maps instead. Other than that, I'm ready to merge this.

The reason I have all those textures is the color override, if I don't use that then I would just have one texture and plus normals

The reason I have all those textures is the color override, if I don't use that then I would just have one texture and plus normals

Right, and it might look best with those overrides, but I was curious what it would look like with only a normal map and inherited colors. I'll give it a shot tomorrow I think :slightly_smiling_face:

Ahh okay, no worries I can give it a shot when I'm home! I'll post it here and in disco

You'll want to update and run around again, I added a normal and improved the texture; I don't think we will need color override now


SS4 Update

Hey Axyr,
Is there anything in the pipeline for this module to be updated for SS4?

Is there any update :) ?

im not really using ss anymore. please feel free to take over or fork :)

@palomamtnez feel free to use my fork in the mean time (linked above). @axyr if you're no longer willing to look after then I'm happy to support since I use it on a bunch of things.

Awesome, thank you for your answers! Will give it a try to the SS4 version :)

Ho @wilr I mad ownership transfer request.
Thanks!


Support any thowable in repeating an error

https://github.com/yiisoft/proxy/pull/15 didn't work because Throwables aren't clone-able.

Since exceptions are rarely modifier, I'd do the same as in #15 but w/o clone.

https://github.com/doctrine/instantiator/issues/7 is interesting as well.

https://github.com/yiisoft/proxy/pull/18


infix functions/operators

What is your idea? Provide a use case.
The infix notation makes huge sense in case of mathematical calculations with custom types, e.g. using a custom type with fixed decimal precision.
It helps with readability. For comparison the following:
type MyInt {get_my_int: Int}

fn my_int_mul(a: MyInt, b: MyInt) -> MyInt {
  a.get_my_int * b.get_my_int / decimal_precision
}

fn foo1(a: MyInt, b: MyInt) {
  my_int_mul(
    a,
    my_int_mul(a, b)
  )
}

// With the infix functions
fn foo2(a: MyInt, b: MyInt) {
  a `my_int_mul` a `my_int_mul` b
}

And the previous would be even nicer if used with infix operators rather than just infix functions. With just a few operations it is acceptable even in the current form, but it gets worse when more complex math expressions are necessary.
Infix functions
I'd like to have an option to call function infix in Aiken.
An example from object oriented languages is operators override which I don't think is that nice since it allows only operators that are reserved, I like the Haskell's approach more where we can use custom functions/operators.
An example from Haskell is that when having a function taking 2 parameters it can be used infix this way:
param1 `my_function` param2

Custom operators/infix operators
The upgraded level of the infix functions are the infix operators.
The following is the example:
type MyInt {get_my_int: Int}

fn |+|(a: MyInt, b: MyInt) -> MyInt {..}
fn |-|(a: MyInt, b: MyInt) -> MyInt {..}

// Then I can use them the following

foo(a: MyInt, b: MyInt) -> MyInt {
  a |+| b
}

Constraint for the operators would that they can't overlap with the reserved operators built into the language.
Why is it a good idea?
As I've described above in more detail, it helps the readability.
What is the current alternative and why is it not good enough?
Currently, we can call functions as normal and can't define custom operators.

What about https://aiken-lang.org/language-tour/functions#pipe-operator
a |> my_int_mul(a) |> my_int_mul(b)

?
Or in foo1's order,
a |> my_int_mul(b) |> my_int_mul(a)

This is extremely unlikely to happen and should be a discussion


boards: arm: Add support for BMD-345-EVAL

Add support for u-blox BMD-345-EVAL which uses the nRF52840
and a Skyworks RFX2411 FEM.
This board is similar to the nRF52840dk_nrf52840 with the
addition of a FEM. Four Arduino GPIO pins have been
reassigned to the PA_LNA control pins.
u-blox would prefer to use this naming convention to match
other BMD-3xx-EVAL and EVK-NINA-Bx boards recently submitted.
Tested with blinky, button, and Bluetooth peripheral_hr
Signed-off-by: Bob Recny<EMAIL_ADDRESS>

Just checking status. Thanks.

@brec-u-blox https://github.com/zephyrproject-rtos/zephyr/pull/31731 Already address the same board and merged. If board name to be changed, rename the directory and board name

@brec-u-blox #31731 Already address the same board and merged. If board name to be changed, rename the directory and board name

Thanks. I wasn't sure of the best way to handle this. I'll close this request and make the changes the board entry that's already merged.


Add missing BKGlobals.h imports.

In BlocksKit/MFMailComposeViewController+BlocksKit.h and BlocksKit/MFMessageComposeViewController+BlocksKit.h the BKGlobals.h wasn't imported, which resulted in a compile error for me.

*sheepishly merges*


Add Obj-C/React Native support

I tried to get Blockstack working for React Native.
In order to use Blockstack in React Native it needs a Native Module. In order to create such a module Blockstack need to be representable in Objective-C first.
This PR adds support for Objective-C and is a step for support in React Native.

Here's a working RN + Blockstack project @yknl.
You might find it useful :)

This is awesome @michalciurus, just what we needed! I'm going to do more testing and merge this in.

Hi Ken,
When do you expect to add Obj-C support and merge this back in.
Thanks,
Pete

Hey @petec029, didn't get a chance to review this PR yet. Perhaps @shreyasthiagaraj can take a look.

This has been resolved in latest version of develop. Thank you for the work here @michalciurus, I used some of your ideas in the final implementation, though this PR was too far out of date to be merged in directly.

Thanks for getting this done.  Do you recommend trying out the developer branch or is it better to wait until you test it further and merge it back into the master branch?


Disable emoji stripping in production

Eliminating potential performance degradation caused by emoji stripping :zap:

Emoji will get stripped from (console) log output only in development mode and if strip-emoji package is present. 🎉

After this lands into develop we can push sequelize logs through bunyan using following patch:
diff --git a/server/common/database/config.js b/server/common/database/config.js
index b5bd06c..73f0f62 100644
--- a/server/common/database/config.js
+++ b/server/common/database/config.js
@@ -1,6 +1,8 @@
 'use strict';

 require('dotenv').config();
+const log = require('../../common/logger');
+const logger = log('db', { level: log.DEBUG });

 const isProduction = process.env.NODE_ENV === 'production';

@@ -9,6 +11,10 @@ module.exports = {
   dialect: 'postgres',
   operatorsAliases: false,
   migrationStorageTableName: 'sequelize_meta',
-  // TODO: Use bunyan for SQL logging.
-  benchmark: !isProduction
+  benchmark: !isProduction,
+  logging(query, time) {
+    const info = { query };
+    if (time) info.duration = `${time}ms`;
+    return logger.debug(info);
+  }
 };

This is what it looks like at the end:


clarify that is pseudobulk

Description

Details
URL to issue

Link to staging deployment URL (or set N/A)

Links to any PRs or resources related to this PR

Integration test branch
master

Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.

Code updates
Have best practices and ongoing refactors being observed in this PR

[x] Migrated any selector / reducer used to the new format.

Manual/unit testing

[x] Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
[x] Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
[x] Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

[ ] Started end-to-end tests on the latest commit.

Documentation updates

[x] Relevant Github READMEs updated or no GitHub README updates required.
[x] Relevant Wiki pages created/updated or no Wiki updates required.

Optional

[ ] Staging environment is unstaged before merging.
[ ] Photo of a cute animal attached to this PR.

@alexvpickering do we want to merge this? Or should it be closed?


[multistage] fix tenant detection issues

follow up on multi-stage tenant support #10336

[x] if query doesn't have table name alias. it doesn't work (it is not a SqlCall but a SqlIdentifier after From)
[x] adding test for OrderBy query as well b/c order by comes before SqlFrom
[x] make error message more clear.

Codecov Report

Merging #10546 (137aa1c) into master (513fa31) will decrease coverage by 53.98%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10546       +/-   ##
=============================================
- Coverage     67.84%   13.87%   -53.98%
+ Complexity     6001      439     -5562
=============================================
  Files          1575     2049      +474
  Lines         81930   110285    +28355
  Branches      12870    16684     +3814
=============================================
- Hits          55586    15297    -40289
- Misses        22450    93741    +71291
+ Partials       3894     1247     -2647

Flag
Coverage Δ

unittests1
?

unittests2
13.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...org/apache/pinot/sql/parsers/CalciteSqlParser.java
0.00% <0.00%> (-84.03%)
:arrow_down:

...t/controller/api/resources/PinotQueryResource.java
0.00% <0.00%> (ø)

... and 1873 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Another issue to follow up with this @ankitsultana and @tibrewalpratik17 is that after this fix the error message for multi-stage query for select * from non_exist_tbl will return non_exist_tbl cannot find common tenant across all table --> where the real error should probably be table non_exist. Please kindly take a look and see how we can better surface the error message since this is user-facing

@walterddr raised a fix to improve the error message in case of non-existent table in #10599


Optimizing startpoint manager to not make successive bootstrapMessage calls to coordinator-store

Symptom: Currently the startpoint manager queries metastore for task-ssps and for each ssp queries coordinator-store, issuing a re-read on the coordinator store. This causes increased AM startup time and depending on the number of input SSPs to a job (thousands in case of regex), YARN may timeout the AM.
Cause: Above.
Fix: This change reduces to number of metastore reads to 2; one for startpoints keyed by ssp and the other for startpoints keyed by ssp+taskname.
API changes: None
Upgrade Instructions: None

+1, simplified and addressed both comments.


Problems with setting clipInnerFrame = false and line area color

Here is the stack overflow link to the issue I am having.
https://stackoverflow.com/questions/47231708/swiftcharts-cutting-off-points-clips-bounds

I posted an answer there!


Docker swarm deployment with multiple networks not possible

Hello there,
while fiddeling around with VerneMQ in a docker swarm environment, I noticed an odd behaviour utilizing multiple networks.
Let's start with a working example of the docker-compose.yml:
version: "3.7"
services:
  vmq_discovery_node:
    image: vernemq:1.13.0
    environment:
      DOCKER_VERNEMQ_SWARM: 1
    networks:
      - internal

  vmq-main-nodes:
    image: vernemq:1.13.0
    environment:
      DOCKER_VERNEMQ_SWARM: 1
      DOCKER_VERNEMQ_DISCOVERY_NODE: vmq_discovery_node
    deploy:
      replicas: 2
    networks:
      - internal

networks:
  internal:
    driver: overlay

As expected, this results in a healthy discovery node which supplies two healthy worker nodes.
When introducing another network (like the one I wanted to utilize for traefik as shown below), this changes drastically:
version: "3.7"
services:
  vmq_discovery_node:
    image: vernemq:1.13.0
    environment:
      DOCKER_VERNEMQ_SWARM: 1
    networks:
      - internal

  vmq-main-nodes:
    image: vernemq:1.13.0
    environment:
      DOCKER_VERNEMQ_SWARM: 1
      DOCKER_VERNEMQ_DISCOVERY_NODE: vmq_discovery_node
    deploy:
      replicas: 2
    networks:
      - internal
      - traefik                                            # <- new

networks:
  internal:
    driver: overlay
  traefik:                                                 # <- new
    driver: overlay                                        # <- new

Taking a deeper look into the problem and what might cause it, I noticed that the error log shows the following:
Invalid -name given to erl<EMAIL_ADDRESS><IP_ADDRESS>

Indicating that the name of the node was mangled to something that includes two IPs.
The root of this can be found in the vernemq.sh startup script at lines 55ff:
# Ensure the Erlang node name is set correctly
if env | grep "DOCKER_VERNEMQ_NODENAME" -q; then
    sed -i.bak -r "s/-name<EMAIL_ADDRESS>VerneMQ@${DOCKER_VERNEMQ_NODENAME}/" ${VERNEMQ_VM_ARGS_FILE}
else
    if [ -n "$DOCKER_VERNEMQ_SWARM" ]; then
        NODENAME=$(hostname -i)
        sed -i.bak -r "s/VerneMQ@.+/VerneMQ@${NODENAME}/" ${VERNEMQ_VM_ARGS_FILE}
    else
        sed -i.bak -r "s/-name<EMAIL_ADDRESS>VerneMQ@${IP_ADDRESS}/" ${VERNEMQ_VM_ARGS_FILE}
    fi
fi

Here, hostname -i delivers multiple IPs in the case of multiple networks, rendering the script unfit for this case.
Maybe I am missing something here, but to me, multiple networks would be a necessity in a standard setup.
Please let me know if there are some thoughts mangled up in my mind and if I can do something to support troubleshooting.
Thanks for you help!

@GrigoriOH Thanks, I guess you have already found the issue (in the script). If you manage to fix this for you (and others), we'd be certainly thankful for a PR.

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Thanks for the quick response. I'll try to dig in to this and give a heads-up (or even PR). Not being a professional myself I'm looking forward for feedback or hints.

@GrigoriOH merged your patch, thanks for your contribution! :)


PHP Security Audit Scan Report import logic flaw

Bug description
PHP Security Audit Scan Report import logic seems flawed. JSON report generated by php security audit has two issue types "error" and "warning" for each file scanned.  Warnings are not imported if the file is not having any errors, where as if a file is having error and warning, then warnings are imported as well.
So for eg.

if file has 1 error and 3 warning, the parser checks if file has error count > 0, condition passes and imports all issues. ie 4 issues imported .
if file has 0 error and 3 warning, the parser checks if file has error count > 0, condition fails and no issues are imported for that file.

Above logic seems to be flawed. I am not a python developer but high level scan through of code I suspect code below contains the flawed logic to import based on error alone.
/dojo/tools/php_security_audit_v2/parser.py
Steps to reproduce
Steps to reproduce the behavior:

Go to findings
Click Import Scan results
Browse and Import sample PHP Security Scan report attached.
See all findings, you will notice files having only warning issues are not imported. Where as warning in files having error are imported.

Expected behavior
Expect all warning and errors to be imported.
Deployment method (select with an X)

[ ] Kubernetes
[ X] Docker
[ ] setup.bash / legacy-setup.bash

Environment information

Operating System: OSX
DefectDojo Commit Message: 1.5.4 Release

Sample scan files (optional)
Sample scan report, expected findings on import into DefectDojo is 19 issues but actual is 18.
phpcs_security_audit.txt

Made a PR for this:
https://github.com/DefectDojo/django-DefectDojo/pull/1705

PR #1705 is merged, so this issue can be closed


[DO NOT MERGE] Remove district councils from Buckinghamshire

This removes four district councils that now fall under Buckinghamshire County Council. This is a follow up PR to https://github.com/alphagov/collections/pull/2129.
Trello - https://trello.com/c/4RYRAlPM/978-update-buckinghamshire-data-before-mapit-data-goes-live
DO NOT MERGE
This shouldn't be merged until the above PR is in and the latest Mapit data is in production.

@JonathanHallam The data file has moved to config/local-restrictions.yaml

@leenagupte This has been rebased against master now so can be merged as and when the new mapit data goes live 🎉


unload method

In the public unload function, it appears you were missing a 's' in $stars.  I added it to my script and it appears to work.
`    unload: function(){
var name = 'plugin' + pluginName;
var $el = $(this);
var $star = $el.data(_name).$stars;
$el.removeData(_name);
$star.off();
}

Thanks!


Fixes more Paginations loops with value not being reset, and wrong value cloud be returned

Description
All this endpoints are susceptible to returning wrong data due to the Struct not getting reset for every iteration of the loop.
I fixed it by moving the variable declaration to inside the loop.
This is related to my other PR #1482 that fixed this for a single api endpoint.
I also found this PR that accomplished the same result in a different way #1016 . If you prefer this method, let me know. I can change them all to be in the same way.
And there is also this PR #1447 that is still missing the change-log. I cloud remove the 3 cases that PR fixes from mine, in case you want to merge that one too.

Has your change been tested?
Yes, go test ./... --race, and also some API calls.
But as I mentioned in #1482, I was not able to create tests that fail without this change, but it happens in runtime.
Most of the tests in this repo do not cover pagination.

Types of changes
What sort of change does your code introduce/modify?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

i haven't managed to set aside anytime for this lately but my concern is that there is no test coverage for this condition so it's hard to identify if this is actually addressing a problem. this hasn't been observed anywhere that we are using (in hundred of paginations) so i'm hesitant to blindly accept these ones. before we merge this, we need to either 1) find cases where this is a problem to confirm the fix or 2) identify a way to isolate this within a test case.

v2 provides the option to handle the pagination automatically so this is no longer needed.


Markdown column disappear

Category
cannot find markdown column in GitBook Editor.
What is the current behavior?

What is the desired behavior?

Additional information

Is this place still a feeback or discuss area?

I don't know. I already abandoned this software.


Fix showModal error inside shadow DOM (#186)

Added and used the isConnected function in order to reliably check whether an element is attached to DOM.

@googlebot I signed it!


Not working with Ionic 3.6

Hi,
I was trying out your plugin for my Ionic 3.6 app.
When I click the button to open the calendar, I am getting an error saying, that there is no CalendarPage declared in Entry Components.
appointment.html
<!--
  Generated template for the AppointmentsPage page.

  See http://ionicframework.com/docs/components/#navigation for more info on
  Ionic pages and navigation.
-->
<ion-header>

  <ion-navbar color="primary">
    <ion-title>Upcoming Appointments</ion-title>
  </ion-navbar>

</ion-header>

<ion-content padding>
  <ion-list>
    <ion-item (tap)="openCalendar()" >
      Current Date: {{curDate | date: 'dd-MMM-yyyy'}}
    </ion-item>
  </ion-list>
</ion-content>

appointment.ts
import { Component } from '@angular/core';
import { IonicPage, NavController, NavParams } from 'ionic-angular';
import { CalendarController } from "ion2-calendar/dist";
/**
 * Generated class for the AppointmentsPage page.
 *
 * See http://ionicframework.com/docs/components/#navigation for more info
 * on Ionic pages and navigation.
 */

@IonicPage()
@Component({
  selector: 'page-appointments',
  templateUrl: 'appointments.html',
})
export class AppointmentsPage {
  curDate = new Date();
  constructor(public navCtrl: NavController,
    public navParams: NavParams,
    public calendarCtrl: CalendarController) {
  }

  ionViewDidLoad() {
    console.log('ionViewDidLoad AppointmentsPage');
  }
  openCalendar() {
    this.calendarCtrl.openCalendar({
      from: new Date()
    })
      .then(res => { console.log(res) });
  }
}

appointment.module.ts
import { NgModule } from '@angular/core';
import { IonicPageModule } from 'ionic-angular';
import { AppointmentsPage } from './appointments';
import { CalendarModule, CalendarPage } from "ion2-calendar";
@NgModule({
  declarations: [
    AppointmentsPage
  ],
  imports: [
    CalendarModule,
    IonicPageModule.forChild(AppointmentsPage),
  ],
})
export class AppointmentsPageModule {}

Ionic Information
 @ionic/cli-utils  : 1.8.0
    ionic (Ionic CLI) : 3.8.0

global packages:

    Cordova CLI : 6.5.0

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : android 6.1.2
    Ionic Framework    : ionic-angular 3.6.0

System:

    Node : v8.1.0
    npm  : 5.0.3
    OS   : Windows 10

Screenshots
Appointment Page Before Clicking On Date

Appointments Page After Clicking On Date [Error]

Do you use lazy loading?

Yes

**Work for me with Ionic 3.6 and  lazy loading **
Cordova Platforms        : android 6.1.2 ios 4.3.1
Cordova CLI              : 6.5.0
Ionic Framework          : ionic-angular 3.6.0
Ionic CLI                : 3.10.3
Node       	         : v6.10.0
npm        		 : 5.3.0
ios-deploy 		 : 1.9.1
ios-sim    		 : 5.0.13
OS         		 : macOS Sierra
Xcode      		 : Xcode 8.3.3 Build version 8E3004b

I have same issue. Sorry, i am not sure what means lazy-load in this part. By the way this lib save my live. Thank you very much.

lazyload-demo

lazyload-demo link is not working. I want to refer this. Can you plz check it and make it work?

lazyload-demo

@HsuanXyz Can you make the code available again? Link is not working


Left Nav and Property Panel Background Colors

Change background colors for the left navigation and the property panel to match design in https://github.com/ld4p/sinopia/issues/299.

Do you have color codes @astridu ?

Light beige (overall background color of left nav): F0EAE4
Medium beige (for highlighting section you're on): D0C1A8
Dark brown (for check marks or the Instance tabs if you're going to put those in the left nav): 5F574F

Here's a more comprehensive style guide. Let me know if I should put this somewhere else. https://docs.google.com/document/d/12IbU5_e0cb9k1lKTOVe0HMarYYA0dG10LzIcvDyX9fo/edit?usp=sharing

Here's a more comprehensive style guide. Let me know if I should put this somewhere else. https://docs.google.com/document/d/12IbU5_e0cb9k1lKTOVe0HMarYYA0dG10LzIcvDyX9fo/edit?usp=sharing

Thanks @astridu, I'll pull out sections into separate tickets like #2439

@astridu I don't see F0EAE4 (light beige) anywhere in the style guide. Am I missing something?

Cut and pasted incorrectly in design doc. Please use: F0EAE4
Thanks

@astridu are we still doing this left nav design?

This isn't in the design document, but it is in #299

No, this ticket is old. See: https://invis.io/ATY349JEPSW#/430680145_records_Right_Panel_2

I updated the ticket and design doc with the updated info.

Closing based on comments in the issue.


improve exception details when karate.call fails in js script

today when karate.call is made using js function it throws generic exception with no details
       * def fun =
          """
		function() {
		  		  try {
		    			  karate.call('classpath:com/intuit/karate/test/js-test-abstract.feature')
		  			   }catch (e){
		    				return(e);
		  			  }
		}
	"""
    * def e = fun()
    * print 'exception>>>',e

[print] exception>>> com.intuit.karate.KarateException: http call failed after 4519 milliseconds for url: https://localhost:8080/abcd/xyz/3.1
classpath:com/intuit/karate/test/js-test-abstract.feature:15
The actual exception is suppressed
19:33:57.062 [main] ERROR com.intuit.karate - javax.net.ssl.SSLException: Unsupported or unrecognized SSL message, http call failed after 425 milliseconds for url: https://localhost:8080/abcd/xyz/3.1
It will help adding these details to serve odd cases like https://stackoverflow.com/questions/55095314/

this is low priority for us, anyone is welcome to contribute a PR

I already did some homework and seems to me this is the class   https://github.com/karatelabs/karate/blob/4257ec44b1f04f65b41de963c84904798b1b5d6a/karate-core/src/main/java/com/intuit/karate/core/Result.java#L139-L150
I can append error.getCause()  to StackTraceElement  at line number 146

I did some homework and seems this is the class tha would need change:
https://github.com/karatelabs/karate/blob/4257ec44b1f04f65b41de963c84904798b1b5d6a/karate-core/src/main/java/com/intuit/karate/core/Result.java#L139-L150
Change>>
    String message = error.getMessage();
    String errCause = error.getCause().getMessage();
    if (message == null) {
            message = error + ""; // make sure we show something meaningful
        }
    error = new KarateException(message + "\n" + step.getDebugInfo() + "\n" + errCause);

Output >>>>
19:31:17.003 [main] INFO  com.intuit.karate - [print] exception>>> com.intuit.karate.KarateException: http call failed after 4610 milliseconds for url: https://localhost:8080/sapi/hws/3.1
classpath:com/intuit/karate/test/js-test-abstract.feature:15
java.lang.RuntimeException: org.apache.http.conn.HttpHostConnectException: Connect to localhost:8080 [localhost/<IP_ADDRESS>,

@shrik18 that code has evolved over 6 years to keep the logs free of noise. I think getCause() can return null in some cases. anyway, a PR and thorough testing (and observation) is required.

@ptrthomas agreed due diligence is required and indeed getCause() possibly can return null.
I have another solution where I can make this change.
https://github.com/karatelabs/karate/blob/4257ec44b1f04f65b41de963c84904798b1b5d6a/karate-core/src/main/java/com/intuit/karate/core/ScenarioEngine.java#L594-L612
Line 611 : this is where actual exception is added to cause. I can ammend this to
throw new KarateException(message +"\n" + e.getMessage(), e)
This way we are pretty much sure only http failures exceptions are added to message, and no risk of null pointer
Its up to you to choose the solution and I will raise a PR.

1.4.0 released


Exception when reading .jar file inside of other .jar file

I have a Play project that depends on ehcache (net.sf.ehcache:ehcache:2.10.4) (Play's default cache implementation), and DependencyCheck (run through sbt) fails to analyze the dependency, reporting the following errors:
[pool-44-thread-2] WARN org.owasp.dependencycheck.analyzer.JarAnalyzer - Unable to open jar file 'ehcache-2.10.4.jar: sizeof-agent.jar'.
[pool-44-thread-2] WARN org.owasp.dependencycheck.AnalysisTask - An error occurred while analyzing '/var/folders/5c/p1x3_s_15xqdgk3ymdc7nlb00000gn/T/dctemp19b35bbb-49b5-439b-a0c1-723a83456bf1/check8199102204704974843tmp/49/net/sf/ehcache/pool/sizeof/sizeof-agent.jar' (Jar Analyzer).

[error] (root/*:dependencyCheck) org.owasp.dependencycheck.exception.ExceptionCollection: One or more exceptions occurred during dependency-check analysis
[error] 	Archive file was not found.
[error] 	Exception occurred reading the JAR file (ehcache-2.10.4.jar: sizeof-agent.jar).

When checking ehcache-2.10.4.jar, I noticed that there is a sizeof-agent contained in the jar, at the reported path of net/sf/ehcache/pool/sizeof/sizeof-agent.jar. Once extracted, I have no problems opening this jar file with other tools.
This error is failing the entire build and therefore I have to disable DependencyCheck, because I found no way to exclude this jar file either.

Sorry, turns out simply updating sbt-dependency-check made the error go away. Closing.


Where to put JMS specific headers?

The documentation for version 2.6.0 of the AsyncAPI spec seems to contradict itself regards protocol specific headers for JMS.
It says here: https://www.asyncapi.com/docs/reference/specification/v2.6.0#messageObject

Schema definition of the application headers. Schema MUST be of type "object". It MUST NOT define the protocol headers.

However, if I follow the documentation through:

A Message object may have a traits property.
A Message Trait object may have a bindings property
A Message Bindings object may have a
jms property.
The JMS Message Binding object does not permit any properties.

If I cannot put the protocol specific headers in the Message or Message Trait, and if I can't put them in the JMS Message Binding... where can I put them?

@adamretter in AsyncAPI all protocol-specific semantics are delegated to AsyncAPI bindings. You can also have Message level bindings. The problem is just that nobody yet from JMS community took time to contribute what these should be and volunteer to maintain it in future.
there was some enquiry in the past https://github.com/asyncapi/bindings/issues/87 but did not go too far.
does that help?

@derberg That is helpful thanks. So I guess we should put things in the JMS Message Binding object of our Async API Schema.
We are not experts in JMS, but we can try and help; would you be happy to receive a PR against https://github.com/asyncapi/bindings/tree/master/jms from us?

Yes please!!! it is hard to find someone to do first step. You might not be experts but doing first step will enable us to share your PR with rest of the community to drag them in with feedback. Thanks 🙏
Once you open up a PR we will close this issue. For now leaving it open to have it as reminder

Thanks @derberg I have sent a PR for a set of JMS bindings to here - https://github.com/asyncapi/bindings/pull/193