certs are valid. Maybe swarm is not started?

create a docker machines with generic
they were not provisioned.
so pasted the certs manually..
now the docker-machines are created ..
These machines were created with --swarm flags, with one of them as master. Able to execute commands on machines but not in swarm. The consul was running outside the swarm cluster.
$ docker-machine config --swarm v36
Error running connection boilerplate: Connection to Swarm cannot be checked but the certs are valid. Maybe swarm is not started

Can you please paste the --debug results of the create as well as the config call?  Thanks!

@navinSing can you take a look at swarm logs? I guess swarm is either not running or has a configuration issue.
docker-machien ssh v36
docker logs swarm-agent-master

@dgageot , yes swarm-agent-master is not started, yet docker-machine is showing that. NOTE : i started consul outside the docker-machine list(on my laptop, even the consul is not showing swarm) .. should it be part of the docker-machine list.
docker-machine ls
NAME   ACTIVE   URL       STATE     URL                       SWARM          DOCKER   ERRORS
v34    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v35    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v36    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36 (master)   v1.9.1
v37    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
=============
docker-machien ssh v36
$ docker logs swarm-agent-master
Error response from daemon: no such id: swarm-agent-master
$ docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
@nathanleclaire
export MAC_NAME="v38"
export MAC_ETH="eth0"
export MAC_IP="<IP_ADDRESS>"
kowo@gomo:/mo/jo/deploy/jj$ export CONSUL_IP=<IP_ADDRESS> &&  docker-machine --debug  create -d generic --generic-ip-address $MAC_IP --generic-ssh-key /mo/keysOfServers/vvwCommon/id_rsa --generic-ssh-user vvw --swarm --swarm-image="swarm:latest" --swarm-discovery="consul://$CONSUL_IP:8500" --engine-opt="cluster-store=consul://$CONSUL_IP:8500" --engine-opt="cluster-advertise=$MAC_ETH:2376" $MAC_NAME
Docker Machine Version:  0.5.6, build 61388e9
Found binary path at /usr/local/bin/docker-machine
Launching plugin server for driver generic
Plugin server listening at address <IP_ADDRESS>:32962
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(flag-lookup) Calling .GetMachineName
(flag-lookup) Calling .DriverName
(flag-lookup) Calling .GetCreateFlags
Found binary path at /usr/local/bin/docker-machine
Launching plugin server for driver generic
Plugin server listening at address <IP_ADDRESS>:41509
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(v38) Calling .GetMachineName
(v38) Calling .DriverName
(v38) Calling .GetCreateFlags
(v38) Calling .SetConfigFromFlags
Running pre-create checks...
(v38) Calling .PreCreateCheck
(v38) Calling .GetConfigRaw
Creating machine...
(v38) Calling .Create
(v38) Importing SSH key...
(v38) DBG | IP: <IP_ADDRESS>
(v38) Calling .GetConfigRaw
(v38) Calling .DriverName
(v38) Calling .DriverName
Waiting for machine to be running, this may take a few minutes...
(v38) Calling .GetState
Machine is running, waiting for SSH to be available...
Getting to WaitForSSH function...
(v38) Calling .GetSSHHostname
(v38) Calling .GetSSHPort
(v38) Calling .GetSSHKeyPath
(v38) Calling .GetSSHKeyPath
(v38) Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i /home/kowo/.docker/machine/machines/v38/id_rsa -p 22] /usr/bin/ssh}
About to run SSH command:
exit 0
SSH cmd err, output: :
Detecting operating system of created instance...
Detecting the provisioner...
(v38) Calling .GetSSHHostname
(v38) Calling .GetSSHPort
(v38) Calling .GetSSHKeyPath
(v38) Calling .GetSSHKeyPath
(v38) Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i /home/kowo/.docker/machine/machines/v38/id_rsa -p 22] /usr/bin/ssh}
About to run SSH command:
cat /etc/os-release
SSH cmd err, output: : NAME="Ubuntu"
VERSION="14.04.3 LTS, Trusty Tahr"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 14.04.3 LTS"
VERSION_ID="14.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
found compatible host: ubuntu
Provisioning with ubuntu(upstart)...
(v38) Calling .GetMachineName
(v38) Calling .GetSSHHostname
(v38) Calling .GetSSHPort
(v38) Calling .GetSSHKeyPath
(v38) Calling .GetSSHKeyPath
(v38) Calling .GetSSHUsername
Using SSH client type: external
{[-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=quiet -o ConnectionAttempts=3 -o ConnectTimeout=10 -o ControlMaster=no -o ControlPath=none<EMAIL_ADDRESS>-o IdentitiesOnly=yes -i /home/kowo/.docker/machine/machines/v38/id_rsa -p 22] /usr/bin/ssh}
About to run SSH command:
sudo hostname v38 && echo "v38" | sudo tee /etc/hostname
SSH cmd err, output: exit status 1: sudo: no tty present and no askpass program specified
Error creating machine: Error running provisioning: Something went wrong running an SSH command!
command : sudo hostname v38 && echo "v38" | sudo tee /etc/hostname
err     : exit status 1
output  : sudo: no tty present and no askpass program specified
kowo@gomo:/mo/jo/deploy/jj$ docker-machine ls
NAME   ACTIVE   URL       STATE     URL                       SWARM          DOCKER    ERRORS
v34    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v35    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v36    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36 (master)   v1.9.1
v37    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v38    -        generic   Running   tcp://<IP_ADDRESS>:2376                  Unknown   Unable to query docker version: Unable to read TLS config: open /home/kowo/.docker/machine/machines/v38/server.pem: no such file or directory
############## copy .pem files
ls
$ docker-machine ls
NAME   ACTIVE   URL       STATE     URL                       SWARM          DOCKER   ERRORS
v34    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v35    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v36    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36 (master)   v1.9.1
v37    -        generic   Running   tcp://<IP_ADDRESS>:2376   v36            v1.9.1
v38    -        generic   Running   tcp://<IP_ADDRESS>:2376                  v1.9.1
$  docker-machine --debug config --swarm v36
Docker Machine Version:  0.5.6, build 61388e9
Found binary path at /usr/local/bin/docker-machine
Launching plugin server for driver generic
Plugin server listening at address <IP_ADDRESS>:40970
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(v36) Calling .GetURL
Reading CA certificate from /home/kowo/.docker/machine/certs/ca.pem
Reading server certificate from /home/kowo/.docker/machine/machines/v36/server.pem
Reading server key from /home/kowo/.docker/machine/machines/v36/server-key.pem
(v36) Calling .GetURL
Reading CA certificate from /home/kowo/.docker/machine/certs/ca.pem
Reading server certificate from /home/kowo/.docker/machine/machines/v36/server.pem
Reading server key from /home/kowo/.docker/machine/machines/v36/server-key.pem
Error running connection boilerplate: Connection to Swarm cannot be checked but the certs are valid. Maybe swarm is not started

Hm. If the create fails Swarm is not guaranteed to be working.  Maybe that's the issue here?

Actually the certs files were not there, hence docker-machine cannot ssh at that time.. have to manually copy it.
Can we have a default cert file path to pick this up or probably a command line args to pick up these certs .. so that the machine could be ssh'ed into and swarm master would then be created at creation time.(with create command.)

@nathanleclaire  @dgageot
Any luck on the bug.

Actually the certs files were not there, hence docker-machine cannot ssh at that time.. have to manually copy it... hence the swarm-master was not created; but docker-machine shows that ... any other way to restart or manually create the swarm-master in the docker cluster.. Pls help, thanks.

Ah ! got it closed by mistake ..

I'm running into this issue (or a similar one) as well on the RC1.  Looks like the created Swarm containers don't have any ports forwarded.
docker@swarmmaster:~$ docker ps
CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS                         PORTS               NAMES
14b31947dffe        swarm:latest        "/swarm join --advert"   8 minutes ago       Up 8 minutes                                       swarm-agent
28c103f6e0d3        swarm:latest        "/swarm manage --tlsv"   8 minutes ago       Restarting (1) 2 minutes ago                       swarm-agent-master


Deprecated method return types when running on PHP 8.1

When running an application with PHP 8.1, these deprecation message are shown, since the plugin requires php >=7.2 and mixed type was added only at PHP 8, the best solution is to add the  #[\ReturnTypeWillChange]  for each method. What do you say?
[Deprecated (8192) ](javascript:void(0);): Return type of MiniAsset\AssetCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [in /app/vendor/markstory/mini-asset/src/AssetCollection.php, line 142]
[Deprecated (8192) ](javascript:void(0);): Return type of MiniAsset\AssetCollection::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [in /app/vendor/markstory/mini-asset/src/AssetCollection.php, line 167]
[Deprecated (8192) ](javascript:void(0);): Return type of MiniAsset\AssetCollection::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [in /app/vendor/markstory/mini-asset/src/AssetCollection.php, line 152]
[Deprecated (8192) ](javascript:void(0);): Return type of MiniAsset\AssetCollection::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [in /app/vendor/markstory/mini-asset/src/AssetCollection.php, line 157]
[Deprecated (8192) ](javascript:void(0);): Return type of MiniAsset\AssetCollection::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [in /app/vendor/markstory/mini-asset/src/AssetCollection.php, line 162]
[Deprecated (8192) ](javascript:void(0);): Return type of MiniAsset\AssetCollection::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice [in /app/vendor/markstory/mini-asset/src/AssetCollection.php, line 147]

A new version of MiniAsset has been released. The deprecation warnings you were seeing should be fixed now.


Return EOA address on WalletConnect

Description
In the WalletConnect integration we are returning the MTW address instead of the EOA. This is super dangerous! Users that connect using WalletConnect might end up making transactions to the MTW address and recovering the funds might be a bit painful (they wouldn't be lost, but it would be annoying).
Other changes
N/A
Tested
Using use-contractkit
How others should test
Hard to test because the public version of use-contractkit doesn't work (I tested with a local version with some minor changes). If it did work one could simply connect your account in that website and check that the address listed is the EOA.
Related issues

Fixes #1075

Backwards compatibility
N/A

Hey @gnardini , We have verified this issue using latest Test flight build V 1.19.0 and Android internal build V1.19.0 & updated status in Gsuite.
GSuite Link: https://docs.google.com/spreadsheets/d/1bWi6smdTMClreG96sGjYxb2lee9Ja6eT4-Lm7eXm1gM/edit#gid=761279479
Verified On Devices: Redmi note 8 (10.0), iPhone 12 (14.7.1)
Query:
We have observed that, we are not able to scan QR code using use-contractkit  on  latest Test flight build V 1.19.0 and Android internal build V1.19.0 from scan section of connected apps. Attachment: Not Able to scan Qr Code.mp4
CC: @tarikbellamine

https://valora.testquality.com requirement R87.

Hey @MuckT We have verified this issue using latest Test flight build V 1.19.0 and Android internal build V1.19.0 & updated status in Test Quality Tool
Test Quality Tool link:
Android (9.0):   https://valora.testquality.com/project/12128/plan/21816/run/150277/result/2485120 Verified On Devices: Redmi Note 8 (9.0)                                                                                @gnardini


WIP: implement scipy.sparse.linalg.cg (second try)

Alternate version of https://github.com/google/jax/pull/1821

@TuanNguyen27 could you OK using your commits in this PR? See the note above from @googlebot for instructions.

@googlebot I consent.


[SC-111] Deploy to multiple environments

Setup travis to deploy the synpase login application to multiple
Beanstalk environments.
Merges to develop branch deploys to scipooldev while merges
to prod branch deploys to scipoolprod.

Will this repo' (synapse-login-scipool) subsume the repo' synapse-login-scipoolprod?  If so, I like it because it seems better that a repo' should NOT refer only to dev or prod (that's the role of the multiple branches in a repo').

Yes, that is correct.  That's why i had to rename the repo, but instead of rename i created a new repo and will remove synapse-login-scipoolprod after SC-111 is complete


AttributeError: 'NoneType' object has no attribute 'headers'

This is on version oauthlib 1.0.0.
Traceback (most recent call last):
File "keystoneclient/tests/unit/v3/test_oauth1.py", line 235, in test_create_access_token_expires_at
oauth_client)
File "keystoneclient/tests/unit/v3/test_oauth1.py", line 112, in _validate_oauth_headers
header_params = oauth_client.get_oauth_params(None)
File "/usr/lib/python2.7/dist-packages/oauthlib/oauth1/rfc5849/init.py", line 181, in get_oauth_params
content_type = request.headers.get('Content-Type', None)
AttributeError: 'NoneType' object has no attribute 'headers'
Should get_oauth_params() be checking if request is None or is that a user error?

That looks like a user error to me.  get_oauth_params specifies 1 argument -- a request -- and you're explicitly sending in None.

Fair enough, thanks for looking.


Macro to call token change via table roll or selection

Love the module so far, currently I have a player we use the module for who updates his token manually when entering rage (he loves it).
However I was hoping this change could be done automatically via via a hook to the module in a macro. So when rage is executed set token to a specific token in the assigned roll table.
Something along those lines. We still use the manuel change for RP purposes but this is just a QOL suggestion where people may want some automation.
Thanks!

This should be doable, yeah. I'm also going to improve the UX of switching images manually to make it possible to do via the Token HUD, so even without automation it should be much less work to quickly switch images.
For macros, I'll try to add a method to do this easily.


Link to migration guide is not public

Link mentioned in release notes to "Migrate from v10 to v11" points to private website.
https://github.com/googleads/swift-package-manager-google-mobile-ads/releases/tag/11.0.0

Hey @machl, thanks for flagging. This has been fixed. Thanks!


this version doesn't exist: github

I got this error , when I try login via github oauth.
this version doesn't exist: github

this is a self hosted repoman.

Please check if this env vars are configured correctly:
OAUTH_GITHUB_CLIENT_ID=
OAUTH_GITHUB_CLIENT_SECRET=

From: https://github.com/settings/developers
I would also need to know where this error occurs exactly.


Is there a OrderActionGroupsBy equivalent in Swashbuckle.AspNetCore?

Just wondering if there is a OrderActionGroupsBy equivalent in AspNetCore so that groups can be custom ordered? Can documentFilter/operationFile be used to achieve this?

Closing this out due to age - if you're still experiencing this problem with the latest version of Swashbuckle please open a new issue.


Links error

following link doesnt work : [this PowerShell Dockerfile.] https://github.com/PowerShell/PowerShell/blob/master/docker/release/nanoserver-insider/Dockerfile

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 74bec137-485e-eb01-851c-fcbe46894c57
Version Independent ID: cbcfb6ac-b17a-ace2-17b8-821af8dd64e0
Content: Build and run an application with or without .NET Core 2.0 or PowerShell Core 6
Content Source: virtualization/windowscontainers/quick-start/Nano-RS3-.NET-Core-and-PS.md
GitHub Login: @ulutasgo

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


replace nebulouslabs with skynethq

Mostly good, but skynet-js isn't migrated yet, so we should wait to merge or just fix others and do another PR later

@MSevey You need to do the replacement in v3/index.html.md as well as that is the latest version, also v3-beta? v2 and v1 can remain as they are. Also I think you missed some links.

Mostly good, but skynet-js isn't migrated yet, so we should wait to merge or just fix others and do another PR later

skynet-js and now be migrated.

@MSevey You need to do the replacement in v3/index.html.md as well as that is the latest version, as well as v3-beta. v2 and v1 can remain as they are. Also I think you missed some links.

updated

Closing in flavor of https://github.com/SkynetHQ/skynet-docs/pull/12, which is more complete and handles the new v4 docs as well.


Preserve leading comments within jss-to-tss-react

I have not added an automated test. Since preserving comments is (ideally) common behavior across several codemods, I wasn't sure about the best place to add a test.

[X] I have followed (at least) the PR section of the contributing guide.

@joshkel Thanks for finding this issue! There is an issue with preserving comments, but it isn't specific to the first node. The issue is that comments are lost for any imports that get replaced or removed. For instance in the following block, the Test makeStyles comment comment will be lost when the import is replaced with a tss-react import.
import React from "react";

/*
Test makeStyles comment
 */
import { makeStyles } from "@material-ui/core";
import clsx from "clsx";

In contrast, if you place a comment before the React import, it is preserved just fine since the codemod doesn't touch that import.
It is fairly straightforward to fix the makeStyles comment case above. If there was a comment on the clsx import, that would be a bit trickier since that import gets completely removed rather than replaced; but it isn't clear that retaining a comment in that case would be desirable.
As far as automated tests, I recommend adding comments to one of the existing actual/expected file pairs and make sure the test fails without any jss-to-tss-react.js changes before attempting a fix.
Let me know whether or not you want to take a crack at redoing your fix in a way that isn't specific to the first node. If you don't want to take care of that, I can take care of it sometime soon.

@joshkel Since you haven't expressed any interest in reworking this pull request, I've created a replacement (#33170) that covers a broader set of scenarios (not just the first node) and avoids removing existing comments (in the case when the first node was removed, but the new first node already had comments of its own) and has test coverage, so I'm closing this one.

Thanks for taking care of this, @ryancogswell. I apologize for not following up.


Upgrade sbt launcher script (sbt-extras)

Actually, this PR updates the sbt launcher, and tells travis to use it -- we don't have to do that, we're currently using whatever sbt is preconfigured in the travis environment, which I assume will be fixed soon: https://twitter.com/travisci/status/621055235038035968

looks like there is some escaping bug here. Legit failure.

what do you think about the previous comment though? this build wasn't using the ./sbt at all, it was using the pre-installed sbt

Well, the problem with using their installed sbt is that we are at their mercy, and we are not testing how we develop locally or how our contributors might use sbt. I think it is nicer to have the only dependency be a jvm, otherwise we will have to support a lot of sbt issues for new contributors.
So, I'd rather standardize on the launcher being in the state of the repo.

yeah sgtm, i'll try to fix this one

OK, think it's fixed. Looks like a property test found a bug though:
[info] - UUID -> String
[info] - URL -> String *** FAILED ***
[info]   IllegalArgumentException was thrown during property evaluation.
[info]     Message: invalid host wildcard specification
[info]     Occurred when passed generated values (
[info]       arg0 = http://鷕ﺌ遦ꆙ諪玄饆ᙆ䊡⺓壑著錮쾠䗚㧪ى᭲岻㒾픷挵壨頛㚚‛ᾍ䲊椄ᄀ뒾葊쟿旬䌡㝖俶펪佩昏᜞狖嘲僀ãꗷⶈ㢊ᗽ㫋*Ꞝ梞⬚츙.com
[info]     )

looks like it might be the *

We should fix that test. It does fail with randomly generated unicode, which is not a good way to generate URLs.

I've been trying (and failing) to find a string that repros this. Copying the above example doesn't seem to work (probably something is lost in the copy)

the odd thing is we do Try(new Url(_)), and the only other method called on this object is .toString. the error "invalid host wildcard specification" comes from here: https://github.com/openjdk-mirror/jdk/blob/jdk7/jdk7/master/src/share/classes/java/net/SocketPermission.java#L425 but I don't yet see why / how we end up there

seems like you get there by a) having a security manager and b) calling openConnection -- I don't know why we'd be doing b, and maybe a) has to do with travis setting one up?

turns out URL.java is pretty complicated :/


Add tags to the listing

Category: Services -> Tutoring
I cannot add any tags to my listing using the Post page.
Tags are crucial to pop up in the Kijiji search! Also, a one repost button would be helpful too!

Will look into the tags. Shouldn't be too difficult.
Not sure what you mean by a one repost button? Could you clarify?

Will look into the tags. Shouldn't be too difficult.
Not sure what you mean by a one repost button? Could you clarify?

After analysis of the traffic regarding tag attributes under the services categories, it was discovered that they simply do not exist on the mobile version. This reposter uses the kijiji mobile api, not the web api. If you post a service using the mobile app, there are no tag options. The kijiji reposter app uses a dynamic attribute generator that takes the attributes directly from the kijiji mobile server and generates a posting page on the fly, meaning it's always up to date. So looks like you're out of luck until they add a tags option to the mobile app.

After analysis of the traffic regarding tag attributes under the services categories, it was discovered that they simply do not exist on the mobile version. This reposter uses the kijiji mobile api, not the web api. If you post a service using the mobile app, there are no tag options. The kijiji reposter app uses a dynamic attribute generator that takes the attributes directly from the kijiji mobile server and generates a posting page on the fly, meaning it's always up to date. So looks like you're out of luck until they add a tags option to the mobile app.

marking this as closed, as the issue lies with kijiji's mingle server, not the reposter.

marking this as closed, as the issue lies with kijiji's mingle server, not the reposter.


[Bug]:  Top topbar is not transparent

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Expected Behavior
No response
Steps To Reproduce
No response
Environment
- OS: 13.0.1
- VSCode: 1.77.1
- Extension: 1.1.14

Anything else?
No response

Please ensure that all of your "Window" settings are set to default, there are quite a few settings there that cause VSCode to render the default macOS window controls if changed.

Please ensure that all of your "Window" settings are set to default, there are quite a few settings there that cause VSCode to render the default macOS window controls if changed.

Thank you very much, I found the reason. The current setting here is "custom"


Improve filtering performance of Stream

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12160.

Are we going to include this into 0.6?

@ButterBright Please fix e2e.

I will leave this @hanahmily whether we include this into 0.6 or we should cut 0.6 first and do more tests for this commit.

I will leave this @hanahmily whether we include this into 0.6 or we should cut 0.6 first and do more tests for this commit.

I prefer to hold this commitment for a while. Since this improvement is a performance issue, we should introduce benchmark testing in addition to traditional UTs and E2E testing.

@ButterBright @hanahmily Let's think how we could build tests to verify this? @hanahmily Is your local benchmark suitable for this case?

@ButterBright @hanahmily Let's think how we could build tests to verify this? @hanahmily Is your local benchmark suitable for this case?

Existing stress tests could also verify it, but we need to use a lightweight benchmark suite to do this job. I have discussed with @ButterBright to add some benchmarks to the package.

@ButterBright The benchmark result shows significant improvement. Can you analyze the benchmark to understand why the allocation is 0? This could provide valuable insights.

Sure.


Inexplicable DRCs from Magic

Description
Magic produces DRCs that seem false.    It reports violations like:
----------------------------------------
Metal2 overlap of via2 < 0.045um in one direction (via2.4a - via2.4)
----------------------------------------
 9.735um 46.335um 9.750um 46.380um

where the via looks legal:

(the small black square in the upper left is a violation marker).  This is viewing the inverter.magic.gds in klayout.
Environment
This is generated by my fork in https://github.com/The-OpenROAD-Project/OpenLane/pull/1059
python3 ./env.py issue-survey
Kernel: Linux v3.10.0-1160.45.1.el7.x86_64
Distribution: centos 7
Python: v3.6.8 (OK)
Container Engine: docker v20.10.14 (OK)
OpenLane Git Version: pdn-update-dev
pip: INSTALLED
pip:venv: INSTALLED
PDK Version Verification Status: OK
Git Log (Last 3 Commits)
840b5d9 2022-05-04T15:13:27-07:00 check FP_PDN_MACRO_HOOKS is set - Matt Liberty -  (HEAD -> pdn-update, origin/pdn-update)
df89226 2022-05-04T13:38:52-07:00 Update pdn scripts for new pdngen in OR - Matt Liberty -  ()
758fceb 2022-05-04T13:37:58-07:00 Modifed caravel_upw to have to instances connected to different supplies - Matt Liberty -  ()
Reproduction Material
Attached
bug.zip
This is just a run of my run area as I don't see a packager for magic issues.  The gds is included.
Expected behavior
An understandable DRC report.

Looking at the magic data, the overlap appears to be only 0.03um. On cifout, magic converts the cut area to vias that are drc clean.

The overlap between what gds layer/datatype exactly?  It does not have that appears in klayout or openroad.

@maliberty :  So the problem here is that magic gives you error messages relevant to magic's layers, not klayout's.  Magic is giving you an error message referring to a derived layer (magic's "via2") and a rule distance referring to two vendor rules: (via2.4a - via2.4).  Magic's rule for its derived via2 layer is a minimum overlap in one direction of 0.045um, which is the vendor overlap rule (0.085um) minus the minimum overlap that is already included in the derived "via2" layer (0.04um).  The vendor rule states that a minimum overlap of metal2 over (mask layer) via2 in one direction is 0.085um.  Your overlap is only 0.7um, which is why the layout is flagged with a DRC error.

I found out what the issue was in OR though I still find magic's report to be hard to grok.

@RTimothyEdwards where is the definition of these derived layers?

There is no specific definition of the derived layers because I haven't thought about a specific place and format for that information, but I guess it would be helpful to create a page for it in some of the online PDK documentation.
Magic's diagnostic output is written to be meaningful within the context of magic's layout view, and it will always be pretty inscrutable if you pull that diagnostic text out and then try to match it up to the view in another tool like klayout instead of magic.

@RTimothyEdwards The input I'm giving is my def file.  It is very confusing that you are modifying the data  I provide and then giving errors against the modified data.  I guess I'll have to learn to use magic as there is no other way to work but it is odd.  I don't have this issue with klayout or Calibre DRCs.

That's the way magic works.  If magic is the only tool that will read DEF, then your other choice is a little roundabout, but you can just use magic to read DEF and write GDS, then run klayout's DRC checker on the GDS, which will give you results more directly meaningful to the GDS mask-level data.

@RTimothyEdwards I don't have a choice as the unit tests are setup to use magic.


update installation doc

This would be useful in the installation guide for Linux, since I bumped into this error during make.
https://groups.google.com/forum/#!topic/openblas-users/DCtLunNlDzA
Instead, I ran make FC=gfortran and it built fine.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/11150934-update-installation-doc?utm_campaign=plugin&utm_content=tracker%2F69691&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F69691&utm_medium=issues&utm_source=github).

Done.
https://github.com/xianyi/OpenBLAS/wiki/Installation-Guide


CLOSE frame received, closing websocket connection

I subscribed to the ticker for all products at once, using the COMBINED method. But it raise a warning:CLOSE frame received, closing websocket connection. Is there a limit to the number of subscriptions?

I also has a similar question. I subscribe both ethusdt and btcusdt bookticker.  Then later I unsubscribe ethusdt and try to keep only btcusdt, but the result is that "CLOSE frame received, closing websocket connection".  How can I remove one of the symbol from the subscribe list?

I subscribed to the ticker for all products at once, using the COMBINED method. But it raise a warning:CLOSE frame received, closing websocket connection. Is there a limit to the number of subscriptions?

How many streams did you subscribe?

I also have a similar question. I subscribe both ethusdt and btcusdt bookticker. Then later I unsubscribe ethusdt and try to keep only btcusdt, but the result is that "CLOSE frame received, closing websocket connection". How can I remove one of the symbol from the subscribe list?

{
    "method": "UNSUBSCRIBE",
    "params":
        [
            "btcusdt@depth"
        ],
     "id": 1
}

To unsubscribe, you can send the above message to the server.

I myself found the problem of my code.
According to the binance document,

WebSocket connections have a limit of 10 incoming messages per second.
the "list_subscribe" is sent too frequently, so the server broke the connection.
I move the "list_subscribe" to a new thread and unsubscribe works well.

Thanks for update.


Remediate already allocated nodePort conflict in provider-local

How to categorize this PR?

/area dev-productivity
/kind bug
What this PR does / why we need it:
We sometimes see flaky tests because the hard-coded nodePorts in the local setup could already be allocated by other services. With this PR, provider-local's Service controller will identify the conflicting Service and assign a new random nodePort to it so that the reconciliation succeeds eventually .
Which issue(s) this PR fixes:
Fixes #6582
Release note:

NONE

/lgtm
/approve


AlertDialog: title+text layout error when focus changes

When the alert dialog text contains several TextFields in a column, when topmost received and looses focus layout changes making title part to stretch to text part even ignoring title's padding settings, unless the topmost TextEdit have some text in it. See attached video:
https://user-images.githubusercontent.com/300065/145812239-0778a2b4-4280-4243-bdda-2f53760c945a.mov
Code fragment:
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.paddingFromBaseline
import androidx.compose.material.AlertDialog
import androidx.compose.material.ExperimentalMaterialApi
import androidx.compose.material.OutlinedTextField
import androidx.compose.material.Text
import androidx.compose.runtime.*
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.em

@OptIn(ExperimentalMaterialApi::class)
@Composable
fun LayoutDialogErrorDemo() {
    var t1: String by remember { mutableStateOf("") }
    var t2: String by remember { mutableStateOf("") }
    AlertDialog(
        {},
        title = { Text("The Heading",fontSize = 1.4.em, modifier = Modifier.paddingFromBaseline(6.dp,4.dp)) },
        buttons = { Text("No buttons") },
        text = {
            Column(verticalArrangement = Arrangement.spacedBy(12.dp)) {
                OutlinedTextField(t1, { t1 = it }, label = { Text("Field1") })
                OutlinedTextField(t2, { t2 = it }, label = { Text("Field2") })
            }
        }
    )
}

It seems like just in general any top padding is ignored.

It seems like just in general any top padding is ignored.

Yes, unfortunately this is how an AlertDialog works, by design. It uses the baselines of the title and text to position them, which has the effect of ignoring their vertical padding.
Alert dialogs are only meant to be used with Text content: https://partnerissuetracker.corp.google.com/issues/217151230#comment7
We are working on a more general "Dialog" implementation. In the meanwhile, you can use the PopupDialog I posted here.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


skip QUERY method test

related: #5615
First step is to stop running this test until there is a node version which supports QUERY properly.
resolves the failure we see in node 21 latest and node 22 latest

I wonder if we should do this in the methods package? Not sure how widely used that is outside of express but this could help in a more broad way if done there.

Adding it to the methods module makes sense because it's an HTTP VERB.

Good point.
From the readme of methods though, that doesn't sound like the contract that it claims to expose:

methods
This is an array of lower-cased method names that Node.js supports. If Node.js provides the http.METHODS export, then this is the same array lower-cased, otherwise it is a snapshot of the verbs from Node.js 0.10.

I have seen a lot of skipped tests in codebases that stay skipped long after they should have been fixed.
Can we do something preventative to avoid this happening in this case?  For example, a check against process.version.  The idea being that the TODO is inverted and becomes a task to re-commit to the skip when a new version is being tested (which important is forced via a test failure), rather than a TODO to remember to bring back/fix the test.

that Node.js supports

But it doesnt yet support it correctly, so I feel like that is alright.

Thats a good point though @ctcpip
How bout we skip it in 21 and 22 only?
The benefit to the ecosystem here is that this test failed node's citgm for express. We found a gap in Node between http.METHODS and actual support it because it failed
We dont know what release of 21 or 22 we should run this test in. We know it fails rn on 21 and 22 (with it soon to pass in a release of at least 22).
But if 23 came out and it was broken, we'd def want to know that. Same for if it somehow could go red in any other past release.


Removing a toolbar brings up an error

Hello and thanks for this useful library,
I am not sure if I am using the library the right way but I don't understand if the toolbar is supposed to be a Leaflet Control?
I can add a toolbar using addControl:
this.toolbar = new L.Toolbar.Control({
                actions: actions,
                position: 'topleft',
                className: 'leaflet-draw-toolbar'
            });

            this.map.addControl(this.toolbar);

But I can't remove it with removeControl because the removeFrom method is not implemented in L.Toolbar.Control.
L.Toolbar inherits from L.Class, so it could be anything but from the name and behaviour, I believe it should behave like a Control? Because it can be a popup as well, you might have made it inherit from Class instead.
This is the method from Leaflet's L.Control:
removeFrom: function (map) {
		var pos = this.getPosition(),
		    corner = map._controlCorners[pos];

		corner.removeChild(this._container);
		this._map = null;

		if (this.onRemove) {
			this.onRemove(map);
		}

		return this;
	},

Thanks for your help,
Fabien

Note that adding
L.Toolbar.Control.prototype.removeFrom = function (map) {
            this.onRemove(map);
        }

Fixes the behaviour, so this is probably something forgotten during a refactoring

Hey @fnicollet - sorry for the confusion!
L.Toolbar.Control is not meant to implement L.Control. Similarly, L.Toolbar.Popup is not meant to implement L.Popup's interface. Leaflet.toolbar provides a class for building toolbar UI's (L.Toolbar), as well as a built-in "control-style" toolbar (L.Toolbar.Control) and a built-in "popup-style" toolbar (L.Toolbar.Popup).
All toolbars deriving from L.Toolbar present an interface similar to the interface for feature layers. That is, toolbars can be added to maps using:
toolbar.addTo(map); // preferred

or, alternatively:
map.addLayer(toolbar);

Similarly, toolbars can be removed from maps by calling
map.removeLayer(toolbar);

This is the result of a deliberate design decision that was intended to ensure a uniform API across all Leaflet.toolbar UI elements and make use of the familiar #addLayer and #removeLayer` methods provided by Leaflet core.
Sorry for the confusion! I've added a new note explaining this to the wiki: https://github.com/Leaflet/Leaflet.toolbar/wiki/API-Reference#adding-and-removing-toolbars.

ok, thanks for the precisions :)


style: Deprecate "exception" from the API and replace with "error"

Closes #161.
Deprecates methods with the word "exception" from the exported API and adds the same method with the word "error".
There are still some private methods with "exception" and exported structs with "exception" fields.

When the event gets sent to Sentry, we still have to use the exception key.
Btw, our Rust SDK uses sentry::capture_error(&err) as well, so I'm 👍 on this and will take a look!


Add NetBSD to FreeBSD build targets

Added support for amd64 and arm64 only.

FYI I tested building for all platforms on Mac and FreeBSD and it was successful.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.81%. Comparing base (05d44f5) to head (e380317).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   87.44%   85.81%   -1.64%
==========================================
  Files          13       14       +1
  Lines         701      592     -109
==========================================
- Hits          613      508     -105
+ Misses         69       67       -2
+ Partials       19       17       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks @cromedome! I'll get a new release out in the next day or two.


Cleanup desktop client environment and storage engine

Remove "resolve" constraints on states
Switch lovefield to some other database

nedb
lokijs

Move relevant functionality from providers to $rootScope

We have decided as part of this issue we will not be replacing the lovefield database. Instead, we have deprecated it as a dependency in the source code with plans to reimplement a new local data store when the debug feature in the application is demanded. We have opened issue #28 for the reimplementation  task.


Handle properly the error paths for the callback based auth

At the moment, the auth callbacks (JwtCallback and TokenRequestCallback) always require returning a value. This is fine when generating the token was successful. However, when the token generation failed, there is no clear way to communicate this to the AAT SDK.
We should consider how this is done in the ably-java and see how we can provide similar capabilities from the AAT SDK.
┆Issue is synchronized with this Jira Uncategorised by Unito

When there's an error while retrieving a token users should throw an exception. For now, if any exception is thrown the auth attempt fails and retries after 15 seconds. Ideally, we should provide custom AAT exceptions that would allow both notifying the Ably SDK to not retry the auth operation and notifying it that it should retry the operation.


Update README.md

As per the instructions for learning making PRs, i have added my name to the List!

Thank you @AllanRegush for reviewing 👍


dhcpv4 or rx ethernet packets not working on nucleo_f429zi

Hi,
I flashed dhcpv4_client sample application on my nucleo_f429zi board and unfortunately the board is not able to get any address from my DHCP server.
Describe the bug
I made wireshark analysis, and see that the board is able to send dhcp_discover packets, and get a response from DHCP Server with a dhcp_offer packet, but the board seems to ignore them.
To Reproduce
Steps to reproduce the behavior:

west build -p auto -b nucleo_f429zi samples/net/dhcpv4_client/

Expected behavior
The board should get an IP address from dhcp server.
Screenshots or console output
uart:~$ *** Booting Zephyr OS build zephyr-v2.2.0-1897-gd59ac4f0d50a  ***
[00:00:01.517,000] <dbg> eth_stm32_hal.eth_initialize: MAC 02:80:e1:d8:b3:a2
[00:00:01.517,000] <dbg> net_if.net_if_init: (0x20003ce0):
[00:00:01.517,000] <dbg> net_if.init_iface: (0x20003ce0): On iface 0x2000aca0
[00:00:01.517,000] <dbg> net_if.net_if_post_init: (0x20003ce0):
[00:00:01.517,000] <dbg> net_dhcpv4.net_dhcpv4_init: (0x20003ce0):
[00:00:01.523,000] <inf> net_dhcpv4_client_sample: Run dhcpv4 client
[00:00:01.523,000] <dbg> net_dhcpv4.net_dhcpv4_start: (0x20003ce0): iface 0x2000aca0 state=init
[00:00:01.523,000] <dbg> net_dhcpv4.net_dhcpv4_start: (0x20003ce0): wait timeout=7s
[00:00:02.010,000] <dbg> net_if.net_if_up: (0x20003d9c): iface 0x2000aca0
[00:00:02.010,000] <dbg> net_dhcpv4.dhcpv4_iface_event_handler: (0x2000371c): Interface 0x2000aca0 coming up
[00:00:02.010,000] <dbg> net_dhcpv4.dhcph4_manage_timers: (0x20003d9c): iface 0x2000aca0 state=init
[00:00:02.010,000] <dbg> net_dhcpv4.dhcpv4_enter_selecting: (0x20003d9c): enter state=selecting
[00:00:02.010,000] <dbg> net_dhcpv4.dhcpv4_send_discover: (0x20003d9c): send discover xid=0xb7d0fdf5 timeout=4s
[00:00:02.010,000] <dbg> net_dhcpv4.dhcpv4_timeout: (0x20003d9c): Waiting for 4s
[00:00:02.010,000] <dbg> net_if.net_if_tx: (0x20003a6c): Processing (pkt 0x20007700, prio 0) network packet iface 0x2000aca0/1
[00:00:06.010,000] <dbg> net_dhcpv4.dhcph4_manage_timers: (0x20003d9c): iface 0x2000aca0 state=selecting
[00:00:06.010,000] <dbg> net_dhcpv4.dhcpv4_send_discover: (0x20003d9c): send discover xid=0xb7d0fdf6 timeout=8s
[00:00:06.010,000] <dbg> net_dhcpv4.dhcpv4_timeout: (0x20003d9c): Waiting for 8s
[00:00:06.010,000] <dbg> net_if.net_if_tx: (0x20003a6c): Processing (pkt 0x20007700, prio 0) network packet iface 0x2000aca0/1

Environment :

OS: Debian 10
Toolchain: Zephyr SDK
2.2.99

I do not have exactly that hw, but tried this in nucleo_f767zi. The dhcpv4_sample client worked for me in Zephyr OS build v2.3.0-rc1-422-g76d8f8f1e268 just fine.

Hi Jukkar,
Thanks a lot for your help, it's working using the version v2.3.0-rc1-422-g76d8f8f1e268.
uart:~$ *** Booting Zephyr OS build v2.3.0-rc1-422-g76d8f8f1e268  ***
[00:00:01.607,000] <dbg> eth_stm32_hal.eth_initialize: MAC 02:80:e1:49:12:d5
[00:00:01.607,000] <dbg> net_if.net_if_init: (0x200047e4):
[00:00:01.607,000] <dbg> net_if.init_iface: (0x200047e4): On iface 0x20000a80
[00:00:01.607,000] <dbg> net_if.net_if_post_init: (0x200047e4):
[00:00:01.607,000] <dbg> net_dhcpv4.net_dhcpv4_init: (0x200047e4):
[00:00:01.613,000] <inf> net_dhcpv4_client_sample: Run dhcpv4 client
[00:00:01.613,000] <dbg> net_dhcpv4.net_dhcpv4_start: (0x200047e4): iface 0x20000a80 state=init
[00:00:01.613,000] <dbg> net_dhcpv4.net_dhcpv4_start: (0x200047e4): wait timeout=6s
[00:00:02.029,000] <err> eth_stm32_hal: Failed to enqueue frame into RX queue: -62
[00:00:02.029,000] <dbg> net_if.net_if_up: (0x200048a8): iface 0x20000a80
[00:00:02.029,000] <dbg> net_dhcpv4.dhcpv4_iface_event_handler: (0x20004210): Interface 0x20000a80 coming up
[00:00:02.029,000] <dbg> net_dhcpv4.dhcph4_manage_timers: (0x200048a8): iface 0x20000a80 state=init
[00:00:02.029,000] <dbg> net_dhcpv4.dhcpv4_enter_selecting: (0x200048a8): enter state=selecting
[00:00:02.029,000] <dbg> net_dhcpv4.dhcpv4_send_discover: (0x200048a8): send discover xid=0x6f558966 timeout=4s
[00:00:02.029,000] <dbg> net_dhcpv4.dhcpv4_timeout: (0x200048a8): Waiting for 4s
[00:00:02.029,000] <dbg> net_if.net_if_tx: (0x20004570): Processing (pkt 0x20008208, prio 0) network packet iface 0x20000a80/1
[00:00:05.038,000] <dbg> net_dhcpv4.net_dhcpv4_input: (0x200044dc): Received dhcp msg [op=0x2 htype=0x1 hlen=6 xid=0x6f558966 secs=0 flags=0x80 chaddr=02:80:E1:49:12:D5
[00:00:05.038,000] <dbg> net_dhcpv4.net_dhcpv4_input: (0x200044dc):   ciaddr=<IP_ADDRESS>
--- 19 messages dropped ---
[00:00:05.038,000] <dbg> net_dhcpv4.net_dhcpv4_input: (0x200044dc):   yiaddr=<IP_ADDRESS>
[00:00:05.038,000] <dbg> net_dhcpv4.net_dhcpv4_input: (0x200044dc):   siaddr=<IP_ADDRESS>
[00:00:05.038,000] <dbg> net_dhcpv4.net_dhcpv4_input: (0x200044dc):   giaddr=<IP_ADDRESS>]
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_server_id: <IP_ADDRESS>
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_lease_time: 86400
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_renewal: 43200
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_rebinding: 75600
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): option unknown: 28
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): option unknown: 6
[00:00:05.038,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_router: <IP_ADDRESS>
[00:00:05.043,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): option unknown: 15
[00:00:05.043,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_router: <log_strdup alloc failed>
[00:00:05.043,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_subnet_mask <log_strdup alloc failed>
[00:00:05.043,000] <dbg> net_dhcpv4.dhcpv4_parse_options: (0x200044dc): options_end
[00:00:05.043,000] <dbg> net_dhcpv4.dhcpv4_handle_reply: (0x200044dc): state=requesting msg=ack
[00:00:05.043,000] <inf> net_dhcpv4: Received: <log_strdup alloc failed>
[00:00:05.043,000] <dbg> net_if.net_if_ipv4_addr_add: (0x200044dc): [0] interface 0x20000a80 address <log_strdup alloc failed> type DHCP added
[00:00:05.043,000] <dbg> net_dhcpv4.dhcpv4_enter_bound: (0x200044dc): enter state=bound renewal=43200s rebinding=75600s
[00:00:05.043,000] <inf> net_dhcpv4_client_sample: Your address: <IP_ADDRESS>
[00:00:05.043,000] <inf> net_dhcpv4_client_sample: Lease time: 86400 seconds
[00:00:05.043,000] <inf> net_dhcpv4_client_sample: Subnet: <log_strdup alloc failed>
[00:00:05.043,000] <inf> net_dhcpv4_client_sample: Router: <log_strdup alloc failed>
[00:00:06.029,000] <dbg> net_dhcpv4.dhcph4_manage_timers: (0x200048a8): iface 0x20000a80 state=bound

I tested on the same board on today's master revision 72ebf70543fca78740888bc58319a19c2a3d636b at it worked (at least for my dhcp server):
$ west build -p auto -b nucleo_f429zi samples/net/dhcpv4_client/

...

*** Booting Zephyr OS build zephyr-v2.3.0-499-g72ebf70543fc  ***
[00:00:03.903,000] <inf> net_dhcpv4_client_sample: Run dhcpv4 client
[00:00:04.902,000] <inf> net_dhcpv4: Received: <IP_ADDRESS>
[00:00:04.902,000] <inf> net_dhcpv4_client_sample: Your address: <IP_ADDRESS>
[00:00:04.902,000] <inf> net_dhcpv4_client_sample: Lease time: 600 seconds
[00:00:04.902,000] <inf> net_dhcpv4_client_sample: Subnet: <IP_ADDRESS>
[00:00:04.902,000] <inf> net_dhcpv4_client_sample: Router: <IP_ADDRESS>

@Blobby19 can it be closed now, as you reported it was working ?

Closing as no response for more than one month


Scan with filter and limit omits some records

(Probably a clone of #86)
When scan request has a filter and a limit parameter, some of the records are omitted. Filter without limit is OK, limit without filter is OK, but not both at the same time. The same scenario works as expected against the AWS's Dynamo.
Here https://github.com/agibalov/aws-experiment/blob/master/dynamodb-experiment/src/test/java/io/agibalov/DynaliteScanLimitIssueTest.java#L20 I have a test that reproduces the issue. It runs the same scan query with limit changing from 1 to 29. Limits from 1 to 6 result in invalid results, 7 to 29 are perfectly OK.

Now that I'm looking at https://quay.io/repository/testcontainers/dynalite?tag=v1.2.1-1&tab=tags I'm under the impression that it's not 1.2.1. https://github.com/mhart/dynalite/releases/tag/v1.2.1 says June the 18th, while https://quay.io/repository/testcontainers/dynalite?tab=tags says March the 20th.
Let me close for now and try the real 1.2.1 where #86 is supposed to be fixed.


Make asynchronous calls to PDFExtractor Lambda functions

loop.run_until_complete(
asyncio.gather([list])
)

The answers will be returned through the objects passed as arguments (pdf_metadata?)

It seems the output can be fetched by a simple return (will be in a list)

Or even a yield

https://www.youtube.com/watch?v=s30oPx-tA-k ==> utilisation de aiohttp

async def fetch_urls():
await asyncio.gather(*(fetch_url) for url in urls))


Split Constant to individual literal nodes

Summary
This PR splits the Constant enum as individual literal nodes. It introduces the following new nodes for each variant:

ExprStringLiteral
ExprBytesLiteral
ExprNumberLiteral
ExprBooleanLiteral
ExprNoneLiteral
ExprEllipsisLiteral

The main motivation behind this refactor is to introduce the new AST node for implicit string concatenation in the coming PR. The elements of that node will be either a string literal, bytes literal or a f-string which can be implemented using an enum. This means that a string or bytes literal cannot be represented by Constant::Str / Constant::Bytes which creates an inconsistency.
This PR avoids that inconsistency by splitting the constant nodes into it's own literal nodes, literal being the more appropriate naming convention from a static analysis tool perspective.
This also makes working with literals in the linter and formatter much more ergonomic like, for example, if one would want to check if this is a string literal, it can be done easily using Expr::is_string_literal_expr or matching against Expr::StringLiteral as oppose to matching against the ExprConstant and enum Constant. A few AST helper methods can be simplified as well which will be done in a follow-up PR.
This introduces a new Expr::is_literal_expr method which is the same as Expr::is_constant_expr. There are also intermediary changes related to implicit string concatenation which are quiet less. This is done so as to avoid having a huge PR which this already is.
Test Plan

Verify and update all of the existing snapshots (parser, visitor)
Verify that the ecosystem check output remains unchanged for both the linter and formatter

Formatter ecosystem check
main

project
similarity index
total files
changed files

cpython
0.75803
1799
1647

django
0.99983
2772
34

home-assistant
0.99953
10596
186

poetry
0.99891
317
17

transformers
0.99966
2657
330

twine
1.00000
33
0

typeshed
0.99978
3669
20

warehouse
0.99977
654
13

zulip
0.99970
1459
22

dhruv/constant-to-literal

project
similarity index
total files
changed files

cpython
0.75803
1799
1647

django
0.99983
2772
34

home-assistant
0.99953
10596
186

poetry
0.99891
317
17

transformers
0.99966
2657
330

twine
1.00000
33
0

typeshed
0.99978
3669
20

warehouse
0.99977
654
13

zulip
0.99970
1459
22

Current dependencies on/for this PR:

main

PR #8062

PR #8063

PR #8064   👈

This comment was auto-generated by Graphite.

Thanks for the review! I'll make most of the smaller changes in this PR and move a few larger ones in the follow-up PRs:

Introduce LiteralExpressionRef which can be constructed using Expr::as_literal_expr
Unify multiple implementation of having constant type (LiteralKind, LiteralType, ConstantType) on the AST node as expr::literal_type() -> Option<LiteralType>


Fiat price fix for "My pool balance"

Description
Apparently the fix is quicker than I thought... I initially implemented the "latestPrices" subgraph query only to find out that this is the existing priceRate we already used.
Since total was calculated correctly, all what was needed is to use fiatAmounts (which already calcs the fiat amount)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other

How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.

[ ] Check "My pool balance" - total should match the sum of all the pool tokens.

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code where relevant, particularly in hard-to-understand areas
[ ] My changes generate no new console warnings
[ ] The base of this PR is master if hotfix, develop if not

@evgenyboxer I think I've fixed what this PR was aimed at fixing in the feature base branch.


Update to work on Julia 1.9

I embarked on this before realizing that @matthewware had already done basically the same thing in #31. This doesn't include the updates he has to the APS file format, or the start he made to support bbndb.

Wow, really bringing this one back from the grave, @blakejohnson! Thanks!
QGL.jl and pyQGL have significantly diverged with how the channel library is defined and used (it's a sqlite database now...), so I'm not sure what the right move is for thr future of QGL.jl. @grahamrow any thoughts? This might be a good jumping off point for the lower level language/IR we've been talking about as we get ready for the APS4...

Understood. I think if you want to actually use this, you would need to update how it deals with channel libraries. For my purposes, I just wanted to create a speed benchmark, and so the old YAML format was sufficient.


Bundle-License in MANIFEST.MF not evaluated in unpacked archives

For unpacked archives (i.e. for unpacked JARs) the Java scanning component (JavaJarFinder) does not take information on licenses available in the file MANIFEST.MF (tag 'Bundle.License') into account. It does, however, work for packed JARs.
Bug report
Expected Behavior - What where you expecting to happen?
Information in MANIFEST.MF / tag 'Bundle-License' in unpacked archives should be processed in the same way as for packed archives.
Current Behavior - What happens?
Information in MANIFEST.MF / tag 'Bundle-License' in unpacked archives is not taken into account for the collection of available license information.
Expected behaviour see above.
Possible Solution
In file JavaJarFinder, the prcrssing should be added between the lines 119 and 129. Note that there is already a comment stating '// TODO: fetch license header'.
What are the steps to reproduce this issue? (for bugs)
The issue can be reproduced with the unit test JavaJarFinderTest, method testScanJavaUnpackedLicenseManifest(), available in this branch:
https://github.com/pfistererm/LicenseScout/tree/mp_finder_unit_tests
Context

Any logs, error output, etc?
Your Environment

Version used: 1.3.1-SNAPSHOT of 2019-11-01
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop or mobile):

Notes and further information
JavaJarFinder is currently difficult to maintain. A refactoring may be considered.

Closed since resolved by #87


BS dropdown initial state

Open property is a part of public API but changing it to true as initial value will break the component as event for closing it won't be attached to body.
Fix applies only to v0.11.3 as newest release has made it private for unknown reason ;).

Your PR has conflicts probably because your PR targets master, which is actually the latest 1.0.0-alpha version, but as you said you are targeting 0.11.3, and for the latest version your code changes don't seem to apply. But actually I don't want to support the older 0.x range with updates, so this is probably not going to be merged, sorry!


Longest word in a Sentence (String based question)

Related Issue

#1149

Proposed Changes

Problem and full explained code is added.

Additional Info

Code is explained by comments in a simple manner.

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

In this, I have deeply explained how we approach the problem of finding the longest word in a sentence with a useful comment.

Given a string, we have to find the longest word in the input string and then calculate the number of characters in this word and print it.

#1149

[x] New feature (non-breaking change which adds functionality)

Output Screenshots

Screenshot #1

Code Output

Readme?

Describe the Problem here also

Describe the Problem here also

Readme?

Also changes added @Mrjoy832.

 Hey...Can you Fix the heading of 'String COmparison' please fix it like your

@Mrjoy832 Done Sir , Changes requested completed

LGTM🌟

@all-contributors please add @Pranshu321 code ,


Avoid Xcode 12 warning -> move to iOS 9

Updated to latest version
pod 'TPKeyboardAvoiding'
Usage Details

Language: Swift
Platform: iPhone
iOS Version: iOS 9 - 14

Expected Behavior
Xcode 12 build without warnings, proposal to move target to iOS 9
Actual Behavior
Xcode 12.x warning
The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.
Steps to Reproduce the Problem

Use latest Xcode 12 or 12.0.1
Use TPKeyboardAvoiding in a Swift project with target iOS 11

Please considerate that in my bigger project I am facing this waning for many external components and the it is difficult now for me to keep the overview of the relevant ones in order to resolve them.
Did you plan to move this project to iOS 9 already?
Thanks!

@tbechtum hello, you can try this patch solution, apparently the issue comes from CocoaPods:
# workaround solution for Xcode12 dropping iOS 8.0 support warning
 # cf. https://www.jessesquires.com/blog/2020/07/20/xcode-12-drops-support-for-ios-8-fix-for-cocoapods/
 post_install do |installer|
   installer.pods_project.targets.each do |target|
     target.build_configurations.each do |config|
       config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
     end
   end
 end

Thanks for your reply, but I need the deployment on iPhones. Seems to be a workaround. But are there any issues to move your support to iOS 9 and later (de-supporting iOS 8). Do you think you will loose clients?

Thanks for your reply, but I need the deployment on iPhones. Seems to be a workaround. But are there any issues to move your support to iOS 9 and later (de-supporting iOS 8). Do you think you will loose clients?

It is indeed a workaround, but as stated, it is an issue related to CocoaPods. I can't help regarding your other questions because I'm not the creator of the framework.
@michaeltyson is this framework still maintained ? it could be interesting to help contribute to it, as I have been freely profiting from it the past years, if you are in need for help.

Hi,
hope to be more clear, I am asking to move the deployment target of this project to iOS 9 and later in order to avoid the Xcode 12 warnings. I will try this later as soon as possible in a fork and let you know. Thanks.

@michaeltyson is this framework still maintained ? it could be interesting to help contribute to it, as I have been freely profiting from it the past years, if you are in need for help.

It is, @nicoonguitar, just a bit infrequently as I don't use it any more myself. I've just merged a few pull requests and pushed an update though.

Hi thanks a lot for your work, updated now to the latest version 1.3.5, this warning 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0' disappeared and TPKeyboardAvoiding works fine.


Portfolio - Bootstrap

Good job done 🥳. Your portfolio looks nice.
However, remember that any project can be improved!
Here are some suggestion(s) to help you improve your project:

Bootstrap is working perfectly fine but I suggest you remove the script tag in the head section and place it just before the closing tag of the /body at the bottom of the html. 👌👌👌👌There wouldn't be issues with the JavaScript codes of Bootstrap when the page loads.
Responsive version of the desktop has been implemented well 👏👏👏👏👏. I also suggest you check the responsiveness of the cards on the mobile screens.

Thanks @Theodoraldo for your kind feedback, actually the mobile version is not completed yet we just completed the desktop version completely but for the mobile version we just done with the top navbar and head section part but I will try to implement these changes. 💯 💯 👍


Eth Hive tests failing with mismatch forkID

https://hivetests.ethdevops.io/#suite=eth&client=besu
status exchange failed: wrong fork ID in status: have {[73 86 88 180] 0}, want {[188 12 38 5] 0}

fixed by https://github.com/ethereum/hive/pull/999


[Bug]: Custom Styles on iOS

Mapbox Implementation
Mapbox
Mapbox Version
11
React Native Version
0.71.8
Platform
iOS
@rnmapbox/maps version
10.1.19
Standalone component to reproduce
import {mapSelectedIdState, mapUserLocationState} from '@atoms/vehicle-map';
import {useGetVehiclesWithSnapshots} from '@hooks/queries/useGetAllSnapshots';
import Mapbox, {Camera, MapView} from '@rnmapbox/maps';
import {Box, Button, ImageBox} from '@theme';
import {useEffect, useRef} from 'react';
import {Platform} from 'react-native';
import {useRecoilState} from 'recoil';
import {VehicleMarker} from './Markers/VehicleMarker';
import {useCenterUserLocation, useUpdateUserLocation} from './utils';

export const MapV2 = () => {
  const [selectedId, setSelectedId] = useRecoilState(mapSelectedIdState);
  const [userLocation, setUserLocation] = useRecoilState(mapUserLocationState);

  const cameraRef = useRef<Camera>(null);
  const mapRef = useRef<MapView>(null);

  const updateUserLocation = useUpdateUserLocation();
  const centerUserLocation = useCenterUserLocation(cameraRef);

  const {data: vehicles} = useGetVehiclesWithSnapshots();

  var MapViewProps = {
    ref: mapRef,
    backgroundColor: 'transparent',

    // styleJSON: NEW_MAPBOX_STYLE,
  };

  const MapCameraProps = {
    ref: cameraRef,
    maxZoomLevel: 16,
    minZoomLevel: 10,
    zoomLevel: 14,
    animationDuration: 500,
  };

  useEffect(() => {
    centerUserLocation();
  }, [centerUserLocation, userLocation]);

  useEffect(() => {
    if (Platform.OS === 'android') {
      Mapbox.requestAndroidLocationPermissions();
    }
  }, []);

  return (
    <>
      <Mapbox.MapView
        {...MapViewProps}
        style={{height: '100%', width: '100%'}}
        onMapLoadingError={() => console.log('issue here')}
        // onDidFinishRenderingMapFully={() => console.log('heyo')}
        onWillStartLoadingMap={() => {
          console.log('hooo hooo');
        }}
        onDidFinishLoadingMap={() => {
          console.log('hi hi');
// was trying to insert the style prop here:
          MapViewProps = {
            ref: mapRef,
            backgroundColor: 'transparent',
            // styleJSON: NEW_MAPBOX_STYLE,
          };
        }}
        onDidFinishLoadingStyle={() => console.log('heeeeeee')}>
        <Mapbox.Camera {...MapCameraProps} />
        <Mapbox.UserLocation
          // Minimum amount of movement before GPS location is updated in meters
          minDisplacement={5}
          onUpdate={location => {
            updateUserLocation(location);
          }}
        />
      </Mapbox.MapView>
    </>
  );
};

Observed behavior and steps to reproduce
When I comment out the styleJSON around line 25 the default style loads. If I uncomment it, and fresh restart, the style loads completely black with no map. I know the style works because if I change the style file and save it, uncomment the line, the hot reloading will allow the map to load.
Expected behavior
Map loads with expected styleJSON
Notes / preliminary analysis
Seems like something about how the style is getting loaded isn't allowing the custom style to load on iOS. Android works fine.
The style I'm loading is v11 and I believe I have all the things set up based on this guide: here
Additional links and references
Are other people running into this issue?

open


LDTOOLS-206: Sequence Viewer: Unexpected selection of residues in the white area of shorter sequences for unequal sequence lengths

Primary: @pradeepnschrodinger
Summary:
MSA generated a residue:click event without taking into account the actual length of sequences. Consequently, we could see selections for shorter sequences even when we clicked in the white area (present horizontally). I have updated the MSA code to see the actual length of the sequence being clicked before generating a residue:click event. As required by the
Selecting Entity and monomers in the sequence viewer user story, now the selection will also be reset when the white area (present horizontally) is clicked.
Demo:
https://drive.google.com/file/d/1DkdEfwQVZuYycWdrfMEEa8qj-JqNGQE1/view?usp=sharing

There was this behavior in MSA where all the entities were highlighted on a column selection, irrespective of the sequence lengths.
https://github.com/user-attachments/assets/d4491493-ce80-4b21-8f4c-e9a4db227e56
I've also updated this behavior as part of this ticket such that only those entities are highlighted on a column selection, which have residues in that column.
https://github.com/user-attachments/assets/88642c4e-8f26-41e2-bff4-5b6f3fca347e


Query incorrectly excludes some valid non-alphanumeric characters like & from query string.

A Query currently does not support all valid characters as described in the reserved characters section of RFC3986 and the unreserved characters section of RFC3986
Currently supported characters:
'%',
'-',
'.',
'/',
'=',
'[',
']',
'_',

Should support all of the following characters:

"'",
"-",
".",
"_",
"~",
'!',
'#',
'$',
'&',
'(',
')',
'*',
'+',
',',
'/',
':',
';',
'=',
'?',
'@',
'[',
']',

Refactor to allow all valid non-alphanumeric characters.

resolved in 63cc7204254d3969eaef9e8576a8a8cefe01bf65


fix: political status isn't relevant to government

The government column of search.page depends on the
the political flag being set, but there is no reason for it, so this
commit removes the dependency.

It could be not-political and yet be tagged to a government, as far as I can tell from various sources.


[ZEPPELIN-4152]. Use spark 2.2 as the default profile

What is this PR for?
Trivial PR to use spark 2.2 as the default profile so that the default build command can pass
mvn clean package -DskipTests

What type of PR is it?
[ Improvement ]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4152

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Unfortunately, spark 2.3 doesn't support scala 2.10 which is default profile.

hm. I guess we need a plan to move to 2.11

I tried to do that, but some other interpreters don't support scala-2.11. So it would take much more time to support scala-2.11 fully in zeppelin. I plan to move some interpreter out of zeppelin project to subproject, so that each interpreter can has its own build environment and dependency. This PR is a temporary solution before that

sure, this could be a big problem...

LGTM


[Q] Weird error code when syncing offline runs

I'm trying to sync an offline run and getting the following error code:
wandb: ERROR Error while calling W&B API: invalid parameters: 64 limit exceeded for JobType (<Response [400]>)

What does it mean and how can I fix it so offline syncing works properly? Currently the run doesn't display on the WandB website, so I can't view results and it's a big issue.
Thanks!
Some more information—when I do cat /tmp/debug-cli.tristanengst.log, I get:
2023-09-27 18:38:31 INFO Running runs: []
2023-09-27 18:38:31 INFO Agent received command: run
2023-09-27 18:38:31 INFO Agent starting run with config:
        arch: conv
        bs: 64
        code_bs: 1000
        conv_embed_dim: 256
        data_tr: cifar10
        data_val: cifar10
        debug_one_wd: 1
        epochs: 32
        eval_iter: 4
        gpus: 0
        ipe: 20
        lrs: 0 5e-5
        noise_std: 0.2
        suffix: Sept27-ConvTuning-Old
        wandb: online
        wd: 1e-05
2023-09-27 18:38:31 INFO About to run command: /usr/bin/env python TrainSSL.py --arch=conv --bs=64 --code_bs=1000 --conv_embed_dim=256 --data_tr=cifar10 --data_val=cifar10 --debug_one_wd=1 --epochs=32 --eval_iter=4 --gpus=0 --ipe=20 "--lrs=0 5e-5" --noise_std=0.2 --suffix=Sept27-ConvTuning-Old --wandb=online --wd=1e-05
2023-10-02 18:22:43 INFO open for scan: /home/tristanengst/Development/IMLE-SSL/wandb/offline-run-20231002_181204-i3zlwjfk/run-i3zlwjfk.wandb
2023-10-02 18:22:43 ERROR 400 response executing GraphQL.
2023-10-02 18:22:43 ERROR {"errors":[{"message":"invalid parameters: 64 limit exceeded for JobType","path":["upsertBucket"]}],"data":{"upsertBucket":null}}
2023-10-02 18:22:43 ERROR invalid parameters: 64 limit exceeded for JobType (Error 400: Bad Request)
Traceback (most recent call last):
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/apis/normalize.py", line 41, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/internal_api.py", line 1999, in upsert_run
    response = self.gql(
               ^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/internal_api.py", line 330, in gql
    ret = self._retry_gql(
          ^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/lib/retry.py", line 131, in __call__
    result = self._call_fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/internal_api.py", line 358, in execute
    return self.client.execute(*args, **kwargs)  # type: ignore
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/vendor/gql-0.2.0/wandb_gql/client.py", line 52, in execute
    result = self._get_result(document, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/vendor/gql-0.2.0/wandb_gql/client.py", line 60, in _get_result
    return self.transport.execute(document, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/lib/gql_request.py", line 56, in execute
    request.raise_for_status()
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.wandb.ai/graphql

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/sender.py", line 974, in send_run
    self._init_run(run, config_value_dict)
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/sender.py", line 1012, in _init_run
    server_run, inserted, server_messages = self._api.upsert_run(
                                            ^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/apis/normalize.py", line 51, in wrapper
    raise CommError(message, error)
wandb.errors.CommError: invalid parameters: 64 limit exceeded for JobType (Error 400: Bad Request)
2023-10-02 18:22:43 INFO saving file wandb-metadata.json with policy now
2023-10-02 18:22:43 INFO saving file code/* with policy now
2023-10-02 18:22:43 INFO saving file media/images/images/val_0_20f5f75632f77e06d4a7.png with policy now
2023-10-02 18:22:43 INFO saving file media/images/images/tr_0_a137e38691aab7cb4a67.png with policy now
2023-10-02 18:22:43 INFO saving file media/images/images/tr_new_masks_0_c8d25f60c572fa6f2255.png with policy now
2023-10-02 18:22:43 INFO saving file media/images/images/val_150_4a3ed90deed76030f8b1.png with policy now
2023-10-02 18:22:43 INFO saving file media/images/images/tr_150_6209b97279066c8ba952.png with policy now
2023-10-02 18:22:43 INFO saving file media/images/images/tr_new_masks_150_db44275faff9405555a4.png with policy now
2023-10-02 18:22:43 INFO saving file wandb-summary.json with policy end
2023-10-02 18:22:43 INFO handling exit code: 255
2023-10-02 18:22:43 INFO handling runtime: 451
2023-10-02 18:22:43 INFO saving file wandb-summary.json with policy end
2023-10-02 18:22:43 INFO send defer
2023-10-02 18:22:43 INFO handle sender defer: 0
2023-10-02 18:22:43 INFO send defer: 1
2023-10-02 18:22:43 INFO handle sender defer: 1
2023-10-02 18:22:43 INFO send defer: 2
2023-10-02 18:22:43 INFO handle sender defer: 2
2023-10-02 18:22:43 INFO send defer: 3
2023-10-02 18:22:43 INFO handle sender defer: 3
2023-10-02 18:22:43 INFO send defer: 4
2023-10-02 18:22:43 INFO handle sender defer: 4
2023-10-02 18:22:43 INFO send defer: 5
2023-10-02 18:22:43 INFO handle sender defer: 5
2023-10-02 18:22:43 INFO send defer: 6
2023-10-02 18:22:43 INFO handle sender defer: 6
2023-10-02 18:22:43 INFO send defer: 7
2023-10-02 18:22:43 INFO handle sender defer: 7
2023-10-02 18:22:43 INFO send defer: 8
2023-10-02 18:22:43 INFO handle sender defer: 8
2023-10-02 18:22:43 INFO Attempting to build job artifact
2023-10-02 18:22:43 INFO is repo sourced job
2023-10-02 18:22:43 INFO adding wandb-job metadata file
2023-10-02 18:22:43 INFO send defer: 9
2023-10-02 18:22:43 INFO handle sender defer: 9
2023-10-02 18:22:43 INFO send defer: 10
2023-10-02 18:22:43 INFO handle sender defer: 10
2023-10-02 18:22:43 INFO send defer: 11
2023-10-02 18:22:43 INFO handle sender defer: 11
2023-10-02 18:22:43 INFO send defer: 12
2023-10-02 18:22:43 INFO handle sender defer: 12
2023-10-02 18:22:43 INFO send defer: 13
2023-10-02 18:22:43 INFO handle sender defer: 13
2023-10-02 18:22:43 INFO send defer: 14
2023-10-02 18:22:43 INFO handle sender defer: 14
2023-10-02 18:22:43 INFO shutting down sender
2023-10-03 05:37:36 INFO open for scan: /home/tristanengst/Development/IMLE-SSL/wandb/offline-run-20231003_053428-sva44zb8/run-sva44zb8.wandb
2023-10-03 05:37:36 ERROR 400 response executing GraphQL.
2023-10-03 05:37:36 ERROR {"errors":[{"message":"invalid parameters: 64 limit exceeded for JobType","path":["upsertBucket"]}],"data":{"upsertBucket":null}}
2023-10-03 05:37:36 ERROR invalid parameters: 64 limit exceeded for JobType (Error 400: Bad Request)
Traceback (most recent call last):
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/apis/normalize.py", line 41, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/internal_api.py", line 1999, in upsert_run
    response = self.gql(
               ^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/internal_api.py", line 330, in gql
    ret = self._retry_gql(
          ^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/lib/retry.py", line 131, in __call__
    result = self._call_fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/internal_api.py", line 358, in execute
    return self.client.execute(*args, **kwargs)  # type: ignore
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/vendor/gql-0.2.0/wandb_gql/client.py", line 52, in execute
    result = self._get_result(document, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/vendor/gql-0.2.0/wandb_gql/client.py", line 60, in _get_result
    return self.transport.execute(document, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/lib/gql_request.py", line 56, in execute
    request.raise_for_status()
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.wandb.ai/graphql

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/sender.py", line 974, in send_run
    self._init_run(run, config_value_dict)
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/sdk/internal/sender.py", line 1012, in _init_run
    server_run, inserted, server_messages = self._api.upsert_run(
                                            ^^^^^^^^^^^^^^^^^^^^^
  File "/home/tristanengst/miniconda3/envs/py311IMLESSL/lib/python3.11/site-packages/wandb/apis/normalize.py", line 51, in wrapper
    raise CommError(message, error)
wandb.errors.CommError: invalid parameters: 64 limit exceeded for JobType (Error 400: Bad Request)
2023-10-03 05:37:36 INFO saving file wandb-metadata.json with policy now
2023-10-03 05:37:36 INFO saving file code/* with policy now
2023-10-03 05:37:36 INFO saving file media/images/images/val_0_20f5f75632f77e06d4a7.png with policy now
2023-10-03 05:37:36 INFO saving file media/images/images/tr_0_a137e38691aab7cb4a67.png with policy now
2023-10-03 05:37:36 INFO saving file media/images/images/tr_new_masks_0_c8d25f60c572fa6f2255.png with policy now
2023-10-03 05:37:36 INFO saving file wandb-summary.json with policy end
2023-10-03 05:37:36 INFO handling exit code: 255
2023-10-03 05:37:36 INFO handling runtime: 176
2023-10-03 05:37:36 INFO saving file wandb-summary.json with policy end
2023-10-03 05:37:36 INFO send defer
2023-10-03 05:37:36 INFO handle sender defer: 0
2023-10-03 05:37:36 INFO send defer: 1
2023-10-03 05:37:36 INFO handle sender defer: 1
2023-10-03 05:37:36 INFO send defer: 2
2023-10-03 05:37:36 INFO handle sender defer: 2
2023-10-03 05:37:36 INFO send defer: 3
2023-10-03 05:37:36 INFO handle sender defer: 3
2023-10-03 05:37:36 INFO send defer: 4
2023-10-03 05:37:36 INFO handle sender defer: 4
2023-10-03 05:37:36 INFO send defer: 5
2023-10-03 05:37:36 INFO handle sender defer: 5
2023-10-03 05:37:36 INFO send defer: 6
2023-10-03 05:37:36 INFO handle sender defer: 6
2023-10-03 05:37:36 INFO send defer: 7
2023-10-03 05:37:36 INFO handle sender defer: 7
2023-10-03 05:37:36 INFO send defer: 8
2023-10-03 05:37:36 INFO handle sender defer: 8
2023-10-03 05:37:36 INFO Attempting to build job artifact
2023-10-03 05:37:36 INFO is repo sourced job
2023-10-03 05:37:36 INFO adding wandb-job metadata file
2023-10-03 05:37:36 INFO send defer: 9
2023-10-03 05:37:36 INFO handle sender defer: 9
2023-10-03 05:37:36 INFO send defer: 10
2023-10-03 05:37:36 INFO handle sender defer: 10
2023-10-03 05:37:36 INFO send defer: 11
2023-10-03 05:37:36 INFO handle sender defer: 11
2023-10-03 05:37:36 INFO send defer: 12
2023-10-03 05:37:36 INFO handle sender defer: 12
2023-10-03 05:37:36 INFO send defer: 13
2023-10-03 05:37:36 INFO handle sender defer: 13
2023-10-03 05:37:36 INFO send defer: 14
2023-10-03 05:37:36 INFO handle sender defer: 14
2023-10-03 05:37:36 INFO shutting down sender

Hey @tristanengst - thank you for surfacing this. We have a hard 64 character restriction on run job_type strings which is why you are running into this error; however, this doesn't seem to be enforced in offline mode - I will definitely make a bug report about this and update you with progress that arises.
As for syncing your current runs - I'm looking to see if there's a way we can do that and will update you if I find a workaround. Otherwise, I recommend re-running your script with a job_type string less than 64 characters - so sorry for this inconvenience!

What does job_string actually refer to? Is it the name of the run (the name keyword argument to wandb.init())—it's the only thing that could've been especially long, although I'd had no trouble with roughly similar lengths in both online and offline mode before.

@tristanengst - Would it be possible to provide an example code snippet of your wandb.init() call and the arguments inside it? Or if you have a value set for the environment variable WANDB_JOB_TYPE ?

Apologies, there was a bug in my init function—job_type should have been None, but was accidentally set to the long string I mentioned earlier as the name keyword argument. I confirmed that with online mode, calling wandb.init() with the issue fails immediately, so it is good enforce this in offline mode too to avoid confusion. There's no need to figure out how to sync to the affected runs as the problem can be easily circumvented going forward by not having the bug.

@tristanengst I'll update this thread once progress is made on the fix. Glad to hear you were able to find the bug in your init function!

hey @tristanengst - just merged a fix for being able to override the job type you may have set in your script, since we don't enforce the 64 character limit in offline runs. this will be available in our next SDK release, and thanks again for flagging!


Direct pose

What do you think about anchor-free inspired approaches like https://arxiv.org/abs/1911.07451?
Are these model plausible for Coral devices?
Do you plan to have an example here?
If you can talk internally with other TF teams see also HUB:
https://github.com/tensorflow/hub/issues/424
And related:
https://github.com/tensorflow/models/issues/4676

Hi,
This seems certainly an interesting approach though i'm not deeply familiar with it. The convolutional parts of this would likely run on EdgeTPU no problem.
The post processing will have to get done on CPU i suspect.
We don't currently plan to provide such models as pretrained/canned examples.


Explicitly invoke /lagoon/entrypoints.sh for pre/post rollout tasks

Fixes #574
According to some googling I did, running oc exec and oc rsh doesn't automatically invoke the container entrypoints.
This PR forces running /lagoon/entrypoints.sh for pre/post rollout tasks.

oc-build-deploy-dind image is no longer maintained, and will be shortly removed.


Add komoot logo to sponsors page

Welcome komoot, great to have you as a sponsor!

Broken for me locally too. Also on main.

Removed community page temporarily. Open an issue for this


Feature/implement create new premises post endpoint

This PR is to do a comprehensive first pass of implementing a new POST endpoint for adding a new premises.
The request body is specific to CAS3, however the response body is using the existing Premises schema which has had to be augmented to add some new fields:

address
notes
service

Address is only a single string, notes are optional and service in this case is 'CAS3'. This is so that when a call is made to get only CAS3 properties, they can be queried on this value.
In PremisesService you will see:
`// TODO: dummy data for now - remove asap
val apAreaEntity = ApAreaEntity(
id = UUID.randomUUID(),
name = "arbitrary_ap_area",
identifier = "arbitrary_identifier",
probationRegions = mutableListOf()
)
val probationRegion = ProbationRegionEntity(
  id = UUID.fromString("afee0696-8df3-4d9f-9d0c-268f17772e2c"), // Wales in db
  name = "arbitrary_probation_region",
  apArea = apAreaEntity,
  premises = mutableListOf()
)
// end of dummy data`

This is dummy data (for now) for just ap area and probabtion region as they are not being passed through but are required as part of creating a new premises using the shared schema.
Also just below that you will see:
// TODO: on the next iteration the identifier and name will be retrieved by the id     val localAuthorityArea = LocalAuthorityAreaEntity(       id = UUID.fromString(requestBody.localAuthority),       identifier = "arbitrary_identifier",       name = "arbitrary_local_authority_area",       premises = mutableListOf()     )
This is the initial first pass for this structure as the UUID is being passed down from the client and a subsequent story will pass both identifier and name.
An outside in approach has been used to test the creation of a new premises and also the validation scenarios.

Around the ktLint stuff:

The gradle task addKtlintCheckGitPreCommitHook will add a check to stop you comitting code that's going to upset it
The gradle task ktLintFormat will sort out most issues for you
There's an IntelliJ plugin Ktlint (unofficial) by Nick Bedal that adds error highlighting and a context item to format - seems to be a bit flaky (doesn't always trigger) but I've found it to be fairly useful nonetheless

On the commits, generally if you're correcting something from a previous commit (e.g. formatting or changing a comment etc.) the way seems to be to rebase the original commit: https://playbook.dxw.com/tech/how-we-do-development/#7-tidy-up-your-commits
e.g. the CAS3-443: reformat code to address linting commits should probably be part of the commits that changed those lines to begin with rather than additional ones.

As discussed, I was testing this out with the frontend and the /premises endpoint now seems to 500 with a problem seemingly related to address?
java.lang.NullPointerException: Parameter specified as non-null is null: method uk.gov.justice.digital.hmpps.approvedpremisesapi.api.model.Premises.<init>, parameter address
	at uk.gov.justice.digital.hmpps.approvedpremisesapi.api.model.Premises.<init>(Premises.kt)

With the agreement from Sharon last week about working on the same API I think we can now look to merge this into main rather than our release branch.
That said, given the work has been reviewed already it probably makes sense to merge this in as originally intended and then look to propose a merge from temporary-accommodation-main into main. We can then shut down temporary-accommodation-main.

@edavey @tahb @brownbearsoftware I have forced pushed up a revision.
Here's some of my observations:
This is has been my first PR getting used to the ways of working so a lot has been learnt from it so can be applied to future work and PR's.
I have tidied up the history - it is still long but that's the nature of being a longlived branch as you mentioned @edavey. I can avoid this in future.
There are perhaps a couple of things on here for future discussion rather than trying to resolve now such as the enum for a service type. As we just get a string from the client atm that's enough for a first pass with a further story for making it better.
The hardcoded strings are okay for now? As a first pass to get this infrastructure in and a story to be raised to address these as this PR really needs to be in

Not one for this PR specifically but one other thing that's just sprung to mind; I'm guessing this will need an acompanying change to the GET /premises endpoint to return only CAS1 or CAS3 Premises so the frontends can supply the relevant value.  Or alternatively, just a change on each frontend to filter out the other type when displaying lists of Premises.

I've raised it with Kath to have a story follow closely behind to address these hard-coded values

Leaving ApCode, Delius Team Code and Ap Area as placeholder/dummy data for the time being makes me nervous as I would argue the first & foremost priority should be making sure we have a coherent model that makes sense for both use cases.  Appreciate there are other factors at play around timing though so will leave to @edavey / @pezholio from our end.

@edavey In regards to Joe's comment there, I'm wondering if we might in future want to split any AP specific fields like ApArea and DeliusTeam code out in a similar way we plan to do for Characteristics?

@tahb That's a good idea - I don't think we search by any of those fields (at least, not yet), so that might be a good option. Thoughts? @edavey @brownbearsoftware?

@edavey In regards to Joe's comment there, I'm wondering if we might in future want to split any AP specific fields like ApArea and DeliusTeam code out in a similar way we plan to do for Characteristics?

I'm not seeing why we would need to split these attributes out of the premises table. As far as  I understand they are required attributes of a CAS3 premises in the same way that they are required attributes of a CAS1 premises.
Is the problem here actually that we don't have values yet for the CAS3 seed data?
Is there a reason why you can't make up realistic values for these fields? I think that's what we've done in CAS1...

Is there a reason why you can't make up realistic values for these fields? I think that's what we've done in CAS1...

Yeah, we have just very basic seed data in at the mo

I'm not sure that ApArea, ApCode or Delius Team Code have come up for CAS3 yet. Right now, based on our bedspace trackers, this is what we imagine we'll be collecting about premises:

I'm not familiar with what those fields mean for CAS1 but I suspect this will be something that may come up later for us but @edavey  you mentioned you had some understanding that it's relevant?

I'm not sure that ApArea, ApCode or Delius Team Code have come up for CAS3 yet. Right now, based on our bedspace
...
I'm not familiar with what those fields mean for CAS1 but I suspect this will be something that may come up later for us but @edavey you mentioned you had some understanding that it's relevant?

hmm, it might be quicker to have a chat about this in person to understand the differences properly and agree a way forward?
And in the meantime, you could just seed your data with valid values?

We had a quick chat about this and concluded:
apCode - this field is a new internal reference for a premises, though CAS3 don't have a direct need we can create our own reference by creating a random sha. This should be quick to do now @ian-wells-nimble so I think we should do so. In the future this column should be renamed to something more generic.
deliusTeamCode - we are not sure if CAS3 will ever have probation officers on site, we suspect not but should confirm this. If we're right, this field is AP specific and we should think of a way to redesign this model to allow it to be optional for CAS3. This work should be done as soon as a follow-up and I think reasonably should come before the next bits of work. For now we can keep "UNKNOWN" or similar to allow this pull request to be merged.
apAreaEntity - this may or may not be needed by CAS3 in future. CAS3 don't have a good handle on it yet though it may be related to asking users which PDU a premises resides within(?). CAS1 are currently only using this field with the intention of reporting. We should probably figure out a way we can add dummy data here the short term.
@edavey Could we allow the apAreaEntity relationship to be optional? It feels misleading to assign our premises to a real but random ap area. The data would look real but would be inaccurate for a premises. Adding a fake ApArea might work but may interfere if CAS1 users are able to see it in a list they can pick from.

Further to our chat, I've had more of a think about how to handle these divergencies and have some proposals which would mean a bit of work on the CAS1 side but would avoid us having to take on technical debt and feel soiled at such an early stage in the process of developing a shared API.
premises.ap_code
These are unique, human-readable codes which have been assigned to each premises during the manual auditing exercise which Dan Stretton is leading. They are strings like:

NEALB for "North East: Albion", and
MIWOR for "Midlands: Wordsworth"

This system has been extended to identify individual beds within APs e.g

MIWOR03
NEALB18

The value of these codes is purely in their human-readability and we expect to use them only in views and in reporting. They are not used as keys in database joins. Premises and beds use autogenerated UUIDs as their primary keys.
I suggest that apCode:

should be renamed to premisesCode
should be implemented by CAS3 premises for now. In the future we (CAS1) could extract this to some other table like friendly_ids

premises.delius_team_code_id
It seems clear that not all (any?) CAS3 premises will be staffed by Delius teams.
I suggest we (CAS1) extract these Delius staff codes to a join table called something like premises_staffing. Once CAS3 know more about their staffing needs they can implement a compatible staffing entity.
probation_regions.ap_area_id
APs are associated with probation_regions (premises.probation_region_id), approx 13 in total.
Each probation region belongs to one of about 8 "AP areas" (probation_regions.ap_area_id).
Each probation region has many Probation Delivery Units (aka LDUs) which are currently missing from our schema.
Each premises is also associated with a Local Authority Area (premises.local_authority_area_id)
As it seems clear that not all of these categorisations will make sense for CAS3, perhaps we (CAS1) should extract all this "organisational" information into something like OrganisationalUnit entities, so that each type of premises can have the types of organisational_unit_memberships which are meaningful for that service e.g. from available:
organisational_units

ap areas
probation regions
probation delivery units
local authority areas

CAS1 can redefine these properties through a join table:
organisational_unit_memberships
joining organisational_units to premises
Once CAS3 know more about their needs they can use these organisational units or add their own.
I think we ought to stick to doing the job right and not try to fudge our differences as I suspect that as we proceed we're going to discover small but significant differences round most corners and that we need to let those differences drive maintainable design.
So my view is that we should i) merge this PR and ii) and proceed right away with some refactoring to remove the hacks and fudges.