Proposal: Clarification on criteria for stable component status and deprecation of "stable candidate" term.

/area docs
Clarification on criteria for stable component designation
As a maintainer of components-contrib I propose the following requirements for a component to be designated as stable:

The component was included in the previous release (both alpha and beta state are acceptable). This means a brand new component cannot be introduced and immediately be considered stable. It must be at least Alpha or Beta for one release. This of course shall not prevent an eager contributor from contributing a certification test early.
In addition to conformance tests the component must have a stable certification test including a Readme (the test plan) outlining what is being tested. The certification test must cover the following requirements:

Every component metadata attribute and their potential values (if this is a list or enum) must be covered by an integration test communicating with the actual cloud service or containerized service for which this component is intended to be used.
Every supported authentication or connection mechanism must be covered by an integration test.
If the component uses a protocol that maintains a connection (e.g. websocket, or binary protocol etc) a test must be created that demonstrates the component is able to reconnect if this connection is interrupted. Components communicating via REST or gRPC do not require this.
Emulators of cloud services are not acceptable for meeting the certification test requirements above. Certification tests for cloud services must communicate with the actual cloud service. This may require coordination with the Dapr Steering Community to securely configure credentials that can be used to exercise cloud-based test infrastructure.

Note: Certification tests should avoid basic operations already covered by conformance tests.
With this new definition above the term stable candidate will be dropped. A component may move from alpha or beta to stable directly if the above requirements have been met.

cc @dapr/maintainers-components-contrib @dapr/maintainers-dapr

This would make certification test stage approval more stricter so that we can directly move beta to stable instead of waiting one release to move to stable, is that correct?

This would make certification test stage approval more stricter so that we can directly move beta to stable instead of waiting one release to move to stable, is that correct?

No, this formalizes what was already the requirement upheld by contrib maintainers. Further, it removes the unnecessary stable candidate designation which h introduced a waiting period that served no purpose as we haven't seen any increase in adoption of beta components that were stable candidates. This introduced unnecessary complexity and so we are getting rid of this.
In theory with this change a component could be stable faster than before as long as the formalized requirements have been met.

Looks good.

Overall looks good to me. Two things:

Given the stricter definitions of the cert tests, are we going to go through and mark which ones need to be updated? Certain components like Kafka and Azure Service Bus* have a lot of metadata so I wouldn't be surprised if they were missed.
Should we include anything about resiliency here? We have a proposal 1863 but it hasn't been ratified yet. Do you think it's too early to include what that path would look like?

Overall looks good to me. Two things:

Given the stricter definitions of the cert tests, are we going to go through and mark which ones need to be updated? Certain components like Kafka and Azure Service Bus* have a lot of metadata so I wouldn't be surprised if they were missed.
Should we include anything about resiliency here? We have a proposal 1863 but it hasn't been ratified yet. Do you think it's too early to include what that path would look like?

1.) Existing components should be grandfathered in. We should make sure to revisit their certification tests when we have an opportunity to do so.
@dapr/approvers-components-contrib @dapr/maintainers-components-contrib should ensure that new metadata options being introduced for stable components also add an appropriate test case in certification tests going forward.
2.) Given that the Component Resiliency Proposal isn't finalized / approved yet we cannot consider it yet as part of this standard.
I do expect that in the future implementing the Resiliency interface will be a requirement for stable certification as well. At that time we will need to amend the published guidelines for stable component certification.

Existing components should be grandfathered in. We should make sure to revisit their certification tests when we have an opportunity to do so.

https://github.com/orgs/dapr/teams/approvers-components-contrib https://github.com/orgs/dapr/teams/maintainers-components-contrib should ensure that new metadata options being introduced for stable components also add an appropriate test case in certification tests going forward.

Agree

Given that the Component Resiliency Proposal isn't finalized / approved yet we cannot consider it yet as part of this standard.

Agree

I do expect that in the future implementing the Resiliency interface will be a requirement for stable certification as well.

I'm not too sure about that, but in any case we probably need a few releases with Resiliency in stable status before we can make that decision.

Overall I think this makes a lot of sense.
Only one comment on this:

If the component uses a protocol that maintains a connection (e.g. websocket, or binary protocol etc) a test must be created that demonstrates the component is able to reconnect if this connection is interrupted. Components communicating via REST or gRPC do not require this.

On the last sentence:

I think we should clarify that components that use HTTP or GRPC but maintain streams or perform long-polling (which is the case for some pub subs), then they are still required to comply with this requirement.
Even when the component does not maintain any persistent connection, I think it is still important to test a situation where the network is down to validate how the component handles that?

Are we OK to merge https://github.com/dapr/docs/pull/2720 ?

I think we should clarify that components that use HTTP or GRPC but maintain streams or perform long-polling (which is the case for some pub subs), then they are still required to comply with this requirement.

Agreed. Updated.

Even when the component does not maintain any persistent connection, I think it is still important to test a situation where the network is down to validate how the component handles that?

I don't think that belongs in certification tests. If the network is down the component will fail operations multiple times (depending on resiliency settings). It would be expected that the runtime eventually consider the component to be in bad state and attempts to restart the component (or restarts the entire sidecar -- whichever the current behavior is).

Are we OK to merge dapr/docs#2720 ?

Please update the PR to also add the detailed requirements on the certification tests which we can link to. Otherwise the page is still very ambiguous as it isn't clear what a certification test entails.


Update manual and function signatures for ordered logistic/probit

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
Update the manual, function signatures, and tests for the vectorised ordered logistic and probit distributions introduced in math prs: stan-dev/math/pull/638 stan-dev/math/pull/645
Intended Effect
Allow usage of ordered logistic and probit distributions in stan
How to Verify
Visually inspect
Side Effects
N/A
Documentation
Included in PR
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

It looks like this is failing because it's missing files.  Did you check everything in or are the paths wrong?


No profiles in "Profile class" menu

Following the first tutorial at https://essim-documentation.readthedocs.io/en/latest/tutorials/index.html#tutorial-1-basic-energy-system I can find no profiles in the "Profile class". The bold entries are not selectable.

Do these have to be imported in a previous step or during the setup of the ESDL Map Editor?
Host system: Ubuntu 20.04
Deployment: Docker, from https://github.com/ESDLMapEditorESSIM/docker-toolsuite

Did you do Step 8. Upload some profiles from  https://github.com/ESDLMapEditorESSIM/docker-toolsuite ? There are some example profiles in the Data\Profiles\standard_profiles.csv folder, you can upload in the ESDL MapEditor

Thank you for your very quick reply @ewoudwerkman . I indeed missed that step, my apologies.
Are the standard_profiles.csv energy values or power/temperature values? Should they be summed or averaged?

If I recall correctly these profiles are NEDU profiles from the Netherlands, which all sum up to 1, so you can use the multiplier field to scale it to e.g. a yearly value.

Thank you for your help @ewoudwerkman , I think we can close this one.


Scheduled CI failed

Information

Qiskit Optimization version: latest
Python version: Github Actions
Operating system: Github Actions

What is the current behavior?
Scheduled CI failed.
https://github.com/Qiskit/qiskit-optimization/actions/runs/1131728954
Unit tests of GroverOptimizer takes so long time.
https://github.com/Qiskit/qiskit-terra/pull/6831 seems the cause. It changes QuantumCircuit.power.
{0} test.algorithms.test_grover_optimizer.TestGroverOptimizer.test_samples_and_raw_samples_1_sv [] ... inprogress
{1} test.algorithms.test_grover_optimizer.TestGroverOptimizer.test_samples_and_raw_samples_2_qasm [] ... inprogress
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/future/standard_library/__init__.py:65: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/threading.py:874: ResourceWarning: unclosed file <_io.FileIO name=5 mode='rb' closefd=True>
  del self._target, self._args, self._kwargs
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/stestr/commands/load.py:287: ResourceWarning: unclosed file <_io.FileIO name=6 mode='rb' closefd=True>
  case.run(result)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/subprocess.py:946: ResourceWarning: subprocess 3345 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/subprocess.py:946: ResourceWarning: subprocess 3343 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback

Steps to reproduce the problem
What is the expected behavior?
No error.
Suggested solutions

I created https://github.com/Qiskit/qiskit-terra/pull/6910 to resolve this issue.


withLifecycle method doesn't have access to domNode

domNode is acccessiable when using onComponentDidMount passed from parent. But it isn't accessible when using compose > withLifecycle method.

Hi @cloudship
Thanks for your info. do you have some example code with a working solution? i‘ll then try to fix it 👍

Hi @zanettin , nope, I didn't have a solution with incompose, so that I just passed down the lifecyle funtions from the parent node to get it work.

ah no, i meant a working example using the „native“ way with inferno. so i can see, what you want to achieve with incompose :-)

`import { withLifecycle, compose } from 'incompose'
const MyComponent = ()=>(

    hello world!

)
const mountNotice = (el:HTMLElement)=>{
console.log(el);
}
export default compose(
withLifecycle({
componentDidMount: mountNotice
})
)(MyComponent)`
`const IdeaListPage = () => (

)`
the code above generates output: "undefined"
but if I write pass the lifecycle function from the parent node, it work.
`const IdeaListPage = () => (

)`
this prints out: hello world!

ah now i got it. thanks for the code.
the problem is, that we're talking about 2 separate functionalities here. the working example is a custom callback for inferno functional components. in this case, you'll receive the element as first param on your callback function. on the other hand, class components and the incompose lifecylces are not receiving any params on the componentDidMount method on the class. that's why i can't forward anything to you unfortunately.
docs from inferno about this topic
https://infernojs.org/docs/guides/components

functional lifecycles
class component lifecycle methods

suggestion
i can share this code snippet with you which should do what you want:
import { createElement } from "inferno-create-element";
import compose from "incompose/dist/compose";

// tiny HoC to use the functional lifecycles from within the component
const withLifecycle = config => component => props => createElement(component, { ...props, ...config });

const App = () =>
my super awesome component
;

export default compose(
  withLifecycle({
    onComponentDidMount: (el) => console.log("mounted", el)
  })
)(App);


Updated for metadata for support with 3.18

I have tested this extension with 3.18 in Arch Linux and the extension works as expected. I think it is safe to merge and update on the main EGO (extensions.gnome.org) page.

@MichaelTunnell Awesome, thanks! :)


Actor.get_market_schedule() defaulting to strategy 0

https://github.com/BESTenergytrade/simply/blob/ada5f7b0bd12a95ebc93d22fbb1b34d2cf97d695/simply/actor.py#L271C1-L271C37
If I am not mistaken, according to the warning text above, this line should be strategy = 0, right?

Correct this would be better. I will change it

solved in dev


Feature Request: API for use in setup.py

In an effort to reduce duplication it would be nice if setup.py could get the install_requires items from an API.
For a library where you want to be a little loose with the requirements (i.e. non-pinned)
# setup.py
from pipenv.api import install_requirements

setup(
    install_requires=install_requirements()
)

For an application distributed via setup.py, a little tighter
# setup.py
from pipenv.api import install_requirements

setup(
    install_requires=install_requirements(pinned=True)
)

This remindes me of npm and node a bit.  I think it's a feature we can consider but not one that will want implement soon.

closing with a tag for now so we can keep track of future enhancements.  Just trying to clear some of the issues out and sort them.

Related: #209 #689

shoot, that would be SO nice :(


sarkar/remove inner private api calls in tests

What does this PR do?
There are a bunch of tests of this nature:
out1=model.generate(mode="sample")
out2=model._sample()
assert out1==out2

Reasons for removing these tests

generate is the only public api, the rest are meant to be private and are not meant to be called
The test themselves are not testing much, because it exercises the same paths, and the outer generate ends up calling the inner ones themselves
the transformer repo itself does not have these tests
the inner/private apis can change at any time (like it changed in this upgrade), causing multiple tests to break

This PR also hooks up the stub contrastive search in OH, so it will fail now. so contrastive search tests are marked xfail
Current status of the branch on 1 test file that I tested t5:
FAILED tests/transformers/tests/models/t5/test_modeling_t5.py::T5ModelIntegrationTests::test_summarization - AssertionError: Lists differ: ['pro[360 chars]n in the occupied Palestinian territory . as m[703 chars]2 .'] != ['pro[360 chars]n in Palestinian territories...
FAILED tests/transformers/tests/models/t5/test_modeling_t5.py::T5ModelIntegrationTests::test_torch_quant - AttributeError: 'Linear' object has no attribute 'custom_name'

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

another reason to reflect these changes:

the eventual test_utils.py would much closer in test content to HF upstream for future transformers updates.

merged to https://github.com/huggingface/optimum-habana/pull/1163 via https://github.com/huggingface/optimum-habana/pull/1204/files#diff-7726d5e68b02d4909ece94ee45f0cc0beeb9b94c53cbd4c5cbf75476e6f36a89


Feature request: Disable scroll

Hello! it would be nice if we can toggle true or false the scroll feature, in that way we can control change between popups and only lock the flow of the dashboard to the buttons!

Hi, I'm not sure of what you're asking for? You mean the fact that you can scroll into a pop-up when there is too much content? Can you be more specific?

Hi sure! When a pop-up is added to the dashboard, I can access it by scrolling down the main dashboard screen without clicking the pop-up open button. Additionally, with one pop-up open on the dashboard, I can easily scroll between pop-ups without closing the previous ones. It would be helpful to disable the scroll feature to prevent unintended navigation between pop-ups.

Well... In fact what you are experiencing seems like a bug, because pop-ups are hidden when they are not triggered. Can you give me more informations about your configuration?

Yeah! at the beginning I also think of it as a bug, I will upload a video so that you can see the behavior i'm getting

Have you tried with a different theme? Because it should work with most themes.

Yes, I tried some, the one that I normally use is the "minimalist-mobile" from the UI Lovelace Minimalist and most of those "minimalist" themes don't work properly with this feature, but I know that is related to the themes, because trying different things I get the pop-ups to work correctly, but affecting the visuals of the dashboard.

Hi! Yesterday I did some updates on my HAs and updated a bunch of things, and the "bug" got fixed! I guess I was running older components and somehow it wasn't working properly!
Thank you for the support!


Add feature to pass extra args when building image

If a user wants to pass few extra args to build
command when building image, then he can pass
using 'extra-args' input parameter.
This PR adds another input extra-args to pass extra arguments.
Fixes: #22
Signed-off-by: divyansh42<EMAIL_ADDRESS>

closing because we are not implementing this as per https://github.com/redhat-actions/buildah-build/issues/22#issuecomment-771043447


Tabla sound font

Tabla is a popular Indian percussion instrument.
Here are MIDI.js compatible format of Tabla.sf2
Not all notes contains sound, use sound font software like Viena to find details of sound and MIDI key

Awesome! Would you please update the README with the new soundfont info? You can use Fluid-Soundfont as a template.

My first accepted pull request on Github. :-)
Thank you @gleitz

Nice work!


iOS build crashes settingup firebase_messaging Undefined symbols for architecture arm64:   "OBJC_CLASS$_FLTFirebaseCorePlugin", referenced from:

Hi i am trying to setup firebase for my ios project and i did add googleservices-info.plist to my runner project. i am unable to get pass this i have even tried setting it up in a empty project just with  firebase_messaging: ^6.0.16 in yaml file
Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_FLTFirebaseCorePlugin", referenced from:
      objc-class-ref in GeneratedPluginRegistrant.o
  "_OBJC_CLASS_$_FLTFirebaseMessagingPlugin", referenced from:
      objc-class-ref in GeneratedPluginRegistrant.o
  "_OBJC_CLASS_$_FLTFirebaseAnalyticsPlugin", referenced from:
      objc-class-ref in GeneratedPluginRegistrant.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)``

Hi @sandrush73
From what I can see, the issue is related to a FlutterFire plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments,
providing your flutter doctor -v, your flutter run -v,  your pubspec.yaml
a minimal reproducible code sample that does not use 3rd party plugins,
and I will reopen it.
Thank you


Not in a runtime context is not always true

I'm importing a library that uses tokio_uring's upstream git version and if I try to spawn it with tokio_uring::start and the 0.4.0 version it get an error saying:  'Not in a runtime context' which is not correct. I believe the expect calls are masking the actual issue.

Can you upload some code to help us reproduce?

Sure I can try to put together a little example. I think basically the issue is that if you have a rust workspace with a library and a binary and they're both using different versions of tokio_uring it'll cause this not a runtime context error to be thrown upon startup.

Ah, I see, cargo is linking these as separate crates, so the 0.4.0 version doesn't see the runtime from the git version.

Yeah it might just be a documentation issue to warn people. I realize what I'm doing is pretty far off the beaten path

Not really, I just need to finish the in-progress work and get a release out.


Create .zip file with C# nuget packages

Once C# nugets are built, also create a zip (this will eventually simplify the testing chain).

LGTM


Release: v0.7.8

As per title cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Install error

error info:
You are using pip version 10.0.1, however version 18.0 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Yeah, that's not termtosvg related. It's just pip telling you that there is a new version of pip available. termtosvg should be compatible with both versions so upgrading or not is your choice.


Sema: Source compatibility fix for extensions of type aliases

Referring to a generic type without arguments inside the definition
of the type itself or an extension thereof is a shorthand for
forwarding the arguments from context:
struct Generic<T> {}

extension Generic {
  func makeOne() -> Generic  // same as -> Generic<T>
}

However this didn't work if the type was replaced by a typealias:
struct OldGeneric<T> {}
typealias Generic<T> = OldGeneric<T>

extension Generic {
  func makeOne() -> OldGeneric  // OK
  func makeOne() -> Generic  // error
}

Add a hack for making this work so that we better cope with the
renaming of DictionaryLiteral to KeyValuePairs in Swift 5.0.
Fixes rdar://problem/43955962.

@swift-ci Please smoke test

@swift-ci Please test source compatibility


Optimization configfile path constant definition

Signed-off-by: jiawei<EMAIL_ADDRESS>
What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@JiaweiGithub need paas CI / Verify

/lgtm
/approve


endpoint: add regeneratePolicy benchmark based off of variable number of rules

This test adds a basic benchmark test for regeneratePolicy within pkg/endpoint. It adds a hardcoded number of rules (currently 1000000 copies of one rule over and over again) into the policy repository, and then runs the benchmark. Thus, it tests how policy regeneration scales in relation to the number of rules added to the policy repository.
You can run it by doing the following from the cilium repository root:
$ make start-kvstores
$ go test -ldflags "-X github.com/cilium/cilium/pkg/kvstore.consulDummyConfigFile=/tmp/cilium-consul-certs/cilium-consul.yaml" github.com/cilium/cilium/pkg/endpoint -test.v -check.b -timeout 360s -coverprofile=coverage.out -covermode=count -coverpkg ./...

Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.1%) to 43.457% when pulling a1f4dfb16ea7a8fde623ab670ae43b2271ee9541 on pr/ianvernon/add-regenerate-policy-benchmark into e43ff15e9ebfdd83748059028bd20ed95f4e12f6 on master.

Build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8410
Appears to be #6059 most likely.

test-me-please

NodePort test failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8425/
#5384 appears to be the culprit.

test-me-please

Build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8432/
Hit #6347 .

test-me-please

@aanm in order to make the changes that resulted in ResolvePolicy being created, I had to benchmark regeneratePolicy first. This is the output of that benchmarking work.
I can definitely rework the benchmark to be for ResolvePolicy.

test-me-please

test-me-please

@aanm yes, and in general, to figure out what the bottlenecks are in policy generation for future optimizations.

test-me-please


how to evaluate Plus[1, 1]?

Thank you for the package, I'm learning about WSTP but I can't seem to get it to evaluate the expression (despite trying put_eval_packet and manually with put_function.
The below code, when run returns
warning: `wstp_tests` (bin "wstp_tests") generated 1 warning (run `cargo fix --bin "wstp_tests"` to apply 1 suggestion)
    Finished dev [unoptimized + debuginfo] target(s) in 0.28s
     Running `target/debug/wstp_tests`
Ok(70)
The result is: System`EvaluatePacket[System`Plus[1, 1]]

I'm definitely missing something about WSTP, how do I actually retrieve the evaluated code?
Thanks!
use std::error::Error;
use wolfram_expr::{Expr, Symbol};
use wstp::Link;

fn main() -> Result<(), Box<dyn Error>> {
    // Create an expression
    let expr = Expr::normal(
        Symbol::new("System`Plus"),
        vec![Expr::from(1), Expr::from(1)],
    );

    // Initialize the link
    let mut link = Link::new_loopback()?;

    // Send an evaluate packet with the expression Plus[1, 1]
    link.put_function("System`EvaluatePacket", 1)?;
    link.put_function("System`Plus", 2)?;
    link.put_i64(1)?;
    link.put_i64(1)?;
    link.end_packet()?;
    link.flush()?;

    println!("{:?}", link.get_raw_type());

    // Retrieve and print the result
    let result_expr = link.get_expr()?;
    println!("The result is: {:?}", result_expr);

    Ok(())
}

Hi @anandijain, the reason this isn't evaluating is that the the link you're creating is not connected to a Wolfram Kernel. WSTP is a generic protocol for transferring Wolfram Language expressions between arbitrary programs, so by default no Wolfram Kernel is involved.
In your example, your program is creating a special type of link called a 'Loopback' link, where any expression written to the link can be read back from the same link unmodified.
If you want to create a link to a Wolfram Kernel, you will need to create a WSTP link that "launches" the Kernel it will connect to. The wstp::kernel documentation shows an example of this:
use std::path::PathBuf;
use wstp::kernel::WolframKernelProcess;

let exe = PathBuf::from(
    "/Applications/Mathematica.app/Contents/MacOS/WolframKernel"
);

let kernel = WolframKernelProcess::launch(&exe).unwrap();

(The wstp::kernel documentation I linked to also shows an example of using wolfram-app-discovery so you don't have to hard-code the path to your WolframKernel executable.)
If you're trying to build a program that interacts with a running Kernel, you might be interested in this unofficial wolfram-client library I've been developing for use in wolfram-cli.


release 6.17.1

Due to various reports that automatic releasing failed, I keep track via this issue.
What I did so far:
followed the instructions by tagging and adding a new releases.
fingers crossed!

@jangalinski I see this in staging, so on behalf of @camunda-community-hub/devrel, I will close and release it. It may take a bit longer to see in Maven Central.

If this doesn't work, it may be because the project was renamed but not changed here.

Thanks a lot for checking. I was not aware of the repo list, I changed the mockito name there to reflect the latest repo.
I guess the release will work though, 6.17.0 was already released under the new naming conventions.

We are having some issues with projects not appearing in staging and at least one was fixed by updating the name in the Infrastructure repo. 🤷♀
I keep my fingers crossed 🤞 everything works for you here 😄


Playlist sorting

Allow sorting playlist songs manually or automatically by score, alphabetically or randomly

Also allow sorting by date added


Add (optional) factory contract for creating ERC20/ERC721 pools

This may or may not be a pattern we want to encourage - so looking for input here.
If you deployed the TokenFactory, this would allow the connector to behave similarly to the erc1155 connector - ie FireFly could create lots of token pools (fungible or non-fungible) without requiring you to manually deploy new contract instances.
Behavior is essentially: if you configure a factory contract address, and if a token pool creation request contains no address parameter, the factory will automatically deploy an instance of the requested type.
Note that the changes here just enable a factory pattern and lay out a sample factory contract. If we wanted to take it a step further, the CLI could also auto-deploy the example factory, similar to what is done by the CLI with erc1155.

The Docker build is failing for me locally on this branch


Checkpointing for Callbacks.

Is your feature request related to a problem? Please describe.
It would be nice to enable checkpointing of the callbacks. The best case scenario is if checkpointing would allow you to resume training completely as if it hadn't stopped, and I think this feature would bring us one step closer.
Describe the solution you'd like
If you look at the code for LR schedulers in PyTorch it should be simple to implement:
  def state_dict(self):
        """Returns the state of the scheduler as a :class:`dict`.

        It contains an entry for every variable in self.__dict__ which
        is not the optimizer.
        """
        return {key: value for key, value in self.__dict__.items() if key != 'optimizer'}

    def load_state_dict(self, state_dict):
        """Loads the schedulers state.

        Arguments:
            state_dict (dict): scheduler state. Should be an object returned
                from a call to :meth:`state_dict`.
        """
        self.__dict__.update(state_dict)

They don't include the optimizer, because that would be stored/restored separately.
I would like to have a similar interface in the Callbacks, such that for example if training stops between each epoch and is restored, this will not make the Early Stopping callback void.
Additional Context
Reference docs: https://williamfalcon.github.io/pytorch-lightning/Trainer/Checkpointing/
Discussion/Unrelated
This is hardly related, but if you have time to read and consider the idea I would appreciate it. :)
It is hard to know all the things that must be done to make checkpointing completely save and restore the program state. (Short of using formal verification, which of course can't be done on the users code.)
One coding style that could make it more manageable is to adopt a somewhat more "functional" style in some of code. Currently we have self.restore simply return nothing and mutate the Trainer state. But realize that this function is always called when training is started
trainer.fit -> ... -> self.__run_pretrain_routine -> ... -> self.restore -> ... -> self.train.
The state we are using is always initialized/restored and then mutated later down the function call.
If the state is read from a checkpoint and only used in the training loop, is there any reason to keep this state in Trainer after trainer.fit returns?
The reason for the checkpoints is to be able to restore a training session, so what if we instead had a signature state = self.restore, then call self.train(state), where state contains all the trainer variables that are modified by the training procedure.
If all the variables modified are exclusively inside state (current index in loop, model, optimizers, callback statedicts, etc.) or derived from it, one can establish the invariant that a call to self.train(state) with the same state will always produce the same result.
A benefit is that one can then restrict to only passing the needed subset of the state to mutator functions, so bugs are easier to track down, or won't happen at all.
A more extreme version is to not mutate the state at all, and simply let functions return new objects (copy the old, modify and return modified versions) - a truly pure function. But this would likely not be of any benefit.

@sebftw the callbacks already save and restore state... so when you resume training from reload, it does exactly this.

@williamFalcon Ah. I see.
It would be nice to have a common interface to save/load the Callbacks, and to move the logic into these classes. But it's not big priority right now, IMO, since it works!


Fixes to adapt to changes in transformers

ImageProcessingMixin was segregated from FeatureExtractionMixin, see https://github.com/huggingface/transformers/pull/20501. FeatureExtractionMixin already exists, but the appropriate type returned by AutoProcessor is now ImageProcessingMixin.

Image sizes were standardized to dicts to avoid ambiguity.

These changes make most of the slow tests (but not all) pass again. Taking a look at the remaining ones.

Thanks, Pedro!


docs: Add note for SDK directories mounted with nodev

This was causing trouble for me when I was trying to use cork inside
/tmp.
Suggested-by: Jeremi Piotrowski<EMAIL_ADDRESS>Suggested-by: Thilo Fromm<EMAIL_ADDRESS>Signed-off-by: Chris Tarazi<EMAIL_ADDRESS>

@jepio @t-lo Thanks for the help, here's the PR to update the docs regarding the "permission denied" errors with cork inside /tmp.

Thanks! Hope this saves someone else from that trap 😄


supporting HostApplicationBuilder

It looks like microsoft are pushing towards usage of HostApplicationBuilder instead of IHostBuilder
https://github.com/dotnet/runtime/issues/61634
you could probably use an extensions like
public static HostApplicationBuilder UseSpectreConsole(this HostApplicationBuilder builder, Action<IConfigurator> configureCommandApp)
{
    builder = builder ?? throw new ArgumentNullException(nameof(builder));

    var collection = builder.Services;

    collection.AddSingleton<ICommandApp>(sp =>
    {
        var scope = sp.CreateScope();
        var registrar = TieredTypeRegistrar.FromServices(scope.ServiceProvider);

        var command = new CommandApp(registrar);
        command.Configure(configureCommandApp);

        return command;
    });

    collection.AddHostedService<SpectreConsoleWorker>();
    collection.UseDefaultSpectreConsoleArgs();

    return builder;
}

wdyt?

Great catch! Thank you :)
The only thing that is giving me headaches is the versioning.
I want to support as many runtimes and versions of both Spectre and Microsoft.Extensions.Hosting as possible.
Microsoft.Extensions.Hosting requires atleast version 7.0.0 to have the HostApplicationBuilder included, that means i cannot build against version 6.0.0 or lower, because nuget distinquishes between framework versions but not dependency versions...
2 possible solutions:

Follow the dotnet versioning: Create a branch for each supported runtime and use the minor and patch versions for releases.
Use multiple TargetFrameworks, use conditions in the PackageReference and use the good old compiler switches #if

I'm not really sure why spectre console aren't just splitting their composition root into an AddSpectreConsoleCli and the registration of the working into a UseSpectreConsoleHostedWorker or something. be inline with the community.
I'd probably go the extra mile and add some #IF and some conditionals on the package references. at least until net6 is out of support 🤷


Fixed the issue where the player's second skin layer did not appear after respawn (issue #284).

Description
The issue has been fixed by broadcasting the entity metadata packet with the skin parts inside the respawn function

Testing
I tested it and it works completly fine after this changes

Checklist
Things need to be done before this Pull Request can be merged.

[x] Code is well-formatted and adheres to project style guidelines: cargo fmt
[x] Code does not produce any clippy warnings cargo clippy

* [x ] Code is well-formatted and adheres to project style guidelines: `cargo fmt`
* [ x] Code does not produce any clippy warnings `cargo clippy`

- * [x ]
+ * [x]

LGTM.
Thanks @neioox


WIP: Don't pivot if identical sha256

This is a lowering of
openshift/machine-config-operator#463
to pivot.  We need it for the case of doing an early pivot
before the MCD comes up.

This is failing for me with:
F0308 12:54:37.000370   12936 root.go:136] parsing current osImageURL: parsing reference: "exampleregistry/redhat-coreos/maipo@sha256:c09f455cc09673a1a13ae7b54cc4348cda0411e06dfa79ecd0130b35d62e8670": unsupported digest algorithm

Which um...what?    This must be something with github.com/opencontainers/go-digest...it looks like the algorithms are package-scoped variables.  But why is it failing?

This looks good overall! Would be nice to also directly edit the origin so the custom string points to the new image. Basically reframe this not as a special case, but just following through with the operation and being smart about not rebooting like we currently do. Not essential right now though if we're going for a tactical fix.

Added a test, now banging my head against:
$ go test ./cmd/...
/tmp/go-build756046464/b001/cmd.test flag redefined: log_dir
panic: /tmp/go-build756046464/b001/cmd.test flag redefined: log_dir

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc00006a180, 0x670f20, 0xc000056660, 0x639cb8, 0x7, 0x644aa5, 0x2f)
        /usr/lib/golang/src/flag/flag.go:805 +0x529
flag.(*FlagSet).StringVar(0xc00006a180, 0xc000056660, 0x639cb8, 0x7, 0x0, 0x0, 0x644aa5, 0x2f)
        /usr/lib/golang/src/flag/flag.go:708 +0x8a
flag.(*FlagSet).String(0xc00006a180, 0x639cb8, 0x7, 0x0, 0x0, 0x644aa5, 0x2f, 0xc000056650)
        /usr/lib/golang/src/flag/flag.go:721 +0x8b
flag.String(0x639cb8, 0x7, 0x0, 0x0, 0x644aa5, 0x2f, 0xc00007e210)
        /usr/lib/golang/src/flag/flag.go:728 +0x69
FAIL    github/openshift/pivot/cmd      0.005s

https://stackoverflow.com/questions/37284423/glog-flag-redefined-error apparently...man Golang vendor/ stuff is a huge mess in comparison to Cargo.

Hmm, go test working OK here (though seems like one of the tests is failing):
$ go test ./cmd/...
--- FAIL: TestCompareOSImageURL (0.00s)
    root_test.go:17: Expected refA = refB
FAIL
FAIL    github.com/openshift/pivot/cmd  0.006s

Is your setup similar to this:
$ echo $GOPATH
/code/go
$ pwd
/code/go/src/github.com/openshift/pivot

(Similar -> pwd is $GOPATH + src/github.com/openshift/pivot)

OK yeah, no idea what was going on before.  I just pushed a tweak so that we display errors, now I get:
$ go test -v ./cmd/...
=== RUN   TestCompareOSImageURL
--- FAIL: TestCompareOSImageURL (0.00s)
    root_test.go:10: parsing current osImageURL: parsing reference: "registry.example.com/foo/bar@sha256:0743a3cc3bcf3b4aabb814500c2739f84cb085ff4e7ec7996aef7977c4c19c7f": unsupported digest algorithm
FAIL
FAIL    github/openshift/pivot/cmd      0.005s

OK so apparently
https://golang.org/pkg/crypto/#Hash.Available is returning false for crypto.SHA256...

https://golang.org/pkg/crypto/#Hash.Available is returning false for crypto.SHA256...

And import ("crypto/sha256") fixes this...then to avoid unused imports errors I had to add a dummy sha256 usage.  If this (or a better way to do it) is documented at all anywhere I can't find it.

man Golang vendor/ stuff is a huge mess in comparison to Cargo.

Yeah, it really is.

Rebased, though one open discussion.

Let's get this shipped please?

/lgtm

/cc @yuqi-zhang for syncing over


[Feature request] Loop invariant

It would be great if we can define loop invariant to keep track on updated variable inside the loop body for each iteration. Here is a use case for the feature
In the following loop body we need to have invariant for updated variable zeta_i to tell the resolver that its value is still inside the boundaries https://github.com/cryspen/libcrux/blob/ml-kem-lax-check/libcrux-ml-kem/src/ntt.rs#L61-L63
The feature can replace the assumptions in this code https://github.com/cryspen/libcrux/blob/ml-kem-panic-free/libcrux-ml-kem/src/ntt.rs#L66-L69 to make it verify.

Hey, thanks for the issue! That's a duplicate of https://github.com/hacspec/hax/issues/605 though. Can you comment in there and close that one?


Web.config migration should not include ASPNET-specific settings

ASP.NET MVC projects have a set of ASPNET-specific appsettings. These shouldn't be needed in ASP.NET Core and shouldn't be automatically migrated to the appsettings.json file. Without looking too deep I see the following appsettings that should be ignored when migrating the app settings.

aspnet:*
webpages:*
ClientValidationEnabled
UnobtrusiveJavaScriptEnabled

There may be more.

Also applies to the nested web.config in the Views folder

I also found these which have likely been legacy already for MVC5
    <add key="ChartImageHandler" value="storage=memory;deleteAfterServicing=true" />
    <add key="PreserveLoginUrl" value="true" />


Convert C++ Example to Docker Build Pattern

While this does make it a longer build time, it makes it easier to get started with the C++ example because there is no tooling dependencies other than Docker (Make is even optional, it just sets the default arguments up).
Also provides an end to end example of compiling the SDK, installing it and then using it with another C++ project.
Co-authored-by: @dsazonoff

/cc @dsazonoff Please confirm you are good with these changes being applied :smile:
Also do you see any issues here?

Looks good.


Revalidate doesn't refresh when an internal/external module is changed and remoteEntry.js is the same.

The hashing strategy for the revalidate is based on the response of remoteEntry.js, so if another internal module of app2 changes, the revalidate won't detect it as changed.
Any tips for fixing this on my side?

the remote hashes its chunks, so if anything it depends on changes, its hash changes since the referenced chunk ids would be different

the remote hashes its chunks, so if anything it depends on changes, its hash changes since the referenced chunk ids would be different

I don't see any hashes representing the imported changes on the dist/remoteEntry.js.
I tested it with a minimal working example: https://github.com/pedrokehl/module-federation-nodejs-example

Starting app2
starting app1
Before the interval finishes, change the file app2/mapBook.js
Restart app2
shouldReload2 is false, and content is not updated

I could only get it to have a different content (hash) on dist/remoteEntry.js by renaming mapBook for example.

This is still an issue, can we reopen it?

Hey @pedrokehl , have you found any fixes for this ?

I just released a node plugin update to ensure chunks in remote entry map are always content hashed. So if any chunk changed, the remote content hash will be different. We don't hash remote file name itself as we need to still be able to reference it. Try it now

Hey @ScriptedAlchemy  , I am still facing the same issue even after I tried all these steps

Upgraded the @module-federation/nextjs-mf to latest 6.2.2 and @module-federation/node to latest 0.12.2
Deployed it in the AWS Amplify in both of my host and remote apps
Then opened the deployed app and saw if everything was working fine and it did
Made a change to remote in two seperate components , just a text change and redeployed the remote
Came to the host app with the same remoteEntry file and checked if everything was working fine , but when we go to the component the api call to the remote in network tab throws 404 error saying that it is not found ,

May I please know how to fix this issue @ScriptedAlchemy  ?

@ScriptedAlchemy
The issue is unfortunately still happening.
There's no hashes on remoteEntry.js that would represent the files being imported by the exposed modules.
@Pradeep976
Were you able to workaround this?


When nexus.conf is parsed it doesn't ignored commented lines

When lines are commented out with # in config file, the wallet still adds them to map and prepends them with -. I believe you should be able to fix it by changing this line:
https://github.com/Nexusoft/LLL-TAO/blob/26a5dcd96ac66ee0f29f3c5bcdec7c2ad88329fa/src/Util/config.cpp#L44
To
if(i == std::string::npos || line.front() == '#')

This has already been updated via commit:
https://github.com/Nexusoft/LLL-TAO/commit/a7a4c4a36f6aa9ccd0544352c8ac2def3d228a27
to be included in release 3.0.2


mixing pipelines?

hi there.
Thanks for the integration. I've been looking for integrations that incorporate LocalAI into HA and there are only 2, or maybe just yours depending on how you count the other.
There was a time where I was using your integration and this other integration here
to try and get my working LocalAI into HA. I experienced an unusual problem where I had to delete both integrations, but its not clear which integration caused it so I will report here for now.
I had the other integration setup to point to my LocalAI instance, and then setup yours to point to it also. I also have the Core HA Integration for OpenAI using the API key.
But, what ended up happening was I was using the OpenAI HA Core integration as the voice assistant, but it was submitting the queries to my LocalAI instance.
I don't think I had changed the OpenAI integration to point to my LocalAI for the conversation agent...but maybe it was? Anyway could it be possible that there was some sort of pipeline crossing with your integration?
thanks :)

hi, ok I canfirm that its when I add this integrations that pipelines gets mixed up.
Here what do/see:
I have the the core OpenAI integration setup and also have the other integration setup. They are both working well, independtly. I Install this integration and point it to my LocalAI server. Your integration works well, except, when I try to use core OpenAI integration, that now dumps all the queries to my LocalAI instance and not to OpenAI.
any ideas what could be goin on?

Moved on from this. Thanks


move to root folder

This will get rid of the dashboard folder that wraps the application so once merged you would not need to do cd dashboard to get to the juicy part, but it's kind of disruptive so let's be careful when merging.

BTW this won't deploy since netlify expects things to be inside the dashboard folder, once it is merged, I'll reconfigure netlify


ARROW-15365: [Python] Expose full cast options in the pyarrow.compute.cast function

13109

 Quality gate: Passed
 Everything looks good
Details


cursor_control.hpp  show_console_cursor - multiple defintions

Not really looked into this - as I have a work around. But if you have multiple includes of cursor_control.hpp in separate source files you get the error:
pkcs11_progress.cpp:(.text+0x0): multiple definition of indicators::show_console_cursor(bool)'
pkcs11_ec_ecdsaAttacks.o:pkcs11_ec_ecdsaAttacks.cpp:(.text+0x376): first defined here
`

Making this function static inline should fix the problem.

Please confirm if this fixes the problem.

Fixed for me.


Add a better way to display trust between recipients

The idea is to add a --all option to the vault recipients command which will make a difference between all the recipients from gpg and the ones in your vaultfile.
This way it'd be really easy to know if you need to import someone into your vault or if there's someone in your vault which you don't have in your pubring

Closed by #15


Allow multiple congestion points per connection

1.1 Describe the improvement
The improvement would consist of allowing one connection identifier to be linked to multiple congestion points. Currently, the protocol only allows a connection identifier to be connected to a single congestion point in the Common Reference. This is identified as a reason for rejection of a connection registration in section 3.6.1 of the USEF Flex Trading Protocol Specifications 3.0.0.
This limitation does not allow to reflect the potential impact of a connection in different congestion points (or for different grid configurations), limiting the potential use of a connection to solve different congestion problems.
1.2 Additional context
This change request was initiated by Project FUSION since this problem was encountered during the trial.
1.3 Expected [behavior
What is expected is that the DSO has the freedom to define link the connection to different congestion points in the Common Reference.
Change request - allow multiple CPs per connection.pdf

This change request was approved by the TSC on 30/01/2023

Merged https://github.com/shapeshifter/shapeshifter-specification/pull/70 to fix this issue


SAK-33450 Add permission to hide students from roles

I think we talked on the JIRA about just using the perms from roster2 tool


fix: code clean up

minor cleanup
build fix for python package versioning with semantic release

:tada: This PR is included in version 1.0.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


.postcssrc.js not work in monorepo situation

Version
3.0.0-beta.15
Reproduction link
https://github.com/zhangbobell/vue-cli-lerna-reproduce
Steps to reproduce

git clone https://github.com/zhangbobell/vue-cli-lerna-reproduce.git
cd vue-cli-lerna-reproduce
yarn
cd packages/sample && yarn serve

What is expected?
runs well
What is actually happening?
broken since postcss error
Module build failed: Error: No PostCSS Config found in: /Users/myName/Sites/demos/temp/vue-cli-lerna-reproduce/node_modules/el
ement-ui/lib/theme-chalk

About my repos

I use lerna to manage monorepo include a repo create by vue-cli
I use a ui library element-ui, import it js and css
seems the imported css will be handled by postCSS, which will find it's config file recursively in it's parent directory until user's home directory
postcss-loader has  expose a options called path to specify the path of config file,  but vue-cli-service only pass in sourceMap option

Tried solution

I've tried use vue.config.js to override the config but failed, since it's not allowed, main because it's a internal config
postcss-load-config does not provide path options, cannot use the solution posted in the docs
following #1124 may solve this problem (the code snippet did not work since the config differs), but I did not try it, since the level of postcss config section is too deep, the callback will be a nightmare, may be encapsulate a vue-cli-plugin ?
put a .postcssrc.js in lerna root dir or add postcss section to root package.json will solve this, but I think it's not a elegant solution

So, would you please provide a elegant solution about this problem ?
Thanks very much !

We will make postcss-loader's option configurable in vue.config.js.

I have met same issue before with a monorepo project. Actually It's because yarn workspace is using different mechanism to resolve dependencies rather than lerna + npm.
If you try to use lerna with npm client in your provided repo, you will find it works fine.
Good news is, yarn workspace support a nohoist mode since v1.4.2 ( see https://yarnpkg.com/blog/2018/02/15/nohoist/ for more details), you just need to change your package.json to:
{
	"private": true,
	"devDependencies": {
		"lerna": "^2.11.0"
	},
	"workspaces": {
		"packages": ["packages/*"],
    "nohoist": ["**/element-ui"]
	}
}

@yyx990803 @jkzing thank you both, I'll try nohoist option in root package.json temporarily to solve this problem, and look forward the next release! 😄

closed via 0ba111e

@zhangbobell, how did you utilize the new vue.config.js functionality to solve your problem? Setting css.loaderOptions.postcss to {} did not get rid of the "No PostCSS Config found" error, but putting postcss: {} in the monorepo's root package.json file did work.

Same as @benlind, trying to set this code in vue.config.js:
module.exports = {
  css: {
    loaderOptions: {
      postcss: {
        plugins: {
          autoprefixer: {}
        }
      }
    }
  }
}

but doesn't work.
Thanks @benlind for the temporary solution in the root package.json :)

closed via 0ba111e

@yyx990803, this solution doesn't work for me, only placing postcss: {} in root's package.json file. I think this issue should be reopened.

This worked for me, but bear in mind that the config used in vue.config.js is more like the raw webpack config so the example mentioned by @maximelebreton isn't correct. You need something more like
module.exports = {
  css: {
    loaderOptions: {
      postcss: {
        plugins: [
          require('autoprefixer')()
        ]
      }
    }
  }
};

@mattnathan I said that my example did not work ;)

@mattnathan I said that my example did not work ;)

Ha, of course. I was hoping to help out by changing the example into one that did work (for me at least) in case some future person stumbled across this issue/thread and didn't have the time to work out the correct way to do it... mostly because I expect that person will be me in a few months time!

I just ran into this as well. I use Workspaces, so eventually I figured out PostCSS is looking for a config file at the root workspace, where node_modules actually lives. So pretty simple fix, just create a postcss.config.js file that exports an empty object, like so:
module.exports = {}

I usually add links to related issues, to reason why this file is necessary. I should also mention I didn't have to go through this for a React based project, so I'm guessing it's something with how PostCSS is integrated into the Vue service.


Custom lists are not supported to be passed as arguments

Regarding johncarl81/parceler#229, custom implementations of lists, such as those generated by Arrays.asList, Collections.unmodifiableList and List.subList, are not supported to be passed as an argument to an Activity when being parceled, as the type isn't recognized.
I think that to solve this issue lists can be casted as List class.

/cc @matir91


BHBC-1570: Add multiple contacts for restoration projects

Overview
This PR will allow users to add multiple contacts to the restoration projects.
Links to jira tickets

BHBC-1570

This PR contains the following changes

{List all the relevant changes. If there are many changes across many Jira tickets, organize the changes by Jira ticket}

This PR contains the following types of changes

[ ] New feature (change which adds functionality)
[ ] Enhancement (improvements to existing functionality)
[ ] Bug fix (change which fixes an issue)
[ ] Misc cleanup / Refactoring / Documentation
[ ] Version change

Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General

[ ] I have performed a self-review of my own code

Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[ ] I have avoided duplicating code when possible, moving re-usable pieces into functions
[ ] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[ ] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

[ ] My code follows the established style conventions
[ ] My code uses native material-ui components/icons/conventions when possible

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation, as needed

Tests

[ ] I have added/updated unit tests for any code I've added/updated
[ ] I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

[ ] I have run the linter and fixed any issues, as needed
See the lint commands in package.json
[ ] I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

[ ] I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
NOTE: This is just draft and will be updated with the UI finalized

Looks really good overall, nice work!


Decide on collaborative writing platform

Google docs gets my vote, but if anyone feels strongly about trying authorea, I could be swayed
I can edit this issue - Sam

Things I like from a writing platform

[ ] mouse integration
[ ] reference integration
[ ] gui interface

Google docs works for me!


Operator crash after update to v0.7.0

Hello.
I've tried to upgrade solr-operator from v0.6.0 to v0.7.0 in AWS EKS 1.27 but it crashes constantly:
2023-07-03T08:49:18Z	INFO	setup	solr-operator Version: v0.7.0
2023-07-03T08:49:18Z	INFO	setup	solr-operator Git SHA: 0e16c6b
2023-07-03T08:49:18Z	INFO	setup	solr-operator Build Time: Mon Apr 24 19:23:35 UTC 2023
2023-07-03T08:49:18Z	INFO	setup	Go Version: go1.19.8
2023-07-03T08:49:18Z	INFO	setup	Go OS/Arch: linux / amd64
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x12ab950]

goroutine 1 [running]:
k8s.io/client-go/discovery.convertAPIResource(...)
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/aggregated_discovery.go:88
k8s.io/client-go/discovery.convertAPIGroup({{{0x0, 0x0}, {0x0, 0x0}}, {{0xc00004f560, 0x15}, {0x0, 0x0}, {0x0, 0x0}, ...}, ...})
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/aggregated_discovery.go:69 +0x5f0
k8s.io/client-go/discovery.SplitGroupsAndResources({{{0xc00004e3f0, 0x15}, {0xc000049060, 0x1b}}, {{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, ...}, ...})
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/aggregated_discovery.go:35 +0x2f8
k8s.io/client-go/discovery.(*DiscoveryClient).downloadAPIs(0x1815ff3?)
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/discovery_client.go:310 +0x47c
k8s.io/client-go/discovery.(*DiscoveryClient).GroupsAndMaybeResources(0xc000001e00?)
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/discovery_client.go:198 +0x5c
k8s.io/client-go/discovery.ServerGroupsAndResources({0x1a8a320, 0xc0002b32f0})
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/discovery_client.go:392 +0x59
k8s.io/client-go/discovery.(*DiscoveryClient).ServerGroupsAndResources.func1()
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/discovery_client.go:356 +0x25
k8s.io/client-go/discovery.withRetries(0x2, 0xc0004c50d0)
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/discovery_client.go:621 +0x72
k8s.io/client-go/discovery.(*DiscoveryClient).ServerGroupsAndResources(0x0?)
	/go/pkg/mod/k8s.io/client-go@v0.26.1/discovery/discovery_client.go:355 +0x3a
k8s.io/client-go/restmapper.GetAPIGroupResources({0x1a8a320?, 0xc0002b32f0?})
	/go/pkg/mod/k8s.io/client-go@v0.26.1/restmapper/discovery.go:148 +0x42
sigs.k8s.io/controller-runtime/pkg/client/apiutil.NewDynamicRESTMapper.func1()
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.2/pkg/client/apiutil/dynamicrestmapper.go:86 +0x25
sigs.k8s.io/controller-runtime/pkg/client/apiutil.(*dynamicRESTMapper).setStaticMapper(...)
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.2/pkg/client/apiutil/dynamicrestmapper.go:119
sigs.k8s.io/controller-runtime/pkg/client/apiutil.NewDynamicRESTMapper(0xc000358870?, {0x0, 0x0, 0x2fb3e8039a338f01?})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.2/pkg/client/apiutil/dynamicrestmapper.go:99 +0x176
sigs.k8s.io/controller-runtime/pkg/cluster.setOptionsDefaults.func1(0xc00011d6c0?)
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.2/pkg/cluster/cluster.go:217 +0x25
sigs.k8s.io/controller-runtime/pkg/cluster.New(0xc0001c3200, {0xc000143a58, 0x1, 0x0?})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.2/pkg/cluster/cluster.go:159 +0x18d
sigs.k8s.io/controller-runtime/pkg/manager.New(_, {0xc00011d6c0, 0x0, 0x0, {{0x1a87000, 0xc00012f1c0}, 0x0}, 0x1, {0x0, 0x0}, ...})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.2/pkg/manager/manager.go:351 +0xf9
main.main()
	/workspace/main.go:171 +0x7b5

Hello.
We had similar problems with external-secrets https://github.com/external-secrets/external-secrets/issues/2344
Hope it helps.

Fixed this. I'll start a v0.7.1 release soon.

@angelprada The release candidate is out to try, please let me know if the docker image apache/solr-operator:v0.7.1-rc1 works for you. It should be a drop-in replacement for v0.7.0.

@HoustonPutman Tried and worked as expected!
2023-07-17T17:46:46Z	INFO	setup	solr-operator Version: v0.7.1
2023-07-17T17:46:46Z	INFO	setup	solr-operator Git SHA: 5205b93
2023-07-17T17:46:46Z	INFO	setup	solr-operator Build Time: Mon Jul 17 17:08:17 UTC 2023
2023-07-17T17:46:46Z	INFO	setup	Go Version: go1.19.11
2023-07-17T17:46:46Z	INFO	setup	Go OS/Arch: linux / amd64
2023-07-17T17:46:47Z	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": ":8080"}
2023-07-17T17:46:47Z	INFO	setup	starting manager
2023-07-17T17:46:47Z	INFO	Starting server	{"path": "/metrics", "kind": "metrics", "addr": "[::]:8080"}
2023-07-17T17:46:47Z	INFO	Starting server	{"kind": "health probe", "addr": "[::]:8081"}
I0717 17:46:47.169060       1 leaderelection.go:248] attempting to acquire leader lease kube-system/88488bdc.solr.apache.org...
I0717 17:47:17.922432       1 leaderelection.go:258] successfully acquired lease kube-system/88488bdc.solr.apache.org

Thank you!


(fix) Use absolute paths to avoid ambiguity with relative paths.

Related to #23

Coverage increased (+0.02%) to 86.651% when pulling 1f43f9cbace41bc6577732448c9580d30cf0a270 on mttrbrts:mr-fix-issue-23-again into 41c24b0cb86120ca07ad3207f02a7081454620b1 on accordproject:master.


Added script for scraping the pranger webshop (printing only)

still needs to be hooked up properly
creates no data structure, only prints
displays categories that should probably not be exposed to krautkoopf members
in essence a hack
have fun

Thanks a lot! :)
To do: (as a note to myself, or in case you want to carry on)

we need the item number / article number (so we can identify articles with changes instead of replacing all articles every week)
separate the article name from the unit, and also cut out "Bio-" (Regex?)
separate price information into price (without currency symbol), unit, and cut out "ca. "
when there is more than one unit option, we need to pick one (or else that has to be done manually). I think the smallest (lowest price) but preferably >=1.00€ would work best for us.


Quarterly maintenace q3 2020

Bumps node version in dockerfile, eslint and yarn versions, and adds new eslint rules from latest releases.

@optijon please post merge review.


Item rolls on Chat do not show Description and Modificators correctly

Description and Modificators are on different tabs. On chat Roll should show Description only.

Fixed, it will show up nicely on version 0.0.2


[React] Closes #162 Move testing to Jest + react-testing-library

@josephden16 could you fetch dev, fix the conflict and resubmit?


text centering of headers and text

[x] rolesurvey page
[x] front page
[x] factquiz page
[x] summary page of fact and role quizes
[x] groupsummary page
[x] faq page

All tasks completed


[multistage][cleanup] make leaf stage also registered with OpChainSchedulerService

Summary
Allow leaf-stage combine operator to run on the OpChain scheduler, this refactor makes all the execution logic consistent with a single codepath

it will be on the intermediate stage execution pool
LeafStageTransformOperator is going to be the push/pull model transition point for leaf-stage
allow QueryRunner.processQuery to return PhysicalPlanner or ServerRequestPlanner success/failure result back to broker instead of a blind OK

TODO

separate LeafStageTransformOperator into

generic PiplineBreakerOperator (e.g. wait until proceed forward operator); and
format transformer operator for v1/v2 format compatibility

Codecov Report

Merging #10711 (c7a0d32) into master (b72051c) will decrease coverage by 38.37%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10711       +/-   ##
=============================================
- Coverage     70.31%   31.95%   -38.37%
+ Complexity     5641      453     -5188
=============================================
  Files          2112     2112
  Lines        114048   114034       -14
  Branches      17223    17219        -4
=============================================
- Hits          80196    36440    -43756
- Misses        28255    74282    +46027
+ Partials       5597     3312     -2285

Flag
Coverage Δ

integration1
24.27% <0.00%> (-0.24%)
:arrow_down:

integration2
?

unittests1
?

unittests2
13.81% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...apache/pinot/query/mailbox/GrpcSendingMailbox.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/pinot/query/mailbox/InMemorySendingMailbox.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/query/runtime/QueryRunner.java
0.00% <0.00%> (-83.20%)
:arrow_down:

...e/operator/LeafStageTransferableBlockOperator.java
0.00% <0.00%> (-78.31%)
:arrow_down:

... and 1333 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

after discussion internally we realized several issues.

while receiving mailbox is yielding the opChain by returning a no-op block; sending mailbox is not yielding if it is blocked on a sender: say InMemoryMailbox if the receiving side is not polling it out fast enough then sending opChain will block on only 1 particular mailbox
putting the push-based and pull-based opChains into the same queue exaggerated the above problem b/c of the sending mailbox block
this causes other troubles if other operators can potentially cause the OpChain thread to park somewhere that's not returning a no-op block

going back to the drawing board and see what's the best solution. the current solution is to use a cached threadpool for intermediate stage
PRO: it immediately unblock the distributed deadlock issue.
CON: under high QPS threads start to thrash. (observed 20-30% overhead in QPS degradation)


Hiding future dates

Is there currently a way to hide subdomains that are in the future?  For example, with subdomain of day could days past the current day be hidden?

You can "hide" them visually by giving them the same background color as your page

Is there a way to target future days when setting color

They have .future class

Thanks.  Not sure how I overlooked that.  I feel a little sheepish. Closing.

When looking it appears that the current date also has future.  Does this have anything to do with time settings?

So what I found was the current subdomain had .future class.  I can add the highlight: "now" option and the future class goes away and .now is added.  This allows for the appropriate styling.

It seems like the .now class should be on the current date no matter what and .future should never be on the current date.


Save Button Enabled/Disabled based on changes

We have a HasChanges property in the base view model. The save close control uses a multi binding to toggle the save buttons enabled state. This becomes difficult to manage because not all user interactions triggers a property with a notify property changed event. That means that the user can change things and the save button stays disabled. Right now I changed the multi converter to always have the save button be enabled.

I developed an architecture around the "HasChanges" boolean. All editors now ask the user if they want to save if they try to close the editor with unsaved changes.


⚠ API - Lens has degraded performance

In f4841bf, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 502
Response time: 347 ms

Resolved: API - Lens performance has improved in d3929f6 after 8 minutes.


Revert "Interval Data Type Support for Chisel (#1210)"

This reverts commit 7b93b0f8c48e39cc9730cf9f91340cf733dadafe.

It's failing due to the pulled FIRRTL SNAPSHOT: sbt.librarymanagement.ResolveException: Error downloading edu.berkeley.cs:firrtl_2.12:1.2-20191030-SNAPSHOT. I'm thinking release branches should build from release branches, so 3.2.x should probably build FIRRTL from source and use that, alternatively it could depend on 1.2.+, thoughts?

Typically (in the past), I do all the tests by building from source locally (after deleting the edu.berkeley.cs ivy cache). I don't submit the dependency changes as PRs - I merge them directly into the Z.Y.x branch. They don't get CI testing. The dependencies (pretty much have to) reflect post-publishing.
I think reproducible builds are important so I'm hesitant to support wild cards in dependencies.
If we do want to have CI testing on release updates (which would be a good thing), I think it has to use build from source and publishLocal.

I think we definitely want CI on release branches because I want to automate bugfix backporting to make bugfix releases as easy to do as possible. I agree with you about reproducibility, so does that mean we should test against FIRRTL 1.2.0 and bump that number each time we release a new FIRRTL?
Per Jenkins, is that configuration in the repo or is it defined elsewhere? Can you fix the chisel3 CI for 3.2.x or is there some way I can help?

It's defined in the Jenkins job, which does allow overriding dependency versions. I can manually push this through with the correct dependencies, but we should use structured comments to define them.
(i.e., Requires firrtl |)

Ideally there's no need for manual intervention at all if we want to automate backporting, can we make Jenkins treat release branches like 3.2.x differently than master?

Yes. We can add branch-specific Jenkins job code.


Variant Inspect Card - Pedigree 'alt' bar needs better labels.

need labels 9 alt, 10 ref instead of 9 of 19

Tony Di Sera Mar 5 at 1:06 PM
Let's get rid of the commas. Also, can we fix a related bug? It looks like when the sex is unknown (diamond symbol), the allele count bar overlaps with the symbol. Screen Shot 2020-03-05 at 1.04.34 PM.png
Reply
Tony Di Sera Mar 5 at 1:02 PM (edited)
Oops. I just realized that the allele counts don't show when we load a single proband, because the pedigree/genotype viz doesn't show. So we either need to change the logic to show the pedigree with the one node or add back the 'allele counts' popup when only a proband is provided.
Screen Shot 2020-03-05 at 1.01.01 PM.png
Reply
Matt Velinder Mar 3 at 1:15 PM
With newest push it looks fixed
Edit - Delete
Matt Velinder Mar 3 at 7:26 AM
Not fixed on stage.gene as launched from Mosaic (see image.png above)

@mvelinder @tonydisera @WilliamRichards2017 When there are specific examples in the description, can we include sample, gene, variant info so it can be recreated in testing?

Sure thing.  To show the proband as a diamond, try this.  Go to files and rather than clicking on 'Demo data', just enter the platinum demo for proband, mom, dad.

And go to what gene?


Halo effect on radio button not centred on button

Hello, the halo effect on radio button click is not centred on the radio button.
Tested on Firefox 39 and Chromium 43.
See screenshot please.

Thanks for the bug report. It looks like we could improve the overall centring here, but will need to check this cross-platform too. @sgomes could you take a look?


”Brăești”, ”Albești”, ”Buda”, ”Cristești”, ”Rediu” are listed in the drop-down menu

Description:
When user writes ”Brăești”, ”Albești”, ”Buda”, ”Cristești”, ”Rediu” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Brăești"

Expected results
The location appears in the drop-down menu as "Sat Brăești, IAȘI (Brăești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Albești"

Expected results
The location appears in the drop-down menu as "Sat Albești, IAȘI (Brăești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Buda"

Expected results
The location appears in the drop-down menu as "Sat Buda, IAȘI (Brăești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Cristești"

Expected results
The location appears in the drop-down menu as "Sat Cristești, IAȘI (Brăești)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Rediu"

Expected results
The location appears in the drop-down menu as "Sat Rediu, IAȘI (Brăești)".


Promisify web3 sync requests in tests

Fixes #999
🚀 Description
Makes use of the toPromise helper already present in the codebase to promisify web3.eth.getBalance function calls throughout the tests.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[ ] ✅ I've added tests where applicable to test my new functionality.
[ ] 📖 I've made sure that my contracts are well-documented.
[ ] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@LogvinovLeon Done. Let me know if I missed something. Thanks!
P.S. I can squash the commits before the PR is good to merge.

Could you please rebase your changes of the latest master branch?

@shrugs Any chance you or any other maintainer can review that?

@LogvinovLeon Sure, let me do it :slightly_smiling_face:

hmm, SOLC_NIGHTLY is failing because of an ECRecovery call throwing instead of returning 0x0. Investigating.


Feature/default recipe

This feature branch adds default recipe. It can be useful for those people who follow strategy of reusing already existent code as much as possible, because writing and supporting own cookbooks in large chef infrastructure is expensive.

Hi @alxgrh
Thank you for opening a Pull Request. Unfortunately I will not be merging this. I do not believe community cookbooks should include recipes, but instead expose primitives for others to build on.
The attribute-driven approach has been proven to be faulty, especially in large organizations as it gets incredibly difficult to look at 500 lines of JSON and reason about the end result of the machine.
Adding a recipe opens the door to "tunable" attributes, which I think are an anti-pattern in community cookbooks.


Restore / upgrade to 16.04 fails

https://bazaarvoice.box.com/s/4k9comma4uw4k6uf5va1ys4h6rg9i1rg is debug info from two nodes. The third node was inaccessible entirely. I am retrying now, but I believe I've seen this before.

Third node has returned to accessible, and appears to have bootstrapped successfully. However, the cluster does not coalesce, and was unfortunately torn down before I could get fuller debug info from the third node.
Another instance of the cluster built correctly, so this may be lower priority. I will attempt some additional builds against it, once I've made our backups work with the restrictions of 16.04.

@temujin9 it looks like the third node became inaccessible at 2017-01-10T02:50:26Z which then caused issues for the discoverd cluster (we are investigating strategies for minimising the impact of this in #3766).
Without the logs from the third node, it's hard to determine the root cause here.

I am going to close this, please open a new issue if you see this same behaviour again and try and get the logs.


Update LICENSE

Update License from symlink to file

Thank you @morri-son for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Superseded by https://github.com/open-component-model/delivery-service/pull/82


🐛 alertdialog should be permitted on dialog elements

Environment information
as outlined here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog#technical_summary

the `alertdialog` should be a permitted role for `lint/a11y/useSemanticElements` on `<dialog />` elements.

CLI:
  Version:                      1.9.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.12.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.10.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

I defined a dialog element with the role of alertdialog

Expected result
I should not see an error for lint/a11y/useSemanticElements
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Could you add a playground example for reproduction?

@Conaclos ah, you know what, I'm in the middle of porting the codebase from ESLint to Biome, it was ESLint, sorry for the false report.


Add MonotonicUpperBound

This ensures that older versions of a package have older versions of dependencies.
xref https://github.com/JuliaRegistries/General/pull/7342
(I know this needs tests, this is just for early feedback.)

Just from a quick look, this looks great!

OK, now this is a real PR. Worth nothing that master fails the same test this one fails.

bors try

Just pushed a small improvement to the test.

bors try-

bors merge

bors merge

bors merge-

Alright I made a few changes to get tests to pass. Take a look and make sure it still looks good.

Yes, seems fine to me. Thanks for the fixes!

Bors merge

Bors merge


Release 1.13.0

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all
/test-vm-e2e

test-vm-e2e is failed with a known issue, @wenyingd has found the root case and it's a test code bug, so we can ignore the failure.
FAIL: TestVMAgent/testExternalNodeWithANP/testANPOnWindowsVM/testANPOnExternalNodeWithFQDN

/test-windows-proxyall-e2e

/test-flexible-ipam-e2e

/test-multicast-e2e

test-windows-proxyall-e2e, test-windows-e2e and test-windows-conformance test can be ignored, this is based on docker, we have changed to containerd based test from v1.13.
multicast-e2e and flexible-ipam-e2e are caused by a testbed issue, we add new meter related metrics in this release, but the old test bed don't support meter feature, the metrics related e2e test cases need to be refined to support both cases.
We can ignore the failure at this moment.

/skip-conformance


Added a job update command to make changes to a job

This is a command that lets a job make changes to itself at runtime. The client doesn't know about what it can update, so it's pretty generic. We can add support for different attributes as we go.
The first attribute I'm supporting is label. This is useful if you want to call out something from inside a job, but don't want to a full blown annotation:
buildkite agent job update "label" " :warning::warning::warning:" --apend

[x] Send a change UUID so the backend make the changes idempotent

@lox cool, thanks for the review. Will merge once I've pushed the backend for it 👌

So I first called this job update, but I'd like to change it to step update, to align with the things you declare in your pipeline.yml file. Any major objections?
If you have a "tests.sh" step that fails, and you retry it, the step is still the same. We've just internally created a new job to represent the new work for it. The step is the "intention" of the work.
If you buildkite-agent step update in a parallel job, it'd make the change all the parallel jobs in the step.

This pipeline here demonstrates the concept well. With this sort of view, the "label" of the job doesn't really matter. The thing I actually want to change is the step label in the build pipeline.
More generally I want to make a clearer distinction between steps and jobs. A build has steps, and steps have jobs. The benefit of this layer is it gives us a great foundation for jobs that kick off to other jobs. Let's say your job is "run-this-script.sh", the step is "Run This Thing". The step shouldn't care that it created a job, which was then handed off to another agent to do the thing. All the build cares about, is if "run-this-script.sh" actually does it's thing (similar to what we've been talking about for a while @lox).
So there could very well be a job update command in the future, but for the use cases I'm aiming for with this plumbing, step update makes more sense.


[WIP] refactor SciMLOps to work with AbstractArray in place of AbstractVecOrMats

due to changes in https://github.com/SciML/SciMLOperators.jl/pull/200
TODO

[ ] change FunctionOperator to use AbstractArray everywhere
[ ] change cache interface to accept AbstractArray
[ ] ensure methods dont clash with methods in multidim.jl
[ ] change all the wrappers and all operators except MatrixOperator to accept AbstractArray so you can add/ compose, affine FunctionOperator
[ ] do size check before mat_mul for all ops
[ ] AffineOperator will also require batch kwarg for b
[ ] Maybe we need to add kwarg active_dims to FunctionOperator
[ ] Things will get complicated with TensorProductOperator because of all the reshaping. Right now we do pairwise tensor products with nesting, and composite operators are reshaped to act on AbstractMatrices. At the very least we need a notion of what dims the composite operators are acting on

looks like rm'ing the redundant functionop constructor didn't break anything. good

@ChrisRackauckas

@ChrisRackauckas can you take a second look sometime soon? this is holding some stuff up.


Bullet threading broken

Should be updated, as the Dev theme allready has been. This change in Logseq breaks the current bullet threading: https://github.com/logseq/logseq/pull/3559
Hoping for a quick fix 😊 Love this theme!

👋 Thanks for the note. I just pushed the change to the main code base but still need to submit a PR to the marketplace. In the meantime you can use the import: @import url('https://cdn.jsdelivr.net/gh/sokirill/logseq-panic-theme@latest/custom.css');

👋 Thanks for the note. I just pushed the change to the main code base but still need to submit a PR to the marketplace. In the meantime you can use the import: @import url('https://cdn.jsdelivr.net/gh/sokirill/logseq-panic-theme@latest/custom.css');


Unable to filter for all rights reserved photos

See: https://forum.inaturalist.org/t/cannot-filter-for-observations-with-all-rights-reserved-photos/18160
I'm unsure if this is a bug or intended, but some forum users said that license=none and photo-license=none params used to work when searching for all rights reserved photos. It's not possible to use those now, though, nor do license=false and photo-license=false. Can we make those work in the URL at least, if not add as an option to the UI?
Use case: some user want to find unlicensed photos so they can contact the observers and ask them to change the license or allow them to use the photos.

Can you be more specific about where on the site you're talking about? You can filter for licensed photos at https://www.inaturalist.org/observations, https://www.inaturalist.org/taxa/36204-Sceloporus-occidentalis/browse_photos, maybe elsewhere.

via Explore. The dropdown options for licensing include all options except for all rights reserved

and directly editing the URL here doesn't work either

The observations search page previously supported a photo_licensed boolean parameter, and now additionally supports a licensed boolean parameter for observation licenses. Setting to false in either case returns only all rights reserved content, e.g. https://www.inaturalist.org/observations?photo_licensed=false, https://www.inaturalist.org/observations?licensed=false . No additional UI has been added

perfect, thanks Patrick

I'm going to close this as the ability to filter is there. If someone wants to request updating the explore page UI, please open a separate ticket


[SQLite] Add boolean mode to integer

Continuing on from https://github.com/drizzle-team/drizzle-orm/pull/411

@meech-ward the pipeline is failing

this looks great! any ability to get this in soon?

@dankochetov would you be able to check this one again?


Fix URLPattern query error

Quick fix of that

After thinking about it for a while, we prob should not use this api at all. It's experimental and not supported in firefox (that we plan on supporting) ref: https://developer.mozilla.org/en-US/docs/Web/API/URLPattern

So what we're going to do with this?

After thinking about it for a while, we prob should not use this api at all. It's experimental and not supported in firefox (that we plan on supporting) ref: https://developer.mozilla.org/en-US/docs/Web/API/URLPattern

So what we're going to do with this?

Get hostname in any other possible way?


[DOCFIX] Add a missing new line.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15682/
Test PASSed.


Implement StableDeref for singleton::Box

There was a discussion in the riot channel about what it's needed for a buffer to be DMA safe, where ra_kete came up with this POC:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=339a9a29fb59c080b42b6d77a902acb6
Where it seems that the requirements described in the Embedonomicon doesn't seem to be enough to prevent stack corruption.
If that is really the case and we decide to use StableDeref instead, then a implementation for Box is very important to be able to easily use it on DMA APIs and a new point release would be necessary.
CC @korken89

bors r+


Documentation on reduced (v0.20.1)

Reduced API docs state:
Note: this optimization is unavailable to functions not explicitly listed above. For instance, it is not currently supported by reduceRight.
But it doesn't list which functions support this optimization above (or below).

Yup, definitely needs to be fixed.  Might take a bit of digging, but should be fairly straightforward.

Hey i'd like to pick this up as my first contribution! Can someone please point me in the right direction?

@morgsmccauley: That's great!  (Sorry for the slow response.  Been busy on other projects.)
I would suggest simply finding which files import _reduced and double-checking that it does actually do what it suggests for them.

Cheers @CrossEye! I'll come up with a list of all functions currently supporting reduced and then check back in on how to update the documentation.

Updating the documentation is just a matter of updating the comment sections on the functions.  The docs are extracted from those.

It looks like _reduce checks for @@transducer/reduced on the accumulator every loop (set by _reduced) and short-circuits if present and true.
Because of this, both reduce and reduceWhile support reduced as they both use _reduce under the hood. reduceBy also uses _reduce, but it has a bit more going on so doesn't work as expected (and also doesn't make much sense?).
What confuses me though is when functions are used as transducers, because @@transducer/reduced pops up a lot in this context. Is there such a thing as users wanting to use reduced when trying to build a transducer, or is this just used internally?
I think reduce and reduceWhile may be sufficient for a list of supported functions but just wanted to check in first. Is there more that i'm missing? I'm very happy to keep digging but I may need more guidance. Functional concepts are relatively new to me, apologies if these are basic quesitons. All help is very much appreciated!

I will have to check into this.  Although it gets easier each time to wrap my head around transducers, I don't really remember it between times.  I suppose the question is whether there are other functions that themselves depend on reduce or reduceWhile.  Many of them could be written in terms of these, but there probably are not many which are.

So I ended up going through the 63 files which mention reduce. These mentions include _reduce, reduceWhile, forceReduced etc. From this I have concluded that the only functions which truely support reduced are:

reduce
reduceWhile
transduce
Note that pipeWith also supports reduced depending on the application but I think this may be by accident and something like R.when would be better suited for the use-case.

Many _x* functions/transducer implementations mention reduce but this is for internal capability to ensure the function works as expected when used as a transducer. For example, R.take will short-circuit the transducer when the specified number of values is met.
I have created a pull request adding the above supporting functions to the documentation of reduced and I have also added tests to support this.
As a side note, it may be beneficial if all reduce* functions support reduced, which is possible. I am happy to raise a PR for this if there is interest.

As a side note, it may be beneficial if all reduce* functions support reduced, which is possible. I am happy to raise a PR for this if there is interest.

I think that would be a very good idea.  If you're willing to take it on, then thank you very much.

Thanks @CrossEye. Ill work towards a PR for that when I get the time :)


Change os.Stderr reassign for Windows service

Previously we were reassigning os.Stderr to the panic.log file we create
when getting asked to run Containerd as a Windows service. The panic.log
file was used as a means to easily collect panic stacks as Windows
services don't have regular standard IO, and the usual recommendation
is to either write to the event log or just to a file in the case of
running as a service.
One place where this panic.log flow was biting us was with shim logging,
which is forwarded from the shim and copied to os.Stderr directly which was
causing shim logs to get forwarded to this panic.log file instead of just
panics. We expose an additional --log-file flag if you ask to run a
windows service which is the main way you'd get Containerd logs, and with
this change all of the shim logging which would today end up in panic.log
will now also go to this log file.

This was intended to resolve https://github.com/containerd/containerd/issues/6990

@kevpar ping

ping @kevpar

Sorry, been meaning to get to this one...
I created a table to summarize the behavior here, both before and after the change:

I think we could do with a comment in service_windows.go explaining overall what happens with output when run as a service (e.g. what's in this table), since it seems kind of unintuitive.
One thing I'm wondering: When run as a service I don't think stderr goes anywhere useful by default. Would it make this code easier to read to explicitly set os.Stderr = io.Discard in the "no log file" case, so then it would match how we set up log and logrus output?
Otherwise I think this seems reasonable. This will keep panic.log isolated[1] to just actual panics. If users want logging they can set a log file to be used (or collect via ETW, though that won't work for shim logs).
[1] Of course, if any other code in containerd specifically queries GetStdHandle(STD_ERROR_HANDLE) and writes to it, that will still end up in panic.log. I don't think there's anything we can do about that unless Go chooses to support explicit panic log redirection, though.

I think we could do with a comment in service_windows.go explaining overall what happens with output when run as a service (e.g. what's in this table), since it seems kind of unintuitive.

Will add

One thing I'm wondering: When run as a service I don't think stderr goes anywhere useful by default. Would it make this code easier to read to explicitly set os.Stderr = io.Discard in the "no log file" case, so then it would match how we set up log and logrus output?

Sure that's a good idea, better to be explicit.

@kevpar Updated! PTAL

Linux CI failures are definitely unrelated and the node-e2e failed on some preamble for fetching package lists

/retest


Stop Signs In Aayaat Disappear While Verses are Playing

Salaam,
Please notice the difference when a verse is highlighted for playing and when it's not. The stop signs disappear:
Not Playing (They're Good)

While Playing (They're Hidden)

@naveed-ahmad should we close this?