No UI for resolving Git conflicts

When there are conflicts caused by two people making changes to the same MakeCode project that has been shared by Github, there is no facility/UI for resolving those conflicts. In fact, without teaching the users how to resolve conflicts in Github (which is super difficult to teach to the under 12 crowd), there's no way to fix this.
I finally figured out we could tell kids to delete the merge-1 branch that is created during the conflict and close out the pull request. Then one kid's changes are deleted, but at least the project is back on track.

For now they can stay on master; we have conflict resolution when pulling there. Still wip for PRs

What does that mean to have them stay on master?
Here's our scenario:

Two kids working together on a project where they both want to work on the same MakeCode Arcade game independently while working at their own homes. They're both working off the #master branch.
They do not properly negotiate working times and both make changes to the same version of the project and check in at the same time, neglecting to pull remote changes before hitting commit.

We always pull origin before doing a commit and we merge conflict resolution in MakeCode in master when pulling changes from GitHub.
So if they have conflicts, they will have to resolve them before doing the commit.

Yep, and there's no UI or instructions for doing that conflict resolution.
That's a hole in the workflow. Could you provide instructions on how to resolve it for "IT Support"? (meaning the teacher).

There is UI for conflict resolution but it seems that you are not seeing it or it might have broken up.
Again, only when pulling changes from master currently.

From: Andrew Begel<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:03:56 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Peli de Halleux<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
Yep, and there's no UI or instructions for doing that conflict resolution.
That's a hole in the workflow. Could you provide instructions on how to resolve it for "IT Support"? (meaning the teacher).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1908%23issuecomment-634362191&data=02|01|jhalleux%40microsoft.com|2fade6599ddc49ad83c008d801d9d505|72f988bf86f141af91ab2d7cd011db47|1|0|637261382469977595&sdata=E3a1kj1RLL4Mn9IVzdI2LOp6tHXENvYn9GTtU0tKNvE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKO7Q3G3ASRBW7DYNRLRTRRHZANCNFSM4NLL2HPQ&data=02|01|jhalleux%40microsoft.com|2fade6599ddc49ad83c008d801d9d505|72f988bf86f141af91ab2d7cd011db47|1|0|637261382469977595&sdata=my1tUv8UkGPLIUJ2znpN7k2bsOx0je0RIfIJIzUECmM%3D&reserved=0.

Definitely a hole in PRs flow.

From: Peli de Halleux<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:06:10 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
There is UI for conflict resolution but it seems that you are not seeing it or it might have broken up.
Again, only when pulling changes from master currently.

From: Andrew Begel<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:03:56 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Peli de Halleux<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
Yep, and there's no UI or instructions for doing that conflict resolution.
That's a hole in the workflow. Could you provide instructions on how to resolve it for "IT Support"? (meaning the teacher).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1908%23issuecomment-634362191&data=02|01|jhalleux%40microsoft.com|2fade6599ddc49ad83c008d801d9d505|72f988bf86f141af91ab2d7cd011db47|1|0|637261382469977595&sdata=E3a1kj1RLL4Mn9IVzdI2LOp6tHXENvYn9GTtU0tKNvE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKO7Q3G3ASRBW7DYNRLRTRRHZANCNFSM4NLL2HPQ&data=02|01|jhalleux%40microsoft.com|2fade6599ddc49ad83c008d801d9d505|72f988bf86f141af91ab2d7cd011db47|1|0|637261382469977595&sdata=my1tUv8UkGPLIUJ2znpN7k2bsOx0je0RIfIJIzUECmM%3D&reserved=0.

Wait is this blocks or JavaScript?

From: Peli de Halleux<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:07:11 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
Definitely a hole in PRs flow.

From: Peli de Halleux<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:06:10 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
There is UI for conflict resolution but it seems that you are not seeing it or it might have broken up.
Again, only when pulling changes from master currently.

From: Andrew Begel<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:03:56 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Peli de Halleux<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
Yep, and there's no UI or instructions for doing that conflict resolution.
That's a hole in the workflow. Could you provide instructions on how to resolve it for "IT Support"? (meaning the teacher).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1908%23issuecomment-634362191&data=02|01|jhalleux%40microsoft.com|2fade6599ddc49ad83c008d801d9d505|72f988bf86f141af91ab2d7cd011db47|1|0|637261382469977595&sdata=E3a1kj1RLL4Mn9IVzdI2LOp6tHXENvYn9GTtU0tKNvE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKO7Q3G3ASRBW7DYNRLRTRRHZANCNFSM4NLL2HPQ&data=02|01|jhalleux%40microsoft.com|2fade6599ddc49ad83c008d801d9d505|72f988bf86f141af91ab2d7cd011db47|1|0|637261382469977595&sdata=my1tUv8UkGPLIUJ2znpN7k2bsOx0je0RIfIJIzUECmM%3D&reserved=0.

Blocks.

So part of the conflict were the graphics for the diff.

Collab on blocks still needs a bunch of work for sure.

From: Andrew Begel<EMAIL_ADDRESS>Sent: Tuesday, May 26, 2020 6:12:13 PM
To: microsoft/pxt-arcade<EMAIL_ADDRESS>Cc: Peli de Halleux<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [microsoft/pxt-arcade] No UI for resolving Git conflicts (#1908)
So part of the conflict were the graphics for the diff.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1908%23issuecomment-634364782&data=02|01|jhalleux%40microsoft.com|52fea9d106a14a717fda08d801dafd4b|72f988bf86f141af91ab2d7cd011db47|1|0|637261387350394816&sdata=%2BB%2B2TSUHGj72kWYmC2RaaW0SE56nXDXq6idDcld87mo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKOM62U543OK4T3FIZTRTRSG3ANCNFSM4NLL2HPQ&data=02|01|jhalleux%40microsoft.com|52fea9d106a14a717fda08d801dafd4b|72f988bf86f141af91ab2d7cd011db47|1|0|637261387350404809&sdata=L1tCP1gOAgfWJcM73uPlUJ7PsWtofbfVBfhYbZHtE%2Fg%3D&reserved=0.


Provide a CHANGELOG

To be able to track what's new and know about breaking changes.
(Thanks for this module!)

technically you can trust a major version to properly break stuff, but if there's a tool that can help build changelogs without too much human interference, I'll be more than happy to add one.

Like https://github.com/rvagg/changelog-maker ?
There are several tools for that, https://github.com/search?utf8=✓&q="CHANGELOG.md"&type=
It's pretty common to add to libraries, would be greatly appreciated.

changelog-maker is kind of a less useful way to do what https://github.com/pomax/react-onclickoutside/compare/v5.7.0...v6.0.0 already does, and that seems to be the norm rather than the exception: libraries like this keep the job of writing an actually useful changelog an arduous manual task. If you know of any specific ones that generate nicer changelogs instead of just writing out commit diff dumps, please let me know.

There's lerna/lerna-changelog which 'Uses github PR/Issue names categorized by labels with configurable headings'. It's used by create-react-app/releases. Probably not much more useful than changelog-maker though.
Even without automatic changelogs, a quick one-liner in the release page or CHANGELOG.md would be much appreciated. This package gets 150k downloads a week and there's no mention of the breaking changes in https://github.com/Pomax/react-onclickoutside/compare/v5.7.0...v6.0.0

@GeKorm this project uses semver, so major version bumps are by definition breaking changes. That said, I'll have a look at lerna-changelog, thanks for the recommendation!

semver is not a real solution for this. It still forces the user to re read all documentation to figure out the breaking change (which may be a function rename or a whole new API). A single liner description fire each version would be great. I wouldn't necessarily trust the generators because they probably rely on detailed PR description which might not always be the case. Anyway, thanks for the hard work.

Ive added release notes for v6+ and I plan to add new ones each time the library gets an update.


Helidon init does not produce app.yaml for 3.x.x

It used to work (and it's also described in the quickstart).
For some reason now it only works when selecting version 4.0.0.
Creating a project with the Maven archetype does not work either (which I guess is what helidon init does under the hood) but I admit I did not try that in the past.

Indeed, this issue was reported and fixed under the Helidon repository: https://github.com/helidon-io/helidon/issues/7215

I see. Still does not work with the current version of helidon init when selecting a 3.x.x version. Is there a way to fix this behavior?

Yes, it will be included in the next 3.x Helidon release.

Yet there is something weird to my eyes.
Creating a 3.x.x project results in a missing app.yaml while creating a 4.0.0 project with very same version of the helidon cli does not. This seems to suggest that the helidon cli is using different revisions of archetypes/helidon/src/main/archetype/common/presets.xml depending on the chosen Helidon version.
And, if that is the case, why it "sees" a different preset.xml for 3.x.x than what it used to "see" a couple of versions ago (given that it used to create the app.yaml file)?


Suggestion/Discussion: add automatic semantic-release to the pipeline

Hi @seeseemelk,
I wanted to discuss a feature for the ci/cd pipeline: semantic-release. This workflow action allows for automatic releases and version bumps of the library according to the semantic versioning schema.
It assumes a special commit format (conventional-commits) to parse the correct next version and sets it inside the gradle.properties and in any other files you want. It will also automatically generate a changelog.
I have this active for all of my projects and since MockBukkit stems on SemVer, I would highly suggest implementing it. This would change the PR checklist from manually bumping the version to automated versioning. But it requires commits to follow the conventional commit format.
You can see the workflow, changelog and versioning in action on all of my projects, e.g.: spigot-plugin-template. If wanted I will assist and send a PR that implements it in the pipeline.
What do you, and others, think?

I think it's very good.
However, in addition to using semantic versioning as a way to increase the versioning, I can think of other ways to add specific labels to the PR (e.x. version/major, version/minor, version/patch, etc.).

I'd love to be able to just label PRs like that and have the version bumped automatically.
If you find an action which does this, feel free to write a workflow and make a pull request @rona-tombo.
I'd happily take a look and consider merging this if seesee agrees (I think he would).

I love the idea of being able to bump the version number using a label

Fully implemented with #424


Add Parsing for Logical AND  Token

Update the parser to handle the LOGICAL_AND token, allowing it to correctly parse expressions involving the && operator.

@Sahil06012002  working on this


Client abstraction

This is not a final design but a draft based on recent discussions: Ideally, we should have certain elements of the Client abstracted away for users to provide desired implementations according to environments:
pub struct Client<S: Store, P: TxProver, N: NodeRpc, A: Authenticator, R: Rng> {
    store: S,
    node_rpc: N,
    tx_executor: TransactionExecutor,
    tx_prover: P,
    authenticator: A,
    rng: R,
}

[x] Abstract away Rng: we need to give users a way to inject randomness as this can be environment-dependent (#22)
[x] #174
[ ] Proving: In the future, it would be desirable for proving to be delegated in order to enable weak clients to easily submit proofs with their transactions.
[x] Rpc: In order to abstract I/O with the node, which can also be target-dependent, we need to abstract the RPC client. #145
[x] Authenticator: In order to provide user-defined authentication input mechanisms

the authenticator was added in #321

Closing as done and creating a new issue for delegated proving


input type file

Hi,
is there a plan to change 'input type file' look? It's a bit delicate problem, heck I can't make it properly, but defaults are just soooo ugly.
Thank you

Hi, I tried file input control, but it lacks file path string only with CSS. I will see there is another solution.

According to a StackOverflow Article there's (due to security reasons) no way to extract the file path.
But here's a good Article about how to style it:
Tympanus: Styling & Customizing File Inputs the Smart Way
Is it really necessary to show the file path?

Yeah, input type file is screwed, maybe it would be best to make simple solution (just button) and leave paths to user (because of js)? Really not sure.

There are good reasons, that access to the file path(s) is not accessible.
In my opinion, just a button would be enough as long as you style it properly and make it recognizable and accessible.
Even Google does it.

While there is no CSS-only solution, most browsers support the JavaScript File API which allows to access at least the name. Requires JavaScript, though.

http://jsfiddle.net/barney/uxPjN/

@tomlutzenberger Can you show me how Google does it?

I saw it in Tag Manager recently.
Go to "Admin / Import Container".
They do it as follows:
HTML

<button type="button" class="btn btn-raised" ng-click="fileUploadClicked()">

    Choose container file

</button>
<input type="file" name="uploadedFile" style="visibility: hidden;">

CSS
.btn.btn-raised, button.btn-raised, input[type="submit"].btn-raised {
    background: transparent;
    border: none;
    box-shadow: none;
    font-weight: 500;
    height: 32px;
    line-height: 32px;
    padding-left: 8px;
    padding-right: 8px;
    text-transform: uppercase;
    box-shadow: 0 1px 5px 0 rgba(0,0,0,0.2),0 2px 2px 0 rgba(0,0,0,0.14),0 3px 1px -2px rgba(0,0,0,0.12);
    background: #f5f5f5;
    border-radius: 3px;
}
input:not([type='submit']), select, .gtm-form-input {
    background: #ffffff;
    border: solid 1px #c2c2c2;
    border-radius: 2px;
    color: #444444;
    font-family: Roboto,Arial,sans-serif;
    font-size: 14px;
    height: 34px;
    line-height: 34px;
    padding: 0 8px;
    vertical-align: middle;
}

JS
 /* ... */
}).directive("gtmFileInput",
	function ($timeout) {
		return {
			scope: {
				file: "=",
				buttonText: "@"
			},
			link: function (scope, element) {
				var inputFileElement = angular.element('<input type="file" name="' + element.attr("name") + '" style="visibility: hidden"/>');
				element.append(inputFileElement);
				inputFileElement.bind("change", function (event) {
					scope.$apply(function () {
						scope.file = event.target.files[0]
					})
				});
				scope.fileUploadClicked = function () {
					$timeout(function () {
						inputFileElement.click()
					})
				}
			},
			templateUrl: "/gtm/app/components/form/gtm-file-input.html"
		}
	}) /* ... */

As you can see, they use Angular and trigger the file input via JS.
That's way too much an complicated for somtehing like spectre.css.
I would just style it.

My Q&D attempt of trying to achieve something without js but with filepath:

    <input id="file-upload" type="file"/>

.fi {
    border: 1px solid #ccc;
    display: inline-block;
    padding: 6px 12px;
    cursor: pointer;
    width:50%;
}

input[type="file"] {
  position: absolute;
  cursor: pointer;
  left: -71px;
  top: 0;
}

.fi-c{
  position: relative;
  overflow: hidden;
  height:20px;
}

http://jsfiddle.net/uk2xhz06/

@artf Tested it in 5 Browsers (Chrome, FF, IE, Edge, Opera): Visible in each of them.
But a good start how to do it.


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit a0f35bd:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch 6da61886-d20b-453b-a392-51e4c411ddb4 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Analyzer Improvements

Store form analysis data in ->analysis-info map with keys matching the code-block id without redundancies
Simplify Graph nodes (each code block appears in the graph just once by its block-id)
Simplify hash of deps (only graph dependencies are used to compute the hash of a block)
Take var snapshots during eval
Handle var redefinitions

Fixes #454
Fixes #628
Fixes #66
Fixes #633
Fixes #634

Some edge cases still need to be addressed:

(def a 1)

(def a (inc a))

a

the analyzer/analyze  fails to return a as dependency of the (def a (inc a)). This is because we set-subtract all introduced vars from the deps:
https://github.com/nextjournal/clerk/blob/38a4653492bd47799f6dc5e6864e2b7eaf47a410/src/nextjournal/clerk/analyzer.clj#L187
Not doing that leads to other issues (e.g for multi-arity defns (defn f ([x] (f {} x)) ([x opts] ...)).
So when the first definition changes, this won't propagate to the value of a at the bottom. It's still an improvement wrt main, where the code above just crashes (#634).

Second case:
(def a 1)

(inc a)

(def a :boom)

Similarly, this also crashes on main (#634) but evals correctly a first time on this branch.
Subsequent clerk/show! fail when the consumer of the var a changes, since a is bound to a keyword, but (def a 1) didn't change. A similar behaviour to the "deref deps" might be applied here, but we need to decide when.

Of course I didn't thought of the example:
(def a 1)
(when false (def a 2))
(inc a)

so also the current handling of redefinitions in the graph won't work reliably, I'm tempted to not cache definitions with the same name at all and let people decide (throw on redefs, warn+not-cache, not-cache).

In this other branch I've disabled caching for redefined vars (and therefore for their dependants). We might mark in the UI the blocks that are not cached and in case of the redefinitions explain why.

Trying out passing info to code cells
https://github.com/nextjournal/clerk/assets/1078464/7f11c5db-3243-4681-bed5-1729a94e759a


MI - REFERENCE section (KAFKA Inbound)

Complete the reference content on [1].
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/inbound_endpoints/polling_inbound_endpoint/kafka-Inbound-Protocol.md

The original page is removed. Content is separated into 'Concepts'[1] and 'Properties'[2].
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/concepts/concepts.md
[2] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/synapse-properties/inbound-endpoint-properties.md

Done with the reference section [1].
[2] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/synapse-properties/inbound-endpoint-properties.md


BF-Audit-Finding #1: Vulnerable / Out-of-Date Dependencies

(Reported by the Bishop Fox audit). We use some old versions of dependencies that contain vulnerabilities. There's a gradle command that checks for these. Figure 1 from the audit report:
root@e9a8f1cedbe5:/mount/zcash-android-wallet-sdk# ./gradlew dependencyCheckAnalyze
...omitted for brevity...
> Task :dependencyCheckAnalyze
Verifying dependencies for project zcash-android-wallet-sdk
Checking for updates and analyzing dependencies for vulnerabilities
Generating report for project zcash-android-wallet-sdk
Found 7 vulnerabilities in project zcash-android-wallet-sdk
One or more dependencies were identified with known vulnerabilities in zcash-
android-wallet-sdk:
okhttp-2.5.0.jar<EMAIL_ADDRESS>cpe:2.3:a:squareup:okhttp:2.5.0:*:*:*:*:*:*:*) : CVE-2016-2402
guava-23.5-jre.jar<EMAIL_ADDRESS>cpe:2.3:a:google:guava:23.5:*:*:*:*:*:*:*) : CVE-2018-10237
kotlin-annotation-processing-gradle-1.3.21.jar
<EMAIL_ADDRESS>cpe:2.3:a:gradle:gradle:1.3.21:*:*:*:*:*:*:*,
cpe:2.3:a:processing:processing:1.3.21:*:*:*:*:*:*:*) : CVE-2018-1000840
gradle-api-3.5.0-alpha09.jar<EMAIL_ADDRESS>alpha09, cpe:2.3:a:gradle:gradle:3.5.0:*:*:*:*:*:*:*) : CVE-2019-11065
commons-compress-1.12.jar<EMAIL_ADDRESS>cpe:2.3:a:apache:commons-compress:1.12:*:*:*:*:*:*:*) : CVE-2018-11771, CVE-2018-
1324
intellij-core-26.5.0-alpha09.jar/META-INF/maven/com.google.protobuf/protobuf-
java/pom.xml<EMAIL_ADDRESS>: CVE-2015-5237
See the dependency-check report for more details.
BUILD SUCCESSFUL in 19s
1 actionable task: 1 executed
<-------------> 0% WAITING
> IDLE

This was fixed by Kevin, but are not doing this on a repeating basis.
Test should be added to the CI so that we are checking for if dependencies are out of date.

So in terms of reporting - if you can get CI to report an out of date issue to Taylor and I, we can analyze it for whether we need to update and how much effort the update is.

Split out the non-MVP part of this ticket: https://github.com/zcash/zcash-android-wallet-sdk/issues/50.


Fix benchmark compilation when missing v1 feature flag

Codecov Report

Merging #333 (f381810) into master (b4c737b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   80.43%   80.43%
=======================================
  Files          73       73
  Lines        9345     9345
=======================================
  Hits         7517     7517
  Misses       1828     1828

Impacted Files
Coverage Δ

benches/benches.rs
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c737b...f381810. Read the comment docs.


Slot names with german Umlauts

Hi,
I found that umlaute are not set properly (in this for slots but maybe also for other things like entities?)
WARNING:rasa_core.slots:Categorical slot 'slot1' is set to a value ('Ã¤pfel) that is not specified in the domain.
Rasa Core version: 10.4
Python version: 3.6
Content of domain file (if used & relevant):
Example:
obst:
    type: categorical
    values:
    - Äpfel
    - Birne

I don't have this as an entity if this might the issue?

Please fill out the template when creating an issue

Rasa Core version:
Python version:
Operating system (windows, osx, ...):
Issue:
Content of domain file (if used & relevant):

Sorry, I edited it

Can you check if this persists in 0.11?


Hunters workshop/metokens integration - WIP

@Seroxdesign I put this PR in draft mode for us 🙂

@Seroxdesign would you mind fetching and pulling the latest code changes, before we merge ☄

@Seroxdesign would you mind fetching and pulling the latest code changes, before we merge ☄

Got 1 more commit and then I will resolve the issues

@Seroxdesign would you mind fetching and pulling the latest code changes, before we merge ☄

done


[Snyk] Fix for 3 vulnerabilities

Snyk has created this PR to fix 3 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):

tests/integration/apps/python/requirements.txt

⚠ Warning
Flask 2.2.5 requires Werkzeug, which is not installed.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Remote Code Execution (RCE)

Will move to internal GH


Foundry auto caches the last 3 solc versions, however these are specifically identified by their version numbers (0.8.18,.19,20)

Fix: Add 0.8.21 as Foundry auto caches the last 3 solc versions, these are specifically identified by their version numbers (0.8.18,.19,20)
This version isnt added to that list (replacing .18)
Originally posted by @sambacha in https://github.com/foundry-rs/foundry/pull/5459#issuecomment-1649727739

not exactly sure what this means, can you elaborate?

not exactly sure what this means, can you elaborate?

Foundry will download solc 0.8.18, 0.8.19, and 0.8.20 in anticipation that they will be used so it reduces the overhead when the user executes their first build as it does not have to download those SOLC versions, it already has when it was first setup.

not exactly sure what this means, can you elaborate?

I am actually not sure if this effects normal user usage, but this is what I was referring to https://github.com/foundry-rs/foundry/pull/5504

closed with #5504


VarLibMergeError first parameter must be a Merger object

a lot of places instead pass in the 'self' parameter, incorrectly assuming that is a Merger.
This is meant to fix 'AttributeError: 'dict' object has no attribute 'ttfs'' as reported in https://github.com/googlefonts/fontmake/issues/766#issuecomment-836576341
there's still some places where I'm not sure what the right thing to do is

ping @simoncozens


Close button does not work on "Backup Multisig wallet" modal

This modal is not possible to close. I'm on Sparrow 1.9.1, macOS

Thanks for the bug report, fixed in fb679c01.


Routing_Request Points from Dreamview

if I understand correctly, the routing_request should at least has two points: the start_point, the end_point.
Test1:
if I select a point and click the Send Routing Request in the dreamview,  the following is the topic of /apollo/routing_request:
waypoint1: start_point
waypoint2: end_point

Question 1:
I think waypoint2 is the point that I selected in Dreamview.
But how did the apollo system get the waypoint1?    the waypoint1 should be the vehicle's localization pose?
so where is the source code of getting the vehicle's localization pose to be the waypoint1?  I can't find it in the dreamview/backend, maybe it's in the frontend?

Test2:
Then After the vehicle arrived, I selected another point in the dreamview:  sequence_number = 2

Question2:
In my opinion, I think the waypoint1 of sequence_number2 should equal to the waypoint2 of  sequence_number1?
the start_point of sequence_number2 should queal to the end_point of sequence_number1.
but why actually it's not?

I think waypoint2 is the point that I selected in Dreamview.
But how did the apollo system get the waypoint1? the waypoint1 should be the vehicle's localization pose?

yes, if you only select 1 point, then the starting point is the position of the car, and the ending point is the selected point


replace old doc of log_prob logic with new doc

fix doc string

Thanks, @kilian1103! This is a good spot. Feel free to merge.

@kilian1103 Don't worry about the tests failing at the moment. This is an unrelated issue detailed in #12 that I need to address. Feel free to merge.


Added coverage upload to Codecov (#4)

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[SAC-108][KAFKA] Remove KafkaHarvester.CONFIG_CUSTOM_CLUSTER_NAME

What changes were proposed in this pull request?
We already have CLUSTER_NAME in AtlasClientConf. This PR removes the duplicated new configuration KafkaHarvester.CONFIG_CUSTOM_CLUSTER_NAME and use the existing one instead. This will reduce future confusion.
How was this patch tested?
Pass the Travis CI.
This closes #108

I'll merge this since it passed locally, @HeartSaVioR . I'll not retrigger this one to keep the record for #105 .


Fix DownloadCertificate test failures

DownloadECDsaCertificateSignLocalVerifyRemote started failing on linux because of #20204 and we found some related ordering issues in tests when run locally.

/azp run net - keyvault - tests

/azp run net - keyvault - tests

The HSM test failure is unrelated, and being dealt with in PR #20206 so I'm going to merge this one since it resolved the more immediate error.

/check-enforcer override


Fix HIP-Clang GPU build issues

This is the same as #362 , just moved the fork branch to here.
Add missing device attributes for GPU functions. GPU functions must be annotated with device in HIP. Also, fix a few warning: nvcc does not allow 'device' to appear after '()' in lambdas.
Here are the test results, I will file bugs for the failures:
99% tests passed, 2 tests failed out of 182
Total Test time (real) = 26.47 sec

Rebased on develop

@aaronenyeshi do you have an understanding on the build failures? Is there a plan to address?


removes branch alias and updates composer

@tmatsuo ptal

LGTM, Why did we need the branch alias?

@tmatsuo I accidentally copied it over from the symfony-standard repo


Handling gRPC exceptions by gRPC Labview

Since gRPC-exceptions are the recommended way of handling errors in gRPC, I'd like to use that rather than adding a status field to every response message.
Generated exceptions from server (e.g. C# implementation) can be handled by Labview client. But what about the other way around? How to send exceptions from Labview Server to clients.
AB#2778642

It is up to each gRPC language plugin to handle errors in a style that makes the most sense for that language. An error in this case is an RPC where the response status code is anything other than OK. For a LabVIEW client, that means the status code and details string from the response will get converted to an error cluster. For a C# client, that means a RpcException will get thrown. If you are adding your own error fields to the messages defined in the .proto file, then you are effectively bypassing the built in error reporting of gRPC.
If this is what you are doing, then in general I would say don't do that. If you are doing that because you find the built in error reporting somewhat limited, that's a valid criticism. In fact that's what has led to a "richer error model" that has been adopted as an ad hoc convention by many languages. However, grpc-labview doesn't currently provide any libraries/APIs that makes adopting a rich error model easy. See here for more information about these concepts.


Do not update zef when upgrading perl6

The patch seems to have disappeared from github, so I applied the changes manually. Cheers!


Idea: Disable hurt texture

In the /content/textures/ui/TopBar folder, i found this texture:

Im pretty sure this is the texture thats red when you take damage in a game. If, for some reason, this texture annoys somebody, there could be an option in the Bloxstrap mod menu to disable it. Thanks in advance!

did you read the help documentation on making custom mods

Guess you could do it like that.


(Bonfire: Diff Two Arrays) Test inconsistencies / missing exercise constraint

Hi guys,
I managed to complete the challenge, but believe that there are inconsistencies in the expected test results / exercise constraints

["andesite", "grass", "dirt", "pink wool", "dead shrub"], ["diorite", "andesite", "grass", "dirt", "dead shrub"] should return ["diorite", "pink wool"] is inconsistent with [], ["snuffleupagus", "cookie monster", "elmo"] should return ["snuffleupagus", "cookie monster", "elmo"]
[1, "calf", 3, "piglet"], [7, "filly"] should return [1, "calf", 3, "piglet", 7, "filly"] is true only if there is no sorting
The exercise description does not require that the results be sorted alphabetically.

My code does not do any alphabetical sorting.  It considers each array in turn, and discards any element that appears in both arrays.
That my code was accepted suggests that
a. The submission tests are wonky, or
b. The tests don't expect alphabetical sorting, and that the current wording may confuse others.
Proposals
a. Require that the results be sorted alphabetically (add exercise constraint, update descriptions of test outcomes), or
b. Change the expected test results for ["andesite", "grass", "dirt", "pink wool", "dead shrub"], ["diorite", "andesite", "grass", "dirt", "dead shrub"] so that it is ["pink wool", "diorite"] (no sorting expected)
Related Issue
I saw that caeldom raised a related issue: https://github.com/FreeCodeCamp/FreeCodeCamp/issues/4133
I tried caeldom's solution, and it give the results:

["pink wool"]
["diorite", "pink wool"]
[]
[4]
[4, "piglet"]
["cookie monster", "elmo", "snuffleupagus"]
[1, 3, 7, "calf", "filly", "piglet"]

I really like that caeldom's solution is more concise than my code, but the outcomes are inconsistent with the listed test results.
If sorting is not expected (and actually considered a bug), then the arr.filter logic will not work.
If sorting is required:

Result 5 is inconsistent with [1, "calf", 3, "piglet"], [1, "calf", 3, 4] should return ["piglet", 4].
Result 7 is inconsistent with [1, "calf", 3, "piglet"], [7, "filly"] should return [1, "calf", 3, "piglet", 7, "filly"].

I'm not sure I understand the problem? The wording of the challenge doesn't enforce order and the tests don't either.

Yes, that's my experience too.  However, the challenge states that ["andesite", "grass", "dirt", "pink wool", "dead shrub"], ["diorite", "andesite", "grass", "dirt", "dead shrub"] should return ["diorite", "pink wool"].  Without sorting, the return value will be ["diorite", "pink wool"].
I was further confused by the response to #4133 (though that doesn't seem to be the production behavior).
The change is probably as small as updating the expected results stated in the challenge.

#4133 was fixed :smile: . I don't think updating the order is a solution because the output order is algorithm dependent. The reason the tests ended up ordered like they are is that the algorithm most people end up using outputs them in the order displayed. The items have to be in some order, and there's always a chance that won't match the output of the user's function.
However, if someone wants to put in a PR that adds text like "The order of items in the output array does not matter." or something to that effect I don't see a problem with it.

I understand where you're coming from w.r.t offering flexibility.  The output is either sorted or unsorted (but not both?) depending on the approach we use.
I'm just suggesting that the test results in the challenge description (below the output box on the left) may be confusing since they suggest both sorted and unsorted behaviors happening with the same program:
["andesite", "grass", "dirt", "pink wool", "dead shrub"], ["diorite", "andesite", "grass", "dirt", "dead shrub"] should return ["diorite", "pink wool"]

AND
[], ["snuffleupagus", "cookie monster", "elmo"] should return ["snuffleupagus", "cookie monster", "elmo"]

I have the impression that the results should either be

unsorted (what I got from my code, and what was accepted), OR

["pink wool", "diorite"]
["snuffleupagus", "cookie monster", "elmo"]

sorted (what caeldom got with #4133)

["diorite", "pink wool"]
["cookie monster", "elmo", "snuffleupagus"]

Has someone submitted code that mixes the behaviors?  I'm curious to see if there's some algorithm that may result in another outcome.
This is a small thing anyway.  I'm just bringing it up because I look at the expected test outcomes before I code, so there was some logical inconsistency during design time.
Thanks for the nice work on the site!


Add a Process.toUtf8 and Process.toUtf8_

Or we can decide on a better API.

Process.toUtf8: Run the command and return all the lines
Process.toUtf8_: Run the command and return the last line only

If it is lines then it should be toLines. If we want chars then it could be toChars. These are easily representable by idioms. We should keep the APIs experimental to begin with. I am not sure if we should have these as we can just plug a Unicode.lines function in the stream to achieve this. If this is common in shell programming we can possibly have a convenience function in streamly-shell.
For last line we can just use Stream.last or we can have something like Stream.takeLast as well to n elements from end.

We have toLines now.


Added -AsJob description to Get-CsOnlineUser.md

https://github.com/MicrosoftDocs/office-docs-powershell/issues/5717

Docs Build status updates of commit 664e01b:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 664e01b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@dariomws, just FYI, AsJob is a common Windows PowerShell parameter that's available in remote PowerShell connections (similar to ErrorAction, ErrorVariable, etc.). platyPS was updated to not include that parameter (notice that it's not present in any Exchange-related cmdlets). I would consider a global search/replace effort to remove AsJob wherever you find it.

@chrisda I'm going do it starting now.

@chrisda done, new PR:
https://github.com/MicrosoftDocs/office-docs-powershell/pull/5760
Maybe we should add some information about -Asjob here:
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (https://go.microsoft.com/fwlink/?LinkID=113216).
with these articles:
about_Jobs
about_Remote_Jobs

@dariomws, I wouldn't mess with that Common Parameters boilerplate, unless you're prepared to add the modified text to all future new cmdlets.

Ok, understood. This text is added automatically by PlatyPS I think. Thanks!
Anyway, as you know, I'm available to help you with everything you need.

Docs Build status updates of commit 664e01b:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 664e01b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

[Error-GetDocumentsFromDHSFailed] Getting documents from document hosting service failed with locale: en-us, depot name: MSDN.officewebapps-ps, branch name: pr-en-us-5752. Error: A task was canceled.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Hi Chris,
I missed this. Do you want that I do a global search/replace to remove
AsJob?
Thanks,
Dario
On Fri, May 29, 2020 at 7:18 PM Chris Davis<EMAIL_ADDRESS>wrote:

@dariomws https://github.com/dariomws, I wouldn't mess with that Common
Parameters boilerplate, unless you're prepared to add the modified text to
all future new cmdlets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/office-docs-powershell/pull/5752#issuecomment-636217645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIAIP5W7ZK7IOLAOH5AKFKTRUAYDTANCNFSM4NOICKUA
.

Docs Build status updates of commit 664e01b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\huhu-s, target branch: master, target branch commit: 5ac9867f1dce3d249022042abfd11dff56d16121, source commit: 664e01bd3adbe9679c6423ea8c6d3b2aa9383c3d.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


podman push without destination image

the destination image for podman push should be optional (if the destination
has already been tagged in).  the man page for podman push describes that it
should work this way.
Resolves: #645
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

I think the error message should be reworded, otherwise LGTM

Error message has been reworked, merging
@rh-atomic-bot r+

Looks like registry pull errors against the Fedora registry

@rh-atomic-bot retry

@rh-atomic-bot retry

bot, retest this please


gegl: Put aarch64-linux in badPlatforms

Closes #127347
Motivation for this change
It's broken, but since it's just the old version of gegl it's not worth fixing.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Shouldn't we just drop the old gegl and default to the new gegl 0.4 ?

Shouldn't we just drop the old gegl and default to the new gegl 0.4 ?
I created a draft PR here: https://github.com/NixOS/nixpkgs/pull/129124

Closing in favor of https://github.com/NixOS/nixpkgs/pull/129124


How to deal with proxy

@liamcottle
Do you have any suggestion of proxy server to use in a production enviroment?
I'm developing a comment tracking system but i dont know what to do next.
And do i need on proxy address/port for each user?
I'm kind of lost on that.

Hi @GitDov,
Unfortunately I don't have any recommendations on which proxy service provider to use.
I provide all the methods to interact with Instagram, your tracking system implementation is for you to decide on 😄
Cheers.


issues with connectivity

Ever since MacOS Ventura was released the Open MTP app has been virtually unusable and has made my life really tough.

Hi @Al2832, no one will be able to help you with a vague comment like that.  Please elaborate on the issues you've started to experience since upgrading to macOS Ventura.

This issue is being actively investigated.

could you follow this link? https://github.com/ganeshrvel/openmtp/issues/276

Yeah quitting preview did the trick, thanks a lot!


Problem: when transaction.to == null it's a contract creation

Part of #122.

originates from https://github.com/ethereumproject/sputnikvm/pull/142


[clkmgr] Allow software to control clock stepdown

Fixes #8027

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

This PR needs an associated documentation update.

Thanks Tim. LGTM.

I need to update the clkmgr testplan for this, the frequency counters, and moving more stuff to SVA
LGTM

let me know if you want me to file an issue.


Fix for #1319: Selected service gets highlighted correctly

Description
Fixing the highlighted service in Quick Switcher
Motivation and Context
Using the quick switcher, the list of services that had been navigated without / before the QS was intuitivily ordered by last-used. But, the highlighted service became out of sync if the Cmd+ shortcut was used bypassing the QS. This has now been fixed to be consistent always.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

Merged locally and seems to be working fine. However, are these scrollbars intentional?

@kytwb - I dont see any scrollbars on my macos. It must be something else. As you can notice, the changes that I have made are very trivial.

Keeps working fine even after merging alongside #1326. I think this is safe to merge.
(Well, the scrollbars are still weird, but that's a Linux issue that I'll have to fix and is unrelated to this patch.)

LGTM, thanks!


I do not have permission to do /pex

I cant do /pex
I am op
It saids: sorry, you do not have enough permissions
Please help!

Which version of Minecraft and PEX are you attempting to use?
Are there error messages in the startup log? (Copy the startup log to Pastebin and leave the link here.)
Show me your permissions.yml file.  (Copy it to Pastebin, leave the link here.)

I found out why!
But thank you

What was the solution?

It was in the config you have to allow op commands.

¯_(ツ)_/¯


compare with c12/rc9?

Clear and concise description of the problem
Wanted to understand author's vision for this library and how it compares to rc9/c12. All three libraries are related so it will be useful to understand the scope for each of them
Suggested solution
This is just a question, but hopefully will be good to include the answer in the readme.
Alternative
No response
Additional context
Thank you for great effort
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Just use c12 I would say. unconfig was a try to be able to load plugin configs fields from framework configs like vite.config.js nuxt.config.js, but in the end it didn't work well and it would be still more efficient and reliable to have a dedicated config file.


Wrong Result For jDay

I use this Library for my jalali datePicker form field but when i update this library from v3.3.3 to v3.3.8 i found this bug:
Describe the bug
when I try to get a last day of the month with this below code i get NaN:
const LastDayIndex = jMoment( '1399-4-31').locale('fa').jDay(); // NaN

// OR

const LastDayIndex = jMoment( '1399-4-' + jMoment.jDaysInMonth(1399, 4).toString() ).locale('fa').jDay(); // NaN

and I realize after update library the result of jDay() has one unit Increase. why?

please create a demo
https://stackblitz.com/edit/jalali-moment-demo-react-ed5qpt?file=index.js
jday works well
jMoment( '1399-4-31') doesn't work because we updated the moment.js and it doesn't support this kind of input anymore.
so please use the following syntax instead
jmoment.from("1399-4-14", 'fa', 'YYYY-MM-DD')


Add overall sql execution event

There are limitation to use sql executor event to enhance sjdbc. You can get every single sql execution event but cannot get overall execution event. This is not compatible with the monitoring system.
So sjdbc should add overall sql execution event.

fixed at 2.0.0.M2


Added support for z8 files

Added support for z8 files. Will probably add zblorb if David pushes out a new release. Just wanted some more options. Also clarified the readme with a couple minor things.
Thanks a ton for your work, I wish it was in python but i guess nodejs is ok :-). I used it to create a voice interface to them with a small demo here https://www.youtube.com/watch?v=5RX4Dm9TmCY. Not quite ready for prime time since i hacked it together in a couple hours last night but you guys work made that quick turnaround possible., so thanks again.

Awesome, thanks! And yeah, sorry it's a node project. If I were going to rebuild, it'd probably be in go or python at this point.


Add Sky Drop tests and pending Sky Drop glitch tests (for Gen 5)

@Marty-D can you verify the mechanics of how Pokemon can be freed from the Sky Drop glitch are indeed the ones that I mentioned? What happens when Power Herb is used with two-turn moves, or maybe if the two-turn move misses or is blocked by Protect?

Everything you have so far is accurate, nicely done! The completion of the second turn of any two-turn move is what frees the original target, which includes Power Herb, missing, and being blocked. Only if the second turn is actually prevented from executing due to confusion or paralysis or whatever does the target stay immobile.
Something else I forgot to mention before is that the user of Sky Drop also cannot be forced to switch out while the immobilizing effect is still active (a Red Card is still consumed as normal).

This Suction Cups effect you speak of is probably in the effect of Sky Drop to begin with, to prevent the user from being forced out via Lock On + Roar or the like. Can you check that behavior for Sky Drop in Gen 6?

Yeah, it is part of Sky Drop's effect; I was just comparing it to other stuff. Still works the same way in Gen 6.

Speaking of Sky Drop preventing Pokemon from being dragged out, that implementation was actually slightly off (the target wasn't prevented from being forced out).
Also, this makes me curious. I know that when you try to switch when your Pokemon is being held by an opposing Sky Drop, it will display "__ won't let __ go!" but does any message along those lines display when Sky Drop prevents dragging?

Roar/Whirlwind show "But it failed!" as expected, but other than that there are no messages. In fact, the "Sky Drop won't let POKEMON go!" message is never actually shown in the battle text, only to the player trying to click anything besides something in the Fight command.

Yeah I was just checking. The Sky Drop tests should be comprehensive now, but the Sky Drop glitch tests might have some holes.

@Marty-D can you double check that everything is good before it gets merged?

Looks good to me! :+1:
The only thing I noticed after skimming through it again is that Infiltrator Sky Drop should probably not fail against a substitute, but I can't test that in-game by myself. Testing No Guard Skill Swap on it during the second turn would also be a neat thing to check. That's a minor thing though; there's no need to wait for that to be tested before merging this.


Config resourcemanager

Description
Sessions' SQLConfigs are now HazelcastSQLConf instances and thus it is possible to share each session configuration among the cluster members.
Testing

[x] Unit

:+1:

:+1:


Slayer plugin has wrong icon for Fire Giant Task

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
The slayer task plugin info box for fire giants displays an icon of a fire battlestaff.
Expected behavior
To have an icon that better represents the monster. EX: Hellhounds have a hellhound icon.
Screenshots

Fire Giant Icon

Hellhounds Icon

Environment (please complete the following information):

OS: [e.g. Windows, Ubuntu, macOS]
RuneLite version: 1.5.23
Launcher version: 1.6.0

Duplicate of #1562


As an iOS developer, I can encode a model into a dictionary

What happened

Add dictionary to Encodable extension

Insight

In current request, we have to create a dictionary to map one by one in parameters like example below:

var requestParameters: [String: Any] = [
    "first_name": parameters.firstName,
    "last_name": parameters.lastName,
    "nationality_id": parameters.nationality,
    "date_of_birth": parameters.dateOfBirth,
    "mobile": parameters.mobile,
    "mobile_country": parameters.mobileCountryCode,
    "otp_request_id": parameters.oTPRequestId,
    "marketing_consent": parameters.hasGivenMarketingConsent,
    "tc": parameters.hasGivenTermsAndConditionConsent,
    "consentFlag": parameters.hasGivenMarketingConsent,
    "consentVersion": parameters.consentVersion,
    "pin": parameters.pinCode
]
RequestConfiguration(
    method: .post,
    url: url(forEndpoint: "accounts"),
    parameters: requestParameters
)

Proof Of Work
If we use swift's codable, we can encode a model into a dictionary quickly
RequestConfiguration(
    method: .post,
    url: url(forEndpoint: accounts),
    parameters: model.dictionary
)

What do think about adding JSONEncoder as a parameter so that we can have different rules like keyEncodingStrategy.

@blyscuit Could you please explain more a bit? 🙏  I don't get your idea 😅

What do think about adding JSONEncoder as a parameter so that we can have different rules like keyEncodingStrategy.

@blyscuit Could you please explain more a bit? 🙏 I don't get your idea 😅

What I have is something along the line of
let encoder = JSONEncoder()
encoder.keyEncodingStrategy = .convertToSnakeCase
obj. toDictionary(encoder)

func toDictionary(_ encoder: JSONEncoder = JSONEncoder()) -> [String: Any] {
        guard let data = try? encoder.encode(self),
        let object = try? JSONSerialization.jsonObject(with: data),
        let json = object as? [String: Any]
        else { return [:] }
        return json
    }

where we can specify special encoder we want? but this change your approach by using func instead of var

What I have is something along the line of
let encoder = JSONEncoder()
encoder.keyEncodingStrategy = .convertToSnakeCase
obj. toDictionary(encoder)

func toDictionary(_ encoder: JSONEncoder = JSONEncoder()) -> [String: Any] {
        guard let data = try? encoder.encode(self),
        let object = try? JSONSerialization.jsonObject(with: data),
        let json = object as? [String: Any]
        else { return [:] }
        return json
    }

where we can specify special encoder we want? but this change your approach by using func instead of var

Cool, it looks great. One small thing that can we throw an error instead of empty list? What do you think?
func toDictionary(_ encoder: JSONEncoder = JSONEncoder()) throws -> [String: Any] {
        guard let dictionary = try JSONSerialization.jsonObject(
                with: encoder.encode(self), options: .allowFragments
        ) as? [String: Any] else {
          throw NSError()
        }
        return dictionary
}


How do I get the StyleID of cell, row and column?

In this way, I can set the same style for the new cells, rows and columns as the specified cells, rows and columns.

well, right now it's not possible. Idea was to create library for humans, not robots. So  id of style was not supposing to use directly. i started to add more features some time ago, but it still not finished, but it will be possible to use existing styles.

Thank you for your work. I will keep watching this project.

I will try finish columns issue today

I pushed recent changes that include styles, but that branch is not release ready yet. Its stable (all tests works as before), but some planned features are not added yet, but if it's critical for you, then you can try:
Here is branch:
https://github.com/plandem/xlsx/tree/feature/hyperlink

The Formatting method is what I need. Thank you!

That branch was created for hyperlink feature, but during implementation I had to add other features, e.g. full support of merged cells, so don't be fooled with name of branch, it's more like develop right now :) Hope I will have time to finish hyperlink helper type - the only thing that not finished to release it.


documentation for shape args of expect seems inconsistent

Although the shape argument of the base class expect function is correctly documented as the tuple called args, the call signature of the distribution-specific expect member functions are less clearly documented.
For the gamma distribution it's a bit misleading that a is a shape parameter in mean but a length-1 tuple of shape parameters in expect
mean(a, loc=0, scale=1)
expect(func, a, loc=0, scale=1, lb=None, ub=None, conditional=False, **kwds)

and for the gausshyper distribution the documented call signature of expect is just incompatible with the actual call signature.
mean(a, b, c, z, loc=0, scale=1)
expect(func, a, b, c, z, loc=0, scale=1, lb=None, ub=None, conditional=False, **kwds)

Documented more clearly in gh-5153. Cannot be changed in a backwards-compatible way, so closing.


filter fields and meta

closes #189 subset of fields and closes #197 filtering covidcast meta
new parameter: fields allowing to specify a subset of the fields to be returned. This is mostly for the website to limit the transferred data

Rebase this against main, if you would? There's a schema update that needs to get propagated into integrations/.../test_covidcast.py:test_fields:
Warning: repos.delphi.delphi-epidata.integrations.server.test_covidcast missing attribute __test_target__. Coverage will not be tracked.
test_fields (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Test to limit fields field ... ERROR
test_location_timeline (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Select a timeline for a particular location. ... ok
test_location_wildcard (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Select all locations with a wildcard query. ... ok
test_nullable_columns (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Missing values should be surfaced as null. ... ok
test_round_trip (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Make a simple round-trip with some sample data. ... ok
test_temporal_partitioning (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Request a signal that's available at multiple temporal resolutions. ... ok
test_unique_key_constraint (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Don't allow a row with a key collision to be inserted. ... ok

======================================================================
ERROR: test_fields (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Test to limit fields field
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/src/app/repos/delphi/delphi-epidata/integrations/server/test_covidcast.py", line 85, in test_fields
    self.cur.execute('''
  File "/usr/local/lib/python3.8/site-packages/mysql/connector/cursor.py", line 551, in execute
    self._handle_result(self._connection.cmd_query(stmt))
  File "/usr/local/lib/python3.8/site-packages/mysql/connector/connection.py", line 490, in cmd_query
    result = self._handle_result(self._send_cmd(ServerCmd.QUERY, query))
  File "/usr/local/lib/python3.8/site-packages/mysql/connector/connection.py", line 395, in _handle_result
    raise errors.get_exception(packet)
mysql.connector.errors.DataError: 1136 (21S01): Column count doesn't match value count at row 1

----------------------------------------------------------------------
Ran 7 tests in 0.201s

FAILED (errors=1)

main merged and CI is successful again https://github.com/sgratzl/delphi-epidata/runs/1080393029?check_suite_focus=true


Athena Variable Query Editor

Athena currently only supports a simple query editor which also makes use of the datasources default connection details. The Cloudwatch datasource supports selecting a query type allowing for properties such as Region, Namespace etc. to be pulled from the backend. A similar editor should be implemented for Athena. The query editor should also be updated to allow for Region, Catalog, Database to be set rather than using default values.

We've decided not to work on this one for now.


Mob Location updates

I was going to add you on discord but thought id post here and update it if any more needed changing.
In Thavnair
Akyaali Crab | (x13,y27.4)
Vajralangula | (x13.8,y18.5 )
Pisaca | (x21.4,y19.3)
These mobs, the bot would fly around the wrong location, crab and vaj specificly would just fly around the elephants(gaja).
Ive added the correct coordinates if those could be changed.
Hope youre still updating this, I love it!

remembered I can edited the code myself xD


jsonld.js - new version fails to load remote context

This issue is to keep track of progress in digitalbazaar/jsonld.js/issues/451
jsonld.js with version 5.0.0 moved away from request library. Unfortunately with this version the documentLoader: jsonld.documentLoaders.node() fails to load remote context.
If this won't be fixed and the upgrade would be needed for other reasons then possibility is to create custom documentLoader.

Fixed in #55 (699f079)


2.4.0 gem yanked

Version 2.4.0 is the latest gem in the changelog, but is no longer available for download due to a yank from rubygems.
Why was this version yanked? Any chance this could be explained with a note about what's new in 2.4.1 in the changelog?

@bpo there was an error in the gemspec which was causing people's builds to fail with certain Gemfile configurations.  See issue #110
A bundle update should be all you need to do.

For future incidents, could you please not yank versions that have been released for a month?
The yank broke diaspora out of the blue, and potentially a lot of other projects, and 2.4.0 was working just fine in our case (and looking at #110, it was probably fine for most people).

@denschub In hindsight, I wouldn't do that again in this particular case when most people weren't having an issue with it.

❤


Add transformers, include GitHub and YouTube transformers

I wanted to make it cleaner to add transformations for the /proxy endpoint used when we use the /import slash command.
This adds two types of transformers:

UrlTransformer: used to take a URL and rewrite it before we do the fetch()
ResponseTransformer: used to update a fetched Response before we return it

I've converted the various GitHub URL rewrites to use UrlTransformer, and also added one for working with PRs, like I showed in class the other day.
I included the stuff to transform Responses before we return them, but I'm not using it yet.  It would be useful it you wanted to turn something with a particular Content-Type into some other format, or parse the body and generate some different content, etc.
I've included tests to show that these all work.

Not sure why that test fails in CI, it passes locally.  Maybe the node version?  Seems odd.

Turns out it shouldn't have been passing locally!  Fixed.

Here is a sample chat that uses it, showing this PR being /import'ed, and the patch being returned.

Fixes #360.
I've updated the transformer API so that it's possible to:

rewrite the URL
rewrite the Response
ignore the Response and use a different logic for fetching the data

In order to demonstrate a number of examples, I've done GitHub URL rewrites and YouTube captioning.  You can try using /import with GitHub files, Gists, or PRs.
You can try YouTube videos, too. Here's an example of using /import with a YouTube video.
I ran into a few bugs doing this.  One in https://github.com/algolia/youtube-captions-scraper/pull/25 (can't use axios in CloudFlare workers), which I've hacked around by re-implementing the code in our tree temporarily.  The other relates to & in URLs being rewritten in our Markdown render to &, which I'll file separately.
Another thing I'm not sure how to handle is the case where a video doesn't have any subtitles. Currently we'll return an error, but there is likely a better UX.

There's also an extra 3 backticks at the end of the data, which I don't understand:

It might be getting added in the browser, not sure.
I also realize that in a follow-up, we could transform the GitHub stuff so it properly syntax highlights the files (e.g., return Markdown with fenced code blocks vs. text).

Filed #373 on the & vs. & issue.

Note, rendering these in any fancy way will eat tokens for breakfast thus process slower and more expensively. I would even strip timestamps and llms do without those.

Note, rendering these in any fancy way will eat tokens for breakfast thus process slower and more expensively. I would even strip timestamps and llms do without those.

Good point.  I've altered it to return only text, and sentences are separated by newlines.
Example: https://b957613a.console-overthinker-dev.pages.dev/c/chatcraft_dev/RlW21J19uxWlP5CdXYEPt

@humphd I think the 3 backticks at the end comes from file src/lib/commands/ImportCommand.ts
    const text =
      `${command}\n\n` +
      // If it's already markdown, dump it into the message as is;
      // otherwise, wrap it in a code block with appropriate type
      (type === "markdown" ? `${content}` : `\`\`\`${type}\n${content}`) +
      `\n\`\`\``;

Possible fix:
      (type === "markdown" ? `${content}` : `\`\`\`${type}\n${content}\n\`\`\``);

Fixed the trailing backticks, thanks @mingming-ma
Added support for transforming GitHub responses to syntax highlight diffs and blobs (e.g., files)

To test this you can /import a PR URL or a GitHub file.
I'll probably stop extending this now, since I have examples of how to use everything, which others could copy.

Is there a way to test this before landing on main? Can we call these rewriters(or something)? It's gonna make someone have a bad day if they confuse these with huggingface transformers.

lgtm on the code other than name

Got it to work.
import https://github.com/tarasglek/chatcraft.org/pull/370#issuecomment-1915383498

Does not work...

i think for pull reqs it should not do the patch translation unless one points it at git diff view.. eg we might wanna mine pull comments

Fixed so it won't do PR comments (I'll file a follow-up to add that), removed my youtube-captions-scraper in favour of upstream fix https://github.com/algolia/youtube-captions-scraper/pull/25, did some cleanup, rebased.
@tarasglek RE: name, what should I call these instead of "Transofmer"? "Rewriter", "Handler", "Processor", "Mutator" ??

Markdown renderer is the true name for what it does. Simplifier or Rewriter is fine too

Renamed transformers to rewriters.  MarkdownRenderer is true only if we operate on the response, which we don't always.
I think I'll land this and we can continue in subsequent PRs.


Fix anchor link in TOC

#__init__ -> #init__

By using Pandoc's TOC feature, it is no need to fix this problem.


Issue with dollar sign

Hi,
I have a problem when making searches that include the dollar sign character, the exception I get is the following:
ThinkingSphinx::SphinxError: index inquiry_core,room_core,user_core: syntax error, unexpected '$' near '$'
[GEM_ROOT]/bundler/gems/thinking-sphinx-6259635e2692/lib/thinking_sphinx/search.rb:406:in `block in populate'
[GEM_ROOT]/bundler/gems/thinking-sphinx-6259635e2692/lib/thinking_sphinx/search.rb:551:in `call'
[GEM_ROOT]/bundler/gems/thinking-sphinx-6259635e2692/lib/thinking_sphinx/search.rb:551:in `retry_on_stale_index'
[GEM_ROOT]/bundler/gems/thinking-sphinx-6259635e2692/lib/thinking_sphinx/search.rb:394:in `populate'
[GEM_ROOT]/bundler/gems/thinking-sphinx-6259635e2692/lib/thinking_sphinx/search.rb:176:in `method_missing'
app/views/admin/searches/create.html.erb:4:in `_app_views_admin_searches_create_html_erb__932742353_105545480__302590324'

Any clue what the reason could be?

Please update the url it's now on
https://github.com/pat/thinking-sphinx/issues/235


Create kkk

Collaborator cannot find remote user mapping for pull request creator, review created by system administrator

Collaborator: Review for this pull request was created. Link to review

cancelled


Refactor/prepare for dynamic json

Description
As a preparation for DynamicJsonDocuments required for Growatt TL-XH support
remove the unnecessary ShineJsonDocument typedef and use the abstract JsonDocument type.
While at it avoid duplication of Hostname and MacAdress Strings by marking them as const String&.
StaticJsonDocuments greater than 2048 will result in unexpected behaviour as the stack
of the ESP is only 4096 bytes. In fact the ArduinoJson documentation recommends a
maximum StaticJsonDocument size of 1024 [1]. To avoid any side effects of changing
to DynamicJsonDocument leave StaticJsonDocument for up to 2048 bytes for now.
How Has This Been Tested?

[ ] Not applicable

Inverter type

[ ] Simulated inverter
[X] Growatt 3000 TL-X

Stick type

[ ] Shine X
[ ] Shine S
[ ] Lolin32
[ ] Nodemcu32

The intention was to not change it for the current modbus versions to not break anything. I use DynamicJsonDocument for weeks now with 4K size without any trouble. In fact in ArduinoJson 7 there is no static version anymire. I can modifiy this PR to just switch to DynamicJsonDocument.

Last time I tried DynamicJsonDocument I had heap fragmentation issues (?). But I am willing to try again. AFAIR I was quite unstable when turning on tls on an esp32.

I understand you had a good reason to use StaticJsonDocument. Maybe the approach to stick with StaticJsonDocument and use DynamicJsonDocument only for the TL-XH inverters is not that bad. At least until we have more evidence that the Dynamic version does not cause any issues. In my setup MaxHeep is stable at not decreasing, but its an ESP8266 without TLS.

@crasu I googled a bit and only find DynamicJsonDocument causing heap fragmentation when it still was allowed to grow dynamically. Do you remember and what time this happened?

I have this running now more or less stable for a couple of days. Seems to be running fine. However I am unable to monitor the heap memory stats as I do not have prometheus setup in my homenetwork.

I can also add the metrics to Inverter:createJson, but this would require more space ;-). I can send a new PR which changes to DynamicJsonDoc unconditionally and add a patch that adds the monitoring also to the Json output.

@crasu this is the show stopper for the TL-XH patch. If you are okay with it I can send a PR with DynamicJson + Heap Stats in Json + TL-XH support. Please note that I will leave for holidays on Monday. Otherwise this has to wait until end of July.

If you are okay with it I can send a PR with DynamicJson + Heap Stats in Json + TL-XH support.
Make it so
Please note that I will leave for holidays on Monday. Otherwise this has to wait until end of July.

Have a nice holiday

@crasu Thank you. I will try to prepare the PR before I leave. I will close this PR in favor of the new one.


NameError: name 'pyodbc' is not defined

I get this error on startup!

We currently have pyodbc as part of requirement.
Could you try pip install pyodbc
And let me know if import pyodbc works
I will also push another patch that removes the pyodbc requirement.

Also, try create_cocoon_workflow(con)
We need database as input, not a pandas df

Works now! as i had to do apt install unixodbc


[Bug] Overlapping of Get Components Button with other sections

Description
There is overlapping of get components button between Accordions and Background div.
Please assign me this issue under IWOC2024
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Hello @Dhairya1Gupta can u assign me under iwoc24?

Approach: I have been checking code,by changing the alignments it could be working ... it's like brute force

It is not overlapping. Work on other issues @Dhairya1Gupta


K8SSAND-1358 ⁃ Allow performing restores without having a running cluster

Cassandra data should be restore-able on the initial cluster startup.
The K8ssandraCluster object would need to be augmented with settings that indicate which backup should be restored on the first start:
    datacenters:
      - metadata:
          name: dc1
        k8sContext: dev
        size: 3
        restoreFrom:
          prefix: cluster-1
          backupName: medusa_20220315

Connection settings would still be set up in the Medusa section of the manifest, as Medusa's containers will rely on it.
The prefix will be customizable for the restore operation though, which will be carried out in #453.
This work will also leverage what will be done in #486.
┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1358
┆priority: Medium

Hey team! Please add your planning poker estimate with ZenHub @adejanovski @adutra

@jsanda @burmanm, we may want to have a quick design session before moving on with this. I feel like we're not totally on the same page on how this should be implemented.

Agreed about the design session. Let's make sure we are all on the same page and get it documented.


Update CONTRIBUTING.md

Successfully added instructions to contribute using GitHub Desktop.
closes #50

Great !! @PradnyaGaitonde  Looking forward for more contributions !!


[Question] Simplify?

Of course this isn't gospel, but i feel thee docker image could be simplified a lot. For example, what i use for my docker environments is:
// docker-compose.yml
socket:
    ...
    build:
      context: .
      dockerfile: .docker/deno.dockerfile
      args:
        DENO_VERSION: 1.2.3
    environment:
      USE_DENON: "true"
    ports:
      - "1668:1668"
    volumes:
    - "./src/socket:/var/www/socket"
    working_dir: /var/www/socket
    networks:
      - chatsterisk-app-network

// .docker/deno.dockerfile
FROM debian:stable-slim

ARG DENO_VERSION

RUN apt update -y \
  && apt clean \
  && apt install bash curl unzip -y

RUN curl -fsSL https://deno.land/x/install/install.sh | DENO_INSTALL=/usr/local sh -s v${DENO_VERSION}
RUN export DENO_INSTALL="/root/.local"
RUN export PATH="$DENO_INSTALL/bin:$PATH"

COPY ./.docker/deno-entrypoint.sh /deno-entrypoint.sh
RUN chmod +x /deno-entrypoint.sh
ENTRYPOINT ["/deno-entrypoint.sh"]

// deno-entrypoint.sh
// just uses denon if USE_DENON env var is true

I think it'd be nice to see aspects of the above incorporated, for example the ARGS, so from an end-user perspective, i'd do:
// docker-compose.yml
socket:
    image: hayd/deno-image-name
    environment:
        DENO_VERSION: <IP_ADDRESS> # installs that specific version of deno

Whilst maybe still allow the user to specify an entrypoint, so for example i could still install denon and use denon

@hayd i'm not too familiar to installing it through GH, but though through deno.land is official right? I assume you have to change the permissions on the file due to installing it through GH? Which is something not needed when installing through deno.land

I just mean, that deno.land uses GH behind the scenes. It's a good point that it is official. 🤔

Of course it's entirely up to you
If you are against any ideas then feel free to close this issue 👍 I'll leave it open if you wanted to discuss it more or it might be a good idea for the future or something

I think the reason to keep the current way is it is explicit (in a single RUN step):

install curl and unzip
curl the file from GH
unzip
uninstall curl and unzip

deno install essentially does the same thing (the curl and unzip), but it's obscured.
I'm not really convinced that using deno install is any simpler! 🤷

BTW In your example above you do the curl/unzip install in a previous step, this bloats the image a little (though those are both small), I think what the docker file should do is install deno only (and set ENV variables) no other libs that aren't required for deno to run.

That said, very happy to add slim (I thought the current debian image was slim, but it is tied to a specific tag).
Can you open another issue for the ARGS concern? I am not sure I grok the issue but it sounds important/useful to fix. (and seems independent of using deno install in the dockerfile)

I'm not really convinced that using deno install is any simpler! 🤷

Fair enough :)

To be honest, i'm not sure the size of debian-slim compared to the one you use (i only assume it's smaller), but there might not even be much difference in size

FYI Made the issue for the args: https://github.com/hayd/deno-docker/issues/88

Also FYI turns out the debian-stable-slim image is 69MB on my machine, so really 0 difference at all


Adding images withing the wishlist

It should have the option to add images with every item in your wish list, that way your secret Santa will get a better idea of what you want, sometimes is hard to explain with just words, because we want something very specific.
Images are better than words ;)

you can link to image URL's that you can find in google search etc.
but hosting the actual images makes us a lot more vulnerable to abuse. I don't think we are going to do this without having someone that really wants to invest his/her time into the feature
also note that this is an issue tracker on a code collaboration platform, so feel free to come up with an implementation

How do I link?
I didn't see that option, if so I agree with you, no need more.

Say I want this sweater: https://litb-cgis.rightinthebox.com/images/640x640/202110/bps/product/inc/fdbnxw1635500067851.jpg?fmt=webp&v=1 you can just put that link in your wishlist item. Can you try that?

Yes, thank you, the site is down now (or at least my friend and I cannot enter), but I got what you said.

I see. Fixed thanks!

Thanks a lot, already put the link.


make PlayerDelegate methods optional

Solves https://github.com/piemonte/Player/issues/109

@tsheaff 👍


IBAX points

Describe the bug
Does not give 200 points for liking and tagging 3 friends on Twitter posts.
Reproduction

It does not give 200 points as it appears here
System Info
All browsers have the same problem. A general problem.

Logs
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Goof

Nice

aynen

It's the original design users get 200 IBAX points.  Now we give more than 200


feat: rewrite answer as well

fixes issue with jankins not being able to resolve *.uds.dev
Description
jankins images are incompatbile with dns responses where the answer section doesn't match the question

Thanks @corang. Tested this and looks good.


Mavenize project layout [HPPC-41]

Create a mavenized project layout, just to see how it'd compare to the ANT-only version.

Issue: HPPC-41 (migrated from JIRA), created by Dawid Weiss (@dweiss), resolved Jan 24 2011

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
Remaining:

mavenized project layout
generated sources, eclipse
javadocs (customized)
PMD, CDP, FINDBUGS
Intrinsics.equals test
artifacts, distribution assembly descr.
release bundle [sonatype]
benchmarks and reports
document how to launch maven to get: installed binary, benchmarks, reports, distribution bundles, snapshot release, final release
clover2 (this seem ridiculously complex, passing on it).

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
I give up to add clover support, it just sucks from maven. Clover either modifies the compiled classes (so that it would have to run as a separate build) or runs in a separate lifecycle, thus causing all tests to be executed multiple times. Even if, I couldn't get it to pick up the generated sources for processing, adding includesAllSourceRoots resulted in duplicate class errors.


Cloudinary selected image previews not rendering in image widgets

Describe the bug

I'm using Cloudinary for media library.
The selected image previews are not showing up in the admin page's image widgets. See screenshot:

The one error in the console:
TypeError: Arguments to path.join must be strings 2 index.js:117:12

Here's my relevant config.yml:
media_library:
  name: cloudinary
  config:
    cloud_name: ***********
    api_key: ************
  output_filename_only: true
collections:
  - label: 'Products'
    name: 'products'
    folder: '_data/products'
    format: 'json'
    create: true
    identifier_field: name
    fields:
      - label: 'Primary photo'
        name: 'imgPrimary'
        widget: 'image'
        allow_multiple: false
        required: false
      - label: 'Secondary photos'
        name: 'imgSecondarySet'
        widget: 'list'
        allow_multiple: true
        field: { label: Image, name: image, widget: image }
        required: false

To Reproduce

See screenshot above.
Expected behavior

The image preview should render for selected images.
Screenshots

See above
Applicable Versions:

Netlify CMS version:

netlify-cms-app 2.11.14
netlify-cms-core 2.17.0
netlify-cms 2.10.17

Git provider: GitHub

OS: macOS 10.12.6

Browser version FF Dev Edition 73.0b12

Node.JS version: Not using node, just straight up src tag in html

CMS configuration

See above
Additional context

Closing this as duplicate of https://github.com/netlify/netlify-cms/issues/1934


[TE] Support Scan of non-highest axis

For algorithms like cumsum, most of the cases requires scanning over non-highest axis. The current workaround for this issue is to transposing the target axis to the highest and then do the scanning. It would be great to add direct support for scanning over other axis though.
Background https://github.com/apache/incubator-tvm/pull/5289

We have cumsum op now.


When using POCOs as dictionary keys, how I access them inside the template?

What is the state of accessing dictionary entries that are indexed by objects?
var dict = new Dictionary<MyClass, MyOtherClass>();
dict.Add(instanceOfMyClass, instanceOfMyOtherClass);

In the template:
{{ dict[instance_of_my_class].any_property }}

This throws an error saying dict[instance_of_my_class] is null.
I can list {{ dict }} and I know it has all the entries in it. And re-accessing my entry through C# works fine. So I know the dictionary has the entry, and I use the object elsewhere in Scriban, so I know the {{ instanceOfMyClass }} object is the right key.
The Scriban capable of accessing dictionary entries keyed this way?  And is instance_of_my_class in the template the same as instanceOfMyClass in C#?  Will those keys match up?

FYI -- any attempt to run {{ dict }} through object.keys or object.values gives me:
'Unable to convert parameter #0 of type `System.Collections.Generic.Dictionary`2[BlogData.Post,BlogData.PostContext]` to type `System.Collections.Generic.IDictionary`2[System.String,System.Object]`'

What is the state of accessing dictionary entries that are indexed by objects?

Unfortunately, It's not supported. Dictionary keys are required to be strings (like json objects)

I had tried to make the keys strings, but still couldn't get it to work, and then I turned it to <string,object> and it worked. So:
dict.ToDictionary(i => i.Key, i=>(object)i.Value);

It wouldn't accept it if the value is MyOtherClass. It literally has to be cast down to an object.
Is this right?


added hover effects to the card

Added shadows hover effects (mainly scaling up the cards), removed the hover border color, and made the profile username font a bit light and color black

Fixes Issue

Changes proposed

added shadows,
added hover effect,
changed profile username text on the card to light and black

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots

It's a hover effect so moving the cursor pointer on it will show you the changes, although you may see the change I made in the profile username text
Note to reviewers
Made these changes to make the UI better than before.

The suggestion is to remove the orange box containing profile view numbers which are on the top right of the profile picture. Instead what you can do is:

here's the video, if needed we can add colors to hover transition or more shadow-drops
https://user-images.githubusercontent.com/73755149/214341944-769c6bd5-b74e-4c30-ab1f-49981f595303.mp4

so, we can increase the font weight for UserName instead of using ''text-bold''... which will make the heading separate from the description down below and the orange color can be lighter for eg. #F0A500 or RGB(240, 165, 0)
Is the hover transition fine?

that less space for description can be solved by adding an anchor tag of more... If a user wants to read the remaining part of the description he can click on the more hyperlink which will redirect to the profile link of the user. In this way, the user will also get more views on his profile.

I'd just wait and let Eddie or the maintainers make a call on this!. Thanks for the contribution <3

Okay! Cool

I think the orange border looks great also 👍  maybe try with the orange border and the new effects and see how it looks?

Oh! I made the change! I think it looks good. Here's the video:
https://user-images.githubusercontent.com/73755149/215020539-e48a64c7-c114-46ed-a4b0-fdc1d200d447.mp4

@eddiejaoude Oh! I made the change! I think it looks good. Here's the video:
Untitled.mp4
should I change the code? and it looks slow in the video(because of compression) but it's good when tested on website

looks good to me :)

thank you!! when it will be merged? 😃

Hey. One of the maintainers will look into it and take a decision

Okay, got it! 👍🏼

@eddiejaoude can you please check the changes and merge if it's looking good?

Hey. Give it a few days before mentioning. A good period would be 7 days, post that you can reach out to the maintainers on the discord server

Hey. Give it a few days before mentioning. A good period would be 7 days, post that you can reach out to the maintainers on the discord server

Oh okay, thanks for the info.

@stevenovak123  I just committed a change to the profile username... the username will be underlined once hovered on it. what do you think about that?

Imo it is a good addition, I'm just a person that helps maintainers review. Its the maintainers call if its a good addition to be merged into repo. So make the contribution and wait until a maintainer takes a decision

There is a falling GitHub Action for accessibility, please fix so we can merge?

done. 👍🏼

Please can you add a screenshot of the latest changes

Please can you add a screenshot of the latest changes

the latest change was the bold black username and underline transition when hovering

and hover effect can be seen in the video I sent earlier in the conversation :)


test: supply-chain-backend-api-calls fails without config file #1516

Made it so that the test uses a config that does not specify a config
file path to be parsed by the config service so that it does not depend
on one existing on the file system when the test gets executed.
It works fine without the .config.json file because we anyway configure
everything via code within the test.
This test started failing while I was working on the Jest/Tap co-existence
pull request so it might have something to do with the migration, but it
does not look like it.
Fixes #1516
Signed-off-by: Peter Somogyvari<EMAIL_ADDRESS>

Codecov Report

Merging #1517 (1be9bba) into main (af6c240) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   69.78%   69.78%
=======================================
  Files         336      336
  Lines       12626    12626
  Branches     1513     1513
=======================================
  Hits         8811     8811
  Misses       2992     2992
  Partials      823      823

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6c240...1be9bba. Read the comment docs.


[models] Get Polygon of mesh

I am working on Collision Detection, but i need the polygon of a mesh
A way in code would just be
Polygon = GetPoly(Mesh, ID);
So i could loop through it
if this wouldn't be done,
could someone at least tell me how to do it without a function
(using vertices and tangents or normals, idk, no idea how do to)

@CrezyDud What is the polygon of a mesh? model.meshes only contain vertex data. Do you mean the triangles?
Triangles are usually defined by a set of 3 vertices in a row but only if no indexes are used.

yes, sorry, i do mean triangles
so to get one i would just have to get 1st verticy 2nd and 3rd, connect them and i have one?
i tried that am i doing something wrong?
i'll check my code and try again


Gauge Chart value doesn't update when jinja template filters are set

I have a gauge chart in my dashboard that displays one metric. I apply filters with Jinja templating to the base table. The gauge chart metric doesn't change, not even after a full refresh.
How to reproduce the bug

Add a filter with jinja templating in a dataset, pseudocode similar to my scenario:

SELECT
  a.something
FROM table_A a
INNER JOIN table_B b
ON table_A.id = table_B.id
WHERE 1 = 1
{% if filter_values('val')|length %}
  AND b.val IN {{ filter_values('val')|where_in }};
{% endif %}

Add a metric in dataset, e.g. COUNT(DISTINCT(something))
Add a gauge chart displaying the metric
Put it on a dashboard
Change filter values
See that gauge chart value doesn't update.

Expected results
Changed metric in gauge chart.
Actual results
Metric in gauge chart stays as if no filter was applied.
Screenshots
No filters set, gauge chart and big number chart with unfiltered metric value:

Filter is set (greyed/whited out, but visible that a filter value was set), big number chart updates, gauge chart doesn't:

Environment
(please complete the following information):

browser type and version: Chrome
superset version: 3.0.1

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Closing this as stale, but it's likely stale because it's hard to reproduce. Can you give us a reproducible test case using example charts/data so not as much has to be redacted? If we can make that happen, and the bug is still present in 3.1/4.0, we can revisit/reopen. Thanks!


Timezones - Verify that all methods are implemented

Verify that all methods below have been implemented.
Timezones

[x] /timezones/list

This object has a horrible formatting, making it almost impossible


feat: Fix tooltip and add favicon

What type of PR is this? (check all applicable)

[x] ♻ Refactor
[x] ✨ Feature
[x] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR adds

the opensauced favicon
a tooltip to every profile image
layout structure to present codebase

Related Tickets & Documents

fixes #36
fixes #30

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 docs
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@kelvinsekx This looks good. You will need to fix the merge conflicts and fill out the description items for the PR. That context is important for future contributors and documentation.

PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched

package.json

This requires an npm install to bring the changes from package.json into npm-shrinkwrap.json

PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched

package.json

This requires an npm install to bring the changes from package.json into npm-shrinkwrap.json

Have not been around my laptop. When I'm in I will resolve that.

Thanks for another great contribution @kelvinsekx


Generate definition classes for inlined objects

This PR bring support for generation of definition classes for objects that are inlined (they are defined with some other object definition). Current behavior is not to generate any definition class and just just io.circe.Json (scala). This PR significantly improves current situation.
Generated definitions for those classes are placed into a companion object. Name of a class is derived from a property for which the class was derived for. Please see a test if this is not clear.
A similar approach can be used for enums that are not defined on their own. Currently we use String. I plan to implement this as well, but in a separate PR to keep this one small.
Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

cc @blast-hardcheese

@hanny24 Definitely on my radar for the new week, I didn't have time to look over the weekend. From what I've seen so far, this strategy gets us closer to object deduplicaton as well, which I'm particularly interested in. Thanks for you work so far :smile:

Are there any other concerns? If not, I can squash all the changes into single commit.

I'll merge whenever you say this branch is ready to be merged. If you'd like to restructure the commits in any way (atomic, etc) feel free.

It's ready to be merged now. Thanks!

Thank you! This is really exciting!

Indeed, with third party APIs that's really welcome.
Looking forward for anonymous enum support too..

We do now: https://github.com/twilio/guardrail/issues/370


Compile task sticks around after Extension Development Host is closed.

Version 1.4.0-insider

start vscode fresh
open a extension sample code, e.g. https://github.com/DanTup/Dart-Code/
in the settings unfilter the out folder, so it can be seen in the exlorer
delete the out/src folder, create a empty src folder again
press F5.
Extension Development Host starts, open a dart file, all works fine, files are compiled
shutdown the Extension Development Host
delete the out/src folder, create a empty src folder again
press F5.
Extension Development Host starts, open a dart file, error, out/src stays empty.
Run 'terminate running task'
press F5.
Extension Development Host starts, open a dart file, all works fine, files are compiled

Wouldn't it be better to kill the task when the Extension Development Host is closed? It is not obvious to the user that there's still a task running and how to terminate it. Also I don't need to have my files compiled until I start the the Extension Development Host again.

Instead of killing I would then not start a watching task.

While the Extension Development Host is up, watching makes sense (reload is faster than restart)