Improve performance of Markup.child(at:) method while still accurately tracking metadata

Summary
While investigating general performance improvements in Swift-DocC for:

https://github.com/apple/swift-docc/pull/166

I found that Swift-DocC was spending a lot of time creating iterators while rewriting markup elements in Swift-Markdown code using MarkupRewriters. This PR is a refactoring of the Markup.child(at:) method to improve performance.
I put up a PR with a similar change in #36 where @bitjammer pointed out that I was incorrectly tracking metadata for child elements. This is a second iteration on that PR that resolves that issue and adds a test to catch the issue I missed before. It appears to have the same performance win as the original PR when testing with the Swift-DocC performance suite.
Testing
I added tests that confirm the metadata returned for child elements via the new child(at:) implementation is the same as the metadata for child elements returned via the existing sequence implementation. Swift-Markdown and Swift-DocC's existing tests continue to pass with this change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Updated documentation if necessary

@swift-ci please test

Hm, is this really faster now? There are now more heap allocations in here and it is still O(n). This isn’t really what I was intending when we were talking about this earlier. Can we please hold off on changes to this area until I can have a look at the performance trace? If it’s all right with you, I want to take a look at making this faster without having to basically inline the iterator.

Hm, is this really faster now?

It is noticeably faster in the bundle-registration phase of docc convert which is where most of the markup rewriting occurs. Here's benchmark results of a before/after adopting this version of Swift-Markdown in Swift-DocC:
TestFramework-5.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -9.50%     | 2.90                 | 2.63                 |
| Duration for 'convert-total-time' (sec)  | -6.36%     | 4.42                 | 4.14                 |
| Duration for 'documentation-processing'  | -0.45%     | 1.34                 | 1.33                 |
| Duration for 'finalize-navigation-index' | +2.67%     | 0.07                 | 0.08                 |
| Peak memory footprint (MB)               | +2.92%     | 202.93               | 208.86               |
| Data subdirectory size (MB)              | no change  | 57.35                | 57.35                |
| Index subdirectory size (MB)             | no change  | 0.47                 | 0.47                 |
| Total DocC archive size (MB)             | no change  | 75.64                | 75.64                |
| Topic Anchor Checksum                    | no change  | 65d4ff3050cd1106a21b | 65d4ff3050cd1106a21b |
| Topic Graph Checksum                     | no change  | 0a64c740a2ed5a246836 | 0a64c740a2ed5a246836 |
+-----------------------------------------------------------------------------------------------------+
TestFramework-10.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -10.65%    | 5.89                 | 5.26                 |
| Duration for 'convert-total-time' (sec)  | -6.57%     | 9.00                 | 8.41                 |
| Duration for 'documentation-processing'  | +0.29%     | 2.79                 | 2.80                 |
| Duration for 'finalize-navigation-index' | +2.76%     | 0.14                 | 0.15                 |
| Peak memory footprint (MB)               | -0.38%     | 364.61               | 363.21               |
| Data subdirectory size (MB)              | no change  | 114.71               | 114.71               |
| Index subdirectory size (MB)             | no change  | 0.95                 | 0.95                 |
| Total DocC archive size (MB)             | no change  | 150.47               | 150.47               |
| Topic Anchor Checksum                    | no change  | c8f03d4e81da8e3b6d7f | c8f03d4e81da8e3b6d7f |
| Topic Graph Checksum                     | no change  | edce22bce4f8de475a5e | edce22bce4f8de475a5e |
+-----------------------------------------------------------------------------------------------------+
TestFramework-25.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -10.16%    | 14.93                | 13.42                |
| Duration for 'convert-total-time' (sec)  | -6.39%     | 23.56                | 22.05                |
| Duration for 'documentation-processing'  | +0.20%     | 7.82                 | 7.84                 |
| Duration for 'finalize-navigation-index' | no change  | 0.36                 | 0.36                 |
| Peak memory footprint (MB)               | -1.87%     | 861.11               | 845.04               |
| Data subdirectory size (MB)              | no change  | 287.64               | 287.64               |
| Index subdirectory size (MB)             | no change  | 2.41                 | 2.41                 |
| Total DocC archive size (MB)             | no change  | 375.86               | 375.86               |
| Topic Anchor Checksum                    | no change  | 9a675b9ad6d69f8b7f0c | 9a675b9ad6d69f8b7f0c |
| Topic Graph Checksum                     | no change  |<PHONE_NUMBER>84b5131a37 |<PHONE_NUMBER>84b5131a37 |
+-----------------------------------------------------------------------------------------------------+
TestFramework-50.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -9.78%     | 30.12                | 27.18                |
| Duration for 'convert-total-time' (sec)  | -6.19%     | 49.48                | 46.42                |
| Duration for 'documentation-processing'  | -0.64%     | 17.64                | 17.52                |
| Duration for 'finalize-navigation-index' | -0.13%     | 0.74                 | 0.74                 |
| Peak memory footprint (MB)               | +1.27%     | 1605.38              | 1625.81              |
| Data subdirectory size (MB)              | no change  | 578.65               | 578.65               |
| Index subdirectory size (MB)             | no change  | 4.84                 | 4.84                 |
| Total DocC archive size (MB)             | no change  | 754.32               | 754.32               |
| Topic Anchor Checksum                    | no change  | 08d0a84bec913460905f | 08d0a84bec913460905f |
| Topic Graph Checksum                     | no change  | 74d25c4f1ee185ad5676 | 74d25c4f1ee185ad5676 |
+-----------------------------------------------------------------------------------------------------+

There are now more heap allocations in here and it is still O(n).

Are there more heap allocations? I was thinking that reducing the number of calls to _makeMarkup to one instead of N would result in fewer.

Can we please hold off on changes to this area until I can have a look at the performance trace? If it’s all right with you, I want to take a look at making this faster without having to basically inline the iterator.

That's fine with me! I'd like to land the fix in DocC sometime next week and would ideally like to take this (or a different performance win) with it so that we're fully resolving that performance regression. But would, of course, appreciate your help here on investigating other solutions.

@swift-ci Please test

Thank you for all the help with this one!

There are a few more ways we can shave off some time for this operation but we can save it until later if you’re happy with the boost.

That sounds great. Would love to take another crack at this with you in the next month or so.

Updated performance test results for adopting this change in Swift-DocC:
TestFramework-5
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -9.78%     | 2.90                 | 2.62                 |
| Duration for 'convert-total-time' (sec)  | -6.51%     | 4.43                 | 4.14                 |
| Duration for 'documentation-processing'  | -0.37%     | 1.35                 | 1.34                 |
| Duration for 'finalize-navigation-index' | -1.28%     | 0.08                 | 0.08                 |
| Peak memory footprint (MB)               | +4.93%     | 195.41               | 205.04               |
| Data subdirectory size (MB)              | no change  | 57.36                | 57.36                |
| Index subdirectory size (MB)             | no change  | 0.47                 | 0.47                 |
| Total DocC archive size (MB)             | no change  | 74.45                | 74.45                |
| Topic Anchor Checksum                    | no change  | 65d4ff3050cd1106a21b | 65d4ff3050cd1106a21b |
| Topic Graph Checksum                     | no change  | 0a64c740a2ed5a246836 | 0a64c740a2ed5a246836 |
+-----------------------------------------------------------------------------------------------------+
TestFramework-10
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -9.93%     | 5.86                 | 5.28                 |
| Duration for 'convert-total-time' (sec)  | -8.04%     | 9.15                 | 8.41                 |
| Duration for 'documentation-processing'  | -6.98%     | 2.96                 | 2.76                 |
| Duration for 'finalize-navigation-index' | +2.04%     | 0.15                 | 0.15                 |
| Peak memory footprint (MB)               | +1.94%     | 357.46               | 364.38               |
| Data subdirectory size (MB)              | no change  | 114.84               | 114.84               |
| Index subdirectory size (MB)             | no change  | 0.95                 | 0.95                 |
| Total DocC archive size (MB)             | no change  | 148.21               | 148.21               |
| Topic Anchor Checksum                    | no change  | c8f03d4e81da8e3b6d7f | c8f03d4e81da8e3b6d7f |
| Topic Graph Checksum                     | no change  | edce22bce4f8de475a5e | edce22bce4f8de475a5e |
+-----------------------------------------------------------------------------------------------------+
TestFramework-25
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -9.01%     | 14.70                | 13.37                |
| Duration for 'convert-total-time' (sec)  | -6.43%     | 23.56                | 22.05                |
| Duration for 'documentation-processing'  | -1.61%     | 8.00                 | 7.87                 |
| Duration for 'finalize-navigation-index' | -0.27%     | 0.37                 | 0.37                 |
| Peak memory footprint (MB)               | +0.49%     | 837.12               | 841.25               |
| Data subdirectory size (MB)              | no change  | 287.75               | 287.75               |
| Index subdirectory size (MB)             | no change  | 2.41                 | 2.41                 |
| Total DocC archive size (MB)             | no change  | 369.97               | 369.97               |
| Topic Anchor Checksum                    | no change  | 9a675b9ad6d69f8b7f0c | 9a675b9ad6d69f8b7f0c |
| Topic Graph Checksum                     | no change  |<PHONE_NUMBER>84b5131a37 |<PHONE_NUMBER>84b5131a37 |
+-----------------------------------------------------------------------------------------------------+
TestFramework-50
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Duration for 'bundle-registration' (sec) | -10.97%    | 30.28                | 26.96                |
| Duration for 'convert-total-time' (sec)  | -7.31%     | 50.01                | 46.35                |
| Duration for 'documentation-processing'  | -2.08%     | 18.06                | 17.68                |
| Duration for 'finalize-navigation-index' | -1.32%     | 0.76                 | 0.74                 |
| Peak memory footprint (MB)               | -3.15%     | 1590.68              | 1540.61              |
| Data subdirectory size (MB)              | no change  | 578.68               | 578.68               |
| Index subdirectory size (MB)             | no change  | 4.84                 | 4.84                 |
| Total DocC archive size (MB)             | no change  | 742.34               | 742.34               |
| Topic Anchor Checksum                    | no change  | 08d0a84bec913460905f | 08d0a84bec913460905f |
| Topic Graph Checksum                     | no change  | 74d25c4f1ee185ad5676 | 74d25c4f1ee185ad5676 |
+-----------------------------------------------------------------------------------------------------+


Add "anonymous profile" option for participant profiles

This fixes #294. Now, experimenters can specify "Set anonymous profiles" in the profile editing stage.
When participants are created, they are assigned an identity:

And will be shown this screen rather than the profile editing screen:

NOTE: Updated anonymous profile configuration so that the createParticipant endpoint only takes in one new parameter, isAnonymous. Based on this, we use functions in utils/src/participant.ts to populate the profile with animal name/avatar based on the participant's number (e.g., if there are animal options ["Lion", "Tiger", "Bear"], participant-0 gets "Lion", participant-2 gets "Tiger", participant-3 gets "Bear", participant 4 gets "Lion 1", etc.


Update license 2019

Fix license of use,
update 2019;
Format ISO 8869-1;
in Memoriam Guto Schiavon

R.I.P pioneer and friend.
#ripGUTO

No changes have been made in 2019.


Office 365 integration and individualized targets

It'd be awesome given that Office365 has access to my active directory and everything that I could set this up to send a message directly to reviewers of a PR per say instead of just to a channel.  Channel based messaging becomes chaff.  I will say I haven't tested this yet.  If it tags users that is better than nothing but individualized messaging would be far more effective.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cddc0ae-93af-297c-2e71-334143ebee1e
Version Independent ID: cb76e516-8471-c3e1-45f4-0a20a223f32a
Content
Content Source
Service: unspecified

Deprecated, this connector doesn't exist


[BatchMode] Remove uses of -bypass-batch-mode-checks in tests, no longer needed.

Just removes a flag we don't need to be passing.
cc @davidungar and @jrose-apple for observability, but I don't imagine this is contentions.

@swift-ci please test and merge


error: OpenCV(4.6.0) :-1: error: (-5:Bad argument) in function 'circle'

Describe the bug
Extra parameters in the request method.
To Reproduce
Steps to reproduce the behavior:

Dora start daemon: dora up
Start a new dataflow: dora start graphs/oasis/oasis_agent_planning.yaml --attach

Screenshots or Video

Environments (please complete the following information):

System info: ubuntu 20.04 LTS
Dora version: v0.2.3

            for waypoint in gps_waypoints:
                if np.isnan(waypoint).any():
                    break
                cv2.circle(
                    resized_image,
                    (int(waypoint[0]), int(waypoint[1])),
                    3,
                    (
                        int(np.clip(255 - waypoint[2] * 100, 0, 255)),
                        int(np.clip(waypoint[2], 0, 255)),
                        122,
                    ),
                    # -1,
                )

It is normal to delete the parameter -1


Docs(autocomplete): regex filter search issue with character "?" and "$"

Bug, feature request, or proposal:
Documentation Bug on custom filtering : https://material.angular.io/components/component/autocomplete
What is the expected behavior?
Able to filter with character starting with ? and $
What is the current behavior?
Application crashes when filtering with character starting with ?
Not able to filter with character starting with $
What are the steps to reproduce?
Plunker Link
Search With > Result
S > Shelley
? > Application Crash
$ > No Result
What is the use-case or motivation for changing an existing behavior?
NA
Which versions of Angular, Material, OS, browsers are affected?
Angular 4.1.0
Material 2.0.0-beta.3
Chrome OS
Is there anything else we should know?
Came up with a solution to not use Regex. Plunker Link
filter(name: string): User[] {
     return this.options.filter((s) => s.name.toLowerCase().indexOf(name.toLowerCase()) !== -1);
}

I opted for something similar to this:
filter(val: string): string[] {
  const escapedVal = val.replace(/([.?*+^$[\]\\(){}|-])/g, '\\$1');
  return this.options.filter(option => new RegExp(`^${escapedVal}`, 'gi').test(option));
}

Perhaps @kara can weigh in on whether or not regex escaping is within the scope of the autocomplete docs.

The reason the autocomplete in our demo has this default filter is due to accessibility concerns. See https://github.com/angular/material2/issues/3373 for more info. Essentially, it is confusing for users with screenreaders to hear options matching any letter in the word (rather than options that match starting with the first letter). I think it's outside the scope of the docs to explain how to escape particular Regex characters. That's a pretty broad topic that we wouldn't be able to cover sufficiently.


test(robot): fix unable to pass downtime to reboot node function

Which issue(s) this PR fixes:

Issue N/A
What this PR does / why we need it:
fix unable to pass downtime to reboot node function
Special notes for your reviewer:
Additional documentation or context

cc @longhorn/qa


[live 2539] LLM - Back button in NftViewer

📝 Description
LLM - Adding the back button to NFT Viewer and fixed background issue (the skeletton was still loading in the background. Passed the header to transparent so it has no background and is positionned to "absolute" preventing the image to get down in the view.
❓ Context

Impacted projects: LLM
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-2539 https://www.figma.com/file/gmYzg5ekdRJ9tK3KuviFFu/LLM-%2F-NFT?node-id=211%3A560

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo
before :

after :

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Please provide a video of how it's now working with the NftImage loading since you changed the skeleton behaviour 🙏


configmaps is forbidden: User "system:serviceaccount:kube-system:k8s-ipam-configmap" cannot create configmaps in the namespace "kube-system"

Hi,
first of all, thanks for opensourcing fortigate-lb-ctlr, great stuff.
I am trying to deploy fortigate-lb-ctlr with k8s-ipam-configmap and I ran into an issue.
After applying the various YAML files, including rbac.yml, the k8s-ipam-configmap container fails to start:
panic: error creating initial address management configmap 'ipam-cm' in namespace 'kube-system': configmaps is forbidden: User "system:serviceaccount:kube-system:k8s-ipam-configmap" cannot create configmaps in the namespace "kube-system"

$ kubectl get serviceaccount k8s-ipam-configmap -o yaml --namespace=kube-system
apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","kind":"ServiceAccount","metadata":{"annotations":{},"name":"k8s-ipam-configmap","namespace":"kube-system"}}
  creationTimestamp: 2018-10-14T21:26:38Z
  name: k8s-ipam-configmap
  namespace: kube-system
  resourceVersion: "246525"
  selfLink: /api/v1/namespaces/kube-system/serviceaccounts/k8s-ipam-configmap
  uid: d5a14d10-cff7-11e8-b1c4-005056b43773
secrets:
- name: k8s-ipam-configmap-token-cmc5j

$ kubectl get clusterroles k8s-ipam-configmap -o yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"rbac.authorization.k8s.io/v1","kind":"ClusterRole","metadata":{"annotations":{},"name":"k8s-ipam-configmap","namespace":""},"rules":[{"apiGroups":[""],"resourceNames":["ipam-cm"],"resources":["configmaps"],"verbs":["create","get","update","patch","delete"]},{"apiGroups":["ipam.nexinto.com"],"resources":["ipaddresses"],"verbs":["*"]}]}
  creationTimestamp: 2018-10-14T12:40:08Z
  name: k8s-ipam-configmap
  resourceVersion: "191000"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterroles/k8s-ipam-configmap
  uid: 48b2646a-cfae-11e8-b1c4-005056b43773
rules:
- apiGroups:
  - ""
  resourceNames:
  - ipam-cm
  resources:
  - configmaps
  verbs:
  - create
  - get
  - update
  - patch
  - delete
- apiGroups:
  - ipam.nexinto.com
  resources:
  - ipaddresses
  verbs:
  - '*'

$ kubectl get clusterrolebindings k8s-ipam-configmap -o yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"rbac.authorization.k8s.io/v1","kind":"ClusterRoleBinding","metadata":{"annotations":{},"name":"k8s-ipam-configmap","namespace":""},"roleRef":{"apiGroup":"rbac.authorization.k8s.io","kind":"ClusterRole","name":"k8s-ipam-configmap"},"subjects":[{"kind":"ServiceAccount","name":"k8s-ipam-configmap","namespace":"kube-system"}]}
  creationTimestamp: 2018-10-14T12:40:08Z
  name: k8s-ipam-configmap
  resourceVersion: "644246"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterrolebindings/k8s-ipam-configmap
  uid: 48bfee09-cfae-11e8-b1c4-005056b43773
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: k8s-ipam-configmap
subjects:
- kind: ServiceAccount
  name: k8s-ipam-configmap
  namespace: kube-system

Any idea what I should be looking at?
Thank you!

Hello,
there was a bug in the RBAC configuration. I have fixed it; could you apply deploy/rbac.yaml again?

Hi Ilja,
It is working now, thanks a lot!


Pass abstraction

Okay, I think this is pretty much done. All the compiler passes have been converted, and the tests are all uniform.
I'm not sure about what I've done with renaming: it's a pass, and the compiler passes that need renaming export a "normal" pass and a "self-contained" pass which does the renaming first. I'm unsure if this is a good way to structure it, but it seems nice to both have the "bare" pass and the one that is can be reliably used without thinking about renaming.

Also the number of tests for the property tests for the different passes are wildly different with no rationale :( I might also clean that up.

I think I'm happy with the current state, we can work on it more in future.


How to connect to elasticsearch running on a server other than localhost.

I am trying to connect to elasticsearch running in a server other than localhost for eg: <IP_ADDRESS>:9200. Which fields needs to be updated to access the elasticsearch.

Elasticsearch connections are configured via the invenio-search package. You can have a look at the module's config docs: https://invenio-search.readthedocs.io/en/latest/configuration.html


[SMALLFIX] Changed the thriftGen from project enumeration to detecting projects …

…that contain thrift files

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8692/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8696/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8718/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8770/
Test PASSed.

Merged build finished. Test PASSed.

@aaudiber any more comments?

nice! LGTM


Update from fork

Fixed merge conflicts. Test before submit.

Oops wrong place sorry.

any plans to upstream QAVHWDevice_DXVA2?

Novacer any plans to upstream QAVHWDevice_DXVA2?

Sure I've submitted a pull request #272.
FWIW Dxva2 didn't really make any observable difference in my own testing so I did not pursue it further. But if you see value it in then happy to contribute :)


deprecate distrax

make surjectors a strict superset of distrax, so we can remove any distrax calls

Actually some functionality is needed. Good solution for vectorial things


edges table viewer: incorrect right coordinate displayed?

There seems to be a difference between the right coordinates displayed in the Edge table viewer vs the tree sequence edges table.

I'm not sure the correct coordinates are displayed in Edges plot either, so it could be that somehow the wrong coordinate is recorded in the edges_df. I'll dig into it!

I've not been able to replicate this in a couple of tree sequences I tried.

We've discused this already, but posting here so I don't forget: we think it's likely because in the edges_df we end up representing edges in terms of site IDs, instead of genomic coordinates.

Of course! We aren't dequantising the tszip columns! I'll add some more tests here - I should have caught this in the preprocessing tests.


unwrap_or_default not found

hey !
this tool looks awesome and i want it :)
i try to build it with cargo from source and got the following error
its the file src/widgets/disk.rs line 76:7
no method named `unwrap_or_default` found for type `std::option::Option<psutil::disk::disk_io_counters::DiskIoCounters>` i
n the current scope

note: the method `unwrap_or_default` exists but the following trait bounds were not satisfied:
           `psutil::disk::disk_io_counters::DiskIoCounters : std::default::Default`

i tried to build it with the night and the stable toolchain, no luck :S
am i missing something ? some library ? psutil is a python lib but i dont think that i will need this to build a cargo package :D
cheers,
felix

No you are not missing anything. I just accidentally remove something from the rust-psutil library but it should be fixed now :)

works like a charm now :) thanks alot !


Fix: Made POCOObservableForProperty include property name in warning

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix.
Fixes #864
Makes POCOObservableForProperty  error message include the property name.
What is the current behavior? (You can also link to an open issue here)
Just lists the full type name.
What is the new behavior (if this is a feature change)?
Now includes the property name.
What might this PR break?
Could be performance issue but only if the error happens, and only once per instance of the type.
Please check if the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)

I changed over to providing the different ICreatePropertyObservable to having the property name passed in. This already happens with the other method in the ICreatesPropertyObservable and the base class already asks for the GetMemberInfo().Name.
I did bench marking to confirm if this is indeed quicker.
Here are the old times:
BenchmarkDotNet=v0.11.0, OS=Windows 10.0.17134.191 (1803/April2018Update/Redstone4)
Intel Core i7-7700HQ CPU 2.80GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
  [Host] : .NET Framework 4.7.2 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.3160.0
  Clr    : .NET Framework 4.7.2 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.3160.0
  Core   : .NET Core 2.0.9 (CoreCLR 4.6.26614.01, CoreFX 4.6.26614.01), 64bit RyuJIT

          Method |    Job | Runtime |      Mean |     Error |    StdDev | Rank |
---------------- |------- |-------- |----------:|----------:|----------:|-----:|
 PropertyBinding |    Clr |     Clr | 10.201 us | 0.2273 us | 0.2706 us |    2 |
 PropertyBinding |   Core |    Core |  9.241 us | 0.1816 us | 0.2162 us |    1 |
 PropertyBinding | CoreRT |  CoreRT |        NA |        NA |        NA |    ? |

Here are the new times:
BenchmarkDotNet=v0.11.0, OS=Windows 10.0.17134.191 (1803/April2018Update/Redstone4)
Intel Core i7-7700HQ CPU 2.80GHz (Max: 2.00GHz) (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
  [Host] : .NET Framework 4.7.2 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.3160.0
  Clr    : .NET Framework 4.7.2 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.3160.0
  Core   : .NET Core 2.0.9 (CoreCLR 4.6.26614.01, CoreFX 4.6.26614.01), 64bit RyuJIT

          Method |    Job | Runtime |     Mean |     Error |    StdDev | Rank |
---------------- |------- |-------- |---------:|----------:|----------:|-----:|
 PropertyBinding |    Clr |     Clr | 6.041 us | 0.1122 us | 0.1152 us |    2 |
 PropertyBinding |   Core |    Core | 5.516 us | 0.0478 us | 0.0399 us |    1 |
 PropertyBinding | CoreRT |  CoreRT |       NA |        NA |        NA |    ? |

As you can see it halves the time in that function.
Here's my benchmark code for reference:
    [ClrJob, CoreJob, MonoJob, CoreRtJob]
    [RPlotExporter, RankColumn]
    public class INPCObservableForPropertyBenchmarks
    {
        private string propertyName;
        private Expression<Func<TestClassChanged, string>> expr = x => x.Property1;
        private Expression exp;
        private INPCObservableForProperty instance = new INPCObservableForProperty();

        [GlobalSetup]
        public void Setup()
        {
            exp = Reflection.Rewrite(expr.Body);
            propertyName = exp.GetMemberInfo().Name;
        }

        [Benchmark]
        public void PropertyBinding()
        {
            var testClass = new TestClassChanged();

            var changes = new List<IObservedChange<object, object>>();
            instance.GetNotificationForProperty(testClass, exp, false).Subscribe(c => changes.Add(c));
        }

        class TestClassChanged : INotifyPropertyChanged
        {
            string property;

            string property2;

            public string Property1
            {
                get { return property; }
                set
                {
                    property = value;
                    OnPropertyChanged();
                }
            }

            public string Property2
            {
                get { return property2; }
                set
                {
                    property2 = value;
                    OnPropertyChanged();
                }
            }

            public event PropertyChangedEventHandler PropertyChanged;

            public void OnPropertyChanged([CallerMemberName] string propertyName = null)
            {
                var handler = PropertyChanged;
                if (handler != null) {
                    handler(this, new PropertyChangedEventArgs(propertyName));
                }
            }
        }
    }


subscribe and unsubscribe regardless listener for AbstractRegistry

With WebSocket and removal of local cache in the LightCluster, there is no need to have a listener instance in the parameter when it is called from the cluster.

 subscribe and unsubscribe regardless listener for AbstractRegistry light-4j master


TreePrototype: fixed delete method and added generic methods

This is now obsolete as we'll continue with our unifiedTree module


#42 + #39 autocomplete and dropdown component

Both the dropdown and autocomplete component are part of this PR as they're fairly similar and I didn't want to keep switching between branches whenever I made adjustments. #39-dropdown-component is therefore stale

@leChuckles  @m-m-mic
I think this needs some more work:

filtering when typing is not implemented
filtering with no match should show "empty" list with message like "no option". this could be a configurable prop
the chips should be in state selected (and probably not deselectable -> not yet feasible with the current chips implementation)
the chevron (arrow icon) is not in the right size, position and direction (to be fair, it's also not always in the right direction in figma ;) )
the input is growing in height when a chip is inserted, is this according to the design or was it not considered?
unclear to me if there needs to be a placeholder when something is already selected (tbd with design)
unclear to me how it should behave on multiline input (tbd with design), chevron alignment

Other thoughts for improvement (might need sync with design)

allow the autocomplete component to be a single selection (without chips then)
remove selected entries with backspace
add action (inset cross icon) to delete all selected values


Add dependabot config

Context
We'd like to enable dependabot updates

Changes proposed in this pull request
Add basic configuration for dependabot

Guidance to review

Link to Trello card
https://trello.com/c/coBfXvDo/138-initial-project-setup-for-access-your-teaching-profile

Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency

@malcolmbaig :+1: amended


Configure CodeQL scanning

Add GitHub CodeQL scanning workflow

@Roemer Let me know if you still want to review, otherwise I'm going to merge it.


The getNewRepeat plugins source needs to be updated

Issue in help/implement/vars/plugins/getnewrepeat.md
getNewRepeat.txt

the above source file attachment is not minified. The below attachment has both the unminified and minified versions.
getNewRepeat.txt

Hi there, I've reached out via Slack internally to continue this thread. Thanks!


Run applications_convolution failed with AMD Radeon Pro W7900

I compile the git repo with "make" and the compiling finished without any error. Then I try to run some application like /rocm-examples/Applications/convolution/applications_convolution, but got failed.
root@AIG-PM:/home/rocm-examples/Applications/convolution# ./applications_convolution
Executing a simple convolution for 10 iterations with a 4096 x 4096 sized grid.
An error encountered: "invalid kernel file" at main.hip:242
I read the documents of this git. And just guest the compile should set the LLVM target of W7900 which is gfx1036. But I did not find out how to do the compile with gfx1036 as the LLVM target. Or may be other reason of the failed run.

The LLVM target of the W7900 should be gfx1100. You can configure this by adding -DCMAKE_HIP_ARCHITECTURES=gfx1100 to the cmake command, though by default cmake should attempt to figure it out by itself. Can you post your build command and it's full output?


CGZIP: Lost interrupt problem not detected properly anymore

RETC=102 is taken as confirmation that everything was fine. The enhance time echo took is not noticed anymore. We are working on a fix to see that we still loose interrupts in certain scenarios.

https://github.com/ibm-genwqe/genwqe-user/commit/55cbff03a9d5e13510fad8f3cf71b1453e806c2a might fix the problem.


Add additional math operations

Get intersection of two 2d lines
Get intersection of two rectangles
Add sign operation in math module

Hi Aysel,
I've made some comments inline which you can see above. Let me know if you need any clarification.
Thanks for the contribution!


Options from select showing as list  on page with CSS turned off(Accessibility)

As part of accessibility compliance, we have to test the functionality with CSS turned off. When we turn off CSS, the dropdown functionality is there and works as expected, but all the options in  also show up as a list  on the page. If you open and close the dropdown once, then the  markup goes away from the page and everything is good.
Is there a way to turn off the  markup from showing on the page on initial load?
Here is a sample:
http://jsfiddle.net/gopster/58n1ruox/

load the page
turn off styles on the page
You can see in the result window the  markup
Turn the styles back on
open and close the dropdown
turn off styles on the page
Now you don't see the list  markup

It's because you've got data-container="body" set. By default, regardless of the settings, the menu HTML is generated on page load. Once you open the menu, it is then removed from the default bootstrap-select container and appended to the new container ("body" in this case). I might play around with it and see if the performance increase is worth it to only generate the menu HTML upon clicking on the button.


[validator] not required field should not be validated by domain

Example: field with domain DO_EMAIL not required, the email validator is still applyed.
Its value is "" but the check is
        if (property.value === undefined || property.value === null) {
          return true;
        }
        return emailValidation(property.value, validator.options);

https://github.com/KleeGroup/focus/blob/24a5a975b949fed3eb3d491235e4cbf67e741e3b/src/definition/validator/validate.js#L54

Not required and empty fields.

Two things:

the value '' shoud be undefined when the form is read
the validator should't deal with empty cases, it should not be validated when a field is undefined


[WIP] Docker build

Added a Dockerfile to build of an alpine container on Mac OSX and Linux.

This change is

See https://github.com/dcos/dcos-net/pull/40

Thanks @urbanserj going to close this one in favor of #40 .


[Unit Test] Add test for EtcdCustomService.java

Search before asking

[X] I had searched in the issues and found no similar issues.

Read the unit testing guidelines

[X] I have read.

Unit test request
Add unit test for EtcdCustomService.java
Describe the unit tests you want to do
Module name:  eventmesh-meta
Located at: eventmesh-meta/eventmesh-meta-etcd/src/main/java/org/apache/eventmesh/meta/etcd/service/EtcdCustomService.java
Task status: ×(unfinished)
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Hey, i'm interested in this task. Can you assign this to me please

Feel free to submit a PR :)

Hey, i'm interested in this ticket. Was that possible to assign me in this ticket also?


Refactor type and range validation in configuration update process

Description
The configuration update process mixes type validation with range validation in com.cloud.configuration.ConfigurationManagerImpl#validateConfigurationValue. To improve this process, this PR splits these validations into two methods (validateValueType and validateValueRange) and cleans up the code.
Furthermore, this PR also fixes an issue that allows non-numeric values to be inserted into Double configurations, such as zone.virtualnetwork.ipv6subnet.capacity.notificationthreshold.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[X] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

How Has This Been Tested?
I manually verified the behavior of trying to update configurations of the following types, and compared them with the previous version to ensure the result was expected:

String - quota.currency.symbol and alert.email.addresses (that is, one that does not have null as a valid value and another that does);
Boolean - admin.is.allowed.to.deploy.anywhere;
Integer - storage.cleanup.interval. (the validations for this type also apply to Short and Long);
Float - cpu.overprovisioning.factor (also applies to Double).

Number
Test
Result
Expected result (Y/N)?

1
Value "null" in a String that does not have null as a valid value
The value is updated in the database, but the default value is used
Y

2
Value "1" in a String that does not have null as a valid value
Success
Y

3
Value "1.1" in a String that does not have null as a valid value
Success
Y

4
Value "test" in a String that does not have null as a valid value
Success
Y

5
Value "null" in a String that has null as a valid value
Success
Y

6
Value "1" in a String that has null as a valid value
Success
Y

7
Value "1.1" in a String that has null as a valid value
Success
Y

8
Value "test" in a String that has null as a valid value
Success
Y

9
Value "null" in a Boolean
Exception
Y

10
Value "1" in a Boolean
Exception
Y

11
Value "1.1" in a Boolean
Exception
Y

12
Value "test" in a Boolean
Exception
Y

13
Value "true" in a Boolean
Success
Y

14
Value "false" in a Boolean
Success
Y

15
Value "fALse" in a Boolean
Exception
Y

16
Value "null" in an Integer
Exception
Y

17
Value "1" in an Integer
Success
Y

18
Value "1.1" in an Integer
Exception
Y

19
Value "test" in an Integer
Exception
Y

20
Value "null" in a Float
Exception
Y

21
Value "1" in a Float
Success
Y

22
Value "1.1" in a Float
Success
Y

23
Value "test" in a Float
Exception
Y

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 9670

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10169

@blueorangutan package

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✖ debian ✔ suse15. SL-JID 10228

@blueorangutan package

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10471

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-11061)

Hey @winterhazel
I did some testing, overall it looks good, but I've found one case that I think we should address in this PR.

Number
Config
Value
Result

1
storage.cleanup.interval
oasij
Error

2
storage.cleanup.interval
.
Error

3
storage.cleanup.interval
(
Error

4
storage.cleanup.interval
102938120381209381203981239128
Error

5
storage.cleanup.interval

Error

6
storage.cleanup.interval
""
Error

7
storage.cleanup.interval
86400
Ok

8
cpu.overprovisioning.factor
a
Error

9
cpu.overprovisioning.factor
^
Error

10
cpu.overprovisioning.factor
1.1.1
Error

11
cpu.overprovisioning.factor
10928091283012830123810293
OK

12
cpu.overprovisioning.factor
9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999
OK, but this should not be

13
admin.is.allowed.to.deploy.anywhere
1
Error

14
admin.is.allowed.to.deploy.anywhere
0
Error

15
admin.is.allowed.to.deploy.anywhere
a
Error

16
admin.is.allowed.to.deploy.anywhere
FALSE
Error

17
admin.is.allowed.to.deploy.anywhere
TRUE
Error

18
admin.is.allowed.to.deploy.anywhere
true
OK

19
admin.is.allowed.to.deploy.anywhere
false
OK

Test 12 was sucessful, but the number informed is bigger than the maximum value of Floats and Doubles. Double.parseDouble() returns Infinity if the number being parsed would overflow. We should not allow this config value, we should return an error, like what is done in test 4.

Thanks for testing @JoaoJandre. I addressed the issue you pointed out.

@blueorangutan package

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10764

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11158)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53213 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9107-t11158-kvm-ol8.zip
Smoke tests completed. 137 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_secure_vm_migration
Error
135.45
test_vm_life_cycle.py

test_01_secure_vm_migration
Error
135.45
test_vm_life_cycle.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
391.95
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Failure
487.68
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
487.70
test_vpc_redundant.py

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-11181)

@blueorangutan LLtest

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan package

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10964

Merging based on approvals and manual testing https://github.com/apache/cloudstack/pull/9107#issuecomment-2305311036


Matching wrapped exceptions with scalatest intercept

Is it possible with scalatest to match a wrapped exception using intercept? I can't find any usages online.

The answer is that you can intercept the outer exception, and then inspect the cause. Something like:
val intercepted = intercept[OuterExceptionType] { ... }
assert(intercepted.cause.isInstanceOf[InnerExceptionType])
In the future, please ask questions like this on the scalatest-users mailing, as this is a support question not an issue.


import/export apache ignite UUID column type

Description
We have a apache ignite table that uses UUID as primary key. When we try to import the data to another instance, we get a binding  error:
Object parameter[----GUID----] binding not supported

Also I don't see UUID in the data types list.
DBeaver Version
Community Edition 22.1.4
Operating System
Windows Server 2016
Database and driver
Apache Ignite 8.8.13
Steps to reproduce

Create a table with UUID as primary key in one schema
Add a new row in the first table
Create the same table in another schema
Export the data from the first table to the second table

Additional context
No response

The same with Vertica. Should I open another issue for this?


Changes added from a non-github device

I'm adding these updates from a computer that isn't authorized on Github.

Approved


UI Scrolling

Objective

Fixes #8074
Adopts / Supersedes #8104

Solution
Adapted from #8104 and affords the same benefits.
Additions

[x] Update scrolling on relayout (height of node or contents may have changed)
[x] Make ScrollPosition component optional for ui nodes to avoid checking every node on scroll
[x] Nested scrollviews

Omissions

Removed input handling for scrolling from bevy_ui. Users should update ScrollPosition directly.

Implementation
Adds a new ScrollPosition component. Updating this component on a Node with an overflow axis set to OverflowAxis::Scroll will reposition its children by that amount when calculating node transforms. As before, no impact on the underlying Taffy layout.
Calculating this correctly is trickier than it was in #8104 due to "Update scrolling on relayout".
Background
When ScrollPosition is updated directly by the user, it can be trivially handled in-engine by adding the parent's scroll position to the final location of each child node. However, other layout actions may result in a situation where ScrollPosition needs to be updated. Consider a 1000 pixel tall vertically scrolling list of 100 elements, each 100 pixels tall. Scrolled to the bottom, the ScrollPosition.offset_y is 9000, just enough to display the last element in the list. When removing an element from that list, the new desired ScrollPosition.offset_y is 8900, but, critically, that is not known until after the sizes and positions of the children of the scrollable node are resolved.
All user scrolling code today handles this by delaying the resolution by one frame. One notable disadvantage of this is the inability to support WinitSettings::desktop_app(), since there would need to be an input AFTER the layout change that caused the scroll position to update for the results of the scroll position update to render visually.
I propose the alternative in this PR, which allows for same-frame resolution of scrolling layout.
Resolution
Edit: Below resolution is outdated, and replaced with the simpler usage of taffy's Layout::content_size.
When recursively iterating the children of a node, each child now returns a Vec2 representing the location of their own bottom right corner. Then, [[0,0, [x,y]] represents a bounding box containing the scrollable area filled by that child. Scrollable parents aggregate those areas into the bounding box of all children, then consider that result against ScrollPosition to ensure its validity.
In the event that resolution of the layout of the children invalidates the ScrollPosition (e.g. scrolled further than there were children to scroll to), all children of that node must be recursively repositioned. The position of each child must change as a result of the change in scroll position.
Therefore, this implementation takes care to only spend the cost of the "second layout pass" when a specific node actually had a ScrollPosition forcibly updated by the layout of its children.
Testing
Examples in ui/scroll.rs. There may be more complex node/style interactions that were unconsidered.

Showcase

Alternatives

bevy_ui doesn't support scrolling.
bevy_ui implements scrolling with a one-frame delay on reactions to layout changes.

Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to https://github.com/bevyengine/bevy-website/issues/1693 if you'd like to help out.


[Design] Consider exposing CopyAuthorization internal members

In CopyAuthorization, members AccessToken, ResourceId and ResourceRegion are internal, but in Java they're public. Java is considering hiding them as well.

If Java hides them, we can close this issue with no actions.
If Java keeps them public, consider exposing them for API consistency. .NET is inclined to keep them internal.

Java cannot hide their properties due to constraints imposed by their access modifiers.
In .NET, we decided to keep them hidden because they're not very useful to the user. If we get future feature requests to expose these properties, we can always include them as additive changes, which won't break the API.


First Day Of Week not working

Hi,
firstDayOfWeek paramater doesn't work. I try few things:
cvCalendarView.setup(currentMonth, lastMonth, DayOfWeek.MONDAY);
cvCalendarView.setup(currentMonth, lastMonth, DayOfWeek.of(1));
DayOfWeek firstDayOfWeek = WeekFields.of(DayOfWeek.MONDAY, 7).getFirstDayOfWeek();
cvCalendarView.setup(currentMonth, lastMonth, firstDayOfWeek);
Thank you for this great library! :)

Hello, could you explain what you mean by "it does not work"? Are the days in a month not generated?

Sorry, my mistake. Close this and thanks again for great library.


Toast transparency causing issue with text in background

I haven't checked if this is happening in light mode as well, but I've seen a few things using opacity in dark mode (borders, dividers, etc), so I wouldn't be surprised if this was a chakra ui issue on the dark mode default theme.

It seems to be expected: https://github.com/chakra-ui/chakra-ui/issues/3861
The solution seems to be adding variant: "solid" in the toast call argument. I don't like how it looks in light mode with solid, so I'll go with the following for new toasts.
import { useColorModeValue } from "@chakra-ui/react";
const toastVariant = useColorModeValue("subtle", "solid");

toast({
  description: "Can't get the message to sign. Please try again",
  status: "error",
  variant: toastVariant,
});

An alternative workaround that allows you to use the subtle, top-accent and left-accent variants in dark mode while keeping a slightly tinted background based on the status:
import type { FunctionComponent } from 'react';
import { useCallback } from 'react';
import { Button, VStack, useColorModeValue, useToast } from '@chakra-ui/react';

const variants = [ 'subtle', 'top-accent', 'left-accent' ] as const;

export const MyComponent: FunctionComponent = () => {

  const containerStyle = useColorModeValue(undefined, {
    bg: 'chakra-body-bg',
    rounded: 'md',
  });

  const toast = useToast();

  const showToast = useCallback<(variant: typeof variants[number]) => void>((variant) => {
    toast({
      containerStyle,
      variant,
      title: `Example ${variant} toast`,
    });
  }, [ containerStyle, toast ]);

  return (
    <VStack>
      {variants.map((variant) => (
        <Button key={variant} onClick={() => showToast(variant)}>Show {variant} Toast</Button>
      ))}
    </VStack>
  );

};


Clarification for semicolon as a statement ender

Hello again @sandersn 👋, I'm working on the second exercise "Make semicolon a statement ender, not statement separator." I found an approach but am unsure if it's the right way to go. I just wanted to check with you about your thoughts on this.
Here's the implementation I've done https://github.com/imteekay/mini-typescript/pull/7
My idea is:

Rather than parsing statements with the semicolon as the separator, we can parse all statements until it gets to the EOF node.
Return the EOF node similar to how it works in TS*
When parsing, if it gets to the semicolon (and it's not an empty statement**), the parser skips the semicolon and starts parsing the next statement

*see example

source code
ast

**empty statements should have at least two semicolons together (is it a fair statement?). In the example above, we can see the empty statement is there because it has two semicolons between variable declarations and at the end of the ast, it has the eof node.
Thanks 🙇

Merged the PR https://github.com/imteekay/mini-typescript/pull/7


Initial update for patch 5.1

I took the liberty of making an initial swipe at updating for patch 5.1.
There were certain things I wasnt sure how to handle.  ie. the new traits which boost basic and rapid synth.  So I went with the approach of treating them as a different skill but with a display name of the lower level version.
I also did not obtain any new images or modify any.
This is more intended to be something I and others can use until doxxx get's back from vacation and does things better. @doxxx feel free to use this as a starting spot when you get back if you like.
If anyone finds issues (via cloning and running locally yourself), please feel free to post a comment to the PR I will try and address.

Can't solve for anything. Stuck like this:

I tried to clear cookies and switch browser. Doesn't help.

setting level in crafter attribute to anything higher than 70 makes it unusable
works okay when 70 or below

Please hit F12 and copy the console output error and post it.

worker.js:36 TypeError: Cannot read property 'shortName' of undefined
at ApplySpecialActionEffects (ffxivcraftmodel.js:631)
at UpdateState (ffxivcraftmodel.js:776)
at MonteCarloStep (ffxivcraftmodel.js:1067)
at MonteCarloSequence (ffxivcraftmodel.js:1254)
at start (worker.js:191)
at self.onmessage (worker.js:21)
self.onmessage @ worker.js:36
worker.js:40 Uncaught TypeError: Cannot read property 'logOutput' of undefined
at self.onmessage (worker.js:40)

I got this error when I was trying to solve for my lv70 weaver.

More changes made.  Thanks for testing and if you see other issues, please post your crafters stats and whether or not its a specialist as well as what you're attempting to craft.  In the case above, it was due to having a specialist.  As my highest crafter is 53, I don't have specialization and didnt know what it provides (+15 cp) until today.

Another problem, the recipes durability is 70. Master's Mend should be use after 6 action, not 7 as it will fail if durability reach 0.

/ac "Reflect" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Master's Mend" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Master's Mend" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/echo Macro #1 complete <se.1>

first of all, thanks for putting up a temp site for this.
some things I noticed:

looks like its using the old CP cost for Rapid Synth for later levels
Byregot's Blessing is missing
Final Appraisal is missing
if specialist is checked it still gives the +15 CP (which is no longer a thing)

Awesome! Thanks for doing this!
On Nov 3, 2019, 1:36 AM +0000, Joseph Werle<EMAIL_ADDRESS>wrote:

first of all, thanks for putting up a temp site for this.
some things I noticed:
• looks like its using the old CP cost for Rapid Synth for later levels
• Byregot's Blessing is missing
• Final Appraisal is missing
• if specialist is checked it still gives the +15 CP (which is no longer a thing)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

first of all, thanks for putting up a temp site for this.
some things I noticed:

looks like its using the old CP cost for Rapid Synth for later levels
Byregot's Blessing is missing
Final Appraisal is missing
if specialist is checked it still gives the +15 CP (which is no longer a thing)

According to the patch notes:
Soul of the Crafter now also increases CP by 15. is this something different than being a specialist?
I'm leaving doxxx to deal with final appraisal and heuristic  related changes.  He understands it alot better than the 2 hours I've spent looking at this code.  Even the way I've made changes to muscle memory and reflect likely arent entirely proper and may be impacting how the final results come out.  But its all better than the nothing that we have currently ;p
blessing and rapid synth fix.

Hello I am level 80 in all crafting areas and am happy to help and test. Tell me what you want tests and I can give you results.
One thing of note is that the progress and quality numbers on the simulator window are wrong.
My crafter (craft 2175, control 2009) says in the crafting pane for a level 80 item  (dwarven mythril hatchet) progress 353 and quality 377. the simulator says progress 264 and quality 277.
for my specialist (same gear) (craft 2195, control 2029)  Dwarven mythril ring has progress 356 and quality 381 in game,  simulator says 356, 381

Apology for the previously incorrect message. I had imported my stats to the test site wrong.
However I am a level 80 crafter happy to help with testing! Tell me how I can can be helpful.

the thing with soul of the crafter is that its always there so its just applied to your base stats, which is likely the value people will put into the tool (i.e. if my CP for a non-specialist is 460 in the character menu, it will be 475 on a specialist in the character menu)

i see.  so does it serve any purpose to have the option to select that you have a craft job specialized then?

in my opinion it doesn't since the only specialist action you have now is 'Careful Observation' (but costs a crafter's delineation to use and not entirely sure how different it is from 'Observe' aside from the 0 CP cost)

/ac "Reflect" <wait.3>
/ac "Ingenuity" <wait.2>
/ac "Delicate Synthesis" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Ingenuity" <wait.2>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Delicate Synthesis" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Ingenuity" <wait.2>
/ac "Prudent Touch" <wait.3>
/ac "Byregot's Blessing" <wait.3>
/echo Macro #1 complete <se.1>

Ingenuity count down is 5. And it will fail if use too close to each other like this (you have to wait the the buff to expire before refresh it.

The new Custom Deliveries recipes for 5.1 are missing.

no skill call "倹約II" is inside the game.
it should be call "長期倹約" LV:47 CP:98
And also the icon of this skill is wrong.(I know it is just a test version sorry)
Also found that not all the skill is translated in Optimizer so try to provide that skill's Japanese name.
Trained Eye -> 匠の早業 LV:80 CP:250
Reflect -> 真価 LV:69 CP:24

/ac "Reflect" <wait.3>
/ac "Ingenuity" <wait.2>
/ac "Delicate Synthesis" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Ingenuity" <wait.2>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Delicate Synthesis" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Ingenuity" <wait.2>
/ac "Prudent Touch" <wait.3>
/ac "Byregot's Blessing" <wait.3>
/echo Macro #1 complete <se.1>

Ingenuity count down is 5. And it will fail if use too close to each other like this (you have to wait the the buff to expire before refresh it).

I don't believe I've done anything in my changes which would warrant this behavior.  ie. i believe it likely that this behavior already existed.

no skill call "倹約II" is inside the game.
it should be call "長期倹約" LV:47 CP:98
And also the icon of this skill is wrong.(I know it is just a test version sorry)
Also found that not all the skill is translated in Optimizer so try to provide that skill's Japanese name.
Trained Eye -> 匠の早業 LV:80 CP:250
Reflect -> 真価 LV:69 CP:24

Sorry but as I dont read or write Japanese, I'm not going to make translation changes as part of my PR.  Please feel free to write this up as a different bug/issue or submit your own PR.

in my opinion it doesn't since the only specialist action you have now is 'Careful Observation' (but costs a crafter's delineation to use and not entirely sure how different it is from 'Observe' aside from the 0 CP cost)

I have removed the 15 cp assuming people will inherently put the CP into the tool including this value.

Ingenuity's cost is wrong, it has been lowered to 22 CP

When importing a settings file that included the Cross-Class Action Macro setting enabled (from the master branch, not this pull request), the section for that macro still exists on the solver page, but cannot be unset. Would recommend clearing the flag as part of import or removing the section for the macro in the solver tab.

Sorry for the wait, I came down with the flu on vacation :P and took a long time to recover. How is this coming?

Sorry for the wait, I came down with the flu on vacation :P and took a long time to recover. How is this coming?

It's functional so far. Not sure how good it is on latest contents since I didn't participate in those. But on 80* or lower it seem to works fine.

I've addressed most functional issues with the 5.1 change; at least those that have been reported.  I didn't want to combine any item changes into it as I felt the PR as probably large enough.  I also sent you a message on linkedin, not sure if you saw it.  This also doesnt contain any icon changes.  I tried using the item generator repo but the output didnt land in the same format as what is used by this tool, so not sure if i did something wrong or perhaps it serves a different purpose.

@ryan-dyer-sp I've removed all the commented out code and fixed a few other things. Please have a look and let me know if you're okay with these changes, then I'll merge the PR. After that, further fixes and tweaks can be made in new PRs of hopefully smaller scope. :)

one minor comment, otherwise it all looks fine to me.

Thank you for all your hard work!

Uploaded to beta site.

beta site?

ffxiv-beta.lokyst.net
On Dec 2, 2019, 8:37 PM -0500, ryan-dyer-sp<EMAIL_ADDRESS>wrote:

beta site?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


feat(cli.rs): add tests to node binding, delete cli.js

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

might be the time to rename cli.rs to just cli since cli.js is gone now?

might be the time to rename cli.rs to just cli since cli.js is gone now?

@amrbashir the folder name yeah I agree, but we still need a convention to name those two so I think the current one is ok.

yeah I was referring mainly to the folder but we can also refer to them as cli and cli/node or cli/npm as it is now a really thin wrapper.


Use containerd as cri to join the k8s cluster, the container fails to start

Description

I got an ARM platform development board from a partner, and the partner pre-installed a simplified version of Linux on the development board. My purpose is to add this ARM development board to the completed K8S cluster and work normally.
I started the containerd and kubelet of arm on it,  I will show my startup parameters later. After starting kubelet and containerd, the node successfully joined the k8s cluster, and the node is in the ready state
Because I cannot start kubelet and containerd without using the CNI plug-in, I added the CNI configuration file and binary startup file on this Linux. If there is a way to start kubelet and containerd without using the CNI plug-in, I hope You can tell me the way
This streamlined version of Linux does not have init programs such as systemd and SysV. No package management, no packages can be installed.  There may be other differences from ordinary Linux, but I didn't find it. Its kernel version is 4.9.37

The error i encountered

Error output using kubectl describe kube-proxy -n kube-system
Error: failed to create containerd task: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"process_linux.go:415: setting cgroup config for procHooks process caused \\\"failed to write \\\\\\\"100000\\\\\\\" to \\\\\\\"/sys/fs/cgroup/cpu/kubepods/besteffort/podc66a5327-cb13-4415-932e-4054fc9a1a85/kube-proxy/cpu.cfs_period_us\\\\\\\": open /sys/fs/cgroup/cpu/kubepods/besteffort/podc66a5327-cb13-4415-932e-4054fc9a1a85/kube-proxy/cpu.cfs_period_us: permission denied\\\"\"": unknown

Configuration files and startup parameters of kubelet and containerd

kubelet startup parameters
kubelet --kubeconfig=/opt/kubernetes/kubelet.conf --pod-infra-container-image=<IP_ADDRESS>/google_containers/pause-arm64:3.0 --cluster-dns=<IP_ADDRESS> --cluster-domain=cluster.local --fail-swap-on=false --container-runtime=remote --container-runtime-endpoint=unix:///run/containerd/containerd.sock

Configuration file of containerd
root = "/var/lib/containerd"
state = "/run/containerd"
oom_score = 0

[grpc]
  address = "/run/containerd/containerd.sock"
  uid = 0
  gid = 0
  max_recv_message_size = 16777216
  max_send_message_size = 16777216

[debug]
  address = ""
  uid = 0
  gid = 0
  level = ""

[metrics]
  address = ""
  grpc_histogram = false

[cgroup]
  path = ""

[plugins]
  [plugins.cgroups]
    no_prometheus = false
  [plugins.cri]
    stream_server_address = "<IP_ADDRESS>"
    stream_server_port = "0"
    enable_selinux = false
    sandbox_image = "<IP_ADDRESS>/google_containers/pause-arm64:3.0"
    stats_collect_period = 10
    systemd_cgroup = false
    enable_tls_streaming = false
    max_container_log_line_size = 16384
    disable_proc_mount = false
    [plugins.cri.containerd]
      snapshotter = "overlayfs"
      no_pivot = false
      [plugins.cri.containerd.default_runtime]
        runtime_type = "io.containerd.runtime.v1.linux"
        runtime_engine = ""
        runtime_root = ""
      [plugins.cri.containerd.untrusted_workload_runtime]
        runtime_type = ""
        runtime_engine = ""
        runtime_root = ""
    [plugins.cri.registry]
      [plugins.cri.registry.mirrors]
        [plugins.cri.registry.mirrors."docker.io"]
          endpoint = ["https://registry-1.docker.io"]
        [plugins.cri.registry.mirrors."<IP_ADDRESS>"]
          endpoint = ["http://<IP_ADDRESS>"]
    [plugins.cri.x509_key_pair_streaming]
      tls_cert_file = ""
      tls_key_file = ""
  [plugins.diff-service]
    default = ["walking"]
  [plugins.linux]
    shim = "containerd-shim"
    runtime = "runc"
    runtime_root = ""
    no_shim = false
    shim_debug = false
  [plugins.opt]
    path = "/opt/docker/bin"
  [plugins.restart]
    interval = "10s"
  [plugins.scheduler]
    pause_threshold = 0.02
    deletion_threshold = 0
    mutation_threshold = 100
    schedule_delay = "0s"
    startup_delay = "100ms"

containerd version
containerd github.com/containerd/containerd v1.2.13 7ad184331fa3e55e52b890ea95e65ba581ae3429

Some of my own understanding and attempts

I use the same configuration in a normal Linux environment, kube-proxy and other pods can run normally. This problem should come from this condensed version of Linux, but I don’t know what determines it

tried to give the kube-proxy the maximum authority to the pod, but the error still exists, the following is the relevant configuration in my kube-proxy manifest file

securityContext:
  allowPrivilegeEscalation: true
  privileged: true
  runAsNonRoot: false

I entered the directory in the error message, /sys/fs/cgroup/cpu/kubepods/besteffort/podc66a5327-cb13-4415-932e-4054fc9a1a85/ This part of the directory exists, and the subsequent directory does not exist. I am not sure that the subsequent directory should Who created it

@HirazawaUi could you provide information about ls -al /sys/fs/cgroup/cpu/ ? thanks

what version of runc


👌 IMPROVE: Pixel-perfect Active Tab Border — Fix #48765

Makes the active tab bottom border pixel-perfect by removing the border from the right and left on editor tabs CSS. FIX: #48765.
BEFORE ⬇

AFTER ⬇

This was pretty tricky. And it's a less aggressive version. We could add the following code:
.monaco-workbench > .part.editor > .content > .one-editor-silo > .container > .title .tabs-container > .tab.active + .tab {
	border-left: none !important;
}

This removes the left border from the tab next to an active tab. But it leads to a 1px movement of tabs and feels like a jerky behavior. So, I am sticking with the less aggressive version for now.

Thanks, but a fix like that is waiting to be pushed already in the ben/editor branch end of week.

@ahmadawais sorry for that, I appreciate your intent 👍


LinkFix: windows-driver-docs-ddi (2022-06) 3rd try

This PR is the result of running a Link Repair script on the included content. This script is primarily being run to clean up links to function correctly in Air Gapped Clouds (AGC). Here's a breakdown of what the script that generated the changes in this PR fixes:

docs.microsoft.com Fully Qualified Domain Name (FQDN) Links to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not

azure.microsoft.com/documentation/articles that reflect to Docs to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not

All known flavors of MSDN/TechNet domains (we know of 8 or 9 now) that reflect to Docs to either Relative (if in same Repo/DocSet/ContentSet) and Site Relative if not

This also includes cleanup of the appended query string for MSDN (redirectedfrom=MSDN).

Fixes articles that are redirected in .openpublishing.redirection.json and updates the link to the current final location (this has a lot of customer usability fixes).

Please note the Contributor Guide: Links has been updated with the following link-type preference order:

By order of preference, links hosted on Docs should be Relative if they are in the same repository and docset. If they are in a different docset, even if in the same repository, they should be Site Relative. Links to content hosted on Docs shouldn't use a complete URL, otherwise known as Fully Qualified Domain Names (FQDN). Using a complete URL from Docs to other content on Docs will cause that link to be non-functional in air-gap environments.

#sign-off

@DJm00n @j0le @jasonepperly @tedhudek can one of you assist with approving and merging this PR? Thanks!


Update Readme with new maintainer

Update Readme with new maintainer as well as creator credits.

Ah I was about to create a pull request too :)
I wasn't sure whether to include links to your new projects. I'd be totally fine to keep those in, so up to you.


XAudio2.7 and .NET Core

I am trying to create a XAudio2.7 audio device using the new .NET Core 5 workflow (I used the console app package template in VS2015 RC).
I go and reference SharpDX.XAudio2 package through NuGet/package manager and I am unable to retrieve the XAudio2Version type. I can create a XAudio2 object while debugging fine, but am unable to specify the version to use. It seems to be hardcoded to XAudio2.8 when looking through the assembly with ILSpy. It strange because the source tells a completely different story https://github.com/sharpdx/SharpDX/blob/master/Source/SharpDX.XAudio2/XAudio2.cs#L64. Considering that .NET Core 5.0 runs on Windows 7 is it possible to have an option to allow the usage of XAudio2.7 for the .NETCore/PCL distribution of SharpDX?
The PCL/NETCore distribution of SharpDX will most definitely be used by some developers outside the WinStore now with .NET Core 5 becoming usable, especially for people looking to develop a cross platform engine which makes use of multiple API's depending on the platform.
I hope this is possible, thanks

I forgot to mention this is on the latest alpha <IP_ADDRESS> version

I figured out the reason why XAudio2Version type does not exist is because the NuGet packets have not been updated since the Version2_7 option was added to XAudio. The latest version still won't allow you to initiate a Version2_7 XAudio2 device however, see: https://github.com/sharpdx/SharpDX/blob/master/Source/SharpDX.XAudio2/XAudio2.cs#L80.

Sorry for the state of the 3.0 compilation process, still didn't have time to work on it for several weeks.
If you download the latest binary zip from sharpdx.org, you should get the latest build against the sources. Nuget 3.0 is not up-to-date (don't remember exactly why)

Thanks for the reply, regarding getting the latest binaries. I already have those, however it is still impossible to create a XAudio2.7 device on the NETPortable library of SharpDX.XAudio2 due to the link I pasted above (https://github.com/sharpdx/SharpDX/blob/master/Source/SharpDX.XAudio2/XAudio2.cs#L80) which is what this issue is about. I realize you have been busy as of late which is why I wanted to try attempt to solve this myself since it looks pretty straight forward. The problem lies however with how complex it is to compile SharpDX and really think it should be cleaned up/simplified and explained somewhere so others can contribute easier.

Hm, not sure to understand... Both SharpDX Desktop and Store assemblies have been compiled with PCL.So the SharpDX Desktop assemblies should be PCL (as setup in the build file, assuming that SharpDXDesktopOnly is false, which should be the case afair)
What you can't have is a general PCL library that supports both 2.7 and StoreApps.
For the compilation, well, It was never easy, as SharpDX had to support many different platforms that were coming with different headers files...etc. So in the past, It requires to install many SDK (DirectX SDK, Windows 7 SDK, Windows 8 SDK). In order to support Direct3D12, the compilation process has been simplified, so we just rely on Windows 10 SDK, but because the SDK is not yet stabilized (there is no stable version of it so far) we have still to deal with this problem for a few months.
I'm currently working on moving SharpDX.org website to a github-pages so that SharpDX users will be able to more easily contributes to the documentation.

Moving to github pages sounds like a good idea, many docs on the SharpDX.org are outdated. Also I did not even realize the Desktop builds were PCL supported so this might not even be an issue. I was the one to misunderstand sorry, I thought the StoreApp was the PCL libraries, not 100% sure what NuGet was giving me anyway. I will test the latest against .NET Core 5 today.

Can't believe I missed it, all the Desktop binaries are NETPortable! Case closed.


Polish CalDAV Sync

The synchronization with a remote server is not yet ready to be used reliably.
To be done, work in progress:

[ ] multiple daily events
[ ] entry header (summary)
[ ] fix bug where tokenfile is removed when offline

   curl_easy_perform() failed: Couldn't resolve host name
   Unable to fetch principal due to invalid tokenfile. Removing tokenfile '~/.diary-token'.

[x] the spinner top right sometimes looses the description (example, on sign-in request when auth url is displayed)
[ ] slow performance when uploading the whole year (explore mulit
[ ] sporadic segfaults when uploading multiple events with sync all ("S" shortcut)
[ ] memory issues due to error in pointer handling (malloc/free) and the like
[ ] length of remote description too long, random bytes read
[ ] sporadic corruption of local files (not unfolded but replaced)

valgrinding my way through the app. Found two obvious issues so far:

https://github.com/in0rdr/diary/commit/5ff400
https://github.com/in0rdr/diary/commit/98ff1e

Many other sporadic segfaults still exist in the caldav/syncing code.


🐛 [BUG]: edge.sourceNode is not updated by updateEdge when edge.source is updated

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
I use Events API.
const { onEdgeUpdate, updateEdge } = useVueFlow();
onEdgeUpdate((params) => {
  updateEdge(params.edge, params.connection)
})

However, updateEdge only updates edge.source but not edge.sourceNode.
Expected Behavior
Both edge.source but not edge.sourceNode should be updated.
Steps To Reproduce
git clone git@github.com:ljw20180420/vueFlowBug.git
cd vueFlowBug
npm install
npm run dev

In the browser,
Neglect the breakpoint at start up.
Move the source of the edge from `node 1` to `node3`.
In the console, `edge.source` becomes `node 3`, while `edge.sourceNode.id` is still `node 1`.

Relevant log output
No response
Anything else?
No response

Thanks for the report, will be fixed in the next patch.

Fixed with 1.41.6


Code quality

This pull request improves code quality and running time.  I have also improved the (internal) documentation.  You previous comments have been very helpful.  If there are further comments that I should incorporate into the code, I would be happy to receive them.  Thank you!

Sorry for having committed several bug fixes for the tests but I cannot get the tests running on my own hardware.  However, the tests work now as expected.

Looks good. Just tell me when you're satisfied with the PR and I will merge it. If you want to get rid of the "unnecessary" commits you could rebase + force-push them; however, this is not strictly necessary to get the PR merged.

Great to hear. In general, I am satisfied with the PR. It might happen that I have new insights of how to improve the code, but I do not expect it at the very moment. (I still do not understand completely why the algorithm does not become faster on 4 cores compared to 2 cores.) For me, it would be fine to just proceed with the commits as they are. If you prefer that I only create one commit, I would just clone again, copy the four files that I changed and commit again. Let me know what you prefer. – You see, I kept my promise to improve the code after the first merge!

Yes, thank you. The code is in a good shape now, so I am merging this.


Support for reStructuredText (*.rst)

Would it be possible to support reStructuredText or other markup languages also supported on GitHub?

Maybe this could be of help.
https://pypi.python.org/pypi/restview


SNAP-2601: Display Tables Schema on Snappy UI

Changes proposed in this pull request
Feature Request:

Display tables schema in Tables tabular view.
Provide user control on click of which table schema is shown or hide.

Changes:

Code changes to maintain schema details map in the SnappyRegionStats and SnappyExternalTableStats.

Patch testing

Tested Manually

Is precheckin with -Pstore clean?

Not yet run

ReleaseNotes changes

NA

Other PRs
SnappyData: https://github.com/SnappyDataInc/snappydata/pull/1172
Spark: https://github.com/SnappyDataInc/spark/pull/125

As per discussion in huddle (16th Nov 2018), Idea of displaying table schema details needs re-thinking or more specifically displaying all details specific to Table on completely new page/tab can needs to be considered. This needs more discussion.
For now closing this and relevant PRs( SnappyData: SnappyDataInc/snappydata#1172, Spark: SnappyDataInc/spark#125 ).


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1487

Questions ?
Please refer to the Backport tool documentation


My problem with my custom character in the mod templete not working

Describe your problem here.
I have compiled psych engine 0.7.1 and I have an issue where I made a mod template add the png and xml files for my character and it doesn't show in the character editor and if I use a character json in the mod templete too it won't show on the list and I tried seeing if pressing the red template button in the character Editor but it won't show either
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

It’s because your character images doesn’t exist. But idk how to fix it. I have the same problem too.


[improve][io] Debezium sources: Support loading config from secrets

Motivation
Currently the Debezium sources don't support loading sensitive configuration from secrets.
Modifications
Most sources can rely on IOConfigUtils.loadWithSecrets because they provide a specific Config class with FieldDoc annotations. The Debezium sources work differently because there is no specific Config class but rather just a Map with some basic validation that is passed to Debezium. Therefore we need to directly get the secrets from the sourceContext.
Most of the Debezium sources rely on the same config properties (database.user, database.password) to configure the connector so I decided to move the secret-handling code into the abstract DebeziumSource class that all the individual connectors inherit from. There are exceptions to this, such as the MongoDB source, which uses another set of config properties (e.g. mongodb.user instead of database.user), these sources will have to call the secret-handling code by overriding the open method.
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
I would be open to adding a unit test as well, but I feel it does not add a lot of value because the sourceContext already has unit tests for this functionality.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/alpreu/pulsar/pull/4

/pulsarbot rerun-failure-checks

Codecov Report

Merging #19004 (9d5a50c) into master (feb3cb4) will increase coverage by 3.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #19004      +/-   ##
============================================
+ Coverage     46.35%   49.45%   +3.09%
+ Complexity     8939     7008    -1931
============================================
  Files           597      394     -203
  Lines         56858    42916   -13942
  Branches       5905     4384    -1521
============================================
- Hits          26357    21224    -5133
+ Misses        27616    19384    -8232
+ Partials       2885     2308     -577

Flag
Coverage Δ

unittests
49.45% <ø> (+3.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../pulsar/broker/service/SharedConsumerAssignor.java
3.70% <0.00%> (-64.82%)
:arrow_down:

...apache/pulsar/broker/service/EntryAndMetadata.java
0.00% <0.00%> (-40.75%)
:arrow_down:

...lsar/broker/loadbalance/impl/ThresholdShedder.java
3.27% <0.00%> (-27.05%)
:arrow_down:

...che/pulsar/broker/intercept/BrokerInterceptor.java
0.00% <0.00%> (-13.05%)
:arrow_down:

...tent/NonPersistentDispatcherMultipleConsumers.java
40.74% <0.00%> (-12.35%)
:arrow_down:

...apache/pulsar/broker/service/TopicListService.java
40.80% <0.00%> (-12.00%)
:arrow_down:

...sistent/PersistentDispatcherMultipleConsumers.java
49.47% <0.00%> (-8.51%)
:arrow_down:

...org/apache/pulsar/broker/loadbalance/LoadData.java
58.33% <0.00%> (-8.34%)
:arrow_down:

...ction/buffer/impl/TransactionBufferClientImpl.java
76.74% <0.00%> (-4.66%)
:arrow_down:

.../buffer/impl/TransactionBufferClientStatsImpl.java
82.00% <0.00%> (-4.00%)
:arrow_down:

... and 250 more


Deprecate this module in favor of Terraform data source availability_zones?

I think that Terraform supports this behavior natively now via the data source availability_zones.
Thoughts on deprecating this module?

Totally agree. Closing #12


Server Side Apply: check only for > v1.22

CheckSSAEnabled for version > 1.22 should always return true since it went GA in v1.22
Fixes: #37946

Hi @Pawan-Bishnoi. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ymesika can you mark this /ok-to-test

/ok-to-test

@Pawan-Bishnoi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c5bc258729e6ea67938c967990339a130496fd23
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika can you mark this /ok-to-test

you should apply to join community to skip this.
like this PR https://github.com/istio/community/pull/983

@Pawan-Bishnoi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Pawan-Bishnoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests-arm64

gencheck_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Pawan-Bishnoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests-arm64

gencheck_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test gencheck

unit-tests_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Pawan-Bishnoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests-arm64

unit-tests_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests

gencheck_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Pawan-Bishnoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests

gencheck_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test gencheck

unit-tests-arm64_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Pawan-Bishnoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test gencheck

unit-tests-arm64_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests-arm64

unit-tests_istio
3d77dd8b4c3bef0e6e5a9c82a0c6d1fea16c05a5
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Disabled SSA while in TestMode. Please let me know if that is not the right way of moving forward.
https://github.com/istio/istio/blob/f21f0dfe71914bc9f647713a2eaefdadc86b5228/operator/pkg/helmreconciler/common.go#L53-L54

@dhawton it is waiting for your approval. Can you please review and let me know if there are additional comments.


[MODFISTO-461] - Release v8.5.1

Purpose

Approach

Learning
MODFISTO-461
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all the appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Did you modify code to call some additional endpoints?

[ ] If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Abdulkhakimov:x: Dzmitry_ButramyouDzmitry_Butramyou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature Parity: Support TLSRoute and VPC Lattice TLS_PASSTHROUGH feature

Solved by #643,  #650, #654  and TLSRoute released by the version v1.0.5


Add MLP & QLoRA Fused Ops and Kernels, Mixtral

Completing more items in #25

running a set of benches now. will merge after complete