ConfiguratorException when using casc credentials with 1.0-beta-13/14

When starting jenkinsfile-runner with credentials present in the casc yaml, an exception occurs during launch:
2020-07-28 11:42:58.176+0000 [id=28]    SEVERE  jenkins.InitReactorRunner$1#onTaskFailed: Failed ConfigurationAsCode.init
io.jenkins.plugins.casc.ConfiguratorException: No configurator for the following root elements credentials
        at io.jenkins.plugins.casc.ConfigurationAsCode.invokeWith(ConfigurationAsCode.java:713)
        at io.jenkins.plugins.casc.ConfigurationAsCode.checkWith(ConfigurationAsCode.java:755)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:740)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:616)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configure(ConfigurationAsCode.java:298)
        at io.jenkins.plugins.casc.ConfigurationAsCode.init(ConfigurationAsCode.java:290)
Caused: java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:104)
Caused: java.lang.Error
        at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:110)
        at hudson.init.TaskMethodFinder$TaskImpl.run(TaskMethodFinder.java:175)
        at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
        at jenkins.model.Jenkins$5.runTask(Jenkins.java:1131)
        at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
        at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
        at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

The configuration yaml:
credentials:
  system:
    domainCredentials:
      - credentials:
          - UsernamePasswordCredentialsImpl:
              scope: GLOBAL
              id: sample_credential
              username: sample_user
              password: sample_password

This constellation still worked with beta-12.
Am I missing some config change or required plugin?
plugins.txt

@bparzella your plugins.txt is missing versions, so it is hard to say for sure which ones are actually installed. Do you use the --plugins parameter? And which Jenkins core version do you use?
On the investigation side, the credentials category configurator relies on some class locations in https://github.com/jenkinsci/configuration-as-code-plugin/blob/02ca4728571a26465339742f532c9e50fe629b07/plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java#L124-L132 . If the com.cloudbees.plugins.credentials.CredentialsProviderManager$Configuration class is moved, it will lead to the reported behavior. At the same time the class is still there: https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/CredentialsProviderManager.java#L338-L345 . CC @timja @jetersen just in case I am missing something

Need more logs, probably the credentials plugin failed to load for some reason

I use this plugins.txt with the -p parameter, so all the plugins are latest. The core is also the one jenkins-runner downloads (No explicit version has been selected, using latest LTS. Running pipeline on jenkins 2.235.3). The operating system is Windows.
I attached a logfile, but I don't know if it provides the information needed. If not, I need a hint on how to create a useful log file.
jenkins-runner.log

Uhm:
2020-07-28 14:10:12.659+0000 [id=38]	FINER	hudson.ExtensionList#load: Loading ExtensionList 'hudson.ExtensionFinder' from
java.lang.Throwable: Only present for stacktrace information
	at hudson.ExtensionList.load(ExtensionList.java:378)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:317)
	at hudson.ExtensionList.getComponents(ExtensionList.java:183)
	at jenkins.model.Jenkins$6.onInitMilestoneAttained(Jenkins.java:1161)
	at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:85)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.lambda$onAttained$3(ReactorListener.java:102)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.run(ReactorListener.java:109)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:102)
	at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:177)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
2020-07-28 14:10:13.634+0000 [id=38]	FINE	hudson.ExtensionFinder$Sezpoz#scout: Failed to scout com.cloudbees.plugins.credentials.casc.CredentialsRootConfigurator
java.lang.ClassNotFoundException: io.jenkins.plugins.casc.RootElementConfigurator
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
Caused: java.lang.NoClassDefFoundError: io/jenkins/plugins/casc/RootElementConfigurator
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:405)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
	at net.java.sezpoz.IndexItem.element(IndexItem.java:134)
Caused: java.lang.InstantiationException
	at net.java.sezpoz.IndexItem.element(IndexItem.java:146)
	at hudson.ExtensionFinder.getClassFromIndex(ExtensionFinder.java:746)
	at hudson.ExtensionFinder.access$900(ExtensionFinder.java:90)
	at hudson.ExtensionFinder$Sezpoz.scout(ExtensionFinder.java:731)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:340)
	at hudson.ExtensionList.load(ExtensionList.java:381)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:317)
	at hudson.ExtensionList.getComponents(ExtensionList.java:183)
	at jenkins.model.Jenkins$6.onInitMilestoneAttained(Jenkins.java:1161)
	at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:85)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.lambda$onAttained$3(ReactorListener.java:102)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.run(ReactorListener.java:109)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:102)
	at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:177)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

This extensive log output is only displayed when I try to start with log output for level FINER, with normal logging only the message from my first post is printed.
Am I missing something?

It would be possible to use even higher logging level to capture the plugin loading sequence. The issue is actually with the JCasC classloading, but I am not sure what happened. It might be related to different classloaders
@bparzella I will try to reproduce it locally with published binaries

UPD: I was unable to reproduce it. I suspect plugin version conflicts. JCasC is currently included by default into JFR, and hence it will use the JCasC version from the bundle. I consider detaching JCasC and using it only inside Vanilla

@bparzella are you still interested in the issue? As I said above, I was not able to reproduce it

I tried both, the latest version and removed the CasC from the plugin list but nothing changed.
What else can I do to find the source of this problem? Could it be the java version? Could it be related to windows?
As I am on holiday at the moment, I can run further tests from the beginning of september.

I am running JFR on Windows as well, so unlikely. It might be just related to the JFR version quirks.

So I did some more testing and I created a minimal example that reproduces the error for me.
Background: in my use case the pipeline uses credentials, which are defined in the casc yaml.
So if I have the casc plugin present in the plugins.txt (which was okay before beta 13), I get the error I reported initially. This is how the attached example is set up.
If I remove the casc plugin from the plugins.txt, there seems to be an issue, loading the credentials from the casc yaml:
[Pipeline] Start of Pipeline
[Pipeline] node
Running on Jenkins in d:\UserData\z0046afz\src\jfr_test\workspace
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Declarative: Checkout SCM)
[Pipeline] checkout
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: sample_credential
Finished: FAILURE

(This error is the same in beta 12.)
To reproduce this error with the example, simply remove casc from the plugins.txt.
The Example:
A script for downloading the JFR jar is present in the install folder, the jfr_test.bat runs JFR with plugins, config and Jenkinsfile.
jfr_test.zip

Are there any news on this one? Are there any clarifications required?

Sorry, I missed the previous message due to my vacation @bparzella . I will try to take a look

I face the exact same issue.
As an additional info, I can mention that I don't use the Vanilla image, but beta-17 version of the jenkinsfile-runner jar file.
Then for the plugins folder, I copied it from a Jenkins master docker container built from scratch on my local machine, in which I installed all the plugins, including JCasC from the UI.

I just tried beta19 and it seems to be working.
Any updates? If not I'll close the issue.


2022-11-26 14:44:40.980 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.980 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.980 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.981 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.981 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.981 - debug: dysonairpurifier.0 (7371) Data received from dyson API: ""
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.981 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0000"
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.981 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.981 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0000"
2022-11-26 14:44:40.982 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.982 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.982 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0000"
2022-11-26 14:44:40.982 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.982 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.982 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.982 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.982 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.982 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.983 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.983 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.983 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0003"
2022-11-26 14:44:40.983 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.983 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.983 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0000"
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.984 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.984 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.984 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "="
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.984 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.984 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.985 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "�"
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.985 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0001"
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.985 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0000"
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
2022-11-26 14:44:40.985 - debug: dysonairpurifier.0 (7371) Data received from dyson API: "\u0000"
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Device with serial number [undefined] not added, hence it is not supported by this adapter. Product type: [undefined]
2022-11-26 14:44:40.985 - warn: dysonairpurifier.0 (7371) Please open an Issue on github if you think your device should be supported.
`

Hmmm.
Please reenter your credentials and try it again.

I type in my PW again and saved .. same log again .. i deleted the "Dyson ChallengeID" and klicked on "2FA-Code Email" and there is this Error:
Received error: [AxiosError: Request failed with status code 401] from dyson API. These credentials have been used during this request: Username: [################], Password: [###############], country: [DE], locale: [de-DE]. If these credentials are okay and you are facing a 401 error, please refer to the adapters readme file for a documented solution. If these credentials are okay and you are facing another error please contact the developer via iobroker forum or github.

Now its sad:
This account : ############## is undefined but needs to be ACTIVE. Please fix this first and set this account to active using the dyson smartphone app or website.
But i do not changed my account and the dyson App works just fine

I pretty much expected that number. So please install the just released V2.5.3 from github and test if your issue is solved with that. If not - please reopen this issue.

i have just updated to the actual github version and the problem is still there for.

Something is wrong .. i logout out from the Dyson App and relogin it works fine with my Creds .. i get the Mail from Dyson .. just as expected but the Apdater is failing and still says i should fix my account.

@tehmilcho
To fix your 401 issue please follow: https://github.com/Grizzelbee/ioBroker.dysonairpurifier#if-you-are-facing-the-401-issue-during-2-fa-please-try-this-workaround
@tehmilcho and @krobipd
Please downgrade to 2.5.1 and wait for further updates here. I need to check what I've changed to cause this issue.

Hey okay.. now i get 429 Error ... so i just rollback my Snapshot :)
Take your time :) Just say if should test somehing :)

@tehmilcho , @krobipd
I've just taken a first look into it. The issue is between node 16.x and axios 1.x. Axios 1.x works with Node 14 but not with Node 16.
https://github.com/axios/axios/issues/5298
To solve this I downgraded in v2.5.4 to axios 0.27.2 which was already used in v2.5.1
Test on my machines looked promising.
So I think this is solved for now and I now need to upgrade my development environment from node 14 to node 16.
Please close this issue if it's solved for you as well.

@Grizzelbee wunderbar GitHub version installiert und funktioniert - 2.5.4 🥳
danke sehr

Works fine :) No issue in the Logs :)


Add support for Chromium viewport configuration for screenshots

While for generating PDFs, there is the option to manipulate the sizing of the end result through e.g. the "paperWidth" and "paperHeight" request attributes, in case of screenshots, the feature seems to be missing yet from the current route API.
I recommend the following additional configuration options for screenshots, which are fully supported by Chromium:

captureBeyondViewport: its current hard-coded value is true in spite of the Chromium API default being false; optional, the default value should stay true for backward compatibility reasons
viewportWidth: similarly to the HTML viewport meta tag, an integer value, designating number of pixels; optional, its default value would be -1, in which case the viewport restriction is not passed over to Chromium
viewportHeight: similarly to the HTML viewport meta tag, an integer value, designating number of pixels; optional, its default value would be -1, in which case the viewport restriction is not passed over to Chromium

Hey @gg-gaborginter,
I was playing with viewportWidth and viewportHeight, and I was not able to make them work.
For instance, increasing the value of viewportWidth did not make the website CSS "adapt", but instead it kept the same width while capturing more "background". viewportHeight was working OK, meaning I was able to take screenshots of a portion of the site.
Also, keep in mind that screenshots are not a first class citizen, but merely a tool to make a sort of "preview" of the PDF converssion.

Hi @gulien,
We are at the moment using a self-built, similar setup for both purposes: PDF and screenshot generation. With screenshots, as the window size can't be influenced anyhow else on the Chromium API, we set the viewport sizes instead and restricted the width of the page body through CSS.
I made some tests with the HTML viewport meta tag, by fixing the width and height explicitly, but without the viewport setting on the Chromium page instance, the screenshot was made of the whole window size (lots of white space all around the desired content).
I understand that the screenshot feature is not a first-class citizen. I merely would like to have the option to control some of the settings that Chromium offers. I'm willing to contribute, so I created a pull request, as well: https://github.com/gotenberg/gotenberg/pull/787


Add onclick callback for Notifications

When the notification is clicked, the callback "raises" the browser window and (changes to) the tab of the notebook.
Tested to work on:
Firefox 37.0.1
Chrome 41.0.2272.101 m

Nice, thanks!


add a way to print version

Thank you for contributing^^
I hope you understand but I think that if pfetch should support flags, it should be proper support (i.e. using clap) with a help menu and possibly a man-page. I also don't think that printing the version number should be necessary because the only reason to update the program should be if something with the current setup is not working properly, otherwise the version doesn't really matter.
This project is supposed to be a rewrite of the original pfetch with pretty much the same features and therefore should (like pfetch) stay minimalistic (because that is what differentiates it from other fetch utilities like neofetch).
I should probably add some information somewhere on what I have in mind for this project  so that no time is wasted implementing features that I don't think fit pfetch.

the original pfetch printed its version with -v, adding --version was to be complete, even if its not that important it still technically brings it closer to the original

Sorry, I didn't know that😅 I will look into whether it is worth it to parse the arguments with clap or not. If not this is a good solution.

If we want to implement everything then here is the code that parses arguments from the original.
Besides version there is the help menu and a debug mode.

I added a help menu.  I don't know how to get the executable name automaticly in rust like the original does so I just hardcoded pfetch as the executable name.

Thank you!


Devise means of raising any exception passed as an Action.init param

As a lib user
I want to raise any Exception passed as an Action.init param
So I can be assured that Pipelines won't continue processing when failure has already been encountered
related to #85 and #87

this was released in 1.7.0


php artisan infyom.publish:tests (Laravel 5.4)

As documented in http://labs.infyom.com/laravelgenerator/docs/master/generator-options
will cause:
[Symfony\Component\Console\Exception\CommandNotFoundException]
  Command "infyom.publish:test" is not defined.
  Did you mean one of these?
      infyom.api:tests
      infyom.publish:layout
      infyom.publish:templates
      infyom.publish:vuejs
      infyom:publish
      make:test

While  trying 'infyom.api:test' will cause:
[Symfony\Component\Console\Exception\RuntimeException]
  Not enough arguments (missing: "model").

I believe infyom.api:testis throwing that exception because it's meant for generating the test files so a Model has to be provided. However I can reproduce the same issue with php artisan infyom.publish:tests and tests seem to be broken in 5.4: even when ApiTestTrait is present and autoload-dev set in the composer.json as indicated at http://labs.infyom.com/laravelgenerator/docs/5.4/generator-options, I'm getting Trait 'ApiTestTrait' not found errors.

I have the same problem while upgrading to Laravel 5.5.

OK, now I can run the test.
I changed the base class of TestCase which laravel/browser-kit-testing/src/TestCase.php was using. And I found that this change has been made in master branch of this file. What's more, I found it was done after the 1.3 version of browser-kit-testing package.
So I let composer use the latest version of browser-kit-testing and the tests can run.

@skys215 I faced with the same problem. Thank you for the solution 👍


Operator '+' cannot be applied to types 'string | number | symbol' and 'number'.

template:
<el-menu-item v-for="(developer, index) in developers"
              :key="developer.id"
              :index="index + 1"
              @click="onActive(developer)">
  <template #title>
    {{ developer.name }}
  </template>
</el-menu-item>

error:
Operator '+' cannot be applied to types 'string | number | symbol' and 'number'.

Make sure developers is not any type, otherwise index is string | number | symbol type in expected.

You can use @ts-ignore in template expression. Currently not support ignore type-checking for <template>, you can open feature request to Volar for discuss if you want.


Wrong error when incorrect ini definition

Following error is raised when I had a new line in config within string definition:
[main]
evaluation=[("target_beam", "target\n", )]
...
2017-08-06 15:54:07: Failed to load INI file: Required argument `source' not given.
Traceback (most recent call last):
  File "neuralmonkey/config/configuration.py", line 70, in load_file
    self.raw_config, self.config_dict = parse_file(file, changes)
  File "neuralmonkey/config/parsing.py", line 176, in parse_file
    config = _parse_ini(config_file)
  File "neuralmonkey/config/parsing.py", line 137, in _parse_ini
    config.read_file(line_numbers, source=filename)
raise ValueError("Required argument `source' not given.")

What would be an ideal error message then?

Anything like "There is an error when parsing the ini file". Because currently, this error suggests that the ini was not even found.

I think the most appropriate error in this case is:
Series target
has not been found.

Anything else is a bug in parsing which should support newlines in strings (in general).


Fix for service catalog service dialog refresh function behaving differently

This is basically a re-do of #793, because that PR somehow had dropped the test coverage and highlighted some problems with the way the specs were written.
As such, this PR moves the triggering and listening to a specific AutoRefresh angular service that doesn't use jQuery's $(document).on, .off, or .trigger methods.
https://bugzilla.redhat.com/show_bug.cgi?id=1439761
@miq-bot add_label euwe/yes, fine/yes, bug
@miq-bot assign @chriskacerguis
@chalettu Can you review and let me know if this is more along the lines of what you were thinking for the auto refresh communications?

Fixing test failures...

@eclarizio prepending unused params with _ will keep travis from whining about em  as being unused

@AllenBW I think there was just a problem with the rebase, because I was still working on the same branch that the old PR was made from, but that got reverted. So some of the changes I needed just didn't make it into the final push and I didn't notice after fixing the conflicts git raised.

@eclarizio looking at what @AllenBW suggested (and said) this will probably need a separate PR for Fine and Euwe.  Other than that, LGTM 👍

@AllenBW This can be backported to Fine branch without conflict. @eclarizio suggested that I check with you to make sure this can go in as is, in case something needs to be done differently in Fine branch. Please let me know. Thanks!

@simaishi well hot darn! yeah ok i see now, all good to go to fine, but not euwe, app structure is fundamentally different :-/

@AllenBW thanks!  Added euwe/conflict label.

Fine backport details:
$ git log -1
commit 7e41b7c23df5b8536897a3c67c9314c5e47b624c
Author: Chris Kacerguis<EMAIL_ADDRESS>Date:   Mon Jun 12 10:21:32 2017 -0500

    Merge pull request #814 from eclarizio/BZ1439761

    Fix for service catalog service dialog refresh function behaving differently
    (cherry picked from commit 8c8cd0b39386187a01d72b6076b016e8f1322348)

    https://bugzilla.redhat.com/show_bug.cgi?id=1461183


Need help with Beerwarts training upgrades taking 1000 days each

Out of nowhere, all my upgrades now require 1000 days to upgrade each. If the only way to fix that is to restart from scratch, I think it's time for me to quit.

Hi @SaintKarien,
in a later stage of the game the training times are getting longer but there are upgrades which lead to magicians reducing the training time of each running training so they are reachable. Although in a very late stage the times got way too large so I limited them to 1000 days. I messed the calculation up, fixed it with 1.66.1 which I just released.
You can cancel the running training (takes a cooldown time until you can restart the training afterwards) and then start them with the correct time again (if you have started the 1000 days lasting trainings) If you haven't started them yet you should be fine again after updating to the latest version.
Really sorry for the issue!

Delay kinda sucks (Shouldn't event exist imo.) since I would lose progress for 7 days(Not even counting the time taken for around 12~ upgrades for the new ones) waiting for the CD to go away on all my mages.

So you are fine with the Bugfix or do you need further assistance to remove the trainings from your save state which shouldn't take such a long time?

I wouldn't mind waiting, but it's annoying. I just feel like there shouldn't be a need for the 7 day delay. Just make the punishment be no refunds for starting and cancelling training if that wasn't the case already. Or lower the delay time to 1 day or less.

I noticed the delay time isn't coupled with the game speed. I'll fix this in a new issue.


"Snagov", "Ciofliceni", "Ghermănești", "Tâncăbești" and "Vlădiceasca" are listed in the drop-down menu

Description:
"Snagov", "Ciofliceni", "Ghermănești", "Tâncăbești" and "Vlădiceasca" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Snagov" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Snagov, ILFOV (Snagov)" and "Comuna Snagov, ILFOV".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Ciofliceni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Ciofliceni, ILFOV (Snagov)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Ghermănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Ghermănești, ILFOV (Snagov)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Tâncăbești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Tâncăbești, ILFOV (Snagov)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Type "Vlădiceasca" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Vlădiceasca, ILFOV (Snagov)".


Password policy testing

Good: refactored the password policy code and wrote tests, and I think it is well-covered now.
Bad: created a new module, that still needs some testing.
@richaagarwal you might be interested in this little bonus: I've included a tox configuration change that allows you to invoke tox with extra arguments, that are passed on to django's test runner. For example, you can now do:
tox -- v1.tests to only run the tests in v1.tests
Testing

tox or cfgov/manage.py test ought to do it.

Review

@kurtw @richaagarwal @kave

Screenshots
Notes

Todos

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[x] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Nice! 👍

Test pass 👍


Undefined symbols when running the opentdf service according to the documentation/instructions

After downloading the latest opentdf app, tried running "go run github.com/opentdf/platform/service provision keycloak". I see thefollowing errors:
github.com/opentdf/platform/service/internal/security
service\internal\security\hsm.go:51:13: undefined: pkcs11.Ctx
service\internal\security\hsm.go:52:13: undefined: pkcs11.SessionHandle
service\internal\security\hsm.go:71:27: undefined: pkcs11.ObjectHandle
service\internal\security\hsm.go:73:26: undefined: pkcs11.ObjectHandle
service\internal\security\hsm.go:147:57: undefined: pkcs11.Ctx
service\internal\security\hsm.go:149:16: undefined: pkcs11.New
service\internal\security\hsm.go:160:39: undefined: pkcs11.Ctx
service\internal\security\hsm.go:168:33: undefined: pkcs11.Ctx
service\internal\security\hsm.go:208:38: undefined: pkcs11.Ctx
service\internal\security\hsm.go:346:64: undefined: pkcs11.ObjectHandle
service\internal\security\hsm.go:149:16: too many errors

Thanks for opening this issue @rsundaar1!  This was likely fixed by some of the pulls around HSM and the crypto utilized.

This is likely still an issue. We might need to add build tags to prevent
We can do this by refactoring hsm.go so it uses a build tag, adding
//go:build hsm

to the top of the file, then adding another bit of code that lets it compile when the hsm tag is not set during go build.

@rsundaar1
To address the issue above you need to install a PKCS 1.1 compatible library, called in the code an HSM library. These libraries tend to be platform specific so for ease of development we generally use the softHSM library, which provides that API on top of openssl.

People internally are often running into this, especially when trying to use platform/service as a library.

This is merged as of https://github.com/opentdf/platform/pull/830 and should be available in 0.4.3 when we tag that


Declare private methods and properties in comments

I do not like the underscore convention for privates in JavaScript.
I propose adding a comment-based way to specify private methods and variables.
E.g.
class Foo {

  // this is foo
  // @private
  foo;

  // this is bar
  // @private
  bar() {

  }

}

Because the munge_underscores flag is already implemented, this should be easy to do.
We should allow a custom regex for the comment format (similar to the suppress_comment option).
Would be great if the regex could support parsing AtomDoc (TomDoc syntax) - the documentation used in Gihub's Atom Editor.
class Foo {
  // Public: foo is a foo
  //
  // Foo foo foo.
  foo;
}

We should also support JSDoc style comments too.
class Foo {
  /**
   @private
   */
  foo;

  /** @private */
  bar;

  /* @private */
  baz;
}

Flow does have a comment syntax but no support for private class members.
Merging this into the feature request issue for private class members: #275


Keys starting with dynamic command names will be wrongfully replaced

Describe the bug
When having a key like datetimevalue it will get replaced by 15/12.
To Reproduce
write datetimevalue
copy it
it gets replaced by
Expected behavior
The static key defined should show up
Screenshots
N/A
Desktop (please complete the following information):
Windows 10: version 0.2

Fixed


Set and render new DATA_SCHEMA

Is there a way to set and render new data_schema on the page? The problem is to set json schema value on another field change event.

@MichaelPavlov there is an example with dynamic schema https://github.com/abogushov/django-admin-json-editor#dynamic-schema but schema will be generated when page will loaded. Dynamic schema during editing is not supported in my opinion.


[Feature Request] Save last FBT calibration, and restore it after a game restart/crash

I'm probably the only one that cares about having a perfectly aligned FBT calibration (that I take time to do).
Having something that restore the last FBT calibration (in case if the game crash, or just restart because idk something broke and you need to restart it) would be life saving.
I am not joking, the amount of time I stopped my VRChat session because it crashed and I didn't want to spend 15min again on calibrating my FBT is countless.
I just hope this is possible with VRCX.

As far as we are aware FBT calibration is saved within the game and not at all saved externally like to a file or the windows registry so this will not be possible, it would be best for you to request a feature from VRChat directly via canny as this is out of the scope of VRCX.


What's the difference between this one and Google Material

Google has a similar UI project for Angular (https://github.com/angular/material) on GitHub. What's the difference between this one and Google's Material?

Google Material is build on top of FlexBox and AngularJS. This one is build with Bootstrap. This is easier to learn if you have experience in using Bootstrap.


Collaboration

Wanna collaborate on a new finance project together? Drop a message on linkedin in case you are interested after a quick reply here.

@devfinwiz - What project? Can you share a synopsis or the GitHub repo, if that's a public repo?

Hi @pkjmesra ,
https://github.com/devfinwiz/Fin-Maestro-Web
I was planning to improvise this project such that it is correctly deployable with ease along with frontend. Also, maybe a new project to build a FastApi for Fin-Maestro. Let me know what you think about it...


Fix R_AARCH64_PREL64 relocation error when statically linking on aarch64

This PR fixes the first half of https://github.com/openssl/openssl/issues/10842. The second half (relocations in poly1305-armv8) was apparently already fixed in an almost identical manner to my proposed patch in https://github.com/openssl/openssl/commit/db42bb440e76399b89fc8ae04644441a2a5f6821.

I'm filling the CLA form and emailing it.

Sent the CLA (happy to mark the commit as trivial if that's better).

CI failed because The job exceeded the maximum time limit for jobs, and has been terminated.

CI failed because The job exceeded the maximum time limit for jobs, and has been terminated.

That particular job has regular timeouts and we haven't yet come up with a good solution. For now it can be safely ignored.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has the label 'hold: cla required' and is stale: it has not been updated in 60 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

@iamamoose apologies - it seems like I originally sent the wrong form (which I was told via email), but then I forgot to follow up. I'll send it ASAP.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

@iamamoose I sent the corrected CLA some time ago, could you check it again?

Hi @sztomi  yes, we registered it on 14th July; but you need to "close and immediately reopen" any PRs you have in order to have the bot check again!

We just hit this trying to build RocketMQ on Arm. It looks like the TravisCI failure is unrelated to the patch since it's on x86 not Arm. Is there a reason that this hasn't been merged? Anything we can do to help?

Are you sure the .hidden is even needed? As far as I know, all others are either a combination of .word and .comm, or just .extern. Those 2 files seem to use .extern and .comm, which conflict. poly1305/asm/poly1305-armv8.pl only has .extern.
The symbol will get hidden anyway.

It appears https://github.com/openssl/openssl/issues/10842 is out of date then, I was able to build RocketMQ on arm64 from the current master. The poly1305 fix merged earlier may have obviated the need to add .hidden.
Based on my testing, this PR and the open issue can be closed.

But is the 1.1.1 branch also fixed?

Confirmed NOT working on the OpenSSL_1_1_1-stable branch or the 1.1.1h release.
/usr/bin/ld: ../../bin/lib/libcrypto.a(sha1-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
../../bin/lib/libcrypto.a(sha1-armv8.o): in function `sha1_block_armv8':
(.text+0x1240): dangerous relocation: unsupported relocation
/usr/bin/ld: ../../bin/lib/libcrypto.a(chacha-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
../../bin/lib/libcrypto.a(chacha-armv8.o):(.text+0x20): dangerous relocation: unsupported relocation
/usr/bin/ld: ../../bin/lib/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_ADR_PREL_LO21 against symbol `poly1305_blocks' which may bind externally can not be used when making a shared object; recompile with -fPIC
../../bin/lib/libcrypto.a(poly1305-armv8.o): in function `poly1305_init':
(.text+0x40): dangerous relocation: unsupported relocation
/usr/bin/ld: ../../bin/lib/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_ADR_PREL_LO21 against symbol `poly1305_emit' which may bind externally can not be used when making a shared object; recompile with -fPIC
(.text+0x48): dangerous relocation: unsupported relocation
/usr/bin/ld: ../../bin/lib/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
../../bin/lib/libcrypto.a(poly1305-armv8.o): in function `poly1305_emit_neon':
(.text+0x9a0): dangerous relocation: unsupported relocation
/usr/bin/ld: ../../bin/lib/libcrypto.a(sha256-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
../../bin/lib/libcrypto.a(sha256-armv8.o): in function `sha256_block_data_order':
(.text+0xf88): dangerous relocation: unsupported relocation
/usr/bin/ld: ../../bin/lib/libcrypto.a(sha512-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
../../bin/lib/libcrypto.a(sha512-armv8.o): in function `sha512_block_data_order':
(.text+0x1108): dangerous relocation: unsupported relocation
collect2: error: ld returned 1 exit status

Should we consider this PR against OpenSSL_1_1_1-stable?

@kroeckx Looks like this PR is still needed for the OpenSSL_1_1_1-stable branch for more recent versions of GCC. Can we look into merging it there?

Please open a PR against the OpenSSL_1_1_1-stable branch if
only a fix is needed in that branch (or if it's different then
what you want to do in master.)
I currently don't see a reason why the v8 files in master should
still have the .comm in them. As part of commit db42bb440e7, the
use of OPENSSL_armcap_P changed so that it has a direct relocation
for it, instead of what it does with .LOPENSSL_armcap_P previously
and for v4. So I suggest you change this PR to just remove the
.comm from those 2 files.
For the OpenSSL_1_1_1-stable branch, I'm not sure why the .comm is
needed there either.

Hey guys,
I have the same issue when using openssl version 1.1.1g.
Here is the traces:
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(sha1-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/lib/libcrypto.a(sha1-armv8.o): in function `sha1_block_armv8':
  /usr/src/debug/openssl/1.1.1g-r0/build/crypto/sha/sha1-armv8.S:1204:(.text+0x1240): dangerous relocation: unsupported relocation
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(chacha-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/lib/libcrypto.a(chacha-armv8.o):(.text+0x20): dangerous relocation: unsupported relocation
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_ADR_PREL_LO21 against symbol `poly1305_blocks' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/lib/libcrypto.a(poly1305-armv8.o): in function `poly1305_init':
  /usr/src/debug/openssl/1.1.1g-r0/build/crypto/poly1305/poly1305-armv8.S:43:(.text+0x40): dangerous relocation: unsupported relocation
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_ADR_PREL_LO21 against symbol `poly1305_emit' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/src/debug/openssl/1.1.1g-r0/build/crypto/poly1305/poly1305-armv8.S:45:(.text+0x48): dangerous relocation: unsupported relocation
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(poly1305-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/lib/libcrypto.a(poly1305-armv8.o): in function `poly1305_emit_neon':
  /usr/src/debug/openssl/1.1.1g-r0/build/crypto/poly1305/poly1305-armv8.S:852:(.text+0x9a0): dangerous relocation: unsupported relocation
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(sha256-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/lib/libcrypto.a(sha256-armv8.o): in function `sha256_block_data_order':
  /usr/src/debug/openssl/1.1.1g-r0/build/crypto/sha/sha256-armv8.S:1041:(.text+0xf88): dangerous relocation: unsupported relocation
  /usr/lib/gcc/aarch64-ds-linux/7.3.0/../../../../aarch64-ds-linux/bin/ld: /usr/lib/libcrypto.a(sha512-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC
  /usr/lib/libcrypto.a(sha512-armv8.o): in function `sha512_block_data_order':
  /usr/src/debug/openssl/1.1.1g-r0/build/crypto/sha/sha512-armv8.S:1039:(.text+0x1108): dangerous relocation: unsupported relocation
  collect2: error: ld returned 1 exit status
  error: command 'aarch64-ds-linux-gcc' failed with exit status 1

Note: I'm using gcc version 7.3.0
I will try the patch propose above
ilies

There is one change in gcc that I know of that might be relevant, but limited testing didn't actually show an issue. Maybe I didn't create the correct relocations to actually have a problem.
gcc 10 changed the default from -fcommon to -fno-common. Maybe Ubuntu made that change earlier. Using -fcommon, a global int foo; in a .c file with generate .comm foo,4,4 in the .s file. Using -fno-common it will generate .globl foo. So with older gcc versions, you only have .comm, while a more recent you might get both a .glob and various .comm.

Hi,
I am still having issues with OpenSSL 3.0.0 alpha 6. I didn't try master branch, but checking git history, these asm perl files for armv8 don't seem to have changed since the alpha 6. In my case I have more issues than @mattsplats because I think OpenSSL is being used in a .so file which uses a linker script hidden OpenSSL symbols by default. That's why I do hide some symbols like this is done in this pull request.
@kroeckx I also took into account your advise to remove the .comm section.
It's in pull request #13056.
Cheers,
Romain

Hi,
Normally this pull request can be closed, master branch has a similar fix now.
Cheers,
Romain

Fixed by #13056 (master) and #13218 (1.1.1). Closing.


Add support for object change notification to storage

See: https://cloud.google.com/storage/docs/object-change-notification
E.g., we could add a watch() method to Bucket, which would  register the notification URL and return an instance of a new Channel class:  that instance would have a close() method which would turn off the notifications.

@jgeewax can you give us a feel for how important this issue (and #19) are?  Should they be blockers for Storage M1?

FWIW, there are 34 methods in storage and this is one of them. This would target storage.channels.stop and storage.objects.watchAll.

Can move this elsewhere, but is a list of the other 32 methods, not all of which we support
Each of the 5 resources

buckets
bucketAccessControls
objects
objectAccessControls
defaultObjectAccessControls

have the 6 verbs insert, get, list, update, patch, delete and in addition there is a way to concatenate objects and to copy them

storage.objects.compose
storage.objects.copy

@dhermes, #19 was a request for a way to cache all the blob IDs in a bucket:  I have the sense that we cannot "safely" provide that feature without having a way to invalidate the cache, which requires the storage.objects.watchAll API (and therefore storage.channels.stop).

Yes the "get all keys" / "get all objects" concept is not something that really applies to a mature application (one with more than a few thousand objects). As for the people "just getting started", the two HTTP requests won't be such a big deal. What's more, we shouldn't be encouraging people to get a list of "all objects" locally; they should only use what they need (e.g. for serving a request for a signed-in user).

I think this one should probably not be a total blocker for a 1.0 release, but I really like the API that @tseaver suggests. It makes sample code look like:
bucket = storage.get_bucket('...')

# Set up a 'watch' on the bucket (ie, tell it to ping a URL when things happen):
channel = bucket.watch('http://...', channel_id='my-magical-channel')
channel2 = bucket.watch('http://...')

# Stop notifications..
channel.close()
channel2.close()

# Stop all notifications (can we do this?)
# Is this the right name? Maybe bucket.get_notification_channels() ?
channels = bucket.get_channels()
for channel in channels:
  channel.close()

# Get a channel by ID and stop those notifications.
# Maybe bucket.get_notification_channel() ?
channel = bucket.get_channel('my-magical-channel')
channel.close()

Based on "I think this one should probably not be a total blocker for a 1.0 release" I'm moving Stable -> Future.

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.
As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Thank you!


MicroBit: Missing Sensor

Describe the bug

According to the manufacturer(https://microbit.org/guide/features/), the MicroBit robot has a light sensor in it but the option for the sensor is not available in the lab.

To Reproduce
Steps to reproduce the behavior:

Switch to MicroBit.
Click on Sensor's category.
See missing light sensor.

Expected behavior

Availability of light sensor in the sensor's list.

Screenshots

Device information

Type: Laptop
OS: Windows 10
Browser: Google Chrome

works. But the light sensor returns always 100% light. It should be possibile to set the value in the sensor data panel in the same way as for other sensors.

Please try to hover with the mouse over the led matrix, the value is then 50 (like shadowed) , if you touch down with the mouse on the led matrix, light becomes brighter and the value is 150. This was the first sensor implemented in the simulation (no extra panel available at that time ).


When I try to save a character json it just breaks and doesn't respond

Describe your bug here.

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no

which version of psych engine are you using

which version of psych engine are you using

i don't know, it's baldi's funkin class and i dont know what version that is

Put It In Bin/Mods/Characters/Whatever.json

then click 7, and if it works, you will see playtime or what you name it.

if there is a bin folder

if there is a bin folder

it's PSYCH ENGINE.

yeah I know that

yeah I know that dipshit

there's no bin folders in psych engine.

sometimes there is, sometimes there isn't, especially when you compile the game

Put It In Bin/Mods/Characters/Whatever.json

bruh it wont let me download the json file

Put It In Bin/Mods/Characters/Whatever.json

bruh it wont let me download the json file

wdym it won't let you download the json?

Put It In Bin/Mods/Characters/Whatever.json

bruh it wont let me download the json file

wdym it won't let you download the json?

when i click save character it just doesn't respond and it won't ever download it on my pc


Store FHIR file in blob storage

Store the generated FHIR file in blob storage in a FHIR folder, with sub folders per recipient within the FHIR folder. For this step, each generated FHIR file will have a direct mapping to one internal csv file.
Test: verify the file is generated and saved in blob storage.

Hey team! Please add your planning poker estimate with ZenHub @carlosfelix2 @jh765 @jimduff-usds @oslynn @smythe5 @whytheplatypus

Subsumed by more recent Gage tickets.


Override ink-docstrap parameters

Is it possible for user to override the default docstrap configuration?
I'd like to use a different them than Cerulean.

Ah, the override is supported by the config option. All options will be replaced by those in the config file specified though so the output would be in the default ./out/ not ./docs/gen/.


Iron Router 1.0.x is eating CollectionFS download URLs

It looks like something in Iron Router has changed in a way that the CollectionFS download URLs no longer work. Could you please help identify where the problem could be?
You can find more details there: https://github.com/CollectionFS/Meteor-CollectionFS/issues/472

Did anyone confirm this fix?
I am getting the same error with these versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I can confirm this is fixed. The error I received was due to having both a route and collection with the same name.


Removing parental element styles that affect extensions

Removing annoying parent styles that affect Cluster Page and Bottom Bar extensions.
Outer styles for another registires kept untouched since for some places like menu items outer styling is preferred way to keep things simple for extension developers. For example, if some extension adding a menu item to pod actions menu, new item visualisation most probably would look alike other items. So there's no need for developer to style whole look of a menu item.
Also, moved styling of Support Page extension to emotion styled components considered it as a prefered way to isolate custom styles from ones provided by Lens.
Fixes #1251

@stefcameron Totally agree. The previous statement was wrong, I've changed name of the PR.


Unable to destroy repo with longjobs

Installation information

jumpscale version:master(c277ddbc)
operating system:Ubuntu

Detailed description
An ays repo with a long job isn't properly destroyed. The services and actors directory are created again and the long job is restarted when the ays is restarted.
Steps to reproduce

Create a repo with a long job
Destroy the repo
Check the directories in the repo which will still have services and actors directories.
Restart the ays server and the job will restart

Verified


add support to enable/disable WIFI

it would be nice to have support to manipulate the WIFI connection

It's already implemented. Use TestButler.setWifiState(boolean).

@BogdanLivadariu This is already implemented. Can you close this issue?


The 'Access-Control-Allow-Origin' header has a value that is not equal to the supplied origin

Hi,
I have been using laravel-cors from quite a long time and it's been working flawlessly so far. But Today, I am receiving a strange error on my setup described below:
I have ubuntu 16 with nginx server installed and have created server blocks as follows:

backend.xx.co (laravel 5.3)
a.xx.co (angular 2)
b.xx.co (angular 2)

Now, When I'm on b.xx.co, Only on few of the backend api routes (not all the routes), the response for the request is:
Failed to load http://backend.xx.co/api/xxx: The 'Access-Control-Allow-Origin' header has a value 'http://a.xx.co' that is not equal to the supplied origin. Origin 'http://b.xx.co' is therefore not allowed access.
and on a.xx.co, on some routes:
Failed to load http://backend.xx.co/api/xxx: The 'Access-Control-Allow-Origin' header has a value 'http://b.xx.co' that is not equal to the supplied origin. Origin 'http://a.xx.co' is therefore not allowed access.
I have been messing with this from hours and not able to fix this yet. Any help will be appreciated.
Thanks

Same here.

I meet the same problem

If there was a way to support wildcard subdomains, that would fix this issue. We run our front end on App Engine, and they support versioned URLs, so different versions might be on app.example.com and qa.app.example.com.
I would expect to be able to configure this like:
'allowedOrigins' => ['*.app.example.com', 'app.example.com']

The CORS spec does not support wildcard mapping of subdomains, as it is expected the the web server does the mapping and return the appropriate and specific response.

I'm closing this due to inactivity. If this issue is still relevant on the latest version (2.0.1 at the moment), please open a new issue with detailed information.


(SERVER-326) Add /v3/environments route

Add the /environments route to the v3 routes, as it previously
existed in the v2 routes.

:+1: This looks good to me and fixes one of the failing puppet acceptance tests.


Empty page when going to an invalid page

Expected
I would expect it to redirect me back to the home page or show a page that say that the page is invalid and a button or link that allow me to go back to home page instead of this empty page

The issue of an empty page when navigating to an invalid URL has been fixed by making the "Not Found" page visible. Additionally, as suggested, functionality has been added to allow redirection to the home page and a page reload.


[WHLSL] Implement texture types

Migrated from https://bugs.webkit.org/show_bug.cgi?id=188940:
At 2018-08-25T02:19:59Z<EMAIL_ADDRESS>wrote:
[WHLSL] Implement texture types

Committed r235642: https://trac.webkit.org/changeset/235642


Fails on cargo workspace

Environment details

OS: github actions.
Node.js version: 18.16.1
npm version: 9.5.1
release-please version: 15.11.0

Steps to reproduce

Run release-please on a cargo workspace (e.g. this one).

The provided sample workspace is essentially the result of doing:
mkdir cargo-release-please-test
git init
cargo new a --lib
cargo new b --lib

And then creating a Cargo.toml file in the root which links to a and b, and added the default release-please-action config with the release-type set to rust.
Release-please will fail with:
❯ Fetching a/Cargo.toml from branch master
❯ Fetching b/Cargo.toml from branch master
❯ Fetching Cargo.toml from branch master
✖ is not a package manifest (might be a cargo workspace)

And yes, this is true, Cargo.toml is the root of this cargo workspace, but according to this this is supposed to work with a cargo workspace.
I feel like I'm losing my mind because other people have gotten this working, so either this is a recent regression, or I'm missing something obivous.  :P  I don't see any documentation here or here that says I need to do anything special for a cargo workspace though.

Looks like the problem is that cargo workspaces aren't supported without using the manifest release.
You need a release-please-config.json, which for this project looks like:
{
    "packages": {
      "a": {},
      "b": {}
    },
    "plugins": ["cargo-workspace"],
    "release-type": "rust"
  }

"packages" needs to list all your sub-crates.  And you need a .release-please-manifest.json which can start life as:
{}


Update spec for multiple selective imports

This is an attempt at updating the spec for the changes in https://github.com/dlang/dmd/pull/6589
I wasn't so sure about the grammar changes.
(grammar.dd would also need an update)
See also: https://dlang.org/changelog/pending.html#multi_module_selective_imports

Andrei has approved these changes and it looks like Wilzbach has addressed all issues, so I'm gonna merge.


feat: new shuffler

Codecov Report
Attention: Patch coverage is 0% with 170 lines in your changes are missing coverage. Please review.

Project coverage is 79.53%.

Files
Patch %
Lines

rust/lance-index/src/vector/v3/shuffler.rs
0.00%
162 Missing :warning:

rust/lance-file/src/v2/writer.rs
0.00%
8 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
- Coverage   79.77%   79.53%   -0.25%
==========================================
  Files         202      203       +1
  Lines       55306    55476     +170
  Branches    55306    55476     +170
==========================================
  Hits        44121    44121
- Misses       8618     8787     +169
- Partials     2567     2568       +1

Flag
Coverage Δ

unittests
79.53% <0.00%> (-0.25%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(builtin): growth array capacity if necessary

This is a very basic strategy to growth the capacity of array, but I think it works for now.
close #107

Great! 👍


Stop propagation of expand events

I think this should fix https://github.com/rangle/augury/issues/553 but I am not sure because I cannot reproduce it

@clbond it does not seem to fix the above issue for me.

Alright, sorry. I wish I could access your application and reproduce it. I'll close this PR


Incompatibility with "minimize to tray" tools

GUI breaks after changing connection from dropdown list

This problem appeared in 4.1 version - there are no problems with 4.0.5. Version 4.21 also has this issiue.
I tried some tools (rbtray, dm2, 4t Tray Minimizer) - all of them breaks GUI
Can you fix it? Minimize to tray is very usefull for temporary cleaning of taskbar

What is your OS/window manager?

Win7
The problem disappears when I close rbtray

Context : Windows 10, dbeaver 4.2.0
Same here, but i don't have "minimize to tray" tool.
To reproduce, i launch dbeaver, open a connection and change the connection with the dropdown list.
And it goes from this :

to this :

And sometimes the main menu turn to a bugged drop down list :

It seems the problem is gone in 4.2.3 )
Thank you!

Thanks for letting know.
And there will be yet another fix of schema selector in 4.2.4 (empty list when there is no active schema).


Linker errors on Linux with debug build

The lib build is fine. For example build I get:
IrrlichtBAW/source/Irrlicht/coreutil.cpp:129: error: undefined reference to '_Ux86_64_getcontext'

@Crisspl @devshgraphicsprogramming I tried to render the GUI today but this happens:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/COpenGLStateManager.h:530:32: error: ‘GL_CLIP_DISTANCE6’ was not declared in this scope
return GL_CLIP_DISTANCE6;

Full error log:
[100%] Building CXX object examples_tests/13.BRDF_Explorer/CMakeFiles/brdf_explorer.dir///ext/CEGUI/CEGUI.cpp.o
In file included from IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLExtensionHandler.h:19:0,
from IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:25,
from IrrlichtBAW/ext/CEGUI/CEGUI.cpp:29:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/COpenGLStateManager.h: In static member function ‘static GLenum irr::video::COpenGLState::glEnableBitToGLenum(const uint64_t&)’:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/COpenGLStateManager.h:530:32: error: ‘GL_CLIP_DISTANCE6’ was not declared in this scope
return GL_CLIP_DISTANCE6;
^~~~~~~~~~~~~~~~~
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/COpenGLStateManager.h:530:32: note: suggested alternative: ‘GL_CLIP_DISTANCE0’
return GL_CLIP_DISTANCE6;
^~~~~~~~~~~~~~~~~
GL_CLIP_DISTANCE0
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/COpenGLStateManager.h:533:32: error: ‘GL_CLIP_DISTANCE7’ was not declared in this scope
return GL_CLIP_DISTANCE7;
^~~~~~~~~~~~~~~~~
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/COpenGLStateManager.h:533:32: note: suggested alternative: ‘GL_CLIP_DISTANCE0’
return GL_CLIP_DISTANCE7;
^~~~~~~~~~~~~~~~~
GL_CLIP_DISTANCE0
In file included from IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:25:0,
from IrrlichtBAW/ext/CEGUI/CEGUI.cpp:29:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLExtensionHandler.h: In static member function ‘static void irr::video::COpenGLExtensionHandler::extGlClearNamedFramebufferfv(GLuint, GLenum, GLint, const GLfloat*)’:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLExtensionHandler.h:3465:78: error: invalid conversion from ‘const GLfloat* {aka const float*}’ to ‘GLfloat* {aka float*}’ [-fpermissive]
pGlClearNamedFramebufferfv(framebuffer, buffer, drawbuffer, value);
^
In file included from IrrlichtBAW/ext/CEGUI/CEGUI.cpp:29:0:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h: At global scope:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:678:17: error: ‘GLXContext’ does not name a type; did you mean ‘SAuxContext’?
GLXContext ctx;
^~~~~~~~~~
SAuxContext
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:679:17: error: ‘GLXPbuffer’ does not name a type; did you mean ‘setbuffer’?
GLXPbuffer pbuff;
^~~~~~~~~~
setbuffer
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:1004:4: error: ‘GLXDrawable’ does not name a type
GLXDrawable Drawable;
^~~~~~~~~~~
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:1005:4: error: ‘Display’ does not name a type
Display* X11Display;
^~~~~~~
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h: In constructor ‘irr::video::COpenGLDriver::SAuxContext::SAuxContext()’:
IrrlichtBAW/examples_tests/13.BRDF_Explorer/../../include/../source/Irrlicht/COpenGLDriver.h:637:58: error: class ‘irr::video::COpenGLDriver::SAuxContext’ does not have any field named ‘ctx’
SAuxContext() : threadId(std::thread::id()), ctx(NULL), XFormFeedbackRunning(false), CurrentXFormFeedback(NULL),
^~~
examples_tests/13.BRDF_Explorer/CMakeFiles/brdf_explorer.dir/build.make:75: recipe for target 'examples_tests/13.BRDF_Explorer/CMakeFiles/brdf_explorer.dir///ext/CEGUI/CEGUI.cpp.o' failed
make[2]: *** [examples_tests/13.BRDF_Explorer/CMakeFiles/brdf_explorer.dir///ext/CEGUI/CEGUI.cpp.o] Error 1
CMakeFiles/Makefile2:3874: recipe for target 'examples_tests/13.BRDF_Explorer/CMakeFiles/brdf_explorer.dir/all' failed
make[1]: *** [examples_tests/13.BRDF_Explorer/CMakeFiles/brdf_explorer.dir/all] Error 2
Makefile:151: recipe for target 'all' failed
make: *** [all] Error 2

I made it to link to libunwind yesterday and tested on meshloaders example build (debug build) with engine and all deps from scratch. Builds fine so most likely it's something wrong in ex13 setup or generally your side

Could you try just including COpenGLExtensionHandler.h and build the helloworld example? The compile errors are for the lib actually, it does not point to my code. BTW I think this is because the OpenGL state tracking code is staying behind and not updated since the drop of Silverlining example.

it might be the project does not have the ./source/Irrlicht/ for the header include search paths, thats why you're probably not seeing stuff usually defined in glext.h

‘GL_CLIP_DISTANCE6’ was not declared in this scope

This is a define in glext.h (which is here https://github.com/buildaworldnet/IrrlichtBAW/blob/master/source/Irrlicht/glext.h )

ple build I get:
IrrlichtBAW/source/Irrlicht/coreutil.cpp:129: error: undefined reference to '_Ux86_64_getcontext'

Thats libunwind not being linked.

I've just tried the following in COpenGLDriver.h
// also includes the OpenGL stuff
#include "glext.h"
#include "COpenGLExtensionHandler.h"

I think it simply does not find these headers, try this after the includes
#ifndef __glext_h_
#error "Failed to find glext.h or not pulling in the defines"
#endif

#ifndef GL_VERSION_3_0
#error "Why is this not defined?"
#endif

Btw what order are you including OpenGL state manager and COpenGLExtensionHandler?

RFC from @devshgraphicsprogramming for this issue: https://github.com/Crisspl/IrrlichtBAW/commit/df448a29975eff96a8754d8bd74732edbeccc948
Commit message:
Partial fixes for conflicts with GLEW
Unfortunately also commenting out the code in glew.h that produces 'gl.h was included from before GLEW' error or similar...
But generally most likely solution would be to make sure irrbaw's GL headers and GLEW's GL headers never end up in the same translation unit

then you need to keep CEGUI+GLEW separate from OpenGLStateManager, or sort out the order in which heaers get included.
We need to see more output regarding the errors.
I think the main "pain in the ass" comes from the fact that the last release of glew was in 2017 (2.1.0), whereas the last release of OpenGL 4.6 was in 2017, so we need to make sure that CEGUI is using the latest glew + opengl headers and that IrrBaW is also using the latest glext.h,wglext.h,glxext.h and gl.h

Maybe try "CEGUI_USE_EPOXY" instead of "CEGUI_USE_GLEW" ?
I see there are a lot of find_package for CEGUI CMake which is extremely annoying, maybe its finding an old glew with old glext.h headers ?
Since this is linux it will basically depend on what version of glew you have available in the repositories.
This is why I prefer all dependencies as submodules as not relying on package manager such as vcpkg, apt, etc.
Because what version of the dependency is controlled by the OS or other tool global tool.

Solved, my assumption is right, just isolating the state management code and it will compile and run.
Different GLEW of CEGUI doesn't matter.


First attempt fixing null properties of Values<>

@RehanSaeed I've had a go at refactoring along the lines you explained, but all nulls now seem to be rendering... for both OneOrMany<> and Values<>!
Did I miss something here?

Closing to re-submit based on newly merged master...

Yeah sorry about that. I was seeing if I could get tests to run under net461 under ubuntu + mono. Very tricky.

Sounds like it!!


Validator bug + proposed solution

Hello,
While using the JSON validation we discovered that it doesn't work properly for complex inheritance hierarchy. For the following JSON:
{
  "BaseInstances": [
    {
      "discriminator": "Base",
      "Name": "Base1",
      "Label": "Base Instance 1",
      "IsActive": true,
      "Children": [
        {
          "MaxThreadNumberOverride": null,
          "discriminator": "Concrete",
          "Name": "Concrete1",
          "Label": "Concrete Instance 1",
          "IsActive": true,
          "Children": [
            {
              "discriminator": "Base",
              "Name": "Base2",
              "Label": "Base Instance 2",
              "IsActive": true,
              "Children": []
            }
          ]
        }
      ]
    }
  ]
}

, and the corresponding classes:
public class Container
{
	public Container() => BaseInstances = new List<Base>();
	public ICollection<Base> BaseInstances { get; set; }
}

[JsonConverter(typeof(JsonInheritanceConverter))]
[KnownType(typeof(Concrete))]
public class Base
{
	public Base()
	{
		Children = new List<Base>();
	}

	public string Name { get; set; }
	public string Label { get; set; }
	public bool IsActive { get; set; }
	public ICollection<Base> Children { get; }
}

public class Concrete : Base
{
	public int? MaxThreadNumberOverride { get; set; }
}

, the validator outputs:
 NoAdditionalPropertiesAllowed: #/BaseInstances[0].Children[0].MaxThreadNumberOverride

The schema is generated with FromTypeAsync method and it appears to be correct. We've managed to investigate how the JsonSchemaValidator performs the validation and the problem seems to be related to how it resolves schema properties.
schema.Properties.ContainsKey(...)

,and
foreach (var propertyInfo in schema.Properties)

The Concrete.MaxThreadNumberOverride property seems NOT to be on the list of schema.Properties and instead is only visible on:
schema?.DiscriminatorObject?.Mapping?.Values?.FirstOrDefault()?.ActualSchema?.ActualProperties

We've built an extension method and used it in those two places I mentioned. The only thing it does it aggregate the properties from Base and Concrete classes. Of course FirstOrDefault that you see should rather be replaced with more sophisticated mapping retrieval logic but the idea should be clear. We are curious what you think of it--does it seem like a bug?
Please find an extension method below (we can also provide a small sample project should you request it).
public static IDictionary<string, JsonProperty> AllProperties(this JsonSchema4 schema)
{
    var list = new Dictionary<string, JsonProperty>();
    foreach (var property in schema.Properties)
    {
        list.Add(property.Key, property.Value);
    }

    if (schema?.DiscriminatorObject?.Mapping?.Values?.FirstOrDefault()?.ActualSchema?.ActualProperties != null)
    {
        foreach (var property in schema?.DiscriminatorObject?.Mapping?.Values?.FirstOrDefault()?.ActualSchema?.ActualProperties)
        {
            list.Add(property.Key, property.Value);
        }
    }

    return list;
}

Best Regards
Piotr Kołodziej

Duplicate of https://github.com/RicoSuter/NJsonSchema/issues/224 ?

Well it seems so. We will create a pull request soon, and kindly ask you to take a look.

Hi, I am interested about the progress of this issue. I implemented inheritance with dicriminators, same as your example and I am trying to validate a json against a schema. The validation test passes no matter if the discriminator is correct or not.


Expanding ModNPC SetChatButtons & OnChatButtonClicked

At the current moment, the ModNPC class only allows you to define two Chat options, where most of the time the first of which is set as a "Shop", leaving you with only one other option to define. This is very limiting in many circumstances.
My suggestion is to make a minor adjustment to these two methods.
For SetChatButtons, change it from (ref string button, ref string button2) to (ref string[] buttons). A more viable limit could then be applied (5 - 6 should be optimal). For OnChatButtonClicked, it would change from (bool firstButton, ref bool isShop) to (int buttonIndex, ref bool isShop).
This would open up a lot more in terms of NPC functionality for modders and custom town bots.


Docker Image Versioned Tags

Hi,
I've noticed that the Docker image on Docker Hub only has a "latest" tag. It would be great if new tagged releases could generate a new tag on Docker Hub as well, so it is possible for us to run a specific version in Production.
Thanks!

I completely agree - happy to do this manually for previous releases. But would be interested in incorporating this into a prepublishOnly script.

Hi Joel,
Given the images are built using Docker Hub Builds it should just be a case of configuring it to build on tags. I'm not very familiar with prePublishOnly scripts to know how that would work unfortunately.
Thanks
Sam

Ah good point - we could have CI do this when it detects a new tag. I'll investigate

I tried it with CI (https://github.com/single-spa/import-map-deployer/commit/aedd4ecf1cdc4b886b9a597d0160cad4cd9a6295) but it turned out to be somewhat tricky to get it working in Travis. I gave up once I ran into a problem where travis considered a push to master with new tags to sometimes be the master branch and sometimes not to be the master branch.
So I ended up implementing this as a postpublish script that will run whenever I publish a new version. This means that the person publishing it must login to docker hub and have access to the repo. But it was easier to set up. It will now automatically run in all future publishes.
I am closing this issue since it's set up for future versions - let me know if you'd like me to push up a tag of a previous version that you're interested in using. I will link to the tag on docker hub once it finishes pushing (it has taken over 15 minutes!!). I documented how to use it at https://github.com/single-spa/import-map-deployer/commit/ca56b935a7ef8ca87d7343c97c061ea4dd4a08f7

Here is the v2.2.1 tag - https://hub.docker.com/layers/singlespa/import-map-deployer/v2.2.1/images/sha256-d725ec45d3977e4decbfa119514fc537c9ad847df26bdda180c188ee4a809316?context=repo

Ah I just realized that docker hub can do this very easily - switched over to using that.

Great thanks! :)

Just confirmed that this is not working. See https://hub.docker.com/repository/docker/singlespa/import-map-deployer/builds.

I likely just configured docker hub incorrectly. If anyone spots anything wrong in that screenshot, please share.

Just fixed it. First successful auto build for a git tag is at https://hub.docker.com/repository/registry-1.docker.io/singlespa/import-map-deployer/builds/6e27cf34-2b5e-42f5-8289-1a515b9523e2


 This cause the counter to quickly reach the retry limit if it has previously failed several times. For example, assuming that an application failed 3 times in a row, and then succeeded once. If the retry limit on failures is 3, then the application will not be retried the next time it fails as its ExecutionAttempts has already exceeded 3. The semantics of ``ExecutionAttempts, however, is a counter of failed attempts, and its value is used to determine if the controller should keep retrying running an application in case of failure, as the [code](https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/pkg/controller/sparkapplication/controller.go#L421) shows. The same goes for SubmissionAttempts. This PR fixes the bug by resetting ExecutionAttempts and SubmissionAttempts upon a successful run and submission of an application.
@akhurana001

I think the right way to achieve this is to reset these fields in the PendingRerunState which we should go through for every re-run. I see we already clear some of these in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/527/files#diff-b7eea120d7ac0e8587781b863b7db8e4L909 similar to what we seem to be doing for InvalidatingState  Let me know if you think that might not work.

@akhurana001 resetting them in PendingRerun state means resetting them even after each consecutive failed run, which is certainly not what the semantic of these counters are.

resetting them in PendingRerun state means resetting them even after each consecutive failed run, which is certainly not what the semantic of these counters are.

My bad, that's correct for ExecutionAttempts although resetting SubmissionAttempts in PendingRerun should be fine.

Currently we don't reset ExecutionAttempts upon a successful run of an application. This cause the counter to quickly reach the retry limit if it has previously failed several times. For example, assuming that an application failed 3 times in a row, and then succeeded once. If the retry limit on failures is 3, then the application will not be retried the next time it fails as its ExecutionAttempts has already exceeded 3.

Thinking more about this, this case shouldn't happen. The application is only restarted after a successful run if the restartPolicy is Always and if so, any future restarts decisions won't take the ExecutionAttempts into account as per https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/pkg/controller/sparkapplication/controller.go#L414
Overall, I believe SubmissionAttempts should still capture what happened within a run of an application so it will be better if we reset in PendingRerun before we start a new run of the application.
For ExecutionAttempts , as I mentioned above, I don't think its causing any issues right now and is probably useful to understand the total runs (success + failures) for the application but yes, some future restartPolicy changes might end up breaking it. I am not sure if this required now but I be fine if you strongly believe that we should be resetting this after each successful run.

Thinking more about this, this case shouldn't happen. The application is only restarted after a successful run if the restartPolicy is Always and if so, any future restarts decisions won't take the ExecutionAttempts into account as per https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/pkg/controller/sparkapplication/controller.go#L414

ExecutionAttempt is checked against the failure retry limit when the restartPolicy is OnFailure so it does matter.

ExecutionAttempt is checked against the failure retry limit when the restartPolicy is OnFailure so it does matter.

Yes, I was just pointing out that a case like Failed -> Failed -> Success -> Failed -> Failed -> .... can only happen if the restartPolicy is Always so  ExecutionAttempt check won't happen for such a case and I don't think its causing any issues right now but I am fine if you strongly believe that we should be resetting it.

I was just pointing out that a case like Failed -> Failed -> Success -> Failed -> Failed -> .... can only happen if the restartPolicy is Always so ExecutionAttempt check won't happen for such a case and I don't think its causing any issues right now but I am fine if you strongly believe that we should be resetting it.

Yes, normally this won't cause the issue. However, the user may update the app spec and trigger a rerun. The rerun may fail and not get retried if ExecutionAttempts is not cleared.

Overall, I believe SubmissionAttempts should still capture what happened within a run of an application so it will be better if we reset in PendingRerun before we start a new run of the application.

Done.

One minor comment. Looks good to me otherwise 👍


HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.


fix-test

fix run-tests issues in ci

API change check
API changes are not detected in this pull request.


port parallel changes from master to 0.3.x branch

i've reviewed https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/pull/83, which this is a backport of.

released as v0.3.13 🎉


added 'default_action_name' key to module's .cm/meta.json to allow intercepting any undefined method

This pull request deals with the situation when an action is missing from the module's .cm/meta.json declaration dictionary.
The old behaviour was to immediately return with an error, stating that the method is unavailable.
The new proposed behaviour is to also check if the module has a 'default_action_name' defined. If it is defined and the corresponding function exists, this default function will be called instead.
If the 'default_action_name' is not defined, the behaviour is exactly the same as it used to be (an error is generated).
The new behaviour opens a new dimension for extending CK by allowing a CK module to intercept calls to another module, augmenting or substituting the functionality.

Coverage increased (+0.01%) to 68.248% when pulling 1e64ca45832c095b1741aa8ffef58832005225bf on ens-lg4:master into 5c6f80f0dfb9d11dbab6df732acacfe798d0b245 on ctuning:master.

As we agreed, I am accepting this patch to "test new ideas" but not yet for production use since I am still not convinced that it will give us productivity benefits in comparison with current already existing implementations. You can later show some usage examples and we can discuss it further ...


DSA 2.1 Strings: Binary Strings - Audio

Description
What are Binary Strings? Give examples.
Given a binary string, count number of substrings that start and end with 1.
Important: Do not use assign command for this issue.
Task

[ ] Audio

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

Please assign this issue to me
Name Vanshika Pandey
Batch no: 10


width and height not working well with lock-aspect-ratio

When :lock-aspect-ratio is true, w and h doesn't get values what i'm assigning, specially w.
In my case, item.width and item.height are equals to 200.
top and left are equals to 0:
<vue-draggable-resizable
:lock-aspect-ratio="true"
:x="item.top"
:y="item.left"
:w="item.width"
:h="item.height"
...
>

yes it is a quite bug
my solution is:
set lock-aspect-ratio as a ref with default false value
when starting resizing, set the ref value to true
`
const ratiovalue = ref(false);
function onResizeStartCallback(){
console.log("ResizeStart")
ratiovalue.value=true
}
`


The feedback popup should disappear after choosing to submit a bug

Issue Type: Bug

Click on the smiley face in the bottom right corner
Click on the "Submit a bug" link in the pop up

The issue reporter shows up. At this point, there is no need for the pop up to remain... well, popped up.
VS Code version: Code - Insiders 1.26.0-insider (c86cab2211d6dce686e5c89934d915b1e020ba9e, 2018-08-02T05:17:02.675Z)
OS version: Windows_NT x64 10.0.17134

Hey @ramya-rao-a - is there a way to open the OSS version as an Insiders build so I can see that feedback smiley?

@ramya-rao-a Great - I'll create a PR for this. Also, in the insiders build - the request a feature link goes directly to a feature-request filtered version of the issues in github.

@ramya-rao-a @RMacfarlane do you want the feedback to close also on clicking Request a missing feature?

@itamark Yes, I think it would make sense for the popup to close in both cases. Thanks for looking at this!

@RMacfarlane no probs! I'll add that to the same PR.

@RMacfarlane okay I added it to the PR. #55938 I put the popup directly in the click event handler instead of using an external action is that okay?


Meadow.OS integration - Part 1

Summary
This patch starts to implement the ability to build Meadow.OS for the Meadow F7 board with the NuttX  mainline. It will be followed by more patches, progressively enabling full Meadow.OS functionality.
The Meadow.OS source code is needed to build this configuration. Meadow.OS is being open-sourced under the Apache 2.0 license. A prototype of the source code release and integration with NuttX  is at https://github.com/WildernessLabs/Meadow.OS/tree/prototype
This is the second revision of this patch, as the first one (https://github.com/apache/nuttx/pull/9997) was causing build issues on NuttX CI and was reverted.
Impact
This should only impact the Meadow F7 board configurations.
Testing
No testing to be done, as the configuration is under development.

CI Failure seems unrelated


Fix usage of pyplot when show=False

Fix usage of pyplot when show=False.

Thanks! I am sorry for being out for so long and letting this just sit here. I merged a different fix for the same error already, but I noted that you also seem to have some sigmoid logic added in here as well. Could you explain the motivation for that? Thanks again!

Closing this for now. But if there is something with the sigmoid that you think needs incorporated just say so. Thanks!


Graphs should reset to pan India stats if anywhere on page, except on state slab in the table.

Is your feature request related to a problem? Please describe.
When we hover out of the table, the graphs still represent the last state we hovered over. Doesn't seem natural to me.
Describe the solution you'd like
I personally would prefer that it reset to pan India stats when we are not hovering over any particular state slab.

This is really subjective. I think resetting by clicking anywhere outside the map provides a good middle ground. Closing

But even that does not happen, does it? Clicking anywhere on the page also doesn't reset the map. You have to go all the way in the drop box to select All states to get the pan India view.

@championballer So it resets if you click anywhere outside the map, but still inside the SVG container. You're right that it should ideally reset by clicking anywhere outside the map on the whole webpage, but I couldn't figure out a way to do that.

@shuklaayush Found this while playing around with react-use, maybe you're looking for this?


Manage case where prometheus is disbaled

With prometheus disabled, prometheus Config was still added to volumes list.
This caused POD to never be able to start since the Config for prometheus did not exist.

please revert the changes to the jmx exporter config location and the configmap to create said config. see the CI for error details and i could confirm in my local cluster that these changes result in a crash of the init container as the filesystem in /data is not present at the execution time of the init container.
the changes to switch from wget to curl seem fine for me. just please add them to the config summary in the README.md file

Hi @fredrikand ,
i addressed your points in this PR here: #10
thanks for pointing them out and the initial work on fixing them


fuel_gauge: Join get/set prop structs

The fuel gauge API uses separate get/set property structs to indicate what properties are readable or writable. This lead to duplication in property names and potential confusion for new users of the API. See issue #61818. In addition to above, drivers already determine at runtime if a property is supported for read or write actions.
Join the get/set fuel gauge property structs as a single struct.

Whoops. Missed a test because I running twister on qemu_x86 platform.

Bah! Forgot to check the sample.


[admin] Updating dependency versions

Docs Build status updates of commit 04bf18b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

generate-docs/scripts/package-lock.json
:white_check_mark:Succeeded

generate-docs/tools/package-lock.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel