UWP TintTransformation - DivideByZeroException

The Xaml is working on Android and IOS, but it gives exceptions on UWP:
Xaml
<ffimageloading:CachedImage
                                WidthRequest="25" HeightRequest="25" Source="{Binding statusIcon}">
                                    <ffimageloading:CachedImage.Transformations>
                                        <fftransformations:TintTransformation EnableSolidColor="True" HexColor="#8BC34A" />
                                    </ffimageloading:CachedImage.Transformations>
                                </ffimageloading:CachedImage>

Exception
Image loading failed: ic_queue_black.pngTintTransformation,R=139,G=195,B=74,A=255,HexColor=#8BC34A,EnableSolidColor=True
System.DivideByZeroException: Attempted to divide by zero.
   at FFImageLoading.Transformations.TintTransformation.ToReplacedColor(BitmapHolder bmp, Int32 r, Int32 g, Int32 b, Int32 a)
   at FFImageLoading.Transformations.TintTransformation.Transform(BitmapHolder source)
   at FFImageLoading.Transformations.TransformationBase.Transform(IBitmap source)
   at FFImageLoading.Work.PlatformImageLoaderTask`1.<GenerateImageAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at FFImageLoading.Work.ImageLoaderTask`2.<RunAsync>d__109.MoveNext()

The image shows when I remove the TintTransformation, so it can find the image file resouce!

I now work around it by disabling the tint transformation on Windows:

                                <ffimageloading:CachedImage
                                WidthRequest="25" HeightRequest="25" Source="{Binding statusIcon}">
                                    <ffimageloading:CachedImage.Transformations>
                                        <fftransformations:TintTransformation HexColor="#8BC34A" >
                                            <fftransformations:TintTransformation.EnableSolidColor>
                                                <OnPlatform x:TypeArguments="x:Boolean">
                                                    <OnPlatform.iOS>True</OnPlatform.iOS>
                                                    <OnPlatform.Android>True</OnPlatform.Android>
                                                    <OnPlatform.WinPhone>False</OnPlatform.WinPhone>
                                                </OnPlatform>
                                            </fftransformations:TintTransformation.EnableSolidColor>
                                        </fftransformations:TintTransformation>
                                    </ffimageloading:CachedImage.Transformations>
                                </ffimageloading:CachedImage>

I've just started coming across this issue now. I've narrowed it down to using .png's with transparency, and having EnableSolidColor set to true in the transformation.
If I disable EnableSolidColor, there's no error, and the images then show although the transform just acts across the whole image (including the transparent parts, which is undesirable... see first image).
Purely a Windows problem, as the same setup works perfectly on Android with or without EnableSolidColor (see second picture)

It may be related to this: https://github.com/luberda-molinet/FFImageLoading/issues/384
Transformation source is here: https://github.com/luberda-molinet/FFImageLoading/blob/master/source/FFImageLoading.Transformations.Windows/TintTransformation.cs
Any clues?

Fixed :)


micrortps_client: Use px4_get_parameter_value to parse baudrate option

This enables support for 'p:' prefix for the option value to get
current parameter value from px4 param store.
Signed-off-by: Jari Nippula<EMAIL_ADDRESS>

Looks good, just check the formatting with "make format" or manually...

Looks good, just check the formatting with "make format" or manually...

Code cleaned up and then formatted with 'make format'


Add hi Dollar (HI)

Adding hi Dollar (HI)
为确保 Token Profile 的顺利通过，务必逐一确保以下检查项并补充项目资料：
.json 及 .png 文件检查项

[ ] logo 尺寸：120*120 px
[ ] logo 背景：透明
[ ] 代币有至少一笔成功的转账记录
[ ] 此项对于 ERC-20 项目方：合约地址有大小写（做 checksum）
[ ] .json 和 .png 文件名一致（包括大小写）

项目资料：
官方公告：
团队背景：
项目基本情况：
媒体报道：
收录的交易所：
转账所需 Gas Limit（对 ERC-20 项目方）：（默认为 60000）

Please check the following to ensure a successful verification of Token Profile
.json and .png document checklists

[ ] logo dimensions: 120*120 px
[ ] logo background: Transparent
[ ] At least one transaction on the token contract
[ ] For ERC-20 project teams: Upper and lower capitalized alphabets in token address (For checksum purposes)
[ ] Same document name for both .json and .png (Including capitalization)

Project background:
Official announcement:
Project team background:
Sean Rach, Co-Founder, Former Crypto.com CMO
Stefan Rüst, Co-Founder, Former Bitcoin.com CEO
Project basic information:
hi is leveraging blockchain technology to build services that are community powered. Members of hi are the key stakeholders of this ecosystem and the business is committed to maximize membership value - not profits. Our first product is a digital wallet that provides members with the most seamless payment experience via social messengers. The hi Dollar is a membership token that powers the hi ecosystem.
Media publications: https://www.prnewswire.com/news/hi/
Tradeable exchanges: https://info.uniswap.org/#/tokens/0xc4f6e93aeddc11dc22268488465babcaf09399ac
Recommended Gas Limit (For ERC-20 project teams) for transaction: 1000 GWEI

Change Gas Limit to 1,000,000 please. Apologies.

Incorrect json format, check it. :(


refactor(deserialize): allow setting name for root deserialized value

Summary
Allow naming the root deserialized value.
This addresses some requests of #1250.

Can we add a test where we use this new field?

You mean in the doctest?


v0.30: Falconn

LSH library falconn either needs a FalconnTransformer implementation, or should be dropped altogether.

Actually, should be dropped, since there is still no way to serialize the index.


Clinical Records issue

Hi team,
We are using this library for a long time to get user's health data such as HeartRate, Height, Weight, Steps, BMI, BloodPressure. But recently the Apple team reviewers rejected our app with reason:

"Your app uses the Clinical Health Records API but your app does not appear to include any primary features that require the Clinical Health Records API.
Next Steps
To resolve this issue, please remove the Clinical Health Records API from your app, as well as any references to this app’s interactivity with Clinical Health Records from your app or its metadata.
To disable the functionality through App Store Connect, please uncheck the "Health Records" capability (leaving the HealthKit entitlement enabled), remove all the references to HKClinicalRecord class from your code, then resubmit."

although we do not using these apis (We don't check the Clinical Health Records and Background Delivery capabilities).
So is there a way for this library to detach Clinical Records module?
Looking forward to see your reply.
Thanks in advanced./.

Remove this `Clinical Health Records` from your` Signing & Capabalities`. Rebuild and upload the app. Then it will be fine

@DeepikaSharma5 I did it but it's still rejected. I think the problem is in native code with HKClinicalRecord class and the Apple reviewers detected it.

Hello @ngocht143, detaching the clinical records to a module is currently a bit complicated, but you could try to run a build script (maybe you can do it as a post-install script in the podfile) to remove the clinical records code.
You can change the clinicalTypeFromName method to only return nil, and completely remove the fetchClinicalRecordsOfType function and the getClinicalRecords RCT export block.
Sorry, I'm not sure if this is the optimal solution but should work
Running a bash script through podfile: https://stackoverflow.com/questions/26326762/run-bash-command-in-cocoapods-post-install-step

same issue 😭

did any one found solution for this issue ??

 Remove this Clinical Health Records from your Signing & Capabalities. Rebuild and upload the app. Then it will be fine

I had the same issue. My app was rejected for a week and I tried everything. I event tried to modify the package natively. But Then I did the above change.

Untick the "Clinical Health Records".
Delete podfile.lock
Delete thenode_modules
npm install
Then pod install
In XCode rebuild the project
Submit the new build as a new version.

After these steps my app got approved. Remember you need to add the new build as a new version. Please try this and let me know.

I am getting the same error using expo development build
Apple rejection reason

Your app still uses the Clinical Health Records API but your app does not appear to include any primary features that require the Clinical Health Records API.
Next Steps
To resolve this issue, please remove the Clinical Health Records API from your app, as well as any references to this app’s interactivity with Clinical Health Records from your app or its metadata.
To disable the functionality through App Store Connect, please uncheck the "Health Records" capability (leaving the HealthKit entitlement enabled), remove all the references to HKClinicalRecord class from your code, then resubmit.

This is my app.config.ts
   [
      "react-native-health",
      {
        healthSharePermission:
          "Share your health data with medical professionals at Pulsia, please allow Pulsia to access your health data.",
        healthUpdatePermission:
          "Share your health data with medical professionals at Pulsia, please allow Pulsia to access your health data.",
      },
    ],

How can i remove the clinical health records API for eas builds?


Feature/add user geolocation to header

Create the useGeolocation hook to be able to get the user location in any page/component using the Geolocation API.
Change the fixed address to the user address using Reverse Geocoding Nominatim API
Change div width style to fit bigger addresses.

Close #2

Great!! 🚀 💜


There is no wifi 2.4 data in the interfaces

Hello, I started monitoring my home system with a mikrotik hap ac^2 router and I have no data in the wifi_2.4 interface. Is it possible to fix this problem?

@metgen This is quite difficult to debug remotely. In order to get a glimpse about what's going on, you may open the explore tab in Grafana and query the metric manually:

open "Explore" inside Grafana (http://<YOUR_GRAFANA_HOST>/explore)
enter the following query: (rate(mktxp_interface_tx_byte_total{routerboard_address="XXXX", name="wifi_2.4"}[$__rate_interval]) * 8)

replace  routerboard_address="XXXX" with the address of your monitored device (the same as in your mktxp.conf)
e.g. routerboard_address="<IP_ADDRESS>"


Add the Axe, and determine how easy it was to add a new tool to the mod. Do a write-up of the process on the wiki.

There are currently only to Tools added by Forgero. The goal for the mod is to create a framework for adding your own composable equipment. The process for creating and adding tools to the Mod should be very simple and straightforward. I will try to add an Axe to the mod, And I will determine if the process of adding additional tools is satisfactory or not.

Process of adding a new tool:
Item and registry

Create a new ToolItem class
Create a new ForgeroToolType
Add axeItems to ItemFactory
Create an axehead
Add axehead to ToolPartFactory
Add axehead to ToolPartHeadBuilder
Register new patternItems
Add translation for tool and head
Add new Tag for axes to be dynamicAttributeTool and available for recipes
Manually adding these tags is extremely error prone, as I have already forgotten to add materials. This task could be automated.
Add pickaxehead to strategyfactory
Add axe to createBaseToolPartsFromMaterial
Add axe head to toolpartheadbuilder

Recipe

Manually create a new TemplateRecipe
Recipe is essentially the same as all other heads. I should find a way to generate these recipes more efficiently.
Add recipe to recipeCreator and factory
Add recipeType
Add Axeheadrecipetype to recipe loader

Texture and model

Add AXEHEAD to model types
Create new Axehead template texture
Create new Axehead binding
Create new Axehead Gem
Create secondary textures for everything
Add gem models and binding models and secondary textures

Estimated time for creating the axe - 2.5 hours


Adapt the banner to small screens, add zh_CN and french locales

@kuro282 translations need to go through Crowdin, we need to set that up on our end.
In this case, can you please separate the styling changes (adapting to small screens) from the translations? Closing this PR for now, but happy to review a separate PR for just the styling changes.


The questions

This library is nothing but garbage which requires tremendous amount of effort not only to set it up but also to use afterwards.

What's OUT_DIR here? Why isn't it explained anywhere?

include!(concat!(env!("OUT_DIR"), "/main.rs"));

"Stable Rust is a little more complicated" -> I wouldn't say a little given that it's already complicated enough.

What's "src/main.rs.IN"? Why does it have the same content as main.rs?

"While this works well with Stable Rust, be aware that the error locations currently are reported in the generated file instead of in the source file. " -> of course.

Why does it have so many dependencies?

Starting an issue with

This library is nothing but garbage
is disrespectful towards the authors of this crate, and I wonder how you would think this incentivizes anyone to provide support for you.

Usually I am the first one to plead guilty when it comes to writing these kinds of comments in initial rage, but by now I usually manage to save the draft, and revisit it next day to change a sentence or two.
As the Rust community really likes to be good to each other, I truly hope you find the time to revisit your text and change it to something less offensive. Maybe even given it a positive spin by making suggestions on how to make serde usage more convenient and user-friendly ? After all, your experience might be shared by others, and we really, really want to make it better.

@Byron , I've tried to get the hang of it a few times and it's never panned out. If it's not one thing it's another.
Suggestion - make it more like the default Rust json library rustc_serialize.

@Byron: Thanks for the support.
@GildedHonour: Please try to remain civil, and just politely ask for help. I'm here or almost always on #rust. The serde macros do some very complicated things in order to do things in stable Rust, which has absolutely no support for compiler plugins. json and rustc_serialize (which I also wrote) cheat because they're actually built into the compiler. If you want ease of use, use nightly and serde_macros, which gives you pretty much the same user experience as json and rustc_serialize. Someday we'll get official support for plugins, and we can get rid of the build scripts.


fix(table): fix disappearing borders in firefox, workspace styles

fixes https://github.com/patternfly/patternfly-next/issues/1520
You'll need to test in Firefox on windows to verify the borders no longer disappear.

Deploy preview for pf-next ready!
Built with commit dd54c16b675e6629813d0eb5125e20248db0da54
https://deploy-preview-1545--pf-next.netlify.com

Strange, in this PR i still see those two issues that I had fixed in recent PRs:

@christiemolloy I rebased, let me know if you still see those issues.

@mcoker not seeing those issues anymore

:tada: This PR is included in version 1.0.234 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add error for babel-version <6.14.0

Okay. This time I'm sure it works.
But when we include preset options, I guess it is not possible to add them as well as support this.
/cc @loganfsmyth

I'm thinking of revisiting after we get somewhere with preset options #162 as when I tried previously, it was impossible to detect and throw this custom error (with a preset function). Also we don't have any complaints about this at all now.

I'll close for now so that it doesn't distract us from other PR's


API Access Needed for "Recently Opened Files" List

Type: Feature Request
I would like to SELECTIVELY clear the list of recently opened files (including folders & workspaces) in my extension. However, I cannot find any public API to access or modify this list.
I found that there are operations on this list in src/vs/platform/workspaces/electron-main/workspacesHistoryMainService.ts, but it seems that there is no API exposed for extensions.
VS Code version: Code 1.89.1 (dc96b837cf6bb4af9cd736aa3af08cf8279f7685, 2024-05-07T05:13:33.891Z)
OS version: Windows_NT x64 10.0.19045
Modes:

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Move to inplace API rather than allocating ourselves?

We currently allocate the memory for the return array ourselves which is slightly different to how it is done in MDA.
This makes us more standalone as we don't rely on the right array being passed but leads to a more complicated on the MDA side.

Yeah it's currently in the Python layer. Shall we remove and require a results memory view to be provided ?


chore: adding semantic-release

Adding ability to auto release new updates of package

Pull Request Test Coverage Report for Build 587202867

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 587177484:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


issue with database name in the task terminal not matching with the target database

Issue Type: Bug
I am using the backupProvider to perform a full backup on a database in the SQL migration extension. The backup is completed as expected. However, when I close the extension wizard, the tasks in the terminal doesn't show the name of the database I triggered backup for. Instead, it shows the name of the first database in the database list in the extension wizard. For example, in the case where there are 3 databases in the database list in the extension wizard, when I trigger backup for the database 2 and then exit to the main page, it will show that backup database completed for database 1 and resulting .bak file is the backup for the database 2 as expected. The expected behavior is for the the terminal to show the name of the database I trigger backup for while the current behavior is that the terminal is showing the name of the first database in the db list in the extension wizard.
Azure Data Studio version: azuredatastudio Dev 1.37.0 (9ca6200018fc206d67a47229f991901a8a453781, 2017-12-15T12:00:00.000Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.59GB (16.60GB free)

Process Argv
. --disable-background-networking --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-renderer-backgrounding --disable-sync --metrics-recording-only --no-first-run --no-default-browser-check --user-data-dir=C:\Users\noksam\Documents\repo\azuredatastudio/.profile-oss --inspect=5875 --no-cached-data --remote-debugging-port=9222 --remote-debugging-port=9222

Screen Reader
no

VM
0%

Extensions: none

@NokSamLeong can you provide a link the code you're using to trigger this back-up so we can repro locally?

@NokSamLeong can you provide a link the code you're using to trigger this back-up so we can repro locally?

the file I modified: https://github.com/microsoft/azuredatastudio/blob/t-noleong/backupForMigration/extensions/sql-migration/src/wizard/databaseBackupPage.ts
the existing backup function: https://github.com/microsoft/azuredatastudio/blob/t-noleong/backupForMigration/src/sql/azdata.d.ts

steps to reproduce the bug.

open up the SQL Migration extension
click 'Migration to Azure SQL'
select 1+ databases, click next
select 'Azure SQL Manager Instance'
scroll down and click view/select
select all the database, click select and then next
select any of the subscription that would allow you to click next, then move on to the next page.
select 'offline migration, then next
select 'my database backups are on a networkshare'
scroll down to where you enter the networkshare path. Enter any network sharing path for all the databases.
click backup for all the databases.
then press cancel to close the wizard.
go to the task tab in the terminal. The task should show the same name for all the tasks.

I did comparison between my project and the backup dialog which also uses the same backup function. The bug insists even when the parameters are exactly the same. The biggest difference in the beginning of my debugging was that the Uri I get from the migration model doesnt have the backupId, databasename, and databaseDisplayName. I added those to my uri and it didnt help.

might need to checkout this commit (4efc72378e6dbfb23ae73031b13936970617ddce) instead of the newest commit to repro the bug because status checking that was added in the newest commit is blocking the task from showing up in the terminal.

@NokSamLeong when I run through the repo steps above with the dev branch you linked me, I get the following exception when I click the Backup button.  Are you sure all the changes are pushed?  No entries are added to the Task panel and the busy spinner runs indefinitely after this exception, so I'm not able to see the issue you're encountering.
mainThreadExtensionService.ts:64 TypeError: Cannot read property '625c8fcd-8cc9-4c95-876f-b2a98f4707d4' of undefined
	at c:\Users\kburt\repos\azuredatastudio\extensions\sql-migration\out\wizard\databaseBackupPage.js:885:153
	at handleNotification (c:\Users\kburt\repos\azuredatastudio\extensions\mssql\node_modules\vscode-jsonrpc\lib\main.js:489:43)
	at processMessageQueue (c:\Users\kburt\repos\azuredatastudio\extensions\mssql\node_modules\vscode-jsonrpc\lib\main.js:260:17)
	at Immediate.<anonymous> (c:\Users\kburt\repos\azuredatastudio\extensions\mssql\node_modules\vscode-jsonrpc\lib\main.js:247:13)
	at processImmediate (internal/timers.js:461:21)

It should shows the task now if you pull the latest commit. Also it is expected behavior for now that the spinner go on indefinitely because of the listener issue.


AGM breaks the Angular Language Service VSCode extension

Issue description
When I install @agm/core, the Angular Language Service VSCode extension stop working.
Steps to reproduce and a minimal demo of the problem
check the Angular Language Service VSCode extension is working properly
npm i @agm/core
check the Angular Language Service VSCode extension stop working properly
Current behavior
Angular Language Service VSCode extension stop working
Expected/desired behavior
Angular Language Service VSCode extension continue working
angular-google-maps, Angular, & any other relevant dependency versions
Angular 8, all angular-google-maps versions

Without AGM:

With AGM:

Same here


fix: when sign up is success and push a workout_page then if the user…

… tried to pop it, it will pop to black screen
Summary

Other Information

If our changes in application files (*.dart) do not requires new versions of packages, then we dont commit any modifications to pubspec.lock file. I think it is to change @tenshiAMD or @jorre127 what you think about that?

Yeah you are right
i didn't notice that pubspec.lock modified


Buggy behaviour of tgl reports span[-offset]

The -offset is sometimes is included when a grouping is selected, sometimes it's completely ignored...

https://github.com/Flow-Launcher/Flow.Launcher/blob/e1c63af06184d3993128da09373307566265e425/Flow.Launcher.Plugin/Result.cs#L162C13-L162C13
Grr... 50 minutes of debugging later 🥴
It seems like there is some internal caching that doesn't update the displayed result (and hence the AutoCompleteText and Action) if the results are pass Equals.

Related to https://github.com/Flow-Launcher/Flow.Launcher/issues/2201 and https://github.com/Flow-Launcher/Flow.Launcher/pull/2202.

Fixed (with a hopefully temporary solution).
https://github.com/JamesNZL/flow-toggl-plugin/blob/6425713de50c1b52884dd369596f7b3e9ec41a43/src/TogglTrack.cs#L2154


Support Django REST Framework 3.14 & Python 3.11.

Hm, this seems to have a flake on Python 3.7 with the ordering on Postgres. I've been unable to reproduce this locally though. Will see if it comes up in the future or not.


PWA-964 optomize product content

Pull Request Test Coverage Report for Build 1698

14 of 28 (50.0%)  changed or added relevant lines in 7 files are covered.
82 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-1.1%) to 39.761%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pages/Product/components/Characteristics/index.jsx
0
3
0.0%

pages/Product/components/Options/index.jsx
6
9
66.67%

pages/Product/index.jsx
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

pages/Product/components/Characteristics/Characteristic/transition.js
1
0.0%

pages/Product/components/Characteristics/Characteristic/components/VariantAvailability/style.js
1
0.0%

pages/Product/components/Header/components/Manufacturer/connector.js
3
22.22%

pages/Product/components/Properties/connector.js
4
0.0%

pages/Product/index.jsx
4
0.0%

pages/Product/components/Description/connector.js
5
0.0%

pages/Product/components/Characteristics/Characteristic/components/VariantAvailability/connector.js
5
0.0%

pages/Product/components/Options/connector.js
5
0.0%

pages/Product/components/Characteristics/Characteristic/components/SheetItem/style.js
5
0.0%

pages/Product/components/Characteristics/Characteristic/components/SheetItem/index.jsx
5
0.0%

Totals

Change from base Build 1697:
-1.1%

Covered Lines:
1413

Relevant Lines:
3383

💛  - Coveralls


Ipv6

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 9 committers have signed the CLA.:white_check_mark: li-xiao-shuang:white_check_mark: Sorieee:white_check_mark: steverao:white_check_mark: complone:white_check_mark: YunWZ:white_check_mark: likeyoukang:white_check_mark: HHoflittlefish777:white_check_mark: DanielLiu1123:x: snaper1You have signed the CLA already but the status is still pending? Let us recheck it.


Update left markers in UI

Added markers for all fields except name
Skills marker is truncated if width of window is too small

Codecov Report

Merging #150 (6de4796) into master (888fc10) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
- Coverage     70.65%   70.45%   -0.21%
- Complexity      515      516       +1
============================================
  Files            86       86
  Lines          1578     1584       +6
  Branches        180      180
============================================
+ Hits           1115     1116       +1
- Misses          411      416       +5
  Partials         52       52

Impacted Files
Coverage Δ

...rc/main/java/seedu/linkedout/ui/ApplicantCard.java
0.00% <0.00%> (ø)

...va/seedu/linkedout/logic/commands/EditCommand.java
95.94% <0.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888fc10...6de4796. Read the comment docs.


Multicompilation of indexXX.js files to indexXX.html outputs

Hi, consider this as a WIP / discussion opener / proof-of-concept of sorts related to #1084.
With this, it is quite easy to add multiple .html outputs when needed:

src/index.js results in index.html and accompanied bundles in build/
src/indexXX.js results in indexXX.html and accompanied bundles in build/

Verified by copying packages/react-scripts/template/src/index.js to index2.js with modifications and seeing that both yarn start and yarn build succeeded and both http://localhost:3000/ and http://localhost:3000/index2.html work and hot-reload ok, but there may well be edge cases (such as advanced configuration and router usage) so please don't merge until polished by a knowledgeable create-react-app person.
It might be better to output pages (such as src/pages/indexname/index.js or src/pages/indexname.js) to separate subdirectories (such as build/indexname/index.html), but that may necessitate larger changes in build scripts than this minimal diff.

CI failing seem unrelated to this pull request. On Travis, not enough disk space, on Appveyor, the flow server is not responding.

Thanks for this, but we're not exploring multi compilations at this time.


Allow CORS Requests

This is a simple solution to allow all CORS requests, which are necessary when using s3rver for testing web applications. I tested it with Chromium.

Hello. It would be nice if CORs is activated via an option - it should be disactivated by default. What do you think?

That's a good idea. I just added the option.

Excellent! Thanks very much. I'll push a new release to NPM tomorrow morning :+1:

@toehio  - v.0.0.10 has been released. It has also been pushed to NPM. Cheers


Signal handling does not work as expected

Ninja on POSIX systems currently puts children in their own process group. This policy causes a variety of problems, since ninja doesn't perfectly forward signals to children --- for example, C-z in the terminal sends a SIGTSTP (and then SIGSTOP) to ninja, but since ninja doesn't do anything special for SIGTSTP, the compilation jobs keep running. SIGINT frequently doesn't interrupt compilation jobs either.
In GNU Make, all of these interactions work as you'd expect.
Why do we need to put subprocesses in their own process group? This whole issue disappears if we don't put children in their own process groups, let them inherit the controlling terminal, and allow signal propagation to work normally.

See #744 for SIGSTP
For SIGINT check #893 and make sure your ninja includes the referred patch.

Found a potentially related signal issue today.  If you're piping the ninja output to something that closes the pipe, e.g. grep -q, it can return non-zero status.  Perhaps this is what you want?  Most programs ignore the SIGPIPE here.
$ cmake --build . --target help  | grep -q foo
SIGPIPE
CMake Error: Generator: execution of make failed. Make command was: ninja -j 6 help &&


Delete compression version history from HISTORY.md

This module is excellent! brotli's going, the config  is intuitive, and documentation are excellent.
One minor nitpick: the version's not consistent.
According to https://github.com/aickin/shrink-ray/blob/master/HISTORY.md it's 1.6.1
According to https://www.npmjs.com/package/shrink-ray it's 0.1.3
Maybe update both and publish 1.6.2 on npm (as the module seems pretty stable now and 1.6.2 is more semver-y).

Thanks Mike!
The 1.6.x versions are the versions of compression (which this was forked from) whereas 0.1.3 is the version of this (shrink-ray). I guess I should modify HISTORY.md to reflect this project only; I'll change the title of this issue. Thanks!

Since this project is mature, it could be good release a new version with a post-1.x version. 0.1.3 can seem a bit experimental. Maybe 2.0 since it's a breaking change from the old compression module?

From: Sasha Aickin<EMAIL_ADDRESS>Sent: Wednesday, April 5, 2017 11:26:30 PM
To: aickin/shrink-ray
Cc: Mike MacCana; Author
Subject: Re: [aickin/shrink-ray] Is latest version 1.6.1 or 0.1.3? (#7)
Thanks Mike!
The 1.6.x versions are the versions of compression (which this was forked from) whereas 0.1.3 is the version of this (shrink-ray). I guess I should modify HISTORY.md to reflect this project only; I'll change the title of this issue. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/aickin/shrink-ray/issues/7#issuecomment-292015344, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAKiMvdjLrziNvfdER4cKK9BS27cslw8ks5rtBUWgaJpZM4MzPpI.


Ant movement based on pheromone

I have thought about the process of how ants decide their next movment based on the pheromones left behind:
Imagine an ant its coordinates (x, y). The ant decides where to go next based on the pheromone levels, around it. The ant can only move a certain number of steps (Ant.step_size) at a time .

Example 1 – Step Size 1:
Let's say the ant is at (4, 6). With a step size of 1, it looks at the pheromone levels at nearby spots:
(3, 5), (3, 6), (3, 7), (4, 5), (4, 7), (5, 5), (5, 6), and (5, 7).
It chooses the spot with the strongest (or weakest, depending on the goal) pheromone level.
Example 2 – Step Size 2:
If the ant starts at (4, 6) but can move 2 steps, it checks pheromone levels at spots further away:
(2, 4), (2, 6), (2, 8), (4, 4), (4, 8), (6, 4), (6, 6), and (6, 8).
It again picks the spot with the strongest (or weakest) pheromone level.
After finding the best spot based on pheromones, an angle α between the ant's current position and its intended destination should be calculated.. This angle helps decide which way the ant should move.
For example, if the best spot is at (6, 7), the angle between the ant's current spot (4, 6) and (6, 7) is calculated, and the ant moves in that direction. Ant.move(angle_offset = α)
PS: These are initial thoughts on how this process works. I welcome comments or suggestions for improvement.

For example, if the best spot is at (6, 7), the angle between the ant's current spot (4, 6) and (6, 7) is calculated, and the ant moves in that direction. Ant.move(angle_offset = α)

Can you please explain more detailed which angle should be calculated exactly?
(I guess you probably mean in a right-angled triangle)

If the ant starts at (4, 6) but can move 2 steps, it checks pheromone levels at spots further away:
(2, 4), (2, 6), (2, 8), (4, 4), (4, 8), (6, 4), (6, 6), and (6, 8).

Moreover in your Example 2 you did not mention the spot (6,7).
It's important to know, if we only consider coordinates on the horizontal, vertical and diagonal lines - I guess this is a better approch- or all points after a step size (this would be the outline of a square then).
Please include a picture / drawn diagram! 😄

For example, if the best spot is at (6, 7), the angle between the ant's current spot (4, 6) and (6, 7) is calculated, and the ant moves in that direction. Ant.move(angle_offset = α)

Oops… I meant of course any index/spot from the ones I listed or from the ones whose pheromone levels were checked. This was a typing error, I meant (6, 4).
Regarding the calculation of the angle. I think it should not be calculated between two vectors as i mentioned, but only from the new position vector, which points in the direction of the highest pheromone level in the vicinity of an ant. See video:
https://github.com/heyitsalina/ant_search_algorithm/assets/147917604/037b0beb-e5ef-43fc-86cd-cd7c9b87aa96
@tis22 Today we can talk more about it at the meeting..

So the angle can be considered as from the origin to the new position - not from the current ant coordinates to the new position?

In our todays meeting we decided that we need a mapping-method to map the current coordinates of the ant to the associated position in the pheromones-array (see #87).

the horizontal, vertical and diagonal lines - I guess this is a better approch-

We will use that approch.

For the search of the strongest or weakest (depending on the goal) pheromones a new method find_pheromone_target is needed.
This method examines which value in the array is the strongest or weakest in a range of a given step size.
If all values within this step size are of one value (f.e. 0 or 1 or -1) a random direction will be picked.
In the next epoch the find_pheromone_target-method will examine the pheromones within the stepsize again and look for a max or min value / decide for a random direction again.
After the direction array-element is found, the direction will be updated.
Therefor an angle is calculated by the array-indices(?) of the element with the min/max-value (see video above).

Question @AlhaririAnas:

Don't I need the mapped coordinates for this calculation?
If I use the coordinates will the ant-movement headed to the center or the top left corner? (maybe if f.e. for the x-axis the mapping calculated an width of 3 the center must be 1.5) - I guess the center would be the best idea.

The red dots are the two possible new positions of the ant after the movement:

After all the angle is returned to the ant.move-method to do the movement.

@tis22:

Don't I need the mapped coordinates for this calculation?

No, we only need the mapped coordinates to determine where the ant is located, i.e. which pheromone index (cell) it belongs to.

If I use the coordinates will the ant-movement headed to the center or the top left corner? (maybe if f.e. for the x-axis the mapping calculated an width of 3 the center must be 1.5) - I guess the center would be the best idea.

The pheromone index should correspond to the center position, that makes the implementation easier and more understandable. I agree with you, therefore.

If anything is still unclear, please let me know.

If the code does the calculation for the angle by using the indices of the pheromones-array this would not be the center, as far as I can tell. I guess this would be the top left corner then.
If we want to use the center I need to know how the mapping was or is performed:

(maybe if f.e. for the x-axis the mapping calculated an width of 3 the center must be 1.5)

Because of this I think I do need the mapping informations.

@tis22
The step_size is now implemented in our code, and it is being used. I don't think we can do without it, so the step_size should not be hardcoded to always be 1.

Please answer the previously written comment.

Here is a calculation for the center of the pheromone spot with the highest pheromone level:
I hope this could help you further.

Do we really want/need a step_size > 1?
Until now we have not discussed this in the meeting.
Since we update the peromones every epoch it could be useful that the ants can move only on step at each epoch also.
I've got a solution for step_size > 1 but it makes the code more complicated and errors could occur easier.

I now have a better understanding of what you mean. I suggest we initially assume that the step size is 1. This means we should only consider and compare the immediate surrounding pheromone spots. It's possible that we might not need to take the step size into account at all. I will think about it and leave a comment once it becomes clearer to me

I made a commit of my current working state, please refer to it (39ed330).
The part highlighted in blue:
These indices will be given to the new find_pheromone_target-method.
The part highlighted in yellow:
These indices will be determined by the find_pheromone_target-method.
The method returns – as you intended – the arctan, not the target-indices.
The part circled in red:
This has to be part of the mapping-method OR the return of the find_pheromone_target-method has to be changed to the (not mapped) indices of the target-spot.
This is what I already questioned you above and in Issue_87.

@AlhaririAnas Refer to the comments above.
Please delve deeper into the problems with your original idea.
It's best if you also understand my commit.

Regarding my approach, it may not necessarily be correct, and there's a chance I might have made mistakes. That's why I mentioned: 'PS: These are initial thoughts on how this process works. I welcome comments or suggestions for improvement.' So, if you disagree with my approach, feel free to think about and apply a different method. The most important thing is to accomplish the task.
I carefully reviewed your code with the commit (39ed330) and had difficulties understanding everything. It's possible that the code is too complex for me.
I'm trying here once again to articulate what needs to be done with this issue and request a recoding.
Objective: Develop a method named find_pheromone_target_idx in the Pheromone class. This method aims to identify the index of the strongest or weakest pheromone in the immediate vicinity of an ant, depending on the pheromone's state.
Parameters:

idx_ant_pos: The current position of the ant.
pheromone_status: The state of the pheromone, indicating whether to search for the highest or lowest value.

Functionality:

The method should scan the neighboring cells around the ant's current position.
It reads the pheromone value of each cell and decides, based on pheromone_status, whether to search for the highest or lowest value.
The method returns the index (x, y) of the cell with the targeted pheromone value. If all surrounding cells have the same pheromone value, return None.

Pseudocode:
Method find_pheromone_target_idx(idx_ant_pos, pheromone_status):
Set target_pheromone_value to 0
Set idx_target_pheromone_value to (0, 0)

Get n_rows and n_cols from the shape of pheromone_array
Initialize unique_pheromone_values as an empty set

Set depth to 1
If pheromone_status is -1, set depth to 0

For i from idx_ant_pos[0] - 1 to idx_ant_pos[0] + 1:
    For j from idx_ant_pos[1] - 1 to idx_ant_pos[1] + 1:
        If i is within 0 and n_rows and j is within 0 and n_cols:
            If (i, j) is not idx_ant_pos:
                Add pheromone_array[depth, i, j] to unique_pheromone_values

                If pheromone_status is 1 and pheromone_array[depth, i, j] > target_pheromone_value:
                    Update target_pheromone_value
                    Update idx_target_pheromone_value

                Else if pheromone_status is -1 and pheromone_array[depth, i, j] < target_pheromone_value:
                    Update target_pheromone_value
                    Update idx_target_pheromone_value

If unique_pheromone_values has only one value, return None

Return idx_target_pheromone_value

Step size and the calculation of the angle can be ignored for now!

As stated above my commit already does what was asked for in this issue.
I haven't come up with a new idea yet, which is why I asked you for your other ideas and wanted to discuss them with you.
I think you again don't understand the problems I described.
I'll repeat my points here so that you can understand them better:

Step size is fully implemented.

Function to search the field with the highest level of pheromones is implemented.

If all fields (within the step size) have the same value (f.e. all have pheromone-level 20; or all have pheromone-level 0) the return is movement_angle = 0 currently, as this leads to a random selection of the field in the ant.move-method.

If only two fields (within the step size) have the same value, the choice between the two will be random.

The angle to the field with the highest pheromone-level movement_angle is returned in all cases at the moment.

Since this approach is apparently (somehow) faulty, I pointed this out to you and said that we can change the return to the index of the field with the highest pheromone level, as you also mentioned in your last comment.
Note:
The return is only the index of the field in the pheromone array.
In order for the ant to walk to the center of the field, this coordinates must then be mapped to the center using the mapping method.
This (direction of the mapping) still needs to be added to the mapping method.
Summary:
In summary, you only have to tell me whether I should change the current implementation so that the function returns the indices of the field with the highest pheromone-level.
As I said, you will (very likely) have to change your mapping method then so that the ants move to the middle of the field if given this coordinates. This mapping should not be done in the find_pheromone_target-method as it depends on the mapping of the mapping-method.

Yes, please modify the implementation so that the method returns the relevant indices.
With these indices, a new method I've coded, called "calculate_pheromone_target_pos()", will be integrated into the simulation. It will compute and return the central position of the field with the highest or lowest pheromone level.
For the time being, disregard the use of Step_size. The reason is that when pheromone fields cover a large area, such as a board size of 480x720 with a grid_shape of 50x50, an ant can take multiple steps within a single field. Hence, employing Step_size in this scenario does not provide an advantage.

DEADLINE FOR THIS ISSUE:
14.02.


Multiple column search

how can add a search box for each column similar to this

Hi... after checking, it seems that the gridApi doesn't support this behavior, I will look into adding it but it may take a few days please be patient :)


feat: Localization

@deer I've set up basic localization, this should solve #14 and #15.
It currently only has English and Spanish but we can add more languages at ./src/utils/localization. There is also a switch statement in ./src/plugin/blog.ts that checks for the lang set in blogOptions. If someone wants to customize their own words they can add a second parameter to blogPlugin(). You can see this working at ./tests/localization_fixture. I added some instructions to the read me but I feel like they could be more clear.
Let me know if this works. Cheers!

@deer This was lazy Sunday coding. I've implemented all of the suggestions mentioned above. Last thing I need to do is figure out a better way to switch the languages with out using a switch statement. That section of code could get quite large as the project grows. I'll also create some tests and do another PR after work today.

Cool, looking forward to the next iteration! Just out of curiosity: why close this one and open another instead of just adding to this?

@deer Not sure why I did that, lol. I'll reopen to keep things clean.

@deer 🤞 I did better this round

Looks like I need to sort something out with notion. I will look more properly at this later today. Thanks for following up!

Let me know if I can help.

Google to the rescue: https://github.com/orgs/community/discussions/26163
What do you think is the most expedient way to resolve this? A few options:

I can promote you to a collaborator and then you could push against the repo.
I can cherry pick the commit from your fork and push to the repo.
As a longer term fix, something about refactoring the tests to isolate notion so that these run less frequently.
I'll look to see if there's an easy way to make a notion database public, so that there's no need to authenticate.
The shortest term fix is that I'll pull your branch and run the tests locally, then just go ahead and merge after I complete the review.

Starting to review the actual changes now.

Google to the rescue: https://github.com/orgs/community/discussions/26163 What do you think is the most expedient way to resolve this? A few options:

I can promote you to a collaborator and then you could push against the repo.
I can cherry pick the commit from your fork and push to the repo.
As a longer term fix, something about refactoring the tests to isolate notion so that these run less frequently.
I'll look to see if there's an easy way to make a notion database public, so that there's no need to authenticate.
The shortest term fix is that I'll pull your branch and run the tests locally, then just go ahead and merge after I complete the review.

However you want to go about this works for me. I definitely want to help with this project going forward so let me know how I can help. I've never used Notion before so it would take me a second to get used to it.

Ok, obviously I'm still a bit new to the open source thing, since the way I've set it up has made it impossible for you to get a passing run on your machine. I'll have a think about that, but in the meantime, your changes are passing just fine locally for me.

I'm new to contributing to open source as well. Good to know were in the same boat.

This is really nice! Thanks so much for contributing. A few really minor comments, and then a suggestion if you want to go the extra mile. Not sure how up-to-date you stay with the latest fresh releases, but in 1.4 there's the possibility to set the lang attribute in the html tag much easier. See https://deno.com/blog/fresh-1.4#custom-html-head-and-body-tags for details. I guess the lang property you've introduced would be perfect for driving this. Of course I can always log an issue and do this later. After your great work here it should be very easy to implement!

Thats a great idea, I'll work on it today after work. I see "$fresh/": "https://raw.githubusercontent.com/deer/fresh/feat_plugin_islands/", in deno.json shouldn't this be the default $fresh import for 1.4?

Just did some clean up of code.

Oh, one other fyi for the future (in the hope that you continue contributing... 🙏 ): https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
So you can write closes #14 , closes #15 (or pick your favorite word from the list in the link), and then the issues get closed when the PR is merged.

Good to know, thanks!


Travis build is failing

The travis build is failing with
sh: 0: Can't open /etc/init.d/xvfb
The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during

so the file .travis.yml may need to be updated for this?

Hello @mike-goodwin , I tried this:
    packages:
      g++-4.8
+     xvfb
before_install:
-   "export DISPLAY=:99.0"
-   "sh -e /etc/init.d/xvfb start"
-   sleep 3 # give xvfb some time to start
+   export DISPLAY=':99.0'
+   Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &

which got past the shell errors, but then tripped up because of not finding packages that have been commented out and added to test.js:
//require('angular-mocks');
//require('phantomjs-polyfill-find');


Unable to find market listing item image

Bug: After signing in with steam-market-history CLI, command fails to find listing item image and errors out.
Steps to replicate:

Run the following command: steam-market-history export --csv --path
Login to CLI
Error will occur after a few seconds

Traceback:
   File "<path>\steam_market_history\modules\steam.py", line 63, in fetch_market_history     market_listing_item_img = row.find("img", class_="market_listing_item_img")["src"] TypeError: 'NoneType' object is not subscriptable

Hey @RyleyGG,
I was able to recreate the error and fixed it immediately. It seems there was an change in the Steam API, which causes empty image src tags. The new behaviour is that images will be ignored if not present.
Thanks for contributing and have a nice day!

steam-market-history 3.0.4 is now available: https://pypi.org/project/steam-market-history/


Merge 1.0.61

@lenny-lunarg Is there some reason this isn't in master already? Looks clean so far on our farm. I have some other changes I want to land soon which depend on 1.0.61.

The reason I didn't stick it on master is that @mikes-lunarg usually pushes this stuff back to master after we release an SDK from private material and since he's been at the F2F, I hadn't wanted to push it without first checking with him. There shouldn't be any reason we can't push it to master — I had just intended to check with Mike before I did it.
We can get him to make sure it's fine for master. The one other thing I need to do is that I'm going to cherry-pick another commit over to the SDK branch and tag that as <IP_ADDRESS>. It's a fix to vulkan.hpp which we're going to release a <IP_ADDRESS> SDK for shortly. Not having that fix won't brake the repo, bit if other people try to use vulkan.hpp from the repo. it'll give them trouble.

Alright, so this might be a little complicated.
You can merge this branch in the way you have it now if you're in a hurry to get this stuff in, but that wouldn't be my first choice. Merging this will not break the repo, but if people are using vulkan.hpp from this repo, then the change may break their code. I have a fix for the vulkan.hpp problem on the sdk-1.0.61 branch, but the fix requires Visual Studio 2015 on Windows (because 2013 doesn't support constexpr). This means that if you pull in the latest commit, our test farm will start failing for the repo and yours might, too. @cnorthrop, what version of Visual Studio are you using for Windows testing? If it's 2013, how long would it take you to upgrade to 2015?
My preferred solution to this would be to hold off on merging in the 1.0.61 content until we can upgrade our test farm to use 2015 (which should take about a day). Then I'd want to pull over both of the commits  that are currently on the sdk-1.0.61 branch, which would break Visual Studio 2013 support.
If either you don't want to break VS2013 support, or you want to get this stuff in quickly, then I'd also be fine with just merging this PR as-is. This will leave us with a messed up vulkan.hpp, but it won't cause any problems for our repo.
The basic problem we've been having is that vulkan.hpp started using constexpr, but that isn't supported by VS2013. As a result, we replaced constexpr with const for the <IP_ADDRESS> SDK, so that it would still build with VS2013. However, since constexpr implies inline, Visual Studio decided to stop inlining these functions, and generated multiple copies of the functions (from including vulkan.hpp in multple cpp files). This causes linker errors because the functions were redefined in every cpp file that included vulkan.hpp. We could have tried to use const and inline to replace constexpr, but since making our own changes to vulkan.hpp were what caused the problem in the first place, we weren't real keen on doing that again.
Let me know if you're alright with waiting a day or two, and if this will cause problems on your test farm.

I should be able to upgrade our farm to 2015 tomorrow.

We've updated to VS2015 on our side.

We've updated to VS2015 on our farm as well. I've pushed 1.0.61 commits to master now. I did it by cherry-picking from the sdk-1.0.61 branch instead of merging this PR because @mark-lunarg didn't like the merge commit.
In any case, I'm closing this PR because it's been de facto merged.


Making result (pagefind-ui__result) clickable instead of title

Right now, the element with class pagefind-ui__result-link is the one that is actually clickable. How is it possible to make the whole result clickable? (The li element with the class pagefind-ui__result )

Especially the optional image left to a result is expected by most userers to be a clickable link to the hit. see #235  posted long ago

Is there any workaround possible?

I think it should be possible with these styles:
.pagefind-ui__result {
  position: relative;
}

.pagefind-ui__result-link::after {
  position: absolute;
  inset: 0;
  display: block;
  content: "";
}

.pagefind-ui__result {
  position: relative;
}

.pagefind-ui__result-link::after {
  position: absolute;
  inset: 0;
  content: "";
}

That worked well thanks! A more modular/minimal UI solution that you have more control over yourself would be a nice photo addition, but this will most definitely do for now. Thanks a lot :)

@alexanderameye you're welcome, happy it worked!

I tried (using a modified pagefind-ui.css of the default UI) but without success - in which file do you have to add this?
e.g.
.pagefind-ui__result.svelte-j9e30.svelte-j9e30{
    position:relative;
    list-style-type:none;
    display:flex;
    align-items:flex-start;
    gap:min(calc(40px * var(--pagefind-ui-scale)),3%);
    padding:calc(30px * var(--pagefind-ui-scale)) 0 calc(40px * var(--pagefind-ui-scale));
    border-top:solid var(--pagefind-ui-border-width) var(--pagefind-ui-border)
}
.pagefind-ui__result-link.svelte-j9e30.svelte-j9e30:after{
    position:absolute;
    inset:0;
    content:""
}
.pagefind-ui__result.svelte-j9e30.svelte-j9e30:last-of-type{
    border-bottom:solid var(--pagefind-ui-border-width) var(--pagefind-ui-border)
}


build error with windows in top-of-tree

With top-of-tree (aka 0696db96700f2b8) I'm seeing this error with Windows builds. (I assume it's just a matter of a missing cast.)
Error: C:\Users\runneradmin\go\pkg\mod\github.com\veandco\go-sdl2@v0.5.0-alpha.3.0.20220912155024-0696db96700f\sdl\guid.go:38:33: cannot use _cap (variable of type _Ctype_ulong) as type _Ctype_ulonglong in argument to (_Cfunc_SDL_malloc)

Hi @mmp, thanks for the reporting of issues again! It should be fixed in the master branch now.

Looks good now--thank you!


using with browserify

I've installed textures using npm install textures --save-dev but when I try and require('textures'); it is returning as undefined.

You can try this:)
##main.js
var xx = require('./node_modules/textures/textures.js')
console.log(xx)

build bundle.js
browserify main.js > bundle.js

test.html
<html>
  <head>
  <script src="bundle.js"></script>
  </head>
  <body>
  </body>
</html>

It is working.

Thanks, it's now working. I'm including like this -
var textures = require('textures/textures');
Is this a problem with browserify? Is it possible to change it so you can simply use require('textures');

You can closed this issue now

Done.


Is there a scraper for Elsevier

Did you create a scraper for Elsevier (I know the lazy load Javascript needing addressing)? I seemed to remember you created at least a prototype. We shall need one.

This should be an issue on http://github.com/contentmine/journal-scrapers.
There is a sciencedirect scraper in the non-open branch of that repo: https://github.com/ContentMine/journal-scrapers/blob/non-open/scrapers/science_direct.json

On Sat, Jun 13, 2015 at 9:07 PM, Richard Smith-Unna <
<EMAIL_ADDRESS>wrote:

This should be an issue on http://github.com/contentmine/journal-scrapers
https://github.com/contentmine/journal-scrapers.
There is a sciencedirect scraper in the non-open branch of that repo:
https://github.com/ContentMine/journal-scrapers/blob/non-open/scrapers/science_direct.json

does "non-open" mean that the papers are non-(Open Access) or that the
scraper directory itself is not public - I'll assume the former.

—
Reply to this email directly or view it on GitHub
https://github.com/ContentMine/quickscrape/issues/49#issuecomment-111743979
.

--
Peter Murray-Rust
Reader in Molecular Informatics
Unilever Centre, Dep. Of Chemistry
University of Cambridge
CB2 1EW, UK
+44-1223-763069

Yes, the former.


CV/VA-API interop feature implemented - core support & sample

:+1:

@avershov Please squash commits into one.

done
On 08/20/2015 03:30 PM, Alexander Alekhin wrote:

@avershov https://github.com/avershov Please squash commits into one.
—
Reply to this email directly or view it on GitHub
https://github.com/Itseez/opencv/pull/5171#issuecomment-132991894.

:+1:


Errors during running the KST realTimeImpedence demo

Hi, Dr. Safeea,
I’m Tian. After dealing with the previous problems, we run the demos in the KST, which are really wonderful! However, not every demo can be run successfully, such as the ‘KSTclass_Tutorial_realTimeImpedencePlotTorqueFeedBack.m’.
Our tool mass is 2.3 kg, the COM is [-8,0,65] mm. The parameters are found in our gripper manual. Firstly, we use these parameters, but some errors appear in the SmartPad and the matlab, which said 'java.lang.IllegalStateException:Load Mass Validation Failed axisTauExtMsr[1] of LBRExtTorque@LBR_iiwa_14_R820_1 is 12.171958888630373 should be less than 10'. The errors are shown below. I have also tried to modify and use different tool parameters in the matlab code, but it does not work.  Besides, I also search the solution in Google and Github, but I find no solution to this.
In addition, about the KST gamepad demos, we can run them successfully, and we can use the left handle of gamepad to select different axis of iiwa, but we cannot move the joints by using the right handle of gamepad. We really don’t know why.
We will appreciate your help very much if you can help us analyze these problems! Especially the impedence control demo!
I’m really sorry to disturb you so much and looking forward to your reply.
Best regards,
Tian Xu.

Dear Tian:
For the impedance mode issue:
From inside the class SmartServoWithImpedence.java, go to the line
if (!ServoMotion.validateForImpedanceMode(_lbr))
And change it to
if (!ServoMotion.validateForImpedanceMode(_toolAttachedToLBR))
If it works, tell me so I push the changes into the repository.
For the joyetick issue:
Probably this issue is due to the assignement of the joystick inputs. Conesqeuntly, run the following script from an inside (.m) file in Matlab,
close all;clear;clc;
instrreset;
ID=1;
joy=vrjoystick(ID);
%% Loop for reading the jpystick
while true
     joyStatus=read(joy);
     disp(joyStatus);
     pause(0.1);
end
At the same time push the jpystick handles then show me the output
Regards

Hi, Dr. Safeea,
For the impedance mode issue:
I have changed the code in the SmartServoWithImpedence.java, but unfortunately, the same error still exists. Our tool load data are 3kg and [7.9,7.1,144.4] mm in the Smartpad. The errors message are shown here. Will the frame of the tool affect the impedence validation? I just guess that.

For the joyetick issue:
I have run the script that you give, and the output are shown here.

Thank you for your reply and help all the time very much!
Best regards,
Tian Xu.

Hi Tian,
Regarding the impedance:
I expeirmented with 3.8 Kg weight at the EEF, and the program worked fine as shown in the video.
Probably the problem is due to some safety configuration (Torque Limit).
Check torque limits in the "SafetyConfiguration.sconf" file.
Regarding the joystick:
The script "KST_gampade_jointsPosControl.m", utilizes the joyStatus(3) to move the joint at Line 99.
From the photo you sent, I notice that the value of joyStatus(3) is almost zero (am not sure whether you are pressing the joystick, or whether matlab is not getting a proper reading from the joyStick).
Since the readings are almost zero, probably this is the reason why the robot is not moving.
Note that, in the script "KST_gampade_jointsPosControl.m", for the robot to move there shall be a reading at joyStatus(3)  simultaneously the reading at joyStatus(2) shall be less than 0.02.
Cheers!


feat: adjust principal recipients in location page

:tada: This PR is included in version 1.2.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add search location in create campaign map

Problem
User need to be able search a location easily when creating a campaign.

added
https://github.com/hotosm/field-campaigner/pull/131


Difference between Readme and code

The Readme says: "OPTIONAL: Currency, CHF by default", but the linked code says: "self.currency ||= 'EUR'" see:
https://github.com/viafintech/sps_king/blob/60872692e92e5746ff07d361fcb2195e82ee2140/lib/sps_king/transaction.rb#L46

You are right. The documentation is correct here and it is not correct in the code. I will adjust it and release it as a bug fix release.
It just doesn't make any sense to default to EUR here.
In our code we never noticed because we always pass it explicitly

Resolved and released in v0.3.1


Centralizing and Synchronizing Annotation Projects Across Distinct Document Sets

Problem:

Each annotation project operates on its unique set of documents.
The goal is to establish a highly efficient, compact set of deeply annotated documents.

Key Considerations:

Some annotations generated by Pubget are still in an older format-- we need tooling to update old annotations
Certain projects will remain distinct by nature (e.g., fMRI versus diffusion studies), yet it’s essential to enable synchronization across annotations for consistency and utility.

Proposed Solution:

Centralize Source Documents:

Place all source documents at the top level of the repository to facilitate organization and access.

Distinguish Document Sources and Annotation Subsets:

Clearly differentiate between document sources (e.g., specific Pubget searches) and the annotated subset of documents. For instance, a search might retrieve 1,000 articles, but only the first 100 might undergo detailed annotation.

Streamlined Access for Annotation Projects:

Allow each project to project down to its annotated subset to simplify access within Labelbuddy, making subsets easily accessible for project-specific workflows.

The main issue with this approach is that it will require quite a bit of work on updating the existing tooling that Jerome wrote, including the website etc.
Alternative Solution: Streamlined Organization without Full Centralization

Maintain Project-Specific Document Sets:

Keep each project’s document set within its own folder to avoid merging everything at the top level. This preserves the existing structure and minimizes changes.

Implement Annotation updating tools:

Use pubget to reprocess all annotations in the whole project to the latest versions, making them mergable

Implement tools for better merging of documents in existing projects:

Add tools to see which documents have been documented already in other projects, and search within those documents using certain criteria (i.e. new search terms), maximizing the chance that you annotated documents with existing annotations.
If new documents are needed for a specific annotation project, a new pubget search can be done and only top n documents included.

Other relates issues:
https://github.com/neuroquery/pubget/issues/46

I'm starting to learn towards the latter option.
I think the key would be to add tooling to search documents in other project (e.g. full text search) to see if they meet your criteria, and copy those that meet those criteria to your new project folder.
This would make it easier to say something like: I want "resting-state" documents that were also annotated by "participant_demographics".  Let's say 52 of those match, then copy those into my new annotation project folder.
In addition, we might want to allow for sub-projects, so we can then group together all the "cobidas" related sub-annotation projects together (in recognition that there's non overlapping sets of docs for cobidas, and its easier to annotatate one thing vs many).

I'm realizing that Jerome's excellent documentation actually covers this under Reusing documents from another project
However, the proposed solution is just to do a symlink to another project. I wonder if a better solution is to allow users to remix documents from other projects?

thanks @adelavega that's very interesting. indeed it would be great to use the same documents in different annotation projects as much as possible, as it might help study associations between the different things being annotated.
For that as you mention we need a way to explore already existing documents and define new subsets that we will annotate. Maybe there are some lessons learned from the design of the neurosynth-compose StudySets & co that we can apply here?
this might also be an opportunity to revisit how we store documents. ATM the JSON files to annotate are directly in the github repository which is simple and guarantees we always have all the correct documents but means we have to be very careful not to add too many, so there may be a better solution.

However, the proposed solution is just to do a symlink to another project. I wonder if a better solution is to allow users to remix documents from other projects?

yes the symlink approach is probably too limiting because it assumes you will basically work on the same document set as another project, rather than regroup documents dispersed across many files. I think having a couple of use cases, example projects that need a more complex selection of documents, would help a lot in finding a better solution. I'm guessing we could do something similar to the symlinks but slightly more expressive: in the project directory we could have a file containing a list of pmcids and where to find them in the repo, and reconstruct the labelbuddy file when we run start_project.py or something like that?
for finding and selecting the documents we could use the database created by make database, possibly adding more information to it. the question is how to make something usable without spending a lot of effort on building an interface for inspecting and choosing documents

that sounds similar to what I was thinking: the project specific label-buddy files could be "temporary" but can be recreated from a central "repository" on the fly given a list of PMCIDs that are annotated in a given project.
regarding where to store this "repository", perhaps we can use datalad/github-annex or something if size becomes an issue, but we can probably punt that issue for now.
also, it's probably best for the repository to include the label-buddy JSONs, instead of recreating them, in case the text changes which would make the annotations hard to interpret. i would not want to rely on re-downloading them as they could chane. specific documents can be remixed with others into new json-l files, however.

in terms of use cases here is one:
we want to annotate various aspects of COBIDAS, but it is rather large. So for some sub-projects that only cover a modality (e.g. fMRI/Diffusion), you only want to annotate relevant documents. it's annoying to have to skip irrelevant ones, so ideally you effectively filter those out using key-words.
however, there are also aspects of cobidas that would also span modalities, so you'd want to annotate all of those documents on another dimension (say: data sharing statements).
it's possible that this use case could be handled by symlinks if you thoughtfully create the subsets prior to starting annotation.

finally, in terms of finding relevant papers, i agree this is challenging. perhaps this can be a less controlled process which we facilitate through the python interface, but may still require some amount of user intervention to create a final list of PMCIDs to include in a project.
then it is added to a project and a script populates a "view" of labelbuddy files for annotation.

I'm still not 100% sure we should do here, but my feeling is we're getting too scattered, so either we need to have more discipline about how we get documents for annotation, or centralize all documents and check out temporary views for annotation only

We could also take a more hands off approach and add a "shared_documents" folder, and do a 1 time re-organization right now where we group documents into useful subsets

great!
I started working on centralizing the annotations by doing something similar to what you outlined.
My approach was to:

look at all existing documents and re-download them using pubget in a temporary directory (since this can always be recreated we don't need to keep it)
check in all the labelbuddy documents from this dump into a central documents/ directory (maybe should only keep those w/ existing annotations, but currently I kept all those referenced in projects).
each project has pmcids.txt file which outlines which of the centralized documents are relevant for this project

the above is a one time migration operation
still to do:
4) write a script that can "check out" documents for a project (from the pmicds.txt file) from the centralized location into a {project_name}/_documents directory inside each project, to open in labelbuddy to annotate.
_documents folders are in .gitignore.
(it seems okay to me for annotations to be kept within a project)
then in the future if somebody wants to get new documents for a project, there could be a script that:

given a pubmedcentral search (which is specific enough), and a target number of documents (e.g. 100), finds the overlap between that search and already annotated documents, prioritizing existing documents.
if, for example, 100 are requested, and 70 overlap with existing documents, only 30 new articles need to be added

we could also add a "clean up" script which removes all documents that have no annotations in any projects.

the only potential issue I see with this approach is its less intuitive, especially if finding target documents is hard to do with a specific PMC query. But we could also allow users to just come up with a custom pmcids.txt file with whatever method they see fit (including manually browsing documents, or doing a broader search than necessary and then running the clean up script).
also perhaps you are right and only document with annotations should be checked in to save space.

the above is a one time migration operation

sorry I hadn't realized that, so you can ignore most of my comments on the pr -- we don't care too much about details of the script if we'll only run it once. but of course it should be obvious moving all documents into one place only needs to be done once :sweat_smile:

since this can always be recreated we don't need to keep it

I wonder if we want to keep the pubget output somewhere? if later the article in pubmed is different or not there anymore and we want to get the original full xml that produced the thing we annotated? maybe not worth the storage & effort

_documents folders are in .gitignore.

those you could also discard after populating the labelbuddy database
re. getting new documents, I agree the script you describe would be useful but for now we can say "come up with your pmcid list" is the current solution
one advantage of not keeping documents without annotations in inactive projects is that if I am lazy I will prefer to use documents that are already available in the repo, and if it only contains documents that are annotated or very likely to be annotated I will end up annotating the same documents as other projects which is what we want

My bad, I should have marked the PR as WIP, which it is.
Not sure if we even need to keep track of the one time migration script then
As far as original pubget output, we could keep it in a folder that is not checked in by default.
Yes, agree, for now we can punt on the search scripts and just tell projects to come up with a pmcid list in a way that best fits their needs. Also agree that it's good to nudge projects to re-use docs. Will add that to PR.

Closed by #40


Tips Modal Spacing Off on Mobile

Issue Summary: On mobile, the tips modal has no margin.

Browser/Operating System: iPhone 5S, iOS 8.3

Issue Scope: Happens on at least two campaigns's tips on mobile, FAQ modal on mobile works fine. Desktop modals look correct.

@DFurnes another lingering neue thing. This is the Do It section tips. We put them in a modal on mobile; there is no modal for these on desktop, instead they are in the gray box in the Do It section.

Ooooof. :sweat:

Hate to be a pain @DFurnes -- seems like this is still an issue :( Could we chat about this on Monday? Thanks!

It's fixed on staging, but hasn't been deployed to production yet!

yeah i just deployed to staging so you can verify @namimody!

Ahhh I'm so sorry!!
On Fri, Jun 5, 2015 at 3:19 PM, mikefantini<EMAIL_ADDRESS>wrote:

yeah i just deployed to staging so you can verify @namimody
https://github.com/namimody!
—
Reply to this email directly or view it on GitHub
https://github.com/DoSomething/dosomething/issues/4517#issuecomment-109410232
.

--
Namita (Nami) Mody
Junior Product Manager
@dosomething http://twitter.com/dosomething @imanami13
https://twitter.com/imanami13
(212) 254-2390 x255

No prob!


Handle batch requests

With jussi (api.steemit.com) it's possible to send batch requests. LightRPC should allow this aswell. It would be easier for replay blockchain or could be used in Busy to reduce the number of requests. Instead of sending one operation per request, we can send one array of multiple operation per request.

Possible implementation.

Change send to accept a request object with keys message and params.
Add sendBatch to accept an array of objects (with the same structure as in 1.)
send is just wrapper for sendBatch. We wrap request in the array and call sendBatch.

It has been implemented at 1.0.0-beta.2.


Next.js ssr with Swiper-reat warning issue.

First of all, thank you for making this awesome library. It really helps me to save a lot of time.
I am using swiper-react(v. 6.1.1) with Next.js(v. 9.5.1) and found following warning in my terminal
Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in components that render exclusively on the client. See https://fb.me/react-uselayouteffect-ssr for common fixes.
I googled the issue and found out that this is something to do with Next.js ssr behavior and useLayoutEffect.
I changed useLayoutEffect hook to useEffect hook in swiper-slide.js in node_module like this below.
  (0, _react.useEffect)(function () {
    if (externalRef) {
      externalRef.current = slideElRef.current;
    }

    if (!slideElRef.current || !swiper) return;

    if (swiper.destroyed) {
      if (slideClasses !== 'swiper-slide') {
        setSlideClasses('swiper-slide');
      }

      return;
    }

Now the warning is gone but do not understand why this is happening.
Could this be a bug that should be fixed?

It is just a warning
Update to 6.1.2 where its is fixed


Expressions

LDPL should really support expressions. It's very cumbersome to have to use
MULTIPLY someVar BY someConstant IN temp_var
ADD initialValue TO temp_var in TEMP_var

to do initialValue + someVar * someConstant. Given that LDPL compiles to C++, adding expressions to the language should be fairly easy. I'm not saying that IF statements or WHILE statements should support them (it would be nice, though), I'm saying that there should be some statement like
IN var SOLVE EXPRESSION initialValue + someVar * someConstant

Maybe IN var SOLVE MATH initialValue + someVar * someConstant? Since EXPRESSION is kind of ambiguous in programming languages? But maybe that's just because I'm a bad math student !

That would be fine as well, yes! I think that's even clearer haha


New validation rules: less_than_min_length and greater_than_max_length

Specifications:
https://github.com/Big-Life-Lab/PHES-ODM-Validation/blob/main/validation-rules/greater_than_max_length.md
and
https://github.com/Big-Life-Lab/PHES-ODM-Validation/blob/main/validation-rules/less_than_min_length.md

Blocked by #63

See comment about inclusive min/max in #37.


[Create news]: Not enough space between hint and text field.

Environment: macOS Catalina 10.15.4, Google Chrome 81.0.4044.122 (64-bit)
Reproducible: always
Build found: commit b517ccb
Preconditions:

User is signed in
https://ita-social-projects.github.io/GreenCityClient/#/create-news is opened

Steps to reproduce:

Click on the 'Eco news' link.
Click on the 'Create news' button.

Actual result:
Not enough space between:
'Should contain maximum 170 symbols' hint and 'Title' text field.
'Only 3 tags can be added' hint and tags chips.
'Please add the link of original article/news/post. Link should contain https://' hint and 'Source (optional)'text field.

Expected result:
Space between should be as on mock-up

User story: #505

Not fixed

Not fixed
Actual result:
Space between:
'Should contain maximum 170 symbols' hint and 'Title' text field - is 2px
'Only 3 tags can be added' hint and tags chips - is 2px
'Please add the link of original article/news/post. Link should contain https://' hint and 'Source (optional)'text field - is 2px

Expected result:
Space between:
'Should contain maximum 170 symbols' hint and 'Title' text field - should be 4px
'Only 3 tags can be added' hint and tags chips - should be 4px
'Please add the link of original article/news/post. Link should contain https://' hint and 'Source (optional)'text field - should be 4px

Verified


Change IP address range for ims bearer

Hi,
I would like to ask you to confirm,
To solve IP range conflict between eNB connection network and Open5GS assigns to ims bearer. (I use external eNB) I made attached modification. change IP range for ims bearer to <IP_ADDRESS>/24
Is it enough and collect  ?
After this modification and re-build, everything works fine. UE can attach. can access to internet. can make VoLTE call between two.
diff_changeIpRangeForIms.txt
.

Hi @yasuhirom
IP addresses are assigned to APN internet and ims for each device connected to the core network, so it depends on whether /24 meets your requirements.
In my case, it was enough to try VoLTE and SMS.

Hi @s5uishida
Thank you for your confirmation.
Sorry "enough" means my modification is covered all necessary change IP address range or need more modification.
Change <IP_ADDRESS>/24 to <IP_ADDRESS>/24 may more clear.
Yes, how many UE can be handled is , /24 is enough for my case.

Hi @yasuhirom
I'm sorry I misunderstood.
BTW, if you want to try VoLTE easily, I recommend the open5gs_hss_cx branch without FHoSS.
If you want to try SMS over IMS in addition to VoLTE using IMS (Kamailio), you need to use  the master branch.
You may try SMS over SGs on either branch.
FYI.

For ue subnet change, you need to modify upf.yaml and smf.yaml and also in upf_init.sh file with the subnet you wnat

@herlesupreeth
pcscf_init.sh and rtpengine_init.sh as below. Is it unnecessary to modify ?
# Add static route to route traffic back to UE as there is not NATing
ip r add <IP_ADDRESS>/24 via ${UPF_IP}

hi, @s5uishida
Thank you for your info.
Regarding SMS, I already got working by over SGx interface on non docker environment Open5GS w/o Kamailio.

Yes, you need to modify there as well

@herlesupreeth
thank you for your confirmation.


Improve build times

Build times have gotten longer with  panda: From an average of 6 mins to 1 hour.
(They don't really take 1 hour because travis runs many jobs at a time)
Would there be a clever way to speed them up? I would not want to reduce testing just for the sake of faster builds tho.

@ReAzem you should try using a pip wheels to speed up the build:
https://packaging.python.org/en/latest/installing.html#installing-cached-wheels

I think we can try using the caching option in travis by modifiying .travis.yml.
cache:
  directories:
    - $HOME/.cache/pip
before_cache:
  - rm -f $HOME/.cache/pip/log/debug.log

Any thoughts? Waiting for more than an hour to see if one's build is successful is really frustrating.

That will avoid recompiling with pandas?
I'll push it on another branch to try.

Yes, it's supposed to cache the wheels and all consecutive builds should be significantly faster.

I have switched to the container architecture and the buiilds are now blazing fast!

=D

I had to do a very dirty hack...
See .travis.yml
    wget https://s3.amazonaws.com/influxdb/influxdb_0.9.2_amd64.deb
    dpkg -x influxdb_*_amd64.deb influxdb_install
    export INFLUXDB_PYTHON_INFLUXD_PATH=$(pwd)/influxdb_install/opt/influxdb/versions/0.9.2/influxd


Update keynote page

Update keynote HT's title and abstract

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   77.17%   77.17%
=======================================
  Files          69       69
  Lines        2427     2427
=======================================
  Hits         1873     1873
  Misses        554      554

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c877ebc...3242cf1. Read the comment docs.

Deploy 了


Add APIs to get profile of compile time

Add serial time measurement
Add profiler to measure lots of stages in slang compilation, and it can accumulate the time spent in each thread in multi-threads case and finally report a serial timing info.

So the supposed use right now is to call isClear=true before each compile, and then call again after the compile and accumulate the values in user space?

It's actually called after each compile, e.g.
spCompile();
bool isClear = true;
spGetCompileProfile(..., isClear);

in this case, the profiling data for this compile job will be returned to user, and slang will clear it.

The use of strncpy caused a warning in visual studio. I believe you can just use strncpy_s, and we should have this defined for linux in slang-secure-crt.h.

strncpy_s

The use of strncpy caused a warning in visual studio. I believe you can just use strncpy_s, and we should have this defined for linux in slang-secure-crt.h.

The use of strncpy caused a warning in visual studio. I believe you can just use strncpy_s, and we should have this defined for linux in slang-secure-crt.h.

Yeah, updated.


Amy test

There were no changes between this branch and UI, so I'll close this pull request. Can reopen if more gets added here.


bigdecimal crate decimal stringify problem in sqllogictest

Describe the bug
There is a change in sqllogictest float to string method after the bigdecimal crate 0.4.3 version. There are affected PRs like https://github.com/apache/arrow-datafusion/pull/9460. It will cause an error on every PR status check from now.
To Reproduce
Just run a workflow on CI or local after cargo update.
Expected behavior
No response
Additional context
We should change the cargo.toml as bigdecimal = "=0.4.1" or bigdecimal = "=0.4.2" until it gets a fix.

It was okay on my local, lets check CI.
I was experimenting with RUST_BIGDECIMAL_EXPONENTIAL_FORMAT_THRESHOLD but that doesnt seem to wok properly

I saw it in our fork, and changing the version was the solution. If this is not the case here, I will check my fork again.

maybe you should run cargo update then try it.


Support protovalidate examples

Because this PR was merged https://github.com/bufbuild/protovalidate/pull/239, once a new release happens for protovalidate, I can use these examples in this plugin to populate the examples field in OpenAPI

This is now done and released as part of v0.11.0


Added alignment of headers according to spec

Added headers to kscb, tests, etc

@yogilad I refactored it to remove the logic out of KSCB, take another look.


Stabilizing manifest generation to create text diffable output

This PR stabilizes the output order of the mesh generate family of commands, which will cause them to produce text diffable output (e.g. you can now run mesh generate > test.yaml, mesh generate > test2.yaml, and then diff test.yaml test2.yaml and get a zero diff).
This fix is to close https://github.com/istio/istio/issues/15273, which I believe was created before the operator was forked into its own repository.

Hi @stewartbutler. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot I signed it!

/ok-to-test

@stewartbutler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

operator-lint
667114df6ca736ef2edb072a4ece3405dfdd7057
link
/test operator-lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


pivot_table function implementation

Current state:
All functionality of pivot_table were implemented in #1669 (ready for review). Implementation uses unstack function, which is not merged in master yet (#1649, unstack requires design documentation), so for now it uses default_to_pandas version of unstack.
More details about the current state could be found in this comment.

Current state:
Tested pivot_table with draft unstack implementation from #1649 here is the results:
150000 rows, 256 cols, 256 cols used as values:
pd: 5.6312
md: 4.6227


Notebook: Option to dock the variable window on the righthand side

In Python notebooks the window with the variables from the kernel is positioned above the notebook. It would be nice to have the option to dock the window on the right side.
VS Version: 1.46.0
OS: Windows_NT x64 10.0.18363

Please file issues against the Python extension, which currently provides Jupyter support.


Cannot build iOS app - 'openSettingsURLString' has been renamed to 'UIApplicationOpenSettingsURLString'

I cannot build an iOS app with this plugin. I get the following errors:
                                                   ^
/Users/xxx/MyProject/platforms/ios/MyProject/Plugins/cordova-plugin-qrscanner/QRScanner.swift:471:63: error: 'openSettingsURLString' has been renamed to 'UIApplicationOpenSettingsURLString'
            guard let settingsUrl = URL(string: UIApplication.openSettingsURLString) else {
                                                              ^~~~~~~~~~~~~~~~~~~~~
                                                              UIApplicationOpenSettingsURLString
UIKit.UIApplication:70:22: note: 'openSettingsURLString' was introduced in Swift 4.2
    public class let openSettingsURLString: String
                     ^
/Users/xxx/MyProject/platforms/ios/MyProject/Plugins/cordova-plugin-qrscanner/QRScanner.swift:484:74: error: 'openSettingsURLString' has been renamed to 'UIApplicationOpenSettingsURLString'
                UIApplication.shared.openURL(NSURL(string: UIApplication.openSettingsURLString)! as URL)
                                                                         ^~~~~~~~~~~~~~~~~~~~~
                                                                         UIApplicationOpenSettingsURLString
UIKit.UIApplication:70:22: note: 'openSettingsURLString' was introduced in Swift 4.2
    public class let openSettingsURLString: String
                     ^

** BUILD FAILED **

The following build commands failed:
        CompileSwift normal x86_64 /Users/xxx/MyProject/platforms/ios/MyProject/Plugins/cordova-plugin-qrscanner/QRScanner.swift
        CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)
Command finished with error code 65: xcodebuild -workspace,MyProject.xcworkspace,-scheme, MyProject,-configuration,Debug,-sdk,iphonesimulator,-destination,platform=iOS Simulator,name=iPhone 11 Pro Max,build,CONFIGURATION_BUILD_DIR=/Users/xxx/MyProject/platforms/ios/build/emulator,SHARED_PRECOMPS_DIR=/Users/xxx/MyProject/platforms/ios/build/sharedpch,EMBEDDED_CONTENT_CONTAINS_SWIFT = YES,ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO,LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks"
xcodebuild: Command failed with exit code 65
Error: xcodebuild: Command failed with exit code 65
    at ChildProcess.whenDone (/Users/xxx/MyProject/node_modules/cordova-common/src/superspawn.js:135:23)
    at ChildProcess.emit (events.js:321:20)
    at maybeClose (internal/child_process.js:1026:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
[ERROR] An error occurred while running subprocess cordova.

Same question

Yes, it's an known issue. Change UIApplication.openSettingsURLString to UIApplicationOpenSettingsURLString

find . -type f -name "*.swift" -print0 | xargs -0 sed -i '' -e 's/UIApplication.openSettingsURLString/UIApplicationOpenSettingsURLString/g'

Are you planning on fixing this in a new release anytime soon? Making the above change isn't going to help when I do a CI build of the app.

Yes, there is several pull requests to fix it like https://github.com/bitpay/cordova-plugin-qrscanner/pull/251/commits/106abbdf2923f3a65d2ea4a85ab8725077ad6886

I have given up on waiting for this to be fixed. I have created a substitute for the npm package using @markterrill code. If you want to try it run:
npm uninstall cordova-plugin-qrscanner
npm install<EMAIL_ADDRESS>
Hope it works for you...

Cheers @danielzen !
I'll use your fork / npm, thanks for setting that up.
Mark

Now that I have updated to Swift 5, I understand why @markterrill's code was not accepted. Perhaps it is better to set swift5 in Cordova or Capacitor (as I did)?
In cordova use: https://www.npmjs.com/package/cordova-plugin-add-swift-support
In capacitor set cordovaSwiftVersion: https://capacitor.ionicframework.com/docs/basics/configuring-your-app/
I'm leaving my Swift 3 version at https://github.com/danielzen/cordova-plugin-qrscanner in the meantime, but I no longer recommend it. Hope this helps.

srsly it has been almost a year now !

Is this closed because it is fixed?

I recommend looking at:

https://www.npmjs.com/package/cordova-plugin-qrscanner-11

based on

https://github.com/v1934/cordova-plugin-qrscanner-11

It has updates that are working for me....

Is this closed because it is fixed?

@terryjiang2020 - closed because there is nothing to fix - it is not a bug - your Cordova iOS settings need to use Swift 5 (not 3) and the plugin will work fine.
See @danielzen 's comment above on May 18, 2020, and my comment on this similar issue for more help/details:
https://github.com/bitpay/cordova-plugin-qrscanner/pull/272#issuecomment-887081111


⚠ ClamAV has degraded performance

In 4d4ba49, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: ClamAV performance has improved in bbc9728.


add design documents to packages page

For now, I think it would be good to embed or link to our design documents on the website. I would like to get input from the broader community on them.
What is the best way to do this? The hackpads actually have very little flexibility in terms of permissions.
One option would be to translate them to markdown, put them into a repo (maybe the website repo itself, maybe the individual project repos, idk) and seek input as github issues or pull requests.
How should we handle this?

Here is a suggestion: make a markdown file for each package and publish the content on the website (maybe through different pages) so that it would visible for potential contributors. We could add a link saying something like: "If you want to contribute to this package, please contact email of the person in charge of the package to have more details on the ongoing development and fork the code  here (github repo)"

To be clear, are the people in charge of the design documents of the different packages during supposed to keep managing them ? I'm ok to be in charge of the signal processing package.

@rabernat did this a while back.


[WIP] tooling: Add jsonschema dump of API (...cont)

continuation of closed PR #13254
very WIP!
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

After rebasing to the latest main branch HEAD and making a slight modification to this PR branch to catch up with related changes such as #16618, #16496 and #18091, I have successfully generate a JSON schema for the Envoy configuration file based on the latest release version of Envoy (except for CryptoMbPrivateKeyMethodConfig extension).
I am exploring to see if there is any other things that is blocking this improvement PR.

@mmizutani its a while since i worked on this, unfortunately other priorities took precedence
im trying to rem exactly what issues i hit - iirc generating the basic schema was not so problematic, but there were a few additinal hurdles to making it work with vscode
i would be happy to review and/or help with this effort so feel free to ping me if you raise a PR

Clearing myself from assignee until we have a PR ready for review, thanks.


[SCB-595]Compatible with old SC

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.05%) to 87.554% when pulling e68185c564ef8faa345ce44dd70132a7bdc4b27a on laijianbin:patch-2 into 2ef4245235786ef94f750e0993675a1e40e6e55f on apache:master.


0xFD+ bytes aren't shown properly.

how did i not see this

Yep it was because I converted int to byte.

It's sad because I have to use 32-bit integers instead of bytes which increases the memory usage :(

Fixed.
Note: Use fs.Read(byte[], int, int) way more often.


Amazing Project !! I seem to have some issues running it ...

What I did -

cloned repo
changed repo name
changed name in package.json, mnifest.json & index.html
changed .env
tired deploying it on vercel

There were many warns in build logs.
The deployment seems empty. https://animezia.vercel.app/

Hi, I don't know if the name changing step is causing the problem or not, but you can try adding the environment variables of the project on Vercel:
Go to your project -> Settings -> Environment Variables and add these value

Ah thanks, fixed it.
Btw, I tried using anilist api in normal js. Would like to discuss and learn about it more, can we talk on some social media? discord, fb, ig?


Extract hsi to tif

Fixes flake8-lint and docs issues in the extract_hsi_to_tif script.

@Nageshbansal should I close this, since now the tests pass and the flake8-lint are already fixed?

Yes, I'm closing this PR now. Thanks for letting me know :)