[Bug] guc not valid unexpectedly, exposed on lightning external fts build

Cloudberry Database version
PostgreSQL 14.4 (Cloudberry Database 1.5.5+dev.61.g3ccb452c build 78117 commit:3ccb452c) (HashData Lightning 1.5.5+dev.61.g3ccb452c build 78117 commit:3ccb452c) on x86_64-pc-linux-gnu, compiled by gcc (GCC) 10.2.1 20210130 (Red Hat 10.2.1-11),
64-bit compiled on Jun 26 2024 04:10:34
What happened
gpconfig -c gp_fts_probe_interval -v 10 --masteronly
20240626:18:09:21:027381 gpconfig:xuebin-centos7-x86-external-fts:gpadmin-[CRITICAL]:-not a valid GUC: gp_fts_probe_interval
not a valid GUC: gp_fts_probe_interval
ICW Test case fts_segment_reset failed.  gpconfig exited with code 1 instead of expected code 0.
 -- Let FTS detect/declare failure sooner
 !\retcode gpconfig -c gp_fts_probe_interval -v 10 --masteronly;
-(exited with code 0)
+GP_IGNORE:-- start_ignore
+GP_IGNORE:20240626:17:58:21:022511 gpconfig:xuebin-centos7-x86-external-fts:gpadmin-[CRITICAL]:-not a valid GUC: gp_fts_probe_interval
+GP_IGNORE:not a valid GUC: gp_fts_probe_interval
+GP_IGNORE:
+GP_IGNORE:-- end_ignore
+(exited with code 1)

What you think should happen instead
No response
How to reproduce
logon to <IP_ADDRESS>
gpstart
su - gpadmin
gpconfig -c gp_fts_probe_interval -v 10 --masteronly
Operating System
centos7 x86
Anything else
on external fts build
Are you willing to submit PR?

[x] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

As we discussed,  I would change test case to ignore the output of  "gpconfig -c gp_fts_probe_interval -v 10 --masteronly".

closing this,  as JIaqi 's new change fixed this problem
"re-enable the external FTS ICW (https://github.com/cloudberrydb/cloudberrydb/pull/483)"
test fts_session_reset            ... ok       112982 ms (diff   53 ms)


Resolve doesn't work with components and nested view

This is a:

[x] Bug Report

My version of UI-Router is: (1.0.0-rc.1)
Bug Report
Current Behavior:
When using nested views with angular components - there is no ability to define resolve section independently per each view. When I do so - component isn't rendering at all
Expected Behavior:
Each nested view should have independent resolve section
Link to Plunker that reproduces the issue:
https://plnkr.co/edit/pfW3cPjxJsBipSqxmgEx

It was an undocumented feature in 0.3.x and now it's removed. More info here #2717.
I have my own workaround for this case. If you want, I can publish it as a package.

@kopach Anber is correct, this was never officially supported because resolves cannot be scoped to a view.
In 0.x you could declare them at a view level, but it was the same behavior as declaring them at the state level.  In addition, if you declared two resolves with the same name in two different views, the results were undefined.
In this example, the resolved value for foo is non-deterministic.  For this reason we no longer support the behavior of 0.x.
.state('foo', {
views: {
  view1: {
    resolve: { foo: function() { return "ABC"; } }
  },
  view2: {
    resolve: { foo: function() { return "DEF"; } }
  }
});

@Anber Could u publish your workaround?


Enable all iGEMM solvers by default

This PR ~remove a~ disables workaround, so MIOpen would enable all iGEMM solvers by default.
Also resolves issue #483

Let's discuss this on meeting today.

@daniellowell test_conv_for_implicit_gemm failed. But there is no log on which case failed. Restarted the CI job

@asroy @daniellowell Do we still need this (i.e. what is the value of it)?

blocked by #540 which include a bug fix, otherwise CI would not pass

@atamazov All iGEMM solvers (HIP/asm) will be used if MIOPEN_FIND_MODE=1.
This PR is blocked by #540 which has a bug fix for asm-iGEMM kernel, otherwise this PR will not pass CI

@asroy

All iGEMM solvers (HIP/asm) will be used if MIOPEN_FIND_MODE=1.

Of course. The question is how do we estimate the overall value of this change. One may think this is not good (the value is negative), because Find() will take longer. Another one may consider this is of small value.

@asroy This PR needs more work. It consistently fails on FP32 gfx908 tests.
http://micimaster.amd.com/blue/organizations/jenkins/MLLibs%2FMIOpen/detail/enable_all_igemm_solver/18/pipeline
Please open additional tickets for bug fixes.

Converted to draft to avoid spoiling docker image cache on CI. You can continue work as usual. But please change this back to "normal" PR only after ending of CI moratorium (see mail). Then first merge from develop. Push the [Ready for review] button only after that. Thanks.

No longer pursuit

No longer pursuit

Why? Since #615 (2 days ago) we have parallel builds of all solutions, so the library can tolerate this.


Download MESSIDOR and segmentations

Nice project. The link of  vessel segmentation is missing. Can you check it ? Thanks

Hi @wuhanhui! The link is working perfectly (even in my cell phone, in which I'm not logged in on Box). If you are using wget or right clic and save as it won't work. You just have to clic on the link, which will bring you to the Box folder, and there you will find all the vessel segmentation. Take into account that all of them are downsampled to approximately the same resolution on DRIVE.
By the way, as we didn't submit our paper yet, of you use this data on your research please cite our TBME and MICCAI papers on vessel segmentation. You will find the corresponding citations on one of my repos here. Once we get our PMB paper accepted we will let you know.
Good luck, and let me know if you can't make the link work yet!

Thanks for you help. I have try to download that with a proxy and it works now. Maybe this website is blocked in my country.


DOC: avoid a few sphinx warnings

This PR fixes 3 sphinx warnings by:
1.) removing overview.rst which is not used
2.) adding exclude_patterns = ['substitutions.rst', ] to avoid warnings about it not being in a toctree
3.) using correct relative path to favicon.ico to suppress a warning about it not being found
The exclude_patterns parameter was added to conf.py back in Sphinx 1.0, so I think that should be fine to use at this point.
As there is now only one remaining document (wavelet packets) linking to substitutions.rst we could alternatively just move the substitution to that file instead.
The only remaining warning I see is the following, which I think is fine (it is just a Travis badge):
/Users/lee8rx/src/my_git/pyir/pywt/doc/source/dev/testing.rst:None: WARNING: nonlocal image URI found: https://secure.travis-ci.org/PyWavelets/pywt.png?branch=master

Current coverage is 86.68% (diff: 100%)

Merging #237 into master will not change coverage

@@             master       #237   diff @@
==========================================
  Files            20         20
  Lines          2900       2900
  Methods           0          0
  Messages          0          0
  Branches        277        277
==========================================
  Hits           2514       2514
- Misses          335        336     +1
+ Partials         51         50     -1

Powered by Codecov. Last update d198414...96029c8

Thanks, LGTM.


Feedback yifang

This research is clearly motivated, emphasizing the importance of forecasting lending amounts to financial institutions. The variables are chosen with clear rationale. In data section, the author explained how each of the regressors can affect the forecasting targets, which laid a strong theoretical foundation for future analysis and interpretation of the coefficients and results. By individually forecasting lending amounts for housing sector and business sector, it benefits financial institutions who have an target clients in specific sectors, which leads back to the motivation of this paper.
While I think the one thing can be done better is cleaning the data to suit your purpose. I see all variables are still in different frequencies, this won't make sense if they are just put into the model. Also, the PACF is quite meaningless for choosing the ideal lags. Also in the time series plot they seem to cover different time periods. Some statement needs to be made about what period that you want to cover and is there a reason for that(e.g no significant regime change). A short to-do list for this:

choose a time period to estimate(could be base on some literature).
choose an ideal frequency of data (monthly/quarterly etc.) based on data available.
transform all data into same frequency, could be by averaging.
Comment on the ACF/PACF results.

Also, I read both cited articles' data section, one of them uses lending rates and the other just interest rate. I think lending rates in the past might be a more relevant option than cash rate target as those are rates faced by borrowers other than banks.  The RBA has data on a range of lending rates for housing and business sector, they may be useful in this context.
For the index file:

I change the Abstract section a bit so that it would be an abstract for the paper  ec11479a95ef4fb55cad62f95a2fa8dff3197817

I write some sample codes that can use one function to retrieve data without obtaining the xlsx file first, which is readrba recommended by Tomasz. It returns a table called tibble, which is part of the tidyverse packages. Two other function there is for choosing the desirable time period and turn monthly data into quarterly very easily. 0bf67c2c15bdaecab6bab8ffa65e5c1b1d0f0016

I changed some expressions in your model specification.

I changed the distribution of error term from iid to iid normal, only then the compact error is multivariate normal. 53c9173ddfeee9b72cc09f020efde62d699bb6c0
I changed small n to capital N for consistent notation cc71734ccd66698dd19f274811d6ec7ba3e8f573
I change some matrices expression as there are some mistakes c0807a1b6c87e37aacf264425e7d57206bc2e942
Great work in general, I'm looking forward to see the rest of the progress and your report!
Yifang

Perfect! Hey, @lzyzero3 please remember to include @YifangUnimelb  feedback re the variables. But you have to do that for the presentation and RP3. Take your time!


Additions to NBTUtils

Methods:

getTag
clearTags
containsTag
getAllTags

Thank you for opening this issue, @ItzGuy.
I appreciate your interest in improving NBTUtils. The methods you mentioned, such as getTag, clearTags, containsTag, and getAllTags, sound like valuable additions to the library.
I'm glad to inform you that I will be implementing these methods in the next release of NBTUtils. They will provide convenient functionality for retrieving tags, clearing tags, checking for tag existence, and retrieving all tags.
Your contribution is greatly appreciated, and I look forward to delivering these enhancements in the upcoming release. If you have any further suggestions or feedback, please don't hesitate to let me know.
Thank you again for your valuable input.


Module with changes in different projects

For example, I made a module "team" in which default fields are name, email, phone. I have it in git as a private repository and use it in the some projects.
But what if in a certain project in this module it is necessary to add a photo? If I do changes directly in the module code I need to commit it and use this unwanted functionality in other projects (if I do git pull on it).
Just don't do commit? Git branch? How can there be logic? Any ideas?

That's up to you. It basically depends if you value keeping the ability to update the module or not.
If you do, then you can fork your module and make the changes while keeping the ability to update.
If not it's more easily, remove your module from composer, and customise on a per project basis.
I usually go for the second option. It's all about the trade offs.


If the cluster is single-stack IPv6, bind to :: rather than <IP_ADDRESS>.

This updates our kube-apiserver config to specify a bind address of :: rather than <IP_ADDRESS> when running in a single-stack IPv6 cluster. Combined with https://github.com/kubernetes/kubernetes/pull/84727 this will then cause it to advertise an IPv6 address for kubernetes.default.
Originally I modified both bindata/bootkube/config/bootstrap-config-overrides.yaml and bindata/bootkube/config/config-overrides.yaml, but the changes to the latter had no effect; I'm guessing that the "real" (post-bootstrap) config is rendered without access to the cluster manifets and so doesn't pass --cluster-config-file, so the whole if len(renderConfig.ClusterCIDR) > 0 section just gets skipped. So instead I added the code to the config observer.
There is, at the moment, no simple way to test this, but this is going to be one of the PRs that needs to merge before we can even have an e2e-aws-ipv6... (see https://github.com/openshift/enhancements/pull/87, https://github.com/openshift/installer/pull/2555)

/retest

/retest

/retest

/retest

Can't and shouldn't we just always listen on ::?

Some nits. Looks good otherwise.

/assign @squeed

:+1: lgtm

Can't and shouldn't we just always listen on ::?

If someone disables IPv6 in the kernel then there won't be a ::. (Though maybe that would cause other problems anyway?)
kubernetes/kubernetes#84727 makes apiserver treat --bind-address :: as additionally meaning "advertise an IPv6 address in kubernetes.default.svc by default" so we'd have to change that.

Can't and shouldn't we just always listen on ::?

OK, so it turns out that golang will actually give you a dual-stack socket if you say net.Listen("tcp", "<IP_ADDRESS>:6443"), but since we were passing "tcp4" rather than "tcp" we got single-stack. So if we changed BindNetwork, we could get dual-stack behavior.
However, this is going to need to go into 4.3, and making hostNetwork servers in single-stack IPv4 clusters suddenly be dual-stack is scary as a last-minute (or z-stream) change. So I think for now we want to stick with this approach, but probably later in 4.4 we'll want to switch to BindNetwork: tcp. (For pod-network servers though, we can do the dual stack thing.)

/retest
@soltysh updated for your comments

/retest

/retest

Per slack discussion yesterday, I understand that this is something we want to do for 4.3 (single-stack), but we don't want to do for 4.4 (dual-stack). But because of our "process", we have to merge this into master and then do a backport of this into 4.3.z, correct?
I'm not sure how this will work if somebody take 4.3.0 and install it on IPv6 cluster (which I suppose won't work) and then upgrade to whatever z-stream level has this fix. Upgrade does not seems to magically make his cluster work on IPv6 as this is only dealing with the z-stream.
Should this be a hard 4.3.0 blocker? /cc @smarterclayton @eparis

I'm not sure how this will work if somebody take 4.3.0 and install it on IPv6 cluster (which I suppose won't work)

The 4.3.0 installer won't allow you to specify an IPv6 machineCIDR / clusterNetwork / serviceNetwork.

@danwinship so one need to install 4.3.0 on ipv4, then get the right z-stream and switch to ipv6?

No, if you need IPv6, you have to wait for the 4.3.z release that supports IPv6, and then install that directly. You'd never run 4.3.0 on that cluster.

We are not worrying about supporting 4.3.0-with-IPv4 to 4.3.z-with-IPv6 upgrades

@danwinship gotcha

/approve

/cherrypick release-4.3


Update project submission template with requirements

We've had a nice wave of submissions lately, but a few of them have come without a Code of Conduct.  Nobody has balked at adding one, but maybe we could gently remind people in the template and expedite admission.
Another requirement for projects is the an open license.  That hasn't been an issue, but could fit in the same section.

https://github.com/typelevel/governance/pull/93


InHouse Error Page Introuduced

PR Fixes:

1.This PR fixes the Text , buttons visibility in 404 page not found page.
2 .This PR also introduced INHOUSE Error page with clean UI and also a button to go back to home page ("/") route.

Resolves #552
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue
I have provided the  Screen recording of that 404 page  before updating by visiting app.100xdevs.com page and after Updating in my local system.
Screen Recording Click Here

I think you should exclude tsconfig.json from the commit because it's just adding commas.


Add support for TF Hub text-embedding models

This PR addresses issue #40. It provides (an initial) support for text-embedding models in TensorFlow Hub (or any other compatible model which could be loaded using hub.load()). Note that this only supports models which can operate/be called directly on raw text/sentence string; therefore, for the time being, it does not support models like BERT (example) which need additional pre-processing steps.

Thanks for submitting a pull request 🚀 @erohmensing will take a look at it as soon as possible ✨

@koaning for you 🙂

Could you merge the changes from master into this? I just want to make sure this also works on the new tensorflow versions.

@koaning Don't worry since I added the last commit after you merged the new dependency upgrade PR. So the current checks have used TF 2.3.

@koaning The failing test is the flaky test which I have mentioned earlier. Please re-run the checks. I will fix that test in another PR.

LGTM. Thanks!


Updating the Sample

Hi,
The sample seems to be outdated, referring to DirectX11 and some of your libraries that are now archived like MyMath.
Any chance of getting it updated? Or is there any other working sample that I might have missed?
Thank you

As you can see this project is a work in progress and I haven't spent any time on it recently. It was originally built on DX-11, and then was moved to Vulkan. The DX-11 code remains in the feature/dx11-port branch, but no guarantees. I am unlikely to spend any time on it in the near future.

Cool, I'll just read the code then.


Notify message repeated

When flashing notify messages to the session, the message are showed duplicated

any updates on this G?

I have not had chance to looke into it yet. PR are welcome.


Support LambdaType and MatchType for Scala3

Issue: https://github.com/scalameta/scalameta/issues/2403
Here's a prototype implementation of Extracting Signature information for MatchType and TypeLambda from Scala3

https://github.com/tanishiking/dotty/pull/1
https://github.com/tanishiking/semanticdb-for-scala3/pull/1/files

LambdaType
message LambdaType {
  Scope parameters = 1;
  Type return_type = 2;
}

LambdaType represents the LambdaTypes for Scala3
http://dotty.epfl.ch/docs/reference/new-types/type-lambdas.html
for example type Union = [A, B] =>> [C] =>> A | B | C
LambdaType(
  parameters = Some(
    value = Scope(symlinks =
      List(
        "....Union#[A]"
        "....Union#[B]"
      ), hardlinks = List()
    )
  ),
  returnType = LambdaType(
    parameters = Some(
      value = Scope(symlinks = List("....Union#[C]"), hardlinks = List())
    ),
    returnType = UnionType(
      types = List(
        TypeRef(
          prefix = Empty,
          symbol = "....Union#[A]",
          typeArguments = List()
        ),
        TypeRef(
          prefix = Empty,
          symbol = "....Union#[B]",
          typeArguments = List()
        ),
        TypeRef(
          prefix = Empty,
          symbol = "....Union#[C]",
          typeArguments = List()
        )
      )
    )
  )
)

As you can see, for the TypeLambda who has multiple type params like [X] =>> [Y] =>> X | Y, we will have nested LambdaType.
The type parameters are represented as Scope and they should be symlinked.

MatchType
message MatchType {
  message CaseType {
    Type key = 1;
    Type body = 2;
  }
  Type scrutinee = 1;
  repeated CaseType cases = 2;
}

MatchType represents the MatchType in Scala3
http://dotty.epfl.ch/docs/reference/new-types/match-types.html
Each case are represented as CaseType and they have key and value
types.
For example
type Elem[X] <: Any = X match
  case String => Char
  case Array[t] => t

The type signature of Elem looks like
TypeSignature(
  Some(Scope(List(matchtype/MatchType$package.Elem#[X]),List())),
  MatchType(
    TypeRef(Empty,matchtype/MatchType$package.Elem#[X],List()),
    List(
      CaseType(
        TypeRef(Empty,scala/Predef.String#,List()),
        TypeRef(Empty,scala/Char#,List())
      ),
      CaseType(
        TypeRef(Empty,scala/Array#,List(TypeRef(Empty,local0,List()))),
        TypeRef(Empty,local0,List())
      )
    )
  ),
  TypeRef(Empty,scala/Any#,List())
)

where local0 means the local symbol for t in Array[t].

Based on the discussions in https://github.com/scalameta/scalameta/issues/2403, I refined the schema.
And opened a PR because I think this PR could be a good place to discuss how should we model the schema for those new types.
Besides, it might be better to finish up the prototype https://github.com/tanishiking/dotty/pull/1 before merging this PR, to confirm those models are a good fit with the actual Scala3 types.
What do you think about this? @tgodzik @olafurpg @bishabosha

I finally came back to this
TODOs:

Finishing up the prototypical implementation in Dotty repo

Ask for review and discuss the schema

If it's approved, then merge this PR

Closing for now, as I'm working supporting LambdaType and MatchType in separate PRs :)


dont show fiat for token invoice if cource not enabled

Checklist

[ ] I have read the CONTRIBUTING guide
[ ] Good naming (as clear and simple as possible)
[ ] Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
[ ] I tested desktop/mobile resolution
[ ] I tested light/dark theme
[ ] I tested different languages
[ ] I checked the functionality once again (AFFECT MONEY)
[ ] I checked the work on the Testnet
[ ] I checked the work on the Mainnet
[ ] I checked the work in the plugin
[ ] I checked the PR once again

Tests
Please start auto tests as follows:

add a label swap test to start swap tests
add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional
Original issue

https://github.com/swaponline/MultiCurrencyWallet/issues/5090
Video / screenshot proof

Надо будет проверить тесты для токенов. Может где рпс поменять или задержку увеличить.


camel-kamelets-utils - Reduce dependencies in use

The reuse of kamelets are more limited due to kamelets-utils are bringing in a number of depedencies that are for a specific Camel version.
We should try to reduce the number of dependencies if we can, and try to use only generic camel apis that does not change as much. This allows kamelets to be used across multiple Camel versions.
For example camel-kafka we only use some constant names for headers. Instead of we just use the String value instead and remove camel-kafka.
https://github.com/apache/camel-kamelets/blob/main/library/camel-kamelets-utils/pom.xml

Some of the util code could maybe also be moved to camel core project / components

There is this draft which is somewhat related https://github.com/apache/camel/pull/8694

The utils have been moved to camel-kamelets component. So this is outdated now.


How to get the world-scale depth

Hi,
Thank you for sharing the great work.
I found the depth map value is no the world-scale.
How can I get the world-scale value.

if you're using our metadata files, check the "pose_scale_factor" parameter

Hi, Thank you for your help.
I found the value of pose_scale_factor is 87.76204257199016.
If I want to get the world-scale depth value, I should multiply the value of pose_scale_factor.

that is correct


reduce CP logs verbosity

reduce ContainerPilot logs verbosity, set to ERROR by default

LGTM. env variables can be substituted with the help of envtpl, but let's do that in another PR


Problem with pbtxt file on the TF serving server

I am trying to serve the mediapipe landmark pbtxt file on the tensorserving which accept ONLY pb fomat file.
May I ask you to how I get the pb file or please guide me to get it.

Hi @Luna0214, Could you please elaborate your use case w.r.t the above query. Thanks!

What I am trying to do is, using mediapipe model serving via tensorserving for my school project.
So I clone the repos. of mediapipe and the pose_landmark_cpu.pbtxt file put on the server which is can't parse on the TF serving.
Therefore I need the pb format version of mediapipe pose_landmark_cpu to serve.
I have tried some code from some website:
`import tensorflow as tf
from tensorflow.python.saved_model import signature_constants
from tensorflow.python.saved_model import tag_constants
export_dir = './saved'
graph_pb = 'my_quant_graph.pb'
builder = tf.saved_model.builder.SavedModelBuilder(export_dir)
with tf.gfile.GFile(graph_pb, "rb") as f:
graph_def = tf.GraphDef()
graph_def.ParseFromString(f.read())
sigs = {}
with tf.Session(graph=tf.Graph()) as sess:
# name="" is important to ensure we don't get spurious prefixing
tf.import_graph_def(graph_def, name="")
g = tf.get_default_graph()
inp = g.get_tensor_by_name("real_A_and_B_images:0")
out = g.get_tensor_by_name("generator/Tanh:0")
sigs[signature_constants.DEFAULT_SERVING_SIGNATURE_DEF_KEY] = \
    tf.saved_model.signature_def_utils.predict_signature_def(
        {"in": inp}, {"out": out})

builder.add_meta_graph_and_variables(sess,
                                     [tag_constants.SERVING],
                                     signature_def_map=sigs)

builder.save()`
BUT STILL not working.
What I want is pose_landmark with pb format file.
Please help.

Mediapipe uses tflite for inference and the model format is .tflite. TF serving is for tensorflow models and the saved model format is a .pb file. So, they are two different systems and you probably can't use Mediapipe models with TF serving.


Add metadata field to LocalityLbEndpoints

Add a metadata field to the LocalityLbEndpoints proto that would be inherited by each LbEndpoint it contains. This would dramatically reduce the size of the serialized EDS resources in situations where all of the endpoints in a locality have identical metadata fields.
Motivation
It's currently possible to add metadata to an LbEndpoint proto for use in transport socket matching. This causes a significant increase in the size of each serialized protobuf.
An LbEndpoint without metadata is 28 bytes:
endpoint:{address:{socket_address:{address:"<IP_ADDRESS>"  port_value:8080}}}  health_status:HEALTHY  load_balancing_weight:{value:1}

Adding a modest 2 fields of metadata increases this size by 600% to 168 bytes:
endpoint:{address:{socket_address:{address:"<IP_ADDRESS>"  port_value:8080}}}  health_status:HEALTHY  metadata:{filter_metadata:{key:"envoy.transport_socket_match"  value:{fields:{key:"txallen_example.bar.identifier"  value:{string_value:"1234567890"}}  fields:{key:"txallen_example.foo.identifier"  value:{string_value:"1234567890"}}}}}  load_balancing_weight:{value:1}

In situations where every endpoint in a locality would share the same metadata fields, we should have the option to add metadata to the LocalityLbEndpoints that will be inherited by each  LbEndpoint contained within. This would significantly benefit control planes serving/storing 1M+ EDS resources where a bunch of endpoints are duplicating metadata.

I think this is a valid request. Would need to clarify what happens when metadata is defined for both the LocalityLbEndpoints  and the LbEndpoint (probably override semantics, unless this is defined as a locality-level metadata rather than a shared-endpoints metadata).
cc @envoyproxy/api-shepherds for visibility

I suggest we just follow the same pattern that we use everywhere else: we support metadata at both the LocalityLbEndpoint and LbEndpoint levels, and filters can use data from both places as appropriate.

Alrighty then. I'll get on it. Thanks folks!


Cancel dump imports dump

Are you sure, you want to import the dump file into local database? [Y|n]: n
By pressing "n" the dump file gets imported nevertheless.

Yap, you're absolutly right, the script was just checking the confirmation, but not considering the input.
This was fixed in 2883307ef08a8acc8ce0487d92cee3a8a66cce50 and release v2.10.2


ArchiveTimestamp error after upgrade to v1.0.9

Hi @bseddon !!!
I hope your are fine!!
Thanks for this package again!
Today, I updated from v1.0.0 to v1.0.9 and I get the following error:
[2022-03-29 09:42:51] develop.ERROR: Call to undefined method lyquidity\xmldsig\SignedDocumentResourceInfo::generateDomDocument() {"userId":4,"exception":"[object] (Error(code: 0): Call to undefined method lyquidity\\xmldsig\\SignedDocumentResourceInfo::generateDomDocument() at /var/www/test/laravel/vendor/lyquidity/xml-signer/src/XAdES.php:310)
[stacktrace]
#0 /var/www/test/laravel/vendor/lyquidity/xml-signer/src/XAdES.php(253): lyquidity\\xmldsig\\XAdES::internalTimestamp(Object(lyquidity\\xmldsig\\SignedDocumentResourceInfo), 'addArchiveTimes...', 'http://M...', NULL)
#1 /var/www/test/laravel/app/M/Certifications/XMLUtils.php(110): lyquidity\\xmldsig\\XAdES::archiveTimestamp(Object(lyquidity\\xmldsig\\SignedDocumentResourceInfo), 'http://M...')
#2 /var/www/test/laravel/app/M/Certifications/CertificationService.php(69): App\\M\\Certifications\\XMLUtils->signAndTimpestampWithXADES('/var/www/test...', 'sin')
#3 /var/www/test/laravel/app/Http/Routes/web.php(78): M\\Certifications\\CertificationService->certificateEvidence(Object(Customer), 'sin', Array, 'Email')

Did you changed the way to sign with LTA on XAdES::archiveTimestamp() method??
My code is the following:

        XAdES::signDocument(
            new InputResourceInfo(
                $path_xml, // The source document
                ResourceInfo::file, // The source is a file
                $partes_ruta['dirname'], // The location to save the signed document
                $partes_ruta['filename'], // The name of the file to save the signed document in,
                null,
                false
            ),
            new CertificateResourceInfo( $certData['cert'], ResourceInfo::string | ResourceInfo::pem ),
            new KeyResourceInfo( $certData['pkey'], ResourceInfo::string ),
            new SignatureProductionPlaceV2(
                'City',
                null, // This is V2 only
                'City',
                '28800',
                'ES'
            ),
            new SignerRoleV2(
                'CEO'
            ),
            array(
                'canonicalizationMethod' => XMLSecurityDSig::C14N,
                'addTimestamp' => $tsaURL // Include a timestamp? Can specify an alternative TSA url eg 'http://mytsa.com/'
            )
        );

        XAdES::archiveTimestamp(
            new SignedDocumentResourceInfo(
                $path_xml,
                ResourceInfo::file,
                XAdES::SignatureRootId, // optional id
                $partes_ruta['dirname'],
                $partes_ruta['filename'].".xml",
                XMLSecurityDSig::generateGUID('archive-timestamp-')
            ),
            $tsaURL
        );

Thanks Bill!

Thanks for the alert.  The cause of your issue is that since version 1.0 a function called generateDomDocument has been created from code to open an XML resource so the code can be re-used.  This function has been put into InputResourceInfo.php.  I can see now this is an error because SignedDocumentResourceInfo does not inherit from InputResourceInfo.  Instead it inherits from BaseInputResourceInfo and this is where the new function generateDomDocument should be placed.
I'll look at this issue later and verify that moving the function is the best change to make.

The code has been updated to move the function generateDomDocument into BaseInputResourceInfo  so all input classes are able to call it. My testing shows this change allows an Archive Timestamp to be created.  However, this is not a function I use so it is possible it may not work for you.  If so, let me know.
At the moment there is no new release package.  If you need one, let me know.

Thanks @bseddon , I will try soon!

Hi, new releases have been created.  The dependent repository requester has also been updated and a release created.  Composer should handle this update automatically.
Please note that since the modification to address the issue you reported, other changes have been made.  I don't think any changes will affect you adversely.  The changes are because ETSI has been running a 'plug test' event over the last 10 or so weeks in which XAdES tools can create signatures then validate others to see if validations are consistent.  As a result, it became clear the signer would not work with certificates created using an elliptic curve algorithm.
If you find further problems let me know and I'll get on as soon as possible.


Fix frontend locale and localized dates

Fixes #6862, fixes #6848 by:

Changing "lang" attribute for html document to current request locale
Fixing hard coded english localization of dates and times to that document locale
Filling META-Tag "availableLanguages" with the language codes from KNOWN_LOCALES

Thanks @kilrogg!


Week View Help

Hello, I want to know how I can change what appears in the week component's events..it shows time but I only want it to show name of the event. Please note I'm only using  and don't have full custom views.

stale


Reports are generating with inconsistent and getting mismatch for the Custom datasets.

Hello Team,
When I ran the "example.py" with your dataset, the number of records is equal to the number of results present in "results.txt",
for example, for "example_data.txt" having 19,608 records when I ran the simulation in return I'm getting 19,608 results in "result.txt"
but when I ran the same code for my dataset with have 9 channels of data that for around 1 lakh records, in return I'm getting around 6.5 lakh results in "results.txt", I'm unable to trace the inconsistency in results, can you please help me.
all the configurations are default as present in "example.py"
Thanks.

Hello there!

In what environment did you run it,,, I can’t run py2.7+cvxpy0.4.0+snap2.7 and py3.7+cvxpy+snap3.7 under Windows10.
thanks.

Hello there!

In what environment did you run it,,, I can’t run py2.7+cvxpy0.4.0+snap2.7 and py3.7+cvxpy+snap3.7 under Windows10.
thanks.


Explain mta.yaml from top to bottom

Dear CAP Team,
I really like the premise of CAP - just a couple of easy command and away you go.
The problem is that you are learning another language of yaml and these command are magically adding things and it isn't always clear what has been added.
I think a very good addition to the documentation would be to explain all the magic files (mta.yaml, ui5.yaml etc) from top to bottom to explain what each bit does.
And it would be nice if the different tools didn't clobber your mta.yaml
Trying use the fiori cli tool explained here was complaining about a misformed mta.yaml without saying what was misformed then I find that app-db was missing so I rerun cds add hana --for production and that obliterates my xsuaa section from the yaml.
😱
sincerely,
Frustrated

This is slightly instructive.
https://github.com/SAP-samples/cloud-cap-risk-management/blob/cap-mta-deployment/mta.yaml
Could the tooling add comments?

Hi @njames,
First of all, thanks for your continuous feedback!

I think a very good addition to the documentation would be to explain all the magic files (mta.yaml, ui5.yaml etc) from top to bottom to explain what each bit does.

mta.yaml and ui5.yaml are not CAP products, so we usually leave detailed explanations of their general structure to MTA build tool and UI5 documentation. I understand your intuition to add those explanations to CAPire though, as our documentation is increasingly seen as a holistic guidance covering all of your development process. We'll discuss some steps we can do in our CAPire sync.
For the cds add commands specifically, I think a code box like
cds add hana --for production

with a line-by-line explanation of changes would be a good middle ground. What do you think?

so I rerun cds add hana --for production and that obliterates my xsuaa section from the yaml

Can you please provide the prior mta.yaml? I can't reproduce the XSUAA section being removed. cds add is purely additive bar very few exceptions.
Note that some whitespace changes are not preventable, as we're merging the abstract syntax tree (AST) instead of the concrete syntax tree (CST). Popular tools like npm are doing the same approach, for example, when you modify your package.json via npm add the file might be re-indented. This shouldn't compromise the functionality of the modified file, though.

Could the tooling add comments? Perhaps if there was a comments on flag --comments

We made the decision that a clean, minimal and straightforward configuration is preferred over excessive ornamentation via comments (e.g. the # -------------------- SIDECAR MODULE -------------------------like fences in your example), therefore cds add mta just adds comments sparsely.
Best regards,
Steffen

Thanks Steffen,
I appreciate you all putting up with my "feedback" :)
I understand thought about the comments.
I think the combination of the other tools: fiori, ui5 and cds did the trick with elements disappearing from the mta.yml
I will try and reproduce that as I work on other things and if I can reliably reproduce it I will document the steps taken to get there.
Cheers,
Nigel

I have found some other good sources:

https://blogs.sap.com/2020/11/18/multi-target-application-model-mta-sap-cloud-platform-cloud-foundry/
https://www.sap.com/documents/2016/06/e2f618e4-757c-0010-82c7-eda71af511fa.html
https://sap.github.io/cloud-mta-build-tool/configuration/

and with that I will call this closed


ci(*): make the CI faster

⬇ Generated builds by Codemagic for commit f0b9545a17dec853ca22d02b327db6af17b8606b ⬇
This is a custom message.
|
|
|


fix: correct indicate condition update logic

🤔 PR includes

✨ Feature

[ ] New feature

🎨 Enhance

[ ] Code style optimization
[ ] Refactoring
[ ] Change the UI
[ ] Improve performance.
[ ] Type optimization

🐛 Bug fix

[x] fix indicate conditions updating issue

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[ ] CI / workflow
[ ] Other

📝 Description
🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

结论： 衍生指标概念已经打平，没有必要多一套去兼容，直接去除 indicateConditionValues 相关兼容逻辑，减少维护condition的复杂度


Update github workflow go test to setup go 1.14

Since unit tests break for go 1.15

/assign @zhanggbj

@navidshaikh  one quick question, there're lots of 1.5.x specified in the following files, is there any thing we need fix in this PR?
https://github.com/knative-sandbox/kn-plugin-admin/search?q=1.15

@zhanggbj : We can update them to 1.14 as well, but the respective check passes. We'll eventually move to go 1.15 and I'd keep it this way and adjust the required when its time to bump to 1.15.

/lgtm
@navidshaikh if this is the case, I agree and merging this PR.


ENH: return empty bytes (b'' ) for h5py.Empty strings

closes #94

@rabernat According to @shoyer's suggestions this should close the case.
If h5py.Empty strings are detected they are extracted as empty bytes (b'').

I've rebased on latest master and added a changelog entry. Will merge, when CI is happy.


Upgrade SpotBugs maven plugin from <IP_ADDRESS> to 4.0.4

there are still some instances of findbugs in our pom.xml. are those needed? can we remove them or replace them?

all instances of findbugs were removed in https://github.com/Alluxio/alluxio/pull/10407. Everything is SpotBugs now

oh i was looking at findbugs-annotations, is there a spotbugs replacement for the annotation package as well?

see edit above

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10769/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10772/
Test PASSed.

did ospublish run ok?

Yes, its marked in the spreadsheet

alluxio-bot, merge this please


Add ServiceArtifactBuilder [ECR-3014]

Overview
Add ServiceArtifactBuilder allowing to create at runtime
Exonum Service artifacts, including malformed to be able
to test error handling.

See: https://jira.bf.local/browse/ECR-3014
Definition of Done

[x] There are no TODOs left in the code
[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[x] Method preconditions are checked and documented in the Javadoc of the method
[x] Changelog is updated if needed (in case of notable or breaking changes)
[x] The continuous integration build passes

Coverage increased (+0.2%) to 86.089% when pulling 82d891ea65d9edce6cf48f4e49ecacfe310edeca on dmitry-timofeev:service-loader-testkit-ECR-3014 into 7706e83cfbe66c2a21350f4f506e013971b3b562 on exonum:multiple-services.

@dip56 You might find this thing useful if need to create a couple of hundreds services in QA tests (but some bash scripts with some JARing might also work).


Incompatibility with PowerMockRunner

wiremock-jre8, version 2.27.2
powermockito, version 2.0.4
Java 14
The annotation @RunWith(PowerMockRunner.class) in a test case leads to the following exception:
    javax.xml.transform.TransformerFactoryConfigurationError: Provider
    com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl could not be instantiated:
    java.lang.reflect.InvocationTargetException

at java.xml/javax.xml.transform.FactoryFinder.newInstance(FactoryFinder.java:181)
at java.xml/javax.xml.transform.FactoryFinder.find(FactoryFinder.java:257)
at java.xml/javax.xml.transform.TransformerFactory.newInstance(TransformerFactory.java:126)
at com.github.tomakehurst.wiremock.common.xml.Xml.optimizeFactoriesLoading(Xml.java:52)
at com.github.tomakehurst.wiremock.core.WireMockApp.<clinit>(WireMockApp.java:75)
at com.github.tomakehurst.wiremock.WireMockServer.<init>(WireMockServer.java:73)
at com.github.tomakehurst.wiremock.junit.WireMockRule.<init>(WireMockRule.java:43)
at com.github.tomakehurst.wiremock.junit.WireMockRule.<init>(WireMockRule.java:39)

Removing PowerMock and switching to a different runner like @RunWith(MockitoJUnitRunner.class) fixes the issue. The cause of the exception was kinda hard to track down so maybe this could be improved.
The issue is probably related to https://github.com/tomakehurst/wiremock/issues/1072

I'm going to ask the standard questions:

Have you tried the standalone JAR?
Have you looked at your project dependencies when Powermock is present to see what's different and whether it can be fixed by e.g. dependency exclusions?

Yes, I tried wiremock-jre8 and wiremock-jre8-standalone. I also tried to exclude specific dependencies but I wasn't able to fix it.
Like I said above, switching the JUnit Runner fixed it.

Apparently this issue can be solved by adding below dependencies with test scope.
<dependency>       <groupId>xalan</groupId>       <artifactId>xalan</artifactId>       <version>2.7.2</version>       <scope>test</scope>     </dependency>

I've wrapped the optimise method in a try/catch in 882b7d044fb6f113025237c9e3ad6c27fb923b49. Curious to know if this fixes the issue if you're able to re-test?

I've wrapped the optimise method in a try/catch in 882b7d0. Curious to know if this fixes the issue if you're able to re-test?

Thanks for the effort you put into that! Sadly I am no longer able to re-test it due to a change in work. I really hope someone else can confirm that in the future!

OK, I'm going to close this for now. Someone please shout if it's still an issue.


Sebastian.p/generalized rff

he purpose of this PR is to to be able to use TrajectorySamplers within Trieste (further on HV repo) that can support Heteroskedastic likelihoods (so multiple GP heads) that can have SeparateIndependent and SharedIndependent kernels & inducing variables.
Main changes:
creation of feature_decomposition_kernels folder. Idea was to structure it just like in GPflow (i.e. multioutput subfolder). Having a separate folder for this type of kernels will prove to be better suited if we are planning on including in the future some other papers such as .. [1] Solin, Arno, and Simo Särkkä. "Hilbert space methods for reduced-rank Gaussian process regression." Statistics and Computing (2020). .. [2] Borovitskiy, Viacheslav, et al. "Matérn Gaussian processes on Riemannian manifolds." In Advances in Neural Information Processing Systems (2020).
in gpflux.layers.basis_functions.fourier_features I have added the multioutput version
in gpflux.sampling I have added the multioutput version

It seems like there may be a lot of added files from personal runs of the models that we won't want in GPflux, e.g., docs/notebooks/logs, cos/notebooks/ckpts, and docs/notebooks/checkpoint. Could you verify this?

I think we also don't typically do formatting checks on notebooks, although I don't see any need to revert this

I have cleaned the PR, now ready for review!


ENH: Chroma types available as top-level imports

Description of changes
Summarize the changes made by this PR.
Closes Issue: #923
Adds the following types available as a top-level import in addition to the Collection class:

CollectionMetadata,
Documents,
EmbeddingFunction,
Embeddings,
IDs,
Include,
Metadata,
Where,
QueryResult,
GetResult,
WhereDocument,
UpdateCollectionMetadata,

Test plan
How are these changes tested?

No additional tests were added

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

It might make sense to make clear these cans can be used from the top level.

@jeffchuber You or anyone on the team got a second to give this a once over?

@mcgeestocks I will take a look later today, thanks.

Running CI...

I think we should audit our docs https://github.com/chroma-core/docs for any occurrences of these imports and change them. Would you be up to tackle that @mcgeestocks ?


chore(ci): replace vanilla kernels not asus/surface

Fixes bug in #1752 which ignored the fact that asus/surface images in Bluefin are sourced from the HWE images, thus they already have their expected kernels.
I do think this end state is a bit nicer though as it is easier to grok that this script only works on specific akmods flavors rather than the nvidia_type which didn't seem to have a clear correlation to replacing the kernel.
I apologize for the noise and confusion on this topic tonight.

This was weirdly stuck in the merge queue, even after all the merge checks were green. So I removed and manually merged.


chore(Enhancement): Add commands to package.json

Added various grunt commands to the package.json, this will allow users to run most grunt commands without having grunt-cli installed globally on their system.
All new commands are accessible via npm run.

Thanks! Out of curiosity, which tool adds .tmp.txt files?

That is what I was wondering too but I could not reproduce it unfortunately.


Support a mirror queue for testing

We are using ElasticMQ as local SQS substitute for testing, one problem we have is in a full integrate test we are testing both the producers and consuming components and asserting a message was created is racey as it is often consumed before the assertion runs.
Lots of ways to tackle this, one would be for ElasticMQ to mirror all messages received on a specific queue to a mirror queue that would only be consumed by the test/assertions themselves. Is such a thing possible / desirable? Doing it in ElasticMQ rather than the client code seems cleaner.

That's not currently supported, but adding an "audit" queue to verify that all messages have been properly handled could make much sense. It shouldn't be very hard to implement, if you'd like to try :)

Does the “delay” setting try to achieve the same goal? If I enable a delay on the queues does that give me a window to assert again the message being in the queue before it’s read?
I tried delay but it didn’t seem to do anything, messages were just read straight away.
On 9 Nov 2017, 7:44 AM +1100, Adam Warski<EMAIL_ADDRESS>wrote:

That's not currently supported, but adding an "audit" queue to verify that all messages have been properly handled could make much sense. It shouldn't be very hard to implement, if you'd like to try :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I think the original purpose of delay is different, to deliver messages after a certain period of time, but I suppose it should be possible to implement what you are after using this as well.
If I recall correctly, a global queue-delay should apply to all messages, unless they have a different delay explicitly specified. Is that not the behavior you are seeing?

I've got it configured like this
queues {
  transactions {
    delay = 10 seconds
  }
}

And with DEBUG level i'm expecting to see a Sent.. event, and no Receive.. event until 10+seconds afterwards. But i see the Receive.. immediately afterwards. I couldn't see anywhere to specify a global delay (which i would prefer), how do I do that?

Either way, as your mentioned delay doesn't achieve what i want, it would just make the messages unavailable to both the consumer and the test assertion. The mirror / audit queue is a better solution, any tips for how to PR it in? My scala is weak.

There's no way to create a global delay; and I think the way you configured the queue should work fine; maybe that's a separate bug ;)
Anyway, you are right that using the delay (even if it worked properly) wouldn't do the trick here, as the messages would be unavailable to both consumer.
I think the way to go here would be to add an auditQueue, similarly to how a deadLettersQueue is specified. This would require changes in the configuration, server, all the way up to the core actors. The Scala isn't very sophisticated, but it would be probably a couple of hours of work :)

We went another direction with this (doing assertions further downstream), so I won't have time to do the work. Still seems like a good idea though =)

Ok, I'll keep this open to implement this one day (maybe :) )

Hi guys, one concern regarding this feature for testing:
I think it would be beneficial to have not only "copy each message to another queue" ability (i.e. what is called "audit queue" here) - but also smth like "move/redirect each message to another queue" (thus removing message from original queue).
The difference here is that component handling that queued message might be able (or not able - depending on "lucky"/"unlucky" timing) to read message and process or partially process it (thus performing any arbitrary side effects/updating databases/interacting with other services/doing anything else) - which could lead to difficulties in tests (assuming in scope of the given test we want to check only "message was sent", not "message was sent and all the processing happened").
What do you guys think about it? @adamw ?

@sbinq if people would find it useful for testing, why not. I suppose that could take the form of options on a queue, copy-to = [other queue name] (audit), move-to = [other queue name]

Hi @adamw, could you please take a look at the pull request referenced above if you have some time for this?
That's my first attempt implementing functionality as discussed here - please let me know if you'd like smth to be done in different way/any concerns on this/etc. Thanks!

Hi @adamw many thanks for merged request @sbinq. I think you could close this issue.


Summary / reporting dashboard

It would be great if there was a reporting dashboard that gave a summary of what checks/services/instances failed in the past desired amount of time.  This will be useful in cases where you want to see a trend or just to get a snapshot of the events that took place.
So for example one can at the end of the day or maybe even at the end of a week (time should be user configurable) go to the dashboard and see a list of all checks that were triggered.  For a heavy Cabot user this will be a really helpful resource.
Note, I understand there is a status chart the top of each instance/service but this is severely lacking and not helpful in the way I described above.

Can you provide a bit more detail about the sort of insight you want to get and what it might look like? What in particular is "not helpful" about the current status chart? Is it a case of displaying the same data better, or getting more control over the data, or something else?

For example, suppose you had a few metrics during the day/week that triggered an alert and in response at the time you took care of the issue and moved on.  It would be nice if at the end of the day/week/whenever you do your review to be able to review the metrics that triggered to see if it needs adjustments.
Currently with the above case that is not possible with the status chart, because the status chart does not give you the list of the metrics that failed and it is only for the past 24 hours.  To gather the necessary data one would have to go through the history of each metric one by one to see what happened.  This works if you have 10 metrics your checking but not when you have 500.


430 - Phase Out Open Call for Contributions

Issue Number
Closes #430
Purpose/Implementation Notes
Based on the requirement, removed the contribute banner and display the contribute page card in the contribute page.
@dvenprasad, please review the latest UI here.
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

I don't think we need to worry about rendering this specific card on other pages by design. Also there was a layout thing with the padding at my browser width, which moving it into the page would resolve.
* Renaming `ContributePageCard` to `WarningCard` and pass in the props

Is this warning card design specific to the contribute page? Is there any plans to create warning cards at the page level with a similar style 🎨 ? If the latter is the case, then It makes sense.
For the red warning text, currently our shared WarningText component is used.

* Move the `ContributePageCard` from the layout to where the button was on the `contribute` page.

Please see the screenshot below (the first one is in the Layout component and the second one is in the contribute page component):
*I added the green text in the middle 😄

Due to the way the site structure is currently set up, the contribute page width is fixed (not full width against a browser) and for this reason, the yellow and blue band cuts off. To move this card to the contribute page component from Layout, We'll need to add a new JS condition in Layout to make this page width to be full, and then adjust this page styles (e.g., by introducing additional div to make the content width to be fixed). So it's much simpler to keep the current implementation.
Also, I made improvements to the site structure in this PR https://github.com/AlexsLemonade/scpca-portal/pull/405, which simplifies and makes the site layout more flexible (also addresses the padding condition issues for pages) and remove most of the JS conditions (we previously discussed cleaning them up). Could we review it so that it may be merged?

I wanted to add a few notes. First, Deepa and I discussed this before she went on PTO, and she said she trusted the rest of the team to make decisions to get something posted as soon as possible. That's to say, we should not wait for Deepa's review of this PR. We may need to tweak it once she returns, but that's okay.
Because we would like the changes in #430 to go out as soon as possible, can we find a strategy for getting this merged that doesn't rely on the review, approval, and merging of #405, please?

I wanted to add a few notes. First, Deepa and I discussed this before she went on PTO, and she said she trusted the rest of the team to make decisions to get something posted as soon as possible. That's to say, we should not wait for Deepa's review of this PR. We may need to tweak it once she returns, but that's okay.
Because we would like the changes in #430 to go out as soon as possible, can we find a strategy for getting this merged that doesn't rely on the review, approval, and merging of #405, please?

@jaclyn-taroni  I see. In this case, I removed Deepa as a reviewer.
@davidsmejia If the contributePage card must be in the contribute page, then I'll need to revise the page layout. Can we merge this PR as is for now and we'll make the site structure improvement (#405) after that? Please let me know.

As per our meeting today lets:

Rename ContributePageCard to WarningCard and pass in the props
Move the ContributePageCard from the layout to where the button was on the contribute page.
Add some drop shadow to the card and add some padding to the text contents

@davidsmejia Updated, please review the latest UI here, thank you.


[CI] Incorporate creation and publishing of Meshery Helm chart into stable release workflow

Current Behavior

Location of source code for Meshery’s chart: https://github.com/layer5io/meshery/tree/master/install/kubernetes/helm/meshery
Location of published Meshery chart: https://github.com/layer5io/meshery.io/tree/master/charts (used by Artifact Hub)
No workflow included in the build and release CI workflow for publishing the helm chart.

Desired Behavior

The Helm chart should be incorporated into the stable release channel.
The Helm chart should follow Meshery’s versioning.

Implementation

No workflow included in the build and release CI workflow for publishing the helm chart.

Acceptance Tests

Meshery's helm chart is updated and published with each Meshery stable version release.
Meshery's helm chart no longer has its own version number, but follows that of Meshery (server).

Future:

Users can use mesheryctl system channel to switch between release channels. // @anirudhjain75 @navendu-pottekkat

Related to https://github.com/layer5io/meshery/discussions/1792#discussion-29007

Related to https://github.com/layer5io/meshery/discussions/1792#discussion-29007

Example of where we have automated the build and release of Helm charts in Learn-Layer5 - https://github.com/layer5io/learn-layer5/blob/43e1dc9563c4232bed341cbf076c9561367ff040/.github/workflows/ci.yml#L46-L64

Example of where we have automated the build and release of Helm charts in Learn-Layer5 - https://github.com/layer5io/learn-layer5/blob/43e1dc9563c4232bed341cbf076c9561367ff040/.github/workflows/ci.yml#L46-L64

Example of where we have automated the build and release of Helm charts in Learn-Layer5 - https://github.com/layer5io/learn-layer5/blob/43e1dc9563c4232bed341cbf076c9561367ff040/.github/workflows/ci.yml#L46-L64

Looks good, sir. But I do not have permission to setup the Secret in any repo in Layer5, there may need some's help on it.

Example of where we have automated the build and release of Helm charts in Learn-Layer5 - https://github.com/layer5io/learn-layer5/blob/43e1dc9563c4232bed341cbf076c9561367ff040/.github/workflows/ci.yml#L46-L64

Looks good, sir. But I do not have permission to setup the Secret in any repo in Layer5, there may need some's help on it.

The secrets are already in place. You just need to reference them in a workflow like what is being done in this Layer5 repo.

On Jan 25, 2021, at 7:47 PM, Aisuko<EMAIL_ADDRESS>wrote:

Example of where we have automated the build and release of Helm charts in Learn-Layer5 - https://github.com/layer5io/learn-layer5/blob/43e1dc9563c4232bed341cbf076c9561367ff040/.github/workflows/ci.yml#L46-L64
Looks good, sir. But I do not have permission to setup the Secret in any repo in Layer5, there may need some's help on it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

The secrets are already in place. You just need to reference them in a workflow like what is being done in this Layer5 repo.

On Jan 25, 2021, at 7:47 PM, Aisuko<EMAIL_ADDRESS>wrote:

Example of where we have automated the build and release of Helm charts in Learn-Layer5 - https://github.com/layer5io/learn-layer5/blob/43e1dc9563c4232bed341cbf076c9561367ff040/.github/workflows/ci.yml#L46-L64
Looks good, sir. But I do not have permission to setup the Secret in any repo in Layer5, there may need some's help on it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have a consider on this
https://lippertmarkus.com/2020/08/13/chartreleaser/
When you now push a change to your master branch, the action checks each chart for a new version. For updated charts it creates a GitHub Release and adds the chart artifact *.tgz file to the release. Now the index.yaml file on the gh-pages branch is updated to add your new chart version with the link to the GitHub Releases artifact.
This CI should be work in the repo which only includes the source code of Helm charts right?

I have a consider on this
https://lippertmarkus.com/2020/08/13/chartreleaser/
When you now push a change to your master branch, the action checks each chart for a new version. For updated charts it creates a GitHub Release and adds the chart artifact *.tgz file to the release. Now the index.yaml file on the gh-pages branch is updated to add your new chart version with the link to the GitHub Releases artifact.
This CI should be work in the repo which only includes the source code of Helm charts right?

You can build from source in one repo and push build artifact to another repo.

On Jan 26, 2021, at 1:55 AM, Aisuko<EMAIL_ADDRESS>wrote:

I have a consider on this
https://lippertmarkus.com/2020/08/13/chartreleaser/
When you now push a change to your master branch, the action checks each chart for a new version. For updated charts it creates a GitHub Release and adds the chart artifact *.tgz file to the release. Now the index.yaml file on the gh-pages branch is updated to add your new chart version with the link to the GitHub Releases artifact.
This CI should be work in the repo which only includes the source code of Helm charts right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

You can build from source in one repo and push build artifact to another repo.

On Jan 26, 2021, at 1:55 AM, Aisuko<EMAIL_ADDRESS>wrote:

I have a consider on this
https://lippertmarkus.com/2020/08/13/chartreleaser/
When you now push a change to your master branch, the action checks each chart for a new version. For updated charts it creates a GitHub Release and adds the chart artifact *.tgz file to the release. Now the index.yaml file on the gh-pages branch is updated to add your new chart version with the link to the GitHub Releases artifact.
This CI should be work in the repo which only includes the source code of Helm charts right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@ramrodo, this is a good item to review in the Meshery CI Meeting this Thursday.

@ramrodo, this is a good item to review in the Meshery CI Meeting this Thursday.

Added to the agenda 👍🏼

Added to the agenda 👍🏼

One question @Aisuko, are you currently working on this?. I want to help if it is possible but I don't understand well what we should do. For instance, you mention:

This CI should be work in the repo which only includes the source code of Helm charts right?

I think that yes. We should implement this CI workflow in the same repo that the Helm Charts source code is.

I have a consider on this
https://lippertmarkus.com/2020/08/13/chartreleaser/

Yes. It's a good idea to use that GitHub Action to publish the chart releases into a Github Page and also, it'll allow us to add the .tgz to the Github release published 👍🏼

Hi, @ramrodo I mean this Github Action for Helm chart release tool is good for us. But I believe this tool would work well for the repo which only includes the Helm chart source code. Everything we committing should be aiming at Helm Charts. And the Github Action can release the new charts with bumped version.

@Aisuko ok, I see the problem you are pointing out. So, if we want to use that GitHub Action, we should separate the code of the charts to a new repo, right? Have another repo like "meshery-charts", right?

@Aisuko ok, I see the problem you are pointing out. So, if we want to use that GitHub Action, we should separate the code of the charts to a new repo, right? Have another repo like "meshery-charts", right?

Yes, you got this. @leecalcote Hello, sir. Any idea on this?

@Aisuko, yes, I wrote up a set of thoughts on this a few weeks ago and lost them when my browser crashed. Here's the very short version:

users that are serious about having Meshery help them run their service measures are most likely to be running mastery in Kubernetes. Making sure that this Meshery deployment experience is highly curated and smooth is important. To facilitate this, having the Helm chart published much more frequently will help ensure that it's up to speed. It didn't (and maybe still doesn't?) have all of the adapters in it. We are retiring the Octarine adapter, so that needs updated. The point is that changes occur here some frequency.
Our CI workflows include much conditional logic today. Some of the that logic is based on whether files in a path are changed (e.g. only publish new version of the chart when changes to the chart files are made).
The Meshery repo has many components in it (ui, cli, database, docs and so on). We do this because people measure a project based on number of stars and number of contributions. We need to optimize where those signals live (we need them in the same core repo to the extent possible). The helm chart is another one of those components.

I propose that we work to integrate conditional flow for publishing Meshery's helm chart using the same release version number as Meshery. Agreeable?

@ramrodo do you have any objections here? Let's move forward?

@Aisuko, yes, I wrote up a set of thoughts on this a few weeks ago and lost them when my browser crashed. Here's the very short version:
* users that are serious about having Meshery help them run their service measures are most likely to be running mastery in Kubernetes. Making sure that this Meshery deployment experience is highly curated and smooth is important. To facilitate this, having the Helm chart published much more frequently will help ensure that it's up to speed. It didn't (and maybe still doesn't?) have all of the adapters in it. We are retiring the Octarine adapter, so that needs updated. The point is that changes occur here some frequency.

* Our CI workflows include much conditional logic today. Some of the that logic is based on whether files in a path are changed (e.g. only publish new version of the chart when changes to the chart files are made).

* The Meshery repo has many components in it (ui, cli, database, docs and so on). We do this because people measure a project based on number of stars and number of contributions. We need to optimize where those signals live (we need them in the same core repo to the extent possible). The helm chart is another one of those components.

I propose that we work to integrate conditional flow for publishing Meshery's helm chart using the same release version number as Meshery. Agreeable?

For sure, I got your point. You are right, we need the contributor to focus on our main project(Especially the situation of us). If we release a new version of Meshery; We should release the new version of Helm charts. So, we need to change the image tag from latest  to the specially verson.

@leecalcote Sure! Sounds really good. We're on the same page. We can proceed with this.


Remove maps to unblock 3.0.0 OSD builds

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Remove maps to unblock 3.0.0 OSD builds
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2844 (e991d63) into main (6500b40) will decrease coverage by 0.47%.
The diff coverage is 79.13%.

@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   93.82%   93.34%   -0.48%
==========================================
  Files         157      158       +1
  Lines        4242     4373     +131
==========================================
+ Hits         3980     4082     +102
- Misses        262      291      +29

Impacted Files
Coverage Δ

src/test_workflow/test_cluster.py
85.33% <40.00%> (-3.24%)
:arrow_down:

src/test_workflow/integ_test/integ_test_suite.py
85.71% <55.55%> (-8.41%)
:arrow_down:

src/manifests/test_manifest.py
85.71% <61.11%> (-11.66%)
:arrow_down:

src/test_workflow/integ_test/topology.py
87.50% <87.50%> (ø)

...workflow/integ_test/integ_test_suite_opensearch.py
92.00% <100.00%> (+0.33%)
:arrow_up:

src/test_workflow/integ_test/local_test_cluster.py
100.00% <100.00%> (ø)

src/test_workflow/integ_test/service_opensearch.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Enrich the list of infrastructure we support

Description:
ATM, we only run following infrastructure:
OS: Ubuntu 16.04 and CentOS 7.4
JDK: OpenJDK 8 and Oracle JDK 8
DB: Postgres 9.6.1, 10.3, mysql 5.7, oracle 11.2, sqlserver 13.00, mariadb 10.0.32
This is not comprehensive enough. We need to add rest of the OSes, JDKs, and Databases. We need to more DBs, JDKs and OSes.
We can add some of the infrastructure by simply adding an entry into infrastructure_parameter table. This can be done for other CentOS versions such as 6.6, adding other Database versions such as Mysql 5.6, Oracle 12g etc.
Therefore, we need to first add the infrastructures we can easily configure via infrastructure_param table.
Rest can follow course afterwards.
Affected Product Version:
0.9.0-m22
Related Issues:
N/A

cc @tharindu1992

Closing since now the product-teams/script providers are responsible to add new infrastructures to incorporate with TestGrid. :)


RTS-1466: Reduce the limits on warn_object_size and max_object_size

https://bashoeng.atlassian.net/browse/RTS-1466
Basically this is a port of https://github.com/basho/riak_kv/blob/develop/src/riak_kv_vnode.erl#L2338-L2353 to write-once.
Test: https://github.com/basho/riak_test/pull/1218

+1 looks fine to me

what about https://github.com/basho/riak_kv/blob/79473edc4ef6f90b29cf7394186c01ab045ad69d/test/riak_kv_schema_tests.erl#L102
https://github.com/basho/riak_kv/blob/79473edc4ef6f90b29cf7394186c01ab045ad69d/test/riak_kv_schema_tests.erl#L103
https://github.com/basho/riak_kv/blob/79473edc4ef6f90b29cf7394186c01ab045ad69d/test/riak_kv_schema_tests.erl#L159
https://github.com/basho/riak_kv/blob/79473edc4ef6f90b29cf7394186c01ab045ad69d/test/riak_kv_schema_tests.erl#L160
@javajolt

Those look to simply be configuration test values. They only live inside the test, so they are probably good to change them as well, however.

+1

Is this to check Riak TS writes? From the riak_kv_vnode.erl code it looks like it only affects normal puts.

Sounds like we need to review this requirement

@andytill Where are write once limits imposed?

I can't see where the limits are used at all, by looking for that configuration key. I haven't investigated thoroughly, just did a find all on the key string.

Discussed with @angrycub - we will have lower thresholds for Riak TS 1.5 as defined in the requirements document. For 2017 roadmap, we will discuss how to make it more flexible. We'll probably need several global thresholds (e.g. KV buckets, TS tables, object storage) and also will check what it takes to have limits per bucket type.

After some quick experimentation I can't think of a good way to clean this up, so never mind my suggestions above.
Test works, logging matches, code looks like it's doing what's intended.
+1

thumbot retry

+1

thumbot retry

thumbot retry

thumbot retry

+1


Allow custom querystring parsing and serialization.

type-route uses querystringify internally. This is fine when starting up a new project, but for projects stuck with existing URLs, it can cause information loss in the URL and prevent type-route from being used at all.
Example querystring:
?thing[]=stuff1&thing[]=stuff2
parses as
{ "thing[]": "stuff1 }
Can you think of a way to expand router or route definition to customize querystring parsing? I experimented a bit, but it ends up being yet another overload to defineRoute. For that cost, it seems like there'd need to be more benefit, like general transformation of query/params (invert control a bit per-route).

I've been experimenting with something that could cover this and some other features at the same time. I'm hitting some TS inference limitations, but I think I can work around them.
I haven't figured out the runtime part yet - for now I'm just seeing if TS can handle it.
// imagine versions for optional vs. required strings
type QueryParamAdvanced<TParsed> = {
  type: "query.param.string";
  parse: (value: string) => TParsed;
  // supply both the value and the entire query string depending on needs
  stringify: (values: { value: TParsed, queryString: string }) => string;
};

const { routes } = createRouter({
  books: defineRoute(
    {
      userId: "path.param.number",
      relatedUserIds: {
        type: "query.param.string.optional",
        stringify: (value: number[]) => value.join(","),
        parse: ({ value }) => value.split(",").map(Number)
      },
      bookIds: {
        type: "query.param.string.optional",
        stringify: (value: string[]) => qs.stringify(value),
        parse: ({ queryString }) => qs.parse(queryString).bookIds
      }
    },
    params => `/books/${params.userId}`
  )
});

The hopeful goal is to keep all the URL stuff hidden away, without complicating the API for simpler routes:
routes.books.href({
  userId: 1,
  relatedUserIds: [2, 3],
  bookIds: ["5", "6"],
});

I like the direction this is going and appreciate the use case you've raised. I've been thinking for a while about a way to give more flexibility to query and path parameters so they can be more than just numbers and strings. I haven't however thought about needing to support parsing things such as ?thing[]=stuff1&thing[]=stuff2 into something like {think:['stuff1','stuff2']}. I'd be open to the idea of a user providing their own query string serializer/deserializer at an entire router level to ensure keys are properly matched up with values and then having the ability for individual parameters to have custom serializers/deserializers for the actual value. Need to think on it some more but thanks for opening this!

This PR adds the ability to provide a custom query string serializer: https://github.com/type-route/type-route/pull/35. Any feedback on the new api would be appreciated!

Released support for this in 0.4.0! Feel free to reopen if you feel that release doesn't address this fully.


proposal: affected/package: crypto/ssh

Add support for service names additional to port numbers to ssh.Client.Dial.
PR: https://go.dev/cl/443775
net.Dial already supports this same, this proposal adds that same feature to ssh.Client.Dial.
Currently ssh.Client.Dial uses strconv.ParseUint to convert a port number as string into the int type it needs.
The proposal is to use net.LookupPort instead.
net.LookupPort is purpose build for interpreting strings as ports and has the additional feature that it also supports service names.

This addition seems reasonable to me
cc @golang/proposal-review

With no api change I don't think this requires a proposal

I have already approved the change, and didn't think this needs a proposal at all.

It needs the proposal tag, I was about to ok a CL after the "is this what it claims" Google-required supply-chain check, and realized that it might reach the "proposal" bar, pinged the rest of the release team, and consensus was "yes".

Thanks for all the input! What would be the next step now?


chore: move build tool to vite

Moving build tool from react-scripts to vite.
Reasons:

Improved Performance.
Better build speeds
Better support

Reasons to deprecate react-scripts:

Slower to build and no longer maintainer by the react team.

Work great. Thanks for this. After comments and conflicts it should be good to go.


Improve Mac Install Script

TODO:

[x] Create helper functions
[x] Install Python
[x] Install Git
[x] Install Tesseract OCR
[x] Test

@dianzrong
I have added a TODO for Installation for Tesseract OCR with  the link for reference.
https://github.com/MLDSAI/OpenAdapt/blob/main/install/install_openadapt.sh#L4
It will be great if you implement that for macOS :)

@KrishPatel13 Will do!

@dianzrong Thank you! 😊
Also, Here is the link for the PR that added the TODO, just for reference!
https://github.com/MLDSAI/OpenAdapt/pull/243

Next up we have to:

[ ] Add poetry setup commands instead of .venv

@dianzrong we tested this on @flyguy712 's machine, and it worked. Thank you!

For reference: Video of install


[WIP] Lesson 3: Overview of building blocks (tensors) of TensorFlow main methods, functions, and datasets

Relates to https://github.com/developmentseed/servir-amazonia-2-internal/issues/5
In this lesson, we go through:

some basics on tensors, how to use them
tf.function and when to use
tf.data and how to create datasets from raw data

cna > can
Tip: open the notebook in vscode, it should highlight spelling issues.
Respond and view the context here.

Nice to have, an answer to the question above.
variable: loss value, changes with each epoch
constant: fixed hyper parameters like batch size
Respond and view the context here.

A "vector" is a "rank-1" tensor and contains something like a list of values > In ML, a "vector" is a "rank-1" tensor and contains a list of values
In mathematics vectors can have more than 1 dimension, but when it comes to ML, vectors typically refer to single dimensional arrays. I think we can omit the last sentence "A vector is characterized by having one axis." since this doesn't hold depending on who you're talking to.
Respond and view the context here.

Word. I actually provide an answer a bit later on, discussing how trainable weights should be variables. But I like these suggestions too.
Respond and view the context here.

overall not a big deal though
Respond and view the context here.

can delete  "and mostly out of scope for now", implied
Respond and view the context here.

definition of rank happens after the term is introduced, can you shift where it is introduced below this or move these definitions up?
Respond and view the context here.

I think we can leave out "It's also used in the making of data pipelines."
We don't introduce the concept of functional data pipes in this lesson so this might confuse learners
Respond and view the context here.

can also remove data pipes here too. unless we introduce TF's concept of it with code.
Respond and view the context here.

ok here I think is where we map tf.data.dataset to data pipes, should be data pipes for consistency.
can this introduction be moved up? and I think in that case, good to expand and define data pipes and include the references to datapipes.
Respond and view the context here.

Reviewed and revised per all of the suggested changes. Merging now.


grenade prediction v2

revert drawing to match old grenade prediction while still staying more accurate.

Hi, nice job on the grenade prediction but you should fix the variable naming and some of the code organization, take a look @ Contributing.md, there's also a resharper settings file in the repo's main directory.


[CARBONDATA-2316] Executor task is failed but UI shows success issue is fixed …

[x] Any interfaces changed?  No

[x] Any backward compatibility impacted? No

[x] Document update required? No

[x] Testing done UT And FT success report is sufficient . offline verified .

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4852/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3630/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3673/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4896/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4365/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4396/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3720/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4939/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4942/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3723/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4400/

LGTM


Broken links in docs

Description of the Change
Broken links modify to enable in the documentation,
page link below
https://mochajs.org/api/tutorial-custom-reporter.html

Alternate Designs
N/A

Why should this be in core?
N/A

Benefits
link enable  in the documentation

Possible Drawbacks
None

Applicable issues
Fixes #3855

Coverage increased (+0.03%) to 91.739% when pulling 7822be6d0569ef74ce1037ebc4aa446f93eaf03f on toyjhlee:feature/3855 into 63056f08b412fdb0908a1a829a3f37dd2bdc2ac8 on mochajs:master.


Proposal: Add ability to use preprocessor in assets folder

We currently can use preprocessor (sass and typescript) in our svelte component but this doesn't apply to the assets folder.
It could be nice to add this ability, probably a modification in copyAssetsToPublic, by checking the file extension and apply the corresponding preprocess.
If it's done, it could be nice to add some options to elder.config, in order to enable/disable this feature and to include/exclude some files; if we need the raw file in public for whatever reason.

@kiuKisas We should look if imported files within Svelte components get bundled.

My gut feel is that this is outside of the scope of Elder.js and could easily be added to the rollup config.

Just some though as I don't think it's a priority right now.
I though it could be nice to have this feature "out of the box", it can't be done through a plugin right now because we don't have access to rollup config, but if we offer an "out of the box" solution, it should be a plugin.
Also, one use case I can think of is to have scss files with variables and being able to access them in any route/component without having to import the variable file. This file should probably not be into the assets folder though.
For those who are interested, I currently have this quick implement (modification of copyAssetsToPublic hook ) that works for my use case (global css files):
const sass = require('node-sass')
  {
    hook: 'bootstrap',
    name: 'copyAssetsToPublic',
    description:
      'Copies ./assets/ to the "distDir" defined in the elder.config.js. This function helps support the live reload process.',
    priority: 50,
    run: ({ settings }) => {
      // copy assets folder to public destination
      glob.sync(path.resolve(settings.rootDir, './assets/**/*')).forEach((file) => {
        const parsed = path.parse(file);
        // Only write the file/folder structure if it has an extension
        if (!(parsed.ext && parsed.ext.length > 0)) return;
        const relativeToAssetsFolder = path.relative(path.join(settings.rootDir, './assets'), file);
      // TODO: write a cleaner version for preprocess
        const outputPath = path.resolve(settings.distDir, relativeToAssetsFolder);
        fs.ensureDirSync(path.parse(outputPath).dir);
        if (parsed.ext === '.scss') {
          if (parsed.name[0] === '_') return;
          sass.render({ file, outputStyle: 'compressed' }, (err, result) => {
            if (err) {
              console.log(err);
              return;
            } else {
              fs.outputFileSync(outputPath.split('.').slice(0, -1).concat('css').join('.'), result.css);
            }
          });
        } else {
          fs.outputFileSync(outputPath, fs.readFileSync(file));
        }
      });
    },
  },

Using rollup seems cleaner though, but  I probably not gonna change this soon.

@kiuKisas makes sense but point of clarity. We give users complete control to add their own rollup definitions due to the way Elder.js is configured. They just need to add it before or after the Elder.js Rollup in their rollup config.

@kiuKisas For scss here is how we're handling it:
// Layout.svelte
<style lang="scss" global>
  @import '../styles/style.scss';
</style>

The next release of Elder.js will properly rebase images.


Interoperability with MATLAB

Has anybody tried to import an interval matrix from INTLAB into mpmath iv matrices? I can use Python and MATLAB for floats using the MATLAB python engine but I'm just wondering if this would be possible for the Interval data type.

@david10e10, MATLAB and INTLAB are proprietary software.  If you are using that, why just not try to interact with the mpmath?
The iv context has very limited implementation, almost nothing beyond the basic arithmetic is guaranteed to work correctly.  I doubt it can interoperate with the INTLAB.  This is how implemented conversion from other types to iv.mpf:
https://github.com/mpmath/mpmath/blob/08cbde4bfbb2a6079644021fc51b3d179cce1a5e/mpmath/ctx_iv.py#L405-L436
It shouldn't be hard to workaround this, however.  You can transform end-points to rational numbers or to mantissa/exp pairs.  This will allow you to reconstruct mp.mpf and then iv.mpf...
Feel free to reopen this issue, if you think the answer is not clear or you think that mpmath can implement something to better interact with matlab/intlab.


remove featuregate DevicePlugins

due to https://github.com/kubernetes/kubernetes/pull/117656

Thanks @carlory for the PR.
The changes look good to me.
/lgtm

In https://k8s.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/, it is still said that
{{< note >}}
Although the Device Manager component of Kubernetes is a generally available feature,
the _device plugin API_ is not stable. For information on the device plugin API and
version compatibility, read [Device Plugin API versions](/docs/reference/node/device-plugin-api-versions/).
{{< /note >}}

Do we need to revise this?

In https://k8s.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/, it is still said that
{{< note >}}
Although the Device Manager component of Kubernetes is a generally available feature,
the _device plugin API_ is not stable. For information on the device plugin API and
version compatibility, read [Device Plugin API versions](/docs/reference/node/device-plugin-api-versions/).
{{< /note >}}

Do we need to revise this?

I think we can remove this note, as it is stable now and the feature gate is removed.
WDYT? @carlory @tengqm

@carlory can we mention the issue k8s/k8s #113587 here, for better understanding of readers i.e. we Device Plugin API didn't graduate alongside the DeviceManager.

@Shubham82 done.

/sig node

Thanks.
/approve

@carlory, Rebase your changes.

@Shubham82 done

JFI: This PR also removed the graduated feature gate DelegateFSGroupToCSIDriver

Thanks, @carlory
it looks good to me.
/lgtm


Support

Hi! I will be taking down or hide my original mod - JContainters for several days. Will you support me and do the same?
I wanted some attention from gaming community to the events happening in my country where I live, in Ukraine. I know that Nexus tries to keep neutral position and to not discuss politics.

I know several people from over there. It is your mod however so, I think you have the full rights to do whatever you want with it. You should have enough rights to hide it even I believe?

@ryobg I do not want to be intrusive.
 If you need else, let me know.

@ryobg Thank you!


Drupal core v7.102 [0.5h]

Security release - https://www.drupal.org/project/drupal/releases/7.102

Deployed to live


Regions "regions-double-clicked" event does not trigger on mobile

Bug description
When using regions:
Regions "regions-double-clicked" event does not trigger on mobile
Environment

Browser: Internet on Android, Edge on Android

Minimal code snippet
regions.on('region-double-clicked', function(region, e) {
    e.stopPropagation()
    axios.post('/api/annotations/' + region.id + '/delete');
    region.remove();
})

Expected result
Event should be firing on double tap on region
Obtained result
Event not firing on double tap on region

This event is using the native dblclick DOM event which sadly isn't supported on touch devices.
We can detect double taps manually like this:
let lastTap = 0
element.addEventListener('touchend', (e) => {
  const tapGap = Date.now() - lastTap
  if (tapGap < 300 && tapGap > 0) { // Detect double-tap (within 300ms)
    this.emit('dblclick', e)
  }
  lastTap = currentTime
})

Pull requests are welcome!


Removed automatic Upgrade header logic from UpgradeAsync to fix issue 2086

Removed automatic Upgrade header logic from UpgradeAsync to fix issue 2086

Removed code to set response headers -  connection and upgrade as it should be  set by caller e.g. WebSockets Middleware
Fixed test cases - as connection would be set to "close" instead of "upgrade" after removing headers

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: brightcr sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Wouldn't it be decent to cherry-pick @markuspalme's commit from https://github.com/aspnet/KestrelHttpServer/pull/2300 here? 🤔

Sorry, I didn't have a chance to work on this sooner. Is there anything left to do now?

Nope, all good.


Box.com OAuth2

Changes

Updates Tauri to v1.4
Adds "Sign in to Box" to the WelcomeModal instead of Start
Full Oauth2 sign in flow to authenticate with Box.com
New Rust commands

get_auth_url - Returns Box sign-in URL to open in new window
request_token - Uses authorization code from sign-in to request an API access token and puts  the tokens in the settings store
refresh_token - Retrieves refresh token from settings store and requests a new API access token

Includes demo API functions and buttons to test that the token and refresh token are working

Can you update this PR with our new codebase structure and our new DEV_ rule for development-only files.


getDuration return 0 first time

Can you specify which platform and environment? Device or simulator?

Closing this out. Feel free to reopen if the issue persists!

Obviously, this issue is 100% related to this one: https://github.com/jsierles/react-native-audio/issues/115
You are trying to get the file duration, when actually the file was not totally created yet.
We need promises. Always we are dealing with files, we need promises.

Unfortunately we have no way to know when the file is finished writing. Check #115 for more discussion on solutions for this.


scheduled erase option

Feature idea: Automatic erase of (certain) mails older than XX days via cronjob.

Maybe instead deleting we could archive it.
Create a zip file in /files/ where the eml files are compressed

I like both ideas :-)

Are you planning to develop this enhancement?

Hey,
I will close this as we currently want to work for features only for Shopware 6. If you want to implement it by own feel free to create pull request


Display notifications with this.$waveui.notify()

Instead of having to create w-notification elements in potentially deeply nested components and worry about having them overlap with other notifications and so on, it would be nice if notifications could be triggered from anywhere with a function call, and have them centrally managed.
Ideally, notifications would also never overlap. If a notification was triggered while another one was still visible, they should be automatically arranged such that they are both always visible.

As per #40, I’m using Vue 3.

Also related to #14, now considering this feature request.

Hi @djmattyg007, @mikeerickson, @Epithumia, @HenryLin0914.
This is now possible in Wave UI 1.35.0 and 2.21.0.
Check the documentation at https://antoniandre.github.io/wave-ui/w-notification!
Thanks for suggesting this feature, and please reopen if you see any issue. :)

HI @antoniandre we still need a pretty confirm/prompt dialog box.  I have hacked one using w-dialog, and I had to create a new instance of WaveUI every time to make it work right.  It would be nice if there was a simple w-dialog prebuild with a confirm capability.


Explicitly depend on poetry-plugin-export

See

https://python-poetry.org/blog/announcing-poetry-1.2.0/#migration-of-the-poetry-export-command

To reflect this, and to accelerate development of the main Poetry project, it has been migrated into a separate repo and is distributed separately as poetry-plugin-export.

To ease the transition, the plugin is installed by default for the 1.2 release. Future releases of Poetry will deprecate this automatic install, and require the user to explicitly install the plugin.

Since nox-poetry depends on poetry-plugin-export, it should document that users must install it or install it as a dependency (if that is supported for poetry plugins? A user might have to opt into this).

Note that this will become a more pressing issue because as of Poetry 1.7.0

Print a future warning that poetry-plugin-export will not be installed by default anymore

https://github.com/python-poetry/poetry/pull/8562

A potential Poetry feature that would really help solve this for nox-poetry users is:

https://github.com/python-poetry/poetry/issues/5729
https://github.com/python-poetry/poetry/pull/5740

Poetry 2.0 will have this and when it is released, we will need to update the docs here to instruct people on how to add the export plugin as a required plugin for their project

https://github.com/python-poetry/poetry/pull/9547

What do we need to do to silence this warning and keep our projects running?

This is documented here: https://python-poetry.org/docs/plugins#using-plugins
Since it is another manual bootstrapping step, however, I'm personally allowing the warning to print until Poetry 2.0 is released and plugins can be explicitly declared as a dependency for a project, which scales much better with multiple team members.


Add numbered lists guidance

What do you need?
We should advise when it's appropriate to use an ordered/numbered list.
Which entry/section is this related to?
http://content-style-guide.apps.staging.digital.gov.au/az-indexes/n.html#numbered-lists
Good example
https://github.com/AusDTO/dto-design-guide/blob/feature/typography-refactor/_foundations/typography/lists.md
https://www.gov.uk/guidance/style-guide/a-to-z-of-gov-uk-style#bullet-points-steps

Content Clinic agrees to add "go easy" guidance - e.g. can be overwhelming to have large number of numbered steps. Check with @AndrewArch

https://github.com/govau/content-guide/issues/37


[BUG] quick description of bug

Duplicate Path Definition in Router
Duplicate / Path
Problem: The route definition has two paths set to /. One renders the Layout component, and another renders the OperationsPage component under the same path (/). This could lead to routing conflicts or unexpected behavior since both routes compete to render when the path is /.
can anyone fix this??

Removed duplicate / path:
{
  path: '/',
  element: <OperationsPage />, // Ensure only one definition
}

The second definition of the / path that pointed to OperationsPage was removed.
Set OperationsPage as the default route: Instead of giving OperationsPage its own / path, it is now the default child of Layout by using index: true. This way, when the root / is hit, OperationsPage is rendered by default under Layout.


Feature specification content on the website

Upstream issues:

https://github.com/riboseinc/jekyll-theme-open-project-helpers/issues/9
https://github.com/riboseinc/jekyll-theme-open-project/issues/38

Current implementation integrates model diagrams (screenshot). To do before release:

Fix specification layout to match software docs (with expandable narrow-viewport-friendly navigation bar)
Make build work with Metanorma-based specs in addition to PNG diagrams

I wonder if we should directly incorporate PlantUML into site generation rather than relying on PNG files?

Sure, could be another plugin. This one is convenient in that if you switch to another diagram generator it won’t break project sites downstream, and that it takes any PNGs, not just a UML spec.

On 25 Nov 2018, at 8:32 PM, Ronald Tse<EMAIL_ADDRESS>wrote:
I wonder if we should directly incorporate PlantUML into site generation rather than relying on PNG files?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes indeed. Maybe that is desirable. Let's hold off PlantUML for now.

Yeah seems pragmatic to hold off PlantUML for now since handling its dependencies (or containerizing the whole thing) complicates things. Adding the Metanorma engine next, there’re some challenges there too. PNG illustration engine to fix #34 is working at the moment, pending deployment: http://www.metanorma.comspecs/metanorma-model-gb/

BTW it is easy to build Metanorma documents now using Travis, you can see the Travis CI file here https://github.com/riboseinc/ogc-tcpnp.
So it should be really easy to have a Jekyll plugin that renders Metanorma.

To build PlantUML sources into SVG, rather than rely on images being part of model repo, it should be possible to call these methods: https://github.com/nus/gitbucket-plantuml-plugin/blob/master/src/main/scala/com/yotaichino/gitbucket/plugins/plantuml/PlantUMLUtils.scala#L12

You can consider the asciidoctor-diagram gem that allows this?