Can I merge my own PR?

Bug Report

[x] I have searched the issues of this repository and believe that this is not a duplicate.

In the past we used loose lgtm management, but to ensure that all code is reviewed when merging, the new bot places some restrictions on committers merging their own pr. Submitters are not allowed to merge their own pr directly.

From BusyJay
For example, if an overseas colleague commits a code and gets two lgtms after many days, and then changes a typo, he needs to wait at least one day to merge it again. But the author can merge it directly if he/she decides to do so.

From BusyJay
For example, if an overseas colleague commits a code and gets two lgtms after many days, and then changes a typo, he needs to wait at least one day to merge it again. But the author can merge it directly if he/she decides to do so.

If we didn't have this restriction, when the committer's PR have two lgtms, because we don't automatically remove the lgtm when there is a new commit, the committer could merge that pr without a review.

If we didn't have this restriction, when the committer's PR have two lgtms, because we don't automatically remove the lgtm when there is a new commit, the committer could merge that pr without a review.

From @BusyJay
For example, if an overseas colleague commits a code and gets two lgtms after many days, and then changes a typo, he needs to wait at least one day to merge it again. But the author can merge it directly if he/she decides to do so.

From @BusyJay
For example, if an overseas colleague commits a code and gets two lgtms after many days, and then changes a typo, he needs to wait at least one day to merge it again. But the author can merge it directly if he/she decides to do so.

In my opinion, I think this is a flaw in the mechanism, and I don't think committers should be allowed to merge their PRs from this perspective.

In my opinion, I think this is a flaw in the mechanism, and I don't think committers should be allowed to merge their PRs from this perspective.

To correct the context, TiKV has been allowing people who have write access to the project to merge any PRs that have two approvals with new commits for more than a year. We believe in trust instead of defending against our collaborators. Author should ask for new reviews when the changes are not pure fixing typos or fixing conflicts. /cc @nrc

To correct the context, TiKV has been allowing people who have write access to the project to merge any PRs that have two approvals with new commits for more than a year. We believe in trust instead of defending against our collaborators. Author should ask for new reviews when the changes are not pure fixing typos or fixing conflicts. /cc @nrc

We should be aware that this is a trade-off, not a simple case of one approach is better. If we allow self-merge, we sacrifice some security for the sake of development velocity and if we don't, then we sacrifice some development velocity for the sake of security.
It's worth examining both sides of the trade-off to make a decision, but before we do that we should understand that both things are important - code security should be obvious, development velocity is also important - on large projects with large teams, rebasing is a non-trivial task which can take significant time and introduce subtle errors, slowing down landing PRs can snowball into long delays and lots of non-productive work, i.e., it can have an impact on how quickly we can fix bugs and implement features for our customers. Requiring re-review costs the time and energy of two reviewers.
Let's examine the motivation for this change: we want to improve our code security. The implicit threat model is that a developer with merge permission for the repo either maliciously or accidentally merges a change which includes a bug which would otherwise have been found by a reviewer. This is possible if the PR is ok, the author adds a commit with the bug, and then merges the PR; or there is another bug in the bot where a PR can be merged without proper review and the author does so (i.e., this second case is defense in depth).
However, this change does not help as much as expected. In order to merge the PR, the author must have permission to merge PRs to the repo, this means that they are trusted, this feature is not available to all authors. We trust the author to voluntarily ask for re-review of significant changes and not to introduce malicious changes. If we can't trust the author in this way they should not have the ability to merge (or review) code at all.
Importantly, the review system is based on trust. We trust reviewers and some authors. The system does not provide perfect security in the presence of a malicious insider, and neither can many of our other systems.
For there to be a benefit any bug must be found be the reviewers, I believe that in a large PR with small, rebasing changes, it would be rare for a reviewer to catch a bug on re-review. So, the real benefit of this change is much less than the perceived benefit. Furthermore, the frequency of such bugs being introduced will be very low, so the overall benefit of this change is also very low. On the other hand, the cost in time and frustration is there on many PRs, so the total cost is large.
Finally, even if a bug is landed, there is a high chance that it will be found by testing or code inspection later and it can be fixed. The Git history provides a permanent record of how the bug was introduced and what was there before.

We should be aware that this is a trade-off, not a simple case of one approach is better. If we allow self-merge, we sacrifice some security for the sake of development velocity and if we don't, then we sacrifice some development velocity for the sake of security.
It's worth examining both sides of the trade-off to make a decision, but before we do that we should understand that both things are important - code security should be obvious, development velocity is also important - on large projects with large teams, rebasing is a non-trivial task which can take significant time and introduce subtle errors, slowing down landing PRs can snowball into long delays and lots of non-productive work, i.e., it can have an impact on how quickly we can fix bugs and implement features for our customers. Requiring re-review costs the time and energy of two reviewers.
Let's examine the motivation for this change: we want to improve our code security. The implicit threat model is that a developer with merge permission for the repo either maliciously or accidentally merges a change which includes a bug which would otherwise have been found by a reviewer. This is possible if the PR is ok, the author adds a commit with the bug, and then merges the PR; or there is another bug in the bot where a PR can be merged without proper review and the author does so (i.e., this second case is defense in depth).
However, this change does not help as much as expected. In order to merge the PR, the author must have permission to merge PRs to the repo, this means that they are trusted, this feature is not available to all authors. We trust the author to voluntarily ask for re-review of significant changes and not to introduce malicious changes. If we can't trust the author in this way they should not have the ability to merge (or review) code at all.
Importantly, the review system is based on trust. We trust reviewers and some authors. The system does not provide perfect security in the presence of a malicious insider, and neither can many of our other systems.
For there to be a benefit any bug must be found be the reviewers, I believe that in a large PR with small, rebasing changes, it would be rare for a reviewer to catch a bug on re-review. So, the real benefit of this change is much less than the perceived benefit. Furthermore, the frequency of such bugs being introduced will be very low, so the overall benefit of this change is also very low. On the other hand, the cost in time and frustration is there on many PRs, so the total cost is large.
Finally, even if a bug is landed, there is a high chance that it will be found by testing or code inspection later and it can be fixed. The Git history provides a permanent record of how the bug was introduced and what was there before.

@nrc  Thank you for your patient explanation, I couldn't agree with you more from a benefit perspective.

@nrc  Thank you for your patient explanation, I couldn't agree with you more from a benefit perspective.


Backup/restore credentials

2.0.0

Did support
Verifiable credentials
Backup/restore credentials

The changelog contains this listing. But I could not find any function call to backup and restore credentials.

Future<String?> backupIdentity({
required String privateKey,
});
Future restoreIdentity(
{required String privateKey, String? encryptedDb});

Affer calling restoreIdentity passing as param the encryptedDb you got as response from backupIdentity, credentials are recovered in the sdk, so calling credential.getClaims method should return the claims restored.

Hello @rauljareno,
Step 1:
final encryptedDb = sdk.identity.backupIdentity(privateKey: privateKey);
Step 2:
    final privateIdentityEntity = await sdk.identity.restoreIdentity(
      privateKey: privateKey,
      encryptedDb: encryptedDb,
    );

I did this step. So, what is the further process with privateIdentityEntity??
getClaims requires Iden3MessageEntity parameter. I don't have this with above steps. Am I missing anything?
Our moto is to backup, save somewhere and restore the credentials in the wallet..

@rauljareno backupIdentity vale is supposed to contains encrypted credentials (claims) ?

hello @bibash28 @hawkbee1 ,
you were using getClaims from iden3comm that is for interacting with issuer/verifier messages. I was referring to getClaims from credential. So in the end it will look like this:
Step 1:
final encryptedDb = sdk.identity.backupIdentity(privateKey: privateKey);
Step 2:
  final privateIdentityEntity = await sdk.identity.restoreIdentity(
     privateKey: privateKey,
     encryptedDb: encryptedDb,
   );

Step 3:
final List<ClaimEntity> credentials = await sdk.credential.getClaims(
      genesisDid: privateIdentityEntity.did,
      privateKey: privateIdentityEntity.privateKey
);

Hello @rauljareno ,
If the user has already did and the private key saved already, then we should not have to go through steps 1 and 2. Am I right?

steps 1 and 2 are for backing up and restoring the identity and the credentials stored in the sdk. If Identity is already created in the sdk and there are credentials already stored in the sdk, you can call step 3 directly.

steps 1 and 2 are for backing up and restoring the identity and the credentials stored in the sdk. If Identity is already created in the sdk and there are credentials already stored in the sdk, you can call step 3 directly.


Support deprecated tags in TS marked source

While reading the TS 4.0 release notes,
I realized that the TS indexer currently doesn't tag entities that are
marked as deprecated. There's a formal API for this in TS 4.0, but we
accurately determine whether a node is deprecated (and why) by scanning
the JSDoc tags of that node.

ptal @evmar


Is it possible to use ngstorage instead of $cookieStorage?

never used ngStorage, but if it exposes a service that follows the same signature as $cookieStorage then tmhDynamicLocaleProvider.useStorage('someOtherService') will make it. If it does not follow the same signature, then it should be possible to create an intermediate service that does the right thing

Without any answer, I expect that https://github.com/lgalfaso/angular-dynamic-locale/issues/75#issuecomment-138622093 provides the right solution


DSI LCD Support

Is there any plan of releasing a build that has LCD Panel support for Linux (RockPro64)?

Well, you can change DTS yourself and support it.
For now, I added support for upcoming Pinebook Pro with eDP display.


added yolo v4 network

Lint doesn't pass.

Unit test is missing.

@Johnson-Wang Thanks for the suggestions. I have edited this PR according to the reviews and please have a look when it is convenient for you.

so, is there any plan to merge to master branch? or just it will stay as a branch?


floatingActionButton contains a Row

Steps to Reproduce
new Scaffold(
      appBar: new AppBar(),
      floatingActionButton: new Row(
        mainAxisAlignment: MainAxisAlignment.spaceBetween,
        children: <Widget>[
          new FloatingActionButton(onPressed: null),
          new FloatingActionButton(onPressed: null),
        ],
      ),
    );

the first FloatingActionButton is not in the correct place i need to add padding to make it right

This is definitely not the use-case that the scaffold's layout was intended for, in fact layouts with more than one FAB are called out as a bad idea in the Material design spec.  However.
What's happening in this case is that the scaffold is laying out the Row with a width constraint that matches the width of the screen.  The MainAxisAlignment.spaceBetween constraint causes the FABs to appear at either end of the row. Then the Scaffold's default floatingActionButtonLocation causes the row's location to be adjusted to the left a bit, as you can see.
If you really want to do this, consider writing a custom FloatingActionButtonLocation that puts the FAB where you want it.

thank you @HansMuller

I've the same. So, it's bug or feature?

use MainAxisAlignment.end


Chess game with another player

I tried playing chess with my friend since I can't play with the AI. After my turn it should be his turn, right? But for some reason, it's still MY turn. Can you guys fix this? The chess pieces on the board clearly are working fine.
Also what I mean by "still MY turn" is that I also control the black chess pieces.

It also only shows that it's my turn.

@GoddessLena are you still having this issue?

Fixed, turns will cycle correctly now


US914108: Version Currency: JUnit 5 migration

https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=914108

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
https://sou-jenkins2.swinfra.net/job/WorkerFramework/job/WorkerFramework~worker-framework-testing~914108~CI


[SYSTEMML-651] Fix scalar input support for JMLC

thanks @deroneriksson for debugging this issue. However, I would strongly recommend not to create these additional special cases in DAG (which would lead to different conditions firing for normal transient reads and transient reads introduced by jmlc/mlcontext). Couldn't we instead modify RewriteRemovePersistentReadWrite and clear the filename in case of scalars?

@mboehm7 In RewriteRemovePersistentReadWrite, I've tried things such as the following without success:
case PERSISTENTREAD:
	if( _inputs.contains(dop.getName()) ) {
		dop.setDataOpType(DataOpTypes.TRANSIENTREAD);
		if (hop.getDataType() == DataType.SCALAR) {
			dop.setFileName(null);
			dop.getInput().set(dop.getParameterIndex("iofilename"), new LiteralOp(null));
		}
	}

Also, such things as
dop.getInput().set(dop.getParameterIndex("iofilename"), new LiteralOp(Double.NaN));
and
dop.getInput().set(dop.getParameterIndex("iofilename"), new LiteralOp(""));
Do you have any further advice?

how about removing it (i.e., not overwriting) from both _paramIndexMap and _inputs?

@mboehm7 Let me know if the current implementation looks OK. Updated to:
if (hop.getDataType() == DataType.SCALAR) {
	int iofilenameIndex = dop.getParameterIndex("iofilename");
	dop.getInput().remove(iofilenameIndex);
	HashMap<String, Integer> parameterIndexMap = dop.getParameterIndexMap();
	parameterIndexMap.remove("iofilename");
	parameterIndexMap.put("format", iofilenameIndex);
}

thanks, in general yes, although not as clean as I hoped for when I made the initial comment.
I leave it up to you to go either with your original version or this one right here. If we use the latest version, I would recommend to move the map modifications into DataOp (together with a slight generalization for "re-indexing" arbitrary parameters, not just format). Also, you might want to change one of the existing jmlc tests to pass a scalar through this codepath (instead of the currently used input arguments).

@mboehm7 Created a removeInput method in DataOp which is called from RewriteRemovePersistentReadWrite. Also created some basic scalar input tests for JMLC.

All tests passed here.

LGTM - thanks @deroneriksson

@mboehm7 Thank you for reviewing and the help.


Area2D mouse_entered/mouse_exited doesn't update properly with Camera2D movement

Godot version
v4.0.2.stable.official [7a0977ce2]
System information
Windows 10, Linux
Issue description
When the mouse_entered and mouse_exited signals are used with an Area2D node, the signals are not emitted if the Camera2D moves the viewport such that the mouse enters or leaves the area.

Steps to reproduce
Open the attached minimal project...

Put the mouse cursor inside the circular area
Move the camera with WASD or arrow keys such that the mouse cursor enters and leaves the area (don't move the mouse in this step)
Watch as the label doesn't update properly

Minimal reproduction project
Area2D bug.zip

A few weeks ago, @RandomShaper and I have discussed this issue and came to the conclusion, that this should be considered a bug and be solved.

A few weeks ago, @RandomShaper and I have discussed this issue and came to the conclusion, that this should be considered a bug and be solved.

I haven't found a similar issue when searching the git so I decided to open up this one. It might be good to check if other types of nodes have the same bug, like Control nodes and Area3D.

The discussion happened on RockenChat, so it is good to have this Issue open as a reminder. And both other nodetypes, that you mentioned, show the same behavior.

Would love to see a fix for this implemented! I've also noticed that it's an issue if you want to use mouse_entered/mouse_exited signals on control nodes that have their positions updated (for example an AnimationPlayer that makes UI appear/disappear on toggle).

Would love to see a fix for this implemented! I've also noticed that it's an issue if you want to use mouse_entered/mouse_exited signals on control nodes that have their positions updated (for example: making UI appear/disappear using an AnimationPlayer).

@Dritic The issue about Control nodes is more complex and will have to wait until Viewport::update_mouse_cursor_state no longer creates InputEvents.


Added IsNil and IsNotNil assertions

@lukaszb thanks for the contribution. I like the idea of adding these type of assertions but we need to make sure to catch nil structs as well.  I.E:
var nilStruct struct{}
g.It("IsNil should trigger", func() {
	g.Assert(nilStruct).IsNil()
})

Currently this fails, It'd be nice if we could catch these scenarios also.

@marcosnils sure, can do that. btw, can you look at travis failed build? It seems to fail for code I haven't actually touched.

var nilStruct struct{}

This struct is zeroed, not nil (only pointers can be nil) so the behavior could be misleading.
IsZero() / IsNotZero() are probably better names for this more flexible functionality.


Zuul Static Resources Not Found ..

I configured the hystrix dashboard forwarding with zuul, but found some problems, static resource files were not found.
This is my zuul configuration：

This is my dashboard configurarion:

When I visit the http://localhost:8080/dashboard/hystrix page, the image and js are not found, but the page can display normally.

The address of the picture and js access is:

The reason they can't find it is because there is no prefix/dashboard~~
Can you help me solve this problem? thank u very much~~~

I know that zuul can do the forwarding of services, but can I do page forwarding?

This is not the Spring Cloud issue tracker, you should ask there. There's no functional difference between a service response and page response, just different content type.


feat: match, verbose opts, getMagicComment, external imports.

Adds options match and verbose to the schema.
Adds utility getMagicComments.
Relaxes import prefix regex to allow for external and absolute imports.
Adds an example to the readme.

Codecov Report
Patch coverage: 100.00% and project coverage change: +1.06 :tada:

Comparison is base (60c605a) 98.93% compared to head (54b8df8) 100.00%.

:exclamation: Current head 54b8df8 differs from pull request most recent head 1e4b574. Consider uploading reports for the commit 1e4b574 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #3      +/-   ##
===========================================
+ Coverage   98.93%   100.00%   +1.06%
===========================================
  Files          15        15
  Lines         188       197       +9
  Branches       67        72       +5
===========================================
+ Hits          186       197      +11
+ Misses          2         0       -2

Impacted Files
Coverage Δ

src/schema.js
100.00% <ø> (ø)

src/booleanComment.js
100.00% <100.00%> (ø)

src/strategy.js
100.00% <100.00%> (ø)

src/util.js
100.00% <100.00%> (+4.16%)
:arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: change filemaps for maps.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master      #1   +/-   ##
======================================
  Coverage    86.4%   86.4%
======================================
  Files           4       4
  Lines         103     103
======================================
  Hits           89      89
  Misses         14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc9f9b...a12bf59. Read the comment docs.


Don't allow events at same time and place

For example, Tom is signed up to do a head cook on 8/20 at 2:15pm at the TS CH. I just created a meal where I'm the head cook, and it's happening at the same time and place. The system saved it without complaint about this.
Originally created by Willie Northway at 2015-08-20 01:22, migrated from redmine-#2904

Tracker changed from Bug to Feature

Subject changed from Collision detection to Don't allow events at same time and place

By Tom Smyth at 2015-09-14 03:32

Status changed from New to Closed

Fixed as part of reservations
By Tom Smyth at 2016-05-14 05:58


foo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.85%. Comparing base (6b8f2b5) to head (cb3831a).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   79.23%   79.85%   +0.61%
==========================================
  Files          18       18
  Lines         260      268       +8
==========================================
+ Hits          206      214       +8
  Misses         54       54

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Limiter example?

I've played around with the Limiter, but can't seem to get it to do much. I'd be great to have an example of it's proper usage.

Sorry about this - there was a frankly stupendous amount of fail in the Limiter code which should now be fixed.  Usage should be pretty simple, and the defaults are fairly good as a standard - something like this should work fine now:
   var audiolet = new Audiolet();
   var synth = new MyVeryLoudSynth(audiolet);
   var threshold = 0.95, attack = 0.01, release = 0.4; // Default values, attack and release times given in seconds.
   var limiter = new Limiter(audiolet, threshold, attack, release);
   synth.connect(limiter);
   limiter.connect(audiolet.output);


Change Wallet Retry Text

The text for retrying payments in the wallet is confusing, and doesn't reflect what the user is actually doing. It should be improved by changing it to something like the following:
"Retry Payment" should be changed to "Bump Fee" or "Increase Fee".
"X* will be added to retry the payment" should be changed to "Add X* to the fee and rerun the transaction."

@morebrownies thoughts on the text?
@cpacia is the description above accurate as to what is actually happening?

Yeah I like:
Increase Fee
"Add X* to the fee and republish the transaction"

Is the transaction republished? Resubmitted? I'm not sure what the right word for resending a Bitcoin transaction is.

@hoffmabc @SamPatt what is the right word for submitting a transaction with a bumped fee? Republish, resend, resubmit, etc.?

Resubmitted I believe.


Normalize Lua coding style

PR #360 got out of hand and needed rebasing, so I'm splitting it up. This is most of the style related changes squashed into a few commits. Nothing in this PR should introduce any functional changes, but white space and coding conventions should be a little more consistent (at least for the bits of code I was touching working on the pushBack() thing).

This can be merged any time. The test shows as failing for the PR but that's only because of master being broken right now. These commits actually don't break anything as can been in this passing Travis test run for commit 288c5dc.

Thanks very much for this; looks great!


Evaluation is too slow

While testing my PR using the Coq Nix Toolbox on the Coq repo (https://github.com/coq/coq/pull/14435), @Alizter noticed that getting into nix-shell takes extremely long compared to master (it's close to a minute vs 4 seconds for him, and it is about 12 vs 3 seconds for me).
Using nix-shell --debug --run exit 2>&1 | ts '[%Y-%m-%d %H:%M:%S]' | xclip -selection clipboard, he was able to obtain a log with timings (https://ctxt.io/2/AAAQEsEJEw), from which we learn that most of the time is spent there:
[2022-10-04 16:53:13.782202] instantiated 'jsonAction' -> '/nix/store/lw4sm4gc14n88jza66f81wx2pzran7l4-jsonAction.drv'
[2022-10-04 16:54:03.336866] copied source '/home/ali/coq' -> '/nix/store/r8z94sfdklky20qiwsd1yp9zqmap88zn-coq'

So it looks like instantiating the jsonAction on every call to nix-shell (and every nix-build) is seriously impacting the performance of the Coq Nix Toolbox.
Could we find a way of not instantiating it or making it trivially faster?
What I'm considering is adding a gen-action ? false parameter to default.nix and changing the value of an attribute based on this.
@CohenCyril WDYT?

Actually, I realize that I've completely misread the above. Sorry. It is copying the repository to the store which takes so long!

FWIW, this is also what takes the longest on my computer, but just not as long (it might be due to the size of the repo, or to the type of hardware).
[2022-10-04 17:21:23] instantiated 'jsonAction' -> '/nix/store/lw4sm4gc14n88jza66f81wx2pzran7l4-jsonAction.drv'
[2022-10-04 17:21:31] copied source '/home/theo/git/coq' -> '/nix/store/1l9kgdk619ghb08z2rx0hhcblhmzg93y-coq'

I tried to fix the source filtering function by using another technique only to discover that my first filtering function was actually fine. It's just that during the evaluation of nix-shell we get something like:
copied source '/home/theo/git/coq' -> '/nix/store/kgzkcn8y3wmxcdw8jwqr58n6fx8lgrfj-coq'

even though the source that is used by the coq-full derivation is: /nix/store/8b1p4awf64r19lyplhlcilg3ddpkpgww-coq.
The former store path has copied everything included filtered out directories, while the latter has the filters applied correctly.
In the current Nix setup in the Coq repository (without the Toolbox), we don't have this issue that the source is copied to the store once without the filters (even when running nix-shell default.nix so that src is not set to null).

So indeed, the Coq Nix Toolbox needs to import the current directory as a source, and we cannot apply exactly the same filters (in particular, we cannot filter out the .nix repository). If we try to filter out the .git directory, it also leads to some error:
error: a string that refers to a store path cannot be appended to a path

       at /nix/store/0fhbpysgjrayi9nzsh3i4qngdm8a5dch-source/config-parser-1.0.0/normalize.nix:42:21:

           41|   src = config.src or
           42|     (if pathExists (/. + initial.src)
             |                     ^
           43|         -> pathExists (/. + initial.src + "/.git")
(use '--show-trace' to show detailed location information)

@CohenCyril Can you tell me what this was supposed to do:
https://github.com/coq-community/coq-nix-toolbox/blob/84cb9c4223db9a4e291fd8165f4bfdb22a6a8838/config-parser-1.0.0/normalize.nix#L41-L48
I guess it was precisely some attempt at doing some filtering? And thus, it cannot be composed with a call to filterSource. Maybe we should have some basic filtering predicate by default in the Toolbox and provide a way to extend them? Or what about just loading the .nix/ directory and nothing else as the source for the Toolbox's use?

I guess it was precisely some attempt at doing some filtering?

No this was an attempt to have shallow git clones to avoid time consuming source fetching when faced with potentially git repos.

And thus, it cannot be composed with a call to filterSource. Maybe we should have some basic filtering predicate by default in the Toolbox and provide a way to extend them? Or what about just loading the .nix/ directory and nothing else as the source for the Toolbox's use?

I prefer to be able to pass the a predicate... but, actually, I'd prefer the source filtering to be done by each derivation (and that hashes of the various sources take the filtering into account), so that for example changing .nix/* or README in many derivation does not affect the result of the build.

Since the Coq Nix Toolbox does need the .nix directory, but a standard derivation should filter it out from its sources, we obviously need two sources, one for the internal functions  of the Coq Nix Toolbox and one from the actual package. Would it work if the sources used by the Coq Nix Toolbox were limited to only the .nix directory?


Give opaque existential containers extra inhabitants.

We can use the extra inhabitants of the type metadata field as extra inhabitants of the entire
existential container, allowing Any? and similar types to be the same size as non-optional
existentials.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - ae4fd6b46b85bdc089bc6ccc746387d2bc6c0eae

Build failed
Swift Test OS X Platform
Git Sha - ae4fd6b46b85bdc089bc6ccc746387d2bc6c0eae

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - ae4fd6b46b85bdc089bc6ccc746387d2bc6c0eae

Build failed
Swift Test OS X Platform
Git Sha - ae4fd6b46b85bdc089bc6ccc746387d2bc6c0eae

@swift-ci Please test OS X

Build failed
Swift Test OS X Platform
Git Sha - b4abe8503a4b572ae4c29fb2b0712904c65c2dd2

@swift-ci Please clean test

Build failed
Swift Test OS X Platform
Git Sha - b4abe8503a4b572ae4c29fb2b0712904c65c2dd2

@swift-ci Please clean test OS X

Build failed
Swift Test Linux Platform
Git Sha - b4abe8503a4b572ae4c29fb2b0712904c65c2dd2

@swift-ci Please test


Installation clarification

Hi
I'm new to react-native and mobile development.
I'm trying to understand this Android  installation step:
buildscript {...}
allprojects {...}

/**
  + Project-wide Gradle configuration properties
  */
ext {
    compileSdkVersion   = 27
    targetSdkVersion    = 27
    buildToolsVersion   = "27.0.3"
}

what should I edit here?
I don't have:
buildscript {...}
allprojects {...}

Also, in IOS installation, where do I edit this alert:
$(PRODUCT_NAME) would like access to your photo gallery to change your profile picture

Hi
For iOS you have to add NSPhotoLibraryUsageDescription in your info.plist and you can write whatever you want for the description.


mingw and SSE/AVX

Hello
I am writing an application using  object detection from dlib.
It's not ready, but the part written is based mainly on the example train_object_detector.
It works as expected on linux (lubuntu 14.04, lubuntu 16.04, kubuntu 17.04).
But under Windows, using QT5.9 with mingw530_32 (which identifies itself as gcc 5.3.0), as soon as I set -march=native, or -march=sandybridge, or -msse2, the application crashes, currently at the second call of dlib::load_image, on windows7_64 on an I5-2500, and also on windows10_64 on an I5-7200U in release mode. The same code works in debug mode.
Also the example train_object_detector itself crashes when compiled under these conditions, using the same compiler and cmake-gui/cmake.
Has anybody used mingw with fhog training and SSE/AVX?

It's probably because thread support in mingw is wacked.  Try running it without threads and it should run fine.  Do this by setting the number of threads to 0 and you will see what I mean.  By default, mingw doens't support C++11 threads and there is all this nonsense on the internet about how to get it to work.  But it sure doesn't seem to work well even when you get a version of mingw that supposedly supports threads.

@pepeverde9 , i am using MinGW a lot (SSE2, AVX, AVX2) - all fine, but I am using x64 code. I am using all functions and training FHOG too. I had some problems with MinGW 32 bit a year ago, first was threads - but it was fixed when using SJLJ version of MinGW, the second problem is calling MinGW-compiled DLL from MSVC, it was solved with -mstackrealign flag  (the 6.3 compiler does not have this issue)
MinGW works much better in terms of performance for FHOG compared with MSVC, the other option is CLang, it works good too and compatible with MSVC libraries

Yeah, the issue seems to only happen in the 32bit version of mingw.  I tried 32bit SJLJ this morning and got the same error as @pepeverde9.

Closing this issue because we aren't able to reproduce it and the poster seems to have vanished.

I forgot about this thread, and used linux for the application for some time.
Then, when a LTS Qt version came out compiled with mingw64 7.3, I could build and run the program on windows without issues using that compiler.


fix(ant): revert breaking change on records for ANT

Readme should need an update as well.

:tada: This PR is included in version 2.5.0-alpha.14 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update cats-core, cats-effect, ... to 2.3.1

Updates

org.typelevel:cats-core
org.typelevel:cats-effect
org.typelevel:cats-effect-laws
org.typelevel:cats-laws

from 2.3.0 to 2.3.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

labels: library-update, semver-patch

To 0.21 with you!


Remove setters

Part of #2184
Remove setters from support radius and radius-core modules

Looks good. Could we perhaps use Throwables.propagate() for the above issues to be consistent? (and once we decide to move away from those calls, it will be easier to spot them all)

Removing the message? using just
Throwables.propagate(e);

Yeah that should work. e.getMessage() already has better the description and nothing we're removing here is all that helpful to begin with :)


training for waymo open dataset

Hi, congratulations for your great work!
There is one thing I wanna know is that why did you choose Nuscenes but not Waymo Open Dataset for experiments?
And have u trained on WOD before? How does it performs.

Hi, thanks for your interesting. We think that nuScenes is very suitable for multi-modality and DETR-based detector.
We want to develop a query-based temporal fusion method for LiDAR, Camera, and multi-modality DETR-based 3D detector. And the performance of DETR-based 3D detector is still inferior to center-based or two-stage 3D detector on WOD during this work. So, we chosen the well-known DETR-based 3D detector TransFusion and nuScenes dataset for experiments.
Due to limited resources before, we didn't spend a lot of time adjusting QTNet for WOD. But, we conducted some experiments on ConQueR with 20% sequence data, and observed about some improvements (about 2 mAP).

Hi, thanks for your interesting. We think that nuScenes is very suitable for multi-modality and DETR-based detector.
We want to develop a query-based temporal fusion method for LiDAR, Camera, and multi-modality DETR-based 3D detector. And the performance of DETR-based 3D detector is still inferior to center-based or two-stage 3D detector on WOD during this work. So, we chosen the well-known DETR-based 3D detector TransFusion and nuScenes dataset for experiments.
Due to limited resources before, we didn't spend a lot of time adjusting QTNet for WOD. But, we conducted some experiments on ConQueR with 20% sequence data, and observed some improvements (about 2 mAP).

I got it, thanks for your fast and detailed reply.


Issues when trying to contribute

I know how to listen on the DOM and therefore fix issue #2, but when loading the src locally I get Uncaught TypeError: Cannot read property 'nodeType' of nullwalk @ content_script.js:17.
Can you help me figure this out so that we can contribute to the extension as a community?
Cheers

I cannot replicate this error. Does it really say "nullwalk"? Google is not helping much on "nullwalk".

Must have been a collision of other extensions. Locally things are working now. Expect a PR with solution to #2 in the near future.
Nice project by the way. Cheers.

Sounds good, thanks.


Starting trace fails if iotrace module is loaded before that

Test scenario:

Install iotrace
modprobe iotrace
start tracing (e.g. iotrace -S -d /dev/nvme0n1)

Output after starting and finishing trace:
{
 "timestamp": "2020-02-18 00:31.539",
 "system": "iotrace",
 "severity": "Error",
 "trace": "Failed to open trace file: /proc/iotrace//trace_ring.0"
}
^C{
 "timestamp": "2020-02-18 00:31.544",
 "system": "iotrace",
 "severity": "Error",
 "trace": "Tracing not completed, trace path kernel/2020-02-18_00:31:25"
}

Without modprobe command starting succeeds properly.
OS: Ubuntu 18.04.3 LTS
kernel: 5.0.0-23-generic

It was a problem with a test, which uploaded kernel module from host to DUT. Kernels of both machines were different, and on DUT, we weren't able to load kernel module built on test controller OS.


Add compressor station

Description of the issue
Compressor stations are an important part of gas grids and are often included in energy systems modelling. However, these are not yet included in the OEO.
Ideas of solution
compressor station: A compressor station is an energy transformation unit that has a compressor to enable gas transport via a gas grid.
Axioms:

'has part' some 'compressor'
'part of' some 'gas grid'
'part of' some 'transport network'
'part of' 'CRF sector (IPCC 2006): pipeline transport'

compressor: A compressor is a pump that converts energy into kinetic or potential energy of a gaseous fluid.
gas turbine compressor station: A gas turbine compressor station is a compressor station that has a gas turbine for driving the compressor.

'has part' some 'gas turbine'
uses some gaseous combustion fuel

electric compressor station: An electric compressor station is a compressor station that has en elecrtric motor for driving the compressor.

'has part' some 'electric motor'
uses some 'gaseous combustion fuel'

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

'part of' 'CRF sector (IPCC 2006): pipeline transport'

Instead of 'compressor station' 'part of' 'CRF sector (IPCC 2006): pipeline transport' we could axiomatise the other way round:
'CRF sector (IPCC 2006): pipeline transport' 'is sector of' some 'compressor station'.
My preferred option is: introduce an inverse of is sector of. Something like included in sector: A relation that holds between a processes or material entities and a sector which indicates that the process or sector is included in the sector.
Then the axiom above could be expressed more precisely as: 'compressor station' 'included in sector' 'CRF sector (IPCC 2006): pipeline transport'

Everything except the relation to the sectors seems very trivial here. Thus I suggest the following:

Implement compressor station, gas turbine compressor station and electric compressor station now.
Make the relation between compressor station and the sectors part of issue #1333 or open a separate issue for that.

@stap-m : If you agree, I could implement the three classes very (minus the sector relation) shortly.


Roller shutter stop function not working

Hello,
I have 2 shutters, which are working perfectly with the Smart Life app, but not in Home as a homekit accessory.
I have added them and I can open/close them, but I cannot stop them in between these states. Also the status either showing "Opening..." or "Closing...".
I have googled it but just cannot seem to find a solution.
Any info needed please let me know, as I am not sure what to provide :)
THanks!

Stop functionality is supported by this plugin, however it seems not to be supported by HomeKit, please check out another HomeKit compatible app (such as the EVE home app) which does support this functionality.
The other bug is a known problem but I am consistently unable to reproduce this behavior on my own devices and therefore am unable to fix them sadly, PRs are very welcome!


Can't Hear Sound - Blaze_Shoot

Version:
0.7.4
Server Version:
1.8.8 spigot
If I play the Blaze_Shoot sound I can hear it in 1.8 but not on 1.9.
Ex as this: player.playEffect(player.getLocation(), Effect.BLAZE_SHOOT, 0);

Fixed next version #342


Update client-libraries.md : add python pykorm lib

Hi,
This small commit adds the pykorm python library which is meant to link kubernetes CRDs to its python model's counterpart.
I suppose it could interest some people,
Many thanks and cheers
Frank

Indeed, sorry for the delay :-)

Page preview:
https://deploy-preview-25644--kubernetes-io-master-staging.netlify.app/docs/reference/using-api/client-libraries/#community-maintained-client-libraries

/lgtm

/approve


Need fromPromise

An essential feature is being able to convert promises to streams.

That’s implemented in the wonkaJS part of the library 🙌 https://github.com/kitten/wonka/blob/master/src/wonkaJs.re#L58


RPM rkt/before-remove error: detected active mounts in [/var/lib/rkt] if /var/lib/rkt on separate partition

Using the official RPM for rkt 1.26, upgrading from 1.25 fails, saying
rkt/before-remove error: detected active mounts in [/var/lib/rkt].

The reason for this is my server has /var/lib/rkt on a separate partition.
The problem is two lines like this in the RPM scriptlets:
if [ -n "$(grep "/var/lib/rkt" /proc/mounts)" ]; then

One solution would be to append a slash, like this:
if [ -n "$(grep "/var/lib/rkt/" /proc/mounts)" ]; then

But I think a better solution would be to use a longer path, in case someone chooses to make e.g. /var/lib/rkt/cas on a separate partition, so like this:
if [ -n "$(grep "/var/lib/rkt/pods/run/" /proc/mounts)" ]; then

I didn't find the RPM spec file in the github repo, or I would have contributed a pull request to fix this.
A work-around for completing the upgrade despite the broken scriptlet is as follows:
# umount /var/lib/rkt
# yum remove rkt
# mkdir /var/lib/rkt
# mount /var/lib/rkt
# yum install rkt

I'm not personally using RPMs, but I think I agree with your assessment and proposed fix. Packaging related material is under scripts/pkg, please feel free to amend it and test the result.
/cc @squeed


Fixes error obtaining FIPS config

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] Optimization
[ ] Documentation Update

Description

Fixes error obtaining FIPS config
Fixes error on malformed JSON to index

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Tested -- using a cluster without ovnk -- lgtm
jtaleric at polaris in ~/code/plow/utils on fix-bug-ip-sec▲ $ export PROW_JOB_ID=rook-bs
jtaleric at polaris in ~/code/plow/utils on fix-bug-ip-sec▲ $ export ES_SERVER=https://search-perfscale-dev-chmf5l4sh66lvxbnadi4bznl3a.us-west-2.es.amazonaws.com:443
jtaleric at polaris in ~/code/plow/utils on fix-bug-ip-sec▲ $ export UUID=ROOKBS
jtaleric at polaris in ~/code/plow/utils on fix-bug-ip-sec▲ $ ./index.sh
Error from server (NotFound): namespaces "openshift-ovn-kubernetes" not found
{
        "ciSystem":"PROW",
        "uuid":"ROOKBS",
        "releaseStream":"4.14.5",
        "platform":"AWS",
        "clusterType":"self-managed",
        "benchmark":"",
        "masterNodesCount":3,
        "workerNodesCount":4,
        "infraNodesCount":0,
        "masterNodesType":"m6i.xlarge",
        "workerNodesType":"m5.2xlarge",
        "infraNodesType":"",
        "totalNodesCount":7,
        "clusterName":"cilium-fun-dxtx2",
        "ocpVersion":"4.14.5",
        "networkType":"Cilium",
        "buildTag":"",
        "jobStatus":"",
        "buildUrl":"https://prow.ci.openshift.org/view/gs/origin-ci-test/logs//",
        "upstreamJob":"",
        "upstreamJobBuild":"rook-bs",
        "executionDate":"",
        "jobDuration":"0",
        "startDate":"",
        "endDate":"",
        "timestamp":"",
        "ipsec":"false",
        "fips":"false",
        "encrypted":"false",
        "encryptionType":"",
        "publish":"External",
        "computeArch":"amd64",
        "controlPlaneArch":"amd64"
        }
{"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"failed to parse field [startDate] of type [date] in document with id '/rook-bs//ROOKBS'. Preview of field's value: ''"}],"type":"mapper_parsing_exception","reason":"failed to parse field [startDate] of type [date] in document with id '/rook-bs//ROOKBS'. Preview of field's value: ''","caused_by":{"type":"illegal_argument_exception","reason":"cannot parse empty date"}},"status":400}jtaleric at polaris in ~/code/plow/utils on fix-bug-ip-sec▲ $ echo $?
0


test: add tests for transform

:tada: This issue has been resolved in v4.1.4
If you appreciate this project, please consider supporting this project by sponsoring :heart: :pray:


Ingestion - Redshift varbyte & time

Affected module
Ingestion
Describe the bug
/Users/pmbrull/venv/lib/python3.9/site-packages/metadata/ingestion/source/redshift.py:120: SAWarning: Did not recognize type 'binary varying' of column 'my_varbyte'
  column_info = super(RedshiftDialectMixin, self)._get_column_info(

When ingesting redshift data of type varbinary we get the error above and the column gets mapped wrongly to varchar.
Also, although there is no error in the logs, the TIME type gets ingested as varchar as well.
To Reproduce
Reproduce this by running the ingestion against our DEV redshift and check the table public.type_test.
Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@ayush-shah can we fix this and if needed the varbyte into types on the server side


Rendering: improves repr of Python types

Makes it more robust against trying to render regular Python types.
For example if you fill in a table by matrix that has integers in it.

Thank you a lot Bernhard!

I'm worried about the try / catch block. Catching all exceptions and silently continuing gives the code a bad smell

@nzjrs you are right, this should have been an except AttributeError: instead.


[build.ps1] ensure the compiler is using UTF-8

I am (again) proposing to add this flag because anyone who's not using 65001 code page could meet unexpected situations without it. Although it should have no effect with code page 65001 or clang-cl, I added a conditional check to eliminate the flag when unncessary.

Do we have a guarantee that the code is stored in UTF-8 encoding? If we can get that put into .gitattributes as the guaranteed encoding, I don't think that this should be too big of a deal. Without the attributes, this could mis-parse the code.

AFAIK all the current dependencies were encoded in UTF-8. Given the nature that Git only supports ASCII’s supersets without explicit working-tree-encoding in .gitattributes, I don’t think there’s any reason to do that for C/C++ source files.
BTW clang-cl.exe is implicitly /utf-8 and doesn’t care about code pages. If a source library supports clang-cl, it should not be in other encodings. Allowing other encoding could cause unnecessary confusion.

Ping @compnerd or anyone else who's familiar with Windows code pages and MSVC toolset


doc: the namespace is wrong when validating cilium installation with Azure CNI

In https://docs.cilium.io/en/v1.6/gettingstarted/cni-chaining-azure-cni/#validate-the-installation, the namespace should be cilium instead of kube-system, because the chaining.yaml and the cilium release are in the namespace cilium.
https://docs.cilium.io/en/v1.6/gettingstarted/cni-chaining-aws-cni/ shares the validation step, whose namespace is kube-system.

Thanks for reporting @bingosummer ! Would you like to send a small PR for updating the ...

https://docs.cilium.io/en/v1.6/gettingstarted/cni-chaining-azure-cni/
https://docs.cilium.io/en/v1.6/gettingstarted/k8s-install-aks/

... to use kubectl -n cilium get pods in the validation step for both?


Broken "retry_policy" parameter in pub/sub module

Hi,
I open this issue because I found a small bug in the latest Fabric release (27.0.0). I'm trying to use the recently implemented feature that allows you to set backoff times for the "retry_policy" of pub/sub subscriptions.
My code for a topic is the following (I'm only reporting the subscription part):
subscriptions = {
  "uni.customers.hyb.updateCustomers.sub" = {
    labels                     = {}
    ack_deadline_seconds       = 600
    retain_acked_messages      = false
    message_retention_duration = "604800s"
    expiration_policy_ttl      = ""
    filter                     = ""
    dead_letter_policy = {
      topic                 = "${module.uni_mulesoft_dlq_topic_01.id}"
      max_delivery_attempts = 10
    }
    retry_policy = {
      minimum_backoff = 600
      maximum_backoff = 600
    }
  }
}

Which from the fabric/terraform point of view does not cause any problems and which leads to a correct plan that implements the retry policy:

However, when I proceed with the apply command I get the following error:

The problem seems to concern the format of the backoff duration in the API request, in fact the fabric requires that parameter to be a number:

while the google API expects a string ending with "s" to indicate the seconds:

I'm currently using the following configuration of terraform and Google provider:

From my local tests, to fix this problem it is sufficient to change "optional(number)" to "optional(string)" in the variable definition of the pubsub module (lines 116 and 117).
Regards,
Francesco

Now that you pointed it out I also think that keeping the type at "number" and appending "s" is better for type checking. Furthermore, duration can only be expressed in seconds so we would also avoid any confusion on the unit of measurement of the parameter.

@francesco-pavan-huware can you try #1744?

@juliocc I confirm that the apply now works correctly. Thank you very much!


[FLINK-28395][Connectors/ElasticSearch] create table and await for su…

What is the purpose of the change
Fix test case error  about create table/query document in elasticsearch 6
Brief change log

add await api on creating table , make sure create table happen before querying document

Verifying this change
I have run test case several times and get passed result
(Please pick either of the following options)
none
Does this pull request potentially affect one of the following parts:
none
Documentation
none

@HuangXingBo I open a new branch

Replaced by#20318  which is already merged ,so close  this pr.

Needs to be moved to https://github.com/apache/flink-connector-elasticsearch

Needs to be moved to https://github.com/apache/flink-connector-elasticsearch

Of course


[ERROR] flutter create --template=plugin

If you do flutter create --template=plugin myplugin
and then try to run the example with flutter run, the compilation fails as import androidx.annotation.NonNull; can't be imported.
So i think that --androidx should be added by default with flutter create

Hi @BadTasTe-
can you please provide your flutter doctor -v?
Thank you

hi @iapicca,
thank you for the answer, here is my flutter doctor:
`flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G103, locale ca-ES)
    • Flutter version 1.12.13+hotfix.5 at /Users/arnaud/dev/flutter
    • Framework revision 27321ebbad (5 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
    • Android SDK at /Users/arnaud/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.0
    • ANDROID_HOME = /Users/arnaud/Library/Android/sdk
    • Java binary at: /Users/arnaud/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5900203/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Users/arnaud/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5900203/Android Studio.app/Contents
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.41.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.`

androidx is used by default as of 1.10.6 with https://github.com/flutter/flutter/pull/40925, and you're past that on v1.12.13+hotfix.5.
I just successfully flutter create --template=plugin myplugin and flutter run the example and didn't see the import issue.
Am I missing steps to reproduce?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.


Add access token cnf public key validation in PoP token verifier

This check ensures that the user who requested the access token is the same user who created the PoP token.
Also added a few missed error cases and tests to the PoP token verifier.

i actually not quite follow how this change ensures that the user who requested the access token is the same user who created the PoP token

i actually not quite follow how this change ensures that the user who requested the access token is the same user who created the PoP token

The user who created the inner access token gave the PoP token public key to AAD, and the returned access token contains the public key info in the cnf claim.
The PoP token wraps the access token, includes the same public key, and is signed by the PoP token private key. The PoP token signature can be verified using the included public key, and the public key in the PoP token claims can be checked against the inner access token's cnf claim.

@@tamalsaha I plan to cut a release. Is there any instruction?


Raw data tab

It would be nice to have the opportunity to open a tab with the raw data of the database in table format. This could be a simple possibility to modify data.

The last commit should actually refer to https://github.com/DLR-AE/WiVis/issues/9.


[SQLite] Multiplying 2 numbers without CAST inside GROUP BY results in over 220x slower compilation

UPDATE: It was not the Blobs causing the issues - it was the lack of CAST and the GROUP BY
I mistakenly attempted to multiply two blobs in SQLite and the compilation times shot up from 0.36s to 1m20s (over 220x slower).
I'm not sure what expected behaviour for multiplying two blobs is - an error maybe - but these compile times are quite bizarre.

                GROUP BY parts.id
            "#,
            part_id,
        )

Output without the blob multiplication (above commented out)
Finished dev [unoptimized + debuginfo] target(s) in 0.36s
Output with the blob multiplication
Finished dev [unoptimized + debuginfo] target(s) in 1m 20s

Update: The problem persisted after switching to non-blobs. My code now works but I'm no longer clear on what caused the compile times to balloon up or how to reproduce the problem.
Working Code (with INT types in the schema)
                SELECT
                    CAST(parts.quantity * packages.quantity AS INT) AS total
                FROM parts
                INNER JOIN packages ON packages.id = parts.package_id
                WHERE parts.id = ?

Update: The problem persisted after switching to non-blobs. My code now works but I'm no longer clear on what caused the compile times to balloon up or how to reproduce the problem.
Working Code (with INT types in the schema)
                SELECT
                    CAST(parts.quantity * packages.quantity AS INT) AS total
                FROM parts
                INNER JOIN packages ON packages.id = parts.package_id
                WHERE parts.id = ?

I've found the same problem with a couple more queries and it looks like the CAST(_ AS INT) is the solution. Any idea why a missing cast would cause a compiler performance degradation?

I've found the same problem with a couple more queries and it looks like the CAST(_ AS INT) is the solution. Any idea why a missing cast would cause a compiler performance degradation?

A LEFT JOIN just triggered the same slow compile time as well. Very strange.

A LEFT JOIN just triggered the same slow compile time as well. Very strange.

@D1plo1d If you could please run EXPLAIN SELECT ... and upload the results that would help us debug the performance problem of the inspection.

@D1plo1d If you could please run EXPLAIN SELECT ... and upload the results that would help us debug the performance problem of the inspection.

@mehcode Done - I made some changes in debugging but the query in this explain is currently causing the same compile time issue:
SQLite version 3.31.1 2020-01-27 19:55:54
Enter ".help" for usage hints.
sqlite> EXPLAIN
   ...>                 SELECT
   ...>                     COUNT(tasks.id) AS printed,
   ...>                     CAST(parts.quantity * packages.quantity AS INT) AS total
   ...>                 FROM parts
   ...>                 INNER JOIN tasks ON tasks.part_id = parts.id
   ...>                 INNER JOIN packages ON packages.id = parts.package_id
   ...>                 WHERE parts.id = ?
   ...>                 GROUP BY parts.id
   ...> ;
addr  opcode         p1    p2    p3    p4             p5  comment
----  -------------  ----  ----  ----  -------------  --  -------------
0     Init           0     55    0                    00  Start at 55
1     Noop           3     4     0                    00
2     Integer        0     6     0                    00  r[6]=0; clear abort flag
3     Null           0     9     9                    00  r[9..9]=NULL
4     Gosub          8     51    0                    00
5     OpenRead       0     22    0     4              00  root=22 iDb=0; parts
6     OpenRead       4     23    0     k(1,)          02  root=23 iDb=0; sqlite_autoindex_parts_1
7     OpenRead       2     20    0     4              00  root=20 iDb=0; packages
8     OpenRead       5     21    0     k(1,)          02  root=21 iDb=0; sqlite_autoindex_packages_1
9     OpenRead       1     16    0     4              00  root=16 iDb=0; tasks
10    Variable       1     11    0                    00  r[11]=parameter(1,)
11    IsNull         11    39    0                    00  if r[11]==NULL goto 39
12    Affinity       11    1     0     B              00  affinity(r[11])
13    SeekGE         4     39    11    1              00  key=r[11]
14    IdxGT          4     39    11    1              00  key=r[11]
15    DeferredSeek   4     0     0                    00  Move 0 to 4.rowid if needed
16    Column         0     2     12                   00  r[12]=parts.package_id
17    SeekGE         5     39    12    1              00  key=r[12]
18    IdxGT          5     39    12    1              00  key=r[12]
19    DeferredSeek   5     0     2                    00  Move 2 to 5.rowid if needed
20    Rewind         1     39    0                    00
21      Column         1     3     13                   00  r[13]=tasks.part_id
22      Variable       1     14    0                    00  r[14]=parameter(1,)
23      Affinity       14    1     0     B              00  affinity(r[14])
24      Ne             14    38    13    (BINARY)       51  if r[13]!=r[14] goto 38
25      Column         4     0     10                   00  r[10]=parts.id
26      Compare        9     10    1     k(1,B)         00  r[9] <-> r[10]
27      Jump           28    32    28                   00
28      Move           10    9     1                    00  r[9]=r[10]
29      Gosub          7     43    0                    00  output one row
30      IfPos          6     54    0                    00  if r[6]>0 then r[6]-=0, goto 54; check abort flag
31      Gosub          8     51    0                    00  reset accumulator
32      Column         1     0     14                   00  r[14]=tasks.id
33      AggStep        0     14    1     count(1)       01  accum=r[1] step(r[14])
34      If             5     37    0                    00
35      Column         0     3     2                    00  r[2]=parts.quantity
36      Column         2     3     3                    00  r[3]=packages.quantity
37      Integer        1     5     0                    00  r[5]=1; indicate data in accumulator
38    Next           1     21    0                    01
39    Gosub          7     43    0                    00  output final row
40    Goto           0     54    0                    00
41    Integer        1     6     0                    00  r[6]=1; set abort flag
42    Return         7     0     0                    00
43    IfPos          5     45    0                    00  if r[5]>0 then r[5]-=0, goto 45; Groupby result generator entry point
44    Return         7     0     0                    00
45    AggFinal       1     1     0     count(1)       00  accum=r[1] N=1
46    Copy           1     15    0                    00  r[15]=r[1]
47    Multiply       3     2     16                   00  r[16]=r[3]*r[2]
48    Cast           16    68    0                    00  affinity(r[16])
49    ResultRow      15    2     0                    00  output=r[15..16]
50    Return         7     0     0                    00  end groupby result generator
51    Null           0     1     4                    00  r[1..4]=NULL
52    Integer        0     5     0                    00  r[5]=0; indicate accumulator empty
53    Return         8     0     0                    00
54    Halt           0     0     0                    00
55    Transaction    0     0     13    0              01  usesStmtJournal=0
56    Goto           0     1     0                    00
sqlite>

@mehcode Done - I made some changes in debugging but the query in this explain is currently causing the same compile time issue:
SQLite version 3.31.1 2020-01-27 19:55:54
Enter ".help" for usage hints.
sqlite> EXPLAIN
   ...>                 SELECT
   ...>                     COUNT(tasks.id) AS printed,
   ...>                     CAST(parts.quantity * packages.quantity AS INT) AS total
   ...>                 FROM parts
   ...>                 INNER JOIN tasks ON tasks.part_id = parts.id
   ...>                 INNER JOIN packages ON packages.id = parts.package_id
   ...>                 WHERE parts.id = ?
   ...>                 GROUP BY parts.id
   ...> ;
addr  opcode         p1    p2    p3    p4             p5  comment
----  -------------  ----  ----  ----  -------------  --  -------------
0     Init           0     55    0                    00  Start at 55
1     Noop           3     4     0                    00
2     Integer        0     6     0                    00  r[6]=0; clear abort flag
3     Null           0     9     9                    00  r[9..9]=NULL
4     Gosub          8     51    0                    00
5     OpenRead       0     22    0     4              00  root=22 iDb=0; parts
6     OpenRead       4     23    0     k(1,)          02  root=23 iDb=0; sqlite_autoindex_parts_1
7     OpenRead       2     20    0     4              00  root=20 iDb=0; packages
8     OpenRead       5     21    0     k(1,)          02  root=21 iDb=0; sqlite_autoindex_packages_1
9     OpenRead       1     16    0     4              00  root=16 iDb=0; tasks
10    Variable       1     11    0                    00  r[11]=parameter(1,)
11    IsNull         11    39    0                    00  if r[11]==NULL goto 39
12    Affinity       11    1     0     B              00  affinity(r[11])
13    SeekGE         4     39    11    1              00  key=r[11]
14    IdxGT          4     39    11    1              00  key=r[11]
15    DeferredSeek   4     0     0                    00  Move 0 to 4.rowid if needed
16    Column         0     2     12                   00  r[12]=parts.package_id
17    SeekGE         5     39    12    1              00  key=r[12]
18    IdxGT          5     39    12    1              00  key=r[12]
19    DeferredSeek   5     0     2                    00  Move 2 to 5.rowid if needed
20    Rewind         1     39    0                    00
21      Column         1     3     13                   00  r[13]=tasks.part_id
22      Variable       1     14    0                    00  r[14]=parameter(1,)
23      Affinity       14    1     0     B              00  affinity(r[14])
24      Ne             14    38    13    (BINARY)       51  if r[13]!=r[14] goto 38
25      Column         4     0     10                   00  r[10]=parts.id
26      Compare        9     10    1     k(1,B)         00  r[9] <-> r[10]
27      Jump           28    32    28                   00
28      Move           10    9     1                    00  r[9]=r[10]
29      Gosub          7     43    0                    00  output one row
30      IfPos          6     54    0                    00  if r[6]>0 then r[6]-=0, goto 54; check abort flag
31      Gosub          8     51    0                    00  reset accumulator
32      Column         1     0     14                   00  r[14]=tasks.id
33      AggStep        0     14    1     count(1)       01  accum=r[1] step(r[14])
34      If             5     37    0                    00
35      Column         0     3     2                    00  r[2]=parts.quantity
36      Column         2     3     3                    00  r[3]=packages.quantity
37      Integer        1     5     0                    00  r[5]=1; indicate data in accumulator
38    Next           1     21    0                    01
39    Gosub          7     43    0                    00  output final row
40    Goto           0     54    0                    00
41    Integer        1     6     0                    00  r[6]=1; set abort flag
42    Return         7     0     0                    00
43    IfPos          5     45    0                    00  if r[5]>0 then r[5]-=0, goto 45; Groupby result generator entry point
44    Return         7     0     0                    00
45    AggFinal       1     1     0     count(1)       00  accum=r[1] N=1
46    Copy           1     15    0                    00  r[15]=r[1]
47    Multiply       3     2     16                   00  r[16]=r[3]*r[2]
48    Cast           16    68    0                    00  affinity(r[16])
49    ResultRow      15    2     0                    00  output=r[15..16]
50    Return         7     0     0                    00  end groupby result generator
51    Null           0     1     4                    00  r[1..4]=NULL
52    Integer        0     5     0                    00  r[5]=0; indicate accumulator empty
53    Return         8     0     0                    00
54    Halt           0     0     0                    00
55    Transaction    0     0     13    0              01  usesStmtJournal=0
56    Goto           0     1     0                    00
sqlite>

Possibly a duplicate of #981 ?

Possibly a duplicate of #981 ?


invariants, checks

Hi,
just comming to java from the Eiffel world, and trying valid4j.
Did U thought about invariants? somebody? is there a way to call at least invariants on post conditions? dont know if there is a way to call a function after all functions from a class in java... maybe also poor perfomances while the compiler doesnt do that.
What about disabling assertions? not documented or did I miss that?
Was wondering also and could be into the doc too, how about performances if we disable assertions, are they evaluated anyway?
And checks?

Hi, thanks for your question!
You can customise the behaviour via following the instructions here: https://github.com/valid4j/valid4j/blob/master/src/main/java/org/valid4j/provider/AssertiveInstance.java#L19-L24
If you specify your conditions using hamcrest-matchers (instead of boolean expressions), the hamcrest-matchers won't execute it's matching function if you disable assertions, i.e they would not be evaluated. But obviously, the matchers themselves would still be instantiated regardless of evaluation, and that could possibly be performance costly.
For more info have a look at the (arguably very brief) web-site: http://www.valid4j.org/


Guards

You can ignore the previous pull request, better place of the guards on the phrase level.
Only two failed test cases left

Nice work 👍

Need to have another look at those guards, I am not sure it works the way I
thought it should :)
On Thu, Feb 4, 2016 at 10:34 AM Jeroen Rosenberg<EMAIL_ADDRESS>wrote:

Nice work 👍
—
Reply to this email directly or view it on GitHub
https://github.com/jeroenr/gnip-rule-parser/pull/3#issuecomment-179731767
.


Scroll methods unexpected behavior

The problem
SelenideElement methods for scrolling to element (scrollIntoView, scrollTo) instead of scrolling to element as expected only "jerk" the scrollbar two times by couple pixels and ends the action resulting in failing tests as following conditions are able to be fulfilled.
Details
I have recently again started working on my company FE project and after updating both Selenide and Chrome (I use portable Chrome for test, in case its relevant) to latest, I started observing that my tests fail due to element not being visible. This is caused by this weird behavior where it doesnt scroll/drag the scrollbar properly and instead it just pulls it a little bit down couple pixels.
Tell us about your environment

Selenide Version:  7.4.3
Chrome\Firefox\IE Version:  Chrome for Test 129.0.6668.58 (r1343869) *
Browser Driver Version: auto-managed
Selenide-Appium Version: none
IOS\Android\WEB version: none
Selenium Version: whatever is baked into Selenide release
OS Version: Win 11

* https://googlechromelabs.github.io/chrome-for-testing/#stable

Sorry for spam, seems to be fixed now. App has lot of shadow doms and it seems that Xpath selector wasnt working as intended which caused issues for scrolling.

@ASTRO-CZ I have no idea how to reproduce this issue... Nobody knows.
If you want the problem to be fixed, describe how can other reproduce it.

@asolntsev hello and thanks for answer, normally I would provide more information, but I am not sure how much I can share without causing potential security incident at my work.  I will update the topic once I figure out what all can be posted publicly

@asolntsev I'm having the same problem and I want to share some information that may help solve this issue.
 I noticed the test worked three times in a row before the pixel jerking started again. I've also tried scrollIntoView(), executeScript("arguments[0].scrollIntoView(true);", selenideElement), but the behaviour remains inconsistent.
I hope this can help.

@MatteoPalese Sorry, but it can help only if we get a reproducible example. ¯¯_(ツ)_/¯¯

Feel free to reopen the issue if we get info how to reproduce it.


Disable SSL validation

Hi,
I am trying to create a wiki in an azure DevOps project but getting an error regarding SSL validation, I am wondering how can I disable SSL validation for just testing purpose.
Code
from azure.devops.connection import Connection
from msrest.authentication import BasicAuthentication

# Fill in with your personal access token and org URL
personal_access_token = 'YOURPAT'
organization_url = 'https://dev.azure.com/YOURORG'

# Create a connection to the org
credentials = BasicAuthentication('', personal_access_token)
connection = Connection(base_url=organization_url, creds=credentials)

# Get a client (the "core" client provides access to projects, teams, etc)
core_client = connection.clients.get_core_client()
wiki_client = connection.clients.get_wiki_client()

wiki_client.create_or_update_page(parameters={"content": "ENTER_CONTENT HERE", "id":1}, project="PROJECT_ID", wiki_identifier="WIKI_NAME", path="/page1", version=None)

Error
msrest.exception.ClientRequestError: Error occured in request., SSLError: HTTPSCOnnectionPool(host="dev.azure.com", port=443): Max retries exceeded with url : /_apis (Caused by SSLError(SSLCertVerficationError(1. '[SSl:CERTIFICATE_VERIFY_FAILED']) certificate verify failed: self signed certificate in certificate chain (_ssl.c:1100)')))

How can this issue be resolved?

msrest linked issue.

@tedchamb kindly have a look at this issue

See if this helps:
https://github.com/Azure/azure-devops-cli-extension/issues/76

thank you.


FE: Environment Set-up

Timeline: Week One
Team: @firstus @Alade Faruk

[x] Create react app
[x] Set-up React/Redux File structure
[x] Set-up Test Env/File.

This has been completed


Add ObjectStore::append

Which issue does this PR close?

Part of #3790
Rationale for this change

Adds an append API to allow for appending to files where supported
What changes are included in this PR?

Are there any user-facing changes?

FYI @metesynnada @ozankabak  @alamb

I agree with the API design, I made a POC on https://github.com/synnada-ai/arrow-rs/pull/4.

LGTM, thanks Raphael 👍

Ok - I'll get this in

I made a POC on https://github.com/synnada-ai/arrow-rs/pull/4

Looks good from a quick look, if you would like to get it polished up and raise a PR here I'll give a more in-depth review


ON-14865: Resolve preflight failures and errors

WIP on addressing the "HasLicense" and "RunAsNonRoot" failures for the Device Plugin and "HasLicense", "HasRequiredLabel", "BasedOnUbi" failures and "HasNoProhibitedPackages" error for the Controller images.
Also, want to piggy-back a tiny ContainerFileNotice fix in this "cleanup" PR.

Yay, the latest revision has passed all checks, but I need to rebase and carry on with fixes.

As-is, PR addresses preflight failures and errors identified by the quay.io/opdev/preflight:1.7.0 suite as outlined in the description.
Additionally, it addresses some ghcr.io/super-linter/super-linter:slim-v5.3.1 issues, but not all: Golang false positives and complaints about ContainerFileNotice are still there.
Pending work:

Test if the runtime is still functional in the cluster after changing the base image and user.
Rebase and remove Peter's patch that adds actions.


Feature/create new wallet

Summary
Done layout, logic for Create new wallet
Checklist (If you won't pass this checklist please comment why)

[x] I removed all commented or unnecessary code.
[x] Provide the screenshots due to UI changed or bug fixed
[x] My code has covered these test cases (please list down your tested cases):

Layout Recovery Phrase done with example Phrase.json
Choose random 8 words to select from list Phrase and validate words was checked in Let’s double check it screen.

@gaupoit hi, please review this PR as soon as possible. Thanks

hi @ThanhNguyen140797 , please merge back to develop branch with these changes (https://github.com/CasperDash/casperdash-mobile-wallet/pull/10). Now you can use our casper-storage to generate the mnemonic
import { KeyFactory } from ‘casper-storage’;
const mnemonic = KeyFactory.getInstance().generate();

hi @ThanhNguyen140797 , please merge back to develop branch with these changes (#10). Now you can use our casper-storage to generate the mnemonic
import { KeyFactory } from ‘casper-storage’;
const mnemonic = KeyFactory.getInstance().generate();

ok, thanks

hi @ThanhNguyen140797 , please merge back to develop branch with these changes (#10). Now you can use our casper-storage to generate the mnemonic
import { KeyFactory } from ‘casper-storage’;
const mnemonic = KeyFactory.getInstance().generate();

I got an issue after merge dev. Please check this issue, thanks. @gaupoit

Sorry about that. It has problems on iOS (https://github.com/polkadot-js/common/issues/1321 ). By default, react-native using @babel/plugin-transform-exponentiation-operator to transform exponentiation operator ** to Math.pow, which doesn't support BigInt. We are finding the solution and keep you update by 2night. Thanks for your patient.

Hi, @djhahe @gaupoit please review my code. Thanks


Support for multiple certs for same IdP?

Any way to have IdP with multiple certs for verifying responses from the IdP? We need to be able to support two IdP certificates during a rollover/transition period when an IdP wishes to change their certificate.

Currently no support for multiple certs, would welcome a PR for this though!

Can the pr-welcome tag be added to this then?

What method would we like to use to configure such a thing? We need to determine how the configuration will work and where we might actually do the check and how. Would we have a primary/secondary cert and fail-over, or would we have a cert ID and another setting that dictates which cert to use before trying others?

BTW, the documentation states that you can already support multiple IdP certs for when they roll their certificate.
If the Identity Provider has multiple signing certificates that are valid (such as during the rolling from an old key to a new key and responses signed with either key are valid) then the cert configuration key can be an array:

    cert: [ 'MIICizCCAfQCCQCY8tKaMc0BMjANBgkqh ... W==', 'MIIEOTCCAyGgAwIBAgIJAKZgJdKdCdL6M ... g=' ]

What we really need is something similar for when the SP needs to roll it's certificate so that the SP doesn't go offline during re-federation with the IdP


datetime.datetime doesn't exist

https://github.com/porcej/njord/blob/f2d9c38c44e0dea3862872eabe7636f790b2b3fe/njord.py#L86
https://github.com/porcej/njord/blob/f2d9c38c44e0dea3862872eabe7636f790b2b3fe/njord.py#L95
AttributeError: type object 'datetime.datetime' has no attribute 'datetime'

Closed by 3A9bbf6
/

Closed by 3A9bbf6


As a potential user, I want to be able to use cloud.gov immediately

Signing up for a sandbox account currently requires an email, and human intervention.
https://cloud.gov/docs/help/#i-m-interested-in-using-cloud-gov
It would smooth the process for users to be able to simply enter and confirm their .gov/.mil email address, and have an account created automatically. In other words, potential users should be able to send themselves an invitation.
The Migration team may do a spike on this sooner than later, as it will smooth the process of getting people out of the sandboxes in East/West and into GovCloud. Adding to that Epic for that reason.

Notes from discussion with @jcscottiii:

Will likely add to https://github.com/18F/cg-uaa-extras
Need this page/box to be accessible without being signed in
Do we need the government warning message when visiting this page?

Thanks for asking! From our compliance perspective, the relevant requirement is AC-8, which says: "Displays to users [our warning] before granting access to the system". If the person is simply signing up for a self-invitation with this tool, they'll get the warning later when they first log into the system (the first time they actually get access to anything) - so this invitation tool doesn't need to provide an additional warning.
From a user-centered perspective, we should make sure people are adequately informed that this is a monitored system before they invite themselves. We could handle that by adding a little info from our warning to https://cloud.gov/docs/getting-started/accounts/#use-your-account-responsibly and then linking to that from the self-invitation page.

Basically we just need a slightly modified version of the invite application at an unprotected URL where it says "sorry, only .gov and .mil accounts can be created now" if you enter something else; otherwise it basically functions identically.
My feeling here is that it's something that could even be posted to via the form at the bottom of https://cloud.gov... We already have the "enter your e-mail here to get notice about cloud.gov availability" form without any compliance turbulence, and we could would look something like that.
Note: The actual provisioning/login flow is down to which IdP you're using, and is a separate problem. (We could even expose this "invite me" functionality right now so long as it was only non-sorry to GSA/EPA/FDIC domains... The idp.cloud.gov IdP won't be ready for use by other .gov and .mil users for a while yet.)

I cleaned up the original post to be more direct, though I left Aidan's original text for reference.

@afeld do you mind if we deprecate this issue in favor of the original/clean version at https://github.com/18F/cg-product/issues/78 ?


webpackJsonp is not defined

Uncaught ReferenceError: webpackJsonp is not defined and the error can block my project
But when I refresh the browser again，the error disappear

Hi @jasmineY . If you still have this issue, Please provide more details about which version of nuxt and what template using and possibly sharing your project and reopen.

I have this issue when I launch it from a linux production environment under an http server.
Some chunks of my js files are missing.

this may be related:
https://github.com/webpack/webpack/issues/5002#issuecomment-306280559

and this is quite related:
https://stackoverflow.com/questions/48736923/errors-when-publishing-my-nuxtjs-website-on-ssr-mode

I'm getting this error now, launching in an environment were I cannot specify the cache of the HTTP server so easily. webpackJsonp is not defined because manifest file is not being loaded. And in my case it had to do with https://github.com/nuxt/nuxt.js/issues/574 app bootstrap JS files hashes not being updated. My guess is server cache.
As a workaround I was setting the same hashes (hard-coded) to the app, vendor and manifest files. But, for sure, is not a definitive solution... Maybe @pi0 can expand the reasons.

In my case, restarting PM2 and Nginx did it.

@Erigers what I ended up doing:

completely removing the old build from from PM2 (pm2 delete )
make a new build
starting it again on PM2 (for me, pm2 start npm --name "webapp" -- start)
setting up PM2 to boot on server restart (pm2 save & pm2 startup systemd)
Restart Nginx

Following code updates didn't throw this issue anymore. A hassle, but for now, t'works.


Memory creation fails when using Milvus Vector DB

Installation Method
git clone
Environment

Open WebUI Version: v0.3.35

Operating System: Windows 10, Debian Bookworm

Confirmation:

[X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.
[X] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
Memory is created by creating a collection when using both Chroma and Milvus
Actual Behavior:
Memory is not added. Silently fails.
Receive error from backend:
pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=Invalid collection open_webui_user-memory-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. ,  collection name can only contain numbers, letters and underscores: invalid parameter)>
Description
Bug Summary:
Memories.py creates collections using names that contain dashes. Milvus does not allow dashes so this fails.
Reproduction Details
Steps to Reproduce:

Configure OpenWebUI to use Milvus instead of Chroma for vector db
Add a Memory

Logs and Screenshots
pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=Invalid collection open_webui_user-memory-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. ,  collection name can only contain numbers, letters and underscores: invalid parameter)>

Additional Information
I have a proposal for how to fix this and can submit a PR. Instead of setting the collection name with dashes in it multiple times in memories.py, create a function, get_collection_name that returns collection_name but with dashes replaced with underscores if the VECTOR_DB_CLIENT is MilvusClient, otherwise return collection_name as currently implemented to keep backward compatibility.

I had tested this on a previous version and then saw it was still present in the latest version in memories.py. However, upon further review I can see that there was code added to apps/retrieval/vector/dbs/milvus.py to perform the replacements at that level. This can be closed as it's actually fixed in the latest version.


Add possibility to add authentication token has headers for a WebProcessingService invocation.

Example: auth_headers = {'Access_token': auth_token, 'Authorization': auth_token}

@mmelcot
just saw your patch and i'm curious to know what kind of auth_tokens you use. We also need to protect our wps services and want to use simple auth-tokens. We have a prototype of an ows security proxy called twitcher:
https://github.com/bird-house/twitcher
Auth tokens are currently just uuid strings. They can be provided either as part of the request url or as a header variable. With owslib i'm using the headers parameter ... well, it's not merged yet ...
https://github.com/bird-house/OWSLib/blob/pingudev/owslib/wps.py#L184
The headers parameter is also used in owslib.wms.

@cehbrecht
We use token from an OpenAM server.
We didn't set-up the OpenAM so I can't tell you how complex it is. But on the client side it is very simple since you just have to provide headers like this:
headers = {'X-OpenAM-Username': login, 'X-OpenAM-Password': password}
in order to receive a token.


runtime: use register instead of TLS for G pointer for darwin/arm and darwin/arm64

Need to decide how to handle TLS on darwin/arm.  On x86, TLS was moved from a pthread_get/setspecific implementation to a reserved (by Apple) slot in the TLS (see #23617).  That's not possible for arm/arm64 so we still use the old method.  Since these archs have more registers, we should probably just reserve a register for the G pointer.
Reserving a register might invalidate some existing assembly code.  Kind of a wrench in the plan, need to investigate how bad it might be.
Or maybe someone can think of a better solution.
We might need a solution before we can do #17490 for arm.

I think we already do reserve a G register on ARM and ARM64, regardless of OS. This is R10 on ARM, and R28 on ARM64. TLS is only used when crossing Go-C boundary, where we save G register to a TLS slot when calling to C, and reload it when entering Go code, as C code may clobber our G register.

Maybe this is unnecessary then.

The pthread_get/set magic is still present in runtime/cgo/gcc_darwin_arm*.c so I wouldn't qualify that as unnecessary.
@cherrymui given that we onlt use the TLS slot for Cgo, could we use a callee-saved register for G and thus avoid the TLS slot (and the save/restore) altogether?

I haven't looked into the code in detail, but I'm not sure callee-saved register is enough. C code can still temporarily use the register, and a signal can happen at this point. The signal handler, runtime.sigtramp needs to look at the G register to tell whether/which Go stack we are on.

Backing up one level: why does runtime.sigtramp need to know which goroutine is running if we're in a C call?

I'm not sure I completely understand the question, but see the sigtramp code in runtime/sys_darwin_arm.s and runtime/sys_darwin_arm64.s.  It does today examine the g register, which it loads out of the TLS slot.

Besides signal handler, another place where we need G is when Go calls C which calls back to Go. There we want to use the same G, I think.

#17490 is fixed, even for iOS, so the remaining bug is that we're relying on an undocumented assumption that a TLS slot allocated by pthread_key_create is located at some positive offset from the TLS base. See https://github.com/golang/go/blob/59ea685ce96a696281e56badd80d2e5dd618b0b0/src/runtime/cgo/gcc_darwin_arm64.c#L31-L45
We recently had to remove a similar assumption for Android (https://github.com/golang/go/issues/29674).
Since we use a register for g on arm and arm64 the appropriate fix for this issue is probably to call pthread_getspecific and pthread_setspecific when entering or exiting C code.


better handling of removed attributes (default values for removed props/attributes)

When an attribute is removed, the default value is not used.
In withUpdate's attributeChangedCallback we have
          const propertyValue = deserialize
            ? deserialize.call(this, newValue, propertyName)
            : newValue;
          this._props[propertyName] =
            propertyValue == null ? defaultValue : propertyValue;

And here for example is one of Skate's builtin props:
const zeroOrNumber = (val: string): number => (empty(val) ? 0 : Number(val));

// ...

const number: Function = prop({
  attribute,
  default: 0,
  coerce: zeroOrNumber,
  deserialize: zeroOrNumber,
  serialize: (val: mixed): null | string =>
    empty(val) ? null : String(Number(val))
});

Say for example I'd like to have a default value of 100:
import {props} from 'skatejs'
const MyNumberProp = { ...props.number, default: 100 }

If the attribute doesn't exist the very first time the element is created, 100 will be used.
But later on, if someone sets the prop to undefined or null or removes the attribute with removeAttribute, the default value will be 0 instead of 100 because the call to deserialize always returns 0 for "empty" values.
It will never return null which means there's never a chance for the default value to be used when an attribute is removed (or prop set to null).
Feature request
Maybe we need a generic way to handle this case so that default will come into play in these cases without manually having to write it in every prop definition.
For example, here's how'd we'd make it work as an end user, which makes it more verbose:
    import {Color} from 'three'

    const MyColorProp = {
        // ...
        coerce: val => val instanceof Color ? val : empty(val) ? MyColorProp.default : new Color(val),
        default: new Color(120, 200, 50),
        deserialize: val => empty(val) ? MyColorProp.default : new Color(val),
        // ...
    }

Use case(s)
A solution to this would simplify props definitions so they don't require manual use of the default value.
    import {Color} from 'three'

    const MyColorProp = {
        // ...
        coerce: val => val instanceof Color ? val : new Color(val),
        default: new Color(120, 200, 50),
        deserialize: val => new Color(val),
        // ...
    }

I think all we really need to do is check in attributeChangedCallback whether or not newValue == null, and if so, apply the default value.

Another way could be to initialize the _props with the default value, and only ever set the default again when set or deserialize has a null. Hmmmm 🤔...

Why can't we just return the default from propType.get() if the value is null internally?

I just checked
https://github.com/skatejs/skatejs/blob/853a53934ac849169fcef8000884c52548ef2748/packages/core/src/props.ts#L45-L51
and I see that it still returns 0 there when values are null, instead of the default value defined in the propType.
Seems like somewhere around here we'd need to call propType.default:
https://github.com/skatejs/skatejs/blob/853a53934ac849169fcef8000884c52548ef2748/packages/core/src/component.ts#L198-L203

We could just return null from deserialize and set default to 0, right?

The default value is now returned from the getter if the value has been removed.


Database cmdlets only work on Windows 8+ / Windows Server 2012+

The database cmdlets only work on Windows 8+ / Windows Server 2012+, because there is a bug in the underlying libraries on older systems. I am currently trying to bypass it.

This is how the error looks like:
PS C:\Users\admin> Get-BootKey -SystemHivePath ‘D:\tmp\ifm\registry\SYSTEM’
040b02c9bd79ae68a95ccde275e12868
PS C:\Users\admin> $key = Get-BootKey -SystemHivePath ‘D:\tmp\ifm\registry\SYSTEM’
PS C:\Users\admin> Get-ADDBAccount -all -DBPath ‘D:\tmp\ifm\ActiveDirectory\ntds.dit’ -BootKey $key
Get-ADDBAccount : Cannot marshal: Encountered unmappable character.
Au caractère Ligne:1 : 1

Get-ADDBAccount -all -DBPath ‘D:\tmp\ifm\ActiveDirectory\ntds.dit’ -BootKey $key

CategoryInfo : OpenError: (:) [Get-ADDBAccount], ArgumentException
FullyQualifiedErrorId : DBContextError,DSInternals.PowerShell.Commands.GetADDBAccountCommand I fail to see where does the problem, thank you for your help

This will hopefully do it. Further testing is needed.

This fix has finally found its way to the upstream, ManagedEsent <IP_ADDRESS>. It seems that our fork could be dropped and the official NuGet package might be used. But Issue #12 needs further testing.


memory-t-usage-guidelines.md: reference to MemoryPool.Dispose should be IMemoryOwner.Dispose

Owners of IMemoryOwner should call IMemoryOwner.Dispose, reference to MemoryPool is a typo here. /cc @GrabYourPitchforks

I fixed other cases where the document refers to MemoryPool<T>.Dispose, it seems to be a consistent mistake.
A MemoryPool<T> never implements IMemoryOwner, it is the provider (pool) of those objects, responsible for Renting them. Disposing the pool means disposing it's retained IMemoryOwner-s.
@tdykstra: if @GrabYourPitchforks doesn't have a chance to look at the PR, you can check his original document to get a confirmation on this:
https://gist.github.com/GrabYourPitchforks/4c3e1935fd4d9fa2831dbfcab35dffc6