RFP - ryujinx-ava

Checklist

[x] The package I am requesting does not already exist on https://community.chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://github.com/Ryujinx/Ryujinx
Direct download URL for the software / installer : https://github.com/Ryujinx/release-channel-master/releases/download/1.1.707/test-ava-ryujinx-1.1.707-win_x64.zip
Software summary / short description: Ryujinx with Avalonia UI

Avalonia is merged into master.


[sil-devirtualizer] Code clean-up. Simplify the previous patch.

Since the return type of the callee is not changed and the old apply instruction is not removed by devirtualizeClassMethod, there is no need to insert an "unreachable" instruction, because by construction rules of SIL it should be already there right after the old apply.

@swift-ci please smoke test


Devel2

Hello,I hope you will pull my change.
Support

codeblock filename
list nested codeblock
Markdown module 3.1.1

Not Support

python 3.2, 3.3
python 3.4 with pygments

Coverage decreased (-9.7%) to 90.323% when pulling c61d452f8b5fd3106cf49d14858894ba89de23ab on oonishi870:devel2 into cd3a2eef17c7ae6cfb9eae269621e534368c726a on Zopieux:master.

I made some misunderstanding about gfm.
I cancel this request.


getting an Undefined variable: fieldnames error

Hi guys, Idk if this is a bug inside of plugin but I kept getting this error.. it seems like variable fieldnames is undefined.. Im looking at code and i dont know where fieldnames is defined

Hi
Could you please provide me your database configuration in the process part of your form settings?
Thx

I'm having the same error, my db config is this:
    - database:
        db: grav
        table: contacts
        fields: { name: name, email: email, message: message }

Could you please provide me the exact error message. and where you get this.

Whoops \ Exception \ ErrorException (E_NOTICE)
Undefined variable: fieldnames
Here's a zip file with the whole thing if that helps error file

Thanks for the infos.
I guess it is an bug.
Workaround
Add the following line after line 83 in the file /user/plugins/form-database/form-database.php:

$fieldnames = "";

Now I get
Undefined index: name

And it's pointing to line 110 of the plugin
$fieldvalues = "('" . $_POST[$val] ."'";

I'm testing it at the weekend.

I've found the problem.
The form plugin is generating the fields using the following:
form:
    fields:
        - name: name

And the fields are coming up in the form as:
<input name="data[name]" value="" type="text">

So $_POST[$val] wasn't finding anything, I've changed it to $_POST['data'][$val] and it works now.
I don't know if this was a change in the form plugin or if it's going to be permanent, but at least I've got it working.

Just to say a big thanks to ramono — your edit seems to work, I was encountering the exact same issue...

also for me, had to make the edit suggested by @ramono.


[CI] Textlint fails locally but not in GH action

Here's the output of when I run the linter locally:
> check:text
> npm run _check:text

> _check:text
> npx textlint content data

/Users/chalin/git/lf/open-telemetry/opentelemetry.io/content/en/docs/instrumentation/php/automatic.md
  102:22  ✓ error  Incorrect usage of the term: “php”, use “PHP” instead  terminology

✖ 1 problem (1 error, 0 warnings)
✓ 1 fixable problem.
Try to run: $ textlint --fix [file]

ERROR: "check:text" exited with 1.
ERROR: "check" exited with 1.

Maybe the script that generates errors for GH gobbles up the failure sometimes? /cc @svrnm

@chalin I can not reproduce that error

@svrnm - we can see the problem in GH too. For that and a fix, see #3120.

@chalin then my local repo might be off 🤷 I approved the PR looks good to me


ONNX Backend test crashes

The following tests are crashing:

[ ] test_resize_downsample_scales_nearest_cpu
[ ] test_resize_upsample_scales_nearest_cpu
[ ] test_resize_upsample_sizes_nearest_cpu
[ ] test_resize_downsample_sizes_nearest
[ ] test_resize_upsample_sizes_nearest_floor_align_corners_cpu
[ ] test_resize_upsample_sizes_nearest_round_prefer_ceil_asymmetric_cpu
[ ] test_resize_upsample_sizes_nearest_ceil_half_pixel_cpu
[ ] test_unique_not_sorted_without_axis_cpu
[ ] test_unique_sorted_with_axis_cpu
[ ] test_unique_sorted_without_axis_cpu

Unique operator test crashes occur due to output being a dynamic shape.
Two remaining tests test_unique_sorted_with_negative_axis_cpu and test_unique_sorted_with_axis_3d_cpu currently return an error because the operator only supports axis = 0 or None. They would also return a dynamic shape and crash if all axis values are supported.

Resize operator test crashes listed in the issue occur due to output being a dynamic shape.
Remaining tests currently return an error because some attribute values are not supported. They would also return a dynamic shape and crash if those features are supported. There are some cases when operator can return a non-dynamic shape, but it seems python backend tests all have a dynamic shape output.


Removed unnecessary variables from view partial, stylistic changes

removed variables tree_id, pfx
stylistic changes

LGTM, but for some reason the Travis build was cancelled.  I just restarted it.


Add better validation for .mp4 video mode

Currently there is limited validation for .mp4 files
https://github.com/trek-view/gopro2gsv#validation-1
With introduction of new modes (e.g. #28 ) validation should be stricter

file extension must be .mp4
filenames must start with GS or VIDEO_
XMP-GSpherical:ProjectionType is equirectangular
trackN:MetaFormat is gpmd
trackN:GPSDateTime has more than 10 entries

Where trackN is the track that contains the gpmd telemetry.

does this mean .mp4 mode should continue to use video->video pipeline and only .360 mode goes through video->image->video piepliine?


Base Test Coverage and Test Organization

This pull request does a number of things.

Adds some tests for the base module, mostly for assert_xydata(), addressing issue #101
Renames tests that shared names with other tests, causing only one to be defined and run. This addresses issue #101
Refactors assert_xydata() for clarity
Moves the test test_correct_title() to test_base_titles_captions.py, addressing issue #115
Moves all the tests for assert_xydata() to test_base_data.py, addressing issue #114

@lwasser Could you take a look at this?

@lwasser The for loop and .iloc[] were temporary things I'd put in for debugging. I'm pretty confused how they ended up in the most recent commit, as I deleted them a couple commits ago, but they should be gone now.

ok @ryla5068 this all looks great. i ddi some testing of black locally. for some reason it's not formatting the docstrings using the 79 character line length. i'm not sure why but let's just ensure the code is 79 characters is less long including the docstrings. i'll create an issue surrounding this but you can adjust the code manually for this pr. once you are done with the fixes, please ping me here again and i'll give this another review (and will likely merge as my comments are very small!!)

a few other question

[ ] https://codecov.io/gh/earthlab/matplotcheck/pull/112/diff?src=pr&el=tree#D3-683 i am wondering if the test for this doesn't have match= to rest that the error message is raised?

@lwasser I think I've fixed everything here.

For the commented-out tests:

The geodata test was not a working or substantial test, so I deleted it.
I moved the timeseries test to test_ts_data.py, but left it commented out.

I couldn't follow the link you gave to the pytest.raises() call without a match=, but I added a match= to a couple tests in test_base.py. I believe every test in that file and intest_base_data.py has a match= now.
I added docstrings to the fixtures
I changed all the docstrings in base.py to have the correct length lines

excellent work on this PR @ryla5068 !!! i'm going to let CI run and will then merge this.


Sort feature added in all tables

Hello,
I solved issue no #99

Now we can sort the entities by clicking on the header of that column.
If you create a new table in the future then add a class like class="data-table" in that table then the sort feature is also working for that table.
Suggestions:-
If you want more features like pagination, searching bar, etc for the table then you can do that by changing "false" to "true" pagination, searching, etc at the bottom of the header.ejs file.
Thanks.

@vsvipul Please review this PR.

Hi @pankajkumarbij
Good work on this, but I think there are some unwanted changes in the design of the tables
See :
(BEFORE)

(AFTER)

Can you investigate why this is happening and how could this be fixed?

Now all the unwanted changes in the table are resolved.
The sort feature is working very well. you can check by clicking on the table column's header.
Now please review and merge it.

I am getting this error in the terminal when I try to run the code in this PR.
@Signior-X could you please check if you too see a similar error?

It works fine on my side.
Please check again and accept PR.

Pranshu, the error says address is already in use. Try killing all
npm/nodemon processes and try again. If this doesn't help, restart your pc.
On Sat, 19 Dec 2020, 03:12 pranshukharkwal<EMAIL_ADDRESS>wrote:

[image: Screenshot from 2020-12-19 03-11-28]
https://user-images.githubusercontent.com/21126219/102664019-ef981f00-41a7-11eb-9f14-b535e5765572.png
I am getting this error in the terminal when I try to run the code in this
PR.
@Signior-X https://github.com/Signior-X could you please check if you
too see a similar error?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/KamandPrompt/CodeManiacs/pull/164#issuecomment-748333650,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2G2BA37PX5CJ7CRWTUBWDSVPEF7ANCNFSM4UWPENPA
.

@pranshukharkwal I tested this on my PC, working well. Do as suggested by Dheeraj.
@pankajkumarbij this is working as expected, quite nice. Just one thing I noticed, hovering on the heading of the column doesn't make a feel that it is kind of button to sort.

Like here hovering on the name doesn't feel like a button.
Can you try to add a tooptip on the column headings wherever they are needed or check if there is something kind of in the library you used.

@Signior-X @pankajkumarbij Yes, I too think that something should be there to indicate that these columns could be sorted. Currently it just looks like a table.

There is two types of changes I can do:-

Feel the table's column header like a button or link.
I can use a Sort Icon with a heading and also feel like a button(given below picture)

Which one you want please let me know after that I will update this PR.

Second option LGTM.
@Signior-X what do you say?

Please check now table headings look like a sortable button.

check and let me know if any mistakes.

Please review this PR.

@pankajkumarbij I have an exam tomorrow. I will review this pr after that. It will be done by tomorrow

@Signior-X The changes look good to me. Please review the PR and merge it if it is all good.

@pankajkumarbij Awesome work done... to the point! Keep up the good work.
@pranshukharkwal mergung  this one


Skipped Day in Week View

A day (Wednesday) is completely skipped in the week view with the "Show current day in daily list" option disabled:

It goes from Tuesday (the current day) straight to Thursday.
Version 2.9.2 build 145

@LinuxinaBit is it still the same after a full app restart?
which provider? can you export settings and share with me? You can share by email (cause it will have your location)

Unfortunately I did a reinstall and it’s fixed now (of course) and I can’t reproduce it.
Maybe it’s a weird timezone thing, I’ll check later tonight.
Otherwise I’ll just close this, sorry about that 😅

@LinuxinaBit think the issue is still there. if you see it again let me know and share your settings

Ah, ok. I’ll let you know 👍


<EMAIL_ADDRESS>adds routes/_index.tsx to templates even if they already have a routes/_layout._index.tsx file

Describe the bug
When using create-remix@latest to check out a later version of BeeRich that comes with a routes/_layout._index.tsx file, then create-remix adds a default _index.tsx file to the project code.
This leads to a build error:
⚠ Route Path Collision: "/"

The following routes all define the same URL, only the first one will be used

🟢 routes/_layout._index.tsx
⭕ routes/_index.tsx

Fix/Workaround
There is an easy fix! Just delete the _index.tsx file from the project before diving into the code! :)
To Reproduce
Steps to reproduce the behavior:

Run npx create-remix@latest --template https://github.com/PacktPublishing/Full-Stack-Web-Development-with-Remix/tree/main/15-advanced-session-management/bee-rich/solution with a later version of BeeRich
Follow the prompts in the terminal
Open the BeeRich project in a file explorer and notice the added routes/_index.tsx file

Expected behavior
No _index.tsx file is added.
Actual behavior
Remix's default _index.tsx file is added to the BeeRich project code.

Seems to have been a one-off bug for me! Remix team closed the ticket as not reproducible. Glad this isn't an issue!


Shut down cleanly on SIGINT

Would be nice, currently it's caught by the main thread which goes down taking the "timer circuits" with it. A second SIGINT then kills the python VM.

Hallo shutdown function also isn't working cleanly. Dictionary changing size while being iterated

Moved to trello https://trello.com/c/JropK5Py/225-clean-up-hallo-shutdown


[RFC] Better merging standards

Right now There are some ways for merging existing data structures in Dynaconf

Using dynaconf_merge mark
Using __ double underlines for existing dictionaries and nested data
Using MERGE_ENABLED_FOR_DYNACONF var to merge everything globally

All the 3 existing ways has limitations.

dynaconf_merge is limited because it works only for 1st level vars
__ works only for data nested under a dictionary
MERGE_ENABLED can break stuff in Django config.

New standards for merging.

NOTE All the above will keep working, we will try to not break backwards compatibility.

Although we are going to explicitly recommend only the new standards on explicit ways for merging that meets:

Optional Granular control of which data is being merged
Control of global merge feature per file
Works also via environment variables
Merge at any level in the nested structures
Can merge any data type like dicts and lists

The merge mark
Historically dynaconf is being using @marks for some special environment variables, we will introduce a new one: @merge for env vars and improve the existing dynaconf_merge for regular files.
Merging files.
A settings.yaml file exists in your project:
default:
  name: Bruno
  colors:
    - red
    - green
  data:
    links:
        twitter:  rochacbruno
        site: brunorocha.org

which will  add to settings.__dict__ object data like:
{
  "NAME": "Bruno",
  "COLORS": ["red", "green"],
  "DATA": {"links": {"twitter": "rochacbruno", "site": "brunorocha.org"}}
}

In a settings.local.yaml we want now to contribute to that existing data we have 2 options
Merge the whole file
adding a dynaconf_merge: true to the root level of the file.
settings.local.yaml
dynaconf_merge: true
default:
  colors:
    - blue
  data:
    links:
        github: rochacbruno.github.io

Then settings.__dict__
{
  "NAME": "Bruno",
  "COLORS": ["red", "green", "blue"],
  "DATA": {"links": {"twitter": "rochacbruno", "site": "brunorocha.org", "github": "rochacbruno.github.io"}}
}

Granular control of which variable is being merged
If we want to merge only specific variables we have to enclose data under a dynaconf_merge key, for example we want to override everything but we want to merge the colors.
settings.local.yaml
default:
  name: Other Name
  colors:
    dynaconf_merge:
      - yellow
      - pink
  data:
    links:
        site: other.com

if it was toml
[default]
name = "Other Name"

[default.colors]
dynaconf_merge = ["yellow","pink"]

[default.data.links]
site = "other.com"

So dynaconf will do pre-processing of every file and for each dynaconf_merge it will call the merge pipeline.
Result on settings.__dict__
{
  "NAME": "Other Name",  # <-- overwritten
  "COLORS": ["red", "green", "yellow", "pink"],  # <-- merged
  "DATA": {"links": {"site": "other.com"}}  # <-- overwritten
}

Dunder merging
Dunder merging continues to work as a shortcut when the data you want to merge is behind a nested datastructure
default:
  data__links__telegram: t.me/rochacbruno  # <-- Calls set('data.links', "t.me/rochacbruno")

or toml
[default]
data__links__telegram = "t.me/rochacbruno"  # <-- Calls set('data.links', "t.me/rochacbruno")

or .env
export DYNACONF_DATA__links__telegram="t.me/rochacbruno"  # <-- Calls set('data.links', "t.me/rochacbruno")

@merge mark
For envvars the @merge will mark as it follows the standard for the other envvar markers.
and it can also be used in regular files
.yaml
default:
  name: Jon # <-- Overwritten
  colors: "@merge blue"   # <-- Calls .append('blue')
  colors: "@merge ['blue', 'white']" # <-- Calls .extend(['blue', 'white'])

.env
export DYNACONf_NAME=Erik   # <-- Overwritten

export DYNACONF_COLORS="@merge ['blue']"   # <-- Calls .extend(['blue'])
export DYNACONF_COLORS="@merge ['blue', 'white']"  # <-- Calls .extend(['blue', 'white'])
export DYNACONF_COLORS="@merge blue"  # <-- Calls .append('blue')
export DYNACONF_COLORS="@merge blue,white"  # <-- Calls .extend('blue,white'.split(','))
export DYNACONF_COLORS="@merge blue 0"  # <-- Calls .insert(0, 'blue')
export DYNACONF_COLORS="@merge white 1"  # <-- Calls .insert(1, 'white')

export DYNACONF_DATA="@merge {foo='bar'}"  # <-- Calls .update({"foo": "bar"})
export DYNACONF_DATA="@merge foo bar"  # <-- Calls ['foo'] = "bar"

@kedark3
I am trying to improve the usability of merging features and give better ways for doing this, your suggestions already helped a lot :tada: thanks!!
Now if you have more suggestions or concerns about the above ideas please comment!
Thanks

Thanks @rochacbruno  I specifically liked dynaconf_merge: true which is very easy to follow and your example intuitive. Rest it looks good :)

I will start working on this which will land in the next release probably next week.


Create view for settings menu in projectView

Need add:

[x] users with role in project
[x] check box for public/private project
[x] move button Delete project from Run menu
[x] number of containers
[x] email for project
[x] check to permit/prohibit editing project settings according to user permissions

On this tab we'll also have permission management described in #598

@akuleshov7 what do you mean by saying "number of containers"? Should it be a dropdown where you can choose amount of containers to be used for testing or it's just a label that indicates amount of containers dedicated for a project?

@sanyavertolet Also, project settings shouldn't be editable if the user doesn't have permissions to edit them. Now we'll just display a 403 error, but there should be some other check too

Closed with #652 and #641


KubernetesPodOperatorAsync failing for latest release of CNCF provider

As per thread https://astronomer.slack.com/archives/C05C7UUPVUH/p1700677604156029
the KubernetesPodOperatorAsync from astronomer-providers is failing.
This is because PR https://github.com/astronomer/astronomer-providers/pull/1359 was introduced to pin the CNCF K8s provider to version <=7.8.0 as there was a breaking change introduced in Airflow OSS PR https://github.com/apache/airflow/pull/35422
If the deployment has CNCF K8s provider version > 7.8.0, it does not work due to the breaking change. We need to figure out a fix for this.

The solution for this is being discussed in Slack thread https://astronomer.slack.com/archives/C05RJA7N3LG/p1700726069898429?thread_ts=1699502522.999209&cid=C05RJA7N3LG

It was discussed to revert the PR https://github.com/apache/airflow/pull/35422 for the time being and then figure out a long term solution later. @dstandish helped here on a holiday to create the revert PR https://github.com/apache/airflow/pull/35822.
@vatsrahul1001 helped test this PR together with CNCF k8s 7.9.0 on an Astro deployment by running the failing KPO Async DAG and it ran successfully.
This has been communicated to Elad, RM for Airflow providers and it will be included in the upcoming RCs. So, I guess we're sorted with this ticket for now.

We need to release astronomer-providers including the revert of pin PR #1368


Performance.hints: "warning" emits non zero exit code

Bug report

Performance.hints defaults to "warning". It is my understanding that a warning is not an error (hence we also have the "error" option). However, even with hints set explicitly to "warning", webpack returns a non zero exit code.
...
	performance: {
		hints: "warning",
	},
...

What is the current behavior?
Webpack returns a non zero exit code when building with performance.hints set to "warning".
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  ire (2.31 MiB)
      js/bundle.js
webpack 5.0.0-rc.0 compiled with 2 warnings in 161386 ms
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `webpack`
npm ERR! Exit status 1

If the current behavior is a bug, please provide the steps to reproduce.
Build anything that produces a performance hint and observe that the exit status is not zero. For easy testing one can add maxAssetSize: 1 to always trigger a performance hint.

What is the expected behavior?
Exactly the same output but with exit code being zero whenever hints is set to "warning".

Other relevant information:
webpack version:  5.0.0-rc.0 (webpack-cli 4.0.0-rc.0)
Node.js version: v12.18.4
Operating System: Windows 10
Additional tools: N/A

Not sure hints should be change exit code, because it is not break build or something elase


Context search parser

Develop a text/comment parser exclusively for context search.
Make sure storage is still kept relatively small per ticket; 20kb - 30kb max.

Maybe only store the parser result, not all comments.
And parse the ticket right as it comes in, will make estimation requests take a little longer.


Refactor inventory items out of images.json

Inventory items that are added to inventory over the course of adventure are currently defined in images.json, and are added in their own invisible Konva Layer to the stage.
Can we get rid of this extra Layer?
Could we add them to the inventory layer "on the fly" as they are picked up / created to the inventory?

Instead of having a layer of their own, could the inventory items (when invisible) reside in the inventory layer?
Is it necessary for them to reside in a layer at all? Can they exist in the stage in some other way?
Could they be created on the fly, instead of at the start?

Minimal implementation in 770bae0


Dev Update/Bump

This was originally going to land as 1 PR but I've split it out into 2 and branched from this one for the other one in my dev environment.
The purpose was to provide a cleanup of a load of redundant options inside the cucumber tests - Saving a small amount of time but mainly just improving readability (Also because a lot are redundant), as well as a slight bump to our gem dependencies - Specifically Selenium Webdriver.
This PR focuses just on the dependencies, the next one will tackle some of the cukes - As one config option was masking a lot of poor setup!
All of the items removed are either default / redundant. The Profiles have been removed because Chrome's did nothing (It was just there for backwards compatibility), and Firefox's only did some basic cache removal. Which creating new Boxes each time would render redundant - The only possibly caveat to this is that it might affect local dev runs, however now we're using an up to date version of geckodriver (And local developers should too!), this problem shouldn't occur

ping @tgaff @TheMetalCode


Struct level #[builder(Default=!)] is making optional fields instead of required

#[builder(Default=!)] on a struct still make its fields optional. I don't even implement Default on Foo.
#[derive(Builder)]
#[builder(Default=!)] // I want to force setting `uni`
pub struct Foo {
    uni: i8,
}

impl Foo {
    fn build_me() {
        let foo_build: FooBuilder = Foo::builder();
        let bar = foo_build.build(); // Still compile ?!
    }
}

However field level works:
#[derive(Builder)]
pub struct Foo {
    #[builder(Default=!)] // I want to force setting `uni`
    uni: i8,
}

impl Foo {
    fn build_me() {
        let foo_build: FooBuilder = Foo::builder();
        let bar = foo_build.build(); // No compiling!
    }
}

Hi @RustyNova016 ,
#[builder(Default=!)] on a struct is only applied to struct itself.Applying to whole struct (aka isn't currently supported

Oh I see. Would be nice to have the option to apply to the whole struct, but I guess I'll have to wait for it.

Oh I see. Would be nice to have the option to apply to the whole struct, but I guess I'll have to wait for it.

I may implement it this week-end, but test completeness for releasing may took few additional days. Expect it into a 1 week :)

@RustyNova016 1.2.0 has been released: https://github.com/loganmzz/macon-rs/releases/tag/1.2.0

Thanks! Gonna update now


How to upgrade talos via talosctl

I can see that talhelper will generate a talconfig controlplane.yaml with an image id. When I apply this config, it does not install the image which is refered to. How can I upgrade my talos os when another image is refered in talosconfig of the controlplane.yaml?

You can't upgrade using talosctl apply-config command to update the image of your node. You should use talosctl upgrade command instead.
Using talhelper, you can do it like so: talhelper gencommand upgrade -n <node name or ip> and run the generated command.

Thank you!


[IMPROVEMENT] Add Support for Custom Headers and HTTP Methods in Generic Webhook

Describe your changes:
Fixes https://github.com/open-metadata/OpenMetadata/issues/17879

Support for custom headers and http methods (POST/PUT) in generic webhook.

Type of change:

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 We will require changes in the UI side for this.

Field for providing custom headers for webhook.
Field for choosing between POST and PUT http method for webhook.


nav bar changed

@avinash201199 I got to know why I got branch conflict. Actually when new courses were added an extra comma was appended at the end of each object in the array in allcourses.json which I've to fix before making any changes to the nav. Merge this PR before adding any course there'll again be merge conflicts

Thank you for your valuable contribution


RFC: Trusted Language Handling

This is a request for comments, we'd like to hear user (or potential user) opinions and get feedback!

As highlighted by @jim-mlodgenski in #9, PL/Rust is currently an "Untrusted" language. This is mostly due to immaturity of the project.
It's our intent to provide a "Trusted" language handler with this repo. For a review of the distinction between trusted and untrusted, see the PostgreSQL PL/Perl docs.
PL/Rust should be restricted from using certain operations such as:

accessing file handles,
accessing database internals,
getting OS-level access with the permissions of a server process (as a C function could)

Rust is a bit different
Rust is considerably different than Perl, Python, Node (via PL/v8) in that it is not interpreted, nor does it have a runtime we can embed in PL/Rust.
Rust creates either target-specific shared objects or binaries, or it creates portable wasm artifacts.

The process of building the code can potentially mutate the build environment (via build.rs or proc macros), but this is a topic for a separate issue.

The shared objects (or binaries) are roughly equivalent to C code, and get executed as such. Due to it's nature, Rust also naturally includes abundant unsafe support, unlike these other interpreted languages. A Rust function from a shared library can do as it pleases with the memory of the process, for example.
PL/Rust's current handling
At this time, PL/Rust is loaded as a PostgreSQL extension, and inside of that process it finds and dyloads the produced cdylib.
Doing this, library initialization routines occur, and all normal precautions around calling unknown foreign functions must be followed. In general, this process is not trusted.
Since PL/Rust created libraries are ultimately loaded by the postmaster binary, they can do whatever any other pgx extension can do, or any C function.
Ways forward
Ultimately, there are two paths we've been discussing:

Having shared objects run in a separate (probably per-function) process which is sandboxed via seccomp/cgroups, and forcing #[forbid(unsafe)] and disabling std, ensuring users only use core and alloc, along with other allowlisted also #[no_std] crates (so the user cannot simply extern crate std;.
Having PL/Rust embed wasmtime (or some other runtime) and use wasm's sandboxing features from inside the postmaster process. (Note this path does not require any disallowing of unsafe code, as the function will already be sandboxed, so it's free to do whatever it wants to it's memory.)

There are several factors contributing to a decision:

Speed: We want PL/Rust to provide users with nearly the same speed as an untrusted C function. It's expected that there will be some cost to sandboxing, but we'd like to avoid impacting the already rather high cost of doing an extern call in PostgreSQL.
Maintainability: Our team is small, and we simply do not have the resources to invest managing a completely homegrown sandboxing solution. It would be desirable if we could use an existing solution and work with that upstream to improve the state of the art when we do have time.
Risk: If a user was able to create untrusted behavior in PL/Rust, we would like to limit the blast radius. It's preferable if the behavior gets killed, even if that takes down the entire database (but safely), as opposed to allow some untrusted behavior. Of course, we'd like that blast radius to be smaller, but a failure like that is still preferable to a PL/Rust function getting access to the superuser account, or a shell onto the host machine.

I have a personal bias towards the wasm route because I can certainly see in the future users requesting things like "I'd like PL/Rust to be able to access XYZ directory and I will configure that with a GUC".
We noted from some benchmarks that there is some definite speed impact, which I worry about, however creating proper isolation on cdylibs may incur roughly the same overhead...

I was investigating the dylib method a bit this morning.
There exists crates like https://github.com/servo/gaol (created for Servo, but long unmaintained), https://github.com/unrelentingtech/rusty-sandbox (also long unmaintained).
I also found this really good article by @marioortizmanero who is doing a @tremor-rs LFX internship: https://nullderef.com/blog/plugin-tech/, which also linked to this paper which includes some metrics around inter-process communication options other than WASM.

We've dug into a branch that does execution with wasmtime and it turns out to be quite fast: https://github.com/tcdi/plrust/tree/wasm-execution
We're exploring how to manage interfaces like SPI next.

Tasks

[ ] tcdi/plrust#32

In general preventing unsafe is insufficient to prevent... anything. The long list of I-unsound functions in rust-lang/rust is full of evidence of this, and most of these are not considered a security issue, as the language doesn't guarantee that you can't pwn yourself. In particular, there are pretty much always a few[^few] lifetime or typesystem bugs which can be abused to easily cause a use-after-free with no unsafe code. These (unlike most I-unsound issues) can be used to subvert the safety system in basically any manner desired, including read+write access to any memory (trivially), transmutes (easily), calling any function in the process (more difficult, but usually possible), and so on.
[^few]: At least 6 or 7 of these seem to exist on stable Rust when I looked last night. Most of them are over a year old, some much older, and they're generally very hard to detect/prevent.
I'd think spawning a sandboxed process (seccomp filter on Linux, seatbelt on macOS, ...) to run the function would be able to limit the damage to what that process has access to (if we can arrange that to be less, that would be ideal). I'm not terribly familiar with sandboxing on Linux though, and maybe either seccomp isn't strong enough[^1], or it may be there's no way to limit the damage, since they still need the ability to talk to the db. Either way, I'm assuming this isn't quite enough given the mention that we'd still need to prevent unsafe in the child.
FWIW, WebAssembly (via wasmtime or similar) is much better suited for this purpose -- with a Wasm sandbox, our risk would be limited to spectre-style attacks, which every other trusted language doubtlessly has trouble with as well[^2]. These are only powerful enough to grant read access to other process memory. We don't need browser-level sandboxing so I believe this would not be of concern.
[^1]: Certainly macOS's seatbelt sandboxing seems like it could do this (it's extremely powerful, IIUC more than any other OS's sandboxing capabilities), but I'm not sure how much we care about macOS (aside from supporting it as a development environment).
[^2]: Preventing them pretty much either requires process isolation -- although you can get close if you prevent access to timers and other sources of non-determinism. Given that accessing timestamps seems important for a database language, I suspect nobody does this.

From some offline discussion: trying to protect from malicious actors in cases like this is not (currently) within the scope of this project (or issue), so this is fine. Maybe someday it will be revisited, but it's an impractical amount of work at the moment, and not needed.

We've moved past the idea of WASM (for now) and a trusted plrust can be built with cargo pgx package --features trusted,pg15.


Strange behaviour of player controls function

Hi I am new to C++ language and this library. So far this library works for my project, however, the spotify.play() function will always fail with the following message.
/v1/me/player/play
api.spotify.com
[ 11307][E][ssl_client.cpp:37] _handle_error(): [send_ssl_data():382]: (-80) UNKNOWN ERROR CODE (0050)
Failed to send request

The strange thing is, the request was actually sent successfully, and my music was played as intended.
Additional Info:

I have a Spotify premium account
The function was only called once

Update: I met the same issue even if I ran the exact same code from your getRefreshToken.ino example. I am doubting maybe it is the behavior of the WifiClientSecure library.

I think I found the problem, the issue occurred in SpotifyArduino.cpp lines 86, under makeRequestWithBody() function.
Somehow it happened when an empty body was printed with client->print(body);
I made a tad bit changes to the code and everything seems working again,
From
client->print(body);

To
if (strlen(body) == 0)
{
    client->println();
}
else
{
    client->print(body);
}

Where I use client->println(); instead when printing an empty body.


Display all file names in tabs with multiple splits

I am a novice at using airline, but already adore it. One thing that I have been trying to achieve, however, is to have tabs display the names of all files present in multiple window splits. For instance, suppose tab 1 is divided into 3 splits, then the tabs would display the names of all 3 files.
Is that possible? Thanks!

If you set let g:airline#extensions#tabline#show_buffers = 1
It shows all the buffers per tab.


No actual place (besides in documentation,) to transfer domain name!

Example URL(s)
Screenshot_20240503-114844

Actual Behavior
No actual place (besides only in documentation,) to transfer domain name so I can transfer my domain!
Expected Behavior
No actual place (besides in the documentation,) to transfer domain name so I can transfer my domain!
Additional information
No actual place (besides in documentation,) to transfer domain name so I can transfer my domain!
And one screenshot above shows my domain NOT registered and the other shows not registered, but needs namservers updated at my hoster?
I need to TRANSFER to be able to actually be able to manage* my domain, without conflicting how tos!
And I do NOT know what is supposed to be input into all the boxes?????
THANK YOU!

Howdy @johdough, I'd encourage you to submit a ticket to our Support team about this issue.
We can't do much to help with troubleshooting issues around the interface itself.


Updates Dataflow container images used by unreleased SDKs.

R: @aaltay


Allow connecting by address

This PR allows one to pass in the BLE address of the printer instead, to avoid having to wait for autodiscovery.

Thanks again @akx. It looks great modulo two small comments. Can you also update the README.md with the new output of --help?

@rbaron Hi! What two small comments? I didn't see a review or anything..? :)

Oops, I forgot to hit submit review 😬

Thanks a lot @akx, this looks great.


Dynamically changing events in a modal dialog

I can dynamically load events by changing $scope.events in a controller but it doesn't appear to work when the calendar is in a modal dialog.
I have created a plunker here https://plnkr.co/edit/9zlEjlAIlsfMFY4bcOPT?p=preview
The "Add new2" button should initialize it to 2 events but doesn't. If you move the calendar and buttons outside of the modal-dialog it works fine.

This is scope issue rather than a specific issue with the calendar. When you transclude the calendar into the modal you create a child scope so the references get messed up. You can get around this by putting your variables into a parent object like so $scope.view.events = [] or better yet use controllerAs syntax. Here's your plunker fixed: https://plnkr.co/edit/cuuN6xzunl9MwebMBXFR?p=preview
Hope this helps :smile:


Use of separate certificates for App GW frontend and APIM proxy endpoint

I understand App GW v2 now supports Rewrite HTTP headers:
https://docs.microsoft.com/en-us/azure/application-gateway/rewrite-http-headers
App GW now supports the ability to rewrite headers of the incoming HTTP requests as well as the outgoing HTTP responses.  Please validate and consider updating this document to make clear that rewrite headers and separate certificates is a viable option.  This would be of interest to customers who wish to make use of separate certificates on the App GW frontend and corresponding APIM proxy endpoint.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37c1f253-44c2-bd07-4c74-9d4c77c45e6e
Version Independent ID: 281ce98c-115b-3c39-52b7-3df95dfd8b52
Content: How to use Azure API Management in Virtual Network with Application Gateway
Content Source: articles/api-management/api-management-howto-integrate-internal-vnet-appgateway.md
Service: api-management
GitHub Login: @solankisamir
Microsoft Alias: sasolank

@balajivenkataraman - Sorry for slow response. The documentation was recently updated to show Application Gateway v2 integration.

Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue.
#please-close


Volume initialize() code invalid

Problem
The code in https://github.com/docker/docker/blob/master/volumes/volume.go#L93 is incorrect.  It only hits the inner side of the if block if the error is not nil and it's an is not exist error.  Any other error type is ignored and the code just goes along.
Solution
Fix the logic to only mkdirall when the error is not exist and return the error for any other error type.

#dibs


[Help] could anyone describe layout and layout-grid

What differs between these two field types?
What are their intended use cases?
Do they have any options?

layout-grid is a layout component ... please try to always use the layout field


TIP MOTION - question

Hello all,
I'm running OpenFAST v3.5.2 to study the tip motion of a Baseline-like turbine with neither tilt, coning nor yaw angles, so I enabled the flapwise and edgewise degrees of freedom of the blades.
I assume that all the tip displacements, translational and rotational, are related to each other: the azimuthal trend describing the rotation of a blade element about the Yb,1-axis should be somehow similar to the translational displacements along the Xb,1- and Zb,1- axes, but it comes out that there's a shift in these azimuthal trends. How can it be possible?

Under my assumptions, the translational displacement about the blade x-axis is also related to the rotational displacement along the blade z-axis, which is considered null by ElastoDyn, thus the azimuthal trend of the rotation about Yb,1 should have the exact same trend of the translational one along Xb,1.
Thanks in advance.

Dear @ILDENIEL,
I would guess the phase shift you are showing has something to do with the blade structural pretwist, which couples flapwise and edgeise bending.  Are the Y rotations in phase with the X translations when the structural pretwist (input StrcTwst in the ElastoDyn blade input file) is zeroed?
Best regards,

Dear @jjonkman,
your help and your tips are always paramount and incredibly appreciated.

with a structural pretwist constant equal to 0 for all the ED nodes, the phase shift is 0.
Thank you so much for your availability and your courtesy.

Dear @ILDENIEL,
I'm glad your results make sense to you know.
The structural twist in ElastoDyn defines the orientation of the principal axes of bending, which effects the coupling between flapwise and edgewise motions.
The aerodynamic twist in AeroDyn defines the orientation of the chordline, which primarily effects the local angle of attack.
Both twist values are often similar, but need not be identical.
Best regards,

Dear @jjonkman,
I thought that these two concepts were tied together, since the angle of attack changes (also) because of the blade bending itself and the following change of the local wind velocity.
Among the papers and documentation, unfortunately, I haven't been able to find such a distinction or explanation.
Where can I find these definitions? Is there a particular document focusing on this topic?
Thanks in advance,
Best regards

Dear @jjonkman,
I understood the difference between structural and aerodynamic twist because of your clear explanation, I just wanted to know if there was a specific document clearly pointing out this difference, in order to eventually cite it.
I'll go through with the documentation that you kindly shared.
Thanks again for your help.
Best regards.


Great Code

Your code is clean and easy to follow. I enjoyed it, and I have learnt a lot. But it looks like you repeated the below:
  // | # ||
  else if (ch == "|") {
    if (ch + second == "||") {
      next();
      processToken(tokens, ch + second, line, column);
    } else {
      processToken(tokens, ch, line, column);
    }

}

Glad you enjoyed it, fixed with https://github.com/maierfelix/mini-js/commit/b71e67736b6dac9a217b648930f51d897e829d0f


fix(state): Make FindHeaders and FindHashes run concurrently with state updates

Motivation
Zebra reads 160 headers for each FindHeaders request.
The FindHeaders requests used to take 5-10 seconds to answer, they might still be a bit slow.
So we want to run them concurrently with state updates.
Depends-On: #4825
Solution

Make FindHeaders and FindHashes run concurrently with state updates

Use the new methods in existing state methods

Make some state queries more efficient

Review
This is an urgent PR to fix Zebra sync performance.
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

In my local tests, PRs #4825 and #4826 make all FindBlockHeaders requests complete in under 5 seconds.
(Our current performance logging limit.)

I rebased this branch on the squashed commit.
All the tests passed except lightwalletd (PR #4828) and mempool_transaction_expiration (ticket #4819), so I'm going to admin-merge this PR.


chore: discuss performance tests in readme

FYI @josd - checkout https://eyereasoner.github.io/eye-js/dev/bench/ :)

:tada: This PR is included in version 4.21.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v4.21.7

Your semantic-release bot :package::rocket:


JAMES-3534 Fixbug - Identity response alway return mayDelete=false when server set identity

Fix bug:
GIVEN I modified my default identity in the webmain
WHEN I try to delete it by JMAP
THEN it fails

Duplicated #2083 or I miss something?

Duplicated #2083 or I miss something?

as my commented on 2083 pr
2083 fix logic "after" storage database,
this pr:

will fix logic "before" storage database


Add build scripts and README file for Derecho

This PR introduces the build scripts and README file about how to build TUV-x and its dependencies on Derecho.
The scripts work for both GNU and Intel compilers (both of them compile successfully).

Using the GNU compiler, all the 59 regression tests are passed.
Using the Intel compiler, the regression test suite hangs at the regression_aerosols_radiator_4strm test for an unknown reason (https://github.com/NCAR/tuv-x-private/issues/286).

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Security alert for development dependencies acorn and minimist via eslint

Thanks for submitting an issue! Below are a few things you can do to help us more quickly address the issue.
Checklist
I have…

[x] described in detail below both the behavior I expected and the behavior I observed.
[x] thoroughly outlined below the steps to reproduce this issue, including relevant technical details (e.g. device, operating system, browser, browser version).
[ ] attached screenshots illustrating relevant behavior.

Expected Behavior
N/A
Observed Behavior
Github has identified acorn and minimist as outdated dependencies that were installed due to eslint. The dependencies are only used in linting for development and CI.
Steps to Reproduce
To reproduce this issue…
N/A
Screenshots
N/A

Minimist appears to be a dependency of eslint, fsevents, and other packages which have been flagged as a vulnerability. We will attempt to bump the version one some of the updates are pushed in those packages. Refer to the following GitHub issue:
https://github.com/eslint/eslint/issues/13050


Update prettierx to version 0.19.0

This patches a critical security vulnerability

@sheerun any chance you could merge this?  Small change, but critical.

@sheerun Starting to get critical notices inside Terminal.  Any chance this could please be merged?


Error "Failed to change file that is currently being used" when deploying to a .NET 5 site with WebSockets

I am deploying a zip file to a .NET 5 website, using this configuration:
- uses: azure/webapps-deploy@v2
  with:
    app-name: sharplab-edge
    package: WebApp.Server.zip

I only added this deployment just now, and I am running into an error:

Error: Failed to change file that is currently being used "D:\home\site\wwwroot\SharpLab.Runtime.dll"

Full log
Run azure/webapps-deploy@v2
  with:
    app-name: sharplab-edge
    package: WebApp.Server.zip
    slot-name: production
  env:
    AZURE_HTTP_USER_AGENT:
    AZUREPS_HOST_ENVIRONMENT:
Package deployment using ZIP Deploy initiated.
Updating submodules.
Preparing deployment for commit id '7561bb78b5'.
Generating deployment script.
Using cached version of deployment script (command: 'azure -y --no-dot-deployment -r "D:\local\Temp\zipdeploy\extracted" -o "D:\home\site\deployments\tools" --basic --sitePath "D:\local\Temp\zipdeploy\extracted"').
Running deployment command...
Command: "D:\home\site\deployments\tools\deploy.cmd"
Handling Basic Web Site deployment.
Creating app_offline.htm
Error: Failed to change file that is currently being used "D:\home\site\wwwroot\SharpLab.Runtime.dll"
KuduSync.NET from: 'D:\local\Temp\zipdeploy\extracted' to: 'D:\home\site\wwwroot'
Copying file: 'appsettings.Development.json'
Copying file: 'appsettings.json'
Copying file: 'SharpLab.Native.Profiler.dll'
Copying file: 'SharpLab.Native.Profiler.pdb'
Copying file: 'SharpLab.Runtime.dll'
Failed exitCode=1, command="kudusync" -v 50  -f "D:\local\Temp\zipdeploy\extracted" -t "D:\home\site\wwwroot" -n "D:\home\site\deployments\7561bb78b59f41d5a5d59fdf27c09a6e\manifest" -p "D:\home\site\deployments\4be36940f6a4876eed6d36ed24c97117df5433d31609801997951\manifest" -i ".git;.hg;.deployment;deploy.cmd"
An error has occurred during web site deployment.
Error: Failed to change file that is currently being used "D:\home\site\wwwroot\SharpLab.Runtime.dll"\r\nD:\Program Files (x86)\SiteExtensions\Kudu\91.21119.4922\bin\Scripts\starter.cmd "D:\home\site\deployments\tools\deploy.cmd"
Error: Failed to deploy web package to App Service.
Error: Deployment Failed with Error: Package deployment using ZIP Deploy failed. Refer logs for more details.
Successfully updated deployment History at https://sharplab-edge.scm.azurewebsites.net/api/deployments/29a251b6083275b643acd856dc6d449e86c587821609802731619
App Service Application URL: http://sharplab-edge.azurewebsites.net

I thought this might be due to the site not correctly handling app_offline.htm (maybe due to a WebSocket connection). But on the other hand when using SCM I can somehow do anything with the files -- they don't seem locked at all even without app_offline.
Not sure what's the actual problem and the right solution here -- maybe action should have an option to stop/start web app explicitly, or a wait/retry setting? Either way some graceful way of handling this and letting the user know what exactly is wrong would be great.

Interestingly, that even fails if I run az webapp stop right before it, probably because stop is not fully processed yet?
Seems like wait/retry would be the best solution here.

Interestingly, that even fails if I run az webapp stop right before it, probably because stop is not fully processed yet?
Seems like wait/retry would be the best solution here.

Can you try with run from package deploy option? https://docs.microsoft.com/en-us/azure/app-service/deploy-run-package#enable-running-from-package
I have found similar older issue https://github.com/projectkudu/kudu/issues/2849

Can you try with run from package deploy option? https://docs.microsoft.com/en-us/azure/app-service/deploy-run-package#enable-running-from-package
I have found similar older issue https://github.com/projectkudu/kudu/issues/2849

@ashmind Have you tried with the above option ?

@ashmind Any update here ?

Since there has been no response, we are closing the issue. Please feel free to reopen in case of any queries. Thanks.


Chocolatey package for Windows

It would be nice to have a Chocolatey package for Windows as per comment from @gitfool in #3

There is a crd2pulumi package in the moderation queue in chocolatey.org right now


Added new ActionType

New action type is required so that we can send cases to field. The name of this new action type? SOCIALICF. Say hi!

 SUS010: Send Not Completed Cases to FWMT (Operational) (8)


- number sign key code

First - thank you for publishing this software! Making the caps lock useful is fantastic.
I wonder if you could add the number sign (#) to your list of key codes, or let us know what it is (or say how key codes can be found)?
I'm in the UK, so I need to use alt-3 to get a # and it really isn't the easiest key stroke (particularly with a broken wrist :-) ) and mapping it to the caps lock would be awesome.

You cannot specify a character directly in Seil.
You have to change your caps lock to alt-3 by the following procedure.

Step 1: Change your caps lock to normal key such as f19 (keycode 80) by Seil.
Step 2: Change f19 key to alt-3 by Karabiner. Use new setting by this private.xml.
https://github.com/tekezo/Files/blob/master/Karabiner/private.f19_to_alt_3/private.xml

How to use private.xml:
https://pqrs.org/osx/karabiner/document.html#privatexml

Got it - thanks!


fix(autoware_traffic_light_arbiter): fix missing include file

Description
This fixes the failing build-and-test action in the main branch. https://github.com/autowarefoundation/autoware.universe/actions/runs/11586899175/job/32258240074
Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

Closing this as it is a duplicate of https://github.com/autowarefoundation/autoware.universe/pull/9186


dimod.higherorder.utils.make_quadratic gives inconsistent / incorrect results

Description
D-Wave has indicated at least two approaches for reducing higher order terms to quadratic, namely Reduction by Substitution and Reduction by Minimum Selection. Both of these are shown to be mathematically correct approaches.
The issue is with the make_quadratic function. The function has at least one clear bug, which is that it returns completely different results if vartype = 'BINARY' or dimod.BINARY, which according to the vartype documentation those should both be identical.
For the trivial example case higher order polynomial:
poly = {(0, 1, 2): 10}
If vartype = dimod.BINARY, we get the following output:
BinaryQuadraticModel({0: 0.0, 1: 0.0, '0*1': 3.0, 2: 0}, {(0, 1): 1.0, (0, '0*1'): -2.0, (1, '0*1'): -2.0, ('0*1', 2): 10}, 0.0, Vartype.BINARY)
This is exactly what you would expect if we were using the Reduction by Substitution approach. However, if vartype='BINARY', we get the following output:
BinaryQuadraticModel({0: -5.0, 1: -5.0, '0*1': -5.0, 'aux0,1': -8.0, 2: 0}, {(0, 1): 2.0, (0, '0*1'): 2.0, (0, 'aux0,1'): 4.0, (1, '0*1'): 2.0, (1, 'aux0,1'): 4.0, ('0*1', 'aux0,1'): 4.0, ('0*1', 2): 10}, 9.0, Vartype.BINARY)
Steps To Reproduce
import dimod

poly = {(0, 1, 2): 10}
bqm = dimod.make_quadratic(poly, 1.0, 'SPIN')
print(bqm)
print('\n')
bqm = dimod.make_quadratic(poly, 1.0, 'BINARY')
print(bqm)
print('\n')
bqm = dimod.make_quadratic(poly, 1.0, dimod.SPIN)
print(bqm)
print('\n')
bqm = dimod.make_quadratic(poly, 1.0, dimod.BINARY)
print(bqm)
print('\n')

assert dimod.make_quadratic(poly, 1.0, 'SPIN') == dimod.make_quadratic(poly, 1.0, dimod.SPIN)
assert dimod.make_quadratic(poly, 1.0, 'BINARY') == dimod.make_quadratic(poly, 1.0, dimod.BINARY)

Expected Behavior
I would expect 3 things that are currently missing in the code:

Consistency: the two assert statements in the code above should always be true.
Clarity: documentation should make clear either the option to choose the reduction method, or clarify which reduction method is being used explicitly.
Correctness: a unit test is required that validates the exact expected output for several different input QUBOs / Ising Hamiltonians.

A final note: it seems inconsistent that somehow make_quadratic requires only 1 ancilla qubit for BINARY and 2 ancilla qubits for SPIN, as converting between the two expressions require no ancilla qubits whatsoever.
Environment

OS: Mac High Sierra 10.13.6
Python version: Python 3.7.4

Additional Context
No additional context required.

The inconsistent behaviour comes from problems parsing the vartype input, this fixed by #551.
For the documentation, we do use the "substitution" method. I agree the documentation should call that out. One problem is (as you noticed) we use different substitutions for BINARY and SPIN. We could convert all polynomials to BINARY and use the substitution method in the docs, but this would actually increase the density of the resulting BQM, relative to doing the substituion in SPIN-space (which requires an additional aux variable). This should all be documented with examples.

Adding to this as my issue seems related.
I am using the make_quadratic function and it seems like the output is inconsistent over multiple runs of the program. For example, running the following:
poly = {(1,2,3,4): 2} bqm = dimod.make_quadratic(pubo_dict, 5, dimod.BINARY)  print (bqm.variables)
sometimes produces a model with bqm.variables equal to Variables([1, 3, '1*3', 2, 4, '2*4']) and other times equal to Variables([1, 3, '1*3', 2, '1*3*2', 4]). Any idea what's going on here?

I have not been able to reproduce, I always get Variables([3, 4, '3*4', 1, 2, '1*2']). What version of Python/dimod are you using?

I have tried with both Python 3.7.13 and 3.10.3 with dimod 0.11.6. You may have to run it a few times to see the consistent behavior (and of course, if you're using a notebook make sure to reset kernel).


Support server variables and multiple servers

https://swagger.io/docs/specification/api-host-and-base-path/

We've supported this for a while now.


Time function in sAddNote should be lowercase

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-15070.
Please use this issue to track the state of your pull request.

Thanks for your PR. Merged with 377dd1e7d8b.


PacReq: Vesktop

Types
-git (Compiled off of the latest commit of the package), -deb (Debian achieve release of the package)
URL
https://github.com/Vencord/Vesktop
Building guide
https://github.com/Vencord/Vesktop?tab=readme-ov-file#building-from-source
https://github.com/Vencord/Vesktop/releases
Additional context
discord's offical app has in my experience pretty jank support for linux most of all screensharing which vesktop does a lot better :3
(first link for build guide, second for deb's)

Weirdly enough, I wrote the pacscript before reading your package request, but was hesitant to submit it because although I'm currently daily-driving it, I'm not sure if I will use it forever, but yeah I have summited PR #6207, so if everything goes fine, it should be available in the pacstall repo soon.

yay thats sick! will close :3


Add support for capability element

The plugin does no support the capability element, something like the following is needed when defining a feature:
<feature name="aries-blueprint" description="Aries Blueprint" version="4.0.1">
	<feature prerequisite="false" dependency="false">aries-proxy</feature>
	<bundle start-level="20">
		mvn:org.apache.aries.blueprint/org.apache.aries.blueprint.api/1.0.1
	</bundle>
	<bundle start-level="20">
		mvn:org.apache.aries.blueprint/org.apache.aries.blueprint.cm/1.0.6
	</bundle>
	<bundle start-level="20">
		mvn:org.apache.aries.blueprint/org.apache.aries.blueprint.core.compatibility/1.0.0
	</bundle>
	<bundle start-level="20">
		mvn:org.apache.aries.blueprint/org.apache.aries.blueprint.core/1.4.3
	</bundle>
	<conditional>
		<condition>bundle</condition>
		<bundle start-level="30">
			mvn:org.apache.karaf.bundle/org.apache.karaf.bundle.blueprintstate/4.0.1
		</bundle>
	</conditional>
	<capability>
		osgi.service;effective:=active;objectClass=org.apache.aries.blueprint.services.ParserService, osgi.extender;
		osgi.extender="osgi.blueprint";uses:="org.osgi.service.blueprint.container,org.osgi.service.blueprint.reflect";version:Version="1.0"
	</capability>
</feature>

Hello,
Thank you for the interest but as you've seen I haven't invested in this plugin. It is no longer maintained. I don't have another option for you.

Sorry, yeah I post on the wrong repo.


Jira integration for Lyft Hackathon

adding a stub for jira integration

Codecov Report

Merging #350 into master will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   75.46%   74.62%   -0.84%
==========================================
  Files         156      130      -26
  Lines        3847     2688    -1159
  Branches      483      387      -96
==========================================
- Hits         2903     2006     -897
+ Misses        912      678     -234
+ Partials       32        4      -28

Impacted Files
Coverage Δ

amundsen_application/api/metadata/v0.py

amundsen_application/log/action_log_callback.py

amundsen_application/api/__init__.py

amundsen_application/api/utils/request_utils.py

amundsen_application/api/mail/v0.py

amundsen_application/base/base_preview_client.py

...ndsen_application/base/base_announcement_client.py

amundsen_application/wsgi.py

amundsen_application/log/action_log_model.py

amundsen_application/api/search/v0.py

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824016b...971685c. Read the comment docs.

@csteez cleaning up this repo a bit. Is it alright to close this PR since the real one is in review?

Closed!


Implement the layout for integrating the search for international results

Reason (Why?)
The usefulness of einander-helfen.org depends on the versatility of the results. We want to be able to offer international, as well as national, results.
Solution (What?)
On the home and result pages both in web and mobile view the pin icon to the left of the location search bar should be replaced by the german flag, with a small triangle next to it to indicate it being a dropdown.
When clicking on it, a dropdown with one option "Weltweit" with a globe icon next to it should expand.
When clicking on "Weltweit" the dropdown collapses again, the german flag icon is switched to the globe icon in the location search bar. The text inside the location search bar changes from "Ort oder PLZ" to "Land oder Kontinent", the radius field gets grayed out/disabled.
Out of scope
Only the layout should be implemented here. The actual filtering of the posts/searching for international results will be implemented with another (backend) issue.
Relation to other Issues
#224
#247 implements the international search (backend).
Acceptance criteria
Home page web view:

Result page web view:

Result page mobile view:

Correct select size in tablet view
Edit smartphone header
Don't use radius in interntaional search

Correct select size in tablet view
Edit smartphone header
Don't use radius in interntaional search

Add the image sources for germany and international to the imprint.

Add the image sources for germany and international to the imprint.


feat: MuSig2* signing

This appears to be working, but I need to do some additional input verifications, switch from dynamic to fixed test vectors, and add some non-happy-path tests.

Why don't we make a new package out of this?

@paulmillr started on new-packageifying it: https://github.com/brandonblack/musig-js -- happy to make it a noble-crypto package if you want, don't know your process there.


TemplateDoesNotExist: cannlytics_website/pages/coas.html, cannlytics_website/pages/coas/coas.html

Error likely due to adding CoA page placeholder:
django.template.exceptions.TemplateDoesNotExist: cannlytics_website/pages/coas.html, cannlytics_website/pages/coas/coas.html, cannlytics_website/pages/general/coas.html
at select_template (/usr/local/lib/python3.8/site-packages/django/template/loader.py:47)
at resolve_template (/usr/local/lib/python3.8/site-packages/django/template/response.py:63)
at rendered_content (/usr/local/lib/python3.8/site-packages/django/template/response.py:81)
at render (/usr/local/lib/python3.8/site-packages/django/template/response.py:105)
at _get_response (/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py:143)
at _get_response (/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py:145)
at inner (/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py:34)

No current plans for a CoA page on the website.


Remove version: DeaDBeeF.DeaDBeeF version 1.9.6

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: URL works;


Bug: Repos with long names get cut off

Describe the bug
Repos with longer names get cut off when viewing an insight page:

This makes for a tricky user experience: I'm really not sure exactly which repos are which.
Steps to reproduce

Create an insight page with repo names that are long
See the insight page and notice the names getting cut off

CC @isabensusan - more feedback 😅 nothing urgent, just a sharp edge
Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

Thanks @nickytonline 🙈

I am not really sure what could be a possible solution for this, maybe wrapping the text?

This issue relates to #1763. We can also look at the size of the repository name and see if we can let that input grow without overlapping other UI and use that in conjunction with ellipsis mentioned in #1763. cc: @OgDev-01

@nickytonline can you please review the changes I have made. I think it fixes the issue.
Also, for some reason my previously merged commits are also being shown in the pull request, is that an issue ?

@aryanas159, we get notified for reviewing things in GitHub, but it doesn't mean we review everything immediately.
Thanks again for contributing to the project!


python310Packages.aiobiketrax: 0.2.1 -> 0.3.0

Description of changes
https://github.com/basilfx/aiobiketrax/blob/master/CHANGELOG.md#v030

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 196323 run on x86_64-linux 1

2 packages built:

python310Packages.aiobiketrax
python39Packages.aiobiketrax


Want be a member

Hi @sseemayer , I want to be member of this project. do you approve?

Thanks for your willingness to contribute! I am happy to receive your pull requests for now. We can discuss about granting merge privileges after some more interactions, ok?


Refactor

Thanks for the pull request - are you guys using the library for a real app?
Happy to accept the pull request if its working, I'm not working on this library anymore...

Yeah, we forked it to use babel and such. It's not quite ready to be used by other people.
Some current things I want to change before we merge are,

[ ] babel register is not optional, so even if you pre-babel it still requires the hook.
[ ] The render to static string option is passed using res.local, not sure if i enjoy this more or less than how reactjs has theirs. The problem I saw with them is that it either always is static render for every route, or the normal render. No choosing in the route.
[ ] I'm worried a layout component is not optional, even though i meant it to be.
[ ] I would like options to be passed as an object instead of how they currently are, so the engine creator function is easier to modify.
[ ] I would like an example document showing how to use this with another engine like pug.

I meant to merge into my own master. After I complete these I will reopen the pull request.

Yeah, we forked it to use babel and such. It's not quite ready to be used by other people.
Some current things I want to change before we merge are,

[ ] babel register is not optional, so even if you pre-babel it still requires the hook.
[ ] The render to static string option is passed using res.local, not sure if i enjoy this more or less than how reactjs has theirs. The problem I saw with them is that it either always is static render for every route, or the normal render. No choosing in the route.
[ ] I'm worried a layout component is not optional, even though i meant it to be.
[ ] I would like options to be passed as an object instead of how they currently are, so the engine creator function is easier to modify.
[ ] I would like an example document showing how to use this with another engine like pug.

I meant to merge into my own master. After I complete these I will reopen the pull request.
EDIT: In other news, don't send markdown from email. Seems to not get built.


IS there a plan to make toc for this theme?

Thank you for this beautiful theme, I really love it and appreciate your great work.
But recently I've been working on adding toc for my blog, Although there is an official tutorial for this, But I failed many times , because this theme is a little different from other themes.
here is the tutorial:
https://ghost.org/tutorials/adding-a-table-of-contents/?_ga=2.8856117.1440588615.1584581452-1250222531.1584338288
And I went into trouble at this step:
<script>
    tocbot.init({
        tocSelector: '.toc',
        contentSelector: '.post-content',
        hasInnerContainers: true
    });
</script>

my blog indicates that it does not have the ".post-content" element, so the toc can not be established.
So I wonder if you would plan to do this?

Hi 👋
I don't have plans to give native support for this since a very few people might need it and because you can integrate it for yourself if needed.
To solve the issue you just need to use .js-post-content instead of .post-content

@eddiesigner Thank You so much, I fixed this problem according to your suggestion. Close this issue.
IF anyone run into the same problem , please follow the suggestion above.


Create a package with various mixins and base classes

So in tickets here we have quite some interesting mixins which should probably be collected into a package and documented. This package could also be then available to others to easily add their stuff. So something like "contrib" package or something.
What mixins or base classes or base class features would you like to see?

Also, it would be useful to document that one should create always their own base class and extend that one for components. So it is easy then to add global methods and other common stuff there.

I made https://github.com/peerlibrary/meteor-blaze-common-component.

Documentation published: https://peerlibrary.github.io/meteor-blaze-common-component/


Vue 3 support

Please I'm just curious, when is Vue 3 support coming?
I feel stuck choosing to use Vue 3 instead of 2. There aren't much OSS work on Vue 3 out there yet. I'm just tired having to do everything myself because there's mostly no Vue 3 support yet.

This. It looks like an epic project but it's a shame it doesn't support vue 3 yet.

update: it turns out <input type="color"> exists. And it also turns out I have spent too much time looking for vuejs colour pickers.

I've created a fork for Vue 3 for those who want to migrate over from Vue 2.
npm package: https://www.npmjs.com/package/verte-vue3
Repo: https://github.com/aiming-pro/verte-vue3


2.6.0-beta.2: IE11 loses space around equation

As reported at math.stackexchange, the expressions in IE11 are missing some space around them.
This is due to this line.  It appears that there are two things involved:  (1) the border-spacing:3px isn't having any effect (so the padding:-3px is reducing the space uncompensated by the boarder), and (2) the body element has the focus initially, which triggers this CSS rule.

I think the main solution is to remove the border-size and padding statements and go back to the tight bounding box.
But I still don't like the rule being triggered by the body element being focused.  The *:focus .MathJax rule was to handle the problem with links that contain math not having the right outline.  So perhaps a rule triggered by *[outline] .MathJax would do it.

OK, *[outline] .MathJax doesn't work, but body :focus .MathJax seems to work better (this only triggers if a child of the body element is focused, not the body itself).
A similar change news to be made to CommonHTML as well.

Also, border-spacing is the wrong attribute.  It should probably be border-width.  I'll have to check to see if that works, but it may be best to remove the extra spacing in any case.

The issue1338 branch of my fork of MathJax includes a fix for this.

=> Merged.


Changelog should say angular requires 1.24

As of https://github.com/dart-lang/angular/commit/991eab32a663604d6f76488b8becf75f4371b32b, the angular package requires the 1.24 SDK. We should explicitly say so in the changelog.
Maybe it should be under breaking changes?

Given that we are unlikely to push another 4.x, I'm closing as infeasible :-/


Can the tuya.force_update from Home Assistant be used for pushing custom firmware?

Before opening a new issue, please read the following
Are you reporting a successful flash?
Please add it to the wiki instead!
No
Do you have a question about configuring your newly flashed device?
Please ask in your alternative firmware's support channel instead!
Yes
Did you have issues getting a device to flash?
Please be sure to include your device name, model, and firmware version as well as your logs!
Yes, BSD29 Smart Plug
Please remember to close your issue when the problem has been addressed!
I was unable to get the BSD29 UK Smartplug flashed. It does get connected to the vtrust network but the "Dots" keep on running.  Hence, I configured the Smartlife and got this Smartplug connected to Home Assistant.  I realized that Home Assistant recognizes a Service called "Force_update" from Tuya. I assume that calling this service would update the latest firmware to Smart Plug.  Hence,  I was wondering, if somebody can decode the JSON data to be passed through this "Force_update" service which would update the Smart Plug with custom firmware like Tasmota or ESP Home

Unfortunately no, according to the docs the "force_update" service is actually for refreshing device information so update in this sense refers to updating account information.
https://www.home-assistant.io/components/tuya/

Thanks @EverythingSmartHome for looking into this.


[MM-11422] Fix show more/less text, add gradient on cutting off attachment and reduce height of attachment text preview

Summary
Fix show more/less text, add gradient on cutting off attachment and reduce height of attachment text preview
Ticket Link
Jira ticket: MM-11422
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)
[x] Has UI changes

Screenshots:
[Commit 1 - old]

[Commit 2 - similar behavior as long post]
https://youtu.be/FmUHS9zaRlg

@esethna Please have a look on the height of attachment's text and small gradient when cutting off the preview.

Thanks @saturninoabril, what was used for the max attachment height? Is it consistent with what we had before this bug fix?
@asaadmahmood please also have a look for styling and make any tweaks you feel necessary. I'm wondering if we want to use the same
"show more"/"show less" buttons we use for long posts?

We don't have a defined max height before since it depends on text length or number of multilines which may vary if it happened to have embedded image or other markdown implementation.  The max height now is just a close approximation of what might be expected.  Please update as necessary.  Thanks!

Okay thanks, moving this to 5.3 as I think it's going to require more testing and most likely some UI tweaks

This is a subsequent fix to https://github.com/mattermost/mattermost-webapp/pull/1467.  I think it's better to have this for v5.2, especially because of reverse implementation of "show more/less".

@esethna We have just talked about being consistent in the permalink previews, so lets start from here. The gradient does feel off, it's probably not of the same height/value as the long post gradient.
We should use the same styling as the long post show more button here instead of the link.

OKay cool. @saturninoabril can you help make that update to the "show more/less" component from long posts, and then Asaad can take a pass at the CSS to clean it up

Changing milestone to 5.2 as this fixes the regression with the show more/less buttons being reversed

Sure, I'll start with this early tomorrow.  Thanks @esethna and @asaadmahmood!

@esethna @asaadmahmood PR is now updated with similar behavior of long posts and attachment.text.  See updated screenshots and screen capture above.
There are lots of code changes.  You might want to request for QA smoke test before merging to v5.2.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-00ee3fa3e6abf9a6d.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-00ee3fa3e6abf9a6d

@esethna @asaadmahmood To easily test, I set up the server and post to incoming hooks (with long embedded message and attachment text) and a long regular post.

@saturninoabril can you assign someone else as a reviewer, I won't have time to review this today

Spinmint test server destroyed


[BUG]: wrong state class being used for _energy_used_average and _energy_used_total?

Describe the bug.
The following error pops up in the HA log:
Entity sensor.st3_pinion_sammy_energy_used_average (<class 'custom_components.stromer.sensor.StromerSensor'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/CoMPaTech/stromer/issues
Entity sensor.st3_pinion_sammy_energy_used_total (<class 'custom_components.stromer.sensor.StromerSensor'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/CoMPaTech/stromer/issues

What version of Home Assistant Core has the issue?
2023.12.0
What was the last working version of Home Assistant Core?
2023.12.0
What type of installation are you running?
Home Assistant OS
How did you install the stromer integration
HACS
Logging
No response
Diagnostics information
No response
Additional information
No response

I'll look into it!

I've deleted the integration, updated to 0.2.8 and readded my account, but the same error is still there?

I'm trying to test 0.2.9a1 myself on my dev instance first ... if you are anxious to test it, apply the 'show beta' trigger in HACS.

Sry, didn't spot it auto-closing the issue

0.2.9a1 seems to be OK now over here. I've completely removed the integration, removed LTS from the sensors, reinstalled 0.2.9a1 and the error is gone now.

ok, I'll push it to release than as 0.2.9 - thanks for reporting & testing


bulb model mod files should be compiled with NMODL (as well as OpenACC backend)

Mod files can be found in :
/gpfs/bbp.cscs.ch/project/proj16/kumbhar/pramod_scratch/modeldb-bulb3d-sim/sim

I assume that this is no longer valid, as we have been testing https://github.com/HumanBrainProject/olfactory-bulb-3d with CoreNEURON, including multiple combinations of NMODL/MOD2C/OpenACC/OpenMP target offload.


c.actions is not iterable

TypeError: c.actions is not iterable
at i.f in src/vs/workbench/contrib/codeActions/browser/codeActionsContribution.ts:109:38
at i.c in src/vs/workbench/contrib/codeActions/browser/codeActionsContribution.ts:97:44
at d.a in src/vs/workbench/contrib/codeActions/browser/codeActionsContribution.ts:85:9
at d in src/vs/workbench/services/extensions/common/extensionsRegistry.ts:144:9
at d.acceptUsers in src/vs/workbench/services/extensions/common/extensionsRegistry.ts:135:8
at W.Ib in src/vs/workbench/services/extensions/common/abstractExtensionService.ts:1095:18
at Y.Fb in src/vs/workbench/services/extensions/common/abstractExtensionService.ts:1025:30
at Y.eb in src/vs/workbench/services/extensions/common/abstractExtensionService.ts:298:8
at async Y.db in src/vs/workbench/services/extensions/common/abstractExtensionService.ts:225:5

Go to Errors Site

https://github.com/microsoft/vscode/blob/b141c5accd99034811099fb30ae856e997db14dc/src/vs/workbench/contrib/codeActions/browser/codeActionsContribution.ts#L109
maybe add additional check here for contribution.actions or contribution. had 43,000 hits

closing, as we haven't seen this happen in the last 27 or so days.


getRequestURL(event).href does not return the right protocol

Environment
Node: 20.10.0
h3: 1.9.0
Reproduction

Host a Nuxt server with HTTPS
Create a server route, e.g. server/api/test.get.ts that logs getRequestURL(event).href
Open https://example.com/api/test in a browser

Console output should be https://..., but instead is http://...
Edit: Create example:
import {
  getRequestProtocol,
  getRequestURL
} from 'h3'

export default defineEventHandler(async (event) => {
  return [
    getRequestProtocol(event),
    getRequestURL(event)
  ]
})

Additional context
See Atinux/nuxt-auth-utils#30

Source for getRequestProtocol

Not a bug, my bad. Forgot that my server was behind a Nginx proxy and I forgot to pass the X-Forwarded-Proto header in my configuration.


Resource Factory update

Is this a good time to bring in the project factory module?
I'd postpone to a new PR since README is still missing. Will TAL at it today.


More robust recursion in Group.getAllChildren()

The current implementation is hard-locked to just check for Group, via objType()==="Group". This means it doesn't play well with extreme group derivatives, such as the forthcoming buffered rendering plugin. It would be better to check for children that implement getAllChildren() themselves.

Addendum thought: There's a possibility of getting infinite loops if the group derivative doesn't prevent such behavior. For example, buffers can form simple feedback loops, although they cannot self-feedback in a single step. We should at least point out that getAllChildren() implementations should self-avert in some fashion.


Need an option to disable the render of items in the curios slots/cosmetic armor slots

So, things put into curious mod slots or cosmetic armors mod slots stay visible, even if you disable the render of 'logically' connected part (by that I mean wearing a cosmetic hat, for example, results in it being seen in first person view, despite rendering of the head being disabled, which becomes quite obnoxious).
For now, I fix it by simply hiding the item. That means its effects are still applied, even though you can't see it, but it would be so much better to just not render the item in FPV.
btw it would be awesome to see the wiki page update

Also hoping for this to get updated.
Maybe add a disable option to not render curios slots in "Model Parts With Rendering Disabled". (the option "slot_head" doesn't seem to disable rendering of curios slots. Although the Disable Settings says that there may be other options not listed in the tooltip)
The more problematic items for me are:
All "Head" Items from the "Artifacts" mod
Gloves from the "Aether" mod which render a gloved hand on the screen when you aren't holding anything. (May be fixable in Disable Settings somehow, but I cant find how as of now)


Add validation for GRPC types

Goal of this PR
Fixes #341
For now, this PR will most likely break on the CI because, at least on my side, following the install steps described on the project's repo did not succeed. I found ways to bypass that flakey install process however so I will experiment with this until I find the best way to install it on the CI.
TODO
Add tests that verify that given invalid requests, the endpoints fail as expected and return appropriate errors.
Checklist

[x] Is on the right branch
[x] Documentation is up-to-date
[ ] Tests are up-to-date

So I replaced the validation plugin with a tagging one, and it seems to work OK. Unfortunately the plugin is not perfect either, but I think it's satisfactory. If not, we can always revert to the previous implementation with the validator plugin. 👍


Alternative fallback

@primozcigler has developped a viable fallback for IE and Edge see here :
https://medium.com/@primozcigler/neat-trick-for-css-object-fit-fallback-on-edge-and-other-browsers-afbc53bbb2c3

Yes, I’ve seen this already, thanks. I’m going to add this as a note into the Readme. But please not this provides only the basic feature of object-fit, and behaves a bit differently so always test if it’s working the way you want it to. :)

Added to README here.

@mediaformat thank you!
As @anselmh mentioned, my fallback explained in article only supports subset of what is possible to achieve with object-fit. But AFAIK the most common use case :smile:

But AFAIK the most common use case :smile:

It is, so thanks again for building, documenting and publishing this lightweight alternative, @primozcigler! :)

This provides only the basic feature of object-fit
@anselmh True, I was thinking narrowly of my use case! Thanks for adding the note!

@primozcigler Thank you sir for the clever fallback!


Does the sample aad-api-spo-cookie work for Chrome?

Category

[ ] Question

Expected or Desired Behavior
Putting an AAD protected web site in iframe within SPO works for Internet Explorer and Chrome.
Observed Behavior
However, in Chrome, the iframe is rendered empty. After inspecting the console log, I see the following errors.  The page appears in the iframe for Internet Explorer and Edge but not Chrome.

Refused to display 'https://login.microsoftonline.com/... a frame because it set 'X-Frame-Options' to 'deny'.
Failed to load resource: net::ERR_BLOCKED_BY_RESPONSE

Steps to Reproduce

Simply drop an Page Viewer Web Part on any SharePoint page and point to your AAD protected web app
Browser it in Google Chrome Version 60.0.3112.113 (Official Build) (64-bit)

Question
Is this approach meant to work only IE?

I've just tried it and it's working correctly. At first, I'm getting an error, but after calling the API in a separate tab and then refreshing the workbench with web part on it, the call comes through.

Yes Waldek,  I have confirmed that if the user has not gone via the sign in process of the API app before this approach will not work in Chrome.
So from the end user experience perspective, the spfx web part has to provide a way to launch a separate browser tab to the API app first in order for this approach to work properly reliably.   Do you have any recommendation on how to properly roll out such web part to large number users without causing confusion?

I've tested the project locally where the certificate is not trusted. I suspect that this is what's causing this behavior. Have you seen the same behavior in a setup with a trusted certificate?

I have my API app deployed to Azure Web site.  All my testing is on the Azure web site.   I don't think the error has anything to do with certificate.
The sample aad-api-spo-cookie is based on the assumption that the iframe will never need to hit login.microsoftonline.com but in the reality when the cookie will expire, the iframe will have to take the user to via login.microsoftonline.com and that is when Chrome refuse to display.
Let me walk you through another scenario.  I have the Recent Order web part running on the workbench last Friday and was showing a list of orders on the screen,  today when I come back to the office and refresh the browser,  the web part display an error.  Reviewing the console reveals the browser is trying to take the user to login.microsoftonline.com and again Chrome refuse it.

In this case, it is by design that the browser refuse to serve the login page.   I suspect we have a false assumption here.

I understand what you're saying. It seems indeed that we stumbled upon a limitation of this approach, where it requires a valid cookie in order to work correctly. If the cookie expires, it cannot perform authentication because the login page cannot be displayed in an iframe.

So far this issue is happening in Chrome.

Hi Waldek,
I stumble upon this API /_api/SP.OAuth.Token/Acquire and I thought to myself that this would have been the best approach to consume secured web API from user experience and security.  No user redirect and no exposing refreshToken in the browser.  The unfortunate part of this API is that it only supports MS Graph resource.
Do you know if there is plan to support getting access token for other custom resource/api?

@larry-lau this is an internal endpoint meant for use by first party solutions. As far as I know there are no plans for a similar approach to obtain tokens for other resources.

I've the same issue, only in chrome as well, @waldekmastykarz there are some something new to fix this? The cookie approach is excelent to avoid the user login everytime that open a webpart, calling the azure API in a separate tab fix it but for the end user it is not viable. Thanks in advance, great job!

@MarianoPrz I'm not sure if this can be fixed in any way. The good news is, at Ignite the engineering team announced changes in this area where we will be able to call an API inside of the SharePoint Framework to obtain an access token for use with custom APIs. More details coming soon.

@waldekmastykarz Hi!  now it's work with the build 62 of Chrome, and not setting display none in the iframe ( despite this the iframe doesn't appear ) so its work great for me. There is an approximate date of the changes announced by the Ignite team? thanks for answering!

@MarianoPrz great to hear it's working. Unfortunately, at this point there are no specific dates, but as mentioned by the team during Ignite, it should be coming soon. Stay tuned!

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”


Update slf4j to 1.8.0-beta4

Because of CVE-2018-8088, we need to upgrade slf4j to 1.8.0-beta4.
Hope this helps.

Note that the build is failing on my laptop with:
[WARNING]
Dependency convergence error for org.jvnet.staxex:stax-ex:1.8.1 paths to dependency are:
+-org.apache.tika:tika-parsers:2.0.0-SNAPSHOT
 +-org.glassfish.jaxb:jaxb-runtime:2.3.2
   +-org.jvnet.staxex:stax-ex:1.8.1
and
+-org.apache.tika:tika-parsers:2.0.0-SNAPSHOT
 +-org.apache.cxf:cxf-rt-rs-client:3.3.0
   +-com.sun.xml.messaging.saaj:saaj-impl:1.4.0-b03
     +-org.jvnet.staxex:stax-ex:1.7.8

[WARNING]
Dependency convergence error for javax.xml.soap:javax.xml.soap-api:1.4.0 paths to dependency are:
+-org.apache.tika:tika-parsers:2.0.0-SNAPSHOT
 +-org.apache.cxf:cxf-rt-rs-client:3.3.0
   +-javax.xml.ws:jaxws-api:2.3.0
     +-javax.xml.soap:javax.xml.soap-api:1.4.0
and
+-org.apache.tika:tika-parsers:2.0.0-SNAPSHOT
 +-org.apache.cxf:cxf-rt-rs-client:3.3.0
   +-com.sun.xml.messaging.saaj:saaj-impl:1.4.0-b03
     +-javax.xml.soap:javax.xml.soap-api:1.4.0-b01

I'm not sure this is related to my change.

I opened #269 to hopefully fix the build failure I got on my laptop.

@dadoonet, convergence error is unrelated but thanks for bringing it up.
As for CVE-2018-8088, issue is related to slf4j-ext which isn't used by Tika at all.
Also, if you're interested in changes in Tika's logging see TIKA-2566. I think we'll update to slf4j-api 1.8.0 when it's released if we choose option to stay with slf4j. Primary reason for update to 1.8.x is JPMS/Jigsaw but I guess we aren't there yet.

@grossws AFAICS this discussion is related to 2.0 right?
In the meantime do we plan to fix this for 1.x branch? If so, should I propose the patch on https://github.com/apache/tika/tree/branch_1x instead?

@dadoonet it applies equally to 1.x and 2.x since both are on slf4j 1.7.25 and both don't use slf4j-ext, so CVE is irrelevant.
There's no rush to update slf4j-api and related deps right now. I hope we'll have a decision about logging (using slf4j or log4j2 as api) soon and will do a relevant update after that. Currently there's no strong reason to use 1.8.0-beta4.

Ha! That's very true. I did not notice that the problem was located in slf4j-ext.
The CVE detection plugin sent a false positive then. I'm going to report that.
Thanks a lot!


Grafana -  Error budget line changes

Hi,
Any ideas what would cause the following to have the error budget line change (This should be a constant)

Also notice the duplicate legends at the bottom.
Any tips are appreciated.
Thx

The issue was the Kubernetes API in Azure. This is now fixed.


Review ethereum related methods

DelegatedAddress is not meant for Ethereum wrapped only. It will serve for any user defined address. For that reason, it should not have ethereum related methods like
https://github.com/Zondax/izari-tools/blob/431e366bb7e9a4ebc604c01b9e772f8b8123ab22/src/address/index.ts#L598-L602

closed in #56


Exclude arbitrary page from sitemap via dashboard

It would be handy to allow staff to exclude an arbitrary page from the sitemap via the dashboard.
Currently the only approach for this that I can find mentioned in the docs is overriding the get_sitemap_urls.  For some pages, it is difficult to determine that a page should be hidden or shown in the sitemap and it would be nice if the page model had a boolean exclude_from_sitemap field for this.
If you do not want to add a field to the Page model, it could be implemented in the sitemap contrib module without touching the Page model... but it would be more convoluted to create a snippet model to control SitemapOptions and autoregister an edit handler for displaying an InlinePanel edit handler than it would be to add a boolean field to the page model.

Adding clarification, the overriding of get_sitemap_urls works and was resolved in #3504 as of Wagtail 1.10.
The enhancement of disabling an arbitrary page in the dashboard has not been implemented and needs a decision if this is something that should be, or leave it to individual developers to implement as they see fit.


Pluploader-1: New commands

This PR adds the commands list, info, enable and disable.
ToDo:

[x] Adjust README.md
[x] Increase Version
[x] Release?

A release will be prepared on the target branch


AutoDetect should get a file listing to check if it works

AutoDetect can sometimes return a wrong profile. This can only be solved by getting a file listing. If it disconnects or returns a blank listing for the root folder then the connection must be determined to have failed.

Added to the bucket list. We will pick this up as and when we have free time. Comment on this issue if you want us to prioritize it. Thanks!


python-can vs socket

Curious as to why you decided to the socket interface as  opposed to python-can?

As these motors are used with a CAN-to-USB converter which interfaces using SocketCAN, the python-can library would also use socket in the background. As socket is a basic python library, using it instead of python-can reduces the number of external dependencies required for this driver. I'm also planning to get rid of the bitstring library so that the driver is standalone in the future. I also have a C++ version of this driver which has zero other dependencies and I am planning to make a python version also with dependencies.

Got it that makes sense!
On another note, have you ever had issued with the encoder giving you an unexpected value after a power cycle? I'm running into issues where say the encoder has value x when the power is on, if the power is turned off and motor does not move, the encoder value on powering it back on is significantly different than x