Sorting function doesn't need int() conversion

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":

Search the issues already opened: https://github.com/googleapis/python-documentai-toolbox/issues
Search StackOverflow: https://stackoverflow.com/questions/tagged/google-cloud-platform+python

If you are still having issues, please be sure to include as much information as possible:
Environment details

OS type and version:
Python version: python --version
pip version: pip --version
google-cloud-documentai-toolbox version: pip show google-cloud-documentai-toolbox

Steps to reproduce

?
?

Code example
wrapped_document = document.Document.from_gcs(
    gcs_bucket_name=gcs_bucket_name, gcs_prefix=gcs_prefix
)

Stack trace
File ~/miniconda/lib/python3.10/site-packages/google/cloud/documentai_toolbox/wrappers/document.py:70, in _entities_from_shards.<locals>.<lambda>(x)
     67     page_offset += len(shard.pages)
     69 if len(result) > 1 and result[0].documentai_object.id:
---> 70     result.sort(key=lambda x: int(x.documentai_object.id))
     71 return result

ValueError: invalid literal for int() with base 10: 'e6a445871928ed89'

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

Actually, on second thought, the int conversion should actually be used for _entities_from_shards() because the entity.id field is a string in the Document object, and these need to be sorted in numerical order.
Can you upload a sample Document json file that causes this issue? (With any PII removed)
Are these Documents imported from a 3rd party service and converted into the Document AI format?

I can't upload the doc as they are very sensitive. They are uploaded into GCS and then imported in to generate the training set in the UI of DocAI

Ok, what is the source of the Documents? Are they output from Document AI, HITL, Warehouse, something related? Or are they created from a different service?

Ok, that's very interesting. So those IDs are the result of auto-labeling with Document AI Workbench. I think it could make sense to either:

Only perform sorting if the IDs are numeric
Remove sorting altogether (Most of the time, I don't think it will be necessary)

Very cool! Thanks!


SDL_GetModState doesn't work properly on windows 10

hi,
SDL_GetModState give bad value when the numlock key on numeric pad is on.
It's ok when the num lock is off.
I attach a piece of code below to demonstrate that problem :
#include <SDL2/SDL.h>

#include <stdio.h>

int main(int argc, char **argv){

   SDL_Surface *surface = NULL;
   SDL_Renderer *renderer;
   SDL_Event event;
   SDL_Window * window ;
   uint8_t quit=0;

  SDL_Rect rect;
  SDL_Init(SDL_INIT_VIDEO);

  window = SDL_CreateWindow("LSHIFT", 100, 100, 640, 480, SDL_WINDOW_SHOWN);
  renderer = SDL_CreateRenderer(window, -1, SDL_RENDERER_ACCELERATED);
  SDL_SetRenderDrawColor(renderer, 255, 0, 0, 255);
  SDL_RenderClear(renderer);
  SDL_RenderPresent(renderer);
  while (!quit) {
       	SDL_PollEvent(&event);
	switch(event.type)
        {
	    case SDL_QUIT:{
		    break;
	    }
	    case SDL_WINDOWEVENT:{
		    switch (event.window.event)  {
		    case SDL_WINDOWEVENT_CLOSE:  {
			    quit=1;
		    }
		    }//switch event.window.event
		    break;
	    }//switch SDL_WINDOWEVENT
            case SDL_KEYDOWN:
	    {
	         if (event.key.keysym.sym==SDLK_KP_PERIOD)
	         {
		    int k = SDL_GetModState();
		    printf("key %i %i \n" , k & KMOD_LSHIFT , k & KMOD_NUM);
	         }
	    }
        }//switch event type
    }//!quit
    SDL_Quit();

    return 0;
}//main

the printf result will be :
0 4096 when left shift is down and num lock on instead of 1 4096
1 0 when num lock is off as expected
Thank for your help

This got moved to https://github.com/libsdl-org/SDL/issues/4893, closing this copy.


Bot Framework Composer: Error Accessing Nested JSON Properties

Describe the bug
When attempting to access the 'data' property from a JSON response in Bot Framework Composer using turn.results.text, the path returns empty. Direct access and expressions such as ${json(turn.results.text.content.data)} lead to an "Operation returned an invalid status code 'BadRequest'" error.
My web app use to return the response in 'message' field and I was able to retrieve it via :  ${turn.results.content.data.message}
Recently, I started getting "Operation returned an invalid status code 'BadRequest'".  The structure of ${turn.results} has changed to:
{ "lgType": "Activity", "text": { "statusCode": 200, "reasonPhrase": "OK", "headers": { "Date": "Mon, 22 Jan 2024 04:58:15 GMT", "Server": "gunicorn" }, "content": { "data": "How can I assist you today? If you have any IT-related queries, need information from the company data, or have compliance-related questions, feel free to ask!" } } }
Attempts to access the data with ${getProperty(turn.results.text.content, 'data')} and ${turn.results.text.content.data} have been unsuccessful resulting in Operation returned an invalid status code 'BadRequest'
Additionally, ${turn.results.text.content} and ${turn.results.text} are returning empty.

Version

Version:  2.1.2
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[x ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Send an HTTP request and store the result in turn.results.
Attempt to access a nested JSON property turn.results.text.content.data,
Receive an empty response or an error.

Expected behavior

Screenshots

Additional context
The exact JSON response structure is as follows:
{
  "lgType": "Activity",
  "text": {
    "statusCode": 200,
    "reasonPhrase": "OK",
    "headers": {
      "Date": "Mon, 22 Jan 2024 04:31:39 GMT",
      "Server": "gunicorn"
    },
    "content": {
      "data": "It seems like there might have been a typo in your message. How can I assist you today?..."
    }
  }
}

@aymiee

What version of the SDK is the bot running?
Was there an update/migration to a newer version for this when it started happening?

Likely related:
https://stackoverflow.com/questions/77847235/inconsistent-display-of-array-property-in-bot-framework-composer-direct-vs-con/

Also confirmed:

Doing something like Results: ${turn.results} will display correctly without the lgType property.
Not related to channel (same behavior in Emulator, Test in Web Chat, Web Chat, Teams).

Thanks, I was told on Microsoft tech community that the issue was an update in the template engine used by the Bot Framework Composer.   I have since updated my flask backend to retrieve the content from the text key.
I also modified my Flask app to not encapsulate the response in a JSON object with 'data' as the key since the Bot Framework Composer already uses 'content' in the JSON structure.  I can now access value via ${turn.results.content}
{ "lgType": "Activity", "text": { "statusCode": 200, "reasonPhrase": "OK", "headers": { "Date": "Mon, 22 Jan 2024 04:58:15 GMT", "Server": "gunicorn" }, "content": { "How can I assist you today? If you have any IT-related queries, need information from the company data, or have compliance-related questions, feel free to ask!" } } }

Closing as the fix was merged in the SDK repository.


As per your request 'Free API List' is the main seo target phrase, so could we have that in the first sentence of the description please :)

Optimize HTML for SEO and performance 😊

@SuyashOP-2 sorry! I just seen

would it be possible to resolve the conflict?

@SuyashOP-2 I will close this pull request, please resubmit on issue #102

@SuyashOP-2 yes please, with the conflict resolved also


Transitioning from MDX via Tabs is very slow.

Please notice the delay from initial load and from tab to tab. Anyway to speed this up?

Well... The current logic is pretty hacky tbh... There are multiple iframe inside each other. To make this work much better, would be to use the storybook api. Unfortunately storybook does not offer such api so I had to go with this hack..

Thankfully, its MUCH faster when out of dev mode. thank you


2 FeignClient custom configuration conflict

I have two different feign client class but feign name is same(name = "service-feign")
@FeignClient(name = "service-feign",configuration=ForwardFeignConfiguration.class)
public interface SchedualServiceInfo3 {

	@RequestMapping(value = "/info3", method = RequestMethod.GET)
	String info3();

	@RequestMapping(value = "/info3", method = RequestMethod.GET)
	String newinfo3(@RequestHeader("Authorization")String  Authorization);
}

@FeignClient(name = "service-feign",configuration=SelfFeignConfiguration.class)
public interface SchedualServiceInfo4 {

	@RequestMapping(value = "/info3", method = RequestMethod.GET)
	String info3();

	@RequestMapping(value = "/info3", method = RequestMethod.GET)
	String newinfo3(@RequestHeader("Authorization")String  Authorization);
}

SchedualServiceInfo3 use the ForwardFeignConfiguration and SchedualServiceInfo4 use the SelfFeignConfiguration,but two all call the same one service(service-feign)
Running results show,two all  use SelfFeignConfiguration
I try to modify  SchedualServiceInfo3 FeignClient name ,call other service(service-feign2)
than  running results is right(SchedualServiceInfo3 use the ForwardFeignConfiguration and SchedualServiceInfo4 use the SelfFeignConfiguration )
so, Is it necessary to use the same configuration to invoke the same service, Even if the FeignClient class is different?

We don't support multiple @FeignClients with the same name. See http://cloud.spring.io/spring-cloud-static/Edgware.SR2/single/spring-cloud.html#_creating_feign_clients_manually for creating the clients manually.

@spencergibb Thank you very much. I understand.

No you would still have to create the Feign clients manually


Inventory

I'm unsure as to how I should properly proceed with an inventory. Should it be accessible at all points ? Should it only be available sometimes ? How should it be presented to the player ? How to have the player organize and edit their inventory ?

Issue was fixed, closing thread.


'zypper in' isnt critical command

i use mkcloud in system where inst zypper, and why use 'zypper in' in each run of mkcloud ?

-1 because it reverses a change which I just deliberately introduced and also breaks indentation. If the zypper in fails then we have no way of guaranteeing that things will work. I agree that it would be better not to run zypper in every run - there are 2 valid approaches to improving this:

Set the expectation that the user will ensure dependencies are installed before running mkcloud.  This is how almost all other software works.  In this case it is still worth checking that the dependencies installed at run-time.
Introduce the same run-time dependency checks as above, but install only the ones which are missing.

Simply reverting to an unchecked zypper in is non-defensive programming which relies on luck for things to work.  Don't do that.

this change breaks mkcloud on other systems , and run zypper in each round is ......

I wonder how exactly it fails... and why?

@bmwiedemann i use mkcloud for example on gentoo ..

OK, so we need to decide: will we support (or at least not obstruct) running mkcloud on other distros?  Personally I don't see a good reason for spending time worrying about gentoo, sorry.

Personally I don't see a good reason for install deps in mkcloud ...
i prefer remove this command from script ..

I'm OK with removing it but only if we add dependency checks, e.g. check that curl / wget / dnsmasq etc. are on $PATH, that libvirt and kvm are installed and so on.  It should be possible to write these checks in a distro-agnostic way.

how about this instead? https://github.com/bmwiedemann/automation/commit/1d47552d4c69c8058c62e04e53d9fc643d9a788a

@bmwiedemann  I agree with @aspiers , better remove + add to sanity check for curl/dnsmasq/kvm etc ..

should be working with non-SUSE OSes now.

It's helpful to reference the commit which justified closing this.  In this case I believe it was 1d47552d.

And BTW the right way to do this is to include "Closes #201" in the commit message, since then github auto-closes it with the suitable comment, and the git history contains a helpful reference back to the PR which motivated the change.


Suppress warnings about weak hash algorithms

Motivation:
LGTM reported that WebSocketUtil uses MD5 and SHA-1 that are considered weak. Although those algorithms are insecure, they are required by draft-ietf-hybi-thewebsocketprotocol-00 specification that is implemented in the corresponding WebSocket handshakers. Once the handshakers are removed, WebSocketUtil can be updated to stop using those weak hash functions.
Modifications:
Added SuppressWarnings annotations.
Result:
Suppressed warnings.
Notes:
Here are the issues reported by LGTM: one, two
I think the best solution would be just removing the calls to MD5 and SHA-1. However, that would break the classes that implement drafts of the WebSocket specification. Please let me know if it's fine to remove them.

@netty-bot test this please
@artem-smotrakov I think suppression is the way to go for now

@netty-bot test this please


How to get data from a response header?

Hi,
When i create an inventory task (but for all task calls), how i can retrieve the task id?
The call return always None, but i need access the Location header.
Thanks

Please elaborate by supplying a snippet of Python code.

Hi, in a situation like this
res = api.sell_feed_create_inventory_task(             body={"schemaVersion": "1.0", "feedType": "LMS_ACTIVE_INVENTORY_REPORT"})         print(res)
res is None
I see the comment in the create_inventory_task function and it is very confusing, because i see:
This method returns the location response header containing the getInventoryTask call URI to retrieve the inventory task you just created. The URL includes the eBay-assigned task ID, which you can use to reference the inventory task.
and
:return: None
but the task is created, if i call get_inventory_tasks i have the task...

Unfortunately, you have discovered a limitation of this library;  thank you for bringing it to my attention.
The root cause is beyond my control; I don't see an easy solution; perhaps a remedy will come from Swagger or eBay in time. Several workarounds come to mind, which I listed in the ReadMe search on  'How to get data from a response header?'.

After several days of tests I came to this solution:
in file sell_feed/api/task_api.py in line 52 (function create_task()) I changed the value '_return_http_data_only' from True to False so it will return header:
kwargs['_return_http_data_only'] = False
In file a_p_i.py in function _de_swagger() I added tuple to basic_types:
basic_types = (bool, bytes, datetime.date, datetime.datetime,
               float, int, type(None), str, tuple)  # omitted ones that are unlikely to ever be used

This is the code to get task_id:
feed_type = "LMS_ADD_FIXED_PRICE_ITEM"
content_type = 'application/json'
body = {
    "feedType": feed_type,  # https://developer.ebay.com/api-docs/sell/static/feed/lms-feeds-quick-reference.html
    "schemaVersion": "1331"  # https://developer.ebay.com/DevZone/XML/docs/ReleaseNotes.html
}
result = api.sell_feed_create_task(body=body, x_ebay_c_marketplace_id='EBAY_IT', content_type=content_type)
location = result[2]._container['location'][1]
task_id = os.path.basename(os.path.normpath(location))

Good digging; thanks for finding and sharing a solution! I'm intensely working on another project, so please forgive me for not acting on this for several weeks.
If you need a fresh release with this change sooner or are willing to submit a PR, please use scripts/generate_code.py to patch sell_feed/api/task_api.py and add a unit test.


override lookup and open a new tab instead

Task/Issue URL: https://app.asana.com/0/392891325557410/1199890390771052
Tech Design URL:
CC:
Description:
Override "lookup" in the menu that pops up when long pressing a text selection and do a search in a new tab instead.
Steps to test this PR:

Open a page
Select some text
Select lookup from the popup menu
New tab should open with selected text as the search

Internal references:
Software Engineering Expectations
Technical Design Template

Decided to raise feedback with Apple instead.  Thanks for looking @samsymons !


Cache redesign part 4: Split up the dataservices

References
This ticket corresponds to issue 8 from #718.
That ticket was too big to tackle at once so we split it up in to smaller, more manageable chunks of work.
Description
We encourage every service that corresponds with a rest endpoint to inherit from it. But most endpoints only support a fraction of the methods dataservice provides. So we either inherit, and a lot of methods don't work, or use delegation, but don't have interfaces to enforce which methods the delegating service has.
This makes it possible for someone to add an @dataservice annotation on a service that isn't one, and we'd only know about it at runtime. We should at least create a separate interface for each atomic bit of functionality in dataservice, and perhaps also split up dataservice in to multiple smaller classes, and use composition rather than inheritance for the implementing services.
Proposed Solution

We'll split dataservice methods up in to chunks of functionality and create interfaces for them.
e.g. CreateDataService, ReadDataService, PutDataService, PatchDataService, DeleteDataService, SearchDataService, …
The dataservice implementations don't inherit from dataservice but implement the interfaces for the methods they need
So DSODataservice would only implement ReadDataService, while CommunityDataService would implement them all.
What is currently the @DataService annotation would become @ReadDataService and enforce services using it to implement the ReadDataService interface.

This will take an estimated 24 - 32h

Tentatively added to 7.1 alongside #741 (both might be done by the same developer at that time)

While we could change the priority back, I'm bumping this to high priority (from medium) simply because I'm seeing a lot of cache related issues in other tickets.  While I realize this may not solve them all, it seems like cache cleanup & fixing caching issues is becoming very high priority.


chore(deps): regenerate yarn.lock file

regenerate the empty app/yarn.lock file to revert it to its default state

Coverage remained the same at 19.631% when pulling f71de2668441480d73c63cab4af9273a86a652e4 on mrfelton:chore/yarn-lock-cleanup into 420aae5938e8dba095482ea7cd0a30f3a080a025 on LN-Zap:master.

Coverage remained the same at 19.631% when pulling f71de2668441480d73c63cab4af9273a86a652e4 on mrfelton:chore/yarn-lock-cleanup into 420aae5938e8dba095482ea7cd0a30f3a080a025 on LN-Zap:master.


[Error]  User '***********' has exceeded the 'max_user_connections' resource (current value: 15)

Hi, thanks for all,
Get an error
[Error]  User '***********' has exceeded the 'max_user_connections' resource (current value: 15)

I get the same error when trying to Register... were you able to complete this?

We were getting the same error
I think this plugin is no longer being supported
We ended up removing the plugin from our app

Wait for like 15 minutes and try again.
On Fri, Dec 18, 2020, 09:41 Shiva Prasad<EMAIL_ADDRESS>wrote:

We were getting the same error
I think this plugin is no longer being supported
We ended up removing the plugin from our app
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NativeScript/nativescript-app-sync-server/issues/19#issuecomment-747924526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJNBJ4K6CK4I7FQ3B3IRX63SVMBTZANCNFSM4SMSGESQ
.


[Introspection] Add empty line between scalar and relation fields

Right now Introspection outputs all fields of a model one after another.
This leads to the formatting to align all the types and attributes by looking at all the fields of the model. Quite often, the scalar fields and the relation fields are quite different, which can look a bit awkward:
model brands {
  cover_picture_id                                            Int?
  created_at                                                  DateTime
  description                                                 String?
  id                                                          Int                  @default(autoincrement()) @id
  media_id                                                    Int?
  name                                                        String?
  page_id                                                     Int?
  picture_id                                                  Int?
  slug                                                        String?
  updated_at                                                  DateTime
  year                                                        Int?
  brands_competitors_brandsTobrands_competitors_brand_id      brands_competitors[] @relation("brandsTobrands_competitors_brand_id")
  brands_competitors_brandsTobrands_competitors_competitor_id brands_competitors[] @relation("brandsTobrands_competitors_competitor_id")

  @@index([slug], name: "index_brands_on_slug")
}

Turns out having an empty line in between fields "restarts" the alignment formatting and would lead to something like that:
model brands {
  cover_picture_id Int?
  created_at       DateTime
  description      String?
  id               Int      @default(autoincrement()) @id
  media_id         Int?
  name             String?
  page_id          Int?
  picture_id       Int?
  slug             String?
  updated_at       DateTime
  year             Int?

  brands_competitors_brandsTobrands_competitors_brand_id      brands_competitors[] @relation("brandsTobrands_competitors_brand_id")
  brands_competitors_brandsTobrands_competitors_competitor_id brands_competitors[] @relation("brandsTobrands_competitors_competitor_id")

  @@index([slug], name: "index_brands_on_slug")
}

Additionally it is quite nice to have the relation fields in their own "block" as it visually separates them and makes them nicer to differentiate.

This will also require changes to the AST renderer otherwise they will be removed on save.

That renderer probably even produces this - Introspection itself strictly only produces a data representation that is then rendered into a string.


Client-side routing?

How did you fixed client-side routing? I use react-router, which works fine in development, because webpack is running a dev-server. But in production/on now/using serve, it works until I refresh the page when I'm on a route. This makes sense, because that route does not point to a file on disk. What's the best way of fixing this?

@Jpunt If u refresh the page, you probably need a server code to handle the routes and pass it to the client code for react router to handle. For instance, you can use express for the server code and use react router match function to handle the incoming routes and pass it down to the client side (this is just my thought, probably need to give it a shot myself to see if it works this way). Think of it like an isomorphic react app.
In fact, if you are refering to the latest commits, create-react-app-now does not fix the page refresh issue (it will throw Not Found if you refresh the page), but if you navigate within the page itself it works fine since it's client code.
On a side note, if you are not required to use CRA, do checkout NextJS (if you haven't of course) as it offers better API imo and works pretty well with Now.

Some of these links might be of help to you:
https://github.com/facebookincubator/create-react-app/issues/1100
https://github.com/facebookincubator/create-react-app/issues/641
<EMAIL_ADDRESS>https://github.com/facebookincubator/create-react-app/pull/887/commits/8199087cd328433cf9549a2f172a3902002fcdfa
https://react-router.now.sh/basic

Thanks. The trick was the amazing --single or -s option of serve. This makes it behave as a single page app 👍

hey , I know this is already closed but I still have that problem and I don't understand that solution Jpunt found where do you set that --single ? Is it in your server where you host your app?

@RamiroIsBack You use --single when you are running the code using serve. Refer to https://github.com/xkawi/create-react-app-now/blob/master/package.json "now-start" command.
Additionally, refer create-react-app official documentation regarding the deployment: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#deployment

Thanks for pointing me in the right direction, going through the official documentation regarding the deployment, says that serve is used for environments using Node, and all the examples and docs about it are using Node. My app is pure react front-end and I'm using firebase for the back-end tasks.
-Do you see another way to make the routing work in production?
-Or does it means that I have to set a back-end for it in Node, so I can use serve to make my web-app work as a single page app caching all the front-end routing and pointing it to index.html? did I get it right?
thanks for the time and effort @xkawi

Yup, think you get it right. Because “serve” acts like the Node backend that host/run/serve your static react code, which will also handle the routing for you.
 Simply host/run your react front-end code using “serve -s ”, as it acts like a static web server.
You can still deploy your static react frontend code to static hosting like aws S3, just that the routing won’t work properly on page refresh. At least that’s the case when I last tried it, which is almost a year ago.
Hope this gives you better idea on how everything works together. Let me know if I didn’t get your question right, so I could try to provide better explanation. :)
Cheers!

On 16 Nov 2017, at 11:04 PM, Ramiro Santamaria Alvarez<EMAIL_ADDRESS>wrote:
Thanks for pointing me in the right direction, going through the official documentation regarding the deployment, says that serve is used for environments using Node, and all the examples and docs about it are using Node. My app is pure react front-end and I'm using firebase for the back-end tasks.
-Do you see another way to make the routing work in production?
-Or does it means that I have to set a back-end for it in Node, so I can use serve to make my web-app work as a single page app caching all the front-end routing and pointing it to index.html? did I get it right?
thanks for the time and effort @xkawi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

that was perfect explanation, I'll try that, thank you again!

that was perfect explanation, and it works perfect locally through serve, cos I installed it globally on my laptop, but when I upload my build content to my hosting server and is out there , refreshing the page on one of the routes keeps on giving me:
Not Found
The requested URL /contact was not found on this server.
Any idea how can I make it work as it works locally through serve?

@RamiroIsBack what is your hosting provider? as you probably need to check how you can deploy a nodejs app into it, means projects that has package.json in it.
if you use Now, it's probably will just work, provided that you have:
"now-start": "server -s ./build"
as one of the npm script in package.json

All right, I had the app on heroku for testing and their servers can handle routing on the client side no problem, but now my clients hosting provider doesn't, and as you suggested I asked them if I could deploy a nodejs app but you have to pay for that service and it's out of budget so...
Since I only have 5 routes on my single page app what I did is to write an html page for each of them and a .js file that controls and redirect them to index.html, this way, I at least catch what suppose to be working on my end, and the 404 is well handled from the server for mistakes or misspellings
I want to thank you @xkawi again for your help!

@RamiroIsBack Anytime. Glad to hear that it’s working on your end now. 👍😊


FIPS APIs

We have code where we integrated with OpenSSL 1.1.1. Since OpenSSL 3.0.0 is released we planning to upgrade to latest released OpenSSL. Our product do support FIPS. With OpenSSL 1.1.1 we used APIs FIPS_mode() and FIPS_mode_set(1).
Is it safe to assume that we should be able to replace above mentioned APIs with EVP_default_properties_is_fips_enabled(NULL) and EVP_default_properties_enable_fips(NULL, 1) ?

Not completely, these calls do not do exactly what you're wanting, they are just setting/checking the default property query.  I suggest looking at the migration guide and specifically the FIPS relevant parts.


[Bug report]: Cannot set properties of undefined (setting 'value')

Requirements before reporting

[X] No duplicated issue reported.
[X] I have checked the latest version if the bug exist there. See all available packages at npmJS.com
[X] I have followed the installation guide.

Package versions
"@scania/tegel-angular": "^1.6.0"
Browser
Chrome
Framework
Angular
Version
No response
Reproduction steps

Add tds dropdown to your page
use angular reactive form
bind dropdown options dynamically using a list created/initialized in typescript
4: assign default value

Code example

<ng-container *ngFor="let market of configuratorService.markets; let idx = index">
<tds-dropdown-option [value]="market.code">
{{ market.name }}

Screenshots
1: set default value is not working..

2: drop down select event is throwing error

Expected behaviour
1: The tds dropdown should work with the default value.
2: The tds dropdown shouldn't throw any errors on dropdown select
Console errors
ERROR Error: Uncaught (in promise): TypeError: Cannot set properties of undefined (setting 'value')
Contact information
No response

I think you would want to user default-value and not value for setting a default value. See: https://tds-storybook.tegel.scania.com/?path=/story/components-dropdown--default&args=defaultOption:Option+1&globals=backgrounds.value:!hex(F9FAFB)

Sorry for the incomplete information. Yes, I am using the 'default-value' property, and it works when I use a static value(predefined options) in the dropdown options. However, it doesn't work when we load the options data using a loop.
e.g.

<ng-container *ngFor="let market of configuratorService.markets; let idx = index">
<tds-dropdown-option [value]="market.code">
{{ market.name }}

@ZakirQamar glad to hear!
However, this should still be fixed. We should add a listener that checks the default-value ones the children change.
Ping @theJohnnyMe

@ZakirQamar would anything change if you use prop [defaultValue] instead of attribute default-value? Please try it out and let me know if anything is different.

Hi, tried with the [defaultValue], but no luck :(

@ZakirQamar  - I made potential fix for this here: https://github.com/scania-digital-design-system/tegel/pull/599 Please check it out when you have time :) Also I can pack code so you test on you local too to check if it improves it.

Fix is released in version 1.8.1


enhancement avoiding broadcast join heuristically and pruning more in CostAndEnforceJob

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


Binarycaching to github nuget doesn't set package to public when linked to public repository

metadata.repository
The nuget and nugetconfig source providers additionally respect certain environment variables while generating nuget packages. The metadata.repository field of any packages will be generated as:
<repository type="git" url="${VCPKG_NUGET_REPOSITORY}"/>

or
<repository type="git"
            url="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git"
            branch="${GITHUB_REF}"
            commit="${GITHUB_SHA}"/>

if the appropriate environment variables are defined and non-empty. This is specifically used to associate packages in GitHub Packages with the building project and not intended to associate with the original package sources.

After setting env VCPKG_NUGET_REPOSITORY it can linked properly to a repository, but the package visibility doesn't keep with repo visibility. Even linked to a public repo the package is still private

@cnSchwarzer Because many NuGet servers require additional credentials to access. Unless you use the package source as a public property, it can only be used as a private package with credentials, which is for security reasons.

@cnSchwarzer Because many NuGet servers require additional credentials to access. Unless you use the package source as a public property, it can only be used as a private package with credentials, which is for security reasons.

Just for curiosity, why packages uploaded by a github action is public by default? (Which use secrets.GITHUB_TOKEN as apikey)

@cnSchwarzer

Which use secrets.GITHUB_TOKEN as apikey, and uploading to public repository

Because the secrets.GITHUB_TOKEN has read and write permissions to the repository associated with the workflow. When the secrets.GITHUB_TOKEN is used to upload a package, the package is added to the repository's release page, which is public by default.

While upload and link to same repository from local computer with a generated PAT is private by default

Because the PAT has the permissions to read and write only to the specific repository to which it has been granted access. Therefore, the package is uploaded to the repository's releases page, which is also private by default.

@cnSchwarzer
The difference in default privacy settings between these two methods of uploading packages is due to the different permissions and access levels granted by secrets.GITHUB_TOKEN and a generated PAT.
Since secrets.GITHUB_TOKEN has read and write permissions to the entire repository, packages uploaded using it are by default public.
In contrast, a generated PAT has limited permissions to only the specific repository to which it has been granted access, which means packages uploaded using it are by default private to that specific repository.

see:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

What about a PAT that was assigned administrative permission and granted all access to all repositories? Does it also private by default?

If a PAT has been assigned administrative permission and granted access to all repositories in an organization, and is used to upload a package to a repository's release page, the package is still private by default.
This is because, by default, the release page for a repository is private, and the PAT only has access to the specific repository to which it has been granted access, regardless of the permissions assigned to it.
And It is very dangerous to grant administrative permissions to pat and all access to the repository. This is generally not recommended

Thank you for answering that! 🌹


Add Edina Schools

Website: Edina Schools

@chococaker Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


I get autocompletion but no other feedback

it seems to hit the openai api properly

Could you try to run it with your cursor in the next line or after adding a period to your request?


Landscape orientation difficult

The chart doesn't sit well in landscape orientation, possibly due to a fixed height? It will always stick out the bottom of a container or cut off the navigation view.

Hi. Can you send me .xml with an example?

I have attached a (very) basic .xml that should show the issue. I have however tried it many different ways, directly in ConstraintLayout, in LinearLayout, and using all types of layout_width and layout_height attributes (match_parent, match_constraint, fixed value). The only way I can get it working correctly is in a scrollview, but this is definitely not an ideal solution.  Padding the sides (image 2) does what you'd expect, however padding top and bottom (image 3) either crops or shifts the chart down. Setting layout_height to wrap_content (image 4) centres the chart enough to see part of the NavigationView, but would likely not work on all devices.
P.S. Apologies if I am not providing the correct information here, or it is a simple error of mine, I am a university student without a great deal of Android experience, but keen to learn.
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".MainActivity">

    <com.klim.tcharts.TChart
        android:id="@+id/tchart"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:padding="16dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent" />

</androidx.constraintlayout.widget.ConstraintLayout>

I get the same issues when I set padding. The issue was solved however, when I included TCharts as a Java Module into my app rather than adding through gradle. Don't ask me why! I'll mark it as closed, as it seems to be working now.


Ph/78 round functionality

Pridal jsem funkci round(Number,precision,RoundingMode), kde Number je cislo, ktere se zaokrouhluje, precision je presnost, RoundingMode jsou mody prevzate z IEEE 754, do funkce se zadava jako cislo od 0 do 4. Funkci je mozne volat i bez RoundingMode, kde se automaticky pouzije NEAREST_EVEN mode.

Codecov Report

Merging #5 into master will increase coverage by 3.38%.
The diff coverage is 63.71%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   40.32%   43.71%   +3.38%
==========================================
  Files          53       53
  Lines        1354     1455     +101
==========================================
+ Hits          546      636      +90
- Misses        808      819      +11

Impacted Files
Coverage Δ

...e/lib/src/parser/expression_parser_exceptions.dart
36.36% <0%> (-3.64%)
:arrow_down:

...age/lib/src/visitors/clone_expression_visitor.dart
0% <0%> (ø)
:arrow_up:

...lib/src/visitors/traversal_expression_visitor.dart
0% <0%> (ø)
:arrow_up:

...xpression_language/lib/src/number_type/number.dart
16.66% <100%> (+16.66%)
:arrow_up:

...on_language/lib/src/parser/expression_factory.dart
36.73% <38.88%> (+10.41%)
:arrow_up:

...sion_language/lib/src/expressions/expressions.dart
31.28% <72.72%> (+4.12%)
:arrow_up:

...pression_language/lib/src/number_type/integer.dart
45.78% <83.33%> (+8.12%)
:arrow_up:

...pression_language/lib/src/number_type/decimal.dart
68.8% <97.72%> (+35.46%)
:arrow_up:

...uage/lib/src/parser/expression_grammar_parser.dart
70.67% <0%> (+0.75%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd615f3...2aca2f6. Read the comment docs.


package universal download is broken

I am using the Universal package part of this tool as part of a build pipeline, but it has seemed to stop working with your latest commit. Now when I try to push/pull artifacts I get an error that a file is not found. It is unclear, but it looks like the missing file being looked for should be part of the project. Older verisons of your installer do not have this issue. Below is a powershell command and the resulting error output.
Thanks for your help and convient tool,
Will Vinke

`C:\source\develop [develop ≡ +0 ~2 -0 !]> vsts package universal download --instance "https://eedp.visualstudio.com/" --feed "RPackages" --name "r-3.5.0" --version "1.0.1" --path .
Universal Packages is currently in preview.
[WinError 2] The system cannot find the file specified
Traceback (most recent call last):
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\invocation.py", line 172, in execute
cmd_result = parsed_args.func(params)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\commands.py", line 105, in call
return self.handler(*args, **kwargs)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\commands.py", line 203, in _command_handler
result = op(client, **command_args) if client else op(**command_args)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\universal.py", line 62, in download_package
return artifact_tool.download_universal(team_instance, feed, name, version, path)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\artifacttool.py", line 24, in download_universal
return self.run_artifacttool(team_instance, ["universal", "download", "--service", team_instance, "--patvar", self.PATVAR, "--feed", feed, "--package-name", package_name, "--package-version", package_version, "--path", path], "Downloading")
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\artifacttool.py", line 44, in run_artifacttool
proc = self._tool_invoker.run(command_args, new_env, initial_progress_message, self._process_stderr)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\external_tool.py", line 68, in run
self.start(command_args, env)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\external_tool.py", line 38, in start
env=env)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\subprocess.py", line 756, in init
restore_signals, start_new_session)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\subprocess.py", line 1155, in _execute_child
startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified`

@eedpWillVinke I am unable to repro the issue using vsts-cli version 0.1.3.
What is the version you are using are you using dev setup since you said.. "but it has seemed to stop working with your latest commit".  Share the --debug logs if the issue is still there.

I am using vsts-cli version 0.1.3 also. Sorry about the confusion, it does not seem to be a result of the commit (I thought maybe the failed CI build had something to do with it).
Looking more closely it may be a throttling issue or something with the connection to vsts.
Are there download/upload limits associated with Azure Artifacts?
Thanks for your fast response
`C:\source\develop\lib [develop ≡ +1 ~1 -0 !]> vsts package universal download --instance "https://eedp.visualstudio.com/" --feed "RPackages" --name "r-3.5.0" --version "1.0.4" --path . --debug
Command arguments: ['package', 'universal', 'download', '--instance', 'https://eedp.visualstudio.com/', '--feed', 'RPackages', '--name', 'r-3.5.0', '--version', '1.0.4', '--path', '.', '--debug']
Event: Cli.PreExecute []
Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x03A88D20>, <function OutputProducer.on_global_arguments at 0x03B328E8>, <function CLIQuery.on_global_arguments at 0x03AE52B8>]
Event: CommandInvoker.OnPreCommandTableCreate [<function CLILogging.remove_logger_flags at 0x03A88D68>]
Event: CommandLoader.OnLoadCommandTable []
Event: CommandLoader.OnLoadArguments []
Event: CommandInvoker.OnPostCommandTableCreate []
Event: CommandInvoker.OnCommandTableLoaded []
Event: CommandInvoker.OnPreParseArgs []
Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x03B32930>, <function CLIQuery.handle_query_parameter at 0x03AE5300>, <function VstsCLI.post_parse_args at 0x04533300>]
Universal Packages is currently in preview.
Checking for a new ArtifactTool
Checking for ArtifactTool updates
Getting credential: vsts-cli:https://eedp.visualstudio.com
Getting credential: vsts-cli: default
Creating connection with personal access token.
Telemetry enabled.
vsts._file_cache : Loading cache file: C:\Users\WillVinke.vsts\python-sdk\cache\options.json
vsts._file_cache : attempting to read file C:\Users\WillVinke.vsts\python-sdk\cache\options.json as utf-8-sig
vsts.vss_client : File cache hit for options on: https://eedp.visualstudio.com
vsts.vss_client : Route template: _apis/{area}/{resource}
vsts.vss_client : Api version '4.0-preview.1'
vsts.vss_client : POST https://eedp.visualstudio.com/_apis/CustomerIntelligence/Events
vsts.vss_client : Request content: [{'area': 'CLI', 'feature': 'package', 'properties': {'Command': 'universal download', 'Args': ['instance', 'feed', 'name', 'version', 'path']}}]
vsts._file_cache : Loading cache file: C:\Users\WillVinke.vsts\python-sdk\cache\resources.json
msrest.pipeline : Configuring request: timeout=100, verify=True, cert=None
vsts._file_cache : attempting to read file C:\Users\WillVinke.vsts\python-sdk\cache\resources.json as utf-8-sig
msrest.pipeline : Configuring proxies: ''
msrest.pipeline : Evaluate proxies against ENV settings: True
vsts.vss_connection : File cache hit for resources on: https://eedp.visualstudio.com
Looking up current version of ArtifactTool...msrest.pipeline : Configuring redirects: allow=True, max=30
vsts.vss_client : File cache hit for options on: https://eedp.vsblob.visualstudio.com
msrest.pipeline : Configuring retry: max_retries=3, backoff_factor=0.8, max_backoff=90
vsts.vss_client : Route template: _apis/{area}/{toolName}/{resource}
vsts.vss_client : Api version '5.0-preview'
urllib3.connectionpool : Starting new HTTPS connection (1): eedp.visualstudio.com:443
vsts.vss_client : GET https://eedp.vsblob.visualstudio.com/_apis/clienttools/ArtifactTool/release?osName=Windows&arch=AMD64
vsts.vss_client : Request content: None
msrest.pipeline : Configuring request: timeout=100, verify=True, cert=None
msrest.pipeline : Configuring proxies: ''
msrest.pipeline : Evaluate proxies against ENV settings: True
msrest.pipeline : Configuring redirects: allow=True, max=30
msrest.pipeline : Configuring retry: max_retries=3, backoff_factor=0.8, max_backoff=90
urllib3.connectionpool : Starting new HTTPS connection (1): eedp.vsblob.visualstudio.com:443
urllib3.connectionpool : https://eedp.visualstudio.com:443 "POST /_apis/CustomerIntelligence/Events HTTP/1.1" 204 0
vsts.vss_client : Response content: b''
urllib3.connectionpool : https://eedp.vsblob.visualstudio.com:443 "GET /_apis/clienttools/ArtifactTool/release?osName=Windows&arch=AMD64 HTTP/1.1" 200 443
vsts.vss_client : Response content: b'{"name":"ArtifactTool","rid":"win10-x64","version":"0.2.74","uri":"https://vsblobprodscussu5shard1.vsblob.vsassets.io/artifacttool/artifacttool-win10-x64-Release_0.2.74.zip?sv=2017-04-17&sr=b&sig=n0GUREh6SRjp0I1qxX8o3IxJYb7P1oF1lKQH2O5PLBU%3D&spr=https&se=2018-11-14T20%3A00%3A03Z&sp=r&P1=1542225303&P2=11&P3=2&P4=4DkMTVZhwtz24UWUebM7rWE1IWtzUn4fCBZXXF%2FiALo%3D"}'
Checking if we already have ArtifactTool release 'ArtifactTool_win10-x64_0.2.74'
Not updating ArtifactTool because the current release already exists at 'C:\Users\WillVinke.vsts\cli\tools\artifacttool\ArtifactTool_win10-x64_0.2.74'
Getting credential: vsts-cli:https://eedp.visualstudio.com
Getting credential: vsts-cli: default
Creating connection with personal access token.
Running external command: C:\Users\WillVinke.vsts\cli\tools\artifacttool\ArtifactTool_win10-x64_0.2.74\artifacttool universal download --service https://eedp.visualstudio.com/ --patvar VSTS_ARTIFACTTOOL_PATVAR --feed RPackages --package-name r-3.5.0 --package-version 1.0.4 --path .
[WinError 2] The system cannot find the file specified
Traceback (most recent call last):
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\invocation.py", line 172, in execute
cmd_result = parsed_args.func(params)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\commands.py", line 105, in call
return self.handler(*args, **kwargs)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\knack\commands.py", line 203, in _command_handler
result = op(client, **command_args) if client else op(**command_args)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\universal.py", line 62, in download_package
return artifact_tool.download_universal(team_instance, feed, name, version, path)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\artifacttool.py", line 24, in download_universal
return self.run_artifacttool(team_instance, ["universal", "download", "--service", team_instance, "--patvar", self.PATVAR, "--feed", feed, "--package-name", package_name, "--package-version", package_version, "--path", path], "Downloading")
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\artifacttool.py", line 44, in run_artifacttool
proc = self._tool_invoker.run(command_args, new_env, initial_progress_message, self._process_stderr)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\external_tool.py", line 68, in run
self.start(command_args, env)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\site-packages\vsts\cli\package\common\external_tool.py", line 38, in start
env=env)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\subprocess.py", line 756, in init
restore_signals, start_new_session)
File "C:\Program Files (x86)\Microsoft SDKs\VSTS\CLI\lib\subprocess.py", line 1155, in _execute_child
startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified`

It was a problem with my installation. I have been installing/uninstalling this a lot, and it looks like the file being looked for ( Running external command: C:\Users\WillVinke.vsts\cli\tools\artifacttool\ArtifactTool_win10-x64_0.2.74\artifacttool universal download --service https://eedp.visualstudio.com/ --patvar VSTS_ARTIFACTTOOL_PATVAR --feed RPackages --package-name r-3.5.0 --package-version 1.0.4 --path .) was messed up in some way even thought the file was still there. I was able to fix the problem by just deleting the /[User]/.vsts directory then reinstalling.
Thanks, sorry for the confusion.


Check dns_check not found in Catalog

Output of the info page (if this is a bug)

Agent Info

Version: 7.18.1
PID: 5824
Check Workers: 4
Agent start: 2020-04-28 17:19:21.367282 GMT
Log Level: info
Config File: C:\ProgramData\Datadog\datadog.yaml
Conf.d Path: C:\ProgramData\Datadog\conf.d
Checks.d Path: C:\ProgramData\Datadog\checks.d

System Info

System UTC Time: 2020-04-28 17:22:19.088376 GMT
Go Version: go1.12.9
Python Version: 3.8.1
Build arch: amd64

Host Info

Boot Time: 2020-04-15 17:24:00.000000 GMT
 OS: windows
 Platform: Windows Server 2016 Standard
 Platform Family: Windows Server 2016 Standard
 Platform Version: 10.0 Build 14393
 Procs: 61
 Uptime: 311h55m21s

Hostnames

Hostname: ddagent
 Socket-Fqdn: ddagent
 Socket-Hostname: ddagent
 Hostname Provider: os
Unused Hostname Providers:

Aws: not retrieving hostname from AWS: the host is not an ECS instance, and other providers already retrieve non-default hostnames
 Configuration/Environment: hostname is empty
 Gce: unable to retrieve hostname from GCE: Get http://<IP_ADDRESS>/computeMetadata/v1/instance/hostname: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Metadata

hostname_source: os

JMX Status

Initialized Checks

No initialized checks

Failed Checks

No failed checks

Forwarder

Check Runs V1: 11
 Dropped: 0
 Dropped On Input: 0
 Events: 0
 Host Metadata: 0
 Intake V1: 2
 Metadata: 0
 Requeued: 37
 Retried: 18
 Retry Queue Size: 0
 Series: 0
 Service Checks: 0
 Sketch Series: 0
 Success: 24
 Timeseries V1: 11

Transactions Errors

Errors: 10
 Errors By Type:

ConnectionErrors: 0
 DNSErrors: 0
 SentRequestErrors: 0
 TLSErrors: 10
 WroteRequestErrors: 0

API Keys Status

API key ending with 43c6d: API Key valid

Endpoints

https://app.datadoghq.com - API Key ending with:
   - 43c6d

Logs Agent

Logs Agent is not running

Aggregator

Checks Metric Sample: 31,014
 Dogstatsd Metric Sample: 781
 Event: 1
 Events Flushed: 1
 Number Of Flushes: 11
 Series Flushed: 28,017
 Service Check: 608
 Service Checks Flushed: 574

DogStatsD

Event Packets: 0
 Event Parse Errors: 0
 Metric Packets: 780
 Metric Parse Errors: 0
 Service Check Packets: 0
 Service Check Parse Errors: 0
 Udp Bytes: 50,289
 Udp Packet Reading Errors: 0
 Udp Packets: 781
 Uds Bytes: 0
 Uds Origin Detection Errors: 0
 Uds Packet Reading Errors: 0
 Uds Packets: 0

Describe what happened:
Trying to check DNS.  Instead we get the following errors in the collector:
dns_check

Core Check Loader: Check dns_check not found in Catalog
JMX Check Loader: check is not a jmx check, or unable to determine if it's so
Python Check Loader: unable to import module 'dns_check': No module named 'dns_check'

Describe what you expected:
check to work?
Steps to reproduce the issue:
dns_check.d/conf.yaml:
init_config:

instances:

  - name: check_domain.com

    hostname: sub.domain.com

    nameserver: <IP_ADDRESS>

Hi! Thanks for your submission!
This is a bug that was introduced with the move to Python 3.8, and we have a fix already applied which should be resolved in the next release of the agent, 7.19.0 due for release "very soon".
For more info, take a look at this PR: https://github.com/DataDog/integrations-core/pull/6478

Any update?


fix(sheet): trigger close action when sheet is fully closed

call setOpen(false) when Sheet is fully closed!
fix junky animation in this issue #2099

@ehxxn can we count on getting it released? We are having animation issues in the prod app

@arekkubaczkowski This isn't a perfect fix, I should close this PR
I'll try to find a proper fix over the weekend. or if someone from Tamagui team wants to fix it
as a workaround, you can use setTimeout
onOpenChange={(open) => {
     if (!open) {
         setTimeout(() => setOpen(false), 300)
     } else {
        setOpen(true)
     }
}}


Mazda: query and log FW on bus 0

prep for https://github.com/commaai/openpilot/issues/25756

@Jafaral can you try this relatively soon to see if it returns anything? If so we can merge it for the next release to gather data

We do get some stuff on bus 0, worth merging as-is


Begone


need help ,someone have any idea about this problem ? Closed websocket, onClose method is not correction

Connect me WebSocket called after WebSocketClient. After the close method not onclose callback method, but the service has been closed the connection.

Hello @youyuanme,
I do not really understand your issue.
For my projects onClose will always be called when the server closes the connection.
Greetings
marci4

I also met. Do not operate for a long time, the client can not receive the message, the server is closed, but the client does not call closure method

I also met. Do not operate for a long time, the client can not receive the message, the server is closed, but the client does not call onClose

Hello @qktang,
are you on the latest version 1.3.2?
Right now this version is passing all the tests provided by the autobahn testsuite including closing behavior, so for me this works.
Greetings
marci4

I also met. The version is 1.3.4. I called close(), but never received onClose(int code, String reason, boolean remote).
Oh my god. My project will be blocked in this situation.

hello @hattie0312,
could you provide some steps to reproduce for me?
what are you doing on the client side and what are you doing on the server side?
Greetings
marci4

No feedback!
If you still have this issue, please open a separate thread!
Greetings
marci4


Move aos storage to MMC

pls, run checkpatch with changes, at least I see that some files don't have new line at the end

LGTM Acked-by: Oleksii Moisieiev<EMAIL_ADDRESS>

as far I see you've reverted previously made changes
is it what you want to do ?

as far I see you've reverted previously made changes

Sorry my branches got messed up a little, should be okay now

Moved the mounting code to bsp/mount.cpp


MorphTargetManager: Fix creation of texture when partial support for morph types

See https://forum.babylonjs.com/t/morphtargetmanager-has-uniform-binding-problem/41995/11

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14017/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14017/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14017/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14017/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14017/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14017/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14017/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14017/merge#BCU1XR#0


<= will intercept the included file

I have a markdown file test.md:
{% codesnippet "./test.cpp", language="cpp" %}{% endcodesnippet %}

and the test.cpp is:
Hello <= Word

Then I run gitbook serve to see the page, I can only see Hello, which means all code after <= is cutted off.
It seems this plugin can not handle this neither:
List<List<Integer>> list = new ArrayList<>();

Anyone?

same problem with <| in elm-language


Fails properly when system certificates can't be found

The code right now assumes that system certificates on macOS will be in /etc/ssl, but this folder might not even exist, in which case the certificates should be loaded from the keychain. If you don't have that folder on your system, the code would take a second path where it would use certificates bundled with the code, which only works when you have the source code available. The code assumes these exists, through, and will fail with a very unhelpful "No such file or directory". This patch only changes the assumption that the bundled certificates will be there, and in case of failure will present the slight less unhelpful "Couldn't load system certificates".
There is still a failure case that I encountered where I have an empty /etc/ssl/certs directory, which will pass the check if the file exists, but will fail with the same "No such file or directory" error when actually used. This is not fixed in this patch.
Again, this only fixes the error message, not the actual problem that the certificates doesn't get loaded from the keychain when they aren't in /etc/ssl.

Version 3 of this package is now at master. This PR will need to be re-opened against the latest 2.x tag.


[Bug]The button“select search engine”and"select models"is not working without ollama config

Describe the bug
Runtime:
Python 3.11
Windows 11x64
*I want to run the app using SAAS API only so I didn't intall ollama and relevent localized LLMs
After installation, when I open the frontend, I find I can't press the “select search engine”and"select models" button!
And the backend just give some errors relating to ollama,
I am wondering how to manage it？
How To Reproduce
Steps to reproduce the be

Below is my settings:

any frontend console errors?

But everytime I swith to the home page, here is a Error:
[2024-05-12 21:19:25,883] ERROR in app: Exception on /api/data [GET]
Traceback (most recent call last):
File "F:\devika-main.venv\Lib\site-packages\flask\app.py", line 1473, in wsgi_app
response = self.full_dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "F:\devika-main.venv\Lib\site-packages\flask\app.py", line 882, in full_dispatch_request
rv = self.handle_user_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "F:\devika-main.venv\Lib\site-packages\flask_cors\extension.py", line 178, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
^^^^^^^^^^^^^^^^^^
File "F:\devika-main.venv\Lib\site-packages\flask\app.py", line 880, in full_dispatch_request
rv = self.dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^
File "F:\devika-main.venv\Lib\site-packages\flask\app.py", line 865, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "F:\devika-main\src\logger.py", line 59, in wrapper
response = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "F:\devika-main\devika.py", line 59, in data
models = LLM().list_models()
^^^^^
File "F:\devika-main\src\llm\llm.py", line 62, in init
self.models["OLLAMA"] = [(model["name"].split(":")[0], model["name"]) for model in ollama.models]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not iterable

Same for me I tried to check it out but something is wrong I can see internal server error

you already have the ollama installed in your system.
As per your LOG it says ollama available. can you type ollama in your system terminal to check it.

so how do I fix this..? I have valid API keys set up and ollama running yet I cant choose a search engine nor model


Garbage values with ptr of self in Number

I expected this code to return  Slice[210, 2, 150, 73].
Interestingly, in my computer it returns Slice[0, 0, 0, 0].
However, with this small change it returns what I expected in my computer while in play.crystal-lang it returns different garbage.

It's all just luck and garbage. n is a local variable, so it lives on the stack. Once bytes returns its stackframe is free to be overwritten again. You have to copy the slice to the heap before returning it.

And here I was thinking that I could cheat and not have to touch the heap :grin: this is the kind of thing that happens when you go from Ruby to Crystal without learning C. Thanks & closing.

@Exilor One way to avoid the heap is to use a static array: https://play.crystal-lang.org/#/r/143z
struct Number
  def bytes
    n = self
    pointerof(n).as(UInt8[sizeof(self)]*).value
  end
end

p 0x01020304.bytes
p 0x01_u8.bytes

Yesssss that's what I wanted!
StaticArray bytes 454.36M (±11.03%)       fastest
      Slice bytes  57.77M (±14.88%)  7.86× slower

Thanks Ary :)


[bugfix] Re-enable ka tests

fixes https://github.com/moment/moment/issues/4839

Coverage decreased (-0.1%) to 88.347% when pulling 9d07fa7953f1173d775dc0d28315f0451a20213a on ka-tests into 1872bb22ff6cd19c56e7dc30c5765489d48e65f1 on develop.

Based on https://github.com/nodejs/node/issues/22518 we cannot merge this until we drop Node 10 support.

We will not drop Node 10 support, so I will close this.
See https://momentjs.com/docs/#/-project-status/


[Mod Support Request] GUI Clock by Serilium

Sorry for posting in issues, but it would be cool if you added support for Serilium's GUI Clock 😎👍

Something like the ingame time showing under the season line? I can add that and make a config option for that, unless their is something specific with the GUI Clock mod

GUI clock makes it so you can ONLY see time if you have a clock in your inventory, possibly you could make it only show seasons when holding a clock or if Fabric Seasons: Extras is installed, a calendar.


Initial implementation of ControlNet and MultiControlNet support.

This replaces PR #3085  (ControlNet backend first draft)

Regarding your comment here - check out the latents nodes. None of them go through base.py or higher layers anymore. It'd be preferable to not go through those (and deprecate them) and generally make it easier to implement new features directly in nodes. We're not all the way there, but that's the ideal direction.

Hi @GreggHelt2 I put the changes in my fork into a patch, it's a little messy but I hope it helps.
Note a few things:

This is against an older version of InvokeAI, and an older version of diffusers (at the time when controlnet was still in a PR)
I just inherited the entire generator from StableDiffusionControlNet, which we aren't doing here
In Img2Img/canvas mode I used strength == 1.0 (before only going to 0.99) to indicate you want the base image to purely be a hint image

Gregg, the pytests are failing. Do you know why?

Gregg, the pytests are failing. Do you know why?

Looks like problems with diffusers version. I'm using v0.15.0.dev0, which seems to currrently be floating along with the diffusers main head. If I revert to diffusers v0.14, my MultiControlNet implementation throws errors (support for ControlNet is in diffusers v0.14, but MultiControlNet is not). I think if we need to stick with v0.14, then with a little more work I could get MultiControlNet also working on v0.14. But we would lose ControlNet strength scaling, which was also introduced in diffusers after v0.14, and which I don't think I can shoehorn in short of completely copying over and modifying the diffusers ControlNetModel (instead of just importing it from v0.15.* )
Maybe  this depends on when a stable diffusers 0.15 release comes out?

Thanks @artsparkAI ! I'm looking over the patch while I clean up PR code...

Hi @GreggHelt2 I put the changes in my fork into a patch, it's a little messy but I hope it helps. Note a few things:

This is against an older version of InvokeAI, and an older version of diffusers (at the time when controlnet was still in a PR)
I just inherited the entire generator from StableDiffusionControlNet, which we aren't doing here
In Img2Img/canvas mode I used strength == 1.0 (before only going to 0.99) to indicate you want the base image to purely be a hint image

Regarding your comment here - check out the latents nodes. None of them go through base.py or higher layers anymore. It'd be preferable to not go through those (and deprecate them) and generally make it easier to implement new features directly in nodes. We're not all the way there, but that's the ideal direction.

I've been following the nodes discussions but there is lots to digest.
So let's see if I'm understanding correctly: is the "exemplar" of basic Text-to-Image generation for release 3.0 an executable graph of:
TextToLatentsInvocation --> LatentsToLatentsInvocation --> LatentToImageInvocation
?
And this graph can be executed in the Node UI but it is also what lies beneath the traditional-looking Img2Txt UI?
If so, is there a script/example/test in the repo I can run for this latents-based Img2Txt?

Gregg, the pytests are failing. Do you know why?

Looks like problem is with diffusers version. I'm using v0.15.0.dev0, which seems to currrently be floating along with the diffusers main head. If I revert to diffusers v0.14, my MultiControlNet implementation throws errors (support for ControlNet is in diffusers v0.14, but MultiControlNet is not). I think if we need to stick with v0.14, then with a little more work I could get MultiControlNet also working on v0.14. But we would lose ControlNet strength scaling, which was also introduced in diffusers after v0.14, and which I don't think I can shoehorn in short of completely copying over and modifying the diffusers ControlNetModel (instead of just importing it from v0.15.* ) Maybe this depends on when a stable diffusers 0.15 release comes out?

And official diffusers v0.15 release just came out. Thoughts on moving InvokeAI diffusers requirement to >= 0.15? Right now I'm testing 0.15 more thoroughly. I know there's a few changes needed in current InvokeAI codebase to move to v0.15, for example some class names that include ...CrossAttention... were renamed to ...Attention...

Gregg, the pytests are failing. Do you know why?

Looks like problem is with diffusers version. I'm using v0.15.0.dev0, which seems to currrently be floating along with the diffusers main head. If I revert to diffusers v0.14, my MultiControlNet implementation throws errors (support for ControlNet is in diffusers v0.14, but MultiControlNet is not). I think if we need to stick with v0.14, then with a little more work I could get MultiControlNet also working on v0.14. But we would lose ControlNet strength scaling, which was also introduced in diffusers after v0.14, and which I don't think I can shoehorn in short of completely copying over and modifying the diffusers ControlNetModel (instead of just importing it from v0.15.* ) Maybe this depends on when a stable diffusers 0.15 release comes out?

And... official diffusers v0.15 release just came out! Thoughts on moving InvokeAI diffusers requirement to >= 0.15? Right now I'm testing 0.15 more thoroughly. I know there's a few changes needed in current InvokeAI codebase to move to v0.15, for example some class names that include ...CrossAttention... were renamed to ...Attention... (which is at least one of the reasons this PR is not passing pytests).

Downgrading to draft PR for now. Will upgrade back to open PR once feat/ui/nodes PR to merge to main goes through, as well as PR for moving to diffusers v0.15. I don't think there's any need for further review till then -- don't want to waste anyone's time when there's going to be more changes needed before this can be used with main.

@GreggHelt2 - Just checking in here, since Multi-controlnet was seeming close to ready - This almost ready to merge in?


Influxdb-admin unreachable at 8083

I used to run influxdb-admin by providing property: ADMIN_ENABLED: 'true' and it used to work fine, however now I am unable to access admin on 8083. has there been any updates for admin accessibility?

@anarwal27 the Admin UI has been deprecated and removed as of 1.3.


tonight and tomorrow - working on:

I'm going to be going through section 3.4 text tonight and into tomorrow if need be...

I've done a couple of my minor assigned issues. Off home now. May work tonight but my eyes are shot....

I'm also working on #758  and #759 tonight and tomorrow AM

Sorry for lack of commits the last two days, I have been trying to get the Laplace approximation to work for the hake model. Good news, it works now and the estimate is similar to other methods. Sorry for my absence and thanks for being patient. I will find something productive to do now.

I am working on #462 and #761 currently


Generate .env at the root of the app

Closes #191
/cc @lotus/core-team @luislavena

@jodosha great, thank you!

@luislavena Thank you for the good catch :+1:


ConfigurationSourceProvider

I found a configuration source provider that works on resources very useful since src/main/resources is already on the classpath.
public class ResourceConfigurationSourceProvider implements ConfigurationSourceProvider {

    @Override
    public InputStream open(String path) throws IOException {
        return getClass().getClassLoader().getResourceAsStream(path);
    }

}

This issue is to see if thats worthwhile incorporating in the main dropwizard code. if so , I can send PR.

Thanks! I've added the class in 615048cdacdcab047dfb4919fdd73709ab00c1cd.


Bump scx_rusty from 0.0.7 to 1.0.0 stable.

Bumped package scx_rusty from 0.0.7 to 1.0.0 :
scx_rusty has just had its first stable release upstreamed three days ago, 1.0.0.  I personally would like to use this on my NixOS machine.  This is my first time making a PR.  If there is anything else needed to get this to build and eventually merged, please let me know.

I like chocolate cake.

Sadly, this one needs an entire bump of the SCX-package.
I'll be trying to do this bump my own after I finish rounding everything in #802. But if you want to really try it yourself, there is an unfinished updated script in pkgs/scx/update.sh, by the end it bumps a commit that should match the v1.0.0 tag, there is also pkgs/scx/common.nix to update. Then you can test everything with nix build -L .#scx

Thanks.  That is useful info.  I've got it building on my machine now following your instructions.  I'll see if I can update this PR if it's successful.

Blah, it was close I think.  Got a Meson error:
   > Message: Fetching bpftool repo
   >
   > meson.build:186:2: ERROR: Command `/build/source/meson-scripts/fetch_bpftool /build/source/build 77a72987353fcae8ce330fd87d4c7afb7677a169` failed with status 1.

log.txt

I closed this because scx 1.0.1 is out already ha.  I'll create a new PR with just the scx 1.0.1 version bump.  It did look like the build service was able to make it work for 1.0.0.

I closed this because of the scx 1.0.1 version bump.  I was gonna create a new PR, but it looks like that was the only change.


Name steps

Applied mkpr on .github/workflows/*.yml
sed s/Dependencies/install dependencies/

:tada: This PR is included in version 1.11.62 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.11.62
GitHub release

Your semantic-release bot :package::rocket:


bundler env should show bundler's shebang if it differs from the first found ruby

I was starting to tear my hair out today in a crazy debugging situation. I ran gem install bundler on OSX, and then trying to install various gems. However, I got ruby version incompatibilities: our rails app specifies ruby 2.3, but bundler reported ruby 2.0.
It turns out that rubygem's had written the bundler binstub with OSX's system ruby for it's shebang, and not the ruby installed with Homebrew. It would have been faster to debug if I had realized the discrepancy earlier.

Can you give an example of the relevant shebangs and ruby executable path?


[DOCU-2928] Kong-Debug header + configuration reference update

Description

Add new parameters to the Configuration Reference.

Compared the Enterprise and OSS versions of kong.conf.default and labelled Enterprise features accordingly
Had to make a copy of the Postgres table for 3.2.x, couldn't get version conditionals to work right without breaking the table - I think it's because I had to use both lte and gte one after the other.

Searched for and updated any instances of the kong-debug header, adding a step to first enable sending debugging info.

As part of this, cleaned up the very outdated gRPC service guide, which was mentioning Kong 1.3 everywhere.

Did not add a changelog/breaking change entry. This will be added in a separate changelog PR.
Ticket: https://konghq.atlassian.net/browse/DOCU-2928
Testing instructions
Netlify link:
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

Not doing redirects for now, as the parameter still exists in the config ref, so the links will continue to work.
We just need to make sure that we don't link to the parameter from inside our own docs; this is covered in https://github.com/Kong/docs.konghq.com/pull/5046.


Al 2043 dev

Codecov Report

Merging #967 (6f8cfb5) into dev (f10fed8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #967      +/-   ##
==========================================
+ Coverage   73.58%   73.62%   +0.03%
==========================================
  Files         132      132
  Lines       12861    12869       +8
==========================================
+ Hits         9464     9475      +11
+ Misses       3397     3394       -3

Impacted Files
Coverage Δ

assemblyline/odm/models/service.py
100.00% <100.00%> (ø)

assemblyline/odm/models/service_delta.py
100.00% <100.00%> (ø)

assemblyline/odm/randomizer.py
94.39% <0.00%> (+0.86%)
:arrow_up:

assemblyline/datasource/alert.py
92.30% <0.00%> (+3.84%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Installer reports success, while it was not

root@acai:/tmp # curl -sfL https://balena.io/engine/install.sh >balena-install.sh
root@acai:/tmp # sh -x balena-install.sh
+ tag=v17.12.0
+ uname -m
+ machine=armv7l
+ arch=armv7
+ url=https://github.com/balena-os/balena-engine/releases/download/v17.12.0/balena-engine-v17.12.0-armv7.tar.gz
+ sudo tar xzv -C /usr/local/bin --strip-components=1
+ curl -sL https://github.com/balena-os/balena-engine/releases/download/v17.12.0/balena-engine-v17.12.0-armv7.tar.gz
balena-engine/balena-engine-containerd-ctr
balena-engine/balena-engine-proxy
balena-engine/balena-engine-containerd-shim
balena-engine/balena-engine-containerd
balena-engine/balena-engine-daemon
balena-engine/balena-engine-runc
balena-engine/balena-engine

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
+ cat

   Installation successful!
 _           _
| |__   __ _| | ___ _ __   __ _
| '_ \ / _` | |/ _ \ '_ \ / _` |
| |_) | (_| | |  __/ | | | (_| |
|_.__/ \__,_|_|\___|_| |_|\__,_|

the container engine for the IoT
root@acai:/tmp #

Suggestions: download file separately, continue downloads, if previous one was aborted. Enable shell exception mode (set -e), Avoid shell pipes, as failed commands are not propagated with pipes. Test for success and report success message only on success.
ps: where the source code resides?


Rules processor should provide Advanced tab to write sql for more complex rule

We should provide a good editor to write up sql statement including syntax helper. Along with convention to refer to schema fields. We should same notation that we use everywhere else to refer to the fields.
cc @hmcl
On the rules processor side we should be able to accept the sql statement an run that.

https://github.com/hortonworks/streamline/commit/2f8f71d9eafd41c20cb55453bfec3450d6e6199b implements this feature.


[Module Proposal]: avm-ptn-avd-lza-managementplane (ptn) (tf)

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in another project that is being evolved into AVM

[X] I have checked for that this module doesn't already exist in CARML or TFVM

Terraform or Bicep?
Terraform
Module Classification?
Resource Module
Module Name
avm-ptn-avd-lza-managementplane
Module Details
Migrating and modifying the Terraform modules we are using for AVD LZA
This is already aligned with @danycontre
Please add as the following co-owner @cshea15
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username
jensheerin

@matebarabas I met with @danycontre and @moisesjgomez and we are aligned. Can you we move to next steps?
cc: @cshea15
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@matebarabas Met with Matt White and reviewed all of the AVD tf module proposals and he approves moving to in development

@jensheerin, thanks for opening this request and volunteering! Thanks for aligning with @matt-FFFFFF, @danycontre, @moisesjgomez and others.
I know you've already pasted the confirmation statement above, but for our records, please let me paste the request below (no need to respond to this again - unless you disagree 🙂).
I'll also shortly send you a final confirmation that indicates you're good to go.
Thank you!

Hi @jensheerin,
Thanks for requesting/proposing to be an AVM module owner.
We just want to confirm you agree to the below pages that define what module ownership means:

https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
https://azure.github.io/Azure-Verified-Modules/specs/shared
https://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed, let us know.
If you agree please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team

@jensheerin: I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @jensheerin,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities.
We just want to ask you to double check a few important things before you start the development.
Please visit the module index page of your module and use the following values explicitly as provided there:

ModuleName
TelemetryIdPrefix
ModuleOwnersGHTeam and ModuleContributorsGHTeam
Repository name and folder path defined in RepoURL

You can now start the development of this module! Happy coding! 🎉
Please respond to this comment, once your module is ready to be published!
Any further questions or clarifications needed, let us know.
Thanks,
The AVM Core Team

CELA review pending https://ossmsft.visualstudio.com/Reviews/_workitems/edit/48797

Thanks for the update!

CELA approved. Working on module.

Followed up with @jensheerin and this is on track for next week.

Reached out to @jensheerin offline to confirm any updates or any supported need, she or I will update accordingly.

PR pending review https://github.com/Azure/terraform-azurerm-avm-ptn-avd-lza-managementplane/pull/8

Pending review https://github.com/Azure/terraform-azurerm-avm-ptn-avd-lza-managementplane

Pending review https://github.com/Azure/terraform-azurerm-avm-ptn-avd-lza-managementplane

Hey @jensheerin per our discussion offline, kindly perform the "Requested Actions" in the AVM-Review

Hi @mbilalamjad review completed for all actions. Thank you!

"The https://github.com/Azure/Azure-Verified-Modules/issues/166 of this module has been completed and the module has been published to the registry. Requesting AVM team to update this module proposal and module index accordingly."

Thank you so much @jensheerin for owning and developing this module.
The module index on the AVM website has been updated to reflect the same.
The module has been moved from "In Review" to "Done" in the "AVM - Module Triage" Project.
This proposal (issue) is being closed as module has been published to terraform registry per below.
https://registry.terraform.io/modules/Azure/avm-ptn-avd-lza-managementplane/azurerm/latest
Any Further discussion on this module including issues & PRs to take please on its repo per below.
https://github.com/Azure/terraform-azurerm-avm-ptn-avd-lza-managementplane