Memo TS lib exports CJS only, needs to export CJS and ESM

I'm trying to use the @solana/spl-token package on a NextJS application and when I try to run this:
import { TOKEN_PROGRAM_ID } from '@solana/spl-token'
const tokenAccounts = await connection.getParsedTokenAccountsByOwner(publicKey, { programId: TOKEN_PROGRAM_ID });

I get this error:
./node_modules/@solana/spl-token/lib/esm/extensions/extensionType.mjs:5:0
Module not found: Can't resolve './memoTransfer.mjs'

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS>./pages/index.tsx

But if instead run this:
      const tokenAccounts = await connection.getParsedTokenAccountsByOwner(publicKey, { programId: new PublicKey('TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA') });

Everything works as expected.
Of course I'm using this second way for the time being, so it's not a gating issue, but thought I'd bring it up as it might be breaking something somewhere else?

It looks like the @solana/spl-token package was published 2 days ago<EMAIL_ADDRESS>A change from v0.2.0 I can see is that it now includes a dependency on @solana/spl-memo: https://www.npmjs.com/package/@solana/spl-memo
The Memo TS lib is only built with tsc: https://github.com/solana-labs/solana-program-library/blob/cccce80e65bbd4d1cdf94cfaac0de3fbf26e11c9/memo/ts/package.json#L14
It's being exported as CJS: https://github.com/solana-labs/solana-program-library/blob/cccce80e65bbd4d1cdf94cfaac0de3fbf26e11c9/memo/ts/package.json#L9
But these compiler options look wrong, they build for ESM: https://github.com/solana-labs/solana-program-library/blob/cccce80e65bbd4d1cdf94cfaac0de3fbf26e11c9/memo/ts/tsconfig.json#L3-L4
Probably what needs to happen is that the TS + package config for the Memo TS lib needs to change to look like the Token TS lib.

As a workaround, set your version to "@solana/spl-token": "^0.2.0".

As a workaround, set your version to "@solana/spl-token": "^0.2.0".

I was literally coming to add this as an FYI. You are fast. Thanks!

I'm getting same issue now.
Do I need to use ^0.2.0 version?

Sorry about that, I'll get these fixed up to be consistent


refactor: use flag package over os.Arg

Unfortunately I don't think I see the point in this PR.
In my opinion, examples are supposed to be simple and straight to the point. I decided against using flag simply because it would add unnecessary bloat considering both are actually required arguments.
I'd like examples to be easily glance-able and this PR seems to take a step back instead.


7 lexer using chumsky

This PR let's chumsky handle the parsing stuff.
Resolves:

https://github.com/soywod/rfc2047-decoder/issues/7
https://github.com/soywod/rfc2047-decoder/issues/3 as you can see here and here its test
https://github.com/soywod/rfc2047-decoder/issues/1 which is done here and which is checked here

hm... I'm a little bit unsure about my tests since some tests are executed "twice" or multiple times but take your time first to review it, then we can talk about it.

@soywod (just a little reminder, because I don't know if you got notified)

I saw, I'm just off for a while I will check when I come back. Thank you for the feature!

@soywod did you take a look or should I take care of this?

Hard to review because there is to many changes, but looks good to me! Thank you :tada:


PSCC paper: Bounds on all variables

Fixes #9

@frederikgeth, @hakanergun, @arpkoirala
I'm pleased to announce that adding bounds has decreased computational time for the specific cases:

one-shot: 2.0 -> 0.8 sec
iteratively:  25.0 -> 1.7 sec (3 itr)

The iterative approach still takes longer than the one-shot, but it is the expectation that this will change when scaling the problem.
Please also note the following strange behavior, requiring further investigation:

For the one-shot formulation, the power bounds are enforced.
For the iterative formulation, the current bounds are enforced.
Enforcing the other bounds for each respective formulation results in infeasibility.

closes #9


Delayed adjusting after light turned back on

Home Assistant Adaptive Lighting Issue Template
Bug Reports
If you need help with using or configuring Adaptive Lighting, please open a Q&A discussion thread here instead.
Before submitting a bug report, please follow these troubleshooting steps:
Please confirm that you have completed the following steps:

[x] I have updated to the latest Adaptive Lighting version available in HACS.
[x] I have reviewed the Troubleshooting Section in the README.
[ ] (If using Zigbee2MQTT) I have read the Zigbee2MQTT troubleshooting guide in the README.
[x] I have checked the V2 Roadmap and open issues to ensure my issue isn't a duplicate.

Required information for bug reports:
Please include the following information in your issue.
Issues missing this information may not be addressed.

Debug logs captured while the issue occurred. See here for instructions on enabling debug logging:

2023-08-05 14:57:17.171 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected a 'light.office' 'state_changed' event: '{'supported_color_modes': [<ColorMode.BRIGHTNESS: 'brightness'>], 'color_mode': <ColorMode.BRIGHTNESS: 'brightness'>, 'brightness': 0, 'friendly_name': 'Bureau', 'supported_features': <LightEntityFeature: 0>}' with context.id='01H72WC23KANDQ8RZMQBG8RC6V'
2023-08-05 14:57:17.171 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected an 'off' → 'on' event for 'light.office' with context.id='01H72WC23KANDQ8RZMQBG8RC6V'
2023-08-05 14:57:17.171 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='01H72WC23KANDQ8RZMQBG8RC6V'
2023-08-05 14:57:17.171 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] just_turned_off: delta_time='36.034285' > delay='5'
2023-08-05 14:57:17.172 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='01H72WC23KANDQ8RZMQBG8RC6V'
2023-08-05 14:57:17.172 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: '_update_attrs_and_maybe_adapt_lights' called with context.id='01H72WC23M:al:IJ2X:lght:03' lights: '['light.office']', transition: '0.0', force: 'True'
2023-08-05 14:57:17.172 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: filtered_lights: '['light.office']'
2023-08-05 14:57:17.172 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: Calling _adapt_light from _update_attrs_and_maybe_adapt_lights: 'light.office' with transition 0.0 and context.id=01H72WC23M:al:IJ2X:lght:03
2023-08-05 14:57:17.172 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='01H72WC23KANDQ8RZMQBG8RC6V'
2023-08-05 14:57:17.172 DEBUG (MainThread) [custom_components.adaptive_lighting.adaptation_utils] Preparing adaptation data for light.office with service data {'entity_id': 'light.office', 'brightness': 255}
2023-08-05 14:57:17.173 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: execute_cancellable_adaptation_calls with data: AdaptationData(entity_id='light.office', context=<homeassistant.core.Context object at 0x7f4610f82a20>, sleep_time=0.0, service_call_datas=<async_generator object _create_service_call_data_iterator at 0x7f4619006040>, force=True, max_length=1, which='brightness', initial_sleep=False)
2023-08-05 14:57:17.176 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: Scheduling 'light.turn_on' with the following 'service_data': {'entity_id': 'light.office', 'brightness': 255} with context.id='01H72WC23M:al:IJ2X:lght:03'
2023-08-05 14:57:17.178 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected an 'light.turn_on('['light.office']')' event with context.id='01H72WC23M:al:IJ2X:lght:03'
2023-08-05 14:57:17.201 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected a 'light.office' 'state_changed' event: '{'supported_color_modes': [<ColorMode.BRIGHTNESS: 'brightness'>], 'color_mode': <ColorMode.BRIGHTNESS: 'brightness'>, 'brightness': 255, 'friendly_name': 'Bureau', 'supported_features': <LightEntityFeature: 0>}' with context.id='01H72WC23M:al:IJ2X:lght:03'
2023-08-05 14:57:17.201 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] AdaptiveLightingManager: New adapt '<state light.office=on; supported_color_modes=[<ColorMode.BRIGHTNESS: 'brightness'>], color_mode=brightness, brightness=255, friendly_name=Bureau, supported_features=0 @ 2023-08-05T14:57:17.171118+02:00>' found for light.office
2023-08-05 14:57:17.201 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] No transition in last adapt for light light.office, continuing...
2023-08-05 14:57:24.089 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected an 'on' → 'off' event for 'light.office' with context.id='01H72WC8VRKPPHE09Z697WNGV2'
2023-08-05 14:57:28.087 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected a 'light.office' 'state_changed' event: '{'supported_color_modes': [<ColorMode.BRIGHTNESS: 'brightness'>], 'color_mode': <ColorMode.BRIGHTNESS: 'brightness'>, 'brightness': 0, 'friendly_name': 'Bureau', 'supported_features': <LightEntityFeature: 0>}' with context.id='01H72WCCRPKTF3FDD3HD26X7TN'
2023-08-05 14:57:28.088 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected an 'off' → 'on' event for 'light.office' with context.id='01H72WCCRPKTF3FDD3HD26X7TN'
2023-08-05 14:57:28.088 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='01H72WCCRPKTF3FDD3HD26X7TN'
2023-08-05 14:57:28.088 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] just_turned_off: Waiting with adjusting 'light.office' for 1.000349
2023-08-05 14:57:28.234 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected a 'light.office' 'state_changed' event: '{'supported_color_modes': [<ColorMode.BRIGHTNESS: 'brightness'>], 'color_mode': <ColorMode.BRIGHTNESS: 'brightness'>, 'brightness': 15, 'friendly_name': 'Bureau', 'supported_features': <LightEntityFeature: 0>}' with context.id='01H72WCCX9ZPF1EBQGMSH7WX28'
2023-08-05 14:57:37.806 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: '_update_attrs_and_maybe_adapt_lights' called with context.id='01H72WCP8D:al:IJ2X:ntrv:04' lights: 'None', transition: '0.0', force: 'False'
2023-08-05 14:57:37.806 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: filtered_lights: '['light.office']'
2023-08-05 14:57:37.806 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: Calling _adapt_light from _update_attrs_and_maybe_adapt_lights: 'light.office' with transition 0.0 and context.id=01H72WCP8D:al:IJ2X:ntrv:04
2023-08-05 14:57:37.806 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='None'
2023-08-05 14:57:37.806 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: 'light.office' is locked
2023-08-05 14:57:39.092 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] just_turned_off: 'light.office' is still on after 11.000349 seconds, assuming it was intended to be on
2023-08-05 14:57:39.093 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='01H72WCCRPKTF3FDD3HD26X7TN'
2023-08-05 14:57:39.093 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: '_update_attrs_and_maybe_adapt_lights' called with context.id='01H72WCQGN:al:IJ2X:lght:05' lights: '['light.office']', transition: '0.0', force: 'True'
2023-08-05 14:57:39.093 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: filtered_lights: '['light.office']'
2023-08-05 14:57:39.093 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: Calling _adapt_light from _update_attrs_and_maybe_adapt_lights: 'light.office' with transition 0.0 and context.id=01H72WCQGN:al:IJ2X:lght:05
2023-08-05 14:57:39.093 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] is_proactively_adapting_context='False', context_id='01H72WCCRPKTF3FDD3HD26X7TN'
2023-08-05 14:57:39.094 DEBUG (MainThread) [custom_components.adaptive_lighting.adaptation_utils] Preparing adaptation data for light.office with service data {'entity_id': 'light.office', 'brightness': 255}
2023-08-05 14:57:39.094 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: execute_cancellable_adaptation_calls with data: AdaptationData(entity_id='light.office', context=<homeassistant.core.Context object at 0x7f461a318c70>, sleep_time=0.0, service_call_datas=<async_generator object _create_service_call_data_iterator at 0x7f460493aa40>, force=True, max_length=1, which='brightness', initial_sleep=False)
2023-08-05 14:57:39.097 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Bureau: Scheduling 'light.turn_on' with the following 'service_data': {'entity_id': 'light.office', 'brightness': 255} with context.id='01H72WCQGN:al:IJ2X:lght:05'
2023-08-05 14:57:39.097 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected an 'light.turn_on('['light.office']')' event with context.id='01H72WCQGN:al:IJ2X:lght:05'
2023-08-05 14:57:39.120 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Detected a 'light.office' 'state_changed' event: '{'supported_color_modes': [<ColorMode.BRIGHTNESS: 'brightness'>], 'color_mode': <ColorMode.BRIGHTNESS: 'brightness'>, 'brightness': 255, 'friendly_name': 'Bureau', 'supported_features': <LightEntityFeature: 0>}' with context.id='01H72WCQGN:al:IJ2X:lght:05'
2023-08-05 14:57:39.120 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] AdaptiveLightingManager: New adapt '<state light.office=on; supported_color_modes=[<ColorMode.BRIGHTNESS: 'brightness'>], color_mode=brightness, brightness=255, friendly_name=Bureau, supported_features=0 @ 2023-08-05T14:57:28.086986+02:00>' found for light.office
2023-08-05 14:57:39.120 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] No transition in last adapt for light light.office, continuing...

Your Adaptive Lighting configuration:

lights:
  - light.office
prefer_rgb_color: false
include_config_in_attributes: true
initial_transition: 0
sleep_transition: 1
transition: 0
transition_until_sleep: false
interval: 90
min_brightness: 1
max_brightness: 100
min_color_temp: 2000
max_color_temp: 5500
sleep_brightness: 1
sleep_rgb_or_color_temp: color_temp
sleep_color_temp: 1000
sleep_rgb_color:
  - 255
  - 56
  - 0
sunrise_time: null
max_sunrise_time: null
sunrise_offset: 0
sunset_time: null
min_sunset_time: null
sunset_offset: 0
only_once: false
take_over_control: true
detect_non_ha_changes: true
separate_turn_on_commands: false
send_split_delay: 0
adapt_delay: 0
autoreset_control_seconds: 0
skip_redundant_commands: true
name: Bureau

(If using Zigbee2MQTT), provide your configuration files (remove all personal information before posting):

devices.yaml
groups.yaml
configuration.yaml ⚠; Warning REMOVE ALL of the PERSONAL INFORMATION BELOW before posting ⚠;

mqtt: server:
mqtt: user:
mqtt: password:
advanced: pan_id:
advanced: network_key:
anything in log_syslog if you use this

Brand and model number of problematic light(s)

Describe the bug and how to reproduce it:

When a light turns off, and back on again in 'semi-rapid' succession, the light does not start adapting after a period (I think the interval period, but not 100% sure).
For example, my light in the bathroom is automated with a motion sensor, it happens from time to time that I have to wave my hand to turn it on again 😅  but that turns on the lights to the lowest brightness (this is configured by myself, as I cannot have a dynamically set brightness in my KNX setup).
In the logs I have simulated the behaviour for my 'Bureau' lights

Steps to reproduce the behavior:

Turn light on, let AL adjust the light
Turn light off and back on again

This is actually a protection mechanism to make sure that lights that are just turned off, are not turned on by AL.
What can happen is that one turns the light off with a light.turn_off, then HA updates the state, and the light claims to be on (even though it is turning off or actually off).
To make sure we are not in this situation, we wait a little while to check whether the lights are actually off.
It seems like your lights are turned on outside of HA (so not with a light.turn_on) and therefore only report the on state again.
In this case we cannot distinguish between the protection mechanism and what happens in your case.
You can see that there is no light.turn_on because this message:
Detected an 'off' → 'on' event for 'light.office' with context.id='01H72WC23KANDQ8RZMQBG8RC6V'

is not accompanied by a
# I wrote this one, this does NOT appear in your logs
Detected an 'light.turn_on('['light.office']')' event with context.id='01H72WC23KANDQ8RZMQBG8RC6V'

Can you confirm that it is something outside of HA that turns on the lights?

Yep that is correct, a physical button (or sensor) turns on and off the lights.
Other than increasing the turn-off timer of the sensor,  would you have any other ideas on how to mitigate this issue?

Perhaps you can have an automation like:
automation:
  - alias: "Set Manual Control to False after Light Turned On"
    trigger:
      - platform: state
        entity_id: light.YOUR_LIGHT_ENTITY_ID_HERE
        from: 'off'
        to: 'on'
    action:
      - service: adaptive_lighting.set_manual_control
        data:
          entity_id: switch.YOUR_ADAPTIVE_LIGHTING_SWITCH_ENTITY_ID_HERE
          lights:
            - light.YOUR_LIGHT_ENTITY_ID_HERE
          manual_control: false

Thanks! I'll try that one in the coming days.
I'll go ahead and close this issue is it's working by design, I do see the reason why it's there :D


Key Vault live tests do not make use of AZURE_AUTHORITY_HOST

When running tests with a custom AZURE_AUTHORITY_HOST environment variable set many tests fail with error:
Exception: Preparer failure when creating resource KeyVaultPreparer for test test_example_keys_recover (test_samples_keys_async.TestExamplesKeyVault): , AdalError: Get Token request returned http error: 400 and server response: {"error":"invalid_request","error_description":"AADSTS900382: Confidential Client is not supported in Cross Cloud request.\r\nTrace ID: a187be58-eef5-440b-83e4-ebbf32faad00\r\nCorrelation ID: 9c512854-1e95-4fb4-b835-61eece4b285c\r\nTimestamp: 2020-04-28 06:00:26Z","error_codes":[900382],"timestamp":"2020-04-28 06:00:26Z","trace_id":"a187be58-eef5-440b-83e4-ebbf32faad00","correlation_id":"9c512854-1e95-4fb4-b835-61eece4b285c"}

(source)
This may have something to do with how the preparer uses EnvironmentCredential and EnvironmentCredential doesn't directly reference AZURE_AUTHORITY_HOST  in an obvious way

The right thing should happen here re the authority, given the code in master. It's certainly not obvious but in this case the client responsible for sending requests to AAD will consume AZURE_AUTHORITY_HOST (via get_default_authority) when no authority is otherwise specified.

@chlowell  - Are you saying there is a bug in the test or in the lib code?

I'm saying the preparer uses EnvironmentCredential correctly and that credential doesn't reference AZURE_AUTHORITY_HOST because that variable is consumed elsewhere.
Actually it appears the failure here occurs when creating a Key Vault, so I'd guess the management library's credential is misconfigured (in which case EnvironmentCredential doesn't enter into it).

@danieljurek - What part of the test is failing?  I'm not seeing a KV being created in the test it self.
My local EnvCred tests work against other clouds - so I'm guessing this is something to do with the test code.

The Key Vault is created by KeyVaultPreparer, one instance for each test case it decorates (almost all of them). I'm thinking the problem here is the preparer's management client not getting the right authority. I don't know how to configure a track 1 credential's authority or where that's done in CI runs, but it isn't in the Key Vault test code--I'd start with the preparer's base class, AzureMgmtPreparer in devtools_testutils.
This begins to look like a project for me, if no one else is already investigating. When do we hope to have these tests passing?

Has there been any update to this issue?

A few things have changed. azure-mgmt-keyvault now has a track 2 version, so the management client should (certainly could) use an azure-identity credential which observes $AZURE_AUTHORITY_HOST. But we're now replacing KeyVaultPreparer with a pipeline job/script that creates vaults. Upshot is, this particular failure may not occur anymore but the scenario now depends on configuring that job/script. @danieljurek, are you still working on sovereign cloud testing?

Hey @chlowell  and @mccoyp, questions about live testing configuration and sovereign cloud testing should go to @benbp going forward. Thanks!

KeyVaultPreparer is no longer in use and sovereign cloud testing for KV is tracked by a new issue (https://github.com/Azure/azure-sdk-for-python/issues/20775), so I'll close this issue.


Check server exceptions

[x] handle /auth/eth exceptions caused by the older accounts/app versions gracefully
[ ] handle emails verification failures
[ ] search/investigate other exceptions

@alt-a1r
here you’d have to investigate the whole app regarding server errors handling
2:53
server returns an json response with shape {ok: 0|1, error?: string}
2:53
if code = 200 but ok = 0 this is an error and should be handled like error
2:54
check API.js we may have axios interceptor which checks ok and creates Error with response.data.error as message
2:54
also you’d need to make sure we’re handling errors after API calls correctly
2:55
depending to the situation we may show dialog or go to different screen. need to make sure the error of any call will be caught, logged and the corresponding action would be perfrormed
2:55
if we’re omitting the error, it should be logged anyway with log.warn
2:56
if we don’t awaiting for something, the error should be caught and warn-logged by .catch(e => log.warn(‘lalbel’, e.message, e)
2:56
start from API.js, check how do we handling ok:0 responses
2:56
then track api methods, where they are called from
2:57
and check corresponding components/hooks etc

@johnsmith-gooddollar higher priority is to investigate actual errors we get on sentry/monitoring alerts

@alt-a1r ^^^


Add requestRichPresence

Hi there, I decided to implement this so this module has rich presence capabilities on par with the capabilities offered by node-steam: https://github.com/seishun/node-steam/tree/master/lib/handlers/rich_presence (and I needed to mark off an excuse for why I haven't moved a project from node-steam to node-steam-user)
There's one thing in the implementation that on second thoughts could be implemented differently. First of all if RP cannot be parsed by the parser (most likely because the user is not in the game), I decided to omit the SteamID entirely from the response. In my head I figured it would be easier for a user to check whether the key exists in the object, instead of checking if the keys in the response was > 0 or checking if a key exists. I suppose this can instead be implemented where the key is added to the response for that SteamID and the value is a blank object (user would have to check len of keys in the response), or just a falsy value (false, null).
Also I'm aware that getPersonas gives RP data, but as I'm sure you know that's only for friends and this method can be called on total strangers (non friends) which is very cool!
Here's an example of a response of me chilling in the CS:GO main menu:
{
	users: {
		'76561197993496553': {
			status: 'Playing CS:GO',
			version: '13762',
			time: '17.338300',
			'game:state': 'lobby',
			steam_display: '#display_Menu',
			connect: '+gcconnectGXXXXXXXX'
		}
	}
}

Why not just use the rich presence data already present in the user event?

Why not just use the rich presence data already present in the user event?

I've only seen this work with people who are friends with the bot. Whenever I use getPersonas on an account not friends with the bot and then catch the user and getPersonas callback I've noticed the rich_presence array to be empty.
When using this however I've found it to be foolproof and work everytime, even on people who have private profiles.

I see. Okay.
I would prefer to also break the RP parsing code from processUser and apply it here as well to get the localized string.

Ah of course, in my haste I didn't even consider this, will do

Looking at the RP parsing code from processUser: https://github.com/DoctorMcKay/node-steam-user/blob/79e3fc2fb5ec0be6a26a2c076479dd9876a26f75/components/friends.js#L973 it doesn't look like the rich_presence values ever get modified correct? Here is the code and some sample output:
[
    {
      key: 'status',
      value: 'Offline Casual workshop/243702660/aim_botz'
    },
    { key: 'version', value: '13762' },
    { key: 'time', value: '50.807220' },
    { key: 'game:state', value: 'game' },
    { key: 'steam_display', value: '#display_GameWkshpMap' },
    { key: 'game:act', value: 'offline' },
    { key: 'game:mode', value: 'casual' },
    { key: 'game:map', value: 'workshop/243702660/aim_botz' },
    { key: 'game:server', value: 'offline' }
]

Oh I think I get what you mean, use the same implementation you use for parsing the RP string and apply it to all the properties for in the RP object we get now.

Yeah, the parsing code doesn't actually modify any of the RP values, it just uses them to determine the localized string displayed in the client.
Since RP keys can be anything, I don't think that simply adding a localized_string property (or whatever) to the object you're returning is 100% foolproof, but maybe it's fine to do.

How's this, the response from requestRichPresence will look like this:
{
	"users": {
		"76561197993496553": {
			"RP": {
				"status": "Playing CS:GO",
				"version": "13762",
				"time": "17.367492",
				"game:state": "lobby",
				"steam_display": "#display_Menu",
				"connect": "+gcconnectG01FB0FE9"
			},
			"localizedString": "Playing CS:GO"
		}
	}
}

and the original behaviour from processUser is still maintained:
{
	rich_presence: [{
			key: 'status',
			value: 'Playing CS:GO'
		},
		{
			key: 'version',
			value: '13762'
		},
		{
			key: 'time',
			value: '17.367492'
		},
		{
			key: 'game:state',
			value: 'lobby'
		},
		{
			key: 'steam_display',
			value: '#display_Menu'
		},
		{
			key: 'connect',
			value: '+gcconnectG01FB0FE9'
		}
	],
	rich_presence_string: 'Playing CS:GO'
}

I made a helper function called _getRPLocalizedString for this.

I was getting empty presence using approach discussed in https://dev.doctormckay.com/topic/2474-rich-presence/
After testing method added by this branch, which requires setting appID, I could get proper presence of contacts on my friends list.

Released in 4.18.0.


Fetch data from each endpoint

CI failed on other code, do you need me to remove the dead code?

Yes， let's make the ci happy


Export Report as Word Doc

As a user, I want to export reports as Word Docs, so that I can have the report in the format I want.
Acceptance Criteria:

The report export dropdown adds Word Doc as an option

Original report: https://github.com/mitre-attack/tram/pull/43

This will be fixed in #151 (which is cherry picked from #129).


[TOOLING] Validator fixes

2023-02-Sprint special edition.
Addressing the open-ended Tooling goal “Review issues and comments related to Python validator (trim down technical debt)”.
@erdalkaraca — in case you want to have a look at what's happening :)

As of a137c6d this uses my bids-examples fork for testing, should be reverted before pull once https://github.com/bids-standard/bids-examples/pull/351 is merged OR we create .bidsignore as part of the test suite.

As of 05bbe33 this uses my bids-examples fork for testing, should be reverted before pull once bids-standard/bids-examples#351 is merged OR we create .bidsignore as part of the test suite.

This has been merged upstream, using vanilla BIDS examples again.

@effigies I know you prob have enough on your plate after last week, but if you could get a chance to look at this soon it would save a lot of trouble further down the line. This touches/reorganizes a bunch of things and is likely to need significantly more rebasing the later it is to be merged :/

Also, the test failure is stochastic link checking unrelated to this PR.

@effigies all done save for two I left open. I think the list might make things easier than the set here... as for the default path for https://github.com/bids-standard/bids-schema — whenever that one might land. What else do you suggest? Alternatively we could leave it as-is and deal with that when we have can distribute the first 2 BIDS-versions which are schema-compatible.

@tsalo interested in merging this?

@effigies looking good? There's a new test failure though, not really sure where it comes from 🤔

Looks like you made bids_reference_root=None in one place, but then it never gets used. And the other one is still a hard path. What about:
diff --git a/tools/schemacode/bidsschematools/validator.py b/tools/schemacode/bidsschematools/validator.py
index bbb5b6e5..32f301ca 100644
--- a/tools/schemacode/bidsschematools/validator.py
+++ b/tools/schemacode/bidsschematools/validator.py
@@ -285,7 +285,7 @@ def log_errors(validation_result):
 def select_schema_path(
     bids_version=None,
     bids_root=None,
-    bids_reference_root="/usr/share/bids-schema/versions",
+    bids_reference_root=None,
 ):
     """
     Select schema directory, according to a priority logic whereby the schema path is
@@ -326,6 +326,10 @@ def select_schema_path(
         enforcement on the package distribution side.
     """

+    if bids_reference_root is None:
+        lgr.warning("No BIDS reference root provided.")
+        return None
+
     bids_reference_root = os.path.abspath(os.path.expanduser(bids_reference_root))

     schema_dir = False
@@ -599,6 +603,7 @@ def validate_bids(
         schema_path = select_schema_path(
             bids_version,
             bids_root,
+            bids_reference_root=bids_reference_root,
         )

     regex_schema, my_schema = bst.rules.regexify_all(schema_path)

@effigies what about now? :)

💛


Add Travis badge

I'm pretty sure you'll have to do PR "fix Travis build" first ;) .

I wanted to see if travis would pass actually. And not. I'd say merge this PR, because it will help us see that travis doesn't pass. Then either fix travis or leave this repo, but at least, we'll be explicit about travis not passing ^^

@k4nar ?

Ok why not.


Improve error messages of unset Providers for unchained Providers

We could include the properties identity in an error message


Fix index and overflow error in itertools

fix index error (refer to CPython)

test_permutations (__main__.TestBasicOps) ... thread 'main' panicked at 'index out of bounds: the len is 4 but the index is 4', vm/src/stdlib/itertools.rs:1420:42

fix overflow error in debug mode when r > n

Is there a itertools test that we can remove the unittest.skip() decorator from now? Or did that panic only happen in debug mode?

As i've heard, it only occured in debug mode.


vscode doesnt support c blah blah blah

VS Code doesn't ship support for C++ out of the box and it's provided by extensions and (supported) compiler of your choise.
Please see steps https://code.visualstudio.com/dges/cpp and https://code.visualstudio.com/docs/cpp/introvideos-cpp for setup steps and other information on how to use C++ in VS Code.
Originally posted by @IllusionMH in https://github.com/microsoft/vscode/issues/134181#issuecomment-931162887

404 on first link!

I don't understand why you would create this issue to just restate what was told to you before. C++ is not supported out of the box in VS Code and I doubt will ever be. Any questions related to C++ should be routed to the C++ extension team https://github.com/microsoft/vscode-cpptools


Update OWNERS file

Signed-off-by: Fabricio Aguiar<EMAIL_ADDRESS>

/approve

it needs to be merged to fix the CI
https://github.com/openshift/release/pull/35407

/retest


Set minimum trade size

Hi, I would like to ask how to add a "minimum x% trade size" constraint?
The result should be either 0% (not holding it) or at least x% (if optimizer wants to hold it, hold it >= x%)
I have tried with weight_bound=((x/100),1), but the result buys every stock at x% which is not what I want to achieve...
I have also tried with custom constraints: dummy_ef.add_constraint(lambda w: w * (w - (x/100)) >= 0) but it gave me error 'Problem does not follow DCP rules.".

Theoretically: That makes the portfolio optimize on a non-continuous space, if you are not lucky then the optimization reach an invalid point and also cannot continue to go, i.e. it fails. You can take a look at keyword "Discontinuous Constraint", for example this paper: https://support.sas.com/resources/papers/proceedings16/1820-2016.pdf
Technically: You still want to do that, just mask that requirement as invalid area so the portfolio optimization will not choose any point in that area to optimize.
P/s: I talked about the previous convex-optimization version of this library, I didnt check a new version, so I cant help you to write the constraint. Another approach is global optimization, e.g. Bayesian Optimization which will check "all" possible and valid weights, therefore you will have a result and meet your requirement.

@iamagent001 As mentioned by @88d52bdba0366127fffca9dfa93895, you're proposed constraint makes the problem nonconvex. We can still solve it using mixed-integer programming, as outlined here.
Please find below an example where every weight is either 0, or in [0.1, 1.0].
import cvxpy as cp

from tests.utilities_for_tests import setup_efficient_frontier

ef = setup_efficient_frontier()
z = cp.Variable(ef.n_assets, boolean=True)

lb = 0.1
ub = 1.0
ef.add_constraint(lambda w: lb * z <= w)
ef.add_constraint(lambda w: w <= ub * z)

ef.min_volatility()
print(ef.clean_weights().values())


Project inactive?

I see the commits, it did not update for almost 5 or 6 years. Does it inactive or dead?

where's the difference?
good alternatives in case you miss features are recaf and ByteCodeViewer.
I still use it as main tool tho.


have a gofabric8 erase-pvc command

when working with fabric8 its very common for keycloak to barf. e.g. reboot your laptop and try to restart your minikube/minishift VM and keycloak won't start. WIT has similar issues too when you recreate the PVC for keycloak.
So it'd be handy to have a gofabric8 erase-pvc command like this...
$ gofabric8 erase-pvc keycloak-db-postgresql-data
persistentvolumeclaim "keycloak-db-postgresql-data" deleted
persistentvolumeclaim "keycloak-db-postgresql-data" created
pod "keycloak-db-3064796942-4vhn2" deleted
pod "keycloak-3463143011-1jhkc" deleted

i.e. it'd find the PVC; delete it, then recreate an empty version which has the same labels and spec but removing the spec. volumeName value (so its not bound to the PV) and with no status. Also remove the annotations added by the storage implementation like these:
    control-plane.alpha.kubernetes.io/leader: '{"holderIdentity":"e3faf84f-a9b8-11e7-bc26-0ec1a5fcab50","leaseDurationSeconds":15,"acquireTime":"2017-10-05T10:41:51Z","renewTime":"2017-10-05T10:41:53Z","leaderTransitions":0}'
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"labels":{"group":"io.fabric8.apps","project":"keycloak-db","provider":"fabric8","version":"1.0.2"},"name":"keycloak-db-postgresql-data","namespace":"fabric8"},"spec":{"accessModes":["ReadWriteOnce"],"resources":{"requests":{"storage":"1Gi"}},"storageClassName":"standard"}}
    pv.kubernetes.io/bind-completed: "yes"
    pv.kubernetes.io/bound-by-controller: "yes"
    volume.beta.kubernetes.io/storage-provisioner: k8s.io/minikube-hostpath

Then extra bonus points for also deleting all pods which reference this PVC. Even more brownie points for also deleting all pods which depend on those pods (e.g. keycloak DB and keycloak pods - ditto for WIT etc) though for now only immediate dependencies would probably do the trick

@chmouel fancy having a go?

this would mean after a reboot folks would just have to type gofabric8 erase-pvc keycloak-db-postgresql-data and hopefully keycloak would eventually startup again. They'd have to login again from scratch mind; but at least KC would startup so they could login

sounds good! I'd trash the creationDate too really


[SPARK-46638][Python] Create Python UDTF API to acquire execution memory for function evaluation

What changes were proposed in this pull request?
This PR creates a Python UDTF API to acquire execution memory for future function evaluation in the 'eval' and 'terminate' and 'cleanup' methods.
For example, this UDTF accepts an argument representing the requested amount of memory to allocate (of which it will receive some subset), and a second argument containing the minimum memory allowed. It sets a status column to indicate an "out of memory" condition if the latter exceeds the memory allocated by Spark:
from dataclasses import dataclass
from pyspark.sql.functions import AnalyzeResult
from pyspark.sql.types import IntegerType, LongType, StringType, StructType

@dataclass
class CustomAnalyzeResult(AnalyzeResult):
    minMemoryMb: int = 0

class UDTFAcquireExecutionMemory:
    def __init__(self, analyze_result):
        self._analyze_result = analyze_result

    @staticmethod
    def analyze(**kwargs):
        requested_memory_mb = kwargs.get("requested_memory_mb")
        min_memory_mb = kwargs.get("min_memory_mb").value
        if requested_memory_mb is not None:
            assert(
                requested_memory_mb.dataType == IntegerType() or
                requested_memory_mb.dataType == LongType())
            requested_memory_mb_value = requested_memory_mb.value
        else:
            requested_memory_mb_value = None
        return CustomAnalyzeResult(
            schema=StructType()
                .add("initial_request", LongType())
                .add("acquired_memory", LongType())
                .add("min_memory", LongType())
                .add("status", StringType()),
            acquireExecutionMemoryMbRequested=requested_memory_mb_value,
            minMemoryMb=min_memory_mb)

    def eval(self, **kwargs):
        pass

    def terminate(self):
          yield (
              self._analyze_result.acquireExecutionMemoryMbRequested,
              self._analyze_result.acquireExecutionMemoryMbActual,
              self._analyze_result.minMemoryMb,
              "OK" if self._analyze_result.acquireExecutionMemoryMbActual >=
                  self._analyze_result.minMemoryMb else "Insufficient memory")

Invoking it yields the following:
SELECT * FROM UDTFAcquireExecutionMemory(
    requested_memory_mb_value => 4,
    min_memory_mb => 0)

> 4	4	0	OK

SELECT * FROM UDTFAcquireExecutionMemory(
    requested_memory_mb_value => 4,
    min_memory_mb => 10)

> 4	4	10	Insufficient memory

Why are the changes needed?
Python UDTFs that import large libraries or otherwise use up a lot of memory from storing many input rows in memory need to register this memory usage with Spark executors in order to protect against OOM crashes.
Does this PR introduce any user-facing change?
Yes, see above.
How was this patch tested?
This PR adds test coverage.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @ueshin @allisonwang-db

@dtenedor I did some dumb memory profiling running the following UDTF
from pyspark.sql.functions import udtf
import resource

@udtf(returnType="step: int, memory: int")
class SimpleUDTF:
    def __init__(self, *args, **kwargs):
        self.step_id = 0

    @staticmethod
    def get_peak_memory_usage_kb() -> int:
        return resource.getrusage(resource.RUSAGE_SELF).ru_maxrss

    def eval(self, *args, **kwargs):
        yield self.step_id, self.get_peak_memory_usage_kb()
        self.step_id += 1

    def terminate(self, *args, **kwargs):
        yield self.step_id, self.get_peak_memory_usage_kb()

spark.udtf.register("pyUdtfMemProfile", SimpleUDTF)

I'm not entirely confident in the results because I noticed running a high memory UDTF before the profiling UDTF would increase the peak memory usage (I guess they share a process?). But on a fresh 14.2 cluster I ran this and got max memory usage across 100 UDTFs of 45440 KB, which seems reasonable. Peak memory usage of my vanilla conda distribution on my mac is 16400 KB and it makes sense that UDTF framework would need extra stuff loaded into memory.
What do you think about designing UDTFs so that we take a save overestimate of this (say 50000 KB) as the memory floor handled entirely by Scala (i.e. the UDTF framework will always retry if it can't get at least this amount of memory). Then in the user-provided part of the code, users can specify how much additional memory they would like to request just for holding their class instance attributes (e.g. for AI_FORECAST, just the size of the training data).
If this sounds reasonable to you, we could also add some unit tests making sure that the no-modifications Py UDTF memory requirements don't exceed 50KB

After offline discussion, I am going to close this PR since the memory PySpark uses is off-heap which as @ueshin points out is not the same memory as the on-heap memory generally tracked by the TaskMemoryManager. We can always reopen it later if we want to revive the approach.

@dtenedor I just had another thought about making something like this more usable for python users. It would be awesome to also provide a utility for python users to inspect their current instantaneous memory usage.
They could use this during analyze() to get the size of their in-scope libraries and, assuming things are comparable on the executor, could request that amount + X MB for any additional data they would collect. Additionally they could use this inside eval() and terminate() and possibly execute some conditional logic if they are close to their allocated memory limit.

@nickstanishadb how would this be different from calling Python's resource.getrusage within the analyze method, and then adding the resulting memory number into a subclass of AnalyzeResult to be propagated to subsequent __init__ and eval/terminate methods? https://github.com/apache/spark/blob/master/python/docs/source/user_guide/sql/python_udtf.rst


fix appendToBody

Fixes https://github.com/joshuaeasy/vue3-daterange-picker/issues/1

Thanks @artdnlv for your contribution 😊


vscode: update some extensions

Description of changes
Noticed at the last minute that github.vscode-pull-request-github is also done by #177446.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build vscode-extensions.llvm-vs-code-extensions.vscode-clangd vscode-extensions.eamodio.gitlens vscode-extensions.arrterian.nix-env-selector vscode-extensions.streetsidesoftware.code-spell-checker vscode-extensions.github.vscode-pull-request-github


Publish Helm chart 0.4.1

Summary
Publish the Helm chart for latest release otel-collectors-0.4.1.

Published with #94.


Headers

A user should be able to specify headers on pub and be given headers on a sub callback.

Looks like the protocol has changed somewhat
https://docs.nats.io/reference/reference-protocols/nats-protocol#hmsg
The HMSG and HPUB now need a NATS header version prefix
HPUB FOO 22 33␍␊NATS/1.0␍␊Bar: Baz␍␊␍␊Hello NATS!␍␊

The parser already deals with this 🎉 the transformer does not 😞


Added Get-AppLockerConfig

This is a new situational awareness module that will check the AppLocker policy for a user-supplied executable or all executables in a filepath for a specified user.

Having a bit of an issue getting output from the script to come back to the agent and could use some help.

Hi @matterpreter, you should replace Write-Host with Write-Output. With this change everything works for me:
(Empire: powershell/situational_awareness/host/applockerstatus) > set Executable c:\windows\system32\calc.exe
(Empire: powershell/situational_awareness/host/applockerstatus) > execute
[*] Tasked 8NRZSV4X to run TASK_CMD_WAIT
[*] Agent 8NRZSV4X tasked with task ID 6
[*] Tasked agent 8NRZSV4X to run module powershell/situational_awareness/host/applockerstatus
(Empire: powershell/situational_awareness/host/applockerstatus) > [*] Agent 8NRZSV4X returned results.
[-] User does not exist. Exiting...
[*] Valid results returned by <IP_ADDRESS>
(Empire: powershell/situational_awareness/host/applockerstatus) > set User winnie
(Empire: powershell/situational_awareness/host/applockerstatus) > execute
[*] Tasked 8NRZSV4X to run TASK_CMD_WAIT
[*] Agent 8NRZSV4X tasked with task ID 7
[*] Tasked agent 8NRZSV4X to run module powershell/situational_awareness/host/applockerstatus
(Empire: powershell/situational_awareness/host/applockerstatus) > [*] Agent 8NRZSV4X returned results.
[+] c:\windows\system32\calc.exe - ALLOWED for winnie!
[*] Valid results returned by <IP_ADDRESS>

Thanks @winnie22! Fixed in 5f62dde.

@matterpreter Great work! Thanks


Possibility for the users to exit add, delete and change todo menus

When users enter the add, delete or change todo status menus, they have to finish each steps in these menus and can't cancel the action. Implementing the possibility for the users to cancel their current actions would ge a great addition.
For example, if a user is currently creating a Todo, and when prompted to enter the Todo's name, wants to cancel, they should be able to hit a key on their keyboard to go back to the main menu.

I would to contribute to this issue. Is the key "Escape" is good for you ?


suggestion to ameliore the interface and user experience

it would be nice if on the home page, after connection, we could, via an option, choose to display the domain name instead of the IP... for now, we see xx.xx.xx .xx.:port but see subdomain.domain.com related to access to the configuration server, it would be more user friendly for a basic user not knowing the program. Option that could be configured during installation and in the amp settings

I'm unsure where you're specifically wanting to see this. For things like the connect to SFTP button there is the Base URL (search in the top right of AMP).


Notifications not showing

With v1.5.1, notifications do not show as intended. The app crashes when a notification should be raised.

Actually, there is a bug. If the activity becomes inactive, the work manager instance is invalidated and needs to be recreated.


Fix #68849 "Screencast: Some keys do not get special treatment"

This pull request fixes issue #68849

Thanks! :beers:


Public access to Whole Tale

For discussion
Initial thoughts:

Unauthenticated user can access Whole Tale dashboard

View Public Tales
Browse and download files
... anything a read-only user can do on a tale and public tales

Gravatar is replaced with Sign-in link when not signed in
Anything the user wants to do that requires authentication requires sign-in
Need to move Terms of Use and acknowledgements someplace else

Looking over the existing code, the current "Public Tales" view ties in rather with authenticated resources:

Instances are used to render the "Running Tales" section
User profile used to render the navbar
Start/Stop buttons obviously wouldn't work either

This code is rather tightly coupled with the other Tale Catalog pages (the other two views inherit this), so that makes it a bit harder to change it by itself. For example, the MyTalesComponent subclass only overrides the HTML and ends up inheriting all of the methods of PublicTalesComponent: https://github.com/whole-tale/ngx-dashboard/blob/master/src/app/%2Btale-catalog/tale-catalog/components/my-tales/my-tales.component.ts
Would it be acceptable to instead build up a new view using existing components from the UI? This way, we hopefully don't have to change as many of the long-term assumptions about these views.

Hmmm.. yes probably, and you bring up an excellent point - duplicating both set of views would be quite a lot of UI to try to recreate. I know that for a few things (e.g. rendered read-only metadata) we have some special components that can handle that, as well as the file-browser which could possibly be re-used as well.
Sorry for waffling a bit on this, but I will go back and see if I can figure out a workable pattern here

Fixed by https://github.com/whole-tale/ngx-dashboard/pull/277


[21136] Add XML configuration for FlowControllerDescriptor to 2.x

Description

This PR is a backport from #782 to 2.x. It adds the XML documentation for flow controller descriptors.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

[X] Commit messages follow the project guidelines.
[X] Code snippets related to the added documentation have been provided.
[X] Documentation tests pass locally.
[X] Applicable backports have been included in the description.

Reviewer Checklist

[ ] The PR has a milestone assigned.
[ ] The title and description correctly express the PR's purpose.
[ ] Check contributor checklist is correct.
[ ] CI passes without warnings or errors.

@richiprosima please test_3 docs

@richiprosima please test this

@Mergifyio backport 2.13.x 2.10.x 2.6.x


Cosine similarity between generated vectors is close to 1.0?

Hi, thank you for your excellent work!
I have a question about the cosine similarity between the generated vectors of the nodes.
For Amazon dataset and one dataset of my own, threshold(https://github.com/THUDM/GATNE/blob/master/src/main.py#L100) printed during training is always greater than 0.98, and the final similarity score between any two nodes is close to 1, most of which is greater than 0.95, which seems that the generated vectors are distributed in a limited area and makes me very confused.
I change nothing about the experiment setups for Amazon dataset.
Do you have any idea about this result? Thanks ahead!

Hi @ruoyuli1995,
Thanks for your attention to our work. I haven't reported the threshold value before and we mainly care about the relative similarity scores (e.g., AUC). What you discover is very interesting. I have no idea about it right now. Maybe we can analyze this phenomenon and tackle this issue later.

Yes, I find the generated vectors indeed make sense, by visualization of kmeans result. However, when I try to find thresholds to cut off, I find the similarity scores lack distinction.
Thank you for your reply and look forward to further findings.

same problem.  is there any way to explain?  loss function cause this?


404 Maven 3.9.2 not found when building the action's docker image

Hi colleagues,
this is basically the same issue as I reported two weeks ago (#28).
It seems like the latest (and only available Maven version) is now 3.9.3 (I checked by following this link: https://downloads.apache.org/maven/maven-3/).
I suggest you find a more stable approach for getting the latest / a specific maven version, as the current approach seems to be too flaky.
Best regards,
Johannes

You are right, I was also not happy with the solution provided. Let me work on a proper reliable fix.

Hey @sourabhsparkala
any progress on this issue?


Different value and display text for select filter element

    ...
    Display Text
    ...

Hello, my datatable td's html codes as above and my yadcf filter settings as below
    ...
    yadcf.init(Datatable,
                                [{
                                    column_number: 0,
                                    style_class: "custom-select",
                                   html5_data: "data-filter"
                                },
    ...

After rendered html, result as below
    ...
    <option value="bla-bla">bla-bla</option>
    ...

I would like to get result as below. is it possible?
    ...
    <option value="text-for-filter">Display Text</option>
    ...

please provide a test page (jsfiddle)

Hello again,
I have created an example into jsfiddle https://jsfiddle.net/umtd07sj/1/
I would like to show select element as below
<select id="yadcf-filter--TableTypes-0" class="yadcf-filter " onchange="yadcf.doFilter(this, '-TableTypes', 0, 'contains');" onkeydown="yadcf.preventDefaultForEnter(event);" onmousedown="yadcf.stopPropagation(event);" onclick="yadcf.stopPropagation(event);">
	<option value="-1">Select Types</option>
	<option value="types-car">Cars</option>
	<option value="types-fruits">Fruits</option>
</select>

added in 0.9.4.beta.28  , see it working https://jsfiddle.net/vedmack/kq8avshw/

I see this will require use of html data attributes. Would it be possible for it to work with the datatables data  option e.g. when using an ajax data source e.g.
columns: {
	"data": {
			_: "phone",
			filter: "phone_filter",
			display: "phone_display"
		}
	}

@tanyona please open a new issue with jsfiddle test page and I will see what can be done


z-index not applied on _clippingElement

What is the problem?

Container element doesn't have z-index: 1 applied, despite it's defined in code.
What is the current behavior?
<-- What happens in your situation -->
This leads to not visible selection area when some elements in DOM have higher z-index.
Please provide the steps to reproduce and create a JSFiddle.

No need.  The issue is in code:
The change from zIndex: '1' to zIndex: 1 occurred in commit 2b55c944ff345543a1af3de05ac0ba5d6d8b0fab
Numeric zIndex leads to adding "px" unit to it in "css" lib, which prevents from applying it to DOM element style
What is the expected behavior?

Expect the _clippingElement to have z-index: 1 or even better: be configurable
Your environment:
Version (SelectionArea.version): 2.0.0
Browser:  Chrome v.90
OS:  Windows 10

Fix is available in v2.1.1 :)


lxd/migration: Bi-directional rsync negotiation

Closes #5270
Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Looks good.

@brauner should be ready to merge


Remove print statements and improve log messages for base config.py

@wilke It's giving a million warnings now:
DEBUG CLI 2024-08-30 13:45:27,270:	Group: None
WARNING CLI 2024-08-30 13:45:27,270:	Found log_level in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,270:	Removing log_level from options
WARNING CLI 2024-08-30 13:45:27,270:	Found output_dir in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,270:	Removing output_dir from options
WARNING CLI 2024-08-30 13:45:27,270:	Found param_log_file in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,270:	Removing param_log_file from options
WARNING CLI 2024-08-30 13:45:27,271:	Found input_supp_data_dir in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing input_supp_data_dir from options
WARNING CLI 2024-08-30 13:45:27,271:	Found y_data_dir in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing y_data_dir from options
WARNING CLI 2024-08-30 13:45:27,271:	Found train_split_file in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing train_split_file from options
WARNING CLI 2024-08-30 13:45:27,271:	Found test_split_file in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing test_split_file from options
WARNING CLI 2024-08-30 13:45:27,271:	Found permutation_int in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing permutation_int from options
WARNING CLI 2024-08-30 13:45:27,271:	Found cpu_int in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing cpu_int from options
WARNING CLI 2024-08-30 13:45:27,271:	Found dgnet_file in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing dgnet_file from options
WARNING CLI 2024-08-30 13:45:27,271:	Found cnvnet_file in options. This option is predefined and can not be overwritten.
DEBUG CLI 2024-08-30 13:45:27,271:	Removing cnvnet_file from options
DEBUG CLI 2024-08-30 13:45:27,271:	Unique Options: []
WARNING Preprocess 2024-08-30 13:45:27,271:	Option help is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option input_dir is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option output_dir is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option log_level is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option config_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option param_log_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option data_format is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option input_supp_data_dir is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option x_data_dir is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option y_data_dir is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option splits_dir is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option train_split_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option val_split_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option test_split_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option y_data_files is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option x_data_canc_files is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,272:	Option x_data_drug_files is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option canc_col_name is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option drug_col_name is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option y_col_name is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option y_data_suffix is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option bit_int is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option permutation_int is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option seed_int is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option cpu_int is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option drug_bits_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option dgnet_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option mutnet_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option cnvnet_file is missing required keys.
WARNING Preprocess 2024-08-30 13:45:27,273:	Option exp_file is missing required keys.

@wilke is this related to issue #61? Should we merge these issues?


Use an argument label to disambiguate calls to _SwiftValue.fetch.

Back out the changes from d9cdc7ecdb91fdfd738b7347c69a6fa3b6d5d2be and
15769584ce4b4e450e893f33a550e2c23f55db30, and instead use an argument
label to disambiguate calls to fetch.

@phausler Here's what the disambiguation of fetch looks like using an argument label.
One downside of only adding the argument label to the non-optional case is that the optional version can now result in implicit conversions from Any? to Any, which results in a warning, but is usually not intended and might be missed.
In fact I noticed that without any of my changes there appear to be a few cases of calls to store that are doing this. I'm not sure if those are really intended to store Any? or not.

@swift-ci Please test

@shahmishal Mishal, any idea why this is timing out attempting to clone the sources?

@swift-ci Please test

This timeout happened because their was no output after 30mins. Looks like it got stuck at command below.
--- bootstrap: note: building self-hosted 'swift-build': env SWIFT_EXEC=/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/swiftpm-linux-x86_64/debug/swiftc SWIFT_BUILD_PATH=/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/swiftpm-linux-x86_64 /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/swiftpm-linux-x86_64/debug/swift-build-stage1 -Xlinker -rpath -Xlinker $ORIGIN/../lib/swift/linux -Xlinker -L -Xlinker /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation -Xlinker -rpath -Xlinker /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation -Xswiftc -I/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation -Xswiftc -I/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation/usr/lib/swift -Xlinker -L -Xlinker /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/xctest-linux-x86_64 -Xlinker -rpath -Xlinker /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/xctest-linux-x86_64 -Xswiftc -I/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/xctest-linux-x86_64 -Xlinker -L/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/libdispatch-linux-x86_64/src/.libs -Xswiftc -I/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/libdispatch-linux-x86_64/src -Xswiftc -I/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/libdispatch-linux-x86_64/src/swift -Xswiftc -I/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/swift-corelibs-libdispatch -Xcc -fblocks --build-tests
Build timed out (after 30 minutes). Marking the build as failed.

@shahmishal Okay, that's the most recent failure from my second run, but the one I was referring to is this, which looks like it's timing out due to the clone: https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/491/consoleFull#-18214046556633f0f-8823-4f82-9a4a-0c0d97ce7760
I don't think my more recent run should be timing out due to any changes of mine, either, so I'll try another test run to see if it happens again.

@swift-ci Please test

https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/491/consoleFull#-18214046556633f0f-8823-4f82-9a4a-0c0d97ce7760

This was due to network issue on Github side.

Okay, it looks like the build is timing out but I can reproduce a crash if I try it myself, so perhaps we somehow miss the crash in the system that monitors the build status.

Fixed an infinite recursion, so trying once more.

@swift-ci Please test

@swift-ci Please test

@phausler Let me know what you think of the result here.
Unfortunately there is a bit of urgency to get the associated compiler change in (which is blocking other changes), so feedback would be appreciated!

@swift-ci Please test

@swift-ci Please test

@phausler The compiler change just makes Any consistent with the rest of the language, removing an accidental special-case. For example, the following was already ambiguous:
struct S {}

func f(_ s: S) -> S { return s }
func f(_ s: S?) -> S? { return s }

func g(s: S) -> S? { return f(s) } // call to f is ambiguous!

Both options for f() result in coercion to an optional (in one case for the parameter, in the other case for the return value).
Thanks for the review!


[validation-test] Add availability around new Unicode test

This adds an availability around a previously crashing behavior with Unicode scalars that has now been fixed.
Fixes: rdar://82125394

@swift-ci please smoke test


Generic input sanitisation functions

As commented in PR #117, would be nice to have some generic input sanitisation functions to call that are centrally managed, and then implemented bot wide. This would ensure that all sanitisation is consistent and if bugs are found, allow them to be patched all at once.
Notes on ideas to include:

Stripping trailing white spaces (already in message.strip() though)
Removing back tick code segments, both single line and block '`'
Single and multi line block quotes '>'
Handling emojis, either through removing colons and keeping text (for meaning), or removing them all together.

Alternative may be to have one function for stripping (before functionality of method), to save elsewhere, and then one function to replace them back after whatever function is completed

Text formatting '*' and '_'

N.B. '*' may sometimes not be interpreted as bold or italics. They will also be used for bullets in updates being rolled out soon (hyphens will also add bullets). Depending on function made, it might be desirable to remove bullets, but keep text formatting.

Not sure how python handles strings, but "||" spoilers may also be a problem.

I guess a note on all of these that obviously the user put these in their message for a reason. Maybe it's just to try to mess with the bot on purpose, or maybe it's to include some text formatting in their respective output, however, consideration for all of these functions, if possible, should be given to attempting to preserve the user's formatting if it doesn't break things. If these characters do break things, attempts to replace them at the end would be good.
For a start though, generic, bot-wide sanitisation would be good.
After these are created, they would obviously also need to be actually implemented bot-wide.

I'm just going to link #100 here, as it seems to be a subset of this issue. We might need to remove #100.

This is the sort of trick you could handle with a decorator (and it would be pretty cool to do so). Take a function, find every str argument, then call the original function with sanitise() on all of them.
This wouldn't handle in-depth sanitisation (e.g. when you're pulling message.text from an interaction) but it would make base-level sanitisation very easy. For in-depth, you'd still just have to sanitise() the string.
However, that's an implementation detail that I'll leave to whoever picks up this issue. For now, I'm agreeing with Isaac that #100 is a sufficiently narrow subset and closing it.
Quoth Isaac on that PR:

Wow, if I had a nickel for every time I [found a regex for replacing discord emotes] ... I'd have two[three] nickels - which isn't a lot, but it's weird that it happened twice[thrice].

(and also noting that the 3 he identified there are in haiku.py, yelling.py, and cowsay.py)


pwa.workbox.clientsClaim is not working.

pwa.workbox.clientsClaim is not working
pwa:   {
            workbox: {
            skipWaiting: true,
            clientsClaim: false,
  }
}

I want to disable clientClaim ，but it doesn't work as expected and it wolud still controll the existed client on other tab.

Weird, can you set mode to development and check the generated sw.js?
If you're using any virtual the page reload may force to control the current tab but others shouldn't.
https://developer.chrome.com/docs/workbox/modules/workbox-build#type-GeneratePartial


Not compatible with<EMAIL_ADDRESS>default or createSandbox (chain is not a function)

Hi there,
I'm happy user of sinon-mongoose 2.2.1 and find it very usefull. It worked just fine until sinon 7.2.3, which was not compatible with created sandbox (sinon.createSandbox) but was compatible with default sandbox.
Starting version 7.2.6 sinon-mongoose is not compatible nor with default nor with created sanbox (sandbox.createSandbox).
I know there is https://github.com/underscopeio/sinon-mongoose/issues/15 and also PR https://github.com/underscopeio/sinon-mongoose/pull/19.
EDIT: added test for non default created sandbox.
describe('using sinon createSandbox', function() {
    var sanbox = sinon.createSandbox();

    beforeEach(function() {
        sanbox.restore();
    });

    afterEach(function() {
        sanbox.verify();
    });

    it('should work mocking Model', function() {
        var BookMock = sanbox.mock(Book);

        BookMock.expects('find')
            .withArgs('SOME_ARGUMENTS')
            .chain('exec')
            .resolves('RESULT');

        Book.find('SOME_ARGUMENTS')
            .exec()
            .then(function(result) {
                assert.equal(result, 'RESULT');
            });
    });
});

It fails with error:
  2) sinon-mongoose
       using sinon sandbox
         should work mocking Model:
     TypeError: BookMock.expects(...).withArgs(...).chain is not a function
      at Context.<anonymous> (test/index.js:159:10)

The related PRs have been merged/closed.  Are you still having an issue?

Yes, it's still relavant.

Do you have any substitue of this method, until the issue will be solve ?

I am facing the same error with sinon-mongoose 7.3.2. I am a first-time of sinon-mongoose. What are the earlier versions of sinon-mongoose and sinon where they both work together? I would like to revert to them until maybe there is a solution.
Thank you for this libraryr.


GC/Wii widescreen: framebuffer or viewport change?

I'm starting to wonder if games with widescreen capabilities only alter the framebuffer (during rasterisation) and/or the viewport (during projection). Need more research to confirm this.

The framebuffer remains the same; in fact, the EFB can't be bigger than 640 by 528 (writes outside of that are ignored, though it wraps around if you go outside of the 1024 by 1024 area). It might be possible to use a wider XFB, but it would require multiple passes (games do do that elsewhere with e.g. anti-aliasing on the GameCube IPL involving 3 passes stacked vertically).
The viewport itself would also remain the same (e.g. Super Mario Galaxy in widescreen sets the viewport to have a width of 320 and height of -228 (these are radii, corresponding to 640 and 456 respectively) as well as a center of (662, 570) (which is (320 + 342, 228 + 342) - that 342 offset is removed by the "scissor offset" feature, which is its own weird thing). The different scaling happens via the projection matrix instead.
Dolphin's "dump EFB target" and "dump XFB target" options (under graphics → advanced) can help with seeing this, though note that these will generate a LOT of images in the Dolphin Emulator\Dump\Textures folder, so you probably want to double-click them while the game is running instead of leaving them on constantly.

Thanks for the info, I will amend the Wii article.


Bump minimum Erlang/OTP requirement from 22 to 23

The main reason is that the rebar3_format and rebar3_edoc_extensions plugins we depend on (yes, there is a circular dependency I don't understand) require Erlang/OTP 23 apparently.
Note that I don't understand why rebar3_edoc_extensions fetched from Hex.pm requires Erlang 22, but anyway...

yes, there is a circular dependency I don't understand
@dumbbell this is need for use rebar3_edoc_extensions for generate a push to hex.pm the rebar3_edoc_extensions documentation - also works as example :upside_down_face:

The tag 1.1.0 is created with latest changes at hex.pm - https://hex.pm/packages/rebar3_edoc_extensions/1.1.0

The tag 1.1.0 is created with latest changes at hex.pm - https://hex.pm/packages/rebar3_edoc_extensions/1.1.0

I plan to make a couple more improvements. I believe we'll need another release shortly!


If a player submits a starting article too soon to the time limit, their article loads with the "waiting for other players message"

got this reproduced:
This happened when player enter the starter article at the VERY LAST second of countdown.

It sometimes accompanies with a glitch of #96, sometimes doesn't. (for the test that I taken screenshot of it does, in my a few other tests it doesn't)

And when player click into other link from the starter page, the "waiting" message persist but content change.

PS: timing seems to be the key to trigger this, that player needs to be precisely click enter in the VERY LAST SECOND.


Change status of donations to failed if txHash not found and nonce is used

@mohammadranjbarz is this issue still relevant?
I think it's better to close this and create new one if we needed


ansis:SoilSite - phenomenon times

Turns out phenomenonTimes were already on observable property objects.

yes, no ontology fix - is on on sampling and observable properties object


Ability to Specify Unity Version if Stripped

Hello! I've seen this issue addressed in #324 and related posts, but I was wondering if I could formally request re-adding support for specifying stripped Unity versions in order to use plugins.
I would like to make a guide for modding a game with stripped files (starting with texture mods, which necessitates the "Edit Texture" plugin) and the thought of having to walk everyone through personally compiling the program seems a bit daunting.
Thank you for your work on this program!

I whipped up something real quick. Hopefully it works for you, but I don't have any stripped bundles to test on so let me know if it works or doesn't.


[Bazaar] run IPFS node on mobile (not only API)

options:

js in webview: In case js-ipfs is used with WebView: WebView blocks access to local files from web by default. Issue is already open on ipfs side: https://github.com/ipfs/js-ipfs/issues/2262
run as separate app:

sweet IPFS: https://play.google.com/store/apps/details?id=fr.rhaz.ipfs.sweet

textileio has a React Native SDK: https://medium.com/textileio/introducing-the-textile-mobile-sdk-d77c246f8d51. watch for flutter version!

@brenzi any update on this topic?
I am trying to build a flutter app based on IPFS protocol where user add small data and then is stored in the IPFS Network and loaded from it.
I made some test running the  IPFS daemon  on my macOS and the app works only in the Simulator and using for IPFS cat and IPFS add the dart_ipfs_client  dart package.

Now where should I start to make the IPFS daemon working directly on the app, should I use the IPFS node library ?
Is the security issue solved ?
Thankyou so much!

Sorry to inform you, but we have not tackled that issue at all yet.

tanks @clangenb, do you think there is a workaround or a different solution to achieve the app purpose. The app goal is to use the IPFS protocol directly on the user phone.

We use an IPFS gateway now. you could consider infura for that or run your own gateway/pinning service. That actually works nicely, but it's not decentralized at all :-(

Any way on how to run an IPFS node as part of my mobile app? (Flutter specifically). This really hurts my project! I need to make my app an IPFS node.


Copy .NET 6 code to .NET 9 folder

Fixes #33961
Preps #4633

Internal previews

📄 File
🔗 Preview link

aspnetcore/data/ef-rp/intro/samples/cu90/wwwroot/lib/jquery-validation/LICENSE.md
aspnetcore/data/ef-rp/intro/samples/cu90/wwwroot/lib/jquery-validation/LICENSE

Or do we want to start from scratch in a folder appropriately located for a Blazor Web App version of the tutorial series?

I'll let them decide but I think RP is more complete than https://learn.microsoft.com/en-us/aspnet/core/blazor/blazor-ef-core

Is this about jQuery validation? ... If so, it isn't supported for Blazor.

Is this about jQuery validation? ... If so, it isn't supported for Blazor.

Nope, it's like your EF/Movies/Blazor tutorial only more advanced. It uses no jQuery.

Gotcha ... but I think if you're refering to the Blazor movie dB tutorial, it isn't ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/blazor-ef-core
It's this one ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/tutorials/movie-database-app/?view=aspnetcore-8.0


In the next meeting issues

When trying to set a task to be due in the next meeting for a subject, it sets the due date to next week instead of the actual next meeting (ex: tomorrow).

Fixed in the latest commit


Security vulnerabilities with tfsec .

Getting security vulnerabilities with tfsec for the encryption and versioning, though we can see that all these are already enabled by default.

@asthasrivastava48 In recent release of AWS provider v4.0, aws_s3_bucket has been quite heavily refactored, and its former configuration arguments became separate resources such as aws_s3_bucket_logging, aws_s3_bucket_server_side_encryption_configuration and aws_s3_bucket_versioning.
It seems tfsec has not adopted to this update, so I suppose we can safely ignore these warnings for now.
See here for more detail about the changes introduced in AWS provider v4.0.

@nozaq I am still getting these 4 warnings.
#1 HIGH Cluster encryption is not enabled.
#2 MEDIUM Bucket does not have logging enabled
bucket.tf Lines 56-62
56  │ resource "aws_s3_bucket" "state" {
57  │   bucket_prefix = var.override_s3_bucket_name ? null : var.state_bucket_prefix
58  │   bucket        = var.override_s3_bucket_name ? var.s3_bucket_name : null
59  │   force_destroy = var.s3_bucket_force_destroy
60  │
61  │   tags = var.tags
62  │ }
#3 MEDIUM Bucket does not have logging enabled
#4 LOW Cluster encryption does not use a customer-managed KMS key.
I am using tfsec version 1.6.2 and aws provider version 4.4.0

@asthasrivastava48 Thanks for the update!

#1 & #4: In v1.1.0, server-side encryption can be enabled for the DynamoDB table.
#2: Bucket logging can be enabled for the state bucket via var.s3_logging_target_bucket argument.
#3: I assume this warning is for the replication bucket. Do you have a real use-case you'd like to enable logging for the replication bucket?

@nozaq works fine now. Thanks


Demo app

Have you any small demo example working with frontend of this library?

check https://github.com/jiyeyuran/mediasoup-go-demo

simple demo: https://github.com/lihp1603/mediasoup-go-simple-app


Universal Dark Mode is inconsistent

Describe the bug
Upon loading darkmode.css into Messenger, nothing happens. Service remains white and no attributes from the CSS file are shown. Viewing devtools for service, no styles are loaded from darkmode.css.
To Reproduce

Go to Messenger service
Click on 'Enable Dark Mode'
Click on 'Open darkmode.css'
Add styles and save

Expected behavior
Expected to have darkmode.css rendered
Desktop

OS: MacOS High Sierra 10.13.6
Version 5.4.0-beta.2

Additional context
I've tried the same darkmode.css on the Messenger service within Franz and it works as expected. Is there a reason that it is not loading darkmode.css for Ferdi?

Ferdi does have some problems with dark mode probably because of the Dark Reader implementation.
For me Ferdi just randomly doesn't load in or only partially loads in my dark modes at launch, but that is fixed by reloading a given service.
I use a custom dark mode for Messenger and Telegram, but it only happens to TG every 1 or 2 weeks, while for Messenger it's several times a week.
If you reload just your Messenger by right clicking the icon on the left does it still not load?
Maybe there's an error message in the console the team could direct us to?

I currently can't reproduce this with Ferdi 5.4.0-beta.4 (current develop branch). I now added some debug statements to help fix this issue.
I also added a possible fix for this issue - but as I can't reproduce it I don't know if it fixed it.
Using MacOS Catalina 10.15.

If you reload just your Messenger by right clicking the icon on the left does it still not load?
Maybe there's an error message in the console the team could direct us to?

Reloading both services and Ferdi did not fix it on my end. I tried disabling universal dark mode, but still doesn't fix it. Multiple reloads and nothing, but today it randomly loaded for reload.
Here's the interesting part. If I right-click and reload on the icon, it loads white. BUT, if I then open service devtools and then right-click reload while devtools is open, the darkmode loads sometimes. Like 1 out of 4 times. Weird?
I updated today to beta.4 and darkmode.css loaded right away first time. Crossing fingers and will post back if there's any issue.

I have the suspicion that the webview won't update correctly when the darkmode setting gets transmitted.
In the service developer tools you'll now see some output about that the darkmode script is currently doing. When having darkmode enabled, it should first output that it has removed the darkmode and a few seconds later that it has now added the darkmode. In my tests, if the darkmode doesn't work correctly, the second output won't exist - can you confirm this on your installation?

It looks like the recipe script sometimes can't get loaded and instead throws this error:

It can't load the module because the module "did not self-register". Looking online, most people suggested trying to reinstall node_modules and rebuilding the modules but both did nothing.
At least on my computer it looks like the service always succeeds at loading the darkmode when initially creating the webview but fails to do so whenever I reload it. I tried always disabling the webview's websecurity (in case that blocked the module from being loaded) but that didn't fix it.
I now also tried to change the reload script from updating the webview url to directly reloading the webview (c8e7dabd) and that looks like it fixed the issues for me. No matter how often I refresh and reload the services, the darkmode gets loaded correctly everytime. I also don't have any conflicts between universal dark mode and darkmode.css anymore.
The fixed will be published as 5.4.0-beta.5 in the next couple of days so you can test if that was also the problem on your end.

I still have some problems with dark mode. I couldn't apply a dark theme to google calendar via darkmode.css, the Enable Dark Mode setting in the service was always enabled but didn't help. Telegram was working with dark reader and I could set a darkmode.css for whatsapp (not sure if it worked because of the css or dark reader). So I deleted the $HOME/.config/Ferdi and re-added the services (telegram, whatsapp and google calendar). Now Whatsapp Web works with Dark reader, but neither telegram nor google calendar appear dark (also not with a darkmode.css).
Screenshot of my google calendar dev console:

Screenshot of my telegram dev console:

Screenshot of my whatsapp dev console:

Env

Fedora 29
using  Ferdi-5.4.0-beta.4.AppImage
using Ferdi without a server

I've noticed with the latest update (5.4.0) that when the Messenger service darkmode toggle is enabled and there is an existing darkmode.css file, it does not load. BUT, if you open the service devtools and load the console tab, THEN right click on the service icon and choose "Reload", darkmode.css will then load. If you close the devtools window and do another reload, once again darkmode.css will not load and you get default. The CSS will only load if the devtools window is active. Odd no? Attached is a screenshot from 2 reloads of the console. The first 3 lines are on reload without devtools and the last 3 lines are on reload with service devtools active.

Some improvements have been shipped with v5.4.1-beta.2.

I will continue to improve and take a look at the inconsistencies on UDM.

Confirmed: Dark Mode is working in Google Voice now.

To whomever is coming here from a referenced issue, I recommend updating directly to v5.4.1-beta.3 to avoid issues possibly introduced in v5.4.1-beta.1 or v5.4.1-beta.2. There is still some inconsistency to be addressed with Universal Dark Mode (UDM) as, if I remember correctly, it doesn't work nicely with Adaptive Dark Mode on macOS yet.

Followup on Google Voice, having an odd issue now where there's a flickering of the service as you move your mouse around the page. It's an odd issue in that something (not yet sure what) is triggering it to go "blank":

Ok, I just published better synchronisation between service dark mode and macOS dark mode with 5714e2f - it will be released with the next update.

This now works flawlessly for me with Version 5.4.4-beta.1 (5.4.4-beta.1.1023) on macOS 10.15.3 (19D76). Thank you! :)

@emanuelst have you checked it with Google Voice per chance? I'd like to know if this is isolated to me or others are also seeing it.

@emanuelst have you checked it with Google Voice per chance? I'd like to know if this is isolated to me or others are also seeing it.

Unfortunately I can't tell you, as I'm not able to log into Google Voice (#264)

@vantezzen I think https://github.com/getferdi/ferdi/issues/347 was introduced via the recent changes. Also, I think we should start use nativeTheme.shouldUseDarkColors more for the Adaptable Dark Mode instead of checking if the app is running on macOS, as nativeTheme.shouldUseDarkColors works for other platforms. I'm keen to contribute to the refactor and fix the regression at the same time.

I just pushed a fix for #347 just so we've already fixed that.
Using nativeTheme.shouldUseDarkColors sounds like a good idea so you're welcome to start refactoring.

Just commenting to say #258 is still occurring for me with Ferdi 5.4.3.

Whatsapp not loading dark mode after a service reload.
Have both universal and adaptable dark modes enabled, as well as dark mode enabled on the service itself. I've tried clearing the cache (not sure if that would have done anything anyway, but worth a shot), reloaded service, restarted Ferdi, disabled and re-enabled service as well as removing and re-adding the service. None of the above seemed to fix.
When I opened darkmode.css it was empty - is this expected (maybe a silly question, sorry!)?
Dark mode worked on first installation (same version as using now).
Version 5.4.3; OS: macOS Mojave 10.14.6

Whatsapp not loading dark mode after a service reload.
Have both universal and adaptable dark modes enabled, as well as dark mode enabled on the service itself. I've tried clearing the cache (not sure if that would have done anything anyway, but worth a shot), reloaded service, restarted Ferdi, disabled and re-enabled service as well as removing and re-adding the service. None of the above seemed to fix.
When I opened darkmode.css it was empty - is this expected (maybe a silly question, sorry!)?
Dark mode worked on first installation (same version as using now).
Version 5.4.3; OS: macOS Mojave 10.14.6

So I believe this is a separate issue from what is described in the original issue, but I ran into this and found the workaround. When you opened darkmode.css it created a darkmode.css file. Ferdi handles dark mode in a separate way/file, so this file overrides Ferdi's dark mode.
The workaround/fix is to delete the darkmode.css file you created and is empty. After doing so restart Ferdi and you should be back to Ferdi's. Ferdi's Dark Mode may still be inconsistent as described in this issue depending on the service.

So I believe this is a separate issue from what is described in the original issue, but I ran into this and found the workaround. When you opened darkmode.css it created a darkmode.css file. Ferdi handles dark mode in a separate way/file, so this file overrides Ferdi's dark mode.
The workaround/fix is to delete the darkmode.css file you created and is empty. After doing so restart Ferdi and you should be back to Ferdi's. Ferdi's Dark Mode may still be inconsistent as described in this issue depending on the service.

This worked, thank you!
The issue I ran into on my first comment actually happened when trying to remediate a different issue i came across - which is where the speech bubble tails in Whatsapp aren't the same colour as the body of the message in dark mode (it might be related to #511?) and similarly the colour of the dropdown arrow which appears on hovering over messages isn't consistent with the rest of the dark mode styling - see screenshots.

Same behaviour here, I deleted darkmode.css from edit service -> bottom left button in dialog edit darkmode.css, and it's now working, but at least once the file got re-generated.
Also, how do I change Dark reader settings [contrast, etc..]?
Thanks

Also, how do I change Dark reader settings [contrast, etc..]?

We can't at the moment, but someone else suggested we expose them to the user via https://github.com/getferdi/ferdi/issues/531.

Same behaviour here, I deleted darkmode.css from edit service -> bottom left button in dialog edit darkmode.css, and it's now working, but at least once the file got re-generated.
Also, how do I change Dark reader settings [contrast, etc..]?
Thanks

@nordurljosahvida just to clarify, did it regenerate without clicking "Open darkmode.css" file?

As far as I know, it will always generate after clicking this button. Not aware of any other ways it may be generated.

Also, how do I change Dark reader settings [contrast, etc..]?

We can't at the moment, but someone else suggested we expose them to the user via #531.

great thanks!
@Julian88Tex i supposed it had, since i only clicked open darkmode.css to delete it, and as soon as i did that everything started working.

I have a similar problem in 5.5.0.
In all services I tested when you put something in darkmode.css the UI of the service changes to a light theme again. When I empty the darkmode.css it stays light, also after reloading. Only when removing the darkmode.css file and reloading the service it is dark again.
Only with WhatsApp when I change the 'Dark Reader settings', even a little bit, WhatsApp shows the default light theme again. This can only be fixed by deleting the WhatsApp service and add it again.

A lot of solutions are proposed here but let me throw in my custom darkmode.css based on this stackoverflow answer.
It persists as you move inside the web app and even managed to inject itself through iframes.
html {
    -webkit-filter: invert(100%);
    -moz-filter: invert(100%);
    -o-filter: invert(100%);
    -ms-filter: invert(100%);
}

This issue doesn't seem to be stale. Experiencing it with several services at the moment.

I try to reproduce. Dark mode, and editing darkmode.css work good for me on 5.6.4-nightly.12


some changes in the bugreporting page to reflect the new redmine forms

@gioman Feel free to merge after the checks are green or ping me if you have no commit right :) Thanks!

@yjacolin I don't commit rights, can you merge this? thanks!

Thanks


how to set --proxy-type to 'Https' or 'socks4' ?

Hello,
I see this section :

--proxy-type=[http|socks5|none] specifies the type of the proxy server (default is http).

Ok , you support 'http' , 'socks5' however what about 'https' or 'socks4' ?

I also want to know it

@ariya ?

SOCKS4 is not supported. HTTPS should work fine with you specify it as http

@Vitallium you mean by "HTTPS should work fine with you specify it as http"
That we can open https websites , but the problem is ,
some sometimes there is an HTTPS proxy , which we need to tell phantom that the proxy type is HTTPS not HTTP.
That's why we have a problem with pahntomjs

I also want to know it


Add missing instrumented gems to docs site

Is your feature request related to a problem? Please describe.
Incomplete documentation
Feature Description
Gems are missing from Ruby agent requirements and supported frameworks

yajl-ruby
actionview
activejob
actioncable

Documentation does not state that sinatra, padrino, and grape are excluded on Ruby 3
Additional context
Discovered while woking on yajl-ruby ignite sprint goal updates. Additional gems from Erik's Ruby Gem Analysis
Priority
[Must Have]

@tristinbarnett for those gems that are missing from our documentation, do you have the versions that we support? If you do, could you please add to this ticket?

Closed by this PR to the docs website: https://github.com/newrelic/docs-website/pull/3867
yajl-ruby: we added a line in the docs that says:

Yajl-Ruby:1.1.0 or higher

actionview, actionjob, and actioncable come packaged with rails, so we felt that we could exclude these and rely on our rails support documentation.
We added a line stating that Grape, Padrino, and Sinatra are not supported for Ruby 3.0+


Flashy v1.5

Material 3 Support 🎨
Widgets Support 🎨
Change Screen Colour Support 🎨
Support Flashlight Brightness Control On Supported Android 13+ Devices 📸
Add SOS Option 🆘
Add Stroboscope Option 🚨
Bugfixes 🐛
Translation Updates 🗺

I see these errors:
> Task :app:lintVitalRelease FAILED

\GitHub\Flashy\app\src\main\res\layout\activity_about.xml:122: Error: The id "textView" is not defined anywhere. Did you mean textView2 ? [UnknownId]
                        app:layout_constraintTop_toBottomOf="@+id/textView" />
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "UnknownId":
   The @+id/ syntax refers to an existing id, or creates a new one if it has
   not already been defined elsewhere. However, this means that if you have a
   typo in your reference, or if the referred view no longer exists, you do
   not get a warning since the id will be created on demand. This check
   catches errors where you have renamed an id without updating all of the
   references to it.

\GitHub\Flashy\app\src\main\res\layout\activity_about.xml:120: Error: @id/crazymarvin_github is not a sibling in the same ConstraintLayout [NotSibling]
                        app:layout_constraintBottom_toTopOf="@id/crazymarvin_github"
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
\GitHub\Flashy\app\src\main\res\layout\activity_about.xml:179: Error: @+id/fahadsaleem_github is not a sibling in the same ConstraintLayout [NotSibling]
                        app:layout_constraintTop_toBottomOf="@+id/fahadsaleem_github" />
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "NotSibling":
   Layout constraints in a given ConstraintLayout or RelativeLayout should
   reference other views within the same relative layout (but not itself!)

3 errors, 0 warnings

Execution failed for task ':app:lintVitalRelease'.
> Lint found fatal errors while assembling a release target.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

May you have a look please, @unbiaseduser?


Tatoebot should auto edits the wiki with the new commands

i used shigebot and i saw that shigebot edits a git with all the commands everytime a command is added/edited/deleted, so why not also tatoebot? :smiley:

The current wiki page is categorized so it'll be harder to maintain auto edit.

yeah :c


Any way to use the current location with this?

Seems like it would be reasonably simple to expose some scope variables that contain the user's current lat/ long - would it be feasible to use those to set the default location displayed on the map? I see there's an address attribute but it's not clear if that is re-used after the location has been established - empirically it does not appear that it is.

Actually, empirically it appears the initAddress() function gets called repeatedly until angular dies with an infinite digest error.


Look up the most nested constant first in the CustomNamespace strategy

In my app, I have App::Events which is a module not related to the persistence layer and I also have App::Relations::Events which is a relations class. CustomNamespace wrongfully picks up App::Events rather than App::Relations::Events. This PR fixes the issue, now it starts with the longest constant name.

I had some failures on jRuby. Initially, I tried to bump its version but it doesn't work well because of I tried https://github.com/jruby/jruby/issues/4895. Then I updated specs to forcefully "unload" constants in https://github.com/rom-rb/rom/pull/479/commits/bad37407616e3d394335b823f06807741a1099ca, this slowed down specs by 0.5s (2.2 -> 2.7) or so but I believe a clean environment is better than speed here, we can tag these specs as slow if needed.


Benchmark: add the ability to specify ID ordering as a CLI flag

When benchmarking, it's very handy to be able to switch this out at runtime to see what different workloads look like.

@batiati I've swapped in IdPermutation - but I think that keeping different names for the CLI is more clear (IMO --id-order=sequential / --id-order=reversed is more clear than --id-order=identity / --id-order=inversion)


Add cblas_crotg, cblas_zrotg, cblas_csrot and cblas_zdrot

the cmake build already generated the interface functions, but neither the gmake build nor the cblas.h had them. Fixes #3063

ok thanks ;do you know (historically) for the ?rotg family? it has been decided not to transpose back the packed-format-matrix i.e param ; that's the only weirdo which doesn't respect row major storage.
By any logical means cblas_?rotmg should be have been declared as the following:

cblas_?rotmg(const enum CBLAS_ORDER order, type * d1, type * d2, type * b1, const type b2, type * param);

then param result transposed as it actually returns [ flag, h11, h21, h12, h22 ]. in row-major anyone would expect [ flag,  h11, h12,  h21, h22].

ok thanks ;do you know (historically) for the ?rotg family? it has been decided not to transpose back the packed-format-matrix i.e param ; that's the only weirdo which doesn't respect row major storage.
By any logical means cblas_?rotmg should be have been declared as the following:

cblas_?rotmg(const enum CBLAS_ORDER order, type * d1, type * d2, type * b1, const type b2, type * param);

then param result transposed as it actually returns [ flag, h11, h21, h12, h22 ]. in row-major anyone would expect [ flag,  h11, h12,  h21, h22].