Bug in the preparation of the simulation of some stateful cells in some cases

Version
Yosys 0.37+21 (git sha1 8649e3066, clang 10.0.0-4ubuntu1 -fPIC -Os)
On which OS did this happen?
Linux
Reproduction Steps
Hi there!
In some cases with stateful cells, the compilation step fails.
I created a dedicated repository to help you reproduce this issue.
It does not seem related to #4136 , I am working with the last Yosys version.
Thank you!
Flavien
Expected Behavior
Successful compilation
Actual Behavior
cxxrtl_obj_dir/cxxrtl.cpp:118:90: error: ‘struct cxxrtl::slice_expr<cxxrtl::value<2>, 0, 0>’ has no member named ‘update’
  118 |  p_top__i_2e_celloutsig__0z.next.slice<0>() = p_top__i_2e_celloutsig__0z.next.slice<0>().update(value<1>{0x1u}, (p_top__i_2e_clkin__data.slice<96>().val() ? value<1>{0u} : (p_top__i_2e_clkin__data.slice<64>().val() ? value<1>{0x1u} : value<1>{0u})));
      |                                                                                ^~~~~~
cxxrtl_obj_dir/cxxrtl.cpp:119:90: error: ‘struct cxxrtl::slice_expr<cxxrtl::value<2>, 0, 0>’ has no member named ‘update’
  119 |  p_top__i_2e_celloutsig__0z.next.slice<0>() = p_top__i_2e_celloutsig__0z.next.slice<0>().update(value<1>{0u}, (p_top__i_2e_clkin__data.slice<96>().val() ? value<1>{0x1u} : value<1>{0u}));

I created a dedicated repository to help you reproduce this issue.

Thank you, this really helps.
At a glance, I do think you found a real issue, I'll take a look shortly.

I'm not able to reproduce this. How are you getting that .slice<0>() in the middle? I've just built commit https://github.com/YosysHQ/yosys/commit/8649e306682e44b7f3e1b869d1043041db00b13e and the generated code looks like this:
p_top__i_2e_celloutsig__0z.next = p_top__i_2e_celloutsig__0z.next.update(value<1>{0x1u}, (p_top__i_2e_clkin__data.slice<96>().val() ? value<1>{0u} : (p_top__i_2e_clkin__data.slice<64>().val() ? value<1>{0x1u} : value<1>{0u})));
p_top__i_2e_celloutsig__0z.next = p_top__i_2e_celloutsig__0z.next.update(value<1>{0u}, (p_top__i_2e_clkin__data.slice<96>().val() ? value<1>{0x1u} : value<1>{0u}));

which is built without problems by g++ on my system:
g++ (Debian 12.2.0-14) 12.2.0

Are you using a patched Yosys somehow? How are you getting all of these errors that I consistently cannot reproduce?

Hi @whitequark , thank you for your response! Indeed with again deleting everything and reinstalling again from scratch, the issue disappears. I suspect that cxxrtl.h moves between versions in the share directory and the wrong one may be selected sometimes when moving versions without a very clean uninstall. Thank you again for having looked at it :pray:

Hi again Whitequark, my apologies for the back and forth.
I'm actually still stumbling into the exact same bug for a small variation of the top.sv, which I updated in the same repository now. I confirmed with a fresh Docker container that this occurs with a fresh initial installation.
You can try it with this Dockerfile if this is convenient for you:
FROM ubuntu:20.04
ENV DEBIAN_FRONTEND=noninteractive

# Install apt dependencies
RUN apt-get update && apt-get install -y build-essential clang bison flex \
	libreadline-dev gawk tcl-dev libffi-dev git \
	graphviz xdot pkg-config python3 libboost-system-dev \
	libboost-python-dev libboost-filesystem-dev zlib1g-dev

RUN git clone https://github.com/YosysHQ/yosys.git && cd yosys && git checkout 8649e30 && make config-clang && make -j$(nproc) && make install

RUN echo salut
RUN git clone https://github.com/flaviens/cxxrtl-b2.git
RUN cd cxxrtl-b2 && bash run.sh

which I updated in the same repository now.

I can reproduce your issue with the updated repository. I will look at it later. I do want to underscore that it is completely unacceptable to repeatedly file fuzzer-discovered bugs which do not reproduce on the master branch or with other blatant issues (some of the earlier testbenches referenced signals that do not exist, etc) and if this trend continues I will deprioritize all of your issues as they require me to spend quite a bit of time triaging them that I could spend helping people whose practical designs are blocked on some issue.

Hi Whitequark, thank you for your response! I understand, and am also learning from this process. I will continue trying to make it as easy as possible for you. Please prioritize as suits you the best. Thanks!

Fixed by https://github.com/YosysHQ/yosys/pull/4157.

Very cool, thanks!


Support for compiling with c++ files

Go now supports compiling c++ files (as long as you write a c interface over the c++ api of course).  It would be fantastic if cross platform c++ toolchains could be added to the docker image to enable doint this with xgo.  It shouldn't be too difficult, but I'm not enough of a docker expert to know where things need to change.  I think installing appropriate c++ compilers and adding the CXX=... for each build is about all that would be necessary.

If you can put together a simple enough C++ dependent project and put it on github, I might play around with it if I have some time available :) I don't really have the time to start fiddling with cgo to ensure that that part is really correct and issues are/or are not in xgo :)

github.com/rwcarlsen/cyan/cmd/cyan binary imports the github.com/cyan/nuc
package which has some cgo with c++ stuff in it.
On Fri, May 8, 2015 at 1:45 AM, Péter Szilágyi<EMAIL_ADDRESS>wrote:

If you can put together a simple enough C++ dependent project and put it
on github, I might play around with it if I have some time available :) I
don't really have the time to start fiddling with cgo to ensure that that
part is really correct and issues are/or are not in xgo :)
—
Reply to this email directly or view it on GitHub
https://github.com/karalabe/xgo/issues/16#issuecomment-100137728.

Sorry - that last link should be github.com/rwcarlsen/cyan/nuc.
On Fri, May 8, 2015 at 7:36 AM, Robert Carlsen<EMAIL_ADDRESS>wrote:

github.com/rwcarlsen/cyan/cmd/cyan binary imports the github.com/cyan/nuc
package which has some cgo with c++ stuff in it.
On Fri, May 8, 2015 at 1:45 AM, Péter Szilágyi<EMAIL_ADDRESS>wrote:

If you can put together a simple enough C++ dependent project and put it
on github, I might play around with it if I have some time available :) I
don't really have the time to start fiddling with cgo to ensure that that
part is really correct and issues are/or are not in xgo :)
—
Reply to this email directly or view it on GitHub
https://github.com/karalabe/xgo/issues/16#issuecomment-100137728.

I'll note that xgo currently works out of the box with c++ files for the linux-amd64 architecture.

 I haven't had the time to work on xgo in the past months so couldn't properly address this issue. Your PR indeed solves C++ cross compilation for the main platforms, but I didn't want to merge it in without having a proper solution for all supported targets. Furthermore, I've also updated xgo to Go 1.5+, which uses different cross compilation semantics, as well as added support for android cross compilation, so your original PR got very out of date and also had understandably had merge conflicts.
However, I figured that if I started patching up xgo for new features, I might as well address your request of being able to cross compile C++, so I've pushed https://github.com/karalabe/xgo/commit/e95f85ee814291bd9ec4e5451bad9518d607ce23 just now, which should make xgo happy on all platforms.
Compiling your specific code sample:
$ xgo github.com/rwcarlsen/cyan/nuc
[...]

$ ls -al
-rw-r--r--  1 root     root      628738 Sep 16 17:03 nuc-android-21-arm
-rw-r--r--  1 root     root      350926 Sep 16 17:03 nuc-darwin-386
-rw-r--r--  1 root     root      353080 Sep 16 17:03 nuc-darwin-amd64
-rw-r--r--  1 root     root     1388814 Sep 16 17:03 nuc-linux-386
-rw-r--r--  1 root     root     2641598 Sep 16 17:03 nuc-linux-amd64
-rw-r--r--  1 root     root     1628688 Sep 16 17:03 nuc-linux-arm
-rw-r--r--  1 root     root     1953608 Sep 16 17:03 nuc-windows-386.exe
-rw-r--r--  1 root     root     1798090 Sep 16 17:03 nuc-windows-amd64.exe

Sorry for not being able to address this in a timely fashion :)
PS: Docker is still crunching through the updates, so it will probably take half an hour until the fresh images are out.


lazy_encode fails to encode storage changes

Storage changes can have four items:
https://github.com/ethereum/pyethereum/blob/develop/ethereum/blocks.py#L1017
The lazy_encode is only evaluated if the logging is set to TRACE:
https://github.com/ethereum/pyethereum/blob/develop/ethereum/blocks.py#L1032
lazy_encode assumes that all items in the list have length 3:
https://github.com/ethereum/pyethereum/blob/develop/ethereum/blocks.py#L42

@konradkonrad ---^


Optimize

Remove unnecessary code

toObject method at each value objects

Change password encryption to hash

Because decryption is unnecessary

Coverage remained the same at 100.0% when pulling 4048abe874eac8128c3741719ce426bada9d8c86 on optimize into fe77b76754c632d08791d90000c6f66cc1ccd6d5 on develop.

It looks fine.
LGTM


Update XR assets for XR Management 3.0

Overview
Unity's XR Plugin Management package had a pretty large update for version 3.0, and all previous versions were unpublished. As a result, ARCore and ARKit are now managed via XR Management, so I'm adding those assets. I also recreated the WMR assets from scratch.
For these assets, since they don't exist in 2018.4, they simply state that fact and don't cause issues:

These files are only included in the repo to facilitate XR SDK work on MRTK. They are not distributed in any MRTK package or intended to be used by others, but exist as repo scaffolding.

/azp run


List.append (curried) for appending one list to another

This:
append = (xs, ys) --> ys.concat xs

would make writing the following possible:
[1 2 3] |> append [4 5 6]

Signature: [a] → [a] → [a]
Unless, of course, I've missed something in the LiveScript bag of tricks.

(++)?
[1 2 3] |> (++) [4 5 6] → [ 4, 5, 6, 1, 2, 3 ].

@anko Great suggestion (I have forgotten about ++) and I can live with that for now. The only difference is that (and which I also forgot to specify in my original comment) it would behave more like:
[1 2 3] |> append [4 5 6] #=> [1, 2, 3, 4, 5, 6]

But I could partially apply ++ with a placeholder as follows to get that effect as part of a pipeline:
[1 2 3] |> ((++) _, [4 5 6])

That would make the definition of append just a flip of ++ arguments:
append = (xs, ys) --> ys ++ xs

…boiling down to just:
append = flip (++)

If the prelude maintainers feel append doesn't add any value (even for readability) then I wouldn't be completely annoyed or disappointed if this issue is closed. :smirk: Then again, not sure where you draw the with one-liner functions.

I think ++ is good enough.
[1 2 3] |> (++ [4 5 6])
#=> [1,2,3,4,5,6]

@gkz Okay, I clearly forgot the first of the two examples listed in the docs:
(+ 2) 4         #=> 6
(*) 4 3         #=> 12

It would've done the job in the first place. I don't know why I kept insisting on the second form; could be muscle memory from F# that requires the second form.


[graphiql] move tests files outside src directory everywhere

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
to avoid publishing them since we publish src directory we can move them to tests directory

Expected Behavior
No response
Steps To Reproduce
No response
Module pattern

[ ] graphiql-umd
[ ] graphiql-esm
[ ] graphiql-commonjs

Environment
- GraphiQL Version:
- OS:
- Browser:
- Bundler:
- `react` Version:
- `graphql` Version:

Anything else?
No response

@B2o5T  I will work on this issue shortly! Thanks.

ohhh this is about test files getting published. seems fine to me. i'm guessing there is no way to exclude files from files config?


Addition additional checks to avoid errors and comments

Code is more readable now and special inputs like non-existing directorys are catched

Can you clarify an example of non-existing directories being found?  It's not a situation I've ever encountered myself, so I just want to make sure I fully understand it before I merge this request.

Errors occur if you try to search in a non-existing directory. I was talking about the inputs and not about the outputs.

I added the key feature of this pull request (checking for non-existent paths in the input string) to the latest version of the code.  A merge conflict arose here due to another unrelated bug fix, so it was easier to make the manual change than to do the full merge.


"edit tier" for tables is missing from policies

Affected module
UI
Describe the bug
On previous version, there was an option to set permissions for "edit tier".
Now, it's available for all resources, but not for table resource.
Meaning there is no option to set permission on this field.
To Reproduce
flow 1:

flow 2:

Expected behavior
I expect the option for setting tier editing permissions will be available for table resource.
Version:
1.3.2

hi @harshach,
Can we prioritize this bug somehow?
Users are adding this tag though the assets are not in tier 1 standartd.

hi @harshach,
Can we prioritize this bug somehow?
Users are adding this tag though the assets are not in tier 1 standard.

Fixed in 1.6.1


docs: Add documentation for the @poap-xyz/frames package

Description
Add docs pages for @poap-xyz/frames.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have updated the documentation accordingly.

@rlajous Added the package, and it's better now.


b/350090066 - Changing connector name to 'Looker by Google' to prepare for release

The title says "Looker by Google" but the changes mostly look like s/looker-jdbc/looker.. is that intentional?

I think the vendor name "Google" gets automatically picked up in the Tableau UI. Earlier it used to show Looker JDBC by Google

The title says "Looker by Google" but the changes mostly look like s/looker-jdbc/looker.. is that intentional?

I'm removing most references to looker-jdbc and renaming it to just looker in the code.
On the Tableau UI, it will see Looker by Google and this change is from the first line in connector/tableau/looker/manifest.xml

makes sense !  LGTM


Responsive Timeline

The sb-admin-2 live demo features a Responsive Timeline. What would it take to support this in sb-admin, too?

I could add this in as a feature in the future. The original timeline for SB Admin 2 was pulled from Bootsnipp here: https://bootsnipp.com/snippets/featured/timeline-responsive
You could easily go in and grab the code for that timeline in the link above, convert any Bootstrap 3 related markup to Bootstrap 4, and then go from there.


Does not work

Hi, we tried and got an error: CreateForWindow failed with E_INVALIDARGS and with valid HWND which is perfectly works for normal D3D11 rendering.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 745996b6-93b9-0039-78e4-1dc76ac2d16e
Version Independent ID: eb998dc5-14b5-8869-87d1-c3cbf923019c
Content: Getting a HolographicSpace - Mixed Reality
Content Source: mixed-reality-docs/getting-a-holographicspace.md
Service: unspecified
GitHub Login: @MikeRiches
Microsoft Alias: mriches

Hi @kirillp, are you saying something is wrong with the documentation? Or are you just trying to get help solving a problem with your app? If the former, please suggest a change to the docs via pull request; if the latter, you should ask for help in forums.hololens.com. We don't have anyone to troubleshoot issues through the documentation site.

Thx


toggle_hint not hiding the hidden list labels or added list rows

Running skillet:
https://github.com/scotchoaf/ping-test/blob/develop/ping_test_2/.meta-cnc.yaml
Designed to hide the list if file type selected and will hide the file upload if list selected
Toggle not hiding elements as expected
Describe the bug
When choosing on option the 'hidden' option field label is still shown. The label and field should both be hidden.
For a list when adding additional rows, the added rows still appear although this variable should be hidden.
panHandler version: Version: 3.1-DEV 2020-04-03T13:00:38
Steps to reproduce
Label showing:
Select file or list and the hidden label will still be shown
List row showing:
Set type to list
Create a list variable with > 1 entries
Set type to file

fixed via commit: 275603cfe0d9b3b012e43add5696a55ae456dc58


A6000 with Apple shipped fonts, with FontVal 1.0

"DecoTypeNaskh.ttf" and "Brush Script.ttf" triggers this. This needs looking at why this is the case (even if it is because FontVal 1.0 is buggy) and documenting.

Documented as known issue with Fontval 1.0 in https://github.com/HinTak/Font-Validator/commit/9a8043b414e1709ddd4a778c00feb9c3a2be8ca5


Don't parse beatmaps.

The error you're getting indicates that parse_beatmap failed, which could either be because it received invalid arguments (meaning that an earlier step failed but wasn't detected) or because it failed to open the beatmap file. I consider the latter to be more likely.
This might be an issue with permissions, you could try to run maniac from an admin shell (ergo from a CMD.exe that was started with admin rights).
Could you run a debug build and let me know what debug messages/errors you see?


[New feature] - Tock Gen AI

A new feature that leverages the power of LLMs to ensure that the chat bot provides a better response to the end user.
With Tock Gen AI, we've tried to address two use cases:

RAG: Enables the bot, in the event of an unknown intent, to search for the answer in enterprise data, in an attempt to provide a valid response.
Sentence Generation: Enables the FAQ manager on Tock to generate several sentences/questions that resemble the list of training sentences. The aim is to speed up this training phase.

The PR is now ready @vsct-jburet
We are working on the documentation, and will make a separate contribution for this. The PR can be reviewed and validated as is.


Key is ID = Throw Error

In the location_update and location_new queries, it is possible to update the id field on the table on the db.
However, doing so will actually overwrite the %{id} reserved parameter.

You want to update id field to be 123.
The query you would expect to look like
UPDATE schema.table SET id = 123 WHERE unique_id = 777`

It actually does this
UPDATE  schema.table SET id = 123 WHERE unique_id = 123`

Proposed Fix

Simply don't allow the id field to be updated.

Long-Term Fix

We should replace %{id} with a better unique descriptor, such as %{infoj_id} or similar that wouldn't be used a field name on the db

I just pushed a commit to make sure the Error message throws the Error using the layer.qID not 'id' so it is explicit what the issue is.


Propagate raw JSON as bytes setting to array element schema

This ensures that we generate the type as [][]byte. The original intention was to generate this a []byte but that never actually happened and we can't change it now.
 The linked issue implies [][]byte doesn't work today; could anyone be broken if we start generating []byte instead?

Let me clarify as there are a few angles to this problem.
Enabling rawjson-as-bytes was not working for arrays of untyped elements in some cases. The expectation was to generate [][]byte (i.e. a slice of raw JSON items) but we were generating []any.
When I originally added the rawjson-as-bytes feature, I intended to always emit []byte even if the swagger stated an array of untyped objects. You could argue that what we generate with this fix is technically correct, i.e. if the swagger states an untyped object you get []byte and if it states an array of untyped objects you get [][]byte. Whether or not it's better I suppose depends on one's perspective (I can see arguments both ways).
All that said, we have to leave it as [][]byte at this point to avoid any breaking changes (I believe KV would be impacted by such a change).

👍 thanks for the context. That makes sense and I see how [][]byte is easier than []byte in application code.


HTML Block: add option to prettify HTML code

When working with the HTML block and especially longer HTML code blocks it would be handy to have an option to prettify the HTML code.

fixed by #1840


Update Readme to include a how-to get an EVE version and syslog from SD card

Included updated Readme.
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

I'll be merging this now @mydatascience -- but see my comment above


Bug 1947756: Add maxUnavailable to DaemonSet

Add maxUnavailable to DaemonSet to speed up cluster upgrade by allowing more nodes to be updated simultaneously.

/retest

/lgtm


Inline Grid Edit of NumberInput can be lost after quick navigation

[From Jakub, reported at Client]
Has anyone encountered a changes-are-not-immediately-saving bug with numberEditor on the latest hoist/blueprint/ag-grid?
If a user changes a value in a grid column using numberEditor and then, very quickly afterwards, hits ENTER or clicks off the field, the value they just changed to is not saved. It appears to take a couple 100ms to save the value.
It occurs in https://toolbox-dev.xh.io/app/grids/inlineEditing
It does not happen in the last release of the client app, which uses:
Hoist React	62.0.1
React	18.2.0
ag-Grid	30.2.1
Blueprint Core	4.20.2
It does happen in the current dev of the client app, which uses:
Hoist React	65.0.0
React	18.2.0
ag-Grid	31.2.1
Blueprint Core	5.10.4

The issue in question from Toolbox:
https://github.com/xh/hoist-react/assets/70573025/9539a623-d513-4639-a797-0a48e167c8e9


Toasts aren't going away after launching multiple times

When launching the toast a 2nd time, it doesn't hide automatically.
Demo (launch toast once, wait a 2secs then launch again to see issue):
https://french-toast-demo.surge.sh/
repo: https://github.com/jinyus/toastr
video of the issue:
https://user-images.githubusercontent.com/30532952/210676089-f1569de5-3ffd-415b-9bd4-cccac8295bf8.mp4

Can you use a different ID for the subsequent toasts and try again? Since the toast is already closed, using the same ID shouldn't work.

This worked, thanks.


Could not find class 'android.app.ActivityManager$TaskDescription', on API 19

API 19
App crashing
Error:
E/dalvikvm: Could not find class 'android.app.ActivityManager$TaskDescription',

I haven't tested it myself, I'll let you know when I do.


[FlatList] serious problem

Problem description
If I add components in renderitem using the flatlist display and the symbol is to click on it will display error
error message*
0.43.3 err

0.43.4 err

Error code

Normal code

Think this might be related to #12905, I had the same thing in a FlatList when using a number as text

@fangkyi02 for now, do <Text>{${index}}</Text>. I believe this has been raised a few times!

Seems like a dupe of #12905. Try the workaround above. A fix will ship in the next release.


Add the ddev domain to the output of ddev version

The Problem/Issue/Bug:
ddev version doesn't show any information about the TLD used to spin up sites.
How this PR Solves The Problem:
Simple addition of the DDevTLD constant to the output of ddev version
Manual Testing Instructions:
Run ddev version
Automated Testing Overview:
One extra assertion was added to test for the TLD in the output.
Related Issue Link(s):
https://github.com/drud/ddev/issues/441
Release/Deployment notes:

I completely changed my review, as I was wrong about several things there.

@rfay this is ready for another look.

This is great, thanks so much.


Support web assets for .riv

Works great on mobile for IOS/Android!
I made things works on web devellopement, but I see that the assets .riv aren't  present in the web final static build.
Just write that command expo export -p web and go check the .build folder.
In my app.config i have
{
...
web: {
      bundler: "metro",
      output: "static",
      favicon: "./assets/images/favicon.png",
    },
...
}

Maybe it is juste something I have to do on my side.
I'll give info if I found something.

Hello @t1gu1 thanks for the report , just want to ask did you make a prebuild before exporting the web version
TBH I haven’t check the web support but will give it a try after your answer

Oh I just found why it's not present in web.
We have to add a require("@/assets/rive/bonsoir.riv"); somewhere in the code to include file in the bundle, even if it's not used.

Oh I just found why it's not present in web. We have to add a require("@/assets/rive/bonsoir.riv"); somewhere in the code to include file in the bundle, even if it's not used.

is this an issue from expo? or there is it mentioned in their docs

It's more a "ME" problem from what a found..
I'll share my expérience here if others found it.
For the web, assets has to be require() somewhere in the code to be present in the assets final build folder.
So for the web, I did that so select the good ressource: (In my RiveAdapter.web.tsx)
const [assets] = useAssets([
    require("assets/rive/boussole3.riv"),
    require("assets/rive/mapcanada3.riv"),
  ]);

  const source = assets?.find((asset) =>
    asset.name.includes(resourceName)
  )?.uri;


Friday 15-03-2024 roll call

Roll Call!
Leave a comment with these two things:

A summary of your study using only emojis
Something you'd like to share, anything goes! (within respect)

emoji cheat sheet

gud morning..

Good morning

Good morning!

Good Morning

Hello

Hello

Good Morning

salut

Good Morning

morgen

morning

good morning

Good morning


LepIndex - Can images be ordered so the front image is the first?

Currently there seems to be a consistent ordering of the back image first. Can this be reversed so the front image appears first?

Should be fixed for show order on next rebuild of import.

Resolved in show.  Need a mechanism to zoom thumbnails on mouseover.


Domain Process Coordinator - Execute Action Asynchronously when true

Hi @ImJohnMDaniel,
Hope you're well! Might I propose this change? I recently ran into a use case when the DomainProcessAbstractAction that ships with the framework did not meet my requirements. The scope of my use case, however, was limited to the methods provided by IDomainProcessAction (I did not need to implement IDomainProcessQueueableAction).
So, in my action class, instead of extending DomainProcessAbstractAction, I just implemented IDomainProcessAction. When I did this, I ran into this issue with the DomainProcessCoordinator. Because the coordinator is checking whether currentDomainProcess.ExecuteAsynchronous__c != null (it will never be null since it is a boolean field), by proxy we must always implement IDomainProcessQueueableAction. If we switch the if to just check for if ExecuteAsynchronous__c = true, then we do not have to implement IDomainProcessQueueableAction.
Curious to know your thoughts on this,
Ryan

This change is

G'day @rygramer.  Thanks for reaching out.  This is an interesting catch.  I will need to think about the implications of fixing this line of code.  Let me consult with @stohn777 and think about it for a bit and get back to you by next week.

Copy, thanks @ImJohnMDaniel!

Copy, thanks @ImJohnMDaniel!

G'day @rygramer.  After consulting with @stohn777 a bit on this, I made a slight adjustment to the solution that you are proposing.  Basically, it is going to perform a type check as well before setting the action to run in queue.  If this works with your use case, then we will approve and merge the changes.  Just let me know when you can.  Cheers!

Sounds great! Thanks @ImJohnMDaniel @stohn777

Thanks @rygramer  for the help!!!  Very much appreciated.


[SSD] Using liip/imagine-bundle

Hello,
I'm using in my app also liip/imagine-bundle for thumbnails. If I run bin/console dump-static-site no thumbnail will be generated and so not copied into the output directory. Any ideas how to make this work?
Thank you!

Hi,
I don't use the bundle so I have no idea what needs to be done.
My super random guess is:

add custom command to generate thumbnails before bin/console dump-static-site to the same output directory

I found out that I was missing: The images are only generated when requested, but SSD doesn't crawl assets. For the solution I added a new Twig filter, which changes the behavior, so images are generated on template render. Now everything works. Thank you! :)

I'm glad your solved it :) could you share your Twig filter code in raw here? I think you're not the first and last who is ussing the bundle and it would save other developers creating the same issue here.

namespace App;

use Liip\ImagineBundle\Service\FilterService;
use Twig\Extension\AbstractExtension;

class CustomExtension extends AbstractExtension
{
    private $filterService;

    public function __construct(
        FilterService $filterService,
    ) {
        $this->filterService = $filterService;
    }

    public function getFilters()
    {
        return [
            new TwigFilter('image_src', [$this, 'getResizedImage']),
        ];
    }

    public function getResizedImage($path, $filter = 'default')
    {
        return $this->filterService->getUrlOfFilteredImage($path, $filter);
    }
}

Thank you


Updated bash scripts for attested data

Added the attested data call to bash script .
Also added code to validate the main and intermediate certificates and the certificate chain.

lgtm


PromptFile URL Parsing Error

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

youtube-dl -U
youtube-dl is up-to-date (2<IP_ADDRESS>)

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
# youtube-dl http://www.promptfile.com/l/07247DA006-C77ED97278 --verbose
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'http://www.promptfile.com/l/07247DA006-C77ED97278', u'--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.12 - Linux-4.4.0-31-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: none
[debug] Proxy map: {}
[PromptFile] 07247DA006-C77ED97278: Downloading webpage
[PromptFile] 07247DA006-C77ED97278: Downloading video page
ERROR: Unable to extract URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 691, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 347, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/promptfile.py", line 43, in _real_extract
    url = self._html_search_regex(r'url:\s*\'([^\']+)\'', webpage, 'URL')
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 659, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 650, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: http://www.promptfile.com/l/9FD7EFDC80-D5AE30F56A
And any others at PromtFile

Description of your issue, suggested solution and other information
Have successfully used youtube-dl in the past to download from promptfile, but I cannot any longer. Not sure what version I was using before, it's been a while.
Other downloaders tried are failing to parse aspects of the page - so I imagine that PromptFile has tweaked the page a bit.

https://github.com/rg3/youtube-dl/pull/10751 fixed ;)

Hmm, still encountering errors on new version: (for science, I have tried the same video)
macbook-pro in ~
○ → youtube-dl --verbose http://www.promptfile.com/l/07247DA006-C77ED97278
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://www.promptfile.com/l/07247DA006-C77ED97278']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.24
[debug] Python version 2.7.10 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[PromptFile] 07247DA006-C77ED97278: Downloading webpage
[PromptFile] 07247DA006-C77ED97278: Downloading video page
ERROR: Unable to extract URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 355, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/promptfile.py", line 43, in _real_extract
    url = self._html_search_regex(r'url:\s*\'([^\']+)\'', webpage, 'URL')
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 667, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 658, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

FYI: #10751 is not merged yet.

https://github.com/rg3/youtube-dl/pull/10751 Merged ;)


[bug]: Asset Burning for Collectibles

cant burn assets which are json or oneof somehow via api, I think only token assets can be burned at the moment.
If I'm wrong please let me know how I would burn a Asset which is a Collectible.

I think should be the same command, the arguments do not depend on the asset type, just the asset ID or group key.

I think you might simply run into a limitation that doesn't allow you to burn an asset if it is the only one in an on-chain UTXO (e.g. it's the last asset and no change would be left over). That should be fixed once we address https://github.com/lightninglabs/taproot-assets/issues/514.

@weltitob do you have a repro scenario?

I think you might simply run into a limitation that doesn't allow you to burn an asset if it is the only one in an on-chain UTXO (e.g. it's the last asset and no change would be left over). That should be fixed once we address #514.

Okay, thanks ;)


Update documentation

The lack of ... documentation is completely confusing.
It's not even entirely clear if marionette/js/marionette even works (after all, if it's not meant to have backbone as a dependency then what is L69 doing in the package.json.
Is the idea something like all the things described at https://marionettejs.com/docs/ will just work except they'll not use Backbone at all?

Backbone is in dev dependencies and not the package.  But yeah, essentially marionette should be expected to work without backbone, but it will be tested to work with it nearly the same as before.  I would expect many if not most people would continue to use marionette with backbone for a while.  The docs will likely update in line with a beta release.  There's some outstanding issues to resolve first though.


email verify link missing http{s}://

https://github.com/biocore/qiita/blob/0d2491a5a45c87c3fe8ac486f9de8d94c5ff8b94/qiita_pet/handlers/auth_handlers.py#L46-L50
This causes email programs not to make the link clickable.

Thank you for your comment. I believe that feature is email client
dependent. Generally we test with gmail where the link is clickable.
Anyway, do you have a suggestion on how to make it generally clickable
for all clients?

Can't check code right now, but is it prefixed with mailto:?
On Apr 3, 2015 8:07 AM, "Antonio Gonzalez"<EMAIL_ADDRESS>wrote:

Thank you for your comment. I believe that feature is email client
dependent. Generally we test with gmail where the link is clickable.
Anyway, do you have a suggestion on how to make it generally clickable
for all clients?
—
Reply to this email directly or view it on GitHub
https://github.com/biocore/qiita/issues/1035#issuecomment-89300417.

It's an url not an email:
send_email(username, "QIITA: Verify Email Address", "Please "
"click the following link to verify email address: "
"%s/auth/verify/%s?email=%s"
% (qiita_config.base_url, info['user_verify_code'],
url_escape(username)))

lots of things work in gmail that don't work in mutt :wink:. Just thought I would point it out. QIITA is nice work btw. I'm already finding it incredibly useful.

Thanks @audy ! It is still on heavy development so please, do not hesitate on reporting issues so we can make it even more useful! And of course, contributions are more than welcome! We are planning to include some developer documentation soon, so it is easier for new developers start on the system.

:+1: another fellow mutt user! :fireworks:
On (Apr-03-15| 8:53), Austin Richardson wrote:

lots of things work in gmail that don't work in mutt :wink:. Just thought I would point it out. QIITA is nice work btw. I'm already finding it incredibly useful.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/1035#issuecomment-89335968

Anyway, do you have a suggestion on how to make it generally clickable
for all clients?

Either use an actual html anchor tag and send an HTML email or prepend http:// to the URL so that most browsers can recognize it as a URL.

I'm surprised the qiita_config.base_urlsetting is missing the http:// or https:// leader on the main system. That would fix this problem.

Yes, should we also add a comment right above that setting in the config
file saying something along the lines of:
# don't forget to specify the protocol i.e. http or https
base_url = http://debugatron-200.com/

On (Apr-05-15| 8:47), Joshua Shorenstein wrote:

I'm surprised the qiita_config.base_urlsetting is missing the http:// or https:// leader on the main system. That would fix this problem.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/issues/1035#issuecomment-89795737

Sounds good to me.

This was solved in the main deploy but the issue was never closed. Closing now.


Change to Identifier Record?

First to clarify that, in principle, the 'Data access' field in the identifier record refers to the other record types (sampling and effort), and not to the Identifier record itself, which should be considered public meta information
If this is agreed, the fields related to data owner/data originator could be simplified (we only need the custodian, the rest can be in the meta data catalgue record)
Remove fields 7 and 8 (Data Owner)
Rename fields DataOriginator to DataCustodian (to align with metadata) and make mandatory
or the other way around if that is easier ;)

@neil-ices-dk this looks sensible to me. One additional thought on top of those mentioned in meeting.
Removing of Data Owner from the data itself may make conversion into the international standard Darwin-Core (DwC) a little tricker. The "rightsHolder" DwC field wont be found in the data itself, so would have to be sourced from some joining to metadata.
However this is only an issue if the JCDP group think it's an issue ;) It mainly has impact on distribution of records into OBIS/GBIF or similar systems (and MEDIN by association).

First to clarify that, in principle, the 'Data access' field in the identifier record refers to the other record types (sampling and effort), and not to the Identifier record itself, which should be considered public meta information
If this is agreed, the fields related to data owner/data originator could be simplified (we only need the custodian, the rest can be in the meta data catalgue record)
Rename fields 7 (DataRightsHolder) - fieldType = varchar
Remove field 8 (DataOwnerContact)
Rename fields DataOriginator to DataCustodian (to align with ISO metadata) and make mandatory

@pcrjoana to change in Excel template/DATSU
@cmspinto to update database
@NikkiTaylorJNCC change in data standard

will be part of v2. data template


feature request: karma config export

Description
Currently, the package defaults to formatForSelenium. There is no other configuration supported out of the box.
Proposed solution
We could add a formatForKarma that modifies the returned object to match the karma config requirements in the config object.
Something along these lines:
import { BrowserFilter, OperatingSystemFilter }, getCapabilities from 'browserslist-browserstack';

const capabilities = await getCapabilities({
  username: 'browserstack-username',
  accessKey: 'browserstack-accesskey',
  browsers: {
    include: [
      BrowserFilter.CHROME
    ]
  },
  operatingSystems: {
    exclude: [
      OperatingSystemFilter.OSX
    ]
  },
  formatForKarma: true,
})

// returns
{
  base: "BrowserStack",
  browser: "chrome",
  browser_version: "90",
  os: "WINDOWS",
  os_version: "10"
}

Considered alternatives
Instead, there could be a plugins framework where the returned object could go through a custom parser that reshapes it according to the plugin. This way, the package could support more testing frameworks without having to codify each one into the codebase.
Something along these lines:
import { BrowserFilter, OperatingSystemFilter }, getCapabilities from 'browserslist-browserstack';

const karma = (obj) => {
  // some formatting logic
}

const capabilities = await getCapabilities({
  username: 'browserstack-username',
  accessKey: 'browserstack-accesskey',
  browsers: {
    include: [
      BrowserFilter.CHROME
    ]
  },
  operatingSystems: {
    exclude: [
      OperatingSystemFilter.OSX
    ]
  },
  // for every plugin in the array, a key with a corresponding config object would be added to the return value
  plugins: [ karma ]
});

// returns -->

{
...
  karma: {
    base: "BrowserStack",
    browser: "chrome",
    browser_version: "90",
    os: "OSX",
    os_version: "10"
  },
}

I'm happy to take on a PR for this if there's no objection to adding this feature 😀

formatForKarma seems strange alongside formatForSelenium.
plugins seems excessive, since all it is doing is remapping an object.

A few other alternatives.

format which could accept browserstack | selenium | karma
Remove the formatForSelenium option and expose a function to format the capabilities for selenium, making it more obvious how one might do the same themselves, without needing to extend the core API.

I think my preference would be format, given there aren't all that many formats out there I think keeping them in the project is fine, and they aren't much hassle to maintain. Also, if someone really wants to they can map any of the formats, to the format they desire.

@AndrewLeedham
I decided to do a little bit of both in #662.

kept the default behavior (format for selenium)
created a format key that accepts a function or false
exported two helpers, formatForSelenium and formatForKarma

Let me know what you think 😄


No update

I have been following your otp_pin_field but haven't seen any updates for a time. Kindly make some changes and add few more funcationalities.

Sure @vedantttechahead  i will add more functionality but can you tell which functionality are you look for
Thanks


Math Domain Error

Hi,
I'm trying to run your code and getting the following error:
Running EM algorithm
Traceback (most recent call last):
  File "HPV-EM.py", line 213, in <module>
    main()
  File "HPV-EM.py", line 207, in main
    EmAlgo(readsTable, allReadsNum, thresholdTpm=args.tpm, outputName=args.outname, printResult=args.printem)
  File "HPV-EM/EMstep.py", line 120, in EmAlgo
    l +=  w[i,j] * math.log(((1.-err)**Lm * err**Le * phi[j])/w[i,j])
ValueError: math domain error

Any suggestions on how to fix this?

I get the same error "line 120, in EmAlgo  l +=  w[i,j] * math.log(((1.-err)Lm * errLe * phi[j])/w[i,j])"
@jin-wash-u do you have any directions how this could be solved? I am running the algorithm on single-end 3'-Seq RNAseq data. Alignment and plots are fine until the error.


npx sonarwhal doesn't work

Running npx sonarwhal example.com results in:
info looking for local prebuild @ prebuilds/iltorb-v2.3.0-node-v57-darwin-x64.tar.gz
info looking for cached prebuild @ /Users/xxxxx/.npm/_prebuilds/https-github.com-MayhemYDG-iltorb-releases-download-v2.3.0-iltorb-v2.3.0-node-v57-darwin-x64.tar.gz
info found cached prebuild
info unpacking @ /Users/xxxxx/.npm/_prebuilds/https-github.com-MayhemYDG-iltorb-releases-download-v2.3.0-iltorb-v2.3.0-node-v57-darwin-x64.tar.gz
info unpack resolved to /Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/node_modules/iltorb/build/bindings/iltorb.node
info unpack required /Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/node_modules/iltorb/build/bindings/iltorb.node successfully
info install Successfully installed iltorb binary!
Couldn't find a valid path to load the configuration file.
? A valid configuration file can't be found. Do you want to create a new one? Yes
Welcome to sonarwhal configuration generator
? Do you want to use a predefined configuration or create your own based on your installed pa
ckages? predefined
? Choose the configuration you want to extend from web-recommended
Installing packages...
✔ Running command: npm install @sonarwhal/configuration-web-recommended -g
Configuration file .sonarwhalrc was created.
Error: Resource web-recommended not found
    at Object.exports.loadResource (/Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/dist/src/lib/utils/resource-loader.js:172:15)
    at Object.exports.loadConfiguration (/Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/dist/src/lib/utils/resource-loader.js:208:20)
    at userConfig.extends.map (/Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/dist/src/lib/config.js:38:52)
    at Array.map (<anonymous>)
    at composeConfig (/Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/dist/src/lib/config.js:37:47)
    at Function.fromConfig (/Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/dist/src/lib/config.js:149:28)
    at exports.analyze (/Users/xxxxx/.npm/_npx/2213/lib/node_modules/sonarwhal/dist/src/lib/cli/analyze.js:111:45)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Thanks for @sota1235 for catching this!

I think the solution would be to run npm install @sonarwhal/configuration-web-recommended without the global option in this scenario but I have no idea on how to test this :/

I couldn't repro this anymore with the beta package of webhint (npx hint https://example.com) so closing.


useFetch does not account for params change

Environment
Nuxt CLI v3.0.0-rc.6                                                                                16:22:47
RootDir: *                                  16:22:47
Nuxt project info:                                                                                16:22:47

Operating System: Darwin
Node Version:     v16.15.1
Nuxt Version:     3.0.0-rc.6
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, build, runtimeConfig
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-brbcqx?file=pages/index.vue
Describe the bug
When we use useFetch with the same URL, but with different query string parameters, changing the parameters does not trigger a new fetch. As you can see in the repo, navigating from Page One to Page Two, and back, does trigger the composable useData, but the data is not fetch given new params. If you navigate to / or /page2 directly, then we can see the correct data.
Additionally, using the querystring directly in the URL also results in the same bug.
Additional context
No response
Logs
No response

It seems that<EMAIL_ADDRESS>still has the same question. This is my code:
  const key = hash([     method,     url,     params,   ]);   const res = await useFetch("/request-url", {     key,     method: "get",     params,     initialCache: false,   });
When I start my nuxt3 project use nuxt dev. useFetch functon works well.
But I build my project use nuxt build. then start it by npx nuxt start. useFetch function seems to cache my HTTP request.
Is it because the generation environment caches data？
I need someone's help, PLZ.

Resolved! I use this code:
import { hash } from 'ohash'
and send key with this code 'key' : hash(['api-fetch', url, params]),


minor: use http's request context for metrics collection cancellation

Scratching the PR.
I was just reading the code and saw this, but now I realize that the context is not used anyway.


The documentation says your plugin is supported from iOS 8.1+ SDK but when I try to debug/run this on iOS 10 SDK I get error

Severity	Code	Description	Project	File	Line	Suppression State
Error	:	This version of Xamarin.iOS requires the iOS 10.2 SDK (shipped with Xcode 8.2) when the managed linker is disabled. Either upgrade Xcode, or enable the managed linker.	Carousel.iOS

That doesn't means iOS 8.1 is not supported. It means you have to update your XCode.

If my work is helping you, please help me back: https://xamarinhq.wufoo.com/forms/nominate-a-xamarin-mvp/
This is what i have done that is community visible:

Alex has been pretty active sharing his knowledge and answering questions in StackOverflow, GitHub and Xamarin Forums.
Alex has been open sourcing Xamarin components and plugin with the community, with more of 10 repositories being maintained on GitHub.
One of Alex's Xamarin.Forms plugin, the CarouselView, is currently being pulled into the Xamarin.Forms core (https://github.com/xamarin/Xamarin.Forms/pull/853). As an stable widget, this control has become the standard for Xamarin.Forms carousel screens with more that 16K downloads in NuGet and more than 100 solved and not open issues.
Another Alex's plugin, the SegmentedControl (https://github.com/alexrainman/SegmentedControl), is a big candidate to be also pulled into Xamarin.Forms core.
Plus Xamarin.Forms UI related plugins, Alex shares plugins to set app icon Badge, Google Analytics and KeyChain access.
Alex shares his knowledge about cutting edge technologies like Couchbase NoSQL and MobileIron integration with Xamarin Apps.


Updated to 1.19.2

Updated to 1.19.2. There is an occasional crash, however it doesn't affect the mod if you try to reload it afterwards. This might be on Tetra's end, but I'm not sure. Overall, works pretty well and not a lot of conflicts.

Yo, i'm unfamiliar with coding in general tbh, is there a way i could get the 1.19.2 version?

Message me on Discord on Monday, my handle is acetheeldritchking.

I'll try but also i'd need your code lol (i.e. Sandy#4025

Check the forks on Enlarged. I have a 1.19.2 fork; it's nothing extreme.

i dunno how to download it lol

Oh! You'll need an IDE to get a download of it. I can walk you through it Monday, I was planning on just giving you a copy of the jar file too.

thanks ill try to contact you monday ig

need your entire discord fr lol

acetheeldritchking
Sorry I ended up getting a lot of personal things happening.
AoF/SoFr discord: https://discord.gg/6bkCnV3Q


do not rename inuse files

Renaming files that are open does not work on windows depending on how file is opened.
Add a scope to ensure that the defer close occurs before rename.

LGTM
Curious what you are up to. Obviously the mention of Windows sparks some curiosity. :thinking:
Regardless of Windows it's just bad form to rename an open file, so this looks great!

LGTM
Curious what you are up to. Obviously the mention of Windows sparks some curiosity. 🤔
Regardless of Windows it's just bad form to rename an open file, so this looks great!

It is useful for test / dev to have an api server on windows that works. Unfortunately not every machine is hyper-v capable to run kind, or minikube, or k3s in vm.
To get api server to work I largely did 3 things

Hack out components that do not compile on windows (I invested 0 time getting them to compile, as they were not needed for my scenario)

rootless
containerd
netpool
syssetup

comment out the chmod
fix the rename issue

I saw that there was an issue open about windows support, and figured I would at least contribute back the rename issue. Hopefully someone will do it and it will save them a few minutes. However since the other ones are largely just hacks and more work would need to be done to contribute them back I didn't prepare PR's for them.
then simply launch k3s on an admin prompt (due to needing symlink priviledge)
k3s.exe  server --disable-agent -d c:\tmp\k3s

Note this still creates some pods in kube-system namespace that don't get scheduled because their exists no nodes in the cluster.
Anyways remaining hack code is available at https://github.com/KnicKnic/k3s/commit/3f54f563415c24bafd840e5823cf02bc31b79475 for your curiosity.

@ibuildthecloud well I tidied up the getting windows to build and submitted another PR https://github.com/rancher/k3s/pull/1444

Thanks @KnicKnic!

So @KnicKnic, I'd like to understand: you did this just to get a function K8s API server? Are you registering functional nodes that can launch pods to it or do you just need the API server for testing non-pod related controllers?

https://github.com/rancher/k3s/issues/1486

So @KnicKnic, I'd like to understand: you did this just to get a function K8s API server? Are you registering functional nodes that can launch pods to it or do you just need the API server for testing non-pod related controllers?

My goal was just to get api server to run on windows for dev/ci purposes It was not to get everything working. Although that would always be better :-) . I did find a previously existing issue for getting things to run on windows.
So I took this change, and change https://github.com/rancher/k3s/pull/1444 and added just enough changes to get a node started and joined. It will not be scheduable as I did not fix networking, I left that journey for someone else. You can see the issue for more details and the
branch I used https://github.com/rancher/k3s/issues/114#issuecomment-590047668


Visual Calendar: Add an additional date picker widget that has a different style.

This date picker should show a visual calendar that the user selects from.

Added birthday widget as part of fix available in 2.1.4. More widgets need to be added

I wish to be assigned to this task

@aubincris, this is the issue has been upgraded to a possible outreachy/GSoC project. This issue will be assigned to person who's project proposal is accepted. If you want to start by adding a date widget go ahead as we expect multiple date and calendar options to be added. However, I cannot exclusively assign it to you.


split DTConfig.pytest_extra_skips  key into pytest-ignore, pytest-skip and pytest-xfail

-ignore means skip collecting (tutorial/examples)
-skip means apply pytest.mark.skip (or $ doctest +SKIP) --- report as SKIPPED, do not run
-xfail means apply pytest.mark.xfail (or # may vary) -- report as XFAIL/XPASS, run but do not check

Need to allow both objects and paths, so that it works on both docstrings and tutorials.

Here's how (TIL):
$ cat test_1.py
import pytest

def test_smth():
    assert False

Then,
$ cat conftest.py
import pytest

def pytest_collection_modifyitems(config, items):
    item = items[0]
    item.add_marker(pytest.mark.xfail(reason='programmatic'))

produces
$ pytest test_1.py -v
================================= test session starts ==================================
platform linux -- Python 3.10.10, pytest-8.0.1, pluggy-1.3.0 -- /home/br/mambaforge/envs/scipy-dev/bin/python3.10
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/br/sweethome/proj/scipy/refguide_check_2/scrtch/.hypothesis/examples')
rootdir: /home/br/sweethome/proj/scipy/refguide_check_2/scrtch
plugins: scpdt-0.1, anyio-4.2.0, cov-4.0.0, timeout-2.1.0, hypothesis-6.84.3, xdist-3.2.1
collected 1 item

test_1.py::test_smth XFAIL (programmatic)                                        [100%]

================================== 1 xfailed in 0.14s ==================================


Why does my robot only print the log without displaying the login QR code

16:38:54.387 [main]DEBUG io.github.wechaty.grpc.GrpcPuppet-[77]  - IDLE
16:38:55.132 [main]DEBUG io.github.wechaty.eventEmitter.EventEmitter-[43]  - this eventName:START has no listener
16:38:55.133 [main]INFO  io.github.wechaty.Wechaty-[58]  - start Wechaty
16:38:55.168 [pool-12-thread-1]DEBUG io.github.wechaty.grpc.GrpcPuppet-[944]  - PuppetHostie EVENT_TYPE_LOGIN payload {"contactId":"wxid_g2c8qakzm2zn22"}
16:38:55.173 [pool-8-thread-1]DEBUG io.github.wechaty.Puppet-[267]  - class Type is io.github.wechaty.schemas.EventHeartbeatPayload
16:38:55.173 [pool-8-thread-1]DEBUG io.github.wechaty.Puppet-[79]  - heartbeat -> heartbeat
16:38:55.173 [pool-8-thread-1]DEBUG io.github.wechaty.io.github.wechaty.watchdag.WatchdogFood-[68]  - feed dog WatchdogFood(timeout=60000, data=heartbeat)
16:38:55.173 [pool-8-thread-1]DEBUG io.github.wechaty.io.github.wechaty.watchdag.WatchdogFood-[79]  - lastFeed is<PHONE_NUMBER>173
16:38:55.939 [pool-8-thread-2]DEBUG io.github.wechaty.Puppet-[499]  - contactPayload is null by id wxid_g2c8qakzm2zn22
io.github.wechaty.user.ContactSelf@15ccc200
16:39:02.556 [pool-9-thread-1]DEBUG io.github.wechaty.Puppet-[133]  - HEARTBEAT_COUNTER #1
16:39:02.614 [pool-12-thread-2]DEBUG io.github.wechaty.grpc.GrpcPuppet-[944]  - PuppetHostie EVENT_TYPE_DONG payload {"data":"`recover CPR #1"}
16:39:02.615 [pool-8-thread-3]DEBUG io.github.wechaty.Puppet-[267]  - class Type is io.github.wechaty.schemas.EventHeartbeatPayload
16:39:02.615 [pool-8-thread-3]DEBUG io.github.wechaty.Puppet-[79]  - heartbeat -> heartbeat
16:39:02.615 [pool-8-thread-3]DEBUG io.github.wechaty.io.github.wechaty.watchdag.WatchdogFood-[68]  - feed dog WatchdogFood(timeout=60000, data=heartbeat)
16:39:02.615 [pool-8-thread-3]DEBUG io.github.wechaty.io.github.wechaty.watchdag.WatchdogFood-[79]  - lastFeed is<PHONE_NUMBER>615
16:39:02.622 [pool-8-thread-4]DEBUG io.github.wechaty.Puppet-[158]  - class Type is io.github.wechaty.schemas.EventDongPayload
16:39:02.622 [pool-8-thread-4]DEBUG io.github.wechaty.eventEmitter.EventEmitter-[43]  - this eventName:DONG has no listener

@su-chang

@coderbot1  Which token are you using now? padplus or donut?

16:38:55.168 [pool-12-thread-1]DEBUG io.github.wechaty.grpc.GrpcPuppet-[944]  - PuppetHostie EVENT_TYPE_LOGIN payload {"contactId":"wxid_g2c8qakzm2zn22"}
it looks like you already login.


[Proposal][QTL] provide reverse lookup mapping via unApply.

The goal of this proposal is to introduce an API Change to the interface LookupExtractor.
Current interface only exposes String apply(String input) that defines a mapping between druid dimension to a mapped value in a given lookup.
In order to support some optimization and/or lookup introspection we can add List<String> unApply(Sting input) that provides the reverse mapping from a given lookup value to druid dimensions table.
One obvious contract of this method is:
for a given input String
foreach key in unApply(input)
	apply(key) == input
end

The major thing to worry about here is multi-value dimensions, and if you want to support inverting surjective extraction functions.

Another concern:
An injective extraction function only need be injective for the domain of the dimension of interest in the query of interest. Injective is a query time property because the extraction function may not be injective for an arbitrary domain. As such, any particular extraction function's injective-ness across the set of all possible Strings is not currently a property of a lookup extraction's underlying data map. (it could be added but would require more data about lookups to be propagated around)
Without this change (or other rule enforcement) it is not possible to simply do a full scan of the range of the lookup transformation and guarantee that only the values of interest will return from the function, but since any values outside the dimension should be eventually ignored, this may not be a problem.
To do a full table scan of the dimension values, apply the lookup transformation, and filter on the values is what the dimension extraction filter currently does. The problem is that it cannot be applied in an optimized way (ex: at the broker) because the broker does not know what the potential dimension values are, it only can get the entire domain of the lookup.
Additionally, the lookup fn has the capacity to either retain or replace missing values, including the capacity to treat missing values as null. Such behavior would have to be preserved when doing an unApply.
From prior conversations I'm assuming the point here is trying to make QTL have the capacity to avoid the full dimension-value scan for pattern matching. Doing so should be possible, but it may have to have very specific constraints on when it can be done.

@drcrallen I don't understand.  Can you be more specific?
At a high level, I think that what we are realizing is that the idea of ExtractionFn is a good start for QTL, but it's not sufficient.  For this kind of join, we actually need more functionality and I think it makes a lot of sense to enforce that in the interface in order to unify functionality.  You are correct that the big thing we cannot do without unapply() is the broker-level rewrites for filters.

@cheddar Sure,
In the current extractionFn method, the QTL stuff is all represented as a simple map of a set of keys to some values.
In the current implementation you can have a map as follows:
{
  "key1":"value1",
  "key2:"value2",
}

Which takes the key# and extracts them to be value#. The most simple case.
The current implementation permits the following functionality:
{
  "dim1Key1":"value1",
  "dim1Key2":"value2",
  "dim2Key1":"value1",
  "dim2Key2":"value2"
}

For a particular query you may only have dimension values {"dim1Key1","dim1Key2"} or {"dim2Key1","dim2Key2"} depending on which dimension you are extracting. As such, the individual ExtractionFn which uses the QTL-map can still be injective, since the domain of the dataSource dimension is a subset of the QTL key set. But the total key set for a QTL map (or set of all strings) may not be injective (because there are multiple instances of value# in it.
So, if you were to do a simple broker-level rewrite, you could do something like selecting value1 to mean dim1Key1 OR dim2Key1. Which I think would end up being OK because one of the other might never be present.

@cheddar do you have specific use cases that are not covered well by the simple QTL implementation that currently exists?

@drcrallen Thanks for the comments:
So i am not sure i do understand the concerns about having unApply() at the lookup extractor API.
In fact current implementation of lookup is a map based, Hence it is by construction that the unApply function can be built.
As your example shows it is perfectly fine to filter by dim1Key1 OR dim2Key1 if the filter value is value1.
Is there a case where unApply can't be constructed ?

@drcrallen any updates about this ?

@b-slim @drcrallen is out today, he should be back tomorrow.

Done


TODO: Server Config

Currently the config is being copied into /bin/Server but if the config is missing the server will crash.
Project: SS14.Server

Implement error handling to correct this
When it checks for the config: if it is missing then it should write a default config to the config file.

Note: Server stack overflows for spooky reasons if you try to XML serialize the new config file

Currently working on this.

Probably best to move server config to toml.

Server config system has been remade and moved to TOML.
https://github.com/space-wizards/space-station-14/pull/253


Adding the ability to define the radius of the dots Resolves #485

The dot radius for both the path and the tooltip can be set via the options object with the following format:
dots {
  pathRadius: 4,
  tooltipRadius: 6
}

If this is not set, it will default to 2 and 3 respectively

@lorem--ipsum The build is currently failing due to missing google-chrome-stable dependencies. I don't think that this could be related to my changes. Any advice?

Okay so I've fixed the issue, please pull master and rebase from it
then push again on your PR's branch and you should be all set

Please rebase

Any chance of this getting a review? Would be awesome, since I am currently using a non-official version of the line-chart lib (one with my changes).

Okay could you please add a e2e test and update the doc so we can see better what'd be the API now ?
Hint : to add an e2e tests, simply run gulp new-e2e-test --name=my_awesome_test.

sure thing

e2e tests and updated docs, as requested. :)

Just a quick question on this, why not use CSS to achieve this? Something like
circle.dot {
    r: 10px;
}

You can play around with an example here: http://codepen.io/chaosmail/pen/bpZBob
In my opinion this setting would only make sense on a per series basis (in some use-cases), but just for styling all dots it's more convenient with CSS. What do you guys think?

What I like about the v2 is that it is fully customizable via CSS. So I think everything concerning styling that is not based on special series or data points (such as defining radius with a functon of the value) should be added as CSS and not as an option. But I would be happy to discuss this.

Yeah I agree. I had this feeling yesterday without being able to exactly put my finger on it, but yeah, doing this via CSS makes more sense. How does that sound @hambyiii ?

Although it is possible to set the dot series via CSS, the same isn't true of the tooltip dot, since that is a path rather than a circle.

Fair point. Then I think it would make more sense to change the tooltip dots to be circles. Originally I wanted them to be paths so they could have different shapes, but since it's never been done and it's in the way, feel free to change that.
Sorry for being picky, we really appreciate your interest in the project :-)

Yu can try my demo, it works also for tooltip dots (although a little differently)

Wrong dots :) I was referring to the actual dot that appears on the chart during mouseover, but as lorem--ipsum says, changing it to a circle and then doing everything via css might be the better solution

I'm still here, not gone away :) I am going to start a new branch for switching the tooltip dot from a path to a circle, if this is okay with you guys.

That's great, thanks :)

Closing this pull request in favour of the new one I have created: https://github.com/n3-charts/line-chart/pull/505


building deb package on stretch broken (debhelper version changed)

ping @tianon since you are a maintainer of the debhelper package maybe you know what sepcifically changed
so it seems the debhelper version on stretch has been bumped (debhelper (9.20160306)) https://packages.debian.org/stretch/debhelper http://metadata.ftp-master.debian.org/changelogs/main/d/debhelper/debhelper_9.20160306_changelog
so this leads to errors when trying to build the docker-engine debs:
chmod: cannot access '../../hack/make/.build-deb/docker-engine/usr/share/man/man5/config-json.5': No such file or directory
chmod: cannot access '../../hack/make/.build-deb/docker-engine/usr/share/man/man8/docker-daemon.8': No such file or directory
dh_compress: chmod a-x ../../hack/make/.build-deb/docker-engine/usr/share/doc/docker-engine/README.md ../../hack/make/.build-deb/docker-engine/usr/share/doc/docker-engine/changelog ../../hack/make/.build-deb/docker-engine/usr/share
/doc/docker-engine/changelog.Debian ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-attach.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-build.1 ../../hack/make/.build-deb/docker-engine/usr/share/
man/man1/docker-commit.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-cp.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-create.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docke
r-diff.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-events.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-exec.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-export.1 ../
../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-history.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-images.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-import.1 ../../hack/m
ake/.build-deb/docker-engine/usr/share/man/man1/docker-info.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-inspect.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-kill.1 ../../hack/make/.build-de
b/docker-engine/usr/share/man/man1/docker-load.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-login.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-logout.1 ../../hack/make/.build-deb/docker-engi
ne/usr/share/man/man1/docker-logs.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-network-connect.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-network-create.1 ../../hack/make/.build-deb/docker
-engine/usr/share/man/man1/docker-network-disconnect.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-network-inspect.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-network-ls.1 ../../hack/make/.b
uild-deb/docker-engine/usr/share/man/man1/docker-network-rm.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-pause.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-port.1 ../../hack/make/.build-deb/
docker-engine/usr/share/man/man1/docker-ps.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-pull.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-push.1 ../../hack/make/.build-deb/docker-engine/usr/
share/man/man1/docker-rename.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-restart.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-rm.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man
1/docker-rmi.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-run.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-save.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-search.1
../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-start.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-stats.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-stop.1 ../../hack/mak
e/.build-deb/docker-engine/usr/share/man/man1/docker-tag.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-top.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-unpause.1 ../../hack/make/.build-deb/do
cker-engine/usr/share/man/man1/docker-update.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-version.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-volume-create.1 ../../hack/make/.build-deb/dock
er-engine/usr/share/man/man1/docker-volume-inspect.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-volume-ls.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-volume-rm.1 ../../hack/make/.build-deb/
docker-engine/usr/share/man/man1/docker-volume.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker-wait.1 ../../hack/make/.build-deb/docker-engine/usr/share/man/man1/docker.1 ../../hack/make/.build-deb/docker-engine/usr/s
hare/man/man5/Dockerfile.5 ../../hack/make/.build-deb/docker-engine/usr/share/man/man5/config-json.5 ../../hack/make/.build-deb/docker-engine/usr/share/man/man8/docker-daemon.8 returned exit code 1
debian/rules:40: recipe for target 'binary' failed
make: *** [binary] Error 1
dpkg-buildpackage: error: debian/rules binary gave error exit status 2

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Arg, this looks hairy -- I'll take a look and see what I can figure out. :disappointed:

It's got to be one of:
  * dh_compress: Correct and warn if given a path with a package
    tmp dir prefix (e.g. "debian/<pkg>/path/to/file").
  * dh_compress: Handle file resolution failures more gracefully.
    Thanks to Daniel Leidert for reporting this issue.
    (Closes: #802274)

I'm thinking it's caused by our non-standard symlinking, but I'm testing that theory right now.

I noticed that there is a new commit in master, but I don't know if that fixes this issue:
https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=f29fc94894e9ce483b969878e9e48d547517d77f
Currently testing injecting the master dh_compress script in the container:
ADD https://anonscm.debian.org/git/debhelper/debhelper.git/plain/dh_compress /usr/bin/
RUN chmod +x /usr/bin/dh_compress

(specifically, the way we create debian/ as a symlink instead of a simple directory, which is uncommon)

Confirmed, this is definitely new to the "canonicalization" that dh_compress is now doing for validation purposes, and our symlink isn't good enough anymore.  Creating a PR to fix this shortly.

@tianon what if we just copy all the files over a new debian directory? that sounds straightforward.

Yeah, that's what I'm planning (replacing line 68 of hack/make/build-deb with a mv instead of ln -- feel free to take over if you'd like!)

okay, I'm testing that, I'll open a PR if it works. Thanks!

:+1:

I'm testing as well, but my machine is struggling ATM so you'll likely get there faster than I will. :disappointed:

Confirmed!
diff --git a/hack/make/build-deb b/hack/make/build-deb
index 81fc222..64cd527 100644
--- a/hack/make/build-deb
+++ b/hack/make/build-deb
@@ -65,7 +65,7 @@ set -e
 			echo 'ENV DOCKER_EXPERIMENTAL 1' >> "$DEST/$version/Dockerfile.build"
 		fi
 		cat >> "$DEST/$version/Dockerfile.build" <<-EOF
-			RUN ln -sfv hack/make/.build-deb debian
+			RUN mv -v hack/make/.build-deb debian
 			RUN { echo '$debSource (${debVersion}-0~${suite}) $suite; urgency=low'; echo; echo '  * Version: $VERSION'; echo; echo " -- $debMaintainer  $debDate"; } > debian/changelog && cat >&2 debian/changelog
 			RUN dpkg-buildpackage -uc -us
 		EOF

...
dpkg-deb: building package 'docker-engine' in '../docker-engine_1.11.0~dev~git20160301.222424.0.793d3b5-0~stretch_amd64.deb'.
 dpkg-genchanges  >../docker-engine_1.11.0~dev~git20160301.222424.0.793d3b5-0~stretch_amd64.changes
dpkg-genchanges: including full source code in upload
 dpkg-source --after-build docker
dpkg-buildpackage: full upload; Debian-native package (full source is included)
 ---> e8d0c721c498
Removing intermediate container 468e9ff5bc10
Successfully built e8d0c721c498
docker-engine_1.11.0~dev~git20160301.222424.0.793d3b5-0~stretch.dsc
...

https://github.com/docker/docker/pull/21226


ReNameView does not produce correct rollback if using a non-default schema.

Environment
Liquibase Version: 4.7.1 (Although I believe the bug has existed since the inception of renameView)
Database Vendor & Version: Postgres 13
Operating System Type & Version: MacOS 12.1
Description
Rollback of RenameViewChange does not include the schema.  This is possibly due to not setting the schemaName in the createInverses method in RenameViewChange.
Steps To Reproduce

Create a new schema in v0
Create a View in the new schema in a v1 tag.
Rename the View, specifying the schema, in a v2 tag
Rollback to the v1 tag

Actual Behavior
Error is thrown: ERROR: relation "public.view_name" does not exist
Expected/Desired Behavior
No error.  The correct schema should be set.

Looks like the issue has been fixed for liquibase 4.15. If the issue continues to happen to you, please reach out and we will have a second look. Thanks!


doc fix of HiveThriftServer

What changes were proposed in this pull request?
Just minor doc fix.
\cc @yhuai

Test build #60479 has started for PR 13659 at commit 9f8b534.

LGTM, are those all the copy / paste errors?

I think so,  Just post another commit for another place's doc fix.

Test build #60483 has started for PR 13659 at commit f57e519.

Test build #60479 has finished for PR 13659 at commit 9f8b534.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60479/
Test PASSed.

Test build #60483 has finished for PR 13659 at commit f57e519.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60483/
Test PASSed.

Merged build finished. Test PASSed.

Test build #60489 has started for PR 13659 at commit 3574931.

Test build #60489 has finished for PR 13659 at commit 3574931.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60489/
Test PASSed.

Merged to master/2.0


Add method to load all Values from a store

Add a method, probably to the Value class, that allows you to load all Values from the current store into a list of Values. This may be complimentary to the work in #121 , as that could make this easier to do. Alternatively, this could be done without that change in a less elegant way.

Resolved by Store query functionality.

Even though this is possible by the Store query/filter/search_artifacts functionality, a substantial amount of code is needed to pull it off. It makes more sense to add a frontend, something like Value.load_all(), that underneath does the work to make it easier to load all Values from a Store.
Currently, partial code to do this would look something like this:
 with ManagedSession(session().store.session()) as handle:
    query = Query(filter=ArtifactTypeFilter(type=FilterType.TYPE, artifact_type=ArtifactType.VALUE))
    artifacts = handle.search_artifacts("ns", "IrisClassifier", "0.0.1")
    values = [Value.from_model(value_model) for value_model in artifacts]

However, this is not complete, as Value.from_model is specific for each Value subtype, so it wouldn't work in this simplified form. Furthermore, this should also work for external Value types extended by the user, so more work needs to be added to support that in a transparent way.


This function has been renamed

https://github.com/Improbable-AI/airobot/blob/8277fa242ed188858c0834d5b32e7a7a12b80058/src/airobot/utils/common.py#L57

see https://stackoverflow.com/questions/65628149/ratcave-scipy-spatial-transform-rotation-rotation-object-has-no-attribute-a

Thanks for pointing it out. We have fixed that in the qa branch. You can use that instead.


[libepoxy] build failure

Host Environment

OS: [ Windows 10]
Compiler: VS 2019

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libepoxy
Failure logs
-PS C:\Users\王炳龙> vcpkg install libepoxy
Computing installation plan...
The following packages will be built and installed:
libepoxy[core]:x86-windows
Starting package 1/1: libepoxy:x86-windows
Building package libepoxy[core]:x86-windows...
-- Using cached E:/vcpkg-master/downloads/anholt-libepoxy-1.5.4.tar.gz
-- Cleaning sources at E:/vcpkg-master/buildtrees/libepoxy/src/1.5.4-337c486045.clean. Pass --editable to vcpkg to reuse sources.
-- Extracting source E:/vcpkg-master/downloads/anholt-libepoxy-1.5.4.tar.gz
-- Applying patch libepoxy-1.5.4_Add_call_convention_to_mock_function.patch
-- Using source at E:/vcpkg-master/buildtrees/libepoxy/src/1.5.4-337c486045.clean
-- Acquiring MSYS Packages...
-- Acquiring MSYS Packages... OK
-- Configuring x86-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: E:/vcpkg-master/downloads/tools/python/python-3.8.3-x86/python.exe E:/vcpkg-master/downloads/tools/meson/meson-0.54.2/meson.py -Denable-glx=no -Denable-egl=no -Dcmake_prefix_path=['E:/vcpkg-master/installed/x86-windows','E:/vcpkg-master/installed/x86-windows/share'] --buildtype plain --backend ninja --wrap-mode nodownload --default-library shared --libdir lib --prefix E:/vcpkg-master/packages/libepoxy_x86-windows/debug --includedir ../include E:/vcpkg-master/buildtrees/libepoxy/src/1.5.4-337c486045.clean -Dc_args=['/nologo','/DWIN32','/D_WINDOWS','/W3','/MP','/D_DEBUG','/MDd','/Z7','/Ob0','/Od','/RTC1'] -Dcpp_args=['/nologo','/DWIN32','/D_WINDOWS','/W3','/GR','/EHsc','/MP','/D_DEBUG','/MDd','/Z7','/Ob0','/Od','/RTC1'] -Dc_link_args=[] -Dcpp_link_args=[]
Working Directory: E:/vcpkg-master/buildtrees/libepoxy/x86-windows-dbg
Error code: 2
See logs for more information:
E:\vcpkg-master\buildtrees\libepoxy\config-x86-windows-dbg-out.log
E:\vcpkg-master\buildtrees\libepoxy\config-x86-windows-dbg-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_meson.cmake:161 (vcpkg_execute_required_process)
ports/libepoxy/portfile.cmake:16 (vcpkg_configure_meson)
scripts/ports.cmake:76 (include)
Error: Building package libepoxy:x86-windows failed with: BUILD_FAILED
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.
config-x86-windows-dbg-err.log
config-x86-windows-dbg-out.log

Uploading config-x86-windows-dbg-out.log…

Hi @W-Binglong
Thanks for posting this issue.
UnicodeDecodeError: 'gbk' codec can't decode byte 0x84 in position 335288: illegal multibyte sequence
It's duplicated to #11525.


add support for reading and writing RTCP XR packets

As specified in RFC 3611.
Supports:

Loss RLE
Duplicate RLE
Packet Receive Times
DLRR

Does not support:

Statistics Summary
VOIP Metrics

Codecov Report
Attention: Patch coverage is 79.74684% with 96 lines in your changes missing coverage. Please review.

Project coverage is 74.66%. Comparing base (3bef0df) to head (0eca050).

Files with missing lines
Patch %
Lines

src/xr/mod.rs
71.73%
26 Missing :warning:

src/xr/dlrr.rs
80.00%
13 Missing :warning:

src/xr/duplicate_rle.rs
73.91%
12 Missing :warning:

src/xr/loss_rle.rs
73.91%
12 Missing :warning:

src/xr/packet_receipt_time.rs
84.37%
10 Missing :warning:

src/xr/rle.rs
92.36%
10 Missing :warning:

src/xr/receiver_reference_time.rs
68.00%
8 Missing :warning:

src/compound.rs
0.00%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   72.68%   74.66%   +1.97%
==========================================
  Files          15       22       +7
  Lines        1219     1693     +474
==========================================
+ Hits          886     1264     +378
- Misses        333      429      +96

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Install instructions?

Got this error when trying to build another project:
package github.com/pions/webrtc/pkg/ice: cannot find package "github.com/pions/webrtc/pkg/ice" in any of:
        /usr/local/go/src/github.com/pions/webrtc/pkg/ice (from $GOROOT)
        /home/chiller/go/src/github.com/pions/webrtc/pkg/ice (from $GOPATH)

So I assumed it can be installed like:
$ go get github.com/pion/ice
# github.com/pion/dtls
src/github.com/pion/dtls/prf.go:72:10: undefined: curve25519.X25519

$ go version
go version go1.13 linux/amd64

Hey @ChillerDragon
You probably want github.com/pion/webrtc/v2, we added a new major version when we changed names from pions -> pion

@Sean-Der thanks for the fast reply how do I install github.com/pion/webrtc/v2?
sorry if this question is weird but I have no clue how go works
$ go get github.com/pion/webrtc/v2
package github.com/pion/webrtc/v2: cannot find package "github.com/pion/webrtc/v2" in any of:
        /usr/local/go/src/github.com/pion/webrtc/v2 (from $GOROOT)
        /home/chiller/go/src/github.com/pion/webrtc/v2 (from $GOPATH)

Glad to hear it worked @ChillerDragon
If you are up for it, would you mind updating the docs that you were following? I am sure lots of people are hitting this issue, and just don't file issues :(
thanks for using Pio!

I sadly do not have any findings yet I just followed your awesome list to find something working because I could not understand the webrtc example :D I smashed In a bunch of go commands into my terminal until different things started to break. I was not too successful yet but we will see... looks like a nice project for sure!


move other policy engines

Signed-off-by: Jim Bugwadia<EMAIL_ADDRESS>Move other policy engines out of FAQs into instantiations, and order alphabetically.

Preview changes: https://deploy-preview-33974--kubernetes-io-main-staging.netlify.app/docs/concepts/security/pod-security-standards/#policy-instantiation

/lgtm

/lgtm


zend_mm_heap corrupted when 2 PHPCPP extensions are loaded

I experience zend_mm_heap corrupted errors when two PHPCPP-based extensions are loaded at the same time ?
Along this error PHP CLI exits with exit code 1 when both extensions are loaded.
When one of the extensions is loaded without the other one, everything works in that extension
When both extensions are loaded at the same time, everything still seems to work but the zend_mm_heap corrupted are shown and all PHP CLI processes now exit with exitcode 1 (instead of 0)
How do I debug this situation.
I am using PHPCPP 2.2.0
I can provide makefiles or extension source code if needed.
I am running PHP 7.2.32-1+ubuntu16.04.1+deb.sury.org+1 (cli) (Extension API: 20170718)

Never mind this one - it was caused by some global variables used by both extensions


Pics leer

removed all text form images. for simpler replacing with updates.

sorry i created this pr by accident, on the other hand it might help other transaltor to have the pics without text so thea can add their translations easier...remove it if you think its helpful.

@dotob Hey Sebastian, I agree that this might be useful, but this PR contains all of our changes from the German translation and not just the images without the text. I'd close it and and then open a new one that would only add the images.


URL with URL-unsafe characters causes invalid URI errors

I'm testing an API where we have the name of the resource as the unique identifier. If the name includes a space or any other URL-unsafe character, I see the following:
Failure/Error: it { is_expected.to validate(:get, '/resources/{name}', 200, params) }
URI::InvalidURIError:
 bad URI(is not URI?): http://www.example.com:80/resources/name of thing

I would expect apivore to convert this to
/resources/name+of+thing

so my tests can remain legible.
I'm happy to write a patch; it would just involve adding CGI::escape to https://github.com/westfieldlabs/apivore/blob/275e799ea72c2a5961b56b1742c2e1d09daf308c/lib/apivore/validator.rb#L50 as is done internally in Rails' Object#to_query (see https://github.com/rails/rails/blob/52ce6ece8c8f74064bb64e0a0b1ddd83092718e1/activesupport/lib/active_support/core_ext/object/to_query.rb#L12).
Please let me know if this would be valuable, or if the thought is that that actually should be an error.

@amcaplan is it possible to use the to_query rails method?

No.  to_query converts a key-value pair into key=value for use in a URL query string.  CGI::escape is for a single String.  It's also in the Ruby standard library, already used in any Rails app, so I'm not sure why we'd not want to use it.

@amcaplan This would be a breaking change as as any string already escaped would be doubly escaped and then fail. It could be considered for a later Apivore version.
Personally, I don't see:
it { is_expected.to validate(:get, '/resources/{CGI.escape(name)}', 200, params) }
as illegible. It is also explicit that there can be things in name that need special treatment. Often a significant understanding of code can be found by seeing how the tests are written.
There are also many ways to bury and refactor the above into Rails-like URL helpers, thus:
def resources_path(name)
  "/resources/#{CGI.escape(name)}"
end

it { is_expected.to validate(:get, resources_path(name), 200, params) }

and many other options.

Breaking change

@gwshaw I think I understood what you said, but I don't think it was expressed clearly.  The validation URL has to exactly match what the Swagger spec has.  So if Swagger has a URL '/resources/{name}', the URL to validate has to be '/resources/{name}' exactly, with name set in params.  If you try:
it { is_expected.to validate(:get, '/resources/escaped+name', 200, {})

the endpoint to validate won't be recognized by Apivore.
Instead, you have to do:
let(:params) {{ 'name' => 'string with spaces') }}
it { is_expected.to validate(:get, '/resources/{name}', 200, params) }

which of course breaks, because Apivore tries the URI /resources/string with spaces, which isn't a valid URI.
I'm still pretty sure you're right, so I've rephrased a bit.
For posterity, here's my understanding:

it { is_expected.to validate(:get, '/resources/{name}', 200, params) } fails if params['name'] is a non-URL-safe String.
I suggested calling CGI::escape on URL params to make sure they're URL-safe.
@gwshaw pointed out that if you already escaped it (e.g., params['name'] = 'string+with+spaces'), it'll be re-escaped ('string%2Bwith%2Bspaces'), which would be a breaking change.
Hence, the recommended solution in this case is to escape it yourself:

let(:params) {{ 'name' => CGI.escape("string with spaces") }}
it { is_expected.to validate(:get, '/resources/{name}', 200, params) }

Is that right?

Sorry, I misinterpreted your code and my examples were then incorrect, but yes, you need to escape it yourself as you show in your example.