[plot] syncaxis.py example raises an error when closing

On macOS with python 3.5 and PyQt5.10, I get the following error with syncaxis.py example:
QObject::disconnect: No such signal QObject::sigLimitsChanged(double,double)
Exception ignored in: <bound method SyncAxes.__del__ of <silx.gui.plot.utils.axis.SyncAxes object at 0x110e75048>>
Traceback (most recent call last):
  File "silx/gui/plot/utils/axis.py", line 131, in __del__
  File "silx/gui/plot/utils/axis.py", line 124, in stop
TypeError: disconnect() failed between 'sigLimitsChanged' and 'unislot'

Is SyncAxis.__del__ needed?

Test synchronization when sync object is destroyed ... Traceback (most recent call last):
  File "C:\projects\silx\venv_test\lib\site-packages\silx\utils\weakref.py", line 177, in __call__
    raise ReferenceError("weakly-referenced object no longer exists")
ReferenceError: weakly-referenced object no longer exists

It looks to be a yes.

On Python 3.5 PyQt 5.10
./run_tests.py silx.gui.plot.test.testUtilsAxis
Unhandled Python exception

Became more and more ugly, but it works

Reopening as I still get an error on macOS, python 3.5, PyQt5.10 when closing syncaxis.py sample code:
Exception ignored in: <bound method SyncAxes.__del__ of <silx.gui.plot.utils.axis.SyncAxes object at 0x110ef4400>>
Traceback (most recent call last):
  File "/Users/tvincent/src/silx/build/lib.macosx-10.6-intel-3.5/silx/gui/plot/utils/axis.py", line 155, in __del__
  File "/Users/tvincent/src/silx/build/lib.macosx-10.6-intel-3.5/silx/gui/plot/utils/axis.py", line 147, in stop
AttributeError: 'NoneType' object has no attribute 'sigLimitsChanged'


Deprecate metadata manager V1 implementation in Cassandra

Update unit tests
Remove DomainTableVersion variables
Improve domain cache refreshment on newly created domain

Coverage increased (+0.3%) to 67.262% when pulling 13fdcaa2d40d9a67924213bc156949dd4bbfde15 on deprecate-domain-v1 into 6d2ffbd5110eaba92c03ac179106521cf1fee6aa on master.


DBInstance support host from Kubernetes secret/configmap reference

Example taken from here: https://github.com/db-operator/db-operator/blob/main/examples/instance-generic.yaml.
apiVersion: kinda.rocks/v1beta1
kind: DbInstance
metadata:
  name: "example-generic"
spec:
  adminSecretRef:
    Name: example-instance-admin-secret
    Namespace: << namespace of admin secret >>
  engine: postgres
  generic:
    host: << remote database server address >>
    port: 5432
---
apiVersion: v1
kind: Secret
metadata:
  name: example-instance-admin-secret
  namespace: << operator namespace >>
type: Opaque
data:
  user: cG9zdGdyZXM=
  password: c2VjdXJlcGFzc3dvcmQK

spec.generic.host is expected to be a string but our use case requires settings this from a Kubernetes Secret (of Configmap also fine). Can we copy the same logic for retrieving the admin credentials to the host field? This means the example becomes something like
apiVersion: kinda.rocks/v1beta1
kind: DbInstance
metadata:
 name: "example-generic"
spec:
 adminSecretRef:
   Name: example-instance-admin-secret
   Namespace: << namespace of admin secret >>
 engine: postgres
 generic:
   host:
     secretRef:
       name: example-instance-admin-secret
       namespace: <namespace>
   port: 5432
---
apiVersion: v1
kind: Secret
metadata:
 name: example-instance-admin-secret
 namespace: << operator namespace >>
type: Opaque
data:
 host: my-instance.rds.amazonaws.com
 user: cG9zdGdyZXM=
 password: c2VjdXJlcGFzc3dvcmQK

This is a bit tough. Because it's a breaking change, it will require a new api version.
Here is the WIP PR: https://github.com/db-operator/db-operator/pull/67
And the issue: https://github.com/db-operator/db-operator/issues/66
We are almost ready to be there, but there are some things that are not ready/designed yet, and some of them are big.
I would say, once we have these 3 ready/designed, we can have a new APi version.

https://github.com/db-operator/db-operator/pull/81 But I want to update everything, so we don't have logrus at all
https://github.com/db-operator/db-operator/issues/17 I need to go through all the postgres/mysel params and find out which of them can be configured via CRD, and update the db package
https://github.com/db-operator/db-operator/pull/87 It's ready, just waiting for a review from another dev

But as you see, two of them are not ready at all, and both of can be pretty complicated. So I can't promise that we have this feature soon.

What I can offer now. I can make the PR with a new API version buildable, and add this feature there. Then you'll be able to install this version using the dev image. But then we can't promise any kind of real support, because you'll be using a test version of the operator. It will take some time too, but not that long as real production implementation

Hi @allanger thanks for the quick response much appreciated! I haven't had time to go over the linked PRs in depth, but here is an idea that came to mind:
How about changing the type of host to either string or object using oneOf?  In code you can check if the value is a string which means the address was given or if it's an object (with the corresponding fields) with a reference to a secret. If we can get this to work no breaking change is required and it's more flexible.
From the CRD perspective this appears to be supported in Kubernetes:

for each field in an object and each item in an array which is specified within any of allOf, anyOf, oneOf or not, the schema also specifies the field/item outside of those logical junctors (compare example 1 and 2).
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#specifying-a-structural-schema

@sjoukedv I haven't thought about it, thanks m. I will check it, and probably will be able to make it ready for release within a couple of weeks

Maybe I haven't spent enough time with that, but I don't think that oneOf is supported by controller-gen for crd generation.
But I can implement it this way without removing old fields, that it won't be a breaking change.
https://github.com/db-operator/db-operator/issues/96#issuecomment-1909811222

So, this is merged: https://github.com/db-operator/db-operator/pull/102
Will be released soon too

https://github.com/db-operator/db-operator/releases/tag/v2.4.0


Something in 0.4.8 broke my stuff

Describe the bug
I have a DV table that shows upcoming brithdays (I think I got it from @Moonbase59). Since 0.4.8 it gives me the following error ===
Dataview: Every row during operation 'where' failed with an error; first 3:
        - Operator '+' is not supported for 'null' and 'number

===
To Reproduce
This is the DV query being run...
## Upcoming birthDays
Here are the upcoming birthdays for the next 2 months (until =date(today) + dur(2 months)).
```dataview
TABLE birthDate as "DoB", choice(
date(today).month*100+date(today).day = birthDate.month*100+birthDate.day,(date(today)-birthDate).year,(date(today)-birthDate).year+1) as Age
FROM "People"
WHERE file.name != this.file.name and
choice(date(today).month*100+date(today).day > birthDate.month*100+birthDate.day,
(date(today).year+1)*10000 + birthDate.month*100 + birthDate.day,
date(today).year*10000 + birthDate.month*100 + birthDate.day) <= (date(today) + dur(2 months)).year*10000+(date(today) + dur(2 months)).month*100+(date(today) + dur(2 months)).day
SORT choice(
date(today).month*100+date(today).day > birthDate.month*100+birthDate.day,
(date(today).year+1)*10000 + birthDate.month*100 + birthDate.day,
date(today).year*10000 + birthDate.month*100 + birthDate.day)
```

Expected behavior
Until 0.4.8 this query ran as expected. I reverted from 0.4.9, and 0.4.10, back to 0.4.7, and all is again as expected.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 10
Obsidian Version 0.12.16 (installer 0.12.15)

What is the output if you run date(today) or dur(2 months) alone?

Not entirely sure what you are asking me to do, but I tried replacing all instances (4) of date(today) + dur(2 months) with only date(today) and dur(2 months) respectively. I got the same result as before for each iteration...
- Operator '+' is not supported for 'null' and 'number

Oh, I'm sorry, I just wanted to see the output of that literal code, rather than replacing things in your big query.
Basically, when looking at your code, the only time I see addition it's date(today) + (some number) or dur(2 months) + (some number). That likely means that date or dur are returning null and I was hoping to understand which one it was.

Very sorry, but I suspect I am being uncommonly dense. I ran this - `
date(today)

and got this...
Dataview: Error:
-- PARSING FAILED --------------------------------------------------

1 | date(today))
| ^
2 |

Expected:
query type ('TABLE', 'LIST', or 'TASK')
`

No, sorry, that's on me. When I'm at a computer later I'll take a look.

Interesting - I'll have to look at what changed between 0.4.7 and 0.4.8 that could cause this internally.

It seems pretty unlikely that the 0.4.7 -> 0.4.8 release itself caused issues - that was only 2 very minor fixes to code formatting and how dates are sorted.

Weird. I've tried exactly the same text in 0.4.7 and in a vanilla 0.4.10, and I still get the error messages

l'l try the exact query myself. Could be due to a strange interaction. Do you have a single "example page" I could use?

Here ya go..
Don Van Vliet.md
.

here ya go (take two)...
Don Van Vliet.md

I can reproduce this locally. It looks to me like date(today) doesn't have the month  property, for some reason. I don't know if this is true for year, day, or other properties.

It does have the month property - the issue is the lack of spaces in birthDate.month*100. birthDate.month * 100 with spaces works; this is apparently because * is considered an emoji/valid identifier.

Emoji support is the bane of my existence.

There are very complicated regexes I can use to hopefully eliminate these edge cases, though it will take a little bit of effort to set them up, so I will target this fix for 0.4.12, after the impending release.

putting a space around all * got it working with DV 0.4.10 for me. Many thanks!


Revert "GH-39628: [C++] Use -j1 for cmake >= 3.28"

Revert apache/arrow#39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

Should we use "MINOR: ..." or "GH-XXX: ..." format for this? Or is it OK with "git revert" format?

I think we can use both MINOR or the git revert format. This is not common and the changelog script will just ignore it. As we don't cherry-pick initially and we just branch from main when we create the maintenance branch it won't be an issue.

Ok, I added "MINOR". CI failures look unrelated.


Global tags

This adds the ability to set global tags on the transport that get sent with each log entry.

@adambiggs merged and published to npm. Thanks for the contribution!


[money-630] Replace larssiet font with skintype-text

Related: https://github.com/curology/curology-gatsby/pull/2432
Question:
I'm surprised that .yarn/ and yarn.lock aren't git ignored. Is that intentional? Should I be committing .yarn/?
Local Storybook, showing all font styles default to 'skintype-test' instead of 'larssiet'

Related PRs:

https://github.com/curology/PocketDerm/pull/21008
https://github.com/curology/curology-gatsby/pull/2432

@ZeMunchkin great callout, and yep, I'm on it! https://github.com/curology/PocketDerm/pull/21008


Receiving "Lint/Eval has the wrong namespace - should be Security" when rubocop is run

When I invoke the rubocop command using version 0.47.1, I sometimes get the following warning output
Lint/Eval has the wrong namespace - should be Security
Lint/Eval has the wrong namespace - should be Security
Lint/Eval has the wrong namespace - should be Security
Lint/Eval has the wrong namespace - should be Security

Unfortunately, it doesn't happen consistently.  I first saw the warning last night and I tried deleting a couple older versions of rubocop.  The problem went away.  Today, it started happening again.  I wiped out all versions of rubocop and reinstalled.  0.47.1 is the only one on my system and the warning is gone (for now).

Likely you have some references to Lint/Eval in your config or in RuboCop directives embedded in your code. The cop was renamed to Security/Eval recently.

Thank you.  I had some RuboCop directives referencing Lint/Eval.
Any idea why I don't see this warning consistently?  Here is the output I just received on two back-to-back rubocop runs:
vagrant@vagrant (foo) (master $) $ rubocop
Inspecting 314 files
..................................................................................................................................
/home/vagrant/Documents/dev/foo/lib/foo/host_autoload_paths.rb: Lint/Eval has the wrong namespace - should be Security
/home/vagrant/Documents/dev/foo/lib/fook/host_autoload_paths.rb: Lint/Eval has the wrong namespace - should be Security
........................................................................................................................................................................................
314 files inspected, no offenses detected

vagrant@vagrant (foo) (master $) $ rubocop
Inspecting 314 files
..........................................................................................................................................................................................................................................................................................................................
314 files inspected, no offenses detected

I understand RuboCop caches results to speed up analysis.  However, I would expect the Lint/Eval warnings to always display in the results.  If I run with rubocop --cache false, everything works as expected; I consistently get the Lint/Eval warnings in the results.


S3 HTML Template does not provide device specific warnings

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
S3 Action generates a HTML page from which a user can install the .ipa.  However it doesn't take into account what specific devices this .ipa supports.  For instance, if the app is iPad only and you open the page on a desktop, it says

Please open this page on your iPhone!

If you then open the page on your iPhone, it will let you attempt the install.  Unfortunately the system will allow this, and then fail the install with an generic warning instead of just telling the user the app is iPad only.
Configuration Files
Fastfile:
default_platform :ios

platform :ios do

  before_all do
    ensure_git_status_clean
  end

  def bump
    increment_build_number
    commit_version_bump
  end

  desc "Build and sign for enterprise (beta) release"
  lane :beta do

    bump

    # Build
    gym(
      scheme: "ro",
      output_name: "ro.ipa",
      configuration: "Enterprise",
      codesigning_identity: "iPhone Distribution: 303Software inc",
      provisioning_profile_path: "./fastlane/certs/RO_Enterprise.mobileprovision",
      use_legacy_build_api: true
    )

    # Deploy
    s3(
      access_key: ENV['S3_ACCESS_KEY'],               # Required from user.
      secret_access_key: ENV['S3_SECRET_ACCESS_KEY'], # Required from user.
      bucket: 's3.303apps.com/ro',                       # Required from user.
      ipa: 'build/ro.ipa',                             # Optional is you use `ipa` to build
      dsym: 'build/ro.app.dSYM.zip',                   # Optional is you use `ipa` to build
      upload_metadata: true,                          # Upload version.json, plist and HTML. Set to false to skip uploading of these files.
    )

  end
end

Environment
fastlane version (run fastlane -v):
fastlane 1.100.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
No

I propose (implemented in PR #5775) the following behavior.

When viewed from a desktop, the default HTML should tell you what type device you need to install on.
When viewing an iPad only app on an iPhone, you should not be able to install and the warning should tell you to Please open this page on your iPad!

PR merged.  Thanks @ohwutup


Allow custom authenticator

Fixes NETBEANS-61.
Allows a Platform user to install his own version of an Authenticator which may be more appropriate for the given application than the one provided by default by the Platform.
In no implementation of Authenticator is found in the Global Lookup then everything will work as before.

Can one of the admins verify this patch?

This is an API change (one can register Authenticator which wasn't possible). You should also change apichanges.xml and arch.xml files. The later one to describe the API - use <api group="lookup"....> tag, the first file to refer to description of the change. You should also increase the version number of the module and use it in apichanges.xml file. Please run ant javadoc and make sure your documentation looks acceptable.

On hold for now.

I think you can proceed now, when beta of 9.0 is out and most of the licensing issues are resolved.

I would like to stress that due to this issue https://issues.apache.org/jira/browse/NETBEANS-58, phansson's plugin's:
https://bitbucket.org/phansson/netbeansproxy2
https://bitbucket.org/phansson/netbeansnetworkauthenticator
it is highiest importance that those plugins should be part of the NB platform.

@jmborer, isn't that what this issue is about?

Are we ready to merge this or do we need more discussion?

@geertjanw: yes it is, but it seems incomplete. As far as I understand, it just allows the installation of a custom Authenticator, but when I requested the integration of phansson plugins,  my query was motivated by the fact that the plugins also include advanced proxy PAC support and provide an implementation of an Authenticator that handles much better SPNEGO as the default NBAuhthenticator.

I am very interested for integration of netbeansproxy2 because I have since a couple of yeas I run into problems with my platform applications running in the windows worls of some universities. Suddenly an authentification window opens but authentification does nor work. In some case I cauld find the origin of the problem in bugs in the proxies but this bug only affects my nb platform apps so they dont wont to fix it and I have to workaound it. Using the netbeansproxy2 solves this problem. So it would be really great if this can be integrated.

Is the original author still working on this?

Am Freitag, 21. September 2018, 22:10:55 CEST
schrieb darkyellow:

Is the original author still working on this?
I don't know:-(

@phansson what needs to get it done? Any big issues?

@phansson can you be so kind pleaes and fix what @emilianbold requested? Otherwise we should close it, maybe.

I was mostly commenting on top of it back then. Nothing from what I've said was a hard -1 so to speak. Please carry on.

Any plans to finish this pull request? If so, feel free to reopen.


Correction for raw affiliation School of Computing Science Simon Fraser University

Correction needed for raw affiliation School of Computing Science Simon Fraser University
raw_affiliation_name: School of Computing Science Simon Fraser University
new_rors: 0213rcc28
previous_rors:
works_examples: W4386093908
contact: e276100a8073ef876ae7152fa61875ac:67570439 @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


AssertionError

您好，请问这个错误是什么原因呢？感谢感谢！
Traceback (most recent call last):
File "drive/GoogleAI/CRNN_Tensorflow-master/tools/demo_shadownet.py", line 107, in
recognize(image_path=args.image_path, weights_path=args.weights_path)
File "drive/GoogleAI/CRNN_Tensorflow-master/tools/demo_shadownet.py", line 68, in recognize
decoder = data_utils.TextFeatureIO()
File "drive/GoogleAI/CRNN_Tensorflow-master/local_utils/data_utils.py", line 240, in init
self.__writer = TextFeatureWriter()
File "drive/GoogleAI/CRNN_Tensorflow-master/local_utils/data_utils.py", line 161, in init
super(TextFeatureWriter, self).init()
File "drive/GoogleAI/CRNN_Tensorflow-master/local_utils/data_utils.py", line 26, in init
self.__char_list = establish_char_dict.CharDictBuilder.read_char_dict(char_dict_path)
File "drive/GoogleAI/CRNN_Tensorflow-master/local_utils/establish_char_dict.py", line 59, in read_char_dict
assert ops.exists(dict_path)
AssertionError

@wwxjtu 你可能没有获取到字典文件


⚠ Bofrost.at has degraded performance

In 3bd0b62, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2432 ms

Resolved: Bofrost.at performance has improved in 5a780c5 after 6 minutes.


Pipeline module

At the moment we have separate methods in workers and tasks - slight refactor to organize all of these into opennem.pipelines
Batch process tasks per-network and on an interval basis
Raise exceptions that are quashed on no new data

we now have opennem.pipelines for processing - we'll add to this over time to better organize the code


[WIP] Add ability to toggle sidebar

[x] Show sidebar or not depending on the screen width
[x] Allow to show sidebar using hamburger
[x] Allow to hide sidebar on large screens using hamburger
[x] Allo to hide sidebar on small screens by clickaway
[ ] on small screens, hide sidebar after menu click

Closes #258

Thank you for doing this It will save me hacking away with drawer.
Also per another item (the iframe support issue. ) Here is a picture with the app supporting three.js multiple iframes.     I also have it working with google maps and a couple of other components.

I'm abandoning material-ui's <Drawer> component, as it's ultra hard to make work as I want (read: not fixed). Falling back to <Paper> in another PR.


Add csstype, fix CSSProperties

Fixes #142
Additional:
Adds support for style:* and class:*, which allows you to do this

NOTE csstype is marked as a peer dependency. Solid must install this as a dependency (not dev dependency).

Can we not do the additional for now? Those fields need to still be reviewed from a runtime perspective.

Can we not do the additional for now? Those fields need to still be reviewed from a runtime perspective.

Sure. I've commented it out for now in case we want to include these set of features in the future. We can remove it anytime once we've decided.


Update lot singular and plural

https://trello.com/c/T70XvJ70/437-update-save-and-return-to-lab-summary
N.B. This uses a branch commit of digitalmarketplace-utils to update the stubs. Once this is approved I will do a release with that change. See sister PR: https://github.com/alphagov/digitalmarketplace-utils/pull/575

I don't think utils needs to be updated for this PR, looking at the test you've changed the lots are derived from an actual database rather than from the stubs, and the stubs that are used are from dmtestutils rather than dmutils.

@lfdebrux you were right! I've forced pushed now without those other changes.

Woops, sorry I accidentally clicked merge 😅


New models of dataset to use

Hey all, I'm currently running finetuning with the original dataset provided in the example.
Unfortunately the basic two options which are "Input" and "output" limit the amount of trainable parameters
Is it possible to use other models of dataset or will that be released soon ?
Thanks

Hi @mums77,
It is LoRa feature, it helps fitting big model to your GPU.
If you want try to finetune full model, use
BaseModel.create("llama_int8")

Hey @StochasticRomanAgeev  thanks for the anwser
I think I was not clear sorry, I understand that there is many different models that can be used and I appreciate that.
My concern was more about the finetuning with the dataset, for instance I want to build a prompt answering language model with one of the model but as I understand there is only the huggingface dataset model that is supported for now.
Unfortunately this dataset is quite limitating as there is only a "Input" and "output" in the dataset. That doesn't make my model really smart as it can roughly answers only the question i've added to the dataset
I was wondering if there is or there will be other dataset type that will be added later ?
As an example another project on github is using the model : "Question" , "assistant hypothetical answer" , "Agent Reflection" , "Assistant final answer" to train the model
That gives nice result as there is in a simple question many different aspect that are covered
Thanks foe the answer
/M

Hi again, @mums77
Out dataset supports prompt templates, but probably you can gust put entire prompt in input column, it is the easy way.


Added missing Linux header (sys/uio.h)

<sys/uio.h> is required under at least with Ubuntu 18.04 as it declares "writev"

Thanks a lot for your contribution.


Allowing --no-build flag during skyux e2e

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #262   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          58     58
  Lines        1340   1347    +7
  Branches      197    199    +2
=====================================
+ Hits         1340   1347    +7

Flag
Coverage Δ

#builder
100% <100%> (ø)
:arrow_up:

#runtime
100% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

cli/e2e.js
100% <100%> (ø)
:arrow_up:

utils/host-utils.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce68a2...87cd395. Read the comment docs.

Great feedback @Blackbaud-SteveBrush.  Should be addressed in latest.  I haven't seen rampant fs errors, but I did add a check to verify the file exists before trying to read.


Allow character count components to be decorated

The character count is essentially a textarea and takes the same parameters for its input field.

Don't need to remove the indenting in templates as {%- takes care of removing leading white space.

Don't need to remove the indenting in templates as {%- takes care of removing leading white space.

Sure, but {%- macro shouldn't be indented anyway, as it's not a child of the import statement.

Ah, you’re right. Ignore me!


Update integration tests

Update integrations tests to use the new-ish Noetic containers, updated/cleaned up docs accordingly and also reduced the steps required to attach/detach a tool.
What type of change is this?

[x] Bug fix in a backwards-compatible manner.
[ ] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[x] Other (e.g. doc update, configuration, etc)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[x] I ran all tests on my computer and it's all green (i.e. invoke test).
[x] I ran lint on my computer and there are no errors (i.e. invoke lint).
[ ] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary documentation (if appropriate)

I branched off of some-refactoring branch, so, once that is merged, this will be based on main and only then, the tests will run on github.


lightbox jQuery 3.1.0 bug

Recently I found bug when using jQuery 3.1.0. Lightbox takes max width and scale up to specyfic image width in modal window. With 3.1.0 jQuery your lightbox don't add that style settings to the modal-dialog.
jQuery 2.2.4

jQuery 3.1.0

Can't we just use  return image.on('load', function() { .. }); ?

Can you grab the latest files from /dist in this branch. This is a complete re-write, please take note of the new documentation.
https://github.com/ashleydw/lightbox/tree/v4_0_1_jquery3_bootstrap4
Two breaking changes (in readme):

navigate_left and navigate_right functions are camelCased
gallery_parent_selector has been deprecated - document.body is default

continue this in #166

@lbausch This bug is still present in 4.0.2 - would you consider a maintenance branch for the 4.x version and accept a pull request replacing .load( with .on('load', where appropriate?

@adjohnson916 I'm not a maintainer of this project.

@adjohnson916  There's no .load() call in version 4. As you can see on the docs page, the style settings are applied http://ashleydw.github.io/lightbox/

anyone is welcome to make a 4.0.3 to fix the load bug


Max and min allowed dates support

This pull request add possibility to specify min and max allowed dates (including also time) for selection using options or setters.

Thanks for the contribution!
I'm short on reviewing time at the moment. To help me get started quickly can you describe the change in more detail - what exactly do the startDate and stopDate options do? How can I check they are working correctly?
Can you add some test cases? Test coverage is low at the moment but I would like to raise it, starting with new features like this.
Thanks!

Hello. Sorry for such short description.
These options deny users to select date earlier than startDate and later than stopDate. So if you specify these options, all UI controls (day, hour and minute pickers) which allow to select date not from specified interval will be disabled. You can set only one of the options. Setters are implemented for on-the-fly timepicker updates, for example if a user is denied to select a time greater than current but timepicker stays opened for a few minutes, stopDate can be updated to allow next five minutes or new hour selection and UI will be also updated.
Regarding tests, I'll try to write them (I've never done it before :) ), but I can't promise that since I'm currently busy.


data verification tool

Verify whether the collected data meets the requirement of localization map making. @anyong298 @deidaraho

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yuanyijun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@ooooooops please sign the CLA

please check why TeamCity build failed.

The ticket has not been updated for a while. It's being closed. Please submit a new one.


Different calculations between prod/site and github/dev

Required Information
Class: Leatherworker
Level: 53
Craftsmanship: 379
Control: 351
CP: 341
Recipe Name: Wyvern Leather
Recipe Level: 52
Solver Seed: n/a
Expected Behaviour
Basic Synthesis progress is 100.
Actual Behaviour
On https://ffxiv.lokyst.net/#/simulator, the calculation is correct. (and matches what is seen in game) If I run the app locally from the master branch, the output is 95.
Steps To Reproduce

Run app locally (I used Dockerfile.dev, although it required some changes to get working, look forward to a future pr)
Set stats correctly.
Go to 'edit' in the simulator, select 'basic synthesis'.
Compare with the same actions in prod.

Notes
I'm working on a CLI-based tool using your code, for just doing basic 'how many CS2s do I need to leave room for'-type calculations. My calculations kept being off, so I decided to run a local version of your site and add logging output. However, it turns out my local version matches my manual calculations! Have you made un-submitted updates to the effective level table, possibly?

The ffxiv.lokyst.net site is rather out of date. The ffxiv-beta.lokyst.net site is up-to-date with the contents of the master branch. However, it has a variety of changes for newer versions of the game that may have affected accuracy.

@ermad FYI

Thanks for the info. I just checked on http://ffxiv-beta.lokyst.net/, and I get the same (correct, matches actual observed values in-game) numbers there that I do at http://ffxiv.lokyst.net/

Phew! :)
The beta site is definitely up to date with master, so I'd guess the source of the discrepancy lies in the way your CLI tool is integrating with our code. Is your project source published somewhere?

I'm not actually integrating with your code, I did a fresh implementation based on it. The source isn't posted anywhere yet, no.
Again, though, the weird thing / the bug I'm trying to report is that if I run your site from master, unmodified, on my own box, I get different numbers. (and those numbers match the calculations my code is producing, but the two are not talking to each other at all!)
Screenshot attached for elucidation. Note the URL (my local network) and the incorrect progress value (same operation on the real site shows 100)

Interesting... I'll see if I can reproduce it.

This fails for other recipes too: I tried it with my goldsmith, ffxiv-beta reports 182, locally running instance reports 173, actual progress in game is 183. (ffxiv-beta is still off-by-1, but I see another bug already open relating to that, so no big deal there)

So, for your original setup I get 95 progress on both a local version of the site and on ffxiv-beta.lokyst.net but 100 on ffxiv.lokyst.net. If you've used ffxiv-beta.lokyst.net in the past, could you try force-reloading the page? There might be a cached file which is causing it to use old calculations. I've just double-checked that there are no file differences between what's on master and what's on the beta site.

For reference, the production branch is what's deployed on ffxiv.lokyst.net. It's about 9 months old at this point. There have been changes in the effect of level difference for crafters below a certain level.

It boils down to the base progress formula for crafters above level 50.
The "production" site uses:
baseProgress = 1.834712812e-5 * craftsmanship * craftsmanship + 1.904074773e-1 * craftsmanship + 1.544103837;

The "beta" site uses:
baseProgress = 1.834712812e-5 * craftsmanship * craftsmanship + 1.904074773e-1 * craftsmanship + 1.544103837;

There are some minor differences in the level correction factor but that only results in a ~0.25 variance.
@Ermad Have you been able to get any further with your research into an updated formula?

Yeah, I noticed the polynomial in use for > 50 crafters in the code.
And after force-refreshing I see 95 on ffxiv-beta, which lines up with what I expect the code to do. Whew.
FWIW, 100 is the "correct" answer in-game for that craft and those stats, so the beta site is wrong for this particular recipe/stat combo. (and several others that I've been inputting throughout the day, all for crafter levels between 53 and 55)
Thanks for explaining what's deployed where, that's helpful for making sense of all this!

The main problem is a lack of data and free time. Neither myself nor lokyst have played FFXIV in years, so we can't collect data of our own. We have to rely on submissions to update the formulae. @Ermad has helped a lot in this regard but has focused mainly on >60. It's possible that we need to introduce another "tier" of formulas to separate 50-60 from 60-70. But without the ability to verify it, I can't really do anything about it.

The main issue in cases like this, is that I only have level 70 crafters. So for issues that only affects lower level crafters I rely on user submitted reports and data.
In this particular case, it does seem like it should be using the original HW base progress formula. When I was doing to the initial implementaion of the Stormblood changes, it seemed like the new Stormblood progress matched for it. There was probably another bug at the time that masked it that has since been fixed.

Ermad's changes have been deployed. You may have to clear your browser cache.


Add files via upload

Please have a look to my college
College offical website : http://www.santhigiricollege.com/

@AlanBinu007 Pull request merged. Thank you!


Windows Terminal Preview is not recognized by Files

Describe the bug
Basically, Files doesn't recognize WT Preview. You may try to manyally add it to the terminal.json file but it gets removed on startup. Even changing the title from "Windows Terminal" to "Windows Terminal Preview" still makes Files remove that JSON object all together.
To Reproduce
Steps to reproduce the behavior:

Go to Settings > Preferences
Edit the file to add Windows Terminal Preview
Go back to Settings > Preferences after a restart of the app
See that the entry you added is deleted and not there.

Expected behavior
The expected behavior is that my entry for Windows Terminal Preview would continue to be there after a restart.
Desktop:

OS Version: Windows 10 1909 18363.1082
App version: v<IP_ADDRESS>

Additional context
The workaround I have found for this is to change the command for the Windows Terminal JSON object from wt.exe to just wt.
EDIT:
For Clarity, this bug is only present when ONLY Windows Terminal Preview is installed and not also the Stable version.

Windows Terminal Preview is not intended to be detected by Files, have you tried using the sample profile for Windows Terminal Preview?

No I haven't tried using the sample profile for Windows Terminal Preview.. I actually can't see it on the wiki...

@brukberhane The profile for Windows Terminal Preview is the same Windows Terminal profile. See this doc for more information.

@yaichenbaum I am aware that they share the same CLI yet the option to select windows terminal instead of say powershell on files doesn't pop up and when you add teh profile to terminal.json manually, it deletes it on startup. Except when I did the workaroudn I mentioned

You shouldn't need to change the profile, if you change the wt argument in the Windows 10 settings app to point to the Preview then Files will automatically launch the Preview version.

I had changed the wt argument to point to the Preview... but it just wouldn't show up in the list of terminals

The list of terminals won't change, the apps basically runs the wt command to launch the app connected to that argument.

That looks correct, what happens when you try launching Terminal from the right click context menu?

@yaichenbaum

But when I place a new profile in there called "Windows Terminal Preview" and then replace the path wt.exe with just wt. It doesn't get deleted on startup

Can you try adding this profile?
{
      "name": "Windows Terminal",
      "path": "wt.exe",
      "arguments": "-d .",
      "icon": ""
 }

Before restarting files after adding your config:

After:

At this point, I feel that it should be worth mentioning that I ONLY have Windows Terminal Preview Installed.

try and not using preview and the official version

@Atlasim1 Is it possilble to install the official version alongside the preview?

@brukberhane - if you are asking if you can install both Terminal and Terminal Preview on the same PC, then the answer is absolutely yet. These are two different packages and appear separately both in Windows Store and chocolatey.

@Don-Vito I'm sorry if I didn't put this succinctly. What I mean is that if ONLY Windows Terminal Preview is installed, then Files doesn't automatically add the "Windows Terminal" option into the "open with terminal" options. Even if I were to manually add it into the .json file, My entry gets removed.

@Don-Vito I'm sorry if I didn't put this succinctly. What I mean is that if ONLY Windows Terminal Preview is installed, then Files doesn't automatically add the "Windows Terminal" option into the "open with terminal" options. Even if I were to manually add it into the .json file, My entry gets removed.

@brukberhane - actually you explained it quite well in the first time :blush: There is an issue that definitely requires a fix (I guess I understand the root cause of it but not sure how to fix it yet).
I tried to answer your last question, about installing preview and non-preview alongside. Probably I misread it.
But if such temporary workaround applicable in your case, you can install both Terminal and Terminal Preview on your system but use non-preview with Files.

@brukberhane This issue should be resolved with #2764.


Address risk of ingesting TTY NA as NaN in Pandas code

Possibly Simply add parameters to CSV reads:
df = pd.read_csv(file_, dtype=object, na_filter = False)
See other suggestions at: https://stackoverflow.com/questions/33952142/prevent-pandas-from-interpreting-na-as-nan-in-a-string

I found the na_filter = False method to work nicely as well.
For what it's worth, I first  tried casting the :TYPE column to string, but it did NOT work.
dtype_dic= {':TYPE':str} pd.read_csv(file, dtype = dtype_dic)

@computationdoc is this still an issue? I have not encountered it. Then again, I wasn't looking for it.


Wrong size in annotations

Hi,
This doesn't raise any issue but I was wondering why even if the size of the pictures and/or laneseg_label is 1640x590, some of the annotations coordonates goes higher than 1640 ? For example in Dataset CULane/dataset/driver_23_30frame/05151640_0419.MP4/00000.lines, 3rd line, first coordonate :
1660.47 470.
Is it because the lines were interpolated ?
Thank you !

@lmameri Yes, it is caused by spline fitting, and should not matter much.


Make cache timeout values configurable

Idea spawned from https://github.com/Chatterino/api/pull/409#issuecomment-1378603767

I took a look at how to implement this the best way. Since there re a good amount of different caches (>10), individual config entries for each timeout value would bloat the config quiet a bit.
A possible solution is to use a map:
cache-timeouts:
   youtube: 24h
   twitter: 10m

This is nice in the config.yml in my opinion, but as far as I can see viper does not support maps in command-line flags.
The cache value could as a result only be set via the config.yml.
Not sure which of the two would be the best option, suggestions appreciated!

We already don't use maps where we could, so I think it makes sense to just add long keys here too
atm we have youtube-api-key, we'd want to add something like youtube-video-cache-duration and youtube-profile-cache-duration, for twitter we'd add twitter-profile-cache-duration and twitter-tweet-cache-duration.
I'm flexible with the naming


chore: automerge

Artifact can be viewed here: :
https://3277-62313804-gh.circle-artifacts.com/0/sandbox/mdbook/book/index.html

Artifact can be viewed here: :
https://3278-62313804-gh.circle-artifacts.com/0/packages/style/storybook-static/index.html

Artifact can be viewed here: :
https://3278-62313804-gh.circle-artifacts.com/0/sandbox/sapper/__sapper__/export/index.html

Artifact can be viewed here: :
https://3278-62313804-gh.circle-artifacts.com/0/sandbox/vuepress/docs/.vuepress/dist/index.html


Make it responsive

you can make it responsive
plus add button for the movement and
dont delete anything just comment it down
#goodfirstissue
#firstcommit
make it playable on mobile by making it responsive
plus add buttons for the movement

Hi Best of Luck

Assign me please.

ok, so
first of all you can add buttons in it using javascript so that we can play is using buttons instead of touchpad
and after that you can make it responsive so that we can play the game in mobile as well
apart from that if background doesnot suits you can change it according to the responsive window i mean new bg for small screen
alright
best of luck

ok, so first of all you can add buttons in it using javascript so that we can play is using buttons instead of touchpad and after that you can make it responsive so that we can play the game in mobile as well apart from that if background doesnot suits you can change it according to the responsive window i mean new bg for small screen alright best of luck

Ok, It will be done by this week, please assign me to the issue


TypeError: Passing a set as an indexer is not supported. Use a list instead.

In files:
File "/Users/a3kaur/Downloads/CTA_new-main-2/src/Common/Objects/Samples.py", line 297, in ApplyDocumentCutoff
    document_topic_prob_df.loc[unknown_list, "unknown"] = 1.0
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pandas/core/indexing.py", line 875, in setitem
check_dict_or_set_indexers(key)
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pandas/core/indexing.py", line 2687, in check_dict_or_set_indexers

Tried Link: https://stackoverflow.com/questions/72583625/futurewarning-passing-a-set-as-an-indexer-is-deprecated-and-will-raise-in-a-fut

`      unknown_list = list(set(self._tokensets) - document_set)
unknown_df = document_topic_prob_df[document_topic_prob_df.index.isin(unknown_list)]
unknown_series = unknown_df.max(axis=1).sort_values()
new_unknown_list = list(unknown_series.index.values)
    document_topic_prob_df["unknown"] = 0.0
    document_topic_prob_df.loc[unknown_list, "unknown"] = 1.0
    self.document_topic_prob = document_topic_prob_df.to_dict(orient='index')`

Line 301 in "/Users/a3kaur/Downloads/CTA_new-main-2/src/Common/Objects/Samples.py"


fix bug: getStartStatesTaskCount always return none StartStates task count

Pull Request Test Coverage Report for Build 433

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.954%

Totals

Change from base Build 422:
0.0%

Covered Lines:
438

Relevant Lines:
635

💛  - Coveralls

Pull Request Test Coverage Report for Build 433

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.954%

Totals

Change from base Build 422:
0.0%

Covered Lines:
438

Relevant Lines:
635

💛  - Coveralls


New version: SimpleSDMLayers v0.9.6

Registering package: SimpleSDMLayers
Repository: https://github.com/PoisotLab/SpeciesDistributionToolkit.jl
Created by: @tpoisot
Version: v0.9.6
Commit: 473300d32e39402457f0e3815464be93c25cb54c
Reviewed by: @tpoisot
Reference: https://github.com/PoisotLab/SpeciesDistributionToolkit.jl/commit/473300d32e39402457f0e3815464be93c25cb54c#commitcomment-130003198
Description: Work with species distributions in Julia

This should be closed in favor of #93420 (I thought the registrator would update this PR, sorry)


Dev

Hello @LMByrne! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file bot/disco/core.py:

Line 420:26: E128 continuation line under-indented for visual indent

In the file bot/disco/fm.py:

Line 154:80: E501 line too long (80 > 79 characters)

In the file bot/disco/superuser.py:

Line 390:80: E501 line too long (100 > 79 characters)
Line 412:80: E501 line too long (80 > 79 characters)
Line 426:80: E501 line too long (95 > 79 characters)


Problems with auth facade

Latest version, level 5, default configuration
Upon running, all occurrences of Auth::user()->something are reported. In the files I simply added use Auth as import;
An example:
Access to an undefined property Illuminate\Contracts\Auth\Authenticatable::$username
Access to an undefined property Illuminate\Contracts\Auth\Authenticatable::$id

Can you try to import the facade with use Illuminate\Support\Facades\Auth?

yes seems to work thanks


Avoid using execSync or execFileSync

As options we can:

use the existing executeProcess helper under utils or
implement a new helper based on execFile & promisify

@getlarge I added this one based on our yesterdays chat. If I miss something feel free to directly change the issue.


WIP refactor: recipes > commands

The main goal of this PR is to deprecate recipes and migrates the popular recipes into commands, a new alternative to recipes.
See Test Plan on how to enable it for testing.

Note: The Custom Commands feature is still in the exploring stage and has not been finalized. Use at your own risk.

This PR includes:

3 new default commands created with a JSON file:

Document Code
Explain Code
Generate Unit Tests

Added e2e test for Custom Commands
renamed the my-cody directory to custom-prompts
rename custom recipes to custom commands
refactored custom recipes files and removed unused methods to custom commands
renamed and clean up methods for custom commands
remove redundant debug output from LocalAppDetector
new command menu in command palette, with item to start inline chat

command menu can be invoked from icon in doc context menu, or shortcut cmd + shift + v

new custom commands config menu for managing custom commands config files

added code lenses for Cody that trigger the new command menu in text files

New slash commands panel invokable from chat box:

Moved cody items up in context menu

New cleaner UI with Recipes tab removed

Test plan

added e2e test for custom commands and updated current tests to work with new default commands

@toolmantim i still need to fix the tests and update the PR description, but other than that, can you check if the rest of the build looks good to you? I've removed the Recipes tab and all the old recipes, and replaced the recipes actions with commands.

@abeatrix I just pushed up some copy cleanups, but there'e still lots that isn't working for me (like executing and commands doesn't seem to do anything… and the "New Custom Command…" doesn't seem to trigger the multi-step quickpick like it used to) 🤔 Let's sync to go through it together?

@toolmantim i just pushed some updates so that you won't need to set the feature flag to get those to work. I've also finished with the clean up and updated the PR so it's good to test! Happy to sync up later if you want.

It took a lot of fighting, but I got it looking pretty good across all themes, including high contrast! I also added a proper focus outline to the input too.
https://github.com/sourcegraph/cody/assets/153/0cec9572-7206-4540-b1f3-574d969a2a99
A few outstanding things I couldn't fix @Beatrix:

The items are still in reverse alphabetical order (Z-A) but should be A-Z
I feel like escape should clear the input, making it feel as fast as the standard quickpick. It's a bit odd for a textarea but I think it makes more sense.
The command chooser should disappear when the input loses focus (and reappear when it does, if the input has a slash command in it). A few times I've accidentally deleted code in the editor mis-understanding the focus/cursor.


Support JSON in sort

won't do bc what if the joined relation is not projected as required for this?


Update unit-test-basics.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/test/unit-test-basics.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mzmgh : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.


Incorrect calculation of bags total sum of the order

The total sum of the order does not include possible added bags and limits

@urio999 Please add steps to reproduce and environment


Change warning location of SafeMode

Summary
Related https://github.com/rubocop-hq/rubocop/pull/7249.
In #7249, the following deprecation  warning is displayed for all operations of rubocop command.
% bundle exec rubocop -v
The `SafeMode` option will be removed in `RuboCop` 0.76. Please update
`rubocop-performance` to 1.5.0 or higher.
0.74.0

I noticed that with the ConfigObsolete module, RuboCop can only show the warning when using SafeMode.
% cat .rubocop.yml
require: rubocop-performance

Performance/Count:
  SafeMode: false

% bundle exec rubocop
Error: obsolete parameter SafeMode (for Performance/Count) found in .rubocop.yml
`SafeMode` has been removed. Use `SafeAutoCorrect` instead.

OTOH, RuboCop Performance happens the following error when SafeMode module will removed:
NameError:
 uninitialized constant RuboCop::Cop::Performance::Count::SafeMode

Therefore, the following milestones were planned. This plan does not remove SafeMode module immediately.

RuboCop 0.75 ... Presents an alternative API via ConfigObsolete module
RuboCop 0.76 ... Remove SafeMode

This is probably a better way, as it is best to offer an alternative API in the 3rd party module.
Other Information
Metrics/ClassLength cop excludes config_obsoletion.rb by .rubocop.yaml because most of the code in ConfigObsoletion module are configuration codes.
% bundle exec rake internal_investigation

(snip)

Offenses:

lib/rubocop/config_obsoletion.rb:5:3: C: Metrics/ClassLength: Class has
too many lines. [185/182]
  class ConfigObsoletion ...
    ^^^^^^^^^^^^^^^^^^^^^^

1101 files inspected, 1 offense detected
RuboCop failed!

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

rubocop-performance 1.5 was not released yet, so now this commit is showing a warning that can't be fixed. @koic can you release it?
Warning: Performance/Count does not support SafeAutoCorrect parameter.

Supported parameters are:

  - SafeMode
  - Enabled

Warning: Performance/Detect does not support SafeAutoCorrect parameter.

Supported parameters are:

  - SafeMode
  - Enabled

@rafaelfranca RuboCop 1.5.0 has been released. Thanks for the mention!
https://rubygems.org/gems/rubocop-performance/versions/1.5.0


add go 1.18 to tests

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[v] Other (please describe): add go 1.18 to test matrix

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #188 (8be0208) into master (3f1b8be) will decrease coverage by 20.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #188       +/-   ##
===========================================
- Coverage   58.35%   37.41%   -20.94%
===========================================
  Files         131      130        -1
  Lines       15367    15300       -67
===========================================
- Hits         8967     5725     -3242
- Misses       5816     9089     +3273
+ Partials      584      486       -98

Flag
Coverage Δ

1.14.x
?

1.15.x
28.58% <ø> (ø)

1.16.x
28.58% <ø> (ø)

1.17.x
37.41% <ø> (-20.94%)
:arrow_down:

connection
?

discovery
?

e2e
20.64% <ø> (-28.18%)
:arrow_down:

integration
20.64% <ø> (-28.18%)
:arrow_down:

macOS-latest
?

ratelimiter
16.86% <ø> (ø)

scripting
17.41% <ø> (ø)

table
?

ubuntu-latest
37.41% <ø> (-20.94%)
:arrow_down:

unit
28.58% <ø> (ø)

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/resolver/resolver.go
0.00% <0.00%> (-100.00%)
:arrow_down:

with.go
0.00% <0.00%> (-88.47%)
:arrow_down:

internal/repeater/repeat.go
0.00% <0.00%> (-80.00%)
:arrow_down:

internal/deadline/context.go
0.00% <0.00%> (-80.00%)
:arrow_down:

scheme/config/config.go
12.50% <0.00%> (-79.17%)
:arrow_down:

log/table.go
0.65% <0.00%> (-77.69%)
:arrow_down:

internal/table/statement.go
0.00% <0.00%> (-75.00%)
:arrow_down:

internal/cluster/context.go
28.57% <0.00%> (-71.43%)
:arrow_down:

internal/balancer/list/list.go
0.00% <0.00%> (-70.84%)
:arrow_down:

table/table.go
8.82% <0.00%> (-68.63%)
:arrow_down:

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1b8be...8be0208. Read the comment docs.


Performance testing with extended FILE data

Discussed Google Doc  contents with John Milnes and Bill.  Aware of possible degradation of write performance as the database grows, but ready to move on with deployment.


PERF-#4851: Compute dtypes for binary operations that can only return bool type

Signed-off-by: Myachev<EMAIL_ADDRESS>
What do these changes do?

[x] commit message follows format outlined here
[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #4851
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date
[x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

I did some tracing, and it seems that the dtypes argument is largely ignored by these codepaths? It only seems to be used when broadcast is set to True for the algebra operator, but none of these functions (le, gt,...) set broadcast to True, and it defaults to False. Additionally, shouldn't we add dtypes as a named, necessary kwarg for base's binary_op as well?

Well, the changes now mostly cover cases where the right operand is not a Modin object, like just comparing with a scalar. https://github.com/modin-project/modin/blob/b0465fa4425247e7949881e93866c6b85bb10a1d/modin/core/dataframe/algebra/binary.py#L104
Yes, we should, I already opened the issue for that: https://github.com/modin-project/modin/issues/4856

@RehanSD @vnlitvinov ready to merge if there is no concerns

Well, the changes now mostly cover cases where the right operand is not a Modin object, like just comparing with a scalar.

This bit of the information seems very important to understand what's going on.
I would rather you put it at least to the opening message of this PR.


Increment version for LCA

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/84653
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.2 -m "<description of version>" 49cab78ab3ded41c9f8eb78d53eb284dd8a4ec17
git push origin v0.3.2


Reflect Actions API changes in types

Pretty easy.
Only the format stuff is weird but Prettier hold all the truth, right ?

LGTM

@Swizz Is there any way to split up MyAction type so that is more readable? I don't mean the format. 🤔

By splitting you mean using side types ?
type Reducer<State> = (state: State) => ActionResult<State>
type Effect<State, Actions> = (
  state: State
) => (actions: Actions) => ActionResult<State>

export type MyAction<State, Actions> = (
  data: any
) => ActionResult<State> | Reducer<State> | Effect<State, Actions>

But "Reducer" is a wrong name as an effect could do not use Actions :thinking:
type NeedActions<State, Actions> = (actions: Actions) => ActionResult<State>
type NeedState<State, Actions> = (
  state: State
) => ActionResult<State> | NeedActions<State, Actions>

export type MyAction<State, Actions> = (
  data: any
) => ActionResult<State> | NeedState<State, Actions>

Just a bunch of things helping you to think more a bout what you are requesting.
Both way, using the following state will have the right type assertions ! :tada:
app<State, Actions>({
  state: {
    value: 0
  },
  actions: {
    addNumber(num: number) {
      return state => ({ value: state.value + num })
    }
  }
})

@Swizz Yes, something like that. It would help with readability IMO.

Which one to use ?

@Swizz The one that says Reducer and Effects is what I meant. Is that the good one?


Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
submitting second assignment
What did you learn from the changes you have made?
reviewed material on numpy.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no other approach
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I don't understand the point of having different csv files for this assignment if we are using only the first time,
unless the rest are gonna be used in future assignments
How were these changes tested?
tested by running the blocks, by checking the third file (all_paths[2]), detect_problems function returns True which by looking at the file, on the last row, a faulty set of data for a patient with all zeros as values can be seen, proving the validity of the function
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

@pedram-aliniaye-asli Hi Pedram, thanks for the feedback.
I added some comments and also checked the code to see why it produces 'True' for the last part. I didn't change anything but by running all blocks again It produced 'False' as expected. so my guess is The 'True' that was seen below it, had to be produced before making the final edition before I submitted it. I mean I probably, before submission, had 'True' as the result, fixed the code but didn't run it to display the corrected output which is 'False'. But I don't know if the outputs of blocks are saved inside the notebooks or not.


Unable to resolve artifact when dag/tasks includes withItems parameter

Is this a BUG REPORT or FEATURE REQUEST?:
Not sure, I guess this is a bug
What happened:
I use a DAG template with two tasks, one task with withItems parameter and outputs text to artifact, and second one use this artifact as input. However, the second task is failed with error
 Unable to resolve: {{tasks.generate-artifact.outputs.artifacts.hello-art}}.
I also use a globalName in artifact, in this case the second task gets not content.
Here's my yaml file:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: artifact-passing-
spec:
  entrypoint: artifact-example
  templates:
  - name: artifact-example
    parallelism: 4
    dag:
      tasks:
      - name: generate-artifact
        template: whalesay
        arguments:
          parameters:
          - name: message
            value: "{{item}}"
        withItems: [0,1,2]

      - name: consume-artifact
        dependencies: [generate-artifact]
        template: print-message
        arguments:
          artifacts:
          - name: message
            #from: "{{tasks.generate-artifact.outputs.artifacts.hello-art}}"
            from: "{{workflow.outputs.artifacts.my-global-art}}"

  - name: whalesay
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay:latest
      command: [bash, -c]
      args: ["sleep 1; if [ {{inputs.parameters.message}} == '0' ]; then cowsay hello world | tee /tmp/hello_world.txt; fi"]
      #args: ["sleep 1; cowsay hello world {{inputs.parameters.message}}| tee /tmp/hello_world.txt"]
    outputs:
      artifacts:
      - name: hello-art
        path: /tmp/hello_world.txt
        optional: true
        globalName: my-global-art

  - name: print-message
    inputs:
      artifacts:
      - name: message
        path: /tmp/message
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["cat /tmp/message"]

What you expected to happen:
The next task can read the artifact from previous task's output artifact
How to reproduce it (as minimally and precisely as possible):
Run the yaml file
Anything else we need to know?:
Environment:

Argo version:

2.3.0

Kubernetes version :

clientVersion:
  buildDate: "2019-08-05T16:54:35Z"
  compiler: gc
  gitCommit: f6278300bebbb750328ac16ee6dd3aa7d3549568
  gitTreeState: clean
  gitVersion: v1.15.2
  goVersion: go1.12.7
  major: "1"
  minor: "15"
  platform: darwin/amd64
serverVersion:
  buildDate: "2019-08-05T09:15:22Z"
  compiler: gc
  gitCommit: f6278300bebbb750328ac16ee6dd3aa7d3549568
  gitTreeState: clean
  gitVersion: v1.15.2
  goVersion: go1.12.5
  major: "1"
  minor: "15"
  platform: linux/amd64

Checking this

@simster7 any update on this?

This should be resolved in 2.4.3. Could you please check? If the issue still exists please reopen.

@simster7 The issue is resolved in v2.4.3 if i use global artifiacts. However it still can not resolve artifact without globalName field. Here's workflow yaml content:
# This example demonstrates the ability to pass artifacts
# from one step to the next.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: artifact-passing-
spec:
  entrypoint: artifact-example
  templates:
  - name: artifact-example
    parallelism: 4
    dag:
      tasks:
      - name: generate-artifact
        template: whalesay
        arguments:
          parameters:
          - name: message
            value: "{{item}}"
        withItems: [0,1,2]

      - name: consume-artifact
        dependencies: [generate-artifact]
        template: print-message
        arguments:
          artifacts:
          - name: message
            from: "{{tasks.generate-artifact.outputs.artifacts.hello-art}}"
            #from: "{{workflow.outputs.artifacts.my-global-art}}"

  - name: whalesay
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay:latest
      command: [bash, -c]
      args: ["sleep 1; if [ {{inputs.parameters.message}} == '0' ]; then cowsay hello world | tee /tmp/hello_world.txt; fi"]
      #args: ["sleep 1; cowsay hello world {{inputs.parameters.message}}| tee /tmp/hello_world.txt"]
    outputs:
      artifacts:
      - name: hello-art
        path: /tmp/hello_world.txt
        optional: true
        #globalName: my-global-art

  - name: print-message
    inputs:
      artifacts:
      - name: message
        path: /tmp/message
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["cat /tmp/message"]
      #args: ["ls /tmp/message"]

@Itfly Did you solve it? The same demo code. And It happens sometime not all the time, but I can't fix it.

@Itfly Do you solve it? I get the error sometimes. It's weird.

I still get this exact issue in Argo v3.3.8 ...

EDIT: I guess discussion is ongoing in #6805

Marking this as superseded as such


This server is not the leader for that topic-partition

I have a consumer that listens to messages and processes them. It works fine for a few days but after a while it breaks:
This server is not the leader for that topic-partition
I set the following options:
autoCommitInterval: 5000,
autoCommitThreshold: 100,
Does anyone have an idea why that happens?

Are you sure that the application breaks? NOT_LEADER_FOR_PARTITION is a transient error that happens when a partition migrates from one broker to another. The operation should be retried and the application should continue as usual afterwards.

Yes kafka retries 10 times but fails every time and then stops listening to messages

Hi, I actually don't have the logs except the error I mentioned above. I need to wait until it happens again. There were some errors below this error (i think it was errors while retrying to connect). Do you have any idea how I can reproduce this, so I can investigate it further? I am very clueless right now.

This feels like a cluster operation (leaders been moved), what version of KafkaJS are you using? We had an issue in some old version where the consumer would give up on the retries.

I'm using 1.4.6, should I upgrade?

yes, I did a quick check on the changelog, and I can spot at least two fixes that might help with this issue:
[1.4.8] - 2019-02-18
Fix consumer restart on find coordinator errors #253

[1.5.0] - 2019-03-05
Restart consumer on crashes due to retriable error #269

you can safely upgrade to 1.7.0.

I'm closing this due to lack of feedback. Feel free to open it back up if the issue persists, @timojokinen

https://github.com/tulios/kafkajs/issues/518


Adding info about the 3rd party Gradle plugin

There's a somewhat hidden info mentioned in #195, that there's a (separate) Gradle plugin for running Scapegoat.
Mentioning that in our readme.
FYI @eugene-sy

Thanks!
I was not going to add this before some people test the plugin in their projects. But it looks like it's difficult to discover the plugin if we don't add it to the readme. :)


Trad 淡 incorrectly simplified to 澹

Trad 淡 incorrectly simplified to 澹

脊 is also wrongly translated to 嵴

溷 is also wrongly translated to 混


UI API request sometimes failed on 1.0.0

Describe the bug
Upgrade of several PVs from 0.8.1 to 1.0.0 fail. Some others upgraded well.
To Reproduce
Steps to reproduce the behavior:

Kubernetes deployments for PVs scaled to 0
Crosscheck no pod is running
Longhorn UI tells the PVs are detached
Select a PV "upgrade engine", then select the 1.0.0 version, then o.k.

Expected behavior
After a few seconds the upgrade symbol shoud disappear.
Log
Environment:

Longhorn version: 1.0.0
Kubernetes version: v1.18.2+k3s1
Node OS type and version: Ubuntu 18.04.4 LTS

Additional context
Already sent support bundle

Previous thread: https://forums.rancher.com/t/cannot-upgrade-engine/17580/7

@wopl It's weird that I didn't see any engine upgrade request in the manager's log.
We normally should see something like this
[longhorn-manager-h787j] <IP_ADDRESS> - - [01/Jun/2020:15:43:48 +0000] "POST /v1/volumes/test?action=engineUpgrade HTTP/1.1" 200 3052 "https://rancher-master/k8s/clusters/c-sff4g/api/v1/namespaces/longhorn-system/services/http:longhorn-frontend:80/proxy/volume" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36"
[longhorn-manager-h787j] time="2020-06-01T15:43:56Z" level=debug msg="Upgrading volume test engine image from longhornio/longhorn-engine:v1.0.0-rc3 to longhornio/longhorn-engine:v1.0.0"

From the support bundle, I saw pvc-c7af46c3-aab0-46ad-ae47-4b2bf33ad73c and pvc-5cb345c7-a33b-46a9-a7f6-ee37274c5daa are not upgraded, others have been upgraded to v1.0.0. Are the other volumes working fine?

You are correct. All have been upgraded except the two you mentioned.
I now removed the deprecated driver.
I am working with Chrome. In addition I tried on Firefox.
All are working fine at the moment. At least I haven't seen any issues yet.
This one worked now (successfully upgraded):
2020-06-01T18:04:43.715197434+02:00 time="2020-06-01T16:04:43Z" level=debug msg="Upgrading volume pvc-c7af46c3-aab0-46ad-ae47-4b2bf33ad73c engine image from longhornio/longhorn-engine:v0.8.1 to longhornio/longhorn-engine:v1.0.0" 2020-06-01T18:04:43.716504578+02:00 <IP_ADDRESS> - - [01/Jun/2020:16:04:43 +0000] "POST /v1/volumes/pvc-c7af46c3-aab0-46ad-ae47-4b2bf33ad73c?action=engineUpgrade HTTP/1.1" 200 4003 "https://longhorn.plettscher.de/volume" "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0"
I now tried with the pvc-5cb... which failes and there is no entry within longhorn-manager log.  If you see more of them, we might check again.

If you perform a single volume upgrade operation, you can try to debug as shown.
You can see if the value of payload.url is correct @wopl

If you perform a batch upgrade operation, you can try to debug as shown.

If you have time, would you give me feedback? I also want to know why there is no request to the backend. thanks @wopl

Here the url at first breakpoint
url: "wss://longhorn.xxx.de/v1/volumes/pvc-5cb345c7-a33b-46a9-a7f6-ee37274c5daa?action=engineUpgrade"
I looked around not resuming at the breakpoint. Added a shell. I started again from the base URL.
Now at breakpoint I see
url: "https://longhorn.xxx.de/v1/volumes/pvc-5cb345c7-a33b-46a9-a7f6-ee37274c5daa?action=engineUpgrade"
Different protocol now???
I resumed the breakpoint to complete operation. This time the PV successfully upgraded. Finally all my PV are upgraded and I don't have one 0.8.1 to redo the tests.
Thanks for your help
Wolfram

@smallteeths It seems we're issuing commands over WebSocket?

Seems we are getting closer to the root cause. I am using Traefik as Ingress Controller opening HTTP/HTTPS connection for comms into K3S. In the meantime I simplified to HTTP to ensure not to observe any security side effects. All HTTP get requests seem to work (200) and UI looks good (except some minor missing fields that can be filled by a refresh).
Sending commands to Traefik / K3S I see no HTTP protocol anymore but it changes to WS (websocket) protocol.
Access to XMLHttpRequest at ‘ws://localhost:8087/v1/volumes/pvc-8cac06cc-d203-4248-a3a9-44086974d1dd?action=snapshotCreate’ from origin ‘http://localhost:8087’ has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, https.
ws protocol in my case now is blocked as seen above. The reason for not reaching the server (and not being logged) is clear now. You could argue: "Change your Traefik rules", but I was not successful here so far (will continue).
Overall question: Wouldn't it be more simple to use regular HTTP/HTTPS requests to transmit the simple commands? Other question: Why did it work "sometimes" before (why "sometimes" the HTTP/HTTPS protocol was used alternatively to the WS/WSS protocol)?
Any other suggestions (temporarily)?

In addition I see
root      9471  6421  1 Jun03 ?        00:28:38 longhorn-manager -d daemon --engine-image longhornio/longhorn-engine:v1.0.0 --instance-manager-image longhornio/longhorn
producing a lot of zombie processes. Any coincidence with above or open this as a new issue?

@wopl regarding zombie processes, please file a separate bug.
Regarding the original issue, https shouldn't change to ws. Something is wrong here. I am not sure if it's frontend or backend though. Can you provide instructions to recreate your environment? If we can reproduce it, it should be much easier to troubleshoot.

Hi Yasker,
of cource https will change to wss. All fine at this side. It seems to be the change of protocol between HTTP/WS or HTTPS/WSS which will lead to a CORS problem. CORS does not allow a protocol change (e.g. from HTTP to WS / from HTTPS to WSS).
As said before, I "could" add some rules to the Ingress Controller, but gave me other challenges (I am in contact with Traefik team as well). Not sure yet, this problem should be on the end-users side.
As said: Traefik is my Ingress controller to the K3S. I povided an HTTP route. No CORS or WS additional headers / routes / middlewares so far. Happy to provide more information, but not sure, what I shoud do at this moment.
You want to discuss offline?
Wolfram

Hi everyone, I solved this issue independently today of your posts. Had the same issues with CORS wss failing. It's related to the default settings of Traefik not correctly setting headers for the websocket connection. Therefore, everything seemed very unreliable.
Adding the following middleware to the route for the Longhorn UI fixed all issues:
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: svc-wss-headers
spec:
  headers:
    customRequestHeaders:
      X-Forwarded-Proto: "https"

The missing forward protocol header when accessing over https seems to break the websockets. Hope this solves it for you too! Maybe add this to the Longhorn docs?

Thanks @christiaangoossens ! @wopl Can you verify if it works for you? We would love to add this to the doc.
One question remaining: it seems this cannot be triggered by the normal k3s + traefik installation since we've tried that. What's the reproduce step for the issue?

I think normal k3s uses Traefik 1.x. This issue only appears for Traefik 2.x. That would be the difference. It's not k3s related in any way, only Traefik 2.x and it's Websocket handling.

yes I can confirm that the  X-Forwarded-Proto: "https" solves the problem running longhorn-ui via trafic 2.2.1

@yasker Yes I can confirm, the X-Forwarded-Proto header (either HTTP or HTTPS) solves the problem.
Still not sure it is solely Traefik related (see @rsoika)
Anyway many thanks @chrisitangoossens ! I never would have solved that on my own.
@yasker, @smallteeths  Thanks a lot for the deep discussions.

It seems to be a particularity in Traefik 2.x that only causes problems with (ex)Rancher products due to some particularities in their websocket implementation. More details and earlier research here, I have only seen this bug in the context of the Rancher UI and Longhorn: https://github.com/containous/traefik/issues/5533#issuecomment-553823512
I guess I would still count this as a bug(?) report to Rancher and Longhorn.. @yasker What do you think?

I leaning towards considering this as a bug, but I don't have enough knowledge to tell what's the right thing to do here. With @vincent99 's help, we found the problem is the API framework we're using: https://github.com/rancher/go-rancher/blob/5d4e55e3f5de872bd5136d538139fffad238ad3a/api/url.go#L156 .
Let's see if we can fix it on the Rancher side and update the Longhorn dependency after.

Just encountered the same issue with Longhorn v1.0.2, @christiaangoossens solution also worked for me.

Just encountered this with v1.1.0-rc1.  The middleware solution worked for me.  Would be great to add this to the docs.
For me, it was particularly hard to track down. The FIRST edit to any volume worked; all subsequent ones silently failed.

Closing, already validated.


Guarnatee sucessful communication from main device running the agent

Hardware description: ESP32 dev board
RTOS: Arduino
Version or commit hash: ROS2 foxy

Hello,
I am currently working on implementing micro-ros on an ESP32dev board and ROS2 foxy running on my laptop. For now, I am starting the agent from a separate terminal and then subscribing to the published topics on a node implemnted with rospy. Currently, I am checking a connection of the agent only visually by the output in the terminal. However, ideally I would like to know if the agent was successfully setup from my rospy node and make sure that it discovered the MCU, to guarantee that the communication is running from the main device and not only on the MCU side (for that I was looking at the reconnection example). This would be similar to a handshake functionality at startup in a serial communication setting. It should furthermore open the possibility to detect from my rospy node if connection to the device was lost during runtime.
I also thought that in the end it should be possible to just check that messages are coming in or implementing a service upon startup, but that would already require a successful communication setup and no possibility to automatically reconnect from the main device side if the communication is not working for some reason.
Could you please help me out and tell me if I am simply missing something here or if this functionality is not available yet. Also, if this has not been implemented yet I would appreciate some hints where to look at to solve this issue.
Thanks

Hello @Johannap1,
In the micro-ROS client-side you can implement application logic for checking if the agent is available using the ping functionality. You have the example code in the reconnection example.
On your ROS 2 application side, the only way to check if micro-ROS node is correctly enabled is by checking the ROS 2 graph, for example, using get_node_names() in order to check if your micro-ROS node is alive.

Hello @pablogs9,
thank you for your quick answer. Indeed my question concerns more the ROS 2 application side. I tried your suggestion using the get_node_names(). This should work to check whether the agent is running on startup to see whether the node is there, but what I discovered is that when connection is lost to the microcontroller (either unplugging it or killing the agent), the node remains for up to half a minute before it cannot be detected by ROS anymore. So this would not be a solution to detecting if connection is lost. Do you see the same behavior with your system?

Hello @Johannap1,
On the ROS 2 side you have two situations:

If the agent is killed, micro-ROS entities will appear for at least 20 seconds, that is the default lease time of the underlaying DDS participant.
If the MCU is unplugged, the entities should appear forever as the micro-ROS agent is not allowed to kill entities without the client's request. This is the default behavior of XRCE-DDS, the underlying middleware for micro-ROS.

If you want to check the liveliness of your MCU system, my recommendation would be to send a topic in a certain rate and check this rate at the ROS 2 side. For this deadline QoS can be handy, check this

Any update on this?

Some comments here: https://discourse.ros.org/t/our-conclusions-on-trying-to-implement-micro-ros-in-our-robot/24690/2?u=pablogs

Closing due to inactivity


Atom's "Generate Syntax Theme" not working (even after reading docs)

Hello,
I was just studying how to create a custom theme by reading https://atom.io/docs/v0.201.0/hacking-atom-creating-a-theme because I wanted to try out my own theme.
However, when I followed the instructions, it did not seem to work as expected.
At first, I pressed cmd-shift-P as stated in the docs and searched for "Generate Syntax Theme":

I then pressed "Enter", so it asked me to enter the path file:

However, after I entered the path, I could not find a way to submit the path (I tried pressing the "Enter" button, but it did not work) and when I clicked somewhere else, it just disappeared and I had to do it all over again.  Can someone please tell me what button I should press after I enter the file path to start generating the theme?
Thank you very much!
Yours sincerely,
DonaldKellett (Donald at Kellett)

@DonaldKellett Pressing enter should work -- I just tried it on OSX and it worked for me. Can you provide a bit more information and check the debugging guide?

I haven't upgraded to Mac OSX Yosemite yet.  Does that matter?
And if I type an invalid path, will it still allow me to create a theme after I press enter (although I'm fairly certain I have typed in a valid path)?
Thank you very much.
DonaldKellett

I haven't upgraded to Mac OSX Yosemite yet. Does that matter?

I don't know -- I don't have a machine with Mavericks to confirm.

And if I type an invalid path, will it still allow me to create a theme after I press enter (although I'm fairly certain I have typed in a valid path)?

What kind of invalid path do you have in mind? That path you entered looks valid to me.
Does pressing enter work in other similar panels, e.g. when you try to add a file in the tree view? (Open a folder with Atom, then in the tree view select a file, right click it, and select "New File". You'll be shown a similar panel to enter the file's name.)
Do you see any errors in the devtools console?

Sorry, I don't know (I'm quite new to Atom, but I read the first 2 main sections of the Atom Documentation and I think I understand most of the content).
Do I have to create an empty file beforehand, or does Atom help me generate the file when I enter the path?
For example, should I create a folder named motif-syntax on my Desktop before I generate a theme and type in the file path /Users//Desktop/motif-syntax or should I simply type in that path to create the theme?  Anyway, either way (I tried both ways already), it doesn't seem to work and I'm certain I have all Core packages enabled.
Thank you very much!
Yours sincerely,
DonaldKellett [Donald Leung (Kellett)]

Open up the .atom folder in atom in dev mode then try again, this is how I
made mine.
Only thing I don't know how to do is how I go about publishing it.
Hope this helps
On 28 May 2015 16:29, "Donald Leung (Kellett)"<EMAIL_ADDRESS>wrote:

Sorry, I don't know (I'm quite new to Atom, but I read the first 2 main
sections of the Atom Documentation and I think I understand most of the
content).
Do I have to create an empty file beforehand, or does Atom help me
generate the file when I enter the path?
For example, should I create a folder named motif-syntax on my Desktop
before I generate a theme and type in the file path
/Users//Desktop/motif-syntax or should I simply type in that path to create
the theme? Anyway, either way (I tried both ways already), it doesn't seem
to work and I'm certain I have all Core packages enabled.
Thank you very much!
Yours sincerely,
DonaldKellett [Donald Leung (Kellett)]
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/6972#issuecomment-106411393.

Do I have to create an empty file beforehand, or does Atom help me generate the file when I enter the path?

@DonaldKellett You shouldn't need to create anything yourself.
Can you answer the two questions I asked in a previous comment? Here they are again:

Does pressing enter work in other similar panels, e.g. when you try to add a file in the tree view? (Open a folder with Atom, then in the tree view select a file, right click it, and select "New File". You'll be shown a similar panel to enter the file's name.)

Do you see any errors in the devtools console?

Also, can you try generating a package instead of a theme and see if that works? (Using the "Generate package" command).
Thanks for the help in investigating this.

Only thing I don't know how to do is how I go about publishing it.

@Huaraz2 You need to use the apm publish command for that.


clarify variable scope, as in...

can read from any scope but only write in current one

f2=func() {
       log("called f2", n) // log output
       n
}
f1=func() { // function
    log("called f1", n) // log output
    n=n-1
    log("n in f1 now", n)
    f2() // still bound to top-level env not this one
 }
n=5
f1()

maybe f2() called into f1() should refer to f2's env not the env it was created in...?
or have some option
or have upvar
or have &

it's kind of nice as is, so far, all pure functions that we memoized automatically in #72

Ok so while trying to trigger an error when a function parameter is a CONSTANT identifier, I stepped on this again
Decided to do the following (in #102 ) :
The environment when calling into a function body is either:

Based on the environment when the function was defined (capture), ie previous behavior
or
Based on the current environment if the function is the same (ie recursing) [which is itself based on time of definition per above when it's the first call]

Note this only works for direct recursion, a->b->a would use env of a as when defined, not the first a
(which maybe is dicey)


OnClick Handler

I'm using your toast component for a chat inside my application and it would be nice if you could add the option of adding a clickable button (call to action) into the toast.
to open the mentioned chat for example.

@jappyjan great idea, I'll cook something up soon.

@jappyjan check out new slot option I've added, you can use this.$createElement to create links buttons and other components.

thanks a lot! this solved it! great work!


Notifying the subscription topic of a message notification

Hi Adam,
I am using your great component on a project that uses your library in two different forms, I have clients that will suscribe to a specific topic, lets say "topic/subtopic" and in a more general way let say "topic/"
My issue is that, when a publish notification arrives, the framework do not state for wich subscription topic happened, but just the topic of the message, so I cannot dispatch to the addecuate client. I would suggest to  extend the MQTTPublishInfo to add either the topic of the subscription or eventually a copy of the MQTTSubscribeInfo. On that way I could map the subscriptions to my consumers.
Thanks for your support
Juan Solsona.

Hi Juan,
This information is not part of the MQTT spec. You only get the topicName back. You don't get the original subscription topic back. But there is a way around if you are using MQTT v5. You can add a subscriptionIdentiifer property to a subscription and this will be returned in each publish notification.
let _ = client.v5.subscribe(
    to: [.init(topicFilter: "topic", qos: .atLeastOnce)],
    properties: [.subscriptionIdentifier(1)]
).wait()

Ah! That is very helpful , thanks a lot Adam,
El El sáb, 14 ago 2021 a las 13:15, Adam Fowler @.***>
escribió:

Hi Juan,
This information is not part of the MQTT spec. You only get the topicName
back. You don't get the original subscription topic back. But there is a
way around if you are using MQTT v5. You can add a subscriptionIdentiifer
property to a subscription and this will be returned in each publish
notification.
let _ = client.v5.subscribe(
to: [.init(topicFilter: "topic", qos: .atLeastOnce)],
properties: [.subscriptionIdentifier(1)]
).wait()
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adam-fowler/mqtt-nio/issues/68#issuecomment-898880980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKKLL7FN36M2UOHBZHU4XLT4ZF4RANCNFSM5CE6HBYA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Create Tutorial for ProCoda data analysis software

Fletcher, can you create a tutorial on how to use your data analysis software for ProCoda?  This will be used over the summer for reports.

I added two pages to the wiki. If that isn't sufficient or you want me to expand anything feel free to reopen the issue


Merge prTesting_202007121925 branch to master branch

Docs Build status updates of commit 3b8e120:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestCon.md
:warning:Warning

Details

split/updateTestCon.md

Line 0: [Warning-h1-not-first] Markdown content is not allowed before H1.
Line 1: [Suggestion-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning around July 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


PDFKIT Measurement unit

What is the measurement unit used in pdfkit???
Is it cm, mm, inch or pixels???
Can I change it??

It uses PDF/PostScript points - there are 72 to an inch
http://pdfkit.org/docs/getting_started.html#adding_pages


verify-commit semantic refinement

This issue is intended to discuss a possible change in semantics for the verify-commit subcommand.
I'm still a little unclear on the specifics, but from what I understand from talking with @adityasaky it gathers the first reference to a commit ("first mention is RSL") and verifies if that was a valid change of the reference.
@adityasaky now proposed a change the semantics towards verifying a commit with respect to a given reference (e. g. branch).
Example:
state 0:
180757b (feature) feature commit
5fa7115 (HEAD -> main) init

state 1 (main rebase to feature):
180757b (HEAD -> main, feature) feature commit
5fa7115 init

If my understanding of the current implementation is correct, if gittuf verify-commit 180757b was run after the merge (state 1), it would still verify the commiter of 180757b was allowed to commit to feature branch according to the policy at state 0.
The new implementation would require a reference as a second argument.
The command gittuf verify-commit 180757b feature could then be used to check if main was valid at state 0 whereas  gittuf verify-commit 180757b main would check if the original commit was according to policy.
Are reverts valid gittuf actions i. e. recorded to the rsl just the same?
If so, a commit could be added to the rsl, reverted and then readded, which means the combination commit/reference does not uniquely identify a rsl state.
How should gittuf behave in such situations?
Are there significant drawbacks to simply picking the first/last occurrence?

Come to think of it, maybe an added flag for verify-ref would be a better match for the proposed semantics:
gittuf verify-ref main --at 180757b
Which would have the additional perk of being able to throw out verify-commit and verofy-tag entirely and renaming verify-ref to verify.

We would not necessarily be able to throw out verify-tag, since while each tag is a ref itself, tags, and their verification work diffrently compared to regular refs. We maybe could route tag verification through gittuf verify-ref, but I think it would have to be its own feature under the hood.

Also, the use cases of verify commit are minor, and after #337 is merged, parsing invalid states will be much easier. Currently, the only use case of verify-commit(that I can see) is to find out if, in an invalid state, these x commits caused it, especially when we have to take into account the ref that we are verifying the commit with, which would make it take as long as a regular verify-ref.

Here's how gittuf verify-commit currently works: it tries to identify when the specified commit was first seen in the repository in any git reference from the RSL. Recall that the RSL is a series of entries, with each indicating a git ref and the target commit or tag object's ID for that ref. To identify when a commit was first seen, the RSL is walked back until an entry is found that doesn't "know" the commit. That is, the commit recorded in the entry is not a descendant of the commit being verified. This is problematic because this entry may have been for a push to an older feature branch, and entries before it may well "know" the commit under test. To be really sure about when we first saw a commit, we would essentially have to walk all the way back to the start of the RSL.
The reason this is done is to identify the policy applicable at the time the commit was first seen. verify-commit uses all the public keys in this policy to verify the commit's signature. Note that this means it doesn't enforce any meaningful policies about whether the signature is indeed valid for a given context (eg: the branch the commit is in), because we don't have that context with verify-commit. This is largely why I think we ought to drop the current verify-commit flow, I also am not a big believer in a boolean signature verification check on a commit that may or may not actually matter to the repository's history.
verify-tag is a bit different because it primarily considers annotated tag objects rather than lightweight tags, and verifies the tag object's signature. However, it also notes that the tag is a ref as well, and so it looks at the corresponding RSL entry. This really means that verify-tag is part of the way to verify-ref minus some checks (eg: bootstrapping successive roots of trust, thresholds etc), so I'm inclined to roll that into verify-ref as well. I have some pending changes to policy's verifyTagEntry that addresses this, which I plan to open after the current sequence of PRs on the git binary backend are merged.
I think I largely agree with @flandweber's point above. We ought to roll things into verify-ref and provide some features for users to do more specific things. For example, we already have verify-ref --from-entry to verify the RSL from a particular entry (I see this being valuable on fetch when the local repository is in a verified state pre-fetch and must only verify new entries, #245). I think verify-ref --at-commit as proposed above is a good idea. We'd be doing a version of what I stated above to determine when the commit first appeared in the specified ref, but it'd be a lot more constrained.

Currently, the only use case of verify-commit(that I can see) is to find out if, in an invalid state, these x commits caused it,

My use case is actually a little different: I'd like to pin a commit in a Nix fetcher (https://codeberg.org/flandweber/fetchgittuf), so that it always evaluates to the same state of the repository.
I wouldn't care if a verification later on fails, as long as the commits up to the pinned commit pass.

To be really sure about when we first saw a commit, we would essentially have to walk all the way back to the start of the RSL.

Expensive operations may be acceptable in some cases, though the --at flag can't be more expensive than verify-ref on the branch head, correct?
Also could be sped up by using data structures, though I realize this is probably not be worth the effort.

Expensive operations may be acceptable in some cases, though the --at flag can't be more expensive than verify-ref on the branch head, correct?

It depends, but it should be possible to make it cheaper I think. I'm also generally curious about what optimizations we can pull off in the rsl package, we can likely track parent child relationships and what not.

Closing this due to #445.

I wouldn't care if a verification later on fails, as long as the commits up to the pinned commit pass.

Do we want to track verify-ref --at or verify-ref --until in a separate issue?