How to use my phone's light?

Description of the problem:
Which library version are you using? E.g. 3.2.0.
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
Does the same happen on other devices or an emulator?
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error?
In the case of an error do you have a stack trace or adb logs?

By default the volume up/down buttons can be used. For other ways, search through the existing issues here (search for torch/flashlight).


Add flag for testing notifications only

I added another flag called test that defaults to false. When true it attempts to send all configured notifications. I also extracted the url switch statement into its own function so I could use it.

This would be handy, it's hard to test now while the Nvidia API is down.


Refactor of backend API

Would like feedback first before changing eStark.

test failing

please squash then I'll approve


Put FlowClient behind an interface

Is your feature request related to a problem? Please describe.
Right now the Flow client is just a struct, so mocking it in tests it quite difficult.
Describe the solution you'd like
Ideally the client exposes a concrete interface that we can mock out if we want to.
Describe alternatives you've considered
Developers who wish to mock out the client could also wrap it in their own interface, but they really shouldn't have to do that imo.
Additional context
Add any other context or screenshots about the feature request here.

So you can almost do this already. client.Client uses the generated gRPC interface under the hood, and that interface is mocked in our own tests: https://github.com/onflow/flow-go-sdk/blob/master/client/client_test.go#L51-L52). You just need to call client.NewFromRPCClient.
But mocking at this level means you need to deal with the protobuf types directly, which I suppose isn't ideal for most end users. 🤔
I'll need to think about this a bit more. I don't want to return an interface directly from client.NewClient because that breaks the "accept interfaces, return structs" rule in Go, which I've grown to like. I also recently had a discussion about how it's better for the consuming package to define an interface that describes the values it will accept, rather than the other way around. Not trying to shoot this down at all, but I think it would be valid for your code to look something like this:

type FlowClient interface {
  // define the functions you need
 GetLatestBlockHeader(ctx context.Context, isSealed bool, opts ...grpc.CallOption) (*flow.BlockHeader, error)
 SendTransaction(ctx context.Context, tx flow.Transaction, opts ...grpc.CallOption) error
}

type App struct {
  c flowClient
}

func NewApp(c FlowClient) app {
  return app{c: c}
}

// ...

import "github.com/onflow/flow-go-sdk/client"

c, _ := client.New("localhost:3569")
a := NewApp(c)

I want to add that having the client side of things as an interface is actually not that idiomatic for go. An example from the standard lib, with http.Client as the example: https://github.com/golang/go/issues/16047.
The reasoning from that issue being that the intention of the package is NOT to have an interface that other people can implement, but rather to implement an interface with an API.
I'm not completely opposed to the idea of providing a "FlowClient" interface, but i do think more thought would be required to determine if it's appropriate, where in the package it lives, or if it should even be in this repo.

@psiemens @Kay-Zee Thanks for the responses, they make a lot of sense. We used NewFromRPCClient to mock out the client in our tests, which I think suffices in most cases. I also agree that the New and NewFromRPCClient functions should return structs, not interfaces, and that it's probably cleaner for packages that depend on the Flow client to accept interfaces rather than the FlowClient struct.
I think the only argument in favour of defining a client interface within the SDK would be that you save other people the work of having to do it themselves, but given what we're already said, defining this interface in the SDK would be putting dead code into the repo, since that interface wouldn't really be used by the SDK itself.
All that said, I actually think we should probably close this issue. If people defining their own interfaces or using the RPCClient to mock becomes a problem, we can come back to this.

Sounds good, thanks @bfbachmann!

Sounds good, thanks @bfbachmann!


Show human-readable error message when parsing the JSON-config fails

Shows the actual error message.

@aanil Install black locally and run it, and then push to this PR. Then we'll merge. We can ignore the pytest failure for now imo.

Great, thanks, will merge!


Export ListCollection from react-stately/list so it can be used externally with useCollection

Provide a general summary of the feature here
Sometimes we need to extract collection items from children, but we don't need to use any state function. It would be helpful to have a Collection implementation exported from the library
🤔 Expected Behavior?
The ListCollection class would be exported from the library.
😯 Current Behavior
It isn't exported
💁 Possible Solution
No response
🔦 Context
I'm trying to incorporate the Collections API in some components that aren't using any react stately state hook
💻 Examples
No response
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Thanks for the issue. That ListCollection is actually part of our old Collections. I know our hooks docs still reference the old Collections, I'm looking for our issue/backlog item to update them and will link it here once I find it.
I'm going to close this as won't do because it's old collections.
If you tell us more about what you're trying to accomplish, maybe we will have some other suggestions.

@snowystinger Thank you. Could you please clarify a little bit more on what is the old Collections and what is the new preferred approach?
Currently our design system uses Collections for many components (dropdown-menus, lists, tabs), so, trying to maintain the same API for other components with subitems, I wanted to have a way of using useCollection without having to go to an unneeded state hook.
What would be your recommendation? (What I did was copying the ListCollection class to our project to be used in the factory for useCollection, but it would be better not having a fork of that inside the project)

Thank you


Cannot Use in Other Bazel Project

Hi all,
Although this project builds well with Bazel, we are having difficulty using it in another Bazel project (https://github.com/prysmaticlabs/prysm) as a dependency.
The failure is as follows:
ERROR: /home/nishant/.cache/bazel/_bazel_nishant/2d55d16d3d0901116c0ae97899c3d124/external/com_github_prysmaticlabs_go_bls/BUILD.bazel:3:1: C++ compilation of rule '@com_github_prysmaticlabs_go_bls//:go_default_library%linux_amd64%cgo_c_lib' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -MD -MF ... (remaining 66 argument(s) skipped)

crypto.go:5:10: fatal error: external/herumi_mcl/include/mcl/bls.h: No such file or directory
compilation terminated.

Even after adding the transitive deps the Prysm WORKSPACE:
go_repository(
    name = "com_github_prysmaticlabs_go_bls",
    commit = "a37e65522727d6a8518151ce9008aa155632c13d",
    importpath = "github.com/prysmaticlabs/go-bls",
)

load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")

git_repository(
    name = "herumi_mcl",
    commit = "79b3a33e21072712f00985ed2adf34b3bcf0d74e",
    remote = "https://github.com/prysmaticlabs/mcl",
)

git_repository(
    name = "bazelify_gmp",
    commit = "bb4881b35e6864c90493980d035e1d984cafd093",
    remote = "https://github.com/robin-thomas/bazelify-gmp",
)

git_repository(
    name = "boringssl",
    commit = "fafc4482e85c09e7af5f71b2eb287b73ccd1020a",
    remote = "https://github.com/google/boringssl",
)

git_repository(
    name = "io_bazel_rules_m4",
    commit = "2bf69df77dfb6b3ba6b7fc95c304b0dc279375bc",
    remote = "https://github.com/jmillikin/rules_m4",
)

load("@io_bazel_rules_m4//:m4.bzl", "m4_register_toolchains")

m4_register_toolchains()

Any help on this would be much appreciated.

Unrelated to this - this is a bug in rules_go with bazel support in Goland


inconsistency of reset function names in kvikio.defaults

It seems a bit counterintuitive that there is
reset_num_threads
reset_task_size
but
compat_mode_reset
For consistency, I would have expected the last one to be reset_compat_mode. Do you think this is worth changing via a deprecation cycle?
The C++ API consistently has all three functions in a form ending in _reset, but if we did that on the Python side we would have to change two of the existing functions.

I think this is a very good idea!
Let's change all of them to end with _reset in branch-22.10


Simple mechanized proofs

Attempt at making some simple generalised tactics

I'm not very familiar with Ltac programming but at some informal level this looks great to me, thanks!


error download split apk

(node:4208) UnhandledPromiseRejectionWarning: Error: Download "com.supercell.clashofclans" Split Apks Failed: Get "com.supercell.clashofclans" Download Split Apks Name And Url Failed:
Get "com.supercell.clashofclans" Split Delivery Data Info Failed: Get "com.supercell.clashofclans" Download Info Failed: Make "com.supercell.clashofclans" Purchase Request Failed: Erro
r retrieving information from server. DF-DFERH-01

I solved it by refreshing the token, sorry for bothering


Copy html file to html directory

Signed-off-by: yaacov<EMAIL_ADDRESS>dist files are missing on upstream image
Screenshot:

/lgtm

/hold

/hold this isn't it @yaacov .
tests aren't passign

@glekner :+1: thanks, looking

/close
will need to find a more complete fix, closing this one


Bring https://kubernetes.io/docs/setup/best-practices/multiple-zones/ up to date

This is a Feature Request
What would you like to be added
Revise and restructure the page about running in multiple failure zones.

create a new task page about building a cluster that spans at least 2 failure zones
optionally create a follow-on task page to demonstrate additional concepts, such as Volume affinity to zones.
revise https://kubernetes.io/docs/setup/best-practices/multiple-zones/ to explain what approach cluster operators should take and why they should follow it.

failure zones should be geographically& separate
consider using a managed control plane where appropriate
if deploying your own control plane, run that (including etcd) across multiple zones
also make sure nodes are available in multiple zones
CNI considerations for running in multiple zones
as good practice, cluster autoscaling should also be zone aware (run enough nodes to spread ReplicaSets etc across zones as required)

Why is this needed
https://kubernetes.io/docs/setup/best-practices/multiple-zones/ is out of date: it talks about Kubernetes v1.2, minions, and the v1 Federation design. The page recommends using kube-up to bring up a cluster. As I understand it, kube-up and the whole folder it lives in are deprecated.
Comments
Relevant to #11536 as SIG Cluster Lifecycle has expressed an intent to maintain this section of the documentation.
/language en

This covers some of the same ground as #14638

/priority backlog

/sig cluster-lifecycle
/remove-lifecycle stale

I noticed that https://kubernetes.io/docs/setup/best-practices/ doesn't really cover the benefits of a multi-master control plane. That'd be worth explaining too.

/remove-lifecycle stale

i'm not familiar with the authorship of this page, but it seems to fall under SIG Cloud Provider.
potentially Node / Storage too.
/remove-sig cluster-lifecycle
/sig cluster-lifecycle

/sig cloud-provider

I'm planning to remove the cloud-provider stuff as it's both outdated and not really in line with the content guide.
/remove-lifecycle stale


init: Allow '--import <ENV_FILE>' and '--format ' together

Problem description
I'd like to be able to write this, please.
pixi init --import environment.yml --format pyproject

Or is there an automatic way to convert pixi.toml to pyproject.toml.
Currently this gives the following error:
error: the argument '--import <ENV_FILE>' cannot be used with '--format <FORMAT>'

pixi: 0.37.0

He @jamesmyatt, this sounds like a good plan! I've added a good first issue label feel free to take a stab at it!

I don't know any rust, unfortunately


fix(Let): properly create instruction Id

Current behavior is having all calls in a single statement, this leads to a bug where instruction id cannot be properly created before creating instruction. Thanks to @graycrow for pointing this out.
cc @EisenbergEffect

ok, well I can get these fixes out now since it's not working anyways 🤣 Thanks for jumping on this!


remove dubbo

Delete Dubbo related content。
Describe what this PR does / why we need it
https://github.com/alibaba/spring-cloud-alibaba/issues/2512#issuecomment-1102144921

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the Contributor License Agreement!

Please sign the Contributor License Agreement, otherwise we can't merge your PR.

Other people fixed it later.


impl From for SizeRange is a refactoring hazard

Consider this example strategy:
prop_compose! {
    fn string(max_chars: usize)
        (chars in prop::collection::vec(".", 0..=max_chars))
        -> String
    {
        chars.concat()
    }
}

Uses of string(4) produce strings with the number of characters between 0 and 4 inclusive.
Now I have decided I want to specify the lower bound and support non-inclusive ranges as well and made the strategy's parameter generic like this:
prop_compose! {
    fn string(size: impl Into<SizeRange>)
        (chars in prop::collection::vec(".", size))
        -> String
    {
        chars.concat()
    }
}

Suddenly, my string(4) calls produce strings with strictly 4 characters, shrinking test coverage with no break in compilation.
For the next major version, please consider removing the conversion from usize into SizeRange, so that the user has to make the intent explicit with e.g. 4..=4.

The type SizeRange was introduced instead of using Range* directly to make usage of ::vec(...) and friends more ergonomic in concrete cases. It wasn't primarily added to allow users to be generic like size: impl Into<SizeRange>, although its nice that it supports this too. Therefore my view is that regressing ergonomics by removing From<usize> is the wrong trade-off.


Ignore non-existent characteristics taken from device config

Describe the bug
If the device config contains characteristics a device itself does not, just ignore them instead of throwing. See buttplugio/buttplug#94.

buttplug-js will soon be part of buttplug-wasm in https://github.com/buttplugio/buttplug-rs-ffi, closing this bug as it relates to implementation that will be taken care of in buttplug-rs.


Ninja Menuconfig is not functionning

Describe the bug
After updated amazon-freertos repo and used it such as a subdirectory , related to this
Document how to create a new cmake project outside the freertos source tree
, I canno't use ninja menuconfig, with or without IDF_SDK_CONFIG personnalized.
But it's working with make menuconfig.
**** Command used :
=> cmake -S . -B build -DCMAKE_TOOLCHAIN_FILE=amazon-freertos/tools/cmake/toolchains/xtensa-esp32.cmake -GNinja
=> ./amazon-freertos/vendors/espressif/esp-idf/tools/idf.py menuconfig
System information

Which hardware board or part numbers? ESP32
IDE used VS Studio
Operating System MacOS
Version of Amazon FreeRTOS : 201910.00-378-gd26ecc1dd
Project [Custom Application]
If your project is a Custom Application, please add the relevant code snippet in the section

Expected behavior
Run ninja menuconfig
Terminal error
Loading defaults file /Users/XX/Documents/XX/Phase_4_AWS/bob_v7_gui/Developement_GUI_ESP32/sdkconfig.defaults...
No such file or directory
FAILED: amazon-freertos/CMakeFiles/menuconfig
Code to reproduce the bug
# -------------------------------------------------------------------------------------------------
# Cmake to build project BOB and amazon freertos
# -------------------------------------------------------------------------------------------------
cmake_minimum_required(VERSION 3.13)

set(CMAKE_C_COMPILER /Users/XX/esp/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc)
set(CMAKE_CXX_COMPILER /Users/XX/esp/xtensa-esp32-elf/bin/xtensa-esp32-elf-g++)

set(EXTRA_CFLAGS --save-temps -lm -l)
project(bob_v6)

file(GLOB SOURCES "/Users/XXDocuments/XX/Phase_4_AWS/bob_v7_gui/Developement_GUI_ESP32/main/*.c" ABSOLUTE

    "amazon-freertos/libraries/freertos_plus/standard/utils/src/iot_system_init.c"
    )
file(GLOB HEADERS "/Users/XX/Documents/XX/Phase_4_AWS/bob_v7_gui/Developement_GUI_ESP32/main/*.h" ABSOLUTE
)
add_executable(bob_v6 ${SOURCES} ${HEADERS})

# Tell IDF build to link against this target
set(IDF_PROJECT_EXECUTABLE bob_v6)

#Define the components
get_filename_component(ESPRESSIF_CODE_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/amazon-freertos/vendors/espressif/boards/esp32/aws_demos/application_code/espressif_code" ABSOLUTE)
get_filename_component(ESP_SPIFFS_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/spiffs" ABSOLUTE)
get_filename_component(ESP_SPIFFS_IMG_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/spiffs_image" ABSOLUTE)
get_filename_component(ESP_MKSPIFFS_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/mkspiffs" ABSOLUTE)
get_filename_component(ESP_SPIDRIVER_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/spidriver" ABSOLUTE)
get_filename_component(ESP_TFT_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/tft" ABSOLUTE)
get_filename_component(MQTT_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/mqtt_cartridge" ABSOLUTE)
get_filename_component(FOO_COMPONENT "${CMAKE_CURRENT_LIST_DIR}/components/foo" ABSOLUTE )

set(EXTRA_COMPONENT_DIRS
                            #${EXTRA_COMPONENT_DIRS}
                            ${FOO_COMPONENT}
                            ${ESPRESSIF_CODE_COMPONENT}
                            ${ESP_TFT_COMPONENT}
                            ${ESP_SPIFFS_COMPONENT}
                            ${ESP_SPIFFS_IMG_COMPONENT}
                            ${ESP_MKSPIFFS_COMPONENT}
                            ${ESP_SPIDRIVER_COMPONENT}
                            ${MQTT_COMPONENT}
)

list(APPEND IDF_EXTRA_COMPONENT_DIRS ${EXTRA_COMPONENT_DIRS})

# As of now there's no offical way to redefine config files outside of Amazon FreeRTOS source tree.
# This is a temporary approach to inject an include path so that this takes precedence over the
# config file directory inside Amazon FreeRTOS.

#include_directories(BEFORE amazon-freertos-configs)

# Bring in the include directories
set(INCLUDE_DIRS ${INCLUDE_DIRS}
    "amazon-freertos/vendors/espressif/esp-idf/components/spi_flash/include"
    "amazon-freertos/demos/include/"
    "amazon-freertos/libraries/freertos_plus/standard/freertos_plus_tcp/include/"
    "${esp_idf_dir}/components/bt/bluedroid/api/include/api/"
    "${AFR_ROOT_DIR}/vendors/espressif/esp-idf/components/bt/include/"
    )
include_directories(${INCLUDE_DIRS})

# include_directories(bob_v6 PRIVATE "amazon-freertos/demos/include")
# include_directories(bob_v6 PRIVATE "amazon-freertos/libraries/abstractions/platform/freertos/include")
# include_directories(bob_v6 PRIVATE "amazon-freertos/libraries/freertos_plus/standard/utils/include")
# include_directories(bob_v6 PRIVATE "amazon-freertos/libraries/freertos_plus/standard/utils/src")
# include_directories(bob_v6 PRIVATE "amazon-freertos/demos/dev_mode_key_provisioning/include/")
# include_directories(bob_v6 PRIVATE "amazon-freertos/libraries/abstractions/pkcs11/include/")
# include_directories(bob_v6 PRIVATE "amazon-freertos/libraries/3rdparty/pkcs11/")
# include_directories(bob_v6 PRIVATE "amazon-freertos/demos/network_manager/")
# include_directories(bob_v6 PRIVATE "amazon-freertos/libraries/abstractions/wifi/include/")

#Set SDK Config Defaults
set(IDF_SDKCONFIG_DEFAULTS "/Users/XX/Documents/XX/Phase_4_AWS/bob_v7_gui/Developement_GUI_ESP32/sdkconfig.defaults")

# Bring in the FreeRTOS code
# AFR_BOARD tells which board we need to target.
set(AFR_BOARD espressif.esp32_devkitc CACHE INTERNAL "")
set(EXTRA_CFLAGS --save-temps -lm)
add_subdirectory(amazon-freertos)

message("++++++++++++++++++++++++++++++++++")
message("++++          MY APP          ++++")
message("++++++++++++++++++++++++++++++++++")

message("IDF_EXTRA_COMPONENT_DIRS: ${IDF_EXTRA_COMPONENT_DIRS}")

message("INCLUDE_DIRS: ${INCLUDE_DIRS}")

message("Glob Source : ${SOURCES}")

message("Glob headers : ${HEADERS}")

message("IDF_CONFG: ${IDF_SDKCONFIG_DEFAULTS}")

target_link_libraries(bob_v6 PRIVATE AFR::demo_mqtt)
target_link_libraries(bob_v6 PRIVATE AFR::demo_ble)
target_link_libraries(bob_v6 PRIVATE AFR::demo_ble_numeric_comparison)

target_link_libraries(bob_v6 PRIVATE AFR::wifi)
target_link_libraries(bob_v6 PRIVATE AFR::utils)
target_link_libraries(bob_v6 PRIVATE AFR::ble)
target_link_libraries(bob_v6 PRIVATE AFR::ble_hal)
target_link_libraries(bob_v6 PRIVATE AFR::platform)
target_link_libraries(bob_v6 PRIVATE AFR::dev_mode_key_provisioning)
target_link_libraries(bob_v6 PRIVATE AFR::mqtt)
target_link_libraries(bob_v6 PRIVATE AFR::pkcs11)
target_link_libraries(bob_v6 PRIVATE 3rdparty::pkcs11)
target_link_libraries(bob_v6 PRIVATE AFR::serializer)

If the code is longer than 30 lines, GIST is preferred.
Additional context
Add any other context about the problem here.
Thank you!

When you run cmake, it should create a ninja.build file, I think.  Would you share the contents of that file, please?

There is the build.ninja attached after running ninja menuconfig build.ninja

@elieDaan I just figured where the issue is, inside this file amazon-freertos/vendors/espressif/esp-idf/tools/cmake/kconfig.cmake where the menuconfig target is defined, the dependency mconf-idf is referencing a wrong location.
On line 51, change set(MCONF ${CMAKE_BINARY_DIR}/kconfig_bin/mconf-idf) to set(MCONF ${CMAKE_CURRENT_BINARY_DIR}/kconfig_bin/mconf-idf). Basically, the mconf-idf should point to build/amazon-freertos/kconfig_bin/mconf-idf, note there's a amazon-freertos subdirectory. I'll raise a PR to fix this problem and let Espressif know.
@mahavirj, Looks like the issue is also in the ESP-IDF upstream repo, can you verify this? https://github.com/espressif/esp-idf/blob/93a8603c545fb8e54741d6685146e2f3b874378d/tools/cmake/kconfig.cmake#L36

OMG It's working perfectly ! Very good job @tgsong, thanks a lot because I spend a lot of time on this ;)

@mahavirj, Looks like the issue is also in the ESP-IDF upstream repo, can you verify this? https://github.com/espressif/esp-idf/blob/93a8603c545fb8e54741d6685146e2f3b874378d/tools/cmake/kconfig.cmake#L36

@tgsong Correct fix should be: https://github.com/espressif/esp-idf/commit/ded0ac352d90cda800bd54ec5c71635ffe38229a
Seems like we did not backport this one to our release/v3.3 branch, I will ensure that its taken care of and when we migrate ESP-IDF to next release in AFR, change will reflect here as well. (CC @shubhamkulkarni97)

@mahavirj, thanks, I raised a PR #1614 to fix for this version first.


How to switch between "0.1.0-small" and "0.1.0-base?

I have tried using nougat
nougat .\Nougat- Neural Optical Understanding for Academic Documents.pdf -o ./
It downloaded the 0.1.0-small version. How can I use the 0.1.0-base version for comparison?

You'll need to manually download the model files from the release section into a separate directory (eg nougat-base) and then provide the path to the model
nougat .\Nougat- Neural Optical Understanding for Academic Documents.pdf -o ./ --checkpoint .\nougat-base


Fix scroll position for cross references links

You may have noticed a very annoying behavior when clicking on links within the Ledger API reference docs. For example, if you click on the link for the GetActiveContractsResponse message, the heading for that message is behind the navbar. It is very confusing for new users.
This PR makes a small CSS tweak to address that issue. Using jQuery, it dynamically adds the section CSS class to the spans which serve as the anchor for internal links.
I did look at trying to add that CSS class to the RST source file, but without success. I have also asked on StackOverflow.
Attached are videos showing before and after.
https://github.com/user-attachments/assets/a3963573-f321-499f-8dd7-3a13adaa8987
https://github.com/user-attachments/assets/66f9c6b1-a31c-4c1c-8e4b-73703a0550fd

Oh nice!
This is however a general problem on docs.daml.com, see

https://github.com/digital-asset/docs.daml.com/issues/722

Not sure how easy it would be to apply this fix generally 🤔

Not sure how easy it would be to apply this fix generally

@yves-da, with 91f6986ab81014dfcbc9728432e5e59ef39dac26 I changed the jQuery selector from span[id^=com-daml-ledger-api-v] to div.section > span.

The former selects spans whose ids start with com-daml-ledger-api-v.
The latter selects spans that are direct children of a div with the class section. This is the pattern that Sphinx uses, as described here.

With the new selector, the issue seems to be addressed site wide.

@wallacekelly-da thanks a lot for the fix.

With the new selector, the issue seems to be addressed site wide.
I wasn't able to verify that for myself. However, since this is theme-only change CI didn't update docs.daml.com because of https://github.com/digital-asset/docs.daml.com/issues/758

And indeed, after docs/2.10.0 got updated from another PR, the improvement materialized for that version. Very nice 😆


⚠ ClamAV has degraded performance

In e0f2936, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in 9b3f6b5.


[FEAT]: Bulk Create Box

Clear and concise description of the problem
⭐ Current Flow

👆 Click the flying pencil icon button to open the create box form
✍ Fill name, location, and image of the box
✅ Single box created!

This flow is so painful if we need to create a lot of boxes.
Suggested solution
🤔 Suggested Flow

👆 Click the flying pencil icon button to open the box creation menu
👆 Select single or bulk box creation
🌿 If single box creation is selected, use the current flow
🌿 If bulk box creation selected, open a bulk box creation form
✍ Fill in how many boxes we need to create
✅ The boxes created!
🖨 Download the QR code document for the boxes

In this solution, we only need to print the QR Code once and focus on recording the items inside the boxes.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Closed by today commit


Symfony 3 support ?

Does this Bundle work with Symfony3 ?

We are using it in an SF3 application, yes.


Update styles.css

Added the specifications for the card

Added the specifications for the card

Well done!


Feature/signup

I tried to make a pull request in fork repo, but did it by mistake. Just ignore it. :(


Why does RequestToken return Null all the time ??

Anyone else experience this ??  I saw another post about adding the Content Type, but how is that done?

Not sure that my answer will be useful for you, but I had the same problem. In my own project RequestToken returns OAuthResponse with null-value properties. I cloned this repo and run it locally, and found that RequestToken works fine! I'm really confused. After that I recreate RequestToken locally and used it directly (with the same config) instead of auth.RequestToken and now I got success!

Apparently there is something about the IP being blocked from Instagram when making too many invalid calls, I'll need to try it:
#115

So in the end, I tried it on another device to obtain a different IP, and same result, RequestToken returns OAuthResponse with null-value properties.
I don't know MVC, i'm using this library in a UWP project.

Did you tried to implement your own RequestToken method in your project (copy from this repo) ? I have no ideas why it works, but it does.

What I'm noticing is the problems begin before I even get to the RequestToken, it's during the Authentication flow. So I did just that with a few other changes. I start the login process with the WebAuthenticationBroker as such:
	var scopes = new List<OAuth.Scope>();
	scopes.Add(InstaSharp.OAuth.Scope.Basic);

	var link = InstaSharp.OAuth
					.AuthLink
					(
						_config.OAuthUri + "authorize",
						_config.ClientId,
						_config.RedirectUri,
						scopes,
						InstaSharp.OAuth.ResponseType.Token
					);

	var webAuthResult = await WebAuthenticationBroker
									.AuthenticateAsync
									(
										WebAuthenticationOptions.None,
										new Uri(link)
									);

	switch (webAuthResult.ResponseStatus)
	{
		case WebAuthenticationStatus.Success:
			return true;

		case WebAuthenticationStatus.UserCancel:
			return false;

		case WebAuthenticationStatus.ErrorHttp:
			return false;

		default:
			return false;
	}

So all begins well, the user gets a popup which asks for their login. Once I enter the credentials and Login, I receive is a Http 400. Here is a screenshot of the error when clicking the login in the popup:

ARe you using version 2.0.4?

@fujiy  Thanks Felipe!
I'm going to try it as soon as I can, unfortunately I can't upgrade to 2.0.5 since I'm using InstaSharp in a PCL project and the cryptography dependency is not PCL-ready.
I'll look for a workaround to the issue.

Ok, that explains it  :)  thanks for the quick reply.
And just for information purposes, this was the error. If I do find a workaround, I'll post it here  :)
"Could not install package 'System.Security.Cryptography.Algorithms 4.3.0'. You are trying to install this package into a project that targets 'Windows,Version=v8.1', but the package does not contain any assembly references or content files that are compatible with that framework."

Unfortunately  Windows 8.1 doesn't support Net Standard 1.3: https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/

I think I'll need to go back to Bouncy Castle

Done

@fujiy  2.0.6 working perfectly!!   Thanks!!  :)


Update scalafmt-core to 3.4.3

Updates org.scalameta:scalafmt-core from 3.3.3 to 3.4.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report

Merging #217 (6b90317) into main (e2aef5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   70.51%   70.51%
=======================================
  Files           4        4
  Lines          78       78
  Branches        4        4
=======================================
  Hits           55       55
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2aef5c...6b90317. Read the comment docs.


JSON serializer for task graphs

First step of #92
Please start with the new notebook to read about the reasoning behind the format and see examples.

Why are data nodes serialized? I thought we just want to serialize the task graph (which may eventually include serializing the input data, or a hash thereof).

Why does visualize show them? Without the data nodes, it becomes harder to understand what a provider returns and how that relates to arguments of other providers. We would basically have to write the signature of providers into the nodes.

It is not clear why we would want special handling for param tables. Is the only reason a potential desire to reconstruct the same TaskGroup from the JSON? Otherwise I would feel that the special handling just overcomplicates things. I do not really see a need for handling this any different from "regular" providers.

What is a 'TaskGroup'?
table providers are handled the same as others. It is the data nodes that have special handling because they encode which table entry they represent. If this wasn't the case, we would have a lot of duplicate, e.g., float(int) nodes in the graph.

Why are data nodes serialized? I thought we just want to serialize the task graph (which may eventually include serializing the input data, or a hash thereof).

Why does visualize show them? Without the data nodes, it becomes harder to understand what a provider returns and how that relates to arguments of other providers. We would basically have to write the signature of providers into the nodes.

visualize is not about provenance. I am not saying serializing the result types is a bad idea, but then I thought it should be part of the 'compute' nodes, not represented as 'data' nodes. But if we would distinguish between 'input' nodes (which may get serialized values eventually) and 'data' nodes (values never serialized) that would be equivalent.

It is not clear why we would want special handling for param tables. Is the only reason a potential desire to reconstruct the same TaskGroup from the JSON? Otherwise I would feel that the special handling just overcomplicates things. I do not really see a need for handling this any different from "regular" providers.

What is a 'TaskGroup'?

TaskGraph

table providers are handled the same as others. It is the data nodes that have special handling because they encode which table entry they represent. If this wasn't the case, we would have a lot of duplicate, e.g., float(int) nodes in the graph.

Not an issue if my first item is taken into account.

visualize is not about provenance.

This doesn't answer my question. Why is it useful to show the types as separate nodes in visualize but not for provenance tracking?

But if we would distinguish between 'input' nodes (which may get serialized values eventually) and 'data' nodes (values never serialized) that would be equivalent.

What would be equivalent?

table providers are handled the same as others. It is the data nodes that have special handling because they encode which table entry they represent. If this wasn't the case, we would have a lot of duplicate, e.g., float(int) nodes in the graph.

Not an issue if my first item is taken into account.

Well, the special handling would be moved from data to provider nodes. But it would still be there.

visualize is not about provenance.

This doesn't answer my question. Why is it useful to show the types as separate nodes in visualize but not for provenance tracking?

Not sure why you don't see having the types in the visualization is useful. But computation wise, the graph of providers provides a full definition.

But if we would distinguish between 'input' nodes (which may get serialized values eventually) and 'data' nodes (values never serialized) that would be equivalent.

What would be equivalent?

Adding an extra attribute in a compute node saying "I am computing type X" is equivalent to adding a data node between this compute node and all dependent compute nodes.

table providers are handled the same as others. It is the data nodes that have special handling because they encode which table entry they represent. If this wasn't the case, we would have a lot of duplicate, e.g., float(int) nodes in the graph.

Not an issue if my first item is taken into account.

Well, the special handling would be moved from data to provider nodes. But it would still be there.

Why, how? I don't see the need for special handling. You'd just have the same compute node N times (all with a unique id).

Why, how? I don't see the need for special handling. You'd just have the same compute node N times (all with a unique id).

And identical return types. Or not easily computer-readable return types (Without special handling, the serialized type becomes, e.g., "builtins.float(builtins.int:0)" and that still has special handling in key_full_qualname)

Why, how? I don't see the need for special handling. You'd just have the same compute node N times (all with a unique id).

And identical return types. Or not easily computer-readable return types (Without special handling, the serialized type becomes, e.g., "builtins.float(builtins.int:0)" and that still has special handling in key_full_qualname)

What is the problem with identical return types? You will get N data nodes (all with a unique id).

Why, how? I don't see the need for special handling. You'd just have the same compute node N times (all with a unique id).

And identical return types. Or not easily computer-readable return types (Without special handling, the serialized type becomes, e.g., "builtins.float(builtins.int:0)" and that still has special handling in key_full_qualname)

What is the problem with identical return types? You will get N data nodes (all with a unique id).

Not when you merge data and provider nodes.  So you know they represent different things, but cannot tell what they represent.

Why, how? I don't see the need for special handling. You'd just have the same compute node N times (all with a unique id).

And identical return types. Or not easily computer-readable return types (Without special handling, the serialized type becomes, e.g., "builtins.float(builtins.int:0)" and that still has special handling in key_full_qualname)

What is the problem with identical return types? You will get N data nodes (all with a unique id).

Not when you merge data and provider nodes.

I think that discussion is orthogonal and does not change anything.

 So you know they represent different things, but cannot tell what they represent.

So? I thought this is about provenance. If you look at an arbitrary non-param-table graph you also have no idea what it represents, without knowing which input data was used, do you?

So? I thought this is about provenance. If you look at an arbitrary non-param-table graph you also have no idea what it represents, without knowing which input data was used, do you?

But the graph has all graph-related info. Yes, parameters are missing, this was part of the requirements for this task. But with tables, even the graph is incompletely specified:
graph LR
A1("A(Label)") --> B1("B(Label)") --> C
A2("A(Label)") --> B2("B(Label)") --> C
A1("A(Label)") --> D

Which part of the param table is used by D and which by C?
To be honest, I don't fully understand your objection. Which part of the information in teh graph should be omitted?

But the graph has all graph-related info. Yes, parameters are missing, this was part of the requirements for this task. But with tables, even the graph is incompletely specified:
[...]
Which part of the param table is used by D and which by C?

The value "1" from the table is used by D, both "1" and "2" are used by C? "1" and "2" are "input" nodes.
graph LR
1-->A1
2-->A2
A1("A") --> B1("B") --> C
A2("A") --> B2("B") --> C
A1("A") --> D

But the graph has all graph-related info. Yes, parameters are missing, this was part of the requirements for this task. But with tables, even the graph is incompletely specified:
[...]
Which part of the param table is used by D and which by C?

The value "1" from the table is used by D, both "1" and "2" are used by C? "1" and "2" are "input" nodes.
graph LR
1-->A1
2-->A2
A1("A") --> B1("B") --> C
A2("A") --> B2("B") --> C
A1("A") --> D

Those input nodes correspond to the p_table_cell nodes in the PR and are not regular parameter nodes. So would you preserve those but remove the index information from all dependent nodes? This would mean that you have to walk the graph to find that information.

But the graph has all graph-related info. Yes, parameters are missing, this was part of the requirements for this task. But with tables, even the graph is incompletely specified:
[...]
Which part of the param table is used by D and which by C?

The value "1" from the table is used by D, both "1" and "2" are used by C? "1" and "2" are "input" nodes.
graph LR
1-->A1
2-->A2
A1("A") --> B1("B") --> C
A2("A") --> B2("B") --> C
A1("A") --> D

  graph LR

1-->A1
2-->A2
A1("A") --> B1("B") --> C
A2("A") --> B2("B") --> C
A1("A") --> D

Those input nodes correspond to the p_table_cell nodes in the PR and are not regular parameter nodes. So would you preserve those but remove the index information from all dependent nodes? This would mean that you have to walk the graph to find that information.

Yes, absolutely! Remember that Sciline's parameter tables are just a convenient way of building task graphs. They do however have little to do with the resulting task graph and actual computation. As this task is about provenance and reproducibility (independent of Sciline), we have to avoid exposing Sciline "implementation details" in the JSON representation.
In fact I would be tempted to argue that a graph that was made without parameter tables "by hand" should result in the same JSON (modulo something related to the provider that makes the series).

Implemented a new schema with these changes:

no support for param tables
merged data and provider nodes
renamed type -> out
function nodes now encode the order of arguments


Fixed Login onKeyUp

On login page, pressing 'enter' triggers login.
Added onkeyup event handler on textfield instead of button.
Fixees #338

This fix works in principle, but we should trigger login when the onKeyUp event happens on the login button. Not the text field. I don't think a user would expect that hitting enter on the input field would cause them to log in. Usually that would cause them to move to a new field.


Profile does not save detail address info.

Service provider profile> Your Location> when i set my location as a provider (Ms Clean) on my profile does not save detail address info. despite tapping save button, only Governate level also does not save public and distance when i set up them up too.

@iamonuwa Please check all profile data, I think it happens with all the data on the account profile page.

The issue is that the select inputs are not populated on page load.


pilot-discovery periodically reads server disk data, resulting in high IO

Bug Description
I deployed istio on the k8s cluster, using istiooperator.
Istiooperator is configured as follows:
spec:
  components:
    ingressGateways:
    - enabled: true
      k8s:
        env:
        - name: ISTIO_META_OWNER
          value: kubernetes://apis/apps/v1/namespaces/istio-system/daemonsets/istio-ingressgateway
        nodeSelector:
          istio-ingressgateway: "true"
        overlays:
        - kind: Deployment
          name: istio-ingressgateway
          patches:
          - path: kind
            value: DaemonSet
          - path: spec.template.spec.hostNetwork
            value: true
          - path: spec.template.spec.dnsPolicy
            value: ClusterFirstWithHostNet
          - path: spec.strategy
        resources:
          limits:
            cpu: "2"
            memory: 2Gi
          requests:
            cpu: "2"
            memory: 2Gi
      name: istio-ingressgateway
    pilot:
      k8s:
        nodeSelector:
          istio-ingressgateway: "true"
  meshConfig:
    accessLogEncoding: JSON
    accessLogFile: /dev/stdout
    defaultConfig:
      tracing:
        sampling: 1
    discoverySelectors:
    - matchLabels:
        istio-discovery: "true"
    enableTracing: true
  profile: default

The status of the deployment is as follows:
# kubectl get po -n istio-system -owide
NAME                         READY   STATUS    RESTARTS       AGE    IP               NODE                         NOMINATED NODE   READINESS GATES
istio-ingressgateway-27gcd   1/1     Running   1 (2d4h ago)   2d5h   <IP_ADDRESS>      k8snode24   <none>           <none>
istio-ingressgateway-42q59   1/1     Running   0              2d5h   <IP_ADDRESS>      k8snode25   <none>           <none>
istio-ingressgateway-kfs7n   1/1     Running   0              2d5h   <IP_ADDRESS>      k8snode28   <none>           <none>
istio-ingressgateway-kj4k6   1/1     Running   0              2d5h   <IP_ADDRESS>      k8snode27   <none>           <none>
istio-ingressgateway-qnzbn   1/1     Running   0              2d5h   <IP_ADDRESS>      k8snode26   <none>           <none>
istiod-7695b997c9-q2vbp      1/1     Running   0              4d5h   <IP_ADDRESS>   k8snode27   <none>           <none>
istiod-7695b997c9-tbbwm      1/1     Running   0              8d     <IP_ADDRESS>   k8snode26   <none>           <none>
istiod-7695b997c9-wtjrb      1/1     Running   1 (8d ago)     8d     <IP_ADDRESS>   k8snode25   <none>           <none>

But the pilot-discovery on the k8snode26 node is often very high iowait.This node only deploys istio-ingressgateway, calico, kube-proxy, containerd, kubelet.
Version
$ istioctl version
client version: 1.12.3
control plane version: 1.12.3
data plane version: 1.12.3 (58 proxies)

#  kubectl version --short
Client Version: v1.22.6
Server Version: v1.22.6

# containerd --version
containerd containerd.io 1.6.6

# calico version  v3.23.1

# iptables --version
iptables v1.4.21

# uname -a
Linux k8snode26 4.20.13-1.el7.elrepo.x86_64 #1 SMP Wed Feb 27 10:02:05 EST 2019 x86_64 x86_64 x86_64 GNU/Linux

Additional Information
I used some tools and found the following information, but I don't know what happened.
When using the top command, you can see that wa is very large:

At this time, using iotop, you can see that the disk read speed of pilot is 140M/s:

Then use the pidstat -dt -p 17544 1 command to see which child thread frequently operates io:

Finally, through perf trace -t 17558, the 17558 thread was found and the following information was printed:

After the server IO is raised, the information of rt_sigreturn will be printed, but I don't know what the error is.

@dotbalo similar issue not found on any other node?

So I just stumbled on this in my graphs today.... and i'm wondering if it's related to this!

if we capture htis maybe we can see what file specifically? it shouldn't be much (other than logs which are to stdout, but eventually end up on the disk via containerd). https://serverfault.com/questions/224629/see-what-files-are-being-written-to-like-iotop-but-for-files-not-processes maybe helps fine this


Consolidate utility testing functions where possible

As we've discussed synchronously many times, there's quite a bit of redundant testing utility functions. We should consolidate where possible. If its not possible due to cyclic imports, then we should consider putting those tests in their own package.
related to #829

@evan-forbes I can work on this issue. Can you point me to the files to get started?

A candidate sub-task for this issue is to delete the duplicate definitions of randomValidNamespace:

https://github.com/celestiaorg/celestia-app/blob/27632ddc804fbf7655ef5ba941eb4f346c539be9/testutil/payment/testutil.go#L134
https://github.com/celestiaorg/celestia-app/blob/e18de882c3de4ee92e4632af21d4007c1b642adb/app/test_util.go#L178
https://github.com/celestiaorg/celestia-app/blob/8f4fd811b19b8539bfd9e77e83f23518ec702c88/app/test/block_size_test.go#L299
https://github.com/celestiaorg/celestia-app/blob/906fdf74f871f13d3fe0c632dfda95db494521ee/pkg/prove/proof_test.go#L290
https://github.com/celestiaorg/celestia-app/blob/07b5bb4a6dd905166c33b3434895cd292501f100/testutil/utils.go#L15

The last function definition is the most preferred because it accounts for the parity and tail padding namespaces. Note: the duplicate functions are defined in different packages so the last function may need to be extracted to a package that can be imported by all usages of the duplicate definitions.

Spun out https://github.com/celestiaorg/celestia-app/issues/836 in-case @evan-forbes has other ideas for what this issue should include.

another instance per this https://github.com/celestiaorg/celestia-app/pull/1991#discussion_r1243461687

Closing this b/c it's not actionable. Please re-open or create a new issue with more specific examples of the redundant testing utilities that need consolidation.


Handling padding 0

Hi, i'm trying to use a pretrained model and replace all Conv2D with CircularConv2d. How should I handle cases where padding for Conv2D is 0? Setting cpad=(0, 0, 0, 0) to CircularConv2d crashes the code. Thanks

Nevermind, I had to leave places with 0 padding with the original Conv2D


Adds basic function description documentation to codes

Should just be code comments. Testing required as I am unable. Should close issue #27

Thoughts about using JSDoc or something standard?

Closing without merge. Please do this in JSDoc.


Mark pony_ctx as readnone in LLVM IR

This avoids redundant calls in generated code after inlining. pony_ctx always returns the same pointer from within a single behaviour so this is safe.

I admit that I'm still getting a handle on the LLVM semantics, but it seems like readnone isn't quite right, given that it does read from a thread-local static var  - maybe inaccessiblememonly is more accurate?

I think readnone is right here. Basically, it tells the compiler that it doesn't need to call pony_ctx over and over again in a single behaviour, including between calls to the runtime. The "user part" of a behaviour can't witness any changes to the context since its content either doesn't change or comes back to its original state atomically in runtime calls (or successive calls generated by the compiler). So I'll say a context is logically immutable inside of a behaviour and this is compliant with the LLVM documentation saying the function must not access mutable state.

I'll let @sylvanc have the last word on what is correct - I don't think I'm qualified to approve or deny this based on what I know right now.

Nice! Strange as it seems, readnone is indeed the right LLVM semantic here. Thanks @Praetonus !


i18n - in app/models/* part 4

Added gettexts if needed from app/models/miq_provision_workflow.rb to app/models/miq_snmp.rb

:+1:


Additional deletions (from the statscore namespace)

Codecov Report
Attention: Patch coverage is 0% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 5.28%. Comparing base (47639c0) to head (23258e1).

Files
Patch %
Lines

...s/StatsCore/Distributions/EmpiricalDistribution.cs
0.00%
17 Missing :warning:

...ailDiff/Statistics/StatsCore/Distributions/Beta.cs
0.00%
8 Missing :warning:

...sis/SailDiff/Statistics/StatsCore/Combinatorics.cs
0.00%
7 Missing :warning:

...StatsCore/Distributions/NonCentralTDistribution.cs
0.00%
7 Missing :warning:

...ics/StatsCore/Analysers/MannWhitneyTestSailfish.cs
0.00%
6 Missing :warning:

...ogorovSmirnovTestSailfish/KolmogorovSmirnovTest.cs
0.00%
5 Missing :warning:

source/Sailfish/Execution/TickAutoConverter.cs
0.00%
5 Missing :warning:

.../StatsCore/Analysers/TwoSampleKolmogorovSmirnov.cs
0.00%
4 Missing :warning:

...StatsCore/Distributions/MannWhitneyDistribution.cs
0.00%
3 Missing :warning:

...lDiff/Statistics/StatsCore/Analysers/TwoSampleT.cs
0.00%
2 Missing :warning:

... and 11 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #161       +/-   ##
==========================================
- Coverage   53.54%   5.28%   -48.27%
==========================================
  Files         325     243       -82
  Lines       10696    8520     -2176
  Branches     1408    1168      -240
==========================================
- Hits         5727     450     -5277
- Misses       4641    8057     +3416
+ Partials      328      13      -315

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Task 12,13,14,15,16,17

SourceCode/2023/Oct2023/Basics/Padmavathykarra/Task12/project.json
Review Comments:
NoFile:

Your project needs an Automation Hub URL defined as per your organization standards. Please use the "Project Settings" to add the missing link.

I noticed that you have included the UiPath.Testing.Activities and UiPath.UIAutomation.Activities packages, but they are not utilized in the code. Removing unused packages can help improve the execution time.

Main.xaml:

It seems the Log Message activity isn't used in the Main workflow. They are pretty important since they aid in understanding the flow, especially during the maintenance phase and when an error pops up.

I see the activity names are defined multiple times. For the For Each, Body, If, and Assign activities, the names are used more than once. It's a good practice to have unique names for activities. This makes it easier to understand what each one does. Please avoid duplicate names.

Some of your activities have default names. Consider renaming them to something more descriptive to help anyone skimming through the code understand what they do in a jiffy.

Scores:
Code completion: 1.5/2
Execution: 1.5/2
Annotations and comments: 0.5/1
Suggested

SourceCode/2023/Oct2023/Basics/Padmavathykarra/Task14/project.json
Github PR comments:
For Sequence.xaml file:

Please use Log Message activities in the workflow sequence. It's helpful for maintenance and error tracing.
DataTable variables should start with dt_ prefix. Please rename ExtractDataTable to dt_ExtractDataTable.
Add a descriptive name to replace the default name for Use Application/Browser activity.
Add a descriptive name to replace the default name for Extract Table Data activity.

For NoFile:

An Automation Hub URL is required. Add this URL in Project Settings.
Remove unused dependency packages UiPath.Mail.Activities and UiPath.Testing.Activities to speed up process execution.

For Main.xaml file:

Please use Log Message activities in the Main workflow. It's helpful for maintenance and error tracing.
DataTable variables should start with dt_ prefix. Please rename ExtractDataTable and FilterDataTable to dt_ExtractDataTable and dt_FilterDataTable respectively.

Score:

Code completion: 1/2. Code needs improvement in using naming conventions and removing unused packages.
Execution: 1/2. Add

SourceCode/2023/Oct2023/Basics/Padmavathykarra/Task15/project.json
Code Completion: 1.5/2 - Your code seems completed but there are some dependencies that are not used in your project, this has an impact on code completion score. Please remove them for better scoring.
Execution: 1/2 - Activities like WriteLine shouldn't be in final version of your code, also, remember to use Logged Messages to enable debugging in future as it helps in understanding the code flow.
Annotations and comments: 0.5/1 - Make sure activities and variables have descriptive names as much as possible. This will help you and others to understand the code better.
Fixes:
In 'NoFile':

Define your Automation Hub URL in "Project Settings".
Try to remove unused packages such as UiPath.Mail.Activities, UiPath.Testing.Activities, UiPath.UIAutomation.Activities, to speed up process execution.

In 'Main.xaml':

Include 'Log message' activities in your workflow, they are key for debugging and maintenance.
Replace 'Write Line' activity to 'Log Message' for debugging.
Rename your 'Assign' activities, avoid duplications, and use a unique and clear name.
Add 'dt_' prefix for variable 'Output1'.
5

SourceCode/2023/Oct2023/Basics/Padmavathykarra/Task16/project.json
NoFile:

Define your project's Automation Hub URL in the 'Project Settings' as per your organization's requirement.
Remove the unused packages UiPath.Mail.Activities, UiPath.Testing.Activities, and UiPath.UIAutomation.Activities. This will reduce the process execution time.

Main.xaml:

Use 'Log Message' activities in your workflow. They make it easier to understand the process path, making maintenance easier and quickly identifying errors.
The variable 'Result_1' doesn't follow the naming convention. Correct it.
The 'Result' variable should have the 'dt_' prefix as it's a DataTable.
The 'Output Data Table', 'Build Data Table', and 'Message Box' activities still have their default names. Update them to make their functions clearer.

Scores Based on Criteria:

Code Completion: 1/2
Execution: 2/2
Annotations and Comments: 0/1.

SourceCode/2023/Oct2023/Basics/Padmavathykarra/Task17/project.json
Posted to NoFile:

1. You need to define an Automation Hub URL for your project. This can be done in your project settings.
2. Noticed that the dependency package, UiPath.Mail.Activities, is not being used. It's beneficial to remove any unused packages to help speed up the process execution time.
3. Another unused package, UiPath.UIAutomation.Activities, was found. Again, removing unused packages can help improve your process execution time.

Score: Code Completion: 1.5 / 2, Execution: 1.5 / 2, Comments: 0.5 / 1

Posted to Main.xaml:

1. It looks like you haven't used the Log Message in your workflow. These can be very valuable for understanding the flow and identifying any sources and causes of errors.
2. The variable 'Result_1' doesn't follow the naming convention for DataTable. For these, you want to use the prefix 'dt_'.
3. Continuing on the topic of naming conventions, the variable 'Result_1' does not match the set pattern. Remember to follow the naming convention for clarity and consistency.
4. Noticed that the activity 'Generate Data Table From Text' has a default name. Try giving your activities more

@Padmavathykarra
Task -12
Code verified. Default activity names

Task -14
Code verified. Default activity names

Task -15
Code verified. Default activity names

Task -16
Code verified. Default activity names

Task -17
Code verified. Default activity names


Start new task: DownwardAPIVolumeFile.

This change is

@saad-ali, ping

Good stuff. Looks like you need to rebase. Otherwise:
/lgtm
/approve


Recaptcha for contact form

adding flask-recaptcha to app

added config values for captcha (connects to<EMAIL_ADDRESS>admin panel)

adding recaptcha to /contact page

only appears (and subsequently checks) if user is not logged in
if recaptcha cannot be verified on submit, reloads /contact page instead of attempting to send a contact message

Hello @OptimusRhine! Thanks for submitting the PR.

In the file portal/extensions.py, following are the PEP8 issues :

Line 155:1: E402 module level import not at top of file


[Payments] [zelcash] Insufficient funds (149.9998) to process payments (150); possibly waiting for txs.

Just wanted to test out getting a block of Zelcash and after finding the block it has been stuck on pending for quite some time. Any ideas?

z_gettotalbalance
  "transparent": "149.9998", "private": "0.00", "total": "149.9998"

getwalletinfo
 "walletversion": 60000, "balance":<PHONE_NUMBER>0, "unconfirmed_balance": 0.00000000, "immature_balance": 0.00000000, "txcount": 4, "keypoololdest":<PHONE_NUMBER>, "keypoolsize": 101, "paytxfee": 0.00000000

243/100 confirmations currently

coins/zelcash.json
   "name": "zelcash",  "symbol": "zel",  "algorithm": "equihash",  "requireShielding": true,  "txfee": 0.0001

in pool_configs/zelcash.json...
minConf = 10 minimumPayment = 1 maxBlocksPerPayment = 100

post full pool_configs/zelcash.conf(the pool config)

Config.json:
{
"logLevel": "debug",
"logColors": true,
"cliPort": 17117,

"clustering": {
    "enabled": true,
    "forks": "auto"
},

"defaultPoolConfigs": {
    "blockRefreshInterval": 0,
    "jobRebroadcastTimeout": 100,
    "connectionTimeout": 250,
    "emitInvalidBlockHashes": true,
    "validateWorkerUsername": true,
    "tcpProxyProtocol": false,
    "banning": {
        "enabled": true,
        "time": 600,
        "invalidPercent": 50,
        "checkThreshold": 500,
        "purgeInterval": 300
    },
    "redis": {
        "host": "<IP_ADDRESS>",
        "port": 6379,
        "password": ""
    }
},

"website": {
    "enabled": true,
    "host": "xx.xx.xx.xx",
    "port": 8084,
    "stratumHost": "xx.xx.xx.xx",
    "stats": {
        "updateInterval": 30,
        "historicalRetention": 14400,
        "hashrateWindow": 300
    },
    "adminCenter": {
        "enabled": true,
        "password": "password"
    },
    "tlsOptions" : {
        "enabled": false,
        "cert": "",
        "key": ""
    }
},

"redis": {
    "host": "<IP_ADDRESS>",
    "port": 6379
},

"switching": {
    "switch1": {
        "enabled": false,
        "algorithm": "sha256",
        "ports": {
            "3333": {
                "diff": 10,
                "varDiff": {
                    "minDiff": 16,
                    "maxDiff": 512,
                    "targetTime": 15,
                    "retargetTime": 90,
                    "variancePercent": 30
                }
            }
        }
    },
    "switch2": {
        "enabled": false,
        "algorithm": "scrypt",
        "ports": {
            "4444": {
                "diff": 10,
                "varDiff": {
                    "minDiff": 16,
                    "maxDiff": 512,
                    "targetTime": 15,
                    "retargetTime": 90,
                    "variancePercent": 30
                }
            }
        }
    },
    "switch3": {
        "enabled": false,
        "algorithm": "x11",
        "ports": {
            "5555": {
                "diff": 0.001,
                "varDiff": {
                    "minDiff": 0.001,
                    "maxDiff": 1,
                    "targetTime": 15,
                    "retargetTime": 60,
                    "variancePercent": 30
                }
            }
        }
    }
},

"profitSwitch": {
    "enabled": false,
    "updateInterval": 600,
    "depth": 0.90,
    "usePoloniex": true,
    "useCryptsy": true,
    "useMintpal": true,
    "useBittrex": true
}

}
zelcash.json
{
"enabled": true,
"coin": "zelcash.json",
"address": "t1.........",
"_comment_address": "a transparent address to send coinbase rewards to and to transfer to zAddress.",

"zAddress": "zc.............",
"_comment_zAddress": "a private address used to send coins to tAddress.",

"tAddress": "t1.....",
"_comment_tAddress": "transparent address used to send payments, make this a different address, otherwise payments will not send",

"walletInterval": 5,

"rewardRecipients": {

},

"paymentProcessing": {
"minConf": 10,
    "enabled": true,
    "paymentMode": "prop",
    "_comment_paymentMode":"prop, pplnt",
    "paymentInterval": 600,
    "minimumPayment": 1,
    "maxBlocksPerPayment": 100,
    "daemon": {
        "host": "<IP_ADDRESS>",
        "port": 16124,
        "user": "secret password",
        "password": "secret username"
    }
},

"tlsOptions": {
    "enabled": false,
    "serverKey":"",
    "serverCert":"",
    "ca":""
},

"ports": {
    "3040": {
        "diff": 0.05,
        "tls": false,
        "varDiff": {
            "minDiff": 0.04,
            "maxDiff": 16,
            "targetTime": 15,
            "retargetTime": 60,
            "variancePercent": 30
        }
    }
},

"daemons": [
    {
        "host": "<IP_ADDRESS>",
        "port": 16124,
        "user": "secret username",
        "password": "secret password"
    }
],

"p2p": {
    "enabled": false,
    "host": "<IP_ADDRESS>",
    "port": 19333,
    "disableTransactions": true
},

"mposMode": {
    "enabled": false,
    "host": "<IP_ADDRESS>",
    "port": 3306,
    "user": "me",
    "password": "mypass",
    "database": "zec",
    "checkPassword": true,
    "autoCreateWorker": false
}

}

"address": "t1.........",  == "tAddress": "t1.....", ?

Send 1 ZEL to your first t address in the config and see if it completes.

@c2h2
Not the same.
@zzzpotato
Trying this in a few moments.

@zzzpotato Does not appear to have fixed it. The pool shielded the payment from the exchange I purchased zelcash on and then continued to display the same error message for the block solved.

can be many problems, can you see your coin on the explorer? the 2 t-addresses

@c2h2
@zzzpotato
The problem has solved itself. After around 1800 confirmations it was accepted and I do believe sending the 1 coin to the first t-address was the trick. Is there something on the software side of things we could do to rid of this problem for good without having to send a coin?

@angona2 happened to me before, the trick is to pay some coins, but the root cause could be round off error or something wrong in the config.


Last button in the openshift flow

Last button in the openshift flow needs to present the user with some next steps that he can take. Instead of going back to the start / front page.

How does that work now? Is it a static text?

in the new almost everything is just static text

I like the old "after launch" page, can we keep that?

do you guys means having those screens in the new wizard?

@ia3andy next step for zip is already there the other is missing


fix: add wagtail-modeladmin as dependency

this is just a quick fix for https://github.com/jazzband/wagtailmenus/issues/459
The project should migrate to use wagtail snippets instead.

When I prepared #461 I didn’t add the new non-contrib version of ModelAdmin as a deployment requirement because if an older version of Wagtail was being used you would end up with both the contrib and non-contrib versions loaded; it seemed that delegating that choice to the developer made sense, and the installation documentation aligns with this.
Before hard-coding non-contrib ModelAdmin as a deployment requirement, it should be tested against pre-5.1 versions of Wagtail.
By February 2024 Wagtail 4.1 LTS will go out of support (see https://endoflife.date/wagtail) so I suggest that is the time to add non-contrib ModelAdmin as a deployment requirement, maybe as a minor or major release.

Hello! With #480, this PR will no longer be necessary. I'll be closing it for now. Still, @JanMalte , your help was appreciated!


fix typo in Throttle middleware httpAapp->httpApp

Deprecate method with typo and add new method with correction

Ouch, good catch and thanks for the PR. Since this is an issue in 0.23.x would you mind retargeting your PR to series/0.23? You will have to rebase and force-push.


isNaN parameter should be any (or unknown?)

According to the spec (see references below), isNaN() should be able to take any kind of value, which would be coerced into a number (using something like Number(value), which seems to make sense from my tests).
Forcing the parameter to be number breaks legacy code which relies on being able to pass string arguments to isNaN().
function f(value: string) {
  if (isNaN(value)) { // compilation error, but should be OK
    ...
  }
}

Removing the string type from the value parameter admittedly fixes the compilation error, but breaks the "no implicity any" rule.
References:

Spec: https://tc39.es/ecma262/#sec-isnan-number
Type declaration: https://github.com/microsoft/TypeScript/blob/f8083d291719c7671a876578234edea0ee33d624/lib/lib.es5.d.ts#L53

Please respect the issue templates for bug reports and feature requests.

Both issue templates urge you to first search for existing issues and asks for information (including the search terms you have used to search for existing issues).
This is a duplicate of:

#3947
#4002
#11414
#12302
#13227
#15173
#16427
#19153
#21065
#23464
#29607
#34609

Search terms used: isNaN

Huh. Fair enough. I see your point in alternate solutions.
However, the original reason for closing the first report of this issue is incorrect. https://github.com/microsoft/TypeScript/pull/3947#issuecomment-123558773

Reading more the ecmascript doc the argument is specified as Number.

"Number" in the spec is not the type, confusingly enough. It's the parameter name. That becomes evident when you read the algorithm for isNaN().
Regarding searching for issues and issue templates: I simply found the line of code I was looking for in the GitHub project file browser, clicked the little ellipsis next to the line number, and selected "Reference this in a new issue." There was no issue template. Sorry for that, I suppose. I typed "isNaN" in the title but none of the "similar issues" were the same as this one in my opinion. I don't mean to get defensive but I tried and sometimes mistakes happen.
Either way, I still feel like this is in violation of the spec, and that Number.isNaN() should be the one whose parameter should have type number.
Thank you for your consideration.

Ah, I was using issues search incorrectly, as were some of the others. However, I do think that both the issue reporters and issue closers are making misinterpretations of the ECMA spec. Number.isNaN and isNaN are both intended to be used on non-number values and should be typed accordingly, for the same reason that both === and == are valid operators in typescript. An example/counterexample is that isNan("NaN") is true while Number.isNan("NaN") is false, not because isNan is coercing "NaN" incorrectly, but because it is meant to coerce "NaN" as per the spec. I can see the benefit to code clarity of making ts users do toNaN(Number("NaN")) rather than rely on ECMA's ToNumber algorithm, but it would be more appropriate to make your own standard library to address those concerns rather than misrepresent ECMA's.

I don't know where this comment by "Aaron Paterson" went (removed?), but I thought it was very insightful:

I do think that both the issue reporters and issue closers are making misinterpretations of the ECMA spec. Number.isNaN and isNaN are both intended to be used on non-number values and should be typed accordingly, for the same reason that both === and == are valid operators in typescript. An example/counterexample is that isNan("NaN") is true while Number.isNan("NaN") is false, not because isNan is coercing "NaN" incorrectly, but because it is meant to coerce "NaN" as per the spec. I can see the benefit to code clarity of making ts users do toNaN(Number("NaN")) rather than rely on ECMA's ToNumber algorithm, but it would be more appropriate to make your own standard library to address those concerns rather than misrepresent ECMA's.


[onednn][tfg][remapper] Add FusedBatchNormEx fusion

This PR addresses :

FusedBatchnormEx fusion in TFGGrappler : Remapper.
FusedBatchNorm[$is_training] + ... -> _FusedBatchNormEx[$is_training]
(a) FusedBatchNorm + Activation
(b) FusedBatchNorm + SideInput + Activation
only supported activation is Relu

Fix FusedConv2D attributes to align with latest changes in FusedConv2D kernel

@penpornk Just a kind reminder to get this PR reviewed.

Thank you @ChiaHungDuan for reviewing this. I have addressed your comments, can you take a look ?

@ChiaHungDuan Thank you for reviewing.
@penpornk can you take a look when you get chance ? thank you.

@penpornk, I have done the review and given that @rdzhabarov is unavailable for the review recently. Can you help with the final review and approve it?
Thanks

Hi @penpornk Can you please take a look on this PR ? Thank you!

@penpornk Just a gentle reminder to review this PR

The added test failed internally, so I don't think this PR will make it into TF 2.12. But I'll follow up on this with the tfg team soon. Sorry again for the long delay!

Thank you! Please, fix the .mlir test and should be good to go, unless there are some new failures there.

@rdzhabarov @penpornk I have addressed the comments and made the necessary changes. Could you please review the PR? Thanks!

Thank you @kanvi-nervana for closing on the review comments
@penpornk, kind reminder to take a look at this PR ?


CMake: SCA: Cppcheck finds no defects when including <zephyr/kernel.h>

Bug description
When running static analysis through CodeChecker support in the build system (-DZEPHYR_SCA_VARIANT=codechecker), Cppcheck fails to analyze the code.
Found on 3.4, but also verified to fail in 3.5.
To Reproduce
Steps to reproduce the behavior:

Introduce some undefined behaviour construct (for instance, zero-division) in for example zephyr/samples/hello_world/src/main.c
west build -b qemu_x86 -- -DZEPHYR_SCA_VARIANT=codechecker
The defect is detected
Include <zephyr/kernel.h> at the top of the source file
Build again (west build), and no defect is found for the source file containing the issue

Expected behavior
Native integration of static code analysis should work when including Zephyr headers. Otherwise, it offers no functionality for real projects
Impact
I can temporarily get static code analysis with a workaround using a script that removes zephyr/include from the list of include paths (-I parameter) for the call to cppcheck executable
Environment (please complete the following information):

OS: Linux
Toolchain (Zephyr SDK, tested with both arm-zephyr-eabi and x86_64-zephyr-elf)
v3.5.0 (a6eef0ba3755f2530c5ce93524e5ac4f5be30194)

Additional context
I have tried running CodeChecker analyze with the same arguments set by the build system. Then, when I omit the Cppcheck option --suppress=preprocessorErrorDirective, error #error "Invalid/unknown toolchain configuration" is raising in zephyr/include/zephyr/toolchain.h. When <zephyr/kernel.h> is not included in sample source file, probably zephyr/toolchain.h gets never included, because even removing --suppress=preprocessorErrorDirective, this #error is not thrown, performing the static code analysis as expected.
Ccing @pdgendt

For the Cortex-M I am dealing with, in order to prevent cppcheck from triggering the #error directives that raise in zephyr/toolchain.h, zephyr/toolchain/gcc.h, zephyr/sys/util.h, zephyr/arch/arm/aarch32/error.h, and zephyr/kernel.h these are the definitions I need to provide as arguments to the analyzer.
-D__GNUC__ -D__BYTE_ORDER__=1234 -DCONFIG_ARM -D__CHAR_BIT__=8 -D__SIZEOF_LONG__=4 -D__SIZEOF_LONG_LONG__=8 -DCONFIG_ARMV7_M_ARMV8_M_MAINLINE -DCONFIG_NUM_COOP_PRIORITIES=16 -DCONFIG_NUM_PREEMPT_PRIORITIES=15

They can be placed in a file to let CodeChecker analyze forward them to cppcheck with option --cppcheckargs. That can be added to the input arguments in https://github.com/zephyrproject-rtos/zephyr/blob/a6eef0ba3755f2530c5ce93524e5ac4f5be30194/cmake/sca/codechecker/sca.cmake#L22 so I will probably try to figure out how to generate automatically the file with the definitions, depending some of them from the compiler type, architecture or kernel priorities configuration

-D__GNUC__ -D__BYTE_ORDER__=1234 -DCONFIG_ARM -D__CHAR_BIT__=8 -D__SIZEOF_LONG__=4 -D__SIZEOF_LONG_LONG__=8 -DCONFIG_ARMV7_M_ARMV8_M_MAINLINE -DCONFIG_NUM_COOP_PRIORITIES=16 -DCONFIG_NUM_PREEMPT_PRIORITIES=15

They can be placed in a file to let CodeChecker analyze forward them to cppcheck with option --cppcheckargs. That can be added to the input arguments in

Thanks @alfonsoespinosa for the investigation, it does look like the generated Kconfig symbols are not taken into account? Is it possible that cppcheck isn't including the generated autoconf.h file?

Thanks @alfonsoespinosa for the investigation, it does look like the generated Kconfig symbols are not taken into account? Is it possible that cppcheck isn't including the generated autoconf.h file?

It's not being added to the command line arguments by CodeChecker analyze, but indeed that is the purpose of cppcheck option --include:
--include=<file>
                         Force inclusion of a file before the checked file. Can
                         be used for example when checking the Linux kernel,
                         where autoconf.h needs to be included for every file
                         compiled. Works the same way as the GCC -include
                         option.

So it could be also added from CodeChecker analyze in the file passed with --cppcheckargs, and at least the 3 Kconfig-related missing defines would be solved.
Bad news is that doing this causes a really weird collateral damage:
zephyr/include/zephyr/devicetree.h:4231:0: error: failed to expand '_EXC_IRQ_DEFAULT_PRIO', Invalid ## usage when expanding 'DT_CAT3'.

We have bumped to Zephyr 3.5 and the behaviour changes slightly. The workaround in my previous comment is not working anymore. Apart from now having to define manually also CONFIG_CPU_CORTEX_M (otherwise preprocessor fails here), there are a couple of __ASSERT that do not work in the Memory Management Internal APIs header file (in this case probably an issue with Nordic's porting).
I will try to catch up to 3.5 and then later try to work out something for newer versions

Getting back to this on v3.5.0, cppcheck is giving
error: failed to expand '__ASSERT', it is invalid to use a preprocessor directive as macro parameter [preprocessorErrorDirective] #if CONFIG_SRAM_BASE_ADDRESS != 0
here and here in include/zephyr/sys/mem_manage.h. One possible solution is to put the preprocessor directive outside, conditionally defining some macro that later would be used in the __ASSERT(), like this diff does.
There is later an error: failed to expand '_EXC_IRQ_DEFAULT_PRIO', Invalid ## usage when expanding 'DT_CAT3': Unexpected token ')' [preprocessorErrorDirective] here in include/zephyr/arch/arm/cortex_m/exc.h, that seems to be a cppcheck bug about failing to handle ## in macro definitions: https://github.com/danmar/simplecpp/issues/228

No news about this? Having trouble checking my projects.


Fill in the middle syntax request

Hello,
I have been trying to get the inline coding suggestions to work. However, I keep getting an error (Status code: 422, Unprocessable entity). Would you be able to share the format of the request (with JSON payload)?
Thanks

Here is the code that sends the fill in the middle request -> https://github.com/mzbac/wizardCoder-vsc/blob/main/src/WizardCoderInlineCompletionItemProvider.ts#L56

Thanks for sharing the line - I had checked that. But for some reason it still doesn't seem to work. But one thing to point is that I am not running the API locally, instead I am pointing at HF API - https://huggingface.co/WizardLM/WizardCoder-Python-34B-V1.0 model.


Request: Add Watched section

Can you also add cmore.fi? And watched tab would be nice also, so can delete watched content from own cmore account. Thanks alot.

Hi!
cmore.fi uses a different API (at least for the login process) and adding support for that would be too much of a hassle. See #1 for more info.
I'll look into adding the Watched section.

Oh damn. Then its useless for me because im from finland. Anyway, you doing good work, keep it going!


Add setup miniconda

uses an adapted setup_miniconda script from the APN-blueprint

launch jenkins

Closing because Jenkins / miniconda setup is now being taken care of in https://github.com/C2SM/icon-vis/pull/31


Pattern for supporting additional Equinix APIs

Description
Equinix provides several APIs not represented in this Terraform provider.  This issue body describes a pattern for adopting the Equinix APIs that have not been implemented in this provider including future revisions to existing APIs. To codify this design, documentation should be added to the provider readme that describes the resource name pattern.
Today, Equinix APIs are offered in the following format:
https://api.equinix.com/{service}/{version}/ (with some exceptions at https://api.equinix.com/{version}/{service})
Compatibility between versions is in no way guaranteed, these versions typically represent a major API revision in semver parlance.  This is most evident in the differences between ecx/v2 and ecx/v3 service revisions.
Terraform providers "bridge Terraform Core and their respective target APIs". It does not benefit Terraform users or Terraform provider authors to invent translation layers and features that do not exist in the API.  Terraform providers should not offer magic. Doing so creates domain logic tightly controlled in the Terraform provider. This project, the Terraform provider, does not have the authority to dictate how the Equinix APIs work. Changes in the upstream APIs can upheave any of the underpinnings of magic interfaces (as we have seen with the ecx_l2_connection_accepter resource #64).
The most faithful representation of the Equinix API in Terraform is one that matches the services, endpoints, and attributes of the upstream API and must include versioned resources:
equinix_ecxv2_{endpoint}
equinix_ecxv3_{endpoint}
equinix_fabricv4_{endpoint} https://developer.equinix.com/docs/fabric-apis-v4
equinix_metalv1_{endpoint} (currently offered by the https://registry.terraform.io/providers/equinix/metal/latest provider)
This approach will remove the fragility present in today's resource structure.  Another benefit of this format is that some APIs will be EOLd with alternative APIs being introduced with competing functionality.  The fabric service token (fabricv4) API offers an improved experience to features of the ecxv2 API. Along the way, the service and API were reorganized and the feature appears under a new name. It would be confusing to offer Fabric v4 features under an ecx name.
There is precedent for this format in other providers, including AWS: https://registry.terraform.io/providers/hashicorp/aws/latest/docs.  In the AWS provider, versioning does not appear planned for in Terraform resource names so we see confusing patterns, including: aws_foov2, aws_foo_v2, and aws_foo vs aws_otherfoo.  This provider will benefit from adopting a pattern early and predictably.
I do not believe that it is necessary to rename the existing unversioned resource names (equinix_ecx_* ). These resources will eventually be retired with their APIs and be deprecated and removed from the Terraform provider. In the case where these APIs are long-lived, we may never need to introduce a versioned successor resource.  We trade some convenience of consistent naming with backward compatibility. On the other hand, renaming resources to fit the new naming pattern is also possible and the process is well documented: https://www.terraform.io/docs/extend/best-practices/deprecations.html#provider-data-source-or-resource-rename.
Alternatives considered:

ecx\_{endpoint} (independent ECX provider, v2 and v3): Too many redundant provider configuration blocks would be needed. Any opportunity to share API connection (rate limit throttling) handling would be lost.
Deprecating old resource patterns in favor of new resource patterns within the same resource name: This is problematic because both variations of the resource may be valid at the same time (v2 and v3 ECX APIs may coexist).  Resource operations like create/read/update would need to make versioned branches and consider competing formats on the same field name between versions (name or id could be a common field name with entirely different constraints of formats between versions).
Changing the upstream API to offer a single long-lived backwards compatible service version per service: This is outside the scope and authority of the Terraform provider.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

https://www.terraform.io/plugin/sdkv2/resources/state-migration#terraform-v0-12-sdk-state-migrations may also play a role, allowing Terraform to accept old configuration and internally upgrade/convert the state to match newer APIs.


cmd/go: include source dir in cache key when ${SRCDIR} is present in cgo header

What I did:

have a project including cgo headers using ${SRCDIR}
move that project to a new directory
build

Result:
ld: warning: directory not found for option '-L/Users/josh/...redacted...
The redacted directory is the previous directory pointed to by the ${SRCDIR} directive in the cgo sources.
After a go clean -cache, the error disappeared.
I suspect that cmd/go's caching may be too effective here. It probably doesn't take into account the absolute path containing the project, but it may need to when the ${SRCDIR} cgo directive is present.
cc @bcmills @jayconrod

When this is fixed, we should also test with -trimpath. When -trimpath is passed, most paths are not included in the cache key, but I think ${SRCDIR} needs to be there in any case.

Moving to backlog milestone.


UI randomly reorders the Project card view

Description
Visit the kargo root page (e.g. https://kargo.demo.akuity.io/), then click refresh a bunch of times. Project list will reorder randomly.
Version
v0.5.0

Duplicate of #782


add task counts to HighLevelGraph and Layer html reprs

[x] Closes #8497
[x] Tests added / passed
[x] Passes pre-commit run --all-files

I am simply passing the len. Is this okay?
Example:
arr = da.ones(shape=(100, 100), chunks=[5,10])
arr2 = da.ones(shape=(100, 100))
res = arr.dot(arr2)

Can one of the admins verify this patch?

add to allowlist

Thanks a lot for the detailed explanation @ian-r-rose! I was suspecting that this might not be the right approcach without knowing why exactly (was thinking that this might force some unwanted computation). I will update the PR according to your suggestion.

I have updated to use:
for layers: get_output_keys
for graph: get_all_external_keys which seems to call get_output_keys for each layer.
Updated example:

@ian-r-rose Can you take another look here when you get a chance?

I also have another concern unrelated to this discussion. I just want to make sure that we are not doing anything that will harm the user experience. According to #8570 get_all_external_keys could cause memory problems (i.e. generation of billions of keys).

At least for get_all_external_keys(), the set is cached, so it should be safe to call it more than once: https://github.com/dask/dask/blob/bd8e8dc3f1329e7f9ef24072479729d9effeb6ad/dask/highlevelgraph.py#L772
I would say that the intention of get_all_external_keys() is that it is fairly cheap to call. So using it here would not be a misuse of the API. But, as you point out, there are some issues with the design of HighLevelGraph algorithms that make it not as cheap to manipulate as intended. To my mind, that's something that will need to be addressed in the short term, though I don't think we need to do it here. Any refactoring of the highlevelgraph cull operation will need to have something that allows you to reason about how "big" each graph is, and it should be easy to update the repr here should we need to.
TL;DR, I think this is fine, and would probably be easy to update if we need to


Borderlands 1 Split Screen Problem

Okay, when I try to do split screen with 1 keyboard and 1 controller, the controller and keyboard only work on the screen being focused on. Help?

I kinda implemented without further testing, I'm going to test and see if I can fix it. Thanks for the heads up.

I messed up on the options being carried into the Game Handler, basically it was always starting without a keyboard player.
But still, Borderlands 1 is not responding to input when out of focus. On 2 and PreSequel I used -AlwaysFocus to fix that, but that command doesnt seem to work. I'm researching to see how to fix this last step.

Seems like ahk can do it.
But tbh this seems a duplicate of #42


Use dependency injection to load Middlewares

The preferable way to stack up Middlewares is using string, like the following sample:
$app->stackUp(SomeMiddleware::class);
$app->stackUp(AnotherMiddleware::class);

Then, the application should use the dependency injection container to load those Middlewares when it builds the chain.

Implemented on commit 163a662a62dda0161b721558cfdf5dd937167414.


HaRe & HIE-P-API installation failed on Windows10

Progress: 3/5
--  While building custom Setup.hs for package HaRe-<IP_ADDRESS> using:
      C:\sr\setup-exe-cache\x86_64-windows\Cabal-simple_Z6RU0evB_<IP_ADDRESS>_ghc-8.2.2.exe --builddir=.stack-work\dist\5c8418a7 build lib:HaRe exe:ghc-hare --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: E:\HIE\.stack-work\logs\HaRe-<IP_ADDRESS>.log

    Configuring HaRe-<IP_ADDRESS>...
    Preprocessing library for HaRe-<IP_ADDRESS>..
    Building library for HaRe-<IP_ADDRESS>..
    [ 3 of 29] Compiling Language.Haskell.Refact.Utils.GhcUtils ( src\Language\Haskell\Refact\Utils\GhcUtils.hs, .stack-work\dist\5c8418a7\build\Language\Haskell\Refact\Utils\GhcUtils.o )

    src\Language\Haskell\Refact\Utils\GhcUtils.hs:49:1: error:
        Could not find module `Data.Generics.Zipper'
        There are files missing in the `syz-<IP_ADDRESS>' package,
        try running 'ghc-pkg check'.
        Use -v to see a list of the files searched for.
       |
    49 | import qualified Data.Generics.Zipper as Z
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

--  While building custom Setup.hs for package hie-plugin-api-<IP_ADDRESS> using:
      C:\sr\setup-exe-cache\x86_64-windows\Cabal-simple_Z6RU0evB_<IP_ADDRESS>_ghc-8.2.2.exe --builddir=.stack-work\dist\5c8418a7 build lib:hie-plugin-api --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: E:\HIE\.stack-work\logs\hie-plugin-api-<IP_ADDRESS>.log

    Configuring hie-plugin-api-<IP_ADDRESS>...
    Preprocessing library for hie-plugin-api-<IP_ADDRESS>..
    Building library for hie-plugin-api-<IP_ADDRESS>..
    [ 9 of 10] Compiling Haskell.Ide.Engine.PluginDescriptor ( Haskell\Ide\Engine\PluginDescriptor.hs, .stack-work\dist\5c8418a7\build\Haskell\Ide\Engine\PluginDescriptor.o )

    Haskell\Ide\Engine\PluginDescriptor.hs:20:1: error:
        Could not find module `Data.ConstrainedDynamic'
        There are files missing in the `constrained-dynamic-<IP_ADDRESS>' package,
        try running 'ghc-pkg check'.
        Use -v to see a list of the files searched for.
       |
    20 | import qualified Data.ConstrainedDynamic         as CD
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I have just experienced the same issue while building HIE with stack --stack-yaml=stack-8.2.1.yaml install   at Ubuntu 16.04

Is this building with hie current master, and latest stack?
And what does ghc-pkg-8.2.1 check show you?

Full output on the latest master ( after gch-pkg check looks the same ):
 stack --stack-yaml=stack-8.2.1.yaml install
HaRe-<IP_ADDRESS>: build (lib + exe)
ghc-mod-<IP_ADDRESS>: build (lib + exe)
hie-plugin-api-<IP_ADDRESS>: build (lib)
haddock-library-1.4.4: configure
haddock-library-1.4.4: build
haddock-library-1.4.4: copy/register
Log files have been written to: /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/logs/
Progress: 4/6
--  While building custom Setup.hs for package ghc-mod-<IP_ADDRESS> using:
      /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/downloaded/PmPHKA28vAjA/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/setup/setup --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build lib:ghc-mod exe:ghc-mod exe:ghc-modi --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/logs/ghc-mod-<IP_ADDRESS>.log

    Preprocessing library for ghc-mod-<IP_ADDRESS>..
    Building library for ghc-mod-<IP_ADDRESS>..
    [10 of 17] Compiling GhcMod.Exe.Lint  ( GhcMod/Exe/Lint.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/GhcMod/Exe/Lint.o )

    /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/downloaded/PmPHKA28vAjA/GhcMod/Exe/Lint.hs:9:1: error:
        Could not find module ‘Language.Haskell.HLint3’
        There are files missing in the ‘hlint-2.0.11’ package,
        try running 'ghc-pkg check'.
        Use -v to see a list of the files searched for.
      |
    9 | import Language.Haskell.HLint3
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

--  While building custom Setup.hs for package hie-plugin-api-<IP_ADDRESS> using:
      /home/mitutee/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.2.1 --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build lib:hie-plugin-api --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/logs/hie-plugin-api-<IP_ADDRESS>.log

    Preprocessing library for hie-plugin-api-<IP_ADDRESS>..
    Building library for hie-plugin-api-<IP_ADDRESS>..
    [12 of 12] Compiling Haskell.Ide.Engine.PluginDescriptor ( Haskell/Ide/Engine/PluginDescriptor.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Haskell/Ide/Engine/PluginDescriptor.o )

    /home/mitutee/programming/thirdparty/haskell-ide-engine/hie-plugin-api/Haskell/Ide/Engine/PluginDescriptor.hs:20:1: error:
        Could not find module ‘Data.ConstrainedDynamic’
        There are files missing in the ‘constrained-dynamic-<IP_ADDRESS>’ package,
        try running 'ghc-pkg check'.
        Use -v to see a list of the files searched for.
       |
    20 | import qualified Data.ConstrainedDynamic         as CD
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

--  While building custom Setup.hs for package HaRe-<IP_ADDRESS> using:
      /home/mitutee/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.2.1 --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build lib:HaRe exe:ghc-hare --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/logs/HaRe-<IP_ADDRESS>.log

    Preprocessing library for HaRe-<IP_ADDRESS>..
    Building library for HaRe-<IP_ADDRESS>..
    [ 3 of 29] Compiling Language.Haskell.Refact.Utils.GhcUtils ( src/Language/Haskell/Refact/Utils/GhcUtils.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Language/Haskell/Refact/Utils/GhcUtils.o )

    /home/mitutee/programming/thirdparty/haskell-ide-engine/.stack-work/downloaded/9zRr-Yb8IEfi/src/Language/Haskell/Refact/Utils/GhcUtils.hs:49:1: error:
        Could not find module ‘Data.Generics.Zipper’
        There are files missing in the ‘syz-<IP_ADDRESS>’ package,
        try running 'ghc-pkg check'.
        Use -v to see a list of the files searched for.
       |
    49 | import qualified Data.Generics.Zipper as Z
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

ghc-pkg-8.2.1 check - command not found.

Is this still a problem?

No response for a couple of months, closing.


Skip validating the pbc registry for non-regional curated packages flow

Description of changes:
This PR skips validating the pbc registry for non-regional curated packages flow as a follow-up to #8910.
Testing (if applicable):
make eks-a
make lint
make unit-test
make build-all-test-binaries
make generate
make generate-manifests
make release-manifests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/approve

/cherry-pick release-0.21

/cherry-pick release-0.20

/lgtm


1.55 Wrong Gui initialized on Ubuntu 20.04 . Same as before, see #116682

With this new version 1.55 on ubuntu 20.04 gnome, I don't see the correct gui.
I need to start with --disable-gpu as suggested as workaround in #116682 by deepak1556

We haven't updated the runtime in 1.55, please continue to follow https://github.com/microsoft/vscode/issues/115868 for updates. Thanks!


Problems in coordinate axis arrays

I applied it in the Threejs project and found that some of them were not extended but contracted.
(This is a Chinese translation)

The contracted data is:
[-14, -6], [-8, -6], [-8, -8], [-6, -8], [-6, -14], [-16, -14], [-16, -8], [-14, -8]],
[6, -7], [7, -7], [7, -6], [12, -6], [12, -7], [13, -7], [13, -12], [12, -12], [12, -13], [7, -13], [7, -12], [6, -12]]

Hey,
Have in mind that this is a very simple library which I'm not maintaining anymore, since I found the excellent js-angusj-clipper. It is really robust and I can wholeheartedly recommend it. Here is ofsetting documentation.
Anyway, I re-created your examples in CodeSandbox - https://codesandbox.io/p/sandbox/offset-polygon-issue-4-4f6m8f
From I can see, with offset set to 1, it works as expected:

Of course if you increase offset to something larger than the polygon (in this case 3), you library will go bonkers:

Hope that helps, cheers!