Correct typo

Add missing decapsulation field in the decap-encap NH.
"standardize" the NHG and NHG numbering that:

single digit represents action for VRF_111 and VRF_222
double digit represents actions related to the indirect next-hop IP in the default.
triple digit represents actions in the encap VRF.
quad digit represents backup actions.

Pull Request Functional Test Report for #2514 / cc1c039cce413892575f872cfb7f09cbb6ac66c9
No tests identified for validation.
Help

cc: @singh-prem and @arvbaska1

@nflath to approve.

The same DecapEncap action is needed for below NH#1001 as well ?
NH#1001 -> { encapsulate_header: OPENCONFIGAFTTYPESENCAPSULATIONHEADERTYPE_IPV4 ip_in_ip { dst_ip: "<IP_ADDRESS>" src_ip: "ipv4_outer_src_222" } network_instance: "TE_VRF_222" }

done.


Release a patch version 1.3.4 to remove use of syreclabs.com/go/faker

Hi @AlekSi,
Would it be possible to create a tag v1.3.4 to fix issues with syreclabs.com/go/faker?
I see that the library has been replaced by github.com/brianvoe/gofakeit with the PR https://github.com/go-reform/reform/pull/195 but that hasn't been released yet, thus isn't available through go get -u gpkg.in/reform.v1.
For references, issues with syreclabs.com/go/faker:

https://github.com/go-reform/reform/issues/194
https://github.com/dmgk/faker/issues/14

$ go mod download
#... more fetches
go: finding gopkg.in/reform.v1 v1.3.3
go<EMAIL_ADDRESS>unrecognized import path "syreclabs.com/go/faker" (https fetch: Get https://syreclabs.com/go/faker?go-get=1: x509: certificate signed by unknown authority)
# ... more fetches
go: error loading module requirements
##[error]Process completed with exit code 1.

v1.3.4 is out. Sorry for delay.


M3-1137 Create Tag (Linodes Detail)

Purpose
Create a Tag on Linodes Detail
Notes

First and foremost, <LinodesDetail /> got a facelift. Much of the logic was abstracted to the <LinodesDetailHeader /> component, as to get the line numbers down and readability up
Also fixed an issue where deleting a Tag on Linodes Detail would delete the Tag permanently, when really it should have been removing that tag from the current Linode
Incorporated react-select. There was a bit of magic involved to get it to behave the way I wanted. Please let me know if anything is unclear so I can document it better

basically, if you add or delete a Tag, the auto-suggestions will be updated to either add or filter out the Tag you added or removed to the suggestion list

@rjstires Let me know what you think about the changes. Instead of making <LinodesDetailHeader /> into a presentation component, I instead created smaller components.
imo, it makes sense to have logic in <LinodesDetailHeader /> because most of the functions in that component rely on linode not being undefined which is definitely a possibility in <LinodesDetail />. Further, if all that logic lived in <LinodesDetail />, it would be massive.

Coverage decreased (-0.2%) to 26.347% when pulling fc3da49c3cccdf888cf277b3611d6b2285782241 on martinmckenna:M3-1137-create-tag into 1d46570131d4ef48745796789cbcaefd68378f87 on linode:feature/tags.


Update DiagnosticGroups.java

I'd like to be able to suppress these compiler warnings. Here is the scenario I've encountered.
Function $jscomp.scope.Graph.prototype.setEdge: called with 2 argument(s). Function requires at least 0 argument(s) and no more than 0 argument(s).
I encountered this when trying to use the graphlib library with a closure compiled project. I downloaded the graphlib library and modified it to use goog.require and goog.provide statements.
https://github.com/cpettitt/graphlib
They use a function (Graph.prototype.setEdge) without defined parameters in graph.js but it uses the 'arguments' reference to pull down the arguments. This code does this because it is overloaded and has multiple ways of calling it. You can see it here.
https://github.com/cpettitt/graphlib/blob/master/lib/graph.js#L353
Normally, if you've written code like this then you're doing something wrong and should just fix up the function. But its desirable to leave the third party library unmodified as much as possible in your own project. So in this case it is desirable to suppress the warning.

Hi Alex, the group you changed is not what you're looking for. It is used only for testing the new type inference. You are most likely using the old type checker. To suppress the warning, add
@suppress {checkTypes}

to the jsdoc of the function that contains the call.
Also, do you want to compile graphlib together with your project, or just use them together? If you want to only compile your code, then you can write an externs file for graphlib and use that for the compilation.


Remove '1 tab == 4 spaces remarks' from check

Remove the * 1 tab == 4 spaces remark from header check.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added another update in last commit. Introduces ignore mechanism, and uses it to ignore some files. Likely this ignore list will grow


Use official RPM repository instead of EPEL

Would you mind update the module to use the official Erlang yum repository instead of epel ? I see R14 on epel and R16B03 in the official repo
https://www.erlang-solutions.com/downloads/download-erlang-otp

I've put in the PR for move away from EPEL to use the erlang-solutions repo
https://github.com/garethr/garethr-erlang/pull/21

It looks like #21 is failing. I tried updating all of the gems, and it looks like puppet 3.8 fails on Syck. We may need to look at which versions of ruby/puppet are supported.

I'll try to take a look tonight or early tomorrow eastern time


User Created with Insecure Permissions

When creating a user in the docker/generic/Docker.kinetic file you give the user root permissions with the password 'autoware' and nopasswd privileges in the sudoers file. This allows anyone with access to this system to have root permissions without any authentication and should be changed.

@harobbins I think it is necessary for attackers to login the host machine of the docker image.
This is already insident.
So, I think it is not a problem to write username and password in Dockerfile.
Please tell me what kind of insident are you talking about?
Thanks!!

The issue is not that it is written to the Dockerfile, but that the user is created at all. Having a user with root permissions like this is leaving the system open to significant security risk.

This is a good point from a product point of view. I'm assuming the Docker support in docker/generic is only a reference for testing and development. A real deployment should not use it.


announcements: Increase specificity of events coming from Kubernetes

This PR continues the work started in https://github.com/openservicemesh/osm/pull/2010 and contributes towards resolving issue https://github.com/openservicemesh/osm/issues/1719
This PR adds announcement types (add, delete, update) for Pods and Kubernetes Endpoints.
This also changes GetKubernetesEventHandlers() so it emits the appropriate AnnouncementType based on which Kubernetes object is observed.

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

Codecov Report

Merging #2028 (9b50373) into main (5c4b802) will decrease coverage by 0.07%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   56.32%   56.24%   -0.08%
==========================================
  Files         142      143       +1
  Lines        5767     5800      +33
==========================================
+ Hits         3248     3262      +14
- Misses       2516     2535      +19
  Partials        3        3

Impacted Files
Coverage Δ

pkg/catalog/repeater.go
30.76% <0.00%> (-4.02%)
:arrow_down:

pkg/kubernetes/event_handlers.go
56.60% <50.00%> (-12.15%)
:arrow_down:

pkg/endpoint/providers/kube/announcements.go
66.66% <66.66%> (ø)

pkg/configurator/client.go
89.47% <100.00%> (ø)

pkg/endpoint/providers/kube/client.go
83.62% <100.00%> (ø)

pkg/kubernetes/client.go
89.69% <100.00%> (ø)

pkg/smi/client.go
77.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4b802...9b50373. Read the comment docs.


Azure SQL firewall settings steps outdated

The step Generate the Database Schema references a menu entry called Firewalls and virtual networks:

On the left navigation, select Firewalls and virtual networks.

The menu entry has been renamed to Networking and significantly redesigned - therefore the instructions and screenshots for this section are outdated.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: df55b676-8ff7-1470-3525-d0edfd406af6
Version Independent ID: ac264c26-7196-870b-760f-94a97ae437e8
Content: Deploy an ASP.NET Core and Azure SQL Database app to Azure App Service - Azure App Service
Content Source: articles/app-service/tutorial-dotnetcore-sqldb-app.md
Service: app-service
GitHub Login: @alexwolfmsft
Microsoft Alias: alexwolf

@kszicsillag
Thanks for your feedback! We have assigned the issue to author and will provide further updates.

This has been addressed in an upcoming PR, thanks!
#please-close


Usage of plural

Hey, I'm kinda confused how plurals are working.
I read the docs and some other issues related to plural and created this fiddle: https://jsfiddle.net/escapedcat/75peeeqy/1/
ITEM and ITEMS should be translated to Car and Cars, but only ITEM translates correctly.
Is this supposed to work or not? If not can you highlight the paragraph in the doc where this is stated? I would try to rework the docs to make this more clear. If this sin't supposed to work, how could somethign like this be achieved?

And how do you expect it to work if you don't use a correct JSON format for the plurals in your translation object?
Use this in your fiddle and enjoy it working:
Vue.use(VueGettext, {translations: {
    "ITEM": [
      "Item",
      "Items"
    ],
}});

And maybe you can read some examples before making me loosing my time :p

Thanks a lot for the hint. This works fine now: https://jsfiddle.net/escapedcat/sydeqk2c/
I'm still trying to wrap my head around gettext. Sorry for wasting your time :P

You can read this for an introduction to the classic Gettext workflow.
But please note that Vue-gettext deviates from the original Gettext. Notably with regard to the way translations are exposed in a JSON format. You can learn more by reading the doc and inspecting some dependencies (gettext-compile).


ZipKin with Mysql

Hi Team,
I Configured Zipkin with spring boot micro service projects. i am able to run and watch service details on Zipkin UI. I would like to store span, dependecies and annotationas in to my SQL Database.
I did MySQl configuration in application.property file, but need help how to store data from springboot request controller to mysql tables.
Thank you
Javeed Ali Khan A

Hi, it looks like you are building a custom zipkin server. Unfortunately we cannot provide support for custom servers, we are a small group of volunteers and custom servers can have so many variables that it is too big of a burden on our community.
Did you know there are pre-built distributions of zipkin? Please check out our documentation for more information: https://github.com/apache/incubator-zipkin/blob/master/zipkin-server/README.md


NOTES-WINDOWS: fix named anchor links in table of contents

Those links were probably broken by some changes to the sanitizer of the github/markup module.
You can test it for yourself in your browser:

NOTES-WINDOWS (master, broken)
NOTES-WINDOWS (this pull request, fixed)

Checklist

[x] documentation is added or updated

This pull request is ready to merge

Merged to master in cf6342bc024868f5a55f2225f2e083415fb1329a, thanks!


bug: fixing the error page

its working fine

its working fine

check it again , in mine it was not working


Initial work on fixing child interpolation

The tests under __main__ will be extracted in a separate PR, so I will merge this in as-is for now to get this fix in.

@jimbaker I think you wanted to start over from scratch (last Saturday.) Do you want to keep this PR open?

Correct.


OS X - can't skip song or start a new song in the list?

Is this just not done yet? This is how it looks for me:
http://i.imgur.com/0CnW94U.png
Awesome application, keep it up!
<3

Seems I don't get admin status on my own rooms? Am I missing something?

You can vote to skip the playing song using the three-dot menu at the top of the playing track.  You can't queue another song up to play, you need votes from other users to change the order (this is by design since it's about collaboration).
You should be an admin of your own room if you created it, try typing /listadmins in the chat window to double check.


Error with multishotfilesampler

Hi, tere is an error with the multishot filesampler, when you have images of different sizes it should be resized so all images have the same size, otherwise many models can't use the data, or it will fail when trying to convert to a tensor in the line 196 in multishotmemorysample (https://github.com/tensorflow/similarity/blob/81d5e00033344ec6b218fc97e6e7a3c5a74ae323/tensorflow_similarity/samplers/memory_samplers.py#L196), the problem is that there isn't a way to add the target size when using the class, I think the load_image function should be inside the class and it should use a self.target_size variable from the init function

I think you can use the load_fn to resize the image before we get to the convert_to_tensor call. We set up a version of the multishot sampler for images to do just this -> tensorflow_similarity/samplers/file_samplers.py
A similar use case is doing random crops and resize to the same size. We actually have a function in our augmenters to handle doing this as well.
Let me know that unblocks the issue. Alternatively, I also recently added a new tf.data.dataset sampler if you'd prefer to use the standard TF dataset api. tensorflow_similarity/samplers/tfdata_sampler.py

I see. The original intention was to parameterize the load function before passing it to the multishot sampler. Something like the following:
...
import functools

f = functools.partial(load_image, target_size=(24,24,3))

s = MultiShotFileSampler(
        x,
        y,
        load_example_fn=f,
    )

Or write a custom function and include the parameters inside... However, I see the issue you mentioned in the current implementation. We use the load_image func as the default and that doesn't currently provide a default target_size so it's skipped by default. That works but is probably not the most intuitive.

ok, I didn't knew that way to use the image, is weird for how the class is made class but very useful for the MultiShotMemorySampler, since the MultiShotFileSampler is currently just the MultiShotMemorySampler with the load_image function by default. Thanks, I learned something very useful, still, when I get the time I will propose what I think will be more natural to use as a different class, my current code is not useful for this project because I use opencv to load every extension i need (mostly because the decode_images function of tensorflow doesn't load webp)


Move some dependencies to dev dependencies

Move ESLint, its config, plugins, and React (as it's not used in the app itself, just as a peer for React ESLint plugins) dependency to dev dependencies

Commit a283e6b was just left from doing style fixes, I pushed that to master without PR as it's a simple style change.

🦀🦀🦀

nvm conflicts cringe

aight I'll rebase then update it again


Hugo v0.87.0  no longer support Hugo modules/themes

I failed to use hugo v0.87.0 to run hugo themes in win10, but hugo v0.84.1 worked.

PS C:\Users\Lenovo> hugo version
hugo v0.87.0-B0C541E4+extended windows/amd64 BuildDate=2021-08-03T10:57:28Z VendorInfo=gohugoio
PS C:\Users\Lenovo> go version
go version go1.16.7 windows/amd64

PS D:\1_Files\hugo-academic-website-dev> hugo server
hugo: downloading modules …
go<EMAIL_ADDRESS>reading github.com/wowchemy/wowchemy-hugo-modules/go.mod at revision v5.3.0: unknown revision v5.3.0
hugo: collected modules in 43316 ms
Error: failed to download modules: go command failed: go<EMAIL_ADDRESS>reading github.com/wowchemy/wowchemy-hugo-modules/go.mod at revision v5.3.0: unknown revision v5.3.0

related link in wowchemy-hugo-modules.

Your issue title i obviously not correct as general statement. I and many with me use Hugo Modules every day.

Ignoring the issue title I would say you might have a cache issue or an issue with defining the version of your module. Try running some of these commands:
hugo mod tidy
hugo mod get -u ./...

and see what happens. You could also delete a folder possibly called /tmp/hugo-cache or something along these lines depending on your operating system.
If nothing else helps follow the advise on your linked wowchemy issue and downgrade hugo to the version that did work at the time the current version of the theme worked.

@Bear-kai my suggestion would be to try:
hugo mod clean

And then run hugo.


Upgrading from 1.7.0 to 1.8.0 in Rails changes output

I have a test that styles should be getting inlined:

Hi there!

But now they aren't:

Hi there!

I suspect it has something do with 56b84a3bff6eb5e0c69a7ae3561834a4cd3c6862 but I can't figure out what it is. My relevant initializers look like this:
Premailer::Rails.config.merge!(preserve_styles: true, css_to_attributes: true)

ActionMailer::Base.register_interceptor(ActionMailerInterceptors::MessageIDGenerator)
ActionMailer::Base.register_interceptor(ActionMailerInterceptors::EmailSubjectRailsEnvPrefixer)
ActionMailer::Base.register_interceptor(ActionMailerInterceptors::StripStylesheetLinksInterceptor)
ActionMailer::Base.register_interceptor(ActionMailerInterceptors::ClickAndOpenTrackingInjector)
ActionMailer::Base.register_interceptor(ActionMailerInterceptors::DefaultMailgunTrackingOff)

What am I missing?

Is this still an issue with the latest version?

Yep, it's still an issue.

Could you throw together a minimal working example so I can look into it? #156 is possibly related to this.

OK, here's a tiny Rails app with one test.
demo.zip

@brandonweiss premailer-rails manipulates emails upon delivery. The test case you built is failing with both premailer-rails versions. You can trigger the processing with Premailer::Rails::Hook.perform(mail).


Add support for py35 to tox.ini and .travis.yml

This was done in ab2b5113cacb1926db2f4652256a2b300118968e?

Looks like it, thanks!


Wrong layout for radio an select

According to CakePHP Form Helper documentation, you should create radio buttons and selects with the following code:
//Radio Button
$options = array('M' => 'Male', 'F' => 'Female');
$attributes = array('legend' => false);
echo $this->Form->radio('gender', $options, $attributes);
//Select
$options = array('M' => 'Male', 'F' => 'Female');
echo $this->Form->select('gender', $options);
The current output, for horizontal form, is in the attachment

And for non-horizontal form, the output is

What I understand from the FormHelper documentation, and the way I want my plugin to work is the following:

If you want to have bootstrap layout (i.e., the Helper wrapping your inputs), use the input method
If you want raw input / select / etc., use the direct methods (select, input, radio, etc.)

This is the way the default CakePHP FormHelper works: If you use the default input method, the helper wraps the inputs elements into div, if you use the direct methods, there is no "wrapping".
If you want Bootstrap layout, use the following codes:
//Radio Button
$options = array('M' => 'Male', 'F' => 'Female');
echo $this->Form->input('gender', array('type' => 'radio', 'options' => $options, 'legend' => FALSE));

//Select
$options = array('M' => 'Male', 'F' => 'Female');
echo $this->Form->input('gender', array( 'options' => $options));

Thanks Holt59. I understand your point.
However, I still thinking there are a strange behavior on inline radio button.
If I write
//Radio Button
$options = array('M' => 'Male', 'F' => 'Female', 'T' => 'Trans');
echo $this->Form->input('gender', array('type' => 'radio', 'options' => $options, 'legend' => false, 'inline'=> TRUE);
The first radio button is above the others. Please, see the picture below

If you look the firstone, it has a different class: radio vs. radio-inline in the other inputs
Am I missing some parameter??

No you're not, there were some bugs. This should be fixed with the latest commit.

Thank Holt59, It´s working OK now


Battles always end in a 0-0 draw

Every battle I play, no matter the number of points, it always gets treated as a 0-0 draw

https://user-images.githubusercontent.com/123265757/219010615-87bddacd-7ece-488a-8439-b17f5f838e34.mp4
Video showing the bug


:sparkles: new interface

In this PR we transfer from pandas.Series as representation for time series to a purely np.ndarray based representation
(pandas.Series its index can at this time not represent most numeric dtypes, e.g. int16)
The signature for the downsample methdod is changed to:
downsample([x], y, n_out, **kwargs)

Note the following:

x is optional, allowing the same (memory) efficient runtime as with pd.RangeIndex
x and y are both positional arguments (this is in line with how the matplotlib,pyplot.plot signature is)
n_out is a mandatory keyword argument

Example:
from tsdownsample import MinMaxLTTBDownsampler
import numpy as np

# Create a time series
y = np.random.randn(10_000_000)

# Downsample to 1000 points
s_ds = MinMaxLTTBDownsampler().downsample(y, n_out=1000)

Other aspects of this PR

[x] support x and y datetime64: view the array as np.int64
[x] support y timedelta64: view the array as np.int64
[x] support y bool: view the array as np.int8 (under the hood numpy represents a bool as 8 bits)
[x] support y int8 & uint8
[ ] support categorical data => out of scope for this PR, would mostly be some Python code converting it to an encoding (which is perhaps not the responsibility of this library...)  - also not really sure how numpy would represent categorical data

Major TODOs:

documentation :ledger:  => will leave this for another PR
do not assume fixed sampling rate => will leave this for another PR

I find it a little cleaner to import the concrete methods/variables in tsdownsample/__init__.py than applying from .downsamplers import *

LGTM, see those comments!

Will merge this if you approve @jonasvdd & then I can make first real release! :rocket:
Besides documentation, the (afaik) only major TODO is getting rid of the assumption of fixed sampling rate :thinking:

Will merge this if you approve @jonasvdd & then I can make first real release! rocket
Besides documentation, the (afaik) only major TODO is getting rid of the assumption of fixed sampling rate thinking

Guess we won't make a first real release yet as the distribution is not 100% watertight (see #9)

@jvdd, I think we can tackle the M2 building in a new PR and merge this one? 🙏🏼

Ready to squash and merge :rocket:


fix: Updated source_files with the correct path

I made the change of paths and didn't update this, my bad!

cc @rundfunk47


Add SIC code field

Requested via email and Zendesk:

I would like to include the SIC information for businesses in the online search feature for the IAIP.

SIC codes were not originally imported from the previous application. Out of 1168 customers imported from the old database, 632 had SIC codes entered.
This request requires updating the SBEAP app to include Customer SIC code and importing that data from the old database.

SicCodes.csv

After eliminating inactive SIC codes, the count is 619.

QA finished 11/7/2023

Approved by program.


Add new instances view layout description (all, registered, unregistered)

@EfrenRey could you please review?
@jim-phillips, @lyzalou, @srveit as soon as it is reviewed, could you please merge this? It is describing a feature that is being announced in the Release Notes published today. Thanks!
@rchakra1, FYI (you can also review if you want!)

@jim-phillips, @lyzalou, @srveit, could you please merge this?


CC62257: Creating a table to display "Parts" content

Hello, @mairaw ,
This proposed file change comes from https://github.com/dotnet/docs.pl-pl/pull/148.
"Polish contributor suggested a change in style for the section "Parts""
Could you review this contribution and help to merge if agreed?
Many thanks in advance.

Thanks @rpetrusha


Feature/multiple test json

This updates the test json support so that it supports multiple test jsons per entry version.

[x] Check that you pass the basic style checks and unit tests by running mvn clean install

Coverage decreased (-0.2%) to 72.479% when pulling e4d77a71d6b393a3c6631c34adab46d3f7f781a0 on feature/multiple_test_json into f29a604593915f22571cad8b7cf073271717a281 on develop.


Prevent conversion if any domain uses PHP provided by os vendor

Since vendor version of PHP is 5.4 on CentOS 7 we should force to move from it before the conversion.
We cannot directly upgrade php-handler to the PHP 7.2 provided by the vendor on AlmaLinux 8. This is because there is a risk that the website will break due to PHP version incompatibility.
Additionally, staying on PHP 5.4 is not an option since it is not provided by the vendor or Plesk on AlmaLinux 8.
As a solution, we need to prevent the upgrade and advise a customer to switch to PHP 7.2 provided by Plesk or any other modern PHP version.
It would be beneficial to implement a pre-conversion checker for this issue.

Problem should be fixed in #201


YAML module is not available.

When importing the bible function I get this error. Any ideas why? I'm running python3.6 on Ubuntu 16.04
YAML module is not available. Exporting to YAML function will NOT work.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/.local/lib/python3.6/site-packages/freebible/__init__.py", line 15, in <module>
    from freebible.helpers import read_kougo, read_web, bibles
  File "/home/user/.local/lib/python3.6/site-packages/freebible/helpers.py", line 16, in <module>
    from freebible.parsers.kougo import parse_kougo
  File "/home/user/.local/lib/python3.6/site-packages/freebible/parsers/kougo.py", line 38, in <module>
    from chirptext.io import read_file
ModuleNotFoundError: No module named 'chirptext.io'```

Hi, sorry I missed this comment. This bug was caused by an update in @letuananh/chirptext module (renaming chirptext.io to chirptext.chio). It was fixed in the latest release (freebible-0.1a8). Can you please kindly help to update chirptext and freebible packages and see if it is working as intended? Thank you for contributing.
pip install --upgrade chirptext
pip install --upgrade freebible

It worked, thanks!
>>> from freebible import bibles

>>> bibles.print("Exo", 5, 20)

[Exo 5:20] 彼らパロをはなれて出たる時モーセとアロンの對面にたてるを見たれば
[Exo 5:20] They met Moses and Aaron, who stood in the way, as they came forth from Pharaoh:
[Exo 5:20 彼らパロをはなれて出たる時モーセとアロンの對面にたてるを見たれば , Exo 5:20 They met Moses and Aaron, who stood in the way, as they came forth from Pharaoh:]


Use assembly sequences to enable caches.

See #232, which this partially fixes -- there's still the question of
taking an interrupt in the midst of these sequences.

r? @adamgreig
(rust_highfive has picked a reviewer for you, use r? to override)

I'm not clear on why as on one of your builders has stronger opinions about the use of unified thumb mnemonics than the others, but I have removed the offending suffix.

Only the x86 target runs the assemble.sh script to check the pre-built blobs match the CI-generated ones, the other targets just test the crate itself.
Our CI is using ARM's gcc-arm-none-eabi-7-2018-q2-update-linux which is a bit old; what version are you assembling with?

I am using binutils 2.34-1.

Is the decision to use pre-unified syntax in the asm files deliberate? It means that the asm files and the inline-asm blocks use different syntax. (I'm having to go digging to remember how to express a reg-reg-immed orr in pre-unified mnemonics.)
If not, I will add the .syntax unified directive to the top of the file.

I don't see any reason not to use unified syntax here, I assume it was an oversight originally.
The replication between the asm files and the inline asm blocks is the only way we've found to provide asm to stable users while still offering inline asm for nightly users, but I don't think there's any need for inline asm for these cache management operations, so we could only ship the prebuilt objects here. If we end up including all the other maintenance operations I think there would be enough assembly to tip the balance towards only using the prebuilt objects; as-is it's short enough that I think we might as well include both. Hopefully soon Rust will include stable inline assembly and eventually we can remove the duplication.
On the critical section: do you think there's any situation where users are likely to be worried about the overhead of entering a new critical section, justifying a version of the function that takes an &CriticalSection token? I assume most users are not enabling the cache in their fast paths, and as you've noted unprivileged users won't be changing the cache either. If that's the case I think just stick the cps inside the assembly and document it in the function docstring.

I don't see any reason not to use unified syntax here, I assume it was an oversight originally.

woot, updated

The replication between the asm files and the inline asm blocks is the only way we've found to provide asm to stable users while still offering inline asm for nightly users

Right. I'd do the same thing in your place. I wish that llvm_asm! could be pointed at a file, though, so that they both eat the same input. It's not immediately clear that that's possible (without, say, a proc macro).

I don't think there's any need for inline asm for these cache management operations

Well, that simplifies things! :-)

On the critical section: do you think there's any situation where users are likely to be worried about the overhead of entering a new critical section, justifying a version of the function that takes an &CriticalSection token?

This may be a failure of imagination, but...no, I don't think that's likely. I haven't quantified the overhead on the M7 (which is where caches start to become commonplace) but I would be surprised if anyone noticed. So I will add the instructions and make the code correct.


[Performance] Creating UnityContainer is slow

Description
Creating a new UnityContainer (new UnityContainer()) takes around 60ms, which is quite slow I think. Is there any way to speed it up? What is the Container doing that is taking so long?

I am guessing here, but probably initializing?

@ENikS The problem is that I'm unable to cache the Dependency Container instance for a long time, as I'm not in control of the lifetime of my app domain. I'm not familiar with the internals of the UnityContainer and what it is doing to initialize itself. I just wanted to point out that this (long) setup time can be a problem in specific projects and that it would be great if it's possible to decrease this initial setup time.

Do you suspect it is being slowed down on purpose?!

No, I've never said that... You seem to care about performance as you've done lots of performance measurements and improvements in the 5.X versions of Unity. I'm just saying that resolving and registration  might be the most important performance improvements, but they are not the only ones. Just creating the container without registering or resolving any type shouldn't take that long in my eyes and there is room for improvement.

@s-bauer
Closing for now. Feel free to reopen or send a PR if you find a way to improve performance.


Further Changes to S4 Dungeons

Reapplied changes from pull request #29

LGTM! Thank you, I'll publish a new version today


Add Light theme

For now the light theme is only done through the theme button
I will be adding the Command for it soon

Part of #19


I can add missing values for numerical tool-groups

the process of adding new missing values works both for categorical data (i.e. few unique values) and numeric data (i.e. many unique values) without permanently spamming the screen with a long list of values (e.g. dropdown)

@jarmoza, this guy probably needs a little bit more detail. Mind having a look over?

Sure. What prompted you to mention it? Is there something you've come across in your work?

It's part of the epic you are working on right now and I wanted to make sure we think through it before the next sprint so that we have a clearer idea of the work involved by then.


Fix message for admin DLQ merge command

What changed?
Fix message for admin DLQ merge command

Why?
Currently More messages to merge will be printed even if there's actually there's no more DLQ messages. This pr fix it.

How did you test it?

Potential risks

Coverage decreased (-0.6%) to 66.923% when pulling 2d329643eedebce9e90f6a3179684d5164427918 on yycptt:fix-dlq-merge into 85e0cb1f1c35084527bee925145d061da831addf on uber:master.


Difference from v1 ?

Hi,
What's the actual difference between the previous version of your code? I have v1 running smoothly on my site.. Do I need to upgrade? Are there specific upgrade instructions?
thanks,
Andrew

Here is the information you are looking for:
https://github.com/maximejobin/rocket-nginx/releases/tag/2.0

ok, I am a bit of a newb but how do I uninstall v1.0 ?
I forgot what files the plugin has added...
many thanks

You can simply delete the folder rocket-nginx and redownload everything. That is the way to "uninstall".


add oracle-7 to release_checks_list and disable selinux

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@27498f2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #426   +/-   ##
=========================================
  Coverage          ?   16.66%
=========================================
  Files             ?        1
  Lines             ?        6
  Branches          ?        0
=========================================
  Hits              ?        1
  Misses            ?        5
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27498f2...cc63239. Read the comment docs.


Ability to set Namespace when switching contexts

When switching a context, it would be nice to be able to set the active (default) namespace for the context as well.
kubectx my-cluster test-namespace

If test-namespace is left off, it would just be ignored.

@jwhitcraft Interesting idea. I don’t have a lot of daily experience with namespaces. It looks like if you want to associate a namespace with a context entry, you need to create a new context entry (or modify the existing context entry).
Please correct me if I'm wrong, but in your example, my-cluster would always be associated with the test-namespace. I can think of refactoring the kubectx alias functionality to accept a namespace argument like this:
kubectx c1=my-cluster
kubectx c2=my-cluster:test-namespace

because there's no way to do kubectl config use-namespace today. What do you think of this?

@ahmetb, that works for me.  Currently I do this in my bash script which allows me to keep the same context but change the active namespace at will.
function k8sns() {
    ctx=`kubectl config current-context`
    ns=$1

    // verify that the namespace exists
    ns=`kubectl get namespace $1 --no-headers --output=go-template={{.metadata.name}} 2>/dev/null`

    if [ -z "${ns}" ]; then
        echo "Namespace (${1}) not found, using default"
        ns="default"
    fi

    kubectl config set-context ${ctx} --namespace="${ns}"
}

@jwhitcraft I see, that's essentially modifying your context. But it should be fine. I have an alternative proposal:
We can ship an additional kubens script, just like kubectx it can list/auto-complete the namespaces active in the current context and modify the current context to use the namespace, like your script does. It would also provide switching back and forth between namespaces using kubens –.
Which solution do you like better, a separate tool, or aliasing feature charged with namespaces?

@ahmetb a seperate tool would be best the more and more i think about it.

@jwhitcraft I just hacked a kubens tool. Can you try check out this branch, add it to your PATH and try kubens? https://github.com/ahmetb/kubectx/tree/wip-kubens  I appreciate feedback.

@ahmetb I just got back to work and i'll get this setup today.
Thanks!

@ahmetb, so far working well. nice job 👍

This can now be installed via brew install kubectx --HEAD


Implementing native admob view in Android

Hi,
Here's some snippet of my code. However

I could only see white space without the ad
I tried debugging and it doesn't hit createViewInstance method

Any idea why? I tried implementing dummy prop too. I'm on RN 0.14.0-RC
ReactAdMobManager.java
public class ReactAdMobManager extends SimpleViewManager<AdView> {

    private AdView mAdView;

    @ReactProp(name = "src")
    public void setSrc(AdView view, String src) {
        Log.d("ReactAdMobManager", "inside set src");
    }

    public static final String REACT_CLASS = "RCTAdMobView";

    @Override
    public String getName() {
        return REACT_CLASS;
    }

    @Override
    public AdView createViewInstance(ThemedReactContext context) {
        Log.d("ReactAdMobManager", "inside create view instance");
        mAdView = new AdView(context);
        mAdView.setAdSize(AdSize.FULL_BANNER);
        mAdView.setAdUnitId("xxxxx");

        mAdView.setAdListener(new AdListener() {
            @Override
            public void onAdLoaded() {
                Log.d("ReactAdMobManager", "ad loaded");
            }
        });

        // Create an ad request.
        AdRequest adRequest = new AdRequest.Builder().addTestDevice("50AC32B853DA4B3E64C3B10BC26D0380").build();
        //adRequest.
        mAdView.loadAd(adRequest);

        return mAdView;

    }

}

ReactAdMobPackage.java
public class ReactAdMobPackage implements ReactPackage {
    @Override
    public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
        return Collections.emptyList();
    }

    @Override
    public List<Class<? extends JavaScriptModule>> createJSModules() {
        return Collections.emptyList();
    }

    @Override
    public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
        return Arrays.<ViewManager>asList(new ReactAdMobManager());
    }
}

MainActivity.java
 mReactInstanceManager = ReactInstanceManager.builder()
                .setApplication(getApplication())
                .setBundleAssetName("index.android.bundle")
                .setJSMainModuleName("index.android")
                .addPackage(new MainReactPackage())
                .addPackage(new ReactAdMobPackage()) // <--- add fab package here
                .setUseDeveloperSupport(BuildConfig.DEBUG)
                .setInitialLifecycleState(LifecycleState.RESUMED)
                .build();

AndroidAdMobView.js

var { PropTypes, requireNativeComponent } = require('react-native');

var iface = {
    name: 'AdMobView',
    propTypes: {
        src: PropTypes.string
    }
}

module.exports = requireNativeComponent('RCTAdMobView', iface);

Usage

var AdView = require('./AndroidAdmobView');

//at render
      <AdView style={{height:50}} text="foo" />

updated with my latest code.
my onAdLoaded listener got fired. however it's still not visible on my screen.
From the logs I saw

W/cr.BindingManager﹕ Cannot call determinedVisibility() - never saw a connection for the pid: 24719
I/Ads﹕ Ad is not visible. Not refreshing ad.

Wild guess: does AdView implement the onCreate and onResume methods? If yes try calling them directly in createViewInstance (or subclass AdView and call onCreate and onResume)

yes i just tried that too, still showing blank

Do you have any news on this? I am needing the same thing, so before I start from zero, I'd like to help you getting this.

I'm sorry @rodripf, I don't.
I tried asking in stackoverflow and there's no news too

Hi steve! Could you share a repository with the code you used to start from that? Let's make it!
Cheers

@rodripf  the required codes are all up there!

Is there an update on this?

I reach the same point as you @steve-ng. In the catlog the ad request is successful but it doesn't shows. And admob knows that it is not showing because in the log it says "the ad is not being showed. re scheduling reload to 60 sec from now.".
I've added some things to the scenario: added google play services to the compilation, added the required permissions and activity to the android manifest.
I also tried updating the view once the ad is loaded, once I click a button, but with no success.
When I'm back home I'll upload my code to a repo so we can work with the same things.

I was not sure what to put into the repository and what not to make it usable, but I did my best.
Here is it: https://github.com/rodripf/react-native-android-admob
To note here, as commented before: what I added to manifest.xml and to the gradle files.
But not success after all :-(
Any other idea coming?

The example above mostly works, but does not on an initial load.
The same example, when run on a device and there is an orientation change (android destroys and recreates views when that happens) the Ad loads.
The loading of the ad needs to be removed from the render cycle to after, perhaps via a call in componentDidMount?

I think I solved it.
The problem is that the AdView has zero width and zero height until loaded. I attached an AdListener and do some layout and measure magic when the ad is loaded.
I added it to my AdMob Library. It's far from perfect, but pull requests are welcome!

@sbugert I mostly followed your example and was able to get it working. However, I was able to simplify things.

SimpleViewManager specializes on AdView.

createViewInstance loads the Ad and returns an instance.

My onAdLoaded callback is as follows:
     @Override
     public void onAdLoaded() {
         super.onAdLoaded();
         Log.d(REACT_CLASS, "onAdloaded");
         int width = AdSize.BANNER.getWidthInPixels(reactContext);
         int height = AdSize.BANNER.getHeightInPixels(reactContext);
         mAdview.measure(width, height);
         mAdview.layout(0, 0, width, height);
     }

On the Javascript side, I wrap the nativeView within a   which is styled to the size of the ad ie 320x50 for the banner. Wrapping it in a  is required so that the ad stays within the layout and does not jump to the top left of the parent view.
HTH - happy to send pull requests or put this code up if anyone is interested

@kritikinfo do you think u are able to provide a gist too? Thanks

@steve-ng Sure - I'll put up the whole thing into a gist and reference it here.

@kritikinfo Thanks for the idea to simplify things!
I found that mAdview.layout(0, 0, width, height); will break when using the banner in a flex layout.
Something like mAdview.layout(originalLeft, originalTop, width, originalTop + height); resolves this.
Also, your solution lacks the ability to change the banner size with a prop. This is why I added an event to style the javascript view with the appropriate size.
I got everything working now (still testing) with events and props and will push the changes later to my repo :-)

@steve-ng  https://gist.github.com/kritikinfo/1bc92d2a07b3b1516a9d
The only thing special is in the onAdLoaded as per previous comments.
@sbugert eagerly waiting for the updates!

@kritikinfo I did not yet succeed in changing the banner's props on the fly because calling setAdSize() for changing is illegal. Creating a new instance didn't work either because the view passed to a prop method is final.
The only solution I came up with is (again) wrapping a ReactViewGroup and creating a new AdView everytime a prop changes.
Here is a gist with my current code.
Do you have any ideas how to improve it?

@steve-ng @kritikinfo Have any luck since this discussion?

@danleveille I have managed to implement it based on the gist provided by @kritikinfo

hi, I use the similar method with https://gist.github.com/kritikinfo/1bc92d2a07b3b1516a9d.
I create a native container view such as RelativeLayout, and return it when client call createViewInstance(). However, I want to add its child asynchronously, and this child won't be displayed. It is because its measured width/height is 0, and it didn't trigger layout.
But if we measure and layout it, it would be displayed. Could someone tell me why? Thanks a lot.
public class MyViewManager extends SimpleViewManager {
private static final String TAG = "MyViewManager";
public static final String REACT_CLASS = "MyRelativeLayout";

public MyViewManager() {
}

@Override
public String getName() {
    return REACT_CLASS;
}

@Override
protected RelativeLayout createViewInstance(final ThemedReactContext reactContext) {
    final Context baseContext = reactContext.getBaseContext();
    if (baseContext == null || !(baseContext instanceof Activity)) {
        Log.e(TAG, "Base context is not an activity!");
        return null;
    }

    final RelativeLayout container = new RelativeLayout(baseContext);

    Handler handler = new Handler();
    handler.postDelayed(new Runnable() {
        @Override
        public void run() {
            TextView textView = new TextView(reactContext);
            textView.setText("hello world");
            RelativeLayout.LayoutParams lp = new RelativeLayout.LayoutParams(960, 150);
            // if we measure and layout it, it would be displayed
            //textView.measure(960, 150);
            //textView.layout(0, 0, 960, 150);
            container.addView(textView, lp);
        }
    }, 3000);

    return container;
}

}
const MyRelativeLayout = requireNativeComponent('MyRelativeLayout', iface);
render: function() {
return (

);
},


HIghly distorted point cloud surface

Required Info

Camera Model
D435

Firmware Version
(Open RealSense Viewer --> <IP_ADDRESS>)

Operating System & Version
LInux(Ubuntu 20.04 LTS)

Kernel Version (Linux Only)
(5.9.1-rt20)

Platform
PC

SDK Version
2.55.1-0

Language
C++

Segment
VR/AR

Issue Description
The point cloud surface generated by the camera is highly distorted and the edges are not preserved as well. How to generate a high quality point cloud surface for remotely rendering to a VR device (Meta Quest 3)?

Here's my modified code for obtaining the point cloud with post processing steps. Applying hole filling filter doesn't work either.
I tried using filters in other libraries such as PCL but it worsened the results.
#include <librealsense2/rs.hpp> // Include
#include "example.hpp"          // Include short list of convenience functions for rendering

#include <algorithm>         // std::min, std::max
#include <nlohmann/json.hpp> // to store pointcloud data to json format

using json = nlohmann::json;

// Helper functions
void register_glfw_callbacks(window &app, glfw_state &app_state);

int main(int argc, char *argv[])
try
{
    // Create a simple OpenGL window for rendering:
    window app(1280, 720, "RealSense Pointcloud Example");
    // Construct an object to manage view state
    glfw_state app_state;
    // register callbacks to allow manipulation of the pointcloud
    register_glfw_callbacks(app, app_state);

    // Declare pointcloud object, for calculating pointclouds and texture mappings
    rs2::pointcloud pc;
    // We want the points object to be persistent so we can display the last cloud when a frame drops
    rs2::points points;
    // Declare RealSense pipeline, encapsulating the actual device and sensors
    rs2::pipeline pipe;
    // Start streaming with default recommended configuration
    pipe.start();

    // Declare filters
    rs2::decimation_filter dec_filter; // Decimation - reduces depth frame density
    rs2::threshold_filter thr_filter;  // Threshold  - removes values outside recommended range
    rs2::spatial_filter spat_filter;   // Spatial    - edge-preserving spatial smoothing
    rs2::temporal_filter temp_filter;  // Temporal   - reduces temporal noise
                                       // Declare disparity transform from depth to disparity and vice versa
    rs2::hole_filling_filter hfill_filter;

    rs2::disparity_transform depth_to_disparity(true);
    rs2::disparity_transform disparity_to_depth(false);

    while (app) // Application still alive?
    {
        // Wait for the next set of frames from the camera
        auto frames = pipe.wait_for_frames();

        auto color = frames.get_color_frame();

        // For cameras that don't have RGB sensor, we'll map the pointcloud to infrared instead of color
        if (!color)
            color = frames.get_infrared_frame();

        // Tell pointcloud object to map to this color frame
        pc.map_to(color);

        auto depth = frames.get_depth_frame();

        // Generate the pointcloud and texture mappings
        points = pc.calculate(depth);

        dec_filter.process(depth);
        thr_filter.process(depth);
        spat_filter.process(depth);
        temp_filter.process(depth);
        hfill_filter.process(depth);
        disparity_to_depth.process(depth);
        depth_to_disparity.process(depth);

        // Get point cloud data as a 2D array of floats
        const rs2::vertex *vertices = points.get_vertices();
        size_t point_count = points.size();

        // Prepare vector to store point cloud data (x, y, z)
        std::vector<std::vector<float>> point_cloud_data;

        for (size_t i = 0; i < point_count; ++i)
        {
            // Extract x, y, z from each vertex
            float x = vertices[i].x;
            float y = vertices[i].y;
            float z = vertices[i].z;

            // Store point in vector
            point_cloud_data.push_back({x, y, z});
        }

        // Upload the color frame to OpenGL
        app_state.tex.upload(color);

        // Draw the pointcloud
        draw_pointcloud(app.width(), app.height(), app_state, points);

        // Send the point cloud data to Azure (optional, commented out)
        // send_point_cloud_data(point_cloud_data);
    }

    return EXIT_SUCCESS;
}
catch (const rs2::error &e)
{
    std::cerr << "RealSense error calling " << e.get_failed_function() << "(" << e.get_failed_args() << "):\n    " << e.what() << std::endl;
    return EXIT_FAILURE;
}
catch (const std::exception &e)
{
    std::cerr << e.what() << std::endl;
    return EXIT_FAILURE;
}

Hey @MartyG-RealSense,
could you help?

Hi @addy1997  There is a specific order that Intel recommend applying the post-processing filters in.  I have rearranged your list below into the Intel-recommended order.
dec_filter.process(depth);
depth_to_disparity.process(depth);
spat_filter.process(depth);
temp_filter.process(depth);
disparity_to_depth.process(depth);
hfill_filter.process(depth);
thr_filter.process(depth);
https://dev.intelrealsense.com/docs/post-processing-filters#using-filters-in-application-code
In regard to rendering to a Quest 3, you may find the detailed guide for Quest 2 at the link below to be helpful.
https://github.com/GeorgeAdamon/quest-realsense


[Core.VarInfo] Remove VarInfo.index

See https://github.com/yebai/Turing.jl/issues/367#issuecomment-345840292

This PR https://github.com/yebai/Turing.jl/pull/395 removes  VarInfo.index

PR https://github.com/yebai/Turing.jl/pull/395 merged


Non blocking mark occurences operation

I have made some changes to 'Mark occurences' task behaviour,
I am aware that these changes are not ideal, but the plugin was nearly unusable without them, every change in editor produced number of backround tasks. and even single task blocked eclipse more than necessary.
I have removed synchronized section in KotlinPsiManager, I think that in this case responsivity is primary goal and I have used SynchronizedMaps to synchronize access to cached projects and kotlin files to improve performance, I am using this modified plugin for several months without serious problems and without blocking events like 'Update occurance annotations' backround task.
I am not very experienced in opensource projects, so please forgive me if I have done something wrong, I will gladly learn how to do it properly.
https://discuss.kotlinlang.org/t/extremely-poor-performance-of-the-kotlin-plugin-for-eclipse/3397

I will reconcile it more befero asking for pull request

Thanks for your work @noemus
Looking forward to your renewed pull request.

I have corrected indentation (tabs) and simplified a little. Also checked for possible problems.


Improve output for ambiguous task names

As a user I can (and frequently do) use camel case on the command line to select a task I want to execute. This works well also in multi projects by using a path like :c:s-s:m:bui (or something like that).
When the tasks names are derived from other inputs that task name can become quite long it can be difficult to pick it out and visually execute it without just copying and pasting it, especially if generated by a plugin's NamedDomainObjectContainer or other objects.
Expected Behavior
I can think of a few possible improvements, I'm sure there are others.

Visually distinguish camel case characters with markup
Output each ambiguous task choice on another line
Prompt for input again based on the filtered tasks
Use something like https://github.com/gradle/gradle-completion (which I'm planning on doing anyways)

Current Behavior
For example, a current Gradle project I am looking it uses the java-gradle-plugin for development. It produces two plugins with similar names. Here is the output when running ./gradlew genP to see what one of the generated POMs would be.

What went wrong:

Task 'genP' is ambiguous in root project 'qms-tools'. Candidates are: 'generatePomFileForPluginMavenPublication', 'generatePomFileForQmsProjectPluginMarkerMavenPublication', 'generatePomFileForQmsSubprojectPluginMarkerMavenPublication'.

Looking at a terminal at going from genP to genPFFQP, genPFFS, or gPFFM are all difficult to see and figure out without having to type most of the task.
Context
See above example
Your Environment
Gradle 4.2.1

I think using Gradle completion is probably the best way to go here. Would that be a satisfactory answer for you?

@oehme I think that is a better solution, closing this.


Slice 141

Coverage remained the same at 71.684% when pulling ef21164952dcc17d2faa3fdfa121767888767a32 on SLICE-141 into 50c2317b460460de153550b4d92f7d1cf5dd301d on master.


KA50.3 "Options" command does not activate AI Comms Menu

Describe the bug
DCS OB version <IP_ADDRESS>759
Vaicom version <IP_ADDRESS>
Tested in KA50 BS3 - Vaicom although recognizes the "Options" command but pop the AI comms menu. I did not assign keyboard bindings to either "Alt + " and "".
Tested in Mi-24 - This issue does not occur here, works fine 100%.
To Reproduce
Steps to reproduce the behavior:

Start Vaicom, issue the "Options" command but that doesn't bring up the ai comms menu.
Press Keyboard "Alt + ", it doesn't work either.
Close/exit Vaicom,
Press Keyboard "Alt+ " again, ai comms menu displays correctly.

In summary, it appears that whenever Vaicom is running, it prevents the ai comms menu from displaying.
Expected behavior
Isssuing "Options" command should bring up the ai comms menu.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about

This should be fixed in Beta v <IP_ADDRESS>. Waiting for feedback to close.

I have this issue in the Mossie on <IP_ADDRESS>

Hi,
Thanks for letting me know about the fix for KA50, I'll retest the beta ver
and revert with the outcome.
Regards,
Steven
On Wed, May 3, 2023 at 5:47 AM Badger @.***> wrote:

I have this issue in the Mossie on <IP_ADDRESS>
—
Reply to this email directly, view it on GitHub
https://github.com/Penecruz/VAICOMPRO-Community/issues/77#issuecomment-1532053778,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ7F4FFJYIFBFR5KNM7653TXEFQDNANCNFSM6AAAAAAUZ5NHXM
.
You are receiving this because you authored the thread.Message ID:
@.***>

DCS OB with latest patch <IP_ADDRESS>731 released on Apr 4th '23.
I retested Vaicom Pro Community Beta Ver for KA50 BS3
Issue 1: AI Comms menu
a. Make sure "Allow Options" is ticked (selected) in the config menu (alt + Ctrl + C).
b. While the helo is on the ground, press PTT e.g. TX1 or any TX to begin transmit, say "Options" will pop the AI menu. Do not release the PTT yet, continue with e.g. "Take 1" or "Take 2" - Result: OK
c. While the helo is airborne anything above 3 meters (just a few feet up in the air will do), press e.g. TX1 to begin transmit, say "Options", AI menu does not pop unless manually press keyboard "Alt + " several times repeated. - Result: NOT OK
Issue 2: Kneeboard
a. While the helo is on the ground, press PTT e.g. TX1 or any TX to begin transmit, say "Kneeboard" and continue with page command. Result: OK
b. While the helo is airborne a few meters/feet will do, press PTT, say "Kneeboard" but nothing happens. Result: NOT OK
Summary
It's unfortunate that the reported issues continue to persist, not fixed....

Fixed in next release


message feed ui: added new approach to mark message as unread

Added new approach for mark as unread message as suggested in the issue
Fixes: #24263

@timabbott hey can you please check if we need anything else here

This looks plausible; can you post before/after screenshots of profiling using the browser developer tools "mark as unread" when looking at a PM conversation with just a handful of messages?
You may need to use manage.py populate_db -n 2000 to have more message history in your development environment in order to have things be slow enough to see improvement in a profile.

@timabbott ran the provided command to populate the db and here are some profiling results
Before

After

Merged after rewriting the commit message, thanks for the screenshots @hdck007!
Please read the commit message that was integrated -- it's important to have that kind of explanation of what problem we're solving and why in every commit, as well as the code that auto-closes the original issue -- about as important as the changes themselves to a large open source project.


add tmp dir to npmignore fix #12

I'm sorry, I already had this done, but I couldn't push from the underground. Published in 0.1.2


lockPassword property does not lock connection edition

System information:

Operating system (distribution) and version : Windows 10 Pro
DBeaver version : Version <IP_ADDRESS>111141807
Additional extensions : Git Support / Office Support / DevStyle

Connection specification:

Database name and version : Any type of database has the same problem
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
I'm trying to add a lockPassword property in my .data-sources.json but the editing connection is not lock.
by example
...
"folder": "DB2 for i/dev - Release Maintenance",
"lockPassword": "e4a51326ea0c5da710b9f4cd2773e3db",
"configuration": {
...
Include any warning/errors/backtraces from the logs
No error log
Thank you

Thank you for the report.

Can't reproduce.  When lockPassword  property is set then DBeaver asks for password before configuration change.
It allows to open connection edit dialog though.

HEllo,
I test with a new fresh "zip" windows 64 bit version and i reproduce. In the dbeaver-debug log i've got this message
Service 'org.jkiss.dbeaver.runtime.ui.UIServiceSecurity' not found
Is it linked to my issue ?
Thank you

Fixed

Verified


Get part sizes from part family

https://forum.dynamobim.com/t/pipe-network-from-points/69993/2?u=mzjensen
https://forum.dynamobim.com/t/camber-feedback-thread/68942/83?u=mzjensen


add output folder

Putting output in a folder is a good idea, I'll merge accept it in. It errors if the folder isn't present though.
Can you add a folder '/output' to the project and modify the request or maybe check if the folder exists and create it if not?
import os if not os.path.exists('my_folder'):     os.makedirs('my_folder')

Thank you! add folder existing check

Looks good, thanks!


Updated Viewport docs

Filled out a few missing enum descriptions and updated the description to reflect changes in the Godot3

Thanks!

Cherry-picked into 3.0.4.


merge 2.12.x to 2.11.x

including the big splitting-up of the config file

queued: https://scala-ci.typesafe.com/view/scala-2.11.x/job/scala-2.11.x-integrate-community-build/1355/


Make audit more reliable

bors r+
🤖

@matklad, might I ask you to elaborate on what happens with npm audit?

https://github.com/rust-analyzer/rust-analyzer/runs/511162809?check_suite_focus=true#step:5:8
Seems like a transient network error. I've seen this several times already.

Okay, I'd suggest to mention such relevant info in commit messages though...


Review Ticket

Python Quiz: Link
Tool Check: Link
Notes tab: [Link](https://kalanicabralomana.github.io/Fastpages/notes/)
Post with image: Link
Docx File: Link
Tags: Link
Fastpages Website: Link

Kalani Cabral-Omana
Grade: 2.7+

Added a python quiz using different code from what the teacher had
Made a tool link so that you can see all of the tools that are used and downloaded by him
Added a notes tab that has all of his vocab and notes from this class and previous classes
Imported a Docx File


Handle proxy authentication

This PR makes Code handle the app.on('listen' event from Electron, thus supporting proxy authentication.

Any progress on that or ETA when it will be merged. I really need access from behind the authenticated corporate proxy. Thank you!

Sorry, in what version was this landed?

@ninrod This was released in 1.15, which came out on 10 August 2017.

Michaelpeoni Webdr1 referenced this pull request on Feb 11, 2019
issues reaching repositories do to http://go.microsoft.com/fwlink/p/?LinkId=255141


Remove font height restriction from Button

Possible fix #35005
The button height is determined by the text buffer, so additinally using font height is not necessary.

How does this behave when the button is within a Container with no custom minimum size set?

It shrinks to the stylebox size (the same as show in the GIF). This change only affects buttons without text, so it doesn't break anything in majority of the cases.

@Geometror OptionButton will be handled by #59303, other buttons don't really have this problem.

Just noticed that some Color inspector properties are squished heavily:
Before->after:

Maybe bruvzg's suggestion makes sense actually...

Just noticed that some Color inspector properties are squished heavily: Before->after:

This is actually a good thing and the fix working as intended, IMO. ColorPickerButton shouldn't depend on the height of the font, and we should just adjust its theme properties to give it more initial height to match the UI.

The shrinking is still present (at least in color theme overrides section) but I agree with what @YuriSizov said, this could be fixed by adjusting the ColorPickerButton style/minsize (in this or a subsequent PR).

I think this can be merged. The tweaks needed for the editor UI can be done separately.

Thanks!


Adding doomsday algorithm in python

@OtacilioN  have you seen this?

What a great code :smile: !
Just a little tip, its good to always put a description on your PRs to make more understandable.
Thank you for contributing! :rocket:


Bayesian Optimizer metric maximization

Hi there,
Is it possible for guild run --optimizer bayesian to somehow maximize the training metric instead of minimizing it? Can it be specified in any way?
The easiest workaround I see is to simply print out the negation of the metric, so the optimizer will minimize the negation -> maximize the actual metric. But this is then a bit troublesome in the guild compare dashboard.

Nevermind, it seems that --maximize accuracy works just fine. From the documentation I though it can be used with workflow only.


Valid Api Name Required error occurs for funds & account API names

I see other endpoints like historical_trades, open_orders, all_orders are responding.  But funds and accounts are raising exceptions as below
Traceback (most recent call last):   File "/Users/digiajay/Documents/Projects/Bitbucket/aj_wazirx/strategy_1.py", line 37, in <module>     funds = (client.send('account',{"timestamp": int(time.time() * 1000)}))   File "/Users/digiajay/Documents/Projects/Bitbucket/aj_wazirx/wazirx_sapi_client/rest/client.py", line 35, in send     raise BaseException("Valid Api Name Required") BaseException: Valid Api Name Required

Look inside the api_mapper.json, you should use "funds_info" for funds and "account_info" for account info.

I think this issue has been resolved. Closing this issue


#231

See #231 for more info.
Originally posted by @panthersdude2001 in https://github.com/openstreetcam/openstreetcam.org/issues/230#issuecomment-520258472

Closing due to points NOW showing up finally!


Check for styl.sourcemap before assigning sourcesContent

Fix #77

The tests have no problem passing. But when running npm run test-build the solo webpack build fails. The -d flag passed to webpack-dev-server, turning on debug mode, includes a sourceMap value.


[ENHANCEMENT] adjust resources + limits for core deployment since it now has responsibilities of operate, zeebe, and tasklist

Describe the use case:
In 8.7-alpha, we introduced a new "core" deployment type which will combine zeebe, operate, and tasklist . However, we still have the same resource requests and limits that zeebe had before despite it needing to respond to operate and tasklist requests and perform the steps that the operate importer and exporter would normally do.

Describe the enhancement/feature:
I would suggest we take the requests and limits for each application, and add them together for our new requests and limits for the core deployment.  I would be open for other suggestions as well for what those requests and limits should be.
One minor concern I have about bumping these numbers up is that this may prevent scheduling the core deployment on nodes that do not meet the requests.  So any solution we come up with for this issue should take that into account.

Desired outcome and acceptance tests:

Please see https://zeebe-io.github.io/zeebe-chaos/2024/11/14/Impact-of-Camunda-Exporter-on-processing-performance/ for some input in sizing


Transactions List should be able to clear all transactions

I'm going to consolidate this with issue #797 . They're both similar issues and logically can be in the same PR. Will modify the description on that issue


Crash when hoppers place items

Seems like after i placed hoppers down when someone opens one of my chests or the hoppers place an item in a chest ive created in crashes my game I dont even need to be near them when they open it

Please provide your log files from BepInEx/LogOut.log from both players while this happens

Closing this without further information. Feel free to reopen if this still occurs and you can provide more information.


Async providers

Investigate async providers

http://google.github.io/dagger/producers.html
I am not really convinced by the relevance of this feature. We had some futures at some point in TP codebase as well. But we decided to remove it because it was enlarging the scope of the library, and this holds true as well for Dagger 2.
Personally, I don't think a DI lib should take care of this, and it can actually be done in a cleaner way via Rx Java for instance, using reusable pools and limiting the adherence to the lib to concurrency APIs.
@dlemures, what do you think if you close the issue ?
Thx to Евгений from Mobius 2017 for mentioning the issue.

@stephanenicolas, you're welcome :) Actually I asked this question only because of curiosity. In my opinion, this feature is too specific and it certainly will make your library too "heavy". Toothpick looks awesome because it's simple and works absolutely transparently. So I wish you to keep it this way.

Thx @katella for pointing out this feature though. I close the issue. See you around !


Update deprecation warning s/6/7/

See https://github.com/isaacs/node-graceful-fs/issues/61#issuecomment-215514206 — that message is not correct.
Only a runtime warning landed in Node.js 6.0, that warning will be turned into a throw in Node.js 7.0.
Refs: nodejs/node#6413, nodejs/node#5213, nodejs/node#5102.

The initial graceful-fs deprecation message was fine, but it was mistakenly changed in #61.

Aha!  Sorry for my confusion.  Updated deprecation warning.  Thanks for the update.

@isaacs Thanks!


Revert "Change name of metadata directory"

This reverts commit 88220cf40562bbc9a8b9b7f686e3c6697f8cc184, which fixes #35.
This statement gives the location of the installed model metadata. Changing it here in the babelizer causes problems downstream--it confuses the model_metadata package, which raises an exception from within pymt. I didn't fully understand the consequences of this change when I made it.

@mdpiper sorry, I should have caught this.
As part of this pull request, would it be possible for you to add a test that checks that metadata files are installed correctly?

@mdpiper sorry, I should have caught this.
As part of this pull request, would it be possible for you to add a test that checks that metadata files are installed correctly?

@mcflugen I shouldn't have messed up! I'll make a test.

@mcflugen I shouldn't have messed up! I'll make a test.

@mcflugen Added test code. It's ugly, though; any suggestions for improvement are welcome.

@mcflugen Added test code. It's ugly, though; any suggestions for improvement are welcome.


Test SDK does not record all requests in recording mode

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command

Describe the bug

I cannot find the matcher in my recorded yaml if there are many same request.
To Reproduce

I have a command with more than one PATCH request to one resource.
Delete the recording yaml
Run the test, the request only recorded once.
When re-run the test, it cannot find the correct mapping. See https://github.com/kevin1024/vcrpy/issues/516

Expected behavior

I belive this line only count live mode in but ignore the record mode.
Environment summary

Additional context

@jiasli for awareness

My gut feeling tells me some usage is wrong. If Azure CLI test framework did have such bug, it would have affected us since long time ago.


better logging for http spawn errors

Currently, if there's a problem spawning the HTTP server, the output will look something like this:
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', src/http/mod.rs:168:55
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

That error was caused because it couldn't bind to the port (because of permission reasons). This should be fixed to better show why there was a problem, because it's hard to diagnose.

fixed with 69fc405cbe722bd11583cd0a84c65df33de0dc52


Add update method to Call

Provides an update method on a Call model, allowing the user to POST updated properties to the represented call object as per the API.
This is a one liner in terms of implementation, which seems suspiciously simple...

I also, as should be evident, improved the DRYness of the Call tests. Those literal JSON definitions were quite messy.


azurewebsites.net

Hi All :)
So currently I am running EHconsole, and seeing my wonderfull data stream.
If I log into the name.azurewebsites.net I just see a blank page... do I need some java or whatever to see the graphs?

If you see your data stream in EHConsole, then the Pi is set up correctly and sending data to EH. If you see the website below and it shows “connected” in the bottom left corner, you have the website set up correctly. That seems to indicate that you have incorrectly set up the data strings from your sensors. If you are using the Arduino and weather shield, I would look at the INO file and make sure it is correct.
Can you copy 6-10 lines of the data you see in EHConsole into here? We could see immediately if that is the issue.

Hmmmm currently having issues with programming my Arduino, will get back to you asap

Hi Ruben. Curious to know if you were able to fix your Arduino setup?

Hi all,
I've sort have had a shift in working responsibilities hehe but as far as I know:
After the Pi started to communicate with the azure website, there came a problem with reading the string from the Arduino. It might only be a coincidence (I have not been able to pinpoint the start of the problem), but for some reason, the JSON string read complete gibberish...
import serial
ser = serial.Serial('/dev/ttyACM0', 9600)
while 1:
textln = ser.readline()
print(textln)
This being my python script (running on my Pi) just to view the info being sent from the Arduino.
My .ino file looks like this:
#include "dht.h"
#define dht_dpin A0
#define ldr_dpin A1
dht DHT;
// Constants used for the ConnectTheDots project
// Disp value will be the label for the curve on the chart
// GUID ensures all the data from this sensor appears on the same chart
// You can use Visual Studio to create DeviceGUID and copy it here. In VS, On the Tools menu, click Create GUID. The Create GUID
// tool appears with a GUID in the Result box. Click Copy, and paste below.
//
char GUID1[] = "019d2910-d224-11e4-8830-0800200c9a66 ";  //generated by wwww.famkruitfoh.net/uuid/uuidgen - universally unique identifier - according to www.ietf.org/rfc/rfc4122.txt
char GUID2[] = "7f354d10-d2e9-11e4-8830-0800200c9a66 ";
char GUID3[] = "8bbb7a50-d2e9-11e4-8830-0800200c9a66 ";
char Org[] = "Company ";
char Disp[] = "Current conditions: ";
char Locn[] = "The Loft ";
char Measure1[] = "Temperature: ";
char Units1[] = "C ";
char Measure2[] = "Humidity: ";
char Units2[] = "% ";
char Measure3[] = "Light: ";
char Units3[] = "% ";
char buffer[300];
char dtostrfbuffer[15];
void setup()
{
Serial.begin(9600);
delay(700);
}
void loop()
{
DHT.read11(dht_dpin);  //call library function - temperature and humidity
delay(1000);  //stability
float light_level = analogRead(ldr_dpin);  //read ldr level
light_level = (light_level-20)*100/180;  //conversion to percentage light (an estimation of light required)
// print string for temperature, separated by line for ease of reading
// sent as one Serial.Print to reduce risk of serial errors
memset(buffer,'\0',sizeof(buffer));
strcat(buffer,"{");
strcat(buffer,""guid":"");
strcat(buffer,GUID1);
strcat(buffer,"","organization":"");
strcat(buffer,Org);
strcat(buffer,"","displayname":"");
strcat(buffer,Disp);
strcat(buffer,"","location":"");
strcat(buffer,Locn);
strcat(buffer,"","measurename":"");
strcat(buffer,Measure1);
strcat(buffer,"","unitofmeasure":"");
strcat(buffer,Units1);
strcat(buffer,"","value":");
strcat(buffer,dtostrf(DHT.temperature,8,2,dtostrfbuffer));
strcat(buffer,"}");
Serial.println(buffer);
/* delay(1000);  //stability
// print string for humidity, separated by line for ease of reading
memset(buffer,'\0',sizeof(buffer));
strcat(buffer,"{");
strcat(buffer,""guid":"");
strcat(buffer,GUID2);
strcat(buffer,"","organization":"");
strcat(buffer,Org);
strcat(buffer,"","displayname":"");
strcat(buffer,Disp);
strcat(buffer,"","location":"");
strcat(buffer,Locn);
strcat(buffer,"","measurename":"");
strcat(buffer,Measure2);
strcat(buffer,"","unitofmeasure":"");
strcat(buffer,Units2);
strcat(buffer,"","value":");
strcat(buffer,dtostrf(DHT.humidity,6,2,dtostrfbuffer));
strcat(buffer,"}");
Serial.println(buffer);
delay(1000);  //stability
// print string for light, separated by line for ease of reading
memset(buffer,'\0',sizeof(buffer));
strcat(buffer,"{");
strcat(buffer,""guid":"");
strcat(buffer,GUID3);
strcat(buffer,"","organization":"");
strcat(buffer,Org);
strcat(buffer,"","displayname":"");
strcat(buffer,Disp);
strcat(buffer,"","location":"");
strcat(buffer,Locn);
strcat(buffer,"","measurename":"");
strcat(buffer,Measure3);
strcat(buffer,"","unitofmeasure":"");
strcat(buffer,Units3);
strcat(buffer,"","value":");
strcat(buffer,dtostrf(light_level,6,2,dtostrfbuffer));
strcat(buffer,"}");
Serial.println(buffer);*/
delay(1000);  //stability
}// end loop()
At first I thought the error might be because I am sending 3 Serial.println so I commented out the last two, but the problem persists.
Is there a way that you know of to check for interrupts on the Arduino maybe? Or some reason the serial communication protocol might be clashing with the ethernet communication? The reason I am asking, is because if I connect the Arduino directly to my laptop, I can program it fine (now that I think about it, I didnt check the serial data being sent back)...
Blegh. Anyway, I am sure this not really in your scope of work to test arduino's :P so don't worry about this. At the moment I need to learn app programming, so my Arduino is going back into the box for a while...
Thank you so much for your support in everything.
Oh, and regarding that deploy.cmd... I just added sudo in front of every command, and that sorted it out. And I specified the direct file path of my project. (not just ../../)


[ES-1205037] Reproduce counter reset with merge iter unit test

please check out the branch and run the unit test. No plan to merge.

Did the test case pass when you ran it on your laptop? @yuchen-db
[hc.zhu@XYVT3X7065 ~/thanos(db_main)] go test github.com/thanos-io/thanos/pkg/dedup
ok      github.com/thanos-io/thanos/pkg/dedup   1.749s

Did the test case pass when you ran it on your laptop? @yuchen-db
[hc.zhu@XYVT3X7065 ~/thanos(db_main)] go test github.com/thanos-io/thanos/pkg/dedup
ok      github.com/thanos-io/thanos/pkg/dedup   1.749s

It failed on my laptop

Did the test case pass when you ran it on your laptop? @yuchen-db
[hc.zhu@XYVT3X7065 ~/thanos(db_main)] go test github.com/thanos-io/thanos/pkg/dedup
ok      github.com/thanos-io/thanos/pkg/dedup   1.749s

looks like you were on the db_main branch

UPDATE: after removing resets in raw data the unit test PASSed. Prob need to use another piece of data or so.


Failed to read file: {DIR}/botframework-emulator/server.json

I've got this error only on Windows (Win 10) but I'll check at home on OS X.
Is this expected to get this error when running with clean state? I'm running emulator from source code.
The file is not yet created at all (server.json) hence that error. There are other files in emulator data directory, like client.json.
https://github.com/Microsoft/BotFramework-Emulator/blob/82b84e5975351b321258f502803966afb2b99217/src/utils.ts#L66
Full error:
><EMAIL_ADDRESS>start C:\dev\BotFramework-Emulator
> electron .

Failed to read file: C:\Users\{USER}\AppData\Roaming\botframework-emulator/botframework-emulator/server.json
{ Error: ENOENT: no such file or directory, stat 'C:\ Users\{USER}\AppData\Roaming\botframework-emulator\botframework-emulator\server.js
 on'
    at Error (native)
    at fs.statSync (fs.js:992:18)
    at Object.fs.statSync (ELECTRON_ASAR.js:285:16)
    at Object.exports.loadSettings (C:\dev\BotFramework-Emulator\app\utils.js:55:23)
    at Object.exports.getStore (C:\dev\BotFramework-Emulator\app\server\settings.js:61:39)
    at Object.exports.startup (C:\dev\BotFramework-Emulator\app\server\settings.js:114:13)
    at Function.Emulator.startup (C:\dev\BotFramework-Emulator\app\server\emulator.js:62:18)
    at Object.<anonymous> (C:\dev\BotFramework-Emulator\app\server\main.js:143:25)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
  errno: -4058,
  code: 'ENOENT',
  syscall: 'stat',
  path: 'C:\\Users\\{USER}\\AppData\\Roaming\\botframework-emulator\\botframework-emulator\\server.json' }
restarting Emulator because undefined !== 9002

It this expected - as I haven't yet started local bot server?
Thanks!
Windows 10
Node 6.9.* (LTS)

This being a young application we wanted to err on the side of verbosity when errors happen, so that users would be able to provide details when they report issues.
This particular instance isn't actually reporting an error state, just a failure to find the file, which is fine.
We'll make the app less spammy over time.


[SPARK-15100][DOC] Modified user guide and examples for CountVectorizer, HashingTF and QuantileDiscretizer

What changes were proposed in this pull request?
This is partial document changes to ml.feature. Made changes to CountVectorizer, HashingTF and QuantileDiscretizer
How was this patch tested?
Unit test and manual testing

Can one of the admins verify this patch?

(@GayathriMurali It seems the title is incomplete ending with ... Maybe it would be nicer if the title is complete and rebased for the conflict)

@hhbyyh Can you please help review this? I will resolve the branch conflict along with review comments

ok to test

Test build #58967 has started for PR 13176 at commit 46408bb.

Test build #58967 has finished for PR 13176 at commit 46408bb.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58967/
Test PASSed.

Test build #59014 has started for PR 13176 at commit e0b1c38.

Something messed up the git push.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59014/
Test PASSed.

@oliverpierson @GayathriMurali I opened #13228 for the relativeError param as well as cleaned up doc for QuantileDiscretizer

@MLnick The latest commit includes just the ml-feature.md changes. I removed all the other example files and feature.py.

Test build #59032 has started for PR 13176 at commit 490a8e8.

Test build #59032 has finished for PR 13176 at commit 490a8e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59032/
Test PASSed.

Test build #59036 has started for PR 13176 at commit 901fb6d.

Test build #59036 has finished for PR 13176 at commit 901fb6d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59036/
Test PASSed.

@MLnick I fixed all review comments. Can you please let me know if there is anything else to be done to help get this merged?

Test build #59171 has started for PR 13176 at commit 27acda3.

Test build #59171 has finished for PR 13176 at commit 27acda3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59171/
Test PASSed.

Merged build finished. Test PASSed.

@GayathriMurali thanks. Made another small comment to make the descirption of the binary parameter consistent. Also please check the QuantileDiscretizer example in the guide (not the example code but the little example section in the guide). It either needs to be updated to reflect the output of QuantileDiscretizer with default error param, or we need to add a sentence about "computing exact quantiles" to make it match up.

Test build #59222 has started for PR 13176 at commit 1028995.

Test build #59222 has finished for PR 13176 at commit 1028995.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59222/
Test PASSed.

Merged build finished. Test PASSed.

Test build #59328 has started for PR 13176 at commit ba832aa.

Test build #59328 has finished for PR 13176 at commit ba832aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59328/
Test PASSed.

Test build #59399 has started for PR 13176 at commit 39d3dfb.

Test build #59399 has finished for PR 13176 at commit 39d3dfb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59399/
Test PASSed.

@MLnick Please let me know if there is anything else that I can help with this PR

LGTM - my internet connection is a bit patchy as I'm traveling. Will merge later today.

@MLnick @oliverpierson I checked again with a clean build off master. Here is the hash : 2bfc4f15214a870b3e067f06f37eb506b0070a1f. Here is what I see

@GayathriMurali Looks like it could be an issue with bucketing, but I'm not sure how.  What does df.stat.approxQuantile("hour", Array(1.0/3, 2.0/3), relativeError=0.001) return?

I get this : Array[Double] = Array(5.0, 8.0)

That's wild.  I'm getting Array[Double] = Array(2.2, 5.0) and I'm guessing @MLnick is also.  approxQuantile is deterministic so I'm not really sure why we're getting different results.  Perhaps @thunterdb might have an idea?

I'm also getting the same results as @MLnick and @oliverpierson , also getting Array(2.2, 5.0) from the stat call.  My env is:
master (updated this morning) on d67c82e4b647dacd0b789d72c9eaf4dc7d329dbd
RHEL 7
OpenJDK 64-Bit Server VM, Java 1.8.0_77
Scala version 2.11.8

@BryanCutler @oliverpierson Looks like something is wrong on my side. I just checked again on a fresh build and got the same results. Will dig deeper.

Yeah I get the following
scala> df.stat.approxQuantile("hour", Array(1.0/3, 2.0/3), relativeError=0.001)
res1: Array[Double] = Array(2.2, 5.0)

env:
on Mac, Scala version 2.11.8 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_77)

@GayathriMurali what environment are you using?

On Mac. Scala version 2.11.8 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_73). I checked again and I consistently get the same output on master. @MLnick Please let me know how you would like to proceed. Should I go ahead and change the example in the doc and investigate further on my end?

Scala version 2.11.8 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_77) on my machine.

I will try as well this afternoon.

@GayathriMurali what master are you using for spark-shell? If using local[4] I get the same result as you (default for me is 8 threads), so probably due to difference in parallelism (merging the approximations)?

@MLnick I am using local. I havent explicitly setup thread count.

Can you check with sysctl -n hw.ncpu?

I just did. It is local[4]

I just tried with --master local[8] and I get the same results as you do. Should I call this out in the example?

Ok, at least we know the issue now.
I'd say we can leave the example as is, but let's add something like:
Given `numBuckets = 3`, and computing exact quantiles (by setting `relativeError = 0`), we should get the following DataFrame:

This makes it clear (and also independent of the hardware setup people may have).

That would require setting relativeError to 0 in the examples however. Open to other suggestions.

@MLnick  +1 for making the change in the example as well. Calling out difference in result due to parallelism might be little confusing in this document.

Test build #59694 has started for PR 13176 at commit 4b1a1fa.

Test build #59694 has finished for PR 13176 at commit 4b1a1fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59694/
Test PASSed.

@MLnick Please let me know if there is anything else that I can help with this PR

We'll need to update the Java and Python examples accordingly too.

@MLnick I agree. Should I make those changes in this same PR?

Yes, you can do it in this one.

Test build #59913 has started for PR 13176 at commit 5df77c3.

Test build #59913 has finished for PR 13176 at commit 5df77c3.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59913/
Test FAILed.

Merged build finished. Test FAILed.

Test build #59915 has started for PR 13176 at commit 5a53051.

Test build #59915 has finished for PR 13176 at commit 5a53051.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59915/
Test PASSed.

Test build #59964 has started for PR 13176 at commit 881a2fc.

Test build #59964 has finished for PR 13176 at commit 881a2fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59964/
Test PASSed.

Test build #60322 has started for PR 13176 at commit 87844ef.

Test build #60322 has finished for PR 13176 at commit 87844ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60322/
Test PASSed.

Merged build finished. Test PASSed.

@MLnick Please let me know if there is anything else I can do to help get this merged.Thanks!

Can the issue with different results be fixed by making sure the DataFrame has a single partition?  It'd be great not to have error = 0 in the examples.

@jkbradley the different results was due to the difference in underlying core count(thread count). @MLnick  and I were able to get the same results for local[4]. We could explicitly specify this in the example and get rid of the error = 0.

Did you try setting this up so the data has 1 partition only?  That would likely fix the issue with varying # cores affecting results.
Also, can you please create a new JIRA for this PR to make it clear in JIRA what it is addressing?  Please link it to SPARK-15100.  Thanks!

@jkbradley I just tried this.

and getting this output which is the same as the one in the example

I will create a new JIRA and link this PR to that. Thanks!

@jkbradley @MLnick I have created SPARK-15997 to track the changes addressed in this PR.

@GayathriMurali why did you close this? I'm sorry it is taking a while, but everyone has been pretty swamped over the past few weeks in the lead up to Spark Summit and trying to get 2.0 ready for an RC.
This would have been simpler if not for the partition issue. I think we can figure out an approach easily to ensure 1 partition in the examples (e.g. use repartition or similar).

@MLnick I opened PR #13745 to track this as @jkbradley suggested. This JIRA is only doing partial list of Audit ml.feature. Please help review SPARK-15597.

It would have been easier to keep this one open I think as it has all the comment history. Anyway, I commented on #13745.

@GayathriMurali Thanks for the update.  For future cases like this, I support creating a new JIRA specific to the task at hand, but agree with @MLnick about keeping the same PR and just changing the title to link it to the new JIRA.  No big deal though.

@jkbradley @MLnick  My bad. Sorry about that!


Tee and Join pipeline

Add tasks for Tee (duplicator) and Join (tupling).

The code looks good if https://github.com/Idein/actfw-core/issues/17 fixed.  We should wait for #17 and postpone merging this PR.

The change looks good :+1:


Typo when defining the fingerprint

I found a typo in the elastic-container.sh on line 90, it should not be "docker compose"   fingerprint=$(docker compose exec -w /usr/share/elasticsearch/config/certs/ca elasticsearch cat ca.crt | openssl x509 -noout -fingerprint -sha256 | cut -d "=" -f 2 | tr -d :) If you change it to docker-compose  it should work
Originally posted by @OzzyKampha in https://github.com/peasead/elastic-container/issues/8#issuecomment-1229241931

Thanks for the issue, @OzzyKampha
Are you experiencing an issue with the fingerprint being populated in the Fleet settings in Kibana or were you reviewing the shell script?
Background
docker compose exec... is the equivalent subcommand of docker exec... when targeting a Compose service. This is defined in the Docker documentation here.
Running with docker compose exec... returns the SHA256 hash (hash will be different per installation):
$ docker compose exec -w /usr/share/elasticsearch/config/certs/ca elasticsearch cat ca.crt | openssl x509 -noout -fingerprint -sha256 | cut -d "=" -f 2 | tr -d :
7CCBD40E7DD1414CB65D8C042167D292AEBA570B57DE07B4AE330482093796A2

Running with docker exec... returns the same SHA256 hash:
docker exec -w /usr/share/elasticsearch/config/certs/ca elasticsearch cat ca.crt | openssl x509 -noout -fingerprint -sha256 | cut -d "=" -f 2 | tr -d :
7CCBD40E7DD1414CB65D8C042167D292AEBA570B57DE07B4AE330482093796A2

Here I see the fingerprint that is the same as shown above from the CLI.

Running with docker-compose exec... returns an error
$ docker-compose exec -w /usr/share/elasticsearch/config/certs/ca elasticsearch cat ca.crt | openssl x509 -noout -fingerprint -sha256 | cut -d "=" -f 2 | tr -d :
-----BEGIN CERTIFICATE-----
MIIDSTCCAjGgAwIBAgIUAZhR/PSu1MIISFGI6t8VpeEKq2YwDQYJKoZIhvcNAQEL
BQAwNDEyMDAGA1UEAxMpRWxhc3RpYyBDZXJ0aWZpY2F0ZSBUb29sIEF1dG9nZW5l
cmF0ZWQgQ0EwHhcNMjIwODI4MjA0MjA5WhcNMjUwODI3MjA0MjA5WjA0MTIwMAYD
VQQDEylFbGFzdGljIENlcnRpZmljYXRlIFRvb2wgQXV0b2dlbmVyYXRlZCBDQTCC
ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAIZdNV84gPdkXwKTwQuA8PK7
+MHA0ZQVAvNiOfAPB3NwiyO/xbYc6YwBuhbz+Lt/XSuuE+AdEuPcHsf35y8VYly7
LW6+1QxWym8RGzD+mwfqPjgU+Ry2dHNMewQe9L9WqTpufUWqH+sj5jjHNPbLX4X2
hNbsu55DZrqDCQF2wkmTopYmmKJqEyJV6TQQrNFn0COjfMQ0l7YEhcQtdeWvnvs0
aqb7QJzJHHD2sU3shM5e659rUOHDRbsAYSSWge/M3S4isigxfjzLLk6/my847+D+
Iz8f9LIu/4oSdU5X6YGxIRgNgMA90+VpyxuNMJZ3kUOLq8yy3VQKu5Q5dGGJEEEC
AwEAAaNTMFEwHQYDVR0OBBYEFBo6IcnHxz5vcYGZ1XP48fwOavDDMB8GA1UdIwQY
MBaAFBo6IcnHxz5vcYGZ1XP48fwOavDDMA8GA1UdEwEB/wQFMAMBAf8wDQYJKoZI
hvcNAQELBQADggEBAC0a8pyaszeAylb28pyncdrmsb2JRvG9BAqLBkZYYDeK13BI
cG/hY97Hvv7s3KQSQDgj7wJ/kNJ0j0t7AS52QMw5+wcQzMf9cADr1r53FYok2DYx
C3gSN+ek8v8qu0Qbt+FdUatrawM9PPpIpXxU3hRa7nmy/eYV+fiXDrJazNb1FpuA
PBGe4j/lSX6d27lj98+4EaGm+b1oFA/tG/umF6Gu+ktnPEwSgsTIBYDj7UEzSqWL
sZJUbVnrujpHh8kLevJqXAaA7DVA0as1aAZQ/2VivbM147bzTfHqS1HBqcYBRjMb
UAhlsi4R705WhilAKpBpRFA1Hx4wQsOl8ddJT+4=
-----END CERTIFICATE-----
unable to load certificate
4376446508:error:09FFF06C:PEM routines:CRYPTO_internal:no start line:/AppleInternal/Library/BuildRoots/b6051351-c030-11ec-96e9-3e7866fcf3a1/Library/Caches/com.apple.xbs/Sources/libressl/libressl-2.8/crypto/pem/pem_lib.c:684:Expecting: TRUSTED CERTIFICATE

Whelp...found the problem.
With Linux (tested on Ubuntu and Fedora), you need the docker-compose-package...which we didn't have in our documentation as a prerequisite. We'll adjust that with a PR this week.


Upgrade to iced 0.7

Only minor changes are needed to compile against iced 0.7.
I have tested all the programs in examples/ and they all compile, run and seem to work.
Updated iced_native to 0.8, iced_graphics to 0.6, iced_style to 0.6, iced to 0.7.
Examples time_picker and date_picker give deprecation warnings for chrono, but that is unrelated to the changes made.
There's some cargo fmt changes that should probably be done too, but I only applied formatting to code I changed in this PR.

@genusistimelord If I do further changed to iced_aw, should I cargo fmt the files I changed or try to keep the old formatting where possible?

yes we would appreciate that. cargo fmt is what we generally use.

That's amazing, thanks @carl-anders.
Now that we are again in parallel with iced latest version, what should we do to use iced_aw?
I guess that the answer is to keep using the git feature in the cargo.toml; however, are you guys planning some workaround to getting it published on crates.io even if the package owner is gone? If there is no way to ask him to give someone else the privileges to publish a version, should we make an alternative repo and publish that to crates.io?
What do you think? @genusistimelord


bibekpanda55

Added onClick sound feature for every click on categories page, every click on puzzle list page and result page and  added a toggle button on settings page for mute and unmute feature for the onClick sound with a snackbar to notify about mute and unmute state on clicking the toggle audio button.

Hey @harshptl14  as you said I have added a toggle button for mute/unmute feature and also added a snackbar for displaying the same, hope your issue is solved so please review and accept this PR as soon as possible😅.

No problem I know my work would have a value so anything for that!! Also I have added a star  to your repo earlier.It was nice working on the issues.☺