GREYInteraction atIndex doesn't throw an exception if index is larger than number of matched elements

The GREYInteraction atIndex documentation says, "In case of the index being over the number of matched elements, it throws an exception."
But the Swift declaration of atIndex doesn't indicate that it is possible to throw an exception, and it in fact doesn't throw an exception.
public func atIndex(index: UInt) -> Self!
From my testing, atIndex will always return a GREYInteraction, so how is it possible to know if the GREYInteraction that is returned is actually pointing to a valid UI element?
I'm using EarlGrey v1.7.0 with Swift 2.3.

Quick question - could you show us how you're using atIndex in your test?selectElementWithMatcher and atIndex will not do anything until an interaction is performed on the GREYInteraction object i.e. by doing performAction, assert etc.

So, I'm essentially just trying to determine the number of elements of a certain type that are currently displayed.  The latest version of my method (which doesn't work) is:
static func count(collection: GREYInteraction) -> UInt {
    let errorConstant = NSError(domain: "", code: 1, userInfo: [:])
    var error: NSError? = errorConstant

    var index: UInt = 0
    collection.atIndex(index).assertWithMatcher(grey_notNil(), error: &error)

    while (error == errorConstant) {
        index += 1
        collection.atIndex(index).assertWithMatcher(grey_notNil(), error: &error)
    }

    return index
}

That seems like a bug in EarlGrey. Also, I notice you're using atIndex to get the count of elements. This seems to be a behavior many devs are using.
We're planning to cut a release by today, this will surely be added in the next one. Thanks for reporting this.

@jblack10101 I created this test for our main table view -
  func testCountOfTableViewCells() {
    var error:NSError? = nil
    var index: UInt = 0
    while (true) {
      EarlGrey.select(elementWithMatcher: grey_kindOfClass(UITableViewCell.self)).atIndex(index).assert(with: grey_notNil(), error: &error)
      if ((error) != nil) {
        break
      } else {
        index = index + 1
      }
    }
    GREYAssert(index > 1, reason: "There are more than one cells present.")
    let outOfBoundsIndex: UInt = index + 1
    EarlGrey.select(elementWithMatcher: grey_kindOfClass(UITableViewCell.self)).atIndex(outOfBoundsIndex).assert(with: grey_notNil(), error: &error)
    GREYAssert(error?.code == GREYInteractionErrorCode.matchedElementIndexOutOfBoundsErrorCode.rawValue,
               reason: "The Interaction element's index being used was over the count of matched elements available.")
  }

From my testing, atIndex will always return a GREYInteraction, so how is it possible to know if the GREYInteraction that is returned is actually pointing to a valid UI element?

 You need to call the action for it to actually go and search the hierarchy and find if an element exists. Simply creating a GREYInteraction doesn't do anything processing. This is done so that you can have the same GREYInteraction object utilized in different places for different actions. For eg.
let interaction: GREYInteraction! = EarlGrey.select(elementWithMatcher: grey_foo())
interaction.assert(with: grey_sufficientlyVisible())
// Perform an action on another GREYInteraction object.
interaction.perform(grey_tap())

would be completely out of sync.

The GREYInteraction atIndex documentation says, "In case of the index being over the number of matched elements, it throws an exception."
But the Swift declaration of atIndex doesn't indicate that it is possible to throw an exception, and it in fact doesn't throw an exception.
public func atIndex(index: UInt) -> Self!

Is there a @throws or so annotation that we could use for that here? As before, the atIndex can be used only in conjunction with an action / assertion. The reason why you're not seeing any exception being thrown is because you're passing an error. The error will soak the exception and allow you to handle it yourself. In the above test I've added, if you remove the passed error, then you'll see an issue with the last statement.
Is there something I'm missing from this? I'll add the test I showed in our Contribs project as a method so that you'd have a ready reference when you wish to get the count.
I'm using EarlGrey v1.7.0 with Swift 2.3.

Fixes https://github.com/google/EarlGrey/issues/419

Closing this for now. @jblack10101 do reopen and tell us if anything else is required.

Reopening here (tell me if it is not the place to talk about this) but is related to the count method. It does not get count elements that are hidden under the scroll, so I'm wondering how would it be possible to get all of the unique occurrences of a UITableView or UIScrollView even when they're not visible because a scroll is being needed to get them @tirodkar

We don't do a check for visibility when we try to get the count of cells, so visibility shouldn't impact the result. We go through the hierarchy and check the count. Can you ensure using [GREYElementHierarchy hierarchyStringForAllUIWindows]; that the UITableView or UIScrollView is indeed present?

Counting instances of UITableViewCell works just fine, but counting elements inside all cells (like counting how many labels of a certain accessibility identifier are there present in the table or scroll this method does not work as intended, it seems just count visible ones (on the screen) but not outside the frame of the screen itself

So I figured out what the issue is, the labels that I'm counting seems to have an alpha=1 even though their container is hidden (an UIStackView), so they are being counted when they're not visible enough.


BUG: Fix issue #1939: Use -mtune=generic

Use -mtune=generic to avoid build-time CPU detection of -mtune=native
to get reproducible build results.
See https://reproducible-builds.org/ for why this is good.
Fixes #1939
This PR was done while working on reproducible builds for openSUSE.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[x] Added test (or behavior not changed)
[x] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@dzenanz Performance would depend on which build machine did the mtune=native build.
I probably wont be able to run the benchmarking (no time).

My concern is that the default builds with the -mtune=generic only use instructions from CPU's that are 20 years old.    There have been many advances since then, and ITK is well suited to take advantage of modern hardware instructions.

@hjmjohnson the allowed CPU instructions are not governed by mtune=, but by the march=corei7 below that expects CPUs younger than 12y. IMHO a good compromise if you do not want to ship multiple copies for different target CPUs.

@hjmjohnson the allowed CPU instructions are not governed by mtune=, but by the march=corei7 below that expects CPUs younger than 12y. IMHO a good compromise if you do not want to ship multiple copies for different target CPUs.

I agree regarding the instructions available being specified by the '-march' flag, and the '-mtune' flag prefers using instructions for the specified architecture.
I don't understand why one would "allow use of corei7 instructions" but tune for the "generic lowest common denominator instructions"?  This would potentially generate binaries that require corei7 features, but then seldom use them.

Checking the GCC docs:
-mtune=cpu-type

    Tune to cpu-type everything applicable about the generated code, except for the ABI and the set of available instructions. While picking a specific cpu-type schedules things appropriately for that particular chip, the compiler does not generate any code that cannot run on the default machine type unless you use a -march=cpu-type option. For example, if GCC is configured for i686-pc-linux-gnu then -mtune=pentium4 generates code that is tuned for Pentium 4 but still runs on i686 machines.

    The choices for cpu-type are the same as for -march. In addition, -mtune supports 2 extra choices for cpu-type:

    ‘generic’

        Produce code optimized for the most common IA32/AMD64/EM64T processors. If you know the CPU on which your code will run, then you should use the corresponding -mtune or -march option instead of -mtune=generic. But, if you do not know exactly what CPU users of your application will have, then you should use this option.

        As new processors are deployed in the marketplace, the behavior of this option will change. Therefore, if you upgrade to a newer version of GCC, code generation controlled by this option will change to reflect the processors that are most common at the time that version of GCC is released.

        There is no -march=generic option because -march indicates the instruction set the compiler can use, and there is no generic instruction set applicable to all processors. In contrast, -mtune indicates the processor (or, in this case, collection of processors) for which the code is optimized.

Given:

-mtune=generic. But, if you do not know exactly what CPU users of your application will have, then you should use this option.

Therefore, if you upgrade to a newer version of GCC, code generation controlled by this option will change to reflect the processors that are most common at the time that version of GCC is released.

-mtune=generic is the best default option for working across generic modern processors (which may be even newer than the instructions allowed by -march). @hjmjohnson do you agree?

@thewtex
mtune and march are somewhat orthogonal. march=cpu-type generate instructions for the machine type cpu-type. In contrast to -mtune=cpu-type, which merely tunes the generated code for the specified cpu-type, -march=cpu-type allows GCC to generate code that may not run at all on processors other than the one indicated. Specifying -march=cpu-type implies -mtune=cpu-type, except where noted otherwise.
-mtune=generic is a fine heuristic that makes reasonable tuning of the code (order of instructions, prefetch assumptions, etc) within the instructions chosen by "march" flag (which like defaults to -march=x86-64, A generic CPU with 64-bit extensions).
march indicates the instruction set the compiler can use.  If march is undefined (the default) then MAXIMUM GENERALIZABILITY is achieved by MINIMIZING the CPU instructions used (i.e. prohibit use of MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, POPCNT, AES and PCLMUL instruction set support.).
========
I think that we could easily drop the -mtune flag, and use the default behavior.
The rationale for having -march=corei7 (circa 2008 instructions) is that 99% of the anticipated deployment market will likely be satisfied with these instructions, and basic simd instructions are allowed to be used for processing.
‘corei7’
Intel Core i7 CPU with 64-bit extensions, MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1 and SSE4.2 instruction set support.
Hans

FYI:
FLAGS1="-march=corei7 -mtune=generic"
gcc $(echo ${FLAGS1})  -Q --help=target > /tmp/options1

FLAGS2=""
gcc $(echo ${FLAGS2})  -Q --help=target > /tmp/options2

diff /tmp/options1 /tmp/options2

24c24
<   -march=                     		corei7
---
>   -march=                     		x86-64
53c53
<   -mcx16                      		[enabled]
---
>   -mcx16                      		[disabled]
100c100
<   -mno-sse4                   		[disabled]
---
>   -mno-sse4                   		[enabled]
109c109
<   -mpopcnt                    		[enabled]
---
>   -mpopcnt                    		[disabled]
125c125
<   -msahf                      		[enabled]
---
>   -msahf                      		[disabled]
133,136c133,136
<   -msse3                      		[enabled]
<   -msse4                      		[enabled]
<   -msse4.1                    		[enabled]
<   -msse4.2                    		[enabled]
---
>   -msse3                      		[disabled]
>   -msse4                      		[disabled]
>   -msse4.1                    		[disabled]
>   -msse4.2                    		[disabled]
140c140
<   -mssse3                     		[enabled]
---
>   -mssse3                     		[disabled]


Bing maps comparison

It would be great to have a Migrate from Bing Maps doc similar to the Migrate from Google Maps. I also get asked about the differences between Bing and Azure Maps. It would be great to have somewhere official on Docs to point them to.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b33476e-4f3b-f94e-d6d6-1faf9fbf3e6d
Version Independent ID: 058c7d5c-2368-1d6d-2e95-1f66a83240a4
Content: Tutorial: Migrate from Google Maps to Azure Maps
Content Source: articles/azure-maps/migrate-from-google-maps.md
Service: azure-maps
GitHub Login: @rbrundritt
Microsoft Alias: richbrun

Hi Cecil,
There is some sensitivity around this topic. As such we have choose to be reactive rather than proactive. The official Microsoft messaging on this is listed below.

Microsoft customers have a rich choice of options from which to source location and mapping data. Our guidance on which service to choose reflects the preference and status of a customer’s implementation of location data. For those enterprise customers already using (or looking to use) Azure, we would recommend they use Azure Maps. Similarly, we’d recommend customers who have a preference for TomTom mapping data to also turn to Azure Maps. For existing Bing Maps for Enterprise customers, if your current services are meeting your needs, we encourage you to stay on your existing service. All customers should work with their Microsoft team to determine which of the services will best serve the individual customer requirements for production grade, fully deployable services.

I see that you work at Microsoft. Happy to discuss this further offline.

@cecilphillip Thank you for your feedback! We will review and provide an update as appropriate.

@ketan-chawda-msft I already responded to this thread.

@cecilphillip Does that answers  your question? Do let us now if there any further queries. Also, as Ricky mentioned, you can discuss offline as well.

@AshokPeddakotla-MSFT yes, we're good. I'll discuss offline w/ @rbrundritt

Sure, thank you!


The module should work with Fedora

Fedora is of course a RedHat-family Linux, and it has relied on systemd for longer than RHEL has done, but the module expressly rejects Fedora clients:

Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Unsupported RHEL/CentOS version! (file: [/path/to]/modules/systemd/manifests/params.pp, line: 12, column: 20)

The error message itself appears to arise because Fedora uses different version numbering than does RHEL.
Fedora is not presently documented among the supported distros, so I guess this is a feature request, not a bug report.

Hi,
I've blindly added support for OpenSuSE and Fedora, could you please check if it is working for you?
Right now 0.1.47 is set as a pre-release
best regards,

I'm setting this issue as resolved, I've also changed the 0.1.47 status to release
best regards,


performance fix: protobuf client ioutil.ReadAll

Issue https://github.com/twitchtv/twirp/issues/166:
ioutil.ReadAll takes 2x memory and is ~20% slower for the protobuf client. CC https://github.com/twitchtv/twirp/issues/166
Description of changes:
My team uses twirp as an RPC to talk to other service. Both client and server are written in go. As a part of the spec, services exchange []byte blobs. Occasionally, those blobs are fairly large in size and exceed 100M. I have detected, that ioutil.ReadAll has a noticeable performance impact for us and pretty much confirmed https://github.com/twitchtv/twirp/issues/166 findings.
I have created a test app and a benchmark test for it - https://github.com/mkorenkov/twirpbench. Based on the benchmark, current PR improves Total Allocations 2x and is about 20% faster, than master branch.
NOTE: requires https://github.com/gogo/protobuf/ protoc plugin. No special features are needed though - see https://github.com/mkorenkov/twirpbench/blob/master/cmd/protoc-gen-maxgo/main.go. Please let me know what you want me to do about it. I can move https://github.com/mkorenkov/twirpbench/blob/master/cmd/protoc-gen-maxgo/main.go to twirp as well and update README.md accordingly.
Benchmark results:
goos: darwin
goarch: amd64
pkg: github.com/mkorenkov/twirpbench/benchmarks
BenchmarkTwirp/twirp-raw-300K-16<PHONE_NUMBER>	         0.00164 ns/op<PHONE_NUMBER>40.75 MB/s	         2.64 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-raw-1M-16<PHONE_NUMBER>	         0.00416 ns/op<PHONE_NUMBER>47.75 MB/s	         5.99 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-raw-10M-16<PHONE_NUMBER>	         0.0418 ns/op<PHONE_NUMBER>46.79 MB/s	        83.1 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-raw-100M-16<PHONE_NUMBER>	         0.387 ns/op<PHONE_NUMBER>83.59 MB/s	       703 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-gz-300K-16<PHONE_NUMBER>	         0.00209 ns/op<PHONE_NUMBER>05.93 MB/s	         3.43 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-gz-1M-16<PHONE_NUMBER>	         0.00447 ns/op<PHONE_NUMBER>11.50 MB/s	         6.79 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-gz-10M-16<PHONE_NUMBER>	         0.0400 ns/op<PHONE_NUMBER>43.54 MB/s	        83.9 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/twirp-gz-100M-16<PHONE_NUMBER>	         0.336 ns/op<PHONE_NUMBER>41.05 MB/s	       704 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-raw-300K-16<PHONE_NUMBER>	         0.00139 ns/op<PHONE_NUMBER>83.97 MB/s	         1.35 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-raw-1M-16<PHONE_NUMBER>	         0.00302 ns/op<PHONE_NUMBER>91.13 MB/s	         3.02 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-raw-10M-16<PHONE_NUMBER>	         0.0330 ns/op<PHONE_NUMBER>24.03 MB/s	        41.6 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-raw-100M-16<PHONE_NUMBER>	         0.311 ns/op<PHONE_NUMBER>50.50 MB/s	       351 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-gz-300K-16<PHONE_NUMBER>	         0.00172 ns/op<PHONE_NUMBER>89.19 MB/s	         2.15 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-gz-1M-16<PHONE_NUMBER>	         0.00399 ns/op<PHONE_NUMBER>25.24 MB/s	         3.83 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-gz-10M-16<PHONE_NUMBER>	         0.0308 ns/op<PHONE_NUMBER>29.88 MB/s	        42.4 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
BenchmarkTwirp/maxtwirp-gz-100M-16<PHONE_NUMBER>	         0.265 ns/op<PHONE_NUMBER>48.52 MB/s	       352 TotalAlloc(MiB)	       0 B/op	       0 allocs/op
PASS
ok  	github.com/mkorenkov/twirpbench/benchmarks	26.213s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @mkorenkov,
Thanks for your investigation. At this time, our team isn't willing to accept the tradeoff of addition of another dependency for deserialization. We'd strongly encourage pursuing performance improvements in the first party github.com/golang/protobuf library, which we will gladly take.


[BUG] Atom search is rendering with strange padding and red text

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Open atom search

Expected behavior
Text should be themed with editor default. Padding seems too large on the first page of options.
Screenshots

Environment

OS: Windows Editor
Unity Version: 2022.2.7
Version of Unity Atoms: 4.4.5

Additional context
It looked correct before (like a normal Unity menu). I have no idea what changed. Perhaps a recent Odin Inspector update, but I am really not sure.
I also got these warning:
Unable to find style 'DD ItemStyle' in skin 'GameSkin' <called outside OnGUI>
UnityEditor.IMGUI.Controls.AdvancedDropdown:Show (UnityEngine.Rect)
UnityAtoms.Editor.AtomsSearchableAssetCreationMenu:AtomsSearchMenu () (at ./Library/PackageCache/com.unity-atoms.unity-atoms-base-atoms@4.4.5/Editor/AtomsSearchableAssetCreationMenu.cs:66)

Unable to find style 'DD HeaderStyle' in skin 'GameSkin' <called outside OnGUI>
UnityEditor.IMGUI.Controls.AdvancedDropdown:Show (UnityEngine.Rect)
UnityAtoms.Editor.AtomsSearchableAssetCreationMenu:AtomsSearchMenu () (at ./Library/PackageCache/com.unity-atoms.unity-atoms-base-atoms@4.4.5/Editor/AtomsSearchableAssetCreationMenu.cs:66)

Unable to find style 'DD ItemCheckmark' in skin 'GameSkin' <called outside OnGUI>
UnityEditor.IMGUI.Controls.AdvancedDropdown:Show (UnityEngine.Rect)
UnityAtoms.Editor.AtomsSearchableAssetCreationMenu:AtomsSearchMenu () (at ./Library/PackageCache/com.unity-atoms.unity-atoms-base-atoms@4.4.5/Editor/AtomsSearchableAssetCreationMenu.cs:66)

Unable to find style 'DefaultLineSeparator' in skin 'GameSkin' <called outside OnGUI>
UnityEditor.IMGUI.Controls.AdvancedDropdown:Show (UnityEngine.Rect)
UnityAtoms.Editor.AtomsSearchableAssetCreationMenu:AtomsSearchMenu () (at ./Library/PackageCache/com.unity-atoms.unity-atoms-base-atoms@4.4.5/Editor/AtomsSearchableAssetCreationMenu.cs:66)

Unable to find style 'ArrowNavigationRight' in skin 'GameSkin' <called outside OnGUI>
UnityEditor.IMGUI.Controls.AdvancedDropdown:Show (UnityEngine.Rect)
UnityAtoms.Editor.AtomsSearchableAssetCreationMenu:AtomsSearchMenu () (at ./Library/PackageCache/com.unity-atoms.unity-atoms-base-atoms@4.4.5/Editor/AtomsSearchableAssetCreationMenu.cs:66)

Unable to find style 'ArrowNavigationLeft' in skin 'GameSkin' <called outside OnGUI>
UnityEditor.IMGUI.Controls.AdvancedDropdown:Show (UnityEngine.Rect)
UnityAtoms.Editor.AtomsSearchableAssetCreationMenu:AtomsSearchMenu () (at ./Library/PackageCache/com.unity-atoms.unity-atoms-base-atoms@4.4.5/Editor/AtomsSearchableAssetCreationMenu.cs:66)

Hm, maybe unity is removing some guiskins now that they adapt more and more to ui toolkit...
Need to take a look into the code, but i think this might be a unity issue and those skins are referenced from the AdvancedDropDownMenu itself...


Add a basic auth method

According to the README and --help, there's not a way to add any kind of authentication. Everyone can access the exported data.

This follows the Prometheus philosophy on authentication, please read https://prometheus.io/docs/operating/security/#authentication-authorization-and-encryption and use the mailing list if you want to discuss this topic further.


[DPTOOLS-2717] Create default role

Issue link: https://jira.lyft.net/browse/DPTOOLS-2717
This pr is to just add default role.
Description:
Our final target is to have new airflow enable auto registration for new users. This PR is to create a "Default" role and sync and check the dag for this role.
The "Default" role have these properties:

Default role can see all the menus exclude "Security" menu and have all permissions. We may have improvement after we finish this whole task.
2.Default role can load public dag. Public dag here means the dag without "access_control" parameter.
This PR is just to create default roll and grant airflow permission. Just airflow permission, without dag permission.

Test
I changed the log in role to "Default" role from "Admin" role: https://github.com/lyft/airflowinfra/blob/master/ops/config/states/webserver_config.py.template#L61.

Then I sign in to the page.
Remember here, since I didn't change the register button, so now only can click "sign in" button to log in as "Default" role.
Here is the home page:

Since I didn't grant dag permission, so in the page, it just shows menu without dag.
Make sure to mark the boxes below before creating PR: [x]

[x] Description above provides context of the change
[ ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
[ ] Unit tests coverage for changes (not needed for documentation changes)
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions.
[ ] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

👀 @youngyjd @feng-tao @astahlman
cc: @Alagappan

Codecov Report

Merging #177 into airflowinfra will decrease coverage by 52.75%.
The diff coverage is 100.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace9a0d...8b43d00. Read the comment docs.

what is the difference between putting the role here vs using airflow create-roles to create the role in deploy time? Does the latter have less VM/Perms that default role needed?

what is the difference between putting the role here vs using airflow create-roles to create the role in deploy time? Does the latter have less VM/Perms that default role needed?

Using cmd is just to create the role but don't create the permission. From code, we can create the role with view permission.

👍

what is the difference between putting the role here vs using airflow create-roles to create the role in deploy time? Does the latter have less VM/Perms that default role needed?

Using cmd is just to create the role but don't create the permission. From code, we can create the role with view permission.

I am not sure how you get this statement. If that's the case, why all the existing roles(zippydev,corpetl) we use airflow create-roles will have permission? All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.
The thing I don't agree is that why we are modifying existing code with the pr that can't be upstream. How are we doing the upgrade next time?

If you really prefer to add the role in security manager instead of having a high state cron job, I think it should add it at Lyft custom security manager instead of here.

wdyt @astahlman @youngyjd @sherryzhao1006

what is the difference between putting the role here vs using airflow create-roles to create the role in deploy time? Does the latter have less VM/Perms that default role needed?

Using cmd is just to create the role but don't create the permission. From code, we can create the role with view permission.

I am not sure how you get this statement. If that's the case, why will all the existing roles(zippydev,corpetl) we use airflow create-roles have permission? All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.
The thing I don't agree is that why we are modifying existing code with the pr that can't be upstream. How are we doing the upgrade next time?

Here is the cmd code to create roles:https://github.com/apache/airflow/blob/master/airflow/cli/commands/sync_perm_command.py#L25.
'All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.'  -- This is to grant view permission to custom dag roles. Their permission should be the same as 'User' role.
This is our code path: we run the script from airflow repo:https://github.com/lyft/airflowinfra/blob/master/scripts/update-fab-users.py#L183-L205. We truly run 'airflow create roles'. But at last, we run 'airflow sync-perm':https://github.com/apache/airflow/blob/master/airflow/cli/commands/sync_perm_command.py#L25. It has two main functions in this cmd: sync_role and sync_perm_for_dag
sync_role:In this method, we init default roles first and then grant custom dag roles(zippydev,corpetl) view permission.
sync_perm_for_dag: we sync the permission for custom dag roles.

what is the difference between putting the role here vs using airflow create-roles to create the role in deploy time? Does the latter have less VM/Perms that default role needed?

Using cmd is just to create the role but don't create the permission. From code, we can create the role with view permission.

I am not sure how you get this statement. If that's the case, why will all the existing roles(zippydev,corpetl) we use airflow create-roles have permission? All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.
The thing I don't agree is that why we are modifying existing code with the pr that can't be upstream. How are we doing the upgrade next time?

Here is the cmd code to create roles:https://github.com/apache/airflow/blob/master/airflow/cli/commands/sync_perm_command.py#L25.
'All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.' -- This is to grant view permission to custom dag roles. Their permission should be the same as 'User' role.
This is our code path: we run the script from airflow repo:https://github.com/lyft/airflowinfra/blob/master/scripts/update-fab-users.py#L183-L205. We truly run 'airflow create roles'. But at last, we run 'airflow sync-perm':https://github.com/apache/airflow/blob/master/airflow/cli/commands/sync_perm_command.py#L25. It has two main functions in this cmd: sync_role and sync_perm_for_dag
sync_role:In this method, we init default roles first and then grant custom dag roles(zippydev,corpetl) view permission.
sync_perm_for_dag: we sync the permission for custom dag roles.

Sure, but Airflow will sync the permissions during startup in (https://github.com/apache/airflow/blob/master/airflow/www/app.py#L210) also from https://lyft.slack.com/archives/CTKA6PTEV/p1584399418114200?thread_ts=1584380833.090100&cid=CTKA6PTEV for every new dag role, it should auto sync the permissions.

what is the difference between putting the role here vs using airflow create-roles to create the role in deploy time? Does the latter have less VM/Perms that default role needed?

Using cmd is just to create the role but don't create the permission. From code, we can create the role with view permission.

I am not sure how you get this statement. If that's the case, why will all the existing roles(zippydev,corpetl) we use airflow create-roles have permission? All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.
The thing I don't agree is that why we are modifying existing code with the pr that can't be upstream. How are we doing the upgrade next time?

Here is the cmd code to create roles:https://github.com/apache/airflow/blob/master/airflow/cli/commands/sync_perm_command.py#L25.
'All the custom dag roles will have necessary permission through this function(https://github.com/apache/airflow/blob/master/airflow/www/security.py#L379) once Airflow is loaded.' -- This is to grant view permission to custom dag roles. Their permission should be the same as 'User' role.
This is our code path: we run the script from airflow repo:https://github.com/lyft/airflowinfra/blob/master/scripts/update-fab-users.py#L183-L205. We truly run 'airflow create roles'. But at last, we run 'airflow sync-perm':https://github.com/apache/airflow/blob/master/airflow/cli/commands/sync_perm_command.py#L25. It has two main functions in this cmd: sync_role and sync_perm_for_dag
sync_role:In this method, we init default roles first and then grant custom dag roles(zippydev,corpetl) view permission.
sync_perm_for_dag: we sync the permission for custom dag roles.

Sure, but Airflow will sync the permissions during startup in (https://github.com/apache/airflow/blob/master/airflow/www/app.py#L210) also from https://lyft.slack.com/archives/CTKA6PTEV/p1584399418114200?thread_ts=1584380833.090100&cid=CTKA6PTEV for every new dag role, it should auto sync the permissions.

Oh... If in this way, we can sync dag for default role in sync_perm.
Honestly, I think it's not that easy to use Lyft security manager especially create default role since default role cannot be the same as User role. I may need spend more time to test that. Not sure about the timeline.


Navigation ignores external URLs.

Seems like the navigation configuration under menus.en.toml do not allow anything except subdirectories. This is very un-ideal as it completely limits the use of the navigation bar.
It totally ignores any external links or URI fragments (which none seem to exist for the features sections on the main page anyways).

Hey @tuxpizza, you need to use url instead of pageRef to use an external link in menu. for example
[[main]]
name = "Google"
url = "https://google.com"
weight = 2


Buyer reads the book's description

As a buyer I can read the book's description to make descision
Main scenario

Buyer chooses book from the list of found books
Website shows the description of the book

Add price field to the book
Clean HTML


Documentation query:  To put @Configuration or not for class defined in @LoadBalancerCLient

Hi,
According to https://docs.spring.io/spring-cloud-commons/docs/current/reference/html/#webclinet-loadbalancer-client,
it stated "The classes you pass as @LoadBalancerClient or @LoadBalancerClients configuration arguments should either not be annotated with @Configuration or be outside component scan scope."
But according to https://spring.io/guides/gs/spring-cloud-loadbalancer,   the SayHelloConfiguration.class passed to the @LoadBalancerClient is annotated with @Configuration and  is within component scan scope
I am basically confused.  So do we put @Configuration or not.

Hello, @hanct. Thanks for reporting it. The annotation should not be there. Have fixed it.


libfranka: unable to set realtime scheduling: Operation not permitted

Hello guys!
I am using Franka with my computer as following:

Also, I install the realtime kernel followed by the instructions of FCI documents, and after the installation, I used the rt-test to test if the real-time kernel was worked well,

All the results seem OK, however, when I restart and enter in the kernel 4.14.12_rt10, errors happened

and, the Graphic driver and wireless driver did not work well.
When I start the roslauch with Franka example controllers, errors shown as "libfranka: unable to set realtime scheduling: Operation not permitted"
Detailed:

errors.txt
I have tried to reinstall the real-time kernel many times, with 4.14.12 or other 4.14 versions, the results were the same. Is the problem because of the i9 9900k cup? Since no problem happened on my laptop(i7 8650u).
Are there any solutions to this problem?

(FYI Just a fellow user here)
If it's not suuuper important that you run realtime, then you can use realtime_config = RealtimeConfig::kIgnore:
https://frankaemika.github.io/libfranka/classfranka_1_1Robot.html#ae63bc19390df3d54f3a270814df35eb6
Before delving into anything ROS-laden, you may want to try one of the direct examples, e.g.:
https://github.com/frankaemika/libfranka/blob/f1f46fb008a37eb0d1dba00c971ff7e5a7bfbfd3/examples/generate_joint_position_motion.cpp
Then mayhaps try something like cd build && sudo ./examples/generate_joint_position_motion <robot-address> to see if it's a permissions issue.
If so, then maybe see if you can configure rtprio to allow priority changes. (A colleague had set this up on our side, I dunno the specifics):
https://serverfault.com/questions/487602/linux-etc-security-limits-conf-explanation

@YinjieLin I faced the same issue on Ubuntu 18.04 and 5.4.102-rt53 #1 SMP PREEMPT_RT kernel.
Even with the libfranka examples. ( I don't think it does not matter if you launch a file in ROS or use an example code, as this is probably a systems error.
I also consulted the steps in:
https://frankaemika.github.io/docs/troubleshooting.html
and set the cpu performance up to performance and verified.
Jitter test gave:
--- <IP_ADDRESS> ping statistics ---
10000 packets transmitted, 10000 received, 0% packet loss, time 9998ms
rtt min/avg/max/mdev = 0.080/0.185/0.354/0.037 ms
And I double-checked that user is within the realtime group with:
getent group
Result realtime:x:1001:userName
I also logged off and on and also rebooted.

My bad, I somehow commented the configurations in the limits.config:
@realtime soft rtprio 99
@realtime soft priority 99
@realtime soft memlock 102400
@realtime hard rtprio 99
@realtime hard priority 99
@realtime hard memlock 102400
That resolved the error.
Also I did not use fakeroot for makeing the kernel. Just: make -j4 deb-pkg

How you commented on the limits.conf ??because when I add them to the file I can't save the file

Ah yeah, I was playing a bit.
I tried saving it under a different (temporary) file name. The command prompt opens the same questions again then I typed in the original file name. I re-opened the files to double-check if the changes were applied.
Regards

Can you please give me more information to understand you?
Thanks for your help

Hi @hussienali321 ,
could you get it to work? If not, don't hesitate to re-open the issue here.
Regarding the file which was edited - I guess you would need to open it as 'sudo' in order to be able to save it.
Cheers,
Andreas


VHDL/Questa: Failed to execute callback

When trying the examples (e.g. examples/dff/tests) in VHDL mode with Questa as simulator by calling
make SIM=questa TOPLEVEL_LANG=vhdl, the test is executed, but finishes with an error:
# Loading std.standard
# Loading std.textio(body)
# Loading ieee.std_logic_1164(body)
# Loading work.dff(rtl)#1
# Loading /tmp/cocotb/build/libs/x86_64/libfli.so
#      -.--ns INFO     cocotb.gpi                                  FliImpl.cpp:1037 in cocotb_init                     cocotb_init called
#
#      -.--ns INFO     cocotb.gpi                                GpiCommon.cpp:91   in gpi_print_registered_impl       FLI registered
#   0.00ns INFO     cocotb.gpi                                  gpi_embed.c:248  in embed_sim_init                  Running on ModelSim for Questa-64 version 10.4c_5 2015.11
#   0.00ns INFO     cocotb.gpi                                  gpi_embed.c:249  in embed_sim_init                  Python interpreter initialised and cocotb loaded!
#   0.00ns INFO     cocotb                                      __init__.py:115  in _initialise_testbench           Running tests with Cocotb v1.0 from /tmp/cocotb
#   0.00ns INFO     cocotb                                      __init__.py:131  in _initialise_testbench           Seeding Python random module with<PHONE_NUMBER>
#   0.00ns INFO     cocotb.regression                         regression.py:167  in initialise                      Found test dff_cocotb.run_test_001
#   0.00ns INFO     cocotb.regression                         regression.py:287  in execute                         Running test 1/1: run_test_001
#   0.00ns INFO     ..coroutine._my_test.0x7fffe83c6a20       decorators.py:191  in send                            Starting test: "run_test_001"
#                                                                                Description: Automatically generated test
#
#
#   0.00ns INFO     cocotb.scoreboard.dff                     scoreboard.py:177  in add_interface                   Created with reorder_depth 0
ERROR: called callback function returned NULL
Failed to execute callback
# Simulation halt requested by foreign interface.
# End time: 10:51:18 on Jul 20,2017, Elapsed time: 0:00:01
# Errors: 0, Warnings: 0

By rolling back the GIT history I found the error comes by commit 7942b0a65f30164783e5ab666775ae2ce9310f11, while using 40cfcf00878cc34a150f048eeb3bd6de7e4a318c is still ok.
The interesting thing is, that everything works well when using make SIM=questa TOPLEVEL_LANG=verilog instead.
The following info may also be relevant:

OS is Arch Linux (64 Bit)
Python version 3.6.1, also tested with 3.5.3 and 3.3.6 (in Arch-Linux, /usr/bin/python points to python3.6 instead of the pretty old python2.7)
the test works well when changing Makefile.pylib.Linux to explicitly use python2.7
tested with Questa 10.4c as well as 10.6
tested with system gcc (7.1.1) as well as gcc delivered with Questa (4.7.4)

I could confirm this bug using:

Debian Stretch
Python 3.5.3
QuestaSim 10.4d
GCC delivered with Questa (4.7.4)

Problem appeared after commit 7942b0a65f30164783e5ab666775ae2ce9310f11 with Python 3
This should be the fix:
diff --git a/cocotb/scheduler.py b/cocotb/scheduler.py
index 43c39e2..1014768 100644
--- a/cocotb/scheduler.py
+++ b/cocotb/scheduler.py
@@ -542,7 +542,7 @@ class Scheduler(object):

         Unprime all pending triggers and kill off any coroutines
         """
-        for trigger, waiting in self._trigger2coros.items():
+        for trigger, waiting in dict(self._trigger2coros).items():
             for coro in waiting:
                 if _debug:
                     self.log.debug("Killing %s" % str(coro))

I will check more carefully and create PR.


Some incoming function calls are not shown

For example, there are definitely more incoming function calls to this account - https://explorer.near.org/accounts/transfer-vote.near but they are not shown in the history.

@ilblackdragon Are they [function calls] triggered as cross-contract calls? (duplicate of #323?)

Yes I believe it is the same issue (action from receipts not being properly indexed).


Global client config

Scenario/Intent
I'd like to be able to set the client object once and then all resources that don't set the client property will use that as a default.
Environment Details

oneview Cookbook Version: 1.0.0

Steps to Reproduce
[If you are filing an issue, what are the things we need to do in order to reproduce your problem? How are you using this cookbook or any resources it includes?]
Expected Result
Set the client object once and everything that doesn't override it will use that as a default.
Actual Result
You have to pass in a client object for EVERY resource

Also, it should use the environment variables that the SDK defines; so a user may never have to define a client in their code.

I think the ENV variables may not be safest and not the simplest option for storing multiple clients. The main use case we came up for the client's use was storing and retrieving them from databags. The client is just exposed in the examples for demonstration purposes.

Well, you'd only be able to use the ENV variables for a single default client. Anything else would need to use another method. I think we can still recommend using a secure method like an encrypted databag or secrets management solution (e.g., Hashicorp Vault). What I'm trying to accomplish with ENV variables is a consistent pattern in both the SDK and the cookbook. If we do this, we'll also make it much easier for people to run the examples, and we can even use the examples internally as more of an integration test.


Type uuid isn't exists for Array in Ajv v7/v8?

What version of Ajv are you using? Does the issue happen if you use the latest version?
Ajv options object
{ allErrors: true, strict: true }

JSON Schema
{
        "type": "array",
        "items": { "type": "string", "format": "uuid" }
}

Sample data
["0d7051b1-7d4d-4d26-b5ee-9a20ea30e310", "0d7051b1-7d4d-4d26-b5ee-9a20ea30e310"]

Your code

https://runkit.com/dalisoft/606c9ce9ccb884001b7e9794
Validation result, data AFTER validation, error messages
Error: unknown format "uuid" ignored in schema at path "#/items"

What results did you expect?
Correct validation
Are you going to resolve the issue?
I don't know enough yet, but if someone from team can help, i really want solve this issue

Formats are moved to ajv-formats package - see https://ajv.js.org/guide/formats.html

Thanks @epoberezkin. I didn't noticed it before

Same error Here. Is there any news on this ?
{
"name": "vx-mock",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo "Error: no test specified" && exit 1"
},
"author": "",
"license": "ISC",
"devDependencies": {
"axios": "^1.6.8",
"express": "^4.19.2",
"fs": "^0.0.1-security",
"mongoose": "^8.3.2",
"path": "^0.12.7"
},
"dependencies": {
"ajv": "^8.12.0",
"ajv-errors": "^3.0.0",
"ajv-formats": "^3.0.1"
}
}


Segmentation fault in Mruby interpreter making it crash

A segfault in in ht_index_get function in src/hash.c:425 due to a high-value address dereference is triggered from a call to it by ht_get function in src/hash.c:445. The bug can be detected on Ubuntu-18.04 64-bit with ASAN-enabled mruby.  It has been reproduced with mruby compiled with different compiler toolchains: clang-9, clang-10, gcc-7.5. This vulnerability causes the mruby interpreter to crash. The POC input and steps to reproduce are provided below.
POC Input
b=([]..[])
a=[]
b=a.append(b)
b.zip(b)
a=ObjectSpace.count_objects
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
a.shift
d=a.shift
a.shift
a.shift
a.shift
b=a.rehash().slice(d)

Steps to reproduce
git clone https://github.com/mruby/mruby
cd mruby
CC=clang LDFLAGS="-fsanitize=address" CFLAGS="-fsanitize=address -g" make -j`nproc`
./bin/mruby poc.rb

ASAN Report
AddressSanitizer:DEADLYSIGNAL
=================================================================
==4075==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x000000704498 bp 0x7ffccca696b0 sp 0x7ffccca69480 T0)
==4075==The signal is caused by a READ memory access.
==4075==Hint: this fault was caused by a dereference of a high value address (see register values below).  Dissassemble the provided pc to learn which register was used.
    #0 0x704498 in ht_index_get /tmp/mruby/src/hash.c:425:10
    #1 0x6f59d6 in ht_get /tmp/mruby/src/hash.c:445:12
    #2 0x6f7855 in mrb_hash_fetch /tmp/mruby/src/hash.c:740:7
    #3 0x7a564d in hash_slice /tmp/mruby/mrbgems/mruby-hash-ext/src/hash-ext.c:62:11
    #4 0x5b9c59 in mrb_vm_exec /tmp/mruby/src/vm.c:1446:18
    #5 0x5a9494 in mrb_vm_run /tmp/mruby/src/vm.c:944:12
    #6 0x600d4f in mrb_top_run /tmp/mruby/src/vm.c:2845:12
    #7 0x641d2d in mrb_load_exec /tmp/mruby/mrbgems/mruby-compiler/core/parse.y:6512:7
    #8 0x642a3d in mrb_load_file_cxt /tmp/mruby/mrbgems/mruby-compiler/core/parse.y:6521:10
    #9 0x4c58cf in main /tmp/mruby/mrbgems/mruby-bin-mruby/tools/mruby/mruby.c:331:11
    #10 0x7fe65764cb96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
    #11 0x41c009 in _start (/tmp/mruby/bin/mruby+0x41c009)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /tmp/mruby/src/hash.c:425:10 in ht_index_get
==4075==ABORTING

Authors
Prashast Srivastava (Purdue University) , Mathias Payer (EPFL)

Thank you for the report!


Fix/multiple context crash

Fix the C++ bridge crash in two scenarios:

The JSAtom can be shared between JSContexts, but we store the JSContext pointer at AtomicString class. That's a big mistake. If the previous stored JSContext are freeed, the bridge will crash if we copy previous JSContext allocated AtomicString to the current JSContext.
The InvokeModule API's callback could be called when the JSContext are already disposed in some special cases.

Add Multiple page integration test system.  Fixed #75

@XGHeaven Please review again


GATSBY_PLUGIN_MAILCHIMP_ADDRESS_ is not defined

System details

node v8.9.3
npm 6.5.0
gatsby: "^2.13.23"
gatsby-plugin-mailchimp: "^5.1.2",

Usage
The endpoint is defined in gatsby-config.js as:
{
      resolve: 'gatsby-plugin-mailchimp',
      options: {
        endpoint: `https://gmail.us3.list-manage.com/subscribe/post?u=X&id=Y`,
      }
    }

And called:
const IndexPage = props => {
  const [email, setEmail] = useState('')

  const handleSubmit = async (e) => {
    e.preventDefault();
    const result = await addToMailChimp(email)
  }

  const handleChange = e => {
    setEmail(e.target.value)
  }
  return (
  ...
  <form onSubmit={handleSubmit}>
      <input type='text' value={email} onChange={handleChange}/>
      <input type="submit" value="Request access"/>
  </form>
}

Stacktrace

node_modules/gatsby-plugin-mailchimp/index.js:88
_callee$
src/pages/index.js:15
  12 | const IndexPage = (props) => {
  13 |   const [email, setEmail] = useState('')
  14 |
> 15 |   const handleSubmit = async (e) => {
  16 |     e.preventDefault();
  17 |     const result = await addToMailChimp(email)
  18 |   }
View compiled
▼ 7 stack frames were expanded.
tryCatch
node_modules/regenerator-runtime/runtime.js:45
Generator.invoke [as _invoke]
node_modules/regenerator-runtime/runtime.js:271
Generator.prototype.<computed> [as next]
node_modules/regenerator-runtime/runtime.js:97
asyncGeneratorStep
node_modules/@babel/runtime/helpers/esm/asyncToGenerator.js:3
_next
node_modules/@babel/runtime/helpers/esm/asyncToGenerator.js:25
(anonymous function)
node_modules/@babel/runtime/helpers/esm/asyncToGenerator.js:32
(anonymous function)
node_modules/@babel/runtime/helpers/esm/asyncToGenerator.js:21
▲ 7 stack frames were expanded.
handleSubmit
src/pages/index.js:15
  12 | const IndexPage = (props) => {
  13 |   const [email, setEmail] = useState('')
  14 |
> 15 |   const handleSubmit = async (e) => {
  16 |     e.preventDefault();
  17 |     const result = await addToMailChimp(email)
  18 |   }
View compiled
▼ 20 stack frames were expanded.
HTMLUnknownElement.callCallback
node_modules/react-dom/cjs/react-dom.development.js:150
invokeGuardedCallbackDev
node_modules/react-dom/cjs/react-dom.development.js:200
invokeGuardedCallback
node_modules/react-dom/cjs/react-dom.development.js:257
invokeGuardedCallbackAndCatchFirstError
node_modules/react-dom/cjs/react-dom.development.js:271
executeDispatch
node_modules/react-dom/cjs/react-dom.development.js:562
executeDispatchesInOrder
node_modules/react-dom/cjs/react-dom.development.js:584
executeDispatchesAndRelease
node_modules/react-dom/cjs/react-dom.development.js:681
executeDispatchesAndReleaseTopLevel
node_modules/react-dom/cjs/react-dom.development.js:689
forEachAccumulated
node_modules/react-dom/cjs/react-dom.development.js:663
runEventsInBatch
node_modules/react-dom/cjs/react-dom.development.js:817
runExtractedEventsInBatch
node_modules/react-dom/cjs/react-dom.development.js:825
handleTopLevel
node_modules/react-dom/cjs/react-dom.development.js:4827
batchedUpdates$1
node_modules/react-dom/cjs/react-dom.development.js:20440
batchedUpdates
node_modules/react-dom/cjs/react-dom.development.js:2152
dispatchEvent
node_modules/react-dom/cjs/react-dom.development.js:4906
(anonymous function)
node_modules/react-dom/cjs/react-dom.development.js:20491
unstable_runWithPriority
node_modules/scheduler/cjs/scheduler.development.js:255
interactiveUpdates$1
node_modules/react-dom/cjs/react-dom.development.js:20490
interactiveUpdates
node_modules/react-dom/cjs/react-dom.development.js:2171
dispatchInteractiveEvent
node_modules/react-dom/cjs/react-dom.development.js:4883

Taking a closer look at your endpoint... are you sure that's a Mailchimp URL? I'm trying to think what else this could be... did you have this working before and it just failed? Or did you just install this?
I usually recommend removing as much as possible from your environment and slowly adding stuff back in to see if there is a conflict.  For example, try using the basic starter from Gatsby with your endpoint, see if you can get that working.  If not, that means there is a problem with your endpoint. But if it does work then likely there is a conflict with another plugin.

@isaacsultan and also use the method defined in the docs i.e. addToMailchimp instead of camel case.

The same issue observed in my case, which gets resolved after restarting node (npm start).
I was able to add a couple of emails within the last couple of days and then I've run it today and had the same issue:

Uncaught (in promise) ReferenceError: GATSBY_PLUGIN_MAILCHIMP_ADDRESS is not defined
at addToMailchimp

which points to this piece of code:
    // eslint-disable-next-line no-undef
    var endpoint = __GATSBY_PLUGIN_MAILCHIMP_ADDRESS__;

@isaacsultan and also use the method defined in the docs i.e. addToMailchimp instead of camel case.

it's okay, addToMailchimp has a default export
@benjaminhoffman Mailchimp URL looks correct

Having the same issue. I have also tried passing my MC endpoint URL in as a param to addToMailChimp but the same ReferenceError: GATSBY_PLUGIN_MAILCHIMP_ADDRESS is not defined is still happening. Endpoint is ok because I send a POST to the same endpoint using Postman and got a 200 back. Could be an issue with conflicting es-lint settings? (shot in the dark, no exp with es-lint)

@nh273 Any luck with this? I'm having the same issue all the sudden.

this is so weird.  does anyone here have repro steps i can do?  no updates have been made to the plugin so 🤷♂

this is so weird. does anyone here have repro steps i can do? no updates have been made to the plugin so 🤷♂

I'm going to try what you suggested and start removing plugins to see if there is a plugin conflict happening, I'll circle back here later today.

I had a silly mistake in my gatsby-config.js causing this error. Two of my plugins were defined in the same object.. 🤦
    {
      resolve: 'gatsby-plugin-mailchimp',
      options: {
        endpoint: 'xxxxx',
      },
      resolve: `gatsby-source-stripe`,
      options: {
        objects: ['Sku', 'Product'],
        secretKey: xxxx,
        downloadFiles: true,
      },
    },

The Stripe and Mailchimp plugin was defined in the same object causing this issue.
    {
      resolve: 'gatsby-plugin-mailchimp',
      options: {
        endpoint: 'xxxxx',
      },
      resolve: `gatsby-source-stripe`,
      options: {
        objects: ['Sku', 'Product'],
        secretKey: xxxx,
        downloadFiles: true,
      },
    },

No worries we've all been there, including me 🤦. I have just checked
what's happening on my site and I can see it's still working, but it takes
a super long time for the state to change and display the message (anyone
else have this). Also sometimes get a cors warning in my console. I thought
I'd taken care of that through micro-cors package but apparently not.
On Fri, May 1, 2020 at 7:26 PM Sam Ojling<EMAIL_ADDRESS>wrote:

I had a silly mistake in my gatsby-config.js causing this error. Two of
my plugins were defined in the same object.. 🤦
{

  resolve: 'gatsby-plugin-mailchimp',

  options: {

    endpoint: 'xxxxx',

  },

  resolve: `gatsby-source-stripe`,

  options: {

    objects: ['Sku', 'Product'],

    secretKey: xxxx,

    downloadFiles: true,

  },

},

The Stripe and Mailchimp plugin was defined in the same object causing
this issue.
{

  resolve: 'gatsby-plugin-mailchimp',

  options: {

    endpoint: 'xxxxx',

  },

  resolve: `gatsby-source-stripe`,

  options: {

    objects: ['Sku', 'Product'],

    secretKey: xxxx,

    downloadFiles: true,

  },

},

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/issues/42#issuecomment-622504999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCIF5RJHEMTBVRZZ5ONCQDRPMH43ANCNFSM4IEQLGEA
.

I had the same problem but I only had to restart the gatsby server and it worked again

Looks like this may be solved?   Would love to close it but if anyone is still experiencing issues, I am happy to keep it open.

@isaacsultan hi I look your code and compare with the documentation and we see that you call addToMailchimp with capital leter:
const handleSubmit = async (e) => {
e.preventDefault();
const result = await addToMailChimp(email)--------------------> here is the problem
}
and when you see the documentation don't use the capital leter.

I'm facing the same issue ,it keep saying https is not defined. Even after  restart and installing npm install gatsby-plugin-mailchimp,  i'm receiving  the same message.

I had this issue and it was down to the formatting of my gatsby-config.js.
Weirdly, the previous plugin in the file didn't have a comma after a }. It was the last { in the list but putting the comma in made the the Mailchimp plugin suddenly start seeing the configured endpoint.


Enable backup price should be more clear

Whoops, my mistake. The price has no further label on the create page or the Backups tab.

[ ] Create page
[ ] Backup enable page


searching a user's profile makes the old mod button come back

as a side note, i have no idea which module does profile searching

re: sidenote
The comment module does, since it searches comments :)

I think there was some confusion on this one.  If I'm not mistaken, @psdtwk was to the new [M] button option:  https://reddit.com/#?tbsettings=modbutton&setting=showinusernamearea
Before searching: http://i.imgur.com/NukRdWW.png
After searching: http://i.imgur.com/g7xTG70.png
That said, this did fix the classic mod button placement, which was incorrect.

I fixed this earlier this week.


URL encoding for upload request query string

Came across this bug when I set a value for initialComment that contained a URL. The code incorrectly split the URL on ampersand characters.

Thanks for the pull request, just a released a new version with your fix


Update to Catalyst 13 and latest Symbolics

This updates to the latest Catalyst (V13) and Symbolics. Please double check I understood what you wanted the Term in getsubstitutions to be -- Symbolics no longer uses Terms, and generally one shouldn't be directly constructing them or their new equivalent. It seemed like you wanted a vector of symbolic variables with a given symbol for their name, so that is what I replaced it with. I can update differently if needed.
Also, given Julia 1.6 is the latest LTS release I updated the Julia dependency to that. Most SciML packages only support 1.6 on now. (And will likely migrate up again soon if 1.10 or 1.11 becomes a LTS release.)

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

I missed the doc examples need updating too. Will try to do that today.

This should hopefully fix the doc builds. Note that Documenter.jl recently released a (breaking) 1.0 version, so I set this to the last pre-1.0 version. You'll need some more updates to migrate to 1.0.

Hi Sam, many thanks for your PR! I wanted to merge it yesterday but stumbled on the documentation bit. Merged!


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

To enable students to code collaboratively in their term projects in addition to enable them to get used to versioning and backing-up their work in a smart way.

Given what you have learned about Git, why would you want to use Git in your classroom?

To enable students to code collaboratively in their term projects in addition to enable them to get used to versioning and backing-up their work in a smart way.


No possibility to use Union and aliased query (with ... as ..)

Trying to create query like
WITH filtered AS (SELECT * FROM .. WHERE ...)
SELECT COUNT(*) FROM filtered
UNION
SELECT COUNT(*) FROM filtered WHERE ...

with
Query.from_(AliasedQuery("filtered")).select(Count("*")).union(Query.from_(AliasedQuery("filtered")).select(Count("*")).where(...)).with(Query.from(...).select("*").where(...), "filtered") - but it is not working (TypeError: 'Field' object is not callable)

Hello @mvbrn
If you break it down it will be clearer, so I recreated your query like this:

query= (Query.from_(Table("filtered"))
            .where(Table("filtered").column_1 == 10)
            .select(Table("filtered").column_1, Table("filtered").column_2))

union= (Query.from_(Table("table2"))
            .where(Table("table2").column_1 == 10)
            .select(Table("table2").column_1, Table("table2").column_2))

second_query = (Query
               .with_(query, "filtered")
               .from_(AliasedQuery("filtered"))
               .select(Table("filtered").column_1, Table("filtered"). column_2)
               .union(union))
print(str(second_query))

With this, the result will be:
(WITH filtered AS (SELECT "column_1", "column_2" FROM "filtered" WHERE "column_1" = 10)
 SELECT "column_1", "column_2"
 FROM filtered)
UNION
(SELECT "column_1", "column_2" FROM "table2" WHERE "column_1" = 10)

I hope it'll help you.


Enable source_config_env test on Windows

This enables the advaned_env::source_config_env test on Windows. The issue with Command modifying the case of environment variables was fixed by https://github.com/rust-lang/rust/pull/85270.

@bors r+

:pushpin: Commit 73f19a01d07411713b54d18f54a42cb63b94dd1a has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 73f19a01d07411713b54d18f54a42cb63b94dd1a with merge 88f14290f253d8d1270b6a202e7bb37361cf2ab0...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 88f14290f253d8d1270b6a202e7bb37361cf2ab0 to master...


[Question]: Improving Performance for Adding 75k Relationships and Ensuring System Functionality

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I'm currently working on a feature where I need to add approximately 75,000 relationships using the index.upsert_triplet_and_node() function in our system. While implementing this, I've noticed that the process is quite slow, and I'm concerned about the system's ability to handle such a large number of relationships efficiently.
The code snippet I'm using is as follows:
index.upsert_triplet_and_node((name, 'BELONGS_TO', category_name), user_node, include_embeddings=True)

I'd like to optimize this process to make it faster without compromising the system's functionality. Additionally, I'm curious about potential limitations or thresholds where the system may stop working as expected due to the high volume of relationships being added.
To be explicit, I am not using from_documents. I am building a graph and need to add the tuples with upsert_triplet_and_node.
Any insights, tips, or best practices on how to make this process more efficient and ensure the system can handle adding 75k relationships would be greatly appreciated. Thank you!

Will something like this work?
from concurrent.futures import ThreadPoolExecutor
from typing import List, Tuple
from llama_index.core.schema import BaseNode

class KnowledgeGraphIndex(BaseIndex[KG]):
    # ... existing code ...

    def parallel_upsert_triplets_and_nodes(
        self,
        triplets_and_nodes: List[Tuple[Tuple[str, str, str], BaseNode]],
        include_embeddings: bool = False,
        max_workers: int = 10
    ) -> None:
        """
        Perform upserts in parallel for a list of triplets and nodes.

        Args:
            triplets_and_nodes (List[Tuple[Tuple[str, str, str], BaseNode]]):
                A list of tuples containing triplets and corresponding nodes.
            include_embeddings (bool): Option to add embeddings for triplets.
                Defaults to False.
            max_workers (int): The maximum number of threads to use.
                Defaults to 10.
        """
        def upsert(triplet_and_node):
            triplet, node = triplet_and_node
            self.upsert_triplet_and_node(triplet, node, include_embeddings)

        with ThreadPoolExecutor(max_workers=max_workers) as executor:
            executor.map(upsert, triplets_and_nodes)
      ```

can a human please answer or at least telling me that i will not get an answer?

I just learned you're just a team of nine in seed stage!! I thought you were tens of Facebook engineers because of the name LLama. Sorry for expecting you to answer me. I also became aware of this just today, which may solve all of our problems https://docs.llamaindex.ai/en/stable/examples/query_engine/knowledge_graph_rag_query_engine.html Thank you so much for all your work; the system feels so elegantly coded with engineering structure being laid out on all of these problems

Yea in general, our knowledge graph stuff is a little unoptimized in a few places.
Working on a larger refactor with better UX

Awesome, cannot wait to try it!!


Implement operator function to honor cliServices: tag and sub fields

Implement operator function to honor cliServices: tag and sub fields in the Kabanero document ( CRD )
e.g.

Just to be clear, the requirement is that the CLI team needs to be able to test new versions of the CLI microservice container in the confines of Kabanero without rebuilding the Kabanero operator.  The configuration that Dave includes above is already present in the model, we just need to hook the code up to it so that the correct CLI container image is generated.

@kyleschlosser ^^

Fixed by #200

It looks like all is well when the deployment is created, but if the image tag changes, the deployment is not updated.

Fixed by #200 and #203


Findigs file.

On our discord we have discussed the possibility of documenting our research on removing or dependency on root. I started work on exactly that, i document our seat research but i have no idea about the other solutions proposed. Would be neat if somebody else could finish this.

Hi eskpil, on second thoughts I think we can make elogind context switching work.

I will be trying to make a PoC in the coming days, hopefully then publishing our findings won't be necessary. However I'll keep this open till we get concrete results.

Hi eskpil, on second thoughts I think we can make elogind context switching work.

Hey, is it possible you can elaborate on this? I am very curious.

Hi eskpil, on second thoughts I think we can make elogind context switching work.

Hey, is it possible you can elaborate on this? I am very curious.

Will share a PoC soon. It's very late rn so for tomorrow!


JS Client for react native

Hi is it possible to use signalr JS client in react native project

I believe other people have had success using react native.
We don't officially support it, however if you find an issue when using react native we will consider non-breaking changes in PR's to help make it work.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


chore(main): release 1.2.2

:robot: I have created a release beep boop
1.2.2 (2023-01-08)
update

update "Add" Done! (635f6e7)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/School-of-Website-Engineering/Back-end-management-system-E-commerce/releases/tag/v1.2.2 :sunflower:


.RPGMVO Won't show up

When I try to convert the rpgmvo file, (Audio file) to .ogg, then it won't even let me, because when I open the file system, it says 'No items match your search.' I tried it with both of the 'choose your file' Buttons, and no, I didn't delete them. I checked afterwards. Help would be appreciated.

Are you in the correct directory?
Also you can try to select "All-Files (.)"  for File-Types

This seems solved... Feel free to reopen this issue, when you're back and still have that Problem

Okay. Thanks!


Sia-UI v.1.3.0-rc7 reports Sia version as 1.2.2

Observed on Win10 x64:

I checked the siad.exe and siac.exe versions that came in the zip and they report 1.3.0. Not sure where it's getting 1.2.2.

Have you got a siac.exe (v. 1.2.2) anywhere on your system?

I'm not seeing that on my machine, I think it's likely you have a v1.2.2 daemon running somewhere. The UI will use the existing daemon if it finds one that is running already.

I have siad 1.2.2 downloaded on that system and I had run it previously, but there are definitely no other siad daemons running when I launch Sia-UI 1.3.0-RC7. Here's the repro:
https://streamable.com/95xzc

In the stream, siac version reports its own version as 1.3.0, and siad's version as 1.2.2. What does siad version report?
I checked the Windows binaries bundled with rc7. The filesizes match the ones in your stream exactly, but they each report v1.3.0. Very strange.

This is because Sia-UI now re-uses config.json across upgrades, and determines if siad needs to be replaced by comparing the last version used as logged in config.json with the current version: https://github.com/NebulousLabs/Sia-UI/blob/master/js/mainjs/config.js#L46. Looks like it's not detecting the upgrade correctly, and it's still pointing at an old (v1.2.2) siad.

In the stream, siac version reports its own version as 1.3.0, and siad's version as 1.2.2. What does siad version report?
> siad version
Sia Daemon v1.3.0

@johnathanhowell's explanation makes sense.

Did you upgrade straight from v1.2.2 to RC7? Or did you run multiple RCs?

I went straight from 1.2.2 to RC7.

@mtlynch do you mind posting the contents of %APPDATA%\Sia-UI\config.json?

Sure, here you go: https://gist.github.com/mtlynch/ece44387f2c3f2523968e39bcd60d9d4

Thanks. Fixed in https://github.com/NebulousLabs/Sia-UI/pull/682, in the mean time you can delete config.json and restart.


Changes for Journal Voucher

Changes for Journal Voucher

Originally posted by @sureshsirvi in https://github.com/EasyCloudConsultants/EasyCloudBooks/issues/274#issuecomment-562430015

1. Remove things that are in Red Box.
2. Remove Pay Button.

Waiting for @sureshsirvi sir's approval..

Removed Pay button on JV Voucher
Removed Closing Balance from all vouchers

Resolved


Set current app name for view component template

Otherwise it's always application

Thanks @query-string. This one was actually intentionally left at "application", just so we have a predicable name for the "base" layout for each sub-app.


bwp

I came here to report the .toc, but see you already fixed it.
You might want to consider migrating to the https://github.com/BigWigsMods/packager given the issues I'm seeing in your actions. The workflow files are simpler, and can do GH, CF, WOWI, and Wago in one shot.

When I find some time I will look at migrating the release over to bwp.


Team cumulative leaderboard shouldn't show Friends of BAFS

The team cumulative leaderboard doesn't take the leaderboard_exclude flag into account, so the Friends of BAFS are considered a team and are showing up.
Link to relevant query

Fixed in the dim and distant past.


is it compulsory to make both dark and light theme?

No, it's not obligatory, to make light and dark theme in your clock...


Access to model checkpoint

Hi Pavel
This is very cool work! Unfortunately, I don't have access to TPUs or 8 V100s so I cannot reproduce your HMC inference.
It would be great if you can upload the HMC samples used in the MLP and CIFAR10 experiments in your paper.
Thanks!

Hi @xidulu! Actually, for all the MNIST experiments we used just a single GPU, so you might be able to run those!
For CIFAR, you can get access to the HMC samples here: https://colab.research.google.com/drive/1EAWv7KwVPh_bw3hvJOfCNappQTQgGsh7?usp=sharing.
If you need to access to MNIST checkpoints, I uploaded some of our MLP runs here: https://storage.cloud.google.com/neurips2021_bdl_competition/bnn_covshift_mnist_mlp_runs.tar.gz. Please let me know if you have any issues accessing these.
We plan to open-source more HMC checkpoints in the future.

@izmailovpavel
Thanks! Are you also planning to open-source the LeNet checkpoint (with or without EmpCov Prior)?
If so, that would be very helpful!

I ran three chains of each. I uploaded the checkpoints here:

MNIST CNN: https://storage.googleapis.com/bnn_covariate_shift/mnist_cnn_runs.tar.gz
MNIST MLP: https://storage.googleapis.com/bnn_covariate_shift/mnist_mlp_runs.tar.gz

On a single Titan RTX GPU, the Gaussian prior runs take 6 minutes / sample, and the EmpCov runs take 2 minutes / sample for the CNN.

@izmailovpavel
Thanks! Really appreciate it!

@izmailovpavel
Hi
Thanks for uploading the checkpoints! But I recently found out that I have difficulty downloading the checkpoints, when I opened the link, it says:

Do you have any clue on why this would happen?
Thanks,
Xi


vscode delete my code!!!

When I use vscode GIT panel to execute git add, it add success but the added files become empty files, I lose all my three-days work.

Should always backup locally too. I've had similar issues [with other software] in the past.

@foisonocean Can you reproduce the issue?


Write DPP paper

Task to do
Write DPP paper for publication
Reason
Outreach
Result
A paper gets submitted w/ data and code archived
Steps to take

[ ] Write paper outline including mockups of tables and figures

[ ] define three points that you want reader to take away

[ ] Generate figures for each site 1) ortho w/ plots overlaid and 2) time series of canopy cover

[ ] G2F
[ ] YCEDA
[ ] CIMMYT
[ ] TERRA REF

[ ] Write paper
[ ] Submit paper
[ ] Curate and publish data

G2F: /iplant/home/shared/commons_repo/curated/tamu_corn_2017_CS17_G2F_20190305
CIMMYT: https://www.dropbox.com/sh/a7va1n8ev0nb2hj/AAC_AoTqWb4ZZESc3bL68t9Ba/af_2017-2018/dji_HiBAP-Y16?dl=0&subfolder_nav_tracking=1
Yceda: /iplant/home/schnaufer/yceda/SmithFieldLettuce
Terraref: use Globus

G2F: /iplant/home/shared/commons_repo/curated/tamu_corn_2017_CS17_G2F_20190305
CIMMYT: https://www.dropbox.com/sh/a7va1n8ev0nb2hj/AAC_AoTqWb4ZZESc3bL68t9Ba/af_2017-2018/dji_HiBAP-Y16?dl=0&subfolder_nav_tracking=1
Yceda: /iplant/home/schnaufer/yceda/SmithFieldLettuce
Terraref: use Globus

Changed to epic


Upgrade System.Data.SqlClient to 4.4.0-*

Addresses "SqlClient fails with netcoreapp2.0 on Win7/Server2008" (https://github.com/dotnet/corefx/issues/18406)
Revert if and when $(CoreFxVersion) is upgraded to 4.4.0-*

@mikeharder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Desync on new input types

vue & vue-validator version
1.0.26, 2.0.0
Reproduction Link

	<validator name="validateColour">

			Select:
			<input type="color" v-model="colour" v-validate:colour="['colour']"></input>

			Type (for example purposes only):
			<input type="text" v-model="colour"></input>

Invalid colour.

Good colour.

	</validator>

Steps to reproduce
Run the code above.  The text box is provided for this example, in a real use of color[sic] input types it obviously wouldn't exist.  Every time something is typed in that box, the new value is propagated to the colour input, and the validator is called.
What is Expected?
Invalid colour. should be displayed, since the value of {{colour}} is the string NOT A COLOUR.
What is actually happening?
It seems the validator pulls the string for comparison straight out of the input value, instead of the underlying model.  Sadly, it seems that the color input type internally converts all non-colour inputs to 0 (black), so the validator is always called on a valid colour.  This is evidenced by the console.log in the colour validator.
The colour button is black regardless of input, unless a real colour in the #HHHHHH format is typed exactly, in which case everything behaves correctly and seems to show that there isn't a mistake in my code (which took a long time to verify).
Moving the v-validate directive to the text input works exactly as expected, as does moving it to a hidden input next to the colour input, for the purposes of display and validation:

			Select:
			<input type="color" v-model="colour"></input>
			<input type="hidden" v-model="colour" v-validate:colour="['colour']"></input>

Thank you for your feedback
In stable version (2.1.7), input[type="color"] is not supported.
I'll try to support in 3.0.


fix: eth max button should stay on

closes #2909

Shouldn't we introduce this behaviour to other protocols?
We should also show the user that the data was changed. @onvisions had some suggestions about it.

@CedrikNikita @martinkaintas @peronczyk

Shouldn't we introduce this behaviour to other protocols?
We should also show the user that the data was changed. @onvisions had some suggestions about it.

IMO

Yes, we should. Consistency.

if you mean the smooth "blinking" transition of updated values (I shared a video of the effect): Yes, we'd better apply it so user will visually be aware that data has changed.

On opening the modal.
TypeError: Cannot read properties of null (reading 'animate')


New Feature: nav bar and updated logo

Created navigation bar (mostly unstyled), and updated logo in index.html

Going to close this for now. First need to integrate the Routing changes with the existing components. After that lands we can bring in this Signup Page


Got error (tensorflow1.1 / python3.5 )

TypeError: Can't mix strings and bytes in path components
https://github.com/tensorflow/tensorflow/issues/10399

https://github.com/tensorflow/tensorflow/pull/9719/files
I've modified using this 'gc.py' solution. Then it worked.


Branch improve event date and time v1.3

Currently, the application Duke The Market only supports Event Date and Time fields as Strings.
To increase the functionality of the application, we can save these fields as LocalDate and LocalTime objects instead.
Closes #68

Codecov Report
Base: 64.68% // Head: 62.63% // Decreases project coverage by -2.04% :warning:

Coverage data is based on head (93852e4) compared to base (271b615).
Patch coverage: 27.48% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
- Coverage     64.68%   62.63%   -2.05%
- Complexity      461      467       +6
============================================
  Files            86       88       +2
  Lines          1648     1745      +97
  Branches        176      186      +10
============================================
+ Hits           1066     1093      +27
- Misses          525      591      +66
- Partials         57       61       +4

Impacted Files
Coverage Δ

.../seedu/address/logic/commands/AddEventCommand.java
0.00% <ø> (ø)

...du/address/logic/parser/AddEventCommandParser.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
63.63% <0.00%> (-6.37%)
:arrow_down:

.../java/seedu/address/model/util/SampleDataUtil.java
16.66% <ø> (ø)

src/main/java/seedu/address/ui/EventCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/event/Event.java
20.68% <27.27%> (ø)

...main/java/seedu/address/model/event/StartTime.java
28.57% <28.57%> (ø)

...main/java/seedu/address/model/event/StartDate.java
30.23% <30.23%> (ø)

...n/java/seedu/address/storage/JsonAdaptedEvent.java
33.33% <37.50%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Version is "2.4.1" while the package version is v2.4.3

In line 29 in server.go there is this line:
Version                       = "2.4.1" // the current server version.
However this is not the current version and it makes for a very confusing log output during startup.

This is my fault, I'll correct it this evening.
I'll try to catch up with everything else too - it's been a bit of a busy year!

Fixed in v2.4.4 :)


Update Pages “home”

Automatically generated by Netlify CMS

👷 Deploy Preview for shimmering-marigold-4f5b4a processing.

Name
Link

🔨 Latest commit
4743b87dfd2e1d2b6b919aa2e79eb92c118d787f

🔍 Latest deploy log
https://app.netlify.com/sites/shimmering-marigold-4f5b4a/deploys/633820f55c207b0009f7c265


Hundred emails on support: documentation  for PlatformIO is broken

http://docs.platformio.org
P.S: Should we host it on the own server?

The new repo-trigger helped. How to avoid similar issues?

Following up on your email, pageviews aren't a problem -- we serve more than 1 million per day. I'm not sure why your project would have went into an unbuilt state however. This would have to have been a version being wiped manually.

A lot of projects were affected that day. The only one solution was to "re-build" docs via new commit.
This project ( https://esp-idf.readthedocs.io ) also had the same symptoms.

This would have to have been a version being wiped manually.

I never touch your "Admin" system. Just only commits...
If you don't see a problem in the logs, we can close this issue. Thanks!

This might be due to a bug with our symlinking after builds. Ping this issue if this comes back, but I'll close this for now.


Update web-sites-dotnet-store-data-mongodb-vm.md

Added default value to the date the task is due since the default sets it to 1/1/0001, just makes it a little cleaner.

@jboeshart,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jboeshart : Thanks for your contribution to the Azure documentation! The author, @cephalin, has been notified to review your proposed change.

@jboeshart Hi! Really appreciate your contribution. Unfortunately this article is in the process of being retired. Sorry about that. #please-close


Install new version when consul_template::version changes

Following changes let Puppet download a new release and installs the binary when the version variable has been changed.

Nice one, thanks! :)

Published 0.2.2 on the Forge https://forge.puppetlabs.com/gdhbashton/consul_template


Address book: validate chain id; fix download button

What it solves
Resolves #2464.
How this PR fixes it
Checks if chain id exists in the list of supported chains.
I've also fixed the Download button in the export modal. The clickable area wasn't covering the whole button.
How to test it
Export the AB on the Arbitrum branch, try to import on this PR's branch. It will not recognize Arbitrum because it's not merged yet.
Screenshots

Actually now comes the question, should we export the entries only for the current network?
Otherwise there can be confusion: when we import all of them and it says "Imported 7 records" but you can see only 2.

Issue:
If there there is a blank space in front of the chainID number the system  will take that as a not valid chainId (for example [ADDRESS],[NAME], 56).
Currently in prod we trim the blank spaces for the chainID so a ", 4" is a valid chain id in prod.

@francovenica fixed ✅

Looks good to me


[SPARK-41731][CONNECT][TESTS] Disable ANSI mode in pyspark.sql.tests.connect.test_connect_column

What changes were proposed in this pull request?
This PR proposes to disable ANSI mode in pyspark.sql.tests.connect.test_connect_column temporarily.
This is a sort of a followup of https://github.com/apache/spark/pull/39241 and https://github.com/apache/spark/pull/39276.
Why are the changes needed?
To recover the broken ASNI build https://github.com/apache/spark/actions/runs/3791006074/jobs/6446116146. This is similar with https://github.com/apache/spark/pull/39092.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually tested via:
SPARK_ANSI_SQL_MODE=true ./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_column'

cc @zhengruifeng


Generate accessors for structs with pointer fields

Fixes #45.
Change-Id: Ib2b6cc5d713e2eb833ee3c7fcfbd804bfe8fa313

Thanks for working on this @gmlewis. Before I look at the details of the implementation, I'd like to discuss this change at a higher level. I have some concerns about the general direction and I'd like to see where others stand. Let's maybe do that in #45 itself, and leave this PR to discuss implementation details. I'll ping you there.

As I posted in https://github.com/google/go-github/issues/45#issuecomment-279566195, my potential concerns are resolved and I have no objections to doing this. I'll leave some review comments on the implementation now.

First, some high level questions/thoughts for @gmlewis, looking only at the final API after this PR.

The "Get" prefix is slightly unfortunate, given Go style suggests to avoid "Get" prefix from getters (source: https://golang.org/doc/effective_go.html#Getters).
However, I understand this is unavoidable because otherwise field name and method name would have same name, right? Also, this is the same solution that protobuf uses and is therefore consistent, right?
Just mentioning this, I don't think we need to change it. Also, one way to justify the "Get" prefix is that it's not a simple getter, it has logic for returning zero value if the pointer is nil.

The documentation text for methods seems to prioritize mentioning the nil case:
// GetMessage returns the zero value if nil, otherwise the actual value.

Is that the way to go? I'd expect the nil case to be the less common path, and the actual value being the primary path. So would it better to reflect that in the docs by swapping the order? Something that mentions the actual value first, nil case second, like:
// GetMessage returns the Message field if its value is non-nil, and zero value otherwise.

(That phrasing doesn't sound better, but perhaps it can be tweaked. Just want to get your thoughts.)

This is actually somewhat implementation-related. Currently, this PR generates 56 "-accessors.go" files. Given they're all generated and most users/developers won't need to look at/modify the detailed contents of those files, maybe it'd be better to consolidate them all in a single  generated .go file?
That way, when working on this package, there are less files get in your way that you don't want to modify. Also smaller risk of accidentally modifying a generated file, because there are fewer of them.
Compare the file list before and after this PR.
Please don't change this yet, I just want to get your thoughts on this first. We should consider the trade-offs of both approaches.

@shurcooL - addressing your questions/thoughts:

Yes, "Get" is consistent with the proto2 implementation.
I went through a few iterations on the comment, and am fine with changing it. Both versions seem clear to me, but am happy to emphasize as suggested.
Sure, I'm happy to consolidate to a single file... I was originally thinking it would be nice to easily jump to just the accessors for a particular file, but with all the editor tooling we have these days, maybe a single file is better after all.

+1 to single file
On Tue, Feb 14, 2017 at 7:55 AM, Glenn Lewis<EMAIL_ADDRESS>wrote:

@shurcooL https://github.com/shurcooL - addressing your
questions/thoughts:

Yes, "Get" is consistent with the proto2 implementation.
I went through a few iterations on the comment, and am fine with
changing it. Both versions seem clear to me, but am happy to emphasize as
suggested.
Sure, I'm happy to consolidate to a single file... I was originally
thinking it would be nice to easily jump to just the accessors for a
particular file, but with all the editor tooling we have these days, maybe
a single file is better after all.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/go-github/pull/543#issuecomment-279747553, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAEWG5WFHKq6kjaw6N5AdsyJ-ogUXP3ks5rcc5mgaJpZM4L2GC9
.

I believe I've addressed the review comments from @shurcooL.
PTAL.

Thank you for the detailed discussion regarding generators, @shurcooL!
I was not aware of this common usage, and it makes sense, so I've moved gen-accessors.go into the github directory.

Merging.

Integrated in https://github.com/google/go-github/commit/cd756c0dfc435cf14d9c696e3b44012f6a4fb5aa


button in top corner of nodes with images to keep them at maximum size (full width of controller)

done on dev

This feature works, but now I can't colapse the images.
Even when it's disabled.

Alo, can you try this icon an see how it looks.
The current one it's OK, but it seems that's for moving the image or something.

Fixed the blocking of minimise on dev.
the pi-window-maximize is normally used to pop something out to fullscreen (which I'd quite like to add!). How about:

Also, now we have the pin, there is no reason to have the maximum height constrained, so I'm removing it.

Yeah, the pin icon is better. It looks good.
It has a more recognizable and simple shape, than the maximize icon.


solana-cli: 1.14.23 → 1.16.27

Description of changes

Changelog / Release: https://github.com/solana-labs/solana/releases/tag/v1.16.27
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Closes #280604
Add a :+1: reaction to pull requests you find important.

Output of nixpkgs-review pr 280788
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/280788/head:refs/nixpkgs-review/1
remote: Enumerating objects: 106, done.
remote: Counting objects: 100% (90/90), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 48 (delta 37), reused 28 (delta 18), pack-reused 0
Unpacking objects: 100% (48/48), 8.60 KiB | 4.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   d431d30e0bba..e0d20bfe6c1f  master     -> refs/nixpkgs-review/0
$ git worktree add /home/aikoo7/.cache/nixpkgs-review/pr-280788-4/nixpkgs e0d20bfe6c1f4fc3eb2e20799133fb5d2256ad9d
Preparing worktree (detached HEAD e0d20bfe6c1f)
Updating files: 100% (38928/38928), done.
HEAD is now at e0d20bfe6c1f Merge pull request #280771 from uku3lig/osu-lazer-2024-113
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/aikoo7/.cache/nixpkgs-review/pr-280788-4/nixpkgs nixpkgs-overlays=/tmp/tmp95yi7ze0 -qaP --xml --out-path --show-trace --no-allow-import-from-derivationhttps://github.com/NixOS/nixpkgs/pull/280788 failed to build: Failed to list packages: nix-env failed with exit code -9
$ git worktree remove -f /home/aikoo7/.cache/nixpkgs-review/pr-280788-4/nixpkgs

Result of nixpkgs-review pr 280788 run on x86_64-linux 1

1 package built:

solana-cli

Result of nixpkgs-review pr 280788 run on x86_64-linux 1
1 package built:

Well, then very likely my system because I retried it half a hour ago with a bigger swap file and it didn't yet finish

For some reason after the ofborg run, it now works, I guess I was beating my head agaisnt a wall for no reason

Thank you for your contribution!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/building-solana-package-already-in-nixpkgs-fails-in-24-05-pre/38174/3


Fix short echo open tags deprecation

Short echo open tags are deprecated and disabled by default in php.ini
since PHP 5.5.0. It does not break anything for olders versions.

You can tell that the code is pretty old :)


pull request for e2e test at 12/14/2016 11:45:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Firefox attachment not working

Good day! On click nothing happens

Hi Luke! Now only attachment in input

Ahh yes.. whoops! Forgot position: relative 😅 thanks for the report. Hopefully it is fixed now.


Camera Not Working in Android 5.1/ Lollipop

Bug Report
Problem
What is expected to happen?
Camera wont open in android 5.1/lollipop
What does actually happen?
When opening camera error occurs illegal argument exception
Information

Command or Code

function capturePhoto() {
navigator.camera.getPicture(onPhotoURISuccess, onFail, {
quality: 90,
destinationType: destinationType.DATA_URL,
correctOrientation: true,
});
}
Environment, Platform, Device

Android 5.1 Emulator
Version information

Cordova 9.0
"cordova-plugin-camera": "^4.1.0",
Checklist

[ X] I searched for existing GitHub issues
[ X] I updated all Cordova tooling to most recent version
[ X] I included all the necessary information above

Are you using cordova-android@9? If so, can you retry with setting the preference android-targetSdkVersion to 28? Curious if this is an API level introduced issue.

Was there a fix for this? I'm also experiencing this problem.

@betagole I think this is an emulator issue. just edit your emulator camera settings to emulated

I wasn't using an emulator. I downgraded to @4.1.0 and it worked on my phone now.

hello please make sure you updated your webview, maybe some js not running correctly on 5.1


Research how to publish a cocoapod with multiple frameworks dependencies

As a user developer, I want to add TIKI SDK as a cocoapod dependency.
This issue is the followup from #5 .
Flutter produces a Framework with multiple local dependencies from other frameworks: the Flutter core, the tiki_sdk_flutter module, tiki_sdk_flutter_plugin and one for each dependency this frameworks have.
It works perfeclty for a a local usage, but for publishing to Cocoapods, all the dependencies must be published as a pod.
As mentioned in #5 we have already tried to compile all dependencies as a single framework to publish, but it lead to compilation errors.
This issue is to research if there are any different ways to publish a pod with multiple dependencies.
If compiling all in one framework is the best choice, research how to do it to not end up with the same error reported in #5.
Accpetance criteria:
1.- Description of the solution with related stories created.

The idea to use Flutter as a library was to develop faster and keep just one code base. But it ended up taking more time and not using native iOS implementations that typically are more robust and reliable.
Instead of spending more time finding how to package Fluttter as a non UI library, something that it was not designed to achieve, I have decided to move into a native SDK implementation in swift. Since the architecture is ready, it is a matter of changing the language but keeping the logic.


Step 4, last line is missleading

At the end of Step 4, you are asked to either go to Step 8, or 7, which make you skip steps 5 and 6 in any case.
A customer and myself interpreted the instructions the same way. But we soon realized that step 6 was mandatory.
Could it be rephrased?
Also, my customer and I faced the same issue described below, to bring the WSUS server online again:
-WID had to be removed
-WSUSutil.exe command required
https://social.technet.microsoft.com/Forums/ie/en-US/fd38f661-0352-4cee-b6df-4bf4763b3aa4/updateservicesdbxml-missing?forum=winserverwsus
Step 4:
Verify permissions on the database:
Right-click the SUSDB, select Properties, and then click Permissions. The NT AUTHORITY\NETWORK SERVICE account should be listed. If it is not, you need to add it.
If both WSUS and SQL Instance are on the same machine skip to step 8. Otherwise proceed to step 7.

We seem to have lost the associated article - which one were you trying to follow? Thanks!

Here is the link to our documentation : https://docs.microsoft.com/en-us/windows-server/administration/windows-server-update-services/manage/wid-to-sql-migration

Hi Liza,
It looks like my comment did not get attached to the WSUS article, I was not signed in properly…
Sorry, I am a GitHub beginner.
If you can link it to the below article, that would be great, otherwise I could repost my comment again
https://docs.microsoft.com/en-us/windows-server/administration/windows-server-update-services/manage/wid-to-sql-migration
Let me know!
Florent
Florent Mordelet
Premier Field Engineer | System Center/Azure/EMS
Enterprise Services Delivery | Secure Infrastructure
Microsoft Canada | Mississauga Office
[MSFT_logo_Gray DE sized SIG1.png]    [https://www.mcneese.edu/sites/all/themes/mcneese_www/images/linkedin_icon.png] https://www.linkedin.com/in/florent-mordelet-576b9914/
Office:<PHONE_NUMBER>
Mobile: (+1)<PHONE_NUMBER>
Florent.mordelet<EMAIL_ADDRESS>From: Liza Poggemeyer<EMAIL_ADDRESS>Sent: May 7, 2018 9:49 AM
To: MicrosoftDocs/windowsserverdocs<EMAIL_ADDRESS>Cc: Florent Mordelet<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windowsserverdocs] Step 4, last line is missleading (#755)
We seem to have lost the associated article - which one were you trying to follow? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindowsserverdocs%2Fissues%2F755%23issuecomment-387070557&data=02|01|Florent.Mordelet%40microsoft.com|5f8791ab58574aaedc2308d5b42154fa|72f988bf86f141af91ab2d7cd011db47|1|0|636612977614795358&sdata=nmmg9uAhM%2B89CIONWHUyv3y4UIEg3vhlOa6%2FnbvNpuw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAk_8y3iccB97sALFUEDyTqo2jDlXiRR9ks5twFDbgaJpZM4TzVnx&data=02|01|Florent.Mordelet%40microsoft.com|5f8791ab58574aaedc2308d5b42154fa|72f988bf86f141af91ab2d7cd011db47|1|0|636612977614795358&sdata=kBnTVT1mL5yv2vQ1rSHBhL8mXiyhhI0V2jmxvDiU2R0%3D&reserved=0.

Ya you are a beginner do you really need your contact info published to the public, Or is this the new way to game Googles SEO tack ticks

Reopened on WSUS docs:https://github.com/MicrosoftDocs/windowsserverdocs/issues/769

Comment added to the proper MSFT Doc