Force javac compiler usage

would be great if one of you could checkout master, remove the smallrye-metrics or the jetbrains dependency and do a mvn clean install/verify and check if the jdk internal assertion error appears on your machine as well.
If yes, this issue here fixes this very strange issue.

This will impact the runtime artifact because of a test issue. I can't approve for now as I don't know exactly all the consequences of adding forceJavacCompilerUse. I'll have a look later.

And it's not only a test classpath issue. I also have this when removing the smallrye-metrics dependency which is a "normal" classpath one.


evaluate model API

What is this PR for?
Implement API to evaluate model:
(ref of protocol: https://github.com/drucker/drucker-grpc-proto/pull/10 )
(This PR is just for EvaluateModel protocol. PR for EvaluationResult protocol will be the next)
This PR includes

implement ApiEvaluate class to request evaluation to drucker_worker
save evaluation data path to db (create Evaluation model class)
try using protobuf3-to-dict library instead of ProtobufUtil.serialize_to_object

What type of PR is it?
Feature
What is the issue?
N/A
How should this be tested?

start drucker server based on https://github.com/drucker/drucker/pull/11 and https://github.com/drucker/drucker-example/pull/5
start drucker-dashboard backend server
request to evaluation API with the following script

import requests

app_id = 1  # depends on your local data
service_id = 1  # depends on your local data
url = 'http://localhost:18080/api/applications/{}/services/{}/evaluate'.format(app_id, service_id)
res = requests.post(url, files={'file': open('dummy.txt')})
print(res.text)  # check API response

(dummy.txt is like below)
0,0,5,0,0,0,0,0,0,2,0,13,0,0,0,0,0,12,0,4,0,10,0,0,0,0,0,0,0,17,0,0,0,0,0,1,0,0,0,0,8,1,12,0,0,0,0,7,0,6,11,0,0,1,0,13,0,8,10,9,0,0,0,16,13
1,0,0,0,0,0,11,13,2,0,0,11,12,0,2,15,8,0,18,5,0,11,6,5,0,5,0,0,0,16,6,0,16,18,0,0,9,0,0,0,16,0,0,0,0,0,4,0,0,17,0,9,10,4,5,15,6,0,7,1,4,0,0,0,10

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yuki.matoba seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Did you confirm it pass the unittest on drucker-parent? I am sorry for the inconvenience.

(I need to confirm it works on my env but)
Almost LGTM. Could you add the tests to drucker-parent or drucker-dashboard?
(We plan to move the tests from drucker-parent to here for pipnization)

@yuki-mt
Here is the checklist

[ ] Add unittest
[ ] Confirm to use protobuf_to_dict from @yustoris

@keigohtr
I added unittest in this repo https://github.com/drucker/drucker-dashboard/pull/45/commits/39908f354a8a9cd0fed5b0840cdf70617027ed4b
(mainly in the same way as test in drucker-parent, but removed parts that have nothing to do with ApiEvaluate )
(I mocked stub in DruckerDashboardClient)
Please review it.

@yustoris
Thank you for your comment.
I replace ProtobufUtil.serialize_to_object with protobuf_to_dict in https://github.com/drucker/drucker-dashboard/pull/45/commits/5a9d2bfdfd8cd934a3588647e06909f04988b8da
@keigohtr
Also, I updated README and gitignore to use test db file


Supported custom layout ?

I use Custom layout to store my MS database table,but there are some problems

[DongGuan.Web.Models.MyLayout] is my custom layout type

I think the issue is that you must specify the assembly name of your custom layout type.
So try this:
<layout type="DongGuan.Web.Models.MyLayout, (write assembly name here)">
   ...
</layout>

Else post you config file here....

Thanks, the problem was solved, I started using on log4net yesterday,unskilled in use.


build_packages: break gnupg dependency loop

Follow-up to coreos/portage-stable#560.

Or, as an alternative to this, we can just disable smartcard support in GPG again.

We'll use coreos/coreos-overlay#2630 to not add more packages to production images.


ci: skip all fork tests during cross platform test

Motivation
noticed an uptick in long running cross-platform tests, possibly related to fork test, suggest skipping them.
makes me think that the current backoff impl might need some fine tuning since it currently is exp with the number of requests that are currently ratelimited which can get large real quick

Solution

makes me think that the current backoff impl might need some fine tuning since it currently is exp with the number of requests that are currently ratelimited which can get large real quick

Yep - we discussed that with @meetmangukiya. Might be time we experiment with linear backoff? Seems like we overcorrected


brew link automatically unlink previous versions of gcc.

Bug report

[+] ran brew update and can still reproduce the problem?
Yes, the issue is actual.
[-] ran brew doctor, fixed all issues and can still reproduce the problem?
brew doctor shows me that one keg is not linked:

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  gcc@8

However, when I try to link it, I'm getting another issue - gcc@9 is not linked:
brew link gcc@8
Unlinking<EMAIL_ADDRESS>32 symlinks removed
Linking<EMAIL_ADDRESS>32 symlinks created

[+] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
We have macOS build agents, and to make them compatible for projects, it is required to preserve both versions of GCC in the PATH. However, currently, it is not possible to do, since, after gcc@9 installation, brew automatically unlinks gcc@8
What happened (include command output)
brew link gcc@8
Unlinking<EMAIL_ADDRESS>32 symlinks removed
Linking<EMAIL_ADDRESS>32 symlinks created

The same thing for:
brew install gcc@8
brew install gcc@9

What you expected to happen
It should be possible to preserve both versions in macOS and one week ago it was.
Step-by-step reproduction instructions (by running brew commands)
brew install gcc@8
brew install gcc@9

Try to call:
gcc-8 --version
gcc-8: command not found
gcc-9 --version
works as expected.
Output of brew config and brew doctor commands
BREW DOCTOR:
brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!
Warning: A newer Command Line Tools release is available.
Update them from Software Update in System Preferences or run:
softwareupdate --all --install --force
If that doesn't show you an update run:
sudo rm -rf /Library/Developer/CommandLineTools
sudo xcode-select --install
Alternatively, manually download them from:
https://developer.apple.com/download/more/.
Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run brew link on these:
gcc@8
Warning: Homebrew's sbin was not found in your PATH but you have installed
formulae that put executables in /usr/local/sbin.
Consider setting the PATH for example like so:
echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.profile
Warning: Broken symlinks were found. Remove them with brew cleanup:
/usr/local/bin/mysqldump
/usr/local/opt/node@12
/usr/local/opt/postgresql@12
BREW CONFIG
brew config
HOMEBREW_VERSION: 2.5.9
ORIGIN: https://github.com/Homebrew/brew
HEAD: 2ed5d80ff2f8025823de9b9faacfca27fa006c80
Last commit: 24 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: da375d73744c5dbcdfa82514495cdd531a8e794e
Core tap last commit: 22 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_NO_INSTALL_CLEANUP: set
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 12.0 build 1200
Git: 2.29.0 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
Java: 13
macOS: 10.15.7-x86_64
CLT: 1<IP_ADDRESS>
Xcode: 12.1

We have created PR with a temporary workaround for the current issue in our repository.


Maven build failure

I am currently trying to integrate the scalac-scapegoat-plugin_2.11 version 1.3.0 in a maven build that will integrate with SonarQube via a different plugin.
I am using scapegoat as a scala-maven-plugin compiler plugin, with the -P:scapegoat:dataDir arg set properly.
<compilerPlugins>
    <compilerPlugin>
        <groupId>com.sksamuel.scapegoat</groupId>
        <artifactId>scalac-scapegoat-plugin_2.11</artifactId>
        <version>1.3.0</version>
    </compilerPlugin>
</compilerPlugins>

The problem is that when finding errors during the linting process, the build fails with a compilation error: "Execution default of goal net.alchim31.maven:scala-maven-plugin:3.2.2:compile failed."
I was wondering if it is common behavior for the maven build to fail on scapegoat errors. Can this be suppressed somehow such that the build does not fail?

Is it possible to add a flag such as -P:scapegoat:reportOnly:true that would make the plugin only generate the report, without compilation errors?

@cristiantoader not sure you still need this, but have you tried https://github.com/sksamuel/sbt-scapegoat#inspection-warning-level-overrides?


Returning unresolved InetSocketAddress from resolution filter method

I have a use case where I would like a filter to be able to modify a request hostname/port, but still use the proxy's default host name resolver (i.e. not resolve the address in the filter). I've added a check to ProxyToServerConnection.setupConnectionParameters() so that if the filter does return an unresolved address, it will attempt to resolve it using the usual proxy resolver.

This looks good to me @detro?

LGTM merging


initialize empty group slices

This will allow us to simplify the code in the updater: https://github.com/dependabot/dependabot-core/blob/715ff7114b387812beb435d834b35786901bb1f5/updater/lib/dependabot/job.rb#L91-L96

we are trying to avoid job object attributes to be initialized and not nil.

Avoiding undefined or null in the job JSON definition, which would translate to nil in the Ruby.


Fix Titan Assist medal not tracking properly.

Titan Assist medals were not being given to players who assisted damage when someone else kills a titan, that is due the fact that Titans stores damage history in their Soul component, not the NPC itself.

PR auto-closed due to branch rename


Beta

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


LightNovelPub sourced novels prompt "Network request failed"

Source information
LightNovelPub
Steps to reproduce
1.Go to library or updates tab and pull down to get updates.
2. Wait until app fetches data for novel sourced from LightNovelPub
Expected behavior
Shoul update novel
Actual behavior
Toast notification saying "Network request failed" shows up instead
LNReader version
1.1.8
Android version
8.1
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 1.1.8.
[X] I have updated all installed extensions.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Only happens to novels added from LightNovelPub before installing latest update. Novels added after 1.1.8 works fine. Searching for novel within the Browse tab doesn't work though as the novela shown during search are just the few novels on the first page fetched when opening the source.

This happens when the LightNovelPub enables Cloudflare protection. The app cannot bypass it so it gives Network request failed on updating or opening the source in browse tab. The source will start working normally once they remove it.


Social share sites not recognizing meta tags

The meta tags are being generated properly in my doc head, but when I run the urls through various debuggers to get the scrape data it doesn't find the meta tags.
Using Facebook debugger: http://developers.facebook.com/tools/debug
Google data testing tool: http://www.google.com/webmasters/tools/richsnippets
Twitter card validator: https://dev.twitter.com/docs/cards/validation/validator

Are you using server-side rendering? Otherwise it won't work..

I am not, my server-side is rendered in .NET so I'll have to figure out how to make it work. Thanks.

The problem is, that the social medias are looking at the HTML returned from you server, and doesn't execute JS. So the meta tags has to be in the initial server render.

I'm closing for now..


SCT-1147 Add test rig and a few tests

Only had a couple comments

@jayrbolton verbally approved this PR.


feat: multiple network/bridge support ?

Moving the discussion here from https://github.com/near/rainbow-bridge-client/pull/4#pullrequestreview-604714953  and https://github.com/near/rainbow-bridge-client/pull/4#issuecomment-791079039
Dapps may want to connect to different bridges simultaneously and record bridge transfers of different bridges on the same URL.
The current lib design assumes that dapps like https://github.com/near/rainbow-bridge-frontend will be connecting to a single bridge per URL (rinkeby.bridge.near.org for example) and uses process.env to access bridge contract addresses (process.env.ethLockerAddress for example). Transfers recorded in localStorage do not contain information about token connectors, bridges or networks.

I don't think accessing several bridges simultaneously will be needed soon, so this is no high priority.
However the current design is very error prone for developers that switch between network only for testing (which should be common).

Note: when testing, switching bridge/network is done via process.env and when testing a localhost dapp, different instances for different bridges can be tested on different ports so that transfers of different bridges don't conflict.


Android native plugin doesn't support AGP 8.0

Android Flutter plugins should add namespace under android inside the build configuration for the app.
Something like this.
Steps to reproduce

Create a new Flutter Application (empty)
Use Android Studio's "AGP Upgrade Assistant" to upgrade to Gradle 8
flutter pub add fpjs_pro_plugin

Also check official android documentation here.

Thank you for the issue!
Looks like we will fix it by tomorrow.

:tada: This issue has been resolved in version 2.0.2-test.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

We still need some tome to test it, but you already can try 2.0.2-test.1 prerelease and give us a feedback.

:tada: This issue has been resolved in version 2.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

We finally published the version 2.0.2 with the fix for Gradle.
Thank you @dkrutskikh for the issue.
And thank you @vant3ch for the contribution!


Possibly incorrect generated types for DateTime fields

First and foremost: thank you very much for taking the time to develop this tool 🙏
Paired up with kysely, it makes an amazing setup for dealing with DBs in Node.
I have a prisma definition that contains this model:
model Match {
  // ...
  startedAt           DateTime
  endedAt             DateTime?
  createdAt           DateTime            @default(now())
  deletedAt           DateTime?
  // ...
}

Which results in those types when using prisma-kysely:
export type Timestamp = ColumnType<Date, Date | string, Date | string>

export type Match = {
  startedAt: Timestamp
  endedAt: Timestamp | null
  createdAt: Generated<Timestamp>
  deletedAt: Timestamp | null
}

It feels right, but I stumble upon a problem when querying from this table. I use the following query
 const match = await kysely
    .selectFrom('match')
    .selectAll()
    .where('id', '==', id)
    .executeTakeFirst()

Which retrieves the following result:
{
  id: 5,
  startedAt: '2019-11-14T00:55:31.820Z',
  endedAt: null,
  createdAt: '2023-03-30 17:39:01',
  deletedAt: null,
}

But the generated type for the match variable is:
const match: {
    // ...
    startedAt: Date; // <-- this should be string
    endedAt: Date | null; // <-- this should be string | null
    createdAt: Date; // <-- this should be string
    deletedAt: Date | null; // <-- this should be string | null
} | undefined

Please correct me if I'm wrong. I don't know if it's prisma-kysely responsibility for parsing the dates inside prisma config file as string, or if it's kysely itself that should have been interpreting the Date field and parsing it as a string when retrieving data from the database.
Thank you very much for the attention and time

Hey there. This is totally up to the database driver and Kysely dialect you're using. Some drivers return parsed JS dates, while others do not. The Postgres driver pg, for example, returns parsed dates. Which driver are you using?
As an escape hatch you can always override types in the generator config e.g.:
generator kysely {
  // ...
  dateTimeTypeOverride = "string"
}

Okay, so I suppose it is on Kysely to understand that my driver returns dates as strings?
My current config is the following:
import Database from 'better-sqlite3'
import { Kysely, SqliteDialect } from 'kysely'
import type { DB } from './types'

const database = new Database('./new-database.db')

export default new Kysely<DB>({
  dialect: new SqliteDialect({
    database,
  }),
})

And thanks for the datetimetype override tip

@leo-diehl

don't you think that kysely should be smart enough to infer the date types based on the driver?

Kysely's API is dialect agnostic by design.
Any inference based on passed dialect would:
a. hurt maintainability/readability by adding lots of generics and complex types.
b. hurt compile performance and query complexity potential.
c. hurt ease of dialect creation/maintenance by 3rd parties.
@valtyr Thanks for this awesome project! 🥇
Having the ability to override select data types is very nice, but requires the consumer to investigate and know a bunch of stuff about the driver.
What if:

prisma generation could be wrapped with a thin prisma-kysely CLI.
consumer was allowed to provide an optional global hint to CLI - "I'm using sqlite" - to offer her a more precise output. e.g. prisma-kysely --sqlite.
Kysely is postgres-first in many design decisions regarding defaults, so "hintless" runs would default to pg's behavior.

Hey @igalklebanov. Thanks for some good ideas. We already have information about the database people are using from their prisma schemas and generate different types for each. Within each database type there are of course different drivers which could have inconsistent deserialization for different data types. I think the best we can do is support the most common driver for each database type. It could very well be that I've just picked the wrong DateTime type for sqlite. In that case I can update the type maps in the next version.
The override is only ever meant as an escape hatch, not a general solution by the way. I want 99% of users to be able to use the generator without using any overrides.

@valtyr Thank you for the detailed comment. 🙏
I mixed database and driver and generally "brain farted". 😅
Sounds good to me, and I totally agree with the direction.
I think a good starting point is to support the underlying drivers the built-in Kysely dialects use (better-sqlite3, pg and mysql2).

@igalklebanov that makes perfect sense. I'll go through and double check that I have the correct types for the standard drivers. Thanks for the input! 😎

Alright! @leo-diehl I have a snapshot version for you to try: 0.0.0-snapshot-20230403105456. If you could remove the override and confirm that this version is working for you I'll release a version with the changes.

@valtyr it seems to be working as expected!


Models failed while running harness test (winogrande dataset) with latest IPEX-LLM nightly build

A lot of models failed while running harness test (winogrande dataset) with IPEX-LLM nightly build after 2.1.0b20240820
For example:
Model: codegemma-7b-it
IPEX-LLM version: 2.2.0b20240902
transformers version: 4.38.2
Environment:
Hardware: ThinkBook14G6+IMH-Ultra7-155H-32GB
OS: Windows 11

Steps to reproduce:

Covert the model to 'sym_int4' by <ipex-llm-repo-root>/python/llm/dev/benchmark/all-in-one/save.py
Install harness packages by following the instruction of link
Go to directory <ipex-llm-repo-root>/python/llm/dev/benchmark/harness
Run command python run_llb.py --model ipex-llm --pretrained <model_hub_path>\codegemma-7b-it-int4 --precision sym_int4 --device xpu --tasks winogrande --no_cache --batch 1

Error log:
Running IPEX-LLM harness test ...
Could not import signal.SIGPIPE (this is expected on Windows machines)
C:\Users\superbuilder\miniforge3\envs\ipex-llm-acc\Lib\site-packages\transformers\deepspeed.py:23: FutureWarning: transformers.deepspeed module is deprecated and will be removed in a future version. Please import deepspeed modules directly from transformers.integrations
  warnings.warn(
C:\Users\superbuilder\miniforge3\envs\ipex-llm-acc\Lib\site-packages\torchvision\io\image.py:13: UserWarning: Failed to load image Python extension: 'Could not find module 'C:\Users\superbuilder\miniforge3\envs\ipex-llm-acc\Lib\site-packages\torchvision\image.pyd' (or one of its dependencies). Try using the full path with constructor syntax.'If you don't plan on using image functionality from `torchvision.io`, you can ignore this warning. Otherwise, there might be something wrong with your environment. Did you have `libjpeg` or `libpng` installed before building `torchvision` from source?
  warn(
2024-09-04 15:21:12,329 - INFO - intel_extension_for_pytorch auto imported
Selected Tasks: ['winogrande']
2024-09-04 15:21:13,484 - INFO - Converting the current model to sym_int4 format......
Loading checkpoint shards:   0%|                                                                                | 0/2 [00:00<?, ?it/s]C:\Users\superbuilder\miniforge3\envs\ipex-llm-acc\Lib\site-packages\torch\_utils.py:831: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  return self.fget.__get__(instance, owner)()
Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:08<00:00,  4.31s/it]
Task: winogrande; number of docs: 1267
Task: winogrande; document 0; context prompt (starting on next line):
Natalie took basic French lessons from Betty after school because Betty is strong at that language.

My friends tried to drive the car through the alleyway but the car was too wide.

Sarah didn't practice ballet much but Mary practiced all the time. Sarah wasn't chosen to be a lead dancer.

The trainer tried to put the exercise equipment in the van but it wouldn't fit; the van was too small.

Natalie never checks the air in the tires while Tanya does and you just knew Natalie would have flat tires.

People think Rebecca
(end of prompt on previous line)
Requests: [Req_loglikelihood("Natalie took basic French lessons from Betty after school because Betty is strong at that language.\n\nMy friends tried to drive the car through the alleyway but the car was too wide.\n\nSarah didn't practice ballet much but Mary practiced all the time. Sarah wasn't chosen to be a lead dancer.\n\nThe trainer tried to put the exercise equipment in the van but it wouldn't fit; the van was too small.\n\nNatalie never checks the air in the tires while Tanya does and you just knew Natalie would have flat tires.\n\nPeople think Samantha", ' is embarassed, because Samantha made snide comments about the shirt Rebecca was wearing.')[0]
, Req_loglikelihood("Natalie took basic French lessons from Betty after school because Betty is strong at that language.\n\nMy friends tried to drive the car through the alleyway but the car was too wide.\n\nSarah didn't practice ballet much but Mary practiced all the time. Sarah wasn't chosen to be a lead dancer.\n\nThe trainer tried to put the exercise equipment in the van but it wouldn't fit; the van was too small.\n\nNatalie never checks the air in the tires while Tanya does and you just knew Natalie would have flat tires.\n\nPeople think Rebecca", ' is embarassed, because Samantha made snide comments about the shirt Rebecca was wearing.')[0]
]
Running loglikelihood requests
  0%|                                                                                | 0/2534 [00:02<?, ?it/s]
Job config of task=winogrande, precision=sym_int4 failed. Error Message: The size of tensor a (0) must match the size of tensor b (10) at non-singleton dimension 1
Here are results of all successful tasks:
Traceback (most recent call last):
  File "C:\WorkSpace\superbuilder\llm.model.benchmark\ipex_llm_harness\run_llb.py", line 159, in <module>
    main()
  File "C:\WorkSpace\superbuilder\llm.model.benchmark\ipex_llm_harness\run_llb.py", line 155, in main
    raise RuntimeError('\n'.join(fail))
RuntimeError: Job config of task=winogrande, precision=sym_int4 failed. Error Message: The size of tensor a (0) must match the size of tensor b (10) at non-singleton dimension 1

We encountered some problems when reproducing the issue and have made a contact with the user. Still in progress.

Hi yzha107，
We have looked into the issue and reproduced the problem. The current conclusion is that ipex-llm after 2.1.0b20240820 introduced this change set IPEX_LLM_LAST_LM_HEAD=1 as default   which demands running the following command before the harness evaluation,
for linux users:
export IPEX_LLM_LAST_LM_HEAD=0

for windows users:
$env:IPEX_LLM_LAST_LM_HEAD=0

Doing so should solve the problem.

Issue is already solved for user, close issue.


[SP-5226] Backport of PDI-18100 - When running pan/kitchen with an in…

…valid Repo it raises a Java NPE (8.3 Suite)
@ssamora

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/kitchen/KitchenCommandExecutor.java
  engine/src/main/java/org/pentaho/di/pan/PanCommandExecutor.java
  engine/src/test/java/org/pentaho/di/kitchen/KitchenCommandExecutorTest.java
  engine/src/test/java/org/pentaho/di/pan/PanCommandExecutorTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapinput.LDAPInputMeta

Branch Change: -1.6% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change: -4.5% :small_red_triangle_down:
Complexity Change: -3.1% :small_red_triangle_down:
Instruction Change: -5.7% :small_red_triangle_down:
Line Change: -4.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:


test new CI schema

Codecov Report

Merging #18 (f129d80) into main (10b6058) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   97.35%   97.35%
=======================================
  Files          58       58
  Lines        1134     1134
  Branches       15       17    +2
=======================================
  Hits         1104     1104
  Misses         30       30

Flag
Coverage Δ

spark-2.4.x
94.87% <100.00%> (ø)

spark-3.0.x
96.66% <100.00%> (ø)

spark-3.1.x
97.46% <100.00%> (ø)

spark-3.2.x
97.46% <100.00%> (ø)

spark-3.3.x
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/main/scala/doric/syntax/LiteralConversions.scala
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab94f9...f129d80. Read the comment docs.


Empty arrays as components

I'd like to be able to use ComponentArrays with some fields containing empty data arrays. For example,
ComponentVector(a=Int[], b=1) and ComponentVector(a=[Int[]], b=1) both work fine. However,
ComponentVector(a=[(a1=Int[],)], b=1)

fails due to a zero step-size in a range used in the partition function in utils.jl
Is there a simple fix?

Perhaps the issue is more subtle than I naively thought: ca = ComponentVector(a=[Int[],Int[]], b=1) instantiates an object but ca.a and ca.b both error.

Thanks for opening the issue, @william-macready. It looks like there are actually a few problems here, some more easily fixable than others:

Components that are arrays of ComponentArrays that have only empty inner elements (e.g. a in ComponentVector(a=[(a1=Int[],)], b=1)) do not handle the zero-element case very gracefully. The method of partitioning the data for the output doesn't work when the chunk size is zero. I don't anticipate this being very hard to deal with, it will probably just have to special case for that situation.
Components that have arrays of arrays (e.g. a in ComponentVector(a=[[3], [4, 5]], b=1)) are are collecting the elements of the arrays into the underlying array correctly, but messing up on the indices. For example, this silently gives the wrong answer:

julia> ca = ComponentVector(a=[[3], [4, 5]], b=1)
4-element ComponentVector{Int64} with axis Axis(a = 1:2, b = 3):
 3
 4
 5
 1

julia> ca.b
5

julia> ca.a
2-element view(::Vector{Int64}, 1:2) with eltype Int64:
 3
 4

The issue here is that I never really designed array-valued components to hold plain arrays. They can hold values or they can hold ComponentArrays (all of the same type, of course), but not plain arrays. The empty arrays in ComponentVector(a=[Int[],Int[]], b=1) are a bit of a red herring here because the issue is more with the incorrect indexing than the fact that the arrays are empty.
Fixing this may need a new AbstractAxis type. I'll have to think about how that all might work out. In the very least, though, it should error for now instead of silently giving the wrong answer.

Thank you for the explanations Jonnie.

If you do fix this chunking issue I'm happy to test things for you on my use case. I hope the needed changes are straightforward and are largely localized to partition.
Thanks for the warning, I'll structure things in my code to avoid nested arrays.

Thanks for a very useful package!


I want to run two tasks, one after the other, but when I run the second, the first one runs too.

When I stop the first task (with STOP) and execute the second, both are executed at the same time. I need is for them to run at different times.
--RUN TASK ONE (first moment)
await BackgroundService.start(veryIntensiveTaskONE, options)
--- STOP TASKS (second moment)
await BackgroundService.stop();
--RUN TASK TWO (third moment)
await BackgroundService.start(veryIntensiveTaskTWO, options)
*** Between the second moment and the third moment there is less than 1 second.

@Arturo-J-Alva, calling BackgroundService.stop(); while the app is in the foreground does not guarantee to stop your task immediately. The only way to really stop your task is to resolve the promise. For this purpose you could use BackgroundService.isRunning() to know if it has been stopped.

I did what you told me, but it's the same as before. I observe is that the first task stays saved, and when I run another task, it runs together with the first one.
Is there a method to delete the executed tasks? (after using the STOP method)

@Arturo-J-Alva, if the first task resolves it should not continue running, it works as any other JS Promise. You might need to debug your code and make sure your first task resolves correctly before running your second task. Your code logic might be interfering with the promise resolution.

@Arturo-J-Alva its workied for me , if any other solution please let me know.
`import BackgroundJob from 'react-native-background-actions';

const sleep = (time) => new Promise((resolve) => setTimeout(() => resolve(), time));

const taskRandomOne = async (taskData) => {

    await new Promise(async (resolve) => {

        // For loop with a delay
        const { delay } = taskData;
        console.log(BackgroundJob.isRunning(), delay)

        for (let i = 0; i<=5; i++) {
            console.log('Runned -> ', i);
            await BackgroundJob.updateNotification({ taskDesc: 'Runned -> ' + i });
            await sleep(delay);
        }

        // toggleBackground();
        console.log('SYNC Completed Work ! 1');
        await BackgroundJob.start(taskRandomTwo, optionsTwo);

    });
    return 25;
};

const taskRandomTwo = async (taskData) => {

    await new Promise(async (resolve) => {

        // For loop with a delay
        const { delay } = taskData;
        console.log(BackgroundJob.isRunning(), delay)

        for (let i = 0; i <10; i++) {
            console.log('Runned -> ', i);
            await BackgroundJob.updateNotification({ taskDesc: 'Runned -> ' + i });
            await sleep(delay);
        }
        toggleBackground();
        console.log('SYNC Completed Work ! 2');
    });
};

const optionsOne = {
    taskName: 'Registed',
    taskTitle: 'ExampleTask One',
    taskDesc: 'ExampleTask desc',
    taskIcon: {
        name: 'ic_launcher',
        type: 'mipmap',
    },
    color: '#ff00ff',
    linkingURI: 'exampleScheme://chat/jane',
    parameters: {
        delay: 1000,
    },
};
const optionsTwo = {
    taskName: 'Health Record',
    taskTitle: 'ExampleTask Two',
    taskDesc: 'ExampleTask desc',
    taskIcon: {
        name: 'ic_launcher',
        type: 'mipmap',
    },
    color: '#ff00ff',
    linkingURI: 'exampleScheme://chat/jane',
    parameters: {
        delay: 1000,
    },
};

function handleOpenURL(evt) {
    console.log(evt.url);
}
Linking.addEventListener('url', handleOpenURL);

export const BackgroundJobRunning =async ()=>{

    playing = BackgroundJob.isRunning();

    console.log("playing", playing);

    toggleBackground = async () => {
    this.playing = !this.playing;
        if (this.playing) {
            try {
                console.log('Trying to start background service');
                await BackgroundJob.start(taskRandomOne, optionsOne)

                console.log('Successful start!');
            } catch (e) {
                console.log('Error', e);
            }
        }
        else {

            await BackgroundJob.stop();
            console.log('Stop background service');
        }
    };

    toggleBackground()
}`


Extreme lag caused by onEntityCollide check

A bunch of cows in a pen on 1.10.2 are causing a huge amount of lag.

if the information is relevant, there are a lot of baby cows too

@Lemmmy Need more information.... What Sponge build? What GP build? What PEX build? What mods/plugins ? etc.  Also provide a link to a timings report.

SpongeForge 1876
GP 129
Latest PEX (doesnt specify which version number)

@Lemmmy switch from PEX to LuckPerms and retest
https://github.com/lucko/LuckPerms
Also, delete your ./config/sponge folder so it regenerates fresh. Post a timings report with LuckPerms installed.

Fixed in commit https://github.com/MinecraftPortCentral/GriefPrevention/commit/391c11f8ba961784988be25c0403c2c3a5fd956c


Issues on v4.0.2

I have two main issues with with 0.4.2
Compile fail without built-in-drivers feature
error[E0425]: cannot find function `plugin_scanners` in module `built_in`
   --> src/platform.rs:604:34
    |
604 |         for scanner in built_in::plugin_scanners() {
    |                                  ^^^^^^^^^^^^^^^ not found in `built_in`
    |

Platform crash
When the platform is compiled with builtins, it crashes if a plugin is also already installed in the plugin location.
thread 'main' panicked at src/platform.rs:436:51:
called `Result::unwrap()` on an `Err` value: PluginError("Unable to load plugin_entry_point [\"/etc/panduza/plugins/libpza_plugin_korad.so\"] - (DlSym { desc: \"/etc/panduza/plugins/libpza_plugin_korad.so: undefined symbol: plugin_entry_point\" })")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

KA3005P delay and structure
There is a delay when the a command is issued to the KA3005P, ~2 seconds.
Also the structure is mounted multiple times at connection, the first structure published contains only identify.
This messes up with the app because I don't expect structure to be published multiple times at connection.

Can you test again with the 0.5.0 ? tell me if you have the issue.

[ 14:22 ][~/panduza/panduza-rust-platform]$ cargo run
    Updating crates.io index
    Updating git repository `https://github.com/Panduza/panduza-platform-core`
    Updating git repository `https://github.com/Panduza/pza-plugin-fakes`
    Updating git repository `https://github.com/Panduza/pza-plugin-hameg`
    Updating git repository `https://github.com/Panduza/pza-plugin-korad`
    Updating git repository `https://github.com/Panduza/rumqtt`
error: failed to get `rumqttd` as a dependency of package `panduza-rust-platform v0.5.0 (/home/agouby/panduza/panduza-rust-platform)`

Caused by:
  failed to load source for dependency `rumqttd`

Caused by:
  Unable to update https://github.com/Panduza/rumqtt?tag=0.0.0

Caused by:
  failed to parse manifest at `/home/agouby/.cargo/git/checkouts/rumqtt-23e63b9f9424b28b/6e7d3f6/benchmarks/simplerouter/Cargo.toml`

Caused by:
  invalid type: map, expected a string for key `package.edition`

I still have the platform crash if the plugin pza-plugin-korad built on version 1.0.4 (same as the builtin), is deployed in the plugins folder and I start the platform with cargo run -- -ld

Also when running cargo run --features built-in-drivers -- -ld  if a plugin file is in the plugin folder
[ 14:46 ][~/panduza/panduza-rust-platform]$ cargo run --features built-in-drivers -- -ld
warning: unused variable: `result`
   --> src/platform.rs:619:17
    |
619 |             let result = scanner.scan();
    |                 ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `panduza-rust-platform` (bin "panduza-rust-platform") generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s
     Running `target/debug/panduza-rust-platform -ld`
----------------------------------------
# Panduza Platform

- Stdout logs         : ENABLED
- Broker logs         : DISABLED
- Debug logs          : ENABLED
- Trace logs          : DISABLED

- Log dir             : "/etc/panduza/logs"
- Tree file           : "/etc/panduza/tree.json"
----------------------------------------
[P] -- Platform Start --
[P] Args: Args { log_stdout_enable: true, broker_log_enable: false, debug_log: true, trace_log: false }
[P] Platform Version: 0.5.0
[P] Rustc Version: rustc 1.83.0 (90b35a623 2024-11-26)
[P] All tasks completed
[P] Wait for new tasks
[P] ----- SERVICE : BOOT -----
[P] ----- SERVICE : START BROKER -----
[P] Start Broker
[P] All tasks completed
[P] Wait for new tasks
[P] ----- SERVICE : LOAD PLUGINS -----
[P] ? SEARCH PUGINS in (/home/agouby/panduza/panduza-rust-platform/target/debug/plugins)
[P] ? SEARCH PUGINS in (/etc/panduza/plugins)
[P] !  Found PUGIN file: "/etc/panduza/plugins/libpza_plugin_korad.so"
thread 'main' panicked at src/platform.rs:449:51:
called `Result::unwrap()` on an `Err` value: PluginError("Unable to load plugin_entry_point [\"/etc/panduza/plugins/libpza_plugin_korad.so\"] - (DlSym { desc: \"/etc/panduza/plugins/libpza_plugin_korad.so: undefined symbol: plugin_entry_point\" })")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


Error while running: docker start racnode2 --container_linux.go:348: starting container process caused "process_linux.go:402: container init caused "process_linux.go:367: setting cgroup config for procHooks process caused \"failed to write 95000 to cpu.rt_runtime_us

Hi ,
I faced same error while starting racnode1 which was resolved using #838
But now while starting racnode2 getting same error although same entries are there in the files.
I am trying to implement 2 node rac on single vm with 16GB ram and 2 gb swap.
sudo docker start racnode2
Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "process_linux.go:402: container init caused "process_linux.go:367: setting cgroup config for procHooks process caused \"failed to write 95000 to cpu.rt_runtime_us: write /sys/fs/cgroup/cpu,cpuacct/system.slice/docker-501367d8b58c3a1c8e57160e11f27c50c0ec6718dbe8d7d04d2cd42feb744d7e.scope/cpu.rt_runtime_us: invalid argument\""": unknown
Error: failed to start containers: racnode2
Is there anything else we need to do for racnode2.
docker info output:
Client:
Debug Mode: false
Server:
Containers: 4
Running: 3
Paused: 0
Stopped: 1
Images: 32
Server Version: 19.03.1-ol
Storage Driver: btrfs
Build Version: Btrfs v4.15.1
Library Version: 102
Logging Driver: json-file
Cgroup Driver: systemd
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: c4446665cb9c30056f4998ed953e6d4ff22c7c39
runc version: 4bb1fe4ace1a32d3676bb98f5d3b6a4e32bf6c58
init version: fec3683
Security Options:
seccomp
Profile: default
Kernel Version: 4.14.35-1902.10.7.el7uek.x86_64
Operating System: Oracle Linux Server 7.7
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.38GiB
Name: dockerrac
ID: 35UU:MDQ5:6R22:AKSN:D5BV:SWKX:QOVE:HVMV:VTLN:JQ7Z:TDXU:NIS2
Docker Root Dir: /var/lib/docker
Debug Mode: false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false
Registries:
Thanks,
Nitin

@nmukheja
Can you paste me the container creation command for racnode1 and racnode2.

For Racnode-1:
docker create -t -i
--hostname racnode1
--volume /boot:/boot:ro
--volume /dev/shm
--tmpfs /dev/shm:rw,exec,size=4G
--volume /opt/containers/rac_host_file:/etc/hosts
--volume /opt/.secrets:/run/secrets
--dns-search=example.com
--privileged=false
--volume racstorage:/oradata
--cap-add=SYS_NICE
--cap-add=SYS_RESOURCE
--cap-add=NET_ADMIN
-e NODE_VIP=<IP_ADDRESS>
-e VIP_HOSTNAME=racnode1-vip
-e PRIV_IP=<IP_ADDRESS>
-e PRIV_HOSTNAME=racnode1-priv
-e PUBLIC_IP=<IP_ADDRESS>
-e PUBLIC_HOSTNAME=racnode1
-e SCAN_NAME=racnode-scan
-e SCAN_IP=<IP_ADDRESS>
-e OP_TYPE=INSTALL
-e DOMAIN=example.com
-e ASM_DISCOVERY_DIR=/oradata
-e ASM_DEVICE_LIST=/oradata/asm_disk01.img,/oradata/asm_disk02.img,/oradata/asm_disk03.img,/oradata/asm_disk04.img,/oradata/asm_disk05.img
-e CMAN_HOSTNAME=racnode-cman1
-e CMAN_IP=<IP_ADDRESS>
-e COMMON_OS_PWD_FILE=common_os_pwdfile.enc
-e PWD_KEY=pwd.key
--restart=always
--tmpfs=/run -v /sys/fs/cgroup:/sys/fs/cgroup:ro
--cpu-rt-runtime=95000
--ulimit rtprio=99
--name racnode1
oracle/database-rac:19.3.0
For Racnode2:-
docker create -t -i
--hostname racnode2
--volume /dev/shm
--tmpfs /dev/shm:rw,exec,size=4G
--volume /boot:/boot:ro
--dns-search=example.com
--volume /opt/containers/rac_host_file:/etc/hosts
--volume /opt/.secrets:/run/secrets
--privileged=false
--volume racstorage:/oradata
--cap-add=SYS_NICE
--cap-add=SYS_RESOURCE
--cap-add=NET_ADMIN
-e EXISTING_CLS_NODES=racnode1
-e NODE_VIP=<IP_ADDRESS>
-e VIP_HOSTNAME=racnode2-vip
-e PRIV_IP=<IP_ADDRESS>
-e PRIV_HOSTNAME=racnode2-priv
-e PUBLIC_IP=<IP_ADDRESS>
-e PUBLIC_HOSTNAME=racnode2
-e DOMAIN=example.com
-e SCAN_NAME=racnode-scan
-e SCAN_IP=<IP_ADDRESS>
-e ASM_DISCOVERY_DIR=/oradata
-e ASM_DEVICE_LIST=/oradata/asm_disk01.img,/oradata/asm_disk02.img,/oradata/asm_disk03.img  ,/oradata/asm_disk04.img,/oradata/asm_disk05.img
-e ORACLE_SID=ORCLCDB
-e OP_TYPE=ADDNODE
-e COMMON_OS_PWD_FILE=common_os_pwdfile.enc
-e PWD_KEY=pwd.key
--tmpfs=/run -v /sys/fs/cgroup:/sys/fs/cgroup:ro
--cpu-rt-runtime=95000
--ulimit rtprio=99
--restart=always
--name racnode2
oracle/database-rac:19.3.0

@nmukheja
Container creation command seems to be fine.  Please do following:
I can see you have given following allocation to dockerd:
/usr/bin/dockerd --cpu-rt-runtime=950000 --cpu-rt-period=1000000 --exec-opt=native.cgroupdriver=systemd
However, please do following and try again on 19.3 docker ol and let's use default cgroupfs drive:

If Oracle docker-engine version >= 19.3
Edit /usr/lib/systemd/system/docker.service and add --cpu-rt-runtime=950000 additional parameters in [Service] section for dockerd daemon.
ExecStart=/usr/bin/dockerd -H fd:// --containerd=/run/containerd/containerd.sock --cpu-rt-runtime=950000
Retstart systemd

systemctl daemon-reload
systemctl restart docker

Try to bring up your contaners

Hi,
When i try to run from the above mentioned settings in docker.service file i am not able to start the racnode-cman container also.
[oracle@dockerrac ~]$ sudo docker start racnode-cman
Error response from daemon: linux init cgroups path: write /sys/fs/cgroup/cpu,cpuacct/docker/cpu.rt_runtime_us: invalid argument
Error: failed to start containers: racnode-cman
earlier i was able to start racnode-cman, racnode-storage and racnode1 and was facing issue in racnode2.
cman container was created with below command.
/usr/bin/docker run -d --hostname racnode-cman1 --dns-search=example.com
--network=rac_pub1_nw --ip=<IP_ADDRESS>
-e DOMAIN=example.com -e PUBLIC_IP=<IP_ADDRESS>
-e PUBLIC_HOSTNAME=racnode-cman1 -e SCAN_NAME=racnode-scan
-e SCAN_IP=<IP_ADDRESS> --privileged=false
-p 1521:1521 --name racnode-cman oracle/client-cman:19.3.0

HI @psaini79
My issue is similar to #1590 . There seems to be connectivity issue between racnode1 and racnode2.
As mentioned in the 1590 thread i disabled the firewall and iptables and i saw the nodes were communicating. But when i rebooted the server and started the racnode1 and racnode2 i got connectivity issues again although firewall and iptables are disabled.
Whichever node i start first shows below:
CRS-4537: Cluster Ready Services is online
CRS-4529: Cluster Synchronization Services is online
CRS-4533: Event Manager is online
and whichever node i start second shows.
CRS-4535: Cannot communicate with Cluster Ready Services
CRS-4530: Communications failure contacting Cluster Synchronization Services daemon
CRS-4534: Cannot communicate with Event Manager
I tried running root.sh via root user on racnode2 it gave me error similar to #1590
Died at /u01/app/19.3.0/grid/crs/install/crsinstall.pm line 1970.

@nmukheja
Did you disable the iptables, selinux and firewalld? if not, please execute following steps:
systemctl disable iptables
systemctl disable firewalld
Edit /etc/selinux/config and set SELINUX to permissive i.e. SELINUX=permissive
setenforce 0

Restart containers and check if you still see the issue.

Hi,
Again for a brief period both racnodes were working but when i tried to test after reboot issue came back. I have verified after reboot both iptables and firewalld services were down before i started rac containers.
Before Reboot:
[grid@racnode2 ~]$ crsctl stat res -t
Name           Target  State        Server                   State details
Local Resources
ora.LISTENER.lsnr
ONLINE  ONLINE       racnode1                 STABLE
ONLINE  ONLINE       racnode2                 STABLE
ora.chad
ONLINE  ONLINE       racnode1                 STABLE
ONLINE  ONLINE       racnode2                 STABLE
ora.net1.network
ONLINE  ONLINE       racnode1                 STABLE
ONLINE  ONLINE       racnode2                 STABLE
ora.ons
ONLINE  ONLINE       racnode1                 STABLE
ONLINE  ONLINE       racnode2                 STABLE
Cluster Resources
ora.ASMNET1LSNR_ASM.lsnr(ora.asmgroup)
1        ONLINE  ONLINE       racnode1                 STABLE
2        ONLINE  ONLINE       racnode2                 STABLE
3        OFFLINE OFFLINE                               STABLE
ora.DATA.dg(ora.asmgroup)
1        ONLINE  ONLINE       racnode1                 STABLE
2        ONLINE  ONLINE       racnode2                 STABLE
3        OFFLINE OFFLINE                               STABLE
ora.LISTENER_SCAN1.lsnr
1        ONLINE  ONLINE       racnode1                 STABLE
ora.asm(ora.asmgroup)
1        ONLINE  ONLINE       racnode1                 Started,STABLE
2        ONLINE  ONLINE       racnode2                 Started,STABLE
3        OFFLINE OFFLINE                               STABLE
ora.asmnet1.asmnetwork(ora.asmgroup)
1        ONLINE  ONLINE       racnode1                 STABLE
2        ONLINE  ONLINE       racnode2                 STABLE
3        OFFLINE OFFLINE                               STABLE
ora.cvu
1        ONLINE  ONLINE       racnode1                 STABLE
ora.orclcdb.db
1        ONLINE  ONLINE       racnode1                 Open,HOME=/u01/app/o
racle/product/19.3.0
/dbhome_1,STABLE
ora.qosmserver
1        ONLINE  ONLINE       racnode1                 STABLE
ora.racnode1.vip
1        ONLINE  ONLINE       racnode1                 STABLE
ora.racnode2.vip
1        ONLINE  ONLINE       racnode2                 STABLE
ora.scan1.vip
1        ONLINE  ONLINE       racnode1                 STABLE
After Reboot:[oracle@dockerrac ~]$ sudo systemctl status iptables
● iptables.service - IPv4 firewall with iptables
Loaded: loaded (/usr/lib/systemd/system/iptables.service; disabled; vendor preset: disabled)
Active: inactive (dead)
[oracle@dockerrac ~]$ sudo systemctl status firewalld
● firewalld.service - firewalld - dynamic firewall daemon
Loaded: loaded (/usr/lib/systemd/system/firewalld.service; disabled; vendor preset: enabled)
Active: inactive (dead)
Docs: man:firewalld(1)
[oracle@dockerrac ~]$ cat /etc/selinux/config
This file controls the state of SELinux on the system.
SELINUX= can take one of these three values:
enforcing - SELinux security policy is enforced.
permissive - SELinux prints warnings instead of enforcing.
disabled - No SELinux policy is loaded.
SELINUX=permissive
SELINUXTYPE= can take one of three values:
targeted - Targeted processes are protected,
minimum - Modification of targeted policy. Only selected processes are protected.
mls - Multi Level Security protection.
SELINUXTYPE=targeted
Starting containers
[oracle@dockerrac ~]$ sudo docker ps
CONTAINER ID        IMAGE                              COMMAND                  CREATED             STATUS              PORTS                              NAMES
5098adca4439        oracle/database-rac:19.3.0         "/usr/sbin/oracleinit"   3 hours ago         Up 11 minutes                                          racnode2
1db57bf82d97        oracle/database-rac:19.3.0         "/usr/sbin/oracleinit"   5 hours ago         Up 13 minutes                                          racnode1
eb0bb85b5a3f        oracle/rac-storage-server:19.3.0   "/bin/sh -c 'exec $S…"   6 hours ago         Up 14 minutes                                          racnode-storage
83cb977d6b62        oracle/client-cman:19.3.0          "/bin/sh -c 'exec $S…"    If yes, I recommend using Oracle RAC on Docker on KVM or virtual box on-prem or in Oracle Cloud ( dev and test) populated with OEL 7.x and UEK5 for further assistance, because Oracle RAC is only supported in the Oracle Cloud: https://www.oracle.com/technetwork/database/options/clustering/overview/rac-cloud-support-2843861.pdf
If not , please upload grid diag logs and let me look into it.

I am using Azure VM.


[BUG]: Could not validate login after updating docker container in CasaOS

How are you running AnythingLLM?
Docker (remote machine)
What happened?
I am running a local server in a home lab using Debian 12 and CasaOS, installed AnythingLLM through the built-in App Store. After I updated from 1.6 to 1.7, now every time a user tries to log in, the page shows a message saying: "Error: Could not validate login".
With further testing, I found that this happens not only when one updates the container, but every time it is taken down and up with the respective docker CLI commands or through the CasaOS interface.
Are there known steps to reproduce?

Have AnythingLLM installed in CasaOS
In the UI, click the three dots of AnythingLLM's icon and then the "Check then update"
Wait for the process to finish, then try to login with existing credentials

Its because the storage volume is probably ephemeral to the container. You need to use the command on this page when launching the container or else everytime the container is destroyed its volume is too - which includes your JWT seed and all
https://docs.anythingllm.com/installation-docker/local-docker
export STORAGE_LOCATION=$HOME/anythingllm && \ # <-- this mounts storage between container reboots
mkdir -p $STORAGE_LOCATION && \
touch "$STORAGE_LOCATION/.env" && \
docker run -d -p 3001:3001 \
--cap-add SYS_ADMIN \
-v ${STORAGE_LOCATION}:/app/server/storage \
-v ${STORAGE_LOCATION}/.env:/app/server/.env \
-e STORAGE_DIR="/app/server/storage" \
mintplexlabs/anythingllm

The service runs using docker compose, is there a way to include the proper configuration to the docker-compose.yml file?

Does /DATA/AppData/anythingllm/storage exist on host filesystem? it should be populated with information and files like anythingllm.db and other folders.
volumes:
      - type: bind
        source: /DATA/AppData/anythingllm/storage
        target: /app/server/storage

I think what might be missing is the second volume mount command for the .env file
-v ${STORAGE_LOCATION}/.env:/app/server/.env
volumes:
      # binds folder
      - type: bind
        source: /DATA/AppData/anythingllm/storage # Binds to folder on host /DATA/AppData/anythingllm/storage
        target: /app/server/storage
      # binds env
      - type: bind
        source: /DATA/AppData/anythingllm/storage/.env # Maps .env in storage folder to correct place in image.
        target: /app/server/.env

This is also assuming the entire AppData directory is not being blown away between restarts.
You may need to make sure the .env file exists prior as well like we do in docker
touch "$STORAGE_LOCATION/.env" so for you it is touch /DATA/AppData/anythingllm/storage/.env

Does /DATA/AppData/anythingllm/storage exist on host filesystem? it should be populated with information and files like anythingllm.db and other folders.

It is there, with precisely those kinds of files and it is not blown away after restart, because in fact, in the login screen it still uses my custom app banner, which is stored under the .../storage/assets directory.
I tried adding that extra binding to .env on the docker compose and returned with this error
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/DATA/AppData/anythingllm/storage/.env" to rootfs at "/app/server/.env": create mount destination for /app/server/.env mount: cannot mkdir in /var/lib/docker/overlay2/08fc05bf0824b78b84cfbd66c2d0d1ba54761f9ac55ca7e38cd505561bc3258e/merged/app/server/.env: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type

Tried to create the .env manually afterwards with touch and initialize the container with the same bind added, returned the same error, so removed the binding but kept the manually created .env and it actually fixed it!, I can now change the image tag and recompose and it won't break.
I sincerely have no clue how it worked. Any idea?

@Xoconoch TBH if i said i did have an idea i would be lying and my mom raised me better. I think it might have been with the runtime being able to "recognize" the file is a file before mounting, but you have said you ran each command differently so I'm kind of at a loss.
I say lets just move on and if you get it again or others start to then we can begin looking at what might be going on here more closely.
Thank you for taking the initiative and self-debugging, it is greatly appreciated


[WIP] Feature/auth

Big PR alert!

huge PR, I haven't written specs out. I think it'd be best to split this.

@juliantejera
Current visual progress

It looks really good! 😁


Notebook updates

This should close out a bunch of the small issues in advance of the workshop.

Passed on osx/linux. Failure on AppVeyor unrelated.


Load JSON from file

Add support for reading JSON layout and metadata from an input file?

Addressed in 8c67b74


Update 06a-AddingApps.md - removefid

fix remote feature id command

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/manufacturing-guide/06a-AddingApps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Intelligently read in fits files

#316: Make sure that fits files are read in as the correct type. Add a targetpixelfile.open() function to check Kepler or TESS specific keywords and correspondingly open either a KeplerTargetPixelFile or TessTargetPixelFile.

from lightkurve.targetpixelfile import open_fits

open_fits('/path/to/kepler/or/k2.fits') # returns a `KeplerTargetPixelFile`
open_fits('/path/to/tess.fits') # returns a `TessTargetPixelFile`

Codecov Report

Merging #317 into master will decrease coverage by 0.3%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   89.61%   89.31%   -0.31%
==========================================
  Files          28       28
  Lines        4055     4070      +15
==========================================
+ Hits         3634     3635       +1
- Misses        421      435      +14

Impacted Files
Coverage Δ

lightkurve/targetpixelfile.py
88.15% <6.66%> (-2.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de83814...997709f. Read the comment docs.

@nksaunders Do you think we should extend open() to also detect and read in LightCurveFile files?

@barentsen open() now detects TargetPixelFiles and LightCurveFiles based on header information and returns the corresponding object.
I wasn't sure where to put this function, so I moved it to the search module for now. I initially thought it would make sense in utils, but as both lightcurvefile and targetpixelfile depend on utils, it created circular imports when I tried to return the correct object. Any thoughts on where it should end up?

This looks good to me! @barentsen if you're happy with it, go ahead and merge.

Unit tests are green!  Merging in 3 ... 2 ...


Crash while adding subtitleFont

let notification = RNNotificationView()
notification.titleFont = UIFont(name: "AvenirNext-Bold", size: 12)!
notification.titleTextColor = UIColor.white
//Crashes on below line
notification.subtitleFont = UIFont(name: "AvenirNext", size: 14)!
//notification.isAnimating = true
notification.show(withImage: nil,
title: "Application Name",
message: "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.",
                      onTap: {
                        print("Did tap notification")
    })

The AvenirNext has installed?
The unwrapper 'UIFont(name: "AvenirNext", size: 14)!' cause crash if value of nil.
You can verify this and return contact?
Thanks.

Finished for lack information(feedback).


Bump release-0.10 to use go 1.12.10

What this PR does / why we need it:
Bumps release-0.10 to use the latest Go 1.12 patch version
Which issue this PR fixes: fixes #2091
Release note:
Build using go 1.12.10

/lgtm


Fix: Spelling error in Mutation Drawer

Description
Fixes a spelling error found during PR review.

Coverage remained the same at 34.762% when pulling 1b5f7d25ff74aecc987e933c16c91704bcd726c0 on johnwcallahan:M3-XXXX-mutation-drawer-spelling-error into ea2ca57cb90f5e88ce2b0004fe8bb4738e47f33a on linode:develop.


field ips not found in type whalewall.externalRules

Hey.
For few hours trying to understand what I'm doing wrong. I've configured like this:
  mariadb:
    image: mariadb:11.3.2
    container_name: mariadb
    restart: always
    ports:
      - '3306:3306'
    volumes:
      - mariadb-data:/var/lib/mysql
      - /etc/localtime:/etc/localtime:ro
      - /etc/timezone:/etc/timezone:ro
    environment:
      - MARIADB_ROOT_PASSWORD=${MYSQL_ROOT_PASSWORD}
      - MARIADB_DATABASE=mail-service
      - MARIADB_USER=mail-service
      - MARIADB_PASSWORD=${MYSQL_PASSWORD}
    labels:
      whalewall.enabled: true
      whalewall.rules: |
        mapped_ports:
          localhost:
            allow: true
          external:
            allow: true
            ips:
              - "<IP_ADDRESS>/24"

But once I deploy I get this error:
{"level":"error","time":"2024-03-21T23:19:08.073478263Z","msg":"error creating rules","container.id":"753d9138c41f","container.name":"mariadb","error":"error parsing rules: yaml: unmarshal errors:\n  line 6: field ips not found in type whalewall.externalRules","stacktrace":"github.com/capnspacehook/whalewall.(*RuleManager).createRules\n\tgithub.com/capnspacehook/whalewall/create.go:64\ngithub.com/capnspacehook/whalewall.(*RuleManager).Start.func1\n\tgithub.com/capnspacehook/whalewall/manager.go:112"}

What whalewall version are you using? Can you post the output of whalewall -version?

What whalewall version are you using? Can you post the output of whalewall -version?

I tried 0.2.0 and 0.2.3, got the same issue on both.

So the solution was to instead of ips use ip:
          external:
            allow: true
            ip: "<IP_ADDRESS>/24"

@capnspacehook could you release new docker image 0.2.4 with multiple ips support?

Yeah I didn't realize I haven't cut a new release in over a year... I'll do that soon

@capnspacehook sorry but do you know when you might release newer version? I'm currently stuck with releasing as I need the support for two IP addresses.

This is still not released. @capnspacehook can you please cut a new version?


flakes: update to latest version

Description
Update flake.nix and flake.lock to latest version of flakes.
Checklist

[ ] Change is backwards compatible.

[ ] Code formatted with ./format.

[ ] Code tested through nix-shell --pure tests -A run.all.

[ ] Test cases updated/added. See example.

[ ] Commit messages are formatted like
{component}: {description}

{long description}

See CONTRIBUTING for more information and recent commit messages for examples.

If this PR adds a new module

[ ] Added myself as module maintainer. See example.

[ ] Added myself and the module files to .github/CODEOWNERS.

cc @nrdxp and @kisik21

Thanks, merged to the bqv-flakes branch.


Dependency updates - Dockerfiles/scripts

Description
A clear and concise description of what the feature request. Example: As a user having X would help me accomplish Y.
Proposed solution
A clear and concise description of what you want to happen with screenshots when applicable.
Additional context
Add any other context about the feature, alternatives considered, link to Figma, etc.

Code complete

Code complete, blocked by load tests and springboot.

Closing this as complete, since we've enabled Dependabot for Docker scripts and updated many of them during the Spring update.


Import get_terminal_size from shutil

get_terminal_size  function has been removed from Click 8.1.0. We should use shutil.get_terminal_size instead.
This change is required to handle the following error when using spaCy 3.2.3.
ImportError: cannot import name 'get_terminal_size' from 'click.termui'

Note this is a duplicate of #375 and the issue is being tracked in #377.

I prefer this over #375 because this PR respects the alphabetical ordering of the existing import statements.

#375 follows isort (used by this project) ordering in which standard library imports are placed before external library imports.

#380 was just merged, sounds like a new release is coming soon.

27 minutes ago: https://pypi.org/project/typer/0.4.1/
FYI, anyone running into this via some application in pre-commit, especially pre-commit.ci, environments are cached (globally), so you might still see issues for a while.

Hello! I just released Typer 0.4.1 that includes #380 based on #375, it should handle this. :rocket: :nerd_face:


[Dns] Rename some models

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Dns


Moved hardcoded URLs to build.grade Fixed #2850

Description
Moved the hardcoded URLs to the build.grade file so that the code is easier to maintain, also it removed the duplicate strings :)
Fixes #2850 Moving URLs from About Activity to build.gradle
Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28 stock android.

Codecov Report

Merging #2851 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2851      +/-   ##
=========================================
- Coverage    3.42%   3.42%   -0.01%
=========================================
  Files         246     246
  Lines       12193   12195       +2
  Branches     1071    1071
=========================================
  Hits          418     418
- Misses      11744   11746       +2
  Partials       31      31

Impacted Files
Coverage Δ

...c/main/java/fr/free/nrw/commons/AboutActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a555c...400163b. Read the comment docs.

@maskaravivek changes made as per the discussion


Prevent status triggered reconciles

Usually a status update triggers a new reconcile, no matter who updated the status. In a well implemented idempotent Reconcile this isn't a issue, but still a waste of compute power and potential API calls.
Also, the NHC controller is the only component writing to the status.
So it's safe to skip reconcile for status updates.

/test 4.14-test

/test 4.14-openshift-e2e

/override e2e-k8s

/lgtm

/retest


SKDMAN can't install maven 3.3.9 (OSX)

Hi
Unable to install maven 3.3.9, on OSX Sierra, output below. Am I doing something wrong ?
zsh 475 [1] % sdk version
SDKMAN 5.5.6+219
zsh 476 % sdk install maven
Downloading: maven 3.3.9
In progress...
curl: option --progress-bar --location: is unknown
curl: try 'curl --help' or 'curl --manual' for more information
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /Users/laurent/.sdkman/archives/maven-3.3.9.zip or
/Users/laurent/.sdkman/archives/maven-3.3.9.zip.zip, and cannot find /Users/laurent/.sdkman/archives/maven-3.3.9.zip.ZIP, period.
Stop! The archive was corrupt and has been removed! Please try installing again.

oops, looks like duplicate of https://github.com/sdkman/sdkman-cli/issues/531


Address input selection

Description
complete, alerts the user if the location they are adding has already been saved.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

tooooo many merge conflicts.


Rewrite of get_gambl_metadata and new helper functions

The main changes are:

get_gambl_metadata replaces og_get_gambl_metadata functionality but allows backwards compatibility. This function does a variety of checks for consistency in the metadata/biopsy tables and reports issues it finds.
check_gene_expression ensures RNA-seq is prioritized the way we want and always deduplicated
get_gene_expression now relies on both the new functions and their new features

exome_priority_meta = get_gambl_metadata(capture_protocol_priority = "Exome")
2908 capture samples are missing a value for protocol. Assuming Exome.
55 biopsies are missing from the biopsy metadata. This should be fixed!
affected cohorts:  DLBCL_Weng,DLBCL_Jain
27 biopsies with discrepancies in the pathology field. This should be fixed!
10 biopsies with discrepancies in the time_point field. This should be fixed!

> table(exome_priority_meta$protocol)

      Capture      chromium  ctDNA_Genome         Exome        genome        Genome         polyA         PolyA
           34             3             5          3213            68          1854            11          1108
Ribodepletion
         1235

not_exome_priority_meta = get_gambl_metadata(capture_protocol_priority = "Capture")
2908 capture samples are missing a value for protocol. Assuming Exome.
55 biopsies are missing from the biopsy metadata. This should be fixed!
affected cohorts:  DLBCL_Weng,DLBCL_Jain
27 biopsies with discrepancies in the pathology field. This should be fixed!
10 biopsies with discrepancies in the time_point field. This should be fixed!

> table(not_exome_priority_meta$protocol)

      Capture      chromium  ctDNA_Genome         Exome        genome        Genome         polyA         PolyA
           52             3             5          3195            68          1854            11          1108
Ribodepletion
         1235

Would someone be able to test this again now that I've patched a few more bugs? It was a bit more involved to implement properly but it looks like the format (long/wide) is working as expected.


Development mode : local Object Storage

To avoid to use a remote service (for development purpose,or no internet case for example), there is now some Local implementation of previous internal API. There is also a ObjectStorageFactory that returns the right implementation (local or remote) according to the configuration (if "credentials" is set then we use remote implementation, or if "baseDir" is set then we use local implementation.

thank you @lcotonea, but this is outside of the scope of this project

Ok. I'll make a project based on bluemix-objectstorage-serversdk-nodejs library.


WIP: Add -NoSubject switch to Send-MailMessage cmdlet

PR Summary
Fix #4043.
Adds a new parameter set with -NoSubject switch to opt-in, which allows to send a mail message without a subject.
Adds test cases for named and positional parameters. No test case for pipeline input due to error as stated by #7591.
Adds context scopes for test cases to differentiate between parameter set tests.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[x] User-facing Documentation needed

[x] Issue filed - Issue link: PowerShell/PowerShell-Docs#2852

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ThreeFive-O sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@ThreeFive-O Fix CodeFactor issues as well.

@kvprasoon Thank you for the feedback. I've fixed the spacing issues.
Regarding CodeFactor feedback: Most of the issues were the spacing issues as you pointed out. The other four remaining issues are styling issues which would have to apply for the entire file. But I stick to the coding style within the file. Maybe a separate PR which improves the code style would help here.
One problem I've encountered: My access to the CodeFactor feedback for this PR was denied. I had to clone the code into my own CodeFactor namespace to see the issues. Are you able to access the feedback of CodeFactor directly by clicking "Details" for this PR?

Nop I won't have. Cc: @iSazonov

I lost access to CodeFactor too.
/cc @TravisEz13

I think codefactor should be back.  I had last access as well.

@ThreeFive-O You have added new switch but not implement logic to exclude a subject from the mail.

@iSazonov This is intended: There is no explicit logic to leave the subject out. The implicit logic is the parameter binding. Since the named parameter -Subject won't be bound using the -NoSubject parameter, the subject of the email will be assigned to null.
The possibility to get a wrong behavior would be with pipeline input, but this behavior is not correctly implemented (see also #7591), since the implemented core logic only allows attachments to be piped.
If you wish, one could implement a simple logic to set the mail subject explicitly to null, but due to #7591 the current implementation would have to undergo a bigger code change anyway.
In my humble opinion this PR is the simplest way to implement the behavior without changing the core logic of the code too much.
@kvprasoon  As of the CodeFactor issues: This is also intended not to be fixed in this PR, since the entire document has a different coding style. Merging this PR with all CodeFactor issues fixed would result in a mixed coding style. As cited by the coding guidelines of this repository:

As a general rule, our coding convention is to follow the style of the surrounding code.

@ThreeFive-O CodeFactor checks only for changed/added lines and you have to correct it regardless of the existing code style. CodeFactor is recently added, hence not applied to existing code and I think there won't be an effort to trigger CodeFactor check against the whole codebase.
@iSazonov Correct me if I'm wrong.

@ThreeFive-O Thanks for clarify! I think it is a tricky logic and we MUST add a comment to descibe the behavior in the parameter description.
@kvprasoon We are in a transition phase and we haven't strong requirements about style issues. In the transition time we welcome and accept style fixes in separate PRs or in separate commits but don't force contributes to do this.
If @ThreeFive-O have plans to continue fix issues in the cmdlet (#7591) it would be nice to fix style issues in the file beforehand.

@dantraMSFT Could you please review the small PR?

        _mMailMessage.Subject = _subject;

I would suggest setting this only if -NoSubject is not present.
Something like the following:
if (!NoSubject.IsPresent)
{
_mMailMessage.Subject = _subject;
}

Refers to: src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs:379 in 9fdce4f. [](commit_id = 9fdce4f39cae56fd5590dcf806da6bdf4dc911a8, deletion_comment = False)

Implemented logic as suggested by @dantraMSFT and previously mentioned by @iSazonov.
Fixed the code factor issues as suggested by @kvprasoon.
Changed to auto property as suggested by @iSazonov.
The other style issues shall be fixed in an upcoming PR.

@PowerShell/powershell-committee reviewed this and recommends the proposal we put in the issue https://github.com/PowerShell/PowerShell/issues/4043

@ThreeFive-O Sorry, PowerShell Committee conclusion is that we should change Subject parameter and not add new parameter. I think you could close the PR and implement the conclusion in new PR.

@iSazonov Thank you. Will make a new PR soon.


Strange message

I'm using spago v<IP_ADDRESS>, purs v0.12.3 and the latest package-set psc-0.12.3-20190323-2. Everything is ok, except for this strange message that keeps popping up, saying:
WARNING: the package-set version you're on doesn't check if the version of the
PureScript compiler installed on your system is compatible.
If your build fails you might want to upgrade your set by running this command:
`spago package-set-upgrade`

My guess is that spago gets confused by this -2 in the end of a package-set name. If this is the case then maybe it would be better to change current format from psc-version-date to psc-version-date-x (where x stands for 0, 1, 2 and so on), to be more explicit about the fact that it is possible to have more then one release in one day.

@starper good catch! Fix up in #161

@f-f What do you think about changing package-set version format from psc-version-date to psc-version-date-x?

@starper I have no opinion on it. While it's not optimally consistent, it's consistent enough so that the clients can use it, so it's good by me :)

@starper new release with the fix: https://github.com/spacchetti/spago/releases/tag/<IP_ADDRESS>


Added resolutionator.app

Nice, (and sofar gratis) app from many tricks for getting a resolution menubar item: http://manytricks.com/blog/?cat=34

Fixed!  Woops.

Could you please squash your commits?

Could you please squash your commits?
Done


render should  replace the element

What version of Hono are you using?
4.0.0-rc.0
What runtime/platform is your app running on?
any
What steps can reproduce the bug?
index.html:
<!DOCTYPE html>

foo

src/main.tsx:
import { render } from 'hono/jsx/dom'

const root = document.getElementById('root') as HTMLElement
render(
bar
, root)

What is the expected behavior?

What do you see instead?

Additional information
No response

Hey @usualoma
Is this the behavior you expect? I want the render to replace the contents. Or I want the hydrate method to replace the content.

@yusukebe
Thanks for pointing that out.
How about a fix for #1938.

Fixed by #1938


Feat: Allow overriding channel config via .env file

Because

#582

This PR

Allows channel ID's to be overridden via .env
Modifies .env.sample to include a note on this functionality

Issue
Closes #582
Additional Information

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[x] If this PR addresses an open issue, it is linked in the Issue section
[x] If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

At this point, I don't see a reason for us to keep our own channels hard coded at all. A maintainer can migrate the hard coded channels into the .env on the server. Since a user who is forking and cloning the bot will have no use of the hard coded values anyway, and they won't work even if they used them. I would just include all the channels into .env.
This will also reduce the logic that is in the config file after this PR.

I have a few thoughts on this, but am currently on holiday; will see if I can get them together tomorrow

So a few thoughts:

How would this work with tests? The text-based commands make extensive use of snapshots to check validity, and those snapshots include the embedded channel ID's. Without some way to access those, snapshot tests aren't possible in the same way
How would this work with adding new channel ID's? Right now if I need to add a new one, I can simply add an extra field to the config. If we divorce the production ID's from config, I'd need to push a PR, then ask the merging maintainer to also add the new ID to the prod env variables, but that introduces both delay (during which the command is broken), and opportunities for forgetting/mistyping.

So a few thoughts:
1. How would this work with tests? The text-based commands make extensive use of snapshots to check validity, and those snapshots include the embedded channel ID's. Without some way to access those, snapshot tests aren't possible in the same way

2. How would this work with adding new channel ID's? Right now if I need to add a new one, I can simply add an extra field to the config. If we divorce the production ID's from config, I'd need to push a PR, then ask the merging maintainer to also add the new ID to the prod env variables, but that introduces both delay (during which the command is broken), and opportunities for forgetting/mistyping.

Tests shouldn't be effected by this, there should be mocked to replace the IDs with arbitrary ones. If some test were effected, then that is bad design in the test themselves, and we can refactor those. But I understand if you don't feel like working on those tests in this PR itself we can see to move forward with this, and I can refactor that later to include only IDs in .env
I don't see a problem with maintainer have to do this themselves in the .env file. There are some channels that you do not have access to, for example, and you wouldn't be able to retrieve their IDs without maintainer help. Another thing is a maintainer are able to create new channels which they will include in the .env themselves afterward it wouldn't be expected of you to come and do a PR every time a new channel is created.
Since the maintainer will merge the PR, I don't see it being a problem when they do the change afterward. I would personally still prefer a file to contain a hard coded value or an .env, having both doesn't seem necessary and add complexity / logic to configuration files.
But that's just me, maybe it's ok by the maintainers, then we can move forward without having to worry about the things you mentioned.

@TheOdinProject/odin-bot thoughts about the above? Makes sense to me but since it would change our workflow, I wouldn't want this approved without us all being aware of the change, since I'm not sure if all of us have access to the bot deployment itself (I don't).


[5.8] [SSADestroyHoisting] Don't fold over trivial use.

Cherry-pick of https://github.com/apple/swift/pull/62873
Given an aggregate addr %agg with trivial subobject addr %triv and nontrivial subobject addr %sub which %triv is projected from,
  Aggregate   <- %agg
    Subobject <- %sub
      Trivial <- %triv
      ...
    ...

after %sub is destroyed, %triv is no longer initialized.  As a result, it's not valid to fold a destroy_addr of %agg into a sequence of load [copy]s and copy_addrs if there's an access to %triv after the load [copy]/copy_addr of %sub (or some intermediate subobject).
In other words, transforming
  copy_addr %sub
  load [trivial] %triv
  destroy_addr %agg

into
  copy_addr [take] %sub
  load [trivial] %triv

is invalid.
During destroy_addr folding, prevent that from happening by keeping track of the trivial fields that have already been visited.  If a trivial field is seen more than once, then bail on folding.  This is the same as what is done for non-trivial fields except that there's no requirement that all trivial fields be destroyed.

@swift-ci please test


cast negative zero to string inconsistent with Spark

Describe the bug
SQL
SELECT c8, length(c8) AS x FROM test0 ORDER BY c8;

Spark Plan
AdaptiveSparkPlan isFinalPlan=true
+- == Final Plan ==
   *(2) Sort [c8#8 ASC NULLS FIRST], true, 0
   +- AQEShuffleRead coalesced
      +- ShuffleQueryStage 0
         +- Exchange rangepartitioning(c8#8 ASC NULLS FIRST, 200), ENSURE_REQUIREMENTS, [plan_id=7298]
            +- *(1) Project [c8#8, length(cast(c8#8 as string)) AS x#9969]
               +- *(1) ColumnarToRow
                  +- FileScan parquet [c8#8] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/andy/git/apache/datafusion-comet/fuzz-testing/test0.parquet], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c8:float>
+- == Initial Plan ==
   Sort [c8#8 ASC NULLS FIRST], true, 0
   +- Exchange rangepartitioning(c8#8 ASC NULLS FIRST, 200), ENSURE_REQUIREMENTS, [plan_id=7284]
      +- Project [c8#8, length(cast(c8#8 as string)) AS x#9969]
         +- FileScan parquet [c8#8] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/andy/git/apache/datafusion-comet/fuzz-testing/test0.parquet], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c8:float>

Comet Plan
AdaptiveSparkPlan isFinalPlan=true
+- == Final Plan ==
   *(1) ColumnarToRow
   +- CometSort [c8#8, x#9975], [c8#8 ASC NULLS FIRST]
      +- AQEShuffleRead coalesced
         +- ShuffleQueryStage 0
            +- CometColumnarExchange rangepartitioning(c8#8 ASC NULLS FIRST, 200), ENSURE_REQUIREMENTS, CometColumnarShuffle, [plan_id=7361]
               +- CometProject [c8#8, x#9975], [c8#8, length(cast(c8#8 as string)) AS x#9975]
                  +- CometScan parquet [c8#8] Batched: true, DataFilters: [], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/home/andy/git/apache/datafusion-comet/fuzz-testing/test0.parquet], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c8:float>
+- == Initial Plan ==
   CometSort [c8#8, x#9975], [c8#8 ASC NULLS FIRST]
   +- CometColumnarExchange rangepartitioning(c8#8 ASC NULLS FIRST, 200), ENSURE_REQUIREMENTS, CometColumnarShuffle, [plan_id=7348]
      +- CometProject [c8#8, x#9975], [c8#8, length(cast(c8#8 as string)) AS x#9975]
         +- CometScan parquet [c8#8] Batched: true, DataFilters: [], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/home/andy/git/apache/datafusion-comet/fuzz-testing/test0.parquet], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c8:float>

First difference at row 33:
Spark: 0.0,3
Comet: -0.0,4
Steps to reproduce
No response
Expected behavior
No response
Additional context
No response

This seems like a low priority edge case


Remove unnecessary state CoWs.

Motivation:
When benchmarking the HTTP/2 implementation I noticed that we were
performing a large number of CoW operations on the Dictionary that backs
the ConnectionStreamState structure: specifically, once per frame sent or
received.
This is substantial and unnecessary allocation overhead that drags down
the performance of the program, sprays the heap with small allocations, and
generally just leads to nasty performance costs with no gain.
Sadly, this turns out not to be the easiest CoW to get rid of, because
the ConnectionStreamState structure is stored in associated data on the
connection state machine state enumeration. This means that our usual tricks
for avoiding the CoW (such as swap()) no longer work.
The only solution is to add a new state that corresponds to no state at all
so that we can make the connection state go away while we mutate it. This is
all a bit gross, frankly. Unfortunately, the act of making this simple change
leads to a huge diff as we have to tweak basically every state machine
function in order to ensure that it does the right thing.
Modifications:

Added a function to control CoWing the state machine.
Used that function basically everywhere.
Made sure that function had assertions.
Annoyingly had to increase the visibility of a bunch of structs.

Result:
Fewer CoWs, better performance, sadder code reviewers.

The unfortunate irony here is that the net performance gain of this patch in a more real-world benchmark is pretty small: about 1.5%. The reality is that in that benchmark we just aren't copying too much state around, so the CoWs don't hurt too badly.

Oh god, I hope I don't get retained, I don't need a cow.

Oh god, I hope I don't get retained, I don't need a cow.

It's fine, you just killed a lot of cows. Enjoy 🥩

more real-world benchmark is pretty small: about 1.5%.

I think in the real world under allocator pressure this could have a much better impact.

Indeed, I'm still strongly in favour of removing it: it's just not a really heavy hitter.


samuelattard.com outbound connection (call home) never stops

I use Little Snitch to control my outbound connections.
When I launch the app. It attempts to connect to the server samuelattard.com
I understand that this is the main developer's personal website / server. I'm not 100% sure why/what reason it wants to connect for and I have nothing against simple 'phone home' checks for apps. However, I would like to personally deny this outbound connection. The same as I disallow outbound tracking connections from Google.
This is where in lies the problem.
The outbound connection for samuelattard.com has no max tries count or even a timeout so as long as I'm not playing any music from the app, it will constantly attempt to connect causing massive CPU spikes.

OS X 10.11.3
Version: 3.0.1
I'm not saying to completely take out this outbound connection (I honestly don't know why it's necessary to be honest but that's another subject). What I am suggesting is to at least implement a counter for a max_connections or a 30 second timeout or even both would ideal.
Let me know what you think.

That connection is part of the mini player, basically there is a "default" image for when music isn't playing.  I'll probably move it into source control and package it with the release.
The unlimited retries is a side effect of how the default image works.  It detects an error fetching an image and then attempts to fetch the default image, if the default image fails it will of course try again :+1:
TLDR: Fair enough, I'll move it to a local file

So turns out that I got this bit wrong and i can't distribute the file locally because it is part of the separate mini player library.  I'll implement a max-retries there I guess?  But you really shouldn't be blocking an image :-1:

This is still a problem
http://jwm.d.pr/nfTMe7/5tFtUmPq


Fix TLS for Redis configuration in load balancer

Purpose
When enabling TLS for Redis through wso2.apk.dp.redis.tls set to true installation failed with:
    * Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal bool into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.86%. Comparing base (7493088) to head (44b8c84).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2038       +/-   ##
===========================================
+ Coverage   25.75%   39.86%   +14.11%
===========================================
  Files         126       14      -112
  Lines       14984     1179    -13805
  Branches     2672      246     -2426
===========================================
- Hits         3859      470     -3389
+ Misses      11001      709    -10292
+ Partials      124        0      -124

Flag
Coverage Δ

common-controller
4.61% <ø> (?)

idp-domain-service
80.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM


[rt.openssl.org #4635] BUG: 100% CPU in windows with openssl-1.0.2h

Migrated from rt.openssl.org#4635 (status was 'open')
Requestors:

<EMAIL_ADDRESS>
From<EMAIL_ADDRESS>on 2016-07-30 08:32:44:
Hi,

We are observing 100% CPU in windows. Request you to help us to solve it.

a) SSL method used : TLSv1_2_client_method at client side and TLSv1_2_server_method at the server side

b) Open SSL version: openssl1.0.2h

c) Cipher : "AES128-GCM-SHA256", we have tried other ciphers also, but the same problem observed.

We use VS2010 compile (Microsoft Visual Studio 10.0).

Rgds,
Navi

From<EMAIL_ADDRESS>on 2016-07-30 14:25:13:
We need some details.  Like which function(s) are using the CPU.

never got any details, closing.


Updates to "Configure channel permissions"

Not monetization will be available for MVP so this issue is not necessary.


Add Kafka binder health indicator

Health indicator fetches broker addresses using ZK configuration and matches it with the leaders of the paritions being used in the binder

This resolves #297

Updated the PR to handle exception when connecting to ZK.

Updated the PR to rename the ZK properties and also moved those properties to KafkaBinderConfigurationProperties instead of the default properties.

Squashed, rebased, merged w/https://github.com/spring-cloud/spring-cloud-stream/commit/0fb431db3ae326cb6d518c080ceac6297cc8d4c4 with additional changes in https://github.com/spring-cloud/spring-cloud-stream/commit/b1b0e960d78d77c830fb02acbdbe88d476b3a25f