MySQL 8 support broken

The image uses mariadb-client instead of mysql-client. This means that anything trying to connect to MySQL 8.0 server will fail by default because the mariaDB client does not include support for the caching_sha2_password plugin. This is a fatal error that can't easily be fixed from outside because MariaDB does not support this authentication mechanism, so in a testing scenario like this, it is not an appropriate substitution. This is how it is configured in CI:
db-seeding:
  stage: build
  services:
    - mysql:8.0

and here's an example of how it fails in a pipeline:
The command "mysql --user="${:LARAVEL_LOAD_USER}" --password="${:LARAVEL_LOAD_PASSWORD}" --host="${:LARAVEL_LOAD_HOST}" --port="${:LARAVEL_LOAD_PORT}" --database="${:LARAVEL_LOAD_DATABASE}" < "${:LARAVEL_LOAD_PATH}"" failed.
Exit Code: 1(General error)
Working directory: /builds/myapp
Output:
================
Error Output:
================
ERROR 1045 (28000): Plugin caching_sha2_password could not be loaded: /usr/lib/x86_64-linux-gnu/mariadb19/plugin/caching_sha2_password.so: cannot open shared object file: No such file or directory

This was fixed once before in a PR, but that was never merged.
A possible workaround would be to manually install the mysql client package prior to running the pipeline, but that should not be something we need to do in a default config.

I remember back in the time that there's a reason to this change to mariadb-client, but was a long time ago and i don't remember why anymore, so, i think we can change back to mysql-client again and see

I found that reference. I checked, and it's correct – Debian buster does not provide a MySQL package (which I'm a bit surprised by). MySQL's policy on this is that they provide a repo for Debian packages that you should use instead. Unfortunately this implies a certain a mount of inconvenience as per this guide, though the problem here is with the client; we don't need the server. I'll have a go at scripting that in my PR, which won't work in its current state.

I have found a workaround for this. In the gitlab.ci.yml file, instead of saying:
services: mysql:8.0

say:
services:
    - name: mysql:8.0
      command: [ "--default-authentication-plugin=mysql_native_password" ]

which makes the client use old-style authentication. Bear in mind that this is very much a workaround as it involves a security downgrade.


Update person and company structs with latest API data

I used this: https://mholt.github.io/json-to-go/

Related to #9

Confirmed via my local testing: This closes #9, and there is no longer an error when enriching a person.
(Other structs there may be out of date, though).

thanks for the update @philipithomas


IMAP > Retrieved Mail Ordering is incorrect

Using the defaults, i.e.
emails = Mail.find(:mailbox => 'my_mailbox', :keys => ['SUBJECT','my_subject'])
The returned emails are in the following order:
To<EMAIL_ADDRESS>Date: 2016-03-23T09:25:59+00:00
To<EMAIL_ADDRESS>Date: 2016-03-23T09:25:59+00:00
To<EMAIL_ADDRESS>Date: 2016-03-23T09:26:00+00:00
To<EMAIL_ADDRESS>Date: 2016-03-23T09:25:59+00:00
To<EMAIL_ADDRESS>Date: 2016-03-23T09:26:00+00:00
You can see that the second last email is in the wrong order, it should be in position above.

That's up to your IMAP server. Check out the :order and :what options to change the sort order and such as well.


Add support for candidate type and full description in complex-candidate

Candidate type: Argument completers should be able to tag candidates with types. For instance, a git completer can produce candidates that are git flags, git branches, filenames and so on; it should be able to tag candidates as such.
Full description: This should be obvious. There is some support for it with display-suffix now but it's quite hacky.

The full description should be the full text that is displayed in the terminal for the given candidate. This can be useful e.g. when completing long paths (long candidates), but displaying only the basename of the given candidate.
Another approach to format displayed candidates: tagged candidates. Each candidate has a tag and a description, and the editor formats the displayed text according to the terminal size. (Similarly how tagged paragraphs in man pages works.)
Use cases:

completing options with descriptions in a beautifully formatted way
completing Git commit hashes (as tags) with commit messages (as descriptions)

Each candidate should have a function that is called, when the given candidate is selected.

@notramo Can you elaborate "tagged candidates"? It seems to me that what you call "tags" is simply the text (what gets inserted when the candidate is accepted) of the candidate.
I don't think we should make what happens when a candidate gets accepted (I think you mean accepted instead of selected) customizable. It sounds more like a use case for programmable listing mode (#180).


Update gitignore, Update for Xcode9 and iOS11

Sorry I can't merge this commit because it changed a lot of code. The significant change is changing zoomView from UIImageView to UIView.


Transition from OldDot to NewDot is slow and shows blank screen for long time

### Problem
Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1694668433572469?thread_ts=1694666491.998029&cid=C05LX9D6E07
When a new lead user signs up on OldDot and they want to chat with their setup specialist in NewDot, we use a transition to new.expensify.com to keep their session going in this new app.
However, this transition seems to got very slow now and blank page is shown for over 15 seconds which is terrible UX.
Seems like the issue is that on a first load we dont have proper data to show the reports

after refreshing it works fine

Solution
Investigate why the onyx data is not correctly loaded upon making the transition and fix it
cc @staszekscp @koko57

@mountiny I'm ready to help with this one 🙂

@koko57 will handle this one for us 🎖

Daily update: I'm still looking for the root cause, but I've noticed one strange thing - when the transition fails (I was logged in as a user A and wanted to log in as a user B) and I see the green empty screen the reports that are in the Onyx (like in the first screenshot) are the reports that should be displayed for the user A.

The rest of the data like login, contact methods, email, etc are already populated with user B's data. Then after the refresh the reports stay in Onyx unchanged among the reports that should be displayed for the user B

I logged out of both accounts and logged in separately again. For user A I had 185 keys in Onyx and for user B I had 340.
When logged in as user A and trying to transition from the OldDot as a user B, after the failure and then refresh I had 489 keys in Onyx.

Daily update: Although we're navigating to the report screen, report screen doesn't mount.
On OpenApp and OpeReport requests -  I tried to force both requests, but it didn't help. I'll continue looking into this issue tomorrow.

Thanks for the updates

Daily update: (Sorry for not posting yesterday) unfortunately, not much progress here. I'm digging into the logOut - logIn as a new user flow. I've noticed that in this flow we're firing signOut twice: here and here. I wonder whether this flow could be simplified somehow? The ReportScreen is not mounting as well as SidebarLinksData - which is weird bc CentralPaneNavigator and BaseSidebarScreen both are.

Daily update: today I asked Edu for some help, we both think it's possibly a navigation issue. I'll continue investigating it on Monday.

Investigation continues

Not much progress here. I only discovered that removing this from LogOutPreviousUserPage works but there's a glitch of the old user's chats at the beginning and there is some error in the session object after authenticating. As I've mentioned before we log out the user twice in the current flow. Maybe just simplifying it would fix the issue.

I guess I've finally found the root cause - it's a problem with Onyx. I'm starting working on my proposal.

Great! Thanks!

Working on a proposal, I have one solution on my mind, need to test it thoroughly. 🙂 If everything looks fine, maybe I'd be able to post the proposal tomorrow.

Unfortunately, my solution doesn't work properly, I need to find another one 😞

Came up with another solution, testing it now, but the first results look promising.

Proposal is almost ready, probably will post it tomorrow.

Yes, ty @koko57!

Sorry, it took me so long 🙈
Proposal
Please re-state the problem that we are trying to solve in this issue.
After transitioning from the OldDot to the NewDot the screen is empty (the sidebar and the main screen is displayed but with no content). The data is properly displayed only after refreshing the page. IMPORTANT NOTE: it happens only when user is logged in with another account than the one they want to transition from.
What is the root cause of that problem?
The main cause that the sidebar data and the report screen data is not being loaded is because the withOnyx HOC is missing some essential keys for both the Report Screen and the Sidebar components to render them - the loading state stays true so the HOC returns null instead of the wrapped component.
When the user is logged in on another account he is first being logged out (while still being on AuthScreens) then redirected to the LogInWithShortLivedAuthTokenPage to be then redirected back to the AuthScreens. This flow, in general, is not causing the problem but has a few flaws that actually do that.

When we’re on the AuthScreens the app tries to reconnect https://github.com/Expensify/App/blob/029d009731dcd3c44cd1321672b9672ef0d3d7d9/src/libs/Navigation/AppNavigator/AuthScreens.js#L166

We are sending logOut request twice: once in the setUpPoliciesAndNavigate https://github.com/Expensify/App/blob/029d009731dcd3c44cd1321672b9672ef0d3d7d9/src/libs/actions/App.js#L375-L377 - when we hit the AuthScreens, then on LogOutPreviousUserPage https://github.com/Expensify/App/blob/029d009731dcd3c44cd1321672b9672ef0d3d7d9/src/pages/LogOutPreviousUserPage.js#L33 and this second time we actually start clearing the Onyx (and clearing takes some time, it’s an async action)

after the SignInWithShortLivedAuthToken request AuthScreens are mounted again

We’re redirected to report route, Sidebar and Report Screen should be mounted we don’t have enough data in Onyx, so the components are not mounted

What changes do you think we should make in order to solve the problem?
I think that we should send the logOut request and startClearing the Onyx as soon as the AuthScreen mount. This way Onyx is cleared and populated with the necessary data faster - and the Sidebar and Report Screen components are mounting.
To achieve that I would:

move this lines https://github.com/Expensify/App/blob/029d009731dcd3c44cd1321672b9672ef0d3d7d9/src/libs/actions/App.js#L374-L377 to AuthScreens componentDidMount before this line https://github.com/Expensify/App/blob/d2c573fae7e3cba0173254ec78836ac65944ce2e/src/libs/Navigation/AppNavigator/AuthScreens.js#L162 (or even at the top)
change signOut method to signOutAndRedirectToSignIn (because this one starts clearing the Onyx)
Add a return after to prevent from firing all the methods below, because we don’t need them
remove https://github.com/Expensify/App/blob/029d009731dcd3c44cd1321672b9672ef0d3d7d9/src/pages/LogOutPreviousUserPage.js#L32-L34 because we won’t need it anymore.
These changes in the code made transitioning from another account possible and I didn’t found any regression they would may cause.

What alternative solutions did you explore? (Optional)
Could we possibly render the component if we don’t have the required keys? We usually pass default props for them.

Looks good to me, @allroundexperts what do you think of this proposal?

Thank you!
@koko57 can yuou please create a PR? I think we also wanted to speed up the transition when you are not logged in to other account, do you think that will get improved?

@mountiny these changes are only affecting the flow with the user previously logged in on another account. So it won't have any impact on the previously not logged in user transition.
On the PR - I started working on it today, merged with the newest main, but I've noticed that something has changed and my solution is no longer working 🙁 I'll be investigating it today

@koko57 mind giving us an update?

PR is still under review

@mountiny I saw this https://github.com/Expensify/App/issues/29849 and I'm on it. I know what's happening there but I need to find out why (bc it tested well, I wonder if there was some other changes that together with mine might have caused the issue)

payment tomorrow!

Payment Summary:

Contributor+: @allroundexperts $500

Please apply!

@allroundexperts mind completing checklist? 🙇♂

Agreed, @allroundexperts did you request on newdot? Can we close this issue?

$500 payment approved for @allroundexperts based on this comment.


improvement: return a map from decode_relay_id/1

Slight API improvement over #106.
This makes it more ergonomic to partially match on the return value (and it also makes it more explicit by explicitly labeling the two parts).
Also add tests for relay id encoding/decoding.
Contributor checklist

[x] Features include unit/acceptance tests

🚀 Thank you for your contribution! 🚀


[Event Request] Need old functionality from Codeunit 7000.OnAfterGetSalesLinePrice into new Price Functionality

I am using the Event OnAfterGetSalesLinePrice from Codeunit 7000 that is now marked obsolete.
This event has not been moved over to the new Price functionality, and my best guess on where it should be is:
in Table 37 function "PickPrice" get the event OnAfterPickPrice as the last line, with the same parameters as the old event
:: LOCAL [IntegrationEvent] OnAfterGetSalesLineLineDisc(VAR SalesLine : Record "Sales Line";VAR SalesLineDiscount : Record "Sales Line Discount")
If there is a different place that is better for this event, then I'm fine with that.
What I need is to be able to grab the results of the "Get Price" actions in the document subforms for the "Sales Line" table (which seem to call T37.PickPrice).
Cheers,
Kristján Gaukur Kristjánsson

Please note that since Sales Line Discount is also obsolete, it's not needed(used) here and will not be provided only Sales Line will be provided as parameter, if you discover that you need something else, let us know in another issue.

I need to know which price entry was found, so I can utilize my extension fields in that entry. (Be it "Sales Price" while it is not yet discontinued, and the "Price List Line" that is taking over.)
That is what the Event OnAfterGetSalesLinePrice from Codeunit 7000 is giving me now.
(Why do I need to create another issue?)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Is there a way to change the search to be 2 columns?

Hello, I have table:
first name | last name | email_address           | confirmation number
------------------------------------------------------------------------
John       |  Anderson |<EMAIL_ADDRESS>| abc123

I would like to have the search exactly match a combination of first and last name, or an exact match of just email, or just confirmation number.
so "John Anderson" would match but "John A" would not.   "abc123" would also match

Are you just asking  for full word match  rather than subtring?

Yeah, basically.  I've tried creating a column like "full_name" and told it to do an ExactWordIndexStrategy, but it seems to still split on spaces and search on those.   So "John " still matches even though I only want it to match if it gets "John Anderson"

So my idea was to either:
Match whole words by creating a full_name column OR tell it to some how match exact for 2 columns combined.   Either strategy would work for me.  I'm basically looking for no fuzzy matching, just exact word matching for each index.

Seems like you would need to supply your own tokenizer to create the custom search tokens you're looking for.

There's no built in, out of the box support for this though :)

Hah, yeah.  Didn't even think of that.  I guess what I'm literally looking for is:
    search.tokenizer = {
      tokenize( text ) {
        return [text];
      }
    };

That sounds more like the exact word strategy. Sounds like you want something more custom, that's multi-column match. So rather than converting a string to tokens of string-subsets, you want to convert a document to tokens of column-combinations.
I think this should be doable though :) good luck~


Max number of exchanges field in Arbitrage should be more descriptive, default to 7

Currently it just has a 1 in there, without any kind of description. Someone using the page for the first time wouldn't know what it is for.
Also, it should default to 7, so users don't need to change anything to have no limit to exchanges.

Defaults to 7 as of de3582bc1fa877f6934420a800fb0bef0c20f2c1.


Convert to browser code, and make generally better

[x] HDKey => DashHD
via #26
[x] bip39, root/passphrase => DashPhrase
via #27

pushd ~/.config/dash/; sd 'mnemonic' 'phrase' *.*

[x] @root/base58check, ripemd160 => DashKeys
via #28
[x] secp256k1 => @dashincubator/secp256k1
via #28
[x] @dashevo/dashcore-lib => DashTx

cleanup variable names, etc

All part of v0.5.4


Improve build process of grpc bindings

We are generating/compiling python bindings from .proto-files.
Before this commit the generated protobuf-files did not understand they
were a part of the glclient-module.
This resulted in broken imports which we fixed using sed in our
Makefile.
This commit improves the configuration and voids the need for hacks in
our Makefile.
For more info: See https://github.com/protocolbuffers/protobuf/issues/4176

Following up on our discussion re Google path semantics, I took a look at the generated _grpc.py files, and was surprised the URI was unchanged, instead its just the prefix for the serialization and deserialization was changed. This makes my concerns from yesterday invalid ^^
Today I learned :+1:

Rebased to remove that merge commit, merging asap


device sync now checks commit before syncing

@shaunmulligan can you commit this PR into new-features branch?


Wrapping UI

Hi!
Here's the frontend code for the wrapping page, it has no integration with any of the chain stuff, but I tried to keep the code super simple so it should be pretty easy to integrate!

@arjungandhi Nice job on the UI. Are you planning to implement the actual "chain stuff"?

I've never actually done that before, so I think it would take me a while before I could do it correctly, however Zencephalon mentioned he would be willing to take over and finish up the last part of the integration.


feat: support languages json/markdown

fixes #148

I think this part described in https://github.com/eslint/create-config/issues/148 isn't implemented:

The JavaScript option should be checked by default and if unchecked, we should add this to the config:
{
    ignores: ["**/*.js", "**/*.cjs", "**/*.mjs"]
}

Yes, I was able to repro!
Is it the expected behavior? My understanding is that it should only be applied to js/mjs/cjs files if no files are specified.
and I'm getting the same error even if I added files:
import pluginJs from "@eslint/js";
import json from "@eslint/json";

/** @type {import('eslint').Linter.Config[]} */
export default [
  {files: ["**/*.{js,mjs,cjs}"]},
  pluginJs.configs.recommended,
  {files: ["**/*.json"], language: "json/json", ...json.configs.recommended},
];


Added support for Cypress FM3 high performance series MCUs.

Added support for Fujitsu/Cypress/Infineon FM3 high performance series MCUs.
Verified probe-rs flash and debug scenarios on a custom Fujitsu FM3 (MB9BF618T)-based development board using a Segger J-Link Pro.

Confirmed that smoke_tester passes on the MB9BF618T over J-Link:
1/1 - Starting Test
1/1 - Probe: "J-Link"
1/1 - Chip:  "MB9BF618T"
1/1 - Core 0: Armv7m
1/1 - Halting core..
1/1 - Test [1] - Testing HW breakpoints
1/1 - Test [1] - 6 breakpoints supported
1/1 - Test [1] - Test passed in 195 ms.
1/1 - Test [2] - Test - RAM Start 32
1/1 - Test [2] - Test - RAM End 32
1/1 - Test [2] - Test - RAM Start 8
1/1 - Test [2] - Test - RAM 8 Unaligned
1/1 - Test [2] - Test - RAM End 8
1/1 - Test [2] - Test - RAM Start 32
1/1 - Test [2] - Test - RAM End 32
1/1 - Test [2] - Test - RAM Start 8
1/1 - Test [2] - Test - RAM 8 Unaligned
1/1 - Test [2] - Test - RAM End 8
1/1 - Test [2] - Test passed in 13 ms.
1/1 - Test [3] - Testing register write...
1/1 - Test [3] - Test passed in 68 ms.
1/1 - Test [4] - Testing register read...
1/1 - Test [4] - Test passed in 38 ms.
Testing stepping...
R0 value ok!
Core halted at 0x1fff0002, now trying to run...
Core halted again!
Core halted at 0x1fff0006, now trying to run...
Run core again, with pc = 0x1fff0008
1/1 - Test [5] - Test passed in 80 ms.
1/1 - Test [6] - Missing resource for test: No flash test binary specified
1/1 - Tests Passed
[DONE] - All DUTs passed.
Test summary:
[MB9BF618T] passed


Unable to create regions on clean canvas using Marker

Scenario 1:
a. Uploading the wav file using drag & drop option, then "add segment".
b. Starting clicking on canvas to insert the marker, on "enter" there is no marker action
Issue: Interval is not created using marker
Scenario 2:
a. Uploading the wav file using drag & drop option, then "add segment".
b. Using drag & selection for creating intervals doesn't get enabled/created on "enter" key shortcut.
Both the scenario are evident on using the uploaded wave file. After few random attempts we are able to to drag and create region, then it allows to use either drag or marker to create intervals. But cannot start creating the regions/interval using markers.

Just tested it using this audio file: https://github.com/IPS-LMU/EMU-webApp/blob/master/app/testData/newFormat/ae/0000_ses/msajc003_bndl/msajc003.wav and it does seem to work on my end. Here is what I did:

drag & drop audio file onto drop area of webApp
click "add level (SEG.)"
click onto new level to preselect it (turns a darker shade of grey). Alternatively you can also use the up and down cursor keys to select the current preselected level
mark a segment in the OSCI or SPEC canvas
hit enter

We should however probably automatically preselect the level that has just been added. @georgraess could you have a look at implementing this?

It is creating a region on marker but at first creating the region after drag not on inserting the marker at first before region drag

Sorry but you are going to have to elaborate a bit. I do not really understand what you are referring to in  your last comment.

I understood the way to create boundaries using mouse drag and then pressing enter/return key, but if i want to start with just using single event marker to create intervals. Using single event marker also works but after one interval is created using drag.
It so that i use "praat" desktop GUI where inserting single event marker creates left and right regions right from start of creating intervals.
Let me know how to create the intervals using single event marker from very first?

Ok now I know what you mean. You are right, that is not possible using the EMU-webApp. You have to first create a segment then you can add single boundaries to the left/right of that segment (or between) to create new segments but you can't add a single boundary to an empty level that then creates two segments which together are the length of the entire audio file. To be honest I don't quite know what to think of that behaviour and if it has any benefits for the annotator.

This preselects the level (which is a good thing) but it does not fix the issue -> reopening issue


NavigationServer MapGetPath returns empty path in C#, but equivalent works in GDScript

Godot version
Godot_v4.1.1-stable_mono_win64
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Compatibility) - NVIDIA GeForce RTX 2070 SUPER (NVIDIA; <IP_ADDRESS>13) - Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 Threads)
Issue description
NavigationServer2D's MapGetPath is returning an empty path while a very comparable GDScript version using map_get_path returns the expected coordinates.
The GDScript version logs one error:
update_polygons: Navigation map synchronization error. Attempted to update a navigation region with a navigation mesh that uses a different `cell_size` than the `cell_size` set on the navigation map.
  <C++ Source>   modules/navigation/nav_region.cpp:118 @ update_polygons()

While the C# version logs two; the above as well as this:
sync: Navigation map synchronization error. Attempted to merge a navigation mesh polygon edge with another already-merged edge. This is usually caused by crossing edges, overlapping polygons, or a mismatch of the NavigationMesh / NavigationPolygon baked 'cell_size' and navigation map 'cell_size'.
  <C++ Source>   modules/navigation/nav_map.cpp:845 @ sync()

I have made previous attempts to change the various cell_sizes just in case to no avail.
Steps to reproduce
With the MRP, you can switch the Node2 script from TestingNavigation.cs and TestingNavigation.gd to see the distinctions. With the GDScript attached, the path will properly print to the console while the C# version prints an empty path.
Minimal reproduction project
Navserver Path Issue.zip

I don't encounter any errors in the GDScript version of this project.
I dont have a CSharp setup to test so maybe the CSharp ppl can fill in the blanks.
Those errors should be unrelated to the used language as they are triggered by a mismatch of NavigationMesh cell size and navigation map cell size as well as navigation mesh placement on the map.
The first error is caused by the NavigationMesh resource property cell_size not being the same as the navigation map cell size. By default the NavigationPolygon and the 2D navigation map both use 1 pixel as cell size so there is no reason for this to trigger if you did not change this cell size manually. You can change the navigation map cell_size in the ProjectSettings in the navigation section (Advanced Settings) for the default navigation map or you can use the NavigationServer.map_set_cell_size() API function to change it for any map.
The second error is because the actual rasterization of the navigation mesh vertices and edges failed when the navigation map tried to sync the map. Caused by too many vertices and their edgekeys falling into the same grid cells. This is commonly caused by duplicated edges, or edges that are too close to each other, or edges that intersect each other. Those edges can be from the same navigation mesh but also from other navigation meshes, e.g. because they partly overlap. Since you only have a single navigation mesh in the scene that has 2 correct looking polygons this should not trigger either.

I looked at your CSharp script and you are creating a new navigation map with the NavigationServer API in an async function without updating the cell_size for this newly created navigation map.
New navigation maps created with the server API are "neutral" between 2D and 3D. New maps are init with a cell_size of 0.25. You need to update the cell_size of a new map once so it matches your 2D pixel cell size else you will likely trigger those errors.

Thanks @smix8. Forcing the newly created map to int 1 instead of float resolves the cell_size error. I am still seeing the empty path and the navmesh merge error with C# version.

I took a quick look at the MRP. When you set the transform for the region, in GDScript you are using Transform2D() and in C# you are using new Transform2D(). These are not equivalent, GDScript's constructor creates an identity transform, but in C# it creates a zero transform. If you want the identity transform in C#, use Transform2D.Identity.
Please, read the  C# API differences to GDScript documentation page to find out about all the differences that you need to know when translating code between GDScript and C#.

Made the Transform2D.Identity update and that resolved the console error, but the map path is still empty.

Uploading a simplified version of the MRP that corrects the above listed issues. This one has no errors but MapGetPath still returns an empty path.
navserver-path-issue-2.zip

The NavigationServer2D.map_get_path() function returns a PackedVector2Array instead of a normal Array.
According to docs C# needs to handle those PackedArrays differently. Maybe that is the source of the issue.
https://docs.godotengine.org/en/latest/tutorials/scripting/c_sharp/c_sharp_collections.html#godot-collections

Yes, for Packed*Arrays, we use normal C# arrays in the C# API. This means that NavigationServer2D.MapGetPath returns a Vector2[].
In your MRP you are printing the Vector2[] directly, but C# arrays don't implement ToString so it's only printing the type name, that doesn't mean the array is empty though. If you convert the array to Variant before printing it, it will use the Variant.ToString implementation which will actually print the contents of the array:
var path = NavigationServer2D.MapGetPath(NavigationAgent.GetNavigationMap(), startPosition, endPosition, optimize: true);
GD.Print((Variant)path);

Confirming that is the issue and it is indeed working as expected @raulsntos @smix8. Will close the issue; thanks for helping with this.


Archive support

Hello,
Sometimes I regroup images into an archive file (ZIP/CBZ, RAR/CBR, TAR/CBT, 7z/CB7)
Can you add some archive support ?

That's a bit different from how I intended to use fussel myself. Do you envision the python code unpacking the images at the time? If you have a good use-case and can figure out a way that might work feel free to submit a PR for it. However it does seem like a situation where we might support a "preprocesses" hook and let people writ their own scripts that might do something like unpack to a folder and rearrange things for their needs.


docs: add simple design guidelines section

Oh this is awesome, love it, thank you for documenting this!


fix: Loading == true ignored when Items == null in DataGrid

🐛 Bug Report
items == null overrides loading == true, such that No data to show! is displayed instead of Loading..
prior to the IEnumerable having data.
💻 Repro or Code Sample
@rendermode @(new InteractiveAutoRenderMode(prerender: true))

		<FluentDataGrid Items="MyData?.AsQueryable()" Loading="@(MyData is null)">
			...
		</FluentDataGrid>

@code {

	[Parameter] public IEnumerable<MyEntity>? MyData { get; set; }
}

🤔 Expected Behavior
Collections are either null, empty, or full. I would expect the most common state where loading should display is when the data is null, during data loading. If it comes back empty that is when "No data" takes effect. Or in any case, Loading == true should display loading regardless of anything else.
😯 Current Behavior
When Items is empty, Loading == true takes effect and displays properly.
<FluentDataGrid Items="(RecentTreasuries ?? []).AsQueryable()" Loading="@(MyData is null)">
    ...
</FluentDataGrid>

💁 Possible Solution
Give precedence to Loading == true
🔦 Context
Just unexpected, and I guess I could throw that empty list in there but seems better the other way, just using the null parameter as is.
🌍 Your Environment

OS & Device: Windows 11
Browser Microsoft Edge
.NET 9 Preview, Fluent UI Blazor 4.10.1

I can confirm this as well. Our web app stopped displaying loading when upgrading to 4.10.1. Downgrading to 4.10.0 will result in the expected behavior.

I can confirm this as well. Our web app stopped displaying loading when upgrading to 4.10.1. Downgrading to 4.10.0 will result in the expected behavior.

I've been looking at the changes and I can't see/find where that change would have been made. Can you get as a reproducible example of this?

I can confirm this as well. Our web app stopped displaying loading when upgrading to 4.10.1. Downgrading to 4.10.0 will result in the expected behavior.

I've been looking at the changes and I can't see/find where that change would have been made. Can you get as a reproducible example of this?

Sure!
I made two commits for each version. In 4.10.1 you won't see any "loading" at all while in 4.10.0 "loading" is displayed until you  press the button.
https://github.com/Thoronion/FluentUISandbox

Ok, Tested your repo (thanks) against what I have in a PR I'm working on to fix this and can confirm your example is showing the 4.10.0 behavior with those changes!

Ok, Tested your repo (thanks) against what I have in a PR I'm working on (#2739) to fix this and can confirm your example is showing the 4.10.0 behavior with those changes!

That is great :)


refactor: use a decorator for connection initiation

@larkee, as you proposed once, adding a decorator to deal with Engine and initiate a connection.


Change tables to show the total number of rows

Change the pagination to include the row count e.g. https://www.material-react-table.com/docs/guides/pagination#remote-demo

Show the Total number of filtered rows and the Total amount of rows @MatteoGuarnaccia5


Bungee support

Add bungee cord support

What would this look like to you? Hurricane is pretty dependent on being installed on the server.

What would this look like to you? Hurricane is pretty dependent on being installed on the backend server.

The geyseeextra plugin support it really well, why not add a proxy-mode

They're not comparable. Hurricane needs direct server access as it modifies aspects of the spigot/paper server directly, which is not possible to do on a proxy.
Do note that you can still use Hurricane even if Geyser is on a proxy or if you're using Geyser-Standalone - you'll just need to set up floodgate forwarding.

What would this look like to you? Hurricane is pretty dependent on being installed on the backend server.

The geyseeextra plugin support it really well, why not add a proxy-mode

The reason why GeyserExtras can have a proxy mode is because the data being transferred over to the backend is quite literally only the emote ids which doesn't require any server modification.
It would not make sense for Hurricane to have a proxy-mode as if you install Hurricane on your backend server, no further changes are needed on your proxy (afaik)

Thanks for the issue anyway! Just installing Hurricane on your backend server with Floodgate (plus key forwarding set up correctly) should suffice.

Why not add a thing that supports hunger by like telling people that hurricane does not work on bungee! [error]
hurricane disabled
the plugin hurricane disables

BungeeCord should already warn you if you try to load a spigot plugin on BungeeCord

A big red warning btw and some users don’t “read” it

If users don't read Bungee's warning, they also won't read hurricane's :p


Ensure pad_argument_buffer_resources is set to false

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add rotation to players

At the moment, both players are just boxes standing straight up, not taking account to the rotation generated by the physics engine.

Done in #74


remove duplicate chromedriver check

There were two checks for a local chromedriver. The first was not presenting the fancy error. Removing it allows the second check to do so. It will now look something like:
Preparing chrome...

/home/smassa/source/testium/lib/cli/console.js:112
      throw error;
            ^
Could not find required files for running selenium.
       - message: ENOENT, stat '/home/smassa/source/testium/bin/chromedriver'

You can provide your own version of selenium via ~/.testiumrc:

\```
[selenium]
jar = /path/to/selenium.jar
; For running tests in chrome:
chromedriver = /path/to/chromedriver
\```

testium can also download these files for you,
just execute the following before running your test suite:

$ ./node_modules/.bin/testium --download-selenium

testium will download selenium and chromedriver into this directory:
/home/smassa/source/testium/bin
Error: ENOENT, stat '/home/smassa/source/testium/bin/chromedriver'

(ignore the faux-escaped triple-`)

Addresses: https://github.com/groupon-testium/testium/issues/133

LGTM

published in 2.6.0


Follow up grant Overflow

Overflow
Grant category

Open source maintenance

Description
This is a follow up grant 4 for  https://github.com/onflow/developer-grants/issues/12, https://github.com/onflow/developer-grants/issues/87, https://github.com/onflow/developer-grants/issues/136 and https://github.com/onflow/developer-grants/issues/172
Continued supported.
The initial grants saw a lot of value and the follow up grant continued to give value. Overflow can already enable users to test secure-cadence and give feedback to dapper. Overflow also helped prevent an error in the recent test spork simply by keeping it up to date and alive and running an extensive test suite on the new version of flow.
I would like to ask for a monthly fee to keep overflow afloat for another 6 month period for 10.000 a month for 6 additional months.
Milestones and funding

maintenance
keep a stable-cadence toolchain up to date to test stable cadence

Milestone
Deliverables
Timeline
Risks
USD proposal

1 - Continued support
Support
Every month
I do not want overflow to grow unstable and want to be able to help its users. Each month for 6 months
10000

Team

Name
Role
Bio
Contact

Bjarte Karlsen
Code-monkey
I sling code and have fun and help some people too
<EMAIL_ADDRESS>

I was asked to set the period to 6months in the previous grant but if you want that can be adjusted.

For clarity the previous grant is valid until end of october.

@bjartek Hello! Nice to meet you! Do you still need someone to do this?

@chimpytuts i dont follow, this is me applying for a grant, not me creating a grant for others to apply to.

demo urls

https://asciinema.org/a/HRSwjTL1f0yk0KGXxt86D6ct9

https://github.com/bjartek/stable-cadence/blob/give-admin-direct-cap/main.go

New features that are already part of the stable-cadence branch

get the entitlements of different authorizers in the result object of a transaction.

We appreciate your proposal. After careful review we've decided not to proceed at this time. Please stay connected to our Twitter and working groups to stay on top of the latest developments in the ecosystem and new grant opportunities.


Vae loss negative

I'm running the vae and vae_deconv (in keras examples) with the loss function as provided (no changes done to code logic, but different data). However, I sometimes get both training and validation loss to be negative, which means the variable kl_loss is negative. As I understand, we are minimizing log (p(x))-D_kl(p(x)||q(x)), we know the D_kl is non-negative, it means D_kl(p(x)||q(x))> log(p(x)), or the information in p(x) is less than the distance between the  two distributions. Is this statement correct? I'm basically trying to understand what the function vae_loss is exactly computing, and why it would be negative.

I also get negative loss sometimes.


Fix JSON encode/decode for demo frontend

The lendex-frontend branch contains a WIP demo frontend.
Currently the contract definitions are being fetched when the app is launched, however, the JSON encoding is failing with the following error in the console:
Uncaught Error: GET request to http://localhost:8081/http://localhost:8080/api/new/contract/definitions failed: : (Named "Array" (AtIndex 1 (AtKey "csrSchemas" (Named "Array" (AtIndex 0 (AtKey "argument" (Named "FormSchemaUnsupported" (AtKey "tag" (UnexpectedValue "FormSchemaObject")))))))))
    at Object.exports.error (foreign.js:8)
    at Object.$$throw [as throw] (index.js:19)
    at index.js:16
    at index.js:30
    at index.js:64
    at _run (foreign.js:278)
    at foreign.js:348
    at drain (foreign.js:120)
    at Object.enqueue (foreign.js:141)
    at foreign.js:339

The relevant types are:

ContractSignatureResponse
FunctionSchema
EndpointDescription
FormSchema

Below is a JSON response sample from http://localhost:8080/api/new/contract/definitions :
{
  "csrDefinition": "User",
  "csrSchemas": [
    {
      "endpointDescription": {
        "getEndpointDescription": "borrow"
      },
      "argument": {
        "tag": "FormSchemaObject",
        "contents": [
          [
            "borrow'amount",
            {
              "tag": "FormSchemaInteger"
            }
          ]
        ]
      }
    }
  ]
}

The FormSchema type below corresponds to the "argument" property of the JSON and was copied from the plutus repo (playground-common/src/Schema.hs):
data FormSchema
  = FormSchemaUnit
  | FormSchemaBool
  | FormSchemaInt
  | FormSchemaInteger
  | FormSchemaString
  | FormSchemaHex
  -- ^ A string that may only contain @0-9a-fA-F@
  | FormSchemaArray FormSchema
  | FormSchemaMaybe FormSchema
  | FormSchemaRadio (Array String)
  -- ^ A radio button with a list of labels.
  | FormSchemaTuple FormSchema FormSchema
  | FormSchemaObject (Array (Tuple String FormSchema))
  -- Blessed types that get their own special UI widget.
  | FormSchemaValue
  | FormSchemaSlotRange
  -- Exceptions.
  | FormSchemaUnsupported String

As you can see, the FormSchema doesn't exactly match the JSON format (specifically the "tag" property in the JSON. For this reason the genericEncodeJson / genericDecodeJson strategy currently being used is failing and will need to be modified so that the appropriate constructor is used based on the string contained in the "tag" field.

this is fixed by https://github.com/mlabs-haskell/plutus-use-cases/pull/50
However the conditions of the fix have us holding some technical debt - for some reason it points to an issue with the Eq instance for String, this is too-depended-on to fail and in fact is itself a reference back to ffi over js === , which was exactly our fix.   rather puzzling.
the maintainer of aeson-generic requested that we drop in a minimal repro (which should work with try-purescript.org)

Additional fix has been applied for this issue: 09dd7649ba816545f3afdfc218fdc22ac7ff3b9e
It turns out the previous fix was causing all FormSchema properties to incorrectly decode to FormSchemaUnit. I've reverted the inclusion of the forked argonaut-generic.
In addition, I've  changed the unwrapSingleArguments encoding option from false to true. At this point the decoding appears to be behaving as expected.


chore: removed eslint config

:tada: This PR is included in version 1.13.131 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Linux kind documentation fix

Linux Kind page in docs uses invalid topology definition as an example(missing nodes). Fixed it)

thanks! spot on!


Issue in iOS

Seem to have an issue on iOS since the most recent update... For some reason, when my users and clicking the Continue button to progress to upload the signature to my server, it is emptying the signature completely - I've even removed the "Clear signature" button so that this option isn't available and it is still doing the same thing... works fine on desktop though still...

I think i've figured out that this is down to the eventlistener on the window resize function, however the upload itself is not being carried out... it's as thought it's ignoring the var xhr = new XMLHttpRequest(); command... does anyone have a resolution for this at all?


Enables the content field of the preset.

Clear and concise description of the problem
I am trying to create a component library based on unocss. In the components of the library, I directly use atomic CSS. When I build, a CSS file is generated. I anticipate that some users, while using this component library, will also use unocss. In this case, some rules (like p-2, flex, etc.) will be introduced twice. I hope that for users using unocss, they don't need to import the built CSS, but instead allow unocss to scan the component library files in node_modules (usually a JS file). It seems possible through configuring content, but node_modules is hardcoded as an excluded area.
Currently, I have made a preset and hoped to use fs to read the text of JS files and then write it into content.inline in the preset. But I find that the content property seems to be ineffective in the preset.
Suggested solution
In summary, I am seeking a straightforward method to scan files in node_modules and preferably utilize it within a preset.
My current approach involves defining a preset as follows:
const preset: () => Preset<object> = () => () => {
  let file = ''
  try {
    file = fs.readFileSync('node_modules/xxx/dist/index.js', 'utf-8')
  }
  catch { }
  return {
    // some other configs
    content: {
      inline: [file],
    },
  }
}
export { preset }

However, this doesn't work. Although I can read the contents of file, unocss seems not to recognize the content field in the preset.
Alternative
I can specify the files to read in uno.config.ts and it works, but I find this method inelegant and prefer not to expose the file-reading logic to users.
import fs from 'node:fs'
import { defineConfig } from 'unocss'
import { myUILibPreset } from '@xxx/preset'

const file =<EMAIL_ADDRESS>'utf-8')

export default defineConfig({
  presets: [
    myUILibPreset (),
  ],
  content: {
    inline: [file],
  },
})

Instead, I want users to be able to do this:
import { defineConfig } from 'unocss'
import { myUILibPreset } from '@xxx/preset'

export default defineConfig({
  presets: [
    myUILibPreset (),
  ],
})

Additional context
Or perhaps there are other ways to accomplish this better?
Validations

[X] Read the Contributing Guidelines.
[X] Read the README.md of using the package.
[X] Already used the Interactive Docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Maybe you can try to first read package.json to find the source of the installation library, obtain node_modules at the same level, and implement this logic inside the plug-in yourself.


added required version to cmake dep [phab:D1156]

Created by craigbarber at 2016-11-17 17:42:38:
Added required version to cmake dependency in the getting started page.

shahms accepted this revision at 2016-11-17 17:43:44

craigbarber closed via commit 0f8db336fc63d66b4b16315e9553c661cd89c304 at 2016-11-17 17:52:24


Fix crash on systems with pointer authentication.  (Cherry pick of #41104)

hashStringForType() needed updating to deal with ExistentialType.
rdar://87717024

@swift-ci Please test


make Go handle LRO returning empty properly

A new method GetBigNothing is added to library.proto and corresponding
config to test this behavior.
Package naming also changed slightly:
Previously, if a proto file declare a go_package option with
package name, the name is used in imports.
If the proto file does not declare the name,
we infer the name from the package declaration and add "pb" to it.
Now, all proto files in googleapis has been updated with go_package,
following above rules will drop "pb" from the import name.
This is still correct but causes a large amount of useless diff.
The fix is to add the "pb" back.

I apologize for the large diff in baseline files.
@jba please jump to the Go baselines.

Current coverage is 81.32% (diff: 100%)

Merging #858 into master will decrease coverage by 0.93%

@@             master       #858   diff @@
==========================================
  Files           327        327
  Lines         12550       9576   -2974
  Methods           0          0
  Messages          0          0
  Branches       1644       1555     -89
==========================================
- Hits          10324       7788   -2536
+ Misses         1797       1362    -435
+ Partials        429        426      -3

Powered by Codecov. Last update a6cf59a...f927775

generator code LGTM

I just realized how unclear it is. Thank you for pointing out.


No exception traceback info for exceptions that occur in onCompletedEpoch

Symphony shows a really unhelpful traceback when an exception occurs in Controller.onCompletedEpoch (usually when an exception occurs in a FigureHandler or Protocol.completeEpoch).
Per Sam Cooler:

I'm doing work that involves a lot of debugging. But my errors keep coming up with file/line reference to the Controller.m, with traceback info lost:
Warning: DEBUG: Struct contents reference
from a non-struct array object.
Error using
symphonyui.core.Controller/process (line 284)
Struct contents reference from a non-struct
array object.
Error in symphonyui.core.Controller/run (line
249)
obj.process();

Fixed with 71c9b2c


How can I use it outside of class?

I can't use it in the update because when I use multiprocessing, the code gives an error.
class MySketch(Sketch):
  config_path = "C://Users//test//Desktop//test.json"

  def setup(self):
    self.frame_rate = 60
    self.mouse.color_mode('hsv')
    self.hue = 120

  def update(self):
    print("Test") # Not working
    pass

  def render(self):
    self.mouse.set_static((self.hue, 100, 100))

while True:
  print(1)
  sleep(1)

def visualmouse():
  from pychroma import Sketch
  a = 1
  class MySketch(Sketch):
    config_path = "C://Users//test//Desktop//test.json"

    def setup(self):
      self.frame_rate = 144
      self.mouse.color_mode('hsv')
      self.hue = 120

    def update(self):
      print(a)

    def render(self):
      self.mouse.set_static((self.hue, 100, 100))

Multiprocessing requires all code to be in a function, but then the code doesn't work:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "D:\TEST\lib\site-packages\pychroma\__init__.py", line 23, in no_controller
    raise SketchError('No sketches found')
pychroma.Sketch.SketchError: No sketches found

You should use a Controller inside the target function of your subprocess and set the Controller's flag
Controller.defined = True

in every other process that is not meant to have a sketch running.
I have created an example showcasing a way to use pychroma with multiprocessing. You can view that code here.
If you want to run the example, you can simply
git clone https://github.com/morswin22/pychroma-examples.git
cd pychroma-examples
python examples/multi.py

Does this resolves your issue?


Latest tag (v0.0.2) is from Dec 2020, what is the recommended way to point to a more recent "version" ?

Hello, thanks for pre-commit-packer!
This is not really a bug, but I was unsure where to file it.
I am using this repo in my .pre-commit-config.yaml as
- repo: https://github.com/cisagov/pre-commit-packer
  rev: "v0.0.2"

I noticed that the latest tag (v0.0.2) is from Dec 2020, while this repo has more recent activity.
Would it be possible to make a more recent tag, or do you have recommendations on how to follow a more recent "version" ?
thanks

@marco-m-pix4d Apologies for the lack of response. The activity since that tag has only been "housekeeping" with updates to our GitHub Actions workflows, the pre-commit configuration, etc., but no updates to the functionality of the hooks. Since I am actually pushing through some updates to this project now you should see a new release in the coming week.

Hello @mcdonnnj, thanks!

Closing


Multiple servers and livereload not working

I have two connect servers, but connect.reload() doesn't reload any. Is anyone else have this problem?

Me too!

Can you try again, there were some fixes that just win in for this?

Please re-open if you're still encountering the issue. PR's welcome.

Same problem here. I have two servers open at the same time, but connect.reload() works only for the second one

这里同样的问题。我有两个服务器同时打开，但是connect.reload（）仅适用于第二个服务器

I also encountered it, is there a solution?


En Passant Piece Bug

Describe the bug

CanEnPassant Throws an error when attempting to access the piece involved in the last move. The last move has not been
To Reproduce

Move Pawn
If applicable, post move log/sequence of moves that produces bug:

E4 E5
Expected behavior

no error pls
Possible Solutions

Maybe problem with movelog with cloned boards.
Screenshots

Desktop:

OS:

Additional context
Add any other context about the problem here.

movelog isn't being updated with piece change


HAWQ-160. Fixed "dispatcher encounter error" when cancel query

CHECK_FOR_INTERRUPTS() can not be called between  PG_TRY(); and  PG_CATCH();
because the cancel request ( by passing SIGINT for ProcessInterrupts() to call elog) will be caught by the PG_CATCH(); clause, and the error will be changed to others.
So we just move this line out.

The fix looks good to me. +1

good fix.


Fix failing Challenge exit tests

Tests assertion fails because childChain.getChallengeData() returned object has changed since v1.0

could this be the cause of https://github.com/omisego/omg-js/issues/89 ? or unrelated because this is the api change after v1.0

No, it's an unrelated api change


Unexpected value encountered for GetSummaryReportAsync

Hi there,
I did write a short program to fetch my summary report from Clockify.
As a SummaryReportRequest I am using this:
SummaryReportRequest summaryReportRequest = new()
{
    DateRangeStart = new DateTime(2022, 2, 7),
    DateRangeEnd = new DateTime(2022, 2, 13),
    SummaryFilter = new SummaryFilterDto()
    {
        Groups = new List<GroupType>()
        {
            GroupType.DATE,
            GroupType.TAG
        },
        SortColumn = SortColumnType.GROUP
    },
    ExportType = ExportType.JSON
};

var reportResponse = await clockifyClient.GetSummaryReportAsync(workspace.Id, summaryReportRequest);

The reportResponse is not successful and gives ErrorMessage: Unexpected character encountered while parsing value: [. Path 'groupOne[0].children[0]._id', line 1, position 185.
The error's position and the example might slightly differ, as I did not paste the exact JSON response (truncated it a bit).
When looking at the JSON response, I have something like this:
{
    "totals": [{
        "_id": "",
        "totalTime": 39784,
        "entriesCount": 45,
        "totalAmount": null
    }],
    "groupOne": [{
        "duration": 39784,
        "_id": "2022-02-07",
        "name": "2022-02-07",
        "children": [
	{
	    "duration": 24669,
	    "_id": ["61aa2fa49e0fb0338dac807b"],
	    "name": "Project A",
	    "nameLowerCase": "project a"
	}, {
	    "duration": 10940,
	    "_id": ["61aa2ff01799d3570fc4ab44"],
	    "name": "Project B",
	    "nameLowerCase": "project B"
	}, {
	    "duration": 1184,
	    "_id": ["61aa31531799d3570fc4c648"],
	    "name": "Internal meeting",
	    "nameLowerCase": "internal meeting"
	}, {
	    "duration": 2991,
	    "_id": ["61aa305d9e0fb0338dac8d05"],
	    "name": "Support tag",
	    "nameLowerCase": "support tag"
	}]
    }]
}

I believe it has something to do with Clockify.Net/Models/Reports/SummaryGroup.cs
In there the property Id is a string, and I believe in this case it shouldn't be.
As you can see in the JSON above, the _id fields in the groupOne array contain brackets around the IDs.
I am not sure whether it is always like that, hence logging this issue.
Apart from that, thanks for writing this nice wrapper!

Thanks I will look into that. Maybe Clockify changed their API

If you look into the summary report from Clockify's API, we can see that its response is without the brackets, so it could be related to the fact that I use GroupType.TAG in the SummaryReportRequest. As you can select multiple tags for a time entry, it might be that they return this as an array.
Would be nice if they always returned an array for the ID and not only if you specify TAG.

Fixed in 1.15.0. Thanks for pointing that out!


fix typo error

Removed typo error of beast with best.

@bhuwanupadhyay thank you for the PR :pray: , but its not a typo I meant beast :)


changed number input's bounds to an inclusive range

I was thinking about it and theres a lot of small changes I want aswell

@genusistimelord


Feature flair system + flair to wall feed

Adds flair to wall feed + a system to expand flairs.

It should be fine now.


Re-integrate physics stepper

As far as I know, the old stepper was not integrated in this version of the library.
The old one can be found here: https://github.com/distransient/nphysics-ecs-dumb/blob/master/src/systems/physics_stepper.rs
For a lot of games, including mine, multiple steps per frame is an essential feature.
Are we supposed to externally manage the stepping, or were you planning on having this feature included in the stepper system?

We could provide one, but in Amethyst, the physics dispatcher should be called on fixed_update.


Development

Current coverage is 89.01% (diff: 100%)

Merging #11 into master will increase coverage by 4.94%

@@             master        #11   diff @@
==========================================
  Files            23         23
  Lines           182        182
  Methods          65         65
  Messages          0          0
  Branches          8          8
==========================================
+ Hits            153        162     +9
+ Misses           29         20     -9
  Partials          0          0

Powered by Codecov. Last update 4e23a60...a786107


[WavLM] How can I get padding_mask and applying SpecAugment like masking

Hello, I'm trying to train ASR model with WavLM's modules.
For training task, I'm trying to make get_mask_from_lengths function for padding_mask like below.
There seems to be no error and the output seems to be normal.
I'm not sure if this is the right way to make padding_mask.
import torch, time, random
from model.WavLM import WavLM, WavLMConfig
cfg = WavLMConfig()
model = WavLM(cfg)
model.eval()

def get_mask_from_lengths(lengths, max_len=None):
    with torch.no_grad():
        batch_size = lengths.shape[0]
        if max_len is None:
            max_len = torch.max(lengths).item()

        ids = torch.arange(0, max_len).unsqueeze(0).expand(batch_size, -1).to(lengths.device)
        mask = ids >= lengths.unsqueeze(1).expand(-1, max_len)

    return mask

# Generate Dummy Audio with random audio lengths
batch_size = 16
max_len = random.randint(1, 80000)
wav_input_16khz = torch.randn(batch_size , max_len)
wav_lens = torch.randint(1, max_len, (batch_size ,))

wav_lens = torch.div(wav_lens, 320, rounding_mode='floor')
padding_mask = get_mask_from_lengths(wav_lens, max_len // 320)

# padding_mask : torch.Tensor([batch_size, max_seq_len])

rep, _ = model.extract_features(wav_input_16khz, padding_mask=padding_mask , mask=True)

And If I want to apply SpecAugment for ASR training,
Can I use apply_mask function in WavLM model for applying SpecAugment by switching x[mask_indices] = self.mask_emb to x[mask_indices] = 0?
Any advice would be appreciated!

@LEECHOONGHO  Sorry for the late reply. Here are two ways to fine-tune WavLM on ASR, including the SUPERB approach and the wav2vec approach. Which one do you need.
For your second question, No we cannot change it to x[mask_indices] = 0, since it will hurt the model performance.


Supports v4 get repository files

@neodooth thanks for the PR! Two small questions...

Could you make sure the tests are also updated so they are passing?
Could you update the related endpoints as well so this PR fixes these as well:

Thanks!

Hi,
The test is updated now.
As for other endpoints it may take more time to update since actually I needed to use get files so I made this quick fix. If it's ok you can merge it for now in case I can't find enough time to update other endpoints.

Fair enough.. Thanks!


[TR-037] test for process execution via WMI (

When running simulate I generated 2 rows of data but the test failed when I set count = 2 and passed when count = 1 minor detail that I was hoping you could comment on @P4T12ICK

Hi Jo, this is one line of data, that's why count = 1 is correct. The header with the field names doesn't count. And it also doesn't matter if you already have a count > 1 before.


HttpClient: implement methods used by synthetic generation

This way, we can use developer-dir support in combination with
the new dialogue patch for almond

Pull Request Test Coverage Report for Build 314

4 of 27 (14.81%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.1%) to 79.648%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/http_client.js
4
27
14.81%

Totals

Change from base Build 312:
-1.1%

Covered Lines:
1259

Relevant Lines:
1517

💛  - Coveralls


aws stemcell - limited network connectivity due to network driver restarts

Symptoms:
On AWS on the affected VMs we observe problems with the network connectivity. Frequently the network connectivity is down, coming back up shortly after. This is probably related to a restart of the NIC as seen in the logs below. It is independent from the releases running on the managed bosh vm.
The problem will stay indefinitely. To solve it we delete the vm via bosh. We once rebooted a VM which also solved it.
Logs:
kern.log:
2019-07-22T11:01:55.096109+00:00 localhost kernel: [2008934.869922] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:06.108096+00:00 localhost kernel: [2008945.880952] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:11.992109+00:00 localhost kernel: [2008951.765109] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:21.972103+00:00 localhost kernel: [2008961.745862] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:32.216097+00:00 localhost kernel: [2008971.989764] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:42.964105+00:00 localhost kernel: [2008982.737861] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:53.208095+00:00 localhost kernel: [2008992.981733] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:02:59.100107+00:00 localhost kernel: [2008998.873855] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
2019-07-22T11:03:10.104101+00:00 localhost kernel: [2009009.877387] ixgbevf 0000:00:03.0: NIC Link is Up 10 Gbps
(...)

There are no correlating log entries in the agent or audit.log.
Impact
Network calls will occasionally not go through. Usually the VM will report as healthy as the occasional health check goes through. Jobs will still be reported as running. VMs that rely on frequent network communication like Diego cells are strongly affected.
As the problem will stay indefinitely we currently need to spot the instances and then use delete-vm to delete them manually.
Reproducibility
We see this issue only on large installations (>200 Instances).
We were able to reproduce it by creating a large deployments with 200 instances. Then we recreated instances until the problem occurred.
Further information
Because of this problem the network driver already has been updated but this didn't solve or improve the situation.
We communicated this with the AWS support. They suggested us to contact the AMI vendor and gave the following hint on debugging:
Regarding your set debug mode for ixgbevf driver question, I found the links below and want to share with you on a best effort basis.
You may try to enable the kernel debug or if the driver supports you may use msglvl flag with ethtool.
http://mails.dpdk.org/archives/dev/2017-September/076962.html
https://techedemic.com/2015/01/22/ubuntugrub2-verbose-booting/

The AWS support suggested to use the AWS kernel which includes the ixgbevf driver but our assumption that this is not possible on a stemcell.
cc @friegger @achawki

The AWS support suggested to use the AWS kernel which includes the ixgbevf driver..

Not sure I understand their support's ask, as we have the driver as well. As far as turning on debug, this is probably something that could be done on the VM by rebuilding the ixgbevf driver, on the running VM, with some flags on. Maybe we can both look into trying that (at least until we can figure out reproducing).
On a separate note, I'd like to hear more about your reproduction steps before we go off creating 200 instances.

Not sure I understand their support's ask, as we have the driver as well.

AWS would support us in troubleshooting only if we were using the AWS kernel. In case we are using the stemcell, which side loads the driver, we are more or less on our own.

As far as turning on debug, this is probably something that could be done on the VM by rebuilding the ixgbevf driver, on the running VM, with some flags on.

That sounds good.

On a separate note, I'd like to hear more about your reproduction steps before we go off creating 200 instances.

In the past we just recreated diego cells until they failed to start up because a pre-start script failed due to limited network access. We are going to provide a minimal reproduction scenario and come back to you once we have it.
cc @BeckerMax

I spoke with my pair today, @jaresty, about this issue. He brought up a super interesting theory.
On Xenial stemcells, the bosh-agent uses ifupdown to manage the network. This puts a lot of the responsibility of ensuring the network devices are configured correctly on the bosh-agent. The bosh-agent basically only performs these actions on process start. If the interface goes does, the agent does not recover.
This may explain why rebooting, or recreating the VM has been successful for you.
The fix probably involves moving to a network supervisor like NetworkManager, systemd-networkd, or netplan.
We have begun making this change, of moving from ifupdown -> systemd-networkd, in the next xenial & bionic lines.
What do you think?

We tried to reproduce the issue with following script. It can be any bosh deployment. For simplicity we took https://github.com/cppforlife/zookeeper-release
#!/bin/bash

set -euo pipefail

while true; do
  OUTPUT="$(bosh -e bosh -d zookeeper ssh zookeeper -c 'sudo su -c "occurrences=\$(cat /var/log/kern.log | grep \"NIC Link is Up\" | wc -l); if [ \$occurrences -gt 4 ];then echo ISSUE FOUND on \$(< /var/vcap/instance/name).\$(< /var/vcap/instance/id); fi;"')"
  if grep "ISSUE FOUND" <<<"$OUTPUT";then
    exit 1
  fi
  echo "Recreating zookeeper instance group"
  bosh -e bosh -d zookeeper recreate zookeeper -n
  sleep 300 # sleep after recreate so the potential problem can be seen in the logs
done

We tried it with a deployment size of 50 and max_in_flight also set to 50. The script ran for multiple days on two different installations. So far we could unfortunately not reproduce the problem. We will continue trying to reproduce it.

I spoke with my pair today, @jaresty, about this issue. He brought up a super interesting theory.

Sounds interesting. An affected instance will not recover, but the problem is rather intermittent. Not all network connections fail. Bosh also considers the vm as healthy. When I understand the theory correctly, no network connectivity at all should be possible in this situation?

We still see this issue regularly on all regions on AWS. It seems to randomly hit a VM independent of what is deployed on that VM, roughly 1/1000 VMs. If no monitoring is in place it might go unnoticed until the VM is recreated the next time, but it can have severe impact as described above. We really wonder why there are not reports from others.
Meanwhile we have better monitoring in place and are able to catch affected instances before they are recreated. We then can bosh ignore that instance.
Recent contact with AWS support have again resulted in pointing out that they can only provide limited support since the stemcell is a custom image. Rebooting the VM usually helps. Affected instances are affected right after hey have booted. So we assume the issue occurs during boot somewhere between VM start and the agent finishing up everything.
For context, this issue is with us since 2017, already with trusty stemcells. Meantime the driver has been updated a few times, we have switch to xenial, but the issue persists.
@mrosecrance Is there still someone available on your side with deeper stemcell knowledge that we could pair with looking into an affected VM?

The change mentioned by Aakash above (ifupdown -> systemd-networkd) is only in the 621 line. Is the issue still popping up? It's possible that there's more checking that needs to be done on startup.
At the moment we don't have anyone with deep stemcell knowledge but it's context we'll need to gain anyway so open to pairing on this issue.

we still see the issue happening on a low percentage of AWS VMs.
we verified on an instance showing the issue that
systemctl restart systemd-networkd

does not help
also, reboot of the instance does not help. we even downloaded, compiled the kernel module to 4.7.1 from https://sourceforge.net/projects/e1000/files/ixgbevf stable/ , then loaed it using modprobe, did not help either

Did another test with updating the driver:
bosh -e <env> -d <deployment> scp ixgbevf-4.8.1.tar.gz <instance>:/tmp/.
cd /tmp
mkdir /usr/src/ixgbevf-4.8.1
tar -xzf ixgbevf-4.8.1.tar.gz -C /usr/src/ixgbevf-4.8.1 --strip-components=1
# copy content from https://raw.githubusercontent.com/cloudfoundry/bosh-linux-stemcell-builder/master/stemcell_builder/stages/system_ixgbevf/assets/usr/src/ixgbevf-4.6.1/dkms.conf to /usr/src/ixgbevf-4.8.1/dkms.conf and adjust version
dkms -k 4.15.0-112-generic add -m ixgbevf -v 4.8.1
dkms -k 4.15.0-112-generic build -m ixgbevf -v 4.8.1
dkms -k 4.15.0-112-generic install -m ixgbevf -v 4.8.1
modinfo ixgbevf #-> new version
rmmod ixgbevf && modprobe ixgbevf
ethtool -i eth0 #-> new version

The issue persisted.
A reboot with sudo systemctl reboot fixed the issue on that specific instance.
Another remark. The ixgbevf driver is only used on non-nitro instances. On nitro instances the ena driver is used. Currently we mostly use non-nitro-based instances. Thus, we don't know whether the problem exists on nitro instances.

We investigated this issue further and have the following findings:

the issue happens on AWS with instance types (e.g. m4.large or m4.xlarge...), which use the ixgbevf driver by default.
the custom Intel driver ixgbevf is using two queue pairs (RX, TX) by default.
the kernel module driver ixgbevf for Xenial and Bionic is using a single queue pair by default.

The AWS is using DPDK (https://dpdk.readthedocs.io/en/v17.11/nics/intel_vf.html) on the host system, which supports one queue pair only. This has been confirmed by AWS support. This is to root cause of the initial problem, because the second transmit queue is timing out, which triggers a restart of the NIC driver. Using the latest bionic stemcell with the kernel module driver we couldn't find any issues. We recommend here to use the kernel module driver in bionic to solve this problem.

@dlresende Would you also consider a fix for Xenial? It's a bug, on the other hand is end of live approaching.

I did another test trying to disable the multi queue feature during build process:
I changed the following line in file /usr/src/ixgbevf-4.6.1/dkms.conf
MAKE="cd src/; make BUILD_KERNEL=${kernelver}"

to
MAKE="cd src/; make BUILD_KERNEL=${kernelver} KBUILD_CFLAGS_MODULE=-DIXGBEVF_MAX_RSS_QUEUES=1"

and rebuild the driver
dkms remove -k $(uname -r) -m ixgbevf -v 4.6.1 && dkms add -k $(uname -r) -m ixgbevf -v 4.6.1 && dkms install -k $(uname -r)  -m ixgbevf -v 4.6.1

Interestingly the change matches the kernel module driver ixgbevf version 4.1.0k.
DKMS: build completed.

ixgbevf.ko:
Running module version sanity check.

Good news! Module version 4.1.0-k for ixgbevf.ko
exactly matches what is already found in kernel 4.15.0-123-generic.
DKMS will not replace this module.
You may override by specifying --force.

While using the mentioned --force parameter in the command dkms install --force ... will work, replacing the compiled module by using rmmod ixgbevf && modprobe ixgbevf leads to an unresponsive vm.
A redefinition of IXGBEVF_MAX_RSS_QUEUES to 1 inside the source code works as expected.

@mrosecrance Given that DKMS states that the configuration would be identical to the kernel version the easiest solution might be to just remove the custom Intel driver. What do you think?

After some digging it looks like we initially moved to a custom intel driver as part of this pr and from the aws docs it looks to just affect m4 instances + a few others.
Since we're well beyond the version that caused us to move forward for sriov_net_support it seems pretty safe to rip out.
On a related note, if enhanced networking on newer instance types is a desired feature we can look into ENA support later.

Thanks @mrosecrance! Do I understand it correctly, that you would bring in a PR that removes the custom driver then?
Regarding ENA support, on Nitro based instances the kernel ENA driver is already used and seems to work fine.

@mrosecrance  Any update on this issue? We are heavily impacted by this problem and would be interested to understand the plan forward with this issue. Will you provide a fix for the xenial stemcell? Is the issue already fixed in the bionic stemcell?

@mrosecrance  Any update on this issue? We are heavily impacted by this problem and would be interested to understand the plan forward with this issue. Will you provide a fix for the xenial stemcell? Is the issue already fixed in the bionic stemcell?

Xenial is going out of general support in April so I don't think it makes sense to backport for only the last 3-4 stemcell patches. I haven't seen a PR for a fix yet for Bionic.

Xenial is going out of general support in April so I don't think it makes sense to backport for only the last 3-4 stemcell patches. I haven't seen a PR for a fix yet for Bionic.

The custom intel driver has already been removed for bionic with https://github.com/cloudfoundry/bosh-linux-stemcell-builder/commit/fc0a38a419c3a57a664a8b6459330387bc6240c1.

The custom intel driver has already been removed for bionic with https://github.com/cloudfoundry/bosh-linux-stemcell-builder/commit/fc0a38a419c3a57a664a8b6459330387bc6240c1.

Closing since this is fixed with bionic stemcells.


[BugFix] Fix SenderQueue may leak closure

This bug is Introduced by https://github.com/StarRocks/starrocks/pull/33641
Why I'm doing:
the last chunks may hold the closure for rpc. direct return may cause leak closure when _is_cancelled is true
What I'm doing:
port clean_buffer_queues to outer loops
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

#35380


Rounding dates within date histogram

We were using nice() d3 function, which rounds values. Turns out it was rounding our dates to the end of the year, and x-axis labels and torque selections appeared wrong.
In short, nice function, not nice :dancer:.
CR: @alonsogarciapablo
Fixes #302.

Also fixed a problem with fake placeholders:

cc @piensaenpixel

:+1:


feat: support X-Upload-Content-Length header

This fixes #3162.
Unfortunately, there does not seem to be a way to set the counterpart of
this header for gRPC version, so only cURL is supported.
Emulator is updated to support this too.

This change is

Hm... Did you look into the clang-tidy error?


Fix comment handling

Of course, comments other than "comment offset:" should not be considered invalid. Apologies about the bug.

ptal @feuerste

@wally-the-cartographer merge

@wally-the-cartographer merge

Merge requested by authorized user feuerste. Merge queue now has a length of 1.

@SirVer could we do something about making Wally listen to me?


CognitoAuth.getCurrentUser returns undefined in the Implicit grant flow

I am integrating Amazon Cognito with a SAML identity provider which is also the sole identity provider of my app. I am using both Authorization code grant and Implicit grant flows. The allowed OAuth scopes are: aws.cognito.signin.user.admin, openid, profile, and email.
I am also retrieving the current user by calling the getCurrentUser method inside the onSuccess block of the userhandler property. While the getCurrentUser method returns the current username in the Authorization code grant flow, it returns undefined in the Implicit grant flow.
Is this a known issue?

Hi @dnguyen219, we noticed this issue. I will push the fix very soon!   Thanks!

Hi @dnguyen219, we have published the fix. Please use v1.1.5 and try!


Failed to submit proof   blockID=184,824 tier=200 txHash=45c11b..da39a4 error=

Describe the bug
I can see my prover try to prove 19 blocks proof but failed 4 blocks with same errs
taiko_client_prover_relayer-1  | ERROR[05-21|12:43:04.011] Failed to submit proof                   blockID=184,824 tier=200 txHash=45c11b..da39a4 error=<nil>
taiko_client_prover_relayer-1  | ERROR[05-21|12:43:05.162] Failed to submit proof                   blockID=184,827 tier=200 txHash=135cbf..94ddde error=<nil>
taiko_client_prover_relayer-1  | ERROR[05-21|12:43:05.289] Failed to submit proof                   blockID=184,826 tier=200 txHash=71eab4..78b8bd error=<nil>
taiko_client_prover_relayer-1  | ERROR[05-21|12:43:06.333] Failed to submit proof                   blockID=184,823 tier=200 txHash=94e5c7..e393d7 error=<nil>

I can see successful 16 prove transactions succcessful only. mean 3 blocks got slashed with weird issue

Steps to reproduce
Steps to reproduce here.
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

is it different error from
https://github.com/taikoxyz/simple-taiko-node/issues/241#issuecomment-2103696265 ?

https://github.com/taikoxyz/simple-taiko-node/issues/241

Yes it's the same but actually it does not retry resubmit.. I can see proven transaction count is not matched with total transferred tokens

I also getting weird err today.

taiko_client_prover_relayer-1  | ERROR[05-22|17:08:39.108] Failed to request proof                  height=192,636 error="Can not serialize input for SGX io error: Broken pipe (os error 32), output is Ok(Output { status: ExitStatus(unix_wait_status(256)), stdout: \"Starting one shot mode\\nGlobal options: GlobalOpts { secrets_dir: \\\"/root/.config/raiko/secrets\\\", config_dir: \\\"/root/.config/raiko/config\\\" }, OneShot options: OneShotArgs { sgx_instance_id: 3603 }\\nmemory allocation of 32 bytes failed\\n\", stderr: \"Gramine is starting. Parsing TOML manifest file, this may take some time...\\n-----------------------------------------------------------------------------------------------------------------------\\nGramine detected the following insecure configurations:\\n\\n  - loader.insecure__use_cmdline_argv = true   (forwarding command-line args from untrusted host to the app)\\n  - sys.insecure__allow_eventfd = true         (host-based eventfd is enabled)\\n  - sgx.allowed_files = [ ... ]                (some files are passed through from untrusted host without verification)\\n\\nGramine will continue application execution, but this configuration must not be used in production!\\n-----------------------------------------------------------------------------------------------------------------------\\n\\n[P1:T4:sgx-guest] error: Out-of-memory in library OS\\n\" })" endpoint=http://xx.xx.xx.xx:8080

Hello do we have update on this err ?
I'm getting same err on mainnet today with failed tx :

failed prove tx :
https://etherscan.io/tx/0xf06ea3cf22c35c7ea909ddcf8f73ff031cf5e02b3260eafa307af375809e10bf

taiko_client_prover_relayer-1  | ERROR[05-22|17:08:39.108] Failed to request proof                  height=192,636 error="Can not serialize input for SGX io error: Broken pipe (os error 32), output is Ok(Output { status: ExitStatus(unix_wait_status(256)), stdout: "Starting one shot mode\nGlobal options: GlobalOpts { secrets_dir: \"/root/.config/raiko/secrets\", config_dir: \"/root/.config/raiko/config\" }, OneShot options: OneShotArgs { sgx_instance_id: 3603 }\nmemory allocation of 32 bytes failed\n", stderr: "Gramine is starting. Parsing TOML manifest file, this may take some time...
\n-----------------------------------------------------------------------------------------------------------------------\nGramine detected the following insecure configurations:\n\n  - loader.insecure__use_cmdline_argv = true   (forwarding command-line args from untrusted host to the app)\n  - sys.insecure__allow_eventfd = true         (host-based eventfd is enabled)\n  - sgx.allowed_files = [ ... ]                (some files are passed through from untrusted host without verification)\n\nGramine will continue application execution, but this configuration must not be used in production!\n
-----------------------------------------------------------------------------------------------------------------------\n\n[P1:T4:sgx-guest] error: Out-of-memory in library OS\n" })" endpoint=http://xx.xx.xx.xx:8080

Never see before in our side, but some others mentioned that.
Error is still the libos out-of-memory, switch to bigger instance helps I guess..
BTW: you setup the mainnet? cool! 👍

@smtmfft Yes i think maybe that is an issue with memory with err code  error: Out-of-memory in library OS but actually it's different err with https://github.com/taikoxyz/simple-taiko-node/issues/264#issuecomment-2156037482.
Also my prover has 128G RAM and still free more than 64G ram. Not sure if that is issue with memory on Raiko host but actually that's log from prover side and no issue after generating proof on Raiko node..
That is old issue actually I have not got that err with new ver.
But this error still happening on mainnet :
. The issue is to submit proof after generating https://github.com/taikoxyz/simple-taiko-node/issues/264#issuecomment-2156037482

oh, so your proof is generated but failed to submit I saw you have 2 blocks, 44335 ok & 44330 fail. Can you see the tx in etherscan?? there was a issue in L1 gas evaluation, but with latest taiko-node should be fine.

Here is 2 failed tx :
https://etherscan.io/tx/0xf06ea3cf22c35c7ea909ddcf8f73ff031cf5e02b3260eafa307af375809e10bf
https://etherscan.io/tx/0x10253246c70a1f3bf54bd265fb49bca70d78b41751a524fd438ba8cbe62d9fef

yes, both are out of gas, you need to increase the gas limit.

Ref: https://discord.com/channels/984015101017346058/1152772683054981300/1250567442728484987

feel sad about that :(
Yes, I will talk with client guys for better error hint.
what's the new error tag?? I think the proof should be accepted if it's still in the active window.

yes, both are out of gas, you need to increase the gas limit.

Do we have a plan to update or fix this error?
The issue is can't public prove txt because run out of gas.. The team has removed the default value in .env for the gas limit there it's perilous for mainnet.

feel sad about that :( Yes, I will talk with client guys for better error hint.
what's the new error tag?? I think the proof should be accepted if it's still in the active window.

I changed to use my own beacon and the err is gone already.


relationMappings() function only checks validity of related tables and doesn't check validity of owner table

I have two objectionjs models, Meal and MealType that correspond to meal and meal_type tables respectively in the database. I defined a relationship as follows, where Meal is the owner model and MealType is the related model.
class Meal extends BaseModel {
    static get relationMappings() {
        return {
            mealType: {
                relation: BaseModel.BelongsToOneRelation,
                modelClass: require('./mealtype'),
                join: {
                    from: 'meal.mealTypeId',
                    to: 'mealType.id'
                }
            }
        };
    }
}

Now in the join object, if I misspell the name of the related table, or change a case, the error is caught while querying the model. For example, if I do to: 'mealtype.id', (notice the small t instead of T) I get the following error:
"Meal.relationMappings.mealType: join: either `from` or `to` must point to the owner model table and the other one to the related table. It might be that specified table 'mealtype' is not correct"
That's great, but if I misspell anything in the owner table, like if I write from: 'meal.MealTypeId', (notice the M instead of m) I don't get any kind of error. Just, during the Meal.query().withGraphFetched('mealType') query, the returned data of mealType is null.
I personally did a spelling mistake on the owner table's field-name and it took some time to understand where the problem was. So if possible, can we have some kind of validity checking on the owner table as well?
I am using objectionjs 3.0.1 and postgres 14.3. I am also using ...knexSnakeCaseMappers() in knexfile.js.

@TissuePowder it looks like only the table names are validated. Likely, that's all objection knows about (via tableName).
Have you verified that related columns are validated? I suspect they aren't and would require some kind of table introspection outside of Objection itself.


How to make torso move less

The rendered output has a lot more torso movement compared to the original driving video. Is there a way to lessen torso movement? or even constrain movement to just the head?
https://github.com/xg-chu/GPAvatar/assets/247795/2e3f1ba5-e353-4c05-af2f-f6d54c00e530

You can smooth the ‘expression’ in the processed driving data to achieve this goal. If you fix the expression, there will be only head movements.


Added Swift 4.2 support

Since Xcode 10 is now out of Beta and Apple allows apps to be submitted to the AppStore I think this is an important update so please review my changes and approve it if it feels ok.

thanks


Bug in sciplex3 preprocessing?

Hi there,
I've been trying to reproduce the training on sciplex but I get this error with a brand new clone, datasets and conda env:
$ python -m compert.train --dataset_path datasets/sciplex3_new.h5ad       --save_dir /tmp --max_epochs 1  --doser_type sigm

Traceback (most recent call last):
  File "/home/kcvc236/miniconda3/envs/CPAvanilla/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/kcvc236/miniconda3/envs/CPAvanilla/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/kcvc236/CPAvanilla/CPA/compert/train.py", line 303, in <module>
    train_compert(parse_arguments())
  File "/home/kcvc236/CPAvanilla/CPA/compert/train.py", line 197, in train_compert
    autoencoder, datasets = prepare_compert(args)
  File "/home/kcvc236/CPAvanilla/CPA/compert/train.py", line 167, in prepare_compert
    datasets = load_dataset_splits(
  File "/home/kcvc236/CPAvanilla/CPA/compert/data.py", line 189, in load_dataset_splits
    "training": dataset.subset("train", "all"),
  File "/home/kcvc236/CPAvanilla/CPA/compert/data.py", line 129, in subset
    return SubDataset(self, idx)
  File "/home/kcvc236/CPAvanilla/CPA/compert/data.py", line 161, in __init__
    self.ctrl_name = dataset.ctrl_name[0]
IndexError: list index out of range

I have strong suspicion that there is a problem in the preprocessing of sciplex:
https://github.com/facebookresearch/CPA/blob/main/preprocessing/sciplex3.ipynb
The cell #6 is probably causing the troubles by making it impossible for adata.obs.control to be anything else than 0. Hence the error above.
Do you have a working version or fix you could share for this please?
Cheers

I concur. sciplex3_new.h5ad which is created by processing sciplex_raw_chunk_{i}.h5ad does not have the value "Vehicle_1.0" in adata.obs.drug_dose_name.values at all, and therefore, there are no cells with adata.obs['control'] = 1. Without the control samples, the training crashes.
What is the solution? use some other drug_dose_name value as the control?

I think should be control_1.0


Update .gitignore file

You have included all your changes in this PR, so you do not need any other PRs. They can be closed.


refactor filter by rows

refactor filter by rows

tests do not pass

tests do not pass

I changed patterns and I think it's better than its old pull request
please don't be hesitate if its need more changes

are you finished?


Remove VNC/X11 requirement

The latest speculos versions allows getting screenshots directly from the new REST endpoint

At the moment, Zemu uses VNC to grab screenshots. This was the original way that speculos exposed them.
Since a few weeks speculos finally opens a REST API that can be used to retrieve the images directly without UI.
https://github.com/LedgerHQ/speculos/blob/master/docs/user/api.md
The new API means that we could stop using VNC everywhere and retrieve screenshots directly.
Remove VNC dependencies everywhere and replace:

[ ] screenshot taking with the new REST API
[ ] button clicking with the new REST API
[ ] expose events to the Zemu JS library

Other documentation:

https://github.com/LedgerHQ/speculos/tree/master/docs/dev
https://github.com/LedgerHQ/speculos/tree/master/docs/user

Created another specific issue for events and closing this


Typo Update in README.md

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I want to know what https://github.com/aws/aperf/pull/230 is about. My paranoid suspicion is that it was a test to see if a subsequent PR would get CI/CD'ed without approval being required.

Closing as this user appears to be illegitimate.


Editing slider axis label does not update dimension name in widget

This is a core napari bug: https://github.com/napari/napari/issues/5630
Once that is fixed, this should be fixed too.


libxnd, libndtypes: refactor add support for darwin

Motivation for this change
Prior build instructions were hacks because I did not understand that the configure script was choosing ld as the linker instead of using gcc to properly link. This commit fixes these issues and simplifies the build.
Things done
libxnd: refactor
libndtypes: refactor
Please ensure that this build works on darwin.

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

For some reason the configure script by default chooses ld as the linker. This causes errors because the Makefile assumes that gcc or clang is used for the linker. Is there a more elegant way to do this?

Yes that's very normal, gcc and clang are not linkers. Could you explain or post the error?

I am aware that gcc and clang are not linkers (they are wrappers around preprocessing, compiling, and linking). From what I know they can be used as linkers and call ld with appropriate arguments. Here is the error if I do not manually set cc as the linker.
gcc -I.. -Wall -Wextra -std=c11 -pedantic -O2 -g -fPIC -c seq.c -o .objs/seq.o
gcc -I.. -Wall -Wextra -std=c11 -pedantic -O2 -g -fPIC -c symtable.c -o .objs/symtable.o
gcc -I.. -Wall -Wextra -std=c11 -pedantic -O2 -g -fPIC -c util.c -o .objs/util.o
gcc -I.. -Wall -Wextra -std=c11 -pedantic -O2 -g -fPIC -c values.c -o .objs/values.o
ld -shared -Wl,-soname,libndtypes.so.0 -o libndtypes.so.0.2.0dev3 .objs/alloc.o .objs/attr.o .objs/context.o .objs/copy.o .objs/encodings.o .objs/equal.o .objs/grammar.o .objs/io.o .objs/lexer.o .objs/match.o .objs/ndtypes.o .objs/parsefuncs.o .objs/parser.o .objs/seq.o .objs/symtable.o .objs/util.o .objs/values.o compat/.objs/bpgrammar.o compat/.objs/bplexer.o compat/.objs/import.o
/nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/ld: unrecognized option '-Wl,-soname,libndtypes.so.0'
/nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/ld: use the --help option for usage information
make[1]: *** [Makefile:57: libndtypes.so.0.2.0dev3] Error 1
make[1]: Leaving directory '/build/source/libndtypes'
make: *** [Makefile:23: default] Error 2
builder for '/nix/store/5gplhcy8rxmiabvw43agnwpkflrvz29l-libndtypes-0.2.0dev3.drv' failed with exit code 2
error: build of '/nix/store/5gplhcy8rxmiabvw43agnwpkflrvz29l-libndtypes-0.2.0dev3.drv' failed

'-Wl,-soname,libndtypes.so.0' is a argument that is passed to gcc or clang that is appropriately passed to ld.

Ah I see, the build is passing compiler specific flags to ld like I thought. -Wl is a compiler flag to specify extra flags to pass to the linker. Could you rephrase the comment to avoid confusion.
That should be, so using LD=cc basically turns the incorrect usage into the first variant.
$CC -Wl,-soname,libndtypes.so.0 ...
# or
$LD -soname libndtypes.so.0 ...

Ok I have updated the pull request with a better comment for why cc was used as a linker. Its ready to merge.
I still am not convinced this is incorrect usage. While in this case using ld would have been simple enough. For some complex libraries this is not always the case. Take for example mpicc, mpif90 these are wrappers around gcc with linker and special compilation flags. So similarly using gcc for linking simplifies the process by not having to worry about the location of glibc, lm, ld-linux-x86-64.so.2, etc. Using -Wl,--verbose you can print all of the work done by gcc for linking.

I only have a vague understanding of this, somebody like @Ericson2314 can probably explain this better. But we explicitly set LD=ld in the stdenv which is probably what exposed the issue.

Yeah it is done for cross on other things to force configure scripts to use the right linker. But then some configure scripts are crazy and have defaults like LD ?= gcc for this. I've seen a CCLD environment variable instead, which is a much better way to use a C compiler for linking but also be independent ofCC. That is what upstream ought to use.

@costrouc I'd change "compiler to determine the linker" to "using a compiler to do the linking". The compiler will modify how you link things in subtle ways to pick up the C/C++ runtime things, etc.

Should be ready for a build now


New version: LCIO v1.9.1

Registering package: LCIO
Repository: https://github.com/jstrube/LCIO.jl
Created by: @jstrube
Version: v1.9.1
Commit: bb77e377b8402e43711e0a6c66e026dbe99e82e6
Reviewed by: @jstrube
Reference: https://github.com/jstrube/LCIO.jl/commit/bb77e377b8402e43711e0a6c66e026dbe99e82e6#commitcomment-47438817

needs update

@jstrube can this be merged now?
[noblock]

Yes, please.
[noblock]

Your own message was blocking it :slightly_smiling_face:
[noblock]


Fix InputObject typo

/azp run

@bergmeister nice spot - many thanks I will get this pushed out today


[Bug] [Module Name] Rest API：hazelcast/rest/maps/submit-job return an wrong jobId

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I send the post api as following parameter format，got the result：
{
"jobId":<PHONE_NUMBER>11253000,
"jobName": "event_test"
}
but I use terminal command $SEATUNNEL_HOME/bin/seatunnel.sh -l got another jobId：862969647010611201 ，and I confirmed the<PHONE_NUMBER>10611201 is correct because I can stop it by stop job rest api。
I restart the cluster master Server serveral times got the same error ,the bug seems like Issue 5421, but it closed for it still occur,so I n
SeaTunnel Version
2.3.5
SeaTunnel Config
seatunnel:
  engine:
    history-job-expire-minutes: 1440
    backup-count: 1
    queue-type: blockingqueue
    print-execution-info-interval: 60
    print-job-metrics-info-interval: 60
    slot-service:
      dynamic-slot: true
    event-report-http:
      url: "http://xx.xx.xx.xx:1024/event/report"
      headers:
        Content-Type: application/json
    checkpoint:
      interval: 10000
      timeout: 60000
      storage:
        type: hdfs
        max-retained: 3
        plugin-config:
          storage.type: hdfs
          fs.defaultFS: file:///data/seatunnel/checkpoint_snapshot/

Running Command
POST /hazelcast/rest/maps/submit-job HTTP/1.1
Host: xx.xx.xx.xx:5801

{
    "env": {
        "job.mode": "batch",
        "job.name": "event_test"
    },
    "source": [
        {
            "plugin_name": "FakeSource",
            "result_table_name": "fake",
            "row.num": 100,
            "schema": {
                "fields": {
                    "name": "string",
                    "age": "int",
                    "card": "int"
                }
            }
        }
    ],
    "transform": [
    ],
    "sink": [
        {
            "plugin_name": "Console",
            "source_table_name": ["fake"]
        }
    ]
}

Error Exception
the rest api return information was different from the command monitor metrics。

Zeta or Flink or Spark Version
Zeta
Java or Scala Version
java v1.8
Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @liugddx as well.

We should fix this before 2.3.6.  cc @hailin0 @liugddx @EricJoy2048

We should fix this before 2.3.6. cc @hailin0 @liugddx @EricJoy2048

👀

Our test cases already cover this scenario, Have we fixed this issue in 2.3.6?
https://github.com/apache/seatunnel/blob/57e5627e89e870f26c1b0774cc225eaabe7f3c9a/seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterSeaTunnelContainer.java#L443-L445