Adaptive: Container dialogs registered in dialog manager and ReplaceDialog now works

Fixes https://github.com/microsoft/botbuilder-dotnet/issues/3900

Fixing tests :)

        }

I think this is a problem.
You are now registering the dialog in the constructor

Refers to: libraries/Microsoft.Bot.Builder.Dialogs/DialogManager.cs:120 in 213c345. [](commit_id = 213c3452dc74e2f369060892f70291a0219fc16f, deletion_comment = False)


fix: Improve generation of unique cases

TODO

[ ] Run test_explicit_headers on different runners

Codecov Report

Merging #1655 (3ce9baa) into master (768cd5b) will decrease coverage by 0.05%.
 Consider uploading reports for the commit f0a58ee to get more accurate results

@@            Coverage Diff             @@
##           master    #1655      +/-   ##
==========================================
- Coverage   98.96%   98.91%   -0.06%
==========================================
  Files          95       95
  Lines        7637     7645       +8
  Branches     1575     1317     -258
==========================================
+ Hits         7558     7562       +4
- Misses         48       51       +3
- Partials       31       32       +1

Impacted Files
Coverage Δ

src/schemathesis/_hypothesis.py
100.00% <ø> (ø)

src/schemathesis/schemas.py
99.40% <ø> (ø)

src/schemathesis/specs/graphql/schemas.py
100.00% <ø> (ø)

src/schemathesis/specs/openapi/schemas.py
99.56% <ø> (ø)

src/schemathesis/stateful.py
100.00% <ø> (ø)

src/schemathesis/models.py
99.12% <100.00%> (ø)

src/schemathesis/runner/impl/core.py
96.95% <100.00%> (+0.02%)
:arrow_up:

src/schemathesis/runner/impl/threadpool.py
100.00% <100.00%> (ø)

src/schemathesis/specs/openapi/_hypothesis.py
100.00% <100.00%> (ø)

src/schemathesis/cli/callbacks.py
98.84% <0.00%> (-1.16%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Protected/Private/Class Java fields have setters synthesized for them [moved]

This is Issue 208 moved from a Google Code project.
Added on 2013-07-08T16:19:57.000Z by<EMAIL_ADDRESS>Please review that bug for more context and additional comments, but update this bug.
Original labels: Type-Defect, Priority-Medium

Properties no longer generated for fields.


add writeJSON implementation

yey

@jacereda let me know what you think!

Cool! I'll PR support for StrMap.


Include types

It would be nice if there was an option to include types alongside column names.
Really cool diagrams, btw!

This is now included in 1.0.0 👍


tools: Accept hex representation as binary input

Sometimes when debugging or logging, SPIR-V may be dumped as a stream of hex values.  There are tools to convert such a stream to binary (such as 1) but they create an inconvenient extra step when for example the disassembly of that hex stream is needed.
In this change, the binary reader used by the tools is enhanced to detect when the binary is actually a hex stream, and parse that instead. The following formats are accepted, detected based on how the SPIR-V magic number is output:
=== Words
If the first token of the hex stream is one of 0x07230203, 0x7230203, x07230203, or x7230203, the hex stream is expected to consist of 32-bit hex words prefixed with 0x or x.  For example:
0x7230203, 0x10400, 0x180001, 0x79, 0x0

is parsed as:
0x07230203 0x00010400 0x00180001 0x00000079 0x00000000

Note that , is optional in the stream, but the hex values are expected to be delimited by either , or whitespace.
=== Bytes With Prefix
If the first token of the hex stream is one of 0x07, 0x7, x07, x7, 0x03, 0x3, x03, or x3, the hex stream is expected to consist of 8-bit hex bytes prefixed with 0x or x.  If the first token has a value of 7, the stream is big-endian.  Otherwise it's little-endian.  For example:
0x3, 0x2, 0x23, 0x7, 0x0, 0x4, 0x1, 0x0, 0x1, 0x0, 0x18, 0x0, 0x79, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0

is parsed as:
0x07230203 0x00010400 0x00180001 0x00000079 0x00000000

Similar to "Words", , is optional in the stream, but the hex values are expected to be delimited by either , or whitespace.
=== Bytes Without Prefix
If the first two characters of the hex stream is 07, or 03, the hex stream is expected to consist of 8-bit hex bytes of 2 characters each. If the first token is 07, the stream is big-endian.  Otherwise it's little-endian.  Unlike the other modes, delimiter is optional (which automatically handles 32-bit word streams), but no 0-padding is done. For example, all of the following:
03, 02, 23, 07, 00, 04, 01, 00, 01, 00, 18, 00, 79, 00, 00, 00, 00, 00, 00, 00
03 02 23 07 00 04 01 00 01 00 18 00 79 00 00 00 00 00 00 00
03022307 00040100 01001800 79000000 00000000
07,23,02,03,00,01,04,00,00,18,00,01,00,00,00,79,00,00,00,00
07230203, 00010400, 00180001, 00000079, 00000000

are parsed as:
0x07230203 0x00010400 0x00180001 0x00000079 0x00000000

@spencer-lunarg FYI

My only concern is that this will slow down the most common path, for a fairly special use case. I'm wondering if we could find a way to avoid slowing down the regular binary path? Can you recognize the hex stream without reading the whole file? Should we add an option to the tools to say the file is a hex stream?

Before the comments above, I was willing to add a -x or something to the tools for that, but after doing some perf testing, I don't see the cost of an extra copy showing up. At the moment, it doesn't look like this would actually slow anything down. Note that I did fix the 4KB reads turning to 1KB, now it's always 4KB.
FWIW, I really did consider avoiding the copy, I didn't like doing that. But in the end I decided to go with simple, and avoid reinterpret casts, dealing with alignment, endianness etc.


Feature Request: Support for other "deep zoom" output formats (Google, Zoomify)

Since vips_dzsave supports output in different metadata & directory layouts (specifically, ones compatible with Zoomify and Google Maps) via its layout parameter, would it be possible to add this capability to sharp?

Yes, this should be a relatively straightforward addition, thank you for the suggestion.
I'm happy to help steer you through the process of adding this feature via a Pull Request, should you be feeling eager and/or brave :)

@lovell I'd be willing to try to make it a pull request, given a little guidance!

Excellent.
If you've not already seen it, the CONTRIBUTING guide has a few basics.
For the API, I'd suggest extending the existing tile method to be something like tile([size], [overlap], [layout]), where layout is one of sharp.tile.zoomify, sharp.tile.google or sharp.tile.deepzoom (the default).

@bdunnette Have you been able to make any progress? Anything I can help with?

Commit 38ddb3b on the needle branch adds the ability to use Zoomify and Google directory layouts.
This does break the existing tile API slightly, but with the benefit of making space for things like #337.

v0.14.0 now available via npm, thanks for the original suggestion.


Support tracker to be able to cancel old requests

Sometimes we need to discard old requests. Our specific case is search, where the user changes search parameters quickly, and search request A takes longer than search request B to finish. In those cases, we end up using the last arrived response from the API, i.e. search request A. Not good.
The Http package supports cancelling requests by using a tracker. It would be nice to expose this feature here as well.
To avoid this change forcing the client to always deal with this, since a tracker is not needed in most cases, we should try to add it in a way that is opt in.
Relevant code: https://github.com/folq/servant-to-elm/blob/2b42e522c87aa96e4de84b877115991ea5a85848/src/Servant/To/Elm.hs#L135

We solved this by adding a sequence number to the Msg and keeping the sequence number of the newest request in the model. This way we can ignore results from the old requests.
GotResultMsg sequenceNumber result ->
  if sequenceNumber < model.sequenceNumber then
    -- Ignore results from old requests
    ( model, Cmd.none )

  else
    ...

But I think supporting tracker and possibly other things like timeout will still be an improvement to servant-to-elm, so I'll keep the issue open and see if I (or some one else) gets the time to fix it at some point in the future 🤞

Check out the new elmEndpointRequestInfo function, does it do what you want?

(Relatively new that is, since Dec 2020)

Yes, of course, how did I miss that 🙄 Thanks!


update code test snapshot

Fix failing snapshot test.

@jdeal Have you seen this error? Locally when running npm run patch-release the snapshot test failed because the snapshot expected ie autocorrect="false" but received autocorrect="off". So I updated the snapshot to expect "off". But in travis it receives `"false". So I can make test test pass locally but not in travis, or in travis but not locally, but not both. 😱
I did nuke node_modules and did npm install locally just to rule that out.

@stevemolitor I've never seen this, and your branch fails for me locally. No idea why you're seeing different results. Just to get you moving, ping me Monday, and I can do the patch-release.


SuiteBar: Username of external user dissappears on modern pages

Category

[ ] Question
[ ] Typo
[X ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Username should be visible on all pages.
Observed Behavior
Only on the library/list and viewlsts.aspx the username is shown. When navigating to a modern page, the username disappears from the SuiteBar
Steps to Reproduce

Create a communication or group site,
Add an external user
Logon as the external user
Notice that on the welcome page/home page of the site the username is no longer present (only the gear and question mark icons are visible)
When navigating to site contents or documents, the username appears again.

This is not really a developer issue, so this is not the best channel for this.
Your best option is to contact support, although this problem was not reproducible on our side.


docs: execution tracer is essentially not documented

I was able to find only 3 short mentions:

Command trace
Package trace
Go 1.5 changelog

They are not very helpful. Compare this to how race detector (article, blog post) or pprof (blog post) is documented. People on Reddit even think that trace tool flopped.
#11605 mentions future blog post, but it never materialised.

/cc @broady @campoy

ping

Execution tracer just got some documentation… in the form of this talk.

There is an external package with some documentation for events format: go-trace.

This article by Pusher.com is nice.

If it helps, I did write this long time ago: https://github.com/campoy/go-tooling-workshop/blob/master/3-dynamic-analysis/4-tracing/1-tracing.md

We could definitely still use more documentation, but I'll note that Go 1.19 adds more documentation directly in the trace web UI via https://go.dev/cl/412876.


Very big image files.

For the Eastman dataset, we identified problems using the original uncompressed tif images, as they were much larger than what were used in the application.  The most up to date version of the loris IIIF server has an additional check for compressed images that compress to very large sizes.  This is described in this related Issue
The current punjabi site has a small number of images that fail this test.  For example, the thumbnail image   for the collection.
Investigation of the logs show this error:
loris_1           |   File "/usr/local/lib/python2.7/dist-packages/PIL/Image.py", line 2724, in _decompression_bomb_check
loris_1           |     "could be decompression bomb DOS attack." % (pixels, 2 * MAX_IMAGE_PIXELS)
loris_1           | DecompressionBombError: Image size (466095438 pixels) exceeds limit of 178956970 pixels, could be decompression bomb DOS attack.

Updates to this parameter are available in the Configuration, but the first question is do we want to?  Should we encourage better image organization, but allow massive images, or this is this a good warning not be be using the original images.

@jrmerz .  @EricNebeker  and I discussed this on Friday.  Eric's happy to add Web friendly images to the few Punjabi images that need them.  After thinking about this for awhile.  My inclination is that we probably should not make this fix, and instead have some hard limiits on the size of the images we use.  I wonder what your take is?

@EricNebeker, the general concensus is that the current MAX_IMAGE_PIXELS is a pretty good guard for the website, and we should encourage the use of we ready images.  So, we are going to close this w/out a fix.  Let me know if you want an issue pulled for the Punjabi collection directly?

@qjhart I'll reformat those images. Thanks.


use -source 8 or higher to enable lambda expressions

Since the latest version 1.3.0 I can no longer start my app via Android Studio.
I get the following error message:
\my_project\node_modules\@capacitor-community\http\android\src\main\java\com\getcapacitor\plugin\http\Http.java:144: error: lambda expressions are not supported in -source 1.7
                HttpRequestHandler.ProgressEmitter emitter = (bytes, contentLength) -> {};
                                                                                ^
  (use -source 8 or higher to enable lambda expressions)

I also get the same error in a newly created project.
The following plugins are installed:
"@capacitor-community/http": "^1.3.0",
"@capacitor/android": "^3.2.5",
"@capacitor/app": "^1.0.5",
"@capacitor/browser": "^1.0.5",
"@capacitor/cli": "^3.2.5",
"@capacitor/core": "^3.2.5",
"@capacitor/device": "^1.0.5",
"@capacitor/filesystem": "^1.0.5",
"@capacitor/ios": "^3.2.5",
"@capacitor/push-notifications": "^1.0.6",
"@capacitor/splash-screen": "^1.1.5",
"@capacitor/storage": "^1.2.2",
"@capacitor/toast": "^1.0.5",

#159 used lambda expressions which are supported starting from java8
#174 fixes the issue and is awaiting merge (replaces lambdas with java8 equivalents)

I merged in #159 and #174. This will be fixed in the next release later tonight


platform_permission destination property not working

Describe the bug
Deleting a platform_permission destination (https://registry.terraform.io/providers/jfrog/platform/latest/docs/resources/permission#destination) property is not working
Requirements for and issue

[X] Your version of artifactory (you can curl it at $host/artifactory/api/system/version (self-hosted v7.84.12)
[X] Your version of terraform (1.9.7)
[X] Your version of terraform provider (1.14)

Expected behavior
Ability to manage platform_permission destinations
terraform {
  required_providers {
    artifactory = {
      source  = "jfrog/artifactory"
      version = "12.2.0"
    }
    platform = {
      source  = "jfrog/platform"
      version = "1.14.0"
    }
  }
}

provider "platform" {
  url               = "xxx"
  access_token      = "xxx"
  myjfrog_api_token = "xxx"
}

provider "artifactory" {
  url          = "xxx"
  access_token = "xxx"
}

resource "artifactory_group" "test_mrluje" {
  name      = "test_mrluje"
  auto_join = false
}

resource "platform_permission" "test-reader" {
  name = "test-mrluje"

  artifact = {
    actions = {
      groups = [{
        name        = artifactory_group.test_mrluje.name
        permissions = ["READ"]
      }]
    }

    targets = [{
      name             = artifactory_local_helm_repository.test-mrluje.key
      include_patterns = ["**/test/**"]
    }]
  }

  destination = {
    actions = {
      groups = [{
        name        = artifactory_group.test_mrluje.name
        permissions = ["READ"]
      }]
    }

    targets = [{
      name             = artifactory_local_helm_repository.test-mrluje.key
      include_patterns = ["**/test/**"]
    }]
  }
}

resource "artifactory_local_helm_repository" "test-mrluje" {
  key             = "test-mrluje"
  repo_layout_ref = "simple-default"
}

Next comment the destination block and apply

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # platform_permission.test-reader will be updated in-place
  ~ resource "platform_permission" "test-reader" {
      - destination = {
          - actions = {
              - groups = [
                  - {
                      - name        = "test_mrluje" -> null
                      - permissions = [
                          - "READ",
                        ] -> null
                    },
                ] -> null
            } -> null
          - targets = [
              - {
                  - include_patterns = [
                      - "**/test/**",
                    ] -> null
                  - name             = "test-mrluje" -> null
                },
            ] -> null
        } -> null
        name        = "test-mrluje"
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
╷
│ Warning: Attribute Deprecated
│
│   with provider["registry.terraform.io/jfrog/platform"],
│   on artifactory_test.tf line 17, in provider "platform":
│   17:   myjfrog_api_token = "xxx"
│
│ MyJFrog API token is deprecated. Use provider 'jfrog/myjfrog' https://registry.terraform.io/providers/jfrog/myjfrog instead.
│
│ (and one more similar warning elsewhere)
╵

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

platform_permission.test-reader: Modifying... [name=test-mrluje]
platform_permission.test-reader: Modifications complete after 0s [name=test-mrluje]

Plan again

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # platform_permission.test-reader will be updated in-place
  ~ resource "platform_permission" "test-reader" {
      - destination = {
          - actions = {
              - groups = [
                  - {
                      - name        = "test_mrluje" -> null
                      - permissions = [
                          - "READ",
                        ] -> null
                    },
                ] -> null
            } -> null
          - targets = [
              - {
                  - include_patterns = [
                      - "**/test/**",
                    ] -> null
                  - name             = "test-mrluje" -> null
                },
            ] -> null
        } -> null
        name        = "test-mrluje"
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@MrLuje Thanks for the report. I've added this to our plan to investigate.

@MrLuje Just want to point out that destination does not accept repository key as name. It should be name of the edge node. See https://jfrog.com/help/r/jfrog-platform-administration-documentation/add-destinations

@MrLuje I am unable to reproduce your issue. Using your TF configuration (with modification to run on my local Artifactory instance), there is no plan change after apply.

@alexhung Thanks for checking.
Maybe related to our artifactory version (v7.84.12), I'll try with an updated instance in the coming weeks.

I have the cloud hosted version with the same problem. Onced added a destination parameter in permissions when we removed the parameter
# platform_permission.container-promoter will be updated in-place
  ~ resource "platform_permission" "container-promoter" {
      - destination    = {
          - actions = {
              - groups = [
                  - {
                      - name        = "container-promoter" -> null
                      - permissions = [
                          - "ANNOTATE",
                          - "READ",
                          - "SCAN",
                          - "WRITE",
                        ] -> null
                    },
                ] -> null
              - users  = [] -> null
            } -> null
          - targets = [
              - {
                  - include_patterns = [
                      - "**/undefined",
                    ] -> null
                  - name             = "*" -> null
                },
            ] -> null
        } -> null
        name           = "container-promoter"
        # (3 unchanged attributes hidden)
    }

@Erwan-loot Can you provide more details on your issue (e.g. TF configuration, steps to reproduce)?

I'm experiencing a consistent drift issue with my Terraform configuration involving the platform_permission resource. Specifically, after adding and subsequently removing the destination block, Terraform still detects drift, indicating that the actual state differs from the desired configuration.
Terraform Configuration
Current platform_permission Resource:
resource "platform_permission" "container-promoter" {
  name = "container-promoter"

  artifact = {
    targets = [
      {
        name = artifactory_local_docker_v2_repository.container-internal-staging.key
        include_patterns = [
          "**",
        ]
      },
      {
        name = artifactory_local_docker_v2_repository.container-internal-prod.key
        include_patterns = [
          "**",
        ]
      }
    ]
    actions = {
      groups = [
        {
          name = platform_group.service_groups["container-promoter"].name
          permissions = [
            "ANNOTATE",
            "READ",
            "SCAN",
            "WRITE",
          ]
        }
      ]
    }
  }
  build = {
    targets = [
      {
        include_patterns = [
          "**",
        ]
        name = "artifactory-build-info"
      },
    ]
    actions = {
      groups = [
        {
          name = platform_group.service_groups["container-promoter"].name
          permissions = [
            "ANNOTATE",
            "READ",
            "SCAN",
            "WRITE",
          ]
        }
      ]
    }
  }
  release_bundle = {
    targets = [
      {
        name             = "release-bundles-v2"
        include_patterns = ["**"]
      }
    ]
    actions = {
      groups = [
        {
          name = platform_group.service_groups["container-promoter"].name
          permissions = [
            "ANNOTATE",
            "READ",
            "SCAN",
            "WRITE",
            "EXECUTE"
          ]
        }
      ]
    }
  }
}

Previously Added destination Block:
  destination = {
    actions = {
      groups = [
        {
          name = "my-group"
          permissions = ["READ", "ANNOTATE"]
        }
      ]
    }

    targets = [
      {
        name = "*"
        include_patterns = ["**"]
      }
    ]
  }

Steps to Reproduce

Initial Setup:

Apply the platform_permission resource without the destination block.

Modification:

Add the destination block as shown above.
Apply the configuration.

Reversion:

Remove the destination block from the configuration.
Apply the configuration again.

Observation:

Terraform reports a drift after these changes.

Expected Behavior
After removing the destination block and applying the configuration, Terraform should recognize that the desired state matches the actual state without reporting any drift.
Actual Behavior
Despite removing the destination block and reapplying, Terraform continues to detect drift, indicating discrepancies between the configuration and the actual state.

@Erwan-loot Thanks for the write up! This will help me in my investigation.

@MrLuje Apology for now reading your original issue correctly. Your issue is identical to @Erwan-loot but somehow I didn't see the multi-steps apply on the configuration.
The PR should fix this state drift issue. The provider was not removing the permission resource from Artifactory when it is removed from TF plan.


Make (stripped) prometheus work on gke.

Please note that this doesn't address the regional clusters. Prometheus will still won't work, or work incorrectly, when there is more than 1 master.
Replicated masters will be addressed in a separate PR.

/lgtm

/retest


Add missing sidre group methods

For consistency with other methods, we should add methods to the Group class:

destroyGroupAndData()
destroyGroupsAndData()
destroyGroupSubtreeAndData()
destroyGroupSubtreesAndData()

See https://github.com/LLNL/axom/issues/100 for additional context

I have the following methods in progress.  The AndData signifies that each will use the existing destroyViewAndData when destroying a View.  This will destroy any Buffer that becomes attached to zero Views upon the destruction of its last View.

void destroyGroupAndData(const std::string& path);

void destroyGroupAndData(IndexType idx);
These destroy a specific Group and its entire subtree.

void destroyGroupsAndData();
This destroys all Groups owned by this Group.  The Views directly owned by this are not affected.  There is an analogous destroyViewsAndData() already in the code.

void destroyGroupSubtreeAndData();
This destroys the entire subtree of this Group, both Views and Groups.  this remains in existence as an empty Group.

At the top of this issue there is also the suggestion destroyGroupSubtreesAndData, but I am not sure what this would mean that is not redundant with what I have described here.  Is there something more needed that I am overlooking?


attr_reader value cannot be accessed via super?

class Foo
  attr_reader :val
  def initialize(val)
    @val = val
  end
end
class Bar < Foo
  def val
    super
  end
end
puts Foo.new('foo').val # OK
puts Bar.new('bar').val

The last line raises an exception:
trace (most recent call last):
        [0] hoge.rb:12
        [1] hoge.rb:9:in val
hoge.rb:9: Can't get cfunc env from non-cfunc proc. (TypeError)

Is this mruby limitation?

Hmm. I tested the above with mruby 1.3.0 and get no error - it works fine in MRI and mruby.

in my machine working:
$./program.rb
foo
bar
ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux]
and  mruby 1.2.0 (2015-11-17)

@shevegen @xor256 Thank you for the information.
I did git bisect then found that https://github.com/mruby/mruby/commit/8f2c62407c0659d84126545e19505a851059e750 caused this problem. If you have a time please try 1.4.0 or later

@matz Will this issue be fixed in 1.4.1?


Add user agent header wrapper to requests handled by AuthorizedHttp

Make the existing solution a bit more flexible by passing a method to be wrapped.

Very nice, thank you.
Ross


Make PolylineVertex Flags public please, because we want to filter vertices

We want to filter to just SplineVertexFromSplineFitting points please. This will let us get the points we want without changing the code much. But is this the right way? Would you like to keep the setter Internal? I can update the pull request if you want.

The thing here is that polyline smoothing is not implemented, the information from the DXF is read but you cannot edit them, you can break the polyline if you do not set the flags properly. Also the VertexTypeFlags are actually shared between three different entities the old 2dPolyline that is imported as LwPolyline, the 3dPolyline (Polyline) and the polyface mesh (PolyfaceMesh).
It is not a problem to give read access to those flags, but you should keep them as read only.

I see we can use PolygonalVertexes now. Thanks.


Reusable base service

closes GH-63
provide basic interfaces for resources and services.

Currently, only person specific adaptions have taken place. If the changes are accepted, project specific adaptions will be performed.

@ZenoLC : Should the search method on the service level only have one parameter (query parameters) and then let the implementation decide what to do? Creating a Search object seems like putting logic in the resource layer, when it should really be in the service layer (i.e. defining endpoints and parameters vs implementing logic).

Yes, you are right, since we are not sending the additional information to the frontend we can just defer to the implementations discretion.

Rebased the branch on next


Unquiesce apps on destination after final restore

Closes #701
After further consideration and consultation with @sseago, decided to re-use the logic already in the controller for un-quiescing in the case where an app that is already quiesced is migrated.
Testing Results
I saw this PR successfully scale an nginx-pv deployment back to the original replica count when it was quiesced on my src cluster at the start of the final migmigration run.

Works well for me :+1: Tested a quiesced source app which has been unquiesced on the destination cluster during migration (e.g. also daemonsets un-disabled by node selector, cronjob un-suspended).


Update settings.rst

The correct is X-Access-Token e to AUTH_HEADER_NAME example and not  X_Access_Token

Thanks!


compilation on xcode 11 beta 3 for mac fails

using xcode 11 beta 3.
code compiles and runs fine on ios.
selected the run on mac button in xcode general settings.
compilation fails.

Thanks for reporting this. Things were revamped for Swift Package Manager. Please open a new ticket if you still have issues with it.


Ignore chain if no max cost

If the action is paid for with tokens and max cost is not specified for a chain, then the Builder will now ignore that chain instead of reverting. This allows clients to indicate the chains an action can utilize.

wondering if ignoring the chain with no max cost, whether or not we could just start ignoring from the very top by filtering chainAccountsList so the ignoring chain could be "invisible" through the whole complex logics blocks following after. 🤔

wondering if ignoring the chain with no max cost, whether or not we could just start ignoring from the very top by filtering chainAccountsList so the ignoring chain could be "invisible" through the whole complex logics blocks following after. 🤔

That's a good suggestion, I like it. It's quite a bit cleaner that way IMO.

@cwang25 Updated with your suggestion


Show all labels in a PieChart

I tried to print the Piechart as converting it to Image control. the Output is like below.

But I need to know the percentage of each item. This can be known by mouseover in application. but while printing how can i get this?
my code is below:
public BlockUIContainer GetBulkContainer(Visual target, double dpiX, double dpiY)
{
if (target == null)
{
return null;
}
        if (target.GetType() == typeof(TextBlock))
        {
            TextBlock tb = new TextBlock();
            tb.Text = ((TextBlock)target).Text;
            return new BlockUIContainer(tb);
        }
        else
        {
            // render control content
            Rect bounds = VisualTreeHelper.GetDescendantBounds(target);
            RenderTargetBitmap rtb = new RenderTargetBitmap((int)(bounds.Width * dpiX / 96.0),
                                                            (int)(bounds.Height * dpiY / 96.0),
                                                            dpiX,
                                                            dpiY,
                                                            PixelFormats.Pbgra32);
            DrawingVisual dv = new DrawingVisual();
            using (DrawingContext ctx = dv.RenderOpen())
            {
                VisualBrush vb = new VisualBrush(target);

                ctx.DrawRectangle(vb, null, new Rect(new System.Windows.Point(), bounds.Size));
            }
            rtb.Render(dv);

            PngBitmapEncoder png = new PngBitmapEncoder();
            png.Frames.Add(BitmapFrame.Create(rtb));
            MemoryStream stream = new MemoryStream();
            png.Save(stream);

            System.Windows.Controls.Image im = new System.Windows.Controls.Image();
            BitmapImage imageSource = new BitmapImage();
            imageSource.BeginInit();
            imageSource.StreamSource = stream;
            imageSource.CacheOption = BitmapCacheOption.OnLoad;
            imageSource.EndInit();

            im.Source = imageSource;
            return new BlockUIContainer(im);
        }

Well you can use DataLabels showing the percentage
http://lvcharts.net/App/examples/v1/wpf/Pie Chart
Notice every chart point has many useful properties, one of them is Participation it holds what you need
http://lvcharts.net/App/documentation/beta/LiveCharts-ChartPoint

I tried as you suggested . please check the below screenshot:

Here i cannot see all item percentages.
and how to use Participation property in Piechart?

Some of them are hidden by the default LabelPoint function, it hides the label when it is les than 5% if I remember well.
If you need to show them all, then override it
myPieSeries { LabelPoint = point => point.Participation.ToString("P"); }

Thanks a lot. I almost get everything.
if it is possible like below, it would be very helpful to me.

Not supported yet, will keep this issue open to add it in a future

I have got the same issue.
This will be a good solution:

The referenced commit fixes the issue where the series algorithm was not passing the label when the slice was small, I don't see any logic reason why i did that.
Besides that fixed, from version 0.9.2 I improved the labels position in for pie series, this will help to solve this issue, also keep an eye in #447, I am sure a combination of this fix, plus that issue will be very useful in many cases.
Now we can customize the position of labels in a PieSeries, options are: OutsideSlice and InsideSlice, here is a brief snippet and the result:

<lvc:PieChart Margin="50">
        <lvc:PieChart.Resources>
            <Style TargetType="lvc:PieSeries">
                <Setter Property="DataLabels" Value="True"></Setter>
                <Setter Property="FontSize" Value="16"></Setter>
                <Setter Property="Foreground" Value="#303030"></Setter>
                <Setter Property="LabelPosition" Value="OutsideSlice"></Setter>
                <Setter Property="StrokeThickness" Value="0"></Setter>
            </Style>
        </lvc:PieChart.Resources>
        <lvc:PieChart.Series>
            <lvc:PieSeries Values="5"/>
            <lvc:PieSeries Values="6"/>
            <lvc:PieSeries Values="8"/>
            <lvc:PieSeries Values="3"/>
            <lvc:PieSeries Values="4"/>
            <lvc:PieSeries Values="5"/>
            <lvc:PieSeries Values="9"/>
            <lvc:PieSeries Values="5"/>
            <lvc:PieSeries Values="6"/>
            <lvc:PieSeries Values="8"/>
            <lvc:PieSeries Values="3"/>
            <lvc:PieSeries Values="4"/>
            <lvc:PieSeries Values="5"/>
            <lvc:PieSeries Values="9"/>
            <lvc:PieSeries Values="5"/>
            <lvc:PieSeries Values="6"/>
            <lvc:PieSeries Values="8"/>
            <lvc:PieSeries Values="3"/>
            <lvc:PieSeries Values="4"/>
            <lvc:PieSeries Values="5"/>
            <lvc:PieSeries Values="9"/>
        </lvc:PieChart.Series>
    </lvc:PieChart>


wrong results für "inherit" keyword

I typed in inherit and expected to find the browsers’ support for the CSS-value "inherit", like here: https://developer.mozilla.org/en-US/docs/Web/CSS/inherit
Instead of that there is "CSS initial value" and "text-emphasis styling" in the result list (and no result for "inherit")

The results aren't wrong, those are all the caniuse results with the word "inherit" in them.


Task 3

Merge fix unit testing and Dockerization

Merge fix unit testing and dockerization

Fix unit testing and dockerization


feat: add footer

Description
Added footer.
Checklist

[ ] I am making a proper pull request, not spam.
[ ] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
#179
Add relevant screenshot or video (if any)
(Add here)

@Purva2803 what have you done with the sun image? :')

the image switched accidentally to the other folder. I have made the changes. I am hoping that this is my last PR :). Thank you for your tolerance :).

great work! ✨


Updated Uncovered Lines to Uncovered Line #'s in text report

Per https://github.com/istanbuljs/nyc/issues/35, updated "Uncovered Lines" table header to "Uncovered Line #'s"

Coverage remained the same at 97.523% when pulling ab89ecc15fd3921fbaae57c693b6080aa164c210 on willhayslett:master into bc84c315271a5dd4d39bcefc5925cfb61a3d174a on gotwarlost:master.


fix to issue #402

fix to issue #402

mercator-openlayers.js:

Line 93: Remove export attribute and add PlanetLayerSwitcher to export list at bottom of file.

collection.js:

Lines 7,392: Don't import fromExtent from openlayers directly into CEO. Map operations should be abstracted behind mercator so as to remain mapping library independent.

review-institution.js:

Line 561: What type are startDate and endDate? Do we need to call new Date() on them before using >?


Search does not seem to return classes

From @brodecva on November 17, 2016 2:22
Explain or tell me, what parameters are required to do so. It might be useful for example, to limit the search to classes when done for a header, and to resources, when for a cell.
Copied from original issue: odalic/odalic-ui#136

Duplicate of #215.


Please add that nesting is not supported for groups with role assignments

Please add under the "We don't currently support" section, that nested groups are not supported when the group is used for role assignments. If you try to do this in the GUI, you will get a nondescriptive error that says "Unable to complete due to a service connection error. Please try again later." If you try to add the group as a member in PowerShell, you receive a much more descriptive error: "Nesting is currently not supported for groups that can be assigned to a role."
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe42976d-da2c-c20a-25f1-f1548dcffbfb
Version Independent ID: fbeaa46b-eff9-b43a-e90e-6486149a3103
Content: Add or remove a group from another group - Azure AD
Content Source: articles/active-directory/fundamentals/active-directory-groups-membership-azure-portal.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @ajburnle
Microsoft Alias: ajburnle

Thanks! I made a pull request to add this. https://github.com/MicrosoftDocs/azure-docs-pr/pull/189666


Ethernet: frames with wrong CRC are not discraded by hardware (IDFGH-2577)

Environment

Development Kit:      Olimex ESP32-Gateway
Module or chip used:  [ESP32-WROOM-32U]
IDF version: v3.3.1
Build System:    [CMake]
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
Operating System:     [Linux]
Power Supply:         [USB]

Problem Description
In DMAOPERATION_MODE_REG register FWD_ERR_FRAME field is reset (0).
In promiscuous mode, every now and again frames with wrong CRC received.

Expected Behavior
I would expect these frame to be automatically dropped by hardware
Actual Behavior
In Receive descriptor RDES0[1]: CRC Error is set.
For example:
RDES0=0x58A8322
Steps to reproduce
It is reproduced withing a few seconds, just send some data through Ethernet to the dev board.
The more data is sent the quicker it is reproduced.
In file ../../esp-idf-v3.3.1/components/ethernet/emac_main.c
modify static void emac_process_rx(void) function as follows:
Instead of passing NULL as eb, pass desc0
  //copy data to lwip
  emac_config.emac_tcpip_input((void *)(emac_config.dma_erx[tmp_dirty].basic.desc2),
                                         (((emac_config.dma_erx[tmp_dirty].basic.desc0) >> EMAC_DESC_FRAME_LENGTH_S) &
                                          EMAC_DESC_FRAME_LENGTH), (void *)(emac_config.dma_erx[tmp_dirty].basic.desc0));

Code to reproduce this issue
#define EMAC_DESC_ERROR_SUMMARY (1U << 15)

esp_err_t tcpip_adapter_eth_input(void* buffer, uint16_t len, void* eb)
{
    if (!buffer) {
        return ESP_OK;
    }

    if (((uint32_t)eb & EMAC_DESC_ERROR_SUMMARY) || len <= SIZEOF_ETH_HDR) {
        ESP_LOGW(TAG, "Not a valid eth frame received RDES0=0x%X len=%u", (uint32_t)eb, len);
    }

    esp_eth_free_rx_buf(buffer);
    return ESP_OK;
}

void app_main()
{
...
    eth_config_t config = DEFAULT_ETHERNET_PHY_CONFIG;

    config.phy_addr = PHY_ADDR;
    config.gpio_config = eth_gpio_config_rmii;
    config.tcpip_input = tcpip_adapter_eth_input;
    config.clock_mode = ETH_CLOCK_GPIO17_OUT;
    config.promiscuous_enable = true;
    config.phy_power_enable = phy_device_power_enable_via_gpio;

    ESP_ERROR_CHECK(esp_eth_init_internal(&config));
    ESP_ERROR_CHECK(esp_eth_enable());

...
}

Hi @ohmyandy, thanks for reporting the issue and sorry for very late response. We have limited resources...
What was your setup? What kind of traffic did you send to the ESP32 and from which device? How big frames did you send?
The reason why I am asking is the issue you reported is quite strange since Ethernet is robust proven technology. It seems to be very unlikely that any commercial Ethernet card would produce CRC errors as often as you reported under normal "home" conditions.
Unfortunately, IDF version 3 is getting limited support and we suggest to users to migrate. However, I tested the EMAC behavior on master branch with EthernetKit board. I configured PHY to loopback mode and disabled Tx CRC computation in EMAC by setting DC: Disable CRC[27] to 1 to simulate the CRC corruption.
At Rx side, I tested two options:

FWD_ERR_FRAME of `DMAOPERATION_MODE_REG reset to 0 (default setting). The frames are dropped in EMAC and I do not receive any frames with wrong CRC.
FWD_ERR_FRAME of `DMAOPERATION_MODE_REG set to 1. The corrupted frames are forwarded to our driver where we can check for error by reading status of RDES0.
The test was performed in promiscuous mode.

See 0001-emac_hal-to-corrupt-CRC.patch.zip based on a015123a1d.


[OpenGL] Set scissor rect relative to framebuffer, not viewport.

This fixes the misalignment of scissor rects when the viewport is not a full view of the framebuffer.

@TheMostCuriousThing Thanks for catching this. The fix LGTM.


Fix typo nginx configMap vts metrics customization

This change is

Coverage increased (+0.02%) to 43.146% when pulling 031fdfd730389d95be170eacbf29afa97e678c35 on cy-play:fix-typos-custom-vts-metrics into fc5da496171a7916cbc5668b4a2caa9ab43e538f on kubernetes:master.

/lgtm

@mrmm thanks!


cancelDrag() now cancels drag then does raf->onDragEnd()

Resolving #52
NOTE: I did not do something similar to canclePinch

Out of sheer laziness
Because I'm not confident this is the approach the maintainers would like to take
Because this may never be an issue if it only happens when devtools is open and that's difficult to do on mobile (where pinch is possible?)

Hey @morgs32 5.0.1 has been released and should fix this!  I did intent to make your suggested changes. No matter how busy I was yesterday I should've responded. Sorry!

Haha absolutely no worries, I wanted to make some minor adjustments and this PR was pretty straightforward once you had the correct implementation idea! I genuinely wanted to thank for the help really ;)


Update api spec

Closes no issues :cry: But we have lots of new shiney documentation over at https://serp-connect.rtfd.io/

Current coverage is 41.66% (diff: 100%)

Merging #49 into master will decrease coverage by 0.49%

@@             master        #49   diff @@
==========================================
  Files            15         15
  Lines          1046       1056    +10
  Methods           0          0
  Messages          0          0
  Branches        116        117     +1
==========================================
- Hits            441        440     -1
- Misses          553        563    +10
- Partials         52         53     +1

Powered by Codecov. Last update 3054307...669448d


Completed Profile View Page

Cancel button doesn't do anything?

doesn't seem to work on cancel button still.

also, please update the code to update profile picture instead of storing locally


Help: java.lang.RuntimeException: class not found CLASSNAME

First, thanks for your serialization framework.
It would be great if you can suggest something for my problem. I am getting the following runtime exception when deserialising using the below method:
"java.io.IOException: java.lang.RuntimeException: class not found CLASSNAME: loader:sun.misc.Launcher$AppClassLoader@73d16e93
at org.nustaq.serialization.FSTObjectInput.readObject(FSTObjectInput.java:243)
at org.activity.util.Serializer.fstDeSerializeThis(Serializer.java:161)"
Note that serialisation and deserialisation works fine if done in same execution, but gives the above error if done in separate execution. Kindly suggest,
My implementation is as follows:
public static Object fstDeSerializeThis(String fileName)
	{
		Object obj = null;
		FileInputStream fis = null;
		FSTObjectInput in = null;``
		System.out.println("Deserialising ..." + fileName);
		long dt = System.currentTimeMillis();
		try
		{
			RandomAccessFile raf = new RandomAccessFile(fileName, "rw");
			fis = new FileInputStream(raf.getFD());
			in = new FSTObjectInput(fis);
			obj = in.readObject();
			in.close();
			raf.close();
			long lt = System.currentTimeMillis();
			System.out.println("Successfully fstdeserialised " + fileName + " in " + (lt - dt) / 1000 + " secs");

		}
		catch (Exception ex)
		{
			ex.printStackTrace();
		}
		return obj;
	}

public static void fstSerializeThis(Object obj, String fileName)
	{
		FileOutputStream fos = null;
		FSTObjectOutput out = null;
		long dt = System.currentTimeMillis();
		try
		{
			RandomAccessFile raf = new RandomAccessFile(fileName, "rw");
			fos = new FileOutputStream(raf.getFD());
			out = new FSTObjectOutput(fos);
			out.writeObject(obj);
			out.close();
			raf.close();
			long lt = System.currentTimeMillis();
			System.out.println("Successfully fstserialised " + fileName + " in " + (lt - dt) / 1000 + " secs");
		}

		catch (Exception ex)
		{
			ex.printStackTrace();
		}

	}

Usually when you see an empty CLASSNAME it means the inputstream is empty. I would check the file size and contents on disk and see that is in there.

Hi sorry, I don't have capacity and time to deal with beginners issues as this gets overboard (also receiving mails frequently).


getAllValues() doesn't recognize color values

the css:
.box_pic{background: url(images/no-image) #D1B6DB center center no-repeat;}
the call:
$CssParser = new CSSParser(file_get_contents($filepath));
$CssDocument = $CssParser->parse();
echo $CssDocument;
// that one outputs:
// .box_pic {background: url("images/no-image") rgb(209,182,219) center center no-repeat;}
//but this one:
foreach ($CssDocument->getAllValues() as $value)
echo $value;
//outputs:
// url("images/no-image")centercenterno-repeaturl

That’s because a CSSFunction (which the rgb() color declaration is) is not actually a CSSValue but instead a CSSValueList. I agree it’s confusing. But you could use $CssDocument->getAllValues(null, true) to at least get the CSSValues that make up the function’s arguments.

just took a look at the source and found out about that too, sorry about that.
and thanks for the workaround suggestion. :)


Bugfix 937 allow nested objects in context

fixes: https://github.com/BlueBrain/nexus/issues/937

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2e3638f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #300   +/-   ##
=========================================
  Coverage          ?   84.45%
=========================================
  Files             ?       21
  Lines             ?      444
  Branches          ?       97
=========================================
  Hits              ?      375
  Misses            ?       67
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3638f...431663f. Read the comment docs.


Replace exception library Should with Chai

Resolves issue #28

@HappyZombies you can take a look at it if you want, from my end it is good to go

Looks good! Merging.


Leaderlease examples?

Are there any examples of implementing a leader lease to do safe rolling deploys of controllers?
(New to both Rust and kube-rs but loving it so far! It's a pleasure to use compared to what I'm used to with go.)

Not really, it's an area I've been meaning to look into but even the official K8s documentation on the topic is.. lacklustre at best (or at least it was the last time I tried to make sense of it).
In the meantime, you might be able to get close enough with a StatefulSet? Alternately, it might be viable to structure your controller in such a way that running multiple instances is viable (rollback on update conflicts, and so on).

Also moving this into a discussion, since this isn't really an actionable proposal.


Link to checkpoint file

The links to checkpoint at the end of README seems expired, can you provide a valid one?

It doesn't exist anymore. You need to train yourself.


Import Slow Down

Hi,
I was trying to run the wikipedia demo on an AWS instance and was running into errors/slow down after I imported 12,000,000 paragraphs.
Instance Details:
g4dn.12xlarge
4 T4 GPUs
48 vCPU
192 GB RAM
Ubuntu 18.04 OS
After I import 12 million paragraphs, the machine performance considerably slows down. I start getting a batch creation timeout message for a batch size of 512, and I continue to get the message when I reduce the batch size to 50. Any ideas why the process slows down so much? The "vectorCacheMaxObjects":<PHONE_NUMBER>00 so I know that is not the issue.

Sudden slow downs (if not related to the vectorCacheMaxObjects) are not to be expected, so you are right to look for a source of those slow-downs. The two most common reasons for sudden slow downs that we've seen so far are:

Potential for duplicate vectors. Duplicate vectors are a big problem for the HNSW index, it slows down considerably if there are exact copies of vectors. Is there any chance that your data contains duplicate vectors around the ~12M mark? Since you are mentioning the Wikipedia demo dataset this is unlikely, but we should still rule it out
Could it be that the OS starts swapping memory to disk? As the memory requirements grow it might be the case that the OS suddenly decides to swap mem to disk. This would have a similar effect to limiting the vectorCacheMaxObjects. Is swapping configured and/or can you maybe even see if some pages are swapped?


Implement traits for Cache and HashmapCache

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 12 (91.67%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.784%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main.rs
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
62

Relevant Lines:
74

💛  - Coveralls


Explain that

Note: This uses real hyphens for the example inside the actual HTML comment as opposed to the normally used hyphen-minus, which would end it too early (and we can't escape it nicely).
Reason for this addition:
A user filled in text, keeping the angled brackets
* __Deployment Mode__:       <Single Server>
This is interpreted as HTML element and will thus not display. I hope the proposed change makes it clearer what this is. Or should we explicitly tell not to write the answers in <>?

Tell team members to click edit if something looks like it wasn't filled out to see if something is hidden because of angled brackets. Maybe also write this down in a document for new hires. Then close this PR as not needed.

@sleto-it  Added a comment on internal doc with the request to add a remark regarding this: https://docs.google.com/a/arangodb.com/presentation/d/1xlOv9KMvQvuDRfdq-kWRIJ9owJreVP2niLlhZFZqQho/edit?disco=AAAACXZAjfU


StreamPeerTCP doesn't connect to TCP servers

Godot version
4.0.beta4.official
System information
MacOS Ventura 13.0 or Windows 11 21H2
Issue description
Using the StreamPeerTCP class to connect to a TCP server/listener doesn't work. Well, it works from the server side, but the StreamPeerTCP class do not.
Using the exact same minimal reproduction project in latest stable Godot 3.x works.
Steps to reproduce

Start a basic TCP server/listener on any port (5005 in this example)

Click me
This is an example code in NodeJS:
const net = require('net');

let server = net.createServer((socket) => {
    console.log("Accepted connection.");
}).listen(5005, () => console.log("Listening on 5005."));

Run it using node file.js.

Try to connect by running the very minimal reproduction project
Accepted connection. will get printed on the server side ✅
TCP Connected. will not get printed on Godot/client side ❌

Minimal reproduction project
minimal.zip

See https://github.com/godotengine/godot/issues/64699 and https://github.com/godotengine/godot/issues/62001.

I just looked at the issues you linked. The first one looks similar to the issue I have as it's stuck in the connecting phase too, otherwise they seem to be using some more hight level Class.
Can you expend on why being stuck on STATUS_CONNECTING makes sense in this scenario? I don't get how it could have to do with a compatibility breakage.

Calling tcp.poll() before checking the status works for me.

Calling tcp.poll() before checking the status works for me.

Thank you, I wasn't aware of this function, this fixed my issue.


get_GEOS() and get_GEOSs2s() fixes (corrected precip, pointer allocation)

Minor fix for GNU. Address issue #441 (check the pointer association before checking the size in get_GEOS() and get_GEOSs2s())
Fix for allowing corrected precipitation to be on a different grid than rest of forcing data in get_GEOS().

@weiyuan-jiang,
I added two commits.

The first commit supports the corrected precip being on a different grid from the rest of the forcing data in get_GEOS().   In a nutshell, I deleted the if (GEOSgcm_var==1) then condition per @gmao-qliu's email.
The second commit does the same for get_GEOSs2s(), which is not yet set up to read corrected precipitation from separate files, so here the change is not strictly needed, but it shouldn't hurt and will keep some consistency between the two subroutines.

In either case, did not change the order in which the forcing fields are processed (e.g., G5DAS_defs), contrary to my earlier plans.  On 2nd thought, I think re-ordering would not make a difference because the allocation is remembered from one time step to the next, so there is still only one back-and-forth change per forcing time step.  That is, re-ordering would only provide a minimal efficiency improvement in the initial or final time step.
I also renamed the PR and updated the introductory comment accordingly.
Please  take a look when you're back in the office and let me know if you think this makes sense.  If everything looks ok, we can ask Biljana to test the PR.

It looks good to me. @gmao-rreichle @biljanaorescanin

Thanks, @weiyuan-jiang.  I committed two more changes, one to clean up the redundant call to MAPL_SyncSharedMemory() and the other to fix my earlier commit in get_GEOSs2s().
@biljanaorescanin : Please test the PR.  Make sure to use the full suite of tests that Matt is running every night.  One objective of the PR is to fix the pointer issue that Matt uncovered with the gnudebugconus test.

I've run same tests as Matt, all tests passed.

@gmao-jkolassa, @jpark50:
FYI, with this PR I just merged a minor fix of the get_GEOSs2s() forcing reader (see intro comment above).  The same fix was applied and tested in get_GEOS(), so I don't expect any problems from this merge with get_GEOSs2s() going forward.  Please let me know if you encounter any problems when using this new version of get_GEOSs2s().
cc: @weiyuan-jiang, @biljanaorescanin, @gmao-qliu


[FEATURE] Passing dataframes cross workflow

Is your feature request related to a problem? Please describe.
NA
Describe the solution you'd like
dag1 = FugueWorkflow()
df = dag1.df([[0]],"a:int")
df.yield_as("output")
dag1.run()

dag2 = FugueWorkflow()
df = dag2.df(dag1["output"])
df.show()
dag2.run()

To pass dataframe cross workflow, the dataframe must be stored in persistent storage (save to disk). So dag1["output"] should just be a reference (file path). Notice that, within the same workflow, yield may not be necessary
for Fugue SQL
dag1 = FugueSQLWorkflow()
dag1("""
output = CREATE [[0]] SCHEMA a:int
YIELD output
# or YIELD output AS out
""")
dag1.run()

dag2 = FugueSQLWorkflow()
dag2("""
PRINT df
""", df = dag1["output"])
dag2.run()

Describe alternatives you've considered
NA
Additional context
NA

Don't forget there will be two cases, one is that the dataframe is so large, we need to save it to file, so it's just a reference to that file, another is that the dataframe is small, and users want to yield to memory (to driver memory) so they can use it directly, this is a also a common case when using Jupyter notebook


a11y: improve bot controller keyboard handling

Description
This fixes the following issues

Focus stucks on bot controller menu when navigating with keyboard
Focus doesn't get to the opened debug panel when navigating to run details
No region aria provided for debug pane

The following changes were made to address these issues:

Replace Callout component with FocusTrapCallout to handle focus inside the menu correctly
Add an effect to place focus to the debug panel when panel gets opened
Configure FocusTrapCallout to allow focusing elements outside of the callout
Add required aria attributes to the debug panel root

Task Item

VSTS 70527

Screenshots

#minor

Coverage increased (+0.003%) to 55.962% when pulling e438b896ffc8e8e9c0912332be5564c9b8dd47b9 on OEvgeny:a11y/bot-controller into 8bbf851cb8a2194bdfa877d242d7c822a93a8674 on microsoft:main.


SARIF format results do no supply the actual violation results?

TL;DR
SARIF format results do not include status of the violation - i.e. "PASSED", "FAILED" etc - the field level in the results corresponds to the severity of the security rule.
Expected behavior
Running legitify with the following command:
go run main.go analyze -t <token> --org <org-name> --scm github --output-format sarif --output-file results.json
Expected to view the violation status in the SARIF results
Observed behavior
SARIF-based format results
{
  "ruleId": "data.actions.actions_can_approve_pull_requests",
  "ruleIndex": 0,
  "level": "error",
  "message": {
    "text": "The default GitHub Actions configuration allows for workflows to approve pull requests. This could allow users to bypass code-review restrictions.  \nLink to organization actions: https://github.com/organizations/<org-name>/settings/actions  \nAuxiliary Info:  \nEntity Id: <entity-id>  \nEntity Name: <org-name>  \nOrganization Id: <org-id>  \n"
  },
  "locations": [
    {
      "physicalLocation": {
        "artifactLocation": {
          "uri": "github.com/organizations/<org-name>/settings/actions",
          "uriBaseId": "https://"
        }
      }
    }
  ],
  "hostedViewerUri": "https://github.com/organizations/<org-name>/settings/actions"
}

JSON-based Format results
{
  "violations": [
    {
      "violationEntityType": "organization actions",
      "canonicalLink": "https://github.com/organizations/<org-name>/settings/actions",
      "aux": {
        "entityId": "<entity-id>",
        "entityName": "<org-name>",
        "organizationId": "<org-id> "
      },
      "status": "PASSED"
    }
  ]
}

BTW, According to the actions settings, the JSON-based result is correct.
Version
v1.0.1
On which operating system are you using legitify?
Mac OS
Relevant log output
No response
Additional information
As it seems by the formatter_sarif.go file, there is no reference to the Status field of the violation:
for _, violation := range data.Violations {
			base, uri := f.URIFromLink(violation.CanonicalLink)
			run.AddDistinctArtifact(violation.ViolationEntityType)
			run.CreateResultForRule(policyInfo.FullyQualifiedPolicyName).
				WithLevel(sarifSeverity(policyInfo.Severity)).
				WithMessage(sarif.NewTextMessage(getViolationMessage(&violation, &policyInfo))).
				WithHostedViewerUri(violation.CanonicalLink).
				AddLocation(
					sarif.NewLocationWithPhysicalLocation(
						sarif.NewPhysicalLocation().
							WithArtifactLocation(
								sarif.NewArtifactLocation().
									WithUri(uri).WithUriBaseId(base),
							),
					),
				)
		}

Thanks @iozery.
I've created a PR to include only failed instances in the SARIF output https://github.com/Legit-Labs/legitify/pull/252/files
I'll update once merged.
I assume you don't expect to see PASSED entities in the sarif output, if you do please let us know.

Merged, closing the issue for now


[toranj] test-case for adding IPv6 addresses with same prefix on multiple nodes

This commit adds a new test script for toranj test frame-work
covering the situation when IPv6 addresses with same prefix are
added/removed on multiple nodes. The test verifies that the on-mesh
prefix list on all nodes stays consistent and updated as the addresses
are added/removed and nodes are reset.

Related PR in wpantund: https://github.com/openthread/wpantund/pull/334
This test-case is expected to fail without the related change in wpantund.

The wpantund PR is merged. Rebased on master to fix the conflict.


Better config

This PR beefs up the config module to bring it more in line with other packages. Instead of directly accessing attributes in pliers.config (e.g., pliers.config.parallelize), access is now restricted through config.get_option() and config.set_option() methods.
Additionally, the package now scans in standard locations (user's home directory, and current working directory) for pliers_config.json files, which override package-level settings if found. The user can also set the PLIERS_CONFIG environment variable with a filename that is handled in the same way.
I'm not 100% satisfied with this--e.g., the get_ and set_ methods are currently inconsistent; it's .get_option('parallelize'), but .set_option(parallelize=True)). But on the whole I think this is a big improvement.

Added you to review, @qmac, but no rush--feel free to get to it when you're back from the break.


Android OTP copied from message could not setState

Copied OTP codefrom message could not able to setState(code)
To Reproduce
Steps To produce:

Entered Contact no.
received OTP
Received OTP
on click Button Send OTP the OTP does not set in a state.

Expected behavior
On Send button I need OTP copied OTP on the state.
Smartphone (please complete the following information):
Android Devices
Code:
export default class Verification extends Component<Props> {
    constructor(props) {
        super(props)
        s = Strings()
        this.state = {
            loading: false,
            code : '',
        }
    }

render(){
<View>
  <OTPInputView
                                        style={{ width: '60%', height: 50, alignItems: 'center' }}
                                        pinCount={6}
                                        // code=""

                                        code={this.state.code} //You can supply this prop or not. The component will be used as a controlled / uncontrolled component respectively.
                                        onCodeChanged = {code => { this.setState({code},()=>alert(code))}}
                                        codeInputFieldStyle={styles.underlineStyleBase}
                                        codeInputHighlightStyle={styles.underlineStyleHighLighted}
                                        onCodeFilled={(code => {
                                            code => { this.setState({code})}
                                            alert('code Alert'+code)
                                            // alert(`Code is ${code}, you are good to go!`)
                                            // setTimeout(() => {
                                            //     // this.hitVerifyMobileApiCall(code);
                                            // }, 200);
                                        })}
                                    />
                                </View>
                            <View style={{ marginTop: (d.height*0.036), alignItems: 'center', }}>
                                <AppButton
                                    containerStyle={[styles.submit, { backgroundColor: c.cinnabar }]}
                                    textStyle={{fontSize: d.height < 600 ? 14 : 16, color: "white" }}
                                    value={s.send}
                                    onPress={()=>{
                                                 this.hitVerifyMobileApiCall(this.state.code);

                                    }}
                                    />
                            </View>
</View>
}

This work for me:
        <OTPInputView
          pinCount={6}
          onCodeChanged={(code) => {
            if (code.length === 6) {
              this._handleVerificationCode(code)
            }
          }}
          onCodeFilled={this._handleVerificationCode}
        />

Thanks @rrust for providing the walk around. This issue should had been fixed in PR https://github.com/Twotalltotems/react-native-otp-input/pull/58.


build! remove 32-bit Windows build

I think Terasology dropped 32-bit support a while back.

Oh, there are more left-overs we can remove now.

[ ] https://github.com/MovingBlocks/TerasologyLauncher/tree/master/buildres/windows32
[ ] ... (?)


Vertex color "use as albedo" is ignored when emission is white

Godot 3.0 master
Windows 10 64 bits
nVidia 940M
I created a mesh with PRIMITIVE_LINES, but I am unable to make it output vertex color as emission. I enabled "use vertex color as albedo", but then it's shaded. If I set emission to white, it becomes white and ignores vertex color.
Related? https://github.com/godotengine/godot/pull/10441
Workaround: set the mesh as unshaded.

you cant emit a vertex color as emission, write a custom shader. In 3.1 you will probably get back visual shader graph for more customization


Pre-Updates for the new domain of EZweb (au.com) #232

See #232

Coverage increased (+0.003%) to 95.082% when pulling 095e718dc63d2fa6f57d8841e480e359598f214a on update-for-au.com-3003 into 863b8d8515bbfbe68872c45a76065ea43d6235de on master.


Add URL for viewing node coverage data on dev server.

Running test-js-with-node --coverage now provides a URL
to view the output data on the web.
Fixes #5177.

Automated message from Dropbox CLA bot
@cory2067, it looks like you've already signed the Dropbox CLA. Thanks!

One thing to note, you might want to put this closer to "Coverage summary" or after (or even replace) "Writing coverage reports at ..."

Yeah, I think I'd prefer it there too, but I think those are autogenerated messages by the istanbul library. Not sure if I can really change those.

Oh, ok. That makes sense. (You have failing tests :/)

Oh true, forgot to check coverage on this.

Merged, thanks @cory2067!  I agree it'd be nice to be able to put this next to the istanbul stuff, but if it's not easy, we can leave it as a future improvement idea :)


feat(install): add bundle installer

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closed, work moved to another branch


Feature request: Shift FOV center over so Clive stops being off-center

First, thanks so much for the work you’ve done!
I noticed that when I widen the FOV, the fact that Clive is off-center becomes significantly more noticeable and it’s kind of frustrating to deal with.
Is it at all possible to adjust the position of the camera to shift over so that Clive stops being off center? If that could be added as a feature that would be great!

Added in v0.7.7


fix install and download pages

This PR fix  install  pages by add non-asf notes adn remove install for language that we don't publish in next release:

And add a download pages, which just say: Apache Fury hasn't make a release since joined Apache Incubator:

Hi @sebbASF ,  thanks for helpint review this PR. I updated the PR according to your suggestions. Do you have futher comments for this PR?

Looks OK now, thanks.
[I have not reviewed the update to docusaurus.config.ts as I don't have a way to check that.]

Thanks for reviewing this pr.
If you want to see the web pages of docusauweb for checking docusaurus.config.t.
You can just run 'yarn start' at project directory. It will open localhoat:3000 automatically.

You can just run 'yarn start' at project directory. It will open localhoat:3000 automatically.

It's not as simple as that. First I have to download the relevant Git branch. $ git clone --depth 1 --single-branch -b fix_install_download_pages https://github.com/chaokunyang/incubator-fury-site fury $ cd fury $ yarn start yarn run v1.22.19 $ docusaurus start /bin/sh: docusaurus: command not found

I see. Let's merge this PR first, and add more detailed guide for build site in another PR


Add segugio

Add segugio (mainly for VM usage), https://github.com/reecdeep/segugio.

Might look at this later


Make the property table easier to find

This arose from a discussion with @NatalyLo. The property table is hard to find if you don't know it exists, and nothing indicate the users that they can click on "structure XXX" or "atom YYY" to open this table.
We should make it easier to find, while not being too obnoxious. One suggestion is to add another button on the structure viewer (near duplicate/close/...) that would open this table (and maybe flash the existing buttons to signal the user they can use these as well). Alternatively, clicking on an already selected point on the map could open the table and flash existing buttons (clicking on non-selected point would select it).

The alternative would be to create some kind of tutorial for first time users, showing them parts of the page in an interactive way. I'm a bit reluctant to this since website tutorial can be very obnoxious when you already know what you are doing. This could be alleviated by storing a cookie to know if someone already looked at the tutorial. I don't know how this would play out  with different deployments of chemiscope, although only hosting the tutorial and cookie on chemiscope.org might be an OK solution.

Wouldn't a small [...] button, or hamburger icon, next to the structure
index be a good hint? there's no shortage of space close to the structure
number label
On Wed, 12 May 2021 at 17:04, Guillaume Fraux @.***>
wrote:

This arose from a discussion with @NatalyLo https://github.com/NatalyLo.
The property table is hard to find if you don't know it exists, and nothing
indicate the users that they can click on "structure XXX" or "atom YYY" to
open this table.
We should make it easier to find, while not being too obnoxious. One
suggestion is to add another button on the structure viewer (near
duplicate/close/...) that would open this table (and maybe flash the
existing buttons to signal the user they can use these as well).
Alternatively, clicking on an already selected point on the map could open
the table and flash existing buttons (clicking on non-selected point would
select it).
The alternative would be to create some kind of tutorial for first time
users, showing them parts of the page in an interactive way. I'm a bit
reluctant to this since website tutorial can be very obnoxious when you
already know what you are doing. This could be alleviated by storing a
cookie to know if someone already looked at the tutorial. I don't know how
this would play out with different deployments of chemiscope, although only
hosting the tutorial and cookie on chemiscope.org might be an OK solution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cosmo-epfl/chemiscope/issues/128, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZYZU7OIR64BMSOQL73TNKKH7ANCNFSM44YZJIHA
.


No browser with file_to_run

Should we allow to not launch a browser even when file_to_run is set? Today this is not possible because of https://github.com/jupyter/jupyter_server/blob/master/jupyter_server/serverapp.py#L1822

This is needed for Voila, in the case where we have a file to serve but we don't want to launch a browser if launched with --no-browser.

This makes of sense to me having to serve a file without a browser

Yeah, having a browser pop up if you specify --no-browser seems weird.

Yeah, this makes sense to me. No-browser should always prevent a browser from popping up.


Need to have separate Register and Unregister methods for Listeners

Old listener classes are not being cleaned up quickly enough, and they need to have register and unregister methods that can be called as part of the life cycle.

The subscription events need to me migrated to either fragments that are hidden in the background and don't interact with the ui, or they need to be added to the Activity so they can be correctly unregistered when not in use (i.e. the activity has been destroyed).

This is now being handled by Presenters.   The presenters register for events on the attachView and detachView methods.   The presenter then communicates back to the view to handle any updates..


Added support for drawing complex rounded rectangles

Next to Graphics.drawRoundedRect() there now is Graphics.drawRoundedRectComplex() which expects 4 radii instead of 1. Going clockwise starting from top left.
core.math.shapes.RoundedRectangle has been changed in order to hold the 4 different radii. The contains(x,y) function has been adjusted, as well as the associated drawing methods for Canvas & WebGL.

Ah, I see. Since I changed the RoundedRectangle class, the tests for it fail.

We dont accept those things in dev anymore, only in next. Unless @bigtimebuddy wants to make another drawStar :)

Also you didnt have to close it, just push more commits in your branch (Mwni:dev). However, its better to make a PR against next (pixi-v5)

@ivanpopelyshev Alright, thanks for the info. Should I modify the RoundedRectangle class in a way, so it accepts both 1 or 4 radii, or create a separate class ComplexRoundedRectangle for that?

The problem is that @GoodBoyDigital is doing Graphics refactoring, so I really cant advice anything. We have to wait for both @GoodBoyDigital and @bigtimebuddy


Add design and architecture details of crystal

The PR is for architectural details of crystal.
It explains motivation, goals and architecture design in more details
What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

@skdwriting @sushanthakumar Please review


Add Tick event for ScriptDomain

Add a clear and concise description of the feature you have in mind.
Add a ScriptDomain.Tick event that'll be invoked from main thread, so modders could choose to subscribe to this event for more performant native calling.
Waiting and yielding will be unavailable in the handler

I could make a PR

#1099

You can simply add set the NoScriptThread attribute on your script class now to make SHVDN execute that script on the main thread. Do note that Script.Wait() and Script.Yield() are not available and will throw an exception if used in that case.
[ScriptAttributes(NoScriptThread = true)]
public class MyCoolScript : Script
{
    ...
}


hideBackground not working?

Version
Dev mode.......... capacitor
Pkg quasar........ v1.15.0
Pkg @quasar/app... v2.1.14
Debugging......... enabled
Running mode...... IDE (manual)
Desktop (please complete the following information):

OS: windows
Browser chrome

Smartphone (please complete the following information):

Device: samsung galaxy s10
OS:  10.0
Browser
Version [e.g. 22]

Additional context
Hello.. Thank you for making a great program.
There are some strange things, so I ask you a question.
I am using the quasar framework.
My source is
methods: {
async checkPermission() {
const { BarcodeScanner } = Plugins;
const status = await BarcodeScanner.checkPermission({ force: true });
  if (status.granted) {
    // 권한이 부여 된 사용자
    return true;
  }

  return false;
},
async startScan() {
  try {
    const { BarcodeScanner } = Plugins;

    const status = await this.checkPermission();

    await BarcodeScanner.hideBackground();
    const result = await BarcodeScanner.startScan();
    if (result.hasContent) {
      alert(result.content);
    }
  } catch (error) {
    alert(error);
    console.error(error);
  }
}

When I run the scan... nothing happens.
It seems that hideBackground is not doing anything.
However, when the barcode is scanned... the barcode is output as an alert.
It works fine, but I can't see the scan screen.
Is there any other way I can try?

I set the image to none and it works fine.
Thank you..
The zxing module seems to be slow to recognize code 128..
Trying to apply another module. mlkit

There was an image on my page.
I set the image to none and it works fine.
Thank you..
The zxing module seems to be slow to recognize code 128..
Trying to apply another module. mlkit

Good to hear you got it working! If you have further questions about code 128 or anything else, please open a new issue 💯

Good to hear you got it working! If you have further questions about code 128 or anything else, please open a new issue 💯


Bug: typegen types resolving events to never in guards/actions

Description
I only have this occurring in my one machine and it's fairly difficult to reduce down to a easy reproduction as I couldn't figure out what was the same between the errors. I attached a Typescript playground illustrating the issue with the working actions/implementations commented out. (The typegen is amazing BTW, so much easier and I can remove a lot of checks, looking forward to a CLI tool ✨ )
Expected result
Event type should be correctly inferred for all actions/guards
Actual result
event is resolved to never in certain guards and actions.
Reproduction
Typescript Playground Link
Additional context
xstate 4.30.3

Huh, this is quite interesting! So it seems that the issue is within our IndexByType helper that is used behind the scenes, see this TS playground. The issue here is that it doesn't process event types that are unions correctly.
A different version of this type works OK, see here. Key remapping for mapped types was introduced in TS 4.1 though so I need to rethink compatibility implications here or figure out a different filtering strategy than using Extract. For instance, an intersection works quite OK, see here.


Error: "Interface 'PHP_CodeSniffer_Sniff' not found"

Here is how to reproduce this bug:
$ composer require --dev dealerdirect/phpcodesniffer-composer-installer
$ composer require --dev wp-coding-standards/wpcs
$ touch hi.php
$ vendor/bin/phpcs hi.php
PHP Fatal error:  Interface 'PHP_CodeSniffer_Sniff' not found in test/vendor/wp-coding-standards/wpcs/WordPress/Sniff.php on line 35
PHP Stack trace:
PHP   1. {main}() test/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() test/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Runner->init() test/vendor/squizlabs/php_codesniffer/src/Runner.php:70
PHP   4. PHP_CodeSniffer\Ruleset->__construct() test/vendor/squizlabs/php_codesniffer/src/Runner.php:294
PHP   5. PHP_CodeSniffer\Ruleset->registerSniffs() test/vendor/squizlabs/php_codesniffer/src/Ruleset.php:215
PHP   6. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/src/Ruleset.php:1103
PHP   7. include() test/vendor/squizlabs/php_codesniffer/autoload.php:167
PHP   8. spl_autoload_call() test/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php:26
PHP   9. PHP_CodeSniffer\Autoload::load() test/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php:26
PHP  10. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/autoload.php:134
PHP  11. include() test/vendor/squizlabs/php_codesniffer/autoload.php:167
PHP  12. spl_autoload_call() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionParameterSniff.php:21
PHP  13. PHP_CodeSniffer\Autoload::load() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionParameterSniff.php:21
PHP  14. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/autoload.php:134
PHP  15. include() test/vendor/squizlabs/php_codesniffer/autoload.php:167
PHP  16. spl_autoload_call() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionRestrictionsSniff.php:27
PHP  17. PHP_CodeSniffer\Autoload::load() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionRestrictionsSniff.php:27
PHP  18. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/autoload.php:134
PHP  19. include() test/vendor/squizlabs/php_codesniffer/autoload.php:167

Fatal error: Interface 'PHP_CodeSniffer_Sniff' not found in test/vendor/wp-coding-standards/wpcs/WordPress/Sniff.php on line 35

Call Stack:
    0.0002     356272   1. {main}() test/vendor/squizlabs/php_codesniffer/bin/phpcs:0
    0.0020     571776   2. PHP_CodeSniffer\Runner->runPHPCS() test/vendor/squizlabs/php_codesniffer/bin/phpcs:18
    0.0102     926232   3. PHP_CodeSniffer\Runner->init() test/vendor/squizlabs/php_codesniffer/src/Runner.php:70
    0.0139    1150960   4. PHP_CodeSniffer\Ruleset->__construct() test/vendor/squizlabs/php_codesniffer/src/Runner.php:294
    0.0143    1155472   5. PHP_CodeSniffer\Ruleset->registerSniffs() test/vendor/squizlabs/php_codesniffer/src/Ruleset.php:215
    0.0144    1155472   6. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/src/Ruleset.php:1103
    0.0149    1259496   7. include('test/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php') test/vendor/squizlabs/php_codesniffer/autoload.php:167
    0.0149    1259496   8. spl_autoload_call() test/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php:26
    0.0149    1259576   9. PHP_CodeSniffer\Autoload::load() test/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php:26
    0.0150    1260136  10. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/autoload.php:134
    0.0151    1282440  11. include('test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionParameterSniff.php') test/vendor/squizlabs/php_codesniffer/autoload.php:167
    0.0151    1282440  12. spl_autoload_call() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionParameterSniff.php:21
    0.0151    1282520  13. PHP_CodeSniffer\Autoload::load() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionParameterSniff.php:21
    0.0151    1282744  14. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/autoload.php:134
    0.0154    1328672  15. include('test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionRestrictionsSniff.php') test/vendor/squizlabs/php_codesniffer/autoload.php:167
    0.0154    1328672  16. spl_autoload_call() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionRestrictionsSniff.php:27
    0.0154    1328712  17. PHP_CodeSniffer\Autoload::load() test/vendor/wp-coding-standards/wpcs/WordPress/AbstractFunctionRestrictionsSniff.php:27
    0.0154    1328824  18. PHP_CodeSniffer\Autoload::loadFile() test/vendor/squizlabs/php_codesniffer/autoload.php:134
    0.0167    1553088  19. include('test/vendor/wp-coding-standards/wpcs/WordPress/Sniff.php') test/vendor/squizlabs/php_codesniffer/autoload.php:167

I am using the following phpcs.xml file:
<?xml version="1.0"?>
<ruleset name="PHP_CodeSniffer">
  <description />
  <file>.</file>
  <arg name="extensions" value="php,inc,lib"/>
  <rule ref="WordPress.NamingConventions.PrefixAllGlobals">
    <properties>
      <property name="prefixes" type="array" value="my_prefix,tgmpa" />
  </properties>
  </rule>
</ruleset>

Here is my version information:
$ php --version
PHP 7.1.8 (cli) (built: Aug  7 2017 15:02:45) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans
$ vendor/bin/phpcs --version
PHP_CodeSniffer version 3.1.0 (stable) by Squiz (http://www.squiz.net)
$ cat composer.json
{
    "require-dev": {
        "dealerdirect/phpcodesniffer-composer-installer": "^0.4.3",
        "wp-coding-standards/wpcs": "^0.13.1"
    }
}

I do meet the minimum requirements laid out in README.md:

The WordPress Coding Standards require PHP 5.3 or higher and PHP CodeSniffer version 2.9.0 or higher. As of version 0.13.0, the WordPress Coding Standards are compatible with PHPCS 3.0.2+. In that case, the minimum PHP requirement is PHP 5.4.

The problem is with your phpcs.xml. You need to first include the WordPress ruleset, then set the property of one of the sniffs. Adding <rule ref="WordPress" /> fixed the error for me.

@JDGrimes That does fix the error, but now, unfortunately a bunch of sniffs that I didn't want to enable are enabled.

You could try just <rule ref="WordPress-Core" /> instead, if that is more what you wanted. I don't know if there is another way to include just a particular sniff or not. Perhaps it is supposed to work like you were doing it before, and it is a bug that it doesn't. Maybe @jrfnl has some insight?

@Flimm Yes, this is a known upstream issue unfortunately. It was previously reported here (together with another upstream bug) in #1087.
The upstream issue has been reported here: https://github.com/squizlabs/PHP_CodeSniffer/issues/1582.
There are three ways to get around this bug for now:

Either - as @JDGrimes suggested - include a complete ruleset and exclude the categories/sniffs you don't want.
Or - and considering you are using Composer and the location is therefore predictable - including the WPCS autoload directive in your phpcs.xml ruleset file:<autoload>./vendor/wp-coding-standards/wpcs/WordPress/PHPCSAliases.php</autoload>

If all you want to do is check the prefixes and you don't intend to add any other sniffs to the ruleset, you could run the following command from the command line instead of using a custom ruleset:

phpcs . --standard=WordPress --sniffs=WordPress.NamingConventions.PrefixAllGlobals --runtime-set prefixes my_prefix,tgmpa --extensions=php,inc,lib

Marking this as a duplicate of #1087

Thank you so much for the explanation!

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/PHPCS-3-and-testing-individual-sniffs


Add "/help/cookies" to search index

This is now a static page in Frontend that has a special route.

 Remove cookie-details from search

 Add settings page to search-api


AWS Key ID not existed in records

I got this message, "The AWS Access Key Id you provided does not exist in our records."
And what I typed was this, " ./gof3r put -b testbucket1 -k /root/gof3r_0.4.9_linux_amd64/bbb "
I was trying to put a file to a Japanese Object Storage Service which is compatible with S3 service.
I succeeded to put a file to it using S3 command.
API key couldn't read correctly from environment variable.
Would you be kind to teach me how to fix this problem?
Where to change endpoint, access key, and secret key?
Also gof3r command is the same as go language?

If using the gof3r cli, you may specify keys via environment variables. Please see the Readme.
This tool is designed for and tested against Amazon S3. Unfortunately, I can't troubleshoot problems with other S3-compatible services.


New registration is overriding existing custom operator _smoothing_with_dim

I have installed all the latest modules required and basically untitled.py contains all the importing of modules required for handwriting_ocr.ipynb

Hi karansdoshi,
Without knowing exactly what is in untitled.py, it's very difficult for me to debug your issue.
Please provide the line of code that causes the error.

error on line 23,26,29,30,32
`import difflib
import importlib
import math
import random
import string
random.seed(123)
import cv2
import gluonnlp as nlp
import leven
import matplotlib.pyplot as plt
import matplotlib.patches as patches
import mxnet as mx
import numpy as np
from skimage import transform as skimage_tf, exposure
from tqdm import tqdm
from ocr.utils.expand_bounding_box import expand_bounding_box
from ocr.utils.sclite_helper import ScliteHelper
from ocr.utils.word_to_line import sort_bbs_line_by_line, crop_line_images
from ocr.utils.iam_dataset import IAMDataset, resize_image, crop_image, crop_handwriting_page
#from ocr.utils.encoder_decoder import Denoiser, ALPHABET, encode_char, decode_char, EOS, BOS
from ocr.utils.beam_search import ctcBeamSearch
#import ocr.utils.denoiser_utils
import ocr.utils.beam_search
#importlib.reload(ocr.utils.denoiser_utils)
#from ocr.utils.denoiser_utils import SequenceGenerator
#importlib.reload(ocr.utils.beam_search)
from ocr.utils.beam_search import ctcBeamSearch
from ocr.paragraph_segmentation_dcnn import SegmentationNetwork, paragraph_segmentation_transform
from ocr.word_and_line_segmentation import SSD as WordSegmentationNet, predict_bounding_boxes
from ocr.handwriting_line_recognition import Network as HandwritingRecognitionNet, handwriting_recognition_transform
from ocr.handwriting_line_recognition import decode as decoder_handwriting, alphabet_encoding`

What are the error messages?

[23:45:02] src/c_api/../operator/custom/custom-inl.h:57: New registration is overriding existing custom operator _smoothing_with_dim

Which file is this?


Run event in case of cancellation.

I'm writing a plugin to the graves.
If a player dies in a private area, it will not break the grave.
How to allow the player to break the grave in a private area?

A question: What do you define as a "private area"?

Also, the Listener annotation has:
https://github.com/SpongePowered/SpongeAPI/blob/master/src/main/java/org/spongepowered/api/event/Listener.java#L59
Simply specify it as false and you'll get cancelled events.

Private area - Anti Grief plugin

How to use "ignoreCancelled()"

@Listener(ignoreCancelled=true). Read up on annotations :)

I will write in a different way.
I want execute an event when his cancels other plugin.

So, just to decipher this:
You only want to handle this event if it was cancelled via the AntiGrief plugin?

Allow to break blocks on the territory of the World Guard (any Anti Grief Plugin).

@Azatik
Then what you want to do is adjust your Order to POST as well as ignoreCancelled = false
https://github.com/SpongePowered/SpongeAPI/blob/master/src/main/java/org/spongepowered/api/event/Order.java#L111
Then, if your criteria is met, setCancelled(false)

I understood.I write the result of sixteen hours.

Report.
I created two events.
EventBreakBlock:
public class EventBreakBlock {
    @Listener
    public void onEventBreakBlock(ChangeBlockEvent.Break event) {
        if (event.getCause().first(Player.class).isPresent()) {
            Player player = (Player) event.getCause().first(Player.class).get();
            Text msg = Texts.of(TextColors.DARK_RED, "Action prohibited.");
            player.sendMessage(msg);
            event.setCancelled(true);
            }
        }
    }

EventBreakBlockAllow:
public class EventBreakBlockAllow {
    @Listener(ignoreCancelled=false, order = POST)
    public void onEventBreakBlockAllow(ChangeBlockEvent.Break event) {
        if (event.getCause().first(Player.class).isPresent()) {
            Player player = (Player) event.getCause().first(Player.class).get();
            Text msg = Texts.of(TextColors.DARK_GREEN, "Action allow.");
            player.sendMessage(msg);
            event.setCancelled(false);
        }
    }
}

Result:

@Azatik you don't need to cast with event.getCause().first(Player.class).get() since passing the class will already make the return type a Player. I'll test locally and see if I can reproduce.

@Azatik I ran locally and the event isn't cancelled, so the break is occurring. I'm not seeing the problem in this case.

@gabizou It works fine.
Mini Problem: output message "Action prohibited." from event EventBreakBlock.

@Azatik yes, because the listener executed, and cancelled the event. Of course, the second listener will un-cancel it such that it's now not cancelled. This is why it's important for world protection plugins to not only have a listener for the early events to check protections, but a secondary post listener that checks if the event is still cancelled.
Your act of un cancelling the event in POST however is probably bad practice as at that point you're in a race condition of whichever listener gets the event first in the chain.

@gabizou There are better variants?

Could use BEFORE_POST. POST is intended for block monitoring plugins like Prism where they just log the activities etc.

Otherwise, this isn't an issue it seems.

I agree.


[FEATURE REQ] make the producer client share the same service bus client builder

Is your feature request related to a problem? Please describe.
Consider make the producer client share the same service bus client builder
DefaultServiceBusNamespaceProducerFactory.java
Describe the solution you'd like
The creation of physical connection to Service Bus requires resources. An application should share the connection
between clients which can be achieved by sharing the top level builder.
Refer the following:
(https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/servicebus/azure-messaging-servicebus#sharing-of-connection-between-clients)

don't think this is still valid, closing it


CockroachDB - Connection Invalidated after 30 seconds for long running query

System information:

Linux Ubuntu 19.04
DBeaver version - 6.1

Connection specification:

CockroachDB 19.1.1

Describe your question:
I am currently running a query that inserts a large amount of data into a CockroachDB table, after exactly 30 seconds of runtime, I receive the following error and the connection is invalidated and retries:-
SQL Error [08006]: An I/O error occurred while sending to the backend.
This is a fresh install of Dbeaver, with default settings.  It feels to me as if there is some sort of timeout or connection keep alive that may be causing this, is there a setting that needs to be changed in order to allow this to work?

Missing a key part of the issue, I'm using a GCP TCP Load Balancer for connection, this is where I'm experiencing the timeout as it's set by default to 30 seconds.
Connecting directly to a node resolved the issue, and then increasing the load balancer timeout fixed this through there.


server panic when sending data after connection upgrade

I'm trying to follow http://seanmonstar.com/post/172531530657/http-upgrades-with-hyper and https://github.com/hyperium/hyper/blob/master/tests/server.rs#L1084 to create a server that:

accepts a CONNECT request
creates a TcpStream to the host & port specified in the request
if that's unsuccessful return an error code
otherwise return a 200 OK and splice the client and upstream connections together

I'm seeing the following panic:
thread 'main' panicked at 'assertion failed: self.state.cached_headers.is_none()', /Users/bob/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.12.1/src/proto/h1/conn.rs:437:17

Even though I've done something like:
    let listen_addr = env::args().nth(1).unwrap_or("<IP_ADDRESS>:8081".to_string());
    let listen_addr = listen_addr.parse::<SocketAddr>().unwrap();

    // Create a TCP listener which will listen for incoming connections.
    let listener = TcpListener::bind(&listen_addr).unwrap();
    println!("Listening on: {}", listen_addr);
    ...
    let fut = listener.incoming()
        .map_err(|e| println!("error accepting socket; error = {:?}", e))
        .into_future()
        .map_err(|_| -> hyper::Error { unreachable!() })
        .and_then(|(item, _incoming)| {
            let socket = item.unwrap();
            ...
            let conn = Http::new()
                .serve_connection(socket, service_fn(move |req: Request<Body>| {
                    let upstream_addr = req.uri().authority_part().unwrap().as_str()
                                        .parse::<SocketAddr>().unwrap();
                    let upstream_conn = TcpStream::connect(&upstream_addr);
                    let mut res = Response::new(Body::empty());
                    match upstream_conn.wait() {
                        Ok(v) => *upstream_clone.borrow_mut() = Some(v),
                        Err(e) => *res.status_mut() = StatusCode::NOT_FOUND,
                    };
                    Ok::<_, hyper::Error>(res)
                }));
            ...
            let mut conn_opt = Some(conn);
            future::poll_fn(move || {
                try_ready!(conn_opt.as_mut().unwrap().poll_without_shutdown());
                Ok(conn_opt.take().unwrap().into())
            })
        });
    let client_conn = fut.wait().unwrap().into_parts().io;
    ...

I expected the .serve_connection to fire only on accept() and for the first HTTP request/response pair but after that to have underlying TcpStream object available without hyper parsing any of the requests.
I'll try to reduce this to a minimal test-case.

So, I have discovered that CONNECT requests don't actually trigger the upgrade code like responding with a 101 does. Woops!
I've got a new test for that, and a fix, which should at least get that part working. I haven't yet seen this assert triggered, though.

The newest commit to master includes a fix to treat CONNECTs as upgrades.

And the next commit after that, I believe I found what was triggering the debug assert. The connection had replied once with a response, and so cached the header map allocation to be used for a new request. Then, the connection, since it wasn't "upgraded", treated the next read bytes an HTTP parse error, trying to write a 400 response. When writing the response, the debug assert noticed I had "forgotten" to re-use the cached headers.