Add actively support to iPadOS (Safari 13+ with MSE)

According to Safari 13 RN https://developer.apple.com/documentation/safari_release_notes/safari_13_release_notes
Updated Safari for iPad to support Media Source Extensions.
Note: Safari 13 support webdrivers for automatization, see: https://webkit.org/blog/9395/webdriver-is-coming-to-safari-in-ios-13/

Don't we already detect MSE on iPad on iOS 13?

Yes, it is currently detected, but in README there is no support. Perhaps the only thing necessary is to put an indication in the README pointing to what is supported.

I've confirmed videos play fine in iOS 13, so we can just update the README.

My tests show that on iOS 13.2 iPad Safari Shaka plays MPEG-DASH fine. But for HLS it uses native HTML5 playback, not MSE. It doesn't depend on segments format (TS, MP4) or mux.js library.
I check using getVariantTracks that returns single quality when HLS is played natively.
I think that MSE should be the default option because it gives more capabilities like manual video quality selection.

streaming.useNativeHlsOnSafari doesn't work and I still getting src= playback on iPadOS 13.2:
<!DOCTYPE html>
<html>
  <head>
    <!-- Shaka Player compiled library: -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/shaka-player/2.5.5/shaka-player.compiled.js"></script>
    <script>
var manifestUri =
    'https://akamai-axtest.akamaized.net/routes/lapd-v1-acceptance/www_c4/Manifest.m3u8';

function initApp() {
  // Install built-in polyfills to patch browser incompatibilities.
  shaka.polyfill.installAll();

  // Check to see if the browser supports the basic APIs Shaka needs.
  if (shaka.Player.isBrowserSupported()) {
    // Everything looks good!
    initPlayer();
  } else {
    // This browser does not have the minimum set of APIs we need.
    alert('Browser not supported!');
  }
}

function initPlayer() {
  // Create a Player instance.
  var video = document.getElementById('video');
  var player = new shaka.Player(video);

  // Attach player to the window to make it easy to access in the JS console.
  window.player = player;

  // Listen for error events.
  player.addEventListener('error', onErrorEvent);

  player.configure('streaming.useNativeHlsOnSafari', false);

  // Try to load a manifest.
  // This is an asynchronous process.
  player.load(manifestUri).then(function() {
    // This runs if the asynchronous load is successful.
    alert(player.getVariantTracks().length);
  }).catch(onError);  // onError is executed if the asynchronous load fails.
}

function onErrorEvent(event) {
  // Extract the shaka.util.Error object from the event.
  onError(event.detail);
}

function onError(error) {
  // Log the error.
  console.error('Error code', error.code, 'object', error);
}

document.addEventListener('DOMContentLoaded', initApp);
    </script>
  </head>
  <body>
    <video id="video"
           width="640"
           poster="//shaka-player-demo.appspot.com/assets/poster.jpg"
           controls autoplay></video>
  </body>
</html>

Ok. Looks like it is not released in 2.5.5


Fix virt-handler updates VMI status phase failure bug after it recovered from crash

What this PR does / why we need it:
This fix issue mentioned in #6685
virt-handler failed process vmi if pod was removed from node but vmi stuck in running.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6685
Special notes for your reviewer:
Release note:

Hi @fanzhangio, thanks for this PR.
I've left some comments inline. And another general one - it would be good if we can recreate this scenario in a functional test, so that we can verify this fix works. Maybe using a privileged pod that deletes some virt-launcher pod directory on the host?

Thanks @zcahana , would u plz point me how to add functional test in kubevirt ?

overall looks good.  Will approve when a func test is added.

Thanks @zcahana , would u plz point me how to add functional test in kubevirt ?

@fanzhangio see tests/vmi_lifecycle_test.go for a reference and inspiration for functional test cases that simulate various failure conditions.

/ok-to-test

/test pull-kubevirt-e2e-k8s-1.20-cgroupsv2
/test pull-kubevirt-e2e-k8s-1.20-sig-network
/test pull-kubevirt-e2e-kind-1.19-vgpu
/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot

/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot

Logic looks ok to me.   Need to add some unit test.

/test pull-kubevirt-generate

/test pull-kubevirt-generate

/test pull-kubevirt-e2e-kind-1.19-vgpu

/retest-required

Which kubevirt version are you basing on?

@m14815 kubevirt 0.35

@rthallisey Ok, thanks

@m14815 are you still seeing this issue?


Location overview cards

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Original: https://www.esri.com/en-us/about/about-esri/americas
Before: https://main--esri--aemsites.hlx.live/en-us/about/about-esri/americas
After: https://location-overview--esri--aemsites.hlx.live/drafts/asimon/location-overview

The hover color doesn't match:
Live site:

Branch:

The hover color doesn't match: Live site:
Branch:

Fixed. thanks

The layout shouldn't look like this on mobile:
There should only be 1 column:

Thanks, did probably change media queries back and forth and didnt test again. Fixing it now.

I've also seen that this is used in at least one more page: https://www.esri.com/en-us/capabilities/indoor-gis/capabilities/space-planning-reservation, can you change the name to "Elastic content strip" instead? (as that's the original name and it's way more generic)

For now i've seen these two pages containing the block, which i'm in the process of uploading:

https://www.esri.com/en-us/about/about-esri/overview
https://www.esri.com/en-us/capabilities/indoor-gis/capabilities/space-planning-reservation


Inheritance hierarchy not flattened by default

According to the docs:

By default, Swashbuckle flattens inheritance hierarchies. That is, for derived models, the inherited properties are combined and listed alongside the declared properties.

However, when using the Shape-Rectange-Circle hierarchy (as in the tests), the schema generated with Swashbuckle.AspNetCore.Swagger v6.4.0 still includes the base (parent) fields via allOf.
Expected: name and typeName to end up under Circle -> properties.
Actual: allOf that references Shape is under Circle, despite not calling c.UseAllOfForInheritance() in the code.
openapi: 3.0.1
info:
  title: 'WebApplication1, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
  version: '1.0'
paths:
  /Shapes:
    get:
      tags:
        - Shapes
      operationId: GetShape
      responses:
        '200':
          description: Success
          content:
            text/plain:
              schema:
                oneOf:
                  - $ref: '#/components/schemas/Rectangle'
                  - $ref: '#/components/schemas/Circle'
            application/json:
              schema:
                oneOf:
                  - $ref: '#/components/schemas/Rectangle'
                  - $ref: '#/components/schemas/Circle'
            text/json:
              schema:
                oneOf:
                  - $ref: '#/components/schemas/Rectangle'
                  - $ref: '#/components/schemas/Circle'
components:
  schemas:
    Circle:
      type: object
      allOf:
        - $ref: '#/components/schemas/Shape'
      properties:
        radius:
          type: integer
          format: int32
      additionalProperties: false
    Rectangle:
      type: object
      allOf:
        - $ref: '#/components/schemas/Shape'
      properties:
        height:
          type: integer
          format: int32
        width:
          type: integer
          format: int32
      additionalProperties: false
    Shape:
      required:
        - typeName
      type: object
      properties:
        typeName:
          type: string
        name:
          type: string
          nullable: true
      additionalProperties: false
      discriminator:
        propertyName: typeName
        mapping:
          Rectangle: '#/components/schemas/Rectangle'
          Circle: '#/components/schemas/Circle'

Here is an (almost) minimal repro with .NET 6 (Program.cs):
using Microsoft.AspNetCore.Mvc;

var builder = WebApplication.CreateBuilder(args);

builder.Services.AddControllers();
builder.Services.AddSwaggerGen(c =>
{
    c.UseOneOfForPolymorphism();

    c.SelectDiscriminatorNameUsing((baseType) => "typeName");
    c.SelectDiscriminatorValueUsing((subType) => subType.Name);
});

var app = builder.Build();

app.UseSwagger();
app.UseSwaggerUI();

app.UseHttpsRedirection();
app.UseAuthorization();
app.MapControllers();

app.Run();

[ApiController]
[Route("[controller]")]
public class ShapesController : ControllerBase
{
    [HttpGet(Name = "GetShape")]
    public Shape GetShape() => new Rectangle {Height = 10, Width = 5};

    public abstract class Shape
    {
        public string Name { get; set; }
    }

    public class Rectangle : Shape
    {
        public int Height { get; set; }

        public int Width { get; set; }
    }

    public class Circle : Shape
    {
        public int Radius { get; set; }
    }
}

And here is the WebApplication1.csproj file:
<Project Sdk="Microsoft.NET.Sdk.Web">
    <PropertyGroup>
        <TargetFramework>net6.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
    </PropertyGroup>
    <ItemGroup>
        <PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />
        <PackageReference Include="Swashbuckle.AspNetCore.Swagger" Version="6.4.0" />
    </ItemGroup>
</Project>

I can confirm this bug occurs on v6.5.0 as well.
The issue lies in Swashbuckle.AspNetCore/src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/SchemaGenerator.cs.
Wherein if UseOneOfForPolymorphism OR UseAllOfForInheritance is set, then the other is treated as though it were enabled as well due to line 353: if (_generatorOptions.|| _generatorOptions.UseOneOfForPolymorphism).
In the current design, UseOneOfForPolymorphism relies on the fact that UseAllOfForInheritance is enabled, as it adds the discriminator properties into the BaseType and assumes these will be inherited via AllOf.
The fix is to use the current design for when both UseOneOfForPolymorphism AND UseAllOfForInheritance are enabled and to implement a new design for when only UseOneOfForPolymorphism is enabled.
This new design would need to add the discriminator properties to all the SubTypes rather than to just the BaseTypes. It may also need changes to ensure the Mapping goes to each SubType as well.

I have submitted a Pull Request #2683 that fixes this bug.

https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2683#issuecomment-2053570703

Not stale, @leth is working on it in #2940

I've rebased @danielcrabtree's code in PR #2940, but unfortunately I'm stuck now.
I don't understand the different scenarios and what works well with consuming tools in order to make a good call on how to resolve the failing unit tests well.
I think I need someone who has a better understanding of the overall picture to carry this on.


azcopy url-decodes slashes from directory names

Which version of the AzCopy was used?
10.24.0
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
azcopy copy "C:/Users/XXX/testproject/test_folder_%5C_something_wrong" "https://xxx.blob.core.windows.net/zzz?sp=racw&st=2024-07-22T10:00:55Z&se=2024-07-22T18:00:55Z&spr=https&sv=2022-11-02&sr=c&sig=abc" --recursive
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
I have some directories that have backward slashes in their names (they originally come from unix systems), so they get url encoded on my disk (therefore the %5C in the directory name).
What I am trying to do is upload them in the exact same manner, so no decoding taking place, just the plain "%5C" within the directory name.
However what is happening instead is the %5C gets replaced with a slash and then gets interpreted as a seperator, so in the storage I will get a subdirectory named "_something_wrong"
Expected: storageSource/test_folder_%5C_something_wrong
Actual: storageSource/test_folder_/_something_wrong
I have tried to do a double url encoding by renaming the directory to %255C but that didn't work either and will not be decoded at all, so it stays that way and therefore is also not a solution.
How can we reproduce the problem in the simplest way?
Create a simple folder locally with a %5C in the directory name and transfer it to an arbitrary storage container via azcopy copy.
Have you found a mitigation/solution?
No

Okay I can reproduce this on windows not on linux. I'll get back to you regarding this.

Okay I can reproduce this on windows not on linux. I'll get back to you regarding this.

Hi, are there any updates on this issue?

Hi, can you please share your debug logs for this run. Thanks!

Well, those are corporate specific logs, so this is unfortunately not possible. I thought you could reproduce this. What part of the logs do you need?

Hello @ashruti-msft, you said you can reproduce this issue. What's the next step here, this behaviour hurts pretty much because it rips our hive partitioning into pieces. Please follow up on this. I hope there will be a fix. Thanks.

Hello @ashruti-msft. I'd also like to ask if you've had the chance to look more closely into this issue. It really is a major blocker on our side. Any feedback is highly appreciated. Thanks a lot.

Hello @ashruti-msft, could you please leave a comment on your progress regarding this issue?

Hi @Data-Engineer-Joe I'll discuss this issue with the team and get back to you.

Hello @ashruti-msft  and @adreed-msft , do you have any news on the issue? It's really a major problem for us! Please give me some feedback, what do you plan or if you can offer something. Thank you.

Hi @Data-Engineer-Joe we are actively working on this issue and will be fixing this issue in our next release. Thanks!

Hi  @Data-Engineer-Joe,
Can you please try using this flag while running the command?  --disable-auto-decoding=true
False by default to enable automatic decoding of illegal chars on Windows. Can be set to true to disable automatic decoding.

Hi @Data-Engineer-Joe, Can you please try using this flag while running the command? --disable-auto-decoding=true Default value is false. To enable automatic decoding of illegal chars on Windows can be set to true to disable automatic decoding.

Hello @ashruti-msft @dphulkar-msft , thanks for the support. It took quite some time to test, but the disable-auto-decording flag is exactly what I'm looking for :-) Thanks.


Adds diesel support for Ewkb type for postgis

This additional allows for the seamless use of the Ewkb format in diesel to map to postgis geometry and geography types. Because postgis emits Ewkb for geometry types, we can make the wkb module an entrypoint into the GeoRust ecosystem and allow easy conversion to other types. While it is feasible to make any type that implements ToWkb and has a To* trait from wkb a base type in diesel, Ewkb is the most flexible because it is the base emission from postgis.

Thanks, code looks good! Could you check the failing test?


NETOBSERV-871 UI: Connection tracking query option

This PR implements connection tracking as query option

It also adds 2 new related columns:

Connection Id
Type

Listing connections:

Listing flows:

It also bring a filter capability on connection id:

And finally the ability to switch type and filter on a particular connection id from side panel:

renamed 'connection' to 'conversation' https://github.com/netobserv/network-observability-console-plugin/pull/285/commits/e264482177e759d06d48a66a18e21bf4614a308d and improved tooltips / column values display

rename updateConnection -> heartbeat + rebased

/hold for https://github.com/netobserv/network-observability-operator/pull/252

/unhold sync merge https://github.com/netobserv/network-observability-operator/pull/252 when both are ready
https://github.com/netobserv/flowlogs-pipeline/pull/387 is optionnal to remove duplicated count in connection infos

As suggested connection tracking is now optionnal.

Code looks good! /lgtm

Addressed feedback on ConnectionHeartbeatInterval renaming +  OutputRecordTypes enum

/ok-to-test

/ok-to-test

/label qe-approved

/lgtm

/approve


The window of xmake is cannot be set

I have set the xmake path using:
..\..\xmake.exe
....\xmake.exe
..\..\
....\
None of them is useful. It still warn the "access the xmake first".

relative path is not supported

for example


@conda-forge-admin,please add bot automerge

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/yaq-traits-feedstock#3.


trello list organizer

I have downloaded the chrome extension but every time I click on the icon, it takes me back to your page!  I really want to use this trello list organizer.  please help

I expect this is a duplicate of #36. Resolving in favour of a single tracking issue.

Duplicate of #36


cleaned up kruft: and hope for 310 build with rerender

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-admin, please rerender


[Improve](point query) support retry different backends in PointQuery…

…Executor
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.53 seconds
load time: 479 seconds
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230202180009_clickbench_pr_89768.html


add generated dirs to gitignore

There are a couple dirs now generated when running tests that we can ignore.
Talking with @m1sterc001guy db/ will exist after https://github.com/fedimint/fedimint/pull/1935

Codecov Report
Patch and project coverage have no change.

Comparison is base (d90fb1d) 62.51% compared to head (814be64) 62.51%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2012   +/-   ##
=======================================
  Coverage   62.51%   62.51%
=======================================
  Files         141      141
  Lines       28258    28258
=======================================
  Hits        17665    17665
  Misses      10593    10593

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Database backups are generated during tests, but should only be generated if the backup doesn't already exist. Are you seeing modifications to these files when running tests?
I'm not sure if we should ignore them from git, because eventually we should check in more backups when the database schema is changed

This PR doesn't solve the original DB issue anymore (but that was solved otherwise I assume?), but adding the other target folder for now sounds good till https://github.com/mersinvald/aquamarine/issues/38 is resolved.


Remove handler for recursive checking view visibility

https://github.com/mercadopago/px-android/blob/30e9fa7f03617e5cca1f8d173d84ac6f5d258087/testlib/src/main/java/com/mercadopago/android/testlib/idlingresource/ViewVisibilityIdlingResource.java#L56
isIdleNow() is polling by framework so I don't think we need to using handler to call recursive here

we will do it as soon as we can. Thanks


[1.12-rc3] tasks fail with "Address already in use"

After running several services, on the same port, tasks start failing with "Err": "starting container failed: Address already in use".
I am able to reproduce on this on 1.12-rc3 on Docker for Mac with the following:

Start a service with several instances.
Put the laptop to sleep.
Kick off an update -> tasks fail with described error.

Services will not run again until completely resetting the docker instance.
The following appears in the logs around the time tasks start failing:
time="2016-07-12T20:21:45Z" level=warning msg="Running modprobe nf_nat failed with message: `modprobe: WARNING: Module nf_nat not found in directory /lib/modules/4.4.14-moby`, error: exit status 1"

It is not clear that this is related.
cc @mavenugo @mrjana @thaJeztah @mgoelzer

ping @justincormack in case this is related to piñata

could you upload the diagnostics and let us know the diagnostic ID (Whale menu -> Diagnosis and Feedback -> Upload diagnostics)

FYI this seems to be a duplicate of #24486
Or at least related.

The modprobe warning is unrelated

Yes. the modprobe is unrelated to the issue. But I do think it is a dupe of #24486

@stevvooe let me close this issue in favor of #24486, which also contains additional information. I'll copy the labels to that issue


[Usage]: why vllm takes as much ram as possible ?

Your current environment
I have multiple 0.5B model running.  By default each vllm instance would take 20G ram. I understand the vllm would maintain the memory management, however I don't see why it is necessary to take that much ram so this little model.  My question is would there be some start up option to let it run in a "minimal" status ?
How would you like to use vllm
I want to run inference of a [specific model](put link here). I don't know how to integrate it with vllm.

yes, you can adapt gpu_memory_utilization

thanks


Support for SQL schema format

Recently we've switched from ruby to sql Active Record schema format. This means we currently store schema in a structure.sql file. This is done to utilize Postgres-related features, that are not currently supported by AR.
From what I can see SQL scheme format is not supported by nulldb adapter because of this code:
https://github.com/nulldb/nulldb/blob/11269e9bd7d6e0d4b9b9e3aabb0540af242100aa/lib/active_record/connection_adapters/nulldb_adapter/core.rb#L151-L168
Do you have any plans to add SQL schema format support? Do you have ideas about implementations?
Thank you!

I use that format myself in a few other projects but I don't use nulldb on them, do you want to give it a try making it work as expected and submit a PR?

I'm facing the same issue. It would be nice to have support for structure.sql.


[WIP] Updated logic for role/rolebinding reconciliation

What type of PR is this?
/kind bug
What does this PR do / why we need it:
gitops-operator 1-083_validate_apps_in_any_namespace test is being flaky.
Which issue(s) this PR fixes:
GITOPS-2874
Fixes #?
1-083_validate_apps_in_any_namespace test
How to test changes / Special notes to the reviewer:
kuttl test sequential/1-083_validate_apps_in_any_namespace shouldn't be flaky or fail anymore.

Closing this PR as it has mixed commits. Created new PR #939 for same issue.

Closing this PR as it has mixed commits. Created new PR #939 for same issue.


Not working with password protected servers

Something has been fixed recently so that it now shows a server if you start it with --redis-pass=xxxxxx but you still can't list the keys, and it doesn't work if you add a password protected server gui from within the gui.  All commands need to issue AUTH  first for this to work.

why did you close? seems to still apply. testing w/ AWS Elasticache via stunnel


Through railways include branch lines

We got some private feedback that the legend’s “Mainline track” entry is misleading because it also includes railroad tracks tagged usage=branch. OpenMapTiles doesn’t classify railways by usage=*, and this style doesn’t visually distinguish railways to the extent that this key would be very useful. (It could be useful to a more rail-centric style, however.) Though a little more verbose, “Mainline or branch line track” seems to cover our bases well enough. It doesn’t mention heavy rail, but this is implied by the presence of separate entries for light rail etc.

Was this feedback from a North American, or someone from elsewhere? I understand "mainline track" to be railway=rail with service empty. Mainline track can have any usage=*, including branch, industrial or military.

Yes, this was feedback from a North American, albeit someone deeply familiar with OSM’s railway tagging scheme. I’m not well-versed in rail in general, so “mainline” was the best I could come up with at the time in #632.

Not a rail expert, but would "Main or branch line track" still convey the same meaning a little more concisely? Or does "mainline" have to be one word?

One thing that would be neat (way beyond the scope of this PR) would be to have an option to "translate" the legend into OSM tags, so you could see which tags the style interprets into which symbols. So in this case, rather than "Mainline track" it could say "railway=rail". Would be useful for experienced OSM users coming to the style, and as mapper feedback. I have no idea if this is feasible technically since everything passes through OMT first, but I suppose we already do some of the legwork by making taginfo entries for every symbol.

Perhaps we could call railway=rail "conventional rail"? This technically excludes high-speed rail, though we don't have any of that in the Americas yet.

Not a rail expert, but would "Main or branch line track" still convey the same meaning a little more concisely? Or does "mainline" have to be one word?

Sure, we can factor out “line”.

One thing that would be neat (way beyond the scope of this PR) would be to have an option to "translate" the legend into OSM tags, so you could see which tags the style interprets into which symbols. So in this case, rather than "Mainline track" it could say "railway=rail". Would be useful for experienced OSM users coming to the style, and as mapper feedback. I have no idea if this is feasible technically since everything passes through OMT first, but I suppose we already do some of the legwork by making taginfo entries for every symbol.

Ideally, it would be up to the OSM Wiki to better associate raw tags with real-world terminology, and up to OpenMapTiles to better document how it translates raw OSM tags to its own schema. We do bake in assumptions about these translations into our taginfo project file, but it’s fragile; baking in assumptions about OSM tag semantics at the same would be even more fragile. Compounding matters, these entries don’t correspond one-to-one to OMT properties or even Americana’s own style layers. It’s very reader-centric, as any legend would be.

Perhaps we could call railway=rail "conventional rail"? This technically excludes high-speed rail, though we don't have any of that in the Americas yet.

The point of this entry is to distinguish “main” tracks in the sense of not being surrounded by lots of other tracks. That’s what we’ve styled with a little more emphasis than spurs, yard tracks, etc. The spur/yard entry is also conventional rail.


Change Type facet to a refinement list

...  so that values that are not present on the current dataset are not displayed.
This restores the behavior of the original jQuery example code.
@kokliKo

LGTM :+1:

All eslint errors are actually on other projects than the new instant-search one, so I'm merging.
@dustincoates lots of linting errors in the infinite scroll example ^^


fix: disable false positive error

SUMMARY
Disables a false positive error
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10576 into master will increase coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10576      +/-   ##
==========================================
+ Coverage   59.56%   59.68%   +0.12%
==========================================
  Files         767      767
  Lines       36268    36314      +46
  Branches     3426     3431       +5
==========================================
+ Hits        21603    21675      +72
+ Misses      14472    14447      -25
+ Partials      193      192       -1

Flag
Coverage Δ

#javascript
59.87% <ø> (-0.03%)
:arrow_down:

#python
59.57% <0.00%> (+0.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/utils/decorators.py
55.00% <0.00%> (ø)

...-frontend/src/dashboard/reducers/dashboardState.js
74.54% <0.00%> (-2.82%)
:arrow_down:

...d/src/dashboard/components/gridComponents/Tabs.jsx
68.42% <0.00%> (-2.82%)
:arrow_down:

superset/common/query_context.py
82.50% <0.00%> (-2.76%)
:arrow_down:

...tend/src/dashboard/components/DashboardBuilder.jsx
77.27% <0.00%> (-2.42%)
:arrow_down:

superset/models/alerts.py
95.23% <0.00%> (-2.39%)
:arrow_down:

superset/connectors/sqla/models.py
89.19% <0.00%> (-1.09%)
:arrow_down:

superset/tasks/schedules.py
73.23% <0.00%> (-0.93%)
:arrow_down:

superset/security/manager.py
90.00% <0.00%> (-0.65%)
:arrow_down:

superset/viz.py
57.52% <0.00%> (-0.39%)
:arrow_down:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0db0d...bf2506c. Read the comment docs.


Failed to Create an AccessEntry for Karpenter Node Role

Describe the bug
When creating an AccessEntry to be used by nodes provisioned by Karpenter autoscaler, the ACK resource keeps in this state:
status:
  ackResourceMetadata:
    arn: arn:aws:eks:us-east-1:012345678910:access-entry/cluster-eks-nprd-pnu0001324-s7/role/759021108710/karpenter-node-role-cluster-eks-nprd-pnu0001324-s7/f8c8bdf0-4831-b76a-5b34-b465b3bd4b6d
    ownerAccountID: "012345678910"
    region: us-east-1
  conditions:
  - message: |-
      InvalidParameterException: This operation can only be performed on Access Entries with a type of "STANDARD".
      {
        RespMetadata: {
          StatusCode: 400,
          RequestID: "db318416-8193-4f94-b553-0180a150b89e"
        },
        Message_: "This operation can only be performed on Access Entries with a type of \"STANDARD\"."
      }
    status: "True"
    type: ACK.Recoverable
  - lastTransitionTime: "2024-08-23T12:15:53Z"
    message: Unable to determine if desired resource state matches latest observed
      state
    reason: |-
      InvalidParameterException: This operation can only be performed on Access Entries with a type of "STANDARD".
      {
        RespMetadata: {
          StatusCode: 400,
          RequestID: "db318416-8193-4f94-b553-0180a150b89e"
        },
        Message_: "This operation can only be performed on Access Entries with a type of \"STANDARD\"."
      }
    status: Unknown
    type: ACK.ResourceSynced
  createdAt: "2024-08-22T20:56:40Z"
  modifiedAt: "2024-08-22T20:56:40Z"

Checking in CloudTrail, its possible to see that the AccessEntry was created, but the ack-eks-controller is trying to update it, which is not allowed:
Successful creation:
{
    "eventVersion": "1.09",
    "userIdentity": {
        "type": "AssumedRole",
        "principalId": "AROA3BOJO7XTFT6XXXXXX:eks-cluster-ek-ack-eks-co-a0e5ca17-7d10-4d01-995c-275765e9c280",
        "arn": "arn:aws:sts::012345678910:assumed-role/ACKRole-cluster-eks-nprd-pnu0001324-s7/eks-cluster-ek-ack-eks-co-a0e5ca17-7d10-4d01-995c-275765e9c280",
        "accountId": "012345678910",
        "accessKeyId": "ASIA3BOJO7XTCTXXXXXX",
        "sessionContext": {
            "sessionIssuer": {
                "type": "Role",
                "principalId": "AROA3BOJO7XTFT6XXXXXX",
                "arn": "arn:aws:iam::012345678910:role/ACKRole-cluster-eks-nprd-pnu0001324-s7",
                "accountId": "012345678910",
                "userName": "ACKRole-cluster-eks-nprd-pnu0001324-s7"
            },
            "attributes": {
                "creationDate": "2024-08-22T20:46:10Z",
                "mfaAuthenticated": "false"
            }
        }
    },
    "eventTime": "2024-08-22T20:56:40Z",
    "eventSource": "eks.amazonaws.com",
    "eventName": "CreateAccessEntry",
    "awsRegion": "us-east-1",
    "sourceIPAddress": "<IP_ADDRESS>",
    "userAgent": "aws-controllers-k8s/eks.services.k8s.aws-1.4.4 (GitCommit/1afb0be525003c884306f73102991dd2557c1e3d; BuildDate/2024-08-07T04:31; CRDKind/AccessEntry; CRDVersion/v1alpha1) aws-sdk-go/1.49.13 (go1.22.5; linux; amd64)",
    "requestParameters": {
        "clientRequestToken": "AE2AC76E-E7A3-438F-967A-E75E6BAXXXXX",
        "name": "cluster-eks-nprd-pnu0001324-s7",
        "type": "EC2_LINUX",
        "principalArn": "arn:aws:iam::012345678910:role/karpenter-node-role-cluster-eks-nprd-pnu0001324-s7",
        "tags": {
            "services.k8s.aws/controller-version": "eks-1.4.4",
            "services.k8s.aws/namespace": "karpenter"
        }
    },
    "responseElements": {
        "accessEntry": {
            "clusterName": "cluster-eks-nprd-pnu0001324-s7",
            "principalArn": "arn:aws:iam::012345678910:role/karpenter-node-role-cluster-eks-nprd-pnu0001324-s7",
            "kubernetesGroups": [
                "system:nodes"
            ],
            "accessEntryArn": "arn:aws:eks:us-east-1:012345678910:access-entry/cluster-eks-nprd-pnu0001324-s7/role/759021108710/karpenter-node-role-cluster-eks-nprd-pnu0001324-s7/f8c8bdf0-4831-b76a-5b34-b465b3bd4b6d",
            "createdAt":<PHONE_NUMBER>.593,
            "modifiedAt":<PHONE_NUMBER>.593,
            "tags": {
                "services.k8s.aws/controller-version": "eks-1.4.4",
                "services.k8s.aws/namespace": "karpenter"
            },
            "username": "system:node:{{EC2PrivateDNSName}}",
            "type": "EC2_LINUX"
        }
    },
    "requestID": "78bfea3f-23f1-4367-93ed-51b57942e769",
    "eventID": "e2e0e3e3-83c3-45ca-9d82-85362e548463",
    "readOnly": false,
    "eventType": "AwsApiCall",
    "managementEvent": true,
    "recipientAccountId": "012345678910",
    "eventCategory": "Management"
}

Failed update tentative by ack:
{
    "eventVersion": "1.09",
    "userIdentity": {
        "type": "AssumedRole",
        "principalId": "AROA3BOJO7XTFT6XXXXXX:eks-cluster-ek-ack-eks-co-804545b6-3848-48b5-a0c9-ed128a497a83",
        "arn": "arn:aws:sts::012345678910:assumed-role/ACKRole-cluster-eks-nprd-pnu0001324-s7/eks-cluster-ek-ack-eks-co-804545b6-3848-48b5-a0c9-ed128a497a83",
        "accountId": "012345678910",
        "accessKeyId": "ASIA3BOJO7XTPZXXXXXX",
        "sessionContext": {
            "sessionIssuer": {
                "type": "Role",
                "principalId": "AROA3BOJO7XTFT6XXXXXX",
                "arn": "arn:aws:iam::012345678910:role/ACKRole-cluster-eks-nprd-pnu0001324-s7",
                "accountId": "012345678910",
                "userName": "ACKRole-cluster-eks-nprd-pnu0001324-s7"
            },
            "attributes": {
                "creationDate": "2024-08-23T08:49:45Z",
                "mfaAuthenticated": "false"
            }
        }
    },
    "eventTime": "2024-08-23T12:32:34Z",
    "eventSource": "eks.amazonaws.com",
    "eventName": "UpdateAccessEntry",
    "awsRegion": "us-east-1",
    "sourceIPAddress": "<IP_ADDRESS>",
    "userAgent": "aws-controllers-k8s/eks.services.k8s.aws-1.4.4 (GitCommit/1afb0be525003c884306f73102991dd2557c1e3d; BuildDate/2024-08-07T04:31; CRDKind/AccessEntry; CRDVersion/v1alpha1) aws-sdk-go/1.49.13 (go1.22.5; linux; amd64)",
    "errorCode": "InvalidParameterException",
    "requestParameters": {
        "clientRequestToken": "B35794FF-2AF3-4F93-AB5B-96EB79DXXXXX",
        "name": "cluster-eks-nprd-pnu0001324-s7",
        "principalArn": "arn%3Aaws%3Aiam%3A%3A759021108710%3Arole%2Fkarpenter-node-role-cluster-eks-nprd-pnu0001324-s7"
    },
    "responseElements": {
        "message": "This operation can only be performed on Access Entries with a type of \"STANDARD\"."
    },
    "requestID": "11a808c0-d7ae-474c-ae09-1bc8ac907793",
    "eventID": "1c7df672-d6c4-491e-bdbf-cb26dd32e414",
    "readOnly": false,
    "eventType": "AwsApiCall",
    "managementEvent": true,
    "recipientAccountId": "012345678910",
    "eventCategory": "Management"
}

The YAML definition for the AccessEntry hasn't being changed and is as follows:
apiVersion: eks.services.k8s.aws/v1alpha1
kind: AccessEntry
metadata:
  name: eks-${clusterNameShort}-${cluster_env}-karpenter-ae
  namespace: karpenter
spec:
  clusterName: ${clusterName}
  type: EC2_LINUX
  principalARN: arn:aws:iam::${cluster_account}:role/karpenter-node-role-${clusterName}

Its getting deployed in the cluster by FluxCD using Kustomization.
Steps to reproduce
Just deploy the resource in the cluster. It never turns to the True SYNCED state.
$ k get accessentry -A
NAMESPACE   NAME                               CLUSTER                          TYPE        USERNAME   SYNCED    AGE
karpenter   eks-sprint6-staging-karpenter-ae   cluster-eks-nprd-pnu0001324-s7   EC2_LINUX              Unknown   39m

Expected outcome
The resource with a True SYNCED state in the cluster.
Environment
eks-controller version: 1.4.4

Kubernetes version
1.30

Using EKS (yes/no), if so version?
Yes.
eks.6

AWS service targeted (S3, RDS, etc.)
EKS (AccessEntry)

Thank you @hflobao for raising this, we'll take a look at it :)


GRPC Error: cannot parse size

Once I start the program I get a message box containing the below message.
https://i.imgur.com/2c2UqJd.jpg

Just for searchability, here is the error message in text form (don't include errors as images please)
Uncaught Exception:
Error: cannot parse size
    at ClientReadableStream._emitStatusIfDone (/Applications/Zap.app/Contents/Resources/app.asar/node_modules/grpc/src/client.js:255:19)
    at ClientReadableStream._receiveStatus (/Applications/Zap.app/Contents/Resources/app.asar/node_modules/grpc/src/client.js:233:8)
    at /Applications/Zap.app/Contents/Resources/app.asar/node_modules/grpc/src/client.js:705:12

@PJUllrich It looks like you are using the current v0.1.1-beta release from https://github.com/LN-Zap/zap-desktop/releases ?
This version is no longer functional due to recent changes to the lightning network. We will be releasing a new version soon. In the meantime if you would like to get involved in testing you can build/run the latest version of the app from the source code.

Yes that is correct! Thanks for the update. I'll run it using the source code instead then. This issue can be closed I think.


encoding/jsonschema: oneOf erroneously elides top elements

What version of CUE are you using (cue version)?

8282ca5c729908750943792ac55079bd90ec6ed5

Does this issue reproduce with the latest stable release?
Yes (v0.11.0)
What did you do?
exec cue import schema.json
exec cat schema.cue
! exec cue vet schema.cue string.cue
stderr 'invalid value "foo" \(does not satisfy matchN\): 2 matched, expected 1'

-- schema.json --
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "$defs": {
        "foo": {
            "oneOf": [
                true,
                true
            ]
        }
    },
    "$ref": "#/$defs/foo"
}

-- string.cue --
"foo"

What did you expect to see?
A passing test. No value should succeed when there are two always-pass schemas.
What did you see instead?
> exec cue import schema.json
> exec cat schema.cue
[stdout]
@jsonschema(schema="https://json-schema.org/draft/2020-12/schema")
#foo

#foo: _
> ! exec cue vet schema.cue string.cue
FAIL: /tmp/x.txtar:3: unexpected command success

Here's another variant of the same thing, involving pure type constraints this time:
exec cue import schema.json
exec cat schema.cue
! exec cue vet schema.cue string.cue
stderr 'invalid value "foo" \(does not satisfy matchN\): 2 matched, expected 1'

-- schema.json --
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "$defs": {
        "foo": {
            "oneOf": [
                {"type": "string"},
                {"type": ["string", "number"]}
            ]
        }
    },
    "$ref": "#/$defs/foo"
}

-- string.cue --
"foo"

Failure:
> exec cue import schema.json
> exec cat schema.cue
[stdout]
@jsonschema(schema="https://json-schema.org/draft/2020-12/schema")
#foo

#foo: number | string
> ! exec cue vet schema.cue string.cue
FAIL: /tmp/x.txtar:3: unexpected command success


[Bug] Cannot extend ls.multi_snippet

I tried to extend ls.multi_snippet with the following code:
local ls = require('luasnip')
local ms = ls.multi_snippet
-- Multi snippets that does not expand in string or comments ('code' snippets)
local msc = ls.extend_decorator.apply(ms, {
  common = {
    condition = -- [[ some conds ]],
    show_condition = -- [[ some conds ]],
  },
})

but get this error:
Failed to run `config` for LuaSnip
...ckages/opt/LuaSnip/lua/luasnip/util/extend_decorator.lua:26: Cannot extend this function, it was not registered! Check :h luasnip-extend_decorator for more infos.
# stacktrace:
  - /LuaSnip/lua/luasnip/util/extend_decorator.lua:26 _in_ **apply**
  - ~/.config/nvim/lua/snippets/lua.lua:22
  - ~/.config/nvim/lua/configs/LuaSnip.lua:9 _in_ **load_snippets**
  - ~/.config/nvim/lua/configs/LuaSnip.lua:25 _in_ **lazy_load_snippets**
  - ~/.config/nvim/lua/configs/LuaSnip.lua:79
  - ~/.config/nvim/lua/modules/completion.lua:83 _in_ **config**

Seems that multi-snippets cannot be extended like normal snippets? Is this intended or a bug? Thanks in advance!

Ah, it's possible we don't have that set up yet.
Take a look at the extend-decorator section in DOC.md if you want to do that yourself, it's one call that can also just happen in your config

Thanks for your prompt reply, will look into it later.

For future reference:
To register the multi-snippet function, just call ls.extend_decorator.register:
local ls = require('luasnip')
local ms = ls.multi_snippet
ls.extend_decorator.register(ms, { arg_indx = 1 }, { arg_indx = 3 })

(also added this in 1a42854, with slightly different behaviour: if apply gets a list for the first argument, the lists from apply and the one passed in the call to the decorated function are merged, while common is extended normally. I hope that is good behaviour, and not counterintuitive :D)

@L3MON4D3 Currently the common field is replaced as a whole when the passed arg has this field set instead of merging the passed arg and the extend arg, which is not expected.
To clarify, consider the following cases:
I create some luasnip conds and define a new multi-snippet that only expand if ts is not active or ts and active and the cursor is not in a comment or string:
local msc = ls.extend_decorator.apply(ms, {
  common = {
    condition = -conds.ts_active
      + -conds.in_tsnode('comment') * -conds.in_tsnode('string'),
    show_condition = -conds.ts_active
      + -conds.in_tsnode('comment') * -conds.in_tsnode('string'),
  },
})

Then I want to create a multi-snippet with regex trigger and only expand when the cursor is not in a comment or string:
msc(
  {
    common = { regTrig = true },
    { trig = '(%S?)(%s*)%.%.%s*ck' },
    { trig = '(%S?)(%s*)%.%.%s*check' },
  },
  fmta('<spc>.. ", <v>: " .. vim.inspect(<v>)', {
    spc = f(function(_, snip, _)
      return snip.captures[1] == '' and snip.captures[2]
        or snip.captures[1] .. ' '
    end, {}, {}),
    v = i(1),
  }, { repeat_duplicates = true })
)

it original condition field is then dropped because I provide the field common is the new snippet and the common field is completely replaced by the new common table i.e. { regTrig = true, condition = nil, show_condition = nil, ... }
I would suggest using vim.tbl_deep_extend to merge the common table, this fixes the issue (in function extend_multisnippet_contexts:
	-- extend ("keep") valid keyword-arguments.
	passed_arg.common = vim.tbl_deep_extend(
		"keep",
		passed_arg.common or {},
		extend_arg.common or {}
	)


Add explanatory errors for missing route data (permissions/not uploaded)

Done. See https://github.com/nelsonjchen/op-replay-clipper/commit/ebb196075000cca56ca381da5010b51ef36fb981 and similar


Append query test

Lets try this again with less issues and more success i hope.

Superseded by https://github.com/junegunn/fzf/commit/36d2bb332b87900e8178f2ec54d2cfda07f075db.


Error with reading userVisible in _onToggleVisibility

https://ptb.discord.com/channels/915186263609454632/1161759359089520690/1161767379848675438

Fixed in v0.0.4.


Response-ify Webpage

Using media queries and viewport tag make the web page response down to a width of 320px

9193ac7


TLS: supprts multi default ssl certificates

Configmap:
custom-port-domain: '443: xxx.com, 2443: yyy.com'
If the TLS client hello has not SNI and TLS server port is 443, tengine-ingress will use the default secret resource which has the domain xxx.com.
If the TLS client hello has not SNI and TLS server port is 2443, tengine-ingress will use the default secret resource which has the domain yyy.com.


[SPARK-19244][Core] Sort MemoryConsumers according to their memory usage when spilling

What changes were proposed in this pull request?
In TaskMemoryManager , when we acquire memory by calling acquireExecutionMemory and we can't acquire required memory, we will try to spill other memory consumers.
Currently, we simply iterates the memory consumers in a hash set. Normally each time the consumer will be iterated in the same order.
The first issue is that we might spill additional consumers. For example, if consumer 1 uses 10MB, consumer 2 uses 50MB, then consumer 3 acquires 100MB but we can only get 60MB and spilling is needed. We might spill both consumer 1 and consumer 2. But we actually just need to spill consumer 2 and get the required 100MB.
The second issue is that if we spill consumer 1 in first time spilling. After a while, consumer 1 now uses 5MB. Then consumer 4 may acquire some memory and spilling is needed again. Because we iterate the memory consumers in the same order, we will spill consumer 1 again. So for consumer 1, we will produce many small spilling files.
This patch modifies the way iterating the memory consumers. It sorts the memory consumers by their memory usage. So the consumer using more memory will spill first. Once it is spilled, even it acquires few memory again, in next time spilling happens it will not be the consumers to spill again if there are other consumers using more memory than it.
How was this patch tested?
Jenkins tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Test build #71446 has started for PR 16603 at commit 4c2b7b0.

Test build #71446 has finished for PR 16603 at commit 4c2b7b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71446/
Test PASSed.

Test build #71471 has started for PR 16603 at commit 070ec51.

Test build #71471 has finished for PR 16603 at commit 070ec51.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71471/
Test PASSed.

also cc @vanzin

This fix also has GC issues. Please find the screenshot attached.

@samkum Just this fix or combined with #16387?

Combined with 16387.
On Jan 18, 2017 3:54 PM, "Liang-Chi Hsieh"<EMAIL_ADDRESS>wrote:

@samkum https://github.com/samkum Just this fix or combined with #16387
https://github.com/apache/spark/pull/16387?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/16603#issuecomment-273438586, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARBhjjcmTAapQoC20Ih-1-5gid-2gg2ks5rTehFgaJpZM4Lkjq2
.

Test build #71989 has started for PR 16603 at commit 083cfb3.

ping @vanzin I think this is in better shape now. Can you also take a look? Thanks.

Test build #71989 has finished for PR 16603 at commit 083cfb3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71989/
Test PASSed.

Merged build finished. Test PASSed.

Test build #72006 has started for PR 16603 at commit 9f7c8ca.

Test build #72006 has finished for PR 16603 at commit 9f7c8ca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72006/
Test FAILed.

retest this please.

Test build #72009 has started for PR 16603 at commit 9f7c8ca.

Test build #72009 has finished for PR 16603 at commit 9f7c8ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72009/
Test PASSed.

Merged build finished. Test PASSed.

ping @vanzin @mridulm Do you have more comments on the latest change? Thanks.

@mridulm Thanks! I've addressed those comments.

Test build #72154 has started for PR 16603 at commit 3176756.

Test build #72154 has finished for PR 16603 at commit 3176756.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72154/
Test FAILed.

retest this please.

Test build #72179 has finished for PR 16603 at commit 3176756.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72179/
Test PASSed.

LGTM, will wait for @vanzin's comments before commiting in case he has any.

@mridulm Ok. Thanks for the review.

@vazin Thanks for the review.
For "fast fail", looks like we don't check if we obtain enough memory after spilling all consumers including itself. The consumer which asks more memory will decide it fails or not after this memory acquirement, based on the memory it gets. I think more proper error message is thrown in individual consumer impl. now. So I'd prefer not to add it.

Test build #72221 has started for PR 16603 at commit e41c6bd.

Test build #72221 has finished for PR 16603 at commit e41c6bd.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72221/
Test FAILed.

Thanks for the review @vanzin , I will leave this open for a day in case someone else also wants to review; and will commit tomorrow.

retest this please.

Test build #72234 has started for PR 16603 at commit e41c6bd.

Test build #72234 has finished for PR 16603 at commit e41c6bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72234/
Test PASSed.

Merged build finished. Test PASSed.

The consumer which asks more memory will decide it fails or not after this memory acquirement

Yeah, but at that point, you've already spilled a bunch of other consumers just to find out you don't have enough memory... so it's a pretty expensive failure. But probably not a big deal, hope it doesn't happen often.

@vanzin IIRC what is reported by a consumer as used need not match what it releases as freed memory in spill() right ? That seems to be the assumption made in the code atleast from what I saw.
I am not sure if used can be under or over reported w.r.t spill().

what is reported by a consumer as used need not match what it releases as freed

Right, but if even the sum of the reported used memory is not enough for the new consumer, spilling existing consumers is just causing harm. You can just report there's not enough memory without spilling anything.
But it's fine to leave that for a separate discussion, since I believe that's how the current code behaves anyway.

Thanks! @vanzin @mridulm

Merged, thanks for working on this @viirya !


Inserting a numeral into a formatted field breaks formatting

To reproduce the bug, go into a formatted field (like the credit card field or the expiration date field) and type some valid numbers. Then, insert a number into the middle of the numbers.
For example, let's say I was using the credit card field. I'll use the | operator to mark the position of the cursor. I might have filled half of it out like so:
1234 1234|

Then, If I add a number to the end of the first group of 4 numbers, this is what will happen:
12343 1234|

There are two things that are unintuitive:

The new number is not formatted as 1234 3123 4.
The cursor moves back to the end of the input field, instead of like this: 1234 3|123 4.

You can see this behavior in the example: http://stripe.github.io/jquery.payment/example/.

So, I think I unintentionally fixed the first problem, where the new digit was being grouped with the first group instead of being pushed into the second group. The problem with the cursor moving to the end is ongoing, but I'm going to track it with the more concisely-worded issue #121.


Various fixes and additions

Let me know if it makes more sense to have these as separate pull requests. :smile:

I'll have a look at this as soon as I get a chance but pretty busy these days :(

cool fixes!

No worries, @brentvatne. :+1: :sunglasses:


Cloning large repositories fails

Describe the bug
When cloning very large git repositories from GitHub, StackBlitz fails to clone it after some time.
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/BabylonJS/babylon.js
Steps to reproduce

Open the blitz
"Cloning BabylonJS/babylon.js on branch master"
"Could not clone BabylonJS/babylon.js. Please check that this repository exists and try again."

Expected behavior
It should clone the repository, but fails to do so. I presume this is because the repository in questions is over 5GB is size for a full clone.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots

Platform
Version = 1.72.0
Hash = 27729c2178447b5efac2fb0da8e0c65b16a43747
WebContainer = 33975f1d

Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 115
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; CrOS x86_64 14541.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 67637472,
  "usedJSHeapSize": 64924804,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
I can clone other repositories fine, but not BabylonJS or my fork of it (dr-vortex/babylon.js).

Hi @dr-vortex! :wave: Thanks for opening this issue!
I've created an internal ticket and we'll keep you posted :+1:

@Nemikolh  Any updates on this?


Error during sync and stop of sync after error

PGSync version:
2.1.1 and https://github.com/toluaina/pgsync/archive/refs/heads/master.zip
Postgres version:
postgres:12
Elasticsearch version:
7.14.0
Python version:
3.7.11
Problem Description:
I've setup docker-compose with database, elastic, redis and pgsync.
Then I've run tests, which run one by one, but they are making bunch of changes in database.
I see that sync is slow and sometimes I see error, after error it stops sync. In log I can see only
Polling db testing: 456 item(s)
Polling db testing: 456 item(s)
Polling db testing: 463 item(s)
Polling db testing: 463 item(s)
Polling db testing: 463 item(s)

I've tried different settings. One of set:
- ELASTICSEARCH_THREAD_COUNT=1
- ELASTICSEARCH_QUEUE_SIZE=1
- ELASTICSEARCH_STREAMING_BULK=True
- ELASTICSEARCH_MAX_RETRIES=5
- ELASTICSEARCH_INITIAL_BACKOFF=5
Error Message (if any):
`Exception in thread Thread-5:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/threading.py", line 926, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.7/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 888, in poll_redis
self.on_publish(payloads)
File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 969, in on_publish
self.sync(self._payloads(_payloads))
File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 860, in sync
self.es.bulk(self.index, docs)
File "/usr/local/lib/python3.7/site-packages/pgsync/elastichelper.py", line 104, in bulk
refresh=refresh,
File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 320, in streaming_bulk
actions, chunk_size, max_chunk_bytes, client.transport.serializer
File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 155, in _chunk_actions
for action, data in actions:
File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 692, in _payloads
payloads,
File "/usr/local/lib/python3.7/site-packages/pgsync/sync.py", line 535, in _delete
self.es.bulk(self.index, docs)
File "/usr/local/lib/python3.7/site-packages/pgsync/elastichelper.py", line 104, in bulk
refresh=refresh,
File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 339, in streaming_bulk
**kwargs
File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 256, in _process_bulk_chunk
for item in gen:
File "/usr/local/lib/python3.7/site-packages/elasticsearch/helpers/actions.py", line 187, in _process_bulk_chunk_success
raise BulkIndexError("%i document(s) failed to index." % len(errors), errors)
elasticsearch.helpers.errors.BulkIndexError: ('9 document(s) failed to index.', [{'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1916', '_version': 1, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255341, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1916', '_version': 2, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255342, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1916', '_version': 3, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255343, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1917', '_version': 1, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255344, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1917', '_version': 2, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255345, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1917', '_version': 3, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255346, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1918', '_version': 1, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255347, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1918', '_version': 2, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255348, '_primary_term': 3, 'status': 404}}, {'delete': {'_index': 'orders_list_response', '_type': '_doc', '_id': '1918', '_version': 3, 'result': 'not_found', '_shards': {'total': 2, 'successful': 1, 'failed': 0}, '_seq_no': 255349, '_primary_term': 3, 'status': 404}}])
`

Yes, all time during running tests. When run a lot of requests at  short period of time. There are create, update, delete changes.
I've tested on small database from 10-2000 items. I've tested with default options also.
Config contains schema with about 50 fields of main object and about 5 nested objects with 2-10 fields inside.
Is it possible to have logical issue with bulk updates of elastic if do create, update and delete quickly?

Can you possibly share your testing strategy?
Can this be applied to one of the existing examples?

Tests check different test cases in system.
yes, such error happened during it, if run only one query to db it works fine.

Having the same issue:


feat: add renovate config

Description
Add config file for renovate with the rules

Limit concurrent PR that renovate will created to 3
Enable vulnerability alerts

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Refactor or other

Checklist:

[ ] I have run pnpm format and my code don't have any linting issues

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Or do we want the renovate not to create any PR and we manually select what packages that should receive an updated PR?


do you have a plan to do it with pure go?

I use it to crawl the web page,with your library is vary convenient to convert a charset to another chatset,but it have a boresome problem,i can not build a binary file on my Mac,i hope that will have a pure go .

no, this project will never have a pure go iconv implementation - it's not its purpose.
As I listed before, you can do pure go transcoding with golang/x/text  for example, your single usage of my library can be replaced by the following in your proxy project:
replace
utf_body, err := iconv.NewReader(res.RawResponse.Body, "gbk", "utf-8")
if err != nil {
	log.Fatalln(err)
}

with
utf_body := simplifiedchinese.GBK.NewDecoder().Reader(res.RawResponse.Body)

after adding the import
golang.org/x/text/encoding/simplifiedchinese

thanks for your help,


TE-11.2:Added sleep after creating the flow to avoid flakiness

To avoid flakiness in TE-11.2, added sleep after creating the flow and before starting the traffic.

Pull Request Functional Test Report for #2186 / e83526484e88ecff556570a979136519eaef4b83
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

TE-11.2: Backup NHG: Multiple NH

Cisco 8000E

TE-11.2: Backup NHG: Multiple NH

Cisco XRd

TE-11.2: Backup NHG: Multiple NH

Juniper cPTX

TE-11.2: Backup NHG: Multiple NH

Nokia SR Linux

TE-11.2: Backup NHG: Multiple NH

Openconfig Lemming

TE-11.2: Backup NHG: Multiple NH

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

TE-11.2: Backup NHG: Multiple NH

Cisco 8808

TE-11.2: Backup NHG: Multiple NH

Juniper PTX10008

TE-11.2: Backup NHG: Multiple NH

Nokia 7250 IXR-10e

TE-11.2: Backup NHG: Multiple NH

Help

/gcbrun

Just for posterity
The test is being corrected as the current version of it is looking at the IXIA Port stats for sent and received packets as pass/fail criteria. This make the test flaky as the IXIA sent packets may also include ARP etc. Changes in this Pull is to update checking port stats to checking flow stats for accuracy.


Add API for prefetching the maximum request size

Avoid blocking here (and also the equivalent code for XCBConnection):
https://github.com/psychon/x11rb/blob/a1deb7e2940ce3c2c06650c7a03bddc15a250423/src/rust_connection/mod.rs#L139-L140

Same problem as with #200: A cookie cannot be saved inside a connection, because that would create a self-referential struct.
This could be worked around by only saving the raw sequence number and reconstructing the cookie only later when it is actually needed, but eugh...


(doc) Added Chocolatey Package Badge

@gep13 merged, thanks for contrinuting :+1:

@devlead now all we need is the brew version :smile:

@gep13 someone should totally fix that ;)


Mobilenet_v2_quantized predict_net.pb file possible error

TL;DR
Can't run the net using caffe2 following the 'Load Pretrained Net' tutorial. Keep showing error saying that 325 is not CPU Tensor. Fixed by changing the deserialized ascii prototxt and re-serialization.

I had posted this issue here before.
https://discuss.pytorch.org/t/caffe2-mobilenetv2-quantized-using-caffe2-blobistensortype-blob-cpu-blob-is-not-a-cpu-tensor-325/29065
After some experiments, I've discovered the problem and come up w/ a fix.
After I deserialized predict_net.pb file to ascii prototxt, I found out at the end, the network is supposed to output blob softmax instead of a Int8CPUTensor called 325. The problem, although I'm not entirely sure of on a source code basis, is probably because an Int8CPUTensor somehow fail the CAFFE_ENFORCE test.
When I change the very last line of the dumped ascii prototxt from exported_output: 325 to exported_output: softmax, everything worked just fine. So I'm thinking the file given in the official repo is not correct, at least for me.
I'm not sure if this happens to anyone else. Thought I put it here in case anyone encounters the same situation.

You can find the fixed predict_net.pb here.

@dzung-hoang Great. I've fixed MobileNet myself as well. But it's good to know there is a bug in resnet_quant, too..... I can't believe this....


Allow send with only process metrics

Corrects a bug that caused a call with only process metrics to be rejected

Thanks for contributing!


Support Linux

Perhaps this is just a documentation of putting the .so file in a separate Binaries directory, but I'm skeptical the current instructions of putting all of the libraries from the SDK into Binaries/Win64 will work
Looks like there's more documentation about how to support this here

I hope I'll get help on Linux because I have no Linux machine to test this plugin.


Don't emit debug info for generic types with no declcontext.

Follow-up to 991a66fd99741df57583597c1565306e359269d5.
rdar://problem/31482203

@swift-ci smoke test and merge


[Redshift] Error Backup execution

Description

Select in database context menu Tools> Dump Database
Choose objects to export
Press "Next"
Getting an error

https://github.com/dbeaver/dbeaver/assets/84867187/f80c10e2-2e92-405e-bdcf-410627f47bd5
DBeaver Version
23.1.5
Operating System
win 10
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

We already hide the Native Clients section on the connection page of Redshift. Because it is not clear - how well exactly pg_dump works with Redshift.
I can read the tables list (and can not reproduce the issue. You just lost your connection), but my dump process always fails with the error like:
ERROR:  syntax error at or near "stdout"
For this reason, I think we need to hide the "Backup" and "restore" buttons for Redshift. And maybe for MySQL forks, which do not support native clients to.


error

Repro steps:

Action: cosmosDB.attachEmulator
Error type: Error
Error Message: Unable to connect to local Mongo DB instance. Make sure it is started correctly. See https://aka.ms/AA5zah5 for tips.
failed to connect to server [localhost:10255] on first connect [MongoError: connect ECONNREFUSED <IP_ADDRESS>:10255]
Version: 0.11.0
OS: win32
Product: Visual Studio Code
Product Version: 1.38.0
Language: en

Call Stack
Object.<anonymous> extension.bundle.js:181:30955
a extension.bundle.js:181:30487
process._tickCallback next_tick.js:68:7

So, did you try out the suggestions in the website?  We can't help if you don't provide any information.


matomo_5: 5.1.1 -> 5.1.2

Changelog: https://matomo.org/changelog/matomo-5-1-2/
Security release

This release contains some security fixes.
A high impact security fix is included in this release, an improper request parameter validation could lead to unnecessary resource consumption
A moderate impact security improvement is also included that limits the length of annotations to 255 characters.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build matomo


firebase.extensions.storage-resize-images.v1.complete Cyrillic images names corrupted subject in event

[READ] Step 1: Are you in the right place?
Yes
[REQUIRED] Step 2: Describe your configuration

Extension name: storage-resize-images
Extension version: 0.1.28
Configuration values (redact info where appropriate):

ALLOWED_EVENT_TYPES=firebase.extensions.storage-resize-images.v1.complete

[REQUIRED] Step 3: Describe the problem
Images with Cyrillic text like "фотограія.jpg" event to Eventarc will be sent with wrong subject

P.S.
Outputs in data are fin

Steps to reproduce:

Install extension with complete event
Deploy cloud function

import {onCustomEventPublished} from "firebase-functions/v2/eventarc";

export const customhandler = onCustomEventPublished(
    "firebase.extensions.storage-resize-images.v1.complete",
    (e) => {
      console.log("it works!", JSON.stringify(e));
    }
);

Observe logs for cloud function

Expected result
Subject in event contains proper name as the filename
Actual result
Subject in event contains corrupted file name

HI @georgelviv,
Thank you for reporting this issue, I did recreate the bug successfully. It'll be added to the project board for further discussion

Blocked due to investigating as an Eventarc/CLI issue


New users can't comment - verification/LBC problem

Problems:
New users (mainly weinstein fans) join through iOS and watch videos through either the browser or app. They go to comment and discover that they can't because there's no channel associated with the user account.
The 'channel' menu item under the avatar button isn't being understood by a user and doesn't carry the same meaning as 'profile set up' for them.
Once they're directed to the 'channel' page to set up their channel/profile in order to comment they can't actually save the details they input because they have no LBC.
They therefore can't comment/engage with content.
This impacts any user who creates an account through iOS. All they can do is watch videos.
Side question: If the ability to comment is being tied to verification does this mean only users that verify their accounts can comment?

Examine first-run as well. If we can get profile setup to happen during first run, this issue is diminished.

Made a few tweaks

Added a call to action to the comment view to allow users go directly to the channel creation page.
The app will try to repeatedly claim the email verified reward until the request is successful, as opposed to the initial implementation where it was only attempted once.
Fixed the channels view to display a New Channel option when there are no channels.


Validating EC keys

It seems authlib  isn't supporting key validation for EC keys...
But in the case of ECDH-1PU, where we do a C(1e,2s) key agreement, key validation is essential (especially in the multi-recipient case) since a malicious static key could otherwise easily cause invalid curve attacks or significantly reduce the entropy of the KEM.
Could we add a key validation function?

@AnomalRoil We have added a test verifying validation of a wrong EPK point for ECDH-ES:
https://github.com/sicpa-dlab/didcomm-python/pull/17
The wrong point is caught by cryptography library which is used by Authlib. The actual validation is done by cryptography.hazmat.backends.openssl.backend.Backend._ec_key_set_public_key_affine_coordinates method and it raises ValueError("Invalid EC key.") in case of an error:
https://github.com/pyca/cryptography/blob/main/src/cryptography/hazmat/backends/openssl/backend.py#L1893
In DIDComm this exception is wrapped to (or replaced with) MalformedMessageError(MalformedMessageCode.CAN_NOT_DECRYPT).


react-native-element and react-native-paper icons no longer showing in eas build

Build/Submit details page URL
https://expo.dev/accounts/vcs-jacob/projects/VCS/builds/3ea8e2f2-f5aa-4a85-a264-1ca64d0c069e
Summary
I have several components that use react-native-paper IconButtons and react-native-element Icon components. The Icons and Buttons render perfectly fine in expo-go. I have made several builds of my app and the icons always rendered, but as of today no Icons are rendered on the build of the app. Even when I download a past build where the icons showed, they are no longer there.
Managed or bare?
Managed
Environment
npx expo start
Error output
No errors are shown
Reproducible demo or steps to reproduce from a blank project
eas build

can you see the icons when you do npx expo run:ios or npx expo run:android?

Yes, the icons are rendered correctly when I run npx expo run:android, but they are not there when I install the eas build version

I ran npx expo prebuild before I used eas build and the issue was gone, the icons rendered.

The issue has came back, icons renders with expo-dev-client build but not with eas build


BlazorMaterial with all components

As discussed in #6, here's the whole list of material.io components.

whenever one start to work in a component, create a separated issue/PR and link to this main one

[ ] animation
[ ] auto-init
[x] base
[x] button
[ ] card
[ ] checkbox
[ ] chips
[ ] dialog
[ ] dom
[x] drawer
[ ] elevation
[ ] fab
[ ] feature-targeting
[ ] floating-label
[ ] form-field
[ ] grid-list
[ ] icon-button
[ ] image-list
[ ] layout-grid
[ ] line-ripple
[ ] linear-progress
[x] list
[ ] menu
[ ] menu-surface
[ ] notched-outline
[ ] radio
[x] ripple
[ ] rtl
[ ] select
[ ] shape
[ ] slider
[ ] snackbar
[ ] switch
[ ] tab
[ ] tab-bar
[ ] tab-indicator
[ ] tab-scroller
[ ] textfield
[x] theme
[ ] toolbar
[x] top-app-bar
[x] typography

I think the first task is to refactor the CSS structure and get the updated material.io static resources.
Then, after that, update the existing components so they can use SCSS rather than compiled CSSs so people can use themes.

@galvesribeiro it seems there is library for material design components on github https://github.com/SamProf/MatBlazor
It implemented in the same way on the top of @material package. Maybe we can implement this library in another way? Without @material library and use just Blazor without JavaScript interop? For styling we can use such library: https://github.com/chanan/BlazorStyled.

Interesting... Will think about it.

@galvesribeiro If I will have time then I will prepare MR and you can review new approach


code: 'MODULE_NOT_FOUND'

C:\Users\Strider>node main.js
node:internal/modules/cjs/loader:1252
throw err;
^
Error: Cannot find module 'C:\Users\Strider\main.js'
at Function._resolveFilename (node:internal/modules/cjs/loader:1249:15)
at Function._load (node:internal/modules/cjs/loader:1075:27)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
at node:internal/main/run_main_module:36:49 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Node.js v22.11.0
I'm using only Ollama

you need to do npm install this should fix your issue
npm install

you need to do npm install this should fix your issue
npm install

i get the same error but npm install doesnt fix it

@Strider230 you should run npm install and run the bot inside the folder of mindcraft, and not your just home directory as I can see on the screenshot

i have the same issue, i did put my mindcraft folder, i ran npm install, and it gives me the same error


trace the scope as a JSON object

This is a different implementation of #45, that leaves the name of a scope a string. Instead, when tracing, we parse the name and determine the scope.
Closes #45.

We might want to cache the parsed scope class in the scope itself, not sure if it has any perf implications.

That would almost be #45 then...


fix: load sentry on all servers

See this one: https://docs.sentry.io/platforms/python/integrations/fastapi/

I think you mean for transformer PR?

@williamrusdyputra yes


Integrate LLVM at llvm/llvm-project@8bd65e5

Updates LLVM usage to match llvm/llvm-project@8bd65e5.

TOSA ops switched to DenseArrayAttr with commit llvm/llvm-project@9e1a344. The types of attributes are therfore aligned in reference implementation.
Uses std::nullopt instead of None.
Moves from llvm::makeArrayRef to ArrayRef deduction guides, see https://reviews.llvm.org/D140896.

Further updates the MLIR-HLO submodule to tensorflow/mlir-hlo@78c6dcf.

@NatashaKnk this would change reference implementation for the tosa.tile op as tileOp.getMultiplesAttr() now returns an DenseArrayAttr which is emitted as int64_t by EmitC. Would this be okay for you or do we need to handle this in a different way? I am aware that the spec still states it should be an int32_t...

This would need to be changed to match up with the TOSA spec, but since we don't have anything running off it yet I think it's okay to submit as-is and I'll send a follow-up PR. Thanks for the heads up!


feat: add ktor network plugin

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

lets keep the structure of network plugin as

network

base

ktor-network (will be published)

lib
no-lib

okhttp-network (will be published)

lib
no-lib


Added support for static tagging to java indexer. [phab:D1978]

Created by craigbarber at 2017-10-13 22:08:10:

schroederc commented inline (context lost during migration) at 2017-10-13 22:43:40:
Just use entrySets.getEmitter().emitFact(varNode, "/kythe/tag/static", "").

schroederc required changes at 2017-10-13 22:43:40

craigbarber wrote at 2017-10-16 16:27:17:

incorporated CL feedback

schroederc accepted this revision at 2017-10-16 16:28:44

craigbarber closed via commit 6cd8bb6700cfe29d01268384da1c6dca40d6f1aa at 2017-10-16 16:50:06


Refactor shortcode parsing

Our approach to managing short code is dated and uses many anti-patterns.
Each individual shortcode class must implement the ShortcodeHandler interface. This interface requires the usage of static method. Nowadays, we prefer to use the singleton pattern and use instance methods.
Short code must be registered in _config.php by making this kind of calls:
https://github.com/silverstripe/silverstripe-framework/blob/8886a3a93ddf5d9ad0b677f7403ca600894bbe00/_config.php#L14-L15
Registering shortcodes should be handle via the Injector.
Most of the logic in ShortcodeParser is dedicated to parsing BBCode shortcodes. There's libraries around for this exact purpose:

thunderer/shortcode
s9e/text-formatter

We should consider adopting them instead of maintaining our own parser.

I had a very quick look at the two libraries:

thunderer/shortcode seems very aligned with our current approach, but it hasn't been updated in two years.
s9e/text-formatter has been updated in the last month but it seems like quite a departure from the current approach. It seems to prefer a "template" approach that might not be suitable for our uses case.

Each individual shortcode class must implement the ShortcodeHandler interface.

That's not true - shortcode parsers don't even need to be classes. You only register a callback. It could even be an anonymous function with the current setup.
But yes, I agree we should offload this to a third-party library if one is available and appropriate


Documentation links are broken

Hi,
I am working on processing data in realtime and when I saw your project I thought this could be a solution(Node-red, Spark streaming other solutions).
Basically, I need to take data as input in realtime and process it and send triggers if there is any condition matched.
But when I tried to access the document it is not reachable. Can you add your document to this project or give me a link to access the documentation.
With regards,
Nithin B.

Hi Nithin,
Unfortunately Kurunt is depreciated and I'm not actively developing it anymore. I am working on a new project that improves on what Kurunt did not offer, like persistence, replication, transaction and crypto. It is not ready for release yet,
In the meantime if you're working in Node.js may I suggest Axon if you want to build something low level, or Kafka for a more feature-full solution.
Hope that helps,
Mark.


Make a voters viewer

Now we can see how much each person has voted, as per the voters.json. Not pretty style-wise, but it works.

Here's what it looks like right now:

Not sure what the numbers mean, but I'm guessing that every time chaos polls a PR, it increments the number for all voters.

I got rid of the console.logs

:+1: We can do graphics updates later, but this is a good start.

Did chaosbot crash? Its check isn't showing up.

Did chaosbot crash? Its check isn't showing up.

Looks like.

👍 We can do graphics updates later, but this is a good start.

For the graphical part, I think this list should be hidden on the index page, and show up when you click on a button ?

@MUCHZER Yeah my thought as well. Bootstrap has modals, but we're not using it. Maybe use a separate modal library?

Yeah my thought as well. Bootstrap has modals, but we're not using it. Maybe use a separate modal library?

@PlasmaPower We are using Bulma -> http://bulma.io/documentation/components/modal/
But I think modal are not UX-friendly. Something like https://codepen.io/MUCHZER/pen/WjBvoN with animation in "Hello, Chaos!" panel.

I can pull up the voters.json and view that, but not voters.html. All I'm getting there is the header. Possible bug?

@rudehn it works for me: http://chaosthebot.com/voters.html

Any error message ?

When I go to it, I don't see an error, but all I see is a heading that says "Voters on Chaos". When I look at the source, the syntax highlighting everything after the < in  for (var j = 0; j < keys.length; j++) is the color of a tag.

Found it:
 Uncaught exception: TypeError: 'Object.values' is not a function

@Smittyvb get a new browser

@Smittyvb Thanks. I will try to fix this when I got time

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values#Browser_compatibility
Probably a good idea to change it, it's currently Chrome and Firefox only.

Browser compatibility problem:  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values
Use .map() instead

Updated https://github.com/chaosbot/Chaos/issues/319

Reposting from my comment on #319:

In #354, I've switched to a monospace font for the page to make it a little bit more readable, and added a prefix to show the positions of each voter.
I'm not convinced about making it look the same as the index page or using Bulma, though - it looks quite simple as it is.


Add documentation for using scrapy playwright with CrawlSpider

It is not obvious how to use playwright when using CrawlSpider rules.

Yes, I've been thinking about adding a FAQ or "How to" section, CrawlSpider being one of the first topics.

a9061d241d0fa9f088043b9033b006f39b975c36


Links to "Desktop client developer tools" are not working

Links listed in section "Desktop client developer tools" are broken. They go to a non-existing page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 878f028a-4418-1f6c-bf27-d469b249b621
Version Independent ID: 7209b942-b6ab-e9f6-6cfd-bd5d89ea9aa8
Content: Tools and clients that connect - Azure DevOps Services & TFS - Azure DevOps
Content Source: docs/user-guide/tools.md
Product: devops
GitHub Login: @chcomley
Microsoft Alias: chcomley

Thanks so much for the heads up, @Styxxy. I've fixed these broken links and completed a PR. These fixes should go live sometime this afternoon. In the meantime, here they are:

Android Studio with the Azure DevOps Services Plug-in for Android Studio
IntelliJ with the Azure DevOps Services Plugin for IntelliJ
Visual Studio Code

Thanks again!


Improve handling of selected text in the query field

This PR improves the handling of selected text in the query field in the following cases:

When typing text, the selected query text will be replaced with the new text.
When hitting the backspace key, the selected query text will be removed.
When pasting text, the selected query text will be replaced by the new text.

This gives a bit more system feel to the query field.

Hey @p0deje, is there anything I could do to get this accepted?

@ChaosCoder I'm a bit slow to review now, but I'll look through it within the next couple of weeks.

Sure, take your time! :+1: I just hoped it could be accepted for hacktoberfest, but no worries 🙂

I've tried pulling this to test, but I don't think it behaves correctly. For example, moving the input cursor and pressing delete does nothing. Also, when I select text and then remove it by pressing delete, the selection should be dropped, but it is not.
Could you please test it more thoroughly and address at least these two issues?

Closing since there is no response. Feel free to re-open once the comments are addressed.


Can not use kube-config generated by kubespray to access k8s-dashboard

Refer to https://github.com/kubernetes/dashboard/issues/2474
Currently, the kube-config generated by kubespray doesn't have token field and can not be used to access dashboard.

Maybe we should investigate why this field is missing, and try to add this field.
If can not add this field, create a cluster-admin service account and use its' token to access dashboard is another option.

add a document to show how to access k8s dashboard. https://github.com/microsoft/pai/blob/master/docs/k8s-dashboard/access-k8s-dashboard.md.


FIX: Ngnix fails to start if upstream host for stream is unavailable/unreachable

Issue:
Currently, if the upstream host being forwarded to is down, Nginx fails to start.
Reported by @StefaBa here: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/2672#issuecomment-1475361687
Impact:
In this scenario:

All other hosts managed by NPM are now also taken out.
NPM cannot be started in order to disable or edit the host configuration in order to rectify the issue.

Solution:
Declare a variable for forwarding_host instead of simply injecting it directly into the proxy_pass directive.
Use variables for proxy_pass directive in order to prevent startup failure if the upstream host is down.
@StefaBa this one is for you. I think it should work, but I don't use this functionality, so can you please test it?

FYI: There are actually only a couple of functionally changed lines. Most of the change is indentation which I added to make the code easier for me to read.

npm still fails to start, here's a pastebin of the startup log: https://pastebin.com/XW8z4GLK
fwiw: newhost.wan.vm is currently not only offline, but also unknown to the local DNS server.
-> nslookup newhost.wan.vm currently yields:

** server can't find newhost.wan.vm: NXDOMAIN

with newhost.wan.vm being offline, but known to the local DNS server NPM does come online (both with the current :latest version and with :github-pr-2714)

Can you share what 3.conf looks like?

here you go: https://pastebin.com/eufsKe7W
i since tried recreating this stream in :github-pr-2714, but that always shows the stream as "Offline" in the web-ui, even when newhost.wan.vm is online.

Sorry, I should have been more specific - I wanted to see 3.conf generated by :github-pr-2714 to make sure I didn't screw something up.


Blue green deployment caused a downtime in our internal productive system

Description
Blue green deployment caused a downtime in our internal productive system
in our pipeline we call the piper function deployToCloudFoundry  (using the option blue green deployment) which is using the plugin blue-green-deploy   1.4.0
the scenario where the downtime occurred is the following:
the first pipeline job did the following steps:
https://gist.github.com/I816674/b2cde969edc8753b708e3f4f25b0dad3
and its MAIN LOG
https://gist.github.com/I816674/cac1afb3d1c0dd4b6eaefa06c0bddda0
in this job a green deployment succeeded and started the apps with the expected routes correctly but failed to delete/undeploy the blue apps  so both green and blue were running at the same time and then the jenkins job failed
then we executed again the pipeline, there the blue-green-deploy started by aborting the last operation and then detected that blue and green were deployed and decided for the green to be the candidate to be redeployed and this caused a downtime of our services in an internal productive system! which will would like to avoid for the next times...
here is the steps executed in the second pipeline:
https://gist.github.com/I816674/16b0a72f692908743bbe52ac49d91a5f
and its MAIN LOG
https://gist.github.com/I816674/7bb78c6f0041f09741c23bd11a142f54

The 2nd deployment showed this logging:
There are both blue and green applications already deployed for MTA "fdc-cf-service"
Assuming BLUE is the live and GREEN is the idle MTA color
Dangerous is to do an assumption here, which could be wrong and cause a downtime. In fact green has been active already.

Any updates?

They created a BI to resolve this issue which we can track:
https://sapjira.wdf.sap.corp/browse/LMCROSSITXSADEPLOY-1410

Hello,
The fix is done with:
https://github.com/cloudfoundry-incubator/multiapps-controller/pull/478
Please verify that everything is working as expected.
Best Regards,
Boyan

No updates for a while, so I'll assume that the fix is working and close this issue.


Arrow functions behave inconsistently with ordinary functions

🔎 Search Terms
Unable to get generic type, arrow function
🕗 Version & Regression Information

This is a crash
This problem exists in Nightly version
This is the behavior in every version I tried

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.2.2#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXzDigxAB4AoeK+AZQ2IRAA8TVgBneAJXBxmFLsMMLKgDmAGnhRUATwB8EytQAixKPGasO3Xv0HDRk6XMXKqAQUy5UnLSDacAFEIYAuWvRJTg6j2voASngAXnldMD4BIRFxKRkFJXknWDF2DwBvczEQDDp3eCdgsM8GAG5zKGs8dPgrbBqK6hyMAKgPItDwtoqAX0CPADccLGAK8kIQBics6ngW-JJO2bnqOAxkGHwM6Q8ARnhe80OlOZa2juLwldX4dc3t+AAjDwAmQ+Pe0+oqhtsXLwgHzqYI3VauEjHOYAemh8AAegB+KHUXz0FFUWEI5G3Kj3LbwMG4+AAL32GI+cyO-SAA
💻 Code
declare function create<
    State extends Record<string, any>,
    Data extends Record<string, any>,
    Actions extends (state: State, data: Data) => Record<string, any>,
>(args: {
   getState: () => State;
   actions: Actions;
   getData: () => Data;
}): void;

create({
    getState() {
        return { a: 1 }
    },
    getData: () => {
        return { b: 2 }
    },
    actions(state, data) {
        state
        // ^?
        data
        // ^?
        return {
            z: 1
        }
    }
})

🙁 Actual behavior
The getState and getData function types need to be consistent. For example, they are both arrow functions or ordinary functions to correctly infer the type. Otherwise, they cannot
🙂 Expected behavior
No matter what type of functions getState and getData are, the types can be correctly inferred in the actions function parameters.
Additional information about the issue
No response

Your "ordinary functions" have a hidden this parameter - so they are actually context-sensitive here. This is essentially one of the cases that this issue is about: https://github.com/microsoft/TypeScript/issues/47599


Alert issues fixed

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Exchange-Server-2013/archiveapplication-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/clean-up-the-recoverable-items-folder-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-anti-malware-policies-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-and-manage-distribution-groups-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/enable-a-customized-greeting-for-outlook-voice-access-users-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/enable-custom-prompt-recording-using-the-telephone-user-interface-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/file-formats-indexed-by-exchange-search-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/journaling-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/manage-mail-enabled-security-groups-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/my-custom-apps-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/one-or-more-active-directory-connector-servers-were-found-adcfound-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/organization-configuration-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/organization-wide-disclaimers-signatures-footers-or-headers-exchange-online-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/release-notes-for-exchange-2013-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/remote-device-wipe-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/retention-tags-and-retention-policies-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/sharing-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/working-with-command-output-exchange-2013-help.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


⚠ ClamAV has degraded performance

In 9131587, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in 4518af6.


Fix test of API surface

incorrect check require.resolve !== 'function' in test/index.js

Nice catch!  Thank you very much.


Including canCreate in if statement so that button gets removed if us…

…er isn't to be able to create new records.

Looks good, we can retarget this at a 4.x patch release branch however. If you want to do this yourself you can "Edit" next to the PR title and change the target branch to 4.4, then rebase your PR branch onto 4.4 (removing all irrelevant commits). Otherwise I can do it for you.

Totally @robbieaverill will get that done soon.

Would it be possible to do a rebase as well? 210 commits seem way too many for a change like that.

@robbieaverill @michalkleiner Apologies on the hold up.
Should be all sorted now. (:

@robbieaverill @michalkleiner any feedback on this one guys ?

The phpcs failure is unrelated to this change. Thank you!