cessationDate issue

Hi,
What would be the best way to get the cessationDate to be populated? I have carried out the below and the value returns as null on our api's.

POST directly using /self-assessment/ni/{nino}/self-employments (Add a self-employment business [test only])
PUT direclty using /self-assessment/ni/{nino}/self-employments/{selfEmploymentId} (Update a self-employment business [test only])

Both do not return any values when doing a GET directly on HMRC. Happy to supply various nino's used during tests

Unfortunately it is not currently possible to populate the cessationDate field, and as a result you will never be able to retrieve it using the GET endpoint.
When the POST and PUT APIs are eventually changed to allow this, you will be able to retrieve it.

Thanks for clarifying
On another note, If i supplied the SE ID during POST, it isnt being returned back, another one is assigned to it and returned during GET. Is that expected behaviour?

You can't supply a self-employment ID when POSTing to create a new self-employment. When you perform a POST and receive a response, you will be able to see the self-employment ID in the "Location" header. E.g.:
POST /ni/A999999AA/self-employments will return a header Location: <id> if the creation is successful.

Great, thanks.


e2e: replace IMAGE_FORMAT with RELEASE_IMAGE_LATEST

IMAGE_FORMAT is deprecating and set to an empty string in some cases

/lgtm


Can we extract the unicode into global vars so they can be named?

Can we extract the unicode into global vars so they can be named?
Alternatively, it's the future so you can just paste the character into this file :trollface:
Originally posted by @stevenpitts in https://github.com/stevenpitts/makubot/pull/276#discussion_r799885610

Solved with eeb7015


Crash at start on Android

Hello,
First of all thank you for this repository which is excellent.
I can't make it running on all my Android, either physical or simulators. It crashes at start. It works fine on iOS.
Here is the problem :
Process: com.myapplication.MyApplication, PID: 31222                                                                              java.lang.NoSuchMethodError: No virtual method textFieldColors-l59Burw(JJJJJLandroidx/compose/foundation/text/selection/TextSelectionColors;JJJJJJJJJJJJJJJJJJJJJJLandroidx/compose/runtime/Composer;IIII)Landroidx/compose/material3/TextFieldColors; in class Landroidx/compose/material3/TextFieldDefaults; or its super classes (declaration of 'androidx.compose.material3.TextFieldDefaults' appears in /data/app/~~qzAoIGcV9sAe6nS6CQvbog==/com.myapplication.MyApplication-IZWLvGUDL8YXauFwf7GS_w==/base.apk)                                                                              	at com.github.alexzhirkevich.lookandfeel.components.cupertino.CupertinoSearchTextFieldKt.cupertinoTextFieldColors-GyCwops(CupertinoSearchTextField.kt:91)                                                                              	at com.github.alexzhirkevich.lookandfeel.components.cupertino.CupertinoSearchTextFieldKt.CupertinoSearchTextField(CupertinoSearchTextField.kt:167)                                                                              	at AppKt$ScaffoldSample$2.invoke(App.kt:233)                                                                              	at AppKt$ScaffoldSample$2.invoke(App.kt:208)

Hi. Library is in early development phase and is not ready to use


Investigate scientific notation in stringified amounts from the client

When a client handles a number with sufficiently large precision, it will serialize it into scientific notation. We need to investigate how to improve the amout handling to support this format as it is deserialized.
From @rmisio:

When a number is beyond a certain threshold JSON seriaizes it in scientific notation. OB-go is not handling that format.
A listing with bigPrice: "1.890987463000000000000000001e+27" results in the error invalid item price amount.

Edit:
FWIW, this was made a launch blocker based on:
https://github.com/OpenBazaar/openbazaar-go/issues/1911#issuecomment-563396136

There may be more to the puzzle than I thought.
I save a listing with a bigPrice of 1.23456789e+26 and the server returns a 500 error with invalid item price amount, but if I refresh the listing, the price was updated.
So... I think maybe the server is properly handling the scientific notation at least enough to update the listing.
Another erroneous thing is the price is never updated in the index, it still has the old price leading to mismatch between the listing price and the one in the index (/ob/listings/:peerId).
Expectations:

The server should not kick back an error if the listing is updated.
The index should also be updated to reflect the updated listing price.

This is a necessary fix, so we need to have a plan for addressing this.

Just for some extra context here. When a number is above a certain threshold (not sure what that is other than it's pretty high), JSON will serialize it into scientific notation:
JSON.stringify({ charlie:<PHONE_NUMBER>9494949494949494949 }); // "{"charlie":9.494949494949496e+28}"

So basically that behavior must be outlined in the JSON spec.
The bigNumber.js lib used by the desktop and Haven adheres to the spec, so when serializing a bigNumber above the threshold, it will serialize it in scientific notation (albeit as a string: "9.494949494949496e+28" instead of 9.494949494949496e+28).
I'm not sure if we could customize this on the client. It's maybe possible we can override the toJSON method to not have it go into scientific notation. But, that's not really advisable IMHO because we'd be violating the JSON spec.
Since the server is accepting JSON here, ideally IMHO, they could honor the JSON spec (I do understand this is a gray area because technically string based numbers are not covered in the JSON spec, but ideally string numbers would mimic the behavior of native numbers).

Most likely will require a function to deal with the conversion. - @placer14


refactor: 💡 only pass is_success to finish_job

so that the caller does not have to know the queue job statuses.
Also: finish_job returns a boolean to say if it was in an expected state.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Codecov Report
Patch coverage: 85.00% and project coverage change: -1.55 :warning:

Comparison is base (e8f3d1c) 90.14% compared to head (c26ffc5) 88.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   90.14%   88.59%   -1.55%
==========================================
  Files         180      113      -67
  Lines        9995     5928    -4067
==========================================
- Hits         9010     5252    -3758
+ Misses        985      676     -309

Flag
Coverage Δ

jobs_cache_maintenance
99.08% <ø> (ø)

jobs_mongodb_migration
83.33% <ø> (ø)

libs_libcommon
91.30% <85.00%> (-0.10%)
:arrow_down:

services_admin
86.83% <ø> (ø)

services_api
87.17% <ø> (ø)

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libs/libcommon/src/libcommon/queue.py
88.54% <66.66%> (-1.25%)
:arrow_down:

libs/libcommon/tests/state/test_objects.py
100.00% <100.00%> (ø)

...s/libcommon/tests/state/test_plan_on_real_graph.py
100.00% <100.00%> (ø)

libs/libcommon/tests/state/utils.py
92.94% <100.00%> (ø)

libs/libcommon/tests/test_queue.py
100.00% <100.00%> (ø)

... and 67 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Xteve XMLTV output drops rating tag

Sample xmltv input to xteve:
  <programme start="20200715211500 +0000" stop="20200715230000 +0000" channel="5a66795ef91fef2c7031c599">
    <title lang="en">The Boy Downstairs</title>
    <sub-title lang="en">The Boy Downstairs</sub-title>
    <desc lang="en">Diana (Zosia Mamet, "The Kids are All Right") moves back to New York City after a few years abroad and finds the perfect apartment. Yet on the first night in her new home, she discovers that her ex-boyfriend lives in the apartment below hers.</desc>
    <date>20180216000000 +0000</date>
    <category lang="en">Independent</category>
    <rating>
      <value>PG-13</value>
    </rating>
  </programme>

What xteve outputs when using xepg:
      <programme channel="1010" start="20200715211500 +0000" stop="20200715230000 +0000">
          <title lang="en">The Boy Downstairs</title>
          <sub-title lang="en">The Boy Downstairs</sub-title>
          <desc lang="en">Diana (Zosia Mamet, "The Kids are All Right") moves back to New York City after a few years abroad and finds the perfect apartment. Yet on the first night in her new home, she discovers that her ex-boyfriend lives in the apartment below hers.</desc>
          <category lang="en">Independent</category>
          <category lang="en">Movie</category>
          <icon height="" src="http://<IP_ADDRESS>:34400/images/5017077a1a8b2747b1cd26242f274752.png" width=""></icon>
          <video></video>
          <date>20180216000000 +0000</date>
      </programme>

Note rating is dropped. Here is another sample of rating from an existing case, though curiously it's not mentioned:
https://github.com/xteve-project/xTeVe/issues/44#issuecomment-552651688
Rating is extremely useful for many purposes, including blocking children from watching, etc.
**Server / Desktop

Ubuntu 18.04.7
Intel 64 Bit
xTeVe Version 2.1.2 Build: 0121

To Reproduce
Using xepg, use a xmltv file with rating tags in it as input on the XMLTV tab
Allow xteve (or force it) to create an output xteve.xml
Notice it has dropped the Rating tag.
Expected behavior
I expect xteve to pass through the rating tag as is as it's part of the xmltv spec.
**Desktop

Browser Chrome 84.0.4147.89
Using xteve with Emby dvr

Never seen this as an issue with IPTV, but confirmed.....

The following XML tags are currently not supported.
rating, star-rating, credits
But will be implemented soon.
In your example, the attribute system is missing. According to my research, the value is not enough.
    <rating system="Australian Classification Board">
      <value>MA 15+</value>
    </rating>
    <rating system="Canadian Parental Rating">
      <value>14+</value>
    </rating>
    <rating system="Departamento de Justiça, Classificação, Títulos e Qualificação">
      <value>14</value>
    </rating>
    <rating system="Mediakasvatus- ja kuvaohjelmayksikkö">
      <value>K12</value>
    </rating>
    <rating system="Film & Publication Board">
      <value>13</value>
    </rating>
    <rating system="USA Parental Rating">
      <value>TV14</value>
    </rating>
    <rating system="VCHIP">
      <value>TV-14</value>
    </rating>
    <rating system="advisory">
      <value>Violence</value>
    </rating>

There are other valid systems near as I can tell, for example MPAA is the biggest one here in the US. According to the dtd found at https://github.com/XMLTV/xmltv/blob/master/xmltv.dtd, system is defined as "implied" which should mean optional.
Thanks for considering the request.

As it looks, Plex always uses the first entry if more are available. The language tag of the XMLTV file and the language set in Plex seems to be ignored :(

For me, am only going to put one rating per program so not an issue. I'd love the feature despite any limitation.

The missing tags are now in the beta branch:
https://github.com/xteve-project/xTeVe#xteve-beta-branch

So, I have tested this for a bit and I have had zero issue. But I only tested (and used) the rating addition, not the others as I don't use those. Working great! Thanks!


Fixes constructor for subfilter fluxes plus upgrade to OffsetArrays 1.4

Running the tests manually to see if they pass, but we should probably get CI going at some point (and register as official package...)
cc @tomchor

we'll find out :-D


Disable preflight checks if custom config path

I want to provide my own config template with receivers and routes hard coded. So currently I silence the preflight checks using:
alertmanager_routes: null
alertmanager_receivers: null
Maybe this could be builtin behaviour? I can provide a PR if needed.

PR would be much appreciated :+1:


Revise the getting started guide for devs

The getting started guide is out of date and does not work correctly.
For users, the getting started experience should be as simple as possible. The getting started guide should rely on pre-built and validated images that we publish, so that the risk of build problems across versions and environments is minimized.
There have been a lot of changes wrt how Horreum bootstraps in dev mode and the getting started guide should reflect this for developers

related to #931


rule keep-options-order

fixes #61

[x] suggestion test-cases
[x] rule implementation
[x] suggestion implementation
[x] imports
[x] docs

@sergeysova I remember, you've asked to add autofix to this rule. But personally, I'm little afraid of autofix because ESLint doesn't have any API for AST to source code transformation, so I do it manually and can break something in uncommon environments (e.g., FlowJS).
Should we replace suggestion by autofix? What do you think?

So, I'm going to merge it, but we can still add autofix in separate PR.


Tutorial jupyter notebook for data exploration and analysis

Adding fantastic tutorials on regex and pandas data exploration.

Thanks for the PR.


How to get a property?

I must be doing something very wrong, but how do I get a single property as an API call?
E.g. /store/1/categories always returns [].
Here's my data:
{
  "store": [
    {
      "id": 1,
      "categories": [
        {
          "id": 47,
          "slug": "pizza",
          "name": "Pizza"
        },
        {
          "id": 57,
          "slug": "pizza-dine-in",
          "name": "Pizza Dine In"
        },
        {
          "id": 66,
          "slug": "starters",
          "name": "Starters"
        },
        {
          "id": 69,
          "slug": "dips-items",
          "name": "Dips (Items)"
        },
        {
          "id": 70,
          "slug": "sandwiches",
          "name": "Sandwiches"
        },
        {
          "id": 71,
          "slug": "platters",
          "name": "Platters"
        },
        {
          "id": 75,
          "slug": "baked-subs",
          "name": "Baked Subs"
        },
        {
          "id": 79,
          "slug": "chicken",
          "name": "Chicken"
        },
        {
          "id": 80,
          "slug": "salad",
          "name": "Salad"
        },
        {
          "id": 82,
          "slug": "soup",
          "name": "Soup"
        },
        {
          "id": 83,
          "slug": "pasta",
          "name": "Pasta"
        },
        {
          "id": 87,
          "slug": "beverages",
          "name": "Beverages"
        },
        {
          "id": 89,
          "slug": "dessert",
          "name": "Dessert"
        },
        {
          "id": 105,
          "slug": "entrees",
          "name": "Entrees"
        },
        {
          "id": 119,
          "slug": "buffet",
          "name": "Buffet"
        }
      ]
    }
  ]
}

You're almost there, simply move categories and reference the parent store.
/store/1/categories will then filter categories using storeId. It's the same as /categories?storeId=1
{
  "store": [
    {
      "id": 1
    }
  ],
  "categories": [
      {
        "id": 47,
        "slug": "pizza",
        "name": "Pizza",
        "storeId": 1
      },
      {
        "id": 57,
        "slug": "pizza-dine-in",
        "name": "Pizza Dine In",
        "storeId": 1
      },
      ...
}

Oh, so this server expects normalized data?
I assumed you could just nest properties and get them that way.
Hmm... I'll give it a shot, but it might not be useful for me, because I'm using an actual dump of a JSON structure that's not normalized.

Ok, I see.

Thanks though, it solved my issue for now!


Pip install torch

We pip installed torch for the package Bioc ASL. See https://github.com/Bioconductor/BBS/pull/143. You should install this in the docker if it's not already installed.

torch is 750Mb. Is this really that important for one package? I'm having second thoughts because that is the same reason we don't install TensorFlow.
Downloading torch-1.11.0-cp38-cp38-manylinux1_x86_64.whl (750.6 MB)

Thanks for documenting this @jwokaty 👍🏽 I appreciate it.


Create different-id.md

create a different page for showcasing the different ids

🚀 Deployed on https://660f3b38bd22c212a29b4334--cozy-fox-0defec.netlify.app


TemplateValueHydrator::ectract gets job object

I've described how to add an additional elemet to job posting template in https://groups.google.com/d/msg/yawik/os6SC_SaOzw/GBdVBbBuAwAJ
I've noticed, that our TemplateValueHydrator::ectract method can gets a job object, which leads to an error.
Checking the instance is a short fix, but the bug is probably somewhere else
https://github.com/cross-solution/YAWIK/blob/develop/module/Jobs/src/Jobs/Entity/Hydrator/TemplateValuesHydrator.php#L78

This currently only affects optional modules. We need to refactor the addition of custom template values, but will address this in a separate issue.


Upgrading runc Dependency

Updating runc dependency from version 1.1.5 to version 1.1.13 due to security issue.

Hi @NomiCytrin thanks for the contribution. I'd not kept up with the Dependabot alerts for this repository and this PR prompted me to fix that! The vulnerability in the older runc was fixed via the bot in #382. Please either rebase this PR to bump from 1.1.12 to 1.1.13 or feel free to close it.

Great, thank you so much!
On Wed, 10 Jul 2024 at 16:01 Dave Tucker @.***> wrote:

Hi @NomiCytrin https://github.com/NomiCytrin thanks for the
contribution. I'd not kept up with the Dependabot alerts for this
repository and this PR prompted me to fix that! The vulnerability in the
older runc was fixed via the bot in #382
https://github.com/ovn-org/libovsdb/pull/382. Please either rebase this
PR to bump from 1.1.12 to 1.1.13 or feel free to close it.
—
Reply to this email directly, view it on GitHub
https://github.com/ovn-org/libovsdb/pull/380#issuecomment-2220452983,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRWBMQDPTUHXZMOG2NSSQLZLUWBPAVCNFSM6AAAAABKUSKJNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGQ2TEOJYGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Please add 1.6.0 tag at afbd403

Please add 1.6.0 tag at afbd403, one can download tarballs easily from release page.

Done!


If hot fn returns malformed response server should be more explicit on what went wrong

If function returns malformed HTTP response server returns to a user HTTP 500 Internal Server Error, but in server logs we see more verbose error:
ERRO[1283] internal server error                         action="server.handleRunnerRequest)-fm" app=testapp error="malformed HTTP status code \"established\"" id=01BTNMVEHJ08S0A00000000000 route=/hot-json stack="goroutine 1485 [running]:\nruntime/debug.Stack(0x0, 0x0, 0x0)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xbe\ngithub.com/fnproject/fn/api/server.HandleErrorResponse(0x56a8500, 0xc42056d3b0, 0x5e71918, 0xc4203b38c0, 0x5697ac0, 0xc42043c060)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/error_response.go:37 +0x4bf\ngithub.com/fnproject/fn/api/server.handleErrorResponse(0xc4203b38c0, 0x5697ac0, 0xc42043c060)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/error_response.go:24 +0xae\ngithub.com/fnproject/fn/api/server.(*Server).serve(0xc420392090, 0xc4203b38c0, 0xc4204082a8, 0x7, 0xc4204082af, 0x9)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/runner.go:109 +0x677\ngithub.com/fnproject/fn/api/server.(*Server).handleRequest(0xc420392090, 0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/runner.go:44 +0x248\ngithub.com/fnproject/fn/api/server.(*Server).handleRunnerRequest(0xc420392090, 0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/server.go:213 +0x35\ngithub.com/fnproject/fn/api/server.(*Server).(github.com/fnproject/fn/api/server.handleRunnerRequest)-fm(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/server.go:298 +0x34\ngithub.com/fnproject/fn/vendor/github.com/gin-gonic/gin.(*Context).Next(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/vendor/github.com/gin-gonic/gin/context.go:110 +0x43\ngithub.com/fnproject/fn/api/server.panicWrap(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/server.go:192 +0x51\ngithub.com/fnproject/fn/vendor/github.com/gin-gonic/gin.(*Context).Next(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/vendor/github.com/gin-gonic/gin/context.go:110 +0x43\ngithub.com/fnproject/fn/api/server.traceWrap(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/server.go:114 +0x2e9\ngithub.com/fnproject/fn/vendor/github.com/gin-gonic/gin.(*Context).Next(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/vendor/github.com/gin-gonic/gin/context.go:110 +0x43\ngithub.com/fnproject/fn/api/server.loggerWrap(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/api/server/server.go:209 +0x17c\ngithub.com/fnproject/fn/vendor/github.com/gin-gonic/gin.(*Context).Next(0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/vendor/github.com/gin-gonic/gin/context.go:110 +0x43\ngithub.com/fnproject/fn/vendor/github.com/gin-gonic/gin.(*Engine).handleHTTPRequest(0xc42009a900, 0xc4203b38c0)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/vendor/github.com/gin-gonic/gin/gin.go:344 +0x5c5\ngithub.com/fnproject/fn/vendor/github.com/gin-gonic/gin.(*Engine).ServeHTTP(0xc42009a900, 0x56a73c0, 0xc42062ea80, 0xc420138f00)\n\t/Users/denismakogon/Documents/oracle/go/src/github.com/fnproject/fn/vendor/github.com/gin-gonic/gin/gin.go:311 +0x16b\nnet/http.serverHandler.ServeHTTP(0xc420080c30, 0x56a73c0, 0xc42062ea80, 0xc420138f00)\n\t/usr/local/go/src/net/http/server.go:2619 +0x1e2\nnet/http.(*conn).serve(0xc420132820, 0x56a8440, 0xc42056e440)\n\t/usr/local/go/src/net/http/server.go:1801 +0x125d\ncreated by net/http.(*Server).Serve\n\t/usr/local/go/src/net/http/server.go:2720 +0x734\n"

We might let users know if their function fails to be good one for http format.

The type of error is: malformed HTTP status code, it comes from here, can happen if FDK writes bad output which is malformed for the protocol.

There's one way to reproduce this. Create a function without involving FDK, it should handle only default protocol (simple echo function), make that function hot with HTTP format, call it.


Implement executable challenge type

A request for use in courses was to add a new challenge type where users need to submit a file instead of a flag. This file should then be passed to a challenge script that runs it within a container and returns whether the submission was valid. The container needs to be isolated from the internet for this.
This could also be used by us for some PPC challenges where we want users to hand-craft executables for weird processor types or implement some other type of code.

#yolo ?

Maybe isolate by moving to a raspberry pi that has /root mounted ro and a ramfs and reset it after each run, or something like this? 😛

we're giving people free shells with every pwning challenge... running submitted programs is not more dangerous in any way :P
I think for this we need a base image that has a service running that allows to submit arbitrary files and run a custom testrunner script.
The question is on how to isolate the provided program. We could in theory run docker inside the challenge docker container to start unprivileged containers. The caveat of this is that we'd have to make the challenge container privileged aka. root. All other challenges run as unprivileged containers, which means we only have to trust challenge authors in a rather limited way...
What we could do is the following: Create a trusted privileged docker container for each ppc challenge, which runs a nested docker instance. The the challenge author provides

one or multiple Dockerfile(s) with the validation service
one Dockerfile specifying the container in which the submitted binaries run

The question is on how the validation service would talk to the privileged container for launching docker container...

michi hosted the challenges on his machine so we wont need this right now.


Style for represent keyboard shortcut

Describe the feature you'd like
New format for represent keyboard shortcut
Describe the benefits this feature would bring to BookStack users
If you write book on programming or how to use software, is important to have a model to represent keyboard shortcuts
Additional context
Example of Github representation of keyboard shortcut
shift + command + 3
shift + ctrl + 3

Thank for the request @Xarkam. Unfortunately there's been no further request for this in the last ~3.5 years so I don't think it'll be worth implementing. You can use the "inline code" formatting to get a similar style where needed. Even GitHub now shows a keyboard shortcuts in the same/similar style to inline code.
Will therefore close this off.


Close pull-requests

Is there a way to close pull requests via hub?

No, not right now unfortunately. We're working on improving the hub issue set of commands #1099 and my plan is to follow it up with a similar set of commands to manipulate (and close/reopen) PRs.

Would be awesome to have this to be able to make a github-flow utility similar to (Hubflow)[https://datasift.github.io/gitflow/]

hey @mislav how difficult would this be for a new contributor?

@michaellady It shouldn't be too hard if you're willing to study the GitHub API a bit and also how existing HTTP operations are implemented in github/client.go. But what are you planning to implement exactly—closing of PRs? How would that command be used on the command-line? Would one also be able to close issues? It's good to define things in detail before you proceed with trying out an implementation.

@mislav Mislav, it would be very helpful if hub command supported closing PRs. You mentioned that this is coming in the next feature release. Do you have a sense of a timeline? When can we expect it to become available?
CC: @oerling @nezihyigitbasi

@mbasmanova No clear timeline for editing/closing PRs and issues yet, sorry! Contributions welcome. In the meantime, you can use hub api like above to implement a simple script that will help you close issues/PRs.

hub api -X PATCH /repos/:user/:repo/pulls/:pr-id -F state=closed

I found an additional workaround here. If you delete the branch associated with the PR it will close the PR.
git push origin -d <branchname>


Bundle some commands into Makefile to ease devel installation.

Now typing make install would do both clean-up and installation.

Coverage remained the same at 99.038% when pulling 7703e6545e82cd36ffe406b7c5e4e36c99de2c22 on jangsutsr:makefile_update into badf9819124fb55509f1d52b89dc00aa2b81ab6f on ansible:master.


Feature/747 retry request on 5xx error

Added retry feature for HTTP requests. If a request fails with a 5xx status, it will retry for n amount of times. By default, the amount of retries is 5. It is passed as an argument to the RESTClient constructor as max_retries.
Checklist

[x] I have run nox and all the pipelines have passed.
[ ] I have made unittests according to the code I have added/modified/deleted.

Related issues
Closes #747

Linting is failing, let me fix it.


Test fix: Change CollectionModelBinderTest to update ModelMetadata.IsReadOnly

unrelated to #3482 except that I discovered the issue while investigating that issue
tests previously set BindingDetails.IsReadOnly for a Type and that was ignored
same for DictionaryModelBinderTest

:shipit: - seems like a good change

49ffeb1


132-current-testing-file-have-no-100-coverage

Descriptions

Link to UI design (if possible):

Provide screenshots or videos that the function is working.

Provide screenshots of no warning, or error in the console.

[x] All unit tests passing and coverage of testing is more than 90% unless special needs.
[x] No merge conflict with the main branch, make sure your code is up to date with main.
[x] Check PR title is aligned with your ticket.
[x] Check your app will run without crashes.
[x] Check if there are hard-coded values.
[x] No //eslint-disable-next-line no-unused-vars, unless otherwise specified.
[x] Check you are using camelCase && PascalCase correctly.
[x] Remove unused comments.

I want to recheck the test, I checkout this branch, and found:  Can you recheck your code?

I have checked the code, it is good in my local env.


Dead Link - "Advanced Usage"

In the README, the link to Advanced Usage is dead: https://github.com/rackt/react-router/tree/latest/docs/guides/advanced/README.md

Just fixed this before seeing your issue. Thanks for noticing :smile:


For inElement(true), should a click outside the dialog's backdrop cause the dialog to be dismissed?

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?

Bug - I think

What is the current behavior?

inElement-dialog is dismissed when clicking anywhere on the document - not just when clicking the backdrop

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via

http://plnkr.co/edit/aMP3kmyEK4AwnOacrIyr?p=preview
In this plunker:

click "Alert" for the top div
dialog opens in top div
click anywhere on the bottom div (not the "Alert" button)
dialog of top div is dismissed

What is the expected behavior?

Dialog of top div should not be dismissed

What is the motivation / use case for changing the behavior?

We need multiple dialogs in multiple divs open at the same time

Please tell us about your environment:

Angular version: 5.1.2
ngx-modialog: 5.0.0
bootstrap: 3.3.7
Browser: Chrome

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

I found that the click listener for the backdrop dismissal is registered on the document itself
https://github.com/shlomiassaf/ngx-modialog/blob/master/src/ngx-modialog/src/overlay/overlay.component.ts#L182
this might be correct - but inside the registered handler it is never checked if the path of the click event contains the backdrop of the current dialog.
I think the backdrop should be dismissed only when the click was within the boundaries of the backdrop

Can someone at least tell me if I am correct in assuming that the behaviour I suggested is correct? Should the dialog stay open if a click was made outside the dialog's parent?
If so, I will gladly give it a try to implement my change and submit a PR!


Provide justification analyses on calendars and AEZ to DJF deliverable

Add relevant inputs into the deliverable document.

Naming convention
Integration of the three Phase I calendars into two Phase II calendars
AEZs following boundaries

Please write the necessary parts and add relevant graphics to Sect. 2.1.1 in DJF document. It's highlighted in yellow what we expect to be added there on top of what's there already.


Xcode 6.3 Beta 2 Compatibility

Thanks!
There already is a branch for Swift 1.2 compatibility here. It's not updated to beta 2. Could you make the PR on that instead? The main branch is for production code only.


Concrete disjunction doesn't unify

What version of CUE are you using (cue version)?
cue version v0.4.1-beta.6 darwin/amd64
(same with playground: v0.4.0)
Does this issue reproduce with the latest release?
Not sure
What did you do?
cue eval the following
// A and B are assumed to be 'semantically' equivalent
A: { x: number, y: (1 | 2) + x }
B: { x: number, y: 1 + x } | { x: number, y: 2 + x }

// A valid combination for x and y that unifies with A and B
C: { x: 1, y: 3 }

// Disjunction (1 | 2) isn't resolved (while x and y are concrete)?
D: A & C

// Disjunction gets resolved
E: B & C

// Disjunction isn't resolved
F: A & B

// Concrete disjunction in y keeps 'blocking' y to become concrete
H: F & C

What did you get?
// A and B are assumed to be 'semantically' equivalent
A: {
	x: number
	y: (1 | 2) + x
}
B: {
	x: number
	y: 1 + x
} | {
	x: number
	y: 2 + x
}

// A valid combination for x and y that unifies with A and B
C: {
	x: 1
	y: 3
}

// Disjunction (1 | 2) isn't resolved (while x and y are concrete)?
D: {
	x: 1
	y: (1 | 2)+x & 3
}

// Disjunction gets resolved
E: {
	x: 1
	y: 3
}

// Disjunction isn't resolved
F: {
	x: number
	y: (1 | 2)+x & 1+x
} | {
	x: number
	y: (1 | 2)+x & 2+x
}

// Concrete disjunction in y keeps 'blocking' y to become concrete
H: {
	x: 1
	y: (1 | 2)+x & 3 & 2+x
}

What did you expect to see?
I would expect the concrete disjunction y to unify to a concrete value

// A and B are assumed to be 'semantically' equivalent
A: { x: number, y: (1 | 2) + x }
B: { x: number, y: 1 + x } | { x: number, y: 2 + x }

These are not semantically equivalent. Firstly, CUE does not do structural unification (like some logical programming languages), so an expression like (1 | 2) + x is inherently not concrete, as (1|2) will never resolve.

Thank you for looking into this issue. I'm learning more and more about CUE's semantics day by day.
And no fancy rewrites: I'm totally fine with that.
Indeed, some more aggressive reporting would keep everybody honest. Some additional documentation about which operators distribute over other operators (or not) would be welcome (only & distributes over other operators seems).

@odipar it is documented in the spec, but that is neither to be considered light reading nor necessarily the best way to learn a language.
We do plan to write something like "Effective CUE", akin to "Effective Go" where such things are expressed in a more accessible format.

Linking #1013 for the "Effective CUE" reference.


Created semantic ui template to start off in index.html; Added style.…

…css file for default styles and responsiveness; API call to Zomato successful in console with user's local coordinates.

very nice


php cs fixer comments

Description
The results of beautification are not what I expect.
seems like any comment line causes indention problems. Like the beautifier stops indenting after a comment.

This is a bug in php-cs-fixer, not atom-beautify.
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/2694


Cannot "electronize init" without following Error

Version: API and CLI 8.31.2 on .NET Core 3.1

Target: Windows 10

Description: I can't "electronize init" my project without getting the error shown in the picture provided.

Steps to Reproduce:

Create a new Project
Do what is described in README.md
run "electronize init"
and I get the mentioned error.

I'm currently having the same issue.

in my case, i was a folder before the right one, so maybe you have to move on one folder.


BadSubscriptionIdInvalid for nodes with SamplingInterval of 100ms

Hi,

After running without problems for months the publisher stops monitoring the Tags with a sampling interval of 100ms, the ones with sampling interval of 1000ms keep coming in.
So, the subscription of the 100ms nodes is stopped, the other one (1000ms sampling interval) remains.
Any idea how to prevent this from happening?
Thanks!
Regards

Hi @dcrupel,  we'll look into this.

Hi @dcrupel, could you share which version of the publisher you were using? Did you update at some point in time? Are there any other things that changed?

Hi @dcrupel,
I had this same problem but only when i connected to the machine via middleware (Kepware). When connected to the machine directly i could use sample rates of 50ms without any problems. Have you done some testing with different OPC UA servers?
Regards

Hi @dcrupel,
I had this same problem but only when i connected to the machine via middleware (Kepware). When connected to the machine directly i could use sample rates of 50ms without any problems. Have you done some testing with different OPC UA servers?
Regards

Hi @dcrupel,
I had this same problem but only when i connected to the machine via middleware (Kepware). When connected to the machine directly i could use sample rates of 50ms without any problems. Have you done some testing with different OPC UA servers?
Regards

Hi @dcrupel,
I had this same problem but only when i connected to the machine via middleware (Kepware). When connected to the machine directly i could use sample rates of 50ms without any problems. Have you done some testing with different OPC UA servers?
Regards

Yes, It is a Kepware problem so this has nothing to do with the OPC publisher. I'll close this issue.

I'm in contact with the developers of Kepware on this issue. If there is any progress I'll send you an update.


[Activation] Node does not advance after failed Coinstake signature verification

My node has stopped syncing after block 448135.
After a bit of debugging I found out that block 448136 (the next block) contains an UTXO which which fails signature verification here:
private bool VerifySignature(UnspentOutputs coin, Transaction txTo, int txToInN, ScriptVerify flagScriptVerify)
{
    this.logger.LogTrace("({0}:'{1}/{2}',{3}:{4},{5}:{6})", nameof(coin), coin.TransactionId, coin.Height, nameof(txToInN), txToInN, nameof(flagScriptVerify), flagScriptVerify);

    TxIn input = txTo.Inputs[txToInN];

    if (input.PrevOut.N >= coin.Outputs.Length)
        return false;

This then causes the peers that contains the blocks, to be banned and as such my node does not advance (rightly so).
I suspect that this issue relates to the incorrect shutdown problem and/or the stake store load error?
For whatever reason my node cannot process my block data at height 448136.
@dangershony @noescape00 @Aprogiena

Could this just be because my data is corrupt due to previously mentioned bugs?

@fassadlr Can you add the specific txid failing verification to this thread? And what are the values that the trace log is logging on entry to the method?

Update:
From my logs it appears that when I connected to IP <IP_ADDRESS>, which is an older Stratis X node (<IP_ADDRESS>), block validation failed and the peer got banned. However, even though I was connected to other peers with higher versions and/or block heights it failed to advance.
I'm investigating why.


nested components in Story.block ?

Hi!
Any ideas how we should document this kind of %Story{}?
<.tabs>
  <.tab is_active to="/">Home</.tab>
  <.tab link_type="a" to="/" label="About" />
</.tabs>

I've tried block:
defmodule BrmblWeb.Storybook.Components.Navigation.Tabs do
  use PhxLiveStorybook.Entry, :component

  import BrmblWeb.UI.Navigation.Tabs

  def function, do: &BrmblWeb.UI.Navigation.Tabs.tabs/1

  def stories do
    [
      %Story{
        id: :tabs,
        attributes: %{},
        block: """
        <.tab is_active to="/" label="Tab1" />
        <.tab to="/hi" label="Tab2" />
        """
      }
    ]
  end
end

Which yields an opaque error:
Compiling 2 files (.ex)

== Compilation error in file lib/brmbl_web/storybook.ex ==
** (CompileError) lib/brmbl_web/storybook.ex: an error occured while rendering story tabs
    (stdlib 3.17.2) lists.erl:1358: :lists.mapfoldl/3
    (stdlib 3.17.2) lists.erl:1359: :lists.mapfoldl/3
    (stdlib 3.17.2) lists.erl:1358: :lists.mapfoldl/3
    (phoenix_live_view 0.17.11) expanding macro: Phoenix.LiveView.Helpers.inner_block/2

Confirmed that plain old HTML inside a block works fine:
  def stories do
    [
      %Story{
        id: :tabs,
        attributes: %{},
        block: """
        hi
        hi
        """
      }
    ]
  end

Can we (do we need to) use sigil_H inside our story definitions?

can you try using a fully qualified name in your block?
%Story{
  id: :tabs,
  attributes: %{},
  block: """
  <BrmblWeb.UI.Navigation.Tabs.tab is_active to="/" label="Tab1" />
  <BrmblWeb.UI.Navigation.Tabs.tab to="/hi" label="Tab2" />
  """
}

That gets it to compile
The generated story remains verbose however:
<.tabs>
  <BrmblWeb.UI.Navigation.Tabs.tab is_active to="/" label="Tab1" />
<BrmblWeb.UI.Navigation.Tabs.tab to="/hi" label="Tab2" />
<./tabs>

(indentation appears broken, but Ive noticed that elsewhere)

Thanks for that - this un-blocks me for now!

Ok I’ll improve it so that all functions in your component are automatically imported.
I’ll also check with indentation
Le 31 août 2022 à 09:31 +0200, Glenn Roberts @.***>, a écrit :

That gets it to compile
The generated story remains verbose however:
<.tabs>
<BrmblWeb.UI.Navigation.Tabs.tab is_active to="/" label="Tab1" />
<BrmblWeb.UI.Navigation.Tabs.tab to="/hi" label="Tab2" />
<./tabs>
(indentation appears broken, but Ive noticed that elsewhere)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

An entry example using new custom aliases / imports
defmodule NestedComponent do
  use PhxLiveStorybook.Entry, :component
  def function, do: &NestedComponent.nested_component/1

  def aliases, do: [MyStorybook.Helpers.JSHelpers]
  def imports, do: [{NestedComponent, nested: 1}]

  def stories do
    [
      %Story{
        id: :default,
        block: """
        <.nested phx-click={JSHelpers.toggle()}>hello</.nested>
        <.nested phx-click={JSHelpers.toggle()}>world</.nested>
        """
      }
    ]
  end
end

proper slots indentation 👌

@cblavier just spotted this. Awesome stuff mate.
You got a release candidate, or some other tag we can pull from?

no release now, still a few tickets to ship.
In the meantime you can pull main branch. The issue is that, since it's not a proper hex release, you won't have the assets
in your mix.exs :
defp deps do
  [{:phx_live_storybook, github: "phenixdigital/phx_live_storybook"}]
end

then from your shell
mix deps.get
cd deps/phx_live_storybook
mix deps.get
npm ci --prefix assets
mix assets.build

you should be ready to go, and take care of recent changes in router.ex (see CHANGELOG.md)

yeah I spotted those changes in the Changelog. I gave it a stab yesterday, but the assets were tripping me up. Thanks a bunch for the workaround!


Mapster issue 3.1.8

The below mapping was working before 3.1.8
.Map(dest => dest.Texts, src => from i in src.Texts
where i.TextValue != null || src.IncludeNullValue == true
select new TextModel()
{
TextId = i.TextId, Value = i.TextValue
});
But now it is giving an error.
Getting the error
variable '' of type '' referenced from scope '', but it is not defined

Sorry for taking very long time to reply, I did unit test as you describe, but it works fine. Could you provide reproducible test?


Add unit tests to the client and fix related bugs

This PR adds unit tests for the types and the functions in the API Client.
When testing, several bugs were identified, leading to the implementation of the following modifications:

Add a missing optional keyword to the UpdateGridpoolOrderRequest protobuf definition
Make the GridpoolOrderFilter, GridpoolTradeFilter and PublicTradeFilter types hashable, as they are used as keys in combination with the gridpool_id in the streaming functions
Refactor some protofub timestamps that were falsly returning None values in the client
Add error handling in the client for the gRPC errors that could be raised by the service

NOTE: The last commit ("Remove _lists suffixes) will be removed once the changes in #59 are merged.


Don't depend on exact versions of dependencies

Hi.
Because unimport requires pathspec==0.8.1, it cannot be installed alongside the latest black, which requires patchspec>=0.9. The same applies to all other dependencies, e.g., I would like to update to typing-extensions <IP_ADDRESS>, but I cannot cause unimport wants exactly <IP_ADDRESS>.
Could you please allow a broader range of versions in setup.py? This is actually a standard practice for python libraries/tools that one installs as a part of a project, see e.g., pytest, isort, and black.

Hi,
Thank you for reporting the issue.


remove that ugly border from quick-input icon

Appears when we click on the quick-input button.

P.S. See bottom-right

Will work on it

hey, i've worked on a similar issue before. Can i work on this? I'll send a PR by tonight.

I am working on it kindly look for some other issue @ptechofficial

I am working on it kindly look for some other issue @ptechofficial

yeah okay.


doc: remove unneeded comma

IMO the comma after the first word is not needed.

/kind cleanup

Page preview:
https://deploy-preview-28343--kubernetes-io-master-staging.netlify.app/docs/concepts/scheduling-eviction/taint-and-toleration/

/lgtm

/approve


[Fixes #136] Made Some UI Enhancements to the README file

Fixes #136

Added avatar images to the admin and mentors section
Added Color boxes to display the color of the respective hexadecimal code

Here are the screenshots of the same:


[1.17.1] what is mm? Mod 'MoreCommands' (morecommands) 3.9.2 requires version 2.3 or later of mm, which is missing!

not sure, maybe I am stupid but I can not find the dependency named MM in the mod description.
net.fabricmc.loader.impl.FormattedException: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
	 - Install mm, version 2.3 or later.
Unmet dependency listing:
	 - Mod 'MoreCommands' (morecommands) 3.9.2 requires version 2.3 or later of mm, which is missing!
Inactive mods:
	 - mod 'Advancements Enlarger' (advancements-enlarger) 0.2.4, reason: wrong environment (client/server only)
	 - mod 'Break Progress' (breakprogress) 1.0.1, reason: wrong environment (client/server only)
	 - mod 'Better Sodium Video Settings Button' (bsvsb) 2.0.4, reason: wrong environment (client/server only)
	 - mod 'cAn i MiNe thIS bLOCk?' (can-i-mine-this-block) 1.1.0, reason: wrong environment (client/server only)
	 - mod 'Disable Custom Worlds Advice' (disable_custom_worlds_advice) 1.4, reason: wrong environment (client/server only)
	 - mod 'Enhanced Block Entities' (enhancedblockentities) 0.5+1.17, reason: wrong environment (client/server only)
	 - mod 'I Know What I'm Doing' (iknowwhatimdoing) 4.0.0, reason: wrong environment (client/server only)
	 - mod 'Konkrete' (konkrete) 1.3.0, reason: wrong environment (client/server only)
	 - mod 'Light Overlay' (lightoverlay) 6.0.1, reason: wrong environment (client/server only)
	 - mod 'Mod Menu' (modmenu) 2.0.14, reason: wrong environment (client/server only)
	 - mod 'MoreTooltips' (more_tooltips) 1.0.2, reason: wrong environment (client/server only)
	 - mod 'Mouse Tweaks' (mousetweaks) 2.15, reason: wrong environment (client/server only)
	 - mod 'No Potion Offset' (no-potion-offset) ${version}, reason: wrong environment (client/server only)
	 - mod 'Ok Zoomer' (okzoomer) 5.0.0-beta.3+1.17.1, reason: wrong environment (client/server only)
	 - mod 'Pling' (pling) 1.5.0, reason: wrong environment (client/server only)
	 - mod 'Reese's Sodium Options' (reeses-sodium-options) 1.2.3, reason: wrong environment (client/server only)
	 - mod 'WMITAF' (wmitaf) 1.2.0, reason: wrong environment (client/server only)
	 - mod 'Runtime Resource Pack' (advanced_runtime_resource_pack) 0.2.9, reason: newer version active
	 - mod 'Runtime Resource Pack' (advanced_runtime_resource_pack) 0.3.7, reason: newer version active
	 - mod 'Auto Config v1 Updated' (autoconfig1u) 3.2.2, reason: newer version active
	 - mod 'jankson' (blue_endless_jankson) 1.2.1, reason: same version active
	 - mod 'jankson' (blue_endless_jankson) 1.2.1, reason: same version active
	 - mod 'Cardinal Components API (base)' (cardinal-components-base) 3.0.0-nightly.1.17-pre1, reason: newer version active
	 - mod 'Cardinal Components API (base)' (cardinal-components-base) 3.0.0-nightly.1.17-pre2, reason: newer version active
	 - mod 'Cardinal Components API (base)' (cardinal-components-base) 3.0.0, reason: newer version active
	 - mod 'Cardinal Components API (blocks)' (cardinal-components-block) 3.0.0, reason: newer version active
	 - mod 'Cardinal Components API (entities)' (cardinal-components-entity) 3.0.0-nightly.1.17-pre1, reason: newer version active
	 - mod 'Cardinal Components API (entities)' (cardinal-components-entity) 3.0.0-nightly.1.17-pre2, reason: newer version active
	 - mod 'Cardinal Components API (entities)' (cardinal-components-entity) 3.0.0, reason: newer version active
	 - mod 'Cardinal Components API (utilities)' (cardinal-components-util) 3.0.0-nightly.1.17-pre2, reason: newer version active
	 - mod 'Cardinal Components API (worlds)' (cardinal-components-world) 3.0.0, reason: newer version active
	 - mod 'Cloth Basic Math' (cloth-basic-math) 0.5.1, reason: newer version active
	 - mod 'Cloth Common Events v1' (cloth-common-events-v1) 1.5.47, reason: newer version active
	 - mod 'Cloth Config v6' (cloth-config) 6.1.48, reason: unknown
	 - mod 'Cloth Config v4' (cloth-config2) 4.11.18, reason: newer version active
	 - mod 'Cloth Config v4' (cloth-config2) 5.0.33, reason: newer version active
	 - mod 'Cloth Config v4' (cloth-config2) 5.0.34, reason: newer version active
	 - mod 'Cloth Config v5' (cloth-config2) 5.0.38, reason: newer version active
	 - mod 'Cloth Scissors API v1' (cloth-scissors-api-v1) 2.0.54, reason: wrong environment (client/server only)
	 - mod 'core' (com_electronwill_night-config_core) 3.6.2, reason: newer version active
	 - mod 'core' (com_electronwill_night-config_core) 3.6.3, reason: newer version active
	 - mod 'core' (com_electronwill_night-config_core) 3.6.5, reason: same version active
	 - mod 'toml' (com_electronwill_night-config_toml) 3.6.2, reason: newer version active
	 - mod 'toml' (com_electronwill_night-config_toml) 3.6.3, reason: newer version active
	 - mod 'toml' (com_electronwill_night-config_toml) 3.6.5, reason: same version active
	 - mod 'toml4j' (com_moandjiezana_toml_toml4j) +, reason: newer version active
	 - mod 'Custom Portal Api' (customportalapi) 0.0.1-beta45-1.17, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.1.3+12a8474cfa, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.1.3+12a8474c34, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.3.0+a02b446318, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.3.0+a02b446313, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.3.0+a02b446318, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.4.0+5847535018, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.4.0+cf39a74318, reason: same version active
	 - mod 'Fabric BlockRenderLayer Registration (v1)' (fabric-blockrenderlayer-v1) 1.1.6+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Command API (v1)' (fabric-command-api-v1) 1.1.2+6cefd57718, reason: newer version active
	 - mod 'Fabric Command API (v1)' (fabric-command-api-v1) 1.1.3+5ab9934c18, reason: newer version active
	 - mod 'Fabric Entity Events (v1)' (fabric-entity-events-v1) 1.2.0+8a9f12e018, reason: newer version active
	 - mod 'Fabric Entity Events (v1)' (fabric-entity-events-v1) 1.2.1+077fc48418, reason: newer version active
	 - mod 'Fabric Item API (v1)' (fabric-item-api-v1) 1.2.4+a02b446318, reason: newer version active
	 - mod 'Fabric Key Binding API (v1)' (fabric-key-binding-api-v1) 1.0.4+a02b446318, reason: wrong environment (client/server only)
	 - mod 'Fabric Key Binding API (v1)' (fabric-key-binding-api-v1) 1.0.6+2a2bb57318, reason: wrong environment (client/server only)
	 - mod 'Fabric Key Bindings (v0)' (fabric-keybindings-v0) 0.2.4+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Lifecycle Events (v1)' (fabric-lifecycle-events-v1) 1.4.4+a02b446318, reason: newer version active
	 - mod 'Fabric Models (v0)' (fabric-models-v0) 0.3.1+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Networking API (v1)' (fabric-networking-api-v1) 1.0.14+cf39a74318, reason: newer version active
	 - mod 'Fabric Networking (v0)' (fabric-networking-v0) 0.3.2+92519afa13, reason: newer version active
	 - mod 'Fabric Renderer API (v1)' (fabric-renderer-api-v1) 0.4.5+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Renderer - Indigo' (fabric-renderer-indigo) 0.4.9+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Renderer Registries (v1)' (fabric-renderer-registries-v1) 3.2.6+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Rendering (v0)' (fabric-rendering-v0) 1.1.7+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Rendering (v1)' (fabric-rendering-v1) 1.6.0+a02b446318, reason: wrong environment (client/server only)
	 - mod 'Fabric Rendering (v1)' (fabric-rendering-v1) 1.10.1+377137cc18, reason: wrong environment (client/server only)
	 - mod 'Fabric Resource Loader (v0)' (fabric-resource-loader-v0) 0.4.7+b7ab612118, reason: newer version active
	 - mod 'Fabric Resource Loader (v0)' (fabric-resource-loader-v0) 0.4.10+f09604ce18, reason: same version active
	 - mod 'Fabric Screen API (v1)' (fabric-screen-api-v1) 1.0.5+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Tag Extensions (v0)' (fabric-tag-extensions-v0) 1.2.3+cf39a74318, reason: same version active
	 - mod 'Fabric Textures (v0)' (fabric-textures-v0) 1.0.7+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Hologram API' (hologram-api) 0.2.0+1.17.1, reason: newer version active
	 - mod 'libaddict' (libaddict) 0.3.0, reason: wrong environment (client/server only)
	 - mod 'LibBlockAttributes' (libblockattributes) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Core)' (libblockattributes_core) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Core)' (libblockattributes_core) 0.9.0, reason: same version active
	 - mod 'LibBlockAttributes (Fluids)' (libblockattributes_fluids) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Fluids)' (libblockattributes_fluids) 0.9.0, reason: same version active
	 - mod 'LibBlockAttributes (Items)' (libblockattributes_items) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Items)' (libblockattributes_items) 0.9.0, reason: same version active
	 - mod 'LibCapableData' (libcd) 3.0.3+1.16.3, reason: same version active
	 - mod 'LibGui' (libgui) 4.1.0+1.17, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.1+1.17.1-rc1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.2+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.3+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.4+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.6+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.2.1+1.17.1, reason: newer version active
	 - mod 'Magna' (magna) 0.4.0-1.17.1, reason: newer version active
	 - mod 'megane-dml-simulacrum' (megane-dml-simulacrum) 5.6.1+1.0.5, reason: unknown
	 - mod 'Myron' (myron) 1.6.1-1.17.1, reason: newer version active
	 - mod 'OmegaConfig' (omega-config) 1.0.4, reason: newer version active
	 - mod 'OmegaConfig' (omega-config) 1.0.4, reason: newer version active
	 - mod 'Packet Tweaker' (packet_tweaker) 0.2.0-1.17-pre1, reason: newer version active
	 - mod 'Patchouli' (patchouli) 1.17.1-56-FABRIC, reason: newer version active
	 - mod 'Patchouli' (patchouli) 1.17.1-56-FABRIC-SNAPSHOT, reason: newer version active
	 - mod 'Fabric Placeholder API' (placeholder-api) 1.0.1+1.17, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.3.0-nightly.1.17-pre1, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.3.0-nightly.1.17-rc1, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.3.0, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.4.0, reason: same version active
	 - mod 'Reborn Core' (reborncore) 5.0.11-beta, reason: same version active
	 - mod 'Server Translations API' (server_translations_api) 1.4.5+1.17, reason: newer version active
	 - mod 'Somnus API' (somnus) 0.0.13-1.17.1, reason: newer version active
	 - mod 'Statement Vanilla Compatibility Module' (statement_vanilla_compatibility) 1.0.1+1.14.4-1.15.2, reason: newer version active
	 - mod 'Step Height Entity Attribute' (step-height-entity-attribute) 1.0.0, reason: same version active
	 - mod 'Energy' (team_reborn_energy) 0.1.1, reason: newer version active
	 - mod 'Trinkets' (trinkets) 3.0.4, reason: same version active
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:189)
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:142)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71)
	at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:66)
Caused by: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
	 - Install mm, version 2.3 or later.
Unmet dependency listing:
	 - Mod 'MoreCommands' (morecommands) 3.9.2 requires version 2.3 or later of mm, which is missing!
Inactive mods:
	 - mod 'Advancements Enlarger' (advancements-enlarger) 0.2.4, reason: wrong environment (client/server only)
	 - mod 'Break Progress' (breakprogress) 1.0.1, reason: wrong environment (client/server only)
	 - mod 'Better Sodium Video Settings Button' (bsvsb) 2.0.4, reason: wrong environment (client/server only)
	 - mod 'cAn i MiNe thIS bLOCk?' (can-i-mine-this-block) 1.1.0, reason: wrong environment (client/server only)
	 - mod 'Disable Custom Worlds Advice' (disable_custom_worlds_advice) 1.4, reason: wrong environment (client/server only)
	 - mod 'Enhanced Block Entities' (enhancedblockentities) 0.5+1.17, reason: wrong environment (client/server only)
	 - mod 'I Know What I'm Doing' (iknowwhatimdoing) 4.0.0, reason: wrong environment (client/server only)
	 - mod 'Konkrete' (konkrete) 1.3.0, reason: wrong environment (client/server only)
	 - mod 'Light Overlay' (lightoverlay) 6.0.1, reason: wrong environment (client/server only)
	 - mod 'Mod Menu' (modmenu) 2.0.14, reason: wrong environment (client/server only)
	 - mod 'MoreTooltips' (more_tooltips) 1.0.2, reason: wrong environment (client/server only)
	 - mod 'Mouse Tweaks' (mousetweaks) 2.15, reason: wrong environment (client/server only)
	 - mod 'No Potion Offset' (no-potion-offset) ${version}, reason: wrong environment (client/server only)
	 - mod 'Ok Zoomer' (okzoomer) 5.0.0-beta.3+1.17.1, reason: wrong environment (client/server only)
	 - mod 'Pling' (pling) 1.5.0, reason: wrong environment (client/server only)
	 - mod 'Reese's Sodium Options' (reeses-sodium-options) 1.2.3, reason: wrong environment (client/server only)
	 - mod 'WMITAF' (wmitaf) 1.2.0, reason: wrong environment (client/server only)
	 - mod 'Runtime Resource Pack' (advanced_runtime_resource_pack) 0.2.9, reason: newer version active
	 - mod 'Runtime Resource Pack' (advanced_runtime_resource_pack) 0.3.7, reason: newer version active
	 - mod 'Auto Config v1 Updated' (autoconfig1u) 3.2.2, reason: newer version active
	 - mod 'jankson' (blue_endless_jankson) 1.2.1, reason: same version active
	 - mod 'jankson' (blue_endless_jankson) 1.2.1, reason: same version active
	 - mod 'Cardinal Components API (base)' (cardinal-components-base) 3.0.0-nightly.1.17-pre1, reason: newer version active
	 - mod 'Cardinal Components API (base)' (cardinal-components-base) 3.0.0-nightly.1.17-pre2, reason: newer version active
	 - mod 'Cardinal Components API (base)' (cardinal-components-base) 3.0.0, reason: newer version active
	 - mod 'Cardinal Components API (blocks)' (cardinal-components-block) 3.0.0, reason: newer version active
	 - mod 'Cardinal Components API (entities)' (cardinal-components-entity) 3.0.0-nightly.1.17-pre1, reason: newer version active
	 - mod 'Cardinal Components API (entities)' (cardinal-components-entity) 3.0.0-nightly.1.17-pre2, reason: newer version active
	 - mod 'Cardinal Components API (entities)' (cardinal-components-entity) 3.0.0, reason: newer version active
	 - mod 'Cardinal Components API (utilities)' (cardinal-components-util) 3.0.0-nightly.1.17-pre2, reason: newer version active
	 - mod 'Cardinal Components API (worlds)' (cardinal-components-world) 3.0.0, reason: newer version active
	 - mod 'Cloth Basic Math' (cloth-basic-math) 0.5.1, reason: newer version active
	 - mod 'Cloth Common Events v1' (cloth-common-events-v1) 1.5.47, reason: newer version active
	 - mod 'Cloth Config v6' (cloth-config) 6.1.48, reason: unknown
	 - mod 'Cloth Config v4' (cloth-config2) 4.11.18, reason: newer version active
	 - mod 'Cloth Config v4' (cloth-config2) 5.0.33, reason: newer version active
	 - mod 'Cloth Config v4' (cloth-config2) 5.0.34, reason: newer version active
	 - mod 'Cloth Config v5' (cloth-config2) 5.0.38, reason: newer version active
	 - mod 'Cloth Scissors API v1' (cloth-scissors-api-v1) 2.0.54, reason: wrong environment (client/server only)
	 - mod 'core' (com_electronwill_night-config_core) 3.6.2, reason: newer version active
	 - mod 'core' (com_electronwill_night-config_core) 3.6.3, reason: newer version active
	 - mod 'core' (com_electronwill_night-config_core) 3.6.5, reason: same version active
	 - mod 'toml' (com_electronwill_night-config_toml) 3.6.2, reason: newer version active
	 - mod 'toml' (com_electronwill_night-config_toml) 3.6.3, reason: newer version active
	 - mod 'toml' (com_electronwill_night-config_toml) 3.6.5, reason: same version active
	 - mod 'toml4j' (com_moandjiezana_toml_toml4j) +, reason: newer version active
	 - mod 'Custom Portal Api' (customportalapi) 0.0.1-beta45-1.17, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.1.3+12a8474cfa, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.1.3+12a8474c34, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.3.0+a02b446318, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.3.0+a02b446313, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.3.0+a02b446318, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.4.0+5847535018, reason: newer version active
	 - mod 'Fabric API Base' (fabric-api-base) 0.4.0+cf39a74318, reason: same version active
	 - mod 'Fabric BlockRenderLayer Registration (v1)' (fabric-blockrenderlayer-v1) 1.1.6+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Command API (v1)' (fabric-command-api-v1) 1.1.2+6cefd57718, reason: newer version active
	 - mod 'Fabric Command API (v1)' (fabric-command-api-v1) 1.1.3+5ab9934c18, reason: newer version active
	 - mod 'Fabric Entity Events (v1)' (fabric-entity-events-v1) 1.2.0+8a9f12e018, reason: newer version active
	 - mod 'Fabric Entity Events (v1)' (fabric-entity-events-v1) 1.2.1+077fc48418, reason: newer version active
	 - mod 'Fabric Item API (v1)' (fabric-item-api-v1) 1.2.4+a02b446318, reason: newer version active
	 - mod 'Fabric Key Binding API (v1)' (fabric-key-binding-api-v1) 1.0.4+a02b446318, reason: wrong environment (client/server only)
	 - mod 'Fabric Key Binding API (v1)' (fabric-key-binding-api-v1) 1.0.6+2a2bb57318, reason: wrong environment (client/server only)
	 - mod 'Fabric Key Bindings (v0)' (fabric-keybindings-v0) 0.2.4+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Lifecycle Events (v1)' (fabric-lifecycle-events-v1) 1.4.4+a02b446318, reason: newer version active
	 - mod 'Fabric Models (v0)' (fabric-models-v0) 0.3.1+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Networking API (v1)' (fabric-networking-api-v1) 1.0.14+cf39a74318, reason: newer version active
	 - mod 'Fabric Networking (v0)' (fabric-networking-v0) 0.3.2+92519afa13, reason: newer version active
	 - mod 'Fabric Renderer API (v1)' (fabric-renderer-api-v1) 0.4.5+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Renderer - Indigo' (fabric-renderer-indigo) 0.4.9+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Renderer Registries (v1)' (fabric-renderer-registries-v1) 3.2.6+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Rendering (v0)' (fabric-rendering-v0) 1.1.7+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Rendering (v1)' (fabric-rendering-v1) 1.6.0+a02b446318, reason: wrong environment (client/server only)
	 - mod 'Fabric Rendering (v1)' (fabric-rendering-v1) 1.10.1+377137cc18, reason: wrong environment (client/server only)
	 - mod 'Fabric Resource Loader (v0)' (fabric-resource-loader-v0) 0.4.7+b7ab612118, reason: newer version active
	 - mod 'Fabric Resource Loader (v0)' (fabric-resource-loader-v0) 0.4.10+f09604ce18, reason: same version active
	 - mod 'Fabric Screen API (v1)' (fabric-screen-api-v1) 1.0.5+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Fabric Tag Extensions (v0)' (fabric-tag-extensions-v0) 1.2.3+cf39a74318, reason: same version active
	 - mod 'Fabric Textures (v0)' (fabric-textures-v0) 1.0.7+cf39a74318, reason: wrong environment (client/server only)
	 - mod 'Hologram API' (hologram-api) 0.2.0+1.17.1, reason: newer version active
	 - mod 'libaddict' (libaddict) 0.3.0, reason: wrong environment (client/server only)
	 - mod 'LibBlockAttributes' (libblockattributes) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Core)' (libblockattributes_core) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Core)' (libblockattributes_core) 0.9.0, reason: same version active
	 - mod 'LibBlockAttributes (Fluids)' (libblockattributes_fluids) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Fluids)' (libblockattributes_fluids) 0.9.0, reason: same version active
	 - mod 'LibBlockAttributes (Items)' (libblockattributes_items) 0.8.17003, reason: newer version active
	 - mod 'LibBlockAttributes (Items)' (libblockattributes_items) 0.9.0, reason: same version active
	 - mod 'LibCapableData' (libcd) 3.0.3+1.16.3, reason: same version active
	 - mod 'LibGui' (libgui) 4.1.0+1.17, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.1+1.17.1-rc1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.2+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.3+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.4+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.1.6+1.17.1, reason: newer version active
	 - mod 'LibGui' (libgui) 4.2.1+1.17.1, reason: newer version active
	 - mod 'Magna' (magna) 0.4.0-1.17.1, reason: newer version active
	 - mod 'megane-dml-simulacrum' (megane-dml-simulacrum) 5.6.1+1.0.5, reason: unknown
	 - mod 'Myron' (myron) 1.6.1-1.17.1, reason: newer version active
	 - mod 'OmegaConfig' (omega-config) 1.0.4, reason: newer version active
	 - mod 'OmegaConfig' (omega-config) 1.0.4, reason: newer version active
	 - mod 'Packet Tweaker' (packet_tweaker) 0.2.0-1.17-pre1, reason: newer version active
	 - mod 'Patchouli' (patchouli) 1.17.1-56-FABRIC, reason: newer version active
	 - mod 'Patchouli' (patchouli) 1.17.1-56-FABRIC-SNAPSHOT, reason: newer version active
	 - mod 'Fabric Placeholder API' (placeholder-api) 1.0.1+1.17, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.3.0-nightly.1.17-pre1, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.3.0-nightly.1.17-rc1, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.3.0, reason: newer version active
	 - mod 'Pal' (playerabilitylib) 1.4.0, reason: same version active
	 - mod 'Reborn Core' (reborncore) 5.0.11-beta, reason: same version active
	 - mod 'Server Translations API' (server_translations_api) 1.4.5+1.17, reason: newer version active
	 - mod 'Somnus API' (somnus) 0.0.13-1.17.1, reason: newer version active
	 - mod 'Statement Vanilla Compatibility Module' (statement_vanilla_compatibility) 1.0.1+1.14.4-1.15.2, reason: newer version active
	 - mod 'Step Height Entity Attribute' (step-height-entity-attribute) 1.0.0, reason: same version active
	 - mod 'Energy' (team_reborn_energy) 0.1.1, reason: newer version active
	 - mod 'Trinkets' (trinkets) 3.0.4, reason: same version active
	at net.fabricmc.loader.impl.discovery.ModResolver.findCompatibleSet(ModResolver.java:159)
	at net.fabricmc.loader.impl.discovery.ModResolver.resolve(ModResolver.java:45)
	at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:224)
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187)
	... 8 more

could it be ModMenu? but for 1.17.1 the latest version is 2.0.14

MM is Manningham Mills aka Fabric ASM, it is shadowed in the jar, but Fabric is dumb. I added it as a dependency to fix conflicts with other mods using an older version of it, but that completely broke the mod.
Will be fixed soon.

Try this.
https://www.curseforge.com/minecraft/mc-mods/shulkerboxtooltip
I've no idea but it works. Super wierd.

I tried to compile but i cannot get 3.9.2 how can i do so?

I tried to compile but i cannot get 3.9.2 how can i do so?

Please don't necropost. Make a new issue if you need.


fix image paths when using non-default $SNAPSHOT_SCREENSHOTS_PATH

Looks great, thanks :+1: Looks like GitHub can't merge this pull request, could you fix the merge conflict?


Tooltips on ui buttons don't follow theme

Tooltips on websites all follow the themes colours but tooltips for some Firefox buttons don't.

I've been trying to fix this and frankly, I'm stumped. This is out of my range of expertise. If you know any other themes that manage to change the Home and Extension tooltips please tell me. For now, no development on this front.

My exams finish on Tuesday, I'll check some of the more comprehensive themes that I know then. I'll also open issues for the other bugs I've found too.
If you want you could try asking in the r/firefoxcss subreddit or on matrix (link in the subreddit sidebar), iirc there is a dev channel that could help.

Ok after testing a bunch of other themes, including these:
https://github.com/BloodyHell619/Firefox-Theme-DarkMatter
https://github.com/aminomancer/uc.css.js#installation
as well as some googling I'm pretty sure these tooltips can't be customised, should I close this issue?

I'll close it dw.

I found a solution, it needs to be done with js.
See these rules. Stylesheet must be loaded as an agent sheet.
PS: Did you find a way to have smooth animations when pressing alt?
PPS: This css doesn't seem to have any effect (#10)?
.toolbarbutton-badge {
	padding: 0 2px 0px !important;
}


User/PWD?

Good Morning;
Was trying to test your OData connector yesterday was curious how you set the user/pwd to connect to the cluster? We tried setting the elastic.host in the web.xml had assumed it possibly would work using the format USER:PWD@HOST. Figured I would just reach out if your library works we might use it for a POC vs building it. Please let me know and thank you.
Joe Gaska
<EMAIL_ADDRESS>

@tarasrng @RuslanDidyk ???

Looks like a bug in ESConfigImpl class

I will fix this when I will have some free time. If you need this fix asap you can debug ESConfigImpl, I believe there is an issue during initializing ES client in constructor.

Let me know if you get a chance. We tried to wire up your code and could not get it to bring back the $metadata just crashed. We successfully verified a different sample wired things in with no luck (https://github.com/elastic/found-shield-example). If you email me at<EMAIL_ADDRESS>I will give you credentials I would love to test out what you guys have if it can point to cloud instance at elastic.io.  Let me know.
Joe Gaska
<EMAIL_ADDRESS>

I would love this to be fixed also, we could really use this

@simonmiller99 Ended up building our own obvious resolution time and licensing limitations was not worth the risk basing it on this implementation.

@gaskaj thanks for the heads-up. I've spent days trying to get this all to work (assuming that the config issue was my error) and reading StackOverflow with a microscope.  I'd love this to be working, but it looks like I will have to roll my own based on the up-to-date Olingo samples from Apache and applying it to a web layer.


Better way of referring to classes ?

In the current version of geo-deep-learning, we need to refer to our classes in differents parts of the code. For example:
config.yaml, data_analysis section
colormap.csv
In colormap.csv, the first column refers to input grayscale values corresponding to each class. This refers directly to the values chosen in the initial gpkg linked to each satellite image. Is the user always aware of the attribute value that correponds to each class (ex.: 1 for vegetation, 2 for hydro, etc.) ? If not, we could try to find a more transparent way of doing this mapping. If so, then we should still centralize this mapping in one place, like the config yaml (ie. not a separate file like colormap.csv).
This kind of mapping could become more and more important, especially if we develop, for example, class-specific metrics.
Hopefully, it's something STAC items will address. If not, I would like to suggest this dev as a priority. The first step would be to merge the colormap.csv file to the yaml, and map, in a single yaml section, the values associated to classes (which could then be used by a module like data_analysis) Just an idea.

See Label Extension Specification.

We're currently developing a data model for our annotated vector data. This data model defines the possible classes of information (land cover and objects) that can be extracted from satellite imagery.

This data model will be made publicly available
Each class will have a unique ID which can be refereed to
An object can have multiple "level" of naming. (One building footprint can be refereed to as: Building -> residential building -> single-family)

Using such model could add robustness to our system, creating a unique link between predictions and class information.


Title shows [unsupported] after enabling the background

The extension works perfectly in VS Code but the title shows up like this:

I have tried restarting and reinstalling the theme which didn't help as well.
OS: Windows 10

You can search the store to install this extension remove this message: "fix vscode checksums"

Because there is no official API for the current change background, this information is not removed particularly effectiv

That really helped, although I had it installed previously, applying the checksums again fixed the problem. Thanks!


Capping slippage component of margin

At the moment it seems that an order book with unreliable buys / sells can lead to undesirable closeouts getting triggered (@Jiajia-Cui is confirming with a feature test which we can review and then update to check we really have a fix).
The reason is the slippage component of the margin (see also https://github.com/vegaprotocol/specs/issues/1567).
Imagine a party A that's short 1 ETHUSD. If the buys sells are
buy 1 @ 15000
buy 10 @ 14900
and
sell 1 @ 16000
sell 10 @ 16100

then, if the last mark price was 15900 then the slippage charge is 16000 - 15900 = 100 (because to close the party out I need to execute a network trade on behalf of the distressed party, that would take its position to 0 i.e. the network needs to buy 1 so I need to compare to the price for selling 1 unit. The RF part is probably something like 15900 x 0.1 = 1590 so the slippage part is modest component of the maintenance margin. So far so good (or at least no disaster).
Now imagine the book becomes:
buy 1 @ 15000
buy 10 @ 14900
and
sell 1 @ 100 000
sell 10 @ 100 100

The slippage is now 100 000 - 15900 = 84 100 which is a lot and will most likely initiate a closeout, draining the party's general and margin accounts (and bond if they happen to be an LP).
So far this is the problem description.
Proposed solution
I think we'd want both.
Cap the slippage component
Introduce a new optional market parameter market.maxSlippageFraction with default of 0.1 i.e. 10%. The slippage component will never be allowed to be more that min(slippage from book, market.maxSlippageFraction x size x mark price).
The spec change PR for this is: https://github.com/vegaprotocol/specs/pull/1583
Do not execute closeout trades that would reach volume too far out
Here, too far out would be IMO:

volume outside price monitoring bounds
volume outside LP liquidity range market.liquidity.priceRange.

I'd just execute the closeout trade with a limit order placed at the price monitoring bound (so as to not trigger the price monitoring auction) and reduce the distressed parties positions pro rata from the sourced volume.
If someone builds a huge positions relative to the market then masking it with 10% slippage may be dangerous should they  become distressed later on due to MTM losses.

If someone builds a huge positions relative to the market then masking it with 10% slippage

I still think it's less bad than closing someone randomly because there is only crazy priced volume on the book for whatever reason (ddos attack so LP can't post or whatever).
You're not exactly masking it because it's still at least market.maxSlippageFraction x size x mark price + rf x size x mark price. Finally it's up to the market creator, they can set market.maxSlippageFraction  = 200% or whatever if they want.

If we go with "Do not execute closeout trades that would reach volume too far out" then we should probably start splitting closeout trades. So at each MTM:

if a party is below maintenance close what you can that won't go past price monitoring / LP bound and confiscate margin balance.

Note that if the position is e.g. 100 and the margin is subsequently 100 x rf x price (so say 160 000) if rf = 0.1 and price is 16 000 then most of it will go into the insurance pool. So if in the first round you can only close out e.g. 10 then most of the 160 000 will go into the insurance pool and will be available for subsequent closeout rounds (but the original party's margin is unlikely to amount to much).

I’m comfortable with capping and splitting close out volume as long as we do still try to close the rest out later if it’s still distressed, and there’s a way to tell there are pending close out orders/trades via some API so people can supply the liquidation demand (at a potentially very good price for them).
I’m not sure a passive limit order works for this though, perhaps unless we can guarantee the market is always in an auction if we have pending closeouts, as it could otherwise mean that all closeouts that happen like this get closed at the worst “allowable” price. Perhaps always being in an auction in this situation wouldn’t be a bad idea though?


[WIP] Refactor Document Model

Issue Link: #716

closing this as PR will be scoped out into smaller successive PRs.


Centralized logging for TensorBoard among multiple docker images

https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tensorboard

tensorflow + hdfs is now integrated

Setup Distributed Tensorboard using HDFS

The issue I am facing is that each job runs and embedding are hard coded with full path inside the container  on the ProjectorConfig file, while tensorboard does not have the same full path, how HDFS will help me with this?

complete.  using hdfs.

Can you please give a link to some example or write how you made it work?


Pass Mouse Button State into HandleMouse

Follow-up from #4848. TerminalInput::s_GetPressedButton() gets the key state for the mouse buttons. We should just have the caller of HandleMouse pass in the mouse button state.

Triaged into 1.x.


fix: ensure we can serialize/deserialize the ghsa model

ensure we can serialize and deserialize the ghsa model
correct type names and visibility
fix possible NPE

I'm still not happy with having the edge nodes in the serialization - but it is the only way I can figure out how to have a single model that can deserialize the response from GitHub's GraphQL endpoint and serialize/deserialize a slightly condensed schema.

In hindsight - this probably should have been considered a breaking change... as some of the APIs did change. The ghsa lib was only published like a week ago - likely very few users... sorry.


Legends in exporter

Adds legends to the export and persistence flow.

Hey @juanignaciosl could you CR please?

Now's the time @juanignaciosl :) thanks!


Dev/migration templates

Pull Request summary:
Added factory method that converts UX1 to UX2. Based on template definition field from GET on /dataservice/template/feature
https://github.com/CiscoDevNet/catalystwan/blob/1b3ad1681978824c4d3b6e658cf524515958c2c6/catalystwan/models/configuration/feature_profile/converters/feature_template/__init__.py#L36
Description of changes:
Added modular converters that take care of data missmatch on models.
For example in UX1 BFD has field named  color and in UX2 BFD model has field named  colors. We can take care of such problems by adding new converter class.
from catalystwan.models.configuration.feature_profile.sdwan.system import BFD

class BFDTemplateConverter:
    @staticmethod
    def create_parcel(name: str, description: str, template_values: dict) -> BFD:
        """
        Creates an BFD object based on the provided template values.
        Returns:
            BFD: An BFD object with the provided template values.
        """
        template_values["name"] = name
        template_values["description"] = description

        if template_values.get("color") is not None:
            template_values["colors"] = template_values["color"]
            del template_values["color"]

        return BFD(**template_values)

Checklist:

[ ] Make sure to run pre-commit before committing changes
[ ] Make sure all checks have passed
[ ] PR description is clear and comprehensive
[ ] Mentioned the issue that this PR solves (if applicable)
[ ] Make sure you test the changes

Lets not commit incomplete features to main.
I have created dev-ux-migration branch from which dev versions will be produced, so we can sync work there without polluting main.
Please open new PR which will target dev-ux-migration branch


Dev

Update EdiblesSpectrum docstring, add interpolated spectrum and raw data attributes, updated EdiblesSpectrum test

Chose a static cent value for entire wavelength grid for interpolation, not sure if correct thing to do...


Merge Compaction and Promotion

This PR merges the compaction and promotion passes,  which fixes #1909.
It also gets rid of the compaction pass.
You can pass -x static-promotion:compaction=false if you want to run just promotion, without compaction.
Also, compaction has a very simple heuristic: if you can compact the schedule at all, then compaction occurs. In the future, I can see more complex heuristics.

Awesome! One high-level suggestion from #1909 that I wanted to bubble up is defining a wrapper trait that manages the fixup stuff for passes that want to similar things to this pass. Might be worth doing in either this PR or another one if you think it makes sense.

Bumping this for merge since I'm getting ready for #1902!


Are there cmake-to-bazel provided?

Yes，I want it, got any plan?

It is supported by https://github.com/bazelbuild/rules_foreign_cc.

thanks a lot


Append invisible characters to

Currently, the <mj-preview> tag functions by placing its contents into an invisible
 tag. This approach allows the contents to appear in the email preview on clients such as Gmail. However, there is a minor issue with this implementation.

  Hello World!

If the preview text provided by the <mj-preview> tag is too short, the email client may grab the next text-containing element, potentially resulting in the title not accurately reflecting what the user has defined.
Wouldn't it be possible to improve the <mj-preview> functionality by introducing an option to append invisible characters to the title during the compilation step? This modification would ensure that the title contains only the elements explicitly defined by the user, improving the accuracy of email previews.

  Hello World!

👋 Closing in favor of #1829
But we don't want to be the default behavior of preview tag and put it behind an attribute.


Does not compile in Visual Studio after July 6th commit

The commit on May 14th, 7c3d8fa612465a452fe9baf4463db0fb422746c7, works.
The first commit on July 6th, 48379773f891ba21c8e474a899e2496e9cc41387, does not compile, along with none of the following commits.
I am experiencing this using Visual Studio 14 on a Windows 10 64-bit machine, building for Debug or Release for Win32.
I follow the same procedure for building the two different versions.
I configure with cmake. Set SDL2 lib, SDL2main lib, and SDL2 include locations. Configure again. Generate. Open SDL_gpu.sln. Build SDL_gpu project.
It then succeeds for the May commit but fails for the July commit.
The errors mostly consist of undefined identifiers for all of the GL_ GPU_ and SDL_ identifiers.
Please let me know if I can be of more help.

Eric Wing noticed this too and provided a fix for errors on VS that are just warnings on GCC: 9e9bdbada3b233aff955e304fa3b91750211dc77
Does this solve your issue?

That did it! 9e9bdbada3b233aff955e304fa3b91750211dc77 compiles fine. Thanks!

Cool, thanks for reporting on it. :)


Increment version for spring releases

Increment version for spring releases

Can one of the admins verify this patch?


The selected account/network/token icon is not displayed in the Select account/Select network/Select token screens

Describe the bug
The selected account/network/token icon is not displayed in the Select account/Select network/Select token screens
https://user-images.githubusercontent.com/130966515/238198009-2623af6a-a958-4a96-a434-55b6187fa72a.mp4

Expect: Show the selected icon

Version test: v1.0.3(154)
Devices test: IP 11
Validation passed


added the sender parameter for the event

The event method needs two parameters and first one is normally sender which is of type object

Thanks for your contribution - looks good to me, @jamesmontemagno can you confirm?

Thanks @conceptdev , just came in front of this via a stackoverflow question where the OP was getting compile time error while following the example from the docs, and it's my very first contribution to open source 👍

We appreciate you taking the time, as it helps everyone!

Looks good here! Good catch


Question on composing queries together

Suppose I have the following base query:
const accounts = db.accounts
    .leftJoin("cover")
    .selectAll()
    .select({
        cover: q => q.cover.selectAll(),
        num_posts: q => q.account_posts.count().whereNotExists(db.commentsOnPosts, "comment_id", "=", "id"),
        num_comments: q => q.account_posts.count().whereExists(db.commentsOnPosts, "comment_id", "=", "id"),
        num_posts_liked: q => q.account_likes.count().whereNotExists(db.commentsOnPosts, "comment_id", "=", "post_id"),
        num_comments_liked: q => q.account_likes.count().whereExists(db.commentsOnPosts, "comment_id", "=", "post_id"),
    })
    .limit(10);

I am attempting to represent the following query:
select * from (${accounts}) where num_posts_liked > 0

My attempt at building this query is as so, though is incorrect:
db.accounts.from(accounts).selectAll().where({ num_posts_liked: { gt: 0 } });

Not supported yet, but I'm taking this to the development plan.

This feature is ready now, update the packages to check it out.
Added method $from to ORM, so no need, in this case, to write db.accounts.
With the tables defined in the related issues, this works:
const accounts = db.accounts
  .select({
    cover: q => q.cover.selectAll(),
    num_posts: q => q.account_posts.count().whereNotExists(db.commentsOnPosts, "comment_id", "=", "id"),
    num_comments: q => q.account_posts.count().whereExists(db.commentsOnPosts, "comment_id", "=", "id"),
    num_posts_liked: q => q.account_likes.count().whereNotExists(db.commentsOnPosts, "comment_id", "=", "post_id"),
    num_comments_liked: q => q.account_likes.count().whereExists(db.commentsOnPosts, "comment_id", "=", "post_id"),
  })
  .limit(10);

console.log(
  await db.$from(accounts).where({ num_posts_liked: { gt: 0 } })
)

await db.$close()

Is there any way to provide an alias to $from as well? I notice that $from by default aliases the subquery by the table it references from.
Also, does {left,right,inner,outer}[j|J]oin() support subqueries as well?

Yes, there is a separate method .as to set alias:
await db.$from(accounts).as('t').where(...)

Here it's aliased as t.

Also, does {left,right,inner,outer}[j|J]oin() support subqueries as well?

Do you mean to get something like this?
SELECT * FROM table
JOIN ( SELECT * FROM other ) t ON true

No, currently not.

Got it 👍 should I make a separate issue for having subqueries supported for joins?

Yeah, make it please

Seem to run into an error about type instantiation being too deep here:
error TS2589: Type instantiation is excessively deep and possibly infinite.

    12     const results2 = await db.$from(results).as("accounts_view").selectAll();
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

const results = db.accounts.select("id", "publicKey", "name", "alias", "bio", "createdAt", "updatedAt", "lastSeenAt", "isVerified")
      .select({
        numPosts: q => db.posts.count().whereNotExists(db.commentsOnPosts, { commentId: "id" }).where(q.raw("posts.author_id = accounts.id")),
        numComments: q => db.posts.count().whereExists(db.commentsOnPosts, { commentId: "id" }).where(q.raw("posts.author_id = accounts.id")),
      });

    const results2 = await db.$from(results).as("accounts_view").selectAll();

    console.log(results2);


Quickfix: Allow type date for TextField

What❓
This allows the type property of the TextField component to accept "date", so the field can be used as a date input field
Why 💁♀
why you did it

This change is


ddLCMSubscriber may not preserve (channel, message) ordering if messages are published close together

I was writing a quick modification to Siyuan's show_frames.py script to accept multiple channels (as what the drakevisualizer.py in director does) by subscribing to 'DRAKE_DRAW_FRAMES.*' (with callbackNeedsChannel = True).
However, I noticed that occasionally the channel name and the message data would sometime get mixed. If I added sleep for about ~100ms in between publishing on the different channels,
I will briefly try to reproduce this in one or two independent scripts.
As a workaround, I will try to add a command-line argument (or something else) to register each subscriber independently, rather than relying on a single subscriber with multiple channel names.

Added some reproduction scripts (see repro.sh for running):
https://github.com/EricCousineau-TRI/repro/tree/13fa51b/bug/director_lcm_sub
Here's the portion of output.txt that effectively captures the issue:
+ ./pub.py
...
pub 1
channel: DRAKE_DRAW_FRAMES_A
  name: b
timestamp: 1
...
+ ./pub.py --do_sleep
...
pub 1
channel: DRAKE_DRAW_FRAMES_A
  name: a
  timestamp: 1
channel: DRAKE_DRAW_FRAMES_B
  name: b
  timestamp: 1

Yes this is a known issue, thanks for reporting.  I can't remember if there is already an open issue.  I have run into the exact problem when implementing a ros tf visualization that subscribed to * channel but I implemented a workaround, based on independent subscribers.  But the issue should just be fixed in ddLCMSubscriber implementation ideally.

Sounds good! I will do the workaround for the time being, and possibly update the underlying subscriber if it comes to that point.
Thanks!

I think if you can also workaround the issue by doing this:
sub.setNotifyAllMessagesEnabled(True)

For very high frequency messages this may have performance issues, but most of the time flag is fine.

I think a reasonable fix in ddLCMSubscriber would change mLastMessage from a QByteArray to a QMap<QString, QByteArray> and the function signature  QByteArray getNextMessage(int timeout) would be modified to  QByteArray getNextMessage(int timeout, const QString& channel=QString()).

I think if you can also workaround the issue by doing this:

Yup, that did the trick! Is #446 the related issue you were mentioning?

That's related but not the same as what you reported.  I guess it's never been posted in Github issues.  I found where it was previously encountered though, and maybe we just discussed it on Slack:
https://github.com/RobotLocomotion/director/blob/master/src/python/director/treeviewer.py#L426