DMP token

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

I can help stop wasting your time refer this zakimzf/profile#1

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ
.
You are receiving this because you commented.Message ID:
@.***>

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I Prefer just email
Op di 18 jan. 2022 16:53 schreef Mohd Zakiuddin Faiz <
@.***>:

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015549153,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXLLQ6KNDFIDARIMW6ZLBLLUWWEHVANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

If you van help me to add a logo and a name to Solana tokens, that would be
very helpfull. I Will Paul on Sol
Op di 18 jan. 2022 16:53 schreef Mohd Zakiuddin Faiz <
@.***>:

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015549153,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXLLQ6KNDFIDARIMW6ZLBLLUWWEHVANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I can help you but email will cause a communication gap better if you hop
on WhatsApp or Facebook!
If not then email me : @.***
On Tue, 18 Jan 2022, 9:34 pm BerkshireConsulting, @.***>
wrote:

If you van help me to add a logo and a name to Solana tokens, that would be
very helpfull. I Will Paul on Sol
Op di 18 jan. 2022 16:53 schreef Mohd Zakiuddin Faiz <
@.***>:

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015549153
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AXLLQ6KNDFIDARIMW6ZLBLLUWWEHVANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015559580,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAH7M27XXGWPS4HJPXZXLDUWWFPRANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

WhatsApp ok. What is your mobile nr?
Op di 18 jan. 2022 17:07 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help you but email will cause a communication gap better if you hop
on WhatsApp or Facebook!
If not then email me : @.***
On Tue, 18 Jan 2022, 9:34 pm BerkshireConsulting, @.***>
wrote:

If you van help me to add a logo and a name to Solana tokens, that would
be
very helpfull. I Will Paul on Sol
Op di 18 jan. 2022 16:53 schreef Mohd Zakiuddin Faiz <
@.***>:

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015549153

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KNDFIDARIMW6ZLBLLUWWEHVANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015559580
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AQAH7M27XXGWPS4HJPXZXLDUWWFPRANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015562751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXLLQ6NM5NRJAF7S2FHNZHDUWWF3ZANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes whtaspp is ok..i cannot disclose my number publicly on GitHub...so
either u mail me with your email or send me your email!
On Tue, 18 Jan 2022, 9:39 pm BerkshireConsulting, @.***>
wrote:

WhatsApp ok. What is your mobile nr?
Op di 18 jan. 2022 17:07 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help you but email will cause a communication gap better if you hop
on WhatsApp or Facebook!
If not then email me : @.***
On Tue, 18 Jan 2022, 9:34 pm BerkshireConsulting, @.***>
wrote:

If you van help me to add a logo and a name to Solana tokens, that
would
be
very helpfull. I Will Paul on Sol
Op di 18 jan. 2022 16:53 schreef Mohd Zakiuddin Faiz <
@.***>:

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this
zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the
thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015549153

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KNDFIDARIMW6ZLBLLUWWEHVANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015559580

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M27XXGWPS4HJPXZXLDUWWFPRANCNFSM5MHBBTSQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015562751
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AXLLQ6NM5NRJAF7S2FHNZHDUWWF3ZANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015564500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAH7M6BBFLUW3RCFPRWAO3UWWGCZANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@.***
Op di 18 jan. 2022 17:10 schreef Mohd Zakiuddin Faiz <
@.***>:

Yes whtaspp is ok..i cannot disclose my number publicly on GitHub...so
either u mail me with your email or send me your email!
On Tue, 18 Jan 2022, 9:39 pm BerkshireConsulting, @.***>
wrote:

WhatsApp ok. What is your mobile nr?
Op di 18 jan. 2022 17:07 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help you but email will cause a communication gap better if you
hop
on WhatsApp or Facebook!
If not then email me : @.***
On Tue, 18 Jan 2022, 9:34 pm BerkshireConsulting, @.***>
wrote:

If you van help me to add a logo and a name to Solana tokens, that
would
be
very helpfull. I Will Paul on Sol
Op di 18 jan. 2022 16:53 schreef Mohd Zakiuddin Faiz <
@.***>:

What messenger do you use?
On Tue, 18 Jan 2022, 9:17 pm BerkshireConsulting, @.***>
wrote:

I don't have
Op di 18 jan. 2022 16:42 schreef Mohd Zakiuddin Faiz <
@.***>:

Contact me on telegram @zakimzf
On Tue, 18 Jan 2022, 9:03 pm BerkshireConsulting, @.***>
wrote:

Hello Mohd,
How could you help me please?
Best regards,
Jan Jaap
Op di 18 jan. 2022 16:25 schreef Mohd Zakiuddin Faiz <
@.***>:

I can help stop wasting your time refer this
zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015521625

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KCTEE5DWLH6Y52Q43UWWA6HANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the
thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015529437

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M3E5TO6VB7XA52ZVT3UWWB4DANCNFSM5MHBBTSQ

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015538265

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6IGYBPFXRN3JTFAJ43UWWC7DANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message
ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015542517

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7MYRE7MYIYNAMHDZIGDUWWDPLANCNFSM5MHBBTSQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015549153

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6KNDFIDARIMW6ZLBLLUWWEHVANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015559580

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AQAH7M27XXGWPS4HJPXZXLDUWWFPRANCNFSM5MHBBTSQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015562751

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AXLLQ6NM5NRJAF7S2FHNZHDUWWF3ZANCNFSM5MHBBTSQ

.
Triage notifications on the go with GitHub Mobile for iOS
<

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015564500
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AQAH7M6BBFLUW3RCFPRWAO3UWWGCZANCNFSM5MHBBTSQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/14587#issuecomment-1015566019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXLLQ6LCUMOGDFBWCKCL5ZTUWWGJBANCNFSM5MHBBTSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

ok just whatsapp me @ +919704371049

I can help resolve automerge issues.
Feel free to check out J-a-m-e-s-o-n/token-list#1


Unexpected runtime difference when using Brackets or not with ts-node

Bug Report

🔎 Search Terms

Brackets
🕗 Version & Regression Information

[x] This is a crash
[ ] This changed between versions ______ and _______
[ ] This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
[ ] I was unable to test this on prior versions because _______

⏯ Playground Link

Playground link with relevant code
💻 Code

const ESLinter = (require(linterPath) as typeof import('eslint')).Linter

// vs

const ESLinter = require(linterPath) as typeof import('eslint').Linter

🙁 Actual behavior

The first one with Brackets works well, but when running with the second one there is an error:
TypeError: Cannot read property 'verify' of undefined

🙂 Expected behavior

They should work the same.
Reproduction:
https://github.com/mdx-js/eslint-mdx/tree/feat/eslint-plugin-markdown
run yarn eslint --no-ignore test/fixtures/code-blocks.md

This is working as intended. The second one is compiled to const ESLinter = require(linterPath)

Hah, thanks for your point, I just forgot about that.😂


[fuzz] Added validation for secrets

Signed-off-by: Zach Reyes<EMAIL_ADDRESS>Commit Message: Added validation for secrets.
Additional Description: The HTTP filter OAuth was crashing due to a null dereference. This was due to secret not being required. Fixes issue: https://oss-fuzz.com/testcase-detail/5681522444861440.
Risk Level: Low
Testing: Added regression corpus entry
Docs Changes: N/A
Release Notes: N/A

/assign @asraa


Fix extension host profiling

This PR fixes https://github.com/microsoft/vscode/issues/86601

Tested on all platforms


feat(chrome-extension): use browser from web-ext instead of global ch…

…rome to make extension browsers agnostic

Bundle size with webextension package :

Comparing bundle size without webextension package :

@aradjdi There seems to be a snyk license issue.

@aradjdi Can you also take a look at the preview mode (yarn dev)? The polyfill throws an error.


Add relevant alt tag on logo

Ideally Alt should be site - title as it is going to site and not a static text.

Looks good. Thank you.


Host needs -p xxxx for ssh

Can this be done during init command?

Let me know if it works for you, I'll then close the issue.

works fine, thx :)


Add build task signing

This feature adds the ability for customers to sign task packages before uploading them using tfx.
We implement this by using NuGet signing.
We take advantage of the fact that tasks are zips and NuGet packages are also zips.
This allows us to change the zip to a nupkg, sign it, then convert back to zip.
The only change that signing adds is to embed a .signature.p7s file at the root of the archive. This is helpful since we need to be able to inspect inside tasks and we won't have the private key.
The command to sign is:
tfx build tasks sign --task-path {TASK_PATH} --cert-fingerprint {FINGERPRINT} --new-guid {GUID} --new-name-suffix ' - SIGNED'

@damccorm


Facilitate config retries via callbacks.

Closes #2257
Currently TestNG facilitates retry of failed tests
via a retry analyser but the same mechanism doesn’t
exist for a configuration method.
Instead of introducing a new retry analyses for
configuration methods, found an alternative when
retries for configuration methods can be easily supported
via call backs.
This PR enables support for retry of configuration
methods via call back.
Fixes #2257  .
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt

Hello, so in order for TestNG's Retry Analyzer to re-run @BeforeTest methods upon failure, does it required any logic to be implemented or is it just handled by latest version (7.3.0)?

Hello, so in order for TestNG's Retry Analyzer to re-run @BeforeTest methods upon failure, does it required any logic to be implemented or is it just handled by latest version (7.3.0)?

@tomcribb  You need two things.

Upgrade to 7.3.0
To use this feature refer to src/test/java/test/hook/issue2257/TestClassSample.java for example

@tomcribb  You need two things.

Upgrade to 7.3.0
To use this feature refer to src/test/java/test/hook/issue2257/TestClassSample.java for example

I have implemented your suggested solution from: https://rationaleemotions.com/retry_configuration_methods/
It works like a charm man!
Thanks and keep the good work up
Best regards

I have implemented your suggested solution from: https://rationaleemotions.com/retry_configuration_methods/
It works like a charm man!
Thanks and keep the good work up
Best regards

@tomcribb @krmahadevan
Was trying out this feature for my existing framework and encountered that @beforemethod does get triggered for 4 times in case of failure, but the loop is not broken in case of Assertion Pass.
Below is the code snippet
private int counter = 1;
@BeforeMethod()
	@Retriable(attempts = 4)
	public void setup(Method method) {
				initiate();
				System.out.println("Test name: " + method.getName());
				AssertJUnit.assertEquals(2, counter++);
				LoginPageObj = new LoginPage();
				AgenciesLandingPageObj = new AgenciesLandingPage();
				utils = new CommonUtils();
				error_message = "";
		}

Further observed that the value for testResult in case of assertion getting passed (AssertJUnit.assertEquals) remains unchanged while eventually does not break the loop here
@Override
	  public void run(IConfigureCallBack callBack, ITestResult testResult) {
	    Retriable retriable =
	        testResult.getMethod().getConstructorOrMethod().getMethod().getAnnotation(Retriable.class);
	    int attempts = 1;
	    if (retriable != null) {
	      attempts = retriable.attempts();
	    }
	    for (int attempt = 1; attempt <= attempts; attempt++) {
	      callBack.runConfigurationMethod(testResult);
	      if (testResult.getThrowable() == null) {
	        break;
	      }
	    }
	  }

Are there any more changes that are needed to resolve this ?
PS - Current testng version used
org.testng
testng
7.3.0

@prafulkolhe89 - I cant reproduce the problem. You would need to share a full fledged example that can be used to reproduce the problem at hand (Please dont include any selenium dependencies and keep it to just core java)
Once you have a sample, please post it on the TestNG users google forum.
https://groups.google.com/g/testng-users

Hi,
This feature works like a charm on my regression suite. I will try to run
your code and let you know whether I can reproduce it.
niedz., 28 lut 2021, 08:45 użytkownik prafulkolhe89 <
<EMAIL_ADDRESS>napisał:

@tomcribb https://github.com/tomcribb @krmahadevan
https://github.com/krmahadevan
Was trying out this feature for my existing framework and encountered that
@beforemethod does get triggered for 4 times in case of failure, but the
loop is not broken in case of Assertion Pass.
Below is the code snippet
private int counter = 1;
@BeforeMethod()
@Retriable(attempts = 4)
public void setup(Method method) {
initiate();
System.out.println("Test name: " + method.getName());
AssertJUnit.assertEquals(2, counter++);
LoginPageObj = new LoginPage();
AgenciesLandingPageObj = new AgenciesLandingPage();
utils = new CommonUtils();
error_message = "";
}
Further observed that the value for testResult in case of assertion
getting passed (AssertJUnit.assertEquals) remains unchanged while
eventually does not break the loop here
@Override
public void run(IConfigureCallBack callBack, ITestResult testResult) {
Retriable retriable =
testResult.getMethod().getConstructorOrMethod().getMethod().getAnnotation(Retriable.class);
int attempts = 1;
if (retriable != null) {
attempts = retriable.attempts();
}
for (int attempt = 1; attempt <= attempts; attempt++) {
callBack.runConfigurationMethod(testResult);
if (testResult.getThrowable() == null) {
break;
}
}
}
Are there any more changes that are needed to resolve this ?
PS - Current testng version used
org.testng
testng
7.3.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cbeust/testng/pull/2262#issuecomment-787411879, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2AOFOKXI6XAVNSWGL4F43TBHYDBANCNFSM4LDX3GZA
.

Hi,
When a child class's test fails, the testResult.getThrowable() is null in IConfigurable.run.
For example when running ChildTest, testResult.getThrowable() is null and testResult.testResult() is false.
Is this intentional?
`
public class Base implements IConfigurable {
public void run(IConfigureCallBack callBack, ITestResult testResult) {
callBack.runConfigurationMethod(testResult);
//testResult.getThrowable() is null
//testResult.testResult() is false
}
public class ChildTest extend Base() {
@Test
public void test(){
fail();
}
}
`

@askfor - Are you using TestNG 7.4.0 for this. If this is still a problem on 7.4.0, please open a new issue with a sample that can be used to reproduce the problem.

After some test, I found that It's not about child class, only related to BeforeMethod (or other BeforeXXX)
opened  #2657

how can I rerun @beforemethod after skipped or failed? I am trying everything, can some one show me example how it will work ?

@lazogio have you checked the test class sample and see if that helps?
src/test/java/test/hook/issue2257/TestClassSample.java

@krmahadevan  Yes, It isnot work for me :/

@lazogio please share a sample project which uses '7.5-SNAPSHOT' and also your sample code so that we can find out what is going wrong.
I don't remember if this is yet released or not. Thats why the request to use the latest snapshot version.

testng.zip
you will see Version2 package

@lazogio - Can you please remove off all Selenium references and share a simple project that uses just TestNG ? The project you shared has selenide references in it.

Yes I only Try Used TestNG ,I want to call @Beforemethod  after field or skip  Test method

@lazogio - What I meant was the following:

Create a sample project
Add ONLY testNG as its dependency
create sample that can be used to reproduce the problem.

@krmahadevan
hm.. with only TestNg work, how can integration with selenide ?
`import org.testng.Assert;
import org.testng.IConfigurable;
import org.testng.IConfigureCallBack;
import org.testng.ITestResult;
import org.testng.annotations.*;
public class TestClassSample implements IConfigurable {
private int counter = 1;
@Override
public void run(IConfigureCallBack callBack, ITestResult testResult) {
    callBack.runConfigurationMethod(testResult);
    if (testResult.getThrowable() != null) {
        for (int i = 0; i <= 3; i++) {
            callBack.runConfigurationMethod(testResult);
            if (testResult.getThrowable() == null) {
                break;
            }
        }
    }
}

@BeforeSuite
public void beforeSuite() {

    runConfiguration();
    System.out.println("beforeSuite");
}

@BeforeTest
public void beforeTest() {
    runConfiguration();
    System.out.println("BeforeTest");
}

@BeforeClass
public void beforeClass() {
    runConfiguration();
    System.out.println("BeforeClass");
}

@BeforeMethod
public void beforeMethod() {
    runConfiguration();
    System.out.println("BeforeMethod");
}

@Test
public void runTest() {
    Assert.fail();
}
@Test
public void Te() {
    Assert.assertTrue(true);
}

@Test
public void r() {
    Assert.fail();
}
@Test
public void ru() {
    Assert.fail();
}
@Test
public void Test() {
    Assert.assertTrue(true);
}

private void runConfiguration() {
    if (counter++ == 2) {
        counter = 1;
    } else {
        Assert.fail();
    }
}`

beforeSuite
BeforeTest
BeforeClass
BeforeMethod
BeforeMethod
BeforeMethod

hm.. with only TestNg work, how can integration with selenide ?

The intent is to try and rule out all the noise so that we can focus on the TestNG related problem. Hence the request.

@lazogio - I modified the sample that you shared and it works fine and I do see the config methods being retried (on TestNG 7.4.0 version)
import org.testng.Assert;
import org.testng.IConfigurable;
import org.testng.IConfigureCallBack;
import org.testng.ITestNGMethod;
import org.testng.ITestResult;
import org.testng.annotations.*;

public class TestClassSample implements IConfigurable {

  private int counter = 1;

  @Override
  public void run(IConfigureCallBack callBack, ITestResult testResult) {
    callBack.runConfigurationMethod(testResult);
    if (testResult.getThrowable() != null) {
      for (int i = 0; i <= 3; i++) {
        System.err.println("Retrying " + parseType(testResult) + " method : " +
            testResult.getMethod().getQualifiedName());
        callBack.runConfigurationMethod(testResult);
        if (testResult.getThrowable() == null) {
          break;
        }
      }
    }
  }

  @BeforeSuite
  public void beforeSuite() {

    runConfiguration();
    System.out.println("beforeSuite");
  }

  @BeforeTest
  public void beforeTest() {
    runConfiguration();
    System.out.println("BeforeTest");
  }

  @BeforeClass
  public void beforeClass() {
    runConfiguration();
    System.out.println("BeforeClass");
  }

  @BeforeMethod
  public void beforeMethod() {
    runConfiguration();
    System.out.println("BeforeMethod");
  }

  @Test
  public void runTest() {
    Assert.fail();
  }

  @Test
  public void Te() {
    Assert.assertTrue(true);
  }

  @Test
  public void r() {
    Assert.fail();
  }

  @Test
  public void ru() {
    Assert.fail();
  }

  @Test
  public void Test() {
    Assert.assertTrue(true);
  }

  private void runConfiguration() {
    if (counter++ == 2) {
      counter = 1;
    } else {
      Assert.fail();
    }
  }

  private static String parseType(ITestResult testResult) {
    ITestNGMethod method = testResult.getMethod();
    if (method.isBeforeSuiteConfiguration()) {
      return "@BeforeSuite";
    }
    if (method.isAfterSuiteConfiguration()) {
      return "@AfterSuite";
    }
    if (method.isBeforeTestConfiguration()) {
      return "@BeforeTest";
    }
    if (method.isAfterTestConfiguration()) {
      return "@AfterTest";
    }
    if (method.isBeforeGroupsConfiguration()) {
      return "@BeforeGroup";
    }
    if (method.isAfterGroupsConfiguration()) {
      return "@AfterGroup";
    }
    if (method.isBeforeClassConfiguration()) {
      return "@BeforeClass";
    }
    if (method.isAfterClassConfiguration()) {
      return "@AfterClass";
    }
    if (method.isBeforeMethodConfiguration()) {
      return "@BeforeMethod";
    }
    return "@AfterMethod";
  }
}

Here's the output
beforeSuite
Retrying @BeforeSuite method : com.rationaleemotions.issue2262.TestClassSample.beforeSuite
Retrying @BeforeTest method : com.rationaleemotions.issue2262.TestClassSample.beforeTest
BeforeTest
Retrying @BeforeClass method : com.rationaleemotions.issue2262.TestClassSample.beforeClass
BeforeClass
Retrying @BeforeMethod method : com.rationaleemotions.issue2262.TestClassSample.beforeMethod
BeforeMethod

java.lang.AssertionError: null

	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.fail(Assert.java:106)
	at com.rationaleemotions.issue2262.TestClassSample.runTest(TestClassSample.java:56)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:133)
	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:598)
	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:173)
	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:824)
	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:146)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
	at org.testng.TestRunner$$Lambda$105/0x0000000000000000.accept(Unknown Source)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at org.testng.TestRunner.privateRun(TestRunner.java:794)
	at org.testng.TestRunner.run(TestRunner.java:596)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:377)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:371)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:332)
	at org.testng.SuiteRunner.run(SuiteRunner.java:276)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1212)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1134)
	at org.testng.TestNG.runSuites(TestNG.java:1063)
	at org.testng.TestNG.run(TestNG.java:1031)
	at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66)
	at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:109)

===============================================
Default Suite
Total tests run: 1, Passes: 0, Failures: 1, Skips: 0
===============================================

Process finished with exit code 0

@lazogio - Please feel free to create a new issue, if you are having issues with this feature (Please don't forget to attach a sample that is just using TestNG which we can use to reproduce the problem)

@krmahadevan  thank for help


chore(main): release 1.4.3

:robot: I have created a release beep boop
1.4.3 (2023-04-13)
update

更新好友聊天跳转 (3179fed)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/School-of-Website-Engineering/future-front-end/releases/tag/v1.4.3 :sunflower:


[FEATURE] - implement post bump hooks

This shall be optional and be set either with a flag or in cog.toml
User shall be warned and prompted a yes/no question before pushing tag and commit to remote

Hello, I'd like to poke at this 😃 Could you specify more details? Is this supposed to be an addition to bump so that the new version is pushed immediately to the repo, or did you mean something else?

@tranzystorek-io yep, exactly what you said : bump shall push the new git tag to the remote repository but we need to define an entry in cog.toml config, something like push_to_remote = true/false (default to true).

When disabled the user shall never be asked/prompted for a remote push.
When enabled if the user says "yes" we need to push the chore(version) x.x.x commit and if the commit is successfully pushed to remote, push the tag.

Also we need to prompt user for confirmation before pushing to remote. It would be nice to have a kind of sum up the changelog in addition to the current bump output.
Something like this :
Git tag 1.2.4 created locally
- 2 feature commits
- 4 bug fixes
Would you like to push to remote immediatly? (Y/n)

Hey, an update:

I have a draft version of a summary for a bump (a list of all commit types with the number of commits)
I'm looking around git2, but so far I can't find anything on pushing specific tags/branches to a remote

There's also the question of deciding which remote to push to. I guess assuming origin if there is more than one remote is too simplistic...

Choosing the remote seems easy :
    let repo = git2::Repository::open(".").unwrap();

    repo.remotes().unwrap().iter()
        .for_each(|remmote| println!("{:?}", remmote));

    let mut remote = repo.find_remote("origin").unwrap();

But I think you can focus on making it work with origin only for now.
I think you need to use Remote::push, although I am not a 100% sure.
I have also done a quick research on git2-rs issue board and this does not seems to be trivial to implement :

A simple authentification callback implementation
A git2-rs issue related to authentication callbacks implementation
A reference implementation in cargo

@tranzystorek-io How is it going with this feature ?
I am now thinking It might be simpler to just use post version hooks we could reuse what have been done by @mersinvald in #45 to do something like :
# cog.toml
post-bump-hooks = [
  "git push",
  "git push origin %version",
  "cargo package",
  "cargo publish",
]

Those would be run after the version commit and git tag have been created for the new version.
This would be much easier to implement and will allow to do much more. What do you think ?

I've been unfortunately busy with some other stuff. I like the post-bump hooks idea, but i have some remarks:

I'd be more explicit in the example:
# cog.toml
post-bump-hooks = [
  "git push origin master %version",
  "cargo package",
  "cargo publish",
]

Assuming that master is always the branch that collects all the final changes.

Since we're thinking about having multiple types of hooks, the original hooks should probably be renamed to pre-bump-hooks or something similar.

Do we still want to ask for confirmation before this hook, or do we trust the user, like with the other hook?

@tranzystorek-io Good to here you have not been working for nothing, since the first implementation is not relevant anymore.

I agree, however the hook could be any command so this is a documentation matter.
you are right on this one !
I think no confirmation is needed since the user will choose the hooks. So yes the summary is not necessary anymore.

Since the implementation has changed, do you still want to do it ?

Since the implementation has changed, do you still want to do it ?

Sure, I'd like to see this feature completed! 😄


Set Urgency in webpush.Headers for FCM

Set Urgency: high header for webpush FCM delivery

Thank you @neekolas —  I might suggest some more changes at a later time, e.g. FCM will skip onBackgroundMessage handler when webpush.Notification is set, making it harder to handle push messages in the service worker.
We don't currently have bandwidth to create our own go deployment pipeline and we pull the image directly from xmtp/notification-server on DockerHub, so thank you for approving!

Closing because we're deploying changes on our own and this PR's from our main


Feature: episode monitoring

What?
Added environment monitoring (recording videos of episodes)
Why?
Very useful for debugging
How?
Added a MonitorExecutorEnvironmentLoop component which creates a MonitorParallelEnvironmentLoop on evaluators and a regular ParallelEnvironmentLoop on executors
Extra

Had to edit MonitorParallelEnvironmentLoop to get the correct counter. The current way the env loops and loop wrappers support both tf and jax mava makes them incredibly messy, I'll open an issue and get on this ASAP
I changed checkpoint_subpath config in the ParameterServerConfig to experiment_path this allows it to be a more general path for other things that we want to save there (e.g the recordings)

Also, there is a small error in the build which should disappear with a local pre-commit

docker run debugging env: [evaluator/0] Render frames exception: HINT: you can install pyglet directly via 'pip install pyglet'. But if you really just want to install all Gym dependencies and not have to think about it, 'pip install -e .[all]' or 'pip install gym[all]' will do it.


feat(config): add support for mac universal arch

PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
Issue Number
What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information

@m01i0ng Hi! Thank you for submitting your PR! Can I ask a question? Is this a modification that can be packaged with a generic chip architecture installer? Including Apple M1 and Inter CPU?

@m01i0ng Hi! Thank you for submitting your PR! May I ask a question? Is this a modification that can be packaged with a generic chip architecture installer? Including Apple M1 and Inter CPU?

Sure! I've tried with an intel mac and everything ok.

Mac universal app contains both two platform's runtime so the bundle size will increase by 100M+.

YES! 100M+ is a little too big. 😂
OK! Anyway I will merge it! thanks!

@m01i0ng Hi! I am building the mac universal packages now, but I got this error when packaging. Is it a problem with my Node version? Which Node version are you using?

Node: v14.5.0

@ysfscream Hi! According to nodejs's changlog, v16 is the first version that support m1, so I guess node v16 is required. And I use v16.4.0 now.
https://github.com/nodejs/node/blob/b7136827f5d9f4f65bd0a60e75c4a9531cf4312a/doc/changelogs/CHANGELOG_V16.md#toolchain-and-compiler-upgrades

@ysfscream v16 is not required. fs.rm was added in v14.14.0, so the latest v14 works fine.

@m01i0ng YES! Thanks for the answer! I upgraded the node version and fixed the issue, now the universal package is uploaded to the release assets and the release note is updated. https://github.com/emqx/MQTTX/releases/tag/v1.6.0
Thanks again! 👏

@m01i0ng YES! Thanks for the answer! I upgraded the node version and fixed the issue, now the universal package is uploaded to the release assets and the release note is updated. https://github.com/emqx/MQTTX/releases/tag/v1.6.0
Thanks again! 👏

Nice! And don't forget brew's cask. I think we can add a judgement, if m1, gives the universal bundle and if intel then the normal one.

@m01i0ng Good one. That's a great suggestion!


composer support for phpbrowscap

added Composer support to phpbrowscap

/cc @seldaek

Thanks for the path; I'm willing to merge this pull request under the following conditions:

Modify the README in order to mention the use of Composer (and removing the note about the "modified version of the original")
Modify the wiki quick start guide in order to include namespace usage in the code (and removing it from the read me)
Update the quick start guide to mention composer with a quick introduction (a couple of lines) and a link back to the website.


I want to Update a Customer

Acceptance Criteria: Should be able to enter a customer_id  and one or more of the customer's attributes (first_name and/or last_name) and have this update the Customer Table in the DB.

Already in original repo.


Remove snyk action

We're trusting https://github.blog/2021-07-22-github-supply-chain-security-features-go-community/ now, which has been tested to work without the API Creds shenanigans necessary for snyk.
/assign @julz @evankanderson

/lgtm
/approve


Mention complexity of functions if it is known

I was looking for information on the performance of Query and found the following comment.

Query.get is O(1), and resources are also a constant time lookup :)
― https://github.com/bevyengine/bevy/issues/6556#issuecomment-1358516794

What about other functions?
I frequently use query-like functions such as Query::get(), Query::single(), Commands::entity(), Res<Input<KeyCode>>::just_pressed(), etc, but I'm just a Bevy user and don't know about the complexity of them.
If the complexity of a function is known, please consider documenting it.

This is a great idea :) Going to convert it to a discussion for now: feel free to open as many issues as you'd like for specific APIs / clusters of APIs. Otherwise this issue will stay open in a state of limbo forever, as this isn't exactly "completable" in its current forms.


please enable travis for the repository

I came to realization that apparently travis is still not turned on for this repo... and i believe ./test.sh is failing since awhile with
 + sudo singularity create -s 15 container.img                  (retval=1) ERROR
Creating a sparse image with a maximum size of 15MiB...
Using given image size of 15
ERROR  : Will not overwrite existing file: container.img
/tmp/singularity-test.o58KBg/libexec/singularity/cli/create.exec: line 114: messsage: command not found
Full output in: /tmp/tmp.l5dIKIy0Bj

and I guess since recommended by the wise me set -e -u doesn't run much and fails as well:
$> ./test.sh
Gaining/checking sudo access...
Building/Installing Singularity to temporary directory
Reinvoking in a clean shell
Gaining/checking sudo access...
./libexec/functions: line 234: DEBUG: unbound variable

$> echo $?
1

to enable travis just go to travis-ci.org, login via github, and toggle the switch for this repository among your repositories... let me know if you need more guidance.

I don't know.. may be I could just blame gyn&tonic I had but now ./test.sh fails even on older point, which I think it was working (e.g. e987e239291fbf1fd01087bbf871ad8eec62e935) and moreover fails to run properly if I remove system wide installation of singularity, adjust /etc/sudoers to not env_reset or secure_env but still getting this error:
$> bash ./test.sh
Gaining/checking sudo access...
Building/Installing Singularity to temporary directory
Reinvoking in a clean shell
Gaining/checking sudo access...
 + sh ./autogen.sh --prefix=/tmp/singularity-test.vTyet1        (retval=0) OK
 + make                                                         (retval=0) OK
 + sudo make install                                            (retval=0) OK

SINGULARITY_CACHEDIR=/tmp/singularity-test.vTyet1
PATH=/tmp/singularity-test.vTyet1/bin:/bin:/usr/bin:/sbin:/usr/sbin

 temp working space at: /tmp/singularity-test.vTyet1
 + mkdir -p /tmp/singularity-test.vTyet1                        (retval=0) OK
 + pushd /tmp/singularity-test.vTyet1                           (retval=0) OK

Running base tests...

 + singularity                                                  (retval=127) ERROR
./libexec/functions: line 139: singularity: command not found
Full output in: /tmp/tmp.EGgth3IkPt
bash ./test.sh  11.26s user 0.68s system 73% cpu 16.172 total

so I will get back to the beast tomorrow unless someone just points me to my sin(s) ;)

If you are testing directly from master right now, I am changing a bunch of things. The effects of set -u -e are far and wide! lol... I am dealing with the repercussions. I think I should have taken your advice, and not put it in functions as I may have to change that now.
Standby, working on it now.

Hrmm, it also doesn't help that busybox.net has been having various problems lately! Can you download?
https://www.busybox.net/downloads/binaries/busybox-x86_64

My indispensable piece of advice is to use feature branches instead of avalanche of changes in the same master branch, send them as pull requests and merge when ready.  The effects of set -u -e are far and wide! lol... I am
dealing with the repercussions. I think I should have taken your
advice, and not put it in functions as I may have to change that now.
Standby, working on it now.

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/gmkurtzer/singularity/issues/136#issuecomment-232523494

I am still in the mode of CVS/SVN work I guess... Where master == trunk, and all current and broken stuff goes in there and it filters out to the branches as it stabilizes.
Feature branches? Like from a fork of my own repo, or just work in a local branch and merge when ready?

On the phone doesn't work :-/  the entire site seems to be down
On July 13, 2016 8:21:33 PM EDT, "Gregory M. Kurtzer"<EMAIL_ADDRESS>wrote:

Hrmm, it also doesn't help that busybox.net has been having various
problems lately! Can you download?
https://www.busybox.net/downloads/binaries/busybox-x86_64

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/gmkurtzer/singularity/issues/136#issuecomment-232524069

Yeah, it wasn't working for me either... When I can get back to it, I'll download the busybox static binary and keep it local. Right now I have to test with a debian base image, and bootstrap it every time via test.sh. Not fun.
Thanks!

If it is a matter of time, you might speed things up inside if you install first eatmydata and run installation calls under it... I might find/test instructions later on
On July 13, 2016 9:17:19 PM EDT, "Gregory M. Kurtzer"<EMAIL_ADDRESS>wrote:

Yeah, it wasn't working for me either... When I can get back to it,
I'll download the busybox static binary and keep it local. Right now I
have to test with a debian base image, and bootstrap it every time via
test.sh. Not fun.
Thanks!

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/gmkurtzer/singularity/issues/136#issuecomment-232531311

so what about enabling travis? ;)

Yep, I will look into how to do it at my first opportunity.
Thanks!

Done. Thank you for the great idea and help implementing it!


returns None on empty vec

📝 Summary
Changed drain_new_orders implementation.
Now it returns None if new_orders is an empty Vec
in reference to #180

I believe that https://github.com/flashbots/rbuilder/issues/180 is wrong, just added a comment.


Error while Creating Image for Azure Devops Self Hosted Agents using the image genration helpers

Description
I have been using the image generation helpers and trying to create an image for ubuntu 18.04. The script runs for 3 hours and fails.
Expected behavior
Create an Image for Ubuntu1804 self hosted agents
Actual behavior
I have followed the instructions specified here:  https://github.com/actions/virtual-environments/blob/main/help/CreateImageAndAzureResources.md  to create a image for Ubuntu 18.04 and the script runs for around 3h and fails with the following exception:

Repro steps
Environment:
Os: MacOS
Packer : v1.7.0
PowerShell:  7.0.3
azure-cli: 2.15.1 *
core: 2.15.1 *
telemetry:1.0.6
Az Powershell: 3.3.0
git: 2.20.1
Steps:
clone repo
git clone https://github.com/actions/virtual-environments.git
cd virtual-environments
Import Helper Modules
Import-Module .\helpers\GenerateResourcesAndImage.ps1
GenerateResourcesAndImage -SubscriptionId "******" -ResourceGroupName "" -ImageGenerationRepositoryRoot "$pwd" -ImageType "ubuntu1804" -AzureLocation "eastus" -GithubFeedToken "" -verbose

Hi @Divya1388, could you please share a full log? There are many tests for all installed software, these tests run during image generation and any failed test can throws this error.

Hi @vsafonkin Thank you for the response, i have been building the image on mac and unfortunately i do not have the full logs now. However i observed that the vhd file was created though the build failed.
And yesterday night i have run the image generation on my parallels and fortunately the image was built successfully.
And now this makes me wonder if the build failed because i ran it on Mac

@Divya1388 it shouldn't be the issue since packer is multiplatform — we generate ubuntu images using windows-based agents.
I'm going to close the issue, but please feel free to contact us if you need any help.
Thank you!


Missing location and population data for ESP regions

Tons of ESP regions can't find their respective GeoJSON:
❌ Could not find location Principado de Asturias, ESP
❌ Could not find location Illes Balears, ESP
❌ Could not find location Canarias, ESP
❌ Could not find location Comunitat Valenciana, ESP
❌ Could not find location Comunidad de Madrid, ESP
❌ Could not find location Región de Murcia, ESP
❌ Could not find location Comunidad Foral de Navarra, ESP
And we're missing population data for tons too:
❌ Andalucía, ESP: ?
❌ Aragón, ESP: ?
❌ Principado de Asturias, ESP: ?
❌ Illes Balears, ESP: ?
❌ Canarias, ESP: ?
❌ Cantabria, ESP: ?
❌ Castilla y León, ESP: ?
❌ Castilla-La Mancha, ESP: ?
❌ Cataluña, ESP: ?
❌ Comunitat Valenciana, ESP: ?
❌ Extremadura, ESP: ?
❌ Galicia, ESP: ?
❌ Comunidad de Madrid, ESP: ?
❌ Región de Murcia, ESP: ?
❌ Comunidad Foral de Navarra, ESP: ?
❌ País Vasco, ESP: ?
❌ La Rioja, ESP: ?
❌ Ceuta, ESP: ?
❌ Melilla, ESP: ?

http://www.diva-gis.org/datadown
Spain Administrative areas. ESP_Adm1.shx should be the boundaries you want.
ESP_adm1_json.zip

Population numbers
https://www.ine.es/dynt3/inebase/en/index.htm?padre=517&capsel=525
Municipal breakdown-Download compressed file with the municipal Excel files for each year (latest population totals from January 2019)
Downloadable  in CSV and Json

this is fixed by #228 and https://github.com/lazd/coronavirus-data-sources/pull/8 . Problem was that data is reported by Comunidad Autónoma, but geojson only showed Provincias.


LICENSE

What license is the code under?
Obviously, there's the "Copy the code" section on the home page, but it might be worth adding a license to this repository (like the UNLICENSE) to be more explicit about the copying terms.
It may also be worth considering if you want the code samples to be under a different license than the website itself, but that's up to you - the maintainer(s)

Hey @MarkSFrancis thanks for raising that topic. I have added MIT licence now.  👌


Electricity Maps (Independent Publisher)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[x] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[x] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[x] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree

[[certify-connector]]

Hello @VitaliiSorokin,
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

Hello @Amjed-Ayoub,
Thank you for the update.
I just want to clarify one moment: at what point and by whom my pull request should be merged to the dev branch?

Hi @VitaliiSorokin, After the connector is deployed we will merge the pull request. you can track the progress using this conversation. we will keep you posted.
You should see a label called "deployment-in-progress" once the deployment starts.
Please let me know if you have any questions.
Thank you so much again.

Hello @VitaliiSorokin,
I hope you are doing well.
Your connector is in production deployment and queued up for the next deployment schedule. This process typically takes 3-4 weeks. Please note that the documentation for your connector will not be generated until the deployment process is in the final steps.
Please let us know if you have any questions.
Thank you very much for working with us.

Great news!
Thank you @Amjed-Ayoub!
It was a pleasure to work with you. Looking forward to future cooperation.

Hello @VitaliiSorokin,
I hope you are doing well.
Congratulations, the deployment of your connector and documentation page was already completed, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program.
Thank you very much for working with us.


Creating a branch produces lots of unwanted artifacts

And besides, does not clarify workflow, which implies copying thing from master to branches and update them while debugging.
The documentation should clarify that the files needed are:

action.yml
lib/main.js (or whatever file you're generating)
package*.json
Additionally, README.md and LICENSE, as well as a specific .gitignore.

I think I disagree with this approach. The things you're taking out with that are:

tests
workflow files
and typescript source files

These aren't really going to be significantly large in most use cases and it shouldn't cause problems to have them. The tradeoff is that you make the publishing process harder with more steps (which makes it more error prone and harder to automate), and you lose some readability (I like, for example, having the TypeScript files in the release since its easier for me to tell what's going on)

All that is in the master branch, or maybe a dev branch if you want to go that way. It's not so much about what is nice or not, but the minimum files necessary to make an action work. You can keep the rest if you want, but right now all files are replicated in release branches, up to and including a docs/contributors.md file... Knowing precisely what needs to be in a release branch gives you the ability to decide whether you want to keep the rest of the files or not.
And about workflow, it's very simple to create a commit hook that changes to the release branch and checks out lib/main.js from master every time you change it. No big deal.

What must be in the a branch that runs is the Actions.yml and the javascript file it references.  That's all.  The runner download the contents of that branch and run that entry point.

Closing since question answered.  We covered what's mandatory.  And yes, there's file in the distribution branch that are superfluous.  We are balancing complexity of this template, merges, etc vs optimizing what really isn't a problem (pulling a few text files at runtime)


⚠ Bofrost.lu has degraded performance

In c9cfd05, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1376 ms

Resolved: Bofrost.lu performance has improved in 76ae6ec after 20 minutes.


[Impeller] ImageFilter.blur produces different colors in trivial case

    const Color green = Color(0xFF00AA00);
    final Paint paint = Paint()
      ..color = green
      ..imageFilter = ImageFilter.blur(1.0, 1.0, TileMode.decal);

Drawing that paint and getting 3x3 image from it produces different colors on Skia or Impeller. Bug may be in the code to get the image out.

Also from image_filter_test.dart, color filters, color filter composition, and matrix are broken.
The color filter ones may be related to https://github.com/flutter/flutter/issues/135699


Node.js Install error

when I ran the command
cd Odyssey/odyssey/env/mineflayer/mineflayer-collectblock
npx tsc

I got the errors as follow:
src/CollectBlock.ts:71:59 - error TS2538: Type 'undefined' cannot be used as an index type.

71                                 bot.registry.blocksByName[closest.name];
                                                             ~~~~~~~~~~~~

src/CollectBlock.ts:75:61 - error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.

75                             const item = bot.registry.items[leastTool];
                                                               ~~~~~~~~~

Found 2 errors in the same file, starting at: src/CollectBlock.ts:71

I use node v22.11.0

Mineflayer recommends using a Node.js version between 16 and 18, but I can run it locally with v20.17.0 as well. I suspect that your issue might be caused by the Node.js version being too high.

I ran into the same problem like his. Degrading Node.js version did not help.

This issue might be related to the version of the prismarine-block package. You can refer to the following issues to see if they can help resolve the problem:
https://github.com/MineDojo/Voyager/issues/179
https://github.com/MineDojo/Voyager/issues/127
https://github.com/MineDojo/Voyager/issues/120.

This issue might be related to the version of the prismarine-block package. You can refer to the following issues to see if they can help resolve the problem:

node.js install error
Cannot set up Voyager: system environment issue
npx tsc error TS2345

Solve my problem. It is a version issue with prismarine-block. Thanks.

This issue might be related to the version of the prismarine-block package. You can refer to the following issues to see if they can help resolve the problem:

node.js install error
Cannot set up Voyager: system environment issue
npx tsc error TS2345

Solve my problem. It is a version issue with prismarine-block. Thanks.

Glad to hear that you were able to resolve the issue! Could you please share which version of prismarine-block you used? I believe this information would be very helpful for others who might encounter the same problem.

same problem, I tried several versions but could not solve it.

This issue might be related to the version of the prismarine-block package. You can refer to the following issues to see if they can help resolve the problem:

node.js install error
Cannot set up Voyager: system environment issue
npx tsc error TS2345

Solve my problem. It is a version issue with prismarine-block. Thanks.

Glad to hear that you were able to resolve the issue! Could you please share which version of prismarine-block you used? I believe this information would be very helpful for others who might encounter the same problem.

Actually I did not change the version of prismarine-block, but update mineflayer-collectblock to the newest, which have few changes in src/CollectBlock.ts.
Hopefully that will solve the problem.


cirq_google.get_engine_device('rainbow') is missing connections in the device diagram

How to reproduce the issue
print(cg.Sycamore23)
print("=" * 30)
print(cg.get_engine_device('rainbow'))

                  (3, 2)
                  │
                  │
         (4, 1)───(4, 2)───(4, 3)
         │        │        │
         │        │        │
(5, 0)───(5, 1)───(5, 2)───(5, 3)───(5, 4)
         │        │        │        │
         │        │        │        │
         (6, 1)───(6, 2)───(6, 3)───(6, 4)───(6, 5)
                  │        │        │        │
                  │        │        │        │
                  (7, 2)───(7, 3)───(7, 4)───(7, 5)───(7, 6)
                           │        │        │
                           │        │        │
                           (8, 3)───(8, 4)───(8, 5)
                                    │
                                    │
                                    (9, 4)
============================================================
                  (3, 2)

         (4, 1)   (4, 2)   (4, 3)

(5, 0)   (5, 1)   (5, 2)   (5, 3)   (5, 4)

         (6, 1)   (6, 2)   (6, 3)   (6, 4)   (6, 5)

                  (7, 2)   (7, 3)   (7, 4)   (7, 5)   (7, 6)

                           (8, 3)   (8, 4)   (8, 5)

                                    (9, 4)

Cirq version
v0.12.0.dev

I think this happens because project_id and gatesets are set as None. I agree this should probably raise instead of returning a device with no edges. @dstrain115 Please verify that this is post 1.0, since it's a project health task (raise if API is used in a way it's not supposed to).

@verult Is this issue obsolete?  Can it be closed now?


New attitude... optimism based on latest community call

I watched the latest community call with Bhaskar Vedula (@WhitWaldo thanks for the update) and I've decided to delete my previous comments.

Don't you know you'll catch more bees with honey than taking a dump in the issue tracker?
I too am frustrated with issues I report not being addressed, since my company placed a big bet on Service Fabric. But unless you're paying Microsoft a ton of money, you can't really dictate the choices they make. At least it's open source, and you can debug and contribute fixes.
Service Fabric still works great, and it runs on linux, and allows more efficient (non containerized) cloud utilization than Kubernetes and a lot of features you don't get out of the box with Kubernetes. So you're not helping anyone by pushing the team to cancel the product.
I'm sure the root cause is staffing - the issue you're angry about is VS integration and/or testing the VS template before launch issue, and it's well known that Microsoft de-funded QA teams years ago. So it's likely to be a VS bug caused by lack of testing instead of a problem in Service Fabric proper.
I'm saying this as a user of Service Fabric, I have no affiliation with Microsoft.

Sorry for the delayed response. The fix for this bug would be available to customers in the next minor release for VS 2022, and should make the external preview channel in January. We are also releasing new SF features every month. More details can be found here.
Thanks for your patience!

@mert-microsoft I greatly appreciate the update on this particular issue, but the level of communications from the SF team is just unacceptable. For example,
This repository's home page still shows 9.2 shipping in October.
net7.0 shipped a couple weeks ago, is it compatible with the 9.1 release?
Why doesn't anyone ever respond to issues reported here? Developers are taking time out to report issues with your product, and they're just being ignored.

@jackbond Especially for any specific asks/concerns, I'd encourage you to join the monthly community call and share it with the SF team directly. Personally, I'd enjoy hearing from more customers on the call in general. It's usually held around noon (US central) on the third Thursday of the month. I can share an invite link with you if there's interest.
I asked about .NET 7 on the call last week and they said they'd circle back for the next call with a timeline for support and whether there are any known issues (like .NET 5's binary serialization issue) with just migrating up in lieu of official support. I haven't personally noticed any issues running .NET 7, but I also don't yet have anything running yet on a deployed cluster - just locally.
They also explained that for the last several months, they've been forced to prioritize the recent containerization changes (because of licensing changes) as covered in the first half of the call before the Q&A.
This repository itself is a bit out of date, yes, but the others are alive and get frequent updates (and accept PRs if you're so inclined):
Reliable Services & Actors
Service Fabric Explorer
SF Yarp
Especially if you have an issue specific to any of those in particular instead of SF as a whole, I'd encourage filing the tickets there.

So these calls still exist. Thought they were killed since nothing on those in the blog lately.

So these calls still exist. Thought they were killed since nothing on those in the blog lately.

They did disappear for three months without warning (or I'd have brought up .NET 7 support sooner.
On the last call, they again cited the Mirantis container changes as a big priorities changer, but that they'd be back on track (YARP and Managed SF deployment next-steps cited specifically) by the start of the new year. The call was run by a new-hire to the team, so at least the surface area of who can field questions is expanding too. But they affirmed their intent to keep offering these calls monthly again.

@WhitWaldo - I'm interested in the call. Is the link public?
I see the Service Fabric Webcast Topics form, but it's not clear whether submitting a topic request is required to get invited.

It looks as though this link (pulled from the top of here) will at least get Teams to launch and join the meeting.
To my knowledge, submitting a topic request isn't required so much as just being indicative of what you'd like to talk about in some hand-waving future call.
The call is (nearly) always scheduled for the third Thursday of the month at 10 AM pacific, so I'd expect next month's call to land on the 15th. I'd have to review the recording of last month's call, but I'm pretty sure they said they'd be meeting in December, but there's a chance I'm not recalling that right and they'll instead circle back on 1/19. I've reached out to see if I can get clarification of this one way or another and I'll write back then.

@jackbond I've gotten clarification that the next SF community call is scheduled for Thursday, January 19th at 10 AM PT and can be joined from this link via Teams. I look forward to seeing you there!

Hello all,
We recommend using the Microsoft Q&A forum for general questions/problems as it is way more active. Specific issues against the product are still best filed here on github.
https://learn.microsoft.com/en-us/azure/service-fabric/service-fabric-support#post-a-question-to-microsoft-qa
Copy/pasting the details from the doc.
Get answers to Service Fabric questions directly from Microsoft engineers, Azure Most Valuable Professionals (MVPs), and members of our expert community.
Microsoft Q&A is Azure's recommended source of community support.
If you can't find an answer to your problem by searching Microsoft Q&A, submit a new question. Be sure to post your question using the azure-service-fabric tag. Here are some Microsoft Q&A tips for writing high-quality questions.

@WhitWaldo No call today?

I haven't found anything in the usual places about a call today (which doesn't mean there isn't one). Only Whit's link.
Nothing in the Yammer groups where it used to be announced .

@jackbond  @tuhland  @rathorer I just received word that the next community call will be on January 26th at 10 AM PST. It might be at the same link, but I'm trying to get confirmation of that and see if there's a shareable version I can distribute in the alternative.
I look forward to seeing you on the call!

Could you suggest to them to publish the time / conference link on their blog, https://techcommunity.microsoft.com/t5/azure-service-fabric-blog/bg-p/Service-Fabric Thanks.

Whoops - I misunderstood and there is no community call tomorrow. I'll pass it along, but it's been a while since they posted anything but patch notes on the blog @jackbond

There is a community call tomorrow, 01/26
ACP Webcast: Service Fabric Q&A #67
Microsoft Teams meeting
Join on your computer, mobile app or room device
Click here to join the meeting
Meeting ID: 268 025 107 756
Passcode: Az7VjK
Download Teams | Join on the web
Or call in (audio only)
+1<PHONE_NUMBER>,,347080129#   United States, Los Angeles
Phone Conference ID: 347 080 129#
Find a local number | Reset PIN
Learn More | Meeting options

Confirming we are hosting one at 10am pst today 1/26

Hi,
I want to get involved in these community calls. Is there any central place where the details on these meetings are shared?
Thanks!

@jackbond @rathorer @tuhland @johncrim
@wouterroos I don't know where this is publicly posted, but in light of @vbhaskarrao sharing the call-in details of the last one in this thread, here are the call-in details of the next one:
When: 3/30 at 10 AM PST
Join us March 30th at 10AM PST for our Service Fabric Q&A #68, which will include:
•	Upcoming SF runtime release information
•	Product update/demo: SFMC
•	Q & A
We hope to see you there!
Click here to join the meeting
Meeting ID: 299 788 616 165
Passcode: u8F4Lx
Join on the web

@WhitWaldo Thanks, see you there!

Hi @WhitWaldo . Can we have details for the next meeting? Thanks.

@websolut  @wouterroos @jackbond @rathorer @tuhland @johncrim
Next call is tentatively planned for July 27 at 10 AM PT. I don't have the call-in information yet (usually get it a few days before the call), but I'll share as soon as I have it.

Is there a call today?


Incorrect lights direction when exported to glb 0, 1 or 2 times

Primary playground is #KX53VK#30 testing right handed export to glb.
All bugs could be related, so I grouped them here.
Black triangles
Bug repro: https://www.babylonjs-playground.com/#9DXCHP#1
Expected result: Triangles should be colored
Current result: When scene is exported and imported once (not twice), the triangles are black (unlighted).
Comments:
The light direction is back to front (0,0,-1).
When imported into the sandbox, the triangles are visible due to a default ambient light. The directional light is still back to front and the gizmo toggle has no effect on light direction. Those behaviors in the sandbox are as expected.
Light direction
Bug repro: https://www.babylonjs-playground.com/#KX53VK#30
Expected result: The light should be oriented as initially front to back (0,0,1).
Current result: When scene is exported and imported twice (unmodified playground), the light direction is reversed: oriented back to front (0,0,-1).
Comments:
The gizmo toggle has no effect on light direction (unlike other 2 bugs above).
Triangles are lighted correctly, despite light direction being reversed.
Linked light dummies
Bug repro: https://www.babylonjs-playground.com/#KX53VK#30
Expected result: Each Light dummy should be independant from each other
Current result: the 2 Light dummies, parent of the actual directional light, are someway linked together. Transform edition of one dummy through Inspector impacts the other. Comparing world matrix using the console.
I'm off the office until Monday 6th.
Adding @Jaskar for any question meanwhile.

Adding @thomlucc to track them
@noalak @Jaskar can you guys work on it?

Linking
https://github.com/BabylonJS/Exporters/issues/696
As my test process touches on the light gizmo not aligning with the light's actual orientation

Few initial takeaways:
I'll start by figuring out why the gizmo is improperly oriented/modifies the light orientation on activation in a Right-Handed coordinate space. This seems key to being able to properly visually debug the other elements.
I'd assume that we're just improperly flipping the light direction when exporting the scene. This seems similar to our double root issues addressed via #7257 where we're converting our already converted light transform, but I'll have to look closer into the source to confirm.
@noalak for the linked light dummy issue, you linked to the original PG:
https://www.babylonjs-playground.com/#KX53VK#30
Is this correct? This scene appears to only contain a single light. Also I'm not sure what "light dummy" means in this context, can you please clarify?
Thanks

The light dummies are the light meshes parenting the actual light. They are used as Transform nodes when importing a glTF light.
If you edit in the Inspector the rotation of the node selected in the image above, and then select its parent, the displayed rotation is affected as well.
World matrices of light dummies seem right (the parent world matrix is unchanged). The bug is probably on the Inspector refresh.

Thanks @noalak, I think I have all I need to make progress on this.
I'm moving the gizmo related issue to a separate bug: #7603 as It's not really related to these issues, just a very annoying occurance when trying to reproduce this.

In investigating the light export issue, I am noticing some strange behavior of the lights when we use a right handed coordinate system:
I am using #KX53VK#32 to reproduce this (using my #7603 fix). When I use a right handed coordinate system:

The triangle is black because the face winding doesn't correspond to the normal.
I think this happens because you have 2 swaps in your PG.

one with the positions depending on RH/LH
one with the ComputeNormals
The 1st swap will make the normal flipped (because of the position), then you flip again the normal with the ComputeNormals call.
As the positions correspond to what you want, you don't need to flip the normals a second time.

https://www.babylonjs-playground.com/#KX53VK#33

Ok, the test scene appears to work now, I'm very concerned about the vertex normals in our right handed system now (see https://www.babylonjs-playground.com/#KX53VK#34) :

If we use the vertex normal gizmo, it shows the normals as pointing backwards from the plane? This doesn't seem right either, the generated plane in scene seems generated with proper normal orientation and winding order, but is also lit backwards:

I'm starting to suspect that we're lighting our scene wrong in right handed mode...

After talking with @CedricGuillemet , he pointed me to this thread which prompted the original change to the vLightSpecular direction:
https://forum.babylonjs.com/t/solved-unexpected-light-gizmo-on-right-hand-system/5043/15
This looks eerily similar to the change I just addressed via #7603, looks like we conflated a lighting error with the gizmo error. I believe that it's for the best to fix this, as we can reproduce this regression by modifying this testing scene:
https://www.babylonjs-playground.com/#0YYQ3N#0

by changing the scene handedness before import:

Which causes our poor cat to be eerily lit. Undoing commit https://github.com/BabylonJS/Babylon.js/pull/6712/files/8dcdbf7386243e7acdededa6d8b8ecde436d1b4c#r313200449 appears to fix this regression in combination with the previously mentioned gizmo fix:

Now this causes our original test scene: https://www.babylonjs-playground.com/#KX53VK#30
To fail on validation.  I believe that we originally did not have proper light orientation, as the directional light instantiated in scene was facing (0,0,1) regardless of handedness. I think this one slid through the cracks and our original test scene was not properly constructed.
I will update this testing scene to work correctly as a part of the light direction reverting PR; the lights should face our triangles regardless of scene handedness. The unit tests will be updated to reference:
https://www.babylonjs-playground.com/#KX53VK#35 (Left handed)
https://www.babylonjs-playground.com/#KX53VK#36 (right handed)

It would be good to verify that the double root issue is also fixed once ready.

Regarding the light orientation issue, there are multiple issues happening here:
For one, our lights aren't being properly exported from a right handed scene, they are 180degY off, as the exported node should be oriented such that the light shines towards -Z:

This appears to be caused by using the same calculation for the light's yaw angle given the direction, a right handed system should invert the input direction Z axis to align with the coordinate system:
https://github.com/BabylonJS/Babylon.js/blob/768c2b07c9426f5beb6f6138005d665ae8419a31/serializers/src/glTF/2.0/Extensions/KHR_lights_punctual.ts#L109
In addition, the light direction is toggled, due to a duplication of light dummy nodes. On import, we create a dummy node oriented such that the light has a direction of (0,0,-1) regardless of scene handedness. On export, we preserve that node, and export that dummy node with the light parented to that node as a new node containing the KHR_lights_punctual extension. This node then duplicated on the next import, causing the light to flip direction.

In order to fix this issue, I had to make some alterations to the _applyExtension contract (and affected methods and interfaces that use this contract)
Originally, there was no capability to use or return a null value from an export extension handler method, my changes intended to expand the contract to allow for an extension to "void" an exported null in this case where we don't want to duplicate an existing exported node. From there, all that's needed is to reorient the exported grandparent node of the light to encapsulate the light.