Move aws-sdk out of the dependencies list

Issue #, if available: Resolves #54
Description of changes: Moves aws-sdk out of the aws-xray-sdk-core package dependencies, so as to not bloat project bundles that will be deployed to AWS Lambda Node.js runtime.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It would be fantastic if someone at AWS could review this PR and cut a new release.

This is definitely a reasonable request and we will work with you to fix this as soon as possible. Unfortunately we can't simply accept and merge this PR.
In version 2.0 the SDK has two timers that use aws-sdk to call X-Ray service for fetching sampling rules if running on non-Lambda: https://github.com/aws/aws-xray-sdk-node/blob/master/packages/core/lib/middleware/sampling/service_connector.js. In the current implementation this is not an issue when the user code patches aws_sdk as the two timers use different copies with the user code. But with changing to peerDependencies the X-Ray SDK could use the patched aws_sdk while for the timers there is obviously no tracing context and those calls should not be captured. The aws_sdk patcher code also needs to be fixed so this change doesn't break v2.0 on non-Lambda workload.
The other concern is that for customers running on non-Lambda workload with npm 3 or later, this could be a breaking change since starting with npm v3 it will not install peerDependencies if a package is not explicitly declared as a dependency on higher dependency tree. Developers also would need to manually resolve the conflict if there is one. See https://github.com/npm/npm/issues/6565. (A good thing but still a breaking behavior.)
I agree this PR is a low hanging fruit for Lambda customers but we want to make sure we are also doing the right fix for our non-Lambda customers. Please correct me if I misunderstood any implication of this PR or if you have any thoughts regarding the concerns.

@haotianw465 is there a way to split X-ray core into separate lambda and non-lambda packages to optimize for those usage models?

@haotianw465 would it work to do this in lib/middleware/sampling/service_connector.js:
var XRay = require('aws-sdk/clients/xray');

...
var ServiceConnector = {
  ...
  client: new XRay({endpoint: util.format('http://%s:%d', DaemonConfig.tcp_ip, DaemonConfig.tcp_port)}),
  ...
}

The benefit here is that at least you could tree-shake away the rest of the duplicate aws-sdk package with something like https://github.com/serverless-heaven/serverless-webpack.
An even better solution (that requires more work) would be to update the aws-sdk project with lerna and publish each service client as its own package, similar to the way the aws-xray-sdk project is structured and published. Then you could just require the XRay client and we would all be on our merry ways. But that's a subject for another repo on another day.

@jplock Yes we will look into separating it into two packages. Right now the two use cases (Lambda and non-Lambda) are tightly coupled so this work is not trivia.
@compwright Thank you for your suggestion. We will look into the repo link you provided. We've also forwarded your request on modularizing AWS Nodejs SDK to AWS SDK team.
Right now we are still maintaining 1.x for bug fixes and the only new feature for X-Ray SDK 2.x is service sampling rules which is not applicable on AWS Lambda. You can continue using 1.x if the 2.x bundle size is an issue. We will update this issue as soon as we make progress.

If aws-xray-sdk was provided by default, the way aws-sdk is, then this wouldn't be an issue.

You can omit the aws-sdk during Lambda packaging using most toolsets, but bundling Lodash and Winston is surely not helping. But also, yeah, provided by default!

The size issue was resolved on webpack case https://github.com/aws/aws-xray-sdk-node/pull/73. AWS Node SDK just released v3 in preview which is modularized https://aws.amazon.com/blogs/developer/new-aws-sdk-for-javascript-developer-preview/. I'm closing this PR in favor of https://github.com/aws/aws-xray-sdk-node/issues/82. To @jafl's point we are working with Lambda team with what you are suggesting.

Thanks @haotianw465!  Will you be releasing a new version of this library with the fixes from #73 in it prior to implementing #82?

Not everyone uses webpack, etc.
https://github.com/aws/aws-xray-sdk-node/search?q=lodash&unscoped_q=lodash
I think Lodash could be replaced with vanilla JS in many cases, and at least import the lodash.whatever methods for the ones that can't, not the whole package.
Logging - pino is quite small and fast

@jplock yes we will prepare a release soon regardless of progress on #82.
@dougmoscrop I created #82 so we can fix the non webpack use case and non-lambda use case. We will have to wait for AWS SDK v3 becomes GA before directly depend on it. For loadash changes feel free to open a separate issue or PR and we will keep improving the bundle size.


Readme correction and clarity change

Got rid of dBm for monitoring_status which should be dimensionless
Corrected the monitoring_status template, which was pointing to BLE rssi
Added some clarity about the sensor name. This is subjective but clarity usually helps.

I'd even argue that owlet_monitoring_status is redundant, since that state is already pushed by the main platform: owlet sensor.


Jameswtruher/testgap 004

Hi @JamesWTruher, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jim Truher). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

LGTM

LGTM

it looks like everyone has signed off - can I get a merge?


Random System.AccessViolationException

Hello team,
I met random below exception. I don't know why the exception will be thrown.
Application: NewConsole.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException
at System.Windows.Forms.UnsafeNativeMethods.CallWindowProc(IntPtr, IntPtr, Int32, IntPtr, IntPtr)
at System.Windows.Forms.NativeWindow.DefWndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control.DefWndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control.WmCommand(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control.WndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.ComboBox.WndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control+ControlNativeWindow.OnMessage(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control+ControlNativeWindow.WndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr, Int32, IntPtr, IntPtr)
at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG ByRef)
at System.Windows.Forms.Application+ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr, Int32, Int32)
at System.Windows.Forms.Application+ThreadContext.RunMessageLoopInner(Int32, System.Windows.Forms.ApplicationContext)
at System.Windows.Forms.Application+ThreadContext.RunMessageLoop(Int32, System.Windows.Forms.ApplicationContext)
at System.Windows.Forms.Application.Run(System.Windows.Forms.Form)
at Slb.Horizon.NewUIFramework.NewConsole.Main(System.String[])

Can you provide a sample project?

This doesn't look familiar to me, so I have no clue. In this type of situation, I usually copy my entire test project and delete half of it and see if it still repros. If not, I know part of the the repro is in the part I deleted, and I keep deleting roughly by halves until I figure out what is essential to the repro.
I don't see NUnit in your call stack anywhere. Is this strictly NUnit-related?

I think it isn't NUnit. Because it is random in a complex project, I'd like looking for some clue.

I'd be happy to help, but I have no clue. The best advice I can give is to just start deleting everything you possibly can while keeping still reproducing the problem.
Sadly, this forum isn't a super appropriate place for non-NUnit issues. I'd be happy to hear from you via the email in my GitHub profile if you get stuck boiling down the problem.

@gli27 Oh dear! I mixed up which repository this tab was for, I'm sorry! 😆 Yeah, sorry I don't have any clues. If you delete as much as possible and post that code, that gives folks something to work with.


Support float type

#6

[x] Lexer (supporting 12.34 but not .5 or 2.)
[ ] Parser
[ ] Eval
[ ] Compiler
[ ] VM

f64 doesn't support Eq. If I add f64 to Expression, Expression can't be used as a key for HashMap...

Monkey language supports any expression as a hash map key. Limit what can be a hashmap key, and create another enum for hashmap keys.

In the AST level, HashLiteral should have a list instead of a map to keep entries because the order matters. Then we don't need Expression to implement Hash.


Add support for ES exists query

Ref
It is used in the airmail  project but it may not be needed. It is used to do aggregations only on documents where the field is present.

Done in #3710


[BUG] MTU is overwrite by storage network

Describe the bug

To Reproduce
Steps to reproduce the behavior:

Go to the Harvester network page and add a new clusterNetwork and networkconfig with MUT 9000

the current MTU of both the bridge and bond interface is 9000
config storage network on the settings page and select the above configured cluster network

check the MTU again, and the MTU value of *-br is changed to 1500141: vlan-bo: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 9000 qdisc noqueue master vlan-br state UP group default qlen 1000
142: vlan-br: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default

Expected behavior
the MTU value should be persisted even after configured as storage network.
Support bundle

Environment

Harvester ISO version: v1.1.1
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): All

Additional context
This probably is overwritten by the NAD bridge config, need to check if it can support MTU config
Temp Workaround:
run $ip link set mtu 9000 dev $interface to update the MTU config in all nodes.

connect with https://github.com/harvester/harvester/issues/4353

Supposed to be fixed in https://github.com/harvester/harvester/issues/4353, see comment

Verify fixed for Harvester v1.2.0 (harvester-network-controller v0.3.4)


Exposing App Proxies using LiveView

First off, thanks very much for your work on this tool.
I’m hoping to learn more about whether there are any compatibility issues between Shopifex, LiveView, and Shopify’s App Proxy API, which allows for embedded applications to be inserted into storefronts either as a full page or as a block using theme app extensions.
My understanding is that some additional security restrictions apply with app proxies, but I’m not sure they cannot be overcome. For instance, app sessions are somewhat “sandboxed” to the page that the app proxy loads, as Shopify will block any set-cookie header if it’s returned as a response to the app proxy request. But in the context of the frame, you can establish a connection and authenticate using information Shopify attaches to the app proxy request.
I’m not in a position to test all this at the moment but I wanted to get some thoughts down now and see whether there was something fundamental that I was missing.
I also had not seen an example of Shopifex used with LiveView and so wanted to check that there weren’t any blockers there for any reason. It seems to be that the only important bit would be making sure that LiveView mount properly replicates the Shopifex auth steps for routes that are live-navigated to.

Going to close this; I had some misconceptions that I've since cleared up, and while I think there's something here, the questions as I posed them don't make a lot of sense. I'll consider posting a new issue or making a PR as I get farther along in my integration.

@zachallaun Thanks! What were the misconceptions which you cleared up?
I have experimented with Shopifex and LiveView in the past and it worked perfectly :) I don't know though how this would working with Shopify's AppProxy - would be very interested in hearing about your results!

Thanks! What were the misconceptions which you cleared up?

Mostly around Shopify's integration points. They tend to name a lot of things very similarly and I had just crossed some wires between app bridge (admin-facing) and app proxy (customer facing).
I was indeed able to get LiveView set up and working with app bridge (on the admin side), but I'm worried that it's not going to be possible through app proxies -- I have a hunch Shopify is stripping/blocking some important headers for some http/2 connection upgrade/websocket stuff.
No matter there, though! I can still use the app proxy functionality just fine without LiveView and can even experiment with returning liquid for Shopify to render. There are a few elements of app proxies that I think would be great additions to Shopifex: proxied requests include a signature parameter used to verify that the request was sent by Shopify and a logged_in_user_id (very recent addition) which, in my case, is extremely helpful. I'll have a data model for customers and will likely want some notion of current_customer.
As I learn more, I'll certainly to contribute what I can back to Shopifex if it seems general purpose & useful enough!

@zachallaun

There are a few elements of app proxies that I think would be great additions to Shopifex

It sounds like it; Looking forward to seeing what you are able to contribute!
Another place I am noticing a need is on the fulfillment service API requests that Shopify sends to a FulfillmentService app. They are signed with HMAC but don't seem to use the same algorithm as the webhooks and admin links. Anyways, plenty of room for contributing to this lib :)


Inconsistent behavior when image has a dimension of size of 1.

🐛 Bug

To Reproduce
Create a tif file
Steps to reproduce the behavior:

Create a tif image that has a dimension with size of 1.
e.g. tifffile.imsave('test.tif', numpy.zeros((1, 100, 100))
Open napari and drag & drop test.tif into napari.
Click the 2nd icon from left bottom that has a label of "Toggle of number of displayed dimensions" twice.
A slider now appears.

Expected behavior
It is not really a bug but maybe napari can ignore the dimension of size 1 because it doesn't seem to make much sense to display a slider for this dimension. This could be annoying when the image data somehow has many dimensions of size of 1.

Environment
napari: 0.2.12
Platform: Darwin-18.7.0-x86_64-i386-64bit
Python: 3.7.6 | packaged by conda-forge | (default, Mar 23 2020, 22:45:16) [Clang 9.0.1 ]
Qt: 5.14.2
PySide2: 5.14.2
VisPy: 0.6.4
NumPy: 1.18.2
SciPy: 1.4.1
scikit-image: 0.16.2
Dask: 2.13.0
GL version: 2.1 ATI-2.11.21
MAX_TEXTURE_SIZE: 16384

Please copy and paste the information at napari info option in help menubar here:

Any other relevant information:

Additional context

@li-li-github thank you for the report! I agree that this is inconsistent and undesired behaviour. Hopefully this shouldn't be too hard to track down!

Closed by #1196


Incorrect type for Model class createNotFoundError static method

https://github.com/Vincit/objection.js/blob/73e27d00a6e0ca2ef8e5c43b6214898139183530/typings/objection/index.d.ts#L1588
Hi the types for Model.createNotFoundError seems to be missing 2 arguments?
Should it be static createNotFoundError(ctx: QueryContext, args: CreateNotFoundErrorArgs): Error;

I fixed this yesterday.

I fixed this yesterday.

I see the fix for interface ModelClass in v2.2.10. But its still missing for class Model. Or am I mistaken?

I see the fix for interface ModelClass in v2.2.10. But its still missing for class Model. Or am I mistaken?

Shit! You're right. I'll fix that asap and release v2.2.11

Shit! You're right. I'll fix that asap and release v2.2.11

Fixed in 2af79111a51044c088d0c862015013e28c371e17

Fixed in 2af79111a51044c088d0c862015013e28c371e17


Remove Exposure of TDStatus Errors

Exposure of TDStatus errors should be eliminated to do this the following steps should be followed:

Use a single error domain across the CDT parts of the library -- CDTDatastoreErrorDomain.
Devote a block of 1000 error codes to each subsystem
(replication, attachments, CRUD, indexing).

This allows the developer to see, for example, 1007 and know it's a CRUD
error, and we can expand the error codes produced by a subsystem (up to
999 codes, anyway).

Audit each error site, and decide what the most useful error is, and
whether it needs a unique code.
Wrap TD Errors.
Document all our error codes properly. Using a single domain and
declaring them a single header.

It's worth taking note of SE-0112 which will introduce better bridging into swift and a new macro for Objc errors.

Closing as this library is now EOL and this issue won't be fixed here.
The issue has been tagged EOL in case any forks want to import it.


[Documentation] Version upgrade documents for Recognizers-Text dependency

This PR adds the documentation of changes from utterances results between v1.1.3 and v1.2.6 from Recognizers-Text.
By adding this documentation we expect to be able to reduce the impact on the user's bots and help them solve any issues generated by a version upgrade.

Pull Request Test Coverage Report for Build 76290

0 of 0   changed or added relevant lines in 0 files are covered.
348 unchanged lines in 50 files lost coverage.
Overall coverage decreased (-1.9%) to 78.541%

Files with Coverage Reduction
New Missed Lines
%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
1
95.45%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs
1
82.35%

/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs
1
86.96%

/libraries/Microsoft.Bot.Builder/TelemetryLoggerMiddleware.cs
1
73.94%

/libraries/Microsoft.Bot.Builder.Testing/XUnit/TestDataObject.cs
1
82.35%

/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/HttpHelper.cs
2
90.91%

/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs
2
94.94%

/libraries/Microsoft.Bot.Builder.AI.LUIS/Generator/DateTimeSpec.cs
2
64.29%

/libraries/Microsoft.Bot.Builder.Azure/CosmosDBKeyEscape.cs
2
89.74%

Totals

Change from base Build 76157:
-1.9%

Covered Lines:
4392

Relevant Lines:
5592

💛  - Coveralls


BUG: SNS FIFO topic gives an error

What environment did it happen in?

Crossplane Version: 1.11.2
Provider Version:  xpkg.upbound.io/upbound/provider-aws:v0.29.0
Kubernetes Version: 1.25.3
Kubernetes Distribution: kind

I'm trying to create a FIFO SNS topic using the following yaml file:
apiVersion: sns.aws.upbound.io/v1beta1
kind: Topic
metadata:
  name: some.fifo
spec:
  forProvider:
    policy: |
      {
          "Version":"2012-10-17",
          "Statement":[{
              "Effect": "Allow",
              "Principal": {
                  "AWS": "*"
              },
              "Action": "SNS:Publish",
              "Resource": "arn:aws:sns:*:*:some.fifo"
          }]
      }
    fifoTopic: true
    contentBasedDeduplication: true
    region: us-east-1
    kmsMasterKeyId: alias/aws/sns

This results in the following error:
Events:
  Type     Reason                           Age                From                                            Message
  ----     ------                           ----               ----                                            -------
  Warning  CannotInitializeManagedResource  24s                managed/sns.aws.upbound.io/v1beta1, kind=topic  Operation cannot be fulfilled on topics.sns.aws.upbound.io "some.fifo": the object has been modified; please apply your changes to the latest version and try again
  Warning  CannotConnectToProvider          15s (x4 over 24s)  managed/sns.aws.upbound.io/v1beta1, kind=topic  cannot get a terraform workspace for resource: cannot init workspace: There are some problems with the configuration, described below.

The Terraform configuration must be valid before initialization so that
Terraform can determine which modules and providers need to be installed.
╷
│ Error: Invalid resource name
│
│   on main.tf.json line 1, in resource.aws_sns_topic:
│    1: {"provider":{"aws":{"access_key":"REDACTED","region":"REDACTED","secret_key":"REDACTED","token":""}},"resource":{"aws_sns_topic":{"some.fifo":{"content_based_deduplication":true,"fifo_topic":true,"kms_master_key_id":"alias/aws/sns","lifecycle":{"prevent_destroy":true},"name":"some.fifo","policy":"{\n    \"Version\":\"2012-10-17\",\n    \"Statement\":[{\n        \"Effect\": \"Allow\",\n        \"Principal\": {\n            \"AWS\": \"*\"\n        },\n        \"Action\": \"SNS:Publish\",\n        \"Resource\": \"arn:aws:sns:*:*:some.fifo\"\n    }]\n}\n","tags":{"crossplane-kind":"topic.sns.aws.upbound.io","crossplane-name":"some.fifo","crossplane-providerconfig":"default"}}}},"terraform":{"required_providers":{"aws":{"source":"hashicorp/aws","version":"4.52.0"}}}}
│
│ A name must start with a letter or underscore and may contain only letters,
│ digits, underscores, and dashes.
╵

: exit status 1

If I skip the .fifo in the name, and keep the other params as is, then the topic is never created.  There is no error either, however, the system just continues to show "Creating"
Am I missing something or is there an issue with creating fifo topics using upbound provider?

Hi @mgshirali ! Could you please attach output yaml (kubectl get topic.sns.aws.upbound.io/ -o yaml)?
For now I can reproduce this issue but in case If I skip the .fifo in the name - I can see an error in output:

lastTransitionTime: "2023-04-14T17:32:28Z"
message: 'apply failed: invalid topic name: sometestingfifo: '
reason: ApplyFailure
status: "False"
type: LastAsyncOperation

Hi @svscheg , thanks for taking a look.
Incase .fifo is appended to the name, there  is the below error
apiVersion: sns.aws.upbound.io/v1beta1
kind: Topic
metadata:
  annotations:
    crossplane.io/external-name: some.fifo
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"sns.aws.upbound.io/v1beta1","kind":"Topic","metadata":{"annotations":{},"name":"some.fifo"},"spec":{"forProvider":{"contentBasedDeduplication":true,"fifoTopic":true,"kmsMasterKeyId":"alias/aws/sns","policy":"{\n    \"Version\":\"2012-10-17\",\n    \"Statement\":[{\n        \"Effect\": \"Allow\",\n        \"Principal\": {\n            \"AWS\": \"*\"\n        },\n        \"Action\": \"SNS:Publish\",\n        \"Resource\": \"arn:aws:sns:*:*:some.fifo\"\n    }]\n}\n","region":"us-east-1"}}}
  creationTimestamp: "2023-04-17T03:30:01Z"
  generation: 2
  name: some.fifo
  resourceVersion: "1173559"
  uid: b76b2e1f-eab3-4121-9267-a432597f127f
spec:
  deletionPolicy: Delete
  forProvider:
    contentBasedDeduplication: true
    fifoTopic: true
    kmsMasterKeyId: alias/aws/sns
    policy: |
      {
          "Version":"2012-10-17",
          "Statement":[{
              "Effect": "Allow",
              "Principal": {
                  "AWS": "*"
              },
              "Action": "SNS:Publish",
              "Resource": "arn:aws:sns:*:*:some.fifo"
          }]
      }
    region: us-east-1
    tags:
      crossplane-kind: topic.sns.aws.upbound.io
      crossplane-name: some.fifo
      crossplane-providerconfig: default
  providerConfigRef:
    name: default
status:
  atProvider: {}
  conditions:
  - lastTransitionTime: "2023-04-17T03:30:01Z"
    message: "connect failed: cannot get a terraform workspace for resource: cannot
      init workspace: \e[31m\e[0mThere are some problems with the configuration, described
      below.\n\nThe Terraform configuration must be valid before initialization so
      that\nTerraform can determine which modules and providers need to be installed.\e[0m\e[0m\n\e[31m\e[31m╷\e[0m\e[0m\n\e[31m│\e[0m
      \e[0m\e[1m\e[31mError: \e[0m\e[0m\e[1mInvalid resource name\e[0m\n\e[31m│\e[0m
      \e[0m\n\e[31m│\e[0m \e[0m\e[0m  on main.tf.json line 1, in resource.aws_sns_topic:\n\e[31m│\e[0m
      \e[0m   1: {\"provider\":{\"aws\":{\"access_key\":\"REDACTED\",\"region\":\"REDACTED\",\"secret_key\":\"REDACTED\",\"token\":\"\"}},\"resource\":{\"aws_sns_topic\":{\e[4m\"some.fifo\"\e[0m:{\"content_based_deduplication\":true,\"fifo_topic\":true,\"kms_master_key_id\":\"alias/aws/sns\",\"lifecycle\":{\"prevent_destroy\":true},\"name\":\"some.fifo\",\"policy\":\"{\\n
      \   \\\"Version\\\":\\\"2012-10-17\\\",\\n    \\\"Statement\\\":[{\\n        \\\"Effect\\\":
      \\\"Allow\\\",\\n        \\\"Principal\\\": {\\n            \\\"AWS\\\": \\\"*\\\"\\n
      \       },\\n        \\\"Action\\\": \\\"SNS:Publish\\\",\\n        \\\"Resource\\\":
      \\\"arn:aws:sns:*:*:some.fifo\\\"\\n    }]\\n}\\n\",\"tags\":{\"crossplane-kind\":\"topic.sns.aws.upbound.io\",\"crossplane-name\":\"some.fifo\",\"crossplane-providerconfig\":\"default\"}}}},\"terraform\":{\"required_providers\":{\"aws\":{\"source\":\"hashicorp/aws\",\"version\":\"4.52.0\"}}}}\e[0m\n\e[31m│\e[0m
      \e[0m\n\e[31m│\e[0m \e[0mA name must start with a letter or underscore and may
      contain only letters,\n\e[31m│\e[0m \e[0mdigits, underscores, and dashes.\n\e[31m╵\e[0m\e[0m\n\e[0m\e[0m\n:
      exit status 1"
    reason: ReconcileError
    status: "False"
    type: Synced

I checked this again, and yes incase .fifo is skipped from the name, then I do see the error below (as you've confirmed). I guess I missed it.
  - lastTransitionTime: "2023-04-17T03:35:41Z"
    message: 'apply failed: invalid topic name: some: '
    reason: ApplyFailure
    status: "False"
    type: LastAsyncOperation

So, does that mean there is a bug with creation of fifo SNS topic? Is there a config piece/work around for this?

Thank @mgshirali for confirm error.
Issue will be triaged.
The issue is reproduced on the latest master.

I am blocked by this issue as well.
If the .fifo is removed from the name, the following error occurs:
    - lastTransitionTime: '2023-05-26T18:40:40Z'       message: >-         apply failed: invalid topic name:         resbio-prod-euw2-a-pipeline-work-status:        reason: ApplyFailure       status: 'False'       type: LastAsyncOperation
This is expected, as .fifo is required for SNS fifo topics.
A reasonable solution may be for the provider to automatically append .fifo to the name if fifoTopic: true is set in the resource.

@mgshirali  Wanted to mention a workaround is to set the annotation crossplane.io/external-name to the correct name with .fifo appended.  This will override metadata.name as the name of the resource, and allow the provider to successfully create the SNS topic.

We are blocked by this issue as well.
Look in this documentation we can see:

The name of a FIFO queue must end with the .fifo suffix. The suffix counts towards the 80-character queue name quota. To determine whether a queue is FIFO, you can check whether the queue name ends with the suffix.

I don't think this is a bug, it's just an unfortunate consequence of the naming restrictions. To the extent that the previous behavior was broken, it looks like that was fixed by switching to the no-fork architecture in provider-aws version 0.44.
I just posted a PR which adds two valid examples of creating a FIFO SNS topic, and then ran a test which creates them, imports them, and deletes them successfully. You can see the test logs here until they expire.
You can either use the metadata.name of your kubernetes resource as the name of the topic, and make it end with .fifo (which is allowed, but AFAIK not generally recommended), or you can use the crossplane.io/external-name annotation to set the name of the topic in AWS (which must end in .fifo) according to the aws-specific naming restrictions, and the kubernetes metadata.name can be whatever you want. I gave examples of both in #1031.
It does seem like there are some undocumented (or inconsistently-documented) restrictions on the fifo SNS topic name on the aws side. I didn't exhaustively explore possible combinations, but some of my examples worked and others didn't. If you're running into an invalid name error, please try changing the format of the name to match what aws expects (which is possibly different than what AWS says it expects. I got several names rejected that should have been valid according to what the cloudformation documentation says, but I suspect the docs are wrong.)

I see the same issue occurs in SQS, IMHO it seems to be a bug!

@haooliveira84 can you clarify what precisely you think is a bug? Do the naming conventions I used in the examples I added to the linked PR not work for you?
Something along the lines of "when I X I expect Y but instead observe Z" would be helpful in understanding the issue here.


Fixes 404 to Persistence layer sourcecode

@brendankowitz : Thanks for your contribution! The author, @hansenms, has been notified to review your proposed change.

#sign-off


Add support for several charts

Currently only one pie chart is being displayed even data expects more

Example

Done in 3.1.55

Yes, it works but the legend is duplicated:

It duplicates the legend after clicking 'Show values' button

DSW shows the following:

The original in DSZ is:

[ ] add titles for each diagram
[ ] make the same types of the charts (latest example)

example needed


Issue #2026 Retry Subworkflow Mechanism

Issue #2026:
The requested changes from the previous Pull Request are made:
Pull Request #2025 Fixed the retry mechanism for subworkflows so that retry starts from the last failed task.
co-authors: @grkn @azb96
Please guide through the contribution process @kishorebanala @apanicker-nflx @aravindanr @jfernandez

Our build is failing with this error. Can you help us please?
@kishorebanala @apanicker-nflx @aravindanr @jfernandez
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
No stopped containers
> Task :conductor-mysql-persistence:integrationTestDockerComposeUp FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':conductor-mysql-persistence:integrationTestDockerComposeUp'.
> Exit-code 1 when calling docker-compose, stdout: N/A

Our build is failing with this error. Can you help us please?
@kishorebanala @apanicker-nflx @aravindanr @jfernandez
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
No stopped containers
> Task :conductor-mysql-persistence:integrationTestDockerComposeUp FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':conductor-mysql-persistence:integrationTestDockerComposeUp'.
> Exit-code 1 when calling docker-compose, stdout: N/A

Pull Request Test Coverage Report for Build 4979

46 of 70 (65.71%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 70.135%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/main/java/com/netflix/conductor/service/WorkflowBulkServiceImpl.java
0
1
0.0%

grpc-server/src/main/java/com/netflix/conductor/grpc/server/service/WorkflowServiceImpl.java
0
1
0.0%

core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
44
66
66.67%

Files with Coverage Reduction
New Missed Lines
%

core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
1
85.58%

Totals

Change from base Build 4958:
0.03%

Covered Lines:
13043

Relevant Lines:
18597

💛  - Coveralls

Pull Request Test Coverage Report for Build 4979

46 of 70 (65.71%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 70.135%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/main/java/com/netflix/conductor/service/WorkflowBulkServiceImpl.java
0
1
0.0%

grpc-server/src/main/java/com/netflix/conductor/grpc/server/service/WorkflowServiceImpl.java
0
1
0.0%

core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
44
66
66.67%

Files with Coverage Reduction
New Missed Lines
%

core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
1
85.58%

Totals

Change from base Build 4958:
0.03%

Covered Lines:
13043

Relevant Lines:
18597

💛  - Coveralls

@kishorebanala could you please review our PR?

@kishorebanala could you please review our PR?

@mehmet-islamoglu @grkn @azb96 Great work so far, thanks for the contribution.
Regarding your question about progressing the PR, let's finalize the review and we'll take it from there to merge it. In general, after merging to dev, we batch merge dev to master and cut out a new release tag.

@mehmet-islamoglu @grkn @azb96 Great work so far, thanks for the contribution.
Regarding your question about progressing the PR, let's finalize the review and we'll take it from there to merge it. In general, after merging to dev, we batch merge dev to master and cut out a new release tag.

Hello @kishorebanala,
We have completed all of your requested changes. Could you please review our PR again?

Hello @kishorebanala,
We have completed all of your requested changes. Could you please review our PR again?


Build(deps-dev): Bump prettier from 2.5.0 to 2.5.1 (#2094)

Pull request opened by the merge tool on behalf of #2094

Merged in 265b19fbf41e435a6a6e600344adb848347b4919


NClientV2 "no entries found"

it says "no entries found" how i fix it?

You sadly can't. Check #433 for a explanation why.


[RFE] Reporting container pid for trace exec gadget

Add for built-in trace exec and image-based trace-exec gadgets the ability to report the container pid for process events which originated from that container

I started #3501 but I will not have time to complete it this month. If someone wants to pick it up, feel free to do it.


Add random 3 ‘Friends of Rust’ to the front page

#477 Can spend some more time tweaking the styling, though it seems to be quite alright reusing the same CSS.
r? @brson

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Can you maybe host this somewhere so we can check it out?

Here it is: http://rust.terhix.com/en-US/

Oh this is awesome.
It's almost perfect the way it is, but a few observations:
With all the whitespace when there is no hover the "all friends of rust" looks pretty disconnected from the rest of the page. Since the "Friends of Rust" header links to the same place, can we try just removing the "all" link?
Once we do that we've got just the one header line to express everything we can. Right now it is "Friends of Rust (organizations using Rust in production)". When I read that I think it's quite verbose for what it is conveying. But at the same time that's exactly what the 'friends' page says, so it makes sense.
I like what the ember page says for this, "who's using ember?". It gets the point across with few words, but unfortunately on our page we used different terminology, the reason being (as i recall) we wanted to emphasize the 'production-ness' of the users, vs. e.g. open source organizations.
I'm inclined to try this: center "Friends of Rust" and remove "organizations running Rust in production". It won't be clear what 'friend' means, but if they click through it will be made obvious.
Do you mind making those changes? This will probably require a few rounds of iteration.
Thanks @maciejhirsz !

Sure thing! Don't have time right now, but I'll get to it.

Oh this is so cool!
One issue with this on my screen:

that is, it just cuts off before the "all friends" thing. Not sure if that's something that can be fixed, exactly....

I think it could be made clearer that this is a subset of the friends of Rust -- I didn't find that obvious at first. I'm not sure the best way to do that though. :)

Applied @brson's suggestions, updated version at the same url.

Thanks @maciejhirsz. Can we try one more iteration?
I have a few outstanding concerns: that 'friends of rust' doesn't indicate clearly enough what it means, nor that there are more than just three; that the centered header in that location feels unbalanced.
So I think it makes sense to say something like "See more Rust production users", but it really only makes sense to say that after we've shown them some production users (like your original footer). But putting that footer there makes the hover whitespace looks super wierd.
So can we try: removing the hover descriptions entirely (they can see them on the friends page); moving the "Friends of Rust" header to beneath the logos, leaving about as much vertical whitespace as the current header takes up now; changing "Friends of Rust" to "See more uses of Rust in production", with only "uses of Rust in production" being a link (so that the contrast between "see more" and "uses of..." strongly indicates it can be clicked.
Thanks for your patience.

Updated, it does feel like an improvement. I'm tempted to add a period after the link now that it's more of a sentence.
I don't mind iterating further with this and trying things out. At times I might be slow to respond with changes :).

@maciejhirsz I agree it's begging for a period. Please add.
With that I think this is a pretty great checkpoint. Let's deploy and live with it a while and see what people think.

@maciejhirsz Oh, I'm noticing that I see Xero every time I load the page. Do you see that? Is there an error in the math?

cc @rust-lang/core

@brson - maybe it's just your browser?

@brson Nope.
Could make it pick 3 random indexes instead to make it faster, but as far as the correctness goes it should be solid.

@maciejhirsz - after playing with it a little more I'm starting to see the same pattern.  Maybe we should be on the safe side and switch up the way we're picking them

Weird, let me try picking the indexes instead...

I like the idea of this change, but the current version gives me mixed feelings. In particular, it makes the home page feel a bit cluttered, as also feels a bit as if we're displaying advertisements. (Note also that the logos are as big, or bigger, than our own logo!) I wonder if there's some different way of styling this that would make it feel more natural?
I think part of the issue may be that the hope page tries to fit in a literal page, which has kept it very focused. This feels like a departure, and might work better in the context of a page with more sections, e.g. the Typescript home page, where we could more clearly delineate. We could reap some additional benefits by having some other home page sections, but obviously that would be part of a more substantial revamp...

@aturon - to make it feel less like an advertisement, what if there was a line between the friends and the bottom of the example.  something like:
               --------- Friends of Rust ---------
              [ image]          [ image]          [ image]

I feel less certain about myself trying to be clever here than I did with the simple shuffle + slice, let me know if it seems wonky.
Re the design: a separator alike one present on other pages above headlines might help. Even without a headline it should make the 3 logos and the text below them seem more like a single unit unrelated to the rest of the page.

OK, sorry for the delay.
The core team had some high-bandwith discussion about this and unfortunately want to scale back our ambitions for now.
The problem we see is that with the current minimal front-page design, putting these logos on their gives them very strong prominence. They are bigger than the Rust logo! If you compare our page to e.g. typescript, they are way less in-your-face. And the reason for this seems to be pretty fundamental - they've just got a lot more content, so the page is structured into sections, where the later sections are clearly less important. On the Rust page, you look at it, and the impression is that these companies are of prime importance to Rust.
So until we are able to do a wholistic redesign, the desire is to not use logos.
As an alternative, what if we figure out how to adjust the 'sales pitch' section, and change the text of 'show me!' to something else that links to the friends page?
Some options:

"See how Rust is used in production."
"See who's using Rust in production."
"See who's using Rust."
"And it's used for serious business, in the real world."

The style and layout may need to be tweaked to make it pretty. Not sure.
cc @rust-lang/core any opinions?

I personally like "See who's using Rust", short and sweet and gets the point across

I personally like "See who's using Rust", short and sweet and gets the point across

+1 on that!
To restate my earlier point, it's not just about the prominence of the logos, but the fact that the overall web design just doesn't lend itself well to this kind of addition (without it strongly feeling like a cluttered ad). I think we definitely want something like this original PR eventually, but as part of a larger revamp. Doing it textually for now is a good incremental step.

Closing in favor of https://github.com/rust-lang/rust-www/pull/536. Sorry for the hassle @maciejhirsz. It's entirely my fault.


Fixed Crash in create_driver_utils.py

Error in create_driver_utils.py, line 226, in create_selenium_driver:
NameError: name 'SessionNotCreatedException' is not defined
Fix was to just import the correct exception type.

Hi Dan,
Thank you for submitting your pull request for bug fix.
We have decided not to proceed with merging this feature. Our current decision is based on the fact that we have already resolved this issued in botasaurus v4.
We genuinely appreciate your initiative and the work you put into this.
Thanks again for your understanding :).
Best,
Chetan


eng-england/2003-04/1-premierleague.txt  File is empty

This file is empty
eng-england/2003-04/1-premierleague.txt

It's a place holder.


A.2 Motivation and use cases - Link to EU OPD should be deleted

A small change is needed in "A.2 Motivation and use cases" in https://github.com/SEMICeu/GeoDCAT-AP/blob/gh-pages/drafts/3.0.0/index.html
Current text:
..."such as the European Union Open Data Portal (EU ODP) and the European Data Portal (EDP)."
Change to:
...such as data.europa.eu, the official portal for European data.
Reason:
There are no longer two European data portals since ODP and EDP were combined in 2021. The official name for the current portal is data.europa.eu.
Thanks!
Antje Kügeler, con terra (contractor working on data.europa.eu)

Fixed in https://semiceu.github.io/GeoDCAT-AP/drafts/3.0.0/


[Feature Request] Confirmation on Book Title before immediate download

since the current version of this build has you type the 5 digit number instead of whole url, can you add a step between the first and immediate download to have it confirm the title of the book?
thanks! i love this tool

Oops, haven't noticed the issue.

since the current version of this build has you type the 5 digit number instead of whole url,

That's not the case. You can input the whole url, like this:
https://www.royalroad.com/fiction/55212/pyrebound
or the url trimmed down to the whole number:
https://www.royalroad.com/fiction/55212
Hope that helps. Feel free to reopen if you have more questions.

Updated the README to make it a bit more clear.


'cargo test' fails when programs in examples/ subdirectory have dependencies

I have a library with examples in an examples subdirectory. The examples have their own Cargo.toml and build.rs files. Recently, I started seeing errors when running cargo test from the library's root directory, because Cargo was trying to build the examples but was ignoring the Cargo.toml files.
I've resorted to this workaround: https://github.com/capnproto/capnp-rpc-rust/blob/768f74aa702a7360ec037e7f3eb952e04572848a/Cargo.toml#L27
On IRC, panicbit suggested:

At any rate, I think an simple rule for cargo to follow would be to simply ignore any dirs and subdirs that contain a Cargo.toml

As another workaround, I could rename my directory to something other than examples/. Unfortunately, that would break a bunch of documentation links.

Nah this seems like a fine feature to add to me!
FWIW this is because Cargo now thinks that examples/foo/main.rs is an example called foo. (the main.rs is required there as an exact name). If you rename examples/pubsub/main.rs to examples/pubsub/src/main.rs I believe Cargo won't be building the examples automatically for the parent project. (although that's not as great of a solution as just ignoring dirs with Cargo.toml in them.

Note: there is now also package.autoexamples = false
Unsure how safe it would be for us to stop auto-discoverying some packages (if a Cargo.toml is present).  Since we have a way to turn auto-discovery off, I lean towards sticking with just that.  I propose that we close this.

Thanks for triaging such an old issue. Agree with you on package.autoexamples = false approach. Closing.


Update protobuf

I need to use a protobuf>4.0 for some workload (typically insighface take up to 30sec to launch because of protobuf 3, with protobuf 4 and 5 this is nearly instant, see https://github.com/cubiq/ComfyUI_IPAdapter_plus/issues/238#issuecomment-1903230961). However seems like modal is not liking it:
modal 0.61.1 requires protobuf!=4.24.0,<5.0,>=3.19, but you have protobuf 5.26.0 which is incompatible.

What did you suggest  ? Any reason why your blocking protobuf <5.0. Did you think I can install some 4 version ?

Hey, protobuf 5 is quite new and we haven't had a chance to test whether it causes any problems for modal. But as the error message suggests, you should be able to install protobuf 4 (aside from the specific 4.24.0 release, which had some issues).

Seems that everything is fine with pip install --upgrade protobuf==4.*. I'm closing the issue !

Hey, just flagging that we had a chance to test out protobuf 5.26.1 and didn't see any issues, so the latest release of the client will be marked as compatible with it.


FEATURE: MPNT-31 Update ldm json

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-oss-check/17/ : SUCCESS in 7s

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gdc-public-demos-gate-PR6
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-fossa-scanning-zuul-el7/5/ : SUCCESS in 1m 01s (non-voting)
https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-sonarqube-scan-zuul-gate/5/ : SUCCESS in 34s
https://checklist.intgdc.com/job/compliance/job/gdc-public-demos-merge-compliance-check/6/ : SUCCESS in 24s


Adapt uninitialized_copy and uninitialized_copy_n to C++ 20

Adapted uninitialized copy and uninitialized_copy_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668

retest lsu

retest

launch perftests

retest lsu

retest lsu

@Jedi18 same here, i.e. this one also needs a rebase after #5389 was merged.

PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill


Strict mode

Directly changing the state property from outside will occur an exception.
You can change it through “mutations”, or you can get it via “getters”.

LGTM 👍
見ました！


Results download broken

Example:
https://run.api.biosimulations.org/results/6134edbdd73440e9b686f488/download

Still running into this issue. Might be a change on the unconn side.

Was a config error. Storage endpoint was not set in the config, so the default value was selected. The default value has http as the protocol instead of https. The default value should be updated

:tada: This issue has been resolved in version 4.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


New Provider: BackBlaze B2

It would be nice to have access to BackBlaze B2 online storage.
https://www.backblaze.com/b2/cloud-storage.html
API Docs:
https://www.backblaze.com/b2/docs/
Cheers

Vote for this new provider, if you would like to see it implemented.

You should be able to use the S3 SDK. Just leave things as textboxes and let people enter the info themselves, then it should work for any S3 compatible provider, not just Backblaze.
Example for MinIO:
RegionEndpoint = RegionEndpoint.USEast1, // MUST set this before setting ServiceURL and it should match the `MINIO_REGION` environment variable.
ServiceURL = "http://localhost:9000", // replace http://localhost:9000 with URL of your MinIO server
ForcePathStyle = true // MUST be true to work correctly with MinIO server

Backblaze allows you to setup an account and has a generous free tier, so you can play around with it.
New Provider: S3 Compatible
Options:

Access Key - nothing different from AWS
Secret Key - nothing different from AWS
Endpoint - Type: textbox
Region - Type: textbox
Path Style - Type: checkbox (probably checked by default)

If you allow any hostname to be entered, it could easily work for any S3 compatible provider, including ones you host yourself (MinIO).
https://docs.min.io/docs/how-to-use-aws-sdk-for-net-with-minio-server.html

@AIVAS001 @vrelk
Please test Beta-Build from https://github.com/Kyrodan/KeeAnywhere/issues/252#issuecomment-782150223

Releases v2.0.0 today.


Demotion in Ellipses conversions?

The size field is optional for some argument types. When no size prefix is specified, the formatter consumes integer arguments—for example, signed or unsigned char, short, int, long, and enumeration types—as 32-bit int types, and float, double, and long double floating-point arguments are consumed as 64-bit double types.

Um, why is a long double getting demoted to a double?  That makes no sense.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78bd3fde-7eae-a126-f330-563d912a1fab
Version Independent ID: b6f2df29-3154-05ec-4c9b-9dbd8c316dd3
Content: Format Specification Syntax: printf and wprintf Functions
Content Source: docs/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions.md
Product: visual-cpp
GitHub Login: @corob-msft
Microsoft Alias: corob

@Ma-XX-oN In the Microsoft compilers, double and long double have identical representations even though they are treated as distinct types. Both are already 64-bit types, so no demotion that loses information is taking place here.

Just here, or every place where we mention the long double type? There are a few hundred of those, so rather than mention it in all of them, we rely on readers to be familiar with the fundamental types and their Microsoft-specific implementation details. This is one of the first things to learn when you want to write portable code; compilers differ in their implementations of these types, and that's perfectly valid according to the standard.


TransformerChain

Concepts introduced in this tutorial inconsistent with others. Concepts to introduce are IEstimator, ITransformer, IDV and PredictionEngine. Follow recommendation engine tutorial for reference.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77fc5686-2288-d607-8136-3146ed02dbf6
Version Independent ID: 8a16b9e9-b5cb-a55e-2135-191bc62c1656
Content: Classify GitHub issues - multiclass classification - ML.NET
Content Source: docs/machine-learning/tutorials/github-issue-classification.md
Product: dotnet-ml
GitHub Login: @JRAlexander
Microsoft Alias: johalex

This should be resolved in the above PR.


NimBLEServerCallbacks won't call onConnect(BLEServer*, NimBLEConnInfo&)

Hi,
I'm using this library in version 1.4.1 and identified an unexpected behaviour with server callbacks.
Here is the init code I'm using:
class ServerCallbacks: public NimBLEServerCallbacks {
    void onConnect(BLEServer* pServer) {
      deviceConnected = true;
    };

void loop() {
  log("deviceConnected: " + std::to_string(deviceConnected));
  }
}

BLEServer *pServer;
NimBLEDevice::init(BLE_NAME);
pServer = NimBLEDevice::createServer();
pServer->setCallbacks(new ServerCallbacks());

I implemented the server callbacks as shown and, in this situation, the deviceConnected variable is correctly set when my android device connects:
ble-master | deviceConnected: 0
ble-master | deviceConnected: 0
ble-master | deviceConnected: 0
// Android device connecting
ble-master | deviceConnected: 1
// The callback is called
ble-master | deviceConnected: 1
ble-master | deviceConnected: 1

On the other hand, while using the complete prototype for onConnect(BLEServer*, NimBLEConnInfo&), the callback is not called at all. With:
class ServerCallbacks: public NimBLEServerCallbacks {
    void onConnect(BLEServer* pServer, NimBLEConnInfo& connInfo) {
      deviceConnected = true;
    };
}

nothing happens
ble-master | deviceConnected: 0
ble-master | deviceConnected: 0
ble-master | deviceConnected: 0
// Android device connecting
ble-master | deviceConnected: 0
ble-master | deviceConnected: 0
ble-master | deviceConnected: 0
// Nothing happens

I double checked that the only difference between both tests is changing the function prototype from
onConnect(BLEServer* pServer) to onConnect(BLEServer* pServer, NimBLEConnInfo& connInfo).
As I need the connInfoparameter, this bug is a bit annoying.
Any idea ?

You are using v1.4.1, try switching to the master branch if you want to use the latest function signature, otherwise change to the old sig that takes the ble_conn_desc struct.

you can add  override.
class ServerCallbacks: public NimBLEServerCallbacks {
void onConnect(BLEServer* pServer,BLEConnInfo& connInfo) override  {
deviceConnected = true;
};
void loop() {
log("deviceConnected: " + std::to_string(deviceConnected));
}
}

Closing this, please reopen if still an issue.


Set up Dependabot group for devDependencies

Current dependencies on/for this PR:

main

PR #114   👈

This comment was auto-generated by Graphite.


Sky issues

i use the materials bin of version 3.3 and the 3.3 resource pack and it did not work for me.the sky is glitching and i cannot enjoy this shader
for more details that might fix my issue
here are my PC specs
CPU: Intel Core i7-11700F
GPU: RTX 3060 TI Ventus 2x 8G V1 LHR
RAM: DDR4 16gb
SSD: 512 GB
OS: Windows 10
DirectX: DirectX 12

pls help me


Custom InfoCard background

What's more, if the header background and the infocard background do not use geo in the mean time, we should find a way to remove geopattern to avoid it be bundled in.

About this, do you have any good ideas? I don't know if we can use import() to dynamically load Geopattern.And this method seems to need to configure Syntax Dynamic Import Babel Plugin in chainWebpack.

Another way is to use define (webpack alias) to point geopattern to an empty file.


Apple silicon support?

Describe the bug
When running the ibazel version downloaded by npm I get the following error on an M1 Mac:
ibazel run //src:devserver
FATAL: Your platform/architecture combination darwin - arm64 is not yet supported.
    Follow install instructions at https://github.com/bazelbuild/bazel-watcher/blob/master/README.md to compile for your system.
node:internal/validators:119
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "file" argument must be of type string. Received an instance of Promise
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:119:11)
    at normalizeSpawnArguments (node:child_process:503:3)
    at spawn (node:child_process:691:13)
    at main (/Users/jakob/.nvm/versions/node/v16.11.1/lib/node_modules/@bazel/ibazel/index.js:82:18)
    at Object.<anonymous> (/Users/jakob/.nvm/versions/node/v16.11.1/lib/node_modules/@bazel/ibazel/index.js:96:3)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Steps to reproduce the behavior:

git clone git@github.com:bazelbuild/rules_nodejs.git
cd examples/angular
ibazel run //src:devserver
See error

Version (please complete the following information):

OS: macOS Big Sur 11.6
ibazel version: -
Bazel version: 4.2.1-homebrew

I believe this is another urgent thing to work on @achew22 as both bazelisk and bazel already supports darwin_arm64 natively.

This issue is still a problem.


Replicate backlog priority in Azure Devops

Hi,
Is it possible for the work items in Azure DevOps (in backlogs) to appear in the same order as in JIRA.
Currently, the open work items in Azure DevOps are are ordered based on the creation date in JIRA.

Good point and that makes sense. We'll investigate.

Is this planned to be done anytime in the near future? We'd like to do a heavy migration from Jira to ADO, but this is a big blocker for my organization.

We're planning for an update in a couple of weeks, I'll investigate this tomorrow and see if we can get this done soon(ish). I assume you are using the default rank to order the backlog in Jira and have that come over to Azure DevOps?

Correct. What seems to happen is that the ADO tickets are ordered by the Jira ticket # (i.e. by created date, ascending)

I took a look at this and it looks pretty straight-forward to convert the string value the rank has in Jira (using a form of lexicographical ordering) to a number. We could then just use that value as the backlog ordering and the Jira order will be preserved. It may however conflict with other Azure DevOps items in the backlog when existing and new items are merged in the backlog list. But I think that's ok in this scenario, you can easily import the Jira issues to an isolated area path and then figure out how to merge with existing items.

Can you elaborate a bit more on the conflicts? When we've used this migrator, we always put the migrated items into an isolated area path. If I'm interpreting what you're saying correctly, that means we shouldn't have too much to worry about.

Exactly, if you use an isolated area then it would work just right. If not then existing items may potentially have the same rank or new items may get inserted between existing items which for a large backlog will be less ideal I suppose. But I don't think that's a particularly big problem and we would make this an opt-in behavior in the tool so you could choose if you want the original order or not. Makes sense?

Sounds good to me.
From: Mathias Olausson
Sent: Friday, August 2, 2019 11:24 AM
To: solidify/jira-azuredevops-migrator
Cc: Dan Miller; Comment
Subject: Re: [solidify/jira-azuredevops-migrator] Replicate backlog priorityin Azure Devops (#64)
Exactly, if you use an isolated area then it would work just right. If not then existing items may potentially have the same rank or new items may get inserted between existing items which for a large backlog will be less ideal I suppose. But I don't think that's a particularly big problem and we would make this an opt-in behavior in the tool so you could choose if you want the original order or not. Makes sense?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Replace header image

In my view, if we make the header in this way like first the heading will be written in English then below that in Hindi.
I want to work on this issue. Assign it to me @QAZIMAAZARSHAD

Okk go ahead.

@RahulBansal0502 you can replace the 'register to vote' image in the header with flag.png on every page.

I will replace this but this is not a Level0 issue. There are so many loop holes in the code.

I will replace this but this is not a Level0 issue. There are so many loopholes in the code.

@RahulBansal0502 you have to only replace vote.png with flag.png on three pages.
I don't think this is anyway a little more than zero level.
Also, the levels label in the issue is just temporary, most of the times I have increased or decreased the level according to the efforts of the contributor, lines of code written and the PR made.

Oh ok, I understand now I have to only replace my header image now only.


Make Exists Mode for QueryParameters support empty parameters

Discussed in https://github.com/microsoft/reverse-proxy/discussions/2553

Originally posted by ppv-milestone July 17, 2024
We need to match queries to an interface that accepts a request like this:
http://path/component?hello
But according to documentation the "Exists" Mode in QueryParameters will only match against non-empty parameters and our tests show that Prefix, Exact and Contains seem to be following the same (providing "" as a value to match for causes the service to fail).
Also tried with regular expressions in Path, but those does not seem to match on parameters.
Anyone has a workaround for this? Or maybe supporting empty parameters for Exists could be supported in next version?
Thanks a lot in advance!
Br,
Peter

FWIW the query parameters here is matching what we do for headers:
https://github.com/microsoft/reverse-proxy/blob/b1a1d8b20a2ff599517705771ce87614799e8ceb/src/ReverseProxy/Routing/HeaderMatcherPolicy.cs#L78-L83
https://github.com/microsoft/reverse-proxy/blob/b1a1d8b20a2ff599517705771ce87614799e8ceb/src/ReverseProxy/Routing/QueryParameterMatcherPolicy.cs#L77-L81
and the behavior was intentional for headers at least.
I'd find it surprising if the two were inconsistent.

FWIW the query parameters here is matching what we do for headers:
https://github.com/microsoft/reverse-proxy/blob/b1a1d8b20a2ff599517705771ce87614799e8ceb/src/ReverseProxy/Routing/HeaderMatcherPolicy.cs#L78-L83
https://github.com/microsoft/reverse-proxy/blob/b1a1d8b20a2ff599517705771ce87614799e8ceb/src/ReverseProxy/Routing/QueryParameterMatcherPolicy.cs#L77-L81
and the behavior was intentional for headers at least. I'd find it surprising if the two were inconsistent.

Why do you assume the behavior was intentional for headers and not just the easiest approach? To me it sounds a bit counter-intuitive that Exists goes on whether it has a value instead of whether it actually is present or not - both for headers and query parameters.

It was intentional for headers. Empty headers have no semantic meaning and may be dropped by intermediaries.
The query situation is a bit different. We assume key-value pairs (?key1=a&key2=b), but having a single key without an equals sign is still meaningful (?key1&key2). AspNetCore isn't great at representing this case, it doesn't distinguish between key1= and key1.


app closed / app background

Hi,
the plugin work when app is closed? Not in background, but closed.
Thank you in advance.
Francesco

@fcavola The plugin won't work when the application is closed.

Hi
I am wondering about the same thing, but also wondering if it is possible to do so like Whatsapp does. They seem to be running in the background, even when the app is closed off.

I'm having the same problem, I need to run my app on background before "deviceready" is fired.

Hi. To do something like WPP, I recommend that you read about apple push notifications.

@fcavola The plugin won't work when the application is closed. Anything else requires a native application logic out of the web view.


More magic ✨

PR comments
Commit messages
Alias URLs
Anything else?

GitHub added Job Summaries to Actions announcement here from 09 May, which could be a nice addition, bringing it closer to how the App commented after deployment

It seems like most of this is being tracked in other issues.


Error caused by using Content Type: image/jpeg

Describe the Bug

Normal use of type=application/octet stream will not result in an error. The image can be displayed normally
Steps to Reproduce
Configure in the initWADOImageLoader.js file,
Const xhrRequestHeaders={
Accept: appConfig.omitQuotationForMultipartRequest
Multipart/related; Type="/"; Transfer syntax=* '
:'multipart/related; Type="/"; Transfer syntax=* ',
};
The current behavior
Configuring this causes the image to not display properly
The expected behavior
const xhrRequestHeaders = {
Accept: appConfig.omitQuotationForMultipartRequest
? 'multipart/related; type="/"; transfer-syntax='
: 'multipart/related; type="/"; transfer-syntax=',
};
The image can be displayed normally
OS
windows 10
Node version
v16.16.0
Browser
Chrome 119.0.6045.159

Only MR type images have problems

Can you try again OHIF master branch, this might have been fixed


How to understand position embedding?

Can you explain codes in https://github.com/soskek/attention_is_all_you_need/blob/master/net.py#L308-L340, I have to implemented the code of another similar paper which is inspired by "all you need": https://arxiv.org/pdf/1711.11575.pdf , in bottom of page 3. The author said: This 4-d feature is embedded to a high-dimensional representation by method in [49], which computes cosine and sine functions of different wavelengths. The feature dimension after embedding is dg.
How to understand the position sin& cos embedding, I have read the two paper, And I still can not understand this part.

Can you help me, please!

If you want to ask about an algorithm or content itself in the papers, it would be better to ask the authors.

Why the code of position embedding of https://github.com/soskek/attention_is_all_you_need/blob/master/net.py#L308-L340 and https://github.com/soskek/attention_is_all_you_need/blob/master/Observe_Position_Encoding.ipynb is different? Does they do the same thing??
Can you give me some insights about how to understand it? Or does it just replicate of paper formular?

@soskek I test the two function results. which is different of calcuate result?

As my comment out in the code already said (Implementation in the Google tensor2tensor repo), it is used in tensor2tensor official implementation.
https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/layers/common_attention.py#L359-L403
For question about that, it would be better to ask the authors or contributors of the repository.


Compilation errors

I had a couple of compilation errors while trying to build the latest version.

SoftU2FDaemon had a missing RuntimeIdentifier and required C# version 9.0.  The fix was to add the following lines to SoftU2FDaemon.csproj

	<RuntimeIdentifier>win10-x64</RuntimeIdentifier>
	<LangVersion>9.0</LangVersion>

SoftU2FDriver SIGNTASK needed a File Digest Algorithm. This required updating the SoftU2FDriver:
Right click on SoftU2FDriver -> Properties -> Driver Signing -> General
Type SHA256 in the File Digest Algorithm

Prior to installing the driver, I needed to execute Set-ExecutionPolicy RemoteSigned

error 2 worked for you after you build it? Did you install the driver? I'm not able to properly build it to make it work :(
https://github.com/SoftU2F/SoftU2F-Win/issues/11#issuecomment-1094212360

the RuntimeIdentifier is done here: https://github.com/SoftU2F/SoftU2F-Win/blob/6273591f49720e763d0d712780b41c43e1d9ecc8/azure-pipelines.yml#L45 though you can change it manually

thanks for reporting. should be addressed by https://github.com/SoftU2F/SoftU2F-Win/pull/23


refactor: update FHIR controller endpoints and properties

Modify FHIR controller endpoints for better organization
Add spring.codec.max-in-memory-size to dev properties
Update metrics tracking variables in FhirService
Enhance URL to Key Map initialization logic

Closing, resolved merge conflict directly


Hero follow us not responding

At the moment, it is not possible to click in any of the following links:

It's fixed now :checkered_flag:

It is not, sorry. It depends on the screen size.

It's fixed 👌


Add HTTP semantic convention for content size

https://github.com/open-telemetry/opentelemetry-specification/pull/641
This will need to be added to the HTTP and HTTPS plugins, as well as to the Semantic Conventions module.

Per meeting, I can grab this.

Oops looks like i assigned @obecny instead of @michaelgoin

Greetings, I work with @michaelgoin at New Relic and he and I both decided I could take this issue to get more familiar with the project.  Can someone assign me this issue?  I'm looking forward to contributing to the project.  Thanks!

@dyladan I have some questions about this issue.  Should we be calculating the value for request_content_length or just use the content-length header value to populate request_content_length?  For request_content_length_uncompressed, do we populate this value with the content-length header if no transport encoding is used OR should it be calculated as well?

For request_content_length, simply using the header value should be fine. I'm not that familiar with the available headers but I think uncompressed will need to be calculated.

PR #1625 opened to add this feature


Use shalow copy(optional)

#141, #139
You can set git_clone_depth option for fetching repository. This brings git clone --depth 50 https://example.com/your/repos and this reduces total build time!
This is optional setting because shallowly-cloned repository does not have push ability until git v1.9.0.
https://github.com/git/git/blob/master/Documentation/RelNotes/1.9.0.txt
I don't know what value is enough yet, but git_clone_depth: 50 is reasonable, because travis-ci uses --depth 50 :relaxed:

Coverage remained the same at 68.0% when pulling 1f7fb155a95683b87d1d771c0f0bce40c9ce349c on feat/use-shalow-copy into b7b7889456e30037e0068bdc169407d020b5e254 on master.


installation guide - [closed]

In GitLab by @guyingyan on Jan 16, 2018, 02:47
Merges dev-doc -> dev

In GitLab by @wknet123 on Nov 13, 2019, 10:25
the coverage is  % check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:25
the build is FAILED console log

In GitLab by @wknet123 on Nov 13, 2019, 10:25
closed


Application logs

"Application logs - these are defined as the logs from your containerized applications, based on how you have instrumented your application (e.g. docker logs)"
What exactly does this mean? "Based on how you have instrumented your application" is especially unclear to me. Is this identical to the docker logs for each container? Is it the System.Diagnostics.Trace output? Unhandled exceptions only? Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2da3f507-c5b9-7ade-1542-21ca8e0315f0
Version Independent ID: 209486c4-cf22-77a8-fbfa-7374a003bb49
Content: Monitoring and diagnostics in Azure Service Fabric Mesh applications
Content Source: articles/service-fabric-mesh/service-fabric-mesh-monitoring-diagnostics.md
Service: service-fabric-mesh
GitHub Login: @srrengar
Microsoft Alias: srrengar

Thanks for the question! We are investigating and will update you shortly.

@sirdank as I understand it, it is the logs you would gain directly from connecting to the application such as the docker logs. So anything you can get in the docker logs would be applicable here.
@srrengar can you confirm or elaborate on this?

Yes these are logs which you write in your code specific to your app's logic and use to debug or capture telemetry, either to standard output like docker logs or with a logging framework such as the App Insights SDK or ILogger.

Thanks @srrengar
@sirdank does that answer your question?

@sirdank I will close for now. If you have further questions let me know and we can always reopen and continue the conversation


Do not include null-valued sprints the field map

Fixes https://github.com/solidify/jira-azuredevops-migrator/issues/737
Smoke tests: https://dev.azure.com/solidify/Internal/_build/results?buildId=12192&view=results

Closing, superseded by https://github.com/solidify/jira-azuredevops-migrator/pull/773


Avoid React warning when rendering list

Avoid "Warning: Any use of a keyed object should be wrapped in
React.addons.createFragment(object) before being passed as a child."

Closed in favor of https://github.com/jankopriva/react-infinite-list/pull/5


Added VizAPI v2; Tableau Cloud

@johnDance @alicemhsiao @bcantoni

Added a variable in the docs for "Tableau Cloud" (in case we change it again)
Added VizAPI v2 to the docs (split the VizAPI reference in two (v1 and v2)

Link to docs

@dnagapuram @johnDance  I added a VizImage2 sample to the Samples directory. Could use a look. It's just a copy of the VizImage sample with the new v2 inputSpec.  The user can now select mark types for the two fields.
Note that I tried to use the tableau.MarkType enums in the HTML code, but couldn't figure out how to get them to be interpreted as strings.  The VizImage sample uses the string values and I just did the same.


CGX: Handling of missing geometry in path plots

if the sampling points of a path plot happen to be outside the geometry, then these points are removed, no matter if they were based on line division or node selection.
If such nodes occure at the beginning or end of a path, then there is no problem. If the nodes are in a hole or gap in the geometry, then in the plot there is just a straight line connecting the proximal nodes with valid values.
See for example https://github.com/mkraska/CalculiX-Examples/tree/master/Linear/StressConc1#post-processing
In Gnuplot, you would just need an empty separator line to interrupt the graph. Such lines might be issued whenever there is an invalid data point.

still persistent in 2.13.1


RequestSpecificRetryHandler retries same server for SERVER_THROTTLED

Netflix's RequestSpecificRetryHandler allows to retry on same server for SERVER_THROTTLED error.
When the okToRetryOnAllErrors property is true, the retry handler allows to retry on the same server unconditionally without taking into account the actual error. This is useless when the server responded with SERVER_THROTTLED.
It looks like the if statement at https://github.com/Netflix/ribbon/blob/master/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java#L58-L65 should be considered first before the other conditions.
I doubt Netflix is willing to change this behavior but we could override it in SpringCloud.
What do you think ?

Hi @brenuart
My understanding of spring cloud not only can set the number of retries the same server but also can set the number of retries of different servers.
You mean that we should not unconditionally retry the same server, but according to the specific situation to decide whether to continue to retry the same server?(For example, according to an exception to decide whether to retry the same server)

Ribbon can indeed be configured to retry the same server a couple of times before trying the next one.
If the server replies with SERVER_THROTTLED, there is no point in retrying the same server - whatever the number of retries that is allowed... With the default configuration, you will get the following scenario:

(first call) server1: SERVER_THROTTLED
(retry same) server1: SERVER_THROTTLED
(retry) server2: OK

The second call is useless...

@brenuart
Thank you for your reply, I would like to ask whether to continue retrying the same server when an exception occurs. Can this choice be up to the user? (such as provide a property to allow users to configure to decide which the situation does not need to retry on the same server).Instead of just for SERVER_THROTTLED  situation


Add CI unittests

This will automatically run unit tests and stylecheck (with flake) when users push PRs against :master on github.

(fyi: i'd expect these to fail until we run something like black on the repo. I also think there might be a few cyclical deps since we just added setup.py recently)


Login/logout use in two separate browser windows

I'm evaluating using the angular-oauth2-oidc package in an Angular 9 appliction. I've been playing around with the worked example found at: https://github.com/manfredsteyer/angular-oauth2-oidc.
When I run the example (straight out the box with no code changes) and open up two separate browser windows using Chrome and try and log in using the two supplied username/passwords I've notice the following:
When I logout in one browser the other browser logouts.
When I login on one browser and try and log into the second browser (using a different user account) it automatically logs me in without having to authenticate (using the other windows login details).
When I logout I notice the localStorage is deleted but I'm still automatically logged in when I click login.
For security reasons if a browser window is closed down (with or without logging out) I need to force the user to login every time.  And of course I can't have separate browser instances automatically logging other users in/out.
Is this expected functionality? Seems very strange behavior. Could anyone recommend how I can configure angular-oauth2-oidc to overcome the issues highlighted?

For security reasons if a browser window is closed down (...) I need to force the user to login every time.

Then you cannot use localStorage, and you should switch to providing either sessionStorage, or your own custom storage provider.

When I logout I notice the localStorage is deleted but I'm still automatically logged in when I click login.

I presume you refer to this sample (?). That sample uses https://idsvr4.azurewebsites.net configured with a proper end_session_endpoint, so the logoutUrl should be set and the logout call should properly end the session at the server.
You could check my alternative example where logout is persistent (uses another IDS). If you'd swap out localStorage for sessionStorage then you should also see the behavior where closing/reopening the browser doesn't persist your session anymore.
Note on that last point: if the user clicks "remember me" in the IDS, then the login is remembered across browser sessions in the IDS cookie. There's nearly nothing your SPA can do to prevent that, you cannot "quickly log someone out from IDS" when they ALT+F4 your Angular application.

Thanks for the prompt reply, greatly appriciated. What about the point I was making where I have two browser windows open and logging out one logs the session out in the other window? Would this be resolved using sessionStorage too? The example code I'm using uses the https://demo.identityserver.io IS4 server.

I'm a tad confused about what specific sample you're using. The link in your original post is to this repository, and the "sample" project in this repo uses idsvr4.azurewebsites.net, not demo.identityserver.io you mention in your last post?
In any case, cross-tab logout can (seemingly) happin in many different ways:

enableSessionChecks would use the OpenID spec for the server notifying clients of logout
angular bindings might watch for localStorage changes if you use that
you could have an app that uses some kind of cross-tab communication to enable the feature yourself

If you want to know what's going on in your own app you could do sth like this:
    this.oauthService.events.subscribe(event => {
      if (event instanceof OAuthErrorEvent) {
        console.error(event);
      } else {
        console.warn(event);
      }
    });

Thanks again for your comments.  apologies for the confusion regarding the samples.  Yes the issused raised are to do with this repo
The main issue I'm having a problem with is not cross-tab but cross-browser.  I have two browser windows open.  Logging in/out in one browser window logs you in/out in the other browser window

Browser windows from Chrome, FF, etc are considered equivalent to tabs nowadays? Or do you mean actual different browser kinds?

Wow I didn't realise separate browser windows acted like tabs in the same browser instance! I haven't tried having one instance of say Edge and one of Chrome.  Thanks for claifying that for me.

Haha yeah, that caught me off guard some time ago too. Fun fact: even incognito windows (and tabs) in Chrome all are "one", and they share e.g. localStorage. So you need to close all incognito windows/tabs (even if they have other websites open) before reopening your app in a fresh incognito window to get a clean state.


Character comparison change?

I usually use the string L|l1iI0Oo when checking out fonts.
The idea is there at the bottom of the character's tab, but separating the 1/l/O/0 doesn't provide a great comparison when "the whole point" is to see if you can tell the difference between those characters - ie, if the characters are 'well designed', the differences should be apparent/easy-to-spot. Since it is all done with screen shots, not the easiest\quickest PR, and this is basically a question of the core design of that tab, but perhaps food for thought? (Also, of course, regardless of format, I'd like to see my letter-I, |, and i comparisons along the 1s and ls)
addendum: (If not obvious, my suggested test string is capL, pipe-symbol,  lowerL, 1, lowerI, capI, 0, capO, lowerO)

Agreed. I think the comparison should certainly include I (capital I) and | (pipe).

Mark Simon on adding _ underscores to this page as well:
https://github.com/chriscoyier/coding-fonts/issues/87

We have this change in place for new fonts:
https://coding-fonts.css-tricks.com/fonts/codelia/?language=charmap
I think we need to:

Redo all other screenshots
Force-clear the cache somehow. Either go into Cloudinary and delete the ones there that have been fetched already, or implement a file-name-change system and put like e?v=2 on the end of the image sources or something.


fix(TDI-38994): improve the test coverage for runtime part

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-38994
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[x] Other... Please describe: improve test coverage

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Pull request test result: success :star:


what to do when forgot passphrase?

I just need to create a new wallet. I can't find an option to do that.

Similar problem here with Mac. Tried to remove the wallet and re-install it but didn't work. Also tried removing the files I found in the Library folder but something sticks somewhere and can't create a new wallet from scratch when re-installing.
A full uninstall feature is also needed in this wallet at least.

I just need to create a new wallet. I can't find an option to do that.

First, exit Neoxa, shut it down.
Navigate to C:\Users\userName\AppData\Roaming\Neoxa and copy wallet.dat to a USB stick and save it in case you later remember the passphrase.
Next, AFTER you have backed up wallet.dat, from that DIR, then delete the wallet.dat file.
After you've deleted the wallet.dat file, re-start Neoxa.
You should be good to go with generating new wallet.

@GauchoBois Not sure about Mac as I don't use them, but I guess would be in location like /Users/<username>/Library/Application Support/Neoxa/neoxa
You need to do the same thing. Shutdown Neoxa. Backup wallet data file to USB, delete wallet data file from Mac, re-start Neoxa.

Hello,
I have been mining Neoxa since like 6 months. I have recently lost my laptop and I could not recover the data on my PC. So I bought new PC and I reconnected my Neoxa core wallet through my passphrase and mnemonic, after I can not find my balance in my wallet so I opened debug window from tools section and added my receiving address in which I have been mining. After that I can see my balance but it's not spendable its only watch only mode. Can anyone hear help please?


ID Look ups for location table views

Add the ability to create a location table view, that performs an ID look up specific to the location.

Isn't that the case anyways?

Aren't they Spatial in design ?

From report.js in shneame deployment.
  _xyz.tableview.locationTable({
    title: 'Age Profile',
    location: {
      layer: params.layer,
      id: params.id
    },
    target: document.getElementById('age_profile')
  });

Done and added to docs.


Issue 682: Welcome popup, splash screen, and viewing the Gallery

Added an additional check to hide the welcome and the splash screens if the current view is the Gallery. Unfortunately, I haven't been able to test this because I need a real Gallery link, which I cannot do locally.

I think you can enable the gallery in local by turning the flag on in appengine-web.inf:
diff --git a/appinventor/appengine/war/WEB-INF/appengine-web.xml b/appinventor/appengine/war/WEB-INF/appengine-web.xml
index b0f6de2..74ff0d9 100644
--- a/appinventor/appengine/war/WEB-INF/appengine-web.xml
+++ b/appinventor/appengine/war/WEB-INF/appengine-web.xml
@@ -56,9 +56,9 @@
     <property name="use.gcs" value="true" />

     <!-- Name of gallery bucket in Google Cloud Store -->
-    <property name="gallery.bucket" value="" />
+    <property name="gallery.bucket" value="my-gallery-bucket" />
     <!-- Whether or not to use the gallery -->
-    <property name="use.gallery" value="false" />
+    <property name="use.gallery" value="true" />

I did that, but it was an empty gallery. And it was all on localhost, no
unique address, so I couldn't follow the steps you gave me to replicate the
bug.
On Jan 26, 2016 5:02 PM, "Mark Sherman"<EMAIL_ADDRESS>wrote:

I think you can enable the gallery in local by turning the flag on in
appengine-web.inf:
diff --git a/appinventor/appengine/war/WEB-INF/appengine-web.xml b/appinventor/appengine/war/WEB-INF/appengine-web.xml
index b0f6de2..74ff0d9 100644--- a/appinventor/appengine/war/WEB-INF/appengine-web.xml+++ b/appinventor/appengine/war/WEB-INF/appengine-web.xml@@ -56,9 +56,9 @@

 <!-- Name of gallery bucket in Google Cloud Store -->-    <property name="gallery.bucket" value="" />+    <property name="gallery.bucket" value="my-gallery-bucket" />
 <!-- Whether or not to use the gallery -->-    <property name="use.gallery" value="false" />+    <property name="use.gallery" value="true" />

—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/686#issuecomment-175252349
.

Yes you can. Just use two accounts.
Log in with an account, to your localhost server, make and share a project
to the gallery. The share button gives you a local url:
localhost:8888/?galleryId=4785074604081152 which then works to trigger
the bug when you log in as a second account.
On Tue, Jan 26, 2016 at 5:23 PM ajcolter<EMAIL_ADDRESS>wrote:

I did that, but it was an empty gallery. And it was all on localhost, no
unique address, so I couldn't follow the steps you gave me to replicate the
bug.
On Jan 26, 2016 5:02 PM, "Mark Sherman"<EMAIL_ADDRESS>wrote:

I think you can enable the gallery in local by turning the flag on in
appengine-web.inf:
diff --git a/appinventor/appengine/war/WEB-INF/appengine-web.xml
b/appinventor/appengine/war/WEB-INF/appengine-web.xml
index b0f6de2..74ff0d9 100644---
a/appinventor/appengine/war/WEB-INF/appengine-web.xml+++
b/appinventor/appengine/war/WEB-INF/appengine-web.xml@@ -56,9 +56,9 @@

-
name="gallery.bucket" value="" />+

-
value="false" />+

—
Reply to this email directly or view it on GitHub
<
https://github.com/mit-cml/appinventor-sources/pull/686#issuecomment-175252349
.

—
Reply to this email directly or view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mit-2Dcml_appinventor-2Dsources_pull_686-23issuecomment-2D175264092&d=BQMFaQ&c=lqHimbpwJeF7VTDNof4ddnO1LTp7jTaMHJ2UAxZwrfY&r=bJEpcfB0VesGOEw6RgFQuGv3sSGrcpElZuIXV_waLqM&m=OlEHH3btc3ca5DnLb_4XgmQvlZYXXSLy1SiSFr_Q2_o&s=Q3WYz6-f0pzB3nwZwNk05Gw1yZaYs0k-NizoQdOt99I&e=
.

Uploaded new code. Jose helped me fix the random constant. However, I realized that the Welcome box should really only ever be displayed IF we are on the projects view (right?). Tried to change the condition in the If statements to that. However, now the welcome box is never displayed, which makes me think that maybe the currentView isn't updating properly? I can't find where to see the OdeLog message I wrote in, but if I could see it, then maybe I could figure out what is going wrong.

@ajcolter if you are logged in as an Admin, you should see an Admin tab containing something like switch to debug panel (or similar). Logging ends up there at times. If the Log statement you used does not appear, grep the appengine client folder for any string that does appear in the debug view, and do the logging that way. Does that make sense?

Makes sense. I found it. It's saying the current view is int 0, which is the designer. But I don't know why it's saying that when I log in for the first time... But that explains why, with my code the way it is, the welcome box is no longer displayed.

Jeff wrote something so the welcome box won't show when looking at a gallery page. He'll be creating the PR.
Also, we decided to stop showing the splash screen, except for major updates (like needing a new companion).


After the update, this mod is not compatible with the current version

plz fix the mod~

I'm just a player,having no relevant knowledge of programming,but thank u very much for giving me and my friend a wonderful time


For each on signals

I am starting Solid with signals because I naturally trust them more after over a year of usage, vs state.  I probably will move to state as I understand it more, because it looks awesome.  It looks like a <For each={(signal())}>, where the signal returns a list, still needs wrapping parens to dynamically render even in version 0.13.2 of babel-plugin-jsx-dom-expressions.   I can get you a reproducible code sample but it just showed up on a work project.

Hmm.. I would expect this to work from a compiler perspective. You are right I use state in most of my examples but the Scoreboard uses a signal from createMemo for the sorted list and my tests(https://github.com/ryansolid/solid/blob/master/test/dom/for.spec.jsx) are passing which are using a simple createSignal setup. So I wonder if something else is going on.

Oh yes the Scoreboard does use a signal in a For each scenario without parens.  At this one For each call site of mine, the only one I have so far that uses a list,  I have to wrap mine in parens for it to dynamically render when the signal updates even though I don't in other places after upgrading.  I will spend a bit more time chasing this down to see if I can narrow it down.  Thanks!

Oh just found my own bug after pasting this.  model.selectedInsight() === insightType ? "true" : false.  They don't let me use Typescript but definitely need some linting.  After fixing this it works (for some reason haha).


DeConz group of lights and Home Assistant integration

Home Assistant release with the issue:
Operating environment (Hass.io/Docker/Windows/etc.):

arch
x86_64

dev
false

docker
true

hassio
false

os_name
Linux

python_version
3.7.3

timezone
Europe/Zurich

version
0.93.2

virtualenv
false

Last working Home Assistant release (if known):
n/a
Component/platform:
deonz
Description of problem:
I have an issue that I don't know how to debug... I have the integration between Home Assistant and Phoscon App and a setup consisting only of Philips Hue stuff: lights and motions.
Some rooms have a group of 5 lights and others only a single light. I use Home Assistant automation to turn on lights when there is a motion in the room. No issue at all with the rooms with single light. However, with the group of lights, it's kind of hit or miss... Sometime, when there is a motion, the group of lights is turning on but sometime, I can see the motion status "Detected" and the lights status "on", on the Home Assistant GUI, but in fact, the group of lights is not turning on and stays off.
I have the issue only with multiple lights in DeConz group but not with single light in a group.
Thanks for any help !
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
Traceback (if applicable):
default: error
logs:
  pydeconz: debug
  homeassistant.components.deconz: debug

No error in the log.
Additional information:
@Kane610

Similar to https://github.com/home-assistant/home-assistant/issues/24056?

Can you gather some debug logs describing the issue?

Similar to #24056?

Maybe, as it seems as an user is experiencing the same issue with a deconz group, but different as I don't get any errors in the log.

Can you gather some debug logs describing the issue?

Sure, I'll send it as soon as I get the issue.

There is a fix I hope will help with this issue. It would be great if you could take the beta when it arrives to verify improvement.

Great, thanks ! I'll switch to the beta then.

I'm using Docker, so if I switch to the rc image label instead of latest, it should include your latest fix, right ?

I still have the issue and no error in the log... I can see that the group of lights state is ON in home assistant but physically it is not, and then few seconds later, I can see that the group of lights state is OFF in home assistant, without any action from my side.... and the group of lights stays physically OFF.

Ready to close this one @WhistleMaster ?

I would like to say yes, but unfortunately the issue is till there. I've switched to the final v0.94. I've tried to gather some log when I have the issue and when not, but it seems that there are no errors.
home-assistant.log
I have no issue at all with single lights but with my groups of 5 lights, I have the problem. Thanks for your help.

I have a change related to this in for 0.94.2. If that doesn't solve your issue. We should move this to the deConz github

Well, I've upgraded to 0.94.3 but unfortunately the issue is still there...

I re-opened the issue on Deconz's git. See https://github.com/dresden-elektronik/deconz-rest-plugin/issues/1335.

I still have the issue, but I've made some tests, and I've tried to use Phoscon only to do the same (detect motion and light the group of lights) and it works perfectly, no issue at all...
I suspect then that the issue is with the integration between Home Assistant and Deconz.


autoform.setFieldValue ?

How to set a field value?

+1

+1

+1

If it does not seem obvious,i can to bring here with half a hundred friends with "+1"?

+1

+1

+1

+1

+1

+1

+1

+1

+1

+5

+1

If you need assistance moving away from this depriciated package, just ping me.


Regression v3.6.3 - DeepPartial with flavoured types not working

TypeScript Version:  v3.6.3
It errors on v3.6.3 and also the nightly build on the playground
Does not error on v3.5.1

Search Terms:
nominal types
deep partial
flavor
flavour
Code

interface Flavoring<FlavorT> {
  _type?: FlavorT
}
type Flavor<T, FlavorT> = T & Flavoring<FlavorT>

type DeepPartial<T> = {
  [K in keyof T]?: T[K] extends object ? DeepPartial<T[K]> : T[K]
}

type FlavouredEventId = Flavor<string, 'EventId'>

interface FlavouredEventSummary {
  id: FlavouredEventId
}

interface EventSummary {
  id: string
}

const flavourTest: DeepPartial<FlavouredEventSummary> = { id: 'id'} // Broken in 3.6.3
const test: DeepPartial<EventSummary> = { id: 'id'} // Works in 3.6.3

flavour code from here: https://spin.atomicobject.com/2018/01/15/typescript-flexible-nominal-typing/
Expected behavior:
It throws no errors
Actual behavior:
It throws
Type 'string' is not assignable to type 'undefined'.

Playground Link:
https://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgGIBs4DcD2VQDmAPBtngCoB8yA3gFDLID6YAngA4QD8AXGprijkA3HQC+dNp35koRcgBoZgqsgC8ycsgBkyvIRICKlUZI4oAIhAjsACnChhgcdPOob6jANoBpZKGQAawhWHBhNAF1eTV8I5AgAD0gQABMAZ2QcACMAKwgEMGQuZCsbe0dnV3JY6j5qnwjxUykUUlwAVygIFIBRLAhwAEkU9T05NLB8EAIlACI+gbBh2ZM6OlBIWERWo07uhfAAZXaAWxOHVloGfxS+Npw93v6hlNEJdfBoeCRkA7Bjs4XK6MYC3ZATKYEN5rBA4EATZAwXZCCATPilOwOJwuQxkR5-AHnKCsdy0G58Wag2bIMTCZAAenpyAAQlAcMEQP5OQBmAB0ADZedy6LD4YVIGiStZMRUcQTTkSSaMaOTkJSUtTaQymQB1PCBDIBPmC4VAA
Related Issues:

The updated behavior is more correct - a string primitive should not be considered assignable to object. You can rewrite as
type DeepPartial<T> = {
  [K in keyof T]?: T[K] extends (string | boolean | number | symbol) ? T[K] : DeepPartial<T[K]>
};

to get the desired behavior


Missing License

Hey Angel,
I saw your post on twitter and checked the project.  I've been looking for candidates that I can use as experiments for ISPC, the Intel SPMD Program Compiler.  I'd love to use this project, you've done a very good job with organization so I think it's a good fit.  However I can't experiment with your code as it's unlicensed.
If you were to choose MIT or Apache 2.0 I'd love to experiment with ISPC implementations for certain functions.
Namely:
void SoftwareRenderer::drawTriangularMesh(Model * currentModel)
void Rasterizer::drawTriangles(Vector3f *vertices, IShader &shader, Buffer *pixelBuffer, Buffer *zBuffer)
Cheers,
Pete

Hey Pete,
Thanks for your interest in my project! I apologize for the inconvenience, I just went ahead and added a MIT license to the project.
Hope that helps your experimentation and let me know how it goes!
Thanks,
Angel