Added support for removal reason templates

Fixes #1047
Feature Summary and Justification
This feature provides support for "new" Reddit's removal reasons. These are templates with titles that can be applied to a submission or comment by a moderator after a post is removed. This PR adds the ability to list the removal reasons (because you need the reason_id) as well as apply the template.
These templates are available only on "new" Reddit at https://www.reddit.com/r/SUBREDDIT/about/removal
You can list reasons by using https://oauth.reddit.com/api/v1/SUBREDDIT/removal_reasons.json but looking at the other endpoints that PRAW uses I discovered https://oauth.reddit.com/api/v1/SUBREDDIT/removal_reasons/all works too
Technically when using this on the website, selecting a reason lets you edit the template in line. This should be possible via PRAW but I didn't implement that as of now.
Note: I haven't written tests for this yet. I'm not very experienced with writing unit/integration tests.
Edit: I should note that on "new" Reddit this template just adds the removal reason and mod note to a submission. When you select a removal reason to send it performs this method first and then the send_removal_reason method. In reality these two methods should be performed at the same time.
References

I referred to the send_removal_reason method and the SubmissionFlair.choices for acomplishing this
To get the endpoints I performed the actions on the website and monitored my network traffic. These endpoints are not publicly documented

Okay I think I figured out the integration tests and I added them for both comments and submissions for both of the new methods I added.

@jarhill0 The removal reason (and optional mod note) are viewable on a submission/comment under the:
mod_removal_reason attribute and the mod_note attribute within PRAW. On the website, this information is displayed by hovering over/clicking the “Removed” red text after successfully applying a removal reason. The popover will show which mod removed it, the title of the removal reason, and the mod note (if any) (It does not seem to reflect this information within the mod log though).
As noted in my edit to the PR description, it seems that Reddit intends for this PR’s method to be used in tandem with send_removal_message method in order to:

Notify the user why their submission/comment was removed
Display in the UI to other mods what the reason was for removing it

Cool, thanks for answering my questions.
I see the removal reason at submission.mod_reason_title rather than mod_removal_reason as you say but I assume that you meant the former. Also, I assume I am doing something wrong because I cannot get my removal reason to be sent when using send_removal_message unless I pass it in myself as a parameter, which seems to defeat the point. Can you give a code sample of how I can achieve this? Or, by "Reddit intends," did you mean that this doesn't currently work (on Reddit's end)?

At this point, the PR is essentially ready to merge, aside from my previously requested documentation changes and potential other documentation changes to clarify issues along the lines of the questions I've been asking of you. Thanks for bearing with me. 😃

Yes I meant mod_reason_title  - was working off memory at the time.
As for send_removal_message there's nothing I changed with the current implementation as documented here
Currently a removal with reason works like this:

Mod clicks "remove" (api call to :meth:remove)
Mod clicks "add removal reason" (believe this is an ajax call to :meth:removal_reasons)
Mod select a removal reason and can customize it + add mod note and hits submit

Step 3 results in 2 API calls:

First to :meth:add_removal_reason which just adds the title + mod note to the submission/comment
2 Second to :meth:send_removal_message containing the chosen method of removal (modmail, comment etc.) sent to the user.

Because this is two API calls and we already have :meth:send_removal_message I chose not to modify it further.
Ideally, as a convenience around the whole process there would be a new method which more closely mimics the experience on the website. This new method could be :meth:add_and_send_removal_reason and takes as parameters: reason_id, additional_message, mod_note, and type
This method could then fetch the reason body and title and use that in :meth:add_removal_reason and :meth:send_removal_message but perhaps this should be a separate PR?

Ideally, as a convenience around the whole process there would be a new method which more closely mimics the experience on the website. This new method could be :meth:add_and_send_removal_reason and takes as parameters: reason_id, additional_message, mod_note, and type
This method could then fetch the reason body and title and use that in :meth:add_removal_reason and :meth:send_removal_message but perhaps this should be a separate PR?

This sounds great. This is a feature PRAW should have, and it makes the most sense to put it in a new PR (once this is merged).

Hi y'all. I'm a little late to this game. It would be great if removal_reasons was treated like some of the other attributes which have an add method. That is to list removal reasons one can do:
for reason in subreddit.mod.removal_reasons():
    ...

The above syntax with () should only be used if removal_reasons takes arguments. If not simply use removal_reasons.
And to add a removal reason, one would then do:
subreddit.mod.removal_reasons.add(...)

This would improve consistency that I sought to add with PRAW4+. What do you think?

@bboe I initially modeled removal_reasons off of SubmissionFlair.choices() which returns a list. Since currently the dict that removal_reasons returns is a dict of dicts which contain the reason "id" this could more closely mimic SubmissionFlair.choices() and return .add.adda list of dicts.
That said, I'm not sure I follow on your recommendation for .add(...) since none of these methods are for adding a new removal reason to the subreddit (and frankly I haven't tried to do this via the API yet.) The only existing place where I can find .add(...) methods is on the Subreddit class.
In this PR, the use of removal_reasons is a way to list the available choices for adding to a removed submission/comment. Since the associated methods (add_removal_reason and send_removal_reason) are only available for moderators on a submission/comment I kept removal_reasons in the ThingModerationMixin.
I could see value in moving removal_reason to SubredditModeration along with trying to figure out what the API calls look like to create/update/delete removal reasons. I'm happy to explore that, but dunno how quickly I could get to it.

@bboe @jarhill0 Hey just checking in. I wasn't clear from the last comment whether this PR would be good as is or if we needed to pivot to making the removal reasons part of the Subreddit class. Let me know as I haven't looked at moving/creating the methods related to management of removal reasons at all yet.
Also, if it's decided to go that route, I'm not really sure what to do with this PR. I'm not familiar with the PR process. Would this be closed and we'd make a new one? Or would I update the PR to just include the methods related to applying a removal reason to an object and a new PR would be used for removal reason management methods?

I'm going to defer to @bboe to determine whether his concerns have been addressed.

Would this be closed and we'd make a new one? Or would I update the PR to just include the methods related to applying a removal reason to an object and a new PR would be used for removal reason management methods?

All described are valid choices. Again, I'll leave it up to @bboe on this one.

Sorry for the delay in responding. There's no need to make another PR unless you find that easier than modifying this branch.
Now that I've worked with removal reasons and templates a bit, I believe listing removal reasons should exist on subreddit.mod since they belong to a subreddit, and not a submission, or comment.

Also, to reiterate what I've said before, I think the interface should look like this:
# add removal reason
subreddit.mod.removal_reasons.add(...)
# list removal reasons
for reason in subreddit.mod.removal_reasons:
    ...

Adding a bit more. What's so strange to me is that you can associate a templated removal reason with a comment/submission, but it seems like one still needs to send the removal reason manually in order for the message to get to the author.
As a result, I think we could add a field to item.mod.remove() which is the removal_reason_id. If it exists, we make a second API call. If it doesn't exist, removal happens exactly like it does now.
Then we'll later decide if we want to change how send_removal_message works to make it a little more cohesive. Thoughts?

Thanks for the clarifications. I agree it's weird how the current API is implemented with regards to removal reasons.
As for your suggestion with the removal_reason_id field for thing.mod.remove() one thing that's particularly challenging is that on the website when you select a removal reason template, it loads the template text into the modal for editing. You can add/removed/edit/append any text you want to the selected template and it will only be sent to the user that one time. Thus, the following scenarios come up, from most likely to least likely:

Use a removal reason template as is
Use a removal reason template but add an additional note for the user
Pick a removal reason template, but edit some of the text
Pick a removal reason template, but edit some of the text and add an additional note
Pick a removal reason template, but completely replace the text with something else

Emulating the ability to not just use a template, but append text or replace parts of the template entirely seems a bit tricky.
I'll work on some of your proposed changes and also see if I can figure out how to add/remove/edit removal reason templates on the subreddit level.

I just tested a removal via the web interface:
POST /api/v1/modactions/removal_reasons/
{"item_ids":["t1_f90hdiv"],"reason_id":"141h9jvb7oycg","mod_note":"note"}

POST /api/v1/modactions/removal_comment_message/
{"item_id":["t1_f90hdiv"],"message":"change it up","title":"test","type":"public"}

In the end, the message has nothing to do with the reason_id. I didn't try the mod_note, before, so it looks like we'd also need to include that alongside remove too. But the eventual send_removal_message really doesn't have anything to do with with the template, other than potentially serving as a basis for the message to send.

Right - the removal message and removal title in send_removal_message are not tied to adding the removal reason to a thing. However in order for the removal reason to have a title, you need to specify a matching removal reason "template." Thus, if you want the removal message title to match what gets attached to the submission or comment you need to first get the corresponding reason.
Also, something I just discovered is that if a subreddit has no removal reasons defined in the settings you can still add a removal reason. The reason_id is null and the mod_note becomes required. In the resulting thing's json:
"mod_reason_title": null,
"mod_reason_by": "fwump38",
"mod_note": "test",

I'll update this PR shortly with some of the work I've done on your latest suggested changes.

As far as making the changes for this PR, I inspected my network traffic while adding/updating/removing removal reasons and have the code for doing this via PRAW. In looking for the best example code to model this after I took code from both the emoji.py module and the SubredditFlair class including lazy retrieval of removal reasons.
For brevity I named the Subreddit attribute reasons and the class SubredditReasons and Reasons respectively instead of the more verbose removal_reasons and SubredditRemovalReasons but can easily use the longer name if desired.
I know you originally indicated that you wanted something like subreddit.mod.removal_reasons.add(...) but I saw that SubredditFlair and SubredditEmoji both existed outside of SubredditModeration. I couldn't figure out what the delineation was between methods in SubredditModeration and since I was borrowing examples from SubredditEmoji and Emoji classes I think this is cleaner.
I need to write/fix the tests still but I wanted to get feedback on whether I should proceed as is or if you'd like things moved under SubredditModeration.
Also, I haven't looked into your suggestions around adding fields to :meth:remove() yet.

Okay so I was on a roll and went ahead anyways. If you would still prefer removal reason code to be in SubredditModeration I can do that.
As it stands, removal reason management is fully working and tested and in it's own module similar to emojis.py
I also added reason_id and mod_note as optional args to :meth:remove such that, if either is specified, a second API call will be made to apply the removal reason.
I think that covers pretty much all that this PR intended to cover and then some.

Awesome work last night. I would like this to exist under .mod if these actions can only be performed by moderators. I believe flair falls outside of .mod because some actions can be performed by regular users. I think the same is true with emoji as well.

I've approved changes because the changes I requested were added and now that @bboe has taken over reviewing this PR, I don't want my requested changes to still hang around.

Amazing work. 🎆 Thank you so much.

Thanks - this is my first ever PR. I'm excited for this to become part of the project!


Force UTC timezone in client and server

To eliminate all potential timezone issues.

[x] Already implemented for client.py/server.py.
[x] PTDaemon: could be done using export TZ=UTC.
[ ] Loadgen: should be fixed in the loadgen source code.

Hi @ykurlaev  - Is this issue now done, and can be closed.

I believe this is fixed and issue is merged, we should be able to close.  @psyhtest  and @araghun  can you check and confirm ?

Set UTC timezone for PTD #234
Merged

@araghun @ykurlaev FYI, the loadgen now logs the power_start/end timestamps in UTC

https://github.com/mlcommons/inference/pull/898 has been merged


Can we archive diagnostic logs to a storage account in a different region?

Hi,
In the doc, we can select 'Storage Account' as a destination for the diagnostic setting. In 'Location' line, there is no selection. Is there a way to store logs to a storage account in another region?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ca576e1-fafa-3a02-6d29-394f342bc737
Version Independent ID: a6a83de5-41fd-2dce-eb86-cee6c086c07d
Content: Create diagnostic settings to send platform logs and metrics to different destinations - Azure Monitor
Content Source: articles/azure-monitor/platform/diagnostic-settings.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@WenyunZou Thanks for your comment. We are actively investigating and will get back to you shortly.

@bwren  Seems there is a limitation for streaming diagnostic logs from one region to a storage account/eventhub in another region. Can you please verify and update the documentation accordingly?

Thank you! I close this issue as I have no more questions.


Hiscore feature expansion

I've implemented looking up hiscores from all the subcategories - Ironman, Hardcore Ironman, Ultimate Ironman, Deadman, and Seasonal Deadman - and made HiscoreService aware of the rest of the entries tracked by Jagex (each type of clue scroll and the total, last man standing, bounty hunter rogue and hunter).
Because the extra items made the panel taller than the default fixed game window I replaced the old skill icons with smaller versions from the official Hiscore website. Personally I really dislike these as well as the Hiscore category icons but I'm not much of an artist.

I think I've done a decent job testing the HTTP Service and I hope it will work (works on my machine), but I wouldn't be surprised if something slipped past me.

Thanks for the review! I'm always open to suggestions :)

Thanks for being patient with my mess!

Thanks


Timestamps were improperly escaped

Swaps the timestamp and escaping methods
Fixes #126

@maxim please review :)

Thanks for getting this fixed! @ScotterC


Experimental Dot Backend

Can be used for visualization of the metamodel and instruction behavior.
Not ready for review!

Related to #41


[docs] make todo app into a template app

Motivation
We'd like for people to be able to get started with a more sophisticated template app that can be hacked on.
Finish Line

dxos create tasks should create a new DXOS app from the tasks app

blocked by #3914

split out from #3916

expecting that we won't have to complete all of #3916 - hope to have what I need by 9/3

it's working, but not published to NPM yet


Cql4bonnie qdm5 3 937 facility

JIRA Test: https://jira.mitre.org/browse/BONNIE-968
Related PRs:

https://github.com/projecttacoma/bonnie/pull/815
https://github.com/projecttacoma/cql_qdm_patientapi/pull/65
https://github.com/projectcypress/health-data-standards/pull/528

Additional work required. Closing for now.


Add requirements file

Hi,
Thanks for open-sourcing your code !
Just thought it would be clearer and easier for the users to have a requirements file.
The user can install all the dependencies at once this way.

Thanks!


Figure out how to spin up the elastic stack with custom version of beats

How to properly test a change E2E in beats that is also affecting the behaviour of integrations package?
Scenario where things get tricky without knowing this:

A PR is adding a new option for the azure config.
Testing this config option would require releasing a new version of beats and then spinning up the stack locally to check the functionality (via elastic-package stack up -v -d).
After testing, an enhancement in usability is discovered or the config option is bugged. Any change would require waiting for another release cycle to be available.

This is worrying, as without proper testing, bugged/unpolished features can be shipped unknowingly.

Superseeded by https://github.com/zmoog/public-notes/issues/35


Batch API calls

This is a first implementation for batching API calls as per discussion here https://github.com/logtail/logback-logtail/issues/4.
Some notes:

Batch size is configures using <batchSize>200</batchSize>, see logback-batch-test.xml
Some tests require an explicit flush() in order to force the sending.
There's a need for a Thread.sleep(2000) in LogtailAppenderBatchConfigSizeTest
We recommend not suggesting queueSize in the documentation as to not create confusion with batchSize

@cosmin-marginean Hi Cos, thanks a lot for the PR! There seem to be tests failing - do you want to tackle this or should the team here take a look? 🙌

It's ok, I can have a look this afternoon, quite likely to do with me coding against jdk11 or something

@gyfis I couldn't get this to break, but I see some 401 - Unauthorized. in the tests - are these tests using any "LOGTAIL_INGEST_KEY" env setting?
https://github.com/logtail/logback-logtail/runs/5510436756?check_suite_focus=true

@cosmin-marginean Ah, sorry, we do have a secret token on the repo which I think is not accessible by PRs. Let me test this locally real quick...

@cosmin-marginean Hi again Cos, sorry, the tests pass fine locally :tada:
The PR looks good, too. I wonder if there's a way to register an exit event to flush any logs that are in the queue - this is so that this library doesn't discard logs. I think with this you could then drop the Thread.sleep and flush. This property seems like a good start: logging.register-shutdown-hook. Do you know if it's possible to register this somehow in our appender, to clean up after ourselves?

That's a very good point @gyfis. Leave this with me, I'll do some experiments these days, as this will indeed be a problem beyond the tests - we don't want messages lost on app shutdown in production.

Appreciate it! Tag me here or at<EMAIL_ADDRESS>if you'd like any help :pray: Thanks a lot!

@gyfis I've added a flush() on stop() which seems to do the job: https://github.com/logtail/logback-logtail/pull/5/commits/04088535760ad2a0e0e46cfb3f6bf4364c886e27
I couldn't quite figure out how to write a test for this without actually querying the logs in the remote system, so the only way I could validate this was to send 5 messages (for a batch size of 10), and test with and without flush in stop() and look in the console/dashboard. The messages appear in Logtail when this is on.
We can't really use a shared variable either as a second test (checking if the messages were flushed) would probably be run in a separate instance, so checking the number of API calls (like we do in other tests) won't help much.
Let me know if you think there's a better way to test this.

@cosmin-marginean Hi Cos, thanks for the update!
Ideally (acknowledging I'm out of depth here), I'd like to see a mocked server-appender pair that we could start, stop, and inspect mid-run. Logzio seems to be doing something similar with their MockLogzioBulkListener used e.g. in the serverCrashTest, but I understand that's quite a lot of code to write.
Let me know if you want to tackle this too - otherwise I'll make one more review, test locally, and merge after!

@gyfis That would be ideal, yes, I agree. I personally don't have the time at the moment to go into the depths of this unfortunately, but I'd be happy to review some work on this at some point if required.
Thanks!

The code looks good - thanks again Cos!


Uncaught TypeError: Cannot read property 'div' of undefined

Chrome 46 with demo viewer
Press r key when no file is loaded will throw follow exception.
You can "unload" the file in demo viewer by open a non-pdf file.
Uncaught TypeError: Cannot read property 'div' of undefined
PDFViewer_scrollPageIntoView @ viewer.js:5033
pdfViewRotatePages @ viewer.js:7048
keydown @ viewer.js:7808

We should ignore most of the keyboard events when there is no file loaded.

Since this issue specifically mentions the R key, and given that the approach in the referenced PR has unwanted side-effects, I'd suggest to just modify {PDFViewer, PDFThumbnailViewer}.pagesRotation instead.


hardcoding special variable exceptions

#69
#56
also increasing cache size

we should add them as docstring

we should add them as docstring


Give PolynomialFit more docs, and a debug toString

I was debugging some details of scrolling and dragging (toward #122338), and found it was helpful to print out one of these and to know what its fields mean.  To work that out I had to read the code that emits these elsewhere in this file. So here are the results of that, to save the next person from having to do the same.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks!


feat: svelte rune-powered state + slots refactor

Before submitting the PR, please make sure you do the following:

[ ] Read the Contributing Guidelines
[ ] Reference your PR to an issue that was discussed ahead of time
[ ] The PR should contain a clear description of the problem it solves
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

[ ] Run the unit tests with npm run test
[ ] Run the linting with npm run lint
[ ] Run the e2e tests with npm run e2e

Thank you for contributing to AgnosUI!

thanks for the review @divdavem !


description isn't actually required...

we default to .Summary if not present

Make sence, summary is also changed to optional #140.


Add install instructions from conda

I've added this nice tool to conda-forge for others to find and install:
https://anaconda.org/conda-forge/verticalize

It might be a few hours for CDNs to update and for others to be able to pull from Anaconda:
https://github.com/conda-forge/verticalize-feedstock/commit/9b87d302c327b5b54c47ce1ab68fa11198571696#commitcomment-141729672
An OSX Arm64 recipe will exist soon too:
https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5858

@clintval great ! thanks

@lindenb I tried to also put this into Homebrew, but the project wasn't notable enough, unfortunately:

https://github.com/Homebrew/homebrew-core/pull/171062

For the time being, others can install using a homebrew tap:
brew tap clintval/verticalize
brew install verticalize

https://github.com/clintval/homebrew-verticalize


SyntaxError: Invalid Syntax

File "pwnedornot.py", line 66
printf(f'{G[>]}{C} Created by:  {W}thewhiteh4t' )
^
can't able to run git clone on the terminal
the closing square brackets missing in the line 26,27,28,29
R = '\033[31m' # red
G = '\033[32m' # green
C = '\033[36m' # cyan
W = '\033[0m'  # white

@SanthoshG03 please share a screenshot of the error

As I was replying as much as fast, I saw your notification, I can't figure out how to upload an image in github,
but still managed to get it done at least.
here you go:
https://ibb.co/yPbSskr


lab-06-simple-api

terminal server works, POST, PUT, READ, DELETE all work in the terminal also.

Great start!
Aaron, I'm not able to get all of your commands when I pull down your branch. I've copy and pasted and fiddled with the commands but am getting different errors. I would check that these work by copying and pasting from your readme.
Nice job getting started with the swagger file.


Power Requirement and battery sizing

Depending on the modules selected, calculate and analyze the required power
Use this data to estimate the required battery size

Relevant calculations were done and verified. The power distribution board was designed to meet these requirements


Detect MTU/Fragmentation and warn

The current intent is that messages will fit in one datagram. The reason is this simplifies the logic and negates the need to buffer message contents and detect data framing. The downside is messages are limited to 1400-1500 bytes, if messages over this are sent they will be unprocessable, A guard to detect the adapter MTU and compared against the message size should be added to warn and drop sending the message.
if larger messages or streams are required, this should be handled at upper layer consumers that choose to deal with that complexity.
To support cases where further MTU reduction can be added on upstream interfaces a configurable MTU limit should be added to override detected MTU.

Chunking support added in #16


onCreateWindow does not work as advertised

Environment
Flutter version: 1.19.0-2.0.pre.173
Plugin version: 3.2.0
Android version: 9 (Pie)
iOS version: -
Xcode version: -
Device information: Redmi Note 7
Description
Clicked an anchor tag with target="_blank" got called to "shouldOverrideUrlLoading" with "isMainFrame = false" instead of "onCreateWindow"
Expected behavior:
Current behavior:
Steps to reproduce

Opens a static page with an anchor tag with target="_blank" and any link in href.
Click on the anchor tag.
It opens in the current webview

If you ever read the API docs, it is clearly written that, on Android, you need to set the option supportMultipleWindows: true:
initialOptions: InAppWebViewGroupOptions(
  crossPlatform: InAppWebViewOptions(
    debuggingEnabled: true,
    useShouldOverrideUrlLoading: true
  ),
  android: AndroidInAppWebViewOptions(
    supportMultipleWindows: true
  )
),


Cannot change CMD in commit to a command with arguments (from 1.7)

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Setting up CMD in commit command cannot be a command with arguments, but only single executable since 1.7. It worked as expected before.
Steps to reproduce the issue:
(happens both with system and user container)

(sudo) podman run --name to_be_commited -dit fedora bash
(sudo) podman commit -c CMD="sleep 6000" to_be_commited commited_image

Describe the results you received:
The second command fails with Error: invalid change "CMD=sleep 6000" - invalid instruction CMD=SLEEP
However, if I use just command without any arguments, it works. E.g. (not valid cmd, but to show the point)
(sudo)  podman commit -c CMD="sleep" to_be_commited commited_image

Describe the results you expected:
Successfully created image. If I run these two commands with podman-1.6.2-2, the image is created and in sudo podman inspect commited_image I see:
"Config": {
            "Cmd": [
                "/bin/sh",
                "-c",
                "sleep 6000"
            ],

Additional information you deem important (e.g. issue happens only occasionally):
Worked in podman-1.6.2-2, broken in podman-1.7.0-2.
Output of podman version:
Version:            1.7.0
RemoteAPI Version:  1
Go Version:         go1.13.5
OS/Arch:            linux/amd64

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.7.0-2.fc31.x86_64

I'll grab this one
On Mon, Jan 13, 2020, 02:50 Matej Marušák<EMAIL_ADDRESS>wrote:

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Setting up CMD in commit command cannot be a command with arguments, but
only single executable since 1.7. It worked as expected before.
Steps to reproduce the issue:
(happens both with system and user container)

(sudo) podman run --name to_be_commited -dit fedora bash
(sudo) podman commit -c CMD="sleep 6000" to_be_commited
commited_image

Describe the results you received:
The second command fails with Error: invalid change "CMD=sleep 6000" -
invalid instruction CMD=SLEEP
However, if I use just command without any arguments, it works. E.g. (not
valid cmd, but to show the point)
(sudo)  podman commit -c CMD="sleep" to_be_commited commited_image
Describe the results you expected:
Successfully created image. If I run these two commands with
podman-1.6.2-2, the image is created and in sudo podman inspect
commited_image I see:
"Config": {
"Cmd": [
"/bin/sh",
"-c",
"sleep 6000"
],
Additional information you deem important (e.g. issue happens only
occasionally):
Worked in podman-1.6.2-2, broken in podman-1.7.0-2.
Output of podman version:
Version:            1.7.0
RemoteAPI Version:  1
Go Version:         go1.13.5
OS/Arch:            linux/amd64
Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.7.0-2.fc31.x86_64
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/issues/4847?email_source=notifications&email_token=AB3AOCHY6PBJIYNQ4GCBMBTQ5QMMPA5CNFSM4KF5ZWB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFVM6ZA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCHYYHPOUR66H2HGTVTQ5QMMPANCNFSM4KF5ZWBQ
.

This is a result of our parsing changes for --change in 1.7.0 to more closely match docker commit syntax.
Multi-part commit changes are not allowed in Docker with just quotation marks, and instead require an array. Also, use of an = between instruction and value is really discouraged - a space is greatly preferred. sudo podman commit -c 'CMD ["sleep", "6000"]' to_be_commited commited_image should work here.
I recognize that breaking changes between versions are bad for users, but Podman aims to provide Docker compatibility, and the existing parsing of the --change flag was completely incompatible (and also very broken, which is what originally prompted the move). The flag is meant to consume lines formatted as they would be in a Dockerfile, and reuse the existing Dockerfile parser. I can at least say that this should be the last breaking change the flag sees - now that it's been fixed to match Docker syntax, it shouldn't need to change again.

I see.
How is API affected? (from docs)
method Commit(name: string, image_name: string, changes: []string, author: string, message: string, pause: bool, manifestType: string) -> (reply: MoreResponse)

What is supposed to be passed into changes in the same usecase?

The format for each individual change (string in the array) should again match standard Dockerfile format - instruction, then value, separated by a single space - basically identical to what we pass into the command line for --change.

sudo varlink call unix:/run/podman/io.podman/io.podman.Commit '{"name": "to_be_commited", "image_name": "new_name_foo", "changes": ["CMD [\"sleep\", \"6000\"]"]}'

works. It seems not to break API? I'll try to implement this and see how it behaves with older versions. But really, having array as string in API is so unfriendly...

of course it breaks api :disappointed:  Running command https://github.com/containers/libpod/issues/4847#issuecomment-573731214 on 1.6 and 1.7):
$ sudo podman inspect commited_image_from_1.6
            "Cmd": [
                "sleep",
                " \"6000\""
            ],

 $ sudo podman inspect commited_image_from_1.7
            "Cmd": [
                "sleep",
                "6000"
            ],

The one from 1.6 is of course invalid command and it fails. So I guess we AGAIN need to put conditions on API version in cockpit-podman.

varlink was designed to be a self-descripting, extensible, and stable API. This really isn't that. Also, encoding a list into a string and passing that through the API as a string? Why not actually passing a list? On top of being sensible, this would have kept the API backwards compatible, this now broke it for no reason at all..
Sorry for the rant, but that has happened several times now...


Added support for GCC error logging

GCC errors/warnings/infos are parsed and written to Error List, including file navigation if available

For some reason build script not working, but build from Visual Studio does

Looks cool. Not sure how to test this. Thoughts?


iOS Suggestion: Use tag image instead of folder image?

I amended the masterFolderImage to use SFSymbols tag.
static var masterFolderImage: RSImage = {
		let image = RSImage(systemName: "tag")!
		return image.maskWithColor(color: AppAssets.masterFolderColor.cgColor)!
}()

Closing as agreed to use folder image from SFSymbols.


[GE] Improve drag and drop

You can now drag new controls into the tree view on the left, and place them exactly where you want them to be. Also, fixes the bugginess of hovering and dropping inside other controls.

I am not completely getting why the need of the first/second process here is for, maybe adding comments could help maintenance wise ?

Yes, good point, I went back and improved the readability with fewer variables and more comments :)


Add  open-source copyright

add  open-source copyright

done in https://github.com/TuGraph-family/tugraph-analytics/pull/237


Question about TLV::TLVReader class

Is there a way to make a full copy of a TLV::TLVReader object?
I have tried this:
TLV::TLVReader myTlvReader;
myTlvReader.Init(aReader);

Right affter this init, I dump the two readers (aReader and myTlvReader) and they are indeed the same. But it I dump myTlvReader later on (when "aReader" is no more valid), I can see that the container data are no more available. So it seems that both object were in fact using the same container data.
Would you have advices to do a full copy of a TLVReader object?
Is there a way to copy the TLVReader data into an uint8_t array?
Thank you

But it I dump myTlvReader later on (when "aReader" is no more valid), I can see that the container data are no more available.

Generally, what you are doing should work, as long as the underlying buffer backing aReader sticks around.
It's hard to say what "later on when aReader is no more valid" means, but the real question is: what happened to its backing buffer?

Is there a way to copy the TLVReader data into an uint8_t array?

A TLVReader, in general, can be pointing to a data stream.  Including an infinite data stream.

But it I dump myTlvReader later on (when "aReader" is no more valid), I can see that the container data are no more available.

I can see that there was a typo. I meant: "But if I dump myTlvReader  later".

Generally, what you are doing should work, as long as the underlying buffer backing aReader sticks around.

It's hard to say what "later on when aReader is no more valid" means, but the real question is: what happened to its backing buffer?

That's the point. I want to be able to keep a copy of the TlvReader even when aReader will no more be valid anymore.

A TLVReader, in general, can be pointing to a data stream. Including an infinite data stream.

Would you have an example?
Thanks

I want to be able to keep a copy of the TlvReader even when aReader will no more be valid anymore.

Then you have to actually copy the backing state.  I don't believe there is a good way to do that, in general, because the backing state might not allow rewinding.
If you know your reader is backed by a single buffer and does not have the "backing state cannot be rewound" problem, you can init a reader as above, set up a new buffer with a TLVWriter pointed to it, keep doing CopyElement on the writer until you run out of reader bits, finalize the writer, and then create a new TLVReader pointing to your buffer.

Would you have an example?

A reader initialized via:
    CHIP_ERROR Init(TLVBackingStore & backingStore, uint32_t maxLen = UINT32_MAX);

The backing store can keep returning things from GetNextBuffer forever.  Why one would do that in practice is a separate issue, of course.


Adding Page Shield support

Description
Added support for Page Shield based on developer docs.
Has your change been tested?
All changes have been tested with test suites. Also, have tested using a local driver application
Screenshots (if appropriate):

Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

@jacobbednarz do you think it is necessary to use ptr's for boolean values in this? How stringent do you want me to be with the linter issues?

the semgrep rules are in place from past issues we've seen with usage (especially the terraform provider). i'm not sure why but semgrep should be pointing you at https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans which explains it a little more too.

I noticed some other files that don't use it, that's why I ask. I will update and push another. Apologies for the repetitive nature.

i've gone through and applied a few updates from https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#methods to get this closer to the library conventions and make our future maintenance a bit easier :)

Thank you! I just noticed. I don't do a lot of public contribution.. thanks for helping me out :-)

aaanndd that's why they say don't do a force push...

😂 check out https://blog.developer.atlassian.com/force-with-lease/

I have your changes in the PR checked out on my machine. Do you want me to close this PR and open a new one?

do you just want to cherry-pick them onto this one? whatever is easiest for you to do.

no worries! thanks for the contribution 🏅


Color codes bugged

Mythic Mob Plugin

'&8&m                 &r&8[ &b&lINFO&r &8]&8&m                 '

This line doesn't seems to have any error, but it turned out different in the picture below. The gray line turned white.

how is this related to adventure?

I went to Mythic mob discord the support says it's a known issue that's related to kyori adventure, I've got no idea too that's why i came here to ask. They said it should be fixed by kyori 4.12 but idk the release date of it.

no idea what they're on about, but if whatever they said is true this issue would already be solved.
if someone from mythicmobs wants to file an actual bug report with reproduction steps we can work with that, but there's not enough information in this issue to go off of


Supports running add-on in Node.js

Issue: #26
This PR aims to add node support for this addon, but ends up doing a bit more:
1 - Revamp the dev setup, as it was not very convenient. Now you're able to:

run yarn start in the root and it will spin both the addon in watch mode and storybook, and any change you make in the addon package will reflect correctly and trigger HMR on storybook.
run yarn dev in the addon package, and it will keep building in watch mode

This will definitely improve DX and help upcoming contributors!
2 - Update the decorator syntax to CSF. It was using makeDecorator which is a legacy format.
Regarding node support:
3 - Setup server when not in browser mode
4 - Return the worker in initializeWorker and also expose it in a getWorker function (that will error in case worker is not yet initialized)
5 - Add example using the addon in node, similar to how @storybook/testing-react would handle the addon automatically.
Let me know what you think and I can improve the work based on your feedback. Once we are settled, I can improve the documentation in this part, and maybe point out that msw-storybook-addon + @storybook/testing-react = ♥

I hope you like the work, and I am happy to help improve the codebase, as well as the docs and CONTRIBUTING in future PRs :)

Hey @kettanaito I think I found a good way to handle the fallback mechanism. I created a proxy class that just calls the right methods of the worker/server. When the addon is migrated to typescript, both classes could implement the same interface, resulting in a seamless experience for the end user!
See this commit. What do you think? :D

@yannbf it looks like using the link: protocol as an add-on dependency fails the build on Netlify (excerpt from the logs):
11:20:27 AM: npm ERR! code EUNSUPPORTEDPROTOCOL
11:20:27 AM: npm ERR! Unsupported URL Type "link:": link:../msw-addon
11:20:27 AM: npm ERR! A complete log of this run can be found in:
11:20:27 AM: npm ERR!     /opt/buildhome/.npm/_logs/2021-06-14T09_20_27_449Z-debug.log

Could you please look into this? Let me know if we need to reconfigure something on Netlify's side. Thanks.

@yannbf it looks like using the link: protocol as an add-on dependency fails the build on Netlify (excerpt from the logs):
11:20:27 AM: npm ERR! code EUNSUPPORTEDPROTOCOL
11:20:27 AM: npm ERR! Unsupported URL Type "link:": link:../msw-addon
11:20:27 AM: npm ERR! A complete log of this run can be found in:
11:20:27 AM: npm ERR!     /opt/buildhome/.npm/_logs/2021-06-14T09_20_27_449Z-debug.log

Could you please look into this? Let me know if we need to reconfigure something on Netlify's side. Thanks.

Thanks for letting me now! I wonder what commands are happening in the Netlify setting (e.g build command).
link is a protocol supported by yarn but not npm. Is Netlify running npm instead of yarn?
The protocol that is supported by both npm and yarn is file, but link makes it so that if you change files from msw-addon package, Storybook from docs package will pick it up with HMR and it will just work. Would be awesome if that worked in Netlify, it's really good DX!

@yannbf, you're correct, Netlify uses npm install instead of yarn, which causes this issue. I don't have permission to that project, will reach out to the add-on's author to ask if he'd be willing to migrate the Netlify project or give me the necessary permissions to configure build commands. Sorry for this delay, but we should merge a passing CI into master.

@yannbf, you're correct, Netlify uses npm install instead of yarn, which causes this issue. I don't have permission to that project, will reach out to the add-on's author to ask if he'd be willing to migrate the Netlify project or give me the necessary permissions to configure build commands. Sorry for this delay, but we should merge a passing CI into master.

No worries at all! It's awesome that you've given your time to this already. For that I'm really thankful!

Hey, @yannbf. I've migrated the add-on's website to the MSW team on Vercel and configured the build to use Yarn. Could you please update this feature branch against the latest master? It already contains:

link: for the msw-storybook-addon dependency.

So you can drop these changes from this feature branch. Thank you for your patience.

Let me know once the changes are ready. Thanks!

Hey, @yannbf. I've migrated the add-on's website to the MSW team on Vercel and configured the build to use Yarn. Could you please update this feature branch against the latest master? It already contains:

link: for the msw-storybook-addon dependency.

So you can drop these changes from this feature branch. Thank you for your patience.

All good now!

Thank you for this improvement, @yannbf!


AE2 Stuff block crashes server

We have a crash today on the Server when placing a Wireless connector.
Server crash log:
https://github.com/bdew/ae2stuff/issues/95
Mods used in a Modpack
ae2stuff-<IP_ADDRESS>-mc1.7.10
appliedenergistics2-rv3-beta-4
Modpack:
https://github.com/GTNewHorizons/NewHorizons

If you are using AE2 rv3 alpha/beta you need the -rv3 builds of AE2 Stuff.
http://minecraft.curseforge.com/projects/ae2-stuff/files/2270295

ok thanks


[Hacktoberfest] Simple JS Code Clean Up!

This was written in a hurry, it would be great if some professional adds some structure to this!

Hello ! Going for a small chunk ;-)

@thecuriousnoob Go ahead I'm excited to see other people's input!

Going in as well!

@lkwatson welcome to the partyyyy

Dude, did you ever run your project ? 😄

@thecuriousnoob nope I havent ran it today since all yall made changes, probably doesnt work but I dont really care for now.

Okay I'd recommend you for any other project to merge changes into another branch so you can ensure that build requirements and any tests can pass before merging them into master. This workflow wouldn't be blocking your project ;-)

It would be great if you had time to document your code and the scripts you wrote so we could split this cleanup into issues (cause there's a lot of work here). Then it would be easier for any contributor to grab an issue and submit a PR.
This is actually doable independently from current changes brought to your master branch and would help a lot of contributors to come ! :-)

I definitely second @thecuriousnoob, a little more documentation would go a long way.
But cool project, I like it.

for (var i = 0; i < data.length; i++) {
  for (var j = 0; j <= i; j++) {
    if (i === j) {
      unique.push(data[i])
    }
    if (j < i && comparator(data[i], data[j])) {
      console.log('duplicate found')
      break
    }
  }
}

did you want to check the elements of input and output are equal or not?

No I'm taking the input and extracting all the unique values, then saving it back into trainingdata.json.
Data is generated through gameplay.


Fix FullInfiniteProjector

In Corboz's original way (PRL 113 046402) to get projectors from the full-infinite environment, he first performs QR on the two halves and then SVD on the two R tensors. However, it is later refined in PRB 98 235148 that there's no need to do QR first, and we can directly do SVD on the two halves. This PR implements the latter method to replace the original (instead of adding an option to switch between the two).

Before SVD, the indices in the lower half of the two half-infinite environments should be contracted instead of multiplied (as two linear maps; see original here) to include fermion signs.

This will also fix the warning message reported in #104.

Thanks for the fix! Doing just the SVD simplifies things and perhaps makes the full-infinite scheme more stable in the reverse-mode differentiation.
I will quickly adapt the fixes to the code convention (i.e. outsource the contractions to the contraction file and naming). Also I will add some tools for working the the actual full-infinite environment which I coded up for #99 but then didn't use because of the QR. (This will make it possible to use function-handle SVDs for the full-infinite algorithm in the future such that the environments don't have to be constructed as dense tensors.)

The codecov is complaining slightly that some of the sparse methods and related contractions aren't tested, but I am okay with keeping that as is for now, until we actually start using them.

Yes that was the plan. I'll write up tests once we fully implement sparse CTMRG :-)


"Error: name and version and cpi unique" on concurrent deployments

We trigger several BOSH deployments on new stemcell versions. When multiple deployments run at close to the same time and try to upload stemcells, all but one fail with Error: name and version and cpi unique. I think we can do better: if a deployment wants to upload a stemcell that already exists, it should just use the existing stemcell.
This might be a race condition in UpdateStemcell.perform at https://github.com/cloudfoundry/bosh/blob/b5dbaaa5a2cb20f26cf0a5b5ec0a2cf12505ceb4/src/bosh-director/lib/bosh/director/jobs/update_stemcell.rb#L92-L104. It looks like we look up the stemcell, then attempt to create if it doesn't exist. Instead, we might want to attempt to create the stemcell, then rescue on uniqueness violations.

@jmcarp is this from master?

@cppforlife we're using bosh 265.2.0 from bosh.io, but I think we've been seeing this behavior for a while.

@cppforlife  Hasn't this been an error ever since? I remember we encountered https://github.com/cloudfoundry/bosh/issues/1169 quite a while ago (and even had some proposed fix up for discussion, which was never merged)

@jmcarp i would recommend working around it for now. it's in the queue to be solved but not going to happen in next few weeks.

Closing this as a duplicate of #1169. Please feel free to reopen if you have further questions.
Best,
@jfmyers9 && @jaresty, CF BOSH


[SPARK-8189] [SQL] use Long for TimestampType in SQL

This PR change to use Long as internal type for TimestampType for efficiency, which means it will the precision below 100ns.

cc @rxin @JoshRosen

Merged build triggered.

Merged build started.

Test build #34539 has started for   PR 6733 at commit 309d2e1.

cc @liancheng to take a look at the column store stuff.

We also need to rewrite CastSuite to make it cover more stuff. The coverage currently is pretty low.

Test build #34539 has finished for   PR 6733 at commit 309d2e1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34573 has started for   PR 6733 at commit 246ee74.

Test build #34573 has finished for   PR 6733 at commit 246ee74.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34577 has started for   PR 6733 at commit 8f77ee0.

Test build #34577 has finished for   PR 6733 at commit 8f77ee0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

In-memory columnar part looks good. The test failure was because of timestamp precision change. We can just ignore those two Hive compatibility test cases.

Merged build triggered.

Merged build started.

Test build #34610 has started for   PR 6733 at commit 86fecfb.

Test build #895 has started for   PR 6733 at commit 86fecfb.

Test build #34610 timed out     for PR 6733 at commit 86fecfb     after a configured wait of 175m.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34631 has started for   PR 6733 at commit 65cf2f1.

Merged build triggered.

Merged build started.

Test build #34632 has started for   PR 6733 at commit d9565fa.

Test build #895 timed out     for PR 6733 at commit 86fecfb     after a configured wait of 175m.

Test build #34632 has finished for   PR 6733 at commit d9565fa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #34638 has started for   PR 6733 at commit d9565fa.

Test build #34631 has finished for   PR 6733 at commit 65cf2f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

I'm going to merge this, but we should fix rest of the things later.
@JoshRosen would be great if you review this again too.

Test build #34638 has finished for   PR 6733 at commit d9565fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


Android Basics: Get data from the Internet

name: Android Basics Unit 4 issue
about: Report problems with the Android Basics Unit 4 codelabs
title: 'Android Basics Unit 4 issue:' missin suspend qualifier to getPhotos
labels: ''
assignees: ''

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-getting-data-internet?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-4-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-getting-data-internet#7
In which task and step of the codelab can this issue be found?
at point 7, you wrote:
interface MarsApiService {
@GET("photo")
fun getPhotos(): List
}
Describe the problem
The app fails with error "Failure: unable to create call adapter for java.util.List<com.example.android.marsphotos.network.MarsPhoto> from methdo MarsApiService.getPhotos
Additional information
just add "suspend" keyword again and everything works fine.
interface MarsApiService {
@GET("photo")
suspend fun getPhotos(): List
}

@catosh
Thank you for reaching out to us. The issue is fixed and published.


keg_relocate: Check HOMEBREW_TEMP's realpath when excluding name changes

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Since /tmp (the default HOMEBREW_TEMP) is a symlink to /private/tmp,
some build systems (like Parrot's) will attempt to use the realpath
instead of the literal /tmp we supply it with. This breaks the relocation
code, which only tested the literal HOMEBREW_TEMP and not its realpath.
Fixes parrot bottling in Homebrew/homebrew-core#6408.
Ping @ilovezfs

This also fixed open-zwave. https://bot.brew.sh/job/Homebrew Sierra Testing/1185/
Thanks!


I don't think matching against Chinese is really the right answer, here.

          > I don't think matching against Chinese is really the right answer, here.

When you are using dollar signs within text and you don't want them to be treated as math delimiters, you need to quote them with a backslash, as in \$1一个香蕉\$2. In order to get a literal backslash into a javascript string, you need to use two backslashes:
const tempstr = ref('\\$1一个香蕉\\$2');

the handling of \$ as an escape for $ is controlled by the processEscapes option in the tex block of your configuration. It is true by default, so this should work as is.

But the text content is not known in advance, it is returned by the ChatGPT. So I can only use regular matching '$...$',and then determine if there is Chinese inside, and then split the character '\' before '$'?
Originally posted by @guoyutao in https://github.com/mathjax/MathJax/issues/3265#issuecomment-2262427807

What is your purpose in reposting this here?  There is no new question, and there is already a response to that post.


More tests

Pull Request Test Coverage Report for Build 312161325

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.6%) to 75.831%

Totals

Change from base Build 311629138:
2.6%

Covered Lines:
753

Relevant Lines:
993

💛  - Coveralls


Fix error messages not printing in netrepl server

Currently, errors that occur during evaluation of code by the netrepl server result in only a stacktrace being sent to the client, no error message is sent. The cause of this is a change made in Janet 1.19.1 that allowed for an optional prefix parameter to be provided to debug/stacktrace (changelog). Although this parameter is optional in the sense that it does not need to be provided, if debug/stacktrace is called without providing a string prefix, the error message will not be printed (the stacktrace is still printed).
This PR adds an empty string prefix to the calls to debug/stacktrace. This mirrors the approach taken to updating debug/stacktrace calls within boot.janet.

The error occurring here is fixed in janet-lang/janet#896 but that hasn't been released yet as a new version.


Tooltip mistake when Jade shows droped item entity with socket.

MC version: 1.19.2
placebo: 7.1.7
Apotheosis: 6.1.5
Jade: 8.8.1
This will not influence gameplay. But may provide some message.

This is not something apoth can fix - it means Jade is not properly supporting forge tooltip components.

OK, I will post this on Jade and see.


A problem in your paper

Hi, Rdevon, I read your paper DIM, a good job. However, I have a question about this model. In your paper, you use the JS divergence to replace the KL divergence, but this maybe get a bad result: the marginal  probability product p(z)p(x) will be greater than the p(z|x)p(x), this will result in a poor result, the probability that a specific representation given a specific sample will be reduced. This is my question and what do you think it.

We're still studying the differences between the KL and JSD when used to maximize the expected log ratio of the joint and marginal probability measures. We have some more recent analysis and experiments that show that the JSD and KL between these measures are approximately monotonic, and the highest JSDs also have the highest KLs. This will be added to the arXiv version soon.
There is also new work I'm aware of (that should be available on arXiv soon, not by us) that show that when the JSD is used in this way to train an estimator for the MI (the output of the JSD network can also be used to approximate the expected log ratio), that the JSD-based estimator is very accurate relative to other estimators (Fenchel-based KL or NCE-based).
But you are right that the JSD and KL-based estimators do not have gradients that point in the same direction for all realizations of the joint and marginal. Exactly why this matters isn't entirely clear to me yet, but we are comfortable now believing that they can be used to maximize / estimate the same thing.
Hope that helps.

Hi Devon,
Would you mind sharing the title of the paper that you mentioned here? It has been two months ago, so I guess this paper is on arXiv now. But I did not find it by searching for some keywords.


links in readme - different versions?

the readme contains two links:
View the SXL online
View the SXL as a PDF
which refers to the latest release. i tihnk we should state it's the latest release, or instead refer to http://rsmp-nordic.org/specification/#traffic-light-controller-sxl

Fixed


Multicasting Test Failures on test-godaddy-win2016-x64-1 to 4

Multicast tests are returning localhost ipv4 and ipv6 addresses. Potentially related to other hosting problems with godaddy machines
Failures are seen on jdk14, I know MulticastSendReceiveTests.java failure is only re-createable on jdk14 due to a difference in test material, not sure about the other tests
java/net/MulticastSocket/IPMulticastIF.java
run testng IPMulticastIF [PASS]
run testng/othervm -Djava.net.preferIPv4Stack=true IPMulticastIF [PASS]
run testng/othervm -Djava.net.preferIPv6Addresses=true IPMulticastIF [FAIL]

--- testSetGetInterfaceBound bindAddr=[s160-153-234-27/[0:0:0:0:0:0:0:1]:0], nif=[name:eth2 (Microsoft KM-TEST Loopback Adapter)]
01:07:09  test IPMulticastIF.testSetGetInterfaceBound(java.net.InetSocketAddress@3e72d39a, java.net.NetworkInterface@17c88e2b): failure
01:07:09  java.lang.AssertionError: expected [name:eth2 (Microsoft KM-TEST Loopback Adapter)] but found [name:::]

--- testSetGetInterfaceBound bindAddr=[s160-153-234-27/[0:0:0:0:0:0:0:1]:0], nif=[name:eth1 (Red Hat VirtIO Ethernet Adapter)]
01:07:09  test IPMulticastIF.testSetGetInterfaceBound(java.net.InetSocketAddress@f844c8ab, java.net.NetworkInterface@c105cba7): failure
01:07:09  java.lang.AssertionError: expected [name:eth1 (Red Hat VirtIO Ethernet Adapter)] but found [name:::]

...

java/net/MulticastSocket/TestInterfaces.java
01:07:28  NetworkInterface under test name:eth1 (Red Hat VirtIO Ethernet Adapter)
01:07:28  Display name: Red Hat VirtIO Ethernet Adapter
01:07:28  Name: eth1
01:07:28  InetAddress: /<IP_ADDRESS>
01:07:28  InetAddress: /<IP_ADDRESS>
01:07:28  Up? true
01:07:28  Loopback? false
01:07:28  PointToPoint? false
01:07:28  Supports multicast? true
01:07:28  Virtual? false
01:07:28  Hardware address: [-6, 22, 62, 99, -15, 83]
01:07:28  MTU: 1500
01:07:28  Index: 3

01:07:28  MulticastSocket.getInterface returned: /<IP_ADDRESS>
01:07:28  Failed! Expected: /<IP_ADDRESS>

01:07:28  MulticastSocket.getInterface returned: /<IP_ADDRESS>
01:07:28  Failed! Expected: /<IP_ADDRESS>

01:07:28  MulticastSocket.getNetworkInterface returned: name:lo (Software Loopback Interface 1)
01:07:28  Failed! Expected: name:eth1 (Red Hat VirtIO Ethernet Adapter)

-> Tests are returning localhost:
01:07:28  Display name: Software Loopback Interface 1
01:07:28  Name: lo
01:07:28  InetAddress: /<IP_ADDRESS>
01:07:28  InetAddress: /0:0:0:0:0:0:0:1
01:07:28  Up? true
01:07:28  Loopback? true
01:07:28  PointToPoint? false
01:07:28  Supports multicast? true
01:07:28  Virtual? false
01:07:28  Hardware address: null
01:07:28  MTU: -1
01:07:28  Index: 1

java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
01:19:23  STDOUT:
01:19:23
01:19:23  Test DatagramChannel to UNSPEC socket
01:19:23  join <IP_ADDRESS> @ eth2
01:19:23  Send message from <IP_ADDRESS> -> group <IP_ADDRESS> (id=0x7747ccae)
01:19:23  Waiting to receive message
01:19:23  Received message from /0:0:0:0:0:ffff:a9fe:fe1c%4 (id=0x7747ccae)
01:19:23  Message ignored (wrong sender)
01:19:23  Waiting to receive message
01:19:23  STDERR:
01:19:23  java.lang.RuntimeException: Expected message not received
01:19:23  	at MulticastSendReceiveTests.receiveDatagram(MulticastSendReceiveTests.java:110)
01:19:23  	at MulticastSendReceiveTests.test(MulticastSendReceiveTests.java:187)
01:19:23  	at MulticastSendReceiveTests.main(MulticastSendReceiveTests.java:267)
01:19:23  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
01:19:23  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
01:19:23  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
01:19:23  	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
01:19:23  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
01:19:23  	at java.base/java.lang.Thread.run(Thread.java:835)

I believe only George has access to these systems

Godaddy hosts are gone.


tor-browser does not find tor executable

Issue description
When trying to start tor-browser, a dialog pops up
Unable to start Tor.
The Tor executable is missing.

Steps to reproduce
add tor-browser to to installed packages and start it.
Technical details

System: 16.09.1623.74f24c7 (Flounder)  (Also reproducible on unstable)
Nix version: nix-env (Nix) 1.11.6
Nixpkgs version: 16.09.1623.74f24c7

I cannot reproduce this.
Could you try again with a clean profile? The path to the tor executable is written into the profile directory, but may become invalid if torbrowser is updated.

It was due to a stale ~/.torbrowser4 folder in case anybody else runs into this. Removing this folder fixes the issue.

I confirm what @r-raymond says

I'm working on a new version that "cannot" go stale: https://github.com/joachifm/nixpkgs/tree/tbb-new

@joachifm, great! Thanks for taking care of this!

Pushed ecd0e1a2c736a9a609cd820de0cb2861129482c3; hopefully a comprehensive fix.  Please let me know if you continue to experience stale references.


Dead link and small code change proposal

Thanks a lot for sharing :)

Oh my god... sorry!
I didn't know your bot would automatically merge PRs :D
Actually I just opened a PR because you disabled the issue tracker in Github


NOT able to install version 1.0.0 is it not released yet ?

@pablojim Could you make a release for version 1.0.0?

@SharpieX @maciej-gurban pushed to npm and tagged on github now.

Thanks @pablojim


Fails on all current distros

🤷🏽♂ Current Behaviour

All current releases based on Fedora or Ubuntu fail to run this app.  This happens on Ubuntu derivatives with the deb packages, and Fedora distros from rpm.  The appimage does not work and fails with the same issue.
A JavaScript error occurred in the main process
Uncaught Exception:
RangeError: Maximum call stack size exceeded
at write (console.js:165:9)
at Console.log (console.js:197:3)
at crawl (/tmp/.mount_pb-for2VxpQ0/resources/app.asar/node_modules/package.loader/lib/tools/crawler.js:47:13)
🎯 Expected Behaviour

The application should start and be usable.
👟 Steps to Reproduce (S2R)

Install on distro based on F29 or Ubuntu 18.04+,
Try to start pb-for-desktop

🏡 Environmental Context

App Version
vALL
Installation Type
RPM, DEB, AppImage
Operating System
F29, Ubuntu 18.04, Ubuntu 18.10

pb-for-desktop seems to work on ubuntu 18.10.
it can start up and send messages, alltho it seems like it does not know if the message was actually send or not and if i try to send messages to pb-for-desktop, it seems like no new messages will be received after startup.
if the program is restarted or i use the reconnect feature, all missing messages will then show up.
an error message sometimes appears with the option to send an error report, however the window closes if i try to fill out the form.

Same issue with Arch Linux.  This seems to be an issue with several versions I've tried in Arch.  If I click Blog and then the PB logo the error message disappears and the application begins working again.  I also have Ubuntu 18.10 installed and the exact same issue.

On Ubuntu 18.10 not getting any notifications and don't sincronized, but i can send pushes to other devices

While the app is usable and autostarts, SMS mirror or push notifications do not work.
Running Xubuntu 18.10.

@alongfield @pjb0521 Please validate whether this issue still occurs in the new version (10.0.1). Thanks.

@sidneys Notifications seem to be functional. Thank you for the fix!

i still get an error, but a diffrent message now:

but it seems to work anyway

@sidneys Notifications seem to be functional. Thank you for the fix!

You are most welcome.

i still get an error, but a diffrent message now:

but it seems to work anyway

Thank you for the report. A fix for this issue has just been deployed in version 10.2.0. Please and add your feedback should it reoccur.
Kind regards, S

seems like its fixed now, thanks a lot :)

Rebuilt from installed 9.5.0 in Arch AUR with a manual change to get 10.2.0 in the build file.  Built and installed fine and seems to be all set.  Thanks!


Gpc 1415 adding gt pv2 messages 38/39

In this pull request added Change Notification Req/Resp messages and unit tests for them.

approved


chore: cargo update to fix webpki vuln warning

Fixes: webpki: CPU denial of service in certificate path building

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


UX on Linux: needs additional click to access Web UI

When I click on tray icon, a single-item context menu is displayed:

When I click on it the actual Menu opens as expected:

I've seen this glitch in past, but was fixed some time ago.
Not sure what could cause this.
@hacdias  Was electron version updated recently or something?
Should I go back in time and find a version without this glitch, so we can see what changed since then?

Not really sure if the version of Electron was updated. If comparing to 0.5.0, yes, it was updated. Although I've never heard of this issue before. When you click the first time the icons are colored or faded out?

This doesn't happen anymore 😃


Issue #19 Add style checker

--added check style
--fixed check style findings.

1: Removed pmd checks (not worth it)
2: Based on rij checks, reviewed them and removed ones i think are not needed
3: updated read.me
4:  config location is required. Default path is <build.gradle.folder>/config/stylecheck/stylecheck.xml, in our case it is api/config/... , dont think adding such folder is good.. maybe better to change it to root build.gradle? ( but i do not know how to configure that)
5: Changed dependendOn to "build" will probably be called during deployment?.. not sure where to attach it, since we do not have many tasks..

4: config location is required. Default path is <build.gradle.folder>/config/stylecheck/stylecheck.xml, > in our case it is api/config/... , dont think adding such folder is good.. maybe better to change it to > > root build.gradle? ( but i do not know how to configure that)
I do not see a problem with the api/config folder. It is a configuration for the api module is it not?

Changed to default location as we discussed offline

Thanks, looks good to me.
@sergeytrasko any comments from your side? Otherwise we're good to go.


[MISC] Handle on start secret exception and remove stale test

Handle model error during _on_start hook
Remove stale TLS test

@taurus-forever
I agree.
Juju:

I've opened a bug on this: https://bugs.launchpad.net/juju/+bug/2074369

Feel free to upvote!

Libs:

Safety measure should be introduced on our side: I opened issue https://github.com/canonical/data-platform-libs/issues/184


ci: Move templates out of the 1ES folder

Description
Now that all the relevant pipelines have been migrated to use 1ES templates, we can move the updated template files from /tools/pipelines/templates/1ES back to their original location /tools/pipelines/templates (replacing their original counterparts which are not referenced anymore).
This was purely a move of existing files, and replacing paths from /tools/pipelines/templates/1ES to /tools/pipelines/templates/
Reviewer Guidance
The review process is outlined on this wiki page.

/azp run Build - client packages


Subject generator periodically creates subjects < 20 characters.

Easy fix - either change the generator to always be a minimum of 20 characters, or change the following code into the GetCell method:
before
cell.TextLabel.Text = item.Subject.Substring(0,20) + "...";

after
cell.TextLabel.Text = item.Subject.Substring(0,Math.Min(20,item.Subject.Length-1)) + "...";

This is a fix for IOS110 - will be corrected in that repo.
closing issue


Support portal hostname formats

what

Support a configurable format for hostnames
Fix typo schema -> scheme

why

Customer expressed they want to use format like dashboard-portal.us-west-2.staging.example.net format, vs dashboard.portal.us-west-2.staging.example.net due to use of wildcard ACM certificates instead of kube-lego annotations

references

https://github.com/cloudposse/charts/issues/146

Replaced by https://github.com/cloudposse/charts/pull/149


Guess

Guess

[x] Ensure guess uses the required letter, and the length is at least 4 letters.

[x] Ensure the users guess actually exists within the word bank.

[x] Check whether or not they guessed the pangram for the puzzle

[x] If the guess is valid, display message telling the user how it's correct and how many points they got.

[x] Update the point variable for user/rank if necessary.

[x] Add guessed word into variable storing their guesses.

[x] Ensure the user cannot guess a word that is already guessed

Primary: Noah
Secondary: Gabe
Size: M
Actual Size: (e.g. t-shirt size after completion)
Actual Time: (in minutes or hours -- after completion)

finished besides updating user/rank, but it tracks points. check #rough-draft-coding


Event hub is not working after enabling the email as username feature - APIM 4.0.0

Description:
After configuring the Email as Username feature with the externalized gateway deployment and when publishing APIs to the externalized gateway, the artifact is not getting deployed, and hence, able to see the 404 response when invoking the API.
Steps to reproduce:

Configure the deployment with an external gateway (profiled) with an All in One instance. (Please add the [apim.event_hub] configurations)

[apim.event_hub]
enable = true
<EMAIL_ADDRESS>password= "$ref{super_admin.password}"
service_url = "https://localhost:9443/services/"
event_listening_endpoints = ["tcp://localhost:5672"]

[[apim.event_hub.publish.url_group]]
urls = ["tcp://localhost:9611"]
auth_urls = ["ssl://localhost:9711"]

Configured the Email as Username feature by referring to the documentation[1].
Start all the nodes. (When starting the profiled gateway, not able to see the artifact deployment logs)

[2022-03-23 13:41:52,229]  INFO - QpidServiceComponent Activating Andes Message Broker Engine...
[Broker] BRK-1001 : Startup : Version: 0.11 Build: 90784:90849
[Broker] MNG-1001 : Startup
[Broker] MNG-1004 : Ready : Using the platform JMX Agent
[Broker] BRK-1002 : Starting : Listening on TCP port 5673
[2022-03-23 13:41:52,706]  INFO - listening [Broker] BRK-1002 : Starting : Listening on TCP port 5673
[Broker] BRK-1002 : Starting : Listening on TCP/SSL port 8673
[2022-03-23 13:41:52,711]  INFO - listening [Broker] BRK-1002 : Starting : Listening on TCP/SSL port 8673
[Broker] BRK-1004 : Qpid Broker Ready
[2022-03-23 13:41:52,716]  INFO - QpidServiceComponent AMQP Host Address : <IP_ADDRESS> Port : 5673
[2022-03-23 13:41:52,717]  INFO - QpidServiceComponent Successfully connected to AMQP server on port 5673
[2022-03-23 13:41:52,718]  INFO - QpidServiceComponent WSO2 Message Broker is started.
[2022-03-23 13:41:52,750]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,761]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,771]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,789]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,798]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,814]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,824]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,839]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:52,851]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,095]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,117]  INFO - PassThroughHttpListener Starting Pass-through HTTP Listener...
[2022-03-23 13:41:53,122]  INFO - PassThroughListeningIOReactorManager Pass-through HTTP Listener started on <IP_ADDRESS>:8281
[2022-03-23 13:41:53,123]  INFO - PassThroughHttpMultiSSLListener Starting Pass-through HTTPS Listener...
[2022-03-23 13:41:53,132]  INFO - PassThroughListeningIOReactorManager Pass-through HTTPS Listener started on <IP_ADDRESS>:8244
[2022-03-23 13:41:53,195]  WARN - SSLUtilBase The trusted certificate with alias [thawtepremiumserverca] and DN<EMAIL_ADDRESS>CN=Thawte Premium Server CA, OU=Certification Services Division, O=Thawte Consulting cc, L=Cape Town, ST=Western Cape, C=ZA] is not valid due to [NotAfter: Sat Jan 02 05:29:59 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,196]  WARN - SSLUtilBase The trusted certificate with alias [identrustdstx3] and DN [CN=DST Root CA X3, O=Digital Signature Trust Co.] is not valid due to [NotAfter: Thu Sep 30 19:31:15 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,197]  WARN - SSLUtilBase The trusted certificate with alias [addtrustclass1ca] and DN [CN=AddTrust Class 1 CA Root, OU=AddTrust TTP Network, O=AddTrust AB, C=SE] is not valid due to [NotAfter: Sat May 30 16:08:31 IST 2020]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,198]  WARN - SSLUtilBase The trusted certificate with alias [wso2carbon] and DN [CN=localhost, OU=WSO2, O=WSO2, L=Mountain View, ST=CA, C=US] is not valid due to [NotAfter: Tue Jan 25 13:00:43 IST 2022]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,198]  WARN - SSLUtilBase The trusted certificate with alias [mzyxmmfkogywmwi0zwnmndcxngywymm4zta3mwi2ndazzgqzngm0zgrlnjjkodfkzdriotfkmwfhmzu2zgvlng_rs256] and DN [CN=localhost, OU=WSO2, O=WSO2, L=Mountain View, ST=CA, C=US] is not valid due to [NotAfter: Tue Jan 25 13:00:43 IST 2022]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,198]  WARN - SSLUtilBase The trusted certificate with alias [gateway_certificate_alias] and DN [CN=localhost, OU=WSO2, O=WSO2, L=Mountain View, ST=CA, C=US] is not valid due to [NotAfter: Tue Jan 25 13:00:43 IST 2022]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,199]  WARN - SSLUtilBase The trusted certificate with alias [globalsignr2ca] and DN [CN=GlobalSign, O=GlobalSign, OU=GlobalSign Root CA - R2] is not valid due to [NotAfter: Wed Dec 15 13:30:00 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,199]  WARN - SSLUtilBase The trusted certificate with alias [soneraclass2ca] and DN [CN=Sonera Class2 CA, O=Sonera, C=FI] is not valid due to [NotAfter: Tue Apr 06 12:59:40 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,199]  WARN - SSLUtilBase The trusted certificate with alias [verisigntsaca] and DN [CN=Thawte Timestamping CA, OU=Thawte Certification, O=Thawte, L=Durbanville, ST=Western Cape, C=ZA] is not valid due to [NotAfter: Sat Jan 02 05:29:59 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,200]  WARN - SSLUtilBase The trusted certificate with alias [quovadisrootca] and DN [CN=QuoVadis Root Certification Authority, OU=Root Certification Authority, O=QuoVadis Limited, C=BM] is not valid due to [NotAfter: Thu Mar 18 00:03:33 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,200]  WARN - SSLUtilBase The trusted certificate with alias [addtrustqualifiedca] and DN [CN=AddTrust Qualified CA Root, OU=AddTrust TTP Network, O=AddTrust AB, C=SE] is not valid due to [NotAfter: Sat May 30 16:14:50 IST 2020]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,201]  WARN - SSLUtilBase The trusted certificate with alias [keynectisrootca] and DN [CN=KEYNECTIS ROOT CA, OU=ROOT, O=KEYNECTIS, C=FR] is not valid due to [NotAfter: Tue May 26 05:30:00 IST 2020]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,201]  WARN - SSLUtilBase The trusted certificate with alias [addtrustexternalca] and DN [CN=AddTrust External CA Root, OU=AddTrust External TTP Network, O=AddTrust AB, C=SE] is not valid due to [NotAfter: Sat May 30 16:18:38 IST 2020]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,201]  WARN - SSLUtilBase The trusted certificate with alias [luxtrustglobalrootca] and DN [CN=LuxTrust Global Root, O=LuxTrust s.a., C=LU] is not valid due to [NotAfter: Wed Mar 17 15:21:37 IST 2021]. Certificates signed by this trusted certificate WILL be accepted
[2022-03-23 13:41:53,330]  INFO - TaskServiceImpl Task service starting in STANDALONE mode...
[2022-03-23 13:41:53,387]  INFO - RegistryEventingServiceComponent Successfully Initialized Eventing on Registry
[2022-03-23 13:41:53,453]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,532]  INFO - JMXServerManager JMX Service URL  : service:jmx:rmi://localhost:11112/jndi/rmi://localhost:10000/jmxrmi
[2022-03-23 13:41:53,594]  INFO - StartupFinalizerServiceComponent Server           :  WSO2 API Manager-4.0.0
[2022-03-23 13:41:53,595]  INFO - StartupFinalizerServiceComponent WSO2 Carbon started in 29 sec
[2022-03-23 13:41:53,603]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,636]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,654]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,673]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,691]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:53,748]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,276]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,291]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,309]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,354]  INFO - CarbonUIServiceComponent Mgt Console URL  : https://<IP_ADDRESS>:9444/carbon/
[2022-03-23 13:41:54,354]  INFO - CarbonUIServiceComponent API Developer Portal Default Context : https://<IP_ADDRESS>:9444/devportal
[2022-03-23 13:41:54,355]  INFO - CarbonUIServiceComponent API Publisher Default Context : https://<IP_ADDRESS>:9444/publisher
[2022-03-23 13:41:54,370]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,383]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,406]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,427]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,453]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:54,469]  INFO - JMSConnectionFactory JMS ConnectionFactory : Siddhi-JMS-Consumer initialized
[2022-03-23 13:41:55,733]  INFO - CallHomeExecutor
....................................................................
wso2am-<IP_ADDRESS> is the latest update level available for the product
wso2am-4.0.0
....................................................................

Go to the publisher portal and publish an API. (Select the Externalized gateway)
Try to invoke the API and be able to see the 404 response.

[1] https://apim.docs.wso2.com/en/latest/install-and-setup/setup/security/logins-and-passwords/maintaining-logins-and-passwords/#setup-an-e-mail-login
Affected Product Version:
4.0.0

closing this issue as update is released for apim 4.0.0


CDPS-832: Correcting the sqs secret names

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.61%. Comparing base (e0bfad5) to head (b67ee9b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #38   +/-   ##
=========================================
  Coverage     83.61%   83.61%
  Complexity      284      284
=========================================
  Files            54       54
  Lines           903      903
  Branches         63       63
=========================================
  Hits            755      755
  Misses          110      110
  Partials         38       38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SimpleBufferedApacheFetchTest.Success is flaky

SimpleBufferedApacheFetchTest.Success fails with some regularity on travis.
see:
https://travis-ci.org/pagespeed/mod_pagespeed/builds/139282852
[ FAILED ] SimpleBufferedApacheFetchTest.Success

seems to be fixed by 6f403aa6c54ac4bfdb7e6a587b008c9c91eb27d6


Tabs

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: marcus8448:x: ChipWolfYou have signed the CLA already but the status is still pending? Let us recheck it.


Custom vocabulary not added correctly

Hi
I tried to add a custom vocabulary to AWS transcribe
after that I added the custom vocabulary name inside the stack and I updated my stack
then I tried to add a new call to process it
I found that no improvement in text extraction
on the another hand, I found that the custom voc not added yet!!!
you can find screenshot that the custom voc not added while I added it to my stack
how can I solve this???

Hi @muntherqasaimeh, To help troubleshoot, can you:

attach screenshot of the custom vocabulary listed in the Amazon Transcribe console.. including the Language setting for the vocab
attach screenshot of the current parameter values for your stack (in Cloudformation, select 'Parameters' tab) - showing the value for VocabularyName (at the end of the list).. Want to make sure it exactly matches
Check the value of the 'VocabularyName' parameter in System Manager Parameter Store (link].. include screenshot of that too
If everything aligns perfectly so far, then check the CloudWatch logs for the SFStartTranscribeJob Lambda function and share the logs reported there.. it should identify the custom vocabukary used for the job, based on the settings..

Assuming resolved since no follow-up. Please reopen if the issue remains. Tx.

Hello
I noticed a new issue
when I tried to update my stack I just removed the custom voc from the cloudformation to make it empty
so the stack is not able to be updated, giving errors custom vocabulary name parameter
I need to let it empty I dont want custom voc

if the Name of the dictionary has to have the language suffix , why does the template tell you to leave it off ?
once I added my language suffix to the filename it was applied properly
for anyone coming here with the same issue - this is what worked for me

cloudfommation dictionary entry: myfile
dictionary file name: myfile-en-us ( or whatever langauge suffix )


Make population a number instead of a string

Made population an integer in update_prevalance.py:AppLocation, ran yarn prevelance and updated frontend code accordingly.

How do we generally handle these backward-incompatible changes in update_prevelance.py? I just ran it on the branch here but I can imagine supporting both at first until it is run or something

How do we generally handle these backward-incompatible changes in update_prevelance.py? I just ran it on the branch here but I can imagine supporting both at first until it is run or something

Not sure what you mean. Why would we need to support both?
I'm not sure if this is what you're asking, but on a related note: we usually don't run update_prevalence on the same branch that does the changes. One branch does the changes. Then right after we merge it into main, we run the script and update all the data.
That said, I think what you're pointing out is that a bunch of stuff will break if we do it as two separate changes. So doing it exactly the way you have makes sense to me! 👍
Still not clear what "support both" would mean in this case, though.

@blanchardjeremy By "support both" I mean write frontend code that supports either format in the location.ts file (which would involve casework: parse it to a number if it's a string, otherwise don't), so that it works both before and after we run update_prevalence.py. Then once we run update_prevalence.py we could remove the casework in a later PR. That's generally how breaking backend changes are handled

Gotcha. Yeah. In that case , I think it'd be easier to just merge in the or the way you have it, where we have already run update prevalence as part of it.

@blanchardjeremy By "support both" I mean write frontend code that supports either format in the location.ts file (which would involve casework: parse it to a number if it's a string, otherwise don't), so that it works both before and after we run update_prevalence.py. Then once we run update_prevalence.py we could remove the casework in a later PR. That's generally how breaking backend changes are handled

Yeah, that's what I'd suggest if we had a real backend, but since it's secretly all frontend and changeable atomically, this looks like the right approach.

I found the "population as string" surprising while working on some other changes recently. I'd like to see this merged, especially since the prevalence script concerns are no longer relevant.

Well, I attempted to merge main and resolve conflicts, but it does appear as if there's going to be quite a bit more work to do as the code is still complaining about str/int conflicts, both in javascript and Python, so someone will need to invest more time in getting things working again.
I'm going to close this PR for now, but I welcome others to revive it or use it as a guide to re-implement it. I may do the same too, but for now it's too much for me to take on.


[Feature request] Add function to allow custom ignoring from the user

Say I want to ignore the scrollbar in float windows, having something like:
  require("scrollbar").setup({
    exclude_func = function(winid, bufnr)
      if not vim.api.nvim_win_is_valid(winid) then
        return true
      end

      local is_floating = vim.api.nvim_win_get_config(winid).relative ~= ""

      local filetype = vim.api.nvim_buf_get_option(bufnr, "filetype")
      local exclude_filetype = {
        TelescopePrompt = true,
        [""] = true,
      }

      local buftype = vim.api.nvim_buf_get_option(bufnr, "buftype")
      local exclude_buftype = {
        terminal = true,
        prompt = true,
      }

      return is_floating or exclude_buftype[buftype] or exclude_filetype[filetype]
    end,
  })

which is likely a bit more complicated and would require adding options for each kind of filtering the user wants to do. Having a function like this (can even provide some default options) seems a bit easier.
This would be in addition to exclude_filetypes or just replace it as that option would likely become redundant.
I will make a PR for this in a bit.

Handled by the commit that closes #10, as users can set show = false and then manually show the scrollbar as needed.


User specified profiles are never transformed from intensity to voltage

primary issue
At initialization a Pulsar object gives itself the default pulse profile (intensity).  If SignalType is 'voltage', the profile is square rooted to convert from power to amplitude.
https://github.com/PsrSigSim/VersionZeroPointZero/blob/623d4e0d93735db6dd4c95d7fcaf36ea8565b050/pulsar.py#L50-L54
However, if a user calls gauss_template() after initialization, there will be no unit conversion even if SignalType is 'voltage'.
secondary issue
In the snippet above the profile is scaled by the square-root of the profile max.  The max is set to 1 in guass_template() already.  This is only necessary for user specified templates, which don't pass through this code anyway.

This fix is needed to correctly handle radiometer noise for baseband signals with non-default pulse profiles.  See PR #11.

gauss_template and user_template can be updated to check self.SignalType and return the profile with correct amp/pow scaling at generation.


Verify that check_result() is not taking a long time inside GP.solve()

Profile this after implementing #23 .

I added some timing machinery in f46cba54a2e876e02f06dba39fd7c6010a071638. This means that GeometricProgram.solve() will now print more time information, if verbosity > 1.
@bqpd, if you like this, I think we should move this to 0.4, and use the fancy models we use as test cases to get a feel for the times.

Sounds good!

@whoburg, let's meet up and take a quick look at this.

Anecdotally verified during profiling.


Adding xp for messages doesn't work

To fix it; rework it, completely remove giving xp for messages, or just remove the time limit that causes the problem.

Every message gives xp now


[Linter] Warn against freezing a type T with a capability-like name (ends in Cap or Capability) and capability-like usage (one or more functions gated with &T inside the package that declares T)

Description
Implementslint to warn against freezing capability-like types in Sui, identifying function calls that may incorrectly freeze such types.
The lint checks for specific freezing functions defined in constants and inspects their type arguments for capability-like type names.
Run the linter
cargo test move_check_testsuit
Testing
File testing: freezing_capability.move
Release notes

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[x] CLI: newly added Move linter rule, only triggered if run with --rule freezing_capability
[ ] Rust SDK:

newly added Move linter rule, only triggered if run with --rule freezing_capability

I do not understand this release note. I do not believe that sort of filtering works. Could you elaborate?


Lucene 10577

This patch revisits the idea of storing vectors in 8-bit precision. It incorporates some @rmuir  and @jpountz suggestions from https://github.com/apache/lucene/pull/899 which was the first attempt. The highlights here are:

Adds a new VectorSimilarity to represent this use case
Expects vectors to be supplied (as float[]) with values in the range [-128,127]
All dot-product operations are done over byte using integer math when this similarity is used

The good parts:
Index size is reduced; I ran a test with 100K (200-dimensional) GloVe vectors and the index size goes from 231M to 173M for an M=200 graph and 154M->97M for an M=100 graph. The vector portion of the storage (.vec files) is reduced nearly 75% as expected.
With careful tuning of the scaling factor, recall is pretty much unchanged compared to the full-precision baseline. I think these GloVe vectors are not well-conditioned numerically, so to do the scaling I did not use min/max values as the limits, rather I discarded outlying values and used 0.1/0.99 pctile values.
Indexing and search performance as measured with KnnGraphTester improved somewhere in the range of 15-25%. I'd like to run luceneutil and/or ann-benchmarks to get another look, but this was a very pleasant surprise. I think the prospect is bright for vectorization too, but this improvement is achievable using our scalar impl.
The not-so-good-parts:
I think we probably wouldn't want to commit as-is since it would make changes to the codec that aren't forwards-compatible. To go forward I guess we'd need to create a new version of the HnswVectorsFormat.
I had to add some branches and generics to handle the two different data representations. I don't think it's too terribly ugly, but I know we've had concerns about this kind of thing in the past - maybe there's a better way that doesn't require massive code duplication?

hm this "luke-can-be-launched" test failed for me locally too. I guess it needs a JVM with a head?

hm this "luke-can-be-launched" test failed for me locally too. I guess it needs a JVM with a head?

It's not a part of the mandatory test suite but you can run it headlessly (if you are on Linux). Please see: https://github.com/apache/lucene/blob/71a9acb2e2aa55257021eefce1e5d8d390bc7048/help/tests.txt#L131
As for the occasional test failure of the GUI test for Luke, I'm planning to disable the test on windows VM - it looks too slow in GitHub Actions.

Also, it should run on headless JVM; we are running it on CI servers without displays.
https://github.com/apache/lucene/blob/71a9acb2e2aa55257021eefce1e5d8d390bc7048/lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java#L75-L78

I'm planning to disable the test on windows VM - it looks too slow in GitHub Actions.

I'm not sure it's the slowness anymore. Looks like some other issue blocking the forked process.

Looks like some other issue blocking the forked process.

Yes I think it could completely hang for some reason.

It's not a part of the mandatory test suite but you can run it headlessly with a virtual display (if you are on Linux). Please see:
Thanks, I guess it runs as part of check tasks? Anyway after installing xvfb I get a pass; thanks.

I ran luceneutil (after adding support for this new encoding, and scaling the vectors used on the build the candidate index and queries) and got decent results:
   Task QPS  | baseline |      StdDev | candidate  |      StdDev |                Pct diff | p-value

--------------- | -------: | ----------- | ---------: | ----------- | ----------------------- | --------- :
PKLookup       |   133.47 |     (18.7%) |     130.73 |     (24.6%) |  -2.0% ( -38% -   50%)  | 0.767
LowTermVector   |  1024.29 |     (15.6%) |    1140.88 |     (16.3%) |   11.4% ( -17% -   51%) | 0.024
MedTermVector   |   727.57 |   (8.6%)    |     850.54 |     (14.0%) |  16.9% (  -5% -   43%)  | 0.000
AndHighMedVector |   934.28 |    (8.9%)   |    1105.48 |     (15.0%) |   18.3% (  -5% -   46%) | 0.000
AndHighHighVector|   789.04 |   (11.1%)   |     947.74 |     (16.1%) |   20.1% (  -6% -   53%) | 0.000
AndHighLowVector |   910.39 |   (13.2%)   |    1219.95 |     (22.2%) |   34.0% (  -1% -   79%) | 0.000
HighTermVector  |   674.78 |    (8.8%)   |     915.99 |     (17.9%) |   35.7% (   8% -   68%) | 0.000
I have no explanation for the drop in PKLookup -- I checked the two indexes and they have the same named files, all the same sizes except for the .vec and .vem files, as expected.