Update init.py

The idea is to have one code function to send both Vids and Pics as the same functionality applies
def send_vid_pic(self, vid_pic, message=" "):
send_video can then call self.send_vid_pic(vid_pic, message="") and therefore not break anyone's code
I do have an issue though, Not sure if it is just my Laptop or 102 of Chrome but:

If I step through the code then all works fine (chrome shows a lot of lag)
If you just run the code then nothing seems to be sent..

Please assist if you can - I thought of waiting until NOT present "Sending message" popup is not present, but I just cannot find how to do this...

Hi, @theCJMan. Converting this into a draft while all of us investigate. Thanks a lot for the contribution!
Can you please be a little more specific on the difference between step through the code and run the code? Testing this into some hours.

Hey guys, sorry for the late reply
I am using PyCharm as UI for my development environment,
“Running” the code let the app run from start to end, no breakpoints
“Stepping through the code” allows me to execute one line of code at a time, inspect variables and step to the next line, or run up to a breakpoint then run the code line by line
my app loads an Excel file and loop through the file row by row.
It reads the First and last names, WhatsApp message to send, and attachment file to be send
If you need I can post my full app as well
Cornelius Mostert
B.Sc. (Computer Science), M. IT. (Knowledge Management)
WWW:  https://corneliusmostert.com/ Me on the Web
WhatsApp:  https://api.whatsapp.com/send?phone=27790995412&text=<PHONE_NUMBER>
From: Eurico Nicacio @.>
Sent: Saturday, 25 June 2022 08:37
To: Kalebu/alright @.>
Cc: Cornelius Mostert @.>; Mention @.>
Subject: Re: [Kalebu/alright] Update init.py (PR #73)
Hi, @theCJMan https://github.com/theCJMan . Converting this into a draft while all of us investigate. Thanks a lot for the contribution!
Can you please be a little more specific on the difference between step through the code and run the code? Testing this into some hours.
—
Reply to this email directly, view it on GitHub https://github.com/Kalebu/alright/pull/73#issuecomment-1166204991 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCPFSZIOSJHQYINQAWDFALVQ2SHXANCNFSM5ZYHLNNQ .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AJCPFS4X4WD5EKPDIX7GNT3VQ2SHXA5CNFSM5ZYHLNN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIWBOAPY.gif Message ID: @.*** @.***> >


Found a way to save all the tabs to a file

After trying literally everything and anything, I have hit the jackpot, and was able to get full tab list.
I'm not sure which prefs, settings, flags are important, so I just all of them ;P
Chromium116.0.5845.61 (Official Build) (64-bit)
Revision040e18a49d4851edd8ac6643352a4045245b368f-refs/branch-heads/5845@{#769
Command Line    --use-mobile-user-agent --top-controls-show-threshold=0.5 --top-controls-hide-threshold=0.5 --use-mobile-user-agent --enable-viewport --validate-input-event-stream --enable-longpress-drag-selection --touch-selection-strategy=direction --disable-composited-antialiasing --enable-dom-distiller --flag-switches-begin --enable-experimental-accessibility-language-detection --enable-experimental-accessibility-language-detection-dynamic --enable-quic --show-autofill-signatures --extensions-on-chrome-urls --enable-features=ClipboardUnsanitizedContent --disable-features=OmniboxMatchToolbarAndStatusBarColor,OmniboxModernizeVisualUpdate --flag-switches-end
Settings no preloading, no https, no safe browsing, no DNS
chrome://profile-internals Expand chrome tabs
https://imgur.com/a/TygQgCA
Install this extension, check all the boxes, plus in site settings everything to allow
https://chrome.google.com/webstore/detail/save-as-mhtml-mime-html/djbjejcpegcimjdappppobfhaafbmjpf
Restart the browser, open chrome://profile-internals again, you'll get an internal page in JSON, open menu, click save MHTML.
The page will be saved in downloads folder
https://www.reddit.com/r/kiwibrowser/comments/15o77ai/_/

This is a very cool find! A bit complex, but can be useful for desperate users. Thanks

For root users, look for /data/data/com.kiwibrowser.browser/cache/Offline Pages/archived.
To manage them on internal storage, delete the directory & softlink it to userspace.
su -c ln -s /data/media/0/Android/data/com.kiwibrowser.browser/files/Download /data/data/com.kiwibrowser.browser/cache/Offline\ Pages
From then you can manage the mhtmls without root prevs.


Update stable

Bumps github.com/onsi/gomega from 1.12.0 to 1.13.0.

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

/lgtm


Suricata blocks traffic after update to OPNsense 21.1-amd64

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
After update to the new version I suggest that suricata has got problems with the signatures of the snort_vrt.oinkcode or snort_vrt.rulesfile or et_telemetry.token. Whatever happend i do not know, but disabling the intrusion detection brought me back into the internet.
Any ideas?
A clear and concise description of what the bug is, including last known working version (if any).
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:

Go to 'Services: Intrusion Detection: Administration' activate >> update >> error = no internet
Click on 'Enabled' >> activate Click on 'Download' >> download all >> Click on 'Alerts' = flodding blocks
Scroll down to '....'
See error
Here are some error messages:

2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_INVALID_SIGNATURE(39)] - error parsing signature "drop tcp $EXTERNAL_NET any -> $HOME_NET $HTTP_PORTS (msg:"SERVER-WEBAPP Oracle GlassFish Server authentication bypass attempt"; flow:to_server,established; content:"GET"; nocase; http_method; content:"/applications/upload"; http_uri; pcre:"/^(Frame)?\.jsf/R"; content:!"JSESSIONID="; flowbits:set,glassfish_unauth_attempt; metadata:policy max-detect-ips drop, service http; reference:bugtraq,47438; reference:cve,2011-0807; classtype:attempted-admin; sid:20159; rev:9;)" from file /usr/local/etc/suricata/opnsense.rules/snort_vrt.server-webapp.rules at line 3542 |
-- | -- | -- | --
2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_INVALID_SIGNATURE(39)] - pcre with /R (relative) needs preceeding match in the same buffer |
2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_INVALID_SIGNATURE(39)] - error parsing signature "drop tcp $EXTERNAL_NET any -> $HOME_NET $HTTP_PORTS (msg:"SERVER-WEBAPP Multiple products DVR admin password leak attempt"; flow:to_server,established; content:"/device.rsp"; fast_pattern:only; http_uri; content:"uid="; http_raw_cookie; content:"cmd=list"; http_uri; metadata:policy balanced-ips drop, policy max-detect-ips drop, policy security-ips drop, service http; reference:cve,2018-9995; classtype:web-application-attack; sid:46825; rev:2;)" from file /usr/local/etc/suricata/opnsense.rules/snort_vrt.server-webapp.rules at line 1118 |
2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_RULE_KEYWORD_UNKNOWN(102)] - unknown rule keyword 'http_raw_cookie'. |
2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_INVALID_SIGNATURE(39)] - error parsing signature "drop tcp $EXTERNAL_NET any -> $HOME_NET $HTTP_PORTS (msg:"SERVER-WEBAPP Grandstream UCM6202 series SQL injection attempt"; flow:to_server,established; content:"user_name="; fast_pattern:only; http_uri; urilen:4; content:"/cgi"; nocase; http_uri; pcre:"/[?&]user_name=[^&]*?([\x27\x22\x3b\x23\x28]\|\x2f\x2a\|\x2d\x2d)/Ui"; metadata:policy balanced-ips drop, policy max-detect-ips drop, policy security-ips drop, service http; reference:cve,2020-5722; classtype:web-application-attack; sid:53858; rev:2;)" from file /usr/local/etc/suricata/opnsense.rules/snort_vrt.server-webapp.rules at line 198 |
2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_INVALID_SIGNATURE(39)] - depth or urilen 4 smaller than content len 10 |
2021-01-29T09:52:34 | suricata[77119] | [100169] <Error> -- [ERRCODE: SC_ERR_INVALID_SIGNATURE(39)] - error parsing signature "drop tcp $EXTERNAL_NET any -> $HOME_NET $HTTP_PORTS (msg:"SERVER-WEBAPP Multiple products DVR admin password leak attempt"; flow:to_server,established; content:"/device.rsp"; fast_pattern:only; http_uri; content:"uid="; http_raw_cookie; content:"cmd=list"; http_client_body; metadata:policy balanced-ips drop, policy max-detect-ips drop, policy security-ips drop, service http; reference:cve,2018-9995; classtype:web-application-attack; sid:55839; rev:1;)" from file /usr/local/etc/suricata/opnsense.rules/snort_vrt.server-webapp.rules at line 100

Expected behavior
A clear and concise description of what you expected to happen.
Describe alternatives you considered
Disable Suricata and everything works fine.
A clear and concise description of any alternative solutions or workaround you considered.
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense OPNsense 21.1-amd64
FreeBSD 12.1-RELEASE-p12-HBSD
OpenSSL 1.1.1i 8 Dec 2020
Intel(R) Core(TM) i3-9100F CPU @ 3.60GHz (4 cores)
Network Intel Corporate

suricata.log

suricata.log

Hello. I think I found (my) the mistake. All possible rules were activated under menu item Services: Intrusion Detection: Policy. I can remember that I only activated relevant rules for myself. When I adjusted these rules, the accesses I wanted were blocked. Now the question arises, does it make sense to activate all of these or are there any empirical values that should be set?

Hello. I think I found (my) the mistake. All possible rules were activated under menu item Services: Intrusion Detection: Policy. I can remember that I only activated relevant rules for myself. When I adjusted these rules, the accesses I wanted were blocked. Now the question arises, does it make sense to activate all of these or are there any empirical values that should be set?

I don't know about the VRT rulesets, but the emerging threats open variant has the risk of false positives, when using telemetry chances are smaller (since some open rules are filtered out there for this reason by Proofpoint)

I don't know about the VRT rulesets, but the emerging threats open variant has the risk of false positives, when using telemetry chances are smaller (since some open rules are filtered out there for this reason by Proofpoint)

Hi, you can close this issue. Everything is working fine. I did not activate "pt.research.rules". I guess that was the rule which blocked.
Thnx

done


Macro limitations

The README.MD file hints at macros being useful for scaffolding head/body items …

It may be useful to define macros that expand to either body items or head items. Ascent allows you to do this.

… which the MACROS.MD then provides further examples for and gives the following motivation …

Macros can be defined inside Ascent programs to avoid having to repeat code.

As somebody accustomed to Rust's native macro the above would make one assume that —just like in Rust itself— ascent's macros could be used in effectively every position in the code. In reality however it seems that ascent's macros are limited to clause position.
As such this works:
ascent! {
    // Facts:

    relation unique(isize);

    // Macros:

    macro shared($x: expr) {
        shared(Rc::new($x))
    }

    // Rules:

    relation shared(Rc<isize>);

    shared!(*x) <-- unique(x);
}

This however doesn't:
ascent! {
    // Facts:

    relation unique(isize);

    // Macros:

    macro rc($x: expr) {
        Rc::new($x)
    }

    // Rules:

    relation shared(Rc<isize>);

    shared(rc!(*x)) <-- unique(x);
    //     ^^
    // error: cannot find macro `rc` in this scope
}

This is rather surprising and unexpected.
As such I would expect the above to either be accepted or at least provide a more useful error message than the current "cannot find macro … in this scope".

The point of macro definitions in Ascent is to do what can't be done with normal Rust macros (i.e., expand to body or head clauses). If you need macros that expand to expressions (as in your second example), you can just define them as Rust macros.
Regarding better error messages, that's not really feasible, as the error message is coming from the Rust compiler, and not Ascent.
The readme mentions that macro invocations expand to body or head items. I'll update MACROS.MD to emphasize this fact.


getting python error on run

getting the following error when I run cloudgrep
Traceback (most recent call last):
  File "/home/ec2-user/cloudgrep/cloudgrep.py", line 1, in <module>
    from cloudgrep import __main__
  File "/home/ec2-user/cloudgrep/cloudgrep/__main__.py", line 6, in <module>
    from cloudgrep.cloudgrep import CloudGrep
  File "/home/ec2-user/cloudgrep/cloudgrep/cloudgrep.py", line 46
    match log_type:
          ^
SyntaxError: invalid syntax

I can't figure out why this is, an older version of the package installed works fine.

Hi @ashmirza I deployed an Amazon linux instance, and looks like you just need to upgrade to python 3.10 or later.

Fix looks good, thanks for raising


Missing Texture on <IP_ADDRESS>

I updated to the latest version and there appears to be a missing texture.

Whoops, wrong file name. I've just uploaded a new build to CurseForge, hopefully it's approved soon.

I just want to say I absolutely love the new textures.

Thanks! They weren't quite finalized when I did the previous release, but they'll be out for Forge soon. 1.20.6 will take a while though, I'm afraid.
Textures are by Vouniern.


chaise record page should enforce uniqueness of its entity reference

This PR addresses the issue where more than one entity is fetched in the record, then the record page displayed a lot of unrelated entities.
With this PR:
An error modal window will be displayed if there are more than 1 entity fetched for a given constraints and on the click of OK button, the page will redirect to recordset page to display all the fetched results appropriately.
An implementation of this is available here

@nitishksahu if the code for this has been merged, please close this issue.
If you want to have the featured reviewed by others, assign a reviewer to this issue. I think we have a separate issue already for the feature review.

This PR is related to issue#1098
@hongsudt this issue is waiting on your queue to verify, if everything looks good, we can close this.

This looks good. You can close the issue.


Footer not displayed in 0.2.8 and 0.2.7

The footer frame is not displayed in pdf file when following the documentation.
How to reproduce:

create a virtualenv with xhtml2pdf library:

python3 -m venv venv
./venv/bin/pip install xhtml2pdf

add an index.html file containing the example at https://xhtml2pdf.readthedocs.io/en/latest/format_html.html#example-with-2-static-frames-and-1-content-frame
./venv/bin/xhtml2pdf index.html

The generated index.pdf shows only 'Lyrics-R-Us' and 'To PDF or not to PDF'.
It could occurs in others releases. I only checked these two releases.

I have the same problem, I went from 0.2.5 to 0.28 and the footers stopped being generated.

Have the same issue with images near the bottom of the page being bottom-cropped with percentage depending of their height. Issue is present since 0.2.6. Had to pin back 0.2.5 (and reportlab to 3.6.6)

Is this a duplicate of #644? If so, can it be closed since #628 has been merged?

Duplicate of #644 and #564

I confirm the test case is fixed in 0.2.9.


Fixed ReleaseJobExtension compilation

Fixed ReleaseJobExtension compilation failures w.r.t endpoint resourceUrl

@lovakumar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


feat(utils): Produce valid snapshot names

Description
The previous version of loupe pulled within Vitest was not properly splitting strings to produce names of snapshots. The proposed PR bumps it and adds the relevant tests.
Fixes #5681
Note: I feel the lock has changed a bit more than what I would have expected. I updated it with<EMAIL_ADDRESS>from a GitHub Codespace. I don't really get how to properly update it if it's not the right one.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[x] Ideally, include a test that fails without this PR but passes with it.
[x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[x] Run the tests with pnpm test:ci.

Documentation

[x] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Looks good to me! Thank you! The lint error is also on main, two PRs merged too quickly 😄


perf: cache NumberFormat before expanding options

Options expansion was slow
This gives additional 2.7x speedup compared to #8
Also, we don't need lodash

tests are failing for me
><EMAIL_ADDRESS>unit
> ava --verbose

  ✔ edge cases
  ✖ format numbers
  ✔ call Intl.NumberFormat correctly

  1 test failed [11:08:05]

  format numbers

  /Users/mv/code/format-num/test/test.js:22

   21:   // maybe a bug?
   22:   t.is(formatNumber(10000000.00000004), '10,000,000', '')
   23:

  Difference:

  - '10,000,000.00000004'
  + '10,000,000'

@mvayngrib they are failing on master (since the start)

confirmed it also fails on master 👍


NASA discontinuing FTP server for ephemeris data.

The README.md suggests downloading the daily GPS ephemeris data from NASA's FTP server. This service is ending on October 31, 2020 as per their website. Please update the README to go suggest visiting the new HTTPS instead.

The new way to get ephemeris data is as follows:

Register an account with https://urs.earthdata.nasa.gov/ (There is no way around this step).

Create a file called .netrc  with the following format.
machine urs.earthdata.nasa.gov login <username> password <password> where <username> and <password> are the values you set when you created your Earthdata login account. Don't forget to sudo chmod 004 .netrc so that no one can read your file and get your username and password.

You can automate with the process with following script.

#!/bin/sh
day=$(date +%j)
year=$(date +%Y)
yr=$(date +%y)

curl -c /tmp/cookie -n -L -o "brdc""$day""0.$yr""n.Z" "https://cddis.gsfc.nasa.gov/archive/gnss/data/daily/$year""/brdc/brdc""$day""0.$yr""n.Z"

uncompress "brdc""$day""0.$yr""n.Z"
echo "brdc""$day""0.$yr""n.Z"

The .netrc file along with the -n flag allows curl to automatically authenticate when attempting to retrieve the file.
I hope this helps and please consider expanding the README to include more information like this.

Thanks @cmconrad - this was super helpful. I've got a couple updates to your script to reflect 1) a different NASA URL and 2) a change in the Ubuntu's OpenSSL settings that gave me trouble running this script and 3) a couple readability changes.
Here's how I get ephemeris now on Ubuntu 20.04: (first two steps are the same as @cmconrad's)

Register an account with https://urs.earthdata.nasa.gov/ (There is no way around this step).

Create a file called .netrc with the following format:
machine urs.earthdata.nasa.gov login <username> password <password> where  and  are the values you set when you created your Earthdata login account. Don't forget to sudo chmod 004 .netrc so that no one can read your file and get your username and password.

Put the following in ~/.openssl_allow_tls1.0.cnf:

openssl_conf = openssl_init

[openssl_init]
ssl_conf = ssl_sect

[ssl_sect]
system_default = system_default_sect

[system_default_sect]
CipherString = DEFAULT@SECLEVEL=1

This is an OpenSSL configuration file that allows you to temporarily make cURL use an older, weaker set of SSL settings. In the script below, the OPENSSL_CONF=~/.openssl_allow_tls1.0.cnf preceding the curl command applies these OpenSSL configs to just that single curl command, so the rest of your system still uses the newer preferred OpenSSL settings. I found this solution in an AskUbuntu forum answer and it's working well for me on Ubuntu 20.04.

Put the following into a script (I called mine pull-brdc.sh):

#!/bin/sh
day=$(date +%j)
year=$(date +%Y)
yr=$(date +%y)

OUTFILE="brdc""$day""0.$yr""n.gz"
URL="https://cddis.nasa.gov/archive/gnss/data/daily/$year/brdc/$OUTFILE"
echo "Downloading ${URL} into ${OUTFILE}"

OPENSSL_CONF=~/.openssl_allow_tls1.0.cnf curl -c /tmp/cookie --netrc-file ~/.netrc -L -o $OUTFILE $URL

uncompress $OUTFILE
echo $OUTFILE

Run chmod +x pull-brdc.sh and run with ./pull-brdc.sh and you should get today's brdc file.

One change I made to the cURL command was to replace the original -n flag with  --netrc-file ~/.netrc. The behavior is exactly the same, since ~/.netrc is the default file reading in -n mode. However, with the --netrc-file flag, you could change the path to the .netrc file in case you are on a shared machine and don't want to put your username and password in the home directory.


paper writing;: table overview of tasks

see https://github.com/embeddings-benchmark/mteb/discussions/595#discussioncomment-9467714

Assigned to @ Sakshamrzt

@KennethEnevoldsen Having a lang column seems necessary but it could lead to issues like above. What do you think should be done here?

Ahh yea that seems a bit frustrating. A solution would be to reduce it to ["acm", "afr", "als", ...], with a maximum on n=10 languages. This does not convey the size though. So would add a column with the number or something like
N. Languages
---
107 ("acm", "afr", "als", ...)

Sounds good!

Had a look at the table. Looking good so far!
A few suggestions at which point I think we are getting there)

introduce a space between name and citation
make the text smaller (size the table is quite large) e.g. see - ideally no more than 2 lines pr. dataset.
Move the table to appendix D (though that should probably be moved to be the last appendix). We should also add a small introduction here as well as long with a reference to the table on docs (which includes the description).
I would add a parenthesis around the language)
remove decimals from N. Docs, as well as reduce the avg. length decimals to 1.
We will probably need to add in the size for the cases where it is missing
there is one citation that does render properly

Will close this issue for now. the MTEBTasks object now has a to_latex function


Changing isServerEncrypted parameter to Boolean to avoid NPE

Description
resolves #32255
NullPointerException occurred due to null value passed in for isXMsRequestServerEncrypted. Changed to Boolean to handle nulls.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob

If we're fixing a bug we should be adding tests to confirm the fix.

/azp run java - storage - tests


doc: update design.rst

Merging this PR will replace NodeJS to Node.js(Node.js and not NodeJS) with link to the Node.js official site in the design.rst page.

Landed in https://github.com/libuv/libuv/commit/805401b0b30d58ceb4fa28cf6881015e8fec1cf2. Thanks!


Test azure plugin claims migration on a schedule

Create azure plugin integration tests
test claims migration
do it on a schedule (daily)

So would the general outline of the integration test here be:

Install test bundle with pre-v0.28.0 porter release
Upgrade test bundle with >= v0.28.0 porter release
(2.5: And/or, may have an explicit migrate step per https://github.com/deislabs/porter/issues/1203)
Verify all is well/expected
Cleanup

With the following details:

we can use the current azure plugin code with updated claims support for all the test actions, right? (It supports working with pre- and post-v0.28.0 porter?)
use a storage account in Canada (supporting tags as req'd by newer version of Azure plugin)

Prereq:

We can use canary Porter, though we may want an official pre-release/rc, if v0.28.0 still hasn't been cut when this is worked on

Other notes/details here?


cache http response code

If for example "500" is cached, response retrieved from redis is served with "200" response code.

:+1: on this.

looks like there was work done on this here https://github.com/inthepocket/express-redis-cache/commit/a24321bf13aa20d589052e5584745e3264dd819b , though it needs tests.

Just for note, this seems broken again. :)
I came here looking for this issue. I will look into previous fixes and see if I can get you all a fix.

@madelinecameron I know it's been a while, but any updates on this?

I haven't used this library in a while so haven't been able to check up on this bug. :)

This is broken again! Please fix it. :-)

The branch or the project? Just want to know if my branch broke. I haven’t used this in a while. 😅

On Jul 1, 2019, at 10:02, MaraZ1<EMAIL_ADDRESS>wrote:
This is broken again! Please fix it. :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


If the user is not logged into the website, they are unable to download the slides.

The user is allowed to download the specific slides even without logging in @hkirat .

Yeah, but it's not an issue, it's done here intentionaly I think.


remember query history

cycli console should remember query history even across different sessions, just like neo4j-shell does.

:+1:


Added tests for CreatePostViewModel - 100% covered

Hey, I have added the test cases for CreatePostViewModel.
Hope it is useful.
Thanks.

@sergdort can you please have a look and do the needful. Thank you.


Should fontspec support square brackets?

Should this work?
\documentclass{article}
\usepackage{unicode-math}
\setmainfont{[texgyrepagella-regular]}
\begin{document}
hello \emph{hello}
\end{document}

It currently does but only by coincidence (without the square brackets it doesn't work, but with a literal .otf appended fontspec parses that out and does the right thing).
I should decide whether this should (continue to) work or not and include it in the docs.
I guess for backwards compatibility I should keep it working, but parse out the [ and ] chars from the name and then automatically call the Path feature.

Let's not promulgate shorthand syntax where it doesn't belong. I'll close this and assume any accidental support for [] doesn't catch on…


Add substring_index function support

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Add columnar support for substring_index to reduce fallback.

Fixed.


Identify source of teacher data?

Can we say where the teacher data comes from? Is it synthetic data? It feels a little weird to say simple anonymization is not sufficient... and then go head and appear to rely on just dropping the state column.
Close when we can add a little note about the provenance of this data to the new tutorial.

(Note sent to data preparer. If not answered soon, will move this issue out of the milestone)

The data file was taken from this source: http://spss.allenandunwin.com.s3-website-ap-southeast-2.amazonaws.com/data-files.html (the first database, survey.sav). Nonetheless, as it had few entries, we repeated the data to reach 7000 entries. Also, we made a different story as follows about the participants in the survey and its purpose:

Thanks for tracking this down: Feel free to assign to me to make the edit, otherwise I'll leave it to you. Perhaps something like:

This sample data is derived from a survey in Julie Pallant's SPSS Survival Manual

If you want more to worry about:

Do we have a license for this? Should we?
It feels weird to just duplicate the data to get to an acceptable error level, and neither explaining our process nor hoping it won't be noticed feels great. -- It's one thing that people should definitely not do in the real world.

^ Yes. Agreed. Can't use w/o a license


don't deploy the SSO server via env.dependencies

The test expects the SSO server to be already deployed, so we shouldn't configure Arquillian Cube to deploy it again.
Could you please also do the same in the redhat branch? Thanks.

@Ladicek Is this really a problem (as it worked for me) or is this just a minor detail?
As I found it useful to have this as part of arq.xml.

It's an annoyance when automating tests of all the SSO boosters, as neither Swarm nor Vert.x do this. They both expect the SSO server to already be deployed.
You need to pass in SSO_AUTH_SERVER_URL anyway, and I'm not aware of any general way to predict that -- you have to deploy the SSO server to figure it out. In which case it kinda doesn't make sense for the test to deploy it again. Am I missing something here?

@Ladicek for me it was useful when I did "oc delete all", and then just re-ran the "mvn verify".
But np, I'll remove it.

I think locally, you could pass -Denv.dependencies=... on the cmdline -- that should help in your oc delete all usecase.

Fixed: in sb-1.5.x and redhat

Thanks!


Getting a weird error with flow router?

I'm getting this error
W20150501-00:42:27.780(-6)? (STDERR) Publish handler for games sent no ready signal

Here's my packages:
grigio:babel              0.1.2  Write javascript ES6 in your Meteor app
grove:react               0.1.3  React for Meteor - vendor files and essential mixins
meteor-platform           1.2.2  Include a standard set of Meteor packages in your app
meteorhacks:fast-render   2.3.2  Render you app even before the DDP connection comes live. - magic?
meteorhacks:flow-router   1.5.0  Carefully Designed Client Side Router for Meteor
meteorhacks:subs-manager  1.3.0  Subscriptions Manager for Meteor

Here's the router code:
var subs = new SubsManager();

FlowRouter.route('/', {
	subscriptions: function(params) {
		this.register('games', subs.subscribe('games'));
		console.log("Subscribed to current game");
	},
	action: function(params) {
		console.log("Rending your first react shit");
		React.render(<Game name="World" />, document.getElementById('yield'));
	}
});

I can stop the error from happening by doing:
subscriptions: function(params) {
    if(Meteor.isClient) {
        this.register('games', subs.subscribe('games'));
    }
    console.log("Subscribed to current game");
},

Just wondering if I'm doing something wrong here!
-Thanks

Never mind I think it had to do with poor naming conventions on my part! keep on keeping on guys!


added method pop to protocol Mapping and dict implementation

This PR adds method pop to protocol Mapping and the dict implementation. Also a minor change to method get. The signatures are
get         : (A,?B) -> ?B
pop         : mut(A,?B) -> ?B

The required check test-app-yang fails and prevents the merging of this PR which would fix issue #1989. I don't know what the problem is.

Agreed in todays meeting that this is the way forward, having separate get() and getdef() functions. I will split this PR into two parts, the first introducing getdef() / popdef(), then we can merge that and change the various applications we have after which we can do the second change, which is modifying the get() / pop() definitions in this backwards incompatible way. I will fix!

This is now implemented via #2040 etc. Closing.


changeDate event doesn't return "date" if it is the same date.

So if you do
$('.element').datepicker().on("changeDate", function(e){
    console.log(e.date);
});

If you choose a different day other than today, it will return the date. If you choose the same date, it will return with
undefined

http://jsfiddle.net/tuG6C/333/ <--- click on the input field, click on dates, check out the console and see how it reacts. It will return the date unless it's the same date.
This doesn't seem logical. If it returns the date for all other dates, it should return for same day. I haven't tested other events but I know it happens on changeDate for sure.

Can anyone verify if this is still an issue? I can't reproduce it in chrome/ff with http://jsfiddle.net/vh1oknf7/5/

Tested it out too. On the same env I had the bug on. Works fine for me now.

The fix provided by @sularome is working pretty well. Thanks !


[Question] Can anyone give me some WORKING proxy?

Hello, i was checking for security my server but i need a working proxy because the txt that i donwloaded from here: socks-proxy.net,  but it just says timed out and shows a socks error.
Thanks in advanced

these ones currently work for me
<IP_ADDRESS>:1080
<IP_ADDRESS>:1080
<IP_ADDRESS>:1080
<IP_ADDRESS>:1080
<IP_ADDRESS>:8080
<IP_ADDRESS>:65111
<IP_ADDRESS>:37451
<IP_ADDRESS>:49597
<IP_ADDRESS>:61981
<IP_ADDRESS>:1080
<IP_ADDRESS>:40831
<IP_ADDRESS>:1080
<IP_ADDRESS>:1080
<IP_ADDRESS>:8975
<IP_ADDRESS>:17127
<IP_ADDRESS>:1080
<IP_ADDRESS>:6699
<IP_ADDRESS>:1080
<IP_ADDRESS>:38816
<IP_ADDRESS>:1090
<IP_ADDRESS>:38801
<IP_ADDRESS>:62353
<IP_ADDRESS>:8080
<IP_ADDRESS>:30588
<IP_ADDRESS>:30588
<IP_ADDRESS>:58690
<IP_ADDRESS>:6699
<IP_ADDRESS>:4145
<IP_ADDRESS>:62354
<IP_ADDRESS>:30588
<IP_ADDRESS>:9050
<IP_ADDRESS>:23105
<IP_ADDRESS>:10200
<IP_ADDRESS>:1080
<IP_ADDRESS>:1080
after a quick 5-second google search, I found them here(Make sure they are socks5): http://free-proxy.cz/en/
next time do a google search instead of opening an issue.

ok thx


sap azd templates add

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new azd template to the gallery
Fill this out if you want your template to be added to the awesome-azd gallery!
Your template repository
Place your template repository link here:

[x ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

[x ] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

[ x] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

[ x] Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

[ x] Link to Author's GitHub or other relevant website - Used for attribution

[ x] Author's Name -  Name to credit on the gallery card

[ x] Link to template source - Link to the template GitHub repo

[ x] Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!
Required tags:

[ x] Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
[ x] Tag the IaC provider ("bicep" or "terraform")
[ x] At least 1 tag for programming language used
[x ] At least 1 tag for Azure services integrated
[x ] Add the "new" tag for any newly authored templates

[x ] In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

[ ] Name of resource
[ ] Resource author - who created this resource? (so we can credit them!)
[ ] What section should this resource be included in? -Is the resource an article? A video? Something else?

These are the two repos that we would like to see added:
https://github.com/Azure-Samples/app-service-javascript-sap-cap-quickstart
https://github.com/Azure-Samples/functions-javascript-sap-cloud-sdk-quickstart

@v-xuto Could you test these templates?

@hemarina  Sure. We will test this template today.

@v-xuto any findings?

@v-xuto any findings?

Under testing, will be updated here when testing is complete.

@hemarina, @MartinPankraz We have finished this template test, and we filed five issues. Please review.

https://github.com/Azure-Samples/functions-javascript-sap-cloud-sdk-quickstart/issues/48
https://github.com/Azure-Samples/functions-javascript-sap-cloud-sdk-quickstart/issues/49
https://github.com/Azure-Samples/functions-javascript-sap-cloud-sdk-quickstart/issues/50
https://github.com/Azure-Samples/app-service-javascript-sap-cap-quickstart/issues/22
https://github.com/Azure-Samples/app-service-javascript-sap-cap-quickstart/issues/23

@hemarina @v-xuto I adjusted the repos as requested. The issue requires authentication as per the customer choice of system. The default points towards SAP's cloud sandbox. Step 5 here calls out that fact.
Please let me know if anything else is needed to approved the PR

@hemarina when will these show up on the gallery?


能否实现可以编辑和删除已发送给用户的消息

能否实现可以编辑和删除已发送给用户的消息，因为有时候发送错误的信息给用户会非常尴尬，不知道可否实现相关功能。
Is it possible to implement a feature that allows editing or deleting messages that have already been sent to users? Sometimes sending incorrect information can be quite embarrassing, so I was wondering if such functionality could be added. This would help avoid awkward situations and allow for correcting mistakes after the fact.

消息编辑已经实现了。
https://github.com/SideCloudGroup/BetterForward/blob/5ede4efa3a17f5ca70d2e6f9d460d5dc1f581bc4/main.py#L63
删除功能无法实现，TG未提供监听消息删除的接口，并且对于bot删除消息有一定限制。

这样也可以曲线救国。感谢！


Fix nullable BottomSheet animationController issue

Description
Fix cases where animation controller may be null.
Related Issues
Fixes https://github.com/flutter/flutter/issues/70614
Tests
I added the following tests:
This is may be considered as part of NNBD migration (introduced by https://github.com/flutter/flutter/pull/67078) so it does not require tests (let me know if it does require tests).
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.

Hey, I don't have a reproducible test case, but I feel the following crash report I got from a user is relevant to this and might get fixed here? (Using Flutter stable).
Error:

NoSuchMethodError: The getter 'status' was called on null.  It looks like that was the original intent of the code?

@goderbauer  I fear that this may be a breaking change for some user's codebase!

I fear that this may be a breaking change for some user's codebase!

Whether it is breaking or not would be determined by our breaking change policy: https://github.com/flutter/flutter/wiki/Tree-hygiene#1-determine-if-your-change-is-a-breaking-change

I fear that this may be a breaking change for some user's codebase!

Whether it is breaking or not would be determined by our breaking change policy: https://github.com/flutter/flutter/wiki/Tree-hygiene#1-determine-if-your-change-is-a-breaking-change

Just noticed that there are some tests (four to precise) that are failing just by making controller non-nullable. So this is not an option anymore.

Ready for review!

Ready for review!

Just noticed that there are some tests (four to precise) that are failing just by making controller non-nullable. So this is not an option anymore.

Those tests all appear to be inside the framework? Changing those is not a breaking change.

Just noticed that there are some tests (four to precise) that are failing just by making controller non-nullable. So this is not an option anymore.

Those tests all appear to be inside the framework? Changing those is not a breaking change.

@pedromassango it's been a month since last updates from you, can you follow up?

@pedromassango it's been a month since last updates from you, can you follow up?

Thanks for the heads up,  I will work asap (probably on Saturday)

Closing as I don't have plans to get back to this soon.


Add Julia kernel

The PR requirement involved in https://github.com/tweag/jupyterWith/issues/161

waiting for rebasing my latest rev.https://github.com/tweag/jupyterWith/pull/179

DONE for testing:

@guaraqe please review.


Release

Added FileDropArea

:tada: This PR is included in version 6.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Specialize function prototypes

Introduction
The Prototype class represents a function prototype, or signature; that is, its list of parameters and its return type.
Currently this class is not derived and handles all cases that can occur. Its data members are the following.
Type mReturnType;
int mCapacity;
Type *mBegin;
Type *mEnd;
Type mParams[4];

Basically a prototype holds a return type and two pointers indicating the beginning and end of a sequence of parameter types.
The Prototype class is not used much within the library, but every Function holds a prototype. To avoid many dynamic memory allocations, the class also implements a "small-prototypes" optimisation that allows it to store up to 4 parameters without making any additional memory allocation. This number was choosen empirically without much data to support the decision.
The problems
This unique class that is supposed to fit them all is unlikely to be optimal for the variety of cases:

binary operators and conversion functions always have 2 parameters
destructors always have a single parameter (the implicit object type)
default, copy and move constructors have respectively 1 or 2 parameters
other functions can have zero, one or many more parameters

After using libscript for some time in the Yasl project, I was able to gather some data (see commit 4b9a3c6). The current statistics show that functions have on average 1.73 parameters (including the implicit object parameter this). All this means that space is often wasted.
Besides, the Prototype class is designed to allow adding new parameters (it acts roughly as a std::vector) but it is mostly accessed through const &.
After a function has been constructed, its prototype cannot change, and so the capacity field becomes useless.
It would be better if prototypes could implement modification functionnalities only before the Function is created (i.e. in the FunctionBuilder class).
Things to do
1) Redefine Prototype to be a non-owning non-polymorphic class holding only a return type and a begin and end.
2) Introduce derived types that implement actual prototypes, e.g. OperatorPrototype, CastPrototype, ...
3) Experiment with mutable and non-mutable prototypes that would be used respectively during construction and after construction is completed.
4) "Small-prototypes" optimisation are okay, but gathering some more data would be interesting to choose an optimal size for these.

There has been a lot of progress on this issue, starting from commit [8a9176e] to commit [37b3b40].
The Prototype class is now a non-owning class. Parameters are owned by its derived classes like CastPrototype, BinaryOperatorPrototype, etc... The derived classes pass begin and end pointer of the parameter list to their base class.
class Prototype
{
  /* public members */
  /* ... */
  Type mReturnType;
  Type *mBegin;
  Type *mEnd;
};

The FunctionImpl classes have been redesigned to hold the most appropriate prototype.
In the momentum, I used these new prototype classes to considerably improve the FunctionBuilder classes (see commit [805698b] and [6824241]). Each kind of function (e.g. conversion function, constructor, destructor, ...) now has its now builder class ! This means more optimization opportunities (if ever needed) and a more specialized behavior which can help catch errors earlier.
As far as point 3) is concerned, I think it is better to let that aside for some time. There does not seem to be much to gain from that; and it would probably be premature optimization.
I still have to work on the small-prototype optimization. For the sake of simplicity, I removed it completely; but I intend to reintroduce it because I could see a noticeable degradation of performance while running the existing test set.


Saving logic app with invalid parameter indicates save was successful but then indicates Unsaved Changes Will be Discarded upon closing editor

Describe the Bug with repro steps
Create LA with "When an Email Arrives" trigger and set valid parameters for From Address, Subject, etc...
Save LA
Edit LA and try to add invalid value for Start Time
Save LA - System indicates Save was successful.
Close LA - System warns that Unsaved Changes will be Discarded
Edit LA - Confirm that changes were not saved despite prior successful Save message
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using Preview Designer or GA Designer
Preview
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Edge
Additional context
No response

This is in the known issues.


feat: add synth calculations [WEB-924]

Is there a specific reason you are using latestRoundData() instead of just latestAnswer()? The latter seems simpler to me.

Might be good to add a setter for the address of each of the data feeds; chainlink updates these sometimes I believe

Would also be really great if you could write a simple test to prove that this works. Adding a few tokens, checking the price on them, show that correct ones show true and incorrect show false, etc.

Is there a specific reason you are using latestRoundData() instead of just latestAnswer()? The latter seems simpler to me, probably cheaper too.

Looks like it's deprecated from one of the aggregator contracts (I can't find where they are in github):
/**
   * @notice Reads the current answer from aggregator delegated to.
   *
   * @dev #[deprecated] Use latestRoundData instead. This does not error if no
   * answer has been reached, it will simply return 0. Either wait to point to
   * an already answered Aggregator or use the recommended latestRoundData
   * instead which includes better verification information.
   */
  function latestAnswer()

Is there a specific reason you are using latestRoundData() instead of just latestAnswer()? The latter seems simpler to me, probably cheaper too.

Looks like it's deprecated from one of the aggregator contracts (I can't find where they are in github):
/**
   * @notice Reads the current answer from aggregator delegated to.
   *
   * @dev #[deprecated] Use latestRoundData instead. This does not error if no
   * answer has been reached, it will simply return 0. Either wait to point to
   * an already answered Aggregator or use the recommended latestRoundData
   * instead which includes better verification information.
   */
  function latestAnswer()

interesting, good thing you read the contracts! I didn't know this lol

@dudesahn should be ready to review again


Include Service Account File as explicit parameter

Currently, credentials_source can take three possible values

Empty, "", to indicate Application Default Credentials

None, "none", to indicate explicit read-only access.

A path to a Service Account File.

While feeling out full integration using a basic bosh deployment, it became apparent the Service Account File would need to be included as part of the config file as that path may not be valid on whichever hosts end up accessing the blobstore using the configuration.
Proposed: introduce 'service_account_file' to config and convert the arbitrary path option of credentials_source to take 'static' to indicate using the included Service Account File.
This change brings us inline with the semantics of s3cli.

46cf1c8eae93ff176e6f4da512ace0dd68a078ae closes


cannot use backgroundImageFn

I tried to use backgroundImageFn to load the emoji sheet locally
  <emoji-mart *ngIf="toggled" title="" [showPreview]="false"
                                                id="post-emoji-picker" (window:mouseup)="mouseUp($event)"
                                                (emojiClick)="addEmoji($event)"
                                                [backgroundImageFn]="backgroundImageFn"></emoji-mart>

 @Input()
    backgroundImageFn: Emoji['backgroundImageFn'] = (
        set: string,
        sheetSize: number,
    ) =>
        'assets/emoji-picker.png'

but it still load from unpkg.com

:tada: This issue has been resolved in version 0.6.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


I can't download a library from jcenter

I can't download a library from jcenter

so... try again.

thanks for answering, but I still can download, he says "This webpage is not available", and excuse my ignorance but how I can use this library in my project if working offline

for the first problem , maybe your network made some mistake , but the second , you can download it and work offline easily , if you use eclipse , you can add the jar in dependencies , if you use the intellij idea , you can not add dependency in the gradle , but you can also add the jar for dependency.

Thanks again for responding, but where can I download the jar, pq not find I can download the code of the project and I am new at this so the jar is not generated from the code. Excuse the inconvenience and many questions, if you could send me the jar to this email<EMAIL_ADDRESS>

the problem is I'm Cuban and that the internet becomes a bit complicated

Clone the project, build it and then use it.
To be able to use an aar file add this into your gradle:
compile(name: 'the-name-you-give-to-the-library', ext: 'aar')

I'm from IRAN and have similar problem, use VPN or ANTI-FILTER to hide your ip.


Create test.txt

PR template isn’t functioning as expected; will need to cross-check.

Should have merged my updates with the main branch and tested it there. Anyway, it works now!


Support for tifffile.py and for imageio

Hi,
I've added patches for Christoph Gohlke's tifffile.py and for imageio. I added test scripts to the examples directory as there isn't a useful unit test pattern to follow yet. The paths in those files are tied to my system, so they are of dubious value. I included them mainly to demonstrate that I did verify that the patch logging is behaving as expected. Feel free to discard them or come back with suggestions of how you prefer tests to be implemented,
Gary

Hi Gary - sorry for the huge delay in merging this, it kinda got 'lost' in the system, and development had stalled on recipy for a while. However, we're now kicking things off again, and I'm currently at a recipy sprint at PyConUK - and I knew my first task had to be to merge this PR.
Sorry again - and thanks so much for the contribution :-)


Support for making libraries

If this is set as the output library name:
module.exports = {
  output: {
    library: '[name]',
  },

user-bundle.js gets generated like so:
var CarteBlanche [0] =
/******/ (function(modules) { // webpackBootstrap

(which is invalid)

output library

Are you making a library?
I think that's a usecase we haven't accounted for so far, would you mind adding an example to the repo with your webpack config?

@mxstbr example config here: https://github.com/tmc/cb-test

Thanks, taking a look!


Why here didn't use async def❓

https://github.com/channelcat/sanic/blob/master/docs/request_data.md Example

Because it makes no difference regarding what the examples are trying to explain.
The async directive is completely optional, you can add it whenever you want that function to be treated asynchronously or not. It changes nothing on how the request data parameter is treated.

@luizfb  Thanks for your answer🙏
but if don't add async, will affect speed?

@neo1218 and @luizfb  I did test using WRK and I've a few better performance with the async keyword.
Machine:
OS: Fedora25
Intel® Core™ i3 CPU M 370 @ 2.40GHz × 4
3,7 GiB
without async keyword:
➜  ~ wrk -c 100 -d 30  http://<IP_ADDRESS>:8000
Running 30s test @ http://<IP_ADDRESS>:8000
  2 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     5.35ms    2.07ms  30.65ms   76.26%
    Req/Sec     9.43k   656.42    10.64k    72.67%
  563060 requests in 30.04s, 73.03MB read
Requests/sec:  18740.64
Transfer/sec:      2.43MB

With async keyword:
➜  ~ wrk -c 100 -d 30  http://<IP_ADDRESS>:8000
Running 30s test @ http://<IP_ADDRESS>:8000
  2 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     5.05ms    2.12ms  57.27ms   79.70%
    Req/Sec    10.02k   573.57    11.08k    57.50%
  598465 requests in 30.03s, 77.62MB read
Requests/sec:  19931.79
Transfer/sec:      2.59MB

@neo1218 The async keyword is what makes Sanic treat your requests asynchronously, which is where most of the performance benefits from Sanic come from, hence there will logically be a performance difference from using async or not, as evidenced by @viniciusfeitosa 's benchmarks.
You probably want to add async to all your route handlers (the functions you decorate with @app.route) for the performance benefits. If you call those functions from other parts of your code as well, you might want to read up on Python 3's new async/await functionalities and learn where you might need to use an await to maintain synchronicity.


Post syntax is not natural

Hi,
Why the Post does not follow the Put syntax?
var vm = this;
PUT
vm.bookmark.put();
POST
Restangular.all('bookmark').post(vm.bookmark);
Why not use like this:
vm.bookmark.post();
The best would be if the save method was fixed!

The put method is expected to "put" the entire object at the URL. The post method sends data to an endpoint and expects the server to handle putting that data where it needs to.
More simply put (no pun intended), the put method is for updating/replacing/creating a single object at an endpoint, the post, for sending data, which may consequently create/replace something on the server, but nevertheless, it is for a different purpose. More info on the RFC
All this being said, the put method doesn't need to accept any object to send, whereas the post method is expecting an object as the first parameter to send to the server. Does that make sense?


Can the jQuery dependency be removed

So yeah as the tittle says, can it please be removed.

Given that Chosen is a jQuery plug-in, it seems unlikely to be possible to remove the latter...

There is a prototype version available: http://harvesthq.github.io/chosen/index.proto.html

Sorry, It's not possible as Chosen is a jQuery plugin.


Bugfix/IIA-1103: Window shifts and zooms out when resized beyond the left edge limit for Concept, Pattern, LIDR windows

Fixes https://ikmdev.atlassian.net/browse/IIA-1103
Videos of the before and after of this PR have been attached to the Jira ticket.

Looks good to me

Thanks for reviewing Swaroop!
Should I add reviewers to my PRs?


Allow provider to work with git worktrees

Currently it seems the provider does not support git worktrees very well.
I am trying to move to a worktree workflow for my machines to be able to more smoothly work on multiple branches at the same time, it would be nice to have the provider support as many work styles as possible to make the provider more universally useful.
I created some short scripts to illustrate the issue and show differences as it would be difficult for me to know what information is needed..
just run the scripts bash <script file> it will create directories and run terraform and remove the directories after.
This is a basic setup that is probably the most common, and it works fine:
basic-repo.txt
Seperating out the git dir also seems to work fine
seperate-git-dir.txt
Worktrees do not work how ever
worktree.txt

Yeah that's correct and I'm hurting by this myself as well. Unfortunately this restriction is due missing support for worktrees in go-git which is the library used in this provider for git integration. I briefly thought about switching to libgit2 or just shelling out to the users git command in order to improve this but haven't found the motivation to do such a big change yet..

I dont think using the git cli is a good option, I myself am looking into your provider explicitly to get away from any external dependencies outside of the terraform ecosystem.
I am not familiar with the inner workings of your provider at this point, or the library you use, so I can not say for sure, but it does look a little to me like there is some sort of worktree support: https://pkg.go.dev/github.com/go-git/go-git/v5#Worktree

Yeah I'm using that Worktree struct in this provider (e.g. https://github.com/metio/terraform-provider-git/blob/main/internal/provider/git_worktree.go) but that's not the git worktree support that we both want.
100% ack on the getting away from external dependencies part

Although it is not optimal, what about using the library you mentioned libgit2 for new features, and if you wish existing code can be ported over time? There shouldn't be any blockers to using two libraries with overlap in functionality, during a transition stage or even permanently.

Yeah that's https://libgit2.org/ which has a Go bindings at https://github.com/libgit2/git2go
Using two libs should not be an issue, however that git.Worktree struct from go-git is kinda central in this provider so replacing that would probably be most of the work to switch the entire provider to libgit2.
My current workaround for this is to clone each repo twice, once for 'manual' work (coding) that uses multiple worktrees and once again for automated work which does not use multiple worktrees and thus can be used with this provider. It annoys me every time I look at it so I'm definitely interested in finding a solution for this myself. I'm just not sure whether go-git is faster in supporting multiple worktrees or me finding the time/motivation to do something about it in this provider..

I understand the lack of time and motivation, but it does not seem like multiple worktrees is likely to happen anytime soon in go-git: https://github.com/go-git/go-git/issues/41#issuecomment-619360286
I would very much like to help, but I am not a great go coder, and have very limited time myself, it would probably take me a very long time to get to the point where I could start making changes to your code.
Would it be at all feasable to create the multiple worktree support with the new lib and basically start the new architecture without affecting / ripping out the old resources and data sources code?

Yeah I don't think worktree support in go-git is happening anytime soon either, but the same is true for switching to another lib in this provider - it won't happen soon (if at all) so if you need something now you have to look for something else.


ENG-274: Agree GitHub Actions & Workflow implementation best practices

GH actions security

Putting it back into the backlog as more information is needed.


feature: Adding extra_filters to warm_up_cache

SUMMARY
At Airbnb on a nightly basis we warm up recently consumed dashboard slices, which adheres to the default dashboard filters (if applicable). We carried out an analysis which modeled how various factored contributed to the cache hit rate and cache efficiency rate, i.e., what proportion of pre-warmed payloads were actually consumed.
A clear mechanism for increasing the cache hit rate seems to be to warm up dashboard slices with specified filters (and not simply rely on the default) based on event logs (which were fixed in https://github.com/apache/incubator-superset/pull/10197). This PR provides a mechanism for providing the dashboard filters (which materialize as extra_filters in the form-data). If not specified it falls back to using the default dashboard filters which is the current logic.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
CI and added unit tests.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Roadmap: https://github.com/apache-superset/superset-roadmap/issues/74


We don't have the debian client repos

We only have debian AND Ubuntu client tools detection. We need to add for debian without ubuntu there: https://github.com/uyuni-project/sumaform/blob/master/salt/repos/default.sls#L507

Related https://github.com/uyuni-project/sumaform/pull/831

Related https://github.com/uyuni-project/sumaform/pull/831


AuthorizeErrors.UnsupportedResponseType when "Invalid response_mode for flow"?

Question
When we request an authorization for Hybrid flow (response_type=code id_token) and try to use response_mode=query which obviously is not supported by Hybrid flow. We are receiving the message:
error code=unsupported_response_type
Error Description=Invalid response_mode

In our opinion, this message is not clear to understand the problem. In this case, the real problem is query response_mode is not supported for Hybrid flow.
Instead of "unsupported_response_type" for the error code, should be "invalid_request" (based on OAuth2 Authorization error response spec)?
Is it possible to have a better error description message? Example: "Invalid response_mode for flow" or better "Invalid response_mode (query) for Hybrid flow"?
It seems the return statement for error message it's a copy-paste situation.
Minimal working example
The code bellow is found on AuthorizeRequestValidator.cs (line 437)
    // check if response_mode parameter is present and valid
            var responseMode = request.Raw.Get(OidcConstants.AuthorizeRequest.ResponseMode);
            if (responseMode.IsPresent())
            {
                if (Constants.SupportedResponseModes.Contains(responseMode))
                {
                    if (Constants.AllowedResponseModesForGrantType[request.GrantType].Contains(responseMode))
                    {
                        request.ResponseMode = responseMode;
                    }
                    else
                    {
                        LogError("Invalid response_mode for flow", responseMode, request);
                        return Invalid(request, OidcConstants.AuthorizeErrors.UnsupportedResponseType, description: "Invalid response_mode");
                    }
                }
                else
                {
                    LogError("Unsupported response_mode", responseMode, request);
                    return Invalid(request, OidcConstants.AuthorizeErrors.UnsupportedResponseType, description: "Invalid response_mode");
                }
            }

Thanks.
We are discussing this here: https://github.com/IdentityServer/IdentityServer4/pull/4504


A structured patch fails to apply with a JavaScript error

diff v5.0.0
Node v16.13.1
Trying to apply a patch generated by diff.structuredPatch fails with this error:
node_modules\diff\lib\patch\apply.js:151
          delimiter = _hunk.linedelimiters[j];
                                          ^

TypeError: Cannot read properties of undefined (reading '0')

Here's the test script:
var diff = require('diff');
var patch = diff.structuredPatch('path/to/original', '/path/to/file',
                                '1\n2\n3\n4', '1\nx\ny\n4', 'old header', 'new header');
console.log(diff.applyPatch('1\n2\n3\n4', patch));

diff.applyPatch, on the other hand succeeds, so this code runs fine:
var diff = require('diff');
var patch = diff.createTwoFilesPatch('path/to/original', '/path/to/file',
                                '1\n2\n3\n4', '1\nx\ny\n4', 'old header', 'new header');
console.log(diff.applyPatch('1\n2\n3\n4', diff.parsePatch(patch)));

, and yields this output, as expected:
===================================================================
--- path/to/original    old header
+++ /path/to/file       new header
@@ -1,4 +1,4 @@
 1
-2
-3
+x
+y
 4
\ No newline at end of file

1
x
y
4

Looking at the structured patch generated by diff.parsePatch, it's different from the one produced by diff.structuredPatch, which is where the problem seems to be. Here's the former:
[
  {
    oldFileName: 'path/to/original',
    oldHeader: 'old header',
    newFileName: '/path/to/file',
    newHeader: 'new header',
    hunks: [
      {
        oldStart: 1,
        oldLines: 4,
        newStart: 1,
        newLines: 4,
        lines: [Array],
        linedelimiters: [Array]
      }
    ]
  }
]

Here's the latter:
{
  oldFileName: 'path/to/original',
  newFileName: '/path/to/file',
  oldHeader: 'old header',
  newHeader: 'new header',
  hunks: [
    {
      oldStart: 1,
      oldLines: 4,
      newStart: 1,
      newLines: 4,
      lines: [Array]
    }
  ]
}

It's missing linedelimiters in its hunks, which is what the error suggests. I didn't look at the outer object vs. array. I imagine it's fine for multiple patches, though.

I'm hitting this problem in 5.1.0 -- is the PR linked to here already applied?

Fixed by https://github.com/kpdecker/jsdiff/pull/393.


default indicators can now accept custom text

for translation purpose i updated the default indicator pages and also export them to be available in the app

could you update your PR to only include changes to the files necessary?

hi,
i updated the PR

hi,
i updated the PR. can please check it.

This PR requires exporting the default page indicators.
I believe that might be undesirable, as indicated in #36.
#216 might be a better way of solving this.


Insider Cloud Mode (Actions)

Proposed changes
Moved work from #4862 to a new branch so I can make edits
Merge timing
When work in #4862 is complete
Related issues (optional)
Related to #4862

@forstisabella @markzegarelli I just applied the recommended changes from here, can we get this pushed through?


Error trying to init with npx

Since I'm not used to npm and npx I wonder if I am doing something wrong or if there's actually an error. This is what I receive whenever I try to init
D:\Coding\portfolio-notehost>npx notehost@latest init lucasctnh.com
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
file:///C:/Users/lcsco/AppData/Local/npm-cache/_npx/aafa416c13a5a17f/node_modules/notehost/dist/cli/index.js:164
  const runDir = appPath.match(/^(.*)\/[^/]+$/)[1];
                                               ^

TypeError: Cannot read properties of null (reading '1')
    at buildOriginDir (file:///C:/Users/lcsco/AppData/Local/npm-cache/_npx/aafa416c13a5a17f/node_modules/notehost/dist/cli/index.js:164:48)
    at Command.<anonymous> (file:///C:/Users/lcsco/AppData/Local/npm-cache/_npx/aafa416c13a5a17f/node_modules/notehost/dist/cli/index.js:137:23)
    at Generator.next (<anonymous>)
    at file:///C:/Users/lcsco/AppData/Local/npm-cache/_npx/aafa416c13a5a17f/node_modules/notehost/dist/cli/index.js:19:61
    at new Promise (<anonymous>)
    at __async (file:///C:/Users/lcsco/AppData/Local/npm-cache/_npx/aafa416c13a5a17f/node_modules/notehost/dist/cli/index.js:3:10)
    at Command.initRepo (file:///C:/Users/lcsco/AppData/Local/npm-cache/_npx/aafa416c13a5a17f/node_modules/notehost/dist/cli/index.js:135:10)
    at Command.listener [as _actionHandler] (C:\Users\lcsco\AppData\Local\npm-cache\_npx\aafa416c13a5a17f\node_modules\commander\lib\command.js:494:17)
    at C:\Users\lcsco\AppData\Local\npm-cache\_npx\aafa416c13a5a17f\node_modules\commander\lib\command.js:1296:65
    at Command._chainOrCall (C:\Users\lcsco\AppData\Local\npm-cache\_npx\aafa416c13a5a17f\node_modules\commander\lib\command.js:1193:12)

Node.js v18.17.1

Ok, so just to add more information. I checked the code and the problem was that appPath in the buildOriginDir function had a regex match call which wasn't matching the dir path.
By removing the regex I've encountered another problem, the buildOriginDir was returning a wrong path and the code could not find the templates folder. Here's the error:
node:fs:1527
  handleErrorFromBinding(ctx);
  ^

Error: ENOENT: no such file or directory, scandir 'D:\Coding\portfolio-notehost\node_modules\notehost\dist\cli\notehost\templates'
    at Object.readdirSync (node:fs:1527:3)
    at Command.<anonymous> (file:///D:/Coding/portfolio-notehost/node_modules/notehost/dist/cli/index.js:139:27)
    at Generator.next (<anonymous>)
    at fulfilled (file:///D:/Coding/portfolio-notehost/node_modules/notehost/dist/cli/index.js:6:24)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errno: -4058,
  syscall: 'scandir',
  code: 'ENOENT',
  path: 'D:\\Coding\\portfolio-notehost\\node_modules\\notehost\\dist\\cli\\notehost\\templates'
}

Im not sure if this error was caused by me when I removed the regex match, but while I was trying the previous versions such as 1.0.9 and 1.0.8 I've encountered this same error. Adjusting the returning path manually fixed it and I was able to init

I can see the problem. This is an issue with Windows paths, which are not handled correctly by my code.
I've released a new version of notehost: 1.0.17, which should address this. Please run the init command again and lmk if you still experience crashes.
Thanks!


Add dict support for span tags

Add support of dictionary for span tags on tracer level in order to be
compliant with opentracing API.

Fixes #54

Fixes #54


How can I implement gfile?

In python; (url: https://gist.github.com/madhawav/1546a4b99c8313f06c0b2d7d7b4a09e2)
self.detection_graph = tf.Graph()
.
.
.
with self.detection_graph.as_default():
      od_graph_def = tf.GraphDef()
      with tf.gfile.GFile(self.path_to_ckpt, 'rb') as fid:
             serialized_graph = fid.read()
             od_graph_def.ParseFromString(serialized_graph)
             tf.import_graph_def(od_graph_def, name='')

But I cannot find these methods like GraphDef() and .gfile.GFile(self.path_to_ckpt, 'rb') in TensorFlow.Net on csharp?
How can I find out it?

Your code essentially does the following:
using System.IO;
var serialized_graph = File.ReadAllText(self.path_to_ckpt);

Has this resolved your issue?

@Nucs thanks but it gives error being "There is no ParseFromString() method of od_graph_def" for the line od_graph_def.ParseFromString(serialized_graph)

Do we have any updates on this issue because I am also struggling to solve this.

I am facing the same so.


Unable to build from source

Extension version: Latest master
VSCode Version: 1.35.1
OS: Fedora Linux 30

Steps to Reproduce:

yarn
yarn test

[scott@localhost vscode-pull-request-github]$ npm -v
5.6.0
[scott@localhost vscode-pull-request-github]$ node -v
v8.9.4
[scott@localhost vscode-pull-request-github]$ yarn
yarn install v1.16.0
[1/5] Validating package.json...
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Building fresh packages...
$ node ./node_modules/vscode/bin/install
Detected VS Code engine version: ^1.35.0
Found minimal version that qualifies engine range: 1.35.0
Fetching vscode.d.ts from: https://raw.githubusercontent.com/Microsoft/vscode/553cfb2c2205db5f15f3ee8395bbd5cf066d357d/src/vs/vscode.d.ts
vscode.d.ts successfully installed!

Done in 4.59s.
[scott@localhost vscode-pull-request-github]$ yarn test
yarn run v1.16.0
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
$ ./test.sh
Running webpack
[tslint-plugin] Starting linter in separate process...
[tslint-plugin] Linting complete.
Hash: 7472aede563a9201f84ff7a2cdf563c8d8f0b59f
Version: webpack 4.12.0
Child extension:
    Hash: 7472aede563a9201f84f
    Time: 18690ms
    Built at: 2019-06-27 12:24:52
               Asset      Size     Chunks             Chunk Names
        extension.js   2.9 MiB  extension  [emitted]  extension
    extension.js.map  3.22 MiB  extension  [emitted]  extension
    Entrypoint extension = extension.js extension.js.map
    [./src/api/api1.ts] 2.56 KiB {extension} [built]
    [./src/authentication/keychain.ts] 5.33 KiB {extension} [built]
    [./src/authentication/vsConfiguration.ts] 2.01 KiB {extension} [built]
    [./src/common/logger.ts] 1.89 KiB {extension} [built]
    [./src/common/resources.ts] 5.45 KiB {extension} [built]
    [./src/common/telemetry.ts] 7.82 KiB {extension} [built]
    [./src/common/uri.ts] 2.85 KiB {extension} [built]
    [./src/common/utils.ts] 13.8 KiB {extension} [built]
    [./src/extension.ts] 5.29 KiB {extension} [built]
    [./src/gitProviders/api.ts] 989 bytes {extension} [built]
    [./src/github/pullRequestManager.ts] 68.7 KiB {extension} [built]
    [./src/view/fileTypeDecorationProvider.ts] 2.13 KiB {extension} [built]
    [./src/view/prsTreeDataProvider.ts] 7.84 KiB {extension} [built]
    [./src/view/reviewManager.ts] 34.8 KiB {extension} [built]
    [vscode] external "vscode" 42 bytes {extension} [built]
        + 477 hidden modules

    ERROR in /home/scott/src/vscode-pull-request-github/src/github/utils.ts
    ./src/github/utils.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/github/utils.ts(33,6)
          TS2322: Type '{ _rawComment: Comment; commentId: string; body: MarkdownString; selectCommand: Command | undefined; userName: string; userIconPath: Uri | undefined; label: string | undefined; commentReactions: { ...; }[]; }' is not assignable to type 'Comment & { _rawComment: Comment; }'.
      Type '{ _rawComment: Comment; commentId: string; body: MarkdownString; selectCommand: Command | undefined; userName: string; userIconPath: Uri | undefined; label: string | undefined; commentReactions: { ...; }[]; }' is missing the following properties from type 'Comment': mode, author

    ERROR in /home/scott/src/vscode-pull-request-github/src/github/utils.ts
    ./src/github/utils.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/github/utils.ts(54,3)
          TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.
      Type 'readonly Comment[]' is missing the following properties from type 'Comment[]': pop, push, reverse, shift, and 6 more.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts
    ./src/view/reviewDocumentCommentProvider.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts(54,12)
          TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' is not assignable to parameter of type 'CommentThread'.
      Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' but required in type 'CommentThread'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts
    ./src/view/reviewDocumentCommentProvider.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts(539,13)
          TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' is not assignable to parameter of type 'CommentThread'.
      Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' but required in type 'CommentThread'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts
    ./src/view/reviewDocumentCommentProvider.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts(615,13)
          TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' is not assignable to parameter of type 'CommentThread'.
      Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' but required in type 'CommentThread'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts
    ./src/view/reviewDocumentCommentProvider.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/reviewDocumentCommentProvider.ts(922,22)
          TS2551: Property 'splice' does not exist on type 'readonly Comment[]'. Did you mean 'slice'?

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(66,16)
          TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' is not assignable to parameter of type 'CommentThread'.
      Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' but required in type 'CommentThread'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(110,31)
          TS2339: Property 'value' does not exist on type 'string | MarkdownString'.
      Property 'value' does not exist on type 'string'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(110,57)
          TS2339: Property 'value' does not exist on type 'string | MarkdownString'.
      Property 'value' does not exist on type 'string'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(562,85)
          TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(563,47)
          TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(686,20)
          TS2551: Property 'splice' does not exist on type 'readonly Comment[]'. Did you mean 'slice'?

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(687,45)
          TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(711,21)
          TS2551: Property 'splice' does not exist on type 'readonly Comment[]'. Did you mean 'slice'?

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(712,46)
          TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

    ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts
    ./src/view/treeNodes/pullRequestNode.ts
    [tsl] ERROR in /home/scott/src/vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts(853,47)
          TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.
Child webview:
    Hash: f7a2cdf563c8d8f0b59f
    Time: 15002ms
    Built at: 2019-06-27 12:24:49
       Asset      Size  Chunks             Chunk Names
    index.js  5.16 MiB   index  [emitted]  index
    Entrypoint index = index.js
    [./node_modules/css-loader/index.js!./preview-src/index.css] ./node_modules/css-loader!./preview-src/index.css 20 KiB {index} [built]
    [./preview-src/app.tsx] 766 bytes {index} [built]
    [./preview-src/cache.ts] 1.09 KiB {index} [built]
    [./preview-src/comment.tsx] 8.12 KiB {index} [built]
    [./preview-src/context.tsx] 6.68 KiB {index} [built]
    [./preview-src/header.tsx] 4.9 KiB {index} [built]
    [./preview-src/index.css] 1.05 KiB {index} [built]
    [./preview-src/index.ts] 523 bytes {index} [built]
    [./preview-src/merge.tsx] 8.08 KiB {index} [built]
    [./preview-src/message.ts] 1.71 KiB {index} [built]
    [./preview-src/overview.tsx] 1.04 KiB {index} [built]
    [./preview-src/sidebar.tsx] 3.68 KiB {index} [built]
    [./preview-src/timeline.tsx] 6.54 KiB {index} [built]
    [./preview-src/timestamp.tsx] 328 bytes {index} [built]
    [./src/common/timelineEvent.ts] 1.65 KiB {index} [built]
        + 114 hidden modules
Transpiling src/
node_modules/vscode/vscode.d.ts:8956:3 - error TS2300: Duplicate identifier 'Collapsed'.

8956    Collapsed = 0,
        ~~~~~~~~~

  src/typings/vscode.proposed.d.ts:735:3
    735         Collapsed = 0,
                ~~~~~~~~~
    'Collapsed' was also declared here.

node_modules/vscode/vscode.d.ts:8961:3 - error TS2300: Duplicate identifier 'Expanded'.

8961    Expanded = 1
        ~~~~~~~~

  src/typings/vscode.proposed.d.ts:739:3
    739         Expanded = 1
                ~~~~~~~~
    'Expanded' was also declared here.

node_modules/vscode/vscode.d.ts:9003:3 - error TS2687: All declarations of 'collapsibleState' must have identical modifiers.

9003    collapsibleState: CommentThreadCollapsibleState;
        ~~~~~~~~~~~~~~~~

src/github/utils.ts:33:6 - error TS2322: Type '{ _rawComment: Comment; commentId: string; body: MarkdownString; selectCommand: Command | undefined; userName: string; userIconPath: Uri | undefined; label: string | undefined; commentReactions: { ...; }[]; }' is not assignable to type 'Comment & { _rawComment: Comment; }'.
  Type '{ _rawComment: Comment; commentId: string; body: MarkdownString; selectCommand: Command | undefined; userName: string; userIconPath: Uri | undefined; label: string | undefined; commentReactions: { ...; }[]; }' is missing the following properties from type 'Comment': mode, author

33  let vscodeComment: vscode.Comment & { _rawComment: Comment } = {
        ~~~~~~~~~~~~~

src/github/utils.ts:54:3 - error TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

54      thread.comments
        ~~~~~~~~~~~~~~~

src/typings/vscode.proposed.d.ts:735:3 - error TS2300: Duplicate identifier 'Collapsed'.

735     Collapsed = 0,
        ~~~~~~~~~

  node_modules/vscode/vscode.d.ts:8956:3
    8956        Collapsed = 0,
                ~~~~~~~~~
    'Collapsed' was also declared here.

src/typings/vscode.proposed.d.ts:739:3 - error TS2300: Duplicate identifier 'Expanded'.

739     Expanded = 1
        ~~~~~~~~

  node_modules/vscode/vscode.d.ts:8961:3
    8961        Expanded = 1
                ~~~~~~~~
    'Expanded' was also declared here.

src/typings/vscode.proposed.d.ts:770:3 - error TS2717: Subsequent property declarations must have the same type.  Property 'comments' must be of type 'readonly Comment[]', but here has type 'Comment[]'.

770     comments: Comment[];
        ~~~~~~~~

src/typings/vscode.proposed.d.ts:792:3 - error TS2687: All declarations of 'collapsibleState' must have identical modifiers.

792     collapsibleState?: CommentThreadCollapsibleState;
        ~~~~~~~~~~~~~~~~

src/typings/vscode.proposed.d.ts:792:3 - error TS2717: Subsequent property declarations must have the same type.  Property 'collapsibleState' must be of type 'CommentThreadCollapsibleState', but here has type 'CommentThreadCollapsibleState | undefined'.

792     collapsibleState?: CommentThreadCollapsibleState;
        ~~~~~~~~~~~~~~~~

src/typings/vscode.proposed.d.ts:803:3 - error TS2386: Overload signatures must all be optional or required.

803     dispose?(): void;
        ~~~~~~~

src/typings/vscode.proposed.d.ts:818:3 - error TS2717: Subsequent property declarations must have the same type.  Property 'body' must be of type 'string | MarkdownString', but here has type 'MarkdownString'.

818     body: MarkdownString;
        ~~~~

src/view/reviewDocumentCommentProvider.ts:54:12 - error TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' is not assignable to parameter of type 'CommentThread'.
  Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' but required in type 'CommentThread'.

 54     ret.push({
                 ~
 55             threadId: firstComment.id.toString(),
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
 59             collapsibleState
    ~~~~~~~~~~~~~~~~~~~
 60     });
    ~~~

  node_modules/vscode/vscode.d.ts:8986:12
    8986        readonly uri: Uri;
                         ~~~
    'uri' is declared here.

src/view/reviewDocumentCommentProvider.ts:539:13 - error TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' is not assignable to parameter of type 'CommentThread'.
  Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState; }' but required in type 'CommentThread'.

539             ret.push({
                         ~
540                     threadId: firstComment.id.toString(),
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
554                     collapsibleState: collapsibleState
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
555             });
    ~~~~

  node_modules/vscode/vscode.d.ts:8986:12
    8986        readonly uri: Uri;
                         ~~~
    'uri' is declared here.

src/view/reviewDocumentCommentProvider.ts:615:13 - error TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' is not assignable to parameter of type 'CommentThread'.
  Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' but required in type 'CommentThread'.

615             ret.push({
                         ~
616                     threadId: String(firstComment.id),
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
623                     collapsibleState: vscode.CommentThreadCollapsibleState.Expanded
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
624             });
    ~~~~

  node_modules/vscode/vscode.d.ts:8986:12
    8986        readonly uri: Uri;
                         ~~~
    'uri' is declared here.

src/view/reviewDocumentCommentProvider.ts:922:22 - error TS2551: Property 'splice' does not exist on type 'readonly Comment[]'. Did you mean 'slice'?

922                             thread.comments.splice(index, 1);
                                                ~~~~~~

  node_modules/typescript/lib/lib.es5.d.ts:1119:5
    1119     slice(start?: number, end?: number): T[];
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    'slice' is declared here.

src/view/treeNodes/pullRequestNode.ts:66:16 - error TS2345: Argument of type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' is not assignable to parameter of type 'CommentThread'.
  Property 'uri' is missing in type '{ threadId: string; resource: Uri; range: Range; comments: (Comment & { _rawComment: Comment; })[]; collapsibleState: CommentThreadCollapsibleState.Expanded; }' but required in type 'CommentThread'.

 66     threads.push({
                     ~
 67             threadId: firstComment.id.toString(),
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
 71             collapsibleState: vscode.CommentThreadCollapsibleState.Expanded,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 72     });
    ~~~

  node_modules/vscode/vscode.d.ts:8986:12
    8986        readonly uri: Uri;
                         ~~~
    'uri' is declared here.

src/view/treeNodes/pullRequestNode.ts:110:31 - error TS2339: Property 'value' does not exist on type 'string | MarkdownString'.
  Property 'value' does not exist on type 'string'.

110     if (matchingComment[0].body.value !== oldComment.body.value) {
                                    ~~~~~

src/view/treeNodes/pullRequestNode.ts:110:57 - error TS2339: Property 'value' does not exist on type 'string | MarkdownString'.
  Property 'value' does not exist on type 'string'.

110     if (matchingComment[0].body.value !== oldComment.body.value) {
                                                              ~~~~~

src/view/treeNodes/pullRequestNode.ts:562:85 - error TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

562                             if (match.comments.length !== thread.comments.length || commentsEditedInThread(matchingCommentThread[0].comments, thread.comments)) {
                                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/view/treeNodes/pullRequestNode.ts:563:47 - error TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

563                                     this.updateCommentThreadComments(match, thread.comments);
                                                                                ~~~~~~~~~~~~~~~

src/view/treeNodes/pullRequestNode.ts:686:20 - error TS2551: Property 'splice' does not exist on type 'readonly Comment[]'. Did you mean 'slice'?

686             thread.comments.splice(vscodeCommentIndex, 1, vscodeComment);
                                ~~~~~~

  node_modules/typescript/lib/lib.es5.d.ts:1119:5
    1119     slice(start?: number, end?: number): T[];
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    'slice' is declared here.

src/view/treeNodes/pullRequestNode.ts:687:45 - error TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.
  Type 'readonly Comment[]' is missing the following properties from type 'Comment[]': pop, push, reverse, shift, and 6 more.

687             this.updateCommentThreadComments(thread, thread.comments);
                                                         ~~~~~~~~~~~~~~~

src/view/treeNodes/pullRequestNode.ts:711:21 - error TS2551: Property 'splice' does not exist on type 'readonly Comment[]'. Did you mean 'slice'?

711                     thread.comments.splice(index, 1);
                                        ~~~~~~

  node_modules/typescript/lib/lib.es5.d.ts:1119:5
    1119     slice(start?: number, end?: number): T[];
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    'slice' is declared here.

src/view/treeNodes/pullRequestNode.ts:712:46 - error TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

712                     this.updateCommentThreadComments(thread, thread.comments);
                                                                 ~~~~~~~~~~~~~~~

src/view/treeNodes/pullRequestNode.ts:853:47 - error TS2345: Argument of type 'readonly Comment[]' is not assignable to parameter of type 'Comment[]'.

853                             this.updateCommentThreadComments(thread, thread.comments);
                                                                         ~~~~~~~~~~~~~~~

Found 26 errors.

Transpiling preview-src/

Launching test runner
### VS Code Extension Test Run ###

Current working directory: /home/scott/src/vscode-pull-request-github
Downloading VS Code 1.35.1 into .vscode-test/vscode-1.35.1.
Downloading VS Code from: https://update.code.visualstudio.com/1.35.1/linux-x64/stable
Downloaded VS Code 1.35.1
Running extension tests: /home/scott/src/vscode-pull-request-github/.vscode-test/vscode-1.35.1/VSCode-linux-x64/code /home/scott/src/vscode-pull-request-github/out/test --extensionDevelopmentPath=/home/scott/src/vscode-pull-request-github --extensionTestsPath=/home/scott/src/vscode-pull-request-github/out/test --locale=en
[main 2019-06-27T16:25:18.651Z] Running extension tests from the command line is currently only supported if no other instance of Code is running.

[main 2019-06-27T16:25:18.653Z] Error: Running extension tests from the command line is currently only supported if no other instance of Code is running.
    at U.<anonymous> (/home/scott/src/vscode-pull-request-github/.vscode-test/vscode-1.35.1/VSCode-linux-x64/resources/app/out/vs/code/electron-main/main.js:500:716)
    at Generator.next (<anonymous>)
    at s (/home/scott/src/vscode-pull-request-github/.vscode-test/vscode-1.35.1/VSCode-linux-x64/resources/app/out/vs/code/electron-main/main.js:13:221)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Tests exited with code: 1
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[scott@localhost vscode-pull-request-github]$

@sreed101 Sorry! This should be fixed with https://github.com/microsoft/vscode-pull-request-github/commit/e71dd72fbdc2881634bd9347ca2a3f0bb6bc16b2, we previously bumped the engine version of VS Code without fully adopting the new shape of an API.