Documentation about defining routes are invalid

app/routes.js
export default (route, resource) => {
  resource('users');
};

Error when lux s
TypeError: resource is not a function
    at Object.routes (/home/photon/projects/lux-test/app/routes.js:1:37)
    at build (/home/photon/projects/lux-test/node_modules/lux-framework/src/packages/router/definitions/index.js:44:13)
    at new Router (/home/photon/projects/lux-test/node_modules/lux-framework/src/packages/router/index.js:20:25)
    at /home/photon/projects/lux-test/node_modules/lux-framework/src/packages/application/initialize.js:85:18
    at next (native)
    at step (/home/photon/projects/lux-test/node_modules/lux-framework/src/utils/set-type.js:22:3)
    at /home/photon/projects/lux-test/node_modules/lux-framework/src/utils/set-type.js:22:3

This is correct. The place I look when hitting these errors in the example apps. They are in the process of creating better docs for the 1.0 release. I ran into this same issue a few weeks ago.

Thanks for jumping on this @gentle-noah!
@Photon79 we currently have two PRs (#418 & #456) that we're hoping to land in this coming week! Until then, check out this example for a proper routes.js.

Docs about declaring routes is no longer invalid.

@zacharygolba Thanks


removed all unused dependencies issue #150

i removed all the unused dependencies thereby decreasing the size of nodemodules

please add gssoc-ext and level1 label before merge @dhairyagothi

@AyushSharma72 conflicts dont make multiple PR without sync fork this leads to conflicts

@AyushSharma72 conflicts dont make multiple PR without sync fork this leads to conflicts

@dhairyagothi

@AyushSharma72 conflicts dont make multiple PR without sync fork this leads to conflicts

@dhairyagothi

???

@AyushSharma72 conflicts dont make multiple PR without sync fork this leads to conflicts

@dhairyagothi

???

done @dhairyagothi

@AyushSharma72

@AyushSharma72

I will close ths and make another pr for this


Redirect special LBRY urls to pages in App

The Issue
Great idea from @robvsmith :
In order to drive engagement to various areas of the LBRY app, i.e. Discover, Wallet Overview, Publish or Rewards pages, we need an easy way for user to launch the app and navigate to said pages. This can be done via a https://open.lbry.io link such as https://open.lbry.io/?Rewards (don't click, will cause a green screen) which would then open the LBRY app (if closed) and redirect the user to the respective area.
Changes needed to : https://github.com/lbryio/lbry-app/blob/master/src/main/index.js / https://github.com/lbryio/lbry-app/blob/master/src/main/createWindow.js to handle the ? parameter and navigate the user.
List of possible pages:
https://github.com/lbryio/lbry-app/blob/master/src/renderer/component/router/view.jsx#L30
Want to target these:
discover
invite
publish
getcredits
rewards
settings
wallet
subscriptions
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Completed via https://github.com/lbryio/lbry-app/pull/1511


Conversion Failed!

Hi,
Thanks for sharing your amazing work, I tried this on my BBB installation, but sadly the logs don't say according to the plan.
Here is the output of error:

Press [q] to stop, [?] for help
[libx264 @ 0x55e8fbf1a240] using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX FMA3 AVX2 LZCNT BMI2
[libx264 @ 0x55e8fbf1a240] profile High, level 4.0
[libx264 @ 0x55e8fbf1a240] 264 - core 148 r2643 5c65704 - H.264/MPEG-4 AVC codec - Copyleft 2003-2015 - http://www.videolan.org/x264.html - options: cabac=1 ref=3 deblock=1:0:0 analyse=0x3:0x113 me=hex subme=7 psy=1 psy_rd=1.00:0.00 mixed_ref=1 me_range=16 chroma_me=1 trellis=1 8x8dct=1 cqm=0 deadzone=21,11 fast_pskip=1 chroma_qp_offset=-2 threads=6 lookahead_threads=1 sliced_threads=0 nr=0 decimate=1 interlaced=0 bluray_compat=0 constrained_intra=0 bframes=3 b_pyramid=2 b_adapt=1 b_bias=0 direct=1 weightb=1 open_gop=0 weightp=2 keyint=250 keyint_min=25 scenecut=40 intra_refresh=0 rc_lookahead=40 rc=crf mbtree=1 crf=23.0 qcomp=0.60 qpmin=0 qpmax=69 qpstep=4 ip_ratio=1.40 aq=1:1.00
[mp4 @ 0x55e8fbf14f40] track 1: codec frame size is not set
[mp4 @ 0x55e8fbf14f40] opus in MP4 support is experimental, add '-strict -2' if you want to use it.
Could not write header for output file #0 (incorrect codec parameters ?): Experimental feature
Error initializing output stream 0:0 --
Conversion failed!
at Processor.createVideo (/opt/bbb-video-download/modules/processor.js:60:19)
at async process (/opt/bbb-video-download/index.js:26:9)

I, [2020-08-31T22:39:25.244493 #29106]  INFO -- : Create downloadable video for [c7478e38fb4df17285e6684fb7deb158b88601e7-1598899280653] end
I, [2020-08-31T22:39:25.731900 #29440]  INFO -- : Task: Getting meeting metadata
I, [2020-08-31T22:39:25.744377 #29440]  INFO -- : Recording Ready Notify for [c7478e38fb4df17285e6684fb7deb158b88601e7-1598899280653] starts
I, [2020-08-31T22:39:25.744413 #29440]  INFO -- : Recording Ready notify ends

Could you please look into this issue?

Hi @advaitn - thanks for reporting that issue. It helps me to improve my code.
According to this thread at stackoverflow, this issue is related to an outdated ffmpeg version.
In version 1.0.2 I reordered the global and output options, i.e. "-y" is now placed before inputs and added "-strict -2" before the outputfile. This doesn't break my code on newer ffmpeg versions as tested on my machine, but I don't have a machine with your specs to test it with an older version of ffmpeg. Can you verify, if this solves your problem?

Excellent, that solved the issue.
I still have another issue the videos do get exported in the required format but they don't show on the playback page in a similar context.
https://live.grtf.in/playback/presentation/2.0/playback.html?meetingId=c7478e38fb4df17285e6684fb7deb158b88601e7-1598899280653
You can check here.
Thanks!

Your video can be accessed via https://live.grtf.in/presentation/c7478e38fb4df17285e6684fb7deb158b88601e7-1598899280653/video.mp4
I don‘t intend to modify the bbb player.

Oh, it's alright then. I actually referred to your reference :

You can compare it here:
BBB Playback: https://meet.impavit.com/playback/presentation/2.0/playback.html?meetingId=9a9b6536a10b10017f7e849d30a026809852d01f-1598793065462
Video: https://meet.impavit.com/presentation/9a9b6536a10b10017f7e849d30a026809852d01f-1598793065462/video.mp4

Any idea how I can achieve that? 🥇

The video is stored in the presentation folder as video.mp4 - so you can always access it at https://your-server/presentation//video.mp4
I distribute the downloads via our website. You can of course also change the player html code to display a download button.

The video is stored in the presentation folder as video.mp4 - so you can always access it at https://your-server/presentation/%presentationid%/video.mp4
I distribute the downloads via our website. You can of course also change the player html code to display a download button.

Ok great, thanks for the quick reply!


in predicate does not work with dd.read_parquet()

What happened: Reading a partitioned parquet dataset with dask using a filter containing an in predicate raises an exception. Perhaps dask uses syntax for this predicate that is different from how pyarrow/fastparquet work? I was not able to find an example.
Minimal Complete Verifiable Example:
import pandas as pd
import dask.dataframe as dd
df = pd.DataFrame({"A": [1, 2, 3, 4], "B": [1, 1, 2, 2]})
df = dd.from_pandas(df, npartitions=1)

df.to_parquet(
    "dataset",
    partition_on="B",
    write_index=False,
)

dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "in", {"1"})])

The call to dd.read_parquet yields the following traceback:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Input In [84], in <module>
----> 1 dd.read_parquet('dataset', filters=[("B", "in", {"1"})])

File ~/Library/Caches/pypoetry/virtualenvs/project-GfuZs_x0-py3.8/lib/python3.8/site-packages/dask/dataframe/io/parquet/core.py:400, in read_parquet(path, columns, filters, categories, index, storage_options, engine, gather_statistics, ignore_metadata_file, metadata_task_size, split_row_groups, chunksize, aggregate_files, **kwargs)
    397         raise ValueError("read_parquet options require gather_statistics=True")
    398     gather_statistics = True
--> 400 read_metadata_result = engine.read_metadata(
    401     fs,
    402     paths,
    403     categories=categories,
    404     index=index,
    405     gather_statistics=gather_statistics,
    406     filters=filters,
    407     split_row_groups=split_row_groups,
    408     chunksize=chunksize,
    409     aggregate_files=aggregate_files,
    410     ignore_metadata_file=ignore_metadata_file,
    411     metadata_task_size=metadata_task_size,
    412     **kwargs,
    413 )
    415 # In the future, we may want to give the engine the
    416 # option to return a dedicated element for `common_kwargs`.
    417 # However, to avoid breaking the API, we just embed this
    418 # data in the first element of `parts` for now.
    419 # The logic below is inteded to handle backward and forward
    420 # compatibility with a user-defined engine.
    421 meta, statistics, parts, index = read_metadata_result[:4]

File ~/Library/Caches/pypoetry/virtualenvs/project-GfuZs_x0-py3.8/lib/python3.8/site-packages/dask/dataframe/io/parquet/fastparquet.py:881, in FastParquetEngine.read_metadata(cls, fs, paths, categories, index, gather_statistics, filters, split_row_groups, chunksize, aggregate_files, ignore_metadata_file, metadata_task_size, **kwargs)
    878 meta = cls._create_dd_meta(dataset_info)
    880 # Stage 3: Generate parts and stats
--> 881 parts, stats, common_kwargs = cls._construct_collection_plan(dataset_info)
    883 # Cannot allow `None` in columns if the user has specified index=False
    884 index = dataset_info["index"]

File ~/Library/Caches/pypoetry/virtualenvs/project-GfuZs_x0-py3.8/lib/python3.8/site-packages/dask/dataframe/io/parquet/fastparquet.py:666, in FastParquetEngine._construct_collection_plan(cls, dataset_info)
    663         gather_statistics = True
    665 # Determine which columns need statistics.
--> 666 flat_filters = _flatten_filters(filters)
    667 stat_col_indices = {}
    668 for i, name in enumerate(pf.columns):

File ~/Library/Caches/pypoetry/virtualenvs/project-GfuZs_x0-py3.8/lib/python3.8/site-packages/dask/dataframe/io/parquet/utils.py:495, in _flatten_filters(filters)
    492 def _flatten_filters(filters):
    493     """Flatten DNF-formatted filters (list of tuples)"""
    494     return (
--> 495         set(flatten(tuple(flatten(filters, container=list)), container=tuple))
    496         if filters
    497         else []
    498     )

TypeError: unhashable type: 'set'

The same error arises if I instead try
dd.read_parquet("dataset", engine="fastparquet", filters=[("B", "in", ["1"])])

(Except that now the error is TypeError: unhashable type: 'list')
On the other hand, replacing the dask call with

pd.read_parquet('dataset', engine="pyarrow", filters=[("B", "in", {"1"})])

works correctly, i.e., it only loads rows where B = 1. Similarly,

pd.read_parquet('dataset', engine="fastparquet", filters=[("B", "in", ["1"])])

also works correctly.
Environment:

Dask version: 2022.02.0
Python version: 3.8
Operating System: OSX

Specifying the collection as a tuple ("1") fixes the error above (since this is different than both fastparquet and pyarrow conventions, perhaps it should be documented somewhere?).
However, there appears to be a rather subtle bug when the val in a (column, op, val) predicate contains just one item: consider a modification of the original example, but where the partitioning column takes its values in two-digit numbers:
import pandas as pd
import dask.dataframe as dd
df = pd.DataFrame({"A": [1, 2, 3, 4], "B": [10, 10, 20, 20]})
df = dd.from_pandas(df, npartitions=1)

df.to_parquet(
    "dataset",
    partition_on=["B"]
    write_index=False,
)

# Raises TypeError: 'int' object is not iterable
dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "in", (10))])

# Returns an empty dataset, which I would regard as incorrect
dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "in", ("10"))])

# Works correctly
dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "in", ("10", "10"))])

# Works correctly
dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "==", (10))])

Thanks for writing this up @erinov1! I just went looking through the codebase and came to the same conclusion as you that only a tuple is supported. If this is a known and unavoidable limitation (@rjzamora or @martindurant should be able to comment on whether that is the case), then docs and an early error would certainly help. For your second scenario, I think you just need a trailing comma to make sure that you are actually passing a tuple:
# Raises TypeError: 'int' object is not iterable
dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "in", (10,))])

# Returns an empty dataset, which I would regard as incorrect
dd.read_parquet("dataset", engine="pyarrow", filters=[("B", "in", ("10",))])

Otherwise in the first case Python evaluates (10) as an int (non-iterable) and ("10") as a string (iterable but not in the way you were expecting).

Correct, @jsignell . I think this specific syntax was described in full by arrow, although fastparquet originated the general form.

Correct, @jsignell . I think this specific syntax was described in full by arrow, although fastparquet originated the general form.

Ok great! So it would be reasonable to raise if the op is in and the val is not a tuple right?

Yes it would. Well, maybe a list is OK too.

@erinov1 just checking in here-- would you feel comfortable opening up a PR with the above suggestions? Feel free to let us know if you need any help. No pressure either way!

Hi @jsignell @scharlottej13
Apologies for the delay. Yes, I can try to open a PR in the next few days.


Figure out how to make it easier for clients on older versions to leapfrog to latest

Having clients upgrade their installer version is generally a good thing since newer Releases have improved security and functionality. Unfortunately, IMO, the current approach (grab latest release, run Terraform plan, and see what it complains about) is not super professional and should be improved.
Given that this tool is designed to keep most client configuration constrained to the terraform.tfvars and omnibus SSM objects, it shouldn't be too difficult to provide a diff(s) outlining all the necessary changes. We should figure out how to do this in a clean and repeatable way.

Idea: Use the extractor logic used for validation and use it to diff the keys between the client's tfvars file and the latest project variables.tf file.


Make clearing file providers optional.

Closes #18.
Let me know if you'd like any changes.

Thanks for this fix! I'm happy to merge this PR, but would like to ask you if you could maybe add 1-2 lines into the documentation so that possibly other Orchard users will find what they need if they come across this library? Given that I'm not familiar with Orchard I think you could probably better explain this.
Many thanks!

Oh, I got the merge notification, but I don't see myself updating the docs. I will need to do that, I think.

Thanks that's appreciated! Either way, your fix is good and I've merge and released it as part of the .NET 5 upgrade and the latest package.


Stopped unexpectedly: failed to start

Describe the bug
🌲 vmgr | time="08-14 22:26:40" level=error msg="failed to unmount nfs" error="unmount nfs: operation not permitted"
🌲 vmgr | time="08-14 22:26:40" level=fatal msg="panic: new machine: Intel CPUs older than Skylake (6th generation) or newer than Ice Lake (10th generation), the newest CPU ever shipped in an Intel Mac, are not supported"
Check logs for more details.
My configuration:
MacBook Air 2017 (Intel Core I5)
To Reproduce
No response
Expected behavior
No response
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Intel CPUs older than Skylake (6th generation) or newer than Ice Lake (10th generation), the newest CPU ever shipped in an Intel Mac, are not supported


Mibi notebook analysis

Fix production table name (pull from column C of HTAN-Tables-metadata )

Update Open in Colab link to reflect new notebook name

Also per @Gibbsdavidl comment on my notebook, let's comment out
%env GOOGLE_APPLICATION_CREDENTIALS=<path to key>
I guess we can assume that most people will use Colab, so commenting this out will allow downstream cells to run smoothly


add buttons instead of reactions

waiting for release of discord.js v13

after we let #383 settle in, start working on thi


Added description of mode function

📝 Description
mode function description wasn't to be found anywhere in the documentation. I therefore added a small description of it after i inspected it in the source code.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information

@noobinthisgame your call. It could be in the color more section, but then "mode" should become searchable. Not sure how the docs are configured for these things.

@advename If you make a header for the mode section and run yarn search-meta:gen script it will become searchable.

Closing in favour of #677


Make List / Tree Hovers Focusable

With #209642 we added support to trigger the custom hover in lists and tress with the Ctrl K + Ctrl I keybinding. However, it is not possible to set focus into the hover.


MalformedPolicyDocumentException: The new key policy will not allow you to update the key policy in the future.

Description
│ Error: creating KMS Key: MalformedPolicyDocumentException: The new key policy will not allow you to update the key policy in the future.
│
│   with module.ebs_kms_key.aws_kms_key.this[0],
│   on .terraform/modules/ebs_kms_key/main.tf line 8, in resource "aws_kms_key" "this":
│    8: resource "aws_kms_key" "this" {
│

If your request is for a new feature, please use the Feature request template.

[ x] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]: 1.4.0

Terraform version: 1.3.7

Provider version(s):

provider registry.terraform.io/hashicorp/aws v4.53.0
provider registry.terraform.io/hashicorp/cloudinit v2.2.0
provider registry.terraform.io/hashicorp/kubernetes v2.17.0
provider registry.terraform.io/hashicorp/tls v4.0.4

Reproduction Code [Required]
data "aws_caller_identity" "current" {}
module "eks" {
  source                          = "terraform-aws-modules/eks/aws"
  version                         = "19.6.0"

  cluster_name                    = "mgmt-test"
  cluster_version                 = "1.24"
  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = false

  create_kms_key            = true
  cluster_encryption_config = {
    resources        = ["secrets"]
  }
  kms_key_description             = "KMS Secrets encryption for EKS cluster."
  kms_key_enable_default_policy   = true

  eks_managed_node_groups = {
    default = {}
  }
}
module "karpenter_irsa_role" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  version = "~> 5.0"

  role_name_prefix                   = "karpenter_controller"
  attach_karpenter_controller_policy = true

  karpenter_controller_cluster_id         = module.eks.cluster_id
  karpenter_controller_node_iam_role_arns = [module.eks.eks_managed_node_groups["default"].iam_role_arn]

  oidc_providers = {
    main = {
      provider_arn               = module.eks.oidc_provider_arn
      namespace_service_accounts = ["karpenter:karpenter"]
    }
  }
}

module "ebs_csi_irsa" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  version = "~> 5.0"

  role_name_prefix      = "ebs-csi-irsa"
  attach_ebs_csi_policy = true

  oidc_providers = {
    ex = {
      provider_arn               = module.eks.oidc_provider_arn
      namespace_service_accounts = ["kube-system:ebs-csi-controller-sa"]
    }
  }
}
module "ebs_kms_key" {
  source  = "terraform-aws-modules/kms/aws"
  version = "~> 1.1"

  description = "Customer managed key to encrypt EKS managed node group volumes"

  # Policy
  key_administrators = [
    "arn:aws:iam::${data.aws_caller_identity.current.account_id}:root",
    "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/${var.sysadmin_role}",
    data.aws_caller_identity.current.arn
  ]
  key_service_users = [
    # required for the cluster / persistentvolume-controller to create encrypted PVCs
    module.eks.cluster_iam_role_arn,
    # required for Karpenter to manage encrypted volumes for nodes
    module.karpenter_irsa_role.iam_role_arn
  ]

  # Aliases
  aliases = ["eks/${local.name}/ebs"]
}

may I ask why you have opened 4 issues across at least 3 different repositories for what looks like the same issue? The KMS key created by the EKS module is as the variable says https://github.com/terraform-aws-modules/terraform-aws-eks/blob/4b7fe4637a048a52422ee04d6146136f48900695/variables.tf#L138
Its for creating a CMK for cluster secret encryption. It is NOT intended for EC2 EBS volume encryption. In the future, please start with one issue and please provide the details requested in the issue template

@bryantbiggs didn’t open 4 issues. Opened 2 and as noted/referenced wasn’t sure if it was kms policy or the EBS attachment.
the issue ended up being caller identity role arn being an assumed role. The EBS key worked once I stopped adding the current provider IAM role to the document.


Add tests for nodejs-ex repository.

Add tests for nodejs-ex repository.
It tests imported imagestreams against this repo.

[test]


Install-Module is not making module importable on non-Windows systems

Steps to reproduce
Install-Module FIFA2018
Import-Module FIFA2018

Expected behavior
Module is imported into session. This is working fine on Windows machines (both Windows PowerShell or PowerShell Core). It is not working fine on Linux (error in next section).
Actual behavior
Import-Module : The specified module 'FIFA2018' was not loaded because
no valid module file was found in any module directory.

Initial investigation
Root cause for this behaviour seems to be case-sensitive search in Linux.
Module is having name with all capital letters FIFA2018 - both psm1 and psd1. However, it is getting saved to directory that has small letters fifa2018. Thus, Windows finds it, and Linux does not.
For this one module, problem can be resolved by renaming it in PS Gallery (how?).
I am more reporting inconsistency between PowerShellGet and built-in PowerShell commands.  If Install-Module finds module with some name, it should save it with that exact name.
Interesting is that Get-InstalledModule will find it, but Get-Module -ListAvailable will not.
Check against PS Gallery
Aboput 4% of modules in PS Gallery would have similar problems. It is impacting even some high class modules like AzureRM.profile / AzureRM.Profile.

Click to expand Environment data
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.2.1
PSEdition                      Core
GitCommitId                    6.2.1
OS                             Linux 4.15.0-1036-azure #38~16.04.1-Ubuntu SMP Fri Dec 7 03:21:52 UTC 2018
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

> Get-Module -ListAvailable PowerShellGet,PackageManagement
    Directory: /usr/local/share/powershell/Modules

ModuleType Version    Name                                PSEdition ExportedCommands
---------- -------    ----                                --------- ----------------
Script     1.4        PackageManagement                   Desk      {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource…}
Script     2.1.4      PowerShellGet                       Desk      {Find-Command, Find-DSCResource, Find-Module, Find-RoleCapability…}

    Directory: /opt/microsoft/powershell/6/Modules

ModuleType Version    Name                                PSEdition ExportedCommands
---------- -------    ----                                --------- ----------------
Script     1.3.2      PackageManagement                   Desk      {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource…}
Script     2.1.3      PowerShellGet                       Desk      {Find-Command, Find-DSCResource, Find-Module, Find-RoleCapability…}

> Get-PackageProvider -ListAvailable
Get-PackageProvider -ListAvailable

Name                     Version          DynamicOptions
----                     -------          --------------
NuGet                    <IP_ADDRESS>          Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag, Contains, AllowPrereleaseVersions, ConfigFile, SkipValidate
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, InstallUpdate, NoPathUpdate, AllowPrereleaseVersions, Filter, Tag, Includes, DscRes…
PowerShellGet            <IP_ADDRESS>

Looks like a dup of #472. Thanks for the additional details!

Thanks @edyoung. You are right, its duplicate. I searched for similar things, but I could not find it. I will add my details there.

Closing as a duplicate, thanks @iricigor


-getorient test fails because of version display on branch poq_issue_729

-getorient test works by getting the output of the function. On branch poq_issue_729, ouput now includes version information (see below) which causes the integrity test to fail.
SpinalCord Toolbox version 2.2_dev
SCT installed in /Users/sadup/code/spinalcordtoolbox
PYTHON /Users/sadup/miniconda/bin/python /Users/sadup/code/spinalcordtoolbox/bin/osx/miniconda /Users/sadup/code/spinalcordtoolbox
running /Users/sadup/code/spinalcordtoolbox/scripts/sct_image.py -i sct_testing_data/data/t2/t2.nii.gz -getorient
AIL

Proposed solution:

Merge master on branch poq_issue_729
use the function get_orientation() calling nibabel instead of get_orientation_3d() calling the binary
in the test function of sct_imageget orientation by calling the python function instead of a command line OR take the last three characters of the command line output
in the rest of the code: replace all the command line calls to sct_image -getorient by a call to the python function

The tests passes now: I don't know what have changed ... But this is fixed !
I changed get_orient anyway, using nibabel instead of the binary ``ìsct_orientation3d```.


JsonStoreBuilder throws ClassCastExceptions when store is configured with identity serializers

This PR fixes the problem by  base64 decoding the key/value data where identity (byte arrays) are expected.  Works for both key and value serialization
i.e. Store xml defined as
..
 <key-serializer>
    <type>string</type>
 </key-serializer>
 <value-serializer>
    <type>identity</type>
 </value-serializer>
..

Will now succesfully generate stores with input files like:
"key1" "AAE="
"key2" "AAI="

@jalkjaer  I am very confused. You are using identify serializer and using base64 .  In voldemort context identity means input is byte array and serialized to byte array.  Which in turn means no serialization.
Can you please tell us what you are trying to do ? Why is not possible or why is it sub-optimal ? What is your solution ?
If you want to use byte array, you should probably use Avro serialization and have bytes in there. Base 64 encoding is good for HTTP style protocol where binary characters pose a problem. This is very hacky solution and in this current form, I am going to close it. I would encourage you to start a discussion on the groups, so that community can help you.

Let me elaborate:
To populate a ReadOnly store, you normaly run the Hadoop base job. An alternative is to use the cli tool voldemort.store.readonly.JsonStoreBuilder which works locally without all the complexities of haddop. This is convenient for generating test stores as you simply the tool to a text file.
The problem with JsonStoreBuilder is that it cannot generate stores files if the store is defined with the "identity"  key or value serializer.
I'm not ready to change the store definition as that will require changes to all clients that read from the store as the byte content will be altered due to the change in serialization format.

But isn't this still giving different behaviors for Product and test only code ? If you define the same schema in the Hadoop, it is going to end up with different key/value bytes. This is confusing and it does more bad than good in my opinion. If it solves a specific problem for your use case, you can have it in your fork, but I don't see it good enough to be good for the community.
Please correct me if my understanding is incorrect.

Both our prod and test stores are configured with identity value
serialization. Our hadoop output is  sequencefiles of string,
byteswritable. The mapper is then trivial
On Thu, 7 Apr 2016 07:58 ARUNACHALAM THIRUPATHI<EMAIL_ADDRESS>wrote:

But isn't this still giving different behaviors for Product and test only
code ? If you define the same schema in the Hadoop, it is going to end up
with different key/value bytes. This is confusing and it does more bad than
good in my opinion. If it solves a specific problem for your use case, you
can have it in your fork, but I don't see it good enough to be good for the
community.
Please correct me if my understanding is incorrect.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/voldemort/voldemort/pull/397#issuecomment-206707971

@jalkjaer  I am really confused.
JsonStoreBuilder is used only for Tests as you mentioned. I searched the code again and Voldemort except in Rest co-ordinator code path, does not have base64 encoding/decoding.
With the pull request you sent, JsonStoreBuilder will use base64 for encoding/decoding, but prod code path will use some other way. This is inconsistent behavior.
Base64 is used to serialize bytes especially when used with HTTP protocols to work with binary data. But combining Json and base64 is ugly hacking, though it may be easier to use it in shell or some other testing.
Please let me know if something is not clear.

It's unclear to me why you are talking about the rest client and prod code. JsonStoreBuilder is a commandline tool used to create ReadOnly store files from a text input file. E.g. its not part of any "production" call path.
The JsonStoreBuilder in master cannot create store files, if the store definition has
 <value-serializer>
    <type>identity</type>
 </value-serializer>

It fails with an ClassCast exception as described in my previous comments.
The PR changes how the JsonStoreBuilder interprets the input text file when the store definition has <type>identity</type> in either key- or value-serializer. The PR doesn't change how the stores are being generated. Given that JsonStoreBuilder  reads a text file I don't think its a very controversial or hackish to assume Base64 in this case as that is the de facto standard for storing binary content in a text file/stream


stickyHeader for DataTableSkeleton

DataTableSkeleton's styles are a bit too rigid compared to the actual DataTable:

stickyHeader tables aren't supported
The toolbar size is fixed
The batchSelection header look can't be replicated (with the extra header checkbox space)

This is a design request best suited for https://github.com/carbon-design-system/carbon/issues


feat(runWithLocalTime): avoid nesting RelativeSinks

Accumulate RelativeSink offsets to avoid nesting.
I don't like instanceof, but in this case it feels like the right thing.  The alternative would be to require a new method (i.e. analogous to Scheduler's recently-added relative method) on all Sinks, which feels too annoying for people writing custom Sinks.  Alternatively, we could offer a superclass that provides the method, but I dislike coupling people's code to a superclass even more than I dislike instanceof.

However, doesn’t the sink parameter becomes ambiguous?

doesn’t the sink parameter become ambiguous?

I'm not sure what you mean.  Ambiguous in what way?  Could you explain a bit more?

The type of sinks.

@Frikki Here's why I think the type of sink is unambiguous.
I'm viewing Sink as a typeclass/interface (e.g. it's a TS interface in @most/types), of which RelativeSink is one particular implementation, and the type of relativeSink as:
relativeSink :: Sink s => s a -> RelativeSink a

IOW, given any Sink which propagates as, relativeSink returns a RelativeSink that propagates as.  So, at it's interface, relativeSink is well-typed (even though it's implementation does use instanceof to make a runtime type discrimination--see PR description for why I think this is the lesser of all evils).  The sink passed to runWithLocalTime and stream.run has the same type constraint: It can be any Sink a.
Does that make sense?

@briancavalier Indeed, it does. I was looking for the type definition before your last comment but didn’t find it. Everything is dandy and fine.

Cool.  I think you highlighted one of the problems with our having externally facing type definitions, and not (yet) having them internally.  Types are great internal documentation.


Add script to generate release notes

Description
Adds a simple script to collect PR information and generate some basic markdown layout.
Type of PR

[ x ] Bugfix
[ ] Feature implementation
[ ] Refactor of code (without functional changes)
[ ] Documentation improvements
[ ] Test improvements

So good - this saved so much time for the core release notes!
Thanks!


Appstudio update test-component-pac-eqmh

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-component-pac-eqmh-on-pull-request-
creating pipelinerun test-component-pac-eqmh-on-pull-request- in namespace build-e2e-yvli-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-component-pac-eqmh-on-pull-request-
creating pipelinerun test-component-pac-eqmh-on-pull-request- in namespace build-e2e-klbg-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI/test-component-pac-eqmh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
3 minutes
build-container

✅ Succeeded
3 minutes
sast-snyk-check

✅ Succeeded
7 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
inspect-image

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI/test-component-pac-eqmh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
3 minutes
build-container

✅ Succeeded
3 minutes
sast-snyk-check

✅ Succeeded
7 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
inspect-image

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-component-pac-eqmh-on-pull-request-
creating pipelinerun test-component-pac-eqmh-on-pull-request- in namespace build-e2e-klbg-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI/test-component-pac-eqmh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
52 seconds
sast-snyk-check

✅ Succeeded
26 seconds
build-container

✅ Succeeded
27 seconds
deprecated-base-image-check

✅ Succeeded
27 seconds
inspect-image

✅ Succeeded
38 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
7 seconds
clair-scan

✅ Succeeded
31 seconds
label-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
5 seconds
show-sbom


Adds the bind-to-interface helper code

Typical UDP socket would listen on <IP_ADDRESS>:67 and bind to an interface
to limit exposure. This PR implements a helper method to bind and serve
on a socket.
Currently it’s linux only. I left an unimplemented!() trap for BSD with
a note how to progress there and feature-gated the code.

While I can agree that it could fit net2 or similar better, I'd argue that it's widely used for dhcp servers specifically, so all of the users would end up re-implementing it over and over. Given it's feature and platform gated, I think it's still an useful addition.

bump.


Local dataset or model path support

Hi~I would like to use dataset or model locally, but I have not found the way by configuring tasks/model. Is their any way to use model or dataset locally through appropriate settings or will this function be supported?

Referring to some issues mentioned vefore, I have tried passing local model path on --pretrained model args, it works. However, when I tried use the same way on --task args, I failed. Referring to the new task guide doc and https://github.com/EleutherAI/lm-evaluation-harness/issues/547, my command is as follow:
lm_eval --model hf     --model_args pretrained=/home/work/local-model-ds-harness-test/local-model/     --tasks /home/work/local-model-ds-harness-test/local-dataset/local-hellaswag-task/syc-hellaswag2     --device cuda:0     --batch_size 8
The task path is a duplicate of dataset hellaswag, my config file is as follow

Contents under my datadir is hellaswag datasets, I have used load_dataset and save_to_path, the structure is as follow:

Referring to some issues mentioned vefore, I have tried passing local model path on --pretrained model args, it works. However, when I tried use the same way on --task args, I failed. Referring to the new task guide doc and https://github.com/EleutherAI/lm-evaluation-harness/issues/547, my command is as follow:
lm_eval --model hf     --model_args pretrained=/home/work/local-model-ds-harness-test/local-model/     --tasks /home/work/local-model-ds-harness-test/local-dataset/local-hellaswag-task/syc-hellaswag2     --device cuda:0     --batch_size 8
The task path is a duplicate of dataset hellaswag, my config file is as follow

Contents under my datadir is hellaswag datasets, I have used load_dataset and save_to_path, the structure is as follow:

The error is as follow

So, I want to know, is there any way that I could use dataset locally. Is the way I use it wrong? Sincerely appreciation on your help~

Hi! you can simply use --tasks syc-hellaswag2 (the task field) now, after modifying the dataset_path on the task config like you did here. If this config is in another folder other than the default one you can also use --include_path DIR to also look in that directory. Adding --verbosity DEBUG also prints out the intermediate outputs in case of any problems in loading.

Hi! you can simply use --tasks syc-hellaswag2 (the task field) now, after modifying the dataset_path on the task config like you did here. If this config is in another folder other than the default one you can also use --include_path DIR to also look in that directory. Adding --verbosity DEBUG also prints out the intermediate outputs in case of any problems in loading.

It does not work. I have tried to add it in lm_eval/tasks dir, but it told me that ValueError: Tasks not found: syc-hellaswag2. I am sure if I use my dataset name on the huggingface it works, so I think such task is not added successfully after I change dataset_path to local path. The result is as follow,

Internally we use the datasets API by calling datasets.load_dataset (dataset_path, dataset_name etc.). See if it loads through that to narrow down the potential issue. You can also pass in other args using
dataset_kwargs:
  data_files: /path/to/my/json

if needs be.

Internally we use the datasets API by calling datasets.load_dataset (dataset_path, dataset_name etc.). See if it loads through that to narrow down the potential issue. You can also pass in other args using
dataset_kwargs:
  data_files: /path/to/my/json

if needs be.

So I think I should change dataset_path to arrow or json? But The same issue occurs when I add this and change the dataset_path param in the task yaml

I tried:
import datasets
x = datasets.load_dataset("hellaswag")
x.save_to_disk("hellaswag_local/")

y = datasets.load_dataset(path="hellaswag", data_dir="hellaswag_local/")

which saved configs of the train, val, and test in their own sub-folders and loaded it successfully. In the yaml, I just copied the args I used to load the dataset.
dataset_path: hellaswag
dataset_kwargs:
    data_dir: hellaswag_local/

@lintangsutawika did #1127 break our recommendations for local datasets? Looks like there is a conflict here where we search for a dataset loading python script but can't find it, despite an HF datasets - compliant dir at that location.
This isn't a bug per se, as I think we do want to support custom dataset scripts at the moment if a user desires it, but we should make sure to document using save_to_disk() / save_to_path() to run using a saved HF dataset so that this doesn't cause confusion.
Running locally / offline might deserve its own docs subsection / FAQ.

This issue seems to be a different use-case where the local dataset is a downloaded version of the a hf dataset? If there isn't any difference than maybe setting up HF's CACHE_DIR os variable would help locate the data.
#1127 is meant for tasks where users want to supply their own python script (which HF datasets all have to download and prepare the final datafiles)
Otherwise for local data like jsonl or csv.
dataset_path: "json"
dataset_name: null
validation_split: train
dataset_kwargs:
  data_files: /path/to/json

This issue seems to be a different use-case where the local dataset is a downloaded version of the a hf dataset? If there isn't any difference than maybe setting up HF's CACHE_DIR os variable would help locate the data.
#1127 is meant for tasks where users want to supply their own python script (which HF datasets all have to download and prepare the final datafiles)

I have changed the config file, setting the dataset_path to my own duplicate dataset path ycsong-eugene/syc-hellaswag2 and the datadir to my local path, which uses the the same function to save as you mentioned, however, it tells me the error as follow,

but I am sure it is the right place to save the data~

@lintangsutawika did #1127 break our recommendations for local datasets? Looks like there is a conflict here where we search for a dataset loading python script but can't find it, despite an HF datasets - compliant dir at that location.
This isn't a bug per se, as I think we do want to support custom dataset scripts at the moment if a user desires it, but we should make sure to document using save_to_disk() / save_to_path() to run using a saved HF dataset so that this doesn't cause confusion.
Running locally / offline might deserve its own docs subsection / FAQ.

Hi~ thanks for your concern. My aim is supporting local dataset , downloaded from huggingface. So, is it supported right now? I have searched the doc carefully but do not find what I want. Will related doc be supported in the future? I am looking fooking forward to your reply sincerely~

You might need to follow the documentation from datasets
https://huggingface.co/docs/datasets/loading#local-loading-script
dataset_path and dataset_name refer to the args in load_dataset
https://huggingface.co/docs/datasets/v2.15.0/en/package_reference/loading_methods#datasets.load_dataset
If you can make sure that you can load your local dataset using load_dataset that it should also work on lm-eval (this would be a goo way to test it)

Hi~ thanks for your concern. My aim is supporting local dataset , downloaded from huggingface. So, is it supported right now? I have searched the doc carefully but do not find what I want. Will related doc be supported in the future? I am looking fooking forward to your reply sincerely~

We should be able to add this by mid-week next week and document it, if it is indeed a gap in our support!

https://github.com/EleutherAI/lm-evaluation-harness/pull/1127 is meant for tasks where users want to supply their own python script (which HF datasets all have to download and prepare the final datafiles

HF is moving away from this towards parquets/arrow, though it will still be supported.

Hi~ thanks for your concern. My aim is supporting local dataset , downloaded from huggingface. So, is it supported right now? I have searched the doc carefully but do not find what I want.

Ok this is definitely working (with dataset saved with save_to_disk():
dataset_path: arrow
dataset_kwargs:
  data_files:
    train: hellaswag_local/train/data-00000-of-00001.arrow
    validation: hellaswag_local/validation/data-00000-of-00001.arrow

Hi~ thanks for your concern. My aim is supporting local dataset , downloaded from huggingface. So, is it supported right now? I have searched the doc carefully but do not find what I want.

Ok this is definitely working (with dataset saved with save_to_disk():
dataset_path: arrow
dataset_kwargs:
  data_files:
    train: hellaswag_local/train/data-00000-of-00001.arrow
    validation: hellaswag_local/validation/data-00000-of-00001.arrow

Thanks a lot~ I have confirmed this way works~ thank you very much~

Hi~ thanks for your concern. My aim is supporting local dataset , downloaded from huggingface. So, is it supported right now? I have searched the doc carefully but do not find what I want. Will related doc be supported in the future? I am looking fooking forward to your reply sincerely~

We should be able to add this by mid-week next week and document it, if it is indeed a gap in our support!

#1127 is meant for tasks where users want to supply their own python script (which HF datasets all have to download and prepare the final datafiles

HF is moving away from this towards parquets/arrow, though it will still be supported.

Thanks a lot, I will keep paying attention on it and please sync this update here~

Closing in favor of #1233 since we do currently support this, just want to document it more explicitly w.r.t. save_to_disk().


Fix indentation in createIndexHtmlFile()

The method body at https://github.com/ycechungAI/cmd-ssg/blob/main/bin/index.js#L109-L143 needs to be indented one tab stop.

Same issue at https://github.com/ycechungAI/cmd-ssg/blob/main/bin/index.js#L127


Refactor large files

Closes #59
Signed-off-by: thirdsgames<EMAIL_ADDRESS>

Fixes #59

Codecov Report

Merging #68 (0b8c97f) into main (71f8d2d) will increase coverage by 0.05%.
The diff coverage is 41.47%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   65.62%   65.68%   +0.05%
==========================================
  Files          57       65       +8
  Lines        7177     7177
==========================================
+ Hits         4710     4714       +4
+ Misses       2467     2463       -4

Impacted Files
Coverage Δ

src/quill_index/src/lib.rs
100.00% <ø> (ø)

src/quill_index/src/main_index.rs
58.12% <ø> (ø)

src/quill_index/src/type_index.rs
34.37% <ø> (ø)

src/quill_index/src/type_resolve.rs
61.22% <ø> (ø)

src/quill_llvm/src/func/body.rs
84.89% <ø> (ø)

src/quill_llvm/src/func/rvalue.rs
56.91% <ø> (ø)

src/quill_lsp/src/semantic_tokens.rs
0.00% <0.00%> (ø)

src/quill_mir/src/definition.rs
99.06% <ø> (ø)

src/quill_mir/src/lib.rs
100.00% <ø> (ø)

src/quill_mir/src/mir.rs
73.77% <ø> (ø)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f8d2d...0b8c97f. Read the comment docs.


Feature/cvsb 19198

This PR contains the changes for CVSB-18854 https://jira.dvsacloud.uk/browse/CVSB-18854, FE suite refactored due to the implementation of Auth connect

not required anymore


Add copy buttons

Add copy buttons
It would be nice to have buttons next to some / all fields to copy them to clipboard. This already exists for the token. It would especially help with dataset PIDs in order to copy them to a client software.

In the dataset details, there is a copy-button for the pid

True. This was added after I opened the issue but I forgot to close it.


Windows Support (tracking issue)

Opening this as a more general response to @ra0x3's question in #1513.
Current State
Windows support for Sway and its tooling is largely untested.
If you are a Windows user, you are currently recommended to use WSL. That is, at least until we start testing and publishing Windows binaries.
Moving Forward
If we wish to support Windows we should do the following for each of the fuel-core, fuels-rs and sway repos and their crates:

[ ] Check all path handling and that no code makes the assumption we're using unix-style paths. Primary culprits are the use of concatentating strings or using format! to construct paths, e.g.. format!("{}/{}/{}", foo, bar, baz). Windows does not support "foo/bar/baz" style paths. Instead, Path::join or PathBuf::collect should be used.
Another example: until #1213, Sway directly appended the path that you see in dep foo/bar/baz; verbatim, meaning that nested modules could never be successfully compiled on Windows.
[ ] Check that all I/O heavy dependencies are Windows-friendly. Well implemented crates will give compile errors on platforms they don't support, but that's not always the case.
[ ] Add a CI job that at least compiles and runs some basic tests on Windows.
[ ] Update docs w.r.t. any windows-specific needs in regards to system dependencies or setup.

Only once we've addressed these should we consider publishing and distributing Windows native binaries. Otherwise for the most part, Rust and the wider ecosystem makes it easy to write cross-platform code.
Related

#1191.
Old issue #413.

Needs to be broken down into repo-level issues.


chore: run yarn-deduplicate command

TIL about yarn-deduplicate tool, so here is a PR with some yarn.lock cleanup.

Thanks, looks pretty useful. We did some big changes on master now, so there are conflicts. Is this something in yarn itself, or is it a separate project?

@LarsDenBakker rebased and force-pushed.
This is a separate tool by Atlassian, not part of yarn itself. You can run it like this:
npx yarn-deduplicate yarn.lock

Unfortunately it's causes a change in snapshots, we have file hashes in snapshots which is pretty cumbersome. Looking to get red of it.

I ran the tool, did some cleanup and updates the snapshots in https://github.com/open-wc/open-wc/pull/1509
Will close hthis one, Thanks for the tip!


Inner shadow not generating "measures"

When I run the plugin on an object with an inner shadow, and only want the Inner Shadow properties, it doesn't generate the "measures" (properties box).

Thank you so much, Fixed

Glad I could help :smile: :+1:


Fixes #296 by closing the embedded iteration.

This PR addresses GitHub issue: #296
Briefly describe the changes proposed in this PR:

Closes the embedded iteration in handleClose().

Make sure you've followed the Contributor Guidelines. In particular (please tick to indicate you've taken care of it):

[ ] RDF4J code formatting has been applied
[ ] tests are included
[ ] all tests succeed

Signed-off-by: Pavel Mihaylov<EMAIL_ADDRESS>

@avataar are you available to fix the PR with @ansell 's suggestion?

Approved

@avataar thanks for applying the fix, and you're quite right that it should be done everywhere. @ansell is in fact doing this as part of Pull Request #294 - which has turned into a general audit and standardization of the Iteration hierarchy.


New kappa feature for env vars overrides with {}

When deploying now, the env vars that where defined manually gets erased cause of this line https://github.com/garnaat/kappa/blob/develop/kappa/function.py#L58
Code should grab already existent code and merge with the env vars defined on the config kappa.yml file

Will try to get some time later to work on a fix

With fix #107 the code will not set env vars if the part environment_files is not on the config file, BUT once using env vars on the config file, any manual changes will be overriden, the vars are not merged from AWS (this was done on purpose).


Save vis to notebook

Goal:

Way to persist visualizations from profiler into the notebook so can share and repro

Ideally, export as code so that can edit but alternatively can have an import and then access through that

[ ] export vis as code in altair
[ ] If dont like this, then make it accessible through autoprofiler in the notebook like digautoprofile.getvis()


The ui should be more simpler and simpler the fonts should be changed

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Ok


DO NOT MERGE: Handle API tokens

This PR adds the ability to use security schemes requiring headers with API keys.

Coverage increased (+0.05%) to 99.574% when pulling 2aded07aee672c60cce666048b57d7b981eccb1d on handle-api-tokens into 5d82104f06f9bf20b8b470c7a6040f52c0cfc933 on master.

Coverage increased (+0.05%) to 99.576% when pulling c74adf31d027c3057d7e913d5f64e797d982e25a on handle-api-tokens into 5d82104f06f9bf20b8b470c7a6040f52c0cfc933 on master.

Coverage increased (+0.05%) to 99.575% when pulling 6ea1c9095fc808e53f9d9172c9ca7bea7d61b8fc on handle-api-tokens into 5d82104f06f9bf20b8b470c7a6040f52c0cfc933 on master.

Coverage increased (+0.05%) to 99.574% when pulling cf50b7353f3821c1182a8d27b103c149855dc5c6 on handle-api-tokens into 5d82104f06f9bf20b8b470c7a6040f52c0cfc933 on master.


adding battery extension to the prompt returns error

Describe Your Issue
What is happening?
Battery extension not working in prompt.
Most issues are best explained with a screenshot. Please share one if you can!
Have you tried to debug or fix it?
zsh returns this on every line prompt_battery:27: bad math expression: illegal character: ^[
reading the powerlevel9k.zsh-theme and prompt_powerlevel9k_setup file i see that it is this line causing the issue: bat_percent=$(echo $raw_data | grep -o '[0-9]*%' | sed 's/%//')
Environment Information
This information will help us understand your configuration.

What version of ZSH are you using? You can use zsh --version to see this.
zsh 5.6.2 (x86_64-apple-darwin18.0.0)
Do you use a ZSH framework (e.g., Oh-My-ZSH, Antigen)?
Oh-My-ZSH
How did you install P9k (cloning the repo, by tarball, a package from your OS, etc.,)?
Clone from github to ~/.oh-my-zsh/custom/themes/powerlevel9k
What version of P9k are you using?
Latest? Just cloned it today
Which terminal emulator do you use?
Standard macOS one

I just submitted a PR which should hopefully fix this: https://github.com/bhilburn/powerlevel9k/pull/1184


Missing dummy-level instructions for getting started with Python

In the collected BW2 tutorials, all notebooks either completely skip on the very first first steps of installing python, creating environments and installing packages, or they explain it in a way that is not appropriate for a first-time coder. Often, the reader is referred to external sources, but these are often a bit too generic and their broadness can be overwhelming ("...but what do I need?"). To make the training also accessible to first-time coders, it would be desirable to include clear instructions that also connect to requirements in subsequent notebooks (i.e. instructions to connect to relevant channels, installing required packages etc.).

Relink images from imgbb to images folder in repo

I would suggest using this page and giving some attribution to it -- https://pvlib-python.readthedocs.io/en/stable/user_guide/installation.html        the clear question and answer of what to do is very easy to follow, with enough information about the conda jupyter options.

(let me know if you want to assign me this task of moddying it)

The general Brightway setup is now covered on the 'Setup' page of the documentation. The interactive documentation will not require setup.


net: mgmt: Document network events

Add documentation to events that are triggered by the network stack.

Moved this commit to #72992 so closing this PR.


Test Service_Account always false

Test for Filepermissions of Service_Account is always fals for domain-user.

@spitzerr  ..
we see the bug
https://github.com/Esri/arcgis-powershell-dsc/blob/master/Modules/ArcGIS/DSCResources/ArcGIS_Service_Account/ArcGIS_Service_Account.psm1#L371
Where {$_.IdentityReference -ieq "$env:ComputerName$RunAsUserName"}
Feel free to PR a fix :)

Still not fixed. Please see PR #12 for fix

@spitzerr .. apologies for the delay.   @shailesh91 is OOF till next week and the team is busy with EPC/DevSummit prep. work.
We'll review early next week and merge the PR.  Thanks for you issue reports and quick contributions and bug fixes.


Realm package as a dynamic framework

Problem
We have an SDK which depends on Realm and we distribute it as an XCFramework.
When our clients include this xcframework into their projects, they are seeing a lot of logs similar to this one:
(Let's say our SDK name is OurSDK and our client's project is ClientProject)
Class RLMAppConfiguration is implemented in both /.../DerivedData/ClientProject/.../OurSDK.framework/OurSDK (0x112b46fb0) and /.../CoreSimulator/.../ClientProject.app/ClientProject (0x10c9a89a8). One of the two will be used. Which one is undefined.
We understand the reason for this is because Realm is statically linked to both the XCFramework and the Client's project, and having Realm as a dynamic framework would solve the issue.
Also, the app is crashing at some point with the following stacktrace:
*** Terminating app due to uncaught exception 'RLMException', reason: 'null
Exception backtrace:
0   OurSDK                           0x000000010dd74bc2 _ZN5realm15InvalidTableRefC2EPKc + 58
1   OurSDK                           0x000000010dd74a6c _ZNK5realm13ConstTableRef5checkEv + 62
2   OurSDK                           0x000000010dd79511 _ZN5realm9TableView7do_syncEv + 205
3   OurSDK                           0x000000010dc785ea _ZN5realm5Query8find_allERKNS_18DescriptorOrderingE + 246
4   OurSDK                           0x000000010dbbd9f6 _ZN5realm7Results17ensure_up_to_dateENS0_12EvaluateModeE + 476
5   OurSDK                           0x000000010dbbd90c _ZN5realm7Results17ensure_up_to_dateENS0_12EvaluateModeE + 242
6   OurSDK                           0x000000010dbc5094 _ZN5realm7Results24evaluate_query_if_neededEb + 58
7   OurSDK                           0x000000010d9dee64 -[RLMResults countByEnumeratingWithState:objects:count:] + 49
8   libswiftFoundation.dylib            0x00007fff5999eb82 $s10Foundation25NSFastEnumerationIteratorV4nextypSgyF + 258
9   OurSDK                           0x000000010da81abe block_destroy_helper.47 + 4766
10  OurSDK                           0x000000010d6845ef block_destroy_helper + 40159
11  OurSDK                           0x000000010d661d9d __swift_destroy_boxed_opaque_existential_0 + 4173
12  OurSDK                           0x000000010d66130e __swift_destroy_boxed_opaque_existential_0 + 1470
13  OurSDK                           0x000000010d69fa88 __swift_memcpy24_8 + 16712
14  OurSDK                           0x000000010d6c8bb3 block_destroy_helper + 9123
15  OurSDK                           0x000000010d6c7cb7 block_destroy_helper + 5287
16  OurSDK                           0x000000010d6cc7da block_destroy_helper + 810
17  OurSDK                           0x000000010d838005 __swift_memcpy153_8 + 5797
18  OurSDK                           0x000000010d839dce __swift_memcpy153_8 + 13422
19  OurSDK                           0x000000010d839dfb __swift_memcpy153_8 + 13467
20  OurSDK                           0x000000010de8eb66 __swift_memcpy0_1 + 24822
21  OurSDK                           0x000000010de99d3e __swift_memcpy0_1 + 70350
22  OurSDK                           0x000000010de99aa5 __swift_memcpy0_1 + 69685
23  OurSDK                           0x000000010de78ac5 __swift_memcpy40_8 + 127461
24  OurSDK                           0x000000010de99b50 __swift_memcpy0_1 + 69856
25  OurSDK                           0x000000010de72a13 __swift_memcpy40_8 + 102707
26  OurSDK                           0x000000010de28020 block_destroy_helper + 1072
27  OurSDK                           0x000000010de28110 block_destroy_helper + 1312
28  OurSDK                           0x000000010de03fb6 __swift_memcpy16_8 + 310
29  OurSDK                           0x000000010de03a60 __swift_noop_void_return + 2944
30  OurSDK                           0x000000010de6fce0 __swift_memcpy40_8 + 91136
31  OurSDK                           0x000000010d83964c __swift_memcpy153_8 + 11500
32  OurSDK                           0x000000010d838a61 __swift_memcpy153_8 + 8449
33  OurSDK                           0x000000010d83b999 __swift_memcpy153_8 + 20537
34  OurSDK                           0x000000010d858153 block_destroy_helper + 48931
35  OurSDK                           0x000000010d783fe5 __swift_assign_boxed_opaque_existential_1 + 72437
36  OurSDK                           0x000000010d77ea8d __swift_assign_boxed_opaque_existential_1 + 50589
37  OurSDK                           0x000000010d7964a8 block_destroy_helper + 1608
38  OurSDK                           0x000000010d7787d2 __swift_assign_boxed_opaque_existential_1 + 25314
39  CFNetwork                           0x00007fff23e48782 CFNetwork + 30594
40  CFNetwork                           0x00007fff23e63ed8 _CFHTTPMessageSetResponseProxyURL + 16299
41  libdispatch.dylib                   0x000000010b1d1816 _dispatch_call_block_and_release + 12
42  libdispatch.dylib                   0x000000010b1d2a5b _dispatch_client_callout + 8
43  libdispatch.dylib                   0x000000010b1d93bd _dispatch_lane_serial_drain + 855
44  libdispatch.dylib                   0x000000010b1da123 _dispatch_lane_invoke + 490
45  libdispatch.dylib                   0x000000010b1e6601 _dispatch_workloop_worker_thread + 907
46  libsystem_pthread.dylib             0x00007fff701c7074 _pthread_wqthread + 326
47  libsystem_pthread.dylib             0x00007fff701c5ffb start_wqthread + 15'
terminating with uncaught exception of type NSException

Would it be possible to have Realm as a dynamic framework for SPM?
Solution
Probably the solution for this would be to declare two new different products in Package.swift, like:
...
products: [
  .library(
    name: "Realm",
    targets: ["Realm"]),
  .library(
    name: "RealmSwift",
    targets: ["Realm", "RealmSwift"]),
  .library(
    name: "Realm-Dynamic",
    type: .dynamic,
    targets: ["Realm"]),
  .library(
    name: "RealmSwift-Dynamic",
    type: .dynamic,
    targets: ["Realm", "RealmSwift"]
  )
],
...

I'm not sure about dependencies like RealmDatabase probably we would need a "RealmDatabase-Dynamic" as well.
How important is this improvement for you?
Dealbreaker

A XCFramework with a dependency which the consuming app also has as a dependency is a scenario that SPM currently doesn't handle at all. Building the dependency as a dynamic library doesn't fully fix the problem by itself. In the simplest case of the app consuming your xcframework and nothing else, it can work but requires the app to manually ensure that it's always pinning the exact version of Realm your xcframework was built again. In more complicated scenarios (e.g. if they have a second Swift package that relies on Realm), it just can't work.
My recommendation would be to distribute a Realm XCFramework along with your SDK's XCFramework, rather than hoping that the copy of Realm built as part of the app will be ABI-compatible with the one your SDK was built against.

Thanks for your answer @tgoyne!
The problem is that the consuming app does not have this dependency itself, only our xcframework has it.
In fact, I'm reproducing this with an empty project which only has our sdk as dependency.
For some reason it looks like the dependencies from xcframework are installed twice.

Hello again, we are reproducing this crash on any app that has our SDK (XCFramework) integrated via SPM. The weird thing is that this is only happening on simulators, but not on physical devices.
If we install the SDK through CocoaPods, we also receive a crash but with a different error:
Could not cast value of type '__C.RealmSwiftObject.Type' (0x10771ca88) to '__C.RLMObjectBase.Type' (0x10771d318).

Does anybody have any clue how can we get around these crashes? This is completely blocking our SDK clients.

Hi @rserentill let me first try to understand your setup so we can reproduce it, you have RealmSwift through SPM as a dependency in your framework, and then you want to distribute it as a xcframework?.

Hello @dianaafanador3, thank for answering!
Yes, that's correct. Let me clarify that our SDK is not an Xcode project, it's a Swift Package. This swift package has RealmSwift as a dependency.
When we need to publish a new SDK version, we archive this swift package for both device and simulator architectures, and we generate an XCFramework with these two archives.
Also, as a workaround to work with dependencies, we have a wrapper target, as suggested in this swift forum thread: https://forums.swift.org/t/issue-with-third-party-dependencies-inside-a-xcframework-through-spm/41977/2
We are also using @_implementationOnly import RealmSwift in all of our files using Realm.

@rserentill In your comment above I saw you have an empty project with a reproduction of the issue, can you push this a repository?.

@dianaafanador3 is there any way I can share it with you privately? the SDK consumes protected data and it uses client credentials to authenticate to our backend services.

@dianaafanador3 I see I forgot to mention that the crash is only happening when we include the SDK as an XCFramework. If we add the swift package directly, without a binary, it doesn't crash.

@rserentill  you can send it to<EMAIL_ADDRESS>

@dianaafanador3 I have just sent the project to the email address you provided 😊

Hi @rserentill I can run the app and go to the view in question without any crashes when using Xcode 14 on an iPhone 14 simulator.

Hello @leemaguire, thank you for your answer! That's weird.. We can reproduce the crash 100% of the times with this project. In both Xcode 13 and 14. We have also tried with both Intel and M1 chips, same result.
So you open the project, click on the red button and you can read the magazine's content without a crash?

@rserentill yep I tap 'Open Magazine' and it shows me content.

@leemaguire Do you have Intel or Apple chip? Just trying to figure out what's different, although we've been able to reproduce it in both.
Could you please try to reset SPM cache?
This only happens to us if we use the xcframework binary, but it doesn't happen using the package with the source code in it. Maybe you have realm-core project locally and somehow Xcode is recognising it?

I have the Apple chip. I checked the SPM checkouts and its not referencing any local versions of Realm Core. I also just checked it with Xcode 13.4.1 and it runs fine there too.

And your'e testing it on Simulator, right?

Hi all,
any update on this front?
Class RLMAppConfiguration is implemented in both /.../DerivedData/ClientProject/.../OurSDK.framework/OurSDK (0x112b46fb0) and /.../CoreSimulator/.../ClientProject.app/ClientProject (0x10c9a89a8). One of the two will be used. Which one is undefined.

I have exactly this  flow:
- RealmSwift through SPM as a dependency in a framework,
- and then I want to distribute it as a xcframework.


pull request for e2e test at 11/17/2016 22:26:04

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fullscreen scrolls browser to top in Firefox 11

If you make a video full screen in in Firefox 11 and then close fullscreen mode the browser scrolls to the top of the page - is there any way of stopping this?

@benjamincoleman Can you provide a URL that shows this issue, please?

@benjamincoleman Closing old issues. If you'd like to reopen this, let us know. Thanks!


Fix Remote code execution in simple-git()

Summary
Affected versions of this package are vulnerable to Remote Code Execution (RCE) via the clone(), pull(), push() and listRemote() methods, due to improper input sanitization. This vulnerability exists due to an incomplete fix of CVE-2022-25912.
const simpleGit = require('simple-git'); let git = simpleGit(); git.clone('-u touch /tmp/pwn', 'file:///tmp/zero12'); git.pull('--upload-pack=touch /tmp/pwn0', 'master'); git.push('--receive-pack=touch /tmp/pwn1', 'master'); git.listRemote(['--upload-pack=touch /tmp/pwn2', 'main']);

CVE-2022-25860
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Checklist
Please add a x inside each checkbox:

[x] I have read the contribution guidelines.
[x] Code is formatted via running yarn format.
[x] Tests are passing via running yarn test.
[ ] The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)

Dependencies will be updated as part of another PR.


non-standard codepoint for “Santa Claus (Father Christmas)” and “Mrs. Claus”

I noticed that the codepoints for the emoji “Santa Claus (Father Christmas)” and “Mrs. Claus” used in Twemoji differ from the standard published at https://unicode.org/Public/emoji/13.1/emoji-test.txt :
In Twemoji, the filenames are:

Santa: 1f468-200d-1f384 (“man, zwj, christmas tree”)
Mrs Claus : 1f469-200d-1f384 (“woman, zwj, christmas tree”)

But on the Unicode document they are listed as:

1F385             ; fully-qualified     # 🎅 E0.6 Santa Claus
1F936             ; fully-qualified     # 🤶 E3.0 Mrs. Claus
1F9D1 200D 1F384  ; fully-qualified     # 🧑🎄 E13.0 mx claus

Is there a reason for this difference?
(both 1F385 and 1F936 are recognized by twemoji.min.js)

@xDEADC0DE both (1f468-200d-1f384|1f469-200d-1f384).(svg|png) and (1f385|1f936).(svg|png) are available as filenames in Twemoji (example: 1f385.png). While the latter isn't fully-qualified, its existence helps us avoid special-casing certain emoji as the standard evolves towards the gender-inclusive pattern of (person|man|woman)-zwj-object.
I'm going to close this out for now since given the info in this thread, we don't plan to change this right now — but if this is somehow causing problems in a project you're trying to integrate Twemoji into, feel free to reopen with a comment with more info.

Thank you for your answer, it doesn’t cause any issues I was just a bit surprised :)


chore: remove swapperV1

Description

Removes all traces of swapperV1
Updates the Approval and TradeConfirm components to use functionality only from swapperV2
Removes the swapperV2 feature flag

Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
Closes https://github.com/shapeshift/web/issues/3080.
Risk
Some risk associated with the handling changes made to the Approval and TradeConfirm components, but mostly the logic was just moved into swapperV2 were applicable, with slight refactors for cleaner code.
Testing
Everything related to the swapper should work as it did before.
There is a small risk related to trade approvals, and the data shown on the trade confirm screen, so they should be sanity checked.
Engineering
☝
Operations
☝
Screenshots (if applicable)
N/A

@gomesalexandre that approval bug you found was a good one.
I'm not sure how long it's been there for, but it occurred whenever you did an approval and did not have any existing quotes "in memory".
It also meant we were potentially executing stale quotes 😬
See https://github.com/shapeshift/web/pull/3084/commits/de6755ebec4310d8f1fe2c7af77fc05eb703e3f0 for the simple, derpy fix.


beets: fix pygobject issues

Description of changes
Fixes: https://github.com/NixOS/nixpkgs/issues/184175
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Would it make sense to add a test in this PR so this will not break again?

I added a simple test, using beets with the problematic configuration.


Identifying search logic in Kibana data

We think that
More advanced researchers (Knowledge Gatherers) have distinct search habits that can be used to identify them.
Therefore we hypothesise that
If we look at search behaviour for longer sessions, we will see methodical changes in search terms as measured by variations in search terms or the addition of terms or use of terms appearing in works surfaced; pauses indicating use of other sites.
We are right if
If we see similar behaviour for more than 10 users.

@taceybadgerbrook This sounds like a super interesting set of data to get.
What might help is if we could get what you might expect the data to look like, and we can probably start doing some data transforms to get it as querying the current index would definitely not be good enough.
We can pair on that to so you know what functionality is available which might help inspire new ways of wanting the data.

Initially, I would look at sessions on a given day to produce the following:-

histogram of the number of searches conducted before a search result is selected
histogram of max page depth
histogram of session length

All of these appear to be possible using data from search_result_implicit in Python - but please shout if the data is not what it seems!


helm init --wait doesn't appear to work with TLS

When I run:
helm init \
    --wait \
    --tiller-tls \
    --tiller-tls-cert ${tmp}/tiller.cert.pem \
    --tiller-tls-key ${tmp}/tiller.key.pem \
    --tls-ca-cert ${HELMHOME}/ca.pem \
    --tiller-tls-verify \
    --service-account=tiller

I get the following error:

Error: could not ping Tiller: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs

Output of helm version:
Client: &version.Version{SemVer:"v2.9.0", GitCommit:"f6025bb9ee7daf9fee0026541c90a6f557a3e0bc", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.2", GitCommit:"5fa2db2bd46ac79e5e00a4e6ed24191080aa463b", GitTreeState:"clean", BuildDate:"2018-01-18T10:09:24Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8+", GitVersion:"v1.8.8-gke.0", GitCommit:"6e5b33a290a99c067003632e0fd6be0ead48b233", GitTreeState:"clean", BuildDate:"2018-02-16T18:26:58Z", GoVersion:"go1.8.3b4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
GKE

I'm getting the same error with helm v2.9.1. I followed the steps described here: https://docs.helm.sh/using_helm/#using-ssl-between-helm-and-tiller to setup TLS cert verification.

We ran into this issue, as well. It seems to be a problem with the section of code that gets executed when --wait is used: https://github.com/kubernetes/helm/blob/aa98e7e3dd2356bce72e8e367e8c87e8085c692b/cmd/helm/init.go#L343.
As a workaround, you can run kubectl rollout status -n kube-system deploy tiller-deploy -w to wait on the deployment of tiller before proceeding.

good catch @stevvooe. We probably just need to propagate those flags to the helm client when we initiate the connection.


AfterNodeExport but no BeforeNodeExport?

I'm trying to figure out the best way to customize the export for Open Brush.
Our problem is that the runtime scene graph isn't neccesarily the same structure we want to export. In fact we probably want to configure the export somewhat.
At runtime the user's sketch is divided into layers (like Photoshop layers). Inside a layer there is a "batch" for each type of brush which is a single mesh. When a batch exceeds the Unity vertex limit, a new one is started.
There is also the concept of "groups" which are a convenient way to group stokes within a layer from the user's perspective. These don't exist in the Unity hierarchy.
So - I think our best approach is to run through a regular export to generate all the node that aren't brush stroke (imported models, images etc) but catch all the brush stroke nodes in a separate data structure and then on AfterSceneExport go through and generate nodes for groups and/or strokes (probably user configurable).
We also transform the vertex layout at this point. We ditch some of the uv channels that are for runtime use and optionally add some data that can be useful for exported meshes (for example timestamps so that the drawing of strokes can be animated).
So ideally I'd like a BeforeNodeExport that allowed me to either skip the node creation entirely (but record the parent for later use) or to skip the mesh creation.

@hybridherbst - any thoughts on this?

Ah. Seems to be resolved recently by a new commit to #644 - I had assumed the big merge was already complete on the dev branch. Seems not!

Sorry for the delay!
The Big Merge comes any week now hopefully 😶🌫

Is there a forum or something to keep track of plans? There's not a lot of discussion happening directly on Github and it would be helpful to follow along with whatever discussions are going on.


Port crc to MATLAB

The port needs Sable/wu-wei-benchmarking-toolkit#12 done because the runner expects multiple arguments.

@elavoie Do we need to leave a script to run the runner?  Because a runner may take several arguments, a script for runner may make the program clear, like runCRC.


feat(date-range-input): added new props onClose

Добавлен новый пропс onClose - обработчик закрытия календаря в мобильной версии

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 80.644%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/date-range-input/src/components/date-range-input/Component.tsx
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

packages/date-range-input/src/components/date-range-input/Component.tsx
1
73.93%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
7316

Relevant Lines:
8268

💛  - Coveralls

Тут конфликты появились


Reintroduce action type constraint

Motivation and Context
Revert the last liquibase change as it's broken preprod
What has changed

How to test?

Links

/deploy baileyw

/deploy baileyw


Improve testing infrastructure

I added a Project.toml for the tests, made CompatHelper track it, added doctests to CI, and introduced modules for tests to avoid cluttering the namespace.

Can you "modularize" the new deprecations.jl tests too? Might have to rebase onto master.
And bump the version number?

Can you "modularize" the new deprecations.jl tests too? Might have to rebase onto master.
And bump the version number?

 And we are dropping (test-) compatibility with Julia <1.2.

@haampie Good to merge?

Yes. @mschauer I would be happy with only supporting julia 1.5.3+ because it has 5-arg mul, which is useful in some solvers.


Is there an implementation for HGet?

I use HSet to set my values and not I want to recieve them, but there doesn't appear to be a HGet?

hget is absolutely included in the module.
 client.hget(key,field,callback);
I'm am curious where you got the idea that the module doesn't implement hget but I'm going to go ahead and close this.

There is simply no documentation about it.

Second sentence of the readme (emphasis added):

It supports all Redis commands and focuses on high performance.

But, yeah, I do get it on some level. Documentation on other modules is often explicit about what is supported and what is not.


add some new functions in the fact-checker bot

Hello!
This is another attempt to improve the GH bots. I've added new features to the fact-checker bot. Now it:

checks for duplicate articles in the crypto wiki (based on target entity and date).
verifies if all headers are correctly specified (Summary, etc.).
evaluates the text style and readability using the Flesch Reading Ease metric.
Example here.

P.S.: My PyCharm automatically updated the poetry.lock file, and I noticed that some package versions were updated in it. I'm ready to manually roll back these changes.
I would appreciate your feedback. My first appearance here

I would rather close this pull request and split the work into one feature per PR. It's hard to review and test big chunks of code that do multiple things at the same time.

I think there's a confusion about the "readability" thing. Original challenge referenced readability project by Mozilla that allows to extract article content from a page. That could come handy for any fact-checker that goes beyond search engine result snippets and actually tries to crawl the links from the search results. It has nothing to do with making the wiki articles more "readable".
Things have changed since we first implemented the quality checks, and now most of the functionality is covered by GPT-like services. It should be possible to refactor existing quality checks to fit the whole PR (instead of splitting it into chunks) into one API request. Anything that goes beyond LLM's context window, can safely be cut out and produce a warning with advice to submit smaller PRs. Although OpenAI API still lacks web browsing functionality, there are alternative solutions offered by Goggle or Azure. Reach out if you need test API keys.

To summarize what we need moved directly to a single GPT prompt:

Fact-checking. Azure OpenAI Service and reverse-engineered Bard libraries have that functionality, but there are plenty of alternative solutions.
Spellcheck can safely be moved to GPT with a carefully crafted prompt.
Hugo SSG formatting checker. The fact that an article is a Markdown document with headers for Hugo SSG would probably need to be specified in the prompt anyway for adding the spellcheck functionality. Asking the LLM to check formatting should be an easy addition.
Existing articles check. Getting the directory listing is the easiest way to do it, and you already implemented it.
Article submission guidelines checks. A good idea might be adding a markdown file with guidelines to load guidelines from there instead of hard-coding them in the prompt. This will adhere to single source of truth best practices and make the maintenance of those guidelines much easier.
Plagiarism. Probably requires additional testing of existing LLM services, but there's nothing fundamental that would prevent models with internet access to spot copy-paste work.

I also updated the original issue to add these clarifications and remove functionality that is hard to implement in a single GPT prompt.


Lost code while running gulp serve

After adding code as specified getting the error, but not while compiling, after running "gulp serve" pasted code is gone, and .ts change state to initial.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0ecfb7b-2d99-1835-1688-8fbb904fcc8c
Version Independent ID: 9001961c-5199-76ca-c3a7-b3d69b49e20d
Content: Use page placeholders from Application Customizer (Hello World part 2)
Content Source: docs/spfx/extensions/get-started/using-page-placeholder-with-extensions.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Where did you add the code? The command gulp serve does not delete anything. The only command that deletes stuff is gulp clean and that only deletes temp files you should not be edited directly in lib, dist & temp.

in src\extensions\helloWorld\HelloWorldApplicationCustomizer.ts file and saved it, when ever i run the "gulp serve" code get removed and came back to initial state of file.

That should not happen. Can you record a screencast and post it somewhere reproducing this?

Sure i can do that.

I have attached the images can't make a video, restrictions

It looks like your making changes to the TypeScript Declaration file, “HelloWorldApplicationCustomizer.d.ts”, which is generated for you.
You should be editing just the non declaration file, “HelloWorldApplicationCustomizer.ts”.
If you make changes to that and then perform a gulp Serve, do you retain and see your changes? :)


feature request: onClick event with option to close the message box

I'm submitting a ...
[ ] bug report
[X] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
feature

What is the current behavior?
On hover on the message box there is pointer cursor, but after click nothing is happening.

What is the expected behavior?
I would like to have onClick event and would like to close the message box on message click.
It also would be cool to create custom template to override default one.

What is the motivation / use case for changing the behavior?
Close button is small and on mobile devices would be easier to use it. It would be also more flexible when onClick event could be served.

Yeah,
like this one http://codeseven.github.io/toastr/demo.html

Hi, i was having same problem.
I have implemented the onClick and created a pull request .


How to specify treesitter highlight groups?

:h treesitter-highlight-groups describes highlight groups such as @comment @comment.lua.
Lua doesn't allow symbols like @ and . in names, so you can't do:
local lush = require('lush')
return lush(function()
	return {
		@comment { },
		@comment.lua { },
	}
end)

For @comment the workaround is using the default link TSComment or Comment instead, but I can't work out if there's a similar workaround for language specific groups.

#107

See https://github.com/rktjmp/lush.nvim/issues/109 for fix.


report mixs package/term association counts from sheets-for-nmdc-submission-schema

https://docs.google.com/spreadsheets/d/1cMlPKgjZh-v21aMYCm9x1TxzE5BwGQptBQcvuaYAtC8/edit#gid=1742830620

@turbomam can you expand on what this issue is trying to address?


Sixth Korean l10n work for release 1.17

Link modify to new docs added from previous branch. (#19374)
Localize email address placeholder (ko) (#19407)
Translate storage/volume-snapshot-classes.md in Korean. (#19371)
Translate concepts/security/overview.md in Korean (#19464)
Translate storage/volume-pvc-datasource.md in Korean. (#19370)
Translate controllers/jobs-run-to-completion.md in Korean. (#19369)

Co-authored-by: Ian Y. Choi<EMAIL_ADDRESS>Co-authored-by: Jesang Myung<EMAIL_ADDRESS>Co-authored-by: Seokho Son<EMAIL_ADDRESS>Co-authored-by: Yuk, Yongsu<EMAIL_ADDRESS>Co-authored-by: Ryan<EMAIL_ADDRESS>Co-authored-by: Tim Bannister<EMAIL_ADDRESS>

I'v checked the preview and it looks good.
Thank you @gochist !
/lgtm
/approve

Hello, @zacharysarah :)
This PR is to merge 6th 1.17 Korean l10n work branch for release into Master branch.
Since this PR includes a commit to change a file (i18n/ko.toml file) which requires an approve from sig-docs-en-owners, I cannot approve this PR.
@gochist (Korean team leader) has authority to approve this PR since he is in the sig-docs-en-owners.
However, since @gochist opened this PR, an approval from another sig-docs-en-owner seems appropriate :)

@seokho-son 👋🏻 Thanks for the helpful explanation!
/lgtm
/approve

@seokho-son FYI, I'm not in the sig-docs-en-owners now by #19600.


Update arangodb-java-driver to 7.8.0

About this PR
📦 Updates com.arangodb:arangodb-java-driver from 7.5.1 to 7.8.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.arangodb", artifactId = "arangodb-java-driver" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.arangodb", artifactId = "arangodb-java-driver" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #309.


Schedule is in wrong status after game restart (bug)

Hey there!
I have started a schedule and closed the game. After starting the game again my VPet was in idle but when i wanted to start my schedule again, the button got "Stop Schedule" label.
This is wrong because the Schedule was not active at this point.
Screenshot after game restart while schedule was started:

In fact, it is already on the schedule. By default, every time it is launched, it will determine whether it is on the schedule based on the last enabled state.
Your current schedule is on break, so it doesn't seem to have started yet.


⚠ File access (beta) has degraded performance

In 866b69f, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 3527 ms

Resolved: File access (beta) performance has improved in 35c4033.


[build] only enable ecdsa when OpenThread configures

ECDSA is already enabled in
https://github.com/openthread/openthread/blob/master/third_party/mbedtls/mbedtls-config.h#L137

It may break compilation under Keil. I'll check it.


[test_id:1754]should create a virtual machine with sriov interface  - SRIOV VirtualMachineInstance with sriov plugin interface

/kind bug
/triage build-officer
What happened:
[test_id:1754]should create a virtual machine with sriov interface
What you expected to happen:
 SRIOV
/root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:568
  VirtualMachineInstance with sriov plugin interface
  /root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:623
    [test_id:1754]should create a virtual machine with sriov interface [It]
    /root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:695
    Unexpected error:
        <*errors.StatusError | 0xc0023dedc0>: {
            ErrStatus: {
                TypeMeta: {Kind: "", APIVersion: ""},
                ListMeta: {
                    SelfLink: "",
                    ResourceVersion: "",
                    Continue: "",
                    RemainingItemCount: nil,
                },
                Status: "Failure",
                Message: "Internal error occurred: failed calling webhook \"virtualmachineinstances-create-validator.kubevirt.io\": Post https://virt-api.kubevirt.svc:443/virtualmachineinstances-validate-create?timeout=30s: context deadline exceeded (Client.Timeout exceeded while awaiting headers)",
                Reason: "InternalError",
                Details: {
                    Name: "",
                    Group: "",
                    Kind: "",
                    UID: "",
                    Causes: [
                        {
                            Type: "",
                            Message: "failed calling webhook \"virtualmachineinstances-create-validator.kubevirt.io\": Post https://virt-api.kubevirt.svc:443/virtualmachineinstances-validate-create?timeout=30s: context deadline exceeded (Client.Timeout exceeded while awaiting headers)",
                            Field: "",
                        },
                    ],
                    RetryAfterSeconds: 0,
                },
                Code: 500,
            },
        }
        Internal error occurred: failed calling webhook "virtualmachineinstances-create-validator.kubevirt.io": Post https://virt-api.kubevirt.svc:443/virtualmachineinstances-validate-create?timeout=30s: context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    occurred

Prow job log
Lane:
pull-kubevirt-e2e-kind-1.17-sriov

@phoracek
@ormergi
https://github.com/kubevirt/kubevirt/issues/3485#issuecomment-636304852
Maybe this comment is interesting ?

again:
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/2935/pull-kubevirt-e2e-kind-1.17-sriov/1280469208785752065

/remove-lifecycle rotten

/remove-lifecycle rotten

can you please paste the error ?
is it the webhook (as the issue first thread says) or the etcd timeout ?

the latter

the latter

There isnt one, but indeed it would be best please to open one, do you want me or you to open it ?
since the webhook that appear in the issue main message is outdated

I think this one is it: https://github.com/kubevirt/kubevirt/issues/3777

I think this one is it: #3777

This one according most of the links there is during cluster-up, Or is on it
but please see error like we have here which deserve imo a new issue
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4511/pull-kubevirt-e2e-kind-1.17-sriov/1325727568359329793

@orenc1 @dhiller
We didnt saw this error for a while now, and there have been huge effort for stabilizing this lane
now all the changes we did are in place.
I think we can close this one.

Agreed, we can reopen it if it occurs again.

/close


Next: Add Switch Component

Linked Issue
Closes #2394
Description
Add the Switch component for both Svelte and React, as well as the expected documentation.

NOTE: also installs Lucide-Svelte and Lucide-React for testing icons!

Changsets
Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.
Checklist
Please read and apply all contribution requirements.

[x] This PR targets the dev branch (NEVER master)
[x] Documentation reflects all relevant changes
[x] Branch is prefixed with: docs/, feat/, chore/, bugfix/
[x] Ensure Svelte and Typescript linting is current - run pnpm ci:check
[x] Ensure Prettier linting is current - run pnpm format
[x] All test cases are passing - run pnpm test
[x] Includes a changeset (if relevant; see above)

Reminder:

Convert <button> to type button
Review {...props} spread method for misc a11y and similar props


Release to prod-stable

:tada: This PR is included in version 1.11.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Dr 1153 - Billing page - Add Country combo

Hi team,
I added country combo in the Billing page with the same countries of activation flow
Example:

Could you review?

Great!


[WIP] Rename ServiceParametersSet to ServicePlan

Depends on https://github.com/ManageIQ/topological_inventory-core/pull/17

@bdunne we're not worrying about breaking API changes => bumping the major version yet right

No, I think we're sticking to v0.0 for now.  I briefly talked to @carbonin & @gtanzillo and think we should start versioning soon, but we have to figure out when.

@bdunne looks like the subcollection for service_plan on service_instance isn't working:
No route matches [GET] "/api/v0.0/service_instances/1/service_plan"

@agrare It should be /api/v0.0/service_instances/1/service_plans

@bdunne Oh okay, it is a singular belongs_to so should it be plural?

I see, a ServiceInstance belongs_to a ServicePlan, so it's not a (sub)collection, it's a sub-resource and I currently don't have any routes for sub-resources.

Okay its not related to this PR, this looks good to me


git ignore deps folder

top gitignore can have .deps added as well as existing /.deps to ignore all .deps folders.

Done


feat(create-jsx-email): setup npx command

Component / Package Name:
create-jsx-email
This PR contains:

[ ] bugfix
[x] feature
[ ] refactor
[x] documentation
[ ] other

Are tests included?

[ ] yes (bugfixes and features will not be merged without tests)
[x] no

Breaking Changes?

[ ] yes (breaking changes will not be merged unless absolutely necessary)
[x] no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:

Description
This PR sets up the create-jsx-email command. The fastest way to setup a jsx-email project
Usage
npx create-jsx-email
# OR
npx create-jsx-email <project-name>

LGTM🚀