Feature/download queue

wont jhave telegram and github titles on sidebar anymore?

@piradata we won't.


Partial fix to #677 #navbarCollapse

What this PR does / why we need it:
Re-implement the class "in"
Which issue this PR fixes (optional - uncomment and add issue):
fixes #677 (partial)
Special notes for your reviewer:
Not sure if is the best/right way but this fix the hamburger menu regression.
It's not enough although.
assets/scripts/syna-collapse.js also needs updating, but I don't know if there is a proper method to do it better than by hand.
Release note:
Fix #677  #navbarCollapse regression

Ok, after a bit of trial and error I think I got it.
I was missing the node_modules folder that a empty yarn downloads and then I could run
yarn run build-js

There seems to have been a bigger underlaying issue with a code change leading to a full DOM reset resulting in lost event listeners. This should be fixed in #681.
Thanks for debugging and adding a fix, which unfortunately isn't necessary anymore with the bigger issue fixed. We'll do our best to add tests so such a regression won't happen again.
Closing for now and commenting on the issue itself.
Looking forward to more contributions especially ones we merge in ;)


NTRs? for "proximal portion of axoneme" and "distal portion of axoneme"

I am annotating PMID_26909801 and it shows a bunch of localization evidence, e.g. Dnah11 is in proximal portion of the axoneme of a "9+2 motile cilium" in respiratory epithelium, but is pan-axonemal in the "9+0 motile cilium" of the mouse embryonic node. In human cells, they also show that human DNAH11 is in proximal portion of the axoneme of a "9+2 motile cilium" in respiratory epithelium, while DNAH9  is found in only the distal region of the axoneme of these same cells.
Currently, I can annotate to the term "axoneme" and make a model or extensions to indicate the appropriate type of axoneme (9+2 motile vs 9+0 motile) and cell type or anatomy structure.
However, it seems this misses the main point of this work, which is localization of DNAH11 or DNAH9 to the proximal versus distal portions of the axoneme in these specific cell types.
I could capture the proximal and distal specific localizations with GO terms with two new terms:
proximal portion of axoneme GO:new1
distal portion of axoneme GO:new2
@paolaroncaglia @JohnvanDam @ukemi  Any objections to this proposal?
thanks,
Karen

I agree. After a quick scan of the paper it looks like the take home message is the specific localization. Plus this seems to have a clinical importance.

@krchristie @ukemi
I haven’t had a chance to read that paper, but the summary that you both give find me in full agreement with the new terms proposal. Plus there are a few other examples of the use of ‘proximal’ and ‘distal’ in GO where this improves the information content. Thanks.

human annotations updated to use new terms on 3/12/2018
mouse annotations updated to use new term on 3/16/2018


UofT DSI | Visualization - Assignment 3

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Assignment 3 submission.
What did you learn from the changes you have made?
I learnt to think about accessibility and reproducibility and how to include them in visualization.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
N/A
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
N/A
How were these changes tested?
N/A
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[X] I can confirm that my changes are working as intended

A3 complete


file upload not working

I tracked it down to this line:
https://github.com/apigee-127/sway/blob/master/lib/types/parameter.js#L150
req.files is an array. So this should probably use a .find(f => f.fieldName == name)?
Or should swagger-tools/othertool create the mapping, dont know?

okay, so actually swagger-node-runner is doing that mapping. Was bad config on my side...


Can't convert to JSON

After calling #to_json on a query result, i get an error:
no overload matches 'BSON::ObjectId#to_json' with type JSON::Builder
Am I doing something wrong or is this functionality not supported?
Disclaimer: I'm new to Crystal and Amber.

Thanks for catching this. That part of the code was untested and carried over from a very old version of granite orm. Now you should be able to call .to_json on any mongo_orm object. That said, do know that Mongo uses something called BSON, which is slightly different, and calling .to_bson will already give you a BSON object, and .to_bson.to_s is very similar to JSON. The .to_json method I wrote will give you crystal-formatted datetime values, while the .to_bson method will give you things in Mongo's internal formats.


Bug 2203362: [release-4.11] Fix the capacity queries

Capacity queries are using 'kubelet_volume_stats_used_bytes', which gives the result in a per node basis (evenwhen the nodes are sharing a single PVC).
Corrected the query to give only one result per + combination.
Signed-off-by: Arun Kumar Mohan<EMAIL_ADDRESS>(cherry picked from commit d2d2a28a17fbb86a02841f9677e5f67625ff9f41)

/bugzilla refresh

/cherry-pick release-4.11-compatibility

cc @bipuladh

/bugzilla refresh

/retest-required

added a cherry-pick comment here: https://github.com/red-hat-storage/odf-console/pull/1001#issuecomment-1695056389
we need to make sure PR for 4.11-compatibility branch is merged as well before moving BZ to MODIFIED...

/approve
/lgtm


Cost price separator

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When entering the cost for a charge, I'm not able to use comma as separator which is normal in Denmark.
Expected Behavior
No response
Steps To Reproduce
No response
Relevant log output
I cannot save the cost value when entering it with a comma instead a dot

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v1.24.1

iphone, latest IOS, cannot add cost, as it asks for a dot, but on the keyboard is comma and => error.

You could try to set the LOCALE for the teslamate service in docker-compose.yml. I have set LOCALE=DE and get commas accepted... (I think :-))

Changed the language of the application to Danish and now I can use commas.


US 1643841 - Loc fix incomplete string.

User Story 1643841: Content Update - Localization fix: Quantum Docs - M44796 - Possible incomplete string

The Localization team identified this incomplete sentence and wanted it clarified.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/overview/what-is-qsharp.md
84
47
21
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit 76bb5be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/overview/what-is-qsharp.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/overview/what-is-qsharp.md
84
47
21
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit 1efec30:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/overview/what-is-qsharp.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@cgranade Thanks! that's an excellent change.

@cgranade If there are no more suggested changes for this, the Localization team would like to get this merged. Thanks!

#sign-off

@bromeg If there are no more suggested changes, the Localization team would like to get this PR merged. Thanks!


Interpolation-only expressions are deprecated

System Information
Linux distribution
Fedora 31
Terraform version
0.12
Provider and libvirt versions
0.6 for Fedora 28

Checklist
Description of Issue/Question
Warning: Interpolation-only expressions are deprecated
on main.tf line 23, in resource "libvirt_domain" "centos7":
23:     volume_id = "${libvirt_volume.centos7-qcow2.id}"
Terraform 0.11 and earlier required all non-constant expressions to be
provided via interpolation syntax, but this pattern is now deprecated. To
silence this warning, remove the "${ sequence from the start and the }"
sequence from the end of this expression, leaving just the inner expression.
Template interpolation syntax is still used to construct strings from
expressions when the template includes multiple interpolation sequences or a
mixture of literal strings and interpolations. This deprecation applies only
to templates that consist entirely of a single interpolation sequence.
Setup
main.tf
provider "libvirt" {
uri = "qemu:///system"
}
resource "libvirt_volume" "centos7-qcow2" {
name = "centos7.qcow2"
pool = "images"
source = "/var/lib/libvirt/images/centos.qcow2"
format = "qcow2"
}
resource "libvirt_domain" "centos7" {
name   = "centos7"
memory = "1024"
vcpu   = 1
network_interface {
network_name = "default"
}
disk {
volume_id = "${libvirt_volume.centos7-qcow2.id}"
}
console {
type = "pty"
target_type = "serial"
target_port = "0"
}
}
Steps to Reproduce Issue
terraform plan

Additional information:
Do you have SELinux or Apparmor/Firewall enabled? Some special configuration?
No SELinux or Apparmor

@hvad can you add more detail to your issue and problem? TIA :pray:

Hello,
What do need ? it's a warning on terraform 0.12.
${ is deprecated syntax used on 0.11 version. If i replace ${ by syntax for 0.12 this module don't work.
Bye

@hvad I can't understand one thing. Are using a main.tf from our examples? Which module are you referring?

Hi,
Sorry when i talk about module it's for terraform-provider-libvirt.
If i use " volume_id = "${libvirt_volume.centos7-qcow2.id}"" on my main.tf then i have  "Warning: Interpolation-only expressions are deprecated" because ${ is depracated on terraform version 0.12.

@hvad  I'm stil not getting this issue.
The warning you get is a terraform warning upstream which the provider cannot fix.
The warning refer to the HCL language which we don't maintain here.
closing for this. If you have any question feel free to piing me


HTTPS deno.land import

Hello,
Could you please use HTTPS in your example deno.land import ?
Thanks

If you send a pull request, I can see about merging it.


I‐96: Monetization of Graphical Place Reservation

https://github.com/UnionInternationalCheminsdeFer/OSDM/wiki/I‐96-Monetization-of-Graphical-Place-Reservation

#557 and #592 were closed after merge of Clemens' pull request. I keep this improvement issue open so you can cross check if all necessary changes were made, work on further features, and/or documentation, or close the improvement as completed.


Testbed using of GLSL 4.00 when it's not needed.

Testbed is using GLSL 4.00 but there is no any shaders or other parts of testbed that's using it for real. As for me I am getting an error, that GLSL 4.00 is not supported, cause supported versions are 1.10, 1.20, 1.30, 1.00 ES, and 3.00 ES. So when I'm changing code a little to change version of GLSL that would be used, everything is fine (I changed shader glsl #version).
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3);
glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);

@Megaxela I may be confused then on what you mean. The only place I see glfwWindowHint getting called now is in a pre-processor #if defined(__APPLE__) block. There it does specify major version 4. But this existing code should only be getting invoked on MacOS X systems. Are you saying that glfwWindowHint also needs to be called for Linux systems but with the major set to 3? Is that because it defaults on Linux to trying to use version 4?

I guess that's true. It's not first machine that reproduces this error. I tried to remove glfwWindowHint calls, but even if i'll change shaders #version version, Testbed continue to proceed errors on shaders compilation. Yes, that issue exists in Erin Cato's Box2D repo. I remember that I changed this in his code to make it work.

Interesting!
Since the glfwWindowHint doesn't get called in the Testbed application for non-Apple systems, I believe the defaults would get used. According to the online GLFW guide, that would be 1 and 0 then for the GLFW_CONTEXT_VERSION_MAJOR and GLFW_CONTEXT_VERSION_MINOR window hints respectively. Why then is the code trying to use GLSL 4.00 then on your system I'm wondering.
Googling "glsl 4.00 is not supported" reveals some possibly relevant info:

C++ OpenGL shading version error - GLSL x is not supported Ubuntu 16.04.
Shader can't be compiled.

Now I see that the shader programs in DebugDraw.cpp have #version 400 in them while shader code in RenderGL3.cpp has #version 150 in it. According to WikiPedia's OpenGL Shading Language page, these are some of the shader preprocessor choices and version 400 is from back in OpenGL 4.0 with a date of March 2010.
What does your system say if you run sudo glxinfo | grep "OpenGL"?
Regardless, I think I understand now what you were saying regarding the #version version. I wonder why version 400 was picked in Erin's code. Looks like he introduced a shader version in his commit 66252b58bbe8006bac1f01702b557f07de9aabde , wherein he has this version 400 already chosen.
I guess we need to understand or confirm what lowering the #version would do. Sounds like you're saying that version 400 isn't necessary and that older shader #version can be used. If you replace all occurrences of #version 400 with #version 330 does everything work then for you without doing any glfwWindowHint calls in the Testbed? My concern is that glfwWindowHint can set some settings in ways that can cause the runtime to fail instead of just overriding the "hint".

Ok, I tested Testbed without glfwWindowHint, and it didn't work. Still the same error, when it compiled shaders. If I'm only adding glfwWindowHint it's not working. If I'm only changing #version in shaders it's not working either.

@Megaxela Thanks for the update! I've changed the code now so that all of the Testbed shader programs request no more than #version 330 (instead of #version 400) and so the hints given are always:
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3);
glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);
glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);

Crossing my fingers that this works better on your system and doesn't hurt on any others.

I guess the changes worked and I see that Erin effectively took these changes to his repo as well. Nice to see this outcome. Closing this issue now.


[bug] Update 'logo' field to reflect 'favicon'

Location: https://iam.hax.psu.edu/cgl109/sites/grovecenterwebtraining/
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
OS: macOS - 8GB RAM - 8 cores
Screen: 1512x982
Window size: 1505x760
Battery: 100%
Connection: 4g
Bug you experienced: Not really a bug...Not really that important, more of a note: The system uses the 'logo' field located in: Site actions > Edit Settings to define a favicon. I'm aware of this, but new users might not be aware what 'logo' actually does. Potential Fixes: Either renaming the field, or providing some descriptive text below the field that is more clear.

Good suggestion; should now be like this:
                "title": "Favicon",
                "description": "Browser tab image / used on phones as small site logo",


Duplicate entry

Hi, I have duplicate entry (redirection) in my ovh dashboard
I use :

https://github.com/caddy-dns/ovh
https://github.com/mholt/caddy-dynamicdns

Fixed in latest release


Check for previous/existing GitHub issues/module proposals

[x] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[x] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Bicep
Module Classification?
Pattern Module
Module Name
avm/ptn/mgmt-groups/subscription-placement
Module Details
This module places subscriptions within a specified management group hierarchy. While an example for ALZ (Platform, Landing Zones, Decommissioned, Sandbox, etc.) will be provided in the test cases directory, the module can support any defined hierarchy provided by a user.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
oZakari
(Optional) Secondary Module Owner's GitHub Username (handle)
31Nick

Hi @oZakari,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @oZakari,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team


please add two logos to main partners on landing page

new order: TU, EU, LMU, HSS, WM
here are the svgs
https://drive.google.com/a/serlo.org/file/d/0B0vgO6Y0XakNTThNejBiR1dobHM/view?usp=sharing
https://drive.google.com/a/serlo.org/file/d/0B0vgO6Y0XakNS3hGN1VrZ0dZbUU/view?usp=sharing

First, I am not sure whether this is for the current landing page or the planned one (see #471).
The following is only relevant, if it's for the current landing page.
The EU logo will look alright, but the blue should be the same as on Serlo and also there should be a white border around the flag.
The LMU logo is green though, also the background isn't transparent. I am not sure whether that will fit so well into the page. I would suggest the following:

make it blue instead of green
have white borders for the boxes
make the background transparent
Would these changes be ok?
My skills with graphic design programs are very limited and I don't have a lot of free time, so I won't be able to implement these changes to the svgs myself.

Hi Jonas, it's only important for the new landing page.
Have a look, how @elbotho formated the logo svgs on the current landing pages. Ithink it is a mixture between gray-scale and transparency-scale. They shouldn't have collors

oh and @JonasBley I would suggest to keep the replacement of the partners, that Botho did on the new landing page, too. So place them at the bottom of the second section (background picture). What do you think?

I would prefer them in the second section too. Makes more sense, thematically, to put partners below the vision.

We are kind of having a conversation in two different, issues, this all belongs to #471 right?

done in #489


OverrideFont does not work with Unicode font names

I am trying to make a mod that translates an English to Japanese, and I want to replace the font with Japanese one.
But when I try to display a font that has name with Japanese characters, it doesn't work.
The font name I've been trying to use: JFドットK14

When using override font and the font is not correctly selected, the available fonts are usually printed out to the log/console. Is this font printed out?

How do I enable console?

You can enable console through the config of this plugin, but I'd recommend using BepInEx instead, because it's implementation it's console integration is much better. Can also enable showing JP characters in that if your OS is not configured to show non-ASCII characters in a console.


@orta => Updated README and added CONTRIBUTING

What do you think of this?

In the mobile repos, we include a link to a tag for related blog posts - can maybe make one for force too?

-> http://artsy.github.io/blog/categories/force/

Updated.

@orta this is ready for review

10/10


Revert back to install.packages('arrow') so it fails loudly if extra aren't enabled?

https://github.com/ursacomputing/benchmarks/commit/d5d21a827dd9560558184de97c5777e7e2581500
We started using nightly because:
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[parquet, snappy, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[parquet, snappy, dataframe]
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[feather, lz4, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[feather, lz4, dataframe]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[parquet, snappy, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[parquet, snappy, dataframe]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[feather, lz4, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[feather, lz4, dataframe]

Exception: Error: NotImplemented: Support for codec 'snappy' not built

Exception: Error: NotImplemented: Support for codec 'lz4' not built

> install.packages("arrow")
Installing package into '/home/jkeane/R/x86_64-pc-linux-gnu-library/4.1'
(as 'lib' is unspecified)
trying URL 'https://packagemanager.rstudio.com/all/__linux__/bionic/latest/src/contrib/arrow_<IP_ADDRESS>.tar.gz'
Content type 'binary/octet-stream' length 20338508 bytes (19.4 MB)
==================================================
downloaded 19.4 MB

* installing *binary* package 'arrow' ...
* DONE (arrow)

The downloaded source packages are in
	'/tmp/RtmpJLf3lB/downloaded_packages'
> arrow_info()
Error in arrow_info() : could not find function "arrow_info"
> arrow::arrow_info()
Arrow package version: <IP_ADDRESS>

Capabilities:

dataset    TRUE
parquet    TRUE
json       TRUE
s3        FALSE
utf8proc   TRUE
re2        TRUE
snappy    FALSE
gzip      FALSE
brotli    FALSE
zstd      FALSE
lz4       FALSE
lz4_frame FALSE
lzo       FALSE
bz2       FALSE
jemalloc  FALSE
mimalloc  FALSE

To reinstall with more optional capabilities enabled, see
   https://arrow.apache.org/docs/r/articles/install.html

I'm not sure we want to go back to using only the release in testing. I've actually created a jira in arrow to create some sort of post-release tests to catch things like this — and we will (and have) gotten lots of tickets about it.
Using the nightly will also allow us to add + test benchmark features that aren't in a released version of arrow already.


OpenShift - Import Yaml - Button placement inconsistency

Describe the bug
When importing yaml the 'Create and 'Cancel' button appear button left of the screen, elsewhere in the application the buttons all appear top right.
To Reproduce

Login to OpenShift
Projects
Import Yaml

Expected behavior
The button placement should be consistent across the application, elsewhere in the application the buttons all appear top right of the screen.
Screenshots

Additional context
Add any other context about the problem here.

OpenShift bug, not related to the workshop

https://issues.redhat.com/browse/OCPBUGS-43611


Fix Linting Bugs

This fixes all the outstanding linting bugs, except those in aligncheck (which I've removed; it wasn't getting us much benefit.)

LGTM on green


[en]modify debug link in resource-metrics-pipeline.md

[zh] modify debug link in content/en/docs/tasks/debug/debug-cluster/resource-metrics-pipeline.md

Can you help propose these fixes in a batch or two?
/lgtm

Can you help propose these fixes in a batch or two? /lgtm

At first I wanted to do this, but then I found that the parts changed in each link are different, I am afraid I will mess up
I'll try to do this next


Support Stackage LTS 21.1

Mostly relaxing deps, but there was a little munging around regarding backwards-compatibility for aeson pre version 2.
The Item golden file needed to be regenerated for a couple reasons 1) the package version is bumped, but more importantly 2) version <IP_ADDRESS> of hspec-golden-aeson introduced a breaking change where the seed it stores is no longer an Int but an Int32. The value for this "seed" field in the golden file that existed before this PR was no longer valid as it was way larger than the max value of Int32.

Whoops, I targeted the wrong fork! 😅


[CI] Fix python 3.8.3 issue

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

python 3.8.3

Solution:

https://github.com/Azure/azure-python-devtools/pull/59 merge this PR.
bump dependency

#13680


Graphical Glitches in Tony Hawk Pro Skater II

The character doesn't seem to animate correctly. This can be seen in the intro movie below and in regular game play.
Incorrect Rendering with the CoG BIOS:
https://user-images.githubusercontent.com/7118296/141451232-9755bbba-d992-4449-9159-b0005df93afa.mov
Correct Rendering
https://user-images.githubusercontent.com/7118296/141451285-5f3ee8de-6376-4645-be9a-08677df87795.mov

This game uses SWI calls:

0x1 (RegisterRamReset)
0x5 (VBlankIntrWait)
0x6 (Div)
0x8 (Sqrt)
0xC (CpuFastSet)
0xE (BgAffineSet)
0xF (ObjAffineSet)
0x12 (LZ77UnCompReadNormalWrite16bit)

While the corruption occurs it is mostly 0x6, 0x8, and 0xF that are called.

I was able to root cause this to the implementation of the 0x8 (Sqrt) SWI through stubbing the SWI in my emulator and replacing with ReGBA/VBAs implementation


x/xerrors: tests broken (via vet error) with go1.15rc1

What version of Go are you using (go version)?

$ go1.15 version
go version go1.15rc1 darwin/amd64
$ go1.14 version
go version go1.14.6 darwin/amd64

Does this issue reproduce with the latest release?
The issue is present in the latest release candidate, go1.15rc1. It is a regression from the latest release, go1.14.6.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rhys/Library/Caches/go-build"
GOENV="/Users/rhys/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/rhys/go/pkg/mod"
GONOPROXY="*"
GONOSUMDB="*"
GOOS="darwin"
GOPATH="/Users/rhys/go"
GOPRIVATE="*"
GOPROXY="direct"
GOROOT="/usr/local/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/tmp/xerr/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/49/zmds5zsn75z1283vtzxyfr5hj7yjq4/T/go-build982147191=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
$ mkdir /tmp/xerr && cd /tmp/xerr && go mod init xerr
go: creating new go.mod: module xerr

$ go get golang.org/x/xerrors@master
go: golang.org/x/xerrors master => v0.0.0-20191204190536-9bdfabe68543

$ go1.15 test golang.org/x/xerrors
# golang.org/x/xerrors_test
/Users/rhys/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20191204190536-9bdfabe68543/fmt_test.go:398:43: Sprint arg e causes recursive call to Error method
FAIL	golang.org/x/xerrors [build failed]
FAIL

$ go1.14 test golang.org/x/xerrors
ok  	golang.org/x/xerrors	0.302s

$ go1.15 version
go version go1.15rc1 darwin/amd64

$ go1.14 version
go version go1.14.6 darwin/amd64

What did you expect to see?
I expected the tests for the golang.org/x/errors package to succeed without errors.
What did you see instead?
A new vet check in Go 1.15, enabled by default when running tests, detects what looks like a bug in a type that x/xerrors defines for the purpose of testing itself. https://github.com/golang/xerrors/blob/9bdfabe68543/fmt_test.go#L398

I can reproduce this locally using go1.15rc1.

CC @toothrot

Should be fixed at head, but may need a backport to release-branch.go1.15.
#37020 is the issue to add this repo to the build dashboard.

@gopherbot, please backport to 1.15.


js web worker sample doesnt work

Package Name:
Package Version:
Operating system:
[ ] nodejs

version:

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Follow the directions in the readme.md   file
Click on the deploy link
It's referencing the URL:    web-worker/*rm-template.json and also it overrides the current browser window... it should have opened in a different tab.
Copy the URL to a browser and correct the URL to be arm-template.json
go to deplay a template in the portal and paste the template
The template doesn't actually create the SAS  / doesn't display it
In the portal open blobs and then create a SAS for blobs with every permission possible
copy to .env , paste the URL and run npm-install
Run the code and see that the developer tools is complaining that .

Expected behavior
I would expect that everything should work
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi @nagendramishr - thank you for creating this issue. To clarify, is this the sample you are referring to: https://github.com/Azure/azure-sdk-for-js/tree/main/samples/web-workers ?

Yes:
@.***
From: Maor Leger @.>
Sent: Friday, March 18, 2022 11:20 AM
To: Azure/azure-sdk-for-js @.>
Cc: Nagendra Mishr @.>; Mention @.>
Subject: Re: [Azure/azure-sdk-for-js] js web worker sample doesnt work (Issue #20934)
Hi @nagendramishrhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnagendramishr&data=04|01|Nagendra.Mishr%40microsoft.com|e54c2058d26642a50e9e08da08f2c4db|72f988bf86f141af91ab2d7cd011db47|1|0|637832136027707164|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Te7fP8jUYfS91TpFgBgcwxKvX%2Bvpq9UgFiSNCnUwf4w%3D&reserved=0 - thank you for creating this issue. To clarify, is this the sample you are referring to: https://github.com/Azure/azure-sdk-for-js/tree/main/samples/web-workershttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Ftree%2Fmain%2Fsamples%2Fweb-workers&data=04|01|Nagendra.Mishr%40microsoft.com|e54c2058d26642a50e9e08da08f2c4db|72f988bf86f141af91ab2d7cd011db47|1|0|637832136027707164|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=MxfU0xiVV%2BGfLeVUIXnqMhYjBnVqJR8xlVXlDeD7lHM%3D&reserved=0 ?

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Fissues%2F20934%23issuecomment-1072513222&data=04|01|Nagendra.Mishr%40microsoft.com|e54c2058d26642a50e9e08da08f2c4db|72f988bf86f141af91ab2d7cd011db47|1|0|637832136027707164|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2BJJsnb7bxIKQNZitgLJJ%2FZzowDKrG5cJ12m9cjmrlmQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATOLBOBSCSIPYHC3KLDIBKLVASNKBANCNFSM5RB47FOQ&data=04|01|Nagendra.Mishr%40microsoft.com|e54c2058d26642a50e9e08da08f2c4db|72f988bf86f141af91ab2d7cd011db47|1|0|637832136027707164|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=dnBOkWb%2ByOx5fXN2L%2FW1DB0CWxWplp4VX5%2F9ykavuPc%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|Nagendra.Mishr%40microsoft.com|e54c2058d26642a50e9e08da08f2c4db|72f988bf86f141af91ab2d7cd011db47|1|0|637832136027707164|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=iP6zLDpOMWs9lGfd8EhsJ4Hk%2FUWgKGiEmHZDCkdxAmk%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|Nagendra.Mishr%40microsoft.com|e54c2058d26642a50e9e08da08f2c4db|72f988bf86f141af91ab2d7cd011db47|1|0|637832136027707164|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=8%2FUwZYwlftw1Yj881GNVkjd40ygu25IiT%2F3gwnzS4xQ%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Just following up here - it looks like SharedArrayBuffer has been turned off by most modern browsers. JSDOM uses webidl-conversions which is where this error comes from (source: https://github.com/jsdom/webidl-conversions/issues/38). An article about why SharedArrayBuffer has been disabled is posted here: https://developer.chrome.com/blog/enabling-shared-array-buffer/
In short, we will need to update our sample to use something other than JSDOM as it is no longer supported by modern browsers until this is fixed. It will take me some time to find a suitable replacement, but this is the root of the problem.


[AutoPR automation/resource-manager] Remove automation parameters from client

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2741

Codecov Report

Merging #2261 into restapi_auto_automation/resource-manager will increase coverage by 1.85%.
The diff coverage is 0%.

@@                             Coverage Diff                              @@
##           restapi_auto_automation/resource-manager    #2261      +/-   ##
============================================================================
+ Coverage                                     50.41%   52.26%   +1.85%
============================================================================
  Files                                          5811     4955     -856
  Lines                                        149519   124189   -25330
============================================================================
- Hits                                          75375    64912   -10463
+ Misses                                        74144    59277   -14867

Impacted Files
Coverage Δ

...gmt/automation/operations/connection_operations.py
14.15% <ø> (ø)
:arrow_up:

.../mgmt/automation/operations/schedule_operations.py
14.95% <ø> (ø)
:arrow_up:

...mt/automation/operations/certificate_operations.py
14.54% <ø> (ø)
:arrow_up:

...omation/operations/dsc_configuration_operations.py
14.81% <ø> (ø)
:arrow_up:

...e/mgmt/automation/operations/webhook_operations.py
13.84% <ø> (ø)
:arrow_up:

...re/mgmt/automation/operations/module_operations.py
14.67% <ø> (ø)
:arrow_up:

...gmt/automation/operations/credential_operations.py
15.45% <ø> (ø)
:arrow_up:

.../mgmt/automation/operations/variable_operations.py
14.67% <ø> (ø)
:arrow_up:

...utomation/operations/connection_type_operations.py
15.73% <ø> (ø)
:arrow_up:

...erations/hybrid_runbook_worker_group_operations.py
15.9% <ø> (ø)
:arrow_up:

... and 1246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b3bed...ce33f77. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/1959


Slow bot_update step blocking tree re-opening

The bot_update step usually takes a couple of minutes, but it's taking more than an hour here: https://ci.chromium.org/p/flutter/builders/prod/Linux Host Engine/6431
End of the logs:
[1:11:30] Still working on:
[1:11:30]   src/third_party/dart/third_party/pkg/html
[1:11:30]   src/third_party/dart/third_party/pkg/linter

/cc @godofredoc Is this a network issue?

Not sure, the bot update is a black box but it shouldn't take more than 5 mins. I can take a look by I recommend to kill the process and retry from github ui to unblock.

Retried the builder.

Did you use? https://g3doc.corp.google.com/company/teams/flutter/luci/playbook.md#trigger-prod-builder-retries

The tree is showing a blue square there, now. Will this eventually re-run and turn green?

Same issue on Windows Host Engine: https://ci.chromium.org/p/flutter/builders/prod/Windows Host Engine/6348, sorry I didn't include that in the initial report.

Seems like there is a problem checking out  src/third_party/swiftshader, do you know where are we getting it from?

Did you use? https://g3doc.corp.google.com/company/teams/flutter/luci/playbook.md#trigger-prod-builder-retries

I clicked the retry button, the retry build succeeded: https://ci.chromium.org/p/flutter/builders/prod/Linux Host Engine/6432

Looks like the issue is caused by network hiccup and that is recovered.


Proposed Fix for ReqnrollVisualStudio issue 47

(Context menu throws error in project that Step Bindings but no feature files)
Looking for feedback on whether this is a valid path to take to solve the reported issue.
Partial fix; tests not passing and needing update to reflect that with this change we would allow Discovery to proceed on external binding assemblies.

🤔 What's changed?

⚡ What's your motivation?

🏷 What kind of change is this?

:book: Documentation (improvements without changing code)
:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
:bug: Bug fix (non-breaking change which fixes a defect)
:zap: New feature (non-breaking change which adds new behaviour)
:boom: Breaking change (incompatible changes to the API)

♻ Anything particular you want feedback on?

📋 Checklist:

[ ] I've changed the behaviour of the code

[ ] I have added/updated tests to cover my changes.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] Users should know about my change

[ ] I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

My thoughts on making the background execution of discovery.
The background execution for discovery is a must, because otherwise I would lock to main (UI) thread causing the UI freeze and also VS would kill our extension.
@Code-Grump said on Discord:

If we were talking in terms of tasks, I would expect to fire-and-forget the discovery (because we don't want to do heavy work on the main thread) by using Task.Run but have components interested in the discovered bindings await the task (because it may still be running.)

This is basically how it works. We trigger the discovery from DiscoveryService here as
_projectScope.IdeScope.FireAndForgetOnBackgroundThread(
            _ => BindingRegistryCache.Update(_ => DiscoveryInvoker.InvokeDiscoveryWithTimer()));

The IdeScope.FireAndForgetOnBackgroundThread is just an interface method to make testing easier, but the real implementation uses a Task.Start:
Task.Factory.StartNew(async () =>
    {
        try
        {
            ThreadHelper.ThrowIfOnUIThread(callerName);
            await action(_backgroundTaskTokenSource.Token);
        }
        catch (Exception e)
        {
            Logger.LogException(MonitoringService, e, $"Called from {callerName}");
        }
    },
    _backgroundTaskTokenSource.Token,
    TaskCreationOptions.LongRunning,
    TaskScheduler.Default
);

About waiting for the binding discovery result in UI commands
The binding discovery is performed whenever you build the project as it is working based on the compiled assemblies, once the feature file has been opened on that project (that initializes the system and performs the first discovery).
Once you build the discovery is finished within a few seconds.
Most of our UI commands are executed from the feature file, so normally the discovery has been anyway performed.
There are a few commands that start from the C# files, so there is a chance that no feature files were executed yet and therefore the discovery is not initialized yet. In that case we should initialize the discovery (this is done when you call project.GetDiscoveryService() like in here) and wait to finish with an await, like here.
        var discoveryService = project.GetDiscoveryService();
        var bindingRegistry = await discoveryService.BindingRegistryCache.GetLatest();

@clrudolphi said on Discord

The second issue is that when discovery IS performed, is launched on a background thread in a Fire&Forget manner. That thread of activity has not yet finished when the Command is looking for the result, and so it finds the original (Invalid) binding registry in the cache.

Based on the description above, this should not be a problem (maybe there is a bug though).
On extending these features to Reqnroll "lib" projects
Now I better remember the problem.
The problem with the Reqnroll "lib" projects (so literally class lib projects that do not contain feature files), that these projects do not have a Reqnroll configuration. To understand this, consider the following case:

Reqnroll Lib A: defines a step argument transformation for type X
Reqnroll Lib B: defines a step definition that uses X in the parameter, e.g. with Cucumber expression: I do something with {X}
Reqnroll Test Project: has a configuration that lists both Lib A and Lib B as binding assembly and has a feature file that uses the step definition from Lib B

This is a fully valid setup. Once the tests are running, the binding discovery is performed for the Test Project, that loads step definitions and transformations from both Lib A and Lib B and run the step successfully.
But if you would consider Lib B alone, that is invalid, because it cannot understand {X} in the cucumber expression and it does not have a configuration that would tell that it depends on Lib A.
Of course this is a special case and in most of the cases, the binding discovery can also be performed for lib projects, but in this case it is hard to separate if the binding is invalid because the user did something wrong or it is invalid because it can only be used in a context of a test project. So we could run into an issue that we keep showing invalid errors for lib project discovery to the users although nothing is wrong.
So I don't know how we could support this easily.
What do you think?

Regarding the complexity of supporting Find when we have partial discovery; I suggest we either:

Create a mechanism by which Discovery is performed on the entire solution (and all commands run off of that), or
Do a better job at identifying the edge cases and responding with better error messages to explain the limitations

Regarding the complexity of supporting Find when we have partial discovery; I suggest we either:

Create a mechanism by which Discovery is performed on the entire solution (and all commands run off of that), or
Do a better job at identifying the edge cases and responding with better error messages to explain the limitations

I am absolutely agree to the second point, but I can't imagine how could we do the discovery for the entire solution. Do you have some concrete ideas for that?

If that line were changed to:
            var bindingRegistry = await project.GetDiscoveryService().BindingRegistryCache.GetLatest();

would that be sufficient?

Good question, we would need to try.
As far as I remember, for the UI thread the await call works in a way that it gives back the UI thread to the general event processing loop (so won't freeze) and when the result arrives it schedules it back to the UI thread. So it won't block the UI, but maybe @Code-Grump knows this better.

Regarding the complexity of supporting Find when we have partial discovery; I suggest we either:

Create a mechanism by which Discovery is performed on the entire solution (and all commands run off of that), or
Do a better job at identifying the edge cases and responding with better error messages to explain the limitations

I am absolutely agree to the second point, but I can't imagine how could we do the discovery for the entire solution. Do you have some concrete ideas for that?

In the FindUsages Command, after obtaining the binding registry, it iterates through all the projects of the solution, reads/parses the feature files and finds matches. In other words, we have the topology of the solution.
It would seem we have all we need to spider our way through the solution and ask each project for its binding registry; and then we would merge them. If we processed them in reverse topological sort order (of dependencies on each other), then might we be able to solve the thorny problem you identified earlier of a given StepDef pattern referencing an argument transformation defined elsewhere?

Good question, we would need to try.

I'll give that a try.

Good question, we would need to try.

Ugh. Not sure how to do this. This section of code is in the Command's PreExec method, which is an override of the virtual method defined in DeveroomEditorCommandBase. This code is old enough that it doesn't support async/await.
If I used:
            var bindingRegistry = Task.Run(
                 () => project.GetDiscoveryService().BindingRegistryCache.GetLatest()
             ).Wait();

would that be sufficient? I suspect not as the wait would block the thread, right?
Should we upgrade this Class to support async/await versions of PreExec and PostExec? Or would that not work well the vs ide?

Here is a different idea. What if the bulk of the PreExec method body were put inside a single Task.Run()? For example, here is the FindStepDef command method as it exists today:
    public override bool PreExec(IWpfTextView textView, DeveroomEditorCommandTargetKey commandKey,
        IntPtr inArgs = default)
    {
        Logger.LogVerbose("Find Step Definition Usages");

        var textBuffer = textView.TextBuffer;
        var fileName = GetEditorDocumentPath(textBuffer);
        var triggerPoint = textView.Caret.Position.BufferPosition;

        var project = IdeScope.GetProject(textBuffer);
        bool bindingsNotYetLoaded = false;
        bool projectNotYetLoaded = project == null;
        if (!projectNotYetLoaded)
        {
            Logger.LogVerbose("Find Step Definition Usages:PreExec: project loaded");
            var bindingRegistry = project.GetDiscoveryService().BindingRegistryCache;
            bindingsNotYetLoaded = (bindingRegistry == null || bindingRegistry.Value == ProjectBindingRegistry.Invalid);
            if (bindingsNotYetLoaded)
                Logger.LogVerbose($"Find Step Definition Usages: PreExec: binding registry not available: {(bindingRegistry == null ? "null" : "invalid")}");
        }

        if (project == null || !project.GetProjectSettings().IsReqnrollProject || bindingsNotYetLoaded )
        {
            IdeScope.Actions.ShowProblem(
                "Unable to find step definition usages: the project is not detected to be a Reqnroll project or it is not initialized yet.");
            return true;
        }

        var reqnrollTestProjects = IdeScope.GetProjectsWithFeatureFiles()
            .Where(p => p.GetProjectSettings().IsReqnrollTestProject)
            .ToArray();

        if (reqnrollTestProjects.Length == 0)
        {
            IdeScope.Actions.ShowProblem(
                "Unable to find step definition usages: could not find any Reqnroll project with feature files.");
            return true;
        }

        var asyncContextMenu = IdeScope.Actions.ShowAsyncContextMenu(PopupHeader);
        Task.Run(
            () => FindUsagesInProjectsAsync(reqnrollTestProjects, fileName, triggerPoint, asyncContextMenu,
                asyncContextMenu.CancellationToken), asyncContextMenu.CancellationToken);
        return true;
    }

Here is a revised version in which we invoke GetLatest() on the BindingRegistryCache() and the GetDiscoveryService() need not launch a new thread since everything is already off the UI thread.
    public override bool PreExec(IWpfTextView textView, DeveroomEditorCommandTargetKey commandKey,
        IntPtr inArgs = default)
    {
        Logger.LogVerbose("Find Step Definition Usages");

        var textBuffer = textView.TextBuffer;
        var fileName = GetEditorDocumentPath(textBuffer);
        var triggerPoint = textView.Caret.Position.BufferPosition;

        var project = IdeScope.GetProject(textBuffer);
        bool bindingsNotYetLoaded = false;
        bool projectNotYetLoaded = project == null;
        var asyncContextMenu = IdeScope.Actions.ShowAsyncContextMenu(PopupHeader);

        Task.Run(() =>
       {

        if (!projectNotYetLoaded)
        {
            Logger.LogVerbose("Find Step Definition Usages:PreExec: project loaded");
            var bindingRegistry = project.GetDiscoveryService().BindingRegistryCache.GetLatest();
            bindingsNotYetLoaded = (bindingRegistry == null || bindingRegistry.Value == ProjectBindingRegistry.Invalid);
            if (bindingsNotYetLoaded)
                Logger.LogVerbose($"Find Step Definition Usages: PreExec: binding registry not available: {(bindingRegistry == null ? "null" : "invalid")}");
        }

        if (project == null || !project.GetProjectSettings().IsReqnrollProject || bindingsNotYetLoaded )
        {
            IdeScope.Actions.ShowProblem(
                "Unable to find step definition usages: the project is not detected to be a Reqnroll project or it is not initialized yet.");
            return true;
        }

        var reqnrollTestProjects = IdeScope.GetProjectsWithFeatureFiles()
            .Where(p => p.GetProjectSettings().IsReqnrollTestProject)
            .ToArray();

        if (reqnrollTestProjects.Length == 0)
        {
            IdeScope.Actions.ShowProblem(
                "Unable to find step definition usages: could not find any Reqnroll project with feature files.");
            return true;
        }

           FindUsagesInProjectsAsync(reqnrollTestProjects, fileName, triggerPoint, asyncContextMenu,
                asyncContextMenu.CancellationToken):
    },
asyncContextMenu.CancellationToken);
        return true;
    }

await isn't necessarily going to help us. It should be able to, provided the await is able to capture the synchronization context that is the UI thread and schedule the continuation back to the UI thread when the awaited task has completed. This should happen automatically but Visual Studio is a magical beastie and may have other ideas, so I'd want to test to be absolutely certain.
We absolutely cannot use Wait(): at best you will block the UI thread (making Visual Studio unresponsive until the task completes) at worst, you will deadlock the UI thread (because it gets stuck waiting for itself.)
There are two problems being presented (actual coding semantics aside.) Fundamentally this is a piece of lazy evaluation happening, so we need to:

Have a way of building the binding cache which will

evaluate when it is first requested
block callers until it is available
immediately return the value on future requests

Make sure the UI remains responsive and indicate that work is happening throughout the operation and prevent other requests racing with it, especially if it takes a noticeable amount of time the first time it happens.

So we probably want something that continues to create a task on the thread-pool using Task.Run, but we modify it so it's a lazy-created task that is assigned to a field, and then the task can be awaited by anything that requires it.
In essence a method in a class structured like this (types indicated are for the concept only and can be renamed):
    // A lazy field to ensure we only do the building once. It holds a task, because the building is asynchronous.
    private readonly Lazy<Task<ProjectBindingRegistry>> _lazyRegistryBuildTask;

    public DiscoveryService()
    {
        // The lazy initialization uses LazyThreadSafetyMode.ExecutionAndPublication to ensure work will be started only once.
        // Starting is actually cheap and will happen very quickly; the critical section is miniscule.
        _lazyRegistryBuildTask = new Lazy<Task<ProjectBindingRegistry>>(BuildBindingRegistryOnThreadPoolAsync, LazyThreadSafetyMode.ExecutionAndPublication);
    }

    // The public method which can be awaited. It unwraps the task from the Lazy field. If the task has not been started, this causes it to be created.
    public Task<ProjectBindingRegistry> GetBindingRegistryAsync() => _lazyRegistryBuildTask.Value;

    // The method which schedules the work to happen on the thread-pool.
    private Task<ProjectBindingRegistry> BuildBindingRegistryOnThreadPoolAsync() => Task.Run(BuildBindingRegistry);

    // The method that does the real work to build the registry. This runs exactly once on the thread pool.
    private ProjectBindingRegistry BuildBindingRegistry()
    {
        // Actual work done here.
    }

I've placed the bulk of the FindStepDefinitionsCommand.PreExec method body inside of a Task. Before running the task, the ShowAsyncContextMenu() is called to cause the pop-up context menu to appear. The task then causes the results of the Find to populate into the context menu. The cancellation token of the popup context menu is passed to the task.
I modified one unit test to reflect that focuses on Not Supporting discovery on Non Reqnroll projects to allow for discovery on ReqnrollLibProjects.
Two items for further investigation:

The Discovery related Spec tests fail on my local machine, but passed during the github build. (weird)
Given the change to how Discovery works, I'd like to re-examine what we're doing with 'FindUnUsedStepDefinitions" when launched from external assembly projects.

Let me know your thoughts on these changes. If acceptable, I'll mark up the ChangeLog and resubmit.

I am happy with this so far.
For manual/exploratory testing:

you can use https://github.com/reqnroll/Reqnroll.ExploratoryTestProjects/tree/main/CleanReqnrollProject, that has an additional binding project as well. Make sure you unload the Net462 project as that is not supported by out VS extension anyway.
for UI lock issues, you can use the https://github.com/reqnroll/Reqnroll.ExploratoryTestProjects/tree/main/BigReqnrollProject but I also sometimes put some extra thread.sleep to the discovery processing code to simulate slow discovery processing

For auto tests:

it is painful, but it is a good opportunity that it fails locally. you would need to look at that. maybe you can trace some of the flakyness

I can't imagine how could we do the discovery for the entire solution.

@gasparnagy Would it be feasible to extend/change the Discovery Connectors in the VS project to do a solution-wide discovery?


Pass own endpoint to a project as environment variable

Discussed in https://github.com/dotnet/aspire/discussions/3522

Originally posted by Kralizek April  9, 2024
I need to set two environment variables for a project to be able to run correctly: one is the address of another service, the other is the address of the same service.
var auth = builder.AddProject<AuthService>("auth")
    .WithReference(db)
    .WithReference(legacyDb);

var admin = builder.AddProject<Admin>("admin")
    .WithEnvironment("AdminUi__AuthorityUrl", auth.GetEndpoint("http"))
    .WithEnvironment("AdminUi__UiUrl", "http://localhost:5278") // Copied from launchSettings.json
    .WithReference(db);

Is there a better way than this? Something that doesn't create a magic string coupling?
Ideally I'd love the possibility to do something like
var admin = builder.AddProject<Admin>("admin")
    .WithEnvironment("AdminUi__AuthorityUrl", auth.GetEndpoint("http"))
    .WithEnvironment("AdminUi__UiUrl", t => t.GetEndpoint("http"))
    .WithReference(db);

I think this could be useful in this situation where people might want to specify configuration in the appsettings.json but need to pass in the Url via an environment variable to override. For example: https://github.com/dotnet/aspire/issues/3695

I'm partial to using GetEndpoint to avoid assigning static ports to projects locally while still being able to access the endpoints used for non-HttpClient scenarios (e.g. populating links to other localhost projects in Blazor pages).

Simplest way to do this is to break up your fluent API calls:
var auth = builder.AddProject<AuthService>("auth")
                 .WithReference(db)
                 .WithReference(legacyDb);

var admin = builder.AddProject<Admin>("admin")
                   .WithEnvironment("AdminUi__AuthorityUrl", auth.GetEndpoint("http"))
                   .WithReference(db);

admin.WithEnvironment(context =>
{
    context.EnvironmentVariables["AdminUi__UiUrl"] = admin.GetEndpoint("http");
})


[APP REQUEST] CV Engineer | Resume builder

Need this app named CV Engineer
https://play.google.com/store/apps/details?id=sampson.cvbuilder

Closing this issue.
App suggestions and requests should not be made through the issues system. The issues section is meant for reporting bugs, technical problems, or suggesting improvements for UpdateMe itself.


Neither of the mobile-examples work

On Macos with Xcode 8.3.2. Both the UIExamples and Navigation subprojects fail at the sbt ios:dev stage.

Fail how?

@marcintustin Are you still having problems? If not, please close. If yes, please add details.

@virtualirfan Dude, you try building them.

@marcintustin
you didn't answered @virtualirfan  first question yet! , anyway to help you further here are the options available

sbt ios:dev is just compilation stuff. post the full error you getting ...
Fix it yourself, send a PR and document it.
Install a torjan backdoor on your computer and share details with us.When some one from sri community have time will access your computer to see exact error you getting and will suggest a fix if we know!.

Rakshak Bot : @marcintustin you're not allowed to create issues here, please post your question here, if its a reproducible bug one of sri maintainers will create an issue back here will inform you about when/how it will be fixed.


[Event Request] Codeunit 12 Gen. Jnl.-Post Line - OnCustPostApplyCustLedgEntryOnAfterCustLedgEntryTransferFields

We need a new event in Codeunit 12 "Gen. Jnl.-Post Line" named OnCustPostApplyCustLedgEntryOnAfterCustLedgEntryTransferFields:
[IntegrationEvent(false, false)]
local procedure OnCustPostApplyCustLedgEntryOnAfterCustLedgEntryTransferFields(VAR CustLedgerEntry: Record "Cust. Ledger Entry"; VAR GenJournalLine: Record "Gen. Journal Line")
begin
end;
called from:
procedure CustPostApplyCustLedgEntry(var GenJnlLinePostApply: Record "Gen. Journal Line"; var CustLedgEntryPostApply: Record "Cust. Ledger Entry")
var
Cust: Record Customer;
CustPostingGr: Record "Customer Posting Group";
CustLedgEntry: Record "Cust. Ledger Entry";
DtldCustLedgEntry: Record "Detailed Cust. Ledg. Entry";
TempDtldCVLedgEntryBuf: Record "Detailed CV Ledg. Entry Buffer" temporary;
CVLedgEntryBuf: Record "CV Ledger Entry Buffer";
GenJnlLine: Record "Gen. Journal Line";
DtldLedgEntryInserted: Boolean;
begin
OnBeforeCustPostApplyCustLedgEntry(GenJnlLinePostApply);
GenJnlLine := GenJnlLinePostApply;
CustLedgEntry.TransferFields(CustLedgEntryPostApply);
//INIT INSERT
OnCustPostApplyCustLedgEntryOnAfterCustLedgEntryTransferFields(CustLedgEntry, GenJnlLine);
//END INSERT
with GenJnlLine do begin
"Source Currency Code" := CustLedgEntryPostApply."Currency Code";
"Applies-to ID" := CustLedgEntryPostApply."Applies-to ID";
GenJnlCheckLine.RunCheck(GenJnlLine);
......
......
......

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


fix: Optimize pathSatisfies to handle specified path not exists

I'm afraid that I'm :-1: on this.  I know some recent path changes have not yet been released.  I'm not sure if they would fix the error that led you to this PR, but I'll see what I can do about getting them out soon.
But what I really don't like about this is that it might suppress an error in the user's pred function.  We really don't want to swallow an error that we didn't create.


Tag a python docker image that isn't wasmedge specific

ghcr.io/vmware-labs/python-wasm:3.11.1-latest is wasmedge specific, and has signatures incompatible with WASI. This makes it impossible to use in other runtimes including what's supported by crun (wasmer and wasmtime) as well what isn't yet (wazero)
Can you re-publish this so that both compatible and the wasmedge vendor specific images exist. I understand wasmedge is important, but it would be nice for others to easily re-use your work and docker is easier than extracting zips.

By the way, I tried the non-wasmedge build and failed. It would be helpful to create CI to prove they work, as it is easy to get things like paths wrong.

@codefromthecrypt thanks for the input! Putting this on the plan!

By the way, I tried the non-wasmedge build and failed. It would be helpful to create CI to prove they work, as it is easy to get things like paths wrong.

Totally agree about a CI, that's on the roadmap. If possible could you share what failed? Is it not working at all or was it a non-obvious configuration issue (since you mention paths)?

I was trying to build a docker image out of it, but python didn't start fully due to some encoding error. The image itself was a little complicated due to having to download and unzip stuff, and prefer to not set that up again right now.
when there's a portable image basically I'll try again which is something like this, just python instead of a glorified hollo world https://github.com/tetratelabs/wazero/pull/1099#issuecomment-1418111204

I was trying to build a docker image out of it, but python didn't start fully due to some encoding error. The image itself was a little complicated due to having to download and unzip stuff, and prefer to not set that up again right now.

Got it. The encoding error is caused by the missing standard library. When you build the docker image you also need to add the usr folder from the release in /usr. As is done here - https://github.com/vmware-labs/webassembly-language-runtimes/blob/main/images/python/Dockerfile.
We'll try to also offer a fat binary via wasi-vfs so you won't need to do this in future.

when there's a portable image basically I'll try again which is something like this, just python instead of a glorified hollo world tetratelabs/wazero#1099 (comment)

I will ping you when we publish one.

thanks for the tips and also interesting about wasi-vfs as indeed that would be easy for anything built-in!

New images published:

ghcr.io/vmware-labs/python-wasm:3.11.1 - WASI compliant
ghcr.io/vmware-labs/python-wasm:3.11.1-wasmedge - WasmEdge compliant

great. I'll give these a go shortly (pun intended)

@assambar thanks to @evacchi this is confirmed working (albeit 1.0.1 not 1.0.0 😊) https://github.com/tetratelabs/wazero/releases/tag/v1.0.1


Policy enhancements

Added by aanm:
Depends on #650
Fixes https://github.com/cilium/cilium/issues/552
TODO:

[x] Fix runtime tests. They are failing most likely due policy: changed TargetCoveredBy to cover all labels (134fafe).
[x] Merge ingress-isolation code with this PR
[x] Add namespace listener to automatically modify the running containers' labels in case the user changes the label of a kubernetes namespace.
[ ] Rebase with #650
[x] Add documentation to make @houndci-bot happy

All commits addressed with the new policy


fix(esl-media): fix brightcove provider autoplay marker flow

Closes: #1979

:tada: This PR is included in version 4.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Disable the TLS by default

This closes #907

Do we need to enable TLS in docker images? Currently TLS is enabled in nightly dockerhub images.

Do we need to enable TLS in docker images? Currently TLS is enabled in nightly dockerhub images.

Yes, we need to enable TLS in docker image, let me fix it later.


Bulk Update: Adds spaces between variable types and variables

Pull Request (PR) description
Adds spaces between variable types and variables. (Mostly) resisted the urge to fix other code style issues surrounding these changes. Planning to fix those in other PR's.
This Pull Request (PR) fixes the following issues
None
Task list

[x] Added an entry under the Unreleased section of the change log in
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as
appropriate.
[ ] Examples appropriately added/updated.
[x] Unit tests added/updated. See
DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See
DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines and Best Practices

This change is

Codecov Report

Merging #541 into dev will not change coverage.
The diff coverage is 50%.

@@         Coverage Diff         @@
##            dev   #541   +/-   ##
===================================
  Coverage    74%    74%
===================================
  Files        27     27
  Lines      4029   4029
  Branches      4      4
===================================
  Hits       3009   3009
  Misses     1016   1016
  Partials      4      4


Tag Helper - Associated VS2017 Warning

When using the  tag helper and a target attribute simultaneously VS2017 gives a warning saying "Attribute is allowed only when 'href' is present".  I guess it's pretty obvious why it's happening as it tells us but not sure it's the desired behaviour.
Example of tag:
View all activities

This is obviously not stopping anything working but thought you might like to know (and it's a little annoying to have warnings when there isn't anything wrong).
If this isn't the correct repo, can you let me know the correct one and I will raise there.

This issue was moved to aspnet/Razor#1428


Fix error in update method for V_STATUS

Remove check against V_STATUS to avoid error when using version 1.4
of mysensors. V_LIGHT has the same integer value so V_STATUS is not
needed.

You know you don't have to wait for me to merge these


x509: certificate relies on legacy Common Name field

Details
I discovered a problem while developing a helm chart  that generates a self signed SSL:

Helm chart

Specifically I'm using this logic to generate the certs:
{{ $ca := genCA "tesoro-admission-controller-ca" 3650 }}
{{ $cn := printf "tesoro-admission-controller.%s.svc" .Release.Namespace }}
{{ $server := genSignedCert $cn nil nil 365 $ca }}

However on Kubernetes v1.19 the following error is being thrown, when the mutating admission controller is being used:
$ kubectl apply -f tests/k8s/nginx_deployment.yml
Error from server (InternalError): error when creating "tests/k8s/nginx_deployment.yml": Internal error occurred: failed calling webhook "tesoro-admission-controller.tesoro.svc": Post "https://tesoro-admission-controller.tesoro.svc:443/mutate?timeout=30s": x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0

Everything works fine on Kubernetes v1.18
Suspect
Kubernetes v1.19 is now built with golang 1.15.0-rc.1

Kubernetes v1.19 API changes
#93264

Latest version of helm is using go 1.14
$ helm version
version.BuildInfo{Version:"v3.4.1", GitCommit:"c4e74854886b2efe3321e185578e6db9be0a6e29", GitTreeState:"clean", GoVersion:"go1.14.11"}

Additional
Output of helm version:
$ helm version
version.BuildInfo{Version:"v3.4.1", GitCommit:"c4e74854886b2efe3321e185578e6db9be0a6e29", GitTreeState:"clean", GoVersion:"go1.14.11"}

Output of kubectl version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.7", GitCommit:"bfb38f707bc4a8edfcd73472ec3d96b500b8b781", GitTreeState:"clean", BuildDate:"2020-08-12T20:27:48Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-11T13:09:17Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
$ minikube start
😄  minikube v1.15.1 on Ubuntu 18.04
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.19.4 on Docker 19.03.13 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

Functions like genCA are provided by a third-party library called sprig, which are then included in Helm's template engine. So if there's an issue with the function's output, it's probably best to start tracking the issue down there to see if a fix can be applied upstream.
Hope that helps.

@myspotontheweb hey!
can use for example:
{{- $cn := printf "%s.%s.svc" ( include "chart.name" . ) .Release.Namespace }}
{{- $ca := genCA "default-ca" 3650 -}}
{{- $altNames := list ( printf "%s" ( include "chart.name" . ) ) ( printf "%s.%s" ( include "chart.name" . ) .Release.Namespace ) ( printf "%s.%s.svc" ( include "chart.name" . ) .Release.Namespace ) -}}
{{- $cert := genSignedCert $cn nil $altNames 3650 $ca -}}

need to add altNames and it will work


x/net/http2: Incompatibility between library and built-in net/http transport ("bogus greeting")

What version of Go are you using (go version)?
1.9.2
Does this issue reproduce with the latest release?
Yes (1.9.2 is currently the latest.)
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jeff/go"
GORACE=""
GOROOT="/home/jeff/src/go"
GOTOOLDIR="/home/jeff/src/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build323001895=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
Created an http.Server and called http2.ConfigureServer on it with nil configuration.
What did you expect to see?
Working behavior regardless of whether an http.Transport is using the Go net/http package's built-in H2 support or the http2 package's support.
What did you see instead?
When an http.Client is used with an http.Transport using the built-in net/http H2 support, a bogus greeting message:
2017/10/27 16:44:08 http2: server: error reading preface from client <IP_ADDRESS>:51101: bogus greeting "GET /v1/auth/token/looku"
--- FAIL: TestServer (2.59s)
        sandbox_test.go:46: Get https://<IP_ADDRESS>:51096/v1/auth/token/lookup-self: net/http: HTTP/1.x transport connection broken: malformed HTTP response "\x00\x00\x18\x04\x00\x00\x00\x00\x00\x00\x05\x00\x10\x00\x00\x00\x03\x00\x00\x00\xfa\x00\x06\x00\x10\x01@\x00\x04\x00\x10\x00\x00"
FAIL

If the http.Transport has http2.ConfigureTransport called on it, everything works normally.
This appears to have started happening somewhere between September 5th and October 27th, since I first started seeing this behavior after a vendored dependency update. Before then, the transport worked fine regardless of whether it was using http2.ConfigureTransport or not.

Can you post a complete repro with code? It's possible that you're not using TLS. Currently, net/http's H2 support requires TLS.

I don't have a minimal repro yet but can try to work one up (if you're willing to source from some external packages I can make one pretty trivially).
However, TLS is always used.

This works just fine for me using a self-signed cert:
package main

import (
    "crypto/tls"
    "fmt"
    "net/http"

    "golang.org/x/net/http2"
)

func main() {
    http.HandleFunc("/", func(rw http.ResponseWriter, req *http.Request) {
        fmt.Printf("Got request %v\n", req.URL)
        rw.WriteHeader(204)
    })

    go func() {
        var srv http.Server
        srv.Addr = "localhost:8999"
        http2.ConfigureServer(&srv, nil)
        srv.ListenAndServeTLS(cert, key)
    }()

    t := http.DefaultTransport
    t.(*http.Transport).TLSClientConfig = &tls.Config{
        InsecureSkipVerify: true,
    }
    req, err := http.NewRequest("GET", "https://localhost:8999/foo", nil)
    if err != nil {
        fmt.Printf("NewRequest: %v\n", err)
        return
    }
    resp, err := t.RoundTrip(req)
    if err != nil {
        fmt.Printf("RoundTrip: %v\n", err)
        return
    }
    fmt.Printf("Got response %v\n", resp.StatusCode)
}

Tested with go 1.9.1 and HEAD. I haven't tried go 1.9.2, but I'm not aware of any HTTP changes in 1.9.2. Does the above program work for you?

After a bunch more testing and digging in, I think what has happened here is that due to some unrelated changes we ended up in a state where http2.ConfigureTransport was no longer being called but the TLS config for the connection was specifying a NextProtos of ["h2", "http/1.1"], leading to a situation where the underlying transport would advertise H2 support but not have an upgrade handler configured.
Sorry for the noise and thanks for helping!


Missing title on /tags

Bug Report
Environment
Zola version: 0.17.2
tabi commit: https://github.com/welpo/tabi/commit/c79407e6d7ea544a8b337e372309909a58640423
Expected Behavior
Title should be "Tags" or "All tags" when navigating to /tags
Current Behavior
/tags doesn't have a unique title
Step to reproduce
Navigate to https://welpo.github.io/tabi/tags/

Thanks for reporting this, Donovan.
I'm working on a PR which will overhaul the translation/i18n of the theme. That PR will fix this issue.


"color": true, but the toolbar has no colour button

i initialized as follows:
$('#test').wysihtml5({
"font-styles": true, //Font styling, e.g. h1, h2, etc. Default true
"emphasis": true, //Italics, bold, etc. Default true
"lists": true, //(Un)ordered lists, e.g. Bullets, Numbers. Default true
"html": false, //Button which allows you to edit the generated HTML. Default false
"link": false, //Button to insert a link. Default true
"image": false, //Button to insert an image. Default true,
"color": true //Button to change color of font
});

The colour button does not appear. Why is that?

@togoenvogue I have the same issue that you had, you did solve this issue?


how to get ownProps?

<Provider store={store}>
    <Counter color="blue" />
</Provider>

if i pass a prop color="blue" to the connected component it's not accessible inside Counter component as a prop. Only props that you return from mapToProps function are passed as constructor props.
Redux passes properties as ownProps as the second argument of mapToProps function.
Is it missing from redux-zero or am i doing something wrong ?

@malbernaz do you have an elegant way to handle this?

We pass ownProps as the second argument for mapToProps as well. But this props should be accessible inside a connected component. Maybe this is a bug. @Ganesh could you show us how you are connecting your component?

just tried to recreate it on a sandbox and it works, so probably it's the late hours to blame.
Would be good to have the API documented somewhere, because i only found this searching through redux documentation. It's not even in the examples.
thanks for redux-zero, i love the simplicity

This is actually not working @Gamesh. I have identified the bug and our connect HOC is in fact not getting the props passed to it in our latest release.
I'll submit a PR tonight to fix that. Please hang on!
cc @matheusml

#82 solves this. @matheusml: waiting for you to merge it.

thanks for double checking and fixing 👍


CheckboxListTile setState not working

Steps to Reproduce
I have a PopupMenuButton with PopupMenuItems which have an AnimatedBuilder as a child with a CheckboxListTile built.
Clicking the row of the Checkbox does not set the State automatically, which seems to be as designed. But calling setState will not rebuild the view, therefore the Checkbox is not visibly selected (Even tough it's set correctly). Reopening the PopupMenu will then display the Checkbox checked.
I also have RadioListTile which have the same hierarchy as the CheckboxListTile. Clicking one of these works as expected, this also rebuild the Checkboxes which are shown correctly afterwards.

  @override
  Widget build(BuildContext context) {
    var sfo = widget.searchFilterSortOptions;

    return PopupMenuButton<dynamic>(
        icon: Icon(SSAIcons.FILTER),
        itemBuilder: (BuildContext context) {
          var list = List<PopupMenuEntry<dynamic>>();

          list.add(PopupMenuItem(
              value: null,
              child: new AnimatedBuilder(
                  child: new Text("Gruppierung und Filter", style: TEXT_GRAY),
                  animation: _selectedItem,
                  builder: (BuildContext context, Widget child) {
                    return new ListTile(title: Text("Gruppierung und Filter",style: TextStyle(fontWeight: FontWeight.bold)));
                  })));

          for (Filter f in sfo.availableFilters) {
            list.add(PopupMenuItem(
                value: f,
                child: new AnimatedBuilder(
                    child: new Text(sfo.getNameForBase(f, context), style: TEXT_GRAY),
                    animation: _selectedItem,
                    builder: (BuildContext context, Widget child) {
                        return new RadioListTile<BaseSortFilter>(
                            value: f,
                            groupValue: _selectedItem.value,
                            title: child,
                            controlAffinity: ListTileControlAffinity.trailing,
                            onChanged: (BaseSortFilter value) {
                              _selectedItem.value = value;
                              sfo.setActiveSort(value);
                              widget.selectedCallback(sfo);
                              Navigator.of(context).pop();
                            });
                    })));
          }

          list.add(PopupMenuDivider());

          if (sfo.displayLastEdited || sfo.displayCreator) {
            if (sfo.displayLastEdited) {
              list.add(PopupMenuItem(
                  value: sfo.lastEdited.active,
                  child: new AnimatedBuilder(
                      child: new Text(sfo.getNameForBase(sfo.lastEdited, context), style: TEXT_GRAY),
                      animation: _selectedItem,
                      builder: (BuildContext context, Widget child) {
                        return new CheckboxListTile(
                            value: sfo.lastEdited.active,
                            selected: sfo.lastEdited.active,
                            title: child,
                            controlAffinity: ListTileControlAffinity.trailing,
                            onChanged: (bool value) {
                              setState(() {
                                sfo.lastEdited.active = value;
                                widget.selectedCallback(sfo);
                              });
                            });
                      })));
            }

            if (sfo.displayCreator) {
              list.add(PopupMenuItem(
                  value: sfo.creator.active,
                  child: new AnimatedBuilder(
                      child: new Text(sfo.getNameForBase(sfo.creator, context), style: TEXT_GRAY),
                      animation: _selectedItem,
                      builder: (BuildContext context, Widget child) {
                        return new CheckboxListTile(
                            value: sfo.creator.active,
                            selected: sfo.creator.active,
                            title: child,
                            controlAffinity: ListTileControlAffinity.trailing,
                            onChanged: (bool value) {
                              setState(() {
                                sfo.lastEdited.active = value;
                                widget.selectedCallback(sfo);
                              });
                            });
                      })));
            }
            list.add(PopupMenuDivider());
          }

          list.add(PopupMenuItem(
              value: null,
              child: new AnimatedBuilder(
                  child: new Text("Mehr Filter", style: TEXT_GRAY),
                  animation: _selectedItem,
                  builder: (BuildContext context, Widget child) {
                    return new ListTile(title: Text("Mehr Filter", style: TextStyle(fontWeight: FontWeight.bold)), trailing: Icon(SSAIcons.CHEVRON_LARGE_RIGHT));
                  })));

          return list;
        });
  }

Logs
No error messages thrown

flutter analyze is just giving information and one warning, all unrelated
[✓] Flutter (Channel unknown, v1.9.8-pre.54, on Mac OS X 10.14.5 18F132, locale
    en-CH)
    • Flutter version 1.9.8-pre.54 at /Users/c.wyss/Documents/Projects/flutter
    • Framework revision 16fcb83fec (6 hours ago), 2019-09-02 23:44:41 -0400
    • Engine revision e7f9ef6aa0
    • Dart version 2.5.0 (build 2.5.0-dev.4.0 36985859e4)

I have the very same problem!

same problem!

A workaround you can apply is to rebuild the whole tree when updating the state of a checkbox in the list. But this is so heavy! Definitely need a proper solution for this!!!

I replicated this issue on v1.9.1+hotfix.6
Do you know in what version it was added?

hey guys, any progress?

You can wrap the CheckboxListTile in a StatefulBuilder widget and call the second argument of the builder instead of setState.
For example,
PopupMenuButton(
            onSelected: (_) {},
            itemBuilder: (_) => [
                  PopupMenuItem<bool>(
                    child: StatefulBuilder(
                      builder: (context, _setState) => CheckboxListTile(
                        value: Model.instance().widgetIndex == index,
                        onChanged: (newValue) {
                          _setState(() => Model.instance().widgetIndex =
                              newValue ? index : 0);
                        },
                      ),
                    ),
                  )
                ],
            icon: Icon(Icons.more_vert))

You can wrap the CheckboxListTile in a StatefulBuilder widget and call the second argument of the builder instead of setState.
For example,
PopupMenuButton(
            onSelected: (_) {},
            itemBuilder: (_) => [
                  PopupMenuItem<bool>(
                    child: StatefulBuilder(
                      builder: (context, _setState) => CheckboxListTile(
                        value: Model.instance().widgetIndex == index,
                        onChanged: (newValue) {
                          _setState(() => Model.instance().widgetIndex =
                              newValue ? index : 0);
                        },
                      ),
                    ),
                  )
                ],
            icon: Icon(Icons.more_vert))

This is what I did like 1 month ago, and it works! I was always forgetting to post it here tho...

I believe that @richardrobinson0924's fix is the correct one, so I'm going to close this issue. Thank you, and thanks to all for using Flutter!

same problem! i used checkbox in bottom sheet setState is not working


cannot delete email

Hi,
I delete my email in vmail but it is not deleted on server. Anytime I rerun vmail, I get all those deleted email again. Please help.
Thanks,
Ngan

@hoangngan82, I hope that the issue is resolved. If not, please see this related issue.

Hi,
First, I would like to thank you all for your very cool software.
I can delete emails now. The reason was that when I ran
vmail -g
the following error occur
Selecting [Gmail]/["Sent Mail"]
/usr/lib/ruby/2.3.0/net/imap.rb:1196:in get_tagged_response':  Unknown Mailbox: [Gmail]/["Sent Mail"] (Failure) (Net::IMAP::NoResponseError)         from /usr/lib/ruby/2.3.0/net/imap.rb:1250:in block in send_command'
from /usr/lib/ruby/2.3.0/monitor.rb:214:in mon_synchronize'         from /usr/lib/ruby/2.3.0/net/imap.rb:1232:in send_command'
from /usr/lib/ruby/2.3.0/net/imap.rb:454:in block in select'         from /usr/lib/ruby/2.3.0/monitor.rb:214:in mon_synchronize'
from /usr/lib/ruby/2.3.0/net/imap.rb:452:in select'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/contacts_extractor.rb:27:in block in extract'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/contacts_extractor.rb:17:in open'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/contacts_extractor.rb:23:in extract'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/options.rb:79:in block (2 levels) in parse'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/options.rb:78:in open'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/options.rb:78:in block in parse'         from /usr/lib/ruby/2.3.0/optparse.rb:1061:in initialize'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/options.rb:22:in new'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/options.rb:22:in parse'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail/options.rb:18:in initialize'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail.rb:44:in new'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail.rb:44:in options'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail.rb:48:in config'
from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/lib/vmail.rb:21:in start'         from /home/hoangngan/.gem/ruby/2.3.0/gems/vmail-2.9.5/bin/vmail:14:in <top (required)>'
from /home/hoangngan/.gem/ruby/2.3.0/bin/vmail:23:in load'         from /home/hoangngan/.gem/ruby/2.3.0/bin/vmail:23:in '
In order to temporarily fixed it, I modified /path/to/lib/vmail/defaults.rb by
changing ['Sent Mail'] to 'Sent Mail' (removing square brackets). This is of
course is not consistent with the rest of defaults.rb file but it makes
vmail -g
work. However, it screwed up delete command. When I changed defaults.rb to
its original version, deleting works flawlessly.
Thanks,
Ngan
On Sun, Jan 24, 2016 at 11:20 PM, Alex<EMAIL_ADDRESS>wrote:

from: Alex<EMAIL_ADDRESS>date: Sun, Jan 24 11:20 PM -08:00 2016
to: danchoi/vmail<EMAIL_ADDRESS>cc: Ngan Nguyen<EMAIL_ADDRESS>reply-to: danchoi/vmail<EMAIL_ADDRESS>subject: Re: [vmail] cannot delete email (#198)
@hoangngan82, I hope that the issue is resolved. If not, please see this related issue.

Reply to this email directly or view it on GitHub:
https://github.com/danchoi/vmail/issues/198#issuecomment-174424450

--
Hoang-Ngan Nguyen


Adds label value functionality for options prop

Why was this closed? This seems like it would be useful functionality.


CDAP-13654 remove unused dataset fields from predictor plugin

Also removing some classes that were leftover from when training
took place in a plugin instead of a service.

LGTM


Update editable_text.dart

The typo of "Empty" fixed to "Empty"

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The current revisions of this PR and #120369 propose the same one-item series of commits:

0c9270641c5ae224c5862b9f8f3bf68a674c3fac Update editable_text.dart

Actually, sorry that I didn't notice this before, but there is another earlier PR that makes the same change: https://github.com/flutter/flutter/pull/120062
If that PR becomes stale then I'll reopen this one.  Thanks for the PR and sorry for the duplicate work here!

Guys thanks for the response it was fun contributing to flutter
Actually this is my 1st contribution 😀

Actually, sorry that I didn't notice this before, but there is another earlier PR that makes the same change: https://github.com/flutter/flutter/pull/120062
If that PR becomes stale then I'll reopen this one.  Thanks for the PR and sorry for the duplicate work here!

Hey I saw the luci flutter check failure in the issue u referenced here https://github.com/flutter/flutter/pull/120062
Where as it is solved in mine can u please show me some reference article to read more about it?

@MrChinmay03 That check indicates whether Flutter's master branch is currently passing all of its tests or not.  It should be the same across all framework PRs, but maybe it was just out of date in this case.  Most of our information about this kind of thing is in the wiki, but I'm not sure if this is covered specifically. https://github.com/flutter/flutter/wiki/Tree-hygiene


AzureAD

Add azureAD support as an auth provider
Issue: https://github.com/rancher/rancher/issues/12942

The code looks good, but we need vendor and trash.conf in a proper state to get a green build.
I did have some feedback on the types PR (renaming fields) that will have a minor impact, but that's it.

LGTM


drivers: dmic: clear SOFT_RESET bit to ACE as well

Clearing sof-reset bit applies to ACE as well. And when releasing a paused stream, unmuting mic is necessary. Without unmuting there will be no input data after resume.
fixes: https://github.com/thesofproject/sof/issues/6723

nice find @ranj063 @fredoh9 !

@dnikodem can you run your internal tests with this? I remember this was like this because mtl was not very happy without it...

Sure. I have asked our validation to help with this. I will let you know when the results are ready. Thanks

@juimonen @fredoh9 @dnikodem using FW from thesofproject/sof#7332, I checked the DMIC on MTL and found no regression. Everything seems fine

@wszypelt thanks! then I'm ok with this PR.


As a developer I want to read up on and decide on a library to add login functionality

Acceptance criteria:

Discuss within the group how we want to do it
Write notes on the pros and cons of the chosen one (used for documentation in the project)

Notes:
Chosen one: Azure AD B2C + GitHub (Microsoft Identity Platform)
seems like the balance between using already provided things and our own code.
lots of help to get but still flexibility for us as developers
Scalability/extensibility - B2C are more stable and needs less maintenance as it grows.
cons:

more functionality and therefore more complexity
bigger learning curve
the user accounts and their data are not in a local database and thus we lose some control


Typo with dashes in cli commands

Type of issue
Typo
Feedback
If I'm not mistaken, they should only have 2 dashes each:

Best Regards!
Page URL
https://learn.microsoft.com/en-us/cli/azure/cheat-sheet-onboarding#using-reference-commands
Content source URL
https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/docs-ref-conceptual/cheat-sheet-onboarding.md
Author
@dbradish-microsoft
Document Id
e5d2a07f-afd9-e985-abda-0840ac5f59b0

@Glavyanov
Thanks for your feedback! We will investigate and update as appropriate.

@Glavyanov
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@Glavyanov, this has been fixed in PR 4850. Thanks for bringing this to our attention.


Unit test with Jest with Object spread syntax fails with SyntaxError

Version
v2.4.5
Reproduction link
https://github.com/nuxt/create-nuxt-app
Steps to reproduce

Create a fresh Nuxt project with npx create-nuxt-app test
Enable Jest
Open the sample Logo.spec.js
Add a Object spread syntax e.g. const test = { ...{foo: 'bar', baz: 'qux' } }
Run the test with npm run test

What is expected ?
Test to run properly
What is actually happening?
Test fails with
({"Object.":function(module,exports,require,__dirname,__filename,global,jest){import defineProperty from "./defineProperty";
SyntaxError: Unexpected identifier
Additional comments?
This is because Nuxt's babel-preset-app configures @babel/plugin-transform-runtime to always use ES modules. Jest is by default configured to not transform node_modules dependencies. So, while executing the runtime helper like the ObjectSpread helper, Jest runs into ES imports. Which it cannot understand and result in SyntaxError.
Vue Cli tackles this by using process.env.VUE_CLI_BABEL_TRANSPILE_MODULES which is set to true when running test, therefore disabling the use of ES modules for @babel/plugin-transform-runtime.
For now, the easy fix for me was to not use @nuxt/babel-preset-app in .babelrc

This bug report is available on Nuxt community (#c8771)

First its issue with create nuxt app, not nuxt. So please submit to the right repository :)
Second there a few fixes for it in cna already. e.g. use of jest 24 and remove of nuxt/babel-preset-app
https://github.com/nuxt/create-nuxt-app/pull/193

rude answer...


[FEA] Update GpuHashJoin and GpuBroadcastHashJoin to use OOM retry framework

Is your feature request related to a problem? Please describe.
This is very similar to https://github.com/NVIDIA/spark-rapids/issues/7254
Describe the solution you'd like
For join operators we can run into situations where one or both sides of the join needs to be completely in GPU memory while we stream through the other side of the join.  We are working on some out of core fixes to try and help with these situations, but either way at some point we are likely going to need more memory than we get in the default lease.
We should do the same tasks as with GpuWindowExec.

[ ] Combine the join with any GpuCoalesceBatchExec nodes that would precede it.
[ ] Do a high water mark estimation on how much memory will be needed in the worst case to complete the join, given the input sizes.
[ ] Request a higher lease if needed
[ ] Experiment with RMM high water mark tracking to see how good our estimate is, and verify that we are not missing something
[ ] Write scale testing to verify that our estimation code does not under estimate the amount of memory needed.

This issue is being used for join oom retry work in 23.04.  We will file additional issues for work in future releases.
This covers two OOM failures we were seeing when testing with low memory.
#7930 adds retrying without splits for cases where we were running out of memory on Table.gather calls (JoinGatherer.gatherNext)
#7902 adds retrying without splits for cases where we were running out of memory during SplittableJoinIterator.createGatherer, typically when creating the gather maps.