help avoiding unnecessary recompilation

In serac, whenever I touch any of our cmake files, axom (0da8a5b1b, built alongside serac with add_subdirectory) also gets reconfigured since it's one of our dependencies.
I'm looking for a way to avoid paying this cost each time I interact with our build system. Additionally, when setting some of the optional  components to OFF (we don't even use slam, quest, primal, klee, mint), linking against the axom target seems to still bring them them in on the link line, leading to compilation errors. The linkage error may be specific to serac, that part is still unclear to me.
Is it possible to prevent axom from recompiling everything when making a change to a CMake file?

Here is one potential CMake project implementation for a library (e.g. axom) that optionally builds some combination of components based on user-specified options: library_of_components.zip
Making changes to the CMake project and reconfiguring doesn't result in a complete rebuild. If a user previously built this library, and then decides to turn on one of the optional components, only that new component library is compiled (object files from the other components are reused, rather than recompiled).

It is my understanding that there are two parts to this issue and I will address them separately.

 The options are documented here:
https://axom.readthedocs.io/en/develop/docs/sphinx/quickstart_guide/config_build.html#cmake-configuration-options
We cannot turn off components in Serac due to what Serac requires but more to the point Tribol requires all of Axom. I did create two PRs that limit the inheritance of the targets so, while they are all built, it does limit the need to link them up the chain.

Touching CMake files causes rebuilding of part of Axom

This is more tricky. I was able to confirm that in Serac's Codevelop build that part (not all) of Axom is rebuilt when you only touch a CMake file. This does not happen in straight Axom though.
I have looked over all the things we do to make the Codevelop build work and nothing stands out in touching or reconfiguring files which is usually the case.
If you can figure out why Serac's codevelop build triggers a partial rebuild, I would be glad for a fix.
But for now this should be closed because its not an Axom issue.

I have looked over all the things we do to make the Codevelop build work and nothing stands out in touching or reconfiguring files which is usually the case.
If you can figure out why Serac's codevelop build triggers a partial rebuild, I would be glad for a fix.

ninja will tell you why it's recompiling individual files:
serac/build % ninja -d explain
...
ninja explain: axom/axom/mint/CMakeFiles/mint.dir/fem/FiniteElement.cpp.o is dirty
ninja explain: output axom/axom/mint/CMakeFiles/mint.dir/mesh/internal/MeshHelpers.cpp.o older than most recent input /home/sam/code/serac/build/mfem/mfem.hpp<PHONE_NUMBER>663511236 vs<PHONE_NUMBER>103460827)ninja explain: axom/axom/mint/CMakeFiles/mint.dir/mesh/internal/MeshHelpers.cpp.o is dirty
ninja explain: output axom/axom/mint/CMakeFiles/mint.dir/mesh/CurvilinearMesh.cpp.o older than most recent input /home/sam/code/serac/build/mfem/mfem.hpp<PHONE_NUMBER>475511608 vs<PHONE_NUMBER>103460827)
...

It seems mfem is just regenerating mfem.hpp every time and many of axom's sourcefiles include it, so they end up getting recompiled every time. A simple fix (in mfem) would be to only emplace the generated mfem.hpp file into the build directory if its contents are different than what's there already.


Update read tracking for ITS

ITS has a few pre-processing steps that are run, including removal of reads with N's and using cutadapt prior to a final filterAndTrim step.  Due to this, initial read counts and some of the intermediate processing steps are missing in the final read tracking report.

Need an example ITS data set prior to tackling this one

This is essentially implemented, closing ticket.


Thank you !!!

This package is incredible !!!
Having it will change and improve my workflow for short documents, documentation and publications.

I'm glad it helps!


Mini.files closing explorer after 1 second when using custom mappings.

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.files
Description
After updating to latest version of the plugin I have problems with the explorer closing itself after maybe 1 second after moving one step in the tree (in or out).
I have remapped the keys so it looks like this:
	{
		-- File manager
		"echasnovski/mini.files",
		version = false,
		config = function()
			require("mini.files").setup({
				mappings = {
					go_in_plus = "<Right>",
					go_out_plus = "<Left>",
					synchronize = "<C-s>",
				},
			})
		end,
		event = "VeryLazy",
	},

This worked perfectly before I updated.
I tried looking at checkHealth to see if there were any conflicts but found nothing to explain this.
If I try using the default movements (h and l) it works as expected.
I tried using just go_in and go_out and it makes no difference.
Neovim version
0.10.2
Steps to reproduce

nvim -nu minimal.lua
...

Expected behavior
That using my mappings does not close the explorer until the last node is a file or I exit the explorer.
Actual behavior
The explorer closing itself after maybe 1 second after moving one step in the tree (in or out).

Thanks for the issue!
I can not reproduce. With provided config any "in" and "out" movement works as expected. Closing after 1 second probably means that some window got closed when it wasn't supposed to.
I'd ask you for more information:

Does any of :nmap <Left> or :nmap <Right> show anything not related to 'mini.files' when executed inside active explorer?
Do you know the commit (either from 'mini.nvim' or standalone 'mini.files') at which you had everything work?
Can you reproduce this with  only 'mini.files' set up?

I posted this and was going to edit with the reproduction steps (you are too quick to answer!) and... I can't reproduce it when I do as minimal as possible (using vanilla NvChad with just mini.files set up).
So, it seems there is something that is highjacking or also uses left and right that causes it.
The commit where it worked is this one: 1b5ada9d3a0df36cfbf7f50a314646c0673b8c87
I'll check out the :nmap on left and right. Thanks for the tip.
I also think we can close this as it's not an issue with mini.files as I can't reproduce with a clean slate.

I ran the nmap command on an open explorer and got the following:

and the same for Right but "Go in entry plus" instead of course.
I ran the nmap on a file with no explorer open and I get "No mapping found".
I'm thinking that maybe I want to start over with a clean NvChad and I'll lift everything over as if I just started from that one instead of all the upgrading I've done over the years.

I posted this and was going to edit with the reproduction steps (you are too quick to answer!) and...

Sorry :shrug: :smile:

The commit where it worked is this one: 1b5ada9d3a0df36cfbf7f50a314646c0673b8c87

Well, there was a change in how windows are handled, but I can't see how this can break custom mappings. Definitely not without reproduction steps, sorry :( And also mappings output seems to be ok.

Closing for now. Feel free to post reproduction steps here if you manage to find them.

...and I managed to fix the issue I had!
It was not related at all to mini.files. It was also not related to NvChad.
The issue was that my chadrc (settingsfile for NvChad) required the mappings file. It used to have to do that. Then a lot has changed and I do not need to require the mappings anymore (I realized this when I ran NvChad out of the box).
So I guess the file was read automatically and then I also tried requiring it.
This issue can be closed, buried and forgotten I think.
I just want to give massive thanks to you @echasnovski for the mini plugins, I use a few of them and they are awsome. Also that you're so darn quick to answer. <3


gfmpw1 run-precheck Makefile target uses -it, breaks github actions

Since commit 9ee2462d8ac93ed725feda83f685b91f28e039a5 by @marwaneltoukhy
-it has been added to the docker precheck target.
What is the reasoning behind that? It means the precheck now fails in a github action.

It was added so that docker runs interactively so you can kill the process if needed, when running locally.

interesting. That doesn't actually work for me, I have to open a new terminal and docker kill it. Is there a way where it could tell if it has terminal and only then uses -it? For now I'm just removing -it so I can run it as a GH action: https://github.com/mattvenn/project0_test/actions/runs/6878330117/workflow#L43


How can get list of layer ?

Hi guys
How can i get list of layer and see name of active layer ?

Have a look at the following code.
For Each layer As ILayer In Map.Layers 'this gets you all layers inside your map
            If layer.IsSelected Then 'this indicates whether the layer is currently selected
                Dim legendText As String = layer.LegendText
                Dim fl As IFeatureLayer = TryCast(layer, IFeatureLayer)
                If fl IsNot Nothing Then
                    Dim fileName = fl.DataSet.Filename
                End If
           End If
Next

Not sure what name you want to get. There is layer.LegendText (that is shown in legend), layer.Name (not sure whether that is always set) and if you have a FeatureLayer there is also DataSet.Name (not sure whether that is always set) and DataSet.FileName.

@ZimaSystem If your questions was answered please close the issue.

It appears that Map.Layers gets a mixed list of MapGroups and individual map layers, so if one needs to get all of the single map layers, one would need to use that 'TryCast' to differentiate between MapGroup and individual map layers. I think ILayer is parent to both MapGroup and IMapFeatureLayer.


Bug: DTOs can't serialize as kebab-case

Description
I am attempting to use the DTO rename_strategy to supply a function that implements a transformation from snake-case into kebab-case. Unfortunately I'm getting this error:
TypeError: __slots__ must be identifiers

URL to code causing the issue
No response
MCVE
Largely derived and adapted from https://docs.litestar.dev/latest/tutorials/dto-tutorial/01-simple-dto-exclude.html#our-first-dto
from __future__ import annotations

from dataclasses import dataclass

from litestar import Litestar, get
from litestar.dto import DataclassDTO, DTOConfig

def kebab_case(name: str) -> str:
    return name.lower().replace("_", "-")

@dataclass
class Person:
    full_name: str
    age: int
    email_address: str

class ReadDTO(DataclassDTO[Person]):
    config = DTOConfig(rename_strategy=kebab_case)

@get("/person/{name:str}", return_dto=ReadDTO)
async def get_person(name: str) -> Person:
    # Your logic to retrieve the person goes here
    # For demonstration purposes, a placeholder Person instance is returned
    return Person(full_name=name, age=30<EMAIL_ADDRESS>

app = Litestar(route_handlers=[get_person])

Steps to reproduce

Run sample code above with something like uvicorn bug:app
Observe the app fail to start with the error described in the Logs

Note that if .replace("_", "-") is removed from the rename-function, the application boots fine. However it's not then implementing a kebab-case transformation anymore.
Screenshots
No response
Logs
File "/path/to/project/bug.py", line 29, in <module>
    app = Litestar(route_handlers=[get_person])
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/app.py", line 450, in __init__
    self.register(route_handler)
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/app.py", line 625, in register
    route_handler.on_registration(self)
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/handlers/http_handlers/base.py", line 494, in on_registration
    super().on_registration(app)
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/handlers/base.py", line 526, in on_registration
    self.resolve_return_dto()
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/handlers/base.py", line 485, in resolve_return_dto
    return_dto.create_for_field_definition(
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/dto/base_dto.py", line 185, in create_for_field_definition
    backend_context[key] = backend_cls(  # type: ignore[literal-required]
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/dto/_backend.py", line 112, in __init__
    self.transfer_model_type = self.create_transfer_model_type(
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/dto/_backend.py", line 213, in create_transfer_model_type
    struct = _create_struct_for_field_definitions(struct_name, field_definitions)
  File "/path/to/project/.venv/lib/python3.10/site-packages/litestar/dto/_backend.py", line 807, in _create_struct_for_field_definitions
    return defstruct(model_name, struct_fields, frozen=True, kw_only=True)
TypeError: __slots__ must be identifiers

Litestar Version
litestar 2.4.2
uvicorn 0.24.0.post1
msgspec 0.18.4
python 3.10.13
Platform

[X] Linux
[ ] Mac
[ ] Windows
[ ] Other (Please specify in the description above)

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh Litestar dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Thanks for the report @harmonic-jamie - I think this will require some refactoring of how we handle field renaming.

Originally, we rolled our own renaming framework in order to support multiple transfer model types (pydantic and msgspec). Now that we only support msgspec transfer models we should be using their renaming api. Hopefully this would mean we'd be able to remove a chunk of code, and fix issues like this at the same time.

Thanks @peterschutt - sounds like a lot of effort for something that might reasonably not be considered a high-priority.
Will leave this here to get picked up at some point but I appreciate it might be a while before this slots in.

No worries, and thanks for your PR! Sorry it didn't get merged, but it was nice to get that functionality for free via msgspec. Contributions are always welcome, so feel free to take a bite at any other issues. Cheers.


Use / format for id params

The REST API expects an id to passed with the slash format, eg http://example.dev/wp-json/wp/v2/posts/10 (http://example.dev/wp-json/wp/v2/posts?id=10 won't work as expected).
I think we can automatically use this format for any parameter called id (it's quite standard to use this method).

This methodology is called REST  and should do a couple things.

Work and response based on the HTTP verb send by the request.
Increase the version of the API from v1 to v2 so old applications can operate with no breaking changes on v1 of the endpoints.

This doesn't affect the endpoint version. Do you mean we should increment the version to 2 for the routes endpoint?

Yes all the ones that are going to work with REST should change from v1 to v2 in order to allow backwards compatibility on either of those versions instead of introduce the changes on v1. That’s why each endpoint has the version numbers in order to allow space to introduce changes that are not compatible.

If you ever need to break compatibility with new endpoints, you can then bump this to v2..

Ref. http://v2.wp-api.org/extending/adding/#namespacing http://v2.wp-api.org/extending/adding/#namespacing

On May 23, 2016, at 6:40 PM, Adam Fenton<EMAIL_ADDRESS>wrote:
This doesn't affect the endpoint version. Do you mean we should increment the version to 2 for the routes endpoint?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub https://github.com/moxie-lean/ng-cms/issues/25#issuecomment-221127390

Yes, but this is the frontend. The backend will use a different endpoint namespace altogether, wp : /wp-json/wp/v2/posts. Agree the frontend modules could jump a major version so ng-cms moves to v1.0.0

Correct. I think this should be editable via a callback to allow flexibility as happens with $.get from jQuery


[BEAM-14310] [Website] bug home playground

[BEAM-14310]

add container to iframe
add js script to fix bug with scroll of iframe using css prop pointer-event
add styles to iframe

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

R: @nausharipov

@pcoet this is a fix for scrolling issue - the scrolling was "stuck" when on Playground section, can you please review? :)

thanks!


supports_value_expectations? breaks have collection matcher for should one-liner syntax

Please, I beg of you, let's not rehash RSpec grammar wars.  The is_expected.to syntax is newer, but the should one-liner syntax is supported and should behave appropriately.
Subject of the issue
As of the deprecation of implicit block expectation syntax, and introduction of the check for use of this syntax (version 3.11.0), the have matcher (from rspec-collection_matchers) no longer works properly with an explicit subject.  E.g.:
  describe "#wibbles" do
    subject { foo }
    it { should have(3).wibbles } # => does not work
    it { is_expected.to have(3).wibbles } # => works
  end

For the case with the should syntax this results in:
NoMethodError: undefined method supports_value_expectations?' for #Foo:0x00007ffdadd0e2a8`
If you change the subject thusly:
  describe "#wibbles" do
    subject { foo.wibbles }
    it { should have(3).items }
  end

Now passing examples will work properly, but failing examples will result in a message like this:
expected 3 supports_value_expectations?, got 6
The most common use of the have matcher in my experience is testing validations in Rails:
  describe "validations" do
    subject { wibble }

    context "with an empty name" do
      before { wibble.name = "" }
      it { should have(1).error_on(:name) }
    end
  end

Your environment

Ruby version: 3.0.3
rspec-expectations version: 3.11.0

Steps to reproduce
class Foo
  def wibbles
    [1, 2, 3]
  end
end

RSpec.describe Foo do
  let(:foo) { Foo.new }

  describe "#wibbles" do
    subject { foo }
    it { should have(3).wibbles }
    it { should have_exactly(3).wibbles }
  end
end

Expected behavior
For examples that should pass I would expect passing results.  For examples that should fail I would expect an accurate failure message.
Actual behavior
In the first example given above, any examples using the have matcher throw an exception.  In the second example, failing examples give an inaccurate failure message.

the have matcher (from rspec-collection_matchers)

Transferred to rspec-collection_matchers, its likely this just needs to implement supports_value_expectations?, want to open a PR for that?

Apologies, I've been traveling.
Yes, I'm happy to start contributing again if you'd like.  I'll take a look in the next day or so.

Since, I've upgraded to rails-7 and upgraded to rspec-rails-6.0.0.rc1, I'm having the same issue.
Most of my tests are now failing with NoMethodError:                                                                                undefined method supports_value_expectations?' for #SomeActiveModelObject:0x0000556b6f023250`

@pirj if you now check out the git repo and run bundle install (right even that fails), then bundle exec cucumber you see that the tests fail.

To provide a bit more context: I wanted to update the RPM packaging of puppet-lint but that depends on rspec-collection_matchers. There the test suite is ran on build, but currently failing.
However, I have instead opened a PR to drop the dependency: https://github.com/puppetlabs/puppet-lint/pull/149. That will be easier.

https://github.com/rspec/rspec-collection_matchers/issues/51 is the full report of the failing tests.

Fixed and released in 1.2.1


Fix Slerp C# docs and add test cases for vectors in the same direction

See #57786 and #53928 for more information.

Thanks!


Considering refactoring to a "workspace" organization

RustDDS is current one BIG crate. This means that when projects rely on RustDDS they must build all the code in one big step. You can increase parallelism of cargo's build, potentially give library users more fine grain access to functionality, and the purpose of dependencies much more clear.
You would start by replacing the root Cargo.toml with a workspace definition. All the nested crates (I call them subcrates but I don't think that's a popular term) can continue to exist in this repo no problem.
How could you "chunk" up the RustDDS?
/
  Cargo.toml # the workspace one
  /rustdds-serialization/Cargo.toml
  /rustdds-messages/Cargo.toml
  /rustdds-network/Cargo.toml
  ... and so on ...

then in the root Cargo.toml:
[workspace]
default-members = [
	"rustdds-serialization",
        "rustdds-messages,
        "rustdds-network"
]

and rustdds-serialization/Cargo.toml:
[package]
name = "rustdds-serialization
version = "0.1.0"
authors = ["..."]
edition = "2021"

[dependencies]
# only the SPECIFIC dependencies for the serialization functionality

and cargo can roll up all the transitive dependencies of your subcrates and create a Cargo.lock at the root.
All my rust projects have transitioned to this style, it makes builds much faster and small crates have nice little test suites.

That is a good suggestion.
However, before doing this, the RustDDS codebase needs to be reviewed and quite likely some code should be moved between current modules to make a more sensible module structure. Otherwise, the dependencies between subcrates could end up very convoluted.

Wrote down some reorganization ideas in #184 .


Asset Loader

Load all assets behind the loading screen. Do not allow the loading screen to disappear until all assets have been successfully created.

Uploaded with the game template #3.


DRILL-7110: Skip writing profile when an ALTER SESSION is executed

Allows (by default) for ALTER SESSION SET <option>=<value> queries to NOT be writen to the profile store. This would avoid the risk of potentially adding up to a lot of profiles being written unnecessarily, since those changes are also reflected on the queries that follow.

@sohami / @arina-ielchiieva I've made the minor changes. Please review and let me know if anything else is missing.

LGTM

+1, please squash the commits.


Automated cherry pick of #3999: cloudregion cities filter

Cherry pick of #3999 on release/2.13.
#3999: cloudregion cities filter

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@efad765). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #4000   +/-   ##
==============================================
  Coverage                ?   6.94%
==============================================
  Files                   ?     505
  Lines                   ?   85040
  Branches                ?       0
==============================================
  Hits                    ?    5904
  Misses                  ?   78634
  Partials                ?     502

Flag
Coverage Δ

#aFlag
6.94% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/skus_tools.go
0% <0%> (ø)

pkg/compute/models/cloudregions.go
1.89% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efad765...ff4b5b9. Read the comment docs.

/lgtm
/approve


Websocket support

Hi all, I'd be very interested to see how we could tackle websocket support as there are many possible options.
For example, we could recommend that such functionality should be offloaded to Pusher or we could document how to use a socket.io cluster. If you're to use Websocks, once your app gets big you'll want to account for a solid scaling setup (Redis etc.). Also, see Sailsjs for example who make it very easy to utilise Websocks on the client. Happy to discuss & assist wherever I can, thanks.

+1

+1

+1

What about SocketCluster?

@jbruni worth checking, i will look into it, once i will start with the Socket provider

Closing and added it to the Roadmap on trello https://trello.com/b/yzpqCgdl/adonis-for-humans

is it already added  ?

When is the implementation planned?

@ntvsx193 @mubbashar it is already implemented
http://adonisjs.com/docs/3.2/websocket


vagrant: use libarchive lib from Nix

Motivation for this change
We currently already replace the embedded bsdtar binaries with the
corresponding ones from Nix. However, we also need to replace the
libarchive shared library to prevent version mismatches between the
embedded library and the Nix binaries.
Fixes #17300, although I'm not sure how hacky this is (is the LD_LIBRARY_PATH supposed to handle this?)
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Also expose version on the derivation and use environment variables
to make overriding the derivation easier.

This looks good for now, but eventually we should move to building the Gem project instead of just using the .deb file.

Awesome 🎉
Thank you for your commit 👏


fix test

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to @o2xp/react-datatable?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code improvement

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mike Trieu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add net8.0 configurations and conditional compilation

Added build configurations for .net 8.0.
If one of the two -net8.0 configurations is selected, framework target and relevant dependencies are switched to 8.0. Otherwise, the old values are used.
Addresses #254

There are, of course, other ways to achieve multi-targeting.
I chose the method I did because there was an assembly with its version in its namespace name (the Basic.Reference.Assemblies.Net70 package), which needs to be swapped out and conditional compilation applied for the one line where it is used, and this was just a simple way to do it.
Another option I just realized is available would be to use a global using to alias the reference to Net70 or Net80 as something else (like NetReferenceAssembly or something), so that conditional compilation is entirely handled by msbuild and preprocessor directives in the C# aren't necessary. But that's a newer language/framework feature, so that may not be desirable, for reasons of backward-compatibility for users building on or targeting pre-7.0 .net SDKs.
That would look something like this in the .csproj, replacing the current Choose block:
<Choose>
    <When Condition="'$(Configuration)'=='Debug-net8.0' Or '$(Configuration)'=='Release-net8.0'">
      <PropertyGroup>
        <TargetFramework>net8.0</TargetFramework>
        <DefineConstants>$(DefineConstants);Building_For_Dotnet_8</DefineConstants>
      </PropertyGroup>
      <ItemGroup>
        <PackageReference Include="Basic.Reference.Assemblies.Net80" Version="1.4.5" />
        <PackageReference Include="System.CodeDom" Version="8.0.0" />
        <Using Include="Basic.Reference.Assemblies.Net80">
          <Alias>NetReferenceAssemblies</Alias>
        </Using>
      </ItemGroup>
    </When>
    <Otherwise>
      <PropertyGroup>
        <TargetFramework>net7.0</TargetFramework>
      </PropertyGroup>
      <ItemGroup>
        <PackageReference Include="Basic.Reference.Assemblies.Net70" Version="1.4.5" />
        <PackageReference Include="System.CodeDom" Version="7.0.0" />
        <Using Include="Basic.Reference.Assemblies.Net70">
          <Alias>NetReferenceAssemblies</Alias>
        </Using>
      </ItemGroup>
    </Otherwise>
  </Choose>

And then the code on line 150 of CodeToView.cs (before this PR) would change to:
var references = new List<MetadataReference>(NetReferenceAssemblies.References.All);

Instead of the conditional preprocessor directives I added for this PR.

Note this isn't a problem for Terminal.Gui itself - just this tool, because dotnet tools are pre-packaged framework-dependent assemblies, so the framework version rules, unfortunately, are strict, for them.

Thanks! I will need to update build.yml so that it publishes to nuget correctly.
Do you know if there is any way to snip a nupkg that includes multiple framework versions (e.g. 6,7,8)?
I have done a bit of internet searching but am drawing a blank.
I can update github action to dotnet publish -c 'Release-net8.0' but it would be better if I could also support 7 and 6

I'm not entirely sure, but maybe using a <TargetFrameworks>net7.0,net8.0</TargetFrameworks> in a PropertyGroup in the csproj? 🤔
I was wondering that myself and would have done it if I knew for sure.

If your build system can make multiple runs, you could always just have it run once for each target framework.
I think 6 should work with everything I did, since global usings came about in 6.
You'd just need to add another Choose block for any references that need to be to 6-compatible packages.

If I use TargetFrameworks it isn't going to do the conditional stuff.
But maybe I could reference all the target frameworks and use Environment.Version at the saving point ViewToCode to load the right one and just reference them all.  I will have to investigate

Looks like <TargetFrameworks> will do the trick.
I have targetted only 8.0.0 reference assemblies... hopefully they will run under 7.0 too.
It seems to compile ok.

I've tagged the build with a pre-release version number -rc1 so can test that if it ships ok through CI.
Thanks for creating this PR, I have learned a cool new trick with the csproj I didn't know but if this works I think it will be simpler <3 and if not I can change back to this.
I will have to apply the same change to the v2 branch which is for supporting version 2 of Terminal.Gui which has substantial differences.

Looks like <TargetFrameworks> will do the trick.
I have targetted only 8.0.0 reference assemblies... hopefully they will run under 7.0 too.
It seems to compile ok.

I've tagged the build with a pre-release version number -rc1 so can test that if it ships ok through CI.

Great!
Just for follow-up:
If you don't specify a version in a PackageReference element, it'll pull the latest version it supports (like for the System.CodeDom package), if the package name is the same. But, I think that particular package is backward compatible with 7, anyway, because VS was even offering the upgrade for it when targeting .net7, and it did compile.
You can also use the conditional stuff along with the TargetFrameworks element, even without additional build configurations, if you use a different property on the Condition, such as NET8_0 or other symbols defined by msbuild. But, of course, that's only really necessary if one of the 8.0-versioned dependencies is incompatible with .net7.0 at compile- or run-time. I only used build configurations because it was a simple way to do it with a 100% guarantee the symbol would be declared.

Thanks for creating this PR, I have learned a cool new trick with the csproj I didn't know but if this works I think it will be simpler <3 and if not I can change back to this.

Are you referring to the Choose element? Yeah, when I learned about it a while back I immediately loved it.
It's pretty handy for making much cleaner groupings of conditional elements, for sure.  However, the Condition attribute is valid on almost every element in an msbuild file (including csproj), so you can target things as granularly as your heart desires. 😅

Oh another thing I learned around the same time I learned about Choose....
Did you know the expressions in the Condition attribute support more than just simple logical operators like that? You can even call things like EndsWith on a string, for example. It's super flexible, but the documentation is scattered at best.


Add link pointing to plan upgrade page

Allows customers to easily get to the page while they're thinking about upgrading.

Nice one @stuartmoore1023 👍


Combo 6

This concept is currently being used out in the wild, but there is no data associated with it, and it’s completely uninformative/unnecessary. Note: Seems to be investigator-added term.
Recommendation: terminate existence out in the wild

Removed


Remove version: Microsoft.Azure.CosmosEmulator version 2.14.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://cosmosdbportalstorage.azureedge.net/emulator/2021_06_15_2.14.0-6822d34e/azure-cosmosdb-emulator-2.14.0-6822d34e.msi
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


Mirkat implementation

Just wondering if there are plan to implement the two methods below. They can also be used for longitudinal microbiome analysis with a given distance matrix.
https://www.ncbi.nlm.nih.gov/pubmed/25957468
https://academic.oup.com/bioinformatics/article/32/17/2618/2450751/PERMANOVA-S-association-test-for-microbial

both would be great additions — one problem is that both are only in R, so we would need to wrap the R packages in QIIME2 (this is possible; q2-dada2 is a good example).

I can try to implement the two tests in python after NMIT.

@elong0527 that would be awesome, thanks!

It may be easier to wrap the R/C++ packages than re-implementing in Python. In addition to requiring less developer effort, we'd get access to upstream bug fixes, features, etc. implemented by the R/C++ package authors. Wrapping R or standalone binaries isn't really a problem, see q2-phylogeny and q2-alignment for examples of wrapping a standalone binary (e.g. FastTree, MAFFT) in QIIME 2.
The only limiting factor is that the R/C++ packages must be installable via conda (I don't know if those two packages are available as conda packages).


fixed grammar

I forgot to click the last button to create this Pull Request :)

Good deal, thanks! I'm always in such a hurry that my doc comment quality suffers. Glad to have people looking out for documentation quality :smile:


Audio related issues

[ ] Change all the return value of Source method to Box. There may be many things to solve here.
[ ] The repeat should not use clone. perhaps loop back the index?
[ ] Seperate the AudioPlayer and AudioFile. AudioPlayer can have many params and can be controlled by each Frame. Freeze itself when done.
[ ] In the long run, we should switch to block based solution. Now it's still Frame by Frame

The repeat node has to use clone.
I have tried both approaches, but using index resets breaks repeat if the contained source at any point uses a slice iterator or other state machines like chain. As such, resetting the index is not enough as the state machine also needs to be reset. This also applies for sample conversion nodes and audio wav decoder nodes as they use a sliding window, resetting the window is here not enough due to the adjacent state.


Update sbt, scripted-plugin to 1.9.1

About this PR
📦 Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.8.3 to 1.9.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #295.


Don't use PR branch for rehearsals in the openshift/release repository

Description
I found out that rehearsals run on the openshift/release repository PR set the value of the  PULL_NUMBER env variable of the job to the PR in the openshift/release repository. This naturally leads to a rehearsal job run failing because the pipeline is trying to fetch container files from the PR for ai-edge repository, which does not exist with that PULL_NUMBER (the PR exists just in the openshift/release repository). Therefore, for rehearsals we should always fetch the default, e.g. the main branch of the ai-edge repository, so the same approach we already use for nightly jobs.
How Has This Been Tested?
Locally.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/approve

/override ci/prow/test-ai-edge

@grdryn I overrode the job as it is failing still. I am currently working on fixing it in https://github.com/openshift/release/pull/51003 but I found out that there is this issue with rehearsals, so I would like to fix that first. I originally expected that the PULL_NUMBER of a completely unrelated repository from the tests point of view (openshift/release repo) wouldn't be set but counter-intuitively it is for rehearsals. Can you give it a lgtm?

/lgtm
Good catch


Stripping comments from raw css before parsing will avoid issues I've been having with commented-out MQ being picked up by the parser

I encountered this issue recently as well. As a workaround I added a space between @ and media so that the commented MQ wouldn't be parsed.


PixToBitmapConverter inverts Format1bppIndexed images

Greetings,
This issue is similar to #72.
This is my input image:

This is the output I get:

(Note that attached image is .png, because .bmp is not an acceptable format here.)
This is my simplistic fix:
// inner loop in TransferData1(PixData pixData, BitmapData imgData)
for (int x = 0; x < width; x++)
{
    byte pixVal = (byte)PixData.GetDataByte(pixLine, x);
    // simplistic fix - invert the bits
    if (imgData.PixelFormat == PixelFormat.Format1bppIndexed)
    {
        pixVal = (byte) (pixVal ^ 0xff);
    }
    imgLine[x] = pixVal;
}

I did not investigate any further what the root cause is, and this fix is certainly sub-optimal. It may adversely affect images that convert fine with the current code.
Thanks.
tjk:)

If invert is really needed, Leptonica's pixInvert native function can be used.


the entire game's window isn't centered

Just move it then

Just move it then

how

redownload the game or maybe its a problem with your screen

same situation here, try to press WindowsLogo+UpArrow to make full screen. Then i dont know how to fix the camera offset, so just try to put the neuron panel and the time in your screen


WallsLayer, SceneConfig, and Optional parameters

application.d.ts

Options properties should all be optional.

dialog.d.ts

close: arguments are optional with a default value
confirm: render and options args should be optional
prompt: label, callback, render, and options are all optional

formApplication.d.ts

Options are all optional

sceneConfig.d.ts

New declaration of the SceneConfig class

config.d.ts

Use the new SceneConfig class for sheetClass property type.

wallsLayer.d.ts

New declaration of the WallsLayer class. Built this out for the DF Curvy Walls module.

~types.d.ts~

~Added new declaration for the PIXI PreciseText class.~ Removed as it was a duplicate

index.d.ts

Included the new declaration files

Everything that is not related to SceneConfig or WallsLayer is fine now from my perspective. I didn't take a look at the SceneConfig and ´WallsLayersChanges` yet because @BoltsJ  and @kmoschcau are better candiates to resolve these conflicts with their own PRs.

But overall thank you for the work put in, so far.

I would also suggest to simply remove the changes to SceneConfig and WallsLayer from this PR. If there are still any problems with these classes, feel free to create specific PRs for that (or issues).
Also it looks like the changes in this PR break some tests for the Dialog types. Please address this.

I've removed everything except the changes to the Dialog class' confirm and prompt helper functions.

@ghost91- Not sure what in the changes would cause the dialog test to fail. It is complaining about JQuery not being assignable to HTMLElement. I haven't changed any of the parameter types or return types in this file. Could this be an issue with the test itself?

@ghost91- Not sure what in the changes would cause the dialog test to fail. It is complaining about JQuery not being assignable to HTMLElement. I haven't changed any of the parameter types or return types in this file. Could this be an issue with the test itself?

Per the FoundryVTT API, Dialogs will return a JQuery reference to callbacks by default. The original typings and tests for the Dialog expected the default to be HTMLElement.
FoundryVTT API  Docs:
/* Dialog Class DocComments
 * @param {boolean} options.jQuery    Whether to provide jQuery objects to callback functions (if true) or plain
 *                                    HTMLElement instances (if false). This is currently true by default but in the
 *                                    future will become false by default.
 */

I approved it. In order to be able to merge, @BoltsJ and @kmoschcau also need to approve because they requested changes.

@kmoschcau can you approve?


Feature Request: New data visualizations

Currently, the project only supports visualizing zipcodes and cities on the map using Mapbox
But data can be visualized in many other interesting ways like Bar Charts, Heatmaps and Pie charts.
Not every kind of data can be (or should be) visualized on a map.
For example, a query like "What percent of total crime in San Francisco is burglary vs in New York City" is perfect for visualizing as a stacked bar chart, but really hard to visualize on map.
TLDR: we need to support more visualizations!

Plotly looks promising: https://plotly.com/javascript/bar-charts/

Done. Will punt heatmap for later, until users ask for it.


remove the wiki if not needed

I always recommend removing the repo's wiki (a checkbox in the settings)  if it's not being used.  Just to clear up the repo all the more.

+1 to this. Done!


Added hability to override gav

Hi @aslakknutsen,
I added a way to override chameleon gav by:

adding chameleonGav property;
after adaper is resolved I just change its distribution to the provided gav.

Do you think its sufficient for #41?
I've tested here at the company with our custom distribution and it works great, here is our arquillian.xml:
 <property name="chameleonGav">com.procergs:jboss-eap-dist:zip:6.4.Final</property>
 <property name="chameleonTarget">jboss eap:6.4.Final:${arquillian.container}</property>

no need for custom containers.yaml.
WDYT?

hmm looking at your comment on issue #40 I see your idea was not to create a new property, what do you had in mind for this issue?

@rmpestano My first thought was to allow to load a file named e.g. 'override-default-containers.yaml'  from classpath that the Chameleon internals would merge on top of the built-in default configuration. That way you could provide your company jar that contains this file and overrides any configuration option for any container.

@aslakknutsen, well if I still need to provide a jar with containers.yaml then I have no problems with current approach (copy default.yaml and change gav).
With the approach in this PR only a property is needed.

Hi @aslakknutsen,
I think we can close the issue, I'm assuming its not a common use case (no one comment the pr).
Anyaway we are keeping our "custom" chameleon in our company maven repository.

With the approach in this PR only a property in arq.xml is needed, no need to know containers.yaml syntax or its properties [...]
[...] Anyway we are keeping our "custom" chameleon in our company maven repository.

But wouldn't it be enough for your use to define custom container (like we have in the tests) instead and override certain properties? Diverging from the upstream dev will make your life harder I believe :)
That said - shall we close it? @aslakknutsen

+1

Hi guys,
we have custom eap distribution here at the company. It has custom modules and patches applied.
How do you configure chameleon without having a custom yaml file on each application?

Shouldn't this YAML be on the classpath this way or the other? Maybe shipping it as a JAR would be sufficient? Can you try this approach?

One approach is to bundle the yaml into a jar and use it as dependency as discussed here. Its not the simpler way because it introduces another dependency when we could just change a property in arquillian.xml

Hi @bartoszmajsak, yes (answered at the same time), it solves the issue but for us its way better to manage arq.xml property instead of generating another version  of this dependency(which just changes the adapter's gav  in yaml) everytime a patch is applied to jboss.

Didn't check #40 issue. But then maybe instead of making a special property for GAV we can support syntax in YAML with defaulting. So you would have your one custom jar with this YAML file and having
gav: ${version.glassfish:org.glassfish.main.distributions:glassfish:zip:${version}}

Would it make sense @aslakknutsen @rmpestano?

that's nice but why not support the ${version} directly in chameleon core?

well in fact the hole gav instead of version

We could think about evaluating ${variables} in YAML like we do in arquillian.xml, but then maybe #41 is better way of doing that?

Nice, I am :+1: for any solution that allows me to update container version without managing additional .yaml files or dependencies.
May I close this PR?

May I close this PR?

Go ahead.
Keen to hack on #41 btw? :)

Keen to hack on #41 btw? :)

sure but its a bit nebulous to me on how ${variables} substitution works, example I imagine we would have a gav variable in default containers.yaml:
- name: wildfly
  versionExpression: 9.*
  adapters:
    - type: managed
      gav: org.wildfly.arquillian:wildfly-arquillian-container-managed:1.0.0.Final
      adapterClass: org.jboss.as.arquillian.container.managed.ManagedDeployableContainer
      configuration: &WF_CONFIG
        jbossHome: ${dist}
  dist: &WF_DIST
    gav: ${gav}

and arq.xml:
 <container qualifier="chameleon" default="true">
    <configuration>
      <property name="chameleonTarget">wildfly:9.0.0.Final:managed</property>
    </configuration>
  </container>

if no gav variable provided then use default one: org.wildfly:wildfly-dist:zip:${version}
But how do we override default gav in this case? same way the version is extracted from gav today? in this case the gav should be part of cameleon target property, or do you have another idea?

Let's move this discussion to forum


⚠ Redacted has degraded performance

In 1ea7f2d, Redacted ($RED) experienced degraded performance:

HTTP code: 200
Response time: 3559 ms

Resolved: Redacted performance has improved in f8c259b after 6 minutes.


Unsaved counterparts won't be found.

Counterpoint only looks at the disk for possible counterparts, it doesn't look at vim's own buffer list. That means if you have a foo.cpp file on the disk (but no corresponding foo.h), open it, and then edit a new foo.h Counterpoint can't find the header file until you write it to disk.
It shouldn't be too hard to include vim's listed, file-backed buffers in the counterpart search.

https://github.com/jpetrie/vim-counterpoint/commit/987c0fb299675e1f5999f35ae7d2461ae3ce358f adds this.


match_transactions() performance limitation

The current "second pass" can be extremely expensive if the number of orders with the same id is high enough. I noticed the tagger was getting hung up (using 64GB RAM for hours at a time), and I narrowed it down to a particular order: I have a 50 item AmazonFresh order that was refunded.
for orders_same_id in oid_to_orders.values():
    combos = []
    for r in range(2, len(orders_same_id) + 1):
        combos.extend(itertools.combinations(orders_same_id, r))
    for c in combos:
        orders_total = sum([o.transact_amount() for o in c])
        amount_to_orders[orders_total].append(c)

when len(orders_same_id) is large, the number of possible combinations gets very large. I didn't determine the ideal threshold, I believe I only had 2 manifestations of this issue: 50 items and 30 items.

@jamesgo, thanks for the PR. I haven't used AmazonFresh much. To help me better understand how orders are structured, would you be able to donate some example data (PII redacted of course)? I'm curious why a single amazon fresh order would be modeled as such. It would also be great to turn into a few test cases. Thanks! Jeff


ENH: DOC: add links to reference LAPACK docs for scipy.linalg.lapack

Is your feature request related to a problem? Please describe.
scipy.linalg.lapack docs are currently only helpful when the correct routine is already known. As I assume that no one in the world has time to write helpful docstrings for all of these functions, I thought it might be helpful to at least link into reference lapack's docs.
Describe the solution you'd like.
Example: scipy.linalg.sgbsv would include a link to the Netlib doc of this function.
Describe alternatives you've considered.
No response
Additional context (e.g. screenshots, GIFs)
Automatically generating the URLs to Netlib is not possible probably from what I see :/ .

The docs are unfortunately auto generated by f2py tool and because Netlib team is using doxygen for generating their own documentation, the links are all garbled to be referenced properly. Hence we can't automate it unless there is some logic behind those hash looking urls. This is probably something for the Netlib team I'm afraid.

We could add a general link to the Netlib docs if not the main docs for the function. There may be a way to find a logic behind these links but I'm not sure how to navigate their folder structure.
Examples:

https://netlib.org/lapack/explore-html/da/da7/sgbsv_8f.html
https://netlib.org/lapack/explore-html/dd/dc2/dgbsv_8f.html

This seems unfeasable. Unless there are objections, I will close in a few days.


[FEATURE] Easier import of multiple sequences for single or multi-cam (Desktop)

It would be useful to import either a directory of videos, a directory of directories of images, or a directory of directory of multi-cam data (in consistent sub-directory orderings) with a single import as opposed to having to 1 by 1 do this for a directory of say 30 different sequences. Example data for multi-cam forthcoming shortly.

duplicate of #623


BUG: Unsafe parameter passing in Python action

The line is incorrect because JSON is not valid Python, e.g., null is not defined in Python.

@ioana-blue, could you help out with a unit test when you get a chance? I don't speak Scala.
It should be enough to pass {"foo": null} as inputs.

no serious Scala speak necessary: see PythonActionContainerTests.scala, copy/paste of "support valid flows" test in this case will get you most of the way there ;) if you want to try.

I'll take a look at this PR and try to merge it. I'll work separately on a test case. I don't think it's worth the overhead for Evan to learn how to write tests in our infrastructure, he's really productive with the tasks he needs to focus on. I'm removing the wip label.

Add the test on top of this commit? It's really just a copy/paste and small edit - we should not merge a fix without a test ;)

Ok, I'll try to add the test here.

Per @epatters suggestion, I created my own branch and added his one-line fix. I created a test, thanks @rabbah for suggesting the inspiration :)

Closing subsumed by #950


It's funny that we don't have React in the boilerplate other than in the title

Yep. Want to fix that?

Implemented in this commit


chore: change the persist credentials to false and bump commit msg checker version

This will not force the actions user credentials
to be stored into git config which will later
result in using github_token of release actor.
Signed-off-by: Tibor Dudlák<EMAIL_ADDRESS>

I have no idea why commit message checker is failing

Thanks @dav-pascual for the review!


ISPN-16170 Expose if tracing is enabled in the server

https://issues.redhat.com/browse/ISPN-16170

@pruivo I updated docs and fix. added on full detail as well the tracing

merged! thanks @karesti !


[Doc enhancement][auth-aad-sso-bots-steps-update][2264024]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/authentication/auth-aad-sso-bots.md
98
12
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 70c470a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/authentication/auth-aad-sso-bots.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/authentication/auth-aad-sso-bots.md
98
12
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9881245:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/authentication/auth-aad-sso-bots.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/authentication/auth-aad-sso-bots.md
95
12
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c74c395:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/authentication/auth-aad-sso-bots.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Typo in pandas/pandas/io/parsers.py

In pandas/pandas/io/parsers.py line 1000, np.uin8 is referred. It is an inexistent member in numpy. I suppose it's a typo for np.uint8.

Duplicate of #9266
And there are already two PRs for this (#9350 and #10074)

But thanks for reporting! We should try to merge one of those ... :-)


Reboot for forms causes ugly control rendering in Windows / Windows Mobile

A quirk on Windows and Windows Mobile: the very light styles provided by Reboot cause some unforeseen ugliness - current working hypothesis is that by mostly only setting border-radius most browsers (Firefox, IE11, Edge on Windows 10, and Edge on Windows 10 Mobile) flip from using some nice system-level provided form controls to having to make up their own control rendering, which then has unforeseen defaults that Reboot does not cancel out.
For comparison, here's a test http://codepen.io/patrickhlauke/pen/gPMqgd and two screenshots of the dramatic difference in rendering from just having border-radius present.
Here's Firefox

And here's Edge on Win 10 Mobile

Now, in practice, this isn't so much a problem as Bootstrap obviously defines extra things like border etc later on...but I wonder if Reboot itself should be extended to normalise their rendering? /cc @cvrebert @mdo

And related, this causes the same sort of unsightly form controls (in Edge/Win10Mob) for the notoriously difficult to style file input and for disabled checkboxes/radio buttons in form components http://v4-alpha.getbootstrap.com/components/forms/

Does adding border-style: solid; to the border-radius reset help things?

not fully, no. you then also have to set border-width: 1px and border-color: inherit. and that only fixes the most egregious problem with the broken-looking (most prominently in Edge/Win10Mob) borders. background color and some font choices still don't match exactly, but probably better than nothing.

then again, just going for the basics (maybe even adding a subtle background: inherit (though that seems to make it white/transparent in Firefox/Win10) may make this look slightly less crappy. will have to test a bit...

If we need to do border: 1px solid, let's do it. I don't have a newer Windows phone lying around to test though, so if anyone wants to pick that up and test, I'll happily merge.

Sorry, dropped the ball on this one. Will pick this up in a week or so once I'm not travelling. Wondering if, instead of adding some rule, we should instead remove some (if I can identify the minimum set of styles that work without kicking browsers into their own custom form widget rendering)

retesting everything on Firefox/Windows, Edge/Windows 10, Edge/Windows 10 Mobile, and it seems that at some point, reboot has changed sufficiently for the problem to disappear. http://v4-alpha.getbootstrap.com/content/reboot/#forms and http://v4-alpha.getbootstrap.com/components/forms/ all look fine (no heavy inset broken-looking border, no unsightly blue-ish background on disabled checkboxes/radio buttons/file type inputs). as such, i'm closing this...

May have been the switch from Normalize to all Reboot, too. Bunch of styles got redone as part of that.


[Feature Request]: adding page translator to the footer

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
the existing footer of the netflix clone project is quite different from the official netflix site.
the footer lacks the page translator button in the footer. Kindly assign me this issue @apu52 so that I can enhance the footer and it look exactly the way it is in the official website.
Use Case
adding translator can make it more user friendly
Benefits
No response
Add ScreenShots

this is the actual footer of the official website

the netflix clone project footer
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I have starred the repository

@nandani-goyal u are assigned


Display Tooltip information once clicked

@omaryasser please provide more info about this issue

Sorry for not explaining well. In the page CreateAzkarChallengeScreen, there are some tooltips so that users can click on them and know more about the field they need to fill. Currently you have to touch the tooltip for a while so that the information message show. It will be better if the message show once the user touches the tooltip icon.


Wrongly reported gnomad_num_het

I noticed that for variants that are multi allelic in the Gnomad vcf the number of heterozygous variants is always reported as 0.
I believe this is the consequence of the GC_Male and GC_Female INFO fields missing in the parsed Gnomad vcf files at multi allelic loci.
While the GC_Male and GC_Female INFO fields are still present in the original Gnomad vcf they are gone after vt decomposition (https://github.com/atks/vt/issues/87).
Since the number of heterozygous variants is calulated based on GC_Male an GC_Female, it is wrongly reported as 0 for these multi allelic positions.

Any update on this issue?  This is something we have run into as well.  Maybe we could update the VCF using the fixed vt referenced above?

I'll update the gnomad exomes stuff and ping this issue when it's up. thanks for the reminder and thanks @mmoisse for tracking down the problem.

@brentp
Thanks for updating the exome file.
We're getting an error when we try to run install-data.py:
wget failed with non-zero exit code 8. Retrying
--2018-08-16 14:34:31--  https://s3.amazonaws.com/gemini-annotations/gnomad.exomes.r2.0.2.sites.no-VEP.nohist.tidy.vcf.gz
Resolving s3.amazonaws.com (s3.amazonaws.com)... <IP_ADDRESS>
Connecting to s3.amazonaws.com (s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2018-08-16 14:34:31 ERROR 403: Forbidden.

wget failed with non-zero exit code 8. Retrying
Traceback (most recent call last):
  File "install-data.py", line 171, in <module>
    install_annotation_files(args.anno_dir, args.dl_files, args.extra)
  File "install-data.py", line 106, in install_annotation_files
    to_dl, anno_dir, cur_config)
  File "install-data.py", line 124, in _download_anno_files
    cur_config.get("versions", {}).get(orig, 1))
  File "install-data.py", line 152, in _download_to_dir
    raise ValueError("Failed to download with wget")
ValueError: Failed to download with wget

Does the permission need to be updated?

sorry about that. can you try again?

That worked, thanks.  We had some other warnings/errors in our installation using the master branch, which @ponomarevsy posted here. Not sure if these are critical.

@brentp
Thanks for updating gemini v0.30.1.
The problem has occurred again.  'GC_Male' and 'GC_Female'  were not found in gnomad.exomes.r2.1.tidy.bcf, as a consequence, the gnomad_num_het is always reported as 0.
And could you include the 'popmax','AF_popmax' in gnomad_v2.1 ?
popmax: Allele frequency information for the outbred population with the highest frequency. This excludes Finns, Ashkenazi Jewish and “Other” populations.
Thanks.

@zhanhuizhang I have pushed a fix for this to master, would you give it a try? You'll have to reload your database.
thanks for reporting.

@brentp  Thanks for the quick fix.
The 'gnomad_num_het' and 'gnomad_num_hom_alt' are corrected, but the gnomad_popmax_af is always -1.
Perhaps  GEMINI should get 'AF_popmax' from the gnomad_v2.1.bcf, not the 'popmax_AF'.
THANKS!

sorry about that. I just pushed a fix. Thanks for noticing.

That worked ~~~ :)


changing numChars manually with settings()

Expected behavior
Actual behavior
Steps to reproduce
when changing numChars manually with settings(). and then perform resize().  terminal doesn't recalculate max new num chars for command prompt value.
Browser and OS

The setting numChars was just a hack to make test from jasmine node work becuase there are no css there to make width of the terminal so I've created that option to set number of chars. I didn't know it even work outside of tests.
Maybe I should not put it in docs.

In devel branch, I've made a change to get inline style from terminal instance for fake .terminal div, but you still need to call resize() manually becuase changing font don't trigger resizer, (the width&height is not changed).

there are two problems. first it doesn't correctly return actual num chars per line. (maybe because of custom css)
and second :
problem is that when i have many terminals on screen , executing this code :
var temp = $('<span cla' +
'ss="prompt"> ').appendTo('body');
cost 30 ms in my chorme brower per terminal . so image if i have 16 terminals on screen. not too good for User expirience.
so i tried to calculate num chars manually only 1 time before resizing all terminals. (for ex. when user changing font size, or change width of his browser window. Or even on terminal init)
so i just return {} and rely on setting.num_chars

I've put character size check in font resizer so it will fire only when you change font.

And fixed the requested bug with command line resize on settings.numChars + terminal.resize, didn't get what you wanted first time I've read the issue.

The change is in version 1.11.0


Support go-redis v9

go-redis v9.0.0 released about half an hour ago: https://github.com/redis/go-redis/blob/master/CHANGELOG.md#v9-2023-01-30
Two major changes that affected this code:

redis.NewClient returns a pointer to a redis.Client instead of an instance of redis.UniversalClient. I changed the internal struct to use the pointer type so that existing code won't need to be changed to prefix the &.
Pipeline.Close was removed from upstream "since there is no real need to explicitly manage pipeline resources and it can be safely reused via sync.Pool etc."

Sorry for taking so long to respond. Everything looks fine. Now that there is no pipeline.Close() do I need to implement a sync.Pool?

Not a problem! To my understanding, you'd only need a sync.Pool in the event that the pipeline is reused. From looking at the go-redis code it looks like Pipelines used to have a mutex which required a call to pipeline.Close, but that is no longer the case


Query regarding riscv_vector headerfile

I am trying to run example programs but did not get "riscv_vector.h" header file.
I have already installed riscv-gnu-toolchain along with riscv-pk and riscv-spike.
Do I need to install some other tools or some other environment to access riscv vector extension intrinsics (riscv_vector.h) ?

We haven't released a compiler with vector support yet.  So all you can do is assembly level programming at the moment.


High CPU usage on statistics update

11K Peak Connections
5K Websocket Messages
420 Api Messages
Everything is going well if statistics are disabled, otherwise CPU load reaches 100% usage at the time where the statistics are updated. (it stays ~20s and then CPU load come back to 2%)
Here you can see on the left the statistics are enabled and on the right side are disabled

(DigitalOcean do not show exactly CPU usage on update time, but I notice it from console "top -i")
DigitalOcean Server :  8Gb RAM / 4 CPU
Version : v2.0.0-beta.30

Might be duplicated to: https://github.com/beyondcode/laravel-websockets/issues/623

We'll continue any relevant issues in #623


feat: simplified deployment process

I added a docker-entrypoint.sh which provides a default for the database url and JWT secret. This allows deployment to be simplified to a one liner like git clone ... && cd crystalworld && docker-compose up ...
Additionally, (perhaps this should be a separate PR) if you deploy it in docker by default it's not available outside the docker network because Onyx only binds to localhost. This allows overriding the host and port values from environment variables.

Hey, thanks! Gonna sleep right now and thoroghly check later. Please fix the build issue 👍

Alright, I'm against this PR, because:

Docker Compose is not native to Docker, it usually should be installed separately (and currently the version which supports 3.5 is not that easy to install, at least it's not available on my Ubuntu 16.04 via default apt)
docker-entrypoint.sh brings unnecessary complexity to the project:

If a developer needs to bind the database to a host file, it can be simply done with -v
JWT generation is overhead, it can be achieved with one-line openssl rand -hex 16 command

However, your point about the host is absolutely correct. You can propose a PR which will bind the server to "<IP_ADDRESS>" by default. But please, call the environment variables HOST and PORT accordingly.

Hello, just noticed your comments, I'll get on the changes you requested.
couple discussion points:

* Docker Compose is not native to Docker, it usually should be installed separately (and currently the version which supports `3.5` is not that easy to install, at least it's not available on my Ubuntu 16.04 via default `apt`)

all fair points. I withdraw my suggestion to change the readme to default to that. If you'd like I can write a more generally-compatible docker-compose file to include, or that could just be left out :man_shrugging:

* `docker-entrypoint.sh` brings unnecessary complexity to the project:

  * If a developer needs to bind the database to a host file, it can be simply done with `-v`

If this is the case, then why does the developer need to specify the location of the database at all? Why not just have an optional -v /host/path:/app/crystalworld.db setup option, and have it default?

  * JWT generation is overhead, it can be achieved with one-line `openssl rand -hex 16` command

Oh, ok, I didn't find that command when I was trying to do that. thanks for the tip
I still think there should be a docker-entrypoint.sh which

provides defaults for the random token and the database location (these steps could be done on launch instead of in a docker-entrypoint.sh)
migrates the database if there isn't one already.

The major reason I wrote the script was because it seems unnecessary to have someone manually migrate the databases.

However, your point about the host is absolutely correct. You can propose a PR which will bind the server to "<IP_ADDRESS>" by default. But please, call the environment variables HOST and PORT accordingly.

Closed by 1f7d0d89ef5c56e77ef0c2a2366d267961b11009 and 5c61d6ab0d4c9342a55d86326b4b58ac9cd7cfb9


Added missing diacritics to Spanish names and surnames

Oops. Wrong folder, sorry. Closing and redoing it.


MariaDB

Swap out mysql for MariaDB in VM

@sergii-tkachenko can you close this now? :clap:

Wow, haven't seen it. Sure. it's done: #4374.

Aww yiss. An issue close for free! :+1:


hi

Hello, I am a novice. It took me a few days to understand the design implementation of this code. I would like to ask if the design here USES some algorithm.It's so cleverly designed that it's amazing.

.


Adding a mixin for Azure Locations

Fixes #117
Allows us to turn this:
let resourceGroup = new azure.core.ResourceGroup(name, {
    location: "West US",
});

into
let resourceGroup = new azure.core.ResourceGroup(name, {
    location: azure.WestUS,
});

Great change! How do we maintain the list of locations? How will we know to update it when new regions are available?

@mikhailshilkov great question - so I need to pay attention to when new regions are released. I’ve left it that magic strings will still work though as to not block anyone
No one can really tell me if the 32 regions have is the full list :)

I guess we can trust az account list-locations -o table which seems to return 32 lines indeed.

I'm sure we will hear when new regions hit and we can add the constants for it easily enough :)


Unable to deploy functions

My deployments of Google Cloud Functions have been failing with the error
[2018-05-22T18:18:28.504Z] <<< HTTP RESPONSE BODY {
"error": {
"code": 503,
"message": "The service is currently unavailable.",
"status": "UNAVAILABLE"
}
}
my node version - v8.9.3
npm version - 5.5.1
<EMAIL_ADDRESS><EMAIL_ADDRESS>

It looks like there is an ongoing issue. Sorry about that! Please follow this for status: https://cloud-status.googleplex.com/firebase/incident/Functions/18028

I am not able to login to  https://cloud-status.googleplex.com/firebase/incident/Functions/18028
My old project is working fine, I can successfully deploy functions. the problem is with new one. there is no error in the function, here is my function
const functions = require('firebase-functions'); exports.helloWorld = functions.https.onRequest((request, response) => {  response.send("Hello from Firebase!"); });
and I'm getting this error ...
i  deploying functions
i  functions: ensuring necessary APIs are enabled...
✔  functions: all necessary APIs are enabled
i  functions: preparing functions directory for uploading...
i  functions: packaged functions (38.68 KB) for uploading
Error: An unexpected error has occurred.

the issue is fixed now.

Sorry about that @clement89 I posted an incorrect link. The correct one was: https://status.firebase.google.com/incident/Functions/18028 In general you can always check if there is an ongoing issue on https://status.firebase.google.com in case you run into any strange issues.

Thank you.


Add common properties argument to WSGIApplication wrapper

Our Flask app cannot log common properties/dimensions when it uses the default WSGIApplication wrapper. I have updated the wrapper construct to take in a new common_properties object. This is similar to the code used in the NodeJS Application Insight Telemetry Logger: https://github.com/Microsoft/ApplicationInsights-node.js/blob/develop/Library/TelemetryClient.ts#L36
These common properties are then logged for every track_request made by the WSGIApplication wrapper.

Can you please add an entry into changelog https://github.com/Microsoft/ApplicationInsights-Python/blob/master/CHANGELOG.md so release notes will be easier to write down.

I'd say just update README.md for now and while we ought to address the duplication, let's do so in another issue (#89).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aaronkensci sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@SergeyKanzhelev @jjjordanmsft
I have updated the README and WSGIApplication documentation to surface the new functionality. I added the change to the '0.11.5' changelog version. Please edit it if it should be in the .4 version.


Refactoring recommanded Kubernetes labels

Signed-off-by: Nicolas Lamirault<EMAIL_ADDRESS>Pull Request
What does this PR do?
Refactoring Kubernetes recommanded labels into Helm helper.
PR checklist
Please check if your PR fulfills the following requirements:

[ ] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@meilisearch sync-manifest

bors try

bors merge


How to avoid python packages conflicts when changing stdenv?

I changed the Python stdenv via:
py39 = pkgs.python39.override {
  self = py39;
  stdenv = pkgs.llvmPackages_latest.stdenv
}

Then, I tried:
> nix-shell -p "py39.withPackages (p: [ p.freezegun ])" --run python
...
running install tests
no Makefile or custom installCheckPhase, doing nothing
pythonCatchConflictsPhase
Found duplicated packages in closure for dependency 'six':
  six 1.15.0 (/nix/store/qdjsq2wmgdxm99d071zviypb7ipplprk-python3.9-six-1.15.0/lib/python3.9/site-packages)
  six 1.15.0 (/nix/store/ldj5ixz2327yi3ak5d3aglc5qzbpd27h-python3.9-six-1.15.0/lib/python3.9/site-packages)

Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.
error: builder for '/nix/store/y2xkql653h1gq4fmbsa4vagbx2m2rjyd-python3.9-freezegun-1.1.0.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/3br135qqmfn9zq98hhg8clpdn14r69sa-python3-3.9.2-env.drv' failed to build

To avoid this error, now I use the overlay below, which ignores the check phase.
...
freezegun = freezegun.overridePythonAttrs (o: {
    doInstallCheck = false;
    doCheck = false;
    checkInputs = [ ];
})
...

Is there any other method to solve this error so that I don't need to ignore the check phase of every error packages?

The interpreter should be passed to itself, just as when overriding it for any other purpose. That way, the package set will actually use this modified Python.
mypython = let
  python = pkgs.python3.override {
    stdenv = pkgs.llvmPackages_latest.stdenv
    self = python;
  };
in python;

Note however that stdenv is often passed in as an additional argument, because some checks may be done in the package expression. Overriding the stdenv like the above will not make stdenv be correct there. In that case, pkgs should be updated as well. In order to avoid rebuilding pkgs with stdenv, you could do a
```nix
mypython = let
  stdenv = pkgs.llvmPackages_latest.stdenv;
  python = pkgs.python3.override {
    inherit stdenv;
    self = python;
    pkgs = pkgs // { inherit stdenv; };
  };
in python;

That should get you further. Note, however, this will still fail in case of cross-compilation.

Thanks!
But cpython/default.nix doesn't have the pkgs argument.
It has
  , packageOverrides ? (self: super: {})
  , pkgsBuildBuild
  , pkgsBuildHost
  , pkgsBuildTarget
  , pkgsHostHost
  , pkgsTargetTarget

Should I change one of them?
Also, change
mypython = pkgs.python3.override {
  stdenv = pkgs.llvmPackages_latest.stdenv;
  self = mypython;
}

to the let expression,
mypython = let
  python = pkgs.python3.override {
    stdenv = pkgs.llvmPackages_latest.stdenv;
    self = python;
  };
in python;

seems the same.

Also, change

Correct, I missed you already set self.

Should I change one of them?

So, this is messy. Turns out its actually the pkgs passed into /home/freddy/Code/libraries/nixpkgs/pkgs/development/interpreters/python/default.nix.
mypython = let
  stdenv = pkgs.llvmPackages_latest.stdenv;
  interpreters = pkgs.pythonInterpreters.override {
    pkgs = pkgs // {inherit stdenv};
  };
in interpreters.python38 # if it is 3.8 you want

Thanks, but unfortunately, it not works.
I have tested it with:
when using this one:
mypython = let
  stdenv = pkgs.llvmPackages_latest.stdenv;
  interpreters = pkgs.pythonInterpreters.override {
    pkgs = pkgs // {inherit stdenv;};
  };
in interpreters.python38

It still builds with clang7 but the latest clang11.
If I override the python38 again:
mypython = let
  stdenv = pkgs.llvmPackages_latest.stdenv;
  interpreters = pkgs.pythonInterpreters.override {
    pkgs = pkgs // {inherit stdenv;};
  };
  py38 = interpreters.python38.override {
    self = py38;
    inherit stdenv;
  }
in py38

It conflicts again.

Hi,
let me refresh the issue.
I also struggle with interpreter replacement and face duplicated toml package.
The bug is reproduced with following schema:
{ pkgs ? import <nixpkgs> {} }:

let
  myPatchedPython = (pkgs.python39.overrideAttrs (old:  {
    src = pkgs.fetchFromGitHub {
      owner = "python";
      repo = "cpython";
      rev = "0a7dcbdb13f1f2ab6e76e1cff47e80fb263f5da0"; # 3.9.5
      sha256 = "0fw1bdphhahr4syahd6ii732ryfpxzlbpxjc3r81bi05yvhybd3q";
    };

    preBuild=''
      export LIBFFI_INCLUDEDIR=${pkgs.libffi.dev}/include
      export SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX10.12.sdk"
    '';

    commonPreHook = ''
      export LIBFFI_INCLUDEDIR=${pkgs.libffi.dev}/include
      export SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX10.12.sdk";
    '';

    LIBFFI_INCLUDEDIR="${pkgs.libffi.dev}/include";
    CFLAGS="-iwithprefix ${pkgs.libffi.dev}/include";

    buildInputs = old.buildInputs ++ [
      pkgs.libffi
      pkgs.tcl-8_6
      pkgs.tk-8_6
      pkgs.darwin.apple_sdk.frameworks.Tcl
    ];
    doCheck = false;
    LDFLAGS = " -L${pkgs.tcl-8_6}/lib -L${pkgs.tk-8_6}/lib " + old.LDFLAGS;
  }));

  # replace python in packages
  pa-py-pkgs = myPatchedPython.override { self = myPatchedPython; };

in pa-py-pkgs.pkgs.pygogo

log ends with errors:
pythonCatchConflictsPhase
Found duplicated packages in closure for dependency ‘toml’:
toml 0.10.2 (/nix/store/rxkbpax8krb083hmpkl570qgk4m948hv-python3.9-toml-0.10.2/lib/python3.9/site-packages)
toml 0.10.2 (/nix/store/gmv2cfzs5i4ssnk016rhy44dn9j8mh2k-python3.9-toml-0.10.2/lib/python3.9/site-packages)

python version doesn't matter and other python package (e.g. pygit2) are affected but all.

Overriding of parameters is fixed in https://github.com/NixOS/nixpkgs/pull/169475. Overriding of derivation parameters is harder and does not yet work I think.

@FRidh Thanks a lot for this! I will test it.
With regards to the approach in https://github.com/NixOS/nixpkgs/issues/117065#issuecomment-805257626, I noticed that some parts of the Python infrastructure use python.pythonForBuild. I think the duplicated packages in the present issue stem from this: buildPlatform and hostPlatform are the same, so the conflict checker runs, but python.stdenv is NOT python.pythonForBuild.stdenv when proceeding as in https://github.com/NixOS/nixpkgs/issues/117065#issuecomment-805257626, and somehow both Pythons end up in PATH.
I was unable to override the pythonForBuild stdenv properly, Do you have any pointers on how to do that?

Related to my previous comment: As a quick-and-dirty test, I removed .pythonForBuild from the two lines at https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/hooks/default.nix#L12-L13; after that, the approach in https://github.com/NixOS/nixpkgs/issues/117065#issuecomment-805257626 works with no conflicts. This is clearly not a solution because of cross-compilation, but hopefully it is a useful observation anyway.

The idea was to fix this with https://github.com/NixOS/nixpkgs/issues/117065#issuecomment-1113009606, but because of the splicing it is not possible to override derivations. Seems that in the end it broke cross-compilation as well.


Adaptive Height

Please add Adaptive Height as an option for this plugin. That's the only thing I've experienced with this slider that ranks it below BXSlider and Owl Carousel at this point. Thanks!

Adaptive height does not work with multiple slides :
I have added solution here : https://github.com/kenwheeler/slick/issues/83


nixos build failure

I am trying to build a leptos site to run on Nixos.
The project tries to create a cache folder when compiling the front even with "no_downloads" feature enabled.
I think the solution is to decouple ExeMeta from the cach dir. Where we can access the ExeMeta but not do any cach dir checks.
Thoughts or other paths I can look into, willing to make the changes just want to get your thoughts on fixing it

Hi! I'd love to here more about how you're building it! I have  nix devshells and sites working, but it's possible I missed something

I am trying to build my leptos site into a derivation. I am using the cargo-leptos nix code you have pending submission to nikpkgs. What I am seeing is the cache folder is created even though with "no_downloads" you never use it. So when you build a derivation it complains as it can not create that cache folder.
the  ExeMeta and Exe classes will check for that folder and try to create it even though we set the no_downloads feature. It looks like it is not a straight forward change to try that behavior. Upon looking to create a derivation, I am starting to wonder just to build the server normally and use wasm-pack to build the wasm and merge them to together since this project seems to prioritize filesystem manipulation which nix frowns upon.

I'll have to double check that. I would say it's about the same level of complexity, but that's fair.

@polarmutex If you'd like to try my main branch here: https://github.com/benwis/cargo-leptos
with your derivation, I think I configured it to not create the cache dir.

I have tried that locally, it gets further. but when compiling the frontend it is creating the folder

Could you post your Nix file ? I'll try it myself and not bug you quite as much

https://github.com/polarmutex/website/blob/feat/rust/flake.nix is what I am currently using
might still be some issues in my nix code or might need to try a less complex nix rust flake template

Nice work! This is almost my default Rust Flake template. I'll setup a test env and make sure everything is good

I just tried your changes and did not see that error (i do have the dependencies as build inputs to crane). Not sure that is why I am avoiding that error.
I did run into an error where the target/site (or the folder you define where the css, wasm, and js build to is not there when  the css is moved to the folder. starting to look if we need to do a "mkdir -p" before moving

It might be because I'm trying to build a workspace, but my test.nix is pretty close to yours. Makes sense there'd need to be a manual file copy step for this to work. Let me know if you get it working, and especially if you run into any bugs

got to build (and even runs successfully) with your currrent cargo-leptos build

had to add more dependencies to the build inputs
do not clean source (deletes css and other non rust files)
add an installPhase command to crane

Thanks for looking into this

Alright, I've got it working too. It looks like I may have broken regular operation in some way, but once I figure out why, #80 can be merged and I'll update the nixpkg

@polarmutex A new version of cargo-leptos is out with a versison of my proposed changes, and I have updated the Nixpkg PR. Let me know if that has any issues for you

v0.1.8 works for me, thanks for the changes


some DataFrame/Series methods not support level,fill_value etc arguments

For example,DataFrame.mul()/rmul()/sub()... only accept 2 arguments, but in pandas, there are level,fill_value etc.

@alexwenbj For now, we try to make methods as simple as possible, so definitely not all features available in pandas are currently supported. Going forward, we can extend these functions to include more options as well.
For instance, fill_value can be the same across all math ops function, so that can be easily added. Other features will be based on importance and request.

@risenW Got it.Thank you.


Add Logz.io to Falco's adopters list ADOPTERS.md

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
updating ADOPTERS.md with a new adopter details
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/assign @fntlnz
Signed-off-by: Dotan Horovits<EMAIL_ADDRESS>

@horovits1: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Welcome @horovits1! It looks like this is your first PR to falcosecurity/falco 🎉

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

468c955 Add Logz.io to Falco's adopters list ADOPTERS.md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@horovits1 this LGTM but please look into signing your commits

LGTM label has been added.  Git tree hash: 69355b77efefb7bdc062d4c92ea417032611feaa

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, kris-nova
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,kris-nova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.24.0

Hey everyone
I have noticed that @horovits1 is now a deleted user ( @ghost ) which can neither reply nor sign-off
cc @horovits are you the same user? If so could you please make this PR again, please?
Thanks in advance

hey @leogr yes I transferred accounts, apologies for the mess.
the pull request source is now horovits:update-adopters-logzio
and the signoff stated in the pull request remains unchanged:
Signed-off-by: Dotan Horovits<EMAIL_ADDRESS>can we go ahead with approving the merge? adding Logz to adopters list?
redoing the same PR may mess things up, as it appears on the @horovits account.
Thanks,
Dotan

Hey everyone
I have noticed that @horovits1 is now a deleted user ( @ghost ) which can neither reply nor sign-off
cc @horovits are you the same user? If so could you please make this PR again, please?
Thanks in advance

hey @leogr yes I transferred accounts, apologies for the mess.
the pull request source is now horovits:update-adopters-logzio
and the signoff stated in the pull request remains unchanged:
Signed-off-by: Dotan Horovits<EMAIL_ADDRESS>can we go ahead with approving the merge? adding Logz to adopters list?
redoing the same PR may mess things up, as it appears on the @horovits account.
Thanks,
Dotan

Hi @horovits
we need the sign-off on the commit otherwise we cannot merge it.
Could you git commit --amend --signoff and then force push to horovits:update-adopters-logzio?
That would be ok too to merge this PR.

hi @leogr I did the PR again per request, see #1266, assigned to you.
https://github.com/falcosecurity/falco/pull/1266
Thanks

Hey everyone
I have noticed that @horovits1 is now a deleted user ( @ghost ) which can neither reply nor sign-off
cc @horovits are you the same user? If so could you please make this PR again, please?
Thanks in advance

Thank you!


Roadmap

Hey @nguyenhuy!
Terrific project. I'm excited. I've been thinking for some time now to build something similar but never managed to find time to actually write it, so congrats to you.
Do you have a public roadmap or contributor guidelines?

Hey @FredericJacobs, thanks for reaching out. I'm really sorry for this late response, definitely unacceptable! Won't happen again.
I haven't focused much on this project lately, but I have an important improvement under construction. It adds support to ASDK latest features, most noticeably the Box model layout system. I will publish the code and create tickets for known issues/improvements within next week. Hopefully this project will get some traffic! Working alone is not so fun :)
Regarding contributor guidelines, I don't have a clear idea at the moment. I will make a simple document next week. But basically any PR/issue report/feedback is very welcome.
So, please stay tuned and let me know if there is anything I can help regarding this project, or any other OSS ones.
P/S: terrific OSS contributions yourself! Really excited to have a chance to talk to you :)

I have iOS9/Xcode7/Swift 2.0 support for the code on master if that's something you're interested in.

Of course, please open up a PR :)

@FredericJacobs I've pushed my latest improvements as well as the contribution guidelines. The roadmap, in the form of GitHub issues, will be created soon.
With that, I'm gonna close this ticket. Please create a new one if you have any other question/request/feedback. Cheers!


How can I use UITextFiledDelegate Methods like Should change characters with nkvtextfields

General Information

NKVPhonePicker Version:

iOS Version(s):

Swift Version:

Device or Simulator:

Did you check an example:

What happened?
What did you expect to happen?

Clarify your question with examples please.


How to upload file to server ?

I have an image at "/private/var/mobile/Containers/Shared/AppGroup/5D607506-C125-4CF2-BCBB-67EF9F37B10E/image".
I want to push it to the server so that when the user accesses the url "http://localhost/image" the image will be displayed. Is there any way to do that?

You can send the image from the client to your Telegraph server by posting it to an endpoint. This should work fine as long as you're not sending huge photos, because that will use up a lot of memory.

set up a server route that serves all the images in a local folder, this will be the route that your clients will call to display any of the uploaded images
set up a server route that you can use to post images, in the handler you will find the image data in request.body
when you receive image data, write the request.body to the folder that you created in step 1
on the client you can just read the image using the Data class and use a URLSession to post it to your Telegraph server

These resources might be helpful:

Apple: reading data and writing data
Telegraph: HTTP routes
Telegraph: demo app code


New File better flow for beginners

Experiment with the New File flow to make this easier for new users to create a file they want (example python file)
Maybe introduce some submenu actions to make it easier to create new files.
My idea is to leave the Cmd + N action unchanged.
But change how the main menu, and welcome view new file action behave.
Will experiment next milestone with this, thus assigning to February.
fyi @sana-ajani @digitarald @bpasero

What are you thinking for this? Adding a new submenu for "New File"? Something like this?

@sana-ajani that doesn't scale does it? And we need API for extensions to contribute this, no? Maybe a "New File..." that brings up a picker to select from would be better?

I would suggest to first focus on https://github.com/microsoft/vscode/issues/114307
If we get that thing 100% right this one might not be needed. And the only remaining thing would be how to do it for custom editors, and Daniel already has an issue for that.

No plans to change this. Closing


Only works with scope: StickScope.Document ?

I can only get this working using StickScope.Document, if i try StickScope.Parent it doesn’t stick.
From viewing in the inspector just seems to change the position to ‘absolute' rather than ‘fixed’?
Does the parent need to have an id or set width as i’m using percentage based grid?
$('#sticky_column').stickit({ 		screenMinWidth: 740, 		scope: StickScope.Document 		});
It seems to initialise but unless StickScope.Document it just remmed absolute rather than fixed?

Hi,
Can you give a sample code?

My apologies i had put #sticky_column on the inner container rather than the actual column that i wanted to be stuck.

Is it possible to set custom parent? No the actual parent of the stiicky elemnt, but parent of the parent.
Thanks.

hi, @EDsolution
I will try to add this feature in the future.
You could create a new issue to note this.