New version: TheBrowserCompany.Arc version <IP_ADDRESS>093

Created by 🥟 Dumplings in workflow run #9379.

Log
Updated: <IP_ADDRESS>651 → <IP_ADDRESS>093
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978334972
2024-11-07 10:31:13.108 [CORE] Deployment operation #2: Windows cannot install package TheBrowserCompany.Arc_<IP_ADDRESS>093_x64__ttt1ap7aakyb4 because this package depends on a framework that could not be found. Provide the framework "Microsoft.VCLibs.140.00.UWPDesktop" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 14.0.33728.0, along with this package to install. The frameworks with name "Microsoft.VCLibs.140.00.UWPDesktop" currently installed are: {Microsoft.VCLibs.140.00.UWPDesktop_14.0.29231.0_x86__8wekyb3d8bbwe Microsoft.VCLibs.140.00.UWPDesktop_14.0.30035.0_x64__8wekyb3d8bbwe Microsoft.VCLibs.140.00.UWPDesktop_14.0.30704.0_x64__8wekyb3d8bbwe Microsoft.VCLibs.140.00.UWPDesktop_14.0.33321.0_x64__8wekyb3d8bbwe}
2024-11-07 10:31:13.108 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(161)\WindowsPackageManager.dll!00007FFBB1063F75: (caller: 00007FFBB0FBA720) Exception(2) tid(148c) 80073CF3 Package failed updates, dependency or conflict validation.
2024-11-07 10:31:13.255 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFBB1062D2F: (caller: 00007FFBB106432C) Exception(3) tid(148c) 80073CF1 Package was not found.
2024-11-07 10:31:13.255 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(126)\WindowsPackageManager.dll!00007FFBB11D8931: (caller: 00007FFBB1065853) LogHr(2) tid(148c) 80073CF1 Package was not found.
Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFBB1062D2F: (caller: 00007FFBB106432C) Exception(3) tid(148c) 80073CF1 Package was not found.
2024-11-07 10:31:13.288 [CLI ] MSIX installer failed:<PHONE_NUMBER>

Automated error analysis suggests -1978334972 may mean This package has a dependency missing from your system.
Automated error analysis suggests<PHONE_NUMBER> may mean Error Installing Dependency - Windows cannot install this package because it depends on a framework (version) that could not be found.
(Automated response - build 897.)


Ru readme

Thank you for your collaboration. I've updated your README since it was using an old version. I let you proofread it to make sure there's no misunderstanding.

done

Thank you.


Added a better implementation to fix issue #8 (parallel downloads)

Look at all klines that need to be downloaded, break them into chunks of max_limit (currently 1000), and start parallel downloads of all while still respecting Binance API rate limits.
Addresses issue #8

Beautiful work! Thank you @anson-vandoren


Add attachments support

The implementation is based on the one for custom icons as they are stored in the database in a similar format (inside of meta with references from entries). It could be improved further by adding some more convenience methods like getting attachment by key or id but I left that for later consideration.
One thing that I don't know how it works is how the byte data of these attachments is being stored. Perhaps it's encrypted in a similar way to passwords and protected properties?
In tests, I've treated it as byte64 encoded text but that's not true.
Also, there should be a method to add new attachments (currently it's only possible to add references) but I'm not sure where is the best place to implement that.
Closes #50

Thank you for your great work! I've fixed the problem with the base64 encoded binaries. It should work now with all binary data.


Fix flaky tests in ShadowPolicyIntegrationTest

Risk Level: Low
Testing: Unit Test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/backport


Value cannot be null in MixedRealityInputSystem Reset method

Describe the bug
ArgumentNullException is being thrown when MixedRealityInputSystem.Reset() method is being called.
Full StackTrace:

ArgumentNullException: Value cannot be null.
Parameter name: _unity_self
Microsoft.MixedReality.Toolkit.Windows.Input.GestureRecognizerExtensions.UpdateAndResetGestures (UnityEngine.XR.WSA.Input.GestureRecognizer recognizer, UnityEngine.XR.WSA.Input.GestureSettings gestureSettings) (at Assets/MixedRealityToolkit/Extensions/GestureRecognizerExtensions.cs:11)
Microsoft.MixedReality.Toolkit.WindowsMixedReality.Input.WindowsMixedRealityDeviceManager.set_GestureSettings (Microsoft.MixedReality.Toolkit.Windows.Input.WindowsGestureSettings value) (at Assets/MixedRealityToolkit.Providers/WindowsMixedReality/WindowsMixedRealityDeviceManager.cs:178)
Microsoft.MixedReality.Toolkit.WindowsMixedReality.Input.WindowsMixedRealityDeviceManager.Enable () (at Assets/MixedRealityToolkit.Providers/WindowsMixedReality/WindowsMixedRealityDeviceManager.cs:271)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterServiceInternal (System.Type interfaceType, Microsoft.MixedReality.Toolkit.IMixedRealityService serviceInstance) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:834)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterServiceInternal[T] (T serviceInstance) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:849)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterService[T] (System.Type concreteType, Microsoft.MixedReality.Toolkit.Utilities.SupportedPlatforms supportedPlatforms, System.Object[] args) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:206)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterDataProvider[T] (System.Type concreteType, Microsoft.MixedReality.Toolkit.Utilities.SupportedPlatforms supportedPlatforms, System.Object[] args) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:301)
Microsoft.MixedReality.Toolkit.Input.MixedRealityInputSystem.Enable () (at Assets/MixedRealityToolkit.Services/InputSystem/MixedRealityInputSystem.cs:221)
Microsoft.MixedReality.Toolkit.Input.MixedRealityInputSystem.Reset () (at Assets/MixedRealityToolkit.Services/InputSystem/MixedRealityInputSystem.cs:239)
API.Utils.VoiceCommandsHelper.AddVoiceCommands (System.String label, System.String alternative) (at Assets/API/Utils/VoiceCommandsHelper.cs:39)

To reproduce
Steps to reproduce the behavior:
You can use any scene to check this bug. I've used my own scene and also tried it on Speech Demo scene to make sure that nothing from my own code is interfering.

Allow MixedRealityToolkit to initialize
Call Reset() method for MixedRealityInputSystem

Expected behavior
GestureRecognizer should not be null when Reset() method reaches Enable().
Your Setup (please complete the following information)

Unity Version
2018.3.14f1
MRTK Version
MRTK 2.0 RC2.1

Target Platform (please complete the following information)

HoloLens
HoloLens 2

Additional context
I'm trying to add Voice Commands to the MRTK profile in runtime. While adding new keywords wasn't hard (with the use of reflection), they do not work until next startup. While searching for a way to call some kind of registration of the voice commands, I stumbled upon Reset method in IMixedRealityService. Because of this bug I'm not sure if it will help me, but since I've found it I wanted to report it.

@Agredek thanks for reporting this!
There are a known class of bugs around MRTK object shutdown/restart (i.e. see #5085) for another example. This is something we're looking at this iteration.

Thanks for the update, @wiwei!

@Agredek FYI, I'm not sure that I'm going to be able to push in my change for the current iteration because I'm going to be out for a little bit and won't be able to get to the migration tooling before then. Because my change is breaking (in that a thing that is a MonoBehaviour is no longer one), I think that providing the migration tooling is SUPER important before going out.
That being said, I wanted to send out the change so that folks who were interested in grabbing that functionality could unblock themselves - the overall shape of this shouldn't change that much.

@Agredek, can you share a little more on your scenario in which you're using the Reset() or Disable/Enable functionality? Some folks have asked some questions regarding the right way of addressing this and I want to make sure that the linked PR actually does address the scenario you're trying to accomplish.

@wiwei
Hi! Sorry for late response. I've been out on holidays.
Since submiting this issue I've changed my approach to this problem, but if I recall correctly I wanted to add Voice Commands to my dynamically created buttons. Basically I wanted to register all the voice commands on the start and disable them when buttons are removed form the scene. While working on the topic I've discovered that MRTK probably does some work on Awake and adding voice commands this way won't work.


Update Doc k8s.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/

#18503

Hi, @Kartik494 . Thanks for this PR.
 I think the description should not contain commands that automatically close an issue.
https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords
Page preview:
https://deploy-preview-18560--kubernetes-io-master-staging.netlify.com/docs/tasks/access-application-cluster/configure-access-multiple-clusters/

Looks good @Kartik494 . Thanks for the updates!
/lgtm

/approve


Kharmaim

Sync changes between kharmaim and dev.
The kharmaim branch has evolved significantly in the past 6 months and it might be best to merge / rebase changes across branches before they diverge significantly.

Regardless of what's "finished" or not here it's a good idea to sync whenever it's convenient -- and in this case there are a few finished features (drift frame floors!) that will be nice to have more broadly, too.  With the CI tests reinstated, I can be pretty sure I didn't break anything updating the branch, so I'm going to err on the side of keeping the number of forks low, and I'll try to keep up this "merge early" policy going forward.


[10.x] fix Mailable html content

Currently with this code
if ($content->html) {
     $this->view($content->html);
}

an exception is thrown View [htmlcontent] not found. at vendor/laravel/framework/src/Illuminate/View/FileViewFinder.php:137 if
public function content(): Content
{
    return new Content(
        html: '<html></html>'
    );
}

The html parameter is an alias for the view parameter. See https://laravel.com/docs/10.x/mail#plain-text-emails
If you want to use a raw html string, you can use the htmlString parameter. (Although this one is undocumented)


Use Cypress for e2e testing

cypress.io provides an easier to use test suite that might be worth implementing over proactor

Cypress has been added to the repository, under the frontend-e2e app.


python3

also "{" change to remove newline - for opening in libreoffice

Thanks for doing this!
Could you refactor if __name__ == __main__: into a unittest-style test case? Otherwise LGTM

I submitted PR #4 that cleaned up the library today and I think the changes on this branch are no longer necessary. Can you take a look at the new version to confirm that I can close this?

obsolete


Set global object's prototype

The global object should have the same prototype
as a simple object.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal<EMAIL_ADDRESS>

Related test262 test: https://github.com/tc39/test262/blob/es5-tests/test/suite/ch15/15.2/15.2.3/<IP_ADDRESS>/<IP_ADDRESS>-6-6.js

Looks good to me, after adding comment.

make push

+1 lgtm


Micro ros agent compilation failed

vvvv:~/Micro_Ros/uros_ws$ ros2 run micro_ros_setup build_agent.sh
Building micro-ROS Agent
Starting >>> micro_ros_msgs
Finished <<< micro_ros_msgs [2.61s]
Starting >>> micro_ros_agent
--- stderr: micro_ros_agent
/usr/bin/ld: warning: libfastrtps.so.2, needed by /opt/ros/foxy/lib/librmw_fastrtps_shared_cpp.so, may conflict with libfastrtps.so.2.4.1
/usr/bin/ld: CMakeFiles/micro_ros_agent.dir/src/agent/graph_manager/graph_manager.cpp.o: undefined reference to symbol '_ZN8eprosima8fastrtps5types12ReturnCode_t10RETCODE_OKE'
/usr/bin/ld: /opt/ros/foxy/lib/libfastrtps.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/micro_ros_agent.dir/build.make:172: micro_ros_agent] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/micro_ros_agent.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
---
Failed   <<< micro_ros_agent [1.40s, exited with code 2]

Summary: 1 package finished [4.14s]
  1 package failed: micro_ros_agent
  1 package had stderr output: micro_ros_agent

ubuntu - 20.04
Ros fox\y
While building micro ros agent am getting this error. Already fastrtps is available by default ros foxy.
Please help me to resolve issue.

Please provide details for replicating this issue

Ros2 foxty got installed after that followed below steps:
Building:
source /opt/ros/$ROS_DISTRO/setup.bash
mkdir uros_ws && cd uros_ws
git clone -b $ROS_DISTRO https://github.com/micro-ROS/micro_ros_setup.git src/micro_ros_setup
rosdep update && rosdep install --from-paths src --ignore-src -y
colcon build
source install/local_setup.bash
Building micro-ROS-Agent
ros2 run micro_ros_setup create_agent_ws.sh
ros2 run micro_ros_setup build_agent.sh -- Here throwing the error

I have replicated your steps in a clean Foxy environment and it works well: https://asciinema.org/a/CNQQ6XqoUO8mQXBAzB1QLtVZz
Could you please recheck your Foxy installation and try in a fresh one?

I had tried fresh installation many times but there is no use every same time error only.

I'm not sure if I have understood you well. Do you also have this error in a fresh environment? If so, could you provide instructions for replicating it in a clean ROS 2 Foxy Docker?

Any update on this?

Closing due to inactivity


What format would you like to see added to NeuroConv?
Natus is one of the most popular clinical formats for ECoG. Conversion to NWB requested by @dorahermes
Dora, would you be able to share an example data file in the Natus format? Ideally < 10MB?
Does the format have any documentation?
No response
Existing APIs for format
No response
Do you have any example files you are willing to share?
No response
Do you have any interest in helping implement the feature?
No.
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Have you ensured this bug was not already reported?

Would this also fall under neo/SI domain at all? Or hand-implemented in NeuroConv?
https://github.com/search?q=repo%3ANeuralEnsemble%2Fpython-neo natus&type=code 😧

I think this could potentially be in-scope for NEO. From what I gather this is used for ECoG and accompanying sensor data. It would be unusual to record spike-sortable data using Natus, so it may out of scope for SpikeInterface. It may nevertheless be a good idea to implement an extractor in SpikeInterface if that would be the simplest path forward for NeuroConv to support it. I was able to find this package for reading data from the older Natus XLTEK systems. However, I am not aware of any open source APIs for accessing data from their recent quantum systems.


logysia does not work with<EMAIL_ADDRESS>

Adding use(logger({logIP: true})) to Elysia causes the Content-Type on responses to be text/plain instead of text/html.

Updated to now work with RC.


Not working in fragment

Hello Mayank,
Hope you are doing well, I found that using your library and example it does not work in the fragment, it did not receive in fragment onActivityResult method.

did you check the result code in the onActivityResult?


WFLY-5006 support for extended persistence context with SynchronizationType.UNSYNCHRONIZED

I'm not sure why I only saw failures in our org.jboss.as.test.integration.jpa.transaction.TransactionTestCase after Hibernate ORM (5.0) fixed the HHH-9927 bug, but am happy to catch this (JPA 2.1 bug) finally.

Linux Build 7172 is now running using a merge of 4479c43308883128c3f4517b2e3318974844006d

Linux with security manager Build 2044 is now running using a merge of 4479c43308883128c3f4517b2e3318974844006d

Windows Build 2228 is now running using a merge of 4479c43308883128c3f4517b2e3318974844006d

Linux with security manager Build 2044 outcome was SUCCESS using a merge of 4479c43308883128c3f4517b2e3318974844006d
Summary: Tests passed: 879, ignored: 282 Build time: 0:06:24

Linux Build 7172 outcome was SUCCESS using a merge of 4479c43308883128c3f4517b2e3318974844006d
Summary: Tests passed: 2949, ignored: 354 Build time: 0:46:53

Windows Build 2228 outcome was SUCCESS using a merge of 4479c43308883128c3f4517b2e3318974844006d
Summary: Tests passed: 2947, ignored: 355, muted: 1 Build time: 0:47:56

Are you planning to include this fix into 10.1.0?


Code refactored to avoid duplication

I extracted some code that was duplicated into _loopback_exception and _loopback_reqrep functions. Also, the loopback function has been moved to a different part of the file where it makes more sense due to context.

@Flood1993 Looks good to me now. You'll need to rebase again, though. :wink:


Do not hard-code the default remote branch name in the GitHubConfigFileProvider

Currently, the GitHubConfigFileProvider hard-codes the name of the default branch:
https://github.com/eclipse-apoapsis/ort-server/blob/b56e80447f21658c6dc0ebe298d0d4e0877159ef/config/github/src/main/kotlin/GitHubConfigFileProvider.kt#L146-L147
However, the default should ideally be whatever has been configured as the default branch on GitHub for a project.

For reference, this is how the GitConfigFileProvider does it:
https://github.com/eclipse-apoapsis/ort-server/blob/b56e80447f21658c6dc0ebe298d0d4e0877159ef/config/git/src/main/kotlin/GitConfigFileProvider.kt#L112


PROD/WLGN/LOGN/WISH/CACT/BASK - Wishlist and New User Registration

When a user adds something to their wishlist but doesn't have an account, then proceeds to sign up for an account, the product does not get added to their Wishlist. Furthermore, users end up on their WISH page and clients may lose conversions because it doesn't even navigate back to the previous product they wanted to add in the first place. Additionally, when a user without an account checks their basket and clicks "save for later" to move all items to their wishlist, the items are lost if they go through the registration process.
Expected Behavior
Users should be able to enter the registration process from the PROD page or BASK page via adding items to their Wishlist without items getting lost in the mix.
Consider using session IDs or basket IDs to save this information while the user completes their registration process and then create a wishlist and add item(s) to the new wishlist.
Current Behavior
Described in summary
Attempted Fixes
As a quick fix, I hid the save for later feature on BASK for users that aren't logged in. For the PROD/WLGN/LOGN/CACT/WISH process, I've passed the product ID and other basic info like quantity, category, etc throughout the process and added steps to create a default wishlist after user registration is complete on CACT. The meta refresh then takes the user back to the product they were looking at. When I tried to send the item to the newly created wishlist, I encountered a 403 forbidden. I began to set up passing along attributes but felt that with the 403 and knowing that we use sessions in other aspects of the site, there may be a better way to accomplish this.
Steps to Reproduce (for bugs)
Provide a link to a live example, or an unambiguous set of steps to
reproduce this bug. Include code to reproduce, if relevant
A. PROD to wishlist

Be a guest user without an account.
Navigate to PROD.
Add product to wishlist.
Select Register on WLGN.
Proceed to register as a new user on LOGN.
Wait for info to continue through to CACT and the redirect to WISH.
Notice product does not get added to wishlist.

B. BASK save for later

Be a guest user without an account.
Add several items to cart.
Navigate to BASK
Save items for later.
Repeat registration process mentioned in A.
Notice items are lost.

Context
A client has launched their new Shadows site and is experiencing issues with their users claiming their site is broken. We've improved the experience a bit with hiding features behind a check for logged in users and adjusting redirects, but it still isn't ideal for overall UX.
Your Environment
All platforms.
All browsers.

Thank you for your insights on this. Sadly, the functionality you are talking about is platform inherent. I will add this to the enhancement list for a future release and see what I can do to make the process as smooth as possible for customers without an existing account.


Updates to layout of registries

Updates to menu as per discussion with @japierce1028.
Intro for Terms to be added.

closes #76

@japierce1028, just waiting on your approval to merge this.


Make the ValidateFunction interface "$async": true/false aware

What version of Ajv you are you using? 6.12.4
What problem do you want to solve?
compile({ "$async": true/false/undefined, ... }).validate() could generate a type signature more specific than  boolean | PromiseLike<any>, if some type inference is allowed.
What do you think is the correct solution to problem?

Create specific types for async true or false schemas
Overload compile and compileAsync with two different signatures, one for each schema type

Will you be able to implement it?
Maybe? I'm going to try a bit, maybe draft a pull request.

@villasv thanks for the suggestion. Given the coming release of v7 beta by the end of September, it may be better to consider including there. The first release should be on npm even sooner than that.
It's re-written in typescript, so maintaining types is easier there - it would benefit from some review though.
Also, having more precise types for the end users has risks of breaking existing code compilation, so it better if it is a major version change.
There is another popular request #736 with 55 upvotes that seems related - I think they should be considered together.

Oops, did not realize there as a rewrite coming. Will start experimenting with it and see how it goes.
Looks like this one is a requirement for #736, but I don't think they should be considered together. I am not particularly interested in using validation as a type guard, I just want to have my compiler stop complaining that validation results might be a promise (but never will because I don't use async validation).

Pull request updated. Had to compromise a little bit, though.

Should I experiment with and target branch v7-alpha then?

It would be great. The current latest is v7-alpha-resolve, just pushed the last commit - please have a look.

No problem, I can resolve later.  v7-alpha-resolve can be changing too quickly


Move Travis CI from Node v4 to v5

@Scotchester

:+1:

:+1:

Interestingly, Travis ran fine on my updated table-vars PR that I just merged, without having merged this first.


Convey a message when adding fails due to uniqueness.

I need some sort of mini notification alert that can inform user of Streamus' state. This would allow Streamus to say "Item already in playlist" when an item is saved to it and its already in the playlist.

Merging into a more general issue for desktop notifications.


Cli options -n --no-prompt not working

Hello,
When passing the following command :
$ npx frontity create --no-prompt --theme @frontity/mars-theme myapp

or
$ npx frontity create -n --theme @frontity/mars-theme myapp

I'm prompted back
? Do you want to receive framework updates by email? (y/N)

Am I misunderstanding --no-prompt option purpose ?
This blocks my automation for CI/CD cause it's waiting for an answer that will never come.

@hexaltation Thanks for raising this. You're quite right -n/--no-prompt should mean that the command can be used in scripts that don't require any intervention on the part of the user. I've brought this to the attention of our dev team.
Feel free to raise the issue here where it will be more visible to them.
Alternatively, since Frontity is open source, feel free to create a PR with your own fix.

This seems to be a bug
https://github.com/frontity/frontity/issues/538
I close this issue as it will be managed by fixing the code


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4297

Questions ?
Please refer to the Backport tool documentation


Add some new resources, do linting and spellcheck

Greetings, I appreciate your project and hope you'll consider this PR.
I've added a few additional resources and made the linting/accessibility changes my linter asked for.
Happy to see it merged or will make any changes you'd like
Peace, John

What is the spell-checker / linter you're using? So I can add them to recommended extensions for this vscode workspace

What is the spell-checker / linter you're using? So I can add them to recommended extensions for this vscode workspace

Sure, they are:

https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint
https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker

There are merge conflicts now, will resolve momentarily

Ok that's updated now @aborazmeh


Fix Docker HEALTHCHECK

cmd/healthcheck binary to make http(s) requests.
Move HEALTHCHECK to Dockerfile
Verify health in test scripts
Remove unsupported Trillian health checks https://github.com/google/keytransparency/issues/1200

Updated to address comments


Add ability to set currency symbol in formatter config

I want to use ₽ (Russian Ruble sign) instead of руб. when formatting currencies (yii\i18n\Formatter::asCurrency()).
I don't see the way to set it.

Just tried to do that with plain intl number formatter. Did not manage to set the currency symbol.
http://php.net/manual/en/class.numberformatter.php
There is NumberFormatter::CURRENCY_SYMBOL and NumberFormatter::INTL_CURRENCY_SYMBOL. First has no effect at all, second throws an error if I pass them to setSymbol()...
Can you try to make it work with plain intl number formatter? I can introduce it in yii if we found out how it works.

This code works for me:
$fmt = new \NumberFormatter('ru_RU', \NumberFormatter::CURRENCY);
$fmt->setSymbol(\NumberFormatter::CURRENCY_SYMBOL, '₽');
echo $fmt->format(1234567.89);

what about formatCurrency() ? http://php.net/manual/en/numberformatter.formatcurrency.php

Ahh, I see the problem now...

Checked, works. Thanks a lot!

Settings
'formatter' => [
            'dateFormat' => 'dd.MM.yyyy',
            'decimalSeparator' => ',',
            'thousandSeparator' => ' ',
            'currencyCode' => 'RUB',
            'numberFormatterOptions' => [
                NumberFormatter::MIN_FRACTION_DIGITS => 0,
                NumberFormatter::MAX_FRACTION_DIGITS => 2,
            ],
            'numberFormatterSymbols' => [
                NumberFormatter::CURRENCY_SYMBOL => '₽',
            ]
        ],

but CURRENCY_SYMBOL not working for me, show .руб instead my symbol. php 7.1, intl ext installed

@Fisher-mast please open a new issue for this.

duplicates https://github.com/yiisoft/yii2/issues/13629
You should not set 'currencyCode' => 'RUB', then it will be well done.
config
'formatter' => [
            //'currencyCode' => 'RUR',
            'numberFormatterOptions' => [
                NumberFormatter::MIN_FRACTION_DIGITS => 0,
                NumberFormatter::MAX_FRACTION_DIGITS => 0,
            ],
            'numberFormatterSymbols' => [
                NumberFormatter::CURRENCY_SYMBOL => '₽',
            ],
        ],

formatter call
<?= Yii::$app->formatter->asCurrency(Yii::$app->user->balance) ?>

output
200 000 ₽

look inside the yii\i18n\Formatter
    public function asCurrency($value, $currency = null, $options = [], $textOptions = [])
    {
            //...
            $currency = $currency ?: $this->currencyCode;
            if ($currency && !isset($textOptions[NumberFormatter::CURRENCY_CODE])) {
                $textOptions[NumberFormatter::CURRENCY_CODE] = $currency;
            }
            $formatter = $this->createNumberFormatter(NumberFormatter::CURRENCY, null, $options, $textOptions);
            //die(print_r($textOptions, 1));
            //die($formatter->getSymbol(\NumberFormatter::CURRENCY_SYMBOL));
            if ($currency === null) {
                $result = $formatter->format($value);
            } else {
                $result = $formatter->formatCurrency($value, $currency);
            }
            //...

When you setting up a currency code value in Yii config, it creates NumberFormatter with additional options: $textOptions = [5 => 'RUR'], then calls formatCurrency($value, $currency) and results as 'р.'.
$result = $formatter->formatCurrency($value, $currency);

Otherwise it creates calls NumberFormatter with an empty $textOptions = [], calls format($value) and NumberFormatter::CURRENCY_SYMBOL is applied, this results as '₽'.
$result = $formatter->format($value);

This works on both windows/mac notebook and frebsd/centos (or any other) server, with 7 or 5.4 php.
As for me, It's not, a little bit, usable, but it works if you wanna.
Best wishes,
auxww

You can do it


Include file with multi-line arguments causes parser and syntax highlighting issue

When having this include line in my source:
    {rec/zetin.ooi &where="zetin.act
                       AND CAN-FIND(FIRST ztihu WHERE ztihu.zetin_iden = zetin.zetin_iden)"}

The rest of the file is missing code-completion, because the parser doesn't handle this, and also it's 'browned-out' by the syntax highlighter, because of an un-terminated string.
Removing the line-break within the passed string does solve it, but as the ABL compiler and OpenEdge Editor do allow this kind of syntax, it would be nice to have the plugin handle this properly also.
As we have quite a lot of sources using this type of includes, we'd have to change quite a lot of code, and make it less comprehensible, to effectively use the plugin.

While syntax highlight is broken, code completion is not broken (at least in my tests) as this is handled differently.
Syntax highlight is currently done by the TextMate grammar, based on regexp. I'll have a look at that case, and add a fix in future versions if that doesn't break too many things.

The fix will wait for the semantic highlighting to be implemented in the language server (see this thread on why it's impossible to implement that with TextMate grammars). Note that the language server already has all the information to provide the semantic highlight information, so it's just 😄  a matter of implementing the entrypoint.

Note that the prototype of the semantic highlighting is successful. That won't come in the very near future due to other priorities, but at least there's some progress !

What's the state of semantic highlighting. I've come across a similar issue in our source code. For instance if I have this code:
DELETE PROCEDURE test.

RUN kill-prog("test1.p").
RUN kill-prog("test2.p").

The RUN lines are treated like they're within quotation marks, but if I put a space after "test" and before the "." on the first line then it fixes further lines. I'm making the assumption that that's due to the same issue with TextMate.

Semantic highlighting is included in the prerelease stream of the extension (you have to switch to prerelease for this vscode extension). Note that this might not be very stable...
Then it's disabled by default, so add this section in your settings.json:
    "[abl]": {
        "editor.semanticHighlighting.enabled": true
    }

Colors can be a bit weird, but this is controlled by the theme. It's also a bit slower on large files (shouldn't be noticable on small files).
Semantic highlight is work in progress, no need to report issues regarding the (lack of) quality of the semantic tokens.

Closing issue as this is fixed in semantic highlighting (and will never be fixed in the TextMate grammar).

@tonhuisman This may be improved in the latest grammars. There are certain things that cannot be done without semantic highlighting, as @gquerret  says, but there are some changes made to the grammar that improve the highlighting in the cases mentioned in this issue.

@gquerret I hadn't checked for some time, but current released extension solves the highlighting issue, as described in my original comment. Thank you for fixing that 👍


Exclude gemspec file by default for Metrics/BlockLength

This PR excludes gemspec file by default for Metrics/BlockLength cop.
When gemspec file is changed, it is mainly the increase / decrease for add_runtime_dependency and add_development_dependency.
There is no tendency to change with complicated logic.
Also gemspec file made with bundle gem is also warned by default.
% bundle -v
Bundler version 2.0.1
% bundle gem foo
Creating gem 'foo'...
MIT License enabled in config
      create  foo/Gemfile
      create  foo/lib/foo.rb
      create  foo/lib/foo/version.rb
      create  foo/foo.gemspec
      create  foo/Rakefile
      create  foo/README.md
      create  foo/bin/console
      create  foo/bin/setup
      create  foo/.gitignore
      create  foo/.travis.yml
      create  foo/.rspec
      create  foo/spec/spec_helper.rb
      create  foo/spec/foo_spec.rb
      create  foo/LICENSE.txt
Initializing git repo in /private/tmp/foo

% rubocop -v
0.65.0
% rubocop --only Metrics/BlockLength
Inspecting 8 files
C.......

Offenses:

foo.gemspec:6:1: C: Metrics/BlockLength: Block has too many
lines. [26/25]
Gem::Specification.new do |spec| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

8 files inspected, 1 offense detected

Therefore this PR excluded gemspec file by default.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

🙇


Detect when files move and put that in the working tree with git status

Other clients (like Sourcetree) indicate that a file changed location. Our client just commits it without telling you what happened.

Look again and see what's going on.

This is not what other clients do now at least. It is possible to tell with commandline and using some fancy commands, but tracking a 'moved' file is not exactly what Git is meant for: http://stackoverflow.com/questions/2314652/is-it-possible-to-move-rename-files-in-git-and-maintain-their-history. Closing for now...


[GOBBLIN-266] Improve Hive Task setup

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[X] Here are some details about my PR, including screenshots (if applicable):

Allows adding jars and files to Hive session, as well as running setup queries.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@htran1 can you review?


Attempt to invoke interface method 'boolean android.view.inputmethod.InputConnection.finishComposingText()' on a null object reference

Hey there,
here's a crash we received in Bugsnag from on of our production devices:
java.lang.NullPointerException Attempt to invoke interface method 'boolean android.view.inputmethod.InputConnection.finishComposingText()' on a null object reference
    InputConnectionWrapper.java:78 android.view.inputmethod.InputConnectionWrapper.finishComposingText
    InputMethodManager.java:852 android.view.inputmethod.InputMethodManager.reportFinishInputConnection
    ViewRootImpl.java:3523 android.view.ViewRootImpl$ViewRootHandler.handleMessage_aroundBody0
    ViewRootImpl.java:1 android.view.ViewRootImpl$ViewRootHandler$AjcClosure1.run
    ViewRootImplAO.java:82 android.view.ViewRootImplAO.ajc$around$android_view_ViewRootImplAO$3$dffdddeproceed
    ViewRootImplAO.java:87 android.view.ViewRootImplAO.ajc$around$android_view_ViewRootImplAO$3$dffddde
    ViewRootImpl.java:3341 android.view.ViewRootImpl$ViewRootHandler.handleMessage
    Handler.java:102 android.os.Handler.dispatchMessage
    Looper.java:148 android.os.Looper.loop
    ActivityThread.java:5585 android.app.ActivityThread.main
    Method.java:-2 java.lang.reflect.Method.invoke
    ZygoteInit.java:730 com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
    ZygoteInit.java:620 com.android.internal.os.ZygoteInit.main

Steps to reproduce:
Looks like the user was just editing an TextInput field, and then tried to change the input method,
here's a breadcrumb we received in bugsnag milliseconds before the crash:
input_method_id: com.lge.ime/.LgeImeImpl
Intent Action: android.intent.action.INPUT_METHOD_CHANGED

and here's the exact text the client had been typing:
field: notes value: Told customer 9am - 1pm. We will give a 30 minute heads up phone call before arriving
Bosch power cord recall in Huxley in Hartford

The device where this happened was an LG LGUK750 running Android 6.0.1 (API 23)
Environment:
OS: macOS Sierra 10.12.6
Node: 8.4.0
Yarn: 1.5.1
npm: 5.3.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3

We have not updated to 0.55 yet, and I'm not sure how to actually reproduce the issue.

This has happened to me as well. There was no input when this happened. It was in an emulator. It works fine with API 26 and above. It happens when configuration changes portrait to landscape and vise versa. Here is the error produced:
java.lang.NullPointerException: Attempt to invoke interface method 'boolean android.view.inputmethod.InputConnection.finishComposingText()' on a null object reference
at android.view.inputmethod.InputConnectionWrapper.finishComposingText(InputConnectionWrapper.java:78)
at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:362)
at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:78)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

This happened to me because of Advanced Profiling option is enabled.
To disable the advanced profiling, follow these steps:

Select Run > Edit Configurations.
Select your app module in the left pane.
Click the Profiling tab, and then uncheck Enable advanced profiling.
Learn more

After I tried, the problem was solved. Thank you very much

You're welcome!

This sounds like a solution for the dev version of the app, but we received that issue from a production app..

@Chivorns thank you

You're welcome bro

Thank you very much. It worked bro

welcome bro

@Chivorns thank you

@SudoPlz also had this error in production

Don't think this should have been closed

It would be very nivce, if a message which will said something like: "Check if Advanced Profile is enabled, if it is, then disable it", will pop up....

Thank you very much! It added me a lot!

Same issue. any work around?

I haven't enable the profiling, but encounter same issue.
10-30 20:34:22.545 5970-5970/com.smartlifehousekeeper D/AndroidRuntime: Shutting down VM
10-30 20:34:22.549 5970-5970/com.smartlifehousekeeper E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.smartlifehousekeeper, PID: 5970
    java.lang.NullPointerException: Attempt to invoke interface method 'boolean android.view.inputmethod.InputConnection.finishComposingText()' on a null object reference
        at android.view.inputmethod.InputConnectionWrapper.finishComposingText(InputConnectionWrapper.java:150)
        at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:427)
        at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:85)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:171)
        at android.app.ActivityThread.main(ActivityThread.java:6699)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:246)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:783)


[WIP][Model][Kernel][Bugfix] Commits for new MSFT PhiMoE model

In this PR, we will introduce:
Model

New model named PhiMoE.

Kernel

New inference kernels for PhiMoE FP8 quantization on Nvidia A100.

Bugfix
Fix a LongRoPE bug on stale kv cache
[Bug Description]
When the len(input) < N and len(input + generated content) > N (N is the original_position_embeddings of the model. For phi models, N=4096), models using LongRoPE will generate garbage from the N-th token. This bug was captured by this community post.
[Root Cause]
In LongRoPE, before the N-th tokens, model uses short factors, after the N-th token, model switch to use long factors. However, after the N-th token, the previous N tokens' kv cache is stale now.
[Fix]
If initial input < N, whatever number of tokens to generate in this call, keep using short factor.
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@wenxcs Could you please separate the addition of the new model and the new quantization method into separate PRs? The  PhiMoE model seems like it should be simple to land and we have existing quantized FusedMoE methods it could use in the immediate-term

Hi @mgoin, thanks for your advice. I'm seperating this PR into two PRs.

The model related part: #7729
The quantization part: (TBD)


UartRemote.send sends twice the same message

Solved: When implemementing the SPIKE windowed send function, the else (not SPIKE) branch writes a messgae, and outside of the if statement again. Removed the write from outside the loop


Suspect sharp()....toFile() do not release input file on Windows.

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
I cannot run it because it is not in my environment. The known environments are as follows.
Windows 11
node.js v20.11.0
sharp 0.33.2

// webpack
"ts-loader": "^9.5.1",
"ts-node": "^10.9.2",
"webpack": "^5.90.3",
"webpack-cli": "^5.1.4",
"webpack-node-externals": "^3.0.0"

This error did not occur on macOS (12.7.3 x64).
What are the steps to reproduce?

run sharp(<targetFilePath>)....toFile(<destPath>).
after resolve, try to delete the file  given to sharp(<targetFilePath>).
the following error occurs.

[Error: EPERM: operation not permitted, unlink '<targetFilePath>'] {
    errno: -4048,
    code: 'EPERM',
    syscall: 'unlink',
    path: '<targetFilePath>'
}

What is the expected behaviour?
The above error started happening after updating to 0.33.2. Before the update, I was using 0.32.3 and had no errors. Then I reverted back to 0.32.3 and the above error no longer occurs. My code has not been changed.
I can only guess, but I suspect that await sharp() ... .toFile(destPath); do not release <targetFilePath> file even after resolve.
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
Here is the actual code. Run it on Windows.
import sharp from 'sharp';
import { rm } from 'fs';

const remove = async (path: string): Promise<void | never> => {
    return new Promise<void | never>((resolve, reject) => {
        rm(path, { recursive: true }, (error) => {
            if (error) {
                reject(error);
                return;
            }
            resolve();
        });
    });
};

const resizeAndToWebp = async (
    targetFilePath: string,
    destPath: string,
    maxWidth: number,
    maxHeight: number,
    fit?: keyof sharp.FitEnum
) => {
    await sharp(targetFilePath)
        .rotate()
        .resize({
            width: maxWidth,
            height: maxHeight,
            fit,
            withoutEnlargement: true,
        })
        .webp({
            effort: 6,
        })
        .toFile(destPath);

    if (targetFilePath !== destPath) {
        await remove(targetFilePath); // an error occurs as above
    }
};

Please provide sample image(s) that help explain this problem
No screenshots. A sample repository can be provided if needed.

Windows won't let you delete a file whilst it is held open by libvips' cache.
Please see https://github.com/lovell/sharp/issues/3099#issuecomment-1140900378


Adjust flogger.backend_factory property

After the change to 0.7.4 the #getInstance part should have been removed. Fixes #29.

I've realized that 0.7.4 backend just wont work with 0.5.1 rest. I'll rework this.


ES6 Rules

This will make everyone forced to adopt ES6 syntaxes whether or not they like it

I'm happy with this.


Permissions incorrect (?)

The article states a user needs "db_ddladmin and db_owner fixed database roles" in order to create indexes.  I don't believe this to be correct, a user can create indexes with just db_ddladmin database role.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13793c61-629f-f379-fcb7-e9178e4f5dce
Version Independent ID: ced6efc1-1e34-f452-f995-b597e812c2f2
Content: CREATE INDEX (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/create-index-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @pmasl
Microsoft Alias: carlrab

fixing now: https://github.com/MicrosoftDocs/sql-docs-pr/pull/14157
@jimp100 sorry it took us this long - slipped through the cracks.


converting to nullable

"You can also explicitly cast a nullable value type to a non-nullable type, as the following example shows:..."
No I can't!  Visual Studio gives me a CS0030 error if I try to do this.
double StandarDeviation(List<(double)> x) {	double avr = 0; 	x.ForEach((num) => avr += (double)num); 	return 1.0;//Stub }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3e65a97-5e33-ab78-cd40-b20c3219ca2f
Version Independent ID: 1ae0aed9-e565-44ae-aebe-c55a0a02c2c5
Content: Nullable value types - C# reference
Content Source: docs/csharp/language-reference/builtin-types/nullable-value-types.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Okay removing the () in List<(double)> seems to have resolved the issue, but still a terrible error message.

When I compile your code, I get two error messages:

error CS8124: Tuple must contain at least two elements.
error CS0030: Cannot convert type '(double, ?)' to 'double'

The second one should make you think there's something wrong with the type of num, and the first one explains what the actual problem is. So it seems to me that the error messages here are reasonable and helpful.

Hmm... error CS8124 never showed up for me, and I'm using a 2019 version.
Well thanks for looking into it.
On Mon, Jul 25, 2022 at 2:09 AM Petr Onderka @.***>
wrote:

When I compile your code
https://sharplab.io/#v2:C4LgbgpgTglgZgTwDQBMQGoA+ABADAAmwEYAWAbgFgAoalAewFcAjAGwnwGVgBDAOxW5QAIhDAxuwGHV4AKADIwAzsAA8M+szYBKAHz4AHluoBvavnP4NrdtzBR8AXny5KVCwYB0AMTpQAotwAxgAWMjK8DAC2Wo56tvboTuqM1loR0a7u2ADs+EQeLtQAvkA===,
I get two error messages:
error CS8124: Tuple must contain at least two elements.
error CS0030: Cannot convert type '(double, ?)' to 'double'
The second one should make you think there's something wrong with the type
of num, and the first one explains what the actual problem is. So it
seems to me that the error messages here are reasonable and helpful.
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/issues/30334#issuecomment-1193786445, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRWGOFIPVDDJFSPH7J7IX3VVZKULANCNFSM54QX73KA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for noting this @CastonYoung
And for the helpful analysis @svick
I'm going to close this as it's not relevant to the linked error message.


Add connect 4 minigame

Steal Antisynth's code and port it to Python https://cdn.discordapp.com/attachments/755160719619522616/784096393076670464/message.txt
Command syntax:
!connectfour/connect4/c4
Show an embed with a 7x7 grid of white, yellow, and red circles, with the bottom row being numbers. The message is reacted to with numbers 1-7, to which the players can react to. Reacting to a message will add a yellow/red circle at the bottom of that column. Having four circles diagonally, horizontally, or vertically in a row will have them win the game.

Resolved by https://github.com/mat-1/forum-sweats/commit/a2c32b7ec6c1752862218501e9ac054982c3d575


Test for xSQLServerPermission

Added test for xSQLServerPermission
Added stub file for mocking SMO
Fixed New-TerminationError so it uses InnerException more correctly
Changed xSQLServerPermission so it uses property names in the validate set instead. This was done for the test to work and the benefit was less code

This change is

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

xSQLServerHelper.psm1, line 125 [r2] (raw file):

    Write-Verbose -Message "$($USLocalizedData.$ErrorType -f $FormatArgs) | ErrorType: $errorId"

    $exception = New-Object System.Exception $errorMessage, $InnerException;

This has a semicolon after it

Comments from Reviewable

Review status: 4 of 5 files reviewed at latest revision, 1 unresolved discussion.

xSQLServerHelper.psm1, line 125 [r2] (raw file):
Previously, johlju (Johan Ljunggren) wrote…
> This has a semicolon after it

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Add CEN to ERRBIT

There are no reports from CEN system crashes on ERRBIT

Looking into this. We think Vino may have this fixed - which means we should see error reports coming through IF there is a crash. Need to check.

Tested and configured ok on local dev environment.  Will be live on FreeCEN2 production, test2 & 3 after running the update scripts for this sprint.


Bad Flag and Green Square Image

Using a Pi 4
A PiNoir Camera - compiled from Pull 36
Getting an output image of a large green Square
Before loading the allsky software camera was working and giving an image
Thanks for the help and merry christmas
Also which file name should I be using
Image.jpg
Liveview-Image.jpg
Resize-Image.jpg
When Running allsky.sh I get the following
OpenCV Error: Bad flag (parameter or structure field) (Unrecognized or unsupported array type) in cvGetMat, file /build/opencv-L65chJ/opencv-3.2.0+dfsg/modules/core/src/array.cpp, line 2501
terminate called after throwing an instance of 'cv::Exception'
what():  /build/opencv-L65chJ/opencv-3.2.0+dfsg/modules/core/src/array.cpp:2501: error: (-206) Unrecognized or unsupported array type in function cvGetMat
./allsky.sh: line 25:  1972 Aborted                 ./capture $ARGUMENTS
pi@allsky:~/allsky $
Allsky.sh file has had the ZWO info taken out about file is below
#!/bin/bash
source /home/pi/allsky/config.sh
source /home/pi/allsky/scripts/filename.sh
echo "Starting allsky camera..."
cd /home/pi/allsky
Building the arguments to pass to the capture binary
ARGUMENTS=""
KEYS=( $(jq -r 'keys[]' $CAMERA_SETTINGS) )
for KEY in ${KEYS[@]}
do
ARGUMENTS="$ARGUMENTS -$KEY jq -r '.'$KEY $CAMERA_SETTINGS "
done
When using a desktop environment (Remote Desktop, VNC, HDMI output, etc), a preview of the capture can be displayed in a separate window
The preview mode does not work if allsky.sh is started as a service or if the debian distribution has no desktop environment.
if [[ $1 == "preview" ]] ; then
ARGUMENTS="$ARGUMENTS -preview 1"
fi
ARGUMENTS="$ARGUMENTS -daytime $DAYTIME"
echo "$ARGUMENTS">>log.txt
./capture $ARGUMENTS
Not sure if it has something to doe with the Capture CPP from Pull request 36 as found this
/usr/include/opencv2/core/mat.inl.hpp:333:1: note:   candidate expects 0 arguments, 1 provided
capture.cpp:115:7: error: ‘putText’ is not a member of ‘cv’
cv::putText(mat_img, text, cvPoint(x, y), fontname, fontsize, cvScalar(fontcolor[0],fontcolor[1],fontcolor[2], 255), linewidth, linetype);
^~~~~~~
capture.cpp:115:7: note: suggested alternative: ‘Mutex’
cv::putText(mat_img, text, cvPoint(x, y), fontname, fontsize, cvScalar(fontcolor[0],fontcolor[1],fontcolor[2], 255), linewidth, linetype);
^~~~~~~
Mutex
make: *** [Makefile:40: capture] Error 1

Try this maybe: https://stackoverflow.com/questions/36989044/error-puttext-is-not-a-member-of-cv

Thanks that sort of worked but now getting
penCV Error: Bad flag (parameter or structure field) (Unrecognized or unsupported array type) in cvGetMat, file /build/opencv-L65chJ/opencv-3.2.0+dfsg/modules/core/src/array.cpp, line 2501
terminate called after throwing an instance of 'cv::Exception'
what():  /build/opencv-L65chJ/opencv-3.2.0+dfsg/modules/core/src/array.cpp:2501: error: (-206) Unrecognized or unsupported array type in function cvGetMat
./allsky.sh: line 27:  1577 Aborted                 ./capture $ARGUMENTS

looks like a new issue has appeared so closing this one


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependabot-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[x] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[x] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report
Patch coverage has no change and project coverage change: -0.09 :warning:

Comparison is base (c2dacf9) 81.81% compared to head (3d21732) 81.72%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   81.81%   81.72%   -0.09%
==========================================
  Files          41       41
  Lines        1127     1127
==========================================
- Hits          922      921       -1
- Misses        205      206       +1

Flag
Coverage Δ

linux
81.72% <ø> (ø)

linux-extra_libs
81.72% <ø> (ø)

windows
?

windows-extra_libs
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add support for no retransmit after an error

The MCP25xxFD has support for disabling error retransmission. Add to the API the option to select this.

For the MCP25xxFD this is a bit tricky: the drivers pick up the frame transmit events to mark them off from the internal buffer structures, but when the controller gives up on re-transmitting a frame that event doesn't show up as a transmit event.
Instead of a transmit event, there's a "I gave up" interrupt. This doesn't say which frames were given up on. Unfortunately, reading out which buffers are empty and matching this up isn't so easy: by the time the interrupt is handled, another frame might have been sent (CAN frames can be sent in as little at 47 microseconds). Resolving this race is not straightforward.

One possible way to resolve this is when TXQ is not full, and TXQUA points to a buffer that the drivers have marked as a frame to send, then the buffer slot must be empty, and if the frame did not appear in the transmit event queue then the frame must have been aborted at some point. The drivers must record the TXQUA value for each frame queued so that this can be matched up, and there are races to deal with where the transmit queue must be processed before any decision is made on whether a frame was aborted.

There is also the issue of reporting the space left in the queue: the driver has no idea how much space there is left because it cannot see which frames were abandoned after an error. So get_send_space() will be pessimistic. Send space of 0 can be tested by asking the controller if the buffer is empty or not (there is just a 1-bit flag).


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

🤪

👋🏻

Hello :-)

Yes we can

Issue is our issue here really that is an issue ?


Unable to create folder in Data lake from Storage explorer - Intermittent issue

{
"name": "FetchError",
"message": "request to https://hostname/data/AA%2FBB%2FCC%2FDD%2FEE?resource=directory&timeout=60 failed, reason: tunneling socket could not be established, statusCode=407",
"type": "system",
"errno": "ECONNRESET",
"code": "ECONNRESET",
"stack": "FetchError: request to https://hostname/data/AA%2FBB%2FCC%2FDD%2FEE?
resource=directory&timeout=60 failed, reason: tunneling socket could not be established, statusCode=407\n    at ClientRequest. (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\node-fetch\lib\index.js:1455:11)\n    at ClientRequest.emit (events.js:182:13)\n    at ClientRequest.onConnect (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\@azure\ms-rest-js\node_modules\tunnel\lib\tunnel.js:157:23)\n    at Object.onceWrapper (events.js:273:13)\n    at ClientRequest.emit (events.js:182:13)\n    at Socket.socketOnData (_http_client.js:474:11)\n    at Socket.emit (events.js:182:13)\n    at addChunk (_stream_readable.js:283:12)\n    at readableAddChunk (_stream_readable.js:264:11)\n    at Socket.Readable.push (_stream_readable.js:219:10)"
}

This may be due to your proxy server not being available all the time.

Closing due to lack of response. If you are still encountering this problem please open a new issue. Thanks!


.js error on start of Discord (MAC)

After installing the most recent BD on MAC, when trying to start Discord I get a .js error.

Can you post the error?

install.sh ; exit;
module.js:339
throw err;
^
Error: Cannot find module '/Users/user/index.js'
at Function.Module._resolveFilename (module.js:337:15)
at Function.Module._load (module.js:287:25)
at Function.Module.runMain (module.js:467:10)
at startup (node.js:136:18)
at node.js:963:3
logout

Try running the index.js directly with: node index.js

I got the error that OP recieved when I ran the .sh file. I attempted to run "node index.js" directly, but got almost the exact same error:
module.js:328
    throw err;
    ^

Error: Cannot find module '/Users/[MyUserName]/index.js'
    at Function.Module._resolveFilename (module.js:326:15)
    at Function.Module._load (module.js:277:25)
    at Function.Module.runMain (module.js:430:10)
    at startup (node.js:141:18)
    at node.js:980:3

I installed the js module at https://nodejs.org/en/, and I get this message at the end:
Node.js was installed at

   /usr/local/bin/node

npm was installed at

   /usr/local/bin/npm

Make sure that /usr/local/bin is in your $PATH.
~~~

Does this message imply I can fix this issue by just moving the index.js file or is there more to this?

Thanks for the assistance.

 What do you mean "use absolute paths", because google's explanation is vague at best.

Like: node.js "fullpathtoindex.js"

So, I attempted to do a command and this occurred:
"MAC NAME":~ "USERNAME"$ /usr/local/bin/node

node index.js
SyntaxError: Unexpected identifier
at Object.exports.createScript (vm.js:24:10)
at REPLServer.defaultEval (repl.js:221:25)
at bound (domain.js:287:14)
at REPLServer.runBound [as eval] (domain.js:300:12)
at REPLServer. (repl.js:412:12)
at emitOne (events.js:82:20)
at REPLServer.emit (events.js:169:7)
at REPLServer.Interface._onLine (readline.js:210:10)
at REPLServer.Interface._line (readline.js:549:8)
at REPLServer.Interface._ttyWrite (readline.js:826:14)

So is there something I'm doing wrong?
I also tried downloading the binary files and running the installer while they were in the same folder. I encountered the same folder.
Sorry for the extremely noobish questions, but would it be possible to put up a video or something to show how one installs this?
I apologize for the inconvenience and thank you for the assistance! : )

Remove node and npm from your computer and install again.
For Video Installation please go through https://docs.npmjs.com/getting-started/installing-node.
This contains the steps and also the complete documentation.
I hope you were asking about this.

Remove node and npm from your computer and install again.
For Video Installation please go through https://docs.npmjs.com/getting-started/installing-node.
This contains the steps and also the complete documentation.
I hope you were asking about this.


LEF Generation hangs on some designs

The Magic.WriteLEF step can hang on some designs/is generally buggy

Issue confirmed to be https://github.com/The-OpenROAD-Project/OpenLane/issues/1816 in OpenLane 1- reverting Magic


Infix To Postfix Using Array in C

Description
To Convert Infix Expression To Postfix Expression In C :)
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign

/assign


git rebase -i fails on empty commits

We need to find a way for devs to remove CARRY commits without force-pushing. Creating a revert of a CARRY commit as a SQUASH does not work because git rebase -i doesn't know what to do with the empty commit. We may want to add logic and identify empty commits before actually doing the rebase and drop all those commits automatically.
Found in https://github.com/openshift/aos-cd-jobs/pull/258
@stevekuznetsov @jupierce

git rebase -i --keep-empty

Followed by
for commit_sha in ${some_range}; do
    if [[ -z "$( git diff "${commit_sha}" )" ]]; then
        # empty commit
    fi
done

?


Add lightweight-charts in Reflex

Description
Could you create a lightweight-chart wrapper for Reflex? 🙏
Code example
No response
Method of implementation
No response

YO you can adapt in what ever you want with cursor. I put to work in Django running flawless

@cilindro5432 can you give a bit more details please on how you made it work with Django using lightweight-charts-python?


Crash-loop when a Service Binding remains with no Service Instance

Hi team,
When instantiating a Service Instance with a Service Binding in the same deployment, but the Service Instance provision failed and turned into a blocked status, one can be willing to delete the instance to be able to create a new one, while the Service Binding is still hanging. Unfortunately, this makes the btp-operator crash-loop with the following error (here the policysearch-canary-ai-core is the instance that doesn't exist anymore) :
2024-01-04T08:54:29Z INFO controllers.ServiceBinding getting service instance named policysearch-canary-ai-core in namespace pss for binding policysearch-canary-api-ai-core-binding in namespace pss
{"name":"policysearch-canary-api-ai-core-binding","namespace":"pss"}, "correlation_id": "3c453ac1-6ec3-49b9-8ae2-53c2e14baa86", "policysearch-canary-api-ai-core-binding": "pss"}
2024-01-04T08:54:29Z INFO Observed a panic in reconciler: runtime error: invalid memory address or nil pointer dereference {"controller": "servicebinding", "controllerGroup": "services.cloud.sap.com", "controllerKind": "ServiceBinding", "ServiceBinding": {"name":"policysearch-canary-api-ai-core-binding","namespace":"pss"}, "namespace": "pss", "name": "policysearch-canary-api-ai-core-binding", "reconcileID": "c2146269-ec7e-4aba-b7aa-a676f7347090"}
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1a0 pc=0x14a2ca4]
goroutine 108 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:115 +0x1e5
panic({0x1607de0?, 0x25f3ed0?})
/usr/local/go/src/runtime/panic.go:914 +0x21f
github.com/SAP/sap-btp-service-operator/controllers.(*ServiceBindingReconciler).Reconcile(0xc0000be378, {0x1a59d58, 0xc0000a6f60}, {{{0xc000013a1c, 0x3}, {0xc000049740, 0x27}}})
/workspace/controllers/servicebinding_controller.go:110 +0x664
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x1a59d58?, {0x1a59d58?, 0xc0000a6f60?}, {{{0xc000013a1c?, 0x155ee20?}, {0xc000049740?, 0x1a4b950?}}})
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:118 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc000293e00, {0x1a59d90, 0xc000000820}, {0x167c900?, 0xc0000a8240?})
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:314 +0x368
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc000293e00, {0x1a59d90, 0xc000000820})
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265 +0x1c9
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 56
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:222 +0x565

Since the btp-operator is not healthy anymore, even deleting the remaining Service Binding is impossible. Moreover, further app deployments fail as long as they contain resources managed by operator, even without any change. So the user is blocked and only has two solutions : uninstall btp-operator and potentially break their app, or build a new cluster from scratch.

I think this is fixed by #386

Confirmed the issue is fixed after deployment of version 0.5.10


Hofix/rule rendering

요약

이 PR은 다음 버그/기능을 수정/구현합니다.

[X] Fix rules that were only partially rendered

but it pr is hotfix, I approve beacause fix the rendering bugs

The PR is Hotfix, so we will create a branch and solve the review later.
issue #108

solve the problem that suggest at this for pr
#109


script enhance

script support leetcode-cn by remove the suffix of -cn

now it can auto-convert cn url or old url to national url , enjoy XD


spec.failurePolicy: reinstall as a default is extremely dangerous

Having spec.failurePolicy defaulted to reinstall could cause serious incident.
Example: using HelmChart to install CNI such as Cilium, with next version upgrade chart is failing or being blocked with some admission controller such as kyverno. Then helm-controller removes Cilium and tries to install it again which might also fail if that was blocked by admission controller.

K3s and RKE2 depend on the Helm controller being able to uninstall and reinstall packaged charts in order to ensure that the components are updated. We added control over failure policy as a way for administrators to opt in to manually handling stuck charts, but we do not plan to change the default.


Swift 4.2 Support

Its giving me compile error when I am trying to build with new XCode 10

Hi
Compatibility with Xcode 10 and Swift language version 4.2 support will be available in the next few days.

This has been resolved in #95


how to use indexd

Hello,
from the issues I read I found out perhaps I am not using the indexd module correctly. There is a standalone index server as I could read, is this a module for it?
In the previous commit (53506f08ef77bcdca3fb6230a5aea84c3fbaa875) I could run node test/index.js and the index leveldb would be populated with debug output visible on the console.
When using the latest commit I can do queries navigating to express example page, but I do not see the db being populated anymore.
Would like to ask your kind help in setting it up, or pointing me to a readme where it is noted how to run it.

@KanoczTomas I'll add a npm run target to start the example/ service/server.

That would be cool! I found out that the db was actually populated, but there was no debug output eventhough I had DEBUG=* in my .env. After doing export DEBUG=* in the terminal and running the example afterwards I saw all debug messages. I might be doing something wrong that DEBUG is not being applied from .env ...

npm start should work now as is


js-interop: Missing documentation for v0.6.1

On pub.dartlang.org/packages/js, the documentation is for version 0.6.0. And www.dartdocs.org/documentation/js/0.6.1/ does not exist. It seems there was a build failure for the documentation (see www.dartdocs.org/documentation/js/0.6.1/log.txt)

It looks like js's dependency on 1.19 is the issue. @astashov, now that 1.19.1 has fixed the dartdoc breakage, could we update dartdocs.org to use that?

Can I start using the dev version again? 1.20.whatever-dev?

Yes, I think so. At least, I don't know of any reason why it wouldn't work, and it seems good to use the latest.

This issue is for package:js, rather than dart:js. Switching labels.

The link http://www.dartdocs.org/documentation/js/0.6.1/ now forwards to https://pub.dartlang.org/documentation/js/0.6.1/, which looks ok to me. I'm closing this.


Styling of the selected date buttons

Hey @spongessuck
i know this is an existing issue. Just wanted to know whether this has been fixed for the latest UI bootstrap in any recent release ?
Thanks in advance..

Hi, @sumiangi.
If you could post a demo of the problem, that would be helpful.

Hey @spongessuck
Let me clarify.
Its just that for uib datepicker popup if i am selecting multiple dates then those dates should be highlighted as selected if i am again opening the popup.
please let me know if you still need the demo. I will create a Plunk.
Thanks in advance.

Yes, please post a plunk and I'll check it out.

Closed due to lack of activity.


Field «destination» at APIv2::Entities::Withdraw should be presented as APIv2::Entities::WithdrawDestination


luci-app-advanced-reboot: Add support for Linksys EA7500 v2

Very similar to the EA7300 v2. Tested and working. Some details,
# (dmesg | grep machine)
[    0.000000] MIPS: machine is Linksys EA7500 v2

# cat /proc/mtd
dev:    size   erasesize  name
mtd0: 00080000 00020000 "boot"
mtd1: 00040000 00020000 "u_env"
mtd2: 00040000 00020000 "factory"
mtd3: 00040000 00020000 "s_env"
mtd4: 00040000 00020000 "devinfo"
mtd5: 00400000 00020000 "kernel1"
mtd6: 02400000 00020000 "rootfs1"
mtd7: 00400000 00020000 "kernel2"
mtd8: 02400000 00020000 "ubi"
mtd9: 00100000 00020000 "sysdiag"
mtd10: 02d00000 00020000 "syscfg"

# ubus call system board
{
        "kernel": "5.10.111",
        "hostname": "OpenWrt",
        "system": "MediaTek MT7621 ver:1 eco:3",
        "model": "Linksys EA7500 v2",
        "board_name": "linksys,ea7500-v2",
        "rootfs_type": "squashfs",
        "release": {
                "distribution": "OpenWrt",
                "version": "SNAPSHOT",
                "revision": "r19508-0d2d52df69",
                "target": "ramips/mt7621",
                "description": "OpenWrt SNAPSHOT r19508-0d2d52df69"
        }
}

Signed-off-by: Russell Morris<EMAIL_ADDRESS>

Thank you. Could you please confirm the version(s) you've tested this on?

NP! Sorry, not quite sure what you mean - the info below shows the tested HW ... or are you looking for something else?
Thanks!

NP! Sorry, not quite sure what you mean - the info below shows the tested HW ... or are you looking for something else?
Thanks!

I was wondering if this should be cherrypicked for any stable branches -- are/were you able to test on any of them? Is the HW supported in any stable versions. There was some renaming of internal names for Linksys products, so what worked on master in the past may not have worked on stable branches. If you have the opportunity to look into that, it will be much appreciated.

I do not think that there has been any renaming since 21.02.
(and the renaming in 2020 affected the mvebu routers that had codenames).
19.07 was declared end-of-life last week, so currently only 21.02. and 22.03 branches are active.

I was wondering if this should be cherrypicked for any stable branches -- are/were you able to test on any of them? Is the HW supported in any stable versions. There was some renaming of internal names for Linksys products, so what worked on master in the past may not have worked on stable branches. If you have the opportunity to look into that, it will be much appreciated.

More than happy to! But first, need to get the dual-partition support accepted to the stable branch (of openwrt). I have also submitted a PR there, to master => cherry-pick after. Do the same here perhaps (i.e. on master, then cherry-pick once openwrt PR is accepted)?
Thanks!

Thanks! Let me know if the HW support gets backported/cherry-picked so I could cherry-pick this commit to stable.

Will do, thanks! FYI, this is the PR,
https://github.com/openwrt/openwrt/pull/9749


Add wire:navigate to Action url method

Adds wire:navigate logic to the Action ->url() method.
FilamentView::hasSpaMode() wasn't working - maybe because I'm testing in a standlone SimplePage which I've manually associated with a panel using setCurrentPanel()? Getting it from the panel works though.

Please open an issue with a reproduction as the current implementation should already do this

@danharrin Did some more digging and yeah, it’s an edge case. I have some standalone pages that I’m routing to directly. It’s happening in those.
Not worth investigating. I’ll just add wire:navigate via extraAttributes.


Create ClusterRoles for accessing GlobalnetEgressIP CRD

What would you like to be added:
As part of Globalnet Enhancement, GlobalnetEgressIP will enable users to create EgressIPs for inter-cluster communication.
This request is to track the necessary Cluster roles in submariner-operator.

bump


P2P camera stream sometimes not decoded properly

First of all I'd like to say thank you for the amazing work on this component. it's really come a long way.
When it comes to P2P streaming however I am experiencing some issues. The camera stream sometimes looks like this:

It seems completely random: Sometimes the picture is perfect and sometimes only the first few rows look correct while the rest is garbage.
I am using your very latest version of addon and custom component (with the recent TCP fixes for P2P). I also played around with the "Video analyze duration" but it does not seem to have any effect.
My camera is a Eufy Security Doorbell T8200 with latest firmware,

Do you know which codex you are using? You can see in the logs when image is broken.

where do I see these logs?
What I found is this:
Source: custom_components/eufy_security/camera.py:238
Integration: Eufy Security ([documentation](https://github.com/fuatakgun/eufy_security), [issues](https://github.com/fuatakgun/eufy_security/issues))
First occurred: 06:34:25 (56977 occurrences)
Last logged: 09:06:38

Unable to send payload : [Errno 32] Broken pipe

This logs seems to come every few milliseconds
Concerning your other question: Yes, in general the stream stability is much better with this version. Starting the stream is much more reliable and it also the stream holds up very long

do I need for other logs? e.g. in the addon? Maybe I need to enable more logs?

Are you using WebRTC as well? Looks a lot like the issues that I'm having (also have a T8200):
https://github.com/fuatakgun/eufy_security/issues/434

Yes I do.
Actually I suspect the WebRTC card to be part of the problem.
I had a situation where I had 2 clients showing the same stream but only one video was broken.
But I need to confirm that behavior again

Then it is probably related to WebRTC, but the problem is that we don't know if the issue exists in the eufy_security integration or in WebRTC. How can we exclude one another?

You can test native home assistant streaming without Webrtc to find out root cause.

You can test native home assistant streaming without Webrtc to find out root cause.

Native streaming through P2P is working fine, it's just quite slow. If I open a pop-up when someone rang the doorbell it takes ~5 seconds until I finally see the livestream.
So what you're saying is that if this works, then it must be on the side of WebRTC?

@oischinger I found out that the issue is related to MSE. WebRTC is working fine. The problem (for me) is that "mse: false" is not working, the stream just doesn't load at all. Could you try this out if that works for you?
I'm using AlexxIT's new add-on called Go2RTC, which works for me, but I'm not entirely sure if its really using it, as I have a big delay of 10 seconds, after starting the stream, before it gives me an image.
Hopefully you have some more success.

@Xitro01 For me it doesn't make a difference if mse is on or off.
However I am quite confident that the issue is related to the webRTC component. I reproduced the situation where the stream was working on one device and corrupted on anoter

@Xitro01  did you setup go2rtc successfully? I can't get it to show any stream

@Xitro01 did you setup go2rtc successfully? I can't get it to show any stream

It works, when I open the addon tab and click WebRTC it works instantly (MSE still gives me those problems). Not entirely sure if I’m showing it correctly in lovelace at the moment, as it still takes 10 seconds to load it. I’m doing something wrong, not sure what I’m missing.

OK, I figured it. I had to change the port of "RTSP Simple Server" to 8555 and add the stream rtsp://IP:8555/SERIAL_NUMBER  manually to Go2RTC via the web interface: http://IP:1984
That allowed me to watch the camera stream within the go2RTC web frontend. I guess to be able to use the very same stream in Home Assistant one could use the RTSPtoWebRTC integration and setup a generic camera with the RTSP stream coming from go2RTC
Boy, that's a lot of integrations/addons just to show a camera picture ;)
I really think this should be way simplified.
Ideally the eufy camera integration wouldn't start ffmpeg at all anymore. Instead go2RTC could be set up to use an FFMPEG Source, listening to the same port hat the eufy integration sends the P2P data.
That would directly give us a rtsp stream from go2rtc without the need for running RTSP simple server.
@fuatakgun Do you think makes sense?
From a functional perspective go2RTC solves one problem: My stream sin't corrupted anymore

How can we generate any stream without starting a ffmpeg process? Keep in mind, p2p means, data is coming as chunks and ffmpeg should put them together. How should it matter if ffmpeg is started by home assistant or any external add on?
Currently, p2p works like this;

eufy security ws sends bytes to eufy security integration
eufy security integration initializes ffmpeg process and create a stream on rtsp server
home assistant native or webrtc shows the stream on rtsp server

Open to suggestions on this flow

Your stream is not corrupted because webrtc had having issues to render it correctly. i can replace go2rtc as a new dependency but it should also replace rtsp server.

How can we generate any stream without starting a ffmpeg process?

go2rtc will create the ffmpeg process.
I just hacke together a little proof-of-concept:
Create a go2rtc.yaml:
streams:   mystream: ffmpeg:tcp://<IP_ADDRESS>:63923
Run the go2rtc executable in that directory
Head your browser to http://localhost:1984/webrtc.html?src=mystream
Then run the following python script to fill the stream with data:
from websocket import EufySecurityWebSocket
import aiohttp
import asyncio
import json
import socket

msg = "Hello World"
print(msg)

sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)

sock.bind(("localhost", 63923))
sock.listen()
client_socket, client_address = sock.accept()
client_socket.setblocking(False)

EVENT_CONFIGURATION: dict = {
    "livestream video data": {
        "name": "video_data",
        "value": "buffer",
        "type": "event",
    },
}
class Connector:
    async def on_open(self):
        print(f" on_open - executed")

    async def on_close(self):
        print(f" on_close - executed")

    async def on_error(self, message):
        print(f" on_error - executed - {message}")

    async def on_message(self, message):
        #print(f"- on_message {message}")
        payload = message.json()
        message_type: str = payload["type"]
        if message_type == "event":
            message = payload[message_type]
            event_type = message["event"]
            if message["event"] == "livestream video data":
                print(f"- on_message {message}")
                event_value = message[EVENT_CONFIGURATION[event_type]["value"]]
                event_data_type = EVENT_CONFIGURATION[event_type]["type"]
                if event_data_type == "event":
                    client_socket.sendall(
                        bytearray(event_value["data"])
                    )

SET_P2P_LIVESTREAM_MESSAGE = {
    "messageId": "start_livesteam",
    "command": "device.start_livestream",
    "serialNumber": "T8200N0020280C6C",
}

SET_API_SCHEMA = {
    "messageId": "set_api_schema",
    "command": "set_api_schema",
    "schemaVersion": 11,
}
START_LISTENING_MESSAGE = {"messageId": "start_listening", "command": "start_listening"}

DRIVER_CONNECT_MESSAGE = {"messageId": "driver_connect", "command": "driver.connect"}
async def main():
    c = Connector()

    ws: EufySecurityWebSocket = EufySecurityWebSocket(
        "<IP_ADDRESS>",
        3000,
        aiohttp.ClientSession(),
        c.on_open,
        c.on_message,
        c.on_close,
        c.on_error,
    )

    await ws.connect()
    await ws.send_message(json.dumps(START_LISTENING_MESSAGE))
    await ws.send_message(json.dumps(SET_API_SCHEMA))
    await ws.send_message(json.dumps(DRIVER_CONNECT_MESSAGE))
    await ws.send_message(json.dumps(SET_P2P_LIVESTREAM_MESSAGE))
    await asyncio.sleep(105)

asyncio.run(main())

Works like charm.
We could run all the python script together with go2rtc standalone as an individual addon. The ffmpeg process is created on the fly when the user accesses the stream url.
The custom integration only would need to use the correct rtsp uri for the camera.

Your stream is not corrupted because webrtc had having issues to render it correctly. i can replace go2rtc as a new dependency but it should also replace rtsp server.

Yeah. I was not succesful with that. for some reason eufy_security component cannot use the rtsp server provided by go2rtc

As you point out, ffmpeg is created by an add on, but at the end, you cannot generate a stream without ffmpeg.
thanks for sharing example code pointer, but we should be sure that new proposal should not put more borden on end user and be inclusive for all users. (Some users out there are not having issues with webrtc as codec is perfectly suitable.)
So, let's find a way to keep the complexity identical (or hopefully less :-) ) and continue on this

Since this is not something we might want to do I created a little HA addon on my own to play with it a bit more:
https://github.com/oischinger/eufyp2pstream
I'll close this issue since the original problem is not really related to the custom component.

Let me keep this open, i will check new add on and engage with owner if it supports api to setup the cameras on the fly.

@oischinger , have you checked core integration and add-on of rtsp to webrtc?

integration: https://www.home-assistant.io/integrations/rtsp_to_webrtc/
add-on: https://github.com/allenporter/stream-addons

because of my mistake, current integration cannot use this add-on and integration even if user had installed these.
but you can give this a try manually and update back here if this is solving codec issues and I can quickly release a fix to use rtsp to web add-on and integration.
Under the hood, it is generating webrtc automatically if streaming url is RTSP and intercepting inside home assistant, no need for manual YAML configuration.

and thanks for reminding me missing sound :)

Let me keep this open, i will check new add on and engage with owner if it supports api to setup the cameras on the fly.

Any news on this? Could you get in touch with the owner?

Same issue for me but it's not random: the image is never rendered correctly, @oischinger I will check what you have done, go2rtc seems really nice!

For the people that still have this issue and can't get it resolved with all the add-ons that are out there. Just remove all add-ons and uncheck: "Use RTSP-extension (P2P)". After that it works flawless with WebRTC lovelace integration. It is quite fast, the only limitation is that you can't keep the livestream open for to long. Also it is near realtime, I think it's only 1 sec behind.

For the people that still have this issue and can't get it resolved with all the (other) add-ons that are out there. Just uncheck: "Use RTSP-extension (P2P)". After that it works flawless with WebRTC lovelace integration. It is quite fast, the only limitation is that you can't keep the livestream open for too long. Also it is near realtime, I think it's only 1 sec behind, with P2P streaming it is a good 6-8 seconds behind.
I think this is a good in-between solution, let's hope that P2P will improve in the meantime.

Still have issues from time to time, same problems exist. Hopefully someone has the permanent solution.

https://github.com/fuatakgun/eufy_security/issues/592


Add unit tests

They test these things separately:

shellsheck execution (must have no errors!)
borgcron_start.sh (with a fake borg binary)
borgcron.sh (with a fake borg binary)
borgcron.sh with real borg

TODO:

[x] fix erros in "borgcron.sh with real borg"
[x] checklastbackup.sh

Notable changes: Some minor errors detected and fixed; $PRUNE_PREFIX introduced (see config)


[bugfix] defer matplotlib import error until used

Right now, invoking sparsezoo.analyze --help without dev dev dependencies fails as matplotlib won't be installed and it's needed to plot graphs, this PR defers the import error until matplotlib is actually used

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1204623202382276
https://app.asana.com/0/0/1204623198603898

It would be nice to update the message to properly quote the module installed because the use of angle brackets in the command (e.g. >) without being quoted will not work. This will be greatly helpful to anyone that copies the install command from the error message to then perform the install.
For example:
# This does not use the constraint correctly; at best it installs with no version constraint and pipes all stdout to a file named `=3.0.0`
pip install matplotlib>=3.0.0
# This is the correct command for any standard shell
pip install "matplotlib>=3.0.0"


Units of export given in title

The unit of each export could be given in its respective doc strings. To take this further, the unit could be written in the title of each derived quantity and should be automatically generated depending on the dimension of the mesh

This may be a breaking change since some users already look for the columns in the CSV without the units so we would have to be careful


fix: Double input of text including composing, such as Japanese, at TextNode Boundaries with in a MarkNode #5761

fixed #5761
After
https://github.com/facebook/lexical/assets/111737064/4d6f94da-a90a-4810-b79f-7e463e8101cb
Bug
This happens inside an ElementNode, like MarkNode or LinkNode, where canInsertTextAfter or canInsertTextBefore is set to false. If a part of the internal TextNode is formatted to split it, and text that includes composing is inputted at the boundary, the composition is released, and the text is inputted twice.
Cause of the bug
The bug arise when the CONTROLLED_TEXT_INSERTION_COMMAND is unnecessarily triggered, even when isComposition is true at the node boundary.
Despite the fact that text insertion into the Node is already being behind elsewhere during composing, the selection.insertText function called by the command cause a repeated input.
This leads to the text being doubly entered.
Solution
To resolve this, I modified the behavior so that CONTROLLED_TEXT_INSERTION_COMMAND does not get triggered while composing at the boundary.
$shouldInsertTextAfterOrBeforeTextNode function now returns false during composing because it was previously causing the command to dispatch at boundary inputs.
Since text input during composing is a provisional state, the default behavior is sufficient.
The strategy now ensure that the behavior at the boundary is confirmed only after composing has concluded.

Could we add a test for this please, there are quite a few tests for IME and hashtags, which you can use to build one for this use case.

@ivailop7
Ok!
I want to know where I write to write test code for IME.
If we were to name a test for this case, it would be 'Testing IME input on the boundary between two TextNodes contained within an ElementNode where canInsertTextAfter or canInsertBefore is false'.
Thus, it might be appropriate to write this as a test for MarkNode and LinkNode that meet the above conditions, or as a test for core parts like LexicalSelection.

@ivailop7
Ok!
I want to know where I write to write test code for IME.
If we were to name a test for this case, it would be 'Testing IME input on the boundary between two TextNodes contained within an ElementNode where canInsertTextAfter or canInsertBefore is false'.
Thus, it might be appropriate to write this as a test for MarkNode and LinkNode that meet the above conditions, or as a test for core parts like LexicalSelection.

Sure, a test under the ime Composition file should be better

Is this a test file you mention?
https://github.com/facebook/lexical/blob/111117d0013917d0481cf418430db75a8afbb497/packages/lexical-playground/__tests__/e2e/Composition.spec.mjs#L184

@ivailop7
Is this a test file you mention?
https://github.com/facebook/lexical/blob/111117d0013917d0481cf418430db75a8afbb497/packages/lexical-playground/__tests__/e2e/Composition.spec.mjs#L184

Yes


Implemented Store.SetLimits

Implemented Store.SetLimits using the new wasmtime_store_limiter function.

Thanks for creating this PR! I also thought about implementing this, but didn't find time to do so.

Opinions?

I would favor option 2 (use nullable values), at least for the parameters that can specify an unlimited value according to the documentation (memory_size and table_elements). This would match e.g. the Memory.Maximum API which is also a nullable long?, where null means the memory doesn't have a maximum.
Regarding accepting both negative values and null, we could throw an ArgumentOutOfRangeException if a negative value is specified, so that null is the only way to specify that the default value should be used.
What do you think?
Thanks!

Thanks for implementing this!


add countdownlatch to df worker test

Add a countdown latch to test case failing if parallel build is enabled. see https://issues.apache.org/jira/browse/BEAM-5908

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

@kennknowles FYI, This is, what I came up with. We might experiment with enabling parallel builds here.
Dunno, if we really wanna merge this.

Hmm, I would have expected the waiting to happen before the call to verify.

Ah, yes, now I see. Your fix is just right.

LGTM. I will allow the precommit to pass, then merge this. I think then we can re-enable parallel builds.


Multiple Players Of Same Name Are ALLOWED

Multiple clients using a character with the same name are allowed to join at the same time. I only tested by launching two clients on the same machine.
This works with two of the same exact character and it also works with two characters of the same name.
Also, sort of unrelated, give command gives priority to the first character who joins. Just another reason this shouldn't be allowed.
One other note. We should check more than just the name because if another character just happens to have used the same name as someone who has already registered on the server, he will not be able to join since he will not have the password. If we check other things to uniquely identify the other character, we can allow registrations from same name characters or at least identify that it's a different character and send them a message about the name instead of prompt for password.

It appears to be an issue with the API - the custom user password was not checking. Onward from ebd0445b92ebde6974b1b40f90f3f4282c6b4a81 should contain a fix. Are you able to test with and without restrict when you have time.

tested with and without restrict. resolved.