Immutable distro does not allow root commands after manual build

Ouput of linux-enable-ir-emitter -v configure

CRITICAL: Please run as root.

Output of cat /etc/linux-enable-ir-emitter/*
cat: '/etc/linux-enable-ir-emitter/*': No such file or directory

Output of ls -l /dev/v4l/by-path
total 0
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usb-0:4:1.0-video-index0 -> ../../video0
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usb-0:4:1.0-video-index1 -> ../../video1
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usb-0:4:1.2-video-index0 -> ../../video2
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usb-0:4:1.2-video-index1 -> ../../video3
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usbv2-0:4:1.0-video-index0 -> ../../video0
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usbv2-0:4:1.0-video-index1 -> ../../video1
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usbv2-0:4:1.2-video-index0 -> ../../video2
lrwxrwxrwx. 1 root root 12 Apr  7 11:37 pci-0000:05:00.4-usbv2-0:4:1.2-video-index1 -> ../../video3

Give more information if you have
I built the package manually using meson by following the instructions on docs/manual-build.md, including changing the installation directory to $HOME/.local because I'm on an immutable system. If I run linux-enable-ir emitter configure, the output is CRITICAL: Please run as root.. However, if I then run the same command using sudo, I get sudo: linux-enable-ir-emitter: command not found.
Additional info

Computer (or camera) model: Lenovo Yoga Slim 7 Pro 16ACH6
Linux distribution: Fedora Silverblue 39
Version of linux-enable-ir-emitter: linux-enable-ir-emitter 6.0.0-pre

Ok, I see where is the bug. In the meantime I publish a fix, please execute sudo /home/<your home>/.local/bin/linux-enable-ir emitter configure

Many many thanks! your tool has fixed the issues I was having with Howdy, and you've been incredibly friendly and helpful :)

You're welcome! If you like the project, do not hesitate to star the repository to support me, thank you!

I think I'll officially provide a tarball for immutable distros, to avoid manual build.
Because, is your build static ? Or did you layered the yaml and opencv libs package?

I installed all the dependencies using rpm-ostree, including yaml and opencv.

I'll send a comment here when the installation archive for immutable distro is ready, it'll be easier for the tool not to break when you update the distro, and it'll also reduce your number of layered packages

Thanks!

I've just noticed a new bug- the emitter is now not working again after having restarted my system, so I will have to reconfigure it. Will this be solved when the new tarball is ready?

Don't need to re-configure, execute linux-enable-ir-emitter run.
I think there is a problem with the systemd script.
Can past the output of sudo systemctl status linux-enable-ir-emitter?
Could you also paste here where are installed the different files, thus what is output by the ninja install -C build step

sudo systemctl status linux-enable-ir-emitter gives:
× linux-enable-ir-emitter.service - enable the infrared emitter
     Loaded: loaded (/etc/systemd/system/linux-enable-ir-emitter.service; enabl>
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: failed (Result: exit-code) since Mon 2024-04-08 12:37:19 BST; 58mi>
    Process: 5688 ExecStartPre=modprobe uvcvideo (code=exited, status=0/SUCCESS)
    Process: 5689 ExecStart=linux-enable-ir-emitter -v run (code=exited, status>
   Main PID: 5689 (code=exited, status=203/EXEC)
        CPU: 13ms

Apr 08 12:37:19 Portaweasel systemd[1]: Starting linux-enable-ir-emitter.servic>
Apr 08 12:37:19 Portaweasel (-emitter)[5689]: linux-enable-ir-emitter.service: >
Apr 08 12:37:19 Portaweasel (-emitter)[5689]: linux-enable-ir-emitter.service: >
Apr 08 12:37:19 Portaweasel systemd[1]: linux-enable-ir-emitter.service: Main p>
Apr 08 12:37:19 Portaweasel systemd[1]: linux-enable-ir-emitter.service: Failed>
Apr 08 12:37:19 Portaweasel systemd[1]: Failed to start linux-enable-ir-emitter>
lines 1-16/16 (END)

Output of ninja install -C build:
ninja: Entering directory `build'
[0/1] Installing files.
Installing libcommands.so to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter
Installing new directory /etc/udev/rules.d
'/etc/udev/rules.d': Unable to set permissions 493: Operation not permitted, ignoring...
Installing new directory /etc/linux-enable-ir-emitter
'/etc/linux-enable-ir-emitter': Unable to set permissions 493: Operation not permitted, ignoring...
Installing /var/home/woofweasel/linux-enable-ir-emitter/build/linux-enable-ir-emitter to /var/home/woofweasel/.local/bin
Installation failed due to insufficient permissions.
Attempt to use /usr/bin/sudo to gain elevated privileges? [y/n] y
Attempting facial authentication
[sudo] password for woofweasel:
Identified face as woofweasel
Installing libcommands.so to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter
Installing new directory /etc/udev/rules.d
Installing new directory /etc/linux-enable-ir-emitter
Installing /var/home/woofweasel/linux-enable-ir-emitter/build/linux-enable-ir-emitter to /var/home/woofweasel/.local/bin
Installing /var/home/woofweasel/linux-enable-ir-emitter/build/globals.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/utils
Installing /var/home/woofweasel/linux-enable-ir-emitter/utils/__init__.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/utils
Installing /var/home/woofweasel/linux-enable-ir-emitter/command/__init__.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/command
Installing /var/home/woofweasel/linux-enable-ir-emitter/command/boot.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/command
Installing /var/home/woofweasel/linux-enable-ir-emitter/command/load_cpp_commands.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/command
Installing /var/home/woofweasel/linux-enable-ir-emitter/boot_service/__init__.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/boot_service
Installing /var/home/woofweasel/linux-enable-ir-emitter/boot_service/base_boot_service.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/boot_service
Installing /var/home/woofweasel/linux-enable-ir-emitter/LICENSE to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter
Installing /var/home/woofweasel/linux-enable-ir-emitter/boot_service/systemd/__init__.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/boot_service/systemd
Installing /var/home/woofweasel/linux-enable-ir-emitter/boot_service/systemd/systemd.py to /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/boot_service/systemd
Installing /var/home/woofweasel/linux-enable-ir-emitter/boot_service/systemd/linux-enable-ir-emitter.service to /etc/systemd/system
Installing /var/home/woofweasel/linux-enable-ir-emitter/autocomplete/linux-enable-ir-emitter.bash to /var/home/woofweasel/.local/share/bash-completion/completions
Installing /var/home/woofweasel/linux-enable-ir-emitter/autocomplete/linux-enable-ir-emitter.zsh to /var/home/woofweasel/.local/share/zsh/site-functions

Could you modify the /etc/systemd/system/linux-enable-ir-emitter.service file and change the line:
ExecStart=linux-enable-ir-emitter -v run with:
ExecStart=/var/home/woofweasel/.local/bin/linux-enable-ir-emitter -v run

After making that change, it seems that functionally nothing has changed. If I restart my device, the program will work absolutely fine. If I shut down and then start it up, linux-enable-ir-emitter will not be enabled until I run linux-enable-ir-emitter run.
sudo systemctl status linux-enable-ir-emitter now gives:
× linux-enable-ir-emitter.service - enable the infrared emitter
     Loaded: loaded (/etc/systemd/system/linux-enable-ir-emitter.service; enabled; preset: disabled)
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: failed (Result: exit-code) since Thu 2024-04-11 15:46:59 BST; 7min ago
    Process: 1038 ExecStartPre=modprobe uvcvideo (code=exited, status=0/SUCCESS)
    Process: 1053 ExecStart=/var/home/woofweasel/.local/bin/linux-enable-ir-emitter -v run (code=exited, status=1/FAILURE)
   Main PID: 1053 (code=exited, status=1/FAILURE)
        CPU: 74ms

Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]:   File "/var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/command/load_cpp_commands.py", line 5, in <module>
Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]:     cpp_commands = ctypes.CDLL(CPP_COMMANDS_LIB_PATH)
Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]:                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]:   File "/usr/lib64/python3.12/ctypes/__init__.py", line 379, in __init__
Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]:     self._handle = _dlopen(self._name, mode)
Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]:                    ^^^^^^^^^^^^^^^^^^^^^^^^^
Apr 11 15:46:59 fedora linux-enable-ir-emitter[1053]: OSError: /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/libcommands.so: failed to map segment from shared object
Apr 11 15:46:59 fedora systemd[1]: linux-enable-ir-emitter.service: Main process exited, code=exited, status=1/FAILURE
Apr 11 15:46:59 fedora systemd[1]: linux-enable-ir-emitter.service: Failed with result 'exit-code'.
Apr 11 15:46:59 fedora systemd[1]: Failed to start linux-enable-ir-emitter.service - enable the infrared emitter.
lines 1-20

What shows: ls -l /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/libcommands.so?

ls -l /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/libcommands.so gives:
-rwxr-xr-x. 1 root root 437776 Apr  7 00:29 /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/libcommands.so

Could you execute chmod 777 /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/libcommands.so and see if the issue persists?

This appears to have fixed it, thanks! I'll do some further testing just to make absolutely sure, and if so I'll close the issue.

Hum, as you can see /var/home/woofweasel/.local/lib64/linux-enable-ir-emitter/libcommands.so is owned by root, and this is the problem I think. This is caused by the meson/ninja installer I guess. With the specific tarball for immutable distro I'm creating that problem shouldn't happen I think

That makes sense, thanks mate! You've been really helpful :)

Hey, unfortunately it appears that the issue has persisted- not sure why it worked yesterday. I'm very happy to wait for the new tarball and simply run the program when necessary until then, would you recommend that?

Same output for the systemd service ?

What command should I run to find this out? Apologies, I'm relatively new to Linux.

No problem! sudo systemctl status linux-enable-ir-emitter

that outputs:
× linux-enable-ir-emitter.service - enable the infrared emitter
     Loaded: loaded (/etc/systemd/system/linux-enable-ir-emitter.service; enabl>
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: failed (Result: exit-code) since Fri 2024-04-12 13:45:17 BST; 19mi>
    Process: 1046 ExecStartPre=modprobe uvcvideo (code=exited, status=0/SUCCESS)
    Process: 1067 ExecStart=/var/home/woofweasel/.local/bin/linux-enable-ir-emi>
   Main PID: 1067 (code=exited, status=1/FAILURE)
        CPU: 54ms

Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]:   File "/var/home/woofwea>
Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]:     cpp_commands = ctypes>
Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]:                    ^^^^^^>
Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]:   File "/usr/lib64/python>
Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]:     self._handle = _dlope>
Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]:                    ^^^^^^>
Apr 12 13:45:17 fedora linux-enable-ir-emitter[1067]: OSError: /var/home/woofwe>
Apr 12 13:45:17 fedora systemd[1]: linux-enable-ir-emitter.service: Main proces>
Apr 12 13:45:17 fedora systemd[1]: linux-enable-ir-emitter.service: Failed with>
Apr 12 13:45:17 fedora systemd[1]: Failed to start linux-enable-ir-emitter.serv>
lines 1-20/20 (END)

Hey, in the PR #174, you can find a bot comment that contains instructions and a link to download and install my latest changes.
Please uninstall first your current version:
sudo rm -rf $HOME/.local/lib/linux-enable-ir-emitter \
$HOME/.local/bin/linux-enable-ir-emitter \
$HOME/.local/share/bash-completition/completitions/linux-enable-ir-emitter \
$HOME/.local/share/zsh/site-functions/_linux-enable-ir-emitter \
/etc/systemd/system/linux-enable-ir-emitter.service \
/etc/udev/rules.d/99-linux-enable-ir-emitter.rules

If you don't delete the /etc/linux-enable-ir-emitter, you do not need to reconfigure

That command worked after having changed

$HOME/.local/lib/linux-enable-ir-emitter

to $HOME/.local/lib64/linux-enable-ir-emitter
However, while I have checked that all those files are deleted, I can still run linux-enable-ir-emitter run in order to fix my ir emitter upon a full restart of my device, making me wonder if there's something else that needs to be uninstalled before your new version can be installed?
Also, unfortunately I am very unfamiliar with tarballs, and so I am struggling with the installation of this one. Upon downloading it, I execute unzip linux-enable-ir-emitter*.tar.gz.zip only to be met with:
unzip:  cannot find or open linux-enable-ir-emitter*.tar.gz.zip, linux-enable-ir-emitter*.tar.gz.zip.zip or linux-enable-ir-emitter*.tar.gz.zip.ZIP.

No zipfiles found.

However, while I have checked that all those files are deleted, I can still run linux-enable-ir-emitter run in order to fix my ir emitter upon a full restart of my device, making me wonder if there's something else that needs to be uninstalled before your new version can be installed?

Execute which linux-enable-ir-emitter to see where the executable is located.

Also, unfortunately I am very unfamiliar with tarballs, and so I am struggling with the installation of this one. Upon downloading it, I execute unzip linux-enable-ir-emitter*.tar.gz.zip only to be met with:

Are you in the directory where the archive has been downloaded? e.g. cd $HOME/Downloads

Execute which linux-enable-ir-emitter to see where the executable is located.

This worked and I used sudo rm -rf to uninstall the executable. Strangely, after this step, all my issues with howdy have been fixed and my ir emitter works even after a system shut down. Thank you so much for all the work you've put into solving this for me :)
However, just to see if linux-enable-ir-emitter itself worked on my system, I tried installing the tarball (this time from the downloads directory)- the unzip works, but sudo tar -C / --no-same-owner -h -vxzf linux-enable-ir-emitter*.tar.gz then outputs:
./
./usr/
./usr/local/
./usr/local/bin/
./usr/local/bin/linux-enable-ir-emitter
./usr/local/share/
./usr/local/share/zsh/
./usr/local/share/zsh/site-functions/
./usr/local/share/zsh/site-functions/_linux-enable-ir-emitter
./usr/local/share/licences/
./usr/local/share/licences/linux-enable-ir-emitter/
./usr/local/share/licences/linux-enable-ir-emitter/LICENSE
./usr/local/share/bash-completion/
./usr/local/share/bash-completion/completions/
./usr/local/share/bash-completion/completions/linux-enable-ir-emitter
./etc/
tar: ./usr: Cannot utime: Read-only file system
./etc/systemd/
./etc/systemd/system/
./etc/systemd/system/linux-enable-ir-emitter.service
./etc/linux-enable-ir-emitter/
tar: .: Cannot utime: Operation not permitted
tar: Exiting with failure status due to previous errors

Please try this command: sudo tar -C / --no-same-owner --no-overwrite-dir -h -vxzf linux-enable-ir-emitter*.tar.gz
Many thanks to you also for your contribution to this project!

Strangely, after this step, all my issues with howdy have been fixed and my ir emitter works even after a system shut down. Thank you so much for all the work you've put into solving this for me :)

Hum, not sure if this will persist

Hum, not sure if this will persist

You were spot on, it's broken again.
sudo tar -C / --no-same-owner --no-overwrite-dir -h -vxzf linux-enable-ir-emitter*.tar.gz just output:
./
./usr/
./usr/local/
./usr/local/bin/
./usr/local/bin/linux-enable-ir-emitter
./usr/local/share/
./usr/local/share/zsh/
./usr/local/share/zsh/site-functions/
./usr/local/share/zsh/site-functions/_linux-enable-ir-emitter
./usr/local/share/licences/
./usr/local/share/licences/linux-enable-ir-emitter/
./usr/local/share/licences/linux-enable-ir-emitter/LICENSE
./usr/local/share/bash-completion/
./usr/local/share/bash-completion/completions/
./usr/local/share/bash-completion/completions/linux-enable-ir-emitter
./etc/
tar: ./usr: Cannot utime: Read-only file system
./etc/systemd/
./etc/systemd/system/
./etc/systemd/system/linux-enable-ir-emitter.service
./etc/linux-enable-ir-emitter/
tar: .: Cannot utime: Operation not permitted
tar: Exiting with failure status due to previous errors

And this one:
sudo tar -C / --no-same-owner --atime-preserve=system -h -vxzf linux-enable-ir-emitter*.tar.gz

Same output

Hum, ok let's try these two:

sudo tar -C / --no-same-owner -m -h -vxzf linux-enable-ir-emitter*.tar.gz
sudo tar -C / --no-same-owner --no-overwrite-dir -m -h -vxzf linux-enable-ir-emitter*.tar.gz
Thanks a lot for your time and very prompt response by the way

That first command seemed to work! The output did not contain the errors:
./
./usr/
./usr/local/
./usr/local/bin/
./usr/local/bin/linux-enable-ir-emitter
./usr/local/share/
./usr/local/share/zsh/
./usr/local/share/zsh/site-functions/
./usr/local/share/zsh/site-functions/_linux-enable-ir-emitter
./usr/local/share/licences/
./usr/local/share/licences/linux-enable-ir-emitter/
./usr/local/share/licences/linux-enable-ir-emitter/LICENSE
./usr/local/share/bash-completion/
./usr/local/share/bash-completion/completions/
./usr/local/share/bash-completion/completions/linux-enable-ir-emitter
./etc/
./etc/systemd/
./etc/systemd/system/
./etc/systemd/system/linux-enable-ir-emitter.service
./etc/linux-enable-ir-emitter/

I can now run linux-enable-ir-emitter run just fine and it works, I will test to see if it works even after a shut down now.

And does something is extracted? Is /usr/local/bin/linux-enable-ir-emitter exists?

Yep, it exists (after running the above command, not sure if it did before).

Also execute sudo systemctl enable --now linux-enable-ir-emitter
And if the issue persists, show me the output of systemctl status linux-enable-ir-emitter

Also execute sudo systemctl enable --now linux-enable-ir-emitter

This appears not to have changed anything.

And if the issue persists, show me the output of systemctl status linux-enable-ir-emitter

○ linux-enable-ir-emitter.service - enable the infrared emitter
     Loaded: loaded (/etc/systemd/system/linux-enable-ir-emitter.service; enabled; preset: disabled)
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: inactive (dead) since Wed 2024-04-17 22:26:28 BST; 5min ago
    Process: 1037 ExecStartPre=modprobe uvcvideo (code=exited, status=0/SUCCESS)
    Process: 1057 ExecStartPre=sleep 2 (code=exited, status=0/SUCCESS)
    Process: 1255 ExecStart=linux-enable-ir-emitter -v run (code=exited, status=0/SUCCESS)
   Main PID: 1255 (code=exited, status=0/SUCCESS)
        CPU: 61ms

Apr 17 22:26:26 fedora systemd[1]: Starting linux-enable-ir-emitter.service - enable the infrared emitter...
Apr 17 22:26:28 fedora linux-enable-ir-emitter[1255]: 6.0.0-beta
Apr 17 22:26:28 fedora systemd[1]: linux-enable-ir-emitter.service: Deactivated successfully.
Apr 17 22:26:28 fedora systemd[1]: Finished linux-enable-ir-emitter.service - enable the infrared emitter.

Main PID: 1255 (code=exited, status=0/SUCCESS)

No no, not the same. Now the systemd service does not exit with error, and the output in the bottom is not the same.
However, I forgot that I changed the shortname for the verbosity. It is not anymore -v. Could you do:

Open with root privilege /etc/systemd/system/linux-enable-ir-emitter.service, so e.g. sudo nano /etc/systemd/system/linux-enable-ir-emitter.service`
Modify the -v with --verbose, thus the line becomes: linux-enable-ir-emitter --verbose run
Save (with nano: ctrl+o, enter, ctrl+x)
sudo systemctl enable --now linux-enable-ir-emitter

After that everything should be good!


Make error handling more consistent part 5

Covers server commands, usage commands, and version command, including updating the REST API method that version uses to be the non-deprecated /v1/server/version.

Merging.


On selecting on of the suggested items the background model also get selected this issue only in android device

**search.html **
  <ng-template #withCode let-attrs="attrs">         -        </ng-template>        <ion-auto-complete  id="search" [dataProvider]="statinAutoComp"                            formControlName = "fromStation"                            [options]="{ placeholder : 'From Station',debounce:400 }"                           [template]="withCode"                           [hideListOnSelection]='true'>                   </ion-auto-complete>
search.module.ts
@NgModule({   declarations: [     TrainSearchPage,   ],   imports: [     AutoCompleteModule,     IonicPageModule.forChild(TrainSearchPage),   ] })
search.ts
Constructor
`  constructor(public navCtrl: NavController,
public loadingCtrl:LoadingController,
public alertCtrl:AlertController,
public datepipe:DatePipe,
public modalCtrl:ModalController,
public completeTestService:CompleteTestService,
public saveService:SaveSearchesService,
public statinAutoComp:StationAutoComplete
) {
}`
please help me

Hey kadoshms please help me to resolve this issue.

Hello!
I change the "tap" event to "click" on template directive and remove second param "stopPropagation";
before:
(tap)="select(suggestion);$event.srcEvent.stopPropagation()"
after:
(click)="select(suggestion);"
works fine in Android and IOS

Hello,
I made following changes in module  that is in "ionic2-auto-complete/index.js" for this issue
(click)="select(suggestion);$event.stopPropagation();">\n
It worked fine with regular build.Though when I use prod build for my app this issue pops up again.
Can anybody help me to resolve this?

Hi,
This change in the module that is in "ionic2-auto-complete/index.js" is causing the issue in creating CI-CD build pipeline where every time new modules get installed while building the app and this is how the change in index.js made locally can not work for me. can anyone help in this?


test/cask/audit_spec: add test for slashes in versions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

We should be testing this, for security reasons.

Review period skipped due to critical label.


[Bug-9235][Alert]Fix wechat markdown message and change wechat form structure

Purpose of the pull request
Fix wechat markdown message and change wechat form structure
related issue: https://github.com/apache/dolphinscheduler/issues/9235
related pr: https://github.com/apache/dolphinscheduler/pull/9225
Brief change log
Verify this pull request
Manually verified the change by testing locally.

Codecov Report

Merging #9367 (aa7a2fa) into dev (ee0e3be) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

:exclamation: Current head aa7a2fa differs from pull request most recent head f2395d6. Consider uploading reports for the commit f2395d6 to get more accurate results

@@             Coverage Diff              @@
##                dev    #9367      +/-   ##
============================================
- Coverage     39.98%   39.92%   -0.07%
+ Complexity     4375     4371       -4
============================================
  Files           822      822
  Lines         32921    32927       +6
  Branches       3656     3656
============================================
- Hits          13164    13145      -19
- Misses        18527    18555      +28
+ Partials       1230     1227       -3

Impacted Files
Coverage Δ

...lugin/alert/wechat/WeChatAlertParamsConstants.java
0.00% <ø> (ø)

...uler/plugin/alert/wechat/WechatAppChatMessage.java
0.00% <0.00%> (ø)

...cheduler/plugin/alert/wechat/WechatAppMessage.java
0.00% <0.00%> (ø)

...eduler/api/service/impl/DataSourceServiceImpl.java
30.46% <0.00%> (-0.34%)
:arrow_down:

...er/api/service/impl/TaskDefinitionServiceImpl.java
24.01% <ø> (+0.05%)
:arrow_up:

...hinscheduler/plugin/alert/wechat/WeChatSender.java
26.41% <50.00%> (-11.17%)
:arrow_down:

...plugin/alert/wechat/WeChatAlertChannelFactory.java
97.50% <100.00%> (ø)

...e/dolphinscheduler/remote/NettyRemotingClient.java
53.52% <0.00%> (+0.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0e3be...f2395d6. Read the comment docs.


Inverted 3D models after using

Hello,
I work in a public lab in wich we create accurate 3D capture of historical and cultural heritage related sites.
I've been playing for a while with the VTS backend and encountered an issue :
Our datasets are in the slpk format. When I load it in my local vts environement I end up with a "mirrored" version of my data :
normals seems to be inverted, the model itself is inverted on the Y axis and the latitude and longitude of the default camera inverted in the url (//localhost:3060/dpn/tilesets/test_v17.slpk/?pos=obj,47.895247,-3.407835,fix,-33.02,0.00,-90.00,0.00,74.85,45.00).

We tried to load this same dataset in the melown cloud plateform and their is no sign of these isues (//www.melown.com/cloud/link/ZLlnO3RgGLV4k89n835j?pos=obj,-3.407941,47.895019,fix,86.35,-57.63,-56.62,0.00,72.50,45.00).

We import the data using :

slpk2vts --input <dataset> --output /var/vts/store/resources/tilesets/<dataset> --referenceFrame melown2015 --tilesetId <dataset>
and then vts dpn --add --tileset /var/vts/store/resources/tilesets/<dataset>/ --top

Do you have any idea why we have this behaviour ? Maybe we are missing something. Do you pre-process the files before importing in your cloud service ?

Hi, it looks like a problem with normals. The input dataset is not preprocessed but the software running in the cloud is way older than the current git HEAD.
Would it be possible to provide me with your SLPK dataset so I can debug the problem?

Thanks for your quick response.
Of course ! Can I send a it to you via email ? I'd rather not to provide dl links on public chanel (You can find mine in my profile, you don't seem to have a public mail on yours).

Here is a link download the data :
https://drive.dpn-lab.com/s/kYnQZgMWsBALDnr

Sorry for not replying, I've got distracted by other stuff. Downloaded and your message with the link deleted.
Will investigate.

No problem. Thank you.

I was unable to replicate your problem. However, there was a problem in the 1.89 version of vts-tools in our package repository that was fixed few weeks ago. What OS (vendor, version) and what version of vts-tools do you use?
There's a package 1.93 available for Ubuntu 18.04 (bionic) in our package repo. Otherwise current HEAD of master works OK.

I've noticed that due to "uneven bottom" of your dataset (i.e. not all data are represented at the deepest level 13) the slpk2vts tool computes VTS LOD assignment at level 6 where the dataset resolution does not quite reflect the dataset quality -- the resolution is computed too low and this places the bottom of your dataset (13) at LOD 30 with insanely tiny tile (like 34x34 mm).
The workaround to move the dataset to lower LOD in the VTS tile tree is to use --tweak.optimalTextureSize 1024x1024 on the command line; normally, the optimal texture size is 256x256 so this uses 4x larger texture that leads to move the data 2 LODs up which seems like what the data at the bottom level in your dataset match. This also leads to ~86k tiles -- instead of original ~1.38M tiles.
However, I've hit a bug in the code, the is fix in the master branch. No package built yet.

Thank you for your feed back. I use a custom docker image based on ubuntu 20.04, building directly vts-tools, vtsd, mapproxy and registry from the master branch. I'll try updating my image to incorporate your bug fix. I'll also update my loading process using the workaroud you proposed. I'll keep in touch with you once I've done that.
Thanks again.

Hi,
I have updated docker image using the latests masters and used the workaround you proposed. Unfortunatly it does not seems to correct my isue :
the 3d model and the relation between latitude and longitude are still inverted.

We also tried to load the data as LodTree and got the same result.
Where you able to load the data correctly on your environment ?

Yes, I converted it OK. However, now I noticed you are running it on focal. Lemme test it on focal as there may be some hidden problems with newer libraries.

That's what I thought too. I'll wait for your feedback then.
Thanks again.

Got the same result! Will investigate.

OK, got it. Fixed in master.
As expected, it was a change in dependency: GDAL 3 (present on focal) started honoring axis order in CSR by default. So, for latlon it interprets arguments as (Y, X, Z) by default. I had to tell it to use "traditional GIS order", i.e. (X,Y, Z) regardles of the CSR. This x/y axis swap 1) flipped triangle front faces and 2) moved the model in completely different place in the world.
Just currious how much code did this change break...

Thanks a lot !
We will use the new version and give you feedbacks on any isues. Let's hope nothing has broke ;).

I forgot to mention that the change is in submodule, you have to updated recursively.

Hi,
Thanks for the changes. So far it seems to be working. We managed to load and visualize a full dataset in the corrected version. The only issue we have left is that, after a time, the scene violently reload itself, leading to a full reload of the LODs. You can have an exemple of this in this video : https://drive.dpn-lab.com/s/DrE42wMk8MSk9cK.
Do you have any idea of the reason that can causes this ?

Hi, I have not encountered this but I guess it could be a problem with memory -- too much data loaded in the browser. Have you checked browser's console? (F12 in Chrome and Firefox).


Table: support export to CSV, PDF

Working for PDF and CSV, albeit sans Endo's for the ones that can't hang with Gentium Plus.
TODO:

text not numbers for "Size"

@rperlin-ela decent progress if you want to take a look: https://deploy-preview-117--languagemapping.netlify.app/
The TODOs I mentioned in #93 comments: likely tomorrow.

@rperlin-ela ok i think we're in pretty good shape here: https://deploy-preview-117--languagemapping.netlify.app/
If there's anything minor missing, or anything major broken, let me know. For more bells n whistles, please create a new issue.
This one takes first and second place for the October Surprise Challenging Rabbit Hole Award 🏆

Things to check:

[ ] CSV exports work
[ ] PDF exports work
[ ] On mobile
[ ] And desktop
[ ] Aside from "missing" Endos, all is well enough
[ ] In-PDF link to source spreadsheet works
[ ] Table layout and style are legible. No mid-word line breaks.

Everything totally checks out. Congrats on the Award, maybe there won't be even be a third-place finisher. Some people may have pop-up blockers and not realize it, but I'm not sure there's anything to do about that. Agreed about slipping in a little "Not all endonym scripts supported by PDF export" note, probably just on the PDF itself?

Sounds good. I’d like to wrap up this branch though so let’s do a new issue for smaller export improvements like that as I’m sure there will be other suggestions, e.g. I wouldn’t mind a “Showing X of Y total records” so that the export will more clearly indicate that it’s only a subset of the full set.

Oh and yes to the popup blockers. That’s going to be a browser-specific thing we can’t control. It’s not an issue to me since it only happens once and it’s obvious what caused it since it happens immediately after the click.

I created the issue here, feel free to add as needed
https://github.com/Language-Mapping/language-map/issues/118


setup an cluster in azure

Looking at the examples it looks like one can pass in a PrajnaClusterFile
I can not see a sample Prajna Cluster File.
Also, it is not clear how to setup a cluster in a cloud provider like Azure, any guidance would be appreciated.

Thanks Tony.  Yes, we are aware of the lack of information on how to setup a cluster.  We are in the process of providing the instructions/scripts for various scenarios. It will start with a cluster of windows domain joined machines, then we will also provide similar instructions/scripts for Azure.

Hello Weirong Zhu,
please, if you can , try to give us a simplified cluster setup like Spark standalone (described here)
http://spark.apache.org/docs/latest/spark-standalone.html
this way even solo/small developers can test Prajna in their free time at home on their own pc or group of pcs without having to use expensive server licenses or cloud subscription (with credit card => $$$), that's good for production but for just taking confidence with the suite something simple  I believe would really help this new product to spread rapidly.
One more question, I'm just curious, Spark is known to be built on top of Akka with Scala, Prajna was written in F# (quite similar to scala). Did you use also an actor model framework like Akka? If yes what did you use? Thanks. Antonio

Hi antogh,
Currently, the deployment instruction we have is similar to Spark's standalone mode.  Please check out  https://github.com/MSRCCS/Prajna/wiki/Use-Prajna (also specifically for deployment: https://github.com/MSRCCS/Prajna/wiki/Deploy-Prajna).  Please let us know if you hit any problems.
Regarding to questions on Prajna internals, please refer to http://msrccs.github.io/Prajna/paper/Prajna_v1.pdf for Prajna technical implementation details.
Thanks!


Add some array features

Congratulations @xamfoo, I think this package has an incredible potential! :)
I've been studying the Flux architecture lately and I really like the idea of having all the app state in a single global object. It looks like Facebook is starting to use baobab with ReactJS and Optimizely is already using something similar in NuclearJS.
I like baobab but most of the things it can do are already covered by your excellent package. I think the only thing I'm missing right now are some array features, like push, unshift or splice.
https://github.com/Yomguithereal/baobab#cursor-level
I'd love to know your thoughts about baobab as well.

@LuisHerranz you are very kind. Thank you for the suggestion :)
baobab seems interesting. Some observations:

Facets look similar to getters in NuclearJS. I'd like to see how this can work for reactive data sources.
I would prefer synchronous updating to asynchronous batch updating in baobab. One could set asynchronous option to false but seems like this would affect its performance.
History and updating commands are nice but doesn't seem necessary to me.
Cursors look useful, particularly in this case where we want to apply array methods to a path.

Array methods can look like:
var x = new ReactiveObj({y: []});
var y = x.select('y');
y.push('foo');
y.push('bar');
y.pop(); // 'bar';
x.get(); // {y: ['foo']}

This is certainly open for discussion

Yeah, cursors would be a great addition to simplify the use of deep ReactiveObjs.
Tracker is asynchronous, so updates in Meteor are async by default anyway.
History and undo capabilities would be great for some applications, but probably not needed everywhere. Those come for free when using immutable data, something maybe out of the scope here.
Array methods look great! Maybe you can use them without cursors as well:

var x = new ReactiveObj({ a: { b: [] } });
x.push(['a', 'b'], 'foo');
x.push(['a', 'b'], 'bar');
x.get(); // { a: { b: [ 'foo', 'bar' ] } }

Good point about using them without cursors. I'd probably add push, pop, reverse, shift, sort, splice and unshift.
Let me try to clarify my earlier comment about updating.
Note >> means synchronous, >>async>> means asynchronous.

When we want to read a new value in baobab:

Set value >>async>> Update value >> Trigger callbacks >> Read new value

while for ReactiveDict or ReactiveObj:

Set value >> Update value >> Read new value

I prefer the second case since we don't need to wait for a flush cycle or callbacks to read the value.
I'm interested in the way you are using the global app state. Do you store subscription handlers and Mongo cursors in it?

Yeah, I think in the end what you want to avoid is refreshing the UI more than needed. I agree this approach is better.
I'm still investigating on how to use it best. The idea is that instead of having app state stored in individual reactive variables inside each Flux Store, you use a global object like ReactiveObj.
On the other side (the templates) you have an API to retrieve those values. Something like this:
// instead of this:
Template.Something.helpers({
  something: function(){
    return SomeStore.getSomeState();
  }
});
// the template doesn't need to know about "SomeStore" and can go with:
Template.Something.helpers({
  something: function(){
    return AppState.getSomeState();
  }
});

The change is subtle, but it decouples Templates from Stores.
That "AppState" object can have an API which needs to be declared:
AppState.getSomeState = function() {
   return state.get([ 'state', 'some']);
}

Or can be something like ReactObj itself:
Template.Something.helpers({
  something: function(){
    return AppState.get([ 'state', 'some']);
  }
});

This can be used for session app state. You need collections for persistent app state of course.

Array methods implemented in v0.5.0 7831e7524895a3e2932e2017114728c5a9826158
Let me know if it is good for you :)

Lovely, thanks!
I'll give it a try.


CC1M data

nice work!
can you share the  CC1M  data , many thanks

The pre-training code and datasets will be released after our paper accepted, please stay tuned. And I will update the pre-training stage on O365 in the next few weeks.


Helen doesn't run as called in Makefile

Helen doesn't run according to trevor. @kishwarshafin can you take a look? (we need #1 fixed first...)

Is trevor available anywhere?
On Wed, Aug 21, 2019 at 7:38 AM Rob Currie<EMAIL_ADDRESS>wrote:

Helen doesn't run according to trevor. @kishwarshafin
https://github.com/kishwarshafin can you take a look? (we need #1
https://github.com/ucsc-upd/pipelines/issues/1 fixed first...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=ACQR4P2WJ3QBWWBGMCZQS33QFSMABA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGMMB2A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQR4P4BJ6T56XQK5AYJ6Y3QFSMABANCNFSM4IN7THBA
.

--
Kishwar

He's off grid. If its a nightmare to sort before he gets back we can try
and decouple I suppose. Primary goal a this point is to just get something
that 'runs' all the way through tertiary and then we can divide and conquer
on the steps to determine if they are working properly on chr20
On Tue, Aug 20, 2019 at 7:32 PM Kishwar Shafin<EMAIL_ADDRESS>wrote:

Is trevor available anywhere?
On Wed, Aug 21, 2019 at 7:38 AM Rob Currie<EMAIL_ADDRESS>wrote:

Helen doesn't run according to trevor. @kishwarshafin
https://github.com/kishwarshafin can you take a look? (we need #1
https://github.com/ucsc-upd/pipelines/issues/1 fixed first...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=ACQR4P2WJ3QBWWBGMCZQS33QFSMABA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGMMB2A
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ACQR4P4BJ6T56XQK5AYJ6Y3QFSMABANCNFSM4IN7THBA
.

--
Kishwar
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=AADYIGUIWVODGLF7JVDKNE3QFSSMDA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YHOJY#issuecomment-523269927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADYIGRXWOEWWIDUQW6QSUTQFSSMDANCNFSM4IN7THBA
.

Rob, MP-HELEN is all dockerized. I don’t see a performance issue in the
docker versions. Trevor was making one docker for the entire pipeline. I am
not sure what needs to be done. Is there a test data that you are trying to
run?
On Wed, Aug 21, 2019 at 8:36 AM Rob Currie<EMAIL_ADDRESS>wrote:

He's off grid. If its a nightmare to sort before he gets back we can try
and decouple I suppose. Primary goal a this point is to just get something
that 'runs' all the way through tertiary and then we can divide and conquer
on the steps to determine if they are working properly on chr20
On Tue, Aug 20, 2019 at 7:32 PM Kishwar Shafin<EMAIL_ADDRESS>wrote:

Is trevor available anywhere?
On Wed, Aug 21, 2019 at 7:38 AM Rob Currie<EMAIL_ADDRESS>wrote:

Helen doesn't run according to trevor. @kishwarshafin
https://github.com/kishwarshafin can you take a look? (we need #1
https://github.com/ucsc-upd/pipelines/issues/1 fixed first...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=ACQR4P2WJ3QBWWBGMCZQS33QFSMABA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGMMB2A

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ACQR4P4BJ6T56XQK5AYJ6Y3QFSMABANCNFSM4IN7THBA

.

--
Kishwar
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=AADYIGUIWVODGLF7JVDKNE3QFSSMDA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YHOJY#issuecomment-523269927
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AADYIGRXWOEWWIDUQW6QSUTQFSSMDANCNFSM4IN7THBA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=ACQR4PYWNK7N5DVV4ADRVNDQFSSZHA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YHTUQ#issuecomment-523270610,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQR4P4ULXPGOPAMYD4AHDLQFSSZHANCNFSM4IN7THBA
.

--
Kishwar

Sorry, I didn't realize I was replying here. I'll look into this soon.

Follow the README and let me know if it doesn't work as advertised. Should run all the way through marginPolish and the core dump. So Helen can't really run. If you can sort Helen w/o that go ahead, otherwise I'm going to run the bigger sample Trevor provided (GM24385.chr20.fasta) and see if it gets through marginPolish so Helen can run.

Were you able to run HELEN with the chr20 data?

@kishwarshafin HELEN core dumps on the GM24385.chr20.fasta marginPolish output, but, maybe I'm calling it wrong as Trevor didn't have that working. I've run the pipelines using the Makefile through marginPolish with output at prism.mustard:/private/home/rcurrie/data/upd (I've made it upd group readable so you should be able to get at it on prims/mustart).
I'm calling it via:
  wget -N https://storage.googleapis.com/kishwar-helen/helen_trained_models/v0.0.1/r941_flip235_v001.pkl
  docker run -it --rm --user=`id -u`:`id -g` --cpus="$(CPU)" -v `pwd`:/data \
    kishwars/helen:0.0.1.cpu \
    call_consensus.py -i /data/marginPolish -m r941_flip235_v001.pkl -o helen -w $(CPU)

the -i is to the output folder from marginPolish - is that correct? Trevor's script moved the marginPolish fast out of there but I kept a copy in there in case Helen wants to see it there.

I'm running it. I can give an update soon.
Btw, in the pipeline you convert the FASTQ to FASTA and keep using the FASTA, this is not recommended. MP-HELEN depends on the qualities of FASTQ, so, for mapping, you should use the FASTQ.

Just for Helen or for some of the steps before that? Shasta deals in FASTA's - are you saying feed FASTQ to everything after that?

Ok, I think I see, feed the original fastq and shasta.fasta into minimap and then proceed in fastq/bam/sam land from then on - right?

That's right, only Shasta uses FASTA. For generating the mapping between alignment and reads, you should use FASTQ. So, everything after Shasta (minimap) should be FASTQ.

Got it, will iterate Makefile and report back. Does helen just need the
marginPolish/ output (plus model pkl)?
On Wed, Aug 21, 2019, 1:35 PM Kishwar Shafin<EMAIL_ADDRESS>wrote:

That's right, only Shasta uses FASTA. For generating the mapping between
alignment and reads, you should use FASTQ. So, everything after Shasta
(minimap) should be FASTQ.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=AADYIGRRSNEA7GVMZZH6VITQFWRHTA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43BJZY#issuecomment-523637991,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADYIGWJSASXFYR3DTOU6CTQFWRHTANCNFSM4IN7THBA
.

yes it only needs h5 files generated by marginpolish then it'll generate output in -o directory with -p prefix of the filename

Re-ran using fastq into minimap and therefore downstream. marginPolish seems to work with the exception of some problems at the end changing file ownership, probably because its running as the user instead of root. @kishwarshafin tried to run helen and still getting core dumps. The data is at /private/home/rcurrie/data/upd and you should be able to get at it if you want to try on that, or just run from start using the makefile as currently pushed.

I have a working version. PR coming soon.

Just looking at the log, it might be not configuring shared memory when calling the docker:
^M  0%|                     | 0/241 [00:00<?, ?it/s]ERROR: Unexpected bus error encountered in worker. This might be caused by insufficient shared memory (shm).
^@ERROR: Unexpected bus error encountered in worker. This might be caused by insufficient shared memory (shm).
^@ERROR: Unexpected bus error encountered in worker. This might be caused by insufficient shared memory (shm).
^@ERROR: Unexpected bus error encountered in worker. This might be caused by insufficient shared memory (

Will wait for the PR and test when ready

I fixed everything in my fork. It runs end to end. Re-confirming everything and then will do a PR and ask you to test.

This docker incantation seemed to get Helen further:
        --shm-size=256G --memory=512G \

This was a pytorch error, the way they set up the worker crashes when inside a docker,  so if you force the number of worker to be 0 it'll work.

PR added.

@rcurrie , any update?

Sorry, spent morning at a security conference for the IT folks on campus, part of the trade for our 7kW of power :-) Shasta and minimap ran fine so far. End of those try to set the permissions on a bunch of files but I'm running as the calling user, is there some canonical way trevor/everyone is passing in which user/group the last part of the dockerized pipeline is trying to set all the files ownership to?

Never mind, found it:
# Fix ownership of output files
finish() {
    # Fix ownership of output files
    user_id=$(stat -c '%u:%g' /data)
    chown -R ${user_id} /data
}

@kishwarshafin Works! Ran to completion and generated helen_hdf5/prediction.hdf so closing.
But alas after today's call it appears are not computationally in a position to use shasta/marginPolish/Helen for variant calling. Will leave in the Makefile but the base level analysis is going to be minimap to hg38 and call variants with freebayes.

Rob, it should generate a fasta file which is the final output.
On Fri, Aug 23, 2019 at 10:42 AM Rob Currie<EMAIL_ADDRESS>wrote:

@kishwarshafin https://github.com/kishwarshafin Works! Ran to
completion and generated helen_hdf5/prediction.hdf so closing.
But alas after today's call it appears are not computationally in a
position to use shasta/marginPolish/Helen for variant calling. Will leave
in the Makefile but the base level analysis is going to be minimap to hg38
and call variants with freebayes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ucsc-upd/pipelines/issues/2?email_source=notifications&email_token=ACQR4P75GLKEMOG2RLUFZXTQF5TETA5CNFSM4IN7THBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD47DGXY#issuecomment-524170079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQR4P5CG7ADYBPE7ZKBKF3QF5TETANCNFSM4IN7THBA
.

--
Kishwar

Ah, it did. The second step (stitch.py) didn't run because the first one failed at the end running chown. I forced the second step and shasta_mp_helen_assembly.fa is generated. Running as root in the container fixes the first step.


Why does find() not return a cursor?

Just a question I'm having trouble understanding
Normally in meteor I thought find() would return a cursor only, but when I log it shows its actually the whole array of objects from the collection - is this normal?
export default withTracker((props) => {
      objectReady: Meteor.subscribe('collection').ready(),
      currentObject: Collection.find({ "important": true })
}

I thought you would need to fetch() first? https://forums.meteor.com/t/why-is-this-working-without-fetch/48034

@sflowerlisa22  try This->
Meteor.collection("collectionName", { cursoredFind: true })


Binskim errors in SqlServerSpatial160.dll

Is your feature request related to a problem? Please describe.
I'm trying to address Binskim issues from my webapp. I noticed SqlServerSpatial160.dll fails on EnableControlFlowGuard rule. I am not sure if this is fixable since this seems to be from Microsoft.SqlServer.Types dependency?
Describe the solution you'd like
Binskim EnableControlFlowGuard rule passed
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @dhavv please contact the owners of Microsoft.SqlServer.Types directly. You can use the "Contact Owners" link from the Nuget page: https://www.nuget.org/packages/Microsoft.SqlServer.Types


More contrast between text and background

There has to be more contrast between text and background. Helps to improve web accessibility.

Based on https://contrastchecker.com/ the current colours of #777 and #FFF give a ratio of 20.14 which exceeds the WCAG guideline of 18. What should the new colours be?

Upon closer inspection, what is probably the issue is the grey-background box on the front page which indeed does not meet the criteria for fonts below 18pts and the colour difference criteria. It does not concern the actual content, however and we are supposed to get a brand new design for the portal anyway?


[Improvement]Update README.md

Improvement Improving the readablity of the readme.md
Changes proposed ✍
What
Making the crowd.dev description in readme.md more readable.
Why
There is some grammatical improvement.
No issue is created as it's very minor improvement
How
Checklist ✅

[x] Label appropriately with Feature, Improvement, or Bug.
[x] Add screenshots to the PR description for relevant FE changes
[x] New backend functionality has been unit-tested.
[x] API documentation has been updated (if necessary) (see docs on API documentation).
[x] Quality standards are met.

@joanagmaia I hope the updated pr has no issues.

@joanagmaia any update??


wen-restart: Find heaviest fork

Pass final result of aggregate RestartLastVotedForkSlots to next stage
Find the heaviest fork based on the information

Codecov Report
Attention: Patch coverage is 86.15385% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (f8bb98b) to head (483d12d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #183    +/-   ##
========================================
  Coverage    81.9%    81.9%
========================================
  Files         837      837
  Lines      226539   226814   +275
========================================
+ Hits       185574   185802   +228
- Misses      40965    41012    +47


TFields  values should be of type string | null

Please avoid duplicates

[X] I checked all open feature requests and none of them matched my problem.

What’s missing?
https://github.com/gr2m/github-project/blob/main/index.d.ts#L10
For TFields the value's type should be string | null instead of string
Why?
There's no guarantee a configured field has a value
Alternatives you tried
Ignore the TS type
Would you be interested in contributing the feature?

[X] yes

My description here wasn't exactly correct -- what was necessary was to differentiate between "project fields" and "project item fields" types


drivers: serial : uart_nrf5: add power management control

    NRF52 uart IP seems to consume 500uA when it is activated.
    During low power sessions, we would like to desactivate uart totally.
    Thanks to this commit, power consumption decreases significantly (only few uA...)  as soon as low power control has been requested,

Signed-off-by: Ismael Fillonneau<EMAIL_ADDRESS>

Codecov Report

Merging #7034 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7034   +/-   ##
=======================================
  Coverage   58.58%   58.58%
=======================================
  Files         463      463
  Lines       47389    47389
  Branches     8786     8786
=======================================
  Hits        27762    27762
  Misses      15795    15795
  Partials     3832     3832

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c542c0e...cac433b. Read the comment docs.

@carlescufi @anangl is some of the higher power usage due to using UART mode and not UARTE (EasyDMA)?

@jarz-nordic can you please take a look at this? should @ifillonneau rebase or do you plan to push similar functionality soon?

Please rebase. File uart_nrf5.c was renamed to uart_nrfx_uart.c and it was significantly changed.

I rebased the commit. I saw in latest modifications that you removed "uart_nrf5_dev_data_t" structure,
so I put "device_power_state" variable as global.

@ifillonneau would you mind rebasing instead of merging?  we don't allow merge commits in Pull Requests. More info here: http://docs.zephyrproject.org/contribute/contribute_guidelines.html#contribution-workflow

online changes was not the good way! new commit has been pushed ...

@jarz-nordic @anangl can you please review this when you have a moment?

@jarz-nordic @anangl Since this has been brought up in the mailing list, can we fast-track the review? Thanks!

is this PR still needed?

Yes, this was implemented as part of https://github.com/zephyrproject-rtos/zephyr/pull/9119.
@ifillonneau thanks very much for the contribution.

I am encountering sleep currents of ~0.5 mA on nRF52840DK with Zephyr 2.5.0. I am running the system off example which should be disabling the power of the UART peripheral while being in System ON sleep.  At this stage of the application, it is consuming ~0.5 mA for me.
When it goes to System OFF, I get an average of 12 uA.
Could anything have been introduced that messes with this implementation?


Icon for the app

It is a good idea to make (design) some icon for the application. Also the approach when generating different sizes for the app is specific for Android in specific location and folder names.

https://appicon.co/


comparison with choc

Thank you for this very interesting project!
Is there a detailed comparison anywhere of oh with choc (as defined in your Masters thesis)?  Just for example, does oh have a built-in clone operation?

Thanks for your interest. There is no detailed comparison of oh with choc. They are siblings so there are many similarities but there are also many differences. Oh did have a clone method but that was removed in the last round of cleanups as I found it was never used.

Thank you!


Update reference architectures for 5.20.0 release

Description

Include new ROKS quickstart ref arch by setting production to true.
Minor editorial updates on ocp-quickstart. @toddgiguere please check.
Update dates and versions

Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

:tada: This PR is included in version 5.20.1 :tada:
The release is available on:

GitHub release
v5.20.1

Your semantic-release bot :package::rocket:


decomp: finish demo-obs | sequence-a-village1 | misty-obs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.805%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
40807

Relevant Lines:
74458

💛  - Coveralls


add more e2e tests for authz dry-run with TCP traffic

Please provide a description of this PR:

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@yangminzhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
bf82b574b45051b88182fe63575c08f1f81b81f7
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
bf82b574b45051b88182fe63575c08f1f81b81f7
link
true
/test lint_istio

analyze-tests_istio
bf82b574b45051b88182fe63575c08f1f81b81f7
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@yangminzhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster-tests_istio
a67601ec81bd18a7d56acb89e5de702a500c3faa
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

@istio/wg-policies-and-telemetry-maintainers could someone take a look, thanks.


Add NES, SNES, GBA, and N64 Resolution packs

Have fun looking through this, or trying to validate the title ids.

Folder names should also match the other Resolution Packs:
VCGBA_Resolution
VCN64_Resolution

etc etc.

Folder names should also match the other Resolution Packs:
VCGBA_Resolution
VCN64_Resolution

etc etc.

I have no clue how to change this in github :/

Hm, alright. If I remember to I can rename after it's merged. Just needs testing now


Vulnerabilities in packages that CLI depends on (auditjs)

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.4.1
node: 6.9.5
os: win32 x64
@angular/animations: 4.3.6
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.4.1
@angular/compiler-cli: 4.3.6
@angular/language-service: 4.3.6
typescript: 2.3.4
Repro steps.
-> Generate new app using CLI (ng new sample-app)
-> Install auditjs https://www.npmjs.com/package/auditjs
-> Run auditjs inside generated sample-app
The log given by the failure.
auditjs outputs vulnerabilities in:
handlebars 1.3.0
uglify-js 2.3.6
sockjs 0.3.18
ws 1.1.2
Desired functionality.
No vulnerabilities in packages used by Angular CLI based app.
All of the packages that are highlighted as vulnerable are used under the hood by angular CLI so we can't just update them easily ourselves. This is crucial for enterprise application though, that packages that app depends on are free of known vulnerabilities. We are looking for CLI to be updated to use latest versions of packages which are free of vulnerabilities.

Hi @adamlubek,
Thanks for reporting this. I looked at auditjs output;

handlebars 1.3.0. This comes from postcss-url, and we have no control over it. The good news is I don't know why they depend on 1.3 which is really old.
uglify-js 2.3.6. These are all injection when using uglify, and dependent on the project's code. This is relatively serious, but we're in the process of upgrading uglify-js to the latest version so it will be fixed soon.
sockjs 0.3.18. This is used by webpack-dev-server, which we do not recommend already to run in production or any server visible from the internet. CORS in a dev environment is less severe, but we should keep an eye on it. We'll let the webpack-dev-server know.
ws 1.1.2. WebSocket has insufficient randomization, but like sockjs we only use it for development environment, and as such the severity of this is relatively low.

Please include the details next time you run an audit.
Thanks a lot for this. It will make our project more secure in the future.
I'm closing this with follow ups about sockjs to the webpack-dev-server team.


Lectures: Store learning goal progress for faster access

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I documented the TypeScript code using JSDoc style.

Motivation and Context

The progress for the learning goals were calculated on-the-fly.
As we want to integrate Adaptive Learning and generate recommendations for each user, it will be more performant to persist the progress in a learning goal for each user in the database (similar to the Participant Scores).
Description

A new table is added to the database to persist the progress (percentage of completed learning objects linked to the learning goal), and confidence (average score for all exercise linked to the learning goal) for each user and learning goal combination.
Note: The learning goal user interface will be overhauled in a follow-up PR (#5753). That is why the functionality to click on a learning goal to show a detailed modal was disabled here.
Steps for Testing

Prerequisites:

1 Instructor
1 Learning Goal
Some Exercises and Lecture Units

Log in to Artemis
Navigate to Course Administration
Create exercise units for the exercises
Add all lecture units to the learning goal
Complete the lecture units
Make a submission to an exercise and assess it
Observe that the learning goal progress changes accordingly

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

LearningGoalProgressScheduleService.java
75%
90%

LearningGoalService.java
75%
89%

LectureUnitCompletionListener.java
100%
100%

ParticipantScoreListener.java
75%
98%

MainInstanceMessageSendService.java
n/a
95%

ParticipantScoreScheduleService.java
74%
88%

UserService.java
79%
91%

LearningGoalResource.java
65%
92%

learning-goal-management.component.ts
53%
65%

learning-goal-card.component.ts
69%
94%

course-learning-goals.component.ts
100%
100%

@manuelmanso Thanks, fixed! The LearningGoalProgressScheduleService is already covered by some tests in LearningGoalIntegrationTest.java. Since I am in the process of redesigning the learning goal user interface and some additional refactoring will be done there, I will add some more tests in that follow-up PR.

Codecov Report
Base: 75.62% // Head: 75.61% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (5d8e417) compared to base (b62b511).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5685      +/-   ##
===========================================
- Coverage    75.62%   75.61%   -0.02%
===========================================
  Files         1109     1109
  Lines        43780    43705      -75
  Branches      8269     8259      -10
===========================================
- Hits         33109    33046      -63
+ Misses        5556     5549       -7
+ Partials      5115     5110       -5

Flag
Coverage Δ

client
75.61% <50.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...dal/learning-goal-course-detail-modal.component.ts
69.23% <0.00%> (-19.24%)
:arrow_down:

.../app/course/learning-goals/learningGoal.service.ts
68.75% <ø> (-3.48%)
:arrow_down:

src/main/webapp/app/entities/learningGoal.model.ts
85.71% <ø> (ø)

...-learning-goals/course-learning-goals.component.ts
93.33% <0.00%> (+1.53%)
:arrow_up:

...l-management/learning-goal-management.component.ts
63.73% <66.66%> (-4.84%)
:arrow_down:

...learning-goal-card/learning-goal-card.component.ts
88.23% <100.00%> (+25.44%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I changed the implementation from using listeners and a scheduler to an @Async method. Please re-test and message me on Slack if you have any questions. 🙂

@evgeny1984 Please read the testing steps, this PR only modifies how the learning goal progress is calculated and persisted. Everything else related to the user interface will be done in the stacked PR. I will note down your feedback for there.

@stefanwaldhauser @JonasGeigerTUM @evgeny1984 @JohannesStoehr
I incorporated Stefan's request by adding more logging messages. Thanks for re-reviewing. 🙂


Plan for Upgrade to Quarkus 3.0

Quarkus 3.0.0.Alpha2 has already been released, with planned release of "3.0.0.Final in February 2023"
The ML thread is here: https://groups.google.com/g/quarkus-dev/c/xjHIBk6Mx7k
There are some major breaking changes that Quarkus 3.0 will bring, the Quarkus team have produced a migration guide for extension maintainers, but should be useful for us as well: https://github.com/quarkiverse/quarkiverse/wiki/Migrating-to-Quarkus-3.x
We should plan to test against early 3.0 release to see what breaks, however ORM6 is not included in the Alpha release so far

I am a bit worried about the Jakarta stuff. The api and client modules are Java 8 and we rely on the javax.ws.rs annotations. We could keep the old package names in api through horreum-api-generator that's already rewriting the bytecode but that part will require some work.
Alternatively we could say bye bye to old Jenkins versions, require at least 2.361.1 and base API on a version that's not a fossil...

This is a task like upgrading to React 5

I'll pick up this task. The migration path is non-trivial, even with the Quarkus 3.0 migration tool.
There are a lot of API changes in ORM6 that means this is not a straightforward upgrade

@johnaohara We don't need this right now, but feel free to assign

I made an attempt, but it's not straight forward as there are many (breaking) changes...

Hib6 supports JSON now and they have a JSON Jackson mapper afaik. We use a lot of .addScalar("filterlabels", JsonNodeBinaryType.INSTANCE), I changed that to .TEXT as I could not find any  JSON mapper in org.hibernate.types.StandardBasicTypes.
ScrollableResults have changed, but it's fairly easy to rewrite to the new API
Hib6 also defaults to some different types, eg Enums are now tinyints, there are also some changes to timestamp default types. These can be overwritten though with the @JdbcTypeCode annotation.
Hib6 has also changed how they generate sequence tables. I'm not sure of the implications it has with "normal" tables in Horreum as we have fairly "standard" sequences, but where it does break is for ActionLogDAO as it has a mapped superclass PersistenceLog.
When starting Quarkus it fails with this message: org.hibernate.tool.schema.spi.SchemaManagementException: Schema-validation: missing sequence [ActionLog_SEQ]
I tried to set this property in application.properties: hibernate.id.db_structure_naming_strategy=legacy but it still fails.
https://github.com/stalep/repo/commit/1b2192ac6060765f13a3bc9803b1b88d847af464

I have broken my machine and don't have access to an IDE atm, but one immediate thought

I made an attempt, but it's not straight forward as there are many (breaking) changes...
* Hib6 supports JSON now and they have a JSON Jackson mapper afaik. We use a lot of `.addScalar("filterlabels", JsonNodeBinaryType.INSTANCE)`, I changed that to .TEXT as I could not find any  JSON mapper in org.hibernate.types.StandardBasicTypes.

I don't think this will work, were are using the jsonb datatype throughout the DB schema

I don't think this will work, were are using the jsonb datatype throughout the DB schema
Yes, I also have concerns about that, but I could not find any examples for this in hib6, not any solutions at vladm.. either. I'll search some more.

This is a complex issue - that will require porting in all layers.
Starting with #518 will likely help, as we can let Hibernate do the DB layout, and just install our custom functions.

Closing as we're on Quarkus3 in master


Describe clustermesh-apiserver architecture

I couldn't find any (even short) description of how clustermesh-apiserver works (architecture; is it serving an etcd API and internally querying k8s apiserver? Or serving a k8s apiserver API and internally querying etcd? how does it fit into the cluster?), it would be good to add this at least to maybe the clustermesh-apiserver/README.md or perhaps under the documentation as a new page in the "concepts" section.

I have been looking exactly for this information :) ..had to go through the code of cilium-cli and clustermesh code to understand it.

@jrajahalme any progress with this or is it ok to take this over?

@oblazek I've assigned you.


Create makefile

Good source for information with a sample makefile https://wiki.archlinux.org/title/AVR


(Build) Fail on dev branch.

This issue is created automatically by CI.
Linux Build State: failure
Windows Build State: failure
Commit: 849bc9169bcded4b65e14469cc1779debaa2ffa3
Commit Branch: dev
Commit Author: innerviewer

Auto-closing as build in this branch is successful now. Commit: 97949f4cc292cd5f9cee8117654c12595aac0cf5


Support cross-package nolint parsing

We can report errors on pkg A when we are analyzing pkg B due to our multi-pkg inference. However, nogo’s support for nolint comments is based on reading the AST from current package.
That is, nogo does not know we have a nolint comment in pkg A when analyzing pkg B , but NilAway can report an error there, and hence cannot be suppressed.
The other linter implementations most likely follow the same logic.
We’ll need to implement own cross-pkg nolint support (i.e., reading the nolint and writing it to facts, then read it in downstream analysis to decide whether to report a certain error or not).

I think you're constrained to use the "//nolint:" notation, but just to clarify my understanding, am I correct in thinking what you mean it to express is "this cannot be nil by construction"?
I just ran nilaway on a program that of mine, and added // postcondition: x is non-nil to remind me that the library code I just called produces a non-nil result. (I sort of miss #define ASSERT(...) from a less-modern language (;-))

@davecb Not exactly :)
//nolint: here basically just suppresses errors reported, without meaning anything else.
You're probably thinking about adding annotations to parameters & returns, similar to what Java has (@Nullable and @Nonnull).
In NilAway we try to avoid adding annotation burden onto devs since it's not a builtin language feature unlike Java. But we do parse comments like
//nonnil(result 0)
func foo() (*int) {....}

Where the return value would be assumed nonnil in NilAway's perspective. But those are mostly for testing purposes (do not rely on this feature in your code, though).
In the future, we plan to add a tiny "annotation"-like library that NilAway understands, and most importantly will log and/or panic if the assumption is broken.
func main() {
  // say for some complex code in foo NilAway just cannot reason the return value is nonnil, but you as a developer know that for sure.
  v := foo()
  v := castToNonnil(v)
  print(*v) // NilAway won't complain here anymore.
}

where castToNonnil does nothing but return the same value, in the meantime it can log and/or panic if the input is ever nil (i.e., breaks the assumption) to (1) combat false positives in NilAway in edge cases, and (2) still raise awareness of code defects.


Improve cleanup-repo-filelist-actions’s reliability

LINKED ISSUES:
https://github.com/sindresorhus/refined-github/pull/3405#issuecomment-666905584

TEST URLS:
Open any file (such as https://github.com/sindresorhus/refined-github/blob/master/license) and go to repo root (https://github.com/sindresorhus/refined-github)

SCREENSHOT:
None

I may be wrong, as you said it fixes https://github.com/sindresorhus/refined-github/pull/3405#issuecomment-666905584

Somehow this caused a serious issue and I don't really know why. Can you replicate it? https://github.com/sindresorhus/refined-github/issues/3527


use "docker volume" subcommand when using docker 1.9+

docker-cleanup-volumes.sh doesn't remove volumes properly, since
docker introduced the "volume" subcommand in 1.9.0.
This patch detects the docker version, and runs either
docker-cleanup-volumes.sh or docker volume rm accordingly.
Fixes #24

NB: this introduces a hard dependency on having docker client version >= 1.8, as this version adds the --format switch to docker version. This shouldn't be a problem according to the Dockerfile
cf: https://docs.docker.com/v1.7/docker/reference/commandline/version/ and https://docs.docker.com/v1.8/reference/commandline/version/


Enhance development user experience

[ ] #353
[ ] #354

Support only one ruby version
Separated containers for tweemproxy and sentinels
Separated contatiners for redis. New redis version. Maybe 6.2??

[ ] #355
[ ] #356
[ ] #357

@jlledom FYI

I would add

Enable dotenv: https://github.com/bkeepers/dotenv
Add scripts under /bin to launch both listener and worker in a single thread so the process can be attached to a debugger
Configure logs to store the log files under /log where in development or test


Follow Laravel release schedule

We "follow" Laravel release schedule, stating "February" is misleading.

A new inspection was created.


 Does anyone have the solution for this? Thank you~

I found the solution already. I used the Glide library to load the image and it's getting error to show because of the cache. If you find the same issue, may try to solve it from the caching things.


[1pt] PR: Renaming of benchmark data and associated variables

The benchmark inundation rasters were named "depth" instead of "extent", and NWS and USGS domain shapefiles were named "extent" instead of "domain". This branch addresses those issues in the test_cases directory and in run_test_case.py as well as run_test_case_calibration.py, although the latter will likely be deprecated.
Testing
To test, you can run:
python foss_fim/tools/run_test_case.py -r fim_3_0_4_4_ms_c_agg/12090301/ -b dev-rename-pr-nws -t 12090301_nws

and then run:
python foss_fim/tools/run_test_case.py -r fim_3_0_4_4_ms_c_agg/12090301/ -b dev-rename-pr-ble -t 12090301_ble

And confirm no Traceback errors and good-looking outputs.

In running the first command: python foss_fim/tools/run_test_case.py -r fim_3_0_4_4_ms_c_agg/12090301/ -b dev-rename-pr-nws -t 12090301_nws
A warning is produced when evaluating cbst2 for action magnitude:
RuntimeWarning: invalid value encountered in double_s                        calars
  MCC = (TP*TN - FP*FN)/ np.sqrt((TP+FP)*(TP+FN)*(TN+FP)*(TN+FN))

Also it appears to be iterating multiple times (minor/moderate/major), for example see screenshots:

In running the 2nd command: `python foss_fim/tools/run_test_case.py -r fim_3_0_4_4_ms_c_agg/12090301/ -b dev-rename-pr-ble -t 12090301_ble'
This appears to run without error.
I will verify look at outputs shortly but wanted to get this out there in case it needed addressing or maybe I am mis-interpreting the output.

That warning often happens when a math operation is not possible, perhaps because one of the contingency categories had a zero pixel count. It has been happening for a while and should be unrelated to these changes.

The ble outputs appear to be in place and the visually look appropriate. I verified that the huc wide CSI are consistent from pr-rename-pr-ble vs fim_3_0_4_4_ms_c for both 100 and 500yr.
The nws outputs appear to be in place and visually look appropriate. I verifed that for major category BRTT2 has consistent CSI from dev-rename-pr-nws.
Recommend investigating artifact issues related to messages printed to screen and domain extents for instances where no flow files are supplied (ahps) as future tickets.
I approve this PR


az network application-gateway ssl-cert -- Is there any option to view the expiry of SSL cert

Is your feature request related to a problem? Please describe.
az network application-gateway ssl-cert is used to manage the SSL certificates of an application gateway. However, I am not able to find any option to view the expiry date of the certificate. Getting to know the expiry date is essential at times and would be a helpful feature to have. Is there any way to view the expiry of the SSL certificate of an application gateway.
Describe the solution you'd like
Having an option to view the expiry date of an SSL certificate of an application gateway would be very helpful. If there is already a way to do it, adding an example in the cli and docs would be very helpful.
Describe alternatives you've considered
Tried the following command but did not find any good way to extract the SSL certificate expiry
(Note that argument values have been redacted, as they may contain sensitive information.)
az network application-gateway ssl-cert show -g test-rg --gateway-name test-aag --name test.example.com
{   "data": null,   "etag": "W/\"136379e-3fcca\"",   "id": "/subscriptions/zbca-fa02b/resourceGroups/test-rg/providers/Microsoft.Network/applicationGateways/test-aag/sslCertificates/test.example.com",   "keyVaultSecretId": null,   "name": "test.example.com",   "password": null,   "provisioningState": "Succeeded",   "publicCertData": "QMVPYn209pT/4k2IBDL1AB0z1WJH7Jioqeu72l/XLJpUlTYZ90le68xxM727Cz2GKpXyak1f19+4oK52is7td59BS60sF+O0dUKtaaS8hE26NXeVVY+1pOjyid70irCMeJda5JPrTKjEA",   "resourceGroup": "test-rg",   "type": "Microsoft.Network/applicationGateways/sslCertificates" }

add to S173

@subhasishdc Thanks for raising this issue. Based on my understanding, expiry time is part of SSL cert and we can obtain the data information of the cert. Using some X509 library, should we be able to see the date?

@MyronFanQiu : Thank you for the clarification. The publicCertData field shown in the example able displays the cert but there is no information anywhere on what format this cert is in. I read somewhere online that the format returned by the command in the example is PKCS7. Is that correct? Can you provide some clarity on the field publicCertData which is returned by the az network application-gateway ssl-cert list|show commands.

@subhasishdc Hi. I don't know too much about PKCS7. User need to input a .pfx file. so I think it might be PKCS 12? Here is one of our test file and hope it can help you.

@MyronFanQiu : I did a lot of digging on the publicCertData field returned by the az network application-gateway ssl-cert list|show commands to find out what format it is in. It looks like it is in PKCS7 format. Example is as follows:
$ openssl pkcs7 -print_certs -in test_domain_com.p7b | openssl x509 -noout -enddate notAfter=Jul 30 12:00:00 2020 GMT
I created a cert file in the example above with the data of the field publicCertData. The pkcs7 format got decrypted correctly.
Can you please confirm the above. Also, would it be a good idea to add this information as an example both to the CLI and documentation. If yes, I can do it.

@subhasishdc We always appreciate any better help message. 😄 Based on your command, looks like you store the data into .p7b file. .p7b file is PKCS7. According to my understanding, if you use a .pfx to store this file, it will need pkcs12? I'm not sure whether we can use .p7b file as the cert-file. I can invite service team to double confirm this behavior.

@MyronFanQiu : I tried saving it to a .pfx file and tried to decode it but it throws an error. Hence, it is not in pkcs12 format. On storing it in .p7b format, the decoding is successful. Therefore, I am sure the format is pkcs7. Can you confirm with the service team on this. If they confirm, I will modify the help message.
$ openssl pkcs12 -in test_domain_com.pfx -out test_domain_com.pem -nodes
140550717241232:error:0D0680A8:asn1 encoding routines:ASN1_CHECK_TLEN:wrong tag:tasn_dec.c:1220:<PHONE_NUMBER>41232:error:0D07803A:asn1 encoding routines:ASN1_ITEM_EX_D2I:nested asn1 error:tasn_dec.c:386:Type=PKCS12

@MyronFanQiu : Did you get any update from the service team on this

@MyronFanQiu : Discussed this with Akshay Gupta from the service team. He has confirmed that the command takes a pfx file as input which is pkcs12 and show/list shows only the public part of the cert which pkcs7.
I will create a PR to add a good example to the help section and documentation to demonstrate this behavior so that it is of help for everyone. Will let you know once I do it.


DfsLogger should use nanos

DfsLogger has has a time duration calculation based on System.currentTimeMillis(), but should use System.nanoTime() instead, so it is not broken by system clock changes.

I can take a look at this.


[$1000] Incorrect Redirection on Page Crash: 'Go Back to Home Page' Button Opens Last Visited Page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login with User A (A mobile number) and create a Workspace
Add User B as member
Create a new room in restricted mode within that workspace
Click on Split money
Set amount and description > split
Open the split money box from both user A and user B
Click on user details and it does not open.
You will see “Hmm... it's not here
Oops, this page cannot be found: Go back to Home page”
Click on “Go back to home page”
Verify:
Verify if it leads to last visited page or homepage

Expected Result:
Clicking on the "Go Back to Home Page" button should redirect the user to the home page of the application.
Actual Result:
Clicking on the "Go Back to Home Page" button does not lead to the home page but rather opens the last visited page
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?:  needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/2f4b4221-a2ca-4897-abce-f0856d25eacb
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687037591793089
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c11837b0985d271a
Upwork Job ID:<PHONE_NUMBER>060816384
Last Price Increase: 2023-06-26

@0xmiroslav thoughts on @hungvu193's proposal?

@0xmiroslav bump on the proposal review, thanks!

I am not able to reproduce this. @avi-shek-jha if this is still reproducible, can you please share video with full reproduction step? Please try to test with 2 fresh accounts.

Hi @oxmiroslav, The "Go back to home page"  button only appears during certain page crashes. To reproduce this, we need to first trigger a page crash. Unfortunately, the steps that triggered a page crash when I reported this, no longer trigger a page crash now.  Also, it is not possible to specify where the page crash will occur in the future. If I get one in the future, I will surely let you know. Perhaps, the internal team can help with this.

I'm going to go ahead and close this since it seems we are no longer able to reproduce. Feel free to report it again if you're able to come up with consistent steps.

@puneetlath Now we have consistent reproducible steps. Take a look if you want to: https://expensify.slack.com/archives/C049HHMV9SM/p1690851151974449


Add file bootstrap.dat.xz - 1.4.1

Please, can you add a bootstrap.dat.xz file for each release?
It really helps users for starting a new wallet and its better for the network health.
Thanks in advance!

Hi,
bootstrap.dat.xz was added to 1.4.1 release.
thanks

Thank you! I love you! <3


⚠ Bofrost.fr has degraded performance

In c655079, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1281 ms

Resolved: Bofrost.fr performance has improved in d605935 after 9 minutes.


[question] The 'data' field in the MQTT topic application/1/node/123/rx

Hello. First of all thanks for making this software. I had some problems installing it, because we use an old ubuntu version, but i got it working thanks to the comprehensive guide and some google work. I installed the lora app server 10.1, gateway-bridge 2.1.5 and the loraserver 0.19.2. I have a lorank8 gateway.
I have a connection with the gateway and it looks like the join with the end-device worked correctly. I receive messages in the log of each of the programs and also in the web-app at the gatway. But the web-app doesn't show anything under frame logs. When i subscribe to the mqtt topic application/1/node/123/rx (123 repleaced by the applicationID, found by subscribing to the topic application/#) the 'data' field in the json is the same as the encrypted data field in the things network. What could go wrong with the decryption? What do you need to answer my question?
The data from the mqtt topic:
application/1/node/0004a30b0019825b/rx {"applicationID":"1","applicationName":"testOne","nodeName":"testNode","devEUI":"0004a30b0019825b","rxInfo":[{"mac":"1dee0837b0dd02f0","rssi":-23,"loRaSNR":7.5,"name":"Lorank8","latitude":51.98869,"longitude":6.05546,"altitude":0}],"txInfo":{"frequency":868100000,"dataRate":{"modulation":"LORA","bandwidth":125,"spreadFactor":12},"adr":false,"codeRate":"4/5"},"fCnt":462,"fPort":1,"data":"IQ=="} application/1/node/0004a30b0019825b/rx {"applicationID":"1","applicationName":"testOne","nodeName":"testNode","devEUI":"0004a30b0019825b","rxInfo":[{"mac":"1dee0837b0dd02f0","rssi":-47,"loRaSNR":8,"name":"Lorank8","latitude":51.98869,"longitude":6.05546,"altitude":0}],"txInfo":{"frequency":868100000,"dataRate":{"modulation":"LORA","bandwidth":125,"spreadFactor":12},"adr":false,"codeRate":"4/5"},"fCnt":463,"fPort":1,"data":"IQ=="} application/1/node/0004a30b0019825b/rx {"applicationID":"1","applicationName":"testOne","nodeName":"testNode","devEUI":"0004a30b0019825b","rxInfo":[{"mac":"1dee0837b0dd02f0","rssi":-31,"loRaSNR":7.2,"name":"Lorank8","latitude":51.98869,"longitude":6.05546,"altitude":0}],"txInfo":{"frequency":868100000,"dataRate":{"modulation":"LORA","bandwidth":125,"spreadFactor":12},"adr":false,"codeRate":"4/5"},"fCnt":466,"fPort":1,"data":"IQ=="}
The output from the gateway-bridge:
INFO[21173] backend: publishing packet                    topic="gateway/1dee0837b0dd02f0/stats" INFO[21173] gateway: sending udp packet to gateway        addr=<IP_ADDRESS>:45415 protocol_version=2 type=PushACK INFO[21173] gateway: received udp packet from gateway     addr=<IP_ADDRESS>:50841 protocol_version=2 type=PullData INFO[21173] gateway: sending udp packet to gateway        addr=<IP_ADDRESS>:50841 protocol_version=2 type=PullACK INFO[21181] gateway: received udp packet from gateway     addr=<IP_ADDRESS>:45415 protocol_version=2 type=PushData INFO[21181] gateway: rxpk packet received                 addr=<IP_ADDRESS>:45415 data="QEjRSwYA2gEByctOpw0=" mac=1dee0837b0dd02f0 INFO[21181] backend: publishing packet                    topic="gateway/1dee0837b0dd02f0/rx" INFO[21181] gateway: sending udp packet to gateway        addr=<IP_ADDRESS>:45415 protocol_version=2 type=PushACK INFO[21183] gateway: received udp packet from gateway     addr=<IP_ADDRESS>:50841 protocol_version=2 type=PullData INFO[21183] gateway: sending udp packet to gateway        addr=<IP_ADDRESS>:50841 protocol_version=2 type=PullACK
The output from the loraserver:
INFO[21200] backend/gateway: rx packet received           INFO[21200] packet(s) collected                           dev_eui=0004a30b0019825b gw_count=1 gw_macs=1dee0837b0dd02f0 mtype=UnconfirmedDataUp INFO[21200] rx info sent to network-controller            dev_eui=0004a30b0019825b INFO[21200] node-session saved                            dev_addr=064bd148 dev_eui=0004a30b0019825b INFO[21212] backend/gateway: gateway stats packet received  mac=1dee0837b0dd02f0 INFO[21212] gateway updated                               mac=1dee0837b0dd02f0 INFO[21220] backend/gateway: rx packet received           INFO[21220] packet(s) collected                           dev_eui=0004a30b0019825b gw_count=1 gw_macs=1dee0837b0dd02f0 mtype=UnconfirmedDataUp INFO[21220] rx info sent to network-controller            dev_eui=0004a30b0019825b INFO[21220] node-session saved                            dev_addr=064bd148 dev_eui=0004a30b0019825b INFO[21225] backend/gateway: rx packet received           INFO[21225] packet(s) collected                           dev_eui=0004a30b0019825b gw_count=1 gw_macs=1dee0837b0dd02f0 mtype=UnconfirmedDataUp INFO[21225] rx info sent to network-controller            dev_eui=0004a30b0019825b INFO[21225] node-session saved                            dev_addr=064bd148 dev_eui=0004a30b0019825b
And the output from the application server:
INFO[2288] handler/mqtt: publishing data-up payload      topic="application/1/node/0004a30b0019825b/rx" INFO[2288] data-down item requested by network-server, but queue is empty  dev_eui=0004a30b0019825b INFO[2293] handler/mqtt: publishing data-up payload      topic="application/1/node/0004a30b0019825b/rx" INFO[2293] data-down item requested by network-server, but queue is empty  dev_eui=0004a30b0019825b INFO[2298] handler/mqtt: publishing data-up payload      topic="application/1/node/0004a30b0019825b/rx" INFO[2298] data-down item requested by network-server, but queue is empty  dev_eui=0004a30b0019825b
Thanks in advance,
Evi

But the web-app doesn't show anything under frame logs

See --log-node-frames https://docs.loraserver.io/loraserver/install/config/

What could go wrong with the decryption? What do you need to answer my question?

Not sure if I understand what your question is, but the data field is not encrypted. It is base64 encoded.

Ow, oops, I totally misread that! I expected the raw payload in the 'data' field and assumed it was decrypted wrong when I didn't receive that. I used an online base64 decoder and I got the expected pay-load. Thank you for your help!


[Bug]: Cannot solve the composite SiG-anode DFN model with an initial_soc

PyBaMM Version
23.5
Python Version
3.10.12
Describe the bug
I am trying to use the composite SiG-anode DFM model by following the guide at this link. I can reproduce the steps of the guide, but when I introduce an initial_soc value I get the following error:
KeyError: "'Negative electrode OCP [V]' not found. Use the dimensional version 'Primary: Negative electrode OCP [V]' instead."
Steps to Reproduce
import numpy as np

# load parameter values
params = pybamm.ParameterValues('Chen2020_composite')

# set current equal to C/40
params['Current function [A]'] = params['Nominal cell capacity [A.h]'] / 40

# load battery model
model = pybamm.lithium_ion.DFN({
    'particle phases': ('2', '1'),
    'open-circuit potential': (('single', 'current sigmoid'), 'single')
})

# simulate
sim = pybamm.Simulation(model, parameter_values=params)
sim.solve(t_eval=np.arange(0, 50 * 3600, 60), initial_soc=0.2)```

### Relevant log output

```shell
KeyError: "'Negative electrode OCP [V]' not found. Use the dimensional version 'Primary: Negative electrode OCP [V]' instead."

Thanks for bringing this up. This is a known issue, see https://github.com/pybamm-team/PyBaMM/issues/2682


Support for multiple source folders?

Describe the feature
Hello.
There seems to be a use case in Nuxt Image to support multiple source folders, for example nuxt /content and nuxt /assets:
https://twitter.com/mrblot4/status/1649513803745206277
Do you think it would be better to handle this in IPX or Nuxt Image?
I'd be happy to handle any PRs if they fit with the spirit of the library.
Cheers,
Dave
Additional information

[X] Would you be willing to help implement this feature?

Hi and thanks for good idea. Supporting multi sources will be possible once we migrate to unstorage https://github.com/unjs/ipx/issues/135


Allow LINQ Expressions for Binding Expressions

What does the pull request do?

Add new API to allow users to create ExpressionObservers with LINQ Expressions instead of strings.
Move string-based binding paths up to Avalonia.Markup.
Fix attached property resolution to always resolve the correct property.

What is the current behavior?

ExpressionObservers can only have their binding paths specified as strings.
The AvaloniaPropertyAccessorPlugin tries to resolve an attached property name without the XAML context, so it just makes a guess of which property is the correct property.

What is the updated/expected behavior with this PR?

ExpressionObservers can be created from LINQ Expressions, ExpressionNodes, or strings.
Attached property bindings now use the AvaloniaPropertyAccessorNode class instead with an already-resolved AvaloniaProperty that is resolved via a callback (i.e. XAML type lookup) when built from a string.

How was the solution implemented (if it's not obvious)?

Stream Bindings in LINQ Expressions are pattern based. A method that is either an instance method or extension method without parameters named StreamBinding generates a stream binding node at that point in the expression.

Checklist:

[x] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

If the pull request fixes issue(s) list them like this:
Fixes #1652.

Also, does this PR depend on #1668? A lot of the changes seem to be similar.

#1668 is dependent on some of the changes in this PR. After this gets merged in the changes over there will clean up a lot.

This is going to conflict with #1694, which do you think it makes more sense to get merged first?

I'm on vacation for a week, so probably #1694. Alternatively, all that's left to do here is the XML doc comments, so if you want to put those in we could merge this on approval.

@grokys I've made all the requested changes. Can you take another review pass when possible?

I have a few reasons why I like having the string support outside of ExpressionObserver.

By having the string support in the Markup layer, the Reader class moves up as well (enabling #1668)
If we have string support in the base layer as a constructor (as done currently), then we make string bindings the easiest path of use. I'd like to push advanced users that want to directly use ExpressionObserver to use type-safe binding expressions if possible.
By making ExpressionNode and subclasses part of the API, we allow advanced users who want to customize the binding system (which is already supported on ExpressionObserver in master) to create custom binding nodes if they so wish.
Everything in Avalonia.Data.Core is already an implementation detail namespace. I don't think exposing anything in that namespace publicly is necessarily bad.

Ok, yes those sound like good arguments for doing it this way 👍