Update docfx.json

Docs Build status updates of commit 1d7e029:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/docfx.json
:warning:Warning

Details

docs/input-record-str.md
:warning:Warning
View
Details

docs/mouse-event-record-str.md
:warning:Warning
View
Details

docs/key-event-record-str.md
:warning:Warning
View
Details

docs/high-level-console-i-o.md
:warning:Warning
View
Details

docs/getcurrentconsolefontex.md
:warning:Warning
View
Details

docs/getconsoleselectioninfo.md
:warning:Warning
View
Details

docs/input-and-output-methods.md
:warning:Warning
View
Details

docs/console-modes.md
:warning:Warning
View
Details

docs/low-level-console-input-functions.md
:warning:Warning
View
Details

docs/low-level-console-output-functions.md
:warning:Warning
View
Details

docs/getconsoletitle.md
:warning:Warning
View
Details

docs/getlargestconsolewindowsize.md
:warning:Warning
View
Details

docs/getnumberofconsoleinputevents.md
:warning:Warning
View
Details

docs/index.md
:warning:Warning
View
Details

docs/handlerroutine.md
:warning:Warning
View
Details

docs/console-screen-buffer-info-str.md
:warning:Warning
View
Details

docs/getcurrentconsolefont.md
:warning:Warning
View
Details

docs/peekconsoleinput.md
:warning:Warning
View
Details

docs/low-level-console-modes.md
:warning:Warning
View
Details

docs/scrolling-the-screen-buffer.md
:warning:Warning
View
Details

docs/getstdhandle.md
:warning:Warning
View
Details

docs/low-level-console-i-o.md
:warning:Warning
View
Details

docs/getconsolescreenbufferinfoex.md
:warning:Warning
View
Details

docs/getnumberofconsolemousebuttons.md
:warning:Warning
View
Details

This comment lists only the first 25 files in the pull request.

docs/docfx.json

Line 37, Column 40: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'windows-console' is not valid with 'ms.prod' value 'console'.

docs/input-record-str.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/mouse-event-record-str.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/key-event-record-str.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/high-level-console-i-o.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getcurrentconsolefontex.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getconsoleselectioninfo.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/input-and-output-methods.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/console-modes.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/low-level-console-input-functions.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/low-level-console-output-functions.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getconsoletitle.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getlargestconsolewindowsize.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit bdc5d34:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/docfx.json
:warning:Warning

Details

docs/docfx.json

Line 38, Column 40: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'windows-console' is not valid with 'ms.prod' value 'console'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit df910b1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/docfx.json
:warning:Warning

Details

docs/readconsoleoutput.md
:warning:Warning
View
Details

docs/getconsolefontsize.md
:warning:Warning
View
Details

docs/setconsoledisplaymode.md
:warning:Warning
View
Details

docs/console-history-info.md
:warning:Warning
View
Details

docs/setconsoleactivescreenbuffer.md
:warning:Warning
View
Details

docs/low-level-console-i-o.md
:warning:Warning
View
Details

docs/getnumberofconsoleinputevents.md
:warning:Warning
View
Details

docs/getconsolescreenbufferinfo.md
:warning:Warning
View
Details

docs/readconsole.md
:warning:Warning
View
Details

docs/getconsoleoutputcp.md
:warning:Warning
View
Details

docs/input-record-str.md
:warning:Warning
View
Details

docs/getconsoleprocesslist.md
:warning:Warning
View
Details

docs/input-and-output-methods.md
:warning:Warning
View
Details

docs/ctrl-close-signal.md
:warning:Warning
View
Details

docs/high-level-console-i-o.md
:warning:Warning
View
Details

docs/low-level-console-modes.md
:warning:Warning
View
Details

docs/index.md
:warning:Warning
View
Details

docs/setconsolecursorposition.md
:warning:Warning
View
Details

docs/setconsolecursorinfo.md
:warning:Warning
View
Details

docs/high-level-console-modes.md
:warning:Warning
View
Details

docs/creation-of-a-console.md
:warning:Warning
View
Details

docs/setconsolehistoryinfo.md
:warning:Warning
View
Details

docs/low-level-console-input-functions.md
:warning:Warning
View
Details

docs/getcurrentconsolefont.md
:warning:Warning
View
Details

This comment lists only the first 25 files in the pull request.

docs/docfx.json

Line 37, Column 40: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'windows-console' is not valid with 'ms.prod' value 'console'.

docs/readconsoleoutput.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getconsolefontsize.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/setconsoledisplaymode.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/console-history-info.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/setconsoleactivescreenbuffer.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/low-level-console-i-o.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getnumberofconsoleinputevents.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getconsolescreenbufferinfo.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/readconsole.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getconsoleoutputcp.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/input-record-str.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/getconsoleprocesslist.md

Line 2, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 2, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


bin/dev does not work as intended after upgrading to @oclif/core to V3

Describe the bug
After upgrading @oclif/core to V3, running bin/dev <command> does not work as intended and requires a build for changes to take effect. It now behaves similarly to bin/run.
To Reproduce
Steps to reproduce the behavior:

Make changes to a command (console.log('anything') will do) without build
Run using bin/dev
See the changes won't take effect unless rebuilt

Expected behavior
Should behave as bin/dev and not be similar to bin/run
Screenshots
N/A
Environment (please complete the following information):

MacOS Ventura (ARM64)
Node Version: v18.15.0
Yarn Version: 3.6.3

Additional context

bin/dev works fine on my previous version "@oclif/core": "^2.15.0",
I am using Yarn PnP

@wataruian I'm not seeing this happen on a newly generated CLI (either from the CJS template or the ESM template)
Can you create a simple repository that replicates the issue? It'd also be helpful if you provided the logs from setting the DEBUG=config:ts-node environment variable. That should tell us why it's skipping the compilation step. Thanks!

@wataruian Thanks - feel free to reopen the issue if you trace it down to something in oclif


Expand contribution docs.

Change Summary
This names the dev dependencies explicitly in the contribution docs. They aren't being added to requirements.txt because it can't distinguish between dependencies and dev dependencies.
Related issue number
None, trivial
Checklist

[X] Unit tests for the changes exist (N/A)
[X] Tests pass on CI and coverage remains at 100%
[X] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

(it wasn't at 100% coverage when I got here, but this is a markdown change so it hasn't gotten any worse)

please review :)

Just found make install, which installs development requirements. Will update this PR in a moment.

Sorry, apparently I completely missed step 4.


Collect which SCM tool is used

Wasn't implemented as part of #76, but would be good to collect. Some MLEM usage scenarios can happen outside of the repo, so it would be good to understand connections between executed CLI commands and whether we use repo or not.

closing in favor of https://github.com/iterative/iterative-telemetry/issues/16


NAS-126908 / 24.10 / Add /proc/net/bonding dir to debug

Context
Change adds /proc/net/bonding dir in debug to give visibility for configured bonds. Also PR fixes default value handling of ignore_items of Directory class and adds integration test.

Jira URL: https://ixsystems.atlassian.net/browse/NAS-126908

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.


Eureka configuration stops refreshing after a failure

We have a traefik docker container connected to Eureka.
It is fetching the configuration each 30seconds and after a while it stops fetching new configurations:

Last message is:
level=error msg="Failed to refresh Provider configuration, error: 501: All the given peers are not reachable (Tried to connect to each peer twice and failed) [0]
Then it stops fetching the services from Eureka.
The issue is in the Eureka.go code:
https://github.com/containous/traefik/blob/6a92ac0b7b04ea69a995f7635c0a7fb81fdfc952/provider/eureka/eureka.go#L58
Once there is an issue, it stops the loop for checking new updates, rather then skipping that iteration and wait for the next tick.

Closed by #2838.


Joins within Eloquent query scopes not supported in nested wheres

When defining a query scope within an Eloquent model like so that utilizes a join:
public function scopePopularUsers($query)
{
    return $query->join('popular_users', 'popular_users.user_id', '=', 'users.id')
        ->where('popular_users.popularity', '>', 20);
}

You can correctly use this directly on an Eloquent model which builds the correct SQL:
echo User::popularUsers()->toSql();

select * from `users` inner join `popular_users` on `popular_users`.`user_id` = `users`.`id` where `popular_users`.`popularity` > ?

However trying to use this same query scope within a nested where gives the following:
echo User::where(function ($query) {
    return $query->popularUsers();
})->toSql();

select * from `users` where (`popular_users`.`popularity` > ?)

The join is being lost resulting in malformed SQL.
The issue being the addNestedWhereQuery method of Illuminate\Database\Query\Builder:
public function addNestedWhereQuery($query, $boolean = 'and')
{
    if (count($query->wheres)) {
        $type = 'Nested';

        $this->wheres[] = compact('type', 'query', 'boolean');

        $this->addBinding($query->getBindings(), 'where');
    }

    return $this;
}

The method only accounts for where clauses when I believe it should also be looking at joins like so:
public function addNestedWhereQuery($query, $boolean = 'and')
{
    if (count($query->wheres)) {
        $type = 'Nested';

        $this->wheres[] = compact('type', 'query', 'boolean');

        $this->addBinding($query->getBindings(), 'where');
    }

    if (count($query->joins)) {
        foreach ($query->joins as $join) {
            $this->joins[] = $join;

            $this->addBinding($join->bindings, 'join');
        }
    }

    return $this;
}

I'm wondering if this makes sense or if this usage is beyond the scope (not intended to be a pun) of the feature. If it does make sense I can submit a pull request with amended tests if that's best?
Thanks!

https://github.com/laravel/framework/pull/13194#issuecomment-211459672


Support tables without PKs and changing PKs on a row.

Current protocol assumes an unchanging identity by associating a key with each change. Since we're intent on keeping the key, we must split up an UPDATE change that affects a PK (entire row in case of PK-less tables, since entire row is the key at that point) into a DELETE + INSERT pair representing the update each with an individual key. The pair must be still tied in some way by additional metadata for a client to be able to reconstruct the update if it wants to

Closed by https://github.com/electric-sql/electric-next/pull/182 https://github.com/electric-sql/electric-next/issues/181


Investigate using /MD (dynamic CRT) for Windows embedding

Currently the Windows engine build is using /MT. Given that we're building a DLL that we expect to load into a Runner that is also using the CRT, we should probably be using /MD so they can share the runtime. My understanding is that we can avoid issues passing objects across the DLL boundary that way as well.
I'm not clear on whether this means clients need to bundle the library, or whether we can rely on it being on the end-user's system. (Even if we do need to bundle it, we already need to bundle DLLs anyway, so adding one more would be better than shipping two static copies).
If there's something I'm missing that would make this a bad idea, input welcome.
/cc @csells @clarkezone

Hi,  I am not sure if this is really a good idea.

Sharing CRT will make the program more vulnerable and the heap problem will be more serious.
Simplify the transfer of some memory object state through the shared heap, which requires all DLLs and EXEs to use the same compiler. If you link to different versions of CRT (for example: plug-in projects), you can't share the same CRT heap as well.
It will make the natural physical boundary between DLLs obscure, and the unreasonable call across the boundary that can be blocked by /MT can not be found.

Do we have enough reason to do this?

which requires all DLLs and EXEs to use the same compiler

Interesting, I thought a core idea of dynamic CRT linking was that it allowed getting CRT updates via the OS (rather than each application needing to recompile and ship a new version to get CRT updates), which seems like it would require cross-version compatibility. Could you point me to more details on this by any chance?

Do we have enough reason to do this?

Not necessarily, no. Feedback like your comment is extremely useful in evaluating this, given my lack of experience in this domain.


raw RSS link broken

raw RSS feed link on http://www.theatermania.com/rss/ is broken (links to https://www.subtome.com/#/redirect?to={feed} )

Hum, could you clarify?
When I click on any of the links on http://www.theatermania.com/rss/, I see the Subtome modal just fine, and then I can click on he "RSS feed" icon and be redirected to the actual feed as expected.

Any progress on this?

Hmm it works for me now too. Maybe it was a config issue on their end. I should have gotten a screenshot. Sorry

Maybe I have a local issue but I'm not sure how to tell. Here are some screenshots. Thanks!

Thanks! On which button do you click to get from the last but one screenshot to the last one?

The bottommost link that says "RSS Feed"

This is really strange, because when I do the same, I'm redirected to the feed's page: http://www.theatermania.com/rss.xml
I'm also using Firefox (38.0.5) and I tried from Chrome, and Safari and they all redirect me to the feed as expected...
Is there any message in the console of your browser?

I just tried to replicate again and it totally works without error now. (redirects to http://www.theatermania.com/rss.xml )
I suspect that it was a configuration error by theatermania somehow, but I'm really not sure. Anyway, I'll close the ticket. Thanks for looking into it!


acctz timeout behavior was removed; remove it from the yang model.

The YANG files are moved to the OpenConfig repo. We need to fix it https://github.com/openconfig/public/blob/master/release/models/gnsi/openconfig-gnsi-acctz.yang#L132

The YANG files are moved to the OpenConfig repo. We need to fix it https://github.com/openconfig/public/blob/master/release/models/gnsi/openconfig-gnsi-acctz.yang#L132

oops, we can move this in a new PR I believe.


Remove future flag for released feature

WHY are these changes introduced?
Closes:

https://github.com/Shopify/develop-app-runtime-primitives/issues/540

When optional scopes feature is released, we have the option to either:

Enable scopes future flag by default for new apps and communicate to apps to enable this future flag to use Scopes API OR
Remove the future flag so that apps can use Scopes API automatically.

I think removing the future flag makes more sense since we're adding new feature and not modifying existing behaviour of the library.
WHAT is this pull request doing?
Removes future flag wip_optionalScopesApi.
Top hatting
I tested by linking my app to a local version of the remix library. I can use the Scopes API without adding the future flag.
Type of change

[ ] Patch: Bug (non-breaking change which fixes an issue)
[x] Minor: New feature (non-breaking change which adds functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
[x] I have added/updated tests for this change
[x] I have documented new APIs/updated the documentation for modified APIs (for public APIs)

Just to confirm the docs for this feature is in this PR?


fix integration tests target

There was an oversight in e2e tests where we were testing the published version of this package instead of testing the repo version.

@carsonfarmer Maybe we should merge this into your v4 branch instead of main?

good call


Enable Corepack for superchain Image

Describe the feature
I would like to use yarn berry with the superchain image. This requires corepack to be enabled with corepack enable. It would be cool to have this enabled out of the box.
Use Case
Using yarn berry
Proposed Solution
No response
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

CDK version used
2.159.1
Environment details (OS name and version, etc.)
Linux

Is this a one line change to superchain? Please feel free to try to contribute this one yourself!


Autofill support

We should make sure our text fields trigger the autofill support:
https://developer.android.com/guide/topics/text/autofill.html

Doesn't this framework work whenever an input is recognized natively as an input?
Why wouldn't they via flutter?

fwiw, I have the following form:
          Form(
              child: Column(
                children: <Widget>[
                  TextFormField(
                    keyboardType: TextInputType.emailAddress,
                    decoration: new InputDecoration(
                      hintText: "Email",
                      labelText: "Email"
                    ),
                  ),
                  TextFormField(
                    obscureText: true,
                    decoration: new InputDecoration(
                      labelText: "Password"
                    ),
                  )
                ],
              )
            ),

And 1Password doesn't seem to be triggering.

The Android auto-fill framework wasn't added until SDK 26, so I doubt we support it currently since Flutter's target SDK is still 22

We will definitely have to support it.
Anyway, we definitely don't support it currently - but we absolutely can. I am updating our android sdk version this week, which will enable the use of this API on newer devices

Similarly we should ensure that we support the same for the password field changes in iOS 11 (may already work?) and the upcoming changes in iOS 12.

Investigated updating the android sdk and buildroot this week, found that it's not really feasible unless we are willing to invest time into refactoring buildroot.  see https://github.com/flutter/flutter/issues/17780 for more details - this is blocking implementing autofill

Might be a dupe of https://github.com/flutter/flutter/issues/14047

Any news about this?

Any new progress? 🧐

Any updates?

Ok, so I have confirmation from @dnfield  that we should now be unblocked. What's the current status on this ticket? What needs to be done? Can I help?

https://developer.android.com/guide/topics/text/autofill-optimize#virtual needs to be implemented in the Android TextInputPlugin.

Or perhaps https://developer.android.com/guide/topics/text/autofill-optimize#callback

Well, I am pleased to see that lastpass is at least able to acknowledge the presence of email/password fields and prompts to autofill. Unfortunately that's where the good new stops, because it can't seem to actually perform the autofill action :(

Any news on this??

Any news on this?

Any news on this?

Any news on this?

Would love an update on this. Right now the login procedure is the main thing that makes my app feel non-native.

Hi guys,
Tired of waiting so I've created a flutter plugin:
https://pub.dev/packages/flutter_autofill
Usage is simple, just wrap Autofill widget around your Textfield as follows:
         Autofill(                 onAutofilled: (val) {                    // set value in controller & cursor position after auto-filled value                   _emailController.value = TextEditingValue(text: val, selection: TextSelection.fromPosition(TextPosition(offset: val.length)));                 },                 autofillHints: [FlutterAutofill.AUTOFILL_HINT_EMAIL_ADDRESS],                 autofillType: FlutterAutofill.AUTOFILL_TYPE_TEXT,                 textController: _emailController,                 child: TextField(                   controller: _emailController,                   decoration: InputDecoration(hintText: "Please enter your email"),                 ),               ),
Works using Android autofill virtual structure support
Would appreciate comments/improvements!

hi guys, cant find how to connect google chrome and safari autofill saved passwords and login to flutter app, who has any idea ?

Hi guys,
Tired of waiting so I've created a flutter plugin:
https://pub.dev/packages/flutter_autofill
Usage is simple, just wrap Autofill widget around your Textfield as follows:
          Autofill(
                onAutofilled: (val) {
                   // set value in controller & cursor position after auto-filled value
                  _emailController.value = TextEditingValue(text: val, selection: TextSelection.fromPosition(TextPosition(offset: val.length)));
                },
                autofillHints: [FlutterAutofill.AUTOFILL_HINT_EMAIL_ADDRESS],
                autofillType: FlutterAutofill.AUTOFILL_TYPE_TEXT,
                textController: _emailController,
                child: TextField(
                  controller: _emailController,
                  decoration: InputDecoration(hintText: "Please enter your email"),
                ),
              ),

Works using Android autofill virtual structure support
Would appreciate comments/improvements!

This is great, but a major issue is that there's no autofill option when long-pressing a text field. This needs to be built-in to Flutter.

I added the cujpertino and material labels because I assume that developers will expect integration of autofill with the TextField's text selection menu (per https://github.com/flutter/flutter/issues/13015#issuecomment-536173301)

Any news on this on flutter side?

was anyone able to successfully integrate the solution from @saharh? I have a few issues, I put the same code as in the sample but unable to save or restore the email/password

@genert was asking about helping out with the effort to get Autofill working.  It's going to be a decently large amount of work to do this right.  Here's the work that I see needing to be done for this:

Agree on a proposed solution

Understand how autofill works natively on Android and iOS now.
Come up with an engine API that ideally covers both in a generic way.
Come up with an API for TextField and CupetinoTextField that ties into the engine.
Make sure that this solution would also work for non-text fields like CupertinoDatePicker, etc., if related.
Make sure that a Flutter dev could tie into this API with their own custom form widgets as well.

Implement the engine API.
Tie the engine API into TextField/TextFormField/CupertinoTextField.
Tie the engine API into other form widgets like CupertinoTextField.

Right now I think we need to start out by doing some research and agreeing on a potential solution to this.

As an implement with engine https://github.com/flutter/engine/pull/13878 , does it finished the engine side?

Looks like that could be what we need for iOS in the engine.  I just gave a quick review.

Hi, any updates to this??

This feature has 165 👍 + 7 ❤, isn't that enough for flutter team to take a look? 😢

We're working on it and hope to release something in the first quarter of 2020.

@giaur500 The logic to flow from the dart layer to the flutter engine is roughly in place. Because these are not native android input views, we're having to rely on the lower level frameworks. The guidance I'm needing is more on the modifications needed to flutter engine itself. @LongCatIsLooong could already be working on the engine side for this.

@Hixie @LongCatIsLooong I added the web label as this is also important on the web and requires engine-side work. Also, would it be possible to move this to the near-term goals milestone? Users really really want this.

From the comments I feel like smart lock is out of scope.  https://developer.android.com/distribute/best-practices/develop/smart-lock-for-passwords

+1

Any idea when this might be scheduled for?

This would be great to have. Saves the user from typing over and over again!

This should be working on the master branch now. Please open new issues for feature requests / bug reports!
Known issues:

https://github.com/flutter/flutter/issues/41508: on iOS we don't currently support UIKeyboardType.namePhonePad keyboard type, which seems to be a requirement for triggering name/telephone/address autofill on iOS.
AutofillHint newPassword mapping is currently missing in the iOS text input plugin.

Upcoming features:

Allow the system autofill service to save user input: https://github.com/flutter/flutter/issues/55613
Add more platform-specific autofill flags, for example passwordRules on iOS.

I have this issu also on the web version... any idea how to fix?

as far as I can see, the latest master channel already implements this for flutter web, I can see the autocomplete attributes being set, but apparently the input text fields are generated on the fly, so chrome continues to offer only saving for the password input field, anyone else who can reproduce this?

@Freundschaft Thanks for the question. We are working on that part, there needs to be changes on the framework, later we will merge the Flutter Web changes. The tracking issue: https://github.com/flutter/flutter/issues/55613

Chrome has offered to save and autofill my password on a website I built with Flutter Web. I believe I was on the master channel when I compiled it.

chrome continues to offer only saving for the password input field

Yes, I have the same issue, Chrome only offers to save and fill the password but not the username.

@Levi-Lesches yes we didn't merge the "save" solution yet. Since some fields handled different by the browsers you can see the save popups for some fields.

@nturgut Is the "save" solution merged? Is it tracked using this issue or there is some other issue?

Wondering if anyone else has this autofill problem.
On iOS, when I have multiple text fields on a screen with different autofill hints, tapping between the text fields does not update the autofill correctly. Sometimes the autofill just doesn't show up. Sometimes the time the first autofill item just stays and never switches. Sometimes when I leave the app and come back, all the autofills have change to "Passwords" with the key icon.

Might be related to https://github.com/flutter/flutter/issues/59374

Wondering if anyone else has this autofill problem.
On iOS, when I have multiple text fields on a screen with different autofill hints, tapping between the text fields does not update the autofill correctly. Sometimes the autofill just doesn't show up. Sometimes the first autofill item just stays and never switches. Sometimes when I leave the app and come back, all the autofills have change to "Passwords" with the key icon.

Might be related to #59374

Yep, same here.

@nturgut Is the "save" solution merged? Is it tracked using this issue or there is some other issue?

Save solution is merged. Sorry I just saw this cc.

@jacob-hutchings @stx thanks for reporting this issue! What's your flutter version? From the screenshot it seems it happens on non-password fields right? For those fields I think we reuse the same ios view and I've never had this issue, but it's possible ios autofill caches the content type internally. Could you provide a minimal repro for investigation?

@jacob-hutchings @stx thanks for reporting this issue! What's your flutter version? From the screenshot it seems it happens on non-password fields right? For those fields I think we reuse the same ios view and I've never had this issue, but it's possible ios autofill caches the content type internally. Could you provide a minimal repro for investigation?

Thank you for looking at this @LongCatIsLooong !
Here is my Flutter version info:
Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.4 19E287, locale en-US)
I tested the following code on my physical iPhone 8 and also the iOS simulator iPhone SE (2nd Gen). Autofill straight up never works with the following code for me:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Autofill repro',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  TextEditingController _firstNameController = TextEditingController();
  TextEditingController _lastNameController = TextEditingController();
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Autofill repro'),
      ),
      body: Padding(
        padding: const EdgeInsets.all(18.0),
        child: Column(
          children: <Widget>[
            TextField(
              controller: _firstNameController,
              decoration: InputDecoration(
                hintText: 'Given Name',
              ),
              autofillHints: [AutofillHints.givenName],
            ),
            TextField(
              controller: _lastNameController,
              decoration: InputDecoration(
                hintText: 'Family Name',
              ),
              autofillHints: [AutofillHints.familyName],
            ),
          ],
        ),
      ),
    );
  }
}

I repeatedly tested this, rebuilding, force quitting and launching, and it never showed.
After adding autocorrect: False, to the text fields and testing a bunch more times:

I could sometimes get autofill to show but not very often.
If I type in some text and backspace it all the way, autofill shows up pretty regularly, however, after it shows up, switching between the text fields does not update the autofill:

After testing tens of times I finally got it to update one time, but I'm not sure how I got it to work.
The behavior is very inconsistent.
Please let me know if there is additional info you need.

My login form is defined as follows:
Form buildLoginForm() {
    final citiesListControl = buildCitiesSelector();

    final email = TextFormField(
      enabled: _isCitySelected,
      keyboardType: TextInputType.emailAddress,
      key: Key('email'),
      autofocus: false,
      initialValue: '',
      decoration: InputDecoration(
        hintText: 'E-mail',
        contentPadding: EdgeInsets.fromLTRB(20.0, 10.0, 20.0, 10.0),
        border: OutlineInputBorder(borderRadius: BorderRadius.circular(32.0)),
        focusedBorder: OutlineInputBorder(
          borderSide: const BorderSide(color: Colors.black26, width: 2.0),
          borderRadius: BorderRadius.circular(32.0),
        ),
      ),
      onSaved: (value) => _email = value,
      validator: (val) => !EmailValidator.Validate(val, true)
          ? Strings.msg_email_invalid
          : null,
        autofillHints: [AutofillHints.email]
    );

    final password = TextFormField(
      enabled: _isCitySelected,
      key: Key('password'),
      autofocus: false,
      initialValue: '',
      obscureText: true,
      decoration: InputDecoration(
        hintText: Strings.password_hint,
        contentPadding: EdgeInsets.fromLTRB(20.0, 10.0, 20.0, 10.0),
        border: OutlineInputBorder(borderRadius: BorderRadius.circular(32.0)),
        focusedBorder: OutlineInputBorder(
          borderSide: const BorderSide(color: Colors.black26, width: 2.0),
          borderRadius: BorderRadius.circular(32.0),
        ),
      ),
      onSaved: (value) => _password = value,
      validator: (val) =>
          val.length < 4 ? Strings.msg_password_too_short : null,
        autofillHints: [AutofillHints.password]
    );

    final loginButton = Padding(
      padding: EdgeInsets.symmetric(vertical: 2.0),
      child: RaisedButton(
        shape: RoundedRectangleBorder(
          borderRadius: BorderRadius.circular(24.0),
        ),
        onPressed: _isCitySelected
            ? () {
                if (_loginFormKey.currentState.validate()) {
                  _loginFormKey.currentState.save();
                  _loginEmailPassword();
                }
              }
            : null,
        padding: EdgeInsets.all(12.0),
        color: Colors.lightBlueAccent,
        child: Text(Strings.btn_login, style: TextStyle(color: Colors.white)),
      ),
    );

    final guestLoginButton = Padding(
      padding: EdgeInsets.symmetric(vertical: 0.0),
      child: RaisedButton(
        shape: RoundedRectangleBorder(
          borderRadius: BorderRadius.circular(24.0),
        ),
        onPressed: _isCitySelected
            ? () {
                _loginFormKey.currentState.save();
                _loginGuest();
              }
            : null,
        padding: EdgeInsets.all(12.0),
        color: Colors.green,
        child: Text(Strings.btn_login_guest,
            style: TextStyle(color: Colors.white)),
      ),
    );

    final statusLabel = Padding(
        padding: EdgeInsets.symmetric(vertical: 16.0),
        child: Text(_status ?? "", style: TextStyle(color: Colors.red)));

    return Form(
      key: this._loginFormKey,
      child: Scaffold(
        backgroundColor: Colors.white,
        body: Center(
          child: ListView(
            shrinkWrap: true,
            padding: EdgeInsets.only(left: 24.0, right: 24.0),
            children: <Widget>[
              citiesListControl,
              SizedBox(height: 32.0),
              email,
              SizedBox(height: 8.0),
              password,
              SizedBox(height: 24.0),
              loginButton,
              guestLoginButton,
              statusLabel
            ],
          ),
        ),
      ),
    );
  }

On Android, I am never getting any autofill. Is that anything wrong in my code? Issue is closed, so I guess functionality is finished, so what's wrong?

Every post I saw about Autofill they wrap the Widget were the TextInputFields in with an AutofillGroup. I does it the same way and it works fine.
So maybe that would solve the problems.
Also for iOS you need to define an Runner.entitlements file with associated domains and webcredentials to be able to use them.

Wrapping with AutofillGroup seems to do the magic. Also, in order to be able to see "save data" pop-up I had to use Form and save it on submit / successful login.
Tested on Android with autofill services:

Google - save data worked, update password didn't worked.
Samsung Pass - none worked.

Have you managed to make it working with other password managers?

Wrapping with AutofillGroup seems to do the magic. Also, in order to be able to see "save data" pop-up I had to use Form and save it on submit / successful login.
Tested on Android with autofill services:

Google - save data worked, update password didn't worked.
Samsung Pass - none worked.

Have you managed to make it working with other password managers?

Ref this issue https://github.com/flutter/flutter/issues/55613#event-3635992635.
This feature not release stable channel.

I tried to wrap Form or ListView with AutofillGroup but still no autofill shown.

Hello, it works !!! Wrap the fields with AutoFillGroup and add to each field your autoFillHint is magic in web. The autocomplete with email and password started to work. Thanks

H

could you please share some piece of that logic?

AutofillGroup is the magic


Slower updates?

I have sometimes forgot to close trackmania and so i run in error messages with to many requests. Is it possible to slow down the Update process?

Yes, I have a new version mostly ready, this should be possible


A request

Hi!
Could you please remove the asset repo you forked? and then delete this issue, thanks.

Done

Just to make sure, you deleted it, not just privated it, I don't want my GitHub user to stay as the author of the commits.

Also did you download the server package from the Ruffle issue report, if so I would like you to delete that, I don't want it out there anymore.

What happened bro? Like you are being threatened or something?!
Also, yes I made it private but I will never use it anywhere, just keeping them for memories.
And I don't know anything about the server package.

Could you delete it and fork this instead? https://github.com/glennhenry/tlsdz-assets

What happened bro? Like you are being threatened or something?!

I am not being threatened, I just don't want this stuff to exist anymore sorry.

And I don't know anything about the server package.

Well you commented on ruffle issue 13992, (I don't want to link it here)

Done

Thanks, and you have no local copies, correct? And no server code I had hosted previously, I don't want it out there.

No local copies, no forks and no server code.

Could you now delete this issue, please? Cannot do that myself.


New article - Docs-as-code in action: Building and documenting a Python library.

Article title: Docs-as-code in action: Building and documenting a Python library.
Category: Technical Documentation.
Overview
This article is a comprehensive guide on how to build a python library and publish a documentation for it. The Objective of the article is to show readers the importance of docs-as-code, and how to implement it in a documentation workflow.
By showing how to build a documentation for a Python library, and maintain both code and documentation versions synchronously,  readers can understand the practical implementation of docs-as-code in their workflow.
The article uses Mintlify to build and host the documentation.
Outline
The article has been completed but not published anywhere. It can be found here.

Hello Omotunde,
I will review it and get back to you.
Thanks for writing this peice

Okay, thank you sir.

Hello @wise4rmgod .
I've corrected the highlighted errors. The article has also been split into two as suggested. Below are the links to the articles:
How to build and publish a Python library
Documenting a Python library


Microsoft Teams possible error messages

I would love to help people in this forum through this spreadsheet. You can see some of the most common errors that occur with Microsoft teams here: https://devicebase.net/en/microsoft-teams/questions/what-are-all-the-possible-mistakes-when-signing-up-for-teams/3w5

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41ddf8ce-fda9-ee9d-d96a-801f9a2f66b7
Version Independent ID: 9aa5a49f-c440-95a8-83a1-9d38bdaeda39
Content: Known issues for Microsoft Teams - Microsoft Teams
Content Source: Teams/Known-issues.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@djuricin00 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


[VC] Revise README.md

Based on the discussions in CAPN meeting and the feedbacks from community users, the README.md is revised to add more detailed explanations about VC project.

@christopherhein Thanks a lot for your careful review. All comments have been addressed in the latest commit.

/lgtm
/approve


Create a Footer for the website

Hey @bruno-keiko The website will look better if it has a footer ,it will give a complete design of the website making it more impactful. can you assign me this issue to work on.

Could you please wait until our design is ready?


feat: Debugging panel with integrated diagnostics data

Description
closes #2517
Changes

Implement the Debug Panel's basic container
Implement the new 'Issues' tab, migrate diagnostics page to the bottom of Design Page
Unify the icons of diagnostics 'Error' and 'Warning'
Implement debug panel extension mechanism

Todos - next PR @lei9444

Shell:

Apply Debug Panel accross Composer (will be appeared under all other pages)

Diagnostics:

Can set filters - filter by severity, by skill id... Figma
Implement V2 design

Todos - UX details

@alanlong9278 if the error happens in an Action, double clicking the error should scroll the Action into view

Task Item

Screenshots

Coverage decreased (-0.05%) to 55.001% when pulling c5ac7a16a12eb74b562243351800f7f146245d79 on zeye/debug-pane into 8cde5d7cb7b1edf5c06596092ce3f786c84e21e1 on main.


OpenLane flow get stuck at yosys part "Continuing TECHMAP pass"

Hi
I was trying to run my verilog code which is about 2k rows through OpenLane in order to get a gds file.
(Im using ubuntu 18.04 via virtualBox.) When i run the command :  "/.flow.tcl -design top_level" the flow stucks at ,exact same step, "Continuing TECHMAP pass" on every try and the virtual machine does not responds in anyway. Screenshot of log file is attached below.
(I was able to get a gds file when i ran flow for some modules seperately. Then i put together these modules in a .v file which is compiled and tested).

@ufukyill
check how much used for yosys running

After posting i have already increase the RAM of virtual machine and it kept continue. But now i having this error at "Continuing TECHMAP pass" step :

The issue template is mandatory.


Resolved comments for PR #71

Some of the comments in [PR #71 ] have been incorporated.

@abhijeetbhagat Hello Abhijeet. We tried to follow your suggestion from last PR. Might be useful?


Build to Upgrade bleach to 3.3.0 is failing due to django-incident-response 0.5.1 depends on bleach 3.1.4

Describe the bug
Build failed due to "django-incident-response 0.5.1 depends on bleach 3.1.4"
The latest version of bleach is 4.1.0
Snyk detects a vulnerability issue on bleach - Cross-site Scripting(XSS)
However, the heroku build/deploy is failing because django-incident-response 0.5.1  is not accepting the latest version of bleach (3.3.0 or 4.1.0)
My Platform
Heroku deployment
Django 2.2.26
Additional context
https://pypi.org/project/django-incident-response/
https://pypi.org/search/?q=bleach

Hi, this issue tracker is for issues with the codebase behind https://pypi.org itself, not the projects hosted on PyPI.
You should report this issue to the tracker for the project in question instead.


Add an input filed to specify a WebSocket protocol.

According to WebSockets API specification it is possible to specify
a protocol (an arbitrary string, which does matter only for
particular (custom) server) to WebSocket ctor.
This patch adds an input field for the protocol...

Thanks for the PR. I’ll try to get a new release out in the next couple of days.

@zaufi Should I add an option to save one or more protocol strings to storage similar to the way URLs are managed? Since I don’t use this functionality, I don’t know if that would be helpful or not.

Yep, it'll be helpful for sure
On Fri, Sep 28, 2018 at 8:10 PM Ken Siprell<EMAIL_ADDRESS>wrote:

@zaufi https://github.com/zaufi Should I add an option to save one or
more protocol strings to storage similar to the way URLs are managed? Since
I don’t use this functionality, I don’t know if that would be helpful or
not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kensiprell/browser-websocket-client/pull/3#issuecomment-425503795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhfazfqR3EiHz7hscOEUDfoGVUo1H7iks5uflgMgaJpZM4W9cin
.

@zaufi I've finally published a new version. It should be available in the Chrome and Firefox stores in the next hour. It took me longer than expected because I made several improvements. Please give the new version a test drive and let me know if you have any questions or suggestions.

Many thanks for the plugin and your fixes :)


[v1.14] iptables: Do not install NOTRACK rules if IPv4NativeRoutingCIDR is nil

In case IPv4NativeRoutingCIDR is left unspecified, the related config option will be nil. To avoid panicking, check for this case before converting the CIDR to a string. Moreover, do not try to run the iptables command to install the NOTRACK rules if the resulting string is empty.
Related: #32607

/test-backport-1.14

/test-backport-1.14


An error has occurred. Please save your data in any software currently in use, and then restart the system

I am getting the message "An error has occurred. Please save your data in any software currently in use, and then restart the system" Everytime I click on the slider bar.  I have cleared the internet stuff a dozen times, clicked multiple spots on the slider bar.. Seems no matter what I do, I always get that error.
I am on 9.2.0-20U
After I click the slider bar the bottom screen goes yellow and then grey.  Then it takes me home and gives me the above error.  Any help would be appreciated.

Sliderhax is unreliable. The issues section is not for troubleshooting steps.

Then why is that a step in your guide?  Where would I go for troubleshooting then?

It's unreliable, meaning you have to try a ton to use it. Check the footer on every page and the FAQ for support.


entgql: possibility to attach custom directives to mutation create and update inputs

I want to attach a custom directive to a generated mutation create/update field.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
Through the mutations in a field definition in a schema i want to be able to do something like entgql.UpdateMutation.Directive('directive name', {args}) to be able to attach the given directive to it. (using the same syntax as the current way to add directives to the gql type would be preffered)
Motivation 🔦
Right now i can create a custom directive for checking the minimum length of a string(for example). but this directive is executed whenever i get a object from the database and not when i insert one through a create/update input.
This leads to me being unable to attach directives to places i want them on. manually this would be possible but we generate our create and update inputs through the mutations and want to attach them in the schema/field definitions.

See the merge request above for the fix i wanted.
In there i also added a question about adding the skipping of adding directives to certain types/field/mutations.

Hey, @lucvankessel 👋
Would you mind putting here an example of the mutation inputs you want to generate with entgql? input directives or field-level directives?
Just to make sure you're not blocked on this, check out my SchemaHook example on: https://github.com/ent/ent/issues/3173#issuecomment-1359338499

hey @a8m,
This is a simple example of what i want:
input CreateProjectInput {
  name: String! @CustomDirective("some arg")
}

This input is then generated from the mutations in the schema.
I can generate the inputs without the directive.
This MR does what i want it to do.
In the future it might also be nice to have the ability to skip these directives on either the type, create or update inputs.

Hey @a8m,
Can i help you guys in any way to fast track the progress on this issue?

Made this [MR]{https://github.com/ent/contrib/pull/543} a few days ago with a proposed backwards compatible solution. let me know what you think and if it needs changing etc.


Pager issue 'totalItems' since it isn't a known property

Hi Guys,
I'm using pager in the same way as pagination, but doesn't work as pagination, I'm receiving the following error:
Can't bind to 'totalItems' since it isn't a known property of 'pager'
I've reviewed and I can't find that property in pager.component

Pager extents Pagination and Pagination has public setter and getter methods for totalItems.
The pager component works for me. Please have a look at: https://valor-software.com/ng2-bootstrap/#/pagination
If you still have problems: Please show us your HTML template, the related component and your ngModel definition.


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Gladson Sethiel

Discord Username(if exists):

Additional Context:

:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


x-if, x-for and mountable components

Kind of a big change, mostly messing around for now
Still debating on whether to have dynamic reactivity (that introduced by x-if and x-for). Mountable components are a feature which can replace those, in favour of making the user append and move around elements by themselves (I kind of prefer this, since there's no VDOM, having directives which manipulate elements is kind of off, but alpine and petite-vue do it anyway)

nvm i cooked smth else


Add GRUB network boot support

Add an endpoint /grub which serves GRUB2 configs to CoreOS alpha GRUB for TPM measurement.

Initial support added in #91. Track templating improvements #92 and grub.efi build documentation #98 separately.


Update aws-secrets-manager-component.adoc

Description

Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Can you do the same for 4.8.x too? Thanks Lukas.


win-9 & win-15 are dead.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
win-9 & win-15 are dead.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Network adapter was disabled on both machines, rebooting machine to restart network service.


[FLINK-8989] [e2eTests] Elasticsearch1 end to end test

What is the purpose of the change
This is the first commit for elasticsearch1 end to end test, and fails will have an attempt, recovers, and completes in the second attempt.
Brief change log

Add an elasticsearch1 end to end example job
Add a script to start flink cluster, run the job
Register the script in the nightly test jobs

Verifying this change
This patch adds a first test for elasticsearch1.

This commit only support ElasticSearch 1.x. Will have 2.x, 5.x later.

One other thing:
This end-to-end test isn't self-contained, is it?
Being self-contained, it should:

Download an Elasticsearch distribution
Sets up an Elasticsearch cluster
Test against that cluster

We need all e2e tests to be self contained because they will be automatically executed pre-commit / on nightly runs.

Yes. It should be downloaded Elasticsearch distributions for 1.x, 2.x, 5.x. And then set up its cluster for it. I will add that scripts later commits.

Hi, @tzulitai I would like to move some of them to flink-end-to-end-tests.  And create a module for elasticsearch e2e test. What do you think ?

Hi, @tzulitai, I updated the code based on your suggestions, Could you have another look?

I found an issue, I tried find it out but it seems useless.
For elasticsearch5sink, I can run directly with the following command with flink cluster setup and elasticsearch5 cluster set up also  without error. [Flink cluster and ES cluster setup by manually.]
$FLINK_DIR/bin/flink run -p 1 projects/flink/flink-end-to-end-tests/flink-elasticsearch5-test/target/Elasticsearch5SinkExample.jar --index index --type type

But when I change it to bash scripts to set up flink cluster and es5 cluster. Although it can be written   to elasticsearch5 without error[we can see Elasticsearch end to end test pass in the following message]. In the end, it will throw an exception.
/Users/zhangminglei/projects/flink/flink-end-to-end-tests/test-scripts/../flink-elasticsearch5-test/target/Elasticsearch5SinkExample.jar
Starting execution of program
Program execution finished
Job with JobID 2774e793a167a6bfba07031948fb5b14 has finished.
Job Runtime: 6564 ms
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4189  100  4189    0     0  19737      0 --:--:-- --:--:-- --:--:-- 19759
Elasticsearch end to end test pass.
Stopping taskexecutor daemon (pid: 86784) on host zhangmingleideMacBook-Pro.local.
Stopping standalonesession daemon (pid: 86475) on host zhangmingleideMacBook-Pro.local.
Found non-empty .out files:
Exception in thread "Thread-6" java.lang.NoClassDefFoundError: org/apache/flink/streaming/connectors/elasticsearch5/shaded/org/jboss/netty/channel/socket/nio/NioWorker$RegisterTask
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioWorker.createRegisterTask(NioWorker.java:118)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.AbstractNioSelector.register(AbstractNioSelector.java:104)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioWorker.register(NioWorker.java:36)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:157)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
	at org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders$ChildFirstClassLoader.loadClass(FlinkUserCodeClassLoaders.java:120)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 13 more
One or more tests FAILED.

I think I found how to solve this issue. I will fix it as soon as possible.

I think I found how to solve this issue. I will fix it as soon as possible.

I think I found how to solve this issue. I will fix it as soon as possible.

Hi, @tzulitai What is the state of this PR ? thanks. This PR is ready to have another review.

Hi, @tzulitai Could you take another look on this PR ? It's the time for having another review. Update the code according to your suggestions and I ran the test on my local machine and below are the tests results. Looks good from these results. Thank you very much.
Flink dist directory: /Users/zhangminglei/projects/flink/build-target
TEST_DATA_DIR: /Users/zhangminglei/projects/flink/flink-end-to-end-tests/test-scripts/temp-test-directory-20N
Downloading Elasticsearch1 from https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.7.1.tar.gz

> Elasticsearch node is running.

Starting cluster.
Starting standalonesession daemon on host zhangmingleideMacBook-Pro.local.
Starting taskexecutor daemon on host zhangmingleideMacBook-Pro.local.
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Dispatcher REST endpoint is up.
Starting execution of program
Program execution finished
Job with JobID dbd0dcbf09127ca1715da4bb3f4ca7fa has finished.
Job Runtime: 1791 ms

> Elasticsearch end to end test pass.

Stopping taskexecutor daemon (pid: 64950) on host zhangmingleideMacBook-Pro.local.
Stopping standalonesession daemon (pid: 64658) on host zhangmingleideMacBook-Pro.local.
No zookeeper daemon to stop on host zhangmingleideMacBook-Pro.local.
All tests PASS
Downloading Elasticsearch2 from https://download.elastic.co/elasticsearch/release/org/elasticsearch/distribution/tar/elasticsearch/2.3.5/elasticsearch-2.3.5.tar.gz

> Elasticsearch node is running.

Starting cluster.
Starting standalonesession daemon on host zhangmingleideMacBook-Pro.local.
[2018-05-22 09:16:16,773][INFO ][node                     ] [Orb] version[2.3.5], pid[66176], build[90f439f/2016-07-27T10:36:52Z]
[2018-05-22 09:16:16,773][INFO ][node                     ] [Orb] initializing ...
Starting taskexecutor daemon on host zhangmingleideMacBook-Pro.local.
Waiting for dispatcher REST endpoint to come up...
[2018-05-22 09:16:17,502][INFO ][plugins                  ] [Orb] modules [reindex, lang-expression, lang-groovy], plugins [], sites []
[2018-05-22 09:16:17,533][INFO ][env                      ] [Orb] using [1] data paths, mounts [[/ (/dev/disk1)]], net usable_space [287.8gb], net total_space [464.6gb], spins? [unknown], types [hfs]
[2018-05-22 09:16:17,533][INFO ][env                      ] [Orb] heap size [989.8mb], compressed ordinary object pointers [true]
[2018-05-22 09:16:17,534][WARN ][env                      ] [Orb] max file descriptors [10240] for elasticsearch process likely too low, consider increasing to at least [65536]
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
[2018-05-22 09:16:19,858][INFO ][node                     ] [Orb] initialized
[2018-05-22 09:16:19,858][INFO ][node                     ] [Orb] starting ...
[2018-05-22 09:16:19,963][INFO ][transport                ] [Orb] publish_address {<IP_ADDRESS>:9300}, bound_addresses {[fe80::1]:9300}, {[::1]:9300}, {<IP_ADDRESS>:9300}
[2018-05-22 09:16:19,967][INFO ][discovery                ] [Orb] elasticsearch/VmnVQsJKSDKtkXpxZY11Tg
Waiting for dispatcher REST endpoint to come up...
Dispatcher REST endpoint is up.
Starting execution of program
[2018-05-22 09:16:23,008][INFO ][cluster.service          ] [Orb] new_master {Orb}{VmnVQsJKSDKtkXpxZY11Tg}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}, reason: zen-disco-join(elected_as_master, [0] joins received)
[2018-05-22 09:16:23,023][INFO ][http                     ] [Orb] publish_address {<IP_ADDRESS>:9200}, bound_addresses {[fe80::1]:9200}, {[::1]:9200}, {<IP_ADDRESS>:9200}
[2018-05-22 09:16:23,023][INFO ][node                     ] [Orb] started
[2018-05-22 09:16:23,047][INFO ][gateway                  ] [Orb] recovered [0] indices into cluster_state
[2018-05-22 09:16:24,579][INFO ][cluster.metadata         ] [Orb] [index] creating index, cause [auto(bulk api)], templates [], shards [5]/[1], mappings [type]
[2018-05-22 09:16:24,921][INFO ][cluster.routing.allocation] [Orb] Cluster health status changed from [RED] to [YELLOW] (reason: [shards started [[index][4]] ...]).
[2018-05-22 09:16:24,940][INFO ][cluster.metadata         ] [Orb] [index] update_mapping [type]
Program execution finished
Job with JobID ac42b71aeb6138100d9357b72bcf94f5 has finished.
Job Runtime: 1726 ms

> Elasticsearch end to end test pass.

[2018-05-22 09:16:26,552][INFO ][node                     ] [Orb] stopping ...
[2018-05-22 09:16:26,637][INFO ][node                     ] [Orb] stopped
[2018-05-22 09:16:26,637][INFO ][node                     ] [Orb] closing ...
[2018-05-22 09:16:26,643][INFO ][node                     ] [Orb] closed
Stopping taskexecutor daemon (pid: 66886) on host zhangmingleideMacBook-Pro.local.
Stopping standalonesession daemon (pid: 66594) on host zhangmingleideMacBook-Pro.local.
No zookeeper daemon to stop on host zhangmingleideMacBook-Pro.local.
All tests PASS
Downloading Elasticsearch5 from https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-5.1.2.tar.gz

> Elasticsearch node is running.

Starting cluster.
Starting standalonesession daemon on host zhangmingleideMacBook-Pro.local.
Starting taskexecutor daemon on host zhangmingleideMacBook-Pro.local.
Waiting for dispatcher REST endpoint to come up...
[2018-05-22T09:19:01,590][INFO ][o.e.n.Node               ] [] initializing ...
[2018-05-22T09:19:01,702][INFO ][o.e.e.NodeEnvironment    ] [1m3UnQf] using [1] data paths, mounts [[/ (/dev/disk1)]], net usable_space [287.8gb], net total_space [464.6gb], spins? [unknown], types [hfs]
[2018-05-22T09:19:01,702][INFO ][o.e.e.NodeEnvironment    ] [1m3UnQf] heap size [1.9gb], compressed ordinary object pointers [true]
[2018-05-22T09:19:01,704][INFO ][o.e.n.Node               ] node name [1m3UnQf] derived from node ID [1m3UnQfqRESzEuHGmXtWXw]; set [node.name] to override
[2018-05-22T09:19:01,708][INFO ][o.e.n.Node               ] version[5.1.2], pid[68158], build[c8c4c16/2017-01-11T20:18:39.146Z], OS[Mac OS X/10.12.3/x86_64], JVM[Oracle Corporation/Java HotSpot(TM) 64-Bit Server VM/1.8.0_161/25.161-b12]
Waiting for dispatcher REST endpoint to come up...
[2018-05-22T09:19:03,051][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [aggs-matrix-stats]
[2018-05-22T09:19:03,051][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [ingest-common]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [lang-expression]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [lang-groovy]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [lang-mustache]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [lang-painless]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [percolator]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [reindex]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [transport-netty3]
[2018-05-22T09:19:03,052][INFO ][o.e.p.PluginsService     ] [1m3UnQf] loaded module [transport-netty4]
[2018-05-22T09:19:03,053][INFO ][o.e.p.PluginsService     ] [1m3UnQf] no plugins loaded
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
[2018-05-22T09:19:05,763][INFO ][o.e.n.Node               ] initialized
[2018-05-22T09:19:05,763][INFO ][o.e.n.Node               ] [1m3UnQf] starting ...
Dispatcher REST endpoint is up.
[2018-05-22T09:19:05,973][INFO ][o.e.t.TransportService   ] [1m3UnQf] publish_address {<IP_ADDRESS>:9300}, bound_addresses {[fe80::1]:9300}, {[::1]:9300}, {<IP_ADDRESS>:9300}
Starting execution of program
[2018-05-22T09:19:09,041][INFO ][o.e.c.s.ClusterService   ] [1m3UnQf] new_master {1m3UnQf}{1m3UnQfqRESzEuHGmXtWXw}{Hk79-3qVQCGN5rH2PSvsQA}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}, reason: zen-disco-elected-as-master ([0] nodes joined)
[2018-05-22T09:19:09,064][INFO ][o.e.h.HttpServer         ] [1m3UnQf] publish_address {<IP_ADDRESS>:9200}, bound_addresses {[fe80::1]:9200}, {[::1]:9200}, {<IP_ADDRESS>:9200}
[2018-05-22T09:19:09,064][INFO ][o.e.n.Node               ] [1m3UnQf] started
[2018-05-22T09:19:09,073][INFO ][o.e.g.GatewayService     ] [1m3UnQf] recovered [0] indices into cluster_state
[2018-05-22T09:19:09,134][INFO ][o.e.c.m.MetaDataCreateIndexService] [1m3UnQf] [index] creating index, cause [auto(bulk api)], templates [], shards [5]/[1], mappings []
[2018-05-22T09:19:09,401][INFO ][o.e.c.m.MetaDataMappingService] [1m3UnQf] [index/cPsn88XrR0yimNn648GNlw] create_mapping [type]
Program execution finished
Job with JobID d5506334c212280afaf51f6f04ef5613 has finished.
Job Runtime: 1971 ms

> Elasticsearch end to end test pass.

[2018-05-22T09:19:10,749][INFO ][o.e.n.Node               ] [1m3UnQf] stopping ...
[2018-05-22T09:19:10,818][INFO ][o.e.n.Node               ] [1m3UnQf] stopped
[2018-05-22T09:19:10,818][INFO ][o.e.n.Node               ] [1m3UnQf] closing ...
[2018-05-22T09:19:10,825][INFO ][o.e.n.Node               ] [1m3UnQf] closed
Stopping taskexecutor daemon (pid: 68873) on host zhangmingleideMacBook-Pro.local.
Stopping standalonesession daemon (pid: 68581) on host zhangmingleideMacBook-Pro.local.
No zookeeper daemon to stop on host zhangmingleideMacBook-Pro.local.
All tests PASS

+1, LGTM, merging ...

Thanks @tzulitai for review this patch! ~ 👍


README and a tutorial is missing information about torznab link

As a newbie torrent client user, it is not easy for me to understand how this software works.
The README.md is missing an example of the app usage cases to give layman idea how he can use it and what it will do.
When I check https://www.cross-seed.org/docs/basics/getting-started it also does not clear this and FAQ page https://www.cross-seed.org/docs/basics/faq-troubleshooting shows mainly some hard to understand technicals.
Back to https://www.cross-seed.org/docs/basics/getting-started I am stuck at "--torznab https://localhost/prowlarr/1/api?apikey=12345" the tutorial does not explain on any nearby place what "torznab link" means, how much it cost, where to get it. Where to get the key number.
Hopefully you will improve this.

https://www.cross-seed.org/docs/basics/options#torznab

Thumb down for showing weakness and insufficient of yours provided information. Ignorant.

Thumb down for showing weakness and insufficient of yours provided information. Ignorant.

Showing weakness? Ignorance? Technically, you're the one who is being ignorant and thus why you are asking for help. The issue is this is covered in the documentation already. I linked you to it, you just chose to not read.

what "torznab link" means and where to get it
https://i.imgur.com/PwP2Uul.png

How much it costs - it doesn't cost anything.

Where to get the key number? This is in your Prowlarr or Jackett....like the Torznab link is, but you can once again follow the instructions we ALREADY PROVIDE to get this, and subsequently, any additional problems or confusion on the instructions you have are covered in Prowlarr or Jackett's documentation. We don't need to duplicate information already available on official channels, or part of the workflow we describe, in our documentation (Copying the RSS URL).

I don't know what you're expecting, but everything is covered. Thousands of people use these instructions and documentations and I actively maintain it as new things arrive. I'm sorry if you feel it doesn't work for someone completely new to torrenting, but perhaps that's your ignorance and not mine. I've gotten loads of praise for the documentation since I took it over. If you need further explanation google can provide you specifications for the Torznab protocol and in-depth details...
With your attitude, though, I'm not particularly of the mind to continue this conversation. Good luck.


For convenience, add also a constructor without invoke-code.

Converting existing code to use ProvidedTypesContext would be easier if this invoke-less constructor would be there.

LGTM

Approved.  Could we please also fix the travis build failure at some point?

The build is green again!
@Thorium May I ask you to rebase you commit on master? I'll be happy to merge it then.

Rebased.

Thank you for contribution @Thorium !


Progress not being shown while signed-in

The progress bars are not working when I sign into the website but when I sign out they are being displayed.

I think this is a duplicate of #580, please reopen if this isn't the case.

Yes it is the same issue.


Tempus-362 metadata ingestion: API contract alignment with Tempus

API contract alignment with Tempus.
OAuth2 Client credential grant authenticated request to rest based sink.
Jenkins notification slack channel changed to tempusbuild.

LGTM


extract images from pdf

What were you trying to do?
i tried to extract image from pdf with version 0.6.0. but some images doesn't have mime types.
now i tried with latest version.but it's deferent than v0.6.0. i have no idea how to upgrade 0.6.0 code to latest
How did you attempt to do it?
i tried below way on 0.6.0
What actually happened?
can't find mime from buffer
What did you expect to happen?
want to update 0.6.0 code to latest
How can we reproduce the issue?
const pdf = await PDFDocumentFactory.load(doc);

    let objIdx = 0;

    pdf.index.index.forEach((pdfObject,ref) => {

        if (!(pdfObject instanceof PDFRawStream)) return;

        const { lookupMaybe } = pdf.index;
        const { dictionary } = pdfObject;

        const subtype = lookupMaybe(dictionary.getMaybe('Subtype'));

        if (subtype === PDFName.from('Image')) {

            objIdx++;
            var buffer = Buffer.from(pdfObject.content);

            try {

                console.log(await FileType.fromBuffer(pdfObject.content));

                var image = await Jimp.read(buffer);

                // console.log(buffer);
                image.writeAsync(`./output/${objIdx.toString()}.jpg`);

            } catch (e) {
                // console.log(buffer);
                console.log([objIdx, e.message]);
            }

        }

    })

Version
latest
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

on latest version i have tried like this
const pdf = await PDFDocument.load(doc);

    let objIdx = 0;

    pdf.context.indirectObjects.forEach((pdfObject,ref) => {

        if (!(pdfObject instanceof PDFRawStream)) return;

        objIdx++;
        var buffer = Buffer.from(pdfObject.contents);

        try {

            console.log(await FileType.fromBuffer(pdfObject.contents));

            var image = await Jimp.read(buffer);

            // console.log(buffer);
            image.writeAsync(`./output/${objIdx.toString()}.jpg`);

        } catch (e) {
            // console.log(buffer);
            console.log([objIdx, e.message]);
        }

    })

response

I have also test your code sample, so i could reproduce the error.
The problem solver is to use an other approach:
Jimp.read(buffer)
.then(image => {
// Do stuff with the image.
})
.catch(err => {
// Handle an exception.
});
Here now the code for my succefully test:
var templ= 'existing.pdf';  //Solis5YrTest-2.pdf';
console.log("File:"+ templ);
//my load statement
const pdfDoc = await PDFDocument.load(fs.readFileSync(templ));
let objIdx = 0;
const enumeratedIndirectObjects = pdfDoc.context.enumerateIndirectObjects();
enumeratedIndirectObjects.forEach(x => {
//pdfDoc.context.indirectObjects.forEach((pdfObject,ref) => {
const pdfRef = x[0];
const pdfObject = x[1];
if (!(pdfObject instanceof PDFRawStream)) return;

const { dict } = pdfObject;
objIdx++;
var buffer = Buffer.from(pdfObject.contents);
    try {
      (async () => {
          const img = await Jimp.read(buffer).then(function (image) {
          image.writeAsync(`${objIdx.toString()}.jpg`, Jimp.MIME_JPEG);
      }).catch(function (err) {
            //return Promise.reject(err);
          });

       })();

    } catch (e) {
        // console.log(buffer);
        //console.log([objIdx, e.message]);
    }
})

Please notice, you must also define the mime type in the writeAsync statement. Attached you can found my test pdf document and the extracted image file
existing.pdf

.

I have also test your code sample, so i could reproduce the error. The problem solver is to use an other approach: Jimp.read(buffer) .then(image => { // Do stuff with the image. }) .catch(err => { // Handle an exception. });
Here now the code for my succefully test:
var templ= 'existing.pdf'; //Solis5YrTest-2.pdf'; console.log("File:"+ templ); //my load statement const pdfDoc = await PDFDocument.load(fs.readFileSync(templ)); let objIdx = 0; const enumeratedIndirectObjects = pdfDoc.context.enumerateIndirectObjects(); enumeratedIndirectObjects.forEach(x => { //pdfDoc.context.indirectObjects.forEach((pdfObject,ref) => { const pdfRef = x[0]; const pdfObject = x[1];
if (!(pdfObject instanceof PDFRawStream)) return;

const { dict } = pdfObject;
objIdx++;
var buffer = Buffer.from(pdfObject.contents);
    try {
      (async () => {
          const img = await Jimp.read(buffer).then(function (image) {
          image.writeAsync(`${objIdx.toString()}.jpg`, Jimp.MIME_JPEG);
      }).catch(function (err) {
            //return Promise.reject(err);
          });

       })();

    } catch (e) {
        // console.log(buffer);
        //console.log([objIdx, e.message]);
    }
})

Please notice, you must also define the mime type in the writeAsync statement. Attached you can found my test pdf document and the extracted image file existing.pdf  .

i fixed it from thanks

Why not on node??? This have it now tested - it's worked. Please check your Jimp version, i have tested with version 0.16.1. Attached my test code.
node_app.zip

Closing as this is not a bug. Feel free to open a discussion if you'd like help converting code from an old version of pdf-lib to the current API! See also https://github.com/Hopding/pdf-lib/issues/83#issuecomment-487383843.


test: Add generated files to .gitignore, avoid pulling stale images.

Add generated or downloaded files to .gitignore and avoid pulling
images mentioned in generated logs or yamls.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-me-please

Coverage decreased (-0.03%) to 37.044% when pulling 64c93b9fad0eeba570feaeb24c53d6eb083ab522 on pr/jrajahalme/test-ignore-generated-files into 331aab47f35a4b7e329a2038658845134e362a75 on master.


Power as a product

Suggestion
It would be useful to have power as a product for setting up power plants (eg. how much fuel or water does the power plant need, how many burners can you put on 1 belt, or how many solar panels to produce x amount of power)
(For vanilla, in Factorio 1.1 you could do this for basic steam power plants using steam as a product, but in 2.0 Factory Planner only recognizes the acid neutralization recipe for steam as a product)

Thanks for the suggestion. This has been on the todo list for a long time, but it's a lot of work to add power-production recipes and the like. The old card for this is #81, but it's probably not really current anymore. Either way, this is a long while off, there's a lot of other tasks to get to unfortunately.


Inefficient setInterval usage will waste resources and slow things down

Just came across this script, and noticed that the addblocker function uses a setInterval with a 50ms interval, that performs ~6 document selectors. That's going to lead to a lot of redundant processing, even when a youtube tab is open but not playing anything.

ChatGPT
Reviewing your userscript, several aspects stand out in terms of performance and best practices:

Interval Usage: The script uses setInterval to repeatedly check for elements and perform actions. This can be demanding on resources, especially with short intervals (50ms and 1000ms). Consider using mutation observers or event listeners where possible to react to changes instead of polling.

Query Selectors in Loops: The script repeatedly queries the DOM inside setInterval calls. Frequent DOM querying can be inefficient. It's better to target specific events or changes that indicate the need to query.

Not sure if these issues are related to this:

https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/130
https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/135
https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/136
https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/137

I haven't tested this, and it could almost certainly be refined further, but here's a little mockup ChatGPT wrote based on me prompting/refining it around this:

A more efficient approach would involve checking the nature of the mutations and only running removeAds when it's likely that ads were added or modified. Here's how you can refine the addblocker function:

Inspect Mutations More Closely: Instead of removing all ads for every mutation, inspect the mutation records to determine if they are likely to involve ads. For example, you can check if the added nodes match the selectors for ads.

Selective Ad Removal: Only remove ads that are newly added to the DOM, rather than removing all ads every time.

Here's an updated version of the function that incorporates these improvements:
function addblocker() {
    const observerConfig = {
        childList: true,
        subtree: true
    };

    const adSelector = [
        '.videoAdUiSkipButton',
        '.ytp-ad-skip-button',
        'ytd-action-companion-ad-renderer',
        'div#root.style-scope.ytd-display-ad-renderer',
        'div#sparkles-container.style-scope.ytd-promoted-sparkles-web-renderer',
        'div#main-container.style-scope.ytd-promoted-video-renderer',
        'ytd-in-feed-ad-layout-renderer',
        '.ytd-video-masthead-ad-v3-renderer',
        'div#player-ads.style-scope.ytd-watch-flexy',
        'div#panels.style-scope.ytd-watch-flexy',
        '.ytp-ad-skip-button-modern'
    ].join(', ');

    const adObserver = new MutationObserver(mutations => {
        mutations.forEach(mutation => {
            if (mutation.addedNodes.length) {
                mutation.addedNodes.forEach(node => {
                    if (node.matches && node.matches(adSelector)) {
                        node.remove();
                    }
                });
            }
        });
    });

    adObserver.observe(document.body, observerConfig);
}

// Call the function
addblocker();

In this revised version, the MutationObserver callback checks each added node to see if it matches the ad selectors. If it does, it removes that node specifically. This method is more targeted and efficient, as it only removes nodes that are likely to be ads, instead of removing all potential ads every time there's any mutation in the DOM.

You could probably also do something similar for the popupRemover, though at least it only runs once per second rather than every 50ms.
Again, I didn't validate this code at all, but here's ChatGPT's suggestion:

To refine the popupRemover function for efficiency, you can apply a few key improvements:

Replace setInterval with MutationObserver: Similar to the addblocker function, using a MutationObserver is more efficient than continuously polling the DOM with setInterval. This way, your code responds to changes in the DOM rather than running at a fixed interval.

Optimize Selector Queries: Limit the number of DOM queries. If certain elements like fullScreenButton are static and don’t dynamically change, you can query them once outside of the observer callback.

Selective Removal: Only perform actions if the mutations involve the specific elements you are interested in.

Avoid Redundant DOM Manipulations: Check if an action is necessary before performing it to avoid unnecessary DOM manipulations.

Here's a revised version of the popupRemover function:
function popupRemover() {
    const observerConfig = {
        childList: true,
        subtree: true
    };

    const fullScreenButton = document.querySelector(".ytp-fullscreen-button");
    const bodyStyle = document.body.style;
    bodyStyle.setProperty('overflow-y', 'auto', 'important');

    const observer = new MutationObserver(mutations => {
        mutations.forEach(mutation => {
            if (mutation.addedNodes.length) {
                checkAndRemovePopup();
            }
        });
    });

    observer.observe(document.body, observerConfig);

    function checkAndRemovePopup() {
        const modalOverlay = document.querySelector("tp-yt-iron-overlay-backdrop");
        const popup = document.querySelector(".style-scope ytd-enforcement-message-view-model");
        const popupButton = document.getElementById("dismiss-button");

        if (modalOverlay) {
            modalOverlay.removeAttribute("opened");
            modalOverlay.remove();
        }

        if (popup) {
            if (debug) console.log("Remove Adblock Thing: Popup detected, removing...");
            popupButton?.click();
            popup.remove();
            unpausedAfterSkip = 2;

            fullScreenButton.dispatchEvent(mouseEvent);
            setTimeout(() => {
                fullScreenButton.dispatchEvent(mouseEvent);
            }, 500);

            if (debug) console.log("Remove Adblock Thing: Popup removed");
        }

        // UnPause the video if necessary
        if (unpausedAfterSkip > 0) {
            const video1 = document.querySelector("#movie_player > video.html5-main-video");
            const video2 = document.querySelector("#movie_player > .html5-video-container > video");
            unPauseVideo(video1);
            unPauseVideo(video2);
        }
    }
}

// Additional functions like unPauseVideo should be defined outside of this function.

In this version, checkAndRemovePopup is called only when there are added nodes in the DOM, which could potentially be the popups you're targeting. The function then checks for the presence of these popups and performs actions only if necessary. This approach is more efficient because it minimizes unnecessary DOM queries and operations.

@TheRealJoelmatic Are you able to link to the PR / commit this was fixed in as context?


Add draft ADR on configmap/secret content access for operators

We talked about this in the Architecture meeting and everyone is happy with the decision, so it is decided


Fix #1110 Socket Mode disconnection issue with the aiohttp-based client

Summary
This pull request fixes #1110 by improving the connection management of the AIOHTTP based Socket Mode client. I will add a few comments on the improvement.
Category (place an x in each of the [ ])

[ ] slack_sdk.web.WebClient (sync/async) (Web API client)
[ ] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
[x] slack_sdk.socket_mode (Socket Mode client)
[ ] slack_sdk.signature (Request Signature Verifier)
[ ] slack_sdk.oauth (OAuth Flow Utilities)
[ ] slack_sdk.models (UI component builders)
[ ] slack_sdk.scim (SCIM API client)
[ ] slack_sdk.audit_logs (Audit Logs API client)
[ ] slack_sdk.rtm_v2 (RTM client)
[ ] /docs-src (Documents, have you run ./scripts/docs.sh?)
[ ] /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
[ ] /tutorial (PythOnBoardingBot tutorial)
[ ] tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@eddyg Thanks for the suggestion! I agree with you on the log message consistency. I've updated them.

@filmaj

are there tests for handling ping/pong messages?

Yes, this test runs the code of the patterns.

Possibly should we add tests for the monitoring / reconnection behaviours?

Right now, we don't have any tests for this scenario. The reconnection tests require more updates on the testing utility side. I did lots of manual testing this time. Let me add automated tests for it in future updates.

OK sounds good - I am not saying it is required, I am mainly asking questions to learn 😄


Remove a created file in test

Do not leave a created file in the home directory after test.
Description
I tried changing home directory in previous pull request.
But GitHub Actions environment cannot allow to change home directory.
https://github.com/ruby/actions/runs/7843995832?check_suite_focus=true#step:17:3353
    > eval error: Permission denied @ rb_sysopen - /home/runner/foo.rb

So I will try another solution that allow temporarily changing home directory in tests.
And then I found remaining ~/foo.rb.
https://github.com/ruby/actions/runs/7848993435?check_suite_focus=true#step:19:27
+ diff -u /tmp/stat-before-tests.txt /tmp/stat-after-tests.txt
--- /tmp/stat-before-tests.txt	2022-08-16 01:05:14.740220993 +0000
+++ /tmp/stat-after-tests.txt	2022-08-16 01:13:22.767165216 +0000
@@ -14,6 +14,7 @@
 ["/home/runner/.profile", "100644", 1, 1001, 121, 807, "2b9ee6d446f8f9ffccaab42b6df5649f749a9a07"]
 ["/home/runner/.rustup", "40755", 6, 1001, 121, 4096, nil]
 ["/home/runner/factory", "40755", 2, 1001, 0, 4096, nil]
+["/home/runner/foo.rb", "100644", 1, 1001, 121, 38, "9b900ad84347f369a72cfa234fb93d56852ed2ac"]
 ["/home/runner/perflog", "40755", 2, 1001, 121, 4096, nil]
 ["/home/runner/runners", "40755", 4, 1001, 0, 4096, nil]
 ["/home/runner/warmup", "40755", 2, 1001, 0, 4096, nil]

This pull request tries to delete a created file in the home directory.

TODO: limited to allow modification only on ruby/debug Github actions by checking `GITHUB_REPOSITORY == 'ruby/debug'``