Add rtp support for PCIe card(s)

@DanAustinGH, the one I mentioned 😄
Adds rtp support for PCIe - like we had discussed in the (long) thread, needs to use the "pcie" IP address, not Ceton => rtp from <IP_ADDRESS> ... but made it a configurable variable, in case.
Yell if any concerns. Thanks!

How do you determine the PCIe IP address?
Did you get a chance to benchmark the time to tune a channel for each method and CPU load?
I do think working RTP is worth having, but I'd also like to keep the direct hardware method unless it has a noticeable performance hit...

How do you determine the PCIe IP address?

I was wondering what to call this, to avoid confusion 🤣. I'm open to ideas. But it's the local PC IP address, on the same subnet as the Ceton => it's where the Ceton RTP streams to, to be able to feed it in from there. Make sense?

Did you get a chance to benchmark the time to tune a channel for each method and CPU load?

Not yet - but not forgotten! My issue is that I have been seeing error with the latest streaming updates - gradually getting worse with time running. This seems to work around it for now ... so making this change, then I can try to debug the dropped frames.

I do think working RTP is worth having, but I'd also like to keep the direct hardware method unless it has a noticeable performance hit...

Agreed! I want that as well, just need to resolve the dropped frames. This gives me breathing room to do that ... LOL.

Hang on for a minute please - may have found something!

OK, found a bit of a snag. The Ceton allows direct OR rtp, not both simultaneously. I see that if I enable rtp, I can't pull from the device (i.e. cat). That sort of makes sense, and easy to add the logic to not StartStop if using direct ... checked that here, and it works. Oh, and ... "why didn't this happen before?". Because - the IP and port were being rejected before (by Ceton) ... I corrected that, and now the conflict (as it actually does enable rtp).
The snag - it messes with your approach of checking STOPPED or PLAYING from the Ceton (if using direct, as rtp can't be started). The tuner info is still correct in fHDHR, but not for Ceton. So ... keep track of the state separately (for direct?).
Thoughts?
Thanks!

We have a method to determine the state for rtp and for direct, so we may just to fiddle with it a bit.  I do not see an problem with the module only being able to support on mode or the other.
I considered trying to maintain tuner state, but since the standalone can be whacked by other clients or lose power when the fHDHR host does not, I realized it was going to get ugly.  I think that is far less likely on the PCIe, I can still think of ways it might happen.

We have a method to determine the state for rtp and for direct

Sorry, not sure I fully follow - how to detect for direct?

I can still think of ways it might happen.

Agreed, but also not sure there is really a way to avoid it - in either case (even rtp, another rogue device could take over, right?). I guess no matter what, no answer is really foolproof.
And actually, as fHDHR keeps it's own status - it won't allocate a tuner it thinks is in use. So not sure we really need to detect then at the Ceton level?
Thinking out loud, by all means disagree!

I thought we worked that out in the other thread, I will have to go re-read it.
RTP is the method most vulnerable to hijacking.  If you want to try your hand at tuner tracking for the direct method that works for me.

I thought we worked that out in the other thread, I will have to go re-read it.

We may have, and I just forgot - or didn't get it 🤣

RTP is the method most vulnerable to hijacking.

Agreed!

If you want to try your hand at tuner tracking for the direct method that works for me.

Sure, will take a look! The good thing is - fHDHR at the "top" level is tracking correctly.

OK, think I found a way to detect tuner usage ... rtp and direct (device) both. Trying to code here, seems to work. Want me to push a PR, so you can test it out as well?
I also added some items to the web interface, to help with display during debugging 😄.
Thanks!

Definitely submit the changes and I will review as soon as I can...

Will do! Slight redirect ... latest upstream changes break things - let me dig.

Updating my code, not a huge issue, but ... stream_method seems to have gone away? Thinking it's a different name now, but ... @deathbybandaid - with your changes, not sure how I determine direct or rtp in the plugin now?
Thanks!

stream_args["method"]
The stream_args dict is passed to the get_channel_stream function.
There's other information there that has value.

FYI, I removed my check for now - force it, but then,
  File "/mnt/ProgSSD/fHDHR/fHDHR/streammanager/stream_obj.py", line 24, in __init__
    self.setup_channel_stream()
  File "/mnt/ProgSSD/fHDHR/fHDHR/streammanager/stream_obj.py", line 91, in setup_channel_stream
    if self.tuner_needed:
  File "/mnt/ProgSSD/fHDHR/fHDHR/streammanager/stream_obj.py", line 43, in tuner_needed
    if self.stream_args["method"] == "passthrough":
KeyError: 'method'
2022-03-02T03:49:09Z {'REMOTE_ADDR': '<IP_ADDRESS>', 'REMOTE_PORT': '36690', 'HTTP_HOST': 'linuxserver.rkmorris.home:5006', (hidden keys: 20)} failed with KeyError

Thanks!

Toss a print line in or what stream_args show in ceton, also don't set self.method like that

Funny, had done just exactly that 🤣. We are in sync!
{'channel': '593', 'channel_name': 'Golf HD', 'channel_callsign': 'Golf HD', 'origin': 'ceton', 'accessed': 'http://linuxserver.rkmorris.home:5006/api/tuners?method=stream&channel=65089df3-ff53-45b4-8656-9a0844d4edd8&origin=ceton', 'base_url': 'http://linuxserver.rkmorris.home:5006', 'client': '<IP_ADDRESS>', 'client_id': 'be7dc00c-5f63-4e9a-952d-a692d0559e6a', 'origin_quality': None, 'bytes_per_read': 1152000, 'buffer_size': 3, 'stream_restore_attempts': 3}
{'channel': '593', 'channel_name': 'Golf HD', 'channel_callsign': 'Golf HD', 'origin': 'ceton', 'accessed': 'http://linuxserver.rkmorris.home:5006/api/tuners?method=stream&channel=65089df3-ff53-45b4-8656-9a0844d4edd8&origin=ceton', 'base_url': 'http://linuxserver.rkmorris.home:5006', 'client': '<IP_ADDRESS>', 'client_id': 'c44ad89e-3af1-4edc-b34e-984e49e75ec9', 'origin_quality': None, 'bytes_per_read': 1152000, 'buffer_size': 3, 'stream_restore_attempts': 3}

Didn't want to set that, but I need it in startstop_ceton_tuner, and it's not available there 😞. So was adding this in to be able to use it in startstop.

Just pushed  revert

FYI, direct working also. Leaving a test running overnight now ... vlc, two windows - /dev directly into vlc, and one through fHDHR, with debug loglevel. Let's see 😄.
Thanks!

https://github.com/fHDHR/fHDHR/pull/296 fixes close_stream and also adds a new prime_stream for plugins that need a head-start before fHDHR starts pulling content

That works, thanks! FYI, just one that I noticed ... combination type thing (only happens with loglevel = noob, and ffmpeg ... not with direct!), Similar to a recent fix you included, but perhaps just missed ffmpeg streaming?
[2022-03-02 07:12:59,291] NOOB - Set your [logging]level to INFO if you wish to see more logging output.
[2022-03-02 07:13:50,833] ERROR - Unable to Stream: TunerError: Tuner Setup Failed (lazily handled): Tuner Setup Failed (lazily handled):KeyError 'noob'- /mnt/ProgSSD/fHDHR/fHDHR/streammanager/stream/__init__.py line 81
[2022-03-02 07:13:51,594] ERROR - Unable to Stream: TunerError: Tuner Setup Failed (lazily handled): Tuner Setup Failed (lazily handled):KeyError 'noob'- /mnt/ProgSSD/fHDHR/fHDHR/streammanager/stream/__init__.py line 81

I have no idea why that is happening to you. I cannot recreate

@arrmo try pulling new push for ffmpeg plugin
https://github.com/fHDHR/fHDHR_plugin_stream_ffmpeg/pull/9

That works! Apologies if this was me - I thought I pulled all the latest plugins, but I could have missed one 😞.
OK, back to this update ... LOL. Actually, it's almost fully working here, now, with updates to the UI as well. Will try to get the PR in today, so you can look it over.
FYI, I will open a new (top level) issue, related to dropped frames (as I have mentioned). Have some results to share now, but let me clean them up first.
Thanks again!

@DanAustinGH OK, the updated code - enjoy! 😄. Definitely let me know your thoughts. A few items to help explain,

this supports both rtp (udp) and direct for the pcie card
checks are done for both (in use) ... rtp streaming, or direct access
I tied in updating the UI, as it helped me to debug. By all means, propose naming changes if you want!
like I had mentioned, I have to "block" starting rtp streaming, if direct is desired => they are mutually exclusive, the pcie card outputs to rtp OR /dev (direct), not both

@deathbybandaid, by all means comment as well.
Thanks!
PS: A little screenshot from the "updated" UI ... oh, and I see that my daughter is using Plex right now 🤣

Looks good.  I may have not called the hw in use function if using RTP, but I see you dealt with it in the function.
The only minor nit I have is your logging states that the device is PCIe, which can be assumed for direct hardware, but not RTP.
And also super minor, but in the screenshot it looks odd if Transport is 'Stopped' and in HW State is in Use.  And that made me think what would my non-PCI tuner report for HW state.  We might want it to manually set it to 'N/A' for remote devices or not display it at all.
Neither are enough to prevent me from merging, unless you want to tweak them before a merge.

I may have not called the hw in use function if using RTP, but I see you dealt with it in the function.

"in use" is meant to indicate direct access, to the device. I'm all for different naming - just propose something and I'll change it. Really no issue at all!

The only minor nit I have is your logging states that the device is PCIe, which can be assumed for direct hardware, but not RTP.

True, Want me to change that note somehow? I was there as I was working my way through :smile:

And that made me think what would my non-PCI tuner report for HW state. We might want it to manually set it to 'N/A' for remote devices or not display it at all.

Good point! I could change HW State to N/A for remote, like you say. I'm definitely good with that!

Neither are enough to prevent me from merging, unless you want to tweak them before a merge.

Let's tweak it, no issue. I'm game 😄. Just let me know your thoughts on these, and I'll update.

How about merging Transport and HW and use these states (idle/RTP/Direct).  For the logging just remove 'PCIe' fro line 254 in init.py

Will do! Give me just a little bit - as I noticed, daughter is connected, can't restart it right now ... LOL.

Like this?

Yes!  People with stand-alone devices will only See idle or RTP and the PCIe crowd will see what they are configured for.

Agree with you! This does look better, appreciate the suggestion. Another set of eyes always good 👍
Pushed this update, I think we're aligned - but feel free to disagree.
Thanks!

I'm going to merge this and will try to get my stand-alone environment updated for testing today...

Sounds great, thanks! If you see any issues - poke me. We'll get it working for both 👍

This broke the stand-alone device.  The logic to not make the Start API call looks good, but my RTP streams failed with streaming set to ffmpeg or direct.  I changed it to if not self.ceton_pcie and my device is working again.

I changed it to if not self.ceton_pcie and my device is working again.

Do you mean in the Start API? Is it detecting your stand-alone device as PCIe for some reason? Perhaps print that variable out, so we can check it?
Other than this one thing - the rest working? BTW, from the Ceton UI => manually start one tuner streaming (to never never land 😜) ... the UI should detect it.
Thanks!

Just printed out the variables, and the output is exactly as expected. Then it hit me ... I did have to make some changes to adapt to upstream mods. Did you also pull in the latest from the ffmpeg plugin, and fHDHR itself? Meaning ... are those main branches fully updated on your local?
Thanks!

So glad it's not just me who does that 😜
Thanks!

No worries at all! I have done that way too many times myself. Glad it's all working for you!

Then there's me over here merging channels into the origins system.
Channels system worked great back when I only had to support a single origin.

I was worried the death of Locast would demotivate development around the emulator/proxy apps.  I am happy to see that has not been the case....

Agreed! I think this works really well - I even have some plugins I'd like get to, when I have time 😄

BTW, not forgotten about the direct vs. rtp / ffmpeg startup timing. Trying to find a way to measure it automated. I'm open to suggestions!

Perfect is the enemy of good.  Plex, emby and other players will all introduce some variance to the measurements.  I'm just curious if one 'feels' quicker than the other.  For me  Emby usually tunes in 2~3 seconds.  I've had a few .5 second tune and a few 5 second.  I suspect that direct will be a bit quicker and a bit more consistent, having eliminated a bit of network traffic and maybe benefiting from the direct stream not having the UDP packet overhead.

Perfect is the enemy of good.

Agreed! You must be an engineer (too) 😜

For me Emby usually tunes in 2~3 seconds.

Very interesting timing. I say that because ... the answer was staring me in the face, finally smacked me. Here is what I figured out (yell if you disagree of course!),
Use a client (I chose ffmpeg), that I can time => run a fixed duration of video, then remove that duration from the total time ... the remaining time is startup. Agreed so far? So I went with,
time ffmpeg -i 'http://<IP_ADDRESS>:5006/api/tuners?method=stream&channel=593&origin=ceton' -t 30 -f null /dev/null

This will time ffmpeg, connecting to the server, tuning to channel 593, and processing 30 seconds of video (dumping it to the trash). I started with 30 seconds in case of any startup artifacts / glitches, make sure the video is running smooth (which 30 seconds should ensure). The result?
real    0m33.337s
user    0m5.556s
sys     0m0.166s

Take off 30 seconds => startup is 3.3 seconds. Not too far from what you mentioned. Of course, different clients will be different, but that's on the client then 😆. I then tried 3 seconds of video, got,
real    0m6.500s
user    0m0.368s
sys     0m0.041s

So 3.5 seconds of startup ... works for me! Don't save this number quite yet - as I have been messing with code here, let me undo some things, get real numbers.
Oh, and something to noodle on. I was also thinking about CI/CD in the back of my mind, cases to run automated, confirm the build is good. Interestingly enough, the command above returns 0 ... as expected. If I pick a bogus channel, I get 1. Woohoo, this could be a CI/CD test, agreed?

OK, 3 runs each, rtp and direct, averaged,
rtp: 2.7 sec
direct: 2.2 sec

Not a huge difference, but a bit quicker direct, as you though. BTW, I do see some interesting things in the two cases, that may lead to more optimization yet?

rtp

Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x565292b5d140] Could not find codec parameters for stream 1 (Audio: ac3 (AC-3 / 0x332D4341), 0 channels, fltp): unspecified sample rate
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x565292b5d140] Could not find codec parameters for stream 2 (Unknown: none ([5][0][0][0] / 0x0005)): unknown codec
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x565292b5d140] Could not find codec parameters for stream 3 (Unknown: none ([5][0][0][0] / 0x0005)): unknown codec
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options

direct, client side

[mpegts @ 0x560886e82ec0] Stream #0: not enough frames to estimate rate; consider increasing probesize
[mpegts @ 0x560886e82ec0] Could not find codec parameters for stream 0 (Video: mpeg2video ([2][0][0][0] / 0x0002), none(tv)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x560886e82ec0] Could not find codec parameters for stream 1 (Audio: ac3 (AC-3 / 0x332D4341), 0 channels, fltp): unspecified sample rate
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x560886e82ec0] Could not find codec parameters for stream 2 (Unknown: none ([5][0][0][0] / 0x0005)): unknown codec
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[mpegts @ 0x560886e82ec0] Could not find codec parameters for stream 3 (Unknown: none ([5][0][0][0] / 0x0005)): unknown codec
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options

Very similar in both cases
Thinking I closed my AP here 😜. Thanks!

I like it.  Simple and re-producible without worrying about the media server adding its own delay.  I'm not sure how much optimization with yield.  I think increasing probesize might actually slow things down since it is just a stream copy.
And nice to see the actual numbers.  I am considering trying to pick up a PCIe 6 tuner to replace the current 6 tuner and HDHR 3 tuner I keep as a spare.  The .5 second is not a big difference, but I'd eliminate a good bit of traffic off the home network...
Many thanks for the contributions!

I am considering trying to pick up a PCIe 6 tuner to replace the current 6 tuner

Agreed! I do like the internal card => network traffic is just the PCIe bus 😄

HDHR 3 tuner I keep as a spare

@deathbybandaid may want to hear about this - he has been looking for SSDP output from real HW.

Many thanks for the contributions!

Happy to help if I can!

Well ... a slight update 🤣. Improved timing a bit, without any real downside ... I realized that I had buffer_size set to 3. But there is no real upside to that, as for a real-time / streaming input ... you can't gain any ground on the source => and this is just buffering time up front, which really is only delay. So - changed it to 0, confirmed overnight no higher rate of dropped packets, but updating startup timing! Now ...
rtp: 1.8 sec
direct: 1.3 sec

I have been also fiddling with trying to specify the input format, to speed up startup in ffmpeg in case detection is limiting ... but even in the broken case (screwed up parameters, by me 😆), it's ~ 1.2-1.4 sec. So I'm not thinking I'll get much below the times above. Time to move on to the next item ... which, BTW - I'm going to open a new "issue". Will explain it there, and feel free to assign it to me.

Yeah, we talked about the lack of need for buffering for the Ceton.  You may be able to shave another .25~.5 by reducing the bytes_per_read.  The trade off there is the CPU load will go up.  Since each buffer read represented about .7 seconds of delay there is not a huge about to save here.
Off to see if I forgot to reset the buffer values on my install...

Yeah, we talked about the lack of need for buffering for the Ceton. You may be able to shave another .25~.5 by reducing the bytes_per_read. The trade off there is the CPU load will go up. Since each buffer read represented about .7 seconds of delay there is not a huge about to save here.

Agreed! Was thinking that too - perhaps a slight savings. Like you say, a tradeoff.

Off to see if I forgot to reset the buffer values on my install...

So you have 3 as well currently? Or some other value?

I had mine at 1.  Moving to 0 did not make a difference on the 1st tune.  Will monitor to see if it seems quicker, but since the likely improvement is just under a second, I may well not notice.

Agreed! The delta is pretty small now ... I shaved 1 second going from 3 to 0 ... so your delta is likely ~ 0.33 sec, not really noticeable. I'm using time to measure it, but 0.33 sec won't show much when watching it 😜

I'm going to ponder how we might be able to have multiple Ceton devices.  I have a bid in on a 6 tuner PCIe, and see a few USB-4 devices, which would be similar to the PCIe for hardware access, and I could see people interesting having a mix in use.
Something along the line of adding a config variable Ceton_device_count then loop over reading in ceton_ip_{device#}, pcie_ip_{device#} and tuners_{device#}.  Need to update the properties as well which appears a bit trickier, but not impossible.

Sounds great! And to our earlier discussion - auto-detect the number of tuners (on a device), not hard coded?
Thanks!

Will have to see what is possible once/if I can acquire a 2nd devcie...


Support multiple ports (in reverse mode)

Problem Description
I always come up with the most esoteric use-cases, but here we go.  This way I can mess with the commands traffic. However, due to the way FTP works this breaks the protocol, because the data connection (in passive mode through some random port) is not proxied through mitmproxy and hence comes from a different client and is of course blocked.
Proposal
I'd love to proxy everything in a given range, e.g. 30000 to 30009. With Pure-FTPd I can specify which range it will pick the random port for each data connection. This would require:

Creating multiple listeners on different ports (as simple as allowing listen_port to be a list of int)
Mapping each of them to the reverse destination (maybe by extending the mode syntax to allow mappings)

Alternatives
Launching multiple mitmproxy instances, but that's no fun and I don't have everything in one UI.
Additional context
Burp (which is limited to HTTP) allows launching multiple listeners and displays the port in the flow list so you know which listener the traffic went through. So there are use-cases other than mine and even with regular mode. E.g. I'm using 8080 for my desktop traffic and 8081 for mobile traffic so I know which is which.

Yup! It would be really cool if we could have mitmproxy listen on port 8080 as an HTTP proxy, port 1080 as a SOCKS proxy, user-configurable ports for custom reverse proxy destinations, etc. by default.

I may be on the wrong thread here as it's been years since I've used mitmproxy, but I arrived here trying to find a solution for my use-case, and if this issue fits the context of tihs issue then it seems to me to be a bit more of a pedestrian example.
I have a pretty simple Podman setup for a number of app servers, and an nginx-based reverse proxy. The reverse proxy handles all the TLS and some basic security and just forwards different URL paths to different app servers. these servers are different versions of the same program - we want several up at once to test before making changes.
My aim is just to see all requests coming in and out of the app servers. So this includes intercepting between nginx and the app server for the Gateway<--->App server reverse proxy, and also setting all the app servers to use an mitmproxy instance as their explicit proxy, as the app servers call back out to some APIs over the Internet:

Please exclude the somewhat crappy drawing. I've drawn the red dashed box around what I would like to capture. We can't really put mitmproxy in front of the reverse proxy as the dummy certificate would cause problems.
I believe setting the (multiple) app servers to forward their outgoing requests to mitmproxy is the easy part, and I should be able to see requests out of all the app servers form the same mitmweb interface. However, I'd now also like to intercept the requests going into the app servers form the reverse proxy, without having to set up multiple mitmproxy instances. nginx just uses a simple proxy_pass to the app server, so if it would be possible to set a header in the nginx configs that represents where mitmproxy should pass the request, and instead proxy_pass to mitmproxy, then this owuld be a nice setup for me, involving at most two mitmproxy instances. Currently the workaround (if I'm not just missing an existing easy way to accomplish this) would be to add a second reverse proxy, so mitmproxy would sit inbetween the gateway and that. The gateway would just decrypt and forward the lot through mitmproxy to the second reverse proxy. which would then perform the routing to the app servers.
I would have no problem with multiple instances of mitmproxy, except that it would quickly grow out of control and require complex routing to ensure each app server was speaking to the right one. I think if this oculd be wrapped internally, so that as mentioned, the mitmproxy/mitmweb interfaces grouped in one output the details from several subinstances inside, then that might be a nice option. There's no reason why anything else owuld need to be shared between the subinstances at a granular level for me, it's just having a workable setup, ideally, one mitmproxy that can spawn up two handlers for each app server internally.

Yup! Taking this one step further: It would be really cool if we could have mitmproxy listen on port 8080 as an HTTP proxy, port 1080 as a SOCKS proxy, user-configurable ports for custom reverse proxy destinations, etc. by default.

Correct me if I'm wrong, but this now works on main, right? Or is any of the things you've listed limited?


Update code without re-rendering visr

Right now updating a VISr's backing always re-renders it. While this does work it is slow. It would be better to use reagent's update if at all possible.

This is fixed


Filter sensitive user information from logging

Currently fields like first and last name, email are not being filtered in logs. It is sensitive data of users which I think should be filtered

@SoloJr could this be merged?

@mantaskujalis from my point of view, yes.
@fredericdelordm your call :)

@SoloJr Hello, you can merge.


DARKMODE WITH TEXT CHANGE WITH CLICK ON BUTTON

made a dark and light mode feature with change in text on button with clicks

That's a bad folder name - caps and spaces.
You should not have so much CSS in your HTML - move it to a file.
Do the same with the JS.
Your JS won't work. Have you tested it?


Helidon MP RestClient documentation

Fixes https://github.com/oracle/helidon/issues/4207

I made a few edits to address some of the comments, I created https://github.com/oracle/helidon/issues/4462 to make another pass.


Inky display not updated

Inky phat display not changed, either with quote of the day, or a manual message.
This is on a Pi Zero with a fresh Balena OS install.
Also, I notice the code is set for Inky BLACK.
display = InkyPHAT("black")  I'm new to Balena, so without SFTP/Desktop access, how do I change it for my YELLOW Inkyphat?
Thank you!

Hey @Richard238, I'm a member of the balena team and I am familiar with the inkyshot code. I'm running the inkyshot code on my Red Inkyphat and it runs totally fine (although I don't see any red color as inkyshot code base uses only black and white color at the moment. Actually it'd be great for inkyshot to support red/yellow/other colors).
I suspect that your device has another issue. Could you please open a thread at the balena forums?
Balena support team could help you troubleshoot the issue and even connect to your device to check out the logs (if you provide support access to your device).

I was rather hoping to avoid creating yet another forum login, but, it's done.
Link
Thanks,
Richard.

Root cause here is that there seems to be a new hardware revision of the InkyPHAT which, although higher resolution, requires an updated version of the library. I've updated the libs and altered the code to autodetect both versions.


system#setCode, the code arguments should be customized

[ ] When the code is not large, show all the hex
[ ] When the code is large, show a short info like 0x123...456, then followed by a download button which user can click to download all the hex.
[ ] For JSON, we don't have to show the download button. Only show 0x123...456.

no such data currently
might wait until its scaned

We should improve the extrinsic parachainSystem#enactAuthorizedUpgrade, check following extrinsics:
https://statemine.statescan.io/extrinsics?page=1&module=parachainSystem&method=enactAuthorizedUpgrade


feat: MQTT_NAME env variable for mqtt name.

I added the option to configure the mqtt name using an env variable.
I needed this in order to manage several pods in a kubernetes cluster.

@mannerydhe Could you add the env var to docs please? There is a doc dedicated to env vars :)

@mannerydhe Could you add the env var to docs please? There is a doc dedicated to env vars :)

Done!

Please rrun the command npm run lint-fix

@zwave-js-bot fix lint

@zwave-js-bot fix lint

@zwave-js-bot fix lint

@zwave-js-bot fix lint

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 30.366%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/MqttClient.ts
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
3612

Relevant Lines:
12500

💛  - Coveralls


UHF-7113: Hyphenopoly fixes

UHF-7113

What was done

Moved hyphenopoly out of dist folder to avoid it getting aggregated, added defer attribute to the library js files so that they don't get aggregated either

How to install

Make sure your instance is up and running on latest dev branch.

git pull origin dev
make fresh

Update the HDBT theme

composer require drupal/hdbt:dev-UHF-7113_hyphenopoly_fixes

Run make drush-cr
We need to test that the hyphenopoly works with Drupal JS aggregation turned on so we need to do the following:

Make sure that you have the aggregation turned on. Comment these lines from local.settings.php file if they are not already:

$config['system.performance']['css']['preprocess'] = 0;
$config['system.performance']['js']['preprocess'] = 0;

Edit the hyphenopoly_settings.js file and change the 'fi' value to FORCEHYPHENOPOLY.
Compile the theme styles nvm use && npm i && npm run build
Clear the caches from project root make drush-cr

How to test

[ ] Make sure that the h1 titles are now hyphenated in Finnish using the hyphenopoly library.
[ ] Check that code follows our standards

Designers review

[x] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

This is not something we want to do. Instead lets do this: https://github.com/City-of-Helsinki/drupal-hdbt/pull/658


Clarify difference between Capture and Record audio effects

Updated documentation of AudioEffectCapture and AudioEffectRecord:

Capture returns a raw audio buffer, while Record encodes it into an audio stream.
The note about enable_input setting was confusing in Capture docs, since the microphone use-case is only one of the many listed.
Additionally, the demo project listed uses the Record effect, not Capture! So moved that note and link to the Record effect instead.
Record also had a very weird wording in its docs ("It sets, It checks, It returns"...) which I cleaned up.

Thanks!


Equivalent ESP32 Chip functions

The following would be useful functions to port to the class LibreTuyaClass to understand the chip being used:
getChipRevision
getEfuseMac or a a generically named unique chip identifier equivalent
getFlashChipMode
getFlashChipSpeed

The 2nd function is implemented as getChipUniqueId() or something - refer to the docs, there's a complete reference of the LT class (which is also aliased as ESP). Adding fully compatible functions with the same names is also a good idea.

Actually, I think you can substitute getChipRevision with getChipFamilyName or getBoard, which are implemented. There's also getChipType which returns an enum value.

Actually, there's much more of these functions that I thought. See here:
https://docs.libretuya.ml/docs/reference/lt-api/

Since I'll be refactoring the project anyway, do you think a separate ESP class, fully compatible with ESP32 class, should be added? Right now it's aliased to the LT class, but since their structure is mostly different, I'm not sure if that aliasing makes any sense now.

If I were doing it, I would create a parent class for the LT and the ESP class and add the common functions there with appropriate wrappers in each child class. That way, you reuse in those cases where it makes sense and there is only one class to worry about for these capabilities.
I see the getChipId function now. Thanks for the document reference.
Regarding getChipRevision, this should be the version number of a chip given that they will make mistakes and often have to release replacement versions to correct specific problems.
The functions related to flash operation are useful when working multiple boards.

Maybe save the revision for later. Over time, more people will play with these chips and more information can be extracted from them. I know that I have had to implement different application level or framework code at different times because chips had bugs that needed to be worked around.

Most of ESP class functions are now implemented. Do you need anything else in particular, or can this issue be solved?


Update datasheets and schematics for current circuit

74HC165
LD33CV
24LC256
etc.

https://easyeda.com/editor

https://electronics.stackexchange.com/questions/367797/resistor-dac-and-buffer-for-vga-output/367806#367806

@konimaru
I'm upgrading my VGA DAC to 8 bits, and found this stackoverflow answer going into some good implementation detail.
But at the bottom of the answer, in the "edit", he says that "you don't want 400 mV at the input of the other side of the transmission line. You want 200 mV there. The 75 Ω series termination resistance and the 75 Ω parallel termination resistance forms a voltage divider with a ratio of 2:1. So it will expect half the voltage, not the entire voltage."
I'm not seeing at all how having 1/2 your target voltage at DAC output is supposed to be appropriate, as the divider actually has a 1/2:1 ratio. Thoughts?

https://easyeda.com/cspang1/JCAP

Satisfied by commit f706d67539811e058f30af8e1f3da350c5230424


Do not require cmake to be installed

It seems like some build stuff to bring  this in line with othe node native interfaces would be useful - perhaps using node-gyp??  Are there reasons this wasn't done this way??  I think this library would be super handy for something I'm working on so considering taking that on... thoughts???


fix(ngnix): handle X-Forwarded-Port and X-Forwarded-Proto properly

fixes #244

I can't review this atm, but I'd like to look at this one in some more detail before we merge, if that's alright.

@krancour this isn't getting merged without your lgtm

Current coverage is 46.22% (diff: 100%)

Merging #248 into master will not change coverage

@@             master       #248   diff @@
==========================================
  Files             3          3
  Lines           305        305
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            141        141
  Misses          160        160
  Partials          4          4

Powered by Codecov. Last update e38a69b...4d30fe1

pinging @krancour for a re-review before we cut a new router release

@krancour i had tested with an example app based on https://www.nginx.com/blog/websocket-nginx/ to test the web sockets


Any hints on how to utilize the package to benchmark a user provided dataset and user provided model?

Basically, I would like to utilize the code to benchmarking a local model against a personal test dataset. Is it possible? Didn't find much information in the doc. Thanks!

For running your own model, the easiest way to do this currently is by using the Hugging Face Hub integration.
For adding your own data, or for non-Hugging Face models, I would recommend forking the repository and then adding the model and scenario in the code. Here's some references:

Developer setup
Adding a new scenario
Example PR for adding a new scenario
Adding a new model
Example PR for adding a new model


⚠ Processors has degraded performance

In 2795bfd, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 48 ms

Resolved: Processors performance has improved in 7cb9cd2.


Skycat doc2

Installation and usage instructions as well as description of catalogs for ops rehearsal and roman/rubin simulations.
See it here

Looks good to me. Only minor suggestion would be to write out what SSO is on the main page where the SSO file is defined for clarity.

@matroxel  I followed your suggestion about SSO.  I also fixed a couple typos and updated the documentation workflow to publish from the main branch rather than my development branch. Please take a look when you have a chance and approve if it seems ok so I can merge. Thanks!


Use JSON parser instead of YAML's for metrics

Fixes #197

Coverage remained the same at 85.027% when pulling f8670af889ae597327a8b71f68c5ebff7223c073 on json-loader into 0c1c139fbfcb053011f25b3e44f14ddae3908188 on master.


[VoIP] crash in caller side when a started video call is stopped asap

The caller side crash on a video call, when right after starting the call, the hang up button press is pressed asap..
Steps:

Start a video call
Immediatley press the hang up button to cancel the call
a crash (libc: Fatal signal 11 (SIGSEGV)) is triggered

Reproduced on Moto G.
Race condition..
The video context in webRTC lib was cleared, but after the video API was still called.

I have encounter this problem again on two different devices that I have tested. Video call crash the app at hangup. Is this still the same race condition. PS: I am new to android programming.

I posted this before https://github.com/vector-im/riot-android/issues/3311#issuecomment-533945105
Tracing the Riot 0.9.6 code for the bug. It happens at CallsManager.Java, onHangup(). mActiveCall.hangup() cause the program to crash. This is a call to SDK. The code is not in Riot 0.9.6. Can someone doing the matrix-android-sdk check what is happening inside IMXCall.hangup()?
How do I forward this to matrix-android-sdk thread?


url-loader loads urls of css correctly, but it replaced to url on client side

Version
v2.8.1
Reproduction link
https://github.com/hedrall/nuxt-bug-Reproduction
Steps to reproduce
yarn && yarn dev
What is expected ?
Url-loader loads urls of css correctly, and we can see base64 encoded url in computed styles in browser.
What is actually happening?
In view-source, we can see that urls of css is correctly encoded in base64 like picture bellow.

But checked in computed styles, original url was there. Browser loaded images once more.

I think JS replaced base64 to url on client side. Actually, I tried turn on the utility of block JS on browser, and can see base64 urls in computed styles.
Is this some bug? Thank you.

This bug report is available on Nuxt community (#c9634)

Can't reproduce with the repo and in a production build


planning module start error.

System information

Linux Ubuntu 20.04:
Apollo installed from source:
Apollo version 7.0:
Output of apollo.sh config if on 7.0 branch:

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:
1.run ./docker/scripts/dev_start.sh start container
2.run ./docker/scripts/dev_into.sh into container
3.use vscode remote container
4.start debug planning module

Supporting materials (screenshots, command lines, code/script snippets):
I try to debug planning module use vecode, but it start fail when output this log (PS: debug control module success):
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0615 14:27:32.142376 12989 module_argument.cc:81] []command: /apollo/.cache/bazel/540135163923dd7d5820f3ee4b306b32/execroot/apollo/bazel-out/k8-dbg/bin/cyber/mainboard/mainboard -d /apollo/modules/planning/dag/planning_navi.dag
I0615 14:27:32.142632 12989 global_data.cc:153] []host ip: <IP_ADDRESS>
W0615 14:27:32.142642 12989 environment.h:33] []Environment variable [CYBER_PATH] not set, fallback to
I0615 14:27:32.146597 12989 module_argument.cc:57] []binary_name_ is mainboard, process_group_ is mainboard_default, has 1 dag conf
I0615 14:27:32.147459 12989 module_argument.cc:60] []dag_conf: /apollo/modules/planning/dag/planning_navi.dag
E0615 14:27:32.331519 12989 class_loader_utility.cc:218] [mainboard]LibraryLoadException: libc10.so: cannot open shared object file: No such file or directory
E0615 14:27:32.331575 12989 class_loader_utility.cc:234] [mainboard]shared library failed: /apollo/bazel-bin/modules/planning/libplanning_component.so
E0615 14:27:32.338169 12989 class_loader_manager.h:70] [mainboard]Invalid class name: PlanningComponent
E0615 14:27:32.338222 12989 module_controller.cc:67] [mainboard]Failed to load module: /apollo/modules/planning/dag/planning_navi.dag
E0615 14:27:32.338238 12989 class_loader_utility.cc:256] [mainboard]Attempt to UnloadLibrary lib, but can't find lib: /apollo/bazel-bin/modules/planning/libplanning_component.so
E0615 14:27:32.338248 12989 mainboard.cc:39] [mainboard]module start error.

https://github.com/ApolloAuto/apollo/issues/14307#issuecomment-1168866423

check if libc10.so is exist use ls /usr/local/libtorch_cpu/lib/ or ls /usr/local/libtorch_gpu/lib/
if exist use sudo ldconfig to add the path to runtime dynamic library search path


Pill/Chip: To represent an input, attribute, label or action

The problem
I need to represent a list of email addresses in an input field so that a user can add a single or multiple emails within the input field.
The solution
Creating a pill/chip component that standardized the look and behavior of this component.
Here is the design we'd like to follow for this feature.
This is the starting state:

List state with valid pills:

List state with pill error:

Hover on pill error state:

Alternatives considered
I took a look at what Material Design does for similar use cases and I find that their chips component is very similar to the behavior we're looking for.

Moved to #648


Added LED management for Oculus DK2 and CV1

This pull request enables and manages the LED positions for the Oculus DK2 and CV1 including decoding of the LED positions.
This is needed for positional tracking.

LGTM


Stabilizers don't fit in PE Acrylic 3mm

Hey, so i laser cut the Iris PE Switch Plate Mx 3mm and after receiving it my stabilizers & the switches fall through the thumb area because the space it too large. The shop did not enlarge that area. How am i supposed to fit the stabilizers? I am going to handwire it so the stabs have to fit in the plate
https://github.com/user-attachments/assets/364dcd68-56ff-40d8-9d20-8b80f713b90c

Thanks for the help

The cutout around the 2u key for 3mm plate is large to accommodate the stabilizer wire/housing. Otherwise, the wire and housing would hit the underside of the plate. Hence, the 3mm plate isn’t geared towards handwiring and more for use with a PCB.

Yea i figured that part out later after a lot of troubleshooting. Is it possible to use an adapter over there? The adapter will be 1.5mm and hold the switch & the stabs. Just a thought

I’ll have to check my files, but I may have already designed a 3D-printable adapter to hold the switch in-place.

There is already a file to hold 2 1u switches but i want to use 1 2u
If you have the files, It would be a great help 🙏.
Thanks

Did you fine the stl file?

I checked my Fusion 360 projects, and it doesn't look like I've designed a
2u adapter yet, but I can give it a go later this week.
On Tue, Oct 29, 2024 at 3:21 PM Konisteel @.***> wrote:

Did you fine the stl file?
—
Reply to this email directly, view it on GitHub
https://github.com/keebio/iris-case/issues/45#issuecomment-2445136048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABR3NGOVBE35ZXCLTYWRCTZ57N3HAVCNFSM6AAAAABQZH2SDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBVGEZTMMBUHA
.
You are receiving this because you commented.Message ID:
@.***>

That Would help me out a bunch, and others who will use it :D
Can't wait for the files and the new update

Yeah, I'm working something up right now and will do some test printing

Great!

Hey when can we expect the stl file :p

keyboard adapter.zip

Turns out I did have something designed previously, see how this works out for you.
Iris PE 2u Adapter for 3mm Plate.stl.zip

If recutting the plate is an option, you could go with the older-style cutout in iris-PE-switch-plate-mx-alps.dxf

Hey how does the file work? I'm confused

It’s not particularly great with handwiring though, so I don’t really have a good solution for using the plate as-isOn Nov 6, 2024, at 10:35 AM, Konisteel @.***> wrote:
Hey how does the file work? I'm confused
image.png (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Alright i'll receive the 3d printed adapter that i uploaded and check if everything works great. I'll keep you updated but so far if you use the top plate than a little sanding is necessary or else it'll fit on the plate no problem with normal mx switches and cherry stabs


Update to payjoin-ffi 0.21.0

Please see the commit messages for details of what's going on here. I tried to re-stage everything so that it is easy to review both now and if anyone comes back in the future. I removed the example tests, instead moving payjoin-flutter-demo to the example folder for a single simple smoke test site. We will add payjoin-ffi bindings for test fixtures to make running payjoin-directory, ohttp-relay, and bitcoinD easy in a follow up.
fix #1
What's actually happening here:

bitcoind and bdk integration tests are deleted. They're really smoke tests that require manual setup and teardown, and we'll replace these with an example from payjoin-flutter-demo that's easier to use for now. The differences between bitcoind and bdk tests is really just type conversion from those wallets to payjoin, and we don't need to test that that behavior is possible in Dart. Perhaps we should test that a complete reference is possible, but that can be done at the rust level upstream.
v1 codepath is deleted because nobody is hosting a server with Dart instead of Rust, v2 is backwards compatible
v2 is updated to payjoin-0.21
flutter-payjoin-demo is included last to smoke test

One thing I don't quite understand about the arch you might be able to answer: Why do we need internal FfiType types that we override instead of just exposing those?

I don't have merge access here fyi


[BUG] Fast flag's arent working.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[x] My answer given in the checkbox above is a lie.

What problem did you encounter?
Im trying to get accessory adjustments enabled but it isnt working pls help.
I've tried capatilzing the T and i've retried multiple times. Pls help

Isn't that something you adjust on the website?

Idk bc the other fast flags I have set are working. Its just the accesory ones

Can you post them here please?

Issue has stale for over a month, and will be reopened if further information is given.


Curriculum content not showing

I am still awaiting the email
@IjayAbby  can you pick this up?

Yes I can see
On Tue, Jul 7, 2020 at 12:35 PM ggotora<EMAIL_ADDRESS>wrote:

I am still awaiting the email
@IjayAbby https://github.com/IjayAbby can you see this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ggotora/github-slideshow/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOQBCHP7Q3M7PXNXOAWTXDR2LT4ZANCNFSM4OST7MNQ
.


Training Loss Values.

Hi, thank you for releasing this GitHub repository. I am trying to reproduce the stage 1 training on ImageNet. Could you please share the W&B log or let me know the initial and final loss values for that stage? I am getting the following loss, and it turns out the model is not converging. Thanks.

Hi, thanks for your interest. Your loss curve looks a bit weird. When I trained the first stage, the loss would quickly reduce to around 8, and then converge to around 7 (500k steps).

What's the resolution, are you training on 256x256?

I am training with 256x256 resolution. Can you tell at which training steps at stage 1, you are getting meaningful sampled images in class conditional manner?
One more thing, can you also tell me what is your total batch size and number of training steps in stage 1?

Here are the generated samples at 10k iterations. The total batch size of t2i, mmu, and language modeling is 1152, and I guess the batch size of t2i is around 700.

Thanks for the quick reply! Much appreciated.
Can you tell me how would be the generated images at the end of the stage

I am assuming in the stage 1, you only are using ImageNet and
RefinedWeb. Is it correct?

PhD student at AIM Lab
Science Park, University of Amsterdam, Amsterdam, Netherlands
Skype Id: m2.derakhshani1993
On Tue, 12 Nov 2024 at 09:19, Jinheng Xie @.***> wrote:

Here are the generated samples at 10k iterations. The total batch size of
t2i, mmu, and language modeling is 1152, and I guess the batch size of t2i
is around 700.
image.png (view on web)
https://github.com/user-attachments/assets/95f83469-a300-45ff-a63f-8c0f6c92ed5d
—
Reply to this email directly, view it on GitHub
https://github.com/showlab/Show-o/issues/50#issuecomment-2469868260, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD7OT66RINXDI2QQIQRYSW32AG2ZDAVCNFSM6AAAAABRSVLPYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZHA3DQMRWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

mmu loss is also used in this stage. Some samples generated without CFG.

Could you please clarify whether these samples were generated after the training was completed? Additionally, could you let me know how you adjusted the learning rate? Did you use a method similar to YOLO-style initialization, or did you conduct several experiments to determine the best approach? I want to increase the batch size and train a larger model, so I would appreciate some hints about the initialization of the learning rate.

BTW, welcome to star our project :)

Happy to star! :D


Update lld-disks.py

Ignore dm-crypt devices
Ignore block device partitions using regular expression (probably not a best method)

@strobil, hey!
Sorry for long absence..
Can you explain what is second if for? You would like to filter everything that only has letters in name? Can you please provide an examples that are filtered?

@grundic
Second "if" will filter device partitions.
Instead of creating sda1,sda2,sda3.. etc - it will create only sda monitoring item.
Now i think that is not a good idea, because in my case all disks have one partition, but
in other cases, it might be usefull, because of different device partitions can me mounted on different mount points.
So, i think it would be better if i remain only "dm" in "skippable". What do you think?


Fail on startup for Http/2 HTTPS on Mac

Mac doesn't support ALPN: https://github.com/dotnet/corefx/issues/33016
In 3.0 HTTPS and HTTP/2 (and HTTP/1) are enabled by default. The GRPC template is going to disable HTTP/1. HTTP/2 per spec requires ALPN when used over HTTPS. Today this fails per request and you have to dig into the server logs for the error.
Proposal: Check for HTTPS + HTTP/2-only on Mac at startup and fail early.
@shirhatti @JunTaoLuo

FYI @JamesNK

@JunTaoLuo for verification.

Partly verified in https://github.com/aspnet/AspNetCore/pull/11473#issuecomment-505287505. I'll try it out on a preview 7 SDK.


HAL Link change for lux:PlaceWorkAbout

Problem Description:
Need to change the query: lux:placeworkabout. It looks for works about this place but we want it to look for “works about this place OR works about concepts influenced by this place”.
Expected Behavior/Solution:
The record of the places pages, such as: Black Sea Region should show Works about this place or works about a concept influenced by this place. Such as the Works about tab (example: West Virginia)
Requirements:
record of place: Black Sea Region will contain information on works about a place/works about a concept influenced by this place such as: Personal Narratives, German. . Will contain information in the tab: Works about.

will remove text: "Yale University does not have any objects or works directly related to this place."

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[ ] ~Wireframe/Mockup - Mike~
[ ] Committee discussions - Sarah
[ ] Feasibility/Team discussion - Sarah
[ ] Backend requirements - TBD
[ ] ~Frontend requirements- TBD~
[x] Questions
List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:
https://lux-front-tst.collections.yale.edu/view/place/093db312-3942-4fa1-903c-2810520c512a
Dependencies/Blocks:
Related Github Issues:
https://github.com/project-lux/lux-middletier/issues/42
Related links:
Bugherd: https://www.bugherd.com/projects/284041/tasks/2078
Wireframe/Mockup:
Place wireframe/mockup for the proposed solution at end of ticket.

UAT link does not work in prod/tst.

@clarkepeterf & @kamerynB -  I think the old uat link was for the black sea region record, so I re-found it and then update the URL under UAT. In the case I am mistaken, here was the original uat link that no longer works: https://lux-front-tst.collections.yale.edu/view/place/093db312-3942-4fa1-903c-2810520c512a

Approved by UAT 7/22

Looks good in prod. Closing.


unix:add InotifyInit for mips64

@Doorer please adjust the PR title to unix: add InotifyInit for mips64 (adding the space after colon), so it will be imported correctly into Gerrit (as per https://golang.org/wiki/CommitMessage#github-pull-requests).


re-enable keda tests for ekb

This PR re-enables the keda tests in eventing kafka broker now that they are passing thanks to https://github.com/knative-extensions/eventing-kafka-broker/pull/3479

/lgtm


Tech/move tests to inmemory db

Problem

*-adapters test were failing, as they were trying to use real PostgreSQL DB

Solution

SpringBoot test application properties were switched to user in memory H2 DB
Liquibase schema changelog was added there as well
Liquibase schema changelog files were moved to adapter-commons from app-monolith, as this module is used by *-adapters, so their test can
Dependencies to H2 and liquibase were added there as well, however as test scope is not transitive I left them in default scope. Maybe extracting them to new adapter-test-commons would be better; what do you think?

During development I discovered two issues to be solved in next PRs - groovy test seem not to be run from maven build and while starting app exception
java.sql.SQLFeatureNotSupportedException: Method org.postgresql.jdbc.PgConnection.createClob() is not yet implemented.
is thrown

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #11   +/-   ##
========================================
  Coverage      97.4%   97.4%
  Complexity      104     104
========================================
  Files            23      23
  Lines           231     231
  Branches         29      29
========================================
  Hits            225     225
  Misses            4       4
  Partials          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f30da...e7f1251. Read the comment docs.

Are we able to get rid of com.h2database.h2 dependency from commons, it is confusing.
I will prefers to copy and paste it in each module, or create single BOM pom-file with all Test dependencies.

Please rename *Test into *Spec to include those missing tests in maven build.
It can be done under that feature.

What do you think about putting schema definitions to particular *-adapters modules?
Leaving non matching in common-adapters?
It may work and be pretty elegant, closer toward micro services.


Add the creation of a ceilometer user in the host for allow connectin…

…g to libvirt

change looks fine. it would be nice to refactor this role to match the task organization of the roles in this repo as it relates to separating tasks by their functionality (configure, install, run, etc).

Taking this suggestion into Jira

recheck

/recheck

/recheck

recheck


HBASE-27756 Make request guardrail configs in RSRpcServices live updatable

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 58s
branch-2 passed

+1 :green_heart:
compile
0m 35s
branch-2 passed

+1 :green_heart:
shadedjars
4m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 11s
root in the patch failed.

-1 :x:
compile
0m 22s
hbase-server in the patch failed.

-0 :warning:
javac
0m 22s
hbase-server in the patch failed.

-1 :x:
shadedjars
3m  7s
patch has 17 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 20s
hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

_ Other Tests _

-1 :x:
unit
0m 22s
hbase-server in the patch failed.

15m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5152

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 607f3cc276bb 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 753eaefa29

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/testReport/

Max. process+thread count
71 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 11s
branch-2 passed

+1 :green_heart:
compile
0m 56s
branch-2 passed

+1 :green_heart:
shadedjars
5m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 54s
root in the patch failed.

-1 :x:
compile
0m 31s
hbase-server in the patch failed.

-0 :warning:
javac
0m 31s
hbase-server in the patch failed.

-1 :x:
shadedjars
3m 51s
patch has 17 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-server generated 1 new + 84 unchanged - 0 fixed = 85 total (was 84)

_ Other Tests _

-1 :x:
unit
0m 37s
hbase-server in the patch failed.

20m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5152

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5b9b28f62d33 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 753eaefa29

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/testReport/

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 25s
branch-2 passed

+1 :green_heart:
compile
3m  2s
branch-2 passed

+1 :green_heart:
checkstyle
0m 45s
branch-2 passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 55s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 53s
root in the patch failed.

-1 :x:
compile
0m 32s
hbase-server in the patch failed.

-0 :warning:
javac
0m 32s
hbase-server in the patch failed.

+1 :green_heart:
checkstyle
0m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 44s
The patch causes 17 errors with Hadoop v2.10.2.

-1 :x:
hadoopcheck
3m 34s
The patch causes 17 errors with Hadoop v3.2.4.

-1 :x:
hadoopcheck
5m 32s
The patch causes 17 errors with Hadoop v3.3.4.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
0m 26s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

23m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5152

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 62218d64ebf2 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 753eaefa29

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 32s
branch-2 passed

+1 :green_heart:
compile
2m 23s
branch-2 passed

+1 :green_heart:
checkstyle
0m 36s
branch-2 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 29s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
2m 23s
the patch passed

+1 :green_heart:
javac
2m 23s
the patch passed

+1 :green_heart:
checkstyle
0m 36s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 42s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

38m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5152

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux e20a19ef2721 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 753eaefa29

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 35s
branch-2 passed

+1 :green_heart:
compile
0m 35s
branch-2 passed

+1 :green_heart:
shadedjars
4m 24s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
shadedjars
4m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
195m 29s
hbase-server in the patch passed.

216m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5152

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0a48fac062cc 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 753eaefa29

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/testReport/

Max. process+thread count
2493 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 58s
branch-2 passed

+1 :green_heart:
compile
1m  8s
branch-2 passed

+1 :green_heart:
shadedjars
5m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
237m 31s
hbase-server in the patch passed.

266m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5152

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2d7922f747af 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 753eaefa29

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/testReport/

Max. process+thread count
2236 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5152/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


FindProtobuf: Fix protobuf_generate_*() to handle subdirs

The change in commit d4b8e81 incorrectly adds subdirectories to the
path of the generated files when .proto files are passed to
protobuf_generate_() with subdirectories. This behavior is not correct
when PROTOBUF_GENERATE_CPP_APPEND_PATH is True (default behavior) as
protoc will generate output file in the current build directory.

Thanks!  I've backported this for merge to the release branch for 3.7.0-rc2.  See commit 2b9dad694a43d850af5fe83dd327fc82db29a012.  Once it goes through our nightly testing I'll merge it to master and then to release.
BTW, please see CONTRIBUTING.rst for the preferred contribution path in the future.


Update overview.md

I'd like to post a survey on the learn page to capture the response from users that are not directly in touch with us.  The survey is not about the content directly, but will help us to understand how can we improve the SPE onboarding
Category

[ ] Content fix
[ ] New article
[x] Example checked item (delete this line)

DELETE THIS LINE BEFORE SUBMITTING | For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

DELETE THIS LINE BEFORE SUBMITTING | If this fixes (aka: closes) or references an issue, please reference it here. This helps maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.

What's in this Pull Request?

DELETE THIS LINE BEFORE SUBMITTING | Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Submission guidelines

!!IMPORTANT!! - All submissions must complete the baseline sections included in this template. Ignoring or deleting this template may result in closing the issue with the label type:incomplete-submission.
Follow our guidance on How To Create Good Pull Requests.
Target the main branch of this repo.
When changing a page, ensure you update the ms.date front matter wih the current date in the format MM/DD/YYYY.
Review all build checks and address the automated errors, warnings, and suggestions.
NOTE: The live site is based on the live branch. Site owners periodically refresh live branch from the main branch so merged PRs won't immediately appear on the live site. Please be patient to see your changes appear on the live site.

DELETE THIS SECTION BEFORE SUBMITTING

@andrewconnell @cindylay hey, can ew please push this one?

@cindylay can you comment on this?
Respectfully, I can't tell who @Tiptioka is from the GH profile & with no history, not sure if the PG is ok adding a survey to the SPE homepage in the dev docs.
Just making sure before I merge this...

This is from Olesea @Tiptioka  on our design team. I'm good with these changes!

@cindylay can you comment on this?
Respectfully, I can't tell who @Tiptioka is from the GH profile & with virtually no history on GH, I'm not sure if the PG is ok adding a survey to the SPE homepage in the dev docs.
Just making sure before I merge this...

This looks good to me! @Tiptioka I believe is Olesea from our design team since she was trying to make this change

Hey @cindylay @andrewconnell  Thanks. When will we see the change on the learn pages?

Microsoft periodically does pushes to live... I'll ping the team responsible just to make sure they're aware.

Thanks


Dockerfile: Update to 1.642.3

Signed-off-by: Gianpaolo Macario<EMAIL_ADDRESS>

Adjusted commit log, superseded by PR https://github.com/jenkinsci/docker/pull/233


Switch setLifecycleCallback setter for Croutons to use a fluent interface

This will allow the lifecycle callback setter to be chained into a Crouton creation statement like the setOnClickListener and setConfiguration already are.

See README for further info.