[Card Settings] 🐛 Damaged flow is saying it will immediately cancel the card, rather than saying it will continue to work until the new card is activated

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1703265858599339
Action Performed:

Navigated to wallet
Tapped Expensify Card row
Selected Report physical card loss / damage
Selected My card was damaged

Expected Result:
The copy should explain that the damaged card will remain active until the new one is activated button should say Ship card
Actual Result:
We're showing the same copy / button as we do for a stolen card, which is a different flow that immediately cancels the card and ships a new card with a different PAN
Screenshots/Videos

CC @JKobrynski can you comment so I can assign?

[This is the relevant file (https://github.com/Expensify/App/blob/9208c95e3c9b375897e7133696ffcdb07b67fb74/src/pages/settings/Wallet/ReportCardLostPage.js#L80)for tracking
What needs to be changed:
There are two flows here depending on the first choice:  Lost/Stolen OR Damaged. Both flows will still make the same API call.
LOST/STOLEN

copy under address confirmation reads: "Your current card will be permanently deactivated as soon as your order is placed. Most cards arrive in a few business days."
button copy reads: "Deactivate card"
after pressing button, the current physical card should be in DEACTIVATED state and the new physical card should be in NOT ACTIVATED state

DAMAGED

copy under address confirmation reads: "Your new card will arrive in 2-3 business days, and your existing card will continue to work until you activate your new one."
button copy reads: "Ship new card"
after pressing button, the current physical card should be in ACTIVE state (3) and the new physical card should be in NOT ACTIVATED state

bumped here https://expensify.slack.com/archives/C03UK30EA1Z/p1704227935701489?thread_ts=1703268549.160679&cid=C03UK30EA1Z

bumped in slack, should get this assigned out soon!

If not, I'll make this internal

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

The PR is ready for review!

Looks like we're waiting on @grgia for review here!

@hoangzinh offer sent, lmk when you accept
https://www.upwork.com/jobs/~017041742568c125cc

All set


angular2 tree

Things todo:

docs
sorting of motions in the motion list

This library has some quirks:

The drop placeholder is awful. Nice is to drop one one onto another.
If you change children, some kind of loading-node appears. IDK what that is and there are already questions (unanswered) about this

--> We need a solution from angular cdk...
But you can have a first look

This is the temporary solution mentioned in #4017

@emanuelschuetze Done.

Ok.

@tsiegleauq The error is fixed. what do you mean by swapping? You just can d&d and not swap items in the tree

@tsiegleauq I'll merge to get the other PR ready. Please make an issue for this, if this occurrs again.


Migrate common tests to JUnit 5

https://github.com/netty/netty/issues/10757#issuecomment-848445551

@hyperxpro Your comments should be addressed now - this was the last module I worked on before sleeping, so it seems my eyes gave up on a few lines :stuck_out_tongue:

@kashike thanks a lot!


Proper way to test shipped binaries

Over on the https://github.com/ssciwr/clang-tidy-wheel I've run into trouble testing the binary that's shipped with the wheel.
The get_executable stuff in the package does not append .exe on windows. If we use subprocess.run on the resulting absolute path that fails. If you use subprocess.run just on the command name and rely on it being in PATH, windows will silently add .exe.  I've found this out because in the test I use something like
exe = clang_tidy._get_executable("clang-tidy")
subprocess.run([exe])

Note that in the format tests here, the command name form is used. In fact the clang_format package is never imported.
This might execute the right binary, but depends on ordering in PATH. clang-format is also installed in the windows base image.
I suspect the situation on MacOS might be similar if the build results in a clang-tidy.{bin,dmg}, but haven't checked yet.
I think using the full absolute path in the tests is the correct way to do it. And once I got it all fixed on the tidy side, I would PR a matching update here.

The resulting binaries that actually get run on macOS don't have an extension. (.dmg is a disk image and sort of acts like a zip/tar archive for distributing apps; .app is just a folder whose contents have a special structure; .pkg is an installer)


Fixed typo in clock.runAll error

Error would previously say "Aborting after running 1000timers, assuming an infinite loop!" (notice the lack of space between 1000 and timers). Adding a space there.
Fixes #93.

thanks!


Add pull request template

High Level Overview of Change
Add a pull request template for this GitHub repository.
GitHub documentation about PR templates
Context of Change
This was inspired by the development team's conversation about how it is sometimes difficult for PR reviews to get the necessary context in order to effectively review the main part of a PR. We feel that more descriptive PRs may be helpful in helping reviewers and QA testers to quickly understand the "big picture" of each PR.
This is functionally similar to the issue templates that were added earlier: https://github.com/ripple/rippled/pull/3246
The difference is that this is tailored for pull requests.
Type of Change

[x] New feature (non-breaking change which adds functionality) - adds template when creating new GitHub PR
[x] Documentation Updates

Before / After
When creating a new PR, you would get a blank text field, which results in short PR descriptions, sometimes lacking in helpful detail.
Now, the text field is pre-populated with a template that inspires PR authors to write helpful content for code reviewers and other stakeholders.
Test Plan
Aside from a couple minor edits to make it more relevant to rippled, this template is substantially the same as the one used by xpring-eng:
https://raw.githubusercontent.com/xpring-eng/.github/master/.github/pull_request_template.md
Here are a few random examples of PRs that used this template:

https://github.com/xpring-eng/Xpring-SDK-Demo/pull/34
https://github.com/xpring-eng/xpring.io/pull/101
https://github.com/payid-org/payid/pull/568

I am wondering if we should have an optional section where the author can specify areas or aspects of the code that they would like special attention paid to during the review. This would be useful for larger pull requests, where it's hard for reviewers to rigorously review every piece of code. For smaller pull requests, I will trace through the code to try to find subtle bugs. But for larger pull requests, it's infeasible for one reviewer to trace through every line of code. It would be nice if the author could highlight areas of the code that they would like extra attention paid to. Or maybe the author would like to solicit input on some design decision that the author made that they are not quite so sure about. I know when I create a pull request, there are areas of the code I am happy with, and other areas where I'm not quite as happy with and would like input from the team.

I'm fine with, but not excited about, this possible change.  Personally, I feel like I already include a lot of information in my pull request descriptions.  I don't know that the template will improve the descriptions that I, or anyone else on the team, will write.
A template can be useful if it acts like a check list.  But it also can act like a filter.  If people only fill in the information requested by the template then they may omit other useful information.
I'm also not thrilled with the idea that the author of a pull request necessarily knows how hard, or where, a pull request should be reviewed.  I've reviewed pull requests that the author thought was trivial but actually had, for example, threading problems.  The author frequently has a blind spot that a reviewer may reveal.  It would be counterproductive to pre-bias the reviewer away from that blind spot.
I guess my take is that we should encourage authors of pull requests to write up good pull request notes.  And if reviewers have additional questions those questions should be raised in the code review.


login to authenticate from a third party server before trying methods

I have been working on a Spring MVC project and try to document it using swagger2. Although every thing goes well, when I want to try methods using 'Try it out' button, I encounter an authentication problem. We are using a third party project in a different Url in order to generate token which is needed in header to run methods. I have searched and come up with different solutions which are changing the swagger-ui.html but I wanna know if there is another solution such as using the SecurityScheme in configuring the Docket in server side. We are using basic authentication but when I try to use BasicAuth in Springfox.Documentation.Service it doesn't make any change. In our project users should login using their username and password and ask for token from the third party project which is accessible from different url. Then, they can simply put it in the header and run every methods in the project they want.

@mohaFazel The support for this is kinda sketchy in swagger-ui. You might get better answers on how to do this in the swagger-ui project.


Az Bot authsetting creates AADv2 connection but does not populated the fields

Project
Virtual Assistant
Description
Using the az bot command to create authsettings, the fields are not populated correctly. No errors, creation went through. The documentation that I used is https://github.com/Microsoft/AI/blob/master/solutions/Virtual-Assistant/docs/virtualassistant-createvirtualassistant.md on skills authentication
To Reproduce

Key in this command:- az bot authsetting create --resource-group YOUR_BOT_NAME --name YOUR_BOT_NAME --setting-name "YOUR_AUTH_CONNECTION_NAME" --client-id "YOUR_APPLICATION_ID" --client-secret "YOUR_APPLICATION_PASSWORD" --provider-scope-string "Calendars.ReadWrite Mail.Read Mail.Send Notes.ReadWrite People.Read User.Read" --service Aadv2
Oauth created with correct name, but client ID, client secret and tenant ID is not created properly(blanked)

Expected behavior
The created oauth settings supposed to have the fields populated.
Screenshots
https://user-images.githubusercontent.com/5702935/47987297-81f11c00-e122-11e8-9dba-592d7bac55f8.png
<!--If applicable, add screenshots to help explain your problem.--
![image](https://user-images.githubusercontent.com/5702935/47987297-81f11c00-e122-11e8-9dba-592d7bac55f8.png)
>
https://user-images.githubusercontent.com/5702935/47987297-81f11c00-e122-11e8-9dba-592d7bac55f8.png

**Additional context**
https://user-images.githubusercontent.com/5702935/47987297-81f11c00-e122-11e8-9dba-592d7bac55f8.png

@cbtham Can you click Test Connection and see if it works? It would appear that the command line tools setting the values causes them to be "hidden" in the portal, confusing and I'll see if this is by design

@cbtham I figured out the issue that caused this and update the docs with the fix

Project
Virtual Assistant
Description
Using the az bot command to create authsettings, I have a related issue when I try to create the AADv2 connection. It doesn't run for me. I get the error below
To Reproduce

Key in this command:- az bot authsetting create --resource-group YOUR_BOT_NAME --name YOUR_BOT_NAME --setting-name "YOUR_AUTH_CONNECTION_NAME" --client-id "YOUR_APPLICATION_ID" --client-secret "YOUR_APPLICATION_PASSWORD" --provider-scope-string "Calendars.ReadWrite Mail.Read Mail.Send Notes.ReadWrite People.Read User.Read" --service Aadv2
Command doesn't work. I end up with error below.

az bot authsetting create: error: the following arguments are required: --provider-scope-string, --service
usage: az bot authsetting create [-h] [--verbose] [--debug]
[--output {json,jsonc,table,tsv,yaml,none}]
[--query JMESPATH] --resource-group
RESOURCE_GROUP_NAME --name NAME
--setting-name CONNECTION_NAME --client-id
CLIENT_ID --client-secret CLIENT_SECRET
--provider-scope-string SCOPES --service
SERVICE_PROVIDER_NAME
[--parameters PARAMETERS [PARAMETERS ...]]
[--subscription _SUBSCRIPTION]
Expected behavior
The aadv2 connection should be created and oauth settings fields populated.

Hi @awaemmanuel, this is likely because your client secret contains special characters that need to be escaped and it is blocking the provider-scope-string and service params. Try moving your client-secret param to the end and escaping. Here are some different escape methods for the different command line tools:
For Windows command prompt, enclose the client-secret in double quotes. e.g. ... --client-secret "!|%gr%"
For *Windows PowerShell, try passing in client-secret after the --% argument. e.g. ... --% --appSecret "!|%gr%"
For MacOS or Linux, enclose the appSecret in single quotes. e.g. ... --appSecret '!|%gr%'


Notification service

#542 #543 #544 #545
Added the settings page (front-end only)
Changelog:

Added Settings in the User's dropdown menu
Added Notifications icon
Settings menu will go to the appropriate page that lets the user choose which notifications are available to them
Notifications icon goes to a blank page for now
Save in the Notifications page prepares the data to submit, but doesn't really submit yet.
FontAwesome css updated.

 Navigation | Create Settings page |2|

 Navigation | Create Settings page |2|

 Notifications | Select the types of actions that will trigger a notification |8|

 Navigation | Access My Notifications |2|

 Notifications | Implement notifications badge |5|


Area 2 Map

Designer-->An Area 2 map that can be similar to the last: start player in the south, and put Castle in the middle-back.
-->Is there a way to give this map a "colder" feel?
Animator/Artist --> A storm "overlay" for this map
Sound -> Storm audio
See design doc for more context:
https://docs.google.com/document/d/1pR9PLLrS4NxCNCBC2EqR4rsC7BtZ7ym85IjhC7at_sM/edit?ts=5aa946ee#bookmark=id.lzhlmhaar9d1

@lunar-rane @Ember-Rane Snow grass tiles made.  Finishing setting up the map now...

Created a feature/30 branch and pushed it with all necessary tools to start building this map

Wrapped up audio, but merged it all funky into #37 so best case scenario is that I clean it up after all the other scenes are in.


Create Anaconda distribution

We should create an auto-deployed Anaconda distribution of mapboxgl-jupyter.  Data scientists and analysts frequently use the Anaconda distribution of Python.
Process: https://conda.io/docs/user-guide/tutorials/build-pkgs-skeleton.html

Inital conda version of mapboxgl-jupyter is published at:
conda install -c rsbaumann mapboxgl
To Do

[ ] Check distribution on python 2_7 and 3_5+, and on macOS vs. Windows vs. Linux
[ ] Add docs to deploy process, or webhook to autodeploy
[ ] Use mapbox conda organization cc @sgillies @perrygeo

I would recommend publishing this to conda-forge. Its a set of community maintained recipes that will also build the conda packages for win, osx, and linux and publish it to the conda-forge channels where some anaconda users get packages.
The process is relatively simple: take the conda recipe and make a PR.
You can read more about here: https://github.com/conda-forge/staged-recipes

Excellent, thanks for the tip @danielfrg.  conda-forge it is.

Yeah, 👍 on conda-forge. I know some of the principals and they've won me over, at least for getting Rasterio into the hands of desktop and notebook users.

@ryanbaumann Short term, I'm not finding it in your rsbaumann channel via conda
!conda install -c rsbaumann mapboxgl -y

Fetching package metadata .................

PackageNotFoundError: Packages missing in current channels:

  - mapboxgl

We have searched for the packages in the following channels:

  - https://conda.anaconda.org/rsbaumann/win-64
  - https://conda.anaconda.org/rsbaumann/noarch
  - https://conda.anaconda.org/esri/win-64
  - https://conda.anaconda.org/esri/noarch
  - https://repo.continuum.io/pkgs/main/win-64
  - https://repo.continuum.io/pkgs/main/noarch
  - https://repo.continuum.io/pkgs/free/win-64
  - https://repo.continuum.io/pkgs/free/noarch
  - https://repo.continuum.io/pkgs/r/win-64
  - https://repo.continuum.io/pkgs/r/noarch
  - https://repo.continuum.io/pkgs/pro/win-64
  - https://repo.continuum.io/pkgs/pro/noarch
  - https://repo.continuum.io/pkgs/msys2/win-64
  - https://repo.continuum.io/pkgs/msys2/noarch

I'll get a version out on Conda-Forge with the latest updates and drop in the readme (and this ticket) ASAP @DruidSmith.  In the meantime you can start with pip install mapboxgl

+1 for conda forge

Please upload for ubuntu linux 64 bit version as well.
conda install -c rsbaumann mapboxgl
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

- mapboxgl

Current channels:

  - https://conda.anaconda.org/rsbaumann/linux-64
  - https://conda.anaconda.org/rsbaumann/noarch
  - https://repo.anaconda.com/pkgs/main/linux-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/free/linux-64
  - https://repo.anaconda.com/pkgs/free/noarch
  - https://repo.anaconda.com/pkgs/r/linux-64
  - https://repo.anaconda.com/pkgs/r/noarch
  - https://repo.anaconda.com/pkgs/pro/linux-64
  - https://repo.anaconda.com/pkgs/pro/noarch

 To search for alternate channels that may provide the conda package you're
looking for, navigate to

https://anaconda.org

and use the search bar at the top of the page.

Thanks.

I didn't upload a win-64 version yet. I'll get a version out on Conda-Forge with the latest updates (v0.6.0 releasing by Sunday) and drop in the readme for this repo ASAP @DruidSmith.
In the meantime, you can install with pip install mapboxgl.

Has this been resolved?

Looks like: I can install it with conda install -c conda-forge mapboxgl
see https://anaconda.org/conda-forge/mapboxgl


utils.set_activation_checkpointing is unnecessarily restrictive

The API enforces that the wrapping policy just be a set of modules, which is sufficient for a few use cases but the underlying API offers more generality in terms of wrapping policies. We should expose this to our users or have them directly use apply_activation_checkpointing.

Closing it since PR was merged.


Unspecified required types

Now we can make the required types using parentheses or separated definitions. Is this the spec?
TypeScript Version:  master
Code
type PersonStrict = { name: string, age: number };
type PersonPartial = { name?: string, age?: number };
type Required<T> = { [K in (keyof T)]: T[K] };
const person: Required<PersonPartial> = { name: "iwata" };

or
...
type Keys<T> = keyof T;
type Required<T> = { [K in Keys<T>]: T[K] };
const person: Required<PersonPartial> = { name: "iwata" };

index.ts(4,7): error TS2322: Type '{ name: string; }' is not assignable to type 'Required<PersonPartial>'.
  Property 'age' is missing in type '{ name: string; }'.

cc @ahejlsberg @weswigham

No, that is an unintended effect and it will no longer be the case with #12826. Also, it doesn't really work because you can't get rid of the undefined that was added to each property type by Partial<T>.

I see, thanks for the answer.

Do you fix this effect? This will be a breaking change after many users found this and use as a hack.

We reserve the right to make back compat breaks for things that are effectively bugs. "Things behaved differently when I added parentheses which should have been meaningless" isn't something anyone should have taken a dependency on.


compat-sap-c++-9 appears to be not available in RHEL 8.0.

We are not even installing compat-sap-c++-9 in RHEL 8 in this role. But we are installing it in sap-preconfigure. See

solved in https://github.com/berndfinger/sap-preconfigure/commit/f0f27af20a24e853cc7585f756760d2749e7a9cf .


Status message is not supported on HTTP/2

Addresses #1253
Logic example for different behaviour depending on http version taken from #1262

@dead-horse @fl0w any feedback on this?

can you add a test case for this change?

@dead-horse done


⚠ Bofrost.de has degraded performance

In 6b0ad58, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 964 ms

Resolved: Bofrost.de performance has improved in aba0767 after 304 days, 0 hours, 55 minutes.


need to remove hard types

:tada: This issue has been resolved in version 7.31.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update OCaml template

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.

Motivation and Context
This year the FPV course wants to use Artemis with OCaml. The current OCaml template is rather simple and is missing some features that we would like to have.
Description

Prerequisite: Adding qcheck to the docker image in ls1intum/artemis-ocaml-docker#1
Add an qcheck example test
Add support for solution repository checkout
Add support for not running some tests during the submission period
Show build errors in student code instead of hiding all build output
Disallow symlinks in the submission to prevent students from just including the solution
Changing the template to make it easier for students to test and run their code with dune utop src

Steps for Testing

Log in to Artemis

Navigate to Course Administration

Navigate to some test course

Create a new OCaml exercise
Make sure to check the enable solution checkout box

Open the test repository and check that all these files exist *)
find .

.
./.ocamlformat
./assignment
./assignment/assignment.mli
./assignment/dune
./.gitattributes
./.gitignore
./run.sh
./solution
./solution/dune
./solution/solution.mli
./test
./test/dune
./test/test.ml

Wait for the builds to complete and check that both template and solution build, that the template passes 0/8 tests and that the solution passes 7/8 tests

Change the variables HIDDEN_START and HIDDEN_END in run.sh in the tests repo to not include the current date

Wait for the solution build to finish and check that it now passes 8/8 tests

Cleanup the exercise and course, if required

Review Progress

Prerequisites

[ ] Review and merge ls1intum/artemis-ocaml-docker#1
[ ] Push the update docker image

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage
I adjusted the excludes on the existing tests as far as i could tell what they were supposed to do and why ocaml/haskell were ex/included. There may be other places that i missed

Notes
*)
I hacked around to get artemis to create the repos without a CI, and confimed that it skips files without a dot and fixed the templates. The rest of this note is not really relevant for this PR anymore.

there are a bunch of special cases for template file names in https://github.com/ls1intum/Artemis/blob/6a7b15dc49cda4477cee17cfe622f2ec352f786a/src/main/java/de/tum/in/www1/artemis/service/FileService.java#L332-L354, but i am not sure why exactly and for what they are required.
While they appear to exist for all files that don't follow the name.ext format this doesn't appear to truly be necessary since the previous version of the template contained a .merlin file that was included in the template just fine without a special case.
The only potential issue i could spot is the pattern *.* in https://github.com/ls1intum/Artemis/blob/6a7b15dc49cda4477cee17cfe622f2ec352f786a/src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseService.java#L271-L273 which if the matcher doesn't special case to mean any file like on windows, could exclude files without a dot in the name. But that doesn't explain most of the special cases, or why the patterns isnt simply changed to /** or /**/*.
In the end i opted to leave files as is (other than gits files) and the just see what happens. I would have tests things locally but i don't have an bitbucket instance to test with and i don't know about artemis to make it work anyways.

Superseded by #4068


Input bar relayouting

Codecov Report

Merging #620 into master will increase coverage by 0.17%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   60.59%   60.76%   +0.17%
==========================================
  Files          92       92
  Lines        4875     4881       +6
==========================================
+ Hits         2954     2966      +12
+ Misses       1921     1915       -6

Impacted Files
Coverage Δ

...Source/ChatController/BaseChatViewController.swift
69.2% <71.42%> (+0.65%)
:arrow_up:

...Chat Items/TextMessages/Views/TextBubbleView.swift
86.22% <0%> (+3.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b0e5d...9c38775. Read the comment docs.

Please, don't merge yet.


[polarion] Allow users pass extra custom-fields

Jump has --custom-fields argument that is set here in the polarion role.


CLI Version

Hi, there are a cli version for plex-rich-presence ?
Because I would like to create a docker container to run the software h24.

Hello,
No there isn't one yet. I'll definetly do it in the upcoming rewrite !

Hello,
I was triaging issues as I am planning the rewrite and I think that your use case of running you app in a docker container is not possible.
To trigger the rich presence, my app sends a signal to a discord client running on the same machine, I don't see how that could work in a docker container ?

Hello, I was triaging issues as I am planning the rewrite and I think that your use case of running you app in a docker container is not possible. To trigger the rich presence, my app sends a signal to a discord client running on the same machine, I don't see how that could work in a docker container ?

A discord install in a docker container with X11 (the overkill thing :D )

Okay I see, did not think about that !
I'll definetly include this in the new version given the low effort required.
Once done, I'd be interested if you documented your docker setup :p

Okay I see, did not think about that ! I'll definetly include this in the new version given the low effort required. Once done, I'd be interested if you documented your docker setup :p

Check this https://github.com/davidk/docker-discord

there is this too, but i don't know if it would work, https://www.npmjs.com/package/discord-rpc

ok


[BUG] Build is broken

Ope!
Possibly related to iPlug2.
Updating the submodule as in #341 and #370 may do it?

Just looks like a random CI failure to me

Agreed. Re-run worked
Whew.


fix: fix for the zoom out and more smooth/controlled zoom update

zoomsnap attribute added for the zoom out issue and more controlled zoom

closed for the reorganization on the branch, will reopen that


Icon align prop

Fixes 1472.

Changes proposed in this Pull Request:

Added iconAlign prop (like textAlign) that aligns the icon when avatar prop is set to false. This prop is set to left by default
Added story, doc, changlog... marking as a draft until I figure out how to do the git submodule thing

Screenshots:
Under LTR and dark mode.
Note that the drawer menu items did not get any settings on it; the only things changed in this screenshot are those in the list of info list items. Look how nicely aligned they are :)

Works great! My only question is do we want these to be 'left' 'center' 'right', or 'start' 'center' 'end'? I only ask because i looked at it in RTL and it was backwards to what the prop says (technically).

Should I do 'left' | 'start' | 'center' | 'right' | 'end' then? :P
I am happy with either way -- we are having "left component" "right component" etc, so I think it should be fine to leave it that way

Works great! My only question is do we want these to be 'left' 'center' 'right', or 'start' 'center' 'end'? I only ask because i looked at it in RTL and it was backwards to what the prop says (technically).

Should I do 'left' | 'start' | 'center' | 'right' | 'end' then? :P
I am happy with either way -- we are having "left component" "right component" etc, so I think it should be fine to leave it that way

Good point...I'm fine with it as is


Feature: Added download svg for player cards

I have submitted a pull request that includes a new feature for downloading player card images in SVG format using the html-to-image library. The decision to use SVG format was made to maintain image quality, however, it is also possible to download the images in PNG format (changes on the code), but this may result in a loss of image quality. I apologize for any issues or inconvenience caused by the implementation of this feature. To ensure that the card images would not be cropped when downloaded, I had to take the following steps:

placed the card inside a container
extracted the url
then returned the card back to its original position

By doing this, I was able to download the player card images without any cropping or loss of quality.
This is my first time working with Astro, and I was not entirely familiar with the best practices for adding event listeners. As a result, I used a basic selector by using querySelector and added the listeners that way.
When hover on player card:

If button is clicked:

Svg saved:

Amazing!


Upgrading from v6.1, Error "volume name is too short"

Hi,
I'm currently running v6.1 and when trying to upgrade to v6.4, I got this error.
Status: Downloaded newer image for mattermost/mattermost-team-edition:6.4
Creating postgres_mattermost ... done
Creating mattermost          ... error

ERROR: for mattermost  Cannot create container for service mattermost: create .: volume name is too short, names should be at least two alphanumeric characters

ERROR: for mattermost  Cannot create container for service mattermost: create .: volume name is too short, names should be at least two alphanumeric characters
ERROR: Encountered errors while bringing up the project.

Steps to reproduce:

I have a running 6.1 instance with modified docker-compose.yml, .env and docker-compose.without-nginx.yml
When I tried to git pull, it asked to commit or stash, because docker-compose.yml has been changed, so i did git commit
then git pull
In .env, i changed MATTERMOST_IMAGE_TAG=6.1 to MATTERMOST_IMAGE_TAG=6.4
sudo docker-compose -f docker-compose.yml -f docker-compose.without-nginx.yml up -d
Then I got the above error message. Now, even changing MATTERMOST_IMAGE_TAG back to 6.1 would have the same error.

How can I fix it?
Thanks!
P.S. I have a btrfs snapshot in place, so I can easily go back to the working state (v6.1), ok to experiment with any recommendation.
Here are the config files:
docker-compose.yml
# https://docs.docker.com/compose/environment-variables/

version: "2.4"

services:
  postgres:
    container_name: postgres_mattermost
    image: postgres:${POSTGRES_IMAGE_TAG}
    restart: ${RESTART_POLICY}
    security_opt:
      - no-new-privileges:true
    pids_limit: 100
    read_only: true
    tmpfs:
      - /tmp
      - /var/run/postgresql
    volumes:
      - ${POSTGRES_DATA_PATH}:/var/lib/postgresql/data
    environment:
      # timezone inside container
      - TZ

      # necessary Postgres options/variables
      - POSTGRES_USER
      - POSTGRES_PASSWORD
      - POSTGRES_DB

  mattermost:
    depends_on:
      - postgres
    container_name: mattermost
    image: mattermost/${MATTERMOST_IMAGE}:${MATTERMOST_IMAGE_TAG}
    restart: ${RESTART_POLICY}
    security_opt:
      - no-new-privileges:true
    pids_limit: 200
    read_only: ${MATTERMOST_CONTAINER_READONLY}
    tmpfs:
      - /tmp
    volumes:
      - ${MATTERMOST_CONFIG_PATH}:/mattermost/config:rw
      - ${MATTERMOST_DATA_PATH}:/mattermost/data:rw
      - ${MATTERMOST_LOGS_PATH}:/mattermost/logs:rw
      - ${MATTERMOST_PLUGINS_PATH}:/mattermost/plugins:rw
      - ${MATTERMOST_CLIENT_PLUGINS_PATH}:/mattermost/client/plugins:rw
      - ${MATTERMOST_BLEVE_INDEXES_PATH}:/mattermost/bleve-indexes:rw
      # When you want to use SSO with GitLab, you have to add the cert pki chain of GitLab inside Alpine
      # to avoid Token request failed: certificate signed by unknown authority
      # (link: https://github.com/mattermost/mattermost-server/issues/13059 and https://github.com/mattermost/docker/issues/34)
      # - ${GITLAB_PKI_CHAIN_PATH}:/etc/ssl/certs/pki_chain.pem:ro
    environment:
      # timezone inside container
      - TZ

      # necessary Mattermost options/variables (see env.example)
      - MM_SQLSETTINGS_DRIVERNAME=postgres
      - MM_SQLSETTINGS_DATASOURCE=postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@postgres:5432/${POSTGRES_DB}?sslmode=disable&connect_timeout=10

      # necessary for bleve
      - MM_BLEVESETTINGS_INDEXDIR

      # additional settings
      - MM_SERVICESETTINGS_SITEURL=***ommited***

# If you use rolling image tags and feel lucky watchtower can automatically pull new images and
# instantiate containers from it. https://containrrr.dev/watchtower/
# Please keep in mind watchtower will have access on the docker socket. This can be a security risk.
#
#  watchtower:
#    container_name: watchtower
#    image: containrrr/watchtower:latest
#    restart: unless-stopped
#    volumes:
#      - /var/run/docker.sock:/var/run/docker.sock

.env
# Domain of service
DOMAIN=***ommited***

# Container settings
## Timezone inside the containers. The value needs to be in the form 'Europe/Berlin'.
## A list of these tz database names can be looked up at Wikipedia
## https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
TZ=America/***ommited***
RESTART_POLICY=unless-stopped

# Postgres settings
## Documentation for this image and available settings can be found on hub.docker.com
## https://hub.docker.com/_/postgres
## Please keep in mind this will create a superuser and it's recommended to use a less privileged
## user to connect to the database.
## A guide on how to change the database user to a nonsuperuser can be found in docs/creation-of-nonsuperuser.md
POSTGRES_IMAGE_TAG=13-alpine
POSTGRES_DATA_PATH=./volumes/db/var/lib/postgresql/data

POSTGRES_USER=mmuser
POSTGRES_PASSWORD=***ommited***
#POSTGRES_PASSWORD=***ommited***
POSTGRES_DB=mattermost

# Nginx
## The nginx container will use a configuration found at the NGINX_MATTERMOST_CONFIG. The config aims
## to be secure and uses a catch-all server vhost which will work out-of-the-box. For additional settings
## or changes ones can edit it or provide another config. Important note: inside the container, nginx sources
## every config file inside */etc/nginx/conf.d* ending with a *.conf* file extension.

## Inside the container the uid and gid is 101. The folder owner can be set with
## `sudo chown -R 101:101 ./nginx` if needed.
NGINX_IMAGE_TAG=alpine

## The folder containing server blocks and any additional config to nginx.conf
NGINX_CONFIG_PATH=./nginx/conf.d
NGINX_DHPARAMS_FILE=./nginx/dhparams4096.pem

#CERT_PATH=./volumes/web/cert/cert.pem
#KEY_PATH=./volumes/web/cert/key-no-password.pem
#GITLAB_PKI_CHAIN_PATH=<path_to_your_gitlab_pki>/pki_chain.pem
CERT_PATH=./certs/etc/letsencrypt/live/${DOMAIN}/fullchain.pem
KEY_PATH=./certs/etc/letsencrypt/live/${DOMAIN}/privkey.pem

## Exposed ports to the host. Inside the container 80 and 443 will be used
#HTTPS_PORT=***ommited***
#HTTP_PORT=***ommited***

# Mattermost settings
## Inside the container the uid and gid is 2000. The folder owner can be set with
## `sudo chown -R 2000:2000 ./volumes/app/mattermost`.
MATTERMOST_CONFIG_PATH=./volumes/app/mattermost/config
MATTERMOST_DATA_PATH=./volumes/app/mattermost/data
MATTERMOST_LOGS_PATH=./volumes/app/mattermost/logs
MATTERMOST_PLUGINS_PATH=./volumes/app/mattermost/plugins
MATTERMOST_CLIENT_PLUGINS_PATH=./volumes/app/mattermost/client/plugins

## This will be 'mattermost-enterprise-edition' or 'mattermost-team-edition' based on the version of Mattermost you're installing.
MATTERMOST_IMAGE=mattermost-team-edition
MATTERMOST_IMAGE_TAG=6.4

## Make Mattermost container readonly. This interferes with the regeneration of root.html inside the container. Only use
## it if you know what you're doing.
## See https://github.com/mattermost/docker/issues/18
MATTERMOST_CONTAINER_READONLY=false

## The app port is only relevant for using Mattermost without the nginx container as reverse proxy. This is not meant
## to be used with the internal HTTP server exposed but rather in case one wants to host several services on one host
## or for using it behind another existing reverse proxy.
APP_PORT=***ommited***

## Configuration settings for Mattermost. Documentation on the variables and the settings itself can be found at
## https://docs.mattermost.com/administration/config-settings.html
## Keep in mind that variables set here will take precedence over the same setting in config.json. This includes
## the system console as well and settings set with env variables will be greyed out.

## Below one can find necessary settings to spin up the Mattermost container
MM_SQLSETTINGS_DRIVERNAME=postgres
MM_SQLSETTINGS_DATASOURCE=postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@postgres:5432/${POSTGRES_DB}?sslmode=disable&connect_timeout=10

## Example settings (any additional setting added here also needs to be introduced in the docker-compose.yml)
MM_SERVICESETTINGS_SITEURL=https://${DOMAIN}

Just found out the latest commit as of 2022-02-22 was still from 2021-12-17, which is probably of version 6.1.
So the error was probably because I got myself a little bit too ahead. Will test again when there are more commits in the main branch.

I have the same problem. I tried to update from 6.3.2 to 6.3.4 and get the same Error.

Well, i gave it another try with MATTERMOST_IMAGE_TAG=6.4 and the problem is gone now.
Case closed.

I have checked the changes after a "git pull". You have to add the folder "bleve-indexes" under "volumes/app/mattermost" and change the rights with "chown -cR 2000:2000 bleve-indexes".
In the file ".env" under the entry "MATTERMOST_CLIENT_PLUGINS_PATH=./volumes/app/mattermost/client/plugins" you have to add the following:
MATTERMOST_BLEVE_INDEXES_PATH=./volumes/app/mattermost/bleve-indexes
Bleve index (inside the container)
MM_BLEVESETTINGS_INDEXDIR=/mattermost/bleve-indexes
Then the upgrade worked for me.

This problem comes back when i upgraded from 6.4 to 6.6, but only if i did a git pull.
I took VM snapshots to experiment, so after i changed the tag from 6.4 to 6.6 in .env:

if I did git pull then docker-compose up -d, then this problem came up;
if I did docker-compose up -d directly, then the docker came up nicely

I have checked the changes after a "git pull". You have to add the folder "bleve-indexes" under "volumes/app/mattermost" and change the rights with chown -cR 2000:2000 bleve-indexes. In the file ".env" under the entry MATTERMOST_CLIENT_PLUGINS_PATH=./volumes/app/mattermost/client/plugins you have to add the following:
MATTERMOST_BLEVE_INDEXES_PATH=./volumes/app/mattermost/bleve-indexes
## Bleve index (inside the container) MM_BLEVESETTINGS_INDEXDIR=/mattermost/bleve-indexes
Then the upgrade worked for me.

You're right.
The doc on upgrading mentioned that:

Run git pull to fetch any recent changes to the repository, paying attention to any potential env.example changes.

So I compared my old .env with the latest one and found out the differences were indeed the part you quoted:
MATTERMOST_BLEVE_INDEXES_PATH=./volumes/app/mattermost/bleve-indexes

## Bleve index (inside the container)
MM_BLEVESETTINGS_INDEXDIR=/mattermost/bleve-indexes

And this explained why the log said "volume name is too short" as there was none specified.
So I added that to the .env file and it worked. In my case, I did not manually created the bleve-indexes directory as the docker did it by itself.
Thanks!
Case closed.


com_ptr::put_const method?

Most D3D APIs take a T *const *ppT parameter (i.e. an array of pointers). With WRL::ComPtr you could use operator& to get the argument to parse. C++/WinRT's com_ptr::put releases its reference before passing you a pointer to what it owns.
Which is safe, but this means you have to do the following dance when parsing only one pointer
auto pSrv = m_srv.get();
context.VSSetShaderResources(0, 1, &pSrv);

which is unnecessarily verbose, as you could provide
template <typename T>
struct com_ptr
{
    type* const* put_const() const noexcept
    {
        return &m_ptr;
    }
}

context.VSSetShaderResources(0, 1, m_srv.put_const());

I would argue against this because:

put const doesn't make it obvious to the reader what is happening here. The code is not actually putting anything.
it is inconsistent that all put methods releases the pointer, but this one doesn't

I'm not opposed to the idea, but it would need a different name.

as_const_c_array might be a bit inconsistent with the existing as/try_as methods.
Feel free to close if this is more bikeshedding than it is worth.
1-1 functionality with WRL::ComPtr would be nice though.

Something like addressof() would work better - and it's also the name used by wil. Have you considered using wil for your com_ptr?
Also I will point out that WRL::ComPtr's operator& does release the held object as well, according to docs.


Cache issues when upgrading to 0.1.25

With uv 0.1.25
$ uv pip install avro
error: Failed to download and build: avro==1.11.3
  Caused by: Failed to deserialize cache entry
  Caused by: expected version to start with a number, but no leading ASCII digits were found

With uv 0.1.24, this works fine.
Both commands were run with that avro package in the cache. Not sure if there was a change in the cache format that might've caused this.

Seeing a similar issue in a similar timeframe:
[2024-03-28T16:04:14Z] 5.288 error: Failed to download and build: pdpyras==5.2.0
[2024-03-28T16:04:14Z] 5.288   Caused by: Failed to deserialize cache entry
[2024-03-28T16:04:14Z] 5.288   Caused by: expected version to start with a number, but no leading ASCII digits were found

Thanks for raising. We'll be addressing this immediately.


Update .travis.yml to allow builds on osx

Build only develop and master on OSX to prevent backlog for now.


Bump K8s and Controller Runtime Dependencies

RukPak is currently a few minor versions behind on both our k8s and controller-runtime dependencies. Upgrading these dependencies will introduce a number of breaking api changes, it would be nice to do this in advance before we uncover some change that is unnecessarily complicated by a requirement on this bump.

I'd recommend deferring this while we investigate kapp-controller


Discount Tag sizing

Refactor sizing for the Discount type of Tag:
We need to switch from using prop width  to size. Size should be equal to width and height.
Also, it may be a nice idea to automatically calculate width and height depending on the content, but it may have unexpected sizing behavior
The behavior we have now:

you like?


Update Invoke-Environment.ps1

Quote command.

Thank you but this change is not quite right.
Example: 1.cmd
@echo off
echo param1 %1
echo param2 %2

This works before you change:
Invoke-Environment.ps1 '1.cmd arg1 arg2' -Output

and gives:
param1 arg1
param2 arg2

With the suggested change it fails:
'"1.cmd arg1 arg2"' is not recognized as an internal or external command,
operable program or batch file.

In other words, you should add all required quotes in your Command parameters yourself, see the help comments example.

I agree that some improvements are needed in order to invoke a batch file in paths with spaces and with arguments with spaces and maybe with special characters with escaping. But this is not that straightforward. cmd /c is pain...

Yes, you are right, I neglected the arguments.

@nanoric
I created a related issue. It's time to make some improvements. I had some pain myself, even being the author :)

And it's done. Use the new parameter File with optional Arguments.


fix(TFD-265): change DatasetRuntime getSample method to enable stream…

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
The DatasetRuntime method implements Iterable<? extends IndexedRecord> getSample(int limit);
What is the new behavior?
The DatasetRuntime method implements void getSample(int limit, Function<IndexedRecord, Void>);
Does this PR introduce a breaking change?

[X] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Reimplement the getSample method to use callbacks instead of returning the iterable collection of records.
Other information:
…ing.

LGTM, please merge.


Framework 'CoreModules' not found in Xcode 16.0 after making Podfile changes to support Firebase SDK

Description
Xcode 16.0 fails to build for the iOS simulator given the following project: https://github.com/imann24/firebase-react-native-build-issues-repro
Steps to reproduce

Clone this project: https://github.com/imann24/firebase-react-native-build-issues-repro
npm install
cd ios
pod install
Open Xcode
Try to build for an iOS 18.0 simulator
Observe failure

React Native Version
0.75.4
Affected Platforms
Other (please specify)
Output of npx react-native info
info Fetching system and libraries information...
System:
  OS: macOS 15.0.1
  CPU: (8) arm64 Apple M1
  Memory: 101.78 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.19.0
    path: ~/.nvm/versions/node/v18.19.0/bin/node
  Yarn:
    version: 3.6.4
    path: ~/.nvm/versions/node/v18.19.0/bin/yarn
  npm:
    version: 10.2.3
    path: ~/.nvm/versions/node/v18.19.0/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/isaiah/.rvm/gems/ruby-2.6.10/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.0
      - iOS 18.0
      - macOS 15.0
      - tvOS 18.0
      - visionOS 2.0
      - watchOS 11.0
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 16.0/16A242d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 1.8.0_275
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /Users/isaiah/.rvm/rubies/ruby-2.6.10/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.75.4
    wanted: 0.75.4
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs
Framework 'CoreModules' not found

Reproducer
https://github.com/imann24/firebase-react-native-build-issues-repro
Screenshots and Videos

Have you reported this to
https://github.com/invertase/react-native-firebase/issues
?
Please report it there first and get back to use if they point the issue as a problem with React Native core


feat(express): add context and per-endpoint middleware support

Codecov Report

Merging #232 (969fdcd) into main (1c53ac9) will decrease coverage by 4.86%.
The diff coverage is 4.76%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   65.01%   60.16%   -4.86%
==========================================
  Files          12       12
  Lines         343      374      +31
  Branches       82       95      +13
==========================================
+ Hits          223      225       +2
- Misses        111      140      +29
  Partials        9        9

Impacted Files
Coverage Δ

libs/ts-rest/express/src/lib/ts-rest-express.ts
10.81% <4.76%> (-1.69%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


p2p,processor(cdc): fix two unstable tests

What problem does this PR solve?
Issue Number: close #3945 close #4319
What is changed and how it works?

Fix incorrect assertions in unit tests

Check List
Tests

Unit test

Related changes

Need to cherry-pick to the release branch

Release note
None

/run-check-issue-triage-complete

/run-leak-tests

/run-leak-tests

Codecov Report

Merging #4827 (aa3e366) into master (9607554) will increase coverage by 0.6444%.
The diff coverage is 70.9349%.

Flag
Coverage Δ

cdc
60.9619% <70.9349%> (+1.0396%)
:arrow_up:

dm
52.4389% <ø> (+0.4100%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4827        +/-   ##
================================================
+ Coverage   55.6402%   56.2847%   +0.6444%
================================================
  Files           494        523        +29
  Lines         61283      65524      +4241
================================================
+ Hits          34098      36880      +2782
- Misses        23750      25047      +1297
- Partials       3435       3597       +162

/merge


fix deficient code, "/socket.io/" http segment declare

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

missing test case declare segment from plugin netty-socketio

How to fix?

add "/socket.io/" HTTP segment declare

New feature or improvement

Describe the details and related test reports.

@dmsolr , you can have a look

@dmsolr , you can have a look

Hi @mrproliu
I am sorry to let you know that PR passed because the  Agent-Plugin-Test framework has a bug. Which will be fixed by #3716 .  BTW, you losing some segments in the expectData.yml yet.

@mrproliu I have asked @dmsolr to remove socket.io test in jenkins file, which will give you 1-2 days to fix and update this PR to add test back

@wu-sheng @mrproliu , I have remove it. Please add it back after fixing it.

Data sync complete, please add the test back and fix the test bug.

I have added the test case into Jenkinsfile-Agent-Test file, why is it not running on Agent Plugin Tests Workload 1?

It is running. The graph only updates after it runs once.

It is running. The graph only updates after it runs once.

good, have resolved test case bug. contact me if it has any problem.

@dmsolr Please continue.

@mrproliu  Please verify the case, the test still fails.

I'm trying to use ${TOOLS_HOME}/skywalking-validator-tools.jar check the reason.
throw IOException when case servlet closes HttpServletResponse.

You should not use it directly. It need mock collector running AFAIK.

I am running the test again to recheck stability

/run agent-plugin-test-1

@dmsolr Please review


API v2: pods: fix two incorrect return codes

/pods/<X>/exists - is documented to return 204, and that's
the correct value, but until now it has been returning 200.

/pods/create - return 409 (conflict), not 500, when pod
already exists

Also: in WriteResponse(), if code is 204 (No Content), emit
the status code only but no content-type headers nor content.
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

/approve
Changes LGTM

Pushed update: only change is in handler.go, using a switch statement to handle both 204 and 304 as defined in rfc2616. Also as a way to rerun flaking tests.

(one more push: fix a badly-formatted comment I added)

@jwhonce @baude if you can spare a moment, I'd appreciate a quick look. I need this to converge on a working set of APIv2 tests that we can enable in CI.

/lgtm


How can I insert a UTF-8 character with skhd?

I came across skhd -k "return" by googling but skhd -k "ü"doesn't work. Is there another flag for that?

As far as I can tell skhd doesn't work well with chars outside of a-z; I ended up using Ukulele for remapping of keys instead.

As far as I can tell skhd doesn't work well with chars outside of a-z; I ended up using Ukulele for remapping of keys instead.

type skhd -o in a terminal, this will observe keypresses and return the hex code for that key.
This can then be used in skhd for remaps.
In terms of OP problem, it may be a better approach to look at how your terminal emulator handles accented characters.
If you're on mac, it relates to a keyboard feature introduced by apple called the 'compose key' which basically enables access to the unicode characters under letters / symbols when holding alt.
This normally needs to be enabled in the term emulator itself.
eg in wezterm there is an option:
config.send_composed_key_when_left_alt_is_pressed = true
config.send_composed_key_when_right_alt_is_pressed = true

@tjex Where would we remap? I'm having trouble mapping my Hyperkey + b. It works great for hyperkey + h j k l but not b for some reason.

what do you mean "where would we remap", it's in the skhdrc.
But sounds like you're already mapping hotkeys. Maybe you're double mapping hyper + b?
Pls post / point to your config file. Otherwise the possibilities are endless.

@tjex thanks for getting back to me. Sorry for being unclear.
Inside of my .config/skhd/skhdrc I have this.
shift + alt + ctrl + cmd - b : skhd -k "shift + 3"

I'd like for it to insert one # into whatever app I have open(Obsidian, Zed, VSCode, etc).
Even better would be if I could get it to insert two # so that it's a ##.
Thanks in advance~!

Wow, just reread the readme and found it.
shift + alt + ctrl + cmd - b : skhd -t "##"

Regardless thanks~! =)

Not a prob :)


Bank feeds api - nav + corrections

Description
Added xero bank feeds to side nav, removed a random link from text
Type of change

[ ] New document(s)/updating existing
[X] Fixes
[X] Styling
[ ] Bug fix (non-breaking change which fixes an issue)

Do we not think a dedicated page for xero bank feeds is warranted?

Do we not think a dedicated page for xero bank feeds is warranted?

It probably is, but at the moment we already refer to this in the overview itself. Better to have something in the side nav rather than nothing at all


Add AceJump to examples

Cool!
README.md is generated file by documentr task. Please change src/docs/examples.md instead. Also add a note that kotlin is used as a language for gradle-stript, it's quite unique at them moment and might be useful as an example

Regeneration README.md is still needed, comment about kotlin-script is still needed. Also, please rebase the branch. I believe even 2 commit is too much for such change

Cool! I rebased the branch, merged the changes, updated examples.md, regenerated examples.md with ./gradlew documentr, and re-submitted changes in a single commit. Just out of curiosity, how did you find the documentr plugin and what benefits does it provide?

Cool! I rebased the branch

Well, I see, but it is not what I wanted. I won't merge 40 commits for adding an example :)

how did you find the documentr plugin and what benefits does it provide?

I didn't remember how I find it. The main reason to use it was updating plugin version across  documentation.

I won't merge 40 commits for adding an example :)

The commits are already merged (those are mostly your commits). Or: I can close this one and resubmit another PR using the latest master branch.

The commits are already merged (those are mostly your commits)

No, they are not, they are different commits which were created during your rebase, and they will be duplicated in master as soon as I rebase master onto your branch.
Please follow the instruction on how to make PR rebasing: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

I can close this one and resubmit another PR using the latest master branch.

If you not sure how to handle this, probably it's easier to resubmit the PR.

If you not sure how to handle this, probably it's easier to resubmit the PR.

Resubmitting under #181.


Dictionary is very inefficient

Kernel mutex + 3 writes to different files on add. Could be reduced to one interlocked flag + single file + async writes. For fixed size keys/values it should be possible to boost performance at least 10x fold. And remap for resize could be done similar to lmdb.

A prototype based on SCG.Dictionary<K,V> gives 7Mops writes and 12 Mops reads on MacBook Air (without locks). Lock-free read-write synchronization similar to Spreads.SortedMap will marginally reduce that number. The final implementation will be in the Spreads project.

Cool that you're still working on this, and hope you can improve on it :)

For fixed size key-values performance is over 6 Mops https://github.com/Spreads/Spreads/commit/f49c5d4e5848e4064136e1889f83fe85c7228754


better tests for unhappy paths

Bug Description
our coverage of the interface.py module lacks a little bit when it comes to unhappy-path tests.
In particular, the library is expected to gracefully handle situations when the databag doesn't contain data that is formatted in the expected way, but we aren't testing those paths.
To Reproduce
PYTHONPATH=.:src:lib pytest --cov
Environment
main
Relevant log output
src/cosl/__init__.py                              6      0      0      0   100%
src/cosl/coordinated_workers/__init__.py         20      5      2      0    68%   26-28, 31-32
src/cosl/coordinated_workers/coordinator.py     302     71     84     18    72%   149, 290->293, 377, 384-388, 397, 402, 407->406, 409, 414, 424-425, 481-493, 498-514, 522-544, 568-569, 583->587, 590, 593, 604, 619-620, 627-632, 649-655, 664-665, 700-720, 725, 730, 740-747
src/cosl/coordinated_workers/interface.py       295     69     82     15    73%   81-84, 90->92, 268, 272-277, 294-305, 319, 330-331, 335-337, 342-344, 355, 363->362, 367-369, 384, 389, 393-399, 405-408, 417, 427-433, 467, 470, 474->exit, 481-482, 490-504, 510-511, 525, 528->exit, 571, 582-585, 589-592, 599
src/cosl/coordinated_workers/nginx.py            90     16     24      7    76%   63-90, 97->exit, 105, 112-113, 129->exit, 134->exit, 142-143, 176->exit
src/cosl/coordinated_workers/worker.py          386     82    164     32    76%   58, 214-215, 219-220, 241-243, 249-250, 257, 263, 269-272, 284-289, 321, 323, 342, 362-366, 442-445, 459, 461, 465, 475, 481, 518-529, 556-557, 560-561, 574, 595-598, 605->609, 627, 662-663, 665-666, 668, 690-696, 705-707, 729-733, 743, 749, 766-794, 798-805, 827, 836->840, 841->840, 855-857

Additional context
focus on src/cosl/coordinated_workers/interface.py 330-331, 335-337, 342-344,
those are 'exception paths' in the cosl.coordinated_workers.interface.ClusterProvider.gather_addresses_by_role method
we should add one or multiple tests that exercise those blocks of code.
Those tests should live in the tests/test_coordinated_workers/test_coordinator.py module and use pytest and scenario.
Rough explanation of what the method is doing:
the ClusterProvider object is a relation endpoint wrapper for the 'cluster' relation interface.
That piece of code is responsible for walking through all units related over 'cluster' and collect a piece of data from their databags.
The expectation is that a log will be printed out if that fails (e.g. because the databag is badly formatted).

I'd like to take on this issue as part of the Engineering Onboarding. Just so that I can update my Jira tickets, should this count as "Bug Fix / Feature" or "Tests" (or both :smiley:)?

I'd like to take on this issue as part of the Engineering Onboarding. Just so that I can update my Jira tickets, should this count as "Bug Fix / Feature" or "Tests" (or both 😃)?

Welcome to take a shot at it! I think this would qualify in the 'tests' category ;)

@lorenzo-medici do note that a colleague of yours already worked on some of those paths in https://github.com/canonical/cos-lib/pull/102
for some reason the PR wasn't linked to this feature, but so something has been done already. There's more still, you can re-run the coverage tool and see what's missing

The lines in interface.py that are specifically referenced have indeed already been included in the test coverage.
I'll expand the test coverage for ClusterRequirer in the same file, unless you suggest other things.


Fix Header Transparency

implement header transparency as in design

scroll to top when user navs to new route

Coverage remained the same at 61.366% when pulling 28c0bd06ab482e916b3b9ddc5820d0e604758168 on josephkane:fix-header-transparency into b2ec7c2638f8963603c87f015e3fc56ec633c630 on supergiant:master.


Failed Request-promise Jasmine2 tests return as successful

I'm trying to add some end point tests to my Protractor test suite (using Jasmine 2) but my tests always pass, even when I try to fail them. In the example below, my response has the expected data, but does not fail, even though it should.
it('should return expected video url', function(done) {
    rp(options).then(function(response) {
        console.log(response.foo); // returns 'foo'
        expect(response.url).toBe('bar'); // should fail but does not
        done();
    });
});

Hi @qualityshepherd, I can't tell for sure because I am using Mocha myself but try this to handle the error thrown by the expect statement:
it('should return expected video url', function(done) {
    rp(options)
        .then(function(response) {
            console.log(response.foo); // returns 'foo'
            expect(response.url).toBe('bar'); // should fail but does not
            done();
        })
        .catch(function (err) {
            done(err);
        });
});

Does this help?

Hi @analog-nico, thanks for the speedy response. I added the catch, but no joy. It still succeeds when it should fail. Strange...

It was long ago that I switched from Jasmine to Mocha because passing an error to done() was not possible. The workaround would be to intentionally fail an expectation.  However, they later introduced done.fail() which is what you probably want to use in the catch block.
However, judging from your observations your expect(...) probably doesn't fail to begin with. Please debug your code and check the variables. If you still face issues you are much better off approaching the Jasmine community and ask about how to handle tests with promises.
Happy debugging!

Thanks @analog-nico. Jasmine2's expect was just never failing. I installed chai and it's expects work as expected.

Strange indeed. :D


new term: increased megakaryocyte progenitor cell number

Preferred term label (e.g., asplenia)
increased megakaryocyte progenitor cell number

Textual definition (the definition should be understandable even for non-specialists.
increase in the number of a progenitor cell committed to the megakaryocyte lineage

Any additional notes to clarify the meaning or use of the term. Please provide a PubMed ID or URL(s) for the source of this information.
J:241724

Suggested parent term.
MP:0002413 abnormal megakaryocyte progenitor cell morphology
(note that the comparable MP:0013704 (increased megakaryocyte-erythroid progenitor cell number) has an intermediate parent MP:0013703 (abnormal megakaryocyte-erythroid progenitor cell number), whereas the comparable MP:0013891 (increased common myeloid progenitor cell number) does not).

Laurens

added
abnormal megakaryocyte progenitor cell number MP:0020462
increased megakaryocyte progenitor cell number MP:0020463
decreased megakaryocyte progenitor cell number MP:0020464
abnormal megakaryocyte progenitor cell physiology MP:0020465
increased megakaryocyte progenitor cell proliferation MP:0020466


Separate types and utils - Marco

Also if you could make the filenames more concise? It a file is in "types/", then it's basically already clear that it is an interface (no need to specify it in the filename); same thing for "utils/" and implementation.


[Bug] NDArray::IsAligned Can't Work for OpenCL, Vulkan Device API, should it is removed?

When using OpenCL + Graph Executor + set_input_zero_copy, we found below code will raise exception, actually we know the NDArray is allocated by the OpenCL device API, it should satisfy the alignment requirement.

After browsing some code of OpenCL device API, we found that OpenCL device API finally will return a pointer of host structure BufferDescriptor,  and this pointer is convert to void*, and store in the data field of DLTensor.

This is the reason why the 1st figure alignment check failed, the vulkan device API use the same mechanism, so it have the same problem.
Why Relay VM haven't meet this failed check?

Acturally Relay VM is impacted by this issue too, the different is Relay VM won't raise exception, but do a non-need copy.
Even through we will pass the aligement argument to the interface  virtual void* AllocDataSpace(Device dev, size_t nbytes, size_t alignment,  DLDataType type_hint) = 0; of class DeviceAPI, but I found except CPU, it seems all of other device can't avoid to specify aligment when alloc data through their runtime API.
So why we need this alignment? can we deleted these checks?

@jwfromm @tqchen @junrushao It seems previous discussion in https://github.com/apache/tvm/pull/12564 is relevant.

I think main issue is that the user might slice the memory in zero copy mode, but we could update IsAligned to ensure that we always return true for Tensors in OpenCL VK backend assuming the byte_offset is 0


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_d03866fa-8dec-4908-9dbd-72bb27549a15/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_d03866fa-8dec-4908-9dbd-72bb27549a15.git

Docs Build status updates of commit 328706b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-03-30-03-39-23 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-03-30-03-39-23

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update plugin to SpecFlow 3 new model

This PR updates the plugin to be compatible with SpecFlow 3 new plugin model.
It also updates Unity dependency, which might be debatable depending on your vision of the plugin.
Documentation will need to be updated too (mostly to remove the configuration parts which are not needed anymore, and to update required versions for dependencies).
I'm looking forward to get your feedback on this proposal, of course!

We are currently looking at Specflow DI. Given that we are using Specflow 3.* and Unity 5.10 this would be very welcome.

Is this pull request likely to be completed and a new version released?

@phatcher : could you provide guidance on this PR, which has been there for a long time?
Would you prefer a fork of this plugin to support SpecFlow 3 / Unity 5, or would you have plans to integrate this feature in a better way?
Are there things we could do to help ?

@phatcher , any chance to get at least a feedback on your intentions?


Design Wireless E-Stop System

The RA-10 remote anything appears to be what we will design our emergency stop system around. We need to conceive a way to translate the outputs of this to our robot's power system.

@gtheller can you post details here?


Fix Login

I get the Network Error (Code 242) when trying to login before the Announcements Box on the right is loaded in.
Whenever I haven't launched GW in a while (like a couple of hours) the Announcements take a while to load resulting in me being unable to auto login using GWLauncher.
Can Toolbox provide a solution for this?

So the client stores these announcements in the dat, and refreshes them every so often on starting gw. The issue with the auth connection is that theres a sequence of handshaking that needs to happen in order - if the client has decided that it needs to know about updated announcements, you have to wait until the response is given otherwise the auth connection drops when you try to login.
Should be able to create a patch to the decision process of whether or not the client needs to ask for updated announcements, so its definitely something we can fix if toolbox is loaded before this logic happens, yep


Remove hard dependency on Biniou

Looking at the dependency tree of Yojson, which is one of the more popular packages in the OCaml ecosystem I encountered Biniou, a serialization library. Biniou is not a particularly popular in OCaml, given it has (at time of writing) 11612 downloads per week in OPAM, which might seem a lot but my hypothesis is that this is mainly due to the dependency in yojson (1.5.0 accounts for 7469 downloads,  1.4.1 for 5120).
So therefore I was curious how tightly interconnected Yojson and Biniou are and it turns out… not much. I split the code that depends on Biniou into a new OPAM/findlib package, to preserve compatibility with code that requires it. The remaining code was using Bi_outbuf which can be replaced nearly 1:1 with Buffer. This changes the signature of some functions, but the advantage is that it replaces the somewhat Bi_outbuf.t type with Buffer.t which, due to the fact it is in the compiler standard library is somewhat more common in the OCaml community.
I haven't run many tests except for very basic "does it even still work" but to my understanding Bi_outbuf and Buffer should have similar asymptotic behaviour since they are designed to fit a similar purpose.
Edit: It was noted on IRC that it is not entirely clear, but the changes in write.mli and read.mli change the public API, thus requiring something bumping the major number. Judging by the fact that these changes only affect programs that use Biniou AND yojson and there are hardly any on OPAM, I believe this is a reasonable trade-off.

Same as you I'm not sure exactly how to interpret all of the benchmark output but mostly it seems to have no significant impact and if anything it's faster than it use to so as far as I'm concerned it's :+1:
I haven't reviewed it all yet but that should be fine.
As you mentioned it, this will break the API so that requires a major version bump, especially since atdgen relies on those parts (specifically on lexer_state using Bi_outbuf).
I'd like to squeeze in a few other changes before 2.0 but it might take a bit of time making sure which ones are doable and will fit the yojson users' need. Because of that I'm wondering whether we should merge this to master or to a 2.0.0 branch so that we can still release minor changes and patches in the meantime.
What do you think?

Because of that I'm wondering whether we should merge this to master or to a 2.0.0 branch so that we can still release minor changes and patches in the meantime.

I think yes. I was thinking about working on Easy_format next and not having this merged will create quite a lot of pain because I either have to base it off this branch (which was painful the last time I did it) or create another branch that will almost certainly conflict with this one.
I don't see much need to do minor changes or patches in 1.x since Yojson has releases around once a year. Even then it is pretty feasible to just branch off the 1.6 commit and create a 1.x branch and release from there. It might be a bit tricky wrt gh-pages but @c-cube has somehow managed to get the docs of all versions of containers on Github pages so I assume it can be done somehow.

Wrt gh-pages I just make a new subdir for every release, copy the content of _build/default/_doc (something like that) into it, add a link in the toplevel index.md file, and that's about it :)

Sorry for the delay. I agree Yojson has been around for quite a while without the need for releases so I doubt there will be an urgent need for a patch while we work on 2.0 and if there is your suggestion about using a 1-x sound reasonable.
I'll review and (hopefully) merge today!

I rebased on top of master which now has a bit more tests to showcase the bug it introduces!

What is the decision on this PR? Seems quite some time passed.

What is the decision on this PR? Seems quite some time passed.

There isn't really a decision that needs to be made at the moment. The PR currently breaks existing functionality with no replacement (as the test introduced by @NathanReb shows), so it cannot be merged at the moment until me or someone else implements it in a way where you can actually output to a file.
The Buffer module does not have a create_channel_writer function, so an abstraction on top of that would be necessary where the wrapping module can write to a channel and then the code has to be adjusted to do that.

So, my hope is that I'll get to work on this during this "between the years" period and can get it merged soon and then with #88 can remove also the transitive dependency on easy-format. As such I've implemented the missing functionality in the simplest possible way, as you can see in the latest commit.
Thanks for the unit tests @NathanReb, they are passing now. I think I'll put adding more extensive tests for this on the TODO list. I would've expected you to be right, with the Buffer.output_buffer being slower, but unless I am reading this wrong the opposite seems to be the case:
This branch (rebased on current master):
Estimated testing time 50s (5 benchmarks x 10s). Change using -quota SECS.
┌──────────────────────────┬────────────┬────────────┬────────────┬──────────┬────────────┐
│ Name                     │   Time/Run │    mWd/Run │   mjWd/Run │ Prom/Run │ Percentage │
├──────────────────────────┼────────────┼────────────┼────────────┼──────────┼────────────┤
│ JSON reading             │    17.26us │  1_141.03w │      2.43w │    2.43w │      1.67% │
│ JSON writing             │     9.72us │    695.01w │    258.30w │    0.30w │      0.94% │
│ JSON writing assoc       │ 1_036.13us │ 20_240.10w │ 47_256.26w │    6.26w │    100.00% │
│ JSON writing int list    │   363.74us │    235.09w │ 22_256.18w │    3.18w │     35.11% │
│ JSON writing string list │   642.48us │ 20_235.13w │ 41_143.85w │    4.85w │     62.01% │
└──────────────────────────┴────────────┴────────────┴────────────┴──────────┴────────────┘

Current master, 41c6c29501c656e0b44dbb904930b7bf8d5cb1c4:
Estimated testing time 50s (5 benchmarks x 10s). Change using -quota SECS.
┌──────────────────────────┬────────────┬────────────┬────────────┬──────────┬────────────┐
│ Name                     │   Time/Run │    mWd/Run │   mjWd/Run │ Prom/Run │ Percentage │
├──────────────────────────┼────────────┼────────────┼────────────┼──────────┼────────────┤
│ JSON reading             │    17.39us │  1_167.02w │      2.24w │    2.24w │      1.55% │
│ JSON writing             │    10.66us │    721.00w │    258.30w │    0.30w │      0.95% │
│ JSON writing assoc       │ 1_121.55us │ 20_266.10w │ 47_254.90w │    4.90w │    100.00% │
│ JSON writing int list    │   392.04us │    261.09w │ 22_255.36w │    2.36w │     34.96% │
│ JSON writing string list │   719.97us │ 20_261.13w │ 41_142.85w │    3.85w │     64.19% │
└──────────────────────────┴────────────┴────────────┴────────────┴──────────┴────────────┘

I am a bit surprised by these results, and I suspect I might be missing something, so I would appreciate if people could take a look and run the benchmarks themselves.

Okay, after adding the relevant benchmarks:
io-benchmarks (master+channel benchmarks) branch:
┌─────────────────────────────────────┬────────────┬────────────┬────────────┬──────────┬────────────┐
│ Name                                │   Time/Run │    mWd/Run │   mjWd/Run │ Prom/Run │ Percentage │
├─────────────────────────────────────┼────────────┼────────────┼────────────┼──────────┼────────────┤
│ JSON reading                        │    17.46us │  1_167.02w │      2.24w │    2.24w │      1.58% │
│ JSON writing                        │    10.70us │    721.00w │    258.30w │    0.30w │      0.97% │
│ JSON writing assoc                  │ 1_106.36us │ 20_266.10w │ 47_254.90w │    4.90w │    100.00% │
│ JSON writing int list               │   388.18us │    261.09w │ 22_255.35w │    2.35w │     35.09% │
│ JSON writing string list            │   713.11us │ 20_261.13w │ 41_142.85w │    3.85w │     64.46% │
│ JSON writing int list to channel    │   366.73us │     52.00w │  6_682.97w │    0.97w │     33.15% │
│ JSON writing string list to channel │   638.09us │ 20_052.34w │  9_255.87w │    3.87w │     57.68% │
│ JSON writing assoc to channel       │ 1_019.29us │ 20_057.34w │ 15_424.31w │    4.31w │     92.13% │
└─────────────────────────────────────┴────────────┴────────────┴────────────┴──────────┴────────────┘

This branch:
┌─────────────────────────────────────┬────────────┬────────────┬────────────┬──────────┬────────────┐
│ Name                                │   Time/Run │    mWd/Run │   mjWd/Run │ Prom/Run │ Percentage │
├─────────────────────────────────────┼────────────┼────────────┼────────────┼──────────┼────────────┤
│ JSON reading                        │    17.23us │  1_141.03w │      2.43w │    2.43w │      1.55% │
│ JSON writing                        │     9.49us │    695.01w │    258.30w │    0.30w │      0.86% │
│ JSON writing assoc                  │   981.97us │ 20_240.10w │ 47_256.25w │    6.25w │     88.58% │
│ JSON writing int list               │   364.64us │    235.09w │ 22_256.18w │    3.18w │     32.89% │
│ JSON writing string list            │   633.92us │ 20_235.13w │ 41_143.84w │    4.84w │     57.18% │
│ JSON writing int list to channel    │   352.56us │     14.04w │ 15_882.40w │    0.40w │     31.80% │
│ JSON writing string list to channel │   737.77us │ 20_014.16w │ 32_268.87w │    0.87w │     66.55% │
│ JSON writing assoc to channel       │ 1_108.61us │ 20_019.17w │ 32_269.40w │    1.40w │    100.00% │
└─────────────────────────────────────┴────────────┴────────────┴────────────┴──────────┴────────────┘

So indeed writing to a channel got slower, but less than I would've expected honestly.

@NathanReb, @Leonidas-from-XIV What is the current status? Are there any outstanding questions or work that I can help with?
I would really love to see these changes merged and have version 2.0.0 published though opam with reduced dependencies.
Looking at the benchmarks, it seems that the changes results in reduced GC pressure.
So in case the users is concerned about serialization speed, i.e. doing serializations in a tight loop, then a high GC pressure will kill performance sooner or later.
The timings differences are also very small (ranging from 87% to 113%), and can always be micro-optimized later.

I'm looking into this right now! @Leonidas-from-XIV could you rebase this on top of master please? I think the benchmarks you added have now been merged!

Thanks! I've just rebased it and since I did the same change as @bschommer in #89 I merged his change first so the PR got slightly smaller.

Ouh! Could you also please add one or more changelog entries about the API changes we're introducing here?

Yep, done all that! For some reason notifications are kinda flaky for me, so I didn't see your review before. Needs some investigating.


Add method for checking if an instruction is parameterized

What is the expected enhancement?
As pointed out by @maddy-tod in #3288 :

... it might be good to have this as a function on the gate for example Gate.is_parameterized() just for clarity. This could potentially introduce confusion for gates that are not able to be parameterized though.

There are a few places in the code which handle parameterized gates differently from fully bound gates, e.g. Optimize1qGates, CommutationAnalysis, Collect2qBlocks, and the unroller . Rather than having each any(isinstance(param, ParameterExpression) for param in op.params), it might be helpful to have a .is_parameterized method on the base Instruction class.
Questions:

What is a returned for a gate that accepts no params?
Do we distinguish between unbound (ParameterExpression(θ)) and bound (ParameterExpression(3.25)) parameters?

* What is a returned for a gate that accepts no `params`?

The only use in Terra of the phrase noted in the Expected Enhancement seems to be as a boolean.
Here's a question: Does this issue solely address adding an instance method (and test case) to qiskit.circuit.Instruction or also applying the Enhancement appropriately throughout Terra?


stpmax=0.2 makes tst_00 and tst_01 fail

I tired updating the default stpmax to be 0.2. However, when running the test suite, the first two tests fail.
To Reproduce
Steps to reproduce the behavior:

change the default stpmax=0.2 in qr.py
Go to test folder
run qr.test --nproc=8
See error:

qr.refine m00_good.mtz /Users/mark/PycharmProjects/phenix/phenix-dev-3386/modules/qrefine/tests/unit/data_files/m00_poor.pdb restraints=cctbx output_folder_name=tst_00 > tst_00.log
tst_00 FAILED Cannot open file for reading: "tst_00/m00_poor_refined.pdb"
[Errno 2] No such file or directory: 'tst_00/m00_poor_refined.pdb'
Total time:  18.19 (s)
qr.refine m00_good.mtz /Users/mark/PycharmProjects/phenix/phenix-dev-3386/modules/qrefine/tests/unit/data_files/m00_poor.pdb restraints=cctbx mode=opt output_folder_name=tst_01 > tst_01.log
tst_01 FAILED
Total time:  25.34 (s)
Suggested behavior
We should adjust the values in the tst_00 and tst_01 to make it pass with 0.2 stpmax:
tst_00.py
fmodel.r_work() < 0.04
r_final-fmodel.r_work())<0.0005
tst_01.py
get_bond_rmsd('m00_poor.pdb' ) > 0.1
get_bond_rmsd('m00_poor_refined.pdb') < 0.0009 < 0.0009
Desktop (please complete the following information):

OS: Mac OS 10.14.2
Version qr commit caused problem a7e1184  changed back in 5fdbd17

Done. Tests now pass with this default.


Multi-line floating labels

I'm not sure how they should behave, currently it's a bit ugly as the label overlaps with the value: https://jsfiddle.net/caub/kjc3hLxo/
It's not really a bug, but do you think there would be a better way to handle this case? or should we just avoid multiline labels when using floating form labels?

Hmm possible to align the input text on the right: https://jsfiddle.net/caub/kjc3hLxo/3/


Change the sampler

Hey! Just wondering if its possible to change the sampler Euler, DDIM etc

It should be easy to implement both dynamically and at startup time. I will try to work this out in next release


[New Feature]: Add Semantic API support for client declaration statement

Description
Need to add support for the following grammar changes: https://github.com/ballerina-platform/ballerina-spec/commit/a3d5a31805c42c66cef2edee6f6a96bae9de4e0e
Describe your problem(s)
No response
Describe your solution(s)
No response
Labels
CompilerFETools
Related issue(s) (optional)
https://github.com/ballerina-platform/ballerina-spec/issues/1097
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

sub-task of https://github.com/ballerina-platform/ballerina-lang/issues/37459


Prefix calls to getenv() during config resolution

Description
Fixes #4559
Closes #4556
Checklist:

[x] Securely signed commits

Before I change the tests, I just want to confirm if my proposed changes are acceptable, @MGatner , @samsonasik ?

Yes looks good to me.

It's a little hard to see what actually changed in the tests because there are a lot of (good) adjustments, but this looks right to me overall if you feel good about it.


Add C, E, and P (rendered chunks, entities, and particles) Counters

Is your feature request related to a problem? Please describe.
Since jumping from 1.8.9 to more modern versions, I've been frustrated by how few mods offer specifically C and E counters as something they display in the overlay HUD (that is, intended to be always visible, unlike HUDs like the F3/debug menu that are meant to be toggled as needed), and how even fewer of these mods aren't overtly deep to the point of accidentally breaching some server's competitive rules.
Describe the solution you'd like
Similar to how they appear in the F3/debug menu, I am requesting the following counters be added as options to Simple HUD Enhanced:

C counter (rendered chunks, often compared to the total chunk count in the loaded area, in the format [rendered]/[total])
E counter (rendered entities, often compared to the total loaded entities count, in the format [rendered]/[total])
P counter (loaded particles)
To the E counter request's extent, I am also tentatively suggesting adding the various loaded entities counters, as they are often an option whenever a mod offers the E counter:
M counter (total monsters, aka hostile mobs, that count towards the mob cap)
C counter (total creatures, aka passive mobs)
etc.
This request, however, is mainly made to request the C/rendered chunks and E/rendered entities counters, as they're highly useful while caving/hunting for bastions.

Describe alternatives you've considered
I've tried some alternatives when pursuing mods that offer C and E counters in the overlay HUD, such as Minihud and BetterF3. However, Minihud is disallowed on some servers on account of having an entity health indicator module (which offers an unfair advantage in gamemodes like UHC), and BetterF3 is meant to replace the F3 screen entirely, so I either sacrifice my F3 menu's depth or opt for a cluttered screen.
Additional context
Two weeks ago, and one week after its most recent commit, you submitted a pull request for a mod called "Simple HUD Utilities", citing how the mod had multiple unresolved issues and how your mod is more robust. I support the pull request's reasoning (especially on unresolved issues), but the mod's author stated they planned on adding C and E counters. To that extent, and because almost no mods offer them currently, I believe adding C and E counters are in your best interest.

Will look into adding it in Update 4.7.2

At this point, I will most likely only add a chunk counter and entity counter, maybe a monster and passive counter variant as well. Is that enough to close this feature request? Particles seem tough; I am looking into it now.

At this point, I will most likely only add a chunk counter and entity counter, maybe a monster and passive counter variant as well. Is that enough to close this feature request? Particles seem tough; I am looking into it now.

That's close enough to the request to close it, yeah. Chunk and entity counters are by far the most useful for cave- and bastion-hunting. Other counters like particles are more performance-related, so they're probably better covered by debug-oriented mods like Minihud, whereas I've always seen Simple HUD Enhanced as more of a QoL mod for everyone to use.
Thanks for implementing the request!

Update: its all working,
Chunk Counter - Total / Loaded - Configurable
Entity Counter
Particle Counter
I am just working on other things, this update is ballooning into a new major release, but these features are already coded and working as of right now.

Great to hear! Looking forward to what else is coming in the major update as well, so here's hoping everything goes smoothly for you.

Just released a preview version of the mod, still testing and ensuring its stable, https://github.com/SoRadGaming/Simple-HUD-Enhanced/releases/tag/v4.7.2 let me know if you have any feedback, thx


Quaternion order

Is the rotation of a keyframe exported as a XYZW quaternion (which is the order specified in the glTF specification) or WXYZ quaternion(which is the order/mode in blender) I thought it's XYZW as that's what the glTF specification says however i am getting very strange values when i export the animated mesh(eg at keyframe 0 which has a rotation set to 0 degrees for each axis, i get the following XYZW quaternion: 1.0, 1.0323214E-21, 7.5497894E-8, 4.584124E-9 (so the X value is 1.0 and YZW are approximately 0)
The expected result in this case would have been 0, 0, 0, 1
glTF file:
vetionanimated22.zip

This only seems to happen with bones that have a parent(not including root)
For example the Joint_3(Body) bone has root as it's parent, doing the same exact rotation works perfectly fine
However doing the same with the LEFT_SHOULDER bone which has Joint_3 as it's parent causes the issues i mentioned above
Exporting the mesh, reading the first 3 keyframes:
LEFT_SHOULDER bone
Got 1.0, 1.0323214E-21, 7.5497894E-8, 4.584124E-9
Got -0.99996436, -0.0031733038, -0.003520802, 0.006986448
Got -0.9994673, -0.012495522, -0.013807366, 0.026801242

JOINT_3 bone
Got -6.584865E-8, -6.71794E-8, -4.853328E-15, 1.0
Got 0.006986387, 0.0035206592, -0.003173303, 0.9999644
Got 0.026801182, 0.013807221, -0.01249552, 0.9994673

Another issue i have noticed is that for the Left shoulder bone(and some others) blender exports the wrong(?) rotation values for the node (1, 0, 0, 0) instead of (0, 0, 0, 1) XYZW quaternion order. as when i imported the mesh, each bone had no rotation(which would be (0, 0, 0, 1) This doesn't happen to all bones (the JOINT_3 bone is fine whereas Left shoulder and some others are not)

I have figured it out, the reason why the rotation of some nodes(bones in this case) changes when exporting is because blender tries to infer(?) rotations for the bones when they have no rotation set for them.
as for the values exported, they also make perfect sense, i simply had to multiply the rotation(at some keyframe) by the rotation of the bone that was transformed, and it seems to be perfectly working now.


ImportError: weighting_sampler is not an existing do sampler.

When I repeat the example of dowhy documents (https://microsoft.github.io/dowhy/readme.html) about dowhy pandas api as:

the error raised:

python 3.5.7
macOS 10.14.6

Hey @stereoF thanks for raising this. For some reason, I'm unable to reproduce this bug. Can you try the notebook dowhy_causal_api.ipynb in the online Binder notebook here: https://mybinder.org/v2/gh/microsoft/dowhy/master?filepath=docs%2Fsource%2F
If it works there, it might be a package dependency issue (check pandas >0.23.4). If not, we need to fix it in DoWhy.


Unable to find an executable to build Qt resources (icons). Tried: 'pyrcc5.bat', 'pyrcc5', 'pyside2-rcc'.

Dear all
I was trying to run a notebook developed by @Varun Kapoor
https://github.com/kapoorlab/TheNextMLExpert/blob/9773c9830da69924beed78d39b6c8870d6b9f6d8/NucleiSegmentation/NucleiSegmentations.ipynb
That uses @napari to visualize grand truth images and prediction images obtained with StarDist, I did run the notebook last week and it work but now that I want to re-run it the next error is appearing
FileNotFoundError: Unable to find an executable to build Qt resources (icons).
Tried: 'pyrcc5.bat', 'pyrcc5', 'pyside2-rcc'.
Please open issue at https://github.com/napari/napari/issues/.
I hope someone can help me to solve this issue. Thanks in advance

Hi @XareniGalindo, please tell us a little more about how you've created your python environment.  Did you create a conda environment or other sort of virtual environment? How did you install napari?  pip?  conda?

Hi @XareniGalindo, would you still like help with this?

This happened to me too.
I think you need a PyQt Ressource compiler binary in your path, not sure if this should be installed with the napari packet itself.
I fixed it by installing the pyqt5-dev-tools.

Those programs come with the default installation of pyqt and pyside on both pip and conda.  You shouldn't need to install anything else.  In most cases in the past, this has been due to idiosyncrasies in the local environment... hence my curiosity.  We can likely prevent it with more information

Just to summarise a short conversation between Talley and I on Zulip: one idea for preventing these issues going forward is to keep the dynamic generation code for local editable installs, but to pre-build the resources for bundles, wheels, and conda-forge packages. That should free us from trying to make these things work in 99%+ of user installs.

Now after reading the installation instructions again, I see my fault was installing via pip install napari without specifying the preferred qt-bindings.

Just to summarise a short conversation between Talley and I on Zulip: one idea for preventing these issues going forward is to keep the dynamic generation code for local editable installs, but to pre-build the resources for bundles, wheels, and conda-forge packages. That should free us from trying to make these things work in 99%+ of user installs.

Is this being done for wheels already? If that's not the case, the conda packages are not doign that either, nor the installers. Let me know if you want me to open an issue/PR to tackle this @jni!

Hi @jaimergp, a lot has changed since this issue.  we really can't build everything we need up front, because part of the point is that themes/icons can be dynamically declared.
The bigger issue here wasn't as much about dynamic code generation as it was about finding qt executables in the environment.  I'll add two notes:

since #2285 (which added even more fallbacks here) we haven't had any issues with this
as soon as https://github.com/napari/napari/pull/3707 is merged, we won't be using pyrcc for runtime compilation of resources at all, so this will be moot

the only ancillary issues here are those of potential write permission limitations, as I mentioned in that issue: https://github.com/napari/napari/pull/3707#issuecomment-1153005744
closing this issue since the initial question was solved


Update hcls example to use lysozyme protein instead of factor xa

Submission Checklist

[x] Have you installed and run this change against pre-commit? (pre-commit install)
[x] Are all tests passing? (make tests)
[x] Have you written unit tests to cover this change?
[x] Is unit test coverage still above 80%?
[x] Have you updated all applicable documentation?
[x] Have you followed the guidelines in our Contributing document?

Updated with some changes requested by @vjb-collab.


add email submission

Looks good to me.
I think it is a good thing to welcome contributions for EmailSubmission/get, EmailSubmission/changes and EmailSubmission/set destroy/update, however I am worry about seeing no tests here.
Clearly as it is not implemented on James side (contribution welcomed BTW) the current integration test starategy is defeated.
I would suggest to write minimal unit tests asserting the JSON payload, that would then be easy to compare to the spec, while waiting for something better.
Cheers,

I was suggesting Unit Tests as well. Integration tests are good and necessary, but Unit Tests are even more important and helpful.

Linked issues #40 , #41

but Unit Tests are even more important and helpful

In my experience, aggressive unit test suite 'can' get in your way as it mirror the code. I ended up on some large scale refactoring being very happy to have a very large integration test suite (safety feeling) and a minimal unit test suite (no need to modify "all the tests") - because testing JMAP method implementation really end up testing 'how the computation is done'. We should be careful not ending testing the 'how' but only the 'what'.
(i like reversing the test pyramid). But anyway my former back-end experiences are likely irrelevant in this project.
Were I tend to agree, I believe unit testing forces a junior team to adopt good design.
To be honest I would be in favor of:

a unit test suite ensuring the JSON produced by this lib is spec compliant (request)
a unit test suite ensuring that this lib is able to understand a test bed of spec compliant JSONs

Would you see other interesting unit tests to write ?
Can you provide such tests, at least for the untested methods you just contributed?

I added a comment, so there is still now 2 of my conversations unresolved ;)

but Unit Tests are even more important and helpful

In my experience, aggressive unit test suite 'can' get in your way as it mirror the code. I ended up on some large scale refactoring being very happy to have a very large integration test suite (safety feeling) and a minimal unit test suite (no need to modify "all the tests") - because testing JMAP method implementation really end up testing 'how the computation is done'. We should be careful not ending testing the 'how' but only the 'what'.
(i like reversing the test pyramid). But anyway my former back-end experiences are likely irrelevant in this project.
Were I tend to agree, I believe unit testing forces a junior team to adopt good design.
To be honest I would be in favor of:
* a unit test suite ensuring the JSON produced by this lib is spec compliant (request)

* a unit test suite ensuring that this lib is able to understand a test bed of spec compliant JSONs

Would you see other interesting unit tests to write ?
Can you provide such tests, at least for the untested methods you just contributed?

I thinke there is no good way in typescript to test the json and spec compliance.
You can not do somthing like {exampleEmailSetArgumentsJson.....} is of type EmailSetArguments. Is this what you proposed?
Again, i am not so good with typecript and if there is a good way then can anyone elaborate. A sample test maybe?

Thanks for the unit tests <3

Thanks for the unit tests <3

We thought about adding also unit tests for checking the response, but then it felt like very redundant test, since it would basically check out response mock.
On the other hand if library at some point will be able to validate response properties against request and in case it is invalid would go into .error() of the promise, then such tests would benefit.

And it seems the tests do not pass, can you look at it?

And it seems the tests do not pass, can you look at it?

I will look into it, locally i have no problems running the tests.

And it seems the tests do not pass, can you look at it?

I will look into it, locally i have no problems running the tests.

Ok, so I have them pass locally too, I will have to investigate.

And it seems the tests do not pass, can you look at it?

I will look into it, locally i have no problems running the tests.

Ok, so I have them pass locally too, I will have to investigate.

I think I know what the issue is. I sent suggestion to @andrevka . So maybe it will get fixed today.

And it seems the tests do not pass, can you look at it?

I will look into it, locally i have no problems running the tests.

Ok, so I have them pass locally too, I will have to investigate.

I think I know what the issue is. I sent suggestion to @andrevka . So maybe it will get fixed today.

Thanks @jeserkin . Your tip did the trick