Feature request: Support for pagination

Hey again!
Is there a way to support pagination? (https://docs.rs/aws-sdk-dynamodb/latest/aws_sdk_dynamodb/operation/query/paginator/struct.QueryPaginator.html)
I don't think I have direct access to the dynamodb query struct when using modyne's query, so thinking this will have to be built into Modyne?
Thanks!

Modyne doesn't use the QueryPaginator as linked, but there are examples of how to paginate through a query. It may be possible to wrap this in an iterator, but that is not directly provided by Modyne.
The example here doesn't do any internal looping, instead expecting a new call with a token for accessing the next page: https://github.com/neoeinstein/modyne/blob/main/dynamodb-book/ch19-ecomm/src/lib.rs#L79-L99


speeding up and slowing down with Part and Phrase

It seems like the tempo in Part is not consistent. The tempo audibly speeds up and slows down while the sound library plays back a part. I'm not sure why this could be...

I'd like to write a test for this that calculates when each beat is triggered vs. when it should be triggered. I think that'll be helpful in tracking down the problem, and it could be used to compare the current method for audio event scheduling to other options.

good idea!
On Mon, Feb 15, 2016 at 10:56 AM, Jason Sigal<EMAIL_ADDRESS>wrote:

I'd like to write a test for this that calculates when each beat is
triggered vs. when it should be triggered. I think that'll be helpful
in tracking down the problem, and it could be used to compare the current
method for audio event scheduling to other options.
—
Reply to this email directly or view it on GitHub
https://github.com/processing/p5.js-sound/issues/99#issuecomment-184269666
.

--
Composer, musician, instrument designer
snyderphonics.com * @snyderphonics


device ID 2 not found

Describe the bug
Integration setup with error "Retrying setup: Inverter device ID 2 not found." I have a configuration with 1 master e 3 Follower (RS485). If I setup integration with 1 inverter, everything works but I don't see my entire system. If I setup integration with >1 inverters then integration stop at #2 stating it's not found.
Expected behavior
My setup is based on 1 master (with one battery), 2 slave (each with a battery), 1 production inverter with AC coupling.
Screenshots

Logs
2022-10-18 11:07:20.886 ERROR (MainThread) [custom_components.solaredge_modbus_multi.hub] Inverter device ID 1: Inverter ID 1 not found.
Copy any log warnings or errors in Home Assistant from "custom_components.solaredge_modbus" and "pymodbus.client.sync".
 Now integration setup without error, but only show up the first id of the chain and not the others, not even #4 that is correctly seen if configured alone

ok after having properly configured IDs correctly now everything is detected. Just in case someone fall into my scenario: old inverters with display have a configuration password: to access the hidden menu you need to hold OK button, password is 12312312


Remove checkboxes from table rows and implement selection mode on mobile devices

Now that we've successfully implemented selection mode for the Search page, we'd like to reuse this same UX for all table rows that can be found on mobile. In order to do this, we will want to remove the checkboxes from all mobile tables and implement the same long-press to enable selection mode.

Here's a running list of the tables we'd want to update on mobile:

Workspace Editor

Members
Distance rates
Categories
Tags (including multi-levels of tags)
Taxes
Report fields

Group chat (for the admin)

Members

Note that for #rooms, we first need to update the members list to look more like the table style found in Groups first, and then we should make this change. We can handle that separately.
cc @Expensify/design @trjExpensify - can you think of anymore places?
Also cc @filip-solecki in case you want to take this one as a follow up. Thanks!

Sure, I can take it!

List looks good to me!

Awesome, thanks Filip!

I'll assign and be the BZ on this one.

Added External to get a C+ assigned for the PR review, removed Help wanted as we don't need contributor proposals for this job. 👍

Filip, you're still going to take this one right?

Yes, I am going to work on this on Monday

Not overdue, we're currently on track with starting work on this new feature as per the comment above.

Yes, I am going to work on this on Monday

Great stuff, thanks Filip!

Not overdue, we're currently on track with starting work on this new feature as per https://github.com/Expensify/App/issues/45451#issuecomment-2240915521.

Can anyone confirm if I can access this page by:

Start new chat button
Add a few people
Go to details
Go to members
cc @shawnborton @trjExpensify

In that particular example, we're talking about when you make a chat with multiple people (not a #room).
So you are correct in your steps you laid out.

[x] [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

NewFeature
Regression Test Proposal
Note: This new feature is only visible / testable in narrow layout devices on the following platforms:

iOS: mWeb
iOS: Native
Android: mWeb
Android: Native

Tests

1. Workspace - Members

Log in to the app.
Go to existing Workspace or create a new one.
Go to Members (as an admin).
Add a few members if you are alone.
Long press on any member.
Choose "Select" .
Select and unselect options and test some bulk action.

2. Workspace Distance Rates

Log in to the app.
Go to existing Workspace or create a new one.
Go to Distance Rates (as an admin).
Enable Distance Rates in More features if not already enabled.
Add a few distance rates if there is only one rate.
Long press on any distance rate.
Choose "Select".
Select and unselect options and test some bulk action.

3. Workspace Categories

Log in to the app.
Go to existing Workspace or create a new one.
Go to Categories (as an admin).
Enable Categories in More features if not already enabled.
Long press on any category.
Choose "Select".
Select and unselect options and test some bulk action.

4. Workspace multi level Tags

Log in to OD.
Go to Workspace settings.
Go to Tags and enable it if not already enabled.
Enable People must tag expenses and Use multiple level of tags.
Import some multi level Tags (eg. this ).
Go to ND.
Go to the same Workspace and Tags page.
You should not be able to select any Tag on the main page.
Go to Tag details.
You will see Tags inside.
Long press on any tag.
Choose "Select".
Select and unselect options and test some bulk action.

5. Workspace single level Tags

Log in to the app.
Go to existing Workspace or create a new one.
Go to Tags (as an admin).
Enable Tags in More features if not already enabled.
Add a few Tags.
Long press on any tag.
Choose "Select".
Select and unselect options and test some bulk action.

6. Workspace Taxes

Log in to the app.
Go to existing Workspace or create a new one.
Go to Taxes (as an admin).
Enable Taxes in More features if not already enabled.
Add a few tax rates
Long press on any tax rate.
Choose "Select".
Select and unselect options and test some bulk action.

7. Workspace Report Fields
Precondition: Access to the Report Fields feature.

Log in to the app.
Go to existing Workspace or create a new one.
Go to Report Fields (as an admin).
Enable Report Fields in More features if not already enabled.
Add a few items.
Long press on any report field.
Chose "Select".
Select and unselect options and test some bulk action.

8. Workspace Report Fields - Add list type report

Log in to the app,
Go to existing Workspace or create a new one.
Go to Report Fields (as an admin).
Enable Report Fields in More features if not already enabled.
Click "Add field".
Fill required fields.
Choose "List" type.
Choose "List values" .
Add a few values.
Long press on any of the added values.
Choose "Select".
Select and unselect options and test some bulk action.

9. Group chat -> Members

Log in to the app.
Go to existing group chat (if you don't have any go to point 3 otherwise go to point 6).
Click + button.
Choose Start chat.
Add a few people to the chat.
Go to chat details.
Go to members.
Long press on any member.
Choose "Select".
Select and unselect options and test some bulk action.

10. Search

Log in to the app (use account with existing transactions or create a several new transactions).
Go to Search Tab (from bottom tab).
Long press any transaction.
Choose "Select" option.
Select and unselect options and do some bulk action.

Do we agree 👍 or 👎.

There is a bug. Please take a look - https://github.com/Expensify/App/pull/46096#issuecomment-2273409940.

@rezkiy37 Thanks! That'll get handled in the fix PR https://github.com/Expensify/App/pull/46698

cc @trjExpensify For payment, in case this fell off your radar.
Note: There were regressions with this one, so payment should be halved, @jasperhuangg to confirm!

Yep! Payment summary as follows:

$125 to @ikevin127 for the C+ review

Regression tests for the Search project will be handled centrally. Offer sent.

@trjExpensify Offer accepted, thank you!

Paid, closing!


feat: enable partitioning by DATE column

Fixes https://github.com/googleapis/python-bigquery-sqlalchemy/issues/1056
Recreating #1057 from a user fork to allow edits by maintainers. cc @chalmerlowe

@bnaul
I just made a PR to do this same thing and when I came here to incorporate it into this repo, I noticed you had done the same. Ha ha. 😃
Gonna let the tests run and make sure they pass.


Fix ordering of endpoint delete from pollset set and transport destruction

We should make sure to delete the endpoint from the pollset_set BEFORE we destroy the transport so as to avoid any data races or faults.

Thanks for reviewing!


MAISTRA-1724 Don't watch namespaces if MRC is used

This will remove the need for namespace permissions if the MRC is used. Instead of creating a controller that watches namespaces on the API server, we only react to the UpdateNamespaces() calls from the MRC.

/retest

/retest

/retest


BZ1345832:  memory metric not being rolled up to OSP Availability zones

This PR adds derived_memory_used to metric rollups for Availability Zones. This resolves BZ #1345832: https://bugzilla.redhat.com/show_bug.cgi?id=1345832

@sseago Please change the commit message to remove the BZ from the commite message title, and then add a line to the commit message with the full link to the BZ.  This will allow the bot to comment on the BZ when the PR is merged. See https://github.com/ManageIQ/guides/blob/master/coding_style_and_standards.md#commits

@miq-bot add_label darga/yes

looks good :+1:

@blomquisg can we merge this one?

@miq-bot assign @chessbyte

Darga backport details:
commit 2fc39b1b2f80d8011a206e25fedd2f5541ef012a
Author: Oleg Barenboim<EMAIL_ADDRESS>Date:   Tue Jul 19 17:13:20 2016 -0400

    Merge pull request #9726 from sseago/bz1345832-memory-metric

    BZ1345832:  memory metric not being rolled up to OSP Availability zones
    (cherry picked from commit 964e766b48e3aca3bece6246ba7ec4463c831594)


Fix versioned codeblocks

These aren't tested and it doesn't look like anyone is depending on them (one of them even had a typo, so couldn't ever have run), but I don't think it hurts to keep them in.

Codecov Report

Merging #32 into master will decrease coverage by 61.77%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #32       +/-   ##
========================================
- Coverage   61.77%    0%   -61.78%
========================================
  Files           5     5
  Lines         858   858
========================================
- Hits          530     0      -530
- Misses        328   858      +530

Impacted Files
Coverage Δ

src/CUBLAS.jl
0% <ø> (-13.8%)
:arrow_down:

src/libcublas.jl
0% <0%> (-0.42%)
:arrow_down:

src/util.jl
0% <0%> (-100%)
:arrow_down:

src/blas.jl
0% <0%> (-93.43%)
:arrow_down:

src/highlevel.jl
0% <0%> (-45.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b2d6d...c829309. Read the comment docs.


The word "undifined" shows up on the Photo home page

The word "undifined" shows up on the Photo home page, top right when first navigating to the page in Chrome browser.
This only happens on a new load, a refresh of the page does not show the error.
http://www.boonex.com/forums/topic/Error-Photos-home-page-in-Chrome.htm

https://github.com/boonex/dolphin.pro/issues/31

Has this been fixed?


Navbar 16 Improved & Made Responsive

I have Improved the Navbar 16 and made it responsive at Navbar/srv/navbar-16.html

Looks amazing 😄 @RavindraP04


options for setValues doesn't work

Either
setValues({ foo: foo }, { override: true }) // foo is an object

or
setValues({ foo: foo }, true) // foo is an object

are sending out
SET foo = $foo

BTW, I think default value should be { override: false } to be compatible with previous versions

When you set override to true, SET foo = $foo is the expected output because all of the properties of foo will be overridden. If you would like to use += in cypher, pass false or nothing at all as false should be the default value anyway.

so, it's a document bug? lol

Yes you were right about the documentation errors, I've fixed them in a branch so they should be released soon. Using the += operator (false) should always be the default and I'm working on making that more consistent across all the set family of methods.

:tada: This issue has been resolved in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Internal error: invalid thread ID 145 in GC work pass

Just wanted to report this bug. The Bailador server regularly crashes with this error:
Internal error: invalid thread ID 145 in GC work pass
I'm currently on:
This is Rakudo version 2016.09-19-g8be36b1 built on MoarVM version 2016.09
implementing Perl 6.c.
I'm afraid I can't reliably replicate it as it seems to occur randomly.

closed because it seems to be a perl6 internal issue


Can't create a Challenge due to existing deleted challenge with same name

Create a challenge named "This is a test"
Then delete that challenge (soft) so it still shows up when you get a list of challenges from the project.
then try to create a challenge with the same name: "This is a test".

I get an error: 500
{
"status": "KO",
"message": "Challenge with name This is a test already exists in the database"
}

Any news on this issue? I have the same problem.
Currently my (dirty) workaround is to add a single whitespace at the end of the challenge name. Also tried to change upper-/lower-case, but that didn't work as challenge names seem to be case insensitive.

I think there is a way to permanently delete the challenge, but it may take a day or so I think. I've just resolved to rename challenges that I'm going to delete BEFORE I delete them.


C_CPP : Hamiltonian Path

Description
Description : Hamiltonian path in graphs.
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Add kotlinOptions jvmTarget to templates

Adds jvmTarget to gradle templates.
Fixes https://github.com/flutter/flutter/issues/147185.
Interestingly, we already had this in many of our examples/tests, see search results here https://github.com/search?q=repo%3Aflutter%2Fflutter jvmTarget&type=code.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This sounds like a good idea to me. Example:
android {
    namespace "com.example.example_huy"
    compileSdk flutter.compileSdkVersion
    ndkVersion flutter.ndkVersion

    compileOptions {
        sourceCompatibility flutter.jvmTargetVersion
        targetCompatibility flutter.jvmTargetVersion
    }

    kotlinOptions {
        jvmTarget = flutter.jvmTargetVersion
    }

    ...
}


[SPARK-6872] [SQL] add copy in external sort

We need add copy before call externalsort.

Test build #30123 has started for   PR 5481 at commit 9611586.

Test build #30123 has finished for   PR 5481 at commit 9611586.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30123/
Test PASSed.

Thanks, merged to master.


Anaconda - Can't upgrade from 0.4 to 1.x

Hi,
I found nothing relating either here in github or in stackoverflow so I open a new ticket (I may have not search well enough, feel free to redirect me if necessary).
I am using Anaconda 4.1.1 with Python 3.5. I installed a couple of weeks ago cvxpy following the instruction found in the tutorial: conda install -c cvxgrp cvxpy. I am surprised that the version installed is the 0.4.2. I tried everything I know to upgrade (excepting pip as I need a compiled version, indeed I lack of visual c++ to build a wheel myself). Each time conda says that all requested packages already installed.
Does it means that the version on cvxgrp is still the 0.4.2? Or versions >=1.0 are incompatibles with Python 3.5? The documentation says nothing about that.
Thanks in advance.
J

We do not currently have a conda version for Python 3 on Windows. You need to install with pip if you want to use Python 3 on Windows.

#492

Thanks for the feedback. I fear I cannot be of any help on that matter.
Maybe a note about that issue in the documentation could be added.
Thanks.


Add [IF NOT EXISTS] to CREATE VERTEX

@gramian kindly pointed out that there is a separate section for CREATE ... TYPE, which actually does specify the [IF NOT EXISTS] option. Therefore, the non-type version of CREATE VERTEX shall not be updated anyway, and this PR is closed.


[SIL Optimizer] Determine feasibility of dynamic casts between tuple types

The SIL optimizer logic that determined feasability of dynamic casts
completely ignored tuple types, therefore assuming that they would
always fail. Check for structural identity, ignoring adding/removing
labels.

Resolves rdar://problem/28121915.

@swift-ci please test

@swiftix please review

@DougGregor LGTM! Thanks for fixing this!


Update rubocop dependencies

Upgrades RuboCop dependencies which solves following issues with rexml:
https://nvd.nist.gov/vuln/detail/CVE-2024-41123
https://nvd.nist.gov/vuln/detail/CVE-2024-41946

Sorry, just saw this now, I updated rexml on master directly.
But I wonder what kind of tool you might be using for it to care about the dev dependencies of redis-client. That's totally ridiculous.

It is reported by the Amazon Inspector. I agree with your point about dev dependencies.
In my case, this brings up additional issues with compliance audits, which is why I opened the PR. In any case, thanks for taking the time!

It is reported by the Amazon Inspector.

Interesting.
@jterapin @mullermp, apologies for the ping, but since we interacted recently: would you happen to know if there's a way to send feedback to the Amazon Inspector team to ask them to not scan dev dependencies?

Yes. @mladenilic Can you file a support ticket through the AWS console? That would be the best way.

Amazon Inspector team acknowledges that the current scanning approach might lead to false positives, where vulnerabilities are reported for components that do not pose an actual risk due to not being used at runtime. However, they also believe it's still valuable to be aware of these potential vulnerabilities.
The response also mentions a new matching engine which may improve the accuracy, but it's unclear if this will specifically address the issue of unused dependencies.
Anyway, my specific problem will be solved once new gem version gets released, since f9641cf removes Gemfile.lock from the gem package. In the meantime we have documented the vulnerability as a low risk to the environment will wait for new version of redis-client.
Thank you both!


WinSDK: add some more constants to the overlay

The WinReg.h constants for the register hives are not imported through
the clang importer due to the complicated casting.  Duplicate the values
to allow usage in Swift.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test


Add support for adding custom labels and environment variables to nodes via spec

Greetings!
This pull-request resolves #135 by adding support add custom labels and environment variables to nodes via spec, which get propagated to the node deployments/pods.
  nodePools:
    - component: nodes
      ...
      labels:
         myLabel: foo
         anotherLabel: bar
      env:
        - name: qux
          value: "quux"
        - name: quuz
          valueFrom:
            configMapKeyRef:
              name: quuz-configmap
              key: corge

I also added test coverage for user defined labels and env vars.

Two comments from my side:

I would prefer the field to be named just env instead of envVars, that way we would be consistent with kubernetes naming
We should consider making it more generic so that users can specify the same things as they can in a pod spec (so not just value but also valueFrom)

Two comments from my side:
* I would prefer the field to be named just `env` instead of `envVars`, that way we would be consistent with kubernetes naming

* We should consider making it more generic so that users can specify the same things as they can in a pod spec (so not just value but also valueFrom)

Sounds good. I've made these changes and squashed the commits.

LGTM. If you could work in the complaint from the linter, I'll approve the PR.

LGTM. If you could work in the complaint from the linter, I'll approve the PR.

All set.

@jlamillan Merged. Thank you for your work with this PR. Much appreciated.


Demo app fixes after #981 refactor

Coverage decreased (-2.2%) to 95.764% when pulling 79f9f62a19a3fbab14b3d31de328621aa9433ca9 on elastic-coders:fixes_for_demo_refactor into a5b75e03c00d09e1b1fe54f1051a74217f93ed0a on KeepSafe:master.

Thanks!!!


Misleading error message while logging in(SSO) if user has no access

Use case: user's email id is "not provided access" , user tries to login using SSO.
Issue: Incorrect error message
To-do: https://zpl.io/bJMo3D6

@chtnnh Sorry for the delayed response, are you still open to work on this issue?


Runtime error during local development

I'm seeing the following runtime error when I try to run the extension locally:

I think it might be an issue with how the examples were loaded to Big Query. Is explore_assistant_examples supposed to have a separate row for each example (i.e. {'input': ..., 'output': ...}) or is it supposed to have a single row with the examples packed into an array (e.g. [{'input': ..., 'output': ...}, {'input': ..., 'output': ...}]).

Nevermind. The issue was that I didn't have any examples loaded into explore_assistant_refinement_examples. It's working now

Hi, I have the same problem, I have deployed a GCP instance for the frontend and we are using BigQuery as backend the backend deployment was made with the example found in the repository.
All in the same project. The Bigquery API has been enabled at the instance level. On the other hand the nginx has been installed, to perform proxy with the application.
Also take down the examples in the bigquery.
charge the capture of one of the examples.

Thanks in advance for any help.

I have the same error with the BigQuery Backend... in my case both tables have examples loaded into them successfully (via the script) and the BQ connection works fine from Looker. I have verified the data is present in BigQuery Studio. On the BigQuery side I can see some queries coming in and I see the following errors in the logs:
Syntax error: SELECT list must not be empty

I can see the select statement in the js and it does look fine though (SELECT examples FROM...). Could be an escaping/encoding issue with the query string perhaps, which has newline chars encoded into it.

I also got this error with the BigQuery backend. In my case I verified via BigQuery Studio that both example tables are loaded with data (using the script provided). The BigQuery connection was also working fine.
On the BigQuery side, I can see requests coming in via the logging console but no errors. However, when looking at the query traces, I could see the query using a WHERE explore="model:explore" syntax in its constraint. This was unexpected and should be documented in the examples script documentation. Those scripts take a --explore_id arg which should actually be populated with a model:explore syntax in order for this to work. After re-running those scripts with the correct explore_id the error cleared.

@cavvia there will be some documentation updates coming soon that will cover unclear instructions like the proper format the explore_id.


sst build fails with new Astro update

sst build

Error: Cannot find package 'astro-sst' imported from
.../node_modules/sst/constructs/AstroSite.js
Trace: Error: Cannot find package 'astro-sst' imported from
.../node_modules/sst/constructs/AstroSite.js
at __node_internal_captureLargerStackTrace (node:internal/errors:497:5)
at new NodeError (node:internal/errors:406:5)
at packageResolve (node:internal/modules/esm/resolve:789:9)
at moduleResolve (node:internal/modules/esm/resolve:838:20)
at defaultResolve (node:internal/modules/esm/resolve:1043:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:228:38)
at ModuleWrap. (node:internal/modules/esm/module_job:85:39)
at link (node:internal/modules/esm/module_job:84:36)
at process. (file:///.../node_modules/sst/cli/sst.js:62:21)
at process.emit (node:events:526:35)
at process.emit (node:domain:488:12)
at process._fatalException (node:internal/process/execution:159:25)
at processPromiseRejections (node:internal/process/promises:289:13)
at process.processTicksAndRejections (node:internal/process/task_queues:96:32)
Need help with this error? Post it in #help on the SST Discord https://sst.dev/discord

If you've already posted your issue on Discord, make sure to leave a link to it here.

Looking into it

I am also getting this error, when trying to deploy to AWS (AWS sst project)

@fwang?

Auto-closed b/c the pr w/ fix was merged. Re-opening it until the fix is verified.

So happy to see how quickly this is being fixed @fwang! Literally just starting to use SST this morning, and was running into this, and it gives me a lot of reassurance moving forward knowing that bugs are taken seriously 🙏🏼

Fixed in v2.28.0.
You can either update sst to 2.28.0 in package.json. Or run npx create-sst@latest again to start from scratch.


Debt 835 pylint

What is the context of this PR?
Codacy uses pylint for linting which gives differing results to the flake8 which is ran locally and on builds therefore we don't know about some of the linting issues until it's passed through codacy which can mean waiting another iteration of the build.
The changes I have made is to use pylint instead of flake8.
I have also applied pylint to the test code.
How to review
Tests continue to pass

I believe we have decided to go with pylint unless I am wrong @ajmaddaford?

Without this PR identifying why we would use PyLint over Flake8, I'm not sure I can approve this. Switching over to it simply because one of our two quality tools uses it seems a bit premature.

Flake8 gives us linting and cyclomatic complexity evaluation, pylint also applies these checks.
Flake8 doesn't apply strict pep 8 styling check it uses it's owned styling inspired by pep 8 checks. Pylint follows pep 8 more closely.
A benefit of sticking to pep 8 styling guide is that it conforms with the generally accepted styling guide which other tools such as pycharm uses.
Non of the static code analysis tools that we use apply flake8 style checks but codacy does apply pep 8 checks. This can be frustrating and can waste time if the builds pass but it fails linting because the tools we use don't match the style.

On using pylint rather than flake8, pylint appears to be stricter than flake8 - on master, running flake8 on the tests - flake8 tests - generates no issues, running pylint - pylint --rcfile=.pylintrc ./tests - generates lots of valid issues.
Codacy can be configured to use the .pylintrc from the repo so we would get consistent checks locally and via status checks on pull requests.
Before we can merge this we need to ensure we consider the functionality provided by the flake8 plugins - flake8-print, pep8-naming, flake8-blind-except, flake8-commas, flake8-debugger, flake8-mock, flake8-tuple - these need to be reviewed to determine if pylint covers what they do, or they are no longer required.
I also ran pep8 and this generates style issues not picked up by pylint e.g.
./token_generator.py:13:13: E126 continuation line over-indented for hanging indent
./app/settings.py:74:45: E241 multiple spaces after ':'
./app/settings.py:75:45: E241 multiple spaces after ':'
...
./app/libs/utils.py:17:35: E226 missing whitespace around arithmetic operator
./app/submitter/converter.py:120:42: E126 continuation line over-indented for hanging indent
./app/templating/metadata_context.py:45:22: E241 multiple spaces after ':'
./app/validation/type_validator_factory.py:34:13: E123 closing bracket does not match indentation of opening bracket's line
...

I think we need pylint to pick these up, or also run pep8. As this pull request is already quite large it would probably be best to tackle those issues in another pull request.

I think we will need to review what is ignored in the .pylintrc if we go ahead with but I'll raise a card to do that as this PR is a bit unwieldy as it is

√ flake8-commas - https://github.com/taozle/pylint-comma
~ flake8-print - Checks for print statements in form print 'test' but not print('test')
√ pep8-naming - currently disabled in .pylintrc as invalid-name
√ flake8-blind-except - Caught as bare-except
x flake8-debugger
x flake8-mock
√ flake8-tuple - Caught as superfluous-parens

As we can't cover all of the checks done by flake8 with pylint plugins, we're going to use both.


An allocation constraint mechanism, that de-prioritizes nodes from getting picked for allocation if they breach certain constraints

Signed-off-by: Ashwin Pankaj<EMAIL_ADDRESS>Description
An allocation constraint mechanism, that de-prioritizes nodes from getting picked for allocation if they breach certain constraints
Issues Resolved
#487
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is this still a WIP? This is also a new feature, correct? And are you wanting to target the 1.0 release?

Hi @nknize ,

Is this still a WIP?
Yes - I was just waiting for final sign-offs from reviewers.

This is also a new feature, correct?
Yes

And are you wanting to target the 1.0 release?
Yes

Looks good, Ashwin. There is more scope in hotspots and constraint tests for randomization, but I will let you decide that since the tests are pretty exhaustive.

start gradle check

@ashwinpankaj could you also raise a backport PR on 1.x if this needs to be backported? The 1.0 freeze is today eod just fyi. If missed, this can go in 1.1.
I would let @itiyamas approve and merge this PR to main.

@setiah @itiyamas does not have merge permissions AFAIK.
Would request someone with permissions to merge it to main.

I have merge permissions, but I am waiting for one more review on this PR.
@shwetathareja Please help review this.

Looks good, Ashwin. There is more scope in hotspots and constraint tests for randomization, but I will let you decide that since the tests are pretty exhaustive.

yes +1 @ashwinpankaj we can create a separate issue to evaluate adding randomization in tests and proceed with merge on this one.


checks and tests on CI or pre-commit

So, now that we've added tests and a linter, I'd like to get from you an exhaustive list of the checks we want to run and where to run them.
I'd say the location where we can run them is:

client on pre-commit
ci

First question: do you confirm that the only pipeline we're going to use will be github actions? I've seen also the vercel's integration, do we want to shut that off or we keep it just for the previews (that I can't access btw)?
Based on the location, the available checks are:
On CI:

biome:ci

On pre-commit:

biome:write

Location agnostic:

playwright

Second question: regarding biome, do we want to run it on pre-commit or ci? (consider we can also do both, but the --write option should only be used on client imho, I don't like re-pushing on the repo from the ci).
Third question: do you want to run the tests on the production website or on the code the pr changed? Do we want to do both and split the workflows into two, one for the staging app and one for the prs?

hi @giacomocerquone, You did a great job!
1 -  My idea is to change the way we release the application. Basically, I'd like to deliver on tag. To do that we could remove the vercel integration and add a proper github action as https://github.com/marketplace/actions/vercel-action. Alternatively, we could keep the vercel integration bound to a new production branch and push to that branch on tag
2 - We can start lean and add biome check only in the CI (no --write flag of course). @davc0n hates pre-commit and I want to make him happy (waiting for him to change his mind😂)
3- As I understood public repo are not charged and we take advantage of unlimited github actions runs. We can add test check on pr and the main commit
Any other idea is welcome

hi @giacomocerquone, You did a great job! 1 - My idea is to change the way we release the application. Basically, I'd like to deliver on tag. To do that we could remove the vercel integration and add a proper github action as https://github.com/marketplace/actions/vercel-action. Alternatively, we could keep the vercel integration bound to a new production branch and push to that branch on tag 2 - We can start lean and add biome check only in the CI (no --write flag of course). @davc0n hates pre-commit and I want to make him happy (waiting for him to change his mind😂) 3- As I understood public repo are not charged and we take advantage of unlimited github actions runs. We can add test check on pr and the main commit Any other idea is welcome

So whatever you prefer I'd say. Probably it's more work than needed to bring the vercel action in here than setting the vercel pipe to only watch and release the production branch
ahaha I hate pre-commits as well but I get there are situations in which it might come in handy
very good news


Text search for my username inconsistent

Search for PlaneMad > 1 result. Search for users:PlaneMad > 3 results
Both should give 3 hits?

@planemad the feature to search with "users: ... " was not implemented. It now is. Searching for just PlaneMad would search the text for the word PlaneMad whereas users:PlaneMad will return results for the user PlaneMad. As such, I would expect that results are inconsistent. Closing.

Searching user:planemad gives results from other users which does not seem to be connected to me in any way. Can you check?
users:planemad gives no results. So its user and not users right?

@planemad it is users and usernames on OSM are case sensitive so you would search for users:PlaneMad. Please close if this works.

works :+1:


[Bug] Resources are not cleaned up in Grafana when changes in instanceSelector are made

Describe the bug
As it was highlighted in https://github.com/grafana/grafana-operator/pull/1497#issuecomment-2093391039, the operator does not clean up resources (across Grafana instances) that no longer match instanceSelector.
Version
v5.9.0
To Reproduce
Steps to reproduce the behavior:

0. Deploy `Grafana`
apiVersion: grafana.integreatly.org/v1beta1
kind: Grafana
metadata:
  name: grafana
  labels:
    dashboards: "grafana"
spec:
  config:
    log:
      mode: "console"
    auth:
      disable_login_form: "false"
    security:
      admin_user: root
      admin_password: secret

1. Deploy `GrafanaDashboard` that matches the `Grafana` instance
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDashboard
metadata:
  name: grafanadashboard-sample
spec:
  resyncPeriod: 30s
  instanceSelector:
    matchLabels:
      dashboards: "grafana"
  json: >
    {
      "id": null,
      "title": "Simple Dashboard",
      "tags": [],
      "style": "dark",
      "timezone": "browser",
      "editable": true,
      "hideControls": false,
      "graphTooltip": 1,
      "panels": [],
      "time": {
        "from": "now-6h",
        "to": "now"
      },
      "timepicker": {
        "time_options": [],
        "refresh_intervals": []
      },
      "templating": {
        "list": []
      },
      "annotations": {
        "list": []
      },
      "refresh": "5s",
      "schemaVersion": 17,
      "version": 0,
      "links": []
    }

2. Adjust `instanceSelector` in `GrafanaDashboard`, so it no longer matches the `Grafana` instance
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDashboard
metadata:
  name: grafanadashboard-sample
spec:
  resyncPeriod: 30s
  instanceSelector:
    matchLabels:
      dashboards: "grafana2"
  json: >
    {
      "id": null,
      "title": "Simple Dashboard",
      "tags": [],
      "style": "dark",
      "timezone": "browser",
      "editable": true,
      "hideControls": false,
      "graphTooltip": 1,
      "panels": [],
      "time": {
        "from": "now-6h",
        "to": "now"
      },
      "timepicker": {
        "time_options": [],
        "refresh_intervals": []
      },
      "templating": {
        "list": []
      },
      "annotations": {
        "list": []
      },
      "refresh": "5s",
      "schemaVersion": 17,
      "version": 0,
      "links": []
    }

Expected behavior
The dashboard should be gone from Grafana.
Runtime (please complete the following information):

Grafana Operator Version: v5.9.0
Environment: Kubernetes

Cleaning up resources on a change of the instanceSelector is difficult to realize since the operator only ever knows about the current version of the resource.
This is also the reason as to why the selector field of deployments and stateful sets are immutable.
To be consistent with the rest of the Kubernetes ecosystem, this should be resolved by setting the instanceSelector to be immutable like this: https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/#immutablility-after-first-modification


Werewolves shaking

Werewolves, at least in the GWD, seem to shake when standing still.

l

This is a Jagex issue or a animation smoothing bug, If animation smoothing is turned on turn it off

definitely animation smoothing. Thanks for the fix

Report it in the runelite chat please :)

Will do


Create custom input (Just a string of text instead of an input)

Issue
Is there any way to have the input just be a string of text, such as "Edit Date"? So that when the user clicks the text, the date picker pops up?
Not just style the input, but rather replace the input with something completely different. Is this possible as of now?

Got Any Solution for this?


loosen the version of rimraf module

I think there is no reason to pin the rimraf version to 2.5.2 strictly.
close https://github.com/benmosher/eslint-plugin-import/pull/752
close https://github.com/benmosher/eslint-plugin-import/pull/750

Coverage decreased (-1.3%) to 93.616% when pulling c3c758d758310609c0f256777e4519c24eac53cb on shinnn:rimraf into 98e7048e7056424d1da6357cffd8e023db5f18c8 on benmosher:master.

Rebased from the latest master branch.

Coverage decreased (-1.3%) to 93.891% when pulling 9a69905cb5eaa55302219953590507fa530ff147 on shinnn:rimraf into 3c46d308ccb462a52554257c49c374045d1a6cf7 on benmosher:master.


closurecompiler: 20200614 -> 20200719

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/closure-compiler/versions.
meta.description for closurecompiler is: "A tool for making JavaScript download and run faster"
meta.homepage for closurecompiler is: "https://developers.google.com/closure/compiler/"
meta.changelog for closurecompiler is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 20200719 with grep in /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719

directory tree listing: https://gist.github.com/47e4bf38dde80ed6752ce1fe4ee53ed7

du listing: https://gist.github.com/b826e81f052327ac83b36048aa299b4a

Rebuild report (if merged into master) (click to expand)

57 total rebuild path(s)

19 package rebuild(s)

19 x86_64-linux rebuild(s)
17 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
17 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
closurecompiler
emscripten
faust
faust2
faust2alqt
faust2alsa
faust2csound
faust2firefox
faust2jack
faust2jackrust
faust2jaqt
faust2ladspa
faust2lv2
faustlive
foo-yc20
meguca
purePackages.faust
tambura
tree-sitter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A closurecompiler https://github.com/r-ryantm/nixpkgs/archive/1f9ccd8264e266c62c96cb1895a516a89e6e6a6d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719
ls -la /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

21 packages failed to build:

emscripten
emscriptenPackages.json_c
emscriptenPackages.libxml2
emscriptenPackages.xmlmirror
emscriptenPackages.zlib
faust
faust2alqt
faust2alsa
faust2csound
faust2firefox
faust2jack
faust2jackrust
faust2jaqt
faust2ladspa
faust2lv2
faustlive
foo-yc20
meguca
purePackages.faust
tambura
tree-sitter

1 package built:

closurecompiler

Maintainer pings

As a maintainer of the faust packages, I feel I need to test this, but I don't even know what it is!
Could someone enlighten me?
Pinging the last 3 people that merged commits to this file:
@marsam @Mic92 @xeji

@magnetophon It optimize javascript code by removing dead code and minifies it.

Thanks!

I believe all of the build errors were due to the emscripten build failure.


Add error reporting when the SUBJKT is already registered

would be cool to have a clearer error mssg when trying to pic a profile name in "seetings" that has already been chosen
currently the only thing that happens is that "transaction fails"

Closing in favor of #26


Implement CLUSTER RESET

It appears support for CLUSTER RESET is missing.

Do you think you can submit at pull request, based on my commit for cluster
forget?

Yes, I'll do that.

I forked the repo and run make, on mac os x (el capitan) using go 1.5.1 and all tests fail, it seems perhaps it's not starting redis. Attached is the output from running make.
output.txt

@mindscratch looks like Redis process can't start
      <*exec.ExitError | 0xc8204fc320>: {
          ProcessState: {
              pid: 35861,
              status: 256,
              rusage: {
                  Utime: {
                      Sec: 0,
                      Usec: 629,
                      Pad_cgo_0: [0, 0, 0, 0],
                  },
                  Stime: {
                      Sec: 0,
                      Usec: 1404,
                      Pad_cgo_0: [0, 0, 0, 0],
                  },
                  Maxrss: 688128,
                  Ixrss: 0,
                  Idrss: 0,
                  Isrss: 0,
                  Minflt: 199,
                  Majflt: 0,
                  Nswap: 0,
                  Inblock: 0,
                  Oublock: 0,
                  Msgsnd: 0,
                  Msgrcv: 0,
                  Nsignals: 0,
                  Nvcsw: 0,
                  Nivcsw: 1,
              },
          },
      }
      exit status 1

Most likely because you did not install test dependencies https://github.com/go-redis/redis/blob/master/Makefile#L5

@vmihailenco I do have the test dependencies. I've tried explicitly starting the redis server using .test/redis/src/redis-server, and then running make. Same problem with all of the tests failing.

If you start tests with verbose -v flag you will see output from redis-server. That can help you to resolve the issue if you are still interested :)
BTW CLUSTER RESET was added in https://github.com/go-redis/redis/pull/223


Restructures the project

The project was restructuring in flavor to Packing Python
Projects[1] specifications and Flask Extensions Builind[2].

Replace flask_jsonrpc/ directory to src/flask_jsonrpc
Add documentation (structure) in Read The Docs
Add support tox tools
Add code of conduct (from https://www.contributor-covenant.org)
Change setup.py in flavor to metadata
Upgrade copyright dates
Add security check in CI

[1] - https://packaging.python.org/
[2] - https://flask.palletsprojects.com/en/2.0.x/extensiondev/

Coverage remained the same at 100.0% when pulling 4b61048b00aead1bbf2f4a9a022b34523231fa7a on feature/py-structure into 0707f1196403e098fd3d7a8b64b53a2764b2e490 on master.


PackagesNotFoundError: The following packages are not available from current channels:

$ conda install pythainlp
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

  - pythainlp

Current channels:

  - https://repo.anaconda.com/pkgs/main/osx-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/free/osx-64
  - https://repo.anaconda.com/pkgs/free/noarch
  - https://repo.anaconda.com/pkgs/r/osx-64
  - https://repo.anaconda.com/pkgs/r/noarch
  - https://repo.anaconda.com/pkgs/pro/osx-64
  - https://repo.anaconda.com/pkgs/pro/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.

Do you have plan to release it in conda?

No , we haven't plan to release it in conda soon.

You can install pip package in conda environment.
See https://conda.io/docs/user-guide/tasks/manage-pkgs.html#installing-non-conda-packages

Windows, in Anaconda Prompt, run:
activate myenv
macOS/Linux, in Terminal, run:
source activate myenv

pip install pythainlp

conda list


Calling scrollToRow() on List no longer works after updating React to v16.4.1

I have a fairly complicated app where this issue is occurring, so it is not so easy to include a simple example showing the problem. Essentially what I am doing is calling
this._pdfView.getWrappedInstance().list.scrollToRow(index);

where this._pdfView is a ref to a connected component (hence the getWrappedInstance() call), which in turn has a getter to access the ref to a List component. I use a combination of WindowScroller, AutoSizer and List. Important to note is that this is an issue specifically with React v16.4.1. If I revert to React v16.3.0 everything works like expected.
If this information is not sufficient, I will try to attach a minimal example that reproduces the problem. I understand that otherwise it will be difficult for you to track down the problem.
What is the current behavior?
Calling scrollToRow() no longer scrolls to the right row. In fact, it doesn't seem to be doing anything anymore.
What is the expected behavior?
It should scroll to the row given by the index.
Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?

Browser
Chrome v67

OS
OSX 10.13.6

React
16.4.1

React DOM
16.4.1

react-virtualized
9.20.1

Have same problem too, but with scrollToCell in Grid. It is working with 16.3, but breaks on >=16.4.
I'm using MultiGrid wrapped in AutoSizer and calling scrollToCell like this:
this._grid._bottomRightGrid.scrollToCell({columnIndex, rowIndex})
I've spent some time in debugger and noticed, that setState on this line is not updating Grid's state (scrollTop/scrollLeft fields):
https://github.com/bvaughn/react-virtualized/blob/master/source/Grid/Grid.js#L1528
It seems setState returns previous cache of the state and not updating it.

How to reproduce
I'm finely reproduced this issue:
Working example. React 16.3: https://codesandbox.io/s/llq660v04l
Broken after updating to React 16.4.1: https://codesandbox.io/s/1v4r4nqpz4
Change values in input with label Scroll to column or Scroll to row. In the first example it will scroll to specified column, but nothing will happen if we update React to 16.4.1 (second example)

Hi,
I have the same problem with the scrollToPosition and React 16.4.
Here is what I have found:
A bug fix has been done on React 16.4 on the getDerivedStateFromProps, see https://reactjs.org/blog/2018/05/23/react-v-16-4.html#bugfix-for-getderivedstatefromprops
The important part is:

getDerivedStateFromProps is now called every time a component is rendered, regardless of the cause of the update. Previously, it was only called if the component was re-rendered by its parent, and would not fire as the result of a local setState.

Here is the code from React Virtualized Grid in the getDerivedStateFromProps
https://github.com/bvaughn/react-virtualized/blob/c646a62eb3f7aebdfe648bb71cb87545af4d3a9b/source/Grid/Grid.js#L839-L845
The nextProps.scrollTop always erase the new value of prevState.scrollTop because it's not anymore the previous state but the new one.

I've made a PR which should fix this issue.

Has this regressed for anyone else? It looks like it got backed out in #1446.

Will investigate!

Facing similar issues with scroll to index / scroll to row

@wuweiweiwu  were you able to track this down at all?

@mozbhearsum
Have you fixed it for using with WindowScroller?
For my case, it works when not using the window scroller (for both scrollToRow and scrollToPosition),
while it doesn't work when using with WindowScroller.
"react": "^16.8.5",
"react-dom": "^16.8.5",
"react-virtualized": "^9.21.2"

@mozbhearsum
NOT Working with WindowScroller
For my case, I tested it works when NOT using the window scroller (for both scrollToRow and scrollToPosition),
while it doesn't work when using with WindowScroller.
"react": "^16.8.5",
"react-dom": "^16.8.5",
"react-virtualized": "^9.21.2"

@mozbhearsum
NOT Working with WindowScroller
For my case, I tested it works when NOT using the window scroller (for both scrollToRow and scrollToPosition),
while it doesn't work when using with WindowScroller.
"react": "^16.8.5",
"react-dom": "^16.8.5",
"react-virtualized": "^9.21.2"

Yeah it's still not working with WindowScroller

@mozbhearsum
NOT Working with WindowScroller
For my case, I tested it works when NOT using the window scroller (for both scrollToRow and scrollToPosition),
while it doesn't work when using with WindowScroller.
"react": "^16.8.5",
"react-dom": "^16.8.5",
"react-virtualized": "^9.21.2"

Doesn't work for me. I haven't tried any workarounds, though.

@mozbhearsum
NOT Working with WindowScroller
For my case, I tested it works when NOT using the window scroller (for both scrollToRow and scrollToPosition),
while it doesn't work when using with WindowScroller.
"react": "^16.8.5",
"react-dom": "^16.8.5",
"react-virtualized": "^9.21.2"

I opened another issue for that
https://github.com/bvaughn/react-virtualized/issues/1507

Any updates on this?

Any updates on this?

+1

This still doesn't work. I've moved out from react virtualized to react window.

please try the latest version! https://www.npmjs.com/package/react-virtualized/v/9.22.2

please try the latest version! https://www.npmjs.com/package/react-virtualized/v/9.22.2

It's not fixed for me.

My quick workaround was like that:
https://github.com/bvaughn/react-virtualized/issues/1507#issuecomment-683547612


Random error for buy and sell tx

With the last update, it doesn't buy any tokens. I tried to increase the waiting time for confirmTransactionWithTimeout to 15 seconds, but I still get Transaction confirmation timed out
This is my RPC Speed

Metric
Value

Transaction Delay
25 milliseconds

Number of Workers
10

Total Successful Transactions Sent
6559

Total Failed Transactions
10

Success Rate
99.85%

RPC Benchmark by ThorLabs
v0.1.7

Test Duration
60 seconds

All jobs are completed in
60.00 seconds

Sending Transactions Per Second (TPS)
109

Successful Transactions Per Second (TPS)
109

RPC Benchmark by ThorLabs
v0.1.7

Latency (ping RPC)
5.434 milliseconds

Minimum TX Response Time
42.720 milliseconds

Maximum TX Response Time
574.101 milliseconds

Average TX Response Time
65.688 milliseconds

Median TX Response Time
57.640 milliseconds

P90 TX Response Time
55.946 milliseconds

P95 TX Response Time
56.707 milliseconds

P99 TX Response Time
57.460 milliseconds

RPC Benchmark by ThorLabs
v0.1.7

Any suggestions?

thanks for report. I pushed more logging on latest master. tx code needs more testing and improving. likely can be improved with tweaking of prio fees
https://solana.stackexchange.com/questions/9482/solana-sendrawtransaction-confirmtransaction-confirmtransaction-takes-foreve

I increased the price and limit as per the suggestion. I even tried to increase the MAX_RETRY = 5. I can't figure out why it doesn't send another request if the last one failed.
ComputeBudgetProgram.setComputeUnitPrice({ microLamports: 10000000 }),
ComputeBudgetProgram.setComputeUnitLimit({ units: 1000000 }),


Demucs 4.0 released

Please update to include Demucs 4.0

UVR has been updated to include Demucs v4 and much more - https://github.com/Anjok07/ultimatevocalremovergui/releases

UVR has been updated to include Demucs v4 and much more - https://github.com/Anjok07/ultimatevocalremovergui/releases

Thank you very much 😊...  where can i find info on newly added demucs 4.0 models such as htdemucs, htdemucs_ff, htdemucs_6s and hdemucs_mmi

Thank you very much 😊... where can i find info on newly added demucs 4.0 models such as htdemucs, htdemucs_ff, htdemucs_6s and hdemucs_mmi

Ask their forum here: https://github.com/facebookresearch/demucs

Go to "Download More Models" under the model selections. You can download them directly from the application.


training problem

I have updated the version of tensorflow to nightly 1.6 and python to 3.5. However, when I run the scripts,  a problem occurred. Anyone has the similar problem?

Have you resolved the issue? Close for now.


Reset access code feature flag to false and remove unused err type

Reset access code feature flag to false and remove unused err type for linter
Description
Master broke because some unused code was caught by the linter.  In the process I also noticed that I accidentally merged a feature flag change that I had used for testing.  This fixes both.
Reviewer Notes
This is the PR that accidentally changed the feature flag. https://github.com/transcom/mymove/pull/6511/files
Setup
Master was broken due to some unused code. The fix should allow pass pre-tests to pass.
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Please frame screenshots to show enough useful context but also highlight the affected regions.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against a1c0730661669cb40c9db080271e29a2657f5a34


misc: move dependabot.yml to .github

Change-Id: I5c882afd1e15420b8fcdcc14895a77b275aedc4e

I think so. On documentation it says that the .dependabot.yml file should be in the default branch https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file.


Revert change to MQTT discovery_hash introduced in #18169

Description:
discovery_hash was changed in #18169 to be unique_id if present in the configuration.
This breaks the possibility to remove a previously discovered entity by sending an empty discovery update.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox.
[x] There is no commented out code in this PR.

@OttoWinter I think you suggested to use the unique_id as the discovery hash, although I can't find the comment.
If there was a good reason for that, maybe add a check for object_id being equal to the unique_id instead?

I think it was more of a question, like "what should we do if unique id changes?". The issue was that using the system you implemented first entities with unqiue ids would not be recreatable since their entity id registration would error out because of duplicate unique ids.
But anyway, yes the ability to remove discovered entities with unqiue id would be good. Personally I don't see an issue with doing it the old way, you probably won't see too many scenarios where unique IDs on the same entity changes dynamically in the wild anyway. I guess let's just keep that undefined behavior, it probably won't be an issue.

@OttoWinter OK, so this should be fine to merge then?


Associating a File Extension is case-sensitive

The extension value when associating a file extension to a code editor, appears to be case-sensitive. If I have a file extension entered of "PRC", SSMS doesn't match this extension with "prc". However, the issue herein is that the SSMS doesn't allow both upper and lower to be entered in the options.
Using SQL Server Management Studio 14.0.17289.0 on Windows 10 Enterprise

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a73ac8f6-4a93-40e5-3abd-08ca8fd206a2
Version Independent ID: 2a557b9e-8f7e-16e7-492b-a7d285fad5a6
Content: Associate File Extensions to a Code Editor - SQL Server
Content Source: docs/ssms/scripting/associate-file-extensions-to-a-code-editor.md
Product: sql
Technology: scripting
GitHub Login: @markingmyname
Microsoft Alias: maghan

@njtpremier  Thank you for the feedback, we apologize for the issues.
To get this to the right people, please move this to either:

SQL Server User Voice
SQL Server technical forums

The product team can then respond and provide both recommendations and updates on the issue.
Again we apologize for the inconvenience.


Automated cherry pick of #277: fix: scheduler schedtag filters execute when candidates

Cherry pick of #277 on release/2.8.0.
#277: fix: scheduler schedtag filters execute when candidates

/cc @swordqiu

/cc @wanyaoqi

/approve
/lgtm


no connection

Error: grpc-status: Unknown, grpc-message: "grpc-status header missing, mapped from HTTP status code 522"
Please help me
Stanislas Gard

was this issue solved for you? I am having same issue and do not know how to access my wallet either.

It's solved. I don't know how but I managed to log in this morning
On Fri, Feb 17, 2023 at 10:00 AM pinigol20 @.***> wrote:

was this issue solved for you? I am having same issue and do not know how
to access my wallet either.
—
Reply to this email directly, view it on GitHub
https://github.com/PirateNetwork/PirateWallet-Lite/issues/105#issuecomment-1434335990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A552ZP2CFXRDEC55J4FYIFDWX4427ANCNFSM6AAAAAAU52VJUU
.
You are receiving this because you authored the thread.Message ID:
@.***>

First of all, your funds are SAFU.
The liteserver is/was down, but Pirate Chhain is currently working on setting up new liteservers. A little patience.
Otherwise, you can access your funds with your key at any time using the Full Node Wallet.

the server was down


librealsense2: 2.33.1-2 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository librealsense2 to 2.33.1-2:

upstream repository: https://github.com/IntelRealSense/librealsense.git
release repository: https://github.com/IntelRealSense/librealsense2-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.9.3
previous version for package: 2.31.0-1

commit aa5b35b updates version in the melodic branch.

I appreciate the remark and will keep that in mind.
Thanks.


This sample project why not have java version？

 That's a small investment for big rewards over Java.

@artshell What you think may be different from the reality.
Also, rust does not work in the JVM, while Kotlin does wonderfully.
Open your mind, try Kotlin, you'll see it is very well designed, and is a much better fit for Android than plain Java 6.
On my side, after ~3 years of Java, I tried Kotlin on a new test project. 10 days later, I wrote production code with it. It was about 2 years ago, and I'd never go back.
Kotlin is arguably easy to learn for Java developers, you can get started in less than a week.

@LouisCAD thanks


[improve][client] Add isInterrupted func on TableView

Motivation

If the tableview is interrupted, soon it will have outdated data as it stops reading more messages. In this case, callers need to know if the tableview is interrupted or not.
Modifications

Added booelan isInterrupted func on TableView.
Verifying this change

[x] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added a unit test.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[x] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: skipped as this is a simple change.

I understand the idea of this patch. but from a api user's view. it is confusing that what is an interrupted, and how should the api user react to the interrupted. I think should choose how to expose the internal exception on TableView to the api user. or we handle the exception inside the client with some retry method. : - )

retry forever upon failures.
throw RuntimeException from the data accessor apis, if already interrupted.(get, entrySet, keySet)
expose table view state(e.g isInterrupted)

It appears that we have the above options.
If tableview is supposed to guarantee the liveness, I think we can go to the option 1 instead.

For the option 3, by this pr, callers could create new tableviews, by constantly monitoring if the table view is interrupted or not.

To expand this discussion a little further, I think the current tableview works under best-effort delivery and needs some improvement in the following areas for mission-critical data replication in production.

guarantee liveness(better error handling. e.g infinite retry)
handle slowness (how to handle slow consumer, e.g self-kill if too slow. If the consumer barely receives messages due to bugs, network, and etc.)
expose operational metrics(table view state(retrying, active), consume latency, highest messageId(highest logical sequence number))

Currently, it is hard or impossible for callers to check them outside of tableview. And this pr is trying to expose the worst-case tableview state,  where tableview is interrupted and stopped to consume messages. We could change the func name to isAlive, isConnected, isClosed, isStopped, or other. I found isInterrupted is a good choice here, as it tells if tableview is "interrupted" by some unknown reason.

I updated the code to retry upon failure. @lifepuzzlefun

@lifepuzzlefun I updated the code to "retry-forever" upon readTailMessages failure. I assume the current "fail-stop" is a bug.

@lifepuzzlefun I updated the code to "retry-forever" upon readTailMessages failure. I assume the current "fail-stop" is not expected.
Another thing to note is that since the reader acks messages immediately, this "retry" will not retry the handling logic with the same message. (It will move on and retry the next message)

Codecov Report

Merging #20044 (85cb28e) into master (3b118b6) will increase coverage by 0.05%.
The diff coverage is 44.85%.

@@             Coverage Diff              @@
##             master   #20044      +/-   ##
============================================
+ Coverage     72.86%   72.91%   +0.05%
- Complexity    31628    31676      +48
============================================
  Files          1861     1858       -3
  Lines        137500   137518      +18
  Branches      15141    15124      -17
============================================
+ Hits         100187   100270      +83
+ Misses        29351    29268      -83
- Partials       7962     7980      +18

Flag
Coverage Δ

inttests
24.19% <0.93%> (-0.21%)
:arrow_down:

systests
24.87% <19.62%> (-0.15%)
:arrow_down:

unittests
72.21% <35.98%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...a/org/apache/pulsar/broker/admin/v2/Functions.java
0.00% <0.00%> (ø)

...java/org/apache/pulsar/broker/admin/v2/Worker.java
11.76% <0.00%> (ø)

...org/apache/pulsar/broker/admin/v2/WorkerStats.java
40.00% <0.00%> (ø)

...ons/worker/rest/api/v2/FunctionsApiV2Resource.java
0.00% <0.00%> (ø)

...s/worker/rest/api/v2/WorkerStatsApiV2Resource.java
0.00% <0.00%> (ø)

...ulsar/functions/worker/rest/api/FunctionsImpl.java
56.55% <16.66%> (-0.74%)
:arrow_down:

...org/apache/pulsar/broker/admin/impl/SinksBase.java
35.29% <35.71%> (ø)

...g/apache/pulsar/broker/admin/impl/SourcesBase.java
35.29% <35.71%> (-1.85%)
:arrow_down:

...ons/worker/rest/api/v3/FunctionsApiV3Resource.java
43.39% <37.50%> (ø)

...e/pulsar/functions/worker/rest/api/WorkerImpl.java
14.90% <38.46%> (+9.38%)
:arrow_up:

... and 16 more

... and 70 files with indirect coverage changes


Create csu.txt

add Central South University

@YinAoXiong Please rename "lib/ domains/ cn/ edu/csu.txt" to lib/domains/cn/edu/csu.txt (extra spaces are not permitted in the filenames). Thank you!

@YinAoXiong I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and rename the file in the request, or make a new request with correct file name. Thank you for the understanding!

thank you，I will rename this file


BUG AddElementPopoverComponent button is submit.

By omitting the button type, this is automatically a submit button. This means pressing the enter key while in an input field triggers this button instead of a true form submit button, and also sends unnecessary form submit events when the form isn't actually being submitted.

Unfortunately this pull-request changes the behavior in a bad way, at least in Firefox where I tested it.
Tabbing on to a hover bar then pressing enter will create a new element popover populated with the available block types.  This is the same behavior as clicking on the hover bar with a mouse.
You can then press enter again and it will dismiss the popover without adding a new element.
However with this pull-request, the behavior changes so that when you press enter the second time to dismiss the popover, instead it will cause the 'Content' tab in the top right tab set to open, which is very undesirable.
Sorry, I'll need to close this one.

Why close the PR and not let the author deal with the provided testing feedback?

Because this has been closed, I've raised #890 for someone else to take a look at fixing.

Why close the PR and not let the author deal with the provided testing feedback?

That's a fair point.
My feeling is that there would significant amount of underlying rework outside of just altering the hover bar component to get this to work.  With the approach taken in this pull request, when pressing enter while focused on the hover bar component was causing a completely different UX component to open.  It seems like a different approach is required.


game implementation

game implementation. I can't describe it  briefly, just try it out and tell me what you think

this is for issue #1

ok. this is a good start


FilePickerResultEvent's path is None when using web browser view...

Description
FilePickerResultEvent's path is None when using WEB_BROWSER view. This also happens in flet publish main.py and in flet build web commands.
Describe the results you received:
Received results: FilePickerResultEvent path is None.
Describe the results you expected:
Expected: FilePickerResultEvent path should be a path to the selected file...
Flet version (pip show flet):
Name: flet
Version: 0.18.0
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: C:\Users\Altaaf\PycharmProjects\Insta Following not followers\venv\Lib\site-packages
Requires: cookiecutter, flet-runtime, packaging, qrcode, watchdog, websocket-client, websockets
Required-by:

Operating system:
OS: Windows 10 22H2
Additional environment details:
Using web view of the app and flet build web and flet publish main.py.

I hosting my app with Cloud run and not upload the file to server
`import json
import os
import shutil
import flet_fastapi
from typing import Dict
import flet
from flet import (
Column,
ElevatedButton,
FilePicker,
FilePickerResultEvent,
FilePickerUploadEvent,
FilePickerUploadFile,
Page,
ProgressRing,
Ref,
Row,
Text,
icons,
)
mnt_dir = os.environ.get("MNT_DIR", "/mnt/nfs/filestore")
async def main(page: Page):
prog_bars: Dict[str, ProgressRing] = {}
files = RefColumn
upload_button = RefElevatedButton
config_data = {
    "max_add_count": 'max_add_count',
    "add_index": 'add_index',
    "adding_status": 'adding_status',
    "scrape_group": 'scrape_group',
    "add_group": 'add_group'
}

with open(f"{mnt_dir}/config.json", "w") as jsonfile:
    json.dump(config_data, jsonfile, indent=4)
    jsonfile.close()

async def file_picker_result(e: FilePickerResultEvent):
    upload_button.current.disabled = True if e.files is None else False
    prog_bars.clear()
    files.current.controls.clear()
    if e.files is not None:
        for f in e.files:
            prog = ProgressRing(value=0, bgcolor="#eeeeee", width=20, height=20)
            prog_bars[f.name] = prog
            files.current.controls.append(Row([prog, Text(f.name)]))
    await page.update_async()

async def on_upload_progress(e: FilePickerUploadEvent):
    prog_bars[e.file_name].value = e.progress
    await prog_bars[e.file_name].update_async()

file_picker = FilePicker(on_result=file_picker_result, on_upload=on_upload_progress)

async def pick_files(e):
    await file_picker.pick_files_async(allow_multiple=True)

async def upload_files(e):
    uf = []
    if file_picker.result is not None and file_picker.result.files is not None:
        for f in file_picker.result.files:
            uf.append(
                FilePickerUploadFile(
                    f.name,
                    upload_url=await page.get_upload_url_async(f.name, 600),
                )
            )
        await file_picker.upload_async(uf)

# hide dialog in a overlay
page.overlay.append(file_picker)

await page.add_async(
    ElevatedButton(
        "Select files...",
        icon=icons.FOLDER_OPEN,
        on_click=pick_files,
    ),
    Column(ref=files),
    ElevatedButton(
        "Upload",
        ref=upload_button,
        icon=icons.UPLOAD,
        on_click=upload_files,
        disabled=True,
    ),
)

app = flet_fastapi.app(main, upload_dir=f"uploads")
flet.app(target=main, upload_dir="uploads", view=flet.WEB_BROWSER)`
Error 👍
2024-01-12 13:52:58.080 ICT
Exception: Specify secret_key parameter or set FLET_SECRET_KEY environment variable to enable uploads.
Open in Logs Explorer
{
insertId: "65a0e1ca00013a5be2a672be"
labels: {1}
logName: "projects/khmer-autotools/logs/run.googleapis.com%2Fstderr"
receiveTimestamp: "2024-01-12T06:52:58.329130140Z"
resource: {2}
textPayload: "Exception: Specify secret_key parameter or set FLET_SECRET_KEY environment variable to enable uploads."
timestamp: "2024-01-12T06:52:58.080475Z"
}

@AngRotanak I think your issue is not related to my issue. I cannot help on your issue. @FeodorFitsner may better guide you...

@ndonkoHenri kindly review this issue please...

@FeodorFitsner Kindly review this issue please

Web browsers have a security feature that prevents them from directly accessing files on your computer. This is why the file path of the file selected by the FilePicker widget in Flet returns None when you select a file in a web application.
To fix this in a web application, you can use the FilePicker's upload property to first upload the file to an accessible location. Then, you can retrieve the file from that location and use it as required.
Note: FilePicker will be able to return the file path if Flet is run as a desktop app or mobile app.

Okay @MaxXilon


Refreshing the vscode window will result in a new session being created.

If the window is reloaded (refresh page in browser OR command "Developer: Reload Window") the session will be recreated instead of reused.
I would expect the session that was active before be used again.

@JosephDHenry I believe this has been resolved, right? Or are you talking about compute session?

I believe @JosephDHenry meant compute session. It's addressed in #175 but not publicly documented.


Use Flask.before_request instead of Flask.before_first_request to work around the re-entry deadlock introduced in Flask 0.11

Fixes #182.
Flask changed its behavior in 0.11 by making before_first_request deadlock if the handler causes another request before finishing. The _before_request hook is still re-entrant, so this can be fixed without changing much code.
Note that Flask's change in behavior addresses some real problems. So a larger, more proper fix later on could be to change Grip._retrieve_styles (or more specifically, Grip._get_styles) to access the cached files directly instead of using a request to do so.

Note: The test failure is coming from pypy3 (which currently implements the now-outdated Python 3.2 version). Ignoring this since later versions of Python 3 are more stable, and the next version of Flask works around this issue. See this Flask issue for details.


Depend more on Python serialization

Python can serialize string,booleans and integers natively ...
For lists , I replace ' to " in order for SQLite to detect them as valid json

Looks great thanks for this! @jimman2003


[BUG/Question] auth_time is parsed as a string, should be int

Describe the bug
We are using Azure B2C with tokens including the auth_time field.  Validation of such tokens fails with
Unable to process jwt token. Uncaught error: 1 validation error for User
auth_time
  Input should be a valid string [type=string_type, input_value=1698160644, input_type=int]

The expected input type is incorrect, and should be changed to an int here. From the Open Id specs (https://openid.net/specs/openid-connect-core-1_0.html):
auth_time
Time when the End-User authentication occurred. Its value is a JSON number representing the number of seconds
from 1970-01-01T0:0:0Z as measured in UTC until the date/time.

To Reproduce
Try to validate a token with the auth_time field present
Stack trace
auth_time
  Input should be a valid string [type=string_type, input_value=1698160644, input_type=int]
    For further information visit https://errors.pydantic.dev/2.4/v/string_type
Traceback (most recent call last):
  File "<snip>/lib/python3.10/site-packages/fastapi_azure_auth/auth.py", line 208, in __call__
    user: User = User(
  File "<snip>/lib/python3.10/site-packages/pydantic/main.py", line 164, in __init__
    __pydantic_self__.__pydantic_validator__.validate_python(data, self_instance=__pydantic_self__)
pydantic_core._pydantic_core.ValidationError: 1 validation error for User
auth_time
  Input should be a valid string [type=string_type, input_value=1698160644, input_type=int]
    For further information visit https://errors.pydantic.dev/2.4/v/string_type

Your configuration
fastapi-azure-auth 4.2.1

Hi, thanks for the report!
PR welcome 😊

PR sent 😄


Weird UX for shadowing errors

Reported by @lasarojc in slack.
It is weird to have a "Failed to resolve" error, and then when one tries to define it, they get a conflict error. Like in this example:
Quint REPL v0.0.3
Type ".exit" to exit, or ".help" for more information
>>> val a = val b = 1 { b }

>>> b
syntax error: error: Failed to resolve name b in definition for q::input, in module __repl__
b
^

>>> val b = 1
syntax error: error: Conflicting definitions found for name b in module __repl__
val a = val b = 1 { b }
        ^^^^^^^^^
error: Conflicting definitions found for name b in module __repl__
val b = 1
^^^^^^^^^

Perhaps we should report a specific shadowing error instead of a general conflict error.

Closing in favor of https://github.com/informalsystems/quint/issues/1187, which is the same but more up-to-date


List.contains (and Seq.contains) is missing from Fable.Core

Description
As title. It confused me because the error message from Babel is opaque.
Repro steps
compile
#r "node_modules/fable-core/Fable.Core.dll"
open Fable.Core
let okChar s = if List.contains s ['a';'b'] then "yes" else "no"

with fable testFable.fsx.
Expected behavior
compiles successfully
Actual behavior
ERROR: Object reference not set to an instance of an object. (C:\fable\tests\testfable.fsx)

Known workarounds
Use List.exists, Seq.exists, etc
Related information

Fable Version 0.4.6
.NET Runtime
W10

Thanks for the report! This should be fixed with fable.compiler 0.5.0 and fable.core 0.5.0  :+1: Please feel free to reopen the issue if it still doesn't work for you.


[PHPUnit 10] Skip with Magic __get() on AssertIssetToAssertObjectHasPropertyRector

with magic __get() property doesn't need to exists to be called.
see https://3v4l.org/3Pckj

All checks have passed 🎉 @TomasVotruba I am merging it ;)


Add CWood-sdf/pineapple

Repo URL:
https://github.com/...
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[ ] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[ ] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR! The changes you've made don't adhere to the checklist, I've deselected the item(s) that need to be fixed.

I'm confused how the PR breaks rule 4. The description does not mention that it's a plugin.

Collects every colorscheme on the internet and allows you to preview them all in Neovim.

Remove the "all in Neovim" part to abide item 4.


Enable Istio metrics and tracing in Rafter

Description
This task is followup to https://github.com/kyma-project/kyma/issues/5085 - what needs to be done:

follow https://istio.io/docs/tasks/telemetry/metrics/querying-metrics/ to enable istio metrics, enable sidecars if needed https://github.com/kyma-project/kyma/blob/master/resources/assetstore/charts/asset-metadata-service/templates/deployment.yaml#L15

Copy pasted stretch, which is now in scope too:

have tracing enabled so I can see time spent on asset between fetching and uploading to minio, to measure which step is a bottleneck in performance. Make sure sampling is set to 100 in performance cluster (check if possible)
have sidecars where needed for tracing if needed

Reasons
Have metrics for controllers and services to be able to see how solution behaves and if the load handling matches the defined SLO

Needs investigation, at the moment, if you enable side-car for minio, it is not reachable anymore

I would rather enable tracing, as we already have a metrics exposed by Kubebuilder

We dont want to invest in rafter within Kyma organisation.
The rafter use case is no longer valid for kyma runtime


Add getRecentPerformanceSamples api

Add the much awaited get_recent_performance_samples api.
sorry, couldn't write an integration test.
solves #218
cheers.

did the integration testing. waiting for it to complete.

done.

thanks for your time @kevinheavey. much appreciated.


chore(): update stencil

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (npm run build) was run locally and any changes were pushed
[ ] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Closing in favor of https://github.com/ionic-team/ionic/pull/19734


Fixes for Mach-O writing

See individual commits.
Based on work by @jedisct1 in https://github.com/fastly/lucet/pull/271#issuecomment-528008121.

Coverage increased (+0.7%) to 44.308% when pulling b252e2d82e5cf2b2dac1602ac0014a4aec7e7442 on philipc:write-macho into a4e3669ef7bc22de279d3476db1e7cf000ca09c9 on gimli-rs:master.

👍

👍


The specification of the call syntax of the native PowerShell command line prompt is not consistent.

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
This issue is technically  related to #15888, #15889, and #15892.
The specifications and definitions are:

PowerShell-7.1 - B. Grammar - see escaped-character
about_Quoting_Rules - PowerShell-7.1
Everyone quotes command line arguments the wrong way

The pure evaluation from the PowerShell prompt behaves as stated in about_Quoting_Rules and uses the syntax of the domain PowerShell-7.1 - B. Grammar

The call of a PowerShell script behaves the same way.

The call of an executable such as another PowerShell instance leaves the PowerShell syntax domain and passes the DOS/cmd.exe syntax domain before entering the PowerShell syntax domain again.
PS> pwsh.exe        powershell-script.ps1  <command-line-parameters>
PS> powershell.exe  powershell-script.ps1  <command-line-parameters>

This is for example the case for:
PS> powershell.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "\""a"
['"a', ]
PS> .\pwsh.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "\""a"
['"a', ]
PS>

where the DOS in-string escape character backslash is successfully applied.
The backslash is not specified in the grammar PowerShell-7.1 - B. Grammar by escaped-character.
Same with Python:
PS> C:\Python371\python.exe -c "import sys;print(sys.argv[1:])" "\""a"
['"a']
PS>

The latter leads me to the assumption, that the initial execution is actually performed in a DOS/cmd.exe like environment, thus escaped and quoted in accordance to the DOS/cmd.exe command line syntax rules. But I called a PowerShell executable at a PowerShell prompt. So I do not expect an intermediary DOS exec call with it's native command line syntax, which has significant differences. Some cases could even not be realized due to the partially contrary/non-compatible specifications.

This makes it difficult to scan/parse a raw call string statically. Because in each case the actuall call chain has to be determined.
The command line call syntax should not change during the call process. At least it should be protected and/or transformed appropriately and passed transparently to the target executable.
The user should have to apply one command line syntax only - PowerShell.
The number of the evaluations of the input command line should be determined and fixed - at best 1x for each call-level.
Expected behavior
PS> powershell.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "`"a"
['"a', ]
PS> .\pwsh.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "`"a"
['"a', ]
PS> .\pwsh.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "\""a"
['\a']

Actual behavior
PS> powershell.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "`"a"
['a', ]
PS> .\pwsh.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "`"a"
['a', ]
PS> .\pwsh.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "\""a"
['"a']

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

I called a PowerShell executable at a PowerShell prompt. So I do not expect an intermediary DOS exec call with it's native command line syntax, which has significant differences. Some cases could even not be realized due to the partially contrary/non-compatible specifications.

Is this a PowerShell issue or a Windows one? I don't know of any way to invoke a process on WIndows while bypassing the typical command line syntax. 🤷

The main confusion of the input and result are:
PS> .\pwsh.exe -noprofile -executionpolicy bypass -file  X:\print_argv_list.ps1  "\""a"
['"a']

Because the backslash is not defined by the PowerShell syntax specification as escape character, see escaped-character. But the backtick only.
I don't know how the internal call structure is. So I cannot say where the internal issue for the call is.
The only thing I know here is that the backslash is defined by DOS/cmd.exe as an in-quote escape character. Because the caret does not work within double quotes.
C:\Python371>python.exe -c "import sys;print(sys.argv[1:])" "^"a"
['^a']

C:\Python371>python.exe -c "import sys;print(sys.argv[1:])" "\"a"
['"a']

C:\Python371>

Thus I assume that a DOS based evaluation and execution is proceeded.
I tried some calls for example with DOS based escaping, but failed due to the required biased quotes of the PowerShell, thus was not able to pass all my trial strings through to the DOS based call. Therefore I had to add even in the above call an extra double quote.
"\"a" => "\""a"

Therefore I did not managed to pass e.g. the following string  due to the non-balanced double qoute error of the PowerShell:
"^"a"

The alternative:
'^"a'

passed, but did not work as expected.
This is why I assume that a simple update of the specification will eventually not suffice for all scenarios.

Therefore I did not managed to pass e.g. the following string due to the non-balanced double qoute error of the PowerShell

 PS > pwsh -f .\1.ps1 '^"""a'
['^"a']

 PS > gc .\1.ps1
"['$args']"

There are multiple levels you need to take into account that aren't specifically PowerShell related.

PowerShell's parser to create a string

If running in PowerShell itself and you want to create a string you need to abide by the parsing rules
That is single quotes/doubles quotes as per https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_quoting_rules?view=powershell-7.1
This logic is about creating a string object in PowerShell for use elsewhere
This is basically how does PowerShell treat "abc" vs 'abc' vs '"abc"' and so on

PowerShell's logic when calling a native executable

This is the logic that PowerShell uses to convert the arguments that it sees when invoking a native binary
e.g. my.exe $arg1 "arg2" ...
It essentially reads each value as positional arguments and generates a list of strings to then pass to the native API
On Windows there is no native API to invoke an executable with a list of arguments so PowerShell has logic to convert that list to a single string
There are numerous issues around this https://github.com/PowerShell/PowerShell/issues/1995
7.2 is implementing some features that try to make this easier to deal with some some of this logic is on shifting ground
In a general sense on Windows, PowerShell will enclose an argument in double quotes but it does not escape the inner double quotes if present
my.exe foo "bar hello" '{"foo": "bar"}' becomes the following command line value my.exe foo "bar hello" "{"foo": "bar"}"

The platforms logic when setting argv of the new process

Linux has a native API to start a process with a list of arguments so this is quite simple
Windows on the other hand has https://docs.microsoft.com/en-us/archive/blogs/twistylittlepassagesallalike/everyone-quotes-command-line-arguments-the-wrong-way
E.g. Windows treats " as a way to escape whitespace chars and \" as a way to have a literal double quote

The new process' logic when reading argv

A process could use the argv passed into it or it could have it's own rules and just reads the command line string directly
There's nothing much PowerShell can do about this as the behaviour is entirely up to the binary being called

Using my example above say you were to do the following in PowerShell (on Windows at least)
$nativeArgs = @('argument1', "argument 2")
$bar = "value 123"

my.exe $nativeArgs foo "bar $bar" '{"foo": "$bar"}'

What happens is the following:

PowerShell parses the line $nativeArgs ... and creates an array of strings based on the standard PowerShell quoting rules
PowerShell parses the line my.exe ... and sees it is calling a native binary and it has positional arguments
These positional arguments are read just like positional arguments to a cmdlet and are flattened down to 2 array

$nativeArgs already contains an array of strings so no extra parsing there - becomes the args arguments1, argument 2
foo is a bare positional argument and is treated as a string - becomes the arg foo
"bar $bar" is a double quoted value so is treated as a string and embedded vars are "templated" in - becomes the argument bar value 123
'{"foo": "$bar"}' is a string value inside single quotes so no variable templating applies - becomes the argument {"foo": "$bar"}

PowerShell takes the list of arguments and wraps them in double quotes if they contain whitespace (space/newline/etc)

argument1 has no space so is kept as argument1
argument 2 has a space so it's changed to "argument 2"
foo has no space so is kept as foo
bar value 123 has a space so it's changed to "bar value 123"
{"foo": "$bar"} has a space so it's changed to "{"foo": "$bar"}"

The list of arguments are added together with spaces and invoked on the C API

The command becomes "my.exe" argument1 "argument 2" foo "bar value 123" "{"foo": "$bar"}"

Now the native binary starts and goes to read the command line

It either uses the standard Windows rules as defined in https://docs.microsoft.com/en-us/archive/blogs/twistylittlepassagesallalike/everyone-quotes-command-line-arguments-the-wrong-way
Or it ignores all that, reads the full command line as a string and parses it in it's own way

For the first everything works fine until it gets to "{"foo": "$bar"}"

The argument here ultimately becomes {foo: $bar} which is obviously not correct
To fix this in PowerShell you would have to escape the inner double quotes manually and do my.exe $nativeArgs foo "bar $bar" '{\"foo\": \"$bar\"}'
Escaping for this uses \" as the escaping happens in this layer and not PowerShell
This is the type of things that are targeted towards fixing in 7.2
The key thing to note here is the escaping done here is not escaping for PowerShell but rather escaping for this layer
Essentially the escaping logic for PowerShell doesn't apply

For the 2nd there's no golden rule - it's entirely up to the underlying application

Ultimately there is no one size fits all and it's made complex by the many different layers that are involved

@237dmitry
I tried to pass the string literal:
^"a

to the native layer with the expected literal result - from the native layer:
"a

Which may have a different call context than the call of a native PowerShell script - see also @jborean93.
Anyhow, this was just a simple trial to understand the instances of the call chain.

@jborean93
Thanks for the comprehensive description. This is exactly the challange.
My focus on the syntax specification in external code like Python is matched in particular by:

The new process' logic when reading argv
A process could use the argv passed into it or it could have it's own rules and just reads the command line string directly

This is what I am scanning/lexing/tokenizing online and offline - argv and/or any complete or partial command line string. Therefore I require in particular the complete normative information about quoting and escaping.
Spoken in terms of this issue - the missing parts of the syntax specification:

The resulting syntax of native calls requires PowerShell-7.1 - B. Grammar plus the syntax specification of the native call environment. The latter seems basically not available.

The syntax of the native layer should be at least referenced by the PowerShell specification. See
PowerShell-7.1 - C. References

@vexx32
The issues are related all to the command line processing and the call of external subprocesses, in particular Python based.
But target actually different issues:

#15888:
split into argv - I guess within calling PowerShell
#15889:
consistency of single and double quotes - where this does not matter - I guess within calling PowerShell
#15892:
escape behaviour - I guess within calling PowerShell for PowerShell interpreter and subprocess caller
#15893:
finally the requirement of the complete normative syntax specification for the native PowerShell interpreter as well as subprocess environments with additional parsers as these require their own quoting/escaping embedded into the same call, but are different from the syntax of the PowerShell

The tasks themself are a bit confusing, therefore I separated them in order to clearly distinguish and define the concrete issues case by case.

This issue has been treated pretty extensively in https://github.com/PowerShell/PowerShell/issues/1995.
There's also discussion in https://github.com/PowerShell/PowerShell/issues/13068.
Essentially, from https://github.com/PowerShell/PowerShell/issues/1995#issuecomment-251192254, the Windows process creation API requires the command line as a single string rather than an array, and then parses that with CommandLineToArgvW. This all means that PowerShell is forced to either make a breaking change in how it parses the command line or propagate bad transformations through the .NET and Windows APIs.
Given the extensive discussion of this in pre-existing issues, I'll mark this and the other issues as duplicates of #1995.