Worker node throws exception trying to use protobuf

From what I can tell, version 3.21.9 of protobuf should be acceptable for Gluten. In the jars folder, I have "protobuf-java-3.21.9.jar", and in /lib, I have this:
libprotobuf.so.32.0.4
libprotobuf.so.32 -> libprotobuf.so.32.0.4
libprotobuf.so -> libprotobuf.so.32.0.4
But when I look at the log for the worker node, I see this exception thrown:
...
22/10/27 20:00:03 INFO JniLibLoader: Successfully loaded library libarrow.so.1000.0.0
22/10/27 20:00:03 INFO JniLibLoader: Trying to load library libgandiva.so.1000.0.0
22/10/27 20:00:03 INFO JniLibLoader: Library /tmp/spark_columnar_plugin_5688917933388226952/libgandiva.so.1000.0.0 has been loaded using path-loading method
22/10/27 20:00:03 INFO JniLibLoader: Library /tmp/spark_columnar_plugin_5688917933388226952/libgandiva.so.1000.0.0 has been loaded
22/10/27 20:00:03 INFO JniLibLoader: Symbolic link /tmp/spark_columnar_plugin_5688917933388226952/libgandiva.so.1000 created for library /tmp/spark_columnar_plugin_5688917933388226952/libgandiva.so.1000.0.0
22/10/27 20:00:03 INFO JniLibLoader: Successfully loaded library libgandiva.so.1000.0.0
22/10/27 20:00:03 INFO JniLibLoader: Trying to load library libspark_columnar_jni.so
22/10/27 20:00:03 INFO JniLibLoader: Library /tmp/spark_columnar_plugin_5688917933388226952/libspark_columnar_jni.so has been loaded using path-loading method
22/10/27 20:00:03 INFO JniLibLoader: Library /tmp/spark_columnar_plugin_5688917933388226952/libspark_columnar_jni.so has been loaded
22/10/27 20:00:03 INFO JniLibLoader: Successfully loaded library libspark_columnar_jni.so
22/10/27 20:00:04 INFO JniLibLoader: Trying to load library libvelox.so
22/10/27 20:00:04 INFO JniLibLoader: Library /tmp/spark_columnar_plugin_5688917933388226952/libvelox.so has been loaded using path-loading method
22/10/27 20:00:04 INFO JniLibLoader: Library /tmp/spark_columnar_plugin_5688917933388226952/libvelox.so has been loaded
22/10/27 20:00:04 INFO JniLibLoader: Successfully loaded library libvelox.so
22/10/27 20:00:04 INFO JniResourceHelper: Trying to extract headers to work directory /tmp/spark_columnar_plugin_5688917933388226952
22/10/27 20:00:04 INFO JniResourceHelper: Successfully extracted headers to work directory /tmp/spark_columnar_plugin_5688917933388226952
22/10/27 20:00:04 ERROR Inbox: An error happened while processing message in the inbox for Executor
java.lang.NoSuchMethodError: com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom([Ljava/lang/String;[Lcom/google/protobuf/Descriptors$FileDescriptor;)Lcom/google/protobuf/Descriptors$FileDescriptor;
        at com.google.protobuf.AnyProto.<clinit>(AnyProto.java:39)
        at io.substrait.proto.Algebra.<clinit>(Algebra.java:915)
...

Evidently there was a jars/protobuf-java-2.5.0.jar that came with Spark. I had to delete that, and the missing exception went away. However, I have a new problem:
E1027 20:16:39.768878 97886 Exceptions.h:68] Line: ../../velox/common/file/FileSystems.cpp:60, Function:getFileSystem, Expression:  No registered file system matched with filename 's3a://theosib-v3-tpcds-hive/warehouse/theosib_tpcds_3000_hive/data/date_dim/part-00000-341e6443-b5cb-4456-91e4-eef70d0a2aaf-c000.snappy.parquet', Source: RUNTIME, ErrorCode: INVALID_STATE
22/10/27 20:16:39 ERROR Executor: Exception in task 0.1 in stage 7.0 (TID 2301)
java.lang.RuntimeException: Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: No registered file system matched with filename 's3a://theosib-v3-tpcds-hive/warehouse/theosib_tpcds_3000_hive/data/date_dim/part-00000-341e6443-b5cb-4456-91e4-eef70d0a2aaf-c000.snappy.parquet'
Retriable: False
Function: getFileSystem
File: ../../velox/common/file/FileSystems.cpp
Line: 60
Stack trace:
# 0
[cut]
# 16

        at io.glutenproject.vectorized.ArrowOutIterator.nativeHasNext(Native Method)
        at io.glutenproject.vectorized.ArrowOutIterator.hasNextInternal(ArrowOutIterator.java:45)
        at io.glutenproject.vectorized.GeneralOutIterator.hasNext(GeneralOutIterator.java:48)

Is Velox actually trying to access s3 directly? Why is it not falling back to Spark's Java code to do the I/O?

We must offload whole table scan operator to Velox where Velox accesses S3 directly or fallback table scan operator to vanilla Spark. We can't offload the I/O only to Spark.
@zhouyuan We need to add a check that if the data storage is not supported then fallback table scan. We should only offload localfs and hdfs now.

Is there anything I can do to help? I don't really know the codebase well enough to just jump in there and work on it, but if you have any hints....

Thank you, @theosib-amazon .
@zhouyuan @rui-mo Can you comment where to add the check?

Thank you, @theosib-amazon .
@zhouyuan @rui-mo Can you comment where to add the check?

Hi Binwei, I think the data storage can be got through file path, but at below place, the whole stage transformer is already created.
WholeStageTransformerExec
VeloxIteratorApi
Is there any other way to know the data storage in advance?

@zhouyuan do you know?

@theosib-amazon this maybe a corner case we didn't covered yet. First, not all Spark job are offloaded - gluten generally only touch the physical plans due to ColumnarAPI framework limit and later execution part.
val df = spark.read.parquet("s3a://tpch/part-00000-b7eace05-f062-4f83-863f-6df6c7446980-c000.snappy.parquet")
val lineitem=df.createTempView("lineitem")

These two jobs are actually running with vanilla Spark, and in your case Spark is configured to work with S3, so it didn't do the fall back and worked(as it should)
in more details, the data frame will be convert to LogicalRelation first, the s3a IO is implemented in Hadoop S3a filesystem thus is actually "transparent" for Spark
spark.sql("select l_orderkey from lineitem").show

In this step, Spark will try to parse the sql, generate the logical plan, then to physicals plans, then gluten will convert to columnar plans to worker will try to execute those plans.
during the plan replacement Gluten could do the check and decided if it's OK to continue offloading or should fallback to vanilla Spark.
I think the scan param should contain the filesystem schema like s3a:// and we could try to do a check there to decided to do the transform or not
https://github.com/oap-project/gluten/blob/main/jvm/src/main/scala/io/glutenproject/extension/columnar/TransformHintRule.scala#L133-L135

there are many other sources like minio we don't support. we need to fallback to vanilla spark on these data sources.

Initially, I tried running queries where I did this for each TPC-DS table:
val df = sqlContext.read.parquet("s3a://theosib-v3-tpcds-hive/warehouse/theosib_tpcds_3000_hive/data/household_demographics")
df.registerTempTable("household_demographics")

But this would always run out of memory. If I did it for all tables, it would run out of memory right away. If I did it for only the tables I needed, it would run out of memory later.
So I switched to rewriting the queries by prepending a with clause like this, and it worked a lot better:
with ${t} as (select * from parquet.`${s3RootPath}${t}`)

Could this be a corner case you hadn't accounted for?

Is it running on Gluten? @zhouyuan is still working on the S3 PR. Did you use his PR?

Is there anything I can do to help? I don't really know the codebase well enough to just jump in there and work on it, but if you have any hints....

Fallback PR submitted by @zhouyuan
https://github.com/oap-project/gluten/pull/499

I'm also trying to get this to work. Using the linked PR gets things moving a bit, but runs into the crash below.
hs_err_pid150447.log
It looks like the cluster is still doing some work, but reading the query never completes. I'm running "select count(*) from store_returns" which completes fairly quick (seconds) with vanilla spark, but is still doing some work after 20 minutes with gluten + velox + s3.

@akashsha1 Let's see if you will meet the same issue

this is fixed by https://github.com/oap-project/gluten/pull/491, right? I think it can be closed


settings: Remove autoscroll forever setting.

@YJDave Thanks for working on this!  The overall approach looks good, but it looks like a test is failing due to your changes.


[release-4.13] Prevent CLBO issues by upgrading to k8s 0.26.4

This commit updates all k8s deps to 0.26.4 to prevent CLBO issues.

/retitle Bug 2232555: [release-4.13] Prevent CLBO issues by upgrading to k8s 0.26.4

/bugzilla refresh

/lgtm
/approve


cmake build fails

Hi Qiming,
When downloading libcint via pyscf, line 3 of CMakeLists.txt is
set(qcint_VERSION "1.6")

and line 52 is
  VERSION ${cint_VERSION}

causing an error..

Fixed in version 2.7


Fix missing highlighting for unquoted strings

This has been missing in seti-syntax for a long time, and it's really made it harder to make syntax highlighting for config files look appealing to Seti users... 😞
Here's a before-and-after:

"Unquoted" strings are basically any line (or block) of text that's interpreted as one long string without needing quotation marks. It's drawn from TextMate's conventions for scope-names in language grammars.

... still silence. :cry:
/cc @jessetumbleweed

Hey sorry, for the delay! Don't know how I didn't see this until now!
Will try and cut a new release shortly

Thanks! :tada:


Connect Fail not Authorized

Hi , I found a problem Connect Fail not Authorized I have used the command python checkupdate.py first and it's show me "Found New Update of gateway mqtt new wss://s.popdeng.click:443/data old None
mqtt gateway wss://s.popdeng.click:443/data | topic click id popdeng/clicks"
After that I've  changed the old wss Which is *wss://o.popdeng.click:443/mqtt *
Then i replaced it with wss://s.popdeng.click:443/data
After that when using the command go run main.go it's show me Connect Fail not Authorized
Sorry for my English as it is my second language.🙏🏻

fixed and it will get url automatically no need to change url in file


I can't change the psych engine icon without breaking my build

Describe your problem here.
So I was learning to compile psych properly, it was all going well until my icons had caused this error (it'd be a screenshot but not this time bc my intel drivers won't let me take a screenshot, another problem that I don't have a workaround for)
(the error in question):
Compiling group: haxe
cl.exe -Iinclude -IC:/HaxeToolkit/haxe/lib/discord_rpc/git/linc/ -IC:/HaxeToolkit/haxe/lib/linc_luajit/git//linc/ -nologo /WX- /fp:precise -DHX_WINDOWS -GR -O2(optim-std) -Zi(debug) -FdD:\zmore mod stuff\The Empitre's extra bits\VsCode Testing\FUCk\export\release\windows\obj\obj/msvc1964-nc/vc.pdb(debug) -Od(debug) -O2(release) -Os(optim-size) -FS -Oy- -c -EHs -GS- -IC:/HaxeToolkit/haxe/lib/hxcpp/4,2,1/include -DHXCPP_M64 -DHXCPP_VISIT_ALLOCS(haxe) -DHXCPP_CHECK_POINTER(haxe) -DHXCPP_STACK_LINE(haxe) -DHX_SMART_STRINGS(haxe) -DHXCPP_API_LEVEL=400(haxe) -D_CRT_SECURE_NO_DEPRECATE -D_ALLOW_MSC_VER_MISMATCH -D_ALLOW_ITERATOR_DEBUG_LEVEL_MISMATCH -DHX_WIN_MAIN(main) -wd4996 ... tags=[haxe,static]

src/lime/utils/AssetCache.cpp  [haxe,release]
src/ApplicationMain.cpp
Link: ApplicationMain.exe
Creating library ApplicationMain.lib and object ApplicationMain.exp

Failed to update resources
that failed to update resources line has begun to haunt me now for the past 5-6 hours. I've gone through 3 builds trying to narrow it down. and narrow it down I did to the conclusion that; trying to change the icons to what I wanted to use compared to what was supposed to be used completely breaks the compiling process for some reason. I've actually tried reverting to the normal icons and it would still break entirely or use the haxeflixel icon. I've completely run out of options and at this point I have tunnel vision. someone please help!!
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I've edited the Project.xml and Main.hx for the working version, I've also edited the MainMenuState.hx in order to remove the achievements menu in favor of a gallery menu in a previous build (tba once I figure everything else out)

Apologies everyone, I was being dumb lmao


[Fade-right]Think to hide overflow

Hi, in your demo (and in my project) i had an overflow effect with fade-right
To fix that,I just need to  add
css:
#app {
  overflow-x: hidden;
}

html:

   <vue-page-transition name="fade-in-right">
     <router-view class="auto-size" />
   </vue-page-transition>

Thanks for your work

Hi, in your demo (and in my project) i had an overflow effect with fade-right
To fix that,I just need to add
css:
#app {
  overflow-x: hidden;
}

html:

   <vue-page-transition name="fade-in-right">
     <router-view class="auto-size" />
   </vue-page-transition>

Thanks for your work

I tried this solution but then my position:sticky elements were no longer sticking.


session_regenerate_id(): Session object destruction failed

i have set email and password for login.once i continuously logout above 3 times it returns this error in yii2

Are you able to reproduce it with basic application template?

no am working in advanced template.could you tell me how to clear this error

No since I have no idea on how to reproduce it.

anyway thanks man :)

Step to reproduce :
1 - add sleep(7) in before logout
2- login
3- duplicate tab ( open two tabs )
4- click logout in the first then logout in the second tab
Result :
session_regenerate_id(): Session object destruction failed. ID: files
As shown above
Thanks


Update flyway-core to 8.4.1

Updates org.flywaydb:flyway-core from 8.3.0 to 8.4.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #254.


issue-43 Delete an existing delta and delete delta bucket file before writing to it in a task.

Deletion of existing delta and delete delta bucket files before starting the write is required as Hive's OrcRecordUpdater
doesnot expect it to be present and hence fails. They can pre exist in the case of task retries, so they need to be cleaned up.

@sourabh912 can you review ?


Add VTK transformation script

added script to transform Parcels output to VTK

@erikvansebille @cpierard @SLYpma
This PR is ready for merging. It plain contains the 4000 LOC transform script in exactly the form as demo'ed on Wednesday 20 april.
The intention of this script is to use it, not to understand it, so I strongly suggest not spending excessive time on the review.
I also just needed to push the script here cause, on my own repo, it is in a private repository for strong reasons, hence I needed to blit it here.
Thanks in advance.


DAG.from_dot_digraph

We can make a dot digraph from a DAG which is very useful to view it.
We also have some convenient ways to make a DAG, such as the code_to_dag function.
Yet I still find myself sometimes building a graph using the dot language (or rather a mini-dot language (I use from qo import dgdisp)). This may indicate the utility of building a DAG from a dot string.
I tried to write a function that takes a graphviz.Digraph instance and returns the edges of the graph as pairs of node IDs, so that I could then use this to make my DAG (using a similar approach as code_to_dag). But I failed. It seems like those graphviz objects are for writing, not reading -- at least not reading into some python-ready object.
I then decided to go through networkx, which has a lot of conversion tools.
This code looked promising.
My slightly modified version:
import networkx as nx

G = nx.complete_graph(5)
A = nx.nx_agraph.to_agraph(G)  # convert to a graphviz graph
X1 = nx.nx_agraph.from_agraph(A)  # convert back to networkx (but as Graph)
X2 = nx.Graph(A)  # fancy way to do conversion
G1 = nx.Graph(X1)  # now make it a Graph

A.write("k5.dot")  # write to dot file
X3 = nx.nx_agraph.read_dot("k5.dot")  # read from dotfile

# You can also create .png directly with the AGraph.draw method
A.draw("k5.png", prog="neato")

# This is what I added, to be able to see the graph:
from IPython.display import Image
Image('k5.png')

Note: I had problems running [the code mentioned above]. I'm told I need pygraphviz, but when I try to pip install I get:
(...)

  error: subprocess-exited-with-error

  × Running setup.py install for pygraphviz did not run successfully.
  │ exit code: 1
  ╰─> [11 lines of output]

(...)

The most voted solution of https://stackoverflow.com/questions/69970147/how-do-i-resolve-the-pygraphviz-error-on-mac-os didn't work for me, but the second did:
https://stackoverflow.com/questions/69970147/how-do-i-resolve-the-pygraphviz-error-on-mac-os

python -m pip install \
    --global-option=build_ext \
    --global-option="-I$(brew --prefix graphviz)/include/" \
    --global-option="-L$(brew --prefix graphviz)/lib/" \
    pygraphviz

There is also: pydot
It can parse and dump into the dot language and send to networkxx.


Player shouldn't play when application become active

Currently, player state will appear as playing when player being init and setup. This should not be the case.
Line 617.
suggestion self.playbackState == .paused.
        if self.playbackState != .playing && self.playbackResumesWhenBecameActive {
            self.play()
        }
    }

thanks @kelvinfok


Optional state

Objective
Adjust bevy internals to utilize Res<Option<State<S>>> instead of Res<State<S>>, to allow for adding/removing states at runtime and avoid unexpected panics.
As requested here: https://github.com/bevyengine/bevy/pull/10088#issuecomment-1869185413

Changelog

Changed the use of world.resource/world.resource_mut to world.get_resource/world.get_resource_mut in the run_enter_schedule and apply_state_transition systems and handled the None option.
in_state now returns a  FnMut(Option<Res<State<S>>>) -> bool + Clone, returning false if the resource doesn't exist.
state_exists_and_equals was marked as deprecated, and now just runs and returns in_state, since their bevhaviour is now identical
state_changed now takes an Option<Res<State<S>>> and returns false if it does not exist.

I would like to remove state_exists_and_equals fully, but wanted to ensure that is acceptable before doing so.

Will this make it harder to diagnose when you forgot to call add_state?

It will make it a bit harder to diagnose, yeah. I'd be in favor of a debounced warning personally.

is there a pre-existing way to debounce a warning?

Added a warning to in_state, that runs only the first time

If you have time to use the once macro before this PR gets a second approval, please do so. Otherwise, happy to merge as is.

Done! Thanks :)

Couple nits on comments, looks good otherwise.

@hymm - Thanks for catching those! I applied your suggestions

The PR description does not match. It says Res<Option<State<S>>> instead of Option<Res<State<S>>>, which left me very confused when I read the actual changes.

Sorry about that - fixed


V2.3.0

Process Image Support #38

[ ] Some refactor #41
[ ] Add ContextMenu Option to switch window from other virtual desktop #39

Hey @taooceros, is this PR ready? Sorry I missed it.

I will remove the cswin32 refactor. I don't think that's necessary and we will use LibraryImport for .Net 7

I would've installed via the GitHub action that ran. Let me know if it's working and ready.

@jjw24 please give it another check. The github artifact previously contains an additional layer of the folder thus making it not able to be installed by our plugin manager.

Before we merge, I would like to fix the virtual desktop issue based on knowledge here. https://github.com/MScholtes/VirtualDesktop
Win11 22H2 changes the COM GUID for the IVirtualDesktopInternal so creating some error there.

Still erroring out:
13:48:35.5824+10:00 - ERROR - PluginManager.InitializePluginsAsync - Fail to Init plugin: Window Walker EXCEPTION OCCURS: System.TypeInitializationException: The type initializer for 'Flow.Plugin.WindowWalker.Components.DesktopManager' threw an exception.  ---> System.InvalidCastException: Specified cast is not valid.    at object Flow.Plugin.WindowWalker.Components.COM.IServiceProvider10.QueryService(ref Guid service, ref Guid riid)    at void Flow.Plugin.WindowWalker.Components.DesktopManager.Init() in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopManager.cs:line 21    at static Flow.Plugin.WindowWalker.Components.DesktopManager() in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopManager.cs:line 16    --- End of inner exception stack trace ---    at VDesktop Flow.Plugin.WindowWalker.Components.VirtualDesktopHelper.CreateVDesktopInstance(Guid desktop, IntPtr hWindow) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopHelper.cs:line 532    at VDesktop Flow.Plugin.WindowWalker.Components.VirtualDesktopHelper.GetWindowDesktop(IntPtr hWindow) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopHelper.cs:line 332    at new Flow.Plugin.WindowWalker.Components.Window(IntPtr hwnd) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/Window.cs:line 137    at bool Flow.Plugin.WindowWalker.Components.OpenWindows.WindowEnumerationCallBack(IntPtr hwnd, IntPtr lParam) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/OpenWindows.cs:line 107    at int Flow.Plugin.WindowWalker.Components.NativeMethods.EnumWindows(EnumWindowsProc callPtr, int lPar)    at void Flow.Plugin.WindowWalker.Components.OpenWindows.UpdateOpenWindowsList() in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/OpenWindows.cs:line 72    at void Flow.Plugin.WindowWalker.Main.Init(PluginInitContext context) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Main.cs:line 133    at Task Flow.Launcher.Plugin.IPlugin.Flow.Launcher.Plugin.IAsyncPlugin.InitAsync(PluginInitContext context)+() => { } in /_/Flow.Launcher.Plugin/Interfaces/IPlugin.cs:line 33    at async Task<long> Flow.Launcher.Infrastructure.Stopwatch.DebugAsync(string message, Func<Task> action) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Stopwatch.cs:line 34    at async Task Flow.Launcher.Core.Plugin.PluginManager.InitializePluginsAsync(IPublicAPI api)+(?) => { } in C:/projects/flow-launcher/Flow.Launcher.Core/Plugin/PluginManager.cs:line 125

Still erroring out: 13:48:35.5824+10:00 - ERROR - PluginManager.InitializePluginsAsync - Fail to Init plugin: Window Walker EXCEPTION OCCURS: System.TypeInitializationException: The type initializer for 'Flow.Plugin.WindowWalker.Components.DesktopManager' threw an exception. ---> System.InvalidCastException: Specified cast is not valid. at object Flow.Plugin.WindowWalker.Components.COM.IServiceProvider10.QueryService(ref Guid service, ref Guid riid) at void Flow.Plugin.WindowWalker.Components.DesktopManager.Init() in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopManager.cs:line 21 at static Flow.Plugin.WindowWalker.Components.DesktopManager() in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopManager.cs:line 16 --- End of inner exception stack trace --- at VDesktop Flow.Plugin.WindowWalker.Components.VirtualDesktopHelper.CreateVDesktopInstance(Guid desktop, IntPtr hWindow) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopHelper.cs:line 532 at VDesktop Flow.Plugin.WindowWalker.Components.VirtualDesktopHelper.GetWindowDesktop(IntPtr hWindow) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/VirtualDesktopHelper.cs:line 332 at new Flow.Plugin.WindowWalker.Components.Window(IntPtr hwnd) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/Window.cs:line 137 at bool Flow.Plugin.WindowWalker.Components.OpenWindows.WindowEnumerationCallBack(IntPtr hwnd, IntPtr lParam) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/OpenWindows.cs:line 107 at int Flow.Plugin.WindowWalker.Components.NativeMethods.EnumWindows(EnumWindowsProc callPtr, int lPar) at void Flow.Plugin.WindowWalker.Components.OpenWindows.UpdateOpenWindowsList() in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Components/OpenWindows.cs:line 72 at void Flow.Plugin.WindowWalker.Main.Init(PluginInitContext context) in D:/a/Flow.Plugin.WindowWalker/Flow.Plugin.WindowWalker/Main.cs:line 133 at Task Flow.Launcher.Plugin.IPlugin.Flow.Launcher.Plugin.IAsyncPlugin.InitAsync(PluginInitContext context)+() => { } in /_/Flow.Launcher.Plugin/Interfaces/IPlugin.cs:line 33 at async Task<long> Flow.Launcher.Infrastructure.Stopwatch.DebugAsync(string message, Func<Task> action) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Stopwatch.cs:line 34 at async Task Flow.Launcher.Core.Plugin.PluginManager.InitializePluginsAsync(IPublicAPI api)+(?) => { } in C:/projects/flow-launcher/Flow.Launcher.Core/Plugin/PluginManager.cs:line 125

yeah...that's the issue I am facing. We uses some internal api in the latest change, which creates some compatibility issue....Maybe we should only enable that feature for latest win11?

Do it like how we handle the notification, check is version and branch accordingly?

With Windows 11 22H2 Release 2215 Microsoft did change the API (COM GUIDs) for accessing the functions for virtual desktops again. I provide seven versions of virtualdesktop.cs now: virtualdesktop11.cs is for Windows 11 22H2 up to release 2134, virtualdesktop11-23h2.cs for Windows 11 22H2 release 2215 and newer (including Insider except Canary) versions, virtualdesktop11-21h2.cs for Windows 11 21H2, virtualdesktop11insidercanary.cs for Windows 11 Insider Canary, virtualdesktopserver2022.cs is for Windows Server 2022, virtualdesktop.cs is for Windows 10 1809 to 22H2, virtualdesktopserver2016.cs is for Windows Server 2016. Using Compile.bat all executables will be generated.


JS/Ruby example code in kata editor is outdated

JS example code in kata editor is still this:
Test.expect(websites.length > 0, 'The array is still empty')
Test.expect(websites.length == 1, 'The array contains too many values')
Test.expect(websites[0] == 'codewars', 'The array does not contain the correct value "codewars"')

while the default initial code and sample test code in trainer are up to date. Even kumite default code is up to date:
// TODO: Replace examples and use TDD development by writing your own tests

// These are some CW specific test methods available:
//    Test.expect(boolean, [optional] message)
//    Test.assertEquals(actual, expected, [optional] message)
//    Test.assertSimilar(actual, expected, [optional] message)
//    Test.assertNotEquals(actual, expected, [optional] message)

// NodeJS assert is also automatically required for you.
//    assert(true)
//    assert.strictEqual({a: 1}, {a: 1})
//    assert.deepEqual({a: [{b: 1}]}, {a: [{b: 1}]})

// You can also use Chai (http://chaijs.com/) by requiring it yourself
// var expect = require("chai").expect;
// var assert = require("chai").assert;
// require("chai").should();

describe("Solution", function(){
  it("should test for something", function(){
    Test.assertEquals("actual", "expected", "This is just an example of how you can write your own TDD tests");
  });
});

Apparently Ruby has the same issue too.


cannot build project

Hello, thank you for this project. I am unable to build project and no technical knowledge, do you please know how to fix this?
Running Monterey 12.6 with Xcode 14.0.1 on M1.
Errors / warnings:

Cannot find
'VZMacOSVirtualMachineStartOp
tions' in scope
Argument passed to call that
takes no arguments
Unable to infer type of a closure
parameter 'error' in the current
context

+1 having the same issue


Colamanga search not working

Source information
Colamanga 1.4.16
Source language
Chinese
Steps to reproduce

Open colamanga
Go to search
Search any manhua
No results

Expected behavior
Search a manhua in the search bar and the result shows up and any related search
Actual behavior
No results even when webview search shows results

Mihon/Tachiyomi version
Mihon 0.16.3
Android version
Android 13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

I suspect this line is at fault. It was fed-deta-info before.

same problem


Support case insensitive wildcard matching

Codecov Report

Merging #49 into master will increase coverage by 0.11%.
The diff coverage is 96.87%.

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     75.14%   75.26%   +0.11%
- Complexity      527      538      +11
============================================
  Files            70       70
  Lines          1839     1860      +21
  Branches        135      140       +5
============================================
+ Hits           1382     1400      +18
- Misses          388      389       +1
- Partials         69       71       +2

Impacted Files
Coverage Δ
Complexity Δ

...tic/apm/matcher/WildcardMatcherValueConverter.java
100% <ø> (ø)
4 <0> (?)

...n/java/co/elastic/apm/matcher/WildcardMatcher.java
98.52% <96.87%> (ø)
38 <12> (?)

...a/co/elastic/apm/report/ReportingEventHandler.java
91.66% <0%> (-8.34%)
8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9a50b...7ed190e. Read the comment docs.


merge package template from Kronos-Tools/npm-package-template-minimal

package.json

chore(package): correct github url
chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(engines): update<EMAIL_ADDRESS>from template
chore(package): set template repo
chore(npm): delete config

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #229   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines           9      9
=====================================
  Hits            9      9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0088357...a15fdba. Read the comment docs.


nat-gateways: use non-inline route

[x] Update the changelog
N/A Make sure that modules and files are documented. This can be done inside the module and files.
N/A Make sure that new modules directories contain a basic README.md file.
N/A Make sure that the module is added to tests/main.tf
[x] Make sure that the linting passes on CI.
N/A Make sure that there is an up to date example for your code:
- For new modules this would entail example code for how to use the module or some explanation in the module readme.
- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
[ ] Make sure that there is a manual CI trigger that can test the deployment.

Looks good and passed the test


Kanister docs update to version 0.25.0

These changes went in as https://github.com/kanisterio/kanister/pull/553


Mitigate parametric test blocked

Motivation
The Parametric tests are frequently blocked. Usually Java, but less frequent in other languages.
I explain the problem on the files
Changes

Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present
[ ] To R&P team: locally build and push the image to hub.docker.com

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team
[ ] Once merged, add (or remove) it in system-test-dasboard nightly

Do you know why the kill command freezes ?

I don't know, because it doesn't enter into the catch....
I wonder if I am focusing on something that is not the root cause?


[Bug]: Selecting one-time permission results in denied

Please check the following before submitting a new issue.

[X] I have searched the existing issues.
[X] I have carefully read the documentation and verified I have added the required platform specific configuration.

Please select affected platform(s)

[X] Android
[ ] iOS
[ ] Linux
[ ] macOS
[ ] Web
[ ] Windows

Steps to reproduce
Just call to Geolocator.requestPermission()
Expected results
Expected allowed state. It seems that "one-time" option has to be added to LocationPermission enum
Actual results
LocationPermission.denied
Code sample
Code sample
var permission = await Geolocator.checkPermission();
if (permission == LocationPermission.deniedForever) {
  // denied
}

if (permission == LocationPermission.denied) {
  permission = await Geolocator.requestPermission();
  if (permission != LocationPermission.whileInUse && permission != LocationPermission.always) {
    // got here if one-time was selected
  }
}

// ok, granted

Screenshots or video

Screenshots or video demonstration
[Upload media here]

Version
13.0.1
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.22.3, on Microsoft Windows [Version 10.0.22000.2538], locale ru-RU)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[!] Visual Studio - develop Windows apps (Visual Studio Build Tools 2019 16.11.26)
    X The current Visual Studio installation is incomplete.
      Please use Visual Studio Installer to complete the installation or reinstall Visual Studio.
[√] Android Studio (version 2023.3)
[√] VS Code (version 1.92.2)
[√] Connected device (4 available)
[√] Network resources

! Doctor found issues in 1 category.

me too


🐞 Bug: Previous button present on first page

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
On CircuitVerse website under Recent Circuits section we have two buttons Previous and Next.
When we are at first page the previous button do not function, obviously, but I think it should not be present at the first place.
Steps To Reproduce

Go to CircuitVerse website.
Scroll down to the Recent Circuits section.
On the first page, previous button is present.

Expected Behavior
The Previous button should start to appear from the second page and should not be there on first page.
Screenshots
The problem:

Device Information [optional]
- OS:
- Browser:
- version:

Additional context
No response
Are you working on this issue?
Yes

Hey @vedant-jain03 I would like to work on this issue.

Hii @tanmoysrt can I work on this issue ?

Hi @antriksh-9  don't remove buttons. It's already disable. It may happen the style for disabled button doesn't differentiate from active button. You can update the style of Prev and Next button if disabled.

Hi @antriksh-9 don't remove buttons. It's already disable. It may happen the style for disabled button doesn't differentiate from active button. You can update the style of Prev and Next button if disabled.
Update the issue description for this.

I know it's disable, I opened this issue because usually we don't find prev button on first page since there is no use of keeping it there in the first place.
Okay, I will update the style of button for differentiating.

Hi @antriksh-9 don't remove buttons. It's already disable. It may happen the style for disabled button doesn't differentiate from active button. You can update the style of Prev and Next button if disabled.
Update the issue description for this.

I know it's disable, I opened this issue because usually we don't find prev button on first page since there is no use of keeping it there in the first place. Okay, I will update the style of button for differentiating.

Just update style for now. As the pagination bar needs a revamp, as it's not responsive at all (although there is a PR #4444) and showing large number for end pages is not meaningful.

Hi @antriksh-9 don't remove buttons. It's already disable. It may happen the style for disabled button doesn't differentiate from active button. You can update the style of Prev and Next button if disabled.
Update the issue description for this.

I know it's disable, I opened this issue because usually we don't find prev button on first page since there is no use of keeping it there in the first place. Okay, I will update the style of button for differentiating.

Just update style for now. As the pagination bar needs a revamp, as it's not responsive at all (although there is a PR #4444) and showing large number for last few pages is not meaningful at all.

Okay!

Hey @tanmoysrt I am getting this error when I'm about to commit:
'lint-staged' is not recognized as an internal or external command, operable program or batch file. husky - pre-commit hook exited with code 1 (error)


my-progress_spec.js can fail due to inconsistent project order returned from the service /api/myProgressSummary endpoint

my-progress_spec.js can fail due to inconsistent project order returned from the /api/myProgressSummary endpoint
https://github.com/NationalSecurityAgency/skills-service/actions/runs/653040847

PR: #417


Add and change variants for the Label component

In order to provide more flexibility and cover more use-cases as a developer/designer I need to have more label-variants. We need to have 5 main types ("variants" now in wave) of labels:

Default (current Neutral)
Info (New)
Success (current Positive)
Warning (New)
Danger (current Negative in design and Danger in code)

In addition to our current outlined-style we need to create an additional style-group: Filled. Both Outlined and Filled styles need to have 5 label types each. This story also includes the rename of the variant "info" to "neutral".
Design: https://zpl.io/aMWQ1Mr

@snapsnapturtle Any update on this topic?

Nothing yet, but I have some changes locally. I can probably open a PR with these and then we have to decide how we want to release them as they will cause a breaking change


Feat/bundles

first working version of carti-core, the heart beat of carti. In this release a few features have been cleaned up and rexported and exposed so the cli downstream can grab access to alot of the logic features that  make the cli tick. This is still very much experimental and am putting this up unsquashed as more for posterities sake. I will merge the squashed version soon after.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[AUTOGLUON] Early Stopping in TimeSeriesPredictor?

Clarification on models Using Early Stopping by default in TimeSeriesPredictor
Description
I would like to understand which models in the TimeSeriesPredictor use early stopping by default. Additionally, could you please clarify how early stopping is implemented and configured in these models?
Key Questions

Default Usage:

Which models in TimeSeriesPredictor (e.g., Temporal Fusion Transformer, DeepAR, etc.) have early stopping activated by default?

Default Parameters:

Are there any default configurations for early stopping, such as:
Patience (number of epochs to wait before stopping)?
Minimum delta (the threshold for improvement)?

Customization:

How can I customize early stopping for models in TimeSeriesPredictor?

Thank you for your assistance!

Closing as duplicate of https://github.com/autogluon/autogluon/issues/4757
@DAD-FOX please use AutoGluon’s issue trailer for issues related to AutoGluon specifically, and avoid duplication.


Collision handling

Hi @Jaimi5, I wonder how the collision mechanism is implemented in your work, what will happen if two nodes will start to send the messages? As I see in the examples we only broadcast the message from one node to others but what about taking care of passing it to the rest of the network? It there any option to use the nodes in receiver/transmitter mode?

Hi @KosBar49!  You can see how the collision mechanism for a single message is working at the following link: IEEE. We implemented a Carrier Sense Multiple Access / Collision Avoidance (CSMA/CA). In the next iteration, it will be implemented a reliable connection with resend if a collision occurs.

As I see in the examples we only broadcast the message from one node to others but what about taking care of passing it to the rest of the network?

At this moment, there is no implementation to forward a broadcast message to all the networks. There is an initial concept about it, but it is not fully implemented yet.

It there any option to use the nodes in receiver/transmitter mode?

At this moment, no.
If you have any questions, do not hesitate!


Two additional checks to prevent FTLing stations

About the PR

Added more safeguards to prevent FTLing when it shouldn't happen
Why / Balance

People have been FTLing stations because the station anchor's changes were not accounted for in the FTL code at the moment and this kind of ruins rounds
Technical details

Station anchors allow FTLing because setting the grid to a static physics body causes it to have 0 mass, the mass check is the only thing stopping stations from FTLing normally
Add a check in the FTL code for the grid being static
Add a check in the FTL code for if the shuttleComp is disabled

Media

Spam clicking FTL
https://github.com/user-attachments/assets/9cad51ce-4066-4dd5-8f82-9b6612c67e3e
Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

nae
Changelog

:cl:

fix: You can no longer FTL the station.

tested FTLing with the anchor disabled, works
tested FTLing with the anchor enabled, prevents FTLing

does this break the evac/arrivals shuttle? I've seen people drag the station anchor to the evac shuttle and make it do funky things.

does this break the evac/arrivals shuttle? I've seen people drag the station anchor to the evac shuttle and make it do funky things.

https://discord.com/channels/310555209753690112/675078881425752124/1288331890171973702

does this break the evac/arrivals shuttle? I've seen people drag the station anchor to the evac shuttle and make it do funky things.

these people should be blown up

tbf it was pretty funny

Side note that (unless it's already been fixed) you can drag/build a shuttle console on Evac and undock Evac from the station dock preemptively. Saw it happen on salamander.

confirmed it doesn't break arrivals
confirmed you can't ftl with arrivals to kidnap it

Side note that (unless it's already been fixed) you can drag/build a shuttle console on Evac and undock Evac from the station dock preemptively. Saw it happen on salamander.

I'm not fixing this but I can confirm it's doable

AI law 2 turn the station anchor off

AI law 2 turn the station anchor off

Denied, law 1 prevents me from doing so. The station drifting may cause someone to become stranded and be harmed.


typo: add -> app

The name of the constructor should be app rather than add according to the context

Thank you! Sorry for the slow turnaround!


WindowAggExec output ordering is fixed

Which issue does this PR close?

Closes #4438.
Rationale for this change

We can't rely on the current output_ordering result unless we pass from the BasicEnforcement optimization pass. Hence  output_ordering of the WindowAggExec would give the wrong result during physical plan planner
What changes are included in this PR?
Since WindowAggExec maintains input order and requires specific ordering, output ordering would be required input ordering. I have changed code to reflect that (By this way we can rely on output_ordering information of WindowAggExec even if there is currently no SortExec before it in the physical plan)
Are these changes tested?
N.A
Are there any user-facing changes?
N.A

No, I think this change is not correct!!!  WindowAggExec should always keep the input ordering, and the input ordering does not always equal with the required input ordering. For example, input ordering could be order by ['a', 'b', 'c'], the required input ordering is order by ['a', 'b'],  order by ['a', 'b', 'c'] can satisfy order by ['a', 'b'], in this case, the output ordering of the WindowAggExec itself is still order by ['a', 'b', 'c'].

@mustafasrepo Could you please explain more specifically why you can not rely on the current output_ordering result?
Do you have your own physical optimizer rules?

#4332
@mingmwang Thanks for your feedback. I saw this problem while working on a PR that removes unnecessary SortExec before WindowAggExec to improve efficiency. Consider the query below

SELECT
      c9,
      SUM(c9) OVER(ORDER BY c9) as sum1,
      SUM(c9) OVER(ORDER BY c9, c8) as sum2
      FROM aggregate_test_100

Its physical plan is as follows
+---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| plan_type     | plan                                                                                |
+---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| logical_plan  | Projection: aggregate_test_100.c9, SUM(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 ASC NULLS LAST] AS sum1, SUM(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 ASC NULLS LAST, aggregate_test_100.c8 ASC NULLS LAST] AS sum2     |
|               |   WindowAggr: windowExpr=[[SUM(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 ASC NULLS LAST]]]                                                                                |
|               |     WindowAggr: windowExpr=[[SUM(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 ASC NULLS LAST, aggregate_test_100.c8 ASC NULLS LAST]]]                                                                                |
|               |       TableScan: aggregate_test_100 projection=[c8, c9]                                                                                |
| physical_plan | ProjectionExec: expr=[c9@3 as c9, SUM(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 ASC NULLS LAST]@0 as sum1, SUM(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 ASC NULLS LAST, aggregate_test_100.c8 ASC NULLS LAST]@1 as sum2] |
|               |   WindowAggExec: wdw=[SUM(aggregate_test_100.c9): Ok(Field { name: "SUM(aggregate_test_100.c9)", data_type: UInt64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None })]                                                          |
|               |     SortExec: [c9@2 ASC NULLS LAST]                                                                                |
|               |       WindowAggExec: wdw=[SUM(aggregate_test_100.c9): Ok(Field { name: "SUM(aggregate_test_100.c9)", data_type: UInt64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None })]                                                      |
|               |         SortExec: [c9@1 ASC NULLS LAST,c8@0 ASC NULLS LAST]                                                                                |
|               |           CsvExec: files=[Users/akurmustafa/projects/synnada/arrow-datafusion-synnada/testing/data/csv/aggregate_test_100.csv], has_header=true, limit=None, projection=[c8, c9]                                                                    |
|               |                                                                                |
+---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Second (from the bottom) SortExec can be removed from the physical plan safely. To remove unnecessary SortExec from the physical plan, I compare the required sorting of WindowAggExec with its input_exec.output_ordering() at here. Second WindowAggExec requires input_ordering c9@2 ASC NULLS LAST. Its input WindowAggExec should have output_ordering , c9@1 ASC NULLS LAST,c8@0 ASC NULLS LAST. However, output_ordering of the first WindowAggExec returns None. The reason is that since we did not put SortExec before it yet (It is is done at optimization pass), its input is CsvExec and its ouput_ordering is None.
In summary, unless we pass from BasicEnforcement optimization pass, the output ordering information of WindowAggExec would give output ordering of Executor before SortExec in the final physical plan.

@mustafasrepo Could you please explain more specifically why you can not rely on the current output_ordering result? Do you have your own physical optimizer rules?

@mustafasrepo Could you please explain more specifically why you can not rely on the current output_ordering result? Do you have your own physical optimizer rules?

To replicate my problem if we put the statement println!("input exec output ordering:{:?}", input_exec.output_ordering()); here
For above query, we receive output ordering input exec output ordering:None, for both WindowAggExecs
However, for the second  WindowAggExec we should receive input exec output ordering:Some([PhysicalSortExpr { expr: Column { name: "c9", index: 1 }, options: SortOptions { descending: false, nulls_first: false } }, PhysicalSortExpr { expr: Column { name: "c8", index: 0 }, options: SortOptions { descending: false, nulls_first: false } }]).

@mustafasrepo BasicEnforcement should do the optimization and avoid the unnecessary SortExec for you. I will write a test in DataFusion late today and try to reproduce the issue.

@mustafasrepo BasicEnforcement should do the optimization and avoid the unnecessary SortExec for you. I will write a test in DataFusion late today and try to reproduce the issue.

@mingmwang, even though @mustafasrepo's example shows how the issue can manifest in a certain context, the core issue is that input_exec.output_ordering() can return a result that is inconsistent with self. required_input_ordering(). In his specific case, the former returns None, which is clearly wrong -- the requirement would have been violated had this been the case.
This seems to happen because as of PR #4122, we insert operators likeSortExec after physical planning (i.e. during the BasicEnforcement optimization step). Therefore, calls like input_exec.output_ordering() return such inconsistent/unreliable results during physical planning, since the "real" input_exec is not there yet!
Until we figure out a general fix to this, we can select the "finer" ordering between required_input_ordering() and input.output_ordering() -- this will result in a less wrong result in the meantime.

@mingmwang, even though @mustafasrepo's example shows how the issue can manifest in a certain context, the core issue is that self.input.output_ordering() can return a result that is inconsistent with self. required_input_ordering(). In his specific case, the former returns None, which is clearly wrong -- the requirement would have been violated had this been the case.
This seems to happen because as of PR #4122, we insert operators likeSortExec after physical planning (i.e. during the BasicEnforcement optimization step). Therefore, calls like input_exec.output_ordering() return such inconsistent/unreliable results during physical planning, since the "real" input_exec is not there yet!
Until we figure out a general fix to this, we can select the "finer" ordering between required_input_ordering() and input.output_ordering() -- this will result in a less wrong result in the meantime.

There is a general fix.  The root cause is not because output ordering return None, but when the WindowAggExec try to derive the ordering from input, the column index must be handle properly. The same bug exists within output partition.
I will raise a PR to fix the bug.

No, I think this change is not correct!!! WindowAggExec should always keep the input ordering, and the input ordering does not always equal with the required input ordering. For example, input ordering could be order by ['a', 'b', 'c'], the required input ordering is order by ['a', 'b'], order by ['a', 'b', 'c'] can satisfy order by ['a', 'b'], in this case, the output ordering of the WindowAggExec itself is still order by ['a', 'b', 'c'].

We have updated this PR to address this concern. Thanks for pointing it out @mingmwang .

Let's consider more general use cases of output_ordering(). In DefaultPhysicalPlanner.create_initial_plan(), we should be able to depend on output_ordering() and output_partitioning() regardless of the optimization step.  Let’s think we have AExec and BExec.
AExec

  ⬇

BExec

where
impl ExecutionPlan for AExec {
    fn output_ordering(&self) -> Option<&[PhysicalSortExpr]> {
        self.input.output_ordering()
    }
}

If I call AExec.output_ordering() in DefaultPhysicalPlanner, it will gives BExec’s output order. I can make decisions depending on it in planner phase. To make this plan “runnable”, we should not add new operators to the between AExec and BExec outside of the planner. If AExec requires an input ordering, this should be decided inside the planner and add to the operator chain to make output_ordering() API work. Currently, these API’s are broken since we did not add a SortExec inside the planner.

Great discussion. I think @metesynnada highlighted the core issue nicely. I don't yet understand the general fix @mingmwang has in mind, but if it works, this PR will become unnecessary.
If it doesn't solve the problem @metesynnada explained, we can use this fix until a final, general fix is available.

@metesynnada
The rule BasicEnforcement is part of the DefaultPhysicalPlanner, that's why the rule is an enforcement rule(A common rule in many other DB Engines).

I just submit the fix PR, please help to take a look.
https://github.com/apache/arrow-datafusion/pull/4455

The BasicEnforcement can choose to satisfy given ordering/partitioning requirements in different ways. For example a requirement ordering ['a'] can be satisfied by sort by ['a'], sort by ['a', 'b'], order by ['a', 'b', 'c'], sort by ['a', random] ......
In future, we will add support for Range Partitioning, if the optimizer detects the column a is a skewed column,   it can effectively add  sort by [a + random()] to avoid data skew in the Range Partitioning.

Thanks! Let's conclude the discussion on your PR first, and then we can easily decide whether to go forward with this or not.

The need for this PR was obviated by PR ##4455 thanks to @mingmwang. We will be closing this shortly and focus our efforts on creating a rule that will swap the default WindowAggExec with more-efficient, pipeline-able version when appropriate.


Handle duplicate adviser and contact record for legacy win migration.

Description of change
This update handles cases when there are duplicate adviser and contact records in Data Hub for legacy export wins migration.
Checklist

[x] Has this branch been rebased on top of the current main branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[x] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Codecov Report
Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 96.40%. Comparing base (085a93a) to head (f96f143).

Files
Patch %
Lines

datahub/export_win/legacy_migration.py
79.16%
2 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5416      +/-   ##
==========================================
- Coverage   96.41%   96.40%   -0.01%
==========================================
  Files         940      940
  Lines       22341    22335       -6
  Branches     2003     2008       +5
==========================================
- Hits        21539    21533       -6
+ Misses        655      653       -2
- Partials      147      149       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[deliver][spaceship] migrate AgeRatingDeclaration from AppStoreVersion to AppInfo for App Store Connect API 1.3 update

Motivation and Context
App Store Connect API released version 1.3 today

AgeRatingDelcaration deprecated on AppStoreVersion
AgeRatingDeclaration added as relationship on AppInfo
gamblingAndContests split into

gambling (boolean value)
contests (string value)

Added new seventeenPlus rating (boolean value)

Description

Moved API and helper methods from AppStoreVersion to AppInfo
Added a new deprecation method on AgeRatingDelcaration to map values to new format if possible

Returns the changed Hash
Returns deprecation messages to be printed out
Returns error messages to be raised

@


Always On Top, clickable GUI glyph/icon

Description of the new feature / enhancement
Not everyone is an aspiring keyboard shortcut magician. Or at least I am not. I have the hand-eye coordination of a snail, and would really enjoy having a GUI-implementation for Always On Top.
Some time ago I used tools like DisplayFusion, DeskPins or Chameleon Windows Manager - but each one ended up too unstable or just abandoned.
Just a nice, minimal, simple additional glyph to click next to the familiar 3 top-right title bar buttons would be so nice. I believe they're called System Caption Buttons, if my memory serves me well.
Scenario when this would be used?
Whenever there is a need to put whatever window on top, by someone like me - with the hand-eye coordination of a snail.
Supporting information
Visually, this would capture what I have in mind the most. But with a different glyph, haha.

I was actually coming here to suggest a similar feature and found this one. I like this one even better. Although this might prove tricky with apps that do their own owner-draw title bars/buttons (e.g. Office). Maybe combine this with what I was going to suggest, which is to borrow a feature from a utility called CClose.
I've been using CClose for AOT for a while now. It lets you make a window AOT by long-left-clicking on the titlebar. If you left click on the titlebar and hold it for ... about a half-second or so, then it toggles the AOT flag for the window. (Given PT's general quality though, I'd imagine having the time-duration configurable.)
Personally I would find this a great addition, as when I'm interacting with windows (as opposed to the program content within) I'm usually already on the mouse, so it would be easier than switching over to the keyboard.

This was something we thought about but injecting stuff into applications can be hard.  We don't control any of those applications.

I honestly have always assumed the titlebar of any application was actually "controlled" by the Windows OS.
As if the explorer.exe process manages the application window and the application utilizes it or something.
That thought was solely based on how it appears the Windows OS is in control of what is and what is not shown on the title bar and such.
Interesting how I couldn't have been more wrong.
For now I used the macro features of my Logitech peripherals to do the keyboard acrobatics for me when I press a certain additional mouse butten which works pretty well for me.


Icon request: Wealthsimple

URL of the site or app: https://www.wealthsimple.com/en-ca/
Logo resources for the icon: Facebook profile pic

Vector: https://www.wealthsimple.com/static/ws-wordmark-7a6a6ea384e8586aaeb2597547f86158.svg
Colors: https://wealthsimple-grow.ghost.io/content/images/2015/11/brand_assets-2.png

Here you go:
https://github.com/krisu5/aegis-icons/blob/master/PNG/Wealthsimple.png


Ensure wheel updated when pipenv check invoked

When pipenv check is invoked, it will always fail due to the wheel version installed in our current runner environments (which has a known DoS vuln).
In the one CI task where we invoke pipenv check, ensure that we update the system's ambient wheel beforehand.

pipenv check uses safety to query safety-db. This has wheel <0.38.0 listed as insecure, but a satisfying update has not yet been published to PyPI (0.38.0 was published, but yanked).

Codecov Report

Merging #2593 (16f5745) into main (33e2d5c) will increase coverage by 2.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2593      +/-   ##
==========================================
+ Coverage   29.89%   32.52%   +2.62%
==========================================
  Files         289      162     -127
  Lines       35764    21674   -14090
==========================================
- Hits        10692     7049    -3643
+ Misses      25072    14625   -10447

Impacted Files
Coverage Δ

src/agent/onefuzz/src/env.rs
0.00% <0.00%> (-83.34%)
:arrow_down:

src/agent/onefuzz/src/libfuzzer.rs
12.23% <0.00%> (-57.87%)
:arrow_down:

src/agent/onefuzz/src/memory.rs
0.00% <0.00%> (-25.00%)
:arrow_down:

src/agent/coverage/src/test.rs
85.71% <0.00%> (-14.29%)
:arrow_down:

src/agent/onefuzz/src/monitor.rs
67.12% <0.00%> (-13.70%)
:arrow_down:

src/agent/onefuzz/src/machine_id.rs
51.72% <0.00%> (-5.12%)
:arrow_down:

src/agent/onefuzz/src/expand.rs
62.97% <0.00%> (-3.52%)
:arrow_down:

src/agent/onefuzz/src/sanitizer.rs
72.22% <0.00%> (-0.39%)
:arrow_down:

src/agent/onefuzz-agent/src/worker/tests.rs
99.07% <0.00%> (-0.14%)
:arrow_down:

src/agent/onefuzz/src/asan.rs
0.00% <0.00%> (ø)

... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Before merging, and once a new version of wheel is published, re-enable the check that was disabled in #2594.


chore(master): release 1.4.19

:robot: I have created a release beep boop
1.4.19 (2023-09-04)
Miscellaneous

deps: update actions/checkout action to v4 (7f5beb1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/docker-build-deps/releases/tag/v1.4.19 :sunflower:


x-ms-external resources results in wrong namespace

Steps to reproduce:
1 Generate Compute SDK from https://github.com/Azure/azure-rest-api-specs/blob/master/arm-compute/2015-06-15/swagger/compute.json
Expected:
https://github.com/dmitriy-barkalov/azure-sdk-for-ruby/blob/feature/arm-sdk-pr/lib/azure/arm/ComputeManagement/lib/azure_compute_management/Models/virtual_machine_properties.rb#L82 has MsRestAzure namespace
Actual:
Internal SDK namespace

Done at 38234f9394a2aecbecde286f191bead5bf074400

Totally reworked the feature, don't use namespace anymore - now just included modules where required 04bcd2e0ee437f929d03759b5d0b985a2a1fd92c


SSO login failing when not using implicit flow

When you enable the Single Sign On (SSO) toggle in the Features settings of the plugin, some client javascript is rendered to checkSession and see if a valid SSO session is available at Auth0, to log the user in automatically without prompting for credentials.
The above flow is failing when there's a valid SSO session at Auth0, causing the plugin code to display:

There was a problem with your log in

and logging a "Wrong number of segments" error in the internal plugin logs:

The checkSession callback does not have an idToken in the authResult, which causes the Wrong number of segments error described above.

This is because the call to checkSession uses responseType: 'code' when implicit flow is turned off, and that response type is not supported by checkSession.
  var options = <?php echo json_encode( $lock_options->get_sso_options() ); ?>;

results into:
  var options = {"scope":"openid ","responseType":"code","redirectUri":"http:\/\/dev-nicotest1.pantheonsite.io\/index.php?auth0=1","state":"xxxx","nonce":"nonce"};

responseType: 'code' is not valid in checkSession:
https://github.com/auth0/auth0.js/blob/308d55f9f0a8c6fa2f46cd61cf7be2917a8fa647/src/web-auth/index.js#L389-L391
To reproduce:

Make sure the WP site is working with the Auth0 plugin
Enable the Single Sign On (SSO) toggle in the plugin settings
Disable the Implicit flow toggle.
Log in with the Auth0 plugin into the WP site. This will create a session both in the WP site and in Auth0.
Clear the cookies for the WP site (but leave the ones in Auth0). This will log you out of the WP site.
Go to /wp-login.php into the WP site. The rendered HTML will do a checkSession call (which will find a session in Auth0). You'll get "There was a problem with your log in"

Could we get an update on when this will be fixed?

@codyayers - This specific fix or SSO in general? We've been talking internally and need to come up with a solution that's going to work long-term. We're aware of what needs to be done here, just want to make sure the solution works well now and going forward.
Getting this operating 💯 is our highest priority for the plugin right now.

@joshcanhelp this specific fix. I'm happy to hear this, just would like to know if any ETA could be provided. Thanks!

@codyayers - This particular fix won't make much of a difference as the check this is trying to do is now happening in Lock 11 (which the latest plugin version will upgrade you to).
That said, here is the one-line change if you want to give it a test on your end:
https://github.com/auth0/wp-auth0/compare/issue-363-experiment
If this has a positive effect, happy to include it in the next release (2 weeks max).

Checking in again here ... that compare branch above expanded by 4 lines but I've got it working now, auto-logging in if the WP session ends before the Auth0 one does. It would be great to get someone to test this out against another set of config options but it's a simple fix and I can fast-track this into the next release coming very soon.

@joshcanhelp these changes: https://github.com/auth0/wp-auth0/compare/issue-363-experiment appear to resolve the problem completely for us! 👍

Shoot.. I take that back.. worked the first time, but now it doesn't seem to be... Will continue testing.

@codyayers - Error messages seen, logged in wp-admin, and logged in the dashboard are helpful, along with steps to reproduce, of course. Might be best to start with a clean browser session, i.e. cleared cookies, but not incognito.

@codyayers - Likely to be a related issue. I had it on my list to walk through that once this process was confirmed.
Stay tuned ... and thank you for testing!

@codyayers - Similar fix for SLO, same compare link as before, single-line fix:
https://github.com/auth0/wp-auth0/compare/issue-363-experiment
I need to setup a network of sites to test this properly so not ready for release but the changes in that compare shouldn't hurt anything or introduce any new issues.

Tested on my end and confirmed it works as expected. If anyone else has any feedback 👍 👎 on this, that would be great. Otherwise, I'm going to put this into a PR and get it ready for release next week in 3.5.2.
Thanks everyone!


[1.3.1] Crash at load

Log - https://pastebin.com/1wT8ijXm
Any idea?
Thanks!

You ran out of block ids. Either remove some mods or get a mod like not enough ids to increase the limit.

1.12.2 is interesting. Thank you!


Transaction only on same connection

If archiving to a different host we can not use transactions.
cc: @vangberg

This isn't needed, actually.
Normally all Rails models share a single connection (e.g. Model1.connection == Model2.connection) and that is what enforces the transaction. In thise case, Model.connection != Model::Archive.connection, and running e.g.:
Model.transaction do
  Model::Archive.last.delete
end

…will not fail, but whatever is called via the Model::Archive connection will not be in the transaction.

Cool 😄


Migrate the etcd implementations of the operations to here

kwok is a simulated k8s cluster.
which implements a subcommand to bypass apiserver and directly edit the etcd data of the simulated cluster.

kwokctl hack get
kwokctl hack del
kwokctl hack put

I want to apply the same capabilities to an existing test cluster rather than a simulation cluster.
allows easier modification of test cluster data for simulation to verify control plane stability after upgrade/downgrade or chaos.
I want to add a subcommand that can directly edit the data from etcd and use it like kubectl.

/assign @wzshiming


perf attrib plot updates

don't plot specific_returns in style/sector breakout plots
add common to style/sector breakout plots

@vikram-narayan can you add screenshots?

here's a screenshot of the changes:

Can't speak to the content of the PR itself, but the changes to the tearsheet look right to me 👍


New Optimization Algorithm Ant-Bee-Colony Optimization

Is your feature request related to a problem? Please describe.
I will add Python and C++ codes for Ant Bee Colony (ABC) Optimization.
Describe the solution you'd like
The Artificial Bee Colony (ABC) algorithm is a population-based optimization algorithm inspired by the foraging behavior of honeybees. It was proposed by Dervis Karaboga in 2005.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
The algorithm simulates the foraging behavior of bees, such as employed bees, onlooker bees, and scout bees, to search for an optimal solution in a given search space.

I think you have already worked on this issue and your PR was marked plagarised


[BUGFIX] Fix the release bug

The original call to assemble.sh used a path related to the machine, causing the release version to report path-related errors. Therefore, we abandoned the calling method of assemble.sh and directly generated the .vmem file in the pocl source code.

只解决了部分问题, ventus_final_ld_flags等使用了开发环境宏的变量都会有问题

后期优化，获取路径。


Update chompy-hunter

Plugin has been stale for about two years. I had pushed out a pull request 2 weeks ago with some work/comments. This will include some updates which have been in pull requests from myself and other members.
Intention is to take over while the plugin remains stale.
I have resubmitted pull request in its own branch.

@ejedev are you okay with this plugin being moved?

@Adam- Apologies for the delay, I am!


Write on boarding text for "Find centroid of geometries" analysis

{Calculating centroids from geometries} has finished.
New columns have been {created as a new dataset}.

{the_geom}
{Point geometries representing the centroid(s) of your input data.}
{value}
{If Aggregate is selected, this will store the aggregate value for each centroid. If not, it will contain the count of features considered for each centroid.}
{category}
{If Categorize is selected, this column will store the category value for each centroid from the source dataset}

{Centroids are calculated from all, groups, or singular geometries. Using the optional parameters of Category, Aggregate, and Weight you can change how they are calculated and what information the result will contain.}
{link to documentation}

Ok, I propose the following changes:
For category since we now if the user selected a column, we could show the list item only when the user categorices by a column and say:
{category}: {This column stores the category value for each centroid from the source dataset}
For value we would have these two versions:

{value} {This column stores the aggregate value for each centroid.}
{value} {This column contains the count of features considered for each centroid.}

❤


Update save_estimated_reference.py

Thanks!

Hi Nikolai,
no problem!
One question for you, what exactly would be the use of this script? As
obviously, you can use the export reference button with Save rotation, Save
errors and *Save estimated values *options to get basically the same info
as save_estimated_reference script...
Le lun. 5 avr. 2021 à 05:05, Nikolai Poliarnyi @.***> a
écrit :

Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/agisoft-llc/metashape-scripts/pull/29#issuecomment-813317920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR2YQMPKCJGPVN5GSYTOIZ3THGDNRANCNFSM42L3EH3A
.

--
Paul Pelletier,
Surveyor, Agrimensor, CIVIS
Prolongación Berriozábal No. 2001,
Fracc. Comercial 2000,
Cd. Victoria, Tamaulipas, C.P. 87099
Tel. +528341062478

Hi Paul, this script is more an illustration of how values in the reference pane are calculated (some users were asking).

Hello Nikolai,
i think  line 46 of code:
self.error_location = ecef_crs.localframe(location_ecef).rotation() * self.
error_location
should be changed to:
self.error_location = crs.localframe(location_ecef).rotation() * self.
error_location
as the original line incorrectly transforms ecef error vector into ecef_crs
instead of crs.
as in example below for one camera:
[image: image.png]
Le lun. 5 avr. 2021 à 16:48, Nikolai Poliarnyi @.***> a
écrit :

Hi Paul, this script is more an illustration of how values in the
reference pane are calculated (some users were asking).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/agisoft-llc/metashape-scripts/pull/29#issuecomment-813670446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR2YQMOIGAXXLOSHVJGOZP3THIV4HANCNFSM42L3EH3A
.

--
Paul Pelletier,
Surveyor, Agrimensor, CIVIS
Prolongación Berriozábal No. 2001,
Fracc. Comercial 2000,
Cd. Victoria, Tamaulipas, C.P. 87099
Tel. +528341062478

Fixed, thanks :)


[Feature request] Allow select text without focus and unlock minimum window size

Is your feature request related to a problem? Please describe.
I'm always frustrated when I'm doing something on the PC and I decide to copy some text from Notepads and I just can't select it before bringing the window into focus.
Describe the solution you'd like
Allow to select text without Notepads focused.
Describe alternatives you've considered
^.
Additional context
I would also like to be able to further reduce the size of Notepads, as I can in Default Notepad.
Video demonstrating the text selection problem
https://user-images.githubusercontent.com/83718128/143404783-2646f9ff-adf7-4d04-a0bd-fb8de449310e.mp4
Notepads are awesome !

This would be an efficiency improvement of Notepads indeed.
Sparing a click, when you do it hundreds of times a day, matters.
As a workaround the only thing I can see is:

Go to the Control Panel\All Control Panel Items\Ease of Access Centre\Make the mouse easier to use screen
Check the Activate a window by hovering over it with the mouse box

I really don't know how to bypass that using UWP. But in the meantime, I am seeing that you are able to do so with Windows Mail app which is also UWP. So I am convinced that this is doable just that I don't know how to do it yet.

I have made a custom UWP TextBox Control before, but it can do that . I guess the reason that you can't select text could be "TextBox.PointerReleased" triggered when window focused, you can try use "CoreWindow.PointerReleased" instead of it.


[Blending] Smoke Randomization Starting Point

Create a module to get a random dx,dy starting point for smoke addition

Hi @jpennors , thnaks for your PR, can you fix the tests ? I'm looking at the code itself but you missing init files to make the package work properly

I recommend adding the following code:
from skimage import measure
blobs_labels = measure.label(mask, background=0)
s = [np.sum(blobs_labels==l) for l in np.unique(blobs_labels)[1:]]
mask = blobs_labels==(np.where(s==np.max(s))[0] + 1)

This will improve the mask by removing false detection like text in the corner for example


Fix typo in docs/csharp/snippets/properties/

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JohannHoepfner sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

closing and reopening for a fresh build.


fix words spelling issue 群集 -> 集群

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17
For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh
For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thanks, Please sign CLA first. @TerryWang9112

/check-cla

/check-cla

@TerryWang9112  参考翻译指引

/close

/reopen


Add support for WSL in vscode

Whenever ps is run in a WSL window in vscode, it prints an error (a "false positive" in a way), causing to pidtree fail.
This work around here is also used in vscode itself.
I don't know whether you want to introduce something like this. As tiny of a change and as simple as it may be, I would understand it if you were to argue that you don't want to start including workarounds for such specific scenarios.
But in case the vscode team either doesn't want to or is unable to address this at the source (this problem has existed for years), this would obviously enable pidtree to be used for tooling in that environment as well. (I recently contributed an improvement to the concurrency behavior of lint-staged that uses pidtree and that I ironically haven't been able to benefit from because I happen to use WSL...)

Codecov Report

Merging #17 (c015637) into master (5ebe846) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   86.95%   86.23%   -0.73%
==========================================
  Files           6        6
  Lines         138      138
==========================================
- Hits          120      119       -1
- Misses         18       19       +1

Impacted Files
Coverage Δ

lib/bin.js
78.26% <100.00%> (ø)

lib/get.js
81.81% <0.00%> (-9.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ebe846...c015637. Read the comment docs.

Hi @s-h-a-d-o-w ,
Thanks for adding this to the project! I think it's fine because VSCode code is using it too.
Could you please add a unit test to make sure this works in our code base so that we can have enough confidence to approve it?
Thank you very much.

Done. Apologies for missing that!
I hope they are alright because... I'm not a fan of these redundancies myself. But looking at the already existing tests and skimming the mockery docs (as well as attempting to remove some of those redundancies), this seemed to me like a conscious decision by the original author and so I ended up following suit.

Thanks for adding the unit test!
I think this PR is good and I'd like to approve this PR after the CI turns green.

Hey! Thank you for this fix.
We are also being affected by this issue. Any prediction on when this will be merged and published?
Thanks a lot!

@juliomrc could you please give an approval to this PR to help us confirm this code is ok?
@simonepri I think this PR will be good to go, and I will merge it if you do not against it and after it get another approval.

@huan thanks for the quick action.
Will you also release the patch to npm?

Sorry everybody for being so late to the party!
I took a look at the PR, and I'm okay with implementing a workaround for this issue, but I'm not sure I like how we implemented it in this PR as it can cause us to ignore more than just the bogus screen error.
I took the liberty to change the code to strip the message from the error stream instead, so that we can ignore only that particular error message.
Please take a look, and confirm this will work as intended:
https://github.com/simonepri/pidtree/commit/4fa79c596d94998ec666639bbe4623432e6a1349
I'll release a new version as soon this is confirmed.
Thanks a lot for the help!

I release a new 0.6.0, let me know if this solves the issue.

This fix works as intended and the edge case integration with lint-staged no longer produces a problem.
Thank you!

@simonepri

it can cause us to ignore more than just the bogus screen error.

That's fair but... on the one hand, I wonder whether ps ever produces other errors when this one occurs (but I'm fine with your adjustments, so I will not invest the time looking into this) and on the other, since you are checking for a more specific error message it is obviously more brittle to changes (not that that's likely after all these years...).
That said...

Thanks a lot for the help!

... and thanks to you for making WSL users happy! I wasn't sure whether it would happen since the last release here was a long time ago (I guess there simply haven't been any issues - which is awesome), so I'm really grateful. 🙂


Where does Bicep get installed?

There are multiple ways documented to install Bicep on a windows box.  None of them go to a consistent location.  In one instance you install via winget, not sure where that gets installed.  There is a manual install that puts it in %USERPROFILE%/.bicep, and the air gapped install where the instructions say to put in in %USERPROFILE%/.azure.bin
Is there some way that we can be consistent with this?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 341ba1b9-e7ea-92a5-3181-6fe48f5df59d
Version Independent ID: 8b49d4d1-2215-73d7-959d-554ffdfc002b
Content: Set up Bicep development and deployment environments - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/install.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

@davemedvitz
Thanks for your feedback! We will investigate and update as appropriate.

@davemedvitz This is expected. Where Bicep CLI gets installed depends on which tool you use to install it. Different tools like winget and Azure CLI should not share the same installation location since that may cause conflicts.

@davemedvitz Hope the information provided is helpful. As there are no further documentation changes, we will close the issue for now. If there are further questions , please revert and we will be glad to assist you.

PS C:\Users\AMatiuk> winget install -e --id Microsoft.Bicep
The msstore source requires that you view the following agreements before using.
Terms of Transaction: https://aka.ms/microsoft-store-terms-of-transaction
The source requires the current machine's 2-letter geographic region to be sent to the backend service to function properly (ex. "US").
Do you agree to all the source agreements terms?
[Y] Yes  [N] No: Y
Found Bicep CLI [Microsoft.Bicep] Version <IP_ADDRESS>165
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/Azure/bicep/releases/download/v0.16.1/bicep-setup-win-x64.exe
██████████████████████████████  23.0 MB / 23.0 MB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Users\AMatiuk> bicep
bicep : The term 'bicep' is not recognized as the name of a cmdlet, function, script file, or operable program. Check
the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1

bicep

  + CategoryInfo          : ObjectNotFound: (bicep:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException


How to set a different threshold for classification probability tab that is not 0.5?

I am having issues to understand how to use  ProbClassificationPerformanceTab() as it seems the position of the item in the list column_mapping.prediction is very important to the output of the recall precision curve and area under the curve.
On the other hand, the classification report that comes in the same dashboard seems to use a default 0,5 threshold to cut the probability predictions. Is there a way to change the threshold?
also is there a way to set what to consider as the positive class in the precision recall curve?
thanks

Hi @Guidosalimbeni
Yes, you are right, for this report class order matters. In particular, column order in Probabilistic Binary Classification. The tool expects that the target (so-called positive) class is the first in the column_mapping['prediction'] list.
Unfortunately, now we do not have an option to set a positive class explicitly, but it is definitely needed. Thank you for pointing it out.
At the moment there is no way to set a custom threshold for the probability predictions, but it will be added in the next release. We are adding QualityMetricOptions and the threshold will be there.

Hi @Guidosalimbeni
We added this functionality in #122
You can get more details here https://docs.evidentlyai.com/user-guide/customization/options-for-quality-metrics


Break up CSS into different files

File ideas: fonts, variables, each page, etc

Were you thinking we'd manually manage each .css file, or use tooling to bundle them together?


Feature/lawn mower entity

Add Lawn Mower Entity
Home Assistant has a native lawn mower entity since version 2023.9 so I quickly added it.
It is based on the vacuum entity. The state mapping reflects the husqvarna implementation.

@dereisele - Thank you for your work! Makes sense to use the mower base entity here now it's available in HA.
Instead of coping everything, can you just change the vacuum to mower?
There is no reason anymore to keep the vacuum, we can drop that support now.

Hi, I would keep the vacuum entity for now, because it's supported by the Google Assistant integration, but the lawn mower isn't.
The largest non-specific copy-paste is the state mapping. Maybe it could be moved to the mix-in Indego Entity.

I would keep the vacuum entity for now, because it's supported by the Google Assistant integration, but the lawn mower isn't.

Ok, that's a good argument to keep it to prevent breaking things. I think we should make it configurable... expose it as vacuum, mower or none.
I will have a look at your code soon and try to merge it.

Nice, comment here if you need any help

It has been merged, optimized and made configurable. It's now on the develop branch.

Nice, comment here if you need any help
Can you test it?

Expose as 'mower' or 'vacuum' if now configurable. Both disabled by default. This can be enabled through the integration configuration panel.

@wimb0 - I noticed you have added the PL translations some time ago. Some translations are now missing due to new functionality. Any chance you can add the new translations?

Maybe @zmechu can help with the Polish translations. He is the one who did the translation.
@sander1988 Is Dutch already up-to-date, if not I can add these.?

Maybe @zmechu can help with the Polish translations. He is the one who did the translation. @sander1988 Is Dutch already up-to-date, if not I can add these.?

Sure! Which file should be translated?

I think this one: https://github.com/jm-73/Indego/blob/lawn-mower-entity-feature/custom_components/indego/translations/pl.json
Seems like EN (and NL) is already translated, so you can use https://github.com/jm-73/Indego/blob/lawn-mower-entity-feature/custom_components/indego/translations/en.json as source for what needs to be translated.

I think this one: https://github.com/jm-73/Indego/blob/lawn-mower-entity-feature/custom_components/indego/translations/pl.json Seems like EN (and NL) is already translated, so you can use https://github.com/jm-73/Indego/blob/lawn-mower-entity-feature/custom_components/indego/translations/en.json as source for what needs to be translated.

Done, please take a look if all is OK.

Do you mean the alert description and headline ?

Ok, at the moment it is not possible because some codes have to be added first but im working on it and hope to finish it tomorrow. I will write anpther PR and let you know when im done so you can start working on your additional translations 😉

Great 😎

From: kizeu @.>
Sent: Monday, May 27, 2024 4:25:54 PM
To: jm-73/Indego @.>
Cc: urbatecte @.>; Comment @.>
Subject: Re: [jm-73/Indego] Feature/lawn mower entity (PR #216)
Ok, at the moment it is not possible because some codes have to be added first but im working on it and hope to finish it tomorrow. I will write anpther PR and let you know when im done so you can start working on your additional translations 😉
—
Reply to this email directly, view it on GitHubhttps://github.com/jm-73/Indego/pull/216#issuecomment-2133593740, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI4MVOXKY3LHA6K44HL2DGDZEM67FAVCNFSM6AAAAABH6WHDCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTGU4TGNZUGA.
You are receiving this because you commented.Message ID: @.***>

I'm not used to make PR :-(
Please find here attached my translation for french
Thanks a lot for your job guys !
fr.json

Good morning guys,
i have added the translations for the entities "Alert Description", "Alert Headline", "Mower State" and "Mower State Detail".
Can you please have a look to the translation files here and change it where needed ?! i left the new lines, where you have to make your changes, blank so you only have to insert the correct translation between the " ".
@zmechu i have added the translation for the services in the pl.json file in the link above so they need to be translated too ;)
Please let me know when you have finished the translations and i will create the PR for that.
One additional request: While you are translating the texts, could you please have a look if the list of possible alerts and mower states is complete ? Unfortunately i have not found a complete list of all possible messages, that's why I could only use the ones that I have encountered so far.
Thanks a lot!

Hi @kimzeuner ,
Here is my french translation file.
fr.json
It seems that some alert message are missing.
In my app, I still have kind of:
Mower stopped by an obstacle
Check blades
Mower immobile (different status than mower stucked, wheel still running but fixed position)
Connection to docking station not possible
Mower too slopped/inclined
Cheers

I think there is no need to translate alert messages. They are returned by the API in the language of the account. I just tested it, I get my alerts in my native language (Dutch).
What I see:

alert description = English
alert message = Native language

And note that code (including alerts) is still being optimized and might change a bit before the release.

Correct, i saw the same (alert message in native language) in my system, thats why i have not translated them.
Should i wait with a PR for the translations until you have finished optimizations ?

Correct, i saw the same (alert message in native language) in my system, thats why i have not translated them. Should i wait with a PR for the translations until you have finished optimizations ?

I recommend it, I'm nearly done optimizing the alert part, will commit it when complete. I will also open a separate issue for translations when ready. It's not really related to this PR, so a bit confusing.

Please provide all translation updates in a PR or file in issue #221. Thank you! Note that I just pushed an update to the develop branch requiring more translations ;-)


Client crash

Hi, when I build and run this project and then load http://localhost:3000 and click on "best" in the orange top bar of the site and then click on "top" in the same orange top bar, the page stops working. I get output in the console showing that this is due to a crash.
The full output is quite long so I am initially posting only the beginning of the two messages that show up in the console:
client.js:321 panicked at 'must have a parent node, tag: Some("ol"), path: TreePath { node_idx: 110, path: [0, 2, 0, 0, 4] }, for patch: Element(
    Element {
        namespace: None,
        tag: "li",
        attrs: [
            Attribute {
                namespace: None,
                name: "key",
                value: [
                    I64(
                        28199994,
                    ),
                ],
            },
        ],
[...]

and
client_bg.wasm:0x9a362 Uncaught RuntimeError: unreachable
    at __rust_start_panic (client_bg.wasm:0x9a362)
    at rust_panic (client_bg.wasm:0x98546)
    at std::panicking::rust_panic_with_hook::h2d9079427a2d996a (client_bg.wasm:0x8a5f0)
    at std::panicking::begin_panic_handler::{{closure}}::h4e49f350d9f4de36 (client_bg.wasm:0x8fd5f)
    at std::sys_common::backtrace::__rust_end_short_backtrace::h91e711607d91be52 (client_bg.wasm:0x97dfc)
    at rust_begin_unwind (client_bg.wasm:0x97074)
    at std::panicking::begin_panic_fmt::h7a3482363d68bbca (client_bg.wasm:0x97b8c)
    at sauron_core::dom::apply_patches::apply_patch_to_node::{{closure}}::h75823b077a8bf1f0 (client_bg.wasm:0x90153)
    at sauron_core::dom::apply_patches::patch::hbbaec4fc219f9cfc (client_bg.wasm:0x32ca2)
    at sauron_core::dom::dom_updater::DomUpdater<MSG>::update_dom::h1ec3d272cce49647 (client_bg.wasm:0x5c501)
$__rust_start_panic @ client_bg.wasm:0x9a362
$rust_panic @ client_bg.wasm:0x98546
[...]

The browser I am using is Brave Version 1.28.105, which is based on Chromium: 92.0.4515.131 (Official Build) (arm64). Running on a MacBook Pro M1 with macOS Big Sur Version 11.5.2.

Thanks for reporting @ctsrc , I'll look into it.

I have replicated the issue and it has to do with the dom-diffing optimization when the keyed elements are changed in their order.
Explanation:
Each item in hacker news has a unique id, and is used as key as in keyed-element, The top and best stories will mostly like have stories that are present in both listing, and they only differ in arrangement.
The algorithm that handles this must keep track of which element has matched or has passed that could have matched. If it has passed the element that could have matched, should not be matched and will therefore be deleted.
For the time-being this fixed by not using a keyed element on the stories, until the dom-diffing code is modified to handle this cased.

This has been fixed in the released of sauron 0.49.2 and mt-dom 0.19, which is the version used in the repo.


increase timeout likely causing ci test flap

https://issues.apache.org/jira/browse/CASSANDRA-11211

I don't understand, in the CI failure, we had too many notifications, not too few, right? I don't think increasing the timeout would fix that.
Unless I'm unaware of the failure cause

You make a good point there. with the timeout bump I'm no longer repro-ing locally but maybe that's unrelated. Seems like the intent of the test was to wait for at least 3 notifications, so maybe it just needs to be relaxed to 3 or more.

I disagree, based on initial analysis, that it was waiting for at least 3. I think we should be expecting an exact amount here.

ok, good thinking, closing this to look into a new fix.


Add --upgrade to pip install

I’m building an app with dependencies defined in setup.py using install_requires to list them. In my requirements.txt, I have a line with . on it that installs my main module and all its dependencies.
Without the --upgrade option, pip does not recognize the addition of new requirements in builds over time and incorrectly skips them. This patch fixes the bug and correctly installs locates all installation requirements that may have changed in a new push to Heroku.

You should be doing -e . instead.
The Python buildpack actually automatically does this if you don't have a requirements.txt file present but do have a setup.py. Nice little trick :)

Thank you! How can I do -e . with the existing buildpack + requirements.txt?

Just add that anywhere in your requirements.txt file.

Ah so, thanks.


Fix for Recruit Officers Frontend.

With this change the page seems to be rendering good now. Thanks for looking into this! Merging. 👍