HDFS-17470. FsVolumeList#getNextVolume can be moved out of DataSetLock.

Description of PR
Refer to HDFS-17470.
FsVolumeList#getNextVolume can be out of BLOCK_POOl read lock.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 39s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 12s

trunk passed

+1 :green_heart:
shadedclient
35m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
35m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
228m 44s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

368m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6733/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 065368168f63 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 382dfcc3c3e8c4fdd85102c8b1cd602d4fc35298

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6733/1/testReport/

Max. process+thread count
3780 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6733/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 01s

No case conflicting files found.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+0 :ok:
codespell
0m 00s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
108m 51s

trunk passed

+1 :green_heart:
compile
7m 38s

trunk passed

+1 :green_heart:
checkstyle
5m 46s

trunk passed

+1 :green_heart:
mvnsite
8m 05s

trunk passed

+1 :green_heart:
javadoc
7m 19s

trunk passed

+1 :green_heart:
shadedclient
175m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 36s

the patch passed

+1 :green_heart:
compile
4m 16s

the patch passed

+1 :green_heart:
javac
4m 16s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 49s

the patch passed

+1 :green_heart:
mvnsite
5m 05s

the patch passed

+1 :green_heart:
javadoc
4m 28s

the patch passed

+1 :green_heart:
shadedclient
195m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
6m 41s

The patch does not generate ASF License warnings.

513m 52s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 2785c41ce87a 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 382dfcc3c3e8c4fdd85102c8b1cd602d4fc35298

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6733/1/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6733/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 00s

No case conflicting files found.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+0 :ok:
codespell
0m 00s

codespell was not available.

+0 :ok:
detsecrets
0m 00s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
86m 39s

trunk passed

+1 :green_heart:
compile
6m 00s

trunk passed

+1 :green_heart:
checkstyle
4m 46s

trunk passed

+1 :green_heart:
mvnsite
6m 20s

trunk passed

+1 :green_heart:
javadoc
5m 45s

trunk passed

+1 :green_heart:
shadedclient
142m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 26s

the patch passed

+1 :green_heart:
compile
3m 29s

the patch passed

+1 :green_heart:
javac
3m 29s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 17s

the patch passed

+1 :green_heart:
mvnsite
3m 57s

the patch passed

+1 :green_heart:
javadoc
3m 21s

the patch passed

+1 :green_heart:
shadedclient
152m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
7m 34s

The patch does not generate ASF License warnings.

411m 21s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6733

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 6642f8136c04 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 382dfcc3c3e8c4fdd85102c8b1cd602d4fc35298

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6733/2/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6733/2/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


StreamSubscriptions triggering all events on auth token refresh

Hey guys,
I observed that when the service token changes (NHostClient addTokenChangedCallback is triggered), all my subscription streams attached to Hasura produce the same data again since the app started listening to them.
Is that the expected behaviour?
Would be a security breach to not refresh the token every minute but once every couple of hours as a way around? What's the drawback?
Any suggestions?
Currenly utilising nhost_sdk: ^3.0.4  and  nhost_graphql_adapter: ^2.0.3
Thank you

Facing the same issue and thinking about ways to fix it... Currently it produces major problems. One solution could be to to work around streams and move from subscriptions to queries.. But thats a big pain..
Increasing the jwt token duration is a security no go for us. May be increased to 1,2,3 minutes, but not more and that won't help.
I am not expert enough to fully figure out if the sdk could be improved to prevent this - so if there is any help by the nhost team / SDK maintainer, that would be highly highly appreciated and also supported from our end where we can. Can't go live with the current solution..

Hi guys, any updates on this issue?
Thank you

Hi,
As of now, this is pretty much expected as the new token is issued, and the connection must be reestablished with a new token. However, I am working on a new release to provide a few solutions. Please stay tuned, I will let you know once it's ready. Meanwhile, you can try the latest dev version https://pub.dev/packages/nhost_sdk/versions#prerelease

Hi @mhadaily, do you have any updates regarding this issue?
Thank you

Hi,
The reconnection is expected as the token is refreshing. However, there was a bug that the token was refreshed every 30 seconds, whereas the actual time was 15 minutes. This bug is fixed in the latest version now nhost_sdk: ^4.0.0-dev.7
You can upgrade to this version; however, consider that you need to remove backendUrl and instead use subdomain and region.


Getting ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined

We are getting
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in langchain\package.json
It started happening from versions 0.0.13 and up.
It works fine for 0.0.12.

Same issue as well. The exports in the package.json have switched from
    "./embeddings": {
      "import": "./embeddings.mjs",
      "default": "./embeddings.js"
    },

to
    "./embeddings": {
      "types": "./embeddings.d.ts",
      "import": "./embeddings.js"
    },

The langchain package is now ESM only. You can fix that by adding "type": "module" to your package.json. You can find more information here https://hwchase17.github.io/langchainjs/docs/getting-started/

The langchain package is now ESM only. You can fix that by adding "type": "module" to your package.json. You can find more information here https://hwchase17.github.io/langchainjs/docs/getting-started/

@nfcampos I'm not sure I understand why this requirement exists. Is this on purpose or will this be changed? Happy to open up a PR with the fix if that would be accepted.

@irl-dan we converted the package to ESM so that we can support other environments outside of Node, which are ESM only, discussion here https://github.com/hwchase17/langchainjs/discussions/152
You also have the option to use it without type: module by using dynamic import as mentioned here https://hwchase17.github.io/langchainjs/docs/getting-started/#commonjs-in-nodejs

Hello.
Using dynamic import on my side produce the same error.
const { OpenAI } = await import('langchain');
and
const { AnalyzeDocumentChain, loadSummarizationChain } = await import('langchain/chains');
tsconfig.json:
{
  "compilerOptions": {
    "module": "commonjs",
    "declaration": true,
    "removeComments": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "allowSyntheticDefaultImports": true,
    "target": "es2017",
    "sourceMap": true,
    "outDir": "./dist",
    "baseUrl": "./",
    "incremental": true,
    "skipLibCheck": true,
    "strictNullChecks": false,
    "noImplicitAny": false,
    "strictBindCallApply": false,
    "forceConsistentCasingInFileNames": false,
    "noFallthroughCasesInSwitch": false,
    "resolveJsonModule": true
  }
}

node version:
v18.12.1
Any idea ?

Some more information on your issue here https://stackoverflow.com/questions/65265420/how-to-prevent-typescript-from-transpiling-dynamic-imports-into-require
A solution for you appears to be "moduleResolution": "node16", see here https://github.com/microsoft/TypeScript/issues/43329#issuecomment-1315512792

Thanks for the fast reply.
Doing so, with :
    const { OpenAI } = await import_('langchain');
    const { AnalyzeDocumentChain, loadSummarizationChain } = await import_('langchain/chains');
    const { RecursiveCharacterTextSplitter } = await import_('langchain/text_splitter');

    const text = this.speakerRecognitionPromptFormatting(
      JSON.parse((conversation as any).toString()).prediction,
      'ok',
    );

    // text is a string.

    const model = new OpenAI({
      temperature: 0,
      openAIApiKey: ...,
    });
    /** Load the summarization chain. */
    const chain = loadSummarizationChain(model);
    const textSplitter = new RecursiveCharacterTextSplitter({ chunkSize: 1000 });
    const docs = await textSplitter.createDocuments([text]);
    const res = await chain.call({
      input_document: docs,
    });

Results in a Error: Document key input_documents not found. error. Also tried with AnalyzeDocumentChain from documentation snippet.
Do you want me to create a separate issue ?

I think the issue might be an s missing on input_document on the last line, should be input_documents

Yep it is. Thanks. Can I submit a PR on the documentation for this single simple correction ?

Yes, thank you

Unfortunately It might not be only a documentation issue, running :
    const text = this.speakerRecognitionPromptFormatting(
      JSON.parse((conversation as any).toString()).prediction,
      'oki',
    );
    console.log('text :', text);
    const model = new OpenAI({
      temperature: 0,
      openAIApiKey: ...,
    });
    /** Load the summarization chain. */
    const combineDocsChain = loadSummarizationChain(model);
    /** Pass this into the AnalyzeDocumentChain. */
    const chain = new AnalyzeDocumentChain({
      combineDocumentsChain: combineDocsChain,
    });
    const res = await chain.call({
      input_documents: text,
    });

Regarding input_documents or input_document with the s change I get different errors. By trying to match the code I get hit by TypeError: currentDocs.map is not a function, occuring in combine_docs_chain.js
I feel like I might be doing something wrong. Note that the text that i'm sending is just a string, not coming from any file.

Ah, input_documents is expected to be an array of Document, see eg the second code block in this page https://hwchase17.github.io/langchainjs/docs/modules/chains/summarization You can get an array of Documents from eg a TextSplitter, or a Loader

When will langchain support CommonJS? Turning my backend package into a module is problematic for many other packages that rely on CommonJS patterns.

If it can helps someone running CommonJS (pretty common to be fair), you can import the langchains modules dynamically and without changing anything config related by using this import package
https://www.npmjs.com/package/@brillout/import

I was struggling with this in a NextJS application. Fortunately, I'm in a monorepo environment and I was able to get it to work by creating a new "package" with type: "module and then having NextJS transpile the package.
My interface to langchain goes through the new package and NextJS is happy.
next.config.js
{
transpilePackages: ["my-ai-package-w-langchain"],
};

You might be able to get around by the following codes:
// tsconfig.json

{
  "compilerOptions": {
    "target": "ES2020",
    "module": "nodenext"
  }
}

// main.ts

const main = async () => {
  const { OpenAI } = await import('langchain');

  const llm = new OpenAI({
    openAIApiKey: '-----',
  });

  const res = await llm.call(
    'your prompt'
  );
  console.log(res.trim());
};

main()
  .then(() => {
    console.log('[done]');
  })
  .catch((e) => {
    console.error(e);
  });

% ts-node path/to/main.ts

Just hitting this now, +1 to CommonJS support. The only workaround I found that "worked" is brillout, mentioned above
import { import_ } from '@brillout/import';

export async function foo(): Promise<string> {
  // Have to do dynamic imports:
  // https://github.com/hwchase17/langchainjs/issues/185
  const { PromptTemplate } = await import_('langchain/prompts');
  const { ChatOpenAI } = await import_('langchain/chat_models');
  const { HumanChatMessage, SystemChatMessage } = await import_('langchain/schema');
  // call API
}

Granted, I cannot get it to send requests, but that may be separate...
ReferenceError: Headers is not defined
    at createRequest (file:///Users/nickbradford/dev/node_modules/langchain/src/util/axios-fetch-adapter.js:273:19)
    at fetchAdapter (file:///Users/nickbradford/dev/node_modules/langchain/src/util/axios-fetch-adapter.js:196:19)
    at dispatchRequest (/Users/nickbradford/dev/node_modules/axios/lib/core/dispatchRequest.js:58:10)
    at Axios.request (/Users/nickbradford/dev/node_modules/axios/lib/core/Axios.js:108:15)
    at Function.wrap [as request] (/Users/nickbradford/dev/node_modules/axios/lib/helpers/bind.js:9:15)
    at /Users/nickbradford/dev/node_modules/openai/dist/common.js:149:22
    at /Users/nickbradford/dev/node_modules/openai/dist/api.js:1738:133

@nfcampos  Encounter the same condition...

@nfcampos  I found the reason is that I missing the polyfill to node-fetch:
import { import_ } from '@brillout/import'
import { Logger } from '@nestjs/common'

export const openaiTranslate = async (text: string, target: string[]) => {
  // Polyfill for node-fetch
  const  { Headers, Request, Response } = await import_('node-fetch')
  const fetch = await import_('node-fetch').then((mod) => mod.default)
  if (!globalThis.fetch) globalThis.fetch = fetch
  if (!globalThis.Headers) globalThis.Headers = Headers
  if (!globalThis.Request) globalThis.Request = Request
  if (!globalThis.Response) globalThis.Response = Response

  const { OpenAI } = await import_('langchain')
  const OPENAI_API_KEY = 'sk-xxx'
  const model = new OpenAI({ openAIApiKey: OPENAI_API_KEY, temperature: 0.9 })

  const res = await model.call(
    'What would be a good company name a company that makes colorful socks?'
  )

  Logger.log(res)

  return res
}

I think where this is confusing is that the docs say for commonjs modules to use async import but commonjs modules are not allowed to await calls at the top level of any module.  This makes the docs feel a bit counterintuitive

The langchain package is now ESM only. You can fix that by adding "type": "module" to your package.json. You can find more information here https://hwchase17.github.io/langchainjs/docs/getting-started/

THIS IS NOT A SOLUTION TO THE PROBLEM.

@irl-dan we converted the package to ESM so that we can support other environments outside of Node, which are ESM only, discussion here #152
You also have the option to use it without type: module by using dynamic import as mentioned here https://hwchase17.github.io/langchainjs/docs/getting-started/#commonjs-in-nodejs

Page not found.

Anyone have any luck using in a Remix.run project?

Would there be interest in exporting to commons and esm? I'd be interested in taking that on.

I see thanks.
Curious if anyone here has a working example of nestjs to view. The options mentioned here don't work for me. When using the await method it breaks other areas of nestjs. I'll post what I have in a bit

@imrank1 see an example here https://github.com/sullivan-sean/chat-langchainjs/
Or maybe better to look at my branch updating it to latest langchain version https://github.com/nfcampos/chat-langchainjs/tree/nc/lc0037

Thanks, the first reference worked for me.
Your fork off of the latest threw an error for me.
Followed the exact steps in README for both.
yarn && yarn ingest
yarn install v1.22.19
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
✨  Done in 5.35s.
yarn run v1.22.19
$ tsx -r dotenv/config ingest.ts
Loader created.
Docs splitted.
Creating vector store...
/Users/imrankhawaja/chat-langchainjs/node_modules/langchain/dist/vectorstores/hnswlib.js:44
        return new HierarchicalNSW(args.space, args.numDimensions);
               ^

Error: Wrong space name, expected "l2" or "ip".
    at Function.getHierarchicalNSW (/Users/imrankhawaja/chat-langchainjs/node_modules/langchain/dist/vectorstores/hnswlib.js:44:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at HNSWLib.initIndex (/Users/imrankhawaja/chat-langchainjs/node_modules/langchain/dist/vectorstores/hnswlib.js:51:26)
    at HNSWLib.addVectors (/Users/imrankhawaja/chat-langchainjs/node_modules/langchain/dist/vectorstores/hnswlib.js:70:9)
    at Function.fromDocuments (/Users/imrankhawaja/chat-langchainjs/node_modules/langchain/dist/vectorstores/hnswlib.js:147:9)
    at run (/Users/imrankhawaja/chat-langchainjs/ingest.ts:77:23)
    at <anonymous> (/Users/imrankhawaja/chat-langchainjs/ingest.ts:82:3)

Let me know if should log an issue in your fork?

@imrank1 ah thanks for letting me know, I've pushed a commit fixing that. the version of hnswlib-node needed to be updated

@imrank1 ah thanks for letting me know, I've pushed a commit fixing that. the version of hnswlib-node needed to be updated

@imrank1 ah thanks for letting me know, I've pushed a commit fixing that. the version of hnswlib-node needed to be updated

Verified it works!

Also found this problematic given that top level awaits aren't allowed. It prevents extending any of the base classes like below:
const { BaseDocumentLoader } = await import('langchain/document_loaders');

export default class SanitizeHtmlLoader extends BaseDocumentLoader {
}

Also chiming in to add that this requirement prevents me from using LangChain in new projects which depend on my old projects and generally impedes getting started. I'm able to get off the ground with this:
export const loadPricePeriods = async (path: string) => {
  const { OpenAI } = await import("langchain");
  const { RecursiveCharacterTextSplitter } = await import(
    "langchain/text_splitter"
  );
  const { Chroma } = await import("langchain/vectorstores");
  const { OpenAIEmbeddings } = await import("langchain/embeddings");
  const { CSVLoader } = await import("langchain/document_loaders");
  const loader = new CSVLoader(path);
  const docs = await loader.load();
  return docs;
};

So my usage of OpenAI has to be encapsulated by this function (or probably a class for long-term usage). Upgrading my old projects to ESM would be a big lift and I don't know how it'll affect those projects' dependencies either, so I feel like I have to settle for this awkward if workable solution.

Hi folks, we have an open PR adding CJS support #626. If you want to give it a try you can install the prerelease version with npm i langchain@next. Can you let me know it it works for you, before we announce for everyone?

@nfcampos Brilliant! I had to uninstall and reinstall d3-dsv (I think because of a version change), but this works well with the following in my tsconfig.json:
{
  "compilerOptions:" {
    // ...
    "module": "commonjs",
    "moduleResolution": "node",
    // ...
  }
}

Thanks a bunch, this makes life a lot easier.

@nfcampos Brilliant! I had to uninstall and reinstall d3-dsv (I think because of a version change), but this works well with the following in my tsconfig.json:
{
  "compilerOptions:" {
    // ...
    "module": "commonjs",
    "moduleResolution": "node",
    // ...
  }
}

Thanks a bunch, this makes life a lot easier.

I can confirm this worked for me as well. thanks!

I really can't get this to work. I'm using 0.0.50. It has issues with typescript it seems.
{
  "include": [
    "src/**/*",
  ],
  "compilerOptions": {
    "target": "es2020",
    "module": "commonjs",         /* I need this for other modules */
    "outDir": "./dist",
    "strict": true,
    "baseUrl": "./src",
    "skipLibCheck": true,        /* Remove this when langchain type check works. */
    "typeRoots": [
      "node_modules/@types"
    ],
    "types": [
      "node",
      "jest"
    ],
    "lib":  [
      "es2020",
      "dom",
    ],=
    "esModuleInterop": true,      /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports.
Path error solved but not able to use new packages.
module not found

Hello, I encountered this same error, I deleted my node_modules, package-lock.json; changed to "type": "module"; using npm i to re-download everything and it seem to be working.

Hello, I encountered this same error, I deleted my node_modules, package-lock.json; changed to "type": "module"; using npm i to re-download everything and it seem to be working.

Seems this doesn't work for me. I am using node v.22


Patch CV out 2 uninitialized

https://github.com/electro-smith/DaisyDuino/blob/ac3698a6349444773194bb01e88b7ccbb49fc8fb/src/DaisyDuino.cpp#L67
CV_1 is initialized twice on the patch, rather than initializing CV_1, then CV_2.

While we're at it, the gate inits a few lines above use hardcoded ints rather than the PATCH_GATE_1 defines

This is the issues section, for showing bugs.
If you think the code should be changed you can make a pull request.
The analog outputs do not even need to be declared to the lines of code do not even need to be there at all as far as I'm aware


Update contributors.txt

@Swgun - Team Lone-rangers

This branch has conflicts that must be resolved


Disable actionSheet which is used as a picker for IOS

How can I disable an ActionSheet which is used as a Picker (make it not clickable)?
I tried editable={false}, any other ideas please?
                <View style={styles.Column}>
                  <Text style={styles.TextLabel} onPress={this.showActionSheet}>Structure Type:</Text>
                    <ActionSheet
                  ref={o => this.ActionSheet = o}
                  title={'Structure Type'}
                  options={['first', 'second', 'third', 'Cancel']}
                  cancelButtonIndex={3}
                  selectedValue={this.state.structureType}
                  value={this.state.structureType}
                  onPress={this.handleSTypePress}
                  editable={false}
                />
                </View>

Solved it by adding pointerEvents="none" to the column view


I have searched for similar issues in both open and closed tickets and cannot find a duplicate. On IE >= 11, when deleting the options from the select box on a multiple required field, I cannot submit the form. Furthermore, sometimes the form will submit without an option being selected, even though the field is required. This only pertain to IE. The features work as expeccted on Chrome and FF. To reproduce this, select a few options in select2, then delete them and try to submit the form. The required attribute must be present in the tag. Any help would be much obliged, thanks

Prerequisites

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate
[x] The issue still exists against the latest master branch of Select2
[x] This is not a usage question (Those should be directed to the community)
[ ] I have attempted to find the simplest possible steps to reproduce the issue
[ ] I have included a failing test as a pull request (Optional)

Steps to reproduce the issue

Expected behavior and actual behavior
When I follow those steps, I see...
I was expecting...
Environment
Browsers

[ ] Google Chrome
[ ] Mozilla Firefox
[ ] Internet Explorer

Operating System

[ ] Windows
[ ] Mac OS X
[ ] Linux
[ ] Mobile

Libraries

jQuery version:
Select2 version:

Isolating the problem

[ ] This bug happens on the examples page
[ ] The bug happens consistently across all tested browsers
[ ] This bug happens when using Select2 without other plugins
[ ] I can reproduce this bug in a jsbin

I have the same issue in IE10. Chrome & FF is like expected.
https://jsfiddle.net/9h68eg6y/
Steps to reproduce scenario A (impossible to post a :valid select):

Load the page
Press "OK" without selecting an option.
Select an option
Press "Ok"

Result:
The form will not be submitted anymore. A page refresh is required to be able to submit the form if an option is directly selected after the page refresh.
Outside of jsfiddle you will get the browsers built-in validation error that the select is a required field. Although an option is selected...
Steps to reproduce scenario B (possible to post a :invalid select):

Load the page
Select an option
Press "OK". - everything is like expected
Remove the selected option
Press "OK" -

Result: Form should not be submitted, but will be!
Hope, this will help to fix this issue :-)


Update falco-detect-malicious-behavior-through-audit-logs-part-2.md

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Hey there,
I just stumbled across this minor issue when working my way through a deployment. Unless we tell the user to append /ui/ to the forwarded URL, they'll probably end up as confused as I was, for a while! :)

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

099b6c8 Update falco-detect-malicious-behavior-through-audit-logs-part-2.md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: funkypenguin
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @funkypenguin! It looks like this is your first PR to falcosecurity/falco-website 🎉

LGTM label has been added.  Git tree hash: de58850c481f26e83c3b4970f1eae97ae00d71aa

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: funkypenguin, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


LoremPixel is unusable as an image source

For days now LoremPixel response time is >20s. Maybe we should think about changing it?
https://placeholder.com has been pretty stable for long time for non context-specific images, https://placeimg.com allows context to be specified.

Duplicate of #957 and #1484.


Disable the onion routing (tor)

This PR disables the onion routing (tor) to fix a security issue.

LGTM


Get thread_ts from modal

Description:
Hello everybody,
i'm successfully able to get channel_id from my modal via "default_to_current_conversation": true", but it is not enough for my goal.
I'm creating a bot who open a modal with a shortcut, open a ticket on Jira via "jira" library and then i need to reply to the thread where the bot was launched to tell the ticket was open and other info obtained from Jira payload.
Thinking of a way / workaround to obtain the thread_ts i can't find any.
from slack_sdk import WebClient
from datetime import datetime
from jira import JIRA
from atlassian import Jira
from slack_bolt import App, Ack
from slack_sdk import WebClient
from slack_bolt.adapter.socket_mode import SocketModeHandler

logging.basicConfig(format='%(asctime)s.%(msecs)03d %(levelname)s {%(module)s} [%(funcName)s] %(message)s', datefmt='%Y-%m-%d,%H:%M:%S', level=logging.DEBUG, filename='log.log')

app = App(
    token="TOKEN",
)

api_token="TOKEN"
jira = Jira(
    url='https://LINK TO JIRA.com',
    username='',
    password='$$')

true=True

loading_modal = {
      "type": "modal",
      "title": {
        "type": "plain_text",
        "text": "Workplace check-in"
      },
      "close": {
        "type": "plain_text",
        "text": "Cancel"
      },
      "blocks": [
        {
          "type": "section",
          "text": {
            "type": "plain_text",
            "text": ":man-biking: Now loading..."
          }
        }
      ]
}

step1_modal = {
    "type": "modal",
    "callback_id": "open_incident",
    "title": {"type": "plain_text", "text": "Open an Incident"},
    "close": {"type": "plain_text", "text": "Close"},
    "submit": {"type": "plain_text","text": "Submit"},
    "blocks": [
        {
			"type": "header",
			"text": {
				"type": "plain_text",
				"text": "Open an Incident on JIRA",
			}
		},
		{
			"type": "input",
			"block_id": "summary_description",
			"element": {
				"type": "plain_text_input",
				"action_id": "summary_input-action"
			},
			"label": {
				"type": "plain_text",
				"text": "Summary",
			}
		},
		{
			"type": "input",
   			"block_id": "impact_description",
			"element": {
				"type": "plain_text_input",
				"multiline": true,
				"action_id": "impact_input-action",
			},
			"label": {
				"type": "plain_text",
				"text": "Description of Impact",
				"emoji": true
			},
		},
				{
			"type": "input",
			"block_id": "notification-channel",
			"element": {
				"type": "conversations_select",
				"action_id": "input-conv",
				"placeholder": {
					"type": "plain_text",
					"text": "Channel to post the result",
					"emoji": true
				},
				"default_to_current_conversation": true
			},
			"label": {
				"type": "plain_text",
				"text": "Notification",
				"emoji": true
			}
		}
    ],
}

@app.shortcut("open_incident_jira")
def open_modal_step1(ack: Ack, body: dict, client: WebClient, logger, say):
    ack()
    res = client.views_open(trigger_id=body["trigger_id"], view=loading_modal)
    logger.info("SONO NELLA MODALE")
    viewId = res["view"]["id"]
    res = client.views_update(view_id=viewId, view=step1_modal)

@app.view("open_incident")
def view_submission(ack, body, logger, view, say):
	ack()
	logger.info(body["view"]["state"]["values"])

	summaryDescription = view["state"]["values"]["summary_description"]["summary_input-action"]["value"]
	impact = view["state"]["values"]["impact_description"]["impact_input-action"]["value"]
	user_id = body["user"]["id"]
	channel_id=view["state"]["values"]["notification-channel"]["input-conv"]["selected_conversation"]

	logger.info("LOGGER PAYLOAD")
	logger.info(thread_ts)
	issue_dict = {
		"project":{"key":"INT"},
		"summary": summaryDescription,
		"customfield_16070": impact,
		"issuetype":{"name":"Production Incident"}
	}

	#jira.issue_create(fields=issue_dict)

	logger.info("USER_ID: " + user_id)
	logger.info("CHANNEL ID: " + channel_id)

	say (channel=channel_id, thread_ts = "1669652117.279039", text=f"<@{user_id}> opened an Incident, summary: {summaryDescription}")

# Start your app
if __name__ == "__main__":
    SocketModeHandler(app, "TOKEN").start()```

Do you know any possible way to obtain this?

Thank you very much everybody!

Regards.

Requirements (place an x in each of the [ ])
[x] I've read and understood the [Contributing guidelines](https://github.com/slackapi/node-slack-sdk/blob/master/.github/contributing.md) and have done my best effort to follow them.
[x] I've read and agree to the [Code of Conduct](https://slackhq.github.io/code-of-conduct).
[x] I've searched for any related issues and avoided creating a duplicate issue.

Hi @lucafx thanks for your question!
Here is a sample payload that your app receives from the MessageShortcut interaction. In this payload there is a message_ts field, this should be the ts value you want to provide as thread_ts in order to reply to a message.
Let me know if this is what you were looking for

Thank you William!
Any ideas on how message attributes can be accessed?
While debugging all my args in the MessageShortcut i can't retrieve the message_ts.
I need a way to get the thread_ts at the first step of this workflow, in the @app.shortcut("open_incident_jira") if possible.
Thank you again!


fix „net.request errors not catchable“ error

Catch net.request errors and emit callback.
(These errors mostly happen, when the internet connection is cut when a request is in in progress or there is no internet connection at all and a request should be sent)
Did not test for bulk downloads, since I don't use them.

@danielnieto can you please check and merge this? It fixes some nasty bugs I am working on atm...

@danielnieto can you review this please, I'm having the same issue and I think that this PR fix it.


angularjs ui typeahead not working with angular-block-ui

Up ,down arrow key not working after second time and focus out from input after one backspace and after second backspace it moves to previous page.
I am using
angular-block-ui v0.0.12
http://angular-ui.github.io/bootstrap/ Version: 0.11.0
Bootstrap v3.1.1
AngularJS v1.2.23
jQuery JavaScript Library v1.11.1

Closing due to inactivity. Please feel free to re-open once you've tested with the latest UI Bootstrap 0.13 and Angular JS 1.3 and can confirm this is still an issue.


Is there way to configure security.toml from docker-compose/run command?

Describe the bug
I want to configure JWT token and certificates for seaweed docker installation. And backup that configuration as part of docker-compose. Is there now any way to achieve this or i need to modify entrypoint.sh to generate security.toml from enviromental properties or code of seaweed itself.
System Setup
Ubuntu 18.04 + docker
seaweedfs 1.45

modify entrypoint.sh


Fast log append rejection

When leader sends append to a follower, follower may reject the messages. However, it only sets its own last index, so there is no way leader can find what's the conflict they have. So leader has to decrease the progress one by one and detect whether it's accepted by the follower. The progress can be very slow and wasteful if there are too many pending logs in the old leader, which is just recovered from a long isolation, because the logs need be sent over and over again.
I suggest to add a hint for the term of last index. If the new leader know the term of the follower's last index, it can jump to the last log in the given term directly and start replicated. So there will be just one round of RPC to figure out the conflict.
For example,
OL:<PHONE_NUMBER>333333333
NL: 124444444
The number is the term of the log. In the old implement, new leader has to decrease the progress one by one to walk through all the '4's. But if it can know that the term of OL's last index, it can jump to 2 directly, and starts replicate logs from 2.

They merge the code, https://github.com/etcd-io/etcd/pull/11964
I can redo this issue


Autocomplete special files, but don't generate previews for them, clean up stat-related code

Fixes #25
I am working on a follow-up PR where I make all filesystem calls asynchronous to compensate for calling fs_stat on every file.

I am working on a follow-up PR where I make all filesystem calls asynchronous to compensate for calling fs_stat on every file.

Ah well, in normal situations (<100 entries) making a bunch of asynchronous fs_stat requests is about 10 times slower than making them synchronously, on big directories (several thousand entries) the synchronous version is still faster, and it takes literally hundreds of thousands of files for the asynchronous version to become 20% faster than the sync one, but it also starts to randomly cause segmentation faults in Nvim (????).

Anyway, I'll merge this.
I think we can call fs_stat in resolve or execute time.


"Plătărești" is listed in the drop-down menu

Description:
"Plătărești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Plătărești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Plătărești, CĂLĂRAȘI (Plătărești)".


[Question or Bug] Extra Useless Tensor in grad_map

Hello!
I have noticed that here the grad is always size of 2, but only grad[0] is used and has value.
struct AddNode : public FunctionNode<AddNode>
{
    static std::vector<Tensor> backward(Context& ctx, std::vector<Tensor> grad)
    {
        auto grad_a = add_backward_impl(grad[0]);
        return grad_a;
    }
};

This is because grad_map[next_node].resize(num_inputs) and num_inputs is 2(for add node)
          grad_map[next_node].resize(next_node->num_inputs);
          grad_map[next_node][next->input_nr].AddInplace(next_gradients[next->input_nr]);

But I try to print the next->input_nr and find it that it is always 0.
It seems the input_nr comes from here when building edge, but since forward result size is always 1, so input_nr is always 0
        // Forward
        auto result = T::forward(node->context, t);

        // Set the edges of the output to point to this node
        for (int i = 0; i < result.size(); ++i)
        {
            result[i].SetEdge(std::make_shared<Edge>(node, i));
        }
        return result;

Here comes the problem

grad_map's tensor list normally has two Tensor, but only the first one is used, the other one is size 0.
assert add's backward input grad list's size == 1 will fail, since it has two values.

I am wondering if you could tell me is this a bug or not? If so, could you solve this problem?

Thanks for fixing the bug~


Fix home directory ownership so that podman 5.2.2 does not error

With the update of podman from 4.9.4 to 5.2.2 in UBI 9, podman fails to run if the ownership of $HOME/.config is incorrect.
This PR fixes that by moving the creation of $HOME and ${HOME}/.config/containers to the ENTRYPOINT.

@ibuziuk   I created https://github.com/devfile/developer-images/pull/198 which also includes logic to detect support for fuse-overlayfs.
It also contains the changes from this PR, so they can either be processed in series, or this one can be closed if favor of the newer one.

@cgruver should we close this PR in favour of - https://github.com/devfile/developer-images/pull/198 ?

@cgruver should we close this PR in favour of - #198 ?

Yes, #198 contains these changes as well.


SAK-49564 sitemanage. Moved template sites to top in replace

https://sakaiproject.atlassian.net/browse/SAK-49564

I've removed the accordions from the replace screen. They were added as part of the trinity work, but merge wasn't done at the same time. The accordions are clunky in my opinion, so I've removed them. Also, I've added hidden sites to the merge screen - they are currently only on the replace screen for some reason.


support clicking

How can I support clicking every text tab?

I needed to support clicking on the "participant" (nodes) and managed to extract it by doing the following:
// Getting all the available "participants" - could alternatively adjust to select notes, signals etc.
var actors = document.getElementsByClassName('actor');

// Making the first participant have an onClick event, could alternatively for loop
actors[0].style.cursor = 'pointer';
actors[0].onclick = () => {
 console.log(actors[0].textContents);
}

Hope this helps!


The operation of a neural network on a single board computer (Raspberry, Odroid etc.)

Hello, @sacmehta!
I've one more question.
Have you tried to run your neural network architecture on embedded platforms? Under the embedded platform, I mean Raspberry Pi, Orange Pi, Odroid and others. If so, what results did you get on the speed of work (FPS)? If you did not run, why? Do you think this neural network will work on these platforms? If so, how do I run ESPNet on such a platform?
At the moment, I managed to run ENet on a single-board Odroid computer, the speed of work was 3 FPS. I'm counting on the fact that your architecture will work faster. Thank you!

I have not tried running on these platforms, but any architecture should work.
Instead of using a PyTorch, you should use Caffe2 which is much more optimized. See below link for more details.
https://pytorch.org/tutorials/advanced/super_resolution_with_caffe2.html

I compiled Pytorch 0.3.0 on a single-board computer. When trying to start test of a neural network, an error occurs:
AssertionError: Torch not compiled with CUDA enabled
When I run test the gpu parameter was set to False.

@DenisN03 Seem you don’t use cuda pytorch


Fix getPath test for Windows

fixes issue #105

@GrapeBaBa  please review

@teohaik Good catch, thanks.


Repos Page v2

This PR introduces statistics into the repositories page. Build frequency still needs to be implemented, and has a placeholder value for the moment.

I've taken a look and spun this up locally @benmandrew - looks like you've got most of the parts in place and that this is still a WIP? I'm wondering this because I see that your onload javascript fetches data from an api controller but that you are not loading this js ... and instead are loading up data directly as part of the server generated page. Maybe this is left over from previous work and you have decided not to fetch information as json via an api route and instead just load the chart data in as part of the page?
btw I see some nan output locally

I wonder if it's possible to deploy this under a separate route that is not hooked up to the router so that we can "test in production." What do you think of that approach?

The new testing route is /:org/new. Please check the old repos page still works as it should as I slapped it together from the current master branch. I will now work on implementing the 'build frequency' column.

Thanks @benmandrew
I haven't had time to look at the code but I did run up the branch locally and can confirm that the new page shows up under the new route and that it does not have the nan issue anymore. I see N/A where I was seeing nanand I am seeing sensible numbers for build frequency.


Could not find org.litepal.android:core:1.4.1.

I got an error for my project. How to solve?
Execution failed for task ':app:checkDebugAarMetadata'.

Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
Could not find org.litepal.android:core:1.4.1.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/org/litepal/android/core/1.4.1/core-1.4.1.pom
- https://repo.maven.apache.org/maven2/org/litepal/android/core/1.4.1/core-1.4.1.pom
Required by:
project :app

Possible solution:

Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

1.4.1 is too old. and it's only released in jcenter
You should upgrade the litepal version
Note: jcenter will always provide read-only service. Don't worry


Docker Toolbox is not available anymore

Describe the bug
https://openthread.io/guides/border-router/docker#mac_or_windows has a link to Docker Toolbox (https://docs.docker.com/toolbox/) which now redirects users to https://docs.docker.com/desktop/. If the user then installs Docker Desktop and uses it, the RCP dongle mounted into the docker image is only a directory and ot-br-posix does not work.
Expected behavior
Either clearly document that Docker Mac and Windows does not work for now and direct users to installing ot-br-posix from source on Mac (Windows?) or find a way how it works with Docker Desktop.

Related to https://github.com/openthread/ot-br-posix/issues/1347.

Closing stale issue.


feat(options): option to include relation fields

closes #36

Tested on my end and it worked perfectly.

Can this get merged? Very nice to have 😄

Sorry for the delay! This looks awesome. Thanks again @jon-lewis.


kit: moved PositionEstimator, Navigation, and FlightController into GNC

@daniel-larraz , can you take a look at what I've done here? I made a modification to GNC. To make a more truthful “Guidance, Navigation, and Control” component I moved the Position Estimator, Navigation, and Flight Controller inside the GNC. With this change, we can then talk about interesting property settings: GNC having sensitive information such as waypoints, GNC being internally developed, GPS being hybrid, etc. Please let me know if that makes sense to you.

Hi @kityansiu. It seems a reasonable change to me. I just want to point out that the model you have modified (models/DeliveryDrone) is a little bit older than the one we used in the last demo (models/DeliveryDrone_CASE_v0/). This should not be a problem if you are just experimenting with MBAS. We can synchronize stories later if we decide to use it for a VERDICT demo.


Building on 32bit arch linux (gcc 4.4), build error

Hi, I tried to build but had the following error.

In file included from ../include/carve/pointset_decl.hpp:27,
                 from ../include/carve/pointset.hpp:22,
                 from intersect.cpp:23:
../include/carve/kd_node.hpp:115: error: default argument missing for
parameter 2 of 'bool carve::geom::kd_node<ndim, data_t, inserter_t,
aabb_calc_t>::split(carve::geom::axis_pos, inserter_t&)'
make[1]: *** [intersect.lo] Error 1
make[1]: Leaving directory `/root/Desktop/carve-1.0.0/lib'

I also needed to add "include <cstring>" to include/carve/matrix.hpp for an
earlier error but thats a no brainer.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 1 Jun 2009 at 2:10

Original comment by<EMAIL_ADDRESS>on 1 Jun 2009 at 11:16

Changed state: Fixed

fixed. the parameter default for parameter 1 was not required.

Original comment by<EMAIL_ADDRESS>on 1 Jun 2009 at 11:15


Add hostname config documentation

Adds documentation for the new APPSIGNAL_HOSTNAME env and config variable.

You should mention that this is available in 1.3 and up, this will be the next release.

@thijsc Should I mention that its next release in the documentation page? That would mean we'd have to update the page to remove that line once it's released. I prefer to only mention the version number.
And in what way should I mark it that it's available since version 1.3. It would be nice if it stood out from the rest. I wanted to use the notice, but it's a bit big for this.

maybe add it behind the config var? (since 1.3) ?

I'm okay with that

👍


Remove C API

I think it may be necessary for #59.
Note that because of transmute tricks #[repr(C)] has to stay to ensure stable representation.

@bors-servo r+

:pushpin: Commit 0c30e53 has been approved by SimonSapin

:hourglass: Testing commit 0c30e53c2e1b4130893025a34b6cbfbe792af968 with merge cd133fe5f626f870f19204fa2c5d2e4b5f1b0869...

:sunny: Test successful - checks-github
Approved by: SimonSapin
Pushing cd133fe5f626f870f19204fa2c5d2e4b5f1b0869 to master...


fixed bug for issue #47; renamed some test files

Codecov Report

Merging #48 (ee04f09) into master (8d69f18) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   77.21%   77.23%   +0.02%
==========================================
  Files           5        5
  Lines         926      927       +1
==========================================
+ Hits          715      716       +1
  Misses        211      211

Files Changed
Coverage Δ

src/grid/simple.jl
93.75% <100.00%> (+0.03%)
:arrow_up:


excessive load error , 503, again

I'm not sure if this is a bug
If you're not sure if it's a real bug or if it's just you, please open a topic on the forum: https://forum.magicmirror.builders/category/15/bug-hunt
I'm having troubles installing or configuring MagicMirror
Problems installing or configuring your MagicMirror? Check out: https://forum.magicmirror.builders/category/10/troubleshooting
I found a bug in the MagicMirror installer
If you are facing an issue or found a bug while trying to install MagicMirror via the installer please report it in the respective GitHub repository:
https://github.com/sdetweil/MagicMirror_scripts
I found a bug in the MagicMirror Docker image
If you are facing an issue or found a bug while running MagicMirror inside a Docker container please create an issue in the GitHub repository of the MagicMirror Docker image:
https://github.com/bastilimbach/docker-MagicMirror

I found a bug in MagicMirror
Please make sure to only submit reproducible issues. You can safely remove everything above the dividing line.
When submitting a new issue, please supply the following information:
Platform: Place your platform here... give us your web browser/Electron version and your hardware (Raspberry Pi 2/3, Windows, Mac, Linux, System V UNIX).
Node Version: Make sure it's version 8 or later.
MagicMirror Version: Please let us now which version of MagicMirror you are running. It can be found in the package.log file.
Description: Provide a detailed description about the issue and include specific details to help us understand the problem. Adding screenshots will help describing the problem.
Steps to Reproduce: List the step by step process to reproduce the issue.
Expected Results: Describe what you expected to see.
Actual Results: Describe what you actually saw.
Configuration: What does the used config.js file look like? Don't forget to remove any sensitive information!
Additional Notes: Provide any other relevant notes not previously mentioned. This is optional.

That's correct. Every Sunday around this time the server sends the weekly forum updates to the users who have this enabled.
It will take a few minutes and during that time the server could suffer from heavy load.
It should solve itself after a while.

should move those to some low usage time of day. after midnight maybe
On Sun, Jul 26, 2020, 10:46 AM Michael Teeuw<EMAIL_ADDRESS>wrote:

That's correct. Every Sunday around this time the server sends the weekly
forum updates to the users who have this enabled.
It will take a few minutes and during that time the server could suffer
from heavy load.
It should solve itself after a while.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MichMich/MagicMirror/issues/2099#issuecomment-664004185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALNYHQYARVUXIS6AOWYXI3R5RFU3ANCNFSM4PIBAE5A
.

That depends on the time zone where you are ... ;)

well, find the typical idle time and do it then. West coast USA, after midnight, would seem like a smaller population impacted. I need to go configure out of those. totally useless given my online time

Made some changes. Let's see how it goes next week. Closing this for now. Let me know if you run into issues.


Sklearn: validation set weights

In Sklearn wrapper, the option to train using using instance weights works OK. However, when evaluating performance metrics on validation sets, there was no option to use instance weights.

Note that this PR solves the previously posted issue https://github.com/dmlc/xgboost/issues/1804

requires rebase with master, feel free to reopen so it triggers a new PR

Codecov Report

Merging #2354 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2354      +/-   ##
============================================
+ Coverage     45.51%   45.69%   +0.17%
  Complexity      228      228
============================================
  Files           166      166
  Lines         12968    12972       +4
  Branches        466      466
============================================
+ Hits           5902     5927      +25
+ Misses         6874     6853      -21
  Partials        192      192

Impacted Files
Coverage Δ
Complexity Δ

python-package/xgboost/sklearn.py
87.36% <100%> (+8.87%)
0 <0> (ø)
:arrow_down:

python-package/xgboost/core.py
81.69% <0%> (+0.59%)
0% <0%> (ø)
:arrow_down:

python-package/xgboost/training.py
95.83% <0%> (+1.04%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e2261...00f28c2. Read the comment docs.


: add BCOS blockheader functions

Codecov Report

Merging #123 into dev will increase coverage by 1.24%.
The diff coverage is 50.81%.

@@             Coverage Diff              @@
##                dev     #123      +/-   ##
============================================
+ Coverage     31.10%   32.35%   +1.24%
- Complexity      372      400      +28
============================================
  Files            62       65       +3
  Lines          4848     5199     +351
  Branches        420      455      +35
============================================
+ Hits           1508     1682     +174
- Misses         3220     3383     +163
- Partials        120      134      +14

Impacted Files
Coverage Δ
Complexity Δ

...bank/wecross/stub/bcos/common/BCOSRequestType.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...bank/wecross/stub/bcos/web3j/Web3jWrapperImpl.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../webank/wecross/stub/bcos/verify/SM2Algorithm.java
37.90% <37.90%> (ø)
11.00 <11.00> (?)

...ebank/wecross/stub/bcos/config/BCOSStubConfig.java
93.61% <53.84%> (-6.39%)
15.00 <2.00> (+2.00)
:arrow_down:

...ecross/stub/bcos/verify/BlockHeaderValidation.java
64.70% <64.70%> (ø)
6.00 <6.00> (?)

...a/com/webank/wecross/stub/bcos/uaproof/Signer.java
75.47% <70.00%> (-2.08%)
2.00 <0.00> (ø)

.../java/com/webank/wecross/stub/bcos/BCOSDriver.java
21.05% <75.00%> (+0.26%)
34.00 <0.00> (ø)

...bank/wecross/stub/bcos/common/BCOSBlockHeader.java
77.77% <77.77%> (ø)
4.00 <4.00> (?)

...a/com/webank/wecross/stub/bcos/BCOSConnection.java
69.26% <100.00%> (+0.77%)
22.00 <0.00> (ø)

...ebank/wecross/stub/bcos/BCOSConnectionFactory.java
65.11% <100.00%> (+0.11%)
4.00 <0.00> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59601e5...57b3367. Read the comment docs.

Codecov Report

Merging #123 into dev will increase coverage by 1.18%.
The diff coverage is 50.13%.

@@             Coverage Diff              @@
##                dev     #123      +/-   ##
============================================
+ Coverage     31.10%   32.28%   +1.18%
- Complexity      372      400      +28
============================================
  Files            62       65       +3
  Lines          4848     5194     +346
  Branches        420      455      +35
============================================
+ Hits           1508     1677     +169
- Misses         3220     3383     +163
- Partials        120      134      +14

Impacted Files
Coverage Δ
Complexity Δ

...bank/wecross/stub/bcos/common/BCOSRequestType.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...bank/wecross/stub/bcos/web3j/Web3jWrapperImpl.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../webank/wecross/stub/bcos/verify/SM2Algorithm.java
36.62% <36.62%> (ø)
11.00 <11.00> (?)

...ebank/wecross/stub/bcos/config/BCOSStubConfig.java
93.61% <53.84%> (-6.39%)
15.00 <2.00> (+2.00)
:arrow_down:

...ecross/stub/bcos/verify/BlockHeaderValidation.java
64.70% <64.70%> (ø)
6.00 <6.00> (?)

...a/com/webank/wecross/stub/bcos/uaproof/Signer.java
75.47% <70.00%> (-2.08%)
2.00 <0.00> (ø)

.../java/com/webank/wecross/stub/bcos/BCOSDriver.java
21.05% <75.00%> (+0.26%)
34.00 <0.00> (ø)

...bank/wecross/stub/bcos/common/BCOSBlockHeader.java
77.77% <77.77%> (ø)
4.00 <4.00> (?)

...a/com/webank/wecross/stub/bcos/BCOSConnection.java
69.26% <100.00%> (+0.77%)
22.00 <0.00> (ø)

...ebank/wecross/stub/bcos/BCOSConnectionFactory.java
65.11% <100.00%> (+0.11%)
4.00 <0.00> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59601e5...75500e6. Read the comment docs.


gulp-esbuild notify error when run command line in vscode terminal macos

[22:57:07] Error in plugin "gulp-esbuild"
Message:
Build failed with 1 error:
error: Cannot read directory "../../../../..": operation not permitted
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hi!
Do you have an example to reproduce this problem?

it seems like an issue on your side. i suspect that you are trying to escape either / or /home/, not sure what mac will tell you if you do so, but make sure that your working directory allows you to do ../../../../.. (do pwd in vscode terminal and image where you will be after ../../../../.. and make sure that you have rights to be there).

Hi!
Do you have an example to reproduce this problem?

Hi!
Here is step by step, maby mighty9245 right, but I need to confirm about this my issue, if you're using macOS.

open vscode and direct to "gulp-esbuild > examples > mjs-gulpfile" project folder
install package node_modules and "npm run build" at vscode terminal, then you will git that issue.

it seems like an issue on your side. i suspect that you are trying to escape either / or /home/, not sure what mac will tell you if you do so, but make sure that your working directory allows you to do ../../../../.. (do pwd in vscode terminal and image where you will be after ../../../../.. and make sure that you have rights to be there).

maybe, but my os terminal is work fine. This issue only match in vscode terminal

Unfortunately I don't have macOS devices and I can't check it :(

Unfortunately I don't have macOS devices and I can't check it :(

never mind bro! I'll research on it, however please give me a suggestion if you have an idea. Cheers

never mind bro! I'll research on it, however please give me a suggestion if you have an idea. Cheers

I googled and found information about "operation not permitted" for terminal https://linuxbeast.com/tutorials/fixes/operation-not-permitted-using-terminal-on-visual-studio-code-in-macbook-pro/.
The author of the article added app to the Full Disk Access list.
Maybe you should do the same.

never mind bro! I'll research on it, however please give me a suggestion if you have an idea. Cheers

I googled and found information about "operation not permitted" for terminal https://linuxbeast.com/tutorials/fixes/operation-not-permitted-using-terminal-on-visual-studio-code-in-macbook-pro/.
The author of the article added app to the Full Disk Access list.
Maybe you should do the same.

Nice! I've fixed it, thks for your support


[Feature]: Add Magic wallet module

Is your request related to a problem?
No.
Feature Description
Add a built-in wallet module for the Magic wallet.
Alternative Solutions
The alternative is to implement a custom wallet module for Magic, but Onboard already supports Fortmatic, which is now Magic. It seems that a custom wallet module implementation would duplicate the work already done to support Fortmatic.
Anything else?
No response

@jacobkaufmann Thanks for the feature request! Would you be able to submit a PR to add the wallet? Otherwise we'll probably wait and integrate it into Onboard V2


[WIP] Adds basic containerization

Adds an initial hello world server and some of the building blocks for
containerization.  Dockerfiles, deployment, cronjob, etc as yaml files, and a
makefile for an easy build + deploy workflow.

@DirectXMan12 Will be grabbing some time to talk about this - I'm guessing theres a lot cleanup that can be done with the docker files and various yaml files.


Add simple recording demo

Add a simple demo to showcase only recording and playback functionality.

The current recordingDemo connects to the localhost backend. This should be the pilot environment like it's set in demo/settings.js, however that setting doesn't seem to be used..

Does it? The current settings.json has the pilot credentials and the connection is made by
  const config = {};
  config.apiUrl = settings.API_URL;
  config.wsUrl = settings.API_WS_URL;
  const connection = new its.Connection(config);

It gets a token from the pilot GAE.


Game crashes on startup

Describe the bug
When I try and load the game, it loads for a few seconds and then immediately crashes
Steps to reproduce

Start game
Wait a few seconds
Crash :(
...

Logs
https://pastebin.com/xSATcqwh
Additional context
Modlist is here:

Also important to note I am using Forge 1.20.1 47.1.3.

The provided log does not contain errors nor crash logs. Please upload your debug.log using a paste site.

Here's a debug log: https://pastebin.com/AUZFaPcK

have the same problem just cant make it work

Have you been able to figure out which mod is causing the crash? Unfortunately, the debug.log doesn't have any useful information either.

I tried running supplementaries and moonlight lib with FFAPI, but it all works fine for me. Do you have a log perhaps?

i have the same problem, i tried later versions of the mods but it still wont work

@JanikDerProfi and what mods are you using? Is it just FFAPI, Moonlightlib and Supplementaries?

I'm getting the same issue, and I have mostly the same mods.
https://pastebin.com/eqgX3i5m

That's the same crash as in #22

I'm getting the same issue

I'm getting the same issue

I dont think lazydfu works...

I'll be closing this as not enough details have been provided to reproduce the issue. When submitting issues, please make sure to provide a minimal list of mods that are required to reproduce the issue, rather than listing all mods you have installed, as that makes tracking down the issue difficult.


Beta.8 - Installation not removing previous version (Beta.7)

Seems like. after doing 'Update-Help -force' in previous version, it won't remove the previous folder because of the *HelpInfo.xml files.
Steps to reproduce
Open File Explorer and search inside the C:\Program Files\PowerShell\6.0.0-beta.7
Expected behavior
To remove previous version.

Actual behavior
Previous version folder is not removed.

Environment data
Windows 10 Insider Build 16299.15

PS C:\Program Files\PowerShell\6.0.0-beta.8> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-beta.8
PSEdition                      Core
GitCommitId                    v6.0.0-beta.8
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

If you did install-module (allusers scope) or update-help, it creates files in $PSHOME.  What we should probably do is migrate the modules folder to the new install so you don't have to reinstall those modules or re-update help.

Thanks @SteveL-MSFT!  I just didn't realized the Help xml to be an issue.  No worries!
:)

Please re-open if you think this is not resolved

@MaximoTrinidad @TravisEz13 I´m trying to understand why the  same issue would not re-occure when when going from 6.0.0 to 6.1.0.  as from the comments here no commit is linked. Maybe I'm just puzzled please bare with me-

@mi-hol ,
This is still happening even when upgrading to 6.1.0-preview.1 from the previous version.
In both Linux and Windows OS, the installation is still leaving the previous 6.x.x folder due to the xxx_HelpInfo.xml files in the main folder: C:\Program Files\PowerShell\6.x.. .
So, I ended up manually removing the previous version folders.
I think the installation should detect the older version, check for installed module (not core) and give the option to be remove.  It should be a clean installation.
:)

This is still happening even when upgrading to 6.1.0-preview.1 from the previous version.

6.1.0-preview.1 is an SxS install, not an upgrade.

In both Linux and Windows OS, the installation is still leaving the previous 6.x.x folder due to the xxx_HelpInfo.xml files in the main folder: C:\Program Files\PowerShell\6.x.. .

As mentioned, it is by design to leave the folder behind if the user has data left in the folder.  There was a change to update-help to save the help data in the user folder by default.

My Apologies!!!
I meant to say "Uninstalling" the previous version won't remove all folders, which I think it should cleared everything before installing the latest.
Sorry!
:)

Of course! If it is By-Designed!  Then, feel free to close this issue.
But, I still think is an unnecessary step to always go back and manually remove all folders. You will always be updating the help and reinstalling modules.
To me it doesn't make any sense.
:)

@MaximoTrinidad I think this should no longer be an issue after we implement this rfc

Aweesome @SteveL-MSFT !
Thanks
:)


Update the explainer

The name globalThis has been publicly discussed for two months, see https://groups.google.com/forum/#!topic/v8-users/Vkoh0wXRwaM . Can the explainer be updated to include the new name and rationale for choosing it?

Thanks for the quick fix!

There's one remaining occurrence of global in README; submitted #29.


Added unit tests for hooks module

This also seems reasonable to me, but @Stranger6667 is sat right next to me. ;) @sigmavirus24/@kennethreitz, mind doing an extra review for me? This is +1 from me.

Hello folks seems somehow I got placed on this email alias By mistake.
Anyway I can be removed.
Thank you
-Ryan
On Sun, Mar 13, 2016 at 7:24 AM Cory Benfield<EMAIL_ADDRESS>wrote:

This also seems reasonable to me, but @Stranger6667
https://github.com/Stranger6667 is sat right next to me. ;)
@sigmavirus24/@kennethreitz https://github.com/kennethreitz, mind doing
an extra review for me? This is +1 from me.
—
Reply to this email directly or view it on GitHub
https://github.com/kennethreitz/requests/pull/3049#issuecomment-195938314
.

@ryandebruyn This is managed by GitHub, it's not an email alias. You'll need to take some action to remove yourself via GitHub.

@ryandebruyn you may be "Watching" this repository in which case only you can fix that by visiting the project page while logged in and "un-watching" it.

Hello, @sigmavirus24 @Lukasa !
I've updated this PR :)

I have one small note. =)

@Stranger6667 I don't like having tons of pull requests open, so I'm merging this. If you wouldn't mind, it would be appreciated if you opened another PR that addresses the notes @Lukasa left on your test.


Reorganization of the repository layout

This PR resolves #7
Files were splitted by types, in src/scripts for Shell scripts, and in src/groovy for groovy scripts. Also, the configurations files were moved into the samples subfolder.
Documentation refined and updated accordingly.
A few minor bugs were also fixed along the way.

@M-DLB there are a couple of dead links on the README now due to the reorg. Getting a couple of 404's.

@M-DLB there are a couple of dead links on the README now due to the reorg. Getting a couple of 404's.

@dennis-behm Can you check again? All the links should be fixed now!


Custom tooltip color doesn't affect arrow color

Reproduction link
https://stackblitz.com/edit/angular-71ldqp?file=src%2Fapp%2Fapp.component.ts
Steps to reproduce
The "minimal reproduction" link refers to the examples on your official website. The four buttons below allow for customizing the tooltip colors. When you hover over them, you can see the tooltip display, along with the black arrow beneath the tooltip.
What is expected?
Expect the arrow color to be consistent with other customized colors, changing accordingly with the customized color.
What is actually happening?
The arrow color seems to remain the default black and does not respond to the customization of colors.

Environment
Info

ng-zorro-antd
17.0.1

Browser
Chrome

I attempted to use CSS to modify the arrow style, but the tooltip is created in the outermost div, making it impossible for me to change the arrow color within a single component. The changes I make seem to affect the entire global scope. Additionally, I examined ant-design 5.0, and it has successfully implemented the customization of tooltip colors, which leaves me puzzled as to why this functionality is not implemented in ng-zero.
I've checked the "chenc041:fix-issue-7639" branch, which indicates that the issue has been fixed. However, I am currently using the latest version of ng-zero, and the problem still persists. Moreover, the example is present in the official documentation, and the issue continues to exist.

I would like to work on this issue, if you agree, please assign it to me.

I would like to work on this issue, if you agree, please assign it to me.

Thank you for offering to help! I don't have the ability to assign issues. Hopefully, someone with the necessary permissions can assign this issue to you.

I hope this message finds you well.
Changes have been merged.
You should be able to see the requested change in the next release.
@alexmao1024


Problem following documentation installation instructions: grunt package

Hi,
I'm trying to get Angular built on a stock Ubuntu 14.04 server, and having trouble with the grunt package step (following the Angular Documentation's step-by-step here). It seems some node modules are not being installed correctly by the Angular npm/grunt scripts.
I modified node so it would install packages in ~/.node, so I didn't have to use the sudo command to use npm.

Aborted due to warnings.

All I can figure out is that node modules aren't in the right place; any additional insight or help fixing this would be appreciated.

Can you try running:
./scripts/npm/install-dependencies.sh

Gave up building Angular.

i have similar problem too!

Fixed by disabling the npm-reinstall task:
https://github.com/dmitriz/angular.js/commit/b4f12d848a2bc22dbec49d4cfc2c80200a946af0

Trying to build Angular on Windows is a joke. I've spent a whole weekend and can't get through the walkthrough here: https://docs.angularjs.org/misc/contribute. Is this an out-of-date document or is trying to develop on Windows a mistake?
Super frustrating.

@Narretz or @gkalpak  - any chance you could give @samscarsella some help here? Do we need to improve the contribute document? Do we still have issues with the npm cache thing?

We unfortunately never fixed the npm install task, so deleting node_modules still fails often I guess. Which steps exactly are causing problems @samscarsella

It seems like grunt package is the command that is giving me the most trouble, but I got some errors with bower install as well, where it was wanting different (earlier) versions than what was installed earlier with npm.

If bower is causing problems then it is best to completely clear out the app/bower_components folder before running anything.

Whatever the problem is/was, I made Yeoman figure it out for me. I'm up and running for now.. Thanks all.

@samscarsella，how？i think you want to build the docs. Yeoman, what does it do for building angular?

Yeoman has generators for building out a scaffolding for certain frameworks: http://yeoman.io/generators/

i think our problem domain is not the same thing. what you want is to scaffold an app structure for you to build an app, what i want is to compile the angular source code, run tests and generate docs. You asked a question in the wrong issue.


Menu dark mode.

I have a basic menu. I cannot actively activate the dark mode, but it can successfully respond to the system dark mode.
So can we actively activate the dark mode?

i'm planning on implementing this on a future version — i just need to finish a few things first before I can begin working on it ✨
I'll close this issue once I'm done adding it

Thanks for your excellent work!

Controlled dark mode would be awesome @dominicstop, thanks for working on it!

@nandorojo You can try using react-native-override-color-scheme

Looks like dark mode works now. And I think you can override it as of RN 0.72 with Appearance from react-native directly.


Spinner is not being removed from the terminal

I'm facing a problem using the pterm in our CLI, sometimes the spinner is not being removed from the terminal, as you can see below ("Getting plan...").
I've noticed that when we set "spinner.Success() or spinner.Fail()", it should clear the line in the terminal, but sometimes it doesn't work, apparently

Hi, this is the docs repo 😉
I'll move the issue to the main repo.


[Update] Facebook for iOS v4.38.0

@dalexsoto same process as always heh. Thanks, dude!

[ ] Facebook Account Kit
[ ] Facebook Core Kit
[ ] Facebook Login Kit
[ ] Facebook Share Kit

fixed #92 #94 #89


Refactoring http trace

I am refactoring this function to help future implementations, such as what was proposed in #295 .
This PR is following this recommendation: https://github.com/aws/aws-xray-sdk-go/pull/295#issuecomment-827692667
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks @bhautikpip!
I submitted the changes :)

@bhautikpip review again, pls


Feat: Enhance the look and hover effect of the Services cards

Describe the feature
The hover effect and the service cards looks simple , i would like to enhance the card and hover effect of it
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Could you assign this task to me

Sure @AbhiJay1287 please work on it

You can be assigned too @SanskrutiKulkarni if you made a PR faster than @AbhiJay1287 :)

Ok , plz assign , I'll try

Please do assign this task to me


Support batch runs

When running a large amount of queries to one call of CompassApp.run() it would be nice to optionally batch the queries and periodically write the results to a file rather than holding them in memory.

There are a couple of ways we could implement this.
We could expose a new function on the compass app that would split the queries into batches and then write them to an output file, something like:
def run_batch(self, queries, output_file: Path, batch_size: Optional[int]):
   # compute batches

   for batch in batches:
    batch_result = self.run(batch)
    # write batch_result to file

Or, we could implement this functionality in rust and pass the output_file and batch_size parameters there.
I'm thinking it makes more sense to implement this in our python wrapper.

Thinking about this a bit more, the python implementation would be easier but it wouldn't be guaranteed to run the queries in the specified batch since since it's possible for the grid search plugin (or any other plugin) to generate multiple queries from a single query. Perhaps this is good justification to implement batching on the rust side?

Continued discussion in #19

hey, sorry i missed/duplicated this issue!


ODataService created invalid filter expressions

https://github.com/wertzui/RESTworld/blob/88afe490682e9b6cb5b9782fdc3e67cd7ea8393c/src/RESTworld/RESTworld.Client.Angular/projects/ngx-restworld-client/src/lib/services/o-data.service.ts#L19
Is:
        return `${oDataOperator}(${property}, ${comparisonValue})`;
      default:
        return `${property} ${oDataOperator} ${comparisonValue}`;

Should be:
        return `${oDataOperator}(${property.name}, ${comparisonValue})`;
      default:
        return `${property.name} ${oDataOperator} ${comparisonValue}`;

This has been fixed with version 8.0.0


can't open new tab when open tab from search

Workaround, as always, is to Ctrl + Click, but agreed this would be a really nice place for the feature to live in search results, rather than just file explorer

+1


The default of canonifyurls = true got reversed silently since v0.11

See discussion starting at http://discuss.gohugo.io/t/deployment-workflow/90/15
The current behavior found in v0.11, v0.12 and v0.13-DEV as of today, i.e. canonifyurls = false by default, is the exact the opposite of Hugo v0.10 and before, and of what is documented in http://gohugo.io/extras/urls.
So, assuming the "default reversal" isn't intentional, we need to do the following:

Investigate which exact commit caused this bug, this "default reversal".

Fix the source code to revert to the correct behaviour, i.e. canonifyurls = true by default.

Add a warning to http://gohugo.io/extras/urls (and a few other relevant places in the documentations) that v0.11 and v0.12 had buggy behaviour, recommending the end user to upgrade or to specify canonifyurls manually to obtain the desired behaviour.

git blame is nice:
62dd1d45
But I like this default, and there will be breaking changes with pre 1.0 versions.

@bjornerik, you are awesome!  I haven't started looking yet, but I suspect I would have looked in the wrong place.  :-D
I must say I like the new default (i.e. canonifyUrl = false) too; the only problem was that the change was undocumented.
@spf13, I must ask you again.  :-)  Is the change to canonifyUrl = false in Hugo v0.11 intentional?  Or was it an oversight?  Which way we fix this issue depends on your decision.  (Either way is fine with me.)  :-)

Wait, I forgot, it is not fixed yet.  Need to wait for @spf13 insight and decision on what the future default should be.  :-)

@spf13 true or false?

I believe it was intentional. There's a much higher probability that I intentionally switched it and forgot to document it.  I also think it's the better default and should continue to be the case going forward.

@spf13, Thanks for your clarification!  I guess the only thing left to do then is to make minor to the docs so the users know that the new default is the way to go now and in the future.  Will do that soon.

@anthonyfok it could also be good to mention the new hugo config command. hugo config | grep -i canon is a pattern I will start to use.

@bep Great point about hugo config!


Correction for raw affiliation Lyon 2 - LADEC

Correction needed for raw affiliation Lyon 2 - LADEC
raw_affiliation_name: Lyon 2 - LADEC
new_rors: 00pbrnp49;000q6dn27
previous_rors: 00pbrnp49
works_examples: W3095776786
contact: 603c47d04a26d025b83d359c56b1b2b8:ee7fcc7bd90d0ed2a3e8615fbe16 @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Use AAD guest accounts

Please is it planned to support AAD guest accounts in future ? There is customer requirement - they need to allow access their B2B partner to access WVD published applications. This users are invited to customer AAD.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2eeca14-80ef-c0b4-2719-80ceb286ba3d
Version Independent ID: b7d3df23-3158-2807-eecc-73e7230c2033
Content: What is Windows Virtual Desktop?  - Azure
Content Source: articles/virtual-desktop/overview.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@jjindrich Thanks for the feedback. We are actively investigating and will get back to you soon.

@jjindrich this is a bit outside the scope of what we would know from a doc perspective. That being said, I see you are an FTE, if you want ping me offline I can provide you with some resources you can check with related to road map for WVD.

@jjindrich should we understand we can't use AAD guest accounts with WVD for the time being?

Correct, you cannot use external accounts.

Any update on this?


Borrow notatition from nameless variable binding, while presenting using nameful aproach

Discussed in https://github.com/ppolesiuk/type-systems-notes/discussions/38

Originally posted by ppolesiuk October 23, 2023
As pointed out in #28, we can use some notations borrowed from nameless approach of Sec. 1.3, but in "nameful" setting. We can write $\gamma^*$ for simultaneous substitution, $γ \triangleleft_x v$ for extending substitutions, and $γ^{\Uparrow_x}$ to extend substitution $γ$ with dummy mapping for $x$.  Actually we've done it during the last lecture and in the notes in the proof of lambda compatibility (Lemma 4.8 in 16d1e21). I think it is a bit non-standard, but worth considering, since it narrows the gap between formalization and informal reasoning, but it leaves the informal reasoning in a traditional style (with a slightly different notation). If we decide to follow this path, we could add a new section in Chapter 1, that introduces notations used throughout the notes.
What do you think? As this is rather controversial change, I expect some critique (positive or negative) before making any step in that direction.
We decided on the following notations:

use $γ^*$ as a simultaneous substitution in traditional setting;
use standard $γ[x↦v]$ in traditional setting;
change $v ◃ γ$ to $γ[↦v]$ in a nameless setting to mimic standard notation $γ[x ↦ v]$;
do not use $γ^{⇑_x}$ in traditional setting, as it trivialize to identity operation (assuming Barendregt convention).

Most of the work is done. It remains to write Sec. 1.4.


Setting Default Browser for React Native Webview

Description
Need to set Microsoft Edge as default browser for React Native Webview
Version
0.68.2
Output of npx react-native info
N/A
Steps to reproduce
N/A
Snack, code example, screenshot, or link to a repository
N/A

for React Native Webview

Please open this issue against: https://github.com/react-native-webview/react-native-webview


untag_resource support in secretsmanager

Thanks for creating such a great library!
It would be great if there was support  for untagging resources in secretsmanager - I'll go ahead and make a PR.

This is now part of moto >= 2.0.2.dev9


Edit run name feature added.

ref #61
imported commits from #86

This change is

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.

angular_scripts.js, line 374 [r2] (raw file):
The implementation here doesn't match the angular style used in the rest of the code. In particular I expect that instead of using innerHtml we will show or hide parts of the template based on the state, and use classes to define any required style rather than direct DOM manipulation.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.

edit_icon.png, line 0 [r4] (raw file):
This looks like a material icon. I would advise using an SVG over PNG. They render better, and kinder on the CPU too i think. An SVG will surely be available from where this PNG was downloaded

index.html, line 30 [r4] (raw file):
Mouse cursor should change to a hand pointer when hovering. Else it won't look like its clickable.

Comments from Reviewable

ng-keypress and  https://docs.angularjs.org/guide/forms#custom-validation

@martiansideofthemoon Do you want to implement a custom validation form for checking if the run name already exists?
And ng-keypress for detecting the Return or Esc keys?

@arpan98 yes to both


Tests.asserMatchesMask skips repeated fields

Here's the code:
    public static void assertMatchesMask(Message message, FieldMask fieldMask) {
        List<String> paths = fieldMask.getPathsList();

        for (Descriptors.FieldDescriptor field : message.getDescriptorForType()
                                                        .getFields()) {
            if (field.isRepeated()) {
                continue;
            }
            assertEquals(message.hasField(field), paths.contains(field.getFullName()));
        }
    }

Why do we skip repeated fields? They may be desired for both exclusion and inclusion when returning queries.
If we do need to skip repeated fields for a good reason, it should be documented.
Please also test the method.

Done in #250.


BUG Ensure root path of any local adapter is safely created and mapped from symlink

Fixes https://github.com/silverstripe/silverstripe-asset-admin/issues/362

I would like @robbieaverill to please confirm this fixes his issue before merging.

Updated based on further exploration.


Implement R6 version of split

@ccotter Heads up, I rebased this PR to fix the test failure with nvc++.

@ccotter The other authors didn't like the split sender inheriting the input sender's environment. I've reverted that change and will merge as soon as tests finish.
Thanks for your work on this!

Thanks! Sounds good, I think that makes sense as well. Interestingly, the original desire for split to be able to forward sender queries was one of the motivations for introducing sender environments.

I can take a look at ensure_started next, although I wonder if it'll need a similar treatment with respect to the environment returned by the returned sender?


fotorama plugin not works fine with popup

Hi
I would like to use fotorama plugin.
I want to use this plugin in my index page and in my popup page.
this plugin works fine on two places, but when I open my popup page,thumbs of images on index page will be removed:
see this site:
http://www.shadyab.com/ali/
fotorama on index page work fine:
http://i.stack.imgur.com/6c8a1.jpg
click on eye icon to open new popup:
http://i.stack.imgur.com/WMTp0.jpg
fotorama on popup page work fine but after loaded popup, fotorama on index page will be removed !
http://i.stack.imgur.com/4II3y.jpg

Hi, @smemamian
here can be few problems
Please check your config, check your layout, problem can be if it display: none while gallery try to init. Problem not in gallery likely. Problem how you use it. If problem actual, please write<EMAIL_ADDRESS>I will help you.


Add the start screen for contact us

Description
TODO
Deployment url
http://add-contact-us-screen.review.ensembl.org

@azangru I've pushed the code after adding the contact overview section content to ContactUs. Styling doesn't seem to be right, so I'll fix that tomorrow.


ScikitLearn support

Hi, I'm looking for algorithms to add to ScikitLearn.jl. Would you be interested in supporting the interface? I can make a PR for it. Are you going to update this package when 0.5 lands?

Hi there!
I'm definitely interested in adding support for some interfaces other than the bare-bones one I've provided. My intention with this package was to provide the model layer and wait and see how the community approaches interfaces.
However, I'm hesitant to add any dependencies at this point in time. I'm kind of waiting on JuliaLang/julia#15705. If there's a way to optionally support ScikitLearn.jl without adding any dependencies, I'm all for it.
As for updating the package for 0.5, yes definitely. I'm actually working on a rewrite on part of the back end right now that I hope to merge with master in a couple days.

However, I'm hesitant to add any dependencies at this point in time.

That's why I split the library between a "full-featured package", ScikitLearn.jl, and an "interface-definition package", ScikitLearnBase.jl. The latter contains one short file and no dependencies. It's the one that I REQUIRE in all the libraries I've supported so far.
There's also Requires.jl. I like the above better, but @require works too.

This PR is a good example. I had to add some functionality for computing conditional probabilities so it's longer than it would be for this package.

Sorry for the slow replies. I took a look through your packages - this is great work! It's nice to see progress in this area. Anyway, ScikitLearnBase is pretty lightweight, so we can just add that as a requirement.
I've made some small changes to the  qda!, cda! and lda! functions (layer below exported interface). Past that it's a major rewrite of many functions. I'll be merging that in a day or two with master.... I'm just finishing up on qda! which isn't fully tested. Regroup in a couple days?

Sure! I wouldn't have time this week anyway.
On Fri, Apr 29, 2016 at 9:29 AM, Tim Thatcher<EMAIL_ADDRESS>wrote:

Sorry for the slow replies. I took a look through your packages - this is
great work! It's nice to see progress in this area. Anyway, ScikitLearnBase
is pretty lightweight, so we can just add that as a requirement.
I've made some small changes to the qda!, cda! and lda! functions (layer
below exported interface). Past that it's a major rewrite of many
functions. I'll be merging that in a day or two with master.... I'm just
finishing up on qda! which isn't fully tested. Regroup in a couple days?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/trthatcher/DiscriminantAnalysis.jl/issues/4#issuecomment-215711242

Still interested in this? If you intend to support this package in Julia 0.6, I can make a PR for ScikitLearnBase support. I'd create new types (eg. LDAClassifier) that work on top of your current code, so there would be no modification of your code.


Get all positive and negative examples

First of all, thank you for your great library.
I think the function "query" in the class Tester should return a list instead of a set cause the set only contains the first positive and negative example.
However, I don't get your result in both cases.
Test example
`settings = Settings(kbpath='examples/trains1')
prog, score, stats = learn_solution(settings)
if prog != None:
print_prog_score(prog, score)
else:
print('NO SOLUTION')
Before
class Tester():
def query(self, query, key):
return set(next(self.prolog.query(query))[key])
Num. pos examples: 1
Num. neg examples: 1
SOLUTION
Precision:1.00 Recall:1.00 TP:1 FN:0 TN:1 FP:0 Size:4
f(A):- has_car(A,C), has_load(C,B), three_load(B).
After
class Tester():
def query(self, query, key):
return list(next(self.prolog.query(query))[key])
Num. pos examples: 394
Num. neg examples: 606
SOLUTION
Precision:1.00 Recall:1.00 TP:394 FN:0 TN:606 FP:0 Size:4
f(A):- has_car(A,B), three_wheels(B), roof_closed(B).

I cannot replicate this bug. Can you confirm that you installed pyswip from the master branch with the command pip install git+https://github.com/yuce/pyswip@master#egg=pyswip?
Can you also confirm the version of Prolog that you are using?

pip install git+https://github.com/yuce/pyswip@master#egg=pyswip fixed the issue.
I used pip install pyswip before and thought that this is the main branch, too.
Thank you very much for the fast reply.


[gamepad-controls] don't copy camera rotation, copy camera rig rotation instead

This closes #394
It doesn't make sense to me to copy the rotation from camera to the camera rig. That's why we have the issue that the camera jumps when first touching the joystick (first issue), and second issue it jumps again if some other component modified the camera rig rotation because it wasn't copied before doing the calculation.
My guess is that code was written/thought when we didn't use camera rig, if movement-controls and camera with look-controls was on the same entity, the code made sense. That's not the case today.
I may have overlooked something, so if someone can review that and test it, I'll appreciate it.
Changes proposed:

Remove rotation copy from look-controls and remove camera from the component properties
Copy camera rig rotation before doing the rotation calculation

You can test with the build of this PR:
<EMAIL_ADDRESS>I tested with the Quest joysticks only.

You can reproduce the first issue if you have rotation="0 90 0" on camera rig for example.
You can reproduce the second issue if you change dynamically camera rig rotation to something else rotation="0 0 0" or rotation="0 -90 0" for example.

Oh I see that previously the code changed the camera rotation, not the camera rig rotation. The behavior changed in https://github.com/n5ro/aframe-extras/pull/373/files#diff-87251e16fae2ca8e4158c45c3374b3446d1f0a9546f2cfac67a43f416163b623
but I believe the changes in this previous PR were correct. You can't really change camera rotation in VR right? This get overridden right away by your real head rotation.

I rebased since I merged another fix.
You can test with the build of this PR:
<EMAIL_ADDRESS>I'll merge those changes in a few days if I don't have any feedback.


[KeyVault] KeyVaultClient not mockable

The KeyVaultClient is the central class for interaction with the KeyVault.
For testing purposes it is the optimal place to mock responses, since I do not want to test the azure sdk.
Unfortunately this class is final. First for a good reason if you see is as a programming API. Second it makes nice testing hard/impossible.
Please trust developers using your SDK.
Cannot mock/spy class com.microsoft.azure.keyvault.KeyVaultClient
Mockito cannot mock/spy because :
 - final class

@jianghaolu this needs to be moved to the new KeyVault client repo

@schaabs @joshfree @JonathanGiles Do you know if the track 2 KeyVault client is mockable? If it is, we can close this?

@g2vinay

@schaabs @joshfree @JonathanGiles Do you know if the track 2 KeyVault client is mockable? If it is, we can close this?

@Petermarcu, @joshfree , @JonathanGiles, @schaabs
Our Client classes (Secret, Keys, Certificates) are final in Track 2 as well.
So, Mockito by default should still throw this error when user tries to mock the clients.
But, Mockito 2 supports mocking final classes.
it can be done via the mockito extension mechanism by creating the file src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker containing a single line:
mock-maker-inline
Power Mockito supports mocking final and static classes by default without any extra config like above.