Using flutter_quill with integration_test is not possible

Imo, integration_test is a very basic flutter sdk dev dependency. Is there a way to relax the platform dependency of the flutter_quill package, so that flutter_quill at least works together with basic flutter sdk dependencies?
The problem: Every project with an integration_test dependency fails with a dependency conflict:
pubspec.yaml
...

environment:
  sdk: ">=3.0.0 <4.0.0"
  flutter: ">=3.10.0"

...

dependencies:
  flutter_quill: ^8.1.3

...

dev_dependencies:
  flutter_test:
    sdk: flutter

  integration_test:
    sdk: flutter

...

flutter pub get Output:
Resolving dependencies... (1.4s)
Note: platform is pinned to version 3.1.0 by flutter_driver from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

Because every version of integration_test from sdk depends on flutter_driver
  from sdk which depends on platform 3.1.0, every version of integration_test
  from sdk requires platform 3.1.0.
And because flutter_quill >=7.4.12 depends on platform ^3.1.3,
  integration_test from sdk is incompatible with flutter_quill >=7.4.12.
So, because project_name depends on both flutter_quill ^8.1.3 and
  integration_test from sdk, version solving failed.

Thank you for the report. I will checkout soon

I'm getting this as well
Note: platform is pinned to version 3.1.0 by flutter_driver from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

Because every version of integration_test from sdk depends on flutter_driver from sdk which depends on platform 3.1.0, every version of integration_test from sdk requires platform 3.1.0.
And because flutter_quill 8.1.5 depends on platform ^3.1.3 and no versions of flutter_quill match >8.1.5 <9.0.0, integration_test from sdk is incompatible with flutter_quill ^8.1.5.
So, because squabbit depends on both flutter_quill ^8.1.5 and integration_test from sdk, version solving failed.

I'm getting this as well
Note: platform is pinned to version 3.1.0 by flutter_driver from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

Because every version of integration_test from sdk depends on flutter_driver from sdk which depends on platform 3.1.0, every version of integration_test from sdk requires platform 3.1.0.
And because flutter_quill 8.1.5 depends on platform ^3.1.3 and no versions of flutter_quill match >8.1.5 <9.0.0, integration_test from sdk is incompatible with flutter_quill ^8.1.5.
So, because squabbit depends on both flutter_quill ^8.1.5 and integration_test from sdk, version solving failed.

It's easy to fix. We will make the minimum version to 3.1.0 instead of 3.1.3
We will update it soon.

Please let me know if you still facing the issue in version 8.1.6
if you have any other questions feel free to ask.

Wow, thank you so much for the fast reply! Did you put out a new version already? How long does it normally take for it to become available? I'm getting the error:
Because <my-app> depends on flutter_quill ^8.1.6 which doesn't match any versions, version solving failed.

Wow, thank you so much for the fast reply! Did you put out a new version already? How long does it normally take for it to become available? I'm getting the error:
Because <my-app> depends on flutter_quill ^8.1.6 which doesn't match any versions, version solving failed.

Thanks, but there's no need to thank me, I'm the one who cause this error anyway
About that error, it will get fixed as soon as @singerdmx publish the new version to pub.dev
Meanwhile, use git in pubspec.yaml to get the flutter_quill package
Please take a look at README.MD
in the installation section

@singerdmx We are not using the platform package anywhere in the project?? then why we need it?? is it safier to delete it??

Go ahead delete it

Wow, thank you so much for the fast reply! Did you put out a new version already? How long does it normally take for it to become available? I'm getting the error:
Because <my-app> depends on flutter_quill ^8.1.6 which doesn't match any versions, version solving failed.

You can run flutter pub get now, the 8.1.6 just got published
Please let me know if the issue is fixed

Awesome, looks like it's working now. Thanks again!

Awesome, looks like it's working now. Thanks again!

You are welcome

Imo, integration_test is a very basic flutter sdk dev dependency. Is there a way to relax the platform dependency of the flutter_quill package, so that flutter_quill at least works together with basic flutter sdk dependencies?
The problem: Every project with an integration_test dependency fails with a dependency conflict:
pubspec.yaml
...

environment:
  sdk: ">=3.0.0 <4.0.0"
  flutter: ">=3.10.0"

...

dependencies:
  flutter_quill: ^8.1.3

...

dev_dependencies:
  flutter_test:
    sdk: flutter

  integration_test:
    sdk: flutter

...

flutter pub get Output:
Resolving dependencies... (1.4s)
Note: platform is pinned to version 3.1.0 by flutter_driver from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

Because every version of integration_test from sdk depends on flutter_driver
  from sdk which depends on platform 3.1.0, every version of integration_test
  from sdk requires platform 3.1.0.
And because flutter_quill >=7.4.12 depends on platform ^3.1.3,
  integration_test from sdk is incompatible with flutter_quill >=7.4.12.
So, because project_name depends on both flutter_quill ^8.1.3 and
  integration_test from sdk, version solving failed.

You can try out the new version since the issue is now fixed.
If you have any other questions feel free to ask us


darwin.linuxBuilder: Fix working directory in documentation

This fixes the working directory for the launchctl service configuration that is mentioned in the documentation, as caught by @MaxDaten in:
https://github.com/NixOS/nixpkgs/issues/229542#issuecomment-1674886874

The working directory is inherited by all child process, so whatever is invoked by the script may accidentally use /etc/nix. Not ideal, but could be acceptable as I don't know the implications of the alternative, which is to pass more paths explicitly. Would that be a breaking change?
If not, I'd prefer for this to use explicit arguments instead of inherited "globals" like working directory or the process environment.

Just found by luck this handy nix-darwin module:
https://github.com/LnL7/nix-darwin/blob/426d38710b656b0a31f8eaae6e0002206a3b96d7/modules/nix/linux-builder.nix#L82
Not sure about the state of this module, maybe still work in progress, but it's configuring WorkingDirectory = "/var/lib/darwin-builder";. Without directly using the module I just adopted the WorkingDirectory setting. Also worked for me without any problems. Even without the acticationScript & mkdir -p /var/lib/darwin-builder although this would probably be the cleaner solution.
Just want to point to it. Thanks for taking care

After having a look again at the create-builder script, it looks like I missed the virtualisation.darwin-builder.workingDirectory option:
https://github.com/NixOS/nixpkgs/blob/f4c11b80885cbb150f98056d68c813179ca0d31b/nixos/modules/profiles/macos-builder.nix#L61-L64
https://github.com/NixOS/nixpkgs/blob/f4c11b80885cbb150f98056d68c813179ca0d31b/nixos/modules/profiles/macos-builder.nix#L144-L149
Seems like instead of setting the WorkingDirectory in the launchd daemon, we should set virtualisation.darwin-builder.workingDirectory

Alright, I believe I've addressed all review feedback


fix(deps): :arrow_up: update dependency vega-lite to v5.14.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

vega-lite (source)
5.13.0 -> 5.14.0

Release Notes

vega/vega-lite (vega-lite)
v5.14.0
Compare Source
Bug Fixes

escape Quotes in tooltip title (#9019) (f7f7735)

Features

Improve color scheme type (#9015) (d535812)

v5.13.0
Compare Source
Features

support domainRaw so one may bind domainRaw to a parameter to build custom interaction (#8989) (21c823d)

v5.12.0
Compare Source
Features

support pre-binned timeUnit (#8971) (dac5c19)

5.11.1 (2023-06-26)
Bug Fixes

show gridline of first axis only for dual axes charts (#8962) (a522a87)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^17.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/material
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   2 more (@angular/platform-browser, @ngneat/spectator)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-07-23T01_08_44_071Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-07-23T01_08_44_071Z-debug-0.log


Is manual installation of CUDA Toolkit (11.8) required?

Hi there,
I did a fresh installation of Ubuntu and tried running some examples from TheBloke's models.
Most of the time I get "CUDA Extension not installed." when running the Python script.
I'm not using docker, just a local dev PC with fresh Ubuntu.
I would like to double confirm:

Is manual installation of CUDA Toolkit required?
Or I can just use the cuda from pytorch in my venv?

I checked nvidia-smi & nvtop, both my GPUs are fully utilised when inferencing. But it shows "CUDA Extension not installed." everytime.
I also followed TheBloke's comment to install AutoGPTQ from source (below snippet) and it gives "CUDA_HOME" environment issue.
pip3 uninstall -y auto-gptq
git clone https://github.com/PanQiWei/AutoGPTQ
cd AutoGPTQ
pip3 install .
Thanks.

I think "CUDA Extension not installed." from here
build autogptq_cuda_64 and autogptq_cuda_256 requires nvcc ... so cuda from torch may be not enough

I think "CUDA Extension not installed." from here
build autogptq_cuda_64 and autogptq_cuda_256 requires nvcc ... so cuda from torch may be not enough

Thanks. I properly installed CUDA toolkit & cuDNN and it worked. "CUDA extension not installed" has disappeared.
My only problem right now was the "revision" parameter still not working even with the latest build from source.
The runtime cuda from torch will not be enough. The module most likely used my CPU for inference instead, both my GPUs VRAM consumption was still full hence I was confused. Properly setting up everything had lowered my inference time from 5 minutes => 5 seconds.
This is my installation for anyone with similar issue, hope it helps.

nvidia-driver-535
CUDA toolkit 11.8 & cuDNN version is 11.x
Pytorch stable build with CUDA 11.8
autogptq build from source


Feature/flake8

What type of PR is this? (check all applicable)

[x] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[x] Yes
[ ] No, because:

Have you updated all relevant documentation?

[ ] Yes
[ ] No
[x] N/A

Description
As per my suggestions here https://github.com/invoke-ai/InvokeAI/discussions/3721
I am adding flake8 checks to GHA, to pre-commit hooks and also cleaning up flake8 issues.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

@lillekemiker I'm watching the conflicts build up. Are you planning to re-run flake8 on current main and update the PR?

@lillekemiker I'm watching the conflicts build up. Are you planning to re-run flake8 on current main and update the PR?

So flake8 only finds the errors, I have to correct them myself, unfortunately. But I don't mind.
@psychedelicious mentioned a couple of PRs that he wanted merged before this one, so I was mostly waiting for a go-ahead there. I forget which ones they were.
That being said, I can start addressing conflicts now so there are less when we are ready.

@lillekemiker Ah, right - those have merged and the path is clear for this PR :)

@psychedelicious @lstein - This should be ready merge as soon as the tests clear (which they already have locally)


Fix for WiFi SSID or Passwords with special characters

Fixes how sed RegExp is created when changing WiFi Password:  Escape the newPass and newName  first before appending it into the sed RegExp.
Change-Id: Ia7de1b28677d26f20246c3f76bdedf0e889d106a

Note: This also fixes setting the SSID to one with special chars (which are apparently valid)


Contact you

Can you give me your discord please i want private plugin

https://discord.gg/uwBf2jS


Add iOS pipeline

(1) Build is added
(2)  Test Running option is added

Added branch https://github.com/SzymonSmykala/MyToDoList/tree/Add-iOS-pipeline


Fix environment not be honored when args is null

The classic optional parameter mess. If args is null, options will be ignored.

I would appreciate a bugfix release, by the way.

@KalitaAlexey Please take a look!

@ishitatsuyuki,
I don't know what is this for?

The environment variables weren't set for the following config:
    "rust.rls": {
        "executable": "rls"
    },

but works with:
    "rust.rls": {
        "executable": "rls",
        "args": []
    },

Sorry I don't understand you.
Could you check if your problem exists in the master branch?


Model Program/Instance RDF/XML ingestion

Describe the feature you'd like and what it will do
Model Program and Instance currently do not support ingestion from the rdf/xml to the django models.
Why is this feature important?
This is needed for the models to be used in hsclient.  It is also needed for the file based aggregation work for model program/instance types.
Is your feature request related to a problem? Please describe.
no

Bags have been regenerated.
https://new-hs-ci.hydroshare.org/view/02-Deployment/job/Production-Deployment/job/prod-hsctl-command/167/console


Agda-like editor support for devising proofs interactively

Writing proof terms solely by inspecting error messages is a pain. Being able to print the types of things in context (#219) would already be helpful. Being able to additionally write terms with "holes" and see the types of these holes would be even better. In the long term we could aim for something like the wonderful Agda Emacs Mode:
http://wiki.portal.chalmers.se/agda/pmwiki.php?n=Main.QuickGuideToEditingTypeCheckingAndCompilingAgdaCode
Update: could also look at Idris editor: https://www.itu.dk/people/drc/pubs/dtp2014-idris-mode.pdf

Related: https://github.com/FStarLang/FStar/pull/940
Agda mode is nice, but it's essentially structured editing: things work as long as the whole document parses. I'm not too fond of that idea.  It'd be much nicer if F* could robustly recover from parsing errors, and give interesting information even for partial terms.

Lots of work on fstar-mode.el.
We also have a wiki page discussing how we might add support for holes and other related features:
https://github.com/FStarLang/FStar/wiki/Towards-a-Finer-grained-Incremental-Typechecker-for-F*
Closing this issue.


AVX support patch

Dear MKL DNN developers,
Would you be interested in reviewing a patch which adds AVX support to convolution forward scoring?
With this patch on AVX machines, we see about 70-80% CPU utilization in single thread with 1x1 convolutions, and about 90% with regular convolutions.
Thank you,
Evgueni.

Hi Evgueni. Yes, we would. Please submit a PR.

Dear Evgueni-Petrov,
I am very interested in your AVX patch.
Could I please review the source code.
@Evgueni-Petrov-aka-espetrov
Thank you,
Daejin Jung

Hi Daejin,
I hope to submit a PR by the end of this week.
E.

Dear Evgueni-Petrov,
Thank you and I look forward to hearing from you.
Daejin Jung.

It's been a while... closing as old. Please reopen or just post a PR.


When you exit the angry pods then FPS counter is still visible

See screesnhot in the lower left corner. Maybe that FPS counter should be in the preference so you can turn it on|off, and leave it off by default?

@gashcrumb I noticed this still is the case.

@davsclaus because I haven't fixed it yet :-)

yay, tracked down how to turn it off, don't think we really need a preference item for it :-)


Create dataset loader for Indo4B Plus

https://indonlp.github.io/nusa-catalogue/card.html?indo4b_plus

#self-assign


Replace DockerUI with portainer.io

DockerUI is no longer maintained. It has now shifted to portainer.io.

DockerUI repo is depreciated and is no longer maintained. It has now been shifted to the new repo that I have provided.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines

The project submitted is conform to the quality standards outlined in the contribution guidelines

Go to the contribution guidelines and read it again.

Thanks @vik-y for the update! Can we have a short note that portainer.io is the continuation of UI for Docker (a.k.a DockerUI), so anybody realize the deprecation?

@agebhar1 I have added the note.


[Excel] (PivotTables) Add new PivotFilter article section

This PR:

Adds a new "Filter with PivotFilters" article section and series of code samples
Adds an introductory "Filter a PivotTable" article section, to encompass both slicers and PivotFilters

Note to reviewers: I think the introductory "Filter a PivotTable" paragraph should include another sentence about the benefits of PivotFilters vs. slicers, but I'm not sure what to note as the most compelling PivotFilter feature. Open to suggestions!

Docs Build status updates of commit 40492fd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:warning:Warning
View
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md

Line 17, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#slicers' in 'excel/excel-add-ins-pivottables.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f0b5634:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:warning:Warning
View
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md

Line 17, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#slicers' in 'excel/excel-add-ins-pivottables.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit fac5a1e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:warning:Warning
View
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md

Line 17, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#slicers' in 'excel/excel-add-ins-pivottables.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 39c884d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:warning:Warning
View
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md

Line 17, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#slicers' in 'excel/excel-add-ins-pivottables.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 39c884d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:warning:Warning
View
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md

Line 17, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#slicers' in 'excel/excel-add-ins-pivottables.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit adefc6b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:warning:Warning
View
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md

Line 17, Column 3: [Warning-bookmark-not-found] Cannot find bookmark '#slicers' in 'excel/excel-add-ins-pivottables.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 9e2d07e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ef53999:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f2b71ce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 10caf4d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7042ffd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d5dd992:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1bba76c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3014019:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8a536b1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8cc3d7c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3c2ebf9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e5bd996:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 010b30c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Rick-Kirkham Could you take a look specifically at line 289 in docs/excel/excel-add-ins-pivottables.md? Thank you!

@Rick-Kirkham Could you take a look specifically at line 289 in docs/excel/excel-add-ins-pivottables.md? Thank you!

That line is:

[!NOTE]
The three subsequent code snippets only display filter-specific excerpts, instead of full Excel.run calls.

Is this the line you are asking me about?  I would replace "three subsequent" with "following three".

Yes, that's the line @Rick-Kirkham. Thank you for the reviews, @AlexJerabek and Ricky!

Docs Build status updates of commit 3ed9ccf:
:clock10: Pending: waiting for processors (10 builds ahead of you)
:warning: Docs Build is busy, currently there are 10 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 3ed9ccf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@AlexJerabek Could you take another quick look? I incorporated the plural PivotFilters feedback and want to make sure I got it right. Specifically, your most recent suggestion offered "PivotFilters" as an option, but I used "PivotFilter" (singular, since in context it's referring to a single filter type). Thanks!

Docs Build status updates of commit 900fafb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d798869:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/excel-api-1-10-requirement-set.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Special cases in enum values fails to generate unique enum keys

Describe the bug
Some Edge-cases can lead to duplicate keys in enums. Given the schema:
{ "enum": ["test plus", "test+"] }

It would generate the enum output
export enum X {
  TEST_PLUS = "test plus",
  TEST_PLUS = "test+"
}

Proposed solution
After generation check the generated keys and add the index on duplicates.
Proposed output:
export enum X {
  TEST_PLUS_0 = "test plus",
  TEST_PLUS_1 = "test+"
}

This can still lead to duplicates in other edge cases.
{ "enum": ["test plus", "test+", "test plus 0"] }

export enum X {
  TEST_PLUS_0 = "test plus",
  TEST_PLUS_1 = "test+",
  TEST_PLUS_0 = "test plus 0",
}

This could be applied iteratively until there are no more duplicates to ensure a valid ts output in all cases.
{ "enum": ["test plus", "test+", "test plus 0"] }

export enum X {
  TEST_PLUS_0_0 = "test plus",
  TEST_PLUS_1 = "test+",
  TEST_PLUS_0_1 = "test plus 0",
}

Another option could be to use random numbers or UUIDs. Then the result would be different on each render which is not a good option i guess.
Related
Issue #450 (Some discussion on how naming in enums should work), PR #497

Definitely, a "problem" that we should solve. Not sure I like the index approach, as it is rather hard to know from a user standpoint what is what. In my mind, the key that is most notably changed i.e. test+, needs to make sure it has no conflicts, it is not the others that have to adapt.
In your example:
{ "enum": ["test plus", "test+", "test plus 0"] }

My first assumption is that the keys for the enums are the ones that most accurately represent their value. I.e. the two entries are straightforward and should not be tampered with:
export enum X {
  TEST_PLUS = "test plus",
  TEST_PLUS_0 = "test plus 0"
}

The last entry, because we alter its key from TEST+ to TEST_PLUS it is up to this key to fit within the existing entries.
I.e. generate something like TEST_PLUS_RESERVED, and continue to do this until no conflicts are found.
What do you think about this approach? 🤔

This would be a nicer approach.
It would require a more complex implementation as we need to determine the priority of the keywords.
As this is an edge case I would also consider it valid to just go for the simplest solution available to provide valid output in all cases even if it is suboptimal for these edge cases.
Probably everything else is just overengineering?

What about just throwing an error in case there are duplicate keys when rendering the enum?
It's kind of "fail-fast", not too complex to implement and will "solve" all possible edge cases.
You just have to ensure that the message is descriptive enough to point to the offending key in the api definition (and also the fact that a potential normalization has happened)

What about just throwing an error in case there are duplicate keys when rendering the enum?

That could also be an option 🤔
This scenario is only triggered because we constrain the keys to the language, and in that case, we might end up with duplicate keys. Failing the generation, because something we did not handle correctly, is bad UX 😅 Cause it is not the user of the library that did something wrong.

This should already be solved in the next branch.


Improve e2e screenshot stability

Two issues in this PR with screenshots:

Some screenshots are showing visual diff when there are small pixel changes
When some screenshots are taken, the cursor may be on top of a tooltip, showing it as part of the screenshot

Goal is to make sure that screenshots are only committed when there are visual diffs (as much as possible)

Also we might need to wait for the transition to end for :

tooltip & modal after detached
button after enabled


[Security] How Kerckhoff's Principle is Applied in Cryptography.

[Security] How Kerckhoff's Principle is Applied in Cryptography.
How Kerckhoff's Principle is Applied in Cryptography.
Kerckhoff's state that a cryptographic system should be secure even if everything about the system except the key is publicly known
According to Kerckhoff's Principle, a cryptographic system's security is solely dependent on the secrecy of its keys, and everything else, including the algorithm itself, should be regarded public knowledge.
Key takeaways

Understand the state principle of kerckhoff's principle
Get to know the origin of kerckhoff's principle
Have an understanding on various fundamental principles of crypto system
The relationship between Kerckhoff's principle and Shannon's Maxim principle
Difference between kerckhoff's principle and Security by Obsecurity

Article quality
This article aims to explain how to develop secure systems with this kerckhoff's principle which is not covered in most article
References
kerckhoff's principle

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Hello @WanjaMIKE  following the available documentation that has already covered Kerckhoff's principle my article will differ with it in that  it will cover..
the  understanding on various fundamental principles of crypto system explained by the Kerckhoff's principle ,
the difference between Kerckhoff's principle and Security by Ob-security and I am aiming at writing a simplified article and easy to understand by any individual.

Okay. Topic approved. Let's ensure that it adds value to the community. Thanks


TIM-126 feat(search): add search result

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#73  👈
#72
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xdjeremy and the rest of your teammates on  Graphite


[CARBONDATA-3149]Support alter table column rename

Why this PR?
This PR is to support column rename feature in carbondata. Carbon already supports datatype change, alter table add column and drop column. This PR uses same DDL as datatype change and supports the column rename.
Any column canbe renamed, since the same DDL is used for rename adn datatype change, both operation can be done together, during that case, the datatupe change validation and limitation remains the same as before
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
Existing alter datatype change DDL is used for column rename also
Example:
ALTER TABLE table_name CHANGE [COLUMN] col_old_name col_new_name column_type;
Alter table t1 CHANGE column1 newcolumn1 String

[x] Any backward compatibility impacted?
NA

[x] Document update required?
Will be done in new PR

[x] Testing done
added UT and tested in cluster
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1974/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10022/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1766/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1981/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10028/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1784/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1785/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1787/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1789/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1999/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10047/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2002/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10057/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2009/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1802/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2012/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10061/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1813/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10072/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2023/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1825/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2034/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10084/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1842/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2050/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10099/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1846/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2054/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1850/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10105/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2058/

@manishgupta88 handled comments, please review

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1853/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10108/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2061/

@manishgupta88 handled, please review

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1867/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1868/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10123/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2076/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1871/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2080/

LGTM

@akashrn5 : plz get LGTM from Likun too

@jackylk handled comments, please review

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1879/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1880/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10135/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2090/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1883/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2092/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10138/

LGTM. Thanks for working on this

@jackylk thank you


[SPARK-40978][SQL] Migrate failAnalysis() w/o a context onto error classes

What changes were proposed in this pull request?
In the PR, I propose to migrate failAnalysis() errors without a context onto temporary error classes with the prefix _LEGACY_ERROR_TEMP_24xx. The error message will not include the error classes, so, in this way we will preserve the existing behaviour.
Why are the changes needed?
The migration on temporary error classes allows to gather statistics about errors and detect most popular error classes. After that we could prioritise the work on migration.
The new error class name prefix _LEGACY_ERROR_TEMP_ proposed here kind of marks the error as developer-facing, not user-facing. Developers can still get the error class programmatically via the SparkThrowable interface, so that they can build error infra with it. End users won't see the error class in the message. This allows us to do the error migration very quickly, and we can refine the error classes and mark them as user-facing later (naming them properly, adding tests, etc.).
Does this PR introduce any user-facing change?
No. The error messages should be almost the same by default.
How was this patch tested?
By running the affected test suites:
$ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"

@cloud-fan @srielau @itholic @LuciferYang @panbingkun Could you review this PR, please.

Merging to master. Thank you, @LuciferYang @cloud-fan for review.


fix .scss errors and sass mixins added.

Hi there!
This pull request only fix scss errors, besides add border-radius and transform mixins for scss.
[]

Thanks @marcio
Checkout #30 and This commit, I think no need to merge this pull request for now. Thakns again. :)


Some way to see what things would match a character

sorted by uniqueness
the idea is that once the user finds “á”, ne should be able to answer the question “how do I best enter “á” in future?”

Maybe just make it another column?


Cop idea: prefer argument forwarding syntax

Is your feature request related to a problem? Please describe.
Since Ruby 2.7, we will be able to use ... to forward arguments to another method.
# 2.6
def foo(*args, &block)
  bar(*args, &block)
end

# 2.7
def foo(...)
  bar(...)
end

I think the ... syntax has two advantages.
First, we can simply avoid keyword parameter warnings with ... syntax.
For example
# with Ruby 2.7

def bar(*args, a: 1, &block)
  p [args, a]
end

# It displays the warning.
def foo(*args, &block)
  bar(*args, &block)
end
foo 1, 2, a: 1

# It displays no warning, but it is a bit of long.
undef foo
def foo(*args, **kwargs, &block)
  bar(*args, **kwargs, &block)
end
foo 1, 2, a: 1

# No warning, and short!
undef foo
def foo(...)
  bar(...)
end

foo 1, 2, a: 1

Second, we can avoid missing &block forwarding with ... syntax.
I guess many people forget passing &block to the forwarded method unexpectedly.
But we can avoid the problem with ... syntax.
Describe the solution you'd like
Add an offense for the following code.
# We can replace the parameter with `...`.
# It can avoid the warning.
# It does not change the behavior at least Ruby 2.7.
# The behavior will be changed in the future.
def foo(*args, &block)
  bar(*args, &block)
end

# We can replace the parameter with `...`.
# The behaviors are completely the same in all Rubies.
# So it is cosmetic change only.
def foo(*args, **kwargs, &block)
  bar(*args, **kwargs, &block)
end

# We can replace the parameter with `...`, but it will change the behavior.
# Because `...` forwards block also.
def foo(*args)
  bar(*args)
end

The last example changes the method behavior actually, so probably we should add Strict option to disable/enable replacing the last case.
Describe alternatives you've considered
nothing
Additional context
nothing

That's a great idea and we should totally implement such a cop!


[Infrastructure] Update readme with information about VF# vs FCS status

I think we should add information to the readme that this is downstream, read-only repository that exists only to have separate documentation and NuGet package. And that all bug reports, feature requests, and pull requests should be done to VF# repo.

Yes please do
This repo also has "the Fable cross-compile PR", which should likely be a fork.

I'll leave the PR to @baronfel - it will be easier to write it once, nicely by the native speaker then fixing all my language mistakes ;-)
Just to sum up what should be there more or less:

Downstream from MSFT/VF#
Read-only
Hosting documentation
Publishing NuGet package
Base for Fable PR
All development happening in MSFT/VF#
You can build latest FCS from MSFT/VF#
All issues and feature request should be reported in MSFT/VF#

Closing as we did this a while back.


Em support

I think I have fixed the EM support.  Here is what I have done:

Updated all media queries to accurate EMs based on a 16px default font-size on browser.
Updated regex to allow for decimals in the min/max-width declarations
Changed the eminpx calculations to find the offsetWidth of a DIV with width: 1em
Cleaned up the code which converted ems to pxs
Changed the styles for P tags to use EM based width

Tested in IE7, IE8
Sorry for all the commits... I was switching back and forth between master and em-support... should have stashed my changes instead of committing them.  Let me know what you think.

I tested this on IE8, and it works perfectly.

Just getting to this now, I'll check it out and get back to you shortly, hopefully with a merge! :)

All rolled into the em-support branch now and updated. Thanks for the great work. I'm closing this out and we'll look to roll it into master asap!


502 BadGateway

After updating my raspiblitz to the newest version of LNDG I get an Bad Gateway nginx message on my normal browser and tor browser. My nginx logs looking normal.

502 usually means that uwsgi or gunicorn is not running properly. Try to check on the status and logs for this service.

Thank u. I restarted the services and everything works fine.


Color not enabled when in a Node Worker

This is related to an ongoing issue/discussion in Node.js related to process.stdout and process.stderr not having isTTY === true when in a Node.js Worker thread.
This means that, if debug is used within a Worker thread, it does not print colors nor ms diff (but timestamps).
Code to reproduce it (requires Node >= 12 or Node 10 with node --experimental-worker flag):
foo.js:
process.env.DEBUG = '*';

const { Worker, parentPort, threadId, isMainThread } = require('worker_threads');
const tty = require('tty');
const debug = require('debug');

async function run()
{
	if (isMainThread)
	{
		const logger = debug('[parent]');

		logger(
			'run() in main thread [process.stderr.isTTY:%s, tty.isatty():%s]',
			process.stderr.isTTY,
			tty.isatty(process.stderr.fd));

		const worker = new Worker(__filename);

		worker.once('message', message => logger('message from child: %o', message));
		worker.postMessage('hi child!');
	}
	else
	{
		const logger = debug('[child]');

		logger(
			'run() in child thread [process.stderr.isTTY:%s, tty.isatty():%s]',
			process.stderr.isTTY,
			tty.isatty(process.stderr.fd));

		parentPort.once('message', message => logger('message from parent: %o', message));
		parentPort.postMessage('hi dad!');
	}
}

run();

Output:
$ node --experimental-worker foo.js

  [parent] run() in main thread [process.stderr.isTTY:true, tty.isatty():true] +0ms
2020-01-12T15:22:36.083Z [child] run() in child thread [process.stderr.isTTY:undefined, tty.isatty():false]
  [parent] message from child: 'hi dad!' +33ms
2020-01-12T15:22:36.085Z [child] message from parent: 'hi child!'

Of course it works if I set DEBUG_COLORS=true environment variable. Just wondering if a debug instance may expose a method to set "tty" mode.

Just wondering if a debug instance may expose a method to set "tty" mode.

This is an anti-pattern, debug isn't meant to be used like this. I'd say this is a fringe case and Node should fix it on their end, not here.

The problem is that this may not even be "fixed" in Node. From the referenced issue:

IMO it make sense for .isTTY to be undefined because process.stdout and process.stderr in worker threads don't actually write to the TTY. They postMessage() the data to the main thread which then writes it out on the worker thread's behalf.
We could copy the .isTTY values from the main thread but that breaks the idiom where if (process.stdout.isTTY) guards are used around calls to process.stdout.setRawMode(true) or process.stdout.cursorTo() - and you can't reasonably support those APIs in worker threads because the TTY is a per-process resource.

I'd be happy by just manually setting process.stderr.isTTY = true in the Worker thread. However this won't make debug module produce colors since it looks at tty.isatty().
And another super ugly workaround is (in the top of the app):
// before loading debug and before creating Workers that also use debug.

const tty = require('tty');
if (tty.isatty(process.stderr.fd)) {
  process.env.DEBUG_COLORS = 'true';
}

Why not just set your main process's environment variable to DEBUG_COLORS from outside your application? debug isn't meant to be a general purpose logging framework. It's meant to be used as an internal, switchable, runtime-configurable debug output module.

Right now I do NOT need to set DEBUG_COLORS. If logging to stdout, debug will produce colors (unless in Workers). If logging to a file or Docker, it won't produce colors. That's great.
So instead of setting DEBUG_COLORS externally, I must do the above hack to make colors work in Workers.

Not really sure how to fix this elegantly, honestly. You have a very specific use-case where you want threads to include colors but Node is not properly forwarding the correct signals to tell the threads they can safely output escape codes. This isn't something debug can solve in a safe, general way - especially since the Node team has states they don't care to forward the isatty results to the worker threads.
Your "hack" is not a workaround for debug, but instead for node. This is their incompatibility, not ours.

I 100% agree this is a bug in Node, I know that. And I do not even understand their rationale to not forward the isTTY value to Workers.

Your "hack" is not a workaround for debug, but instead for node.

Right.

I understand their reasoning, I just think it's a weak reason. They created a tight coupling between the environment and their code and they don't seem to want to fix it.
However, the blame isn't entirely on them. TTYs are some of the last remaining truly archaic software mechanisms still in prominent use today. I call them "archaic" because they were built in a time of serial lines, baud rates, parallel ports and dialup. The reason why your terminal is called a "terminal emulator" is because they were originally made to emulate old real terminal machines like the VT100.
Since then, not much has been done to change this in order to maintain compatibility with old systems running other, equally archaic software. Unix is a huge culprit behind this. It also leaves maintainers of TTY-related software with their hands a bit tied.

Thanks for the explanation.


Do not allow bombs to increment when max bombs at 0

I am working on an AP feature to allow you to start your max bombs at 0. This requires some changes to the base rom as otherwise you can acquire 99 bombs when the max is set to 0.

I backported the bomb logic from KatDevsGames repo.
https://github.com/wesclemens/z3randomizer/tree/feat/archipelago/bomb_bag

Added in a fix to prevent spending last heart


Fixed spelling errors

also, added chokidar to devDependencies

hey @myNameArnav really appreciate your contribution. Can you make a seperate issue and then make a pr.

hey @myNameArnav really appreciate your contribution. Can you make a seperate issue and then make a pr.

just did that, https://github.com/TheNinza/dsa-visualizer/issues/8

Looks good. Merging


/p clear crash

Link to crashdump:
https://pastebin.ubuntu.com/p/wDZM5WWQk5/

Additional comments (optional)
do /p clear more times

Use the latest Myplot Version!

which one
mine is not that outdated
I'm using 1.7.0 which is the 'latest'

1 7.1 is the latest version.
Check it on Poggit

ok they need to update plugin.yml


kind test failed in noEncap cluster with case: TestFlowAggregator

Describe the bug
After I changed antrea.yaml to use noEncap mode in a PR, I triggered kind test, and hit the following error in case TestFlowAggregator.
--- FAIL: TestFlowAggregator (222.52s)
    --- FAIL: TestFlowAggregator/IPv4 (180.47s)
        --- FAIL: TestFlowAggregator/IPv4/IntraNodeFlows (18.92s)
        --- FAIL: TestFlowAggregator/IPv4/IntraNodeDenyConnIngressANP (9.02s)
        --- FAIL: TestFlowAggregator/IPv4/IntraNodeDenyConnEgressANP (8.95s)
        --- FAIL: TestFlowAggregator/IPv4/IntraNodeDenyConnNP (11.00s)
        --- FAIL: TestFlowAggregator/IPv4/InterNodeFlows (129.56s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

To Reproduce
Change antrea.yaml to use noEncap mode, and run kind test in hybrid mode.
Expected
Test succeeds.
Actual behavior
Test failed with panic errors.
Versions:
Antrea 1.2
Here is a link for the error: https://github.com/antrea-io/antrea/pull/2702/checks?check_run_id=3523571257

Change antrea.yaml to use noEncap mode, and run kind test in hybrid mode.

Confused by above statement. To run the kind test in hybrid mode, don't we need to generate the manifest using hybrid mode? Is that a typo or am I missing something?

Here is a link for the error: https://github.com/antrea-io/antrea/pull/2702/checks?check_run_id=3523571257

This link is not correct. By looking in previous runs on the same PR, I was able to find the kind tests failure in hybrid.
https://github.com/antrea-io/antrea/runs/3523571452?check_suite_focus=true
Looking at error logs, there are continuous test failures  prior to running Flow Aggregator test. Therefore, it does not look like its a Flow Aggregator test issue. From the error, it seems like a cluster issue.
=== RUN   TestPodConnectivityDifferentNodes
Error:     connectivity_test.go:54: Ping mesh test between all Pods
Error:     connectivity_test.go:61: Ping 'connectivity-test-8b6jd' -> 'connectivity-test-jm89w': ERROR (error when running ping command 'ping -c 5 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr: )
Error:     connectivity_test.go:61: Ping 'connectivity-test-jm89w' -> 'connectivity-test-8b6jd': ERROR (error when running ping command 'ping -c 5 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr: )
Error:     fixtures.go:239: Exporting test logs to '/home/runner/work/antrea/antrea/log/TestPodConnectivityDifferentNodes/beforeTeardown.Sep06-10-51-53'
Error:     fixtures.go:364: Deleting 'antrea-test' K8s Namespace
--- FAIL: TestPodConnectivityDifferentNodes (84.64s)
=== RUN   TestPodConnectivityAfterAntreaRestart
Error:     connectivity_test.go:54: Ping mesh test between all Pods
Error:     connectivity_test.go:61: Ping 'connectivity-test-dv66c' -> 'connectivity-test-g2w5w': ERROR (error when running ping command 'ping -c 5 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr: )
Error:     connectivity_test.go:61: Ping 'connectivity-test-g2w5w' -> 'connectivity-test-dv66c': ERROR (error when running ping command 'ping -c 5 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr: )
Error:     fixtures.go:239: Exporting test logs to '/home/runner/work/antrea/antrea/log/TestPodConnectivityAfterAntreaRestart/beforeRedploy.Sep06-10-53-13'

Error:     connectivity_test.go:54: Ping mesh test between all Pods
Error:     connectivity_test.go:61: Ping 'connectivity-test-dv66c' -> 'connectivity-test-g2w5w': ERROR (error when running ping command 'ping -c 5 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes

        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr: )
Error:     connectivity_test.go:61: Ping 'connectivity-test-g2w5w' -> 'connectivity-test-dv66c': ERROR (error when running ping command 'ping -c 5 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr: )
Error:     fixtures.go:239: Exporting test logs to '/home/runner/work/antrea/antrea/log/TestPodConnectivityAfterAntreaRestart/beforeTeardown.Sep06-10-55-00'
Error:     fixtures.go:364: Deleting 'antrea-test' K8s Namespace
--- FAIL: TestPodConnectivityAfterAntreaRestart (186.43s)
=== RUN   TestOVSRestartSameNode
Error:     fixtures.go:39: Skipping test for the 'kind' provider: test not valid for the netdev datapath type
--- SKIP: TestOVSRestartSameNode (0.00s)
=== RUN   TestOVSFlowReplay
Error:     fixtures.go:39: Skipping test for the 'kind' provider: stopping OVS daemons create connectivity issues
--- SKIP: TestOVSFlowReplay (0.00s)
=== RUN   TestPingLargeMTU
Error:     connectivity_test.go:477: error when running ping command 'ping -c 5 -s 2000 -4 <IP_ADDRESS>': command terminated with exit code 1 - stdout: PING <IP_ADDRESS> (<IP_ADDRESS>): 2000 data bytes

        --- <IP_ADDRESS> ping statistics ---
        5 packets transmitted, 0 packets received, 100% packet loss
         - stderr:
Error:     fixtures.go:239: Exporting test logs to '/home/runner/work/antrea/antrea/log/TestPingLargeMTU/beforeTeardown.Sep06-10-56-06'
Error:     fixtures.go:364: Deleting 'antrea-test' K8s Namespace
--- FAIL: TestPingLargeMTU (66.47s)

@wenyingd Please redo the initial triaging again and if you still think its a Flow Aggregator. Let us know why.


URLs are not supported in production public_path due to leading slash

Hello! Loving webpack-rails, really has been a game changer getting our code migrated away from sprockets.
We deliver our assets from a CDN, so it makes sense for us to define config.webpack.public_path = '//cdn.url.com/assets/webpack'. The problem with this is that manifest.rb always adds a slash before the public path.
Weirdly, the resulting URLs (like "///sub.domain.com/assets/webpack/app.js") work in most browsers, but not all! In IE11 and other old browsers, the public path gets parsed incorrectly, prevent the assets from being loaded.
A workaround is removing one (but not both) of the leading slashes on our CDN url. But this is pretty weird. Is there another way to tell webpack to load assets from another domain?

 If you can think of a way to solve this without making our configuration more complex than it already is, submit a PR or suggestion.

Cool. I'll take a look soon. I think that doing some simple checks on Rails.configuration.webpack.public_path would be sufficient:
is_url = Rails.configuration.webpack.public_path =~ /^(https?:)\/\//
# Add slash unless is_url

We also use CDN for our frontend assets but do not configure webpack with any of it. Instead, we rely on the rails assets host to be configured properly. I think that should suffice for your case as well.


Add form answer state machine.

Initial implementation of the application state machine.
All transitions are permitted for now as flow is not sorted yet.
Transition triggers need to be added in appropriate places.
States are grouped with indices which represents the phase (based on documentation).
My thinking is to use it for filtering purposes first and then add the transitions triggers to relevant places.
Transitions table stores all historical data.

Looks clear for me :+1:

@dreamfall any notes?

@RuslanHamidullin I'm not 100% sure about the number of states. Seems kind of complex.


gradle issue

Error:A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugCompile'.
Could not find com.android.support:appcompat-v7:22.0.0.
Searched in the following locations:
https://jcenter.bintray.com/com/android/support/appcompat-v7/22.0.0/appcompat-v7-22.0.0.pom
https://jcenter.bintray.com/com/android/support/appcompat-v7/22.0.0/appcompat-v7-22.0.0.jar

It looks like the current version of appcompat is 'com.android.support:appcompat-v7:21.0.3'

got a message to update sdk in android studio. I'm still using v7:21.0.3, but it's working now.

The current version is 22, everything was updated when API 22 was released. They're in the SDK manager.


[readme] (tutorial) Make GitHub repository the source of truth for tutorials

A quick fix to move the source of truth for the tutorials to the GitHub repository: this way we avoid the sharing issues as well as we make sure that the content of the "tutorial" folder is in line with the links in the README.
Tell me what you think about it :)

thank you! certainly an improvement and much welcome change. I think we should link to stable instead of master though so that when users use the tutorials and they install the pip packages , then they will have right code expectations corresponding to the stable tag. (simply replace master with stable in the links and also verify the stable links work)
thoughts?

thank you! certainly an improvement and much welcome change. I think we should link to stable instead of master though so that when users use the tutorials and they install the pip packages , then they will have right code expectations corresponding to the stable tag. (simply replace master with stable in the links and also verify the stable links work)
thoughts?

I think you just point to a very important issue: we need to make sure that the version associated to a branch are the ones pointed by that branch:

on the master, it should link to the master
on the v0.1.5, it should link to this version

I need to think about how to do this.

To be addressed later (we first need to give the rights to all tutorials as we discussed)


Collapse / Expand All doesn't work with mouse input

In lists (Like the scene window list of nodes or the Create New Node window) Alt + Left Cursor key collapses all the nodes and their children and Alt + Right Cursor key expands the whole hierarchy of the children.
But Alt + mouse clicks do not replicate the same behavior. When working with such UI items one tends to use the mouse so the behavior should be the same with mouse input and Alt key should be a modifier to the mouse clicks also.

#19936 was merged a bit late to fix this I guess, I wasn't aware of Alt + Left/Right feature, maybe because it wasn't present at the moment I started working on it or simply not documented. It also uses Shift for this instead. 🤔

@ssoher  Can you (or anyone else) still reproduce this bug in Godot 3.2.2 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

It currently doesn't work in 3.2.3 with Alt being pressed (works with keyboard arrows). Only Shift works as implemented in #19936. Perhaps this could be remapped to Alt if that's a big deal. 😮

@Xrayez I guess you could make it so it works with both Alt or Shift, just in case.

@Calinou you previously mentioned that Ctrl is also common in other software: https://github.com/godotengine/godot/pull/19936#issuecomment-505522374. Perhaps we could handle all the modifiers, just in case? 😃

I got curious how currently Alt works as described in OP.
https://github.com/godotengine/godot/blob/45d0799b5b4a62f7764c0b9e318a9d1547c7083b/scene/gui/tree.cpp#L2188-L2194
So yeah... All that was needed is simply adding the logic directly to Tree input handling to support mouse input (mainly talking about #19936). But given solutions must be local, it's no big deal after all!
Also CC @FeatherAntennae to be aware of this possibly hidden feature, in relation to #33984.

CTRL or SHIFT won't interfere directly if clicking on the arrow, but I recommend against using them for this. Some software do use them, but it's generally not seen as a good practice as it conflicts with the multi-select functionality which is also standard in a list.
People trying to select many things using Shift or CTRL, especially if trying to go as fast as possible, might accidentally hit the arrow, collapsing everything recursively. This could be a bit frustrating on big lists.
In #36926 I went with ALT, because it doesn't interfere with anything and it's kind of this key's purpose to alter or to give an alternative function! ^^

Scene tree already supports this, with Shift+Click.


Deduplicate macro adds additional "with: clause, fails with a cte

Describe the bug
The deduplicate macro adds a "with" clause, making it not work a cte, i.e., when there is already a with clause in the file.
Steps to reproduce
A basic cte and then deduplicate (silly example):
with my_cte as (
    select 1 as user_id
)

{{ dbt_utils.deduplicate(
    relation='my_cte',
    partition_by='user_id',
    order_by='user_id desc',
   )
}}

Compiles to
with my_cte as (
    select 1 as user_id
)

with row_numbered as (
        select
            _inner.*,
            row_number() over (
                partition by user_id
                order by user_id desc
            ) as rn
        from my_cte as _inner
    )

    select
        distinct data.*
    from my_cte as data

    natural join row_numbered
    where row_numbered.rn = 1

Expected results
The macro to work also with a cte, i.e., when there is already a with clause in the file.
Screenshots and log output
Compiler error for the above:
Server error: Runtime Error in rpc request (from remote system)
('42000', "[42000] [Simba][Hardy] (80) Syntax or semantic analysis error thrown in server while executing query. Error message from server: org.apache.hive.service.cli.HiveSQLException: Error running query: [PARSE_SYNTAX_ERROR] org.apache.spark.sql.catalyst.parser.ParseException: \n[PARSE_SYNTAX_ERROR] Syntax error at or near 'with'(line 5, pos 0)\n\n== SQL ==\nwith my_cte as (\n select 1 as us (80) (SQLExecDirectW)")

System information
Which database are you using dbt with?
databricks with dbt cloud v<IP_ADDRESS>
Additional context
"with" statement is in:
https://github.com/dbt-labs/dbt-utils/blob/0.8.6/macros/sql/deduplicate.sql line 42
Are you interested in contributing the fix?
Not experienced at all in DBT, so I should stay far away from trying to fix things ;-)

Good spotting! The interesting thing with this is that the Postgres, Snowflake and BigQuery variants don't require a CTE. It would be very good for all implementations to be consistent, and not needing a with clause seems easiest.
Lazy Joel thinks that maybe this could be done by wrapping it all in a select * from (with .... ) block, but I haven't tested that.
What we don't want: a flag on the macro to say whether the with is needed, because that will do nothing in the PG/SF/BQ cases.
I'm going to mark this as a good first issue for a community member to investigate. @mr78623451915 if you worked out a way to achieve it in Databricks SQL (disregarding the fact that it's in a macro), then we can provide the dbt experience to help you get it merged into the project. But right now all we need is SQL chops - I believe in you!

@ethanotran picking up from this discussion, this is another issue which I'd love to get in to dbt utils 1.0, and I think should be well-suited to a first contribution. To flesh out my example from above, I think the macro would be
select * from (
    [all the code that's already in default__deduplicate]
)

The piece that would be really valuable on top of this would be adding another test in the similar vein to @mr78623451915's example above, so that we can validate that we get the same behaviour on each of the warehouses we support.
You can see an example test here:
https://github.com/dbt-labs/dbt-utils/blob/f612170549204eea25435fa0058763064a4e0d00/integration_tests/models/sql/test_deduplicate.sql#L1-L21
and its generic test defined here
https://github.com/dbt-labs/dbt-utils/blob/f612170549204eea25435fa0058763064a4e0d00/integration_tests/models/sql/schema.yml#L183-L186
You're welcome to use the same input and output files, and just have another copy of the model file which behaves as above instead of wrapping inside a CTE.

Let me know if you need any help with the initial fork or getting set up - the first contribution is always a little bit fiddly.

Hi team,
Any update on this issue, I am facing the same issue with

dbt core 1.4.5
athena adaptor 1.4.2
dbt_utils 1.0.0

Thanks

Hi @joellabes I created a PR for issue based on the hints and guidelines you provided and tested the same in the local environment also and it is working as expected.
Please let me know if this works.
This is my first PR any suggestions for improvements are welcome


v0.4 compat Strings and Uint

Updates to be compatible with v0.4
String->AbstractString
Uint* -> UInt*

Thanks!


ERROR ITMS-90129: "The bundle uses a bundle name or display name that is already taken

Question Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Question Subject

I'm getting this error when trying to publish an app to TestFlight using Azure DevOps Pipelines, which uses Fastlane.  How can I fix it?
Question Description

I found Issue #12680, indicating that this isn't a TestFlight issue... and it still may not be. That issue looks like it was hastily closed without any investigation, and the OP didn't pursue it. I'm bringing it up again because if I manually upload the app to the App Store/TestFlight using XCode, it works perfectly, with the same bundle id, bundle name, and display name. Assuming the Azure DevOps pipelines doesn't do anything to connect to Apple other than use Fastlane, then there would appear to be a problem with Fastlane.

Here's the log from Azure DevOps:
##[section]Starting: Publish to the App Store TestFlight track
==============================================================================
Task         : Apple App Store Release
Description  : Release an app to TestFlight or the Apple App Store
Version      : 1.158.0
Author       : Microsoft Corporation
Help         : [More Information](https://marketplace.visualstudio.com/items?itemName=ms-vsclient.app-store)
==============================================================================
bee538a5-46c9-4cd2-9fca-b847cc5a5080 exists true
[command]/usr/local/opt/ruby/bin/gem install fastlane
Successfully installed rubyzip-1.3.0
Successfully installed fastlane-2.133.0
Parsing documentation for rubyzip-1.3.0
Installing ri documentation for rubyzip-1.3.0
Parsing documentation for fastlane-2.133.0
Installing ri documentation for fastlane-2.133.0
Done installing documentation for rubyzip, fastlane after 21 seconds
2 gems installed
[command]/usr/local/opt/ruby/bin/gem update fastlane -i /Users/vsts/.gem-cache
Updating installed gems
Nothing to update
[command]fastlane pilot upload -u *** -i /Users/vsts/agent/2.158.0/work/1/s/my.ipa -q 117232819 -r Company, Inc. opt_out_usage
[13:58:55]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[13:58:56]: Sending anonymous analytics information
[13:58:56]: Learn more at https://docs.fastlane.tools/#metrics
[13:58:56]: No personal or sensitive data is sent.
[13:58:56]: You can disable this by adding `opt_out_usage` at the top of your Fastfile
[13:58:56]: Login to App Store Connect (***)
Session loaded from environment variable is not valid. Continuing with normal login.
[13:58:58]: Login successful
[13:59:00]: Ready to upload new build to TestFlight (App: 953681025)...
[13:59:00]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
[13:59:18]: iTunes Transporter successfully finished its job
[13:59:18]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
[13:59:18]: Going to upload updated app to App Store Connect
[13:59:18]: This might take a few minutes. Please don't interrupt the script.
[13:59:39]: [Transporter Error Output]: ERROR ITMS-90129: "The bundle uses a bundle name or display name that is already taken."
[13:59:39]: Transporter transfer failed.
[13:59:39]:
[13:59:39]: ERROR ITMS-90129: "The bundle uses a bundle name or display name that is already taken."

I've changed a few of the lines for privacy. For this line:
[13:59:00]: Ready to upload new build to TestFlight (App: 953681025)...

This App# matches the identifier that the App Store has. (I've changed the App# for privacy.) It seems like the app being uploaded is successfully being mapped to the app in the App Store.
For this line:
[command]fastlane pilot upload -u *** -i /Users/vsts/agent/2.158.0/work/1/s/my.ipa -q 117232819 -r Company, Inc. opt_out_usage

What is the magic number ("117232819") after the -q parameter? (I've changed the company name in the -r parameter and the name of the .ipa file for privacy.)


Build out service functions for collections API

Description
Implements the front end collection service based on the backend API design document.
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
None, this code is not yet referenced by the application.

Current dependencies on/for this PR:

master

PR #3152   👈

This comment was auto-generated by Graphite.


6447 add more tests for odo dev on podman

Implement GetRunningPodFromSelector for podman
Implement GetPodLogs for podman
Same message in podman/cluster
Integration tests
WIP - test cases with composite commands
WIP - refactor GetEnvVars
wip : Add GetLabels interface method in component_interface

What type of PR is this:

What does this PR do / why we need it:
Which issue(s) this PR fixes:

Fixes #
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/hold
Created on top of https://github.com/redhat-developer/odo/pull/6481. We need to wait for https://github.com/redhat-developer/odo/pull/6481.

Superseded by:

https://github.com/redhat-developer/odo/pull/6496
https://github.com/redhat-developer/odo/pull/6506
https://github.com/redhat-developer/odo/pull/6515


No display whenever you try to search for a superhero name

I tried searching for a wrong superhero name and nothing displayed. Mind if I take on this issue @Prajwal0225

What you are going to do to solve this issue?

I'm getting an error "TypeError: Cannot read properties of undefined (reading '0')
at script.js:23:32" which means the result array is empty when the superhero cannot be found. So to clear the error we will have to check if the results error exists and if it contains any elements before accessing the first element (json.results[0]). @Prajwal0225

@Prajwal0225 I have fixed this issue already. Should I create a PR ?

Can you do something like If the user enters an incorrect superhero name, it will display the message, 'A superhero with this name does not exist on the website.

Yes @Prajwal0225 . I already did that but I need your permission to push and make a PR ?

Please make a Pr my cloning updated code from the repo.

please assign this to me so that i contribute to this hactoberfest 2023 . i have excellent knowledge of web dev and you can also check my projects in my repositories.

Already done  @Prajwal0225  @Mohd786-hub. Just made a PR on it. You can check other issues.

@Prajwal0225  i've  raised a PR please have a look...


Feature Request: chop-down a.k.a. put arguments on separate lines

There's a refactoring in IntelliJ-based IDEs that I quite like which allows you to put a list of arguments in a function signature / items in a struct / html attributes on their own separate lines.
Examples:
useEffect(() => alert('123'), [])

--->

useEffect(
    () => alert('123'),
    [],
)

<Title className="123" prop1="234" abc={bcd} />

--->

<Title
    className="123"
    prop1="234"
    abc={bcd}
/>

I'm not sure if it's in the scope of this project, but that would be very useful since it's not easily achievable with pure Vim. If it is in scope I would be happy to work on the implementation myself.

This sounds like treesj (using treesitter) or mini.join (using lua patterns)

Yep, that's exactly it, thank you for the great suggestion. Closing the issue then


R.4.3.3 package installation

Greetings,
Is there any problem to install the package for R Ver. 4.3.3?
I have problem to do this!
My R Ver. 4.3.3, and Rstudio Ver. is 1.1.419
Regards,

In both R 4.3.3 and 3.2.2, I could install the package ( GSE5859Subset) and I checked that box in front of it in packages (in Rstudio) .But, when I would call  for example tissueGeneExpression, I see the followings (maybe I am doing the procedure not correctly to call data):

library("GSE5859Subset", lib.loc="~/R/win-library/3.2")
library(tissuesGeneExpression)
Error in library(tissuesGeneExpression) :
there is no package called ‘tissuesGeneExpression’
data(tissuesGeneExpression)
Warning message:
In data(tissuesGeneExpression) : data set ‘tissuesGeneExpression’ not found
table(tissue)
Error in table(tissue) : object 'tissue' not found
library(tissuesGeneExpression)
Error in library(tissuesGeneExpression) :
there is no package called ‘tissuesGeneExpression’
data(tissuesGeneExpression)
Warning message:
In data(tissuesGeneExpression) : data set ‘tissuesGeneExpression’ not found
dim(e)
Error: object 'e' not found

Please guide me!
Regards

library(BiocInstaller)
biocLite("genomicsclass/tissuesGeneExpression")
library(tissuesGeneExpression)
data(tissuesGeneExpression)
dim(e) # will now work
On Thu, Feb 1, 2018 at 7:14 PM, DrPedi<EMAIL_ADDRESS>wrote:

In both R 4.3.3 and 3.2.2, I could install the package ( GSE5859Subset)
and I checked that box in front of it in packages (in Rstudio) .But, when I
would call for example tissueGeneExpression, I see the followings (maybe I
am doing the procedure not correctly to call data):
library("GSE5859Subset", lib.loc="~/R/win-library/3.2")
library(tissuesGeneExpression)
Error in library(tissuesGeneExpression) :
there is no package called ‘tissuesGeneExpression’
data(tissuesGeneExpression)
Warning message:
In data(tissuesGeneExpression) : data set ‘tissuesGeneExpression’ not found
table(tissue)
Error in table(tissue) : object 'tissue' not found
library(tissuesGeneExpression)
Error in library(tissuesGeneExpression) :
there is no package called ‘tissuesGeneExpression’
data(tissuesGeneExpression)
Warning message:
In data(tissuesGeneExpression) : data set ‘tissuesGeneExpression’ not found
dim(e)
Error: object 'e' not found
Please guide me!
Regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/genomicsclass/labs/issues/69#issuecomment-362444886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEaOwu1wXJEbwUvPGWsysoIPNO0G4qxQks5tQlNqgaJpZM4R2agb
.

I appreciate your swift reply!
I have copy/ paste your code in my R console, but still I can see the following errors:
--- Please select a CRAN mirror for use in this session ---
Warning: package ‘devtools’ is in use and will not be installed

library(BiocInstaller)
Error in library(BiocInstaller) :
there is no package called ‘BiocInstaller’
biocLite("genomicsclass/tissuesGeneExpression")
Error in biocLite("genomicsclass/tissuesGeneExpression") :
could not find function "biocLite"
library(tissuesGeneExpression)
Error in library(tissuesGeneExpression) :
there is no package called ‘tissuesGeneExpression’
data(tissuesGeneExpression)
Warning message:
In data(tissuesGeneExpression) : data set ‘tissuesGeneExpression’ not found
dim(e)
Error: object 'e' not found

How can I go forward step by step to make sure that I am doing the procedure rightly?
Regards,

Introductory material of the course discusses how to install R packages.
in this case you can use
source("http://www.bioconductor.org/biocLite.R")
that will install BiocInstaller
library(BiocInstaller)  # will now succeed
On Thu, Feb 1, 2018 at 11:51 PM, DrPedi<EMAIL_ADDRESS>wrote:

I appreciate your swift reply!
I have copy/ paste your code in my R console, but still I can see the
following errors:
--- Please select a CRAN mirror for use in this session ---
Warning: package ‘devtools’ is in use and will not be installed
library(BiocInstaller)
Error in library(BiocInstaller) :
there is no package called ‘BiocInstaller’
biocLite("genomicsclass/tissuesGeneExpression")
Error in biocLite("genomicsclass/tissuesGeneExpression") :
could not find function "biocLite"
library(tissuesGeneExpression)
Error in library(tissuesGeneExpression) :
there is no package called ‘tissuesGeneExpression’
data(tissuesGeneExpression)
Warning message:
In data(tissuesGeneExpression) : data set ‘tissuesGeneExpression’ not found
dim(e)
Error: object 'e' not found
How can I go forward step by step to make sure that I am doing the
procedure rightly?
Regards,
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/genomicsclass/labs/issues/69#issuecomment-362485933,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEaOwmeygI7bcnE2JsH66mH2Ng4Rym4kks5tQpRNgaJpZM4R2agb
.

It works now, my sincere appreciation.
Have a good one,

library(devtools) install_github("genomicsclass/GSE5859Subset") library(GSE5859Subset) data(GSE5859Subset)


BUG Social network buttons in dark mode

Issue description
The Social media buttons have a style issue with the dark mode.

Steps to reproduce the issue

Enter to the APP
By default, the dark mode is active
If the dark mode no active, go to the development console in your browser, application and create a new value inside local storage darkMode with true value.

What's the expected result?
Like this;

hey @itsalb3rt ,
please Assign this task to me i will try to do it

Sure!
before submit your PR, make a sure you tested the UI. If you have any question, I’m here to help 🙌

hi ,
there is an error when i start a vue server at local host and i am unable to figure out why this error is shown after installing all packages

According to the project documentation you need run ‘yarn’ after installing all the dependencies you need run ‘quasar dev’.
This is a Quasar Framework project.
Ref: https://documentation-tavivo.albert.do/front-end/

Hey @itsalb3rt ,
I am unable to open the app so that i can configure please assign this to someone else , Sorry for not resolve conflict.

Cool, no problem. Thanks for notifying me. 🙌

@itsalb3rt I can take this issue.

🙌 yes go ahead @Jadhielv

Can i take this issue?

Sure! @rafieltq

Issue description
The Social media buttons have a style issue with the dark mode.
Solved! That was my results

Awesome! thanks @rafieltq

Ready in #69


Added initial socket-mode work

Summary
Very much a work in progress
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run python setup.py validate after making the changes.

We will use https://github.com/slackapi/python-slack-sdk/pull/883 for Socket Mode. Let me close this PR. Thanks a lot for starting this over 👍


use existing function convert_deps_to_pip, added 2 params to convert_…

running pipenv requirements with the below example dependency will fail
"exmple-repo": {
"editable": true,
"git"<EMAIL_ADDRESS>"ref": "cc858e89f19bc0dbd70983f86b811ab625dc9292"
}
Fix
Use the exisiting pipenv.utils.dependencies.convert_deps_to_pip function with some added parameters to output the requirements, remove parsing of file in pipenv.cli.command.requirements itself
The checklist

[x] Associated issue
[x] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Fixes #5076

Can you add a small test case together with the code?

@oz123 I'm struggling to find an instance were the pipfile.lock is mocked for a test? Any suggestions?

Can you add a small test case together with the code?

@oz123 I'm struggling to find an instance were the pipfile.lock is mocked for a test? Any suggestions?

@fraser-langton You don't really need to mock the Pipfile.lock right, you can just write out a file that is a valid Pipfile.lock and the current tests do that by doing a pipenv lock ahead of the requirements generation.   All of the current tests for this command exist here:  https://github.com/pypa/pipenv/blob/main/tests/integration/test_requirements.py
Alternatively you could generate a lock file locally and write that to a file at the start of your test and generate the requirements from that to test.

@matteius I'm blind 🤦♂ I was looking in the wrong directory. Thanks!

@fraser-langton can you merge latest main branch into your branch and resolve the merge conflict?

@oz123 Think I did correctly :)

You are almost there @fraser-langton  -- There is still a merge conflict that must be resolve with pipenv/cli/command.py -- Probably rebase was not the way to go but merging in the latest main, because now its showing a all the latest changes from main in this PR, which is confusing.  Either way, the conflicting file remains.

@fraser-langton you'll have to restart all over again. I am sorry...
Since we merged a PR which works on the same feature, not sure how to rebase this. You will have to look into the code again and see how to incorporate your commits.

@fraser-langton You may just want to make a new branch off main and cherry-pick in all of your commits up until the rebase, but consider that there is the conflict to resolve and as @oz123 mentions this other change to fix editable installs for that command --
https://github.com/pypa/pipenv/pull/5071

@fraser-langton I created a new PR to fix the conflict issue. I think this gets the original intent of your code.
Thank you for the contribution and the suggestion to use convert_deps_to_pip.
@hoyaaaa thank you too, for the original implementation.

closed with #5083


Initial diagrams for canvas-with-time

Add some initial diagrams about the canvas with time notion to the repo, along with Omnigraffle source.

Testing slack integration...

One more slack test

:+1: to getting these under version control

:+1: great start and certainly want under version control

Nothing normative here. Merging.

I added to todays call agenda the question of how we deal with pull requests here -- for spec stuff it should probably be editors, but are we going to collect more that just a first draft in this repo?