Release MicroProfile 5.0 on 7th Dec

[x]  Update MicroProfile presentation and save it in the right folder (technical person) example here
[ ] Import the presentation to the landing page and resources page of the website
[x] Draft a release announcement blog post using template (technical person) example here
[ ] Create release announcement design card See example here
[ ] Update MicroProfile homepage with release announcement design card
[x] Edit/Publish release announcement blog post on the MicroProfile Blog
[ ] Announce release on social media using Hootsuite (Twitter, Linkedin, Facebook) example here
[ ] Write an update to the MP Community Forum about the release
[ ] Update the MP Calendar with the Release Date (committer)

MPWG Paid Services step for MP 5 Release:

[ ] EF MP 5 release announcement using the EF channels. https://github.com/eclipse/microprofile-marketing/issues/619

I would like to target this release for 7th Dec so that we can announce it on JakartaOne Live on 8th Dec.

EMO: please announce this release.

@emecas,
Thank you for volunteering to steer the Release Announcement written by the EF.
Processing tasks

[ ] Create a new git issue to inform the EF team of the release date by adding Clark git ID to that ticket https://github.com/eclipse/microprofile-marketing/wiki/Eclipse-Foundation-Team-GitHub-IDs
[ ] in that ticket, we need to request that the Announcement draft be provided for MicroProfilers' review  in word version with Suggestive Mode access at least 3 days (avoid a Friday delivery) before Dec. 6th
[ ] We will insert our Technical blog to that paid release, make sure to state it in the ticket
[ ] The EF can use the https://groups.google.com/g/microprofile-marketing to submit the release for update. It is your job to update that ticket you will create.
[ ] that release will be imported into the MP blogs.  Either the EF becomes a contributor of MP blog (follows the guidelines)  or we import the paid announcement as an original content with the link of the actual release. https://github.com/microprofile/wpsite

Questions, shoot and thanks, Emerson!

@aeiras, I don't have permissions in this repository to mark the tasks as 1 to 4 as done,  then please see my comments below for each related subject.

@emecas,
Thank you for volunteering to steer the Release Announcement written by the EF.
Processing tasks
* [ ]  Create a new git issue to inform the EF team of the release date by adding Clark' git ID to that ticket https://github.com/eclipse/microprofile-marketing/wiki/Eclipse-Foundation-Team-GitHub-IDs

Done: https://github.com/eclipse/microprofile-marketing/issues/619

* [ ]  in that ticket,  (added to the template tasks with link) I have added it under paid-services.

I am not sure about what link including, but I added the single task under paid-services to the created issue,  may you provided what link you meant here ? then I could update it

* [ ]  We need to request that the Announcement draft be provided for MicroProfilers' review  in word version with Suggestive Mode access at least 3 days (avoid a Friday delivery) before Dec. 6th

Done

* [ ]  We will insert our Technical blog to that paid release, make sure to state it in the ticket

Done

* [ ]  The EF can use the https://groups.google.com/g/microprofile-marketing to submit the release for review. It is your job to update that ticket you will create with such EF updates.

WIP

* [ ]  that release will be copy/paste imported into the MP blogs.  Either the EF becomes a contributor of MP blog (follows the guidelines) and they do that import  or we import the paid-announcement as an original. Both options must have the link of the actual release post. https://github.com/microprofile/wpsite

TBD

Questions, shoot and thanks, Emerson!

Emerson,
I added ticket 619 to the main template above. Great stuff on that ticket.
Will you also be the one using the technical template to start the release blog? I will be happy to review it once you, emily and Edwin are happy with first draft.
@TetianaFTV,
earlier this fall, you volunteered to help with logistics with MP 5. updates as done for last Dec release. Can you still own that?  Ideally, we could invite someone else from the members who are comfortable with Wordpress updates to shadow you so that they can help on next release and be a trainee on this one. :)

@aeiras I have drafted MicroProfile 5.0 blog . @TetianaFTV, will you be able help with inserting the image (can be found on slide 8.  @rstjames please see the checklist in the issue for social card design and website updates.
I made a start on the slide deck here. The slide 8 and onwards need to be updated. @ederks85 will you be able to do the rest slides?
We need to go through the checklist this week to prepare most of the content.

Hey amazing Emily,
To provide feedback on the infra release, the document must be a google document to welcome my suggestive edit. Remember when we import stuff to wordpress in releases, it is only after the google document has been reviewed.
Can you get that document imported to google doc for me by tomorrow AM? I will be happy to provide feedback via that method by the end of tomorrow.
Please note that we want the release to be authored by you, Edwin and Emerson.  So the authors are 3 and 2 editors  Tetiana (publisher) & me (editor)
A reminder that TT won't be helping on this release with the media, website or design. We stated earlier this summer that we wish for another member to help on MP 5 release to enable the onboarding and scaling of such tasks with respect to Releases.
Tetiana volunteered back then to help once again on this release if it didn't hit X-Mas.  It doesn't, so we are ok, yeay!!
Ideally, maybe Vince chooses to become a release Trainee alongside with Tetiana. Vince has no access to hootsuite and the website and can do everything Ryan and Tetiana can :) Lets' see if he wishes to do this for MP 5.

@aeiras the blogs and slides are https://drive.google.com/drive/folders/1XqoNB9kEL9dpKxjHq71a4CfmBx1vjt3Z for MicroProfile 5.0 release.

Thank you @Emily-Jiang  for grantting me access to the draft document, I just finished reading it and adding some comments and suggestions. @aeiras @ederks85 feel free to review

@emecas,
I released during the review last night that you Emerson didn't have Edit access to help publish and edit stuff in MP wordpress.   Just like Edwin and Emily have earned that Edit access, you to have it now with your work on MP 5.0.  Your log in name should be already in your gmail inbox with Emerson-Castaneda name. Please note that Wordpress doesn't accept ñ as it is a special character, so I had to settled for the N.

I just got done with first review. I will be back tomorrow MicroProfilers to check on the comments and Q&A on feedback provided. :) Super fun stuff!

hi, I've made some edits / comments in blog article draft and presentation.
Possible text for a tweet:
MicroProfile 5.0 is now available! 📢🚀 Each specification included in this release has updated its dependencies from javax to jakarta. Learn more about recent changes and how to become fully @MicroProfileIO compatible [LINK]
@JakartaEE @jee_ambassadors

@aeiras @emecas @Emily-Jiang I have updated the slides regarding the component specification release details in the PPT

@Emily-Jiang I have also revied the blog's Google Doc. A lot was already commented on by Amelia, I have added a few of my own

hi, I've made some edits / comments in blog article draft and presentation.
Possible text for a tweet: MicroProfile 5.0 is now available! 📢🚀 Each specification included in this release has updated its dependencies from javax to jakarta. Learn more about recent changes and how to become fully @MicroProfileIO compatible [LINK] @jakartaee @jee_ambassadors

Hey Tetiana,
If there is space, the tweet should start with #MicroProfileReleaseAnnouncement:
Great write up, I suggest:

inserting #JakartaEE 9.1 somewhere
removing @jee_ambassadors - we must be careful to highlight any group within ecosystem. When we start, there is no stopping the "favoritism" and the lack of care for other groups that also have so much power within the technologies  that belong to the MP ecosystem. MP is not solely supportive of Jakarta.
insert #OSS hastag if there is space.

Also, it is ok to keep 1 ticket for all tasks if those behind the activities wish them. However, there is a harder way to track stuff if using 1 ticket when the checklist welcomes each task to be a ticket to enable focus follow up, closing and tracking on check list.

@ederks85 i reviewed the slides and adjusted a bunch of stuff. Sadly there is no suggestive mode in slides yet you could easily see them if checking History.
Comments are insterted as well. Can you please take a look?

@aeiras I have taken a look and will keep watching the document for new comments. @Emily-Jiang I have put a few comments on the <#8 slides. Are you still working on these?

hi, I've made some edits / comments in blog article draft and presentation.
Possible text for a tweet: MicroProfile 5.0 is now available! 📢🚀 Each specification included in this release has updated its dependencies from javax to jakarta. Learn more about recent changes and how to become fully @MicroProfileIO compatible [LINK] @jakartaee @jee_ambassadors

Thank you @TetianaFTV! I think we need to ask them to try it out the compatible implementation of Open Liberty <IP_ADDRESS>-beta. I will provide some suggestions later today.

@aeiras @TetianaFTV on a separate note, can you two help chasing up the votes on the releases - 4 voting threads to be closed. @TetianaFTV if you can cast your votes on the OpenAPI and MicroProfile 5.0? @aeiras can you get Tomitribe to vote on all of the ballots? Open API 3.0 and MicroProfile 5.0 need a lot of votes to come through before we can release MP 5.0 on 7th Dec.

@Emily-Jiang,
Yes on voting. TT will complete its review and voting today. Thank you for the care and extra push. We appreciate it.

@aeiras  at this stage,  do you think  it would be good idea to create a couple of GitHub issues for providing Spanish translation for both documents available here :
https://drive.google.com/drive/folders/1XqoNB9kEL9dpKxjHq71a4CfmBx1vjt3Z ?
Mainly, in order to provide Spanish documentation for the release day!!! or would it be better wait until having the final versions of slides and blog post?

1 on starting the work on those translations, Emerson. We only have until Dec 17th before most of us go into recharge mode!

Go for it! :)  You know the drill. We can include even a spanish blog, if you are up to it for Mp 5. release. We have never done it before. I think it could be a great new feature if there is ownership. :)

hi, I've made some edits / comments in blog article draft and presentation.
Possible text for a tweet: MicroProfile 5.0 is now available! 📢🚀 Each specification included in this release has updated its dependencies from javax to jakarta. Learn more about recent changes and how to become fully @MicroProfileIO compatible [LINK] @jakartaee @jee_ambassadors

@TetianaFTV how about the following tweet message
MicroProfile 5.0 is now available! 📢🚀 Each specification under MicroProfile 5.0 has updated its dependencies from javax to jakarta. Try it out using @OpenLibertyIO <IP_ADDRESS>-beta https://openliberty.io/blog/2021/11/30/microprofile-5-22001-beta.html @MicroProfileIO @jakartaee @jee_ambassadors  [link to MP 5.0 blog]

Looks good but better leave just link to blog post in the tweet, in the article there can be added link to OpenLiberty

Hey @Emily-Jiang,

Looks good but better leave just link to blog post in the tweet, in the article there can be added link to OpenLiberty

+1. The only link in the tweet is the MP blog.

@Emily-Jiang,
I see why I confused you with the editors and authors feedback.
Please see the pic attached.
Under Authors, it only has your name. It needs to have 3 authors: you, Edwin and Emerson who are the Stewards of MP 5. release.
I added Release category today.
Please when you go into updating the blog with latest version, can you ensure that this blog has 3 authors? Only you can do it b/c you are the creator of the blog in WordPress.
Thank you for rocking it!

@Emily-Jiang, I see why I confused you with the editors and authors feedback.
Please see the pic attached. Under Authors, it only has your name. It needs to have 3 authors: you, Edwin and Emerson who are the Stewards of MP 5. release. I added Release category today.
Please when you go into updating the blog with latest version, can you ensure that this blog has 3 authors? Only you can do it b/c you are the creator of the blog in WordPress.
Thank you for rocking it!

I have updated the blog with the latest update from the google doc. As for the author addition, I don't know how, because there is no areas for me to add more authors. I am not sure whether it is possible. I had a quick look at the past blogs. I have not seen any blogs with multiple authors. I think it only uses the person who created the post. We can add the additional editors on the top if it helps. @aeiras please have a go at it by creating a testing post and see whether you can add additional authors.

I am monitoring the voting status for MP 5.0 release. We are still awaiting AJUG and Garden State JUG to vote on OpenAPI 3.0 and MicroProfile 5.0 ballot. @aeiras if you can reach out and remind them to vote, it will be great. Thank you!

I am monitoring the voting status for MP 5.0 release. We are still awaiting AJUG and Garden State JUG to vote on OpenAPI 3.0 and MicroProfile 5.0 ballot. @aeiras if you can reach out and remind them to vote, it will be great. Thank you!

Notes sent- :)

@Emily-Jiang, I see why I confused you with the editors and authors feedback.
Please see the pic attached. Under Authors, it only has your name. It needs to have 3 authors: you, Edwin and Emerson who are the Stewards of MP 5. release. I added Release category today.
Please when you go into updating the blog with latest version, can you ensure that this blog has 3 authors? Only you can do it b/c you are the creator of the blog in WordPress.
Thank you for rocking it!

I have updated the blog with the latest update from the google doc. As for the author addition, I don't know how, because there is no areas for me to add more authors. I am not sure whether it is possible. I had a quick look at the past blogs. I have not seen any blogs with multiple authors. I think it only uses the person who created the post. We can add the additional editors on the top if it helps. @aeiras please have a go at it by creating a testing post and see whether you can add additional authors.

It might be the new feature from WP that doesn't even allow authors to adjust the blog after it is saved.
All good Emily. In the future we need to add as authors whoever are the Stewards of the release. I will adjust the WP blog to separate editors from Stewards :) that should fix stuff!
So fun and so exciting!   Please do rest. so late for you.
See you on Monday and Tuesday (Jkta)

Emily confirmed that all needed approvals have been received & all materials are complete.  Just waiting on date to release.
@rstjames - input needed to update homepage: change presentation, link to more info, and block with color-coded API's & updates.  He's on vacation until tomorrow 12/7.  @TetianaFTV will do as much as she can pending schedule conflict availability.
For social media, use image already in media folder.  Source files are in drive.  Can update existing card to MP 5.0.
@TetianaFTV will have designer update card tomorrow AM (Europe Time) and will push to hootsuite.
Publish Social Media Updates: 1pm UK Time / 2pm Central European Time
Go live for Emily: 2pm UK Time

There is still a set of comments in the presentation
https://docs.google.com/presentation/d/1PfXEOJzy8v2kGRudvknPox5elRasewv3MBeV0P4Rk6M/edit#slide=id.p
So is it ok to place it on site like this?

@Emily-Jiang for website update, correct links are required for

button in the first block with latest tag at home page https://microprofile.io/ (now I see only pre-releases in repo)
each spec in this block

There is still a set of comments in the presentation https://docs.google.com/presentation/d/1PfXEOJzy8v2kGRudvknPox5elRasewv3MBeV0P4Rk6M/edit#slide=id.p
So is it ok to place it on site like this?

I checked the comments and resolved them. Only one left was for making the logo pages prettier.

@Emily-Jiang for website update, correct links are required for
* button in the first block with latest tag at home page https://microprofile.io/ (now I see only pre-releases in repo)

* each spec in this block

Just for completeness, @TetianaFTV and I had a chat and I have supplied the links:

https://jakarta.ee/specifications/cdi/3.0/jakarta-cdi-spec-3.0.html

https://jakarta.ee/specifications/annotations/2.0/annotations-spec-2.0.html

https://jakarta.ee/specifications/restful-ws/3.0/jakarta-restful-ws-spec-3.0.html

https://jakarta.ee/specifications/jsonb/2.0/jakarta-jsonb-spec-2.0.html

https://jakarta.ee/specifications/jsonp/2.0/apidocs/

https://github.com/eclipse/microprofile-config/releases/tag/3.0

https://github.com/eclipse/microprofile-fault-tolerance/releases/tag/4.0

https://github.com/eclipse/microprofile-health/releases/tag/4.0

https://github.com/eclipse/microprofile-jwt-auth/releases/tag/2.0

https://github.com/eclipse/microprofile-metrics/releases/tag/4.0

https://github.com/eclipse/microprofile-open-api/releases/tag/3.0

https://github.com/eclipse/microprofile-opentracing/releases/tag/3.0

https://github.com/eclipse/microprofile-rest-client/releases/tag/3.0

hi, is everything as planned?
@Emily-Jiang should this link be used as latest tag at home page?
https://github.com/eclipse/microprofile/releases/tag/5.0

hi, is everything as planned?
@Emily-Jiang should this link be used as latest tag at home page? https://github.com/eclipse/microprofile/releases/tag/5.0

yes

website updated
article published
social media posts scheduled for 3pm CET

Thank you @TetianaFTV ! This is awesome!

@Emily-Jiang, @emecas, @ederks85 , @aeiras, @TetianaFTV
Hello all, can this ticket be closed?  Please add your comments here and update the minutes accordingly.  Thank you!  :)

yes, this ticket is completed
but i don't have the rights to close it

Done :)  Thank you, @TetianaFTV!


added clientupdate functions

Added functions that allow setting client properties.
This also corrects how bool values are parsed.

Hi @stevenh, can you take a look at my PRs sometime?


gulp build serve --dev

$ gulp build serve --dev
[17:51:37] Using gulpfile C:\Dev\angular2-seed\gulpfile.js
[17:51:37] Starting 'build'...
[17:51:37] Starting 'serve'...
[17:51:37] Starting 'clean'...
[17:51:37] Starting 'parallel'...
[17:51:37] Starting 'watch'...
[17:51:37] Starting 'livereload'...
[17:51:38] Server started http://localhost:8080
[17:51:38] LiveReload started on port 35729
[17:51:38] Finished 'clean' after 187 ms
[17:51:38] Starting 'parallel'...
[17:51:38] Starting 'scsslint'...
[17:51:38] Starting 'tslint'...
[17:51:38] 'scsslint' errored after 280 ms
[17:51:38] TypeError: Cannot read property 'start' of undefined
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:57:46)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at Object.module.exports.detect (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:100:5)
at C:\Dev\angular2-seed\node_modules\sass-lint\index.js:44:27
at Array.forEach (native)
at Function.sassLint.lintText (C:\Dev\angular2-seed\node_modules\sass-lint\index.js:43:11)
at DestroyableTransform._transform (C:\Dev\angular2-seed\node_modules\gulp-sass-lint\index.js:38:27)
at DestroyableTransform.Transform._read (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_transform.js:172:10)
at DestroyableTransform.Transform._write (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_transform.js:160:12)
at doWrite (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:333:12)
at writeOrBuffer (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:319:5)
at DestroyableTransform.Writable.write (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:246:11)
at DestroyableTransform.ondata (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_readable.js:581:20)
[17:51:38] 'parallel' errored after 284 ms
[17:51:38] TypeError: Cannot read property 'start' of undefined
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:57:46)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at Object.module.exports.detect (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:100:5)
at C:\Dev\angular2-seed\node_modules\sass-lint\index.js:44:27
at Array.forEach (native)
at Function.sassLint.lintText (C:\Dev\angular2-seed\node_modules\sass-lint\index.js:43:11)
at DestroyableTransform._transform (C:\Dev\angular2-seed\node_modules\gulp-sass-lint\index.js:38:27)
at DestroyableTransform.Transform._read (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_transform.js:172:10)
at DestroyableTransform.Transform._write (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_transform.js:160:12)
at doWrite (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:333:12)
at writeOrBuffer (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:319:5)
at DestroyableTransform.Writable.write (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:246:11)
at DestroyableTransform.ondata (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_readable.js:581:20)
[17:51:38] 'build' errored after 482 ms
[17:51:38] TypeError: Cannot read property 'start' of undefined
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:57:46)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at processNode (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:96:9)
at Object.module.exports.detect (C:\Dev\angular2-seed\node_modules\sass-lint\lib\rules\indentation.js:100:5)
at C:\Dev\angular2-seed\node_modules\sass-lint\index.js:44:27
at Array.forEach (native)
at Function.sassLint.lintText (C:\Dev\angular2-seed\node_modules\sass-lint\index.js:43:11)
at DestroyableTransform._transform (C:\Dev\angular2-seed\node_modules\gulp-sass-lint\index.js:38:27)
at DestroyableTransform.Transform._read (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_transform.js:172:10)
at DestroyableTransform.Transform._write (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_transform.js:160:12)
at doWrite (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:333:12)
at writeOrBuffer (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:319:5)
at DestroyableTransform.Writable.write (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_writable.js:246:11)
at DestroyableTransform.ondata (C:\Dev\angular2-seed\node_modules\readable-stream\lib_stream_readable.js:581:20)
[17:51:38] The following tasks did not complete: serve, parallel, watch, livereload, tslint
[17:51:38] Did you forget to signal async completion?

Duplicated https://github.com/ghpabs/angular2-seed/issues/38


Do not crash when initializing API

RELEASE_NOTES=n/a
Fixes #1480
Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Codecov Report

Merging #1481 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   61.11%   61.11%   -0.00%
==========================================
  Files         219      219
  Lines       12176    12185       +9
==========================================
+ Hits         7441     7446       +5
- Misses       3916     3920       +4
  Partials      819      819

Impacted Files
Coverage Δ

cmd/gopass-git-credentials/main.go
0.00% <0.00%> (ø)

cmd/gopass-hibp/main.go
0.00% <0.00%> (ø)

cmd/gopass-jsonapi/main.go
0.00% <0.00%> (ø)

cmd/gopass-summon-provider/main.go
0.00% <0.00%> (ø)

internal/action/commands.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39aeeb...9f5ac44. Read the comment docs.


Suport for InternVL-Chat-V1-5

Model description
OpenGVLab/InternVL-Chat-V1-2-Plus is a open source alternative to GPT-4V. Can we please have support for that?
Open source status

[X] The model implementation is available
[X] The model weights are available

Provide useful links for the implementation
https://huggingface.co/OpenGVLab/InternVL-Chat-V1-2-Plus

Hi @Narsil  Can I currently deploy https://huggingface.co/OpenGVLab/InternVL-Chat-V1-2-Plus on TGI?

Also interested in this model, it performs pretty good in my tests.

also looking forward to it


Windows support

It annoys me that I have to make lexer.globstar a new RegExp object in globrex and then cast it back to a string in the walker.

Thanks for the feedback @lukeed. It's included in the latest commit


Share Server Configuration files links

Server Configuration files - share the links with Santhosh

@ananya-jain1  and @htvenkatesh Please look in to this

Configuration files for cQube roadmap are being reviewed by Santhosh.


Render empty respondents work address in XML

Ensure that respondents with empty work addresses validates correctly against V0.24 of the Jadu Schema when represented as XML.

@helenmott labelling stuff without lifting a finger. Such skilz

LGTM :+1:  good to have you back @dan-palmer !

@dan-palmer merge away

Thanks @mattmb. :ship:


Sea plants needs to emit light

(also on creative server)
Sea plants needs to emit light (buildings underwater will be easier and underwater will be more friendly)

https://github.com/MinetestForFun/server-minetestforfun/commit/73b18e64337a0f0256a3964ddc5113685a5a98da


Add validation for duplicate state names

A state name must be unique within the scope of the entire state machine.

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines           80        86    +6
  Branches         8        10    +2
=========================================
+ Hits            80        86    +6

Impacted Files
Coverage Δ

src/awsstepfuncs/state_machine.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add182a...ef7b968. Read the comment docs.


Can't reload a pandas dataframe containing a list of datetime.time

Hello,
this simple script writes a panda dataframe with a list of datetime.time. However, constructing back the pandas dataframe fails.
I initially realised that when doing a pd.read_parquet('example.parquet'), which fails with the same error.
This is using
pyarrow 0.11.1
pandas 0.23.4
import pandas as pd
import pyarrow as pa
import pyarrow.parquet as pq

times = pd.to_datetime(['09:00', '09:30', '10:00', '10:30', '11:00', '11:30', '12:00']).time
df = pd.DataFrame({'Time': [times]})

table = pa.Table.from_pandas(df)
pq.write_table(table, 'example.parquet')

// works
table2 = pq.read_table('example.parquet')

// Fails: ArrowNotImplementedError: Not implemented type for list in DataFrameBlock: time64[us]
df2 = pa.Table.to_pandas(table2)

Can you open a JIRA issue for this? Thanks

https://issues.apache.org/jira/browse/ARROW-4135


lastPageTitle not working, taking value of firsPageTitle

Description: When we give blank space values to both pagination optios: firstPageText and lastPageText. lastPageTitle takes same value as firstPageTitle.

Example code or repo: https://stackblitz.com/edit/react-v85cxp?file=Hello.js

Steps to reproduce: Set firstPageText and lastPageText as blank space, lastPageTitle will take same value of firstPageTitle

react-bootstrap-table2 version: 3.1.3

Maybe I have found the reason behind this issue, but not sure how to fix:
https://github.com/react-bootstrap-table/react-bootstrap-table2/blob/60eb47dc9e965854c5a3e50297a7928451f43c37/packages/react-bootstrap-table2-paginator/src/page-resolver.js#L141-L145
So, in above code, for both firstPageText and lastPageText, it will match conditon of L141 and it will show firstPageTitle.

hmm..  yeah this is an edge case but can I know why you set the blank text for both of first & last page button?

I am trying to set a background image for both through css and don't want any content in it. Anyways, it worked when gave: <span /> instead of blank space. I am closing it.

👍

Sorry, but if we use jsx element instead of string, it gives compile time errors.
Warning: Failed prop type: Invalid prop `firstPageText` of type `object` supplied to `Pagination`, expected `string`.
in Pagination (created by PaginationHandler)
in PaginationHandler (created by PaginationDataProvider)
in PaginationDataProvider (created by Context.Consumer)
in DataProvider (created by BootstrapTableContainer)
in BootstrapTableContainer
in Unknown (created by App)
in div (created by App)
in App

Example: https://stackblitz.com/edit/react-wjhzky?file=Hello.js

Hello @shhdharmen, so far the firstPageText only accept a string for customization. I will allow it to accept jsx in next version, thanks

@shhdharmen hello, this issue was fixed, please upgrade packages to newest version which listed in below:
https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2019/06/25/version-bump.html

Thanks for the updates, but now it's showing a different error. Example at : https://stackblitz.com/edit/react-wjhzky?file=Hello.js


Revert "Revert "Avoid copying data just to compress them when it is not necessary.""

Reverts vespa-engine/vespa#18905

@hmusum PR


Add Logo and Info for Razor Network (RAZOR) token

Please check the following to ensure a successful verification of Token Profile
.json and .png document checklists

[x] logo dimensions: 120*120 px
[x] logo background: Transparent
[x] At least one transaction on the token contract
[x] For ERC-20 project teams: Upper and lower capitalized alphabets in token address (For checksum purposes)
[x] Same document name for both .json and .png (Including capitalization)

Project Background:
Project basic information: Razor Network is a decentralized oracle network, which connects smart contracts with real-world off-chain data in a fast, robust and secure way. The core of Razor Network is a set of smart contracts that can run on any Ethereum compatible blockchain. Razor Network is blockchain agnostic and will be integrated with multiple blockchains.
CoinMarketCap page: https://coinmarketcap.com/currencies/razor-network/
CoinGecko page: https://www.coingecko.com/en/coins/razor-network
Etherscan Page: https://etherscan.io/token/0x50DE6856358Cc35f3A9a57eAAA34BD4cB707d2cd
Media publications:

https://www.coindesk.com/razor-network-oracles-funding-round
https://www.chainnews.com/news/315117639788.htm
https://news.yahoo.com/razor-network-raises-3-7m-140021836.html
https://www.nasdaq.com/articles/razor-network-raises-%243.7m-to-prove-theres-room-for-more-oracles-in-defi-2020-11-04
https://www.youtube.com/watch?v=98oPxBdLIsE
https://www.facebook.com/watch/live/?v=140544520842010&ref=watch_permalink

Tradeable exchanges: Uniswap, Balancer, MXC, Gate.io, Hoo
Recommended Gas Limit (For ERC-20 project teams) for a transaction: 60,000

@sfsy520 All checks passed. Please check and let me know if there's still anything missing.

@sfsy520 All checks passed. Please check and let me know if there's still anything missing.

欢迎在社区中推荐用户使用 imToken 2.0 ，imToken 支持比特币, 以太坊, Comos, EOS, 波场, Nervos, 比特币现金, 莱特币，波卡等资产管理；同时支持去中心化币币兑换功能 Tokenlon；转账页面支持 ETH, USDT, EOS, BTC OTC 功能；另外对于没有 ETH 矿工费的用户，也提供 ETH 手续费充值功能。

Hey @sfsy520 by when can I expect it to be added and the logo and info to be reflected on the App?

Hey @sfsy520 by when can I expect it to be added and the logo and info to be reflected on the App?
嘿，@ sfsy520何时可以添加，徽标和信息会在应用程序上反映出来？


Use configurations to choose the TLS provider.

This sidesteps dub/issues#1089 and makes vibe.d usable without linking against OpenSSL again.
This is an alternative approach to #1769.

Great, this is messed up. AppVeyor doesn't react anymore. The "push" build on Travis seems to be merged into master instead of 0.8.0, which makes the version test fail. And finally the remaining Travis build fails in a way that I can't reproduce locally. :-1:

Great, this is messed up. AppVeyor doesn't react anymore. The "push" build on Travis seems to be merged into master instead of 0.8.0, which makes the version test fail. And finally the remaining Travis build fails in a way that I can't reproduce locally. :-1:

Btw (in case you haven't enabled this), there's at least the option to auto-cancel "old" commit / builds on Travis:
https://blog.travis-ci.com/2017-03-22-introducing-auto-cancellation
I think on AppVeyor one needs to cancel the builds manually.

And finally the remaining Travis build fails in a way that I can't reproduce locally.

I can:
> dub -v build --combined -b release --compiler=dmd --config=libevent
Using dub registry url 'http://code.dlang.org/'
Refreshing local packages (refresh existing: true)...
Looking for local package map at /var/lib/dub/packages/local-packages.json
Looking for local package map at /home/seb/.dub/packages/local-packages.json
Try to load local package map at /home/seb/.dub/packages/local-packages.json
Determined package version using GIT: eventcore 0.8.8+commit.1.g420c361
Determined package version using GIT: hb-web 0.0.1+commit.3.gf97d88f
Determined package version using GIT: hb-ddb 0.2.5+commit.38.gb515f6b
Determined package version using GIT: vibe-core 1.0.0-beta.6+commit.4.g698824e
Determined package version using GIT: iopipe ~master
Determined package version using GIT: oauth 0.2.0-beta.2+commit.1.gf054671
Determined package version using GIT: inifiled 1.0.2
Determined package version using GIT: dscanner 0.4.0+commit.67.ga853936
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Ignoring version specification (>=0.0.0) for path based dependency .
Determined package version using GIT: vibe-d 0.8.0-rc.4+commit.2.g6ae5c111
No package found in current working directory.
Refreshing local packages (refresh existing: false)...
Looking for local package map at /var/lib/dub/packages/local-packages.json
Looking for local package map at /home/seb/.dub/packages/local-packages.json
Try to load local package map at /home/seb/.dub/packages/local-packages.json
  Error getting sub package vibe-d:redis: Sub package "vibe-d:redis" doesn't exist.
  Found dependency vibe-d:data 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency vibe-d:utils 0.8.0-rc.4+commit.2.g6ae5c111
  Found dependency vibe-d:core 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency libevent 2.0.2+2.0.16
    Found dependency libasync 0.8.3
      Found dependency memutils 0.4.9
    Found dependency vibe-core 1.0.0
      Found dependency eventcore 0.8.12
        Found dependency taggedalgebraic 0.10.7
  Error getting sub package vibe-d:textfilter: Sub package "vibe-d:textfilter" doesn't exist.
  Error getting sub package vibe-d:crypto: Sub package "vibe-d:crypto" doesn't exist.
  Error getting sub package vibe-d:mongodb: Sub package "vibe-d:mongodb" doesn't exist.
  Error getting sub package vibe-d:inet: Sub package "vibe-d:inet" doesn't exist.
  Error getting sub package vibe-d:diet: Sub package "vibe-d:diet" doesn't exist.
  Error getting sub package vibe-d:web: Sub package "vibe-d:web" doesn't exist.
  Error getting sub package vibe-d:tls: Sub package "vibe-d:tls" doesn't exist.
  Found dependency vibe-d:stream 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency openssl 1.1.5+1.0.1g
    Found dependency botan 1.12.9
      Found dependency botan-math 1.0.3
  Error getting sub package vibe-d:http: Sub package "vibe-d:http" doesn't exist.
  Error getting sub package vibe-d:mail: Sub package "vibe-d:mail" doesn't exist.
Refreshing local packages (refresh existing: false)...
Looking for local package map at /var/lib/dub/packages/local-packages.json
Looking for local package map at /home/seb/.dub/packages/local-packages.json
Try to load local package map at /home/seb/.dub/packages/local-packages.json
  Error getting sub package vibe-d:redis: Sub package "vibe-d:redis" doesn't exist.
  Found dependency vibe-d:data 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency vibe-d:utils 0.8.0-rc.4+commit.2.g6ae5c111
  Found dependency vibe-d:core 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency libevent 2.0.2+2.0.16
    Found dependency libasync 0.8.3
      Found dependency memutils 0.4.9
    Found dependency vibe-core 1.0.0
      Found dependency eventcore 0.8.12
        Found dependency taggedalgebraic 0.10.7
  Error getting sub package vibe-d:textfilter: Sub package "vibe-d:textfilter" doesn't exist.
  Error getting sub package vibe-d:crypto: Sub package "vibe-d:crypto" doesn't exist.
  Error getting sub package vibe-d:mongodb: Sub package "vibe-d:mongodb" doesn't exist.
  Error getting sub package vibe-d:inet: Sub package "vibe-d:inet" doesn't exist.
  Error getting sub package vibe-d:diet: Sub package "vibe-d:diet" doesn't exist.
  Error getting sub package vibe-d:web: Sub package "vibe-d:web" doesn't exist.
  Error getting sub package vibe-d:tls: Sub package "vibe-d:tls" doesn't exist.
  Found dependency vibe-d:stream 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency openssl 1.1.5+1.0.1g
    Found dependency botan 1.12.9
      Found dependency botan-math 1.0.3
  Error getting sub package vibe-d:http: Sub package "vibe-d:http" doesn't exist.
  Error getting sub package vibe-d:mail: Sub package "vibe-d:mail" doesn't exist.
Checking for missing dependencies.
External sub package vibe-d:redis 0.8.0-rc.4+commit.2.g6ae5c111 not found.
Using fixed selection libevent 2.0.2+2.0.16
Using fixed selection libasync 0.8.3
Using fixed selection memutils 0.4.9
Using fixed selection vibe-core 1.0.0
Using fixed selection eventcore 0.8.12
Using fixed selection taggedalgebraic 0.10.7
External sub package vibe-d:textfilter 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:crypto 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:mongodb 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:inet 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:diet 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:web 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:tls 0.8.0-rc.4+commit.2.g6ae5c111 not found.
Using fixed selection openssl 1.1.5+1.0.1g
Using fixed selection botan 1.12.9
Using fixed selection botan-math 1.0.3
External sub package vibe-d:http 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:mail 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:redis 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:textfilter 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:crypto 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:mongodb 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:inet 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:diet 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:web 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:tls 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:http 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:mail 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:redis 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:textfilter 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:crypto 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:mongodb 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:inet 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:diet 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:web 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:tls 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:http 0.8.0-rc.4+commit.2.g6ae5c111 not found.
External sub package vibe-d:mail 0.8.0-rc.4+commit.2.g6ae5c111 not found.
Refreshing local packages (refresh existing: false)...
Looking for local package map at /var/lib/dub/packages/local-packages.json
Looking for local package map at /home/seb/.dub/packages/local-packages.json
Try to load local package map at /home/seb/.dub/packages/local-packages.json
  Error getting sub package vibe-d:redis: Sub package "vibe-d:redis" doesn't exist.
  Found dependency vibe-d:data 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency vibe-d:utils 0.8.0-rc.4+commit.2.g6ae5c111
  Found dependency vibe-d:core 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency libevent 2.0.2+2.0.16
    Found dependency libasync 0.8.3
      Found dependency memutils 0.4.9
    Found dependency vibe-core 1.0.0
      Found dependency eventcore 0.8.12
        Found dependency taggedalgebraic 0.10.7
  Error getting sub package vibe-d:textfilter: Sub package "vibe-d:textfilter" doesn't exist.
  Error getting sub package vibe-d:crypto: Sub package "vibe-d:crypto" doesn't exist.
  Error getting sub package vibe-d:mongodb: Sub package "vibe-d:mongodb" doesn't exist.
  Error getting sub package vibe-d:inet: Sub package "vibe-d:inet" doesn't exist.
  Error getting sub package vibe-d:diet: Sub package "vibe-d:diet" doesn't exist.
  Error getting sub package vibe-d:web: Sub package "vibe-d:web" doesn't exist.
  Error getting sub package vibe-d:tls: Sub package "vibe-d:tls" doesn't exist.
  Found dependency vibe-d:stream 0.8.0-rc.4+commit.2.g6ae5c111
    Found dependency openssl 1.1.5+1.0.1g
    Found dependency botan 1.12.9
      Found dependency botan-math 1.0.3
  Error getting sub package vibe-d:http: Sub package "vibe-d:http" doesn't exist.
  Error getting sub package vibe-d:mail: Sub package "vibe-d:mail" doesn't exist.
Checking for upgrades.
Using cached upgrade results...
Non-optional dependency vibe-d:crypto of vibe-d not found in dependency tree!?.

Err, yeah... forgot to check in tls/dub.sdl and didn't remove the old ssl dependencies. Good point ;-)
Auto-cancel is enabled, but AppVeyor is simply idle.

Okay, I'll just rebase and merge in the hope that AppVeyor will then run on the 0.8.0 branch. If all breaks down, this can still be reverted.


[GEP-15] Bastion Management and SSH Key Pair Rotation

How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
Adds a GEP for managing bastions and SSH key pair rotation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
NONE

/assign

@mvladev Assuming what you suggest is implemented, what about the SSH access from the bastion to the shoot worker nodes? How would this look like?

@mvladev do we really want to hand out the user's id_token to the bastion? In case an attacker is under the control of the bastion, he could steal the user's token and impersonate the user against the garden cluster.

@mvladev do we really want to hand out the user's id_token to the bastion? In case an attacker is under the control of the bastion, he could steal the user's token and impersonate the user against the garden cluster.

You are right. I guess in this case the identity should come from the Shoot cluster and not the Gardener cluster.

@mvladev Assuming what you suggest is implemented, what about the SSH access from the bastion to the shoot worker nodes? How would this look like?

I guess in this case the user should use the SSH key from the cloud provider.

It uses the Shoot identity for authentication to the Bastion host
It uses the SSH key stored on the cloud provider for Bastion -> Node SSH

I guess in this case the identity should come from the Shoot cluster and not the Gardener cluster.

@mvladev but this would mean that in case we need to debug a shoot node we are dependant on the availability of the shoot api server, not sure if we really want to have this dependency

I guess in this case the user should use the SSH key from the cloud provider.

@mvladev @petersutter We want to rid us of the infrastructure ssh keys, because they cannot be revoked/rotated (e.g. on AWS), so that's not acceptable (anymore).

as discussed with @vlerenc and @ThormaehlenFred I will remove the pgp encryption and ssh key pair generation part and instead we will use the user's public SSH key.
If required a process can be established where operators are asked to regularly rotate their SSH keys or gardenctl could manage this part. Maybe not from the beginning on but we could add that later as feature

@petersutter I am rewriting some bits already. Give me a few more minutes.

/invite @xrstf
@vlerenc @mvladev can you please have another look so that we can get this in by tomorrow?

@petersutter Have you taken over the suggestions (I see my comments as outdated only, but haven't checked in detail).
@rfranzke If yes, I have read/updated it 2h ago and am fine with the even more simplified solution.

Thanks @vlerenc, can you then approve the PR or dismiss your review? Currently, it would still block a merge.

Yes @vlerenc I have taken over your suggestions, thanks

/merge squash

@mvladev this sounds very slick, I like it! Hoped you had this idea a bit earlier :D But anyhow, I still need to think it through but I feel this is a much better approach 👍

Ok I found one downside of this approach. With the current proposal, no other operator can access the bastion and thus access the node.
With your latest proposal, any other operator could access the bastion and the seeds by fetching the shoot-ca from the ShootState and by creating his own keys.
Also we would also need to rotate the shoot-ca on a regular basis

Even though @mvladev's proposal is more elegant, I would propose to leave the Design as is with the following reasons:

The current design is much simpler, needing less implementation effort
@mvladev's proposal has the disadvantage that, in case an operator has access to the private key of the ssh-ca he could sneak into a running bastion by just creating a new ssh key using the ssh-ca.
If there is really a need to enforce the rotation of public ssh keys on the server side, the public ssh keys could be tracked and the creation of Bastion resources could be rejected in case the keys are being re-used.

@mvladev What's the status of your review? It seems that the "easier" approach (as currently proposed in the GEP) is in favor of most of the people. @petersutter had collected agreement for it also from @vlerenc and @ThormaehlenFred in a chat last week already, and I'm fine with it for now as well (it's good enough to get started now, it can still potentially be improved in the future).
Even if you still have doubts and don't want to approve, can you then please at least dismiss your review so that it can be merged and so that the implementation can be started?

I still believe that the extra implementation cost would make things work better in the long run:

with the current approach - you leave SSH key rotation to the end-user. This is something most people do not do - you can check it yourself - when was the last time you changed your ssh key?
ls -lah ~/.ssh/id_rsa*
-r-------- 1 foo 3.4K Oct  4  2018 /Users/foo/.ssh/id_rsa
-rwxr-xr-x 1 foo  747 Oct  4  2018 /Users/foo/.ssh/id_rsa.pub

with the SSH CA approach, the same Bastion can be used by multiple operators - there is no need to associate a Bastion with a user.

If there is really a need to enforce the rotation of public ssh keys on the server side, the public ssh keys could be tracked and the creation of Bastion resources could be rejected in case the keys are being re-used.

This would be a bad idea because we have to have garbage collecction and store the used keys somewhere. WIth keys issued by the Gardener, you do not have this problem.

@mvladev's proposal has the disadvantage that, in case an operator has access to the private key of the ssh-ca he could sneak into a running bastion by just creating a new ssh key using the ssh-ca.

SSH to the nodes is the least concern in such scenario - the entire cluster might be compromised without the need for SSH keys.


Repo sync for protected CLA branch

The pull request is created from master637334564636764920 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Determine the option name to specify repo root directories for ChromeOS and Android

Currently they are --cros and --arc, but @brandonpollack23 suggests changing them to --cros-repo and --arc-repo.
Context: https://github.com/google/lium/pull/197

@brandonpollack23
Please reply to this comment https://github.com/google/lium/pull/197#issuecomment-1860338164 here.

We decided not to change the arg parameter name to make it simple as lium is a front-end command line tool used by hand.


Support npm modules

https://doc.deno.land/npm:express@4

Outside of potentially aliasing, what is wrong with the current support?
https://doc.deno.land/https://esm.sh/preact@10


BREAKING: Renaming expanded to initialExpanded on Tile

LiveURL: https://orbit-components-breaking-tile-expanded.surge.sh

Will be part of #1381


Introduce debug option to weave script

Now that the bulk of the weave script executes inside the weaveexec container, it's more difficult to access information about its execution for debugging purposes. Add a debug option to the script that:

Starts weaveexec container without --rm option so logs can be inspected
Enables shell debug via set -x

Perhaps have a WEAVE_DEBUG env var, which also gets passed to the "inner" script. That way if we feel the need to modify that script's behaviour for debugging, we can.

re "shell debug"... this is for the "inner" script; we don't need anything special for the outer script, since that is easily traced with sh -x ./weave ... already.

This turned out to be much simpler than I expected. I'm setting -x in the script when WEAVE_DEBUG is present, and pass the env var along in the weavexec invocation, so the embedded script in turn does the same. This results in both the outer and inner script's output appearing in stderr.
I decided to include the outer script execution since we will generally want to see both the outer and inner, and it is easier to ask users to do one thing instead of two.
There is no need to drop the --rm since all the debug output goes to stderr.


fixed license

Hello,
I noticed that you incorrectly setup the license for this repo. You need to include the license as part of this repo so that it is included when people clone it. The MIT license also requires a name and year of which were not included as there was not LICENSE file.
You can merge this pull request or you can make the changes on your own.

Thx @Darin755 :heart:


iconz

Overview
Adds new iIcons for Form updates

PR Checklist

[x] Related to designs: https://www.figma.com/file/9Ke4l9EdIup7kiB3KsbEHx/Form-Inputs-Components?node-id=1218%3A0
[x] Related to JIRA ticket: gm-152
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-icons@4.1.1-alpha.d39e4f.0@codecademy/gamut-kit@0.2.1-alpha.d39e4f.0@codecademy/gamut-labs@10.4.7-alpha.d39e4f.0@codecademy/gamut@26.0.2-alpha.d39e4f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6042810a92199c1295934b6d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@4.1.1-alpha.86476c.0@codecademy/gamut-kit@0.2.4-alpha.86476c.0@codecademy/gamut-labs@10.5.3-alpha.86476c.0@codecademy/gamut@26.0.2-alpha.86476c.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6042a59e93462c00cd67f5d4--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@4.1.1-alpha.3c7a25.0@codecademy/gamut-kit@0.2.4-alpha.3c7a25.0@codecademy/gamut-labs@10.5.3-alpha.3c7a25.0@codecademy/gamut@26.0.2-alpha.3c7a25.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6042ae87707d1c08d9a3da73--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@4.1.1-alpha.844b4b.0@codecademy/gamut-kit@0.2.4-alpha.844b4b.0@codecademy/gamut-labs@10.5.3-alpha.844b4b.0@codecademy/gamut@26.0.2-alpha.844b4b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6042b4d51d11bb0b0fada447--gamut-preview.netlify.appDeploy Logs


Images Do not load/show up at runtime, Error loading Asset

Hello, I just started coding in Flutter(Around a week since) and I cant seem to load images into my app.
Anytime I call an Image asset into my app it never shows up, it keeps saying that it cant load the asset: Error loading asset "Unable to load assets:assets/images/kenkaneki"
this is a section of my code:

import 'package:flutter/material.dart';

class ImageBanner extends StatelessWidget{
  final String _assetPath;

  ImageBanner(this._assetPath);

  @override
  Widget build(BuildContext context){
     return Container(
        constraints: BoxConstraints.expand(
          height:150.2,
          width: 130.0
        ),
        decoration: BoxDecoration(color: Colors.grey),
          child: Image.asset(
            _assetPath,
            fit: BoxFit.cover,
          ),
      );
  }
}

class LocationDetail extends StatelessWidget{
  @override
  Widget build(BuildContext context){
    return Scaffold(
      appBar: AppBar(
        title: Text('Hello'),
      ),
      body:Column(
        mainAxisAlignment: MainAxisAlignment.start,
        crossAxisAlignment: CrossAxisAlignment.stretch,
        children: [
          ImageBanner("assets/images/kenkaneki"),
         TextSection("Memorii","Piglet"),
         TextSection("Summm","mewmew"),
         TextSection("Sumumumu","UwU"),
        ]
    )
    );
  }
}

and this is my pubsec.yaml file:
name: mewmewuwu
description: A new Flutter project.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2

dev_dependencies:
  flutter_test:
    sdk: flutter

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
      - assets/images/

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  # fonts:
  #   - family: Schyler
  #     fonts:
  #       - asset: fonts/Schyler-Regular.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages

I really need help with this issue urgently
Thank you.
Also my asset file IS loaded properly and I have tried the flutter clean.
I also want to know if the image size affects anything.

You have not specified the extension of the image. Try passing the _assetPath with the image extension. If the error still persists please attach a screenshot of your directory structure.

I have already tried that. I even tried using a different directory to load the image.

name: phoenix
description: A new Flutter project.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2

dev_dependencies:
  flutter_test:
    sdk: flutter

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
     - assets/icons/008-tshirt.png
     - assets/images/
  #  - images/a_dot_burr.jpeg
  #  - images/a_dot_ham.jpeg

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  fonts:
       - family: Lora
         fonts:
           - asset: assets/fonts/Lora-Bold.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages

import 'package:flutter/material.dart';

class HorizontalList extends StatelessWidget{
  @override
  Widget build(BuildContext context){
    return Container(
      height: 130,
      child: ListView(
        scrollDirection: Axis.horizontal,
        children: <Widget>[
          Category('assets/icons/008-tshirts.png', 'T-Shirs')
        ]
      ),
    );
  }
}

class Category extends StatelessWidget {
  final String image_location;
  final String image_caption;

  Category(this.image_location, this.image_caption );
  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(2.0),
      child: InkWell(
        onTap: (){},
        child:Container(
          width: 159.0,
          height: 60.0,
        child: ListTile(
          title: Image.asset(image_location),
          subtitle: Text(image_caption),
        )
        ),
      ),
    );
  }
}

my pubsec.yaml file and program code.

name: issues_app
description: Flutter application to analyze issues.
The following defines the version and build number for your application.
A version number is three numbers separated by dots, like 1.2.43
followed by an optional build number separated by a +.
Both the version and the builder number may be overridden in flutter
build by specifying --build-name and --build-number, respectively.
In Android, build-name is used as versionName while build-number used as versionCode.
Read more about Android versioning at https://developer.android.com/studio/publish/versioning
In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
Read more about iOS versioning at
https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1
environment:
sdk: ">=2.1.0 <3.0.0"
dependencies:
flutter:
sdk: flutter
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.2
dev_dependencies:
flutter_test:
sdk: flutter
For information on the generic Dart part of this file, see the
following page: https://dart.dev/tools/pub/pubspec
The following section is specific to Flutter.
flutter:
The following line ensures that the Material Icons font is
included with your application, so that you can use the icons in
the material Icons class.
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:

assets/images/
assets/icons/

- images/a_dot_burr.jpeg
- images/a_dot_ham.jpeg
An image asset can refer to one or more resolution-specific "variants", see
https://flutter.dev/assets-and-images/#resolution-aware.
For details regarding adding assets from package dependencies, see
https://flutter.dev/assets-and-images/#from-packages
To add custom fonts to your application, add a fonts section here,
in this "flutter" section. Each entry in this list should have a
"family" key with the font family name, and a "fonts" key with a
list giving the asset and other descriptors for the font. For
example:
fonts:
- family: Lora
fonts:
- asset: assets/fonts/Lora-Bold.ttf
- asset: fonts/Schyler-Italic.ttf
style: italic
- family: Trajan Pro
fonts:
- asset: fonts/TrajanPro.ttf
- asset: fonts/TrajanPro_Bold.ttf
weight: 700

For details regarding fonts from package dependencies,
see https://flutter.dev/custom-fonts/#from-packages

description: Flutter application to analyze issues.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2

dev_dependencies:
  flutter_test:
    sdk: flutter

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
  - assets/images/
  - assets/icons/
  #  - images/a_dot_burr.jpeg
  #  - images/a_dot_ham.jpeg

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
#  fonts:
#  - family: Lora
#    fonts:
#    - asset: assets/fonts/Lora-Bold.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages```

It's because of the spacing in the pubspec.yaml file. Try with the file I've given above. P.S: Don't forget to change the name. And I've commented out fonts.

Ok I'll try it out

it still didn't work. Do you think maybe its an issue with the emulator

How do you load Images on your Flutter app?

I tried with your code. The only problem I found was the spacing in the YAML file. I fixed it and it worked fine. I even maintained the same directory structure you've shown above.

Hey! I tried what you did, then I looked into some other issues and I found one where the guy was having issues because the image name was something like 1_image and it was working but when he changed it to 01_image it gave him the Unable to load assets error so I tried it and it worked! Thanks for your help it really means a lot.


Need a way to make edge lengths the same.

Would be cool if there was a way to make all edges the same pixel length.

Hi @angelotc, thanks for your question, but I think this is first a question for Graphviz, not pydot. Pydot is just an interface to Graphviz. See Graphviz documentation, on attributes for examples. Also, questions like these are better asked on a Q&A sites like StackOverflow (tag graphviz) or forums rather than on an issue tracker.
Still, I had a look at https://github.com/angelotc/Ford-Fulkerson-Implementation, where your question seems to originate from.
I inspected the DOT-output it generates by inserting the following line:
            graph.write_raw(f'{i}.raw.dot')

This results in the following DOT-output:
digraph G {
rankdir=LR;
1 -> 2  [color=blue, fontsize="10.0", label=9, labelfontcolor="#009933"];
1 -> 3  [color=blue, fontsize="10.0", label=7, labelfontcolor="#009933"];
2 -> 3  [color=blue, fontsize="10.0", label=8, labelfontcolor="#009933"];
3 -> 2  [color=blue, fontsize="10.0", label=3, labelfontcolor="#009933"];
2 -> 4  [color=blue, fontsize="10.0", label=5, labelfontcolor="#009933"];
3 -> 4  [color=blue, fontsize="10.0", label=4, labelfontcolor="#009933"];
3 -> 5  [color=blue, fontsize="10.0", label=2, labelfontcolor="#009933"];
5 -> 4  [color=blue, fontsize="10.0", label=3, labelfontcolor="#009933"];
5 -> 6  [color=blue, fontsize="10.0", label=6, labelfontcolor="#009933"];
4 -> 6  [color=blue, fontsize="10.0", label=10, labelfontcolor="#009933"];
}

If I run that through Graphviz manually:
dot -Tpng 0.raw.dot >0.png

I get the same image as you posted:

I guess you expect the result to look a bit more orderly, like many of the examples in https://commons.wikimedia.org/wiki/Category:Ford-Fulkerson's_algorithm, for example this one by Ekreckel on Wikimedia Commons:

Note, though, that not all edges can be the same length. The diagonal edge between 2 and 5 (or between 3 and 4 in your example) will always be longer than the other edges.
Anyway, if I now modify the DOT-file by adding some subgraphs with attribute rank at the bottom:
digraph G {
rankdir=LR;
1 -> 2  [color=blue, fontsize="10.0", label=9, labelfontcolor="#009933"];
1 -> 3  [color=blue, fontsize="10.0", label=7, labelfontcolor="#009933"];
2 -> 3  [color=blue, fontsize="10.0", label=8, labelfontcolor="#009933"];
3 -> 2  [color=blue, fontsize="10.0", label=3, labelfontcolor="#009933"];
2 -> 4  [color=blue, fontsize="10.0", label=5, labelfontcolor="#009933"];
3 -> 4  [color=blue, fontsize="10.0", label=4, labelfontcolor="#009933"];
3 -> 5  [color=blue, fontsize="10.0", label=2, labelfontcolor="#009933"];
5 -> 4  [color=blue, fontsize="10.0", label=3, labelfontcolor="#009933"];
5 -> 6  [color=blue, fontsize="10.0", label=6, labelfontcolor="#009933"];
4 -> 6  [color=blue, fontsize="10.0", label=10, labelfontcolor="#009933"];
{ rank=source 1 }
{ rank=same 2 3 }
{ rank=same 4 5 }
{ rank=sink 6 }
}

Then run that through Graphviz:
dot -Tpng 0-rank.raw.dot >0-rank.png

The image looks more like what you probably expect:

To get this result from your script, use pydot.Subgraph. A very rudimentary example of what you can insert at the end of your script to generate the necessary subgraphs:
            subg = pydot.Subgraph(rank="source")
            subg.add_node(n_dict["1"])
            graph.add_subgraph(subg)

            subg = pydot.Subgraph(rank="same")
            subg.add_node(n_dict["2"])
            subg.add_node(n_dict["3"])
            graph.add_subgraph(subg)

            subg = pydot.Subgraph(rank="same")
            subg.add_node(n_dict["4"])
            subg.add_node(n_dict["5"])
            graph.add_subgraph(subg)

            subg = pydot.Subgraph(rank="sink")
            subg.add_node(n_dict["6"])
            graph.add_subgraph(subg)

            graph.write_raw(f'{i}.raw.dot')
            graph.write_png(f'{i}.png')

Of course, you will probably want to somehow make this less hard-coded, possibly create the subgraphs while adding the nodes and edges already, but this is just to give you an example of starting with the desired DOT-output and then working your way back to generating that desired DOT-output using pydot.
There may be other ways to tell Graphviz what layout you want. Check the Graphviz documentation mentioned at the top of this post, try it out from the command line first, then work your way back to pydot.

Thank you, Peter. I wanted to make an instructional youtube video on how Ford Fulkerson worked, but have lost motivation to do so recently. I will keep this in mind when I get back into business.

Yes, it's difficult to stay motivated these days, I know all about it. Hope you can keep it up.
Shall we close this issue? You can always open a new one if you find a real bug or have a feature request specifically for pydot.


Hook doesn't allow configuration updates at runtime

Description
In large kedro projects where you have multiple different pipelines working in sequence / paralell you may want to override certain kedro-mlflow settings like tracking.experiment.name during runtime. For example you may want to do something like
kedro run --pipeline pipeline_1 --params mlflow.tracking.experiment.name=pipeline_1

to make sure that pipeline_1 results are tracked and stored to the right experiment name. The current implementation of MlflowHook, which looks something like this
...
try:
    conf_mlflow_yml = context.config_loader.get("mlflow*", "mlflow*/**")
except MissingConfigException:
    ...
    conf_mlflow_yml = {}
mlflow_config = KedroMlflowConfig.parse_obj(conf_mlflow_yml)
  ...

doesn't provide any other way to set the experiment name except for keeping one individual kedro configuraiton per pipeline.
Possible Implementation
I suggest, and can support in implementing, that a method call is added right before
mlflow_config = KedroMlflowConfig.parse_obj(conf_mlflow_yml)

where the mlflow_config object is updated based on all parameters starting with "mlflow" from context.params.
Any ideas?

Hi @Galileo-Galilei.
I agree writing it along every command line would be tedious, but in production scenarios this is carried out by some orchestrator anyway. Regarding your last comment with kedro run --env=<STAGING/PROD/>, that what I already use to handle config in my different environments. However, since my project has 20+ pipelines, having one mlflow.yml for every pipeline and envirment would force me to have 40-60 different mlflow.ymls for different pipelines in different environments.
I suggest we move along with a modified version of your suggestion where the user may have certain settings parsed at runtime by using template strings and environment variables. Example:
´experiment: "prefix-${MLFLOW_ENV_1}_${MLFLOW_ENV_2}-suffix"`
Benefits would be high flexability and high compatabilityt with orchestration tools (ENVs works everywhere). What do you think? Happy to write the PR if you guide me where you want the code to be located.

Hi @kasperjanehag, I understand your issue about multiple combination of pipeline x env and I suspected something like that. I have some good and bad news :)
Environment variables are already supported...
The good news is that what you suggest (combining fixed string and templated environment variables) is already possible: kedro-mlflow leverages the ConfigLoader of your kedro project, so you can even use jinja2 inside the configuration file and itr will be properly parsed. You just need to configure your kedro project to accept environment variables:
# settings.py

from kedro.config import TemplatedConfigLoader  # new import
import os # new import

CONFIG_LOADER_CLASS = TemplatedConfigLoader
CONFIG_LOADER_ARGS = {
    "globals_dict": os.environ,
    }
}

and your above example will work automatically. Even better, I think this will become the default in kedro==0.18.5 which should be released soon
... but runtime CLI params are not
The bad news is that if you also want to use the pipeline name as in the original question (e.g. use something like ${PIPELINE_NAME} where pipeline name is the one given to the CLI, this is much harder. The TemplatedConfigLoader does  not add to its globals_dict the runtime cli arguments. By far the easiest way to have this supported is to modify kedro itself to support such a use case. Open an issue in kedro's repo, and I'll support the feature request as much as I can.
That said, it is unlikely they release the feature soon so I may support this at the kedro-mlflow's level. The idea is to modify at runtime the config loader in above mentioned lines (https://github.com/Galileo-Galilei/kedro-mlflow/blob/a4276b345bfc7e428d6c8022bf5b6429b91ad942/kedro_mlflow/framework/hooks/mlflow_hook.py#L63) to update the global_dict with the run_params arguments of before_pipeline run. However this is tricky because the 2 hooks need to interact and I'd like to avoid that if possible.

This feature will likely wait the implementation of this issue on kedro's side: https://github.com/kedro-org/kedro/issues/2866

For the record, this is now possible with the runtime_params resolver with OmegaConfigLoader. I need to document it. Further reference can be found on slack


Json size is greater than 2 MB

Question
we are using cosmos DB and its size limit is 2MB for one document.
what will happen if my data crosses the 2MB size?
can you please explain this in details

The FHIR Server will error with an Http 413, request entity too large. There is an E2E test case for this:
https://github.com/microsoft/fhir-server/blob/befce04476d80f8a5d937fd9c42706fc40363ca9/test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/CreateTests.cs#L81-L101

Is FHIR Api handle json size which is greater than 2 MB OR we need to provide json which is less than 2 MB?
How to handle Json which has size greater than 2 MB?

Hi @shahedaAnsari, when using the CosmosDB provider the per-item limit is 2mb. If you need to store items larger than 2mb then you should use the SQL Provider

@shahedaAnsari - Closing the issue as the question is answered. Please feel free to contact us for any further assistance.


website: In 'hello world', include GitHub repo and clarify user name

Documentation webpage Getting Started—in section Test your installation—currently says:

Next, make the directories src/github.com/_user/hello inside your workspace (if you use GitHub, substitute your _user name for user),

The following would be better:

Next, make the directories src/github.com/user/_try-golang/hello inside your workspace (if you use GitHub, substitute your _GitHub user name for user),

(The bolding is just for emphasis in this issue.)
The new text aids novice Go users, in two ways:

Novices will wonder where their GitHub repo names fit in the pattern. This will slow them down, and be frustrating. The new text supplies the answer (try-golang, in this case).
"User name" seems (in effect) ambiguous here.

 For them (as well as generally, outside Go), the most commonly used context for the term "user name" is OS X, Linux or Windows—not GitHub.
Likely they'd assume the former (as I did). They can figure it out, but why include this stumbling block in the first place?
The new text specifies it means the GitHub user name.
This change aims to help smooth the path, for new Go language users.

What version of Go are you using (go version)? N/A
What operating system and processor architecture are you using (go env)? N/A
What did you do? N/A
What did you expect to see? N/A
What did you see instead? N/A

That section has been rewritten for go1.8 after the introduction of default GOPATH, and there's now no reference to github.com/usr paths

Create your workspace directory, $HOME/go. (If you'd like to use a different directory, you will need to set the GOPATH environment variable; see How to Write Go Code for details.)
Next, make the directory src/hello inside your workspace, and in that directory create a file named hello.go that looks like:

So this is fixed.


feat: hardfork support

Right now we only document the latest supported features. This is ok but doesn't scale nicely, consider:

All chains import mainnet data as their base, then modify it
Mainnet adds a new opcode or transaction type
Now you have to go into all other chains and remove that

An alternative approach would be for mainnet data to have an array of hard forks that supported that e.g. opcode (or, just the earliest hard fork), and other chains would filter the list based off the hard fork data. This probably would scale much better
This hard fork data can also be shown in the diffs

Yea I think you're right we'll need a list of all hard forks for that reason


Origin should not include path information

From the Mozilla documents:
The origin is a URI indicating the server from which the request initiated.  It does not include any path information, but only the server name.
I think that sending the absolute URL is violating the spec. Some servers reject an origin with path information as malformed.

#288 is merged. Thanks again!


KotlinNullPointerException when run programmatically from detekt

Also see the related https://github.com/arturbosch/detekt/issues/1803. The line
https://github.com/pinterest/ktlint/blob/b41aa2281f271d80255da727b838c0a111b6c293/ktlint-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/FinalNewlineRule.kt#L18
results in
Analyzing 'C:\Dev\oss-review-toolkit\spdx-utils\src\main\kotlin\SpdxLicenseException.kt' led to an exception.
The original exception message was: kotlin.KotlinNullPointerException
Running detekt '1.1.1' on Java '9.0.4+11' on OS 'Windows 10'.
If the exception message does not help, please feel free to create an issue on our github page.
java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)
java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:283)
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1603)
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
com.pinterest.ktlint.ruleset.standard.FinalNewlineRule.visit(FinalNewlineRule.kt:18)
io.gitlab.arturbosch.detekt.formatting.FormattingRule.apply(FormattingRule.kt:62)

when running
./gradlew --rerun-tasks :spdx-utils:detekt

on the detekt-ktlint-issue branch of https://github.com/heremaps/oss-review-toolkit.

From what I see Ktlint.EDITOR_CONFIG_USER_DATA_KEY data should be always available in node. I will try to investigate this next week.

Thanks @Tapchicoma. IIRC, the private injectUserData is only called by lint and format, both of which are not called when using ktlint programmatically by detekt. However, detekt seem to insert EDITOR_CONFIG_USER_DATA_KEY explicitly, but for some reason that does not seem to work. So maybe the issue still is on the detekt side after all.

I see that editorconfigUpdater() in detekt code could return null. In this case EDITOR_CONFIG_USER_DATA_KEY will not be added to node.

Correct, I've meanwhile filed https://github.com/arturbosch/detekt/issues/2339 as I now believe the issue is in detekt, not in ktlint (although ktlint could and should make it more fool-proof to not run into this issue when calling ktlint programmatically by not blindly assuming EDITOR_CONFIG_USER_DATA_KEY to be present in any case).


Turkish translations added

Purpose

Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
[ ] Yes
[✓] No

Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
[ ] Yes
[✓] No

Type of change
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[✓] Other: Add new language

Code quality checklist
See CONTRIBUTING.md for more details.

[] The current tests all pass (python -m pytest).
[ ] I added tests that prove my fix is effective or that my feature works
[ ] I ran python -m pytest --cov to verify 100% coverage of added lines
[ ] I ran python -m mypy to check for type errors
[ ] I either used the pre-commit hooks or ran ruff and black manually on my code.

@microsoft-github-policy-service agree

@mertcakdogan Thanks for the PR! Will you be able to help with future Turkish translations? We sometimes have new strings when features are added.

@pamelafox Thanks for reply, I'm native Turkish speaker, so please feel free to tag me on PRs that add new Turkish strings if needed :))

@mertcakdogan Fantastic, thanks for the contribution and translations help! Merging.


Matcher for "should be ignoring given field names"

Can we get a matcher for checking equality, without checking certain fields of the object.
Such as AssertJ's isEqualToIgnoringGivenFields method.
This is useful when I am trying to do a shouldBe check on two objects which have a createdOn date/time field. It would be nice to be able to say something like obj1.shouldBeIgnoringFields(obj2, "createdOn").

obj.shouldBeEqualUsingFields(obj2, "name", "age", "job")
obj.shouldBeEqualIgnoringFields(obj2, "location")

I think we can add this to 3.3.2

I don't think we should use strings to field names

That works for private fields tho, but I think we could do something like
obj.shoudBeEqualUsingFields(obj2, obj.name, obj.age, obj.job)

And reflect the fields to ignore the same field

Using strings hides the code behind it, and is subject to breaking when one renames the field

If you can get a function reference by just doing obj.name then yes that's better.

I'm almost sure we can

Thanks, excited to start using it!

Closed via #715


Highlights do not show for TSV9 en-tn

In the latest build on Dev- translationCore Create - v1.8 build 197-7a6b5de, highlighting does not show for TSV9 en-tn files.
Highlighting was fixed to work well in TSV7 format by column mapping... we found where for TSV7 it was off by a column or two.
But this change broke the highlighting for TSV9 file format.

Highlighting is working fine for TSV9 as well as TSV7 tN in translationCore Create - v1.8 build<PHONE_NUMBER>.


Output size limit hit.

seems that we've hit an output size limit in the CFT:  "Cannot export output ImageVersions with length 1205. Max length of 1024 exceeded."

PR merged, release published


Binary install on Ubuntu 18.04 missing some test macros?

I recently switched from a source build to installing the binary via apt install cpputest on Ubuntu 18.04 and am getting compiler errors complaining about CHECK_COMPARE not existing.
error: ‘CHECK_COMPARE’ was not declared in this scope
...
note: suggested alternative: ‘CHECK_FALSE’

After some grepping and inspection it seems the UTestMacros.h I get from the binary install is missing bits that are in the source branches.  A Git blame says that the CHECK_COMPARE define in the source is over 8 years old so I don't really know whats up.
Any thoughts?

The Ubuntu version is outdated (v3.8 from 2016). The CHECK_COMPAE() macro isn't available in this version yet.
It has been introduced with 867ea44260ec4cabec2e0b55b9426bb15ace6169.

Will try to release 3.9 soon. Closing this for now.


ihave added in yaml but when i run my project happen this problem

CMake Error at flutter/ephemeral/.plugin_symlinks/cbl_flutter_ce/windows/CMakeLists.txt:28 (message):
Could not install Couchbase Lite native libraries:
ihave added in yaml but when i run my project happen this problem
cbl: ^3.0.0
cbl_flutter: ^3.0.0
cbl_flutter_ce: ^3.0.0


Pressure test cases wanted

https://github.com/sofastack/sofa-mosn/blob/93fbacb4b439ec98999812e72d45e7614b70ab85/docs/features/0.2.0/IOOptimization.md#L184-L190
As the doc shows above. How can we achieve such performance. How to reproduce. (IO协程 case is preferred)

What is the performance data you tested?
This scene that closed the log


is there a way to warm start a mip model using doopl?

is there a way to warm start a mip model using doopl?

Hello,
doopl is just an api to run OPL from python.
So if you want to warm start mip models, just use cplex.readMIPStarts() in your OPL model.
Best regards,


How about add support for persian(Jalali) calendar?

Hello
Can Any One Help Me To add support for persian(Jalali) calendar ?
Like This :
https://github.com/smalot/bootstrap-datetimepicker/issues/116

I have the same issue please help

locale support is handled by momentjs. I'd suggest looking at an existing local file and change it to your needs. If you make a file, you should submit it to moment so that others can benefit from it

no, local support only change it,s language to persian, i need to change date to jalali (shamsi).
in top link available it,s convertor to jalali date, but only work in bootstrap-datetimepicker.js, it no work in moment.js
can you help me to how change date to jalalidate ?
thanks.

Hi,
I Have the same issue,
the Persian calendar system (jalali) is deferent from Georgian system.
I found moment.js convertor to jalali here: https://github.com/jalaali/moment-jalaali
this works fine!
please let me know how can i use "moment-jalali" to this component?
I have a suggestion to add new option as "Calendar" to "bootstrap-datetimepicker" new version 5 to change by calendar systems and develope famous calendar systems like jalali (https://github.com/jalaali/moment-jalaali ), hijri (https://github.com/xsoh/moment-hijri) etc.
thanks,
Alireza

+1


Chore: updated catalog index file

Description
Updating the catalog index file. It appears I missed to push in my last commit.
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

/cc @bparees

/lgtm
/approve


⚠ Bofrost.at has degraded performance

In 33aa387, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1740 ms

Resolved: Bofrost.at performance has improved in c77f897 after 31 minutes.


Refactor the server task into several operation-specific tasks

On my branch issue3, I created a class that extends ServerTask for each server operation. Each class only sets the operation attribute to its respective operation and executes the do-Operation()- method. This avoids the rewriting of the same code, lets the Maven and Gradle project still work with the ServerTask class and provides backwards compatibility. The inconvenient is that the issue is still present, the user can write something like this:
<wlp:serverStop id="idMyServer" installDir="${wlp_install_dir}" template="notInUse" />

And I think there's no way to evade it without removing the compatibility with Maven and Gradle (Because both of them executes their operations using the setters of the ServerTask). Of course we could just hide the parameters not in use in each operation in the README, what do you think?

Also, I want to add the nested 'argument' element, but what if the user writes something like this:
<wlp:server operation="create" template="someTemplate">
    <argument>--template="someOtherTemplate"</argument>
</wlp:server>

I think that the user shouldn't do both add arguments and parameters at the same time.


combining button primary and button secondary

Description
I combined the primary and secondary button component because thare are almost the same. Secondary is a boolean you can pass to button primary but i dont know if "button primary" is a good name if its also secondary button. Should we still have separate components?

Related Ticket
#555

Resolves #555

Checklist

[ ] Building the site with npm run build-site works without errors
[ ] Building the app with npm run build-app works without errors
[ ] I formatted JS and TS files with running npm run format-all

@ladytrekker thanks for reviewing this. Great suggestions! I implemented everything from the comments above.

@Atmosfearful I think this one is good to go if yall dont have any more feedback.


Chore: Add event logging to colorMode toggle

What changed? Why?

Added event logging for toggling colorMode on base docs

Notes to reviewers
How has it been tested?
locally

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Fix "method_lines" issue in package_managers.py

Function update_package_manager_data has 47 lines of code (exceeds 25 allowed). Consider refactoring.
https://codeclimate.com/github/sendgrid/open-source-library-data-collector/package_managers.py#issue_59f69b9f7d682f0001000028

I'm submitting a PR for this soon 😄


Updated using Jenkins to build and deploy your Linux Java application

@peterpogorski : Thanks for your contribution to the Azure documentation! The author, @sayantancs, has been notified to review your proposed change.

#sign-off

Hi @peterpogorski - In the public repo, the reviewer adds the hash sign off comment to show they approve the proposed changes for merge. I modified your hash sign off comment to assist with our queries.  Thanks

Replied to your comments. Kindly take a look and address accordingly.

#sign-off


bug #2095 - verify empty error string even if it is a nullable string

That PR resolve issue #2095, it has been tested against Kafka 2.7.0 and Kafka 2.8.1

Interesting. We should check the broker source to see when/why this changed. This also suggests we need DescribeClientQuotas coverage in the functional_test suite too

Interesting. We should check the broker source to see when/why this changed. This also suggests we need DescribeClientQuotas coverage in the functional_test suite too

Hi @dnwe i added some integration tests which covers describe / alter / delete of client quotas, thanks for your feedbacks !


Start with custom haven config repository

Hi! I think it should be like this because there is no way to revert dm_config_git_enabled after restart if it's false.

Agree. But I suppose better to remove this option at all. If URL was passed than GIT config should be enabled automatically (this option has spring-boot legacy). Thank you for feedback

https://github.com/codeabovelab/haven-platform/issues/11


feat: release 2.3.18

Release Checklist
[x] Production environment build
[x] Spec.version updated
[x] E2E tests
[x] Release notes updated (pt-br/en)

Checkmarx One – Scan Summary & Details – fa694bf8-13b8-4f7c-b6d0-bb4ecf1163b5
No New Or Fixed Issues Found


RTNB burundi live stream

Discussed in https://github.com/orgs/iptv-org/discussions/1663

Originally posted by sunyuanzhe March  2, 2024
mms://<IP_ADDRESS>:8081
This stream uses MMS protocol does anybody convert this mms into a m3u8 link?

Channel discussions should continue to be in https://github.com/orgs/iptv-org/discussions


How do we get to know for which response user has reacted(like/dislike) on MS teams?

We need help in understanding how Microsoft teams like and dislike works with Bot Framework. When user clicks on like option provided, in background we are getting reaction ID but how do we get to know for which specific response user has given his feedback. Do we have this feasibility on Teams?

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow. The official Bot Framework Github repos are the preferred platform for submitting bug fixes and feature requests.
Closing as this is a duplicate of this StackOverflow question