Exit on API errors

When the Github API returns an error, the command should exit and print the error to stderr instead of rendering a HTML page.
Maybe this only applies to --export mode, and not the normal live-reload mode.
Scenario:
We've been happily using grip to render some documentation when a commit it pushed to our repo.
One day we had users reporting that the usual documentation had been replaced with the "Rate Limit" error page.
Ideally what would have happened is that the build step which generates the HTML simply threw an error, instead of overwriting the existing documentation with the error page, which went completely unnoticed until someone tried to view it.
Passing through the error from Github would also be useful in situations as described in #258
Cheers!

Oh yeah, that makes a lot of sense.
+1 from me. I'll get on this and make the errors more accurate for #258 by the next release.
Thanks for writing this up! Very clear that this is a real problem.


w3m: add pkgconf as make dependency

Existing package

[X] I am the maintainer of this package.

Added pkgconf as a make dependency per issue #1311.
On a side note, I noticed on Repology the version changed to 0.5.3pl38 (from 0.5.3). I looked at the source (https://github.com/tats/w3m) and on Repology and believe this to be the same release currently used. It looks like only OpenBSD is using this version name currently.
Should I bump the version so that it shows up as up-to-date on Repology or leave it as-is?

OpenBSD are actually using Debian as the upstream to w3m. Tarball is here: https://github.com/tats/w3m/archive/debian/0.5.3-37.tar.gz Version in this repository should be kept as-is with an issue opened on Repology's tracker about it.

w3m has also seen no release since 2011 according to this: https://sourceforge.net/projects/w3m/files/w3m/w3m-0.5.3/ It might be worth swapping to Debian for upstream (if it's worth it of course).

Changelog for Debian's w3m: https://github.com/tats/w3m/blob/master/ChangeLog

The tarball you linked is actually to an outdated version (released January 2019 as opposed to the current one released May 2020). We already use the "same" upstream as Debian, https://github.com/tats/w3m/releases, but not the debian branch/release. The release we are using was made on the same day using the master branch, however. Looking the debian branch, it currently claims 307 commits ahead, 1989 commits behind master. I'm not currently sure what the difference between the two branches are yet but it looks the master branch gets updated more frequently (committed to 16 days ago vs May 25th).
I'll look into it some more and see which release we should be tracking.


Wrong variable name: DirectorySeperator

Description of the issue
A variable name is misspelled as: DirectorySeperator.
Details:
There is a variable DirectorySeparator declared at line 452 in the script file MaintenanceSolution.sql.
This variable is referred incorrectly as %{DirectorySeperator}% at lines:
2333
and 2377
SQL Server version and edition
Microsoft SQL Server 2014 - 12.0.2269.0 (X64)   Jun 10 2015 03:35:45   Copyright (c) Microsoft Corporation  Express Edition (64-bit) on Windows NT 6.3  (Build 18363: )
Version of the script
2020-01-26 14:06:53
What command are you executing?
Running the file MaintenanceSolution.sql
What output are you getting?
Commands completed successfully.

This issue has been fixed. Thank you for reporting it.


feat: DAYL-125 Update Status Indication a11y docn

Context for DAYL-125: Status Indicator > Improve a11y doc'n
Compared to previous changes, this PR is rather small as it simply just adds the ACCESSIBILITY tag to the text property and adds a small recommendation about providing additional context.

Closing this PR, since we've determined there's likely no real changes that need to be made for the Status Indicator page. If we determine otherwise, I'll re-open it and make those changes.


What setup are you running HTPC on and which branch are you using?
The CDN option works flawlessly here.  Can be enabled or disabled without any ill effects.

On 13 Jul 2015, at 14:57, Scott<EMAIL_ADDRESS>wrote:
Enable CDN checkbox doesn't uncheck once checked and when checked all hell breaks loose and all JS stops working, basically making it impossible to revert the change. all menu links go etc.
—
Reply to this email directly or view it on GitHub https://github.com/Hellowlol/HTPC-Manager/issues/247.

Master2
http://remote.cyanlabs.net/htpc (reverse proxy via nginx)
Windows Server 2012 R2

Can i manually disable the CDN value? I tried with SQLite browser but it didn't disable it.

Does it work directly without the reverse proxy? (just test that it hasn't cached something)

Yes you can edit it manually.

If you can copy the logfile contents and dump them onto pastebin I’m sure @Hellowlol will be able to figure out the problem for you.

On 13 Jul 2015, at 15:03, Scott<EMAIL_ADDRESS>wrote:
Master2
http://remote.cyanlabs.net/htpc http://remote.cyanlabs.net/htpc (reverse proxy via nginx)
Windows Server 2012 R2
—
Reply to this email directly or view it on GitHub https://github.com/Hellowlol/HTPC-Manager/issues/247#issuecomment-120938361.

HellowLol how do i edit it manually? editing the database didn't work.
Getting logs

not much to show... http://pastie.org/private/sybhv8c9mcgpobg5lgkwng

I use a program used sqlite browser set key to 0

Yeah changing that to 0 worked, everything has come back now.
Here look, http://remote.cyanlabs.net/htpc - username: test / password: test123
then once you seen it all working, let me know and i will renable CDN and restart my windows service then you can see everything is broken.

just realised i should enable debug logging, didn't notice. Let me know if/when your done seeing it for yourself then i will enable debug and get a log if you want.

The cnd option will be broken until I have fix it. Leave it disabled for now, I'll ping you when it's fixed.

OK no worries, i'm ok with it not working for now, I code stuff myself but not python so i know how annoying bugs are when not reported :).
I've been thinking this has been related to my reverse proxy for ages but then finally noticed it was the CDN option and am relieved as it makes my life easier :)

http://cdnjs.com/libraries/jquery.tablesorter
Remove tablesorter from js folder should only be in libs

@raysguy @Fma965 Can any confirm that it works now? (with cnd option enabled)

hi i can check for you, give me 5mins

Hi yes it's working now :)

Thank you for confirming that.


[docs] add "how-to-create-model" tutorial document

I have added a tutorial document on how users can build their own models using NNTrainer.
The current tutorial is just the most basic draft, and it needs updating.
It seems that the API needs to be updated to use easily,
as setting up the data by the user is very inconvenient for now.
(So in this example, it uses random data generator.
so.. user couldn't learn how to train using a real data.)
I also added this tutorial link to the README on the first page,
and since the list of maintainers and contributors currently occupies too much space,
I moved this part to the bottom of the README.
Signed-off-by: Seungbaek Hong<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2360. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


[Release-2.4] allow/deny resources feature for 2.4

Related Issue:  open-cluster-management/backlog#20225
Description of changes
Adding this feature for search-collector 2.4
As an ACM user, I want to control the resources collected by search from my managed clusters

/retest

/retest


Fix license

Description
This PR fixes the license metadata in the pyproject.toml and the name of the copyright holder (unidas developers).
Checklist
I have (if applicable):

[ ] referenced the GitHub issue this PR closes.
[ ] documented the new feature with docstrings or appropriate doc page.
[ ] included a test.
[ ] added the "ready_for_review" tag once the PR is ready to be reviewed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.18%. Comparing base (c19d93c) to head (c01565c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   93.18%   93.18%
=======================================
  Files           1        1
  Lines         308      308
=======================================
  Hits          287      287
  Misses         21       21

Flag
Coverage Δ

unittests
93.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use job matrix for builds, update JDK versions

Updates the CI configuration to add oracle JDK 9 and remove OpenJDK 6 and 7. OpenJDK 6 is no longer available, and OpenJDK 7 fails with build errors while trying to load the gradle wrapper.

Is openJDK 9 available on Travis CI yet? Otherwise looks good to me.

not yet, unfortunately.


Allow to change unverified phones on 2FA

Trello Card
Description
Users that still have not verified their mobile numbers through 2FA can find themselves in the situation of needing to change their mobile number in order to be able to receive 2FA codes by sms.
To avoid locking out users in that situations, we will allow them to update their mobile number when requesting their 2FA code to be re-sent to them.

The code will be sent to this new phone.
The phone number will be updated for the user for subsequent 2FA checks.

How does it look
An user with a verified mobile number will see this

While an user that still has not verified their mobile number will see this

When expanding this they will be able to see their current mobile number and modify it prior to submission of a new code.
We keep the validations for mobile number format and presence
So when submitting this

We get this error:

And when submitting this:

We get this error:

Checklist:

[x] Have you documented your changes in the pull request description?
[ ] Has acceptance criteria been tested by a peer?
[x] Has the CHANGELOG been updated? (If change is worth telling users about.)

 (3) Allow a user to change their mobile number when registering if they haven't received a code

This is what I get when there's an error:

Three changes:

Show Error:  in page title - I think you need to pass errors to the title helper.
Can we please open the details element by default if there's an error (I think you add an open attribute to the element or if using a component pass a boolean true to the open param.
The field itself should be in error like this.

Other than those three things, looks good!

@scruti
looks like resend code on reset pwd journey is broken

Seems the reset password flow is blowing up when requesting again a 2FA code because there is no current_user set when attempting to update the password following the reset_password link.
Working on resolving it + applying the feedback.


remove gitbook vestiges

Please don't murder the summary.  I have a better fix.

Added the RTD links and fixed the summary.  Closing.


Some comments may be missed in threaded comments

In timber-post.php foreach loop at line 737 a comment tree structure is built:
foreach( $timber_comments as $key => $comment ) {
	if ( $comment->is_child() ) {
		unset($timber_comments[$comment->id]);
		if ( isset($timber_comments[$comment->comment_parent]) ) {
			$timber_comments[$comment->comment_parent]->children[] = $comment;
		}
	}
}

Unfortunately there is a bug in this loop. When a child is detected and removed from $timber_comments it may be a parent of another comment. When that comment is found down the road there will be no parent anymore in $timber_comments list and it will be silently ignored. The sequence of events probably depends on the comment query result, but the issue is real. I would suggest the following minor change to the loop above:
$child_comment_ids = [];
foreach( $timber_comments as $key => $comment ) {
	if ( $comment->is_child() ) {
		//unset($timber_comments[$comment->id]);
		$child_comment_ids[] = $comment->id;

		if ( isset($timber_comments[$comment->comment_parent]) ) {
			$timber_comments[$comment->comment_parent]->children[] = $comment;
		}
	}
}

foreach($child_comment_ids as $id) {
	unset($timber_comments[$id]);
}

The ids of children are collected but they are removed from $timber_comments only after the first loop. It fixed the problem for me.

Same problem, trying to make nested comments and receive only two-level array.
Commented timber-post.php lines 766-773 and used suggested code below - everything works!

This seems to actually have been fixed in #780


Preallocation is interfering with autodiff

This function call is preallocating memory for the result, but this creates a convert to Float64 which fails for dual numbers.
https://github.com/AlgebraicJulia/CombinatorialSpaces.jl/blob/a5553f4eace107f11bb6f667e6a02b582e5bcf9f/src/DiscreteExteriorCalculus.jl#L488

I dont think this sharp operator is being used in any examples or docs. There is a sharp matrix which is used in Decapodes

Ok great, we should use the matrix form for everything we can for GPUcapodes and Autodiff compat.


Fix Typo: Missing :id for Fetching a specific contact

Fix Typo: Missing :id for Fetching a specific contact

Thanks @BruceWeng

No Problem @ncthbrt
Love to see the change is deployed on the official doc :)


Update OWNERS

This PR updates the OWNERS file to the latest version.

/override ci/prow/e2e-aws
This is a meta change, no need to run E2E


Redirect HTTP response code is set to 303 for Authorization Endpoint

Fixes #900

Default Redirect Strategy is set to HTTP Response Status Code 303. As per below-given conditions:

The Endpoint is receiving a POST request
The POST request is expecting a redirect
Handling every RedirectView present in AuthorizationEndpoint.java

Modifying tests to handle regression issues

Thanks again for the PR @sourabhsparkala. This is now in master.


[FLINK-17321][table] Add support casting of map to map and multiset to multiset

What is the purpose of the change
This PR adds support of casting maps to maps and multisets to multisets
Brief change log

Casting rule org.apache.flink.table.planner.functions.casting.MapToMapAndMultisetToMultisetCastRule
Tests in org.apache.flink.table.planner.functions.casting.CastRulesTest

Verifying this change
This change added tests and can be verified as follows:

Added tests in CastRulesTest that validate casting of maps to maps, multisets to multisets

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

I added test for map and multiset to CastFunctionITCase and for map it is ok while for multiset it fails with
rg.apache.flink.table.api.ValidationException: Could not cast the value of the 1 column: [ map(1, 1) ] of a row: [ null, map(1, 1) ] to the requested type: MULTISET<INT>

	at org.apache.flink.table.operations.utils.ValuesOperationFactory.lambda$null$4(ValuesOperationFactory.java:130)
	at java.util.Optional.orElseThrow(Optional.java:290)
	at org.apache.flink.table.operations.utils.ValuesOperationFactory.lambda$convertTopLevelExpressionToExpectedRowType$5(ValuesOperationFactory.java:127)
	at java.util.stream.IntPipeline$4$1.accept(IntPipeline.java:250)
	at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)

It seems the reason is not LogicalTypeCasts but absent converter for multiset here https://github.com/apache/flink/blob/c5581b8b41e04c1b2fabe3cee57efb1253b4066d/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/ValuesOperationFactory.java#L190
I will have a look at it later today

Hey @snuyanzin have you checked this issue? There might be something helpful for you in the patch i posted there https://issues.apache.org/jira/browse/FLINK-25428.
If the multiset test is a blocker for you, and there's no easy fix for that, you can ignore it now, as it's still not well supported by the whole stack, so perhaps you can just leave it the test there commented.

Thanks for pointing the issue, I had a look however it seems it does not help with current multiset issue.
After some debugging I noticed there is a lack of support of multisets during resolving of multiset expressions.
I added some things to make casting working.
Not sure if it makes sense to have under this issue or under a separate one

@snuyanzin I rather prefer that the multiset e2e casting gets worked out in a separate issue, as it requires significant more testing to check that it works throughout the stack.
As a goal for this task, having the test for map and multiset in CastRulesTest green and the test only for map in CastFunctionITCase green is enough.

ok, I removed multiset related fix from this PR and created a separate issue for that https://issues.apache.org/jira/browse/FLINK-25567
Now it should match the goal, please let me know if not


Spoof should support mocking sequencer address

It should be possible to mock sequencer address value with spoof cheatcode

Duplicate of #609


"Failed to parse macro invocation" when using crate "proconio"

proconio is easy IO library for competitive programming.
Error occur when using input! macro.
I can compile and run it, but I get "Failed to parse macro invocation" in rust-analyzer.
This error was confirmed in both vim and vscode.
rust-analyzer is nightly version(0.3.528).

Complete repro
cargo.toml:
[package]
name = "repro"
version = "0.1.0"
authors = ["hogehoge"]
edition = "2018"
[dependencies]
proconio = "0.4.2"

main.rs
use proconio::*;
fn main() {
    input! {
        _n: isize,
    }
}

Thank you.

Some additional information:
As for released versions of Rust Analyzer, version 2021-03-22 and 2021-03-15 both show the error for the repro code, but if input! is not the last expression of the main function, only 2021-03-22 can't correctly parse them. That is, 2021-03-15 can parse this code but 2021-03-22 cannot:
fn main() {
    input! {
        n: isize,
    }
    let _x = n;
}

As for versions of Visual Studio Code extension, I can confirm the same behavior with rust-analyzer 0.2.529 and 0.2.521. 0.2.529 behaves like 2021-03-22, 0.2.521 behaves like 2021-03-15. I'm not sure they are exactly the same version - I don't know how to check it.

The last one shows 0.2.521 can successfully parse the macro invocation (_x is correctly inferred to be of type isize).

Thanks for the report, It seem like there's still have some bugs related to statements after #8044. I am investigating on it right now, but need sometimes.

Smaller repro:
macro_rules! ng {
    ([$($tts:tt)*]) => {
        $($tts)*;
    };
    ([$($tts:tt)*] $head:tt $($rest:tt)*) => {
        ng! {
            [$($tts)* $head] $($rest)*
        }
    };
}

fn main() {
    ng!([] let _a = 3);
}

This causes failed to parse macro invocation error. let statement may related: ng!([] String::new()) doesn't cause the error.
I'm not sure but recursive macro invocation with braces may be a part of cause: two macros below are both OK.
macro_rules! ok1 {
    ([$($tts:tt)*]) => {
        $($tts)*;
    };
    ([$($tts:tt)*] $head:tt $($rest:tt)*) => {
        // OK: using parens + semicolons instead of braces
        ok1! (
            [$($tts)* $head] $($rest)*
        );
    };
}

macro_rules! ok2 {
    ([$($tts:tt)*]) => {
        $($tts)*;
    };
    ([$($tts:tt)*] $($rest:tt)+) => {
        // OK: no recursive macro calls
        ok2! {
            [$($tts)* $($rest)*]
        }
    };
}

Note: I have a lot of trouble trying them anyway. I need to restart rust-analyzer to get latest diagnostics (error highlights, semantic highlightings, type hints, diagnostics etc won't be updated) every time I change macro invocation (delete or change params, comment-out, etc). I think rust-analyzer enters some erroneous state when something goes wrong.
Among them, ok1! is nearly perfectly parsed: rust-analyzer knows the type of declared variable so type hints and completions are usable.

ok2! does not cause parse error but rust-analyzer seems it doesn't know the type of the variable (perhaps it doesn't know the variable a exists.) Japanese text inside the intellisense popup in this screenshot means "loading..." or the like.

_ok2 gives:
thread '<unnamed>' panicked at 'cannot create item tree from<EMAIL_ADDRESS>let_a=3', crates/hir_def/src/item_tree.rs:123:21
stack backtrace:
   0: rust_begin_unwind
             at /rustc/45b3c28518e4c45dfd12bc2c4400c0d0e9639927/library/std/src/panicking.rs:493:5
   1: std::panicking::begin_panic_fmt
             at /rustc/45b3c28518e4c45dfd12bc2c4400c0d0e9639927/library/std/src/panicking.rs:435:5
   2: hir_def::item_tree::ItemTree::file_item_tree_query
   3: salsa::runtime::Runtime::execute_query_implementation
   4: salsa::derived::slot::Slot<Q,MP>::read_upgrade
   5: salsa::derived::slot::Slot<Q,MP>::read
   6: <salsa::derived::DerivedStorage<Q,MP> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
   7: <DB as hir_def::db::DefDatabase>::file_item_tree::__shim
   8: hir_def::nameres::collector::DefCollector::collect_macro_expansion
   9: hir_def::nameres::collector::ModCollector::collect
  10: hir_def::nameres::collector::DefCollector::collect_macro_expansion
  11: hir_def::nameres::collector::ModCollector::collect
  12: hir_def::nameres::collector::collect_defs
  13: hir_def::nameres::DefMap::block_def_map_query
  14: salsa::runtime::Runtime::execute_query_implementation
  15: salsa::derived::slot::Slot<Q,MP>::read_upgrade
  16: salsa::derived::slot::Slot<Q,MP>::read
  17: <salsa::derived::DerivedStorage<Q,MP> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
  18: <DB as hir_def::db::DefDatabase>::block_def_map::__shim
  19: hir_def::body::lower::ExprCollector::collect_block
  20: hir_def::body::lower::ExprCollector::maybe_collect_expr
  21: hir_def::body::lower::ExprCollector::collect_expr_opt
  22: hir_def::body::lower::lower
  23: hir_def::body::Body::body_with_source_map_query
  24: salsa::runtime::Runtime::execute_query_implementation
  25: salsa::derived::slot::Slot<Q,MP>::read_upgrade
  26: salsa::derived::slot::Slot<Q,MP>::read
  27: <salsa::derived::DerivedStorage<Q,MP> as salsa::plumbing::QueryStorageOps<Q>>::try_fetch
  28: <DB as hir_def::db::DefDatabase>::body_with_source_map::__shim
  29: hir_def::diagnostics::validate_body
  30: hir::Function::diagnostics
  31: hir::Module::diagnostics
  32: ide::diagnostics::diagnostics
  33: std::panicking::try
  34: ide::Analysis::diagnostics
  35: rust_analyzer::handlers::handle_code_action
  36: <F as threadpool::FnBox>::call_box
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


Dragging of DMN rows is incorrectly previewed

Describe the Bug
The dragging of rows in dmn tables works but is incorrectly formatted during the dragging process
Steps to Reproduce
Steps to reproduce the behavior:
Create two or more decision rows
Drag them by using the "drag" icon

Expected Behavior
Visual during dragging is the same as the end result
Environment
Please complete the following information:
Browser: n/a
Modeler: 4.1.1
OS: Arch Linux (Manjaro)
Library version: as used in 4.1.1 modeler
Must be fixed via https://github.com/bpmn-io/dmn-js/issues/550

Fixed via https://github.com/camunda/camunda-modeler/pull/1899 together with upstream https://github.com/bpmn-io/dmn-js/pull/557


Fix some issues with our DocC content.

We've built up some bit rot in our documentation. This PR resolves issues raised when building the DocC bundle.

Documentation change only and our CI is failing for unrelated reasons. Merging.


[native-filters]Default to first item in filter hierarchy does not respect prior default hierarchy selections

Suppose you have a hierarchy of Animal -> Breed, and Breed is set to default to the first option.
Unfiltered, the first value of Breed is Abruzzenhund, a dog breed.
However, species is set to a default value of "Cat".  The expected behavior is that the first default value for Breed should be Abyssian, a cat breed, but Abruzzenhund appears instead.   This means the dashboard shows no data.
Expected results
The default selections in a hierarchy should influence the first item of filters below.
Actual results
The first item displayed ignores the default values of parent filters.
How to reproduce the bug

Create two filters.  Set the first to have a default value of some kind
Set the second filter to be a child of the first, and set it to default to the first item
Load the dashboard and see the first item may well not be logical

Environment

superset version: 1.3 branch
python version: Python 3.7.9
node.js version: 14

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@amitmiran137 not sure if this can be fixed for 1.3, but if it can, that would be super helpful!

I have this problem in multiple dashboards
superset version: 2.1.0 release
python version: Python 3.8.1
using chrome Version 114.0.5735.90 (Official Build) (arm64) as the dashboard browser
I see no errors in the Developer Tools console.

I'm not sure if this is still an issue in current versions of Superset (3.x). If it is, we can re-open this, or feel free to open a new issue with updated context and a reproducible case using example data. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale.

This is still a problem in Superset 3.0.2.
What is the best way to facilitate reproducing the problem?
I believe you need the following

DDL to create a table.
INSERT SQL put a few rows in the table.
A dashboard that has a pair of filters defined.

Should I attach the files to this thread or create a pull request?

Thanks for looking into it. Reopening. If you mean a pull request to fix the issue, that would be amazing. If you mean a PR to reproduce this issue (like an ephemeral workspace in a failing state), I guess that's plausible... but maybe not as simple as creating a failing dashboard and exporting it, then linking to the .zip here. Re-reading this, I think I get the issue... it's just a bit of an edge case that I think core contributors will have a hard time prioritizing. We could use some community help here if anyone wants to investigate a fix.

Can anyone verify if this is still happening on the latest master? I feel like I saw a PR go by about this, but I'm not 100% sure.


merge

Is there any reason I should merge this?

I think this person is inexperienced and wanted to contribute FBTFs config files?

Hey, @Spaenny @garrappachc
This is a complete mistake, I pressed "Sync fork" by accident, I'm in vacation mood so I didn't notice until today, my bad, I'll close this merge request.

No problem :)


Not Working in Browser

An empty avalonia App Not show "Welcome to AValonia and shows a blank broser window"
	<themes:MaterialTheme BaseTheme="Light" PrimaryColor="Indigo" SecondaryColor="Blue" />

but if i comment in app.xaml the material style, it show the message normaly
<!--<themes:MaterialTheme BaseTheme="Light" PrimaryColor="Indigo" SecondaryColor="Blue" />-->
I am using avalonia 11.0.6 in browser solution and Material.Avalonia 3.1.3
all other plataforms works ok

I am having the same exact issue.

Any ideas about that?

@SKProCH No idea what to look for, I just started looking into Avalonia a few days ago.

Seems like this is an Avalonia's bug, more info here.
Fix
Go to *.Browser/AppBundle/main.js and replace runMainAndExit with runMain:
await dotnetRuntime.runMain(config.mainAssemblyName, [window.location.search]);

After that run dotnet build and everything should be fixed.

@SKProCH This fixed the issue, thanks!


Remove trailing whitespace in the district/piece and civil parish names during on line creation/update

Whitespace stripped and deployed to test3


Leaders: SplitsLeaderboards

Class in FanGraphs.leaders to parser the FanGraphs SplitsLeaderboards page.

Coverage is being worked on in leaders/SplitsLeaderboards

Covered by Pull Reuqest #13


Axigpio

addresses #849 by checking the channel's trimask and calling the appropriate function.

I'm several months removed from this project - I no longer have the hardware to test any changes and don't remember specifics about this issue; please reassign.

we'll close for now and do bigger refactor shortly.


Update README.md

Thanks for your contribution 🥰.
The next step is to wait for review and approval to merge it to main repository
The community can help reacting with a thumb up (👍🏻) for approval and rocket (🚀) for who has tested it.
To test this PR you can run the following command below:
# NPM
npm install @shizodevs/wabotz@shizo-devs/WaBotz#patch-1
# YARN v2
yarn add @shizodevs/wabotz@shizo-devs/WaBotz#patch-1

Regards & Loves from
Shizo The Techie 🤭


Stream Deprecation Alternative For Use Case

StreamProviders stream field is deprecated and planned to be removed in 3.0.0. We currently have something like this. What is the alternative for combining stream providers?
final realtimeObeliskDocumentProvider = StreamProvider.autoDispose<ObeliskDocument>((ref) {
  ObeliskDocument obeliskDocument = ref.watch(obeliskDocumentProvider);
  DocumentInfo originalInfo = obeliskDocument.info;
  if (originalInfo.collectionPath == null || originalInfo.id == null) {
    Logging.e("Document should always have an path and id for: $obeliskDocument");
    return Stream.value(obeliskDocument);
  }
  final String collectionPath = originalInfo.collectionPath!;
  final String docId = originalInfo.id!;
  return ref.watch(realtimeDocumentInfoProvider((collectionPath, docId)).stream).map((info) {
    if (info != null) {
      obeliskDocument.info = info;
    }
    return obeliskDocument;
  });
});

final realtimeDocumentInfoProvider = StreamProvider.autoDispose.family<DocumentInfo?, (String, String)>((ref, path) {
  return FirebaseFirestore.instance.collection(path.$1).doc(path.$2).snapshots().asyncMap((snapshot) async {
    DocumentInfo? info = await snapshot.toFirestoreEntity(DocumentInfo.fromJson);
    if (info == null) {
      Logging.e("Was unable to get document info for collection ${path.$1} with id ${path.$2}");
    }
    return info;
  });
});

Describe the solution you'd like
A solution that is ergonomic without stream or removing the deprecation on stream.
Describe alternatives you've considered
listen doesn't seem like the best solution for this use case. Switching the first provider to Future and using .future instead of .stream will cause the screen to go to the loading widget callback. Adding skipLoadingOnReload: true to the .when statement in the widget fixes this, but it causes all user interactions on screen to disappear immediately. With the original .stream user interactions such as selections do not disappear until the new widget is ready, which is desired.

dding skipLoadingOnReload: true to the .when statement in the widget fixes this, but it causes all user interactions on screen to disappear immediately.

What does that mean exactly? It isn't clear to me what this is referring to. I see nothing that would be cleared with the code given when using .future here

I ran into the same (or similar) issue and was going to post essentially this question!
In my case, I have a StreamProvider that I want to observe all changes on in another provider, and take some action when certain types of events occur on the stream (such as playing audio).
I need to observe all events here, not just the latest when the provider is re-built, so .whenData does not work for this case. This works now with a watch on .stream and a regular .listen.
Why is this considered bad and what is the recommended way of doing this without relying on .steam?

In my case, I have a StreamProvider that I want to observe all changes on in another provider, and take some action when certain types of events occur on the stream (such as playing audio).

This sounds like a prime usecase for ref.listen(yourStreamProvider, ...). Have you tried that and if so, why doesn't it work?

I need to observe all events here, not just the latest when the provider is re-built, so .whenData does not work for this case. This works now with a watch on .stream and a regular .listen.

Then instead of Stream<Event>, in your StreamProvider emit a Stream<List<Event>>.
If you want to keep using the previously emitted value, you need to store them somewhere.
.stream is removed because it introduced too many hard-to-catch bugs.
You could easily end-up in a situation where opening a screen, closing it, then reentering would break your page – because the previously emitted values are no-longer readily available.

In my case, I have a StreamProvider that I want to observe all changes on in another provider, and take some action when certain types of events occur on the stream (such as playing audio).

This sounds like a prime usecase for ref.listen(yourStreamProvider, ...). Have you tried that and if so, why doesn't it work?

Ah, yes this does look like the right way! There are still cases where using the .stream directly is more convenient, e.g. to create a provider from another stream provider with some filtering / mapping applied. Is the go-to approach here to combine ref.listen with a local StreamController for these use cases?

I need to observe all events here, not just the latest when the provider is re-built, so .whenData does not work for this case. This works now with a watch on .stream and a regular .listen.

Then instead of Stream<Event>, in your StreamProvider emit a Stream<List<Event>>. If you want to keep using the previously emitted value, you need to store them somewhere.
.stream is removed because it introduced too many hard-to-catch bugs. You could easily end-up in a situation where opening a screen, closing it, then reentering would break your page – because the previously emitted values are no-longer readily available.

Apologies, I didn't mean that I had to be able to access historical values, only that I will need to be notified on every event on the stream, but it sounds like .listen() is the right tool for this.

There are still cases where using the .stream directly is more convenient, e.g. to create a provider from another stream provider with some filtering / mapping applied

This is the very reason why .stream is removed:
It looks like we can use it for that, but it actually doesn't work.
If your provider that filters/maps the stream is initialized too late, chances are it'll be in a perpetual loading state
Normal ref.listen/ref.watch don't have this issue as they can obtain the current value at any time

Closing as this was answered


Too slow

from typing import List

from dataclass_factory import parse
from dataclasses import dataclass
from timeit import timeit

@dataclass
class A:
    a: int
    b: str

@dataclass
class B:
    a: A
    b: A

data = {
    "a": {
        "a": 12345,
        "b": "qwer",
    },
    "b": {
        "a": 12345,
        "b": "qwer",
    }
}

data2 = [
    [1, 2], [3, 4], [5, 6], [7, 8]
]

def do():
    parse(data2, List[List[int]])

res = timeit("do()", globals={"do": do}, number=100000)
print(res)

Verion 1.0 is much better (2 to 10 times)

Not actual. Mashumaro is only 5% faster. Marshmallow is 10 times slower.


associatedStoreIdentifiers, appLaunchURL error

Expected Behavior
Actual Behavior
Steps to Reproduce the Problem
hello.
I am using this library very well, thankfully.
I'm not good at English, so I'm asking a question using Google Translator.
Please understand if the grammar is incorrect.
When using the library and entering the two data below, the created path does not open.
associatedStoreIdentifiers, appLaunchURL
Could you please let me know if that part is not supported?

Hi there! This library saves the payload as JSON, without any further processing, so anything that is described in Apple's JSON payload documentation should work with this library.

Thanks for your reply.
The code below is the code I am currently using.
The type is store card.
I don't know what I'm doing wrong.
Can you provide sample code?
Of course, I would like the code to include associatedStoreIdentifiers .
    $data = [
        "formatVersion"         => 1
        , "passTypeIdentifier"  => $this->passTypeIdentifier
        , "teamIdentifier"      => $this->teamIdentifier
        //, "relevantDate"        => date("Y-m-d\TH:i:sP")

        , "serialNumber"        => $passObjects["pass_unique"]
        , "groupingIdentifier"  => $passObjects["pass_group_code"]

        , "backgroundColor"     => $passObjects["tpl_bg_color"]
        , "foregroundColor"     => $passObjects["tpl_text_color"]
        , "labelColor"          => $passObjects["tpl_text_color"]

        , "description"         => $passObjects["pass_description"]
        , "organizationName"    => $passObjects["pass_organization"]

        , "webServiceURL"       => $passObjects["pass_service_url"]
        , "authenticationToken" => $passObjects["pass_auth_token"] // The token must be 16 characters or longer.

        // , "appLaunchURL"               => "http://www.istarbucks.co.kr/msr/index.do"
        // , "associatedStoreIdentifiers" => "466682252"

    ];

I can't give too much support on the Apple side of things unfortunately, but looking at the documentation, it states:

associatedStoreIdentifiers - array of numbers

So I think those lines need to look more like this:
"appLaunchURL" => "http://www.istarbucks.co.kr/msr/index.do",
"associatedStoreIdentifiers" => [466682252]

I also am not sure if there's a limitation on needing to an app that exists in the same developer account. The docs don't seem to mention it, but I could imagine that being the case, as I guess Apple doesn't want to allow anyone to give out passes that link to a specific app.


Fix broken links

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/breadcrumb/toc.yml
:white_check_mark:Succeeded

docs/controls/file-pickers/index.md
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


added iris close for dark frame generation

I'm new to github so if I'm posting this in the wrong place or not following proper procedure please forgive me!
I had a lens with an auto iris cable and jumped it to ground and gpio pin 4. Installed wiringpi and edited allsky.sh to make gpio4 go low when a dark frame generation is requested. normally it stays high to keep the iris full open on the lens.
edited allsky.sh with dark frame iris control added
`
#!/bin/bash
source /home/pi/allsky/config.sh
source /home/pi/allsky/scripts/filename.sh
#set gpio pins for output
gpio mode 7 out
checkDark="darkframe 1"
echo "Starting allsky camera..."
cd /home/pi/allsky
Building the arguments to pass to the capture binary
ARGUMENTS=""
KEYS=( $(jq -r 'keys[]' $CAMERA_SETTINGS) )
for KEY in ${KEYS[@]}
do
ARGUMENTS="$ARGUMENTS -$KEY jq -r '.'$KEY $CAMERA_SETTINGS "
done
When using a desktop environment (Remote Desktop, VNC, HDMI output, etc), a preview of the capture can be displayed in a separate window
The preview mode does not work if allsky.sh is started as a service or if the debian distribution has no desktop environment.
if [[ $1 == "preview" ]] ; then
ARGUMENTS="$ARGUMENTS -preview 1"
fi
ARGUMENTS="$ARGUMENTS -daytime $DAYTIME"
echo "$ARGUMENTS">>log.txt
Check to see if we're collecting a DarkFrame and if so. Close the iris.
If not. Open it
if echo $ARGUMENTS | grep -q "$checkDark";
then
echo "Creating DarkFrame: Iris Closed"
gpio write 7 0
else
echo "Normal Operation: Iris Open"
gpio write 7 1
fi
./capture $ARGUMENTS
`

Thanks for that piece of code. The auto-iris is definitely an improvement over the manual method. Especially if the camera is already on the roof.
What lens model are you using in your allsky?

The Lens is a Rainbow L163VDC4P fisheye lens. It had a connector for an auto iris connection to a camera. I broke out the pins and isolated just the iris shutter coil power leads. (the iris normally works on some kind of push/pull feedback system with viltages provided by the cctv camera based on video levels. since all I wanted was to be able to close it all the way or open it all the way. all I was concerned with was the actual iris so gpio level voltages on the + - leads were enough to accomplish what I needed.

This issue is from an older release of the AllSky software.  If you think it might still be relevant, please submit a new issue.  Thanks.


ENH: allow layering with ax keyword

This is a common pattern with pandas plots:
ax = df.plot.line()
df.plot.area(ax=ax)

We could do a similar thing by adding an ax argument to methods and using vega-lite layering internally... but corner cases may get a bit complicated.

done in 0936277; leaving this issue open to remind me to add it to the docs.


python37Packages.flask-cors: 3.0.9 -> 3.0.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.flask-cors is: "A Flask extension adding a decorator for CORS support"
meta.homepage for python37Packages.flask-cors is: "https://github.com/corydolphin/flask-cors"
meta.changelog for python37Packages.flask-cors is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.0.10 with grep in /nix/store/giskyx27sd8z1v7fndw6qndcmish6sg8-python3.7-Flask-Cors-3.0.10

directory tree listing: https://gist.github.com/a8d674001a633b140e095722df6a6cb2

du listing: https://gist.github.com/1c30374afe33ae2e169783867239d278

Rebuild report (if merged into master) (click to expand)

61 total rebuild path(s)

17 package rebuild(s)

16 x86_64-linux rebuild(s)
16 i686-linux rebuild(s)
12 x86_64-darwin rebuild(s)
17 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
flexget
python37Packages.alerta-server
python37Packages.flask-cors
python37Packages.ihatemoney
python37Packages.runway-python
python37Packages.swspotify
python38Packages.alerta-server
python38Packages.flask-cors
python38Packages.ihatemoney
python38Packages.runway-python
python38Packages.swspotify
python39Packages.alerta-server
python39Packages.flask-cors
python39Packages.ihatemoney
python39Packages.runway-python
python39Packages.swspotify
swaglyrics

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/giskyx27sd8z1v7fndw6qndcmish6sg8-python3.7-Flask-Cors-3.0.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.flask-cors https://github.com/r-ryantm/nixpkgs/archive/8abd513d8b35b50f456ef418bd4c541d524f8e0a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/giskyx27sd8z1v7fndw6qndcmish6sg8-python3.7-Flask-Cors-3.0.10
ls -la /nix/store/giskyx27sd8z1v7fndw6qndcmish6sg8-python3.7-Flask-Cors-3.0.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

python37Packages.swspotify
python38Packages.swspotify
python39Packages.swspotify
swaglyrics

12 packages built:

flexget
python37Packages.alerta-server
python37Packages.flask-cors
python37Packages.ihatemoney
python37Packages.runway-python
python38Packages.alerta-server
python38Packages.flask-cors
python38Packages.ihatemoney
python38Packages.runway-python
python39Packages.alerta-server
python39Packages.flask-cors
python39Packages.ihatemoney

Maintainer pings

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108776 run on x86_64-linux 1

4 packages failed to build and are new build failures:

python37Packages.swspotify: log https://termbin.com/lk0r
python38Packages.swspotify: log https://termbin.com/jeng
python39Packages.swspotify: log https://termbin.com/06y7
swaglyrics: log was empty

12 packages built:

flexget
python37Packages.alerta-server
python37Packages.flask-cors
python37Packages.ihatemoney
python37Packages.runway-python
python38Packages.alerta-server
python38Packages.flask-cors
python38Packages.ihatemoney
python38Packages.runway-python
python39Packages.alerta-server
python39Packages.flask-cors
python39Packages.ihatemoney

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108776 run on x86_64-linux 1

4 packages failed to build and are new build failures:

python37Packages.swspotify: log https://termbin.com/lk0r
python38Packages.swspotify: log https://termbin.com/jeng
python39Packages.swspotify: log https://termbin.com/06y7
swaglyrics: log was empty

12 packages built:

flexget
python37Packages.alerta-server
python37Packages.flask-cors
python37Packages.ihatemoney
python37Packages.runway-python
python38Packages.alerta-server
python38Packages.flask-cors
python38Packages.ihatemoney
python38Packages.runway-python
python39Packages.alerta-server
python39Packages.flask-cors
python39Packages.ihatemoney

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108776 run on x86_64-darwin 1

12 packages built:

flexget
python37Packages.alerta-server
python37Packages.flask-cors
python37Packages.ihatemoney
python37Packages.runway-python
python38Packages.alerta-server
python38Packages.flask-cors
python38Packages.ihatemoney
python38Packages.runway-python
python39Packages.alerta-server
python39Packages.flask-cors
python39Packages.ihatemoney

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108776 run on x86_64-darwin 1

12 packages built:

flexget
python37Packages.alerta-server
python37Packages.flask-cors
python37Packages.ihatemoney
python37Packages.runway-python
python38Packages.alerta-server
python38Packages.flask-cors
python38Packages.ihatemoney
python38Packages.runway-python
python39Packages.alerta-server
python39Packages.flask-cors
python39Packages.ihatemoney


changing activities to sync

Not a real PR. Using for review purposes

This has passed chad's review. This wasn't meant to be merged in so closing. It will remain in a branch as an example.


[Bugfix][Kernel] Add head size check for attention backend selection

FILL IN THE PR DESCRIPTION HERE
Previous #4886 PR cause the lora-test failing due to Phi-2 with LoRA will make attention head_size to 80 while Flash Attention doesn't support it.

This PR fix the issues by adding a head size check when selecting attention backend.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Hmm wonder if we should fix this way instead; https://github.com/vllm-project/vllm/pull/4948?

Hmm wonder if we should just go this way; https://github.com/vllm-project/vllm/pull/4948 so that we can avoid duplicated constants here

I think #4948 would be a better solution to avoid duplicated constants.


Add jenkins healthcheck taskset

Adds taskset for healthchecking Jenkins workloads and its rest API in Kubernetes

Note: there's a bug in the PVC check that has a fix coming in a separate PR which will include changes addressing feedback from yourself & Kyle

I'm guessing you're referring to:
${KUBERNETES_DISTRIBUTION_BINARY} exec statefulset/${STATEFULSET_NAME} --context=${CONTEXT} -n ${NAMESPACE} -- curl -s localhost:8080/api/json?pretty=true --user $${JENKINS_SA_USERNAME.key}:$${JENKINS_SA_TOKEN.key}
Since I'm using the $${}  syntax with the key and not the actual value this will result in an ENV variable so $JENKINS_SA_USERNAME or  $JENKINS_SA_TOKEN in the robot when it's passed in.
In terms of rendering, we could provide something like:
export JENKINS_SA_USERNAME=<your jenkins username>
export JENKINS_SA_TOKEN=<your jenkins API token>

Thoughts?

Let's skip it for now. If it requires additional configuration to be
useful, it's not ideal.
If it was something we could easily parse from the system that would be
fine, but as it is, it's not a straight copy paste without additional work.
We can look at how to handle that pattern down the line.
--
Shea Stewart (he/him)
c:647-972-5191 @.***
Book a meeting https://calendly.com/stewartshea
On Fri, May 26, 2023, 12:37 p.m. jon-funk @.***> wrote:

I'm guessing you're referring to:
${KUBERNETES_DISTRIBUTION_BINARY} exec statefulset/${STATEFULSET_NAME}
--context=${CONTEXT} -n ${NAMESPACE} -- curl -s
localhost:8080/api/json?pretty=true --user
$${JENKINS_SA_USERNAME.key}:$${JENKINS_SA_TOKEN.key}
Since I'm using the $${} syntax with the key and not the actual value
this will result in an ENV variable so $JENKINS_SA_USERNAME or
$JENKINS_SA_TOKEN in the robot when it's passed in.
In terms of rendering, we could provide something like:
export JENKINS_SA_USERNAME=
export JENKINS_SA_TOKEN=
Thoughts?
—
Reply to this email directly, view it on GitHub
https://github.com/runwhen-contrib/rw-cli-codecollection/pull/27#issuecomment-1564648304,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AELXHOBXI22MDQMCWWH2HITXIDL4FANCNFSM6AAAAAAYNVTI6A
.
You are receiving this because your review was requested.Message ID:
@.***>


Parallel efficiency on a single KNL node drops dramatically

56% with TBB backend
40% with the Cthreads
Half or more of the runtime spent in other
As thread count decreases, efficiency increases.

I am closing this, since it's not a real efficiency issue, but rather that the profile counts also the setup phase.


go.dev: make LICENSE detection optional in pkgsite codebase (not in pkg.go.dev)

Overview
Now that pkgsite is open sourced (congrats btw!), developers can run the server for sharing documentation of their private code amongst their internal teams.
However, private code almost always does not have a LICENSE file in its root repository because employees typically sign a separate agreement stating that the internal code is not to be copied or shared.
This means that pkgsite won't be able to show any documentation for most of the internal code out there (or at least the ones I've worked with as it is hard to quantify what you cannot access).
One option is to go around and add an appropriate LICENSE for all of the private code that both pkgsite can detect: https://pkg.go.dev/license-policy and is an appropriate LICENSE for private code. However, most of the licenses that pkgsite detects seem to be open-source oriented which is a non-starter for private modules. Even if there was a LICENSE that was meant for private-code, it doesn't guarantee that all teams can use it within their private repositories as it requires approvals from their company's legal entities.
Proposal
Therefore, it seems like the best option is to add a new configuration to pkgsite that bypasses the LICENSE check all together so that developers running the server for their internal teams don't need to go add a LICENSE to all of their private modules while still benefiting from using pkgsite and be able to give feedback!
Thanks!

/cc @jba

This does not solve this issue, as it is not a pull request, but I have a project that will hard code license respecting off and run pkgsite as a docker container. It has a few other use cases too.
I could figure out how to solve this with a flag, then create & submit pull request, unless the Go team is already on the issue.
I was able to use sed commands in the Dockerfile  I made to manipulate some booleans that allowed the docs to build for projects without permissive licenses. You can see the affected files/lines in any of the athens.Dockerfile files in the below projects.
GitLab project
GitHub mirror


Alwayes After Open Bot In Telegram

Tap failed - please stop the code and open the bot in telegram then tap 1-2 times and run this code again. it should be worked!

Clicked the bot button, after shutting down and restarting the same error pops up.
What can I do if I have a large farm? Not everywhere it is possible to start telegram and click the button.

disable auto_tap u can just claim btc from cexp power


setuptools-build-hook: fix the develop mode

I have tested with several packages and develop mode would
systematically trigger.
these paths will be fetched (0.02 MiB download, 0.16 MiB unpacked):
/nix/store/j7bms8a3r2pxl31x7nq9hzjzxzkfkwfk-source
copying path '/nix/store/j7bms8a3r2pxl31x7nq9hzjzxzkfkwfk-source' from 'https://cache.nixos.org'...
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Using pipInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing setuptools-check-hook
Using setuptoolsCheckPhase
Executing setuptoolsShellHook
Usage:
/nix/store/k0igqpz995nmxwf6piyd5jjpcc7gcnyc-python3-3.7.4/bin/python3.7 -m pip  [options]
no such option: -e
Finished executing setuptoolsShellHook
There doesn't seem to be a need for eval in the setuptools-build-hook, especially as
other hooks don't have it.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @FRidh

Fix for this is in staging 5505d2f036342f1efb3cfb36c6cb9332e3358954


Upgrade OrleansRuntime to 3.1.2 and set Nuget Version to 3.1.2

Solves #88

Thanks, @Hechamon. I merged this in #90, but with an incremented-by-one patch version.


Documentation & precision

Hi everyone,
I am working with FCNPC for my bot system, nonetheless, I have an issue with bot moving.
When the bot target is higher than the bot, the bot is floating in the air. How can I fixe this bug?
I saw there is a possibility to use MapAndreas, I set the parameters to true, but nothing change.
And the last point: Do you plan to make a dcumentation ?

I am working with FCNPC for my bot system, nonetheless, I have an issue with bot moving.
When the bot target is higher than the bot, the bot is floating in the air. How can I fixe this bug?

Screenshots?

I saw there is a possibility to use MapAndreas, I set the parameters to true, but nothing change.

MapAndreas plugin loaded successfully?

And the last point: Do you plan to make a dcumentation ?

No, I am not interested in this.

Hum my bad, I didn't see I have to load MapAndreas.
The default plugin should work? http://forum.sa-mp.com/showthread.php?t=120013
Thank you for your answer :)

Use this: http://forum.sa-mp.com/showpost.php?p=3130004&postcount=153

I try with the plugin, but the problem is still here. SOmetimes, the bot is under the ground, sometimes it is in the air.
On this picture : http://img11.hostingpics.net/pics/440427samp010.png , the bot is nearly in the ground and this one http://img11.hostingpics.net/pics/859550samp007.png the bot is under the ground (it is shooting at me)

Show your code.

Loading MapAndras:
MapAndreas_Init(MAP_ANDREAS_MODE_FULL);     FCNPC_InitMapAndreas(MapAndreas_GetAddress());
Bot management:
`if (Bot_GetDistanceFromPlayer(npcid, playerid) > 30.0)
{
#if DEV_MODE == 1
printf("NPC(%d) follow Player(%d)", npcid, playerid);
#endif
        if (FCNPC_IsAiming(npcid))
            FCNPC_StopAim(npcid);

        if (!FCNPC_IsMoving(npcid))
            FCNPC_GoToPlayer(npcid, playerid, MOVE_TYPE_AUTO, MOVE_SPEED_AUTO, true);
    }
    else {
        #if DEV_MODE == 1
            printf("NPC(%d) attacks Player(%d)", npcid, playerid);
        #endif

        if (Bot_GetDistanceFromPlayer(npcid, playerid) < 15.0)
            FCNPC_Stop(npcid);

        if (!FCNPC_IsAiming(npcid))
            FCNPC_AimAtPlayer(npcid, playerid, true);
    }`

FCNPC_InitMapAndreas returns 0 or 1?

It returns 1.
Hum, after recompilation, there is no bug. Just one thing, sometimes, the bot pass trough the bulding to go to the target.


patch for read_bytes() & write_bytes()

read_bytes() / write_bytes() gives PermissionError on windows, because the local file can't be opened twice (temppathlib.NamedTemporaryFile() performs an exclusive open). patch attached (that uses similar temp-dir solution you used in get/set).
also note that i changed path.as_posix() -> str(path) in a few places, as this should be more compatible with windows. there are some other places in the code that would probably benefit from that change.
windows-readwrite-patch.txt
thanks for the nice module!

Hi @jaant,
Thanks for the patch and also for spotting the issue! We used Linux so it went unnoticed.
Let me check if the data can be streamed directly to the temporary file so that we can avoid creating a temporary directory. I should come back to you by tonight.
(I'll create a separate pull request for str/as_posix issue.)

Hi @jaant ,

(I'll create a separate pull request str/as_posix issue.)

I decided finally to pack it into the same pull request (#54) since you wouldn't be even able to test the code without it. The test passes successfully on my Linux system.


M24H-26 include landmark & description in the emails

This has M24H-28 and M24H-31 merged in, once those are reviewed
and been merged in the changes here will be come more easily visible.

@KaitCrawford ready for review tomorrow morning but best to start on M24H-31 & M24H-28 first.

:+1:


If the search results contain only one variant the search query gets deleted from the search bar

Describe the Problem
Users would rather avoid losing their current query if it took time to write
Browser and Operating System Information
Chrome on Windows
Steps to Reproduce
Search for sid:774-2137-4923

solved : )


Terraform modules cleanup

Various nits in Maxtext related terraform modules, other changes to align deployments between ai-on-gke and public docs

/gcbrun


Fix dependency on JDK8 classes

This PR removes the dependency from the java.util.function.Consumer interface that is only available in JDK8. The replacement used is org.gradle.api.Action.
I also fixed all inconsistent use of tabs and whitespace across the source files.
All tests passes with JDK 1.7.0_79.
Resolves #13

Unfortunately I could test my fix only on a couple of small projects that need JDK7.
It would be great if you could test it on more substantial projects.
Thanks!

@acisternino : I've got a couple projects on which I could give this a shot.  But— I have no idea how to build the plugin from this branch and incorporate it into a project.  (We do have a Nexus repo to throw it up on if that helps— but I'd need a lead on how to get that job done, as well.)

@Dispader Hi Jake, sorry for the late reply.
What I have done is a bit of a hack. These are the steps you could try:

Check-out my fix-jdk8-dependency branch.
Comment out all references to the signing plugin in the build.gradle file.
Change the version number to anything you like. I have added -FIX7 to it.
Do a gradle install to install in your local maven repository.

If you want to deploy it to your Nexus repository you have to remove the com.jfrog.bintray plugin and follow the Gradle guide for publishing artifacts. I am sorry I can't help you more with this but for me deploying to mavenLocal() was enough.

any chance to see this merged?


envoyMetricsService Istio Histograms are Missing +Inf Upper Bound

Title: envoyMetricsService Istio Histograms are Missing +Inf Upper Bound
Description:
This is a problem with istio/proxyv2
With a normal sidecar/Kiali/Prometheus setup the Istio histogram metrics (ex. istio_request_duration_milliseconds_bucket) include the +Inf bucket.
With the metrics received by the gRPC envoyMetricsService the +Inf bucket is missing. This is a major issue for the histogram_quantile Prometheus function.

The highest bucket must have an upper bound of +Inf. (Otherwise, NaN is returned.)

For now I'll just convert the highest upper bound to +Inf in my metrics service.
[optional Relevant Links:]
https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#RemoteService
Expected behavior
It should include the +Inf bucket. Here's what I receive right now:

[histogram:<sample_count:3 sample_sum:2565 bucket:<cumulative_count:0 upper_bound:0.5 > bucket:<cumulative_count:0 upper_bound:1 > bucket:<cumulative_count:0 upper_bound:5 > bucket:<cumulative_count:0 upper_bound:10 > bucket:<cumulative_count:0 upper_bound:25 > bucket:<cumulative_count:0 upper_bound:50 > bucket:<cumulative_count:0 upper_bound:100 > bucket:<cumulative_count:0 upper_bound:250 > bucket:<cumulative_count:0 upper_bound:500 > bucket:<cumulative_count:3 upper_bound:1000 > bucket:<cumulative_count:3 upper_bound:2500 > bucket:<cumulative_count:3 upper_bound:5000 > bucket:<cumulative_count:3 upper_bound:10000 > bucket:<cumulative_count:3 upper_bound:30000 > bucket:<cumulative_count:3 upper_bound:60000 > bucket:<cumulative_count:3 upper_bound:300000 > bucket:<cumulative_count:3 upper_bound:600000 > bucket:<cumulative_count:3 upper_bound:1.8e+06 > bucket:<cumulative_count:3 upper_bound:3.6e+06 > > timestamp_ms:1595617404646 ]

Steps to reproduce the bug
Run a gRPC envoy metrics service with an Istio sidecar and print the metrics received.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
client version: 1.6.4
control plane version: 1.6.4
data plane version: 1.6.4 (12 proxies)

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.5", GitCommit:"e0fccafd69541e3750d460ba0f9743b90336f24f", GitTreeState:"clean", BuildDate:"2020-04-16T11:44:03Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.9+IKS", GitCommit:"dbe4e8a5c169e0a6a8a9b7b183561fa61e161985", GitTreeState:"clean", BuildDate:"2020-07-16T01:30:57Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

cc @ggreenway who I think is our Prometheus expert at this point.

This is actually a completely different code-path than the admin prometheus stats handler. I've never looked at this before, but I think it should be a simpler fix. In MetricsServiceSink::flushHistogram(), we have this:
  // Add bucket information for histograms.
  io::prometheus::client::MetricFamily* histogram_metrics_family = message_.add_envoy_metrics();
  histogram_metrics_family->set_type(io::prometheus::client::MetricType::HISTOGRAM);
  histogram_metrics_family->set_name(envoy_histogram.name());
  auto* histogram_metric = histogram_metrics_family->add_metric();
  histogram_metric->set_timestamp_ms(std::chrono::duration_cast<std::chrono::milliseconds>(
                                         time_source_.systemTime().time_since_epoch())
                                         .count());
  auto* histogram = histogram_metric->mutable_histogram();
  histogram->set_sample_count(hist_stats.sampleCount());
  histogram->set_sample_sum(hist_stats.sampleSum());
  for (size_t i = 0; i < hist_stats.supportedBuckets().size(); i++) {
    auto* bucket = histogram->add_bucket();
    bucket->set_upper_bound(hist_stats.supportedBuckets()[i]);
    bucket->set_cumulative_count(hist_stats.computedBuckets()[i]);
  }

The +Inf bucket is implied by the format, and isn't included in the config for buckets. So after the loop, add another bucket with bound +Inf and count of hist_stats.sampleCount().

@ggreenway @mattklein123 Thank you. I should be able to make this change at some point


Optimized images

Issue - Page performance
Page affected - localhost:9991/hello/ and https://www.zulip.org
We were using some heavy png images which were making the page slow. I have tried to optimize(total reduced size ~1100kb) all those images so that performance and load time can be improved.

Automated message from Dropbox CLA bot
@akashnimare, it looks like you've already signed the Dropbox CLA. Thanks!

Awesome!  What tools did you use for optimizing them / what resolution did
you move them to?
These images also appear in
https://github.com/zulip/zulip.github.io/tree/master/images, so it'd be
good to have a corresponding pull request there since that's what hosts
zulip.org.
    -Tim Abbott

On Tue, Mar 29, 2016 at 2:21 PM, Steve Marx<EMAIL_ADDRESS>wrote:

Automated message from Dropbox CLA bot
@akashnimare https://github.com/akashnimare, it looks like you've
already signed the Dropbox CLA. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/zulip/zulip/pull/604#issuecomment-203110386

Tools I have used -

https://tinypng.com/
https://compressor.io/
Tinypng is pretty good. Btw there is no change in resolution only the size gets reduced. It's a lossless compression. I will be sending a PR to this repo as well.

Cool, looks good, merged.  Thanks @akashnimare !

(was merged as 41c0b926680c30968a04983c0ec755e703d9857f with a slightly cleaned up commit message to use an action verb and be a bit more descriptive)

I should have elaborated more. Thanks for the merge.


[Feature][zentao] Collect&Extract&Convert programs

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Collect&Extract&Convert programs
Use case
Collect&Extract&Convert programs
Related issues
#2961
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am willing to submit a PR

closed by #3779


Add signout button

[ ] Call firebase.auth().signOut(); when a logout button is clicked

I'd like this as part of a setting tab on the side as we have in years past. See 2018-Core for reference.

@ShashJar same here

Adding onto this, I would prefer if this is ONLY possible when the user has internet in the event that is undesirable

let’s add a pass phrase instead

What do you mean by a passphrase? Something they have to enter in order to sign out?

Yes, TBD.
On Sat, Mar 16, 2019 at 19:28 Dev-Osmium<EMAIL_ADDRESS>wrote:

What do you mean by a passphrase? Something they have to enter in order to
sign out?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FRCteam4909/The-Green-Alliance/issues/11#issuecomment-473601183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEUIR1HQkKJbibAdUkf3pUzLxX5UNIjKks5vXX4rgaJpZM4bU_m6
.


Replace the yellow background

Black background

https://github.com/mdn/to-do-notifications/issues/9

I think you didn't create your branch from the head.
Given your fix is one line, can you recreate a new PR?, it will be easier to review and merge.

yeah, I used master as the source branch. Hopefully now is better, now I used mdn:gh-pages as the source. The new PR -> https://github.com/mdn/to-do-notifications/pull/27


fix: include babel patches to notification banner wc wrapper

arrow functions and class will break IE

Looks good, AFAIK.


haskell gio system dependency escalation

While working on #240387 I noticed, that I am witnessing an escalation of system dependencies for haskell-gi packages:
e.g. while trying to build haskellPackages.webkit2gtk3-javascriptcore:
I witness errors like:
webkit2gtk3-javascriptcore> Error: Setup:
webkit2gtk3-javascriptcore> '/nix/store/yk3w3n1bi8xadabks8flbkri9hk4r6pm-pkg-config-wrapper-0.29.2/bin/pkg-config'
webkit2gtk3-javascriptcore> exited with an error:
webkit2gtk3-javascriptcore> Package libpsl was not found in the pkg-config search path.
webkit2gtk3-javascriptcore> Perhaps you should add the directory containing `libpsl.pc'
webkit2gtk3-javascriptcore> to the PKG_CONFIG_PATH environment variable
webkit2gtk3-javascriptcore> Package 'libpsl', required by 'libsoup-2.4', not found

which I can iteratively (this was actually the last one) fix until I have:
  webkit2gtk3-javascriptcore = addBuildDepends [
      pkgs.pcre2
      pkgs.pcre
      pkgs.util-linux
      pkgs.libselinux
      pkgs.libsepol
      pkgs.libthai
      pkgs.libdatrie
      pkgs.xorg.libXdmcp
      pkgs.libxkbcommon
      pkgs.libepoxy
      pkgs.xorg.libXtst
      pkgs.libsysprof-capture
      pkgs.sqlite
      pkgs.libpsl
    ] super.webkit2gtk3-javascriptcore;

in configuration-nix.nix.
Apparently I need to do similar things for haskellPackages.gi-soup and haskellPackages.gi-javascriptcore next (for reflex-dom). I also noticed, that this escalation of the number of necessary system dependency overrides had already crept into our overrides, see:
https://github.com/NixOS/nixpkgs/blob/c7ac3583bb94f4c014e2554b4e00fcf42773572c/pkgs/development/haskell-modules/configuration-nix.nix#L321-L339
What is especially unnerving about this is, how it cascades. Does nixpkgs not have any tooling to pull in transitive pkg-config dependencies? (As you can maybe tell I have no clue about this stuff.)
Now my question: Are we doing something wrong? Is this indicative of some bigger issue?
I am fine with stacking more and more overrides on this if this is our only chance, but this feels wrong.
Summoning people who touched this and/or might have some insight: @cdepillabout @sternenseemann @jtojnar @wegank @expipiplus1

I do not think anything happened recently.
libpsl is in Requires.private of libsoup-2.4.pc so it should not be needed unless doing static build (in which case buildInputs would automatically be turned to propagated).
Unfortunately, pkg-config does not really define semantics of Requires.private so we have to patch it to behave consistently.

@maralorn Maybe this is the cabal issue we've had problems with for a while now?
https://github.com/NixOS/nixpkgs/blob/405d3d38b3f21b05be5344b0dbf31aafc1e72659/pkgs/development/haskell-modules/configuration-ghc-9.4.x.nix#L164-L192
https://github.com/haskell/cabal/issues/8455

Oh, wow. Good that I asked. I had been wondering what the heck was going on with those overrides. Will try out and report back.

Okay, I think this fixes it (e.g. for gi-soup) but for gi-javascriptcore and webkit2gtk3-javascriptcore I now get:
       > setupCompileFlags: -package-db=/build/tmp.yvABDAGLOt/setup-package.conf.d -j12 +RTS -A64M -RTS -threaded -rtsopts
       > [1 of 2] Compiling Main             ( Setup.hs, /build/tmp.yvABDAGLOt/Main.o )
       > [2 of 2] Linking Setup
       > gcc: fatal error: cannot execute ‘/nix/store/6vwsydq4nzr1l8j7fyg5r61nknwq6w60-gcc-12.3.0/libexec/gcc/x86_64-unknown-linux-gnu/12.3.0/collect2’: execv: Argument list too long
       > compilation terminated.
       > ghc: `cc' failed in phase `Linker'. (Exit code: 1)

@maralorn Possibly you're now running into https://github.com/NixOS/nixpkgs/issues/41340?  (which would be quite unfortunate...)

See also https://github.com/haskell/cabal/issues/8455. The problem is that Cabal basically re-implements pkg-config and tracks libraries that would be needed for static linking in the package db (?) preemptively even though it would be possible to get the same information from pkg-config when the need arises. We will almost certainly need to patch Cabal, but unfortunately it is not yet clear what direction upstream is going in.
(It should be possible to get a fee for the argv problem by cranking NIX_DEBUG up.)

There is the meta.pkgConfigModules package attribute which would make __CabalEagerPkgConfigWorkaround slightly less awful, but this meta information is still missing from many library packages.


Add support for Spring boot 3.

Also, add a test module, and add Java 17 job, which is also used for Sonar.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


New conversational chess notebook using nested chats and tool use

Why are these changes needed?
The existng conversational chess notebook uses complicated register_reply and subclassing.
Replace it with a new notebook using nested chat and tool use.
Related issue number

Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.76%. Comparing base (212722c) to head (c2a8fc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
- Coverage   37.06%   34.76%   -2.30%
==========================================
  Files          68       69       +1
  Lines        7069     7122      +53
  Branches     1543     1552       +9
==========================================
- Hits         2620     2476     -144
- Misses       4218     4426     +208
+ Partials      231      220      -11

Flag
Coverage Δ

unittests
34.76% <ø> (-2.29%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Clarify what happens when the conversation between a player_a and board proxy ends. E.g., how are the results from that conversation are transformed into a message to player_b.

Done. Explained with updated figure.

At some point in the notebook, the logs show an empty carryover message. Consider explain what carryover does in the chess scenario.

Done

Emphasize its important to use the board proxy (or at least a board proxy that use the same board object), to ensure a shared state (beyond chat history) between the players

Done

@ekzhu do you think this is the simplest way to implement this scenario with AutoGen? If no, clarify that this is not a design recommendation for optimal implementation but an illustrative example.

I believe this is it. It should be the example we show to illustrate how to use nested chat with tool use. I have also updated related tutorial chapters.


Expose credential option to disable metadata discovery for MSAL based credentials.

Closes #27776

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Identity

Just like a common TenantId-option is exposed on DefaultAzureCredentialOptions, then consider also to include support for DisableInstanceDiscovery

Just like a common TenantId-option is exposed on DefaultAzureCredentialOptions, then consider also to include support for DisableInstanceDiscovery

Good catch!


fmt: Default formatting of map values for NaN key is  even when nil is not valid for the type.

go version go1.6 linux/amd64
m := map[float64]int{math.NaN(): 3, math.NaN(): 4, .1: 5}
fmt.Println(m)

prints map[0.1:5 NaN:<nil> NaN:<nil>].
I would have hoped for map[0.1:5 NaN:3 NaN:4] since for example iterating over the map with a for loop can retrieve the values 3 and 4.  Perhaps acceptable would be map[0.1:5 NaN:0 NaN:0], consistent with v, ok := m[math.NaN()] returning 0, false.  But printing <nil> when nil is not a valid value for the int type is unexpected.

This behaviour comes from the reflect package used in fmt to print the map.
For a NaN float as reflect value, as key to MapIndex the return is:
https://play.golang.org/p/oY7vr1WgKk

Yes, this is an unfortunate wart that comes from the combination of NaN and the fact that reflect only provides MapKeys, not MapEntries.  MapEntries wouldn't be hard to do, I'd be in favor of doing it.  The question is whether it is worth the extra API just to accommodate NaN keys, something that is probably not advisable anyway.
Also see https://github.com/golang/go/issues/11104


How long the training takes?

HI! @mmaaz60 Thanks for your opensource this project.  I wonder how long the training procedure takes?  What kind of device you yse?

Hi @lxtGH,
Thank you for your interest in our work. We train MAVL model on approx. 1.3 M aligned image-text pairs. The dataset is the same as used in MDETR. The training took almost 3 days on 32 V100 GPUs. Following this the model is evaluated on diverse datasets (Table 1 & 2) for class-agnostic object detection without any finetuning.


Need documentation for webhooks

Description
As a client of Gateway services, I want to understand what APIs my services should expose in order to inter-operate fully with various Gateway servives.
We have webhook specifications in separate OpenAPI files from the service REST API specs. The specs for the webhook types and endpoints should also be published with the docs, and some additional documentation added regarding the purpose of the webhooks and the flows they support.
Requested by Odessa.

@JoeCap08055 is this fixed in https://github.com/ProjectLibertyLabs/gateway/pull/523

@JoeCap08055 is this fixed in #523

Nominally, yes, but something still seems to be missing. Or it might just be because the docs site doesn't update until we cut a new release.


Crafty.load fails with duplicate image

Tested in Crafty 0.6.2 on Ubuntu/Chrome.
Simplest case:
Crafty.load(['image.png', 'image.png'], function() { console.log("Done!"); });
The load-complete function never fires. Crafty fails silently and doesn't ever complete loading. Please at least raise an error highlighting the problem, so that I can more quickly track down the issue (ideally, mention the duplicate-loaded asset).
Another option is just loading and moving on, ignoring the fact that an asset was loaded twice (provided it doesn't actually download twice).

should be fixed via a5fd9872eceb97d5a86e146d6bf2ebc5191f50c0 now


Policy on breaking changes

The latest update brings a breaking change for formatted phone numbers.
Previously with 2.13.0 this would return a phone number without spaces and parentheses.
Phony.formatted(phone_number, :format => :international, :spaces => '')
now with version 2.14.0 I need to use this:
Phony.formatted(phone_number, :format => :international, :spaces => '', :local_spaces => '', :parentheses => false)
Simple to fix and I'm not a semver-fanatic, but would be nice to know if you have any thoughts of versioning and breaking changes?

Hi @espen, can you provide an example, please?

The example is above? Just wondering if you have any thoughts on implementing such changes either through a major or minor version, or if patch versions also may include breaking changes such as this example.
I've been using this gem for a while now and very happy with it :) Just want to clarify what to expect from new versions as this caught be my surprise and broke my tests.

I'm trying to figure out why you think all numbers are generally working like that? Is this about the North American number plan?

If so, after being asked too many times, and being referred to the NANP formatting including parentheses and dashes between local number parts, I finally gave up resisting when https://github.com/floere/phony/issues/252 came in.
But, to answer your question: a change in formatting rules is by Phony definition not breaking. A public interface change would be breaking. The idea here is that Phony users are assumed to trust Phony to gradually improve the formatting for all countries, for example like the NANP area, which got a big change with 2.14.0.
Consider my alternative: if ever I changed any country, and it would be a breaking change with a changing major version, phony would be at about major version 300.
This is why I decided Phony to not "break" when the formatting of a country changes, but just on interface changes.
To sum up, major version change: The public interface had a breaking change.
Minor version change: The public interface had a method added. A country had its formatting changed.
Patch: Everything else. For example, a country had its rules slightly changed.
So if you want to test against formatted numbers, then I am afraid you have to expect that with every release of Phony. I try not to have it happen too often, but it can happen.
I'm interested to hear your thoughts if you have any :)

phone_number = Phony.normalize("+1<PHONE_NUMBER>")
Phony.format(phone_number, :format => :international, :spaces => '')

Version 2.13.0 => "+15417543010"
Version 2.14.0 => "+1<PHONE_NUMBER>"

I cannot reproduce the behaviour with version 2.14.1:
ruby -e 'require "phony"; p Phony.format(Phony.normalize("+1<PHONE_NUMBER>"), :format => :international, :spaces => "")'

Returns "+1(541)754-3010".

Thanks for the info. Understand what you say about country formatting rules and changes. In this case it seems to me more than just that though since the method is adding more arguments and this is causing initial behaviour to break: https://github.com/floere/phony/commit/1bd48bd4e5cfa859f6e3f13eaaf2a602f823594a
And regarding 2.14.1, well it still has parentheses which was introduced in that commit.

@espen The commit you are referring to introduced the option to explicitly set the parentheses option to false. This is an added option to the API, which is why it increased the minor version number.
Based on feedback from #252, I changed the default of NANP (Canada, Mexico, US) to use parentheses around the NDC, and dashes in the local number. That necessitated that you can force parentheses to not show, hence the commit above. In itself, it is also a significant change to the NANP format, but since I need a breaking API change to increase the major number, it is only a minor change.

In any case, I hope you understand that I understand that breaking tests can be annoying. Cheers! I'm closing this because I answered your question – just reopen if you have more questions.

Ok, thanks for the info! :)


Corona Warn App is unable to find EXPOSURE_NOTIFICATION_API

The German CWA fails to find the API provided by microG.
microG version: 0.2.13
CWA Version: 1.5.0
Fairphone 2 open OS
I am getting the error:
Nearby.EXPOSURE_NOTIFICATION_API is not available
In the microG Settings I am told to open the App in order to activate the Exposure Notifications. Is this a hen-egg Problem I am experiencing here?

I installed that version combination just yesterday and normally you should get a popup that asks you to activate the exposure notification as soon as you open CWA the first time. Maybe it helps to reinstall and trigger that again?

I installed that version combination just yesterday and normally you should get a popup that asks you to activate the exposure notification as soon as you open CWA the first time. Maybe it helps to reinstall and trigger that again?

I tried reinstalling both CWA and microG. Nothing helped.
I have the exact same Problem for a few weeks now. I am using Fairphone Open OS. I read there were some problem with Bluetooth Chip not being compatible, but I think that should just mean more battery usage, right?

normally you should get a popup that asks you to activate the exposure notification

That is my Problem. I am simply not getting this popup :(

Had the same problem. Solved it with the following steps.

close / stop CWA
disable GPS and bluetooth
open CWA
Activate exposure notification (you are getting asked to enable GPS and Bluetooth)
enable GPS and bluetooth
Exposure notification is now active in CWA and microg

Nope, no popup.
If I look into the Permission tab in my phone settings, I only see the "taking picture and videos" permission

I had a similar problem with 0.2.12 on LOS 17.1 (GSI on Fairphone 3) after I updated the Corona Warn App from 1.3.1 to 1.5. I had to go back to 1.3.1 (and loose all my stored contacts from the last few days).

@ClundXIII
Did you check that everything is fine according to microG Self-Check?
Fairphone 2 does not support BTLE Advertisements. This means you can't broadcast IDs to nearby devices or let others know that you've been diagnosed positively. However you can still use CWA to get notified if you've been in close contact with a positively diagnosed person.

Did you check that everything is fine according to microG Self-Check?
Yes, all the boxes are checked, except the 3 on top about signature spoofing/checking.

Fairphone 2 does not support BTLE Advertisements. This means you can't broadcast IDs to nearby devices or let others know that you've been diagnosed positively. However you can still use CWA to get notified if you've been in close contact with a positively diagnosed person.
Yes, I read that somewhere in an issue. I was wondering if I could still broadcast with just heavy battery usage, but I guess no :(

except the 3 on top about signature spoofing/checking.

Well, they are required for microG to work.

I was wondering if I could still broadcast with just heavy battery usage

No, BTLE and normal Bluetooth are largely different protocols that are not compatible with each other.

Well, they are required for microG to work.

Specifically for CWA? Because that is so far the only app where I had Problems with.
So the solution is to get a custom ROM?

Had the same problem. Solved it with the following steps.
* close / stop CWA

* disable GPS and bluetooth

* open CWA

* Activate exposure notification (you are getting asked to enable GPS and Bluetooth)

* enable GPS and bluetooth

* Exposure notification is now active in CWA and microg

I can confirm that this solution works also for the Finnish official Covid-19 app. I had the same issue and now it is working after these steps.

@ClundXIII

Specifically for CWA? Because that is so far the only app where I had Problems with.

Most features in microG require signature spoofing. Only a few apps can make use of push notifications and most apps will get network location without signature spoofing. But that's basically it.

So the solution is to get a custom ROM?

There are multiple ways to patch existing ROMs for compatibility with microG. Easiest way probably is to use Nanodroid patcher.

Okay, that explains why I had no Problems yet. I don't use push notifications.

EDIT: Can you provide a screenshot of your Self-Check screen just to verify that this is really the issue?

Sure:

Also the Error message from CWA:

@ClundXIII Alright. Yes, it's definitely the missing signature spoofing causing trouble here. SERVICE_INVALID is the play service client library indicating that the play services (and/or play store) installed is considered "invalid" because the signature does not match due to missing signature spoofing.

Is there a way to patch the OS with nandroid with just Signature Spoofing? Because all the other features mentioned in the nandroid patcher are not really needed for the Fairphone open OS. I would like to stay as much vanilla as possible. (I already have root, the fdroid privileged extension and pretty much already minimal Android)

Yes, the nanodroid-patcher package can do this, for details check https://gitlab.com/Nanolx/NanoDroid/-/blob/master/doc/microGsetup.md

I believe I'm experiencing the same issue with a ShiftPhone 5me and Shift's Google-Free OS.

I am experiencing the same issue with signature spoofing enabled

Okay. I had to install FakeStore. Now it works.

@mar-v-in
I finally found some time and motivation to patch signature spoofing. I used tingle and everything works now!
Thank you very much :)


Word with non-ascii not recorded into autocomplete

In my LaTeX document, if I type a word such as ligevægt, and begin typing it again, ligevægt is not suggested.
Steps to reproduce:
touch tmp.tex
vim tmp.tex

Now paste ligevægt into the first line, and type a newline. Try starting to type the word. Notice how nothing is suggested.
Now find an empty line and paste in a word with just ascii characters. For example cakecakecake would do. On another empty line try starting to type cakecakecake, and see how it's suggested.
I would have expected ligevægt to be suggested, just like cakecakecake was.
I tried a few other characters, I was unable to find a non-ascii character exhibiting the desired behaviour. The characters I tried was æøåöł.

I'm afraid you're on the wrong track here, syntastic has nothing to do with autocomplete.  Perhaps post to vim_users instead?


Completed RecipeView and added LogOutView

I'll work on change password/create an account based on this code!


Create pull request

Create pull request for merging feature/body branch into develop.

Pull request created.


Add maxWidth prop to various components for passthrough to form-field

Summary
This adds a maxWidth prop to various form components (input, textarea and select) for passthrough to the same in terra-form-field.
Closes #2043

I think you'll need to update your jest snapshots.


[CH-328] support function isNaN

Changelog category (leave one):

New Feature

related issue: issue-328

Can one of the admins verify this patch?

test this please


General availability of Microsoft Graph Go SDK

Tracks all work planned as part of the SDK general availability.

closing this.  tracking the goal as milestone.


Allow .txt file extension for plain text robot files

Currently the only files that are parsed are .robot for plain text and .py for python. If any files with other extensions are picked up by the includePaths patterns then it looks like they get filtered out.
const allowedFileExts = new Set(
  Config.getHasPythonKeywords() ? [".robot", ".py"] : [".robot"]
);

...

const filePaths = files
  // User can configure patterns that include other files than .robot.
  // Filter those out.
  .filter(fileUri => isAllowedFile(fileUri))
  .map(fileUri => fileUri.fsPath);

Some RF projects also use the alternative .txt extension for plain text robot files (particularly older projects). It would be great if these could be detected and parsed as well, either through a configuration option for allowed file extensions or by not filtering the includePaths results and just using includePaths/excludePaths to filter if needed.

Thank you for creating an issue! Yes I think we could allow also .txt files to be parsed as it is an allowed file extension for plain text format robot files. This allows the language server to become aware of the keywords and variables defined in .txt files.
There is however the issue that VSCode won't recognize the .txt files to be robot files, so syntax highlighting, completion suggestions or other editing features won't be available when editing those files. There are 3 static (i.e. we can't use a user configurable option) ways how to configure for VSCode to recognize a file to belong to certain language (as documented here):

By file extension. This is what we use now (.robot). I'm reluctant to add .txt here, as it's usually associated with plain text files.
By filename. We could use for example .robot.txt, but that's not how the files are named and if you need to change the filename, you might as well rename them to .robot
First line inside the file. We could try to recognize a table (e.g. *** Settings ***). but it's not reliable if you have for example comments at the beginning of the file.

Thanks, @tomi! You raise a very good point about the language recognition. Globally treating .txt files as robot framework would not be ideal :-)
At the moment I'm using a workspace setting to force VSCode to recognise the .txt extension as robot for this specific project:
"files.associations": {
    "*.txt": "robot"
}

That gives me robot syntax highlighting for my .txt files. I can see from the logs that it is also triggering a search for completion suggestions, although without any results. I was hoping that if we allowed the language server to parse .txt files then it would be enough to get intellisense working as well.
Allowing the user to configure the association with a workspace- or user-level setting rather than having the extension control it seems like a good compromise. That way we can treat the files differently in different projects as needed. In the rare case where there might be a plain .txt file in my robot workspace I can always just manually switch the language once the file is open.
What do you think?

Oh nice, I wasn't aware that you can associate files like that! Yes I think this is totally doable. I'll add support for .txt files as soon as I have time. It's probably better to leave it so that by default only .robot files are parsed, but you can add a pattern to include .txt as well:
"rfLanguageServer.includePaths": [
    "**/*.robot",
    "**/*.txt"
]

@conclavia Please check out the newly released version 2.0.0. It includes a support for .txt files.