fix branchWithoutIssueNumTest flaky test

this test sometimes fails, need to investigate and fix

any notes or error log on this?

no I dont have much but I saw couple times in PR run it failed, once locally, probably we could run this test several times and check how it behaves

https://github.com/cieslarmichal/faker-cxx/actions/runs/10496062791/job/29075874684#step:11:3895

I ran tests several times locally while printing to console
generatedNoun: e
/home/combine/projects/faker-cxx/tests/modules/git_test.cpp:99: Failure
Value of: std::ranges::any_of(word::nouns, [generatedNoun](const std::string_view& word) { return word == generatedNoun; })
  Actual: false
Expected: true

it prints a character e for nouns

I think we must not have words like warm-up this in the list of words in word_store.h since we are splitting the words with - in the test case

Ok lets remove dash from thoses words so it would be ebook


Support checkbox and nested lists.

[x] I think a checkbox for personal goals would be really nice, especially since there's the "Allow entries in the future" option.

And indented / nested lists. So currently you can only do:

Item 1
Item 2

Where I'd like to be able to do:

Item 1

Item 1.1

Item 2

Hi @BenTearzz, thanks for the feedback!
Totally agree regarding nested lists. I'm already working on supporting this :)
Currently, I'd rather not add support for checkboxes, though. I'd like to keep the editor UI as simple as possible and therefore avoid adding any new buttons.

Actually yeah, I've thought more about it and a checkbox wouldn't fit in a diary, it's much better suited for a to-do list. Whereas the diary would be better for stating current progress on those goals and if they've been completed... so in other words, understandable! :D


haskell.compiler.ghcHEAD: 9.3.20210504 -> 9.3.20210806

Motivation for this change
Just bumping the ghcHEAD revision, there're some performance improvements there.
I checked that the resulting ghc can compile code.
However, there was an issue with the hscolour package (with or without this PR), so I couldn't try building a Haskell package with Nix. In my opinion, that's a separate issues ince this PR is not making things worse.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Thanks! This seems reasonable, and it looks like it is building at least on Linux.
@utdemir I'll go ahead and merge this in, but can you keep an eye on Hydra and/or https://github.com/cdepillabout/nix-haskell-updates-status the next 24 hours or so to make sure that this doesn't cause any additional breakage?

Thanks @cdepillabout . I'll keep an eye on it.

@cdepillabout , well, it did not build on darwin, because a dependency has failed (that does not seem relevant to this PR).
When I look at the Hydra jobset evaluations, I don't see a large number of changes to the failed jobs, which looks promising; however when I search for haskell.packages.ghcHEAD on the Jobs tab I don't get any results, I was expecting to get some.
So, in the end I noticed that I don't really know what to look at on Hydra. Sorry to leave this to you, but could you also have a look to see if everything is ok?

@utdemir Thanks for following up.
On our build reports, it looks like haskell.compiler.ghcHEAD is just timing out on Darwin:
https://github.com/cdepillabout/nix-haskell-updates-status/blob/48be9e27c81bc436abc012fe4d050eed440a768f/README.md
If you click through, you can find the job that is timing out:
https://hydra.nixos.org/build/149762652
I took a quick look at this, and I think this is happening because the derivation for ghcHEAD doesn't have meta.timeout set, while the other GHCs derivations do.
ghcHEAD:
https://github.com/NixOS/nixpkgs/blob/c84e14dc3e4ff4438bb2bbc5b0fb4c6258c8a1e4/pkgs/development/compilers/ghc/head.nix#L310-L317
ghc901:
https://github.com/NixOS/nixpkgs/blob/c84e14dc3e4ff4438bb2bbc5b0fb4c6258c8a1e4/pkgs/development/compilers/ghc/9.0.1.nix#L293-L303
I fixed this by adding the timeout = line to the ghcHEAD derivation as well in https://github.com/NixOS/nixpkgs/pull/133422/commits/2d1b5aa1fe72ef401a91e2e8408a939be5c1b238 on https://github.com/NixOS/nixpkgs/pull/133422.
Hopefully this should cause the timeout to not happen anymore.

when I search for haskell.packages.ghcHEAD on the Jobs tab I don't get any results, I was expecting to get some

Ah, so we don't actually build any packages from haskell.packages.ghcHEAD on Hydra.  We don't really expect that any packages will be able to be built.  But we still provide haskell.compiler.ghcHEAD for users that want to use it, and build it on Hydra.
So the only thing you should be able to find a job for is haskell.compiler.ghcHEAD.


Unknown system error

Scansionando https://www.ismonnet.edu.it compare nei log il seguente errore:
LH:common-legislation-cookie-amount-check:warn Caught exception: spawn Unknown system error -86

Da indagare.

$ node dist --type school --destination dist/report --report report --website https://www.ismonnet.edu.it                                                 ~/projects/pa-website-validator
[WARNING] Directory does not exist..
[INFO] Directory created at: dist/report
  LH:config:warn IFrameElements gatherer requested, however no audit requires it. +0ms
  LH:config:warn Inputs gatherer requested, however no audit requires it. +0ms
  LH:status Connecting to browser +25ms
  LH:status Resetting state with about:blank +6ms
  LH:status Navigating to about:blank +0ms
  LH:status Benchmarking machine +35ms
  LH:status Initializing… +1s
  LH:status Preparing target for navigation mode +2ms
  LH:status Running defaultPass pass CSSUsage, JsUsage, ViewportDimensions, ConsoleMessages, AnchorElements, ImageElements, LinkElements, MetaElements, ScriptElements, IFrameElements, Inputs, MainDocumentContent, GlobalListeners, Doctype, DOMStats, OptimizedImages, PasswordInputsWithPreventedPaste, ResponseCompression, TagsBlockingFirstPaint, FontSize, EmbeddedContent, RobotsTxt, TapTargets, Accessibility, TraceElements, InspectorIssues, SourceMaps, FullPageScreenshot, securityDomainNameCheck, fontsCheck, bootstrapCheck, bootstrapItaliaWPCheck, bootstrapItaliaCheck, themeCheck, themeVersionCheck, legislationAccessibilityDeclarationIsPresent, legislationPrivacyIsPresent, menuStructureMatchModel, menuStructureScuolaSecondLevelMatchModel, serviziStructure, controlledVocabularies, legislationCookieAmount, legislationCookieDomain, securityCertificateExpiration, securityHttpsIsPresent, securityTlsCheck, securityIpLocation, securityCipherCheck +4ms
  LH:status Resetting state with about:blank +0ms
  LH:status Navigating to about:blank +0ms
  LH:status Preparing target for navigation +5ms
  LH:status Cleaning origin data +77ms
  LH:status Cleaning browser cache +3ms
  LH:status Preparing network conditions +3ms
  LH:status Beginning devtoolsLog and trace +5ms
  LH:status Loading page & waiting for onload +31ms
  LH:status Navigating to https://www.ismonnet.edu.it/ +1ms
  LH:status Gathering in-page: CSSUsage +5s
  LH:status Gathering in-page: JsUsage +0ms
  LH:status Gathering in-page: ViewportDimensions +0ms
  LH:status Gathering in-page: ConsoleMessages +0ms
  LH:status Gathering in-page: AnchorElements +0ms
  LH:status Gathering in-page: ImageElements +1ms
  LH:status Gathering in-page: LinkElements +0ms
  LH:status Gathering in-page: MetaElements +0ms
  LH:status Gathering in-page: ScriptElements +0ms
  LH:status Gathering in-page: IFrameElements +0ms
  LH:status Gathering in-page: Inputs +0ms
  LH:status Gathering in-page: MainDocumentContent +0ms
  LH:status Gathering in-page: GlobalListeners +0ms
  LH:status Gathering in-page: Doctype +0ms
  LH:status Gathering in-page: DOMStats +0ms
  LH:status Gathering in-page: OptimizedImages +1ms
  LH:status Gathering in-page: PasswordInputsWithPreventedPaste +0ms
  LH:status Gathering in-page: ResponseCompression +0ms
  LH:status Gathering in-page: TagsBlockingFirstPaint +0ms
  LH:status Gathering in-page: FontSize +0ms
  LH:status Gathering in-page: EmbeddedContent +0ms
  LH:status Gathering in-page: RobotsTxt +0ms
  LH:status Gathering in-page: TapTargets +0ms
  LH:status Gathering in-page: Accessibility +0ms
  LH:status Gathering in-page: TraceElements +0ms
  LH:status Gathering in-page: InspectorIssues +0ms
  LH:status Gathering in-page: SourceMaps +0ms
  LH:status Gathering in-page: FullPageScreenshot +0ms
  LH:status Gathering in-page: securityDomainNameCheck +0ms
  LH:status Gathering in-page: fontsCheck +0ms
  LH:status Gathering in-page: bootstrapCheck +0ms
  LH:status Gathering in-page: bootstrapItaliaWPCheck +0ms
  LH:status Gathering in-page: bootstrapItaliaCheck +0ms
  LH:status Gathering in-page: themeCheck +0ms
  LH:status Gathering in-page: themeVersionCheck +1ms
  LH:status Gathering in-page: legislationAccessibilityDeclarationIsPresent +0ms
  LH:status Gathering in-page: legislationPrivacyIsPresent +0ms
  LH:status Gathering in-page: menuStructureMatchModel +0ms
  LH:status Gathering in-page: menuStructureScuolaSecondLevelMatchModel +0ms
  LH:status Gathering in-page: serviziStructure +0ms
  LH:status Gathering in-page: controlledVocabularies +0ms
  LH:status Gathering in-page: legislationCookieAmount +0ms
  LH:status Gathering in-page: legislationCookieDomain +0ms
  LH:status Gathering in-page: securityCertificateExpiration +0ms
  LH:status Gathering in-page: securityHttpsIsPresent +0ms
  LH:status Gathering in-page: securityTlsCheck +0ms
  LH:status Gathering in-page: securityIpLocation +0ms
  LH:status Gathering in-page: securityCipherCheck +0ms
  LH:status Gathering trace +0ms
  LH:status Gathering devtoolsLog & network records +162ms
  LH:status Gathering: CSSUsage +6ms
  LH:status Gathering: JsUsage +124ms
  LH:status Gathering: ViewportDimensions +14ms
  LH:status Gathering: ConsoleMessages +1ms
  LH:status Gathering: AnchorElements +1ms
  LH:status Gathering: ImageElements +51ms
  LH:status Gathering: LinkElements +241ms
  LH:status Gathering: MetaElements +9ms
  LH:status Gathering: ScriptElements +4ms
  LH:status Gathering: IFrameElements +38ms
  LH:status Gathering: Inputs +3ms
  LH:status Gathering: MainDocumentContent +5ms
  LH:status Gathering: GlobalListeners +8ms
  LH:status Gathering: Doctype +1ms
  LH:status Gathering: DOMStats +1ms
  LH:status Gathering: OptimizedImages +3ms
  LH:status Gathering: PasswordInputsWithPreventedPaste +175ms
  LH:status Gathering: ResponseCompression +1ms
  LH:status Gathering: TagsBlockingFirstPaint +25ms
  LH:status Gathering: FontSize +2ms
  LH:status Gathering: EmbeddedContent +96ms
  LH:status Gathering: RobotsTxt +1ms
  LH:status Gathering: TapTargets +51ms
  LH:status Gathering: Accessibility +60ms
  LH:status Gathering: TraceElements +251ms
  LH:status Gathering: InspectorIssues +44ms
  LH:status Gathering: SourceMaps +1ms
  LH:status Gathering: FullPageScreenshot +2s
  LH:status Gathering: securityDomainNameCheck +5s
  LH:status Gathering: fontsCheck +1ms
  LH:status Gathering: bootstrapCheck +1ms
  LH:status Gathering: bootstrapItaliaWPCheck +0ms
  LH:status Gathering: bootstrapItaliaCheck +2ms
  LH:status Gathering: themeCheck +1ms
  LH:status Gathering: themeVersionCheck +1ms
  LH:status Gathering: legislationAccessibilityDeclarationIsPresent +1ms
  LH:status Gathering: legislationPrivacyIsPresent +1ms
  LH:status Gathering: menuStructureMatchModel +1ms
  LH:status Gathering: menuStructureScuolaSecondLevelMatchModel +1ms
  LH:status Gathering: serviziStructure +0ms
  LH:status Gathering: controlledVocabularies +1ms
  LH:status Gathering: legislationCookieAmount +1ms
  LH:status Gathering: legislationCookieDomain +0ms
  LH:status Gathering: securityCertificateExpiration +1ms
  LH:status Gathering: securityHttpsIsPresent +2ms
  LH:status Gathering: securityTlsCheck +0ms
  LH:status Gathering: securityIpLocation +1ms
  LH:status Gathering: securityCipherCheck +1ms
  LH:status Populate base artifacts +1ms
  LH:status Get webapp manifest +0ms
  LH:status Collect stacks +1ms
  LH:status Running offlinePass pass ServiceWorker +8ms
  LH:status Resetting state with about:blank +1ms
  LH:status Navigating to about:blank +0ms
  LH:status Preparing target for navigation +5ms
  LH:status Preparing network conditions +0ms
  LH:status Beginning devtoolsLog and trace +2ms
  LH:status Loading page & waiting for onload +0ms
  LH:status Navigating to https://www.ismonnet.edu.it/ +0ms
  LH:status Gathering in-page: ServiceWorker +2s
  LH:status Gathering devtoolsLog & network records +0ms
  LH:status Gathering: ServiceWorker +7ms
  LH:status Disconnecting from browser... +0ms
  LH:status Cleaning origin data +0ms
  LH:status Analyzing and running audits... +3ms
  LH:status Auditing: Uses HTTPS +3ms
  LH:status Auditing: Registers a service worker that controls page and `start_url` +3ms
  LH:status Auditing: Has a `<meta name="viewport">` tag with `width` or `initial-scale` +2ms
  LH:status Auditing: First Contentful Paint +1ms
  LH:status Auditing: Largest Contentful Paint +23ms
  LH:status Auditing: First Meaningful Paint +11ms
  LH:status Auditing: Speed Index +9ms
  LH:status Auditing: Screenshot Thumbnails +174ms
  LH:status Auditing: Final Screenshot +125ms
  LH:status Auditing: Total Blocking Time +1ms
  LH:status Auditing: Max Potential First Input Delay +15ms
  LH:status Auditing: Cumulative Layout Shift +8ms
  LH:status Auditing: No browser errors logged to the console +1ms
  LH:status Auditing: Initial server response time was short +3ms
  LH:status Auditing: Time to Interactive +1ms
  LH:status Auditing: User Timing marks and measures +0ms
  LH:status Auditing: Avoid chaining critical requests +2ms
  LH:status Auditing: Avoid multiple page redirects +2ms
  LH:status Auditing: Web app manifest and service worker meet the installability requirements +3ms
  LH:status Auditing: Provides a valid `apple-touch-icon` +3ms
  LH:status Auditing: Configured for a custom splash screen +1ms
  LH:status Auditing: Sets a theme color for the address bar. +1ms
  LH:status Auditing: Manifest has a maskable icon +1ms
  LH:status Auditing: Content is sized correctly for the viewport +1ms
  LH:status Auditing: Displays images with correct aspect ratio +1ms
  LH:status Auditing: Serves images with appropriate resolution +1ms
  LH:status Auditing: Fonts with `font-display: optional` are preloaded +1ms
  LH:status Auditing: Avoids deprecated APIs +1ms
  LH:status Auditing: Minimizes main-thread work +2ms
  LH:status Auditing: JavaScript execution time +13ms
  LH:status Auditing: Preload key requests +4ms
  LH:status Auditing: Preconnect to required origins +1ms
  LH:status Auditing: All text remains visible during webfont loads +1ms
  LH:status Auditing: Diagnostics +7ms
  LH:status Auditing: Network Requests +0ms
  LH:status Auditing: Network Round Trip Times +1ms
  LH:status Auditing: Server Backend Latencies +1ms
  LH:status Auditing: Tasks +1ms
  LH:status Auditing: Metrics +0ms
  LH:status Auditing: Performance budget +1ms
  LH:status Auditing: Timing budget +2ms
  LH:status Auditing: Keep request counts low and transfer sizes small +1ms
  LH:status Auditing: Minimize third-party usage +2ms
  LH:status Auditing: Lazy load third-party resources with facades +3ms
  LH:status Auditing: Largest Contentful Paint element +2ms
  LH:status Auditing: Largest Contentful Paint image was not lazily loaded +0ms
  LH:status Auditing: Avoid large layout shifts +1ms
  LH:status Auditing: Avoid long main-thread tasks +1ms
  LH:status Auditing: Avoids `unload` event listeners +4ms
  LH:status Auditing: Avoid non-composited animations +0ms
  LH:status Auditing: Image elements have explicit `width` and `height` +1ms
  LH:status Auditing: Page has valid source maps +1ms
  LH:status Auditing: Preload Largest Contentful Paint image +2ms
  LH:status Auditing: Ensure CSP is effective against XSS attacks +0ms
  LH:status Auditing: Full-page screenshot +1ms
  LH:status Auditing: Script Treemap Data +0ms
  LH:status Auditing: Site works cross-browser +36ms
  LH:status Auditing: Page transitions don't feel like they block on the network +1ms
  LH:status Auditing: Each page has a URL +0ms
  LH:status Auditing: `[accesskey]` values are unique +1ms
  LH:status Auditing: `[aria-*]` attributes match their roles +1ms
  LH:status Auditing: `button`, `link`, and `menuitem` elements have accessible names +2ms
  LH:status Auditing: `[aria-hidden="true"]` is not present on the document `<body>` +2ms
  LH:status Auditing: `[aria-hidden="true"]` elements do not contain focusable descendents +3ms
  LH:status Auditing: ARIA input fields have accessible names +3ms
  LH:status Auditing: ARIA `meter` elements have accessible names +0ms
  LH:status Auditing: ARIA `progressbar` elements have accessible names +2ms
  LH:status Auditing: `[role]`s have all required `[aria-*]` attributes +1ms
  LH:status Auditing: Elements with an ARIA `[role]` that require children to contain a specific `[role]` have all required children. +1ms
  LH:status Auditing: `[role]`s are contained by their required parent element +1ms
  LH:status Auditing: `[role]` values are valid +1ms
  LH:status Auditing: ARIA toggle fields have accessible names +1ms
  LH:status Auditing: ARIA `tooltip` elements have accessible names +2ms
  LH:status Auditing: ARIA `treeitem` elements have accessible names +2ms
  LH:status Auditing: `[aria-*]` attributes have valid values +1ms
  LH:status Auditing: `[aria-*]` attributes are valid and not misspelled +3ms
  LH:status Auditing: Buttons have an accessible name +3ms
  LH:status Auditing: The page contains a heading, skip link, or landmark region +3ms
  LH:status Auditing: Background and foreground colors have a sufficient contrast ratio +3ms
  LH:status Auditing: `<dl>`'s contain only properly-ordered `<dt>` and `<dd>` groups, `<script>`, `<template>` or `<div>` elements. +3ms
  LH:status Auditing: Definition list items are wrapped in `<dl>` elements +2ms
  LH:status Auditing: Document has a `<title>` element +1ms
  LH:status Auditing: `[id]` attributes on active, focusable elements are unique +4ms
  LH:status Auditing: ARIA IDs are unique +1ms
  LH:status Auditing: No form fields have multiple labels +3ms
  LH:status Auditing: `<frame>` or `<iframe>` elements have a title +2ms
  LH:status Auditing: Heading elements appear in a sequentially-descending order +1ms
  LH:status Auditing: `<html>` element has a `[lang]` attribute +3ms
  LH:status Auditing: `<html>` element has a valid value for its `[lang]` attribute +4ms
  LH:status Auditing: Image elements have `[alt]` attributes +3ms
  LH:status Auditing: `<input type="image">` elements have `[alt]` text +3ms
  LH:status Auditing: Form elements have associated labels +2ms
  LH:status Auditing: Links have a discernible name +1ms
  LH:status Auditing: Lists contain only `<li>` elements and script supporting elements (`<script>` and `<template>`). +3ms
  LH:status Auditing: List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements +3ms
  LH:status Auditing: The document does not use `<meta http-equiv="refresh">` +4ms
  LH:status Auditing: `[user-scalable="no"]` is not used in the `<meta name="viewport">` element and the `[maximum-scale]` attribute is not less than 5. +2ms
  LH:status Auditing: `<object>` elements have alternate text +4ms
  LH:status Auditing: No element has a `[tabindex]` value greater than 0 +2ms
  LH:status Auditing: Cells in a `<table>` element that use the `[headers]` attribute refer to table cells within the same table. +3ms
  LH:status Auditing: `<th>` elements and elements with `[role="columnheader"/"rowheader"]` have data cells they describe. +4ms
  LH:status Auditing: `[lang]` attributes have a valid value +3ms
  LH:status Auditing: `<video>` elements contain a `<track>` element with `[kind="captions"]` +3ms
  LH:status Auditing: Custom controls have associated labels +2ms
  LH:status Auditing: Custom controls have ARIA roles +0ms
  LH:status Auditing: User focus is not accidentally trapped in a region +0ms
  LH:status Auditing: Interactive controls are keyboard focusable +0ms
  LH:status Auditing: Interactive elements indicate their purpose and state +0ms
  LH:status Auditing: The page has a logical tab order +0ms
  LH:status Auditing: The user's focus is directed to new content added to the page +0ms
  LH:status Auditing: Offscreen content is hidden from assistive technology +0ms
  LH:status Auditing: HTML5 landmark elements are used to improve navigation +0ms
  LH:status Auditing: Visual order on the page follows DOM order +0ms
  LH:status Auditing: Uses efficient cache policy on static assets +0ms
  LH:status Auditing: Avoids enormous network payloads +3ms
  LH:status Auditing: Defer offscreen images +0ms
  LH:status Auditing: Eliminate render-blocking resources +5ms
  LH:status Auditing: Minify CSS +5ms
  LH:status Auditing: Minify JavaScript +40ms
  LH:status Auditing: Reduce unused CSS +63ms
  LH:status Auditing: Reduce unused JavaScript +4ms
  LH:status Auditing: Serve images in next-gen formats +8ms
  LH:status Auditing: Efficiently encode images +10ms
  LH:status Auditing: Enable text compression +10ms
  LH:status Auditing: Properly size images +6ms
  LH:status Auditing: Use video formats for animated content +5ms
  LH:status Auditing: Remove duplicate modules in JavaScript bundles +6ms
  LH:status Auditing: Avoid serving legacy JavaScript to modern browsers +4ms
  LH:status Auditing: Page has the HTML doctype +71ms
  LH:status Auditing: Properly defines charset +1ms
  LH:status Auditing: Avoids an excessive DOM size +1ms
  LH:status Auditing: Avoids requesting the geolocation permission on page load +1ms
  LH:status Auditing: No issues in the `Issues` panel in Chrome Devtools +1ms
  LH:status Auditing: Avoids `document.write()` +0ms
  LH:status Auditing: Avoids front-end JavaScript libraries with known security vulnerabilities +1ms
  LH:status Auditing: Detected JavaScript libraries +4ms
  LH:status Auditing: Avoids requesting the notification permission on page load +0ms
  LH:status Auditing: Allows users to paste into password fields +1ms
  LH:status Auditing: Use HTTP/2 +1ms
  LH:status Auditing: Uses passive listeners to improve scrolling performance +5ms
  LH:status Auditing: Document has a meta description +1ms
  LH:status Auditing: Page has successful HTTP status code +0ms
  LH:status Auditing: Document uses legible font sizes +1ms
  LH:status Auditing: Links have descriptive text +1ms
  LH:status Auditing: Links are crawlable +1ms
  LH:status Auditing: Page isn’t blocked from indexing +2ms
  LH:status Auditing: robots.txt is valid +1ms
  LH:status Auditing: Tap targets are sized appropriately +1ms
  LH:status Auditing: Document has a valid `hreflang` +3ms
  LH:status Auditing: Document avoids plugins +1ms
  LH:status Auditing: Document has a valid `rel=canonical` +0ms
  LH:status Auditing: Structured data is valid +1ms
  LH:status Auditing: Nome del dominio +0ms
  LH:status Auditing: Font in pagina +0ms
  LH:status Auditing: Versione di bootstrap +0ms
  LH:status Auditing: Libreria bootstrap italia +1ms
  LH:status Auditing: Tema wordpress +11ms
  LH:status Auditing: Versione tema wordpress +5ms
  LH:status Auditing: Presenza Dichiarazione di Accessibilità +186ms
  LH:status Auditing: Presenza del link per la privacy policy +3s
  LH:status Auditing: Le voci del menù rispettano il modello +2s
  LH:status Auditing: Le voci di secondo livello per "La scuola" rispettano il modello +2s
  LH:status Auditing: La scheda di servizio analizzata rispetta il modello +2s
  LH:status Auditing: I vocaboli appartengono al vocabolario scuole +2s
  LH:status Auditing: Quantità di Cookie +2s
  LH:common-legislation-cookie-amount-check:warn Caught exception: spawn Unknown system error -86 +3ms
  LH:status Auditing: Domini dei cookie +0ms
  LH:common-legislation-cookie-domain-check:warn Caught exception: spawn Unknown system error -86 +1ms
  LH:status Auditing: Scadenza del certificato +0ms
  LH:status Auditing: Presenza protocollo HTTPS +2s
  LH:status Auditing: Versione del TLS +1ms
  LH:status Auditing: Localizzazione indirizzo IP +2s
  LH:status Auditing: Versione della suite di cifratura +5ms
  LH:status Generating results... +4s
[INFO] Status result: true
[INFO] HTML report file: dist/report/report.html
[INFO] JSON report file: dist/report/report.json

L'errore non si è più presentato (e l'audit in questione non è più esistente).

@tensor5 dopo varie prove la casistica non risulta riproducibile.
Riusciresti a fornire dei dettagli/contesto in più sulla casistica di errore?

Risolto (1fbb5139c5f37f891d0dfb8e9497ceb86e19f3ff).


Unable to Onboard a new hotspot using the maker starter app

Hello,
I'm am trying to onboard a new hotspot, but unable to finish the process. I keep getting a 404 hotspot not found when checking the hotspot detail using the helium sdk.
getHotspotDetails(hotspotAddress)
File: HotspotSetupWifiConnectingScreen.tsx
  const goToNextStep = useCallback(async () => {
    const address = await getAddress()
    const hotspot = await getHotspotDetails(hotspotAddress)
    if (hotspot && hotspot.owner === address) {
      navigation.replace('OwnedHotspotErrorScreen')
    } else if (hotspot && hotspot.owner !== address) {
      navigation.replace('NotHotspotOwnerErrorScreen')
    } else {
      navigation.replace('HotspotSetupLocationInfoScreen', {
        hotspotAddress,
        addGatewayTxn,
        hotspotType,
      })
    }
  }, [addGatewayTxn, hotspotAddress, hotspotType, navigation])

It seems like getting the hotspot information is able to be retrieved from the helium api.

My guess is you haven’t pulled the gateway address from the Hotspot itself, but I’ve tagged an engineer to clarify.

My guess is you haven’t pulled the gateway address from the Hotspot itself, but I’ve tagged an engineer to clarify.

Yes this is correct. A 404 is expected when onboarding a hotspot as it has not been added to the chain yet. The hotspot address should be read by the app via bluetooth or your own website/api.

Closing this as its an expected error. Let us know if you still need assistance.


Support concurrency

So I did a bit of investigation for https://github.com/Raku/Pod-To-HTML/issues/63...
It seems find-headings is unsafe, so made it into a method and protected with monitor. ??? Problem is gone.
It seems Template::Mustache triggers some rakudo/moar(?) issue as well, as it refused to compile some pages (usually 5 plus-minus a couple from the whole documentation, always different ones) with a bogus error (self being null). So created a special loop catching issues doing some retries. It fixed the problem I saw. By the way, Cro::WebApp tested had no issues like this one and was on average 2.5x to 5x times faster, but to use it we need a smooth API at hand.
Did some crunching with 24 threads rendering whole documentation 100 times in a row. In three crunch sessions saw a moarvm bug once, which is, I suspect, known and so very obscure we probably don't want to deal with it here (I saw it reported in different places).
Otherwise, it became a lot more stable unless you really stresstest it, so I believe the ticket can be closed.

I am thinking about reverting this PR, unless you give me a very good reason to do so. We don't know if it really addresses what it says it does, since it does not add new tests to the test set. And, on the other hand, it's built on top of another PR that is apparently causing some issues.

I am thinking about reverting this PR, unless you give me a very good reason to do so

A (IMO) good reason not to revert it just now: reverting needs a time and a place. In general, it is not a solution. Some issues were solved by this PR but it introduced regressions.
A real solution: increase test coverage and fix regressions.
Result: you fixed old bugs and regressions are dealt with.
A temporary solution: revert.
Result: you get old bugs back.
AFAIK, we do not update docs automatically. Website is not broken right now. Website was not updated very often anyway. Is it impossible to wait until tomorrow for me to deal with regressions? We update website manually when possible, but it is absolutely very desperate to do it right now? We are not pressured to do a revert and can provide a real solution instead of messing with history. I don't get it.

There was no good reason to merge it anyway, since it was not proved (by a test) it solved what it was supposed to solve.
Don't worry about docs now, I got a configuration that works but we really need to work out the issues in this module, starting with the very meager test suite.

There was no good reason to merge it anyway, since it was not proved (by a test) it solved what it was supposed to solve.

Tests do not prove there are no bugs at all. Especially it is very true for concurrency issues and this PR deals with a couple of those.
Just get someone to review the code. This PR uses common, proven techniques of dealing with concurrency issues.
This PR does result in an observable improvement in stresstesting I did, you can reproduce it if you want. Run the gist in the related ticket for 100 times using a lot of threads and see errors. Apply those patches and see how it renders without errors.
But such heavy stresstesting is not suitable for most users. Not everyone would want to render docs for 100 or for 1000 times using 24 or more threads. Possibly we can go with xt/ directory with such a test, but this is not in any case a reason to reject PR that does improve stability.

I'm not rejecting it, it's already approved, and I did approve and merged it. xt tests are good enough, though.
Also, tests are not written for your code specifically. They are written to defend your code. If you don't write a test for this code proving that there are no errors, someone might come up in the future, wipe out this "monitor" thing and get back to the former error. So, please try and add these xt tests to the repo when you are done with the rest of the issues.

Tests are going to protect your code also when you refactor the code for #80, which you will probably need to do, since #86 is critical.


AWS is returning previous user session.

Describe the bug
This issue is in continuation with our reported bug here:
https://github.com/aws-amplify/amplify-ios/issues/1360
As per the fix for 1360 it seems that our issue for username has been resolved. However, now another issue is observed where previous user who was signed out is successfully logged in.
Pre-requisites to run POC:
1- pod install
2- replace '*' with necessary ids/info in amplifyconfiguration.json
3- provide two different users' data in ViewController.swift (Line# 14)
POC to reproduce issue:
AmplifyPOC.zip
Steps To Reproduce
Steps within POC to reproduce issue:

1. Tap "Signin User1" button.
2. Wait for success
3. Tap "Signin User2" button.
4. While log in is in process from step 3, Tap "Signin User2" again in POC.
5. See console logs in POC. You will notice that first "User 1" will be returned then "User 2" will be returned.

NOTE: In the POC, whenever a user is being logged in, the login call is preceded by log out.

Expected behavior
It should fetch the correct/new user session rather than old user session.
Amplify Framework Version
1.17.0
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
4.2
CLI version
Not applicable
Xcode version
12.5
Relevant log output
No response
Is this a regression?
Yes
Regression additional context
Previous version details are mentioned in this bug: https://github.com/aws-amplify/amplify-ios/issues/1360
Device
iPhone7+
iOS Version
14.5
Specific to simulators
No both Simulator and Devices are experiencing it.
Additional context
No response

Hi @shahan-ayyub, thanks for the details and sample app. Taking a look at the code, I can see references to both Amplify.Auth and Amplify.Storage. I'll provision both and run the app to better understand what the issue is.
The code from the sample app
func signin(_ user: User) {
        //remove this get url and no issues will occur
        startDownloadingUrls(for: user)

        Amplify.Auth.signOut { result in
            switch result {
            case .success:
                Amplify.Auth.signIn(username: user.email) { result in
                    do {
                        let result = try result.get()
                        switch result.nextStep {
                        case .done:
                            self.updateMessage("Signin Successfull")
                        case .confirmSignInWithCustomChallenge:
                            Amplify.Auth.confirmSignIn(challengeResponse: "pass_\(user.password)") { result in
                                do {
                                    let result = try result.get()
                                    switch result.nextStep {
                                    case .done:
                                        self.updateMessage("Signin Confirm Successfull")

                                    default:
                                        self.updateMessage("Unknown next step while confirming sign in \(result.nextStep)")
                                    }
                                } catch {
                                    self.updateMessage("Error while confirming sign in \(error.localizedDescription)")
                                }
                            }
                        default:
                            self.updateMessage("Unknown next step while sign in \(result.nextStep)")
                        }
                    } catch {
                        self.updateMessage("Error while sign in \(error.localizedDescription)")
                    }
                }
            case .failure(let error):
                self.updateMessage("Error while signing out before sign in \(error.localizedDescription)")
            }
        }
    }

From reviewing the code, my Cognito auth flow is provisioned with a more simple flow, where confirmSignInWithCustomChallenge is not required, so after sign in, it will land in the done case.
Scenarios I tried

sign in with user1 -> success
Sign in with user 2 -> failed. sign out. Sign in with user 2 -> success
Sign out, sign in with user 1, fetchAuthSession and print IdentityId -> success (identityId is of user1)
Sign out, sign in with user 2, fetchAuthSession and print IdentityId -> success (identityId is of user2)
download user1.jpeg with user2 credentials (since step 3 signs in with user 2), and in parallel sign out, sign in user 1 ->  the sign in is successful, however the storage call fails with

Unexpected error occurred with message: Could not fetch AWS Cognito credentials, but there was no error reported back from
AWSMobileClient.getAWSCredentials call.

Downloading from S3 requires credentials, which can either be done by signing the request with user1 or user2. The request to download from S3 is done in parallel with the sign out call, which means that the session is invalidated while trying to sign in with Cognito to create another session.

downloading user1.jpeg with user2 credentials (fails), and in parallel sign out, sign in with user 1, download user1.jpeg -> sign in was successful and s3 download completed successfully

Now looping back to the auth flow containing the confirmSignInWithCustomChallenge. I didn't actually update my auth flow to incorporate this, but just considering what it means in the logic that you have described. If we were to download a file using the credentials of the previous signed in user, and in parallel sign out, and then sign in with another user. The confirmSignInWithCustomChallenge would further increase the time window in which no user is authenticated at all, thus the S3 call will fail since it cannot successully sign the request.

I didn't quite understand this from the repro steps
See console logs in POC. You will notice that first "User 1" will be returned then "User 2" will be returned.

Are you referring to what's returned as the downloaded image or the user here? We can perform a fetchAuthSession and check the identityId of the current user to see who is signed in.
The scenario I tried

Sign in with user 1 -> success (prints out identityId of user 1). Sign in with user 2, and while it's signing in, perform another sign in with user 2 -> one failure and one success (second sign in with user 2 will cause the first sign in to fail, the second sign in of user 2 is successful prints out identityId of user2 twice)

// first sign in with user 2 that fails
failed AuthError: Unexpected error occurred with message: Could not get end user to sign in.

If you are looking at what was successfully downloaded while running parallel tasks, then there may be a scenario that the download for user1's image is successful because user2 is successfully signed in and signing of the S3 request was done after user2 signed in.
Amplify.Storage.getURL downloads from the public folder, based on the access control you set, it can be read from all users. See file access levels here for more details https://docs.amplify.aws/lib/storage/configureaccess/q/platform/ios/

In the sample i didn't see any code that uses the fetchAuthSession API. You can use this to check user is signed in by matching it aganinst the user sub or identityId https://docs.amplify.aws/lib/auth/access_credentials/q/platform/ios/
let us know if i've missed something here or if you have any questions


Force Token Rotation

You can force invalidations of all tokens by changing the secret, which would is already necessary in the event of a security compromise. However given changes to the application, the addition or removal of data from the JWT may be necessary. [From hive-xyz/hive#20]
The goals of this are to allow you to rotate out these breaking changes without having to forcing users to reauthenticate, while not requiring the developer to implement feature or token version checking logic.

There is also now an additional case in which the individual token contents are potentially out of date, and need to be rotated. While keeping track of all the valid uuids is not part of this gem, the ability to take a uuid and flag it for a rotation is.
Moving forward the terms soft and hard invalidation will be used to refer to a force revocation or a forced rotation.

Originally I planned to have the global soft invalidation triggered by a date based config. Upon reflection I realized that during a cluster based deployment this approach would lead to a race condition based issue. This needs to be handled in the same kinda way that Rails Assets or ActiveRecord migration versioning.


Add ArrayRangeExpressions to the EOGPass

Adds handling ArrayRangeExpressions to the EOG pass and also adds a step property to the class. However, I'm not sure if all languages (i.e., c++) use the expressions in a dynamic way. In that case, I'm not even sure how/if this would be modeled in the EOG.
I'd also suggest to rename the class from ArrayRangeExpression to RangeExpression since we do not really care about the array here (there's not even a way to specify the array).
Closes #377 (and is related to #372).

Nice!

Ah wait its still a Draft, @KuechA Is something missing?


Flickering issue when focusing on input at the top of the docs site

Expected behavior
Component becomes focused and accepts input
Actual behavior
Screen flickers and scroll position changes rapidly. See video.

Steps to reproduce
Load demo page https://reactdatepicker.com/ in Chrome (Tested on OSX Chrome 63.0.3239.132)
Before scrolling or clicking anywhere, click inside the input at the top of the page
Issue also exists on Safari

Also happens on firefox on the demo site

My team experience the same problem, I also found another issue about the same problem #1334
I experienced it in all browsers I had available when testing.

Has the fix been deployed to the https://reactdatepicker.com/ site yet? Because I'm still seeing the behavior in both Chrome and Firefox (but only if my devtools are closed).


Finding all registries

I found "list registries.txt" file in the repos doc folder and I am wondering how has it been generated? I'm interested to get a list of all possible information I could get from my pump and was hoping there is already a way to dump whole registries.

Hi @kaskii.
You could dump all the bytes in the pages for your device but there is no way to know what it corresponds to and how to convert it to meaningful values.
The required registry information mainly comes from Daikin diagnostic tools.
So, all the information that this tool queries and displays for diagnostic is there.
So, if you get a matching definition file for your heat pump, you will have in it all the information that can be displayed.

Thanks for pointing me into right direction!
I found definition files inside a tool and with a little decompiling said tool I managed to write a nice console application to easily convert definition files (.ldd) straight to ESPAltherma supported format.
The tool I found was pretty old version and it seems Daikins update URL is giving timed out errors currently so updating the tool doesn't work. Maybe the URL has been changed. I'll try to get more up to date files.
Now I just need to figure out how to change some values. 👀


ARM template deployment v3 - Parameter overriding UI doesn't support Release.PrimaryArtifactSourceAlias in the path of source files

Type: Bug
Enter Task Name: AzureResourceManagerTemplateDeploymentV3
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Azure Pipelines

Account Name: COFCOInternational
Team Project Name: Integration Platform
Build Definition Name: zema/adf-release

Agent: Private

If using private agent, provide the OS of the machine running the agent and the agent version:
OS: Windows/Linux
Agent Version: 2.172.1

Issue Description
The issue is not related to execution it happens at design time using the classic Release pipeline UI.
The affected task is: AzureResourceManagerTemplateDeploymentV3
The illustrate the way to reproduce the issue look at following screenshot:

The happens when I use the variable $(Release.PrimaryArtifactSourceAlias) and then I try to use the UI to fill parameters as follows:

But then the tasks executes with success, so the issue is only related to this UI and not execution.
The expected behavior would be the UI to able to solve the System variable so it can access files and parse parameters.
Task logs
I'm not providing logs as the issue is not related to it's execution but rather with it's setup UI.
Troubleshooting
If I manually write the artifact alias, there's no issue.
Error logs
Warning: Failed to download the template file from the given path '$(System.ArtifactsDirectory)/$(Release.PrimaryArtifactSourceAlias)/drop/ARMTemplateForFactory.json' with the following error: There is no such artifact '$(System.ArtifactsDirectory)' linked to this release pipeline.

Hi @pacorreia, For override template parameter you need to select template and parameter file path using more option icon (...) and select the path  Or add the path using DEFAULT variables , then override template parameter option will parse the template parameters.

@tiwarishub I think you didn't get the entire picture on this issue
The fact is that, the UI is not able to solve the path to the template f and template parameter files when theri location are specified using variables as described earlier in this issue here's a screenshot of my issue description:

Hi @pacorreia, thanks for your response.
Rendering of template params when path is mentioned with variables (not selected via more icon) , then only option is write to parameter template parameters to override in the textbox. Example–storageName fabrikam
Rendering of template parameter when path is mentioned with variables is not currently supported and it is per its design.
Is there any specific reason why you want to use variables in template and parameter path ?

@tiwarishub actually, there's a reason for it, a convention inside company to prevent hard coded paths whenever possible.
For us makes sense to have generic paths instead of customs ones, also for some reusability.
Since this is by design I would like you to consider for a future improvement.

@pacorreia

Agree that a generic path makes it easier to keep things generic
But the root cause is not with ARM deploy task. At design time, the task uses functionality exposed by UI platform and that itself does not support any other variable except $(System.DefaultWorkingDirectory)
This limitation is by design as at design time many system variables do not exist (they only get alive during runtime). Enabling this feature will mean some very deep rooted changes which, in my honest opinion, is something the platform team will prioritize - especially given that I am not sure many such feedbacks have come in


spicetify-cli: 2.11.1 -> 2.12.0

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Thank you for your work! Unfortunately already updated by https://github.com/NixOS/nixpkgs/pull/189660


Set default colors only if they are null (SASS)

Hi
I was trying to set some colors for the controls, but it seems you are overwriting the vars $plyr-control-color and $plyr-control-color-hover, based on the lightness of $plyr-controls-bg and $plyr-control-bg-hover.
https://github.com/Selz/plyr/blob/master/src/sass/plyr.scss#L26-L45
I could change the 'gray' vars, but $gray: red; doesn't feel that good :)
Maybe you could add a check to see if $plyr-control-color and $plyr-control-color-hover are null before overwriting them?
Still loving this plugin! :+1:

I think using !default would solve this? Sorry, I've always been a LESS person and have been meaning to move over to SASS but just haven't found the time. I'll check it out and get back to you.
Cheers :+1:

Thanks.
Based on this answer: http://stackoverflow.com/questions/12521197/sass-how-to-set-a-variable-to-equal-nothing the following seems to work for me:
// Contrast
@if lightness($plyr-controls-bg) >= 65% && not $plyr-control-color {
    $plyr-control-color: $plyr-gray-light;
}
@elseif not $plyr-control-color {
    $plyr-control-color: $plyr-gray-lighter;
}
@if lightness($plyr-control-bg-hover) >= 65% && not $plyr-control-color-hover {
    $plyr-control-color-hover: $plyr-gray;
}
@elseif not $plyr-control-color-hover {
    $plyr-control-color-hover: #fff;
}


Codec plugin support

Describe why it is important and where it will be useful
libheif has released a new version that has a number of new codec plugins, notably ffmpeg which would allow hardware encoding.
Describe your proposed solution
Using the dynamically compiled option for the plugins and having an option in the python library to specify the codec plugin to use.
Describe alternatives you've considered, if relevant
No response
Additional context
No response

The next release will increase the minimum required libheif to 1.14.1 (adding support for writing image orientation to a file and encoding images in YCbCr without converting to RGB), and after that in the next release after the next - your proposal is an excellent candidate for implementation.

I'm ready to increase the minimum required libheif version to 1.17.
If someone can tell me how I can build a libheif for macOS or Ubuntu/ArchLinux/AlmaLinux so that it sees ffmpeg, I'll try to add support.

do not sure that the result will be success, but looks promising.

Alpine 3.18
I do not worry about Windows, cause I am very familiar with how Windows loads libraries and there will be ok.
Now the main question:
What next after -DENABLE_PLUGIN_LOADING=ON ?
How it will be used? Is there need for heif_load_plugin or heif_load_plugins or even both?
Or specifying plugin directory only as ENV var is enough?
@russkel

Hi @bigcat88
This looks great! I will be honest with you, I have not ever used libheif, only your handy library ;).

Or specifying plugin directory only as ENV var is enough?

Are you intending on packaging the plugins with this library? If so then perhaps the plugin directory could be provided in someway in that it will find them without having to provide the path.
Apart from that it looks like that's all that is required. You then specify the decoder/encoder name as part of normal libheif usage.

Also I wonder why there is no ffmpeg encoder, only decoder. This was what I was interested in :sweat_smile:

Also I wonder why there is no ffmpeg encoder, only decoder. This was what I was interested in 😅

Because no one has yet made such a plugin and functionality as an ffmpeg encoder for libheif. Only decoder was implemented(and I already tested it locally, it has a limited abilities and can not decode some HDR HEICs currently)

Are you intending on packaging the plugins with this library?

The main reason I started work on this is to move x265 HEIF encoder to a separate python plugin to remove GPL2.0 license from binary wheels as it is hard to me to maintain binary wheels with so many libraries that has different licenses.
Second reason is the upcoming CUDA encoder/decoder for Libheif, as I hope after that also a Intel/AMD plugins will arise a bit later.
I already know before started working on this issue that ffmpeg decoder plugin has currently limited capabilities, that's why I was not rushing it

I was interested in ffmpeg because it has the CUDA/Intel/etc encoders, but if they're going to be directly supported at some point that's great.


added get to job type command

PR contains

Add bacalhau job get to download results. #3971
Removed unused parameters from legacy get_test.go.
Modified description to download jobs using the "job get" command.

Can you check now, I have removed the duplicate code.

/ok-to-test

/oktotest

/oktotest

Thanks @leostelon for your contribution. Your changes were merged using a different PR as we have an issue with cricleci that we are trying to fix
https://github.com/bacalhau-project/bacalhau/commit/36a859e1a362fe2fa5c38b7fe49d854c07043415


Default to non-threaded export setting for the web

As #91382 will fix most of the audio issues when exporting single-threaded, I think we should default to this setting for maximum compatibility.
It would mean, though, that existing exports would go from threaded to non-threaded without changing the default value.

It would mean, though, that existing exports would go from threaded to non-threaded without changing the default value.

Default values are always stored in export presets, so this won't break existing export presets.

Makes sense to me. But should we wait for #91382 to be merged first before merging this too?

Yes, we can.

Thanks!

Note: We need to also change the default for godot-cpp, which requires some work because we don't yet support platform defaults there.


Queried for API key if JWT expires

I'm getting this, @Koncopd

Probably what one should do it is to automatically refresh the token rather than asking the user to call lamin login.

But maybe we need to update the message from renewal.

My main issue is that: Upon an expiring JWT and seeing the message "call lamin login", why should I have to go to lamin.ai/settings and manually copy and paste an API key just because the JWT expires? These two things shouldn't have anything to do with each other, should they?

No, no, it is enough to do lamin login <handle> for this (https://github.com/laminlabs/lamindb-setup/pull/853).
I will change the message to
"... call lamin login <handle> to avoid this".

https://github.com/laminlabs/lamindb-setup/commit/436db6e167df07a31bdc3e05aa4e6f4e75bb12b8

Thank you!


UnitManager.pas is missing

UnitManager.pas was renamed to ViewManager.pas.
I just now commited updated dproj files.


bug(nexxutils): Send spotify invite link feature doesn't work with recent new context menu change

Check all the boxes below

[X] I have checked that this bug hasn't already been reported

Discord username
@rairof
Detailed Info
Send spotify invite link button to replace Camara button doesn't work in the new upload context menu  alongside the Camara icon inside media context menu at first doesn't get replaced, this change was recently introduced in discord version 215.X so it's not a issue now but will be for future.
Steps to Reproduce
N/A
Crash Info
N/A
Bug Screenshot

System Info
Device: Xiaomi 11T pro
Manufacturer: Xiaomi
Brand: Xiaomi
OS: Elixir OS
Version: A14
Discord Branch: canaryRelease
Discord Version: 216.8
Discord Build: 216208
Vendetta Version: eed5355
React Version: 18.2.0
Hermes Bytecode: 94

fyi the two spotify modules will be moved to a seperate spotify plugin

@nexpid can you also add option to hide the Camara tile when the Spotify invite link pill plugin is seperated from nexutils and it works over the now Polls pill?


Support for Structurizer

Would be great to have support for Structurizer (https://structurizr.com/) since Kroki supports it.


[CI][AArch64] Skip libgomp failures in integration tests

Some integration tests are failing when running in CI machines that
have torch installed (validated only in AARch64 for now), with an
error message related to libgomp, similar to the one above:
OSError: /.../dist-packages/torch/lib/libgomp-d22c30c5.so.1: cannot
allocate memory in static TLS block
As part of enabling the integration tests in AArch64, I'm marking this
tests as skipped, so that tests can start executing and don't regress
while we take time to investigate these specific failures.
cc @Mousius @NicolaLancellotti @areusch @driazati @gigiblender @lhutton1

@tqchen any idea of what could be causing this issue, as it seems to be related to xgboost some times.


standardise on scalatest 3.2.14

matches what is used in pekko core

oops, it's two commits

I always Squash Merge - which takes all the commits in the PR and makes one commit on the destination branch. This Rebase Merge should be ok. The branch is protected making it difficult to undo this. It's probably best to leave it unless it causes trouble.

yeah, i missed it have two commits😓😓😓


BADI implementation ZADF_EDIT_AUTH

Hi,
I know the code in the implementation is commented,
https://github.com/Microsoft/ABAP-SDK-for-Azure/blob/master/src/zadf/zcl_im_adf_edit_auth.clas.abap
But having the badi implementation in git, customers will install the badi implementation, https://github.com/Microsoft/ABAP-SDK-for-Azure/blob/master/src/zadf/zadf_edit_auth.sxci.xml
which can be seen as modifications to the SAP standard processes.
In this case it looks like the implementation is for enforcing internal Microsoft rules. I suggest moving the implementation to a different package in the Microsoft SAP system, so you still have it internally, but not part of the git repository.

It is imported to Github by mistake. I will delete it from Github. Thanks.

We have deleted the BADI implementation from the source code.


Request for Documentation: Best practices for upgrading

Perhaps this is clear to others, but I'm not sure I understand how to use VueDS as the basis for my own customized design system while simultaneously making it easy to keep it up to date with VueDS releases.
To provide an example, I have a system which contains many custom tokens, doc pages, and components, some of which use plugins and features that VueDS does not implement out of the box (such as vuex).
My upgrade process is to:

clone the current version of VueDS
drop my custom components, tokens, and doc pages into the new version
manually inspect for any config changes that may have occurred and update them
after I am sure it's working, I copy any changed files over to my customized system repository and again spin it up to see if I can get it to run without errors

Am I doing it wrong? Is there an easier way? Ideally, I would love to simply be able to update a vue-design-system dependency in a package.json for my custom system.
Thanks in advance for any info or suggestions!

@sdellis The plan of this branch is to make this whole process much easier: https://github.com/viljamis/vue-design-system/pull/127


build(CodeQL): switching lgtm to CodeQL

v14.3.3 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


Content and styling updates

Add "Info o webu" page
Improve styling
Tweak meta information
Add social section

👷 Deploy Preview for svj-zelenecska processing.
🔨 Explore the source changes: 4b78900d0deade32878a2c680cb2545de2ee2c2a
🔍 Inspect the deploy log: https://app.netlify.com/sites/svj-zelenecska/deploys/612e79b8ad911100079e2c7c


Added code to check connection before ordering food.

Notifies user to connect to internet.

Pull Request Test Coverage Report for Build 281

11 of 14 (78.57%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 91.737%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/OrderCommand.java
3
6
50.0%

Totals

Change from base Build 279:
-0.08%

Covered Lines:
2287

Relevant Lines:
2493

💛  - Coveralls


[FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniClusterResource

What is the purpose of the change
This PR contains the first batch of test ports from TestingCluster to MiniClusterResource.  I will push them one by one. Each test has it's own commit and is self-contained.
Verifying this change
This change is covered by existing tests.

I would ask you to stop working on this issue.
You do not know what changes are required to properly port these tests. Adding a MiniClusterResource (or extend AbstractTestBase) is unfortunately not enough for the tests that are not covered by #5535 and #5542.
The remaining tests are really difficult to port as they heavily rely on internal API's. You see all that code in verifyResults()? All of that must be rewritten to rely on a (new!) abstraction that works for both legacy and Flip-6 clusters.
I appreciate you trying to contribute, but this issue is beyond your capabilities.

Thanks @zentol Yes. I also find this issue is more difficult than what I thought before. I have found those test are really difficult when I keep working on this, as there are many internal API's I must know. Thanks again for telling me and I will leave this issue.

I see verifyResults and I found it is too scared for me at this moment.

@zhangminglei I suggest you follow those issues and check out the solutions in the end. To be honest, I don't yet know how these difficult tests are going to be ported.

@aljoscha Okay. thanks. I will follow those issues.


configuration.md links to explore schema are broken

In docsite/docs/configuration/configuration.md, the following link is given:
https://json-schema.app/view/%23/%23%2Fdefinitions%2FLastfmSourceConfig?url=https%3A%2F%2Fraw.githubusercontent.com%2FFoxxMD%2Fmulti-scrobbler%2Fdevelop%2Fsrc%2Fcommon%2Fschema%2Fsource.json
However navigating to it shows an error:

Schema load failed

Attempted to pull the JSON Schema down from the public internet.

Error: JSON.parse: unexpected non-whitespace character after JSON data at line 1 column 4 of the JSON data

It looks like the backend folder is missing from this

Fixed in 0.6.3


React: page s aren't the same as production

Every page on staging currently has the  set as "ReportStream Dashboard"
Titles should match what's on prod. In 11ty they are stored in front matter and slug-ified. There's also some logic to change some styling/pipes depending on the page (ex: index = PRIME ReportStream, ELR onboarding page = ELR onboarding | How it works | PRIME ReportStream

PR https://github.com/CDCgov/prime-reportstream/pull/2369


Make it easily installable to /opt

Make the script installable to the /opt folder and add a symlink to /usr/sbin so it can be run anywhere.
This will however require config files for root directories and such.

I have two ways to tackle this, either I make an install command, uptime-kuma-service-push install or I make an install script that can easily be run with a initialize command or similar manner that sets up the required files. Not sure what the best approach is.


Setting cardinality() on a property causes an error in the console

Describe the bug
Trying to set the .cardinality() property constraint on a property causes an error in the terminus console. The query I used is adapted from the example at https://terminusdb.com/docs/user-guide/schema/properties/#datatype-property-with-cardinality-constraints
To Reproduce
I used the following schema:
  WOQL.doctype("Actor")
      .label("Actor")
      .property("name", "string")
      .property("born", "integer")

The following query
WOQL.add_property("ssn", "integer")
    .label("SSN")
    .description("An official social security number")
    .domain("Actor")
    .cardinality(1)

returns Parse error: syntax error. Please check your woql query.
If I rerun the query after removing the last line, it is accepted.
Expected behavior
As the query is straight from the docs, I would expect it not to cause an error :)
Bonus points for making the error message a bit more specific.
Error logs
Nothing beyond what I mentioned above.
System information (please complete the following information):

OS: Debian sid
Browser/NodeJS version Firefox 77
terminus-client version: I'm running terminus from the quickstart, in docker with tag v2.0.1. I accessed the console via http://localhost:6363/console/#/db/admin/moviedb/query

Additional context
Add any other context about the problem here.
Similarly, I tried creating the following schema on a new database:
  WOQL.doctype("Actor")
      .label("Actor")
      .property("name", "string")
      .property("born", "integer")
      .property("SSN", "integer").label("ssn").cardinality(1)

The same error happens, and again, if I remove the cardinality part, the query is accepted.

This was fixed in v3.0.0


Public Network Connectivity

Performs the necessary work to support the public Internet.
Closes #11
Summary:

mcnode and mcdir now bind to INADDR_ANY
mcnode allows NAT configuration:

none; default, no NAT
auto; use the libp2p NATPortMap service
manual; uses a user specified public address

mcnode is selective in how it reports addresses to the directory:

if the directory is on localhost, then it reports its localhost address; supports testing
if the directory is on a private network, then it will publish its routable addresses
if the directory is on a publicly routable network, then it will only report public addresses (if any)

mcnode configuration is now persisted to disk.

Tested on laptop and ec2.

lgtm


Drop Python 2.7 testing on CI and update docs for Python 3.5+ support.

The release notes for 1.0 mention that 1.0.x is the last version with Python 3 support. This PR removes a few mentions of Python 2.7 from the docs and removes the Python 2.7 test cases from the Travis and Appveyor configurations.
There is also some mention of Python 2.7/3.2 in a section on building with MinGW. I was not familiar enough with the current status of MinGW builds on Windows to update that section, so I have left it as is for now.

Okay, good suggestion. I have added 1.13.3 to the 3.5 build on Travis and replaced 1.9 with 1.13.3 both the docs and setup.py.

This PR has removed testing on Python 2, but would not have broken anything for Python 2 users. Do you also want to remove Python 2 specific code at this point?
I only found a couple of things:
1.) we define string_types for handling basestr vs str in pywt/_utils.py
2.) there is a check for the futures module in the test_concurrent.py.
Removing the first of these would definitely break things on Python 2.

Do you also want to remove Python 2 specific code at this point?

I'd say let's not do that. I don't think it adds much value, and we don't want to make life harder for backports of people that still depend on 2.x - we just don't want to spend effort on it anymore.

Merged, thanks @grlee77


Shortening road sequence

We are looking into using barefoot for our tracking system. As we have cars driving for a long time, the k-state vectors of the cars get quit huge ...
We now like to get the driven track of the car  (i.e. matched points and driven segments) into a separate database and if done, delete this part in the k-state vector.
Have you done something like that or if not, how would you suggest to do it?

First, sorry for the long delay. This is a good feature that I thought of implementing sometime. Here is just a short description, how you could do it (but of course not tested, since not implemented):

The k-state data structure (https://github.com/bmwcarit/barefoot/blob/master/src/main/java/com/bmwcarit/barefoot/markov/KState.java) is the crucial part for this thing. Note, there's t and a k parameter to do something similar, i.e. bounding the length of the state to either a time of t or a length of k. For your purpose, you should disable both bounds which is the default.
At the end of the remove method (after line 247) you could add a condition that checks if the size of the vector with the given index (sequence.get(index).one().size()) is one, and if so reads the last remaining candidate let's say c and reads all its predecessors recursively saving it to your store and afterwards calls remove(c, index) to remove it from the data structure.

I hope that helps, if you like it and implemented it, feel free to contribute it with a pull request.

@vzahn is there any progress on this issue? If you're planning to work on this issue, I would leave it open but I would close it otherwise.

@smattheis : Yes we are working on it.
In fact, we have already implemented something shortening algorithm, but it has to be tested and refactored to find its way into the general code.

Solution delivered in pull request #39

Regarding this issue:
It is necessary to store the latest stable candidate in candidateStorage and change the KState persistence.
The candidateStorage have to be set like this.
kState = previous KState
cState  = new KState
candidateStore.addAll(kState.candidates());
candidateStore.removeAll(kState.vector());

cState.setCandidateStorage(candidateStore);

And a modification in KState.java is needed, maybe a change in initialize MatcherKState is also needed when you dont want to remove the vector after setting candidates for candidateStorage like described above
	private List<C> candidateStorage;

@Override
	public JSONObject toJSON() throws JSONException {
		JSONObject json = new JSONObject();
		JSONArray jsonsequence = new JSONArray();
		...
                ....
		JSONArray jsoncandidates = new JSONArray();
		for (Entry<C, Integer> entry : counters.entrySet()) {
			JSONObject jsoncandidate = new JSONObject();
			jsoncandidate.put("candidate", entry.getKey().toJSON());
			jsoncandidate.put("count", entry.getValue() + candidateStorage.size());
			jsoncandidates.put(jsoncandidate);
		}
                 //candidateStorage need check against null
		for (int i = 0; i < candidateStorage.size(); i++) {
			JSONObject jsoncandidate = new JSONObject();
			C candidate = candidateStorage.get(i);
			candidate.transition(null);
			candidate.predecessor(null);
			jsoncandidate.put("candidate", candidate.toJSON());
			jsoncandidate.put("count", i);
			jsoncandidates.put(jsoncandidate);
		}
		json.put("k", k);
		json.put("t", t);
		json.put("sequence", jsonsequence);
		json.put("candidates", jsoncandidates);

		return json;
	}


Provide information about Zowe High Availability

Is your request for enhancement related to a problem? Please describe.
Customers wishing to use Zowe in a high availability (HA) configuration need guidance on how this can be done, together with any limitations.
Describe the solution you'd like
Ability to search the zowe docs for "High Availability" or "HA" and see material that describes Zowe and High Avaiability.

@jackjia-ibm Hi Jack, this issue will track the HA doc for 21PI2. Feel free to add more details or support needed here.

@nannanli Hi Ashley, just wanted to let you know that I have created two wiki pages for HA documentation
1- List of changes to the current documentation
2- Additions to the current documentation
I am reviewing Zowe documentation to find out where the changes are required, so that I can complete the first list/item. The second page will have all new information needed for HA work. Please feel free to add your feedback

@NayerNajafi Thank you Nayer! I'm walking through the proposed changes to docs. Will share my feedback and questions in the wiki page as comments and let you know.


Unit tests for plugins.go

Added unit tests for v1alpha/init.go
Note: These tests depend on the v1_suite_test.go test suite file from this PR: https://github.com/operator-framework/java-operator-plugins/pull/24.

Tried locally and working fine.
Running Suite: V1alpha Suite
============================
Random Seed:<PHONE_NUMBER>
Will run 5 of 5 specs

•••••
Ran 5 of 5 Specs in 0.000 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 1.10162139s
Test Suite Passed


Occasionally pins CPU to 100%

Framework 13th gen, seems like sometimes after it suspends/hibernates or runs for a few days something goes haywire and it goes up to 100% cpu usage (as reported by top, so only one thread.) Restarting the service solves this. Next time it happens I'll try to collect some logs.

Relevant journalctl except:
Sep 30 16:24:08 gframe systemd[1]: Started fw-fanctrl.service - FrameWork Fan Controller.
░░ Subject: A start job for unit fw-fanctrl.service has finished successfully
░░ Defined-By: systemd
░░ Support: https://www.debian.org/support
░░
░░ A start job for unit fw-fanctrl.service has finished successfully.
░░
░░ The job identifier is 147846.
Sep 30 16:25:53 gframe python3[1147900]: EC returned error result code 7
Sep 30 16:46:55 gframe python3[1154504]: EC response reserved != 0
Sep 30 17:02:09 gframe python3[1162689]: Missing Chromium EC memory map.
Sep 30 17:02:09 gframe python3[1162689]: Cannot find I2C adapter
Sep 30 17:02:09 gframe python3[1162689]: Unable to establish host communication
Sep 30 17:02:09 gframe python3[1162689]: Couldn't find EC
Sep 30 17:23:09 gframe python3[1173005]: EC returned error result code 7
Sep 30 18:14:11 gframe python3[1193186]: Missing Chromium EC memory map.
Sep 30 18:14:11 gframe python3[1193186]: Cannot find I2C adapter
Sep 30 18:14:11 gframe python3[1193186]: Unable to establish host communication
Sep 30 18:14:11 gframe python3[1193186]: Couldn't find EC
Sep 30 19:41:33 gframe python3[1224615]: EC response reserved != 0
Sep 30 19:41:33 gframe python3[1224615]: EC returned error result code 7
Sep 30 19:45:59 gframe python3[1225688]: EC response version mismatch
Sep 30 19:45:59 gframe python3[1225688]: EC returned error result code 12
Sep 30 19:45:59 gframe python3[1225688]: EC returned error result code 1
Oct 01 16:58:59 gframe python3[1385517]: EC response reserved != 0
Oct 01 17:40:48 gframe python3[1409681]: EC response reserved != 0
Oct 01 18:12:20 gframe python3[1417193]: EC returned error result code 7
Oct 01 18:12:20 gframe python3[1417193]: EC returned error result code 1
Oct 01 18:18:08 gframe python3[1418430]: EC response reserved != 0
Oct 01 18:18:08 gframe python3[1418430]: EC returned error result code 7
Oct 01 18:23:10 gframe python3[1419717]: EC response reserved != 0
Oct 01 18:23:10 gframe python3[1419717]: EC returned error result code 7
Oct 01 19:51:12 gframe python3[1434358]: EC returned error result code 12
Oct 01 20:34:12 gframe python3[1441772]: EC returned error result code 7
Oct 01 21:06:12 gframe python3[1447207]: EC response reserved != 0
Oct 01 22:14:00 gframe python3[1462609]: EC returned error result code 7
Oct 01 22:14:00 gframe python3[1462609]: EC returned error result code 12
Oct 01 23:25:24 gframe python3[1474541]: EC response has invalid checksum
Oct 02 00:30:50 gframe python3[1621628]: EC response has invalid checksum
Oct 02 00:30:50 gframe python3[1621628]: EC returned error result code 7
Oct 02 02:50:58 gframe python3[2534277]: EC response reserved != 0
Oct 02 05:38:14 gframe python3[2576837]: EC response reserved != 0
Oct 02 05:57:24 gframe python3[2579945]: EC response has invalid checksum
Oct 02 06:49:24 gframe python3[2589184]: EC response version mismatch
Oct 02 07:00:28 gframe python3[2591025]: EC response reserved != 0
Oct 02 07:17:50 gframe python3[2593827]: EC response has invalid checksum
Oct 02 07:47:48 gframe python3[2598590]: Missing Chromium EC memory map.
Oct 02 07:47:48 gframe python3[2598590]: Cannot find I2C adapter
Oct 02 07:47:48 gframe python3[2598590]: Unable to establish host communication
Oct 02 07:47:48 gframe python3[2598590]: Couldn't find EC

dmesg output starting at the suspension:
[312001.582152] PM: suspend entry (deep)
[312001.592483] Filesystems sync: 0.010 seconds
[312001.592670] (NULL device *): firmware: direct-loading firmware iwlwifi-ty-a0-gf-a0.pnvm
[312001.592806] (NULL device *): firmware: direct-loading firmware regulatory.db
[312001.592827] (NULL device *): firmware: direct-loading firmware regulatory.db.p7s
[312001.592965] (NULL device *): firmware: direct-loading firmware intel/ibt-0041-0041.sfi
[312001.593157] (NULL device *): firmware: direct-loading firmware iwlwifi-ty-a0-gf-a0-74.ucode
[312001.594923] (NULL device *): firmware: direct-loading firmware intel/ibt-0041-0041.ddc
[312001.594946] (NULL device *): firmware: direct-loading firmware i915/adlp_dmc.bin
[312001.595209] (NULL device *): firmware: direct-loading firmware i915/adlp_guc_70.bin
[312001.596124] (NULL device *): firmware: direct-loading firmware i915/tgl_huc.bin
[312001.599300] Freezing user space processes
[312001.601389] Freezing user space processes completed (elapsed 0.002 seconds)
[312001.601392] OOM killer disabled.
[312001.601393] Freezing remaining freezable tasks
[312001.602719] Freezing remaining freezable tasks completed (elapsed 0.001 seconds)
[312001.602759] printk: Suspending console(s) (use no_console_suspend to debug)
[312001.985107] ACPI: EC: interrupt blocked
[312002.013286] ACPI: PM: Preparing to enter system sleep state S3
[312002.027711] ACPI: EC: event blocked
[312002.027712] ACPI: EC: EC stopped
[312002.027712] ACPI: PM: Saving platform NVS memory
[312002.027966] Disabling non-boot CPUs ...
[312002.029237] smpboot: CPU 19 is now offline
[312002.061798] ACPI: PM: Low-level resume complete
[312002.061969] ACPI: EC: EC started
[312002.061971] ACPI: PM: Restoring platform NVS memory
[312002.064740] Enabling non-boot CPUs ...
[312002.064815] smpboot: Booting Node 0 Processor 19 APIC 0x3e
[312002.085876] core: cpu_atom PMU driver: PEBS-via-PT
[312002.085889] ... version:                5
[312002.085892] ... bit width:              48
[312002.085894] ... generic registers:      6
[312002.085896] ... value mask:             0000ffffffffffff
[312002.085898] ... max period:             00007fffffffffff
[312002.085900] ... fixed-purpose events:   3
[312002.085901] ... event mask:<PHONE_NUMBER>00003f
[312002.086766] CPU19 is up
[312002.087649] ACPI: PM: Waking up from system sleep state S3
[312002.092042] ACPI: EC: interrupt unblocked
[312002.235453] ACPI: EC: event unblocked
[312002.243947] i915 0000:00:02.0: [drm] GT0: GuC firmware i915/adlp_guc_70.bin version 70.5.1
[312002.243951] i915 0000:00:02.0: [drm] GT0: HuC firmware i915/tgl_huc.bin version 7.9.3
[312002.254246] iwlwifi 0000:aa:00.0: WRT: Invalid buffer destination
[312002.257423] nvme nvme0: Shutdown timeout set to 10 seconds
[312002.258356] i915 0000:00:02.0: [drm] GT0: HuC: authenticated for all workloads
[312002.258887] i915 0000:00:02.0: [drm] GT0: GUC: submission enabled
[312002.258888] i915 0000:00:02.0: [drm] GT0: GUC: SLPC enabled
[312002.259516] i915 0000:00:02.0: [drm] GT0: GUC: RC enabled
[312002.263766] nvme nvme0: 20/0/0 default/read/poll queues
[312002.417759] iwlwifi 0000:aa:00.0: WFPM_UMAC_PD_NOTIFICATION: 0x1f
[312002.417779] iwlwifi 0000:aa:00.0: WFPM_LMAC2_PD_NOTIFICATION: 0x1f
[312002.417792] iwlwifi 0000:aa:00.0: WFPM_AUTH_KEY_0: 0x80
[312002.417803] iwlwifi 0000:aa:00.0: CNVI_SCU_SEQ_DATA_DW9: 0x0
[312002.499587] usb 1-9: reset full-speed USB device number 3 using xhci_hcd
[312005.197185] OOM killer enabled.
[312005.197186] Restarting tasks ...
[312005.197203] pcieport 0000:00:1d.0: PCI bridge to [bus aa]
[312005.197238] pcieport 0000:00:1d.0:   bridge window [mem 0x7a200000-0x7a2fffff]
[312005.207472] mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops [i915])
[312005.208828] mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops [i915])
[312005.213964] done.
[312005.213970] random: crng reseeded on system resumption
[312005.215338] usb 1-2: USB disconnect, device number 76
[312005.215342] usb 1-2.2: USB disconnect, device number 79
[312005.215403] usb 4-1: USB disconnect, device number 37
[312005.215405] usb 4-1.4: USB disconnect, device number 38
[312005.215430] cdc_ncm 4-1.4:2.0 eth0: unregister 'cdc_ncm' usb-0000:00:0d.0-1.4, CDC NCM (NO ZLP)
[312005.261320] PM: suspend exit
[312005.275451] smpboot: Booting Node 0 Processor 1 APIC 0x1
[312005.411897] usb 1-2.3: USB disconnect, device number 78
[312005.494873] smpboot: Booting Node 0 Processor 2 APIC 0x8
[312006.051414] usb 1-4: USB disconnect, device number 59
[312006.195305] usb 1-5: USB disconnect, device number 60
[312006.703678] smpboot: Booting Node 0 Processor 3 APIC 0x9
[312006.999304] smpboot: Booting Node 0 Processor 4 APIC 0x10
[312007.068159] iwlwifi 0000:aa:00.0: WRT: Invalid buffer destination
[312007.155824] smpboot: Booting Node 0 Processor 5 APIC 0x11
[312007.231141] iwlwifi 0000:aa:00.0: WFPM_UMAC_PD_NOTIFICATION: 0x1f
[312007.231188] iwlwifi 0000:aa:00.0: WFPM_LMAC2_PD_NOTIFICATION: 0x1f
[312007.231205] iwlwifi 0000:aa:00.0: WFPM_AUTH_KEY_0: 0x80
[312007.231218] iwlwifi 0000:aa:00.0: CNVI_SCU_SEQ_DATA_DW9: 0x0
[312007.411422] smpboot: Booting Node 0 Processor 6 APIC 0x18
[312007.639698] smpboot: Booting Node 0 Processor 7 APIC 0x19
[312007.819266] smpboot: Booting Node 0 Processor 8 APIC 0x20
[312008.019275] smpboot: Booting Node 0 Processor 9 APIC 0x21
[312008.191317] smpboot: Booting Node 0 Processor 10 APIC 0x28
[312008.379282] smpboot: Booting Node 0 Processor 11 APIC 0x29
[312008.515284] smpboot: Booting Node 0 Processor 12 APIC 0x30
[312008.827300] smpboot: Booting Node 0 Processor 13 APIC 0x32
[312009.055303] smpboot: Booting Node 0 Processor 14 APIC 0x34
[312009.215606] usb 1-9: reset full-speed USB device number 3 using xhci_hcd
[312009.283353] smpboot: Booting Node 0 Processor 15 APIC 0x36
[312009.523301] smpboot: Booting Node 0 Processor 16 APIC 0x38
[312009.811377] smpboot: Booting Node 0 Processor 17 APIC 0x3a
[312010.099419] smpboot: Booting Node 0 Processor 18 APIC 0x3c
[312010.171593] usb 1-9: reset full-speed USB device number 3 using xhci_hcd
[312010.703728] wlan0: authenticate with 34:fc:b9:06:ae:d2
[312010.714879] wlan0: send auth to 34:fc:b9:06:ae:d2 (try 1/3)
[312010.769746] wlan0: authenticated
[312010.771348] wlan0: associate with 34:fc:b9:06:ae:d2 (try 1/3)
[312010.773079] wlan0: RX AssocResp from 34:fc:b9:06:ae:d2 (capab=0x1411 status=0 aid=47)
[312010.807944] wlan0: associated
[312010.807999] wlan0: Limiting TX power to 30 (30 - 0) dBm as advertised by 34:fc:b9:06:ae:d2
[312026.698034] filter_write: 35 callbacks suppressed
[312026.698040] msr: Write to unrecognized MSR 0x38f by i7z (pid: 1216462).
[312026.698048] msr: See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details.
[312060.200578] filter_write: 83 callbacks suppressed
[312060.200580] msr: Write to unrecognized MSR 0x38f by i7z (pid: 1216462).
[312060.200583] msr: See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details.
[312093.978058] filter_write: 83 callbacks suppressed
[312093.978060] msr: Write to unrecognized MSR 0x38f by i7z (pid: 1216462).
[312093.978062] msr: See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details.
[312127.779405] filter_write: 83 callbacks suppressed
[312127.779408] msr: Write to unrecognized MSR 0x38f by i7z (pid: 1216462).
[312127.779412] msr: See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details.

Also attached is the file output for perf record on the process. I'm not totally sure if this would be helpful but it might be a good datapoint.
perf.data.tar.gz

Hi, is this issue still active?

Hi @gidoBOSSftw5731 ,
Since you did not reply, I assume that the buggy behaviour has been fixed with the latest version.
I will, close this issue, if the bug is still there, feel free to reopen it.
Have a nice day


update proxy to include fix for peerIsOptional/originIsOptional

The fix is to be cherrypicked into Istio 1.0.3 and the proxy update includes only 1 commit https://github.com/istio/proxy/pull/1969.

@yangminzhu LGTM, but could you follow the "Update Proxy SHA to latest." format that include pulled requests in the commit message (you can generate it with $ git log --oneline 99cfc3f74c414dd4fa4aa784a0f8b13e22b81893..6953ca783697da07ebe565322d12e969280d8b03)?
It's pretty trivial for this PR, i.e.:
Update Proxy SHA to latest.

Pulling the following changes from github.com/istio/proxy:

6953ca7 Back port the fix for peerIsOptional/originIsOptional to 1.0 branch  (#1969)

Thanks!

(you'll need to amend commit message (git commit --amend) and force push (git push -f) to change existing commit message)

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: PiotrSikora
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
44f72baa825db2a1263a722b6d28f1c5dc5bedb9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: PiotrSikora
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests

/assign @hklai


Support htpasswd authentication

Add support for htpasswd authentication

Hey @ggabijaa,
there have been some major changes over the last week in this module. Can you rebase your changes on the current master. I think most of your changes can be dropped and you only have to worry about the functionality you want to see added :)

Hey @zilchms PR is updated

Thanks :) can you add a few basic tests for the new functionality, too?


How to handle validators that return promises

Hi,
Wondering how I can handle validators that return promises.
Trying to create a validator that checks if a name is available by calling some api/name_check service.
https://ember-twiddle.com/d4ec3c55c540d6da68da36ba79250590?fileTreeShown=false&openFiles=validations.user.js%2C
If you type anything in firstName you will notice [object Object] instead of a passing validation.
I noticed there was work done on handling validators that return promises, but I can't see how it actually works.
Thank you

Simplified twiddle: https://ember-twiddle.com/d4ec3c55c540d6da68da36ba79250590?fileTreeShown=false&openFiles=validations.user.js%2C

@brancusi Thanks for opening this issue. This is actually a bug in ember-changeset-validations, so I will close this issue and reopen it there.

See https://github.com/DockYard/ember-changeset-validations/issues/51


Switch from Glyphicons to FontAwesome

The 'pumpicon' class was added for long-term support in perzonalized styles or theme implementation in the future.
Closes: #1252

@strugee Well, could be picon, but if you make this change LTS the class will not be needed

@vxcamiloxv oh, to be clear, I wasn't saying the class name seemed too long. I meant that having a separate class in general felt too heavyweight (i.e. I think we should just drop the secondary class altogether).

Updated with latest changes

If you could also rebase, that would be great. Or I can do it for you if you don't have time

Rebase with master


Uncaught TypeError: Cannot read property 'filter' of undefined

[Enter steps to reproduce:]

install linter-cppcheck
.edit then save a file

Atom: 1.31.1 x64
Electron: 2.0.7
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Cannot read property 'filter' of undefined
At C:\Users\EricR\AppData\Local\atom\app-1.31.1\resources\app\node_modules\settings-view\lib\atom-io-client.js:305

TypeError: Cannot read property 'filter' of undefined
    at Request._callback (~/AppData/Local/atom/app-1.31.1/resources/app/node_modules/settings-view/lib/atom-io-client.js:305:39)
    at Request.self.callback (/app.asar/node_modules/request/request.js:185:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at /app.asar/node_modules/request/request.js:1161:10)
    at emitOne (events.js:116:13)
    at Request.emit (events.js:211:7)
    at /app.asar/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at Gunzip.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1056:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Commands
     -3:46.1.0 intentions:highlight (input.hidden-input)
     -3:46 core:save (input.hidden-input)
     -3:44.7.0 editor:newline (input.hidden-input)
     -3:42.7.0 intentions:highlight (input.hidden-input)
     -3:42.5.0 core:save (input.hidden-input)
  3x -3:08.3.0 core:backspace (input.hidden-input)
     -1:51 intentions:highlight (input.hidden-input)
     -1:50.8.0 core:save (input.hidden-input)
     -1:49.2.0 intentions:highlight (input.hidden-input)
     -1:49 core:save (input.hidden-input)
  2x -1:41.9.0 editor:newline (input.hidden-input)
     -1:40.9.0 intentions:highlight (input.hidden-input)
     -1:40.7.0 core:save (input.hidden-input)
     -1:39.1.0 intentions:highlight (input.hidden-input)
     -1:38.9.0 core:save (input.hidden-input)
  3x -1:34.6.0 linter-ui-default:toggle-panel (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages
atom-material-syntax 1.0.8
atom-material-syntax-dark 1.0.0
atom-material-ui 2.1.3
busy-signal 1.4.3
file-icons 2.1.25
gpp-compiler 3.0.7
intentions 1.1.5
linter 2.2.0
linter-cppcheck 0.2.3
linter-gcc 0.7.1
linter-ui-default 1.7.1

Thanks for contributing!
Based on the stack trace, I think this is a duplicate of https://github.com/atom/settings-view/issues/1052 so you can subscribe there for updates if you'd like.
Go ahead and try uninstalling/reinstalling the package and see if that helps for now.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Adding .text-small for de-emphasised text

This adds a small text style to be used for de-emphasized text.
For example the text under this button:

@primer/owners

This seems pretty similar to <small class="text-muted">. Would that work instead?

I could possibly split out the color and use text-small text-muted when I need it to be both.

Hmm, does the single small.text-muted work for all your instances @jonrohan? Curious if that'd be enough for us and if the implicit font-size change doesn't cause any headaches. It might be beneficial to use a relative, percent font-size for that if we don't already.

does the single small.text-muted work for all your instances @jonrohan?

didn't think of that, it's possible that it will work. Although some fonts might be 12px instead of 11px, I'll do some exploring and see what I can come up with. In the meantime I'll leave this open until I know if I should modify it or just use small.text-muted :+1:


Balena removal: Runapp support for buildroot updates

The runapp should take advantage of the API endpoints added by #2879 and the infrastructure added be #3360 to run updates for buildroot robots.

Oops, this was supposed to be closed by #3771, but I messed up the PR close keyword


feat: add new_byte_array to JNIEnv

Looks good to me. This is the direction I'd like to continue in for #7 as well.