Return Union type can't match

🔎 Search Terms

union
function return type
quickinfo
this

🕗 Version & Regression Information

This is a crash

⏯ Playground Link
https://www.typescriptlang.org/play?#code/CYUwxgNghgTiAEAzArgOzAFwJYHtVJxwAooAGALniIEp4BeAPngG8CdKBnDGLVAcwA08AEaxKqZAFthIGPAC+8AD5IoEDiGqUAbjizAAUIkJEa9JkWYH4bSgHIAjHYHX4fEBhGwzVmzYD0-gB6IfAAKgCeAA4Idlw8-HbwWBzwqDieUBwcWHyoUMIQCBg48BjRsRLSsnYAdEQATADMDQ3UrjZwGMgw+BgAFim1xjgd8IF+k35BAPyu8gby1O0GoJCwCCjo2HheMCQUVLSMLLbw8byCe5zclwrKquqaOnqGovtmJ5auI-ZOLjZ3J53j4xl0en1BhxhoQxhMppNZvNFssDEA
💻 Code
When I use a union type in the return type of a function, type checking still works, but it seems that the property type obtained through property descriptors on this is no longer functioning properly. The type query here invokes the quickinfo command of the TypeScript service.
declare function foo(a0: () => { foo: string, bar: number } | false): void
foo(() => ({
  foo: '1',
  get bar() {
    //^^^ Type 'string' is not assignable to type 'number'.(2322)
    return this.foo
    //          ^? foo: any
  }
}))

declare function bar(a0: () => { foo: string, bar: string } | false): void
bar(() => ({
  foo: '1',
  get bar() {
    return this.foo
    //          ^? foo: any
  }
}))

When I tested further in the sample, I discovered some strange things.

🙁 Actual behavior
foo: any
🙂 Expected behavior
foo: string
Additional information about the issue
No response

Although ThisType can help me solve the problem, I still believe it is an issue that needs to be addressed. Why should the user have to declare it explicitly instead of inferring what I need? The required type here is quite obvious.
type WithThis<T> = T & ThisType<T>

declare function foo(a0: () => WithThis<{ foo: string, bar: number }> | false): void
foo(() => ({
  foo: '1',
  get bar() {
    type T0 = [typeof this.foo] extends [string] ? true : false
    //   ^? true
    type T1 = typeof this.foo extends string ? true : false
    //   ^? true
    return +this.foo
    //          ^? string
  }
}))

Playground Link

Renaming needlessly-conflicting identifiers for clarity:
declare function func1(a0: () => { foo: string, bar: number } | false): void
declare function func2(a0: () => { foo: string, bar: string } | false): void

func1(() => ({
  foo: '1',
  get bar() {
    //^^^ Type 'string' is not assignable to type 'number'.(2322)
    return this.foo
    //          ^?
  }
}))

func2(() => ({
  foo: '1',
  get bar() {
    return this.foo
    //          ^?
  }
}))

This seems to just be a language service display issue - as we can tell from the error, the type is actually being computed correctly

This is an interesting case 😅
When resolving the type getContextualThisParameterType gets containingLiteral and tries to getApparentTypeOfContextualType. It can't get it because it requires getContextualTypeForReturnExpression for this unannotated arrow function. Since it's an unannotated arrow function its signature is still set to resolvingSignature and no contextual type can be retrieved from it. As there is no contextual type for this containing object literal - it gets created through checkExpressionCached(containingLiteral).
But when the language service asks for a type at this position... the arrow's signature is no longer a resolvingSignature. So we get a contextualType for this here... and it's a union ({ foo: string, bar: number } | false). Since .foo doesn't exist on that union we get an error type back and display that as any.
Fixing this is a little bit tricky - it would be best to replicate the very exact behavior of the typecheck here but I'm not sure on the spot how to do this. I thought about filtering this contextualType that is a union but I'm still afraid of other behavioral mismatches between those 2 scenarios.


what is the status of this mirror?

Not seeing any commit, is it deleted for some reason?
The official repository is no longer on github, now it's at https://chromium.googlesource.com/chromium/src.git
I have not found a Chromium github mirror that updates at least daily.

paul irish told me to delete it https://github.com/mirror/mirror/issues/3

Unfortunately I cannot push all the refs to this repo since there are a few big files (≥100 MB) in the history. I therefore adopted the approach of forking https://github.com/ChromiumWebApps/chromium to https://github.com/mirror/chromium-1 which works around that limitation. I will soon delete this repo in favor of the other one.


Improve import and export handling

Closes #1.
Open tasks

[ ] Check reading with directory hierarchy
[x] Enable reading from tarball
[ ] Output handling

CI will fail, until ie3-institute/PowerSystemDataModel#243 is merged and deployed.


Improve format of logging from lstmtraining

always use C ("classic") locale
limit output of floating point values to 3 digits
remove unneeded linefeed after log message "wrote checkpoint"

I added another commit which limits the floating point values in the names of the checkpoint files to 3 digits, too.


Feature/spaced device key

Added spaces after every fourth character in device keys (called fingerprints in the code), so they become easier to read and compare. These spaces are only added in the way that fingerprints are displayed. The actual fingerprints are unchanged.
Refers to #2314
Signed-off-by: Isa Cichon<EMAIL_ADDRESS>

Hello @bmarty
Thanks very much for the feedback! I thought that this code duplication should be avoided but couldn't figure out where the code should go.
Does the current state look satisfying?

Hello,
Yes, it looks better, thanks for update. I'll merge this PR soon
Benoît


added Find by lyrics python script 👍

Description
Python script to get song lyrics or find a song from a snippet of it's lyrics, and more.
Fixes #2044

Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the style guidelines(Clean Code) of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md
[X] My documentation follows Template for README.md
[X] I have added the project meta data in the PR template.
[X] I have created the requirements.txt file if needed.

Project Metadata

Category:

[ ] Calculators
[ ] AI/ML
[X] Scrappers
[ ] Social_Media
[ ] PDF
[ ] Image_Processing
[ ] Video_Processing
[ ] Games
[ ] Networking
[ ] OS_Utilities
[ ] Automation
[ ] Cryptography
[ ] Computer_Vision
[ ] Fun
[ ] Others

Title: Find by Lyrics
Folder: FindByLyrics
Requirements: requirement.txt
Script: main.py
Contributor: sabhisharma.ise
Description: Python script to get song lyrics or find a song from a snippet of it's lyrics, and more.

@avinashkranjan Please Review this PR!


[CLI] Error communicating with wandb process

Hey everyone - thanks for your time and I'd really appreciate your help with this. I'm running into an error when wandb.init() is called in which it says there's an error communicating with wandb process. I'm not sure what's going on as I do believe this node (I'm running this as a python script on a cluster) should have internet access. I've also placed below the debug log for the run to maybe help with what's going on. The only portions of my script that run before the error are below as well.
wandb: ERROR Error communicating with wandb process
wandb: ERROR try: wandb.init(settings=wandb.Settings(start_method='fork'))
wandb: ERROR or:  wandb.init(settings=wandb.Settings(start_method='thread'))
wandb: ERROR For more info see: https://docs.wandb.ai/library/init#init-start-error
Traceback (most recent call last):
File "/wynton/protected/home/ichs/dmandair/BRCA/end_to_end_attention.py", line 40, in
wandb.init(config=default_config)
Script portion:
Setting default run config for wandb
default_config = {'LR': 1e-5, 'NUM_HEADS': 4,
'ATTN_DEPTH': 3, 'QKV_DIM': 128,
'ATTN_TEMP': 12, 'OPTIM': 'Adam',
'WD': 0.001, 'FEAT_DIM': 256,
'HIDDEN_DIM': 128, 'DROPOUT': 0.1}
wandb.init(config=default_config)
Config parameters are automatically set by W&B sweep agent
config = wandb.config
debug.log:
2022-01-11 21:37:00,358 INFO    MainThread:16754 [wandb_init.py:init():460] starting backend
2022-01-11 21:37:00,359 INFO    MainThread:16754 [backend.py:_multiprocessing_setup():99] multiprocessing start_methods=fork,spawn,forkserver, using: spawn
2022-01-11 21:37:00,430 INFO    MainThread:16754 [backend.py:ensure_launched():216] starting backend process...
2022-01-11 21:37:00,737 INFO    MainThread:16754 [backend.py:ensure_launched():221] started backend process with pid: 17524
2022-01-11 21:37:00,740 INFO    MainThread:16754 [wandb_init.py:init():469] backend started and connected
2022-01-11 21:37:00,765 INFO    MainThread:16754 [wandb_init.py:init():533] updated telemetry
2022-01-11 21:37:00,795 INFO    MainThread:16754 [wandb_init.py:init():563] communicating current version
2022-01-11 21:37:05,796 INFO    MainThread:16754 [wandb_init.py:init():578] communicating run to backend with 30 second timeout
2022-01-11 21:37:35,799 INFO    MainThread:16754 [interface_shared.py:_communicate_run():313] couldn't get run from backend
2022-01-11 21:37:35,799 ERROR   MainThread:16754 [wandb_init.py:init():583] backend process timed out
2022-01-11 21:37:35,800 ERROR   MainThread:16754 [wandb_init.py:init():592] encountered error: Error communicating with wandb process
try: wandb.init(settings=wandb.Settings(start_method='fork'))
or:  wandb.init(settings=wandb.Settings(start_method='thread'))
For more info see: https://docs.wandb.ai/library/init#init-start-error
2022-01-11 21:37:55,231 INFO    MainThread:16754 [wandb_init.py:teardown():219] tearing down wandb.init
debug-internal.log:
2022-01-11 21:37:54,096 INFO    MainThread:17524 [internal.py:wandb_internal():87] W&B internal server running at pid: 17524, started at: 2022-01-11 21:37:54.093528
2022-01-11 21:37:54,099 DEBUG   HandlerThread:17524 [handler.py:handle_request():130] handle_request: check_version
2022-01-11 21:37:54,100 INFO    WriterThread:17524 [datastore.py:open_for_write():77] open: /wynton/protected/home/ichs/dmandair/BRCA/wandb/run-20220111_213700-2gvqktu2/run-2gvqktu2.wandb
2022-01-11 21:37:54,101 DEBUG   HandlerThread:17524 [handler.py:handle_request():130] handle_request: shutdown
2022-01-11 21:37:54,103 INFO    HandlerThread:17524 [handler.py:finish():731] shutting down handler
2022-01-11 21:37:54,104 INFO    WriterThread:17524 [datastore.py:close():281] close: /wynton/protected/home/ichs/dmandair/BRCA/wandb/run-20220111_213700-2gvqktu2/run-2gvqktu2.wandb
2022-01-11 21:37:54,112 INFO    SenderThread:17524 [sender.py:finish():1070] shutting down sender
2022-01-11 21:37:55,101 INFO    MainThread:17524 [internal.py:handle_exit():77] Internal process exited

OS: Mac OS Catalina 10.15.7
Environment: running on develop node on university cluster
Python Version: 3.9
wandb: 0.12.9

Would really appreciate your help in figuring this out - thanks so much!

Hi! Did you try passing the settings argument to wandb.init like it's suggested in the error message?
wandb: ERROR try: wandb.init(settings=wandb.Settings(start_method='fork'))
wandb: ERROR or: wandb.init(settings=wandb.Settings(start_method='thread'))

hey thanks for the help! Your suggestion seemed to do the trick - I passed the first settings argument and things are running. Currently the process is running with the context of
'wandb: Waiting for W&B process to finish, PID 31204... (failed 1). Press ctrl-c to abort syncing.'
That means things should be working, correct?
Another question I had is related to the workflow for turning off syncing. When I run my code on the computational nodes, it won't have internet access so I wasn't sure how to 1. turn off syncing and then 2. re-sync with wandb after the run is complete.

Hi! Did you try passing the settings argument to wandb.init like it's suggested in the error message?
wandb: ERROR try: wandb.init(settings=wandb.Settings(start_method='fork'))
wandb: ERROR or: wandb.init(settings=wandb.Settings(start_method='thread'))

hey! thanks for the help again. I just wanted to follow up and see if this fixed things. The previous error no longer popped up but I am seeing 'wandb: Waiting for W&B process to finish, PID 31204... (failed 1). Press ctrl-c to abort syncing.' Looking at the W+B run, I wasn't sure if things were running appropriately as I didn't see GPU being allocated appropriately.
If you had advice for how I can run w+b with syncing turned off that'd be great too.  When I run my code on the computational nodes, it won't have internet access so I wasn't sure how to 1. turn off syncing and then 2. re-sync with wandb after the run is complete.

Hey there, apologies about the delay on this. Regarding the first issue, can you check the local run directory for the debug logs? As for the second question here are the steps to run the runs offline and sync when they are ready:

Set the environment variable WANDB_MODE=offline to save the metrics locally, no internet required.
When you're ready, run wandb init in your directory to set the project name.
Run wandb sync YOUR_RUN_DIRECTORY to push the metrics to our cloud service and see your results in our hosted web app.

Let me know if that works for you.

hey! thanks much - the offline/syncing works perfectly. The previous error just had to do with installation of cuda/pytorch - I re-installed those which seemed to fix the issue. Thanks so much!

Closing the issue as it seems that @dmandair issues are resolved.


[R] GC Torture test is very slow

I'm not sure what changed recently, but this test suddently became very slow (~1 minute):
https://github.com/dmlc/xgboost/blob/5826b02d036deae8c232fb35654eb21f57490919/R-package/tests/testthat/test_gc_safety.R#L3
As it is right now, it accounts for more than half of the running time of tests. Perhaps it could be disabled by default and only run on some selected CI job.

Let me bisect it a little bit.

Yeah, let's remove it. The time is mainly spent inside R instead of XGBoost. I don't think the test is essential.


Is there a 2.0 version of this app?

I'm just getting started with Outlook's web api's.  This tutorial worked very well for me, but I'm having trouble adapting it to use the 2.0 interface.  Is there a tutorial for the 2.0 version of the API?
e.g., https://outlook.office.com/api/v2.0/me/MailFolders/' + folder_name + '/messages

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37663b22-56cb-e39b-a208-50ad709e3f91
Version Independent ID: 0e70cf4f-8728-992f-ddf4-3648ba090056
Content: How to use Outlook REST APIs in a Python app - Outlook Developer
Content Source: docs/rest/python-tutorial.md
Product: outlook
Technology: ms-graph
GitHub Login: @jasonjoh
Microsoft Alias: jasonjoh

Eventually, I found this at the very start of the tutorial:

This guide will use Microsoft Graph to access Outlook mail. Microsoft
recommends using Microsoft Graph to access Outlook mail, calendar, and
contacts.

It would be nice if similar text (e.g., "now you can try out other features offered in the Microsoft Graph API.") were included at the END of the article as part of the "next steps" discussion.

Thanks for the feedback @yoderj. We're working to consolidate these tutorials over on the Graph site so these tutorials haven't gotten the attention they need.
I definitely recommend using the Graph over the Outlook API. They are functionally equivalent except for a few specific features, with  the same entities and interactions.


Add aggregators selecting. Add filters card with dinamically added/removed flters

alert and console log in a code  base
not intelligent merge  (some of my changes removed)
Accepting, for now,  because we in POC stage ;-)
Creating task for eslint to fail on CI in alert/console.log in code

https://github.com/zorko-io/zorko-web-app/issues/5


scons fails with "Text file busy"

This issue was originally created at: 2013-08-23 05:49:36.
This issue was reported by: droundy.
droundy said at 2013-08-23 05:49:36

I've been running into a sporadic bug on linux, and have created a small test
case that reproduces the bug for me.  Presumably it is a race condition.  It
smells like for some reason the cache is not closing the files that it creates
before they are used.   My system is debian stable, and I have now confirmed
this bug on scons 2.3.0 as well as the scons packaged for debian:
$ scons --version
SCons by Steven Knight et al.:
script: v2.1.0.r5357[MODIFIED], 2011/09/09 21:31:03, by bdeegan on
ubuntu
engine: v2.1.0.r5357[MODIFIED], 2011/09/09 21:31:03, by bdeegan on
ubuntu
The circumstances are that I am building an executable, and then running that
executable to generate another file.  I am using a cache, and have never
observed the bug while the cache was disabled.  The cache is on an NFS
filesystem (my home directory), and I have only observed the bug when building
on a local disk.  With the older scons (bundled with debian) I have observed the
bug when the cache is on a local disk, but not with version 2.3.0.  With scons
2.3.0, I have only been able to reproduce this with the cache on NFS and
running over the network.  I tried (without thinking) to reproduce this on the
server machine itself, which mounts the cache over NFS, but it doesn't go over
the network, and I wasn't able to reproduce the bug.  So I suspect that the
cache needs to be slow to (be likely to?) trigger this bug.
The error message is (just cutting some of the output):
Retrieved hello-0059-small' from cache Retrieved hello-0058' from cache
Retrieved hello-0059' from cache ./hello-0057 > greeting-0057.txt ./hello-0056 > greeting-0056.txt Retrieved hello-0060.o' from cache
Retrieved hello-0060-small' from cache Retrieved hello-0060' from cache
./hello-0058 > greeting-0058.txt
./hello-0059 > greeting-0059.txt
sh: 1: ./hello-0059: Text file busy
scons: *** [greeting-0059.txt] Error 2
scons: building terminated because of errors.
I will attach the necessary files (but don't see how to do so while submitting
this bug report).  It's just a simple hello world program that I copy a hundred
times, and build and run to create greeting*.txt files.  In order to reproduce
the bug, I had to make the executable files large, which I did by adding a few
megabytes of zeroes to the end.  With this setup I can reproduce the above error
pretty much on every "scons -j4" with a "scons -c" in between.
I have sent an email about this bug:
http://four.pairlist.net/pipermail/scons-users/2013-August/001632.html
which also has the set case attached.

droundy said at 2013-08-23 05:59:33

Created an attachment (id=927)
tar file for reproducing bug

droundy said at 2013-08-23 06:02:33

I have news on this bug.  While preparing to upload the files to reproduce the
bug, it occurred to me that I could slow down the cache even more by making the
executables even bigger, so I increased the executable size to about 100M (by
adding a zero to the script that extends them with zeros), and can now reliably
trigger the bug with scons 2.3.0 without using NFS at all.  The test case also
now uses about 10G of disk space, so you'll want to be careful with it.
I have also put my test case up on github:
https://github.com/droundy/scons-bug
Thanks for a great tool!

droundy said at 2013-08-23 07:05:38

I've run strace -f and watched file open and close, and they do seem to be
matched.  My best guess at the moment (and I don't know scons internals well
enough to do more) is that perhaps subprocess.Popen is being called without the
close_fds=True flag, and thus a subprocess is inadvertently holding the
executable file open for write.

droundy attached scons-bug.tar.gz at 2013-08-23 05:59:33.

tar file for reproducing bug

I'm unable to reproduce this today.
We've made a large amount of changes in all the logic involved since 2013.
Please reopen if it's still an issue with git master.
(Note currently git master requires python 3.5+)
I tried with your git repo above.
Built in one sandbox, then clone another and built in there. no errors.


view - tab_1_radio.py

please implement the radio buttons [1st world, non first- world, both] to be used with chart 1 in tab 1.

see commit c8381d2, radio buttons were created inside tabs.


Feature/clear cache

This PR gives the user the ability to call Ocelot administration API and clear a region (re routes) cache. The region is set in the Ocelot configuration (like everything else :o).
There is a http endpoint for this on OutputCacheController.
Because we are using cachemanager.net if you set up a backplane or use a distributed cache this gives you the ability to cache across a cluster of Ocelots and clear the whole cache by calling one member of the cluster....pretty neat!
At the moment I have only exposed clearing the cache by region but we could easily add a clear all endpoint in the future.

This PR gives the user the ability to call Ocelot administration API and clear a region (re routes) cache. The region is set in the Ocelot configuration (like everything else :o).
There is a http endpoint for this on OutputCacheController.
Because we are using cachemanager.net if you set up a backplane or use a distributed cache this gives you the ability to cache across a cluster of Ocelots and clear the whole cache by calling one member of the cluster....pretty neat!
At the moment I have only exposed clearing the cache by region but we could easily add a clear all endpoint in the future.

It doesnt working, pls check issue https://github.com/ThreeMammals/Ocelot/issues/1212


Removes duplicate scribe implementation

zipkin-receiver-scribe was implented as a replacement for
zipkin-collector-scribe, but zipkin-collector-service was never
updated to use it. This consolidates towards receiver and deletes the
orphaned code.

FYI twitter doesn't use any of the affected code.

+1 :beers:

:+1:


Elevate private fields to public

This PR changes private access modifiers into public, where the fields did have publicly available getters. We now use getters implicitly provided by Solidity.

It would be nice to put the reasoning in PR description or in commit message so if people want to trace would know why.

The motivation for these changes is that if we add public modifier to a state variable, the compiler automatically generates the getters which are external and are marked as views. There is no need to explicitly write this code.


Something went wrong on "Search matches"[Espanso] ...

Extension
https://www.raycast.com/kud/espanso
Description
Error:
Error: Worker terminated due to reaching memory limit: JS heap out of memory

NodeError:errors:399:5
[kOnExit]:worker:287:26
Worker.<computed>.onexit:worker:209:20

Steps To Reproduce

Launch Espanso
Execute "Search matches" command from Raycast

Current Behaviour
Getting "Something went wrong" message
Expected Behaviour
Ability to search matches

Hey @romanskorobagatko , could you provide me your espanso file? Also does it work when you start the espanso search bar?

I cannot reproduce the error at the moment. Feel free to add any comment to help on this otherwise it'll be closed.


added cuda instructions to readme

Description
Stopgap to update the current environment setup instructions, making CUDA support available for torch. See #743
(I think I had to do this previously and totally forgot how it worked in the intervening time.)
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] Makes existing environment setup accurate for current lilac GPU situation

Status

[ ] Ready to go

Developers certificate of origin

[ ] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report

Merging #744 (5661015) into main (48996e3) will increase coverage by 7.40%.
Report is 65 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files


Add in-place reload for all types of snippets

Now we have a reloader that update the attributes of a snippet based on the serialization mappings


Add maxVal option

I needed the option for a maximum value; so I thought to share my changes with you. Only added it to the main jquery.priceformat.js, didn't add it to the minified version

Hi @GerB!
This Pull Request is too old, We will close it so we can update a new version of the plugin.
Thanks for the contribution.

I guess that's what happens when you wait 8 weeks...


Cleanup traefik certificates (part 1)

What do these changes do?
Introduce *.osparc-master.speag.com to reduce number of certificates. Next step is to update these lines but it will be done after proper certificate manager is in place.
Related issue/s
*https://github.com/ITISFoundation/osparc-ops-environments/issues/450
Related PR/s
Checklist

[ ] I tested and it works

Docker Swarm x Traefik HA x Certificates management: https://www.reddit.com/r/Traefik/comments/xvym9a/is_there_a_best_practice_solution_for_distributed/

It is blocked until the proper cert manager is introduced. Let's continue from this issue:


Github identity doesn't return the user login

In the github connector it looks like we are intentionally returning the users name (if available) instead of their login in the Username claim.
https://github.com/coreos/dex/blob/master/connector/github/github.go#L245-L248
Does it make sense to add a new Name claim to the connector identity which will contain the user's name, and that way we can use the Username claim for their login?
Since this would be a breaking change, as an alternative, maybe we can add a new claim that will contain their login instead?

Oops this is a duplicate of #1076.


Throw if actual value of toThrowMatchers is not a function

Summary
Fixes #2946.
We should warn if an actual value of any of toThrowMatchers is not a function, as toThrow() matcher can pass a supposed-to-be-failing test because of Jest's internal error (in the issue attached it's a TypeError when trying to call actual() on a string).
Here's a screenshot of what it looks like:

Test plan
jest

Codecov Report

Merging #3019 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3019      +/-   ##
=========================================
+ Coverage   68.49%   68.5%   +0.01%
=========================================
  Files         146     146
  Lines        5335    5337       +2
=========================================
+ Hits         3654    3656       +2
  Misses       1681    1681

Impacted Files
Coverage Δ

packages/jest-matchers/src/toThrowMatchers.js
80% <100%> (+0.75%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c48a77...4b5e0d2. Read the comment docs.


Automatic library version fetching. #57

Implements #57.
This PR introduces the following changes:

Library versions are no longer displayed in the third-party tab, as fetching all versions of all libraries takes too long on startup. (Maven Central API isn't exactly a performance demon.) Instead, empty text fields are displayed, allowing the users to override the default version if necessary.
When the project is being generated and a custom version is not given, the tool will automatically query Maven Central or JitPack APIs (depending on the library repository), and will attempt to select the latest stable version.

Version fetching is currently unsupported for snapshot releases. If you find an appropriate API, I can integrate it.
Versions are also fetched for official libGDX extension that do not use the main gdxVersion.

Third-party APIs were cleaned up, particularly the ones outside of the main extensions file.
Added some minor informative labels in the third-party tab.
LML dependencies now use CrashInvaders fork, which should be up-to-date with the latest libGDX version.
Project generation is slightly longer due to the time needed to fetch the library versions.

While displaying a version for each third-party might be convenient for the users, it would require either a significant startup time increase (even with parallel execution), dealing with async issues (e.g. filling the versions over time as they are fetched in the background - can override actual user settings), or using the default versions defines in code (which kind of defeats the purpose and can lead to discrepancies between displayed and actual versions). I think this approach is the cleanest, although admittedly the UI could be improved (e.g. don't display empty text field immediately, only if user selects custom version).

@tommyettinger

Noise4J can be used as a continuous noise generator, but you're better served by joise or make-some-noise in that case. There are also many kinds of map generator in squidlib-util.

Oof. No need to rub it in. :)
In all seriousness, I'm not against removal Noise4J, since it's not maintained anymore and there are a couple of objectively better alternatives. I think there's a project template for it though, so converting it to a different lib might make sense.

This looks great! I think that users probably don't need to see a fetched latest version; if they know they need a particular version that isn't the latest, they already have that version in mind, and otherwise they can just rely on fetching the most recent. I'll poke around the changed files just to make sure everything's fine, but this almost certainly is better than manually updating versions.
And Noise4J does do some things that nothing else does, last I checked, so unless something like SquidLib completely absorbs all of Noise4J's features, it's probably good to hold onto it as an option. It does noise-based map generation (with rooms placed using noise) better than SquidLib does, for instance, and probably allows mixing noise types better than SquidLib or make-some-noise (nothing tops Joise here).

<IP_ADDRESS>.0 gdx-lml stable artifacts are available at https://s01.oss.sonatype.org Nexus server.


feat(create-vite): separate templates from other files

Description
This pull request reorganize the create-vite package to separate all templates from other files (move all templates directories in a templates directory).
Additional context
/

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

What's the benefit of this refactoring?

The benefit of this change is to have a more organized code. Mixing templates with root files is a very bad practice because it becomes more complicated (and longer) to make changes.
For example, if we need to create a script to retrieve all the templates, we need to retrieve all the files (even the unnecessary ones such as the package.json) and then sort them out and work with only the templates. Putting them in the same folder allows to reduce the number of actions to just retrieve all the files in the same folder, and work with those.
In short, it reduces the execution time and the number of lines needed at the end, allowing to have a faster and more efficient code

Thanks for the PR @Olyno, I also think the refactoring is too big for what we win here.


eShopLite Exception When Clicking Cart Icon

Steps to Reproduce:
Run eShopLite
Go to Front End project (localhost:5266)
Click on the Cart icon at the top
Result:
Grpc.Core.RpcException: Status(StatusCode="NotFound", Detail="Basket with buyer id user does not exist")
   at MyFrontend.Services.BasketServiceClient.CheckoutBasketAsync(String buyerId) in C:\dev\github-ardalis\aspire\samples\eShopLite\MyFrontend\Services\BasketServiceClient.cs:line 60
   at MyFrontend.Components.Cart.HandleCheckout() in C:\dev\github-ardalis\aspire\samples\eShopLite\MyFrontend\Components\Cart.razor:line 41
   at Microsoft.AspNetCore.Components.ComponentBase.CallStateHasChangedOnAsyncCompletion(Task task)
   at Microsoft.AspNetCore.Components.Forms.EditForm.HandleSubmitAsync()
   at Microsoft.AspNetCore.Components.ComponentBase.CallStateHasChangedOnAsyncCompletion(Task task)
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.<WaitForQuiescence>g__ProcessAsynchronousWork|54_0()
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.WaitForQuiescence()
   at Microsoft.AspNetCore.Components.Endpoints.EndpointHtmlRenderer.SendStreamingUpdatesAsync(HttpContext httpContext, Task untilTaskCompleted, TextWriter writer)

Hi Steve!
The sample in the aspire repo is more of a test jig we use whilst building out the Aspire libraries. For more fully featured sample you probably want to check out the https://github.com/dotnet/eshop sample.
Sometimes we have "bugs" like this in the sample so that we can quickly launch it and click something and see something (like an error) pop up in the dashboard.

Closing in favor of tracking any change in the samples repo itself: https://github.com/dotnet/aspire-samples/issues/36


GraphQLException in Kotlin sample

When running Main.kt in the kotlin-sample my coworker and I are both seeing the following error:
Exception in thread "main" GraphQLException{message='OK', status='200', description='Cannot construct instance of `models.User` (no Creators, like default construct, exist): cannot deserialize from Object value (no delegate- or property-based Creator)
 at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: io.aexp.nodes.graphql.Wrapper["data"])', errors=null}

Hi Catherine, thanks for opening this issue! Was trying to do some cleaning up and it looks like I went a little too far and didn't properly check my work. Please pull the latest and let me know if that fixes the problems you were facing

Yes that works, thank you!


IZPACK-1400  Maven Build: installer does not recognize external overwritten property

see https://izpack.atlassian.net/browse/IZPACK-1400

Hi @Helpstone, like already commented in https://izpack.atlassian.net/browse/IZPACK-1402 I'd rather like to define a clean concept instead of making partial implementations.
At the moment we are a bit lost in mixing properties and variables, further more we need some configuration facility here instead of breaking anything for others. I know installers in our environment which wouldn't work any longer without bigger efforts after this change.

Yes, the properties and variables are mixed together nowadays. But this is not a result of this pull request.
Adding additional (user) properties is a potential dangerous change and therefore I've created IZPACK-1402. In future there should be a way to determine which properties are provided to the installer runtime. But now and in future the properties, which are provided, should be provided with ther correct value!
But IZPACK-1400 is IMHO not dangerous to existing installers! Only the properties found in pom.xml will be searched in user properties. All other user properties are ignored. So it does NOT add additional properties.It just provides the properties, which were already available up to now, with the correct value (as the user will expect).
Did you honor this fact? Do you really know installers, which would be damaged by this pull request?

Ok and sorry for the late answer.
Maybe my fault, the properties from POM should get in at the moment, that's what I wanted.
I'll merge this and test our installer with the snapshot state. We'll see whether there are broken use cases.
Thank you, @Helpstone.

No problem, the answer has not been late. It is important to check, whether merges could break exisiting installers.
I am sure, IZPACK-1400 will not do so, but importing all user set properties could do so. Therefore we should work carefully on IZPACK-1402 at some day.


Archive node Docs

Plan:

Draft docs page
Review with respective engineers and iterate on copy + instructions
Add cool queries
Add instructions on how to start archive node
Add prereqs

Waiting on the archive node deb package and the name.  Package needs to be created and docs updated with the name.

@michellewong793 are you still working on this issue? Can the Mina Foundation engineering team take it from you?


fix caching phpstan and psalm caches

This PR

[x] fixes phpstan and psalm caches

These caches are immutable, but need to be updated when code changes.
We need to have a changing cache key for that to happen.

Thank you, @bendavies!


can't format code by prettier

when i use prettier and prettier-plugin-tailwindcss to format the code, it just can't :(
and also can't auto fix the tailwind classname order  :(

嗨，我制作了以下应该有助于格式化的更漂亮的插件：prettier-plugin-tailwind-styled-components。 我希望它会有所帮助。

very useful, thanks！


Having two full screen UIs in a scene causes inconsistent MouseOverState behaviour.

Release Type: Official Release
Version: <IP_ADDRESS>
Platform(s): Windows 10
Describe the bug
With two entities in a scene, each having a full screen UI, the MouseOverState property will be set to MouseOverChild while moving the cursor, and then to MouseOverNone one frame after the cursor has stopped, even while the cursor is over a UI element.
To Reproduce

Open the project in UIBug.zip
Hover with cursor over the central button
Note the behavior of the debug display of the MouseOverState value

Expected behavior
The MouseOverState should always be MouseOverChild as long as the cursor hovers the central button
or
Disallow creating several full screen UIs on a scene.

Fixed in #573


Feature Suggestions

Could more logging interactions be added, like:
Player dropped x items
Player collected x items
Player stored x in x (bags, chests, etc)
Player took x from x (same as above)
Player reeled in x (fishing)
Played used nametag (nametags name) on entity x at location x (we have someone going around naming random things with very inappropriate names and we'd like to know whose doing it)

Since this thread is already open for suggestions I would like to add something to it.
CLEARLY server logs are full of unnecessary and excessive logs, making it difficult to use this mod effectively.
Can you make the logs from this mod go into it's own log file?


Enhance docs on set manager timeout

The default parallel task timeout may be low. Need to set both the In manager and ask manager timeout for very long jobs.

public ParallelTaskConfig genParallelTaskConfig() {
ParallelTaskConfig config = new ParallelTaskConfig();
    config.setActorMaxOperationTimeoutSec(35);
    //15min
    config.setTimeoutInManagerSec(900);
    config.setTimeoutAskManagerSec(910);
returnconfig;
}

Updated doc at : http://www.parallec.io/docs/configurations/#long-running-jobs


Change default of "always_allow_keywords" directive to True

Avoid METH_O functions by default, since they do not match normal Python semantics.
Closes #3090.

Looks like the directive is a bit broken. Switching it off makes several unrelated tests fail.


Run QG train and. inference from files on disk

We need the capability and instructions to train and inference from data files on disk similar to the
options in run_mrc.py
    train_file: Optional[str] = field(
        default=None, metadata={"help": "local file(s) to train on."}
    )
    eval_file: Optional[str] = field(
        default=None, metadata={"help": "local file(s) to test on."}
    )

Pls update qg/README.md instructions on how to do this.
This is required to run experiments and integration of QVE https://github.com/primeqa/primeqa/issues/305

@bhavani105 : please point me to a sample file I can use to test the functionality.


Scheduler: from_timespan in base class

Do the from_timespan classes plan to diverge in the SequentialScheduler and the PriorityScheduler (and future Schedulers)?  Currently they are the same and I was going to move them to the base Scheduler class for some cleanup but wanted to check first.
https://github.com/astropy/astroplan/blob/master/astroplan/scheduling.py#L438
https://github.com/astropy/astroplan/blob/master/astroplan/scheduling.py#L558

I can't think of a reason yet why they couldn't be moved up. @kvyh ?

That should be a standard @classmethod for a scheduler, yup.

Similarly, both SequentialScheduler and PriorityScheduler are not calling the base class __init__ method but instead are repeating the same code. If there's no specific reason for this I can get it cleaned up so they are actually inheriting those base properties.

I think that sounds fine.
These two schedulers were each implemented independently, so I think this kind of coordination just hadn't been considered until you brought it up.

Closed by #207


Compatibility Issue with josdk-webhooks and Fabric8 Kubernetes Client

Hi,
I attempted to locally update josdk-webhooks to use fabric8:kubernetes-client v7.0.0 to ensure compatibility with the new beta release of java-operator-sdk. However, I encountered an issue where the tests for the Quarkus part of the project are failing.
From what I’ve observed, the root cause seems to be that josdk-webhooks cannot currently be updated to fabric8:kubernetes-client v7.0.0 because Quarkus includes its own dependency on fabric8, which still references fabric8:kubernetes-client v6.13.4 on the latest officially released version.
Can you confirm that the josdk-webhooks framework won't be updated/released until Quarkus is updated to fabric8:kubernetes-client v7.0.0 with quarkusio/quarkus#42335?
Thank's for you feedback!
Kind regards
Martin

Hi @ebma16 , not necessarily, we have to discuss can skip quarkus releasing, until it catching up with with fabric8 7.0. Or do you see any other possibility @metacosm ?


feat(resetenv): the tool will now clean up the .env file

We will clean up the .env if you use "reset" command

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Projects with no hourly results are now prompted to rerun the Energy Module with hourly results On

The reliability of the hourly results tick box (in project settings) is bypassed. The setting is now applied in code when a user runs the District Energy simulation with a project that does not have hourly results.
Users are prompted if they wish to rerun the EnergyModule. Clicking "yes" runs the UmiSimulateEnergy command. Users must reclick on the District Energy "run simulation" once the energy module simualtion is completed.

Awesome! Can we have a new installer that works also with the new UMI:)>


feat(plugin)!: return cert chain in describe-key

Changes to SIGNATURE_GENERATOR.RAW capability:

Moved response.certificateChain from generate-signature to describe-key.

It is redundant to return the same certificate chain.
Simplifies the implementation of notation-core-go where certificate chain can be obtained without generating any signature.

Signed-off-by: Shiwei Zhang<EMAIL_ADDRESS>

@priteshbandi The keyId defined in the spec is the key identifier, which uniquely identifies the signing key. Rotating the signing key should not re-use the key id. Otherwise, we will have 1-to-many relationship for unique key IDs and signing keys. It is worth noting that key IDs should points to unique keys but key names are not.

Yes, keyId uniquely identifies a signing key at any given point in time. When keys are rotated, usually the old key is archived/disabled and a new key is actived so at any given time there is only one active key.
The keyId from the uber perspective is an alias to a local/remote key which needs to be unique in notation config only, it's out of the scope of notation to dictate or restrict how local/remote keys pointed by keyIds are updated/rotated.

Closing as some cloud providers may silently rotate the key without changing the key id.


Don’t create a package-lock.json file when installing the CLI

Should fix https://github.com/donejs/donejs/issues/959. I’m submitting this against the patch branch so I can test a pre-release after this is merged.

Coverage remained the same at 96.396% when pulling a5929c781c27d45cccbf92411d6b90a539bb702e on 959-npm-5 into 9562d3aadc778c91df202b6a5c26b9de1131669c on patch.


Syntax highlighter for WDL respects the Irish, but disrespects WDL syntax

Is your feature request related to a problem? Please describe.
After filling a ticket for #3984 I decided to check if this also exists in WDL because I forgot the WDL equivalent has to be within a string so apostrophes are non-issue. But, I noticed that syntax with the command section did not have highlighting, unlike the other sections.
In WDL, this is a valid way to form a command section and what is shown in most tutorials aimed at beginners:
command {
    foo
}

However, this syntax is a pain in certain circumstances if you're using variables. For this reason, in WDL 1.0, this is also valid syntax for a command section:
command <<<
    foo
>>>

It appears that, in Dockstore, the <<>> format isn't supported by the syntax highlighter and everything within it is just white. This is different from, say, the output section, where the string in the following section is green, the equals sign is orange, etc.
Describe the solution you'd like
Ideally, at least in the simple case when the command section just contains standard bash stuff, syntax should be highlighted within that section. The command section is usually the most complicated part of a WDL, so having a syntax highlighter that skips it entirely is not very useful to WDL users.
Describe alternatives you've considered
Perhaps it could be toggled by the user to emphasize that what's within the command section is a different kind of syntax then what's outside of it, or use different colors, or just be a single block of its own unique color, or...
Additional context
There's really two ways I think this can be scoped -- either having the syntax highlighter only highlight the more simple cases, like this...

...or to also support situations where you have other languages.

Both of these screenshots are from the TopMed Variant Caller WDL.
┆Issue is synchronized with this Jira Story
┆Fix Versions: Open-ended research tasks
┆Issue Number: DOCK-1683
┆Sprint: Backlog
┆Issue Type: Story

This should be an issue for a particular repo. @garyluu fill in the name of the repo.


what is the difference between global directions and latent mapper.

what is the difference between global directions and latent mapper.

The latent mapper is a network that receives a latent vector w in W+ and returns a delta, such that w + delta corresponds to the image with the desired edit. The mapper has to be trained per text prompts, and the deltas are calculated per latent vector w. Therefore, the latent mapper does not assume that there exists a single direction of the desired edit.
In the global directions approach, we find a single direction in the S space, such that traversing along it changes the desired attributes of the image (according to the text). In this method, we assume that there exists such a global direction exists that works for all the images in StyleGAN's latent space.


Compiling leaf fails on OS X El Capitan (10.11.3)

After cloning the repository, running the example (cargo run --release --example benchmarks) is failing at the point of compiling leaf. I had installed openssl via brew and had updated gcc as well....
yangtheman:~/projects/leaf(master)$ cargo clean
yangtheman:~/projects/leaf(master)$ cargo run --release --example benchmarks
   Compiling libc v0.2.8
   Compiling winapi v0.2.5
   Compiling rustc-serialize v0.3.18
   Compiling bitflags v0.3.3
   Compiling utf8-ranges v0.1.3
   Compiling winapi-build v0.1.1
   Compiling regex-syntax v0.2.5
   Compiling log v0.3.5
   Compiling kernel32-sys v0.2.1
   Compiling memchr v0.1.10
   Compiling time v0.1.34
   Compiling rand v0.3.14
   Compiling timeit v0.1.2
   Compiling byteorder v0.4.2
   Compiling rblas v0.0.11
   Compiling linear-map v0.0.4
   Compiling pkg-config v0.3.8
   Compiling lazy_static v0.1.15
   Compiling aho-corasick v0.5.1
   Compiling cudnn-sys v0.0.3
   Compiling cublas-sys v0.1.0
   Compiling regex v0.1.55
   Compiling cublas v0.2.0
   Compiling cudnn v1.3.1
   Compiling num v0.1.31
   Compiling env_logger v0.3.2
   Compiling enum_primitive v0.1.0
   Compiling collenchyma v0.0.8
   Compiling collenchyma-nn v0.3.4
   Compiling collenchyma-blas v0.2.0
   Compiling leaf v0.2.0 (file:///Users/yangtheman/projects/leaf)
error: linking with `cc` failed: exit code: 1
note: "cc" "-m64" "-L" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib" "/Users/yangtheman/projects/leaf/target/release/examples/benchmarks.0.o" "-o" "/Users/yangtheman/projects/leaf/target/release/examples/benchmarks" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/yangtheman/projects/leaf/target/release" "-L" "/Users/yangtheman/projects/leaf/target/release/deps" "-L" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib" "/Users/yangtheman/projects/leaf/target/release/deps/libenv_logger-2fedde90a22290a6.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libregex-ea979451af017568.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libutf8_ranges-afda04de2a52d0c6.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libaho_corasick-eea45523c8483aac.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libmemchr-545f7c18e4fb5174.rlib" "/Users/yangtheman/projects/leaf/target/release/libleaf.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libtimeit-32b1006bf5998cae.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libtime-22c21fe32894ddad.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcollenchyma_blas-a8b9d5dd0a4541d1.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/librblas-f688441f4b40cb58.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcublas-75b68f8b15390ba0.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcublas_sys-c067fced6fd7f628.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libregex_syntax-46f1c6091c03f7ce.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcollenchyma_nn-f77eb8f370d7400a.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/liblog-0b1f2bad29d31333.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcollenchyma-9c720fde0214e273.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libenum_primitive-2dc0d7f5a40461af.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/liblinear_map-9d19437a952d430c.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/liblazy_static-007034d2ad8108ce.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libnum-d3b232b2ec3de579.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/librand-6fab17fc670a2bc8.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libbyteorder-bff578a6925be5fe.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/librustc_serialize-79a17eda1cd94e46.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcudnn-854d347fd7afab90.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libcudnn_sys-9f4c28c0b836a8f7.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/liblibc-c1044b0a546bbfd6.rlib" "/Users/yangtheman/projects/leaf/target/release/deps/libbitflags-646076c1f4684754.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/libstd-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/libcollections-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/librustc_unicode-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/librand-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/liballoc-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/liballoc_jemalloc-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/liblibc-6a154fe0.rlib" "/usr/local/lib/rustlib/x86_64-apple-darwin/lib/libcore-6a154fe0.rlib" "-l" "blas" "-l" "cublas" "-l" "cublas" "-l" "OpenCL" "-l" "cuda" "-l" "cudnn" "-l" "System" "-l" "pthread" "-l" "c" "-l" "m" "-l" "compiler-rt"
note: ld: library not found for -lcublas
clang: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to previous error
Could not compile `leaf`.

To learn more, run the command again with --verbose.
yangtheman:~/projects/leaf(master)$ gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.3.0
Thread model: posix

Could you try running cargo run --release --no-default-features --features "native" --example benchmarks? This should get the examples to compile but should show you a message saying that CUDA support is required for the examples (which I try to clarify with #76).
Do you have CUDA installed (and is that even possible on your machine)?

My apologies. I didn't realize that being able to run OpenCL or CUDA was a prerequisite. I will close this issue.


Rollback #18806 in ExistValidator::checkTargetRelationExistence()

Note: logic still broken - $forceMasterDb ignored, need complete rework.

Q
A

Is bugfix?
✔/❌

New feature?
❌

Breaks BC?
❌

Tests pass?
✔ need rework too

Fixed issues
#18822

@samdark ok


apigee-istio bindings list exits with an exception

Executing the apigee-istio tool to list bindings exits with an exception if an API Product exists in the ORG+ENV with a description which has characters that need to be escaped.
apigee-istio -o  -e  bindings list
error retrieving products: invalid character '1' after object key:value pair
Problem seems to be the listing call returns a JSON payload and the values in the payload are not escaped.

Do you have an example org or env name that this is an issue for?

Tried recreating issue with quotes and brackets and such in product descriptions without success. Closing as unable to recreate. @wongjoey If you can provide an example, please do and I'll reopen.

I've been able to recreate. The auth proxy's /products endpoint fails to escape double quotes in the user-entered api product values.

@srinandan has a fix. we just need the new istio-products-javacallout-2.0.0.jar from him.


api/v1: Add drop_reason_desc enum to Flow API

Before this patch, drop_reason as a uint32 was difficult to parse for humans.
This patch deprecate drop_reason and introduce drop_reason_desc as an enum value.

test-me-please

test-me-please

retest-4.19

hit https://github.com/cilium/cilium/issues/13275


[MINOR][SS][TEST] Remove unsupportedOperationCheck setting for TextSocketStreamSuite

What changes were proposed in this pull request?

This patch simply removes a few unsupportedOperationCheck in TextSocketStreamSuite.
Why are the changes needed?

unsupportedOperationCheck is used to disable the check of unsupported operations. If we are not to test unsupported operations, it was unnecessarily set in TextSocketStreamSuite and could cause unexpected error by missing check.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests.

Test build #143686 has started for PR 34132 at commit a802ab0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48201/

cc @dongjoon-hyun

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48201/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48201/

Thanks @HyukjinKwon ! GA was passed. Merging to master.

Test build #143686 has finished for PR 34132 at commit a802ab0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

+1, late LGTM.

Thank you @dongjoon-hyun !

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143686/


speed up docker start-up process by using an image with pre-installed gems

How to do is described here

Closed by a48d6d5


Set CLA-related labels ("CLA: Error" & "CLA: Valid")

Summary
For the use in jQuery, I'd like it to add a CLA: Error or CLA: Valid based on the current CLA verification status. We had this with the previous CLA system used by jQuery and it was extremely valuable - I could quickly filter PRs with a proper CLA status without opening PR links.
Background

Go to https://github.com/jquery/jquery/pulls
Be able to filter out PRs without valid CLA signatures easily.
Be able to tell at a glance at the PR list which PR authors have signed the CLA and which have not.

User Story
I want to be able to quickly filter PRs with a proper CLA status without opening PR links.
Acceptance Criteria

After EasyCLA runs on a PR, it should assign the CLA: Error or CLA: Valid depending on whether the CLA was signed or not.
Any time the bot re-runs the check: on PR updates, when the CLA was signed, etc., if the state of the CLA signature has changed, the previous CLA label should be removed and the proper one should be set.

References
N/A

Feature to be discussed
@mlehotskylf

I believe the "search" functionality is a feature of GitHub, and it's not something we can address from the EasyCLA perspective. If that's the case, I suggest we close this ticket.
@nickmango @jarias-lfx please let me know if I'm wrong.

Search is a GitHub feature but attaching labels is very much something that the EasyCLA bot can do - and I provided rationale why that would be useful in my original post.

Yea indeed @mlehotskylf we have to add the tagging accordingly on the PR

@thakurveerendras kindly verify

Hello @mgol , thanks for your patience . Using Github Actions pipeline you can add a label upon the status of the easycla checks. Theres a project thats handling that on their end and creating labels accordingly.. This is one of the reasons it was decided that it would be more flexible with the project owner handling the status updates.
Sample script that would be of use is attached below. Kindly reach out in case of any issues you face
`name: Label PR based on EasyCLA status
on:
check_suite:
types: [completed]
check_run:
types: [completed]
jobs:
label:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Label PR
  uses: actions/github-script@v5
  if: github.event.check_suite.app.name == 'EasyCLA' || github.event.check_run.app.name == 'EasyCLA'
  with:
    script: |
      const status = (github.event.check_suite || github.event.check_run).conclusion;
      const pr_number = (github.event.check_suite || github.event.check_run).pull_requests[0].number;
      const label = status === 'success' ? 'EasyCLA:Valid' : 'EasyCLA:Error';

      await github.rest.issues.addLabels({
        owner: context.repo.owner,
        repo: context.repo.repo,
        issue_number: pr_number,
        labels: [label]
      });

`
cc @mlehotskylf


IMPRO-1475:  remove accumulation from extrapolate

Acceptance

Reads the u/v-component single files created by IMPRO-1446 using existing utility functionality
Produces rate forecasts at required (user-specified) lead times
Writes all rate forecasts to a single file with multiple validity times

Therefore no longer return accumulation

As the CLI is now only returning one object, It will no longer be accumulating instead this role will be taken by a new accumulate CLI.
Loading the cubelist
Loading is done with a constraint to specify the x and y.
Refactor extrapolate
Change some of the error handling to inside the process function.
Return 1 cube
Returns one cube after using merge_cube.
-Has to pop history to get it  to work.-
Can use improver merge cube.
Tests

Removed accumulate tests
removed filename test as no the output file name is given

h1. Testing the new cube match
old0 = old/nowcast-extrapolate/extrapolate/kgo0.nc
old1 = old/nowcast-extrapolate/extrapolate/kgo1.nc
old2 = old/nowcast-extrapolate/extrapolate/kgo2.nc
new_kgo = new/nowcast-extrapolate/extrapolate/kgo.nc

old0 = load_cube(old0)
old1 = load_cube(old1)
old2 = load_cube(old2)
new*kgo = load_cube(new*kgo )

print((old0.data.data == new_kgo[0].data.data).all())
print((old1.data.data == new_kgo[1].data.data).all())
print((old2.data.data == new_kgo[2].data.data).all())

outputs
True
True
True

Testing:

[x] Ran tests and they passed OK

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -5

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ lib/improver/cli/nowcast_extrapolate.py  -5

See the complete overview on Codacy


Add XP per action to XP Tracker

Closes #6727

How does it work with the kills tracking for the combat stats?

how is this information even useful

Works the same with combat skills by tracking xp/kill instead of xp/action

Can this say "XP Last Action" instead of "XP/Action"?
Would make more sense this way and accurately describe what the value is, since for some skills you can be training in a way where you're getting differing exp per action. Agility is an easy example, or for Fishing where some fishing spots have a chance for multiple fish.

Then shouldn't the wording be Average XP / Action?

Then shouldn't the wording be Average XP / Action?

+1 to this. Or even XP / Action (Average). @Atynine what do you think?


Help how to run streamDM

I need help how to run this project in eclipsce
or it should run from cmd
thx in advance

Hello, you could follow the steps provided here : http://huawei-noah.github.io/streamDM/docs/GettingStarted.html
By the way, before being able to work with the "Compiling the code", you should make sure that you have SCALA and SPARK on your computer.
If you don't, please follow the tutorial here to install those two: https://www.tutorialspoint.com/apache_spark/apache_spark_installation.htm
Then, to run the first script (spark.sh), you should need some configurations:

Modify $SPARK_HOME:

Open ~./bash_profile (on MacOS) or ~./bashrc by some text editor
Add this line into that file: export SPARK_HOME="/usr/local/spark"

Run the script.

That's how you could make the code runnable.


OpenFK won't detect older FSGUI versions or missing update files

I've noticed some people still manage to find older versions of OpenFK and FSGUI, back when it was called FunkeySelector.
The version of OpenFK doesn't seem too old because it still auto-updates, but FSGUI doesn't, because the older version is named FunkeySelector.exe and not FunkeySelectorGUI.exe, which is what OpenFK checks for.
We should ensure the following is dealt with:

A missing fsguiupdate.xml
Older FunkeySelector.exe
Where people keep finding these old downloads

Turns out the guide has at least one link with an older version of fsgui
Here's one I found to have one: U.B. Funkeys 5.0 Full Game with No Hub & Funkey Select (Zipped folder)

The third part won't be a problem for very long, but I think we should check for a FunkeySelector.exe file on start and mess with options.rdf so it will check for updates incase it finds the file, so users don't notice the old one and can just play.
I think we should also add an button in the options menu to trigger this tampering with options.rdf to trigger an update.


update console-ui

@pbakaus plz review
note: custom object formatters has been documented (added a row to the table at the bottom with link to doc).

It would be nice if in the filter section we could get a note added. It should inform users if they do "Ctrl + click" on multiple filter types, then it will select multiple filters to show. This is asked often enough that we should float the ability in docs.

Also, they need better compression. For example, this image can easily be shrunken to 16.7k by using the free software ImageAlpha (png8+alpha, 256 colors). Happy to show you the tool in person if you like.

The deployment toolchain compresses images automatically.Should we compare its output vs manually doing it to see if any extra shrinkage happens?

ah, wasn't aware. Prob not needed then, although in my experience, doing it manually always results in better compression with ImageAlpha, as your eye is still the best indicator on how low on colors you can go.


dts: bindings: Add binding for i2s modules

provides generic yaml description for i2s devices.
Signed-off-by: S Balamurugan<EMAIL_ADDRESS>

I Will work towards this and I will upload in different commit.


Outlining

If Then Else clauses collapse
For loops and ForEach loops collapse
Hint text restricted to the range being collapsed
Abstract members collapse
... placed at the end of first line, no longer eats the =

Could you flatten the commits, I mean removing the merges? Rebase interactive should work.

rebase failure, something's wrong with my git config that I haven't been able to figure out


Finalize Action API

As with our Wizard API, we would like to move our Action API to a "pure declaration of intent" model:
Sending an EditorActionEvent will simply mean "Please make these changes", with all other implementation details of how the changes are to be made moved into the event listener. The event source can be sure that the action will be committed, no validation of the action will take place prior to committing it. This means it is up to the event source to make sure the action is sensible and will not result in loss of document validity.
This also means no more need to supply old and new properties, and no more need for the event source to differentiate between Create and Move Actions, which are both merged into the new Append action, supplying only the new place (parent and potentially a reference Node) where the Node in question is to appear. Both Append and Remove actions will work on Nodes instead of Elements, only the Update action will still require an Element to be given since only Elements have attributes that could be updated.
interface RemoveActionDetail {
  node: Node;
}

interface InsertActionDetail {
  parent: Node;
  node: Node;
  reference?: Node | null;
}

interface UpdateActionDetail {
  element: Element;
  attributes: Partial<Record<string, string | null>>;
}

Since we need a generic way to update namespaced attributes in this API, we decided to amend this API as follows:
/** Represents the intent to `parent.insertBefore(node, reference)`. */
export type Insert = {
  parent: Node;
  node: Node;
  reference: Node | null;
};

export type NamespacedAttributeValue = {
  value: string | null;
  namespaceURI: string | null;
};
export type AttributeValue = string | null | NamespacedAttributeValue;
/** Represents the intent to set or remove (if null) attributes on element. */
export type Update = {
  element: Element;
  attributes: Partial<Record<string, AttributeValue>>;
};

/** Represents the intent to remove a node from its ownerDocument. */
export type Remove = {
  node: Node;
};

/** Represents the user's intent to change an XMLDocument. */
export type EditorAction = Insert | Update | Remove;

export function isInsert(action: EditorAction): action is Insert {
  return (action as Insert).parent !== undefined;
}

export function isNamespaced(
  value: AttributeValue
): value is NamespacedAttributeValue {
  return value !== null && typeof value !== 'string';
}
export function isUpdate(action: EditorAction): action is Update {
  return (action as Update).element !== undefined;
}

export function isRemove(action: EditorAction): action is Remove {
  return (
    (action as Insert).parent === undefined &&
    (action as Remove).node !== undefined
  );
}

We can close this or shall we use it to have a documentation.


Honor demotion

I don't understand what is happening:
I had 27052 honor at about 6 P.M (my time)  and five minutes after that I was backwards at 26856... I am sure of the 27052, I have followed them one by one:-) At 12 (my time) I was at 27026.
Loss: 196...
BTW I note that when translating in C++, Elixir or TS my own kata I never progress in my "percent rank progress"... Is that usual too?

There are lots of differences for "Honor" depending on the web page you consider:
https://www.codewars.com/users/g964 gives: 27828
https://www.codewars.com/users/leaderboard gives 27804 and top right 27828
https://www.codewars.com/users/g964/site-events gives "Total" -> 27843 which is the good one but at top right gives 27828.

I have a similar issue: I had around 1560 points an hour earlier, now I'm down to 1484. I completed 1-2 katas in the meantime. Here is a a screenshot that tells it all:

Same thing happening once again:

I'm having this issue too! It went as far as taking away levels on my account!

@HellSingCoder : nothing related and neither a glitch nor an issue. Your account has been notified for banishment, because You're using copies of solutions found somewhere on the web.


sudo resin local promote <IP_ADDRESS> fails with unknown command

resin-cli version: 6.8.0
linux amd64 talking to rpi Resinos2.3.0-dev

sven@y260:~/src/resin-go-hello-world$ sudo resin local promote <IP_ADDRESS>
Error: unknown command "interactive" for "resin-provison"
Run 'resin-provison --help' for usage.
2017/11/07 08:25:15 unknown command "interactive" for "resin-provison"
Connection to <IP_ADDRESS> closed.

this is a resin host that was previously part of an application, but somehow has lost its marbles, so IDK :)

@SvenDowideit that's unusual, and I've certainly not seen that before. Can you reproduce this with a fresh device, that hasn't "lost it's marbles"? :smiley:
Also, are you use the error message above is accurate? provison doesn't appear anywhere in our source, so far as I can tell, and promote definitely tries to run resin-provision:
https://github.com/resin-io/resin-cli/blob/master/lib/actions/local/promote.coffee#L65-L73

yes, I'm pretty sure I copy and pasted - but lets see what else we can find out.
the hard part atm, is scouring the house for sd cards to try :)

yes, it continues to be weird. on this new sdcard, on a different rpi:
sven@y260:~/src/resin-go-hello-world$ sudo resin version
6.8.0
sven@y260:~/src/resin-go-hello-world$
sven@y260:~/src/resin-go-hello-world$
sven@y260:~/src/resin-go-hello-world$
sven@y260:~/src/resin-go-hello-world$ sudo resin local promote <IP_ADDRESS>
[sudo] password for sven:
Error: unknown command "interactive" for "resin-provison"
Run 'resin-provison --help' for usage.
2017/11/09 05:06:40 unknown command "interactive" for "resin-provison"
Connection to <IP_ADDRESS> closed.
sven@y260:~/src/resin-go-hello-world$ sudo resin local scan
Reporting scan results
-
  host:          1a7a2af.local
  address:       <IP_ADDRESS>
  dockerInfo:
    Containers:        2
    ContainersRunning: 2
    ContainersPaused:  0
    ContainersStopped: 0
    Images:            3
    Driver:            aufs
    SystemTime:        2017-11-09T05:06:55.105404366Z
    KernelVersion:     4.4.50
    OperatingSystem:   Resin OS 2.3.0+rev1
    Architecture:      armv7l
  dockerVersion:
    Version:    17.03.1-ce
    ApiVersion: 1.27
sven@y260:~/src/resin-go-hello-world$ sudo resin local --help
Command not found: local

If you need help, don't hesitate in contacting us at:

  GitHub: https://github.com/resin-io/resin-cli/issues/new
  Forums: https://forums.resin.io

sven@y260:~/src/resin-go-hello-world$ sudo resin local ssh <IP_ADDRESS>
? Select a container /jovial_engelbart (fde42911836) - Up 29 minutes
root@7567a94:/go/src/github.com/resin-io-projects/resin-go-hello-world# uptime
 05:07:46 up 38 min,  0 users,  load average: 0.03, 0.06, 0.17
root@7567a94:/go/src/github.com/resin-io-projects/resin-go-hello-world#

We've had some internal discussion about this: right now resin provision doesn't work, and we're in the process of doing some larger changes to ResinOS itself to make this entire unmanaged -> managed flow for users work far more effectively.
What that means in practice is that this is 'expected' - we don't actually support the current implementation, we haven't actively advertised it, and we shouldn't really have released the command in the CLI in the first place given that. Sorry for the confusion! I'm going to remove the command entirely, and then close this ticket.
(internal flowdock link for context: https://www.flowdock.com/app/rulemotion/r-resinos/threads/ekN_XdiSQLNbIDiYJzf7qevPPwO)

Removed entirely in 6.8.3.


chore: bdd-spring-1576867511 to 0.0.1

chore: Promote bdd-spring-1576867511 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update connector-troubleshoot-guide.md

Added troubleshooting guide for "Failed" message when creating managed private end point.
Added troubleshooting guide for "Unable to list blobs." message when creating Event triggers based on Blobs.

@ssabat : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @ssabat - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR and your other existing PRs open for review and merge in the public repo, but would you make future content updates in the private repo? Let me know if you need information about working in the private repo. It's described in the internal contributor guide, but I can also send you the information via email. Thank you!

@ssabat please help close this PR as it no longer applies..

I'll close the PR @linda33wj


[Enterprise] Finally implement "Disable automatic update checks" gpo

Summary of the Pull Request
This policy disables automatic update checks and shows a warning in the user interface.

PR Checklist

[x] Closes: #24363
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested the behavior of the settings ui.
I can't test the behavior of the updater code. This must be done by the reviewers.

Notes for reviewers:

I have no 100% go by @crutkas. He didn't answered my last comment in the issue. But I decided to implement this now.
I wasn't able to test the behavior of the updater code. Can you please do this.
The update for the end user docs is not done yet as I wait on a second PR.

Notes for reviewers:

I have no 100% go by @crutkas. He didn't answered my last comment in the issue. But I decided to implement this now.
I wasn't able to test the behavior of the updater code. Can you please do this.
The update for the end user docs is not done yet as I wait on a second PR.
Maybe the severity "Warning" is to important here and we want to switch it to "Informarion".

Seeing inconsistency in the various InfoBars (severety and text). Can we use the same code/UX in every place?

Seeing inconsistency in the various InfoBars (severety and text). Can we use the same code/UX in every place?

Regarding the severity: I am not sure what @crutkas like to use. But he mentioned in the past that updates are important. So I decided to use a yellow bar to make the user stumble over it and see that he/she has to check manually. We can change it if @crutkas is okay with a blue one.

So this just blocks PowerToys from checking for a new update?  I don't agree with this approach as knowing there is a new version is very useful.
I think focusing more on https://github.com/microsoft/PowerToys/issues/25717 and hammering out details here would be a better way to solve this problem.

So this just blocks PowerToys from checking for a new update?

This blocks PowerToys from searching for updates automatically.
This has no user setting and is more for company deployment situations. It is only a gpo.

I think focusing more on https://github.com/microsoft/PowerToys/issues/25717 and hammering out details here would be a better way to solve this problem.

I can close the PR if you don't like to implement this.

@crutkas
I updated the screenshot:

Only the worker for to check every x minutes in the background without user interaction is disabled. Not the update check feature in PT settings. (For clarification I updated the message text.)

Hi @htcfreek , This is a change that we don't want to be brought in. Checking for the update is something that we want in PowerToys as a way to try and keep users in the latest.
Thanks for opening the PR, but this a change that we can't accept at this moment.

@jaimecbernardo
Should I ...

Close the issue?
Close the PR?
Remove the repared code from code base as it will not be implemented?

@htcfreek, at one point we did discuss that it would be nice to have a GPO settings that would allow to calm down updates for around 3 releases. Although I'm not sure how this can be done. Can perhaps we turn this into something like no updates for x amount of time since last update? Capping it at 90 days?

@htcfreek, at one point we did discuss that it would be nice to have a GPO settings that would allow to calm down updates for around 3 releases. Although I'm not sure how this can be done. Can perhaps we turn this into something like no updates for x amount of time since last update? Capping it at 90 days?

The X releases GPO exists for blocking Action Center notifications for three releases. My question was more about should we remove code that we will never use. As I understand this GPO is not wanted an will never gets implemented.

You're right. Closing this PR. Thanks for opening it all the same :)
Thinking removing that admx entry might make sense, but perhaps another PR?


fix-game-passes

Current dependencies on/for this PR:

main

PR #151   👈

This comment was auto-generated by Graphite.

Fixes #148


(PDB-2290) Align edges and resources formats with query formats

This commit aligns the edges and resources jsonb format with the return
format from querying the catalogs endpoint, this means we do not have to
parse and munge jsonb in export, the new endpoints and sync.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/355/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/360/
Test PASSed.

Closed in favor of https://github.com/puppetlabs/puppetdb/pull/1802


no message in log and auditlog

hi
I'm using libmodsecurity-3.0.0 + modsecurity-nginx-0.0.1 + nginx-1.12.0. I could not find message in the log file even if  rule has been triggered.
and here is my nginx configuration
location / {
              modsecurity on;
              modsecurity_rules_file /etc/nginx/modsecurity/modsec_includes.conf;
              root   /usr/share/nginx/html;
              index  index.html index.htm;
              proxy_set_header X-Forwarded-For $remote_addr;
              proxy_set_header REMOTE_ADDR $remote_addr;
              proxy_set_header HOST $host;
          }

and this is modsec_includes.conf
include modsecurity.conf
include crs-setup.conf
include rules/*.conf

SecRule ARGS "test" "msg:'trigger the rule',id:'44444',log,auditlog,deny" #this is the rule i used to test

and in modsecurity.conf, I define the log and audit log path
SecDebugLogLevel 3
SecDebugLog /var/log/nginx/debug.log

SecAuditEngine RelevantOnly
SecAuditLogRelevantStatus "^(?:5|4(?!04))"
SecAuditLogParts ABIJDEFHZ
SecAuditLogType Serial
SecAuditLog /var/log/modsec_audit.log

Even if the rule(id:44444) is triggered , I cannot find any message in the debug.log or modsec_audit.log
I really don't know why this happened and please correct me if my configuration is wrong.

The reason why I create the issue here is that when I use Modsecurity without nginx connector, I can log message, but now I can't. So, I guess it maybe caused by connector or my configuration is wrong.

Hi @zzhclare,
Indeed, you should be able to see at very least the debug log. Do you mind to change your debug log level to 9, and the respective file to /tmp/debug.log. I want to make sure that your web server has permission to write in the choose directory.
SecDebugLogLevel 9
SecDebugLog /tmp/debug.log

@zimmerle I find the reason now! When I change the configuration, I must restart the nginx service but not just reload the configuration file (nginx -s reload), otherwise the log setting will not be applied!Though the changes of common rules have been updated.
Is that a bug or I must restart the nginx service after I change the log setting?

Hi @zzhclare,
That is odd indeed. I going to perform further investigation. The reload should be enogth to reload the configurations.
I believe that the problem is related to one of the logging lockers. It seems that the last process to die (worker) is closing (and/or closing) that supposedly to be used by the new worker. Further investigation is needed.

Hi @zimmerle,
I am able to see the debug logs. But, I need to see only the error log that contains the rule against which the request was denied. How can I enable this logging?

@NisariAIT, Pull request #116 is up for evaluation to address the behaviour that you've mentioned.
Please see https://github.com/SpiderLabs/ModSecurity-nginx/issues/112 for further information.

As #116 is now merged. Closing this issue.


[Marketplace] Update Marketplace document for v1.6.0

Coverage remained the same at 34.07% when pulling f065cf3609f1b781c766d9668f9c9772bc4a8f19 on yiyi/marketplace/update_document_for_v1.6.0 into 59146fa6facc7f8477fc1f425b8b426713212774 on master.


Artifactory in docker swarm does not work

Hi,
We are using Artifactory enterprise license and trying to setup a multi site network topology. Is Docker swarm mode suitable for that?
Volumes don't work in docker  swarm-mode
Container names aren't supported
Unable to manage artifactory instances and the Swarm's load balancer will take to any task running the instance and not the one you want to manage in Mission Control.
Is Swarm Mode appropriate for multi site topology?

HI @NasAmin
I'm working towards the following architecture...

Use RexRay Docker volume plugin for EBS to store the Database Data
Single Container can Write to the FS
Use RexRay Docker volume plugin for EFS to store the Web App Data
Multiple Containers can write to the FS

Finally got Docker Volumes to work in AWS https://github.com/codedellemc/rexray/issues/820#issuecomment-323624765. I haven't had time to work on it, but our team has worked in deploying the multi-site statically without Docker, but I wanna take this opportunity to do it Dockerized in Swarm...
The work I'm planning is based on a Workshop at Dockercon where the presenter Dockerized his infrastructure entirely in Swarm, including the Docker Registry using Docker Volumes in Swam...

@NasAmin , @marcellodesales - guys - this is old. Is it still relevant? Or can I close it?


Ideas for improve loading times

Problem
The slowest loading tables seem to be "WorkItems Bl0cked" and "WorkItems Daily Bl0cked Count". I believe this is related to the sheer amount of data that has to be acted on when transformations are done directly to the WorkItemRevisions endpoint. Specifically this is happening due to the "Removed Columns" action right after the OData feed. This action is just selecting the only 6 columns needed in both tables because the WorkItemRevisions endpoint returns a lot of more columns (aka more data). This is not needed since the endpoint accepts a column selection parameter.
Solution
In both tables instead of querying the endpoint with a filter, do it with a select and a filter and then remove the subsequent Removed Columns (select columns) action.
Instead of:
(...)/WorkItemRevisions?$filter=(...)

Do:
(...)/WorkItemRevisions?$select=WorkItemId,Title,AreaSK,Blocked,CycleTimeDays,ChangedDate,ChangedDateSK,TagNames,CompletedDateSK,CompletedDate&$filter=(...)

This removes the need for a subsequent select action in the BI side.
I've tested this approach and it cuts loading time for those tables in about 75%

Thank you! I'm away at the minute but will test this on a new version once I'm back 👍🏼👍🏼👍🏼

Closing as suggestion would mean solution would be incompatible with users on the 'Agile' process template

That's interesting. I'm using a custom process derived from agile. I've added no "Blocked" property to it and yet, it works for me.
This is my full query
let
    Source = OData.Feed(#"Http/Https" & "://" & #"Analytics URL/Azure DevOps Server" & "/" & Organization & "/_odata/v3.0-preview/WorkItemRevisions?$select=WorkItemId,Title,AreaSK,Blocked,CycleTimeDays,ChangedDate,ChangedDateSK,TagNames,CompletedDateSK,CompletedDate&$filter=StateCategory%20ne%20%27Proposed%27%20and%20WorkItemType%20ne%20%27Issue%27%20and%20WorkItemType%20ne%20%27Task%27%20and%20WorkItemType%20ne%20%27Test%20Case%27%20and%20WorkItemType%20ne%20%27Test%20Plan%27%20and%20WorkItemType%20ne%20%27Shared%20Parameter%27%20and%20WorkItemType%20ne%20%27Shared%20Steps%27%20and%20WorkItemType%20ne%20%27Test%20Suite%27%20and%20WorkItemType%20ne%20%27Impediment%27%20and%20WorkItemType%20ne%20%27Epic%27%20and%20WorkItemType%20ne%20%27Feature%27%20" & "and ChangedDate ge 2020-06-01Z", null, [Implementation="2.0"]),
    #"Kept Duplicates" = let columnNames = {"WorkItemId"}, addCount = Table.Group(Source, columnNames, {{"Count", Table.RowCount, type number}}), selectDuplicates = Table.SelectRows(addCount, each [Count] > 1), removeCount = Table.RemoveColumns(selectDuplicates, "Count") in Table.Join(Source, columnNames, removeCount, columnNames, JoinKind.Inner),
    #"Sort Items" = Table.Sort(#"Kept Duplicates",{{"WorkItemId", Order.Ascending}, {"ChangedDate", Order.Ascending}})
in
    #"Sort Items"

Here's a screenshot of it refreshing

Here's the refresh stamp

No issues at all and I have my data
This is the exact same query running from Postman, note the results are coming through without error

I also have no project in my organization using CMMI

Any ideas on what else might be different?

Let me have a look and get back to you (reopening)

Ah ok - looks like I've got it working now 👍

Fixed in the latest version - thank you again :)


Cannot Choose Location for Device - Fresh Installation

Environment

Nautobot version (Docker tag too if applicable): 1.5.7
Python version: 3.9.14
Database platform, version: PostgreSQL 10.19
Middleware(s): Only what comes with the nautobot python package

Steps to Reproduce

Followed steps from https://docs.nautobot.com/projects/core/en/stable/installation/nautobot/ to install prerequisites and nautobot
Add Location Groups and Locations
Try to select a location while creating a Rack or Device

Expected Behavior
I expected to see my created locations in the "Locations" drop down selection when creating a rack or device.

Observed Behavior
No locations were listed in the drop down when creating a rack or rack group.
Other Notes
I was able to create locations in a hierarchy.
I was able to associate locations to sites.
I am able to assign a site to Racks and Devices, but not locations.
I want to be able to assign a room location to racks and devices.  If I'm not organizing my data correctly, or if I should be doing this another way please point me to any documentation that discusses nautobot's intended data structures, hierarchies, and relationships.  I'm still new to nautobot, and I accept that I may misunderstand the intended relationships of the data.
Lastly, If there is a better place to submit these types of questions, please let me know.  I cannot participate on the Slack channels because it is blocked at work.

Opening issues is fine, sorry to hear you can't access the Slack!
I would guess that the missing step here is that you need to edit the LocationTypes that can contain Racks and Devices to specify that this is permitted:

This is so that if you have a hierarchy of LocationTypes (say Building -> Floor -> Room) you might want to specify that Rooms can contain Racks but Buildings cannot, etc.

I'm a dummy.  I didn't find the "Content Sections" for location types in the documentation till after a while of playing with this.
For any new folks who also run into this and find this issue, edit your "Location Types" to include all the necessary types that are allowed to be assigned to each location type.

Opening issues is fine, sorry to hear you can't access the Slack!
I would guess that the missing step here is that you need to edit the LocationTypes that can contain Racks and Devices to specify that this is permitted:

This is so that if you have a hierarchy of LocationTypes (say Building -> Floor -> Room) you might want to specify that Rooms can contain Racks but Buildings cannot, etc.

Thanks for the info.  This is exactly the issue I was having! :)