Bring John Aspinall's Method Spies into the base

It's about time we had true breakpoints in Dolphin. Thanks to John giving permission to add his method spies package into the the base of Dolphin we should be able to get there in short(ish) order.

Hi, I would like to know if you are still working on this, and if you are, when do you think this branch could be merged to the master.
Thanks and regards.

@blairmcg I was looking at this, loaded the spies package, and there are some errors.
To be honest, I don't like too much the solution. It overrides too much in different places an then it's very easy to broke things when the base system changes. I'll go for a simpler solution added to the base editors and browsers.
If you don't use STS as versioning system (I think that it should be deprecated), there is no problem adding a halt, and after removing it, while the source doesn't changes it would not be marked as changed.
Using spies had value for me only for: 1) Avoid new method versions in sts; 2) Don't have to write 10 chars, only press pause. I don't remember to ever using a condition in a spy.
Pharo has some improvements over the classic halt, #haltOnce, #haltIf: and others tha are very common use. Maybe we can add some of them to Dolphin.
@msobral what's your use case for spies?

Ahh there's another thing. This is the license for ELV
EditableListView v7.10
28th Feb 2017
(C) John Aspinall/Solutions Software 2017

Terms of Use
EditableListView ("the software") is provided freely  - you may use or modify the software as you desire. In particular, you may include the software in commercial or non-commercial applications you develop. However if you redistribute the software with its source code, you may not charge for it. All copyright in the software resides with Solutions Software Ltd.

Use at your own risk: no warranty is provided as to the suitability of the software for any particular task, and no responsibility is assumed by the authors for any loss or damage that may result from its use.

By downloading the software, you are deemed to have agreed to these terms.

I don't  know if the same type of license applies to Method Spy but being Dolphin MIT, I thing that's not good to allow NON MIT contributions to be part of the core system.

I think @objectarts started working on this but for some reason the progress of the branch method-spies stopped.

For anyone needing this functionality I've created a repository with the current version of Method Spies.
There are some changes and simplifications of the code compared to earlier versions, in particular the placement of spies/breakpoints now hopefully makes more sense (Andy spotted that spies could inadvertently be assigned/returned from the host method). Also the internals of the spy code no longer appear in the debugger unless deliberately stepped into.
I'm still happy for this code (or some derivative of it) to be included in the base or Contributions repository, otherwise I'll continue to maintain in my own repository.


Fix nullable properties

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
382

Relevant Lines:
382

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
382

Relevant Lines:
382

💛  - Coveralls


How to train model with multi machines

Description
I want to train CNN with multi machines.
Hardware: cluster ( Tesla K20)
system: Red Hat Enterprise Linux Server release 6.4 (Santiago)
When I try to run theexample/image-classification/train_cifar10.py
using  comand :

python ../../tools/launch.py -n 4 -H hosts
python train_cifar10.py --network resnet --num-layers 110 --batch-size 128 --gpus 0,1,2,3
--kv-store dist_device_sync 2>&1|tee train_cifar10_log
error as following:

Traceback (most recent call last):
File "train_cifar10.py", line 19, in
import argparse
ImportError: No module named argparse
Exception in thread Thread-6:
Traceback (most recent call last):
File "/home/liyang/anaconda2-5.0/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/home/liyang/anaconda2-5.0/lib/python2.7/threading.py", line 754, in run
self.__target(*self.__args, **self.__kwargs)
File "/home/liyang/incubator-mxnet-master/tools/../dmlc-core/tracker/dmlc_tracker/ssh.py", line 61, in run
subprocess.check_call(prog, shell = True)
File "/home/liyang/anaconda2-5.0/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
CalledProcessError: Command 'ssh -o StrictHostKeyChecking=no <IP_ADDRESS> -p 22 'export LD_LIBRARY_PATH=/opt/intel/impi/<IP_ADDRESS>/intel64/lib:/opt/intel/impi/<IP_ADDRESS>/intel64/lib:/opt/intel/composer_xe_2013.3.163/compiler/lib/intel64:/opt/intel/mic/coi/host-linux-release/lib:/opt/intel/mic/myo/lib:/opt/intel/composer_xe_2013.3.163/mpirt/lib/intel64:/opt/intel/composer_xe_2013.3.163/ipp/../compiler/lib/intel64:/opt/intel/composer_xe_2013.3.163/ipp/lib/intel64:/opt/intel/mic/coi/host-linux-release/lib:/opt/intel/mic/myo/lib:/opt/intel/composer_xe_2013.3.163/compiler/lib/intel64:/opt/intel/composer_xe_2013.3.163/mkl/lib/intel64:/opt/intel/composer_xe_2013.3.163/tbb/lib/intel64/gcc4.1:/home/liyang/usr/lib:/home/liyang/usr/local/lib:/home/liyang/usr/libtool/lib:/home/liyang/usr/local/gcc-5.4.0/lib64:/home/liyang/usr/local/gcc-5.4.0/lib:/home/liyang/usr/local/perl/lib:/usr/local/cuda-8.0/lib64:/home/liyang/anaconda2-5.0/lib::/opt/intel/impi/<IP_ADDRESS>/intel64/lib:/opt/intel/impi/<IP_ADDRESS>/mic/lib; export DMLC_ROLE=worker; export DMLC_PS_ROOT_PORT=9091; export DMLC_PS_ROOT_URI=<IP_ADDRESS>; export DMLC_NUM_SERVER=4; export DMLC_NUM_WORKER=4; cd /home/liyang/incubator-mxnet-master/example/image-classification/; python train_cifar10.py --network resnet --num-layers 110 --batch-size 128 --gpus 0,1,2,3 --kv-store dist_device_sync'' returned non-zero exit status 1

I check my python package, argparse is existed.
Environment info (Required)

----------Python Info----------
('Version      :', '2.7.13')
('Compiler     :', 'GCC 7.2.0')
('Build        :', ('default', 'Sep 22 2017 00:47:24'))
('Arch         :', ('64bit', ''))
------------Pip Info-----------
('Version      :', '9.0.1')
('Directory    :', '/home/liyang/anaconda2-5.0/lib/python2.7/site-packages/pip')
----------MXNet Info-----------
/home/liyang/anaconda2-5.0/lib/python2.7/site-packages/urllib3/contrib/pyopenssl.py:46: DeprecationWarning: OpenSSL.rand is deprecated - you should use os.urandom instead
import OpenSSL.SSL
('Version      :', '1.0.0')
('Directory    :', '/home/liyang/anaconda2-5.0/lib/python2.7/site-packages/mxnet-1.0.0-py2.7.egg/mxnet')
Traceback (most recent call last):
File "diagnose.py", line 171, in
check_mxnet()
File "diagnose.py", line 113, in check_mxnet
except FileNotFoundError:
NameError: global name 'FileNotFoundError' is not defined

Package used (Python/R/Scala/Julia):
(I'm using Python)
Build info (Required if built from source)
Compiler：GCC ( 5.4.0)
Build config:
command:

make -j $(nproc) USE_OPENCV=1 USE_BLAS=openblas USE_CUDA=1 USE_CUDA_PATH=/usr/local/cuda USE_CUDNN=1 USE_DIST_KVSTORE=1

I don't know what errors there are. How can I fix this error?
Thank you!

Have you installed mxnet by running sudo python setup.py install from incubator-mxnet/python/ on each of these machines?

@Feywell if you're still interested there's an tutorial being worked on at the moment which clearly documents the steps required for distributed training. Check out the PR here, and the tutorial file is mxnet/example/distributed_training/README.md.

@thomelane Thank you！ I will read it carefully.

@Feywell, did it help? Is problem resolved now?

@yzhliu can you please close the issue?
@Feywell if you have issues setting up distritibuted training, please create a post on https://discuss.mxnet.io Thanks!


PS3H

Key
Value

ID
PS3H

Source
Vaaran Bhai Gurdas Ji

Page
35

Line
glIey qury ncwieMdy; gjgwh svwry [

Correction
ncwieMdy ≠ ncwieNdy

PROOF (EDITION)
Image:

@bhajneet FYI, Need to use special Bindi char here.


Replace KAT feature with rustflags

Exposing the test-only KAT stuff via a user facing cargo feature is IMHO not optimal. Users are never supposed to use it. So better to not expose it. Here I instead went the route that loom uses and recommends: https://docs.rs/loom/latest/loom/#running-loom-tests. To inject a --cfg <some name> to the build when you want the crate to compile for a certain type of testing.

This is technically a breaking change. Since removing a feature is breaking the API. But it's a grey area since users are not supposed to use the KAT feature anyway. Could be considered a non-breaking change without too much fuzz I guess.

I was bit ambivalent on this at first as it still exposing the chance of misuse for the end-user.
After some time I have come around and recognise this is actually quite neat and clean, I never felt comfortable about the feature hack to expose what should always be private internals (it's there in the comments!).
Just for note, previously considered alternatives to the KAT feature:
1. Using the seed generation code itself rather than just generating it from the NIST submission C codebase into flat files.
2. Moving Known Answer Tests inline rather than as integration tests.
I'm not a fan of either and this is more elegant but will putting it out there for posterity.

I'm glad you like it. I feel like the first priority is to get the KAT tests out of the public API of the crate (a feature is a public thing). Then there can be more work done to clean it up better without worrying about breaking changes. One way you/we can go is to do something similar to what classic-mceliece-rust does: https://github.com/Colfenor/classic-mceliece-rust/blob/main/src/lib.rs#L33-L34. It has a KAT-compatible RNG that is only included in the crate when #[cfg(test)] is true. And the KAT tests are isolated to tests and an example/ binary. That way it's never part of the crate API when building for not-tests.

Is there anything left I need to do here? Any chance of getting it merged?

Sorry for the delay, I was hoping to roll up a few other changes and bump up to v0.4 but haven't had any time to work on the library lately.
Everything looks good, needs updating the main and testing readmes but I can fix that up.
Thanks for the PR, trying to keep them on dev branch though if you can remember for next time, cheers!

Oh. Didn't know there was a development branch. I usually don't work that way and master was the default branch of the repo. Ok, will try to remember that.

No problems hey, just trying to keep it organised and stay on top of changes. Really I could lock the branch but also submit changes to main sometimes also, it's convenient.
Aiming for a stable 1.0 sometime mid next year, there's nothing outstanding with the internals apart from a migration to Rustcrypto's bitsliced AES for 90's mode. Still a bit of work on the exterior to find a nice balance with traits and library interop.
I do lament making breaking changes having been on the other end of them many times but there will probably be a few more leading up to v1.


Update TRACING.md

fixed the "Guest journal redirector" part of TRACING.md error, from "vsock-to-udp-server.sh" to "vsock-to-text-server.sh"

Thx. Please sign off your commit

#644

Hi @YchauWang - thanks for raising this!  See the document below for help on formatting
commits for the project.

This is due to our checkcommits tool which checks the format of commits.
There are three simple things you need to do:

Add docs: as a prefix to the first line of your commit.
Add a reference to a GitHub issue this PR fixes (I've just raised #646 for you to use).
Add a Signed-off-by: comment.

In summary, your commit could look something like this to keep Travis happy:
docs:  Fix incorrect script reference in TRACING.md

Fixed the "Guest journal redirector" part of `TRACING.md` error from `vsock-to-udp-server.sh` to `vsock-to-text-server.sh`.

Fixes: #646

Signed-off-by: your name<EMAIL_ADDRESS>
See https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format for further details.

@jodh-intel thank you very much for your subject. This is my first github commit, so sorry to make this mistake.

@YchauWang can you please rebase with latest changes so that travis can pass?
Thanks.

@chavafg Thanks, I have rebased the patch, the travis passed now.

/test-ubuntu


Update index.md

Update docs so the following error should not occur anymore:

Unable to find the controller for path path. The route is wrongly configured.

See #578

The firewall order is a symfony thing, not related to this bundle. I'm 👎 for adding it to the doc. Thanks anyway

I know its not related to this bundle but if you don't setup it right it won't work...

Yep, I understand the intend here, but this is likely to change, and your main firewall is very specific to your need (that's not common).


feat(Algebra/BigOperators/Ring): parameterise DecidableEq instance for Finset.prod_add

Remove the use of a classical DecidableEq instance from Finset.prod_add.

Zulip
This will have to wait until after the port as it affects the existing api.

LGTM. Thanks! @eric-wieser, AFAIR you have the most principled position about backwards compatibility with Lean 3. Should we merge it now or after the port is officially over?

Ideally we backport and merge in lean 3 first. If we really don't want to do that, then we should at least add a porting note to point out what changed.

Thanks!
bors merge


Sprites can't be deleted

You can't delete sprites once they've been made, meaning a clone-like feature would be useless.
There's probably a simple fix for this but I'm adding it here so I know that this has to be done.

Yes there is - just remove the sprite from the list sprites.
The variable is still there, but you can always reassign that variable.

If anyone thinks that the fix isn't good, comment here and I'll re-open it.

Sprites should have a delete method that deletes them from the sprite list. It would just be
def delete(self):
    sprites.remove(self)

So that I can do mySprite.delete() instead of slither.sprites.remove(mySprite)

@BookOwl It's done.


empty test should pass successfuly

lets say we have single disabled test:
BOOST_AUTO_TEST_CASE(test_name ,*disabled())
it should not crash/fail:
boost::unit_test::ut_detail::throw_exceptionboost::unit_test::framework::setup_error(e=) at throw_exception.hpp:48 [opt]
45
46  	template
47  	BOOST_NORETURN inline void
-> 48  	throw_exception(E const& e) { throw e; }
49
50  	#define BOOST_TEST_I_TRY try
51  	#define BOOST_TEST_I_CATCH( T, var ) catch( T const& var )
instead it may successfully end with 0 tests passed

It was always so and on design: there should be at least one test active in the test module. This is mostly to prevent silent mistakes that can come from the test configuration or the command line filter.

Thanks. What about disabled tests? What should I do if I disable the only test in a module. Also what should I do if I want optionally to declare tests right in the cpp where the tested class is implemented (try  to imagine cmakelists.txt file)? And can it crash w/o tests but not crash with disabled tests?

Hi, sorry for the late answer, I did not see your post.
The behaviour is the same in case you have disabled tests, whether this is done at runtime or compile time: if, when running the test module, boost.test detects an empty test-tree, it flags this as an error. If you do not want the set of tests to be an issue, you can always declare a dummy test that is executed in all cases, and force its execution with command line.
Would that work for you?


wrong web-ui command displays

$ tsp
11   finished   /tmp/ts-out.FpGMc3   0        3870.49/429.23/110.06 ./restore.sh -d jessie

results in 11	110.06 ./restore.sh -d jessie	0	Output	finished	3870.49/429.23/ in the UI

I suspect the output is wrongly parsed.

ID   State      Output               E-Level  Times(r/u/s)   Command [run=0/1]
5    finished   /tmp/ts-out.DpUCWx   0        630.00/93.32/13.31 /usr/local/bin/debprocess.sh /incoming/1.08/kernel-jessie-i386.changes

As seen here the timing overrun to the command field.


fix: make devpool PR msg CC compliant

We've got a feature of opening a PR with partner URL to the devpool repo
 when a new partner installs the bot
The commit message is not conventional commits compliant
This PR fixes it

I wasn't actually actively aware of the feature in the first place. Its cool but I also feat that pull requests will pile up and be neglected. Perhaps its better if the partner manually opens the pull request instead of it being automatic? Perhaps not 100% of the partners want to be added, but with this approach, 100% will have to be reviewed in the piled up pull requests.

I wasn't actually actively aware of the feature in the first place. Its cool but I also fear that pull requests will pile up and be neglected. Perhaps its better if the partner manually opens the pull request instead of it being automatic?
Perhaps not 100% of the partners want to be added, but with this approach, 100% will have to be reviewed in the piled up pull requests.

We discussed it here https://github.com/ubiquity/ubiquibot/issues/278
We don't have piled up PRs right now so I would leave it "as is" for now and fix it later (if it's really necessary)

I wasn't actually actively aware of the feature in the first place. Its cool but I also fear that pull requests will pile up and be neglected. Perhaps its better if the partner manually opens the pull request instead of it being automatic?

Perhaps not 100% of the partners want to be added, but with this approach, 100% will have to be reviewed in the piled up pull requests.

We discussed it here https://github.com/ubiquity/ubiquibot/issues/278

Should we close that issue if it's functional?

We don't have piled up PRs right now so I would leave it "as is" for now and fix it later (if it's really necessary)

Ok

Should we close that issue if it's functional?

@Draeieg I think we need to QA this issue one more time because it seems to be working


plot button does not render plot

it should look like this

broken at a020787d0b97d8250d1040636156a2a0d077d451 on 1/18

broken at b6f713951a817d4a57e94016389250163734aa0c at end of day on 1/17

broken at ae48d836dee0f5e43e13cff5106bed50fdcbe3a6 on end of day 1/13

broken at fb89922543d55e08e6e18ed177e200e1ea91448c on end of day 1/5

bug state at fe79a5b12b18346f7ee4354cb95eea7e0c233ba1 on end of day 12/22, cannot test

bug state at 4188e080a06d6e0d3660eeb8babf36f1a51f3ba4 on 12/19

working at 2d6b9dfe4147c94aaaa787334461945288611bba on 12/12

working at c133607d10d4dd5d8fc99b5ef88dc106d3c0b38f at end of day on 12/14

working at 08c8710886988453ceedc0521df9691b0cbcb150 at end of day 12/15

working at<PHONE_NUMBER>2ac88a58d1e352fc772290cb55c6ba at end of day on 12/16

broken at 5e51770a87be23e084c8906bed11872d8a2d89e9 at end of day 12/27

bug state at 1638ba8028ac72ea6179b79e3bd0580165c4732f on 12/27

different bug state at 1ec9634ab8a271aeeaac54f1be96833bc828b320 on 12/19

so sometime after end of day 12/16  and before end of day 12/27

broken at fd3f6edacc9549c6fd964d54efe631c3e1c81780 at end of day 12/19
can test by pasting this command
plot inspect 'characteristics', getColumnSummary "arrhythmia.hex", "C4"

broken at e30cb6c457e81dba79d08aedc21aeefeec4080be at end of day on 12/20

working at 1dc853ffcd8684691aa111108cf1df48071717f0 on 12/19

working at 1ec9634ab8a271aeeaac54f1be96833bc828b320 on 12/19

working at 9797aa5ea8739e7a84724edcdf2bf9bcc6368988 on 12/19

broken at a48ee6daabdaf8fc9f7630570d88ff5ce3295531 on 12/19

broken at 5aab666b1002c9c039c0db7ae4e4098611e1f0ce on 12/19

broken at 06a3db6f3a34d585b704d44a71ac707003c4cb96 on 12/19

broken at fb622ac5594abee10dbedecb6712edc61592781a on 12/19

broken at de24421ef0612b8bb1bf6889634799fc985c87a1 on 12/19

working at 648dc3755b7b16539d8b0b2213a01b06d5163a3b on 12/19

ok, 🔎 found it! de24421 on 12/19 is the commit that breaks the plot button

fixed by passing the _ to plot in routines


OCPQE-19629 add multi arch support for job controller and test result aggregator

Multi arch support for cli

$ jobctl start-controller --help
Usage: jobctl start-controller [OPTIONS]

Options:
  -r, --release TEXT              y-stream release number e.g. 4.15
                                  [required]
  --nightly / --no-nightly        run controller for nightly or stable build,
                                  default is nightly
  --trigger-prow-job BOOLEAN      trigger prow job if new build is found
  --arch [amd64|arm64|multi|ppc64le]
                                  architecture used to filter accepted build
  --help                          Show this message and exit.

$ jobctl start-aggregator --help
Usage: jobctl start-aggregator [OPTIONS]

Options:
  --arch [amd64|arm64|multi|ppc64le]
                                  architecture used to filter test result
  --help                          Show this message and exit.

Add class ReleaseStreamURLResolver to get latest build url for different release streams, save latest build info in file _releases/ocp-latest-$release-$(nightly/stable)-$arch.json

$ jobctl start-controller -r 4.16 --no-nightly --trigger-prow-job false --arch ppc64le
2024-02-27T20:39:30Z: INFO: Initializing test job registry ...
2024-02-27T20:39:30Z: INFO: Test job registry is initialized
2024-02-27T20:39:34Z: INFO: Getting latest stable build for 4.16 ...
2024-02-27T20:39:38Z: INFO: Latest stable build of 4.16 is:
{
  "name": "4.16.0-ec.3",
  "phase": "Accepted",
  "pullSpec": "quay.io/openshift-release-dev/ocp-release:4.16.0-ec.3-ppc64le",
  "downloadURL": "https://openshift-release-artifacts-ppc64le.apps.ci.l2s4.p1.openshiftapps.com/4.16.0-ec.3"
}

2024-02-27T20:39:38Z: INFO: File _releases/ocp-latest-4.16-stable-ppc64le.json not found
2024-02-27T20:39:39Z: INFO: File _releases/ocp-latest-4.16-stable-ppc64le.json not found
2024-02-27T20:39:39Z: INFO: Creating file _releases/ocp-latest-4.16-stable-ppc64le.json
2024-02-27T20:39:40Z: INFO: File is created successfully

TestJobRegistry will read job definitions by file pattern ocp-${release}+-test-jobs-${arch}.json
JobController will save test result in file _releases/ocp-test-result-${build}-${arch}.json
TestResultAggregator will scan result files by different archs.

/assign @jianzhangbjz

/lgtm
/approve


Fix acceptance tests to work for both roles and profiles

https://github.com/vghn/puppet/commit/6b51ca02d784bcc10de3a41dff376c589b91563c


chore(deps): update devdependency changelogen to ^0.5.7

This PR contains the following updates:

Package
Type
Update
Change

changelogen
devDependencies
patch
^0.5.5 -> ^0.5.7

Release Notes

unjs/changelogen (changelogen)
v0.5.7
Compare Source
compare changes
🩹 Fixes

bump: Avoid using + for canary suffix (#224)

❤ Contributors

Pooya Parsa (@pi0)

v0.5.6
Compare Source
compare changes
🚀 Enhancements

Add option to sign git tags (#117)
git: Support parse git messages that have prefix emoji (#146)

🩹 Fixes

github: Use bearer token (#180)
Handle repo name with multiple segments (#219)
Lowercase scope when filtering (#199)

💅 Refactors

Replace execa with execSync (#222)
Use human readable date for canary versions (#223)
Update execCommand (68127be)

🏡 Chore

Apply automated lint fixes (72c407f)
Update ci (bcb16cb)
Update non major deps (7f714c9)
Update to eslint v9 (fd40be9)
Apply automated lint fixes (673255b)
Update deps (3cfbe27)

❤ Contributors

Pooya Parsa (@pi0)
Klein Petr (@kleinpetr)
Wan Chiu (@wan54)
Jianqi Pan (@Jannchie)
Vasily Kuzin<EMAIL_ADDRESS>Daniel Roe (@danielroe)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Hywax Assistant.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5313e24) to head (5758147).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          146       146
  Branches        25        26    +1
=========================================
  Hits           146       146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Option for externally defined enums

Allow to deserialize GraphQL enums into user defined Rust enums, as described in #358

Here is a first suggestion to add the feature requested in #358. The implementation is very simple. Just don't generate enums if it is in the specified list of external enums. Most of the changes are for adding the option and parsing it. Looking forward to your input on this when you have time to take a look.
Example usage:
#[derive(GraphQLQuery)]
#[graphql(
    schema_path = "api/schema.json",
    query_path = "api/queries/buildings_query.graphql",
    extern_enums("BuildingType")
)]
pub struct BuildingsQuery;

I tested this with my game and 7 queries which use 1-2 enums each. It works as intended for me. As expected, I was able to remove hundreds LOC of boiler-plate code as a result of this. :-)
This is intentionally a minimal change to get the feature done. I guess from my point of view, this is all I really need. But I'm happy to add more bells and whistles, like the option to rename the type name, if that is desired.
What I'm most uncertain about in the current implementation is the error handling. I tried to keep it in line with existing code. It seems that errors due to incorrectly formatted attributes are ignored silently and compilation proceeds as if the attributes were not defined. This is what the new extern_enums attribute does now, too. Let me know if you prefer something else.
Also, please let me know if anything else I should do for the PR, such as writing changelogs or documentation.

Looks good! A test would be great if you have time for it, otherwise I'll write one next time I have a few hours to work on graphql-client.

Absolutely, I will create a test shortly

I added two basic tests.
Checking the CI again, there are no new issues.
However, I just got a bit confused with this error that started failing on master in the daily run from 3 days ago:
 failures:

---- tests::schema_with_keywords_works stdout ----
thread 'tests::schema_with_keywords_works' panicked at 'assertion failed: generated_code.contains(\"extern_\")', graphql_client_codegen/src/tests/mod.rs:32:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrac

Really looks like something that I could have caused with external_enum! But since master fails with the same error, it can't be my change. I can reproduce it locally when updating to nightly-2021-03-06 but it was fine before.

The tests look good! I think we can merge this, I sadly don't have time to invest in looking at what's wrong in CI now, but I definitely will when I have a few hours to spend on graphql-client. For now we can totally merge this, thanks a lot for the idea and the contribution!


return minded/transaction counters correctly

fixed commit 8e6680ba2 bug.

use $http.post()
use then() instead of success()

separate /addr_count from /addr to lazyload the mined counter and the transactions counter

Is this supposed to address when transaction counts are incorrect?
For example, this address shows a transaction count of 8 transaction but actually has many more on gastracker.
This bug occurs with this patch as well.
It seems to happen in addresses with a lot of small ~1 ETC receiving values (like mining payouts).

Disregard the above comment. Seems after letting it go for sometime that all addresses are returning properly.


⚠ ClamAV has degraded performance

In e01d828, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 96 ms

Resolved: ClamAV performance has improved in 0b76e95.


Use heartbeat event to send metrics

This change simplifies dependencies and using internal sidekiq mechanism to send all required metrics to datadog.

In subsequent PRs I will extend list of metrics we are sending


Can not create QNX VM using  the vmdk converted from dumpped emmc.img

Hi there , I am sorry to bother you agian.
I use the tool to dump the emmc.img on the SD card. it is approximate 7.3GB, and I tried qemu-img to convert the raw img to a VMDK file, as well as I use vbox-img command too to convert the file. but  it always failed to start the vm in the very beginning phase for provisioning a VM on VituralBOX.
it is saying:  [FATAL:   No Bootable Medium found!  System Halted.] on the console of VirtualBox.
Seems the Converted VMDK is not a valid BootDisk..
I can start a QNX VM using the download vmdk from internet. but I failed on the exported piece...
could it be some issues during the dump process?
Thanks
BR//shifeng

You need to report this to VirtualBox developers as this VMDK will properly mount in VMware Workstation Pro.

I tried for starting the vmdk on vmware player 。 it was not able to be created too. no bootable medium found。。。

Are you trying to run ARM QNX on x86 CPU?

Are you trying to run ARM QNX on x86 CPU?

I think so, Both VirtualBox and VMware are running on x86 cpu,(Macbook pro).   so this means the dump eMMC img only available for Virtualization Software based on ARM arch?

The problem is J5 and iMX6 is ARM, and QNX in eMMC is for that architecture. And you are trying to boot it in x86 environment. This reminds me fueling a diesel car with the gasoline or vise versa :)

I will put it on a ARM server then create this VM for a try


gopass mv decrypts the entry

Summary
When running gopass mv a/path/to/entry b/new/path/name, Gopass wants to decrypt the entry, which doesn't really make sense since it doesn't need to know its content to move it around on the filesystem.
Steps To Reproduce
Run gopass without the private key for that store.
(I do it by unplugging my Yubikey, but there are other ways to achieve it by setting GNUPGHOME=some/path e.g.)
$ gopass generate test/to/move 20
✅ Password for entry "test/to/move" generated

$ gopass mv test/to/move test/new/path
gpg: decryption failed: No secret key
❌ Decryption failed: exit status 2

Error: source test/to/move does not exist in source store : failed to decrypt

Plus notice the error message is quite cryptic and factually wrong since it says "source test/to/move does not exist in source store".
Expected behavior
This should work without decrypting the entry first.
Environment

OS version: based on Ubuntu 21.10, kernel  5.16.15-76051615-generic x86_64 GNU/Linux
gopass Version: gopass 1.14.0-git+HEAD
Installation method: go install

Yes, that's a shortcut I took in the implementation.
But it shouldn't be too hard to avoid decryption

Back when we did support non-FS based backends I did generalize the move implementation to always Get&Set.
But now only support FS-based backends in practice so I should be worth changing that.
We'll still need a fallback to the old implementation, but that should be easy.
Will try to look into this soon, as it's an important usability issue (I've been unhappy about this for a while but did never bother to do anything).


Training data

Hi, thanks for your amazing work
I wanted to ask about sharing the training code and data?
for RNA/DNA data all of the thing I see in repo are sequences. could you please share pdb files
Thanks

We are hoping to share training code in the future.  it needs some organization before we can add it to the repo, however (it's a mess of scripts at the moment)


Create UI link to install GitHub app

Feature Request
Desired behaviour
Configurable link (can change the GitHub app pointed at) to install a GitHub app for a particular organization or repo where we want to monitor a .dockstore.yml/repo.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.7
┆Sprint: Seabright Sprint 12 Liner
┆Issue Number: DOCK-686
┆Epic: Serve UI from s3/CloudFront

Exists sufficiently in staging.dockstore.org


App lag

For me this week the app was effectively unusable due to variable amounts of lag coupled with chaining presses once the app responded (for example taking 30 seconds to submit a forecast and then entering an infinite loop over countries and targets).
I managed forecasts for the UK, Germany, and Poland but I am not clear if any actually went through or if others were submitted.
Probably need to optimise the app for higher loads and bump up the server in the short term.

Closing as we weren't able to do anything about it / reproduce it

Good idea. I did some internet testing and this was definitely just a slow connection issue


license?

Hello! I've been doing some work based on your library, and wanted to ask if you'd attach an open source license to your work, so I can contribute mine under the same license. MIT or GPLv3, maybe?
I built on your initial code to make an online interface for adjusting images:
https://jywarren.github.io/fisheyegl/example/
https://github.com/jywarren/fisheyegl
I'd be happy to rebase and merge my changes back into your repository if you'd prefer, but I want to release it as a Node.js and Bower package, so I wanted a shorter name.

ping @bluemir awesome library! but would be it be possible to add a license to the code?

Sorry for late reply.
I add 'LICENSE' file in  f36e3e815fa6e362dd16a888b9b806ef4745aa1a commit.


Where does MV constantly get worlds?

I used Multiverse-Core before but removed it from my server for some time (including the Multiverse-Core folder), but now when I want to re-add it, does it constantly load worlds that do not exist anymore.
Where does MV get the worlds from? The folders with the worlds are deleted and the MV folder is completely fresh.
This also gives me the issue, where I can't create a world with the desired name, because it "already exist" but I can also not remove it from the worlds.yml, because it doesn't exist anymore.
Is there a way to forcefully remove the entry from the config (and wherever information about it is also located)?
This is really an annoying situation that I'm unable to solve.
If there is no such force option would I appreciate if it could be added (i.e. /mv remove <world_name> -f[orce]

You should delete the worlds.yml (other than server generated ones which will also be present no matter what) and reimport all your worlds using /mvimport WORLDNAME WORLDTYPE
WORLDTYPE are normal, nether or end

This wouldn't really help in my situation as

The worlds do no longer exist and I can't create them, because the name is already being used
I can delete the worlds.yml 100 times and MV will still load it with non-existant worlds, because it receives the information from somewhere that I don't know about.

Can you send me your full server log?
Also it may be better for you to join mv discord:  https://discord.gg/NZtfKky

https://paste.helpch.at/givamowivi.md

Reproducible issue due to conflict with Slime-World-Manager plugin
Even though there is no test2 world folder, but if have a test2.slime slime-worlds folder and in worlds.yml for SWM, it will result in mv showing that world test2 exist as unloaded.
# output of /mv list
[19:22:38 INFO]: ====[ Multiverse World List ]====
[19:22:38 INFO]: world_the_end - THE_END
[19:22:38 INFO]: world - NORMAL
[19:22:38 INFO]: world_nether - NETHER
[19:22:38 INFO]: test2 - UNLOADED

# Slime World Manager worlds.yml
worlds:
    test2:
        source: file
        spawn: 0, 64, 0
        difficulty: peaceful
        allowMonsters: true
        allowAnimals: true
        pvp: true
        environment: NORMAL
        worldType: DEFAULT
        loadOnStartup: true
        readOnly: false

Yeah. SWM seems to indeed be the issue.
I removed it (mainly because it also causes errors on other ocasions) and MV works fine now.


修改测试用例报错

报错信息：Exception in thread "main" com.alibaba.fastjson.JSONException: can't create non-static inner class instance.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lijiuyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #3432 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3432   +/-   ##
=========================================
  Coverage     80.35%   80.36%
- Complexity     7457     7467   +10
=========================================
  Files           157      157
  Lines         27889    27912   +23
  Branches       6723     6731    +8
=========================================
+ Hits          22411    22432   +21
- Misses         3460     3461    +1
- Partials       2018     2019    +1

Impacted Files
Coverage Δ
Complexity Δ

.../com/alibaba/fastjson/serializer/BeforeFilter.java
94.73% <0.00%> (-5.27%)
5.00% <0.00%> (ø%)

...com/alibaba/fastjson/serializer/SerialContext.java
82.69% <0.00%> (-3.85%)
21.00% <0.00%> (-1.00%)

...stjson/support/jaxrs/FastJsonAutoDiscoverable.java
81.81% <0.00%> (-1.52%)
4.00% <0.00%> (ø%)

...main/java/com/alibaba/fastjson/util/TypeUtils.java
78.85% <0.00%> (+0.15%)
651.00% <0.00%> (+10.00%)

...ba/fastjson/parser/deserializer/Jdk8DateCodec.java
77.66% <0.00%> (+0.25%)
105.00% <0.00%> (+1.00%)

...main/java/com/alibaba/fastjson/util/FieldInfo.java
86.95% <0.00%> (+0.33%)
99.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e697d4a...c1274d3. Read the comment docs.


Implement Add Feed dialog

@vincode-io Do you mind having a look at 6b6ff7c?
It covers the Mac side of things, but it's quite a departure from the existing AppKit code. It works well...replicates the pasting of a URL from clipboard and adds feeds to the correct account / folder.
Mac Add Feed.mov.zip

I think it looks fine.  Unless there was something you thought I should be worried about that I might have overlooked, I say go with it.


Get FreeStyle ready for sharing with the company at large

Removes Utilities section entirely
Removes Applications section for now
Removes Resources section for now
Renames Guidance section to Writing Code

Also renames Components page here to Creating Components

Renames and de-dupes the colours pages
Uses the yaml values for UI colours (with a bunch of tweaking in the values file)
Removes old references to Origin includes from code examples
Removes unnecessary links from header

LGTM 👍


merge bug with [p] component

The [p] component has a bug:
https://github.com/Day8/re-com/blob/ecc55f3f2679548583efae56024f5eab634f1447/src/re_com/text.cljs#L76-L91
The code incorrectly assumes that merge works deeply on given maps (:style sub-maps to be exact).
In effect, the code incorrectly assumes that (merge   {:style {:a 1}}   {:style { :b 3}})   would return {:style {:a 1 :b 3}}  but it actually returns {:style {:b 3}}.
So current call to merge should be replaced with a call to deep-merge, which would be written as:
(defn deep-merge
  "Recursively merges maps. If vals are not maps, the last value wins."
  [& vals]
  (if (every? map? vals)
    (apply merge-with deep-merge vals)
    (last vals)))

Fixed with a83c0f63ec9cf8524f59d7b4a8c7d65b39a1995d


ERROR: Unable to extract uploader id

Checklist

[ ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2021.12.17
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

C:\Users\abc123\Downloads_Aoutube>youtube-dl -v https://www.youtube.com/watch?v=j0wCUKN8tH4
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=j0wCUKN8tH4']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] j0wCUKN8tH4: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are
using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag
and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeD
L.py", line 815, in wrapper
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeD
L.py", line 836, in __extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extracto
r\common.py", line 534, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extracto
r\youtube.py", line 1794, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extracto
r\common.py", line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-d
l.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call yout
ube-dl with the --verbose flag and include its complete output.
Description

WRITE DESCRIPTION HERE
To Whom It May Concern,
I have been successfully using youtube-dl.exe for a couple of years until February 17th, 2023. On the following day, I started getting the error message "unable to extract uploader id". I usually wait for an update or change from your end, but I decided to create a bug report instead. Any assistance you can provide would be greatly appreciated.
Thank you for your time and consideration.
Regards,

I have same problem

I have the same above problem "Unable to extract uploader id".

Ditto.
Thanks for your service.
Best Regards,
Don

Y'all, go /youtube_dl/extractor/common.py.
Line 983, change: fatal=True to fatal=False

#30839

Go here to get the last update https://github.com/yt-dlp/yt-dlp/tree/2023.02.17#installation
the new yt-dlp allow you to download again.
Thank you Dirkf for the update!


fix: KafkaSpout is blocked in AutoCommitMode

What's the issue?
When Storm topology is run on 'At-Most-Once' mode, with ack executor=0, KafkaSpout cannot emit records after some time.
What's the cause?
Function poll() controls whether it need to pull more data from Kafka cluster. With the condition !waitingToEmit() && numUncommittedOffsets < maxUncommittedOffsets, it's always FALSE after reaching threshold, as numUncommittedOffsets is creasing and never reset on 'At-Most-Once' mode.
What's the solution?
I change the condition to !waitingToEmit() && (numUncommittedOffsets < maxUncommittedOffsets || consumerAutoCommitMode), that return TRUE with AutoCommitMode regarding of UnCommittedOffset, see the comments inline.
Also, it's not required to track emitted(msgId) and numUncommittedOffsets with AutoCommitMode .

Nice find :) You should go to https://issues.apache.org/jira/ and create an issue for this. Then rename this PR to mention the jira issue number (see the other open PRs for an example). The commit message should probably also mention the issue number.
The fix itself looks fine to me.

@XuMingmin Could you rebase this? STORM-2225 touches many places on storm-kafka-client so you might need to check it's still valid.

@srdo I create https://issues.apache.org/jira/browse/STORM-2340,
@HeartSaVioR , let me check with the latest code, and open a new pull request

@HeartSaVioR The issue if still there, so I create a new pull request https://github.com/apache/storm/pull/1919 after rebase,

close this one, use https://github.com/apache/storm/pull/1919 instead.


MINIFICPP-297: Remove Boost dependencies since we have very little re…

…liance on it
MINIFICPP-297: Ensure posix compliance
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Still doing some validation on older *nix releases to validate that the stat structure is the same everywhere. In some cases it will not be, so need to finish validation against all releases.

This looks great. My only critique is that FilesystemUtils is used in a stateful way (presumably just to keep a cache of previous unique files?) I think keeping it entirely stateless would be preferable. Looking at the same issue, keeping a stateful instance of "utilities" isn't very meaningful. If part of it really needs to be stateful, I would consider making a nested class in FilesystemUtils i.e. FilesystemUtils::UniqueFileGenerator.
Overall the change is great and removes a huge dependency without adding a lot of complexity.

@achristianson statefulness helps use RAII to eliminate temp files, whereas other techniques don't do this. It's a balance between cleaning them up automatically or requiring the user to. As I saw previously with the code I removed, this was not done, and I fear most users won't properly do this. I'm with you. My initial implementation was just a simple create file without tracking. I'm still on the fence about that. We should require users to remove files, but that's not an expectation from creating temp files.

@achristianson what are your thoughts on that? I'm so on the fence I need a second opinion about that.

@phrocker my thought is to definitely keep the RAII to have simpler/safer resource management. I see the unlink in the destructor. I would just tweak the naming & organization a bit. Now I see this is actually a unique temporary file session, so I would put that in the name. I wouldn't get rid of FileSystemUtils, but would create a nested class i.e. FileSystemUtils::TempFileManager. Usage like this:
{
  FileSystemUtils::TempFileManager mgr;
  auto tmp_file = mgr.unique_file("/tmp", false);
  // Do something with tmp_file
} // All tmp files created with mgr are cleaned up (RAII)


False login error (task #5302)

Codecov Report

Merging #593 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #593      +/-   ##
============================================
+ Coverage     29.47%   29.48%   +0.01%
  Complexity     1115     1115
============================================
  Files            94       94
  Lines          3719     3720       +1
============================================
+ Hits           1096     1097       +1
  Misses         2623     2623

Impacted Files
Coverage Δ
Complexity Δ

src/Controller/AppController.php
65.68% <100%> (+0.33%)
26 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d93b42...8e46040. Read the comment docs.


Create a Shield/Hat class

Currently, the hardware of the Shield/Hat is contained in the classes HardwareArduino and HardwareRaspberry. With an Shield/Hat class, the library could be more abstracted from the hardware.

Duplicate of #27

There is now an other solution so that the classes HardwareArduino and HardwareRaspberry are now obsolete.

Pins and SPI are associated to either class Max14819 or Max14819_Port
Writing to stdout is done by a free function print()
To wait, there is a free function wait_ms().


Don't know how to pass custom input types

Hello, I am using your excellent gem in my rails app to call a graphql API in one of myother rails apps.  It has been working great so far.  Now I'm trying to make a query that takes an input object as a parameter (it's for doing a search).  The UserSearch query is defined like this:
userSearch(
    workingGroupId: ID
    therapeuticAreaId: ID
    roles: [String!]
    filters: UserFilters
    page: Int = 1
    perPage: Int = 10
    sort: String = "users.id ASC"
)

UserFilters is defined as an input type (subclass of GraphQL::Schema::InputObject in the server-side code).
On the client side, I'm parsing the query and I reference :UserFilters as the argument type, but when I run the query, how to I pass in the "filters" argument?  I tried as a hash but that did not work:
Client.query(
        UserSearchQuery,
        ta_id: current_ta.id,
        per_page: self.per_page.to_i,
        page: self.page.to_i,
        filters: {name: 'Shirley'}
      )

The error I get is "Variable filters of type UserFilters was provided invalid value"
Any help would be greatly appreciated!
Greg

Could you post the raw GraphQL query you are trying to run? It looks like a GraphQL error from GraphQL's type system, but an error from the library.

@yuki24 Thank you for your quick feedback. I was able to track it down to me passing arguments I had not defined yet, and also not passing the UserFilter arguments as camelcase (they were still snakecase from ruby).  Closing the issue.


limit search request time to 30 seconds

underlying libs (torrent-search-api) aren't setting a timeout for search requests, as described in #22.
this pr tries to address this by adding a promise race with a cancel timeout of 30 seconds.
if you'd prefer a config setting for this value, i can add that, but would prefer you decide what to call it and where it lives in the config. thanks

also if you have a stylesheet that you use locally please share or include it with the project. thank you!


Create ability to include all groups for Entities/Edges in a View

Currently if you have a view, for example:
"view" : {     "edges": {       "group1": {},       "group2": {}     } }
you must specify all groups you want to return within the view.  The feature of allowing all groups to be included should be added, something like:
"view" : {     "edges": {       "allGroups": "true"     } }
This will become very useful when seedMatching has been deprecated (https://github.com/gchq/Gaffer/issues/1798) for seedMatching EQUALS.

Merged into develop.


in aws, when do restore, restart metad too many times

normally, restart once is ok

Your Environments (required)
operator：reg.vesoft-inc.com/cloud-dev/nebula-operator:snap-1.41
br-ent: reg.vesoft-inc.com/cloud-dev/br-ent:v3.7.0
agent: reg.vesoft-inc.com/cloud-dev/nebula-agent:snap
nebula: reg.vesoft-inc.com/qa/nebula-graphd-ent:snap-hotfix
nebula: reg.vesoft-inc.com/qa/nebula-metad-ent:snap-hotfix
nebula: reg.vesoft-inc.com/qa/nebula-storaged-ent:snap-hotfix

How To Reproduce(required)
do restore
Expected behavior
restart once ,and begin storage restore

https://github.com/vesoft-inc/nebula-operator/pull/464

checked operator：snap-1.42


Incorrect result when comparing strings in memoryview of numpy recarray

Testing the latest release of Cython (0.29.13) using both Python2 and Python3 (with language_level "2" and "3", respectively), I believe I found a bug when comparing fields of a memoryview of a numpy recarray that are byte strings. The comparison always results in False. As a minimal example from the python3 code:
import numpy as np
cimport numpy as np

cdef packed struct a_type:
    np.float64_t a1
    char[5] a2

cpdef double test_func(a_type[::1] x):
    cdef:
        int i
        double res

    res = 0.0

    for i in range(1, x.shape[0]):
        print(x[0].a2, x[i].a2, x[0].a2 == x[i].a2, x[i].a2 == b'abcd')
        if x[0].a2 == x[i].a2:
            res += 1.0

    return 0.0

and then running the code:
import numpy as np

from mod1.ftest import test_func

if __name__ == '__main__':
    a = np.recarray(4, dtype=[('a1', np.float64), ('a2', 'S5')])
    a[0] = (9.0, b'abcd')
    a[1] = (8.0, b'abcd')
    a[2] = (8.0, b'xyz')
    a[3] = (8.0, b'abcd')

    print(test_func(a))

I get the following output:
b'abcd' b'abcd' False True
b'abcd' b'xyz' False False
b'abcd' b'abcd' False True
0.0

Comparing the field to a literal byte string works correctly as demonstrated in the print statement. Calling .decode() on the field also corrects the issue.
I've also pulled up an old environment I had laying around with Cython 0.25.2, and I see the issue there as well.

Comparison is being done between a null terminated string and set of bytes. Instead of "==" if you use memcmp() it should work I think.

x[0].a2 == x[i].a2
transform to
__pyx_t_11 = __Pyx_PyBool_FromLong(((*((struct __pyx_t_6gh3214_a_type *) ( /* dim=0 */ ((char *) (((struct __pyx_t_6gh3214_a_type *) __pyx_v_x.data) + __pyx_t_9)) ))).a2 == (*((struct __pyx_t_6gh3214_a_type *) ( /* dim=0 */ ((char *) (((struct __p
yx_t_6gh3214_a_type *) __pyx_v_x.data) + __pyx_t_10)) ))).a2));

so we are comparing char[] memory addresses NOT string literals.
I could suggest such a workaround
for i in range(1, x.shape[0]):
        print(x[0].a2, x[i].a2, str(x[0].a2) == str(x[i].a2), x[i].a2 == b'abcd')
        if x[0].a2 == x[i].a2:
            res += 1.0

As i can see it adding type conversion call
__Pyx_PyObject_CallOneArg(((PyObject *)(&PyString_Type)), __pyx_t_10)
but after it's using
PyObject_RichCompare instead of ==.

https://github.com/cython/cython/issues/1141 seems related.


Bug in $util.transform.toDynamoDBFilterExpression with nested ors

Describe the bug
A filter query with nested ORs in AppSync does not map to a correct DynamoDB Expression. Some values are overwritten.
Amplify CLI Version
4.16.1
To Reproduce

Simplified graphql schema to setup the repro:

type Clinic @model {
   id: ID!
  patients: [Patient!] @connection(name: "ClinicPatients", sortField: "updatedAt")
}

type Patient @model {
   id: ID!
   phone: AWSPhone
}

Now create a clinic in the db as well as a patient that belongs to that clinic with phone # of<PHONE_NUMBER>

Now run the following graphql query (let's call it Query A):
query GetPatientsForClinic {
   getClinic(id: "<your-id-here>") {
      id
      patients (
      limit: 1000
         filter: {
        or: [
            {
               phone: {
                eq:"5039260766"
              }
          },
           {
              or: [
                {
                  phone: {
                    eq: "5038768765"
                  }
                }
            ]
          }
        ]
      }
    ) {
      items {
        phone
      }
      nextToken
    }
   }
}

You will get no patients back.
Now run the following query (let's call it Query B):
query GetPatientsForClinic {
   getClinic(id: "<your-id-here>") {
      id
      patients (
      limit: 1000
         filter: {
        or: [
            {
               phone: {
                eq:"5039260766"
              }
          },
           {
              phone: {
                eq: "5038768765"
              }
          }
        ]
      }
    ) {
      items {
        phone
      }
      nextToken
    }
   }
}

You will correctly get patient with phone #<PHONE_NUMBER> back.
Expected behavior
Like Query B, Query A should also return the patient.
Additional context
The problem is the dynamodb expression generated for Query A is wrong. It is the following:
   "transformedTemplate": "{\n  \"version\": \"2017-02-28\",\n  \"operation\": \"Query\",\n  \"query\":   {\"expression\":\"#connectionAttribute = :connectionAttribute\",\"expressionNames\":{\"#connectionAttribute\":\"patientClinicId\"},\"expressionValues\":{\":connectionAttribute\":{\"S\":\"<your-id-here>\"}}},\n  \"scanIndexForward\":   true\n  ,\n  \"filter\":   {\"expression\":\"((#phone = :or_0_phone_eq) OR (#phone = :or_0_phone_eq))\",\"expressionNames\":{\"#phone\":\"phone\"},\"expressionValues\":{\":or_0_phone_eq\":{\"S\":\"5038768765\"}}}\n  ,\n  \"limit\": 1000,\n  \"nextToken\":   null\n  ,\n  \"index\": \"gsi-ClinicPatients\"\n}"
You can see there is only one phone # in this expression, the phone # of<PHONE_NUMBER> is missing.
This is the dynamodb expression for Query B - it is correct:
    "transformedTemplate": "{\n  \"version\": \"2017-02-28\",\n  \"operation\": \"Query\",\n  \"query\":   {\"expression\":\"#connectionAttribute = :connectionAttribute\",\"expressionNames\":{\"#connectionAttribute\":\"patientClinicId\"},\"expressionValues\":{\":connectionAttribute\":{\"S\":\"<your-id-here>\"}}},\n  \"scanIndexForward\":   true\n  ,\n  \"filter\":   {\"expression\":\"((#phone = :or_0_phone_eq) OR (#phone = :or_1_phone_eq))\",\"expressionNames\":{\"#phone\":\"phone\"},\"expressionValues\":{\":or_0_phone_eq\":{\"S\":\"5039260766\"},\":or_1_phone_eq\":{\"S\":\"5038768765\"}}}\n  ,\n  \"limit\": 1000,\n  \"nextToken\":   null\n  ,\n  \"index\": \"gsi-ClinicPatients\"\n}"
You can see both phone #s<PHONE_NUMBER> and<PHONE_NUMBER>) are in this expression.

Hello @hisham the second Query B is the correct way to format that query. The first, Query A, is essentially generating a filter where the 2nd statement has nothing to OR against, which could lead to the utility function formatting the expression value incorrectly.
ex. ( (statement1) OR (statement2 OR) )
We'll take note of this as a potential validation enhancement to discuss with the AWS AppSync team.

Hi @SwaySway  - the example I gave is just a simplified repro case. I ran into this bug in cases where there were multiple conditions in the OR and values were getting overridden. From my testing this is a bug not an enhancement.
Here is an example of a more realistic query that was incorrectly mapped to a dynamodb expression - in this case I want patients with phone ===<PHONE_NUMBER> OR (phone ===<PHONE_NUMBER> OR email === test@gmail.com):
query GetPatientsForClinic {
   getClinic(id: "<your-id-here>") {
      id
      patients (
      limit: 1000
         filter: {
        or: [
            {
               phone: {
                eq:"5039260766"
              }
          },
           {
              or: [
                {
                  phone: {
                    eq: "5038768765"
                  },
                  email: {
                    eq<EMAIL_ADDRESS>                  },
                }
            ]
          }
        ]
      }
    ) {
      items {
        phone
      }
      nextToken
    }
   }
}

It didn't work. If you want, I can try again and send you more details including the dynamodb expressions it maps to.

Just realized you can argue the second query I sent is also not "optimal". Here is a third query that is more realistic and is closer to the query we were running:
It's basically patient ===<PHONE_NUMBER> || ( firstName === john && lastName === smith && (phone ===<PHONE_NUMBER> || email === test@gmail.com))
query GetPatientsForClinic {
   getClinic(id: "<your-id-here>") {
      id
      patients (
      limit: 1000
         filter: {
        or: [
            {
               phone: {
                eq:"5039260766"
              }
          },
           {
              { firstName: 'john' },
              { lastName: 'smith'},
              or: [
                {
                  phone: {
                    eq: "5038768765"
                  },
                  email: {
                    eq<EMAIL_ADDRESS>                  },
                }
            ]
          }
        ]
      }
    ) {
      items {
        phone
      }
      nextToken
    }
   }
}


Continue bundle

Codecov Report

Merging #485 (9aa7726) into master (d493ef2) will decrease coverage by 0.02%.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   39.41%   39.38%   -0.03%
==========================================
  Files          34       34
  Lines        5323     5372      +49
==========================================
+ Hits         2098     2116      +18
- Misses       3225     3256      +31

Impacted Files
Coverage Δ

assemblyline_core/submission_client.py
46.60% <27.27%> (-6.42%)
:arrow_down:

assemblyline_core/dispatching/dispatcher.py
75.61% <39.28%> (-1.33%)
:arrow_down:

assemblyline_core/dispatching/client.py
79.77% <87.50%> (-0.34%)
:arrow_down:

assemblyline_core/dispatching/schedules.py
96.38% <100.00%> (+3.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d493ef2...9aa7726. Read the comment docs.


High accuracy is simply not working on devices

Hello there!
I'm running this library with .house accuracy and it simply hangs if I'm testing on my device (iPhone 7) However, it works perfectly with the simulator.
I tried the .city accuracy and it worked perfectly on both, the simulator and the device.
I can't tell exactly what's wrong, as the onError part of the location request is even being called.
I can see that the request is being added through Location.onAddNewRequest.
Thanks!

I have the same issue. Did found something ?

@malcommac can you please fix the high accuracy ? For me, .room and .house don't work.

Just fixed in 2.0.2.


Document the need to destroy a bean that was injected via Instance

As written in the post, it is necessary to manually destroy beans created with Instance#get. The current documentation only says

Provides a fully-constructed and injected instance of T.

I would say that "fully-constructed and injected" gives the impression that it is managed by the container. This will cause unobvious memory leaks. I would suggest adding something along the lines of:

The instance is created in the @Dependent(link to the docs of the annotation) scope not managed directly by the container, Therefor, its lifecycle should be handled by the caller. After using it, it should be released with a call to Instance#destroy (or CDI#destroy). Failing to do so can result in a memory leak (usually when the containing bean goes back to the pool/passivated and is not destroyed).
A typical use case of such an instance is:
Instance<MyBean> creator = ...;
MyBean myBean = creator.get();
myBean.doSomething();
creator.destroy(myBean);

In the last part of the [paragraph about Instance, it says (among other things):

Applications are encouraged to always call destroy() when they no longer require an instance obtained from Instance.

I am not sure if there are other mentions TBH.

I would say that "fully-constructed and injected" ...

It is exactly what it states - constructed (instantiated by CDI) and having its dependencies injected. And, for the most part, managed. But in some cases it is plain impossible for CDI container to do, see below.
Resolving dependent bean from an Instance basically follows the same rules as any other injection; the dependent bean is bound to the lifecycle of the Instance. So, in most cases you don't even need to manually destroy those obtained dependent instances if the Instance itself belong to a bean that will be eventually destroyed (unless, of course, you go on resolving large quantities of dependent beans). The problematic case is typically with things like CDI.current().getBeanManager().createInstance() which can be obtained from anywhere. This means its dependent beans will never be deleted automagically, until the CDI container shuts down. So it is in fact still managed.
Hope this^ makes sense, feel free to ask further questions :-)

Provides a fully-constructed and injected instance of T.

This sentence comes from the javax.inject.Provider which is not part of the CDI API. The CDI spec defines what exactly happens if Instance#get() is called. Moreover, it states that "Applications are encouraged to always call destroy() when they no longer require an instance obtained from Instance". In fact, it should read "...call destroy() when they no longer require an instance of a @Dependent bean obtained..." because normal scopes are not affected.

I would say that "fully-constructed and injected" gives the impression that it is managed by the container.

It is managed by the container. However, as mandated by the spec the container must retain all @Dependent instances created via Instance#get() in the creational context of the bean that injected Instance<T>.
That said, it would not hurt to mention this specific behavior in the javadoc of javax.enterprise.inject.Instance<T>.

The problem is that I see no mention of it either anywhere in the javadocs. Instance doesn't mention it, Provider (from which get is inherited) doesn't mention it, and get itself doesn't mention it. The programmer relies on the Javadoc for correct usage and rarely consults the specs for how to use a class or its methods.
My suggestion is to document whatever is needed to allow programmers to avoid this pitfall, regardless of the exact definition of managed and an out in the form of "we told you so in the specs" :)
You know better when this can occur ("The problematic case is typically with things like...") and why, I just suggested a starting point.
For what it's worth, the Instances I use are obtained by CDI.current().select, but the blog post shows that this can happen when Instance is injected.

but the blog post shows that this can happen when Instance is injected.

Well, yea. Except it's injected into an EJB bean which isn't by definition a standard CDI bean but I get your point.

The problem is that I see no mention of it either anywhere in the javadocs.

I am not sure how to easily describe it in javadoc because like I said, in many cases, this won't be an issue and won't cause a leak and encouraging users to always destroy instances created from Instance might be an overkill. Especially since it is common that user doesn't necessarily know the scope of the bean they are resolving.
But we could add some note around the lines of:

Dependent beans resolved via Instance have a lifecycle bound to that of the Instance that resolved them. If the Instance is injected into non-contextual object, users are encouraged to destroy any dependent beans created via this Instance when they no longer need them.

(poor wording, I know; it's just the first thing that I thought of :))

Something like that seems fine. I would just add how to destroy it:

users are encouraged to destroy any dependent beans created via this Instance when they no longer need them by calling Instance#destroy (or CDI#destroy).

Preferably, a short code example similar to what I had in mind can also be added.
I, too, called the CDI.current().select in a @Stateless EJB, so I would say that this issue can be camouflaged well. In fact, I might remind the user of this with something like

If the Instance is injected into non-contextual object (including EJBs), users are...

Something like that seems fine. I would just add how to destroy it:

users are encouraged to destroy any dependent beans created via this Instance when they no longer need them by calling Instance#destroy (or CDI#destroy).

Note that a @Dependent bean instance must be destroyed by the same Instance that created it. As described in https://github.com/eclipse-ee4j/cdi/blob/master/api/src/main/java/jakarta/enterprise/inject/Instance.java#L219-L220.
Maybe we should also mention the Instance.Handle which allows users to inspect the scope of the relevant bean and destroy it only if needed.

I, too, called the CDI.current().select in a @Stateless EJB.

That's a very bad practice IMO. CDI.current() should only be used if regular injection is not available.

Note that a @Dependent bean instance must be destroyed by the same Instance that created it.

Ah, then remove the (or CDI#destroy) from my suggestion.

That's a very bad practice IMO. CDI.current() should only be used if regular injection is not available.

I agree, but in my case I only know which bean out of many I need during runtime only. I won't be surprised if there's a better pattern to do that.

@starksm64 In what PR was this fixed? I would like to see the new wording.

I think this was closed because of the tracking issue under injection API?
I.e. https://github.com/eclipse-ee4j/injection-api/issues/28

I would like to see the new wording.

I wouldn't mind seeing a PR for it :-)

I think the issue in @Inject is incorrect, as Instance belongs to CDI, but maybe I got confused?

Yes, and it boils down to where we want to document it (and I agree Instance looks like your best bet). Technically, it already is specified in the spec, but not mentioned in the javadoc. One idea was the get() method which comes from Provider which is probably the reason for the other issue. The class-level javadoc of Instance might be the go-to spot.


bugfix(tier4_simulator_launch): fix occupancy grid map not appearing problem in psim

Description

Problem
occupancy grid map is not generated in latest changes.
This is due to:

psim should not use pointcloud based method since pointcloud based method yields both raw and obstacle pointclouds
fixed args in laserscan based launch.py due to unintended bugs

Changes

use laserscan-based method instead of pointcloud

fix some args to fit psim environment

fix laserscan based launch.py to make bool args changable

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Confirmed in both lsim and psim


Accessing context within the test

An example use-case, I want rpminspect to skip metadata when initiator == packit because the copr metadata always fails. This would work with adjust, but in more complicated cases, I would like a more general approach that I can use at runtime.

I have tried using the $@, but this i not expanded within environment:environment:
  CONTEXT_INITIATOR: $@{initiator}

I have tried looking for any other source where context are stored at runtime, but there doesn't seem to be any

Some potential solutions:

Expand all environment nodes. This would be tricky if there is recursive dependence
Add context to TMT_TEST_METADATA
Export TMT_CONTEXT_* variables by default

The decision is to store used context into  TMT_TEST_METADATA file.

Only the TMT_TEST_METADATA or deeper down in Core._update_metadata?

I'd add it somewhere here, combining test._metadata with context without changing what's in test._metadata. That should preserve test metadata for whoever would be interested in using them, not spoiling them with context that would added just to expose it to the test.


Port to r3f

Hello, I assume this project is not maintained anymore. But I thought I could ask, if you ever ported this to r3f or if you are interested in porting it.
I could pick up the task if you could give me some pointers about where to start. Thanks!

Thanks @netgfx! and +1 - that'd be great!
If I was refactoring i'd probably start with

[ ] Porting over shader material (you could porbably use Drei's shaderMaterial wrapper
[ ] Writing a wrapper R3F component that exposes the params the plugin exposes as props


[Avgle] Download the preview video only

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Japan
Provide a description that is worded well enough to be understood
It's download a preview video only, thanks!
Need to connect the VPN.
Test video: https://avgle.com/video/_kWhBhm4zhw/台湾硬汉兄弟大战e奶网红-红豆饼妹-视频遭泄露
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://avgle.com/video/_kWhBhm4zhw/%E5%8F%B0%E6%B9%BE%E7%A1%AC%E6%B1%89%E5%85%84%E5%BC%9F%E5%A4%A7%E6%88%98e%E5%A5%B6%E7%BD%91%E7%BA%A2-%E7%BA%A2%E8%B1%86%E9%A5%BC%E5%A6%B9-%E8%A7%86%E9%A2%91%E9%81%AD%E6%B3%84%E9%9C%B2', '-vU']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [24f827875] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22621-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2021-04-07-git-c06465a70b-full_build-www.gyan.dev (setts), ffprobe 2021-04-07-git-c06465a70b-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2023.07.22, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1901 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[generic] Extracting URL: https://avgle.com/video/_kWhBhm4zhw/%E5%8F%B0%E6%B9%BE%E7%A1%AC%E6%B1%89%E5%85%84%E5%BC%9F%E5%A4%A7%E6%88%98e%E5%A5%B6%E7%BD%91%E7%BA%A2-%E7%BA%A2%E8%B1%86%E9%A5%BC%E5%A6%B9-%E8%A7%86%E9%A2%91%E9%81%AD%E6%B3%84%E9%9C%B2
[generic] 台湾硬汉兄弟大战e奶网红-红豆饼妹-视频遭泄露: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 台湾硬汉兄弟大战e奶网红-红豆饼妹-视频遭泄露: Extracting information
[debug] Looking for embeds
[debug] Identified a Open Graph video info
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] preview: Downloading 1 format(s): 0
[debug] Invoking http downloader on "https://static-clst.avgle.com/videos/tmb20/662339/preview.mp4"
[debug] File locking is not supported. Proceeding without locking
[download] Destination: 台湾硬汉兄弟大战E奶网红“红豆饼妹”视频遭泄露! [preview].mp4
[download] 100% of  122.11KiB in 00:00:00 at 131.41KiB/s

This site looks like it is primarily used for piracy and therefore cannot be supported. If you have reason to believe otherwise, please provide evidence.


chore: migrate to pnpm

What does this PR do?
Migrates from npm to pnpm for faster install speeds and smaller storage size requirements
Test Plan
Manual
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes

Converting to draft due to merge conflicts.


PowerToys crashed

Microsoft PowerToys version
0.41.3
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Launch PowerToys Run using the shortcut Ctrl + Space.
Enter a search tern to launch an application.
✔ Expected Behavior
PowerToys Run to execute a search.
❌ Actual Behavior
Crashed.
PowerToysReport_2021-06-30-10-12-27.zip
Other Software
No response

According to the log file attached (PowerToysReport_2021-06-30-10-12-27.zip\PowerToys Run\Logs\<IP_ADDRESS>\2021-06-30.txt) This issue is duplicating #11970 .
Line 438~462 for the file is pasted below:
System.InvalidCastException: Unable to cast object of type 'System.Windows.Documents.Run' to type 'System.Windows.FrameworkElement'.
   Source: PowerLauncher
   TargetAssembly: PowerLauncher, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
   TargetModule: PowerLauncher.dll
   TargetSite: Void SuggestionsList_PreviewMouseLeftButtonUp(System.Object, System.Windows.Input.MouseButtonEventArgs)
   at PowerLauncher.MainWindow.SuggestionsList_PreviewMouseLeftButtonUp(Object sender, MouseButtonEventArgs e)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.UIElement.OnPreviewMouseUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.ContentElement.RaiseTrustedEvent(RoutedEventArgs args)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

@ejmurray
Does it happen on clicking on the search result or pressing the enter key?

Closing as duplicate of https://github.com/microsoft/PowerToys/issues/11898

We have a hot fix coming shortly to address this issue. Thanks for reporting it!


Provide a way to  customize log format

Provide a mechanism to specify a custom HAProxy log-format

Available as release 1.286.


Paypal Button renders then immediately disappears

Description
Over the weekend something changed in the operation of the paypal express checkout button on kiva.org's payment page. The button initially renders then quickly disappears.
While attempting to debug this using Chrome's dev tools, I noticed that the instance fell into a "sacrificialIframe" state and triggered the "hideElement" method. I believe this code was in the drivers.js.
I could not determine what set this in motion as we had not made any changes to our code over the weekend.

[x] https://drive.google.com/file/d/0B-nF0MgqRt4wSHhvWVJPY0Z4MUk/view?usp=sharing
[x] https://www-kiva-org.global.ssl.fastly.net/rgit2e969457aa8884f7fa081b0de7339ebe19865461/views/Basket/ReviewBasketView.js
[x] https://www.paypalobjects.com/api/checkout.min.js
[x] See Notes in Reproduction Section
[x] No console log messages were reported
[ ] Does the issue also occur at developer.paypal.com/demo/checkout?

Steps to reproduce
Visit Kiva.org
Click "Lend" in the top Navigation
Select any Loans  and click "Lend $25" to add it to your Basket
Click "Proceed to Checkout" to visit the Basket, then Click Continue
Log In or Register to be sent to the payment page.

We had to turn off the button to the public, Paste this link in the address bar to trigger usage of the Paypal Express flow ( https://www.kiva.org/basket/payment?kexpn=paypal_express_checkout.checkout_paths&kexpv=b )

Affected browsers

[x] Chrome
[x] Safari
[ ] Firefox
[ ] Edge
[ ] IE
[ ] Chrome Mobile/Tablet
[ ] Safari Mobile/Tablet
[ ] Web View / Safari ViewController
[ ] Other

Thanks for the report. Taking a look.

I'm seeing the button is being hidden by your code, but I can't see the reason:

Can you please look at the un-minified code and figure out why this .hide() line would be triggered?

@bluepnume How did you find that?!?! I tried to break on changes to that attribute or element but couldn't get to the stack trace you found.
You were absolutely correct. This was an unplanned interference from a different 3rd party lib.
Thank you so much for looking at this and I apologize for taking up your time with something we did.
I think it's safe to close this issue.

Haha no problem at all! Glad to hear you managed to track it down.
You can set a breakpoint on changes to an element like so:


[PE-D][Tester C] Invalid dates are allowed

Steps to Reproduce:

Add any appointment with date 31 on a month with less than 31 days.
e.g.
edit Alex Yeoh ap/31/02/2025 0000

Expected:
Error Message: invalid date
Actual:
Date is "rounded down" to nearest valid date and accepted.

Labels: severity.Low type.FunctionalityBug
original: engyuhan/ped#4

Duplicated issue.


SSE is on by default

Hi Team,
As SSE cannot be disabled and is on by default, would it be better to change this wording below:
"Storage Service Encryption enables you to request that the storage service automatically encrypt data when writing it to Azure Storage."
To some thing like:
"Storage Service Encryption is always enabled, and will automatically encrypt storage service data when writing it to Azure Storage."
Or is there an ability to request the feature be enabled/disabled that I might have missed?
Thanks,
James

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a580028-8116-e73b-3fe2-a9a307a8f292
Version Independent ID: 7a11b3b9-cd6e-8fc2-1289-aecdaaf3936b
Content: Security features that can be used with Azure Storage
Content Source: articles/security/security-storage-overview.md
Service: security
GitHub Login: @TerryLanfear
Microsoft Alias: terrylan

@jlee-vi - Thank you for your feedback. The article has been updated with your suggestion and should publish on 2/4/19.
Updated via PR #65050
#please-close


pwa: Switch to injectManifest strategy for sw.

This allows us to add custom functionality to the SW later (i.e., web push notifications).
Overall functionality should be exactly the same for now.

seems good as long as skipWaiting is ok in our case. I think it is?

As long as you see the new service worker running and not waiting it should be good


Create New Kokoro Job for Python Bazel Workspace Test

Reference: https://github.com/grpc/grpc/pull/19822#discussion_r310788371

CC @lidizheng


Ignore sloth_window in prometheus alerts

This prevents alerts resolving and re-firing when different windows fire.
Implemented using the suggestion from @tokheim in #240.
Fixes https://github.com/slok/sloth/issues/240

Codecov Report

Merging #295 (2f6a69e) into main (6fabcee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   75.55%   75.55%
=======================================
  Files          17       17
  Lines        1489     1489
=======================================
  Hits         1125     1125
  Misses        286      286
  Partials       78       78

Impacted Files
Coverage Δ

internal/prometheus/alert_rules.go
87.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fabcee...2f6a69e. Read the comment docs.

Hi!
First of all @Limess Thanks for the PR!! and second... sorry to @tokheim for taking so long to keep the ball rolling on this enhancement.
Regarding the PR, I'm into adding this, so very happy to see it! :rocket: An small comment regarding the query, what do you think about this simplification?
From this:
(
     (
          max without (sloth_window) (slo:sli_error:ratio_rate5m{sloth_id="workshop-burning-2x-jitter-10"}) > ...
          and
          max without (sloth_window) (slo:sli_error:ratio_rate1h{sloth_id="workshop-burning-2x-jitter-10"}) > ...
      )
      or ignoring (sloth_window)
      (
          max without (sloth_window) (slo:sli_error:ratio_rate30m{sloth_id="workshop-burning-2x-jitter-10"}) > ...
          and
          max without (sloth_window) (slo:sli_error:ratio_rate6h{sloth_id="workshop-burning-2x-jitter-10"}) > ...
      )
)

to:
max without (sloth_window) (
     (
          (slo:sli_error:ratio_rate5m{sloth_id="workshop-burning-2x-jitter-10"}) > ...
          and ignoring (sloth_window)
          (slo:sli_error:ratio_rate1h{sloth_id="workshop-burning-2x-jitter-10"}) > ...
      )
      or ignoring (sloth_window)
      (
          (slo:sli_error:ratio_rate30m{sloth_id="workshop-burning-2x-jitter-10"}) > ...
          and ignoring (sloth_window)
          (slo:sli_error:ratio_rate6h{sloth_id="workshop-burning-2x-jitter-10"}) > ...
      )
)

From my point of view the last one would be like "Get me the alert, and now, once I have it, drop this specific label, because I don't want it".
Let me know your thoughts on this. Thanks!

Personally I favor the readability of the suggestion in PR. It normalizes the metrics, and then there is no fuzz when joining them together with and/or. Still I see that as quite a subjective preference, and since its sort of part of the internal logic of the library, I think probably your opinion matters more then @slok. One thing that could be an important factor is the performance of the query. Did some very unscientific tests and couldn't see any noticeable difference though.
No worries @slok, even with a few re-firings I'm super happy with sloth. Thanks @Limess for looking into the issue!

I updated the branch to fix the test failures (inconsistency in window spacing). Let me know if you would like to go ahead with your alternative or not, it'd be great to get this in as it's causing a small amount of confusion when introducing Sloth in our org right now.

Forget about my comment, although I prefer what I propose, I don't have a strong opinion and @tokheim was the starter of this problem and approach, so let's go with his approach :)

The integration tests are failing because you removed the ignore window also on the optimized SLI recording rules (e.g) instead of only removing them from the alerting rules.

Thanks, they run locally aside from some warns about missing binaries.

Sorry about the multiple iterations - I should have found this sooner https://github.com/slok/sloth/blob/main/CONTRIBUTING.md!
It's a little confusing that the way of running the k8s/CLI tests locally is using the CI commands, and that make integration doesn't seem to find the binaries (I assume it needs the binary and kube config mounting and setting as env vars in the docker container).
I've been through them individually and copied actual into the assertions now, and the make ci-integration-k8s and make ci-integration-cli now pass.

No worries, the CI thing is because these executions are run without docker and normally CI tests are mostly run in CI and not on local (except when big changes are made, like affecting the resulting rules).

I'll try taking a look this week however I'll be in Valencia in the Kubecon so maybe it's delayed until next week! :sweat: many thanks for all the effort @Limess :top:

@Limess @tokheim Could you test this with ghcr.io/slok/sloth:2de193572284e36189fe78ab33beb7e2b339b0f8 image and after some days give me feedback of the outcome? It's a big change so the more we test the better before cutting a new release.
Many thanks!

Thanks for merging!
I've tested this on our alerts and it looks fine, no noticable change in burn rates or anything.
We're only using sloth to generate prometheus config as a build step, we're not running anything live in kubernetes, so can't help there.

Hey @slok, any chance that we could get a stable release with this change? We've been running the alerts in productions for a while now and they fix the issue for us.

Hi @Limess!
Sorry for the delay.
I'll try sorting this in the nex 2t weeks (I'll check dependency upgrades, helm chart PRs...).
Thanks.


true & false instead of TRUE & FALSE

Quick question: does this mean I cannot use lowercase options?
And why would you want to SCREAM booleans? :black_joker:

According to the reference, you can use lowercase, camelCase, or WhATEverCASE for booleans (http://php.net/manual/en/language.types.boolean.php). In the reference, they seem to mostly use SCREAM-CASE. But I aggree that it is a bit noisy.
I looked around a bit to discover if there are any conventions. It turns out that the PSR-2 coding standard (https://www.php-fig.org/psr/psr-2/) states that booleans must be lowercase.
For those reasons, changing to lowercase seems a good idea.
Here are some discussion on the topic:
https://stackoverflow.com/questions/2013848/uppercase-booleans-vs-lowercase-in-php


How to change the data storage directory

I deploy according to the docker-compose.all-in-one.yml file,
It can be deployed successfully and everything is normal. But he can only use the default disk of the system. I cannot switch to the newly installed disk.

Crash when the system default disk is used up。
I created a ubuntu VM in azure, the default is 30G. I mounted a new disk, but I don't know how to switch the service to the newly mounted disk.
My new disk is "datadrive". What configuration can I add in docker-compose.all-in-one.yml to store data in "datadrive"? I want to store all data in "datadrive"

That docker file you are pointing to is only storing the data inside of the container and will be lost when you should the container down. If you want to persist the data then you need to map the data directory to a volume in the compose file like this one does: https://github.com/exceptionless/Exceptionless/blob/master/samples/docker-compose.yml#L58 The docs talk about it here as well: https://exceptionless.com/docs/self-hosting/docker/

I added this sentence, but the data is still not stored in "datadrive"
`version: '3.5'
services:
elasticsearch:
image: exceptionless/exceptionless:latest
ports:
- 5000:80
- 9200:9200
- 9300:9300
volumes:
- esdata7:/datadrive/share/elasticsearch/data
kibana:
depends_on:
- elasticsearch
image: docker.elastic.co/kibana/kibana:7.12.0
ports:
- 5601:5601
volumes:
esdata7:
driver: local
appdata:
driver: local
ssldata:
driver: local
`
The picture below is the file in my real environment

The data is still in the original "overlay"

The volume name is: ex_esdata

Please let us know if you have any other questions.

The volume name is: ex_esdata, and you wouldn't redefine the volumes at the bottom as you need to update the volume for the image:
``
services:
elasticsearch:
image: exceptionless/exceptionless:latest
ports:
- 5000:80
- 9200:9200
- 9300:9300
volumes:
- esdata:/datadrive/share/elasticsearch/data

Please let us know if you have any questions.


improve UI/UX of Cards and box in website.

##Is your feature request related to a problem? Please describe.**
🙋♂𝗛𝗶 ZeroOctave, If, you have assign me for the contributing on this issue. To improve UI/UX of Cards and box in website.
Example:
https://user-images.githubusercontent.com/93794214/156365981-589af417-1532-4563-8762-9e0afc4a0b79.mp4
Code of Conduct✅

[x] I agree to follow this project's Code of Conduct.
[x] I checked the current issues for duplicate problems.
[x] I have gone through project README.

I want to work on this under GSSOC2022. Here is my discord profile DHANANJOY DEY | Contributor#7903

@Astrodevil
I would like to work on this issue.
My Skills in web development :
1)HTML
2)CSS
3)Bootstrap
4)Javascript
5)Jquery
My experience :
5+ months of experience in UI design.
Worked on Hands-on projects. My Github repo shows it

@Astrodevil

@SayedTabish72 You are proposing changes on landing page?

@Astrodevil I believe the issue hasn't been assigned yet, and the landing page needs a lot of alterations with respect to the UI. I'd like to work on this issue, having previous experience with design.


Rejecting unwanted inputs

We are fuzzing a C++ API where there is undefined behaviour for certain out-of-bounds/invalid inputs

We do have precondition checks for all API's, so we could just bail out early and ignore the input, but we are worried about polluting the corpus with these invalid inputs which will be then selected for further mutation, creating outcomes 99% of which will probably still be invalid. So this an efficiency concern.
We can't detect these bad inputs with domain checks, because we are essentially doing https://github.com/google/fuzzing/blob/master/docs/structure-aware-fuzzing.md#fuzzing-stateful-apis where we execute a series of methods/calls against our API, and we don't know if an input is bad until we have got some way through the run, so we can't do it up-front.

Would you consider providing the ability for rejecting inputs similar to https://llvm.org/docs/LibFuzzer.html#rejecting-unwanted-inputs ? Or is this in some way the wrong philosophy these days?

Added fuzztest::SkipTestsOrCurrentInput() for this - feel free to reopen for any issues.


feat: Add api to check the git connection after the key is regenerated

Description

A user should have an option to regenerate the ssh keys for the git connected applications in case the key is compromised. This change set adds an API to test the connection after the key is regenerated by the user.

Fixes #10299
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally
TC's on the way

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=9b9fea2