Poll: Should we support 2 spaces indentation?

While official stance of JetBrains (citation needed) is 4 it's seems like we're alienating considerable chunk of the community (Square, Trello, etc.) by not allowing indentation with 2 spaces.
So the question is: should we allow 2 spaces for indentation or adhere to the official recommendation?

https://github.com/yole/kotlin-style-guide/issues/38#issuecomment-290942021

Can't you add a config file where you specify stuff like that?

I could but that would be against the "no configuration" policy and we'll be back in checkstyle territory. If there is a config file then why not to allow user to configure every aspect of ktlint? I mean, it requires minuscule amount of code and little effort, so why not?
The thing is, I want to keep ktlint simple for the user, keep it a "drop in" solution. You just add it and forget it (you can turn auto-correction (-F flag) on by default (as part of mvn verify / gradle check; or bind it to a commit hook) so that ktlint would do its job without bothering you too much).
Now, if there is a huge demand for 2 space indentation (and it seems like this is the case) - one way to tackle the problem would be to have 2 ktlint artifacts (which have exactly the same set of rules with  1 distinction - indentation rule): ktlint (standard, 4 spaces indentation) and say ktlint-indent2 (2 spaces indentation adopted by Square). This is similar to standard vs semistandard.

Another option: get the value from .editorconfig :tada:

Read from .editorconfig if present and otherwise allow 2 or 4 spaces seems legit to me.

I really like that idea with editor config. It's zero config drop in but respects the  project settings.

@joshfriend @scottmeschke @tedyoung @fwilhe @PaulWoitaschek @mttmllns I'm happy to announce that this issue is effectively resolved. Starting from 0.8.0 ktlint checks .editorconfig for indent_size:
# within project's root directory
printf '[*.{kt,kts}]\nindent_size=2' >> .editorconfig
ktlint

:balloon:
P.S. Recommendation is still to use 4 spaces for indentation. Official position has not changed :wink:

Do you account the intendation intent too?

@PaulWoitaschek if you mean continuation_indent_size then no - not yet. Right now ktlint does a very basic check - "is indentation multiple of indent_size or not?".

you forgot about Google - they're 2 spaces too.
Tbh, 2 spaces is so much better than 4, but we all have AOSP to thank for that.


GPII-1263:  Update gpii.express to use "new world" infusion...

See GPII-1263 for details.

Closed for #10 which incorporates all this material where it will be reviewed


Terminate server thread on exit

The HTTP server thread must be gracefully terminated when the parent duckdb thread exits

Implemented with d78d8758089da82b163b9158e4fea280f5031fef


Revert "Checklist models (#449)"

This reverts commit a9de904d282ec1c2bad11d1a9d9c847af01da1ca.

Coverage decreased (-0.006%) to 94.203% when pulling a0b3f5b0edf7020fc6f7db88e04299b3250a4fe6 on revert-checklist-model2 into a9de904d282ec1c2bad11d1a9d9c847af01da1ca on master.


[Editor] Turning objects Off and On doesnt appear to work reliably if at all

I'll look into this one!

I'll look into this one!

Thanks!


[proposal] support topology-manager-scope in NUMA aware scheduling

What is your proposal:
support topology-manager-scope in NUMA aware scheduling
Why is this needed:
kubelet support container and pod in topology manager by --topology-manager-scope. And koord-scheduler only support pod scope for now.
Is there a suggested solution, if so, please add it:

/assign

Temporarily closed, as there is not enough time to complete this work at the moment


Requirements re-haul

This PR rationalises the dependencies of iris for using conda with the CI travis-ci and readthedocs services, and also for PyPI.
Our current custom approach to manage both conda and PyPI dependencies as one, in general is not intuitive, nor standard, and leads to confusion for both developers and users alike.
Rather, this PR adopts standard community known approaches using self-contained conda environment yml files, and setup.py to manage PyPI dependencies for iris.
All the dependencies now live under the root directory requirements:
requirements
|-- all.txt
|-- ci
|   |-- iris.yml -> py37.yml
|   |-- py36.yml
|   |-- py37.yml
|   `-- readthedocs.yml -> iris.yml
|-- core.txt
|-- docs.txt
|-- setup.txt
`-- test.txt

For conda
As a developer, configuring iris with all the relevant dependencies that you need to code, test, and build the docs is now as simple as:
> conda env create --file=requirements/ci/iris.yml
> . activate iris-dev

Using conda over pip is preferred, due to the superior package dependency management and package coverage. Note that, for conda all packages are pulled from conda-forge and the associated yml files will create the named environment called iris-dev.
So it's one environment for all when it comes to coding, testing, and documentation (although now we can differentiate package content and package versions based on the Python version) which ensures (as far a possible without freezing the environment) that there is environment stability no matter what you are doing i.e., there are no package or package version differences for travis-ci, readthedocs, coding, local testing or building the docs.
The minor downside is that there is some duplication, but IMHO the simplicity and utility of this approach far outweighs the disadvantages of our current custom mechanisms to cherry-pick and manage package dependencies.
Note that, the readthedocs.yml is an alias for the iris.yml file, which is an alias for py37.yml file. As we roll forwards with testing iris with more modern versions of python, we simple create those Python version specific yml files e.g., py38.yml, re-point iris.yml to py38.py, and update .travis-ci.yml appropriately to update the test matrix.
For pip
It's not possible to only use pip to install scitools-iris (PyPI name) due to all the dependencies not being available on PyPI e.g., proj, udunits2 etc.
However, we now host pyke as scitools-pyke on PyPI (but the hope is to purge pyke as technical debt ASAP :pray:).
This PR introduces the pyproject.toml file to support PEP517 and PEP518 building during installation, thus allowing the pyke rules for iris to be built when using pip - this wasn't possible before.
Note that, all the requirements/*.txt files in conjunction with the setup.py file service installation of scitools-iris and it's extras, namely [all], [docs], and [test], pretty much as before.

This is awesome + long overdue.
Right off the top of the head, a few general points arising for me...

as the account here is so good, can we document it somehow ?
we need to be clearer about the categories.

core/setup/test/docs are all good,
"extensions" was always peculiar.
But what is "all" for ??

do we really have to have multiple files for python versions?? yuk.

@pp-mo Yeah, I've been meaning to do this for a long, long time... but just never got around to it, but glad I finally did :tada:
I agree with everything in your comment above :+1:
This definitely should be documented and it will. I've left this for @tkknight to do as a follow up task, as he's totally swarming all over the documentation (mucho :heart:), and this PR unblocks him. I suspect that my description detail above may serve as  a strawman to some developer notes in the follow-up PR.
Also, yeah, having the py36.yml and py37.yml is a slight pimple on the princess, but other projects do also take this approach e.g., see here.
To be honest, I'm willing to live with this and it does give us the scope to have dependencies per Python version, and we can maintain those dependencies historically going forwards, which wasn't possible before... so there are benefits, and at the end of the day I think I can see past the :nauseated_face: if you can?

Hey @bjlittle.  Here is the PR (https://github.com/SciTools/iris/pull/3817) to bring the documentation inline with this PR.  It will be in draft until this PR is merged.

@pp-mo Also, I'm keen that we use conda env create rather than conda create, as it's opinionated in terms of naming the environment and the channel that it pulls from, plus it's a very simple instruction to the user/developer, see #3817

I'm happy to merge this now.  Any last comments @pp-mo ?

@tkknight I'm happy to merge this now. Any last comments @pp-mo ?

No, after some thought I'm :+1:


VMware vSphere PowerCLI 6.0 R3 no longer available from VMware/Broadcom

Since Broadcom revamped VMware's support site, PowerCLI 6.0 R3 is no longer available for download.  Does the Site Recovery Deployment Planner for VMware to Azure support any other versions of PowerCLI, or is there any plan to add compatibility with current versions of PowerCLI?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aa9a9a9e-e47f-2c35-752e-4d026f0fca93
Version Independent ID: c23d2cb9-c2d0-505c-5a58-53074fcd373b
Content: Azure Site Recovery Deployment Planner for VMware disaster recovery - Azure Site Recovery
Content Source: articles/site-recovery/site-recovery-deployment-planner.md
Service: site-recovery
GitHub Login: @ankitaduttaMSFT
Microsoft Alias: ankitadutta

@BrianCran
Thanks for your feedback! We will investigate and update as appropriate.

@BrianCran, thank you for sharing this feedback.
@ankitaduttaMSFT, could you please review this feedback and share your thoughts, Thank you

Running into the same issue now. Without compatibility with other versions of PowerCLI, the deployment planner is effectively bricked and there's no way to assess VMware to Azure DR.

Through sheer luck, after running into this exact problem myself just today, I happened to stumble into the installer for the exact 6.0 version needed on an old file share our company has.  The file has been there for over 9 years!  If anyone should need the 6.0 installer, I could upload it somewhere if you have a specific location.

That would be amazing if you are willing to share it!   Someone may have a better or more permanent way to share, maybe even attaching to a comment in this thread if that is possible, but otherwise, I created a shared folder in Google Drive here: https://drive.google.com/drive/folders/1RpWNkQxiHifCriU4sXhyOtwskXCIdjhb

It's been uploaded!

Came across #123291 and there's a download link for a new version of the planner that shouldn't have this dependency anymore.
Link: https://download.microsoft.com/download/6/5/d/65d39a90-c4e2-49a7-9149-af58deb8ef7d/ASRDeploymentPlanner-v3.0.zip

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine GitHubanother possible update to our documentation, please don't hesitate to reach out again. #please-close


Tolerate extensions appearing twice in extension list

If an extension name appears twice in the extension list then the context always fails to create.
How do you get an extension appearing twice in the extension list? I found it would happen when running through apitrace (https://github.com/apitrace/apitrace).
However, if your OpenGL implementation already advertised any of those extensions, that extension will now be in the list twice.

The code is more robust now. If any GL implementation advertise the same extension mote than one time, no exception is thrown.


The outer product of matrix in 3D.

This is the operation of the outer product of matrices in dimension 3. For example in this test, we have a 2D matrix and another 3D one which we make the outer product

I see only a test, no code.


Some tips I can't understand what these mean

When I type in the code Tabnine its works well, but I don't understand some of the message below the prompt.
Type TabNine::sem to enable semantic completion for Python. This will run the flollowing commands: pip install python-language-server pyls Type TabNine::no_sem  to suppress this message To learn more.................
It seems that I haven't finished some settings, but I don't know how to solve this problem. And I don't know where I should type my pip instructions.
Could you give me some advice?
Thank you.

You can type TabNine::sem and TabNine will run the commands for you. The message is just so that people know that TabNine is going to install something.


FlowRouter.go() Only Changes URL

I am using FlowRouter.go('/'); inside of a react component:
componentWillMount() {
 FlowRouter.go('/');
}

Only the url changes but not the html body. How to properly do this?

This is a bug in the current flow router. Do it inside a setTimeout().
This is fixed in the kadira:flow-router-ssrversion.

Thanks mate!


Fixed peer generation

This change is

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

src/android/java/io/jxcore/node/JXcoreExtension.java, line 517 at r1 (raw file):
Previously, larryonoff (larryonoff) wrote…
is it valid calling one method twice ? what about just cache value and check cached value?

It's okay. It is just getting int via getter. We don't need one more variable. If talk about performance, current solutions consumes less memory

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

PR is added to the queue for testing as 2. task. (e1b00a5)

Test 98312760 (e1b00a5) build started.

Test 98312760 (e1b00a5) build started.

Test (Success) 98312760 build is completed (e1b00a5)
See https://github.com/ThaliTester/TestResults/tree/98312760e1b00a5_Fixed_peer_generation_evabishchevich/ for the logs

Test 98312760e1b00a5(e1b00a5) has failed
See https://github.com/ThaliTester/TestResults/tree/98312760e1b00a5_Fixed_peer_generation_evabishchevich/ for the fail logs

PR is added to the queue for testing as 2. task. (b2c4df9)

Test 98312760 (b2c4df9) build started.

Test (Success) 98312760 build is completed (b2c4df9)
See https://github.com/ThaliTester/TestResults/tree/98312760b2c4df9_Fixed_peer_generation_evabishchevich/ for the logs

Test 98312760b2c4df9(b2c4df9) has failed
See https://github.com/ThaliTester/TestResults/tree/98312760b2c4df9_Fixed_peer_generation_evabishchevich/ for the fail logs

@yaronyg There are CI issues, not the code problems. I'm going to merge this PR


Missing dependency in v2.0.0 release

Describe the bug
The package depends on deprecation but doesn't specify it as a dependency.
To Reproduce
Steps to reproduce the behaviour:

install the package
attempt to use it (see logs below)

Expected behavior
Functional dependencies to be specified on install of the package.
Logs or Screenshots
# python -m virtualenv python-sdk-2.0
created virtual environment CPython3.12.2.final.0-64 in 220ms
  creator CPython3Posix(dest=/Users/yaleman/Projects/python-sdk-2.0, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, via=copy, app_data_dir=/Users/yaleman/Library/Application Support/virtualenv)
    added seed packages: pip==24.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

# source python-sdk-2.0/bin/activate
# which python
./python-sdk-2.0/bin/python

# pip install splunk-sdk
Collecting splunk-sdk
  Downloading splunk-sdk-2.0.0.tar.gz (99 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 99.4/99.4 kB 2.2 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: splunk-sdk
  Building wheel for splunk-sdk (pyproject.toml) ... done
  Created wheel for splunk-sdk: filename=splunk_sdk-2.0.0-py3-none-any.whl size=115450 sha256=7f0d3badeb3f01f4fe8926914404b7db8a8cba717719da149bcff0090eacdb52
  Stored in directory: ~/Library/Caches/pip/wheels/ae/55/6e/a00a84c54550ff94208060e44889ea333fa834a1e6ff33f40e
Successfully built splunk-sdk
Installing collected packages: splunk-sdk
Successfully installed splunk-sdk-2.0.0

# python
Python 3.12.2 (main, Mar  7 2024, 16:38:23) [Clang 15.0.0 (clang-15<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import splunklib.results
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/yaleman/Projects/python-sdk-2.0/lib/python3.12/site-packages/splunklib/results.py", line 49, in <module>
    import deprecation
ModuleNotFoundError: No module named 'deprecation'

Splunk (please complete the following information):
n/1
SDK (please complete the following information):

Version: 2.0.0
Language Runtime Version: python 3.x
OS: any

Additional context
The tox tests explicitly install the dependencies, but this shouldn't be required, as the install_requires option should be used in setuptools.
This is the only non-core-python dependency required by the package.

2.0.1 was released today with the update from the above PR.

When I try to:
from splunklib.results import ResultsReader
in my modular input (I need splunk to connect and get data from antoer splunk via api)
i get error like:
Traceback (most recent call last):   File "../etc/apps/show_activity_analyser/bin/get_audit_GDI.py", line 9, in <module>     from splunklib.results import ResultsReader   File "../etc/apps/show_activity_analyser/bin/../lib/splunklib/results.py", line 49, in <module>     import deprecation ModuleNotFoundError: No module named 'deprecation' <stderr> Introspecting scheme=get_audit_GDI:  Traceback (most recent call last): <stderr> Introspecting scheme=get_audit_GDI:    File "/Users/pmotloch/Applications/splunk/etc/apps/show_activity_analyser/bin/get_audit_GDI.py", line 9, in <module> <stderr> Introspecting scheme=get_audit_GDI:      from splunklib.results import ResultsReader <stderr> Introspecting scheme=get_audit_GDI:    File "/Users/pmotloch/Applications/splunk/etc/apps/show_activity_analyser/bin/../lib/splunklib/results.py", line 49, in <module> <stderr> Introspecting scheme=get_audit_GDI:      import deprecation <stderr> Introspecting scheme=get_audit_GDI:  ModuleNotFoundError: No module named 'deprecation' Introspecting scheme=get_audit_GDI: script running failed (exited with code 1).
@yaleman 100% sure its fixed? Or do you think my error is unrelated?

That sure does look like you're running an old version

i know. That's why i think I'm missing sth "easy". But when I look into my changelog.md:
# Splunk Enterprise SDK for Python Changelog

## Version 2.0.2

### Minor changes
* Added six.py file back

Try:
import splunklib
print(splunklib.version)
dir(splunklib)
sorry I'm on mobile. Maybe your code is using a cached version somewhere

i know. That's why i think I'm missing sth "easy".

The only other thing I could really suggest is installing the missing package or commenting out the offending code. There's no easy wins when there's a missing dependency.


fix(settings): use elevated token when revoking all tokens

https://aptible.slack.com/archives/C05CMUW3LHX/p1707462063586959

I tested this PR and it worked as expected.

Login to CLI with password
aptible apps works
Login to UI with SSO
Elevate into security settings
Revoke all tokens
aptible apps reports the token was revoked

I tested it on main to confirm I was able to reproduce the issue and was able to do so.


Add SDK version docs update to release template

Just a note that we shouldn't really have that version in the main docs (also not needed for JVM SDKs). The latest version attribute is automatically written when publishing the docs:
https://github.com/lightbend/kalix-javascript-sdk/blob/9edd876821f128aa9f1950def45873896190a0e3/docs/Makefile#L31-L32
Would be better to use that one, rather than a manually managed version. May still be there because of the JS quickstarts being in the main docs rather than in the SDK docs.


Feat: Bump Go version to v1.17 and upgrade the dependency k8s libs

Signed-off-by: Jianbo Sun<EMAIL_ADDRESS>Description of your changes

Fixes #
I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

closing as https://github.com/kubevela/kubevela/pull/3776 merged


Calliope: wrong error handling for some sensors in simulation

When you try to execute a program with the ultrasonic sensor in the simulation you get the following:

expected behaviour

As the configuration is still hidden (not present) it is not clear why we have a checker for this (at the wrong place)

Please check all sensors for calliope!

Currently in progress by a GCI student.

Has been resolved by a GCI student.


Improve/scale block type selection UX

Once #38 is done.. The current block selection UX is not gonna cut it.
I'm thinking to display the selected block type on the left hand instead of the word "Menu" and using the left-right stick to change between block types. Have to do some testing.. but I think something like that could scale to a larger number of block types.

[x] Send blocktypes from servers to the clients on the INIT event.
[x] Move atlas loading out of voxels class into the world class so it can be also used by this UI
[x] Implement block selection UI in the client

Once #38 is done.. The current block selection UX is not gonna cut it.
I'm thinking to display the selected block type on the left hand instead of the word "Menu" and using the left-right stick to change between block types. Have to do some testing.. but I think something like that could scale to a larger number of block types.

[x] Send blocktypes from servers to the clients on the INIT event.
[x] Move atlas loading out of voxels class into the world class so it can be also used by this UI
[x] Implement block selection UI in the client


SponsorLink must NEVER be obfuscated

Describe the Bug
SponsolLink is embedded as obfuscated DLL within packages like any virus would be.
Steps to Reproduce
Look into any SponsorLink package available
Expected Behavior
A security official in a company can review the decompiled) source of suspicious looking network traffic and review the packages to rule out leak of secrets, API keys or internectual properties.
Version Info
Every version available

It's OSS now. It won't be obfuscated in any future versions. And the current versions in nuget.org will be updated soon. The published (formerly obfuscated binary) comes from this same source code.

Fixed in https://www.nuget.org/packages/Devlooped.SponsorLink/1.1.0


Support for building wheel

Considering difficulty to build this with commercial compilers (PGI, Intel) and built time issues reported in  #260, it will be great if we could just have wheel for this project.
We already have setup.py for this project. I wonder how much effort it will be to build the wheel for this project.
@ferdonline : when time permit in coming weeks, may be we could evaluate this?

@alexsavulescu : not priority but something to get familiar with this tool and also grab some of the @ferdonline's expertise on this topic.

@cattabiani and I will take a stab at this.
a few things I had in mind:

Cleanup build system to have only the setup.py and the CMakeLists.txt for everything building related.
Building of the code should be done either through cmake, or through the setup.py depending on whether you’re going the spack way or if you want to create a wheel to install via pypi
Documentation building should only be done through setup.py
testing should be removed from setup.py and it should be run only via CMakeLists.txt and that should include both the c++ and the pytests

To simplify cmake building from python we will try scikit-build:
https://scikit-build.readthedocs.io/en/latest/

Just a note : in addition to wheel, typically we need to copy binary to .data directory as we do in NEURON and use shim to launch exe. I wonder if this is not needed as we built static libraries/binaries in NMODL. @ferdonline knows all details of NEURON implementation.

Implemented!


Friendly Date ranges: test cases not displaying

Issue Description
When submitting answer for Friendly Date Range test cases do not display completely. They are cut off by the window. See attached.

Browser Information
FireFox (latest version) Ubuntu 14.04
Code
not relevant. Can be reproduced by submitting the starter code.

Thanks for the issue @jstoebel
Can you tell us your screen size (resolution) as well? May be relevant for anyone looking into this.
/cc @hallaathrad

1366 X 768

Somewhat related to #8390. As I suggested with the Pig Latin challenge, a quick fix would be to change the function name.
Also, is this still a problem? Or is it maybe browser specific? I wasn't able to reproduce this now with Chrome and Safari on a Mac.

Can't reproduce on Chrome, Firefox, and Edge on Windows 10 either.
Has to be Firefox and Ubuntu as per Original Post.

I could reproduce it using Ubuntu 16.04 with a 1360 x 768 resolution. With 1920x1080 the dates are fully rendered.

We've removed this challenge completely so I'm closing this issue.


[BUG] Json template renderer does not work

I am trying to render the following type: https://github.com/IgnisDa/ryot/blob/c790c07c4d64782fda94328e4d9ff57334d1c4c7/apps/backend/src/models.rs#L120.
   let mut generator = SchemaGenerator::default();
        generator.add::<CompleteExport>();
        generator
            .generate(
                base_dir.join("export-schema.json"),
                TemplateRenderer::new_format(Format::Json),
            )
            .unwrap();
    }

Here is what the rendered type is:
{
  // Data about user's measurements.
  "measurements": [],

  // Data about user's media.
  "media": [],

  // Data about user's people.
  "people": [],

  // Data about user's workouts.
  "workouts": [],
}

That is, the types are not rendered recursively.

@IgnisDa Can you add an example of what you want? Since there's "no data" for the array, it's basically empty and has nothing to render. I can maybe add an option that forces it to render like 1 item that matches the struct.

@IgnisDa Try this: https://moonrepo.github.io/schematic/schema/generator/template.html#field-expansion

@milesj this works for my use case. Thanks. Can be closed.

Sweet


[CAP 35] Improve integration test coverage

Right now we only have happy-path coverage (and for SetTrustlineFlags we still need to test the details and effects).
We should add more tests, for instance, the tests suggested by @leighmcculloch at https://github.com/stellar/go/pull/3368#discussion_r562827974
Part of #3348

From reading the comment on #3368, and cap35, the list of extra potential tests I have is below. Not sure we need to hit all of these, as a lot should be handled by core.
Happy path

[ ] Claiming back a partial amount.

Sad Path

[ ] enabling and disabling it (tested implicitly by below?)

[ ] trying to set AUTH_CLAWBACK_ENABLED_FLAG after trustline created

[ ] set options should fail to set clawback enabled when not revocable
[ ] low threshold signature
[ ] negative amount
[ ] from == issuer

[ ] Shouldn't be able to clawback yourself/

[ ] invalid asset
[ ] claimable balance

[ ] already claimed
[ ] already cancelled?
[ ] source account not clawbackable
[ ] source account not allowed to clawback
[ ] source account is not issuer
[ ] created when clawback not enabled on issuer account, then clawback
enabled on issuer account after. should still fail.
[ ] can't clawback it twice.

[ ] accounts

[ ] clawback not enabled on from account
[ ] clawback not enabled on issuer account
[ ] clawback enabled, but revocable not enalbed
[ ] trustline source != issuer (Is this a scenario?)
[ ] clawback should still work when holder is unauthorized
[ ] clawback should still work when holder is authorized_to_maintain_liabilities
[ ] from account has no trustline for asset
[ ] from account does not hold asset
[ ] from account insufficient funds
[ ] from account sufficient funds including selling liabilities

[ ] should fail unless issuer deauthorizes/reauthorizes the from account
[ ] deauthorize/reauthorize should work

Per discussion, for stuff where it is behaviour around core, it makes more sense to maybe sanity-check the error response gets generated correctly, and the horizon state is in the expected state. Possibly a table-driven test makes sense here.


ScreenshotPlugin: Fix taking hunter level screenshots

Fixes #2485

This won't work after all, use the loadWidgets event


[DEP][SP] Move common functions to utils.js and include it in samples

BUG=XWALK-6342

@jondong @huningxin Please help to review. I can't verify the changes in DEP, because DEP is not work in my ENV. I tried the newst master branch. @jondong Please help to check, Thanks!

@DonnaWuDongxia , you may miss the "utils.js" file.

@DonnaWuDongxia your patch won't work for me cause you've missed the utils.js.

@huningxin @jondong updated, thanks!

@DonnaWuDongxia Patch verified and it works fine for me. LGTM as soon as you fixed the CRLF issue of utils.js.

@jondong Good capture, how can you found it? It shows no different by git diff.

@jondong updated. I removed them using tr in cygwin.

LGTM. merging.


CLI arguments to configure Cassandra datastore

Implementing the following arguments in the CLI to override the kong.yml datastore configuration:

[ ] --cassandra-hosts
[ ] --cassandra-port
[ ] --cassandra-keyspace
[ ] --cassandra-timeout
[ ] --cassandra-keepalive

Maybe this issue should be renamed to "Allow to override any configuration property through CLI arguments" (not just cassandra properties)

I don't like the idea. it makes things complicated for nothing. Updating your config will be faster than writing a command with 20 char arguments.

Sometimes the config is generated automatically, or needs to be edited automatically, so the only alternative is updating it using regex and sed, which is not easy. Appending CLI arguments provides a way for better automation.

Don't see that happening, way too much of a hassle, way too many (and too long) arguments for that to be included in the CLI.


mint::Mesh unnecessarily requires coordinate arrays to be 2D (Nx1) arrays

There may be a real reason for the requirement, but it is in excess of the Blueprint mesh convention.  The requirement may be related to storing the 1D arrays in MCArray, which is deprecated.  Maybe we should store them as axom::Array and remove the 2D requirement.  That is, if the change doesn't break anything.

MR https://github.com/LLNL/axom/pull/1459 adds reshaping to sidre::View, so we can reshape the data to satisfy the mint::Mesh requirement.  However, we may still want to consider removing the requirement if it is outdated.


Near real-time data quality alerts

Find out as soon as a processing issue occurs in your pipeline by setting up data quality alerting. Opt-in to receive these alerts by navigating to Pipeline Configuration in Insights Console.

This is now live: https://snowplowanalytics.com/blog/2020/12/07/monitor-and-manage-data-quality-in-real-time/


Update codevar extension

Description

Screencast

Checklist

[ ] I read the extension guidelines
[ ] I read the documentation about publishing
[ ] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
Could you look into the lining errors 😊
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

Do you want to continue @dnf5320


DDC subtype check optimization now has a proven counter example

There are edge cases where it looks like DDC will return the wrong result from a subtype check based on this
https://github.com/dart-lang/sdk/blob/0dd6ea13540588a0c8becc7db58019f0fb00c254/sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/types.dart#L896-L902
@fishythefish found a counter example to the conjecture that code was based on and it should be removed. See counter example in https://github.com/dart-lang/language/blob/master/resources/type-system/subtyping.md.

FWIW, I think all of our implementations have this bug. Consider the following program:
import 'dart:async';

class A implements Future<Future<A>> {
  // Ignore missing implementation
  @override
  noSuchMethod(Invocation invocation) {}
}

void main() {
  List<A> as = [];
  List<FutureOr<A>> foas = [];
  print(as is List<Future<A>>);
  print(foas is List<FutureOr<Future<A>>>);
}

This should print
false
true

since with B := Future<A>, we have A </: B but FutureOr<A> <: FutureOr<B>.
However, we produce
false
false

since all the implementations seem to perform the same bad optimization and reduce the check FutureOr<A> <: FutureOr<B> to A <: B.
We should probably file issues against all of the offenders.

https://dart-review.googlesource.com/c/sdk/+/121653/ should add language_2/future_or_subtype_test, which will exercise this behavior. I'll file bugs against backends when it lands. I could write up a fix for dart2js, but enough of the subtyping logic would have to be restructured that I'm just going to kick it down the road until I fully rewrite the subtyping algorithm for NNBD.

Okay, the test landed, and we have tracking issues:

#38904 (Analyzer)
#38905 (CFE)
#38906 (VM)
#38907 (dart2js)


Reassignment/swapping of borrowed variables

Here are a couple of example programs that fail type-checking at the moment:
@guppy
def foo(q: qubit) -> None:
  measure(q)
  q = qubit()

@guppy
def bar(q1: qubit, q2: qubit, a: angle, b: bool) -> None:
  if b:
    q1, q2 = q2, q1
  h(q1)
  rz(q2)
  cx(q1, q2)

One way would be if we had an intrinsic swap(q1: qubit, q2: qubit) -> None:
@guppy
def foo(q: qubit) -> None:
  q2 = qubit()
  swap(q,q2) # newly-allocated qubit is now in `q`
  measure(q2)

@guppy
def bar(q1: qubit, q2: qubit, a: angle, b: bool) -> None:
  if b:
    swap(q1, q2)
  h(q1)
  rz(q2)
  cx(q1, q2)

The foo here is a bit awkward - this is akin to Rust std::swap on &muts - but perhaps OK.
bar seems fine, but supposes that the swap of q1,q2 should be propagated back to the caller - which makes sense if we realize that borrowing is actually transfer of ownership and back again from the same variable. If we didn't want to do this, we might try:
@guppy(module)
def bar2(q1: qubit, q2: qubit, a: angle, b: bool) -> None:
        (r1, r2) = (q1,q2) if b else (q2, q1)
        h(r1)
        rz(r2, a)
        cx(r1, r2)

but this won't compile - you'd have to refactor into an inner function:
@guppy(module)
def test(q1: qubit, q2: qubit, a: angle, b: bool) -> None:
    def inner(r1: qubit, r2: qubit, a: angle) -> None:
        h(r1)
        rz(r2, a)
        cx(r1, r2)
    if b:
        inner(q1, q2, a)
    else:
        inner(q2, q1, a)

Which works ok. (One could imagine def inner(t: tuple[qubit, qubit], a: angle) and then calling inner((q1,q2) if b else (q2,q1),a) but I'm not sure whether that works, haven't figured out how to use tuples yet.)
A further enhancement would thus be to allow variables r1,r2 in bar2 above to borrow q1/q2, i.e., for borrowing to occur over the lifetime of a local variable (i.e. a section of the CFG) rather than only/always over the lifetime of a function call. This would (significantly) complicate the checker and perhaps also require new syntax, however (in some sense equivalent to defining that local function but without the possibility of indirect call). For discussion, perhaps something like
with ((q1, q2) if b else (q2, q1)) as (r1,r2): # Univariate `with (q1 if b else q2)` straightforward, but tuples??
  h(r1)
  rz(r2, a)
  cx(r1, r2)
# r1,r2 now gone (out-of-scope/consumed); q1,q2 restored

Note the swap version (where the caller sees the qubits being swapped too) is straightforward via the quantum_functional interface: for example:
    def test(q1: qubit @owned, q2: qubit @owned, a: angle, b:bool) -> tuple[qubit, qubit]:
        (r1,r2) = (q1,q2) if b else (q2, q1) # Renaming to r1/r2 only for clarity, no need to
        r1 = h(r1)
        r2 = rz(r2, a)
        return cx(r1, r2)

so as an alternative to swap one might consider ways of calling into quantum_functional from the "inout" world (the other way around being easy)

Specific follow up for swapping: https://github.com/CQCL/guppylang/issues/652

Increasingly I feel that we need to do variable tracking differently. In particular, whereas for non-inout variables we model assignment as SSA form, if we allowed assigning to an inout variable to mean, the new value will be returned instead ('coz that's all inout means - there is no magic here, it's just an extra return value), then we'd enable things like x,y = y,x and all the more-general forms of swap....

So I've been wondering about something like
def swap3(x: L @in, y: L @in, z: L @in, permutation: usize) -> (L @out, L @out, L @out)
   if foo(permutation):
      return (y,z,x)
   elif bar(permutation):
      return (z,y,x)
   ....

(not sure if the @out is legal syntax, and I'm sure one would come up with something better than permutation: usize!)
i.e. we require the @ins to match the @outs in number and type; the body of swap3 is written in normal functional style; and then you can call it as if it were def swap3(x: L @inout, y: L @inout, z: L @inout) -> None.
However, this puts more work on the callee, and is thus less generable/reusable over @owned/pure-functional functions that were not written with this in mind, than the approach of having some syntax at the callsite allowing ` pure-functional function to "borrow" some values. (Which I still like, but might be a separate issue to improving variable tracking as per previous comment)


Unlink some fields from airtable

I've noticed that the table CrawlResults contains a link to Companies. There should be NO direct link because "Company" should be inherited via "Reporting Period". If there is a direct link, there can be inconsistency between the Company of the Reporting Period that a Result is linked to and the direct link to a Company. I don't remember if I created this direct link, but please do not use it in the frontend. To determine which Company a crawled result belongs to, look up the respective Company of the linked Reporting Period. If there is not field containing the Company name in the Reporting Period table and you need one, feel free to create one and add the Column descrpition that it's from you used in frontend.


Add info about DummyClassifier strategy='stratified'

closes #450
Added text to expand explanation on DummyClassifier strategy='stratified'.
Added loop to show the effect of the random prediction made with this strategy and compare it with the deterministic nature of strategy='most_frequent'.

I would rather like to simplify it by removing the end "Notice that the most_frequent strategy is deterministic for a given..."

Does that mean removing from there on, or is it worth keeping the final plot?

Let's wait for the build to complete to check the HTML rendering and then merge.


ocamlPackages.mccs: 1.1+17 -> 1.1+18

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AltGr/ocaml-mccs/releases.
meta.description for ocamlPackages.mccs is: Library providing a multi criteria CUDF solver, part of MANCOOSI project
meta.homepage for ocamlPackages.mccs is: https://www.i3s.unice.fr/~cpjm/misc/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1+18 with grep in /nix/store/034zglmd2xxp7k5mm1szppx8dn6x03d9-ocaml5.1.1-mccs-1.1+18
found 1.1+18 in filename of file in /nix/store/034zglmd2xxp7k5mm1szppx8dn6x03d9-ocaml5.1.1-mccs-1.1+18

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/034zglmd2xxp7k5mm1szppx8dn6x03d9-ocaml5.1.1-mccs-1.1+18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.mccs https://github.com/r-ryantm/nixpkgs/archive/a4224ee84c60f76f3b923ae54370ba50a5a9c376.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a4224ee84c60f76f3b923ae54370ba50a5a9c376#ocamlPackages.mccs

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/034zglmd2xxp7k5mm1szppx8dn6x03d9-ocaml5.1.1-mccs-1.1+18
ls -la /nix/store/034zglmd2xxp7k5mm1szppx8dn6x03d9-ocaml5.1.1-mccs-1.1+18/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ocamlPackages.mccs

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg eval


Feature/pre commit

PR Info

Closes SeaQL/sea-orm/issues/591

Dependencies:

SeaQL/sea-orm/pull/611

Dependents:

Adds

Add pre-commit hooks to format and lint

Fixes

[ ]

Breaking Changes

[ ]

Changes

[ ]

Unfortunately I have not seen #611 before I created it (it was not linked in the issue). So now the project has to decide between pre-commit and vanilla bash/batch scripts.
In my opinion the main upside of using pre-commit over vanilla scripts is that it handles some corner cases, i.e. I have not staged everything, in that case one would expect the tools to only run on what is to be committed, and not the unstaged files. pre-commit handles this automatically, while vanilla hook scripts have to take additional steps to ensure the correct behaviour.

By the way I think I should add something along these lines to the documentation, I am not sure where, and it seems you have more thoughts on what should be done with this signoff discussion over in #611):
Be sure to install pre-commit for this repository by installing pre-comit on your system and enabling it for the repository:
pip install pre-commit       # install pre-commit on system
pre-commit install             # install pre-commit hooks for repo (run inside the repo folder)

Not changing https://github.com/SeaQL/sea-orm/blob/9c4cdd84a5a70def5e0ca375728ff631132eebbf/.github/workflows/rust.yml#L108 to workspace is not an oversight, while the docs state that all is an deprecated alias for workspace, cargo does not like workspace with fmt

Also is it intentional that the cargo pipeline does NOT run cargo clippy -- -D warnings (note the last part) I would expect that this way clippy is run but the output would be ignored?

Hey @maltevesper, thank you so much for the contributions! I think we better perform the clippy checking during CI checks, instead of putting the burden on developer's machine. We have tried  https://github.com/marketplace/actions/rust-clippy-check before but it turns out making the "file changes" tab in PR very messy and hard to review the changes. So, currently we will run clippy check and cargo fmt regularly before every release.

Hey @billy1624,
the wuestion is how would you suggest to proceed, issue #591 still stands as it is. IMHO having a precommit hook can be a big help, especially if several commits are done for a feature before it is fed to the pipeline. In my experience this leads to fixup commits at the end which are a bit out of place:
commit 1 / new feature
commit 2 / test for feature
...
commit 3 / fix formater issues
commit 4 / fix linter warnings
a pre commit script can help to reduce these low value commits (which only fix linter,formater thing). I know that there is interactive rebase & squasing. But not everyone does, and if a feature is implemented across multiple commits, this also tends to dirty the commit history, since it is hard to fixup linter bits on the right commits after the fact.
While I have amde negative experiences with this and use precommit as a tool to help reduce this, it might very well be that this is no problem in practice for sea-orm. Also, pre-commit can not replace the pipeline checks, since it depends on the user actually installing the hooks and not surpessing them with --no-verify.
That said, do you actually want to implement pre-commit hooks? If yes what should they do, so that I can adjust this PR? If no, I suggest you reject this PR and close the issue as wont fix. No hard feelings. I might potentially pick up another issue then.
One last note regarding running clippy on the dev machine: I figured every developer surely (should) compile check his changes, so most things should be cached by rust and the checks should be relativly fast anyways. But I might be wrong there, I  am only now moving to normal sized projects with rust, and had only toy projects before.

Hey @maltevesper, appreciate your thoughts and efforts! I think we can incorporate precommit hook in SeaORM to perform clippy and cargo-fmt checks but there are no guarantee developers would run it on their local machine. That's what holding me back.

Thoughts? @tyt2y3

Hi, I am on vacation but will have a look in a week. What should I do here? Last I checked there where still second thoughts.
I can resolve the mergeconflicts.
Regarding the second thoughts about pre commit hook vs pipeline: I think the pipeline should check everything, since contributers might not run precommit hooks. The job of the pre commit hook is to ensure people that use them that they dont have to create fixup commits.
That said, is there anything else you want the hook doing? Or is it a simple resolve mergeconflicts?
Final note git commit --no-check skips running (precommit) hooks in case you dont want to wait.

@billy1624 I attempted a rebase, I am a little bit surprised to run into:
Warning: can't set format_code_in_doc_comments = true, unstable features are only available in nightly channel.
Apparenlty you set that option 11 month ago, and I assume I am doing something wrong now when running rust-fmt. Can you enlighten me? (I assume running this with a nightly rust is not the right solution)

I don't think that's an error, that's only a warning, so you are good.
As a matter of fact, the nightly fmt differs the stable fmt so what I do these days is:
cargo +nightly fmt
cargo fmt

The reason nightly was introduced in the first place is we want to also format the code inside our doc tests.

Hey @maltevesper, sorry for the conflict. I think similar code has been merged

https://github.com/SeaQL/sea-orm/pull/840

Please check if you have anything to add.

Yeah the CI step works fine so far. Thanks


Django 1.9 and EmptyShortCircuit deprecated

Here's the commit where it's removed:
https://github.com/django/django/commit/4d3470e52e005ed75aa6c7d4204bf5ca87733f85

Will be closed by #133

Try the latest master and let me know if it works so we can close this and move on.

I'm a little worried about replacing EmptyShortCircuit with Exception ... what's it meant to be?

It's the best short term solution we can think of. Please test it and report any problems or suggest an alternative solution. Read #133 for more info.

It seems to be working fine although it seems pretty dirty. Any eta on updating pypi version?
Anyway. Instead of potentially hiding some process() issues by reraising a different exception in 1.9, it would be better to just do not catch anything there or at least reraise original exception.

Feel free to send a pull request with a solution you think works better.

Sure. But are there any chances of pushing what we got now to pypi any time soon? It may not be super pretty but it does the job.

@23doors I released 1.4.1 yesterday


image: strange behavior in DrawImage with too big image parts

Hmm? I don't remember what this bug is. :-P

I'll revisit this when I remember what this is.


3.0.0

I plan to introduce a few breaking changes to emojilib in order to contain the scope of this project. In short, this project should only be adding keywords to emoji, and nothing more. This means:

New emoji added to Unicode should come from muan/unicode-emoji-json, instead of manually added here. (#125, #126)
Use emoji sequence as identifier instead of made up emoji name, since they don't have official machine friendly names. (#131, #135,)
Both simplemap.json and ordered.json will be removed, since they have nothing to do with emoji keywords. They can be generated from muan/unicode-emoji-json if people want it.
Point main to JSON instead of a node interface.
Bonus: generate language based emoji-keyword mapping based on Unicode CLDR. (#12)

TODO:

[x] Generate new JSON based on Unicode data
[x] Create CLI for updating dataset

cc @jasonrudolph FYI

Nice! :zap:

Do I understand correctly that the new version will export a hash like?:
{
  "😀": {
    "keywords": ["face", "smile", "happy", "joy", ":D", "grin"],
    "name": "grinning",
    "fitzpatrick_scale": false,
    "category": "people"
  }
}

Is there an ETA on this work?

any news? Looking forward for this release 😀

Wondering what's blocking this?

Wondering what's blocking this?

My burnout state of mind unfortunately. :)

Do I understand correctly that the new version will export a hash like?:

Looks like this is where I left it: https://github.com/muan/emojilib/blob/e3b4c85f51bdd7ac635a6b80d20026c5ac89758f/dist/emoji-en-US.json#L2-L10
Looking back now though I can see how this is not desirable for existing consumers of this library, as they would need to pull in an alternate source for other emoji metadata (hence the MAJOR version bump).
IIRC, I made this decision because people often request features like "shortcode used for <github/discord/slack/etc> service", which I consider out of the scope of this project. To work around this they'd have to pull in other libraries that do this. This seems tedious, but given that the emoji dataset is gigantic and will only grow in the future, I feel like this is for the best.
I know there are the swiss army knife type of emoji data libraries out there. An ideal scenario would be that they pull this dataset in instead. I'd personally love to see a emoji module that let you build your own dataset.
buildEmojiData --fields character,keywords,unicodeVersion,githubCode --format json

Maybe this already exist, I don't know. But this is more than what I feel comfortable taking on.
So once this is merged, I imagine that I'll be doing something like this for my own use cases:
const emojiData = require('unicode-emoji-json') // https://github.com/muan/unicode-emoji-json/blob/master/data-by-emoji.json
const keywordData = require('emojilib') // needs a better name to clarify purpose

for (const emoji in emojiData) { // 😀
  const keywords = keywordData[emoji] // ["grinning_face","face","smile","happy","joy",":D","grin"]
  return html`<button data-keywords="${keywords.join(' ')}">${emoji} ${emojiData[emoji]['name']}</button>`
}

Any thoughts?

@muan I think your approach is the right one. I came to it naturally as well when I investigated the travesty that is this spec (https://twitter.com/jsumners79/status/1211105577188970497). Like you, I haven't had the time or constitution to get back to it. But my idea was to write a tool that will read all of the base spec files and mash them into something usable.

think your approach is the right one.

:+1:

write a tool that will read all of the base spec files and mash them into something usable.

muan/unicode-emoji-json does mostly that with 3 files already, but no CLDR:
https://github.com/muan/unicode-emoji-json/blob/2e9838abfc854890a155957b8ca5dff650f24de6/script/download-unicode-data.js#L10-L17

I think I was using CLDR to include skin tone variations.

Looking back now though I can see how this is not desirable for existing consumers of this library, as they would need to pull in an alternate source for other emoji metadata (hence the MAJOR version bump).

This makes sense, and it's already what I'm doing. I also saw that Emoji Mart is doing the same. A good source for normal emoji metadata (no keywords) we both used is emoji-data.

Apologies for the delay. Here's the new dataset..

Apologies for the delay. Here's the new dataset..


apps_ui.c: Correct password prompt for ui_method and handling of empty password

Since #4930 has been stalled for long and it had grown into several topics that can be handled independently
I've started doing so with this PR, containing improvements to apps_ui.c.

@levitte, the comments by you and @slontis have been handled some 5 weeks ago.
Can you approve this now?

Ping for OTC approval

Merged - thanks for the comments


Can we send batch/bulk events at once

Hi,
I am looking to integrate the node js sdk and want to push bulk/batch events async,
Is there a function to do that ?

Hi @astar10239, thanks for submitting a question. This is possible, not through a function but a configuration. To do this, initialize amplitude client with the uploadIntervalInSec configuration.
Amplitude.init(<API_KEY>, {
  uploadIntervalInSec: 10,
);

The example configuration above allows amplitude client to send in 10 second intervals, allowing for bulk/batch event payload.


Map Emoji selector keyboard key to another key

Description of the new feature / enhancement
Some Microsoft keyboards have Emoji and Office keys between the Space and CTRL keys. Ideally these low use keys could be mapped to other keys like the Apps/Menu key
Scenario when this would be used?
On most keyboards the Apps/Menu key is between the Space and right CTRL keys - very useful for displaying context menus on applications.
Supporting information
No response

For me, the "Apps/Menu" key is in the list of selectable keys, but I believe the list is "built" based on the keyboard/layout.
Having that said, KBM module/UI is in dire need for a big update, so this might be included when the time comes. See #2027

More context - the keyboard has an Apps/Menu key awkwardly between left CTRL and the Windows key. When this key is enabled "Microsoft Mouse and Keyboard Center" software allows assigning the emoji key to Apps/Menu as well.
However if the Apps/Menu key is disabled in "Microsoft Mouse and Keyboard Center" to prevent accidental press instead of Windows key, the emoji key is disabled as well.
Microsoft Ergonomic Keyboard: https://www.microsoft.com/en-my/accessories/products/keyboards/microsoft-ergonomic-keyboard?activetab=overview%3Aprimaryr2

The other way to open the Emoji window is by pressing either Win+. or Win+;. Maybe you can use those as "input" in Keyboard Manager?

@kinjiru have you tried with 0.59?  We should be able to do at least the office key which makes me believe the emoji key as well.  These may actually be deemed shortcuts vs keys /needinfo

WIth PowerToys 0.59.1:
Attempting to remap the office key > shows Win (Left) when the office key is pressed so affects usage of the Windows key.
If I disable the Apps Menu key (between left CTRL and Windows keys) in Microsoft Mouse and Keyboard Center,

and in Microsoft Mouser and Keyboard Center set the "Emoji Key Settings" to "Emoji selector (default)", then try to remap the emoji key it says the Key Pressed is "Space", so remaps the space key instead of emoji key.
and in Microsoft Mouser and Keyboard Center set the "Emoji Key Settings" to "Application Key", then try to remap the emoji key it says the Key Pressed is Apps/Menu, which cannot be remapped to itself.

With the Apps/Menu key disabled in Microsoft Mouse and Keyboard Center , if I press the emoji key in any application a PowerToys notification pops up saying "key disabled".
Hope it makes sense.

Attempting to remap the office key > shows Win (Left) when the office key is pressed so affects usage of the Windows key.

Note that the part "Remap a key" only accepts one key at a time. The thing is, this (physical) Office Key sends Win+Ctrl+Shift+Alt, so you need "Remap a shortcut" to see/catch this.

Trying to remap Win+Ctrl+Shift+Alt results in message "Some of the shortcuts could not be remapped".
ps. How/where do you find the key combinations sent by the physical keys?

Trying to remap Win+Ctrl+Shift+Alt results in message "Some of the shortcuts could not be remapped".

That's a limitation for Keyboard manager: it needs one or more modifiers and one or more "normal" keys.

ps. How/where do you find the key combinations sent by the physical keys?

Go to "remap a shortcut" and open the input by clicking the Type button. Then press a few keys.

Yes, if you are referring to "Microsoft Mouse and Keyboard Center" - as mentioned above (https://github.com/microsoft/PowerToys/issues/18576#issuecomment-1164903656)

Unless there are any further ideas or development on this issue happy for it to be closed.
Will live with it or replace keyboard.

/dup #14328


Problem getting correct DotNetCore version

I tried to get this challenge to work on my Mac but there seems to be issues with El Capitan and the dotnet tool chain per many hits on Google. So in order to get a stable environment to attend future meetups I installed Ubuntu 16.10 on a VM.
When I get to the part to" dotnet run ../assets/sample-adventure.json" I get this error message:
The specified framework 'Microsoft.NETCore.App', version '1.0.5' was not found.

Check application dependencies and target a framework version installed at:
/usr/share/dotnet/shared/Microsoft.NETCore.App
The following versions are installed:
1.1.1
1.1.2
Alternatively, install the framework version '1.0.5'.

Sooo.... I started by installing version 1.1.2 most current and then 1.1.1 but as shown above I need to either specifically download 1.0.5 (which is only available on Ubuntu 16.04 I think) or modify code base. I will try to download 1.0.5 on Ubuntu 16.10 and if that doesn't work I will have to start from scratch with a 16.04 Ubuntu. I believe that the code base could be changed to use a newer dotnet core but I would have to learn a lot of stuff I think before I attempt that.
Any suggested are welcome. Especially to help me understand how to prepare with correct setup for future Lambda Sharp meetups.
Thanks,
Carl<EMAIL_ADDRESS>

Hi Carl,
I'm running OSX El Capitan as well. You should have no problems with.
Let's see if we can figure this out. First, you have to make sure you install .NET Core 1.0.x. In newer, installers, it's included with the 1.1.x releases. 1.0.x is the Long Term Stable release and is the only version supported by AWS until 2.0 gets an LTS release.
Second, check if you installed mono or a preview release of .NET Core in the past. These can mess up your environment path and cause confusion.
Hope, this helps. If not, I'm happy to assist with getting it figured out since it should just work on OSX.

I ran a script that supposedly removed all previous .net core versions - I will run it again to be sure.
I will have to see if I ever installed mono and I will revolve it if I have.
It would help if you could send me any command line stuff that checks if I have the proper tools and versions - such as:
$ dot not
$ dot net —version
$ aws  cli --version
$ pip —version
$ python —version
...
This is a pretty involved dependency stack so knowing what the correct version for each piece might be important.
I think you are indicating that I need to install the stable release - not the newest release - so I will try that.
I have installed CentOS 7 in VM in Virtualbox and I will try yo get that working regardless if I get it to work on OS X El Capitan.
I think it would be a good idea to create an EC2 template specific to Lambda # so that everyone can just create an EC2 instance in their account based on this template - I will look into that as well.
Best,
Carl
“Quick to smile, slow to frown, brighter day everyone"

On Jun 26, 2017, at 7:18 AM, Steve Bjorg<EMAIL_ADDRESS>wrote:
Hi Carl,
I'm running OSX El Capitan as well. You should have no problems with.
Let's see if we can figure this out. First, you have to make sure you install .NET Core 1.0.x. In newer, installers, it's included with the 1.1.x releases. 1.0.x is the Long Term Stable release and is the only version supported by AWS until 2.0 gets an LTS release.
Second, check if you installed mono or a preview release of .NET Core in the past. These can mess up your environment path and cause confusion.
Hope, this helps. If not, I'm happy to assist with getting it figured out since it should just work on OSX.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/LambdaSharp/June2017-AdventureBot/issues/3#issuecomment-311072772, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRRJTl9HrVFVdoBo4ZAHvgqtWEJ1fctks5sH72sgaJpZM4OENKx.

The EC2 instance is not a bad idea, but it would prevent running an IDE like VS Code to do the work.
If you've installed .NET Core in the past, it's likely you have some lingering garbage sitting around. I know I did and it gave me quite a bit of grief to get rid of it. However, since then, I've found the tooling to be quite solid.
To clarify, if you install .NET Core 1.1 on OSX, it will also install .NET Core 1.0 since its the LTS version.
Here's my tooling info. Hope it helps!
~> dotnet

Microsoft .NET Core Shared Framework Host

  Version  : 1.1.0
  Build    : 928f77c4bc3f49d892459992fb6e1d5542cb5e86

Usage: dotnet [common-options] [[options] path-to-application]

Common Options:
  --help                           Display .NET Core Shared Framework Host help.
  --version                        Display .NET Core Shared Framework Host version.

Options:
  --fx-version <version>           Version of the installed Shared Framework to use to run the application.
  --additionalprobingpath <path>   Path containing probing policy and assemblies to probe for.

Path to Application:
  The path to a .NET Core managed application, dll or exe file to execute.

If you are debugging the Shared Framework Host, set 'COREHOST_TRACE' to '1' in your environment.

To get started on developing applications for .NET Core, install the SDK from:
  http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

~> dotnet --version
1.0.1

~> aws --version
aws-cli/1.11.84 Python/3.6.1 Darwin/15.6.0 botocore/1.5.47

~> pip --version
pip 9.0.1 from /Library/Python/2.7/site-packages (python 2.7)

~> python --version
Python 2.7.10

Thanks Steve - yeh I though about not being able to use a graphical editor / IDE but perhaps just setting up the capability to transfer files between local machine and EC2 instance would help (FileZilla?)
I also will follow through with the CentOS KDE workstation VirtualBox VM and if I can get that to work I’ll see if a can create a sharable appliance that is ready to go in case others want to use it.
I will try what you indicate below on OSX and keep you posted,
Thanks for your quick response to this,
Carl

On Jun 26, 2017, at 10:14 AM, Steve Bjorg<EMAIL_ADDRESS>wrote:
The EC2 instance is not a bad idea, but it would prevent running an IDE like VS Code to do the work.
If you've installed .NET Core in the past, it's likely you have some lingering garbage sitting around. I know I did and it gave me quite a bit of grief to get rid of it. However, since then, I've found the tooling to be quite solid.
To clarify, if you install .NET Core 1.1 on OSX, it will also install .NET Core 1.0 since its the LTS version.
Here's my tooling info. Hope it helps!
~> dotnet
Microsoft .NET Core Shared Framework Host
Version  : 1.1.0
Build    : 928f77c4bc3f49d892459992fb6e1d5542cb5e86
Usage: dotnet [common-options] [[options] path-to-application]
Common Options:
--help                           Display .NET Core Shared Framework Host help.
--version                        Display .NET Core Shared Framework Host version.
Options:
--fx-version            Version of the installed Shared Framework to use to run the application.
--additionalprobingpath    Path containing probing policy and assemblies to probe for.
Path to Application:
The path to a .NET Core managed application, dll or exe file to execute.
If you are debugging the Shared Framework Host, set 'COREHOST_TRACE' to '1' in your environment.
To get started on developing applications for .NET Core, install the SDK from:
http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
~> dotnet --version
1.0.1
~> aws --version
aws-cli/1.11.84 Python/3.6.1 Darwin/15.6.0 botocore/1.5.47
~> pip --version
pip 9.0.1 from /Library/Python/2.7/site-packages (python 2.7)
~> python --version
Python 2.7.10
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/LambdaSharp/June2017-AdventureBot/issues/3#issuecomment-311123238, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRRJUuwpueaLpPtnf0dayPhiCtRsQtWks5sH-bsgaJpZM4OENKx.

This is only difference so far:
aws --version
aws-cli/1.11.111 Python/2.7.10 Darwin/15.6.0 botocore/1.5.74
So I will try to revert to older version of aws-cli and also do this suggestion:
To get started on developing applications for .NET Core, install the SDK from:
 http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

Then if that doesn’t work I will try removing any and all dotnet and mono then reinstalling.
Also I copied the credentials from my default aws profile which I believe was for us-west-1 and setup this profile for the challenge:
.aws/config
[profile lambdasharp]
region = us-east-1
.aws/credentials
[lambdasharp]
aws_access_key_id = AKxxxxxxxxxxH2AMA <-- from defualt
aws_secret_access_key = Rra6lSs+UCGDxxxxxxxxxxAgoDNjz <-- from default
If I haven’t overwhelmed you too much at this point:

I did get the command line adventure game running,
The actual error I get is at tis point:

Change folder to the lambda function: cd AdventureBot.Alexa
Publish the lambda function: dotnet lambda deploy-function

==============================
AdventureBot.Alexa(master) > dotnet lambda deploy-function
Executing publish command
... invoking 'dotnet publish', working folder '/Users/carlgraff/Desktop/Training_Job_Prep/AWS/AWS-MagicNight/June2017-Alexa_AdventureBot/June2017-AdventureBot/AdventureBot.Alexa/bin/Release/netcoreapp1.0/publish'
AdventureBot.Alexa(master) >
No error message but doesn’t seem to compete all the deploy steps.

On Jun 26, 2017, at 10:14 AM, Steve Bjorg<EMAIL_ADDRESS>wrote:
The EC2 instance is not a bad idea, but it would prevent running an IDE like VS Code to do the work.
If you've installed .NET Core in the past, it's likely you have some lingering garbage sitting around. I know I did and it gave me quite a bit of grief to get rid of it. However, since then, I've found the tooling to be quite solid.
To clarify, if you install .NET Core 1.1 on OSX, it will also install .NET Core 1.0 since its the LTS version.
Here's my tooling info. Hope it helps!
~> dotnet
Microsoft .NET Core Shared Framework Host
Version  : 1.1.0
Build    : 928f77c4bc3f49d892459992fb6e1d5542cb5e86
Usage: dotnet [common-options] [[options] path-to-application]
Common Options:
--help                           Display .NET Core Shared Framework Host help.
--version                        Display .NET Core Shared Framework Host version.
Options:
--fx-version            Version of the installed Shared Framework to use to run the application.
--additionalprobingpath    Path containing probing policy and assemblies to probe for.
Path to Application:
The path to a .NET Core managed application, dll or exe file to execute.
If you are debugging the Shared Framework Host, set 'COREHOST_TRACE' to '1' in your environment.
To get started on developing applications for .NET Core, install the SDK from:
http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
~> dotnet --version
1.0.1
~> aws --version
aws-cli/1.11.84 Python/3.6.1 Darwin/15.6.0 botocore/1.5.47
~> pip --version
pip 9.0.1 from /Library/Python/2.7/site-packages (python 2.7)
~> python --version
Python 2.7.10
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/LambdaSharp/June2017-AdventureBot/issues/3#issuecomment-311123238, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRRJUuwpueaLpPtnf0dayPhiCtRsQtWks5sH-bsgaJpZM4OENKx.

Tried everything I can on OSX and have all the same versions as you. Adrian Drummond offered to troubleshoot this with me when/if he has time. So it would be best I think to have another set of eyes look at this either in person somewhere like at MindTouch or via some video conference (google hangout or TeamViewer ..etc). I will pay for someone to help me with this.
Meanwhile I will try and get this to work on my CentOS VM and perhaps an EC2 instance.
Best,
Carl

On Jun 26, 2017, at 10:14 AM, Steve Bjorg<EMAIL_ADDRESS>wrote:
The EC2 instance is not a bad idea, but it would prevent running an IDE like VS Code to do the work.
If you've installed .NET Core in the past, it's likely you have some lingering garbage sitting around. I know I did and it gave me quite a bit of grief to get rid of it. However, since then, I've found the tooling to be quite solid.
To clarify, if you install .NET Core 1.1 on OSX, it will also install .NET Core 1.0 since its the LTS version.
Here's my tooling info. Hope it helps!
~> dotnet
Microsoft .NET Core Shared Framework Host
Version  : 1.1.0
Build    : 928f77c4bc3f49d892459992fb6e1d5542cb5e86
Usage: dotnet [common-options] [[options] path-to-application]
Common Options:
--help                           Display .NET Core Shared Framework Host help.
--version                        Display .NET Core Shared Framework Host version.
Options:
--fx-version            Version of the installed Shared Framework to use to run the application.
--additionalprobingpath    Path containing probing policy and assemblies to probe for.
Path to Application:
The path to a .NET Core managed application, dll or exe file to execute.
If you are debugging the Shared Framework Host, set 'COREHOST_TRACE' to '1' in your environment.
To get started on developing applications for .NET Core, install the SDK from:
http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
~> dotnet --version
1.0.1
~> aws --version
aws-cli/1.11.84 Python/3.6.1 Darwin/15.6.0 botocore/1.5.47
~> pip --version
pip 9.0.1 from /Library/Python/2.7/site-packages (python 2.7)
~> python --version
Python 2.7.10
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/LambdaSharp/June2017-AdventureBot/issues/3#issuecomment-311123238, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRRJUuwpueaLpPtnf0dayPhiCtRsQtWks5sH-bsgaJpZM4OENKx.

Now trying on CentOS and get this message in Alexa console:
Error: Please make sure that "Alexa Skills Kit" is selected for the event source type of arn:aws:lambda:us-east-1:734071252383:function:LambdaSharp-AlexaEcho
arn:aws:lambda:us-east-1:XXXXXXXXXX:function:LambdaSharp-AlexaEcho

using the 7…...….3 you provided
Is this service still arn service still up and running with the same ID?

On Jun 26, 2017, at 11:50 AM, Carl Graff<EMAIL_ADDRESS>wrote:
Tried everything I can on OSX and have all the same versions as you. Adrian Drummond offered to troubleshoot this with me when/if he has time. So it would be best I think to have another set of eyes look at this either in person somewhere like at MindTouch or via some video conference (google hangout or TeamViewer ..etc). I will pay for someone to help me with this.
Meanwhile I will try and get this to work on my CentOS VM and perhaps an EC2 instance.
Best,
Carl

On Jun 26, 2017, at 10:14 AM, Steve Bjorg<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
The EC2 instance is not a bad idea, but it would prevent running an IDE like VS Code to do the work.
If you've installed .NET Core in the past, it's likely you have some lingering garbage sitting around. I know I did and it gave me quite a bit of grief to get rid of it. However, since then, I've found the tooling to be quite solid.
To clarify, if you install .NET Core 1.1 on OSX, it will also install .NET Core 1.0 since its the LTS version.
Here's my tooling info. Hope it helps!
~> dotnet
Microsoft .NET Core Shared Framework Host
Version  : 1.1.0
Build    : 928f77c4bc3f49d892459992fb6e1d5542cb5e86
Usage: dotnet [common-options] [[options] path-to-application]
Common Options:
--help                           Display .NET Core Shared Framework Host help.
--version                        Display .NET Core Shared Framework Host version.
Options:
--fx-version            Version of the installed Shared Framework to use to run the application.
--additionalprobingpath    Path containing probing policy and assemblies to probe for.
Path to Application:
The path to a .NET Core managed application, dll or exe file to execute.
If you are debugging the Shared Framework Host, set 'COREHOST_TRACE' to '1' in your environment.
To get started on developing applications for .NET Core, install the SDK from:
http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409 http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
~> dotnet --version
1.0.1
~> aws --version
aws-cli/1.11.84 Python/3.6.1 Darwin/15.6.0 botocore/1.5.47
~> pip --version
pip 9.0.1 from /Library/Python/2.7/site-packages (python 2.7)
~> python --version
Python 2.7.10
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/LambdaSharp/June2017-AdventureBot/issues/3#issuecomment-311123238, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRRJUuwpueaLpPtnf0dayPhiCtRsQtWks5sH-bsgaJpZM4OENKx.

No, I stopped the lambda function. You can either publish the Alexa Echo function or just skip to step 2.

OK thanks - I got step 2 to work on CentOS VM - so I will save a snapshot of VM now and go back to OSX and try one last thing.
Best,
Carl

On Jun 26, 2017, at 4:34 PM, Steve Bjorg<EMAIL_ADDRESS>wrote:
No, I stopped the lambda function. You can either publish the Alexa Echo https://github.com/LambdaSharp/AlexaEcho function or just skip to step 2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/LambdaSharp/June2017-AdventureBot/issues/3#issuecomment-311210697, or mute the thread https://github.com/notifications/unsubscribe-auth/AQRRJUUaPfbk83Zs4WSG76Ve5PsmoqCrks5sID__gaJpZM4OENKx.

Closing.

Thanks for looking into this for me back when it happened Steve. I should have let you know that it was definitely something in my Mac environment because I spun up a virtual Ubuntu machine and started from scratch and everything worked. fine.

No worries. I was just updating the challenge for .NET Core 2.1 and saw it had an open issue. I had totally forgotten about it! :)


fix(timer): add some improvements in ministry timer

:tada: This PR is included in version 2.130.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"weak digest" warning for deb packages

Hi,
I've started to see this warning recently in Debian Stretch:
W: gpgv:/var/lib/apt/lists/releases.ponylang.org_apt_dists_ponyc_InRelease: The repository is insufficiently signed by key D7488C9552A480F4BF654B3A947573BCDA5E0D11 (weak digest)

It means that the GPG signature on the "Release" file was made with SHA1. Debian has deprecated SHA1, more info on their wiki.
It is very easy to fix though. You must pass  --digest-algo SHA256 or --digest-algo SHA512 to gpg when signing the file.

@killerswan do you know if this was resolved by work you did getting us set up to release? Hopefully yes and we can close this.

If it has been fixed it was not by my actions.  (Perhaps the FPM package used by Travis has been updated to use a better default, say?)

@satbyy any chance you could check and see if this is fixed for you?

Given how long this has been open and no one has reported this since the new release process, I'm going to close this with the possibility it can be reopened if @satbyy reports he still has an issue or if someone else reports going forward.

@SeanTAllen  I'm getting this new warning:
W: The repository 'https://dl.bintray.com/pony-language/ponyc-debian pony-language Release' is not signed.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.

Hmm, there I probably need to mess around a little so my story about which certs you should accept is clear.

@killerswan ? i don't understand.

I'm just getting started with PonyLang, when I installed Ponyc on my Debian system, I had the same warning message.
W: The repository 'https://dl.bintray.com/pony-language/ponyc-debian pony-language Release' is not signed.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.

we have an issue open for this. should hopefully be closed soon. see #1433.


Next.js sites should be environment specific or handled as content. (not as configuration)

I receive error logs as either

localhost is not reachable by the production site when revalidating
the content does not exists on localhost (testing)
editors see the wrong preview

The last one I was able to hack away by creating a custom module that modifies the form. Still kinda ugly.
I understand that seeing "sites" as configuration makes all a bit easier, but it created a lot of issues on the other hand. Are there plans to implement hooks or settings (setting.php) in the future to kind of hide a non env specific "next js destination"?

One solution is to exclude this config values on every environment. Another one is to use one only environment entry and override it on settings.php.
Exclude on config.
$settings['config_exclude_modules'] = [
  'next.next_site.production',
  'next.next_site.stage',
  'next.next_site.localhost',
];

Override (eg for "localhost")
$next_url = "https://my-drupal-cms-domain.com";
$config['next']['next_site']['localhost']['base_url'] = $next_url;
$config['next']['next_site']['localhost']['preview_url'] = $next_url . "/api/preview";

@MokDevelopment I was going to suggest what @theodorosploumis said.
Keep your sites configured for your prod environments then in override the values in your settings.local.php.

Seems that $settings ['config_exclude_modules'] is not for excluding configs. It is for excluding "modules"
https://drupal.stackexchange.com/questions/291639/how-does-the-new-config-exclude-modules-setting-work-exactly

Closing as stale. And based on the discussion here this should be possible with config ignore, config split, settings.php overrides, or some combination of those approaches.


Requesting Background Location for Android

Is it possible to make it request for FINE and COARSE, and then afterwards request for Background?

@liamcharmer you should ask those questions on discord/. Github is for issues and feature requests.
Yes you can simply request without background then with. Should work


spirv-val false positive error

I have error when validating shader code
Structure id 7 decorated as Block for variable in Uniform storage class must follow relaxed uniform buffer layout rules: member 2 at offset 1032 overlaps previous member ending at offset 1039
  %_struct_7 = OpTypeStruct %int %_arr_v2int_uint_64 %float

I am compiling shader
struct PSInput
{
    float4 position : SV_Position;
    float4 color    : COLOR0;
};

cbuffer shader_parameters {
	 int s_var1;
	 int2 s_arr[64]; // <-- invalid validating offset of this element
	 float s_var2;
};

float4 PSMain(PSInput input) : SV_Target0
{
    return input.color * input.color;
}

It produces me this asm:
OpDecorate %_arr_v2int_uint_64 ArrayStride 16
OpMemberDecorate %type_shader_parameters 0 Offset 0
OpMemberDecorate %type_shader_parameters 1 Offset 16
OpMemberDecorate %type_shader_parameters 2 Offset 1032 // <--- This offset is correct for dx layout and my app works nicely with it, except of validation error
OpDecorate %type_shader_parameters Block

I am compiling shader using DXC with "-spirv -fvk-use-dx-layout -O0" flags and trying to validate it using this code:
spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_3);
spvtools::ValidatorOptions options;
options.SetRelaxBlockLayout(true);
options.SetFriendlyNames(false);
spv_const_binary_t binary {
  (const uint32_t *)shaderCode,
  shaderSize / sizeof(uint32_t)
};

spv_diagnostic diag = nullptr;
auto res = spvValidateWithOptions(ctx, options, &binary, &diag);

The problem here is placing s_var2 at offset 1032. Vulkan has the following rule:

If one of the conditions below applies

The storage class is Uniform, StorageBuffer, PhysicalStorageBuffer, ShaderRecordBufferKHR, or PushConstant, and the scalarBlockLayout feature is not enabled on the device.
The storage class is Workgroup, and either the struct member is not part of a Block or the workgroupMemoryExplicitLayoutScalarBlockLayout feature is not enabled on the device.
The storage class is any other storage class.

the memory layout must also obey the following rules:

Vectors must not improperly straddle, as defined above.
The Offset decoration of a member must not place it between the end of a structure, an array or a matrix and the next multiple of the alignment of that structure, array or matrix.

The last bullet is being tripped. If you were to use -scalar-block-layout (or even -uniform-buffer-standard-layout I believe) it should validate successfully.

But when I am compiling shader using vkCreateShaderModule I have the same error. I can't enable -scalar-block-layout or -uniform-buffer-standard-layout because it called internally in validation layer. And what if I dont want to enable additional features? I dont think that I need them, because everything works correctly now I think

But when I am compiling shader using vkCreateShaderModule I have the same error. I can't enable -scalar-block-layout or -uniform-buffer-standard-layout because it called internally in validation layer. And what if I dont want to enable additional features? I dont think that I need them, because everything works correctly now I think

The validation layers would pick the vulkan features and enable those setting appropriately. So if you requested either at device creation the layers should use them. Your app might work because the device supports the higher feature level. If you tried this on an old implementation it might not.

But do I really need to enable one of these features to truly support offsets like this on all devices?

Unfortunately, yes, I think so. Alternatively you reorder your structure definition.

Yep, I added uniform-buffer-standard-layout extension and now it validates and work fine. Thank you!


Use phonenumbers to format phone numbers

See Formatting phone numbers in the Twilio FAQ:

Twilio always returns phone numbers that are formatted in the E.164 format, like this: +12125551234. However your users may enter them like this:<PHONE_NUMBER>. This can lead to problems when, for example, Twilio makes a POST request to your server with the From phone number as +12125551234, but you stored the phone number in your database as<PHONE_NUMBER>, causing a database lookup to fail.

We suggest that you convert the number to E.164 format before you store it in the database. The phonenumbers library is excellent for this purpose.

See branch features/phone-number-validation.

Closed in favor of PR #112.


Missing bash script

Running simple task and getting error
Running: sh concat.sh output/list.txt output/final/xxxxxxxx.mp4 sh: 0: Can't open concat.sh  ERROR! Exception in thread "main" java.lang.RuntimeException: Error executing sh script         at com.autovideo.utils.ProcessRunner.run(ProcessRunner.java:32)         at com.autovideo.video.VideoRenderer.render(VideoRenderer.java:84)         at com.autovideo.wiki.WikiVideoCreator.createVideo(WikiVideoCreator.java:219)         at com.autovideo.wiki.WikiVideoCreator.main(WikiVideoCreator.java:261)

Hi, thanks for reporting this. I've added the script to the repo now :)


Remove version: Tencent.COSBrowser version 2.11.21

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://cos5.cloud.tencent.com/cosbrowser/cosbrowser-setup-2.11.21.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


SSR + Session

I'm getting this error when I try to

import { Session } from 'meteor/session'

Error: Can't find npm module 'meteor/session'. Did you forget to call 'Npm.depends' i
n package.js within the 'modules-runtime' package?

Is there a way to use Session with SSR ?

If you're using React, you can do:
componentDidMount() {
  const Session = require('meteor/session');
  // Do whatever you want with Session
}

I tried it but it complaint about there is no set function of Session

Session.set('test','something');

TypeError: Session.set is not a function

Try console log Session. You will see that Session is an object not a func. You can try Session.Session.set('test', 'something').

Thanks sammkj it works. But I feel something is not right
Everytime when I set a session variable I have to use this syntax :
const rv = require('meteor/session');
rv.Session.set('test','something');
and when get it this syntax :
const rv = require('meteor/session');
let variable=rv.Session.get('test');
//use variable
Must be a simple way but I am newbie in react :(
Could you suggest a proper and shorter way ?

I would create a helper function like:
function setSession(stuff) {
  const Session = require('meteor/session').Session;
  Session.set(stuff);
}

Then call that helper function anywhere in your react component. Hope that helps!

Yeap. Sometimes when you think complex you cab boot see the simple solutions :) Thats it. Thanks..


cmd/compile: nowritebarrier not checked by SSA compiler

The //go:nowritebarrier and //go:nowritebarrierrec annotations in the runtime are not being checked in SSA mode.
For example, add sched.gfree = sched.gfree to any go:nowritebarrier function and compile the runtime. It should fail, but doesn't. Recompile with -gcflags -ssa=0 and it will correctly fail with "write barrier prohibited".
/cc @randall77 @dr2chase

The check is easy to add in.  But it is failing, SSA is generating a write barrier in runtime/mstkbar.go:208 where we store a slice to the heap:
	gp.stkbar = gp.stkbar[:len(gp.stkbar)+1]

When the frontend passes this assignment to SSA, it is marked as requiring a write barrier:
.   ASWB u(100) l(17067) tc(1)
.   .   DOTPTR u(2) l(17067) x(136+0) tc(1) assigned ARRAY-[]stkbar
.   .   .   NAME-runtime.gp u(1) a(true) g(2) l(17030) x(0+0) class(PPARAM) f(1) esc(no) tc(1) used(true) PTR64-*g
.   .   .   NAME-runtime.stkbar u(1) a(true) l(17067) x(0+0)
.   .   SLICE u(2) l(17067) tc(1) ARRAY-[]stkbar
.   .   .   DOTPTR u(2) l(17067) x(136+0) tc(1) ARRAY-[]stkbar
.   .   .   .   NAME-runtime.gp u(1) a(true) g(2) l(17030) x(0+0) class(PPARAM) f(1) esc(no) tc(1) used(true) PTR64-*g
.   .   .   .   NAME-runtime.stkbar u(1) a(true) l(17067) x(0+0)
.   .   .   KEY l(17067)
.   .   .   .   NAME-runtime.autotmp_2802 u(1) a(true) l(17067) x(0+0) class(PAUTO) esc(N) tc(1) assigned used(true) int

I guess there's some subsequent logic in the legacy compiler that removes the write barrier if it notices that the pointer being written is to the same object as the pointer that is already there.  Might be nice if we pushed that logic up to before the SSA cutoff so it can be shared.
The only other occurrence is at mstkbar.go:233:
	gp.stkbar = gp.stkbar[:0]


Remove fuse.js as a dev dependency

The fuse.js library is set as both a dependency and dev dependency, which causes Nx to get confused and not bundle it in package.json.
I made the change locally and did a full clean and rebuild before and after. Below is the dist/libs/designer/package.json content before and after.
Before

After

@rllyy97 or @hartra344 are you able to complete the PR? Even with approvals I do not have permission to complete it. Thanks!


[Request] ability to hand input set_orthographic_screen coords

To get proper preplanning images I had to delete
self._camera_object:set_orthographic_screen( -(res.x/2)*self._mul, (res.x/2)*self._mul, -(res.y/2)*self._mul, (res.y/2)*self._mul )
And replace it with my desired scale and teleport the camera to the center location
self._camera_object:set_orthographic_screen( -8000, 8000, -8000, 8000 )
The request is when in orthographic mode there be a a camera position and orthographic screen value, Something like...
Camera Location: X Y Z
Orthographic scale: X Y (Where X = X and -X)

btw, you can go up and down via Q and E


Fix #1942: Cleanup XML of transform CSV Input

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[ ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[ ] In any other case, please file an Apache Individual Contributor License Agreement.

going to close this one as it is a bit old


syncing props and state is usually a bad idea

Update over the issue #337

Why did you close? We don't currently have capacity to review all PRs but we'd get to it eventually.

Let me reopen it again