ARROW-7165: [C++] passing memory table to hash functions

This PR is to propose some ideas to support groupby in arrow compute.
In JIRA 7165, I summarized some steps in my opinion which is required to support groupby.

change functions in arrow/compute/hash to support a input memo_table.(In this PR)
add splitarray function to use dict encode array as input to split current array. I know we have "take", split is quite like "take", while produces multiple array as output.(in comming PR, codes are done)
So I hope I can get some input here, to see if this is a right path, or you guys already have another plan.
=================
In this PR, I moved memo_table from inside RegularHashKernelImpl class member to the API function, so user can either pass memo_table or init memo_table there.

Signed-off-by: Chendi Xue<EMAIL_ADDRESS>

@wesm , I think you have some works in arrow/compute, hope you can give me some feedback.

I'm a bit hesitant to express views one way or another without seeing an implementation of a hash aggregation fully worked out. Does that make sense?

I'm a bit hesitant to express views one way or another without seeing an implementation of a hash aggregation fully worked out. Does that make sense?

I see, my current "group by hash aggregation" is a combination of "encode dict" + "splitarray" + "aggregate", hope below graph can make my design more clear, after getting a encodedArray from the grouping column, we can use that encodedArray to split all arrays in one batch and then perform aggregate to each array.

and we can use one hash_table(memo_table) for multiple batches so data within same group from different batches can be splitted into same array.
I have completed all codes in my side, while I felt it will be a ton of effort to fix the naming convention for arrow, so I hope I can get some input firstly of knowing if you want to see such an implementation?

@wesm , and that is why I submitted the first PR(this one), to make hash_table as an input argument for methods inside arrow/compute/kernels/hash.h

@wesm , so despite of the whole "GroupBy hash aggregation" design, do you think this PR makes sense to you, if so, I will work on the CI issue fixing. If you don't think this PR makes sense, I will close it.

In general, I am not in favor of "speculative" refactoring. Since there are no unit tests in this patch, that's how this seems to me. I think we need to take a step back and have a broader discussion about the implementation strategy for hash aggregations and other grouping algortihms. Once a strategy has been agreed upon, I do not think we should be accepting any patch until a meaningful algorithm (and associated unit tests) have been implemented.

In general, I am not in favor of "speculative" refactoring. Since there are no unit tests in this patch, that's how this seems to me. I think we need to take a step back and have a broader discussion about the implementation strategy for hash aggregations and other grouping algortihms. Once a strategy has been agreed upon, I do not think we should be accepting any patch until a meaningful algorithm (and associated unit tests) have been implemented.

I see, thanks, @wesm , is there a development discussion meeting we can attend to propose our idea of groupby hash aggregation, or we simply submit design doc on JIRA so anyone interested will comment on that? Which is a prefer way?

@wesm , and for this PR, I apologize that I missed to submit unit tests as well, so it looks like a 'patch' to you, actually it is more like a new interface, anyway, I can either add a unittest to make it more clear to you, or we can have a broader discussion on the whole plan firstly, and hold on this PR our we have an agreement on the design path.

@xuechendi the appropriate place would be the dev@ mailing list -- you can create JIRA issues that map onto the concrete development steps. To reiterate, it's fine if the project takes a while or yields a large pull request, but I think we need to get the target algorithm (for example, a hash/group sum) fully worked out so that we can assess whether the implementation approach is valid.

@wesm , I see, thanks so much for the information, I'll send to dev@ maillist. :)

Closing. I think some more discussion about hash aggregation is required, let's do that and then decide what code changes are necessary


This is organization repository. It mean this is YOUR repository.

Hi, @Kose-i
You forked this repository.
It's so great and cool!
But, we often use fork to OTHERS repository because we cannot edit it.
Here, we can edit this repository.
This is our repository, that is to say, fork is unnecessary.
You can checkout branches to start task on THIS repository.

Please ask @CIRKIT-ARC-1stGrade your question on some issue.

This is demo.


Fix Browserify and JSPM

Inspired by #22

This is something that should be fixed in the request package, not in this library.
See https://github.com/webpack/react-starter/issues/3#issuecomment-53395089
You can workaround the issue in your build by adding the following config to your webpack config file:
  node: {
    fs: 'empty',
    net: 'empty',
    tls: 'empty'
  }

You are right for webpack, but jspm tries to load request even if it is never used in the browser.

Ah yes, you are right.

Re: this and #22, is the problem just that the bundlers see require() and try to do something with it?  Because for the life of me I can't see in what circumstances the code in question would actually run, ever.  Either window is undefined, in which case xOrigin will be undefined, and the code requiring request won't be run, or window is not undefined, in which case the jsonp call will be made, and again, the request code will never be run.   What's more, I don't see what the code would accomplish even if it did run, since it's not saving a cookie anywhere that socket.io would have access to it.  So really, I think we can just remove that code entirely and solve all these problems.  I'll check in with @mikermcneil to see if our former selves had some brilliant idea here.

Ok -- removed calls to request in https://github.com/balderdashy/sails.io.js/commit/a23cc5bc0384c8c15b16b9197d763e1ea7a2ea0d and published v0.13.7.

Thank you! Even better. 😄


"logo.png not found"

After it working just fine I get now an error message while booting
Error: can't find file "\boot\grub\themes\minegrunb-theme\logo.png"; logo.png is missing
I have the Cycler.sh activated.
Workaround with redoing grub-mkconfig works in best case only for one reboot, even when there is no grub update. Most of the time it doesn't work.
Platform is Endeavour OS (arch fork)

I don't know why, but gitalways told me I am up to date, but it turns out I wasn't.
A git stashand git pull helped with the issue of the missing file...


Update the documentation

The documentation of this package is too complex and misses out on things, because more and more issues are opened which could have been solved by a better documentation.
Since this package is quite widely used, the meteor-guide should also be updated: https://github.com/meteor/guide/blob/master/content/testing.md

It also doesn't contain anything about how to use puppeteer ...

I think how to install peer NPM packages for testing packages should be somehow documented, see: https://github.com/meteor/meteor/issues/8577 (Or maybe Meteor issue should be reopened in the first place.)


Main branch not synced with the recent updates

Missing xfeat parser update.

Hi @NajtexQ , this library is currently in an alpha stage and we are actively developing it. We keep main branch reserved for stable releases whereas new features are getting incrementally added to other branches. For XFeat specifically there is currently updated version on feature/xfeat branch which has option to trigger it and also option to work on two inputs (e.g. left and right camera). CC: @kkeroo for additional information if needed

@klemen1999 when can we mainline it, so we can prepare blog post about it?

@Erol444 Initial plan was to wait for the "ParserV2" refactoring and then make a new release - this will introduce some breaking changes. On the other hand there are some models (OCR, Lane detection, some other fixes) which now have parsers only in dev branch. So we can make a release for this and then make a bigger release once refactoring is finished.
For the blog though IMO it is valuable to wait for the "ParsersV2" just because of the changes in the API. After that release the overall structure should stay roughly the same going forward.

Hi @NajtexQ
We've made a new release, v0.0.2-alpha, that includes the XFeat parser along with some other smaller bugfixes and changes. Feel free to check it out.


Jeonghan/test

Controller Test Done, except Auth.

Codecov Report

Merging #27 (77a4996) into master (75e3434) will increase coverage by 43.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master      #27       +/-   ##
=============================================
+ Coverage     35.63%   78.66%   +43.03%
- Complexity      112      244      +132
=============================================
  Files            49       49
  Lines           595      628       +33
  Branches         21       21
=============================================
+ Hits            212      494      +282
+ Misses          376      131      -245
+ Partials          7        3        -4

Impacted Files
Coverage Δ

...e_alone/dokkang/controllers/CommentController.java
100.00% <100.00%> (+90.00%)
:arrow_up:

...kkang/controllers/CommentStudyGroupController.java
100.00% <100.00%> (+90.00%)
:arrow_up:

...m/de_alone/dokkang/controllers/PostController.java
100.00% <100.00%> (+96.00%)
:arrow_up:

...lone/dokkang/controllers/StudyGroupController.java
100.00% <100.00%> (+97.29%)
:arrow_up:

...java/com/de_alone/dokkang/models/BoardComment.java
90.47% <100.00%> (+40.47%)
:arrow_up:

...com/de_alone/dokkang/models/StudyGroupComment.java
95.23% <100.00%> (+88.09%)
:arrow_up:

..._alone/dokkang/models/StudyGroupParticipation.java
80.00% <100.00%> (+70.00%)
:arrow_up:

...va/com/de_alone/dokkang/models/StudyGroupPost.java
96.77% <100.00%> (+92.01%)
:arrow_up:

.../dokkang/payload/request/CreateCommentRequest.java
80.00% <100.00%> (+80.00%)
:arrow_up:

...ayload/request/CreateCommentStudyGroupRequest.java
88.88% <100.00%> (+88.88%)
:arrow_up:

... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Laravel 11 release

Hello,
Could you release a version with the latest commit for Laravel 11 compatibility please?
Thanks

done. :partying_face:


[$250] Chat - Badge 'New messages' disappears after returning to the chat from thread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.2-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4676291
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Open iOS/iPad or Android App
Login with any account
Got to any chat with long history
Mark the latest message as unread
Scroll up the chat history, long-tap on any message and tap to 'Reply in thread'
Go back from thread to the main chat history

Expected Result:
The badge 'New Messages' is present at the top of the screen
Actual Result:
The badge 'New messages' disappears after returning to the chat history from the thread
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native/ iPad
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/ed9f937b-0224-4f8e-a8ab-dadfe3e418a3
https://github.com/Expensify/App/assets/115492554/b24c9396-891a-4ac0-8889-4a006c44a9eb

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01701df429333bf5ee
Upwork Job ID:<PHONE_NUMBER>119579428
Last Price Increase: 2024-07-04

Issue OwnerCurrent Issue Owner: @fedirjh

We think this issue might be related to the #vip-vsb

I think this is kinda fixed on the latest 9.0.2-5. You can see the badge does not show up immediately but the unread line is there and as you scroll the badge shows up.
https://github.com/Expensify/App/assets/36083550/f67e2827-b2bf-4247-a447-1145b36648b2
I think we can demote and retest and see if we need to update the OP @kavimuru @izarutskaya

Nice, thanks @mountiny <3

retesting!

Can no longer repro, given then comment above from Vit, i think we should be good to close this one.


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
0b1411f -> 5b96dd7

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.37.2 -> v1.38.1

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.38.1
Compare Source
Bug Fixes

deps: update gomod (#857) (87710ff)

v1.38.0
Compare Source
Features

add function to check ingress health status of a cluster (#751) - Added new function testhelper.CheckClusterIngressHealthy() which can be used in Terraform tests to validate the status of an OpenShift cluster (801dd27)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

3 additional dependencies were updated

Details:

Package
Change

github.com/IBM/platform-services-go-sdk
v0.67.0 -> v0.68.1

github.com/gruntwork-io/terratest
v0.47.0 -> v0.47.1

github.com/hashicorp/go-getter
v1.7.5 -> v1.7.6

/run pipeline


Is anyone actively monitoring this repo?

I find this to be a very versatile and useful moment plugin. I see Issues and PRs that have been lingering without resolution.
For those who have the ability to merge... are you still active here?
For others, have you found an alternative that meets your date recurrence needs?

I'm still around - just haven't had a lot of time to review/merge things. Some PRs are outstanding because the author hasn't updated their commits per request. If you would like to make contributions, please do so. I will try to find some time to review/merge. Thanks for your interest in my plugin!

Good to know. Thanks.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20220117163405929 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20220117163405929 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.276%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14748

Relevant Lines:
29008

💛  - Coveralls


Display coin transactions for paid fees in coin transaction list

User should be able to navigate to Coin transaction list and see coin transactions for fee paid.
e.g. User transfers 10 LINK and pays 0.1 ETH for fee:

user should see one transaction in the "All transactions" list (value=10LINK)
user should see the same transaction in the "LINK transactions" list (value=10LINK)
user should see an ETH transaction for the fee he paid in ETH in the "Ethereum transactions" list (value=0.1ETH)

Clicking on any of those transactions takes the user to the same transaction details page (showing both the value and the fee)
The ETH transaction (fee transaction) should be differentiated from regular send transactions. It should be clear to the user that this is just the fee that was paid for the transaction.
This applies to all blockchains with tokens

@martinkaintas

Labeling for the specific case of transaction fee item: "Transaction fee paid" (see mockups below).
Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(✔Updated)?node-id=31920-204697&t=xkxejuN2HvrwbOfy-0

Design:

IMO when the user goes from Asset/Transactions to Transaction details the back arrow button should lead back to previous screen and not to the all transactions list of Dashboard/Account details/
As a user I'd expect this behavior when clicking on back. I'd suggest an exception from implemented routing rules in this case.

This can be closed, we will treat it in another way


Hand orientation estimation

Good evening, a quick question.
I am using Hamer to estimate the hand orientation (rotation) from a monocular video.
If I understand the code correctly pred_mano_params.global_orient represents the rotation matrix to go from the hand reference frame to the camera reference frame.
If the image coordinate system is the usual:

what is the hand coordinate system?

I am using the repo to also track the wrist position and orientation in space. Therefore I need the relative rotation btw camera and wrist frame.
I was previously using FrankMocap for this purpose and I could do that there by taking the wrist component of ['pred_joints_smpl'] which is the angle axis representation of this rotation.
My idea to do it with Hamer was to just use out['pred_mano_params']['global_orient'], convert it to angle axis and use it in place of the FrankMocap prediction but I get some unexpected rotation values.
Therefore I wanted to know what is the reference frame for this rotation.
Do you have some code example for doing what you suggested and render the result on the input image?
Thanks for the help

If I just use the visualisation script I was using for FrankMocap that did what you suggested but I use the rotation from global_orient instead the result looks wrong:

(blue is FrankMocap and red is Hamer)
That is why I am trying to understand better what the rotation in global_orient  means

Hamer should be a drop-in replacement for the hand estimation module of FrankMocap, since they regress the same output.
Can you share the rendering script you use (from FrankMocap regressed output to rendering)? Is it likely you are applying further transformations to the FrankMocap output to render according to the renderer conventions?
The demo code we have shows examples of how to render the predicted output both on the bounding box level and at the full image.

This is the rendering code I use. I hope it makes sense even if it is out of context: https://github.com/retoc71586/bullshitting/blob/main/renderer.py
I find the main difference to be your use of the parameter focal_length.  It is not fully clear to me how you use this parameter in the renderer and why you do not use theglobal_orient  parameter in the rendeding.

Hmm, if I understand correctly, this only shows the initialization of the renderer, not the actual rendering function (for example, I don't see how you handle the wrist rotation as you mention above).
The focal_length value would affect the estimated translation for the rendering, and based on the visualization you give, the translation seems to be roughly accurate, so that probably is handled as expected. I'm more concerned with the global_orient, and how this is handled by the MANOGroupLayer, which I don't have the definition for.
But instead of digging deeper into the code, I'm thinking whether it could help more to establish the correspondence between HaMeR and FrankMocap. So, FrankMocap returns a field pred_hand_pose with 48 parameters. The first three correspond to the out['pred_mano_params']['global_orient'] for HaMeR and the other 45 to the out['pred_mano_params']['hand_pose'] for HaMeR. The only difference is that HaMeR outputs the 3D rotations in rotation matrix representation, while the FrankMocap output is in axis angle representation, but based on your previous messages, you are aware of that. Beyond that, there is direct correspondence between pred_hand_betas for FrancMocap and out['pred_mano_params']['betas'] for HaMeR, and (I believe the same is true) for pred_camera of FrankMocap and out['pred_cam'] of HaMeR. If you follow this correspondence, you should be getting an 1-to-1 mapping between the two.
With that being said, something that I don't follow in your above messages, and could be source of confusion, is that:

the wrist component of ['pred_joints_smpl'] which is the angle axis representation of this rotation

This field for FrankMocap gives only the joint location. The wrist rotation in axis angle representation for FrankMocap is actually the first three values in the pred_hand_pose field and, as I write above, this corresponds to out['pred_mano_params']['global_orient'] for HaMeR.
I hope this is helpful. If there is still confusion after the 1-on-1 mapping, then you might need to share more of the script of how you handle the FrankMocap output, to see what you might be doing differently.

Good morning, thanks for the support on the matter.
You are right, the variable in FrankMocap containing the wrist orientation is pred_hand_pose, I have corrected my previous message not to mislead anyone who might be reading this thread in the future.
What you said about the 1to1 correspondence (I get the angle axis from the rot matrix via aa, _ = cv.Rodriguez(rot_mat)) makes perfect sense to me so I agree there must be something strange with the rendering. I have updated my code at https://github.com/retoc71586/bullshitting/blob/main/renderer.py with the whole renderer class which I call just by renderer.run()
The piece of code where I get the vertices from MANO is
self._mano_group_layer = MANOGroupLayer([self._mano_side],[self._mano_betas.astype(np.float32)], mano_root=base_path+"/utils/mano/manopth/mano_v1_2/models").to(self._device) and consequently
mano_pose = self._mano_poses[:,f,1:]
pose = torch.from_numpy(mano_pose.astype(np.float32)).to(self._device)
pose = pose.view(-1, self._mano_group_layer.num_obj * 51)
vert, joint = self._mano_group_layer(pose)
This vertices and joints are then saved in the renderer internal variables.
In pose  I save pred_hand_pose coming from FrankMocap in the order angle_axis_wrist_rotation, joint_3D_position (this reference frame), wrist_3D_position_in_camera_frame.
I think the reason why my FrankMocap code is not compatible with yours is that we use a different MANO layer with different input shape. I use this code, whereas I see you are using smplx.MANOLayer coming from MaxPlanck institute code.

I tried the manopth package and for a random input, it gives me the exact same vertex output as the MPI MANOLayer code. The only difference is that manopth outputs vertices in mm, while MANOLayer in meters.
Is it possible that you apply some extra transformation in the modified manopth code (I see this is not the original), other than simply adding the wrist_3D_position in the vertices? Or any potential error with the transformation from rotation matrices to axis angle? (Although I think that's unlikely, given that the joint rotations look ok). Also, a small comment:

In pose  I save pred_hand_pose coming from FrankMocap in the order angle_axis_wrist_rotation, joint_3D_position (this reference frame), wrist_3D_position_in_camera_frame.

I assume you mean joint_3D_rotations instead of joint_3D_positions. So it should be simply the pred_hand_pose of FrankMocap + the wrist_3D_position.
Beyond that, I believe that the HaMeR output should be able to directly substitute FrankMocap and is compatible with manopth.
Alternatively, if you are not tied to manopth, you could use the MPI MANOLayer and our rendering code.
Here is the MANOLayer initialization. Here is the forward pass to get the vertices given the HaMeR output. And here we have the function that handles the rendering.


Merkle tree should support storing some middle layers

Store some middle layer to avoid reading the entire tree twice (in memory / on disk).

Support using this layer when generating a proof.
Consider disk block size and available memory and ephemeral disk space when deciding which layer to store.
Example numbers:

Each block on the disk (usually 4KB) could contain a 7-layer subtree (assuming 32-byte leaves).
Assuming a 256GB tree, this means that if we store a 2GB cache of the 7th layer we can generate a proof for any subset of leaves by only reading those 2GB and one additional block (or less) per proven leaf.

There's no need to store this additional data all the time. When filtering leaves, the entire tree needs to be traversed anyway, so this cache can be generated then, stored on-disk or in-memory and discarded once the proof is complete.

@zalmen


ValueError: Trying to set a tensor of shape torch.Size([16, 1536, 1, 1]) in "weight" (which has shape torch.Size([16, 2048, 1, 1])), this look incorrect.

I try to load the small-small models but it generates an error

['transforms', 'clip_preprocess', 'gdf', 'sampling_configs', 'effnet_preprocess']
models/stage_c_lite_bf16.safetensors
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
[<ipython-input-4-1d475d0c6014>](https://localhost:8080/#) in <cell line: 3>()
      1 # SETUP MODELS & DATA
      2 extras = core.setup_extras_pre()
----> 3 models = core.setup_models(extras)
      4 models.generator.eval().requires_grad_(False)
      5 print("STAGE C READY")

1 frames
[/usr/local/lib/python3.10/dist-packages/accelerate/utils/modeling.py](https://localhost:8080/#) in set_module_tensor_to_device(module, tensor_name, device, value, dtype, fp16_statistics, tied_params_map)
    343     if value is not None:
    344         if old_value.shape != value.shape:
--> 345             raise ValueError(
    346                 f'Trying to set a tensor of shape {value.shape} in "{tensor_name}" (which has shape {old_value.shape}), this look incorrect.'
    347             )

ValueError: Trying to set a tensor of shape torch.Size([16, 1536, 1, 1]) in "weight" (which has shape torch.Size([16, 2048, 1, 1])), this look incorrect.

stage_c_3b.yaml
# GLOBAL STUFF
model_version: 3.6B
dtype: bfloat16

effnet_checkpoint_path: models/effnet_encoder.safetensors
previewer_checkpoint_path: models/previewer.safetensors
generator_checkpoint_path: models/stage_c_lite_bf16.safetensors

In order to use the small stage C, the field "model version" should be set to 1B in the config Yaml (and 700M for stageB)
https://github.com/Stability-AI/StableCascade/blob/209a52600f35dfe2a205daef54c0ff4068e86bc7/train/train_c.py#L152
https://github.com/Stability-AI/StableCascade/blob/209a52600f35dfe2a205daef54c0ff4068e86bc7/train/train_b.py#L167

Just a note for anyone else who ran into this issue, if you're using the yaml config/inference/ files from the notebooks, you need to set model_version to 1B


Improve RFC-0001

I think i merged too quickly the RFC-0001, here are some improvements to be made :

[x] It's specified that Zom uses, by default the C calling convention but it could be false in later version, so delete this part is a good idea.
[ ] In function declaration; it's said that the string literal after the extern keyword is the calling convention but it's actually the ABI used.
[ ] Add function definition while specifying the ABI used like that :

extern "C" func foo_bar(foo: c_int, bar: c_int) c_int {
    // ...
}

[ ] In the Deep dive explenation section, explain that a function definition with Zom ABI is just a function definition :

extern "Zom" func foo_bar() void {

}

// is equal to

func foo_bar() void {

}

[ ] remove in deep dive section the part where we talk about the name mangling, it will be covered in another RFC.

Note that issue is extraordinary because the RFC process catch this special issue, when you merge too quickly an RFC that it isn't finished.


(WIP) h2c Upgrade support

Needs more testing and a few sanity checks, but basic support should be there.
p.s. credit to @kenichi for bulk of the work here! See: https://github.com/igrigorik/http-2/commit/376d4433b1b3e738ed8e827b99c7cfe43dfa50f6

@igrigorik i've been super swamped but do plan on looking at this soon!

@kenichi no rush and thanks.. I have a few small cleanup things to do on the pull, but otherwise I think it's mostly there.

@igrigorik almost a year later! 😳  i finally got around to reimplementing this on reel - still a WIP - but the .upgrade method sure is handy. 👍
https://github.com/celluloid/reel/compare/master...kenichi:h2

LOL, I spent all weekend trying to figure this out.

@georgeu2000 uh oh sorry - anything i can (try to) help with?

@kenichi - Does example/upgrade_server work with any browser for you? Right now I am figuring out where http_parser comes from.

@georgeu2000 browsers only like h2 over TLS so i've been testing with nghttp2. i think if you build curl with h2 support it will do upgrades too.
utwig:http-2 $ nghttp -vu http://<IP_ADDRESS>:8080/                                                                                [29/32]
[  0.003] Connected
[  0.004] HTTP Upgrade request
GET / HTTP/1.1
host: <IP_ADDRESS>:8080
connection: Upgrade, HTTP2-Settings
upgrade: h2c
http2-settings: AAMAAABkAAQAAP__
accept: */*
user-agent: nghttp2/1.16.0-DEV

[  0.004] HTTP Upgrade response
HTTP/1.1 101 Switching Protocols
Connection: Upgrade
Upgrade: h2c

[  0.004] HTTP Upgrade success
[  0.005] recv SETTINGS frame <length=6, flags=0x00, stream_id=0>
          (niv=1)
          [SETTINGS_MAX_CONCURRENT_STREAMS(0x03):100]
...

@georgeu2000 h2c is not supported by any popular browsers: https://hpbn.co/transport-layer-security-tls/#proxies-intermediaries-tls-and-new-protocols-on-the-web. As @kenichi suggested, you'll have to use an alternative client to test h2c.

Thank you for all the helpful info. I want to run h2 locally over TLS using http-2 gem.
I set up TLS using a Self Signed Certificate, and I *think* it works:
curl -vk --cert lib/keys/server.pem --key lib/keys/server.key https://localhost:8080/
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 8080 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /usr/local/etc/openssl/cert.pem
  CApath: none
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / DHE-RSA-AES256-GCM-SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: CN=localhost; C=US
*  start date: Oct 15 22:41:35 2016 GMT
*  expire date: Oct 15 22:41:35 2017 GMT
*  issuer: CN=localhost; C=US
*  SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
> GET / HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.50.3
> Accept: */*
>
< HTTP/1.1 101 Switching Protocols
< Connection: Upgrade
< Upgrade: h2
<

I added the certificate exception to Chrome, and to the Keychain (OSX). But the browser hangs when making the request.
I'll try using the code from upgrade_server.rb.

is Upgrade: h2 a thing? i thought upgrades were h2c only?
also, to make sure your curl supports http2, check --version, and then use the --http2 option on your command:
$ brew install curl --with-nghttp2

...

$ /usr/local/Cellar/curl/7.50.3/bin/curl --version
curl 7.50.3 (x86_64-apple-darwin16.0.0) libcurl/7.50.3 OpenSSL/1.0.2j zlib/1.2.8 c-ares/1.12.0 libidn/1.33 nghttp2/1.15.0
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IDN IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP HTTP2 UnixSockets Metalink

# NOTE - HTTP2 in the Features list there ----------------------------------------------------^^

$ /usr/local/Cellar/curl/7.50.3/bin/curl --http2 -vk https://vux.nakamura.io:4430/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to vux.nakamura.io (<IP_ADDRESS>) port 4430 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /usr/local/etc/openssl/cert.pem
  CApath: none
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / DHE-RSA-AES256-GCM-SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=nakamura.io
*  start date: Sep  4 16:44:00 2016 GMT
*  expire date: Dec  3 16:44:00 2016 GMT
*  issuer: C=US; O=Let's Encrypt; CN=Let's Encrypt Authority X3
*  SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0x7fadb2801c00)
> GET / HTTP/1.1
> Host: vux.nakamura.io:4430
> User-Agent: curl/7.50.3
> Accept: */*
>
* Connection state changed (MAX_CONCURRENT_STREAMS updated)!
< HTTP/2 200
< content-length: 13
< content-type: text/plain
<
hello world!
* Curl_http_done: called premature == 0
* Connection #0 to host vux.nakamura.io left intact

note: the above is not an h2c upgrade. i'd have to use http:// for curl to do that and run my server without SSL. (see https://github.com/kenichi/reel/blob/h2/lib/reel/h2/server.rb#L24-L59)

OK, thanks for all the help. Yes, I forgot the --http2 flag on curl. And yes, I have 7.50.3 which supports it.
curl with http2 seems to be working. Getting closer...
curl -vk --http2 --cert lib/keys/sehttps://localhost:8080//server.key h
*   Trying ::1...
* TCP_NODELAY set
* connect to ::1 port 8080 failed: Connection refused
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /usr/local/etc/openssl/cert.pem
  CApath: none
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / DHE-RSA-AES256-GCM-SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: CN=localhost; C=US
*  start date: Oct 15 22:41:35 2016 GMT
*  expire date: Oct 15 22:41:35 2017 GMT
*  issuer: CN=localhost; C=US
*  SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
> GET / HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.50.3
> Accept: */*
>
< HTTP/1.1 101 Switching Protocols
< Connection: Upgrade
< Upgrade: h2
<
d	_�I|����message from server
* TLSv1.2 (IN), TLS alert, Client hello (1):
* Curl_http_done: called premature == 0
* Connection #0 to host localhost left intact


Fix glass tests for NDK r11c and fix androidtest.cmd

The new gdb version in the NDK r11c formats the locals slightly different.
androidtest.cmd wouldn't work properly running all tests if any flag was
specified but /Tests was not because when using shift, the 0th argument was
being discarded, and hence %~dp0 was changed to a different value than the
script's directory.
@faxue-msft @gregg-miskelly @chuckries

Otherwise LGTM.

@gregg-miskelly can you merge it if it looks good now? Thanks.


autocomplete="false" not work on Microsoft Egde

Hi all!
I found 1 bug on ng2-select, we can not disable autocomplete on Microsoft Egde by autocomplete="false" so I change source from autocomplete="false" to autocomplete="off"
It's work OK
Thanks

Hi there!
I have continued to develop the project in my fork: https://github.com/optimistex/ngx-select-ex
Try it.
The general maintainers of the project ng2-select have no activity. And all pull requests are ignored, check it yourself.

Hi @baonguyenyam , Can you tell me how to resolve this issue?


Use a named gemset and bundle install before running tests

Coverage remained the same at 100.0% when pulling 8dafca0149a8ed8a600a068b5251b6c8f6e73336 on jammycakes:master into 7b3e5a2dcbac93660380b394343d3305a097c1dd on ukparliament:master.


Creating nodes with Vorto properties from code

Hey,
I am trying to create nodes from code. These nodes have e.g VortoTextField (aka TextString wrapped in Vorto).
Are there any guidelines on how to set the values for all languages?
I found this: #9 , but maybe there were some changes regarding the model classes (VortoValue still seems to be internal)

See #9 , I added a comment for creating content in stead of updating. I did edit the VortoValue class to have a public constuctor.
For all languages you could query all the languages as usual and just add them to the VortoValue model with corresponding values.

Have made VortoValue constructor public to help with this


chore: update ginkgo go omega

Updated ginkgo from v2.1.4 to v2.5.1
Updated gomega from v1.20.0 to v1.24.1
Closes #1095
Signed-off-by: Jonathan Gonzalez V<EMAIL_ADDRESS>

/ok-to-merge


[Improve] Improve streampark-spark module based on [3.5 Concurrent Processing]

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
[Improve] Improve streampark-spark module based on 3.5 Concurrent Processing
Usage Scenario
No response
Related issues
#2986
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

N.A


Analyst Dashboard - Filters V2

User Story
As an analyst,
I want to filter applications
so that I can easily find them
Acceptance Criteria
Filter fields

Field
Type
Domain
MaxLength

CCBC ID
text
-
6

Intake #
Dropdown
List of existent intakes
-

Status
Dropdown
List of implemented statuses
-

Project name
Text
-
60

Oraganization
Text
-
60

Lead
Dropdown
Full list of analysts
-

Package
Dropdown
List of existent packages
-

Page behaviour
Filter by button
Filter icon: https://fontawesome.com/icons/filter?s=solid&f=classic
Icon & text colour: #3F5986
Button colour: #3F5986 16%

[ ] Show filter panel (1st click):
Given the filter panel is hidden
When I click on the "Filter by" button
Then the filter panel slides down css {transition: all .5s ease-in-out;}
And the filter by button changes to selected (#3F5986 50%)

[ ] Hide filter panel(2nd click):
Given the filter panel is visible
When I click on the "Filter by" button
Then the filter panel slides up css {transition: all .5s ease-in-out;}
And the filter by button changes back to (#3F5986 16%)
And the applied filters are reseted

Apply Filter Behaviour

[ ] The results table will be only updated when I click on the "Apply" button
[ ] When I press the "Enter" key, the filter form is submitted
[ ] Show "Number of results" after a filter is applied
[ ] Sort order is kept when filters are applied
[ ] For text input filters, the "space" character has the same behaviour as any other character
[ ] Filtering by two or more fields, they will be combined by an inclusive clause (status="Received" AND organization="TELU")

Clear Filter

[ ] The form will be reset
[ ] The results table will reset
[ ] The current sort will maintain

Design
Figma Wireframe - Dashboard - Filter V2
▶ Slide down prototype
Filter button

Filter button + Filter Panel

Technical Refinement:

DB:
Middleware:
Front-end:
Tests:
Documentation:

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @VB-at-Bis


Upgrade reply to 0.5.1

Fix #337

Codecov Report

Merging #338 (e65f65a) into develop (011e148) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #338   +/-   ##
=========================================
  Coverage   99.967%   99.967%
=========================================
  Files           36        36
  Lines         3085      3085
=========================================
  Hits          3084      3084
  Misses           1         1

Merged, thanks for this!


Added log information of performance of inference of decoding, if bat…

…ch_size=1 log average latency performance, if batch_size>1, log throughput performance

Great thanks, this is very helpful!


ci: Fix preview deployment cleanup error

Is this still a problem? Did https://github.com/cardstack/gh-actions/pull/16 fix this?

oops ya thanks!


[Core][C++] resolve method host conveniences

Description
Closes https://github.com/OpenAssetIO/OpenAssetIO/issues/849.
Previously, the only interface to resolve assumed a batch of entity references with success/error callbacks executed for
each element. This is somewhat clunky when only resolving a single reference in particular, and requires significant boilerplate.
So add convenience overloads that present the API in a friendlier and more versatile manner.
As resolve conveniences in C++ and Python are going to be somewhat distinct, add C++ tests to verify behaviour of variant and exception error modes.

@feltech The additional changes we discussed :

https://github.com/OpenAssetIO/OpenAssetIO/pull/864/commits/c8863e68797218aa74e134d432fd61368c2d8790 : Make it clear whether singular/batch resolve is being called in the WHEN
https://github.com/OpenAssetIO/OpenAssetIO/pull/864/commits/f05b24a6f7acef208e7305477c36cd2d7bbf6857 : Add the move of BatchElementErrorCallback to release notes
https://github.com/OpenAssetIO/OpenAssetIO/pull/864/commits/857b0548c0a33a03fad19cc99a824fe3e4076b06 : Wrap the exceptions that go over the character limit with the added export tag.

Further changes, as discussed @feltech

Made tag dispatcher a const-ref : https://github.com/OpenAssetIO/OpenAssetIO/pull/864/commits/f002f7665d787c7d96c1a6468350c1b528724a32
Mentioned that the copyability of BatchElementError is only a C++ change. https://github.com/OpenAssetIO/OpenAssetIO/pull/864/commits/f0ee4faed87aae85fca1ef7dda41fe2fbe8abe0e


Add from_raw_parts style interfaces to RelPtr and ArchivedBox

Discussed the need for this on Discord. Draft for now so I can prototype with it in protoss and make sure it works as expected/is necessary.
Also snuck in a ignore /tmp directory in .gitignore, a moderately common pattern which I use is to have rust-analyzer compile into a separate target directory so that it doesn't conflict with regular cargo builds.

:ohno: nightly compiler ICE-ing

Marked ready for review since it seems to work for what I want it to in protoss, though hasn't been super thoroughly tested. Maybe worth a MIRI run through :)
Not sure why it would cause the compiler to ICE.... I guess I'll just try rerunning and see if it was a fluke lol.

Seems the ICE is the same on rkyv without this commit on latest ntightly. Filed https://github.com/rust-lang/rust/issues/102978 to track it...

The relevant ICE was in theory fixed, so should be good to go now :)


Unable to create commits on my forked repository

patch2pr sounds really handy! I am having some troubles getting started though.
This is the command that I am running:
patch2pr -repository replit/pyright-extended -fork -no-pull-request changes.patch

My understanding is that:

It creates a fork of replit/pyright-extended on my account arunsathiya
Commits the patch

And without the -no-pull-request flag, it submits a PR too, to upstream replit/pyright-extended.
But the command's failing with this error:
error: commit failed: create tree failed: POST https://api.github.com/repos/arunsathiya/pyright-extended/git/trees: 404 Not Found []

This may be because the repository does not exist or the token you are using
does not have write permission. If submitting a patch to a repository where you
do not have write access, consider using the -fork flag to submit the patch
from a fork.

I have tried the following command too, but it fails with the same error after creating the fork:
patch2pr -repository replit/pyright-extended -fork-repository arunsathiya/pyright-extended -no-pull-request changes.patch

I see the same behavior with the following types of tokens:

repo classic token
Fine-grained token with administration (which is required for forking), contents (for committing changes) and pull requests

My understanding is that the 404 response on the Git data endpoints is due to permission issues, but maybe it is caused in other situations as well.
Since the fork exists now, can you try this command, which should eliminate any issues due to creating a fork?
patch2pr -repository arunsathiya/pyright-extended -no-pull-request changes.patch

Could you also verify that the fine-grained token either works for all repositories or includes the arunsathiya/pyright-extended repository? Since you saw the same error with a classic token, I'm guessing this is not the issue, but I'd like to confirm.
It might also help if you can share the patch you are trying to apply, in case the error is caused by the patch contents.

Since the fork exists now, can you try this command, which should eliminate any issues due to creating a fork?
patch2pr -repository arunsathiya/pyright-extended -no-pull-request changes.patch

Same issue, unfortunately, with the repo classic token.

Could you also verify that the fine-grained token either works for all repositories or includes the arunsathiya/pyright-extended repository?

Tested with a new fine-grained administration token and it seems to work fine for this repository and all other repositories I have so far. I haven't tried invoking the git endpoints manually with a contents token though, because I am not familiar with that endpoint yet.

It might also help if you can share the patch you are trying to apply, in case the error is caused by the patch contents.

It's a fairly straightforward change, here:
changes.patch

Thanks for sharing the patch - I think that's the source of the problem. Please try granting read and write access to "Workflows" with your fine-grained token or adding the workflow scope to your classic token.
I've found this is inconsistently documented in GitHub's API docs [^1], but modifying workflow files for GitHub Actions requires additional permissions that are not needed to modify other types of files in the same repository. I believe this is a security measure to reduce the risk of unauthorized changes to workflows, but it's surprising when you encounter it for the first time and easy to forget.
[^1]: For instance, the Repository permissions for "Contents" page notes this additional permission on the endpoints for updating refs, but not on the other Git endpoints.

Bingo, that's it! Thank you, @bluekeyes. 😄


Colorshake: Mode names can be hard to read

Needs a black box drawn behind the mode text

Tried the black box. Didn't really help. There are only three modes with any issue: shake and the two shock modes. Shake it overlaps a little but isn't hard to read. Shock, the problem is that the "sound fx" pop up over the mode name. This is a bigger deal when the Shock modes are first in the list.

Moved sound fx behind mode name, tweaked battery so it looks better.


Fix keyvault

Summary

Fix the 'property not found' bug when secrets are specified.
Update the doc of sample project.

Issue Type

Bug fixing

Starter Names

key vault spring boot starter

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

See the complete overview on Codacy


[FEATURE] change caret and placeholder colour

Description
This issue just applies to the input range radius

caret and placeholder colors should be -> var(--text-color)

Screenshots

Are you willing to work on this issue ?
None

Can I work on this issue?

Hey @Dun-sin could you please assign me to this issue

Can I work on this issue?

Sure, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@avibiradar100 please raise a PR today, else you will be unassigned

Hello @Dun-sin , Can you assign this issue to me?

Hello @Dun-sin , Can you assign this issue to me?

Sure, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions on the discord server. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@Dun-sin

I am not able to see caret

@Dun-sin  I am not able to see caret

yeah, that's what the issue fixes, change the color and you will

I am sorry, I am not able to understand what I have to do

I am sorry, I am not able to understand what I have to do

Do you know what a caret is and how to change it?

My question is why cant i view that input box fully ? I know variables in css and I know how to change colors of caret and place holder

My question is why cant i view that input box fully ? I know variables in css and I know how to change colors of caret and place holder

Because it's designed that way, technically it's just a number so the input box doesn't need to be big like the rest at the top.
Did you try changing the colors first and seeing if that did anything? Because as I said that's the point of the issue.

:tada: This issue has been resolved in version 2.75.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[chore] Upgrade kompose from v1.26 to v1.27

Current Behavior

Currently this project uses kompose at v1.26.
Desired Behavior

Just a few days ago, kompose released a new version at v1.27. This doesn't have to be an immediate upgrade, as we will need to check to make sure everything is passing before merging the PR.

Resources

Alternatives / Additional Context

Update:
kompose just migrated to use compose-go but this has not been released yet.
calling kompose locally will work to some effect within meshkit, but this also means downgrading or keeping Kubernetes API packages at around v0.22.
bumping this as to keep an eye on the project

Done


Add a system for deprecating and warning users to migrate from old config options

Motivation
As a user,
I want to be alerted to changing in the chef config file format
so that I can update my client config.

As a developer,
I want to be able to update the client config format without breaking users
so that I can refactor legacy code.

Specification
Provide a mechanism similar to the our resource deprecations, but specific to chef-config for alerting on legacy configs and giving users information on how to update their configs.
Downstream Impact
All projects that consume chef-config.

Closing this out as something that we're not going to be working on anytime soon


pulls @import rules to the top of the stylesheet

fixes #142
Note: this is a naive first attempt to fix this issue, because its breaks our production SPAs ATM :)

It seems to break on ff 43
Firefox 43.0.0 (Windows 10 0.0.0) StyleSheet prepends @import rules FAILED
A parameter or an operation is not supported by the underlying object
rules/<@index.js:10554:89
rules@index.js:10553:5
@index.js:55840:17
https://travis-ci.org/threepointone/glamor/builds/182789081
I'll have a look in a bit, unless you have an idea

Mh thats strange. I tested it on ff 50 and (now) 43 and it works in dev/speedy mode for a real project, but fails in the karma test.
Its related to this line:
tag.insertBefore(document.createTextNode(rule), tag.firstChild)

If I change tag.firstChild to null it stops throwing. tag.firstChild contains a text node in all browsers (phantom, chrome and FF) but I really I have no idea why it throws this error for firefox :/

Don't worry, I'll have a little look, just FYI it means guy not release
today tho :(
On Sat, 10 Dec 2016 at 2:11 PM, Benjamin Otto<EMAIL_ADDRESS>wrote:

Mh thats strange. I tested it on ff 50 and (now) 43 and it works in
dev/speedy mode for a real project, but fails in the karma test.
Its related to this line:
tag.insertBefore(document.createTextNode(rule), tag.firstChild)
If I change tag.firstChild to null it stops throwing. tag.firstChild
contains a text node in all browsers (phantom, chrome and FF) but I really
I have no idea why it throws this error for firefox :/
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/threepointone/glamor/pull/151#issuecomment-266190302,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABJePlY5CsXh8Z1svt02hlIIuQCsOaqks5rGmWogaJpZM4LI1If
.

It works for me in this fiddle in ff43&ff50. Really weird :/
Maybe I will look into it this afternoon :)

ok I think I figured this out. adding an import rule in firefox makes cssRules be an indeterminate object for a tick, while it finishes parsing. in the test, we read rules() syncly, which causes this error. the fix is simply to fix the test.


Bug fix for 'ValueError: field 6 out of range (need a 48-bit value)'

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

View a preview at https://prompt.ws/r/Azure/azure-cli/5644
This is an experimental preview for @microsoft users.

Closes https://github.com/Azure/azure-cli/issues/5184

uuid1 is preferred since that uses the device MAC address but since that can raise a ValueError, we'll fallback to uuid4 which is just a random UUID.
Also, they both give the same format so there'll be no noticeable difference:
$ python
>>> import uuid
>>> uuid.uuid1()
UUID('49abe71e-17fe-11e8-8731-6a0000ab8250')
>>> uuid.uuid4()
UUID('5229405e-6207-4fa8-a36e-98df6e9cf527')
>>>

https://docs.python.org/3/library/uuid.html#uuid.uuid1
https://stackoverflow.com/questions/1785503/when-should-i-use-uuid-uuid1-vs-uuid-uuid4-in-python


hack,Makefile: Support overriding the script package path in the update-codegen script.

Currently the ./hack/update-codegen.sh script is hardcoded to use the operator-framework/operator-metering package path, which breaks in the case we move this repository to another organization.
This adds support for overriding the $SCRIPT_PACKAGE variable, changing it to use the value of the $GO_PKG environment variable, and if that variable is unset, e.g. in the case of running the script directly, it defaults to the current github.com/<organization_name>/<repository_name>.
In the case where you want to override the value of the $GO_PKG environment variable, you would do something similar to the following:
make verify GO_PKG="github.com/<some org name>/<some project name>

/hold

/hold cancel
/skip ci/prow/metering-e2e-aws

Tested with:
$ cat Makefile
all:
	SCRIPT_PACKAGE=$(GO_PKG) ./hack/verify-codegen.sh
$ cat hack/verify-codegen.sh
#!/bin/bash
./hack/update-codegen.sh
$ cat hack/update-codegen.sh
#!/bin/bash
SCRIPT_PACKAGE=${SCRIPT_PACKAGE:-"github.com/operator-framework/operator-metering"}
echo $SCRIPT_PACKAGE
$ make GO_PKG="github.com/bentitopolis/operator-metering"
SCRIPT_PACKAGE=github.com/bentitopolis/operator-metering ./hack/verify-codegen.sh
github.com/bentitopolis/operator-metering
$ make
SCRIPT_PACKAGE= ./hack/verify-codegen.sh
github.com/operator-framework/operator-metering```

/lgtm

/override ci/prow/metering-e2e-aws


Enable vLLM Gaudi Support for LLM Service

Description
This PR enabled the vLLM Gaudi support for LLM service, which will be converted to a formal pull request until the habana team officially releases the vLLM support.
Issues
n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[x ] New feature (non-breaking change which adds new functionality)

This PR enabled the vLLM Gaudi support for LLM service.

Dependencies
n/a.
Tests
This PR is tested in the Gaudi2 server with:
2 sockers Intel(R) Xeon(R) Platinum 8368 CPU @ 2.40GHz
8 Gaudi nodes, HL-SMI Version: hl-1.14.0-fw-<IP_ADDRESS> Driver Version: 1.14.0-9e8ecf8

vLLM Gaudi Service

Client Curl Test

This draft PR has been submitted here. Please have a review and check. @Jian-Zhang

Please refer to this new PR based on the officially habana vLLM: https://github.com/opea-project/GenAIComps/pull/137


Setting the locale in the server context (SSR) does not work in production build

We have a very simple code that works perfectly on client side, but fails on the server side on a production build.
This does not happen when using the dev server though.
Code
export default defineNuxtRouteMiddleware(() => {
  const { locale } = useNuxtApp().$i18n;
  const dayjs = useDayjs();

  if (locale.value !== dayjs.locale()) {
    console.log("Setting dayjs locale to", locale.value);
    dayjs.locale(locale.value);
    console.log("Dayjs locale is now set to", dayjs.locale());
  }
});

Output
Setting dayjs locale to de
Dayjs locale is now set to en

Here I'd expect the server to put out "de" twice, but setting the locale simply does nothing.
Config
  locales: i18nConfig.locales,
  plugins: ["localeData", "localizedFormat", "utc", "customParseFormat"],
  defaultLocale: 'en',

does the console say anything about hydration miss match issues? also i wouldn't full trust the dev server without giving it a build first 😅

Like I said it's not happening in the dev server but only in the build version. And I can see the backend content being rendered in the pages source in the English locale, but being overridden by the client side once hydration happens.
But client side and hydration are not important here, I can't get the server to render any non-en locale dates when using the built version.

Same issue

Same issue, different locales between SSR and Client.
Temporary workaround (copy the locale you wan't from the dist folder):
`import dayjs from 'dayjs';
dayjs.locale({
name: 'nl',
weekdays: 'zondag_maandag_dinsdag_woensdag_donderdag_vrijdag_zaterdag'.split('_'),
weekdaysShort: 'zo._ma._di.wo.do.vr.za.'.split(''),
weekdaysMin: 'zo_ma_di_wo_do_vr_za'.split(''),
months: 'januari_februari_maart_april_mei_juni_juli_augustus_september_oktober_november_december'.split(''),
monthsShort: 'jan_feb_mrt_apr_mei_jun_jul_aug_sep_okt_nov_dec'.split(''),
ordinal: n => [${n}${n === 1 || n === 8 || n >= 20 ? 'ste' : 'de'}],
weekStart: 1,
yearStart: 4,
formats: {
LT: 'HH:mm',
LTS: 'HH:mm:ss',
L: 'DD-MM-YYYY',
LL: 'D MMMM YYYY',
LLL: 'D MMMM YYYY HH:mm',
LLLL: 'dddd D MMMM YYYY HH:mm'
},
relativeTime: {
future: 'over %s',
past: '%s geleden',
s: 'een paar seconden',
m: 'een minuut',
mm: '%d minuten',
h: 'een uur',
hh: '%d uur',
d: 'een dag',
dd: '%d dagen',
M: 'een maand',
MM: '%d maanden',
y: 'een jaar',
yy: '%d jaar'
}
}
)
export default dayjs`

Any news on this ? Thank you.

Seems to be an issue i'm having also on a side project i'm building, https://huishistorie.nl/amersfoort/3822cg/bombardonstraat/132
As soon as i change stuff like this:
{{ $dayjs(homeDataStore.homeData.energy.expiry_date).format("D MMMM YYYY") }}

To:
{{ homeDataStore.homeData.energy.expiry_date }}

From the template my hydration error on the frontend disappears. Haven't seen it in dev builds as mentioned above by @PatrickBauer

Same issue, but in dev mode too. In ssr dayjs defaults to "en" locale even when explicitly set to another.

I can confirm this issue... very annoying and resulting in "Hydration completed but contains mismatches." errors in console in production builds!

Same issue with defaultTimezone. SSR does not use it.  In ssr dayjs using utc timezone and after that I see  hydration error because I have another timezone

I created a plugin and followed the initial implementation:
// Skip the type issues for a moment
export default defineNuxtPlugin({
  name: "locale",
  async setup(nuxtApp) {
    const dayjs = nuxtApp.$dayjs;
    const i18n = nuxtApp.$i18n;

    console.log("dayjs.locale", dayjs.locale());
    console.log("i18n.locale", i18n.locale.value);

    dayjs.locale(i18n.locale.value);
  },
});

Both are set to "en" on the server, but dayjs outputs "tr" after hydration. It is still rendered in English, by the way.

Got here because I have the same issue.
"dayjs-nuxt": "^2.1.11",

The core problem lies in the fact that these locales do not exist when they are called during SSR. My temporary solution involves extracting locale configurations directly from the Day.js source, storing them in separate files within my application, and passing them as arguments to dayjs.locale(). Once the page finishes loading, I swap these temporary locales with the actual ones.
This approach does have potential discrepancies if locales are updated or dayjs configurations change significantly. However, as long as you stick to the same Day.js version, this method works reliably. To avoid conflicts with standard locales, name the temporary locales distinctly, such as frSSR instead of just fr.

To make locale config available dayjs requires import with side-effects (like import 'dayjs/locale/ru.js'). It seems that imports without binding to a variable are lost on nuxt build.
Current workaround for my case:
./composables/dayjs.ts:
import dayjs from 'dayjs'
import locale from 'dayjs/locale/ru'
import relativeTime from 'dayjs/plugin/relativeTime'

dayjs.extend(relativeTime)
dayjs.locale('ru', locale)

export function useDayjs()
{
    return dayjs
}

To use:
const dayjs = useDayjs()

Thank you @Trash0101 and @dpetrouk for sharing your solutions.
For anyone having an internationalized site, I'd suggest creating an i18n plugin and adding the workaround like this:
import locale_hu from 'dayjs/locale/hu';
import locale_en from 'dayjs/locale/en';

export default defineNuxtPlugin((nuxtApp) => {
    const localeFiles = {
        hu: locale_hu,
        en: locale_en,
    };

    nuxtApp.hook('app:created', () => {
        nuxtApp.$dayjs.locale(nuxtApp.$i18n.locale.value, localeFiles[nuxtApp.$i18n.locale.value]);
    });

    nuxtApp.hook('i18n:beforeLocaleSwitch', ({ oldLocale, newLocale, initialSetup, context }) => {});

    nuxtApp.hook('i18n:localeSwitched', ({ oldLocale, newLocale }) => {
        nuxtApp.$dayjs.locale(newLocale);
        // change locale of other dependencies
    });
});

"dayjs-nuxt": "^2.1.11",


"use strict" in a class

Hi,
When targeting ES5 and using --noImplicitAny, the following is a type error:
class foo {
    "use strict";
}

Variable '"use strict"' implicitly has an 'any' type.
Why is this a type error?  TypeScript seems to handle "use strict"; within function scopes, including the class constructor.  However, allowing "use strict" as the first line in the class would allow the entire emitted IIFE to work in strict mode.  As it is today, this "use strict"; is erased by the compiler.
As a side issue, I searched the TypeScript 1.4 language spec doc and "use strict" does not occur in it.
Thanks!

This defines a class with a member named use strict (see the emitted code when you give it an initializer, e.g. 'use strict' = 4;).
"use strict" in a class isn't supported; you can put this at a module or file level instead. ES6 classes are strict by default so I don't think we'd bother plumbing in a special case for downlevel emit here.

Thanks.  Module or file level it is.


[FEATURE] Validate max length (also integers and similar)

Description:
I'd argue that validating that a integer is 10 (example) characters of length, should be core functionality. Sure, it can be done by looking at e.g. digits, and having it be between 0 and<PHONE_NUMBER>.. but that seems excessive.
So, I propose maxlength validation. Something like this:
protected function validateMaxLength($attribute, $value, $parameters)
{
    $this->requireParameterCount(1, $parameters, 'maxlength');

    return mb_strlen($value) <= (int) $parameters[0];
}

Usage
'number' => 'integer|maxlength:10',
'name' => 'string|maxlength:10' // Yes, you should use max here, but its just to show that it can be used here as well

It's mostly useful for integers/digits, as specifying "integer" in the rules, will make max validate the value, not the length.
I've also written a short article about it, showing how it works using custom rules: https://lasserafn.com/validating-max-length-laravel-strings-integers-digits/
I think this could improve the experience of validation, especially for newcomers. I remember being confused with max and integers. Providing a maxlength makes it quite straightforward and easy to understand and remember (as its the same parameter used for HTML inputs)
I'd submit a PR; but first let me know if this could potentially be merged.

For suggestions and feature requests please use the https://github.com/laravel/internals repo.


CQL Approach for FHIR Core

CQL (Clinical Quality Language) is the HL7 standard for providing logic execution for decision support and clinical quality measures. CQL allows for a more modular, flexible, and robust expression of the logic. It allows logic to be shared between measures and with clinical decision support. CQL provides the ability to express logic that is human-readable yet structured enough for processing a query electronically. The CQL standards are located on the HL7 Website: CQL Specification. CQL Examples can be found here
Our initial goal is to design and implement a  CQL Library to demo the below functionality

Generate a MeasureReport via $measure operation
Load and execute a custom CQL library for decision logic
Transform a PlanDefinition to a CarePlan using $apply operation

Main use cases to model

How to programmatically implement Apply operation i.e. Use the $apply_operation to generate a CarePlan from a PlanDefinition
Generate a MeasureReport by running the $measure_operation

Related subtasks

[ ] Research CQL Integration sample app #52
[ ] Apply Operation - HAPI FHIR server vs CQF Lib #13
[ ] Patient CarePlan generation / Apply operation #100
[ ] Create a Plan Definition for the Covax App #101

Related FHIR Core projects
1. Notice D  - mADX
The project description can be found here.
CQL Workflow  will entail:
Indicator 1: Percentage of antenatal women with 1st ANC contact  in 1st trimester (before 12 weeks)
Underlying Data:
Patient - Must be a woman (sex = F)
ANC Contact 1:

Observation determining that she is pregnant
Observation determining the Estimated Date of Delivery
Encounter Date

Calculation Narrative:

Search for any patient in the system that is a female and determined to be pregnant and save this as the denominator
For each pregnant woman, search for the first ANC encounter.
For each “first ANC encounter” that’s returned, compare the encounter date against the Estimated Date of Delivery
Return true for this patient if the encounter date is less than the estimated date of delivery minus 6 months

We are trying to build a CQL Library POC with Bryn Rhodes under the WHO ANC CDS.
2. G6PD
The project description can be found here.
CQL Workflow in G6PD will entail:

Press a button in the UI of the host application to start the clinical workflow

The host application generates a ServiceRequest and sends it to intent in the IPE SDK - Computer Vision/ML Kit version

The camera is activated and the user walks through the image capture - Computer Vision/ML Kit version

The IPE SDK evaluates the result and passes as DiagnosticReport with the result, patient reference, and image to the CQL logic module

The CQL logic module performs the evaluation and returns the result as an augmented DiagnosticReport.This will be achieved by running a service request to trigger a diagnostic report. Clinical Quality Language (CQL) evaluation will be used to give a recommendation for the next steps for treatment if the G6PD levels are not within the allowable threshold.

ANC  - Rwanda POC - TBD
CQL Workflow will entail: TBD

After reading the documentation of CQL, here are some questions that need an answer:

What will be the conditions to generate a CQL library for Care Plan / $Apply Operation?
What will be the conditions to generate CQL for measure report?
How will we sync it to server?
Where will we write CQL library(CQL expressions that will be created based on our conditions)?


"contentLoaded" is not fired on Android Chrome Browser after clearing cache.

Description
"contentLoaded" is not fired on Android Chrome Browser after clearing cache.
Steps to check or reproduce

Open "/test/manual/PanoViewer/PanoVideo.html" with Android Chrome Browser (Android 6.0.1, Chrome 64)
Settings -> Privacy -> Clear history
Reload page.

It does not fire "contentLoaded" event.

It's related with
https://github.com/naver/egjs-view360/pull/146
_onContentLoad(image) {
	this._imageIsReady = true;

	if (this._isVideo) {
		this._image.addEventListener("loadeddata", () => {
			this._triggerContentLoad();
		});
	} else {
		this._triggerContentLoad();
	}

	return true;
}

https://github.com/naver/egjs-view360/pull/145
class VideoLoader {
	constructor(video) {
		this._handlers = [];
		this._sourceCount = 0;

		// on iOS safari, 'loadeddata' will not triggered unless the user hits play,
		// so used 'loadedmetadata' instead.
		this._thresholdReadyState = READY_STATUS.HAVE_METADATA;
		this._thresholdEventName = READYSTATECHANGE_EVENT_NAME[this._thresholdReadyState];

		this._loadStatus = (video && video.readyState) || READY_STATUS.HAVE_NOTHING;

		this._onerror = this._onerror.bind(this);

		video && this.set(video);
	}

Current Guide (2018-02-22)

contentLoaded

loadeddata

ready

webgl init & image decoding

We decided to remove contentLoad event. because it's not render's role to check video loaded status. But It checks status minimally to know it's valid video contents.
And ready event does not guarantee video is loaded. it gaurantee it is valid video and video texture is binded.


(retro) Add documentation on credentials and configurations

Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Indicate to all developers on the team the required credentials and secrets used in the app.

Let me know if this is sufficient, or what additional information you would like to see.

I like it, its only missing the part about the codepush key for android, that needs to be in the strings.xml file for the codepush updates to be looked up when the app is launched that cant be encrypted as its not a file.
Maybe also a little more of a detailed explanation of how to specify an environment when archiving with code.
I might be a little confused as i have never had different environments to archive so maybe a small explanation on how to do that. I think that should be all.

@Nashmod could you update the document with that information about codepush on android? I haven't done it myself.
Archiving different environment setups is a matter of using a different xcode scheme. You can read more about schemes, but I don't think it's necessary to put here as it's not specific to our project. Do you think it is worth putting in?

@Nashmod where is the push to update the strings.xml, could you update the readme created here to indicate the information missing (per your first comment)?


Binance US Support?

Really cool project!
I'm a binance customer in New Jersey, USA, and when I try to sign up for binance it tells me that I can only use "binance.us" which seems to have a lot fewer available cryptos...
Is there any way to be able to swith this to use binance us data? or filter for just binance.us things?

Hey! This is not a currently supported feature. This bot was developed by a USA based dev before the geo fencing was strictly enforced and was typically run via vps in Tokyo anyway to be as close as possible to Binance. So there might be a way to change the host and underlying calls to binance.us by configuring our underlying api wrapper (https://github.com/jaggedsoft/node-binance-api) but I haven't looked into this

ah ok. it is a cool project regardless.
thanks. 👍


I downloaded file with cookies (private video) but fter downloaded an merged there is no file saved.

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I am using the cookies to download private videos  but at the the and there is no file save . I says combined buy I can find the save files.
When I try again it says file has been already downloaded
yt-dlp -f 'bestvideo[height<=480]+bestaudio/best[height<=480]' --cookies-from-browser chrome --cookies cookies.txt  https://www.youtube.com/watch?v=_xxxxxxxx
[Cookies] Extracting cookies from chrome
[Cookies] Loading cookie      0/    93WARNING: cannot decrypt v11 cookies: no key found
[Cookies] Extracted 0 cookies from chrome (93 could not be decrypted)
[youtube] Extracting URL: https://www.youtube.com/watch?v=_xxxxxxxxxx
[youtube] _pdeQo1P2do: Downloading webpage
[youtube] _pdeQo1P2do: Downloading ios player API JSON
[youtube] _pdeQo1P2do: Downloading android player API JSON
[youtube] _pdeQo1P2do: Downloading m3u8 information
[info] _pdeQo1P2do: Downloading 1 format(s): 243+251
[download] Destination: 20230715 [_pdeQo1P2do].f243.webm
[download] 100% of  229.83MiB in 00:01:35 at 2.39MiB/s
[download] Destination: 20230715 [_pdeQo1P2do].f251.webm
[download] 100% of  170.71MiB in 00:01:09 at 2.45MiB/s
[Merger] Merging formats into "20230715 [_xxxxxxxxx].webm"
Deleting original file 20230715 [_pdeQo1P2do].f251.webm (pass -k to keep)
Deleting original file 20230715 [_pdeQo1P2do].f243.webm (pass -k to keep)
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[youtube] _pdeQo1P2do: Downloading android player API JSON
[youtube] _pdeQo1P2do: Downloading m3u8 information
[info] _pdeQo1P2do: Downloading 1 format(s): 243+251
[download] 20230715 [_pdeQo1P2do].webm has already been downloaded
(venXDiarizeWisp) (base) alp2080@alp2080:~/data/WORKS/RD$ yt-dlp -vU 'test:youtube'
[debug] Command-line config: ['-vU', 'test:youtube']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[812cdfa06] (pip)
[debug] Python 3.10.10 (CPython x86_64 64bit) - Linux-5.8.0-34-generic-x86_64-with-glibc2.31 (OpenSSL 1.1.1t  7 Feb 2023, glibc 2.31)
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.18.0, brotli-None, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-11.0.3
[debug] Proxy map: {}
[debug] Loaded 1851 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
ERROR: You installed yt-dlp with pip or using the wheel from PyPi; Use that to update
[TestURL] Extracting URL: test:youtube
[TestURL] Test URL: https://www.youtube.com/watch?v=BaW_jenozKc&t=1s&end=9
[youtube] Extracting URL: https://www.youtube.com/watch?v=BaW_jenozKc&t=1s&end=9
[youtube] BaW_jenozKc: Downloading webpage
[youtube] BaW_jenozKc: Downloading ios player API JSON
[youtube] BaW_jenozKc: Downloading android player API JSON
[youtube] BaW_jenozKc: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] BaW_jenozKc: Downloading 1 format(s): 248+251
[download] youtube-dl test video ＂'⧸⧹ä↭𝕐 [BaW_jenozKc].webm has already been downloaded
(venXDiarizeWisp) (base) alp2080@alp2080:~/data/WORKS/RD$
(venXDiarizeWisp) (base) alp2080@alp2080:~/data/WORKS/RD$ yt-dlp -vU 'test:youtube'
[debug] Command-line config: ['-vU', 'test:youtube']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[812cdfa06] (pip)
[debug] Python 3.10.10 (CPython x86_64 64bit) - Linux-5.8.0-34-generic-x86_64-with-glibc2.31 (OpenSSL 1.1.1t  7 Feb 2023, glibc 2.31)
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.18.0, brotli-None, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-11.0.3
[debug] Proxy map: {}
[debug] Loaded 1851 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
ERROR: You installed yt-dlp with pip or using the wheel from PyPi; Use that to update
[TestURL] Extracting URL: test:youtube
[TestURL] Test URL: https://www.youtube.com/watch?v=BaW_jenozKc&t=1s&end=9
[youtube] Extracting URL: https://www.youtube.com/watch?v=BaW_jenozKc&t=1s&end=9
[youtube] BaW_jenozKc: Downloading webpage
[youtube] BaW_jenozKc: Downloading ios player API JSON
[youtube] BaW_jenozKc: Downloading android player API JSON
[youtube] BaW_jenozKc: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] BaW_jenozKc: Downloading 1 format(s): 248+251
[download] youtube-dl test video ＂'⧸⧹ä↭𝕐 [BaW_jenozKc].webm has already been downloaded

it turn that linux ls command messed up with me to show the files.
dir filename shows now..
Best


getSignedUrl is not getting called...

I am using ReactS3Uploader with getSignedUrl custom function as. The onUploadStart function is getting called but no activity after that. getSignedUrl is not getting called. Any idea why is this happening? Also, what is    className={uploaderClassName} in official example?
      <ReactS3Uploader
        getSignedUrl={this.getS3SignedUrl.bind(this)}
        accept="image/*"
        preprocess={this.onUploadStart.bind(this)}
        onProgress={this.onUploadProgress.bind(this)}
        onError={this.onUploadError.bind(this)}
        onFinish={this.onUploadFinish.bind(this)}
        uploadRequestHeaders={{ 'x-amz-acl': 'public-read' }}
        contentDisposition="auto"/>

Resolved. Forget that we need to invoke callback from onUploadStart
onUploadStart(file, callback) {
console.log("uploading image file");
callback(file);
}


[WIP] Configurable Layout/UI Refactor

This PR addresses #182, #184, #185, and #186.
The biggest addition is defining a layout for Minerva that can be configured by 3rd party plugins, shown here.
Other changes include:

Removes gridster, also the map slider :facepunch:
Allowing basemap_args to be stored in the session data, so someone can switch basemaps if they want
Created a generic Panel view
Cleans/removes a lot of jade/stylus that seemed extraneous

Added some basic mixins to organize how panels are rendered

Concerns that need to be addressed before merge:

[ ] I'm largely unfamiliar with how this is being used in BSVE, and for Epidemico's work
Review from someone with their own projects would be greatly appreciated
[ ] I removed the baselayer settings button, since I removed the title bar off the map. What is the stopgap to get this merged?
[ ] The map styling is broken, it goes off the page for some reason, and resizing the window breaks the entire map
[ ] I'm somewhat uneasy about how panels are added to panel groups but wasn't entirely sure what the proper Backbone way was

Future concerns:

Storing/Loading UI state is somewhat sloppy, there may be better tools to accomodate this type of problem
Cleaning up the header panel, removing the sessions listing page
Storing the layout on the session view is sloppy, it should probably be on the model - though it seems like that will be part of a larger refactor in #225

@danlamanna can you pastry in a screenshot?

tasty, thanks.

C'mon, you couldn't get a donut logo up there @danlamanna? disappointed

@danlamanna See my changes here: https://github.com/Kitware/minerva/commit/6ede95f70703f14970c74218a501a251310897f9 to fix the map size issues.  I had to go up the div hierarchy to set all the element heights to 100%.  The only other way to so solve this is to explicitly initialize the map with a given size (and manage any and all size changes that may occur).
Note: I also changed how the stylus files are built so that I can get the header height variable inside a different file.  There are other ways to handle this, but importing (or requiring) files from a single place resembles what we should be doing with webpack.

@jbeezley Thanks for figuring that out, that was more involved than I would have expected.

resembles what we should be doing with webpack.

:microphone:  :droplet:

Yeah, I've come to see it like this.  Normally, unless otherwise stated, a parent element is only as large as the content it contains..  Trying to have an element expand to take up 100% of it's parent inverts the usual pattern, so you have to go all the way up the document tree to make it work.  There are all kind of other implications in positioning you run into as well because it disrupts the whole document flow.

I'm fine with this as is.  It's missing some features, but doesn't back us into any corners that we weren't already camping out in.

@mgrauer I'm going to make some changes and ping you back to take another look, I want to note though that a huge portion of the feedback is directly related to #225, which suggests to me that it may be one of the next things we tackle.

@mgrauer PTAL. I think I fixed most of your comments, others I responded to in this PR.

Yeah, definitely punt on anything that will be fixed as part of #225, we should just note it there.

@mgrauer See my comments on #235, aside from that I think we should consider having the panel views call initialize on their parent PanelView and we can take care of the extending of events there, that way if we want to do something else in the future things will "just work".

Forget what I said on that first PR I created.  I've created a new one #236 to merge into here.  If those are OK with you, you can merge it.
I like your idea of the panel views calling initialize on their parent PanelView.  Can you do that after you've merged #236, and also update the docs? Then I think this would be ready to go.

Alright @mgrauer - one last look.

LGTM.
Awesome work @danlamanna .  Thanks for pushing this refactor through, I think it is a big improvement in the UI and in extensibility.
We should be on the lookout for small bugs to clean up in the near future.

:confetti_ball:


Rename the container_label_tag_mapping table

Raname the container_label_tag_mappings table to provider_tag_mappings
Must be merged together with https://github.com/ManageIQ/manageiq-schema/pull/514
Cross Repo Test: https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/176

Cross Repo Tests are green


Support for storing binary objects

Hi,
I would like to pickle a Python object and then persist it to a DB, preferably PosgreSQL, I am currently using SQLAlchemy from python which is very easy. Is there support for that in sqlpp11? How do I specify this type?
Thanks,

sqlpp11 treats blobs as strings, see scripts/ddl2cpp:
   'tinyblob': 'blob',
    'blob': 'blob',
    'mediumblob': 'blob',
    'longblob': 'blob',

I just glanced at the script in the postgresql connector. That seems to be lacking in that respect, but it is trivial to add, of course.
HTH
Roland

I assume this is solved, right? Otherwise please re-open.


Fixed AdminEvent logging cs

Codecov Report

Merging #1 (0f42dd5) into main (335c529) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage   91.47%   91.47%
=======================================
  Files          17       17
  Lines         469      469
=======================================
  Hits          429      429
  Misses         40       40

Impacted Files
Coverage Δ

src/Repository/ApiKeyRepository.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335c529...0f42dd5. Read the comment docs.


Item

Description
An Item is an abstract object that can be added to an ItemList and has a standard set of properties. All more concrete items (such as Canvas will be an extension of Item with type="Canvas", etc.)
Properties

[x] @context - String or array of strings or undefined
[x] id - String
[x] type - String
[x] Array of child items.

Methods

[x] addItem()
[x] removeItem()
[x] toJSONString()

I see all of the following completed

Reopening because Item needs to implement the ItemList (#10) once we have finished it.
Linking below so we can remember to do it soon. I will take a look at it later tonight.
#10


adapt to new API

Codecov Report

Merging #82 (81b610c) into master (e201e27) will decrease coverage by 0.71%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   74.64%   73.93%   -0.72%
==========================================
  Files          10       10
  Lines        1203     1216      +13
==========================================
+ Hits          898      899       +1
- Misses        305      317      +12

Impacted Files
Coverage Δ

src/api.jl
25.35% <9.09%> (-2.99%)
:arrow_down:

src/compiler.jl
83.52% <77.77%> (-0.28%)
:arrow_down:

src/Enzyme.jl
74.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e201e27...81b610c. Read the comment docs.


Add thickness support to BezierCurve.

I am going to add the same thickness support to the BezierCurve class that I did to the Arc class.  I will make the get_segment function common and used by both.

Here is what I have so far (Blue is an Arc and Red is a Curve).  This was a fairly easy change to make.

Looks good visually.

Another question related to curves is do you want the concept of a 'closed' curve.  Basically it would be just like the closed parameter for pyglet.shapes.Arc in that it would connect the start and end with a straight line.  I don't care either way, I am just asking for completeness.

Also, I went ahead and added the pull request so you can start reviewing it.  Currently, I have just added segment support to BezierCurve and that is it.


openstack-ardana: fix URLs for failing downstream jobs

Using try-catch blocks to display the URLs of downstream jobs
in the Blue Ocean only works if the downstream job is passing.
When failing, the try-catch block will not set the needed variables
and the resulting "undefined variable" failure just eclipses the
real cause of the failure.
The correct approach is to use propagate: false when launching
downstream builds, which will complete successfully regardless of
the downstream build result, then check the result in the upstream
job.

I think I may have found a better solution (suggested here: https://groups.google.com/forum/#!topic/jenkinsci-users/KBQ5oScTY-4)

Updated with the better solution

Example build results with this patch:

failed: https://ci.nue.suse.com/blue/organizations/jenkins/openstack-ardana/detail/openstack-ardana/979/pipeline
succeeded: https://ci.nue.suse.com/blue/organizations/jenkins/openstack-ardana/detail/openstack-ardana/981/pipeline


[Bug] Renaming a “tab” from the entity explorer renames the canvas widget inside the tabs widget

Tale of the baba widget 😄

Tale of the baba widget 😄


Add docker volumes support

Add new type of backup: docker volumes!
Example:
docker://container:/path/to/volume

will inspect the container and get the real path of the volume (e.g. /mount/path)
and will backup into:
/backups/{DATE}/docker/container/path/to/volume
when restore, even if the mount path has changed, it will find the good path and restore it.

Will not be done here. Better to be integrated into a special container


Correspondence client

Description
This PR has perhaps become a bit large and unruly, but there were many interleaved concepts involved in this feature, which turned out to be difficult to separate.
Maskinporten
The MaskinportenClient has been extended to allow for a second (internal use) instance, and the possiblity of exchanging Maskinporten tokens for Altinn tokens. Some updates have been made to the data models which may be considered breaking changes.
I have also renamed HttpClientBuilderExtensions.UseMaskinportenAuthorization, but forwarded the legacy method to the new one. It's not clear to me if this is necessary or not -- it's extremely unlikely that anyone has started using this product yet.
Correspondence
The CorrespondenceClient and all associated logic/models/functionality is brand new. The implementation of this ecosystem is the main bulk of the PR.
The naming conventions for all things Correspondence could use a second pair of eyes. Perhaps especially the CorrespondenceRequestBuilder pattern naming.
Telemetry
The Telemetry class has been extended with a partial class for Correspondence, and CorrespondenceClient implements StartActivity and request counting. This does not cover all objectives in https://github.com/Altinn/app-lib-dotnet/issues/832, so more work is likely needed in this area.
Misc
Certain data that has traditionally been "stringly typed" now has their own struct types: AccessToken, OrganisationNumber and LanguageCode. Implicit operators and JSON converters have been added where applicable for current use.
Related Issue(s)

https://github.com/Altinn/app-lib-dotnet/issues/832
https://github.com/Altinn/app-lib-dotnet/issues/825
https://github.com/Altinn/app-lib-dotnet/issues/826
https://github.com/Altinn/app-lib-dotnet/issues/849
https://github.com/Altinn/app-lib-dotnet/issues/851

Verification

[x] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[x] Relevant automated test added (if you find this hard, leave it and we'll help out)
[x] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

I'm reading and trying to understand, but I have to ask. What does the builder pattern provide that we can't get by just having
public interface ICorrespondanceClient
{
    Task SendCorrespondance(CorrespondanceRequest request, CancellationToken ct = default);
}

that can be used as follows
await _correspondanceClient. SendCorrespondance(new()
{
    Sender = ...
    SenderReference = ...
    RequestedPublishTime = ...
    Recipients = [
    new(){...}
    ],
    ...
});

It is a lot of code and docstrings that we have to review for typos to get a builder pattern that we don't use for anything else.
Also 4 new exception types! Should I go through my InstanceDataUnitOfWork to add a different type for each InvalidOperationException?

And if we first are using a builder pattern. Would't it be expected that it makes immutable updates, instead of mutating the root?
var builder = new Builder().WithSender(---).WithSenderReference(...)

var message1 = builder.WithRecipient(...);
var message2 = builder.WithRecipient(...);
await client.Send(message1.Build());
await client.Send(message2.Build());

Builder pattern lets us have more/earlier validation code, and let's the caller split up initialization and have logic inbetween building up the request. So we've discussed this being beneficial when

The resulting model is large
Some props being required, some not

Re: exceptions, I can only think of benefits (callers being able to catch exceptions by concrete type or the whole category of CorrespondenceException to do custom error handling).
In general I would say the cost of maining code liks this (models and exceptions) is cheap, so I think it's worth it given the benefits


LearningPathways error

Your request to provision   "Microsoft 365 learning   pathways"    template failed!   Please report the   issue here providing the following provisioning action correlation ID:   1395e302-7607-4a4c-9ae2-5561b0031f49 !
Please provide use feedback around your used template or the   service in general by using our feedback   form . Thank you for your input advance.
Exception: {"error":{"code":"-2147467261, System.ArgumentNullException","message":"Value cannot be null.\r\nParameter name: title"}}
Provisioning action correlation ID: 1395e302-7607-4a4c-9ae2-5561b0031f49
As mentioned here: https://github.com/SharePoint/sp-provisioning-service/issues/248
the title is missing. From the URL https://provisioning.sharepointpnp.com/tenant/home/provision?packageId=3df8bd55-b872-4c9d-88e3-6b2f05344239&source=default there is no option to enter a title.

Hi,
Thanks for your feedback. What is the default locale for your tenant?
Here are the localizations that the template supports:
LCID="1033" Name="English (United States)"
LCID="1031" Name="Deutsch (Deutschland)"
LCID="1036" Name="français (France)"
LCID="1049" Name="русский (Россия)"
LCID="2052" Name="中文(中国)"
LCID="1041" Name="日本語 (日本)"
LCID="1046" Name="português (Brasil)"
LCID="3082" Name="español (España, alfabetización internacional)"
LCID="1040" Name="italiano (Italia)"

Please, eventually refer to #258 . In the meantime, I will close this item. Thanks.


Shadowrun Sixth World v.74 - 1 new feature, 2 bugfixes

[x] The pull request title clearly contains the name of the sheet I am editing.

[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).

[x] The pull request makes changes to files in only one sub-folder.

[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

[x] I have followed the Character Sheets Standards when building this sheet.

Changes / Description
Fix for matrix device stats on drag and drop for NPCs
Fix for Sprite drag and drop issue
NPCs->Grunts added a stun monitor and flag to display it (it is hidden by default)

Character Sheet Info Roll20 Internal Use only.


QNN C++ Example Issue

Hi,
I am trying to the run the example for QNN using C++ and am getting an error stating that QNN execution provider is not supported with this build. I followed the build instructions for ORT for Arm64 with QNN support here and am using a 2023 Windows Dev Kit.
Thanks

Hi @hhschumann
Can you please provide the following information:

Exact build command used to build onnxruntime
The exact error message
Confirmation that you are building on Windows ARM64

Thank you

I followed the build instructions here: https://onnxruntime.ai/docs/build/eps.html#build-instructions-5
Error messages was "QNN execution provider is not supported with this build"
Correct, I am building on Windows ARM64

We already have multiple people verified the example code without any problem.
You shouldn't get the error if you set the "--use_qnn --qnn_home [QNN_SDK path]" in your build command. I'm not sure what's wrong here.
Were you build on the 2023 Dev kit?
Could you provide the Onnxruntime build log?

@HectorSVC
I rebuilt Onnxruntime from the source and pulled in the latest version of the example and was able to get the example to work. There was still a minor issue with the ONNX model URL line 3 of run_qnn_ep_sample.bat. It gives me a 404 error. I was able to find the model at https://github.com/onnx/models/blob/main/validated/vision/classification/mobilenet/model/mobilenetv2-12.onnx but for some reason was getting the error "Failed to load model because protobuf parsing failed" when downloading it using the .bat script. However, when I manually downloaded the model and placed it in the example directory, it worked. Not sure why that issue occured.

Oh, no, they moved the folder again. They did that several weeks ago by moving it to archive folder. I'll submit a PR to fix it.
The correct path should be https://github.com/onnx/models/raw/main/validated/vision/classification/mobilenet/model/mobilenetv2-12.onnx.
But anyway, good news from your side.
Can we close this issue now?

https://github.com/microsoft/onnxruntime-inference-examples/pull/365

@HectorSVC yes you may close the issue. Thanks!


Graphical User Interface (GUI)

Implement a gui for the app

@DanniSec Created a branch for developing the GUI