ANTLR 4.9.1 support?

Seems that ANTLR 4.9.x is not in the list of supported versions.

Also interested in getting this.
In the meantime, going to look into making my own bundle. Anyone tried yet?

@movelazar I created a small example on how to do this https://github.com/lgalfaso/bazel_antlr

@marcohu any chance of getting this updated?

Ended up just writing a patch.
diff --git a/antlr/repositories.bzl b/antlr/repositories.bzl
index e2525ab..342dd57 100644
--- a/antlr/repositories.bzl
+++ b/antlr/repositories.bzl
@@ -3,13 +3,18 @@
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_jar")
 load(":lang.bzl", "C", "CPP", "GO", "JAVA", "OBJC", "PYTHON", "PYTHON2", "PYTHON3", supportedLanguages = "supported")

-v4 = [4, "4.7.1", "4.7.2", "4.8"]
+v4 = [4, "4.7.1", "4.7.2", "4.8", "4.9.1"]
 v4_opt = [4, "4.7.1", "4.7.2", "4.7.3", "4.7.4"]
 v3 = [3, "3.5.2"]
 v2 = [2, "2.7.7"]

 PACKAGES = {
     "antlr": {
+        "4.9.1": {
+            "url": "https://github.com/antlr/antlr4/archive/4.9.1.tar.gz",
+            "prefix": "antlr4-4.9.1",
+            "sha256": "db170179917ce6fec7bc4ecf72edba36b97c9881e09e03af6ac0c901eba52a8f",
+        },
         "4.8": {
             "url": "https://github.com/antlr/antlr4/archive/4.8.tar.gz",
             "prefix": "antlr4-4.8",
@@ -38,6 +43,10 @@ PACKAGES = {
         },
     },
     "antlr4_runtime": {
+        "4.9.1": {
+            "path": "org/antlr/antlr4-runtime/4.9.1/antlr4-runtime-4.9.1.jar",
+            "sha256": "a80502c3140ae7acfbb1f57847c8eb1c101461a969215ec38c3f1ebdff61ac29",
+        },
         "4.8": {
             "path": "org/antlr/antlr4-runtime/4.8/antlr4-runtime-4.8.jar",
             "sha256": "2337df5d81e715b39aeea07aac46ad47e4f1f9e9cd7c899f124f425913efdcf8",
@@ -68,6 +77,10 @@ PACKAGES = {
         },
     },
     "antlr4_tool": {
+        "4.9.1": {
+            "path": "org/antlr/antlr4/4.9.1/antlr4-4.9.1.jar",
+            "sha256": "e6bd18f14126ab85a42dcb80ba5f67da2f35ba164ec5a64d40024bd0e7436584",
+        },
         "4.8": {
             "path": "org/antlr/antlr4/4.8/antlr4-4.8.jar",
             "sha256": "6e4477689371f237d4d8aa40642badbb209d4628ccdd81234d90f829a743bac8",
@@ -179,7 +192,9 @@ def rules_antlr_dependencies(*versionsAndLanguages):
             languages = [JAVA]

         for version in sorted(versions, key = _toString):
-            if version == 4 or version == "4.8":
+            if version == 4 or version == "4.9.1":
+                _antlr491_dependencies(languages)
+            elif version == "4.8":
                 _antlr48_dependencies(languages)
             elif version == "4.7.2":
                 _antlr472_dependencies(languages)
@@ -217,6 +232,19 @@ def rules_antlr_optimized_dependencies(version):
     else:
         fail('Unsupported ANTLR version provided: "{0}". Currently supported are: {1}'.format(version, v4_opt), attr = "version")

+def _antlr491_dependencies(languages):
+    _antlr4_dependencies(
+        "4.9.1",
+        languages,
+        {
+            "antlr4_runtime": "4.9.1",
+            "antlr4_tool": "4.9.1",
+            "antlr3_runtime": "3.5.2",
+            "stringtemplate4": "4.3",
+            "javax_json": "1.0.4",
+        },
+    )
+
 def _antlr48_dependencies(languages):
     _antlr4_dependencies(
         "4.8",

Can someone merge the PR so that antlr4.9 is supported? Thanks!


:seedling: Add SetControlPlaneEndpoint function

What this PR does / why we need it:
The following PR addresses the issue #977, and aims to add the function SetControlPlaneEndpoint() and unit tests for it.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #977
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
No it does not
TODOs:

[ ] squash commits
[ ] include documentation
[ ] add unit tests

@janiskemper. I've made the required changes. Can you please review again? I've squashed my commits

@janiskemper . I've implemented the recommended changes. Can you please take a look?

@janiskemper I've made the changes. I request you take another look

I believe that you haven't implemented the additional tests right?

@janiskemper I did implement the three additional tests you recommended

true. My bad. You can resolve the two unresolved conversations and then you are done I guess!

@janiskemper I think we should be good now. I had added a port value for ControlPlaneLoadBalancer.Port too. I think that was unnecessary. I removed that, hence the two commits.
I've ammended that. Please take a look.

you can squash now

@janiskemper i've squashed the commits. Learnt so much with this issue. Thank you

did you call make verify and make test? If so, we can mark it as "ready for review"

thanks @razashahid107 for this PR :)

I loved doing this one. Got to learn so much. Thank you for being supportive @janiskemper @batistein


Rename --summarize flag to --stat

Fixes #3526
My first PR here, so go easy :)
I have signed the contributor agreement.

Looks great. Thanks for the contribution.


Add plugin for DownloadBuildArtifactsV1

Let's add a description?  Maybe a link to the task we re-wrote as an in the box task?

I tested
- task: PublishBuildArtifacts@1
  inputs:
   ArtifactName: mytest
- task: DownloadPipelineArtifact@2
  inputs:
    artifactName: mytest

Which worked great!  If you switch the 2 to 1, it doesn't work with or without the blob flag on.  Was it not supported in v1?

I tested
- task: PublishBuildArtifacts@1
  inputs:
   ArtifactName: mytest
- task: DownloadPipelineArtifact@2
  inputs:
    artifactName: mytest

Which worked great! If you switch the 2 to 1, it doesn't work with or without the blob flag on. Was it not supported in v1?

V1 pipelineartifacts doesn't download from build artifacts


Reduce Transient Allocations during Bulk Text Output

Make a few changes to memory usage throughout the application to reduce transient allocations from the big.txt test from ~213,000 to ~53,000.
PR Checklist

[x] Supports #3075
[x] I work here.
[x] Tested manually and WPR'd. Test suite should still pass.
[x] Am core contributor

Detailed Description of the Pull Request / Additional comments
Transient allocations are those that are new'd, used, then delete'd. Going back and forth to the system allocator for things we're just going to throw away or use rapidly again is a performance detriment.  This PR identifies a few places where we were accidentally allocating and didn't mean to or were allocating and freeing just to turn around and allocate again. I chose other strategies to avoid this.
Validation Steps Performed

Ran big.txt sample (~6MB file) before and after. Observed heap allocations with WPR.

Before:

After:

(Note that the ConsoleIoThread is pretty much gone from Transient allocations. The Render thread has bulked up in how many it has done... probably just a matter of circumstance changing the timing behavior between it and the IO thread.)


Remove legacy puppet object

/release-0.7
/kind technical-debt
Due to how terraform interacts with S3 objects that are encrypted, we designed a new way of indexing the latest puppet manifest to be used whilst keeping the history of manifests used.
During this migration we kept the old puppet object path to ensure backwards compatibility and smooth upgrading. This should now be safe to remove.

e930c9a847847a38179602bd31ae8c13


The NFT minting has stopped working. "Unable to fetch balance changes"

Mint was working fine for 2 weeks, recently had a problem with RPC, solved by switching to RunNode. For three days everything was fine, and I can't check NFT again, I keep getting the error "Unable to fetch balance changes" when I connect, what could this be about?
The console gives this error "findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference."

A solution to the problem was found:
1- Change the RPC to https://solana-api.projectserum.com/ either the API from quicknode.com or runnode.com
2- Mint 1 NFT via CLI using the command: npx ts-node js/packages/cli/src/candy-machine-cli.ts mint_one_token --env mainnet-beta --keypair ~/.config/solana/main.json
3- If you get an error refill your SOL purse with an amount higher than the NFT coin value. And try again.


Conditions are not parsed inside $not expression

Hi,
I'm using Mongoose.js now. While I'm developing my back-end application, I found a bug about $not expression.
If I query using a condition below, it is parsed well.
ex1)
let condition = {"createdAt":{"$gte":"2016/09/02 00:00:00", "$lte":"2016/09/02 23:59:59"}};
mongoose log:
=> Mongoose: collection.find({ createdAt: { '$gte': new Date("Thu, 01 Sep 2016 15:00:00 GMT"), '$lte': new Date("Fri, 02 Sep 2016 14:59:59 GMT") } }, { fields: undefined })
But if I use $not expression inside this condition, date string isn't parsed.
ex2)
let condition = {"createdAt":{$not:{"$gte":"2016/09/02 00:00:00", "$lte":"2016/09/02 23:59:59}}}
mongoose log:
=> Mongoose: collection.find({ createdAt: { '$not': { '$gte': '2016/09/02 00:00:00', '$lte': '2016/09/02 23:59:59' } } }, { fields: undefined })
What should I do to fix this?
Sincerely,
Jeongsang Baek

I'll raise this issue to mongoose.js github repo.


Not working with Grav CMS admin

Hello
I'm building a site with Grav CMS, gulp-connect-php is working fine for rendering php pages.
But when i want to connect to the admin, i get a server error 500 :

The Admin Plugin cannot run on the PHP built-in webserver. It needs Apache, Nginx or another full-featured web server.

Is there a workaround please ?
thx

Grav is stating that it requires a standard web server, you would need to create an issue or feature request with Grav to support non standard web servers such as this one.


Link in readme 404s

The link to XD Plugin Guides (with url https://adobexdplatform.com/plugin-docs/guides) results in a 404.

Hi @timkim, thanks for spotting the broken link. I have fixed the link now.

ref: 317f223f4553793fe43b3d8486cb8daa6db0d87f


Record terminated sessions that come from navigating away from the website / tab

Issue is circumvented because now users cannot nav to another tab with an ongoing session in the first place


registry db store

registry push image,in addition to inform the way,should be combined with training in rotation.

I don't think crane should be responsible for the 100% push success, or the data non-consistency is reasonable.
won't fix this issue.

please open this issue any problem. I will close it now.


allow configuration of hostname returned in service credentials

That is what I meant in #44
We use drbd replication for high availability setup and the host ip can change in case of cut-over -> hence the need to specify hostname.

Merged. A year later. Sorry about that :)


Automated cherry pick of #842: 删除虚拟机同时删除lb相关记录

Cherry pick of #842 on release/2.9.0.
#842: 删除虚拟机同时删除lb相关记录

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.9.0@19937c9). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             release/2.9.0    #853   +/-   ##
===============================================
  Coverage                 ?   7.56%
===============================================
  Files                    ?     342
  Lines                    ?   53487
  Branches                 ?       0
===============================================
  Hits                     ?    4044
  Misses                   ?   49064
  Partials                 ?     379

Flag
Coverage Δ

#aFlag
7.56% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guest_actions.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19937c9...389adf7. Read the comment docs.

/lgtm
/approve


When onWillPop is used, popGesture does not take effect

ATTENTION: DO NOT USE THIS FIELD TO ASK SUPPORT QUESTIONS. USE THE PLATFORM CHANNELS FOR THIS.
Fill in the template. Issues that do not respect the model will be closed.
Describe the bug
A clear and concise description of what the bug is.
Reproduction code
NOTE: THIS IS MANDATORY, IF YOUR ISSUE DOES NOT CONTAIN IT, IT WILL BE CLOSED PRELIMINARY)
example:
void main() => runApp(MaterialApp(home: Home()));

class Home extends StatelessWidget {
  final count = 0.obs;
  @override
  Widget build(context) =>WillPopScope(
  child:  Scaffold(
      appBar: AppBar(title: Text("counter")),
      body: Center(
        child: Obx(() => Text("$count")),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () => count.value++,
      ),
 onWillPop: () {
    return Future.value(true);
 }
));
}

To Reproduce
Steps to reproduce the behavior:
Function to(dynamic Page) {
    return Get.to(Page,
        transition: Transition.cupertino,
        curve: Curves.linear,
        popGesture: true, gestureWidth: (content) {
      return Get.width / 2;
    });
  }

to( () => Home ());

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Flutter Version:
Flutter 2.2.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 02c026b03c (3 months ago) • 2021-05-27 12:24:44 -0700
Engine • revision 0fdb562ac8
Tools • Dart 2.13.1
Getx Version:
4.3.8
Minimal reproduce code
to( () => Home ());

Hi, any update on this issue?

any update?

any update ?


Add StochasticEnv wrapper

This wrapper allows us to convert a minimally written deterministic environment like EmptyGridWorld, and add customized stochastic behaviour without having to create a new environment that is mostly similar and only slightly different.
For example, this wrapper can be used to easily add randomized reset behaviour (random agent start position and direction at each call to reset!), or make the agent take the intended action only probabilistically (as if it is a drunken agent).

@findmyway , I think it will be helpful to add examples like the drunken agent or randomly starting agent (position/direction). Should I add them in tests?

Codecov Report

Merging #63 (cfd5cc6) into master (7d32edc) will decrease coverage by 0.50%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   65.23%   64.73%   -0.51%
==========================================
  Files          14       15       +1
  Lines         443      448       +5
==========================================
+ Hits          289      290       +1
- Misses        154      158       +4

Impacted Files
Coverage Δ

src/GridWorlds.jl
100.00% <ø> (ø)

src/wrappers.jl
0.00% <0.00%> (ø)

src/envs/doorkey.jl
100.00% <0.00%> (+2.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d32edc...cfd5cc6. Read the comment docs.


Preview/ruby 2.7.1

uses 2.7.1 ruby base image
updates Gemfile, and Gemfile.lock to reflect new versio
deployed and tested @ https://scholarsphere-ruby-2-7-1.dsrd.libraries.psu.edu/

@whereismyjetpack This seems like it's doing more than just upgrading Ruby. Can the CircleCI changes be in a separate commit?

doh, Yeah, for sure. circle changes were supposed to be another PR.


Command line window stops with error message

Hello Ohan,
after days and weeks of fine working suddenly V4.93 during startup the command line window stops with following error message:
[error] - [Funktion: Gain :] TypeError: Cannot read properties of undefined (reading 'gain')
After new installation everything is working again but after 3 times of installing new I'm asking for a solution.
Thanks
73's de Achim, DL3RY

Hi
Please try latest release, there was small bug regarding settings.
Test and let me know?

Hi,
new release have been working since yesterday without any issues. If somthing will occur I'll contact you immediately.
Thanks and 73's
Achim, DL3RY


adding required annotations check and necessary tests

Adding a new check that checks for newly required annotations. At first we will only warn partners about this, then after sometime we will move to enforce this check.

Relates: JIRA: EET-3540

Note: There are backend changes being made to support Warning being in the results

Hi @acornett21 the DCI job failed because of a new test you've added
TASK [redhatci.ocp.verify_tests : Fail if not all test results are as expected for preflight_operator_simple-demo-operator_results-junit.xml]
0s
task path: /usr/share/ansible/collections/ansible_collections/redhatci/ocp/roles/verify_tests/tasks/parse_junit_file.yml:35
fatal: [jumphost]: FAILED! => {"changed": false, "msg": "The following expectations failed: [{'failed_expectation': {'testcase': '[a-zA-Z]+', 'passed': True}, 'actual_result': {'testcase': 'RequiredAnnotations', 'passed': False}}]"}

I'll change the expectations for simple-demo-operator tomorrow - for the moment we simply expect all tests to be green.

I'll change the expectations for simple-demo-operator tomorrow - for the moment we simply expect all tests to be green.

@tkrishtop Are you saying the new check showed up as failed? If so that's incorrect. This is still WIP, and I'll be working to update simple-demo-operator and simple-disconnected-operator accordingly, once this feature is fully hashed out.

I adjusted the pinned tests on our side, to ignore the new test failing for simple-demo. For the future, it would be nice to fix the simple-demo as well.

check workload preflight-green

@tkrishtop I've updated the the junit code to add another level/tag (not sure what to call this for junit). But the output will look like this for checks that are at a warn level.
<testsuites>
	<testsuite tests="5" failures="0" warnings="1" time="35.215827" name="Red Hat Certification">
		<properties></properties>
		<testcase classname="quay.io/opdev/simple-demo-operator-bundle:v0.0.6" name="ScorecardBasicSpecCheck" time="3.516921">Check to make sure that all CRs have a spec block.</testcase>
		<testcase classname="quay.io/opdev/simple-demo-operator-bundle:v0.0.6" name="ScorecardOlmSuiteCheck" time="3.530103">Operator-sdk scorecard OLM Test Suite Check</testcase>
		<testcase classname="quay.io/opdev/simple-demo-operator-bundle:v0.0.6" name="DeployableByOLM" time="28.148170">Checking if the operator could be deployed by OLM</testcase>
		<testcase classname="quay.io/opdev/simple-demo-operator-bundle:v0.0.6" name="ValidateOperatorBundle" time="0.010793">Validating Bundle image that checks if it can validate the content and format of the operator bundle</testcase>
		<testcase classname="quay.io/opdev/simple-demo-operator-bundle:v0.0.6" name="RequiredAnnotations" time="9.839866ms">
			<warning message="Warn" type="">Check that the CSV has all of the required feature annotations.: Suggested Fix: Add all of the required annotations, and make sure the value is set to either 'true' or 'false'</warning>
		</testcase>
	</testsuite>
</testsuites>

The idea of introducing a new check at level warn is so that partners can see the check in their results, but not be penalized if it fails. Then at a later date the check will be moved to level best where the check is enforced. I hope this clears up what we are trying to accomplish. Let me know if we need to adjust the XML, or if you see any issue in how the XML works, since I think DCI is the only consumer of this.

/ok-to-test

/ok-to-test

Tested locally as well now that the operators are updated...
{
    "image": "quay.io/opdev/simple-demo-operator-bundle:v0.0.7",
    "passed": true,
    "certification_hash": "d41d8cd98f00b204e9800998ecf8427e",
    "test_library": {
        "name": "github.com/redhat-openshift-ecosystem/openshift-preflight",
        "version": "unknown",
        "commit": "unknown"
    },
    "results": {
        "passed": [
            {
                "name": "ScorecardBasicSpecCheck",
                "elapsed_time": 12673,
                "description": "Check to make sure that all CRs have a spec block."
            },
            {
                "name": "ScorecardOlmSuiteCheck",
                "elapsed_time": 3507,
                "description": "Operator-sdk scorecard OLM Test Suite Check"
            },
            {
                "name": "DeployableByOLM",
                "elapsed_time": 66839,
                "description": "Checking if the operator could be deployed by OLM"
            },
            {
                "name": "ValidateOperatorBundle",
                "elapsed_time": 12,
                "description": "Validating Bundle image that checks if it can validate the content and format of the operator bundle"
            },
            {
                "name": "RequiredAnnotations",
                "elapsed_time": 11,
                "description": "Checks that the CSV has all of the required feature annotations."
            }
        ],
        "failed": [],
        "errors": []
    }
}


update size_box icon in missions (first-timers-only)

first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before and are looking for an easy way take their first steps.
Consider this as your chance to dip your toe into the world of open-source and get some bragging rights for writing code that makes drones fly, cars find charging stations, helps people and goods move from place to place and more...
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new non-profit foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
Missions
The DAV project you are looking at is Missions. Missions is the client facing side of the marketplace connecting DAV users looking to ship packages, with autonomous vehicles such as drones.
How you can help
At DAV we are currently re designing our branding. According to the new design we are changing the color scheme of all our applications including missions.
Issue
The task for this issue is to change the box size image in order page from  to this
You can simply replace the contents of the file size_box.svg in src/images/ with this
<?xml version="1.0" encoding="UTF-8"?>
<svg width="44px" height="35px" viewBox="0 0 44 35" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <!-- Generator: Sketch 49.1 (51147) - http://www.bohemiancoding.com/sketch -->
    <title>box</title>
    <desc>Created with Sketch.</desc>
    <defs>
        <rect id="path-1" x="0" y="0" width="44" height="8"></rect>
    </defs>
    <g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
        <g id="Order-Pick-Up-screen" transform="translate(-300.000000, -283.000000)">
            <g id="box" transform="translate(300.000000, 283.000000)">
                <rect id="Rectangle-6" stroke="#FE6B48" x="3.88461538" y="5.5" width="36.2307692" height="29" rx="1"></rect>
                <g id="Rectangle-6">
                    <use fill="#FFFFFF" fill-rule="evenodd" xlink:href="#path-1"></use>
                    <rect stroke="#FE6B48" stroke-width="1" x="0.5" y="0.5" width="43" height="7"></rect>
                </g>
                <rect id="Rectangle-7" fill="#FE6B48" x="15.2307692" y="16.6666667" width="15.2307692" height="4.33333333" rx="2.16666667"></rect>
            </g>
        </g>
    </g>
</svg>

Contributing to Missions

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Open the Missions GitHub page and click the ★ Star and then ⑂ Fork buttons.
[ ] Clone a copy to your local machine with $ git clone https://github.com/YOUR-GITHUB-USER-NAME/missions.git
[ ] Code Code Code
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missions) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #5)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

HI can I tackle this problem?

go ahead @kwin555 👍

made a pull request

Hey @kwin555 Thanks for your work on missions. Hope you had fun and learned a few things in the process 😄 Feel feel to join our gitter channel to find out more opportunities to contribute.

Thanks for the opportunity! Hope to help out soon!


Affects not fully displayed for spell slots by level

Object 'bangle bracelet sky blue platinum decorated'
Item Type: WORN
Mat Class: metal        Material : platinum
Weight   : 2            Value    : 1000
Affects  : spell slots   by +1 at level 6
Affects  : spell slots   by +1 at level 8
Affects  : RESIST_MAGIC  by 5
Affects  : MEM_FACTOR    by 3
Effects  : DETECT_INVISIBLE
Restricts: NOMAGE NOTHIEF NOPALADIN NORANGER NOWARRIOR NODARK_KNIGHT NOBARBARIAN NOBLACK_ROBE NORED_ROBE NOWHITE_ROBE
Immune   : IMMUNE_COLD IMMUNE_ELECTRICITY

Issue initially identified by Pat and posted in Discord. Was able to duplicate and verify bug exists.

need to change regex, it's in formatAffects
var formatAffects = (pArg) => {
  let retvalue = "";
  let affectsArr = [];
  let sb = "";
  let affectBy = /([A-Za-z_\s]+)\s*by\s*([-+]?\d+)/;

fixed in 322fff0


tensorboard<2.3.0 still in requirements.txt for 0.7.1

As far as I understand from this issue the current release should support tensorboard 2.4, but requirements.txt does not seem to be updated.

This was an oversight. You can force an upgrade of the tensorboard and Guild should work fine. This change was committed, in fact actually this time - so the next release will have this. Thanks for pointing this out!


47 tidy up ordering and capitalisation in user selections

#47
Pull request overview
Tidied up ordering and capitalisation in user selections
Pull request checklist
Please check if your PR fulfills the following:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Tests have been run locally and are passing (shinytest2::test_app())
[x] Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?
What is the new behaviour?
Page 1: Provider breakdowns
Capitalise options for measures.
Default year should be most recent year, and ordered in descending order.
Options for measures in file order rather than alphabetical.
Regions better ordered in usual order rather than alphabetical.
Page 2: LAD breakdowns
Capitalise options for measures.
Options for measures in file order rather than alphabetical.
Default year should be most recent year, and ordered in descending order.
LAD dropdowns would be better sorted alphabetically
Page 3: Subjects and standards
Default year should be most recent year, and ordered in descending order.
Providers should be in alphabetical order in the dropdown
Page 4: Learner characteristics
Better format table headings
Anything else

Thanks, I was hoping I had clicked on a link within the pull request that would create a link with the issues. I've discovered you can also click a link within an issue to create a new branch to deal with it.


add support for invalid but common URL tag inside of NetworkLink KML

When exploring KML support in Cesium, we keep running across invalid KML in the 'wild' which uses a Url tag name instead of the standard link.   Google Earth accepts this invalid KML as well.
 <NetworkLink id="link">\
    <Url>\  <!-- instead of Link -->
      <href>./Data/KML/refresh.kml</href>\
    </Url>\
  </NetworkLink>

This is a fix that will allow those types of KML to be parsed.  It should expand the range of KML that Cesium can accept.

Thanks @mmacaula, I confirmed that Google Earth works as described and accepts the Url node in place of Link.  I'll update CHANGES in master.


update mir version

Force of habit? :)

lets wait

lets wait travis

Why push on my fork? You're testing something?

oh, sorry

hehe ;)


Optimal image size and aspect ratio for metric depth estimation

Thank you all for the really awesome code and research! I am interested in metric depth estimation on KITTI. The metric_depth/evaluate.py script drastically changes aspect ratio of input images of KITTI dataset, such that output depth map is 518x392 pixels, whereas input images are 1216x352, this is enabled by passing mode="eval" to get_config() function call. Evaluating the model with changed aspect ration results in higher accuracy:
{'a1': 0.987, 'a2': 0.998, 'a3': 0.999, 'abs_rel': 0.04, 'rmse': 1.824, 'log_10': 0.017, 'rmse_log': 0.062, 'silog': 5.806, 'sq_rel': 0.107}
compared to running depth estimation on full resolution and original aspect ratio (mode="infer"):
{'a1': 0.982, 'a2': 0.997, 'a3': 0.999, 'abs_rel': 0.056, 'rmse': 2.153, 'log_10': 0.025, 'rmse_log': 0.078, 'silog': 6.881, 'sq_rel': 0.152}
I wanted to confirm what is the optimal image size and aspect ratio for metric depth estimation.
Thanks,
Eldar.

Hi, we did not fine-tune the optimal aspect ratio for fair comparison. I also noticed that some other aspect ratios will result in better results. It is hard to say which aspect ratio or image resolution is optimal. It may depend on specific dataset.


Nesterov momentum implementation

Based off of the simplification suggested by Ian Goodfellow (@goodfeli) and the corresponding paper by Yoshua Bengio.
Still need to add tests to the test suite, but I'm looking for a few more eyes on the code to make sure the basics check out.

@lamblin I believe I've found a mistake in this implementation of Nesterov momentum. Neither the "alternate" rules given in PR #677 nor the rule given by madison are incorrect by my tracing of Ilya Sutskever's paper, which gives the original formulation as equations (3) and (4) on page 3. Here are my proposed rules, with detailed commentary to assure everyone of their correctness.

Nesterov.pdf
If confirmed it would mean that Pylearn never actually implemented Nesterov momentum correctly, and nobody discovered this in over one and a half years. An error this serious merits a notice to users to redo their experiments with NAG if they've previously been disappointed by it.

I now think I was myself mistaken in my post above about a bug in the Nesterov momentum formulas, so I'm scrapping it, and you can ignore it.


Manifest list upload handler should validate manifests' mediaType and size.

@thaJeztah asked what happens If you upload a application/vnd.docker.distribution.manifest.list.v2+json (manifest list) to distribution but specify the incorrect media type for the referenced manifest/s. The answer is the manifest list is accepted. It is also accepted if the size is wrong. The only property that is checked is that the digests either exist in the manifest store or the layer store (because of #3122).
I think we should be validating the mediaType and size. Maybe we should also be validating the platform fields? Or is anyone relying on linking amd64 clients to an i386 image?
We should also check the OCI Index, I have not. If we do any of this for the OCI Index then we will break the method BuildKit uses to store build caches in a registry by referencing blobs from an index.

The manifest list spec

Maybe we should also be validating the platform fields? Or is anyone relying on linking amd64 clients to an i386 image?

Unfortunately, I don't think we'd be able to pull that off. We had a check in docker engine, but it broke way too many cases where images were cross-compiled and uploaded with the wrong metadata (but referenced with the correct os/arch in the manifest list)


ITAB Aggregation issues

I have the issue with ITAB Aggregation as well. I provided two solutions, one with  loop group by, the other without loop group by. The one with loop..group by could not pass syntax check. the one without loop..group by cant pass the unit test. But both solutions passed abap unit test successfully in SAP BTP abap environment.

thanks, can you help pasting the code here as text, so I can copy paste it to test?

METHOD perform_aggregation.
" add solution here
DATA icount TYPE i.
TYPES: BEGIN OF group_type,
group TYPE group,
size  TYPE i,
END OF group_type,
group_types TYPE STANDARD TABLE OF group_type WITH EMPTY KEY.
DATA temp_numbers TYPE initial_numbers.
temp_numbers[] =  initial_numbers[].
SORT temp_numbers BY group ASCENDING.
DATA last_group TYPE c.
DATA group_numbers TYPE group_types.
LOOP AT temp_numbers INTO DATA(initial_number).
IF last_group <> initial_number-group.
APPEND INITIAL LINE TO group_numbers  ASSIGNING FIELD-SYMBOL(<group_number>).
<group_number>-group = initial_number-group.
<group_number>-size = 1.
ELSE.
<group_number>-size += 1.
ENDIF.
last_group =  initial_number-group.
ENDLOOP.
LOOP AT group_numbers INTO DATA(group_number).
  APPEND INITIAL LINE TO aggregated_data ASSIGNING FIELD-SYMBOL(<aggregated_data>).
  <aggregated_data>-group =  group_number-group.
  <aggregated_data>-count = group_number-size.
  icount = 0.
  LOOP AT temp_numbers INTO DATA(ls_member) WHERE group =  group_number-group.
    <aggregated_data>-sum  += ls_member-number.
    IF icount = 0.
      <aggregated_data>-min = <aggregated_data>-max = ls_member-number.
    ELSE.
      <aggregated_data>-min =  COND i( WHEN ls_member-number < <aggregated_data>-min THEN ls_member-number ELSE <aggregated_data>-min ).
      <aggregated_data>-max =  COND i( WHEN ls_member-number > <aggregated_data>-max THEN ls_member-number ELSE <aggregated_data>-max ).
    ENDIF.
    icount += 1.
  ENDLOOP.
  <aggregated_data>-average = <aggregated_data>-sum /  <aggregated_data>-count.
ENDLOOP.

ENDMETHOD.

METHOD perform_aggregation.
" add solution here
LOOP AT initial_numbers INTO DATA(initial_number)
  GROUP BY ( group  = initial_number-group
             size  = GROUP SIZE
             index = GROUP INDEX )
  ASCENDING
  ASSIGNING FIELD-SYMBOL(<group>).

  APPEND INITIAL LINE TO aggregated_data ASSIGNING FIELD-SYMBOL(<aggregated_data>).

  <aggregated_data>-group =  <group>-group. "initial_number-group. <>
  <aggregated_data>-count = <group>-size.
  DATA(icount) = 0.

  LOOP AT GROUP <group> ASSIGNING FIELD-SYMBOL(<ls_member>).
    <aggregated_data>-sum  += <ls_member>-number.
    IF icount = 0.
      <aggregated_data>-min = <aggregated_data>-max = <ls_member>-number.

    ELSE.
      <aggregated_data>-min =  COND i( WHEN <ls_member>-number < <aggregated_data>-min THEN <ls_member>-number ELSE <aggregated_data>-min ).
      <aggregated_data>-max =  COND i( WHEN <ls_member>-number > <aggregated_data>-max THEN <ls_member>-number ELSE <aggregated_data>-max ).
    ENDIF.

    icount += 1.
  ENDLOOP.
  <aggregated_data>-average = <aggregated_data>-sum /  <aggregated_data>-count.
ENDLOOP.

ENDMETHOD.

@A142612 for the first case,
the workaround is not having <aggregated_data>-min = <aggregated_data>-max = ls_member-number.
also note it is considered bad practice to use chained assignment, https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-chain-assignments

enabling no_chained_assignment rule = https://github.com/abaplint/transpiler/pull/881

second LOOP GROUP BY, some bugs in https://syntax.abaplint.org/?filter=groupby#/abap/expression/LoopGroupByComponent
wip, https://github.com/abaplint/abaplint/pull/2691

second, workaround,
refactor the chained assignment
and remove "index = GROUP INDEX", as it is not used in the code,

now gives proper error message for chained assignment,

@A142612 try again

Came here looking to understand why this does not work:
        aggregated_data[ group = <fs_ini_numbers>-group ]-max = COND #(
          when <fs_ini_numbers>-number > aggregated_data[ group = <fs_ini_numbers>-group ]-max
          then <fs_ini_numbers>-number
          else aggregated_data[ group = <fs_ini_numbers>-group ]-max
          ).

and got the inspiration to try an explicit type, which solved the problem. Sadly at the moment I don't have a system supporting the new syntax, but I thought the code above was valid, am I mistaken?

@AndreaBorgia-Abo please open a new issue, I consider this issue solved

@A142612 try again

FYI, chained assignment will work in next release, https://github.com/abaplint/transpiler/pull/887/commits/53e090c3af74346a22d1cd226d88e9684a91b84d

with chained assignment,

closing


Make sure measures contain links to guidance where relevant

Add links to guidance for:

[x] Fungal nail
[x] KTT12 (long acting insulin)
[x] Gluten free
[x]  Nebivolol
[x] KTT9 (abx volume)
[x] KTT3 other lipid-modifying drugs
[x] Keppra - link to BSA, MHRA
[x] Trimethoprim/nitrofurantoin
[x] KTT9 cephalosporins
[x] Lyrica
[x] Non-preferred NSAIDs /COX-2i
[ ] Extended release quetiapine
[x] Soluble/effervescent paracetamol and co-codamol
[x] High cost ARBs ("NICE guidance for treating high blood pressure recommends that the low-cost versions should be used.")
[x] high dose corticosteroids - any links for the COPD guidance?
[ ] Tramadol (this is a cost one but can we link to anything? "Modified release and non-standard tramadol preparations vary widely in cost. Generic tramadol 50mg capsules are low-cost. Ideally modified-release and other high cost preparations should be reserved for patients who have compliance issues.")

quetiapine now retired.
probably nothing we can link to about tramadol.
others done

thanks @richiecroker !


Will add Deserialize Trait?

I try it:
pub trait IMessage<'a>:Serialize + Deserialize<'a>{

}
serialize_trait_object!(<'a> IMessage<'a>);

but I get error messgae: IMessage cannot be made into an object

Closing as a duplicate of #25.


Move to stable

I'd love to use this library for a work project, but I'm not sure I'm willing to move everything to nightly for it. Here's a quick stab at building it on stable, with some updated/relaxed dependencies!
At the very least, this will build on stable, but tests still require nightly for some of the proc_macro/codegen parts.
The nightly parts still present are gated by a #[cfg(nightly)], but I'm not sure those are all necessary, since they primarily deal with NoneError, which is pretty easily replaced by .ok_or(...). I may add another commit adding thiserror support to clean up GraphFailure a bit.
Would love some feedback or ideas on how to take this the rest of the way!
Ref: #290

Hey, thanks for working on this. I for sure want to move to stable and its become a higher priority after several people have asked for it.
To give some context, I am currently working on refactoring the codegen project because of a few issues I have run into, that have made parsing OpenAPI configs and building from that more complicated than I wanted/anticipated. I am still going to be using the OpenAPI config but im taking a cleaner approach to make the project more stable and useful going forward.
Getting the codegen project corrected has been my main priority, but right after that I want the priority to be moving to stable.
I would still love to see a better implementation for errors, and if your willing to put in a separate PR, I would be happy to approve a merge for that.
For the actual work of moving to stable, I believe it may need to be broken up into a few different parts, one of those being removing NoneError from GraphFailure.
        #[cfg(nightly)]
        let url = upload_session["uploadUrl"].as_str()?;
        #[cfg(not(nightly))]
        let url = upload_session["uploadUrl"]
            .as_str()
            .ok_or(GraphFailure::not_found("NoneError"))?;

Honestly, your right about just using ok_or, it just makes more sense and there is no point in trying to support NoneError anymore. So, just doing
        let url = upload_session["uploadUrl"]
            .as_str()
            .ok_or(GraphFailure::not_found("NoneError"))?;

is completely fine with me. I have technically already removed it in my codegen branch, but again I am always open to PR's and people contributing to the project.
The second issue is dealing with the nightly features which you have already noticed. I think it would be fun to have nightly gated features but honestly that would add more work in the future because it would have to be maintained (I do this in my free time). Getting the whole project on stable would be preferable and more people would be able to use it.
I am sure there is more issues we would run into with moving to stable that I am not thinking of right now, but I think this is a starting point and if your willing help figure out what those issues are and possibly help create some issues on GitHub for that work then I am all for getting this rolling.

Yeah, of course. If it makes things easier from a branch/repo management perspective, feel free to just use whatever commits I make on this branch as inspiration for stuff to roll into your active branch.
I think from a user perspective, I wouldn't mind too much if the codegen components still require nightly, since the codegen output is committed to the main crate (i.e. you shouldn't need to be on nightly to pull the main crate from crates.io).
What other nightly is there in the non-codegen parts of the repo? I commented out the two feature attrs in the main crate's lib and everything seemed to still work fine? Maybe they're not necessary anymore?
I could quickly add something to replace rocket in the tests. In future testing, will there ever need to be other listeners besides /redirect? Just setting up a hyper listener would be pretty simple (and already in the dependency tree), but throwing a warp server together is nearly as easy and probably more extensible.

You may be right about the two nightly features in the main crate, Its been a while since I added those.
I made a ticket for the graph-error changes, https://github.com/sreeise/graph-rs/issues/312
There are a few variations of the listeners but all them use redirect:

https://github.com/sreeise/graph-rs/blob/23700f19a17dd39bb8282a6acb62c697b72f23fe/examples/rocket_open_id_code.rs#L63
https://github.com/sreeise/graph-rs/blob/23700f19a17dd39bb8282a6acb62c697b72f23fe/examples/rocket_example.rs#L147
https://github.com/sreeise/graph-rs/blob/23700f19a17dd39bb8282a6acb62c697b72f23fe/examples/rocket_example_with_state.rs#L79
https://github.com/sreeise/graph-rs/blob/23700f19a17dd39bb8282a6acb62c697b72f23fe/examples/auth_code_grant_pkce.rs#L82
https://github.com/sreeise/graph-rs/blob/23700f19a17dd39bb8282a6acb62c697b72f23fe/examples/auth_code_grant.rs#L51

I also made a ticket for the rocket changes: https://github.com/sreeise/graph-rs/issues/313
For PR's that people do I generally just like them to be focused on a single change at a time because they are easier to review/reason about. I will admit that I do not always follow those rules when its my own work (at least on this project) but I really should :)

Totally fair! I'll close this and make some of those changes on individual branches of my fork, then open a few PRs. Thanks for your help, and sorry for all the stuff I'll probably be throwing your way!


⚠ Bofrost.be has degraded performance

In acfe0db, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1342 ms

Resolved: Bofrost.be performance has improved in cb0b8cf after 6 minutes.


cmake: add LATE_LINK to fix llext weak syscall definitions

Since 62b19ef65c0be6186ed9f07343c8242abf651e6c LLEXT has gained the ability to export all syscalls automatically. The export is done for any syscall declared in the build, including those that are never actually defined - most commonly due to not enabling some Kconfig.
These undefined functions would normally cause a link error; the workaround has been to define, in an autogenerated file included by llext_export.c, weak implementations for all syscall symbols to the stock no_handler function, with the intention of providing a sensible default to link with.
However, during development I discovered that some of these symbols were actually defined in the final ELF as NULL. This has been traced to the llext_export.c file being included in the middle of the --whole-archive list, instead of at the end.
This PR adds a LATE_LINK property to Zephyr libraries (by default disabled). Libraries that have this feature enabled will be placed after all the ones that do not enable it in the linker command line; no other ordering is enforced between these two groups.
This feature is then used to split build the llext_exports.c file in its own separate library and move it to the end of the link list, fixing the symbol definition issue.

Closing in favor of #81580.


Mixed C/C++ target followed by target sharing a source file causes errors

Outline of the portion of my CMakeLists.txt file that causes this:
add_executable(mytarget1 mysource1.c mysource2.cpp mysource3.cpp mysource4.cpp)
cotire(mytarget1)

add_executable(mytarget2 mysource4.cpp
cotire(mytarget2)

Error message from cmake:
-- C CXX target mytarget1 cotired.
CMake Error at cmake/cotire.cmake:2649 (message):
  CXX target mytarget2 cotired without precompiled header.
  Target sources already include a precompiled header for target(s)
  mytarget1.  Set target property COTIRE_ENABLE_PRECOMPILED_HEADER to FALSE
  for targets mytarget2, mytarget1 to get a workable build
  system.
Call Stack (most recent call first):
  cmake/cotire.cmake:3051 (cotire_choose_target_languages)
  cmake/cotire.cmake:3206 (cotire_target)
  mydir/CMakeLists.txt:160 (cotire)

Reversing the order that the two targets are cotired in prevents the error.

Can't fix this. Cotire needs to modify the compile flags of the source file. The modified flags then apply to all targets where the file is used. As a work-around, add a file mysource4_target2.cpp to mytarget2 which simply includes mysource4.cpp.


Feature/more cleanup 32

Changes Unknown when pulling 2d12754dcc62c8e26417a10a08480672e20171eb on feature/more-cleanup-32 into ** on master**.


Revert "[Chore] Update .asf.yaml (#4257)"

This reverts commit 36a8774d9ac56bdf415a48e2d3082e4ea54f3c91.

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

@Hisoka-X


suggestion - remove jq as a dependancy

In building my own version of this I took a similar approach, using jq to parse the API response.
Some feedback from (particularly non tech) users was that jq was annoying to install - In the worst case an Xcode update before they could brew install or update - or I had to explain how to install the binary.
I replaced the jq dependancy with using the OS's built in python (2.7 I believe) - could save you some user headaches and issues.

closed from #15


BUG: Change the styling of the products listed on the homepage

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The styling of the products listed on the homepage is not the same as it is of Flipkart
I want to work on this issue, hope you would assign this task to me

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please aasign this issue to me. I want to work on it under GSSoC'24.


NOT DISPLAYING ALL OPENED TABS IN TAB LAYOUT.

Environment
Windows build number: Version 10.0.18362.356
Windows Terminal version: Version: 0.5.2762.0
Actual behavior:
Maximize window view : In maximize view of windows terminal, All tabs are displaying in tab layout.In this image I have opened 6 tabs in terminal.

Minimize window view : But after minimizing the window view of windows terminal. Tab layout is not displaying all the 6 opened tabs. It is displaying only 3 tabs but actually 6 tabs are opened.It is hiding the remaining tabs which are not able to fit in tab layout.

Same behavior getting for Maximize windows view also.
Expected behavior
For this issue we expect to accomplish the space of single tab layout by multiple tabs.
Example 1: Microsoft Edge browser
For multiple opened tabs Microsoft Edge browser provides 'scroll tab list forward' and 'scroll tab list backward' options to scroll over all the tabs and indicates the presence of multiple tabs.

Example 2: Google Chrome browser
For multiple opened tabs Google Chrome browser squeeze all the opened tabs in single tab layout.

Steps to reproduce
To resolve this issue we can add 'scroll tab list forward/backward' options or squeeze all the opened multiple tabs in tab layout.

The looks like a duplicate of #857 and/or #444.

Oh sorry! Would I close this issue ?

Yep! Thanks for the comprehensive write-up though. /dup #857 #444 and will be fixed by #1896 (in PR at #3027)


SDWebImageCombinedOperation can be more elegant

SDWebImageCombinedOperation just need cancel download and remove operation, I think it can provide two blocks to do this, but not hold an instance of SDWebImageManager. And the benefits of doing that is we put @interface and @implementation of SDWebImageCombinedOperation together.
New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[ ] I have added the required tests to prove the fix/feature I am adding

[ ] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[ ] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
...

Best wishes

Codecov Report

Merging #2317 into master will decrease coverage by 0.03%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   75.81%   75.78%   -0.04%
==========================================
  Files          36       36
  Lines        3701     3708       +7
==========================================
+ Hits         2806     2810       +4
- Misses        895      898       +3

Impacted Files
Coverage Δ

SDWebImage/SDWebImageManager.m
73.39% <76.47%> (-0.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c824c...3ba7e05. Read the comment docs.

@gukemanbu The current implementation does not hold an instance of manager. It's just keep a weak reference to the manager.
Your implementation, still keep a weak reference of manager. See that weakSelf you use...
Actually, there are no really difference between implementation. :)

@dreampiggy I was wrong to say hold, From architectural design, @interface and @implementation should put together. With enough memory, I think architecture design should be a priority, not memory，That's just my opinion.

😅 Why we put @interface @implementation into different part. It's because of class declartation.
SDWebImageManager's internal property is defined in @interface SDWebImageManager (). But however, our SDWebImageCombinedOperation need access to this internal property. So the @implementation SDWebImageCombinedOperation should be placed below this.
However,  SDWebImageManager need to access SDWebImageCombinedOperation's internal property as well. So @interface SDWebIamgeCombinedOperation () should be placed above this.
So, this cause the final code-layout :). Yes, you can using something like dynamic, or category to put them together. But...actually this does not cause any meaning for user or performance. However, using a block will cause issue, for example, it cause the retain cycle if you're not careful at all. It impact the performance as well.
Since the reason why we put the @interface @implementation different part is obvious and easy to maintain. I don't think elegant or something is important than these potential problems.


Add convention checker for clang format and fix newer gcc error

@plusvic had to upgrade my Ubuntu to install clang-format and ended up installing Ubuntu 20.10 and its newer gcc causing a compile error which I fixed in this PR.
Created a clang-format convention checker which skips over a hard-coded regex of auto generated files and reports clang-format mentions if clang-format does not like the formatting, e.g.:
$ make clean ; run-parts --reverse --exit-on-error --regex 'convention' tests && make --jobs `nproc` check CC="gcc -DYR_DEBUG_VERBOSITY=2" YR_DEBUG_VERBOSITY=2
- convention: non-portable modifier: none found
- convention: clang-format: skipping source file ./tests/blob.h
- convention: clang-format: skipping source file ./libyara/re_lexer.c
- convention: clang-format: skipping source file ./libyara/re_grammar.h
- convention: clang-format: skipping source file ./libyara/re_grammar.c
- convention: clang-format: skipping source file ./libyara/modules/pb_tests/pb_tests.pb-c.h
- convention: clang-format: skipping source file ./libyara/modules/pb_tests/pb_tests.pb-c.c
- convention: clang-format: skipping source file ./libyara/lexer.c
- convention: clang-format: skipping source file ./libyara/hex_lexer.c
- convention: clang-format: skipping source file ./libyara/hex_grammar.h
- convention: clang-format: skipping source file ./libyara/hex_grammar.c
- convention: clang-format: skipping source file ./libyara/grammar.h
- convention: clang-format: skipping source file ./libyara/grammar.c
- convention: clang-format: running on 127 non-skipped source files
- convention: clang-format: 282 mentions for ./tests/util.h
- convention: clang-format:   1 mentions for ./tests/util.c
- convention: clang-format:  12 mentions for ./tests/test-api.c
- convention: clang-format:  11 mentions for ./sandbox/yara_transaction.h
- convention: clang-format:   6 mentions for ./sandbox/collect_matches.h
- convention: clang-format:  18 mentions for ./libyara/threading.c
- convention: clang-format:   5 mentions for ./libyara/strutils.c
- convention: clang-format:   2 mentions for ./libyara/stream.c
- convention: clang-format:   9 mentions for ./libyara/stopwatch.c
- convention: clang-format:   5 mentions for ./libyara/proc/windows.c
- convention: clang-format:   6 mentions for ./libyara/proc/openbsd.c
- convention: clang-format:   6 mentions for ./libyara/proc/mach.c
- convention: clang-format:  11 mentions for ./libyara/proc/linux.c
- convention: clang-format:   6 mentions for ./libyara/proc/freebsd.c
- convention: clang-format:   5 mentions for ./libyara/proc.c
- convention: clang-format:   6 mentions for ./libyara/modules/time/time.c
- convention: clang-format:   9 mentions for ./libyara/modules/tests/tests.c
- convention: clang-format:   5 mentions for ./libyara/modules/pe/pe_utils.c
- convention: clang-format:   1 mentions for ./libyara/modules/pb_tests/pb_tests.c
- convention: clang-format:  18 mentions for ./libyara/modules/math/math.c
- convention: clang-format:   9 mentions for ./libyara/modules/magic/magic.c
- convention: clang-format:  20 mentions for ./libyara/modules/hash/hash.c
- convention: clang-format:   6 mentions for ./libyara/modules/elf/elf.c
- convention: clang-format:  15 mentions for ./libyara/modules/dotnet/dotnet.c
- convention: clang-format:  11 mentions for ./libyara/modules/dex/dex.c
- convention: clang-format:   4 mentions for ./libyara/modules/demo/demo.c
- convention: clang-format:  19 mentions for ./libyara/modules/cuckoo/cuckoo.c
- convention: clang-format:  23 mentions for ./libyara/libyara.c
- convention: clang-format:   1 mentions for ./libyara/include/yara/rules.h
- convention: clang-format:   1 mentions for ./libyara/include/yara/re.h
- convention: clang-format:  11 mentions for ./libyara/include/yara/pe_utils.h
- convention: clang-format:   1 mentions for ./libyara/include/yara/limits.h
- convention: clang-format:   5 mentions for ./libyara/include/yara/libyara.h
- convention: clang-format:   5 mentions for ./libyara/include/yara/lexer.h
- convention: clang-format:   2 mentions for ./libyara/include/yara/integers.h
- convention: clang-format:   4 mentions for ./libyara/include/yara/hex_lexer.h
- convention: clang-format:  16 mentions for ./libyara/include/yara/hash.h
- convention: clang-format:   6 mentions for ./libyara/include/yara/filemap.h
- convention: clang-format:   4 mentions for ./libyara/exception.h
- convention: clang-format:   9 mentions for ./libyara/atoms.c
- convention: clang-format:   4 mentions for ./cli/common.h
- convention: clang-format:   8 mentions for ./cli/args.h
- convention: clang-format:   7 mentions for ./cli/args.c
- convention: clang-format: source files: 12 skipped, 84 with no mentions, 43 with mentions in 1.231204 seconds
- convention: clang-format: 43 source files found with mentions; please fix
...
Testsuite summary for yara 4.0.2
# TOTAL: 16
# PASS:  16

However, there are so many files not matching clang-format that -- for now -- I commented out the line of the script which does the enforcing if the mentions are found. Should I just go ahead and fix all the files that clang-format disagrees with?

@plusvic regarding the CIFuzz failure... it looks like another random failure again, or? :-(

I submitted this again in https://github.com/VirusTotal/yara/pull/1426.


Validator: Reveal preimages according to expected height

When network falls behind on blocks, it creates a lot of blocks
in a short span and this results in some nodes to be slashed in the
process. If we reveal the preimage of the expected height instead
of the ledger height, we should decrease the chance of us getting
slashed in this scenario.

LGTM, but integration failure is probably because https://github.com/bosagora/agora/issues/3077 + the limitation on long-range pre-image to avoid DoS.

@Geod24 , added a second commit to fix #3077
will merge when CI is green


capv: upgrade to 1.1.0

Issue #, if available:
Description of changes:
This starts the update process for capv to 1.1.0.  There isnt a whole lot interesting here, except for the patches changes.  @vignesh-goutham and @mrajashree have upstreamed a couple of the old patches so I think all we need to keep is where we enable BR user data.
As far as the cluster-template and infra-components manifests.
The only change on the cluster-template is the kube-vip upgrade which @abhinavmpandey08 has been working on separately.
In the infra-components, there is a new field additionalDisksGiB which @vignesh-goutham said we shouldnt need to set.  The other changes deal with the kcp roles/bindings which do not appear to be an issue.
Holding and handing off to @abhinavmpandey08 to merge/finish when ready
/hold
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest


[Bug]: Error while creating mount source path (/host_mnt/Users/_user/.docker/run/docker.sock): operation not supported

Module
Core
Testcontainers version
1.13.0
Using the latest Testcontainers version?
Yes
Host OS
MacOS Sonoma 14.1
Host Arch
ARM64
Docker version
Client:
 Cloud integration: v1.0.35+desktop.5
 Version:           24.0.7
 API version:       1.43
 Go version:        go1.20.10
 Git commit:        afdd53b
 Built:             Thu Oct 26 09:04:20 2023
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.26.1 (131620)
 Engine:
  Version:          24.0.7
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.10
  Git commit:       311b9ff
  Built:            Thu Oct 26 09:08:15 2023
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.25
  GitCommit:        d8f198a4ed8892c764191ef7b3b06d8a2eeb5c7f
 runc:
  Version:          1.1.10
  GitCommit:        v1.1.10-0-g18a0cb0
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

What happened?
Testcontainer runs into an error when starting container.
Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: {"message":"error while creating mount source path '/host_mnt/Users/_user/.docker/run/docker.sock': mkdir /host_mnt/Users/_user/.docker/run/docker.sock: operation not supported"}
Relevant log output
Connected to the target VM, address: '<IP_ADDRESS>:52875', transport: 'socket'
2024-01-29 14:48:25,001 INFO  [main]- at o.t.d.DockerClientProviderStrategy::lambda$getFirstValidStrategy$1(DockerClientProviderStrategy.java:110)  Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first  |TAGS|
2024-01-29 14:48:25,335 INFO  [main]- at o.t.d.UnixSocketClientProviderStrategy::test(UnixSocketClientProviderStrategy.java:37)     Accessing docker with local Unix socket  |TAGS|
2024-01-29 14:48:25,335 INFO  [main]- at o.t.d.DockerClientProviderStrategy::lambda$getFirstValidStrategy$2(DockerClientProviderStrategy.java:119)  Found Docker environment with local Unix socket (unix:///var/run/docker.sock)  |TAGS|
2024-01-29 14:48:25,398 INFO  [main]- at o.t.DockerClientFactory::client(DockerClientFactory.java:137)                              Docker host IP address is localhost  |TAGS|
2024-01-29 14:48:25,427 INFO  [main]- at o.t.DockerClientFactory::client(DockerClientFactory.java:144)                              Connected to docker:
  Server Version: 24.0.7
  API Version: 1.43
  Operating System: Docker Desktop
  Total Memory: 15982 MB  |TAGS|

org.testcontainers.containers.ContainerLaunchException: Container startup failed

	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:322)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:302)
	at org.testcontainers.couchbase.CouchbaseContainer.startProxy(CouchbaseContainer.java:156)
	at org.testcontainers.couchbase.CouchbaseContainer.doStart(CouchbaseContainer.java:134)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:302)
	at com.company.messaging.async.auto.systemtests.general.CouchbaseContainerManager.getInstance(CouchbaseContainerManager.java:69)
	at com.company.messaging.async.auto.systemtests.general.CouchbaseContainerManager.setUp(CouchbaseContainerManager.java:89)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageNameFuture=java.util.concurrent.CompletableFuture@74075134[Completed normally], imagePullPolicy=DefaultPullPolicy(), dockerClient=LazyDockerClient.INSTANCE)
	at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1265)
	at org.testcontainers.containers.GenericContainer.logger(GenericContainer.java:600)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:311)
	... 8 more
Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: {"message":"error while creating mount source path '/host_mnt/Users/_user/.docker/run/docker.sock': mkdir /host_mnt/Users/_user/.docker/run/docker.sock: operation not supported"}

	at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.execute(OkHttpInvocationBuilder.java:287)
	at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.execute(OkHttpInvocationBuilder.java:265)
	at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.post(OkHttpInvocationBuilder.java:126)
	at com.github.dockerjava.core.exec.StartContainerCmdExec.execute(StartContainerCmdExec.java:28)
	at com.github.dockerjava.core.exec.StartContainerCmdExec.execute(StartContainerCmdExec.java:11)
	at com.github.dockerjava.core.exec.AbstrSyncDockerCmdExec.exec(AbstrSyncDockerCmdExec.java:21)
	at com.github.dockerjava.core.command.AbstrDockerCmd.exec(AbstrDockerCmd.java:35)
	at com.github.dockerjava.core.command.StartContainerCmdImpl.exec(StartContainerCmdImpl.java:46)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.testcontainers.dockerclient.AuditLoggingDockerClient.lambda$wrappedCommand$14(AuditLoggingDockerClient.java:99)
	at jdk.proxy2/jdk.proxy2.$Proxy29.exec(Unknown Source)
	at org.testcontainers.utility.ResourceReaper.start(ResourceReaper.java:94)
	at org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:155)
	at org.testcontainers.LazyDockerClient.getDockerClient(LazyDockerClient.java:14)
	at org.testcontainers.LazyDockerClient.listImagesCmd(LazyDockerClient.java:12)
	at org.testcontainers.images.LocalImagesCache.maybeInitCache(LocalImagesCache.java:68)
	at org.testcontainers.images.LocalImagesCache.get(LocalImagesCache.java:32)
	at org.testcontainers.images.AbstractImagePullPolicy.shouldPull(AbstractImagePullPolicy.java:18)
	at org.testcontainers.images.RemoteDockerImage.resolve(RemoteDockerImage.java:62)
	at org.testcontainers.images.RemoteDockerImage.resolve(RemoteDockerImage.java:25)
	at org.testcontainers.utility.LazyFuture.getResolvedValue(LazyFuture.java:20)
	at org.testcontainers.utility.LazyFuture.get(LazyFuture.java:27)
	at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1263)
	... 10 more

Test ignored.
Disconnected from the target VM, address: '<IP_ADDRESS>:52875', transport: 'socket'

Process finished with exit code 255

Additional Information
No response

Testcontainers version used is an old version and it was demonstrated that the setup works perfectly fine using testcontainers-java-repro and Docker Desktop. There are so many changes between 1.13.0 and 1.19.4. Also, the couchbase container implementation it different.

I'm also facing the error when I'm using latest version of test container with spring boot 3.2
I did not face the issue until yesterday when I ran the test through gradle except intellij. Now I'm facing the same issue when I ran it through gradle through command line as well.

Same issue here, as described by @ganesanarun

Can you share a project that reproduces the issue, please?

You can fix this by setting these properties.
Use docker context ls to get your docker endpoint.
For example, unix:///Users/<user>/.docker/run/docker.sock.
Then do these 3 things.
export DOCKER_HOST=unix:///Users/<user>/.docker/run/docker.sock
ln -sf /Users/<user>/.docker/run/docker.sock /var/run/docker.sock
export TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE=/var/run/docker.sock

That is how I got around this. Unfortunately, you can not just set TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE to /Users//.docker/run/docker.sock /var/run/docker.sock, it needs to point to the sym link (not sure why).
That should solve this issue at least it did for me.

I hit this issue on an older project using testcontainers 1.18.x.  Tests were working before, the only recent changes were upgrades to MacOS and colima.  Upgrading to 1.19.8 solved the issue for me.  My setup:

MacOS Sonoma 14.5
colima 0.6.9, installed through homebrew

The workaround does not work if you don't have root access on OSX.

What is suggested by @jlemay should work for old versions. New versions should discover the socket in different locations for Docker and Docker Desktop in macOS and linux. For other container runtimes there is no socket discovery but we have done our best to document was is needed here.


sorting / sortby method

I am trying to make a more generic table, one where I might not know all the property names.
I made a sample fork of the 'sortable columns' example on codepen (For simplicity, I removed the ID property):
http://codepen.io/getglad/pen/pEaOdk
The biggest change I have made is the rows section now looks like this:
<mdt-row ng-repeat="nutrition in nutritionList">
  <mdt-cell html-content="true" ng-repeat="(k, v) in nutrition">
    {{v}}
  </mdt-cell>
</mdt-row>

The table displays fine, but I have broken the sorting somehow. Now, no matter what column I try to sort, only 'calories' ends up getting sorted.
Any tips?
I wondered if I should be using mdt-custom-cell, but the example includes only a cell markup, nothing for row.
<mdt-custom-cell column-key="protein">
   5, 'green': value <= 5}">{{value}}
  click here
</mdt-custom-cell>

Maybe I'm missing something?

@getglad that's interesting. Give me some time to check it and try to resolve your issue.

I've managed to do something similar what you need. Hopefully it'll help you.
http://codepen.io/iamisti/pen/ozqWWB
The idea:

generating the keys based on the first item in your controller
passing and constructing the mdt-row attribute directive's input still in controller level
passing the constructed object to the view.

oh nice - thanks!

My pleasure to help you ;)

Hi,
I came across the same kind of requirement - making the table more generic. In my case, I don't know the column names and some of them could have a custom template - say you need to add a view/delete button in the last table column. How would you handle this? The problem that I have now is that ng-include is not working in mdt-custom-cell.


[Logistic Regression] Add transform and algorithm hyperparameters

build

build

Do we still need to skip tests in ci? https://github.com/NVIDIA/spark-rapids-ml/blob/branch-23.08/python/run_test.sh#L13

updated the tests to undo skip.

build


Updating master to swift 3

Includes:

swift 3 support
swiftier naming
more tests and better code coverage
updated readme

@mariusc Can you please update the travis file so it works? :)

@nickskull Yeah, I just realised it's not updated. Did it now, hope it works 😀

Current coverage is 95.84% (diff: 94.89%)

Merging #37 into master will increase coverage by 23.31%

@@             master        #37   diff @@
==========================================
  Files            15         18     +3
  Lines           324        337    +13
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            235        323    +88
+ Misses           89         14    -75
  Partials          0          0

Powered by Codecov. Last update 151be0e...5b9966a


Feature/solrcloud

An extension to pysolr to make it Zookeeper/SolrCloud aware. This is cloned from the code in the SolrJ client.
The tests are limited to proving that this does not break existing functionality, although I have tested (manually) that it does correctly failover between nodes when a node in a cluster fails.

+1 - I need this in my environment.

Any suggestions as to what is holding this patch back from a merge? Thx!
(I notice there's conflicts which I will resolve)

I would really like this feature to be merged in; what needs to be done to make that happen, apart from conflict resolution?

Beyond conflict cleanup & a quick style review, the main thing I'd want to see would be updating the test runner so it continues to test regular Solr along with running an instance with SolrCloud enabled.
The install packaging also might want a little review – this was rolled into the Tomcat target but seems like it should be a separate one, particularly since the Solr project has itself deprecated deployment on Tomcat.

That said, if you have time to work on this, I can review & ship a release.

I can look into that, @acdha

@upayavira awesome, thanks!

@acdha I've made some reasonably substantial changes to this PR. Basically, instead of starting Solr and getting on with it, we now need the tests to start/stop the correct type of Solr, so I improved your start-solr-test-server.sh script to prepare and start both non-cloud and cloud instances, and then extended the tests to make them able to start the right Solr in their setupClass method.
By extending the SolrTestCase with a SolrCloudTestCase, I was able to have most of your existing tests run a second time against a solrcloud instance.
The tests seem to consistently pass, but for some reason seem to hang at the end, for reasons I have yet to identify.
I am considering rewriting start-solr-test-server.sh in Python, but more importantly I want/need a test that hits Solr repeatedly whilst killing one of the two nodes that contains the collection being queried. Note, it starts three Solr nodes, one for Zookeeper and two to host collections. This means we can kill either of the collection nodes without disrupting Zookeeper.
Please let me know what you make of this (rather substantial) PR. Comments/suggestions welcome, before I start writing the above, more complex, test.

For what it's worth, the tests work on my machine (macos 10.10.5) once I change to the feature/solrcloud branch and I install kazoo.  I have these messages, but I think they're in kazoo, not pysolr:
Waiting for simple-solr ----No handlers could be found for logger "kazoo.client"
No handlers could be found for logger "kazoo.client"

@upayavira I've made some changes in https://github.com/upayavira/pysolr/pull/1. I definitely agree that we're probably close to the point where we should just port the server launcher to Python since we have a bunch of daemons to manage now and will want things like timeouts for hard-kills on the various processes.

The main problem I'm seeing is that KazooClient may leak connections which will block shutdown endlessly trying to reconnection. I don't have time to finish debugging this but it did lead to a lot of cleanup.

https://github.com/acdha/pysolr/tree/138-solrcloud now has stable tests. The biggest change was in https://github.com/acdha/pysolr/commit/67dcc640d1b668495cfd39eae53495363cb9498a which changed the way we start and stop Solr/SolrCloud to avoid spending most of our test runtime starting and stopping them and prevent tests from hanging where the tests all passed but the KazooClient atexit hacks prevent the system from exiting until they can restore a connection to the ZooKeeper instance which was already shut down by that point.

The starting and stopping of Solr for each test case was intentional - as another test is needed - one that confirms that calls to Solr still work once a node has been shut down.
However... I've since worked out that, if we assume we are on Unix, we could achieve that by using kill -17 $PID to stop a Solr instance (equivalent to CTRL+Z at a terminal) and kill -19 to start it again. That would actually be compatible with having both nodes started at the beginning of the test run, and stopped at the end, so your simplification should actually be fine.
I have some other improvements that I made before I saw your work on this - I'm currently working on merging them, which is somewhat tough because we both touched very much the same stuff.

Yes – sorry about that. I strongly prefer the approach of using kill -STOP / -CONT on an instance or starting a third one just for those tests because starting and stopping Solr is bad enough even without restarting ZooKeeper a few times and I'd really like to avoid performance discouraging people from running the tests.

Absolutely - I now see the kill -STOP thing is way better, but I only worked that out this morning - before that I was assuming I would need to start/stop instances. On other words - nothing to apologise for - I'm appreciating your work.

Right now, I'd like to get the excluded failures resolved and review the coverage impact for this.
I've been seeing a bunch of other things which I'd like to fix which aren't specific to this branch so I'd like to plan to merge this fairly soonish so we can get ready for a 4.0 release with some of the hairier old bits of code removed.

One thing I should note - we are testing this against 4.10.4. I'm not sure when it happened, but I suspect after that - Solr moved away from a single clusterstate.json to having a file per collection. Thus, this code isn't compatible with Solr instances in the 5.x range - we will need to have that handled before a major release as it will be expected. I don't envisage that to be hard, but it will need doing.

https://github.com/acdha/pysolr/commit/d26016b37bb801864017aa11d71066052d491cab gets some of the remaining tests flagged as expected failures but might want to be a little cleaner in how it handles the core names.

Agreed on the need to handle both versions. It would probably be a good idea to think about how to handle this – I'm initially disinclined to have SolrCloud4 and SolrCloud5 classes if we can just use something like a solr_version constructor option or something like that but maybe there's something to be said for putting it into the class name to make it explicit.

As of right now, we're at ~83% test coverage with most of the uncovered code being in getAliasHosts

I added a simple checklist points to the description on this ticket. Feel free to add more as they come up.
If we reach the point where this seems stable before getting to the more complicated tests, I could merge the working branch to master & we can start new pull requests from that point.

From my understanding of the changes in Solr 5, we should be able to make it handle both - it watches both locations and adapts depending on what it finds in Zookeeper.
I agree with your plan to stabilise what we have and merge it before looking at additional tests/features.

@upayavira I'm taking a bit of a break from this today if you want to make some changes without worrying about us stepping on each other. I'd like to have something ready to merge by next week so we can polish it a bit. It'd be really nice to see if we could hit 100% test coverage for a release.

I presume by 100% test coverage you mean that all tests pass? That should now be the case. I also raise a few more explicit SolrErrors in there too. Let me know what you think.

@upayavira I was thinking that we have 100% coverage of the new code by the test suite. It looked like most of the remaining gaps were in error-handling, which is definitely easy to miss in future changes.

master now has a few minor updates, the most notable being https://github.com/acdha/pysolr/commit/d23de5825be37a039e2946ecda056a3e723e4954 to ensure that the byte-strings containing JSON are decoded first before passing them to json.loads

https://github.com/acdha/pysolr/commit/cbc07af56c6a32ead3e90efbc0cdb5bf13cd2e05 adds an env: option to Travis CI so the tests are run with and without Kazoo installed, with the ~32 SolrCloud tests skipped in the latter case.

I have some initial/prototype code that should work with both 4.x and 5.x for SolrCloud, and also implements some of the Collections API for creating/deleting collections/etc. I'll post it as a fresh PR once I've played with it a bit more. Really though, as with the above code, it will need some decent tests around it to prove it behaves properly in failover scenarios.

Hi all,
Where do we stand on this?  Is there a sense that pysolr 4.0 will be coming out soon-ish (ie, next two weeks), or should I go ahead and use this branch as a one-off in a private pypi?
Thanks!

+1 I really need the custom search_handler in a released version.  Tired of pulling from the tip instead of the pip.  thanks in advance!

I don't think we're ready for 4.0 yet unless someone has time to help add tests – in particular, it'd be good to start testing with Solr 5 as well as 4.x.

I have a test for failover which seems to work (it passes). I need to add one in which both nodes are down and confirm that it fails.
This code WILL NOT work with Solr 5.x. I've got as far as working out exactly what we need to do (and have some hacked, unpublishable code), but just need to find the time to make it happen.

Upayavira, can you expand on where it won't work?   I have at work pysolr
working with Solr 5 in a non-cloud mode, and I'm anticipating a switch to
cloud.
I have a test for failover which seems to work (it passes). I need to add
one in which both nodes are down and confirm that it fails.
This code WILL NOT work with Solr 5.x. I've got as far as working out
exactly what we need to do (and have some hacked, unpublishable code), but
just need to find the time to make it happen.
—
Reply to this email directly or view it on GitHub
https://github.com/django-haystack/pysolr/pull/138#issuecomment-193972263.

When Solr 4.0 released, SolrCloud stored its cluster information in clusterstate.json - every collection in a single file in Zookeeper. This worked, but people started building clusters with 1000s of collections, leading to an unmanageable file. Therefore, somewhere around the 5.0 mark it switched to having a per-collection state.json file. This allows a zookeeper client to follow just the collections it is interested in.
I don't see any reason why the client cannot be coded to handle both setups. We would need a way to test against both, though, which might require two different Solr installs to run our tests against.

See https://github.com/django-haystack/pysolr/pull/187 for further work here. Should we close this PR now?

Test coverage for ZooKeeper / SolrCloud error states

If you can clarify what you are looking at here, I can look into that.

Support SolrCloud 5 and have a Travis test matrix entry for both major versions
Solr 5.x support is in PR #187 .

I plan to pull the start-solr-test-server.sh for 4.10, rename it start-solr-test-server-4.10.1.sh, and add a way that run-tests.py can use one or the other. That'll mean we can have a Travis run for each version, both using the latest (5.x compatible) code.

Add test that confirms that Pysolr fails-over correctly when one of the Solr nodes disappears (can be simulated with kill -STOP and kill -CONT)

This test is, again, in PR #187 . I accept that I should have separated PR 187 into three PRs, but they kinda all happened at the same time. If you want them separating, let me know and I'll see how possible that is.

@upayavira The main thing I was thinking is confirming that we do something reasonable when ZooKeeper itself has either failed outright or is unresponsive. I think that'd just be a question of making sure our timeouts are used and that something useful is logged.
Since you have a test in #187 I checked the failover tests off the list here.

I've been working all morning on the failover tests. Getting them right isn't easy. It seems that a kill -17 does not cause a change the live_nodes entry in ZooKeeper, so we cannot use a kill -17.
Test scenarios:

Does it handle when one replica is down for a shard of a collection?
Does it fail gracefully when there are no nodes available for a shard/collection?
Does it fail gracefully if it cannot connect to ZK, and recover once ZK comes back?

These are non-trivial tests. The code under test is WAY simpler. I'm mulling now on how to implement them, but I'm open to suggestions,

One thing I've been wondering is whether it makes sense to merge the work-in-progress here and postpone some of the more involved tests or simply defer them entirely to Kazoo or the upstream ZK/Solr projects and instead just use something like mock.patch to confirm that our logging code, etc. works when the important KazooClient methods raise exceptions.

See code in #187 , just committed. I believe it does the job for the above three test scenarios. It turns out it was important to get the tests right, as they did show up one particular bug (not readding a watch when a watch is triggered).
All that is left is support for both 4.x and 5.x. And, by comparison, that is seriously trivial!

I've now got code that works against both 4.x and 5.x. You can set an environment variable to tell it which startup script to use (which version of start-solr-test-server.sh), i.e. the 4.x or the 5.x one. Thus, it should be possible to keep a version of each running in Travis.
This also involved redoing the retry logic somewhat. Solr 4.10 wasn't updating its cluster state as fast as it should, so I made it, by default, retry every 0.02s, and retry 20 times. I saw maybe 4 or 5 retries needed in my tests. These can be overridden on the SolrCloud constructor. I also needed to call random.seed() as random.choice was giving me the same value every time.
I will commit this work against #187 as soon as I get a next moment.

@upayavira that's excellent news!

Moments have been far apart, but #187 now has my latest changes. You can run the tests against 5.5 with:
./run-tests.py
or against 4.10.1 with:
PYSOLR_STARTER=./start-solr-test-server-4x.sh ./run-tests.py
Add both of these to Travis, and you should have good test coverage.


Large memory consumption

Hi, thanks for your nice work.
On a large dataset like ImageNet, proposed self-attention mechanism consumes large amounts of memory because of unfold operation (im2col).
One would want to share point-wise feature vector among sliding windows.
Do you have any idea?

Thanks for comments.
I didn't think of a more efficient way. I will think about the effective self-attention mechanism. If you have a good way, send pull request.
Thank you.

Got it. Thanks.


json adapter

This is a generic JSON adapter that can be used with Logstash, but doesn't need to be. Its fields can be configured with environment variables, with minimal default fields enabled, and a few useful premade fields that can be enabled.

@progrium any update on this?

I would really love to see this feature merged.

Another +1 on getting this merged.

@progrium Any way we can get map types properly converted to json before this PR is merged?  I tried running this branch on a dev box to see what {{.Container.Config.Labels}} would look like, but it doesn't appear the types map properly reads maps to end up being json marshalled correctly.
example json pretty print of a syslog message with json adapter and labels field
{
  "docker": {
    "hostname": "6965fdb0f180",
    "image": "centos:centos7",
    "labels": "map[name:CentOS Base Image vendor:CentOS build-date:2015-12-23 license:GPLv2]"
  },
  "message": "test",
  "time": "1453494436"
}

Ran with following env vars
JSON_FIELDS="time:uint,message,docker.hostname,docker.image,docker.labels"
JSON_DOCKER_LABELS="{{.Container.Config.Labels}}"

Thoughts?

That looks like an easy fix. Also I'm surprised this was never merged. Maybe it would be a good idea to merge this and then talk about fixing that as a separate issue that others might be able to help with?

@progrium either way is fine.
Any ideas how the marshalling would be fixed?  Looking at golang json docs seems like it would be marshalled correctly by default for known types.  Is the use of the template render causing this?  Haven't looked too deeply at it plus I'm a go beginner.

Yeah I'm assuming it's some oversight where I assume some variable is going to be a string. I haven't looked at the code in a while. I'm just, you know, swamped. Also still looking for another maintainer for this project.

Ugh, and it needs to be rebased now too. Maybe neeeext week? :\

Hehe No rush on my part.  I can always build and use locally with the changes 8-).

@progrium  one thing I noticed was this code is using the stock udp transport.  I had a specific need to send JSON over a valid syslog message.  So i'll possibly fork and re-use some of this json code by adding a new MODE to the syslog adaptor configured by environment variables.  The idea would be to send JSON payload in the "message" portion of a syslog message where this payload is configured via environment variables as you've already started on this branch.
High level goal is JSON payload + syslog (udp or tcp).

No reason adapters can't use each other. If there was a way to refactor this so that syslog could be configured to use it (and all its JSON configuration) in its messages that would be rad. Try and explore that in your fork and if you come up with anything let us know!


Duels of Dreams update

Submission Checklist
Required

[ x] The pull request title clearly contains the name of the sheet I am editing.
[ x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x ] The pull request makes changes to files in only one sub-folder.
[x ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ x] This sheet has been made on behalf of, or by, the game's publisher.
[x ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <  https://duelsofdreams.com/ >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
added skill images, a points tab, a collapsing compact skill view, and a buncha auto-calculations for skills and the point buy table. Also fixed a bug where the tabs weren't working.

Character Sheet Info Roll20 Internal Use only.

added skill images, a points tab, a collapsing compact skill view, and a buncha auto-calculations for skills and the point buy table. Also fixed a bug where tabs weren't working.

Hey @danimagaming ,
Looks like you updated the sheet to CSE with this PR, removing .sheet- prefix, etc.  You'll want to update the sheet.json as well, namely changing "legacy": true to "legacy": false, or the sheet's not going to take your CSS once live.  Once you've swapped that out, this should be good to go.
That said, it looks like you've also got two screenshots in this folder, one of the older design and one newer.  You'll want to change "preview" in your sheet.json too, to point towards this newer screenshot, or rename the new screenshot to DODAS.png.  That way, the preview image in the game listing will accurately portray the current appearance of the sheet.
Thanks!

Ah, good catch. Thanks, I'll get on that!
On Wed, Nov 15, 2023 at 5:40 PM Lucas Hall @.***> wrote:

Hey @danimagaming https://github.com/danimagaming ,
Looks like you updated the sheet to CSE with this PR, removing .sheet-
prefix, etc. You'll want to update the sheet.json as well, namely changing "legacy":
true to "legacy": false, or the sheet's not going to take your CSS once
live. Once you've swapped that out, this should be good to go.
That said, it looks like you've also got two screenshots in this folder,
one of the older design and one newer. You'll want to change "preview" in
your sheet.json too, to point towards this newer screenshot, or rename the
new screenshot to DODAS.png. That way, the preview image in the game
listing will accurately portray the current appearance of the sheet.
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/12299#issuecomment-1813380230,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APDO2QRM5JFFNXEUCFN5Q4TYEVAFVAVCNFSM6AAAAAA7LLN4WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGM4DAMRTGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Encyclopedia entity not showing up

The pre-built encyclopedia entity isn't showing up to choose. What can we do?

We will need to review the lab and see what has changed. We do regular sweeps through the content, but it is still a challenge to keep up.

So it appears that the prebuilt encyclopedia entity has been removed:
https://docs.microsoft.com/en-us/azure/cognitive-services/luis/luis-reference-prebuilt-deprecated
We will need to rewrite the lab, or at least do a heavy revision.

You can find a great LUIS lab here: https://docs.microsoft.com/en-us/learn/modules/create-and-publish-a-luis-model/
We are deprecating the lab found on this repo in favor of Microsoft Learn.


Error parsing formula

For the attach xls file and I tried with http://oss.sheetjs.com/js-xlsx/, the formula for C1 is wrong (it should be "A1+B1" while the program returns "0,2"
Book1.zip

@oepdtt Formula parsing was overhauled in 0.8.4.  This appears to be a case of a shared formula and it works in the current version.


(displayfusion) Update update.ps1

Description

URL handling so the update will not fail when the beta URL is temporarily invalid.
Motivation and Context

Fixes Issue #1655
How Has this Been Tested?

Tested in my AU environment with:
.\test_all.ps1 displayfusion

Updating 1 automatic packages at 2021-05-14 07:58:29 (forced)
Push is disabled
NoCheckChocoVersion is disabled
FORCE IS ENABLED. All packages will be updated
   [1/1] displayfusion is updated to 9.8 (11.15s)

Running Report
Saving markdown report: C:\Users\virtualex\Documents\GitHub\chocolatey-packages\Update-Force-Test-.md

Finished 1 packages after .21 minutes.
1 updated, 0 pushed, 0 ignored
0 errors - 0 update, 0 push.

Screenshot (if appropriate, usually isn't needed):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[x] All files are up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

@virtualex-itv your changes have been merged, thanks for your contribution 👍
I have made some changes to the update script so that the stable stream will fail all other streams, and the unstable stream is specifically set to ignore if it fails.