Avoid reformatting long commented comma-separated sequences

First of all, thanks for all your work on this tool, it's great having a automatic formatter with generally good defaults! However, I've got a block in a test function for a decoder like this:
        const DATA: &'static [u8] = &[
            0x42, 0x50, 0x54, 0x44,  //type
            0x23, 0x00, 0x00, 0x00,  //size
            0x00, 0x00, 0x04, 0x00,  //flags
            0xEC, 0x0C, 0x00, 0x00,  //id
            0x00, 0x00, 0x00, 0x00,  //revision
            0x2B, 0x00,  //version
            0x00, 0x00,  //unknown
            0x42, 0x50, 0x54, 0x4E,  //field type
            0x1D, 0x00,  //field size
            0x19, 0x00, 0x00, 0x00,  //decompressed field size
            0x75, 0xc5, 0x21, 0x0d, 0x00, 0x00, 0x08, 0x05, 0xd1, 0x6c,  //field data (compressed)
            0x6c, 0xdc, 0x57, 0x48, 0x3c, 0xfd, 0x5b, 0x5c, 0x02, 0xd4,  //field data (compressed)
            0x6b, 0x32, 0xb5, 0xdc, 0xa3  //field data (compressed)
        ];

This was unchanged by rustfmt 0.4.1 (Rust 1.26.0), but rustfmt 0.4.2 reformats this as:
        const DATA: &'static [u8] = &[
            0x42,
            0x50,
            0x54,
            0x44, //type
            0x23,
            0x00,
            0x00,
            0x00, //size
            0x00,
            0x00,
            0x04,
            0x00, //flags
            0xEC,
            0x0C,
            0x00,
            0x00, //id
            0x00,
            0x00,
            0x00,
            0x00, //revision
            0x2B,
            0x00, //version
            0x00,
            0x00, //unknown
            0x42,
            0x50,
            0x54,
            0x4E, //field type
            0x1D,
            0x00, //field size
            0x19,
            0x00,
            0x00,
            0x00, //decompressed field size
            0x75,
            0xc5,
            0x21,
            0x0d,
            0x00,
            0x00,
            0x08,
            0x05,
            0xd1,
            0x6c, //field data (compressed)
            0x6c,
            0xdc,
            0x57,
            0x48,
            0x3c,
            0xfd,
            0x5b,
            0x5c,
            0x02,
            0xd4, //field data (compressed)
            0x6b,
            0x32,
            0xb5,
            0xdc,
            0xa3, //field data (compressed)
        ];

which is a pain to read/scroll past. If I remove the comments, rustfmt 0.4.2 instead formats it as:
        const DATA: &'static [u8] = &[
            0x42, 0x50, 0x54, 0x44, 0x23, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0xEC, 0x0C,
            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x2B, 0x00, 0x00, 0x00, 0x42, 0x50, 0x54, 0x4E,
            0x1D, 0x00, 0x19, 0x00, 0x00, 0x00, 0x75, 0xc5, 0x21, 0x0d, 0x00, 0x00, 0x08, 0x05,
            0xd1, 0x6c, 0x6c, 0xdc, 0x57, 0x48, 0x3c, 0xfd, 0x5b, 0x5c, 0x02, 0xd4, 0x6b, 0x32,
            0xb5, 0xdc, 0xa3,
        ];

which seems sensible to me, but the comments are useful for indicating the structure that's in the sequence of bytes being tested, and I'd rather not get rid of them.
I think the best way I can explain what I'd expect is that if a line consists of a comma-separated sequence with a trailing comment, the sequence should not be split across lines unless it's too long to fit on one, in which case maximum use of the line width should be used. To give another example that invokes the 'unless' above, given:
        const DATA: &'static [u8] = &[
            0x42, 0x50, 0x54, 0x44, 0x23, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0xEC, 0x0C, 0x00, 0x00, //comment
            0x00, 0x00, 0x00, 0x00, 0x2B, 0x00, 0x00, 0x00, 0x42, 0x50, 0x54, 0x4E, 0x1D, 0x00,
            0x19, 0x00, 0x00, 0x00, 0x75, 0xc5, 0x21, 0x0d, 0x00, 0x00, 0x08, 0x05, 0xd1, 0x6c,
            0x6c, 0xdc, 0x57, 0x48, 0x3c, 0xfd, 0x5b, 0x5c, 0x02, 0xd4, 0x6b, 0x32, 0xb5, 0xdc,
            0xa3,
        ];

I'd expect this to be reformatted as:
        const DATA: &'static [u8] = &[
            0x42, 0x50, 0x54, 0x44, 0x23, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0xEC, 0x0C,
            0x00, 0x00, //comment
            0x00, 0x00, 0x00, 0x00, 0x2B, 0x00, 0x00, 0x00, 0x42, 0x50, 0x54, 0x4E, 0x1D, 0x00,
            0x19, 0x00, 0x00, 0x00, 0x75, 0xc5, 0x21, 0x0d, 0x00, 0x00, 0x08, 0x05, 0xd1, 0x6c,
            0x6c, 0xdc, 0x57, 0x48, 0x3c, 0xfd, 0x5b, 0x5c, 0x02, 0xd4, 0x6b, 0x32, 0xb5, 0xdc,
            0xa3,
        ];

but it gets printed one element per line like my previous example. Can this be changed to be more like my expectation?

I just noticed that this is the same issue as #2619.


Why was timesync disabled?

RE: https://github.com/Azure/acs-engine/blob/master/parts/k8s/kubernetescustomscript.sh#L503
Is this because of bugs in the kernel implementation, or is this because kubelet/kubernetes can't handle the clock shifts?
For users on newer kernels, unaffected by that bugfix, is it safe to enable TimeSync (or rather, not disable it)?

I don't really get it. Maybe the clock adjustment was jumping such that apt wasn't triggering? Blame traces the change back to this PR at least: https://github.com/Azure/acs-engine/pull/817
Anyway, seems like it's less about Kubernetes and more of an apt-ism, so I'm going to go ahead and close this.


Timeout issues when adding/editing cluster or conifg

Hey! Thanks for the nice tool!
Just a FYI, I was having timeout issues when creating or editing clusters on the docker image. I went into the container and noticed that the talosctl command was running multiple times, and seems like it was stuck as it didn't exit.
It works fine if I run it without docker tho!

Thanks for checking in!
Unfortunately I can't really do anything about it without a way to reproduce the issue.
Feel free to provide some steps to reproduce, including details of your hardware and OS etc and we can consider re-opening the issue.


Feature request: autofixable check for -> None return of __init__(self) with no other arguments

mypy has this somewhat silly rule that you have to annotate an __init__ that doesn't have any arguments beyond self with -> None: https://mypy.readthedocs.io/en/stable/class_basics.html#annotating-init-methods
It would be great if ruff could automatically fix this!

Oh yeah, we can definitely do that. I think this would be considered an autofix of ANN204.

Let me know if this works for you once the next release is out. You may also want to set:
[tool.ruff.flake8-annotations]
mypy-init-return = true

Otherwise, it'll always add -> None to __init__ (instead of only doing so when it has no typed arguments).

Will do!

Should be live in v0.0.184 :)


Can you provide a training log of one SparseInst model?

This is an excellent paper, and I am trying to implement SparseInst on another dataset.
Thus, I am wondering to verify whether the training losses decreased in the right way.
Thanks.
Jiaheng.

This issue will be closed, you can open a new issue if you have other problems or reopen it. Thanks for your interest in SparseInst 😊 . If you find it useful in your work or research, could you give us a star 🌟 or help us recommend SparseInst to your friends.


feat(form-field-text-like): add loading spinner

Add loading spinner
GDS-2094

The only issue I see (and it is a pretty small one), at excessively small widths the loading indicator (and clear input button) kind of break. There should probably be a minimum width to display both of these.

The only issue I see (and it is a pretty small one), at excessively small widths the loading indicator (and clear input button) kind of break. There should probably be a minimum width to display both of these.

Hi Thomas, I'll follow this up with design and add a follow-on ticket for it. In the meantime, I'm going to move this along if that's ok?

The only issue I see (and it is a pretty small one), at excessively small widths the loading indicator (and clear input button) kind of break. There should probably be a minimum width to display both of these.

Hi Thomas, I'll follow this up with design and add a follow-on ticket for it. In the meantime, I'm going to move this along if that's ok?

That seems reasonable to me.


Google Sign-in platform deprecated, use GIS ?

Hello,
I am using the lib, working, but cant login or do whatever as I get this on the console:
{
    "error": "idpiframe_initialization_failed",
    "details": "You have created a new client application that uses libraries for user authentication or authorization that will soon be deprecated. New clients must use the new libraries instead; existing clients must also migrate before these libraries are deprecated. See the [Migration Guide](https://developers.google.com/identity/gsi/web/guides/gis-migration) for more information."
}

They seem to say the method (with init etc.) used by vue-gapi is deprecated and should migrate to GIS ? Is that real ????
Thank you

Yeah, thanks for flagging, @kpoman. Per this blog:

On March 31, 2023 we will fully retire the Google Sign-In JavaScript Platform Library and would like to remind you to check if this affects your web application, and if necessary, to plan for a migration.
Beginning April 30th, 2022 new applications must use the Google Identity Services library, existing apps may continue using the Platform Library until the deprecation date.

We'll plan to make updates to this library in the next major version (v3), as I imagine there will be some breaking changes.

I this is the case, then how can we use this library in our current project ?

Any update for this library to use the new Google Identity Services library?

Yes, this project should probably be combined with the Vue GSI (https://vue3-google-signin.syetalabs.io/) project. They're highly interrelated.

Thanks, @RichardJECooke!
v2.1.2 adds a deprecation notice pointing to that project, which we would encourage you to use.


Ability to trigger a dialog on "DialogComplete" event

Is your feature request related to a problem? Please describe.
As a dialog designer I want to execute common dialog logic at the end of all dialogs. For example, Feedback or sending an event at the end of a Dialog (e.g. EndOfConversation for skills)
Describe the solution you'd like
Ability to trigger a dialog when a dialog has ended, the composer equivalent of doing this in code is below but requires a composer dialog to be manually changed to use AdaptiveDialogEx :-(
 public class AdaptiveDialogEx : AdaptiveDialog
 {
       public async override Task EndDialogAsync(ITurnContext turnContext, DialogInstance instance, DialogReason reason, CancellationToken cancellationToken = default)
       {
            // Custom logic
            await base.EndDialogAsync(turnContext, instance, reason, cancellationToken);
       }
 }

Describe alternatives you've considered
As above, derive your own implementation of AdaptiveDialog

@vishwacsena  any thoughts ?


Fix a data collector issue in the Twig Components

Q
A

Bug fix?
yes

New feature?
no

Issues
-

License
MIT

Before

After

It took me a minute before seeing it 😆


`match': invalid byte sequence in  UTF-8 (ArgumentError) on Windows

System

OS:Windows
ruby -v: ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x64-mingw32]
bundle -v: Bundler version 2.1.4
bundle info arduino_ci:

 * arduino_ci (1.1.0)
        Summary: Tools for building and unit testing Arduino libraries
        Homepage: http://github.com/Arduino-CI/arduino_ci
        Path: D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0

Issue Summary
Hello
When I run bundle exec arduino_ci.rb --skip-examples-compilation and the "libraries/symlink" exists I have an error :
Installing library under test... Traceback (most recent call last):
        11: from D:/Progs/Ruby27-x64/bin/arduino_ci.rb:23:in `<main>'
        10: from D:/Progs/Ruby27-x64/bin/arduino_ci.rb:23:in `load'
         9: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/exe/arduino_ci.rb:399:in `<top (required)>'
         8: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/exe/arduino_ci.rb:129:in `assure'
         7: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/exe/arduino_ci.rb:102:in `perform_action'
         6: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/exe/arduino_ci.rb:400:in `block in <top (required)>'
ll_local_library'
         4: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/lib/arduino_ci/host.rb:93:in `symlink?'
         3: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/lib/arduino_ci/host.rb:106:in `readlink'
         2: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/lib/arduino_ci/host.rb:106:in `map'
         1: from D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/lib/arduino_ci/host.rb:106:in `block in readlink'
D:/Progs/Ruby27-x64/lib/ruby/gems/2.7.0/gems/arduino_ci-1.1.0/lib/arduino_ci/host.rb:106:in `match': invalid byte sequence in
UTF-8 (ArgumentError)

Note that everything is ok when I run it when the symlink in the Arduino libraries folder doesn't exists.
After some internet research I solved it but replacing the line (host.rb:106) :
- symlinks = stdout.lines.map { |l| DIR_SYMLINK_REGEX.match(l) }.compact
+ symlinks = stdout.lines.map { |l| DIR_SYMLINK_REGEX.match(l.scrub) }.compact

As I don't know Ruby or your code I have no clue on the consequences of this change but I guess it may be a good start for experts to solve this :)
I wish you a good day !

Hy Nykkolas, thanks for reporting this.  I don't have access to a windows machine so I'm entirely reliant on reports like yours to improve that aspect of the library!
I will probably use the fix you suggested, it looks like the correct one (and if not, unit tests should catch it).
What locale is your system running?  Also, I'm eager to hear your experience in general of using arduino_ci on Windows in a symlinking situation.  Basically, my library has to cover the possibility that the project directory might not be located in the system's Arduino/libraries directory.  Symlinks are the easiest way to accomplish that, but in Windows they don't work the same way as in OSX/Linux.  If you notice any incorrect behavior there (or can think of a better way to accomplish it) please don't hesitate to open more issues

Hi Ian
Thanks for your answer !
My locale is  fr;Français (France)
I use windows like 10% of the time but I'll be pleased to let you know what happens on it. Until now, the only strange thing with symlinks under windows is that you can use them only as an administrator, in a command prompt started as administrator or if you change the security parameters to "development mode".


Extending reporting period duplicates period names

When time-aware target periods already exist for an indicator, and the reporting period end date is pushed out beyond the last target period, additional target periods are automatically generated when the indicator modal window is opened.  The numbering for these target periods is reset to 1, so duplicate Year 1, Year 2, etc... would be created for annual periods.  The time values themselves are correct, just the label is incorrect.
The new label numbering should follow in sequence from the last existing period.

Note - clicking the datepicker in the reporting period modal resets the date to current (losing the information that prepopulated the field)

I extended the reporting period by one year, from 2021 to 2022, like so:

Annual periods numbered correctly: Year 5 added after Year 4. Date ranges look good.
Semi-annual periods numbered correctly: Periods 9 and 10 after period 8. Date ranges look good.

I couldn't find quarterly, tri-annual, or monthly examples, so I set those up and extended the period from 2022 to 2023

Tri-annual periods numbered correctly: Period 19 after 18, date ranges look good.
Quarterly periods numbered correctly: Q21 after Q22. Date ranges look good.
Monthly periods numbered correctly: May 2023 after Apr 2023, date ranges look good.

@sanjuroj Something I noticed that may or may not be expected behavior:
If I extend the reporting period, I have to enter values for ALL newly generated periods before those periods will show up in the Target vs Actuals IPTT.
I feel like this may be just fine, but want to validate that nothing has changed in this regard.

We should see if there are existing indicators with duplicated labels in the production database.


Update README.md

I can't merge this, because only subaddresses start with 8 and integrated addresses do not work with subaddresses.


No usage explain in game

Hey man.
O saw you write some usage explain inside the code, but its not show in game.
Can you pls add some explain?
if you want, i wrote some code for lua file.
            confUsage = {
                name = "Usage",
                order = 6,
                type = "group", inline = true,
                args = {
                    confversiondesc = {
                    order = 1,
                    type = "description",
                    name = ""
                        .."After select your preferred font."
                        .."\n"
                        .."Restart Client for changes to take affect!"
                        .."\n"
                        .."If Font not work as expect, select other.",
                    cmdHidden = true
                    },
                }
            },

Add this after last description. desc1 in "Nice Damage - Refreshed.lua" file

Hey @kaiseryoda - this is a good point, once I get some time this weekend I will take a look at this and see about getting something into production 👍


The flows:started event listener is not removed when the node is closed

Describe the bug
Was looking into the cause of the below stack trace and noticed that the flows:started listener is not getting removed on node close.
This is not the issue with the warning I am getting as I have over ten scheduler nodes in the workspace and each registers a new event listener going over the default max listener limit.
https://github.com/jensrossbach/node-red-contrib-chronos/blob/4faf519f1541667868cfb8c982e182ab41f1f47e/nodes/scheduler.js#L248
17 Sep 01:05:49 - [info] Started flows
(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 flows:started listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
    at _addListener (node:events:601:17)
    at EventEmitter.addListener (node:events:619:10)
    at EventEmitter.<anonymous> (/usr/src/node-red/node_modules/@node-red/util/lib/events.js:44:33)
    at new ChronosSchedulerNode (/data/node_modules/node-red-contrib-chronos/nodes/scheduler.js:248:28)
    at Object.createNode (/usr/src/node-red/node_modules/@node-red/runtime/lib/flows/util.js:90:27)
    at Flow.start (/usr/src/node-red/node_modules/@node-red/runtime/lib/flows/Flow.js:206:48)
    at Object.start [as startFlows] (/usr/src/node-red/node_modules/@node-red/runtime/lib/flows/index.js:394:33)

To reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Context information
Please complete the following information.

Platform & OS: docker - Linux 5.4.0-125-generic x64 LE
node-red-contrib-chronos version: 1.18.1
Node-RED version: 3.0.2
Node.js version: 16.16.0

Additional information
Add any other information about the problem here.

Fixed with release 1.18.2.

@zachowj With release 1.18.3 I did some further improvements by only registering for flows-started events if next event time option is activated (because the triggers are only needed in this case) and immediaterly unregistering the listener as soon as the event has been received.


Problem when shifting labels to zero in binary classification problems with negative labels

Hello!
I would like to report a possible bug.
Code: v2s_main.py
Lines: 43-45
When we have multi-class problems, such as ECG 5000 where the original labels are [1,2,3,4,5], the mod function applied in lines 43-45 shifts the labels to zero correctly, so we obtain the values [0,1,2,3,4] as labels.
However, when we have binary classification with negative labels, such as ECG 200, where the original labels are [-1,1], the mod function used yields 1 as remainder for both cases, and the label vector becomes an array of ones.
Do you agree?

Hello @DominguesPH, thank you for asking.
I think in the L30 of v2s_main.py https://github.com/huckiyang/Voice2Series-Reprogramming/blob/main/v2s_main.py#L30
    y_train[y_train == -1] = 0
    y_test[y_test == -1] = 0

We pre-assigned negative labels back to positive values.
If you want to use the other dataset containing negative values, please consider to value check.
Hope this clarifies your question.

Hello @DominguesPH, thank you for asking. I think in the L30 of v2s_main.py https://github.com/huckiyang/Voice2Series-Reprogramming/blob/main/v2s_main.py#L30
    y_train[y_train == -1] = 0
    y_test[y_test == -1] = 0

We pre-assigned negative labels back to positive values. If you want to use the other dataset containing negative values, please consider this value check. Hope this clarifies your question.

Yes, Huckiyang, I agree with you!
Thank you for the answer!
I only mention this because the ECG200 is not the only dataset with negative labels (the dataset 0 - Ford-A also considers negative labels) and the L30-L32 code is conditioned according to dataset 2 (ECG200).
I don't know if other datasets you've used for testing also have these labels.

Hello @DominguesPH,
Yes, in our experimental setup, we did some data cleanup. I just made some modifications to this public code for all setups.
https://github.com/huckiyang/Voice2Series-Reprogramming/blob/main/v2s_main.py#L30
y_train = [np.uint32(i) for i in y_train]
y_test = [np.uint32(i) for i in y_test]

And I got ~94% for 20 eps by running python v2s_main.py --dataset 0 --eps 20 --mod 2 --seg 18 without tuning the dropout. Thank you again for this discussion.


Implementation transfer learning + early stopping for neural network

Build upon earlier work  by @govertv

This PR is an implementation of transfer learning + early stopping for the 2 layer neural network, as implemented already.
I. Why?
Training the nn-2-layer neural network takes quite a bit of time. By implementing transfer learning + early stopping, training times can be shortened considerably. This code builds upon an earlier made PR by @govertv. In this PR transfer learning was implemented by saving and re-using the model at each iteration. Each iteration consisted of a single epoch.
II. What does this PR add?
In addition to transfer learning as implemented by @govertv, early-stopping is added. The reason for doing so is to try and minimise the loss in performance, whilst still trying to reduce training time. Instead of solely running the a single epoch within each iteration, a maximum of the specified number of epochs (with current default: epochs=35) may be run. The early stopping rule stops training breaks off the training when the training loss has not been improved by the value delta, and moves to the next iteration. It does so with a "patience" of patience.
III. Simulation results
A small simulation is done, comparing both results and training times of the regular nn-2-layer with the modified nn-2-layer. The utilised parameters (specified as defaults) for early stopping are set at delta=0.03 and patience=2 respectively.  Simulation have been ran in simulation mode on the Kwok_2020 dataset.
Statistics + training time comparison

Vanilla nn
Transfer-learning + Early-stopping nn

Training time

1h 13m

WSS@95

47.04 %

WSS@100

20.89 %

RRF@5

57.26 %

RRF@10

72.65 %

Recall curve: Transfer-learning + Early-stopping model

Recall curve: vanilla nn

Great contribution. I like the Early Stopping and model saving.
There are several technical concerns regarding the implementation in my opinion. I'm describing two of them:

backward compatibility. Changing a model affects existing projects. Not a big deal at the moment, because this model is not available in the frontend (<=0.17).  Simulations are less problematic because they are conducted in one run usually. Should we rename this model (such that the legacy model can live next to the new one), create a plugin, of replace it?
saving the model in this way causes potential issues when running multiple simulations in a row/multicore. Where do you delete the model when the simulation is finished?

I'm closing this PR. See PR #636 for the reasoning. Feel free to discuss this in the thread.
I do have plenty of questions about the performance btw. It looks very promising. But maybe discuss this in the model extension repo.


Error in object detection installation

While installing "!python -m pip install models/research" on Colab, it returns this error:
Using cached PyYAML-5.4.1.tar.gz (175 kB)
Installing build dependencies ... done
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
But it doesn't stop the process of execution on the notebook but it returns an error while running:
from object_detection.utils import label_map_util
Error:
ImportError                               Traceback (most recent call last)
 in <cell line: 2>()
1 # import the label map utility module
----> 2 from object_detection.utils import label_map_util
3
4 # import module for reading and updating configuration files.
5 from object_detection.utils import config_util
/usr/local/lib/python3.10/dist-packages/object_detection/utils/label_map_util.py in
19 import tensorflow as tf
20 from google.protobuf import text_format
---> 21 from object_detection.protos import string_int_label_map_pb2
22
23
ImportError: cannot import name 'string_int_label_map_pb2' from 'object_detection.protos' (/usr/local/lib/python3.10/dist-packages/object_detection/protos/init.py)

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.
But this time stops the process of execution on the Colab

How can one rectify this?


Catch ValueError due to recent change to torch.testing.assert_close

With https://github.com/pytorch/pytorch/pull/61031 now merged, we should catch ValueErrors.
This should fix most of the currently failing tests.
CC @pmeier :) !

Thanks for the reviews, I'll look into the rest of the (unrelated) failures in a separate PR


Add type filter for pipeline

What type of PR is this?

Fixes part of #865
Special notes for reviewers:

support: filter pipeline by type in ListPipelineObj
Please check the following list before waiting reviewers:

[ ] Already committed the CRD files to the Helm Chart if you created some new CRDs
[ ] Already added the permission for the new API
[ ] Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

none

/lgtm
/approve

/cherrypick release-3.4


Remove old fixture_path support

An alternative to #2349 which removes the old work around, this seems to no longer apply given our supported levels of Rails.

@koenpunt can you try this branch out?

I just wanted to note I tried this out after having issues on Rails edge and confirmed it's happy for me, in tandem with #2385

Thanks @sudara


Drop support for Node.js v14

[ ] Bump tested versions, so we test 16, 18, 20
[ ] Update https://www.prisma.io/docs/reference/system-requirements
[ ] Update CLI https://github.com/prisma/prisma/blob/d43cfff9e9135b2a2c641dede4efa4ebf1914461/packages/cli/scripts/preinstall.js#L47
[ ] Release notes draft
[ ] Anything else?

Check
https://github.com/prisma/prisma
https://github.com/prisma/ecosystem-tests/
and others

Context: Version 4.14.0 has <5% of usage of Node 14.

Is that linked snippet of preinstall.js still useful? I believe most Node.js packages declare the minimal supported Node.js version via the engines property in package.json: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#engines

@jkomyno  npm does not enforce anymore the engines property by default since "a long time", so we had to have this preinstall check.


README: edit instructions for translators

@rehrar looks like it only needed few tweaks in the README. Did I miss something here? Waiting your review then i will update the guide on Taiga as well

Are you adding the template.yml or not after all?

i think last word on this should go to @rehrar

Then I wait for @rehrar to approve!

Is @rehrar lost in translation (reimplementation for kovri)?

This is fine. I think the verbiage of the README should be updated to have the bigger emphasis on the fact that .yml files are a bigger thing, but that Guides still need to be done in the folders. Meh. This is good. Who cares?


Prometheus metrics

This PR adds base Prometheus functionality for measuring and emitting custom metrics (time series) in NPM. There are 6 metrics included currently, and others can be added easily. The current metrics are:

number of network policies on the host
execution time for adding a network policy
number of IP Table rules on the host
execution time for adding an IP Table rule to a chain on the host
number of IP Sets on the host
execution time for adding an IP Set to the host

Metrics are useful for troubleshooting network issues/configuration and are important to monitor (e.g. number of policies should remain low enough).
NPM Prometheus Metrics

/azp run

/azp run

/azp run

Is there anyway to fix the following unit tests?

Is there anyway to fix the following unit tests?

Is there any reason why this wouldn't work in the pipeline environment:
http.Get("http://localhost" + metrics.HTTPPort + metrics.MetricsPath)

/azp run

/azp run

/azp run

Had an offline discussion with huntergregory for the following 4 topics. Topic 4 will be addressed in the following PR.

How to differentiate differentiate customer's data generated in Prometheus.
Who will have the access to Prometheus data.
How to isolate Prometheus data to limited audience.
Move test only code to testing directory or util directory. Separate testing code from prod code.

/azp run

Noting here that the PR passed the local environment scale test (TH test). No errors and approximately the same memory usage in azure-npm pod (14 MiB without Prometheus and 18 MiB with Prometheus).

Letting @vishiy view the PR


proposal: change coverage tool

I recently change the coverage tool in one of my personal projects from codecov to coveralls.
Coveralls shows information about the coverage in a better way.
It also seems to be faster to navigate between the files.
Thoughts?

Can we trade, can you take over that trade?

Yes, I can do this.


Action items column

I think the old pong app had an "action items" column (or was it in the footer?) that you could put things to take action on latter: would love if this was brought back or if there was an option for it!

Current idea:

This requires a wide screen. On smaller screens, I'm trying to figure out.

Possible different responsive designs.

A version has been deployed.


Clarify expiration functionality documentation

Currently it is not clear whether expired entry are automatically purged from memory or only removed when you try to get them (so that your memory usage can potentially grow uncontrollably and explicit housekeeping for expired entries should be implemented).
Documentation mentions "Keys can have a timeout after which they expire and are cleaned from the cache", but it is not clear, whether values themselves are deleted as well.

During the internal check the method .del( key ) is used to remove expired keys.
So the expired keys will be deleted with delete @data[ key ]
Does this clear your question?

And i think "cleaned from the cache" should be enough and a ttl of a key will not interpreted as there will be garbage left in the cache.

Documentation is ambiguous :(.
Currently it says "Keys can have a timeout after which they expire and are cleaned from the cache." - nowhere it says that "expired keys will be deleted with delete @data[ key ]" (because that operation actually does not only delete the key but also a value for that key). Could you please add the
"So the expired keys will be deleted with delete @data[ key ]"
somewhere in the documentation?


Jest updates

Three distinct changes in this PR; see each commit message for details.
Do these changes make sense? Can split into multiple PRs if necessary. Any additional tests I should add?
Also wondering if it makes sense to remove the other Jasmine methods from the Jest type definition:

describe, it, etc.
expect, et al

I think Jest users should be installing both the Jest and Jasmine type definitions; a couple reasons described in https://github.com/flowtype/flow-typed/pull/265/commits/21334b864b475ab5e0574fd243e09c229fff5e13

cc @cpojer

Can you add all jasmine definitions to Jest? I commented on the issue you created.

Can do! Will update later today

@cpojer Updated

yay this is way better! :)


Fix intermittent panic at startup when asking for node id from the backend

Sometimes the app  would panic at startup (for local deployments for me), and I
figured it was trivial to make it more resilient in this case.
We now log an error if for whatever reason we couldn't display the node id at
startup (e.g. node wasn't ready) - this should not be a showstopper by any means, and it gets
logged at later stage anyway.

Seems a bit weird that we could get to that point without having the node initialised - shouldn't we wait for it or something?

@holzeis, to be honest I haven't dig into this very deep; the node got initialised soon after and this has unblocked me. I don't think there's any reason to be so strict with our invariant for something that is essentially just a log statement, as we make no use with it anyway.

Might be worth a followup in case this could cause other issues down the line?

Might be worth to get this in now and add followup ticket in case the node not being initialised by then could cause other issues down the line?

this PR can't cause any issues (it just fixes the logging thing) and everything worked well during extensive testing I've done on top of this.
I suspect it might be something to running it with a debugger, which is not our typical production use-case.
I see no point in us crashing the application if we cannot log node id early at startup.

this PR can't cause any issues (it just fixes the logging thing) and everything worked well during extensive testing I've done on top of this.

Sorry if I was confusing, but I didn't mean this PR, but rather what this PR addresses could cause issues. This PR addresses the symptom of the node not being initialised. However, the node not being initialised may in and of itself cause other issues down the line. So, I agree that this should go right in, but we should also investigate the underlying cause (with lower priority).

Just ran into this as well
I/flutter (21854): | 2023-09-07 18:06:15.036 | LogLevel.INFO | Oracle endpoint: http://<IP_ADDRESS>:8081
I/flutter (21854): | 2023-09-07 18:06:15.040 | LogLevel.INFO | Oracle PK: 16f88cf7d21e6c0f46bcbc983a4e3b19726c6c98858cc31c83551a88fde171c0
F/libc    (21854): Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 21906 (1.ui), pid 21854 (ce.get10101.app)
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
Build fingerprint: 'alps/full_rlk6580_we_c_m/rlk6580_we_c_m:11/685/685:user/release-keys'
Revision: '0'
ABI: 'arm64'
Timestamp: 2023-09-07 18:06:15-0400
pid: 21854, tid: 21906, name: 1.ui  >>> finance.get10101.app <<<
uid: 10165
signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
    x0<PHONE_NUMBER>000000  x1<PHONE_NUMBER>005592  x2<PHONE_NUMBER>000006  x3  0000007af761e930
    x4<PHONE_NUMBER>000000  x5<PHONE_NUMBER>000000  x6<PHONE_NUMBER>000000  x7  7f7f7f7f7f7f7f7f
    x8<PHONE_NUMBER>0000f0  x9  0000007df97fb800  x10 ffffff80fffffbdf  x11<PHONE_NUMBER>000001
    x12<PHONE_NUMBER>000000  x13<PHONE_NUMBER>000000  x14 0000007acfb9b2d4  x15<PHONE_NUMBER>000005
    x16 0000007df9894c80  x17 0000007df98763a0  x18 0000007aee58a000  x19<PHONE_NUMBER>0000ac
    x20<PHONE_NUMBER>00555e  x21<PHONE_NUMBER>0000b2  x22<PHONE_NUMBER>005592  x23 00000000ffffffff
    x24 0000007acfb97108  x25<PHONE_NUMBER>000001  x26 0000007ad263d898  x27<PHONE_NUMBER>99a8e0
    x28<PHONE_NUMBER>000079  x29 0000007af761e9b0
    lr  0000007df9829544  sp  0000007af761e910  pc  0000007df9829574  pst<PHONE_NUMBER>000000
backtrace:
      #00 pc<PHONE_NUMBER>04e574  /apex/com.android.runtime/lib64/bionic/libc.so (abort+180) (BuildId: 3dd99fe7a181e7428f58a10f32f9fd0e)
      #01 pc<PHONE_NUMBER>f27ac4  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #02 pc<PHONE_NUMBER>f210f4  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #03 pc<PHONE_NUMBER>342d64  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #04 pc<PHONE_NUMBER>f24920  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #05 pc<PHONE_NUMBER>f246ac  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #06 pc<PHONE_NUMBER>f23278  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #07 pc<PHONE_NUMBER>f24430  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #08 pc<PHONE_NUMBER>f4327c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #09 pc<PHONE_NUMBER>f43048  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #10 pc<PHONE_NUMBER>039324  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #11 pc<PHONE_NUMBER>34a500  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #12 pc<PHONE_NUMBER>ea3d04  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #13 pc<PHONE_NUMBER>33b3e4  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #14 pc<PHONE_NUMBER>0ffd9c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #15 pc<PHONE_NUMBER>1c8b50  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #16 pc<PHONE_NUMBER>1c818c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #17 pc<PHONE_NUMBER>ffa44c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #18 pc<PHONE_NUMBER>010e30  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #19 pc<PHONE_NUMBER>fec9a8  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #20 pc<PHONE_NUMBER>3461b4  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #21 pc<PHONE_NUMBER>1c7e7c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #22 pc<PHONE_NUMBER>ffe9ac  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #23 pc<PHONE_NUMBER>010e30  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #24 pc<PHONE_NUMBER>ff6cf8  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #25 pc<PHONE_NUMBER>34738c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #26 pc<PHONE_NUMBER>1c7670  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #27 pc<PHONE_NUMBER>f24d8c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so
      #28 pc<PHONE_NUMBER>e32c0c  /data/app/~~JqNuMu6QuOM2VkRlS6Uh9Q==/finance.get10101.app-FUZBdN8RqrEjQGH9KYDx7Q==/lib/arm64/libnative.so (wire_get_node_id+4)
      #29 pc<PHONE_NUMBER>0076a4  [anon:dart-code]
Lost connection to device.

We now log an error if for whatever reason we couldn't display the node id at
startup (e.g. node wasn't ready) - this should not be a showstopper by any means, and it gets
logged at later stage anyway.

I am wondering how we should deal with an app where the backend crashed. It is basically not usable to the user isn't it?
Maybe we should be able to handle any unexpected crash / panic and ask the user to share the logs if that happens. The user shouldn't be able to do anything else in that state.

We now log an error if for whatever reason we couldn't display the node id at
startup (e.g. node wasn't ready) - this should not be a showstopper by any means, and it gets
logged at later stage anyway.

I am wondering how we should deal with an app where the backend crashed. It is basically not usable to the user isn't it? Maybe we should be able to handle any unexpected crash / panic and ask the user to share the logs if that happens. The user shouldn't be able to do anything else in that state.

Depending what in the backend has crashed, I guess different things are possible.
For the sake of simplicity, we've got a giant monolithic 'node' that does everything right now (a lot of the things are unrelated). I am not proposing to change this, because it's not our highest priority and would take quite a lot of our time for questionable gain. One could argue that trades history and quite a lot of functionality should be still accessible, but I treat that as a very low priority.
I think in an ideal world we would at least display a message what happened and allow sharing the logs with 10101 before we exit the app.
The reason for displaying a message is that sometimes the user can fix the error on their side! (e.g. issues with the internet). Empowering the user to fix this things would give us more happy users and less debugging crashlogs about which we can't do anything.
Eventually (the holy grail of crash recovery) would be if the user can export their seed words / cloud backup of their seed (+ VSS-style channel state eventually). Because you don't want them to lose money, if the issue is serious.

closing this in favour of #1301


0.5.1 release for clang11 fix?

https://github.com/simd-everywhere/simde/commit/e5b5b7db97892a378fa6d2714b299791c4c5eb10
And it looks like avx2 might be done soon too :-)

To be clear, it's not clang 11 that is the problem, it's Apple Clang 11, which is a fork of a pre-release version of an older version of clang (7 or 8, IIRC) which had a bug.  The clang people fixed it before their release, but Apple didn't back-port the fix.
But yes I'll try to make another release soon.  I need to put out a new release of Hedley, too, and I'd like to do that first so those fixes are in SIMDe, too.

https://github.com/simd-everywhere/simde/commit/63d87d9604e025816aed575afe6cf6a46d79635d this would also justify a 0.5.1 release on its own. I can can cherry pick it for Debian but a release would be nicer 🙂

Yeah, I was thinking that too.  I'll try to put out a release in the next day or two.

Gentle ping for a new release :-)

Just released 0.6.0, sorry about the delay.

Thank you @nemequ! I see the tag, but no GitHub release, so I'm doing that part myself.

Thanks. I thought creating a tag created a new release, guess not :/


[core] Generate json-schema is incorrect for http announcers

Task List

[x] Steps to reproduce provided
[ ] Stacktrace (if present) provided
[ ] Example that reproduces the problem (link to git repository is ideal)
[x] Full description of the issue provided (see below)

Steps to Reproduce

mvn jrealeaser:json-schema
Look at the definition of http announcer

Expected Behaviour
Since the HTTP annourcer can have multiple targets, the json-schema should accept things like
announce:
  http:
    xwiki: # first announcer
      # Here is the definition of that announcer
    confluence: # second announcer
      # Here is the definition of the second announcer

Actual Behaviour
Since the json-schema defines the http property as HttpAnnouncers instead of HttpAnnouncerMap, it cannot be accept such structure.
Environment Information

Operating System: Windows
JReleaser Version: 1.4.0
JDK Version: 17

Hmm this is strange. This is how it should be handled:
announce:
  http:   # type is HttpAnnouncers
    xwiki: # type is HttpAnnouncer
      # Here is the definition of that announcer
    confluence: # type is HttpAnnouncer
      # Here is the definition of the second announcer

It seems to me that httpAnnouncers should allow all properties from HttpAnnouncerMap oiw these two types should merge.

Released in v1.5.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.5.0


[patch] anti-spike

if the pitch on the turret is high (upward) enough, when the turret homes (typically at power on), the motion will be so fast that the magnets will not keep the magazine attached to the mounting plate, and the turret will football-spike the magazine.

modifying the pitch speed does not control the pitch speed at homeServos()
maybe check the servos lib to see if there is something that can be done. otherwise, we'll have to write a real hack for it

int startAngle = 0; // Starting angle of the servo
int targetAngle = 90; // Target angle of the servo
int moveSpeed = 1; // Speed of the servo movement

for (int angle = startAngle; angle <= targetAngle; angle += moveSpeed) {
  servo.write(angle); // Set the servo angle
  delay(10); // Delay between each angle change
}

the other problem we have is that these servos do not have a read lead on them, so we can't know their position.
it might be safer to move the turret to a different position, at a higher inclination, to reduce the risk of RUD. if the turret is all the way back, the move will be smaller.

after much futzing, i think the best way to prevent the RUD is to

limit pitch +/-
home to 90 - the potentiometer  seems to brake in the last ten degrees, from 100 to 90, which seems to help b/c reduced change in momentum...


General questions about the dataset

Hi all,
i already trained some nets with your released dataset. everything worded fine so far for the training process. But i have a couple of questions if i understand everything correctly:

On your homepage it says there are 30 classes in 8 categories, so far so good. If i take a look into the labels.py file i count 35 classes (line 63 to 97). For me its not really clear what number to set as the number of output of my last conv layer. acutally after some experementing my suggestion is to set the number of outputs to 34. The problem is, i dont know exactly why... :-).
I saw some net architectures where there is a "ignore label" parameter. Regarding your dataset my understanding is that the void-category should be ignored (better sayed, void is not included for evaluation). How to handle this? on your Homepage void category contains "ground", "dynamic" and "static", so should i set ignore_labesl to 3? in labels.py there are 7 labels within the void-category. This is a little bit confusing for me.
If i have 'class_weighting' by 'weight_by_label_freqs: true' in a "SoftmaxWithLoss"-Layer, how are the weights calculated for the cityscapes labels?
Could you explain the iIoU metric in a little bit more "easy" detailed way than described in your official paper? I still have some understanding issues here.

Thank you very much in advance for your help!
Regards
Stefan

Hi Stefan,
thank you for your feedback. Regarding your items:

The 30 classes is more the high-level view of the dataset and reflects the number of manually labeled classes. The labels.py includes additional artificial classes such as ego-vehicle that can be labeled automatically with known camera calibration. For evaluation, we use only 19 of these classes, since we excluded the void category and rare cases. In labels.py, the excluded classes are flagged by ignoreInEval=true. Thus, I would set the number of output channels to 19, and treat pixels with one of the remaining classes in ground truth as ignore.

I would use the IDs that we named trainId for training. The idea is to map labels that are ignored to 255 and to have consecutive IDs for all other labels. However, please make sure to reverse this mapping before evaluation.

In our experiments in the paper, we did not use any class weighting.

The iIoU weights pixels by the size of the ground truth object that they belong to. In doing so, objects of different pixel size (e.g. close and far cars) are treated more similar in evaluation. Maybe the implementation of the metric helps to understand this better, please refer to evaluation/evalPixelLevelSemanticLabeling.py

Best,
Marius

Hi Marius,
thank you very much for your Response. Please see my further questions below:

Ok, ist much more clear now for me, but when i set Output to 19 in my last conv layer and ignore_label to 255 in the softmax layeri get an "core dumped error" like "free(): invalid next size ...". i recognized it has to do with the number of Outputs. if i Change the number of Outputs to 34 it starts Training the Network. It works with 35 also, this is Kind of strange in my eyes. For now i have bad Evaluation results, seems to be because of the number of Outputs?! but i cant even start a Training because of the error when i set it to 19. Can you help here too?

ok, understand so far.

ok

ok, thx, i didnt even recognized the evalPixelLevelSemanticLabeling.py script :-P So far, I was just evaluating visually by comparing the predictions with the ground truth pics.

Hi Stefan,
you should use ground truth images that match your channel numbers, i.e. all pixel values must be within 0...numberChannels-1 plus the ignore value (e.g. 255). We suggest to use the trainIDs for this, you can generate those with the tool preparation/createTrainIdLabelImgs.py.
Best,
Marius

Hi Marius,
ok, thank you, i will try this tomorrow, that might be the problem that i didnt train with the prepared data created by preparation/createTrainIdLabelImgs.py!
A new question came on tonight...i was trying to run evalPixelLevelSemanticLabeling.py for some actual trained data, just to know how the script works. It took my 2 hours and i was not able to run this correctly...i set the environment variable many times, checked the path by echo $CITYSCAPES_RESULTS, this path points to my result images with the naming like described in the script! i always get the error
"ERROR: Found no prediction for ground truth /home/USERNAME/Downloads/CityscapesDataset/cityscapesscripts/evaluation/../../gtFine/val/frankfurt/frankfurt_000000_011810_gtFine_labelIds.png" I replaced my username here, just for information.
i really dont understand why it alwyas points to the gtFine/val/frankfurt folder??? My environment path is set correctly to another path...i tried to unset all environment variables again and created the result folder in ../../results...it still points to the frankfurt thing. my custom path isnt respected at all, no matter which version of the description in the script i try!
if i give a path or a file as input argument the script runs but it says "Evaluating 0 pairs of images..." and all the rest is "nan" because of dividing by zero as i understand.
what am i doing wrong here??? i am out of ideas...
thank you again in advance for your great help!
Regards
Stefan

Hi Marius,
one more question came up regarding to question 1. from the first post:
i converted my images via createTrainIdLabelImgs.py, that worked so far. But when i set number of outputs in my last conv layer to 19 and ignore_label to 255, it says "CUBLAS_STATUS_SUCCESS (11 vs. 0)  CUBLAS_STATUS_MAPPING_ERROR".
I have to set the number of outputs to 255, then it starts training...is this behaviour correct? that would mean all the accuracy values on the caffe output from 20-254 dont care?
thank you for your help!
Regards
Stefan

Hi Stefan,
regarding your evaluation problem. The script prints the ground truth filename when it cannot find an appropriate result file. Is there a result file for each of the validation images somewhere within the folder "CITYSCAPES_RESULTS"? The files must be named frankfurt_000000_011810*.png or similar.
Did you double-check that your ground truth images contain only values between 0...18 or 255 and that your network is actually using these images?
Best,
Marius

Hi,
How Do i Check how many labels are in the gt picture? I thought the Scripts' Output produces the correct number of labels?
Thanks,
Stefan

Hi Marius,
ok, now i wrote a small script to read out the pixel values of the whole gt Image!
there are a few values of 128, 129 and 64 in the pictures...There seems to be the problem!
All the rest is within the range of 0-19 and the white areas are 255, what looks good so far.
But how can it happen that there are values of 128,129 and 64 inside the picture? I used your script to create the labelTrainId-Images...
Thanks
Stefan

To be a little bit more precise...i checked about 15 gt labelTrainId-Images now, the "strange" values always appear before or after a region of pixels with value 255 if this helps anyway?! I saw some additional "out of range"values 65, 192 and 134...but like i said, always before or after a 255-region.
thanks

Hi Stefan,
are you resizing the images with some kind of interpolation? That would now be a good idea for images with IDs.
Best,
Marius

Hi Marius,
thank you for your quick response!
In fact i do this by cv.Resize(image1,image2,interpolation=cv.CV_INTER_LINEAR) where image1 is the original size and image to is my new size (512x256). So there might be the problem? But i resized the images BEFORE i used your script createTrainIdLabelImgs.py! Should i create the trainId-Images with the original cityscapes image-sizes and then resize them or shouldn't i resize the images at all?
thank you!
Stefan

i checked the non-resized TrainId-images, no "strange" values in there, that seems to be the problem!!!
Thank you very much for your support, i would have searched for this forever :-P
i think i can proceed now and get some results! Thank you!
Stefan

but is it possible to resize images now? I mean resizing the original labelTrainId images? i dont want to use this big resolution. Or will it corrupt the pixel values again?

Just use INTER_NEAREST...
Good luck,
Marius

That worked! The net is training right now with image size 512x256, number of output 19 and ignore_label 255!
Thank you again very much!!!
Have a nice weekend!
Stefan

Great. Thank you, and good luck with your training then. I will close the issue.
Best,
Marius

Hi Maurius, @mcordts I want to use the cityscape dataset but want to reduce the classes to just 2(two) classes. I see that there are .json files I need to change but apart from that, to make a segmentation model, what more am I supposed to change?
Thanks

If I understood you correctly, this is what you want to do:

In labels.py you want to change the trainId column to the two classes that you are interested in (values 0 and 1). The remaining are typically mapped to 255 and then ignored during training (something you will need to take care of)
Run the script csCreateTrainIdLabelImgs
Train your model on the pngs produced by the previous step.

If I understood you correctly, this is what you want to do:

In labels.py you want to change the trainId column to the two classes that you are interested in (values 0 and 1). The remaining are typically mapped to 255 and then ignored during training (something you will need to take care of)
Run the script csCreateTrainIdLabelImgs
Train your model on the pngs produced by the previous step.

Exactly what I needed! Thanks 👍

As you set the remaining pixels to 255, both 0 and 1 will appear black for the eye.

Hello I just trying to use this dataset. Like @mcordts said it better to use TrainIds however after I download the dataset in file gtFine_trainvaltest.zip (241MB) I can't find it, instead I just find labelIds. Where can I download it?, or in which file it is located?

@mcordts I have tried to run the script createTrainIdLabelImgs.py but looks like some validation dataset's images are not converted well. This image is the example:
./gtFine/val/lindau/lindau_000035_000019_gtFine_labelIds.png
label : [ 1  3  4  6 11 17 20 21 24 26]

why it is not encoded to 0-18?

@mcordts Hi Maurius, are the classes of 'static' and 'unlabeled' necessary if I want to customize my own classes? Thank you in advance!

If I want to train on the 8 categories, how could I do that ?


Add OTLP Service Name Environment Variable

…ngface/text-generation-inference/issues/2069
What does this PR do?
Adding Service Name Environment variable to override the default name.
Fixes # (issue)
Fixes
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@OlivierDehaene, @LysandreJik

hi @KevinDuffy94 thank you for the contribution, I think a couple changes are needed before we can approve and merge. Pleas also make sure to update the docs with python update_docs.py, this should automate some extra doc changes needed. Thanks!


(SUNMI V2) SunmiPrinter.printQRCode() does not work If I passed Arabic letters to the data parameter.

The issue appears on Sunmi V2.
When adding any Arabic Text,  something like
SunmiPrinter.printQRCode('ال كيو ار كود لا يعمل')
the printer stuck on this line.
it prints any other thing before this line. but when it reaches this line it get stuck.

Well mate i have never tested arabit text with qrcode printer.
can u try this like in the document example?
商米科技 SUNMI Technology
There is a lot of things that arabic is not possible, like print rowText , i think qrcode is the same.

add me on Discord  then i can upgrade the git version for you to try.
I don't have this equipment i have this one

Brasizza#7615


Give the project a normal golang structure.

Nearly no code change, just moving the project in the standard golang structure.
Adding dep files. It is nice to be able to checkout a project and have it work, so using dep we check in the deps the project uses.

As a follow-up, I added samples: https://github.com/n3wscott/sdk-go/pull/1/

Dep tool is not the official thing. Please switch to go mod

Given go mod is still not on by default in golang version 1.11. I am inclined to not use go mod yet.

Dep as well, no? Go mod meant to be the de-facto standard since 1.11

Dep is the current de-facto for almost of golang projects I work in. Go mod is not in use yet and it has some serious drawbacks that are still being addressed.

Directly including source from a project's dependencies in a repo always bugged me. In this case it's weirder because the dependency is only necessary for running tests. I like Mark's suggestion.

Directly including source from a project's dependencies in a repo always bugged me. In this case it's weirder because the dependency is only necessary for running tests. I like Mark's suggestion.

I find checking out code that does not work more irritating. dep solves this problem, and committing the vendor directory after trimming prevents you from needing to dep ensure.


Pass env values in DedicatedGameServerCollection

Currently, the env variables are created hardcoded. While this works for OpenArena, we need to make them parameterized.

Closing as this will be handled by #3


Mostly linting, maybe fixing

UnitTest_app.js - These changes make Bluebird happy, otherwise it will
complain about "a promise was created in a handler but was not returned
from it"
testThaliManagerCoordinated - Linting
thaliSendNotificationBasedOnReplication - Added an assert on one of
our constructor arguments, covered a theoretical edge case where we
could end up with a negative time value. Clarified that one of the functions
handles an arg different than stated.
thaliManager - Linting
pouchDBGeneratior - Linting

This change is

PR is added to the queue for testing as 1. task. (43945da)

@andrew-aladev If this looks o.k. then please just merge it since in theory @vasilevskayaem and @chapko needs to deal with a failing test
@vasilevskayaem / @chapko - The change here is the equivalent of what Artyom did. But I can't give you any reason why it should fix the bug. :( I tried repro'ing this on the desktop with 15 nodes, 10 nodes, repeated runs, etc. The assert never repro'd.

PR is added to the queue for testing as 2. task. (5a81739)

Test (Success) 87974041 build is completed (43945da)
See https://github.com/ThaliTester/TestResults/tree/8797404143945da_Mostly_linting__maybe_fixing_yaronyg/ for the logs

Test<PHONE_NUMBER>945da(43945da) has failed
See https://github.com/ThaliTester/TestResults/tree/8797404143945da_Mostly_linting__maybe_fixing_yaronyg/ for the fail logs

Test (Success) 87974041 build is completed (5a81739)
See https://github.com/ThaliTester/TestResults/tree/879740415a81739_Mostly_linting__maybe_fixing_yaronyg/ for the logs

Test 879740415a81739(5a81739) has failed
See https://github.com/ThaliTester/TestResults/tree/879740415a81739_Mostly_linting__maybe_fixing_yaronyg/ for the fail logs

Reviewed 5 of 5 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

still can caught "write test" failure on wifi mode


Milestone: Add accessibility to page

Page titles - no issues found
Image text alternative  - updated the image text alternative to a more descriptive text
Text headings - no issues found
Color contrast - no issues found
Resize - no issues found
Interaction - added focus-within effects to section cards
Moving content - no issues found
Multimedia - no issues found
The basic structure of the page - no issues found

Thank you for approving our review @levy002
However, I think you made a mistake by mentioning @dhirajsingha143 in this particular review instead of @yaredtekle022 who was the actual collaborator on this PR.

Thank you @Timbar09 for mentioning that!

No problem @levy002 . Thanks for following up.


@l2succes => Use new series fields

Updates reaction
Uses { series } instead of series_description field

@eessex Merge conflicts :( Let's merge after fixing them


Has anyone been seeing astronomical ask prices from the quote endpoint?

I've been getting ask prices of<PHONE_NUMBER> for symbol VEA and some other Vanguard ETFs.
For example,
https://api.robinhood.com/quotes/?symbols=VEA,VHT
Is this normal? What do you make of this?

Seems to be fixed now at least in the link you provided, or maybe it is intermittent. I haven't noticed anything off with the prices returned but I don't use the ask prices specifically, usually just the last trade price.

Yeah, I was planning on watching at/near open and double check because it was normal when I checked the endpoint linked too. ...and that was less than a minute after the issue was created. Maybe it's a capacity issue like the ones they had last year when the entire API would crumble; a random cache miss and<PHONE_NUMBER> is a placeholder maybe.

Okay, I guess I can close it, but just wanted to share.


Support the OAuth2 secret type

Why & who
We need this to instruct S4D, then CR/ACE, that such a flow needs to be completed in order to retrieve an access token in the action.
This affects the Action Developer when the secret type gets configured with the required scopes and the auth provider info. This also enables the AI Operator to deploy such action requiring this kind of auth. And finally it affects the Knowledge Worker as well as it gives the ability to have a way to observe that such integration is required to be installed first before using the AI Actions.
Feature or enhancement
Similar to Secret (that may be refactored into SecretText) we'd need a SecretOAuth new one which takes a list of scopes and the necessary auth provider info (auth & token URLs) so they can be collected by the auth manager in order to form the complete auth url (including the redirect URI) which triggers the flow (client install).
For the start, we may let the auth manager (S4D, CR) decide the auth & token URLs itself (harcoded) based on the specified provider in the OAuth2 secret type, so the Action Developer won't need to specify these in their actions. (potential limitation with custom Auth Provider servers or tenants requiring a mandatory tenant ID in the URLs -- see case explained below -> which gets solved by being configured straight in S4D, CR)
Solution & alternative

A new secret type called SecretOAuth
GoogleOAuth = SecretOAuth["google", ["read", "write"]] -> would incapsulate the provider and the required scopes
def google_action(token: GoogleOAuth) -> would instruct the auth manager that it needs the flow done
In the function body we get the token with token.access_token -> offers the bearer access token which enables access into the API

The client credentials setup and token refreshing parts are handled by the auth manager (S4D, CR/ACE), never by the Action Package. The AI Actions would know just about the access token only and it should be ensured that this is valid.
Notes

On the auth manager side, operating with Public Apps (service approved clients) won't require the use of a client_secret. (client_id should be enough, but then it requires PKCE layer in place)
A follow-up requirement would be that we'll need native DX support for the Action Developer to complete the flow straight from the Action Server.
Here's diagram expressing the Authorization Code grant type required to allow an app to act on user's behalf.
The Office365 Exchange example where a custom tenant may also be required to craft the auth URL:

Tenant example
Importing the legacy library with a custom tenant
How tenant ID is captured
Then passed and formatted in the auth & token URLs

Linear

For DX, in the examples we use to plot this let's use some actual scope strings as these can be "whatever", nasty, long and convoluted. Google and Slack as examples:

https://developers.google.com/identity/protocols/oauth2/scopes
https://api.slack.com/scopes

Proposed metadata:
{
    "metadata": {
        "name": "Package Name",
        "description": "Package description.",
        "secrets": {
            "/api/actions/package-name/action-name/run": {
                "action": "action_name",
                "actionPackage": "Package Name",
                "secrets": {
                    "api_key": {
                        "type": "Secret"
                    },
                    "access_token": {
                        "type": "OAuth2Secret",
                        "provider": "google",
                        "scope": ["http://foo.bar/read", "http://bar.foo/write"]
                    }
                }
            }
        }
    },

Proposed sema4ai-code structure:
from typing import Generic, Literal, TypeVar

from robocorp.actions import action

# Definition (internal to sema4ai-actions)
ProviderT = TypeVar("ProviderT", bound=str)  # Restrict Provider to string
ScopesT = TypeVar("ScopesT", bound=list)

JSONValue = dict[str, "JSONValue"] | list["JSONValue"] | str | int | float | bool | None

class OAuth2Secret(Generic[ProviderT, ScopesT]):
    def __init__(
        self,
        provider: ProviderT,
        scopes: ScopesT,
        token: str,
        metadata: JSONValue = None,
    ):
        self._provider = provider
        self._scopes = scopes
        self._token = token
        self._metadata = metadata

    @property
    def provider(self) -> str:
        return self._provider

    @property
    def scopes(self) -> ScopesT:
        return self._scopes

    @property
    def token(self) -> str:
        return self._token

    @property
    def metadata(self) -> JSONValue:
        return self._metadata

# Code which the user needs to write
@action
def send_message(
    message: str,
    access_token: OAuth2Secret[
        Literal["google"],
        list[
            Literal[
                "https://www.googleapis.com/auth/spreadsheets",
                "https://www.googleapis.com/auth/drive.file",
            ]
        ],
    ],
) -> str:
    # Actual instance (received in the arguments) is created from the
    # action server with something as:
    access_token = OAuth2Secret(
        "google",
        [
            "https://www.googleapis.com/auth/spreadsheets",
            "https://www.googleapis.com/auth/drive.file",
        ],
        "auth-token",
    )
    print(access_token.provider)
    print(access_token.scopes)
    print(access_token.token)
    print(access_token.metadata)
    return ""

Fixed in https://github.com/Sema4AI/actions/commit/a3a2d7b675412f39492544b2720c0cf6229e7ad2


ImportError: No module named google.protobuf

hello ,there! when i use C++ to call python program that use tensorflow，report this error
Traceback (most recent call last):
File "", line 1, in
File "/root/anaconda2/lib/python2.7/site-packages/tensorflow/init.py", line 24, in
from tensorflow.python import *

File "/root/anaconda2/lib/python2.7/site-packages/tensorflow/python/init.py", line 54, in
from tensorflow.core.framework.graph_pb2 import *

File "/root/anaconda2/lib/python2.7/site-packages/tensorflow/core/framework/graph_pb2.py", line 6, in
from google.protobuf import descriptor as _descriptor

ImportError: No module named google.protobuf
code is here ：
PyRun_SimpleString("sys.path.append('/root/anaconda2/lib/python2.7/site-packages')");
PyRun_SimpleString("sys.path.append('/root/pythoncode/vgg')");
PyRun_SimpleString("import tensorflow as tf");
PyRun_SimpleString("print sys.path");
have anyone meet this question？please，help! thank you very much!

Please make sure you fill in the issue template to ensure that your issue can be troubleshooted correctly. Key information includes System Specs and Tensorflow/CUDA/cuDNN versions. Without this it's harder to help!
What happens when you run it in a normal python environment? Does tensorflow work as expected?

system is centos 7.tensorflow is 1.1.0. when I run it in a normal python environment it can run correctly

I'm not familiar enough with C++ or PyRun and don't want to lead you in the wrong direction. Are your tensorflow, protobuf installations in the site-packages area or are they in an environment somewhere? I notice you're using Anaconda so perhaps you are using anaconda incorrectly with this system? You may some package conflicts.
I presume you're otherwise unable to use the C++ version of Tensorflow for this?

Please provide details about what platform you are using  (operating system, architecture). Also include your TensorFlow version. Also, did you compile from source or install a binary?  Make sure you also include the exact command if possible to produce  the output included in your test case. If you are unclear what to include  see the issue template displayed in  the Github new issue template.
We ask for this in the issue submission template, because    it is really difficult to help without that information. Thanks!


[pgadmin4] horizontalPodAutoscaler v2beta -> v2

Is your feature request related to a problem? Please describe.
When I try to enable the autoscaler feature in this chart, I get the following error;
The Kubernetes API could not find version "v2beta1" of autoscaling/HorizontalPodAutoscaler for requested resource pgadmin/pgadmin-pgadmin4. Version "v2" of autoscaling/HorizontalPodAutoscaler is installed on the destination cluster.

Describe the solution you'd like
I think it's really as simple as changing the template API version to v2
Describe alternatives you've considered
Forking and making the change myself, or just not using autoscaling.
Additional context
Add any other context or screenshots about the feature request here.

@pww217 can you maybe test against my branch here: rr/issues-213/horizontalPodAutoscaler


Fix re-attaching of weave router in awsvpc mode

In order to re-attach the router and make it work in awsvpc mode, the following has to be done:

expose_ip on the router
adjusting arp settings
restoring host routes (routes are taken from VPC rt)

To detect that we run in awsvpc mode, we inspect cmd parameters of the weave router instead of GET'ing /ipinfo/tracker. This is so, because the HTTP server started by the router might not be running at the time of restoration.
Fixes #2381

Can this go into 1.6.1 or is it too low value / high risk?

Why do we restore host routes from the VPC table rather than from IPAM?  Are we worried that they might be out of sync?

I think this could go into 1.6.1.

Why do we restore host routes from the VPC table rather than from IPAM?

The motivation for doing that is to avoid extending the ipam/tracker interface and the ipam/ring module.
Anyway, it is probably better to assume that IPAM is a single source of truth, so I will change it.

Done. Re-opening the PR against the 1.6 branch.


Accidentally disables -Wnon-virtual-dtor for unrelated code

The top of the file tests for __GNUC__ to disable -Wnon-virtual-dtor.
The bottom of the file tries to test for __GNUC__ to reset that warning to the default state. Unfortunately, it's typoed as __GNU__, which doesn't exist, so the warning is left disabled.
Simple typo, simple fix.
(surprised that gcc doesn't throw a warning that the warning stack isn't empty, but oh well)

This change is

Thanks for the pull request. I'm actually getting rid of this in the next release because I've fixed the underlying problem. But I'll merge this into master so that 1.x isn't broken.


Add support for MUJOCO_GL=osmesa on Windows and macOS

The feature, motivation and pitch
I am working on packaging and running the testsuite of gymnasium 1.0.0 on conda-forge (in https://github.com/conda-forge/gymnasium-feedstock/pull/41). The tests are supposed to run on headless CI machines. While all the mujoco tests related to rendering work fine on Linux by setting MUJOCO_GL=osmesa, the rendering test fail on Windows and macOS.
I looked into supporting MUJOCO_GL=osmesa also on Windows and macOS, and the part of the code to modify seem:

https://github.com/google-deepmind/mujoco/blob/3.2.4/python/mujoco/gl_context.py#L22
https://github.com/google-deepmind/mujoco/blob/3.2.4/src/render/glad/glad.c#L226-L244
https://github.com/google-deepmind/mujoco/blob/3.2.4/src/render/glad/glad.c#L88-L97

The python modifications are trivial, while the one on the glad's C files are a bit more complex.
In particular, on the Linux side to decide if osmesa should be used, Linux-specific strategies like checking if osmesa-symbols are present in the global process symbol table or check libraries already loaded in the process with dl_iterate_phdr. Replicating the same strategy on macOS or Windows may not be trivial given how different the loading of shared libraries works on these operating systems.
However, I wonder if it could make sense on Windows and macOS to just check for the value of the MUJOCO_GL env variable from the C code, and try to load OSMesa only if MUJOCO_GL=osmesa? Or there could be downside there? I would probably avoid to modify the Linux logic if it is working fine at the moment.
Note that this modification would not address the problem on how the user installs the osmesa library in the first place, but that is also the situation on Linux, where osmesa should be installed by some package manager that is also able to install C++ libraries (such as the system apt or yum package manager, or conda).
Alternatives
Do not support MUJOCO_GL=osmesa on Windows and macOS
Additional context
.

xref to related issue: https://github.com/google-deepmind/mujoco/issues/959


Feature Request add service worker options

It would be great if some of the additional option were added to the service worker showNotification constructor.
Particularly the Data option because that can be used in the service worker notification click, ie. to provide a URL for redirect.
Icon would be great too! :)

just to clarify, this is what i am talking about:
registration.showNotification(
                                title,
                                {
                                    body: options.body,
                                    vibrate: options.vibrate,
                                    tag: options.tag,
                                    icon: options.icon,
                                    data: options.data,
                                    requireInteraction: options.requireInteraction
                                }

just by including the Data option it makes it possible to pass messages back and forth between the app and service worker.


Value targets in AlphaZero

Hello, I have a question regarding the current AZ implementation. It looks that it uses the average return from MCTS simulation as the value targets:
https://github.com/deepmind/open_spiel/blob/6a49b935bf674920071d0a23464a6d4fa3b39618/open_spiel/python/algorithms/alpha_zero/alpha_zero.py#L229-L232
The loss of the value network is defined as:
https://github.com/deepmind/open_spiel/blob/6a49b935bf674920071d0a23464a6d4fa3b39618/open_spiel/python/algorithms/alpha_zero/model.py#L339-L345
Where I suppose batch.value=root.total_reward / root.explore_count
However if I am not mistaken in the original paper the value targets should be the actual outcomes during an AZ training episode. Is there any difference between these two kind of value targets?

NVM I think it is using the actual outcomes:
https://github.com/deepmind/open_spiel/blob/6a49b935bf674920071d0a23464a6d4fa3b39618/open_spiel/python/algorithms/alpha_zero/alpha_zero.py#L382-L385


fixing Create-new-question dropdown (as the scroll bar isn't working)

Description
Dropdown for "create-new-question" doesn't have a scroll option. So Admins cannot choose other options.
Release notes:
Dropdown for "create-new-question" doesn't have a scroll option. So Admins cannot choose other options.
Checklist

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #3365 ;
Screenshots
Before:

After:

Codecov Report

Merging #3364 (be0ced4) into main (9fa4489) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3364   +/-   ##
=========================================
  Coverage     80.20%   80.20%
  Complexity     2348     2348
=========================================
  Files           287      287
  Lines          9275     9275
  Branches        618      618
=========================================
  Hits           7439     7439
  Misses         1594     1594
  Partials        242      242

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add an experimental Ethereum node config file

This file can be passed in with
GRAPH_EXPERIMENTAL_ETHEREUM_NODE_CONFIGS=/path/to/file.toml

and has to be a TOML file with the following format:
["http://url.of.the/ethereum/node"]
http_header = { authorization: "bearer ...", ... }

We already have one more config file, /etc/graph-node/expensive-queries.txt We should put this file into /etc/graph-node, too, say into /etc/graph-node/ethereum-nodes.toml and not use an environment variable.

Is the example TOML file in your initial comment valid?
I'd expect to use the keyhttp_headers (plural.)

Looks good! I'd love to test it with an Ethereum provider that requires the custom header config.

We already have one more config file, /etc/graph-node/expensive-queries.txt We should put this file into /etc/graph-node, too, say into /etc/graph-node/ethereum-nodes.toml and not use an environment variable.

@lutter Done. Supporting /etc/graph-node/ethereum.toml and $HOME/.config/graph-node/ethereum.toml (on Linux, on macOS it's $HOME/Library/Application\ Support/graph-node/ethereum.toml) now!

@lutter Docs added! https://github.com/graphprotocol/graph-node/blob/jannis/experimental-ethereum-node-configs/docs/ethereum-config.md


Add installation hints and note for beamer support

The required packages and installation instructions are incomplete.

Adding notes on what packages are required on Debian (and likely Ubuntu).
Adding notes to update the template for LaTeX beamer users

Thank you for your PR!
The rendered result seems broken. $ apt install should be block quoted (currently, it is inline quoted). Could you fix it?
https://github.com/Hakuyume/pandoc-filter-graphviz/blob/5b8364cffc64f520dfc22c64f8976323952df8f4/README.md

LGTM. Thank you!


haskellPackages.network: fix build on x86_64-darwin

I don’t know how this is able to build currently, but it requires at least the 10.15 SDK to build on x86_64-darwin due to requiring IP_RECVTOS.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Same as the other PRs re: nixfmt-check.


Bugfix/stats cleanup

I need to do other stat adding and I kept coming across these stats files with many warnings.

I've approved the code changes, but please also update the name of the PR to include the GEODE ticket associated with these changes.

@mhansonp echoing @DonalEvans & @dschneider-pivotal on the GEODE jira etc...  might be useful context to know the reason for the changes before I review...

A few typos and some unintentionally included changes. Also, could the title of the PR please be changed to reference the associated GEODE ticket and be more descriptive?

No. I removed the GEODE- ticket stuff. The  typos are a freebee. :)

This looks good @mhansonp. But I don't see a GEODE ticket for it.
✓ typos fixed
✓ a number of int stats became long stats
✓✓ final added in lots of places
𝙓 missing GEODE ticket reference

I added a new improvement GEODE-9190 to cover this work.

@mhansonp echoing @DonalEvans & @dschneider-pivotal on the GEODE jira etc... might be useful context to know the reason for the changes before I review...

Context: I need to do other stat adding and I kept coming across these stats files with many warnings.


Reflect new workflow name in badge

Signed-off-by: Juan Antonio Osorio<EMAIL_ADDRESS>

Codecov Report

Merging #10 (0156473) into main (059c6c8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          149       149
=========================================
  Hits           149       149

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059c6c8...0156473. Read the comment docs.


Incompatible with Arc shader?

It's not compatible with any shader. I've gone through around 30 of the popular ones & non of them work at all. It seems this mod breaks shaders completely.


[v4.0 Beta 2] - HTML5 Builds - macOS Safari Internet Browser - Not Running?

Godot version
v4.0.beta2.official [f8745f2f7]
System information
Apple macOS Monterey v12.0.1
Issue description
Hi,
The HTML5 version of our Godot v4.0 Beta 2 game is not working on Apple macOS Safari Internet browser?
Running Apple macOS Monterey version 12.0.1
See screenshot below:
Any ideas?
Thanks!
Jesse

Steps to reproduce
(1) Run HTML5 version of our Godot 4 game in Apple Safari Internet browser.
Minimal reproduction project
No response

As stated by the error message, the web server needs to be configured accordingly to support WebAssembly threads. Newgrounds doesn't seem to offer support for this (to my knowledge), so you'll have to use another host such as itch.io (which must be manually configured to do this).

Hi,
We tried Itch.io first over a week ago - it does not work on any OS platform.
v4.0 Beta 2 HTML5 status:

Windows 10/11 - Itch.io not working, NewGrounds.com working
Linux - Itch.io not working, NewGrounds.com working
macOS - Itch.io not working, NewGrounds.com not working

Hope this can be fixed...
Jesse


Visualisation map/graph of the k8s components and their relations

Is your feature request related to a problem? Please describe.
Yeah. I have not seen any good visualization tool on a market which shows real nice UI map of k8s components and how they are connected to each other.
Describe the solution you'd like
I can check for example security visualization and see the UI map of roles, role bindings users etc. How they are connected and so on and so forth.
Describe alternatives you've considered
You can split visualization based on the groups. Not all the objects together. It will be too complex and not readable. But let's say security things, network, pods, traffic flow etc.
Additional context
No additional context. UI and visualization capability of k8s objects and their relations.

We are working on a graph visualization that will provide a solution for this.
It is currently available in the cloud app.monokle.com and it is being added to the Desktop.
Tests and comments are welcome, there are improvements that can be done to it

@fog1985 we've added a Graph View to Monokle as of late - can you give that a try to see if it helps in this regard?

@fog1985 we've added a Graph View to Monokle as of late - can you give that a try to see if it helps in this regard?

Thanks @olensmar . Will check and get back to you with the feedback.


Unpack Solution step cannot handle both type at the same time

Hi,
the build task for exporting a solution automatically attaches a "_managed" suffix if exported solution is managed.
When I use the same pattern for unpacking solutions and select type = both the steps is not able to identify the unmanaged and managed solution zip file without the full name and attached ".zip".

Can you elaborate on how your setup looks when unpacking solution with type == both?
The managed and unmanaged solution need to be in the same directory, for example.
myDir ->

someSolution.zip
someSolution_managed.zip

With this setup the package tooling will unpack the solutions correctly as an aggregate containing unmanaged and managed components files. The _managed suffix is a requirement.

Export the solutions (https://dev.azure.com/PowerPlatform-ALM/_git/WS-11122?path=/.pipelines/templates/jobs/export-solution.yml)
      - task: PowerPlatformExportSolution@0
        inputs:
          authenticationType: "PowerPlatformSPN"
          PowerPlatformSPN: ${{ parameters.targetEnvironment }}
          SolutionName: "${{ parameters.solutionName }}"
          ${{ if eq(parameters.managed, 'false') }}:
            SolutionOutputFile: '"$(Pipeline.Workspace)/solution-export/${{ parameters.solutionName }}.zip"'
          ${{ else }}:
            SolutionOutputFile: "$(Pipeline.Workspace)/solution-export/${{ parameters.solutionName }}_managed.zip"
          Managed: ${{ parameters.managed }}
          AsyncOperation: true
          MaxAsyncWaitTime: "60"

      - task: PublishPipelineArtifact@1
        inputs:
          targetPath: "$(Pipeline.Workspace)/solution-export/"
          ${{ if eq(parameters.managed, 'false') }}:
            artifact: "solution_${{ parameters.solutionName }}_unmanaged"
          ${{ else }}:
            artifact: "solution_${{ parameters.solutionName }}_managed"
          publishLocation: "pipeline"

Copy files to one directory before unpack (https://dev.azure.com/PowerPlatform-ALM/_git/WS-11122?path=/.pipelines/templates/jobs/commit-solution.yml
      - task: CopyFiles@2
        inputs:
          SourceFolder: "$(Pipeline.Workspace)/solution_${{ parameters.solutionName }}_managed"
          Contents: "**/*.zip"
          TargetFolder: "$(Pipeline.Workspace)/solution_${{ parameters.solutionName }}_unmanaged"

With the files in the same location PowerPlatformUnpackSolution should just need the input file absolute path such as the following.
SolutionInputFile: "$(Pipeline.Workspace)/solution_${{ parameters.solutionName }}_unmanaged/${{ parameters.solutionName }}.zip"

Of course, you can put the files in any directory you wish just so long as both reside in the same directory.


Windows Lens v5.0.0 first connection attempt fails

Describe the bug
After adding external "sync" configs to lens for windows v5.0.0, first attempt to connect to the cluster always fails with "Invalid Credentials error"
To Reproduce
Steps to reproduce the behavior:

Add a cluster external config file as a "Kubeconfig Sync" in preferences "Kubernetes" tab
restart Lens
Attempt to connect to cluster
Error "invalid credentials" is shown
Attempt to connect again and connection can suceed

Expected behavior
Where config is valid, first attempt should suceed without error.
Screenshots
Screenshot, including failed attempt to get debug logs for win version using WSL terminal:

Environment (please complete the following information):

Lens Version: v5.0.0
OS: Windows
Installation method : auto upgraded from v5.0.0

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
Unable to get debug logs from windows lens - see later part of discussion on https://k8slens.slack.com/archives/C1U90NQN8/p1625045050141900 and screenshot in this post.
Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
N/A: connection works on second attempt
first time fail occurs with multiple clusters and with valid files using both ServiceAccount and Dex/LDAP login.

** Additional **
Would like to grab and post debug logging, will do so when advised how to do it in windows version of lens.

I am also getting the failed connect at initial connection to a cluster. Hit Reconnect a few times and got further but received the output in the screenshot below.  I am able to view the cluster resources now though.

Additional observation:
When performing the initial failing connect attempt there is only the message "Connecting..." and no message "Authentication proxy started" at any stage.
When clicking to try again there is the message "Reconnecting..." and then after a while "Authentication proxy started" after which the connection then succeeds.

That is a good hint thanks

Can take 2 or 3 times to connect and it's not quick compared to previous versions.
Also, I just get the error "Oops, something went wrong."

When can we expect the fix for this recurring issue please ? This is so frustrating

I assumed this would be resolved before 5.0 release since it was noted by the team in the beta, but it's still a very prevalent issue. Now when Lens has very high CPU usage (after opening a couple clusters or so now) and I go to restart Lens, I run into this error for every cluster individually and it can take 1 to 5 reconnection attempts before it eventually works.
Any thoughts on what could be the cause?

Marking this as a blocker for 5.1.1 as we plan to release 5.1 (with some other bug fixes) today.

Updated just now, the first connection fails with the following error: Oops, something went wrong. Error: connect ECONNREFUSED <IP_ADDRESS>:80

This is on 5.1.0-latest.20210715.1

I can also confirm that this is still happening on the latest release build

Yes we are currently investigating why that proxy connection is failing on windows. Thanks for the additional report.

Every first connection to a cluster fails. Example for an AWS EKS cluster:

This fails in the same way for docker desktop kubernetes cluster, GCP K8s cluster.
I have my K8s kubeconfig set up locally, no sync or Lens cloud.

Yes the local web server is part of Lens, we are still looking into this.

https://github.com/lensapp/lens/pull/3458 seems to have fixed the issue 🎉

🎉 Excellent, what about you @Kolossi ?

I also confirm that the latest build has fixed this issue.

@Nokel81 : Unfortunately not quite there for me on Windows 10 and exactly same "help->about" as image in ramanNarasimhan77 previous post.
When I click to connect to first cluster, it goes through "connecting..." -> "Authentication proxy started", but then spins forever, no error shown.
 -> "Authentication proxy started", but then spins forever, no error shown.
Clicking back on the first cluster, it says "connecting..." then connection completes after about a second and overview shown.
Clicking back on the second cluster, it says "connecting..." then connection completes after about a second and overview shown.
Having done this, if I click on a third cluster I still get "connecting..." -> "Authentication proxy started" and it spins forever, no error shown.
Clicking off to first or second cluster then back to third cluster, it says "connecting..." then connection completes after about a second and overview shown.

I'm too experiencing connection issues with Lens 5. It doesn't get solved for me in the second attempt. Not sire if I need to open a separate issue for this.
I have downgraded to version 4.2.5 and connection is working.
Let me know if I can help in any way - logs etc.
kubectl is working fine without any issues using the same config file.

We have https://github.com/lensapp/lens/pull/3511 which is slated to be part of the 5.2.0 release. As for 2750, I wonder if that is a race condition... We use the port that is automatically given to us by the OS. However, in 4.2.4 there was a race condition where we would try and get a port and then stop using it before trying to use it again, that has been removed.

I still experienced the issue with 5.1.3 as well.
With 5.2.0 on first use the connections did not throw these errors. I'll monitor in the coming days.

@Nokel81 I agree with @m8ram that initial indications with 5.2.0 are good - thanks!
As it's an issue that sometimes happens and sometimes doesn't, it seems fair to hold on closing for now though - I'll also monitor over the next few days and report back.

Will close this then. Please open a new issue (referencing this one) if you encounter it again.

It's now connecting in version 5.2 but causes a blue screen of death in Windows... I'll open a new issue.


[Extra MetaData Loader] No Videos Anymore

Extension name
Extra MetaData Loader
Bug Description
The videos aren't showing up properly in my Playnite (10.16).
To Reproduce
No response
Logs
playnite.log
extensions.log
Screenshots

The problem persists after uninstall/reinstall of extension and an update to Playnite 10.17.

Please follow the instructions here:
https://github.com/darklinkpower/PlayniteExtensionsCollection/wiki/Extra-Metadata-Loader#videos-are-not-playing


Confusion about the coarse transformer trainer

https://github.com/lucidrains/audiolm-pytorch/blob/241bae318f3e49860e765058c0c7abeceb1c9760/audiolm_pytorch/audiolm_pytorch.py#L1414
@lucidrains Here at line 1414 and 1415, why not:
batch = raw_wave_for_codec.shape[0]
num_timesteps = raw_wave_for_codec.shape[1]

@xtluo Thanks Xiaotao! https://github.com/lucidrains/audiolm-pytorch/commit/914ba79adbde1af937b8bb8e29e17e7b2e295dc2

Thank you for your email.This is  an automatic reply, which means I have received your email and I will check it as soon as possible.Best wishes !Xiaotao Luo


can you share a requirements.txt of this project?

I can not install this project in my osx 11.2.3 from latest vesion of conda. Maybe a requirements.txt is better.

I'll have to create a minimal one from scratch. It might take a couple of days since I have a deadline on Thursday but it's in my todos.

@wuyongyi I've uploaded a minimal requirements.txt. Can you test if it works for you?