Check for return code for git clone

In get.sh, we should check return code for git clone. If git clone fails, there is no point to continue. In general, we need better error handling.
https://github.com/AdoptOpenJDK/openjdk-tests/blob/e825d9596f794c7472bae350d10e131e97f723ec/get.sh#L174
Current behavior:
00:01:11.591 + /home/j9build/workspace/Test-sanity.functional-JDK8-linux_x86-64_cmprssptrs/openjdk-tests/get.sh -s /home/j9build/workspace/Test-sanity.functional-JDK8-linux_x86-64_cmprssptrs -t /home/j9build/workspace/Test-sanity.functional-JDK8-linux_x86-64_cmprssptrs/openjdk-tests -p x64_linux -v openjdk8-openj9 -r upstream --openj9_repo https://github.com/eclipse/openj9.git --openj9_sha d56f6d0da0dd95c89481d69c2ea64105f0ba1ee2
00:01:11.591 git clone  https://github.com/eclipse/openj9.git
00:01:11.591 fatal: Unable to find remote helper for 'https'
00:01:11.591 update to openj9 sha: d56f6d0da0dd95c89481d69c2ea64105f0ba1ee2
00:01:11.591 /home/j9build/workspace/Test-sanity.functional-JDK8-linux_x86-64_cmprssptrs/openjdk-tests/get.sh: line 179: cd: openj9: No such file or directory
00:01:11.591 fatal: Unable to find remote helper for 'https'
00:01:11.591 fatal: reference is not a tree: d56f6d0da0dd95c89481d69c2ea64105f0ba1ee2
00:01:11.591 mv: cannot stat 'openj9/test/TestConfig': No such file or directory
00:01:11.591 mv: cannot stat 'openj9/test/Utils': No such file or directory
00:01:11.591 mv: cannot stat 'openj9/test/functional': No such file or directory
00:01:11.591 mkdir: cannot create directory ‘openjdkbinary’: File exists
00:01:11.591 OpenJ9-JDK8-linux_x86-64_cmprssptrs-201801081641.tar.gz

In general, shell scripts will fail on error (default), is there a reason why this is different for this script (or so it appears). I believe it is controlled with set +/-e but I do not see that in the script.


Add priority to reminders

Codecov Report
Base: 58.97% // Head: 59.70% // Increases project coverage by +0.72% :tada:

Coverage data is based on head (251f81e) compared to base (68fcafb).
Patch coverage: 39.39% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
+ Coverage     58.97%   59.70%   +0.72%
- Complexity      612      651      +39
============================================
  Files           129      131       +2
  Lines          2406     2499      +93
  Branches        288      308      +20
============================================
+ Hits           1419     1492      +73
- Misses          892      910      +18
- Partials         95       97       +2

Impacted Files
Coverage Δ

...ogic/parser/reminder/AddReminderCommandParser.java
0.00% <0.00%> (ø)

...ress/logic/parser/reminder/ReminderParserUtil.java
0.00% <0.00%> (ø)

...seedu/address/model/reminder/ReminderDeadline.java
70.00% <ø> (ø)

...ava/seedu/address/model/reminder/ReminderName.java
70.00% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
13.63% <ø> (ø)

...ava/seedu/address/storage/JsonAdaptedReminder.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/ReminderCard.java
0.00% <0.00%> (ø)

...seedu/address/model/reminder/ReminderPriority.java
70.00% <70.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
94.11% <100.00%> (+0.36%)
:arrow_up:

...in/java/seedu/address/model/reminder/Reminder.java
80.64% <100.00%> (+2.86%)
:arrow_up:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[system tests] skip javadoc and deploy

There's no point producing javadoc or publishing artefacts for the kroxylicious-systemtest module to Maven Central.  The module isn't intended to be consumed like this.
We should disable those plugins to reduce the build/deploy time.

@franvila FYI


FluentDatePicker invalidates a valid date OR fails with Serialization Exception

🐛 Bug Report
Using FluentDatePicker (no matter whether Interactive Server or WASM) always fails because it doesn't accept the picked date after submit:

When I prepared a minimal reproduction repositry, I got a totally different error:
System.NotSupportedException: Serialization and deserialization of 'System.Type' instances is not supported. Path: $.Type.
       ---> System.NotSupportedException: Serialization and deserialization of 'System.Type' instances is not supported.
         at System.Text.Json.Serialization.Converters.UnsupportedTypeConverter`1.Write(Utf8JsonWriter writer, T value, JsonSerializerOptions options)
         at System.Text.Json.Serialization.JsonConverter`1.TryWrite(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.GetMemberAndWriteJson(Object obj, WriteStack& state, Utf8JsonWriter writer)
         at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryWrite(Utf8JsonWriter writer, T value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.JsonConverter`1.TryWrite(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.JsonConverter`1.TryWriteAsObject(Utf8JsonWriter writer, Object value, JsonSerializerOptions options, WriteStack& state)
         at System.Text.Json.Serialization.JsonConverter`1.TryWrite(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
[…]

💻 Repro or Code Sample
https://github.com/Ducki/FluentUiRepro
Relevant location: https://github.com/Ducki/FluentUiRepro/blob/3cf2f781d3007ce053b40bfd958eb4ebc1ce16f0/BlazorWasm/Components/Pages/Home.razor#L10
🤔 Expected Behavior
Submit the hand picked date and accept it as valid, because I picked it with the actual date picker.
😯 Current Behavior
See above.
💁 Possible Solution

🔦 Context

🌍 Your Environment

macOS, .NET 8.0.1
Browser: Firefox and Safari
IDE: Rider

The problem is in your code (not in the component).
Update the Counter.razor page in the BlazorWasm.Client project,
with this code and all will be fine.

Add a FormName="MyForm" attribute
Rename your Person class to PersonModel to avoid class conflicts.

@page "/counter"
@rendermode InteractiveWebAssembly

<EditForm OnSubmit="Callback2" Model="Person" FormName="MyForm">
    <FluentDatePicker Name="Person.Birthday"<EMAIL_ADDRESS>    <FluentButton Type="ButtonType.Submit">OK</FluentButton>
</EditForm>

@code
{
    [SupplyParameterFromForm]
    public PersonModel Person { get; set; } = new PersonModel();

    private void Callback2(EditContext obj)
    {
        Console.WriteLine("OK");
        Console.WriteLine(Person.Birthday);
    }

    public class PersonModel
    {
        public DateTime? Birthday { get; set; }
    }
}


[MailGun] GotError: options.body must be a ReadableStream, string or Buffer

adonis-mail version: git#develop
Driver used: mailgun
Node.js version: v6.4.0
npm version: v3.10.3
Hey !
I got an error from got when I try to send a email with the mailgun driver.
Exception
```
{ GotError: options.body must be a ReadableStream, string or Buffer
    at got (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/got/index.js:81:10)
    at Function.got.(anonymous function) [as post] (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/got/index.js:272:10)
    at MailGunTransport.send (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/adonis-mail-provider/src/Mail/Drivers/MailGun/transport.js:75:9)
    at Nodemailer. (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/nodemailer/lib/nodemailer.js:324:30)
    at Nodemailer._processPlugins (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/nodemailer/lib/nodemailer.js:352:16)
    at Nodemailer. (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/nodemailer/lib/nodemailer.js:318:14)
    at Nodemailer._processPlugins (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/nodemailer/lib/nodemailer.js:352:16)
    at Nodemailer.sendMail (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/nodemailer/lib/nodemailer.js:280:10)
    at MailGun.send (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/adonis-mail-provider/src/Mail/Drivers/BaseDriver.js:60:22)
    at Mail.send (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/adonis-mail-provider/src/Mail/Mail.js:129:30)
    at next (native)
    at onFulfilled (/Users/romainlanz/workspace/qualitas-helvetica.ch/node_modules/co/index.js:65:19)
    at process._tickDomainCallback (internal/process/next_tick.js:129:7) nested: undefined, status: 500 }
```

The error seems to be thrown when we are calling got.post(...) on the MailGun API. It's at the line 75 of the MailGun driver

I'm using adonis-mail-provider version 2.0.0 and had the same problem. The package references got only as a dev dependency. npm pulled version 3.x because this version is referenced by the package package-json.
npm install --save got installed 6.x and solved this problem for me.

@RomainLanz Would you try to install got as a your project dependency and let me know if it works. I will add it as a dependency then.

I confirm that installing got directly in my project does the trick!

Cool, I will fix it by including it as a dependency.


missing discord logo

https://discordapp.com/branding

I feel like it looks a little small when it's placed on a standard sized badge:
@1x
@1.5x
@2x
@1x
@1.5x
@2x
@1x
@1.5x
@2x

Hmm, only use the inner "ghost" instead all talk bubble?

Doesn't look like they provide/endorse the use of just the "ghost" as their logo in the link you provided,
May be worth sending them an email to check though.

Here it is without the 'chat bubble':

I like the white one a lot!


Unexplicit message when feed is already subscribed

If a subscription already exists, the message which is outputted as a flash message is not really accurate: Unable to find a subscription..
To try, add a subscription (tried with this one), and try to add it again.
I think the message should be something more like Subscription already existing..
BTW, amazing app!

It's already fixed in master.

My bad then.


Correctly configure GTK3 to reflect recomended stable release settings

GTK/Glib packaging guidelines recomends a release build to use debugging
facilities set to level 'minimum'. Disabling this is officially not
recomended for stable releases. For more info read the following link,
the section --enable-debug.
https://developer.gnome.org/glib/stable/glib-building.html#extra-configuration-options

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: fungos sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR!


image rendering without playwright

docker-compose-viz currently embeds the minified mermaid.min.js script along with the playwright library (headless browser automation). Playwright is however very heavy and doesn't work well inside a docker image.
This issue is about looking for a replacement, that is, a way to still render mermaid diagrams offline and from Kotlin, but with a lighter tool.

why not the official cli ? https://github.com/mermaid-js/mermaid-cli

Hello there!
Just a heads up: the latest release supports the official mermaid-js as well, provided you have npm installed on your system. Let me know what you think.


Fix typo

Hello my name is yuta yamada.
I'm inform  to found typo.

Thank you! You are awesome :)


Style issues on EDGE with Polymer 2

Description
I have some style issues with EDGE
Screenshot of the issue
Take on the paper-icon-item demo from webcomponents.org, but I have same issue on our applications.

Browsers Affected

[ ] Chrome
[ ] Firefox
[x] Edge version 40.15063.0.0
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v2.0.1
webcomponents: v1.0.1

Is this issue only with the paper-icon-item element?

Nop @azakus, all component are affected, I have checked randomly the demos of some webcomponents.org and there is the same issue on paper-menu-button, paper-dropdown-menu, paper-progress, paper-spinner...etc

Can confirm this is an issue for all components
Weird thing is the issue does not persist on
Edge version: 38.14393.1066.0
EdgeHTML version: 14.14393

I have the same problem
Microsoft Edge 40.15063.0.0
Microsoft EdgeHTML 15.15063

Me too, https://github.com/webcomponents/webcomponents.org/issues/1034

See also PolymerElements/paper-listbox#39, PolymerElements/font-roboto#16 and https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11495448/

As mentioned by @feuerste , I solved my problem changing roboto.html file just adding type="text/css" on it. After changes, this file should be like this:

Thank you very much @feuerste

@eduardopthiago, you can actually just use 1.0.3 of font-roboto now, since PolymerElements/font-roboto#16 is already merged :)

The Polymer site I'm working on is completely unusable on Edge, and it seems impossible to debug because Edge doesn't recognize shadow roots in its DevTools. Here's a link, compare it to Chrome or Firefox.

@TrebuhD it seems that you have a file request that should 404 but instead serves back index.html. In my case, the url https://next.suttacentral.net/localization/elements/static_donations-page/nl.json does not return a JSON response, but index.html instead. I think Edge is more strict in this case and throws an error, while Firefox and Chrome are okay with this.


[haproxy] Refactor script

Make the script more readable, mostly by:

using the Product classes,
removing the use of functions when unnecessary,
a little bit of renaming and documentation.

No version update as expected, merging.


Problem of install llvm on go 1.8

hi
i can not, install llvm on go 1.8.
os: ubuntu 16.10-64bit

$~/go/src/github.com/go-llvm/llgo$ go version
go version go1.8 linux/amd64

$ go get -insecure -d -v llvm.org/llvm/bindings/go/llvm
Fetching https://llvm.org/llvm/bindings/go/llvm?go-get=1
Parsing meta tags from https://llvm.org/llvm/bindings/go/llvm?go-get=1 (status code 404)
package llvm.org/llvm/bindings/go/llvm: unrecognized import path "llvm.org/llvm/bindings/go/llvm" (parse https://llvm.org/llvm/bindings/go/llvm?go-get=1: no go-import meta tags ())

$ go get -tags byollvm github.com/go-llvm/llvm
github.com/go-llvm/llvm
could not determine kind of name for C.LLVMDisposeMessage

You need to report this to whoever maintains llvm.org/llvm/bindings/go.  That isn't us.

It looks as though maybe you are using the old (stale) installation instructions for llgo (there is a note on that page saying that the project has moved to LLVM). Have you tried the instructions in http://llvm.org/svn/llvm-project/llgo/trunk/README.TXT?

http://stackoverflow.com/questions/43438219/how-get-llvm-library-in-go


Why you should get into NFTs!

 NFTs are going to revolutionize how we do business and everyone should be paying attention and building with NFTs in mind.
I will cover why NFTs make sense from a psychological perspective and how NFTs benefit people and organizations to build community of superfans and scale their businesses.
Target Audience:   Beginner, Intermediate
Style of Session:  30 min Regular Talks
About me:
I'm Dheeraj Shah, a content creator & Podcaster at Web3 with Dhee who talks and interviews people about DeFi, NFTs, DAOs, Gaming & Investing in web3.
https://twitter.com/DheerajShah_
https://linktr.ee/dheerajshah

label:

label: Beginner, Intermediate, 30 min Regular Talks


"Unifiednlp do not have location to test geocoder" will not pass

I have installed MicroG with all the backends with nanodroid. It has all the permissions, full internet access and all backends are enabled.
Yet I cannot get "Unifiednlp do not have location to test geocoder" to pass. What else can I try to investigate to find out why it is failing?
Just to note, I have no sim card in this phone yet, but that shouldn't cause an issue should it?

I have same problem with my device too. But it got fixed by removing the magisk module and reinstall it. Might take a while but it would work.
But problems still exists some random time all modules disabled on reboot. After another reboot the problem of unitednlp still exists. Maybe don't use nanodroid for now.

I can't reproduce the issue. Where's the log?
Also duplicate of https://gitlab.com/Nanolx/NanoDroid/issues/47
Am 23. März 2019 00:32:45 MEZ schrieb JohnGLFour<EMAIL_ADDRESS>
I have same problem with my device too. But it got fixed by removing
the magisk module, restart and reinstall it. (Repeat if problem still
exists) Might take a while but it would work.
But problems still exists some random time all modules disabled on
reboot. After another reboot the modules re-enabled, modules reseted
and the problem of unitednlp still exists. Maybe don't use nanodroid
for now.
@Nanolx please fix it.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/microg/android_packages_apps_GmsCore/issues/733#issuecomment-475811566

--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

I could only fix this but removing NanoDroid and installing MicroG using the APK's from their website and moving them to priv-app. I then installed the back-ends via fdroid.
It works perfectly after doing that


Security: Control Plane Components should not automount service tokens if not required

Our control plane security requires that cluster master pods not automount service acount tokens unless absolutely necessary. Here's the current list of security violations when compared to a non-Hypershift deployment of ROKS version 4.9.
vagrant@verify-cluster:~$ for DEPLOYMENT in $(kubectl get deployments -n master-prtesting49-63493628 -o name); do

echo "${DEPLOYMENT} automountServiceAccountToken: $(kubectl get "${DEPLOYMENT}" -n master-prtesting49-63493628 -o jsonpath='{.spec.template.spec.automountServiceAccountToken}')" | grep -vE 'false|cluster-health|cluster-updater|control-plane-operator|etcd-operator|openvpn-operator|rbac-sync-operator'

done
deployment.apps/catalog-operator automountServiceAccountToken:
deployment.apps/certified-operators-catalog automountServiceAccountToken:
deployment.apps/cluster-api automountServiceAccountToken:
deployment.apps/cluster-autoscaler automountServiceAccountToken:
deployment.apps/cluster-policy-controller automountServiceAccountToken:
deployment.apps/community-operators-catalog automountServiceAccountToken:
deployment.apps/hosted-cluster-config-operator automountServiceAccountToken:
deployment.apps/ignition-server automountServiceAccountToken:
deployment.apps/machine-approver automountServiceAccountToken:
deployment.apps/olm-operator automountServiceAccountToken:
deployment.apps/packageserver automountServiceAccountToken:
deployment.apps/redhat-marketplace-catalog automountServiceAccountToken:
deployment.apps/redhat-operators-catalog automountServiceAccountToken:

This sgtm.  Anyone that has time can proceed with this.  If you are working on this, please post here so we don't dup effort.

Out of the list above, based on initial testing, the following components likely do not need auto-mount service tokens:

catalog-operator
certified-operators-catalog
cluster-policy-controller
community-operators-catalog
redhat-marketplace-catalog
redhat-operators-catalog
olm-operator


[Improve] ddl schema column length improvement

[Improve] ddl schema column length improvement

cc @macksonmu @Al-assad PTAL, thx

@Al-assad @macksonmu  Thanks for your review, updated, please review again.

Hi @wolfboys , I think the length of some of the fields related to k8s resources should be fixed.
The k8s namespace resource requires compliance with the RFC-1123 label names standard (contains at most 63 characters). ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#namespaces-and-dns
Flink kubernetes.cluster-id configuration item is limited to a maximum length of 45 characters. ref: https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/#kubernetes-cluster-id

Thanks for your review, updated.


RawKeyboard synthesizes key pressing state for modifier

This PR changes RawKeyboard so that, if the current key is being pressed but does not exist in the modifier bit mask, add this key to keysPressed. This change effectively disables the assertion check immediately after _synchronizeModifiers (but it is still kept there.)
This change fixes a case on Linux where a very peculiar sequence of key presses result in an AltRight key down event being sent without the Alt modifier bit, breaking our assumption where the key being pressed must exist in the modifier bit. The approach of this PR adapts the keysPressed state to the event.
An alternative solution is to pretend this event didn't happen, adapting the event to the keysPressed state. I didn't choose this solution because it breaks RawKeyboard's design of one-to-one mapping from the native events to the Flutter events. After all, the modifier bits are used to assist synthesization, not to change event output overall.
It's a sad choice to disable this check that helped us for so long. Update: I've limited the check bypassing to Linux AltRight key.
This PR fixes one of the two symptoms of https://github.com/flutter/flutter/issues/93278.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Update: I've limited the check bypassing to Linux AltRight key.


Fix android duplicate linking

android isInstalled has a different signature than ios counterpart
Motivation
Run react-native link on a project with an android library that is already linked: the check will fail and will link again.
This should fix #18053
Test Plan
AppCenter SDK for React-Native uses linking. Running react-native link on appcenter package would constantly add the imports, the moduleConfig strings and add duplicated code to MainApplication.java without this patch.
I also tested it didn't break ios linking.
Release Notes

[ANDROID] [BUGFIX] Fix react-native link adding duplicate code and configuration when running a second time.

Can you please elaborate why we need an exception for Android? I'd also prefer to keep signature the same.

@Kureev the object ios uses, I debugged it and does not contain the dependency.name that Android needs. Are you suggesting having 3 parameters instead of 2?

react-native link on Android is definitely broken when moving from react-native 0.53.0 to 0.53.2.  New entries are created every time the command is executed.
Seems to be this commit:  https://github.com/facebook/react-native/commit/a40bfa730e05c68da49e6f217ae0f161dcc7ba98#diff-ca7cc59db13ac8eb27fe0a9a6c9debee

@Kureev @grabbou any suggestion for going forward? This impacts every single library having native android code. Without this patch every single time you run react-native link it will duplicate everything in build.gradle (compile project statements), duplicate imports in MainApplication.java, duplicate modules returned in the same file and duplicate string resources, and duplicate settings.gradle changes.
This patch fixes the regression when the code was refactored in https://github.com/facebook/react-native/commit/a40bfa730e05c68da49e6f217ae0f161dcc7ba98#diff-ca7cc59db13ac8eb27fe0a9a6c9debee

Been  hit with this bug.. no matter what react-native  version.. new create and old  also effected.

I've pinged @Kureev to look into it - let's wait for a day or two and then, I'll cherry-pick this back to the releases that are affected. I am really sorry for any inconvenience.

I am even more sorry for this. This is absolutely not @grabbou's fault - I had mixed up a two branches where I was working on support for linking platforms other than iOS and Android and ended up testing the wrong code.  Very sorry @grabbou and @Kureev that we have to patch those releases again. :-(

Hi @rozele do you confirm #18207 supersedes this one? Should I close mine?

@guperrot - #18207 includes this fix in the style requested by @Kureev as well as another fix for unlinking iOS pointed out by @Titozzz

react-native upgrade
and choose y change new version
yarn install
react-native link

;))


Fix Comfoconnect errors during startup

Description:
This pull request fixes the "AttributeError: 'NoneType' object has no attribute 'add_job'" errors by using the async_added_to_hass callback.
I'm not 100% sure if this approach is correct, but it is working fine for me the last couple of days.
Related issue (if applicable): fixes #22781
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Allright, I will try to address the changes. I'm planning to do a followup PR later with changes to the sensors, since there are a lot more sensors that are currently not exposed in Home Assistant.

@MartinHjelmare I've made the requested changes. Pycharm (with default settings) also reordered the imports.

Actually, I will also change the sensor to not pass hass and use correct string formatting.

I will do the config validation in a different PR.

@MartinHjelmare I've made the requested changes. Pycharm (with default settings) also reordered the imports.

Pycharm did wrong. I reorderd with isort.

Can be merged when build passes.


⚠ BCR Bot has degraded performance

In 4c2390d, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1231 ms

Resolved: BCR Bot performance has improved in 6e1ac3e.


Exercise Pangram should define which alphabet is expected

While doing this exercise I've noticed that the README.md does not mention which alphabet one should be checking against. I originally assumed an English alphabet, yet the last test in German being considered a pangram made me reconsider. I guess in summary the alphabet / language to be tested against should be defined exercise problem description, otherwise this is a rather unbounded problem.

I can put up a pull request that fixes it, I just wanted other people's opinion on the matter.

Clarification of the readme would certainly be useful. In the case of this exercise it's only looking for ascii characters. Nothing in extended ascii (or unicode, etc.) should count.
The edge case that the German test is trying to cover is that non-ascii characters don't blow up your code. It does contain a full ascii pangram once you filter out all of the extended characters.

exercism/x-common#284 hopefully clarifies this.


useOnSelectionChange on change must be memoized now

Describe the Bug
The on change callback must be memoized using useCallback now. Otherwise the event triggers only when deselecting a node.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Pass an onChange function to useOnSelectionChange that has not been wrapped in useCallback.
Observe that the event only triggers when deselecting a node.

Expected behavior
This should be documented as a breaking change or fixed.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

Thanks. Documented!


Banlist page should pull data from the new API and be rendered client-side

https://netrunnerdb.com/en/banlists
This page could use some big improvements:

Format Support
Ensure that restrictions are properly filtered to cards legal in the card pool for the given format/card pool/restriction snapshot.

This has been done for a while.  Closing it out.


remove istio-validation container when running istioctl rm

If you're using IstioCNI and trying Istioctl remove-from-mesh, you will find that all istio-related stuff is removed from the deployment manifest except for the init-container. This PR will fix that
[ ] Configuration Infrastructure
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
96098477f8c0be313e64cc0f184abb63efaaabd3
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
96098477f8c0be313e64cc0f184abb63efaaabd3
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio

@tariq1890: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
96098477f8c0be313e64cc0f184abb63efaaabd3
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #26189

In response to a cherrypick label: new pull request created: #26190

In response to a cherrypick label: cannot checkout release-1.8: error checking out release-1.8: exit status 1. output: error: pathspec 'release-1.8' did not match any file(s) known to git


Is there an issue with Jenkins integration (it doesn't believe the webhook is working)

I hesitate to ask this here, because the SMEE bits all seem to be working, but I am getting no responses elsewhere...
We're running Jenkins behind a firewall to public github.com using a SMEE client to provide the necessary proxy.  However in our Jenkins [version 2.361.4-jdk11] configuration page, the Github plugin flatly refuses to save the Override Webhook URL https://smee.io/blah (where blah is our SMEE channel), instead, when Apply is pressed, it says (in orange):
"It doesn't look like https://smee.io/blah is talking to Jenkins.
We can see that, the moment Apply is pressed on the Jenkins configuration page, the SMEE server receives an event, with payload of the form:
"1668551517454":{
}

...and, at the same time, the journald log output from the  SMEE client (which is running on the same machine as Jenkins, each in their own Docker containers) shows that it has successfully posted back to the correct [the default] port of Jenkins:
POST http://<IP_ADDRESS>:8080/github-webhook/ - 200

...<IP_ADDRESS> being the address of the machine where the SMEE client and Jenkins are running.  So connectivity from Jenkins to SMEE server, SMEE server to SMEE client and SMEE client to Jenkins all seem to be working.
But Jenkins doesn't believe the webhook has worked for some reason; any ideas why, or how we might probe more deeply?  The Jenkins journald log output says nothing more interesting than INFO h.p.b.g. GlobalTimeOutConfiguration#configure: global timeout has been cleared at about this time?
In case it matters the SMEE client was run with:
docker run --name smee-client --restart=on-failure --detach --log-driver=journald deltaprojects/smee-client -u https://smee.io/blah -t http://<IP_ADDRESS>:8080/github-webhook/

...and the Jenkins Docker installation was built/run according to the Jenkins instructions.

S'OK, it appears that the GUI of the Jenkins Github plugin is broken, it never saves what you type into the Override Hook URL box.  It has been broken since September 2020.  If you have a Jenkins Jira account you can see the pain.
In case anyone else comes across this, the accepted workaround is to manually edit the Jenkins github-plugin-configuration.xml configuration file to add a field of this form:
<hookUrl>https://smee.io/thestringfromsmee</hookUrl>

...[this example for my case, using SMEE] inside <github-plugin-configuration>, at the same level as <configs> and <hookSecretConfigs>, then restart Jenkins.
Ho hum.


changed valid values for  the sex variable

This is now compatible with the PED file format and the documentation.

PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

@ramprasadn I wasn't sure about the base branch for this PR. Just let me know if this patch branch is not the best choice :D

Hi @sima-r! I have changed the base from patch to dev since these changes will be going into a minor release. As for the lint error, it was related changes in the recent template merge. It has been addressed in the dev branch so a merge with the current dev should fix it.


Provide the "Capture Dev Tools Timeline" option

Hello !
When programming a job involving Chrome, I'd like it to be able to record the dev tools timeline, as in the WPT UI => advanced settings => chrome tab.
We could add that into the advanced options, as this is chrome-only and it adds up to the test overhead and fills up the disk a bit faster.
I need it because I'm monitoring the CPU times of the 3rd parties, here is my workflow :

tests are planned thanks to OSM
a script of mine get the latest WPT tests (thank you very much for the REST API !)
it would extract the timeline from the WPT server, thanks to https://github.com/marcelduran/webpagetest-api
the timeline is analyzed with https://github.com/jpvincent/3rd-party-cpu-abuser
results are sent in a dashboard of mine

I currently can't use OSM to program tests with dev tools timeline turned ON.
Thanks in advance

With release 4.5.0 we fixed this issue by displaying the Chrome tab no matter which browser is used. We think that this is an advanced feature which is used by users who know their way around in OSM. So, we think that there will be no confusion when displaying a tab for Chrome only features, even though the browser for this job is not Chrome.


No RPC connection via public IP address

I seem not to be able to connect to my node from outside my network and I can't find what's the issue.
Wallets like "Union 7" or "Zap" are able to connect from within the network.
The relevant part of lnd.conf looks like this:

rpclisten=<IP_ADDRESS>:10009
tlsextraip=MY.FIXED.IP           # fixed ip is needed
tlsextradomain=HOSTNAME.OF.IP	    # domain name

tls.cert and macaroon are copied into the wallet's preferences.
The router seems to be configured correctly as an nmap -p10009 -Pn MY.FIXED.IP shows the result

Starting Nmap 7.60 ( https://nmap.org ) at 2019-02-18 17:57 CET
Nmap scan report for HOSTNAME.OF.IP (MY.FIXED.IP)
Host is up (0.0041s latency).
PORT      STATE SERVICE
10009/tcp open  swdtp-sv
Nmap done: 1 IP address (1 host up) scanned in 0.04 seconds

Nontheless, changing the IP from internal to external in the wallet's preferences prevents a connection. How can I troubleshoot this further?

Did you adjust the subnet mask for the UFW rule?

Yes, UFW rules look like this
To                         Action      From
--                         ------      ----
22                         ALLOW       <IP_ADDRESS>/24             # allow SSH from local LAN
50002                      ALLOW       <IP_ADDRESS>/24             # allow Electrum from local LAN
9735                       ALLOW       Anywhere                   # allow Lightning
8333                       ALLOW       Anywhere                   # allow Bitcoin mainnet
18333                      ALLOW       Anywhere                   # allow Bitcoin testnet
22                         ALLOW       <IP_ADDRESS>/24           # allow SSH from local LAN
22                         ALLOW       <IP_ADDRESS>/24
10009                      ALLOW       Anywhere                   # allow LND grpc from anywhere
9735 (v6)                  ALLOW       Anywhere (v6)              # allow Lightning
8333 (v6)                  ALLOW       Anywhere (v6)              # allow Bitcoin mainnet
18333 (v6)                 ALLOW       Anywhere (v6)              # allow Bitcoin testnet
10009 (v6)                 ALLOW       Anywhere (v6)              # allow LND grpc from anywhere

Tried to disable ufw, no success either way.

If you use interface <IP_ADDRESS>, UFW is not blocking anything and you're able to connect from within the network, I don't think it's the configuration of the node.
I'm sure you checked, but port forwarding is set correctly to the internal IP address of your node for port 10009?

The IP/host info is probably different in the tls.cert and that might prevent your app from connecting.

Check: https://ln-zap.github.io/zap-tutorials/iOS-remote-node-setup
In the last part the tutorial may give you clues why this is not working.


Move IsSubType and write some docs for the trait

This moves the IsSubType trait from dispatch.rs to traits.rs. It also
adds docs to make the trait better understandable.
polkadot companion: https://github.com/paritytech/polkadot/pull/1829

bot merge

bot merge


I want to control Speed

Hello Sir,
I am using this wheel can i control speed, and rotating time?

@DileepAmrani Hey, thanks for your question.
Currently it is not possible to control this but we are thinking of implementing it in future releases!

Thanks


Deprecate --signature-manifest flag from notation sign

What is the areas you would like to add the new feature to?
Notation CLI
Is your feature request related to a problem?
notation sign has a flag --signature-manifest to sign an artifact and store the signature using OCI artifact manifest. This flag is defined in notation sign.
image-spec v1.1.0-rc.3 removed OCI artifact manifest. This is a breaking change that we need to rethink when delivering a stable Notation v1.0.0.
What solution do you propose?
Deprecate --signature-manifest flag from notation sign but still enable Notation users to read and verify the existing signatures stored with the OCI artifact manifest type in registries that comply with OCI Distribution Spec v1.1.0-RC.1.
There might be some users who are using previous Notation releases. So Notation should still care for those old artifact manifests (signatures).
What alternatives have you considered?
N/A
Any additional context?
No response

Thanks @FeynmanZhou, I will take this one.

Cross posting my comment https://github.com/notaryproject/notation/issues/659#issuecomment-1541121437


IMPROVE: Onboarding/Vault creation

Vault Creation is sometimes unclear to the user, to make it more intuative until the new UI upgrade is ready, please implement the new onboarding flow from figma.
The UX flow should be pretty self-explanatory. If not, please ping me on implementation.

@Rockindash Could you update this screen again according to figma and inlude in #750 ?


Do you have non vue version?

This is very good player and I modify it to support non Soma FM player.
Do you have non vue js for this project?

Hey, glad you like it. Just have the vue version at the moment.

Hey, glad you like it. Just have the vue version at the moment.

I don't like it, I am suppperrrr like it hahahha, you know that now I learn Vue better because of your code and even I launch a web called Dailymate Radio at https://dailymate.net based on yours pls check it out!


Update Java services to 0.7.0

For Delhi, we should update the Java services to 0.7.0.

Note that this should be done for master after @tonyespy finishes #552.

@jpwhitemn note that this issue was just for updating the versions of the services we ship in the snap, I have no idea how to actually update the java code I'll leave that for Brandon


fix: fix all golangci-lint

Hi i try to add some improvement for maintaining project,
This PR try to fix golangci-lint error

[x] fix golangci-lint error
[x] add workflow to check that for any PR

Thanks!


hidden balance mode

Describe your feature request
Have a setting for hidden balance mode where wallet balances are not displayed in the app
What problem does this feature solve? [optional]
adds privacy when making a payment request
Additional context [optional]
monero gui wallet has this feature fyi

Will add this to our feature queue.
If anyone within the community would like to try their hand at adding this feature we would be open to it.
Would largely be cosmetic and utilize functionality already present in the app.


pull data from Bugzilla

This is totally a wishlist item.
we have an internal Bugzilla instance, it's even linked into other bug systems (big company)
There is an upcoming REST API to Bugzilla, but in the meantime there's the old XMLRPC one ( https://www.bugzilla.org/docs/4.4/en/html/api/Bugzilla/WebService/Server/XMLRPC.html ).
Through that, it should be possible to search for bugs on a particular product and extract who's filing and commenting on them.

Hi Stewart! This is an awesome idea.
My main thoughts lie in whether octohat should stay just github-related, or if it should be expanded to allow for other types of source control systems. If that's the case, do you think it would be wise to say have a set flag to say "github" or "bugzilla" with a sufficiently defined identifier for these types?
e.g. github -> (user)/(repo) -> https://api.github.com/repos/(input)
bugzilla -> ??
The less human input required the better, but I'm unsure what the requirements for uniquely identifying a bugzilla repo is.
What are your thoughts on this?

It may be good if it just has plugins for different systems, so people can choose as many / as few as they like, depending on needs.
For uniquely identifying a bugzilla repo, it's basically a URL to the bugzilla instance and then you'll want to specify query parameters (so that you only pull bugs that are related to your project - for example, our bugzilla instance contains bugs for pretty much everything the Linux Technology Center touches... which is a LOT).

Cheers, I'll look into getting a prototype working for bugzilla data

I'm going to close this issue against the github project and refer to the labhr/labhr.github.io#1 issue above for further information.


Improve editor layout dialog with input context, window sizing based on editor scale

Changes:

Enabled ItemList auto_height to avoid LineEdit overlapping.
Added Label to clarify selection.
Added placeholder_text for LineEdit to clarify input.
Included editor_scale to multiply window size with Editor scaling.

Before:

After:

Thanks!


CakePHP 5: Removal of CakePHP <= 3 ones

CakePHP 5 is coming closer
With this I urge everyone that has plugins on that list - or uses them and wants to support them - to upgrade them to CakePHP 4+ now.
With the release of 5, all non 4+ ones will be removed from master list.
We might store them in a legacy sheet or alike.
We want to promote awesomeness, and that requires at least a basic maintance on those, to make sure they can be used by current CakePHP developers and apps.
Thank you!

Move them to a legacy page. They are still useful for those on older versions.

No, but I urge all maintainers or users to already start due diligence on those plugins if possible.
The eco system is a bit less active lately, it seems.

I'm actually in a weird holding pattern on some of my plugins that I'm adding PHP 8 support to. I could end up doing back-to-back major version releases if I support PHP 8, then another to handle changes in cake 5.

Thats usually the best approach. At this point 7.2...8.1 is recommended for Cake4, while Cake5 is 8.0+ anyways.
I personally already go 7.3+ for now with Cake4.2+, and with Cake4.4 even 7.4+ as well.

we can keep 3.x until end of life it , then moving to 3.x branch to archive

3.x | 4.x | 5.x | plugin  - plugin for ...
3.x | 4.x | 5.x | plugin  - plugin for ...
3.x | 4.x | plugin  - plugin for ...
~3.x | plugin  - plugin for ...~

No, I would prefer if we have only one major behind on Master. Bad enough as it is :)

I pushed master to https://github.com/FriendsOfCake/awesome-cakephp/tree/cake3 now and will remove all non Cake4+ plugins/resources now

https://github.com/FriendsOfCake/awesome-cakephp/pull/419


Add option to justify text with :class:MarkupText

Changelog / Overview

A new parameter justify is added to :class:MarkupText. It can be used to justify a paragraph of text passed.

Motivation
Add's option to justify text.
Explanation for Changes
This was implemented in https://github.com/ManimCommunity/ManimPango/pull/40. Pango provides an API to do so and this allows MarkupText to Justify a paragraph of text/
from manim import *
class JustifyText(Scene):
    def construct(self):
        ipsum_text = (
            "Lorem ipsum dolor sit amet, consectetur adipiscing elit."
            "Praesent feugiat metus sit amet iaculis pulvinar. Nulla posuere "
            "quam a ex aliquam, eleifend consectetur tellus viverra. Aliquam "
            "fermentum interdum justo, nec rutrum elit pretium ac. Nam quis "
            "leo pulvinar, dignissim est at, venenatis nisi. Quisque mattis "
            "dolor ut euismod hendrerit. Nullam eu ante sollicitudin, commodo "
            "risus a, vehicula odio. Nam urna tortor, aliquam a nibh eu, commodo "
            "imperdiet arcu. Donec tincidunt commodo enim a tincidunt."
        )
        justified = MarkupText(ipsum_text, justify=True).scale(0.4)
        not_justified = MarkupText(ipsum_text, justify=False).scale(0.4)
        just_title = Title("Justified")
        njust_title = Title("Not Justified")
        self.add(njust_title, not_justified)
        self.play(
            Transform(
                not_justified,
                justified,
            ),
            Transform(
                njust_title,
                just_title,
            ),
            run_time=2,
        )
        self.wait(1)

https://user-images.githubusercontent.com/49693820/122028698-e5b74780-cde9-11eb-8db4-50bc294b7d5d.mp4
Documentation Reference

Testing Status
Works locally.
Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[x] My new functions/classes either have a docstring or are private
[x] My new functions/classes have tests added and (optional) examples in the docs
[ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

Just a small comment, but otherwise it looks good to me!
Really useful feature.


No messages being published

I am facing an issue where I am unable to get any messages from ros2 topic echo /visual_slam/tracking/odometry. (Or any other /visual_slam/tracking/* topics). This is strange because I am able to see publisher count = 1 but no messages are actually being published. I would appreciate any help or insights on how to resolve this issue so that I can get messages to be properly published.
Background
I am using Jetson Orin Nano 8gb Developer Kit. I have followed this guide step by step and have flashed the provided custom SD card for Jetson Orin Nano. I am using Intel Realsense D455, which is a compatible model, and I can see the camera images when I run realsense-viewer. I have also updated the firmware to 05.15.01 which meets the criteria "firmware of the RealSense camera is 5.14.0 or newer." (also tried downgrading)
Output of ros2 launch isaac_ros_visual_slam isaac_ros_visual_slam_realsense.launch.py:
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [component_container-1]: process started with pid [78195]
[INFO] [realsense2_camera_node-2]: process started with pid [78197]
[component_container-1] [INFO] [1708984640.099437692] [visual_slam_launch_container]: Load Library: /workspaces/isaac_ros-dev/install/isaac_ros_visual_slam/lib/libvisual_slam_node.so
[realsense2_camera_node-2] [INFO] [1708984640.478058622] [camera.camera]: RealSense ROS v4.51.1
[realsense2_camera_node-2] [INFO] [1708984640.478491693] [camera.camera]: Built with LibRealSense v2.53.1
[realsense2_camera_node-2] [INFO] [1708984640.478531055] [camera.camera]: Running with LibRealSense v2.53.1
[component_container-1] [INFO] [1708984640.502260655] [visual_slam_launch_container]: Found class: rclcpp_components::NodeFactoryTemplate<isaac_ros::visual_slam::VisualSlamNode>
[component_container-1] [INFO] [1708984640.511121286] [visual_slam_launch_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<isaac_ros::visual_slam::VisualSlamNode>
[component_container-1] [INFO] [1708984640.689291824] [visual_slam_node]: Elbrus version: 10.5
[realsense2_camera_node-2] [INFO] [1708984640.691532511] [camera.camera]: Device with serial number<PHONE_NUMBER>30 was found.
[realsense2_camera_node-2]
[realsense2_camera_node-2] [INFO] [1708984640.699417427] [camera.camera]: Device with physical ID /sys/devices/platform/3610000.xhci/usb1/1-2/1-2.3/1-2.3:1.0/video4linux/video0 was found.
[realsense2_camera_node-2] [INFO] [1708984640.701959884] [camera.camera]: Device with name Intel RealSense D455 was found.
[realsense2_camera_node-2] [INFO] [1708984640.704450020] [camera.camera]: Device with port number 1-2.3 was found.
[realsense2_camera_node-2] [INFO] [1708984640.707527920] [camera.camera]: Device USB type: 2.1
[realsense2_camera_node-2] [WARN] [1708984640.709148168] [camera.camera]: Device<PHONE_NUMBER>30 is connected using a 2.1 port. Reduced performance is expected.
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/visual_slam_node' in container '/visual_slam_launch_container'
[realsense2_camera_node-2] [INFO] [1708984640.762462647] [camera.camera]: getParameters...
[realsense2_camera_node-2] [INFO] [1708984640.768639599] [camera.camera]: JSON file is not provided
[realsense2_camera_node-2] [INFO] [1708984640.768722962] [camera.camera]: Device Name: Intel RealSense D455
[realsense2_camera_node-2] [INFO] [1708984640.768748947] [camera.camera]: Device Serial No:<PHONE_NUMBER>30
[realsense2_camera_node-2] [INFO] [1708984640.768771412] [camera.camera]: Device physical port: /sys/devices/platform/3610000.xhci/usb1/1-2/1-2.3/1-2.3:1.0/video4linux/video0
[realsense2_camera_node-2] [INFO] [1708984640.768789589] [camera.camera]: Device FW version: <IP_ADDRESS>
[realsense2_camera_node-2] [INFO] [1708984640.768806645] [camera.camera]: Device Product ID: 0x0B5C
[realsense2_camera_node-2] [INFO] [1708984640.768819926] [camera.camera]: Sync Mode: Off
[realsense2_camera_node-2] [ERROR] [1708984640.928006150] [camera.camera]: Given value, 640x360x90 is invalid. Set ROS param back to: 640x480x15
[realsense2_camera_node-2] [WARN] [1708984640.946156738] [camera.camera]: Could not set param: rgb_camera.power_line_frequency with 3 Range: [0, 2]: parameter 'rgb_camera.power_line_frequency' could not be set: Parameter {rgb_camera.power_line_frequency} doesn't comply with integer range.
[realsense2_camera_node-2] [INFO] [1708984641.062888577] [camera.camera]: Stopping Sensor: Stereo Module
[realsense2_camera_node-2] [INFO] [1708984641.121916120] [camera.camera]: Starting Sensor: Stereo Module
[realsense2_camera_node-2] [INFO] [1708984641.310861468] [camera.camera]: Open profile: stream_type: Infra(1), Format: Y8, Width: 640, Height: 480, FPS: 15
[realsense2_camera_node-2] [INFO] [1708984641.311643864] [camera.camera]: Stopping Sensor: Motion Module
[realsense2_camera_node-2] [INFO] [1708984641.348215515] [camera.camera]: Starting Sensor: Motion Module
[realsense2_camera_node-2] [INFO] [1708984641.396753089] [camera.camera]: Open profile: stream_type: Accel(0)Format: MOTION_XYZ32F, FPS: 63
[realsense2_camera_node-2] [INFO] [1708984641.400138968] [camera.camera]: Open profile: stream_type: Gyro(0)Format: MOTION_XYZ32F, FPS: 200
[realsense2_camera_node-2] [INFO] [1708984641.416299695] [camera.camera]: RealSense Node Is Up!
[realsense2_camera_node-2] [WARN] [1708984641.512268630] [camera.camera]:

(The only red flag I see is Could not set param: rgb_camera.power_line_frequency with 3 Range: [0, 2]: parameter 'rgb_camera.power_line_frequency' could not be set: Parameter {rgb_camera.power_line_frequency} doesn't comply with integer range., but this is probably not directly related to the odometry issue)
Output of ros2 wtf --report:
topic [type]            : /visual_slam/tracking/odometry [nav_msgs/msg/Odometry]
publisher node          : visual_slam_node
subscriber node         : _ros2cli_13486
compatibility status    : OK
...
topic               : /visual_slam/tracking/odometry
publisher count     : 1
subscriber count    : 0
topic               : /visual_slam/tracking/slam_path
publisher count     : 1
subscriber count    : 0
...

Output of ros2 node list
/camera/camera
/launch_ros_78184
/transform_listener_impl_aaaacb182750
/visual_slam_launch_container
/visual_slam_node

Additional information:

I have tried stopping and starting the daemon via ros2 daemon stop && ros2 daemon start
I tried recreating the Docker container (exiting and running isaac_ros_container again)
Power-mode is set to 15W for the Jetson
I can read from /camera/* topics. The average rate is a little slow: ros2 topic hz /camera/infra1/image_rect_raw --window 20 average rate: 12.309 min: 0.055s max: 0.200s std dev: 0.03933s window: 13, but this shouldn't be the core issue
I've also tried removing /build /log /install and tried colcon build --symlink-install but the issue persists.

I've also tried removing /build /log /install and tried colcon build --symlink-install but the issue persists.
Another potential red flag is the outdated Realsense firmware. There is a message in realsense-viewer that says "Intel RealSense D455, Current Version: <IP_ADDRESS>, Recommended Version: <IP_ADDRESS>". However, whenever I try to install an update, it crashes mid-installation.
I ran ros2 run tf2_tools view_frames but the frames look a little odd:
frames_2024-02-26_12.34.47.pdf

Hi @brian7989 ,
I believe we're already working with you on this thread in the Isaac ROS Forum.
To reiterate the main point of that reply here, it looks like you're using an outdated tutorial. Please reference the official Isaac ROS Docs Site to get the latest information and quickstart guides.

Yes I'll continue on the ROS forum. Thanks.


Handle just_pressed/just_released in the FixedUpdate schedule

Context
Fixes https://github.com/Leafwing-Studios/leafwing-input-manager/issues/252
(see description of the issue in https://github.com/bevyengine/bevy/issues/6183)
It would also fix https://github.com/cBournhonesque/lightyear/issues/349
(I did a write-up here: https://hackmd.io/_TGuaUTnRBeuisvUMr0QoQ?both)
i.e. that we cannot reliably use action.just_pressed() in FixedUpdate systems because:

in some cases,FixedUpdate runs 2 times in the same frame, which means that they would both had just_pressed() = True which is misleading

situation 1 (S1): F - FU - FU - F

in some cases, FixedUpdate runs 0 times in one frame, which means that just_pressed becomes pressed and the input is never seen by the FixedUpdate system.

situation 2 (S2): F - F - FU - F
Glossary:

- `F` = `Frame start`
- `FU` = `FixedUpdate start`

Solution
Outline
This is a an initial version that can probably be improved, but it solves the issues with fixed timesteps.
We will have the same approach as the Time API: this is how it works: https://github.com/bevyengine/bevy/blob/main/crates/bevy_time/src/fixed.rs#L237
There are 3 resources Time<Fixed>, Time<Virtual>, Time<()>.
The resource Time<()> is set to either Time<Fixed> and Time<Virtual> depending on the schedule we are running in.
Here we do the same thing; the ActionData has 3 fields to represent state:

update_state
state
fixed_update_state

We will update update_state in Update and fixed_update_state in FixedUpdate. The user-facing interface will be state which switches between update_state and fixed_update_state depending on the schedule; but maybe we could also expose update_state and fixed_update_state (similarly to how Time<Virtual> and Time<Res> are exposed)
We still keep state so that:

all the current code is untouched (we will just swap state with either update_state or fixed_update_state depending on which schedule we are running
the client-facing API is untouched; the user should just access state and they will access the correct data depending on whether they are running in FixedUpdate or Update

System order
So the order is

Schedule = PreUpdate

tick the ActionState
apply the input events to state. (new button presses, etc.)
apply ManualControl

before Schedule = RunFixedMainLoop (we use this because we don't want to run the systems once per FixedUpdate; there could be multiple FixedUpdate runs in a frame)

set update_state = state to apply the changes; then do state = fixed_update_state to load the new state
apply the input events to state (the input events need to be applied event because we essentially maintain 2 independent ActionState, one in Update and one in FixedUpdate)

Schedule = FixedPreUpdate

apply release_on_disable
apply UI updates (i think this should run once per FixedUpdate because the button could be pressed in FixedUpdate? I might have misunderstood what the ui feature does)

Schedule = FixedPostUpdate

tick the ActionState (we want to run this every FixedUpdate to go from just_pressed to pressed and have better timing information)

after Schedule = RunFixedMainLoop

set fixed_update_state = state to save the changes, and do state = update_state to load the new state

I think having the fields inside ActionData instead of having 3 separate ActionData is a feature, not a bug:
some fields need to be updated only once (value, axis_pair), and should even be shared between the two schedules (consumed).
The timing information is also shared, but only updated in PreUpdate because Time<Real> is only updated in pre-updated. I don't think it's worth worrying about handling timing information separately in Time<Fixed> because:

timing information also wasn't used in FixedUpdate before, so this PR is still a strict improvement
we might need timing information from winit events to compute them accurately anyway

Test
Added 2 unit tests to show that the problems 1 and 2 described above are solved.

This is quite straightforward and the test cases are confidence-inspiring. Definitely reduces footgunnyness, but I do also think that doing input in fixed update is inadvisable in the first place. I dont think that means it should explode on people who do that, but I do wonder if the copying around of structs has a performance impact that everyone will have to pay even if they only do input in update.

I agree that there is a additional cost, so maybe we could gate this change behind a feature flag.
But in general there are a lot of cases where handling inputs in fixed-update is necessary; anything related to the simulation or to networking generally has to run in FixedUpdate (physics, simulation, etc.).
In my usecase, I maintain a networking library that has rollback networking; for rollback to work properly most of the simulation must happen in FixedUpdate, so users will have a lot of input-handling systems inside FixedUpdate.

Are there any cases where you'd want input both in fixed update and normal update? If you're doing rollback netcode sim stuff you wouldnt want any input in normal update, right? Maybe the right approach is to just switch between fixed/notfixed entirely? In any case I think this can be merged as is, without feature gates. Gating would have to be motivated by benchmarks that show the additional complexity is warranted.

Are there any cases where you'd want input both in fixed update and normal update? If you're doing rollback netcode sim stuff you wouldnt want any input in normal update, right? Maybe the right approach is to just switch between fixed/notfixed entirely? In any case I think this can be merged as is, without feature gates. Gating would have to be motivated by benchmarks that show the additional complexity is warranted.

In most cases it would probably be: player inputs (move, fire weapons, etc.) in FixedUpdate, and admin inputs (UI, settings, chat) in Update.
So yeah maybe it's worth having a Mode enum where an input would be either in FixedUpdate or Update.
But it's probable that in some cases it would be useful to have inputs work in both FixedUpdate / Update, maybe we could provide 3 modes: Update, FixedUpdate and Both. Then it's a matter of ergonomics or UX whether we want to expose this kind of complexity to the user or hide it by always using Both. Maybe @alice-i-cecile has an opinion here

Needs formatting now before I can merge 😄


Add optionnal initContainer to fix sysctl config

This request will add an optionnal flag to helm chart values.yaml, that let people add an initContainer to fix sysctl missing "net.ipv4.ip_forward=1" issue. (like https://github.com/Place1/wg-access-server/issues/140)
Here is an exrtract of the documentation I added to values/yaml :

sysctlInitContainer flag adds an initContainer named "init-sysctl" to wg-access-server deployment.
The goal is to set the sysctl net.ipv4.ip_forward=1 to allow packet routing through node.
This initContainer needs to run as privileged, but this is only limited to the initContainer run time, the main container will remain unprivileged as expected.
Use case :
DNS is functionning properly through VPN but does not work for standard traffic.
NB : If you have no problem with wireguard traffic, you should not enable this initContainer

I'd love to see this merged - has bit me more than once at this point. I went ahead and published my own chart with these changes for internal use, but I'd prefer to use the upstream one long term.


APPCRASH

I choose the syntax "Cinema4d Python API" and get an error message (sorry, the system in Russian):
http://i.imgur.com/oMT11n3.jpg
Windows 7 64, Sublime Text 3 Build 3126

it's not working as good as it should anyway. i'll try to update it one asap but for now, let's call it deprecated.

Well, I'll wait for the update.

hello,
I will wait, too.
Work fine on sublime text2.
https://www.sublimetext.com/2
I did recording video ago few days. and introduced your api.
http://oinon.net/blog/how-to-set-up-editor-for-cinema-4d-python/
Thank you for share.

I understood what was happening. A string with constants (for example, AACTION_OP_LESSTHAN, etc.) is too long and therefore the program fails. I truncated this line to five constants and it immediately earned.

nice oinon. I need to update this package to R18...

i've updated the package to the R18 documentation. But i didn't truncated the constants line.


Allow FreeBSD to correctly detect number of CPUs on host.

Use the same scheme as Darwin - `sysctl hw.ncpu' instead of nproc, which doesn't exist in FreeBSD

What's the value of $OSTYPE for FreeBSD?

Nevermind, it's freebsd.


Conversion of pytorch-image-models to image-models with IVY

Is your feature request related to a problem? Please describe.
Hi, As we know when latest papers come from different frameworks, we are bound to certain frameworks such a Torch, Tensofrlow, MXNet, JAX, Numpy etc and although the papers are great, A pytorch user would have to go through multiple loops to reproduce the paper and make the computational graph identical.
Describe the solution you'd like
I believe if we use IVY, a Unifying framework to convert pytorch-image-models, we could have this library create a broader impact. IVY supports PyTorch, TensorFlow, MXNet, JAX, and NumPy. IVY uses automatic code conversions between frameworks. This framework is being created by Danile Lenton and Ronnie Clark and many others and has now become a community effort.
I believe with community effort with everybody writing code for a set model family, pytorch-image-models can reach out to more researches and bolster research even more.
Additional context
Add any other context or screenshots about the feature request here.

@Geeks-Sid moving to discussion as I try to keep the issues focused on bugs and concrete feature req


[Bug] ERROR flutter_rust_bridge_codegen] fatal: missing pubspec.lock 1.49.2

Describe the bug
Try to generate dart file
flutter_rust_bridge_codegen
--rust-input "src/domain/checkin/example.rs"
--dart-output "lib/example.dart"
ERROR flutter_rust_bridge_codegen] fatal: missing pubspec.lock in /private/tmp/flutter_rust_bridge_codegen-20221117-12286-e8c4gf/flutter_rust_bridge-1.49.2/frb_codegen
Codegen logs with RUST_LOG=debug environment variable
[2022-11-19T02:26:57Z DEBUG flutter_rust_bridge_codegen] configs=[Opts { rust_input_path: "/Users/XXX/XXX/XXXXXX/src/domain/checkin/checkin_command.rs", dart_output_path: "/Users/XXX/XXX/XXXXXX/lib/checkin_command.dart", dart_decl_output_path: None, c_output_path: ["/var/folders/sn/n97lrj412yl6wx_6744wfptr0000gn/T/.tmp5heF6Q.h"], rust_crate_dir: "/Users/XXX/XXX/XXXXXX", rust_output_path: "/Users/XXX/XXX/XXXXXX/src/domain/checkin/bridge_generated.rs", class_name: "XXXXXX", dart_format_line_length: 80, skip_add_mod_to_lib: false, llvm_path: ["/opt/homebrew/opt/llvm", "/usr/local/opt/llvm", "/usr/lib/llvm-9", "/usr/lib/llvm-10", "/usr/lib/llvm-11", "/usr/lib/llvm-12", "/usr/lib/llvm-13", "/usr/lib/llvm-14", "/usr/lib/", "/usr/lib64/", "C:/Program Files/llvm", "C:/msys64/mingw64"], llvm_compiler_opts: "", manifest_path: "/Users/XXX/XXX/XXXXXX/Cargo.toml", dart_root: None, build_runner: true, block_index: BlockIndex(0), skip_deps_check: false, wasm_enabled: false, inline_rust: false }]
[2022-11-19T02:26:58Z DEBUG lib_flutter_rust_bridge_codegen::tools] Guessing toolchain the runner is run into
[2022-11-19T02:26:58Z ERROR flutter_rust_bridge_codegen] fatal: missing pubspec.lock in /private/tmp/flutter_rust_bridge_codegen-20221117-12286-e8c4gf/flutter_rust_bridge-1.49.2/frb_codegen

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Version of ffigen
No response
Additional context
No response

looks like you do not have pubspec.lock. e.g. not pub-get yet


markdown: Nested list items marked as markdownCodeBlock

With the following in a markdown file
* foo
    * bar
        * baz

, vim will not render the * baz item as a list item. Using the vim-hilinks plugin I have tracked the problem down to the * baz item being detected as a markdownCodeBlock.
~$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov  2 2015 19:35:17)
MacOS X (unix) version
Included patches: 1-903
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +farsi           +mouse_netterm   +syntax
+arabic          +file_in_path    +mouse_sgr       +tag_binary
+autocmd         +find_in_path    -mouse_sysmouse  +tag_old_static
-balloon_eval    +float           +mouse_urxvt     -tag_any_white
-browse          +folding         +mouse_xterm     -tcl
++builtin_terms  -footer          +multi_byte      +terminfo
+byte_offset     +fork()          +multi_lang      +termresponse
+cindent         -gettext         -mzscheme        +textobjects
-clientserver    -hangul_input    +netbeans_intg   +title
+clipboard       +iconv           +path_extra      -toolbar
+cmdline_compl   +insert_expand   +perl            +user_commands
+cmdline_hist    +jumplist        +persistent_undo +vertsplit
+cmdline_info    +keymap          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       +python          +viminfo
+cscope          +lispindent      -python3         +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      +lua             +rightleft       +windows
+diff            +menu            +ruby            +writebackup
+digraphs        +mksession       +scrollbind      -X11
-dnd             +modify_fname    +signs           -xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      -sniff           -xsmp
+eval            +mouse_dec       +startuptime     -xterm_clipboard
+ex_extra        -mouse_gpm       +statusline      -xterm_save
+extra_search    -mouse_jsbterm   -sun_workshop    -xpm
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: /usr/bin/clang -c -I. -Iproto -DHAVE_CONFIG_H   -F/usr/local/Frameworks -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -DMACOS_X_UNIX  -Os -w -pipe -march=native -mmacosx-version-min=10.11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: /usr/bin/clang   -L. -L/usr/local/lib -L/usr/local/lib -F/usr/local/Frameworks -Wl,-headerpad_max_install_names -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -o vim        -lm  -lncurses -liconv -framework Cocoa  -L/usr/local/lib -llua -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE -lperl -F/usr/local/Cellar/python/2.7.10_2/Frameworks -framework Python   -lruby.2.0.0 -lobjc

Please report to the maintainer of the syntax file. His contact address is given in the syntax file. See also Contributing.md

This looks like a slightly different version of tpope/vim-markdown#81.

this needs to be discussed with the syntax file maintainer. closing.


Retry query jobs and use info-level logging for job link, etc

resolves #696

Description

Improve productivity, provide the Bigquery job's link just after it's submitted. Make it easier to find the executed queries
Example of logs proposal

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

I have just signed the CLA, how can I retrigger the workflow?

Hi @dbeatty10 , thanks for reminding me

I think logging the job-link at the debug-level is reasonable.

This PR doesn't try to implement a retry feature, it just shows the count of retries if profiles.yml have job_retries configuration https://docs.getdbt.com/docs/core/connect-data-platform/bigquery-setup#job_retries

But the PR of @github-christophe-oudar (https://github.com/dbt-labs/dbt-bigquery/pull/697) suited my need. So I will close this PR
Thanks all


Setup Github Actions to allow merging only when the Scenarios have passed

In Continuous Delivery every time we merge to main we are sure that all tests (unit, integration, feature, end2end) have passed.
Since we are not deploying our Application anywhere yet, it is enough to use Github Actions for reporting the status of all tests and preventing merging to main branches that have broken functionality.
Requirements:

A Github action that will report the results of the unit integration and funtional tests. (currently included in the folders PracticeWebApp.Tests and PracticeWebApp.FuncTest)
One cannot merge their branch unless all tests are green.

I think that in order for me to be able to take a look at this, I should be lifted from collaborator to owner. Otherwise, the "settings" tab is not isible

I tried to elevate you to an admin but I could not. I have requested a repo transfer so that you will be the owner and not I.

Not sure if the repo transfer took place. Unless I should do something?


SOAP gateway

Not much of an issue, more of an announcement.
I recently had to write a new gateway plugin for a gateway that uses SOAP with WSDL.  Previously I had worked on the First Data SOAP gateway but that ended up having to be done manually because the WSDL file emitted by the gateway wasn't in fact valid WSDL and the PHP native SOAP client wouldn't parse it.
So I went looking for another gateway to use as an example and couldn't find one.  There was the CyberSource SOAP gateway but it was broken to the extent of not even compiling (I'll have to submit some PRs at some point for that one) and didn't actually send requests.  I realise that the PHP native SOAP client is not particularly great but there should be at least one working example of a gateway plugin using that SOAP client in the absence of another better one.
So I built the Allied Wallet SOAP gateway using the PHP native SOAP client and it works (I have a demonstrator script which makes actual transactions on the gateway and they appear on the merchant dashboard).  It's available for use/inspection/forking/copy-and-paste here: https://github.com/delatbabel/omnipay-alliedwallet
Also it has tests that make use of phpUnit's ability to mock a SOAP client using the getMockFromWsdl() method. These provide 100% test coverage of the gateway methods without having to make actual SOAP calls to the gateway.
There were a few challenges -- mostly in having to over-ride the AbstractGateway and AbstractRequest constructor to allow passing in a SoapClient object so that the client could be mocked by the test cases.  Using a mock httpClient and httpRequest isn't sufficient for SOAP because it uses PHP internal methods that don't allow interception by guzzle, and unless guzzlehttp has a SOAP client along with it we can't mock a SOAP client by mocking methods that it doesn't call.  So I guess a possible v3.0 change is to add this SoapClient or an interface that defines it into the base constructors and having it built as required.
Another question is whether we do in fact need an exemplar, or set of exemplar gateway plugins for use by gateway plugin builders to use as base examples -- one for REST, one for SOAP, etc?

If we use autowiring in v3, it shouldn't matter which classes you need in the Abstract class.
Most of the time, the default PHP SoapClient is used for SOAP, right? So don't think we need to create an interface for that then.

Most of the time, the default PHP SoapClient is used for SOAP, right?

Unfortunately I don't think that's the case.  The default PHP SOAP client isn't very good and quite a few of the gateways that do SOAP or SOAP-like things have comments in the code in a few places saying things like "the native PHP SOAP client doesn't work for this case so we have to do X instead".
https://github.com/thephpleague/omnipay-firstdata/blob/master/src/WebserviceGateway.php#L22 as a case in point.  (follow the trail to the PHP bug -- the core issue is that SOAP allows overloaded functions or class methods, PHP SOAP tries to implement SOAP functions as PHP class methods and so whenever a WSDL file defines overloaded functions the PHP native SOAP client b0rks).
There are other SOAP implementations out there which work for this case and other cases -- besoap is one particular implementation.
I suspect that an interface and then an adapter or wrapper class around PHP's native SOAP implementation, as the default implementation, is what is going to be needed.  In addition an interface that has an implementation that is stubbable or mockable will be required for unit testing.


2i2c-us: Reduce size of filestore for use as home directory

We did a couple cleanups (AUP and Neurohackademy) that have brought usage down now to 2.4T only. This saves us approximately 600$ a month in cloud usage.

Sigh, it looks like we can't actually scale these down at all:
https://cloud.google.com/filestore/docs/scale#differences_in_scaling_behavior_by_service_tier
Running this gives me:
<EMAIL_ADDRESS>╷
│ Error: Error updating Instance "projects/two-eye-two-see/locations/us-central1-b/instances/pilot-hubs-homedirs": googleapi: Error 400: capacity for file share "homes" may only be increased.
│
│   with google_filestore_instance.homedirs[0],
│   on storage.tf line 1, in resource "google_filestore_instance" "homedirs":
│    1: resource "google_filestore_instance" "homedirs" {
│
╵
Releasing state lock. This may take a few moments...

The way out is to switch to 'zonal' (https://cloud.google.com/filestore/docs/service-tiers#zonal_with_capacity_bands) but that's more expensive (0.25 / GB vs 0.16 / GB).


Unstage selected ranges

Part of feature #6516. Since we allow users to stage selected lines, it would be better if users can unstage changes they don't want anymore.
This PR only contains the code change, we need to involve Localization team to handle nls.localize('unstageSelectedLines', "Unstage Selected Lines") as well, right? @isidorn

@rebornix no worries about the localization, as long as the string is under nls calls the localization team will automatically pick it up 1 week before our every release.
Thanks for the PR!

Awesome, thanks! 🍻

Great job - thanks!


stop loader on assets without prices

Fixes #1384

Changes proposed in this PR:

stop loader spinner on assets without prices

@jamiehewitt15 I just pushed some changes to address some of the concern. Now, you won't see the "No price set" label while loading. Hopefully I didn't messed up something else 😬 please take some time to test this PR carefully as it touches some critical components, and it might required some more work.

in general I would suggest taking a step back from this as by trying to fix things this PR makes some things worse, like more than doubling the time it takes before users see assets.
Also can't see how plastering loading spinners everywhere is any better than before, if you have 3 loading spinners in this small space, then something is wrong conceptionally, this is what I get with this PR:

Often it is better to show nothing in place of the thing you are fetching, and just make sure that the empty space takes same space as the filled element. Which could be used for the price alone, just like we have right now on v4 on all AssetTeaser. More ideas are on #1378
So would suggest on #1378 communicate visually first those states

AssetTeaser without price loaded
AssetDetail without price loaded
AssetDetail with spot price loaded
AssetDetail with final consume price loaded

And then start implementing which in turn should fix multiple issues instead of just adding more spinners

Better price loading UX #1378

Agree, we should closed this issue and continue in #1378


Test changes

Fixes #410

Don't use kismatic dashboard command when testing dashboard access
Move some tests into the "skunkworks" install test

LGTM. I have a feeling that keeping track of and organizing those "sub" tests is going to be a pain point, but we'll see when we get there.


Added class override for most parts of calendar

Class-level customization
Following #29, I've got another approach to customization, which is not limited only to colors, but full class customization. Example:

Added props:

calendarContainerClassName
baseDayClassName
disabledClassName
todayClassName
selectedClassName
selectedStartClassName
selectedFullClassName
selectedEndClassName
rangeClassName
btnClassName
btnActiveClassName
btnDisabledClassName
btnFullRoundClassName
btnContainerClassName

Is there a way to change the color fo this element?

Published this package into this:
https://www.npmjs.com/package/gustavolbs-react-tailwindcss-datepicker

can we have this one merged?


OpenShift timing out on login

Quite regularly GitHub Actions' connection to OpenShift silver is failing.  Being listed as unavailable.  If this keeps happening, then a retry can't hurt.
E.g.
error: dial tcp <IP_ADDRESS>:6443: i/o timeout - verify you have provided the correct host and port and that the server is currently running.
Error: Process completed with exit code 1.

Duplicate of https://github.com/bcgov/nr-quickstart-helpers/issues/65


registration

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/108569
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.0 -m "<description of version>" 5cc4f0ffe2ac565bb6684142969fd93c4cfb16e8
git push origin v1.0.0

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/108569
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.0 -m "<description of version>" 41f967fa14de75a5d62adacc4f086c3351e5a406
git push origin v1.0.0

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/109070
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.1 -m "<description of version>" 3b2fbe5dc79365d3719acbaf3e77970448ab7130
git push origin v1.0.1

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/109342
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.2 -m "<description of version>" c22300fd813a42d18e85d3f3423f8c4120471340
git push origin v1.0.2

@JuliaRegistrator register
Release notes:

add rotation according to global axis

Registration pull request created: JuliaRegistries/General/109400
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.1.0 -m "<description of version>" aba05b0eeb7f26fc64c50884c999055060e5cbe8
git push origin v1.1.0

@JuliaRegistrator register
Release notes:

update API (move opc to args, add random color feature), usages are different from v1

Registration pull request created: JuliaRegistries/General/110056
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v2.0.0 -m "<description of version>" a3969d11fbee03074e18d0478e5592d9cb8f081f
git push origin v2.0.0

@JuliaRegistrator register
Release notes:

add customized length for ref axes

Registration pull request created: JuliaRegistries/General/111006
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v2.1.0 -m "<description of version>" f6ee561e18e6e3e4025ba4c7f1e693f8026ae8d9
git push origin v2.1.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/111080
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v2.1.1 -m "<description of version>" 92d2009af6c813302378d353400c1e9f20f189e0
git push origin v2.1.1

@JuliaRegistrator register
Release notes:

set az/el view angle

Registration pull request created: JuliaRegistries/General/111204
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v2.2.0 -m "<description of version>" 3af8b5bf6d44f7631c66ec86d2066fe0b571cb92
git push origin v2.2.0

@JuliaRegistrator register
Release notes:

fix add_arrows!

Registration pull request created: JuliaRegistries/General/111268
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v2.2.1 -m "<description of version>" b3e5a4c513f418cdc4ed502e0e5efbd13608f93f
git push origin v2.2.1


⚠ AGEG website (redirect) has degraded performance

In 1a4731d, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 4776 ms

Resolved: AGEG website (redirect) performance has improved in 775174f.


Unable to run example code

Apologies for posting this here but could not find other forms available for this discussion. I'm unable to run the example code. I get an error "No implicits found for parameter schema: Schema.Record[Person]" for the defineTable() method.  I've copied the code example as shown.  Does this mean that zio.schema isnt generating the appropriate code for me?   Thank you for your help
import zio.schema.Schema
import zio.sql.postgresql.PostgresJdbcModule

object playground extends PostgresJdbcModule {

  final case class Person(name: String, age: Int)
  implicit val schema: Schema[Person] = DeriveSchema.gen[Person]

  val person = defineTable[Person]. // error is here

}

hi @davidleacock try to remove Schema[Person[ type and let compiler infer value for you.
So:
  implicit val schema = DeriveSchema.gen[Person]

Let me know if that helps

Thank you for the response.  Sadly that doesn't resolve it. I actually added the type an an attempt to fix it before.  Also followed the zio-schema docs to try and contruct the schema differently and no luck.
Here are my dependencies if this helps. I've tried older versions of zio-sql and included schema as well
lazy val zioVersion = "2.0.0"
libraryDependencies ++= Seq(
  "dev.zio" %% "zio" % zioVersion,
  "dev.zio" %% "zio-test" % zioVersion,
  "io.d11" %% "zhttp" % "2.0.0-RC10",
  "dev.zio" %% "zio-test-sbt" % zioVersion,
  "dev.zio" %% "zio-json" % "0.3.0-RC8",
  "dev.zio" %% "zio-streams" % zioVersion,
  "dev.zio" %% "zio-test-junit" % zioVersion,
  "dev.zio" %% "zio-sql-postgres" % "0.1.2",
//  "dev.zio" %% "zio-schema" % "0.4.8"
)

Thank you for your response. I apologize, this appears to be an issue with IntelliJ.  I'm able to command line compile and access the person table but the error still shows so its a problem with the IDE.  Closing the issue.


GeoIp incorrect for some IPs

I have noticed that my IP address returns incorrect location. It appears to be pulling data for Antioch, CA but I'm in Nashville, TN (near Antioch, TN).  I checked ip2location, maxminddb and a legacy geoip db, and all return the correct location.  When I check using long/lat, it returns the correct location data.  Perhaps it is finding my IP in a local maxminddb that needs to be updated?

I too am having an issue with this.  I am in Rochester, NY and am receiving weather for Rochester, UK.

@drbayer @merced317
The problem is fixed now (I hope). Please check if it works for you.
And thank you for reporting

Yes, this bug was introduced yesterday indeed. It is fixed now, please test. Thank you for reporting!

Looks great now.  Thanks for the continued awesome work!  Love this project. <3


upgrade cython and downgrade numpy

Fixes #34
I still need to add ci/cd for tests with both numpy versions.

@RobPasMue this works on windows for me. Do you have ideas about the ci issue? I'm stuck in meetings all day today


Every time the caret moves via keyboard search() is called

Describe the bug

Make a test applet
Add console.log() to the search function
Use the left and right keys to observe all the logs to the window

The problem here is namely that web services called risk being spammed. Can add a cacher for this but in the applet, but would be useful if we could bypass the need for caching when the caret is only moving left and right.
Expected behavior
If the search field doesn't change content, it likely shouldn't call search again?
Environment (please complete the following information):

OS: Mac
Version: 0.1.4

Additional context
Noticed this while making the translator applet. Google has a limit on the number of calls that you can make.

This is likely caused by this: TextEditCommand.ts#L87
We always set the new text, even if the contents weren't altered. We should add an if statement here to prevent unnecessary updates. The same holds for the selection.
Additionally we may want to add a similar if statement here: LMSession.tsx#L237
To make sure that even if something else causes updates while the text hasn't changed, the search itself is reexecuted.


Add missing semicolons to webxr.eterns.js

As identified by LGTM, #44154 missed some semicolons. This PR explicitly adds the implicitly added semicolons.

Thanks! The missing semicolons shouldn't actually cause any problems, but it'd be better to have them there. :-)

Thanks!

Cherry-picked for 3.2.4.


rubocop-ast release made rubocop 1.6.1 require ruby 2.5.0

rubocop version 1.6.1 has dependency constraint:
rubocop-ast >= 1.2.0, < 2.0
The recent releases of rubocop-ast (1.4.2 and 1.5.0) satisfy these constraints so they introduce a dependency on ruby version >= 2.5.0. This breaks rubocop version 1.6.1 on ruby 2.4.

Expected behavior
It's unexpected that released versions of rubocop would change their ruby version requirements. Should a ruby version bump in rubocop-ast be treated as a major version?
Actual behavior
$ ruby -v
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin19]
$ gem install rubocop -v 1.6.1
Fetching: parser-<IP_ADDRESS>.gem (100%)
Successfully installed parser-<IP_ADDRESS>
Fetching: rubocop-ast-1.5.0.gem (100%)
ERROR:  Error installing rubocop:
	rubocop-ast requires Ruby version >= 2.5.0.

Steps to reproduce the problem
Install rubocop version 1.6.1 when using ruby 2.4.2.
RuboCop version

Should a ruby version bump in rubocop-ast be treated as a major version?

We discussed the subject here for RuboCop https://github.com/rubocop/rubocop/pull/9648, but I guess we didn't consider the impact for rubocop-ast.

Just to be clear - our expectations was that in a case like yours you'd the get the news version of rubocop-ast that's installable on Ruby 2.4. I'm not sure why that's not actually happening.

Sorry you're having issues.
Indeed, it shouldn't be breaking.
This may be a bug in the rubygems you are using that has been fixed? Could you try gem update --system first?
I was able to install rubocop both 1.12.1 and 1.6.1 on Ruby 2.4.10 with:
$ gem update --system
[...]
$ gem install rubocop
Fetching rexml-3.2.5.gem
Fetching unicode-display_width-2.0.0.gem
Fetching ruby-progressbar-1.11.0.gem
Fetching parser-<IP_ADDRESS>.gem
Fetching rubocop-ast-1.4.1.gem
Fetching rubocop-1.12.1.gem
Fetching rainbow-3.0.0.gem
Fetching parallel-1.20.1.gem
Fetching regexp_parser-2.1.1.gem
Successfully installed unicode-display_width-2.0.0
Successfully installed ruby-progressbar-1.11.0
Successfully installed parser-<IP_ADDRESS>
Successfully installed rubocop-ast-1.4.1
Successfully installed rexml-3.2.5
Successfully installed regexp_parser-2.1.1
Successfully installed rainbow-3.0.0
Successfully installed parallel-1.20.1
Successfully installed rubocop-1.12.1
9 gems installed
$ gem install rubocop -v 1.6.1
Fetching rubocop-1.6.1.gem
Fetching unicode-display_width-1.7.0.gem
Successfully installed unicode-display_width-1.7.0
Successfully installed rubocop-1.6.1
2 gems installed
$ ruby -v
ruby 2.4.10p364 (2020-03-31 revision 67879) [x86_64-darwin18]

gem update --system does fix it. Thanks for the responses.
docker run -it ruby:2.4.10 bash
gem install rubocop -v 1.6.1
ERROR:  Error installing rubocop:
	The last version of rubocop-ast (>= 1.2.0, < 2.0) to support your Ruby & RubyGems was 1.4.1. Try installing it with `gem install rubocop-ast -v 1.4.1` and then running the current command again
	rubocop-ast requires Ruby version >= 2.5.0. The current ruby version is <IP_ADDRESS>4.
gem update --system
gem install rubocop -v 1.6.1
Fetching rubocop-ast-1.4.1.gem
Successfully installed unicode-display_width-1.7.0
Successfully installed ruby-progressbar-1.11.0
Successfully installed rubocop-ast-1.4.1
Successfully installed rubocop-1.6.1
4 gems installed


add issue templates

take from athens & adjust where needed

issue template : bug & feature
PR template

i will take this


Improve project documentation

Document:

[ ] https://github.com/ifvictr/HCCore/pull/64
[ ] Development environment prerequesites
[ ] Plugin dependencies

add code formatting guidelines


Add NET 9 Support

Hello
The official and final version of NET 9 has been released.
Please upgrade the packages.

I am facing various errors in "Z.EntityFramework.Plus.EFCore <IP_ADDRESS>" in the project that I upgraded

Hello @KAJOOSH ,
The support has been added today for EF Plus (EF Core 9)
Let me know if everything works as expected.
Best Regards,
Jon


feat: Web and Internet Transport Area

closing this as abandoned - the idea make it easy to test that the schedule editor worked, but completing automation will require a bit of a refactor of the group utilities and the group edit view so that a management command (and preferably a migration) could make these kinds of changes and still preserve, .e.g.,  RoleHistory