Go operating system build tags/file suffixes

I have some questions about how the Go compiler handles the operating system build tags
A file named name_windows.go will only be included when built for Windows, that's straightforward.
Same goes for name_darwin.go which is OS X/macOS.
However, there is some unclear names I'd like to get some answers to, since I'm currently writing OS dependent code.
route_bsd.go in package syscall, does it build on all BSD flavors?
There are one route.go for each flavor, route_freebsd.go, route_openbsd.go, route_netbsd.go, route_dragonfly.go.
Same is for sockcmsg_unix.go in syscall, exactly what systems will this be built for? Does the unix flag include darwin and all BSD flavors?

@redpois0n see https://github.com/golang/go/wiki/Questions for the ways to ask questions.
In this case https://golang.org/pkg/go/build/#hdr-Build_Constraints is the documentation you're looking for.

@cespare You misunderstood my question or I did not explain correctly, I am mostly wondering what the unix and bsd build constraints includes

@redpois0n I think those names are just conventional. The constraints for those files are listed using build tags in the file.
But please close this issue and let's continue the discussion on one of the forums listed in https://github.com/golang/go/wiki/Questions. We try not to use the issue tracker for questions.

You are correct. Thank you.


CBL-Mariner2.0 reporting security vulnerability [CVE-2024-45490]

We've encountered an issue with Component Governance in our project, specifically with the Mariner 2.0 image. The governance tool flagged several packages as vulnerable, and despite upgrading them to the recommended versions, our pipeline continues to report the presence of these vulnerable packages.

Affected Packages and Versions:
expat: Upgraded from 2.6.2-2.cm2 to 2.6.3-1.cm2
curl: Upgraded from 8.8.0-1.cm2 to 8.8.0-2.cm2
Attempted Resolution: We explicitly upgraded the mentioned packages to the versions recommended by the Component Governance tool to address the vulnerabilities.

Further Steps: Following a suggestion from the Component Governance Team, we utilized the https://github.com/microsoft/component-detection/tree/main tool to scan our project. The scan results showed both the old and new versions of the packages, which is puzzling.

How can we remove any dependencies on the vulnerable packages through docker directives?

It sounds like this is a docker container.  If you install something a layer is added on top.  The scan tools frequently detect packages in both layers.  You will likely need to squash your container for CG to disregard.


feat: add SWC and TSup example

ESBuild isn't really designed to compile entire folders (it is meant to bundle files), so I made the SWC version as a replacement. It is just as fast.

ESBuild isn't really designed to compile entire folders

Right I should change that to with-tsup.. tsup uses esbuild and is much easier to configure and use globby in the background.

Should this PR be closed then?

Just added a tsup example with this PR


Windows Firewall Logging

Been through all the issue reports and guides, had the Windows Firewall Logging working until this morning, but it died. I've been through removing the data connector and putting it back in, reset the MMA agents, and so on.... has something else changed here?

Apologies for the delay in responding.  Would you be able to give a call into our support team, they are best suited to help you there - https://docs.microsoft.com/en-us/azure/azure-supportability/how-to-create-azure-support-request


Add Zbeacon DS01 quirk removing PollControl cluster

Proposed change

The Zbeacon DS01 (no idea who made this, but it's a cheap chinese door sensor that runs on 2xAAA and is long rectangular in shape).
Add quirk for Zbeacon DS01, which removes the PollControl cluster, which is incorrectly implemented by the device I think.
Additional information

The device will send "PollControl:checkin()" on PollControl cluster, but doesn't respond when checkin_response is sent after that from the coordinator.
This results in error messages every 30-60 minutes with the message that the device didn't respond.
This is easily avoided by just disabling the PollControl Cluster.
Checklist

[x] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[x] Tests have been added to verify that the new code works

With witch coordinator do you have testing and also is you having one sniffing of the pairing that we can taking one look on.
Interesting to see if all flags is set OK also if the end device time out is being OK replayed from the devices parent then joining
TI coordinators was having all pull control disabled but was fixed for one half year ago and some is not doing it OK.

@TheJulianJES Great that there is a tool to generate quirks now, nice job.
@MattWestb My coordinator is a Conbee II with the latest firmware (15-May-2022). The testing is done with 2 devices and I have consistent errors every ~45 minutes without this quirk. I could send a log, but it'll take a little while for me to get around to it.
About the classification: I wasn't sure where to put it, because it is unclear to me who made it. The sellers advertise it as being TuYa. I could move it to Elivco or IHseno IH-MC01 (both seem identical in the pictures, but mine are from Elivco).

Then its not one TI-Coordinator problem then one tuya is trying implanting pull control and more then likely we is getting more device from them with the same problem very sooooooon.
If being one own brand its not so importing for my then its not looking like normal tuya IDs like LIDL and other is using.

I moved it to its own manufacturer now; I just put it under Zbeacon. It is probably using a TuYa ZTU module, but that doesn't mean it's programmed by TuYa. I cannot find anything about Zbeacon, Elivco or IHsense. Although Elivco seems to yield some results with smart plugs.


Release 1.5.2

This is a draft of changelog for the 1.5.2 release.
Here you can find all related translations changes: 1.5.1...main.

⚠ Do not merge this pull request manually ⚠
You should approve this pull request instead. After approving, I will automatically update it (release date needs to be adjusted), merge, and tag a new release. You can read more about the process on forum.

Show release notes preview
1.5.2

Traduções atualizadas para extensões:

v17development/flarum-support

Todas as alterações: 1.5.1...1.5.2.

Success! Now you can announce new release on forum:
## Versão [`1.5.2`](https://github.com/flarum-lang/brazilian/releases/tag/1.5.2)

**Traduções atualizadas para extensões**:

* [`v17development/flarum-support`](https://extiverse.com/extension/v17development/flarum-support)

Todas as alterações: [1.5.1...1.5.2](https://github.com/flarum-lang/brazilian/compare/1.5.1...1.5.2).

Para atualizar, execute estes comandos:

```console
composer update flarum-lang/brazilian
php flarum cache:clear
```


Windows program loading

demonstrates that the basics of surgical linking work on actual Windows.
turns out that Wine does not perform base relocations: it just uses the image base from the .exe. That does not work on actual windows, and so we must deal with relocations.
For context: the roc app functions are called from the host with an indirect call: the code will look in a table to find the actual address of the app function. This table must be relocated, because it contains absolute addresses to jump to. This PR implements the insertion of these relocations.

I thought I would test this for you. Windows has been my primary OS for any development. I'm not sure what part you wanted to be executed, so I thought I would try to build it all. This is the result from building on my machine. Cargo build errors

try cargo test -p roc_linker, that should work at least
but thanks for the error log, I'll look into that separately. I also did not get the full compiler to build yet on my windows machine, but CI can do it so it must be some system-specific thing

Running cargo test -p roc_linker 1> cargo_test_linker.txt 2>&1 gives me the following error results.

I fixed some issues with my Zig, and LLVM installation and I am now getting the below, which looks good.


syncback: docs

Hello @nicks,
Please review the following commits I made in branch maiamcc/syncback-docs:
06621853de7cd8b8bd157cb581b8ba45c9da73ef (2020-12-09 17:06:11 -0500)
add image
dea9a480b9141e86d0dcf64e3a24e246abe918a6 (2020-12-09 16:56:51 -0500)
syncback: docs
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

fwiw, my "technical writer" alarm bells always go off whenever i see a README that has a big wall of text of caveats and technical detail.
I suspect the intro user doesn't really care that much how it's implemented, and cares a lot more about how to make it work for their project.
wonder if some of this should be moved to an ARCHITECTURE.md or smth

that... is super reasonable. I'll move this around.


Question : framework-arduinoespressif upgrades ?

I see weekly there are some changes made to  "https://github.com/esp8266/Arduino/" master branch. So how often these changes get into @platformio ?
do these get released with a major release or a milestone ? let me know. thanks.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29062556-question-framework-arduinoespressif-upgrades?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github).

PlatformIO uses stable versions of toolchains, frameworks, etc. See https://github.com/esp8266/Arduino#available-versions

got it. thanks


Remove condition for computing ustar

This PR removes a conditional for deciding how ustar is populated in SurfaceBase. This should be a no-op because ustar is passed into SurfaceFluxes if TC.fixed_ustar(surf_params), so we should be able to recover it by consistency.

bors r+

bors r+


flow compatible mocking API

addresses https://github.com/facebook/jest/issues/4257

needs more thoughts


Support Docker and PostgreSQL image

Acceptance Criteria

Provide handy approach to initialize the project
Integrate PostgreSQL image

Done #17


bower install not working

$ bower install
bower ENOENT        No bower.json present

Please ensure you have copied all the files from the
third_party/polymer_stater directory (which is where bower.json is located)
in the previous step:
cp -rv solutions-vision-search/third_party/polymer-starter/.
solutions-vision-search/gae/frontend
Then follow up with:
cd solutions-vision-search/gae/frontend
bower install
On Wed, 1 May 2019 at 18:09, omar<EMAIL_ADDRESS>wrote:

$ bower install
bower ENOENT No bower.json present
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/solutions-vision-search/issues/1,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVAGKJ3RPEBLCSOUZ3AQC3PTFF5JANCNFSM4HJSJB7Q
.

It works now, thank you!


Improve Support for WASM

Motivation
Use Spartan in WASM environment (browser or WASM runtimes, wasm32-unknown-unknown).
Ref #54
Things changed

[x] move dependencies std features behind new feature std (a58ddef8a0377ee7f97ca62c2fbb1a553d68fff9)
Previously there was no way to disable the std features if someone wants to build it in no_std or partial std target. Now the same can be done by simply disabling the default feature.
[x] remove rand_core dependency as rand re-exports it.
[x] use XofReader instead of io::Read for no_std compatibility (f63812b35961d8602b3d0660f269675ee7ac57d4)
[x] only build bench & profile if std in enabled (074db25ad280c33dbdc503b0625ae14e2661704c)
[x] add CI job to test builds with default-features disabled. (5169cf208bd5aad58c615c53d59e0835bc158ff3)
[x] add WASM Support section in readme

How to use Spartan in wasm32-unknown-unknown?
When adding Spartan to wasm-bindgen projects or any project that target wasm32-unknown-unknown, simply disable the default features and add getrandom(v0.1) as a dependency with wasm-bindgen feature enabled.
[dependencies]
spartan = { version = "0.7", default-features = false }
# since spartan uses getrandom(rand's OsRng), we need to enable 'wasm-bindgen'
# feature to make it feed rand seed from js/nodejs env
# https://docs.rs/getrandom/0.1.16/getrandom/index.html#support-for-webassembly-and-asmjs
getrandom = { version = "0.1", features = ["wasm-bindgen"] }

Details for getrandom
Spartan uses rand v0.7 (Why not latest rand v0.8? because curve25519-dalek v3's Scalar::random will break as it uses rand v0.7).
The rand::rngs::OsRng depends upon getrandom (v0.1) crate which silently fails in wasm32-unknown-unknown during runtime, see the discussion https://github.com/rust-random/getrandom/issues/87#issuecomment-522138650  unless wasm-bindgen feature is enabled.

@microsoft-github-policy-service agree

@ashutoshvarma thanks for the PR! It looks great!
From the CI, it looks like there is a minor issue. I don't seem to have the write access to fix this in the PR branch. Can you add a commit to fix this?
error: this impl can be derived
--> src/errors.rs:26:1
|
26 | / impl Default for ProofVerifyError {
27 | |   fn default() -> Self {
28 | |     ProofVerifyError::InternalError
29 | |   }
30 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: -D clippy::derivable-impls implied by -D warnings
= help: remove the manual implementation...
help: ...and instead derive it...
|
7  | #[derive(Default)]
|
help: ...and mark the default variant
|
8  ~   #[default]
9  ~   InternalError,
|

I don't seem to have the write access to fix this in the PR branch.

That's weird, "Allow edits and access to secrets by maintainers" checkbox is checked for this PR.

Can you add a commit to fix this?

Sure.

@srinathsetty fix pushed!


Allowed title as props for <details>

From #3383

Additionally, should we use a title prop for the anchor base instead of the first child's text?

Used title as props for <details> tag.
Initially, I only used title as props but there are 2-3 particular cases that use code highlighting in the title.

So, I also added back the first child's text as a fallback if no title is passed as props so that we still can use markdown as well.
Also, previously in this particular case, the code section seems to be parsed as object object as well
resulting: https://dvc.org/doc/user-guide/external-dependencies#expand-to-see-resulting-object-object-file
This issue should also be fixed with the pr.
But, if markdown syntax is not so important and the title would be enough then the code implementation of the Details component will be very simple and preferable.

question if this approach breaks some titles and we have to maintain two options, why do we consider it superior and why do? let's keep the previous one?

markdown wouldn't be supported when passed as props but I think it would be okay without it too as it's used in just 2 titles to highlight .dvc.
And, using title as props should make consistent with other markdown custom elements as they also support through props.

Also, previously in this particular case, the code section seems to be parsed as object object as well
resulting: https://dvc.org/doc/user-guide/external-dependencies#expand-to-see-resulting-object-object-file
This issue should also be fixed with the pr.

I think this one needs to be addressed and which we didn't address on pervious pr.

Ah shoot, due to #3391 there are some merge conflicts to solve now... ⌛

Reminder:

Still, I don't see any clear motivation for this tbh. And still it breaks things in some cases. So, my take - let's postpone / keep it as-is for now.

can we skip addressing the conflict?
please please let's be mindful about the bigger priorities

Given this is not much of a priority + all the conflicts, should we close it or turn it into an issue? Thanks


Add a color picker/previewer to the Playground for BABYLON.ColorX invocations

Testing (both with JavaScript and TypeScript):

Firefox 69.0.3 (64-bit)
Chrome 77.0.3865.120 (64-bit)
Edge legacy 44.18362.387.0
Edge 78.0.276.17

:heavy_check_mark:
:heavy_check_mark:
:heavy_check_mark:
:heavy_check_mark:


Add ci_riscv to daily docker image rebuild

Follow-up to https://github.com/apache/tvm/pull/12230.
@driazati @alter-xp @PhilippvK

Skipping GitHub Actions since this is just a Jenkins change


main.py

please make this file apk

You can create apk by following examples in Readme or by using Buildozer locally.


delete Model issue

index table template has a delete link that uses a simple GET request (no form ) to delete an item(Model). so there is no CSRF checking . maybe it would be better to implement a form to delete items and use POST instead of GET request.

it seems there has been a related pull request later


ERROR: Failed to resolve: com.github.hajiyevelnur92:intentanimation:1.0

Hi, Im new to android development. I was trying out the intent animation library;
allprojects {     repositories {         google()         jcenter()         maven {url 'https//jitpack.io'}          }
dependencies{     implementation fileTree(include: ['*.jar'], dir: 'libs')     implementation 'androidx.appcompat:appcompat:1.0.0-beta01'     implementation 'androidx.constraintlayout:constraintlayout:1.1.3'     implementation 'com.muddzdev:styleabletoast:2.2.1'     compile 'com.github.hajiyevelnur92:intentanimation:1.0'     testImplementation 'junit:junit:4.12'     androidTestImplementation 'androidx.test:runner:1.1.0-alpha4'     androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0-alpha4' }
and I got stuck with this error:
ERROR: Failed to resolve: com.github.hajiyevelnur92:intentanimation:1.0
Show in Project Structure dialog
Affected Modules: app
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
Affected Modules: app
So I tried changing "compile" to "implementation" and "api" and got this error in both cases
ERROR: Failed to resolve: com.github.hajiyevelnur92:intentanimation:1.0
Show in Project Structure dialog
Affected Modules: app
Please help me , thank you

put this string in duild.gradle (project: "name") / allprojects. I'vegot simmilar proplem, when i was try to put this stirng in wrong place duild.gradle (project: "name") / buildscript

Got the same error.
Solution: add mavel { url 'https://jitpack.io } in the file: settings.gradle


Steam Input

Please shoot down this feature request if it's out of scope (which it probably is), but: Steam Input is something that's always been a pain when developing with Godot. When in use, there are scenarios where Godot will see a keyboard rather than a controller, or always thinks an Xbox controller is connected, and of course the user might've remapped everything - and the only way it looks like we'd know is by querying the Steam API.
Rather than implementing a custom solution with GodotSteam - which looks like it'd be complex enough, as it doesn't seem to plug into Godot's Input - would it be possible to detect Steam Input fudgery using this plugin, somehow?

I haven't had any dealings with Steam just yet. When I get there I'll have to do some research and see what I can come up with (unless someone has generously worked it out for me by then lol)


Incorrect chunks array index

In create_upload you were using chunks_uploaded but when resuming an upload you're checking for chunks. This PR fixes that.

Yes, but your PR changes 'chunks_uploaded' into 'chunks' in both places; the JSON key should be named 'chunk', but the db columns is named 'chunks_uploaded'

I'm not sure I understand. My PR changes  chunks to chunks_uploaded. Not sure where you get that the JSON key needs to be named chunk from.


Request to be added to cdnjs distribution platform

cdnjs is a distribution platform for small-ish JavaScript libraries that don't have the budget/traffic to pay for a huge CDN or don't care to. You can request to be added to their CDN by opening an issue on their repo.
I'm using your library in a production application and I'd rather use some else's CDN to host it than to host it locally, both to avoid disk I/O slowdowns and because we're currently using a CDN for every other script and stylesheet we load. I think you benefit from this, so I hope you'll consider it!

Good suggestion, I'll try to find some time to put together the package + other requirements they want.

@robojamison Realistically I'm not going to get a chance to do this (create the package, tests, etc). If you submit a pull-request that meets their requirements I'm happy to re-open and merge.


[Rancher2] Publish Rancher API guide

cc @leodotcloud @spgardiner

@sirredbeard sorry, I didn't get the context here. Any action item for me?


Create foundational CloudFormation stacks

As a prerequisite for #8 I need to create the foundational CloudFormation stacks:

[x] BootstrapApp (Set up the AWS environment)
[x] DockerRepositoryApp (Create container registry with ECR)
[x] GitHubActionsApp (Create GH Action user & credentials)
[x] NetworkApp (Create the shared network for all applications)
[x] ServiceApp (Create the application stack to deploy the containerized application)

Set up GH Actions workflows to set up the above CloudFormation stacks:

[x] manual workflow dispatch for the BootstrapApp
[x] manual Workflow dispatch for the NetworkApp
[x] push to master dispatch for the ServiceApp
[x] Set up GH Actions user credentials in the repository secrets

While I'm able to create the GH Actions user via the GitHubActionsApp there are still rights missing. Currently, this user is not able to deploy the ServiceApp.
Let's see if I'll get help with that here: https://github.com/stratospheric-dev/stratospheric/issues/191


php artisan vendor:publish delatbabel/elocryptfive  Not Working

Hello i am Trying to publish the config files.  but this is not working..

Should be working now with the latest tagged version.
The correct command is:
php artisan vendor:publish --provider=Delatbabel\Elocrypt\ElocryptServiceProvider

Nope. This isn't working for me on Laravel 5.2:
php artisan vendor:publish --provider=Delatbabel\Elocrypt\ElocryptServiceProvider
Nothing to publish for tag [].
Also tried
php artisan vendor:publish --provider=Delatbabel\Elocrypt\ElocryptServiceProvider --tag="config"
Nothing to publish for tag [config].

OK I can confirm that it works for me.
If it's not working for you then check the following:

Have you included Delatbabel\Elocrypt\ElocryptServiceProvider::class in your providers array in config/app.php
Does the config/elocrypt.php file already exist? php artisan vendor:publish will only work once, it won't overwrite the file if it already exists in case you have made changes. If you want to force it to overwrite then use the --force flag.
Do you have the latest package? composer update just to check.

Hi. Thanks for replying. I have done the following:

included Delatbabel\Elocrypt\ElocryptServiceProvider::class in providers array
confirmed that config/elocrypt.php does not exist
ran composer update

I am still getting the nothing to publish for tag[] message when running php artisan vendor:publish --provider=Delatbabel\Elocrypt\ElocryptServiceProvider.
Anyway, my client has decided not to go with encryption so I won't be able to look any deeper into this at the moment. Thanks for your help anyway.


Code no longer runs

USer reports that this program used to work 1 month ago and now lo longer works.microbit-Dr-PLAY(2).hex.zip removing the tinker blocks seems to fix the issue, but I can't get a reliable reproducer. Updating the blocks does not fix the issue either.

can you take a look at this @firemansamm @yjsoon ?

Sorry, missed this. Will take a look. Could be due to the memory issues we faced (and since fixed) with the OLED library.

@microbit-mark I'm unable to import this hex file, can I trouble you to check / share a link to a hosted version?

I think it may have been renamed and so doesn't load. Here's a link https://makecode.microbit.org/_DCtita9ifKED

Seems to work with the latest version of the extensions, so it was likely the OLED issue. Replicated with latest extension: https://makecode.microbit.org/_gYbVVh8tXR2M. Closing; hopefully the user got it working!

Thanks @microbit-mark as always 👍


make center_crop as operator

Description

make center crop as operator
support batch input
add unit test

*the code change depend on #13611 utitlity function, so will not pass the CI
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes
Comments
@sandeep-krishnamurthy

will come back to this soon

@stu1130 Did you get a chance to revisit this PR?


Add dependencies (needs: event_file) for upload contributors eample

Should be useful.

The publish step should be run in a separate workflow, see https://github.com/EnricoMi/publish-unit-test-result-action/issues/597#issuecomment-2094764306.


Cannot convert 'AFDataResponse' to 'DataResponse<Any, AFError>' in RxAlamofire with Alamofire 5.10.0

Problem
We are encountering an error in RxAlamofire, which uses Alamofire. The error message is:
Cannot convert value of type 'AFDataResponse<any Sendable>' (aka 'DataResponse<any Sendable, AFError>') to expected argument type 'DataResponse<Any, AFError>' in rxalamofire which uses alamofire.

Alamofire Environment
**Alamofire Version:5.10.0
**Dependency Manager:spm
**Xcode Version:15.4
**Swift Version:unspesified
**Platform(s) Running Alamofire: rxalamofire in Xcode 15.4
**macOS Version Running Xcode: Mac OS  sequoi

On the one hand, this is accurate, and RxAlamofire should be updated with the new signature.
On the other, this API is deprecated, and technically is lying anyway, as the Any value from JSONSerialization isn't Sendable in the first place.
I think I'll revert this part of the Sendable changes.

You shouldn't need to fork anything, just add Alamofire as a package to your project and limit it to 5.9.1. Or use the bug/relax-jsonresponseserializer-sendable-requirement branch until I release the fix.

You shouldn't need to fork anything, just add Alamofire as a package to your project and limit it to 5.9.1. Or use the bug/relax-jsonresponseserializer-sendable-requirement branch until I release the fix.

Thanks for the help. It worked well. It didn't cause any conflict with the RxAlamofire.

This has been released in Alamofire 5.10.1.


Ticketing - In the edit event UI, the save button should update the event and all showings

Events and showings are updated correctly, but ticket types are still not edited correctly and they disappear when trying to save an edit on them.
There is a branch that has begun to address these issues, but it has bugs. Feel free to continue on that one or start a branch from scratch.

Branch provided doesn't exist: https://github.com/WonderTix/WonderTix/tree/julian-final-merge (presents a 404 error). Only main and ticketing branches exist. Moving this back to backlog as it is no longer available for us to use and we will have to start from scratch.


[CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…

… Instead Of Whole CarbonRow
Modification reason: During loading Data usesing globalsort, the sortby processing is based the whole carbon row, the overhead of gc is huge when there are many columns. Theoretically, the sortby processing can works well just based on the sort columns, which will brings less time overhead and gc overhead.
Modification content: In case of loadDataUsingGlobalSort, the first parameter of rdd.sortby is changed to CarbonRow.getKey from CarbonRow.getData. In CarbonRow.getKey, we get the sortcolumns of CarbonRow
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1159/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1177/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1168/

recommit

retest this please

add to whitelist

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1161/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1179/

add to whitelist

retest this please

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1170/

@marchpure :

run the compile locally and then push once everything passed.
mvn clean install -DskipTests -Pbuild-with-format -Pspark-2.3

No need to close PR, nobody will merge untill it gets LGTM. you can work on it by keeping open also

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1180/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1171/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1162/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1165/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1183/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1174/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1171/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1180/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1189/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1305/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/1315/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1328/


Allow user to cancel the initiation of drag and drop

Fixes GitHub issue #1103
See also Stack Overflow

@vakata Thanks for your consideration.  I like the built-in way that you proposed on Stack Overflow.  Feel free to use this Pull as a starting point for other work, if you like.


Button with white background colour variant

Hi team,
I see that the current API does not support a white background Google Pay Button. I came into this problem when integrating with our app which has a black background
It would be great if the Button component has an extra optional prop theme or variant to support the white background version
The alternative that I'm using in order to follow the brand guideline is to use the HTML-and-CSS-only version of the button which can be found here at https://developers.google.com/pay/india/api/otherapis/omnichannel/brand-guidelines

I saw that the latest commit 65c98bad317423bd9d218f61e1f15f19a4f1497b removed the buttonColor prop because there is only 1 variant for the button now.
Also, I see that a similar issue was raised and addressed before at #192
Hence closing this request

@lancedang64 after feedback from partners we decided to revert this change. the white button variant is now available again.


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=360971868
https://github.com/Azure/azure-cli-extensions/commit/cf0d7b6c031ba844dd5e43cc4e07533b85ef1269

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How to use outside a component

Hello @euvl, great job on this plugin, but i would like to know, how i can use this plugin outside of a vue component, like let say i have an api.js file where am making all my api calls, and i want to make use of the plugin in there.
Thank you.

Hey @OgaBoss, Thanks.
This plugin requires instance of Vue to work. You can try doing var instance = new Vue() in your api calls file or you could pass Vue instance from your root component, for example:
mounted () {
  api.setVueInstace(this)
}

api:
let vue = null

export default {
...
setVueInstance (instance) { vue = instance }
}


Extension doesn't work with WSL

When I tried to add this extension to my WSL it wasn't able to start LSP client, failed to deliver proper syntax highlighting and messed up with brackets highlighting.
Unfortunately I can't provide any meaningful logs as extendible doesn't produce any.

Hey @LNow! Do you mind trying again with the latest release from the Marketplace (0.5.3)? Thanks!

@lgalabru now it works correctly.
Thank you for fixing it!


Update tests for offers and organizations enpoints

Description:
After change introduced in 22a4209193f6a3c0dc0dd5625f25e8b93a9c606b we use standard Django-based login method (not the one introduced in Django REST Framework), but tests for /offers and /organizations endpoints use Django REST Framework method to login (self.client.login(...)) - we need to change it to use Django-based login method.
Current behaviour:
Tests for /offers and /organizations endpoints use Django REST Framework method to login (self.client.login(...)).
Expected behaviour:
Tests for /offers and /organizations endpoints use Django-based method to login.

I have checked APITestCase.client.login method and it looks, that it doesn't simulate http request at all. It use background authenticate and login methods.
I'm closing it and we will see in #597 if /login and /logout serves their purposes.


Add more layouts

add more layouts or templates for Scaffold

What kind of layout are you thinking of?
Do you have any examples?

https://vuetifyjs.com/zh-Hans/getting-started/wireframes/#section-793a4f8b


models: per bucket file size limits

Adds a per bucket maximum file size limit.

File size limits are now checked while writing the object.

Signed-off-by: Sami Hiltunen<EMAIL_ADDRESS>

Coverage decreased (-0.8%) to 91.153% when pulling cbcda7eef8063ab8ee0a1b6a56d3a06bb71963d7 on SamiHiltunen:file-size-limiters into f9d958e994e570ab8c994997c689ae27bd3e4622 on inveniosoftware:master.

Coverage decreased (-0.8%) to 91.153% when pulling 7ab0bad53ce2c5d77e165f6c8e53b134faccefdb on SamiHiltunen:file-size-limiters into f9d958e994e570ab8c994997c689ae27bd3e4622 on inveniosoftware:master.

Coverage decreased (-0.8%) to 91.153% when pulling 7ab0bad53ce2c5d77e165f6c8e53b134faccefdb on SamiHiltunen:file-size-limiters into f9d958e994e570ab8c994997c689ae27bd3e4622 on inveniosoftware:master.

Coverage decreased (-0.4%) to 91.572% when pulling 9fbec2d2e969887beab40f720cfc420115953c3e on SamiHiltunen:file-size-limiters into c3a7256ef5bf226ef9898d315d327415d6e00b0f on inveniosoftware:master.

Coverage increased (+1.1%) to 93.052% when pulling e333687fd782a3ec26955f1e81ad89a16f930686 on SamiHiltunen:file-size-limiters into c3a7256ef5bf226ef9898d315d327415d6e00b0f on inveniosoftware:master.

Coverage increased (+1.3%) to 93.28% when pulling 4bc591525b45ca70a192721686f8e35776dc17f8 on SamiHiltunen:file-size-limiters into c3a7256ef5bf226ef9898d315d327415d6e00b0f on inveniosoftware:master.

@lnielsen I've fixed the issues you found


NAT rules do not support descriptions

According to the VCloud API documentation, the Description attribute is supported
The Schema in vcloud::edge_gateway::nat_service already supports this attribute,
When the configuration generator collects the NAT rules, it does not do anything with the description.

Fixing this problem may be as simple as adding new_rule[:Description] = rule[:description] if rule.key?(:description) around line 27 of configuration_generator/nat_service.rb and adding appropriate tests.

This was added in https://github.com/gds-operations/vcloud-edge_gateway/pull/145


missed feed items

not all feed items are being read for some feeds
example: https://www.redvoicemedia.com/feed/
when updating the feed, or re-fetching the feed, all items for the last 2 days (10-17, 10-18) are skipped

I cannot reliably reproduce the issue, the version I am running daily is not published yet and may include a fix for this, but checking the published one it looks like it often fails to load the feed at all, but when it manages to articles are loaded properly
If you are able to could you try using the latest commit?
running
git clone git@github.com:zakius/Smart-RSS.git smartrss
cd smartrss
npm install
grunt prepare

will generate dist/firefox and dist/chromium directories you can load in respective browsers as temporary extensions, preferably do it in separate profile to not risk damaging your data.

Do you have any update on this issue?

i do not - the problem may be with the feed for that particular website - i just refreshed that feed again and got 20 new articles, all dated for the 19th - today is the 18th and it's a US site - i'll let it up to you decide whether to close the issue, but i have nothing to add at this time


Question regarding MQTT

hope you do not mind me asking a question in here.
I am looking at time series db solutions / monitoring / visualization tools in the open source space. I must say I like prometheus - awesome job so far! What I would like to learn about is the preferred solution to collect data from mosquitto (e.g. mqtt is used to collect temperature data from many hundreds or maybe thousands of tiny sensors).
As far as I understand you are not into push protocols. So is there a way to add an mqtt subscriber to prometheus maybe as a plugin? For example I know that InfluxDB has this feature built into telegraf. This approach probably scales better but also leads to long data chains …sensor -> mosquitto -> importer -> database. Do you think it would be possible to subscribe prometheus directly to mosquitto maybe as a plugin - without running an importer as a separate process?
For the purpose of learning this stuff... Is there a fork or some other information what it would mean to have a more push oriented prometheus? (I hope this question does not hurt any feelings)!
Best,
Mark

From a quick look, I think you'd be looking at a similar approach to the graphite/statsd/collectd exporters and creating an exporter that takes in mqtt and produces appropriate prometheus metrics on the other end.

Looks like this is answered.


Authorization PrincipleId not being persisted

When using a custom authorizer with the Event Gateway, you are able to add a principleId to the authorization object, like this:
return awsLambdaCallback(null, {
  authorization: {
    principleId: '123',
    context: {
      foo: 'bar'
    }
  }
})

I can verify that my code is setting principleId, but I do not see it show up in the next Function.  However, context properties do persist and show up.

Hey @ac360,
I think you have a typo in your code. It should be principalId not principleId. Just checked the docs and it's correct there https://github.com/serverless/event-gateway/blob/master/docs/event-types.md.

Thanks.  Was working a lot of hours yesterday :P


Revert "drop easy_install script and associated documentation"

This reverts commit 6e1838a9fb5feb000ba9b6a3c37c8b39d7e872b3.

Also added changelog entries for this and #1830.

Thanks @benoit-pierre for putting this together. I wonder if we can avoid re-adding this functionality by instead moving it to another package (called easy_install), and having setuptools depend on that package. That decoupling would make it obvious what is deprecated and provide a path to backward compatibility (those requiring/expecting this functionality could retain it by installing easy_install separately).
My main reluctance for doing this is that by adding a dependency, that dependency becomes non-optional (pkg_resources will expect the easy_install package to be present and crash if it's not).
Let me put together a draft.

@jaraco I think that might overly complicate things. Even in the now-reverted change, all the old functionality was preserved, we just had removed one of the public interfaces. We can just add a new wrapper script that warns that it's deprecated and in say 1 year replace it with one that actually raises an exception, same way we've done for upload and register .
I think there will be very little ongoing support burden to ship a script that just raises an exception, so we should probably just do the lowest-effort thing that gets us to that endpoint without introducing any footguns for end users.

You make a good argument. I think I agree.
I did throw together the easy_install package. All it needs is a tag to cut a release, but I'll refrain from doing that if we're not going to use it.

In #1913, I drafted my concept, but right away it reveals issues (with bootstrapping), at least one of the foot guns. Let's proceed with this approach for now.


Add a way to clear output field

Resolved. A button has been added to the UI with the functionality of clearing the output


Modifying single_nat_gateway destroys existing nat gatway

I've created a VPC with single_nat_gateway=true. When attempting to change to single_nat_gateway=false the plan shows the following:
  # module.vpc.aws_nat_gateway.this[0] must be replaced
-/+ resource "aws_nat_gateway" "this" {
      ~ allocation_id        = "eipalloc-xxxxx" -> (known after apply) # forces replacement
      ~ id                   = "nat-xxxx" -> (known after apply)
      ~ network_interface_id = "eni-xxxx" -> (known after apply)
      ~ private_ip           = "<IP_ADDRESS>" -> (known after apply)
      ~ public_ip            = "xx.xx.xx.xx" -> (known after apply)
        subnet_id            = "subnet-xxxx"

Since module.vpc.aws_eip.nat[0] has not been changed I would expect module.vpc.aws_nat_gateway.this[0] not to be changed as well.
This is related to the code here: https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/main.tf#L934-L937
And here: https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/main.tf#L906-L911
Any ideas?
Thanks

Hey,
did you change to using multiple NATs? count is tricky and if that's the case it won't keep order when changing count.
If you have multiple NATs then the count of EIP also changed. we can assume order of these as well and that's probably why you get this result.
I can't verify this at the moment but that's my theory.
@antonbabenko I don't see a direct action item but it may ease the pain when upgrading to reduce downtime but adding create_before_destroy for NATs and EIPs to prevent downtime and network failures, WDYT?

@DrFaust92 thanks, i've ended up creating the other nat gateways manually and importing them into the state.
However, I imported the other nat gateways and EIPs into resources [1] and [2], so i'm not sure this is related to count ordering.

@DrFaust92 We need to be very careful with create_before_destroy for NAT gateways in particular when they reuse existing IP addresses (what IP will it use to a new NAT and to an old one?). It is not very trivial task yet, but can be much easier when we replace count with for_each.
I think there is not much we can do here from the current code point of view but we can document the procedure @dudicoco did (see previous comment).

Changing the NAT gateway config like below generates the right plan (the existing NAT gateway is not destroyed).
resource "aws_nat_gateway" "this" {
  count = var.create_vpc && var.enable_nat_gateway ? local.nat_gateway_count : 0

  allocation_id = element(
    var.reuse_nat_ips ? var.external_nat_ip_ids : aws_eip.nat.*.id,
    var.single_nat_gateway ? 0 : count.index,
  )

I tested this on Terraform 0.13.6

create new VPC from scratch, 2 pub subnets, 2 private subnets, single NAT
set single_nat_gateway to false
set single_nat_gateway back to true
destroy VPC

I suppose the original Terraform bug that required the local.nat_gateway_ips workaround is now fixed?

Changing the NAT gateway config like below generates the right plan (the existing NAT gateway is not destroyed).
resource "aws_nat_gateway" "this" {
  count = var.create_vpc && var.enable_nat_gateway ? local.nat_gateway_count : 0

  allocation_id = element(
    var.reuse_nat_ips ? var.external_nat_ip_ids : aws_eip.nat.*.id,
    var.single_nat_gateway ? 0 : count.index,
  )

I tested this on Terraform 0.13.6

create new VPC from scratch, 2 pub subnets, 2 private subnets, single NAT
set single_nat_gateway to false
set single_nat_gateway back to true
destroy VPC

I suppose the original Terraform bug that required the local.nat_gateway_ips workaround is now fixed?

Any updates on this...?
Im switching from single to multi NATGW setup and recreating aws_nat_gateway.this[0] would basically cease the outgoing traffic during which the apply is doing its thing. Also, is there a guarantee that the new NATGW[0] will be hooked up to aws_eip.nat[0]?
I have whitelisted aws_eip.nat[0] somewhere else and it's kinda not cool to have the traffic stopped... even for < 10 seconds. Is there a bool i can set to skip the destroy?

Yep, I would document this. Going from:
  enable_nat_gateway     = true
  single_nat_gateway     = true
  one_nat_gateway_per_az = false

to:
  enable_nat_gateway     = true
  single_nat_gateway     = false
  one_nat_gateway_per_az = true

will cause an interruption of about 90-120 seconds due to the recreation of the existing single NAT gateway. This is still the case in the latest (v3.2.0).

hi all, this should be addressed in the next version which is under development here https://github.com/clowdhaus/terraform-aws-vpc-v4/tree/main/modules/subnets


Add support for creating "wildcard" and "regexp" queries

Closes #15
Changes proposed in this pull request:

Added support for wildcard and regexp queries

@michail1982 can you test this?

Changes Unknown when pulling 81c4ef805c8dc1d3a222a6a1a09667a86cb02792 on feature/wildcard-regexp-queries into ** on develop**.

Changes Unknown when pulling 81c4ef805c8dc1d3a222a6a1a09667a86cb02792 on feature/wildcard-regexp-queries into ** on develop**.

@Jalle19 the queries does have some options that would be nice to support as well, see more at:
https://www.elastic.co/guide/en/elasticsearch/reference/2.4/query-dsl-regexp-query.html
and
https://www.elastic.co/guide/en/elasticsearch/reference/2.4/query-dsl-wildcard-query.html

Also, they are listed under "TermLevel" queries, so the namespace and folder structure could be updated to match that + add direct links to the manual (in last post)

@kryysler I went by the 5.x documentation where these things have been removed (or the documentation has been made shorter).
Similarly, in the 5.x documentation these types of queries are listed under "Partial matching".

Hmm, ok. The project is built for ES 2.x and I think it won't run on 5.x without any hickups?

@kryysler my bad, I was looking at https://www.elastic.co/guide/en/elasticsearch/guide/current/_wildcard_and_regexp_queries.html which was mentioned in the issue. I'll rework the PR to include the missing options.
I'll code it against the v2.4 for now, but we should strongly consider supporting 5.x too.

No worries. Yes, we should upgrade to 5.x asap.

Looking through the documentation again it seems both types of queries support boost while regexp queries also support flags and max_determinized_states.

@kryysler please re-review

Coverage increased (+2.5%) to 67.843% when pulling c00ea70762f320097f06dd56c80ac9b7ba713777 on feature/wildcard-regexp-queries into 20174eb0e6ca2d5c0c0567b7a9cf76e563dc03b6 on develop.

Coverage increased (+1.7%) to 67.048% when pulling c00ea70762f320097f06dd56c80ac9b7ba713777 on feature/wildcard-regexp-queries into 20174eb0e6ca2d5c0c0567b7a9cf76e563dc03b6 on develop.

After moving the field to the base class, does the IDE understand the "(at)return $this" statement as the correct instance, so you can chain methods easily with autocompletion. Important as all queries does not have the same methods.

Yes, I tested this when writing tests. @return $this makes the IDE dynamically resolve the return value so it all works.

@kryysler done

Coverage increased (+1.7%) to 67.048% when pulling 0d190a9d6321c61fff591ed24e12029f74a982ec on feature/wildcard-regexp-queries into 20174eb0e6ca2d5c0c0567b7a9cf76e563dc03b6 on develop.


Fatal error with branch v2.0.0

Hi There,
I'm trying to use branch v2.0.0 but have an issue with the following error:
Fatal error: Uncaught Error: Cannot use object of type GuzzleHttp\Psr7\Response as array in /var/www/html/foo/bar/vendors/thenetworg/oauth2-azure/src/Provider/Azure.php:51
My code is:
$provider = new TheNetworg\OAuth2\Client\Provider\Azure([
  'clientId' => 'x',
  'clientSecret' => 'x',
  'redirectUri' => 'https://domain.com/',
  'metadata' => 'https://login.microsoftonline.com/{tenant}/v2.0/.well-known/openid-configuration',
  'responseType' => 'id_token',
  'responseMode' => 'form_post',
]);
$authUrl = $provider->getAuthorizationUrl();

Am I using it correctly - any advice on how to resolve?
Thanks

I've tried with older versions of guzzle and oauth2-client but no luck.
It seems the getOpenIdConfiguration() function is returning the response object instead of an array here: https://github.com/TheNetworg/oauth2-azure/blob/v2.0.0/src/Provider/Azure.php#L328
Changing to: return json_decode($response->getBody(),true); fixes for me.
Do you want a pr or am I missing something? Seems odd that this hasn't come up before

No problem - see pr #56.
Had a few other issues getting the v2.0.0 branch to work so see the pr for other fixes outside of this issue.

Awesome! It has been merged, so I am closing the issue now.


Load/run WASM created with wit-bindgen

Hello!
I am interested by loading in Java a WebAssembly created using the crate wit_bindgen. Actually I was looking for the Java bindings for this but I could not find any related project. As you probably already know, having this would allow to have a common WASM loaded by different languages (Python, Java, C, etc.).
I run your project wasmtime-java (and thanks for this) with a wit-bindgen generated WASM but I encounter 2 problems:

this first problem deals with the de/allocation functions: for wasmtime-java, the WASM file needs to have the 2 exported functions __alloc_bytes and __dealloc_bytes). Even this is not ideal, I temporarly added these functions (of course it would be better to use the existing wit-bindgen allocation functions)
the second problem occurs when function-signature (in WASM) looks like fn my_function(input: Vec<u8>) -> Vec<u8>. I cannot find a way to load the return value. I confirm that I can "see" the expected result in the WASM memory but I dont understand how to find the correct offset of this result in memory (and the related result size in bytes). The offset returned by the function call (which is correct) does not match the good offset of the result.

Could I ask your opinion about this?
Thanks!!

Hi, thanks for the note. I'm excited that you're looking at the project. So far this is definitely not production ready. In terms of support for wit_bindgen, I think that would be great. I've been a little stuck on trying to figure out generic language support.
I'm definitely aware of some of the limitations of the current structure of this project. I think the __alloc_bytes and __dealloc_bytes are artifacts of how data is passed back and forth with wasm from the Java environment.
As to your issue with Vec parameters and returns, currently the project only supports limited C style arrays to be passed around. This example shows what is currently supported: https://github.com/bluejekyll/wasmtime-java/blob/main/tests/slices/src/lib.rs#L39-L43
Since I haven't played with wit_bindgen yet, I think that would be a great first step in trying to normalize some of these conventions? Is this something you might want to try and help contribute to?

Hi, thanks for your quick answer!
Well, I want to help so I created a branch feature/add_ref_return_value here where there is a way to build a wit-bindgen wasm module (nightly rustc only). Feel free to take it or not!
For the time being, I do not know how to load the return value of my function (which is a byte vector whose value can be found in WASM-memory). Maybe we can contact us through the bytecodealliance zulip chat.

I’m not super active on the bytcodealliance Zulip, but I am on there. That would be a fine place for us to discuss things.


AssignmentInConditionSniff should throw errors on warnings

as mentioned in issue #3242, AssignmentInConditionSniff was removed from list of sniffs that only throw warnings in PR #3173
this PR adds it back in

İ see. The class should be string as it does not exists in ECS deps anymore.

just to confirm, you'd like me to replace the AssignmentInConditionSniff::class with  \PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\AssignmentInConditionSniff?
I'm sorry if it's a stupid question, I've had a long day :)

Better ask once than fix twice ;)
Yes, because downgrade would prefix this class with random string and broke it.


[regression] Loading time is really slow with large thread count once again

When we have a large thread count, loading time is noticeably slower ever since ad13034840b08f4caf393a1eabf1c080c14b541d
When we run translateLocally, the command line gets spammed with:
...
[2021-12-29 22:13:03] [memory] Extending reserved space to 128 MB (device cpu0)
[2021-12-29 22:13:03] Loaded model config
[2021-12-29 22:13:03] Loading scorer of type transformer as feature F0
[2021-12-29 22:13:03] [memory] Reserving 31 MB, device cpu0
[2021-12-29 22:13:03] [memory] Reserving 8 MB, device cpu0
[2021-12-29 22:13:03] [memory] Extending reserved space to 128 MB (device cpu1)
[2021-12-29 22:13:03] Loaded model config
[2021-12-29 22:13:03] Loading scorer of type transformer as feature F0
[2021-12-29 22:13:03] [memory] Reserving 31 MB, device cpu1
[2021-12-29 22:13:03] [memory] Reserving 8 MB, device cpu1
[2021-12-29 22:13:03] [memory] Extending reserved space to 128 MB (device cpu2)
...

For about 6 seconds on machines with large thread counts. This was initially fixed by When @graemenail backported fast model loading in this commit https://github.com/browsermt/marian-dev/commit/0ae657acc8a846c1a310b2eb51df345e6628c4e4
This is not acceptable since anyone running a powerful desktop with many cores would have to wait for a while until they can get the first translation out, especially given the previous experience was instantaneous startup.
I suspect that when @jerinphilip implemented fast model memory swap, he inadvertently broke fast model loading. Either that, or bergamot-translator has become about 16% slower since ad13034840b08f4caf393a1eabf1c080c14b541d and I am just noticing the loading model artefact. I haven't actually gone into the model loading code and verified that it is loaded multiple times, but it seems so to me. I'll do some investigating these days:
time QT_QPA_PLATFORM=offscreen ./translateLocally -m en-de-tiny -i ../../2554-0.txt -o test.avx2
BEFORE:
real    0m37.404s
user    3m40.661s
sys     0m10.943s

AFTER:
real    0m42.399s
user    3m28.061s
sys     0m6.331s

The time delta is pretty much the difference between instantaneous model loading and slow model loading:
[2021-12-29 22:52:35] [data] Loading SentencePiece vocabulary from file /home/s1031254/.config/translateLocally/ende.student.tiny11-1637774209/vocab.deen.spm
[2021-12-29 22:52:35] Missing list of protected prefixes for sentence splitting. Set with --ssplit-prefix-file.
[2021-12-29 22:52:35] [data] Loading binary shortlist as /home/s1031254/.config/translateLocally/ende.student.tiny11-1637774209/lex.s2t.bin false
[2021-12-29 22:52:35] [data] Lexical short list firstNum 50 and bestNum 50
[2021-12-29 22:52:35] [memory] Extending reserved space to 128 MB (device cpu0)
[2021-12-29 22:52:35] Loaded model config
[2021-12-29 22:52:35] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:35] [memory] Reserving 31 MB, device cpu0
[2021-12-29 22:52:35] [memory] Reserving 8 MB, device cpu0
[2021-12-29 22:52:35] [memory] Extending reserved space to 128 MB (device cpu1)
[2021-12-29 22:52:35] Loaded model config
[2021-12-29 22:52:35] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:35] [memory] Reserving 31 MB, device cpu1
[2021-12-29 22:52:35] [memory] Reserving 8 MB, device cpu1
[2021-12-29 22:52:35] [memory] Extending reserved space to 128 MB (device cpu2)
[2021-12-29 22:52:35] Loaded model config
[2021-12-29 22:52:35] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:35] [memory] Reserving 31 MB, device cpu2
[2021-12-29 22:52:35] [memory] Reserving 8 MB, device cpu2
[2021-12-29 22:52:35] [memory] Extending reserved space to 128 MB (device cpu3)
[2021-12-29 22:52:36] Loaded model config
[2021-12-29 22:52:36] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:36] [memory] Reserving 31 MB, device cpu3
[2021-12-29 22:52:36] [memory] Reserving 8 MB, device cpu3
[2021-12-29 22:52:36] [memory] Extending reserved space to 128 MB (device cpu4)
[2021-12-29 22:52:36] Loaded model config
[2021-12-29 22:52:36] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:36] [memory] Reserving 31 MB, device cpu4
[2021-12-29 22:52:36] [memory] Reserving 8 MB, device cpu4
[2021-12-29 22:52:36] [memory] Extending reserved space to 128 MB (device cpu5)
[2021-12-29 22:52:36] Loaded model config
[2021-12-29 22:52:36] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:36] [memory] Reserving 31 MB, device cpu5
[2021-12-29 22:52:36] [memory] Reserving 8 MB, device cpu5
[2021-12-29 22:52:36] [memory] Extending reserved space to 128 MB (device cpu6)
[2021-12-29 22:52:36] Loaded model config
[2021-12-29 22:52:36] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:36] [memory] Reserving 31 MB, device cpu6
[2021-12-29 22:52:36] [memory] Reserving 8 MB, device cpu6
[2021-12-29 22:52:36] [memory] Extending reserved space to 128 MB (device cpu7)
[2021-12-29 22:52:36] Loaded model config
[2021-12-29 22:52:36] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:36] [memory] Reserving 31 MB, device cpu7
[2021-12-29 22:52:36] [memory] Reserving 8 MB, device cpu7
[2021-12-29 22:52:36] [memory] Extending reserved space to 128 MB (device cpu8)
[2021-12-29 22:52:37] Loaded model config
[2021-12-29 22:52:37] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:37] [memory] Reserving 31 MB, device cpu8
[2021-12-29 22:52:37] [memory] Reserving 8 MB, device cpu8
[2021-12-29 22:52:37] [memory] Extending reserved space to 128 MB (device cpu9)
[2021-12-29 22:52:37] Loaded model config
[2021-12-29 22:52:37] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:37] [memory] Reserving 31 MB, device cpu9
[2021-12-29 22:52:37] [memory] Reserving 8 MB, device cpu9
[2021-12-29 22:52:37] [memory] Extending reserved space to 128 MB (device cpu10)
[2021-12-29 22:52:37] Loaded model config
[2021-12-29 22:52:37] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:37] [memory] Reserving 31 MB, device cpu10
[2021-12-29 22:52:37] [memory] Reserving 8 MB, device cpu10
[2021-12-29 22:52:37] [memory] Extending reserved space to 128 MB (device cpu11)
[2021-12-29 22:52:37] Loaded model config
[2021-12-29 22:52:37] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:37] [memory] Reserving 31 MB, device cpu11
[2021-12-29 22:52:37] [memory] Reserving 8 MB, device cpu11
[2021-12-29 22:52:37] [memory] Extending reserved space to 128 MB (device cpu12)
[2021-12-29 22:52:37] Loaded model config
[2021-12-29 22:52:37] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:37] [memory] Reserving 31 MB, device cpu12
[2021-12-29 22:52:37] [memory] Reserving 8 MB, device cpu12
[2021-12-29 22:52:37] [memory] Extending reserved space to 128 MB (device cpu13)
[2021-12-29 22:52:38] Loaded model config
[2021-12-29 22:52:38] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:38] [memory] Reserving 31 MB, device cpu13
[2021-12-29 22:52:38] [memory] Reserving 8 MB, device cpu13
[2021-12-29 22:52:38] [memory] Extending reserved space to 128 MB (device cpu14)
[2021-12-29 22:52:38] Loaded model config
[2021-12-29 22:52:38] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:38] [memory] Reserving 31 MB, device cpu14
[2021-12-29 22:52:38] [memory] Reserving 8 MB, device cpu14
[2021-12-29 22:52:38] [memory] Extending reserved space to 128 MB (device cpu15)
[2021-12-29 22:52:38] Loaded model config
[2021-12-29 22:52:38] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:38] [memory] Reserving 31 MB, device cpu15
[2021-12-29 22:52:38] [memory] Reserving 8 MB, device cpu15
[2021-12-29 22:52:38] [memory] Extending reserved space to 128 MB (device cpu16)
[2021-12-29 22:52:38] Loaded model config
[2021-12-29 22:52:38] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:38] [memory] Reserving 31 MB, device cpu16
[2021-12-29 22:52:38] [memory] Reserving 8 MB, device cpu16
[2021-12-29 22:52:38] [memory] Extending reserved space to 128 MB (device cpu17)
[2021-12-29 22:52:38] Loaded model config
[2021-12-29 22:52:38] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:38] [memory] Reserving 31 MB, device cpu17
[2021-12-29 22:52:38] [memory] Reserving 8 MB, device cpu17
[2021-12-29 22:52:38] [memory] Extending reserved space to 128 MB (device cpu18)
[2021-12-29 22:52:39] Loaded model config
[2021-12-29 22:52:39] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:39] [memory] Reserving 31 MB, device cpu18
[2021-12-29 22:52:39] [memory] Reserving 8 MB, device cpu18
[2021-12-29 22:52:39] [memory] Extending reserved space to 128 MB (device cpu19)
[2021-12-29 22:52:39] Loaded model config
[2021-12-29 22:52:39] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:39] [memory] Reserving 31 MB, device cpu19
[2021-12-29 22:52:39] [memory] Reserving 8 MB, device cpu19
[2021-12-29 22:52:39] [memory] Extending reserved space to 128 MB (device cpu20)
[2021-12-29 22:52:39] Loaded model config
[2021-12-29 22:52:39] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:39] [memory] Reserving 31 MB, device cpu20
[2021-12-29 22:52:39] [memory] Reserving 8 MB, device cpu20
[2021-12-29 22:52:39] [memory] Extending reserved space to 128 MB (device cpu21)
[2021-12-29 22:52:39] Loaded model config
[2021-12-29 22:52:39] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:39] [memory] Reserving 31 MB, device cpu21
[2021-12-29 22:52:39] [memory] Reserving 8 MB, device cpu21
[2021-12-29 22:52:39] [memory] Extending reserved space to 128 MB (device cpu22)
[2021-12-29 22:52:39] Loaded model config
[2021-12-29 22:52:39] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:39] [memory] Reserving 31 MB, device cpu22
[2021-12-29 22:52:39] [memory] Reserving 8 MB, device cpu22
[2021-12-29 22:52:39] [memory] Extending reserved space to 128 MB (device cpu23)
[2021-12-29 22:52:40] Loaded model config
[2021-12-29 22:52:40] Loading scorer of type transformer as feature F0
[2021-12-29 22:52:40] [memory] Reserving 31 MB, device cpu23
[2021-12-29 22:52:40] [memory] Reserving 8 MB, device cpu23

Suggestions, @jelmervdl @jerinphilip

I used marian::bergamot::getMemoryBundleFromConfig() and then plugged in the bundle. But it isn't any faster for me:
Benchmark 1: ./translateLocally-fs -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null
  Time (mean ± σ):      7.415 s ±  0.137 s    [User: 12.637 s, System: 2.146 s]
  Range (min … max):    7.218 s …  7.614 s    10 runs

Benchmark 2: ./translateLocally-mem -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null
  Time (mean ± σ):      7.709 s ±  0.059 s    [User: 13.223 s, System: 1.264 s]
  Range (min … max):    7.637 s …  7.833 s    10 runs

Summary
  './translateLocally-fs -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null' ran
    1.04 ± 0.02 times faster than './translateLocally-mem -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null'

I'm now wondering if TranslationModel::loadBackend could be run in parallel for each worker. From what I can see, it only writes to its own assigned bit in the vectors:
Testing this (see diff below, incl. using memory bundle) vs just uinsg the memory-bundle:
Benchmark 1: ./translateLocally-mem -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null
  Time (mean ± σ):      7.735 s ±  0.089 s    [User: 13.459 s, System: 1.248 s]
  Range (min … max):    7.622 s …  7.894 s    10 runs

Benchmark 2: ./translateLocally-async -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null
  Time (mean ± σ):      3.136 s ±  0.029 s    [User: 14.124 s, System: 2.913 s]
  Range (min … max):    3.103 s …  3.183 s    10 runs

Summary
  './translateLocally-async -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null' ran
    2.47 ± 0.04 times faster than './translateLocally-mem -m en-de-base -i ../../crime-and-punishment-1.txt -o /dev/null'

Diff:
diff --git a/src/translator/translation_model.cpp b/src/translator/translation_model.cpp
index 9d2eb0cdb73526584d53e5cc2e32facfffc9650e..753b500fea4629fde1452b67f76d5862185a1df8 100644
--- a/src/translator/translation_model.cpp
+++ b/src/translator/translation_model.cpp
@@ -45,8 +45,15 @@ TranslationModel::TranslationModel(const Config &options, MemoryBundle &&memory
     }
   }

+  std::vector<std::future<void>> loadCalls;
+  loadCalls.resize(replicas);
+
   for (size_t idx = 0; idx < replicas; idx++) {
-    loadBackend(idx);
+    loadCalls[idx] = std::async(&TranslationModel::loadBackend, this, idx);
+  }
+
+  for (auto &&loadCall : loadCalls) {
+    loadCall.wait();
   }
 }

Can you test with ad13034840b08f4caf393a1eabf1c080c14b541d
I think the problem is not IO (because any modern OS caches IO accesses). I think the model loading is running multiple times, as opposed to only once as in ad13034840b08f4caf393a1eabf1c080c14b541d

Looking at the differences, most of loadBackend was previously implemented in BatchTranslator::initialize, which was called inside the worker threads instead of the main thread.
I'm compiling the old build, will update this comment when I have a comparison.

So... my thinking is that loadBackend(idx) needs to change into loadBackend(graph) or loadBackend(workspace) called from worker thread on the first attempt at translation in the particular worker thread. This will ensure that each of the models are loaded onto the graph/workspace on-demand and once per thread achieving something similar. The thinking here is that workspace is the heavy part, graph and model are thin. If the workspace is constructed once per (service-worker) thread and left there the gains would be higher.
Even better design in our discussions is that the model is read directly from the memory we are given at construction time all the time (model is read-only at inference hence thread-safe, we can share it and need only one copy outside workspace). Mechanisms are not very clear to me here, there seems to be some preprocessing and placing the result on the graph which makes things complicated.
Since TranslationModel is now separated from Service, the active threads when multiple TranslationModel's are constructed might go into T + S (where T are threads spawned by TranslationModel and S those active in Service.


[Bug] Offset of caret from the letter

Describe the bug

In the above screenshot, you can see that the caret(cursor) is a little farther away from where it needs to be. It often happens with longer words.
I have seen the problem when I had a much longer word. I didn't find a much longer word when reporting the issue so it is just a small demo.
To Reproduce
Steps to reproduce the behavior:

Go to the project or website
Select words, sentences, or anything that have a larger number of letters in a single word
Start typing letters for a longer word
See the error

Expected behavior
The caret should be at the beginning of the letter to be typed. It should be just after the typed letter and before the letter to be typed.
Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: 107.0.5304.107

Suggested solution
Use a monospace font-family to solve this bug.

I am already using monospace font family. Maybe it's time to dive into font related css


the above mentioned command set wont work because it is not with the service management module, please revisit

this is the steps to proceed with the management of the classic resources:
install-module Azure
import-module Azure
Add-AzureAccount
get-azuresubscription
select-azuresubscription
Import-Module 'C:\Program Files\WindowsPowerShell\Modules\Azure\5.1.1\Azure\Azure.psd1'
Import-Module 'C:\Program Files\WindowsPowerShell\Modules\Azure\5.1.1\ExpressRoute\ExpressRoute.psd1'
New-AzureDedicatedCircuitLink -ServiceKey "*****************************" -VNetName "MyVNet"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd590afe-cc06-47d3-9e72-c4521871fea8
Version Independent ID: 312e2931-8b60-0a67-93ae-ded13ab6c5bf
Content: ExpressRoute: Link a VNet to a circuit: classic
Content Source: articles/expressroute/expressroute-howto-linkvnet-classic.md
Service: expressroute
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@ghsober Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.

I will take this as a doc bug. Thanks! #please-close


Pass images between pages

Currently the pages are somewhat disjointed from each other. How can we pass the images between the pages, so that a user does not have to download / re-upload the image.
Another idea is if all the widges have a consistent interface, can we chain them together in any user-defined order?

We could use the query_params api to define custom pages based on a query. The benefit is that we just have a single page to define the blocks and another to render them. Users can easily share a persistent links to their dashboard with other users.

The query_params can also be used to share data between pages (e.g. the image data)

Given the increased complexity of the code I think this can no longer be achieved.


percentage with float number

Is it possible to set a float number in percent value instead an Integer?

No not now. I will implement this as soon as i have some free time.


Tag new release

Any chance of tagging a new release as it wasn't immediately obvious when I installed that I wasn't getting the latest version.
Adding "cpanel-lib": "git://github.com/vially/cpanel-lib.git#master" to my package.json fixed the problem, but it would be nice for a proper tagged release.
Thanks

Sure. I just pushed version 0.0.4 on npm, but please keep in mind that I haven't touched this package in a very long time and I have no idea if it still works as advertised.
Cheers!

Brilliant thanks.
Everything seems to be working as expected, although

Awesome. Good luck with your app!


Change of second when updating models leads to different updated_at values in db vs model instance

Laravel Version: v8.20.1
PHP Version: 7.4.13
Database Driver & Version: MariaDb 10.3.26

Description:
We run a rather large test suite very frequently (up to 50 times a day, each pipeline approximately 4000 tests, via paratest running in parallel).
In the past year more and more frequently we had an issue that our test would fail due to unexpected updated_at values coming from our API, vs what was in the DB. Retrying the pipeline mostly fixed the issue, so we put it off to some kind of weird race condition in our code, but have just found out that its in laravel itsself and are now able to reproduce / explain it.
I guess this does not happen often in 'real life' as the case only happens if you create and update a model just at the end of a second, and the update code in laravel runs in exactly the time when the second 'changes' to the next one. I'll walk you through it with an example:

you create a new model and save it. Your model has a specific updated_at value, and it matches the one in the db (lets assume its xxxx-xx-xx 00:00:01)
you take that model and change a property and save it (which causes an update). Lets assume this code is still running inside this first second after midnight, Laravel in performUpdate() of Model.php will indeed run 'updateTimestamps' however as it will set the same updated_at value as the model already has, its not considered 'dirty'.
Laravel proceeds (still in performUpdate method) to determine which fields are 'dirty' and sees that one ore more are
Lets assume that right at this moment (either just before or just after $dirty = $this->getDirty(); is called) the second changes to xxxx-xx-xx 00:00:02
Laravel proceeds to run $this->setKeysForSaveQuery($query)->update($dirty) which ends up using 'addUpdatedAtColumn' method. In there it will fetch a fresh timestamp via freshTimestampString() which now will result in a DB call saving xxxx-xx-xx 00:00:02 as the updated_at value, but our model in the code still has xxxx-xx-xx 00:00:01

I am aware that this is a very rare condition, but the amount of tests we're running, its happening to us nearly every day at least once.
Sadly currently we're not quite sure how to easily fix this without causing rats tail issues. Always considering updated_at as 'dirty' would be an option, could however cause other issues..
Steps To Reproduce:
Firstly to reproduce this condition you need to add a sleep(2) right before or right after $dirty = $this->getDirty(); in performUpdate method of laravels Model.php.
Anywhere do run like this (with a model that has timestamps enabled and has ids)
    $myModel = new SomeModel();
    $myModel->myattribute = 'x';
    $myModel->save();

    $myModel->myattribute = 'y';
    $myModel->save();

    dump((string)$myModel->updated_at);

    $myFreshModel = SomeModel::findOrFail($myModel->id);

    dump((string)$myFreshModel->updated_at);

This will show you 2 different timestamps. The one from the fresh model will (depending on when you run it) be either 1-3 seconds difference.

If your tests rely on timestamps (never a good idea), you have to control them.
The easiest way within Laravel models to use Carbon::setTestNow (or CarbonImmutable::setTestNow if that's your thing).
I've similar scenario, though a couple thousand more tests a lot of APIs (rest, GraphQL) but ever since using this, never had such issues.
HTH

If your tests rely on timestamps (never a good idea), you have to control them.
The easiest way within Laravel models to use Carbon::setTestNow (or CarbonImmutable::setTestNow if that's your thing).
I've similar scenario, though a couple thousand more tests a lot of APIs (rest, GraphQL) but ever since using this, never had such issues.
HTH

@mfn great tip, thank you, we'll look into if this is possible to encorporate into our test suites.
It however seems to me that this is a bug in laravel that would still need to be adressed, would you agree?

@mfn great tip, thank you, we'll look into if this is possible to encorporate into our test suites.
It however seems to me that this is a bug in laravel that would still need to be adressed, would you agree?

It however seems to me that this is a bug in laravel that would still need to be adressed, would you agree?

I've been using the ::setTestNow() since forever, since I basically never encountered this in tests.
I re-read your description once more:

Firstly to reproduce this condition you need to add a sleep(2) right before or right after $dirty = $this->getDirty(); in performUpdate method of laravels Model.php.
…
In there it will fetch a fresh timestamp via freshTimestampString() which now will result in a DB call saving xxxx-xx-xx 00:00:02 as the updated_at value, but our model in the code still has xxxx-xx-xx 00:00:01

Yes, I can reproduce this.

\Illuminate\Database\Eloquent\Model::performUpdate
calls
\Illuminate\Database\Eloquent\Builder::update
calls
\Illuminate\Database\Eloquent\Builder::addUpdatedAtColumn
which generates the value for the update_at column forthe database query only.
But this is never replicated back on the current model.

For this to work, \Illuminate\Database\Eloquent\Builder::update would be needed to be changed to:

get the column and it's updated timestamp value
write it to the model property
then pass it on to \Illuminate\Database\Eloquent\Builder::update

When I read the code correctly, \Illuminate\Database\Eloquent\Builder::update being also called from \Illuminate\Database\Eloquent\Builder::increment and \Illuminate\Database\Eloquent\Builder::decrement I think this also makes these methods suspects to this behaviour.
Whether it's a bug or not is probably debatable, the code does not read like "it's buggy", rather like it was simply implemented that way and that's that (just a guess). It's definitely a change in behaviour which will affect current code (albeit even implicitly) relying on this.

It however seems to me that this is a bug in laravel that would still need to be adressed, would you agree?

I've been using the ::setTestNow() since forever, since I basically never encountered this in tests.
I re-read your description once more:

Firstly to reproduce this condition you need to add a sleep(2) right before or right after $dirty = $this->getDirty(); in performUpdate method of laravels Model.php.
…
In there it will fetch a fresh timestamp via freshTimestampString() which now will result in a DB call saving xxxx-xx-xx 00:00:02 as the updated_at value, but our model in the code still has xxxx-xx-xx 00:00:01

Yes, I can reproduce this.

\Illuminate\Database\Eloquent\Model::performUpdate
calls
\Illuminate\Database\Eloquent\Builder::update
calls
\Illuminate\Database\Eloquent\Builder::addUpdatedAtColumn
which generates the value for the update_at column forthe database query only.
But this is never replicated back on the current model.

For this to work, \Illuminate\Database\Eloquent\Builder::update would be needed to be changed to:

get the column and it's updated timestamp value
write it to the model property
then pass it on to \Illuminate\Database\Eloquent\Builder::update

When I read the code correctly, \Illuminate\Database\Eloquent\Builder::update being also called from \Illuminate\Database\Eloquent\Builder::increment and \Illuminate\Database\Eloquent\Builder::decrement I think this also makes these methods suspects to this behaviour.
Whether it's a bug or not is probably debatable, the code does not read like "it's buggy", rather like it was simply implemented that way and that's that (just a guess). It's definitely a change in behaviour which will affect current code (albeit even implicitly) relying on this.

Thanks for the report. Since it's such an edge case atm we're not going to focus on fixing this ourselves but we do appreciate if someone could send in a PR. Most likely in a next major release.

Thanks for the report. Since it's such an edge case atm we're not going to focus on fixing this ourselves but we do appreciate if someone could send in a PR. Most likely in a next major release.

@driesvints I totally understand. Hope somebody else will chip in, and maybe we'll have some good idea coming up at some point. As its such a deep low-level code the chance to making things worse up is not insignificant.

@driesvints I totally understand. Hope somebody else will chip in, and maybe we'll have some good idea coming up at some point. As its such a deep low-level code the chance to making things worse up is not insignificant.

@mfn I can confirm that setTestNow circumvents this issue, and as you pointed out a good best practise to rely on in any case.
We put this into the setUp of TestCase (which is called for all our tests) and merely hat do exempt / reset this for 2 tests (out of thousands) that actually relied on having real timestamps (very specific rate-limit / lock timeout contract tests)
For anybody who is battling with this issue therefore this is a workaround or actually a best practice solution as @mfn pointed out. I'd like like to see this resolved eventually as i still believe it is a bug, however very low priority.

@mfn I can confirm that setTestNow circumvents this issue, and as you pointed out a good best practise to rely on in any case.
We put this into the setUp of TestCase (which is called for all our tests) and merely hat do exempt / reset this for 2 tests (out of thousands) that actually relied on having real timestamps (very specific rate-limit / lock timeout contract tests)
For anybody who is battling with this issue therefore this is a workaround or actually a best practice solution as @mfn pointed out. I'd like like to see this resolved eventually as i still believe it is a bug, however very low priority.

I think this we have a solid work around for this I will go ahead and close this as "wont fix" for now pending a more pressing reason for addressing it. Addressing it now may have unintended consequences.


feat: add options to support client tls

adding configuration properties:

coder.tlsCertFile
coder.tlsKeyFile
coder.tlsCaFile

fixes #126

@code-asher why might this fail?

Ah I think the certificate fixtures I generated expired, for some reason I just assumed they had no expiration if I never specified one but apparently there is a default.  I will change it to either generate them as part of the test or make the expiration really far in the future.


popover component development

Development of the Patternfly 4's Popover component for widgetastic
A popover has these elements to it:

Title
Body
Footer
Close button
Also, there is only one active popover on the page at a time.

LGTM

LGTM

@opacut please add some tests for this component.

@opacut please add some tests for this component.

@opacut please add some tests for this component.

done

@opacut please add some tests for this component.

done

@opacut please rebase

@opacut please rebase


Creating cached artifact hangs on InetAddress.getLocalHost()

In some cases (TBD) with Gradle 5.6.3 the build hangs for about 5 seconds while packaging the first cache artifacts. The behavior cannot be reproduced with Gradle 5.5.
Thread dump reveals that the packaging is not started because we are waiting for determining the local hostname:
"Execution worker for ':'" #573 prio=5 os_prio=31 tid=0x00007fc435d65800 nid=0x1473f runnable [0x000070000668b000]
   java.lang.Thread.State: RUNNABLE
        at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
        at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:929)
        at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1324)
        at java.net.InetAddress.getLocalHost(InetAddress.java:1501)
        - locked <0x00000003c007cb28> (a java.lang.Object)
        at org.gradle.caching.internal.origin.OriginMetadataFactory.determineHostName(OriginMetadataFactory.java:85)
        at org.gradle.caching.internal.origin.OriginMetadataFactory.access$300(OriginMetadataFactory.java:32)
        at org.gradle.caching.internal.origin.OriginMetadataFactory$1.execute(OriginMetadataFactory.java:74)
        at org.gradle.caching.internal.packaging.impl.TarBuildCacheEntryPacker.packMetadata(TarBuildCacheEntryPacker.java:129)
        at org.gradle.caching.internal.packaging.impl.TarBuildCacheEntryPacker.pack(TarBuildCacheEntryPacker.java:121)
        at org.gradle.caching.internal.packaging.impl.GZipBuildCacheEntryPacker.pack(GZipBuildCacheEntryPacker.java:42)
        at org.gradle.caching.internal.command.BuildCacheCommandFactory$StoreCommand.store(BuildCacheCommandFactory.java:173)

The problem was seen on macOS Mojave. It could be reproduced with both Oracle 1.8.0_211 and also 11.0.5.

cc: @gradle/build-cache

We did make some changes to how the origin metadata is put together in 5.6, calling InetAddress.getLocalHost().getHostName() directly instead of using InetAddressFactory. But only the effective difference I can see is that we used to run InetAddress.getLocalHost().getHostName() in a synchronized block, and we don't do it anymore.
That said, the problem can be reproduced when only a single task is being packages, i.e. there are no concurrent calls to InetAddress.getLocalHost().getHostName(), and synchronized should not make a difference.

Here's a build scan demonstrating the effect: https://customer-scans.grdev.net/s/6kjp7puty7flg

This is the root cause apparently: https://stackoverflow.com/questions/33289695/inetaddress-getlocalhost-slow-to-run-30-seconds

JDK bug: https://bugs.openjdk.java.net/browse/JDK-8143378

My best theory right now is that we still had this problem with Gradle 5.5 and earlier. The difference that brought the problem up with 5.6 is that we removed the synchronized block, thus we ran into this multiple times, and in such a case the bug actually results in much more severe (hence more noticeable) effects. For example, in a build scan with 16 concurrent workers the first 16 tasks took over a minute to complete because of this problem.
The workaround in the PR https://github.com/gradle/gradle/pull/11134 is to run hostname on macOS.

The problem that resolving localhost on macOS can take very long is not new and there is a known workaround: https://docs.gradle.com/enterprise/gradle-plugin/#macos-sierra-bug
It seems like the change in 5.6 did make the problem worse. Still, applying the workaround should make the problem go away, since the access is much faster.
Are you saying that the workaround doesn't help any more with macOS Mojave?

The workaround works as always. However, it is not trivial to notice that you need the workaround. Indeed, it seems that many has been suffering from this problem unknowingly.
In some environments the /etc/hosts workaround cannot be applied, e.g. when internal policies prevent users from applying it. But even when it can be applied it is hard to consistently apply it for everyone affected (including CI and engineers's computers); not in the least because it's hard to detect who needs the workaround in the first place.
We can fix this in a way that the user doesn't need to learn about and then fix the problem, so let's just do that.


Moving header files into include folders.

@coderkarl Awesome, thanks! I'll work on some CI tests tonight.

@coderkarl Thanks! I'll try to set up some CI tests tonight.


Buildings with a dimension of < 2 m are ignored

We determine heights by shrinking the footprints by 2 meters in order to avoid adjacent buildings. However this excludes 2,088 small buildings that become 1D when shrunk (they then have no intersection with the raster)
SELECT osm_id,
       geometry
       from osm_buildings, sf2014_bldg_height
       where st_intersects(rast, ST_Centroid(geometry)) and ST_SummaryStats(ST_Clip(rast,ST_Buffer(geometry,-2),true)) is null;

Examples:
http://www.openstreetmap.org/way/261451051
http://www.openstreetmap.org/way/262111842
I think it is an acceptable compromise to not tag these small buildings - many are potentially misidentified parts of larger buildings, and can be reviewed manually later

👍 , from the sample you provided, they are either backyard sheds or part of a larger building.  Ignoring them in the import make sense.

Using the new SF building data height, we don't need to do this. Closing.


Improve A11y support

Hi, I want to help with a PR for a11y - here are the things I would like to tackle:

Change getHandleProps to return by default: role ('slider'), aria-valuemin, aria-valuemax and aria-valuenow.
Change getHandleProps to not set tabindex and not set outline to none. Ideally, update the examples to use Buttons for handles (since they already are interactive elements and have a tab stop set by default).
Add support for keyboard navigation (When a handle is focused, the user should be able to use left/right arrows to change value)

Do you think these changes make sense for the library?

Absolutely! Go for it :)

PR: #17


wip

Adds the ability for the nodes in our package graph to be empty of data
but still have child nodes. Adds the ability to track deleted objects
when exporting workspaces. Import is currently unchanged and only
supports "modules", which are a closure of the state of the active
change_set+head for specific schema variants.

bors try

bors try

bors try

bors try

bors r+


Plugins: Load configuration before anything else?

This should be possible, imo, for further customization by users and developers.
        public List<string> Aliases {
            get {
                if (Plugin.Instance.Configuration.OverrideKitCommand)
                    return new List<String>() { "lo", "kit" };
                else
                    return new List<String>() { "lo", };
                }
            }

Also, is there a way to force plugin load order? (For the above mentioned OverrideKitCommand option)

Nope, not in Unity.


Revive models/tests/test_exchange_fees.py

Background
Github issue #1149 was to streamline fixed_rate_exchange.py. This was done, in commit https://github.com/oceanprotocol/ocean.py/commit/4da2ade35660d92b39d75710387f57cceb8c3c87.

It included: leveraging OO more for models/fixed_rate_exchange.py, to able to make the interface much cleaner.
And a small tweak was: rename the test modules to models/test/test_exchange_main.py & models/test/test_exchange_fees.py.

However, I wasn't able to properly test and debug test_exchange_fees.py.

I kept hitting barge#339 "Upgrade to latest Ganache. Why: older Ganache has a bug which delays chain update on tx, which breaks unit tests"
So I put a pytest.mark.skip() at its top

TODO

Pre-requisite: barge # 339 is done.
[ ] Create a branch / PR. In the PR, revive test_exchange_fees.py. Un-skip the test.
[ ] Fix pytest fixture names. Including "datatoken" -> "DT", then inside the body have "dt = DT". And maybe more.
[ ] Running locally, iterate on it until it passes. There may be other tweaks needed.
[ ] Ensure remote CI passes. Merge

Questions
I found that when moving "test datatoken enterprise" to new clean exchange interface, it assumed 18 decimal places, and that was the only way that the test would work.
Is that perhaps also a similar thing here?
(Perhaps not, because at least some tests were passing when the delay was introduced)

closed with https://github.com/oceanprotocol/ocean.py/pull/1193


VSCode Xdebug Configuration

Question
I'm using vscode and am not sure where the xdebug configuration in the readme should go. is this a settings json block in the .vscode folder or does this belong somewhere else in the project?
Additional context
This is the settings block in question:
To use Xdebug with VSCode install the PHP Debug extension and use the following configuration:

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for Xdebug",
            "type": "php",
            "request": "launch",
            "port": 9001,
            "log": true,
            "externalConsole": false,
            "pathMappings": {
                "/var/www/project/cms": "${workspaceRoot}/cms"
            },
            "ignore": ["**/vendor/**/*.php"]
        }
    ]
}

mmmmm I'm not sure unfortunately, as I use PhpStorm... but I see that port setting is wrong, it should be 9003 now; I've fixed it  -- perhaps @urbantrout can help?

The configuration needs to be saved in .vscode/launch.json
The port should match xdebug.remote_port as seen here: https://github.com/nystudio107/craft/blob/70879cf3016495deb34b583da105424a81b0d108/docker-config/php-dev-base/xdebug.ini#L3


[loc][Query] Possible typo in source

Hi, we have a question from our translator. Can you help please? Thanks!
Source:
Select the default behaviour of InAppBrowser when opening using the _blank target
Open in a new window: _system target
File available here:
[https://github.com/Microsoft/cordova-simulate/blob/6ad0bd9bae9c78418db484e4796a4e04883659ef/tools/i18n/xliff/ru.xlf]
Query:
The word "target" seems to be out of place. Is this a typo? If not, can you please clarify how connects to the rest of the sentence? Thank you!

This string does not appear to be in our sources.

Hi, yes, sorry, I pasted this to the wrong place. closing the bug


[stringref-upgrade] Change FrontendInputsAndOutputs::numberOfPrimaryI…

…nputsEndingWith to take a StringRef instead of a const char *.
This is in prepration for changing Strings.h to use StringLiteral.

@swift-ci smoke test and merge


Update workflow options for cromwell gcs batch

As far as I can tell, this is undocumented, but found by trawling around the Cromwell source: https://github.com/broadinstitute/cromwell/blob/c8d36d5c7df25f79e87ea5f6373ab5ee1556a6fb/supportedBackends/google/batch/src/main/scala/cromwell/backend/google/batch/models/GcpBatchWorkflowPaths.scala#L20

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.67%. Comparing base (e0937ea) to head (71ff606).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   46.28%   46.67%   +0.39%
==========================================
  Files          15       15
  Lines        1452     1459       +7
==========================================
+ Hits          672      681       +9
+ Misses        780      778       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: Add error handling for incorrect destination configuration in HttpClientWrapper

Pull Request Description 🤖
This PR addresses the backlog item #320 and introduces a new feature to the HttpClientWrapper class in the connectivity-apache-httpclient4 module.
Changes
The changes in this PR include:

A new block of code in the HttpClientWrapper constructor that checks if the destination is configured correctly. If the destination is not configured correctly, it throws a DestinationAccessException with an appropriate error message.

The new block of code checks if the destination's PROXY_TYPE is ON_PREMISE and if the PROXY_HOST is empty. If these conditions are met, it further checks if the TENANT_ID is empty (indicating a provider) and if the AUTH_TYPE (or AUTH_TYPE_FALLBACK) is BASIC_AUTHENTICATION. If these conditions are met, it throws a DestinationAccessException with the message "Accessing an onpremise system on behalf of the provider tenant explicitly is currently not supported." Otherwise, it throws a DestinationAccessException with the message "Unable to resolve connectivity service binding."
Context
This change is part of the effort to migrate the DwC Spring E2E Test, as described in the backlog item. The new feature ensures that the destination is configured correctly before attempting to establish a connection, which helps prevent errors during runtime.
Reviewer Instructions
Please review the changes in the context of the associated backlog item. Pay particular attention to the new error handling code and ensure that it aligns with the expected behavior described in the backlog item.

I agree, the two different use cases (reading properties and using the destination) for the same class is a design flaw. But with the timeframe that we have to release v4, I would accept it as tech debt and have usable exceptions messages.
@Johannes-Schneider Do you think the latest commit is better than storing the exception?


Create own tool to change subsystem

created https://github.com/feel-the-dz3n/wcecl/commit/b3aee9a6a0d8f567c4b52025e188b21c12c69e51

created b3aee9a

https://discord.gg/u74Pk5e