@angular-devkit/build-angular v0.803.5 increased the bundle size!

🐞 Bug report
Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
Yes, the previous version in which this bug was not present was: @angular-devkit/build-angular: 0.802.2
Description
I have updated Angular packages versions 8.2.2 to 8.2.7 and @angular-devkit/build-angular 0.802.2 to 0.803.5. Then I built the project with production configuration. My bundle size increased ~700kb. I recorded a video..
I have Angular NPM libraries. I load these modules lazily via a wrapper module.
My lazy load technique shown below:
app-routing.module.ts:
  {
    path: 'account',
    loadChildren: () => import('./lazy-libs/account-wrapper.module').then(m => m.AccountWrapperModule),
  },

account-wrapper.module.ts:
import { NgModule } from '@angular/core';
import { AccountModule } from<EMAIL_ADDRESS>
@NgModule({
  imports: [AccountModule],
})
export class AccountWrapperModule {}

🌍 My Environment

Angular CLI: 8.3.5
Node: 10.16.0
OS: darwin x64
Angular: 8.2.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.5
@angular-devkit/build-angular     0.803.5
@angular-devkit/build-optimizer   0.803.5
@angular-devkit/build-webpack     0.803.5
@angular-devkit/core              8.3.5
@angular-devkit/schematics        8.3.5
@angular/cdk                      8.2.0
@angular/cli                      8.3.5
@ngtools/webpack                  8.3.5
@schematics/angular               8.3.5
@schematics/update                0.803.5
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

Duplicate of #15425
Please check the actual on disk sizes.  This is a display issue only.

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

I added.


Presence detection in the dark

Hi, I just found your great app and is playing around with all the options. Not yet familiar with everything, so please let me know if I missed an existing option.
The motion detection can be great to turn on the screen and even a light when it is dark. The problem is that it is not working in the dark.
My suggestion to assist with this, is a presence detection with the following two triggers:

Screen touched
Sound/Voice detected

Your kind consideration will be appreciated.

The app already can "wake" from screensaver mode when the screen is touched.


Fix artifacts in gosec target

What this PR does / why we need it:
Moves the junit file to correct directory.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
"NONE"

/pull pull-kubevirt-gosec

/test pull-kubevirt-gosec

/lgtm
/approve


Change core manifests from Pod to Deployment

In manifests/*.yaml.in we have a few cluster wide services which are currently depoyed as Pod. Changing  them to Deployments has the benefit that they survive restarts in our vagrant setup.
Services to change are:

[ ] squid proxy (squid.yaml.in)
[ ] haproxy (haproxy.yaml.in)
[ ] virt-api (virt-api.yaml.in)
[ ] virt-controller (virt-controller.yaml.in)

Hey @rmohr, I will take this on me if you agree.

@RikTheunis Of course. Will be happy if you take it.
Make sure to check out the Getting Started Guide, if you didn't already.
Let me know if you need something.

fixed by #126


Add bounding sphere info to the mesh.

Adds bounding sphere info for the mesh.  This bounding sphere is based
on the bounding box that we're already using for frustum culling.  As
such, the sphere will likely be a little larger than necessary, but will
be accurate enough for now.
The bounding sphere (at least the center of it) will be used in upcoming
check-ins dealing with transparency sorting, and LOD.
GearVRf-DCO-1.0-Signed-off-by: Tom Flynn
<EMAIL_ADDRESS>

Looks good to me. Will test tmr. The only weird case I can think of is if you have a sphere, the bounding sphere's radius will be sqrt(2) times as original one. But should be ok in most of cases.

Correct.  I really just need the center for the next few check-ins.  We can revisit making this a tighter sphere later.  We at least have a placeholder for now.

Codes look okay for me. Just a question, are you planning to replace the bounding box with this sphere, or make it selective, including in the case of frustum culling?

That's much further down the line.  We'll need tighter bounding spheres for culling.  We'll also need to make sure the bounding volume (sphere or box) encompasses all its children for proper frustum culling.  That's all more work that I'm not trying to tackle at the moment :)


Fix a NPE using kafka emitter extension

I found this exception when using kafka emitter according to doc kafka-emitter.
It said "druid.emitter.kafka.producer.config" is not required, so I didn't set it. As a result I got an NPE exception when starting up my overlord.

@wywlds thanks can you please fill the CLA http://druid.io/community/cla.html

@b-slim Hi, I already filled the form when I created a pull-request last weekend.

👍


Make sure the compile order situation is clear in the documentation

MixedAnalyzingCompiler (which I believe is the default compiler used) doesn't distinguish the behaviour between ScalaThenJava and Mixed.
See #234 for the previous discussion around this.
We should try and make this clear, by changing the docs.
Even better would be to make it obvious by removing one or the other. But that involves deprecation cycles, so lets make it clear for now.

Thanks for filing this per our previous discussion Dale!

I'm already working on documenting this part of the API.

The current documentation says that Mixed mode allows Scala sources to depend on Java sources and allows Java sources to depend on Scala sources.
It happens that ScalaThenJava fits the mixed semantics correctly thanks to Scalac (and Dotty, in the future). The Scala compiler will parse any Java source and populate the symbol table (therefore allowing Scala sources to depend on Java sources), and then after Scala has generated the class files, Zinc will invoke javac with those generated class files in the classpath (therefore allowing Java to depend on Scala). However, the fact that Scalac works this way is just a design decision, and this is an implementation detail of the compiler that could change in the future.
Because of this, I suggest that we don't remove Mixed, we should only improve documentation and make the situation clearer. To be honest, I think that keeping Mixed is good for the end user, because ScalaThenJava has a very clear meaning, and people may end up now knowing that it covers the case of Mixed. What should we do?

Okay, after giving it some more thought: it makes sense to leave Mixed because it has a conceptual difference regarding ScalaThenJava. The difference would come in the way Zinc handles the options passes to the Scala compiler. Under Mixed you would pass both Scala and Java sources, while under ScalaThenJava you would only pass Scala sources and leave the Java sources to be compiled by the Java compiler.
This whole discussion boils down to the fact that the implementation here is the same for both. But to my understanding Zinc is applying the logic described in the previous paragraph before arriving to the MixedAnalyzingCompiler, so we're safe.

In the PR fixing the binary API that I'm currently working on, I've written this documentation:
/*
 * Zinc - The incremental compiler for Scala.
 * Copyright 2011 - 2017, Lightbend, Inc.
 * Copyright 2008 - 2010, Mark Harrah
 * This software is released under the terms written in LICENSE.
 */

package xsbti.compile;

/**
 * Define the order in which Scala and Java compilation should happen.
 *
 * This compilation order matters when the sources to be compiled are both
 * Scala and Java sources, in which case the Zinc compiler needs a strategy
 * to deal with the compilation order. Therefore, this setting has no effect
 * if only Java or Scala sources are being compiled.
 */
public enum CompileOrder {
	/**
	 * Allow Scala sources to depend on Java sources and allow Java sources to
	 * depend on Scala sources.
     *
	 * Under this mode, both Java and Scala sources can depend on each other.
	 * Java sources are also passed to the Scala compiler, which parses them,
	 * populates the symbol table and lifts them to Scala trees without
	 * generating class files for the Java trees.
	 *
	 * Then, the incremental compiler will add the generated Scala class files
	 * to the classpath of the Java compiler so that Java sources can depend
	 * on Scala sources.
     *
	 * For more information on the way Mixed and ScalaThenJava mode behave,
	 * see this link.
	 */
	Mixed,

	/**
	 * Allow Scala sources to depend on the Java sources, but it does not allow
	 * Java sources to depend on Scala sources.
     *
	 * When mixed compilation is not required, it's generally more efficient
	 * {@link CompileOrder#JavaThenScala} than {@link CompileOrder#ScalaThenJava}
	 * because the Scala compiler will not parse Java sources, it will just
	 * unpickle the symbol information from class files.
	 */
	JavaThenScala,

	/**
     * Allow Java sources to depend on Scala sources, but it does not allow Java
	 * sources to depend on Scala sources.
     *
     * Because of the way the Scala compiler works with regard to Java sources,
	 * Zinc has to enforce this mode by removing Java sources from the actual
	 * source arguments that are passed to the Scala compiler, otherwise it'll
	 * behave exactly as {@link CompileOrder#Mixed}.
	 *
	 * For more information on the way Mixed and ScalaThenJava mode behave,
	 * see this link.
	 */
	ScalaThenJava
}

The existing docs are (non-obviously) wrong (copy-paste):
https://github.com/sbt/sbt/blob/v0.13.13/interface/src/main/java/xsbti/compile/CompileOrder.java
Yet people have opted into specific settings:
https://github.com/search?l=Scala&q=compileOrder&type=Code&utf8=✓
(https://github.com/sbt/sbt/commit/03ba47c58c6dad710f66e72e4c7c7b73d9b12bf7#commitcomment-1014692 :D)

 * When mixed compilation is not required, it's generally more efficient
 * {@link CompileOrder#JavaThenScala} than {@link CompileOrder#ScalaThenJava}
 * because the Scala compiler will not parse Java sources, it will just
 * unpickle the symbol information from class files.

Is it faster to unpickle than parse?

WRT everything you said @jvican: I agree, LGTM, and good work.

Yes, it's faster because of two things: you don't waste memory to store Java trees, and unpickling is lazy, so if you only use Java symbols you will ignore the unused symbols and not execute them.
In any case, that remark was already there when I arrived. Happy to be convinced otherwise, but that's my justification of why it's faster. I'm not an expert in this area.

This was already merged long time ago, so closing.


Issue with 'Convert Label' Functionality

I'm encountering an issue with the "Convert Label" functionality and I'm not sure if it's a bug or if I'm missing something in its usage. I get the following error message:
[{"type":"enum","loc":["path","action"],"msg":"Input should be 'delete', 'add' or 'update'","input":"rename","ctx":{"expected":"'delete', 'add' or 'update'"}},{"type":"missing","loc":["query","label"],"msg":"Field required","input":null}]

Error in the API. Thanks :)


"ERROR: Assert `port.addr[j] == State::S0' failed" when in Verific mode

Steps to reproduce the issue
Use the 'shared_ports' test-case from YosysHQ tests 'tests/memories/shared_ports.v' (https://github.com/YosysHQ/yosys/blob/master/tests/memories/shared_ports.v)
read -sv shared_ports.v
hierarchy -check -top test
proc
opt_clean
memory -nomap

Yosys 0.12+30 (git sha1 ed4642e18, clang 10.0.0-4ubuntu1 -fPIC -Os)
Expected behavior
The test should run without any assertion like in case with 'read_verilog' command:
read_verilog -sv shared_ports.v
hierarchy -check -top test
proc
opt_clean
memory -nomap

Actual behavior
The test fails during MEMORY_SHARE pass with the following assertion.
ERROR: Assert `port.addr[j] == State::S0' failed in kernel/mem.cc:488.

Please contact<EMAIL_ADDRESS>for YosysHQ’s commercial support, since this concerns an issue involving non-open-source components only included in Tabby CAD Suite.

this is a memory_share bug, reproducible without Verific:
module test (...);

input [7:1] wa1;
input [7:1] wa2;
input [7:0] ra;
output [7:0] rd;
input clk;
input we1, we2;
input [15:0] wd1, wd2;

reg [7:0] mem [0:255];

assign rd = mem[ra];

always @(posedge clk) begin
        if (we1) begin
                mem[{wa1, 1'b0}] <= wd1[7:0];
                mem[{wa1, 1'b1}] <= wd1[15:8];
        end else begin
                mem[{wa2, 1'b0}] <= wd2[7:0];
                mem[{wa2, 1'b1}] <= wd2[15:8];
        end
end

endmodule

yosys -p 'hierachy -top test; proc; opt; memory_share'


How to remove the desktopHCP module?

In .desktop/settings.json, if I set "desktopHCP":  false, it complains that I need to remove the desktopHCP module and does not build.
How do I remove the desktopHCP module? Where is it?

This should not happen - I mean you should not have any problem with building.
Can you paste the message you are getting?

Oh wait, you mean that building with -b fails?
If so do
meteor remove omega:meteor-desktop-watcher omega:meteor-desktop-bundler

This will be handled automatically in 1.0

This was released quite some time ago.


how to define num_iter?

hi davidtvs,
when use lr find, I find the loss curve is a little different when use different num_iter.
for example, image num is 6700, batch size is 252, when use num_iter=27, the loss decreases obviouslyfrom 1e-4 to 1e-3, but when num_iter =270, it decreases obviously from 1e-4 to 5e-4,when num_iter=540, it decreases obviously from 1e-4 to 8e-4, so , I am not sure which loss is correct?
@davidtvs
Thanks! it is a really good tool

Hi @jorie-peng. It should depend on your decision. The greater num_iter is given, the finer scales of lr-loss curve you can get (but it also takes longer to run range_test).
In your case, when num_iter is increased from 27 to 270, the scale of lr-loss curve will be 10x finer. And that's why the range of lr candidates is shortened.
As to pick a proper lr, there is no a single rule can be used to determine which lr is correct or the best by just running range_test. We usually have to apply some hyper-parameter searching algorithms to optimize it, e.g. bayesian optimization, hyperband...
However, we can still find out the possible lr that could make model be trained better. Since we know that loss will decrease obviously in some range, we can speculate that lr in that range would be a proper one to train a model easier. And here are a few approaches which are the most often used:

the steepest point in lr-loss curve
find the global minimum (lr_min) of the lr-loss curve, then lr_min/10. is the one to use

You can check out this comment if you are interesting in this topic.

Thanks for your quick answer! Finding a proper lr is really a hard work. I will try your suggestion. Thanks again

Hello
Thanks for contributing to this project.
I think that how to decide the min & max values of LR from the loss-lr curve should be explained in README.

@rose-jinyang, in the README it is briefly explained how the original author of the paper advises doing the LR selection. Quoting from the README:

the author advises the point at which the loss starts descending and the point at which the loss stops descending or becomes ragged for start_lr and end_lr respectively.  In the plot below, start_lr = 0.0002 and end_lr=0.2.

Here start_lr and end_lr correspond to the min and max values of the learning rate for a cyclical scheduler.

Thanks for your quick reply.


Update OUT_DIR diagnostic to match setting

The setting was renamed, so the diagnostic should follow
bors r+

changelog skip


Upgrade to antd v4

The version 3.x doesn't support code-splitting very well. Due to that, the bundle is unnecessarily big.
v4 version supports virtualized lists which would be useful for example for select inputs.

This depends on resolving @ackee/mateus package in #62 and #47, because there are Antd 3 bindings in mateus.

The team agreed on removing @ackee/mateus and antd dependencies completely (they should be installed per project). auth module can use simple html fields for now.


U8G2 is 2x streched in Y axis?!

Hi, great work! But I have one problem, my SSD1306 displays everything almost 2x streched on y axis with your implementation. Other (less powerful and only driver related) idf components do work as intended...

Did not init with the right function, nvm


Same method queryRPC defined twice in api.js?

I am also having this issue

Yeah it's been a week nobody cares...

@mgao6767 we do care, the problem is the time and size constraints.. why you don`t contribute a PR to fis that ?

@canesin Honestly I knew nothing about Java, so that's why I asked why, in case it's intentionally like that. But the issue is unanswered for a while so...
If the only thing needed is to simply remove the duplicate then sure I'll submit a PR shortly. Thanks!


incorrect parent GO:0008137

@pgaudet
https://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0008137
GO:0008137   NADH dehydrogenase (ubiquinone) activity
has ancestry to transmembrane transport?

See discussion here: #21275
I dont find this really intuitive...

No this one always gets me.


fetchmail: 6.4.27 -> 6.4.28

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fetchmail/versions.
meta.description for fetchmail is: "A full-featured remote-mail retrieval and forwarding utility"
meta.homepage for fetchmail is: "https://www.fetchmail.info/"
meta.changelog for fetchmail is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28/bin/fetchmail had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28/bin/fetchmailconf had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 6.4.28 with grep in /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28
found 6.4.28 in filename of file in /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
fetchmail

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A fetchmail https://github.com/r-ryantm/nixpkgs/archive/e888469fd396bfe2654e7a13ad5f3fb4ce8737ee.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28
ls -la /nix/store/qbdh1brn1ckhgas8fbd41hpm36c9z1zv-fetchmail-6.4.28/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

fetchmail

Maintainer pings

6.4.29 is now available on Sourceforge


Colour contrast for borders on form elements

We currently recommend using $grey-2 (1.81:1 contrast) for borders on form elements. It has been suggested that the contrast is not sufficient and that the 1px border width is too thin.
Propose changing this to $grey-1  (4.56:1 contrast) for borders and increasing the border width to 2px.
A pull request for this change can be found in #104.
Awaiting feedback from Edward Horsford @edwardhorsford  at passports (in user research 12/10/15) and Simon Wilson from Inheritance Tax.

For reference, here's what it will look like:

The current border style:

With a darker colour and thicker border:

Having spoken to @aduggin about this, he recommended that colour contrast for the border should pass AAA for large text, which it does.
Using $grey-1 (#6F777B) for the border.
Foreground: #6F777B - Background: #FFFFFF
The contrast ratio is: 4.56:1
Text passed at level AA
Text failed at level AAA
Large text passed at level AA
Large text passed at level AAA
1.4.3 Contrast (Minimum):  Text (and images of text) have a contrast ratio of at least 4.5:1, except if the text is pure decoration.  Larger scale text (at least 18 point or 14 point bold) or images of text can have a contrast ratio of 3:1. (Level AA)
1.4.6 Contrast (Enhanced): Text (and images of text) have a contrast ratio of at least 7:1, except if the text is pure decoration.  Larger scale text (at least 18 point or 14 point bold) or images of text can have a contrast ratio of 4.5:1. (Level AAA)
If everyone is in agreement about this, i'll merge #104 and close this issue.
@aduggin, @timpaul, @edwardhorsford.

I have no complaint with this, though will reiterate that it's so close to our text colour that it could just be our text colour.
As it stands it's still an improvement, so I support this change.

I agree with Ed on this.
(My concerns are about adding strong borders to the hint for clickable area around radio buttons and checkboxes - a different matter)

Closing this issue, as #104 has been merged.


Feat: Recorder widget

Description

First MVP of the widget
Fixes #3912

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Test A
Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/3912-voice-recorder-audio-player-widget

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.61 (-0.3)
36.69 (-0.1)
33.5 (-0.13)
55.17 (-0.28)

:sparkles: :new:
app/client/src/components/designSystems/appsmith/RecorderComponent.tsx
13.36
15.56
6.98
15.42

:green_circle:
app/client/src/icons/WidgetIcons.tsx
95.31 (0.15)
100 (0)
90.32 (0.32)
95.31 (0.15)

:red_circle:
app/client/src/utils/WidgetRegistry.tsx
79.82 (-0.36)
100 (0)
39.47 (-1.07)
79.82 (-0.36)

:sparkles: :new:
app/client/src/widgets/RecorderWidget.tsx
45
0
42.86
44.74

@wmdev0808 Looks awesome on the first attempt! :D
Just a few things to note:

The orange is not there in color dropdown control.
The icon size of the default state and recording states are different for the orange button. ( i think the sizes are the same but they look too big for pause and recording icon. 40% size looks good to me but that does not look good for the mic icon.
can you make the icons for stop and discard from 16 to 20?
Can you add expanding animation on the orange light border? ( sorry I missed in the developer handoff )
Also, can you remove the border from the orange icon? I see there is some border on the icon button.

Overall, its looking great in the first attempt already. Super work Paul!

@somangshu  @wmdev0808  LGTM!

@wmdev0808 @jsartisan - Tested this feature and please find the observations below,

There is no file type extension related to audio file to download the saved file

If the browser permission is disabled for recording - Then the following message should be displayed as per figma - 'Permission not given'
Suggestion - Instead of showing 'Permission not given' if the permission for recording is disabled can we enable the recording icon so that whenever user clicks on recording any alert message can be disabled to enable the permission - similar to location enable in maps

when the recorder widget is disabled and when the user clicks on the widget the property pane opens

https://www.loom.com/share/8a2c4ebd0b624b60845642d848f197bf

When an recorder widget which has recording saved and copy pasted the saved recording is not available in the copied widget

@wmdev0808 Raised separate issue for point 1 - #6958
Issues Fixed:
2
Agreed on comments for issues 3 & 4
New issues:
5.When an recorded audio is re-played and clicking on stop button resets the widget to original mode
https://loom.com/share/45241f5305eb4361bc8f6e5f62879d5c

When recording is started and enabling the disable option - It is observed that the recording is still happening and the stop and discard button is accessible

https://loom.com/share/ada82f37d6b44964ab0bf253b769d7f3

@wmdev0808 Raised separate issue for point 1 - #6958
Issues Fixed:
2
Agreed on comments for issues 3 & 4
New issues:
5.When an recorded audio is re-played and clicking on stop button resets the widget to original mode
https://loom.com/share/45241f5305eb4361bc8f6e5f62879d5c

When recording is started and enabling the disable option - It is observed that the recording is still happening and the stop and discard button is accessible

https://loom.com/share/ada82f37d6b44964ab0bf253b769d7f3

@YogeshJayaseelan and @jsartisan,
5: it is the normal action from the requirements, because we can go to the first step from saved state by clicking on the left recording button or clicking on stop button.
6: What's the appropriate action exactly for this scenario?

@YogeshJayaseelan point 6 is invalid, the user does not have the choice to disable the widget from the property pane, Plus for an ongoing recording a disable state seems invalid, The state needs to be available before the action is taken.
@wmdev0808 I think point 5 valid. Seems like an inconsistency in the behaviour. For the first time the recording is stopped, But in the second time the widget is reset to the original state. The original state should only show up on click of the big check mark. Additionally we can remove the stop icon from this state. We only need pause and play actions. Let me know what you think

@YogeshJayaseelan point 6 is invalid, the user does not have the choice to disable the widget from the property pane, Plus for an ongoing recording a disable state seems invalid, The state needs to be available before the action is taken.
@wmdev0808 I think point 5 valid. Seems like an inconsistency in the behaviour. For the first time the recording is stopped, But in the second time the widget is reset to the original state. The original state should only show up on click of the big check mark. Additionally we can remove the stop icon from this state. We only need pause and play actions. Let me know what you think

@somangshu I agree with you. I will make changes

@somangshu would need a way to expose the recorded audio in a format that is accepted by our APIs/Query. I'll be checking this. will get back to you.

@wmdev0808 Verified the fix for 5th point and the issue still exists and please find the steps below
Record an audio and click on stop and click on tick mark icon to save the recordings and re-play the saved audio and click on pause the stop button will be displayed and click on stop button the widget resets to original mode.
https://loom.com/share/10e151ff321a4049b273f74ef17d48dc

@wmdev0808 can you add a derived property url on thewidget
url: `{{URL.createObjectURL(this.value)}}`,

@wmdev0808 @somangshu Issue 6 - The canvas breaks by default and unable to proceed testing audio widget
https://www.loom.com/share/455a3939aeab4743872f96651889b7a0

@YogeshJayaseelan you might be having a widget in this app which does not exist in the DP, Please remove all the widgets from the sidebar and try again=

@somangshu Initially i tried with existing app which has audio widget and that didn't work so again i tried creating new app in the DP and facing the same issue in new app which doesn't have any widgets

@YogeshJayaseelan I saw a similar error, This was something to do with the derivedProperties and evaluations, Could be a merge required in the branch, However once I delete the widgets I dont see the error anymore. Regardless, @wmdev0808 there is a merge conflict, Can we resolve that and see if that fixes the above problem

@wmdev0808 Verified the fix for issue 5 & 6 and they are working as expected


Metric names do not comply with prometheus standards and buckets sizes are not configurable

i know this is on the road map. I just wanted to get an issue in place for the PR I'm likely to submit next week to fix some or all of the following metrics:
hystrix_command_error_total
hystrix_command_event_total
hystrix_command_latency_execute_seconds_bucket
hystrix_command_latency_execute_seconds_count
hystrix_command_latency_execute_seconds_sum
hystrix_command_latency_total_seconds_bucket
hystrix_command_latency_total_seconds_count
hystrix_command_latency_total_seconds_sum
hystrix_thread_pool_completed_task_count
hystrix_thread_pool_count_threads_executed
hystrix_thread_pool_largest_pool_size
hystrix_thread_pool_queue_size
hystrix_thread_pool_rolling_count_threads_executed
hystrix_thread_pool_rolling_max_active_threads
hystrix_thread_pool_thread_active_count
hystrix_thread_pool_total_task_count

Thanks for taking on this talk. I've put it on the road map, but I welcome any PR to work on this.
Before you start a PR, could we first agree on the new names for the metrics? I tried to improve the hystrix_command_* metrics in the previous release - let me know what I missed there.
In the hystrix_thread_* metrics I haven't put any thought or effort in yet.
For the sake of compatibility: please only add new metrics and mark the old ones deprecated. All deprecated metrics will be removed in the first 4.x release (but that will require all metrics to comply with prometheus metrics and to be stable)

OK...here's my proposal. I don't 100% understand all the metrics or all of premetheus' requirements, so it's partially a stab in the dark.
hystrix_command_error_total
hystrix_command_event_total

becomes
hystrix_command_total{type="error"}
hystrix_command_total{type="total"}

hystrix_command_latency_execute_seconds_bucket
hystrix_command_latency_execute_seconds_count
hystrix_command_latency_execute_seconds_sum

becomes
hystrix_command_latency_execute_seconds{command_type="bucket"}
hystrix_command_latency_execute_seconds{command_type="count"}
hystrix_command_latency_execute_seconds{command_type ="sum"}

hystrix_command_latency_total_seconds_bucket
hystrix_command_latency_total_seconds_count
hystrix_command_latency_total_seconds_sum

becomes
hystrix_command_latency_seconds_total{type="bucket"}
hystrix_command_latency_seconds_total{type="count"}
hystrix_command_latency_seconds_total{type="sum"}

hystrix_thread_pool_completed_task_count
hystrix_thread_pool_count_threads_executed
hystrix_thread_pool_thread_active_count
hystrix_thread_pool_total_task_count

becomes
hystrix_thread_count{thread_type="completed_task"}
hystrix_thread_count{thread_type="threads_executed"}
hystrix_thread_count{thread_type="thread_active"}
hystrix_thread_count{thread_type="total_task"}

hystrix_thread_pool_rolling_count_threads_executed
hystrix_thread_pool_rolling_max_active_threads

becomes
hystrix_thread_rolling_count{thread_type="threads_executed"}
hystrix_thread_rolling_max{thread_type="active_threads"}

hystrix_thread_pool_largest_pool_size
hystrix_thread_pool_queue_size

becomes
hystrix_thread_pool_size{type="largest_pool"}
hystrix_thread_pool_size{type="queue"}

This brings up the question of whether these should be combined better and what exactly the difference is between a count and a sum:
hystrix_command_latency_execute_seconds{command_type="bucket"}
hystrix_command_latency_execute_seconds{command_type="count"}
hystrix_command_latency_execute_seconds{command_type ="sum"}
hystrix_command_latency_seconds_total{type="bucket"}
hystrix_command_latency_seconds_total{type="count"}
hystrix_command_latency_seconds_total{type="sum"}

The best practices for naming are listed here: https://prometheus.io/docs/practices/naming/
Regarding hystrix_command_error_total/hystrix_command_error_total vs. hystrix_command_total{type="error"}/hystrix_command_total{type="total"}
The rule to apply is "[E]ither the sum() or the avg() over all dimensions of a given metric should be meaningful (though not necessarily useful). If it is not meaningful, split the data up into multiple metrics." -> you can't sum up errors and totals. Therefore I keep them as separate metrics.
Several Metrics with bucket/sum/count at the end
This is the standard metric names of a histogram and it is coded into the prometheus client (in fact all histograms for all languages have them). Therefore I keep them as they are. "sum" is the time used for all executions. "count" is the number of executions. You can use the two numbers to calculate the average execution time.
Several hystrix_thread_pool_... metrics
The rule of sum()/avg() applies here as well. I doubt that we can use labels here. But the names can certainly be improved. I love counters a lot, but not everything can be captured by a counter. The all-time-max or even rolling-max values are unfamiliar in Prometheus metrics, but very helpful in Hystrix world, as peaks would otherwise be missed.
Do you want to give it another go for the hystrix_thread_pool_... metrics?

I can take another go at it. Are there any metrics you think could be combined using labels? Our Prometheus admins are complaining that the bucket metrics alone are creating too many series, so maybe I'm going about this the wrong way.

Between hystrix_command_latency_execute_seconds_bucket{} and hystrix_command_latency_total_seconds_bucket{} we've generated 500k+ time series in < 12 hours

For these metrics:
hystrix_thread_pool_completed_task_count
hystrix_thread_pool_total_task_count

hystrix_thread_pool_thread_active_count
hystrix_thread_pool_count_threads_executed

The bare minimum to comply with the standards would be simply to make sure count is at the end for each metric (only one affected):
hystrix_thread_pool_thread_active_count

My understanding of Prometheus is that it doesn't matter if you use labels or not, as the metric name plus all label values will define the time series.
Example: if you have metric_a and metric_b or metric{label="a"} and metric{label="b"}, this will be two time series in the sense of Prometheus.
So conversion between the name and labels will not reduce the number of time series.
I'll do a sample calculation here (your case will most likely be different):
Today a hystrix_command_latency_total_seconds_bucket will have 31 time series per command. As there is also hystrix_command_latency_execute_seconds_bucket, this will give you 62 time series per command for both of them.
If you have 100 commands in your application, you will get 6200 time series for the buckets.
If you have 20 instances of your application running in parallel, you will get 124000 time series.
If you are re-deploying your application 4 times within 12 hours for example on a kubernetes cluster, you will get a different instance name every time. Each of them will provide its metrics as a different time series: 4x 124000 = 496000 time series.
To reduce the number of time series there are different options using all the factors above - not all of them might be options, and they have drawbacks:

drop some metrics by adjusting the Prometheus Scraping configuration using rewrite rules (you can choose to keep just hystrix_command_latency_total_seconds_bucket and drop hystrix_command_latency_execute_seconds_bucket for example)
reduce the number of commands in your application
use fewer/other buckets (but this will reduce the accuracy) - this is not supported by this library yet
...

You can also ask for consulting services. I know some of the maintainers of Prometheus offer support. The company I work for offers consulting service as well.

Consider just using the default quantiles for histogram, or at least fewer static ones, and not defining the exponential buckets here.  Not sure why anyone would need 32 quantiles of precision.  Just use the default quantiles, and leverage Proms linear prediction functions for an approximation of that level of precision, without storing an insane number of time series.
Plus, lets get the metrics typed properly.  Currently for me they are showing as 'untyped'
Please keep in mind, we're talking webscale apps here. Hundreds of containers scaling up and down frequently.  Your example of redeploying apps 4 times in 12 hours.  Now imagine that with a Prom retention of 2+ weeks.  That level of time series generation is unsustainable.

@civik I think I need do some research to figure out what the purpose of these weird histograms are. The numeric values seem constant but could be based on a configuration value. On the other hand, I guarantee I don't have any configuration set to "2.5169093494697568" seconds.
In any case, it may make sense to just have a feature toggle for histograms.

@ahus1 So it looks like closing this issue is a matter of changing one metric name:
This
hystrix_thread_pool_count_threads_executed
Becomes
hystrix_thread_pool_threads_executed_count

@ahus1
Actually these two should be changed too
From
hystrix_thread_pool_rolling_count_threads_executed
hystrix_thread_pool_rolling_max_active_threads

To
hystrix_thread_pool_threads_executed_rolling_count
hystrix_thread_pool_active_threads_rolling_max

I would also add a switch guarding the exponential bucket definition, or just do away with it entirely.  Looks like the class tries to provide a sane default: https://prometheus.io/client_java/io/prometheus/client/Histogram.html

I've pushed some code changes to make the buckets of the histogram configurable. Also the new default for the histograms of this publisher is the Histogram's default -- cc: @SimenB, @jtlisi
To use the previous exponential buckets, use the following:
HystrixPrometheusMetricsPublisher.builder().withExponentialBuckets().buildAndRegister()
HystrixPrometheusMetricsPublisher.builder().withExponentialBuckets(0.001, 1.31, 30).buildAndRegister()

Please be aware that with the Histogram's default bucket size it is difficult to approximate the error of the calculated percentile. This is only possible with exponential buckets.
If you want to skip the histograms altogether, please use a Prometheus rewrite configuration. I will keep them in the default as Histograms are the only way you can aggregate latencies in a cluster.
The changes are already available in the snapshot Maven repository (see the main README at https://github.com/ahus1/prometheus-hystrix). Please give them a try and comment.

Sorry about the mess there, I forgot to deprecate the old metric names.

Regarding the buckets: I cannot get 3.3.0-SNAPSHOT to test locally. We're including it in a library that is included in our projects and gradle is refusing to use the updated code from the snapshot in the snapshot in the local build. I'll keep trying to get it to work.

I'm unlikely to get this to work locally. However, I see the change only deprecates the register method that we're currently using so the transition from 3.2 to 3.3 should be seamless and your code appears to accomplish the desired goal.

Local results:

Without specifying buckets, it creates 15 linear buckets
Specifying buckets with HystrixPrometheusMetricsPublisher.builder().withExponentialBuckets(0,1.31,6).buildAndRegister() results in the following error and no buckets, but I do get all the rest of the hystrix metrics:

java.lang.IllegalStateException: Histogram buckets must be in increasing order: 0.0 >= 0.0

Which makes sense since nothing should be -lt 0.0
3. Specifying buckets with HystrixPrometheusMetricsPublisher.builder().withExponentialBuckets(0.001,1.31,6).buildAndRegister() results in 7 total exponential buckets, which is nice.
I approve these changes.

@benzvan - thanks for the PR. I've squashed the changed and merged them.
There is an option to exclude all deprecated metrics, I extended this also to this also to HystrixPrometheusMetricsPublisherThreadPool.
I also changed "threads_executed_count" to "threads_executed_total", as the Prometheus Naming conventions state: "_total (for a unit-less accumulating count).
Looking at the metrics again, could we remove rolling_threads_executed_count, as the threads_executed_total allows this value to be calculated by Prometheus rate() function?

Yes, that makes sense. Should we also deprecate rolling_max_active?

rolling_max_active is useful as thread_active_count will give the instant active threads. You can scape it as often as you want, but it will not provide information if there were spikes between scapes. rolling_max_active will give an indication if there has been a spike if you scape at least once within the rolling interval.
So I'll keep it for now.

This has been released as part of 3.3.0 and should be available on maven central shortly.

Awesome! Glad to be involved.


#4383, archive releases

Fixes #4383.

Pull Request Test Coverage Report for Build 1829

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.005%) to 56.628%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
2
80.0%

Totals

Change from base Build 9685:
0.005%

Covered Lines:
11030

Relevant Lines:
19478

💛  - Coveralls

Codecov Report

Merging #4401 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4401   +/-   ##
=========================================
  Coverage     53.19%   53.19%
  Complexity      351      351
=========================================
  Files          1048     1048
  Lines         19478    19478
  Branches       3619     3619
=========================================
  Hits          10362    10362
  Misses         8460     8460
  Partials        656      656

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b1feb...3ad6501. Read the comment docs.


Power settings menu is activated when using...

When using a applescript to execute the following command "pmset displaysleepnow" the power settings menu always comes on as well. I've noticed that it ONLY does this when using that specific terminal command.
Is there anyway you can add a Sleep Display feature to the standard functions?
Thanks!

I've noticed that running an AppleScript does bring up the Are you sure you want to shut down your computer now? menu, but only the first time the script is run. I can't figure out why that is occurring.
Is that what you're seeing as well, the menu only on the first time running the script? Sorry I don't have a better answer, but it may be you'll need to trigger the script once to get rid of the menu. Your script will run immediately thereafter.


⚠ ClamAV has degraded performance

In 76b723e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in e8fb593.


AstTypeStubPaths_MergeStubs test fails

https://github.com/Microsoft/python-language-server/pull/86


Manage alert: exposing alerts from some SPARC NLP.

This PR:

Includes PR #69
Exposing alert related to some SPARC NLP
Draw direct line for missing nodes in AC: The case is that there are several new terms that become nodes in connectivity such as ilxtr:vago-sympathetic-trunk. This node causes disconnection in AC and FC.

What are the alignment/flatmaps/human-flatmap and alignment/flatmaps/rat-flatmap sub-modules all about??

I've rearranged the code to find endnotes. Connectivity with terminals connected to more than one node, such as mmset4/7, will be addressed later.


README with example usage

I know it is not finished but could we add an example on how to use it in the README that can be updated as we progress?

It's already moved, so I think that we can close this issue :) If no - @jwillmer please reopen.


Installed following steps. Top right icon still grayed out, does not show options/buffer.

I installed the extension through policy changer.
It "works" as it is not grayed out in the list of extensions.
The topright icon is still grayed out.
Chrome redirects me when I select and click on "options". I cannot get to options.
Youtube still doesn't buffer.
Installed both:
YouTube Center 2.1.4
ID: bcegdpionpopahcglnfiiioapcclamdj
This product makes the whole youtube page go white, while playing only sound.
YouTube Center Developer Build 548
ID: ajijnmbjgaeekdpmpohgppkckmnagimk
Enabled them, one at a time.
I cannot get to options. What should I do? Is it part of the google megacapitalist plot or is a bug in the plugin/extension/addon?
Thank you.

Go back to old layout, doesn't work on the new material layout.

What is layout? Where do i change it? in youtube or in Chrome?

To exit the Material Design layout, you can go to YouTube's homepage, click your channel icon in the top right to pop-up a menu, then click Restore classic YouTube at the bottom of its list.

Everything works. Plug in doesn't want to update. "Error connecting to server"
How nice would it be if this plugin was like a crack for liberating software from capitalists, where all the policy changes, youtube view changes and other necessary adjustments were done by the plugin during installation.
Otherwise this great plugin is not becoming popular because it is very hard to install and there is no full installation list.
I had to:
Follow github steps, install policy changer then change the policy to allow chrome to use this plug in, then change youtube.
How nice if all those steps were written on the same page.

Any way to trick youtube into buffering a full video in HD?
I would do it by sending requests to buffer the video at different places and than joining all the pieces.
As many poor people living in house shares with slow internet, I would appreciate such accelerator algorithm.

agreed, youtube center is in desperate need of an update, disable DASH playback no locnger works along with a laundry list of other features not working as of some weeks ago. already using old layout, that doesnt fix the issues


Audio not playing in firefox

Currently experiencing a bug where audio files are not playing in both audio-keyboard-response and audio-button-response
A simple timeline like below
    const calibration_audio = {
      type: 'audio-keyboard-response',
      stimulus: `audio/noise_calib_stim.wav`,
      choices: ['c'],
      response_ends_trial: true,
      prompt: '
Test
'
    };

Works fine in chrome, but getting the following error in FF
The buffer passed to decodeAudioData contains invalid content which cannot be decoded successfully.
(tested on FF 60.0a1 (2018-01-26) (64-bit) and Chrome  63.0.3239.132)

Looks like it might be related to this:
https://stackoverflow.com/questions/26169678/why-certain-wav-files-cannot-be-decoded-in-firefox


consul: 0.9.3 -> 1.0.6

Semi-automatic update. These checks were performed:

built on NixOS
ran /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin/bin/consul -h got 0 exit code
ran /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin/bin/consul --help got 0 exit code
ran /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin/bin/consul -v and found version 1.0.6
ran /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin/bin/consul --version and found version 1.0.6
ran /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin/bin/consul version and found version 1.0.6
found 1.0.6 with grep in /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin
found 1.0.6 in filename of file in /nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin

@GrahamcOfBorg build consul

Success on x86_64-darwin (full log)
Partial log (click to expand)
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider/digitalocean/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash -e"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider/gce/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider/gce/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider/gce/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash -e"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/hashicorp/memberlist/tag.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/golang/protobuf/ptypes/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash -e"
/nix/store/71wbnia2cd886pm7h0jjzjxbdhh363v5-consul-1.0.6/share/go/src/github.com/hashicorp/consul/vendor/github.com/posener/complete/test.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/9174xp5imvrsz87x0ba76z3935gaxswd-consul-1.0.6-bin

Success on aarch64-linux (full log)
Partial log (click to expand)
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/terraform/openstack/scripts/server.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/terraform/openstack/scripts/service.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/terraform/shared/scripts/service.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/test/bin/cluster.bash: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/test/ca/generate.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/test/hostname/generate.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/ui/scripts/dist.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6/share/go/src/github.com/hashicorp/consul/website/scripts/deploy.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/dgb832gm0j5nx2kk3y28vassxl0i5sl2-consul-1.0.6...
/nix/store/dv0q8ad6rnp5rg47mfcdwgqhqlh9bl19-consul-1.0.6-bin

Success on x86_64-linux (full log)
Partial log (click to expand)
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/dist_build.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/ui_build.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/ui.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/build.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/dist.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/vagrant-linux-priv-go.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/scripts/fixup_times.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6/share/go/src/github.com/hashicorp/consul/website/scripts/deploy.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-consul-1.0.6.drv-0 in /nix/store/fg2166g06nwjhgm4mwxyhl39f970d2kj-consul-1.0.6...
/nix/store/xf97nh84m71qq46s1mqgra1gspszfamb-consul-1.0.6-bin

Worth noting that upgrading to Consul 1.0+ means a collection of breaking changes.

I also think it's not a trivial update.
@pradeepchhetri @nh2 what is your point of view?

In my own nixpkgs I am already using this (because it promises to fix big issues that take Consul down until restart, like this one), and it's working fine.
It does break some things, espeially the strict enforcement of HTTP verbs (e.g. PUT vs GET); in particularly it breaks the version of the Python consul package that nix has packaged (pythonPackages.consul), for which an upstream [PR that fixes it
(https://github.com/cablehead/python-consul/pull/182) has not been merged for 3 months without activity. I patched my nixpkgs to use the version in the PR.
We may want to do the same in nixpkgs, switching to the version in the PR until it's merged upstream.
Here's my commit:
commit e38b5292a3def39c044fffd33bac28792a3f13a8 (origin/nixos-17.09-benaco)
Author: Niklas Hambüchen<EMAIL_ADDRESS>Date:   Wed Feb 14 18:45:34 2018 +0100

    consul: 0.9.3 -> 1.0.6; also upgrade python-consul to a PR that can handle Consul >= 1.0

diff --git a/pkgs/servers/consul/default.nix b/pkgs/servers/consul/default.nix
index d2ad5d0bd8..7230233908 100644
--- a/pkgs/servers/consul/default.nix
+++ b/pkgs/servers/consul/default.nix
@@ -2,7 +2,7 @@

 buildGoPackage rec {
   name = "consul-${version}";
-  version = "0.9.3";
+  version = "1.0.6";
   rev = "v${version}";

   goPackagePath = "github.com/hashicorp/consul";
@@ -11,7 +11,7 @@ buildGoPackage rec {
     owner = "hashicorp";
     repo = "consul";
     inherit rev;
-    sha256 = "1176frp7kimpycsmz9wrbizf46jgxr8jq7hz5w4q1x90lswvrxv3";
+    sha256 = "06isx7y6nc3305d9bw61738jfmyyh0czshgfdn8dvhdhvxjs5pp2";
   };

   # Keep consul.ui for backward compatability
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 4bf6d17f2c..0189ab7c6d 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -3078,11 +3078,12 @@ in {

   consul = buildPythonPackage (rec {
-    name = "python-consul-0.7.0";
+    name = "python-consul-0.7.0-custom-consul-1.0";

-    src = pkgs.fetchurl {
-      url = "mirror://pypi/p/python-consul/${name}.tar.gz";
-      sha256 = "18gs5myk9wkkq5zvj0n0s68ngj3mrbdcifshxfj1j0bgb1km0wpm";
+    src = pkgs.fetchgit {
+      url = "https://github.com/matusvalo/python-consul.git";
+      rev = "6e30e947725fdf88afa0a0a58b7cd8d7d29485f5";
+      sha256 = "1ipazwafw418a6gclzayzzdhyjlkrscj4fjmvjrp04zpb4y4v1pr";
     };

     buildInputs = with self; [ requests six pytest ];

I didn't have to adjust the consul service in nixpkgs, that one worked out of the box (at least with the settings I use).
I haven't checked other languages' bindings in nixpkgs yet. I think it makes sense to ping the maintainers / people involved in other consul bindings and give them a week.
In general I'm very much in favour of doing this upgrade, but let's ping all involved binding users and give them a week to respond. I'll do that in a moment.

The following packages depending on Consul have to be checked for compatibility with Consul 1.0:
Let's wait a week for the projects persons pinged here to respond before we go ahead with the upgrade.

[ ] vault (which I assume works with latest consul given that it's also by HashiCorp) (CC @volth)
[ ] envconsul, also by HashiCorp so it probably works (CC @ryantm @pradeepchhetri)
[ ] confd (CC @wkennington @bachp @kamilchm @offlinehacker @fpletz @jagajaga)
[ ] terraform providers (CC @zimbatm @mbode @Fuuzetsu @adisbladis)
[ ] haskellPackages.consul-haskell (I filed a question)
[ ] haskellPackages.wai-middleware-consul (I pinged the maintainers to ask if it works OK with Consul 1.0)
[ ] consul-alerts (I filed a question) (CC @kamilchm)
[ ] prometheus-consul-exporter (I filed a question (CC @hectorj)
[ ] pythonPackages.consul (CC @desiderius @FRidh @martijnvermaat @mimadrid) (upstream PR https://github.com/cablehead/python-consul/pull/182)

the terraform plugin is stuck to 0.6.3 on upstream: https://github.com/terraform-providers/terraform-provider-consul/blob/master/vendor/vendor.json#L251

I think the older version will have to be kept around for b/c

Any progress on this?

I've ticked off the projects that have confirmed compatibility.
A big remaining problem for me is https://github.com/cablehead/python-consul/pull/182. I'd be fine to go ahead without more info from the other ones.
Would you be OK with using a patched version of python-consul in nixpkgs, @desiderius @FRidh @martijnvermaat @mimadrid?

@nh2 I'm not currently using nixpkgs with Consul or python-consul anymore (but I would most probably be OK with that).

@nh2 yep, as long as it is documented.

FYI Consul 1.0.7 was released in the meantime, with another breaking change: https://github.com/hashicorp/consul/issues/3890
Perhaps nixpkgs should list multiple consul versions?

Perhaps nixpkgs should list multiple consul versions?

There is a list of software which the active contributors do not use in production so an update with breaking change (or keeping an outdated version) would be unnoticed for long time.
I guess consul is one of them (also mongodb and many others).
When there is at least one user, they pushes their vision about which versions are to be packaged and which old versions to be kept.

https://github.com/cablehead/python-consul/pull/182 was merged, we just have to upgrade it in nixpkgs now. With that, my personal blockers would be gone.

There is a list of software which the active contributors do not use in production so an update with breaking change (or keeping an outdated version) would be unnoticed for long time.
I guess consul is one of them.

I use that but I use nixpkgs stable releases, with fixes cherry-picked on top, not master, so I'd notice breaking changes outside of my own cherry-picks only when upgrading to the next nixpkgs release. But I usually follow upstream quite closely with the cherry-picks.

https://github.com/NixOS/nixpkgs/pull/41239#issuecomment-393000879 explains how to update the Ruby dependencies, which is apparently necessary on current nixpkgs

Closing in favor of #44192


rustfmt removes 'dyn'

Before
#![feature(dyn_trait)]
fn main() {
    trait MyTrait {
        fn method(&self) -> u64;
    }
    fn f(a: Box<dyn MyTrait>) {}
}

After
#![feature(dyn_trait)]
fn main() {
    trait MyTrait {
        fn method(&self) -> u64;
    }
    fn f(a: Box<MyTrait>) {}
}

(rustfmt 0.4.0)

I'm happy to mentor this issue. If you want to explore, look at types.rs and the Rust AST for types. We might need to update our rustc-ap-syntax dependency.

I'd be interested in working on this!

@nrc
ast::TyKind::TraitObject has
pub enum TraitObjectSyntax {
    Dyn,
    None,
}

so I think it's not hard to modify.
I'm working on PR.

Thanks @kngwyu !
@ThatOtherPerson https://github.com/rust-lang-nursery/rustfmt/issues/2445 might be another good issue to get your teeth into. There are some instructions in the issue, feel free to ask questions there too!


Fix failure to build on Cordova Android 7+ caused by manifest path

Looks like you might be using Cordova 6 or lower? This change is indeed breaking earlier versions, in the same way that Cordova 7 breaks this plugin (https://github.com/nordnet/cordova-universal-links-plugin/issues/133).
I think we can fix this by adding checking the cordova version through the context in the hook. I'll look at it when I have time.
I also see I accidentally included another commit in this PR, so I created a new PR (I need to keep the master branch the way it is): https://github.com/PluginCordova/cordova-universal-links-plugin/pull/2


work out flashing w/ genid.exe

my understanding is that we need to place genid.exe (attached) in the same folder as button.pdk compiled from button.prj with RELEASE defined. The writer should then find the exe and run it.
genid.zip

Will try this today!

Works well! Writer executes exe each time MCU is successfully programmed and removed


The dispatcher throughput

The throughput of the dispatcher denotes the number of messages that are processed before running runtime.Gosched(). Right now the n+1 messages will be processed if the throughput is n. Thus the condition checking code i > t  should be replaced with i >= t in mailbox.go
		if i >t { // the condition should be i >= t
			i = 0
			runtime.Gosched()
		}

		i++

As a basic tool library, maibox.go  must be adapted to external situations where illegal data may appear. If t is "0", then
if i > t {
	i = 0
	runtime.Gosched()
}

will ignore the back of the code. So, the current is the best choice.


Update zimlib to 8.2.0

Description of changes
Update to version 8.2.0 of zimlib.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

feel free to replace me in meta.maintainers, if you actually use this

Consider it done.

nice, thanks. you can just squash those commits, I'll do some basic testing and then we can merge this.

I sqaushed them, and it looks like the CI process finally completed.

Result of nixpkgs-review pr 229398 run on x86_64-linux 1

2 packages built:

zim-tools
zimlib


test

Type: Missing
Summary:
test
Details:
test
Resolution:
test
Affected definitions:

SoftButton 0.1.0

You can review the change introduced to the full definition at ClearlyDefined.


[bug 1108156] Upgrade peep

Upgrades to the last peep with the --no-use-wheels provision still in.
Also, this removes the goofy "pip install pip" line.
r?

I think the only way to test this is to destroy your vagrant vm and create a new one.

vagrant halt
vagrant destroy
vagrant up
vagrant ssh
cd fjord; manage.py test

Oops--just found a problem. Working on it now.

Ugh. I hit all kinds of problems. I need to test with a fresh vm now.

Wow... So that happened.
The test steps run in the previous comment works. The changes shouldn't affect -dev, -stage and -prod environments.

Probably unrelated to this PR, but I get this error:
(fjordvagrant)vagrant@vagrant-ubuntu-trusty-64:~/fjord$ ./manage.py test
Using test configuration
Traceback (most recent call last):
  File "./manage.py", line 12, in <module>
    monkeypatches.patch()
  File "/home/vagrant/fjord/fjord/base/monkeypatches.py", line 32, in patch
    import jingo.monkey
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/jingo/__init__.py", line 164, in <module>
    env = get_env()
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/jingo/__init__.py", line 52, in get_env
    loaders = [loader(p) for loader, places in x for p in places]
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/jinja2/loaders.py", line 216, in __init__
    provider = get_provider(package_name)
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/pkg_resources.py", line 229, in get_provider
    __import__(moduleOrReq)
ImportError: No module named sslserver

I guess I need to install that separately?

Oh, that's probably because of my settings_local. Let me fix that.

We were using it to test the remote-troubleshooting stuff. It's not in the dev requirements so probably best to undo it in your local.py settings file.
Going forward, we could add that as a requirement to dev.txt. I'm not sure how often it'll come up or what additional complexities it adds especially in the vagrant dev environment.

WFM. r+

Landed in 342eac3 [bug 1108156] Upgrade peep and handle pip 6.0
Thank you!


Ingress issues a 301 for test.pivot

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.171%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
395

Relevant Lines:
555

💛  - Coveralls


HWKAGENT-5 resource config

this was not off of master but off of another PR branch - https://github.com/hawkular/hawkular-agent/pull/34 so do not merge this PR until that one is merged first

I misunderstood how the new inventory API was going to work. This PR is not going to work.


unable to login to self Service Portal via LDAP auth

Hi,
I am unable to login in self_service portal using LDAP authentication. LDAP is integrated with ManageIQ and able to login to administrator page with my ldap user id and password, however when I try to login to self_service portal with same account it gives me below error
User creation successful for User: XXXXXXXXXXXXX
[----] W, [2021-04-04T12:21:10.541587 #6956:2ad5d2a76bec]  WARN -- Failure: MIQ(Base.audit_failure) userid: [corp\pushan151803] - Authentication failed for userid<EMAIL_ADDRESS>unable to match user's group membership to an EVM role
[----] I, [2021-04-04T12:21:10.554718 #6956:2ad5d2a76bec]  INFO -- Success: MIQ(Base.audit_success) userid: [domain\username] - Authentication successful for user domain\username
Need assistance here

It's hard to tell, but Authentication failed for userid<EMAIL_ADDRESS>unable to match user's group membership to an EVM role implies that you didn't create any groups in ManageIQ to match the groups coming from LDAP.

I did created the same group on manageIQ matching to LDAP

Unfortunately, I don't think I can help without more info.

is this appliance or podified?
what version?
are there any errors in the apache error logs? (httpd pod in podified; /var/log/httpd directory in appliances)

[----] I, [2021-04-21T03:51:44.053927 #365443:2aca8386e778]  INFO -- Success: MIQ(Base.audit_success) userid: [domain\username] - User domain\username successfully validated by LDAP
[----] W, [2021-04-21T03:51:44.065283 #365443:2aca8386e778]  WARN -- : MiqLdap is a deprecated feature. Please convert to using external authentication.
[----] I, [2021-04-21T03:51:44.157007 #365443:2aca8386e778]  INFO -- Success: MIQ(Base.audit_success) userid: [domain\username] - User creation successful for User: firstname lastname with ID<EMAIL_ADDRESS>[----] W, [2021-04-21T03:51:44.173469 #365443:2aca8386e778]  WARN -- Failure: MIQ(Base.audit_failure) userid: [domain\username] - Authentication failed for userid<EMAIL_ADDRESS>unable to match user's group membership to an EVM role
[----] I, [2021-04-21T03:51:44.192555 #365443:2aca8386e778]  INFO -- Success: MIQ(Base.audit_success) userid: [domain\username] - Authentication successful for user domain\username

It's also possible the groups coming from LDAP are not valid / missing.  LDAP must be configured with the memberof overlay.   Search that phrase here: https://www.manageiq.org/blog/2018/01/troubleshooting-auth/#example-authentication-config

WARN -- : MiqLdap is a deprecated feature. Please convert to using external authentication.

@pushan9 Maybe you should convert to external authentication before this long-deprecated feature is removed (https://github.com/ManageIQ/manageiq/pull/21127).

Oh good eyes, @chessbyte .  I'm not even sure MiqLDAP even works with SUI at all.  LDAP via SSSD should work, as I know we have settings for that in the configuration.

Oh good eyes, @chessbyte . I'm not even sure MiqLDAP even works with SUI at all. LDAP via SSSD should work, as I know we have settings for that in the configuration.

Thanks, I will check on this and get back to you on this

Closing due to lack of response.   Please re-open, if needed, with more details.


Templateaddition to the Repo

Before merging the pr  i kindly request you to assign gssoc label to the issue #24 as well as level 2 label to the issue #24 this helps me to gain some points which will be more benefitial

Please add some labels such as gssooc and levels

Please add some labels such as gssooc and levels

hello @hasmithagunda123 please also add level labels here adding level 2 label here will help me to gain some score in the leaderboard #24 thank you


Inquiry about args.dataset in build_graphs.py

Hi @vkola-lab,
Thank you for your explanation! The earlier issue was already solved.
Could you explain how to define args.dataset in the build graphs.py file? Is it linked to the path to patches as you mentioned in the build_graphs.py's parser?
If it's true, does bags_list contain the patches list? Is the compute_feats function used to compute the features for every patch (doesn't matter whether it comes from the same or different WSI)? So that it will store a c_idx.txt, features.pt, adj_s.pt for every patch?
Please correct me if I am wrong. Thank you very much!

Hi, do you have an answer to this?


$.jstree.defaults.unique.duplicate even working?

$.jstree.defaults.unique.duplicate = function(data) {
  do_something();
};

Is not called

Sorry the documentation is misleading - took me a while to figure it out too.


/zh/ localization url fixed.

This PR fixes link to content to localized version.

/assign @xichengliudui

@butuzov good job
/lgtm
/approve

Do we have to prepend '/zh/' to all links, or we can rely on Hugo to figure out the correct links?

@tengqm this is something i discover accidentally. Link to that tutorial was broken at first place, and then i just check do zh has translation.

I have rise a topic here
https://kubernetes.slack.com/archives/C1J0BPD2M/p1577728435037800
And add note with initial plan to implement with deadlinks
https://github.com/butuzov/deadlinks/issues/55
note: last step wound't work (its planed but not implemented)
So what i have done for now is

generate list of links from localization using deadlinks kubernetes.io/L10N/ -n10 -s ignored
grep / awk / sed
pipe this to custom python script (can be curl or something)# this one uses files instead pips as i wanted to cache results
import requests
from time import sleep

with open("mdocs.txt") as f:
    for url in f.readlines():
        rsp = requests.get(url.strip())
        if rsp.status_code != 404:
            print(rsp.status_code, url.strip())
        sleep(0.1)

@butuzov I fully appreciate your passion and effort to fix the dead links. I'm questioning whether we can solve this problem for all languages, and for all links in a "better" way. I'm not a Hugo guru, but I did find something. Rather than finding and fixing individual link errors, I'm asking whether we can solve the problem once for all.

@butuzov Just did some experiments in #18374. I have left some comments concluding the experiments. It looks promising. After we have links in the English source "fixed" once, the links don't need to be "localized" in any language.
@jimangel Probably this is something we want to do.


Influx 1.8 OSS with 2.0.0 client: InfluxDBException: statusCode = 401, code = null, message = null

Describe the bug
Authentication fails, when trying to query a 1.8.5 based Influx instance with the 2.0.0 flutter client.
[VERBOSE-2:ui_dart_state.cc(209)] Unhandled Exception: InfluxDBException: statusCode = 401, code = null, message = null #0      DefaultService._handleResponse package:influxdb_client/client/influxdb_client.dart:108 <asynchronous suspension> #1      QueryService._send package:influxdb_client/client/query_service.dart:80 <asynchronous suspension> #2      QueryService.query package:influxdb_client/client/query_service.dart:66 <asynchronous suspension> #3      _SysHealthState._loadHistoricalData package:screens/syshealth.dart:222 <asynchronous suspension>
To Reproduce
Steps to reproduce the behavior:

Query data from a 1.8.5 influx db with auth-enabled = true

Expected behavior
The query to execute successfully as it does with influxdb_client: ^1.1.0
Specifications:

Client Version: influxdb_client: ^2.0.0
InfluxDB Version: 1.8.5
Platform: Flutter (running client on iOS)

Additional context
The code is working fine with influxdb_client: ^1.1.0
Sample code I used works with client 1.1.0 but not 2.0.0
InfluxDBClient client = InfluxDBClient(
        url: 'http://localhost:8086',
        username: 'my_user',
        password: 'my_password',
        org: '',
        bucket: 'my_db',
        debug: false);

    QueryService queryService = client.getQueryService();

    String fluxQuery = '''
    lat = from(bucket: "my_db")
          |> range(start: -1d)
          |> filter(fn: (r) => r["_measurement"] == "gps_pos")
          |> filter(fn: (r) => r["_field"] == "lat")
          |> limit(n:20)

    long = from(bucket: "my_db")
          |> range(start: -1d)
          |> filter(fn: (r) => r["_measurement"] == "gps_pos")
          |> filter(fn: (r) => r["_field"] == "long")
          |> limit(n:20)

      join(tables: {lat: lat, long: long}, on: ["_time"])
    ''';

    Stream<FluxRecord> recordStream = await queryService.query(fluxQuery);
    await recordStream.forEach((record) {
      double lat = double.parse(record["_value_lat"].toString());
      double long = double.parse(record["_value_long"].toString());
      print('${record["_time"]} lat: $lat long: $long');
    });

Hi @ADLsourceCode,
thanks for using our client.
I have prepared a fixed version within #26.
If you would like to use the fixed version of the client before release into pub.dev, then you can import the library by:
dependencies:
  influxdb_client:
    git:
      url: git@github.com:influxdata/influxdb-client-dart.git
      ref: fix/authorization-v1

https://dart.dev/tools/pub/dependencies#git-packages

Regards

@bednar works great. Thanks a lot for fixing it!


ELZT-69: Updated nl-core dependency to 0.9.0-beta.1

@niekvangalen  In https://github.com/Nictiz/Nictiz-R4-ELZ/pull/9 a merge to 0.2.0-alfa.1 has been done, why wasn't that one merged to 0.2.0-beta.1 instead?

@LuudSlagter the branch was renamed to beta.1, so the merge is correct.