Scaling System

Firefox: No issue, but browser zoom does not change any size of BV
Chrome: Broken movement of windows, and browser zoom does not change any size of BV
Safari: Broken movement of windows, but BV scales to zoom

New context: Implement Scaling of UI

complete


Failed to install dryrun on windows

After executing the command "gem install dryrun" on my windows machine, with the latest Ruby version
I got this error
ERROR:  While executing gem ... (ArgumentError)
wrong number of arguments (given 1, expected 0)
Can you help me?

Is it still unavailable on the Windows platform?

No


How to install via composer in windows

I am getting phantomjs installation error via composer in windows 10.
Is any way so i can deploy this in windows ?

Post the composer version and the error message when you do composer update.

Issue now resolved by using Composer version 1.17.0
On Mon, Jun 21, 2021, 1:41 PM Michael Uno @.***> wrote:

Post the composer version and the error message when you do composer
update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/michaeluno/php-simple-web-scraper/issues/2#issuecomment-864824862,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIXOM4LZXFYMP4CGRDVXPT3TT3XZJANCNFSM47A6XF3A
.


Uncharger does not remove explicit hydrogens

Configuration:

RDKit Version: 2020.09.1
Operating system: Linux
Python version (if relevant): 3.8.5
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? conda-forge

Description:

When uncharging a positive charged nitrogen with four explicit hydrogens attached, the Uncharger does not remove an explicit hydrogen, but only removes the positive formal charge. This then leads to an invalid molecule.

from rdkit import Chem
from rdkit.Chem.MolStandardize.rdMolStandardize import Uncharger

uc = Uncharger()

m = Chem.MolFromSmiles('[NH4+]')
m

Works without explicit hydrogens
uc.uncharge(m)

Does not work with explicit hydrogens
m2 = Chem.MolFromSmiles('[NH4+]')
m2 = Chem.AddHs(m2)
m2

uc.uncharge(m2)

Expected behavior: Uncharger should in this case remove one explicit hydrogen.

@mrcblt My experience is that the rdMolStandardizer requires molecules with implicit hydrogens to work properly, as it extensively uses reaction SMARTS that will only work properly with implicit Hs.
If you work with 3D molecules, it isn't too hard to remove Hs upfront, and then read them afterwards restoring the original coordinates. Does that sound reasonable to you?

Yes, this is kind of the current workaround I use. If there is no way to get it to work easily with explicit hydrogens, then I would suggest that there should at least be a warning if Uncharger is used with molecules containing explicit hydrogens. Or it should be stated in the documentation of the class or the uncharge function. I may have overlooked something, but I couldn't find any indication that Uncharger is not working properly in this case.


Better progress report

Currently, cargo only outputs "Compiling xxx" when starting a job. I propose using ANSI control sequences to have a more finer progress report while keeping the same number of line output.
PoC with jobs in WiP or done state:
#!/usr/bin/env bash

a=(10 4 3 2 5 7 8 1 6 9)

for i in $(seq 1 10); do
    echo "doing $i"
done

for i in $(seq 1 10); do
    # \033[nA moves the cursor up n lines
    printf "\033[$((11 - i))A"
    # Print done jobs. \033[K clears the current line
    printf "\033[Kdone $i\n"
    # Print jobs still running
    for x in "${a[@]}"; do
        if [[ $x -gt $i ]]; then
            printf "\033[Kdoing $x\n"
        fi
    done
    sleep 1
done

The basic idea is with n jobs running, when a job finishes we erase the n previous lines, print the finished jobs then print the jobs still working.
When this setup is working, we can expand it to show a more finer progress report for each job.
Windows seems to support it, MacOS and Linux does.
See https://github.com/rust-lang/cargo/issues/833, maybe also others.

(somewhat) related: #2536

Triage:  Cargo these days has a more advanced progress output than it did 5 years ago.   Unless there's some specific deficiency in the current output, I think this issue can be closed

I think we're still interested in improving Cargo's progress output. #8889 contains the most recent discussion along with some examples. I'm going to close this as a duplicate of #8889 since it has the most recent information.


Add basic Github Pages site

I still need Steven to enable Github Pages here... I'll write again, but @ChristopherChudzicki what do you think?
This is currently deployed to https://mathbox.org.

@sritchie This is nice! Would be great to have the examples visible on the web.
As far as asking Steven to turn on gh-pages... I have been thinking of emailing him to ask if he'd be comfortable with making at least one of us an admin. If not, that's totally fine. But... with admin we could handle this and other issues ourselves. (e.g., adding secrets like an NPM key so we could automate publishing). I'm also interested in turning on Renovate, but I think that needs to be an owner. (except for orgs, where admins can do it).


Fix default value of the clearConsole option

It looks https://github.com/geowarin/friendly-errors-webpack-plugin/pull/10 caused to set wrong default value for the option.

Sorry about that! Thanks for fixing!

Oops.
:flushed:
Thanks @nkzawa.
How many engineers does it take to set a boolean value? 3!
I think we got it this time. Good job guys! 😄


Update overlay.py

UI Enhancements:
- slighty less minimalistic: looking forward for feedback
- New Buttons: Added CustomButton class and introduced new buttons for streamlined interaction:
- Console/Hide Console: Toggle the size of the overlay.
- Filter: Initiates item filtering menu with 'Auto Filter', 'Reset Status'
- Move Items: Initiates item stockings menu 'to stash', 'to inventory'
This need testing for different screen resolution please
Now doesn't affect main.py.

You dont need to create a new pr when updating ;)

You dont need to create a new pr when updating ;)

I'm sorry, I can sometimes mess around. 🤡


aarch64 not picked up by get_arch()

On Fedora Silverblue aarch64, running asdf install kind <version> doesn't download the arm64 version of kind.
Adding aarch64 to the case statement fixes the issue:
--- a/bin/install
+++ b/bin/install
@@ -35,7 +35,7 @@ get_arch() {
    amd64 | x86_64)
      echo "amd64"
      ;;
-   arm64)
+   arm64 | aarch64)
      echo "arm64"
      ;;
    ppc64le)

Support for aarch64 implemented.


Remove unnecessary reserved words introduced in 3.0.0

Document why they aren't needed to avoid similar mistakes in the future.
Add test to check that these words can now be safely used as labels.

@hildjj I added test to another file than the one you suggested. Found pegjs-api.spec.js which already contained tests for the reserved keywords, thought it makes sense to keep all these tests together. Also, didn't manage to figure out how I could make the use of reserved words make the parser.spec.js fail. (I suppose that test only deals with parsing and the keywords are checked for in some other pass which isn't activated in the context of that test).
Fixes #359

LGTM.  I think we need to change the docs a little also, in this new section.  I think I'd like to do that to capture the conversation in #359 somewhat, so I'm going to merge this as-is.

And as I should have said before, thank you @nene !


Added prebuilds of lame for Node 8 and Electron (Mac, Linux, Windows)

As promised in #84.
I got prebuilds for older versions of node also, but skipped those, since they can still be built with node-gyp.

Is it possible to upload the binaries to the GitHub "Releases" function, instead of putting them in git?

Absolutely, I have not tried that, but feel free to do that instead :)
See https://github.com/prebuild/prebuild and https://github.com/prebuild/prebuild-install for more info.

Then it might be possible to add all the builds for older versions also. Make sure that the version in the filenames are correct.
https://www.dropbox.com/s/zhtq650d6nnyeaf/node-lame-prebuilds.7z?dl=0


[RFC] Missing widgets

I implemented the most used widgets in our organization.
With time, I'll implement the rest, have some requests for widgets you use and wish to help me test them? Write them below!

It would be nice to have these components implemented:

AisClearRefinements
AisStateResults
AisRangeInput

Here they're ordered by priority for use in silca-ilco.
If I can help in something, I'm here :)

@MarcBarnaba

AisClearRefinements
AisStateResults
AisRangeInput

has been added!

I switched to this module because of server-side-rendering, however I'm not sure how to proceed because of missing widgets. For instance I would need AisHierarchicalMenu. What is the general idea here? Would I have to wait for the implementation in your module? Or is there a way to plug-in the existing components from Instantsearch?

@georgobermayrsaf HierarchicalMenu is live in version 0.5.2!

Hi @Rigo-m Nice module you have here. We will work with Algolia for our next project in my job and I need the Recommend widget https://www.algolia.com/doc/guides/algolia-recommend/how-to/set-up/#integrate-recommend-into-your-user-interface
Maybe I will do a pull request to improve the documentation + add this widget. I had difficulties to use this module 😝 especially with pnpm and the need to set up shamefully-hoist=true.

I was facing two difficulties :

one on my part because ublock origin was blocking
the second one is with pnpm, we need to set the shamefully host option inside .npmrc. I think this can be fixed on your side. This is not the first time I encounter this problem on nuxt modules 😅

For the recommendations widgets, I was able to connect them to the plugin thanks to the useAisInstance(). Since this is recommendation, the content is not the same for everyone so no need for the widgets to be server rendered for SEO. I don't know yet which widgets my client will need.

Hi,
first of all thanks for the widget. Currently i need the Widget:

AisDynamicWidgets

https://www.algolia.com/doc/api-reference/widgets/dynamic-facets/js/

maximilian

I'm on vacation until the 26th, I'll pick it up afterwards :) In the meantime I think this is already feasible by passing a computed to the widget prop of AisInstantSearch

Hi @Rigo-m, AisMenu and AisMenuSelect were missing. I created PR and would appreciate a review :)


Rdar 27397701 synthesized get set typechecking

Addresses redundant typechecking of getter/setter function bodies outside of the primary file.
This is responsible for unnecessary quadratic work when doing a multi-file compilation.
PR also includes more scale-testing machinery, and a regression test that uses it.
Resolves SR-2901.
Resolves rdar://27397701

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 948fa2b5e7394eb9be4298e9d4b2d3411b35590b
Test requested by - @graydon

Looks like we can't rely on numpy being around

Split scale-test and stats helpers into separate PRs (#5607 and #5608 respectively) that this one depends on. Also fixed numpy and macro definition problems in them.

Updated to unconditionally typecheck all accessors-with-bodies in decl visitor (that's applied to all SF-local decls) rather than trying to switch behaviour for resilient globals.
PR still depends on #5607 and #5608 to land first.

This looks fantastic, thanks!

@swift-ci please smoke test and merge

@swift-ci please smoke test linux and merge

@swift-ci please smoke test linux


Imported K3s cluster - Monitoring API is not ready after apps are active

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

run Rancher v2.4.3-rc2 single install
imported a k3s cluster v1.17.4+k3s1
enable the cluster monitoring

Result:

after the apps are available, the UI still shows waiting for the API to be ready
and it waits a long time to show the graphs in the UI
this is the same behavior we saw here: https://github.com/rancher/rancher/issues/26692

Other details that may be helpful:

this is not seen in an imported k3s cluster with an older version (v1.16.3-k3s.2)

@jiaqiluo I can't reproduce it when testing 2.4-head. Are you always able to reproduce this?

Also notice that there are failure scenario where the controller takes maximum 2 minutes to re-sync. So any status cloud be refreshed after 2 minutes.

Actually I am still struggling at reproducing this issue. But https://github.com/rancher/rancher/pull/27054 should potentically fix it. I think the general issue right here is not related to the underlying k3s version. The controller inside rancher has to fetch the download prometheus instances and update cluster status accordingly. While the controller follow the back-off algorithm to sync status, it will eventually fallback to 2 minutes(or other maximum interval). So there is a delay between the real status and the status showing on UI.
@jiaqiluo Let me know if you see that the cluster stays in not ready states and never returns to a normal state. My understanding is that it will recover after a certain period. This could happen a lot when cluster is not ready(for example, launched with automation scripts).
cc @maggieliu

The bug fix is validated on Rancher

v2.4-3036-head and
master-3034-head

with monitoring chart version 0.1.1
Steps:

run Rancher server, single install
edit the system chart to point to branch dev-v2.5
import a k3s cluster into Rancher, the k3s cluster has 2 servers and 2 workers, and it version is v1.17.4+k3s1
enable the cluster monitoring  0.1.1

Results:
The cluster page shows up graphs right after the monitoring apps are available under system projects


Development Mode: User doesn't log in properly

Logging in while in development mode doesn't work as expected.

Sure this is related to dev mode? This always happens when you were logged in when server restarts.

Yes it does. Not only that, this happens on fresh login also.

I've reproduced it locally and I'm looking into it.

Hi @bkimminich I wanted to let you know an other issue I am facing on development server.
After I clone juice-shop from develop branch and run npm install. I am able to run the normal server by npm start but when I do npm run serve, the following error pops up(this started last night):

The error can be corrected by making the following change in package.json
From
 "serve": "concurrently --kill-others \"nodemon app\" \"cd frontend && ng serve\"",

to
 "serve": "concurrently --kill-others \"node app\" \"cd frontend && ng serve\"",

or by installing nodemon(npm install nodemon --save).
I wonder this is actually an issue or it is happening just in my machine. Please let me know your views on it.
Thank You!!

This can be fixed if you do a npm i -g nodemon.  I was supposed to revert it back to use node but forgot 🤦♂

This can be fixed if you do a npm i -g nodemon. I was supposed to revert it back to use node but forgot 🤦♂

Oh that's why.😆😆 Do you want me to revert it and open a PR?

That would probably best.
In other news, the issue with the original bug has to do with Angular and Express running on two separate ports.  I'm still investigating the issue, however.

That would probably best or @bkimminich can just make the update himself on develop.
In other news, the issue with the original bug may have to do with Angular and Express running on two separate ports. When the app is run in development mode, the cookie in the request is undefined so it's unable to fetch the user.

Yeah sure. That would actually be great😆😆.
And thanks for letting me know about the cookie issue.✌🏻

Having the cookie in the first place is of course a bad idea, as itnl duplicates the Header Authorization header. But it's part of some challenge(s), so would need careful analysis and "fixing".

Maybe we could add something like
let authToken = req.headers.authorization.replace('Bearer ', '');
let token = req.cookies.token ? req.cookies.token : authToken
if(token) {
// do stuff
}

With this theoretical approach, if req.cookies.token is undefined then we can pass in authToken to parse for the user.  This could fix the bug in question.

Or can we just pass token as parameter and at the backend while returning the user modify
const user = insecurity.authenticatedUsers.get(req.cookies.token)

to
const user = insecurity.authenticatedUsers.get(req.body.token)

or
const user = insecurity.authenticatedUsers.get(req.headers.authorization.replace('Bearer ', ''))

@bkimminich @Whamo12
Please let me know your thoughts.
Thank You!!

It appears out that although the above change can solve this error but won't help actually as req.cookies.token is used at multiple places in the app(this change is independent of them and therefore isn't useful).

This problem comes a bit from my own development process, as I rarely use npm run serve. The dev mode just behaves too different from "reality" in production. This got worse in Angular compared to AngularJS back then. I don't think fixing issue with dev mode is worth any extra trouble in production.

This problem comes a bit from my own development process, as I rarely use npm run serve. The dev mode just behaves too different from "reality" in production. This got worse in Angular compared to AngularJS back then. I don't think fixing issue with dev mode is worth any extra trouble in production.

Yeah true, it might not make much sense to modify code for development purposes specifically.


Create zspwni

The school website is moved to spwni.edu.pl, but all email addresses are using old domain @zspwni.edu.pl.

@dzvhj Pull request merged. Thank you!
For the record: domain ownership proof: http://www.spwni.edu.pl/index.php?option=com_content&view=article&id=53&Itemid=174


Improve Command-W behavior on OS X

OS X 10.10.4
Atom 1.0
When you no longer have open tabs, pressing Command-W should close the front window and focus the next unminimized window, if there are any.
This is how Sublime Text 3 behaves. Google Chrome also behaves similarly, except that they do it when you have a single open tab. Pressing Command-W when you have a single open tab will close the window and shift focus to the next open window unless it's minimized.
Originally posted in #7428.

Thanks for the suggestion! This is a duplicate of https://github.com/atom/atom/issues/863 – please subscribe there for updates.


Question regarding Dynamic Executor Allocation support for Spark

What:
https://github.com/Intel-bigdata/oap-raydp/search?q=dynamic suggests that dynamic executor allocation may be added later.
Are there plans to add this, are there fundamental challenges in the ray context for supporting this?

Hi @dpittner. Yeah, we have not supported dynamic executor allocation currently. We will add it support recently.
If you use spark on ray only, it should be easy to add the support. If you want to use spark on ray couple with estimator API, we should add the support of ray object ownership transfer.

close as stale. This has been supported


Disable E501 for inline comments

Our project has pytest-cov, and some lines are disabled from being checked. We use the # noqa: nocover comment, and sometimes it goes beyond the length of the line. I would like to disable the E501 error for inline comments, is there any way to do this?

Do you want E501 to be disabled for all inline comments, or only pragma comments like # noqa?

I think it's better for all inline comments

For now, we are disabling E501 for pragma comments, but not for all inline comments (https://github.com/astral-sh/ruff/pull/7692).

Ty


Developer: Menu builder allow to set/edit 'Hide On' for menu items.

Check the other fields which were added in the nearest past.

Added fields: Addon, Submenu Popup, Custom Visibility, Hidden on.


Add control on Grafana's anonymous authentication

This allows the user to disable anonymous authentication on Grafana.

I'd say we add it as an option to the CRD api

Just a bit of minor work required per @csibbitt but this is a welcome PR, thanks!
Changes required to merge:

documentation
x-descriptors in the CSV for web UI control
CRD changes required for API support
** add this to the graphing.grafana configuration section
** run operator-sdk bundle generate commands to sync CRD and CSV

Wow yeah, sorry I completely missed that part, I will do a v2 ! :)

I believe the work on https://github.com/infrawatch/service-telemetry-operator/pull/281 obsoletes this patch. We leave anonymous auth enabled in all cases, but place grafana behind an auth proxy instead.

I'm going to close this PR due to the work that just merged in #281 but thank you for the contribution!


[KOGITO-2290][KOGITO-2291] Setup stages for release

https://issues.redhat.com/browse/KOGITO-2290
https://issues.redhat.com/browse/KOGITO-2291
Include also https://issues.redhat.com/browse/KOGITO-1013 from @Kevin-Mok
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster

@radtriste is this ready to merge?

running final checks on that one. Will merge it once it is ok.


Support for Reusable and Modular Justfiles in Monorepos (Namespaces)

Originally posted in issue tracking mod, but I feel like it doesn't really belong there.
I am thinking about creating a reusable justfile that can work as a standalone file but can also be copied and imported where needed. For example, environment variables in each justfile represent a standalone application (created with a template) in subdirectories (like a monorepo). The main justfile at the root should be able to build all of them, but independently they should work as standalone applications. However, the root justfile should be able to modify the variables (it should also work for recipes) before building (e.g., to give them different names).
Imagine these justfiles created with a template (which anyone can provide with their frameworks, etc.) and placed in different subdirectories within a monorepo:
# app1/justfile
export APP_NAME := "app-name"

build:
    echo building $APP_NAME

# app2/justfile
export APP_NAME  := "app-name"

build:
    echo building $APP_NAME

# justfile
import 'app1/justfile' with {prefix_vars('app1'}
import 'app2/justfile' with {prefix_vars('app2'}

export app1_APP_NAME = "app-name-1"
export app2_APP_NAME = "app-name-2"

build:
    echo "Building...."
    just app1_build
    just app2_build

$ just build
Building...
building app-name-1
building app-name-2

In my opinion, this would allow the redistribution of applications with justfiles, which could create interesting reusable build processes.  Keep in mind that the examples I gave were made up quickly.

Not sure what the ultimate syntax should look like, but having a way of overriding variables in imported modules seems reasonable to me.
Maybe something like:
import 'app2/justfile' with APP_NAME = "app-name-1"

Not sure what the ultimate syntax should look like, but having a way of overriding variables in imported modules seems reasonable to me.
Maybe something like:
import 'app2/justfile' with APP_NAME = "app-name-1"

I am thinking about {} because it would allow to implement more functions later.

It looks a bit too complicated, it's better to work with modules and passing env vars explicitly but I'm still afraid that in a large nested structure I will accidentally overwrite the variables of a recipe that I don't want


Icons in navbar command (elsewhere too?) do not seem to appear

I'm trying some of the examples from the Try WinJS site, without styling where possible.  In an adaptation of the SplitView, I managed to get the show/hide toggle, the navigation and the content panes.
I cannot seem to get the icons in the navbar, however.  Any suggestions?
<html>
<head>
    <title>AngularWinJS experiments</title>

    <link rel="stylesheet" href="lib/Microsoft.WinJS.4.0/css/ui-dark.css" />
</head>
<body ng-app="AngularWinJSApp" ng-controller="AngularWinJSAppController">
    <button ng-click="paneShown=!paneShown">{{paneShown ? 'Hide' : 'Show'}}</button>
    <win-split-view pane-hidden="!paneShown" shown-display-mode="'inline'" hidden-display-mode="'none'">
        <win-split-view-pane>
            <div>
                <win-nav-bar-command label="'Home'" icon="'home'" tooltip="'Tooltip for Home:put it in quotes'"></win-nav-bar-command>
                <win-nav-bar-command label="'Walk'" icon="'save'"></win-nav-bar-command>
                <win-nav-bar-command label="'Settings'" icon="'settings'"></win-nav-bar-command>
            </div>
        </win-split-view-pane>
        <win-split-view-content>Content Area</win-split-view-content>
    </win-split-view>

    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.15/angular.min.js"></script>
    <script src="lib/Microsoft.WinJS.4.0/js/WinJS.min.js"></script>
    <script src="lib/angular-winjs.js"></script>
    <script>
        var module = angular.module("AngularWinJSApp", ["winjs"]);
        module.controller("AngularWinJSAppController", function ($scope) {
        });
    </script>
</body>
</html>

I wasn't able to repro this. Some questions for you:

Did you make sure to include the symbols font in lib/Microsoft.WinJS.4.0/fonts/Symbols.ttf?
What environment are you reproing this in?
Can you provide an app/page which repros this bug? You can attach it to OneDrive as described on our wiki.

Yes, I downloaded the AngularJS-WinJS samples, built a Visual Studio 2013 project around it. It's possible I missed something to include the .ttf, but unsure as to what.
Windows 8.1 Enterprise, Chrome/IE latest versions.
The HTML page I provided above is the complete app sans the WinJS libraries, but here, http://1drv.ms/1PZfP3P is a OneDrive link.

Thank you

Thanks for the repro page. I successfully reproed it.
I found that if you use the version of WinJS that comes with the templates, the AppBar icons don't work. Is that where you got your WinJS? If so, this is probably a dupe of winjs/generator-winjs#3.
As a workaround, you could grab WinJS from http://try.buildwinjs.com/#get thru the "Direct Download" option.

Thank you.
I grabbed WinJS from the suggested link, and changed nothing but the WinJS folder, and the icons correctly appear as they should.
I suppose I should likewise rely on the version of  angular-winjs from this git repository as well instead of the application templates .zip file.


Enum options need to be quoted

It generated this for me:
timeFormat: {
    type: new GraphQLEnumType({
        name: 'TimeFormat',
        description: '@TODO DESCRIBE ME',

        values: {
            12_H: {
                value: '12H',
                description: '@TODO DESCRIBE ME'
            },

            24_H: {
                value: '24H',
                description: '@TODO DESCRIBE ME'
            }
        }
    }),

    description: '@TODO DESCRIBE ME'
},

12_H and 24_H aren't valid object keys unless they're quoted.

Thanks for reporting! I actually fixed this a while back (in eaa0285dba194a576fc6aaefa127d4bbff44fb63), but forgot to publish a new version.
1.1.0 is now out on NPM and should fix this problem. Thanks!


Can I use MassBank or CFM-ID to retrain it? Thanks

Yes, if you have another set of spectra, it should be possible to retrain
the model with it.
On Mon, Feb 8, 2021 at 5:39 AM lionelxia<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/brain-research/deep-molecular-massspec/issues/23, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADT3XUEUFB4RCU5WCBATHP3S565N3ANCNFSM4XIXXDHA
.


Revert "Moduler modules rework"

Reverts blish-hud/Blish-HUD#37
Wrong base.

Items failing are due to the revert.  This is expected.


Make swift-syntax build without warnings

The main problem here was that we can’t just deprecate syntax nodes since swift-syntax needs to still be able to use them internally (eg. when creating SyntaxEnum cases for as(SyntaxEnum.self)). What we do instead, is to have an underscored node that is not deprecated and deprecate a public typealias from the non-underscored version to the underscored version of the node.
While doing this, I also realized that the SyntaxKind compatibility layer didn’t add deprecation warnings and that we were still using some of them.
And finally, we need to annotate Syntax.Info.info as nonisolated(unsafe). It already had a comment that detailed when it might be modified.

@swift-ci Please test

https://github.com/apple/swift/pull/72557
@swift-ci Please test

https://github.com/apple/swift/pull/72557
@swift-ci Please test

https://github.com/apple/swift/pull/72557
@swift-ci Please test Windows

https://github.com/apple/swift/pull/72557
@swift-ci Please test

https://github.com/apple/swift/pull/72557
@swift-ci Please test Windows


What are all the Config options available?

What are all the config options available? Is there config to prevent user from editing like adding/deleting nodes from the tree

Hi! No such config. Please consider making a fork.On Sep 20, 2018 13:26, keshav1007<EMAIL_ADDRESS>wrote:What are all the config options available? Is there config to prevent user from editing like adding/deleting nodes from the tree
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.


The Lerna script cannot find boost when building C++ modules

When I built on MacOS (having installed Boost using brew) everything is fine.
When I followed the directions on Ubuntu, the lerna build script fails whenever a C++ module needs Boost.  I have Boost installed with apt install libboost-dev (so it's in /usr/include).

Here's  a sample of just one of the many similar errors:
@jpmorganchase/perspective: In file included from /home/dj/usr/src/perspective-clone/packages/perspective/src/cpp/build_filter.cpp:11:
@jpmorganchase/perspective: In file included from /home/dj/usr/src/perspective-clone/packages/perspective/src/include/perspective/build_filter.h:12:
@jpmorganchase/perspective: In file included from /home/dj/usr/src/perspective-clone/packages/perspective/src/include/perspective/filter.h:12:
@jpmorganchase/perspective: /home/dj/usr/src/perspective-clone/packages/perspective/src/include/perspective/base.h:29:10: fatal error: 'boost/unordered_map.hpp' file not found
@jpmorganchase/perspective: #include \n         ^~~~~~~~~~~~~~~~~~~~~~~~~
I'm on:
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 17.10
Release:	17.10
Codename:	artful
$ em++ --version
emcc (Emscripten gcc/clang-like replacement) 1.37.33 ()
Copyright (C) 2014 the Emscripten authors (see AUTHORS.txt)
This is free and open source software under the MIT license.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I had the same issue on ubuntu (WSL) and had to copy the boost headers to /src/boost_includes (as expected by CMake - see CMakeLists.txt in perspective package)
Changing the include to point to /usr/include would cause clash with emscripten specific includes.

Hmmm ok I see that in the CMakeLists.txt.  I'm not sure people are going to want to create a root level directory called /src/boost_includes and link it to /usr/include (or wherever their boost installation is).  Also, some people might not even have sudo ability to do that.  Am I misunderstanding what you did to solve this?
thx

I ran into the same issue few weeks ago when attempting to build on Ubuntu 16.04.
I was able to resolve the issue by copying boost folder, but without modifying cmake files.
I used the following command:  cp -R /usr/include/boost <PERSPECTIVE_ROOT>/src/include/perspective and the project build successfully.
You might be able to save hard drive space by creating symbolic link without copying full folder, but I haven't tried that approach.

Hey that worked -- thank you!

cp -r /usr/include/boost ./packages/perspective/src/include/ got it going for me. No way to script this into the build process?

There is now a PSP_DOCKER environment variable which will run the Emscripten portion of the build with a Docker packaged version of Emscripten:
PSP_DOCKER=1 npm run build


Make /ping and /issue not guildOnly

Why did it pull from my master aahhh

EXCUSE YOU

I did neither of those things


added format checking

@mikter @kjbracey-arm could you please review?

On the signedness, it does seem weird that with these checks GCC doesn't complain about signedness for format strings - eg passing unsigned integers to %d.
That can be turned on in GCC 5 or later, I believe. Might be something to add to toolchain_rules.mk. I know there are quite a few such mismatches around.


WIP: Test

This is a test

Hello @davidhadas , please do not use the official kubernetes/website for testing GitHub pull requests. There's a Contributor Playground designed specifically for this purpose. Thank you.
/close

I am sorry for the confusion - I should have clarified this in the PR description.
This PR was created due to technical problems we have with PR #38104 where the preview does not seem to work.
I created it to see if the problem is related specifically to #38104 or to the content and the conclusion it is a problem in #38104  and not the content (as the content shows up in the preview under this PR).
My bad for now clarifying this and giving the PR a proper name.


Display toast message for invalid login, fixes login form validators

Fixes https://github.com/snypy/snypy-frontend/issues/1196

Codecov Report

Merging #1326 (df2c482) into master (e83c2d0) will increase coverage by 0.21%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   42.78%   42.99%   +0.21%
==========================================
  Files          58       58
  Lines         804      807       +3
  Branches       54       55       +1
==========================================
+ Hits          344      347       +3
  Misses        452      452
  Partials        8        8

Impacted Files
Coverage Δ

src/app/components/auth/login/login.component.ts
75.00% <ø> (ø)

src/app/services/resources/auth.resource.ts
27.27% <25.00%> (-2.00%)
:arrow_down:

...rc/app/components/languages/languages.component.ts
71.42% <0.00%> (-14.29%)
:arrow_down:

...s/team-member-modal/team-member-modal.component.ts
41.66% <0.00%> (+5.55%)
:arrow_up:

src/app/layout/fullscreen/fullscreen.component.ts
66.66% <0.00%> (+11.11%)
:arrow_up:

src/app/layout/sidebar/sidebar.component.ts
100.00% <0.00%> (+20.00%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Clone move rebased

This is another pass on clone merging started with PR #68
This includes some changes that are PR'ed in #105 - happy to rebase it if it goes in ahead of this one.
From the original PR:

This implements clone_merge: a copying merge that lets the user choose how the copy is made. It also supports transforming one component type to another during the merge operation, where the user defines the transformation.
clone_merge will allocate new entity IDs in the dst world by default, but can be fed with an entity mapping to specify the mappings of IDs from src to dst world. A result_mapping can be supplied if the user wishes to know about the final mappings of src to dst world entities, which takes into account newly allocated entities as well as any replaced entities.

@kabergstrom and I have been working on this for a while to solve several problems:

A fast copy allows us to bake prefabs into legion worlds, and spawn them by copying from a prefab world to the game world
Support for transforming from one type to another allows for transforming from say, a component that describes the dimensions of a box (editor-friendly), to a component that holds a handle to a rigid body in a physics engine (runtime-friendly)
Being able to direct the copy to replace data allows us to hot-reload in an editor
The new clone_merge_single variant is used for copying data out of the game world into a cache. We can then compare future gameplay data with the cache to detect and persist changes. We use diffs for editing scenarios like undo/redo, for defining overrides for prefabs, and to provide quick local feedback (while dragging something) while also sending changes to a daemon to persist to disk.

I rebased this again and removed the changes that are in separate PRs

Is this PR waiting on something @TomGillen ?

No, I am not entirely sure if this will be the final API or not, but I don't see issue with the functionality being introduced here and I have delayed this too long already. Any further changes can be made in later PRs, so I'll merge this as it is.


Functions support

Added support for these commands:

FCALL
FUNCTION DELETE
FUNCTION FLUSH
FUNCTION KILL
FUNCTION LOAD

I wasn't able to add FUNCTION LIST and FUNCTION STATS because they respond with RESP3 which isn't supported by Netty (https://github.com/netty/netty/issues/11449). Also FUNCTION DUMP and FUNCTION RESTORE because they use bulk strings to send raw bytes and I wasn't sure how to handle that.
Also, I updated Kotlin to the latest version because I was experiencing some weird issues with compilation and updating fixed it. Detekt didn't work with the new version so I updated it aswell.
EDIT: INFO modules returns now more things than just the installed modules so I also accounted for that

thanks for your contribution @vytskalt 😊
Will review the PR and check whats wrong with this codecov bot failing the code coverage even when we have about 50%+ code coverage.

thanks for your contribution @vytskalt blush
Will review the PR and check whats wrong with this codecov bot failing the code coverage even when we have about 50%+ code coverage.

Any ETA?

@vytskalt will review and merge this PR by end of this week.


Missing docker-entrypoint.sh in latest image?

Hi, I have been using a dockerised neo4j for quite a while without issue, my dockerfile has always fetched the latest image.
I am loading and executing some cypher at startup and in part of my script I use the following command;
/docker-entrypoint.sh neo4j &
this has always worked but now I am getting the error;
'No such file or direcctory'
Has docker-entrypoint.sh been removed?

It moved to /startup/docker-entrypoint.sh


Layout bug

Godot version: 3.2.3
The layout is bugged, i can't move anything and i can't see the scripts
Steps to reproduce: I just clicked in my project and cliked to edit

Related to https://github.com/godotengine/godot/issues/43235. Can you try deleting your editor cache folder as described in that issue?

i did it, in my secondary project the editor is working normally, but in my
main project it got worse

@nicolascanova Does it get better if you un-maximize and resize the editor windwo?

no

uninstalled and reinstalled the editor and still this error continues

every time i try to edit the editor i get this crash

In my secondary project, i didn't get this error, it's working normally

OK, NO PROBLEMS, NO WORRIES, I UNINSTALLED GODOT FROM STEAM AND FROM THE DIRECTORY AND THE PROBLEM WAS RESOLVED :)


How to use if MainViewController is not first controller in app?

I want to add SlideMenu to MainView after LoginView. SlideMenu don't show in LoginView, only show from MainView.
How to do that?
Thanks!

How did you handle it?
I'm also looking for same.

Did you try changeMainViewController?

First, login is mainVC, disable slide menu
Second, changeMainViewController as you like, enable slide menu


Best practice to restart an application

I am wondering what could be the best implementation supporting the following case:
Some middlewares need to be configured within the Startup methods. These middlewares need to use configuration coming from Json configuration files.
If the configurations are already in place, that is fine but in some scenarios - for instance during installation of a web application - we might need to ask the user for some information. E.g.: database connection string, security middleware issuer and audience, etc.
Imagine an API controller that gets this request and serializes the new Json configuration into *.json files. The rest of the application is still not aware of any of these new values.
I tried implementing a shutdown procedure using IApplicationShutdown and it seems to work in a development environment. However, I am wondering if that would be the case in production. The shutdown process might be delayed if "something" is in use or any such unexpected behavior might occur.
My question in short is; how could I make sure that a web application is shutdown (to be restarted asap) immediately so that the startup methods get invoked once again?

IApplicationShutdown.RequestShutdown should work, except that it will wait for active requests to finish. Note that if you're running in IIS the app instance will stop accepting new requests, IIS will spin up a new instance as soon as the next request arrives (and re-run Startup), and this new instance does not affect the old instance that is in the process of shutting down.

Thank you @Tratcher. That provides the explanation I needed.
I have successfully implemented an API controller that has three actions:
RequestShutdown, MonitorShutdownRequest and AcknowledgeShutdown.
Everything seems to work.
Thank you.


Object expressions inside templates are treated as blocks

The following code will throw an exception.
[| { test: "Test", dummy: "Dummy" } |]

This is because the template content starts with the character {, which is treated as a block start. In order to force the evaluation function to treat it as an object expression, all scripts that start with { should be surrounded by parentheses.
There is a downside to this. If the user wants to start the template contents with a block, he will have to write dummy code, such that the first character isn't {, and the engine doesn't surround the content with parentheses.
[| /* BLOCK */ {
    ....
} |]

Fixed.


Create V1_Kodadot Logo and Guides

![Uploading kodadot logo Black BCG.png…](

)

Kodadot Brand guidelines.pdf

LGTM 👀
køda ł

Hey! could we have svg version?

Added all logos to v2 folder -- https://github.com/kodadot/kodadot-presskit/tree/main/v2

Hey! could we have svg version?

Continue here @roiLeo  hope someone (@XyloDrone) will deliver! https://github.com/kodadot/kodadot-presskit/issues/15


feat: mach-o certificate parsing implemented with der_parser

As discussed in #235, implementing the certificate parsing with der_parser to reduce dependencies and potential headaches.
Depends on #275, as the ASN.1 parsing functions were specific to PE before this PR.

Open to discussing how much CMS data we return.
Currently we expose the following:
Certificate {
      issuer: c.x509.issuer.to_string(),
      subject: c.x509.subject.to_string(),
      is_self_signed: c.x509.issuer
          == c.x509.subject,
  }


fix: update license reference

Pull Request Guidelines
Our guidelines for submitting a pull request.
Before submitting your PR, please verify the following:

[x] The commit message follows our guidelines:

Make sure you prefix your commit message with the type of change you are making.

Fixing a bug : fix: description of the change.
Adding a new feature : feat: description of the change.

See the options for the different types of changes you can make in the package.json file of your project.
Leave the options below unchecked if they are not applicable to your Pull Request.

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Test
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If yes Please describe the impact and mitigation strategy for existing applications.
What was changed?
Commit 9198ef2f631f17f493349b8750bfa48c46e70637 renamed the license file. This PR adjusts sources to changes.
Other information
Any other information that is important to this PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.95%. Comparing base (3a25d49) to head (acb5f7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   88.35%   87.95%   -0.40%
==========================================
  Files          24       24
  Lines         816      789      -27
  Branches      138      138
==========================================
- Hits          721      694      -27
  Misses         95       95

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for audio in 32-bit float WAV file

_createWaveFileBlobFromAudioBuffer supports saving the buffer in a
32-bit float wav file.
Disabled the 16-bit format in favor of 32-bit float format.

On Mar 17, 2017 3:37 PM, "Hongchan Choi"<EMAIL_ADDRESS>wrote:
@hoch commented on this pull request.
If you can confirm the bit-float conversion, I will check out this change
(to fix few nits) and merge it.
In app/canopy-app.html
https://github.com/hoch/canopy/pull/79#discussion_r106757713:

@@ -338,9 +338,9 @@

Choose format...

     <paper-item>WAV (RIFF) 16-bit PCM</paper-item>

     <paper-item disabled>WAV (RIFF) 16-bit PCM</paper-item>

This should not be disabled because user might want to get the truncated
16-bit version.
Right. But I don't know what happens if both are enabled. How does the
float method get called?

In app/js/canopy-exporter.js
https://github.com/hoch/canopy/pull/79#discussion_r106757899:

@@ -29,7 +29,16 @@
targetArray[offset + 3] = (aNumber >> 24) & 255;  // byte 4
}

// TODO: Does 32 bit float work??

// Return the bits of the float as a 32-bit integer value.  This
// produces the raw bits; no intepretation of the value is done.
function _floatBits (f) {

Is this the only way of doing the conversion? Seems very wasteful. We are
creating 3 arrays for 1 value.
A search a few years ago only came up with this method on stack overflow.
It's pretty hard to do correctly. Would probably have to call log2 to get
an exponent, multiply by 2^n to get the fraction bits, and then pack
everything back together carefully in IEEE format. Doable, I think. Friends
complicate things a lot.
A smart compiler could reduce this to at most a memory write and read.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hoch/canopy/pull/79#pullrequestreview-27701427, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAofPDnFwDsVcMKmSuO7vg4RXPMHVW5Pks5rmwtEgaJpZM4MXdOQ
.


Relocating CacheProfile to Caching.Abstractions

The idea here is to move the CacheProfile from MVC https://github.com/aspnet/Mvc/blob/760c8f38678118734399c58c2dac981ea6e47046/src/Microsoft.AspNetCore.Mvc.Core/CacheProfile.cs to the Microsoft.Extensions.Caching.Abstractions package. The CacheProfile can then be resolved by middlewares such as ResponseCaching. Configuring the profile can also be implemented in a similar fashion to CORS options/policy.
cc @davidfowl @rynowak @Tratcher

Do we have a way of doing this without a breaking change?

Name it CachePolicy instead and have CacheProfile derive from CachePolicy

Yeah that could work! Probably 😄


⚠ Bofrost.lu has degraded performance

In 33e8eca, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1283 ms

Resolved: Bofrost.lu performance has improved in 980efae after 9 minutes.


API: Modify EM Submission POST Endpoint Validations

[ ] Modify EM submission POST endpoint so that the closed date cannot be before the open date

Error Message: closeDate can not be a date before the entered openDate

@acollad1 Can the closeDate be same as openDate?

Pull Request: https://github.com/US-EPA-CAMD/easey-camd-services/pull/132

EM submission POST endpoint has been modified so that the closed date cannot be before the open date. Error message fires as expected.


Enum string converter is not respected using .NET 6 minimal API

Using Swashbuckle.AspNetCore 6.2.3 with ASP.NET 6 minimal API, I have configured JSON serializer options per the docs.
services.Configure<JsonOptions>(options =>
{
    options.SerializerOptions.Converters.Add(new JsonStringEnumConverter());
    options.SerializerOptions.PropertyNamingPolicy = JsonNamingPolicy.CamelCase;
    options.SerializerOptions.ReferenceHandler = ReferenceHandler.Preserve;
});

However, Swagger UI still reports enums as ints unless I add also use AddControllers().AddJsonOptions():
services.AddControllers()
	.AddJsonOptions(options =>
	{
            options.JsonSerializerOptions.Converters.Add(new JsonStringEnumConverter());
            options.JsonSerializerOptions.PropertyNamingPolicy = JsonNamingPolicy.CamelCase;
            options.JsonSerializerOptions.ReferenceHandler = ReferenceHandler.Preserve;
        });

Once the second block is added, the swagger UI output references the enum string values as expected. As far as I know, the latter simply does the former under the hood, but there seems to be some order of operations affecting the schema generation here?

Looking into this some more, it looks like the problem may be in SwaggerGenServiceCollectionExtensions.cs, line 34:
#if (!NETSTANDARD2_0)
                var serializerOptions = s.GetService<IOptions<JsonOptions>>()?.Value?.JsonSerializerOptions
                    ?? new JsonSerializerOptions();
#else
                var serializerOptions = new JsonSerializerOptions();
#endif

The problem here is that the JsonOptions type is pulled from the Microsoft.AspNetCore.Mvc namespace while .NET 6 minimal APIs are documented to use JsonOptions from the Microsoft.AspNetCore.Http.Json namespace which this code seems blissfully unaware of. Not sure what the path forward is.

I ran into the same problem and my colleague suggested the following as a workaround, which works for me:
using Microsoft.AspNetCore.Http.Json;
using MvcJsonOptions = Microsoft.AspNetCore.Mvc.JsonOptions;
.....
builder.Services.Configure<JsonOptions>(o => o.SerializerOptions.Converters.Add(new JsonStringEnumConverter()));
builder.Services.Configure<MvcJsonOptions>(o => o.JsonSerializerOptions.Converters.Add(new JsonStringEnumConverter()));

@RCSandberg yep, I ended up configuring both. I'm not sure there's a better way without added complexity. Microsoft has a recent history of duplicating entire namespaces for new framework/features. I get it for compatibility reasons, but it makes things like this a real pain.

You can always use NewtonsoftJson
it is in nuget     <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="6.0.2" />
here are my settings
 .AddNewtonsoftJson(options =>             {                 options.SerializerSettings.ReferenceLoopHandling = ReferenceLoopHandling.Ignore;                 options.SerializerSettings.Converters.Add(new StringEnumConverter());                 options.SerializerSettings.DateTimeZoneHandling = DateTimeZoneHandling.Utc;             });

To anyone facing a similar issue as me, make sure you have the right namespace when registerting your serializer globally.
NOT - Microsoft.AspNetCore.Mvc - JsonOptions
YES - Microsoft.AspNetCore.Http.Json - JsonOptions
It was in the docs but i missed it when migrating to minimal api's since the namings are ver similar.

This has worked for me:
using System.Text.Json.Serialization;
builder.Services.Configure<Microsoft.AspNetCore.Http.Json.JsonOptions>(options =>
{
options.SerializerOptions.DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull;
options.SerializerOptions.Converters.Add(new JsonStringEnumConverter());
});
[https://learn.microsoft.com/en-us/aspnet/core/fundamentals/minimal-apis?view=aspnetcore-6.0]

Swashbuckle.AspNetCore 6.4.0 picks up changes from "Microsoft.AspNetCore.Mvc.JsonOptions" options. However, minimal APIs are using "Microsoft.AspNetCore.Http.Json.JsonOptions". Therefore, both of them needs to be configured for Swagger schemas to match the API output.
It would be nice if Swashbuckle can be configured to use "Microsoft.AspNetCore.Http.Json.JsonOptions".

@wrkntwrkn and @stvwndr helped lead me to the workaround that I'm using:
builder.Services.Configure<Microsoft.AspNetCore.Http.Json.JsonOptions>(options =>
{
	options.SerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
});
builder.Services.Configure<Microsoft.AspNetCore.Mvc.JsonOptions>(options =>
{
	options.JsonSerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
});

Thank you, this works as expected!

The below workaround works on the schema.
builder.Services.Configure<Microsoft.AspNetCore.Http.Json.JsonOptions>(options =>
{
	options.SerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
});
builder.Services.Configure<Microsoft.AspNetCore.Mvc.JsonOptions>(options =>
{
	options.JsonSerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
});

However, I had to use AddContollers to get it working with the swagger example.
builder.Services.AddControllers()
    .AddJsonOptions(options =>
        options.JsonSerializerOptions.Converters.Add(new JsonStringEnumConverter()));

No luck for me on either front.
        srv.Configure<Microsoft.AspNetCore.Http.Json.JsonOptions>(options =>
        {
            options.SerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
        });
        srv.Configure<Microsoft.AspNetCore.Mvc.JsonOptions>(options =>
        {
            options.JsonSerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
        });

Swagger still shows enums as integers:

I'm using .Net7, and this issue still exists.
Here's my project setup:
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.5" />
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.18.1" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />

Here's my code:
public record DemoObject
{
    [JsonConverter(typeof(JsonStringEnumConverter))]
    public DemoEnum DemoProperty { get; init; }
}

public enum DemoEnum : int { PlanA = 9, PlanB = 13 }

[Route("api/[controller]")]
[ApiController]
public class DemoController : ControllerBase
{
    [HttpGet("demo")]
    public DemoObject DemoAction() => new() { DemoProperty = DemoEnum.PlanB };
}

As you can see, I decorated enum field with JsonConverterAttribute, using JsonStringEnumConverter as attribute parameter.
If I hit "execute", I can get PlanB in response as expected.
However, when generating "Example value", the json serializer serialized enum field as integer, as the screenshot below demonstrates.

I'm using .Net7, and this issue still exists. Here's my project setup:
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.5" />
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.18.1" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />

Here's my code:
public record DemoObject
{
    [JsonConverter(typeof(JsonStringEnumConverter))]
    public DemoEnum DemoProperty { get; init; }
}

public enum DemoEnum : int { PlanA = 9, PlanB = 13 }

[Route("api/[controller]")]
[ApiController]
public class DemoController : ControllerBase
{
    [HttpGet("demo")]
    public DemoObject DemoAction() => new() { DemoProperty = DemoEnum.PlanB };
}

As you can see, I decorated enum field with JsonConverterAttribute, using JsonStringEnumConverter as attribute parameter. If I hit "execute", I can get PlanB in response as expected. However, when generating "Example value", the json serializer serialized enum field as integer, as the screenshot below demonstrates.

I can confirm that the issue still persists for me too.

I managed to get this fully working for minimal API scenarios by decorating the enum type itself with JsonConverterAttribute.
Tested on NET7 and NET8 RC1:
using System.Text.Json.Serialization;
using Microsoft.AspNetCore.Mvc;

// var builder = WebApplication.CreateSlimBuilder(args); -NET8-
var builder = WebApplication.CreateBuilder(args);

builder.Services.AddEndpointsApiExplorer();
builder.Services.AddSwaggerGen();

var app = builder.Build();

// OK
app.MapPost("postDemo", (RequestDto dto) => TypedResults.Ok(new ResponseDto(dto.Enum)));

// Does not work, query param schema is string
app.MapGet("getDemo1", (DemoEnum? enumParameter) => TypedResults.Ok(new ResponseDto(enumParameter)));

// OK
app.MapGet("getDemo2", ([FromQuery] DemoEnum? enumParameter) => TypedResults.Ok(new ResponseDto(enumParameter)));

// OK
app.MapGet("getDemo3", ([AsParameters] Parameters parameters) => TypedResults.Ok(new ResponseDto(parameters.EnumParameter)));

app.UseSwagger();
app.UseSwaggerUI();
app.Run();

public struct Parameters
{
    [FromQuery]
    public DemoEnum? EnumParameter { get; set; }
}

public sealed record RequestDto(DemoEnum? Enum);
public sealed record ResponseDto(DemoEnum? Enum);

// [JsonConverter(typeof(JsonStringEnumConverter<DemoEnum>))] -NET8-
[JsonConverter(typeof(JsonStringEnumConverter))]
public enum DemoEnum
{
    FirstValue,
    SecondValue,
}

[JsonConverter(typeof(JsonStringEnumConverter))]
public enum DemoEnum

Thanks this works for me. But of course decorating all enums with that is far from ideal, it would be nice if ASPNET respected the serializer converter.

I managed to get this fully working for minimal API scenarios by decorating the enum type itself with JsonConverterAttribute.
Tested on NET7 and NET8 RC1:
using System.Text.Json.Serialization;
using Microsoft.AspNetCore.Mvc;

// var builder = WebApplication.CreateSlimBuilder(args); -NET8-
var builder = WebApplication.CreateBuilder(args);

builder.Services.AddEndpointsApiExplorer();
builder.Services.AddSwaggerGen();

var app = builder.Build();

// OK
app.MapPost("postDemo", (RequestDto dto) => TypedResults.Ok(new ResponseDto(dto.Enum)));

// Does not work, query param schema is string
app.MapGet("getDemo1", (DemoEnum? enumParameter) => TypedResults.Ok(new ResponseDto(enumParameter)));

// OK
app.MapGet("getDemo2", ([FromQuery] DemoEnum? enumParameter) => TypedResults.Ok(new ResponseDto(enumParameter)));

// OK
app.MapGet("getDemo3", ([AsParameters] Parameters parameters) => TypedResults.Ok(new ResponseDto(parameters.EnumParameter)));

app.UseSwagger();
app.UseSwaggerUI();
app.Run();

public struct Parameters
{
    [FromQuery]
    public DemoEnum? EnumParameter { get; set; }
}

public sealed record RequestDto(DemoEnum? Enum);
public sealed record ResponseDto(DemoEnum? Enum);

// [JsonConverter(typeof(JsonStringEnumConverter<DemoEnum>))] -NET8-
[JsonConverter(typeof(JsonStringEnumConverter))]
public enum DemoEnum
{
    FirstValue,
    SecondValue,
}

Thanks, this also works in NET6!

I managed to get this fully working for minimal API scenarios by decorating the enum type itself with JsonConverterAttribute.
Tested on NET7 and NET8 RC1:
using System.Text.Json.Serialization;
using Microsoft.AspNetCore.Mvc;

// var builder = WebApplication.CreateSlimBuilder(args); -NET8-
var builder = WebApplication.CreateBuilder(args);

builder.Services.AddEndpointsApiExplorer();
builder.Services.AddSwaggerGen();

var app = builder.Build();

// OK
app.MapPost("postDemo", (RequestDto dto) => TypedResults.Ok(new ResponseDto(dto.Enum)));

// Does not work, query param schema is string
app.MapGet("getDemo1", (DemoEnum? enumParameter) => TypedResults.Ok(new ResponseDto(enumParameter)));

// OK
app.MapGet("getDemo2", ([FromQuery] DemoEnum? enumParameter) => TypedResults.Ok(new ResponseDto(enumParameter)));

// OK
app.MapGet("getDemo3", ([AsParameters] Parameters parameters) => TypedResults.Ok(new ResponseDto(parameters.EnumParameter)));

app.UseSwagger();
app.UseSwaggerUI();
app.Run();

public struct Parameters
{
    [FromQuery]
    public DemoEnum? EnumParameter { get; set; }
}

public sealed record RequestDto(DemoEnum? Enum);
public sealed record ResponseDto(DemoEnum? Enum);

// [JsonConverter(typeof(JsonStringEnumConverter<DemoEnum>))] -NET8-
[JsonConverter(typeof(JsonStringEnumConverter))]
public enum DemoEnum
{
    FirstValue,
    SecondValue,
}

Thanks, this also works in NET6!

Just noting that another approach here is the below lines:
    builder.Services.AddTransient<ISerializerDataContractResolver>(_ => new JsonSerializerDataContractResolver(
        new JsonSerializerOptions {
             // set whatever default options for JSON serialization you want like enums, PropertyNamingPolicy, or whatever
        }
    ));

I think the comment at https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2293#issuecomment-991870685 is correct that this is the bug because of this code: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/8f363f7359cb1cb8fa5de5195ec6d97aefaa16b3/src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenServiceCollectionExtensions.cs#L33-L43
The code in the #else block just uses the default JsonSerializerOptions if the code isn't NETSTANDARD2_0 which includes net8.0.

The following method was used to collect the Serializer settings in one place.
builder.Services.TryAddTransient<ISerializerDataContractResolver>(s =>
{
    var httpJsonOptions = s.GetRequiredService<IOptions<Microsoft.AspNetCore.Http.Json.JsonOptions>>();
    var serializerOptions = httpJsonOptions.Value.SerializerOptions;
    return new JsonSerializerDataContractResolver(serializerOptions);
});

Just checked with the latest Swashbuckle packages versions and this issue still relevant. Configuring both "classic" and "minimal" JsonOptions suggested above works, yet a bit bothering to have.

The following method was used to collect the Serializer settings in one place.
builder.Services.TryAddTransient<ISerializerDataContractResolver>(s =>
{
    var httpJsonOptions = s.GetRequiredService<IOptions<Microsoft.AspNetCore.Http.Json.JsonOptions>>();
    var serializerOptions = httpJsonOptions.Value.SerializerOptions;
    return new JsonSerializerDataContractResolver(serializerOptions);
});

builder.Services.AddSwaggerGen(options =>
{
    // ...
});

It works. Thanks

A comment to prevent this one from closing due to inactivity, as I believe it's still applicable and does have all the information for the reproduction.

Just noting that another approach here is the below lines:
    builder.Services.AddTransient<ISerializerDataContractResolver>(_ => new JsonSerializerDataContractResolver(
        new JsonSerializerOptions {
             // set whatever default options for JSON serialization you want like enums, PropertyNamingPolicy, or whatever
        }
    ));

I think the comment at #2293 (comment) is correct that this is the bug because of this code:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/8f363f7359cb1cb8fa5de5195ec6d97aefaa16b3/src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenServiceCollectionExtensions.cs#L33-L43
The code in the #else block just uses the default JsonSerializerOptions if the code isn't NETSTANDARD2_0 which includes net8.0.

This might be the problem. The code inside the #if (!NETSTANDARD2_0) is using the Microsoft.AspNetCore.Mvc.JsonOptions instead of the Microsoft.AspNetCore.Http.Json.JsonOptions.

Looking into this some more, it looks like the problem may be in SwaggerGenServiceCollectionExtensions.cs, line 34:
#if (!NETSTANDARD2_0)
                var serializerOptions = s.GetService<IOptions<JsonOptions>>()?.Value?.JsonSerializerOptions
                    ?? new JsonSerializerOptions();
#else
                var serializerOptions = new JsonSerializerOptions();
#endif

The problem here is that the JsonOptions type is pulled from the Microsoft.AspNetCore.Mvc namespace while .NET 6 minimal APIs are documented to use JsonOptions from the Microsoft.AspNetCore.Http.Json namespace which this code seems blissfully unaware of. Not sure what the path forward is.

Maybe the best option would be to have something like this:
builder.Services.AddSwaggerGen(options => options.EnableMinimalApi());

Isn't it because AspNetCore.Mvc.JsonOptions.JsonSerializerOptions is never null?
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenServiceCollectionExtensions.cs#L81
#if !NETSTANDARD2_0
                serializerOptions =
                    _serviceProvider.GetService<IOptions<AspNetCore.Mvc.JsonOptions>>()?.Value?.JsonSerializerOptions
#if NET8_0_OR_GREATER
                    ?? _serviceProvider.GetService<IOptions<AspNetCore.Http.Json.JsonOptions>>()?.Value?.SerializerOptions
#endif
#if NET7_0_OR_GREATER
                    ?? JsonSerializerOptions.Default;
#else
                    ?? new JsonSerializerOptions();
#endif

This code will never get SerializerOptions from AspNetCore.Http.Json.JsonOptions.


FormFlow stuck after form is finished

I'm testing AnnotatedSandwichBot. I enter values for all prompts until the form is "finished".
After the form reached the finished state the bot seems to always respond with an empty reply.

Normally, you would have a caller for the FormDialog that would take some action upon the completion of the form.  If you want to start a new sandwich order, you can change the conversation ID in the emulator.

So does this mean that the bot framework Emulator doesn't completely emulate the caller for the FormDialog?

can you please help mmu with my question ? https://stackoverflow.com/questions/42298992/how-to-call-formflow-after-user-choose-an-option-from-quickreply-in-chatbot

@IntranetFactory the emulator just posts to the activity endpoint for your bot web service.  If you want to use the result of the FormFlow dialog, you should have some root dialog that calls the FormFlow dialog as a child.

@stelazh please don't cross link across multiple GitHub issues to a single stack overflow issue unless that issue is relevant to the GitHub issue.


Check for Netlify deploy URLs in base tag

- Summary
The <base> tag is currently set to Hugo's $.Site.BaseURL. This is great for production builds, but doesn't work well with Netlify deploy previews — anchors/network requests on deploy previews still point to the production server, making it difficult to test changes.
- Test plan
Tested on an existing site build and fresh install.
- Description for the changelog
This change checks for the CONTEXT env, then serves the URL or DEPLOY_PRIME_URL for production & previews, respectively - falling back to $.Site.BaseURL.

Wondering if we should even be using a base URL, as I know of production Hugo sites on Netlify that don't use them at all and previews just work.
Anyhow, this is a great improvement! Thanks!


error in default compose file

happens since this change https://github.com/calcom/docker/commit/c283a92614b54319a402207dd5de4e3e98751931
ERROR: The Compose file './docker-compose.yaml' is invalid because:
services.studio.profiles contains an invalid type, it should be an array
services.studio.volumes contains an invalid type, it should be an array

@kelvinalfaro this was introduced in your last commit. Are you able to address this?

This is still broken, any chance of fixing it?

I'm getting:
services.studio.volumes must be a list

I think you guys are on docker-compose v2 and need to update to v3, or something similar. @jschulman @klipitkas can you try and let us know? Thank you

Was waiting for @kelvinalfaro but I'll jump on this today if still unresponsive

I think you guys are on docker-compose v2 and need to update to v3, or something similar. @jschulman @klipitkas can you try and let us know? Thank you

I'm running Docker version 20.10.17, build 100c701 with the latest docker-compose plugin.
What's weird is the DOCKER_BUILDKIT=0 isn't working.  Even tried exporting it as a global var and still get the:
network mode "stack" not supported by buildkit

Indeed I am using docker compose v2:
$ docker compose version
Docker Compose version v2.6.1

I have patched the yaml file for now to make it work, attaching my patched version below that kind of works for me:
version: '3.1'

volumes:
  database-data:
  db-data:

networks:
  stack:
    name: stack
    external: false

services:
  database:
    image: postgres # profiles: ["withpostgres"] only starts when specifying this profile
    restart: unless-stopped
    volumes:
      - database-data:/var/lib/postgresql/data/
    env_file: .env
    networks:
      - stack
    healthcheck:
      test: ["CMD-SHELL", "pg_isready"]
      interval: 10s
      timeout: 5s
      retries: 5

  calcom:
    build:
      context: .
      dockerfile: Dockerfile
      args:
        - NEXT_PUBLIC_WEBAPP_URL=${NEXT_PUBLIC_WEBAPP_URL}
        - NEXT_PUBLIC_LICENSE_CONSENT=${NEXT_PUBLIC_LICENSE_CONSENT}
        - CALCOM_TELEMETRY_DISABLED=${CALCOM_TELEMETRY_DISABLED}
        - NEXTAUTH_SECRET=${NEXTAUTH_SECRET}
        - CALENDSO_ENCRYPTION_KEY=${CALENDSO_ENCRYPTION_KEY}
        - DATABASE_URL=${DATABASE_URL}
      network: stack
    restart: always
    networks:
      - stack
    ports:
      - ${PORT-3000}:3000
    env_file: .env
    environment:
      - DATABASE_URL=${DATABASE_URL}
      - NODE_ENV=development
      - POSTGRES_PASSWORD = ""
      - POSTGRES_HOST_AUTH_METHOD = trust
    depends_on:
      database: # comment out when using non-docker database (=enabled "withpostgres" profile)
        condition: service_healthy
    volumes:
      - "./calendso:/app/"
      - "./scripts:/app/scripts"

# Optional use of Prisma Studio. To use *with* Prisma Studio:
# docker-compose --profile withstudio up
  studio:
    image: calendso/calendso:latest
    container_name: calendso-studio
    restart: unless-stopped
    profiles: ["withstudio"] # only starts when specifying this profile
    networks:
      - stack
    ports:
      - 5555:5555
    volumes:
      - db_data
    env_file: .env
    environment:
      - DATABASE_URL=${DATABASE_URL}
    depends_on:
      database: # comment out when using non-docker database (=enabled "withpostgres" profile)
        condition: service_healthy
    command:
      - npx
      - prisma
      - studio

I also have the database connection issue when building the calcom image so I guess this might be related to docker compose v2 as well.

We just reverted the previous changes via #139
This may sound redundant, but on the network issue, can you confirm for me that you are running docker compose up -d database prior to the build step?

Just checked and it's still running:
57adabe5e154   postgres                          "docker-entrypoint.s…"   17 hours ago   Up 17 hours           5432/tcp                                                                                calendso-db

Yes me too, my postgres is still running from the morning when I tried to last build it:
CONTAINER ID   IMAGE      COMMAND                  CREATED        STATUS                  PORTS      NAMES
947776dd00a9   postgres   "docker-entrypoint.s…"   11 hours ago   Up 11 hours (healthy)   5432/tcp   calcom-docker-database-1

when using up --force-recreate that solves. but
@calcom/prisma:db-deploy: Error: P1001: Can't reach database server at `db`:`5432`
@calcom/prisma:db-deploy:
@calcom/prisma:db-deploy: Please make sure your database server is running at `db`:`5432`.
@calcom/prisma:db-deploy: error Command failed with exit code 1.
@calcom/prisma:db-deploy: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@calcom/prisma:db-deploy: error Command failed with exit code 1.
@calcom/prisma:db-deploy: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@calcom/prisma:db-deploy: ERROR: command finished with error: command (packages/prisma) yarn run db-deploy exited (1)

the build is broken in more than one way

The above can be addressed in a new issue. Need to see details related to potential changes in the docker-compose file, as the default network address for the database container is database not db as indicated by the log.
Closing this as the original issue in this thread is resolved


fix: added the link to ViteConf 2023 replay (fix #16689)

Description

The link to viteConf 2023 replay was changed to direct youtube link

Thanks for the heads up, we'll get this fixed on the site.

Closing as the link is fixed.


Documentation is missing

The readme points to a link to the documentation, but the link gives a 404.
It's hard to use this without proper documentation.

Added docs http://adonisjs.com/docs/3.1/internationalization


Fix syntax highlighting in README

$ pygmentize -L | grep -A1 -E '^[*] (bash|console),'
* bash, sh, ksh, zsh, shell:
    Bash (filenames *.sh, *.ksh, *.bash, *.ebuild, *.eclass, *.exheres-0, *.exlib, *.zsh, .bashrc, bashrc, .bash_*, bash_*, zshrc, .zshrc, PKGBUILD)
--
* console, shell-session:
    Bash Session (filenames *.sh-session, *.shell-session)

You want the latter lexer.

Ah, I see. Thanks for the fix!

This has been merged/released in 1.1.3


MG Module Hierarchy Section 5

I thought it was very interesting you didn't include a hardware-hiding module, considering your project is probably one with the most amount of hardware involvement since you're using an Arduino. Is there any specific reason you don't include one? Is the idea that your project actual is the hardware-hiding for whatever the end use of the measurement would be? If this is the case maybe that should be noted somewhere, only since I think it would be useful information (or honestly I can see an argument for still including it in the hierarchy as like the top-level module since the entire project is hardware-hiding). Again just something to think about.
MG

See #73


Extract gene tree links generation into overridable method

Description
This PR extracts a bit of code from one subroutine into another subroutine, so that it can then be overridden in a plugin (on the Metazoa website).
See https://github.com/EnsemblGenomes/eg-web-metazoa/pull/35 for full description and link to the sandbox.
Related JIRA Issues (EBI developers only)
https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-6878

Hi all.. I hope I'm not intruding. I have a suggested change to this module which would create an array of @current_gene_clusterset_ids to pass to the Metazoa plugin. I've made corresponding suggestions in eg-web-metazoa PR #35 which would use this array to work out the relevant set of clusterset_ids per orthologue rather than per species.
I hope you don't mind, I've suggested to remove the filtering of clustersets by species, as the implementation of GeneMember::has_GeneTree queries all clustersets at once (see here), so filtering by species is not as useful in this case as it might be in some circumstances.
diff --git a/modules/EnsEMBL/Web/Component/Gene/ComparaOrthologs.pm b/modules/EnsEMBL/Web/Component/Gene/ComparaOrthologs.pm
index 4d038b1680..fc2ee11dcc 100644
--- a/modules/EnsEMBL/Web/Component/Gene/ComparaOrthologs.pm
+++ b/modules/EnsEMBL/Web/Component/Gene/ComparaOrthologs.pm
@@ -201,6 +201,15 @@ sub content {
       $rev_lookup->{$info->{'species_url'}} = $prod_name;
     }
   }
+
+  my @current_gene_clusterset_ids;
+  if (exists $species_defs->multi_hash->{'DATABASE_COMPARA'}{'METAZOA_CLUSTERSETS'}) {
+    my @metazoa_clusterset_ids = ('default', 'protostomes', 'insects', 'pangenome_drosophila');  # gene-tree links are displayed in this order
+    @current_gene_clusterset_ids = grep {
+      ($_ eq 'default' && $availability->{'has_gene_tree'})
+      || $availability->{"has_gene_tree_${_}"}
+    } @metazoa_clusterset_ids;
+  }

   foreach my $species (sort { ($a =~ /^<.*?>(.+)/ ? $1 : $a) cmp ($b =~ /^<.*?>(.+)/ ? $1 : $b) } keys %orthologue_list) {
     next unless $species;
@@ -337,7 +346,7 @@ sub content {

       my $tree_links = $self->create_gene_tree_links({
-        species => $species, # the species parameter only becomes relevant in the Metazoa plugin
+        current_gene_clusterset_ids => \@current_gene_clusterset_ids,  # the current_gene_clusterset_ids parameter only becomes relevant in the Metazoa plugin
         cdb => $cdb,
         stable_id => $stable_id,
         orthologue => $orthologue

Please disregard my previous comment. As @azangru has suggested, the same thing could be achieved by passing the $availability variable.


Flexible plugins configuration

The reason to do so:

plugins's order is important(influence the invoke order of transactions, events, etc)
when need to disable some plugin in first loading by some config, there is no way to do it

So is the way below is more flexible plugins configuration?
let isAndroid = true; // some config pass by useragent or something else;
let somePlugin = xxx;
let state = EditorState.create({
  schema,
  props,
  plugins: [
    isAndroid ? somePlugin : null,
    otherPlugin
  ]
});

How about something like plugins: [...isAndroid: [somePlugin] : [], ...otherPlugins]?

Is also a solution, but not intuitive though 😂😂😂

What's "intuitive" is always hard to argue, but I prefer the simpler types of the current way it works.


Water Dupe with the Cupboard

Minecraft v1.16.4
If a Cupboard is placed in water that is only one block deep, the top half will still become waterlogged. Breaking the cupboard also deletes the water source instead of leaving it behind. Some blocks are also missing waterlogging, which would be nice to see.
Another couple of things I've noticed is that the  Iron Rod can be given the tag #forge:rods/iron, for compat with other mods that use it, such as the Ultimate Car mod or Silent Gear. Also, a lot of the blocks are too large when placed in an item frame.

The Cupboard thing I'm aware of, I've tried to fix it but will probably just remove waterlogging on it. The Iron Rod is already tagged #forge:rods/iron. I'll take a look at the Item frame thing.

Thanks!
From taking a quick look, it looks like it could be happening because the getStateForPlacement is setting the state to be waterlogged instead of checking if the top half is in water or air, but I'm not entirely sure.
Here's a block that I previously added waterlogging for that also has two parts.

Alright thanks, I'll take a look when I've got time!

Fixed in 202012200a.


2 dialogs crash the app when using iron-router

Referring to this:
http://stackoverflow.com/questions/32410382/html-comment-breaking-the-website
My app has two dialogs, and when I try to go from one page to another, my website crashes with the following error:
Error: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
I do not know much about this bug, except that having a comment under the first dialog crashes the website.

I don't think this has anything to do with this package, which just pulls in jQuery UI. You should report it with them if you think it's an issue: https://github.com/jquery/jquery-ui


[Refactor] Revert "[Enhancement] avoid copy user‘s data to butil::IOBuff (#15361)"

This reverts commit 546ded5bdfc4707ce4368fc772fcfcf875156558.
What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

as this increase the peak memory of instance/query, see https://github.com/StarRocks/starrocks/pull/18217
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_admit_test

@mergify backport branch-3.0


Chinese garbled code on command line output

When there are Chinese characters on the command line, there will be garbled code.
The scripts in package.json file:
  "scripts": {
    "test":"concurrently \"npm run print\"",
    "test2":"chcp 65001 && concurrently \"npm run print\"",
    "print":"echo 你好"
  }

Here is the output of npm run test:
PS D:\foo\example> npm run test

><EMAIL_ADDRESS>test D:\foo\example
> concurrently "npm run print"

[0]
[0] ><EMAIL_ADDRESS>print D:\foo\example
[0] > echo 你好
[0]
[0] ���
[0] npm run print exited with code 0

To fix this, I currently add chcp 65001 before concurrently. Here is the output of npm run test2:
PS D:\foo\example> npm run test2

><EMAIL_ADDRESS>test2 D:\foo\example
> chcp 65001 && concurrently "npm run print"

Active code page: 65001
[0]
[0] ><EMAIL_ADDRESS>print D:\foo\example
[0] > echo 你好
[0]
[0] 你好
[0] npm run print exited with code 0

Environment:

OS: Windows 11
Node.js: 14.17.5
concurrently: 7.0.0

Thanks for the report @liamwang, I suspect that this one is specific to windows as I can't reproduce it on my Mac.

ASCII characters can't be displayed properly either.

FWIW, if anyone here on an Intel machine wants to look into this, it'd be really helpful.
I'm on Apple silicon, and I'm not sure if there's any way to run Windows on it (there's no stable release of VirtualBox for it atm). Windows 365 plans are way off the mark from what I can pay right now.

I'm on Apple silicon, and I'm not sure if there's any way to run Windows on it (there's no stable release of VirtualBox for it atm). Windows 365 plans are way off the mark from what I can pay right now.

You might have more luck with https://github.com/utmapp/UTM (awesome project ❤)

Alright! So with the help of UTM I was able to reproduce this issue.
This answer on StackOverflow contains several insights. One that I found specially relevant to this issue is that "piping to other processes uses the active codepage, which by default is ASCII".
This explains the issue seen here, as concurrently uses piping unless --raw is used.
Since node expects UTF-8, concurrently could run chcp 65001 && <user command>.
I haven't found a cheaper way to set this yet (e.g. through environment variable), as chcp is an actual program which inherently has some cost.
I think there's potential for breaking something, but since Windows 10 it's possible to set UTF-8 globally to every console anyways.
WDYT?


Emit a 'radiuschanging' event

For a more advanced styling I'd need to keep track of a circle whose radius is being dragged.
Currently we only have 'radiuschanged' which is emitted once the drag has ended. So a 'radiuschanging' could come in handy.
To be consistent, a 'centerchanging' could also be added.
What do you think? would you accept a PR with this feature?

@eddydg Do you mean it should fire repeatedly every time we get a rAF slot during animation? Sounds like it would degrade performance (one of our biggest challenges).

Please put up a pull request if you have a good strategy for adding this feature!

Thank you for your answers. I'm not sure what a rAF slot is.
I was thinking about something very (too?) simple: adding
this._eventEmitter.emit('radiuschanging', this); in the set radius and
this._eventEmitter.emit('centerchanging', this); in the set center.
PR: https://github.com/smithmicro/mapbox-gl-circle/pull/77
I am not seeing any visible difference in performance but I am keeping a very light playground: http://lab.meltedpeng.com/mapbox-gl-circle/


[Pomodoro] Update to be able to show / hide menu bar icon

Description
Added the ability to hide the app from the menu bar. The corollary: also added the able to show the menu bar once it is hidden.
Screencast

Checklist

[x] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast
[X] I checked that files in the assets folder are used by the extension itself
[X] I checked that assets used by the README are placed outside of the metadata folder

Hmm looks like the check got flagged for style, yet I ran ray fix-lint with no issues. Any advice?

Ahhh, I guess some small indentation slipped through. Fixed now!

Do you mind taking this @KELiON

@pernielsentikaer @KELiON any update on looking at this?

Hi @adamsiwiec 👋
Do you mind fixing the conflicts before we can merge 😊


Buckets v2 Merged

apiv2 buckets

Also, we should use SERVICE_ACCOUNT_CREDENTIALS because that is more descriptive of what the value is.  Also, it is the value we were using before and is documented, so it's less hassle to use that.  I just made a commit on this branch to change everything over for that though.


Output description using images or knit documents

Can the developers release the outputs obtained (in image form or in the form of knit documents)?

Hi satviktiwari,
Thank for the comment. According to what I can understand from your issue: all the outputs can be obtained by replicating the results executing  Meta_clustering_tutorial.Rmd. We have just updated the .Rmd file as well as its HTML version (which can be printed in PDF also) to show some plots that were not available in the previous version. Not sure if this solves your request, feel free to let me know if this does not solve your request.

Yeah it's what I had requested for. Thanks for the quick response. I will go through them all. Great work by the way:)


python310Packages.python-lsp-server: 1.7.3 -> 1.7.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-lsp-server is: Python implementation of the Language Server Protocol
meta.homepage for python310Packages.python-lsp-server is: https://github.com/python-lsp/python-lsp-server
meta.changelog for python310Packages.python-lsp-server is: https://github.com/python-lsp/python-lsp-server/blob/v1.7.4/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.7.4 with grep in /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4
found 1.7.4 in filename of file in /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4

Rebuild report (if merged into master) (click to expand)

21 total rebuild path(s)

21 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pyls-flake8
python310Packages.pyls-isort
python310Packages.pyls-memestra
python310Packages.pyls-spyder
python310Packages.pylsp-mypy
python310Packages.pylsp-rope
python310Packages.python-lsp-black
python310Packages.python-lsp-ruff
python310Packages.python-lsp-server
python310Packages.spyder
python311Packages.pyls-flake8
python311Packages.pyls-isort
python311Packages.pyls-memestra
python311Packages.pyls-spyder
python311Packages.pylsp-mypy
python311Packages.pylsp-rope
python311Packages.python-lsp-black
python311Packages.python-lsp-ruff
python311Packages.python-lsp-server
python311Packages.spyder
spyder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-lsp-server https://github.com/r-ryantm/nixpkgs/archive/62b79368803f82f1435dc099fd0f71559be3530e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4
ls -la /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

spyder (python310Packages.spyder)
python311Packages.spyder

18 packages built:

python310Packages.pyls-flake8
python310Packages.pyls-isort
python310Packages.pyls-memestra
python310Packages.pyls-spyder
python310Packages.pylsp-mypy
python310Packages.pylsp-rope
python310Packages.python-lsp-black
python310Packages.python-lsp-ruff
python310Packages.python-lsp-server
python311Packages.pyls-flake8
python311Packages.pyls-isort
python311Packages.pyls-memestra
python311Packages.pyls-spyder
python311Packages.pylsp-mypy
python311Packages.pylsp-rope
python311Packages.python-lsp-black
python311Packages.python-lsp-ruff
python311Packages.python-lsp-server

Maintainer pings
cc @fabaff for testing.

@ofborg build python310Packages.python-lsp-server python310Packages.python-lsp-server.passthru.tests


[feature] generate .travis.yml

Auto-generate a .travis-ci.yml based on fogg.json.
This introduced a new top-level config in fogg.json for configuring things about travis ci.
When enabled it will use the accounts config to set up profiles and then bucket all the components and modules into a configured number of buckets.

@edulop91 good idea


deps: remove upper bound on pyarrow version

Note: This is an empty PR. It is included so that the changes from #155 are documented in the changelog.
Fixes #161  🦕

@tswast Thank you!


Enhance "No Favourites Found" user experience with an image

Issue Description:
Currently, when there are no favourites found, the application displays the message "Find your favorite restaurants now" followed by an image. However, the existing image may not be very user-friendly or aesthetically pleasing. This can impact the overall user experience.
Expected Behavior:
We should enhance the user experience by replacing the existing image with a more visually appealing and user-friendly one when there are no favorites found. A well-chosen image can contribute to a better user interface and convey a more positive message.

Assign me this, I'll be working on this one @Anandsg

@TheShiveshNetwork Go ahead

cAN I WORK ON THIS? @Anandsg

@Anandsg check out #230


download marked as successful even when incomplete

See failed https://wiki.bitplan.com/index.php/Wikidata_Import_2024-10-24
When downloading the latest dump:
[latest-all.ttl.bz2](https://dumps.wikimedia.org/wikidatawiki/entities/latest-all.ttl.bz2)                                 23-Oct-2024 15:41<PHONE_NUMBER>21

The qlever script reports:
 97  482M   97  472M    0     0  4680k      0  0:01:45  0:01:43  0:00:02 4743k
 98  482M   98  476M    0     0  4680k      0  0:01:45  0:01:44  0:00:01 4691k
 99  482M   99  481M    0     0  4675k      0  0:01:45  0:01:45 --:--:-- 4588k
100  482M  100  482M    0     0  4675k      0  0:01:45  0:01:45 --:--:-- 4537k

Download successful, total file size: 58,697,938,866 bytes

end continues the work as if nothing was wrong we get
2024-10-24 21:43:05.296 - INFO: Triples sorted: 10,242,062,336 [average speed 3.5 M/s, last batch 5.8 M/s, fastest 12.0 M/s, slowest 0.0 M/s]
...
QLever indexing process completed at Thu Oct 24 09:43:15 PM CEST 2024

Showing too few triple
The server is started with the incomplete import effectively trying to overrde our working copy which is only prevented by
QLever server already running on port 7001

@WolfgangFahl Does this issue still persist? There have been multiple fixes regarding this over the last month. In particular, there was a typo in the GET_DATA_CMD in the Qleverfile for Wikidata, which was fixed by d4902b9f8cccaa1f4012656848e3f0b131746538 .

https://wiki.bitplan.com/index.php/Wikidata_Import_2024-11-16 also failed.

@WolfgangFahl It says qlever 0.5.3. That is the version from June 29. The latest version is 0.5.12.

@hannahbast thanks for the hint - the 0.5.3 import seems to be o.k. i still upgraded


Spotify - Access and Refresh Tokens

Hi,
Great library. Is it possible to retrieve the Spotify Access and Refresh Tokens at the point of the user logging in? I'd like to be able to store them for later use in Spotify API requests.
Identity LoginInfo doesn't seem to contain any of that information so I'd like to be able to retrieve it.

I've created a PR for this. https://github.com/TerribleDev/OwinOAuthProviders/pull/251

You should be able to use this trick to get access to those tokens. We don't need to change the code at all.

OK - thanks for the info. I'll give that a try before the PR https://github.com/TerribleDev/OwinOAuthProviders/pull/251 continues

OK - this does work. The only extra info missing (which isn't 100% essential) is the scope and tokenType returned from spotify.
tokenType will always be Bearer and scope should be whatever is sent in at the beginning.

c# has closures, so you should be able to read the scope from the Options object
            var opt = new TwitchAuthenticationOptions()
            {
                ClientId = "",
                ClientSecret = "",
                Provider = new TwitchAuthenticationProvider()
                {

                    OnAuthenticated = async z =>
                    {
                        opt.Scope // get the scope
                        z.Identity.AddClaim(new Claim("Picture", z.User.GetValue("logo").ToString()));
                    }

                }
            };

Oh I think I see what your asking for. You are looking to get back the scopes from Spotify

If we get the scopes back in the response you could add it to the authentication context

Side note the User JObject should be everything we're given so it should also just be in there. I think this would get you the scopes if the json we get back has a scopes in a property called scopes
            var opt = new TwitchAuthenticationOptions()
            {
                ClientId = "",
                ClientSecret = "",
                Provider = new TwitchAuthenticationProvider()
                {

                    OnAuthenticated = async z =>
                    {
                        JToken result;
                        z.User.TryGetValue("scopes", out result); // get the scope
                        var scopes = result.ToObject<List<string>>();
                        z.Identity.AddClaim(new Claim("Picture", z.User.GetValue("logo").ToString()));
                    }

                }
            };

@TerribleDev Great, that's perfect thanks. I will find out the exact property name and try that out.


[jvm-packages] XGBoost Spark integration refactor

Combine a bunch of PRs into one, to merge dev branch to master.

Codecov Report

Merging #3387 into master will decrease coverage by 0.5%.
The diff coverage is 63.22%.

@@             Coverage Diff              @@
##             master    #3387      +/-   ##
============================================
- Coverage     44.99%   44.49%   -0.51%
+ Complexity      228      188      -40
============================================
  Files           166      163       -3
  Lines         12787    12769      -18
  Branches        466      443      -23
============================================
- Hits           5754     5681      -73
- Misses         6841     6887      +46
- Partials        192      201       +9

Impacted Files
Coverage Δ
Complexity Δ

...ost4j/scala/example/spark/SparkWithDataFrame.scala
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...c/main/scala/ml/dmlc/xgboost4j/scala/Booster.scala
35.71% <0%> (-1.33%)
8 <0> (ø)

...t4j/scala/example/spark/SparkModelTuningTool.scala
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...dmlc/xgboost4j/scala/spark/CheckpointManager.scala
72.91% <100%> (-4.17%)
13 <0> (ø)

...c/xgboost4j/scala/spark/params/BoosterParams.scala
59.3% <51.78%> (-6.04%)
0 <0> (ø)

.../dmlc/xgboost4j/scala/spark/XGBoostRegressor.scala
61.72% <61.72%> (ø)
16 <16> (?)

...dmlc/xgboost4j/scala/spark/XGBoostClassifier.scala
62.5% <62.5%> (ø)
18 <18> (?)

...c/xgboost4j/scala/spark/params/GeneralParams.scala
71.64% <68.96%> (-20.96%)
0 <0> (ø)

...oost4j/scala/spark/params/LearningTaskParams.scala
80% <76.47%> (-13.11%)
0 <0> (ø)

.../scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
73.59% <88.88%> (-1.72%)
0 <0> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e3edf...cba447e. Read the comment docs.

There are several PRs merged to master before this one, would you check if this PR contains those fixes

@CodingCat  Yes, I have rebased master.

@yanboliang sure, thanks, looks like some newly added test were failed....@RAMitchell would you mind sharing some insights on this?


NameError not getting into bugsnag

Hi, We had a problem in our app, that one request was returning a 500 to the client. After checking the logs, i found the following:
INFO -- : ** [Bugsnag] Notifying https://notify.bugsnag.com of NameError from api_key XXXX
ActionView::Template::Error (wrong constant name professional):

However, for some reason, the error never got to bugsnag. While some, other errors are getting there. Not sure what the problem is, and how to debug it.

Hi arthurnn, sorry for taking so long to respond.  Are you still seeing this issue occur?

I dunno TBH.
We fixed the issue in our app, which was legit. However, the entire problem here is that bugsnag was not catching that error. I am not sure why.

Thanks, @arthurnn. We recently finished a fairly large overhaul which tidied up a lot of the internals as well as adding a number of small fixes. Let us know if it happens again, but in the meantime I'll mark this as resolved.


Rework TestStyledTextOutputFactory test fixture

This makes it easier to assert separately on the
output, category and log level.
Previously, this was all mixed into/encoded in the output itself.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

The merge queue build has failed. Click here to see all failures.

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan