Request: can docker ps support --format{{.Name}} and/or {{.Names}}

I'm using this in a script to try and shutdown and remove containers based on the names I assigned - but I can't easily exclude some containers, and I can't easily get the Name of each container,so I end up doing this (I have set my container names to match my image names, as for now I have one of each)
#bin/sh
for DOCKER_PROCESS in $(docker ps -q --format "{{.Image}}" --filter "name=-")
do
		if [ "$DOCKER_PROCESS" = "redis" -o "$DOCKER_PROCESS" = "cip-data-redis" ];
		then
				echo "Not stopping $DOCKER_PROCESS"
		else
				echo "...Stopping docker process $DOCKER_PROCESS"
				docker stop $DOCKER_PROCESS &
		fi
done
wait

for DOCKER_CONTAINER in $(docker ps -a -q --format "{{.Image}}" --filter "name=-")
do
		if [ "$DOCKER_CONTAINER" = "redis" -o "$DOCKER_CONTAINER" = "cip-data-redis" -o "$DOCKER_CONTAINER" = "node-js-base" ];
		then
				echo "Skipping delete of $DOCKER_CONTAINER"
		else
				echo "...Removing docker container $DOCKER_CONTAINER"
				docker rm $DOCKER_CONTAINER &
		fi
done
wait

..I would prefer to be able to do something like this;
for DOCKER_CONTAINER in $(docker ps -a -q --format "{{.Name}}" --filter "name=-")
--snip--

or this
for DOCKER_THING in $(docker ps -a -q --format "{{.Name}}" --filter-excludes "name=redis")
--snip--

Any thoughts?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO


[Feature Request] Update packs.mjs for upgrade all items with the new item weight object

Having several modules with many items I would find it very useful to have for the utilities file “pack.mjs” the setting of the new item weight structure set with 3.2.X .
Basically the complementary of the piece of code :
if ( !("weight" in source) || (foundry.utils.getType(source.weight) === "Object") ) return;
    source.weight = {
      value: Number.isNumeric(source.weight) ? Number(source.weight) : 0,
      units: game.settings.get("dnd5e", "metricWeightUnits") ? "kg" : "lb"
    };

Something like this maybe is a valid solution ?
if ( !data.system?.weight?.units  ) {
    data.system.weight = {
      value: Number.isNumeric(data.system.weight) ?


operation ordering is not working

version 2.6.1
I wanna operations sorted by http methods and paths, so I configured it  by using springfox.documentation.spring.web.plugins.Docket.operationOrdering(Ordering<Operation> operationOrdering), but it didn't work.
I found out that List<Operation> springfox.documentation.spring.web.readers.operation.ApiOperationReader.read(RequestMappingContext outerContext) didn't add all operations at a time, so this maybe the bug.
Please check it.

The operation ordering may not have the desired effect in swagger 2.0. However I've put in a fix to make the path lexically sorted based on comparable path strings. Thanks for reporting this issue!


Improve GetLockID()

Thanks for this lock implementation. Currently GetLockID() is unable to build since GetLockID() needs to be completed by user. This forces user to fork the package and add the implementation.
A way to solve this can be: Having a default GetLockID() implementation returning an uuid (or return empty string). User can overwrite the function if necessary.
If the proposal makes sense I can submit a pull-request.

@roylou Thanks for helping out. Would love a pull request. It makes sense to add some kind of identifying information.


ChangeContentDepositorService needs to reset file set permissions

Sufia::ChangeContentDepositorService does not reset a file set's permissions when a transfer is made. As a result, a file set within a work will still retain the original depositor's access rights.

Add file_set.permissions = [] if reset to https://github.com/samvera/sufia/blob/master/app/services/sufia/change_content_depositor_service.rb


[PE-D][Tester C] Wrongly accepts invalid email format

Labels: type.FunctionalityBug severity.High
original: gavinsoh/ped#3

The email format is an acceptable format based on our email constraint.


Use start-gpg-agent in .bashrc

Building on issue #44 , use start-gpg-agent in the user's $HOME/.bashrc startup file. This depends on the correct mosrs-setup module having itself been loaded beforehand. A suggested way of doing this:

Before editing ~/.bashrc, conceptually:

$ MOSRS_SETUP_MODULE=$(module info-loaded mosrs-setup)
$ MOSRS_SETUP_PATH=$(module path $MOSRS_SETUP_MODULE)
$ MOSRS_SETUP_USE=${MOSRS_SETUP_PATH/\/$MOSRS_SETUP_MODULE/}

Put the following into ~/.bashrc in the appropriate place:

# mosrs-setup gpg_agent_script: DO NOT EDIT BETWEEN HERE AND END
function load_mosrs {
  module use $MOSRS_SETUP_USE
  module load $MOSRS_SETUP_MODULE
}
function start_mosrs_gpg {
  mkdir -p $HOME/.gnupg
  load_mosrs
  start-gpg-agent
}
if in_interactive_shell; then
    if in_login_shell; then
        # start the GPG agent
        start_mosrs_gpg
    fi
fi
# mosrs-setup gpg_agent_script: END

where the MOSRS_SETUP_* shell variables are replaced by Python strings.
Issues with doing things this way:

Step 1. depends on mosrs-setup being run from a module, and will fail if mosrs-setup is run directly.

$ module unload mosrs-setup
$ MOSRS_SETUP_MODULE=$(module info-loaded mosrs-setup)
$ echo $MOSRS_SETUP_MODULE

The version of mosrs-setup used in ~/.bashrc is fixed at the version used to edit the ~/.bashrc file itself.

Close. This change is not needed: mosrs-setup no longer updates the .bashrc file.


Website: Fix genesis member profile text for Safari

Small change to fix, will follow up with another PR to align icon and text on Safari
Has checked that this doesn't break on Chrome

it was 11.9 because on the figma, it was 191px for width. 11.9375 - wasnt sure how much to round in this case

Do you remember why this was originally made 11.9? Are we gonna have to fix it again when we add more members?

it was 11.9 because on the figma, it was 191px for width. 11.9375 - wasnt sure how much to round in this case


ARIA 1 Example 4: Tooltip not working as expected

I would expect to have the tooltip appear on hover, but it is only appearing on the screen on focus then disappearing when I hover over it, and it doesn't come back.
This isn't a real implementation of tooltip, and I think it should behave just like one. It seems to me there are a couple of things you're blending together here. One is a visible tooltip via keyboard. The other is a tooltip announced by JAWS. I would suggest you scrap the the first one (keyboard triggered tooltip) as being outside the scope of this example. You can notate that, and give this technique as an example later, but it's muddying the water.

Confirmed same behaviour with FF and Chrome


SVG uploads not displaying thumbnail preview in CMS

We are currently using the Payload CMS and have the 'plugin-cloud-storage' plugin installed, which connects to our S3 bucket. However, we've noticed that when we upload an SVG file, the thumbnail preview is not displayed in the CMS.
Upon further investigation, we found that the URL for the SVG file is not coming from the CDN, but instead from Payload itself. This results in a 404. Wich is wired because the JPG and PNG files have the correct url.
We got 'disablePayloadAccessControl' set to true to serve images directly from the CDN.
We would appreciate your assistance in resolving this issue as soon as possible, as it is affecting our ability to efficiently manage and preview our SVG files in the CMS.

The preview also doesn't work when you upload an image that is smaller than the smallest image sizing. For example when I have a logo called example.png that is 250x250 and my smallest image sizing is 300x300. When I click on the upload link it correctly sends me to the url https://s3.url/media/logo.png but the preview, left of the link, shows the image not being loaded. When I investigate the url it is a relative url for example:  /media/logo.png. And because the disablePayloadAccessControl for this upload collection is set to true this relative url doesn't resolve.

Hey @matthijs166 — I am afraid I can't reproduce this. I just tested with a variety of SVGs and they all work properly.  Can you create a minimally reproducible example? What version of Payload are you on?
@RickGeersing I also can't reproduce your issue either, but that is a separate issue so it should be opened separately. Let's keep this issue thread focused on the original SVG issue. One question for you though - you should check to see if you have an endpoint defined in your S3 adapter config. If you don't, I could see how the URL might be relative. We use the S3 endpoint to generate URLs. If it's not that, and your issue persists, please open up another issue.
Thank you!!

This has been reported before and it ends up being improper mime-type on the SVG file. If files other than SVG are able to preview then it likely isn't this package. You could test different files and different storage options to isolate where the problem is.
If a file doesn't work just with the built-in local storage without this plugin, then we know the issue is that file.
I'm going to close this one. Feel free to re-open if you have a more information or new steps to try.


[Search]MacOS11_NET60_PackageRef_Debug failing in nightly runs

Search nightly test runs are failing with:

##[error]We stopped hearing from agent Azure Pipelines 28. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610
Pool: Azure Pipelines
Image: macos-11
Agent: Azure Pipelines 28
Started: Today at 12:34 AM
Duration: 2h 49m 7s

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2601632&view=results

@jsquire for notification.

//cc: @pallavit

It was one time network connection failure. I just reran the pipeline for MacOS11_NET60_PackageRef_Debug and it resolved the issue.


Moonlight - Failed to initialize video capture

I've installed the beta version, added my specific display res of 3120x1440, 120Hz as I am streaming to my phone. I've got the virtual display showing in display list and set to the resolution/RR that I want, HDR off. I've set Sunshine to \.\DISPLAY4 and applied the change. When I try to connect via Moonlight it fails. If i leave it to default it selects the primary monitor plugged into my 3070. Not sure if my CPU not having an iGPU is the reason for this, or if I can set the VDD to run off the GPU. Also ot sure where the proper place to submit my query is so apologies if this is not it.

The driver will automatically pick the gpu with highest vram in the beta driver, you can change this in the xml by adding your gpu friendly name

I believe there is an issue when streaming if its not your main display, You could try setting the virtual display to be the main display

I had guessed since i have 3 monitors that \.\DISPLAY4 would be what to use. After reviewing and checking the dxgi-info.exe i can see i was using the wrong one. Sorry and thank you for the input!

No problemo! Is it working then ?

Aye sir! Absolutely perfectly and beautifully. 🤜🤛


Warn users that problem solution return types should not be nullable

This includes nullable reference types and nullable structs. A problem solution return type should be a non-null value, when finalized. At the time of development, the user may simply return some placeholder value, including null in the case of a reference type. As far as the framework is concerned, a problem's return type is well-defined and non-null.
Spec

[ ] AoCS0012 - Error - The return type of a problem part solution cannot be nullable

Code fix: always
A more detailed description must be provided explaining the rationale behind this.

This is solvable by adding the notnull constraints on the Problem types. This analyzer is unnecessary. The built-in compiler warning should be sufficient.


QueryExector 414 URI Too Long

The request to get the work items is returning a 414. Here is the line of code I'm referring to: in the QueryOpenBugs method
// get work items for the ids found in the query
return await httpClient.GetWorkItemsAsync(ids, fields, result.AsOf).ConfigureAwait(false);
Not sure if you want to update the code to use the GetWorkItemsBatchAsync method instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e978322f-15ae-3a89-ae89-497cdfa5070a
Version Independent ID: f8654902-e266-c12b-8e25-a2fa7a2ac626
Content: Get work items programmatically from Azure DevOps Services - Azure DevOps
Content Source: docs/integrate/quickstarts/work-item-quickstart.md
Product: devops
Technology: devops-ecosystem
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @zesameri, Thanks so much for your feedback. I've updated the article, based on your recommendation.


org.alfresco.error.AlfrescoRuntimeException: 09050000 GetModelsDiff return status is 404 while running the Alfresco

I have imported mms project as a  maven project from git hub and followed the instructions given in its README file to run and test Alfresco. While testing the application I have entered http://localhost:8080/share/ for which I am successfully getting the login page for Alfresco. But when I am giving the default username and password (i.e. admin and admin) I am not able to login to the application. Getting an error "Your authentication details have not been recognized or Alfresco may not be available at this time." When I checked the console and the Alfresco log file, I found org.springframework.beans.factory.BeanCreationException followed by org.alfresco.error.AlfrescoRuntimeException: 09050000 GetModelsDiff return status is 404.
Installed the following:
Apache Tomcat 7.0 version
PostgreSQL 9.4
Also installed the dependencies needed for the project(Elastic Search6.4 and ActiveMQ5.0).
Working on Java8.
Can anyone please help me out in solving the problem?
Thanks in advance.

log file?

Hi below is the Alfresco log file and also I am attaching the exceptions that I found on my eclipse console while running the application.
Alfresco Log file:
Alfresco.log
Exceptions observed in my console:
console.log
Thanks

Looks like the log says you're missing mms.properties in the mms-ent directory. Simply copy mms.properties.example to mms.properties. The default values should be enough to run locally. BTW, Elasticsearch should be version 5.6, since we do not support or test on 6.4


DevTools: type-based property editors

Adding per-type property editors to DevTools. This makes it easier to tweak values without having to write "True/False" for bool  (for example)
Currently supported types/editors:

bool uses CheckBox
IBrush uses custom BrushEditor that draws a preview of the brush and allows to tweak the color for ISolidColorBrush instances
IImage shows a preview of the image and allows to see an expanded version on click
Enum shows a ComboBox
Integer types use NumericUpDown
Everything else uses TextBox

Suggestions are welcome for additional property editors.

Open issues:

CheckBox not updating checkmark when clicking. Need to investigate further.
NumericUpDown does not support NaN/Infinity, so it doesn't work with floats/doubles
We could  think about adding some attributes that allow to customize how properties are presented in DevTools. For instance, we could have an attribute to control whether a float property shows a slider instead.
Would be nice to allow setting Cursor but AFAICT there's no way to get the StandardCursorType a Cursor object was created from.

You can test this PR using the following package version. 11.0.999-cibuild0030134-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0030138-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Looks great :)
But it feels like image should be visible in the popup or on click only, and show some standard icon in the grid instead.

You can test this PR using the following package version. 11.0.999-cibuild0030153-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

But it feels like image should be visible in the popup or on click only, and show some standard icon in the grid instead.

Agree 👍💯

@pr8x I think I used vscode icons before which are MIT. Fluent icons are also MIT https://github.com/microsoft/fluentui-system-icons.

This is really neat!
My only suggestion, can you add back the color hex text - that's more useful to me than the color preview. A converter and ColorHelper.GetRelativeLuminance from the background color to determine white/black text should deal with contrast concerns.

Color preview is more meaningful IMO than the hex color but I understand than invertían circumstances it's needed. We solved that in the past displaying both. A thin panel (8px or so) with the color preview and the hex text. Clicking on the thin panel displays the color picker and you can also manually edit the hex.

@amwx you can see the hex code in the third tab of the color dialog. But I guess I can add an option to show hex overlay.

@pr8x I think the color preview could look like this?
🔴 #FFFF0000

@pr8x I think the color preview could look like this?
🔴 #FFFF0000

Yeah makes sense. Chrome does it this way...

@maxkatz6

@maxkatz6 On a different note: Seems that Fluent Light theme has a white foreground color for ComboBox etc, which makes it impossible to read the items. Also, as I said above, the checkmark of the CheckBox has the same color as the row selection background (blue). So when you have a row selected and the checkbox checked it looks like it's not checked.

You can test this PR using the following package version. 11.0.999-cibuild0030211-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Added the same preview for Geometry:

Opinions?

You can test this PR using the following package version. 11.0.999-cibuild0030222-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0030225-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

maybe you could keep aspect ratio for image preview

@Sorien I restricted preview popup to 300x300px but the Image.Stretch defaults to Uniform so aspect ratio is maintained.

Updated the color editor:

@danipen @timunie

You can test this PR using the following package version. 11.0.999-cibuild0030295-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Also added validation support for TextBox that discards invalid input. Properties are only updated when pressing Enter or the TextBox loses focus. This make it possible to type a multi-digit number without causing the property to update on every digit.

You can test this PR using the following package version. 11.0.999-cibuild0030301-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@Sorien I restricted preview popup to 300x300px but the Image.Stretch defaults to Uniform so aspect ratio is maintained.

@pr8x sorry, I thought to use an image aspect ratio for the preview window to remove these empty spaces above and below image

Also added validation support for TextBox that discards invalid input. Properties are only updated when pressing Enter or the TextBox loses focus. This make it possible to type a multi-digit number without causing the property to update on every digit.

See this

Updated the color editor:
Much better. Looks good.

image

Also added validation support for TextBox that discards invalid input. Properties are only updated when pressing Enter or the TextBox loses focus. This make it possible to type a multi-digit number without causing the property to update on every digit.

Can we please have a solid background on the tooltip of the validation? The message is hard to read otherwise imo. Thx.

@timunie This is one of the few things broke in the SimpleTheme:

Flyout backgrounds are transparent
Checkbox checkmark has the same color as DataGrid row selection
Light variant: ComboBox item foreground is white

Maybe someone who is more involved in themes could take a look at these?
CC: @maxkatz6

PR should be ready now. Would appreciate it if someone could help testing it :)

I noticed it show validation errors on MaxHeight/Width, when it shouldn't really.

I understand why these properties are disabled, but it makes readability of text worse in here. Since even readonly properties should have readable values.

If there is no solid color brush value set on the property, I can't edit it from the devtools. Wouldn't it make sense to allow to set solid background from the dev tools to the any IBrush property?

Feels like for Thickness it would be nice to have a special control that combines 4 numeric-up-down controls together for each property. With disabled arrows, just text input validation and mouse wheel support provided by the NumericUpDown.

NumericUpDown does not support NaN/Infinity, so it doesn't work with floats/doubles

NumericUpDown can bind to a null, which we can mapped to NaN or Infinity.
Height/Width can be NaN (unset) but never Infinity.
MaxWidth/MaxHeight can be Infinity but never NaN.
So, some of these properties can be supported with NumericUpDown, but probably as hardcoded special cases.
Or, using attributes, as you mentioned. WPF/WinForms have some of these attributes defined and set on their controls. But it's probably a task for another day.

@maxkatz6

I noticed it show validation errors on MaxHeight/Width, when it shouldn't really.

Ah I see, I have to use CultureInfo.InvariantCulture explicitely. That will return "Infinity" by default (or whatever NumberFormatInfo.PositiveInfinity is set to)

I understand why these properties are disabled, but it makes readability of text worse in here. Since even readonly properties should have readable values.

Any suggestion? I currently just make the editor disabled. But should probably make set ReadOnly for TextBox.

If there is no solid color brush value set on the property, I can't edit it from the devtools. Wouldn't it make sense to allow to set solid background from the dev tools to the any IBrush property?

Yeah I was also thinking about that. Any suggestion how we can make it clear that a solid color brush is created on click?

Feels like for Thickness it would be nice to have a special control that combines 4 numeric-up-down controls together for each property. With disabled arrows, just text input validation and mouse wheel support provided by the NumericUpDown.

What about the 2 or 2,2 shorthand syntax to set all or Left/Right & Top/Bottom?

Any suggestion? I currently just make the editor disabled. But should probably set ReadOnly for TextBox.

TextBlock or readonly textbox sounds good.

Yeah I was also thinking about that. Any suggestion how we can make it clear that a solid color brush is created on click?

Not sure if I understand a problem.
We might need a context flyout with "Reset value" though.

What about the 2 or 2,2 shorthand syntax to set all or Left/Right & Top/Bottom?

I don't think we need shorthand syntax there, for simplicity of UX.

Thank you @pr8x for your PR.
This PR close my issue #4665.
I would like to suggest you a change to increase maintainability. Instead of creating the editors via code you could use the data template like this:
@@ -0,0 +1,55 @@
using Avalonia.Controls;
using Avalonia.Controls.Templates;
using Avalonia.Markup.Xaml.Templates;
using System.Linq;

namespace Avalonia.Diagnostics
{
    class DataTemplateSelector : DataTemplates, IDataTemplate
    {
        public Control Build(object? param)
        {
            if (param is ViewModels.PropertyViewModel vm)
            {
                param = vm.Value;
                var propertyType = vm.PropertyType;
                var m = this
                    .FirstOrDefault(t =>
                        {
                            var match = false;

                            foreach (var item in this)
                            {
                                if (item is DataTemplate dt)
                                {
                                    if (dt.DataType == propertyType || dt.DataType.IsAssignableFrom(propertyType))
                                    {
                                        return true;
                                    }
                                }
                                else
                                {
                                    if (item.Match(param))
                                    {
                                        return true;
                                    }
                                }
                            }

                            return match;
                        });

                return m?.Build(param) ??
                        new TextBlock
                        {
                            Text =  $"{vm.Name} = {param}" ,
                        };
            }
            return new TextBlock() { Text = "Error"};
        }

        public bool Match(object? data) => true;
    }
}

and using:
...
  <UserControl.Resources>
    <conv:BoolToOpacityConverter x:Key="BoolToOpacity" Opacity="0.6"/>
    <d:DataTemplateSelector x:Key="ValueTemplateSelector">
      <DataTemplate DataType="{x:Type sys:Boolean}">
        <CheckBox IsChecked="{Binding Value,Mode=TwoWay}"/>
      </DataTemplate>
      <DataTemplate DataType="{x:Type sys:Int32}">
        <NumericUpDown Value="{Binding Value}"
                       Increment="1"
                       ParsingNumberStyle="Integer"
                       HorizontalContentAlignment="Right"
                       />
      </DataTemplate>
      <DataTemplate DataType="{x:Type sys:Double}">
        <NumericUpDown Value="{Binding Value}"
                       Increment=".01"
                       ParsingNumberStyle="Float"
                       HorizontalContentAlignment="Right"
                       />
      </DataTemplate>
      <DataTemplate DataType="{x:Type sys:Decimal}">
        <NumericUpDown Value="{Binding Value}"
                       Increment=".05"
                       ParsingNumberStyle="Currency"
                       HorizontalContentAlignment="Right"
                       />
      </DataTemplate>

      <DataTemplate DataType="{x:Type IBrush}">
          <!-- Brush edior -->
      </DataTemplate>

      <DataTemplate DataType="{x:Type sys:String}">
        <TextBox Text="{Binding Value}"/>
      </DataTemplate>
    </d:DataTemplateSelector>
  </UserControl.Resources>
...

        <DataGrid.Columns>
           ...
          <DataGridTemplateColumn Header="Value" CellTemplate="{StaticResource ValueTemplateSelector}" />
           ...
        </DataGrid.Columns

@workgroupengineering I disagree that it would help maintaining this. I currently have quite a lot of special handling (like excluding float and double from NumericUpDown or having special code to create a color picker or image/geometry preview). Trying to do all this from XAML has no advantage and will just create more boilerplate code (need to create custom controls for everything and also write the same code over and over since you cannot match multiple types at once)

@workgroupengineering I disagree that it would help maintaining this. I currently have quite a lot of special handling (like excluding float and double from NumericUpDown or having special code to create a color picker or image/geometry preview). Trying to do all this from XAML has no advantage and will just create more boilerplate code (need to create custom controls for everything and also write the same code over and over since you cannot match multiple types at once)

In general, methods that are too long decrease readability and extend the probability of making errors.
As for Xaml or Code, you're right, it's subjective.
Take an example the code you wrote:
Take an example, the code you wrote in xaml could be written like this:
https://github.com/AvaloniaUI/Avalonia/blob/b4cfd86afd7c4b773c047305f23d8dcc449ca30d/src/Avalonia.Diagnostics/Diagnostics/Views/PropertyValueEditorView.cs#L143-L209
<DataTemplate DataType="{x:Type IImage}">
   <StackPanel Orientation="Horizontal"
                      Background="Transparent"
                      Spacing="2">
           <Path Data="{StaticResource ImageIcon}" Fill="Gray" Width="12"  Height="12" Stretch="Uniform" VerticalAlignment="Center"/>
           <TextBlock VerticalAlignment="Center">
               <TextBlock.Text>
                     <MultiBinding StringFormat="{}{0} x {1}">
                          <Binding Path="Value.Size.Width"/>
                          <Binding Path="Value.Size.Height"/>
                     </MultiBinding>
               </TextBlock.Text>
           </TextBlock>
           <ToolTip.Tip>
               <Image Source="{Binding Value}" Stretch="Uniform" Width="300" Height="300"/>
           </TootTip.Tip>
   </StackPanel>
</DataTemplate>

<DataTemplate DataType="{x:Type Geometry}">
   <StackPanel Orientation="Horizontal"
                      Background="Transparent"
                      Spacing="2">
           <Path Data="{StaticResource GeometryIcon}" Fill="Gray" Width="12"  Height="12" Stretch="Uniform" VerticalAlignment="Center"/>
           <TextBlock VerticalAlignment="Center">
               <TextBlock.Text>
                     <MultiBinding StringFormat="{}{0} x {1}">
                          <Binding Path="Value.Bounds.Width"/>
                          <Binding Path="Value.Bounds.Height"/>
                     </MultiBinding>
               </TextBlock.Text>
           </TextBlock>
           <ToolTip.Tip>
               <Border Width="300" Height="300">
                     <Path Data="{Binding Value}" Fill="White" Stretch="Uniform"  VerticalAlignment="Center" HorizontalAlignment="Center"/>
               </Border>
           </TootTip.Tip>
   </StackPanel>
</DataTemplate>

@workgroupengineering This might be something for the future. Currently don't feel like rewriting this whole PR 😃

@workgroupengineering This might be something for the future. Currently don't feel like rewriting this whole PR 😃

Ok, I'm waiting for this pr to be merged to start working on #10296

You can test this PR using the following package version. 11.0.999-cibuild0031079-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@pr8x looks good to me. Do you plan to do anything else (thickness, brush and numericupdown trickery) in this PR or should it be done later in another one?

@maxkatz6 I was planning to do Thickness editor but ran out of time this week. Maybe we can already merge this and make a followup for it?

@pr8x not sure if this is intentional or a bug ...
I cannot change the Background brush for a panel that has no brush defined. The "null" value cannot be changed:


[WIP] Shadows proof of concept

Motivation and Context
This is a proof of concept that was quickly hacked together, then basically scrapped due to its low priority.
Since tomorrow is my last day :( putting it up as a draft so it doesn't get lost if anyone ever wants to return this idea.
Uses cascaded shadow mapping technique.
See:

https://doc.magnum.graphics/magnum/examples-shadows.html
https://docs.microsoft.com/en-us/windows/win32/dxtecharts/cascaded-shadow-maps
http://ogldev.atspace.co.uk/www/tutorial49/tutorial49.html

Issues

There is a disconnect between our lights (point lights) and the lights the shadow light uses. This PR just uses a hacked together single hardcoded light direction to determine shadows for all lights.
To fix this, we would need to either:
Support point light shadows: https://learnopengl.com/Advanced-Lighting/Shadows/Point-Shadows
Add directional light support to light setups

How Has This Been Tested
Look at the shadows!!!

To run this example, need to pass --scene-requires-lighting to the viewer, since it doesn't really make sense to have shadows on a flat shaded mesh.
Ie: ./build/viewer --enable-physics --scene-requires-lighting -- ~/habitat-data/scene_datasets/habitat-test-scenes/apartment_1/apartment_1.glb
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Closing this stale PR.


Disocrd error

The bot cannot be used by members like they can use other commands except start

Thank you for submitting an issue. I recently released a new major version with some changes to the default permissions. Please see announcement https://github.com/sleeyax/aternos-discord-bot/discussions/25.


Broken File Permissions during Usage

Perhaps a misconfiguration on my end, but this plugin has the possiblity of breaking file permissions.
For example, under a normal apache setup (files/folders owned like webdr:apache)
/var/www/html
|->test
|->test.php
Editing test.php, would cause the saved changes to be saved in a brand new file owned by webdr and owned by group webdr, completely breaking file permissions structure and normal operating procedure for VIM.
If it was a misconfiguration, More instructions are needed to ensure that this doesn't happen. Otherwise, this plugin is completely and totally unusable in normal environments.

Just confirmed the bug.
@ragingdave Thanks for reporting.
I'm sending out a pull request to @waltzofpearls

Solution I provided caused other issue, will look into this a bit more


App Mesh workshop update dj-app

Current workshop documentation is stale and needs to be updated. It has some unsupported configuration that can lead to problems at runtime and hard to diagnose, see https://github.com/aws/aws-app-mesh-examples/issues/230.
Workshop needs to be updated as per https://github.com/aws/aws-app-mesh-examples/blob/master/walkthroughs/eks/base.md, i.e. using helm.

@geremyCohen can you please guide us here. Thanks

@kiranmeduri can you provide specifics? we ran this workshop yesterday with success.

Workshop may succeed, but any subsequent actions on this appmesh installation may fail e.g. gRPC, TLS, retries. The reason being the CRDs and injector configurations are not up-to date and there is no easy way to update.
We are still trying to debug if there is a bug in this specific workshop exercise. May be you can help the customer https://github.com/aws/aws-app-mesh-examples/issues/230

Specifically the image used by injector is old (v0.1.0) and does not have latest bug-fixes. Latest version if 0.3.0.


add readme

Description of your changes
A rough readme to get something up and running. There are still things that are unclear but it'd give people an idea about what it does and how they can get started if they feel adventurous.
We'll need to do another pass in the coming weeks.
Fixes https://github.com/crossplane-contrib/terrajet/issues/32
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
N/A

@luebken I've removed all the instructions since they are still changing fast, left only the description parts.

Added https://github.com/crossplane-contrib/terrajet/issues/75 for the instructions.


DefaultObjectPool is not threadsafe

From @fofewyoung on September 3, 2018 10:18
i found DefaultObjectPool is not thread safe in 2.1,
the test result is:
2.0.0   ----  pass
2.1.0-preview1-final  -- pass
2.1.0-preview2-final  -- failed
2.1.0                          -- failed
2.2.0-preview1-35029  --failed
my test code is below:
    class AClass
    {
        public int i = 0;

        public void Reset()
        {
            i = 0;
        }
    }

    static DefaultObjectPool<AClass> PoolInstance;
    void TestDOP() // call this function in Main
    {
        PoolInstance = new DefaultObjectPool<AClass>(new DefaultPooledObjectPolicy<AClass>(), 10);
        for (int i = 0; i < 8; i++)
        {
            var t = new Thread(OnTest1);
            t.Start();
        }
    }
    void OnTest1()
    {
        while (true)
        {
            var obj = PoolInstance.Get();
            if (obj.i != 0)
                Console.WriteLine("bug");
            obj.i = 123;

            var obj2 = PoolInstance.Get();
            if (obj2.i != 0)
                Console.WriteLine("bug");
            obj2.i = 321;

            obj.Reset();
            PoolInstance.Return(obj);
            obj2.Reset();
            PoolInstance.Return(obj2);
        }
    }

Copied from original issue: aspnet/Common#394

Thanks for contacting us, @fofewyoung.
@rynowak can you please look into this? Thanks!

@gfoidl - this is the original report

PR for release/2.2 https://github.com/aspnet/Common/pull/398
PR for release/2.1 https://github.com/aspnet/Common/pull/399


Go-chart pie chart PDF mis-rendering

When adjusting the go-charts pie chart example [1] (see output.png) to use the excellent canvas PDF rendering [2], the output is misrendered (see output.pdf).
[1] https://github.com/wcharczuk/go-chart/blob/master/examples/pie_chart/main.go
-- [2]
package main

import (
	"os"

	"github.com/tdewolff/canvas/renderers"
	"github.com/wcharczuk/go-chart/v2"
)

func main() {
	pie := chart.PieChart{
		Width:  512,
		Height: 512,
		Values: []chart.Value{
			{Value: 5, Label: "Blue"},
			{Value: 5, Label: "Green"},
			{Value: 4, Label: "Gray"},
			{Value: 4, Label: "Orange"},
			{Value: 3, Label: "Deep Blue"},
			{Value: 3, Label: "??"},
			{Value: 1, Label: "!!"},
		},
	}

	f, _ := os.Create("output.pdf")
	defer f.Close()

	pie.Render(renderers.NewGoChart(renderers.PDF()), f)
}

output.pdf

Thanks for the bug report, I'll look into it!

I've added a fix, please let me know if you have any other problems

Superb fix! Tests out well with more complex pie charts.


Feature request: View images based on device's screen resoultion

It appers that images shows based on its size and not fit to screen. Large images looks like zoom in and cannot be zoom out because WebApps does not support pinch zoom gesture.

This may be site specific, one site I visit requires 3rd party JavaScript to resize the image correctly, otherwise it is zoomed in even on a desktop. Try unblocking 3rd party requests and see if that fixes the images.


Tower Blocks Game

Developer Checklist

[x] Followed guidelines mentioned in the readme file.
[x] Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
[x] Starred ⭐ the Repo (Optional)

Summary
Created a simple but fun tower block game inspired from Apple iTunes.  Made with Three.js. Also tried to make the game theme close to the Apple iTunes UI. And using Comfortaa Sans font.
Screenshot

Live Project Link
_https://codepen.io/SLIET/pen/bGOQpWP_

Yo sup! @thinkswell. Just mentioning to tell you that I've added the tower block mini project. Aaand... it works just finee.

Amazing projec @BrownGrey  :star2:


More Reselect addons to investigate

https://github.com/sgrishchenko/reselect-utils
https://github.com/heyimalex/reselect-map

I like the pattern that reselect-map uses, having a selector creator specialized to deal with a specific data type (createArraySelector, createObjectSelector, etc).


Dataset on Hugging Face hub

Hi thanks for contributing this dataset! I just wanted to let you know that it is now available on Hugging face hub in this repo, if you want to include the information in the readme, it can be loaded this way:
from datasets import load_dataset

ds = load_dataset("codeparrot/codecomplex", split="train")

Hi! Thank you very much for your interest in our dataset :) It's great that our dataset can be simply loaded from huggingface library already!


Update chat-completion template doc to include API Playground section

Following up on PR #1445 which added the API Playground section to the generated chat-completion.md file, the docs/api-inference/tasks/*.md files should not be edited directly as they are automatically generated.
this PR updates chat-completion.handlebars template to make those changes persistent by adding the "API Playground" section directly in the template.
Note: All changes in other generated docs are from running the generate scripts.
cc @gary149 for viz.

thx for fixing @hanouticelina!


Get formats and thumbnails and title in one call

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question
e.g:  youtube-dl.exe --get-title --list-thumbnails --list-formats URL
It seems if I combine these options, I get "No info from page"
This means I need to call 3 times and combine all output

There seems to be no way to output these info once. You need to get them from json output. (-j or --write-info-json)


Documentation out of date

Some methods described in the docs no longer work, such as Ipfs::Client::addresses.
Would you prefer I update the docs to match the code on the master branch, or fix the code to match the docs?

Hey Andrew :wave:
Documentation was out of date for some time on master :(
Actually, all the up-to-date version was on branch documentation that I just merged.
You can take a look.

Thanks!

I edited my post

👍

Feel free to close when ready

ok @andrew the doc has been uploaded correctly. It can be seen here


How to access the Slack channel?

Hi,
I'm very interested in this endeavour but I can't connect to ASFW's slack.
Do I need an invite?

Thanks

Ahah... Like always it's when you make the issue that you solve it.
For those unfamiliar with Slack like me, you need to go to https://slack.aswf.io/ not a channel sublink like I was trying. There it will ask for your email and send you an invite.


When test on got10k test, it raises error

The error is:
slice indices must be integers or None or have an __index__ method
I don't know where it comes from (no hint to locate)

You can set --threads 0 --num_gpus 1 --debug 0 when testing, so that hints will be printed.

It happens in line 57 of processing_utils.py.
File "tracking/../lib/train/data/processing_utils.py", line 57, in sample_target
    im_crop = im[y1 + y1_pad:y2 - y2_pad, x1 + x1_pad:x2 - x2_pad, :]
TypeError: slice indices must be integers or None or have an __index__ method

FIX:
add target_bb = list(map(int, target_bb)) in line 28 of processing_utils.py.


Mismatch for SHA256 checksum

On the page: https://www.mintlayer.org/en/download/
For Mac OS, Intel users
For the binary Wallet Address Generator
There is a mismatch between the SHA256 checksum provided and the actual SHA256 checksum obtained via shasum -a 256 on my end.
Node Deamon and Wallet CLI match the ones provided.

I appreciate your submission, we'll look into it (I'll pass it on). But please don't report website-related problems here on mintlayer-core repo. This isn't the right place. Try to communicate with our social channels or the website repo (if it's public). The engineers in this repo don't deal with these problems.


Add email filter for users api

Fixes #289

PS: you could add a validation that checks that the api only receives ids o emails.


Fix seg fault in micro_speech_test on ppc64le.

Building micro_speech_test with the same compiler options as on x86, leads to the warnings:
... /micro/testing/micro_test.h:95:51: warning: ISO C++ forbids converting a string constant to 'va_list {aka char*}'
... /micro/micro_error_reporter_test.cc:24:56: warning: ISO C++ forbids converting a string constant to 'va_list {aka char*}'
And running the test program leads to a seg fault, for what I understand the standard for c++11
doesn't allow for a constant string to be used with %s substitution.
Another fix was to add the "-lm" link option when compiling on ppc64le, this avoided compile errors like:
undefined reference to symbol 'cos@@GLIBC_2.17'
This fixes several failing unit testcases on ppc64le, and causes no regression
errors on x86.
Fixes #24148

@petewarden , Can you please review these changes?

Nagging Reviewer @petewarden: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @petewarden, @achowdhery: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 29 days with no activity and the awaiting review label has been applied.

@wdirons Can you please take a look at the failed test builds? Thanks!

I have no idea how to view the internal CI build failures. I can try again with the latest code on x86 ubuntu and make sure the test still pass.

@ymodak , I verified the fix works fine with the latest code on x86 ubuntu python 2.  I have no idea how to view google's internal ci build failures, can you retry the test and if they fail, provide some details on why?

@wdirons Thanks for the update. Re triggered the tests now.

Can one of the admins verify this patch?

@wdirons  can you please fix build errors ?

I tried to rebase the pull request with the latest changes. That didn't work. I'm just going to close the PR and open another if I need to.


Modify Default Styles

Is there a way to set default styles for my file? i.e, I want to set the background colour of the button container and remove the radius?

Sure, I've updated the plugin so it is easy for you to override the defaults.
1: Download and Re-Install the plugin.
2: Override the plugin default values. (See Gif Below)

If in any case the plugin stops working, re-install again to get the default values.

Thank you!
How would I go about setting the background to no fill and applying an outline instead?  i.e for “outline/line” style buttons?
Kind Regards
Lance Redgrave | Managing Director
Level 1, 52-54 Willoughby Rd Crows Nest 2065
p(02) 9439 9115 tel:0294399115 m0405 419 755 tel:0405419755
<EMAIL_ADDRESS><EMAIL_ADDRESS>www.redfoxmedia.com.au http://www.redfoxmedia.com.au/ https://www.google.com/partners/?hl=en-US#a_profile;idtf=8008220449 http://www.webindustry.asn.au/directory/profile/redfoxmedia/ http://www.linkedin.com/company/2622382 https://www.facebook.com/RedfoxMedia1 https://twitter.com/redfoxmedia1 https://plus.google.com/+RedfoxMediaAU/ http://redfoxmedia.com.au/rss/

On 11 Dec 2016, at 10:22 am, fuggfuggfugg<EMAIL_ADDRESS>wrote:
Sure, I've updated the plugin so it is easy for you to override the defaults.
1: Download and Re-Install the plugin.
2: Override the plugin default values. (See Gif Below)
https://cloud.githubusercontent.com/assets/5616123/21076875/336d7902-bf05-11e6-85e5-d25f7261a228.gif
If in any case the plugin stops working, re-install again to get the default values.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/fuggfuggfugg/sketch-dynamic-button-3.5/issues/20#issuecomment-266248746, or mute the thread https://github.com/notifications/unsubscribe-auth/ABiRkj5cO3lD1jrSEE-ky4MZ-E5nw64Vks5rGzQrgaJpZM4LJcLl.

DynamicButton3.5.sketchplugin.zip
This plugin only for you. Unzip the file and install this plugin. It has no fill and #828282 as default border.
To edit the border color and thickness:

Open plugin in a text editor (previous gif)
Line 17 & 18, Change borderColor and borderThickness to your liking.

Let me know how it goes.

Awesome thanks!
Kind Regards
Lance Redgrave | Managing Director
Level 1, 52-54 Willoughby Rd Crows Nest 2065
p(02) 9439 9115 tel:0294399115 m0405 419 755 tel:0405419755
<EMAIL_ADDRESS><EMAIL_ADDRESS>www.redfoxmedia.com.au http://www.redfoxmedia.com.au/ https://www.google.com/partners/?hl=en-US#a_profile;idtf=8008220449 http://www.webindustry.asn.au/directory/profile/redfoxmedia/ http://www.linkedin.com/company/2622382 https://www.facebook.com/RedfoxMedia1 https://twitter.com/redfoxmedia1 https://plus.google.com/+RedfoxMediaAU/ http://redfoxmedia.com.au/rss/

On 20 Jan 2017, at 4:05 pm, fuggfuggfugg<EMAIL_ADDRESS>wrote:
DynamicButton3.5.sketchplugin.zip https://github.com/fuggfuggfugg/sketch-dynamic-button-3.5/files/718464/DynamicButton3.5.sketchplugin.zip
This plugin only for you. Unzip the file and install this plugin. It has no fill and #828282 as default border.
To edit the border color and thickness:
Open plugin in a text editor (previous gif)
Line 17 & 18, Change borderColor and borderThickness to your liking.
Let me know how it goes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/fuggfuggfugg/sketch-dynamic-button-3.5/issues/20#issuecomment-273978608, or mute the thread https://github.com/notifications/unsubscribe-auth/ABiRkkbxPYRf131fOfGqGkUY7yWSaOo-ks5rUEChgaJpZM4LJcLl.


The setter 'readEventsEnabled=' was called on null.

Flutter Doctor
when I run
flutter doctor
Building flutter tool...
The setter 'readEventsEnabled=' was called on null.
 Please run

    pub --trace upgrade --verbosity=error --no-packages-dir

This is likely not a tool issue that can be worked around, but a bug in the dart sdk:
https://github.com/dart-lang/sdk/issues/37808

Closing since this was fixed in dart 2.9.0-19.0.dev. All of the latest flutter channels except stable use 2.9.0-21.0.dev or newer.


Does not connect to Prolink network on High Sierra

Open app on a laptop running High Sierra.

Does not prompt to allow network connections.
Remains offline even after several minutes of waiting.

I believe we fixed this


support cite-group

mcom3414 contains cite-group. We somehow never added support for it (but since it has a dash, validation treats it as a custom HTML element).

Blast from the future - #443 means we can close this.


Order Categories in AddItem by index

They are ordered by some other method, but index would be coolest

It actually should already be doing this, this is a bug


Card Expiration Years need to include more years

The years drop down only includes the current year plus the next 4 years, and we are getting complaints from users that they cannot use their cards because their expiration year is not included in the drop down.

Is anyone keeping this component up-to-date? I tried doing a pull request with the fix for this issue, but the CI build is failing. Looking at the build history, it looks like they have been failing for a while? This is a simple fix, but is needed by my client. Please take a look at it as soon as possible.

Anyone can help with this? I'm facing the same issue here.

Anyone can help with this? I'm facing the same issue here.

anyone found a solution??

static getYears() {         /** @type {?} */         const years = [];         /** @type {?} */         const year = new Date().getFullYear();         for (let i = -2; i < 5; i++) {             years.push(year + i);         }         return years;     }
I don't know what is the purpose of starting the loop from last two years from now!!!!!!!!!


Update built-in-custom-tabs.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3411
Fixed links.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.


FBLPromise+Any.m line 33 Crash

[REQUIRED] Please fill in the following fields:

Unity editor version: 2018.4.19
Firebase Unity SDK version: 6.16.0
Source you installed the SDK: .unitypackage
Problematic Firebase Component: Analytics
Other Firebase Components in use: Messaging, Crashlytics
Additional SDKs you are using: Facebook, Adjust, Helpshift, One Signal
Platform you are using the Unity editor on: Mac
Platform you are targeting: iOS & Android
Scripting Runtime: IL2CPP

[REQUIRED] Please describe the issue here:
We can not reproduce the issue in-house but we're receiving crash reports from the Crashlytics. I'm adding a few crash reports. It looks like the users only experience this crash once then move on. We're suspecting it could be related to the Firebase upgrade.
FBL003.txt
FBL002.txt
FBL001.txt
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
No
What's the issue repro rate? (eg 100%, 1/5 etc)
We don't know.
What happened? How can we make the problem occur?
We don't know. We only have crash reports.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:

Hi @okanulas
Did you see this on both iOS and Android devices, or iOS device only? Your callstack looks like iOS one.
According to the second and the third callstack, it looks like some firebase::Mutex failed to be destroyed and try to log the message by invoking Unity Debug API when the app is terminated. While the app is being torn apart, it is probably not a good time to call a Unity API.
https://github.com/firebase/firebase-cpp-sdk/blob/f0a9d5b65e3a014aee347ea9bb3b664cdce2ae55/app/src/mutex.h#L53
We can potentially try to detect when iOS app is going to be torn apart and unhook the log function from Unity API. Do you think this is causing your user any trouble?  I assume this is a minor app crash which may not deteriorate user experience.
For your first callstack, it resembles #788 up until RuntimeInvoker_FalseSByte_ part. Is it possible to find Il2CppInvokerTable.cpp:40724 in your xcode project and see if you find more information? That callstack does not look like related to Firebase SDK.

Hi, @chkuang-g. Thank you for your patience. It is a busy week for me.
Yes, this crash only affects iOS devices. I didn't see any crash reports from Android devices.
I found that there are "FBLPromise+Any.m - Line 33" logs in other crash reports. Firebase most likely trying to access memory locations when the app is crashing. I think it is a good idea to remove Unity log calls or stop Firebase threads if the app is crashing.
Here is the Il2CppInvokerTable.cpp:40724 . I couldn't find the caller method and the real usage scenario. Hope it helps.
void* RuntimeInvoker_TrueVoid_t22962CB4C05B1D89B55A6E1139F0E87A90987017_RuntimeObject_Int32_t585191389E07734F19F3156FF88FB3EF4800D102_Int32_t585191389E07734F19F3156FF88FB3EF4800D102 (Il2CppMethodPointer methodPointer, const RuntimeMethod* methodMetadata, void* obj, void** args) { 	typedef void (*Func)(void* obj, RuntimeObject * p1, int32_t p2, int32_t p3, const RuntimeMethod* method); 	((Func)methodPointer)(obj, (RuntimeObject *)args[0], *((int32_t*)args[1]), *((int32_t*)args[2]), methodMetadata); 	return NULL; }

I'm seeing a similar issue. Different stack traces leading to it, but always FBLPromise+Any.m - Line 33 at the root. These issues occur on launch, and also mid-game.
We have almost identical stack:
Unity editor version: 2018.4.24
Firebase Unity SDK version: 6.16.0
Source you installed the SDK: External dependency manager
Problematic Firebase Component: Analytics (?probably?)
Other Firebase Components in use: FCM/Messaging, Crashlytics, Analytics, Dynamic links
Additional SDKs you are using: a bunch
Platform you are using the Unity editor on: Mac, Windows
Platform you are targeting: iOS & Android (only iOS is affected)
Scripting Runtime: IL2CPP
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
No
What's the issue repro rate? (eg 100%, 1/5 etc)
10% of iOS users. (by users affected. Probably a much lower % by session. Only shows in Firebase, is not reported by iTunes)
What happened? How can we make the problem occur?
We don't know. We only have crash reports.

Hey folk,
I think it is worth to share some of my findings.

If you look into FBLPromise+Any.m:33, you should find this assert when one of the passed-in promise is still pending.  This part of code has not been changed since Jan 2018 so I assume the line number should be accurate enough.
Based on the code,FBLPromiseCombineValuesAndErrors can only be accessible through Objective-C call like [FBLPromise onQueue:myQueue any:myPromises].  However, I cannot find any this kind of usage in Firebase iOS SDK.
When you see callstack like RuntimeInvoker_FalseSByte_, this is most likely generated by Unity IL2CPP. Unfortunately I do know know what that is generate from, nor do we have control about it.
It seems that all the user who experienced this issue is using Unity 2018 (three on 2018.4)

All these information leads me to think that this might be an issue in Unity instead of Firebase.
FWIW, could you try to upgrade to later version of Unity and see if you are still seeing the crash reporting?
Shawn


Feature Requests

If you have any feature requests, add a comment here with as much detail - when I work on the next version then I will consider them.
If you want to see a feature implemented it, add a comment with the feature number and a +1

Request: Cover inline table valued functions
Statements inside inline table valued functions are not currently covered, the sp_statement_completed event doesn't include inline tvf's but we do get a intent-shared transaction lock so we could include those in the trace and show whether an inline tvf has at least been called. They can't contain branches in so they would either be 0% or 100% covered.
Possible issues to consider:
Do different isolation modes change the lock types?
-Can we filter to just inline tvf's?
-The current trace system wouldn't be able to cope with adding lock aquired's in, more work on the perf of that side of things would be required
-Do we always get a lock for it?
This was copied from: https://github.com/GoEddie/SQLCover/issues/30

Request #2: Corbertura output files support

Request #3: html output: navigation buttons to go to top of page

Request #4: Sql 2019

Request: #5: Sql on linux support (might just be testing)

Request #6: Configure timeout

Hi @GoEddie ,
Do we have a resolution for the issue pls, https://github.com/GoEddie/SQLCover/issues/5

Do we have a resolution for Request https://github.com/GoEddie/SQLCover/issues/5 please?

@Athi2019 no sorry, I haven't tried covering t-sql on a sql on linux instance - if you have and it doesn't work it would be great if you can add any details of exceptions etc.

@GoEddie  I am trying to cover t-sql on a sql instance on windows. Please refer this link for the details:
https://forum.red-gate.com/discussion/85990/incorrect-sql-test-code-coverage#latest

Hi @athi2019 sorry I misunderstood, I see now :)
The issue you have is a few days work and I don’t have the capacity at the moment for that amount of OSS work.
If it is important to you and you have a budget I would be happy to discuss sponsorship to get it working for you, if you would like to pursue this please reach out to me<EMAIL_ADDRESS>Ed

Please can you add an azure-pipeline examples to this repo.. I am using with Azure and I am not sure I am doing it right because  report generator shows files missing when I drill down.

Request: Output report files in UTF-8 by default.
I had issues uploading the OpenCover XML to sites like https://codecov.io since it wasn't in UTF-8. I'm not manually converting before uploading, but it would be nice if that was default or an option. A low lift would be to include this in the example .ps1 file as well.

@persistence911 there is now a github action that works, also see my open sourced project https://dev.azure.com/funktechno/_git/dotnet ci pipelines?path=%2Fazure-pipelines.yml for running a sql server instance in an azure devops pipeline


Update discipline-specs2 to 1.1.3

Updates org.typelevel:discipline-specs2 from 1.0.0 to 1.1.3.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "discipline-specs2" } ]

labels: test-library-update, semver-minor

Superseded by #235.


Cleanup Python details of the recipe

I tried to cleanup the recipe w.r.t. Python aspects taking as example other recipes that use outputs to split a base C++ package from the Python bindings, such as https://github.com/conda-forge/root-feedstock/blob/master/recipe/meta.yaml .
Hopefully this should help with https://github.com/conda-forge/libode-feedstock/issues/9 .
Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

The PR is ready for review @conda-forge/libode .

Thanks for catching this!


Feature request: Get shares of all (or specific) users

As an admin I would like to get the shares of all users or of a specific user without having to authenticate as that user. I dont know if the OCS API supports that (but I assume so). If you through me pointers at it, maybe I can look at it for a PR.

Isn't this: https://github.com/dachinat/nextcloud/blob/44b7755cef8d034ac584b18444b20248b4120ebc/lib/nextcloud/ocs/file_sharing_api.rb#L41


MC_37: Last digit in stated value of x-axis is truncated from right side

RELEASE: v0.6.0
SEVERITY: Minor
MODULE: Mountain Chart
OS/BROWSER: Windows 7 / Chrome 45.0
STEPS TO REPRODUCE:

Navigate to URL: http://static.gapminderdev.org/vizabi/release/v0.6.0/preview/mountainchart.html
Mountain Chart page will be loaded
Click on Full under label Responsiveness Or click on Landscape view
Note that last digit is slightly cut off from right side

ACTUAL RESULTS:
Last digit of x-axis marked is slightly cut off from right side
EXPECTED RESULTS:
Maximum value marked on x-axis scale should be visible completely
SCREENSHOT:

Can't reproduce on development branch Mac OS X 10.10 / Chromium 46.0

@gaivoronsky
At this moment I'm not able to load Mountain chart in release 0.6 as tried many times. we can retest it, once release 0.7 will be available.

Might be fixed, can't be reproducible also on my side as checked on develop branch

yes, it was fixed


UnmarshalBinaryStream implemented

Fixes https://github.com/tendermint/go-wire/issues/101
Allows users to stream in input to be decoded by
this package.

Plz check my comment here: https://github.com/tendermint/go-wire/issues/101
It's not easy to make a binary reader byzantine-memory-spam/DDoS-proof.  You need to pass around counters, because you never know how much more you're going to read, and so we need to count as we read/allocate...  it gets complex.  See original go-wire (e.g. today's Master I think).
MarshalLengthPrefixed/UnmarshalLengthPrefixed is the way to go.  It makes read-counting so much easier to just know how many bytes there will be, up-front.  Which is why UmarshalBinary() takes bz []byte.

Reader implemented on develop now.


refactor and test: balancer/CalcJoinPoolShares

Background
We have observed rounding errors in balancer post-refactor (#1307). There are several balancer pool methods being called from the function in #1307 under the hood that are not unit-tested.
As a result, it is non-trivial to identify the source of the problem. All methods should be covered by unit tests. One of such untested methods is CalcJoinPoolShares
On initial investigation, this method does many things, violating the single responsibility principle in SOLID. As a result, it is difficult to reason about and test.
The person taking on this issue should investigate if it is worth refactoring this method to extract a few others to be called under the hood to mitigate the violation. If any, all newly extracted methods should be unit tested, including CalcJoinPoolShares itself.
Acceptance Criteria

investigate the need for extracting several methods from CalcJoinPoolShares to ease unit testing and improve readability
ensure all logic in CalcJoinPoolShares and newly extracted functions/methods, if any, are covered by unit tests
edge cases are well thought out
all old and new unit tests pass

@alexanderbez would you be interested in working on this? Thanks for offering to help with the tests


Misc-fixes

Description

Add missing oc script to downstream dockerfile
Skip dependencies check to force versions

Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[ ] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

/lgtm

@jpinsonneau @msherif1234 - how is this supposed to work e2e, am I (as customer) supposed to update the yq version before using CLI 1.8? I don't think we'd expect customers to install dependencies using make targets.

That's just for us indeed. Check https://github.com/netobserv/network-observability-cli/pull/140

/retest

/lgtm
we can defer bumping to 4.18 images for future PRs


Releases 1.1.7 and 1.1.8 are not backwards compatible with 1.1.6

Based on the changes introduced in v1.1.7, my release to Azure job is getting the following error:
##[Initialize]
##[ValidateParameter]
Error: Execution Exception (state: ValidateParameter) (step: Invocation)
Error:   Cannot read property 'indexOf' of undefined
Error:     TypeError: Cannot read property 'indexOf' of undefined
    at ParameterValidator.validateScmCredentialsSlotName (D:\a\_actions\Azure\functions-action\v1.1.7\lib\handlers\parameterValidator.js:158:42)
    at ParameterValidator.<anonymous> (D:\a\_actions\Azure\functions-action\v1.1.7\lib\handlers\parameterValidator.js:56:18)
    at Generator.next (<anonymous>)
    at fulfilled (D:\a\_actions\Azure\functions-action\v1.1.7\lib\handlers\parameterValidator.js:24:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error: Deployment Failed!

My job is running on windows-latest and is currently working now that I've specifically pinned v1.1.6 as the version of this action to run.
My job is using a publish profile as the Deployment Credential, the publish profile was generated in July and has the following format (the names and passwords have been changed):
<publishData>
  <publishProfile profileName="my-api - Web Deploy" publishMethod="MSDeploy" publishUrl="my-api.scm.azurewebsites.net:443" msdeploySite="my-api" userName="$my-api" userPWD="***" destinationAppUrl="http://my-api.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
  <publishProfile profileName="my-api - FTP" publishMethod="FTP" publishUrl="ftp://waws-prod-blu-095.ftp.azurewebsites.windows.net/site/wwwroot" ftpPassiveMode="True" userName="my-api\$my-api" userPWD="***" destinationAppUrl="http://my-api.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
  <publishProfile profileName="my-api - ReadOnly - FTP" publishMethod="FTP" publishUrl="ftp://waws-prod-blu-095dr.ftp.azurewebsites.windows.net/site/wwwroot" ftpPassiveMode="True" userName="my-api\$my-api" userPWD="***" destinationAppUrl="http://my-api.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
</publishData>

@Hazhzeng Can you please take a look at this?

@Hazhzeng Can you please look into this?

Hi @rue-kcarlton, thanks for raising the issue.
Based on the error logs, seems like the Github Action fails on slot validation.
Could you share me your workflow.yml? Just want to see if the slot-name variable is set.

@Hazhzeng here's my workflow snippet as it existed during the first of the failed runs:
   - name: Run Azure functions action to deploy ${{ steps.vars.outputs.RELEASE_NAME }} to ${{ env.FLEET }}
      uses: Azure/functions-action@v1
      id: fa
      with:
        app-name: ${{ env.AZURE_FUNCTIONAPP_NAME }}
        package: ${{ env.AZURE_FUNCTIONAPP_PACKAGE_PATH }}
        publish-profile: ${{ secrets.AZURE_FUNCTIONAPP_PUBLISH_PROFILE }}
        slot-name: staging

I think I may have figured out the issue... based on older documentation, I still have the SCM_CREDENTIALS secret set which includes the Azure Publish Profile, but not the AZURE_FUNCTIONAPP_PUBLISH_PROFILE secret.  I haven't been able to test my theory as I didn't want to release again over the holiday weekend (or on cyber Monday).

Thanks @rue-kcarlton for the quick turn around. Yes, it is also worth try to change the line
publish-profile: ${{ secrets.AZURE_FUNCTIONAPP_PUBLISH_PROFILE }}

back to
publish-profile: ${{ secrets.SCM_CREDENTIALS }}

@rue-kcarlton Please let us know if the issue is still happening.

I attempted a release this morning with the change @Hazhzeng suggested (changing my publish-profile to the secrets.SCM_CREDENTIALS), but now I'm getting a new error:
##[Initialize]
##[ValidateParameter]
Successfully parsed SCM credential from old publishProfile
Error: Execution Exception (state: ValidateParameter) (step: Invocation)
Error:   At ValidateParameter, slot-name : SCM credential does not match slot-name.
Error: Deployment Failed!

I see @rue-kcarlton, this action did a validation to ensure your publishProfile matches your slot. The line
publishUrl="my-api.scm.azurewebsites.net:443"

Should be something like
publishUrl="my-api-slotname.scm.azurewebsites.net:443"

instead.
This issue happens when you download your publish profile in your main app instead of from your slot. Please try setting the SCM_CREDENTIALS secret with the slot publish profile.

@rue-kcarlton Are you still facing the issue?

@rue-kcarlton Can you check from your side and let me know if its working?

@aksm-ms Yes, I'm still having the issue... I changed my publish profile to be something like this
<publishData>
  <publishProfile profileName="my-api-staging - Web Deploy" publishMethod="MSDeploy" publishUrl="my-api-staging.scm.azurewebsites.net:443" msdeploySite="my-api__staging" userName="$my-api__staging" userPWD="***" destinationAppUrl="http://my-api-staging.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
  <publishProfile profileName="my-api-staging - FTP" publishMethod="FTP" publishUrl="ftp://waws-prod-blu-095.ftp.azurewebsites.windows.net/site/wwwroot" ftpPassiveMode="True" userName="my-api__staging\$my-api__staging" userPWD="***" destinationAppUrl="http://my-api-staging.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
  <publishProfile profileName="my-api-staging - ReadOnly - FTP" publishMethod="FTP" publishUrl="ftp://waws-prod-blu-095dr.ftp.azurewebsites.windows.net/site/wwwroot" ftpPassiveMode="True" userName="my-api__staging\$my-api__staging" userPWD="***" destinationAppUrl="http://my-api-staging.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
</publishData>

So the slot should match up at this point, but I'm still getting the same error:
Successfully parsed SCM credential from old publishProfile
Error: Execution Exception (state: ValidateParameter) (step: Invocation)
Error:   At ValidateParameter, slot-name : SCM credential does not match slot-name.
Error: Deployment Failed!

@Hazhzeng  can you please take a look at this?

@Hazhzeng Can you please update this?

@aksm-ms, could you take a look at this?

@rue-kcarlton Are you still facing the issue? @Hazhzeng Can you please look into this? cc: @nadesu

@rue-kcarlton Are you still facing the issue? @Hazhzeng Can you please look into this? cc: @nadesu

@aksm-ms Yes, I'm still having this issue.  I've reverted to using v1.1.6 to keep it working.

@aksm-ms Yes, I'm still having this issue.  I've reverted to using v1.1.6 to keep it working.

I had a very similar issue today that may be related.  Essentially, my app name is MyService and the slot name is deployment, and I would get the "SCM credential does not match slot-name" error message.  However, using myservice as the app name fixed the issue entirely.  It looks like the default publish profile to-lowers everything, but the check that it's using the correct slot doesn't to-lower the input, so the check fails.  I would like to be able to use the correct casing for my yml, but the workaround gets the job done for me right now.
Then again, this could be an entirely different issue from @rue-kcarlton's

I had a very similar issue today that may be related.  Essentially, my app name is MyService and the slot name is deployment, and I would get the "SCM credential does not match slot-name" error message.  However, using myservice as the app name fixed the issue entirely.  It looks like the default publish profile to-lowers everything, but the check that it's using the correct slot doesn't to-lower the input, so the check fails.  I would like to be able to use the correct casing for my yml, but the workaround gets the job done for me right now.
Then again, this could be an entirely different issue from @rue-kcarlton's

Sorry for the late reply and thanks @dastev-ms for the investigation.
Hi @rue-kcarlton
This issue should be fixed now https://github.com/Azure/functions-action/blob/v1.3.1/src/handlers/parameterValidator.ts#L172-L173.

Sorry for the late reply and thanks @dastev-ms for the investigation.
Hi @rue-kcarlton
This issue should be fixed now https://github.com/Azure/functions-action/blob/v1.3.1/src/handlers/parameterValidator.ts#L172-L173.


Relayer: Restore partial transport execution mode

After #191, the Relayer lost its capacity to be configured partially to run in only one transport direction.
The configuration parsing only succeeds if all environment variables for all transport directions are defined.
Expected behavior
Configuring the Relayer only for a single transport direction should be possible.

Summary:
On the team call on 29.04.2024 we came to the following consensus:

move forward with the toml file based approach
toml file will be mounted as a volume at tbd location for the relayer to read
we provide the "parse $ENV as env variables" ability described here
currently, we will provide the private key as a k8s secret (and it would get injected when parsing the toml file config), with the intention that later we can use HSMs (not any time soon tho)


Add ppc64le Architecture Support for Wheel Builds on Ubuntu

This PR introduces support for the ppc64le architecture to enable building wheels for Power architecture on the Ubuntu platform. By adding ppc64le to the list of supported architectures, this change aims to facilitate the creation and distribution of ml_dtypes wheels for Power systems.
Request:
Please review these changes to ensure compatibility, and if approved, merge them so that we can begin generating and publishing ml_dtypes wheels for Power architecture.

Hi Team,
I hope this message finds you well! I wanted to kindly follow up on this PR
This PR introduces support for the PPC64LE architecture, including the necessary workflow updates. The changes have been tested successfully, and I'd be happy to address any additional feedback or requirements to move this forward.
If there are any concerns or suggestions for improvement, please let me know. I'm available to make updates as needed.
Looking forward to your feedback!
Regards,
Sandeep


Confusing log fields when backing up additional items for an object

When testing #1843, I noticed that the logger in the itemBackupper has the resource field preset from the resourceBackupper. If an item in a resource pulls in any additional items (e.g. a Pod's PVC or PV), the resource field continues to reflect the current resource (e.g. "pods" rather than "persistentvolumeclaims").

We should set the resource field using the groupResource passed into backupItem to ensure we're not confusingly displaying the wrong resource for the item.
We might also want to display the resource we're going through in a different field to make it more clear what resource pulled in an additional item, but I can't think of a good name for this field. Also, the logs around the additional item already help to indicate what the original resource/item is.

I'd love to pick up this issue to help you guys out!
Just for my own education, I don't think groupResource ever takes a new value between when it's declared and when backupItem could act on it.
https://github.com/heptio/velero/blob/5e22f9c1c87192b2cf23454a41aa4181d4f96ddb/pkg/backup/resource_backupper.go#L110
Doesn't this mean that if we use the groupResource passed into backupItem then the field would still be unchanged from before?
If you want to get the Resource of the obj that's being passed and account for the case listed in the issue, I think the best thing to do might be to meta.TypeAccessor(obj) at the top of backupItem.

PR added: https://github.com/heptio/velero/pull/1904


Second pass T5 duplicate removal

rearranges loop order. Changes loops over lower modules to loops over eligible T5 modules (results in more T5s i think).
I found that only 1 thread in the inner most loops actually worked the best so I took off the parallelism there and moved it to the outer most loops with the modules. This seems to have given the best result.

https://www.classe.cornell.edu/~mgr85/www/SegmentLinking_keep/PR158/eff_plots__GPU_explicit_cache_bd99a1c_PU200/
There is a higher efficiency and duplicate rate here. But the duplicate rate is still fairly low I think.


Added reactor operator back into geometry converted reactor for model…

…ing FPs, changed check for needing to model fission products within the lattice physics writer based on if FPs are present, which generalizes to allow blanket fuel to be depleted.
Description
Users were running into issues with modeling MC2 1D CR with global flux solvers for self-shielding calculations. The error is caused by blocks not containing fission products due to the operator missing in the converted reactor.

Checklist

[ x ] This PR has only one purpose or idea.
[ x ] Tests have been added/updated to verify that the new/changed code works.

[ x ] The code style follows good practices.
[ x ] The commit message(s) follow good practices.

[ x ] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[ x ] The documentation is still up-to-date in the doc folder.
[ x ] The dependencies are still up-to-date in setup.py.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Michael Huang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

This change combined with the change to our internal lattice physics plugin seems to solve the issue that I was having.

@LMikeH you need to also link your TerraPower email to.your GitHub account so that you can sign the CLA before I land. Thank you for running black!

If you just need a hot fix right now, I can support this PR.
We/I will have to undo it real soon, of course.  We have this open ticket that shows the actual cause of your problem, that HexToRZThetaConverter and parameterSweepConverters are some of the only places left that use this backwards r.o:
armi/reactor/converters/geometryConverters.py:  self._o = self._sourceReactor.o

armi/reactor/converters/parameterSweeps/generalParameterSweepConverters.py:  fh = r.o.getInterface("fuelHandler")

Both of those seem pretty straight forward to fix in ARMI, as they really aren't used much. Someone just got a little lazy about passing in the lumped fission products.  But I haven't looked in downstream projects to see what the LOE would be like there.  So, sure.

Thanks @john-science - Yeah we need this as a hot fix, but thank you for your work on removing the reactor's reference to the operator. I think one of the biggest things holding us back from removing the operator in some cases is that interfaces on the operator hold state that isn't recoverable in other ways and it's not easy to create a new interface on the fly and get that state back.


truncate appVersion to 63 characters

@bilalbokharee Yikes!  Build has Failed!

@bilalbokharee Validation Successful


[feature request] subscribe only to a specified relay/relays

ex.
const subscription = ndk.subscribe(filter, opts, ["wss://relay.stemstr.app"]);
Use case: I am currently implementing NDK in Stemstr. I want to be able to fetch the main feed ONLY from the Stemstr relay, but grab replies, reactions, zaps, etc. from other relays as well.

@pablof7z could this be accomplished by simply creating a new/second instance of NDK that only connects to the single relay?

took longer to do than to type how to do it... 😅

LOL – nice one!


Splits Execute Method into 'plan' and 'execute' methods

@shaun-edwards Is this what you were thinking?

@geoffreychiou, don't forget about this one.


Combine selections and location

No need to review this since mapview is branched off this one.
This PR combines app.selections and app.location, such that it's just app.selections now, which contains both data and location information. I had to modify notebooks that worked directly with app.location to function with this new update (see PR in cae-notebooks here)
To test: Review the code, I guess, and look over the cae-notebooks PR in either this branch or the mapviews branch, which is branched off of this one.

Merging without official reviews since many other PRs that were branched off of this one were thoroughly reviewed.


[OS X] Yo Error: EACCES: permission denied

I managed to install yeoman on OS X Catalina.
However, when I run the
yo botkit
I have the following error
Error: EACCES: permission denied, open '/Users/valentin/Library/Preferences/insight-nodejs/insight-yo.json.4064983394'
    at Object.openSync (fs.js:440:3)
    at Function.writeFileSync [as sync] (/usr/local/lib/node_modules/yo/node_modules/write-file-atomic/index.js:212:13)
    at Conf.set store [as store] (/usr/local/lib/node_modules/yo/node_modules/conf/index.js:142:19)
    at new Conf (/usr/local/lib/node_modules/yo/node_modules/conf/index.js:44:14)
    at new Insight (/usr/local/lib/node_modules/yo/node_modules/insight/lib/index.js:40:35)
    at Object.<anonymous> (/usr/local/lib/node_modules/yo/lib/cli.js:54:17)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14) {
  errno: -13,
  syscall: 'open',
  code: 'EACCES',
  path: '/Users/valentin/Library/Preferences/insight-nodejs/insight-yo.json.4064983394'
}

I tried with sudo but the result is the same. I don't see this problem corrected. Any ideas?

I think you are reporting this to the wrong repo. botman is something else completely unrelated to Botkit.

Youps, was an error in writing post ! I fix it !

Gotcha.
Well, it's really hard to say what might be causing this, as this is a local filesystem permission issue.  Are you using the latest version of the generator?
Perhaps try reinstalling yeoman?

I managed to recover the original project on
https://botkit-facebook.glitch.me
But I wish yo would work.
Indeed it's related to OS X but I don't think I'm the only one who had this problem.

Did you try reinstalling yeoman? The error you posted is from an internal package used by Yeoman, not Botkit.
I am not able to reproduce this error.


normalizing and usage

I'll try and summarize some of what I've done:

Changed $fn to be dependent on preview/render (no need to slow down previews with high resolution)
Renamed led_3mm to led since diameter is a variable, not constant
Renamed toggle_switch to switch to shorten variable name (as there are no other switches in the panel)
Cleaned up unnecessary center = true on some cylinders (they were translated to basically undo the setting)
Cleaned up formatting, including transformations, line spacing, and indenting
Echo commands in generatePanel() are only called if there's a component to generate
Commented out the generatePanel() line in panel.scad since it was causing panels to be generated twice (slows things down)
Rewrote the "how to use" section of the readme
Made some slight edits totemplate.scad

This was so helpful. Thank you very much @slashinfty!


Fix cassandra

Motivation for this change
This is a rewrite of the cassandra module as described in #31349.
Things done
Cassandra succesfully starts in a container with the following expression:
  containers.cassandra =
    { privateNetwork = true;
      config =
        { config, pkgs, callPackage, ... }:
        {
          imports =
            [ /path/to/nixpkgs/nixos/modules/services/databases/cassandra.nix
            ];

          nixpkgs.config.allowUnfree = true;

          ids.uids.cassandra = 284;
          ids.gids.cassandra = 284;

          services.cassandra.enable = true;
          services.cassandra.package =
            pkgs.callPackage /path/to/nixpkgs/pkgs/servers/nosql/cassandra/3.11.nix {
              jre = pkgs.jre8;
            };
          services.cassandra.extraConfig =
           { commitlog_sync_batch_window_in_ms = 3;
           };
        };
    };

The module surely needs some further refinements. But it's a start. :)

Could you add back at least a simple test?

I have tried to port the old test, but I ran into some problems that I believe should be fixed out-of-the-box.

JMX was not enabled, because of missing cassandra-env.sh.
The Thrift interface was not enabled
cqlsh, nodetool are not on the system path.

Other things I've noticed:

Other config files are also missing in cassandraEtc. Makes me wonder what else will break.
The repair service+timer is missing. Regular repairs seem to be a necessity, but auto-scheduled repairs have not been integrated into cassandra itself yet.

Yeah, it's fine if there is stuff that does not work. But I'd rather we have a simplistic test than none at all...

based on @roberth testing and review, marking as a WIP so it doesn't get accidentally merged before those points are addressed. I also think some of these commits can be squashed. I don't see a reason to do 2 version bumps in a single PR.

Agreed with @NeQuissimus , the previous commit/test may not have been pretty, but it did reveal bugs in the packaging before that yielded unusable nixos packages. cassandra would run, but if you tried to join it to a cluster, it would segfault due to a missing compression library.
for history, the service/repair, it was originally left out as there was an external task to run repairs. a cluster running repairs at the same time is effectively down and coordinating that in a module wasn't trivial.

Couldn't find the time to push this any further earlier. I just pushed a simplistic test which already revealed a few problems. Do I have to plug in this test anywhere else?
@roberth cassandra-env.sh from the original package is now symlinked into cassandraEtc. Should we add a configuration option to overwrite this?
Should cqlsh and nodetool really go into PATH automatically? You can simply achieve the same by adding the package to environment.systemPackages. Is there some kind of policy on how these things are approached?
@disassembler I'm willing to clean up the commit history before this get merged. Should I do this in this branch and do a forced push or open a new pull request?

Just cleaned up the commit history.

@fuzzy-id , could you add an entry in the release notes?

@fuzzy-id The lines from your example
      ids.uids.cassandra = 284;
      ids.gids.cassandra = 284;

seem to be required, whereas for other services these ids are added automatically.

@roberth I added a small section to the release notes.
Previously the uid and gid were set in the service itself. Should I put it back in there? Does this also work around the possibility of overlapping ids?

@fuzzy-id I'm sorry, my last comment about the ids was incorrect. I jumped to a conclusion too quickly. Your solution seems to be an improvement. I believe NixOS has a 'reserved' range of uids for this purpose, where you can consider the uid assigned when it gets merged. Haven't seen official docs about that though. LGTM

@NeQuissimus do you think this is ready for merging?

@fuzzy-id This does need to be in the release notes. Would you moving it to the 18.09 release notes?

I would really like to see this working again

@bfrog This is working! We don't use it in production atm, as we are in alpha phase. Hence, I haven't played around and cleaned up cluster-setups. But for simple single-machine setups it works like a charm. (NixOS-tests for multi-cluster setups are there, so it should be working.)

Hey guys,
is anyone willing to merge this, so that it will be part of 18.09? I could invest some more cleanup work if there is the need to. (i.e. adding the release note and resolve the conflicts). But it would be nice to get some affirmation that the work is not going to be lost because no one really has the time to merge this.
I just wanted to do version bumps for Cassandra and all this rebasing and cherry-picking just to be able to run the tests is a big pain in the as. So I guess we would rather maintain our own versions of this module internally.

If you rebase it, we should be able to merge it.

Rebased and added release note. Let me know if there is something missing.


Inform the user about KaTeX errors and its limitations.

needs to also work for LaTeX in markdown, not just LaTeX cells


chore: bump all dependendies to latest

It is much simpler and faster to bump all dependencies to the latest then it is to determine what is the minimal set for Bazel 7 support.
Same as https://github.com/aspect-build/rules_esbuild/pull/174.

@gregmagolan any idea when this will be merged/released? We'd love to move to Bazel 7/bzlmod and this is a blocker.

Actually, looks like downgrading to aspect_bazel_lib 1.40.0 resolved the issue (related to #135)


Invalid for_each argument for aws_iam_role_policy_attachment.custom

Found a bug? Maybe our Slack Community can help.

Describe the Bug
The terraform apply fails when using a custom policy. Example code:
module "documentdb_scheduler_policy" {
  source = "git::https://github.com/cloudposse/terraform-aws-iam-policy.git?ref=0.3.0"

  namespace          = var.project_name
  stage              = local.stage
  name               = "documentdb-scheduler-policy"
  iam_policy_enabled = true
  iam_policy_statements = {
    DocumentDB = {
      effect     = "Allow"
      actions    = ["rds:StartDBCluster", "rds:StopDBCluster"]
      resources  = [module.documentdb.arn]
      conditions = []
    }
  }
}

module "documentdb_scheduler_stop_lambda" {
  source = "git::https://github.com/cloudposse/terraform-aws-lambda-function.git?ref=0.3.6"

  namespace              = var.project_name
  stage                  = local.stage
  name                   = "documentdb-scheduler-stop"
  function_name          = "${module.label_documentdb_scheduler.id}-stop"
  handler                = "stop.lambda_handler"
  runtime                = "python3.8"
  filename               = "lambda/documentdb_scheduler/stop.zip"
  source_code_hash       = data.archive_file.documentdb_scheduler_stop.output_base64sha256
  custom_iam_policy_arns = [module.documentdb_scheduler_policy.policy_arn]
}

Error message:

╷
│ Error: Invalid for_each argument
│
│   on .terraform\modules\documentdb_scheduler_stop_lambda\iam-role.tf line 79, in resource "aws_iam_role_policy_attachment" "custom":
│   79:   for_each   = local.enabled && length(var.custom_iam_policy_arns) > 0 ? var.custom_iam_policy_arns : toset([])
│     ├────────────────
│     │ local.enabled is true
│     │ var.custom_iam_policy_arns is set of string with 1 element
│
│ The "for_each" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work around this, use the
│ -target argument to first apply only the resources that the for_each depends on.
╵

Environment (please complete the following information):
Anything that will help us triage the bug will help. Here are some ideas:

OS: Windows
Version 10
terraform 1.0.0

Actually, the problem is with the terraform-aws-iam-policy module, I'll close this for now and reopen if needed later.


feat: add gum helper for choose dialogs

This should help start the process of addressing #148 as it will let us provide basic replacement for gum on systems that lack it with minimal options which in turn lets us shrink down the amount of just commands we have greatly.
Currently it only does choose dialogs, but before merging i want to implement the confirm dialog too.
Return values will be identical to what you would expect from gum so in the most basic use cases it will be a 1:1 drop in, assuming you do not need anything more fancy than the defaults from gum.

Current implementation of ugum supports the choose and confirm verbs
if a command was to be gum choose --cursor="| " "ace of spades" "king of hearts" "5 of diamond" in a just recipe, this can now be replaced with ugum choose --cursor="| " "ace of spades" "king of hearts" "5 of diamond" and ugum will ignore any arguments starting with - and only focus on the the basics, which is providing a choice selection for the user, if ugum detects that the gum binary is present, it will pass all arguments to gum for a more fancy output.
The return values in STDOUT will match what you would expect from using gum if it was installed and it will return the option the user selected.
ugum confirm does the same for confirm dialogs and would be the equivalent to gum confirm.
To change the default prompt just supply one after confirm like ugum confirm "Do you want to build a rocket ship?"
exit code will be 0 if yes, 1 if no. This matches the output from gum

Is there any more changes i need to do to the spec file since it says it failed to build due to the ugum file missing in the log? :thinking:

fzf is now being used as fallback handler if gum is not available and will look like this

if no supported handler is provided in $MENU environment variable and fzf is not available, it will use basic bash to generate the choice selection and the confirm prompts

This looks great!!

Ok, as long as no more needed changes get requested, this is now feature complete for initial release.
There were some requests to use fzf after the PR got opened for review.
Since fzf is included in the images, making it a perfect alternative for gum for those images.
The generic bash alternatives are still there in case a user makes a custom image and removes fzf and gum for whatever reason.
Any more changes will be done at a later date with their own PR and if support for more menu handlers is desired then it can be added at a later date by people familiar with the said menu handlers (dmenu, rofi, wofi, rofi-wayland, etc)