Allow useSelector without provider

What is the new or updated feature that you are suggesting?
Allow using useSelector outside a provider, in which case return either a default value as defined by the context, undefined, or a noop function.
Why should this feature be included?
Some parts of our application have text fields that trigger a "currently highlighted field" value when it receives focus.
For example (similar to our use case): focusing the field for the name of a player will highlight their profile icon, this "currently selected player" information is handled in a uiStore with onFocus={() => dispatch(actions.setFocusedField(id))}.
The highlighting is not critical to the operation of the text field. If there is no available uiStore it's fine to continue without it, but useReduxContext (as called by useSelector / useDispatch will throw an error.
I tried using useStore directly but this also throws, and would leave me without the functionality provided by useSelector.
What docs changes are needed to explain this?
I could not find the reason for this restriction in the docs.

React-Redux has always relied on accessing the store via React context.  It's effectively a form of dependency injection, which enables separating the question of "which store is this component reading from?" from the actual specific store instance.  Otherwise, you'd be locking yourself into a single store that's being imported directly from a module.  (You'd also have to somehow pass that store instance into every call to useSelector and useDispatch.)
For connect specifically, it also relies on the context hierarchy to ensure the invariant that a given component's mapState function only runs after its nearest connected ancestor has updated, to ensure it has the freshest props available as ownProps inside of mapState.
We have no plans to change this.
If some of your components can somehow be used without a Redux store available, then you probably need to rewrite them to separate out which pieces do rely on Redux vs which pieces do not (such as having a parent component that reads dispatch from the Redux store and passes it down as a prop to the child).


RateLimiter attempt method returns true if callback returns values considered false

Laravel Version: 9.36.3 and other
PHP Version: 8.1.11 and other
Database Driver & Version: doesn't matter

Description:
The attempt method contains ?: operator and casts the return value of $callback function to true for all list of values considered as false.
    public function attempt($key, $maxAttempts, Closure $callback, $decaySeconds = 60)
    {
        if ($this->tooManyAttempts($key, $maxAttempts)) {
            return false;
        }

        return tap($callback() ?: true, function () use ($key, $decaySeconds) {
            $this->hit($key, $decaySeconds);
        });
    }

Steps To Reproduce:

$return = RateLimiter::attempt('key', 10, fn() => false, 1); // $return = true, not false

$return = RateLimiter::attempt('key', 10, fn() => [], 1); // $return = true, not []
$return = RateLimiter::attempt('key', 10, fn() => 0, 1); // $return = true, not 0
$return = RateLimiter::attempt('key', 10, fn() => 0.0, 1); // $return = true, not 0.0
$return = RateLimiter::attempt('key', 10, fn() => "", 1); // $return = true, not an empty string

// etc.

Obviously, it's a bug, but the fix also affects the attempt() method return value and may bring backward incompatibility to those who depend on true return.
I believe we have to change attempt() body, remove the cast:
$callback() ?: true

and return explicitly defined user value
$callback()

Case: 3rd-party APIs may return empty arrays as a successful response.
I'm ready to provide PR but kindly ask the community to advise how to deal with this bug-fix effect.
Does it make sense to push the fix in the next version branch?

I believe the API was specifically designed to return a truthy value because false is only expected when the "attempt" fails because of rate limiting. Otherwise you have no way of knowing if false means that the rate limiting kicked in or you simple got back false for your callback. This indeed has the effect on the values you listed but I believe this is expected. If you want you can attempt a PR but like you said it should target the next major version.


Problem on custom node  VideoHelperSuite

I'm trying to convert my workflow to code, but when I run to the combine vedio section, this error occurs.

My workflow works fine in comfyui but fails in python.

workflow_api.json.txt
workflow_api.py.txt.txt
This is my workflow and code.

There was a conflict when the VHS module was running, when I removed the VHS module and replaced it with the image saving module, it worked.

You can save in setting debug in official right now, don't have to use this repo

I believe this might be a similar issue to https://github.com/pydn/ComfyUI-to-Python-Extension/issues/32 and https://github.com/pydn/ComfyUI-to-Python-Extension/issues/26
It seems that some arguments are not being passed for certain custom nodes.


Remove miqOnLoad() from login page and replace afterOnLoad defs

We were using only the ManageIQ.afterOnLoad part of miqOnLoad(), where a simple eval() is called. But because eval == evil, it is more "safe" to call the button clicks from document.ready.

@abellotti can you help me with testing this?

@skateman changes are good 👍
Updated my miq saml appliance to latest source and included the changes here, still work!!

@himdel can you check this from the JS side?
@miq-bot assign @himdel


rosdep: bionic: [ruby, ruby-dev] in 'rosdistro/ruby.yaml'

Added ruby and ruby-dev  for ubuntu: bionic.

Closing and reopening to try to trigger travis

Good catch @mikaelarguedas There's still overlap on some of the others but we can let that be for now as too many dependencies is not the end of the world.


Black images with ASI178MC and RPI3

Hi Thomas,
Thanks a lot for creating this project for all of us!
I have an issue with an ASI178MC, RPI3 and a 2.5A power source - all the images are black. There is no text displayed, just a black image. I have tried swapping the power source (running with an official RPI power source), reinstalling the project, changing USB ports, image size, location, but no matter what I do, all I can see is a black frame.
Here are my settings:
Capture Settings:
Image Type: ASI_IMG_RGB24
Resolution: 3096x2080
Quality: 50
Exposure: 100ms
Max Exposure: 1000ms
Auto Exposure: 0
Gain: 50
Max Gain: 200
Auto Gain: 0
Brightness: 50
Gamma: 50
WB Red: 53
WB Blue: 90
Binning: 1
Delay: 10ms
Daytime Delay: 5000ms
USB Speed: 50
Text Overlay: text
Text Position: 15px left, 35px top
Font Name:  0
Font Color: 255 , 255, 255
Font Line Type: 16
Font Size: 0.7
Font Line: 1
Flip Image: 0
Filename: image.jpg
Latitude: 55.8N
Longitude: 4.2W
Preview: 0
Time: 1
Darkframe: 0
Many thanks,
Alex

Hi Thomas,
Thanks a lot for this, it looks like this was the issue! Everyday learning something new :)
Cheers,
Alex


Bump to use Vue 2.0.

Most official vuejs-templates already have a 2.0 PR ready. I think we can merge them as soon as new vue-cli is released with support to specify a branch on official templates.
Now I'm mostly familiar with browserify and simpler templates :) I know you @chrisvfritz have a gist on how to update this template to work with 2.0.
Before merging 2.0 PR, please create and push branch named 1.0 from current ... um, dist branch. What's up with master here? :)

@zigomir I'm happy to take care of this. Since this is the most-used template, I think it might also be helpful to display a little message reminding people that this is Vue 2.0, with a link to the 2.0 docs and instructions for using the 1.0 template instead. Beyond that, is there anything else you can think of beyond just making the minimal updates to things working?

No, not really. You mean Vue 2.0 docs or webpack-template specific 2.0 docs?
Please see this PR: https://github.com/vuejs-templates/webpack/pull/225. Minimal(istic) note about version is already there.

Ah, got it - sorry for missing that.

... um, dist branch. What's up with master here? :)

+1 What is the logic behind this naming scheme?

I'm confused, I switched to the 2.0 branch and followed the instructions in the Readme, and it installs 1.0.21. I'm guessing the Readme hasn't been updated.
Is there a way to install 2.0 (and all related scaffolding) using Vue-cli?

Ah, vue init webpack#2.0 my-project.

@niallobrien yes :) and that's because 2.0 isn't merged yet. See https://github.com/vuejs-templates/webpack/pull/225

Thanks @zigomir

the default branch now uses Vue 2.0, so we can close this I think :)


Add contributor

Please add @bizob2828 as a contributor. He's the lead engineer on my team at New Relic, and it would be helpful if he could fill-in when I am not available. Case and point:

https://github.com/nodejs/import-in-the-middle/pull/155#issuecomment-2379524329
https://github.com/nodejs/import-in-the-middle/pull/155#issuecomment-2382884492

🤷♂

@bengl is listed as the maintainer of the import-in-the-middle-maintainers team, so I guess he could add to it.

@bizob2828 can click the "Request to join" button in the top right of the team linked above and I guess that will go so someone 🤷♂

@bizob2828 can click the "Request to join" button in the top right of the team linked above and I guess that will go so someone 🤷♂

Sure. I'll give that a shot

I don't have permissions to view that

It seems the Node.js org is been locked down for billing issue. I am going to raise a ticket.

Invitation sent. Feel free to close the issue once @bizob2828 accepts the invite.

Thank you everyone.


feat: work in live preview

The changes can now take effect on the live preview or source code，like this：

I have completed this feature, but I don't like to display the title, I have added a switch to control whether the title is displayed @grempa
If the code block has a title, it will be displayed like this：

Thank you - like it ;)

Is there anything specific that's blocking this?


sampleset.to_serializable to check variable indices

when using to_serializable, seems like it doesn't check the type of variable indices.
if np.int64 is sent it as variable indices, sampleset.to_serializable() remains not bson compatible.
would be nice if we can check that and convert during the process

Can you provide a failing example?

from dwave.system import DWaveSampler

sampler = DWaveSampler()
qubit_indices = np.arange(0,8)
h = {q:1 for q in qubit_indices}
r = sampler.sample_ising(h,{},num_reads = 5)
serialized = r.to_serializable()
try:
    bson.BSON.encode(serialized)
except Exception as e:
    print(e)

Returns
cannot encode object: 0, of type: <class 'numpy.int64'>

Got it. I thought you were referring to the irow, icol.
I do agree that BQM.to_serializable should make sure that the variable labels are in a serializable form.  Which does make this a bug!


[Chore]: Backfill tests for the /v3/builds endpoint

Background
There are no api e2e test for this endpoint
Action to take
Write tests for:

GET /v3/build/{guid}

Impact
We are confident that the build handler works as expected
Dev Notes
No response

Closing this chore as we now have e2e tests for GET /v3/builds/(guid) https://github.com/cloudfoundry/korifi/blob/791b30ffa3d846ae87ece7526ad9d6de4b954de4/tests/e2e/builds_test.go#L32-L51


Go to a specific page

Hi
Its good to have a new feature to go to a specific page . Thanks

+1

+1

+100


docs: improve useCopyToClipboard demo

You're right, currently, the copy function never throws a error. But maybe instead of updating the doc, we should fix the hook to make the copy function "throwable" instead of returning a boolean. This way, we do have not to update the eslint rule and the hook's API will be more natural for JS dev.
What do you think about?

Agree with you!
In fact, I prefer to throw an error if copy to clipboard was failed.
Don't forget to tell the user if we do the breaking change. In particular, users who don't use TypeScript may not be aware that the return value of the copy function has changed from Promise<boolean> to Promise<void>.

Please feel free to close this PR

Thank you for the quick response.
I will keep this PR open until we update the hook as a reminder.


VNC keyboard layout

Feature enhancement request:
It would be great if a user will be able to update the "VNC Keyboard Layout" option.

This is planned to be added as part of user settings feature, please see: #1088


output pvalue instead of binarized pvalues

Hi, I've just noticed that the values in pvalues.txt are binary, according to the cutoff set at the command line when running the job. What would one need to change in order to have the real values in order to plot dot size ~ -log(pval) as in the classic sample plots: https://www.nature.com/articles/s41596-020-0292-x/figures/3
Thanks!

Nevermind, I seem to have been mistaken.


Replace online default Route template with standard one

Please describe the task that needs to be done
When opening Kaoto's online version for the first time, we use the test template as an entry point:

The goal for this ticket is to remove the usage of said template so users can see the "New Route" button instead

This is where we get the default value from: https://github.com/KaotoIO/kaoto/blob/5e02ff2140c31677e32cf9b351fb76e2489b1537/packages/ui/src/layout/Shell.tsx#L27


Update Metrics and Flags for GPU

This PR includes the following changes:

Adds flags used for GPU training and GPU scripts (multiprocess flags, option to overwrite TFDS data dir, option to log compile times)
Adds some additional logging (log compile times, log e2e time, add seqs_per_sec metric)
Fixes logging for gradient accumulation such that reported loss and throughput reflects that of a full batch rather than a subbatch

Including all of the above changes in a single PR to avoid merge conflicts from multiple PRs

@ashors1 can you split train.py changes into another PR? just to make this PR smaller and easier to merge


Do not show announcement banner if announcement contents are empty

Also add documentation about updating and removing announcement banners.
Closes #1695

ignoring codecov upload failures, which should be fixed by #1717
thanks @melissawm!


range部分能添加区间选择的功能吗

Mint UI version
Device model

Reproduction Link

What is Expected?
What is actually happening?

感谢建议，后续会考虑实现


AppServicesHeartbeatTelemetryModule is not initialized properly if TelemetryConfiguration.Active is not set

If you are reporting bug/issue, please provide detailed Repro instructions.
Repro Steps

Create AppServicesHeartbeatTelemetryModule
Create new TelemtryConfiguration
Initialize heartbeat module with the new configuration

Actual Behavior
no heartbeats reported. The module tries to find IHeartbeatPropertyManager in static singleton TelemetryModules.Instance.
The latter is set up by TelemetryConfiguration.Active invocation.
Expected Behavior
heartbeats work
We should make heartbeats initialized explicitly without static singletons as any other component.
If it's not possible - heartbeat modules should touch Active config/do other precautions to make sure they will start properly

@TimothyMothra This can be closed now, right?

Liudmila's repro is still valid.
The Module Initialize method only takes a TelemetryConfiguration which itself doesn't have a reference to a TelemetryModules collection. So the Module still has to look at the TelemetryModules.Instance singleton to find Heartbeat.
We exposed a IHeartbeatPropertyManager property so it can be manually set now.

Got it. This issue is only for those folks who hand create the modules.
Since we provide correct solution for Asp.Net, Asp.Net Core, Console/Worker - I feel this issue can be closed.

I'm okay with that.


Update GCE images to use Docker 1.8.2

Need to update here: https://github.com/weaveworks/weave/blob/master/test/gce.sh#L68, generate a new image, and then update here: https://github.com/weaveworks/weave/blob/master/test/gce.sh#L14

This is needed to fix https://github.com/weaveworks/weave/issues/1437

generate a new image

Wat.

Also we are lacking the requisite credentials I think?

I'll do it next week.  Credentials are checked in, you just need the password to decrypt them.  IM me for it.

#1467 incorporated this same change into 1.1.


Handling undefined in TESTed

See #202. Summary: TESTed doesn't support undefined, which is useful in JS.

To continue this issue: upon further reflection, I think adding undefined as an advanced type (with basic type nothing) is a better way of fixing this:

If you explicitly want undefined as a return value, you probably want None in Python and null in Java (etc.), so this will take care of that.
The expected value in the Dodona feedback will be correct (and not null).
Testing functions without return value is still supported (since this is handled in the judge itself, not in the language implementations).

Sounds good to me.


Double click with mouseDown,mouseUp,mouseDown,mouseUp

What is the reason that Puppeteer doesn't recognize this 4 commands as a double click?
I don't want to use ClickCount as I want to have control over delay between these 4 events.
The same issue for Triple click ( to select whole node text).
I think it will be useful if Puppeteer mouse have the same behavior as a real mouse have.

ClickCount doesn't send multiple clicks, it sets the "count" for each individual click. To do a double click you'd do
await page.mouse.down({clickCount: 1});
// wait however long you want here
await page.mouse.down({clickCount: 2});


CUJ Testing for Beta v2 - Creator Can View Their Stories in Grid View

Feature Description
In preparation for the Beta 2 release we would like to have validation and confirmation of the CUJ functionality detailed in
https://github.com/google/web-stories-wp/issues/1676

[x] See all their stories (Drafts plus Published)
[x]  Sort their stories (last modified, last opened, date created, author, title, etc.)
[x]  Filter their stories by All stories, Drafts and Published
[x]  See metadata such as title and status [draft, published, modified, etc]
[x]  Hover over story card to see quick animated preview of story

Verified in QA


Fix moduleTransaction domain datadecoded and blocknumber fields

Blocknumber should be number not string https://github.com/safe-global/safe-client-gateway/blob/main/src/common/models/backend/transactions.rs#L78
data_decoded should be nullable https://github.com/safe-global/safe-client-gateway/blob/main/src/common/models/backend/transactions.rs#L26

Coverage: 78.426% (+0.03%) from 78.395% when pulling 90d76778788dbf41adbf7b9b9f6bc78a6eaa39b7 on fix_some_schema_fields_module_transaction into a77cc4f3406bf0179a42f6ce10ae7f3d4350ef31 on main.


Microsoft.AspNetCore.Mvc.ViewFeatures: 2.2.0

Package Id
Microsoft.AspNetCore.Mvc.ViewFeatures
Package Version(s)
2.2.0
Additional details
The package is being shown as deprecated without any other option. If such functionalities from the package are being deprecated, where are they being transferred to? To the actual framework? To another package?
I don't see how can a package be deprecated without any reason or option for the developers that have been consuming that package.. This action is lacking the support to guarantee the continuity on the work that people have been using with package.

@Fn-M there are many such packages. You don't see their "new" versions in NuGet anymore because they've been bundled together in the AspNetCore Ref package.

https://www.nuget.org/packages/Microsoft.AspNetCore.App.Ref/8.0.6

If you download that package and check the dlls, you'll see that ViewFeatures in there:

To use these newer versions, you need to upgrade your project to newer framework targets and use the web SDK. There is no way to consume them directly in an older project (as far as I know).

Thanks! I eventually found them, but would be great if such info would be on the nuget page as well, so that people are "redirected" to the alternative version.

@Fn-M

...but would be great if such info would be on the nuget page as well, so that people are "redirected" to the alternative version.

Yep... I can agree with you there. This is definitely a bit on the cryptic side.


Full VQA-X dataset

The VQA-X google drive location contains 1000 images from val and test each. Is there any way to access the rest of the data?

The data in google drive contains only the annotations for textual and visual explanations, meaning that you will have to download the images from the official VQA website (https://visualqa.org/download.html). The 1000 npz files you are seeing are ground-truth annotations for visual pointing. Each file contains 3 heatmaps collected from humans. Due to constraints in resources, we only collected 1000 and evaluated on those.


Move multiple top-level classes in a single RemoteCacheManager.java s…

…ource file as static inner classes
Spring cleaning! Looks like an oversight.

As long as they don't need to be public, top-level seems fine to me...

@danberindei I think that placing multiple top-level classes into one file is a discouraged practice.

@rvansa is right. This practice is called "mess" officially. :-)

@rhusar That's just Jon Skeet, give me a more credible reference :P

@danberindei  ROFL I see you found my sources :)  Anyway, the way I stumbled upon this is that in IntelliJ IDEA (2017.1) double-clicking on the class file does not open the file itself but rather opens another menu listing out the top level classes defined in that file (what a PITA).

@rhusar That sounds annoying indeed... Ok, just make the classes private, and I'll integrate it.

Oops, fixed.

Integrated, thanks Rado!


Unblock the repo using our forked version

Our forked version of gogo-protobuf needs specific tagging and a process
of merging when updating the gogo-protobuf version.  More documetation
to follow on the developer wiki.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sdake
To complete the pull request process, please assign linsun
You can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

https://github.com/istio/istio/pull/15928

https://github.com/istio/tools/pull/233

https://github.com/istio/api/pull/1007

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-shellcheck-master
1890c92a3e52214346e80815875399b69cae321c
link
/test istio-shellcheck-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-shellcheck-master
1890c92a3e52214346e80815875399b69cae321c
link
/test istio-shellcheck-master

istio_auth_sds_e2e-master
1890c92a3e52214346e80815875399b69cae321c
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-shellcheck-master
1890c92a3e52214346e80815875399b69cae321c
link
/test istio-shellcheck-master

istio_auth_sds_e2e-master
1890c92a3e52214346e80815875399b69cae321c
link
/test istio_auth_sds_e2e-master

e2e-simpleTests-distroless-master
1890c92a3e52214346e80815875399b69cae321c
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
1890c92a3e52214346e80815875399b69cae321c
link
/test istio_auth_sds_e2e-master

e2e-simpleTests-distroless-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Now that unit tests have passed, can we force merge ?

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test e2e-simpleTests-distroless-master

integ-new-install-k8s-presubmit-tests-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-distroless-master

Let's wait till everything passes please...

/test integ-new-install-k8s-presubmit-tests-master

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test e2e-simpleTests-distroless-master

integ-new-install-k8s-presubmit-tests-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test integ-new-install-k8s-presubmit-tests-master

integ-mixer-k8s-presubmit-tests-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
8d65528f6b21c7fd8c51dcc29518332fefa69576
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


remove cath in my info because server intercept some error before

Remove catch because server intercept some database error

Pull Request Test Coverage Report for Build 80

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.3%) to 100.0%

Totals

Change from base Build 78:
4.3%

Covered Lines:
39

Relevant Lines:
39

💛  - Coveralls


EDA - Categorical/Continuous relationships

Add ggplot/matplotlib/plotnine examples to the base R example of boxplots.

Fixed as of https://github.com/srvanderplas/unl-stat850/commit/f47a2752255108fb2eb863d8400922823095e72c


[core] force symbol hiding for ecal_core(_c).so.

Description

Related issues

Cherry-pick to

Ah, good luck with this. I had a crack at something like this earlier this year but had trouble with the difference in how MSVC vs gcc/clang handles exporting the run time type info for classes.
https://github.com/DownerCase/ecal/commit/1003c3d07bc03f59c7c2f63aa5850b58f1f42348
Pulling from the CI logs this looks like it  was undefined reference to typeinfo for eCAL::CServiceClient'.
So for gcc, the classes must be marked with a default visibility attribute.
However, MSVC won't let you mark the entire class and specific functions.
I found this as a useful reference, as it's the same problem: https://github.com/PixarAnimationStudios/OpenUSD/issues/665
So I believe the two options would be to:

Introduce a new macro as suggested in the above linked issue
Mark the problematic classes with ECALC_API and remove the per-function specifying.

Hope my rambling was at least remotely helpful! 😅

Hi @DownerCase, yes you summed up the problem pretty nicely.
Not sure which one will be the "better" approach. If I do export the whole class on both Unix and Windows, using std::shared_ptr as private member for pimpl will give warnings, so I'd have to move that back to raw pointers, which I don't like.
So I'll probably go with different macros, making the whole class visible on Unix only.


Update ergoCub1_wiring doc files

Fixing images.

Hi @LoreMoretti
This repo contains the source code underlying our website. Hence, you should consult the documentation through the website, which correctly shows the images:

https://icub-tech-iit.github.io/documentation/ergoCub1_wiring/ergoCub1_0/
https://icub-tech-iit.github.io/documentation/ergoCub1_wiring/ergoCub1_1/
https://icub-tech-iit.github.io/documentation/ergoCub1_wiring/ergoCub1_2/

Indeed, mkdocs doesn't follow tightly the rules of markdown for image locations. It's tricky but that's it 😃


fix: Clean up shape folders and remove unrecoverable shapes

Followup to https://github.com/electric-sql/electric/pull/2049
We are currently leaving folders behind when deleting shapes, which do take up a little bit of space and eventually could be a bit of an issue. This PR takes care of removing everything.
Additionally, when a shape fails to recover by not being able to start the consumer at all (see CubDB issue), the shape data is removed using a new method called unsafe_cleanup! which simply rm -rfs the shape directory. Not great to use while the shape is active as it can cause various bugs, but great for cleaning up.

@magnetised it wouldn't be called unsafe if it was tested 🤔  (added test https://github.com/electric-sql/electric/pull/2051/commits/313729d9816ba1c1e43e20266eb154ab8b712a1f)


Make review url pull request comment multi line

Thank you for contributing!/nPreview these changes: http://laps.run-preview.s3-website-us-east-1.amazonaws.com/new-review-comment-msg//nExpires: Tue Sep 25 05:05:37 UTC 2018 (above link will no longer work)/nNote: it may take a moment for the branch to deploy. Check all pending travis builds have completed

Thank you for contributing!/r/nPreview these changes: http://laps.run-preview.s3-website-us-east-1.amazonaws.com/new-review-comment-msg//n/nExpires: Tue Sep 25 05:08:58 UTC 2018 (above link will no longer work)/nNote: it may take a moment for the branch to deploy. Check all pending travis builds have completed

Thank you for contributing!/r/nPreview these changes: http://laps.run-preview.s3-website-us-east-1.amazonaws.com/new-review-comment-msg//n/nExpires: Tue Sep 25 05:11:42 UTC 2018 (above link will no longer work)Note: it may take a moment for the branch to deploy. Check all pending travis builds have completed

Thank you for contributing!Preview these changes: http://laps.run-preview.s3-website-us-east-1.amazonaws.com/new-review-comment-msg/Expires: Tue Sep 25 05:14:33 UTC 2018 (above link will no longer work)Note: it may take a moment for the branch to deploy. Check all pending travis builds have completed

Thank you for contributing!Preview linktes: http://laps.run-preview.s3-website-us-east-1.amazonaws.com/new-review-comment-msg/Link expires: Tue Sep 25 05:28:55 UTC 2018Note: it may take a moment for the branch to deploy. Check all pending travis builds have completed

Thank you for contributing!Preview these changesLink expires: Tue Sep 25 05:33:41 UTC 2018Note: it may take a moment for the branch to deploy. Check all pending travis builds have completed


feat: add native token gateway to the LST pool in Arbitrum Sepolia

Changes

Added native token gateway to the LST pool in Arbitrum Sepolia

Looks good: I was able to supply ETH to the WETH market. Let's just not merge this PR until it can use a production version of the @venusprotocol/isolated-pools package.


Prepare Changelog for 1.2.2

Thank you for contributing! Please check the following things before submiting your PR:
Required:

[x] I have read and followed the contributing guidelines

If necessary:

[ ] I have updated the README and documentation.
[x] I have updated the ChangeLog with the changes I have made.

Will be merged once 1.2.2 has been released. Hopefully I won't forget to set the release data this time...

Closes #

Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

....Thanks for merging this without even asking if it is ready. Jesus man, show patience and ASK first, because as it was mentioned in the comment will I need to update the Release date first.

I'm so sorry I misread it I guess. I must have asked you. Shouldn't have hurried so much.
Bro, this won't be happening again.
I'll revert the commit.
Sorry again!

No need to revert now. What's done is done.

No need to revert now. What's done is done.

I just wanna say I'm sorry for hurrying.
I hope there are no hard feelings

It's fine.
But I think we should set a rule that a PR is only mergable if the author gave his OK to it... Or maybe always keep them as drafts until they are ready to then turn into ready.

It's fine.
But I think we should set a rule that a PR is only mergeable if the author gave his OK to it... Or maybe always keep them as drafts until they are ready to then turn into ready.

Yeah. You are right. We'll apply both of those rules next time onwards.


[JBallerina] Tuple access not supported in BIR

Description:
Tuple access is not implemented in BIR gen.
Steps to reproduce:
Try building a .bal file with the following snippet to JVM target.
(int,int) kk = (100,200);
 int kl = kk[0];

Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

This is now supported in jballerina


Skip some code and leave it unchanged

My scenario:
I want to use browserify to create a bundled version of the code I want to run on a webpage. I want to use closure-compiler to minify the created bundle.
In general this works beautifully, but this time I have some code dependency that comes in a minified black-box package and I can't get the original source of that. In theory it shouldn't cause a problem to minify an already minified code - but there's no reason to risk anything. Doing so will sooner or later lead to weird errors that no one can locate or fix.
So let's assume I have this minified "long line of code"...
function xyz() {blabla();this.is.doing.alotofstuff();1==4&&gettingmoreunreadable().....}

in the middle of my bundled code.
Is there any way to skip that blob of code and leave it unchanged? Something like /* jshint ignore:start */ ... /* jshint ignore:end */ for the closure compiler?
I've been trying to find a solution, but that seems to be a missing feature.

Nothing that I know of can skip a blob of code.
Can you somehow extract that minified code into its own .js file?

That would be my current solution - actually concatenating the files after minification. It wouldn't be my preferred one, though, because it adds an additional build step.

If the already-minified code is compatible with the optimization mode you are using, then it should be fine to run it through the compiler.
Did you get warnings / errors from that blob of code?

I tried and it seemed to be fine in my test. I'm just not sure if that's a risk I'm willing to take in the long run.

Then you're stuck with another build step. Skipping sections isn't something the compiler can do.


CONTRIBUTING.md: discourage nitpicking

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/satisfaction-survey-from-the-new-rfc-166-formatting/49758/42

See also https://github.com/NixOS/nixpkgs/issues/315337#issuecomment-2138800269

We could enumerate a list of non-blockers, they are plentiful, but I'm not sure if that section is the correct place.

Sorry for the delay, I've been traveling. :airplane:
I adapted @SomeoneSerge's second suggestion. I would love to get "value judgement" and "nitpick" into there for the sake of grep-ability, but the current change I believe most can agree on.


Setup Docker

Currently the project requires postgres and will soon require redis. Setting the development environment is getting more complicated as more 3rd party software is required. We can solve this by using docker containers.

Looking forward to this one! 💯


How do you control browser being used by Azure File Sync during registration process

Browser which pops up during registration is not supported by my company. I assume it's using outdated version of control. How do you control this to allow to proceed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61bb35a5-e2f3-1ce8-1d6e-a926374de6c8
Version Independent ID: e4b3065a-5351-26ef-cdbb-ef2eaea3f301
Content: Deploy Azure File Sync
Content Source: articles/storage/files/storage-sync-files-deployment-guide.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@artisticcheese Thanks for your question. We are checking on this and will respond to you soon.

@artisticcheese  I'd recommend posting your question in https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=windowsazuredata since it's not directly related to the documentation. We'll follow up there.
Please share the complete details of the issue and also share the screenshot.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


bug: Navigation issue in sidemenu starter project

Type: bug
Platform: all
I am using the latest version of Ionic (v1.0.1) to create a sidemenu starter project. Unfortunately I found an annoying issue in this "standard" template.

Create a sidemenu starter project
$ ionic start myApp sidemenu

Run this project. You will see Playlists page by default. Please don't do anything... just open side menu by swiping.

Tap on Playlists from side menu. (I know Playlists was opened already) Side menu disappears and Playlists page will appear again.

Tap on any item, for example, Dubstep.

You will be redirected to single playlist page. But you won't see Back button in navigation bar, as if navigation history was cleared. In this case, Back button should appear because new page (Dubstep) is pushed to navigation stack.

Navigation system and back button works well when Playlists page is opened only once via side menu.  And it's actually killing me.

It seems this issue is actual in some newer versions of Ionic, but I found this doesn't happen in v1.0.0-beta.14

I also found this bug, and I temporarily add this for bugfix:
angular.module('starter.controllers', [])
.controller('MenuCtrl', function($scope, $ionicModal, $timeout, $rootScope, $ionicHistory) {
$rootScope.$on('$ionicSideMenuClose', function (e, side) {
if (side == 'left') {
$timeout(function () {
$ionicHistory.nextViewOptions({
historyRoot: false,
disableAnimate: false,
expire: null
});
}, 100);
}
});
});

Thanks for your response, @gotojmp.  It worked.  However, I am actually planning create a pretty complicated project. I am afraid this hack will cause some unexpected troubles in my project. Is there any other official fixes or releases for this?

I have same problem in my production project  =(

If in your project menu-close with href, like in ionic-starter-sidemenu <ion-item menu-close href="#/app/playlists">, this fix for menuClose directive:
IonicModule
.directive('menuClose', ['$ionicHistory', function($ionicHistory) {
  return {
    restrict: 'AC',
    link: function($scope, $element, $attr) {
      $element.bind('click', function() {
        var sideMenuCtrl = $element.inheritedData('$ionSideMenusController');
        if (sideMenuCtrl) {

          var currentView = $ionicHistory.currentView();
          var currentViewUrl = "#" + currentView.url;
          if($attr.href !==  currentViewUrl) {
            $ionicHistory.nextViewOptions({
              historyRoot: true,
              disableAnimate: true,
              expire: 300
            });
          }

          sideMenuCtrl.close();
        }
      });
    }
  };
}]);

But this check href of current view, will not fix  <ion-item menu-close ng-click="login()">

Closing as a duplicate of #4132


Refactor get tag to remove unnecessary steps

This PR removed some unnecessary codes from getTag and also fix a bug related with tagCache. A not about that:
Lightweight git tags may point to the same commit.

Codecov Report

Merging #14058 (023f723) into master (4ef7512) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #14058      +/-   ##
==========================================
- Coverage   42.32%   42.29%   -0.04%
==========================================
  Files         726      726
  Lines       77684    77677       -7
==========================================
- Hits        32883    32852      -31
- Misses      39403    39435      +32
+ Partials     5398     5390       -8

Impacted Files
Coverage Δ

modules/git/repo_tag.go
59.54% <75.00%> (+0.84%)
:arrow_up:

modules/git/error.go
25.42% <0.00%> (-28.82%)
:arrow_down:

modules/git/repo_base_nogogit.go
63.63% <0.00%> (-9.10%)
:arrow_down:

modules/git/repo.go
39.41% <0.00%> (-4.12%)
:arrow_down:

modules/log/event.go
58.96% <0.00%> (-2.84%)
:arrow_down:

modules/git/utils.go
77.77% <0.00%> (-2.78%)
:arrow_down:

modules/git/blame.go
65.71% <0.00%> (-1.43%)
:arrow_down:

services/pull/pull.go
40.14% <0.00%> (-1.24%)
:arrow_down:

modules/indexer/stats/db.go
48.00% <0.00%> (ø)

models/error.go
38.98% <0.00%> (+0.48%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aabbac...023f723. Read the comment docs.


Releasing an ingredient in the cooking pot can produce an error

[ERROR] gamemodes/supercookingpanic/entities/weapons/scookp_arms.lua:109: Calling net.Start with unpooled message name! [ http://goo.gl/qcx0y ]
  1. Start - [C]:-1
   2. DropIngredientAnim - gamemodes/supercookingpanic/entities/weapons/scookp_arms.lua:109
    3. GrabIngredient - gamemodes/supercookingpanic/entities/weapons/scookp_arms.lua:73
     4. unknown - gamemodes/supercookingpanic/entities/weapons/scookp_arms.lua:30

Further information might be needed.

It's because of a dependency you don't have in your game.

I'll try to add checks to fix the error.


Is there a way to query the parametric constants for a tone curve?

We can query the tone curve type using the cmsGetToneCurveParametricType function. Is there an equivalent way to access the parametric constants for a cmsToneCurve struct? If not, how practical is implementing such a feature in the API?

Actually there is no function to do that, but I think it would be quite easy, something like:
cmsFloat64Number*  cmsGetToneCurveParams(const cmsToneCurve* t)
{
_cmsAssert(t != NULL);
if (t -> nSegments != 1) return NULL;
return t ->Segments[0].Params;

}
I will add this to the development sources, thanks for the idea!

Included in 2.11

Thank you!


[FEATURE] mechanism to reload data on session context change

Description
The original issue can be found in Slack here
In our case, we need to reload product price data when customer logins/logout, because we have different pricing for customer groups. Currently there is no easy way to do so, because there is no co-relation between product data and session on presentation layer. As @mkucmus said, we need some mechanism to reload data on context change (customer login/logout, language, currency change, etc)
Use Case
Possibility to reload data on session context change.
Proposed Solution
No response
Alternatives Considered
No response
Additional Context
No response

I have some thoughts about this issue:
Languages:
We must re-fetch almost everything when changing languages because most pages are based on CMS. So in this case better solution is to reload the page than re-fetching content. We should split this issue in to 2 different tasks, one for language second for price/currency.
Prices/currency:
Do we know how many shops using the Frontends app will have a multi-pricing solution? If the percentage of usage is small, maybe it should be resolved via module not as a core function?

Speaking about demo-template - we can refresh it by default. This is still possible for people to change this behaviour and invoke data fetching instead.
How is that relevant to multi-pricing? The more modular it will be the better, for sure not every project will use it, but if someone will it would be good to have is just as "additional composable you can use"

What's the plan to solve this? Long time no progress.
Will we add an Example and some Documentation?


Get rid of the globals

Not liking the layout of some of the bits, may need a bit of work.
Tests also need to be done, to make sure it all works properly,

Tests all fine. Can't think of anything else to pull out, without making the script any more messy than it currently is.


Include the validations options

Won't be merged, since the :required option for the has_enumeration_for method already achieves the same goal.


Change composer update to install

I don’t see why you would want to run ‘composer update’ after a merge, but ‘composer install’ makes sense.

This is just an example though, so it doesn't quite matter. But you're right. Thanks


MauiMaps Android removed pin still appears on map

When I attempt to remove pin on MauiMaps Android, removed pin still appears on map.
I noticed in Android CustomMapHandler Markers is never is set to anything.
I added the following lines to AddPins() after the check for null at start of methos:
       if (Markers == null)             Markers = new List<Marker>();
Then the pin gets removed from map as expected.
Another issue I see and dont understand is the Action finished method for ImageSource.LoadImage appears to be called 4 times for each ImageSource.LoadImage () request. I examined Markers after adding a pin and there are 4 new Marker entries for an added pin.
I am using the latest version on the repository and Microsoft Visual Studio Community 2022 (64-bit) - Preview
Version 17.6.0 Preview 2.0

AddPins is only called in MapPins. in MapPins I clear all markers:
https://github.com/VladislavAntonyuk/MauiSamples/blob/0efbfec1590e630b626ddbe26d85832dc617b6e5/MauiMaps/Platforms/Android/CustomMapHandler.cs#L40
LoadImage is called and the app continues running. Then in the background image is loading and when ready the Action callback is executed. The marker may appear in a few seconds after you added Pin, depending on the image source (e.g. load image from the internet with low speed)

I think I determined what was happening and made the following changes to CustomMapHandler. Just rely on the Google map. The Markers List is not needed.
In MapPins() : remove mapHandler.Markers.Clear();
In AddPins() : add Map.Clear(); before foreach (var pin in mapPins)
In AddMarker(: remove markers?.Add(marker);

Using the Map.Clear() also prevents the GoogleMap markers from accumulating when adding/deleting pins since these are never cleared otherwise.

Why do you say they never cleaned if they actually do? On sample app click Add and Remove multiple times to see that pins disappear.
Once again markers collection represents pins collection. If you remove pin you remove marker. If you remove marker it will be remove from map.

Maybe we are running different versions of Maui. I use Microsoft Visual Studio Community 2022 (64-bit) - Preview Version 17.6.0 Preview 2.0.
I created a new app.: MauiMaps. I copied your code to this new app. I added the same nugets as your sample.
I run this app. I Added 2 new pins. I now have 4 pins displayed on map.  I Removed 2 pins. There are still 4 pins displayed. Whenever a pin is added, it is added to Markers and Map.AddMarker. When I remove a pin, mapHandler.Markers.Clear(); is called. This clears the local Marker collection, and then adds the map.pins. However what clears the GoogleMap collection?
I see the same result when I compile and run your MauiMaps sample as is.

Ok, I will double check it tomorrow

You are right.
Replace handler.Markers.Clear with
foreach (var marker in mapHandler.Markers)
{
marker.Remove();
}

Updated sample


Relationship fixes - Fix on Sync Pivot

Hi @pxpm!
Instead of messing with your PR of the relationship fixes, I'll add small PRs for you to review and merge if you wish.
This is pointed to the relationship-fixes PR.
So this is the first, it's regarding a Sync Pivot improvement.
It was inside the loop, and could be outside.
I also added another test to that function.

Going to close this @promatik you were right here! I'v just refactored in my branch so I am closing this one.
Thanks 👍

Heads-up @pxpm - the PR was pointing to relationship-fixes so I believe you could have merged it directly. Unless you "refactored" it in the sense that you did the same thing but differently in which case I'll shut up 😀😀

@pxpm I checked the main branch https://github.com/Laravel-Backpack/CRUD/pull/3410 and it doesn't have this fix.
This fixes an issue with syncPivot method, it also adds another test to that method.
I'll reopen this one, please let me know ✌
Btw, along with https://github.com/Laravel-Backpack/CRUD/pull/3601, there is the https://github.com/Laravel-Backpack/CRUD/pull/3610 both pointing to the same branch relationship-fixes.


Downloading files takes too long

There is an issue with using Requests' iter_content function. Even when not enabling streams, it only seems to download 1b at a time. Eventually update to a higher download speed.

A temporary solution proposed is the following:

Define a constant CHUNK_SIZE in Config that defines the chunk size for the entire program.
Assign the chunk size to all functions that download from the repos (update and fetch).

The main issue appears to be some inconsistency in how Requests handles stream-based downloads with chunk sizes. By default, when streaming, the chunk size is 1b, which is ridiculously small. By raising the chunk size, it seems to attempt to download the full packages at once, breaking the status display.
Currently no other options have been proposed, and the above temporary solution has been rejected (for now) as it suffers from a couple problems:

By assigning an upper limit, the download functions will not make full use of the end-user's network. Requests should throttle itself if the user's network isn't good enough, but would otherwise only download at the maximum possible speed. Alternatively, setting the chunk size too high will skip streaming and free the status display.

The final proposed chunk size, for the aforementioned solution, was 500 bytes, which when tested equated to approximately 1.5MiB/s on the development machine.

Having compared this against Pacman on Arch, it appears that the Pacman solution is to set a specific download speed that it will always try to match.
While this program is meant to be accurate to Pkg's behaviour, I haven't been able to verify what limits, if any, Pkg has. I may, possibly temporarily, apply the Pacman download limit, which I'd need to check again but may be ~512KiB/s.


Ramble for R Linting

From email:

Hello Chapman,
Really enjoyed reading about Ramble, and thought it'd be an interesting way to delint R code
One R linting problem I was thinking about  is how one might use Ramble to replace '=' in R code, with '<-' but not in function args, '<=', '==' , ">=" etc?
Best Regards,
Ed Lee
(github: edlee123)

I think you should use a proper linter for this like https://github.com/jimhester/lintr
If you do want to roll your own, I guess it would look something like the attached which sort of works.
library(Ramble)
library(purrr)
library(magrittr)

combine_list <- function(x, y="") {
  return(paste0(unlist(x), collapse=y))
}

using_rest <- function(p, f) {
  #return (f(p(string)))
  return(function(string) {
    f(p(string))
  })
}

`%using_rest%` <- using_rest

#' usage:
#' var_name("hello")
#' var_name("1_2") # not a valid name
#' var_name("1asdf") # not a valid name
var_name <- ((Alpha() %then%
                many(AlphaNum() %alt% String("_"))) %using%
               combine_list)

#' usage:
#'
#' equal_assingment("x = 2")
#' equal_assingment("add(x = 2)")
equal_assignment <- maybe((token(var_name) %then% symbol("=")) %using%
                       function(x) {
                         x[[2]] <- "<-"
                         x <- combine_list(x, " ")
                         return(x)
                       })

#' equal_assingment("x = 2") %>% combine_rest
combine_rest <- function(x) {
  paste(x$result, x$leftover, collapse=" ")
}

#' expr("x=2")
#' expr("add(x=2)")
expr <- equal_assignment %using_rest% combine_rest

Awesome thank you Chapman, that's pretty cool


Move all actions and filters from Options class to wrapper functions

Alternative solution to #3682

@RavanH thanks for your submission - I'm unable at the moment to take time to look into these, but I will :)


[MATIO 1.5.6] testsuite fails with hdf5 error

I don't know what changed, it was working before.
testsuite.log

What do you mean by "it was working before."? Which version exactly?

And which version of libhdf5 do you use? The HDF5 errors should not be there at all. It's all about them.

The same matio version.

hdf5:     1.8.16-0

Maybe it has to do with the HDF5 filter plugins. Check section 4.4 of https://www.hdfgroup.org/HDF5/doc/Advanced/DynamicallyLoadedFilters/HDF5DynamicallyLoadedFilters.pdf and what your hdf5 config header / env var has set for as filter directory.

Ah, is the test error reproducable?

Yes

Thank you. Looks like my hdf5 is built without zlib.

Feel free to close this out. It appears related to an issue building HDF5 where zlib was not getting picked up during the build. Correcting that issue appears to have resolved this one.


Do we stick with centos or make the move to an ubuntu world?

In the case of docker containers I think it will be easier to set them up as ubuntu containers overall. As far as a machine hosting the containers, I could go either way, but probably lean toward centos docker container hosts. Thoughts?

I like CentOS. I use Ubuntu only when the application is developed in ubuntu (ie. qiime). I'm will to do ubuntu, but like Centos.


Fix dependency check for long chains

Say that:

mod A depends on mod B;
mod B depends on mod C.

If mod C is disabled or not present, mod B is not loaded.
But mod A is loaded and that's a problem.
This patch makes sure the whole chain is not loaded.

Added in SuperBLT by BangL: !13.


Add stake_cw721 and cw721-controllers

Adds the ability to stake Cw721 Tokens. Allows for staked Nft use cases.

Codecov Report

Merging #309 (b6e7062) into main (608ad08) will decrease coverage by 0.63%.
The diff coverage is 91.26%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   96.70%   96.06%   -0.64%
==========================================
  Files          36       39       +3
  Lines        8041     9106    +1065
==========================================
+ Hits         7776     8748     +972
- Misses        265      358      +93

Impacted Files
Coverage Δ

contracts/stake-cw721/src/hooks.rs
44.44% <44.44%> (ø)

contracts/stake-cw721/src/contract.rs
90.71% <90.71%> (ø)

packages/cw721-controllers/src/nft_claim.rs
98.37% <98.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608ad08...b6e7062. Read the comment docs.


Implement parser and syntax errors

I'm not super happy about the current state of this code because I felt like I was fighting against parser-gen's and lpeglabel's APIs to get them to work with each other. In particular:

The API for setting error labels in those two libraries is incompatible, so it is hard to use an lpeglabel lexer inside a parser-gen parser. If only lpeglabel allowed arbitrary Lua values as labels...
I'm not sure I really understand how the "%" (subparser) operator works in parser-gen. From the experiments I made, it seemed that the SKIP and error recovery from the subparser can leak into the parent parser, which is weird. The patterns that parser-gen creates also need to be executed with parser-gen.parse and will error-out if you call the match method on them so I am not sure if it is even correct to treat them as patterns.

Anyway, I'm submitting this PR so we can have a place to discuss these problems and because I wanted to get this stuff out of the way so I can can focus on the rest of the compiler for now. I guess we could wait until we figure out a more permanent solution for those lpeg and parser-gen issues before merging this.

I believe @sqmedeiros is the ideal person to give feedback on this. I'm sure he will appreciate seeing the libraries being put through their paces in this realistic scenario.

Anyway, I'm submitting this PR so we can have a place to discuss these problems and because I wanted to get this stuff out of the way so I can can focus on the rest of the compiler for now. I guess we could wait until we figure out a more permanent solution for those lpeg and parser-gen issues before merging this.

Fully agreed! We can revisit this more calmly (and even propose changes to lpeglabel/parser-gen?) after the workshop. We only need syntax-error-free programs for demoing anyway. :)

Hi, everybody.
My main idea when I proposed parser-gen was to make easy to describe a vanilla parser, so a user does not need to worry with some things, such as the matching of whitespaces. At first, I did not imagine that parser-gen would be used together with lpeglabel, so we unfortunately did not pay attention to the integration between both tools.
Fabio already told me that parser-gen has a bug related to error recovery, but I think we are still not dealing with this. But as parser-gen is not mature yet Hugo may have found another bug.
I saw that Hugo open an issue in the lpeglabel repository, but I did not have time this week to look it.
When Fabio added me to Titan, I was planning to write a parser with some error recovery mechanism. As the initial Titan parser was written using parser-gen, my initial schedule was:

Fix parser-gen bugs
Review the API of LPegLabel and adapt parser-gen
Write the Titan parser hopefully using parser-gen

This probably will not be done until the Lua Workshop.
Next week I have more time, so I can help with any issues related to the parser.

@sqmedeiros Sounds like a great plan! We just need a barebones parser for the workshop prototype. A full-fledged parser with nice error recovery would be a great addition later, and it's something that can be done in parallel as the other guys move on to the type checker and code generator.


Week 1 Review Ticket

Individual GitHub pages (3 points)
Jekyll Page

[x] GitHub page for Test Prep study, requiring 5.3, 5.4 notes and actions( See "GitHub pages actions" at the bottom of each TPT page on cspcoders).
[x] GitHub page that documents key learnings and code snippets using GitHub and replit.
[x] InfoDB lists
[x] InfoDB loops
[x] Fibonacci - (For Fibonacci(n)  print complete list 0 - n  and not just the nth term)

Score: 3/3

[ ] 1- One Check 5.3 - had notes and action answers for 5.3 and 5.4 in github Jekyll; clear to follow format with the table!
[ ] 1- One Check 5.4 - had notes and action answers for 5.3 and 5.4 in github Jekyll; clear to follow format with the table!
[ ] 1 - One Check for New Data, minimum of 4 items - added 4 elements inside the infoDB list
[ ] 1- One Check For Loop running and sensible output - for loop produces correct output in repl runtime
[ ] 1- One Check While Loop running and sensible output - while loop produces correct output in repl runtime
[ ] 1- One Check Recursion running and sensible output - recursion produces correct output in repl runtime
[ ] 4- Four checks: Algorithm, code with comments, Prints result, Prints Complete List, - fibonacci recursive algorithm, has comments, prints results in new line using a list
[ ] 1- One check: comments and documentation throughout - has appropriate comments to explain fibonacci code