CodeReviewID appears twice and upload fails with "contains duplicate item"

Describe the bug
Using the default scorecard.yaml on a private repo with a PAT.
# This workflow uses actions that are not certified by GitHub. They are provided
# by a third-party and are governed by separate terms of service, privacy
# policy, and support documentation.

name: Scorecard supply-chain security
on:
  # For Branch-Protection check. Only the default branch is supported. See
  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection
  branch_protection_rule:
  # To guarantee Maintained check is occasionally updated. See
  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained
  schedule:
    - cron: '45 7 * * 5'
  push:
    branches: [ "main" ]

# Declare default permissions as read only.
permissions: read-all

jobs:
  analysis:
    name: Scorecard analysis
    runs-on: ubuntu-latest
    permissions:
      # Needed to upload the results to code-scanning dashboard.
      security-events: write
      # Needed to publish results and get a badge (see publish_results below).
      id-token: write
      # Needed because installing in a private repository.
      contents: read
      actions: read
      # To allow GraphQL ListCommits to work
      issues: read
      pull-requests: read
      # To detect SAST tools
      checks: read

    steps:
      - name: "Checkout code"
        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
        with:
          persist-credentials: false

      - name: "Run analysis"
        uses: ossf/scorecard-action@e38b1902ae4f44df626f11ba0734b14fb91f8f86 # v2.1.2
        with:
          results_file: results.sarif
          results_format: sarif
          repo_token: ${{ secrets.SCORECARD_TOKEN }}
          # For private repositories, `publish_results` will always be set to `false`, regardless
          # of the value entered here.
          publish_results: false

      # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
      # format to the repository Actions tab.
      - name: "Upload artifact"
        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
        with:
          name: SARIF file
          path: results.sarif
          retention-days: 5

      # Upload the results to GitHub's code scanning dashboard.
      - name: "Upload to code-scanning"
        uses: github/codeql-action/upload-sarif@17573ee1cc1b9d061760f3a006fc4aac4f944fd5 # v2.2.4
        with:
          sarif_file: results.sarif

The last step, Upload to cosde-scanning, is failing with
Error: Unable to upload "results.sarif" as it is not valid SARIF:
- instance.runs[2].tool.driver.rules contains duplicate item
Error: Unable to upload "results.sarif" as it is not valid SARIF:
- instance.runs[2].tool.driver.rules contains duplicate item
    at validateSarifFileSchema (/home/runner/work/_actions/github/codeql-action/17573ee1cc1b9d061760f3a006fc4aac4f944fd5/lib/upload-lib.js:193:15)
    at uploadFiles (/home/runner/work/_actions/github/codeql-action/17573ee1cc1b9d061760f3a006fc4aac4f944fd5/lib/upload-lib.js:242:9)
    at Object.uploadFromActions (/home/runner/work/_actions/github/codeql-action/17573ee1cc1b9d061760f3a006fc4aac4f944fd5/lib/upload-lib.js:136:18)
    at async run (/home/runner/work/_actions/github/codeql-action/17573ee1cc1b9d061760f3a006fc4aac4f944fd5/lib/upload-sarif-action.js:48:30)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/17573ee1cc1b9d061760f3a006fc4aac4f944fd5/lib/upload-sarif-action.js:70:9)

Looking at the output printed right above, this item is appearing twice:
 {
        "id": "CodeReviewID",
        "name": "Code-Review",
        "helpUri": "https://github.com/ossf/scorecard/blob/376f465c111c39c6a5ad7408e8896cd790cb5219/docs/checks.md#code-review",
        "shortDescription": {
          "text": "Code-Review"
        },
        "fullDescription": {
          "text": "Determines if the project requires code review before pull requests (aka merge requests) are merged."
        },
        "help": {
          "text": "Determines if the project requires code review before pull requests (aka merge requests) are merged.",
          "markdown": "**Remediation (click \"Show more\" below)**:\n\n- If the project has only one contributor, or does not have enough reviewers to practically require that all contributions be reviewed, try to recruit more maintainers to the project who will be willing to review others' work. Ideally at least some of these people will be from different organizations (see [Contributors](checks.md#contributors)). If the project has very limited utility, consider expanding its intended utility so more people will be interested in improving it, and make that larger scope clear to potential contributors.\n\n- Follow security best practices by performing strict code reviews for every new pull request / merge request.\n\n- Make \"code reviews\" mandatory in your repository configuration. ([Instructions for GitHub.](https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-pull-request-reviews-before-merging))\n\n- Enforce the rule for administrators / code owners as well. ([Instructions for GitHub.](https://docs.github.com/en/github/administering-a-repository/about-protected-branches#include-administrators))\n\n\n\n**Severity**: High\n\n\n\n**Details**:\n\nRisk: `High` (unintentional vulnerabilities or possible injection of malicious\n\ncode)\n\n\n\nThis check determines whether the project requires code review before pull\n\nrequests (merge requests) are merged.\n\n\n\nReviews detect various unintentional problems, including vulnerabilities that\n\ncan be fixed immediately before they are merged, which improves the quality of\n\nthe code. Reviews may also detect or deter an attacker trying to insert\n\nmalicious code (either as a malicious contributor or as an attacker who has\n\nsubverted a contributor's account), because a reviewer might detect the\n\nsubversion.\n\n\n\nThe check first tries to detect whether [Branch-Protection](checks.md#branch-protection) is enabled on the\n\ndefault branch with at least one required reviewer. If this fails, the check\n\ndetermines whether the most recent (~30) commits have a Github-approved review\n\nor if the merger is different from the committer (implicit review). It also\n\nperforms a similar check for reviews using\n\n[Prow](https://github.com/kubernetes/test-infra/tree/master/prow#readme) (labels\n\n\"lgtm\" or \"approved\") and [Gerrit](https://www.gerritcodereview.com/) (\"Reviewed-on\" and \"Reviewed-by\").\n\n\n\nNote: Requiring reviews for all changes is infeasible for some projects, such as\n\nthose with only one active participant. Even a project with multiple active\n\ncontributors may not have enough active participation to be able to require\n\nreview of all proposed changes. Projects with a small number of active\n\nparticipants instead sometimes aim for a review of a\n\npercentage of proposals (e.g., \"at least half of all proposed changes are\n\nreviewed\").\n\n\n\nRequiring review does not eliminate all risks. The other reviewers might fail to\n\nnotice unintentional vulnerabilities or malicious code, be colluding with a\n\nmalicious developer, or even be the same person (using a \"[sock\n\npuppet](https://en.wikipedia.org/wiki/Sock_puppet_account)\" account).\n\n"
        },
        "defaultConfiguration": {
          "level": "error"
        },
        "properties": {
          "precision": "high",
          "problem.severity": "error",
          "security-severity": "7.0",
          "tags": [
            "supply-chain",
            "security",
            "source-code",
            "code-reviews"
          ]
        }
      },

Currently I have no workaround. Branch protection is enabled on our repo, and we are requiring code review with minimum one reviewer.

This was fixed in v2.1.3 (latest version is v2.3.1 though!), here's the original issue for more details #1094

Using the default scorecard.yaml

I assume you mean the starter workflow, we will likely need to send an update with a version bump.
https://github.com/actions/starter-workflows/blob/main/code-scanning/scorecard.yml
@ossf/scorecard-maintainers we need to decide if we're ok not hash pinning these starter workflows. Maybe leave a comment recommending the pinning?

Thanks so much for the quick reply, I can verify that bumping to 2.3.1 fixes this.
Sorry for not testing with the latest version, I kinda assumed the starter workflow would use that.


[B16] Everful Urn can't fill vanilla Cauldron

Probably an unnecessary feature that probably requires special handling, but idk. Fits with the fluff and maybe someone builds a weird redstone clock with it by measuring the Cauldron with a comparator.

This issue was moved to Azanor/thaumcraft-suggestions#347


[tlul,rtl] Modify readback check error reporting logic

Currently, only a readback error check is reported when the error_i signal is not raised. However, as this signal is also raised when there is no activity on the TL-UL bus, we might miss some readback failures.
This commit modifies the error reporting logic to also report the readback mismatch when the error signal is raised.
Closes #24698.

CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_sram_byte.sv
This is a confirmed ECO which is okay.

CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_sram_byte.sv
Confirmed ECO.

CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_sram_byte.sv
Confirmed ECO.


About the RMSE and Type Error Rate Values

Hello,
I am somewhat puzzled as to why the RMSE and Type Error Rate for different models in your paper, EasyTPP, appear so close to each other, yet there are quite noticeable differences in their respective papers.

Hi,
The numbers are indeed close based on what we have implemented... so we conclude that there is no consistent winners across the datasets ..


Security Issue

Hi, I have found a high risk security issue within this application. Who do I contact to reasonably disclose this?

You could post it directly here.

This is critical in nature and sensitive, I would prefer a method of private conversation if possible.

Hi @120318, I'm necro'ing this issue as I haven't received any private contact details.
The vulnerability lies within the https://github.com/Mosasauroidea/GazellePW/blob/main/app/API/ImgUpload.php API functionality. Fundamentally, this allows for the arbitrary upload of any file extension (including .php), and returns the uploaded path. It is quite trivial to obtain RCE through this.
While this requires an API key, there also exists a stored XSS vulnerability within the mouse over avatar functionality. Simply include a payload such as <script>alert(1)</script> and mouse over the user's avatar for the XSS to pop. This could be used to retrieve a users API key from their settings page.


Fix axes labels not displayed bug

This PR should close #182.

It fixes the bug that makes axes labels not visible when the plot is made for the first time before resizing the widget.
It changes saved figure's background to white from transparent one.
It adds a scrollbar to the plotter widget.
It adds constrained_layout=True when creating the figure, which is a solver that adjusts axes sizes.

I would appreciate some testing on laptops with different display settings @zoccoler @haesleinhuepf
E.g. here is how it would look like when the widget is put to the top of napari:

Note to self: review

Thanks a lot @marabuuu!
I now also added the minimum width of the widget, could you please test how it opens the widget now?
On my laptop, it opens the widget even bigger size than the set minimum (not so squished as on yours) but does not allow the widget to be smaller than the defined size. I set it now as 400 px but not sure if it's the optimal value.

I tried it out @lazigu and my problem is that when I try to open the Plotter Widget I get the following error message:
File c:\users\maral\documents\github\napari-clusters-plotter\napari_clusters_plotter\_plotter.py:190, in PlotterWidget.__init__(self=<napari_clusters_plotter._plotter.PlotterWidget object>, napari_viewer=Viewer(axes=Axes(visible=False, labels=True, col...._transform_active_layer at 0x0000017805460670>}))
    188 self.layout.addWidget(axes_container, alignment=Qt.AlignTop)
    189 self.layout.addWidget(cluster_container, alignment=Qt.AlignTop)
--> 190 self.layout().addWidget(self.advanced_options_container)
        self.layout = <PyQt5.QtWidgets.QVBoxLayout object at 0x0000017828675550>
        self.advanced_options_container = <superqt.collapsible._collapsible.QCollapsible object at 0x000001781E65D9D0>
        self = <napari_clusters_plotter._plotter.PlotterWidget object at 0x00000178215AE820>
    191 self.layout.addWidget(update_container, alignment=Qt.AlignTop)
    192 self.layout.addWidget(run_container, alignment=Qt.AlignTop)

TypeError: 'QVBoxLayout' object is not callable

Whops it was branches merging bug that I missed. Now it should be fixed. Thanks, @marabuuu for catching it!

Marcelo, thanks a lot for changes here, they really make sense!!
Btw we have tox file but we are not running tests with tox, you would have to edit this file https://github.com/BiAPoL/napari-clusters-plotter/blob/main/.github/workflows/test_and_deploy.yml
But I thought I would just wait till PR in napari-skimage-regionprops is merged :)

Hi Laura @lazigu ,
I was about to write you here to explain these small changes but you got me first 😆
Yep, I had forgotten about this fact the we do not use tox, I was experimenting hehe
I agree that fixing it in napari-skimage-regionprops will solve it now.
About the changes, they are mostly for some standardization purposes, I did not bring any new fixes. I have tested and everything seems to be working properly. Also, tests pass locally for me.
Also, good idea using constrained_layout! It seems the best way to do it. :)
All good from my side, thanks for implementing this!


Bug damage% ball ligthning in damage and ...

Shoot a ball of lightning that electrocutes enemies along its for 300% weapon damage as Lightning.
Damage calculator ...  Skill multiplier is 150% not 300%???

It actually does 150% damage every 0.7 seconds, the tooltip is misleading.


Sample wanted for square/wire

About the library

Description:    gRPC and protocol buffers for Android, Kotlin, and Java.
GitHub: https://github.com/square/wire
Official website: https://square.github.io/wire/

What the sample could do
Re-use the Dinosaur sample from the documentation
Wants to contribute the sample?

Say so in a comment here
Follow instructions in CONTRIBUTING.md
Submit your pull request!

I'm currently trying out the library, but I'm unable to import wire's gradle plugin to the project. I tried to add the following in build.gradle.kts file
plugins {
id 'application'
id 'org.jetbrains.kotlin.jvm'
id 'com.squareup.wire'
}
wire {
kotlin {
}
}
I get the error: Plugin [id: 'com.squareup.wire'] was not found in any of the following sources:

@sijanr
One get this error when no plugin version is set
add manually to versions.properties this:
plugin.com.squareup.wire=3.4.0

Should I assign the issue to you?

Yes, that'd be great. Thanks!

I get the same error even after setting the plugin version, .
I added plugin.com.squareup.wire=3.4.0 to the version.properties file
In build.gradle.kts, I added:
plugin {
id("com.squareup.wire")
}
wire {
kotlin{
out "${buildDir}/generate"
}
}

It's because the wire plugin is not on the Gradle Plugins portal. You need to add gradlePluginPortal() mavenCentral() in the repos in the pluginManagement in the settings.gradle.kts file.

The build is successful, but I'm unable to add the following in the build.gradle.kts
wire {
kotlin {
}
}
I don't think I can generate the kotlin class of the proto file without adding the above code.
Since applying the plugin directly in the build.gradle.pluginManagement {
repositories {
gradlePluginPortal()
mavenCentral()
}
}kts wasn't working for me, I added plugin.com.squareup.wire=3.4.0 in the version.properties file.
I also added implementation ("com.squareup.wire:wire-runtime:3.4.0") to the dependencies in the build.gradle.kts file
Following your advice, I added
pluginManagement {
repositories {
gradlePluginPortal()
mavenCentral()
}
}
to the settings.gradle.kts file. Is there anything that I did wrong?

Can you push your code and open a pull request in its present state? I will try to fix it

@sijanr pluginManagement is meant for the settings.gradle.ktd file.

Also, please use triple backticks for code snippets.
Like this

This is what I've been able to get so far. You'll probably see a bunch of errors in the gradle build file, but it all clears out if you remove
wire {
          kotlin {}
}

I also deleted the below code from the build.gradle.kts file because I just kept on receiving an error asking me remove it.
tasks.register("run", JavaExec::class.java) {
    this.main = "playground._mainKt"
}

ok, thanks!


GvimExt: Use UTF-8 for gettext

Closes #12431

Use bind_textdomain_codeset() to use UTF-8.
Set to UTF-8 before using _(), and restore to original encoding after using it.
Use Wide functions to handle the menu strings. (ANSI functions are still used in other part.)
Fix size checking in CShellExt::GetCommandString(). Stop using the hard-coded size.
Adjust indentation.
Change WINVER for Windows 7.

@k-takata Great!


Carousel component, set interval / no interval

Hi @ArgoZhang ,
I am using the Carousel and ImageViewer components and would like the following features to extend the Carousel component.

A flag to stop the 'automatic interval' so the user has to select the image next/previous

Can the ImageViewer component be made 'like' the Caroursel component so that you can cycle through images, I like that the image viewer can 'zoom' into an array of images, it would be a really nice extension to allow it to act like a Carousel component and cycle through the images used for the zoom
Many thanks
Patrick

@pomeara sure. I plan to achieve this function in the next milestone

@pomeara the bootstrap carousel update some new feature in v5.2.0. I will integrade them. include the Stop Pause etc feature


Held items does not actas rigid bodies

There are move_and_slide for kinematics but then we would need to convert the rigids back and forth


Replace os.system("python ...") with subprocess.check_call([sys.executable, ...])

The cli.lab uses os.system() to run sub processes. The use of os.system is problematic for two major reasons:

The call does not raise an exception if a sub process fails. The main program just continues to run.
The function requires a properly shell-escaped argument. If the argument is not correctly escaped for the user's current shell, then the command can fail in all sorts of funny ways, e.g. with space or non-ASCII directory name.

I highly recommend to replace any use of os.system() with subprocess.check_call()
Instead of
cmd = f"{script} --gguf {gguf_model_path} --repo {tokenizer_dir} --mlx-path {dest_model_dir}"
os.system("python {}".format(cmd))

do
subprocess.check_call([sys.executable, script, "--gguf", gguf_model_path, "--repo", tokenizer_dir, "--mlx-path", dest_model_dir])

check_call() checks the exit status of a command and fails with an exception if the program fails.

This issue is obsolete due to https://github.com/instructlab/instructlab/issues/438


cannot build wheel

Hi,
When following the installation instructions and calling python -m build, I get the following error:
...
* Building wheel...
running bdist_wheel
running build
running build_py
Traceback (most recent call last):
  File "C:\Users\User\ProjectPath\venv\lib\site-packages\pep517\in_process\_in_process.py",
line 349, in <module>
    main()
  File "C:\Users\User\ProjectPath\venv\lib\site-packages\pep517\in_process\_in_process.py",
line 331, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "C:\Users\User\ProjectPath\venv\lib\site-packages\pep517\in_process\_in_process.py",
line 248, in build_wheel
    return _build_backend().build_wheel(wheel_directory, config_settings,
  File "C:\Users\User\AppData\Local\Temp\build-env-lkyfb7qt\lib\site-packages\setuptools\build_meta.py", line 221
, in build_wheel
    return self._build_with_temp_dir(['bdist_wheel'], '.whl',
  File "C:\Users\User\AppData\Local\Temp\build-env-lkyfb7qt\lib\site-packages\setuptools\build_meta.py", line 207
, in _build_with_temp_dir
    self.run_setup()
  File "C:\Users\User\AppData\Local\Temp\build-env-lkyfb7qt\lib\site-packages\setuptools\build_meta.py", line 150
, in run_setup
    exec(compile(code, __file__, 'exec'), locals())
  File "setup.py", line 53, in <module>
    setup(
  File "C:\Users\User\AppData\Local\Temp\build-env-lkyfb7qt\lib\site-packages\setuptools\__init__.py", line 153,
in setup
    return distutils.core.setup(**attrs)
  File "C:\Program Files\Python39\lib\distutils\core.py", line 148, in setup
    dist.run_commands()
  File "C:\Program Files\Python39\lib\distutils\dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "C:\Program Files\Python39\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "C:\Users\User\AppData\Local\Temp\build-env-lkyfb7qt\lib\site-packages\wheel\bdist_wheel.py", line 299, in
 run
    self.run_command('build')
  File "C:\Program Files\Python39\lib\distutils\cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "C:\Program Files\Python39\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "C:\Program Files\Python39\lib\distutils\command\build.py", line 135, in run
    self.run_command(cmd_name)
  File "C:\Program Files\Python39\lib\distutils\cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "C:\Program Files\Python39\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "setup.py", line 23, in run
    subprocess.run([os.path.join(project_root, 'mvnw'), 'clean', 'install'], cwd=project_root, check=True)
  File "C:\Program Files\Python39\lib\ntpath.py", line 78, in join
    path = os.fspath(path)
TypeError: expected str, bytes or os.PathLike object, not NoneType

ERROR Backend subproccess exited when trying to invoke build_wheel

Probably caused by https://github.com/optapy/optapy/blob/fab133deed98e57a644ddcdd85806cef67bcc845/optapy-core/setup.py#L20 , which is probably undefined in Windows. I'll rewrite it to support Windows build.

Fixed by #16


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/51202

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/51207

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/53667

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/65465


Fixes crash in queries that timeout

Fixes #347.
In an ideal case I add a unit test for this as well, but sadly this is rather involved.
cc @trasch.

Codecov Report

Merging #351 (590cd5d) into main (1516e0c) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   41.20%   41.12%   -0.09%
==========================================
  Files         117      117
  Lines        9657     9654       -3
==========================================
- Hits         3979     3970       -9
- Misses       5678     5684       +6

Impacted Files
Coverage Δ

...urces/PostgresNIO/New/PostgresChannelHandler.swift
61.93% <0.00%> (-0.14%)
:arrow_down:

... and 10 files with indirect coverage changes


create new releases

hello in reolata and a question but I did not know where to write it.
I would like to create the release with the command "dotnet publish" is it possible? or some alternative

This doesn't seem like a question about this extension.

actually i would like an option to load on "relase" and create the actual tag, with the name of the release.
if the "dontnet publish" command is used, a request to create the new version in github should come out if possible


Workaround for controller recognized as keyboard

Similar like the workaround for mouses but this time for gaming controller.
Using Fedora 37 here with a Dualsense 5 controller, this PR lets it appear as gaming device instead of as a keyboard.
PS: Thanks for your cool extension!

Thank you:-)


Process PrintableString and UTF8String ASN.1 types

Hey. Thanks. Can you provide tests for the new types?


service files

Once the immediate problems are solved: There's also User=... instead of using sudo -u.


robotframework-uds: setup basic infrastructure

robotframework-uds:
add infrastructure for setup.py, documentation and release_info
Originally posted by @test-fullautomation in https://github.com/test-fullautomation/robotframework-uds/pull/2#pullrequestreview-2229625765

Done with https://github.com/test-fullautomation/robotframework-uds/pull/6


Ammo desync issues on multiplayer

Pasted error for copy/paste-ability: SCRIPT ERROR: _on_collect: Invalid call. Nonexistent function 'update_weapons' in base 'Nil'.
At: res://entities/collectables/arrow.gdc:5
OS:
Windows 10
Issue description:
Ammo does not seem to spawn the same for each player. When a player picks up an item they can't see, but another can, the error above appears.
Steps to reproduce:
Have at least 2 players connect to a server.
Player 2 cuts grass until Player 1 sees an item.
When Player 2 picks the item up, Player 1 receives the error.

Will fix this, unsure exactly what causes this. Happens in 3.2.3 and 3.3.2.

Interesting discovery: even if the item spawns for both players, this error still appears.

All is fixed except for when entering a room.

I made a comment on a different issue, but this is the issue I meant @fornclake and I will tackle by a backport feature in TetraScript.


fix: add dev feature in error message to generate test vectors

@joshieDo @rakita may I have a quick review on this please? I think this will help people understand how to generate the vectors :)


[opentitanlib] Find out the meaning of CDCE906 related constants

Any idea what these constants mean?
If yes, can we add them as impl-level constants and refer to them by Self::CONSTANT_NAME?
If no, can we leave a TODO to learn their meanings?
Originally posted by @cfrantz in https://github.com/lowRISC/opentitan/pull/12870#discussion_r882052240

Data sheet: https://www.ti.com/lit/gpn/cdce906


Feature/cplp 714 edit bpn field

Hi Martin,
Okay will clone the new repo and do the changes
From: Martin Rohrmeier @.>
Sent: Wednesday, April 6, 2022 9:51 PM
To: tractusx-team-portal-onboarding/tractusx @.>
Cc: Garg Nidhi, @.) @.>; Author @.***>
Subject: Re: [tractusx-team-portal-onboarding/tractusx] Feature/cplp 714 edit bpn field (PR #292)
Sent from outside the BMW organization - be CAUTIOUS, particularly with links and attachments.
Absender außerhalb der BMW Organisation - Bitte VORSICHT beim Öffnen von Links und Anhängen.

@oyo requested changes on this pull request.
Hey Nidhi, yesterday I moved the company-portal to the new repository location. Can you please clone the project from the new repo at
https://github.com/catenax-ng/product-portal-frontend-registration
and apply the changes there to the file:
https://github.com/catenax-ng/product-portal-frontend-registration/blob/main/src/components/cax-companyData.tsx
From now on we should not work on the tractusx-team-portal-onboarding/tractusx repo any more.
—
Reply to this email directly, view it on GitHubhttps://github.com/tractusx-team-portal-onboarding/tractusx/pull/292#pullrequestreview-933765187, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYE7SMFAP5HZOMOAYT5TL5LVDW2W7ANCNFSM5SVVU5SA.
You are receiving this because you authored the thread.Message ID: @.***>

@nidhigarg-bmw does that mean we can close this PR here without merging as you are applying those changes to the new repo manually now?

Hi Nobert,
Are you talking about the PR which I created yesterday for old company-portal ? If yes then yes there is no need to merge I made the changes in new repo.
From: Norbert Truchsess @.>
Sent: Thursday, April 7, 2022 2:58 PM
To: tractusx-team-portal-onboarding/tractusx @.>
Cc: Garg Nidhi, @.) @.>; Mention @.***>
Subject: Re: [tractusx-team-portal-onboarding/tractusx] Feature/cplp 714 edit bpn field (PR #292)
Sent from outside the BMW organization - be CAUTIOUS, particularly with links and attachments.
Absender außerhalb der BMW Organisation - Bitte VORSICHT beim Öffnen von Links und Anhängen.

@nidhigarg-bmwhttps://github.com/nidhigarg-bmw does that mean we can close this PR here without merging as you are applying those changes to the new repo manually now?
—
Reply to this email directly, view it on GitHubhttps://github.com/tractusx-team-portal-onboarding/tractusx/pull/292#issuecomment-1091420905, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYE7SMG5SKMGV2A45UHCMZLVD2TAHANCNFSM5SVVU5SA.
You are receiving this because you were mentioned.Message ID: @.***>


Build error when using it with nuxt 3

I installed this package in my nuxt 3 (v3.13.2) but after building and serving the site I am getting this error:
[nuxt] [request error] [unhandled] [500] fluid is not a function
  at ./.output/server/chunks/build/server.mjs:10284:13
  at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
  at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
  at async ./.output/server/chunks/routes/renderer.mjs:149:24
  at async ./.output/server/chunks/routes/renderer.mjs:240:64
  at async Object.handler (./.output/server/chunks/routes/renderer.mjs:20:22)
  at async Object.handler (./.output/server/chunks/runtime.mjs:3167:19)
  at async Server.toNodeHandle (./.output/server/chunks/runtime.mjs:3438:7)

in my tailwind.config.js:
import fluid, { extract, screens } from 'fluid-tailwind'
  plugins: [
    fluid({
      checkSC144: false,
    }),
  ],

When I run yarn dev it works as expected. Any idea why and how to solve this issue?

Hi, are you using @nuxtjs/tailwindcss?

Also got a build error, now after upgrading to nuxt 3.14.0
I'm using Nuxt UI
[unhandledRejection] Cannot read properties of undefined (reading 'prefix')                      2:46:37 PM

  at extract (node_modules/fluid-tailwind/dist/index.js:15430:43)
  at node_modules/@nuxtjs/tailwindcss/dist/module.mjs:135:18
  at _defu (node_modules/defu/dist/defu.mjs:31:19)
  at _defu (node_modules/defu/dist/defu.mjs:37:21)
  at node_modules/defu/dist/defu.mjs:52:33
  at Array.reduce (<anonymous>)
  at node_modules/defu/dist/defu.mjs:52:16
  at configMerger (node_modules/@nuxtjs/tailwindcss/dist/module.mjs:138:5)
  at configs.reduce.configMerger.content.files (node_modules/@nuxtjs/tailwindcss/dist/module.mjs:249:23)
  at Array.reduce (<anonymous>)

got it when running npm run dev.

@motion-work I can't reproduce this locally on Nuxt 3.13.2. Would you be able to provide a reproduction?


Decorates are replacing each other

What version of Elysia.JS is running?
1.0.23
What platform is your computer?
Linux 6.5.0-35-generic x86_64 x86_64
What steps can reproduce the bug?

I ended up putting the controllers for each route into groups, the user and url controllers both have the /create route.
For some reason, when I call /user/create, Elysia is running the service from the /url/create route
What is the expected behavior?
No response
What do you see instead?
No response
Additional information
No response

@vitorpldev, can you please post code snippets in text form? checkout Creating and highlighting code blocks

Okay, the code I gave as an example is this:
import Elysia, { t } from "elysia";

const user_decorator = (application: Elysia) => {
  return application.decorate({
    services: {
      find: (name: string) => `The name of user is ${name}`,
    },
  });
};

const url_decorator = (application: Elysia) => {
  return application.decorate({
    services: {
      find: (url: string) => `The url is ${url}`,
    },
  });
};

const user_controller = (application: Elysia) => {
  return application.use(user_decorator).get(
    "/",
    ({ query, services }) => {
      return new Response(services.find(query.value), { status: 200 });
    },
    {
      query: t.Object({ value: t.String() }),
    }
  );
};

const url_controller = (application: Elysia) => {
  return application.use(url_decorator).get(
    "/",
    ({ query, services }) => {
      return new Response(services.find(query.value), { status: 200 });
    },
    {
      query: t.Object({ value: t.String() }),
    }
  );
};

const controller = (application: Elysia) => {
  return application
    .group("/user", (user) => {
      return user.use(user_controller);
    })
    .group("/url", (url) => {
      return url.use(url_controller);
    });
};

const app = new Elysia().use(controller);

app.listen({ hostname: "localhost", port: 3030 }, (server) => {
  console.log(`Server is running at ${server.url}`);
});

If in this code I make a request for GET
for http://localhost:3030/user/ passing the value "Elysia" in the query, the expected would be "The name of user is Elysia", but the result is "The url is Elysia".
This is because the way in controllers I am grouping the url_controller after the user_controller, the decorate of the url_controller is replacing the decorate of the user_controller

@vitorpldev
Both user_decorator and url_decorator is decorating same services, I think it's expected to get overridden.
You can either

Use different name to decorate instead of services like user_services and url_services
If you want to keep it as it is, you might consider using derive instead as you can define the scopes

@vitorpldev Both user_decorator and url_decorator is decorating same services, I think it's expected to get overridden.
You can either

Use different name to decorate instead of services like user_services and url_services
If you want to keep it as it is, you might consider using derive instead as you can define the scopes

So, if you try to do this using services with different names, you will notice that the same problem occurs.
Unfortunately the problem is not the declaration of the services name in different decorates.

Perfect, thank you my friend.


Update llbuild CMake directions

I had to pass -DCMAKE_OSX_ARCHITECTURES=x86_64 today to get the build to work, the error was pretty vague but I think it must be related to macOS on arm64

@swift-ci test

Sounds good!


Property 'accuracyAuthorization' not found on object of type 'CLLocationManager *'

Error building ios
"Property 'accuracyAuthorization' not found on object of"
react-native-permissions "version": "3.0.0",
expo  "version": "37.0.12",
pod file
platform :ios, '12.0'
project 'app.xcodeproj'
require_relative '../node_modules/react-native-unimodules/cocoapods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
$ReactNativeMapboxGLIOSVersion = '~> 6.1'
target 'app' do
rnPrefix = "../node_modules/react-native"
permissions_path = '../node_modules/react-native-permissions/ios'
React Native and its dependencies
pod 'FBLazyVector', :path => "#{rnPrefix}/Libraries/FBLazyVector"
pod 'FBReactNativeSpec', :path => "#{rnPrefix}/Libraries/FBReactNativeSpec"
pod 'RCTRequired', :path => "#{rnPrefix}/Libraries/RCTRequired"
pod 'RCTTypeSafety', :path => "#{rnPrefix}/Libraries/TypeSafety"
pod 'React', :path => "#{rnPrefix}/"
pod 'React-Core', :path => "#{rnPrefix}/"
pod 'React-CoreModules', :path => "#{rnPrefix}/React/CoreModules"
pod 'React-RCTActionSheet', :path => "#{rnPrefix}/Libraries/ActionSheetIOS"
pod 'React-RCTAnimation', :path => "#{rnPrefix}/Libraries/NativeAnimation"
pod 'React-RCTBlob', :path => "#{rnPrefix}/Libraries/Blob"
pod 'React-RCTImage', :path => "#{rnPrefix}/Libraries/Image"
pod 'React-RCTLinking', :path => "#{rnPrefix}/Libraries/LinkingIOS"
pod 'React-RCTNetwork', :path => "#{rnPrefix}/Libraries/Network"
pod 'React-RCTSettings', :path => "#{rnPrefix}/Libraries/Settings"
pod 'React-RCTText', :path => "#{rnPrefix}/Libraries/Text"
pod 'React-RCTVibration', :path => "#{rnPrefix}/Libraries/Vibration"
pod 'React-Core/RCTWebSocket', :path => "#{rnPrefix}/"
pod 'React-Core/DevSupport', :path => "#{rnPrefix}/"
pod 'React-cxxreact', :path => "#{rnPrefix}/ReactCommon/cxxreact"
pod 'React-jsi', :path => "#{rnPrefix}/ReactCommon/jsi"
pod 'React-jsiexecutor', :path => "#{rnPrefix}/ReactCommon/jsiexecutor"
pod 'React-jsinspector', :path => "#{rnPrefix}/ReactCommon/jsinspector"
pod 'ReactCommon/jscallinvoker', :path => "#{rnPrefix}/ReactCommon"
pod 'ReactCommon/turbomodule/core', :path => "#{rnPrefix}/ReactCommon"
pod 'Yoga', :path => "#{rnPrefix}/ReactCommon/yoga"
pod 'DoubleConversion', :podspec => "#{rnPrefix}/third-party-podspecs/DoubleConversion.podspec"
pod 'glog', :podspec => "#{rnPrefix}/third-party-podspecs/glog.podspec"
pod 'Folly', :podspec => "#{rnPrefix}/third-party-podspecs/Folly.podspec"
permissions
pod 'Permission-Camera', :path => "#{permissions_path}/Camera"
pod 'Permission-LocationAccuracy', :path => "#{permissions_path}/LocationAccuracy"
pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse"
pod 'Permission-PhotoLibrary', :path => "#{permissions_path}/PhotoLibrary"
Automatically detect installed unimodules
use_unimodules!
react-native-cli autolinking
use_native_modules!
end

Be sure you are using the latest Xcode version with the latest iOS SDK


FPGA: webhook deployment fails with "TLS certificate file is not set" error

Steps to reproduce:
> k create -f https://github.com/jetstack/cert-manager/releases/download/v1.0.0/cert-manager.yaml
customresourcedefinition.apiextensions.k8s.io/certificaterequests.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/certificates.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/challenges.acme.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/clusterissuers.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/issuers.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/orders.acme.cert-manager.io created
namespace/cert-manager created
serviceaccount/cert-manager-cainjector created
serviceaccount/cert-manager created
serviceaccount/cert-manager-webhook created
clusterrole.rbac.authorization.k8s.io/cert-manager-cainjector created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-issuers created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-clusterissuers created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-certificates created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-orders created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-challenges created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-ingress-shim created
clusterrole.rbac.authorization.k8s.io/cert-manager-view created
clusterrole.rbac.authorization.k8s.io/cert-manager-edit created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-cainjector created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-issuers created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-clusterissuers created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-certificates created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-orders created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-challenges created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-ingress-shim created
role.rbac.authorization.k8s.io/cert-manager-cainjector:leaderelection created
role.rbac.authorization.k8s.io/cert-manager:leaderelection created
role.rbac.authorization.k8s.io/cert-manager-webhook:dynamic-serving created
rolebinding.rbac.authorization.k8s.io/cert-manager-cainjector:leaderelection created
rolebinding.rbac.authorization.k8s.io/cert-manager:leaderelection created
rolebinding.rbac.authorization.k8s.io/cert-manager-webhook:dynamic-serving created
service/cert-manager created
service/cert-manager-webhook created
deployment.apps/cert-manager-cainjector created
deployment.apps/cert-manager created
deployment.apps/cert-manager-webhook created
mutatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook created
validatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook created

> k get pods -A
NAMESPACE      NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager   cert-manager-b599fdb8f-ghrgb               1/1     Running   0          10s
cert-manager   cert-manager-cainjector-5df66c9c94-6xrm9   1/1     Running   0          10s
cert-manager   cert-manager-webhook-679cf5c9f9-rqjk8      0/1     Running   0          10s
kube-system    coredns-66bff467f8-2ngwt                   1/1     Running   0          76d
kube-system    coredns-66bff467f8-dp98f                   1/1     Running   0          76d
kube-system    etcd-r720-1                                1/1     Running   0          76d
kube-system    kube-apiserver-r720-1                      1/1     Running   0          76d
kube-system    kube-controller-manager-r720-1             1/1     Running   112        76d
kube-system    kube-proxy-5qqkh                           1/1     Running   0          76d
kube-system    kube-scheduler-r720-1                      1/1     Running   118        76d
kube-system    weave-net-8r8f9                            2/2     Running   0          76d

> k create -k https://github.com/intel/intel-device-plugins-for-kubernetes/deployments/fpga_admissionwebhook/default?ref=master
namespace/intelfpgawebhook-system created
customresourcedefinition.apiextensions.k8s.io/acceleratorfunctions.fpga.intel.com created
customresourcedefinition.apiextensions.k8s.io/fpgaregions.fpga.intel.com created
mutatingwebhookconfiguration.admissionregistration.k8s.io/intelfpgawebhook-mutating-webhook-configuration created
clusterrole.rbac.authorization.k8s.io/intelfpgawebhook-manager-role created
clusterrolebinding.rbac.authorization.k8s.io/intelfpgawebhook-manager-rolebinding created
service/intelfpgawebhook-webhook-service created
deployment.apps/intelfpgawebhook-webhook created
certificate.cert-manager.io/intelfpgawebhook-serving-cert created
issuer.cert-manager.io/intelfpgawebhook-selfsigned-issuer created

> k get pods -A |grep intelfpgawebhook
intelfpgawebhook-system   intelfpgawebhook-webhook-674bb4d5c7-p7b4m   0/1     Error     0          8s

> k logs intelfpgawebhook-webhook-674bb4d5c7-p7b4m -n intelfpgawebhook-system
F0916 10:51:53.846360       1 fpga_admissionwebhook.go:218] TLS certificate file is not set

@mythi I couldn't reproduce this with the latest release:
> k create -k https://github.com/intel/intel-device-plugins-for-kubernetes/deployments/fpga_admissionwebhook/default?ref=v0.18.0
namespace/intelfpgawebhook-system created
customresourcedefinition.apiextensions.k8s.io/acceleratorfunctions.fpga.intel.com created
customresourcedefinition.apiextensions.k8s.io/fpgaregions.fpga.intel.com created
mutatingwebhookconfiguration.admissionregistration.k8s.io/intelfpgawebhook-mutating-webhook-configuration created
clusterrole.rbac.authorization.k8s.io/intelfpgawebhook-manager-role created
clusterrolebinding.rbac.authorization.k8s.io/intelfpgawebhook-manager-rolebinding created
service/intelfpgawebhook-webhook-service created
deployment.apps/intelfpgawebhook-webhook created
certificate.cert-manager.io/intelfpgawebhook-serving-cert created
issuer.cert-manager.io/intelfpgawebhook-selfsigned-issuer created

> k get pods -A | grep fpga
intelfpgawebhook-system   intelfpgawebhook-webhook-b694c84f8-8bcz7   1/1     Running   0          4m12s

I couldn't reproduce it with the current master and cert-manager v1.0.0

make test-with-kind worked for me too

@bart0sh are the e2e tests passing for you?

@bart0sh - would you check one more time and close if not reproducible?

It is reproducible. Sometimes it works, but most of the time I can see the same error.

@mythi I didn't try to run e2e tests because webhook container doesn't run. I'm not sure it even worth trying in these conditions.

Just tried one more time. This time the webhook container was OOMKilled, but the log is the same.
Here is a full console log:
> k get pods -A
NAMESPACE     NAME                             READY   STATUS    RESTARTS   AGE
kube-system   coredns-66bff467f8-2ngwt         1/1     Running   0          82d
kube-system   coredns-66bff467f8-dp98f         1/1     Running   0          82d
kube-system   etcd-r720-1                      1/1     Running   0          82d
kube-system   kube-apiserver-r720-1            1/1     Running   0          82d
kube-system   kube-controller-manager-r720-1   1/1     Running   112        82d
kube-system   kube-proxy-5qqkh                 1/1     Running   0          82d
kube-system   kube-scheduler-r720-1            1/1     Running   118        82d
kube-system   weave-net-8r8f9                  2/2     Running   0          82d

> k create -f https://github.com/jetstack/cert-manager/releases/download/v1.0.0/cert-manager.yaml
customresourcedefinition.apiextensions.k8s.io/certificaterequests.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/certificates.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/challenges.acme.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/clusterissuers.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/issuers.cert-manager.io created
customresourcedefinition.apiextensions.k8s.io/orders.acme.cert-manager.io created
namespace/cert-manager created
serviceaccount/cert-manager-cainjector created
serviceaccount/cert-manager created
serviceaccount/cert-manager-webhook created
clusterrole.rbac.authorization.k8s.io/cert-manager-cainjector created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-issuers created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-clusterissuers created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-certificates created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-orders created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-challenges created
clusterrole.rbac.authorization.k8s.io/cert-manager-controller-ingress-shim created
clusterrole.rbac.authorization.k8s.io/cert-manager-view created
clusterrole.rbac.authorization.k8s.io/cert-manager-edit created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-cainjector created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-issuers created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-clusterissuers created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-certificates created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-orders created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-challenges created
clusterrolebinding.rbac.authorization.k8s.io/cert-manager-controller-ingress-shim created
role.rbac.authorization.k8s.io/cert-manager-cainjector:leaderelection created
role.rbac.authorization.k8s.io/cert-manager:leaderelection created
role.rbac.authorization.k8s.io/cert-manager-webhook:dynamic-serving created
rolebinding.rbac.authorization.k8s.io/cert-manager-cainjector:leaderelection created
rolebinding.rbac.authorization.k8s.io/cert-manager:leaderelection created
rolebinding.rbac.authorization.k8s.io/cert-manager-webhook:dynamic-serving created
service/cert-manager created
service/cert-manager-webhook created
deployment.apps/cert-manager-cainjector created
deployment.apps/cert-manager created
deployment.apps/cert-manager-webhook created
mutatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook created
validatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook created

> k get pods -A
NAMESPACE      NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager   cert-manager-b599fdb8f-h9gr4               1/1     Running   0          9s
cert-manager   cert-manager-cainjector-5df66c9c94-nrw4m   1/1     Running   0          9s
cert-manager   cert-manager-webhook-679cf5c9f9-sqv92      0/1     Running   0          9s
kube-system    coredns-66bff467f8-2ngwt                   1/1     Running   0          82d
kube-system    coredns-66bff467f8-dp98f                   1/1     Running   0          82d
kube-system    etcd-r720-1                                1/1     Running   0          82d
kube-system    kube-apiserver-r720-1                      1/1     Running   0          82d
kube-system    kube-controller-manager-r720-1             1/1     Running   112        82d
kube-system    kube-proxy-5qqkh                           1/1     Running   0          82d
kube-system    kube-scheduler-r720-1                      1/1     Running   118        82d
kube-system    weave-net-8r8f9                            2/2     Running   0          82d

> kubectl create -k https://github.com/intel/intel-device-plugins-for-kubernetes/deployments/fpga_admissionwebhook/default?ref=master
namespace/intelfpgawebhook-system created
customresourcedefinition.apiextensions.k8s.io/acceleratorfunctions.fpga.intel.com created
customresourcedefinition.apiextensions.k8s.io/fpgaregions.fpga.intel.com created
mutatingwebhookconfiguration.admissionregistration.k8s.io/intelfpgawebhook-mutating-webhook-configuration created
clusterrole.rbac.authorization.k8s.io/intelfpgawebhook-manager-role created
clusterrolebinding.rbac.authorization.k8s.io/intelfpgawebhook-manager-rolebinding created
service/intelfpgawebhook-webhook-service created
deployment.apps/intelfpgawebhook-webhook created
certificate.cert-manager.io/intelfpgawebhook-serving-cert created
issuer.cert-manager.io/intelfpgawebhook-selfsigned-issuer created

> k get pods -A
NAMESPACE                 NAME                                        READY   STATUS      RESTARTS   AGE
cert-manager              cert-manager-b599fdb8f-h9gr4                1/1     Running     0          100s
cert-manager              cert-manager-cainjector-5df66c9c94-nrw4m    1/1     Running     0          100s
cert-manager              cert-manager-webhook-679cf5c9f9-sqv92       1/1     Running     0          100s
intelfpgawebhook-system   intelfpgawebhook-webhook-674bb4d5c7-nskvz   0/1     OOMKilled   0          72s
kube-system               coredns-66bff467f8-2ngwt                    1/1     Running     0          82d
kube-system               coredns-66bff467f8-dp98f                    1/1     Running     0          82d
kube-system               etcd-r720-1                                 1/1     Running     0          82d
kube-system               kube-apiserver-r720-1                       1/1     Running     0          82d
kube-system               kube-controller-manager-r720-1              1/1     Running     112        82d
kube-system               kube-proxy-5qqkh                            1/1     Running     0          82d
kube-system               kube-scheduler-r720-1                       1/1     Running     118        82d
kube-system               weave-net-8r8f9                             2/2     Running     0          82d

> k logs -n intelfpgawebhook-system  intelfpgawebhook-webhook-674bb4d5c7-nskvz
F0922 10:38:36.938687       1 fpga_admissionwebhook.go:218] TLS certificate file is not set

I've never  been able to reproduce it with v0.18.0:
> kubectl apply -k https://github.com/intel/intel-device-plugins-for-kubernetes/deployments/fpga_admissionwebhook/default?ref=v0.18.0
namespace/intelfpgawebhook-system created
customresourcedefinition.apiextensions.k8s.io/acceleratorfunctions.fpga.intel.com created
customresourcedefinition.apiextensions.k8s.io/fpgaregions.fpga.intel.com created
mutatingwebhookconfiguration.admissionregistration.k8s.io/intelfpgawebhook-mutating-webhook-configuration created
clusterrole.rbac.authorization.k8s.io/intelfpgawebhook-manager-role created
clusterrolebinding.rbac.authorization.k8s.io/intelfpgawebhook-manager-rolebinding created
service/intelfpgawebhook-webhook-service created
deployment.apps/intelfpgawebhook-webhook created
certificate.cert-manager.io/intelfpgawebhook-serving-cert created
issuer.cert-manager.io/intelfpgawebhook-selfsigned-issuer created

> k get pods -A
NAMESPACE                 NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager              cert-manager-b599fdb8f-h9gr4               1/1     Running   0          8m18s
cert-manager              cert-manager-cainjector-5df66c9c94-nrw4m   1/1     Running   0          8m18s
cert-manager              cert-manager-webhook-679cf5c9f9-sqv92      1/1     Running   0          8m18s
intelfpgawebhook-system   intelfpgawebhook-webhook-b694c84f8-76v7j   1/1     Running   0          10s
kube-system               coredns-66bff467f8-2ngwt                   1/1     Running   0          82d
kube-system               coredns-66bff467f8-dp98f                   1/1     Running   0          82d
kube-system               etcd-r720-1                                1/1     Running   0          82d
kube-system               kube-apiserver-r720-1                      1/1     Running   0          82d
kube-system               kube-controller-manager-r720-1             1/1     Running   112        82d
kube-system               kube-proxy-5qqkh                           1/1     Running   0          82d
kube-system               kube-scheduler-r720-1                      1/1     Running   118        82d
kube-system               weave-net-8r8f9                            2/2     Running   0          82d

> k logs -n intelfpgawebhook-system intelfpgawebhook-webhook-b694c84f8-76v7j
I0922 10:44:55.543179       1 controller.go:91] Starting controller
I0922 10:44:55.844003       1 controller.go:109] Started controller workers

@mythi @rojkov I think it worth investigating, especially after getting OOMKilled status. You have access to the host I guess.

I can bisect it if needed.

fpga_admissionwebhook.go:218] TLS certificate file is not set

This message means that the image with the binary used in the deployment doesn't correspond the new pod spec where the TLS cert is not specified. Could you try to refresh the image?

@rojkov Thank you. Removing all our images and reinstalling webhook helped.

@bart0sh @rojkov #400 :-)
Good that it works!


Github still lists 2.6.2 as the release, but pip installs 2.7.0

What is the current version in such a case?

@surak
In order to expedite the trouble-shooting process here,Could you please fill the issue template,Thanks!

There is no proper template for issues on the repo itself. It is what is written here. The “releases” page shows 2.6.2. Pip downloads 2.7. What is the stable version?

@surak Thank  you for the quick response!
The latest stable TF version is 2.7.0 , please have a look on this link  of tested build configuration for reference.
Thanks!

Great - then, whoever administers github, please make a release.
Have a look. Go to the main page, here: https://github.com/tensorflow/tensorflow
and check on the right side, at RELEASES:

@surak @sushreebarsa
GitHub shows the latest uploaded version not the latest version of TF !!!
The last uploaded version is TF 2.6.2 because security or critical updates were done on it. Please do not mix the last activity and the latest version.
Thanks.

I know, Mark. But there’s no indication of what is the actual latest release anywhere written in a clear, unambiguous way.

@markub3327 Thank you for the response!
@surak Please have a look at https://github.com/tensorflow/tensorflow , where the latest released version of TF is 2.8.0  now.
It was showing TF 2.6.2 as latest due to some updates were done on it.
Thanks!

@surak The latest tested version of TF is (here)[https://www.tensorflow.org/install/source#tested_build_configurations] like @sushreebarsa mentioned. GitHub Releases is only informative for developers and sysadmins may look at https://www.tensorflow.org/install pages.
Thanks.

There is still no clear indication of what the current release is on the github page.

@surak GitHub shows the latest uploaded version for the recent activity not the latest version of TF. Please refer official  site of TensorFlow where stable TF version is 2.8.0 .
Thanks!

@surak
Latest and stable Tensorflow version is 2.8.0. It is updated in Tensorflow githib release notes
Take a look here

@gadagashwini thanks, but only shows the most recent version created. If an older version has a bug fix release issued, that one will come up on top.... And this is my beef here. The page the way you show seems correct now, it wasn't when I opened this issue - look at the comment above: https://github.com/tensorflow/tensorflow/issues/54237#issuecomment-1028034032

Seems nobody cares, or get it so I will close it.

This is the standard procedure for all other packages. It's not soemething that TF itself is at fault.


Missing documentation for @acset_type’s

Objects defined using the macro @acset_type are missing from the official documentation for projects that use Catlab v0.13.0.
For example, Catlab.Graphs.BasicGraphs.Graph is missing in the v0.13.3 Catlab docs but is present in the v0.12 Catlab docs.
For example, DeltaSet2D, EmbeddedDeltaSet1D, and EmbeddedDeltaSet2D are missing in the current CombinatorialSpaces.SimplicialSets docs
It should be noted that the documentation for DeltaSet1D is built correctly, even though it is simply defined as const DeltaSet1D = Graph, and Graph’s documentation is not built correctly.
I looked at the diff of simplicial_sets/index.html for the most recent build of the docs (based on 4b8db1b) and saw that DeltaSet2D was there in the previous commit, but got cut out by this commit from September 30, 2021. I believe this issue has been present since that day.

Thanks for the report. It look like the @acset_type macro is not attaching the docstring to the generated struct. It is certainly possible to do that because macros can control where docstrings attached to the macrocall go.
@olynch, do you have the bandwidth to fix this?

Closed by #594.


Failed parsing 'srcset' attribute value since it has an unknown descriptor.

Hello, I am really struggling to get this to work.
Here is how I import the script:
import picturefill from 'picturefill'
Here is my html:
<picture>

        <source srcset="/static/guy.webp" media="(min-width: 800px)" type="image/webp">
        <source srcset="/static/guy.png" media="(min-width: 800px)">

</picture>

And since I am using vue.js in the ,,mounted" (its being executed when the DOM is rendered) method i have the following:
mounted()  {
   picturefill()
},

And here is the full error which I am getting:
Failed parsing 'srcset' attribute value since it has an unknown descriptor.
Dropped srcset candidate "/static/guy.webp"

Any ideas what I am doing wrong?
Thanks!

Might this actually be the vue.js bug noted here, and nothing to do with Picturefill?

@paulroub
You should be right. Chrome does support srcset natively. So picturefill isn't doing anything here.
You can workaround this by explicitly specifying the default descriptor 1x.
This would look like this:


BasicProperties's Headers is not initialized

Is this a bug report?
Yes

Can you also reproduce the problem with the latest version?
Yes
Environment

Operating system: Win10
Visual Studio version: Rider 2020
Dotnet version:
Dotnet core 3.1

Steps to Reproduce

(Write your steps here:)

Consume some model
Run client
Paste message to rabbitmq queue input box
Click publish

Expected Behavior
TryGetHeader should return false like version 6.x
Actual Behavior
ERROR:
System.NullReferenceException: Object reference not set to an instance of an object.
at MassTransit.RabbitMqTransport.Contexts.RabbitMqHeaderProvider.TryGetHeader(String key, Object& value)
this._context.Properties.Headers is not initialized

What version are you testing with? I'm looking at the code, and IsHeadersPresent is always checked before accessing the headers collection.

I am experiencing the same issue. Reproduction steps are clear. From my understanding something is wrong with IsHeadersPresent() method, perhaps as a hotfix it would be enough to change the if statement to:
_context.Properties.Headers != null && _context.Properties.Headers.TryGetValue(key, out value)

Looks like a bug in the RabbtiMQ Client - maybe introduced with 6.2.1.
I agree checking for null is a fix for now.

Issue on RabbitMQ https://github.com/rabbitmq/rabbitmq-dotnet-client/issues/942

Once the develop packages are available, please verify in your tests that the issue is resolved. Thank you.

Great. It's resloved. Cheers!


planning: added lateral_acceleration_bound in planning_gflags; will b…

…e used later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] Migrating container-interop to PSR-11

Following discussion at #90, this PR implements PSR-11 and adds a deprecation warning at the forefront of the README.
Closes #90
Feedback needed. Not to be merged before Feb 13th!

Looks good to me but I guess it would be better to try it out before merging just to be sure? I'll give it a try with PHP-DI

Looks ok for Slim framework.  I've created a PR converting the application's container to a PSR-11 container.  It also allows users to swap in another PSR-11 container.
It requires "container-interop/container-interop": "^2.0", so it is caught by Composer if a user is trying to swap in a container which only implements container-interop/container-interop version 1.
Exceptions implement Interop\Container\Exception\ContainerException and Psr\Container\ContainerExceptionInterface, so user-land code can still catch them as Container-Interop exceptions.
It seems to me that the upgrade path works ok 👍

@Sam-Burns why do we need to tag a new major version? (2.0) If we keep BC then this can be a 1.2 and all containers (implementors) would be automatically compatible with PSR-11 without needing any new release right?

@mnapoli Sure, that sounds fine.

Congrats container-interop, you've stood the test of time.

@mnapoli Any additional checks you want to perform? Can I merge this?

All good!


chore: add contribution notice with GitHub link

This commit updates the footer in the simplistic frontend HTML files to include a contribution notice. The notice encourages users to check out the Sleep API on GitHub to contribute to the project.

Ok I would so that now
sorry for not seeing this

Sorry for bothering you a lot, this is my first time squashing a commit,
please check if I have done it right now

Sorry for bothering you a lot, this is my first time squashing a commit, please check if I have done it right now

Don't worry about bothering me, I'm not in a rush :)
Looking at the history of your pushes it looks like you pushed 2 new commits to the PR first and then force pushed a squash:

If you look at the commits currently attached to this PR there's 3 commits, we're trying to go to just 1 commit:

I'm not sure what caused you to push 2 commits to the PR, but that would put the total at 6 commits, then you pushed a squash which squashed 4 of those to 1 commit. Finally landing at 3 commits. So judging by that the squash probably went successful, but something caused you to push 2 commits first.
So now you 3 commits on the PR and need to squash those 3 commits into 1 commit. You can follow the directions from my previous comment, but change the amount to squash to 3 instead of 4 like:
git rebase -i HEAD~3

Please don't hesitate to ask questions if you have any 👍

Ok thanks
so I should squash just one which is this one [chore: fix GitHub link in contribution notice]

You check it out now

I can go ahead and delete the breach right?

Thank you so much for Being my mentor and guiding me to finish this project.
You are the best teacher and patient person I have met.
That's very kind of you, it's you I should thank for your contribution 🙏

I can go ahead and delete the branch right?
Sleep API project is set up to automatically delete branches after merge, so it's already been done.
You're all done, I'll close the ticket 👍


Custom comment format to be compatible with yamllint and dependabot

New issue?

[X] I have reviewed the Known Issues and confirm this is not a known issue.

TL;DR
Current comment format is not compatible with yamllint and dependabot
Detailed design
YAMLlint wants two spaces before comments. Yes, I am aware that I can configure yamllint to want 1 space, but if it's possible to make ratchet comply it would make it easier for me.

I use both ratchet and dependabot. Dependabot supports updating version comments but only selection of formats - see https://github.com/dependabot/dependabot-core/pull/5951/files#diff-fd484a22a8411825b6409071a0d839654c9629162c27b0be71e6abe7b7a8d08bR7-R16
If it was possible to customize the comment format it would save me time and effort

Additional information
Thanks for taking the time to review my requests :)

This is a function of the upstream YAML parser and writer that we use. There's no option to control this spacing.


Can't download videos from Arte TV

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.04.08 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Europe
Description
It was possible to download videos from that site a few weeks ago.
Verbose log
yt-dlp -vU https://www.arte.tv/es/videos/032412-000-A/carmen/
[debug] Command-line config: ['-vU', 'https://www.arte.tv/es/videos/032412-000-A/carmen/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, err UTF-8, pref UTF-8
[debug] yt-dlp version 2022.04.08 [7884ade65] (zip)
[debug] Python version 3.6.9 (CPython 64bit) - Linux-4.15.0-176-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 3.4.8, ffprobe 3.4.8, phantomjs 2.1.1
[debug] Optional libraries: certifi, Crypto, secretstorage, sqlite
[debug] Proxy map: {}
Latest version: 2022.04.08, Current version: 2022.04.08
yt-dlp is up to date (2022.04.08)
[debug] [ArteTV] Extracting URL: https://www.arte.tv/es/videos/032412-000-A/carmen/
[ArteTV] 032412-000-A: Downloading JSON metadata
ERROR: [ArteTV] 032412-000-A: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 641, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/arte.py", line 58, in _real_extract
    '%s/config/%s/%s' % (self._API_BASE, lang, video_id), video_id)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1033, in _download_json
    expected_status=expected_status)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1011, in _download_json_handle
    expected_status=expected_status)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 800, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 785, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 767, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3601, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

Another duplicate of #3622. Duh.

Sorry! Many thanks for pointing to original issue.


Changes to build makefiles

This pull request clears a number of warnings from LGTM and introduces a command to create a makefile to help with incremental builds.   The makefile currently only works for linux type systems, but otherwise should be fully functional.
To create a makefile use
    python setup.py build_makefile

It is tied to the build ext system so unfortunately it doesn't run properly if the build directory already exists.  You can then edit the makefile and use it to test builds.  Once this is is working we can remove the project/jpype_cpython/Makefile.
This is backport of a portion of instrumentation pull request.

Ready to go.  This is safe to apply in any order.

This Pull request is part of the approved instrumentation PR.  Thus I will apply this one first.


Finalize Winery Feature

we require tests (similar to tests of other classes, with mocked winery) for the new feature in the QC-Atlas
union with UI
we require (UI) documentation about the feature in our readthedocs
quantil-docker update for winery and env variables, additional profile for winery

https://github.com/UST-QuAntiL/quantil-docker/pull/30 adds Winery to quantil-docker

https://github.com/UST-QuAntiL/qc-atlas/pull/213 adds tests


Unable to create a signed JWT from the given configuration.

Hello, I have a problem with Lexik and easy admin....

I have this message: " An exception has been thrown during the rendering of a template ("Unable to create a signed JWT from the given configuration."). "

this is my paramettre.yml
parameters:
    database_host: <IP_ADDRESS>
    database_port: null
    database_name: symfony
    database_user: root
    database_password: null
    mailer_transport: smtp
    mailer_host: <IP_ADDRESS>
    mailer_user<EMAIL_ADDRESS>    mailer_password: 12399201
    secret: MySecretStoryIsSoAwesome
    jwt_private_key_path: '%kernel.root_dir%/../jwt/private.pem'
    jwt_public_key_path: '%kernel.root_dir%/../jwt/public.pem'
    jwt_key_pass_phrase: SecretForAPI
    jwt_token_ttl: 3600

security.yml
# To get started with security, check out the documentation:
# https://symfony.com/doc/current/security.html
security:

    encoders:
        NAO\UserBundle\Entity\User: sha512

    role_hierarchy:
        ROLE_USER: ROLE_USER
        ROLE_NATURALISTE: [ROLE_ADMIN, ROLE_USER]
        ROLE_ADMIN: ROLE_ADMIN
        ROLE_SUPER_ADMIN: [ROLE_ADMIN, ROLE_ALLOWED_TO_SWITCH]

    providers:
        fosFournisseur:
            id: fos_user.user_provider.username

    firewalls:
        dev:
            pattern: ^/(_(profiler|wdt)|css|images|js)/
            security: false

        login:
            pattern:  ^/API/login
            stateless: true
            anonymous: true
            form_login:
                check_path: /API/login_check
                success_handler: lexik_jwt_authentication.handler.authentication_success
                failure_handler: lexik_jwt_authentication.handler.authentication_failure

        post_observation:
           methods: [POST]
           pattern: ^/API/observation/search
           security: false

        post_taxref:
            methods: [POST]
            pattern: ^/API/taxref/search
            security: false

        api:
            pattern:    ^/API
            stateless: true
            guard:
                authenticators:
                    - lexik_jwt_authentication.jwt_token_authenticator

        main:
            pattern: ^/
            anonymous: true
            provider: fosFournisseur
            form_login:
                csrf_token_generator: security.csrf.token_manager
                login_path: fos_user_security_login
                check_path: fos_user_security_check
                default_target_path: /
            logout:
                path: fos_user_security_logout
                target: fos_user_security_login
            logout_on_user_change: true
            remember_me:
                secret: "%secret%"

    access_control:
        - { path: ^/login$, role: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/register, role: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/resetting, role: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/contact, role: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/profile, role: ROLE_USER }
        - { path: ^/observation, role: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/admin, roles: ROLE_ADMIN}
        - { path: ^/API, roles: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/API/login, roles: IS_AUTHENTICATED_ANONYMOUSLY }

So When i have not connect on the site no problem i can read a page and token, but when i'm connected with easy admin bundle i have an errore ...

I got the same issue, but as stated in this comment in issue #532, try to regenerate the certificates.
Regenerating the certificates (jwt/public.pem and jwt/private.pem) helps in my case.
Why? I don't know.

Lol a tutorial? because I run under windows 10 ...
And I can not launch the command
$ mkdir -p config/jwt # For Symfony3+, no need of the -p option $ openssl genrsa -out config/jwt/private.pem -aes256 4096 $ openssl rsa -pubout -in config/jwt/private.pem -out config/jwt/public.pem

A search engine can do the trick: https://stackoverflow.com/questions/2355568/create-a-openssl-certificate-on-windows#21180554

Ok, With git is good. Know i have this problem, it does not move
https://image.noelshack.com/fichiers/2018/31/1/1532973925-openssl.png

Closing as resolved

symfony 4: make sure that value of JWT_PASSPHRASE from .env file is the same you enter in terminal while generating the keys with openssl

Thakns it's works

@Albert221 nope, you have to generate them. Either use the generated JWT_PASSPHRASE for creating them, or update the JWT_PASSPHRASE in your .env afterwards.

I had the same error.
In my case the passphrase was good.
It was a problem with symlink. To have it work I delete symlink to the keys and regenerate the keys.

I have the same issue as @kaizokou
I use a easycorp/easy-deploy-bundle
And it creates a new folder for each release, so the config/jwt folder is empty after each deploy.
I've made the config/jwt folder as a symlink to shared folder but it seems that it can't read it behind the symlink :-
It also does not work if i make a symliks to the keys not folder
Is there any idea other than regenerating it on each deploy? Or it is a good practice?

for linux it s work fine :
$ openssl genrsa -out config/jwt/private.pem -aes256 4096
$ openssl rsa -pubout -in config/jwt/private.pem -out config/jwt/public.pem

good day - sometimes jwt public private keys not in directory - which in symfony config files written

for linux it s work fine :
$ openssl genrsa -out config/jwt/private.pem -aes256 4096 $ openssl rsa -pubout -in config/jwt/private.pem -out config/jwt/public.pem

this is works!


Allow using 0 as min or max for numeric input

Description
Allow using "0" as min or max properties for numeric input
Related Issues

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow override of storage per module

A really useful feature would be to allow the override of storage e.g. encryption of specific vuex modules.
For example, at the moment you can only specify it for the vuex key in its entirety:
createPersistedState({
      storage: {
        getItem: key => {
          return secureLocalStorage.get(key);
        },
        setItem: (key, value) => secureLocalStorage.set(key, value),
        removeItem: key => secureLocalStorage.remove(key)
      }
    })

How about an API that allows an override of storage in a similar way to the paths property:
createPersistedState({
      paths: stateToPersist,
      storage: [{
        path: 'storeAuth.js',
        getItem: key => {
          return secureLocalStorage.get(key);
        },
        setItem: (key, value) => secureLocalStorage.set(key, value),
        removeItem: key => secureLocalStorage.remove(key)
      }]
    })

You can already do this by registering the plugin multiple timeson your store for different paths / modules.

Ah, didn't know that, thank-you!


Added trace logging level.  Added call to init_logging such that it s…

To test backup init_logging:

Run your favorite entry point  (I.E. 'run_human_input.py') and verify default logging
Remove init_logging from your favorite entry point (be sure to revert this when you are done)
Run your favorite entry point and verify no logging (besides print statements. Note: run_human_input has a lot of print statements which will circumvent logging configurations.)
Create a 'log.config.user.py' file in your working directory and add a config (copy and modify from 'Logging_config.py').  I recommend adding a prefix string to the format like this: '"format": "TEST%(message)s"' to make it obvious when this file is used.
Run your favorite entry point.  Verify your logging works.
Remove or rename 'log.config.user.py' so it doesn't get used continuously

To test trace:

add a logger.trace("message") somewhere
Run and verify no message (assuming default logging config)
add a 'log.config.user.py' file that supports trace logging
Run and verify your log message now appears
Remove or rename 'log.config.user.py' so it doesn't get used continuously

Here is an override 'log.config.user.py' file that I used:
{     "version": 1,     "root": {         "level": "TRACE",         "handlers": ["console"],         "propagate": False     },     "loggers": {         "machine_common_sense": {             "level": "TRACE",             "handlers": ["console"],             "propagate": False         }     },     "handlers": {         "console": {             "class": "logging.StreamHandler",             "formatter": "brief",             "level": "TRACE",             "stream": "ext://sys.stdout"         }     },     "formatters": {         "brief": {             "format": "TEST%(message)s"         }     } }

Maybe this isn't the right place for this discussion, but it seems like MCS swallowing errors by default (not showing any error messages unless error logging is enabled) has caused a lot of headache, both while debugging eval submissions, and previous development I've done. I guess we can try to remember to enable error logging ourselves (though we probably can't rely on TA1 being as rigorous), but it seems to me like we should just return the errors by default, instead of swallowing them (if not to console, then to an error log file). Thoughts?

I think you are right and I can fix the default here.  My original goal in this PR was to not change the behavior, but I think your idea is an improvement.

Before I merge, does anyone have any comments about the change to put the "fail-safe" logging level to errors on console?


[FEAT] Date Range

Date ranges.  Select first date and then select last date and show a bar between them like ui-bootstrap's.

+1

I don't understand what your asking for here - ui-bootstrap doesn't seem to have an example of this that I can find?

+1

Looking forward for this feature.

@SimeonC sorry I was mistaken, I confused it with a different control but you get what i was talking about.

@SimeonC amcdnl is talking about the date range feature. If you can add it, it would be perfect.
Example date range picker:
https://github.com/dangrossman/bootstrap-daterangepicker

It would be a lot cooler if you could just select 2 dates from the same calendar, duplicating the calendar doesn't look very good.

:+1: OK, I get what that's on about, yea we can probably do that in some cool way.

Feature now being tracked in new repo: https://github.com/SimeonC/sc-date-time/issues/2


Trojan Virus within code

My antivirus found a Trojan virus in the Windows Installer of the tmc-cli.

I've got the same detection. It identified Trojan:W32/Generic.relch!fsmind
Please, rebuild the installer from a clean system.


feat: add mix tasks for generating release artifacts

This PR adds new mix tasks that facilitate the generation of release artifacts.
Distillery's implementation is used for generating the appup file and relup is generated via :systools.make_relup/4.
The default upgrade archive, created via systools.make_tar/2, is extracted. Then, all files from the release directory are added to the extracted tmp directory and finally, the files are archived again (some files from the Elixir structure, such as env.sh, are not packed inside the tar by default)

Also, for completeness, we talk about the challenges for hot code upgrades here: https://hexdocs.pm/mix/Mix.Tasks.Release.html#module-hot-code-upgrades :)

@josevalim, thanks for pointing out this notice to me. We want to use the built-in upgrading for minor changes and when it doesn't involve state changes. Our goal is to reduce user disconnection during updates when it is possible


[refactor]: INVITE_BASEURL does not meet the semantics in flat-web

INVITE_BASEURL Does not meet the semantics
Originally posted by @BlackHole1 in https://github.com/netless-io/flat/pull/829#discussion_r679042876
https://github.com/netless-io/flat/pull/834/files#diff-80cd6ff40d48acb0207a9e0780233787449517800f219c43a5d83f1569b344d1R95

INVITE_BASEURL => FLAT_WEB_BASEURL

Not sure we support https://example.com/SUB_DIRECTORY/replay/ROOM_TYPE/ROOM_UUID/OWNER_UUID/ kind of link or not.
If we want to support this kind of URL, we should not name it to the domain. base_url is better.
BTW, I noticed we already have the constant FLAT_WEB_DOMAIN in https://github.com/netless-io/flat/blob/main/web/flat-web/src/constants/process.ts.
Use INVITATION_BASE_URL or INVITATION_ENDPOINT instead will be better, IMO.

In https://github.com/netless-io/flat/pull/829, our requirement is to open the playback link, so using INVITATION is not a good idea in this scenario.

Should we only keep FLAT_WEB_DOMAIN? Or, keep FLAT_WEB_DOMAIN and give it a better name, e.g: WEB_DOMAIN?

The link https://{DOMAIN} with a protocol (https:) called URL or endpoint.
It's OK to use domain if it does not have the protocol part.
You could try this in Node.js REPL:
> new URL('https://exmaple.com:8080/test/test/file.ext')

The result will be:
URL {
  href: 'https://exmaple.com:8080/test/test/file.ext',
  origin: 'https://exmaple.com:8080',
  protocol: 'https:',
  username: '',
  password: '',
  host: 'exmaple.com:8080',
  hostname: 'exmaple.com',
  port: '8080',
  pathname: '/test/test/file.ext',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

The domain and the hostname are the same thing. Hope this helps you understand the URL.

Thanks for the correction, that might be better called FLAT_WEB_ORIGIN / FLAT_WEB_URL / FLAT_WEB_BASE_URL?

The WEB_URL sounds like a full URL.
FALT_WEB_BASE_URL looks good.

Good. Would anyone like to try and submit a PR for this issue? @netless-io/flat

OK, let me solve this.


Gateway MVC forward request but with decoded parameters (%2B becomes +)

Describe the bug
I use the following version of Spring Cloud Gateway MVC to forward request.
org.springframework.cloud
spring-cloud-starter-gateway-mvc
4.1.2
same description as https://github.com/spring-cloud/spring-cloud-gateway/issues/3272
a bug in the code of the ProxyExchangeHandlerFunction class.
	boolean encoded = containsEncodedQuery(serverRequest.uri());
	// @formatter:off
	URI url = UriComponentsBuilder.fromUri(serverRequest.uri())
			.scheme(uri.getScheme())
			.host(uri.getHost())
			.port(uri.getPort())
			.replaceQueryParams(serverRequest.params())
			.build(encoded)
			.toUri();

This is based on serverRequest.uri() to determine whether the URL has been encoded, but when constructing a new URL, the query parameter is replaced with serverRequest.params(). The reality is that serverRequest.uri() is encoded by the URI, but serverRequest.params() is not encoded.
Sample
The url as http://localhost:8083/test?q=name%3Atestname%2BState%3AFailed
In Gateway MVC will forward the rquest as
http://localhost:8083/test?q=name:testname+State:Failed, when the corrsponding service receive the request,
then + becomes space character.
For the UriComponentsBuilder, it will use HierarchicalUriComponents internally, is this related to below issue?
https://github.com/spring-projects/spring-framework/issues/23025

containsEncodedQuery can also cause double-encoding. If the (decoded!) query param contains a non-standard char, it will assume everything is not encoded and encode the whole thing again.


TypeError in /clan/blackandwhite-u0ypppgq

Error in ClashLeaders
TypeError in /clan/blackandwhite-u0ypppgq
Cannot read property '$options' of undefined
View on Bugsnag
Stacktrace
webpack:///node_modules/vue/dist/vue.esm.js:2822 - e.componentInstance

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
TypeError in /clan/blackandwhite-u0ypppgq


[Experiment] Drop prioritization of givens over implicits

Should fix #21264 although that has not been tested yet

@WojciechMazur could you test if the changes here drop the warnings from https://github.com/scala/scala3/issues/21264#issuecomment-2248233870 ?
Note that even if it should solve those, it may likely also incur new warnings (including in other projects).

@odersky Unfortunately, there are already errors in the community-build C, e.g.:
[error] -- [E172] Type Error: /__w/scala3/scala3/community-build/community-projects/scalaz/core/src/main/scala/scalaz/Adjunction.scala:120:46
[error] 120 |    new Adjunction[Writer[E, *], Reader[E, *]] {
[error]     |                                              ^
[error]     |Ambiguous given instances: both method writerTraverse in class WriterTInstances0 and method writerFunctor in class WriterTInstances14 match type scalaz.Functor[[_] =>> scalaz.Writer[E, _]] of parameter F of constructor Adjunction in class Adjunction

[error] -- [E172] Type Error: /__w/scala3/scala3/community-build/community-projects/scalaz/core/src/main/scala/scalaz/Adjunction.scala:120:46
[error] 120 |    new Adjunction[Writer[E, *], Reader[E, *]] {
[error]     |                                              ^
[error]     |Ambiguous given instances: both method writerTraverse in class WriterTInstances0 and method writerFunctor in class WriterTInstances14 match type scalaz.Functor[[_] =>> scalaz.Writer[E, _]] of parameter F of constructor Adjunction in class Adjunction

[error] -- [E007] Type Mismatch Error: /__w/scala3/scala3/community-build/community-projects/scala-collection-compat/compat/src/test/scala/test/scala/collection/BuildFromTest.scala:124:39
[error] 124 |    val xs6: TreeMap[String, String] = xs5
[error]     |                                       ^^^
[error]     |          Found:    (xs5 : Map[String, String])
[error]     |          Required: scala.collection.immutable.TreeMap[String, String]
[error]     |
[error]     | longer explanation available when compiling with `-explain`

[error] -- [E172] Type Error: /__w/scala3/scala3/community-build/community-projects/parboiled2/parboiled-core/src/test/scala/org/parboiled2/ActionSpec.scala:40:32
[error] 40 |      "`test`" - new TestParser0 {
[error]    |                                ^
[error]    |Ambiguous given instances: both method hnil in object Unpack and object HNilUnpack in object Unpack match type org.parboiled2.support.Unpack.Aux[org.parboiled2.support.hlist.HNil, Unit] of parameter unpack of constructor TestParser in class TestParser

[error] -- [E172] Type Error: /__w/scala3/scala3/community-build/community-projects/parboiled2/parboiled-core/src/test/scala/org/parboiled2/RunningSpec.scala:38:17
[error] 38 |        p.A.run() ==> Success(())
[error]    |                 ^
[error]    |No best given instance of type org.parboiled2.Parser.DeliveryScheme[org.parboiled2.support.hlist.HNil] was found for parameter scheme of method run in trait RuleRunnable.
[error]    |I found:
[error]    |
[error]    |    org.parboiled2.Parser.DeliveryScheme.Try[org.parboiled2.support.hlist.HNil, Out]
[error]    |      (
[error]    |      /* ambiguous: both method hnil in object Unpack and object HNilUnpack in object Unpack match type org.parboiled2.support.Unpack.Aux[org.parboiled2.support.hlist.HNil, Out] */
[error]    |        summon[
[error]    |          org.parboiled2.support.Unpack.Aux[org.parboiled2.support.hlist.HNil, Out]]
[error]    |      )
[error]    |
[error]    |But both method hnil in object Unpack and object HNilUnpack in object Unpack match type org.parboiled2.support.Unpack.Aux[org.parboiled2.support.hlist.HNil, Out].

[error] -- [E007] Type Mismatch Error: /__w/scala3/scala3/community-build/community-projects/play-json/play-json/js/src/test/scala/JsonSpec.scala:38:26
[error] 38 |        "key5" -> Json.obj(
[error]    |                  ^
[error]    |Found:    play.api.libs.json.JsObject
[error]    |Required: play.api.libs.json.Json.JsValueWrapper
[error]    |Note that implicit conversions cannot be applied because they are ambiguous;
[error]    |both method writes in object JsObject and method jsValueWrites in trait DefaultWrites match type play.api.libs.json.Writes[play.api.libs.json.JsObject]
[error] 39 |          "key6" -> "こんにちは",
[error] 40 |          "key7" -> BigDecimal("12345678901234567000")
[error] 41 |        )
[error]    |
[error]    | longer explanation available when compiling with `-explain`
[error] -- [E007] Type Mismatch Error: /__w/scala3/scala3/community-build/community-projects/play-json/play-json/js/src/test/scala/JsonSpec.scala:56:26

@WojciechMazur Can we test this PR with the openCB? It is a modified implicit priority scheme.
On the one hand. we also reverse priority for implicit/implicit pairs, which was not the case before. The advantage is that we do the priority switch in one go. If a library switches from implicits to givens in the future there is no danger of an inadvertent change in resolution. There is one caveat: We still fall back to the old priority rules for implicit/implicit pairs if the new ones would give an ambiguity error. So changing these implicit/implicit pairs to givens risks causing ambiguity errors. But it does not risk a change in the resolved given.
On the other hand we add a tweak where in the case of ambiguities owner ranking trumps type ranking. This helps since there are libraries that explicitly prioritize their implicits by placing them into different classes of a linear hierarchy. If the type score now goes against that we honor the explicit prioritization according to owner instead of reporting an ambiguity.

@odersky I was in the process of writing a review, but ended up pushing two small changes instead:

the first being a small optimization,
the second (and more notable one) being that it seems we may not need the (2nd) owner score disambiguation scheme after all,

I hope that's okay.
The changes look good to me otherwise, hopefully we get positive results from the openCB

I've started the OpenCB based on last commit -https://github.com/scala/scala3/pull/21273/commits/e1cc065f2ee38a520e32406f97a2d11e53a2cccb I'll report results when it done

I believe we still want the ownerscore disambiguation because this gives us a way to upgrade implicit hierarchies to given hierarchies. Right now, the ownerscre disambiguation was not needed since it all owner hierarchies we have seen were over implicits so the second scheme for disambiguating implicit/implicit pairs worked in its place. But this will change when those implicits are changed to givens. Then the ownerscore disambiguation becomes essential.

I believe we still want the ownerscore disambiguation because this gives us a way to upgrade implicit hierarchies to given hierarchies. Right now, the ownerscre disambiguation was not needed since it all owner hierarchies we have seen were over implicits so the second scheme for disambiguating implicit/implicit pairs worked in its place. But this will change when those implicits are changed to givens. Then the ownerscore disambiguation becomes essential.

In that case, I don't think the previous version addressed that case as we were under the case matching ownerScore to 0.

@EugeneFlesselle I don't think the optimization is worth it here (not that it matters much either way). It should be very rare to have an ambiguous implicit/implicit pair. On the other hand, a local lazy val requires an allocation even if it is never used (which will be the case for all new code past 3.6 which uses only gives). So since the benefit is dubious or even negative, I don't think it's worthwhile complicating the logic here.
EDIT: In fact looking at it more I find the revised logic clearer than the original one. So let's keep it, a single allocation should not matter anyway here.

Either way, dropping the commit is completely fine with me

@EugeneFlesselle @bracevac
Once we have the results from the OpenCB we might want to explore ways how to mitigate the breakage. Say we have a library with implicits whose priority changes. We find out in a test of the library or in an application using the library. We can fix this on ether the library side or the application side.

On the library side: Prioritize explicitly using owner score.
On the application side: Provide an explicit argument fixing the old choice.

One technique which might help would be to offer a rewrite rule in 3.5 or 3.6-migration that adds an explicit argument according to the old rules if a priority change is observed.

In that case, I don't think the previous version addressed that case as we were under the case matching ownerScore to 0.

Indeed. I now pushed a commit that should fix this problem.

I am shortly going to push a fix & analysis for the failing StringFormatterTest.

@WojciechMazur I see. Yes, probably it's best to temporarily revert https://github.com/scala/scala3/pull/21257.


Does it support .net core ??

Hello @tavisca-arvindy ,
Since the v1.5.0, the library support .NET Core for NETSTANDARD 1.6
Let me know if that answer correctly to your question.
Best Regards,
Jonathan

Hi,
The nuget seems broken, it targets netcore 4.5, which does'nt exists.

May i ask you if NetStandard 1.6 is truly needed ?

it targets netcore 4.5, which does not exist.

That was for Metro application which supports .NET "Core" 4.5 (Target Windows 8)
It was before the .NET Core we know today.

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core
Or perhaps I misunderstood your question?
Best Regards,
Jonathan

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core
Or perhaps I misunderstood your question?

My own lib, which depends on HAP, is NetStandard 1.1 and i would not want to rise it to 1.6.
Do you have some guidance about that?

The problem about .NETStandard 1.1 is almost nothing is supported that library requires.
By example, 3 of 4 packages on which HAP depend require .NETStandard 1.3 minimum:

https://www.nuget.org/packages/System.Xml.XmlDocument/
https://www.nuget.org/packages/System.Xml.XPath/
https://www.nuget.org/packages/System.Xml.XPath.XmlDocument/

So it could be possible to create a .NETStandard 1.3 packages but 1.1 will be close to impossible I believe since we don't have access to package required.
If we remove theses dependencies, I'm not sure how many functionalities we will remove!
We will soon support CSS Selectors like jQuery. Perhaps after we support it, I could check to see about the support for 1.1
You will not have access to XPath selectors, but at least you will have access to CSS Selectors.
Best Regards,
Jonathan

Thanks for your thorough answer.
Thinking back on it, NetStandard 1.3 sounds good to me.
Best regards,
Stéphane.

Great, we will try to support .NET Standard 1.3 during the weekend.
Best Regards,
Jonathan

Hello @pendenaor ,
We added support to the .NET Standard 1.3,
The new version should be available within a few hours.
Best Regards,
Jonathan

Hello @jonalbrecht ,
The version v1.5.0-beta9 has been released:
https://www.nuget.org/packages/HtmlAgilityPack/1.5.0-beta9
Let us know if the support to .NET Standard 1.3 work correctly
Best Regards,
Jonathan

Closing Comment: Feel free to re-open if you still have an issue.


fix: skip cleanup for non-2xx status

What kind of change does this PR introduce?

Skip the cleanup function if the status returned from the ResponseWriter is a non-2xx code
Refactor the cleanup method to be passed as an interface into databaseCleanup to make it easier to test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 57.358%

Totals

Change from base Build<PHONE_NUMBER>3:
0.1%

Covered Lines:
9728

Relevant Lines:
16960

💛  - Coveralls