RgbImage::draw() causing App crashes

I'm not exactly sure what, but in upgrading to 15.8 something seems some kind of memory issue with RgbImage::draw() . draw::draw_image is working fine. I imagine the issue might have to do with the new ColorDepth enum.
I'm not getting any specific error code, but just app crashes.  Switching all cases of RgbImage::draw() to draw::draw_image() (in both cases making sure I was using the correct ColorDepth fixed my problem. If the problem isn't readily clear after you look at the source doe I'll create a more detailed bug report.
On Windows 10.

Seems to be working! I'll let you know if I run into any more issues.

Hey, sorry I didn't catch this completley the first time, but I'm with v 0.15.9 I'm having issues with drawing an RgbImage with L8 Depth.
The large Image in the center of the frame should be the same image of the grey cup in the right side panel, just larger.

let img_width = self.grey_image.as_ref().width();
let img_height = self.grey_image.as_ref().height();
let bytes = self.grey_image.as_ref().unwrap().to_vec();
//self.grey_image is std::option::Option<image::ImageBuffer<image::Luma<u8>, std::vec::Vec<u8>>>
self.frame.draw2(move|widg|{
    let centered_x = (widg.parent().unwrap().x() + widg.parent().unwrap().width()/2) - (x/2) as i32;
    let centered_y = (widg.parent().unwrap().y() + widg.parent().unwrap().height()/2) - (y/2) as i32;
    match draw_image(&bytes, centered_x, centered_y, img_width as i32, img_height as i32, fltk::enums::ColorDepth::L8){
        Ok(img)=>img,
        Err(e)=>panic!("{}", e)
    };
});

This will intermitently lead the app to crash with error:
process didn't exit successfully: `target\release\MuTexAlpha.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

The size of the image in question is 611x815.
Windows 10, using 0.15.9

I noticed this issue was reopened then reclosed, was it resolved?
I'm trying to replicate the problem on my side, but I can't even with arbitrary input for image data (which should panic on wrong image format).

Hey, thanks for checking it out! Reclosing was an accident. I'm going to do some more testing to see if I can narrow down the issue.

What's grey_image? Is it an fltk::image::RgbImage?
I'm not sure about the exit code, it seems to be a status access violation (window's equivalent of a segfault).

grey_image is is std::option::Option<image::ImageBuffer<image::Luma, std::vec::Vec>>, the standard output from image::imageops::colorops::grayscale

Sorry missed the comment in the code snippet.
I've tried to reproduce with:
use fltk::{app, draw, frame, prelude::*, window};
use image::io::Reader as ImageReader;
use std::error::Error;

fn main() -> Result<(), Box<dyn Error>> {
    let img = ImageReader::open("ex.jpg")?.decode()?;
    let img = image::imageops::colorops::grayscale(&img);
    let w = img.width();
    let h = img.height();
    let bytes = img.to_vec();

    let app = app::App::default();
    let mut wind = window::Window::default().with_size(600, 400);
    let mut frame = frame::Frame::default().size_of_parent();
    wind.end();
    wind.show();

    frame.draw2(move |widg| {
        match draw::draw_image(
            &bytes,
            widg.x(),
            widg.y(),
            w as i32,
            h as i32,
            ColorDepth::L8,
        ) {
            Ok(img) => img,
            Err(e) => panic!("{}", e),
        };
    });

    app.run()?;
    Ok(())
}

Also with just getting a luma image directly:
use fltk::{app, draw, frame, prelude::*, window};
use image::io::Reader as ImageReader;
use image::GenericImageView;
use std::error::Error;

fn main() -> Result<(), Box<dyn Error>> {
    let img = ImageReader::open("ex.jpg")?.decode()?;
    let (w, h) = img.dimensions();
    let bytes = img.to_luma8();

    let app = app::App::default();
    let mut wind = window::Window::default().with_size(600, 400);
    let mut frame = frame::Frame::default().size_of_parent();
    wind.end();
    wind.show();

    frame.draw2(move |widg| {
        match draw::draw_image(
            &bytes,
            widg.x(),
            widg.y(),
            w as i32,
            h as i32,
            ColorDepth::L8,
        ) {
            Ok(img) => img,
            Err(e) => panic!("{}", e),
        };
    });

    app.run()?;
    Ok(())
}

But both run fine.
The problem could be elsewhere. Are you deleting a widget somewhere or using any of the unsafe functions in fltk?

Ok so I haven't yet been able to re-create the issue entirely, but I created this repo, which gives me the same kind of image glitches I'm getting in my more complex application:

Could you test my example and see if you get the same results?

Sure I'll take a look at it

Yes this seems to have fixed the issue!


All pyramid levels >0 are stored as floats?

This seems to be a bug:
$ pwd
/data/active/fractal/tests/Temporary_data_UZH_1_well_9x8_sites_singlefov/20200812-CardiomyocyteDifferentiation14-Cycle1.zarr/B/03/0

$ grep dtype */.zarray
0_TEMPORARY_ZARR_ARRAY/.zarray:    "dtype": "<u2",
0/.zarray:    "dtype": "<u2",
1/.zarray:    "dtype": "<f8",
2/.zarray:    "dtype": "<f8",
3/.zarray:    "dtype": "<f8",
4/.zarray:    "dtype": "<f8",

The fix is easy (the pyramid creation functions, either in yokogawa_to_zarr or in lib_pyramid_creation should recast arrays to the input dtype), but it's important to assess the bug impact on disk space, computation time and visualization performance.

The bug is in principle fixed, but let's leave this open for a while to see whether some of the other issues referenced above are worth revisiting.

Oh, what impact have you seen on e.g. file sizes? If I pull in the current master, I'll then have pyramid levels cast correctly, right? In that case, I will rerun some tests to understand the viewer performance implications

This bug-fix had a significant impact on interactive performance. I was getting a bit confused that browsing the 23 well dataset was slower than back in early June and couldn't pinpoint the issue.
For the videos I made for the CZI demo, the 23 well dataset with floats loads significantly slower. If I wait for full resolutions to load, I go through my loop in about 1.5 min. With the fixed uint16 pyramids, the loop is back down to 1 minute, which is also about what we had in June.
With the uint16, the 23 well example just starts to become usable for plate-wise browsing I'd say.
=> performance impact is certainly there, great that we caught this bug!

On medium size datasets like the 3D FMI test set we have, the effect is also very noticeable. uint16 pyramid make it feasible to browse 3D in zoomed out levels, while the float pyramids made this very slow.
But given the tests on single FOV vs. multi FOV were all done on uint16, it doesn't have an effect on that decision (see https://github.com/fractal-analytics-platform/fractal/issues/66#issuecomment-1174698348).
And for file sizes, maybe they would decrease a bit in general for all FOV saving styles.
@tcompa I think we can close this issue. Let's make sure we always save the intensity images as uint16 going forward, because it clearly affects performance quite strongly. Great that we found this!


[Bug]: Jest doesn't find related tests in multi-project setup

Version
29.7
Steps to reproduce
Reproducible hosted in Stackblitz

Clone my repo https://github.com/reaktivo/test-jest-related-files-multi-project/tree/main.
Read the project's README
Install dependencies via yarn
Run jest --findRelatedTests packages/button/index.js

Expected behavior
Tests for both projects should be found
Actual behavior
Only the test for packages/button is found
Additional context
No response
Environment
System:
    OS: macOS 14.1
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.10.0/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    bun: 1.0.14 - ~/.bun/bin/bun
  npmPackages:
    jest: 29.7.0 => 29.7.0

Has anyone been able to look into this issue?


changed CLp to CT

Why?

i believe that the english community has agreed to changed it to CT
http://kancolle.wikia.com/wiki/Elitecl
http://en.kancollewiki.net/wiki/Talk:Katori/@comment-Nukurin-20150207221416/@comment-Ethrundr-20150208002851

I believe that 1) Wikia does not represent the entire English-speaking community; 2) a single comment on a discussion page does not represent the entire English-speaking community.

right. im sorry for that.


Demo not working as intended

We implemented a simple WebUI solution for running the LungTumorMask model on your own data and visualize the prediction in both 2D and 3D using gradio.
However, after deploying the demo to Hugging Face spaces, when selecting an image (or uploading it), it seems to hang (no update).
It is also likely that the model will need to be bundled as part of the Docker image (instead of attempting to download it from externally).

Fixed in d1052d3a6e2078cf3eb0ff30ca4d70b2e1b97753.


Pinot-server getting timedout with zookeeper and it is not reconnecting back

Pinot-server is getting time-out with zookeeper and it is not reconnecting automatically. This affects all tables. Need to restart the Pinot-server to establish the connection with zookeeper.Is there any fix for this issue?
We have deployed the Pinot in kubernetes and we using the latest code.
Error:
21:32:20.562 ClientCnxn - Client session timed out, have not heard from server in 46943ms for sessionid 0x100014f4ba3007c
21:32:20.664 ZKHelixManager - KeeperState:Disconnected, SessionId: 100014f4ba3007c, instance: Server_pinot-server-0.pinot-server.pinot-quickstart.svc.cluster.local_8098, type: PARTICIPANT
21:32:22.577 ClientCnxn - Unable to reconnect to ZooKeeper service, session 0x100014f4ba3007c has expired
21:32:22.577 ZKHelixManager - KeeperState:Expired, SessionId: 100014f4ba3007c, instance: Server_pinot-server-0.pinot-server.pinot-quickstart.svc.cluster.local_8098, type: PARTICIPANT
21:32:22.602 StateModel - Default reset method invoked. Either because the process longer own this resource or session timedout

Do you know why the Pinot server's connection to zookeeper got timeout? We ran into similar problem here in Uber because the Pinot servers experienced Garbage Collection due to expensive queries. Thus, you may take a look at the query traffic on the servers.

@chenboat That's a good point but Pinot should be able to reconnect and resume operations after the GC. Looks like some issue with Helix in handling ZK disconnect/re-connect

@chenboat , yes we see full GC at the Pinot-server when we run expensive queries and it is getting timeout with zookeeper which is expected . Issue here is the pinot-server goes for a toss and it stops responding completely until we manually restart the pinotserver. We are unable to access any of the tables due to this. we also have query timeout set at server and at the broker level. Do you suggest any fix to reconnect with zookeeper and resume the operations as usual when there is a full GC.

@arthuersundar Did you see any re-connection events by Helix in the Pinot server log? That may help to clarify if Helix (ZKHelixManager) ever tried to reconnect.
Speaking of full GC, we also found another issue in #4484. In such events, the Pinot cluster may not serve queries well as we observed. In particular brokers could still send query to GC'ed servers. The recommendation on that issue is to have a GC triggered auto restart -- if your team have such mechanism in place, then auto-restart could be a choice.

Believe we encountered the same issue while running Pinot 0.7.1. It tried to reconnect but was always failing...we had to restart the server to get it reconnected.
@arthuersundar Wondering if you have a figured out a way to work around this?
Sample error logs:
2021/07/19 15:41:12.922 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (Disconnected)
2021/07/19 15:43:45.796 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Opening socket connection to server <zookeeper>/<IP_ADDRESS>:2181. Will not attempt to authenticate using SASL (unknown error)
2021/07/19 15:43:45.797 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Socket connection established, initiating session, client: /<IP_ADDRESS>:55506, server: <zookeeper>/<IP_ADDRESS>:2181
2021/07/19 15:43:45.797 WARN [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Unable to reconnect to ZooKeeper service, session 0x10148643fc40107 has expired
2021/07/19 15:43:45.797 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Unable to reconnect to ZooKeeper service, session 0x10148643fc40107 has expired, closing socket connection
2021/07/19 15:43:45.797 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (Expired)
2021/07/19 15:43:45.797 ERROR [SegmentBuildTimeLeaseExtender] [pool-5-thread-1] Failed to send lease extension for table4__0__16__20210719T1310Z
2021/07/19 15:43:45.798 INFO [ZooKeeper] [Start a Pinot [SERVER]-EventThread] Initiating client connection, connectString=<zookeeper>:2181 sessionTimeout=30000 watcher=org.apache.helix.manager.zk.ZkClient@32e529d9
2021/07/19 15:43:45.798 INFO [ClientCnxnSocket] [Start a Pinot [SERVER]-EventThread] jute.maxbuffer value is 4194304 Bytes
2021/07/19 15:43:45.798 INFO [ClientCnxn] [Start a Pinot [SERVER]-EventThread] zookeeper.request.timeout value is 0. feature enabled=
2021/07/19 15:43:45.798 INFO [ClientCnxn] [Start a Pinot [SERVER]-EventThread] EventThread shut down for session: 0x10148643fc40107
2021/07/19 15:43:45.801 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Opening socket connection to server <zookeeper>/<IP_ADDRESS>:2181. Will not attempt to authenticate using SASL (unknown error)
2021/07/19 15:43:45.801 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Socket connection established, initiating session, client: /<IP_ADDRESS>:55508, server: <zookeeper>/<IP_ADDRESS>:2181
2021/07/19 15:43:45.802 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Session establishment complete on server <zookeeper>/<IP_ADDRESS>:2181, sessionid = 0x10148643fc40108, negotiated timeout = 30000
2021/07/19 15:43:45.802 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (SyncConnected)
2021/07/19 15:43:45.802 INFO [FetchSessionHandler] [table3__0__2__20210718T0705Z] [Consumer clientId=consumer-12082, groupId=] Error sending fetch request (sessionId=1769794914, epoch=21) to node 10: org.apache.kafka.common.errors.DisconnectException.
2021/07/19 15:45:02.256 WARN [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Client session timed out, have not heard from server in 76356ms for sessionid 0x10148643fc40108
2021/07/19 15:45:02.256 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Client session timed out, have not heard from server in 76356ms for sessionid 0x10148643fc40108, closing socket connection and attempting reconnect
2021/07/19 15:45:02.257 INFO [FetchSessionHandler] [table0__0__9__20210719T1330Z] [Consumer clientId=consumer-12446, groupId=] Error sending fetch request (sessionId=1597105468, epoch=305) to node 10: org.apache.kafka.common.errors.DisconnectException.
2021/07/19 15:45:02.260 INFO [FetchSessionHandler] [table2__0__7__20210719T1407Z] [Consumer clientId=consumer-12456, groupId=] Error sending fetch request (sessionId=348900988, epoch=3) to node 10: org.apache.kafka.common.errors.DisconnectException.
2021/07/19 15:45:02.357 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (Disconnected)
2021/07/19 15:45:02.359 INFO [FetchSessionHandler] [table1_current__0__5__20210719T1358Z] [Consumer clientId=consumer-12450, groupId=] Error sending fetch request (sessionId=1078185856, epoch=2) to node 10: org.apache.kafka.common.errors.DisconnectException.
2021/07/19 15:46:19.437 INFO [AbstractCoordinator] [table1__0__40__20210719T1359Z] [Consumer clientId=consumer-12452, groupId=] Group coordinator <kafka>:9092 (id:<PHONE_NUMBER> rack: null) is unavailable or invalid, will attempt rediscovery
2021/07/19 15:46:19.437 INFO [FetchSessionHandler] [table1__0__40__20210719T1359Z] [Consumer clientId=consumer-12452, groupId=] Error sending fetch request (sessionId=1433443208, epoch=1) to node 10: org.apache.kafka.common.errors.DisconnectException.
2021/07/19 15:46:19.538 INFO [AbstractCoordinator] [table1__0__40__20210719T1359Z] [Consumer clientId=consumer-12452, groupId=] Discovered group coordinator <kafka>:9092 (id:<PHONE_NUMBER> rack: null)
2021/07/19 15:47:38.527 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Opening socket connection to server <zookeeper>/<IP_ADDRESS>:2181. Will not attempt to authenticate using SASL (unknown error)
2021/07/19 15:47:38.527 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Socket connection established, initiating session, client: /<IP_ADDRESS>:55622, server: <zookeeper>/<IP_ADDRESS>:2181
2021/07/19 15:47:38.528 WARN [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Unable to reconnect to ZooKeeper service, session 0x10148643fc40108 has expired
2021/07/19 15:47:38.528 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Unable to reconnect to ZooKeeper service, session 0x10148643fc40108 has expired, closing socket connection
2021/07/19 15:47:38.528 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (Expired)
2021/07/19 15:47:38.528 INFO [ZooKeeper] [Start a Pinot [SERVER]-EventThread] Initiating client connection, connectString=<zookeeper>:2181 sessionTimeout=30000 watcher=org.apache.helix.manager.zk.ZkClient@32e529d9
2021/07/19 15:47:38.531 INFO [ClientCnxnSocket] [Start a Pinot [SERVER]-EventThread] jute.maxbuffer value is 4194304 Bytes
2021/07/19 15:47:38.531 INFO [ClientCnxn] [Start a Pinot [SERVER]-EventThread] zookeeper.request.timeout value is 0. feature enabled=
2021/07/19 15:47:38.532 INFO [ClientCnxn] [Start a Pinot [SERVER]-EventThread] EventThread shut down for session: 0x10148643fc40108
2021/07/19 15:47:38.534 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Opening socket connection to server <zookeeper>/<IP_ADDRESS>:2181. Will not attempt to authenticate using SASL (unknown error)
2021/07/19 15:47:38.534 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Socket connection established, initiating session, client: /<IP_ADDRESS>:55628, server: <zookeeper>/<IP_ADDRESS>:2181
2021/07/19 15:47:38.535 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Session establishment complete on server <zookeeper>/<IP_ADDRESS>:2181, sessionid = 0x10148643fc40109, negotiated timeout = 30000
2021/07/19 15:47:38.535 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (SyncConnected)
2021/07/19 15:49:00.015 WARN [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Client session timed out, have not heard from server in 81480ms for sessionid 0x10148643fc40109
2021/07/19 15:49:00.016 INFO [ClientCnxn] [Start a Pinot [SERVER]-SendThread(<zookeeper>:2181)] Client session timed out, have not heard from server in 81480ms for sessionid 0x10148643fc40109, closing socket connection and attempting reconnect
2021/07/19 15:50:16.493 INFO [ZkClient] [Start a Pinot [SERVER]-EventThread] zookeeper state changed (Disconnected)


Fix date editor keyboard copy

I believe this is the necessary fix to get keyboard copy and paste working for date/datetime cells. In HT 8.0.0 they introduced a new mechanism to identify which elements are "owned" by HT. Previously, when we were using HT 7.4.x, adding the handsontableInput class was sufficient. Now they use an attribute called data-hot-input. See: https://github.com/handsontable/handsontable/issues/6383. Without this identification the right document-level event listeners aren't attached when those cells are selected prior to copying.
Secondarily I updated the calls to a few HT helper methods to reflect the preferred ones in 13.1.x.
Lastly, unrelated to all of that I removed the erroneous package-lock.json file and updated yarn.lock to reflect the current dependencies. If we want to switch to using npm for this project instead of yarn I have no strong feelings, but we shouldn't mix the two.

Taking a look.

I could be wrong but there are no templates in DataHarmonizer right now that take "xsd:datetime" and "xsd:time" as ranges, only "date". That said the copy-paste function did work for me when testing ambr/AMBR's "sample received date" slot, after picking a date in the control.
The edits look good, will merge.
@pkalita-lbl is there anything about how the HOT editors currently work which should also apply to the other editors we maintain in this codebase?

Thanks Patrick - it works great; and thx Ken for testing. I'll ensure the other cut/paste changes in mpox rename branch dataharmonizer.js are removed.

Hmm, there may be one lingering problem.  When DH loads, do a paste into a date field.  Then switch templates.  I'm getting something that hopefully is easy to remedy in FlatpickrEditor.js:
Uncaught runtime errors:
×
ERROR
Cannot read properties of undefined (reading 'destroy')
TypeError: Cannot read properties of undefined (reading 'destroy')
    at DateEditor.destroyElements (webpack-internal:///../lib/editors/FlatpickrEditor.js:88:13)
...

I could be wrong but there are no templates in DataHarmonizer right now that take "xsd:datetime" and "xsd:time" as ranges, only "date".

No you're right. NMDC uses datetimes though. Since this fix is in the FlatpickrEditor base class it should apply to the date, datetime, and time cell editors.

is there anything about how the HOT editors currently work which should also apply to the other editors we maintain in this codebase?

Not that I'm aware of!

When DH loads, do a paste into a date field. Then switch templates. I'm getting something that hopefully is easy to remedy in FlatpickrEditor.js

Oops, yeah, I see. Sounds like a timing issue between when the HT instance is recreated for the new template and some asynchronous event callbacks get handled on the old editor. Should be straightforward to fix. I'll get a PR in shortly.


[concurrency] add fix-it to note for "add 'async' to function"

We were emitting a note on functions saying that they might want to add 'async' to it, because there is an async call in its body, but no fix-it was being emitted. I thought it was more tricky to get the right source location, but it turns out to not be too hard (thanks @bnbarham for the tip!)
This patch handles functions that either have no effects specifiers, throws, or rethrows.
resolves rdar://72313654

@swift-ci please smoke test and merge


Setting or controlling quality of layers in VVC multi-layer encoding

VVC, like the predecessor, supports multi-layer encoding. I looked into the config files provided in the base VTM repo along with this repo, and couldn't find a way to set the quality of the layers independently. I read the software manually, but couldn't find any information.
Is there a way to specify the quality of enhancement layers during encoding. For example, L0 at 32 and L1 at 33, and with L2 at 35.
<Not exactly an issue, thanks for the help!>

For the moment our goal is to support best possible quality at a manageable time for the main10 profile. Multi-layer support is a special-case requiring a different profile, so it is not supported for now. Regarding how there is still a lot of stuff to support in the main10 profile, this is what we will concentrate on in the near future.


Migrate to typescript

I want to take on this task of migrating this project to typescript for better development experience

Thank you.


Possible to local images?

Is it possible to indicate a local directory path so that the images are displayed randomly? or sequentially?

Try latest master, you can set your source to "local:/path/to/directory" and it will read the images in that directory.  Be aware that it doesn't recurse into subdirectories.

Perfect! Will give it a try soon!


_rendered process gone

i downloaded Brackets 1.7
live preview won't work!
i get :
_rendered process gone
help, please

Hi @OBXJuggler, can you post the errors in Debug -> Developer Tools -> Console

Closing since there was no answer.
If you still have problems, please, open a new issue.


[INTERNAL] README: Pre-Alpha -> Alpha

Pull Request Test Coverage Report for Build 129

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.683%

Totals

Change from base Build 127:
0.0%

Covered Lines:
423

Relevant Lines:
618

💛  - Coveralls


[BUG] problem with "stop" call (openai 0.28.1)

INFO:openai:error_code=None error_message="'$.stop' is invalid. Please check the API reference: https://platform.openai.com/docs/api-reference." error_param=None error_type=invalid_request_error message='OpenAI API error received' stream_error=False

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

@elder-plinius you must revert your openai to 0.28.1 by pip uninstall openai then pip install openai==0.28.1

@elder-plinius you must revert your openai to 0.28.1 by pip uninstall openai then pip install openai==0.28.1

yes thats the version I'm using. might be a problem with OpenAIChat, maybe this bit of code? async def _agenerate(
self,
prompts: List[str],
stop: Optional[List[str]] = None,
run_manager: Optional[AsyncCallbackManagerForLLMRun] = None,
**kwargs: Any,
) -> LLMResult:
"""Call out to OpenAI's endpoint async with k unique prompts."""
params = self._invocation_params
params = {**params, **kwargs}
sub_prompts = self.get_sub_prompts(params, prompts, stop)
choices = []
token_usage: Dict[str, int] = {}
# Get the token usage from the response.
# Includes prompt, completion, and total tokens used.
_keys = {"completion_tokens", "prompt_tokens", "total_tokens"}
for _prompts in sub_prompts:
if self.streaming:
if len(_prompts) > 1:
raise ValueError("Cannot stream results with multiple prompts.")
            generation: Optional[GenerationChunk] = None
            async for chunk in self._astream(
                _prompts[0], stop, run_manager, **kwargs
            ):
                if generation is None:
                    generation = chunk
                else:
                    generation += chunk
            assert generation is not None
            choices.append(
                {
                    "text": generation.text,
                    "finish_reason": generation.generation_info.get("finish_reason")
                    if generation.generation_info
                    else None,
                    "logprobs": generation.generation_info.get("logprobs")
                    if generation.generation_info
                    else None,
                }
            )
        else:
            response = await acompletion_with_retry(
                self, prompt=_prompts, run_manager=run_manager, **params
            )
            choices.extend(response["choices"])
            update_token_usage(_keys, response, token_usage)
    return self.create_llm_result(choices, prompts, token_usage)

concurent futures threading was causing this issue


Update vendir to 0.21.0

Vendir 0.21 was released yesterday, but hombre hasn't been updated.
https://github.com/vmware-tanzu/carvel-vendir/releases/tag/v0.21.0

Just noticed there's a 0.21.1


SUM() returns interface{} type for mysql

Version
1.27.0
What happened?
Querying SELECT SUM(val) FROM authors will return interface{} instead if int
Relevant log output
No response
Database schema
CREATE TABLE authors (
  val   INT NOT NULL
);

SQL queries
-- name: GetSum :one
SELECT SUM(val) FROM authors;

Configuration
{
  "version": "2",
  "sql": [{
    "schema": "schema.sql",
    "queries": "query.sql",
    "engine": "mysql",
    "gen": {
      "go": {
        "out": "db"
      }
    }
  }]
}

Playground URL
https://play.sqlc.dev/p/a38fb22db5ce7e2309fd44c197b20ade5e3b8f8f61085b8b39656ee651ff4ddf
What operating system are you using?
No response
What database engines are you using?
MySQL
What type of code are you generating?
Go

Same BTW for MAX() with PostgreSQL on an INTEGER-type column.

Looking forward to see #3223 completed and merged!

I'm not currently working on it. Feel free to fork.

Noted


Modules with different clock domains?

It seems this crate has the restriction that all modules always operate in the same clock domain.
Are there any plans to remove this restriction? :)
Btw, do you have a recommendation which crate or HDL to use, for designing an asynchronous manycore CPU, where each core is self-clocked?

It seems this crate has the restriction that all modules always operate in the same clock domain.

This is correct.

Are there any plans to remove this restriction? :)

Nope. Most (arguably well-formed) RTL design is synchronous within a certain clock domain with special-purpose modules used to communicate between them; kaze is meant to cover only the former, which mainly serves to simplify how the simulator works and its interface. AFAIR verilator and CXXRTL have the same restriction.
It should be possible to encode clock domains into signal/module types and have a simulator with a more limited interface that could support multiple clock domains, perhaps. But I have no further concrete thoughts about this and no intent on digging further in support of the projects I use kaze for.

Btw, do you have a recommendation which crate or HDL to use, for designing an asynchronous manycore CPU, where each core is self-clocked?

I personally only have experience doing multi-clock designs in (System)Verilog targeting FPGA, so I don't really know. But I think amaranth and chisel support it in limited capacity? Could be wrong, though. The only other really interesting Rust HDL project I'm aware of is Spade (which is a more fully-fleshed-out-HDL with richer types/syntax but lacking the metaprogramming facilities that you get with a meta/embedded-HDL) and from what I can tell that also only supports a single clock domain AFAIK.

Thanks for the quick reply. Yeah, after further thought, I probably don't really need multiple clock domains..
Btw, I also found https://crates.io/crates/rust-hdl, what do you think of that compared to kaze?

Hadn’t heard of it until now, thanks for sharing. At a glance it looks neat; will have to check it out more properly sometime.


Up / down arrows as well as left / right arrows?

Hi, am I missing something - I am trying to find a style that allows you to show up / down arrows for cases where vertical scrolling / pagination is used. The left / right arrows work fine for horizontal mode but seem to be counter intuitive for paging up & down. It would be great if the up / down arrows were centrally positioned at the top / bottom of the page as well.

I didn't add such arrows because i don't see much sense in such arrows. But you can do it easily by just adjusting arrows styles http://www.idangero.us/swiper/forum/#!/general:vertical-arrow-display-rath


Add debugging to GHA workflows

manually trigger a workflow. This option will show at step 5.
in the GH Actions UI Console use the SSH command printed every 5 seconds to connect to the build agent.
only the actor can SSH. Must have public key registered on GH.

This also has "Unchanged files with check annotations".

This also has "Unchanged files with check annotations".

This is fixed in PR #13.


Webpage not refreshing

Hi, I seem to be having an issue with refreshing the webpage, the first time I connect it loads fine, but won't refresh or allow me to reload the page without rebooting the pi, the page begins to load and then just hangs.  New to this and have no idea where to start looking.
Any help would be much appreciated

What Web browser are you using?
Sent from my T-Mobile 4G LTE Device
-------- Original message --------
From: geordieeddie<EMAIL_ADDRESS>Date:07/25/2015  3:42 AM  (GMT-05:00)
To: steve71/RasPiBrew<EMAIL_ADDRESS>Cc:
Subject: [RasPiBrew] Webpage not refreshing (#16)
Hi, I seem to be having an issue with refreshing the webpage, the first time I connect it loads fine, but won't refresh or allow me to reload the page without rebooting the pi, the page begins to load and then just hangs. New to this and have no idea where to start looking.
Any help would be much appreciated
—
Reply to this email directly or view it on GitHub.

I've tried it on Firefox, chrome, safari.
Sent from my iPhone

On 25 Jul 2015, at 12:01, Stephen Smith<EMAIL_ADDRESS>wrote:
What Web browser are you using?
Sent from my T-Mobile 4G LTE Device
-------- Original message --------
From: geordieeddie<EMAIL_ADDRESS>Date:07/25/2015 3:42 AM (GMT-05:00)
To: steve71/RasPiBrew<EMAIL_ADDRESS>Cc:
Subject: [RasPiBrew] Webpage not refreshing (#16)
Hi, I seem to be having an issue with refreshing the webpage, the first time I connect it loads fine, but won't refresh or allow me to reload the page without rebooting the pi, the page begins to load and then just hangs. New to this and have no idea where to start looking.
Any help would be much appreciated
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.

Did you check your configuration file to see if the settings are correct?  Temperature ID correct?  Have you tried http queries for temperature in the browser (http://your_ip/getstatus/1) ?  Are you using the bootstrap version of the webpage?
 On Saturday, July 25, 2015 12:55 PM, geordieeddie<EMAIL_ADDRESS>wrote:

I've tried it on Firefox, chrome, safari.
Sent from my iPhone

On 25 Jul 2015, at 12:01, Stephen Smith<EMAIL_ADDRESS>wrote:
What Web browser are you using?
Sent from my T-Mobile 4G LTE Device
-------- Original message --------
From: geordieeddie<EMAIL_ADDRESS>Date:07/25/2015 3:42 AM (GMT-05:00)
To: steve71/RasPiBrew<EMAIL_ADDRESS>Cc:
Subject: [RasPiBrew] Webpage not refreshing (#16)
Hi, I seem to be having an issue with refreshing the webpage, the first time I connect it loads fine, but won't refresh or allow me to reload the page without rebooting the pi, the page begins to load and then just hangs. New to this and have no idea where to start looking.
Any help would be much appreciated
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

I've tried both the bootstrap and original versions, however I've yet to connect my temp probe as it hasn't arrived yet, would this cause issues with being able to connect to the webpage more than once without having to power cycle the pi?
Sent from my iPhone

On 25 Jul 2015, at 18:58, Stephen Smith<EMAIL_ADDRESS>wrote:
Did you check your configuration file to see if the settings are correct?  Temperature ID correct?  Have you tried http queries for temperature in the browser (http://your_ip/getstatus/1) ?  Are you using the bootstrap version of the webpage?
On Saturday, July 25, 2015 12:55 PM, geordieeddie<EMAIL_ADDRESS>wrote:
I've tried it on Firefox, chrome, safari.
Sent from my iPhone

On 25 Jul 2015, at 12:01, Stephen Smith<EMAIL_ADDRESS>wrote:
What Web browser are you using?
Sent from my T-Mobile 4G LTE Device
-------- Original message --------
From: geordieeddie<EMAIL_ADDRESS>Date:07/25/2015 3:42 AM (GMT-05:00)
To: steve71/RasPiBrew<EMAIL_ADDRESS>Cc:
Subject: [RasPiBrew] Webpage not refreshing (#16)
Hi, I seem to be having an issue with refreshing the webpage, the first time I connect it loads fine, but won't refresh or allow me to reload the page without rebooting the pi, the page begins to load and then just hangs. New to this and have no idea where to start looking.
Any help would be much appreciated
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.

Not having a sensor connected and not referencing the ID of the sensor will cause the page to be unresponsive. The webpage isn't good for anything without any sensors connected and being referenced correctly.

Obviously the page serves no purpose without the sensor attached, as it's in the post I decided to set the rest up, and sort port forwarding and a domain so I could control it from work, which is when I came unstuck with the page being unresponsive.  It didn't occur to me that the sensor not being attached would affect the page so much. Thanks for clearing this up for me.
Sent from my iPhone

On 25 Jul 2015, at 22:30, Josh<EMAIL_ADDRESS>wrote:
Not having a sensor connected and not referencing the ID of the sensor will cause the page to be unresponsive. The webpage isn't good for anything without any sensors connected and being referenced correctly.
—
Reply to this email directly or view it on GitHub.


WIP - Decompose force in pressure and viscous

Description of the problem
The force felt by an object / on a boundary has two components, the pressure component and the friction (viscous) component. For some application, it may be useful to know the proportion of each contribution.
Description of the solution
The force is decomposed in its two components at all times.

[x] Decompose the force for the sharp-interface method.
[x] Decompose the force for the standard Navier Stokes solvers.

How Has This Been Tested?

[x] Adapt all NS tests
[x] Adapt all Sharp-IB tests

Documentation
No parameter documentation needs to be changed.

[x] Adapt all Lethe examples that output forces if necessary

Future changes

Apply the same changes for torque calculation

Comments

Include an exception catch in the point location interpolation for the use non-Cartesian meshed (when using curved cells)
I for now kept the decomposed_viscous_pressure_contributions parameter in the parameters list without using it, just to make a final decision on if we remove it completely.
I haven't rebased yet, if #505 is merged before this branch, I will have to rebase anyways.

I'll merge once CI passes :). Good job.


chore(deps): update vue monorepo to v2.7.15

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

vue (source)
2.6.12 -> 2.7.15

vue (source)
2.6.14 -> 2.7.15

vue-template-compiler (source)
2.6.14 -> 2.7.15

Release Notes

vuejs/core (vue)
v2.6.14
Compare Source
v2.6.13
Compare Source

vuejs/vue (vue-template-compiler)
v2.7.15
Compare Source
Bug Fixes

compiler-sfc: add semicolon after defineProps statement (#1https://github.com/vuejs/vue/issues/12879/12879)) (51fef2c)
compiler-sfc: fix macro usage in multi-variable declaration (#1https://github.com/vuejs/vue/issues/12873/12873)) (d27c128)
compiler-sfc: Optimize the value of emitIdentifier (#1https://github.com/vuejs/vue/issues/12851/12851)) (bb59751)
compiler-sfc: Resolve object expression parsing errors in v-on (#1https://github.com/vuejs/vue/issues/12862/12862)) (b8c8b3f)
lifecycle: scope might changed when call hook (#1https://github.com/vuejs/vue/issues/13070/13070)) (74ca5a1)
patch: clone insert hooks to avoid being mutated during iteration (#1https://github.com/vuejs/vue/issues/12905/12905)) (c223634)
types/sfc: improve the type inference using withDefaults (#1https://github.com/vuejs/vue/issues/12872/12872)) (099401e)
types: correct serverPrefetch this type (#1https://github.com/vuejs/vue/issues/13068/13068)) (67c1d26), closes #1https://github.com/vuejs/vue/issues/12488/12488)

v2.7.14
Compare Source
Bug Fixes

compiler-sfc: fix template usage check edge case for v-slot destructured default value (#1https://github.com/vuejs/vue/issues/12842/12842)) (5e3d4e9), closes #1https://github.com/vuejs/vue/issues/12841/12841)
provide/inject: do not mutate original provide options during merge (d1899ca), closes #1https://github.com/vuejs/vue/issues/12854/12854)
reactivity: avoid using WeakMap for IE compatibility (29b5f58), closes #1https://github.com/vuejs/vue/issues/12837/12837)
types: fix spreading VNodeData in tsx (#1https://github.com/vuejs/vue/issues/12789/12789)) (f7db7f3), closes #1https://github.com/vuejs/vue/issues/12778/12778)
types: stricter type condition for EventHandlers (#1https://github.com/vuejs/vue/issues/12840/12840)) (0b3cf7d), closes #1https://github.com/vuejs/vue/issues/12832/12832)

v2.7.13
Compare Source
Bug Fixes

effectScope: calling off() of a detached scope should not break currentScope (800207c), closes #1https://github.com/vuejs/vue/issues/12825/12825)
types: style attribute svg (#1https://github.com/vuejs/vue/issues/12800/12800)) (8e26261)
watch: avoid traversing objects that are marked non-reactive (#1https://github.com/vuejs/vue/issues/12806/12806)) (5960f05)

v2.7.12
Compare Source
Reverts

Revert "fix(setup): setup hook should be called before beforeCreate" (e80cd09), closes #1https://github.com/vuejs/vue/issues/12802/12802) #&#https://github.com/vuejs/vue/issues/12821issues/1282https://github.com/vuejs/vue/issues/12822s/vue/issues/12822)

v2.7.11
Compare Source
Bug Fixes

build: enforce LF line ending in built files (738f4b3), closes #1https://github.com/vuejs/vue/issues/12819/12819)
compiler-sfc: export parseComponent for compat with fork-ts-checker-webpack-plugin (0d6d972), closes #1https://github.com/vuejs/vue/issues/12719/12719)
reactivity: check skip first before checking ref when creating observer (#1https://github.com/vuejs/vue/issues/12813/12813)) (5d26f81), closes #1https://github.com/vuejs/vue/issues/12812/12812)
reactivity: use WeakMap for proxy/raw checks, compat with non-extensible objects (4a0d88e), closes #1https://github.com/vuejs/vue/issues/12799/12799) #&#https://github.com/vuejs/vue/issues/12798issues/12798)
setup: setup hook should be called before beforeCreate (e1342df), closes #1https://github.com/vuejs/vue/issues/12802/12802)
sfc: prune returned bindings for non-TS as well (fb13930), closes #1https://github.com/vuejs/vue/issues/12765/12765)
sfc: remove sfc scoped deep syntax deprecation warnings (2f335b2)
types: fix error with options watch (#1https://github.com/vuejs/vue/issues/12779/12779)) (bc5b92a), closes #1https://github.com/vuejs/vue/issues/12780/12780)
types: support Ref and function types in tsx ref attribute (#1https://github.com/vuejs/vue/issues/12759/12759)) (87f69aa), closes #1https://github.com/vuejs/vue/issues/12758/12758)
types: vue 3 directive type compatibility (#1https://github.com/vuejs/vue/issues/12792/12792)) (27eed82)

Performance Improvements

improve unsub perf for deps with massive amount of subs (8880b55), closes #1https://github.com/vuejs/vue/issues/12696/12696)

v2.7.10
Compare Source
Bug Fixes

compiler-sfc: avoid deindent when lang is jsx/tsx (46ca7bc), closes #1https://github.com/vuejs/vue/issues/12755/12755)
fix parent of multi-nested HOC $el not updating (#1https://github.com/vuejs/vue/issues/12757/12757)) (e0b26c4), closes #1https://github.com/vuejs/vue/issues/12589/12589)
types: Add missing type parameter constraints (#1https://github.com/vuejs/vue/issues/12754/12754)) (810f6d1)

v2.7.9
Compare Source
Bug Fixes

compiler-sfc: allow full hostnames in asset url base (#1https://github.com/vuejs/vue/issues/12732/12732)) (5c742eb), closes #1https://github.com/vuejs/vue/issues/12731/12731)
compiler-sfc: rewriteDefault for class with decorators (#1https://github.com/vuejs/vue/issues/12747/12747)) (5221d4d)
directives shorthand normalize error (#1https://github.com/vuejs/vue/issues/12744/12744)) (2263948), closes #1https://github.com/vuejs/vue/issues/12743/12743)
ensure render watcher of manually created instance is correctly tracked in owner scope (bd89ce5), closes #1https://github.com/vuejs/vue/issues/12701/12701)
fix effect scope tracking for manually created instances (7161176), closes #1https://github.com/vuejs/vue/issues/12705/12705)
ssr: fix on-component directives rendering (#1https://github.com/vuejs/vue/issues/12661/12661)) (165a14a), closes #1https://github.com/vuejs/vue/issues/10733/10733)
types: allow attaching unknown options to defined component (b4bf4c5), closes #1https://github.com/vuejs/vue/issues/12742/12742)
types: fix missing error for accessing undefined instance properties (8521f9d), closes #1https://github.com/vuejs/vue/issues/12718/12718)
types: fix options suggestions when using defineComponent (4b37b56), closes #1https://github.com/vuejs/vue/issues/12736/12736)
types: Make SetupBindings optional on ExtendedVue and CombinedVueInstance (#1https://github.com/vuejs/vue/issues/12727/12727)) (00458cd), closes #1https://github.com/vuejs/vue/issues/12726/12726) #&#https://github.com/vuejs/vue/issues/12717issues/12717)
watch: avoid pre watcher firing on unmount (f0057b1), closes #1https://github.com/vuejs/vue/issues/12703/12703)

Features

types: enhance type for onErrorCaptured (#1https://github.com/vuejs/vue/issues/12735/12735)) (bba6b3d)
types: export DefineComponent (80d1baf), closes #1https://github.com/vuejs/vue/issues/12748/12748)
types: support mixins inference for new Vue() (#1https://github.com/vuejs/vue/issues/12737/12737)) (89a6b5e), closes #1https://github.com/vuejs/vue/issues/12730/12730)

v2.7.8
Compare Source
Bug Fixes

reactivity: fix shallowReactive nested ref setting edge cases (2af751b), closes #1https://github.com/vuejs/vue/issues/12688/12688)
sfc: align <script setup> component resolution edge case with v3 (#1https://github.com/vuejs/vue/issues/12687/12687)) (a695c5a), closes #1https://github.com/vuejs/vue/issues/12685/12685)
types: avoid circular type inference between v2 and v3 instance types (fabc1cf), closes #1https://github.com/vuejs/vue/issues/12683/12683)
types: export defineAsyncComponent type (#1https://github.com/vuejs/vue/issues/12684/12684)) (ba7dd2c)

Features

setup: support listeners on setup context + useListeners() helper (adf3ac8)

v2.7.7
Compare Source
Bug Fixes

codegen: script setup should not attempt to resolve native elements as component (e8d3a7d), closes #1https://github.com/vuejs/vue/issues/12674/12674)
inject: fix edge case of provided with async-mutated getters (ea5d0f3), closes #1https://github.com/vuejs/vue/issues/12667/12667)
setup: ensure setup context slots can be accessed immediately (67760f8), closes #1https://github.com/vuejs/vue/issues/12672/12672)
types: vue.d.ts should use relative import to v3-component-public-instance (#1https://github.com/vuejs/vue/issues/12668/12668)) (46ec648), closes #1https://github.com/vuejs/vue/issues/12666/12666)
watch: fix queueing multiple post watchers (25ffdb6), closes #1https://github.com/vuejs/vue/issues/12664/12664)

v2.7.6
Compare Source
Bug Fixes

types: $refs can also contain ComponentPublicInstance (#1https://github.com/vuejs/vue/issues/12659/12659)) (fffbb9e)
types: fix $children and $root instance types (52a5979), closes #1https://github.com/vuejs/vue/issues/12655/12655)
types: fix missing expose() type on setup context (e0a9546), closes #1https://github.com/vuejs/vue/issues/12660/12660)

v2.7.5
Compare Source
Bug Fixes

add missing export from vue.runtime.mjs (#1https://github.com/vuejs/vue/issues/12648/12648)) (08fb4a2)
detect property add/deletion on reactive objects from setup when used in templates (a6e7498)
do not set currentInstance in beforeCreate (0825d30), closes #1https://github.com/vuejs/vue/issues/12636/12636)
reactivity: fix watch behavior inconsistency + deep ref shallow check (98fb01c), closes #1https://github.com/vuejs/vue/issues/12643/12643)
sfc: fix sfc name inference type check (04b4703), closes #1https://github.com/vuejs/vue/issues/12637/12637)
types: support Vue interface augmentations in defineComponent (005e52d), closes #1https://github.com/vuejs/vue/issues/12642/12642)
watch: fix deep watch for structures containing raw refs (1a2c3c2), closes #1https://github.com/vuejs/vue/issues/12652/12652)

v2.7.4
Compare Source
Bug Fixes

build: fix mjs dual package hazard (012e10c), closes #1https://github.com/vuejs/vue/issues/12626/12626)
compiler-sfc: use safer deindent default for compatibility with previous behavior (b70a258)
pass element creation helper to static render fns for functional components (dc8a68e), closes #1https://github.com/vuejs/vue/issues/12625/12625)
ssr/reactivity: fix array setting error at created in ssr [#https://github.com/vuejs/vue/issues/12632s/12632)] (#&https://github.com/vuejs/vue/issues/12633/issues/12633)) (ca7daef)
types: fix missing instance properties on defineComponent this (f8de4ca), closes #1https://github.com/vuejs/vue/issues/12628#issuecomment-1177258223258223)
types: fix this.$slots type for defineComponent (d3add06)
types: fix type inference when using components option (1d5a411)
types: global component registration type compat w/ defineComponent (26ff4bc), closes #1https://github.com/vuejs/vue/issues/12622/12622)
watch: fix watchers triggered in mounted hook (8904ca7), closes #1https://github.com/vuejs/vue/issues/12624/12624)

Features

defineAsyncComponent (9d12106), closes #1https://github.com/vuejs/vue/issues/12608/12608)
support functional components in defineComponent (559600f), closes #1https://github.com/vuejs/vue/issues/12619/12619)

v2.7.3
Compare Source
Bug Fixes

add renderTracked/Triggered merge strategy (#1https://github.com/vuejs/vue/issues/12616/12616)) (6d1dbee)
ssr/reactivity: fix composition api behavior in SSR (360272b), closes #1https://github.com/vuejs/vue/issues/12615/12615)
types: allow slot attribute (94ccca2), closes #1https://github.com/vuejs/vue/issues/12617/12617)

v2.7.2
Compare Source
Bug Fixes

compiler-sfc: preserve old deindent behavior for pug (1294385), closes #1https://github.com/vuejs/vue/issues/12611/12611)

Features

allow passing directive definition directly to h() (#1https://github.com/vuejs/vue/issues/12590/12590)) (d45bbea)
types: define component improvements (#1https://github.com/vuejs/vue/issues/12612/12612)) (fb93c1b)

v2.7.1
Compare Source
Bug Fixes

compiler-sfc: add semicolon after defineProps statement (#1https://github.com/vuejs/vue/issues/12879/12879)) (51fef2c)
compiler-sfc: fix macro usage in multi-variable declaration (#1https://github.com/vuejs/vue/issues/12873/12873)) (d27c128)
compiler-sfc: Optimize the value of emitIdentifier (#1https://github.com/vuejs/vue/issues/12851/12851)) (bb59751)
compiler-sfc: Resolve object expression parsing errors in v-on (#1https://github.com/vuejs/vue/issues/12862/12862)) (b8c8b3f)
lifecycle: scope might changed when call hook (#1https://github.com/vuejs/vue/issues/13070/13070)) (74ca5a1)
patch: clone insert hooks to avoid being mutated during iteration (#1https://github.com/vuejs/vue/issues/12905/12905)) (c223634)
types/sfc: improve the type inference using withDefaults (#1https://github.com/vuejs/vue/issues/12872/12872)) (099401e)
types: correct serverPrefetch this type (#1https://github.com/vuejs/vue/issues/13068/13068)) (67c1d26), closes #1https://github.com/vuejs/vue/issues/12488/12488)

v2.7.0
Compare Source
Backported Features

Composition API
SFC <script setup>
SFC CSS v-bind

In addition, the following APIs are also supported:

defineComponent() with improved type inference (compared to Vue.extend)

h(), useSlot(), useAttrs(), useCssModules()

set(), del() and nextTick() are also provided as named exports in ESM builds.

The emits option is also supported, but only for type-checking purposes (does not affect runtime behavior)
2.7 also supports using ESNext syntax in template expressions. When using a build system, the compiled template render function will go through the same loaders / plugins configured for normal JavaScript. This means if you have configured Babel for .js files, it will also apply to the expressions in your SFC templates.

Notes on API exposure

In ESM builds, these APIs are provided as named exports (and named exports only):
import Vue, { ref } from 'vue'

Vue.ref // undefined, use named export instead

In UMD and CJS builds, these APIs are exposed as properties on the global Vue object.

When bundling with CJS builds externalized, bundlers should be able to handle ESM interop when externalizing CJS builds.

Behavior Differences from Vue 3
The Composition API is backported using Vue 2's getter/setter-based reactivity system to ensure browser compatibility. This means there are some important behavior differences from Vue 3's proxy-based system:

All Vue 2 change detection caveats still apply.

reactive(), ref(), and shallowReactive() will directly convert original objects instead of creating proxies. This means:
// true in 2.7, false in 3.x
reactive(foo) === foo

readonly() does create a separate object, but it won't track newly added properties and does not work on arrays.

Avoid using arrays as root values in reactive() because without property access the array's mutation won't be tracked (this will result in a warning).

Reactivity APIs ignore properties with symbol keys.

In addition, the following features are explicitly NOT ported:

❌ createApp() (Vue 2 doesn't have isolated app scope)
❌ Top-level await in <script setup> (Vue 2 does not support async component initialization)
❌ TypeScript syntax in template expressions (incompatible w/ Vue 2 parser)
❌ Reactivity transform (still experimental)
❌ expose option is not supported for options components (but defineExpose() is supported in <script setup>).

TypeScript Changes

defineComponent provides improved type inference similar to that of Vue 3. Note the type of this inside defineComponent() is not interoperable with this from Vue.extend().

Similar to Vue 3, TSX support is now built-in. If your project previously had manual JSX type shims, make sure to remove them.

Upgrade Guide
Vue CLI / webpack

Upgrade local @vue/cli-xxx dependencies the latest version in your major version range (if applicable):

~4.5.18 for v4
~5.0.6 for v5

Upgrade vue to ^2.7.0. You can also remove vue-template-compiler from the dependencies - it is no longer needed in 2.7.
Note: if you are using @vue/test-utils, you may need to keep it in the dependencies for now, but this requirement will also be lifted in a new release of test utils.

Check your package manager lockfile to ensure the following dependencies meet the version requirements. They may be transitive dependencies not listed in package.json.

vue-loader: ^15.10.0
vue-demi: ^0.13.1

If not, you will need to remove node_modules and the lockfile and perform a fresh install to ensure they are bumped to the latest version.

If you were previously using @vue/composition-api, update imports from it to vue instead. Note that some APIs exported by the plugin, e.g. createApp, are not ported in 2.7.

Update eslint-plugin-vue to latest version (9+) if you run into unused variable lint errors when using <script setup>.

The SFC compiler for 2.7 now uses PostCSS 8 (upgraded from 7). PostCSS 8 should be backwards compatible with most plugins, but the upgrade may cause issues if you were previously using a custom PostCSS plugin that can only work with PostCSS 7. In such cases, you will need to upgrade the relevant plugins to their PostCSS 8 compatible versions.

Vite
2.7 support for Vite is provided via a new plugin: @vitejs/plugin-vue2. This new plugin requires Vue 2.7 or above and supersedes the existing vite-plugin-vue2.
Note that the new plugin does not handle Vue-specific JSX / TSX transform, which is intentional. Vue 2 JSX / TSX transform should be handled in a separate, dedicated plugin, which will be provided soon.
Volar Compatibility
2.7 ships improved type definitions so it is no longer necessary to install @vue/runtime-dom just for Volar template type inference support. All you need now is the following config in tsconfig.json:
{
  // ...
  "vueCompilerOptions": {
    "target": 2.7
  }
}

Devtools Support
Vue Devtools 6.2.0 has added support for inspecting 2.7 Composition API state, but the extensions may still need a few days to go through review on respective publishing platforms.
Bug Fixes

sfc: only include legacy decorator parser plugin when new plugin is not used (326d24a)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC.
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Rolled up into https://github.com/apollographql/apollo-ios-dev/pull/170.


Ability to specify Twig cache directory

I would like to request a configurable Twig cache directory.
From what I understand, it's around here:
https://github.com/phpDocumentor/phpDocumentor2/blob/28441646799aee8dfe1d4cf41b670831fd59558f/src/phpDocumentor/Plugin/Twig/Writer/Twig.php#L145
that the Twig is initialized and the cache directory is set to the system directory.
However, I would like to have the ability to store Twig cache not higher than the project root directory, and certainly not in shared /tmp folder.
Would you consider adding this feature? If so, would a pull request be considered? If so, how would you approach the problem? A XML config example and a CLI param name would be enough to get me started.
I would go with something like
<?xml version="1.0" encoding="UTF-8" ?>
<phpdoc>
  <twig>
    <cache_folder>tmp/twig/cache</cache_folder>
  </twig>
</phpdoc>

And CLI:
vendor/bin/phpdoc --twig-cache-folder="tmp/twig/cache"

I assume folder should be created if it does not exist.

Is there any update on this issue?

This would be super useful. We're looking at setting up phpDoc-as-a-service, so it would improve performance a bunch if we could pre-compile the Twig templates and point phpDocumentor to it.

I am picking this up

This issue has been resolved by caching the twig files in the project's cache directory that is configurable in your phpdoc.xml. This will ensure that the cache is not shared between projects and is hence decoupled.
Please note that we have chosen not to make this configurable in addition to the project cache location to keep it simple (one cache location for all caches) and because it would require a significant investment, at the moment, to have plugins (such as the Twig plugin) have their own bits of configuration.
Even though this latter option is desirable I have chosen to postpone that for now and ensure that this feature is delivered now to you.

I am closing this as the issue is resolved in develop; I will reopen it if comments indicate that a followup is needed.

This is great thanks! We can always handle configuration by manually messing with the cache directory. :)


Problem whith ID (1.7.10)

Hello, I have a problem:
I have delet a lot of dimension whith /safedel and when I want to create a new dimension, I have a ID from a hold dimension and in the dialing device I don't see the new dimension. Have you got an idea?
(sorry for the mistakes of hortograph, I'm not english)

Are you using different dimlets?

Hello,Yes I use different dimlets.
Envoyé depuis mon appareil mobile Samsung.
-------- Message d'origine --------
De : McJty<EMAIL_ADDRESS>Date : 29/08/2017  12:07  (GMT+01:00)
À : McJty/RFTools<EMAIL_ADDRESS>Cc : dalexBob<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
Are you using different dimlets?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/McJty/RFTools","title":"McJty/RFTools","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/McJty/RFTools"}},"updates":{"snippets":[{"icon":"PERSON","message":"@McJty in #1347: Are you using different dimlets?"}],"action":{"name":"View Issue","url":"https://github.com/McJty/RFTools/issues/1347#issuecomment-325618198"}}}

Can you describe exactly what you're doing and what is happening? I'm not fully understanding the problem

I have a minecraft's savegame and I had 56 rftools dimensions, I used /safedel and /deldim to reduce the number of  dimensions. After, I made a new rftools dimension, she has an ID and this ID was an old dimension and in the dialing device she not appear and now when I use /help I have an error.
-------- Message d'origine --------
De : McJty<EMAIL_ADDRESS>Date : 29/08/2017  13:32  (GMT+01:00)
À : McJty/RFTools<EMAIL_ADDRESS>Cc : dalexBob<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
Can you describe exactly what you're doing and what is happening? I'm not fully understanding the problem
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/McJty/RFTools","title":"McJty/RFTools","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/McJty/RFTools"}},"updates":{"snippets":[{"icon":"PERSON","message":"@McJty in #1347: Can you describe exactly what you're doing and what is happening? I'm not fully understanding the problem"}],"action":{"name":"View Issue","url":"https://github.com/McJty/RFTools/issues/1347#issuecomment-325636093"}}}

Well it is normal that you get the old ID's as they are reused.  Can you give me some logs and the exact error you get?

I'm sorry but I just watch and there is more error but I do not understand how do we get back the visible dimension in the dialing device.
Envoyé depuis mon appareil mobile Samsung.
-------- Message d'origine --------
De : McJty<EMAIL_ADDRESS>Date : 29/08/2017  14:57  (GMT+01:00)
À : McJty/RFTools<EMAIL_ADDRESS>Cc : dalexBob<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
Well it is normal that you get the old ID's as they are reused.  Can you give me some logs and the exact error you get?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/McJty/RFTools","title":"McJty/RFTools","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/McJty/RFTools"}},"updates":{"snippets":[{"icon":"PERSON","message":"@McJty in #1347: Well it is normal that you get the old ID's as they are reused.  Can you give me some logs and the exact error you get?"}],"action":{"name":"View Issue","url":"https://github.com/McJty/RFTools/issues/1347#issuecomment-325655138"}}}

I need logs

I'm sorry but what is the log?It's the save?
Envoyé depuis mon appareil mobile Samsung.
-------- Message d'origine --------
De : McJty<EMAIL_ADDRESS>Date : 29/08/2017  15:23  (GMT+01:00)
À : McJty/RFTools<EMAIL_ADDRESS>Cc : dalexBob<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
I need logs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/McJty/RFTools","title":"McJty/RFTools","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/McJty/RFTools"}},"updates":{"snippets":[{"icon":"PERSON","message":"@McJty in #1347: I need logs"}],"action":{"name":"View Issue","url":"https://github.com/McJty/RFTools/issues/1347#issuecomment-325662191"}}}

You can find logs in the minecraft logs folder. That's where all crashes and problems are logged

This day, I have 4 logs
De : McJty<EMAIL_ADDRESS>Envoyé : mardi 29 août 2017 15:38
À : McJty/RFTools
Cc : dalexBob; Author
Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
You can find logs in the minecraft logs folder. That's where all crashes and problems are logged
—
You are receiving this because you authored the thread.
Reply to this email directly, view https://github.com/McJty/RFTools/issues/1347#issuecomment-325666387  it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/Ad9aQoKTFNFyVH6Rv78WHbrIkYerz4kaks5sdBRCgaJpZM4PExBY  the thread.Image supprimée par l'expéditeur.

Yes I need the last one where you tried to create a dimension

As I did not know when I created a new one.
De : McJty<EMAIL_ADDRESS>Envoyé : mardi 29 août 2017 15:50
À : McJty/RFTools
Cc : dalexBob; Author
Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
Yes I need the last one where you tried to create a dimension
—
You are receiving this because you authored the thread.
Reply to this email directly, view https://github.com/McJty/RFTools/issues/1347#issuecomment-325669970  it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/Ad9aQm5xwU7krVFWL6qQh6ZQRmLLXVP4ks5sdBcFgaJpZM4PExBY  the thread.Image supprimée par l'expéditeur.

Have you found something interesting?

I think that without a log there isn't much interesting to find - the problem is quite obscure and hard to replicate without additional information. Maybe you could just attach all the logs there are?
(I'm not a developer of RFTools or affiliated with them in any way, just trying to help.)

You want all logs since when I started the save?
Envoyé depuis mon appareil mobile Samsung.
-------- Message d'origine --------
De : DeFazer<EMAIL_ADDRESS>Date : 12/09/2017  03:02  (GMT+01:00)
À : McJty/RFTools<EMAIL_ADDRESS>Cc : dalexBob<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
I think that without a log there isn't much interesting to find - the problem is quite obscure and hard to replicate without additional information. Maybe you could just attach all the logs there are?
(I'm not a developer of RFTools or affiliated with them in any way, just trying to help.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/McJty/RFTools","title":"McJty/RFTools","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/McJty/RFTools"}},"updates":{"snippets":[{"icon":"PERSON","message":"@DeFazer in #1347: I think that without a log there isn't much interesting to find - the problem is quite obscure and hard to replicate without additional information. Maybe you could just attach all the logs there are?\r\n(I'm not a developer of RFTools or affiliated with them in any way, just trying to help.)"}],"action":{"name":"View Issue","url":"https://github.com/McJty/RFTools/issues/1347#issuecomment-328700605"}}}

you want the logs since I started my game?
De : DeFazer<EMAIL_ADDRESS>Envoyé : mardi 12 septembre 2017 03:02
À : McJty/RFTools
Cc : dalexBob; Author
Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
I think that without a log there isn't much interesting to find - the problem is quite obscure and hard to replicate without additional information. Maybe you could just attach all the logs there are?
(I'm not a developer of RFTools or affiliated with them in any way, just trying to help.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view https://github.com/McJty/RFTools/issues/1347#issuecomment-328700605  it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/Ad9aQlXBpLiXAo6DUjbRvoNqFf0boP8Iks5shdgggaJpZM4PExBY  the thread.  https://github.com/notifications/beacon/Ad9aQqjHUlGQ0oHaQi-yQ_wHbEgYjcXsks5shdgggaJpZM4PExBY.gif

Not sure if logs will help here. In fact not sure what I can do about this at this stage. The 1.7.10 version of the mod is no longer in development. What about new dimensions? Do these work? Or does every dimension simply fail? If every dimension fails then a log when you are attempting to create a dimension would help

Hello,
I sent you a mail with a log and a document, do you have receive this one?
If you received the mail, did you find something?
De : McJty<EMAIL_ADDRESS>Envoyé : mercredi 13 septembre 2017 19:05
À : McJty/RFTools
Cc : dalexBob; Author
Objet : Re: [McJty/RFTools] Problem whith ID (1.7.10) (#1347)
Not sure if logs will help here. In fact not sure what I can do about this at this stage. The 1.7.10 version of the mod is no longer in development. What about new dimensions? Do these work? Or does every dimension simply fail? If every dimension fails then a log when you are attempting to create a dimension would help
—
You are receiving this because you authored the thread.
Reply to this email directly, view https://github.com/McJty/RFTools/issues/1347#issuecomment-329233280  it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/Ad9aQm-lgD6Jjz0jIAJdugJr-wz_vJ4Vks5siAtEgaJpZM4PExBY  the thread.  https://github.com/notifications/beacon/Ad9aQlbVixyeZa4MaMbYBU3jjEhA_1VLks5siAtEgaJpZM4PExBY.gif

Hmm. No I did not get that. You can mail me directly at<EMAIL_ADDRESS>Note however that I'm not sure I will be able to do much about this and I also no longer work on the 1.7.10 version of rftools

Close as 1.7.10 is no longer supported. If this continues to be a bug on 1.12 or newer, please open a new issue.


az cli 2.0 bug workaround

workaround for missing az feature show command

@christiankuhtz : Thanks for your contribution to the Azure documentation! The author, @KumudD, has been notified to review your proposed change.


editor not opening.

Hello there, pressing on the link to open the editor gives me this error.
An unhandled exception ocurred! If you can, please open a GitHub issue so it can be fixed. Select "OK" to copy the error to your clipboard:
Message: $ is not defined
Stacktrace: @https://start-5.github.io/TiTS.JS-Save-Editor/:150:9

Message: $ is not defined
Stacktrace: ReferenceError: $ is not defined
at https://start-5.github.io/TiTS.JS-Save-Editor/:150:9

This is an issue with a core script that is not being loaded correctly.
Works for me, though I need to test more browsers to be sure.

What browser and browser version are you using?
Has the editor worked before? Have you been able to open it before and this error just now started popping up?

well, I'm using firefox.
It works now just fine though, no idea what was wrong.

If I had to guess, the site that hosts the script might have been down intermittently.
I’ll make it so it uses local scripts to avoid this in the future, not sure why I made it use remote instead of local scripts in the first place

thank you so much for your hard work. would it be possible to edit ship stats in the future? :)

I’d have to see how ships work. If it’s not prone to breaking saves it can probably be added. No promises though.

i am using chrome and it was working when one day it stopped

Please try a different browser. If that doesn’t work, there’s something on your device that’s blocking the script, it could be an ad/content blocker or some firewall on your system.
Opening the browser’s dev console (F12 or ctrl+shift+i) may spit out more information about why it’s not loading.
I’ll push an update to use local scripts whenever I have time

i have 3 browser not even one is opening it and this is what it say on f12(Failed to load resource: net::ERR_CONNECTION_RESET
jquery.min.js:1     Failed to load resource: net::ERR_CONNECTION_RESET
popper.min.js:1     Failed to load resource: net::ERR_CONNECTION_RESET
bootstrap.bundle.min.js:1     Failed to load resource: net::ERR_CONNECTION_RESET
typeahead.js:37 Uncaught TypeError: Cannot read properties of undefined (reading 'isArray')
at typeahead.js:37:24
at typeahead.js:161:6
at typeahead.js:16:9
at typeahead.js:18:3
(index):150 Uncaught ReferenceError: $ is not defined
at (index):150:9)

Yup, it's an issue on your end regarding your network, no idea exactly what it is.

i have 3 browser not even one is opening it and this is what it say on f12(Failed to load resource: net::ERR_CONNECTION_RESET
jquery.min.js:1 Failed to load resource: net::ERR_CONNECTION_RESET

Let me know if the latest update fixes the issue

i have 3 browser not even one is opening it and this is what it say on f12(Failed to load resource: net::ERR_CONNECTION_RESET
jquery.min.js:1 Failed to load resource: net::ERR_CONNECTION_RESET

Let me know if the latest update fixes the issue

thanks for your hard work it is working now


Created foundation for the NoteX project

Signed-off-by: Rajesh Hadiya<EMAIL_ADDRESS>

Looks good to me :)


Add license to the repository

I think of some very permissive license like MIT / Apache 2.0.
See github doc

Yes, I think that we can add the MIT license to turn repository formally open-source.

Issue fixed by PR #11


Add more preview examples in Theme Generator

When using the theme generator, it displays various elements and their variants on top of the surface color.
However, when the container itself uses a variant-filled-X token - for example in alerts, cards, and toasts, the various elements like links, buttons, and others end up looking bad.
What type of pull request would this be?
Enhancement

This may be related to the other issue you mentioned here:
https://github.com/skeletonlabs/skeleton/issues/894
Let's circle back and test this after that has been resolved.

This may be related to the other issue you mentioned here:

text-on-X-token isn't respected inside alert containers in dark-mode #894

Let's circle back and test this after that has been resolved.

This is more about allowing the client to choose better colors when deciding the theme.
For example, on the Theme Generator page the preview section uses a card with a forced transparent background
 and looks like the following

If on the other hand we use a variant-filled-X token
 it looks really ugly

Additionally, Skeleton renderes a tags with color: rgb(var(--color-primary-500) / var(--tw-text-opacity)); and the chosen primary color often looks bad on success, error and warning backgrounds.
Using a color variant for containers like cards, alerts and toasts is a common usecase.

Well that's what this tool is for, giving you a preview of how colors are affecting things, and giving you the opportunity to adjust as needed. I'm not sure we can build any sort of intelligence into this to prevent bad color combinations, because a lot of times that's about personal preference in aesthetics.
@ryceg is, however, working on some mechanism to giving you a better indication of color ratios for a11y in regards to "on" colors. You can track progress on that change here:
https://github.com/skeletonlabs/skeleton/pull/847
He's also investigating a means to provide better quality color steps using HSL colors here:
https://github.com/skeletonlabs/skeleton/pull/858
But as for "what looks good", that's where the saying "beauty is in the eye of the beholder" comes in. I'm not sure there's anything more programmatic that can be done to affect that. At least not with a level of effort that's beyond the scope of what we had in mind for this tool.

@AgarwalPragy Also just to make sure you're aware, you're not confined to the theme generator page and the handful of elements presented there. You can navigate the ENTIRE documentation site while Edit mode is enabled. The entire site reflects to your generated theme.

I agree that adding intelligence to prevent bad color choices is a difficult task.
This is precisely why I'm suggesting adding more examples in the preview section 😅
If the user can see what various elements look like not just on the surface background but also on other background colors, it will allow the user to make better color choices.

@AgarwalPragy Also just to make sure you're aware, you're not confined to the theme generator page and the handful of elements presented there. You can navigate the ENTIRE documentation site while Edit mode is enabled. The entire site reflects to your generated theme.

Yes, but the website doesn't have any examples of links / buttons and other styled elements on top of containers with color variants!

I mean yeah, but where do we draw the line here? We're not going to be able to cover every single combination of every single element or container in the library.
If you need to preview a particular combination of elements, take the theme, drop it into your project, build the combination of features you want and preview them there.
I'm not sure we're going to be able to solve the issue you're facing with the generator so I'm going to go ahead and close out this thread. I appreciate the suggest, but again, we can only do so much. Right now the generator is meeting our expectations so we'll leave it at that.

I understand. No worries. 😄

I mean yeah, but where do we draw the line here? We're not going to be able to cover every single combination of every single element or component in the library.

Every color combination is needed (6*6), not every component combination.

Put the preview items inside a tabbed container. Different tabs show various elements inside a different variant of the container
Add some preview items for text and links

@AgarwalPragy even though I've closed this out I will keep your suggestions in mind. The main reason I'm not keen to do this YET, is that things are still in flux. Perhaps once things settle down we can revisit this idea?


Debug Console: wrong order of incoming input

Runtime environment

Visual Studio Code v1.15.1 own compiler
Node.js v8.2.1
OS: Windows_NT ia32 10.0.15063

Description
I want to add "After sort:" between source arry and sort arry, look like this:

But console occasionally shows:

Why for-of-loop  has not finished running, jump out to run console.log ? Source code:
    // Random to generate double digits.
    function getRandom() {
      return Math.round(Math.random() * 100);
    }
    // Writing data to the array.
    var score = [
      ["a", getRandom()],
      ["b", getRandom()],
      ["c", getRandom()],
      ["d", getRandom()],
      ["e", getRandom()]
    ];
    console.log("Before sort:");

    // Print source arry
    for (let m of score) {
      console.log(m);
    }

    // Call sort()
    score.sort((a, b) => {
      return b[1] - a[1];
    });
    console.log("After sort:");

    // Print sort arry.
    for (let n of score) {
      console.log(n);
    }

If i change my code like this:
// Writing data to the array.
var score = [["a", 55], ["b", 33], ["c", 44], ["d", 88], ["e", 22]];
// Print source arry
for (let m of score) {
  console.log(m);
}
console.log("After sort：");

This bug will still appear:

This is just the order the order in which node is emitting events. Not sure if we can do anything here, though assigning to @roblourens since I see you are using the inspector protocol.

The output events come back from the adapter in the right order, but they seem to get reordered by the console when it resolves the variables.
If the log statement is console.log(1) instead of logging an object, then this doesn't repro.

I acknowledge the bug, the issue is that vscode gets an object as output from node2. VSCode has to get the children of that object by sending some request to node2. In the meantime more output comes which gets recieved before the children get resolved thus being appended to the output before.
Code pointer
The fix would be to remember the events in which they came and append them to the repl in that order. This has the downside that if some object takes a long time to resolve all subsequent output will be stuck.
Not a big fan of the fix -> backlog

Thanks for your answer.

Can't the object be inserted in the right position, once it's resolved, while still appending other output?
This seems like a really bad bug - having logs in the wrong order could make someone waste a lot of time debugging.

Yes, we could insert it in the right position by changing the appendToRepl API we have in the debugModel.
I would only look into this if more users complain since the model is quite fragile due to various heuristics on spliting incoming output.

@isidorn Possibly related to this defect and hopefully helpful: I bumped an issue where console.log() and console.error() messages appear out of order in the JavaScript DEBUG CONSOLE. The isolated code below demonstrates the observation. Doesn't happen outside of the DEBUG CONSOLE. Thanks!

The DEBUG CONSOLE:

@good-bits yeah, this seem to be the same issue. Assigning to November to investigate into a fix.

@isidorn Thanks!

I agree with Rob that this is really a bad bug that we should fix: logs are for troubleshooting bugs not for making the troubleshooting more difficult...

@good-bits I have investigated into your issue and it is actually not the same as the one from above. To be more precise the issue is in the debug adapter - it is sending the events in the wrong order. To track this issue I have created https://github.com/Microsoft/vscode/issues/37770
Keeping this open as this is a different issue explained in my comment above and I will investigate in a fix.

@isidorn @roblourens @weinand Thank you so much!


Reference Range signals in the Slider class documentations

See https://github.com/godotengine/godot-docs/issues/3837.

Thanks!

Cherry-picked for 3.2.3.


KYLIN-4307 WritrConflictException when build cube by layer

Pull Request Test Coverage Report for Build 5615

9 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.009%) to 27.531%

Files with Coverage Reduction
New Missed Lines
%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
4
78.12%

Totals

Change from base Build 5602:
0.009%

Covered Lines:
24197

Relevant Lines:
87891

💛  - Coveralls

Codecov Report

Merging #1107 into master will decrease coverage by <.01%.
The diff coverage is 90%.

@@             Coverage Diff              @@
##             master    #1107      +/-   ##
============================================
- Coverage     25.07%   25.06%   -0.01%
  Complexity     6226     6226
============================================
  Files          1440     1440
  Lines         87883    87892       +9
  Branches      12291    12293       +2
============================================
- Hits          22039    22033       -6
- Misses        63688    63698      +10
- Partials       2156     2161       +5

Impacted Files
Coverage Δ
Complexity Δ

...apache/kylin/common/persistence/ResourceStore.java
70.46% <90%> (+0.2%)
64 <2> (+1)
:arrow_up:

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0%> (-4.77%)
5% <0%> (-1%)

...ream/core/storage/columnar/ColumnarStoreCache.java
52.27% <0%> (-3.41%)
8% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.6% <0%> (-1.52%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5b9a3...9391b2c. Read the comment docs.


ERROR: Building tests failed

Building tests fails:
$ make
==> hamcrest (clean)
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> hamcrest (xref)
==> proper (get-deps)
==> hamcrest (get-deps)
==> proper (compile)
make[1]: Wejście do katalogu '/home/aidecoe/Downloads/ejabberd-16.04/deps/hamcrest/deps/proper'
make[1]: 'include/compile_flags.hrl' jest aktualne.
make[1]: Opuszczenie katalogu '/home/aidecoe/Downloads/ejabberd-16.04/deps/hamcrest/deps/proper'
==> hamcrest (compile)
==> hamcrest (ct)
Showing log
--- Test run on 2016/05/28 16:23:48 ---
Converting "/home/aidecoe/Downloads/ejabberd-16.04/deps/hamcrest/." to "/home/aidecoe/Downloads/ejabberd-16.04/deps/hamcrest" and re-inserting with add_patha/1

Common Test v1.12 starting (cwd is /home/aidecoe/Downloads/ejabberd-16.04/deps/hamcrest)

Common Test: Running make in test directories...
 It's quite sad that testing lib fails in tests itself... Is test broken or there's actually a bug in hamcrest?

@aidecoe if you have a second, could you test out my PR? Thanks!

Yeah sorry, this is a version compatibility issue. If the PR works in happy to merge it.


Updated Readme.md

Changed the API documentation link to link to the updated docs page at http://elasticlunr.com/docs/index.html
Changed the example link to the http://elasticlunr.com/example/index.html page

Hi, @Darkle , thanks very much for fix this issue. I've merged your patch.


Add more tests to item stack class with fixes to those tests

Description
See conversation in issue #1028
Uses data generated from MockBukkit/MetaMiner
Checklist
The following items should be checked before the pull request can be merged.

[x] Code follows existing style.
[x] Unit tests added (if applicable).

When writing this, I have realised one of our tests are not testing anything, this pr can not build until #1076 is finished and merged.


Add file decoding from requested data

With the upcoming integration of a routing framework the requirements will change in the near future.

With the upcoming integration of a routing framework the requirements will change in the near future.


1.20.2

Building the 1.20.2 branch gives a .jar that causes some Mixin errors, and the branch seems very out of date in general compared to 1.20.1 & the master, so I'm assuming there's no real 1.20.2 support.
Obligatory backport request warning, please port your 1.20.1 final version to 1.20.2. I would do it, but you self-implemented a lot of things that I really don't have the time to try to comprehend with my limited Java experience.

yeah i've done a lot of tinkering with existing game code so i'll do this asap


Personal sidebar on the right not shown in IE 11

Gitea version (or commit ref): 1.4.0+rc1-12-g423c642
Git version: 2.15.0
Operating system: Docker container from hub.docker.com
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes => Login using IE - no sidebar shown
[ ] No
[ ] Not relevant

Log gist:

Description
When using IE 11 with gitea the personal sidebar on the right side is not shown, with firefox everyhting is okay.
As a side note - the sidebar is shown in IE when choosing a organisation from the drop down
Screenshots
IE 11 on try.gitea.io

Firefox on try.gitea.io

IE 11 on try.gitea.io with organisation selected

Firefox on try.gitea.io with organisation selected

Are there any javascript errors when you press F12 and open Console tab?

@lafriks I'm not a IE user, but from what I see I would say there is no obvisious error in the console:

Short investigation ...
Firefox:

Internet Explorer:


test: increase boot timeout to 600 seconds

Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please


Update request

I was looking for some way to add keynote a plugin and came across this repo, may I ask that if you will continue on this work or not?

It's not actively maintained. Also, it only documents the on-disk file formats, which doesn't say much about how you could build (live) extensions for the apps.
On Mon, Sep 26, 2016 at 3:42 PM, Open Source Kitty - 开源小喵 Arith<EMAIL_ADDRESS>wrote:
I was looking for some way to add keynote a plugin and came across this repo, may I ask that if you will continue on this work or not?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [https://github.com/obriensp/iWorkFileFormat/issues/6] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AAAjuxWJW6pDKvY2xqe3YrUyUVb5CdAyks5quEpXgaJpZM4KHErZ] .


Add CI Testing using Travis

setup travis.yml to automate testing.

Hello, I have set up the travis build pipeline of my fork to automate tests with the yml configuration as a pull request. If you log into travis it should allow you to click the repo thus starting the worker builds 👍

Purrs like a kitten. Fails like the deathstar, too. But that's ok. ;)


welcome screen skipped

hello
goneovim creates new empty file, and shows it instead of noevim's welcome screen
how can i see welcome screen on startup?

:help :intro

:help :intro

oh, why after i opened :help :intro, the welcome screen stopped skipping?
i think it's weird

Please read the explanation in the intro carefully.

When Vim starts without a file name, an introductory message is displayed.  It
is removed as soon as the display is redrawn.  To see the message again, use
the ":intro" command.  To avoid the intro message on startup, add the "I" flag
to 'shortmess'.

i never touched the shortmess flag
i was confused by the fact that when i just ran nvim, the welcome message was shown, but when i ran goneovim it didn't
now after i open :help :intro the message is shown as it should
i think it should always be shown, out of the box, without having to open :help :intro

is this the message you saw?
https://github.com/flathub/io.neovim.nvim/blob/master/neovim-first-run.txt
In this case, it is a message that is displayed only for the first time due to the mechanism unique to the flatpak package.

is this the message you saw?

no, i mean this (pic from google)

Fixing this will require a fix on the Neovim mainframe side.

@akiyosi, but why now i can see welcome message in goneovim after i open :help :intro

@akiyosi, but why now i can see welcome message in goneovim after i open :help :intro

This is because the Welcome content is drawn on the "normal" grid, not on the global grid, when the user explicitly executes the command to display it.

it's weird but ok

I would like to keep this issue open, as it is possible that there are others who care about this issue and it would be better to have it fixed.

It seems that the Neovim core supports that feature.
Related:

https://github.com/neovim/neovim/pull/24764
https://github.com/neovim/neovim/issues/24705


Unable to run the code

Hi I'm trying to clone and run this code but I facing some issues.
after build the code and when try to run it navigate to 404 route CHANGEIT#/login
and I also tried to run the development mode it also navigates to this URL but showing 404 error page http://localhost:4200/#/login
NodeJs version : v14.21.3

so do I

Same here....

To start ONLY the design-studio, you have to:

go to http://loalhost/
add on the local storage the key 'tiledesk_token' with your tiledesk auth token
go to  http://loalhost/#/project/<project_id>/chatbot//blocks

Design Studio can't start independently from Tiledesk solution, so you have to previously made some kind of authentication.
Please let me know!


I have a problem SpeedRx=(3.21949e+10-3.21949e+10)/1

Hello,
I have a problem during client launch
(root@FC02) (/home) # ./serverstatus-client.sh
Connected.
./serverstatus-client.sh: ligne 121: let: SpeedRx=(3.21949e+10-3.21949e+10)/1 : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est ".21949e+10-3.21949e+10)/1")
./serverstatus-client.sh: ligne 122: let: SpeedTx=(1.45228e+11-1.45228e+11)/1 : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est ".45228e+11-1.45228e+11)/1")
./serverstatus-client.sh: ligne 121: let: SpeedRx=(3.2195e+10-3.21949e+10)/1 : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est ".2195e+10-3.21949e+10)/1")
./serverstatus-client.sh: ligne 122: let: SpeedTx=(1.45229e+11-1.45228e+11)/1 : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est ".45229e+11-1.45228e+11)/1")
./serverstatus-client.sh: ligne 121: let: SpeedRx=(3.21952e+10-3.2195e+10)/1 : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est ".21952e+10-3.2195e+10)/1")
./serverstatus-client.sh: ligne 122: let: SpeedTx=(1.45229e+11-1.45229e+11)/1 : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est ".45229e+11-1.45229e+11)/1")
( My debian is language french )
Thanks, !

Could you run these two commands and post the output:
grep ":" /proc/net/dev | grep -v -e "lo" -e "tun" | awk '{a+=$2}{b+=$10}END{print a,b}'
grep ":" /proc/net/dev | grep -v -e "lo" -e "tun" | awk '{a+=$2}{b+=$10}END{printf "%s %s", a,b}'

Hello,
3.40579e+10 1.52567e+11
awk: not an option: -M

Okay, I guess your awk isn't recent enough for -M (--bignums).
You can try without, should be fine as long as the number doesn't become too big:
grep ":" /proc/net/dev | grep -v -e "lo" -e "tun" | awk '{a+=$2}{b+=$10}END{printf "%s %s", a,b}'

3.476e+10 1.55714e+11(
Screen commande ssh : http://prntscr.com/apr2fb

I can't reproduce this on my system actually.
Could you try again but do this before:
export LC_NUMERIC="C"
maybe this one changes the behaviour too?:
export LC_COLLATE="C"

I change it to any place?
Sorry, I do not understand English very well I'm french.

Just do:
export LC_NUMERIC="C" export LC_COLLATE="C"
and try if it works after that.

I stumbled upon this same issue.
Seems that this is issue where bash version doeant support arithmetic calculation. I can confirm about this because I have 2 servers running Debian 7 and Ubuntu 12.04 and both have bash version 4.2.xx as the latest version. Whicle my another debian 8 and ubuntu 14.04 have version 4.3.xx
So the solution is to use python, or upgrade bash version to 4.3.xx


custom.yaml improvements

I think there's a lot we could add to the custom.yaml. The question though, is what should be in the custom.yaml vs what should be in the global.yaml or lab.yaml, etc.
I thought some that could be added were "bridgename" and "primarysubnet"

Latest commit adjusted the deployment to be a custom.yaml variable rather than separate Vagrantfiles.

Looks like the latest version of the custom.yaml structure is:
---
wheredir:
deployment:
extra:
libvirt:
  cpus:
  memory:
  machine_virtual_size:
network:
  bridgename:
  nameserver:
  primarysubnet:
  secondarysubnet:

We also have a templated version in the vagrantfiles/ directory with explanations of each of the variables.
I'm going to go ahead and close this for now, since it's a pretty general/vague issue. If there's something in particular we'd like to add later then we can always open up a new issue.


test sysbench.py  flag with "direct"

The sysbench.py  flag is currently hard-coded with "dsync", and this is to test with the "direct" flag.

A parameter for this has been added:
file_extra_flags: dsync

The value can be "dsync" or "direct"

My fork if the changes are merged have way more options than that @bxu1999. The other problem is that the sync flag although honored by the python script does not honor the other flags (async and 0) that you have in the template file.


Feature/better simple classes

This should be safe to merge in any case. Generate better test cases.
The .gitignore addition is for my convenience ;)

Current coverage is 93.02% (diff: 100%)

Merging #119 into master will decrease coverage by 6.97%

@@           master       #119   diff @@
========================================
  Files           8          8
  Lines         502        502
  Methods         0          0
  Messages        0          0
  Branches      110        110
========================================
- Hits          502        467    -35
- Misses          0         31    +31
- Partials        0          4     +4

Powered by Codecov. Last update 6771640...eb09303

There, easily fixed. I really do prefer the one-line version when the comment is short-ish and fits on one line though.

Googling around, I added the rule to the global gitignore file (~/.config/git/ignore). Problem fixed forever.


Hijack JSON export functionality

Description of PR

What component(s) does this PR affect?

[ ] Back-End (Database, Detection/Configuration/etc. Microservices)
[X] Front-End (Flask, API, UI, etc)
[ ] Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
[ ] Docs
[ ] Build System

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Database, Detection/Configuration/etc. Microservices)
[ ] Front-End (Flask, API, UI, etc)
[ ] Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
[ ] Docs
[ ] Build System

Related Issue

Resolves #257 #446
Solution

Simple functionality addition in hijack details page.
Type

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[X] I have read the contributing guide and my code conforms to the guidelines.
[X] This change requires a change in the documentation.
[X] I have updated the documentation accordingly.

Note that the 2 remaining travis checks https://travis-ci.org/github/FORTH-ICS-INSPIRE/artemis/builds/755924698 will be restarted after the pull limit on docker is reset.

Note that the 2 remaining travis checks https://travis-ci.org/github/FORTH-ICS-INSPIRE/artemis/builds/755924698 will be restarted after the pull limit on docker is reset.