Add additional configuration sources for the WebHostBuilder in the WebApplicationFactory

Is this a Bug or Feature request?:
Feature request.
Description of the problem:
There are some situations where users have manifested the desire to configure some aspects of the app for testing purposes through environment variables and other mechanisms.
We normally recommend overriding ConfigureWebHostBuilder to do these types of changes, but there are a couple of opinions that the WebApplicationFactory makes about what environment the app is using and where the content root is found from.
In both cases, these pieces of data are defined statically in code.

In the default setup of the WebApplicationFactory for the environment the tests run on.
In the WebApplicationFactoryContentRoot attributes for the content roots of the app.

I've discussed this with a bunch of people and we want to switch to a system based on config to allow these things to be configured based on the environment. This way, these settings that the factory needs to correctly boot up the project can be defined when the tests are going to run in addition to at compile time without users customizing the factory.
Proposed changes

Add an additional step to WebApplicationFactory to add additional configuration sources to the webhostbuilder we create.
Switch from custom implementations for determining the content root and the environment to run on to use config.
Provide three additional configuration sources in the appropriate order:

Static config source. Maps our attributes to config keys and defaults the environment to "Development"

Environment variables provider. Maps environment variables with a prefix ASPNETCOREINTEGRATIONTEST
Optional json file appSettings.integrationtests.json to allow these things to be specified on a json file.

Any new customization that needs to be added for testing purposes will be done this way.

@javiercn, please assign cost to this issue.

This sounds very interesting...I recently had to this to configure the InMemoryEmail provider for test purposes.
        protected override IWebHostBuilder CreateWebHostBuilder()
        {
            var assemblyPath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
            return WebApi.Program.BuildWebHost(null)
                                 .ConfigureAppConfiguration(builder => builder.AddJsonFile($"{assemblyPath}/appsettings.testing.json"));
        }

And I thought this was simple enough and still ensures the host setup runs exactly like it would in prod.


Run e2e tests inside a docker-compose stack

Fixes

Related to and blocks #1017 by @sarayourfriend
I originally started working on this directly in the same PR to address #1017 but decided to split this work out and apply it to the existing e2e tests to minimize the scope of the visual regression testing PR.
Description

Note about the line count for this PR!
The vast majority of those changes are in the updated tapes due to the sudden introduction of Brotli compression halfway through developing this. The main places to focus reviews on are the following:

playwright.config.ts
docker-compose.playwright.ts
proxy.js

Rationale
In order for visual regression tests to run in docker (to alleviate cross-platform rendering differences causing false-positives in the snapshot tests) we need to be able to have the full playwright stack working in docker due to networking complications.
Because our app is SSR and client side rendered, there are two contexts in which API requests are made:

In the SSR application
In the docker contained headless browser that is being controlled by playwright

If we just run playwright inside of docker, then we run into an issue where our API url has to be different for the client and the server, because the server will be on the host network and can use localhost, whereas the client will be in the docker network and will need to use something like host.docker.internal. This complicates the code and also makes debugging difficult.
Solution
To fix this, we run everything inside a single Playwright docker container so that they all share the same network and (crucially) can communicate over plain old localhost. Without being able to use localhost (i.e., relying on docker-compose networking) we can lots of weird SSL errors with the browser automatically redirecting requests to places like http://web or http://api to https. These fail because we don't have SSL set up locally.
Instead, I discovered that Playwright actually has built into it the ability to run and wait for a server to start! This means we can run the talkback proxy and the Nuxt server all inside the same container as Playwright, still get the benefits of the Playwright container's browser, all without the hassle of setting up local SSL for everyone trying to run the e2e tests locally.
The only snag here is that writing new tapes from talkback needs to have some permissions juggling fixed for Linux. Apparently this is a non-issue on macOS and Windows because the volumes are shared in a different way, but on Linux files written by docker containers into the host will all have root permissions. To fix this, we can just run chmod on them after updating the tapes. To prevent having to run a sudo script inside our package.json, I chose to just use the node:alpine image to run chmod as the image will already be present on your machine if you run the e2e tests because it's used as the base image for the running Nuxt app. I think we could also use the Playwright image but we need to interpolate the Playwright version to avoid downloading extraneous versions and node:alpine doens't have that problem.
I had to use npm-run-all because pre/post scripts in npm do not run if the main script fails, so if you try to update tapes and the tests don't pass, then the permissions fix won't run. npm-run-all with the --continue-on-error flag set will run all the scripts in sequence even if one of them fails while also still producing a non-zero exit code if any of the scripts produce non-zero exit codes.
Meta commentary about the PR
There are a few long caveat laden comments that needed to be added to explain everything that was going on, specifically with a few edge cases here and there. If when reviewing you find any other places that need clarification, don't hesitate to ask me to add more comments. Given the complexity and depth of this change I think more explanatory comments are best, for our own sanity's sake down the line when we're trying to understand how this all works again.
I actually think that the solution I landed on is ultimately simpler than the solutions I explored along the way. For example, this still uses docker-compose to run the Playwright container, but that's mostly just so that we don't have to stuff all the options into a long docker run line.
Related fixes
Because I was debugging all sorts of broken https requests, I was carefully inspecting the tapes and requests being made by the frontend. I discovered that the thumbnail routes were not being proxied. This PR also fixes that (hence the enormous number of new tapes being added).
Halfway through working on this I ran into an issue where some responses that were being recorded by talkback when updating/creating new tapes were compressed. Talkback, for some reason, doesn't decompress them for you. That's fine because zlib is built into Node anyway and we can easily decompress and recompress responses. I don't know why we didn't run into this previously but as I mentioned in the comment in proxy.js I think it's actually good that we're dealing with it because it more closely mirrors the situation in production.
It does, however, raise the question of why some responses aren't Brotli compressed and others are.
In light of @obulat's existing PR to fix up some of the tape generation logic in https://github.com/WordPress/openverse-frontend/pull/1045 we can hold off on merging this PR until her changes are in. I think it'll be easier to merge in her changes to this PR than the other way around. @obulat feel free to correct me if you think the other way will be easier! I'm not sure if your PR is running into the same Brotli compression issue I ran into with this one, but if so then the other way around (merge this first then rebase the other branch) might be easier. I will leave that up to you though, Olga.
Testing Instructions

Checkout this PR and run pnpm test:e2e and pnpm test:e2e:update-tapes and ensure that they work (i.e., that talkback responses are being used/created, file permissions are set correctly, etc). Also try pnpm test:e2e:debug with and without a local Nuxt server running. Both should work. pnpm generate-playwright-tests is unaffected, but I renamed it in anticipation of visual-regression being added and the generate script no longer being specific to just "e2e" tests.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I've gotten very far with this. I think the final issue that remains is to fix the various SSL errors that happen. You can see these by modifying the playwright.config.js to include use: { trace: 'on' }, extracting the trace.zip created in test-results and opening the trace.trace file. Search for https and you'll find several requests to both https://api:3000 and https://web:8443. I'm not sure what is causing this to be honest but I ran into it with the visual regression PR I was working on as well.

This PR is so close. Now just dealing with file permissions issues.
Locally I can't reproduce this. If I change the playwright container to not run using the pwuser user I get different errors locally about npm not being able to access some log ifles:
openverse-frontend-playwright-1  | [WebServer] glob error [Error: EACCES: permission denied, scandir '/root/.npm/_logs'] {
openverse-frontend-playwright-1  | [WebServer]   errno: -13,
openverse-frontend-playwright-1  | [WebServer]   code: 'EACCES',
openverse-frontend-playwright-1  | [WebServer]   syscall: 'scandir',
openverse-frontend-playwright-1  | [WebServer]   path: '/root/.npm/_logs'
openverse-frontend-playwright-1  | [WebServer] }

I'll dig into this Monday. For now I'm just glad to have gotten this far and have everything working and running properly locally!

In the end it seemed like there was no viable solution for running the scripts with npm due to npm's rather obstinate log placement situation.
Turns out it was trivial to just build our own image based on the playwright one we needed and install pnpm in there to allow us to run everything with pnpm. So then even though we still need to run everything in the container as root (in order to allow the container to write the build to the action workspace, though why this problem doesn't present locally on my machine is beyond me) we don't run into the issues with npm inside the container trying to write logs to a directory outside the mounted volume scope (the action runner's /root directory). npm does not allow configuring the log output location so it's basically a moot point whether or not to use it.
Building our own image that installs pnpm does add some extra time to the final e2e run but it's negligible compared to the time spent building the Nuxt app inside the playwright container. If we wanted to cut that time (or rather amortize it) we could publish an image to our GHCR whenever we update the Playwright version in the pnpm-lock.yaml. It could be a nice way to not have to pull the playwright version from pnpm ls to interpolate it locally or in the CI but, again, it's honestly a negligible amount of time that is spent building that base image.

@obulat you need to run pnpm install before running pnpm test:e2e. We could add it as a pre-script for test:e2e like we do for dev if that would be helpful.

@obulat you need to run pnpm install before running pnpm test:e2e. We could add it as a pre-script for test:e2e like we do for dev if that would be helpful.

Oh no! I was just following the testing instructions, and didn't realize that there was a new package that should be installed locally :) I guess it would be nice to add pnpm install pre-script.
I couldn't run the tests in the beginning, and had to increase the timeout. Then, the tests run well, and at the end I can see a piece of an error like this:
 ⠿ Container openverse-frontend-playwright-1  Stopped                                                                                0.0s
ERRO[0209] 0

I guess it is caused by --abort-on-container-exit, and that's why we use the exit code from playwright, right? --exit-code-from playwright

I guess it is caused by --abort-on-container-exit, and that's why we use the exit code from playwright, right? --exit-code-from playwright

I think this can actually be removed now as we don't have multiple containers :thinking: I'll see if it's possible to remove it. The ERRO[0209] 0 output is confusing. The last number is the exit code. I'm assuming the number inside the brackets is a PID or something. It's just confusing that it always uses ERRO at the start even if the process exited with a non-zero exit code :roll_eyes:

@obulat I tried to use docker-compose ... run playwright but ran into all sorts of weird issues with nuxt's build lock file not getting cleared for some reason! Switched back to up and it works perfectly :shrug:

Getting Brotli related errors in my attempts to test this:

Full terminal output
front on  try/e2e-docker +/- [$] via  v16.13.0
❯ pnpm test:e2e

><EMAIL_ADDRESS>pretest:e2e /Users/zackkrida/Code/openverse/front
> pnpm install

Lockfile is up-to-date, resolution step is skipped
Already up-to-date

><EMAIL_ADDRESS>prepare /Users/zackkrida/Code/openverse/front
> husky install

husky - Git hooks installed

><EMAIL_ADDRESS>test:e2e /Users/zackkrida/Code/openverse/front
> cross-env PLAYWRIGHT_VERSION=1.17.1 TEST_TYPE=e2e docker-compose -f docker-compose.playwright.yml up --abort-on-container-exit --exit-code-from playwright

WARN[0000] Found orphan containers ([front_web_1]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
[+] Running 1/0
 ⠿ Container front-playwright-1  Created                                                                                0.0s
Attaching to front-playwright-1
front-playwright-1  |
front-playwright-1  | ><EMAIL_ADDRESS>test:e2e:local /app
front-playwright-1  | > playwright test -c test/e2e
front-playwright-1  |
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.272Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-106.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.280Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-107.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.397Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-114.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.471Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-117.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.595Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-121.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.708Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-125.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:43.962Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-13.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:44.673Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-15.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.234Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-175.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.253Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-179.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.297Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-180.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.311Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-181.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.413Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-185.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.428Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-186.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.439Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-187.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.623Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-190.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.723Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-21.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:45.759Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-24.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:46.021Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-30.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:46.470Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-42.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:47.053Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-58.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:47.056Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-59.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:47.074Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-60.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:47.089Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-61.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:47.340Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-68.json5 Unsupported content-encoding br
front-playwright-1  | [WebServer] 2022-03-14T14:37:47.370Z [Openverse e2e proxy] [ERROR] Error reading tape test/tapes/response-70.json5 Unsupported content-encoding br

@zackkrida that's a talkback error: https://github.com/sarayourfriend/talkback/blob/7226f9c24ad78957575750cc39a3b17787270602/src/utils/content-encoding.ts#L39
Just need to update to the most recent version of talkback since my PR to add Brotli support was merged upstream: https://github.com/ijpiantanida/talkback/releases/tag/v3.0.1

@zackkrida Ready for re-review.

@zackkrida I'm going to push another commit to solve an issue with duplicate tapes that @obulat pointed out to me. Should be pushing it within the next hour or so.

@obulat What command did you use to run the debug? pnpm test:e2e:debug? It looks like somehow the tests were run without a TEST_TYPE for one of the docker-based approaches... :thinking:

but only if I increase the timeout in playwright.config.ts

I'll increase the timeout to five minutes I think.

@obulat I tried running pnpm test:e2e:debug locally and it worked fine for me :confused: Unfortunately we can't reuse the docker approach for debugging tests because docker would need to connect to a running Xorg server to be able to display the headed browsers.... and configuring that just for one OS is hard enough, making it cross platform to macOS, Linux, and Windows (even with WSL) would require a lot of work. Maybe one day we can tackle that but for now test:e2e:debug's approach is the only way :disappointed:

@zackkrida can you re-review today if you have time? I'd like to merge this to avoid any more merge conflicts. Thanks!

@krysal Would you be able to review this when you have a chance?


Horizon.authEndpoint('provider') should include the host name

I was working with a local Horizon instance, and a remote Horizon instance. I was connected to the remote instance as follows:
Horizon({
    host: 'my-host.io',
    secure: true,
    authType: 'token'})

As the documentation suggest, I called the following to redirect my browser to the OAuth endpoint (from the Horizon server):
horizon.authEndpoint('github').subscribe(endpoint => location.pathname = endpoint)

I received an endpoint, in this case /horizon/github. However, since I was serving my project from the local Horizon instance, my browser redirected to http://localhost:8181/horizon/github, when I really wanted it to redirect to http://my-host.io/horizon/github.
This was particularly confusing because it ended up using tokens and the Horizon config set up in my local instance for the OAuth flow, when I indicated that my Horizon connection was to a
remote host.
It would be easier and less error-prone if the client includes the host parameter in the endpoint it returns.

The docs would have to be updated to suggest using location.apply (which replaces the entire location string) rather than simply location.pathname (which will just update the pathname, not the host).

This was done


Fix BBC BASIC so that it has a logical screen map, origin bottom left

As an Agon programmer
I want to be able to type in existing BBC BASIC programs with graphics commands
And for them to scale / display correctly
Acceptance Criteria:

Origin: Bottom left of screen
Scaling: 1280 x 1024 -> Screen Resolution

Suggestions: Maybe select VDP scaling/origin behaviour via a VDP sequence?

VDU 23, 0, 192, n: Switch logical coords on/off - n: 0=off, 1=on (default)


Proposal for a 5-Star system for mappings

@cmungall @cthoyt @dosumis Please take a look

Here's the link for viewing this document rendered on GitHub https://github.com/mapping-commons/SSSOM/blob/minimum-metadata/SSSOM.md#minimum @matentzn maybe you can include that in the description at the top

@cthoyt thank you for all your feedback on this, operationalising the tiers is a great idea. I would suggest we propose the system first, and then implement an sssom report method in sssom-py which basically checks "tier adherence". See https://github.com/mapping-commons/sssom-py/issues/112

I think I dealt with most of your feedback;
Some of your suggestions about clearer descriptions of the elements need to be done separately on the SSSOM metadata itself.

@cthoyt after a lot of back and forth in my head, I still don't dig the "tier" notion. I would like something that

implies quality: 1-star mappings are bad, 5-star mappings are good (like in linked data) - tier is a bit too neutral for my liking. The "good" and "less good" should really scream from the name
that is commonly understandable - the word should mean something "publishing tier 3 mapping" means little to normal folks

I would suggest we go back over that point. Can you describe again what your problem with the star notion is, and if the problems are valid, maybe something more suitable as an alternative?

@matentzn if your goal is to imply 1 is bad and 5 is good, then I think keeping the "star" nomenclature is actually a good fit. Just keep in mind that it makes it a bit more rigid - if we want to add an additional 6th level later, it will seem very strange (I expect star systems to strictly be out of 5 or 10)

Thank you.. I dont expect any more levels.. If anything, clarifications on the existing ones.


Edit existing roles

Should be a way to edit a role and have the change propagated throughout the db. ie: change the name and all users with that role will have their roles updated with the new name. If there is I missed it.

Good idea, this should be part of the package.  In the meantime, I've published the script that we use to rename roles:  https://gist.github.com/alanning/7aeac128f065e4571095

Hello, so is there a solution for editing roles?
e.g. I want to add a description field for every role?

Still need to use the provided script to rename roles.  Adding descriptions for roles is out of the scope of this package at the moment.  To implement that, we'd have to also implement i18n which we've been able to successfully avoid so far.  :-)

Adding description field can be easily added by adding your own fields to the Meteor.roles collection. The package itself is not really using many fields, so you can feel safe adding your own extra information to it.
Although, for description I would rather suggest that you use a package like tap-i18n. Then you use role name as a key into the translatable description. So no need to store description in the database. You just convert it at runtime.
But if you want to store some user-specified description, just use Meteor.roles.

Renaming of roles available in the v2.0 branch.


Password Generator

Description
Python code for a simple CLI password generator in which you enter the length of the password you'd like to generate (Minimum 8) and it creates a strong random password containing symbols, capital letters, regular letters, and numbers.
Technologies and Languages
Python

Hi @bislara would you please merge my PR or tell me if you need any more modifications or clarifications.

hey @ShivamPande18 , I have already reviewed the PR. Please check the comments and make the changes if required.


feat(OCPADVISOR-123): filter configs filter slice and constants

https://issues.redhat.com/browse/OCPADVISOR-123

Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.

Files
Coverage Δ

src/Services/Filters.js
90.90% <33.33%> (-9.10%)
:arrow_down:

src/Components/Common/Tables.js
83.91% <0.00%> (-4.98%)
:arrow_down:

... and 1 file with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.

:tada: This PR is included in version 1.22.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Documentation/full Docstring for basic numpy/pandas absent in VSC Jupyter notebook.

The standard Jupyter Notebook browser interface provides detailed information when hovering (see image below), but in VSCode the straightforward documentation is absent. In my attempts to find a solution, I see that this has been a recurrent issue and might be related to Pylance?? If I need to edit my .json settings, which looks like it might be a solution for some people, I could use some basic instructions on how to do so.
Environment data
Pylance: v2022.7.20
Pylance language server 2022.7.20 (pyright 7cadfb74)
OS and version: Monterey v12.4
Python version: 3.9.12
I use multiple IDEs depending on the project, some with v2.7.18 or v3.7.13, but the issue is consistent.
Expected behavior (pulled from another issue)

Actual behavior

@deem-lab, we'll need more complete sample code to be able to repro this. With imports and versions of imported libraries.

Closing old issue. If this is still a problem, please reopen with the information requested. thanks


UI controls / grid not scaling with window size on Linux.

Hello!
I recently started working on a project using Avalonia and I've run into a issue I can't seem to figure out.
No mater what size the window is, the elements of the user interface are positioned in the same place with the same size.
I did not define a width or height to the grid used for aligning controls. I have tried assigning the width and height "auto" and "*" and neither of these worked either.
I also tried configuring various min/set/max sizes for the width and height for the window. The window size would change but not the grid or its contents.
Here is a screenshot of the program running:

And here is a link to the XAML file on GitHub:
https://github.com/BrandonEugeneWalker/Click-d-Core/blob/master/ClickdCore/Views/MainWindow.xaml
I'm not sure if this is an issue with Avalonia on Linux or if it is an issue with the XAML code so I thought I would ask here.
Edit:
Pop!_OS 20.04
.netcore3.1
Avalonia 0.9.9

Width="Auto"  means the column is measured with minimal required space. It is not taking available space. Use Width="*"  to measure against available space and allow the control to take all that space.

Width="Auto"  means the column is measured with minimal required space. It is not taking available space. Use Width="*"  to measure against available space and allow the control to take all that space.

Thanks for the tip! I had not thought to try * on the definitions.
I tried that out and the result was the same, any other suggestions? I do appreciate it.

You are using HorizontalAlignment="Left" on your controls instead of Stretch. So again everything gets measured against minimal required space and isn't taking available space.

You are using HorizontalAlignment="Left" on your controls instead of Stretch. So again everything gets measured against minimal required space and isn't taking available space.

Swapping centered for stretch on the grid fixed the issue, thanks!

Spoke too soon, the issue was fixed on my Windows VM but not on the Linux machine.

Here is a screenshot of the Windows VM results:

The appearance on the Linux machine is the same as the original screenshot. Clean and rebuild changed nothing.


Unable to view Admin at localhost:8001

Really like the direction of your project. I do however have one question. When I install StreamMachine and execute the command  ./streammachine-cmd --config ./config/standalone.json from within the repository directory, I'm unable to view the admin at http://localhost:8001/admin within the browser. Instead, it says "invalid stream". Is there something I'm doing wrong. Your feedback or anyone else's is greatly appreciated.
Thanks

That's because it's gone! It got yanked in f5647761deb611d7a98f1eca384dac1eaa5ab26e in favor of just fleshing out the API endpoints. The UI side hadn't been keeping up with underlying changes, and added a large dependency stack to the project. In standalone mode, your API endpoints should be available under /api, so /api/streams, etc. There isn't currently API documentation, but if you take a look at this code I would hope that it is largely self-explanatory:
https://github.com/StreamMachine/StreamMachine/blob/af8d5fea13ac72cb627f7b292b640111144fd9f5/src/streammachine/master/admin/api.coffee#L58-L189
Where in the docs did you see that admin UI reference? I should update it.
I would definitely be open to recreating the admin UI as a separate project. In our day-to-day operation, though, it didn't turn out to be super-useful: how often do you end up updating your stream settings in production?

 I probably should have asked this question under the StreamMachine cookbook repository, that's where I saw the reference to the admin UI. You can find it directly under the section titled "Vagrant". Instead of using the cookbook I tried to set up the same on my local machine.
https://github.com/StreamMachine/streammachine-cookbook
Regarding using stream settings in production, I'm quite new to using nodejs to stream audio and I figured the admin would give me a better insight to how things work.

Thanks. I'll clean up those docs on the cookbook repo.
Feel free to ask any questions here as issues or email me directly. Docs are definitely StreamMachine's weakest point.


git-lfs: Upload never terminates, although file size already exceeded

Gitea Version
1.14.6
Git Version
2.31.1
Operating System
NixOS
How are you running Gitea?
I run gitea as set up by the NixOS module, that means built from source and set up as a systemd service.
Database
MySQL
Can you reproduce the bug on the Gitea demo site?
No¹
Log Gist
https://gist.github.com/schmittlauch/0b6f47c899daa277b4d9df7d2861fe97
Description
I added a new 6.5GiB large file to my git repo via git lfs and tried to push the repository to my gitea remote repository, either via git push or git lfs push.
The upload started normally. After a while I discovered though that far more data has already been uploaded than the file size is supposed to be:
$ git push mygit mainline
loading LFS objects:   0% (0/1), 9.2 GB | 5.0 MB/s

The point of time where the upload size exceeded the actual file size is around the time when the Error: unexpected EOF message has been logged in the gitea log.
The error happened reproducibly at several attempts, I always had to cancel the upload process manually.
The same repo – including the LFS files – has successfully been pushed to a GitLab server.
¹Due to the large file size, I did not attempt to reproduce this issue on try.gitea.io.

I have tested locally with 56362043d3 and cannot reproduce it.

What's your LFS storage configuration?

The configuration is nothing unusual. Excerpt:
[server]
DISABLE_SSH=false
DOMAIN=git.orlives.de
HTTP_ADDR=<IP_ADDRESS>
HTTP_PORT=3000
LFS_CONTENT_PATH=/srv/git/lfs-data
LFS_HTTP_AUTH_EXPIRY=120m
LFS_JWT_SECRET=s98dH5q8f4szeTw9EN8WQVVmD3VluKwzCFcmdbe1pOM
LFS_START_SERVER=true
OFFLINE_MODE=true
ROOT_URL=https://git.orlives.de/
SSH_PORT=2342
STATIC_ROOT_PATH=/nix/store/gmdwyjgfld7vvw678x3f1q2ccx97g0h9-gitea-1.14.6-data

[service]
DISABLE_REGISTRATION=true
ENABLE_NOTIFY_MAIL=true

[session]
COOKIE_NAME=session
COOKIE_SECURE=true
PROVIDER=file

It might be worth a note that the gitea instance runs behind an http2-enabled nginx reverse proxy. client_max_body_size is set to 0, that shouldn't be an issue.

I encouter this problem today.
And at last I fixed this problem by change nginx config to enlarge keepalive timeout.
keepalive_timeout = 100;

I am experiencing a similar issue, again from behind a nginx proxy running in k8s. I see messages similar to these repeating in the gitea logs during upload:
2022-10-15 09:36:19
kube02 .. 2022/10/15 14:36:19 ...rvices/lfs/server.go:323:func1() [E] [634ac543] Error putting LFS MetaObject [f8eaf0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64] into content store. Error: Put "https://s3.kube/gitea/lfs/f8/ea/f0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64?partNumber=11&uploadId=2~DD9lkoTTgIbOLrtJBMIvRdhPLy7rpbz": Connection closed by foreign host https://s3.kube/gitea/lfs/f8/ea/f0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64?partNumber=11&uploadId=2~DD9lkoTTgIbOLrtJBMIvRdhPLy7rpbz. Retry again.

2022-10-15 09:36:19
kube02 .. 2022/10/15 14:36:19 ...lfs/content_store.go:75:Put() [E] [634ac543] Whilst putting LFS OID[f8eaf0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64]: Failed to copy to tmpPath: f8/ea/f0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64 Error: Put "https://s3.kube/gitea/lfs/f8/ea/f0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64?partNumber=11&uploadId=2~DD9lkoTTgIbOLrtJBMIvRdhPLy7rpbz": Connection closed by foreign host https://s3.kube/gitea/lfs/f8/ea/f0b805e3094682da668f1097ccd98deec35240c677c2089cb486d69f0b64?partNumber=11&uploadId=2~DD9lkoTTgIbOLrtJBMIvRdhPLy7rpbz. Retry again.

The message in Gitea obviously looks like it is a bad nginx configuration but for the life of me I cannot replicate outside of Gitea. When. I upload the files I'm failing to add via LFS  through the same proxy everything works perfectly:
aws --profile=ceph --endpoint-url=https://s3.kube --recursive s3 cp binaries s3://datapull/tmp/
upload: binaries/nifi-toolkit-1.18.0-bin.zip to s3://datapull/tmp/nifi-toolkit-1.18.0-bin.zip
upload: binaries/nifi-registry-1.18.0-bin.zip to s3://datapull/tmp/nifi-registry-1.18.0-bin.zip
upload: binaries/nifi-1.18.0-bin.zip to s3://datapull/tmp/nifi-1.18.0-bin.zip

I fix it by changeing the ROOT_URL , SSH_DOMAIN, DOMAIN ti my local ip in app.ini file.

I encountered the same issue.
I use btrfs, and use beesd to dedup in the background.
I solved the issue by temporarily stop beesd.

Thanks @stevapple , that fixed the problem for me! Do we agree here that the problem is more with Git not producing a timeout error correctly (and continuous sending of 'some' data)?

Do we agree here that the problem is more with Git not producing a timeout error correctly (and continuous sending of 'some' data)?

It‘s more of a problem of Gitea’s LFS implementation. Gitea collects the whole LFS object and then uploads it to S3. It should chunk the object and upload simultaneously instead.

This maybe the implementation of minio-go. Of course, Maybe we should deliver the size to minio-go. Then we need to change the method of contentStore.Put.


Branches with long names break Forge Deploy Preview

Problem
If a PR is opened on a branch that contains a name longer than 63 characters, the Forge Deploy Preview fails as the string is not shortened for the database name (though it appears to be shortened for the site domain name).
Solution
Shorten the database name the same way the site name is. This can likely be done by changing .substring(0, 64) to .substring(0, 63).
- .substring(0, 64)
+ .substring(0, 63)

at
https://github.com/bakerkretzmar/laravel-deploy-preview/blob/c04e09216fc48b895313139ff40f148bbe9a7dc1/src/lib.ts#L25
Additional information
Error output example:
Creating preview site for branch: 714-some-absurd-and-lengthy-branch-name-generated-from-github-issues.
Creating site: 714-some-absurd-and-lengthy-branch-name-generated-from-github-i.dev.app.glitchsecure.com.
{
  "database": [
    "The database field must not be greater than 63 characters."
  ]
}
Error: Forge API request failed with status code 422.

Related to: #22 and #32

Thanks!


Clean up LocalKeyStore and related

I introduced a bug in #3744 by injecting LocalKeyStore via Koin before the storage path is initialized. This PR cleans up LocalKeyStore and related classes, and they are now properly dependency injected.

I'll merge this for now because it breaks master for me. Feel free to fix the small dependency regression, suggest a fix, or leave as is.


sequence contains no elements

I got an error in this line as sequence contains no elements because I am using FromUri Model Binding.
When using FromUri Model Binding, duplicate items can appear as items can be passed as URI parameters or querystrings. In this case we can add a custom operation filter to remove the duplicates.
so we need to check duplicates.
see this

Could you please provide a small repo for this? Thanks in advance.

You can see this repo

In Addition, I need to define Route for all of APIs because swagger UI cannot track them.

In Addition, I need to define Route for all of APIs because swagger UI cannot track them.

That repo is using Bit 1.4
If you update it to Bit 1.5, web api's default routing mechanism will get back to work.
I'm gonna write a test for that. Then I'll merge your PR.
Thanks in advance.


Traffic ops Api - doesn't handle the invalid values for fallbackId gracefully.

Api version: 1.4
component: Traffic OPS
Scenario1:
Request:
/api/1.4/cachegroup_fallbacks?cacheGroupId=<> &fallbackId=!131
expected: invalid value - list accepted value type
Actual: refer to the screen shot

Scenario2:
/api/1.4/cachegroup_fallbacks?fallbackId=<<valid id>>
Expected: all the cachegroup that has fallback id associated with it ?!
actual:
{"alerts":[{"level":"error","text":"Invalid cachegroup id, should be an integer"}]}

as per the definition here -> https://traffic-control-cdn.readthedocs.io/en/latest/api/cachegroup_fallbacks.html#id3 the request expects atleast one of the two params.

fwiw that's not unique to cachegroup_fallbacks afaik. Any API endpoint that's still in Perl and calls into UI code (and there are a few of them) has the potential to do this.

This endpoint should be considered deprecated anyways in favor of the cachegroups API which supports fallbacks now.

I learnt from Jeremy that we are not using this endpoint. If its deprecated, may be we should update the documentation

well I think to "officially" deprecate something is a mailing list decision - can't leave it up to just the people that happen to see this issue.

while I understand that its a mailing decision, I think this ticket could be the trigger to initiate the process. If not, please do not hesitate to take next necessary steps.

The only next necessary step is just to send the email, I believe. Which has been done

thanks!


NOJIRA Update autocomplete query to set minimum should match

Before this change, our new suggestion queries were much higher recall than the version currently
running in FedRAMP, due to the fact that the default operator for match queries is or. The same
effect could be achieved by changing the operator to and, but for consistency with
catalog-service, I opted for setting the minimum_should_match parameter to "100%".

[x] styleCheck passes
[x] unit tests pass
[x] integration tests pass
[ ] manual tests pass
- [ ] API docs updated

Build failed.

Code looks good, not sure why the build is failing

retest this please

Build failed.

retest this please

This build looks good.


Manual use of macroRW on enum creates infinite loop

When moving to version 3.0.0, I get the following warning for
Starting compilation server
[warn] ./scripts/helper.sc:277:40
[warn] Infinite loop in function body

for this code:
given rwConfigType: ReadWriter[ConfigType] = macroRW, where ConfigType is defined as:

enum ConfigType:
  case Config, ConfigStructural, StateAppliedConfig, StateDerived, StateStructural, Unknown

, which I can confirm at run time that the compile warning is indeed correct ;-).
Deleting the given and adding a "derives ReadWriter" fixes the issue, but thought that it would be helpful to flag this.

Just had the same issue. Thanks for the workaround.

There's a problem with the user code, you should be using macroRWAll if you want to derive a readwriter for the parent enum type without manually deriving macroRWs for all the enum cases.
The error message is misleading, and can probably be improved


added docs, torquebox-configure support for TORQUE-627

This pull request adds documentation and torquebox-configure support for the profile_api ruby configuration option (TORQUE-627).

Merged smoothly, thanks!


Change the styling of hyperlinks

What
This PR changes the styling of hyperlinks, of which there are currently two:

The "Help" item in the menu. I changed it to behave just like a normal menu item does. On click, it'll always open a new tab, which is a departure from the current behaviour where opening in a new tab required a modifier (alt, etc.) or a middle-click. I believe this behaviour respects better the "rule of least astonishment" in the case of WASM builds. (For native build, it doesn't change anything.)
The link in the "About" panel. For this I just changed the style to use "normal" colour (ie. white), but keep the link behaviour (underline on hover).

[!WARNING]
The forced "new tab" triggered the popup blocker on my computer, so that maybe a motivation to stick with opening help in the same tab by default. Opinions?

Fixes #2733
Before:

After (mouse hovering on link, thus the underline):

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested demo.rerun.io (if applicable)

PR Build Summary
Docs preview
Examples preview

Nice! This link has an underline while the "help" link doesn't. I think we can skip the underline for this link. I also think we can drop the tooltip since it isn't adding any value.

@martenbjork Actually, do we want to keep that hyperlink at all? It's redundant with the massive "rerun.io" that's already on the title bar.

I'd be down to drop it! But the gigantic link present everywhere, even in the desktop app? If so, let's drop it!

Yep it is. Unless we want to drop that big link, then yeah, let's drop the link in the about.

All right good call! And I'll work on improving the design of gigantilink.

How do you feel about the "Help" behaviour. Currently it always open in new tab, which is inconsistent with the gigantilink, which needs a modifier and/or middle click for that. Because of the popup blocker thing, I'm leaning towards defaulting to same tab as well or "Help".

We should definitely make them consistent.

Same window

👍 Works just like any link on the web.
👎 Is there a risk of loosing work if you suddenly navigate away from the app?

New tab

👍 Works like any link on the web with target="blank"
👍 Allows you to keep working on "the thing you need help with"
👍 Won't disturb your workflow

I'd lean towards a new tab. Are you concerned about pop-up blockers? AFAIK, target="blank" in HTML is never blocked, but maybe it's different when triggered from WASM?

👎 Is there a risk of loosing work if you suddenly navigate away from the app?

Yes. Open https://demo.rerun.io, delete a space view (eg), click on the gigantilink, back, space view is there again. (Though maybe not always? Depends on the browser caching implementation?)

Are you concerned about pop-up blockers?

I got that on safari! I had to click and allow.

AFAIK, target="blank" in HTML is never blocked, but maybe it's different when triggered from WASM?

Need to figure out how/if we can do that from rust/wasm.

Apparently it's using _blank for new tabs. I'm unsure why the popup blocker triggered. Regardless, I still prefer default to tab because of the lossy behaviour otherwise. Especially with the "Help" menu item where the user might expect help to show up inside the app.

I'm unsure why the popup blocker triggered

The HTML standard says _blank opens a "new window", maybe that's why. Most browsers today interpret this as "new tab", but I think it's up to the browser vendor.

Regardless, I still prefer default to tab because of the lossy behaviour otherwise.

Agreed! 🚀

This might explain safari's behaviour: https://stackoverflow.com/a/2587692/229511
Basically Safari isn't aware of user interactions inside the wasm executable.

This might explain safari's behaviour

Ah, that makes perfect sense!

Note that the previous behaviour of opening in new tab with modifier/middle-click was also popup-blocked! One more reason to default to new tab.

Jikes, Safari is really nervous about those WASM links, eh? 😀

Jikes, Safari is really nervous about those WASM links, eh? 😀

Indeed. Both Firefox and Chrome seem better behaved by default. Leniency or better ability to detect user interaction? Who knows...


MenuItem React Warning "Unknown prop composeTheme"

Just started using react-toolbox and so far loving it as an alternative to react-bootstrap which I was using previously.
I did just run into an issue, though, with a prop warning from React.
Seems like it could be related to https://github.com/react-toolbox/react-toolbox/issues/607 or https://github.com/react-toolbox/react-toolbox/issues/606. I'm getting this same error with MenuItem.
warning.js:36 Warning: Unknown prop `composeTheme` on <li> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in li (created by MenuItem)
    in MenuItem (created by RippledComponent)
    in RippledComponent (created by ThemedRippledComponent)

react: 15.3.1
react-toolbox: 1.2.1
Let me know if posting my source would be helpful. Any ideas for workarounds in the meantime?

I have the same warning here,
The react-toolbox-example repository give the same warning.
Unfortunately I am a beginner so I can not really help.
node: v6.6.0
react: 15.3.0
toolbox: 1.2.1

Thanks @javivelasco 👍

No problem!!


FFM-7741: Adds git reset procedure

Link to preview

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Thanks @Kira-Jennings !


kubelet config file

I just noticed, running kubeadm init that --pod-manifest-path has been deprecated in favor of the kubelet's --config flag.
This feels like it might be an upstream thing where the kubelet package should be updated (maybe it's already under way). I want to track this somewhere since it's a deprecation warning. Feel free to close if this is not the right place for that.
Apr 30 18:22:32 ip-172-31-38-145 kubelet[3157]: Flag --pod-manifest-path has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ is the full message I saw.

We're going to need todo this long term, but can happily wait until config is beta+.

This is addressed in master.


#97

@rultor merge

@rultor merge

@driver733 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@driver733 Oops, I failed. You can see the full log here (spent 3min)
Results :

Tests run: 42, Failures: 0, Errors: 0, Skipped: 0

[\u001b[1;34mINFO\u001b[m]
[\u001b[1;34mINFO\u001b[m] \u001b[1m--- \u001b[0;32mjcabi-maven-plugin:0.14.1:versionalize\u001b[m \u001b[1m(jcabi-versionalize-packages)\u001b[m @ \u001b[36mVKMusicUploader\u001b[0;1m ---\u001b[m
[\u001b[1;34mINFO\u001b[m] jcabi-aspects 0.18/55a5c13 started new daemon thread jcabi-loggable for watching of @Loggable annotated methods
[\u001b[1;34mINFO\u001b[m] Versionalizing /home/r/repo/target/classes directory
[\u001b[0;37mINFO\u001b[m] org.hibernate.validator.internal.util.Version: HV000001: Hibernate Validator 5.1.2.Final
[\u001b[1;34mINFO\u001b[m] JSR-303 validator org.hibernate.validator.internal.engine.ValidatorImpl instantiated by jcabi-aspects 0.18/55a5c13
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/audio/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/wallpost/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/wallpost/wallposts/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/message/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/message/messagepart/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/fallback/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/basictag/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/advancedtag/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/wallpost/attachment/support/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/properties/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/post/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m] File /home/r/repo/target/classes/com/driver733/vkmusicuploader/post/posts/group-d----usic-ploader-jar.txt added
[\u001b[1;34mINFO\u001b[m]
[\u001b[1;34mINFO\u001b[m] \u001b[1m--- \u001b[0;32mmaven-jar-plugin:3.0.2:jar\u001b[m \u001b[1m(default-jar)\u001b[m @ \u001b[36mVKMusicUploader\u001b[0;1m ---\u001b[m
[\u001b[1;34mINFO\u001b[m] Building jar: /home/r/repo/target/VKMusicUploader-1.0-SNAPSHOT.jar
[\u001b[1;34mINFO\u001b[m]
[\u001b[1;34mINFO\u001b[m] \u001b[1m--- \u001b[0;32mqulice-maven-plugin:0.17.1:check\u001b[m \u001b[1m(jcabi-check)\u001b[m @ \u001b[36mVKMusicUploader\u001b[0;1m ---\u001b[m
log4j:WARN No appenders could be found for logger (com.puppycrawl.tools.checkstyle.ConfigurationLoader).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
[\u001b[1;34mINFO\u001b[m] Starting PMD validator
[\u001b[1;31mERROR\u001b[m] /src/test/java/com/driver733/vkmusicuploader/post/UploadVerificationTest.java[49-228]: This class has too many methods, consider refactoring it. (TooManyMethods)
[\u001b[1;31mERROR\u001b[m] /src/test/java/com/driver733/vkmusicuploader/post/UploadVerificationTest.java[97-97]: Document empty method body (UncommentedEmptyMethodBody)
[\u001b[1;31mERROR\u001b[m] /src/test/java/com/driver733/vkmusicuploader/post/UploadVerificationTest.java[172-172]: Document empty method body (UncommentedEmptyMethodBody)
[\u001b[1;31mERROR\u001b[m] /src/test/java/com/driver733/vkmusicuploader/post/UploadVerificationTest.java[189-189]: Document empty method body (UncommentedEmptyMethodBody)
[\u001b[1;31mERROR\u001b[m] /src/test/java/com/driver733/vkmusicuploader/post/UploadVerificationTest.java[206-206]: Document empty method body (UncommentedEmptyMethodBody)
[\u001b[1;31mERROR\u001b[m] /src/test/java/com/driver733/vkmusicuploader/post/UploadVerificationTest.java[93-93]: The String literal "Test" appears 4 times in this file; the first occurrence is on line 93 (AvoidDuplicateLiterals)
[\u001b[1;34mINFO\u001b[m] Read our quality policy: http://www.qulice.com/quality.html
[\u001b[1;34mINFO\u001b[m] \u001b[1m------------------------------------------------------------------------\u001b[m
[\u001b[1;34mINFO\u001b[m] \u001b[1;31mBUILD FAILURE\u001b[m
[\u001b[1;34mINFO\u001b[m] \u001b[1m------------------------------------------------------------------------\u001b[m
[\u001b[1;34mINFO\u001b[m] Total time: 12.498 s
[\u001b[1;34mINFO\u001b[m] Finished at: 2017-07-04T22:59:25Z
[\u001b[1;34mINFO\u001b[m] Final Memory: 45M/991M
[\u001b[1;34mINFO\u001b[m] \u001b[1m------------------------------------------------------------------------\u001b[m
[\u001b[1;31mERROR\u001b[m] Failed to execute goal \u001b[32mcom.qulice:qulice-maven-plugin:0.17.1:check\u001b[m \u001b[1m(jcabi-check)\u001b[m on project \u001b[36mVKMusicUploader\u001b[m: \u001b[1;31mFailure\u001b[m: 6 PMD violations (see log above) -> \u001b[1m[Help 1]\u001b[m
[\u001b[1;31mERROR\u001b[m]
[\u001b[1;31mERROR\u001b[m] To see the full stack trace of the errors, re-run Maven with the \u001b[1m-e\u001b[m switch.
[\u001b[1;31mERROR\u001b[m] Re-run Maven using the \u001b[1m-X\u001b[m switch to enable full debug logging.
[\u001b[1;31mERROR\u001b[m]
[\u001b[1;31mERROR\u001b[m] For more information about the errors and possible solutions, please read the following articles:
[\u001b[1;31mERROR\u001b[m] \u001b[1m[Help 1]\u001b[m http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 9c1023402d7d43034f8ec41f8c146d1fe8495f77b1dedf58731d2003fb544227 is dead
Wed Jul  5 01:00:36 CEST 2017

@rultor merge

@rultor merge

@driver733 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@driver733 Done! FYI, the full log is here (took me 2min)

Coverage increased (+2.4%) to 53.942% when pulling 230f668706b088405ba0f8e4419783eb62c4f1a7 on #97 into eb92d6729dbee21e04a5a4efd08d75c95d67bb5b on master.


Drop dependency from mruby-array-ext to mruby-enum-ext

Is this pull-request combine two changes in one?

Dependency on mruby-enumerator dropped at #4595. However, dependency on mruby-enum-ext which mruby-enumerator depends on remains, so this PR drop it.

You removed test dependency from mruby-array-ext and it's OK.
You replaced row.count to row.size in mrblib/array.rb which does not seem to related to test dependency.

It is not test code but main code that depends on mruby-enum-ext (Array#count is defined in mruby-enum-ext).
It just works accidentally when enable_test is specified because there is no distinction between test dependencies and normal dependencies in current implementation.
Example
$ MRUBY_CONFIG=<(echo 'MRuby::Build.new{toolchain :gcc; gem core:"mruby-bin-mruby"; gem core:"mruby-array-ext"}') ./minirake
$ bin/mruby -e 'p [[1,2]].transpose'  #=> NoMethodError: undefined method 'count'

I understand.


Vectorized logo + Coderwall badges

Re: issue #914

Vectorized version of the 24 Pull Requests logo added (.ai format)

Vectorized versions of the Coderwall badges added (.ai format, both in same file)

These should be pretty good replications of both the logo and badges in vector formats and files suitable for printing.

Brilliant work @designbyjake, thanks for doing it so quickly!
Cc @erikaheidi

That's amazing :)
--
Regards
Steve Robinson

On 09-Jan-2015, at 2:59 am, Jake Giltsoff<EMAIL_ADDRESS>wrote:
Re: issue #914
Vectorized version of the 24 Pull Requests logo added (.ai format)
Vectorized versions of the Coderwall badges added (.ai format, both in same file)
These should be pretty good replications of both the logo and badges in vector formats and files suitable for printing.
You can merge this Pull Request by running
git pull https://github.com/designbyjake/24pullrequests master
Or view, comment on, or merge it at:
https://github.com/24pullrequests/24pullrequests/pull/915
Commit Summary
Vectorized logo + Coderwall badges
File Changes
A design/24pr-logo.ai (6692)
A design/coderwall-badges.ai (6716)
Patch Links:
https://github.com/24pullrequests/24pullrequests/pull/915.patch
https://github.com/24pullrequests/24pullrequests/pull/915.diff
—
Reply to this email directly or view it on GitHub.

Wonderful, thanks @designbyjake, great job!


Wait for terminated state while destroying a cluster

This PR makes the following changes:

Add --no-wait option to destroy command with False default
destroy command waits for instances to be in "terminated" state  cluster.wait_for_state('terminated')

I tested this PR by manually launching and destroying clusters. I'm not sure about tests for this, should I add one to cover --no-wait option?
Fixes #229

Hey @alexandrnikitin, thanks for submitting this PR! After thinking about this a bit, I think it's fine to just change the default behavior to wait for termination. I'd do that right after here.
To explain my thought process, wait_for_state() is a method on the EC2 implementation of FlintrockCluster, so we shouldn't use it in the provider-agnostic code in flintrock.py or core.py. Instead of figuring out how to enhance the internal API to capture this new feature correctly and delineate between EC2-specific and provider-agnostic code, I think it's fine to just change the default behavior.
How long does the additional wait typically take for a 10-node cluster? If it's a long time, perhaps we should tweak the text here to inform users that the operation may take some time to complete.

Ok, sounds good to me. I'll create another PR for that.

How long does the additional wait typically take for a 10-node cluster?

It's around a dozen of seconds. I think the message we have right now is enough.

Okie doke. Just FYI for the future, you don't need to open a new PR (#232). Additional commits on the same PR are OK since they will all be squashed when I merge.


Gradle check single comments for autobot

Description
This change updates the GitHub Actions comment system. The existing system makes individual comments each run which makes the conversation chains of PRs long. This addresses this issue.
Related Issues

https://github.com/opensearch-project/.github/issues/171
Check List

[ ] ~New functionality includes testing.~

[ ] ~All tests pass~

[ ] ~New functionality has been documented.~

[ ] ~New functionality has javadoc added~

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@scrawfor99 the comments provide useful information regarding the Jenkins builds so I could quickly check the failed ones, this change overrides the build status comment with the latest all the time, is that right?

Hi @reta, this change should make it so that a subsequent failing build will replace an old build failure comment body with the new information. Currently, a build failure triggers a new comment no matter what. This means that on PRs which are long standing or suffer from flaky tests, you can run into lots of comments effectively saying the same thing. This would swap this behavior to overwrite the text body of an existing comment with the new information. So after a comment is created, all subsequent failures would replace that comment body with the updated status.
You should still be able to access the build information of previous runs from the small "X" marks on the right side of the conversation view next to the commit IDs. I admit this is less convenient than the large comment blocks but it is much easier to parse in my opinion. I also think that for the most part, because the build comments provide no readable information about the build in question (they don't have a name associated with them etc., just a URL), you are likely to find the commit-based references more valuable if you wanted to refer to a specific change you made some time ago.
Let me know what you think. If I am in the minority here for wanting this change, then no problem--I just thought it may be something useful for general development purposes.

Let me know what you think. If I am in the minority here for wanting this change, then no problem--I just thought it may be something useful for general development purposes.

Thanks @scrawfor99 , it is really useful for me (to have comment per build/check), and also Github sends the notifications when new comment is added (so pull request needs to be looked at), I think with the comment update no notifications will be sent.
But I could certainly live without it, if others think is it noise.

+1 on what @reta said.
I think as a reviewer, it makes it easy for me to glance at the gradle check runs without having to figure out going to all the checks manually if the change impacts other areas (For eg a test which is flaky repeatedly on a single PR).
And usually gradle check notifications do lead me to a PR as well :)

Thanks for adding this @scrawfor99.
+1 to @reta and @kotwanikunal . I think it's fine to have multiple build comments on the PR to provide step wise failure/success logs of the commits.

Closing since feature is not desired.


controlling the motor

Ask if there is a routine for controlling the motor

Hi DGDL,
The documentation for controlling the motor is on the list to be added soon.
Thanks
James

Motor documentation has been updated and is available now in the docs.

I see the documentation, thank you

电机文档已更新，现在可在文档中找到。

I see the documentation, thank you

Motor documentation has been updated and is available now in the docs.

see the documentation, thank you

Motor documentation has been updated and is available now in the docs.

I have a question, can I write FPGA

Motor documentation has been updated and is available now in the docs.

I read the documentation, thank you

There is no FPGA anymore.

There is no FPGA anymore.

I see. Thank you


fix: show correct state for loading payouts

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3722

PR #3719

PR #3720

PR #3723

PR #3724   👈

This comment was auto-generated by Graphite.

@wraeth-eth started a stack merge that includes this pull request via Graphite.

Graphite rebased this pull request as part of a merge.


A11y_TrydotNetWebsite_AI4W: Ensures each HTML document contains a non-empty  element (html)

"[Check out Accessibility Insights!] - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHub Tags:
#A11yAuto; #A11ySev2; #A11yMAS; #A11yTCS; #Benchmark; #DesktopWeb; #Win11; #ChromiumEdge; #P2-TrydotNetWebsite-Aug21; #AI4W; #WCAG2.4.2;
Environment Details:
Application Name: TrydotNetWebsite
OS and Browser Details:
Chromium Edge Version 99.0.1150.52 (Official build) (64-bit)
Windows 11
Repro Steps:

Hit the URL: https://trydotnet.microsoft.com
Open AI4W tool. Run Automated Checks

Issue:
Ensures each HTML document contains a non-empty  element (document-title - https://accessibilityinsights.io/info-examples/web/document-title)
Target application:
https://try.dot.net - https://try.dot.net/
Element path:
html
Snippet:

How to fix:
Fix any of the following:
Document does not have a non-empty  element
Environment:
Microsoft Edge version 101.0.1210.47
====
This accessibility issue was found using Accessibility Insights for Web 2.32.0 (axe-core 4.4.1), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.
Attachment:

does not reproduce

https://learn.microsoft.com/en-us/dotnet/csharp/tour-of-csharp/tutorials/hello-world?tutorial-step=1&WT.mc_id=-blog-scottha

Thanks @fsteffi . It seems like the issue you have in your screenshot is tracked by https://github.com/dotnet/try/issues/1006. Closing this out.


fix(motion_velocity_planner): fix duplicated topic name

Description
The motion_velocity_planner node implements two publishers with the same topic name.
https://github.com/tier4/autoware.universe/blob/c1011857f1f31ccdff9ede41b51f004889c51786/planning/motion_velocity_planner/autoware_motion_velocity_planner_node/src/node.cpp#L85-L86
https://github.com/tier4/autoware.universe/blob/c1011857f1f31ccdff9ede41b51f004889c51786/planning/motion_velocity_planner/autoware_motion_velocity_planner_node/src/node.hpp#L102
This will result in the following error when starting Autoware.
1725517904.5326092 [ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'motion_velocity_planner' of type 'autoware::motion_velocity_planner::MotionVelocityPlannerNode' in container '/planning/scenario_planning/lane_driving/motion_planning/motion_planning_container': Component constructor threw an exception: could not create publisher: failed to create topic [rt/planning/scenario_planning/lane_driving/motion_planning/motion_velocity_planner/debug/processing_time_ms] because it's already in use in this context with a different message type, at ./src/rmw_node.cpp:1804, at ./src/rcl/publisher.c:116

In the main branch of awf/autoware.universe, this problem has already been fixed by renaming the diag topic.
ref: https://github.com/tier4/autoware.universe/commit/598d9375e915758711c7b63e0e9446a81efc0430
This PR fixes this problem by renaming the debug topic to ~/debug/total_processing_time_ms.
https://github.com/tier4/autoware.universe/blob/6f026f8a6300020a3e22e5acdcb25790bb2b0a91/planning/motion_velocity_planner/autoware_motion_velocity_planner_node/src/node.cpp#L85-L86
Related links
https://github.com/tier4/autoware.universe/pull/1508

How was this PR tested?
PSim
Notes for reviewers
None.
Interface changes
Topic changes
Modifications

Version
Topic Type
Topic Name
Message Type
Description

Old
Pub
~/debug/processing_time_ms
tier4_debug_msgs/msg/Float64Stamped
Topic description

New
Pub
~/debug/total_processing_time_ms
tier4_debug_msgs/msg/Float64Stamped
Topic description

Effects on system behavior
None.

Certainly, differences in topic names are not good as they cause confusion.
I will change the topic name the same as awf/autoware.


Code Review: 'Choose Text Style' button missing (#20802)

Connect to BohemianCoding/Sketch#20802

Warnings

:warning:

This pull request may need a CHANGELOG entry.

:warning:

Source/dom/style/Style.js changed, but not its tests. That's OK as long as you're refactoring.

:warning:

Source/dom/style/Style.js changed, but not its doc. That's OK as long as you're refactoring.

  Generated by :no_entry_sign: dangerJS

Thanks @mathieudutour - I got distracted and haven't finished writing the review notes yet. Basically we used to have a sharedObjectID on the style which has now moved to the owning layer. I think it's a better design (and matches what we do in the symbols) but from the POV of this issue it means we can compare two style objects without worrying about whether they are shared styles.


Configuring integration via Google fails

The problem
When trying to obtain the Nest Protect access token, the google login page shows that the request has been blocked.
The error that I get:
Fout 400: invalid_request
The out-of-band (OOB) flow has been blocked in order to keep users secure. Follow the Out-of-Band (OOB) flow migration guide linked in the developer docs below to migrate your app to an alternative method.
Details van verzoek: redirect_uri=urn:ietf:wg:oauth:2.0:oob flowName=GeneralOAuthFlow
https://developers.google.com/identity/protocols/oauth2/resources/oob-migration
What version of this integration (ha-nest-protect) has the issue?
0.3.12
What version of Home Assistant Core has the issue?
2024.12.5
Device / Model
No response
Diagnostics information
No response
Home Assistant log
Logs
Copy/paste any log here, between the starting and ending backticks (`)

Additional information
No response

Please try the Beta version, and read the instructions there.

Otherwise, please see this issue as reference: https://github.com/iMicknl/ha-nest-protect/issues/371


(TWILL-139) Make ZKClient state change based on authentication result

If authentication is enabled, only move the ZKClient to RUNNING state
when authentication passed.

Found the root cause, which is not addressed in this PR. Closing this one.


Ability to hide purchase history

Some users want the ability to control what content is returned by their purchase history.

hopefully it will be made clear, wherever this option is exposed, that this is only hiding it from the view in the app, not from any analysis more sophisticated than a Shoulder Surfer.


Laravel 11

Heya. Can you also add the new test bench version and update the matrix build on the GHA?

Done! Depends on https://github.com/blade-ui-kit/blade-icons/pull/223

Thanks!


Is there an API to do a bulk row to add to table?

Didn't know if there was a faster way instead of individual inserts.

I've not found one yet,  however you can speed up inserts significantly using the Table.SetWriteLock() and Table.LoadOnlyMode(bool enabled) methods.


Missing "view code" "download code" on courses page

Is there a reason what the "view code" or "download code" buttons don't show up on the new ml5.js "train your own neural network" page?

Problem found. Will push the fix in a few seconds...

10e9800

@shiffman the buttons should appear on the website in a few seconds...


xTB CminSearch

Dear,
I am trying to do a CMIN_Search calculation with xTB for hundred of .sdf files, that i generate with aqme previsuly from SMILES. But, when i want to calculate this CMIN_Search, i have a problem with the input files, i realise that this problem come from the comand that i use in the console, in this case this:
python -m aqme --cmin  --program xtb --files= *.sdf
I was looking in the github repository to find an example for working trough the console with xTB but i could not find the solution to my problem. If you could help me with this would be really helpfully for me.
Thanks for your Attention,
Gonzalo

Hi Gonzalo,
Would you mind describing the error a bit more? The error message that you get is really helpful for us to track back the problem and provide you some feedback and/or fix a possible bug.

Hi Gonzalo - there is a small error in your input line, it should be:
python -m aqme --cmin --program xtb --files *.sdf
Besides this, there seems to be an issue when using xtb-python with pip-installed torch modules. Let me dig into this a bit more and I'll release a new version (1.4.1) shortly. I'll keep you on the loop

Hello,
The problem that i have is that, when i execute this line python -m aqme --cmin --program xtb --files *.sdf, this message come out:
x  xTB is not installed correctly - xTB is not available
I use xtb frequently in my computer, but here i do not know if aqme program, has xtb installed in the package included, or if i need to add another PATH, that can make this xtb work for aqme program. I will try to work on this and see if there is a problem of PATH's, but is weird to me, because as i told you, i can work with xtb without problem.
I will be pleased to help you more to fix this, or find where is my mistake.
Thanks for your attention,
Regards
Gonzalo Nuñez
Universitat Rovira i Virgili

De: Juanvi Alegre-Requena @.>
Enviat el: dissabte, 3 de desembre de 2022 11:46
Per a: jvalegre/aqme @.>
A/c: Gonzalo Darío Nuñez . @.>; Author @.>
Tema: Re: [jvalegre/aqme] xTB CminSearch (Issue #103)
Hi Gonzalo - there is a small error in your input line, it should be:
python -m aqme --cmin --program xtb --files *.sdf
Besides this, there seems to be an issue when using xtb-python with pip-installed torch modules. Let me dig into this a bit more and I'll release a new version (1.4.1) shortly. I'll keep you on the loop
—
Reply to this email directly, view it on GitHubhttps://github.com/jvalegre/aqme/issues/103#issuecomment-1336132951, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3DPR47OTHF3OZULIEUM7YDWLMQJBANCNFSM6AAAAAASSAEMOI.
You are receiving this because you authored the thread.Message ID: @.***>

Another thing that can help, is that when i execute this line with a file, the error that i send you in the last emails come out, but, if I execute xtb alone with the same file, the program works good. So, has to be some problem in the aqme with the xtb, maybe the version of xtb is different.

De: Gonzalo Darío Nuñez . @.>
Enviat el: dilluns, 12 de desembre de 2022 12:11
Per a: jvalegre/aqme @.>
Tema: Re: [jvalegre/aqme] xTB CminSearch (Issue #103)
Hello,
The problem that i have is that, when i execute this line python -m aqme --cmin --program xtb --files *.sdf, this message come out:
x  xTB is not installed correctly - xTB is not available
I use xtb frequently in my computer, but here i do not know if aqme program, has xtb installed in the package included, or if i need to add another PATH, that can make this xtb work for aqme program. I will try to work on this and see if there is a problem of PATH's, but is weird to me, because as i told you, i can work with xtb without problem.
I will be pleased to help you more to fix this, or find where is my mistake.
Thanks for your attention,
Regards
Gonzalo Nuñez
Universitat Rovira i Virgili

De: Juanvi Alegre-Requena @.>
Enviat el: dissabte, 3 de desembre de 2022 11:46
Per a: jvalegre/aqme @.>
A/c: Gonzalo Darío Nuñez . @.>; Author @.>
Tema: Re: [jvalegre/aqme] xTB CminSearch (Issue #103)
Hi Gonzalo - there is a small error in your input line, it should be:
python -m aqme --cmin --program xtb --files *.sdf
Besides this, there seems to be an issue when using xtb-python with pip-installed torch modules. Let me dig into this a bit more and I'll release a new version (1.4.1) shortly. I'll keep you on the loop
—
Reply to this email directly, view it on GitHubhttps://github.com/jvalegre/aqme/issues/103#issuecomment-1336132951, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3DPR47OTHF3OZULIEUM7YDWLMQJBANCNFSM6AAAAAASSAEMOI.
You are receiving this because you authored the thread.Message ID: @.***>

@gonzaurv we just released v1.4.1, you can upload your version with pip for example (pip install aqme). Now, ifyou run your command:
python -m aqme --cmin --program xtb --files "*.sdf"
you should get the optimizaed xTB results in the CMIN folder that generates. Also, you can add xTB command line keywords to the calculations with the xtb_keywords option (i.e. solvent, GFN method, accuracy, etc). This is an example of an xTB optimization in benzene:
python -m aqme --cmin --program xtb --files "*.sdf" --xtb_keywords "--alpb benzene"
Please, let me know if the program is working correctly in this new version and I'll close this issue.


Add Shuttlecloud user interview

Only nits. :+1: in general.

:+1: besides mine and @beorn7's nits.


Prevent [Enter] keypress propagating.

Allows [Enter] key to be bound for the purposes of submitting.
Resolves #159

hey @samkelleher , is there a reason why this PR is closed?


Add community connection-filter schema plugin

Summary
https://github.com/graphile-contrib/postgraphile-plugin-connection-filter
https://www.graphile.org/postgraphile/extending/
The plugin seems to support the useful JSON operators: https://github.com/graphile-contrib/postgraphile-plugin-connection-filter/blob/master/docs/operators.md#json-jsonb
There's also some fancier string operators.
We should be able to configure what operators are enabled for security reasons (DoS): https://github.com/graphile-contrib/postgraphile-plugin-connection-filter#performance-and-security
(https://fetchai.slack.com/archives/D03N4S7T18V/p1660591783212799)

SubQuery's graphql API service already includes this plugin. It just needs to be configured to enable the features we need.
Fixed in #42


Implement Error Handling for Missing Streams Tab in yt-dlp Calls

Hello!
I've been working with your tool and ran into an issue that I wanted to address. Though this is a tiny contribution, so I'm excited to propose this fix!
Issue Encountered:
While fetching video ids using yt-dlp for channels without a streams tab (as in my sample channel here), the script crashes with the following error:
subprocess.CalledProcessError: Command '['yt-dlp', '--flat-playlist', '--print', 'id', 'https://www.youtube.com/channel/UCwpMRCoVgSJ-rKyV1yhWljg/streams']' returned non-zero exit status 1.

And yt-dlp outputs:
ERROR: [youtube:tab] UCwpMRCoVgSJ-rKyV1yhWljg: This channel does not have a streams tab

Proposed Solution:
I've added a try-except block to the get_videos_list  function in download.py to handle this gracefully. The script now continues to run and returns any video URLs it can fetch, even if the streams tab is missing.
Here's the key change in the code:
try:
    res = subprocess.run(cmd, capture_output=True, check=True)
    live_stream_urls = res.stdout.decode().splitlines()
    if len(live_stream_urls) > 0:
        list_of_videos_urls.extend(live_stream_urls)
except subprocess.CalledProcessError:
    console.print("[bold red]No streams tab found or error fetching streams.")

Testing:
Tested this with various channels, and it's working well. Looking forward to your feedback!
Cheers!
🍒

Nice catch, looks like I introduced this bug on "Support Live Streamed Videos #112" could have sworn I tested with channels that didn't have live streams but I was probably using the wrong build. Thank you.


Add language server version in "Versions"

Get "@onflow/cadence-language-server" version from npm packages and display in Version dialog.

done


common: The Id constructor to take hash by value

A very minor change. Sorry for the big PR.

For any work in progress stuff, the change required to port your code can be done automatically by cargo fix


Build failed after cocoapods SwiftyJSON

I could build and run iOS project with Xcode 6.4. However, after cocoapds SwiftyJSON and build workspace, I received below failed message.
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: unknown option character `X' in: -Xlinker

same here

Is the issue still exist?
If so can you create a sample project?

I opened the wrong cocoapods project file so, no problems here.
On Thu, Oct 29, 2015 at 7:10 AM, Zhigang Fang<EMAIL_ADDRESS>wrote:

Is the issue still exist?
If so can you create a sample project?
Reply to this email directly or view it on GitHub:
https://github.com/SwiftyJSON/SwiftyJSON/issues/314#issuecomment-152088771


Extract and Group all links in a given page

Description
Given a user supplied url, the script will crawl the url extracting all page links and gives an output, grouping the extracted links into either internal OR external links
Type of issue

NOTE: These boxes can be checked using [X]

[ x] Feature (New Script)

[ ] Bug

[ ] Documentation

Checklist:

[ x] I have read the project guidelines.
[ x] I have checked all the existing projects, before submitting a new project issue.
[ x] I have checked previous issues to avoid duplicates.
[x ] This issue will be meaningful for the project.

Hey, can I  work on this?

i ccreated this so i can get assigned to it sir ... am already half way through

@TEMHITHORPHE  Are you up to this :)
As the issue is stale for 9 days.
If not, @AdityaJ7 , can you assign me this??

@TEMHITHORPHE Are you up to this :)
As the issue is stale for 9 days.
If not, @AdityaJ7 , can you assign me this??

@Anshul275 assigning to you

nah!! am done!!!
On Thu, Oct 15, 2020 at 5:18 AM Aditya Jetely<EMAIL_ADDRESS>wrote:

@TEMHITHORPHE https://github.com/TEMHITHORPHE Are you up to this :)
As the issue is stale for 9 days.
If not, @AdityaJ7 https://github.com/AdityaJ7 , can you assign me this??
@Anshul275 https://github.com/Anshul275 assigning to you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Python-World/Python_and_the_Web/issues/286#issuecomment-708886667,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AET5HYEWYVHXUZIHSXVDLFTSKZZXXANCNFSM4SDFXMLQ
.


Update NuGet feeds

lgtm, of course.

wow. I can sign off it myself.

LGTM :shipit:

Thank you.


Implement URLHandler router which looks at windowId query param

Fixes #79635
The check for windowId in the URL is quite hacky, but should work for all purposes.

Yeah, I thought I would leave that to you, I just wanted to show how the routing can work.

OK I can take over from here then.

@joaomoreno back to you, please check out https://github.com/microsoft/vscode/pull/80260/commits/822c67c9add32984e3496945fc1196426232398d

@joaomoreno done via https://github.com/microsoft/vscode/pull/80260/commits/8fed7fbd831fe713778c08d093644bebd84f1ddd
(note that Electron Window IDs are just numbers that should never contain ":")


Change config file after release of ubuntu 22.04.1

With this change the image is building again

@shuhaowu, would you take a look?


Add empty changelog

Adds a CHANGELOG.md file to this repository. The format is based on "Keep a changelog", the link in the file contains more information.
If this kind of changelog is added, every PR that makes a somewhat bigger change should also update the changelog accordingly. With this policy it should be possible to have a comprehensive changelog for every release.

Probably update https://github.com/librespot-org/librespot/blob/dev/CONTRIBUTING.md too.


Is there any way to apply to favorites?

This plugin is perfect, but is there any way to show it in favorites too?

Same problem here.
Some of your pages in Favorite seem to work fine. Have you figured out how come these worked in the first place?

Same problem here - would be great to find this out

Figured it out:
In the page property, meaning the first block of the page, add icon::   with an emoji after the double column
Then you need to remove and add as favourite again

Thanks a lot for your answer @k-spr.
I would also suggest to add the following code to custom CSS, for solving the subsequent double icon in title problem (c.f. below image).
.page-icon{
	display: none
}


Add embedContent option

Added a new option embedContent to enable embedding bundle content directly into HTML rather than generating a <script src="..."> pointer tag.
So, as an example a generated HTML body could become:
<body>

    <script>
        // bundle content here
    </script>
</body>

This is actually an awesome idea @lgirma, so sorry I didn't get to merging it earlier. Resolving conflicts, adding tests and publishing with version 1.7.0 now.

This is actually going to take a bit longer as this doesn't really work for all usecases; for example if used with bundle.write() the bundle is not written before this runs. WIll put it in a branch and get to it later


BZ#1624573 - Fix issue where error message is not displayed for consoles

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1624573.   Error messages not being displayed properly for console launch errors.
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label bug

Before SS

After SS

Thanks @AllenBW .  Seems this one caused a test to fail.  Working on fixing it now.

@miq-bot add_label blocker


Microk8s Version upgrade does not work

Expected Behaviour: Changing 'microk8s_version'  would change the version of the installed microk8s.
What happens: Version is still on v1.19
my current by hand fix was running sudo snap refresh microk8s --channel=latest/stable  on all servers.

Hi,
you can specify the version by providing microk8s_version: "1.19/stable"
see the
https://github.com/istvano/ansible_role_microk8s/blob/master/defaults/main.yml

Yes i tried that multiple times. Ansible just printed ok: ...
so no change was detected

From my testing, the role won't change the version of the channel after initial install. I used the following tasks to switch channels (but not force a refresh)
    - name: get snap channel
      shell:
        cmd: snap list --unicode=never microk8s | grep microk8s | awk '{print $4}'
      register: snap_version
      changed_when: false

    - name: update snap channel
      command:
        cmd: snap switch microk8s --channel={{ microk8s_version }}
      become: true
      when:
        - snap_version.stdout != microk8s_version


Translations not working

fixes #906

Automated message from Dropbox CLA bot
@umairwaheed, it looks like you've already signed the Dropbox CLA. Thanks!

Awesome, thanks for doing this @umairwaheed!  Merged.

thanks.


⚠ Bofrost.lu has degraded performance

In a2770ee, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1545 ms

Resolved: Bofrost.lu performance has improved in 1515efa after 22 minutes.


[Feature Request] move setup.py to pyproject.toml

move nndeploy/python/setup.py
refer: https://github.com/FMInference/FlexiGen/pull/54
workload about 40 minutes.

Currently cannot do it, because we create setup.py from setup.py.cfg


Cannot install java in a container: mknod: `fuse-': Operation not permitted

I am using docker on mac os x with in a vagrant box started using the Vagrantfile available on the docker repository.
Vagrant version 1.2.2
Docker version:
Client version: 0.4.2
Server version: 0.4.2
Go version: go1.0.3
I am trying to install java in a container using the following command:
docker pull ubuntu
docker run -i -t ubuntu:12:04 /bin/bash
echo "deb http://archive.ubuntu.com/ubuntu precise main universe" > /etc/apt/sources.list
apt-get update
apt-get install openjdk-7-jdk

Then I get the following error during the install process:
Setting up fuse (2.8.6-2ubuntu2) ...
Creating fuse group...
Adding group `fuse' (GID 102) ...
Done.
Creating fuse device...
mknod: `fuse-': Operation not permitted
makedev fuse c 10 229 root root 0660: failed
chown: cannot access `/dev/fuse': No such file or directory
dpkg: error processing fuse (--configure):
 subprocess installed post-installation script returned error exit status 1
Processing triggers for libc-bin ...No apport report written because MaxReports is reached already

ldconfig deferred processing now taking place
Errors were encountered while processing:
 fuse
E: Sub-process /usr/bin/dpkg returned an error code (1)


Symbol confusion

Description
It's difference from PDF.
(Optional:) Please add any files, screenshots, or other information here.
PDF

HTML

(Required) What is this issue most closely related to? Select one.
Formula
Internal issue ID
7bfc4814-7c7f-4e60-84ef-267935105f7e
Paper URL
https://arxiv.org/html/2307.11046
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

Thank you for reporting it @GF-Huang , this is valuable aid for the latexml team to catch by proofreaders.
The effect is realized via:
\documentclass{article}
\usepackage{mathbbol}
\DeclareSymbolFontAlphabet{\mathbbl}{bbold}
\begin{document}
\def\alllearnrules{\mathbbl{\Sigma}}
Let $\alllearnrules$ ...vs $\Sigma$.
\end{document}

And appears to need an upgrade to mathbbol.sty.ltxml in latexml.


Feature addition

Description of the change
Related Issues & Documents (if needed)
What type of PR is this? (check all applicable)

[ ] Refactoring existing code
[ ] Adding tests to existing code
[x] New Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

QA Instructions(if necessary), Screenshots of Output or Recordings
_Please replace this line with instructions on how to test your changes
Added tests?

[ ] Yes
[x] No, because they aren't needed
[ ] No, because I need help

Added to documentation / readme or updated requirements.txt(if needed)?

[ ] Changed documentation in readme
[ ] No documentation needed
[x] Updated requirements.txt

topic modelling and spell check


strange debugger behaviour

Debugger jumps between lines.
Video attached in google group:
https://groups.google.com/forum/#!topic/ceylon-users/ApfeYszppMc
Ceylon version 1.2.2

Ok, I've been able to confirm the strange jump in the if-statement.
To reproduce simply use:
Boolean? x = false;
variable Boolean y = false;
if (exists x, x == false) {
    y = false;
} else if (!exists x) {
    y = false;
} else {
    y = true;
}

(Btw @martyn-evgeny , the above if-statements can much easier be written as: Boolean y = x else false)

@martyn-evgeny I haven't been able to reproduce yet the strange jump when entering the for-loop that you show at the beginning of the video.
Could you try to trim down the code to the simplest code possible that still shows that behaviour and post that code here?
I'd start be removing all of the code in the loop, to see if the problem is because of something inside the loop or outside of it. Also see if the problem still occurs when using basic types like String and Integer instead of your own classes. etc etc. Just try to achieve the simplest code possible.


Subnet ID

It is unclear if the Subnet ID is only the <guid> which is highlight in the code or the whole "/subscriptions/<guid>/resourceGroups/myVnet/providers/Microsoft.Network/virtualNetworks/myVnet/subnets/default"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37ba0343-7e43-6e2e-e564-5d3a0f523a75
Version Independent ID: 0ba581a1-3e4a-27b4-c667-4a9b969a3ade
Content: Configure Azure CNI networking in Azure Kubernetes Service (AKS)
Content Source: articles/aks/configure-azure-cni.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

It is the  which is highlighted in red, the same color as "[0].id" in the command.

We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


SignPsbt fails to add partial signature when P2TR output is being spent in a funded PSBT

Background
Given a funded PSBT using FundPsbt, the resulting funded PSBT should be able to be signed with SignPsbt but there is no signature being added in the result of SignPsbt when an input is a P2TR input like there is when an input is a P2WPKH.
Your environment

lnd v0.15.0-beta.rc3

Steps to reproduce

Create a funded PSBT using FundPsbt with 1 output and 1 input, where the input is a P2TR
Pass this funded PSBT to SignPsbt in walletrpc

Also do the same thing, but where the input is a P2WPKH
Expected behavior
Both the P2TR signing and the P2WPKH signing should result in a partially signed PSBT
Actual behavior
For the P2TR funded PSBT the output of SignPsbt will be equal to the output of FundPbst, meaning it is not partially signed
For the P2WPKH funded PSBT it will include a partial signature as expected

I think I spotted the issue, when we sign we skip if the bip32 derivation info isn't present: https://github.com/lightningnetwork/lnd/blob/master/lnwallet/btcwallet/psbt.go#L132-L136
However, when we fund w/ a P2TR input, we only place the new taproot specific info: https://github.com/btcsuite/btcwallet/blob/af5562928b707e0b56c1e44052ece3205bb66552/wallet/psbt.go#L273-L288
The itests we have also always put both and old and new information: https://github.com/lightningnetwork/lnd/blob/7106ea59db9ade78d65bb46605f94637900c0e3f/lntest/itest/lnd_psbt_test.go#L769-L776

If this is correct, then we need to fix this on the btcwallet side, then update the lnd dep.


S2U-46 - Improvements: Big data loaded by AJAX

@frasese let me know when do you want to merge this


Fix pyproj deprecation

In this PR:

fixed the deprecated syntax in pyproj to avoid future breakages;
be explicit about always_xy=True to prevent lat, lon vs lon, lat confusions;
drop pyproj <2 to make it easier to support modern pyproj and proj without workaround.

If supporting pyproj 1.9.* is important we can add a few if-clauses here.

@tomkralidis looks good to me. Ok to merge?

+1

@ocefpaf merged. Thanks :)


QUESTION: Better Plain JS example

Is there a complete example of Globalize.js using Plain Javascript that shows how to load specific CLDR data now that cultures are no longer supported in Globalize. The current plain Javascript example loads the data for you which makes it hard to figure out how to do it yourself.

https://github.com/globalizejs/globalize/blob/master/doc/cldr.md#how-do-i-load-cldr-data-into-globalize
Feel free to post additional comments (and I reopen it) if you find bugs in the docs. For questions, please use SO. Thanks