setElementTransform is not count as 'fromPosition'

When i use snabbt.setElementTransform to set position for elements without animation (start position), and later set new position with snabbt, elements are animated from 0, 0, but not from position, that was set in snabbt.setElementTransform.
Ask me for example if you can't reproduce or don't understand me.

I understand what you mean.
However, the setElementTransform-function is very low-level since it takes a matrix as parameter. It's not possible to unambiguously extract position, rotation etc from that.
For example, these two animation configurations would generate the same matrix:
{
   position: [200, 0, 0],
   rotationPost: [0,  0, Math.PI]
}

{
  position: [-200, 0, 0]
}
```

Have you tried using the snabbt()-call with a duration of 0 for just setting the position?
Haven't tried myself, but that would probably have the same effect.

it worked for me only if duration was >= 1 and some 'blinking' was visible
so i needed to make element visibility: hidden and on callback return it to visible
it looks like some "hack", so i use setElementTransform  the same as fromPosition.
since it is not a bug, i close this issue. thank you for paying attention.


[dunfell][gatesgarth][hardknott][honister] {galactic} Miscellaneous fixes for recipes

I encountered some build failures when building ROS2 Galactic for Yocto Project hardknott release.
I have merged my fixes into meta-ros and tested using the documented steps: https://github.com/ros/meta-ros/wiki/OpenEmbedded-Build-Instructions to build ros-image-core
I then appended the following line to conf/local.conf to satisfy one of the recipe's dependencies:
DISTRO_FEATURES_append = " x11 opengl vulkan "
Followed by this command:
bitbake libg2o openvslam octomap phidget22
Without my fixes these recipes will fail, with the fixes applied they should successfully build.

I've updated this to follow our commit conventions and did few more changes inside, please check.

I didn't look into the details, but openvslam fails with this PR applied:
/jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/recipe-sysroot-native/usr/lib/x86_64-oe-linux/gcc/x86_64-oe-linux/9.3.0/include/avxintrin.h: In member function 'virtual float fbow::L2_avx_generic::computeDist(__m256*)':
/jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/recipe-sysroot-native/usr/lib/x86_64-oe-linux/gcc/x86_64-oe-linux/9.3.0/include/avxintrin.h:1228:1: error: inlining failed in call to always_inline '__m256 _mm256_setzero_ps()': target specific option mismatch
 1228 | _mm256_setzero_ps (void)
      | ^~~~~~~~~~~~~~~~~
/jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/git/3rd/FBoW/src/fbow.cpp:121:39: note: called from here
  121 |         __m256 sum = _mm256_setzero_ps(), sub_mult;
      |                      ~~~~~~~~~~~~~~~~~^~
In file included from /jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/recipe-sysroot-native/usr/lib/x86_64-oe-linux/gcc/x86_64-oe-linux/9.3.0/include/immintrin.h:51,
                 from /jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/git/3rd/FBoW/include/fbow/vocabulary.h:40,
                 from /jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/git/3rd/FBoW/include/fbow/fbow.h:34,
                 from /jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/git/3rd/FBoW/src/fbow.cpp:27:
/jenkins/mjansa/build/ros/ros2-galactic-dunfell/tmp-glibc/work/core2-64-oe-linux/openvslam/0.2.3-3-r0/recipe-sysroot-native/usr/lib/x86_64-oe-linux/gcc/x86_64-oe-linux/9.3.0/include/avxintrin.h:147:1: error: inlining failed in call to always_inline '__m256 _mm256_add_ps(__m256, __m256)': target specific option mismatch
  147 | _mm256_add_ps (__m256 __A, __m256 __B)
      | ^~~~~~~~~~~~~

Fails the same here with hardknott release as well.

@rcwoolley Add Upstream-Status and Signed-off-by in:
meta-ros2-galactic/recipes-bbappends/openvslam/openvslam/no_compiler_probe.patch
FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" should be :prepend
And please follow the convention to add {ros-distro} prefix in commit summary when it touches only one of the ROS distributions.
Are you going to fix openvslam in foxy? Or these fixes aren't needed in foxy?

@rcwoolley Add Upstream-Status and Signed-off-by in: meta-ros2-galactic/recipes-bbappends/openvslam/openvslam/no_compiler_probe.patch and preferably use git format-patch to create it, so it can be easily applied with git am
FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" should be :prepend
And please follow the convention to add {ros-distro} prefix in commit summary when it touches only one of the ROS distributions.
Are you going to fix openvslam in foxy? Or these fixes aren't needed in foxy?

Thanks.  I encountered some beginner mistakes with GitHub PRs.  I didn't expect my fork repo's branch to get rewritten and lost your changes when I did a force push.  I will make the changes you asked for now and resubmit.

Upstream-Status and Signed-off-by also missing in meta-ros2-galactic/recipes-bbappends/phidgets-drivers/libphidget22/fix_libdir.patch as shown by:

@rcwoolley Add Upstream-Status and Signed-off-by in: meta-ros2-galactic/recipes-bbappends/openvslam/openvslam/no_compiler_probe.patch and preferably use git format-patch to create it, so it can be easily applied with git am
FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" should be :prepend
And please follow the convention to add {ros-distro} prefix in commit summary when it touches only one of the ROS distributions.
Are you going to fix openvslam in foxy? Or these fixes aren't needed in foxy?

Thanks. I encountered some beginner mistakes with GitHub PRs. I didn't expect my fork repo's branch to get rewritten and lost your changes when I did a force push. I will make the changes you asked for now and resubmit.

My version is in my fork as:
https://github.com/shr-project/meta-ros/tree/dunfell-next-pr-932

I made the changes that were requested.  I also fixed the libphidget22-upstream patch.   The diagnosis was correct, but the method I used to disable the Debian renaming wasn't actually working.   I discovered that doing: "bitbake -c cleanall libphidget22 && bitbake libphidget22" still exhibited the problem.  I tested the new fix both by cleaning and rebuilding libphidget22, but also by examining the log.do_package for libphidget22-upstream to ensure that the debian renaming lines were not present.
These patches successfully built the recipes for both qemux86-64 and raspberrypi4-64.

Some of my changes were missed in this version.

Use BPN in FILESEXTRAPATHS.
Fold libphidget22-upstream_%.bbappend into libphidget22-upstream_1.6.20210312.bb as it doesn't make sense to bbappend our own non-generated recipe, do we really need to disable debian naming for all PACKAGES? PN-doc surely wasn't renamed, right?
The .patch files still don't have the headers from git format-patch.

I will update the PR in https://github.com/shr-project/meta-ros/tree/dunfell-next-pr-932 to avoid further delay.

I missed that. My apologies.
Folding the bbappend in makes sense.
Regarding the second part: not all the packages were created as they would have been empty, however they all did get renamed:

grep debian ../tmp/work/core2-64-oe-linux/libphidget22-upstream/1.6.20210312-r0/temp/log.do_package
DEBUG: Executing python function debian_package_name_hook
NOTE: debian: renaming libphidget22-upstream-src to libphidget22-src
NOTE: debian: renaming libphidget22-upstream-dbg to libphidget22-dbg
NOTE: debian: renaming libphidget22-upstream-staticdev to libphidget22-staticdev
NOTE: debian: renaming libphidget22-upstream-dev to libphidget22-dev
NOTE: debian: renaming libphidget22-upstream-doc to libphidget22-doc
NOTE: debian: renaming libphidget22-upstream-locale to libphidget22-locale
NOTE: debian: renaming libphidget22-upstream to libphidget22-0
DEBUG: Python function debian_package_name_hook finished
The reverse-runtime symlinks reflect the incorrect Debian names as well:
lrwxrwxrwx 1 rwoolley rwoolley 32 Sep 30 10:45 /opt/projects/meta-ros-build/tmp/ljpkgdata/raspberrypi4-64/runtime-reverse/libphidget22-0 -> ../runtime/libphidget22-upstream
lrwxrwxrwx 1 rwoolley rwoolley 36 Sep 30 10:45 /opt/projects/meta-ros-build/tmp/pkgdata/raspberrypi4-64/runtime-reverse/libphidget22-dbg -> ../runtime/libphidget22-upstream-dbg
lrwxrwxrwx 1 rwoolley rwoolley 36 Sep 30 10:45 /opt/projects/meta-ros-build/tmp/pkgdata/raspberrypi4-64/runtime-reverse/libphidget22-dev -> ../runtime/libphidget22-upstream-dev
lrwxrwxrwx 1 rwoolley rwoolley 36 Sep 30 10:45 /opt/projects/meta-ros-build/tmp/pkgdata/raspberrypi4-64/runtime-reverse/libphidget22-src -> ../runtime/libphidget22-upstream-src
lrwxrwxrwx 1 rwoolley rwoolley 42 Sep 30 10:45 /opt/projects/meta-ros-build/tmp/pkgdata/raspberrypi4-64/runtime-reverse/libphidget22-staticdev -> ../runtime/libphidget22-upstream-staticdev
We could isolate the change to the ones that currently conflict, but this would open up the possibility for a conflict in the future.

Acknowledged.  I will use "git format-patch" for future recipe patches.

Replaced by https://github.com/ros/meta-ros/pull/940

We could isolate the change to the ones that currently conflict, but this would open up the possibility for a conflict in the future.

or just set AUTO_LIBNAME_PKGS to empty as I did.


pythonPackages."check-manifest": How to wrap it properly?

A Python question.
Package check-manifest relies on making shell call python setup.py sdist where python is the interpreter used to run check-manifest itself. With the current Nixpkgs Python setup, the dependencies of check-manifest are only set within the main process and do not propagate when it does shell call to Python.
$ nix-build "<nixpkgs>" -A pythonPackages."check-manifest"
/nix/store/dqcbigpnxc2arwvqsg0932c4zbmid2bz-python2.7-check-manifest
$ result/bin/check-manifest
['/nix/store/779afy6nqwpwav76r92djbk652f0d3g0-python-2.7.14/bin/python2.7', 'setup.py', 'sdist', '-d', '/tmp/check-manifest-UD8HKT-sdist'] failed (status 1):
Traceback (most recent call last):
  File "setup.py", line 2, in <module>
    from setuptools import find_packages
ImportError: No module named setuptools

Obviously this does work in nix-shell where PYTHONPATH is patched to include all the dependencies (and it propagates in Python to shell calls by default):
$ nix-shell -p pythonPackages."check-manifest" --run "check-manifest"
lists of files in version control and sdist match

Is there better way than overriding the package to set PYTHONPATH?
.overridePythonAttrs(old: {
  postInstall = ''
    for prog in $out/bin/*; do
      wrapProgram $prog \
        --prefix PYTHONPATH : "$PYTHONPATH" \
        --prefix PATH : "$out/bin:$PATH"
    done
  '';
});

Modules need to be patched to include references like absolute paths or fixed environment variables.
Executables can instead be wrapped as that is often more convenient (although e.g. wrapPythonProgrmas does both patching and wrapping).

In this case the best solution is to replace python setup.py sdist with ${python.interpreter} setup.py sdist, either with substituteInPlace or a proper patch file.

@FRidh Thanks you.
Now I understood that this cannot be automatic because "check-manifest" is used to execute arbitrary setup.py, which could include any imports. By default it uses the current python in path, which makes it work in normal properly in normal virtualenvs.
Yet, for my I own use, I can assume that setup.py always only requires setuptools.
I assume, python.buildEnv is the correct way to create a custom interpreter with required packages to use in substituteInPlace (and possibly to add that into propagatedBuildInputs to ensure it not being garbage collected). At least this worked for me...
let cm_python = python.withPackages(ps: [ ps.setuptools ]); in
self: super: {
  "check-manifest" = "check-manifest".overridePythonAttrs(old: {
    postPatch = ''
      substituteInPlace check_manifest.py --replace "..." "\"${cm_python.interpreter}\""
    '';
  });
}


Question about extensions

Hello,
I was wondering if its possible to implement jump to error by double clicking on error message in output window with extension.

It is not possible to implement this behavior by an extension.
Jump to error by doudble clicking error message is built in vscode. However not all formats of errors are supported, so some error paths are not detected.
Please search our github issue history since there are multiple issues already opened about jump to error for more details.


Slow tab completion on WSL2

Description
In WSL2, tab completion is very slow on executable files and in certain directories
Steps to Reproduce
a<tab>
# Wait 5-10 seconds and it will eventually show the completion menu

The issue is much more evident when tab completing a specific file that is in the immediate directory and thus doesn't require the menu to appear:
cd ~
touch foo
chmod +x foo
./fo<tab>
# Wait 5-10 seconds and it will eventually complete the word foo

I'm not sure if this is a zsh issue or a prezto issue, however if I disable prezto and use vanilla zsh, the tab completion is instant.  The vanilla tab completion doesn't use the menu however, so it could also be the menu's fault, but I'm not sure how to verify that.

I have noticed that WSL, by default, puts a lot of /mnt/c directories (such as /mnt/c/Windows/) on $PATH.

~ ❯❯❯ echo $PATH | tr ':' '\n'
/usr/local/bin
/usr/local/sbin
/usr/sbin
/usr/bin
/sbin
/bin
/usr/games
/usr/local/games
/mnt/c/Windows/system32
/mnt/c/Windows
/mnt/c/Windows/System32/Wbem
/mnt/c/Windows/System32/WindowsPowerShell/v1.0/
/mnt/c/Windows/System32/OpenSSH/
/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common
/mnt/c/Program Files/NVIDIA Corporation/NVIDIA NvDLISR
/mnt/c/WINDOWS/system32
/mnt/c/WINDOWS
/mnt/c/WINDOWS/System32/Wbem
/mnt/c/WINDOWS/System32/WindowsPowerShell/v1.0/
/mnt/c/WINDOWS/System32/OpenSSH/
/mnt/c/Users/Fryguy/AppData/Local/Microsoft/WindowsApps

If I remove those directories, then tab completion is fast.  For now, as a workaround I have the following in my profile which works:
export PATH=$(echo $PATH | tr ':' '\n' | grep -v "/mnt/c/" | tr '\n' ':')

With that workaround in place, everything is fast, however I can kind of force the issue anyway by doing:
cd /mnt/c/Windows/System32
a<tab>
# Wait 3-5 seconds for the completion menu to appear

My guess is something about these Windows directories is overloading completion, but I have no idea how to narrow this down any further.
I've also tried the following to no effect:

sudo updatedb
rm -rf ~/.zcompdump*

Versions

Prezto commit: de7b3b7fdc99f8a67320dc64085dea44914969c7
ZSH version: zsh 5.4.2 (x86_64-ubuntu-linux-gnu)
OS information: Ubuntu 18.04.4 LTS \n \l on WSL2 - Microsoft Windows [Version 10.0.19592.1001]

Faced the same issue here as well. completion gathers some windows specific "exe" binary as well. Basically WSL2 has windows path as well, and that where it get really slow.

Disable windows paths with appendWindowsPath in wsl.conf:
https://devblogs.microsoft.com/commandline/automatically-configuring-wsl/
Then just make aliases to the stuff you use from windows (explorer.exe, vscode etc.)

the completion for directory navigation when using autocd is very slow too

unsetting these options on zshrc will fix it
unsetopt PATH_DIRS
unsetopt COMPLETE_IN_WORD

i think this happens because /bin/X11/ is a symbolic link to /bin/ thus creating a circular directory tree that zsh tries to search

this still works in April 2022 👍

This in my /etc/wsl.conf fixed the issue for me (PATH crowded with Windows binaries)
[interop]
appendWindowsPath = false

Restart to enable the changes.

@lied If you do that, you won't be able to invoke standard Windows binaries. For many (myself included) this would be a deal breaker.

i think this happens because /bin/X11/ is a symbolic link to /bin/ thus creating a circular directory tree that zsh tries to search

No, it's because of path_dirs. This is an esoteric option that the vast majority of users don't need.

This really isn't a prezto issue at all, is it?

Prezto enables path_dirs, which the vast majority of users don't need, including those that actually know what this option does. As a side effect, path_dirs makes completions slow if you have slow directories in your PATH, which includes all WSL setups. Enabling path_dirs isn't a good default.


[WIP] DistributedDataParallel with FP8-support

Description
In this PR, the native pytorch DistributedDataParallel is overrided by msmap.nn.parallel.distributed.DistributedDataParallel, which supports ScalingTensor as the parameters. The weight gradients will be put in a bucket then all-reduced. The function optimizer.all_reduce_grads is deprecated.
Major Revision

Add msmap.nn.parallel.distributed.DistributedDataParallel

TODO

[x] asynchronous all reduce
[ ] refactor code
[ ] check training with deepspeed
[ ] unit test for msmap.nn.parallel.distributed.DistributedDataParallel
[ ] update ms-amp examples
remove optimizer.all_reduce_grads()

Close it because of the new PR #93


IAM delete_server_certificate

Implementation of IAM delete_server_certificate with unit tests.

Welcome to moto. Also run make lint, flake8 is complaining.

Coverage increased (+0.005%) to 92.158% when pulling 383fb9f6cfafef8b678e2c014f4501b4d318b658 on captin411:iam-delete-server-certificate into 81f3cbb54880bdf68fd6f52b9aa30ea25a4b7bd9 on spulec:master.

Coverage increased (+0.005%) to 92.158% when pulling 383fb9f6cfafef8b678e2c014f4501b4d318b658 on captin411:iam-delete-server-certificate into 81f3cbb54880bdf68fd6f52b9aa30ea25a4b7bd9 on spulec:master.

Thank you @terrycain.
I have fixed that.

Looks good


New language

Here is the draft of the new language. Still a few things left to do:

[ ]  update the benchmarks file.
[ ] Add constprop for fully zero tensors.
[ ] Restructure update to just be a trait
[ ] Remove extraneous IR nodes (pass, forget, with, multi)

Codecov Report
Patch coverage: 58.88% and project coverage change: -2.42 :warning:

Comparison is base (d4e4c5d) 79.59% compared to head (2f4ba40) 77.18%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   79.59%   77.18%   -2.42%
==========================================
  Files          42       40       -2
  Lines        4126     4128       +2
==========================================
- Hits         3284     3186      -98
- Misses        842      942     +100

Impacted Files
Coverage Δ

src/FinchNotation/FinchNotation.jl
100.00% <ø> (ø)

src/glue_AbstractArrays.jl
65.00% <0.00%> (-1.67%)
:arrow_down:

src/looplets/runs.jl
66.66% <0.00%> (-0.78%)
:arrow_down:

src/semantics.jl
50.00% <ø> (ø)

src/levels/sparsebytemaplevels.jl
88.70% <8.33%> (-3.92%)
:arrow_down:

src/annihilate.jl
63.08% <10.00%> (-18.67%)
:arrow_down:

src/levels/sparsehashlevels.jl
83.54% <16.66%> (-3.96%)
:arrow_down:

src/Finch.jl
41.66% <20.00%> (-54.49%)
:arrow_down:

src/FinchNotation/instances.jl
44.70% <23.52%> (-4.65%)
:arrow_down:

src/FinchNotation/nodes.jl
48.58% <39.43%> (-4.05%)
:arrow_down:

... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adds header decoding tests and simplifies

This simplifies the header checks as they are ASCII so can be compared easier.
This also defocuses internal code from io.Reader as it is unimportant as wasm.Reader doesn't need to be exported: since it doesn't need to be exported, functions that require io.Reader will already fail compilation upon not implemented at the call site.

thanks for the help review and the open mind @mathetake! each tiny PR was a glitch in my head synced to disk


Running/debugging extension tests does not work anymore

Version: 1.51.0-insider
Commit: 49696e87c64f478f97909a91d41ff2913df9bf71
Date: 2020-10-31T00:11:14.623Z
Tested on Ubuntu and Window

create a new extension with yo code
open the extension in VScode,
set a breakpoint in src/test/suite/extension.test.ts
go to the debug viewlet, Run Extension Tests
other window opens but immediately closes
Breakpoint not reached, no output to debug console
Sometimes the debug session is not terminated (debug toolbar stays present)

I cannot reproduce the issue on Window or linux.
@connor can you?

Have you enabled the web worker extension host? If so you're probably running into https://github.com/microsoft/vscode/issues/104004

Yes, I had the web worker ext host on. So sorry for that, I didn't realize that.
Duplicate of #104004


Allow users to specify homepage variable in package.json

Allow users to specify a homepage variable in package.json, referring to the public path under which the app is served in production. This may be a relative path or absolute URL, though only the pathname is relevant. The value of homepage is ignored in non-production environments.
Use homepage as Webpack's publicPath.
Expose process.env.HOMEPAGE so users can use the variable in their own code.
Prefix all asset paths (including the service worker path and mainfest path) with the public path.

@reznord Fixed the indentation issues (sorry, tabs vs. spaces).
Regarding the failed checks, I can't think of why the service worker check would succeed on Node 6 and fail on Node 8. Unfortunately, I can't actually run the tests locally because I'm on a Windows machine and #262 prevents the preact serve tests from running. But I did just create, build, and http-server (with a proxy redirect through Fiddler to a domain with valid certificates) using Node 8 and the service worker registered just fine in Chrome.
I just looked at the pending checks for my latest commit, and the Node 6 check (which succeeded on the previous commit) seems to be failing all over the place. This is very confusing, since the only difference between those two commits was spacing.

Meanwhile, the most recent Node 8 check is passing this time.
Any ideas why this might be happening? I just double-checked the diffs and it's just spacing.

I'm gonna test this locally in my PC and will let you know.

@ethanroday the tests pass perfectly in my local machine, tested it on node v6, v7, v8 too.

Huh. @lukeed? @developit? Any ideas on why these tests would be succeeding locally but failing in Travis?

Admittedly, I know nothing about our tests 😞 Pinging the resident mastermind @rkostrzewski

Makes me wonder if we should start a "preact-cli" config key within package.json, instead of adding keys here & there.

Perhaps this could also be solved setting publicPath directly. This would help keep custom configuration close together. Then this could be achieved like follows:
// preact.config.js
export default function (config, env, helpers) {
    const BASE_URL = env.production ? '/my-gh-pages-url' : ''
    config.output.publicPath = BASE_URL
}

@lwakefield Correct, I prefer that approach to be honest, but I'm not sure what others feel about it.

Whatever the outcome, it may not be a bad idea to consolidate as much of the configuration as possible. Currently, it looks like there are 5 different ways to configure the preact-cli build:
browserlist, babel, webpack, pre-render and template.

@lwakefield That's actually what I've been doing as a workaround for now, but it leaves two problems unsolved:

The path to the service worker is hardcoded as /sw.js and doesn't care what the public path is, and
The template doesn't use the public path in the path to them manifest (this could be solved by a custom template, but I figured I would also fix it in this PR).

I see your point about there being too many entries for configuration - and this PR just adds another one (in the form of a homepage entry in package.json). I agree that only having to set the public path in preact.config.js would be vastly preferable, but somehow entry.js still needs to get the value of that variable so it can set the service worker path correctly (that's currently being achieved with process.env.HOMEPAGE). In your scenario, how does entry.js get access to the public path (short of requiring the user to define a specifically-named Webpack constant in their preact.config.js)?

@ethanroday, I agree - I ran into similar issues with /sw.js and I think this PR currently addresses this. Are we able to do the following to do away with process.env.HOMEPAGE:
// lib/entry.js
if (process.env.NODE_ENV === 'development') {
	require('preact/devtools');
} else if ('serviceWorker' in navigator && location.protocol === 'https:') {
	navigator.serviceWorker.register(__webpack_public_path__ + 'sw.js');
}

@lwakefield A significantly more elegant solution! One note: in theory, the Webpack public path can be an absolute URL. In those cases, you would need to check to make sure it was the same domain as the current location before attempting to register the service worker.
With that change in place, though, I would be happy to abandon this in favor of a re-opened #323.

I agree. To make things simpler (re: /sw.js), let's just add the publicPath to the prerender options so that it's available to the template.
A quick-n-dirty fix is to add:
var baseUrl = '<%= htmlWebpackPlugin.options.publicPath %>';

/// entry.js
navigator.serviceWorker.register(baseUrl + 'sw.js');

Exposing/mounting baseUrl is safe since it's essentially equivalent to location.href on the first load.

@lukeed, are you suggesting just adding baseUrl as a global variable in a script tag in template.html? Why is that preferable to @lwakefield's __webpack_public_path solution? Or am I misunderstanding you?

@rkostrzewski, any thoughts on the failing tests?

Hi,
I did a build using "homepage": "pwa" and the preact.config.js from @lwakefield above and all URLs are prefixed properly except manifest.json.
We also need to figure out how to reconfigure the Routes (prefixing with pwa doesn't work either)
link rel="manifest" href="/manifest.json"
link rel="shortcut icon" href="/pwa/favicon.ico"
link href="/pwa/style.a1486.css" rel="stylesheet"
body
script defer="defer" src="/pwa/bundle.1405f.js"
script window.fetch||document.write('<script src="/pwa/polyfills.a668a.js"

We could use DefinePlugin to make PUBLIC_PATH available to script, then use that for the serviceworker URL.

I would need to check that it works, but are you thinking of something like:
webpack.definePlugin('PUBLIC_PATH', JSON.stringify(__webpack_public_path__))

Any idea why the manifest.json is not properly prefixed?
Also, shouldn't both the dev an production show the real path ?
(I don't see a problem with dev showing <IP_ADDRESS>:8080/pwa/)
The homepage option is really useful because any website can set up a PWA version of the site in a separate path. So, the Router integration is also key.

Guys, any plans to solve this issue in the nearest couple days? I wouldn't want to create a fork for myself because of this... Thanks!

@rodush hey, for now you can just use preact.config.js which is suggested here: https://github.com/developit/preact-cli/pull/315#issuecomment-323397020

@reznord It doesn't help, as the SW path is hardcoded in entry.js - /sw.js, this is the main problem.

Ah true, my bad!

Hey, I reopened #323 as an alternative approach.
With respect to https://github.com/developit/preact-cli/pull/315#issuecomment-325124297, after some experimenting, it is difficult to define PUBLIC_PATH without introducing another config/env variable. However, it is more or less a one-liner to exposePUBLIC_PATH in preact.config.js.

We decided to go with the path in #323 since it was simpler & doesn't involve any additional package.json reliance.
Thank you for your PR @ethanroday ❤  It sparked some good ideas & conversations. We'll be revisiting those points in the near future, but for now, we're just going with the path of least resistance.
🙇


Feature/boas 46 search applications tool

Describe your changes

Add njk template for the searchbox in the dashboard page (will be possible to use the same one for the search results page)
Add some custom style for the searchbox and the dashboard top section
Add a new whole scope in web/applications for the search, this includes:

a router handling the server url that calls the search api
a controller to handle the form input and its potential errors, call the service and render the search results page
a validator to check whether the search term is defined (can be used in the future to limit special characters)
some Typescript scope-specific types
a dummy service currently mocking the to-be-finished api

Also contains:

updated snapshots
an almost empty template for the search-results page (out of scope)
some notes about the routes structure of the applications scope

Issue ticket number and link
BOAS-46
https://pins-ds.atlassian.net/browse/BOAS-46
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[x] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


random verification failure when using ECDSA with secp521r1

Using:
// g++ -std=c++14 -Ijwt-cpp/include main_ec3.cpp -lcrypto
#include "jwt-cpp/jwt.h"
int main()
{
#if 1
// Fails randomly
//openssl ecparam -genkey -name secp521r1 | openssl ec -out myec.pem
//openssl ec -in myec.pem -pubout -out myec_pub.pem
const std::string ec_private_key = R"key(-----BEGIN EC PRIVATE KEY-----
MIHcAgEBBEIAVNNl9RB5yK3ZqXjoWlVDI/I3CngB6dVePYBHaEw05IzpsMyxp9NA
i+1vivgl25JB0DPACVU+LZ51W3MF1iPiuP6gBwYFK4EEACOhgYkDgYYABADnMhAz
X7tNRt4lxi7Npi68P4/5CYQe718O2XQvav+Bv+Os55JT/v5l3wLkmOAvQzWgUBdx
dd/P81kw91YcJT4w6AC9GOdGZQXEaqmqZwTSTY5nVQ54ejfdAS9CywSCCwYnLgbW
bQZQD/q/opNUNUzfX7oiYAZsd9CKpDr1hL6kip19zg==
-----END EC PRIVATE KEY-----)key";
const std::string ec_public_key = R"key(-----BEGIN PUBLIC KEY-----
MIGbMBAGByqGSM49AgEGBSuBBAAjA4GGAAQA5zIQM1+7TUbeJcYuzaYuvD+P+QmE
Hu9fDtl0L2r/gb/jrOeSU/7+Zd8C5JjgL0M1oFAXcXXfz/NZMPdWHCU+MOgAvRjn
RmUFxGqpqmcE0k2OZ1UOeHo33QEvQssEggsGJy4G1m0GUA/6v6KTVDVM31+6ImAG
bHfQiqQ69YS+pIqdfc4=
-----END PUBLIC KEY-----)key";
#else
// Works reliably
//openssl ecparam -genkey -name secp256k1 | openssl ec -out myec.pem
//openssl ec -in myec.pem -pubout -out myec_pub.pem
const std::string ec_private_key = R"(-----BEGIN PRIVATE KEY-----
MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgPGJGAm4X1fvBuC1z
SpO/4Izx6PXfNMaiKaS5RUkFqEGhRANCAARCBvmeksd3QGTrVs2eMrrfa7CYF+sX
sjyGg+Bo5mPKGH4Gs8M7oIvoP9pb/I85tdebtKlmiCZHAZE5w4DfJSV6
-----END PRIVATE KEY-----)";
const std::string ec_public_key = R"(-----BEGIN PUBLIC KEY-----
MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEQgb5npLHd0Bk61bNnjK632uwmBfr
F7I8hoPgaOZjyhh+BrPDO6CL6D/aW/yPObXXm7SpZogmRwGROcOA3yUleg==
-----END PUBLIC KEY-----)";
#endif
if (false)
{
auto token = jwt::create()
.set_issuer("auth0")
.set_type("JWS")
.set_payload_claim("sample", jwt::claim(std::string("test")))
.sign(jwt::algorithm::es256{"", ec_private_key});
auto decoded = jwt::decode(token);
auto verifier = jwt::verify()
  .allow_algorithm(jwt::algorithm::es256{ ec_public_key })
  .with_issuer("auth0");

verifier.verify(decoded);

}
else
{
std::string hash = "012345678901234567890123456789012";
const jwt::algorithm::es256 signer("", ec_private_key);

const auto signature = signer.sign(hash);

const jwt::algorithm::es256 verifier(ec_public_key);

verifier.verify(hash, signature);

}
}
I observe random verification failures:

g++ -std=c++14 -Ijwt-cpp/include main_ec3.cpp -lcrypto
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
[ixdevenv] abgengcluster:/home/adesitter/MR2/EC_signing_verify>./a.out
terminate called after throwing an instance of 'jwt::signature_verification_exception'
what():  Invalid signature
Abort
g++ -std=c++14 -Ijwt-cpp/include main_ec3.cpp -lcrypto
./a.out
./a.out
./a.out
./a.out
./a.out
terminate called after throwing an instance of 'jwt::signature_verification_exception'
what():  Invalid signature
Abort

Please take a look at the above bugfix.
It should fix your issue.
Turns out the padding of ecdsa signatures was wrong all along and no one noticed.
It only happened randomly as an ECDSA signature is not identical every time you generate it.
So the bug was not in verification but instead in generating.

Thanks for the quick fix.
The case I provided works now as long as I use the correct algorithm (jwt::algorithm::es512).
A few comments:
#1 After the fix, the correct algorithm must to be called depending on the type of key passed by argument. Unless is can be addressed, There is now a case to be more specific in the arguments documentation.
In jwt.h:
* \param public_key ECDSA public key in PEM format
* \param private_key ECDSA private key or empty string if not available. If empty, signing will always fail.
"ECDSA with P-256 (or P-384 or, P-521)" (after https://tools.ietf.org/html/rfc7518#section-3.1)
Currently, using es256 with a P-521 key will result in an exception. It is possible to use es512 with a P-256 key ?
#2 In TokenTest.cpp, it may be worth testing jwt::algorithm::es512. Additionally, you could test that using es256 with a P-521 key result in an exception.
#3 Out of curiosity, it is there an explanation of the padding algorithm you are using somewhere ? It is somewhat puzzling that OpenSSL does not provide a function for this.

@adesitter Regarding 1: It was never a feature that es256 worked with a 512bit key, just a coincident. In fact it probably was pure luck if the tokens were standard compliant.
No you can not (should not) use es512 with a 256 bit key.
Regarding 2: Yes testcases will come once I have time to write some. After they are done I will also add a new release.
Regarding 3: JWS uses a fixed signature length for ecdsa which consists of concatenating r and s of the signature. Therefore each of them needs to be half the size of that length. I basically prepend zeros until the size matches. Not sure why OpenSSL does not provide it, might do in the future but they also might ignore it as its really simple to implement and I could not find any other applications of this specific method.

Thanks.
std::logic_error("bignum size exceeded expected length") could be replaced by std::invalid_argument("Incorrect key type").


Lw/foundation addition

@gfx
Some systems, such as Alamofire aren't quire up to pure json strings as arguments, so I'm adding a quick Foundation accessor to get things like Dictionary and Array as Foundation types.

Looks good :sushi: :+1:


Added REPLACE as an alternative to INSERT.

Replace effectivly looks for PRIMARY or UNIQUE constraints, if something matched it gets replaced, otherwise a new row will be added to the table.
Ref SQLite Replace

Everything should be dandy now i think!
First PR ever so if i did miss any steps that's probably the reason. 👍

I think I made some mistakes here when trying to resolve the conflicts. Can you create a branch called querybuilder-replace on your repository based on your master branch?

Yeah i did and i think it's just 2 spaces in the comments. I pushed a commit into the branch too to fix this.

Can you resolve the conflicts in the querybuilder_test.ts file? I can't resolve this conflict with GitHub's web editor.

I don't understand...
You created this commit but I can't see the changes in this PR 🤔

well either github is a slow poke, or i can just open a new pr in a few minutes; maybe i need to re-request for a review 🤔
Sent with GitHawk

well its merged i was the slowpoke 😅
Sent with GitHawk

Nevermind, it's merged now.
Thanks for your contribution!


FileUploaderButton: Ability to set a clickable Icon instead of a button

I have to add in a data-table an action in order to upload a file from the client to the server.
For the time being I use the FileUploaderButton but having a big button in the data table is not so nice. An icon would be much nicer.
Something like (with of course another icon than the trash ;-):

rather than

Closing as a duplicate of: #1071


bump identity apps core version

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8399428685

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8399428685
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8399647734

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8399647734
Status: success


[ENHANCEMENT] Persist dashboard modification when clicking on save button

This PR allowed the UI to send a request to the backend to persist the modified dashboard.
Success or error message are displayed using the Snackbar
Signed-off-by: Augustin Husson<EMAIL_ADDRESS>

thanks for your help @eunicorn @saminzadeh . This PR is ready to review now :)


Fix SpMV merge conflicts

I'm all set now, thanks Radha!

we don't need to merge this

ok great! i'll close this PR then!


File uploading?

Request for file uploading function like code interpreter of ChatGPT.

https://github.com/shroominic/codeinterpreter-api/blob/main/examples/convert_file.py
File Upload + Download working from day 0


opt auto fallback when query unsupport table type

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Which is the sparsemax in your codes?

Which is the sparsemax in your codes?

The implementation of Sparsemax please see: https://github.com/deep-spin/entmax
In our work, we use entmax in the function self_attention and global_attention of the class DualAttention


Issue with k8s.io/docs/concepts/overview/working-with-objects/names/

This documentation talks about different naming constraints for resources. It does not list, which resource type needs to follow which naming constraints.
Does such a matrix exist? At the moment, I am trying to figure out the naming constraints for lease-names when using the Kubernetes leader election API. But a general overview of all resources would be very convenient.

There is no document that lists the the naming requirements for each Kubernetes API. Also, reference pages such as https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/lease-v1/ don't (yet) list the naming requirements. We do try to document these in the relevant concept pages. A PR against https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/lease-v1/ is welcome.
Should we add a page that lists each API and its naming constraints? It sounds useful; there's a cost, too, both for writing it the first time, and in terms of maintaining the document once we add it.
/kind feature
/language en

According to the validation logic for Lease, the name of a Lease has to be a valid DNS subdomain name.

I don't think we have the resources to maintain that page. It'd be useful to add if more docs contributors turn up.
/remove-lifecycle rotten
/lifecycle frozen
/close not-planned


b3sum -l 64

Microsoft Windows [Version 10.0.17763.2268]
(c) Корпорация Майкрософт (Microsoft Corporation), 2018. Все права защищены.

c:\Tools>b3sum yt-dlp.exe > yt-dlp.blake3

c:\Tools>b3sum -c yt-dlp.blake3
yt-dlp.exe: OK

c:\Tools>b3sum -l 64 yt-dlp.exe > yt-dlp.blake3

c:\Tools>b3sum -c yt-dlp.blake3
b3sum: Invalid space

c:\Tools>b3sum -V
b3sum 1.2.0

c:\Tools>

why error?
9571f05110a290f8e2096a5dea2308da765984dd899c24dbc29d1b50e5b29c5bcd0ff26cc129d6e8ded98e3d2be74be29af9fa6d901eb4953165943694660177  yt-dlp.exe
yt-dlp.exe

Ah, this in intended behavior, but the error message is crappy. The underlying issue is that we just don't support checkfiles with anything other than default-length hashes. There are two reasons for that rule:

Most importantly, using shorter hashes gives you less security. Developers with cryptography experience are well aware of this, of course, and understand all the issues with collisions and birthday bounds and all that. But that's a very small minority of users.
Also, using longer hashes does not give you more security. This is counterintuitive, and I think lots of people expect that something like b3sum -l64 has more collision resistance than the default. The reason this isn't so is that the "chaining values" used internally in BLAKE3 compression are always 32 bytes, regardless of the final output size. Finding a collision on a chaining value is equivalent to finding a collision on the whole hash function.

For those two reasons, the number of legitimate use cases for a checkfile with non-default-length hashes is vanishingly small, and I think the downsides of supporting those cases outweigh the upsides. (Also consider that any advanced user with intense performance requirements is probably using BLAKE3 as a library, rather than shelling out to b3sum.)
But all that said, this is a really crappy error message. It might be a good idea to add some hueristic to catch this case. Any chance you'd be interested in helping us add that feature? :)

I do not know English. Translates Google.

No worries. Google translate is awesome.

Delete the key "-l" from the program?

Unfortunately it's not that simple. Something like b3sum -l64 * is a reasonable command, which you might use for other purposes. However, it's not valid as a checkfile. There's no way for b3sum to know whether its output is intended to be a checkfile or not.
I'll think about other ways to detect this case and improve the error message.

I probably will never understand why b3sum -l64 * if you can't check the result.

I probably will never understand why b3sum -l64 * if you can't check the result.

BLAKE3 supports extendable outputs because there are uncommon use cases that want to generate more than 32 pseudorandom bytes from a given seed. Ed25519 is one example of this, where it splits a single SHA-512 output into two 32-byte keys. Another example would be using BLAKE3 as a stream cipher or a CSPRNG.
However, in typical use cases like --check, there's almost no reason to ever use more than 32 bytes of output.


Upgrade to WebDriverIO v5?

Is there any plan to use latest major WebdriverIO version?

Sure, as soon as holidays are over

Are there any updates on when wdio v5 support will come in?

it's coming, changes in testing cause the delay,  otherwise it's working. I hope to have it out in a week.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Enrique Matta-Rodriguez<EMAIL_ADDRESS>Sent: Monday, February 4, 2019 3:52:36 PM
To: stsvilik/wdio-docker-service
Cc: Simon Tsvilik; Comment
Subject: Re: [stsvilik/wdio-docker-service] Upgrade to WebDriverIO v5? (#44)
Are there any updates on when wdio v5 support will come in?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/stsvilik/wdio-docker-service/issues/44#issuecomment-460408434, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIt0KPDh978X9j0-7RmKzy2e0bZFUFxks5vKJ2UgaJpZM4ZlA91.

I'm having a hard time with selenium-standalone. Did anyone got it running locally. If yes share a working example :|

@stsvilik, you mean get the NPM module runnning locally?
Usually
npm install -g selenium-standalone
selenium-standalone install
selenium-standalone start

would just work like a charm.

Selenium-standalone does not handle installations of browsers. So if you want to interact with Chrome, you need Chrome to be installed at the standard location.

Not that simple for version 5. All essential services are already bundled into main webdriverio repo. With this setup you add new service there (under /packages), which becomes part of main repo. So I'm having problem running @wdio/selenium-standalone that is built-in. Just doesn't work! Overall new version is very confusing and difficult to contribute to.

Ah so you have issue with wdio-selenium-standalone-service. I've just tested it on a blank project and it worked.
You can check it here: https://github.com/catalandavid/wdio-samples/tree/master/wdio5/wdio-selenium-standalone-service

@catalandavid Ok, got that test to pass - turned out that I can't use ES6 import syntax in wdio.config.js files even though it runs with babel-node. Like I said, finding useful examples in the repo is hard and sometimes misleading. Moving forward ... TY for the help!

You're welcome! please let me know if I can help to get the issue fixed.

Hello @stsvilik, any update on this issue? Can we help to get it fixed?

Just came back from vacation :| Working ...

@catalandavid I'm just not getting Jest :(
Here is what I have so far - need few more tests to pass coverage limitation, otherwise it's working. Any help writing unit tests appreciated.
https://github.com/stsvilik/webdriverio/tree/wdio-docker-service

Ah you plan you contribute the service in webdriverio project, great idea, it makes sense! :)
BTW, if you are not already there, I suggest you contact the maintainers here https://gitter.im/webdriverio/webdriverio to communicate your idea to contribute your service.

About your fork, shall I check on master directly or branch wdio-docker-service?

I would checkout branch wdio-docker-service, it just needs a few more tests - just add yourself to contributors in package.json and it'll be a joint effort :)

Anything I can do to support the update?

@christian-bromann That branch would be under my fork. I'm not too keen on Jest mocking/testing so basically all that is needed is to add/modify existing mocha tests to pass coverage threshold. Otherwise code in that branch is working.

I made a PR and a POC https://github.com/serbanghita/wdio5-docker
I couldn't include git@github.com:serbanghita/wdio-docker-service.git#WDIO5 directly because of one babel error npm ERR! prepareGitDep Error: Couldn't find preset "env" relative to directory "/Users/sghita/.npm/_cacache/tmp/git-clone-7ef10687". Apparently using the repo as a package messes up babel. You should be fine testing this by cloning git@github.com:serbanghita/wdio-docker-service.git#WDIO5 and linking it to your repo.
I think this is the easy way to do it until the monorepo approach is done (with all the tests)

@serbanghita thank you! Will take a look.

thanks to @serbanghita new release is compatible with WDIO 5.x
https://github.com/stsvilik/wdio-docker-service/releases/tag/v2.0.2

Hi there, I'm trying to use this dependency with wdio v5 and I get docker service initialization error. I'm using the latest version of wdio-docker-service(2.1.0).  Below is my config details.
services = ['docker'];
hostname = 'localhost';
dockerLogs = './dockerLogs';
dockerOptions = {
    image: 'selenium/standalone-chrome-debug',
    healthCheck: 'http://localhost:4444',
    options: {
        p: ['4444:4444', '5901:5900'],
        shmSize: '2g'
    }
};

Could you please let me know if I'm missing something here?
Thanks,
Thilak
Execution of 1 spec files started at 2019-06-06T20:27:43.857Z
2019-06-06T20:27:43.858Z DEBUG @wdio/utils:initialiseServices: initialise wdio service "docker"
2019-06-06T20:27:43.886Z INFO @wdio/cli:Launcher: Run onPrepare hook
2019-06-06T20:27:43.887Z ERROR @wdio/cli:utils: A service failed in the 'onPrepare' hook
TypeError: Cannot destructure property args of 'undefined' or 'null'.
at DockerLauncher.onPrepare (/webdriveriov5/example/node_modules/wdio-docker-service/lib/launcher.js:28:7)
at Promise.all.launcher.map.service (/webdriveriov5/example/node_modules/@wdio/cli/build/utils.js:29:33)
at Array.map ()
at runServiceHook (/webdriveriov5/example/node_modules/@wdio/cli/build/utils.js:27:39)
at Launcher.run (/webdriveriov5/example/node_modules/@wdio/cli/build/launcher.js:83:38)
at process._tickCallback (internal/process/next_tick.js:68:7)
at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
at startup (internal/bootstrap/node.js:283:19)

@thilaksatish do you mind also sharing node and docker versions?

@thilaksatish this error indicates that configuration was not passed into the service, which could indicate that config file has error or not consumed at all. Please give me an example of how you run it and a full sample of wdio.config.js file

Thanks @stsvilik . I'll provide the details in a new ticket. Thanks for getting back to me on this.

@stsvilik I had something wrong in my wdio conf file. The service works great! Thanks for your help.

Hii There, I tried using Wdio-docker-service ^3.1.4 with wdio v4. I am getting docker initialize error.
ERROR: Couldn't initialise service "docker".
/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/wdio-docker-service/node_modules/fs-extra/lib/mkdirs/make-dir.js:85
} catch {
^
SyntaxError: Unexpected token {
at new Script (vm.js:51:7)
at createScript (vm.js:136:10)
at Object.runInThisContext (vm.js:197:10)
at Module._compile (internal/modules/cjs/loader.js:618:28)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
at Module.load (internal/modules/cjs/loader.js:566:32)
at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
at Function.Module._load (internal/modules/cjs/loader.js:498:3)
at Module.require (internal/modules/cjs/loader.js:598:17)
at require (internal/modules/cjs/helpers.js:11:18)
at Object. (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/wdio-docker-service/node_modules/fs-extra/lib/mkdirs/index.js:3:44)
at Module._compile (internal/modules/cjs/loader.js:654:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
at Module.load (internal/modules/cjs/loader.js:566:32)
at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
at Function.Module._load (internal/modules/cjs/loader.js:498:3)
at Module.require (internal/modules/cjs/loader.js:598:17)
at require (internal/modules/cjs/helpers.js:11:18)
at Object. (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/wdio-docker-service/node_modules/fs-extra/lib/copy-sync/copy-sync.js:5:20)
at Module._compile (internal/modules/cjs/loader.js:654:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
at Module.load (internal/modules/cjs/loader.js:566:32)
at Runner.initialiseServices (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/webdriverio/build/lib/runner.js:692:35)
at Runner._callee$ (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/webdriverio/build/lib/runner.js:94:38)
at tryCatch (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
at new Promise (<anonymous>)
at new F (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/core-js/library/modules/_export.js:36:28)
at Runner.<anonymous> (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12)
at Runner.run (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/webdriverio/build/lib/runner.js:324:29)
at process.<anonymous> (/home/nikhil/ViralGains/IdeaProjects/cucumber-salad/node_modules/webdriverio/build/lib/runner.js:742:22)
at process.emit (events.js:180:13)
at process.emit (domain.js:422:20)
at emit (internal/child_process.js:783:12)
at process._tickCallback (internal/process/next_tick.js:178:19)

Node version -- v9.11.2
wdio.conf.js ---
services: ['docker', 'visual-regression','intercept','devtools'],
dockerLogs: './logs',
dockerOptions : {
image : 'selenium/standalone-chrome',
healthCheck : 'http://localhost:4444',
options : {
p : ['4444:4444'],
shmSize : '2g'
}
},
host: 'localhost',
port: 4444,

@nikhil-sharma10 the version of Wdio that is compatible with 3.1.4 should be at least 5 (better to use 6). That could be the reason for error. Also errors point to file system issues, so make sure that RW permissions are set on the directory you work in.

better to use 6

Better to use 7 😉


Not working on neovim

Hi, this plugin is an awesome idea =)
I would love to play it on nvim.
I use a vim fork called neovim.io, but it is not working on it. I see the Mario falling quickly and then:

NVIM 0.1.7
Ubuntu 16
Thanks

@Lucasosf I'm sorry. I don't want to support this for NeoVim, but welcome the PR .

It actually does appear to run on neovim, you just have to make sure you set nowrap and make sure the font size is small


[Cdn] Add new preview API: 2023-07-01-preview

ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[X] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. July 2023
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. July 2023
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[X] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[X] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[X] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@jessicl-ms  pls check validation and fix them https://github.com/Azure/azure-rest-api-specs/pull/24387#issuecomment-1585491643 refer to https://github.com/Azure/azure-rest-api-specs/pull/24387#issuecomment-1585494110

Hi, @jessicl-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

Please also follow this to update the PR

Hi, @jessicl-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

Please also follow this to update the PR

@zizw123 I fixed my commit history. You should find 3 commits as of now:

Copy latest stable version 2023-05-01 to preview directory
Rename that copy to 2023-07-01-preview version
Changes relevant to new preview api version and all api validation fixes.

@zizw123 Addressing current failures separately in comments below:

This preview API version contains api for preview feature UrlSigningKey. This feature was previously present in cdn.json API definition in Private Preview state. We have already notified customers currently using the previous APIs about breakings changes (<20 total customers). The previous definition in cdn.json was also for a different resource SKU. The current changes are specifically targeted for afdx.json definitions for customers using Azure Frontdoor Standard/Premium SKU. There should be no overlap between the previous and future customers using this preview feature.
Breaking Change (Cross-Version)

The validation pipeline shows this error. I'm not sure how to resolve it. Please advise!
"new":"https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2023-05-01/afdx.json", "details":"Command failed: node<EMAIL_ADDRESS>--v2 --input-file=specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nFATAL: swagger-document/emitter - FAILED\nFATAL: Error: Error retrieving '$.definitions.UrlSigningAction.type' (Error: Trying to retrieve 'type' from mapping that contains no such key)\n Error: Error retrieving '$.definitions.UrlSigningAction.type' (Error: Trying to retrieve 'type' from mapping that contains no such key)\n"

Swagger SDK Breaking Change Tracking:

I had copied over cdn.json and cdnwebapplicationfirewall.json from 2023-05-01 version. There should not be any changes to these files. However, the validation pipeline is identifying changes to those resources. Why is that?

Swagger Model Validation:

Error Discriminator_Value_Not_Found is looking for Discriminator value "UrlSigningRule" not found in preview/2023-07-01-preview/examples/Rules_Create_AfdUrlSigningAction.json. However, that value is present. Is there a different place I need to put it?
Error Missing_Resource_Id says id is required to return in response of GET/PUT resource calls but not being provided. These example files are for cdn.json API definitions which have not been changed in this PR. Can these be ignored?

Swagger LintDiff

Is there a way around Error PutRequestResponseSchemeArm? We do not want a PATCH API available for this resource. A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'KeyGroups_CreateUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: [Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635](https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635)
What kind of error response is error LroErrorContent looking for? This new resource is suing the same lro error we are using for other preexisting operations.

SDK azure-sdk-for-net-track2, SDK azure-powershell
Do these validations only succeed if all other validations are succeeding?

@jessicl-ms Thanks for explanations .  @rkmanda are these errors can be acceptable?

Swagger LintDiff, ~[Staging] Swagger LintDiff

Is there a way around Error PutRequestResponseSchemeArm? We do not want a PATCH API available for this resource. A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'KeyGroups_CreateUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: [Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635](https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635)
What kind of error response is error LroErrorContent looking for? This new resource is suing the same lro error we are using for other preexisting operations.
Is Error DeleteResponseCodes saying I need to remove 200 response from delete API?

The failure for PutRequestResponseSchemeArm is a false alarm. Please apply a suppression for it.
The failure for LroErrorContent can be fixed by switching to the use of the standard error definition for ARM - https://github.com/Azure/azure-rest-api-specs/blob/8b70e81ab1b526c468b5dbd68affd30595cfc329/specification/common-types/resource-management/v5/types.json#L302C1-L303C1
Also fix the warnings to use common types so that you are making use of the common type definitions - ParameterNotUsingCommonTypes
DeleteResponseCodes
A long-running delete must not return a 200 status code. It MUST return a 202 accepted when the delete request is accepted and a long running workflow is initiated for the delete operation. It MUST also return a 204 if the resource does not exist.

      "202": {

PUT must not return a 202

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3685 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)

      "final-state-via": "azure-async-operation"

remove this, you dont need to specify the final-state-via

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3705 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)

      "200": {

remove. Async delete only needs to respond with 202 or 204

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3737 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)

      "$ref": "./cdn.json#/definitions/ProxyResource"

use common-types

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:4616 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)

I opened an issue for the failure in the breaking changes PR check. I also manually compared adfx.json with the prior version and saw no potential breaking changes.

Marked this pull request as draft as there is some more work need to do

      "final-state-via": "azure-async-operation"

remove this, you dont need to specify the final-state-via for control plane APIs
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3705 in e804d9d. [](commit_id = e804d9d, deletion_comment = False)

Removed

      "200": {

remove. Async delete only needs to respond with 202 or 204
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3737 in 8b70e81. [](commit_id = 8b70e81, deletion_comment = False)

Removed

      "202": {

PUT must not return a 202
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3685 in 8b70e81. [](commit_id = 8b70e81, deletion_comment = False)

Request to this API are async and may not complete immediately. We have been using 202 to indicate that the operation was accepted and initiated. Could we keep 202 as PUT response?

Swagger Avocado errors are from files owned by other feature teams. I had rebased with Azure:main, but the error still show up. Please advise on how to resolve or if these errors can be bypassed.
Link to errors: https://github.com/Azure/azure-rest-api-specs/pull/24387/checks?check_run_id=15892581865

Swagger ModelValidation errors are also in files unrelated to this PR. The file cdn.json is owned by our team, but is for a different customer SKU that will not be using the urlsigning key feature being introduced in 2023-07-01-preview. The remaining errors are in files owned by other feature teams.
Link to errors: https://github.com/Azure/azure-rest-api-specs/pull/24387/checks?check_run_id=15892582087

Swagger SemanticValidation errors are in files owned by different teams. Please advise on how to bypass.
Link to errors: https://github.com/Azure/azure-rest-api-specs/pull/24387/checks?check_run_id=15892582133

Swagger LintDiff, ~[Staging] Swagger LintDiff

Is there a way around Error PutRequestResponseSchemeArm? We do not want a PATCH API available for this resource. A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'KeyGroups_CreateUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: [Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635](https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635)
What kind of error response is error LroErrorContent looking for? This new resource is suing the same lro error we are using for other preexisting operations.
Is Error DeleteResponseCodes saying I need to remove 200 response from delete API?

The failure for PutRequestResponseSchemeArm is a false alarm. Please apply a suppression for it.

Suppression has been added to our readme.md

Swagger Avocado errors are from files owned by other feature teams. I had rebased with Azure:main, but the error still show up. Please advise on how to resolve or if these errors can be bypassed.

I'm not sure why you got so many errors. However I'm a little curious about this claim:

Swagger ModelValidation errors are also in files unrelated to this PR. The file cdn.json is owned by our team, but is for a different customer SKU that will not be using the urlsigning key feature being introduced in 2023-07-01-preview. The remaining errors are in files owned by other feature teams. Please advise on how to resolve or bypass.

Link to errors: https://github.com/Azure/azure-rest-api-specs/pull/24387/checks?check_run_id=15892582087

So simplistic question, if its in the swagger file you're changing, shouldn't we try to address any model validation errors? For instance, if you did have a problem with a different customer SKU, but you're adding urlsigning feature, won't you want them to work together in the future, and so want to figure out how to design the API that way, so that we don't get errors when they're potentially combined, or SDKs are generated which have to work with both of them but the compiler is in ignorance of all the domain constraints?

Are these inter-preview-version breaking changes intended?

⚠ 1011 - AddingResponseCode	The new version adds a response code '202'.
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L392:11
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'canMigrate' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L2883:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2871:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'defaultSku' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L2883:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2871:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'errors' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L2883:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2871:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'migratedProfileResourceId' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L3022:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2991:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'errors' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L3022:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2991:7
⚠ 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L354:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L354:7

By ARMChangesRequested I mainly mean please clarify. :)

[And the changes to review are just supposed to be between commits number 2 and 3, is that right?]

Are these inter-preview-version breaking changes intended?

⚠ 1011 - AddingResponseCode	The new version adds a response code '202'.
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L392:11
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'canMigrate' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L2883:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2871:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'defaultSku' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L2883:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2871:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'errors' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L2883:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2871:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'migratedProfileResourceId' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L3022:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2991:7
⚠ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'errors' renamed or removed?
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L3022:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L2991:7
⚠ 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L354:7
Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L354:7

These differences are by design. The 2023-07-01-preview version in this PR is based on 2023-05-01 stable version. The features in 2022-11-01-preview have already been moved into 2023-05-01 stable version. However, they were removed in 2023-05-01 stable version to fix PS/CLI issues. Here is the commit: https://github.com/Azure/azure-rest-api-specs/commit/baa84c2856db44c1d8f00d1d296d66118a998fd3.

[And the changes to review are just supposed to be between commits number 2 and 3, is that right?]

Yes, the changes to review are primarily commit number 3 "Update to new api and rebase all api validation fixes." I have been merging additional changes into this commit.

Swagger Avocado errors are from files owned by other feature teams. I had rebased with Azure:main, but the error still show up. Please advise on how to resolve or if these errors can be bypassed.

I'm not sure why you got so many errors. However I'm a little curious about this claim:

Swagger ModelValidation errors are also in files unrelated to this PR. The file cdn.json is owned by our team, but is for a different customer SKU that will not be using the urlsigning key feature being introduced in 2023-07-01-preview. The remaining errors are in files owned by other feature teams. Please advise on how to resolve or bypass.

Link to errors: https://github.com/Azure/azure-rest-api-specs/pull/24387/checks?check_run_id=15892582087

So simplistic question, if its in the swagger file you're changing, shouldn't we try to address any model validation errors? For instance, if you did have a problem with a different customer SKU, but you're adding urlsigning feature, won't you want them to work together in the future, and so want to figure out how to design the API that way, so that we don't get errors when they're potentially combined, or SDKs are generated which have to work with both of them but the compiler is in ignorance of all the domain constraints?

Fair point. I'll see if I can resolve the ModelValidation errors coming from cdn.json. The reason I would prefer not to is because those errors are in files that are for preexisting APIs that not added or changed in this PR, so I assume it had previously passed validation.

        "description": "OK. Creation or update succeeded.",

200 is returned only for updates. Description can be updated to say Update successful

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3674 in c7d75d7. [](commit_id = c7d75d7f5c41491360e8f0087e774988de694da8, deletion_comment = False)

@jessicl-ms - Please address the review comments. Adding ARMChangesRequested tag

this js breaking is caused by :https://github.com/Azure/azure-rest-api-specs/pull/24164

kazrael2119

/azp run

/azp run

@jessicl-ms , please fix duplicate schema issue for Go sdk failure.
warning | PreCheck/DuplicateSchema | Duplicate Schema named 'DeliveryRuleAction' (6 differences):
01:29:23.777 cmderr 	[generator automation-v2]   - discriminator: {"propertyName":"name"} => <none>
01:29:23.777 cmderr 	[generator automation-v2]   - properties: {"name":{"x-ms-enum":{"name":"DeliveryRuleAction","modelAsString":true},"$ref":"#/components/schemas/DeliveryRuleAction","description":"The name of the action for the delivery rule."}} => <none>
01:29:23.777 cmderr 	[generator automation-v2]   - required: ["name"] => <none>
01:29:23.777 cmderr 	[generator automation-v2]   - type: "object" => "string"
01:29:23.777 cmderr 	[generator automation-v2]   - enum: <none> => ["CacheExpiration","CacheKeyQueryString","ModifyRequestHeader","ModifyResponseHeader","UrlRedirect","UrlRewrite","UrlSigning","OriginGroupOverride","RouteConfigurationOverride"]
01:29:23.777 cmderr 	[generator automation-v2]   - x-ms-enum: <none> => {"name":"DeliveryRuleAction","modelAsString":true}

#raych1 The error mislead me to think the duplicate was DeliveryRuleAction object, but upon close inspection, I found the duplicate object and removed it. There are still errors showing, but they are not in the namespaces/APIs owned by team. This is an issue I've posted about in the General API teams channel.

/azp run


Text doesn't bind when  has attributes

Let's say helloWorldText = 'Hello World'.
The following renders: Hello World
[[helloWorldText]]
However, when I add any attributes to , such as class or on-click, the text binding isn't rendered. For example, the two following examples renders: [[helloWorldText]]
[[helloWorldText]]
[[helloWorldText]]
It looks like I need to add an extra  around the text binding to render, like this:
[[helloWorldText]]
[[helloWorldText]]
Is this expected? Should I be surrounding any/all [[textBinding]] with plain  tags?
I'm currently using 0.8. Thanks!

That's definitely a bug. I can't reproduce it in 0.9:
http://jsbin.com/bipobu/2/edit#H:L24
I can't reproduce it in 0.8-rc.2, either. Do you know exactly what version you have?
You will get this if you have any whitespace around the binding, but I've never seen it when the span has an attribute on it.

We're using v0.8.0-rc.7. Here's our current bower.json.
Could I provide any other info that would be helpful?

We could not reproduce this issue.  Can you please try to modify the following JSBin to reproduce the issue?  Thanks.
http://jsbin.com/wefecifogo/1/edit

Hmm, I can only consistently repro in Chromium with 0.8.0-rc.7. We'll be upgrading to 1.0 soon, so I can remove the extra  around the text binding when we do so.
Thanks!

@kevinpschaaf Hey Kevin, this is no longer repro-able on our side.

Thanks for the update, closing.


Download specific episode

Wondering if there is a way to download a specific episode using the episode URL. Please close if not possible.

No as far as I know it's not possible, but I will not close it for a simple reason, that an option that should be there!

So I found this project that encountered the same issue with HSL, but before that issue, it accepted a Crunchyroll URL and would download that episode. Might be worth taking a look at: https://github.com/einstein95/crunchy-xml-decoder

Thanks for that project, I wil take a look, I think there are a few interesting part, especially for the subtitles which is one other big issue for me with current version of crunchy

On the Deathspike version there were some comments about fixing the episode filter by changing line 96 of the series.js file from:
episode: parseInt(episode[0], 10),
to:
episode: parseInt(episode[1], 10),
Then you would be able to actually select a particular episode by adding -e <some number> to the command like it was intended. I've noticed that it's off by one. So if you want to download episode 21 you need to say -e 20.
I would definitely push for the URL option, though. Using the URL of the video directly would be a lot cleaner in my mind. Some Anime have specials/movies so how are they numbered (see One Piece for example)? There are also a number of episodes on Crunchyroll that have episode numbers like 7.5 or 13.5. How would those be numbered and would they offset the next episodes? For example would Episodes 7, 7.5, and 8 be indexed like 7, 8, 9?
I definitely like the batch downloading functionality, but the URL option would be a lot cleaner.

That's a good idea to clearly add support for full episode URL.
For 7.5, 10.5 etc. My (future) change take care of them. It does not support all of the extra episodes, but most of them
In fact I'm thinking about a major change in how episodes are listed and saved for batch. Will see lots of things are still in progress.


Add garbd package and arbitrator job

Open for suggestions. Currently requires SSL. Does static linking on boost, so that it can run on stemcell without requiring local dynamic libs.
Initial issue here: https://github.com/cloudfoundry-incubator/pxc-release/issues/8

Closing this due to lack of strong interest from community & core pxc-release team.


Change view name from ping to pong

So much better (:
patterns = [
    Pattern('ping', pong),
]

missing changing this on docs and readme (:

@leportella done.


dns/bind: Recording pagination fix

Pagination of DNS records was broken. After selecting a domain all records have been shown and page keys were out of function. Filtering did not work as well.
Additionally the default number of domains shown was reduced to 3 as typical deployments have few domains (but many records each). Default display of 7 does not work well for smaller screens such as 13" notebooks...

@8191 Could you possibly fix your branch? It has diverged (probably because you've merged the master branch instead of rebasing the changed on top of the master branch) and cannot be merged in this state. Thanks!

W00t, squash looks good to me ;)

@8191 Could you possibly fix your branch? It has diverged (probably because you've merged the master branch instead of rebasing your changes on top of the master branch) and cannot be merged in this state. Thanks!

@fraenki Thank's for that hint. I already thought that something is wrong with my PR as so many commits were stated....
So in future to update my local branch to the upstream I should use rebase then merge?

Rebase and/or merge --ff-only should usually do the trick. (See this for more details.)

@fraenki we still prefer squash for history of GitHub based edits or long merge periods

@fichtner Sure, when there's no real commit message (except "Update foo.bar") then there's no point keeping the commit history.

It would seem it depends on how meticulous the committer is preparing and editing the PR. ;) For most scenarios and to save time committers might not have (e.g. to fight git dragons) GitHub can severely speed up the process and clean up the commit  history. Some times, even with clean merges, it can be harder to find corresponding commits in the timeline.

@fichtner Good to know. I'm used to provide PRs with clean git history, because most projects will reject everything else.


Exception in thread "main" java.lang.NoClassDefFoundError: javafx/application/Application$Parameters

This is a continuation of the following:
https://github.com/Col-E/Recaf/issues/72
https://github.com/Col-E/Recaf/issues/79
I have exactly the same issue and tried tree different JDK:
  [1]   icedtea-bin-8  system-vm
  [2]   openjdk-bin-11
  [3]   oracle-jdk-bin-11  user-vm

Here is the last error:
/opt/oracle-jdk-bin-11.0.2/bin/java -jar recaf-1.13.1.jar
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on
Exception in thread "main" java.lang.NoClassDefFoundError: javafx/application/Application$Parameters
        at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
        at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3167)
        at java.base/java.lang.Class.getDeclaredMethods(Class.java:2310)
        at me.coley.event.AccessHelper.getMethodsRecursively(AccessHelper.java:347)
        at me.coley.event.EventBus.getInvokers(EventBus.java:128)
        at me.coley.event.EventBus.subscribe(EventBus.java:51)
        at me.coley.event.EventBus.subscribe(EventBus.java:75)
        at me.coley.event.Bus.subscribe(Bus.java:46)
        at me.coley.recaf.Recaf.main(Recaf.java:20)
Caused by: java.lang.ClassNotFoundException: javafx.application.Application$Parameters
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
        ... 9 more

After some googling, I have discovered the following:
https://www.infoworld.com/article/3305073/removed-from-jdk-11-javafx-11-arrives-as-a-standalone-module.html
Could you add a standalone module as suggested or re-write a  tool without that library?

As PoC, I have downloaded https://gluonhq.com/products/javafx/ as suggested in the link above, unpacked it into "javafx" directory and managed to run the tool with the following:
java -cp 'recaf-1.13.1.jar:javafx/*' me.coley.recaf.Recaf

I've not set my sights on cross-version (Because java 8 to java 9+ is more complex than prior major version updates) compatibility yet. As far as I'm aware Java 8 is still the most widely installed version, so I'm targeting it. The extent of my Java 9+ support is preventing crashes like this, while pointing users to a quick update guide: https://col-e.github.io/Recaf/jigsaw.html
I have removed the usage of Application$Parameters
Regarding the "config" menu not working, the ControlsFx dependency will need to be updated as well as mentioned in the update guide.

regarding the update guide, you should do it automatically using profiles:
https://stackoverflow.com/questions/36043605/pass-jvm-args-to-maven-surefire-conditional-on-build-java-version
https://maven.apache.org/guides/introduction/introduction-to-profiles.html

Fair point, I had tried using profiles before and couldn't get them to work. Now they seem to be fine. I'll make a commit for this suggestion.
Regarding my removal of Application$Parameters, sometimes there are cases where I'd need two version-specific source files. Those are the cases I'm trying to eliminate.

Closing since this specific problem has been resolved as of 6a48b20ade51978719256c574b0dd966146d925c
Another thread on better cross version compatibility in general is warranted though.


[ROM] Confirm default flash settings are sufficient for boot strap

We need to confirm that the default proprietary settings of flash registers are sufficient for boot-strap.
The details of this issue may need to be discussed offline, however filing an issue to track it first.

we've discussed this issue offline and I believe the consensus is this is okay.


Template comparison

Description
Creating the possibility of comparing templates and listing their differences.
Ability to compare

CLI template with Feature template,
CLI template with the current config,
Feature template with current config

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/issues/59


Incorporate aircraft observations pairing into driver

I started setting up the pairing for aircraft observations. All of this is in a jupyter notebook in MELODIES-MONET/melodies_monet/examples/jupyter_notebooks/Monet-analysis-example-plots-cmaq-vert2.ipynb. We need to convert this pairing into the driver.
Then once this is done. Jian, Siyuan, and I can begin to incorporate our python matplotlib plotting routines in as well. I will work on this likely in December. If others want to help move this forward faster let me know.

Added Vertical Profile plot(s) (specific to FIREX as a first example): [https://github.com/NOAA-CSL/MELODIES-MONET/pull/181/files]

Pairing has successfully been incorporated into the driver in the develop_aircraft branch for
mobile and ground
https://github.com/NOAA-CSL/MELODIES-MONET/pull/185
and aircraft
https://github.com/NOAA-CSL/MELODIES-MONET/pull/101
So I'm closing this issue as basic pairing has been incorporated.


Event Sourcing and Laravel Nova...

This may not be the best place to ask the question, but I wasn't sure where else I could ask and I figured someone from Spatie would have some good insight....  :-)
So...I've just started to build up a new project using this package, planning to take an event sourcing approach.  Since the announcement of Nova, I've also planned to use that as an admin tool.  Last night I realized that Laravel Nova and any event sourcing model probably won't play nice together.
Can anyone offer any insight into this?  Event sourcing is something I'd like to do.  Laravel Nova is something I pretty much need to use (assuming it works as advertised).  Before I go much further, I'd like to know if I'm wasting time with event sourcing on this particular project.  (There is another project on the horizon that will not need something like Laravel Nova and so I can apply event sourcing when I work on that.)
Thanks in advance for any feedback/discussion/whatever.  :-)

We already built a test app with Nova and laravel-event-projector. So it's perfectly possible to use them both.
Because Nova isn't released yet I can't share more details now. When Nova is released we'll publish our test app.

@freekmurze Thanks for the quick feedback.  Of course, I'm a bit skeptical of how much effort will be required to make Nova work with an app the uses event sourcing...but without any real details, I'm left to my imagination.  ;-)
Whatever the case...I understand.  It's also encouraging to hear that you've "already built a test app" with the two packages.  That shows me that, if nothing else, you valued both of these enough to make sure that they could work together.
So...I'll try to wait patiently for Nova's release and your test app's publication.  :-)
Thanks again.

This is just a guess based on Taylor's presentation on Nova at laracon US. I do not nor have I ever had access to Nova:
Nova works on top of models. Your projectors likely make models based on events. Nova will be able to access these models like any other models, so displaying existing data will work out-of-the-box (assuming your projectors are working).
Writing to models is the tricky part. You can't let Nova just update models. However, Nova seems to be fully customizable and extendable, so it's probably safe to assume that there will be a way to make it emit events instead of directly mess with models. This may not be trivial, but may be something that possibly gets solved with a nova package (wink-wink nudge-nudge).
So, to get nova working with event sourced projects, some additional legwork will be necessary, but it would still probably be less work than making the admin panel from scratch.

@36864 Thanks for your input.
You said, "Writing to models is the tricky part."  Yes...this is the part that I'm skeptical about.  How difficult will it be to stop Nova from adding/updating/deleting models and fire events instead...?  As you say, "[t]his may not be trivial".  (I find that when one diverges too far from default, out-of-the-box behavior, then maintaining/updating can often become a difficult task.)

wink-wink nudge-nudge

LOL!

So, to get nova working with event sourced projects, some additional legwork will be necessary

Yes, it's this that I fear...the additional legwork.  How much and how big of an impact will it have moving forward...?  (Rhetorical, btw.)

it would still probably be less work than making the admin panel from scratch.

Good point.  :-)
Thanks again.

Writing to models is the tricky part. You can't let Nova just update models. However, Nova seems to be fully customizable and extendable, so it's probably safe to assume that there will be a way to make it emit events instead of directly mess with models. This may not be trivial, but may be something that possibly gets solved with a nova package (wink-wink nudge-nudge).

I got model updates to work with this package + Nova. Nova still updated the model, and I stored the changes by listening to model events. It doesn't really matter that Nova does an actual update, since you'll end up at the same spot after applying your update event in a CRUD scenario. Maybe it could work without saving the model in Nova by listening to other events, but I'd need to do some more testing to find out.
So that was pretty easy to get set up, however, I was kind of stumped when trying to store model relationship changes in Nova, since those don't necessarily have a model event attached to them. Might be a way, but haven't had the time to tinker further.

@sebastiandedeyne Thanks for your input.
Why is everyone else getting to try out Nova, but not me...?!  ;-)
Anyway, you've touched on some of my concerns as well as introduced new, related concerns.  (I hadn't even considered model relationship changes yet.)
It looks like I will have to wait to see for sure.  I'm happy to hear people saying that Laravel Nova and spatie/laravel-event-projector can/will/should play nicely together, but I'm also fearful of all the extra (re)wiring that might be required...as well as all of the unintended consequences, side effects, and gotchas.  This would be on top of having to deal with a first attempt at an event sourced application.
It aggravates me, but I may have to "go traditional" on this app since the combination may be a bit much (right now) and losing Nova would seem to be the greater loss when having to choose between the two.
Anyway...thanks again for the feedback/info.  Helpful...!  :-)

@freekmurze

When Nova is released we'll publish our test app.

I'm sure you've got a lot going on right now ;-), but whenever you have an opportunity to publish/share your test app, I would be quite interesting in taking a look.  In addition, if you or anyone else has any suggestions/advice/tips/etc, particularly around sourcing complex relationship events, if that makes sense, that would be great, too.  (By sourcing complex relationship events, I mean working with Nova to capture events related to many-to-many relationships, for example....attaching, detaching, synching.)
I hope that makes sense.  I'll be getting Nova for my current project...and I'm just hoping that I'll also be able to use laravel-event-projector with it.  :-)
Thanks...!  :-)

Here you go: https://github.com/spatie/nova-app-event-projector
It's just a proof of concept, we don't actually give support for that app.

Thx....and understood, of course.  :-)


[Link rule reference] example error

i have a try with the [Link rule reference] example:
lk_ref.tx
ScreenType:
  'screen' name=ID "{"
  '}'
;

ScreenInstance:
  'screen' type=[ScreenType]
;

lk.hello
// This is a definition of the ScreenType object
screen Introduction {

}

// And this is a reference link to the ScreenType object defined above
// ScreenInstance instance
screen Introduction

then i have a check with the command
textx check lk.hello --grammar lk_ref.tx
Error: None:5:1: error: Expected EOF at position lk.hello:(5, 1) => 'ion {  }  *screen Int'

what is wrong ???

The snippet is not complete. It just shows usage of link rule reference in a larger grammar.
For a complete stuff see examples or tutorials section of the docs. For example robot tutorial or for a link rule reference entity tutorial.

thanks very much  for your quick response


Discord Server

We should create a discord server so we can collaborate easily and have better communication.

Or maybe we can invite you to the town discord and just create a channel on there

From: Choyu @.>
Sent: Friday, 5 May 2023 2:40 PM
To: the-oom-town/town-interactive @.>
Cc: Subscribed @.***>
Subject: [the-oom-town/town-interactive] Discord Server (Issue #9)
We should create a discord server so we can collaborate easily and have better communication.
—
Reply to this email directly, view it on GitHubhttps://github.com/the-oom-town/town-interactive/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUOBLVXTIRZXPHELWAZXQQLXESOFBANCNFSM6AAAAAAXWWTL4A.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Check your emails
Yours sincerely,
Taj

From: Choyu @.>
Sent: Friday, 5 May 2023 3:38 PM
To: the-oom-town/town-interactive @.>
Cc: VAN DER KLAUW Taj @.>; Comment @.>
Subject: Re: [the-oom-town/town-interactive] Discord Server (Issue #9)
sure that works
—
Reply to this email directly, view it on GitHubhttps://github.com/the-oom-town/town-interactive/issues/9#issuecomment-1535849909, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUOBLVSSDFHVKHFLK6NORBTXESVANANCNFSM6AAAAAAXWWTL4A.
You are receiving this because you commented.Message ID: @.***>


Repo sync for protected CLA branch

The pull request is created from main637804600846363016 to main to fix git push error for protected CLA branch

@opbld16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


How to use DM with ResNet18BN

Hi, I want to use DM with ResNet18BN and test in the ResNet18BN, but the performance is poor e.g. 12%(worse than random selection which is 14.6% in your report) under the setting where dataset=cifar100, ipc=10. I only replace the --model  parameter. I don't know if that's normal. Do I need to change other hyperparameters?. Thanks very much for your replay.

Hi, please refer to the closed issues on this question.
https://github.com/VICO-UoE/DatasetCondensation/issues/30
https://github.com/VICO-UoE/DatasetCondensation/issues/11
https://github.com/VICO-UoE/DatasetCondensation/issues/8

Thank you very much. I will try it with smaller learning rate.