Compile error: Cannot redeclare block-scoped variable DEBUG_BUILD

Environment
Node 18.13.0
macOS Sonoma 14.0
Use sentry libs:
"@sentry/angular-ivy": "7.77.0",
"@sentry/capacitor": "0.14.0",
"@sentry/types": "^7.77.0",
Application libs:

Ionic 7.0.7 / Angular 15 / Capacitor 5

2     const __DEBUG_BUILD__: boolean;
            ~~~~~~~~~~~~~~~

  node_modules/@sentry/capacitor/node_modules/@sentry/types/types-ts3.8/globals.d.ts:2:11
    2     const __DEBUG_BUILD__: boolean;
                ~~~~~~~~~~~~~~~
    '__DEBUG_BUILD__' was also declared here.

Error: node_modules/@sentry/capacitor/node_modules/@sentry/types/types-ts3.8/globals.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.

2     const __DEBUG_BUILD__: boolean;
            ~~~~~~~~~~~~~~~

  node_modules/@sentry/browser/node_modules/@sentry/types/types-ts3.8/globals.d.ts:2:11
    2     const __DEBUG_BUILD__: boolean;
                ~~~~~~~~~~~~~~~
    '__DEBUG_BUILD__' was also declared here.

✖ Failed to compile.

Same issues:

https://github.com/getsentry/sentry-capacitor/issues/394
https://github.com/getsentry/sentry-capacitor/issues/249

Use only next versions:
"@sentry/angular-ivy": "7.73.0",
"@sentry/capacitor": "0.14.0",


Allow datatoken holders to call order and download only for consuming datasets

Even tho the ocean market handles consume for both standard and enterprise templates, it does not allow datatoken holders to call order and download only when trying to consume an asset on the ocean market, we always ask them to also buy the datatoken from the exchange.
In the market we also have a confusing label or helper message for the buy button telling users they don't need to pay for the dt even tho we ask them to do that, so we need to coordinate this with actual codebase.

fixed in #1912


Adding AWS ELB ingress implementation

Here is the code for an AWS ELB ingress implementation. This code mostly comes from the docker for AWS code base, and refactored to work with infrakit's L4 loadbalancer implementation.
This does not include the code for handling ACM/TLS/SSL certificates, that will come in a follow up PR.
There might be some extra code that might not be needed in the future, we can remove that in a future PR, once it has been refactored.
This has been tested using a local plugin pointing to us-west-1. I was able to add, remove and list the backends, and routes via the CLI.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "elb-ingress" git@github.com:kencochrane/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354029080
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


for loop

Hey thanks for contributing! 👍  Is there a specific reason this syntax should be preferred? Unless there's a benefit, I'd rather keep the syntax of the for-loops consistent.

Only for reason to keep the file size smaller. It's your choice.


Ensure relative links in markdown work in the HTML

@mwcraig mentioned that relative links in the markdown / notebooks sometimes do not resolve properly when the site is converted to HTML. @mwcraig could you provide an example of where this kind of thing breaks so we can try designing around it?

Sorry for the delay -- the context for this is that I want links between notebooks that will work if someone clones the notebooks  and runs them in  Jupyter and I want those links to work between the rendered HTML pages in jupyter book.
An example is at https://github.com/mwcraig/ccd-reduction-and-photometry-guide/blob/master/notebooks/02-01-Calibrating-bias-images.ipynb?short_path=1129ddd#L68
The link [Preface notebook](00-00-Preface.ipynb) does not, by default, work in the rendered book because 00-00-Preface.ipynb isn't part of the rendered book.
I do have the links working in the rendered version of the book; this rendered page is at https://mwcraig.github.io/ccd-as-book/02-01-Calibrating-bias-images.html#data-for-these-examples
In my case I have a separate repo for the source notebooks, which does not store the notebooks with output, and the repo for the book, which has the executed notebooks.
I'll add another comment in a moment with a link to the code I used to transform the links. I'm happy to contribute it here but would need some guidance as to where to put it (also fine if it doesn't make sense for it to be here).

Here is the code I wrote for replacing the links. In the workflow I'm using now, this is done after I've run nbconvert to execute the notebooks and generate output.
https://github.com/mwcraig/ccd-reduction-and-photometry-guide/blob/master/notebooks/process_for_book.py#L79

hey @mwcraig - any chance you could add your functions to the jupyter-book build process? I think that this is a pretty common issue and it'd be a helpful fix for others! You could put the "find links and replace w/ new extension" stuff here:
https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/utils.py
and then call it just after creating the HTML here:
https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/page.py#L111
What do you think?

Sure, I should be able to do that this weekend.

Bumping this one to v0.7.0 since I think we shouldn't block 0.6.4 on this one...@mwcraig it'd be awesome to see this functionality in Jupyter Book if you still have the time!

Only one more week of classes, only one more week of classes, only one more week of classes...

Closing as this should be superceded by beta.jupyterbook.org


Update Insights packages and fix dev-dependency

Update Insights packages and fix devDependencies.
Note: I've split these updates from the PatternFly milestone build in order to help isolate test issues.
https://issues.redhat.com/browse/COST-2503

Codecov Report

Merging #2365 (068c55d) into main (823a335) will increase coverage by 0.05%.
The diff coverage is 100.00%.

:exclamation: Current head 068c55d differs from pull request most recent head 05b61c7. Consider uploading reports for the commit 05b61c7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   68.83%   68.89%   +0.05%
==========================================
  Files         412      412
  Lines        7856     7877      +21
  Branches     1859     1861       +2
==========================================
+ Hits         5408     5427      +19
+ Misses       2444     2329     -115
- Partials        4      121     +117

Impacted Files
Coverage Δ

src/locales/messages.ts
100.00% <ø> (ø)

...rc/pages/costModels/components/inputs/selector.tsx
97.05% <100.00%> (+2.32%)
:arrow_up:

.../pages/costModels/components/rateForm/rateForm.tsx
96.82% <100.00%> (-3.18%)
:arrow_down:

src/utils/cookie.ts
58.33% <0.00%> (ø)

src/utils/format.ts
66.66% <0.00%> (ø)

src/api/orgs/orgUtils.ts
37.50% <0.00%> (ø)

src/api/queries/query.ts
43.85% <0.00%> (ø)

src/utils/localStorage.ts
79.74% <0.00%> (ø)

src/store/metrics/selectors.ts
75.86% <0.00%> (ø)

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fadc7...05b61c7. Read the comment docs.


Error during Linking on Ubuntu 18.04 with LLVM 7.0.1

I am experiencing issues on ubuntu 18.04 when compiling with gcc which has --enable-default-pie and LLVM 7.0.1 (from releases.llvm.org):
/usr/bin/ld.gold: error: ./stdlib.o: requires dynamic R_X86_64_32 reloc against 'pony_personality_v0' which may overflow at runtime; recompile with -fPIC
Interestingly this only hits us with LLVM 7.0.1 compiled from source (with vendored LLVM using make -f Makefile-lib-llvm ...) or downloaded as pre-compiled libs from releases.llvm.org. The ubuntu-packaged LLVM 7.0.1 works fine.
The LLVM prebuilt binaries from the release seem to be compiled using clang 7.0.1 from the same release: https://github.com/llvm/llvm-project/blob/master/llvm/utils/release/test-release.sh#L550-L612
Steps to reproduce:

build this Dockerfile with docker build --force-rm -t pony:pie-issue .
It will fail to compile the helloworld example

FROM "ubuntu:bionic"

ENV LLVM_VERSION=7.0.1
RUN apt update && apt install -y build-essential git zlib1g-dev libncurses5-dev libssl-dev libpcre2-dev xz-utils wget
RUN mkdir llvm && \
    cd /llvm && \
    wget releases.llvm.org/$LLVM_VERSION/clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04.tar.xz && \
    xz -d clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04.tar.xz && \
    ls -ahl && \
    tar xvf clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04.tar && \
    mv clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04 llvm-$LLVM_VERSION
RUN git clone https://github.com/ponylang/ponyc.git && \
    cd ponyc/ && \
    make default_pic=true default_ssl=openssl_1.1.0 LLVM_CONFIG=/llvm/llvm-$LLVM_VERSION/bin/llvm-config && \
    ./build/release/ponyc examples/helloworld/

Failure:
/usr/bin/ld.gold: error: ./helloworld.o: requires dynamic R_X86_64_32 reloc against 'ponyint_personality_v0' which may overflow at runtime; recompile with -fPIC
collect2: error: ld returned 1 exit status

ld.gold is called from cc with -pie which is raising that error. If -pie is removed from the ld.gold call, the link-step succeeds.
Somehow ponyint_personality_v0 is the only offending symbol it seems that does not play well with -pie. In an object file produced by ponyc compiling the helloworld example, the relocations for ponyint_personality_v0 are listed as follows:
Relocation section '.rela.eh_frame' at offset 0x5a60 contains 13 entries:
  Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000020<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 0
00000000005c<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1f0
0000000000bc<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 490
0000000000f3  004b0000000a R_X86_64_32<PHONE_NUMBER>000000 ponyint_personality_v0 + 0
000000000108<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 8d0
000000000111<PHONE_NUMBER>0a R_X86_64_32<PHONE_NUMBER>000000 .gcc_except_table + 0
000000000158<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + b60
000000000174<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + e20
0000000001c0<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 13c0
0000000001dc<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 14e0
000000000218<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1770
000000000234<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1850
000000000260<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1970

In an object file produced by ponyc compiled against LLVM 7.0.1 from apt.llvm.org (here linking succeeds even with -pie) the relocations are listed like this:
Relocation section '.rela.data.DW.ref.ponyint_personality_v0' at offset 0x5a30 contains 1 entry:
  Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000000  004c00000001 R_X86_64_64<PHONE_NUMBER>000000 ponyint_personality_v0 + 0

Relocation section '.rela.eh_frame' at offset 0x5a48 contains 13 entries:
  Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000020<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 0
00000000005c<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1f0
0000000000bc<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 470
0000000000f3<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 DW.ref.ponyint_persona + 0
000000000108<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 8a0
000000000111<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .gcc_except_table + 0
000000000158<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + b30
000000000174<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + de0
0000000001c0<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1370
0000000001dc<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1490
000000000218<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1720
000000000234<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1800
000000000260<PHONE_NUMBER>02 R_X86_64_PC32<PHONE_NUMBER>000000 .text + 1910

I am not sure where the differences in the generated object files come from.
The LLVM from apt lists the host-target as: x86_64-pc-linux-gnu. vendored and precompiled LLVM both list the target as x86_64-unknown-linux-gnu. Maybe this results in the differences in the object files.
Will investigate further, but marking this as needs discussion during sync as maybe more eyes on this can help.
What might work (as we don't use lld yet) is to detect a pie compiler and issue -nopie during linking. But this would need to be a check during runtime of ponyc.
Seems to be related to #1484

You said that the downloaded version was compiled with clang, if so I believe you need to compile ponyc with clang. Have you tried that.
What happens when you compile ponyc and vendored LLVM with clang?

I compiled vendored LLVM and ponyc with clang and everything worked fine for me.

Vendored LLVM built with clang + ponyc compiled with gcc. Doesn't work.
ponyc builds but when attempting to link examples/helloworld I get:
Error:
/usr/bin/ld.gold: error: ./helloworld.o: requires dynamic R_X86_64_32 reloc against 'ponyint_personality_v0' which may overflow at runtime; recompile with -fPIC
collect2: error: ld returned 1 exit status
Warning: environment variable $CC undefined, using cc as the linker
Error:
unable to link: cc -o ./helloworld -O3 -march=native -mcx16 -latomic  -fuse-ld=gold ./helloworld.o -L"/home/sean/code/ponylang/ponyc/build/release/" -Wl,-rpath,"/home/sean/code/ponylang/ponyc/build/release/" -L"/home/sean/code/ponylang/ponyc/build/release/lib/native" -Wl,-rpath,"/home/sean/code/ponylang/ponyc/build/release/lib/native" -L"/home/sean/code/ponylang/ponyc/build/release/../../packages" -Wl,-rpath,"/home/sean/code/ponylang/ponyc/build/release/../../packages" -L"/usr/local/lib" -Wl,-rpath,"/usr/local/lib" -Wl,--start-group -Wl,--end-group  -lpthread  -lponyrt-pic -ldl -lm

I compiled vendored LLVM  with clang:
Command line:
make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 use=llvm_link_static -j4 CC=/usr/bin/clang CXX=/usr/bin/clang++

Versions:
> clang --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

> clang++ --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Then in top level ponyc directory I ran:
make clean LLVM_CONFIG=./lib/llvm/build/bin/llvm-config
to remove the ponyc. Then did:
make default_pic=true default_ssl=openssl_1.1.0 LLVM_CONFIG=./lib/llvm/build/bin/llvm-config CC=cc CXX=c++
to build with gcc.
Versions:
>  cc --version
cc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

>   c++ --version
c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Vendored LLVM built with clang + ponyc compiled with gcc & clang. Does work.
This is the same as my above example EXCEPT, I use the same c++ compiler (clang++) when compling LLVM and ponyc. So, problem is definitely related to the C++ bits.
I compiled vendored LLVM  with clang:
Command line:
make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 use=llvm_link_static -j4 CC=/usr/bin/clang CXX=/usr/bin/clang++

Versions:
> clang --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

> clang++ --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Then in top level ponyc directory I ran:
make clean LLVM_CONFIG=./lib/llvm/build/bin/llvm-config
to remove the ponyc. Then did:
make default_pic=true default_ssl=openssl_1.1.0 LLVM_CONFIG=./lib/llvm/build/bin/llvm-config CC=cc CXX=/usr/bin/clang++
to built with gcc version:
>  cc --version
cc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

and clang++
> clang++ --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

I think this is a good reason for us to start using a vendored LLVM where-ever possible. And we can include the pony_personality error as an FAQ on the website.

@winksaville when both are compiled with clang, everything works ok.
Here is a reproducing Dockerfile for vendored llvm. The final step, compiling examples/helloworld fails with the error described above:
FROM "ubuntu:bionic"

RUN apt update && apt install -y build-essential git zlib1g-dev libncurses5-dev libssl-dev libpcre2-dev xz-utils wget cmake python3 clang-7
RUN git clone https://github.com/ponylang/ponyc.git && \
    cd ponyc/ && \
    CC=clang-7 CXX=clang++-7 make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 -j8
RUN cd ponyc/ &&\
    make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 clean && \
    make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 -j8 && \
    ./build/release/ponyc examples/helloworld/

Interestingly, compiling both llvm and ponyc with gcc, but llvm with -no-pie and ponyc with -pie works fine.

Glad to here that my hypothesis that compiling with the same compiler
works. Although I have no idea if mixing PIE and non-PIE is a supported
configuration.
On Sun, Mar 17, 2019, 1:53 PM Matthias Wahl<EMAIL_ADDRESS>wrote:

@winksaville https://github.com/winksaville when both are compiled with
clang, everything works ok.
Here is a reproducing Dockerfile for vendored llvm. The final step,
compiling examples/helloworld fails with the error described above:
FROM "ubuntu:bionic"
RUN apt update && apt install -y build-essential git zlib1g-dev libncurses5-dev libssl-dev libpcre2-dev xz-utils wget cmake python3 clang-7
RUN git clone https://github.com/ponylang/ponyc.git &&
cd ponyc/ &&
CC=clang-7 CXX=clang++-7 make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 -j8
RUN cd ponyc/ &&
make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 clean &&
make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 -j8 &&
./build/release/ponyc examples/helloworld/
Interestingly, compiling both llvm and ponyc with gcc, but llvm with
-no-pie and ponyc with -pie works fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ponylang/ponyc/issues/3099#issuecomment-473713662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-hHOap9vyDtNA8ZsVz72eczj3tSipOks5vXqssgaJpZM4b4BL0
.

Are you expecting the following to work or not?

FROM "ubuntu:bionic"

RUN apt update && apt install -y build-essential git zlib1g-dev libncurses5-dev libssl-dev libpcre2-dev xz-utils wget cmake python3 clang-7
RUN git clone https://github.com/ponylang/ponyc.git && \
    cd ponyc/ && \
    CC=clang-7 CXX=clang++-7 make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 -j8
RUN cd ponyc/ &&\
    make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 clean && \
    make -f Makefile-lib-llvm default_pic=true default_ssl=openssl_1.1.0 -j8 && \
    ./build/release/ponyc examples/helloworld/

Interestingly, compiling both llvm and ponyc with gcc, but llvm with -no-pie and ponyc with -pie works fine.

This seems to be related to some sort of memory corruption. Not sure of the root cause but the following steps show memory corruption impacting the PIC option for the LLVM TargetMachine.
Creating a docker image from the following Dockerfile:
FROM "ubuntu:bionic"

ENV LLVM_VERSION=7.0.1
RUN apt update && apt install -y build-essential git zlib1g-dev libncurses5-dev libssl-dev libpcre2-dev xz-utils wget
RUN mkdir llvm && \
    cd /llvm && \
    wget releases.llvm.org/$LLVM_VERSION/clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04.tar.xz && \
    xz -d clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04.tar.xz && \
    ls -ahl && \
    tar xvf clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04.tar && \
    mv clang+llvm-$LLVM_VERSION-x86_64-linux-gnu-ubuntu-18.04 llvm-$LLVM_VERSION
RUN git clone https://github.com/ponylang/ponyc.git

Within the container:
cd ponyc/

git apply the following diff:
diff --git a/src/libponyc/codegen/genopt.cc b/src/libponyc/codegen/genopt.cc
index 7d28ebda..1c247de0 100644
--- a/src/libponyc/codegen/genopt.cc
+++ b/src/libponyc/codegen/genopt.cc
@@ -1318,6 +1318,39 @@ static void optimise(compile_t* c, bool pony_specific)
   Module* m = unwrap(c->module);
   TargetMachine* machine = reinterpret_cast<TargetMachine*>(c->machine);

+  Reloc::Model rm = machine->getRelocationModel();
+
+  if(rm == Reloc::PIC_)
+  {
+    printf("@@@@@ RM is: Reloc::PIC_\n");
+  }
+  else if(rm == Reloc::Static)
+  {
+    printf("@@@@@ RM is: Reloc::Static\n");
+  }
+  else if(rm == Reloc::DynamicNoPIC)
+  {
+    printf("@@@@@ RM is: Reloc::DynamicNoPIC\n");
+  }
+  else if(rm == Reloc::ROPI)
+  {
+    printf("@@@@@ RM is: Reloc::ROPI\n");
+  }
+  else if(rm == Reloc::RWPI)
+  {
+    printf("@@@@@ RM is: Reloc::RWPI\n");
+  }
+  else if(rm == Reloc::ROPI_RWPI)
+  {
+    printf("@@@@@ RM is: Reloc::ROPI_RWPI\n");
+  }
+  else
+  {
+    printf("@@@@@ RM is not normal enum option: %d\n", rm);
+  }
+
+  pony_assert(machine->isPositionIndependent());
+
   llvm::legacy::PassManager lpm;
   llvm::legacy::PassManager mpm;
   llvm::legacy::FunctionPassManager fpm(m);
diff --git a/src/libponyc/codegen/host.cc b/src/libponyc/codegen/host.cc
index a1556a29..cc891f0d 100644
--- a/src/libponyc/codegen/host.cc
+++ b/src/libponyc/codegen/host.cc
@@ -25,7 +25,10 @@ LLVMTargetMachineRef codegen_machine(LLVMTargetRef target, pass_opt_t* opt,
   Optional<Reloc::Model> reloc;

   if(opt->pic || opt->library)
+  {
     reloc = Reloc::PIC_;
+    printf("@@@@@@@@@@@@@@@@@@ Just set PIC!!\n");
+  }

   CodeGenOpt::Level opt_level =
     opt->release ? CodeGenOpt::Aggressive : CodeGenOpt::None;

Then run:
make default_pic=true default_ssl=openssl_1.1.0 LLVM_CONFIG=/llvm/llvm-$LLVM_VERSION/bin/llvm-config
./build/release/ponyc -V 3 examples/helloworld/

I see the following output to ./build/release/ponyc -V 3 examples/helloworld/:
root@ab38f8bd4000:/ponyc# ./build/release/ponyc -V 3 examples/helloworld/
Building builtin -> /ponyc/packages/builtin
Building examples/helloworld/ -> /ponyc/examples/helloworld
Program signature: D75464F9405BA695811B9742705EA91D65FE1468DA4B67178231964B751D3A54BB695CB42D38BDAC5A27648377F1B6B0E6E652DF5131B014ED80C959DCDA80A0

Group 0
Signature: 759568A330DFC108B19F8A343F6222F52AB9B2A6E5DDEC0B948D0418068785F10DD3DB120492D982C700A05B96DC59DBE8984422ED3D2C92A2FBB9D818C1B23D
Members:
  builtin
Dependencies:

Group 1
Signature: E8664E7821EAD801024FDBF026B86088E49CB40F9C90808665C0889E105B0D33ABED6C11F0AC60958E0336B8D9E224552341AB7B5EA8D213055E1C1814B1AD9E
Members:
  helloworld
Dependencies:
  builtin

Generating
@@@@@@@@@@@@@@@@@@ Just set PIC!!
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
@@@@@ RM is not normal enum option:<PHONE_NUMBER>
src/libponyc/codegen/genopt.cc:1352: optimise: Assertion `machine->isPositionIndependent()` failed.

Backtrace:
  ./build/release/ponyc(ponyint_assert_fail+0xa2) [0x560c438def22]
  ./build/release/ponyc(+0x616dff) [0x560c4381fdff]
  ./build/release/ponyc(genopt+0x3f) [0x560c438206ef]
  ./build/release/ponyc(genexe+0x256) [0x560c438adf26]
  ./build/release/ponyc(codegen+0xd4) [0x560c4381d664]
  ./build/release/ponyc(+0x602ac6) [0x560c4380bac6]
  ./build/release/ponyc(main+0x10f) [0x560c43782e6f]
  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7f4323cf1b97]
  ./build/release/ponyc(_start+0x2a) [0x560c4380b9aa]
This is an optimised version of ponyc: the backtrace may be imprecise or incorrect.
Use a debug version to get more meaningful information.
Aborted (core dumped)
root@ab38f8bd4000:/ponyc#

Our plan to address these weird issues is to only support building from source using vendored LLVM. We won't intentionally break using the system llvm but if issues arise, it is on the person building to resolve.

This might be a candidate for the bug we are hitting here: https://bugs.llvm.org/show_bug.cgi?id=39427
Gonna investigate if the new 7.1.0 llvm release indeed fixes this.

@mfelsche can you verify that this is fixed with LLVM 7.1.0 and then we can close this?

I've verified the fix. Closing.


re-implemented property deletion transformation (GSI-531)

... based on schemapack.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

307 of 337 (91.1%)  changed or added relevant lines in 19 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 92.131%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/metldata/schemapack_/builtin_transformations/delete_properties/data_transform.py
12
13
92.31%

src/metldata/schemapack_/builtin_transformations/infer_relations/model_transform.py
13
14
92.86%

src/metldata/schemapack_/transform/base.py
3
4
75.0%

src/metldata/schemapack_/builtin_transformations/delete_properties/assumptions.py
8
10
80.0%

src/metldata/schemapack_/builtin_transformations/delete_properties/model_transform.py
19
21
90.48%

src/metldata/schemapack_/builtin_transformations/infer_relations/relations.py
17
19
89.47%

src/metldata/schemapack_/builtin_transformations/infer_relations/data_transform.py
40
43
93.02%

src/metldata/schemapack_/builtin_transformations/infer_relations/assumptions.py
21
26
80.77%

src/metldata/schemapack_/builtin_transformations/infer_relations/path/path_str.py
61
66
92.42%

src/metldata/schemapack_/builtin_transformations/infer_relations/path/path.py
27
35
77.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
3161

Relevant Lines:
3431

💛  - Coveralls


/integrations/: Fix sidebar overflowing parent container.

The sidebar height was set to shorter than what the sidebar actually
was and so it would overflow the parent. By resetting it, it now
will not overflow.
Fixes: #6315.

Looks great, merged since this fixes the proximal issue.  Is there a way we can make it calculate the height based on how many things are in that sidebar?  I bet the code was correct originally, and then we added another category...  If we don't have a better plan, we should at least add a warning comment by the categories.

Merged, thanks @brockwhittaker!


Megahal

Would be very nice to get a megahal implementation back up and running. Might require persistant functions

Moved to trello https://trello.com/c/fAphDv5G/215-megahal


caddyhttp/proxy: invalid use of Hijack in reverseproxy.go

Hello, in preparation for Go1.8, I detected this misuse of the http.Hijacker API.
reverseproxy.go makes a call to Hijack, but ignores the returned bufio.ReadWriter and proceeds to directly use the connection. In Go1.8, the probability that data is buffered in the bufio.Reader is increased, such that there is a higher change that this logic fails. The proper fix is to handle the data in the read buffer (accessed via brw.Reader.Peek(brw.Reader.Buffered())) and forward that to the backendConn before performing the pair of io.Copy calls.
See https://golang.org/cl/35232 for more information.
\cc @mholt

Dang, I'm swamped for a bit with other things. Can @lhecker or anyone else look into this?

I'd be fine with fixing this, but unfortunately I don't quite get why it doesn't work already. I was under the impression that the returned bufio.ReadWriter is basically just an aliased interface to the returned net.Conn. I thought if you read from the net.Conn it will also read all buffered bytes.
Can you explain (if you don't mind) why that's wrong? Or maybe you know where to find some sample code which makes use of the bufio.ReadWriter as well as the net.Conn?

You are correct that the returned bufio.ReadWriter wraps the net.Conn, which implies that the net.Conn does not wrap the bufio.ReadWriter. Thus, if there are bytes buffered in the bufio.Reader's read buffer, directly reading from the net.Conn will loose knowledge about those bytes.
One way to solve this is to use a wrapped net.Conn that returns the buffered bytes before reading from the connection.
type rbufConn struct {
	net.Conn
	rbuf []byte
}

func (c *rbufConn) Read(p []byte) (int, error) {
	if len(c.rbuf) > 0 {
		n := copy(p, c.rbuf)
		c.rbuf = c.rbuf[n:]
		return n, nil
	}
	return c.Conn.Read(p)
}

func (c *rbufConn) Close() error {
	c.rbuf = nil
	return c.Conn.Close()
}

// Elsewhere in the code (ignoring error checking):
c, brw, _ := resp.(http.Hijacker).Hijack()
rbuf, _ := brw.Reader.Peek(brw.Reader.Buffered())
c = &rbufConn{conn, rbuf}

@dsnet @mholt How's that?

The change LGTM.


Password Reset for Team Herringpp low fidelity design

Password reset page for (desktop, tablet and mobile) low fi

link to design page here: https://www.figma.com/file/xme07kO7eewd0OE5ffRA2o/Project-Chunking?node-id=394%3A554&t=PLqokrv9DI64demR-1


[ELE-47] feature: allow glue adapter

Partially resolves ELE-47
Description
This adds the needed macros to run both the dbt-data-reliability logging process in a dbt-glue set up and the macros needed for by the Elementary CLI.
It uses the Delta file format by default and therefore needs a glue environment that can use Delta. I add a new issue for other file formats.
However, since we use Delta Lake file format, we need to use a specific Glue Session :
Can anyone tell me how I could add disclaimers about it ?
FYI : I am sure this PR needs testing but I don't know how to do them, I would be grateful for advises on that 🙏
Tests that were run locally

Hi @Jeremynadal33 !
I haven't had the chance to review the PR yet, but I wanted to comment on testing.
Please see the instructions here - you should see here how to run our integration tests with py.test.
Please let me know if you have any questions.
Cheers,
Itamar

Hi there,
Thanks a lot for your reactivity! I actually saw the test suit after submitting the PR... Haha. We are currently testing it and will get back to it as soon as we are done !
Thanks again


fix: remove duplicated line in circleci config

remove duplicated line in circleci config
Did you sign your commit? Instructions: 👍
Have you read Contributing guidelines?: 👍

superseded by https://github.com/kumahq/kuma-net/pull/42


serialize 0x prefix string object key as number

Encountered this while using SolidStart.
When object string key contains 0x prefix it gets serialised as hex number.
For context, address identifiers in crypto such as Ethereum are commonly hex addresses.
import { deserialize, serialize } from "seroval"

const original = {
  "0x1": 2
}

const output = serialize(original)
console.log("output", output)
// output ({0x1:2})

const result = deserialize(output)
console.log("deserialize", result)
// deserialize { '1': 2 }

Hmm I thought I handled this, will check

should be fixed in 1.0.3


Fix compile failure due to default C++ standard below 20

For some projects upgrading from older versions to UE5.2 or later, the default C++ standard used by the engine may not be C++20. This issue arises because the file ReviewComments.h contains syntax that is only supported in C++20:
bool bIsClosed : 1 = false;

This bitfield initialization will cause the module compilation to fail. Adding logic to ensure C++ standards in the module's Build.cs can solve this problem.

Thanks for the fix, accepted! :)


Templated Roles UI Step 1

This is bit of a work in progress, moving towards our new design. This could benefit from some more rigorous testing with more data, but I think we're close.
I opted to not move the "Next" button yet as I was intending to do that within its own batch of work.

[ ] Swap out the template_language check for the upcoming templated Boolean that we should be returning from the API soon.
[ ] Move the "Next" button inside each Step

The typeahead search here needs debounce

Migrating to Netflix/consoleme PR #9129


document parallel CLI import

Documents https://github.com/openmicroscopy/openmicroscopy/pull/5828 in the light of https://trello.com/c/5xiUFcMj/37-parallel-import-docs. Staged at https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/ws/src/omero/_build/html/users/cli/import.html and https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/ws/src/omero/_build/html/sysadmins/import-scenarios.html.

That would make sense.


So what do I do?

Do I just download the file, extract it, open Visual Studio (Blend), select the folder, and "compile" it? Or am I missing something here? Where do I even begin?
Sorry, I'm new to coding, and all these jitbits are really confusing me. I'll be glad to get clarifications and helpful guidance!

Pretty much it. You clone/download as zip -> open BlackBone.sln -> build solution.
I'll add some wiki articles about getting started in the near future.


requiring 4.0.4 leads to SyntaxError

With the update from version 4.0.3 to 4.0.3 I cannot require "type-detect/index.js" any longer, because it complains about a SyntaxError.
export default function typeDetect(obj) {
^^^^^^

Hello @illuxio, v4.0.5 just got released and should fix that. Sorry for the mess

Yes, I can confirm that it fixed the issue :+1:


Feature/pfio testcode jk

Description
Reorganized the PFIO standalone program to:

Break the code into small tasks
Mimic the steps of MAPL_Cap. This can be used as reference if PFIO is implemented in a non-GEOS model.
Include FORD tags for documenting the code.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X ] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[ ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[ ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Something is very wrong with this PR. It appears to make changes to unrelated files like the ACG.
Probably just a PR to the wrong branch?

@tclune I think this just needs to be pulled into develop and not main. I'm changing the base.

@mathomp4 Made changes in the CHANGELOG.md file. I am wondering if it will be enough.

@mathomp4 Made changes in the CHANGELOG.md file. I am wondering if it will be enough.

@JulesKouatchou I cleaned it up a bit. I think you got a bit of old develop into it, so I made it look like it should.


OpenAi/Claude: where to save api to call model?

in comfyui extension if_ai tools, how do i add api if i select openai "engine"?
I have run through the docs and dont see any place to add this??

found it
nice extension truly


Switching between pivot() and pivotUI()

I've noticed that simply removing the "UI" from the function call sort of breaks the table.  I had everything working just the way I wanted with pivotUI and just wanted to turn off the UI elements and leave the table, but doing so caused issues.  Is this something to be expected?

Yes, it is. Take a look at the documentation for each function here, including the warning that they take similar but different options :)
https://github.com/nicolaskruchten/pivottable/wiki/Parameters

ok, thanks.

I've just added a new showUI parameter that allows you to use pivotUI() without the UI.


181937962 share excitement

This branch implements a little more than the exact story by including a gif emoticon to display a deeper feeling so users have more tendency of sharing.

I went for the GIF library because it also supports adding gifs to text views like drawableEnd, which I thought might be useful when we want to advertise airtime.

Retry button in this branch crashes, but the fix is already bundled in the retry-Transaction PR.

Thanks, reverting the codebase to match actual spec. Will request for design thoughts on GIFs as a follow up item.


How best to use apex chart with data updated every second? I’m currently using updateSeries but every time I update the data, I loose the zoom range and also the download burger menu will automatically close. Filtering data using the clicking on the label also resets right after I call updateSeries

How best to use apex chart with data updated every second? I’m currently using updateSeries but every time I update the data, I loose the zoom range and also the download burger menu will automatically close. Filtering data using the clicking on the label also resets right after I call updateSeries
Originally posted by @azrin1972 in https://github.com/apexcharts/apexcharts.js/discussions/4029

How do I post an issue then?


Unable to to enable video camera on Mac desktop when Jitsi is embedded

When using Jitsi with Embed Jitsi video inside Mattermost I'm not able to turn on my camera when using Mattermost Mac OS desktop client v4.5.0 Running build https://github.com/mattermost/mattermost-plugin-jitsi/commit/013533b3f7a835e4cb279a8b3c6cf119b6625038
I see the follow error message

This does not occur in Chrome or when Embed Jitsi video inside Mattermost is disabled
Occurs for me on both hosted and cloud version of Jitsi
On a diffrent Windows machine I don't see the issue

Seems possible I have some OS level issue causing this. Please see if you can reproduce.
Steps:

Setup Jisti
Enable Embed Jitsi video inside Mattermost
Connect to server from desktop
Join a meeting

Observed

Camera remains disabled (normally turns on after a couple seconds)
Attempting to enable it shows a error in the Jisti UI

@DHaussermann yes, looks like permissions related like the share screen problem seen before.

I can explicitly try to request permissions using https://www.electronjs.org/docs/api/system-preferences#systempreferencesaskformediaaccessmediatype-macos

Camera is working for me in desktop app 4.4.0 in Arch Linux, maybe is mac thing

Please see some additional details here https://github.com/mattermost/desktop/issues/1330#issuecomment-649377999.

Camera is working for me in desktop app 4.4.0 in Arch Linux, maybe is mac thing

Yes it is MacOS thing...App needs to be signed with entitlements
https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_device_camera
https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_device_microphone

Any news on this? It's a bit confusing switching to the web version in order to use the jitsi plugin

Unsure if it helps, but in desktop app v4.6.2 we fixed an issue where macOS entitlements had not been enabled for using camera and microphone on the Desktop App for third-party plugins such as Jitsi -- https://docs.mattermost.com/help/apps/desktop-changelog.html#release-v4-6

QA in my company tested, and it still doesn't work unfortunately
On Tue, Feb 16, 2021 at 5:00 PM Amy Blais<EMAIL_ADDRESS>wrote:

Unsure if it helps, but in desktop app v4.6.2 we fixed an issue where
macOS entitlements had not been enabled for using camera and microphone on
the Desktop App for third-party plugins such as Jitsi --
https://docs.mattermost.com/help/apps/desktop-changelog.html#release-v4-6
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/mattermost-plugin-jitsi/issues/120#issuecomment-779933020,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACUTPIZGPUCAY7GU7JQHXTS7KJC7ANCNFSM4OHD2SQQ
.

I confirm that updating to version 4.6.2 works. I needed to reinstall the app (delete it and add new version) so the permissions can work.

@dpanic Did you test after reinstalling the app?

Will retest. It didn't worked than (around March this year)

@Willyfrog Any thoughts on this?

if you never got any permission request might be because you already especified those permissions in the OS settings? that happened to me on big sur, if I chose not to permit access, I'd have to go to system preferences -> security & privacy -> camera and allow mattermost to use it. On catalina the path might be different.


Crashes due to unexpected type 'float'

Attempting to zoom via mouse wheel or to draw a bounding box results in an immediate crash. Here's the output when I try to draw a bounding box:
Traceback (most recent call last):
  File "/home/stan/.conda/envs/pytorch_cuda3090/lib/python3.10/site-packages/labelImg/labelImg.py", line 1014, in zoom_request
    self.add_zoom(scale * units)
  File "/home/stan/.conda/envs/pytorch_cuda3090/lib/python3.10/site-packages/labelImg/labelImg.py", line 974, in add_zoom
    self.set_zoom(self.zoom_widget.value() + increment)
  File "/home/stan/.conda/envs/pytorch_cuda3090/lib/python3.10/site-packages/labelImg/labelImg.py", line 971, in set_zoom
    self.zoom_widget.setValue(value)
TypeError: setValue(self, int): argument 1 has unexpected type 'float'
zsh: IOT instruction (core dumped)  labelImg

#841 sounds like the same issue.
$ uname -rvsmio
# Linux 5.19.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 29 Aug 2022 15:51:05 +0000 x86_64 unknown GNU/Linux

$ conda list | grep -E '(qt)|(labelimg)'
# labelimg                  1.8.6           py310hff52083_1    conda-forge
# pyqt                      5.15.7          py310h29803b5_0    conda-forge
# pyqt5-sip                 12.11.0         py310hd8f1fbe_0    conda-forge
# qt-main                   5.15.4               ha5833f6_2    conda-forge

you need to cast those floats into integer, that helps for me. I had fixes for this issues, but im not able to push it.

You're not supposed to push changes directly but rather to create a pull request by forking (see here).
That aside, do you have more information why this problem surfaces or when it began to surface? Maybe the added context would be helpful for me and others. When I install labelImg via my package manager it works, whereas the installation via conda is broken in the manner described above.

Same issue for me. Downloading the release version for Windows (v1.8.1) worked but the pip install version crashes (v1.8.6).

I think someone needs to release a new version of labelimg with current code. Version 1.8.6 does not contain the fixed code.

Solution.
Error in Qt5.
float to int conversion
Changed:
x:\xxxxx\python-310\Lib\site-packages\libs\canvas.py
526 line:
default:
p.drawRect(left_top.x(), left_top.y(), rect_width), int(rect_height)
new:
p.drawRect(int(left_top.x()), int(left_top.y()), int(rect_width), int(rect_height))
530 line:
default:
p.drawLine( self.prev_point.x(), 0, self.prev_point.x(), self.pixmap.height())
new:
p.drawLine( int(self.prev_point.x()), 0, int(self.prev_point.x()), int(self.pixmap.height()))
531 line:
default:
p.drawLine( 0, self.prev_point.y(), self.pixmap.width(), self.prev_point.y())
new:
p.drawLine( 0, int(self.prev_point.y()), int(self.pixmap.width()), int(self.prev_point.y()))
Changed:
x:\xxxxx\python-310\Lib\site-packages\labelImg\labelImg.py
965 line:
default:
bar.setValue(bar.value() + bar.singleStep() * units)
new:
bar.setValue(int(bar.value() + bar.singleStep() * units))

Solution. Error in Qt5. float to int conversion Changed: x:\xxxxx\python-310\Lib\site-packages\libs\canvas.py 526 line: default: p.drawRect(left_top.x(), left_top.y(), rect_width), int(rect_height) new: p.drawRect(int(left_top.x()), int(left_top.y()), int(rect_width), int(rect_height)) 530 line: default: p.drawLine( self.prev_point.x(), 0, self.prev_point.x(), self.pixmap.height()) new: p.drawLine( int(self.prev_point.x()), 0, int(self.prev_point.x()), int(self.pixmap.height())) 531 line: default: p.drawLine( 0, self.prev_point.y(), self.pixmap.width(), self.prev_point.y()) new: p.drawLine( 0, int(self.prev_point.y()), int(self.pixmap.width()), int(self.prev_point.y())) Changed: x:\xxxxx\python-310\Lib\site-packages\labelImg\labelImg.py 965 line: default: bar.setValue(bar.value() + bar.singleStep() * units) new: bar.setValue(int(bar.value() + bar.singleStep() * units))

Great!

Solução. Erro no Qt5. conversão float para int Alterado: x:\xxxxx\python-310\Lib\site-packages\libs\canvas.py 526 linha: padrão: p.drawRect(left_top.x(), left_top.y(), rect_width), int(rect_height) novo: p.drawRect(int(left_top.x()), int(left_top.y()), int(rect_width), int(rect_height)) 530 linha: padrão: p.drawLine( self.prev_point .x(), 0, self.prev_point.x(), self.pixmap.height()) novo: p.drawLine( int(self.prev_point.x()), 0, int(self.prev_point.x( )), int(self.pixmap.height())) 531 linha: padrão: p.drawLine( 0, self.prev_point.y(), self.pixmap.width(), self.prev_point.y()) novo : p.drawLine( 0, int(self.prev_point.y()), int(self.pixmap.width()), int(self.prev_point.y())) Alterado: x:\xxxxx\python-310\ Lib\site-packages\labelImg\labelImg.py 965 linha: padrão: bar.setValue(bar.value() + bar.singleStep() * unidades) novo: bar.setValue(int(bar.value() + bar. singleStep() * unidades))

here it worked, it gave another error, but I used the same logic to fix it - thanks

thanks @ptiszai,this problem has bothered me for a few days. I successfully solved it using your method.Thank you very much

thanks @ptiszai

Thanks @ptiszai
In x:\xxxxx\python-310\Lib\site-packages\labelImg\labelImg.py, I got an error at line 971 and I changed :
default :
self.zoom_widget.setValue(value)
new:
self.zoom_widget.setValue(int(value))

Everything worked fine.

Thanks @ptiszai and @p-mathis
I also got crashes today when showing the labels for bounding boxes so had to make the following change in x:\xxxxx\python-310\Lib\site-packages\libs\shape.py to line 131:
default:
painter.drawText(min_x, min_y, self.label)
new:
painter.drawText(int(min_x), int(min_y), self.label)

Not sure how many people use the feature to display labels on bounding boxes but this fixed things and along with the previous manual updates I'm no longer getting crashes.

Well, why does it work like this?
Why can't we draw float values?


Docs typo

there is no scrape.py

Changed to scrape_web.py and scrape_cli.py depending on how one wants to use it, yet to update the documentation

Updated


Controller prop for smooth zoom in/out

Hello,
thanks again for this amazing library, I'm learning a lot just by browsing the source code and experimenting.
I had to implement the feature of smooth zooming and came up with this solution, a zoomTransition Controller option that will set the transitionDuration for the animation. #2941
Let me know what you think and how can I improve it

[X] Add label and assign to milestone
[X] Coding
[X] Test
[ ] Doc update
[ ] What’s new update

Change List

Added a prop to the Controller class

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lowhearth seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.03%) to 61.785% when pulling 1637a021aa9419b22ecc5855f01fd2a065679cac on Lowhearth:master into 2fc418d6505f300ad74d818f3b445fea99541cdf on uber:master.

Coverage decreased (-0.03%) to 61.785% when pulling 1637a021aa9419b22ecc5855f01fd2a065679cac on Lowhearth:master into 2fc418d6505f300ad74d818f3b445fea99541cdf on uber:master.

You can achieve this by extending the default MapController class:
import DeckGL, {MapController} from 'deck.gl'

class MyController extends MapController {
  _getTransitionProps() {
    return {transitionDuration: 0};
  }
}

<DeckGL ... controller={MyController} />

Definitely taking this approach if we decide that the feature is not worthy to be included in the controller class.
¿ Wouldn't it be good to have this built in feature ?

There are a lot of hard-coded behaviors in the controller class, e.g. transition duration/interpolator, increment for keyboard navigation, etc. I think it's a great suggestion that we should expose them as options. I would avoid making individual additions like this and come up with a comprehensive list of options.

I couldn't agree more


Fix/tasks

This PR fix the problem with the Taskqueue. We now query the region not the zone for queue_region.

@ArneGudermann Thanks for starting this pull request. Can you please re-create the same PR based on the current main branch? As this is a hotfix rather than a feature, I would like to have this in viur-core 3.3.x.


DRILL-5749: solve foreman and netty threads deadlock

break the nest invocation of channelClosed method to avoid nested lock holding

anyone can review this PR ? more details about thread stacks see DRLL-5749

Nice catch @weijietong
Looks like the Netty thread, that is failing all outstanding requests to a certain endpoint, is itself trying to send a message (cancel fragment) to that endpoint. Any ideas on how to fix that?
Apart from Paul's comment, the current patch looks good to me as well. The above fix is a nice-to-have.

@paul-rogers have refactored the codes. @sudheeshkatkam nothing to fix ,once the netty thread got the re-spawned RPC connection ,it will send out the message.

Turns out that I cannot cleanly do the rebase. @weijietong, please rebase this branch onto the latest master, and squash your commits into a single commit.


ABI checks fail in hunter_finalize

The ABI checks always fail in hunter_finalize, see 4e631ebf5a625310aaf72f438e1eda5cedef6688

@oliverdaniell Thanks for report. Can you please add logs with HUNTER_STATUS_DEBUG=ON build option. Also does the error message show this link: https://github.com/ruslo/hunter/wiki/error.abi.detection.failure ?

I will try and do this ASAP, unfortunately releases after 0.11.6 seem to break a lot of other things, for example cached libraries are no longer found. I have switched back to release 0.11.6 for now. When I get a chance I will try and reproduce the errors with some more useful information

for example cached libraries are no longer found

Please open separate issue. Also just for your information since this commit https://github.com/ruslo/hunter/commit/73fbec0e899538e3a0c2c83936ba8ba3e6b4f8f7 (0.11.9 release) toolchain calculation changed so no cache entries will be reused. This is not designed to be changed very often, but it may happens. See git logs: git log scripts/create-toolchain-info.cmake. result: 30 Jun, 22 Apr, 10 Apr, ...

I am unable to reproduce this issue with a fresh checkout of v0.11.9, tested on vs2013 with
examples/Boost-filesytem
examples/OpenSSL
examples/rabbitmq-c

I am unable to reproduce this issue with a fresh checkout of v0.11.9, tested on vs2013 with

@oliverdaniell Thanks for testing

Reproduced issue with v0.11.10. The issue only occurs when hunter is used via hunter gate
[hunter *** DEBUG *** 2015-07-03T12:06:10] HUNTER_ROOT detected by cmake variable
[hunter *** DEBUG *** 2015-07-03T12:06:10] HUNTER_ROOT: C:/temp
[hunter *** DEBUG *** 2015-07-03T12:06:10] Locking directory: C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f
[hunter *** DEBUG *** 2015-07-03T12:06:10] Lock done
[hunter *** DEBUG *** 2015-07-03T12:06:10] Run generate
-- Building for: Visual Studio 12 2013

-- Configuring done

-- Generating done

-- Build files have been written to: C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Build

[hunter] Initializing Hunter workspace (4e05e1f717c26defdd93a03510090160e37d952d)
[hunter]   https://github.com/ruslo/hunter/archive/v0.11.10.tar.gz
[hunter]   -> C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f
Microsoft (R) Build Engine version 12.0.30723.0
[Microsoft .NET Framework, version 4.0.30319.34209]
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 03/07/2015 12:06:10.

Project "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\ALL_BUILD.vcxproj" on node 1 (default targets).

Project "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\ALL_BUILD.vcxproj" (1) is building "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\Hunter.vcxproj" (2) on node 1 (default targets).
Project "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\Hunter.vcxproj" (2) is building "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\ZERO_CHECK.vcxproj" (3) on node 1 (default targets).

PrepareForBuild:
  Creating directory "Win32\Debug\ZERO_CHECK\".

  Creating directory "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\Debug\".

  Creating directory "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\".

InitializeBuildStatus:

  Creating "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

CustomBuild:

  Checking Build System

  CMake does not need to re-run because C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Build/CMakeFiles/generate.stamp is up-to-date.

FinalizeBuildStatus:

  Deleting file "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".

  Touching "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".

Done Building Project "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\ZERO_CHECK.vcxproj" (default targets).

PrepareForBuild:

  Creating directory "Win32\Debug\Hunter\".

  Creating directory "Win32\Debug\Hunter\Hunter.tlog\".

InitializeBuildStatus:

  Creating "Win32\Debug\Hunter\Hunter.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

ComputeCustomBuildOutput:

  Creating directory "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\Hunter-prefix\src\Hunter-stamp\Debug\".

  Creating directory "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\CMakeFiles\Debug\".

CustomBuild:

  Building Custom Rule C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/CMakeLists.txt

  CMake does not need to re-run because C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\CMakeFiles\generate.stamp is up-to-date.

  Creating directories for 'Hunter'

  Performing download step (download, verify and extract) for 'Hunter'

  -- downloading...

       src='https://github.com/ruslo/hunter/archive/v0.11.10.tar.gz'
       dst='C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/v0.11.10.tar.gz'
       timeout='none'

  -- [download 1% complete]

  -- [download 3% complete]

  -- [download 6% complete]

  -- [download 14% complete]

  -- [download 22% complete]

  -- [download 30% complete]

  -- [download 38% complete]

  -- [download 49% complete]

  -- [download 57% complete]

  -- [download 65% complete]

  -- [download 73% complete]

  -- [download 80% complete]

  -- [download 88% complete]

  -- [download 100% complete]

  -- downloading... done

  -- verifying file...

       file='C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/v0.11.10.tar.gz'

  -- verifying file... done

  -- extracting...

       src='C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/v0.11.10.tar.gz'
       dst='C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Unpacked'

  -- extracting... [tar xfz]

  -- extracting... [analysis]

  -- extracting... [rename]

  -- extracting... [clean up]

  -- extracting... done

  No update step for 'Hunter'

  No patch step for 'Hunter'

  No configure step for 'Hunter'

  No build step for 'Hunter'

  No install step for 'Hunter'

  Completed 'Hunter'

FinalizeBuildStatus:

  Deleting file "Win32\Debug\Hunter\Hunter.tlog\unsuccessfulbuild".

  Touching "Win32\Debug\Hunter\Hunter.tlog\Hunter.lastbuildstate".

Done Building Project "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\Hunter.vcxproj" (default targets).

PrepareForBuild:

  Creating directory "Win32\Debug\ALL_BUILD\".

  Creating directory "Win32\Debug\ALL_BUILD\ALL_BUILD.tlog\".

InitializeBuildStatus:

  Creating "Win32\Debug\ALL_BUILD\ALL_BUILD.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

CustomBuild:

  Building Custom Rule C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/CMakeLists.txt

  CMake does not need to re-run because C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\CMakeFiles\generate.stamp is up-to-date.

FinalizeBuildStatus:

  Deleting file "Win32\Debug\ALL_BUILD\ALL_BUILD.tlog\unsuccessfulbuild".

  Touching "Win32\Debug\ALL_BUILD\ALL_BUILD.tlog\ALL_BUILD.lastbuildstate".

Done Building Project "C:\temp\_Base\Download\Hunter\0.11.10\4e05e1f\Build\ALL_BUILD.vcxproj" (default targets).

Build succeeded.
    0 Warning(s)

    0 Error(s)

Time Elapsed 00:00:02.56

[hunter *** DEBUG *** 2015-07-03T12:06:13] Finished
[hunter *** DEBUG *** 2015-07-03T12:06:13] Settings (initialize):
[hunter *** DEBUG *** 2015-07-03T12:06:13]   HunterGate done (NO)
[hunter *** DEBUG *** 2015-07-03T12:06:13]   Cache init (NO)
The CXX compiler identification is MSVC 18.0.30723.0
Check for working CXX compiler using: Visual Studio 12 2013
Check for working CXX compiler using: Visual Studio 12 2013 -- works
Detecting CXX compiler ABI info
Detecting CXX compiler ABI info - done
Detecting CXX compile features
Detecting CXX compile features - done

[hunter ** FATAL ERROR **] ABI not detected for C compiler
[hunter ** FATAL ERROR **] [Directory:E:/Working/traincascade]

------------------------------ WIKI -------------------------------
    https://github.com/ruslo/hunter/wiki/error.abi.detection.failure
-------------------------------------------------------------------

CMake Error at C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Unpacked/cmake/modules/hunter_wiki.cmake:12 (message):
Call Stack (most recent call first):
  C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Unpacked/cmake/modules/hunter_fatal_error.cmake:20 (hunter_wiki)
  C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Unpacked/cmake/modules/hunter_finalize.cmake:16 (hunter_fatal_error)
  C:/temp/_Base/Download/Hunter/0.11.10/4e05e1f/Unpacked/cmake/modules/hunter_add_package.cmake:23 (hunter_finalize)
  CMakeLists.txt:17 (hunter_add_package)

Configuring incomplete, errors occurred!
See also "E:/Working/traincascade/build/CMakeFiles/CMakeOutput.log".

@oliverdaniell Okay, I see. I think you set your project language to C++ only, right?

That fixed it, thanks!

I will reopen it since I think that active language can be checked. Also I can improve it by checking only one of two variables.

Fixed in branch develop


mod: Upgrade to ginkgo v2

What this PR does / why we need it:
Upgrade the ginkgo into v2 version
Release note:

mod: Upgrade the ginkgo into v2

/ok-to-test

thanks @haoxins !
/lgtm
/approve


Improve portability of non-published sites

Forked hax-the-web as per #294
Set up WAMP as instructed in the docs (same kind of deal as MAMP)
Started the servers and checked that PHP version is 7.2
Site kind of loads, but not properly:
I get this

Then scroll down and I've being told to update my browser (I'm on the latest version of Chrome)

Look and see if the build directory is there. If not type on -s ../../build when inside the site directory in terminal

hmm, ok, I think I see what I've done. I'm just trying to edit the site, but it's just standalone and haven't got it as part of HAXcms. I'll try again tomorrow

ohhhhh I see. I thought you had it in the context of HAXcms. HAXcms brings in the editing capabilities. It not loading after a clone has been brought up, has to do w/ knowing where the files are. I've discussed some ways of possibly handling that more gracefully but if you copy the build directory from a HAXcms instance and put it in the site itself then it'll load locally in WAMP as a stand alone (or should).
The issue is that currently our "publishing step" corrects the path differences between a static copy and the real deal. Definitely something we need to improve the UX of

duplicate of #296

#287 rather


convert build setup to pyproject.toml

i have only done a minimal verification that the build command still works.
please test this forwards, backwards and sideways in every way that you can think of.

Merging this as we have this approved. Thanks!


Initialization handlers

Subgraph developers often want to initialise a specific state for their subgraph.
Currently this needs to be done across handlers, or on the basis of some other trigger.
TBD: could parts of this use case be handled declaratively in the manifest e.g. via context?

This was proposed separately in the Forum: https://forum.thegraph.com/t/grp-0001-decorator-hooks-cron-jobs-and-initialisation-handlers/3347

This could be a type of block handler, similar to #959:
blockHandlers
  - handler: initializeState
    filter:
      kind: once

@azf20 I like that, we'd just need to make sure it runs before any other triggers in the first block, rather than after as would be the default for a block handler.

Interesting - I wonder if that could be a separate blockHandler configuration, unless that seems like too much of a footgun?

It does seem interesting to have a separate configuration to make any block handler be handled first. Like a field order: first|last, defaulting to last.

@azf20 I like that, we'd just need to make sure it runs before any other triggers in the first block, rather than after as would be the default for a block handler.

Could we make it start 1 block before the earliest startblocks stated in subgraph.yaml thus ensuring no other handlers are triggered?

Hey, is there an ETA on this?


failed to parse update queries into AST tree

It's more of a question instead of bug report. I'm tring to get the hierachical structure of SQL queries with Jsqlparser. At first I thought it would be perfect to use the parseAST method. But I found that it doesn't work well for many queries like update and insert.
I tried to parse queries with TablesNamesFinder but it seems that I need to override all the visit functions to achieve it, which is not my first choice. And I also need to get the range of every element/token in the query, but I can hardly get the position data from some of Statement elements like Update.
Any idea about how to generate a hierachical structure with range information?
Thanks!

Greetings.
If I was in your shoes, then indeed I would take the DeParser Implementation and overwrite all the visit() methods and build the Syntax Tree and persist the position within each method.

I'm confused about the "persist the position within each method" part, how can i persist the data when there is no field for it in elements?
I'm new to JSqlparser, so sorry if my question is silly

The Deparser will rebuild the SQL String from the Java Objects, mostly by appending to a String Buffer.
For your challenge you would:
a) append to a Tree Model and know the String length of each Node
b) calculate the String Position of each Node by traversing the tree up to the root

how can i persist the data when there is no field for it in elements?

I would implement a special TreeNode, which holds a) the Java Object itself and b) the String representation and then traverse through the tree.

I see...I will give it a try. Thank you very much!


Codeception installed globally is not working.

Codeception which was installed using command composer global require codeception/codeception in provision.sh is not working now (Codeception 2.1).
$ codecept run finish with error PHP Fatal error: Cannot redeclare GuzzleHttp\Psr7\str().
Should use Codeception installed in your project non-globally, and $ ./vendor/bin/codecept run.

refer

https://github.com/Codeception/Codeception/issues/2118

This is my misunderstanding. :dizzy_face:


Fix the scripts for Python3

Running the scripts through pylint gives a lot of errors...  It seems like these scripts are out of date and need a little TLC...
This is just a basic patch to get the code working in Python3, though I'm not sure if the basestring hack is the best approach below.

Thanks! I'm going to tweak gen.py to add a #! header and the print_function import.


Missing upload instructions

There is a note saying "It can take up to 24 hours before sideloading is enabled. During interim, you can use upload for  to test your app."
But pressing this upload link in Teams simply opens a File system navigation dialog. There are no instructions about what to navigate too. Please add a couple of sentences to the note telling readers to upload the zipped package file of the app and the path where they can find it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3530b55-59c8-6eec-b257-b7a5f2ed046b
Version Independent ID: 022f7eff-f6c2-9a73-afa9-74e887b761e1
Content: Prepare your Microsoft 365 tenant - Teams
Content Source: msteams-platform/concepts/build-and-test/prepare-your-o365-tenant.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

Hi @Rick-Kirkham, Thanks for brining up this suggestion, We will ask document team to look into this and make the document better.

Hi @Rick-Kirkham, it has clearly explained in the this link that how to upload  Zip file/manifest and location of the file is depends on user hat where his file is located.

But the reader of the article I raised this issue about (see the Document Details box above) cannot know about some other article, unless you link to it. The note in this screen shot needs to link to:
https://docs.microsoft.com/en-us/microsoftteams/upload-custom-apps#upload


Add text extraction notebook and other demo2 files

For issue #11 and issue #26, add files required to run text extraction phase of demo 2. The extraction notebook is here: notebooks/demo2/pdf_text_extraction.ipynb. The source for extraction adapted from this repository  is in src/components/preprocessing.
Questions that remain to be addressed:

What would be the best way to give credit to the Allianz NLP repository?
The dataset currently is in the data folder of the repo, do we want to bring s3 in the picture at this point?

@Shreyanand  lgtm

Questions that remain to be addressed:

What would be the best way to give credit to the Allianz NLP repository?
The dataset currently is in the data folder of the repo, do we want to bring s3 in the picture at this point?

@Shreyanand do these need to be addressed in this PR? or should they be turned into additional issues?

The dataset currently is in the data folder of the repo, do we want to bring s3 in the picture at this point?

@Shreyanand, I am generally not a fan of using github as the place to store data (other than small example sets). This data is not huge, but I think it might be a good idea to put this data in remote storage and interactive with it that way. WDYT?
@MichaelTiemannOSC is it all right to move this data and make it available through remote storage?

The Data Commons is designed around the concept of having access to cloud storage for just such a reason.  We should create a folder for this.  We just need to figure out an appropriate name for the folder that we can live with for a while.

@MichaelTiemannOSC great : )
Is this something that merits a new issue in the os_c_data_commons repo to discuss?

@MichaelClifford  the following would be a good place to discuss:
https://github.com/os-climate/os_c_data_commons/issues/68

@MichaelTiemannOSC  According to the linked issue it seems like the ESG corporate data we are looking to use here is still a bit of an outlier. I'm happy with any naming convention/bucket location folks want to use, but would corpdata/ESG/**      in the 'ocp-odh-os-demo-s3' bucket suffice for now?
Let me know what you think :smile:

@Shreyanand do these need to be addressed in this PR? or should they be turned into additional issues?

Agreed, let's discuss this in a separate issue - #39 - and unblock this PR :)

/lgtm


IOXDRTestCase no longer uses pipes.yahooapis.com to test XDR

We now use echo.ariatemplates.com, as pipes.yahooapis.com is no longer available.

@fbasso Thank you for your review!


Make sveltekit minor version flexible

This is a potential fix for issue #37
I haven't tested it, I'm not sure exactly how to do that. However I figured that opening a PR is a way to get the ball rolling on fixing the issue.
I made the sveltekit version flexible so that the project can use the same sveltekit version as the user, as long as it is >= 1.8.3 and < 2.0.0
That should fix issue #37 and any future security warnings that may arise from a fixed sveltekit version.

Temporary workaround using this ^1.8.3 fix suggested above by @arieroos:

npm uninstall sveltekit-adapter-aws (if currently installed)
Add the following lines to your project's (root level) package.json:

"overrides": {
  "sveltekit-adapter-aws": {
    "@sveltejs/kit": "^1.8.3"
  }
}

npm install sveltekit-adapter-aws


Add dotnet-bot help job.

@dotnet-bot test ci please

@mmitche FYI

LGTM

@dotnet-bot help

Well that's interesting.  I wonder why it didn't register the rest of the jobs.

Ahh because they're created in the master branch.  Okay i'll have to solve that issue next week.

ANways, still LGTM

@mmitche Okay so we'll see the full set in the help message in master but not in release/1.2 and release/1.3, etc.?

@dotnet-bot test this please

@dotnet-bot test ci please

@dotnet-bot help

@dotnet-bot help

@mmitche How does testing the help message work? Should it work after I triggered a CI test?

@dilijev I just triggered it manually there.  It works like any other CI job (except all it does it post to GitHub) and will work once merged.
I'm working on a way to get the help message to display jobs that aren't defined in this netci.groovy


feat: update package abcmidi to 2023.08.31-1

@cbix Please fix the aarch64 CI builder and then merge this.


⚠ BCR Bot has degraded performance

In c8c0914, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 913 ms

Resolved: BCR Bot performance has improved in 547d760.


License requirements

The article mentions the requirement of Phone System add-on license (if it's not already included in the current SKU available on the tenant).
Can we also use the free "Phone System - Virtual User" add-on license for Voicemail, in a scenario where callqueues outside of the business hours would redirect callers to a  generic (virtual) user's voicemail.
Neither the current article, nor the "Phone System - Virtual User License" article (https://docs.microsoft.com/en-us/microsoftteams/teams-add-on-licensing/virtual-user) mention anything about the virtual user and voicemail.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8228f9b2-a7de-abb4-6f41-70db0b3af155
Version Independent ID: 8fd9fafb-dd76-59a8-e609-56f06d539a31
Content: Set up Cloud Voicemail
Content Source: Teams/set-up-phone-system-voicemail.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

@meshkerila  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@meshkerila Phone System - Virtual user licenses are only for use with resource accounts that are linked to call queues and auto attendants.  They are not full-feature user accounts that can have a voicemail box, so if you configured an auto attendant or call queue to forward to voicemail after hours, the destination voicemail box needs to be for an account that has a normal user license.
Omissions like this are often deliberate: it's not possible to describe everything that's not supported so we only describe what we're sure is supported. I'm confident that's not a supported use of that license.  @waseemhashem can correct me if that's not the case.

I've am trying to get a SfB 2015 environment to make use of Cloud Voicemail instead of using Exchange Online UM but cannot get cloud voicemail working for my onprem homed accounts. Hybrid is setup and working, the accounts have E3 and phone system licenses assigned and the hosting provider for Exchange Online is in place.
When the accounts are homed onprem I get the error "ms-diagnostics-public: 15621;source="MW2PR16CA0018.namprd16.prod.outlook.com";reason="The specified mailbox is not enabled for Unified Messaging." which it isn't since I am trying to make use of Cloud Voicemail not UM online.
When I enable the same account for UM Online voicemail works fine to the Exchange Online UM service. When I disable EXCHO UM and move the account to SfB Online voicemail works with the Cloud Voicemail service, but when I move the account back to the onprem pool the Cloud Voicemail service stops working.
The Technet documentation says that Cloud Voicemail is supported with SfB2015 but I just cannot seem to get this working.

Until its retired in Feb 2020, Exchange UM Online is the default voicemail service for SFB 2015 and 2013. To migrate your deployment to CVM instead, please check the Opt-in instructions in this article: https://docs.microsoft.com/en-us/SkypeForBusiness/plan/exchange-unified-messaging-online-migration-support
From: dewaltk<EMAIL_ADDRESS>Sent: Friday, October 4, 2019 6:37 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Waseem Hashem<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] License requirements (#3071)
I've am trying to get a SfB 2015 environment to make use of Cloud Voicemail instead of using Exchange Online UM but cannot get cloud voicemail working for my onprem homed accounts. Hybrid is setup and working, the accounts have E3 and phone system licenses assigned and the hosting provider for Exchange Online is in place.
When the accounts are homed onprem I get the error "ms-diagnostics-public: 15621;source="MW2PR16CA0018.namprd16.prod.outlook.com";reason="The specified mailbox is not enabled for Unified Messaging." which it isn't since I am trying to make use of Cloud Voicemail not UM online.
When I enable the same account for UM Online voicemail works fine to the Exchange Online UM service. When I disable EXCHO UM and move the account to SfB Online voicemail works with the Cloud Voicemail service, but when I move the account back to the onprem pool the Cloud Voicemail service stops working.
The Technet documentation says that Cloud Voicemail is supported with SfB2015 but I just cannot seem to get this working.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F3071%3Femail_source%3Dnotifications%26email_token%3DALIRWCYLWIF2I2WU4PUD743QM5BHJA5CNFSM4IZ333L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEALVIZQ%23issuecomment-538399846&data=02|01|waseemh%40microsoft.com|4d8a38f035ce4c8da64908d748cfead4|72f988bf86f141af91ab2d7cd011db47|1|0|637057930141783647&sdata=4zEussHJp%2BR%2Fp5dyrb0BgXWmJFzgWI9KuIwkm3tDh1k%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALIRWCZDGBH2TMNOLW2J3X3QM5BHJANCNFSM4IZ333LQ&data=02|01|waseemh%40microsoft.com|4d8a38f035ce4c8da64908d748cfead4|72f988bf86f141af91ab2d7cd011db47|1|0|637057930141793635&sdata=UkBUzrM%2FOCg%2FJ3lEhl%2FHw8aIoZM%2F0OeW61xn9pfOvBI%3D&reserved=0.

@meshkerila Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Fix processing kwargs

Found some inconsistencies in the pre- and postprocessing kwargs..
we required axes and mode kwargs to be specified despite having sensible default values for them.
Also scale_linear's gain and offset are conditionally mandatory (at least one needs to be set). The bioimageio_maybe_required flag ensures the documentation marks that with an asterisk *.

Ok, I will go ahead and merge.


Can you please fix all the bugs that are happening

Please provide a description of the issue you are experiencing and the steps you took to try to fix it yourself.


NRE spam

LogOutput.log

Patched! Noticed it late, but thanks for notifying. The patch should be out soon on thunderstore.io.
If you or anyone who comes across this issue finds any bugs, you're welcome to report them here!


CI: add Python 3.9

@StevenBlack does Python have LTS releases? If so, maybe it would make more sense to reduce the CI-tested versions to the LTS ones?

@XhmikosR σας ευχαριστώ!


Recurring payments

Nice project!
Are you planning to add support for recurring payments? What would be the easiest way to go about that?

This could be possibly used for recurring payments – https://zapier.com/zapbook/zaps/10621/add-rows-to-google-sheets-every-week/


Construct FutureMap with empty Futures

I'm trying to use runtime->construct_future_map to construct a FutureMap which contains empty futures. It may seem silly, but I want my code to be general, and I'd prefer not to add special cases for empty futures.
When I include an entry with NULL and 0 for pointer and size, respectively, it seem this code has a problem.
multiple_partitions: /resilience/legion/runtime/legion/runtime.cc:2575: Legion::Internal::FutureInstance::FutureInstance(const void*, size_t, Legion::Internal::ApEvent, Legion::Internal::Runtime*, bool, bool, bool, Legion::Internal::PhysicalInstance, Legion::Processor, Legion::Internal::RtEvent, Legion::Internal::ApUserEvent): Assertion `size > 0' failed.

Here's the interesting part of the backtrace:
#7  0x00007fcebbf907ad in Legion::Internal::FutureInstance::FutureInstance (this=0x7fce8400db30, d=0x7fce84002c10, s=0, r=...,
    rt=0x56194f7aa050, eager=false, external=true, own=true, inst=..., p=..., use=..., remote_read=...)
    at /resilience/legion/runtime/legion/runtime.cc:2575
#8  0x00007fcebbf941d6 in Legion::Internal::FutureInstance::create_local (value=0x7fce84002c10, size=0, own=true, runtime=0x56194f7aa050)
    at /resilience/legion/runtime/legion/runtime.cc:3316
#9  0x00007fcebbf8bc7f in Legion::Internal::FutureImpl::set_local (this=0x7fce8400c5b0, value=0x0, size=0, own=false)
    at /resilience/legion/runtime/legion/runtime.cc:1474
#10 0x00007fcebb9cc358 in Legion::Internal::InnerContext::construct_future_map (this=0x7fce8c0019d0, space=...,
    data=std::map with 4 elements = {...}, provenance=0x0, collective=false, sid=0, implicit=false, internal=false)
    at /resilience/legion/runtime/legion/legion_context.cc:6606
#11 0x00007fcebbae5b92 in Legion::Runtime::construct_future_map (this=0x56194f67a1d0, ctx=0x7fce8c0019d0, domain=...,
    data=std::map with 4 elements = {...}, collective=false, sid=0, implicit=false, prov=0x0)
    at /resilience/legion/runtime/legion/legion.cc:6330
#12 0x000056194f553096 in ResilientLegion::FutureMapSerializer::inflate (this=0x7fce8400eaf0, runtime=0x7fce90ea7760, ctx=0x7fce8c0019d0)
    at /resilience/src/resilience/resilience.cc:41
#13 0x000056194f55b544 in ResilientLegion::Runtime::enable_checkpointing (this=0x7fce90ea7760, ctx=0x7fce8c0019d0)
    at /resilience/src/resilience/resilience.cc:1046

As my debugging session shows, some of the entries in the data map contain NULL/0:
(gdb) p is
$1 = {id = 1, tid = 1, type_tag = 258}
(gdb) p domain
$2 = {domain = {dim = 1, rects = std::vector of length 1, capacity 1 = {{lo = {p = {dim = 1, point_data = {0, 0, 0}}}, hi = {p = {dim = 1,
            point_data = {3, 0, 0}}}}}}}
(gdb) p data
$3 = std::map with 4 elements = {[{dim = 1, point_data = {0, 0,
      0}}] = {<Legion::Unserializable<Legion::UntypedBuffer>> = {<No data fields>}, args = 0x0, arglen = 0}, [{dim = 1, point_data = {1,
      0, 0}}] = {<Legion::Unserializable<Legion::UntypedBuffer>> = {<No data fields>}, args = 0x0, arglen = 0}, [{dim = 1, point_data = {
      2, 0, 0}}] = {<Legion::Unserializable<Legion::UntypedBuffer>> = {<No data fields>}, args = 0x0, arglen = 0}, [{dim = 1,
    point_data = {3, 0, 0}}] = {<Legion::Unserializable<Legion::UntypedBuffer>> = {<No data fields>}, args = 0x0, arglen = 0}}

I'm on commit 61b82cc43251d0e5e3727d44318b8af2bec2b7e2 of control_replication.

Pull and try again.

Fixed, thanks!


⚠ AGEG website (prod) has degraded performance

In 68d7ebe, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2064 ms

Resolved: AGEG website (prod) performance has improved in f18c857.


Autofocus not working on iphone 13 (ios)

I built the QmlBarcodeReader in QT 6.2.4 for ios. The application Opens on the iphone 13 but it not able to detect any bar code or QR code as it is not auto focusing.
Thanks

@rohitamon Even I am facing the same issue on iphone 13. Could you solve that.
Thanks


Add information in the readme for notebook users with dedicated GPU

regarding the readme "Laptops with dual GPU have to disable the on-board GPU." in my experience the onboard graphics can't be disabled, because the  graphics ouput of the dedicated GFX needs to be passed through over the onboard GFX. the dedicated GFX needs to be assigned to the 3d application by settings in the related control panel of the GFX

Looks good to me, but I don't have a compatible laptop to test. I leave this to @JackD83 for merge.


NO MERGE: PR for testing /payload

@deads2k told me I can use this repository to test /payload Prow plugin. Hence, opening this PR.


Errors when you try to connect from Erlang, driver release '2018-03-21'

Error occurs in Erlang, driver release version is 2018-03-21, but with previous release there is no error.
1> odbc:start().
ok
2> {ok, Ref} = odbc:connect("DSN=clickhouse", []).

=ERROR REPORT==== 26-Mar-2018::07:12:27 ===
ODBC: received unexpected info: {tcp_closed,#Port<0.541>}

=ERROR REPORT==== 26-Mar-2018::07:12:27 ===
** Generic server <0.68.0> terminating
** Last message in was {#Port<0.539>,{exit_status,5}}
** When Server state == {state,#Port<0.539>,
                               {<0.61.0>,#Ref<0.967934967.3703570433.6819>},
                               <0.61.0>,undefined,on,undefined,undefined,on,
                               connecting,undefined,0,
                               [#Port<0.537>,#Port<0.538>],
                               #Port<0.540>,#Port<0.541>}
** Reason for termination ==
** {port_exit,freeing_of_memory_failed}
** exception error: no match of right hand side value {error,connection_closed}

But isql tool works fine.

Does this issue still persist with newer releases?

Assuming you tried the latest version, as suggested in https://github.com/ClickHouse/clickhouse-odbc/issues/73, could you please close this, if this particular issue is fixed for you.


Test grid update

Just travis updates.   We had a couple passing PRs that failed when merged because of changes to astropy-dev

Coverage remained the same at 75.422% when pulling<PHONE_NUMBER>ba6c881f9c612df007d3d57caef360 on keflavich:fix_travis into fdb01439e7430fb9b278152b8f98fbda2c010b89 on radio-astro-tools:master.

Coverage remained the same at 75.422% when pulling 5e52ced369658271c64807e3e15829ceaa5ee70f on keflavich:fix_travis into fdb01439e7430fb9b278152b8f98fbda2c010b89 on radio-astro-tools:master.


How to position html text within canvas

Greetings,
We have successfully applied (text) to the code using the canvas remarks indicated in this form, and although the sentence/sentences appear nicely on the canvas of the browser, they are situated at the top left side. Currently the website simply has the particles.js appearing without text as we have not applied this to the live website until figuring out the proper syntax. Can you please indicate the proper (html and CSS) so we can use our own text?  Greatly appreciated.  Thank you!

The way I use particle.js with html text is applying to the particles a CSS {position:absolute; z-index: 0; width: whateverYouNeed; height: whateverYouNeed; top/right/bottom/left: whateverYouNeed} if the interactivity is not working 100% right after that, I just switch canvas to window and it works just fine

Hi Gabriel.
Please see below the html and CSS.  I seem to have gotten the canvas working to show the html at the top and left side.  Kind of lost after that though.  I have visited Vincent’s website and it looks amazing actually with the text and effects he has there now: https://vincentgarreau.com/en    Our current website live is: www.codeneutron.comhttp://www.codeneutron.com Any assistance is appreciated.
Html -

Code Neutron Technology Coming Soon!

CSS -
body{
margin: 0;
padding: 0;
height: 100vh
}
#particles-js
{
height: 100%;
background-image: url(universe1.jpg);
background-size: cover;
background-position: center;
}
#particles canvas{
position: absolute;
width: 100%;
height: 100%;
z-index: 999;
}
#hello {
position:absolute;
top: 0;
left:0;
color: #fff;
z-index: 9999;
font-family: 'Muli', sans-serif;
font-size: 40px;
text-align:center;
}
Best regards,
Craig
From: Gabriel Ernesto Martínez Cánepa<EMAIL_ADDRESS>Sent: Wednesday, May 30, 2018 3:13 PM
To: VincentGarreau/particles.js<EMAIL_ADDRESS>Cc: Craig Castle<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [VincentGarreau/particles.js] How to position html text within canvas (#319)
The way I use particle.js with html text is applying to the particles a CSS {position:absolute; z-index: 0; width: whateverYouNeed; height: whateverYouNeed; top/right/bottom/left: whateverYouNeed} if the interactivity is not working 100% right after that, I just switch canvas to window and it works just fine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/VincentGarreau/particles.js/issues/319#issuecomment-393282960, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AlwoIatOCl91nbJlwXOu8iOU2MZAjQbmks5t3u9TgaJpZM4UT0a9.

Hi Gabriel,
Actually we were able to figure it out and it was pretty straight forward.  Thank you.
Best regards,
Craig
From: Gabriel Ernesto Martínez Cánepa<EMAIL_ADDRESS>Sent: Wednesday, May 30, 2018 3:13 PM
To: VincentGarreau/particles.js<EMAIL_ADDRESS>Cc: Craig Castle<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [VincentGarreau/particles.js] How to position html text within canvas (#319)
The way I use particle.js with html text is applying to the particles a CSS {position:absolute; z-index: 0; width: whateverYouNeed; height: whateverYouNeed; top/right/bottom/left: whateverYouNeed} if the interactivity is not working 100% right after that, I just switch canvas to window and it works just fine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/VincentGarreau/particles.js/issues/319#issuecomment-393282960, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AlwoIatOCl91nbJlwXOu8iOU2MZAjQbmks5t3u9TgaJpZM4UT0a9.

Hi Gabriel,
Question hoping you can answer:
How do you add an image onto the Particles.js canvas?  By example: Social media Instagram (Logo) see attached. The site is currently a coming soon page: www.codeneuton.comhttp://www.codeneuton.com  Thank you!
Warm regards,
Craig Castle
From: Gabriel Ernesto Martínez Cánepa<EMAIL_ADDRESS>Sent: Wednesday, May 30, 2018 3:13 PM
To: VincentGarreau/particles.js<EMAIL_ADDRESS>Cc: Craig Castle<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [VincentGarreau/particles.js] How to position html text within canvas (#319)
The way I use particle.js with html text is applying to the particles a CSS {position:absolute; z-index: 0; width: whateverYouNeed; height: whateverYouNeed; top/right/bottom/left: whateverYouNeed} if the interactivity is not working 100% right after that, I just switch canvas to window and it works just fine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/VincentGarreau/particles.js/issues/319#issuecomment-393282960, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AlwoIatOCl91nbJlwXOu8iOU2MZAjQbmks5t3u9TgaJpZM4UT0a9.

Hi Gabriel,
My apologies, my coming soon page url: www.codeneutron.comhttp://www.codeneutron.com   Question hoping you can answer:
How do you add an image onto the Particles.js canvas?  By example: Social media Instagram (Logo) see attached.  Thank you!
Warm regards,
Craig Castle


teryx hero no longer effective against elders

thanks for changing systems title, wanted to change this today too


Docs Changes Needed from dbt-core PR #8466

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

More integration testing.  No docs changes needed.


cpu lockup on ubuntu

When using this extension in Visual Studio Code on Ubuntu 16.04 cpu usage jumps to 100% and stays there, even after closing VS Code.

I need a few more informations. (vs code version, only my extension installed, ...)


Magento returns empty error during the authentication

Hello,
I'm experiencing strange behaviors with Magento Authentication.
I'm using ngCordovaOauth and I've tried ngCordova as well but every time I try to authenticate I receive an empty alert. (the $http response is ok)
Did u experience similar problems with magento?
Thank you for your reply
Giuseppe

What do the logs say? It should return an object even if there is an error.
Paste the full ADB logs please.

Hello,
thank you for your help.
I've created this repository containing my code https://github.com/flagthrow/magento-oauth-login
Inside the img_dbg directory you can find 3 images about the console logs, the magento backend configuration and the mobile application output.
These are the steps I followed to create the application:
ionic start IonicProject blank
cd IonicProject
ionic platform add android
cordova plugin add org.apache.cordova.inappbrowser
cordova plugin add cordova-plugin-whitelist
bower install jsSHa
bower install ng-cordova-oauth -S
I've always tested my code directly on the device, as you write, and I added meta tag information inside index.html in order to avoid the following warnings:
No Content-Security-Policy meta tag found. Please add one when using the Cordova-plugin-whitelist plugin
I tried to debug my code with chrome//inspect and I'm sure that I have not a 404.
Actually I think that I isolated the error, indeed inside the adb log I have:
D/SystemWebChromeClient(22511): http://<IP_ADDRESS>:8100/: Line 0 : XMLHttpRequest cannot load https://shop.cheersmonkey.com/oauth/initiate. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://<IP_ADDRESS>:8100' is therefore not allowed access.
I/chromium(22511): [INFO:CONSOLE(0)] "XMLHttpRequest cannot load https://shop.cheersmonkey.com/oauth/initiate. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://<IP_ADDRESS>:8100' is therefore not allowed access.", source: http://<IP_ADDRESS>:8100/ (0)
V/WindowManager(  549): not Base app: Adding window Window{a875531 u0 com.ionicframework.magentooauth777080/com.ionicframework.magentooauth777080.MainActivity} at 7 of 13
W/InputMethodManagerService(  549): Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@199f8197 attribute=null, token = android.os.BinderProxy@33f9b0ea
Thank you very much
Giuseppe

Please try ADB instead of Chrome inspect.  CORS errors are usually related to improper installation or testing.
Regards,

Insufficient information.  Closing the ticket.


Plugin Fails to Load if EliteBGS is down

Describe the bug
While doing some testing today I found that elitebgs.app was down, which causes the plugin to fail to load.
To Reproduce
Kind of tricky since you need elitebgs.app to be down... but when it is (or if you can simulate it being down on our local)
Open EDMC and note that the plugin fails to load
Expected behavior
Ideally (not sure how realistic this is with EDMC) there would be some mechanism to have it retry, but there are lots of options. I don't think I'm in a solid position to make a recommendation, but I wanted to raise the situation for awareness.
I can even see a "This worked as expected" given it does present an error message. And maybe the error message could provide a little more info like "close out and try again in a little while
Screenshots

Desktop (please complete the following information):

OS: Windows
Plugin Version 3.2.0-a1
EDMC Version 5.9.5+6f2ba8d

Additional context
Log Entry:
2023-09-12 11:47:15.341 UTC - ERROR - 21456:2260:2260 <plugins>.BGS-Tally.bgstally.tick.Tick.fetch_tick:36: Unable to fetch latest tick from elitebgs.app: HTTPSConnectionPool(host='elitebgs.app', port=443): Read timed out. (read timeout=10)
2023-09-12 11:47:15.342 UTC - ERROR - 21456:2260:2260 plug.Plugin.__init__:75: : Failed for Plugin "BGS-Tally"
Traceback (most recent call last):
  File "plug.pyc", line 66, in __init__
  File "C:\Users\me\AppData\Local\EDMarketConnector\plugins\BGS-Tally\load.py", line 28, in plugin_start3
    raise Exception("BGS-Tally couldn't continue because the current tick could not be fetched")
Exception: BGS-Tally couldn't continue because the current tick could not be fetched
2023-09-12 11:47:15.343 UTC - ERROR - 21456:2260:2260 plug.load_plugins:187: Failure loading found Plugin "BGS-Tally"
Traceback (most recent call last):
  File "plug.pyc", line 185, in load_plugins
  File "plug.pyc", line 66, in __init__
  File "C:\Users\me\AppData\Local\EDMarketConnector\plugins\BGS-Tally\load.py", line 28, in plugin_start3
    raise Exception("BGS-Tally couldn't continue because the current tick could not be fetched")
Exception: BGS-Tally couldn't continue because the current tick could not be fetched

I think the underlying question here is should an inability to load ticket information prevent the entire plugin from loading, or just prevent features that rely on the tick?

The one feature I know is popular in my squadron, is the Target Commander Information, which wouldn't rely on tick information (I don't think).
Its not like Elite BGS goes down a lot. I think this is only the second time I can remember, so its probably not worth the code complexity of having some features work and not.
Agreed with your reasoning on not using older tick data the confusion level on that could be high. I do appreciate your thoughts and insights. I suppose a counter argument for the error message is there is some pretty limited real estate there so anything more verbose probably becomes problematic. I'll defer to you on closing this or not at this point, but I think your explanations make sense, and current behavior/experience is good.

Yeah, it does go down occasionally but it's very bad luck if it's down just as you are starting up EDMC - If it goes down while BGS-Tally is running, the plugin doesn't halt - it just keeps trying elitebgs occasionally, and any activity keeps being tallied to the current tick.


[Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [EventmeshRebalanceImpl]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java line 65,115,127,232
analysis and explanation:
This method calls the size() method on a collection and compares the result to zero to see if the collection is empty.
Describe the solution you'd like
For better code clarity, it is better to just use col.isEmpty().
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I would like to work on this issue. Please assign it to me.


Don't convert all hash-like things to hashes

Changelog
Bug Fixes

Don't convert all hash-like things to hashes: preserve HashWithIndifferentAccess after renaming keys with rename_keys refinement.

Hold for release setup


Update to work with latest version of UnrealSharp (a.k.a. updated naming prefixes)

Update naming conventions to match new generated output from UnrealSharp.  i.e.
Actor -> AActor
ReceiveBeginPlay() -> BeginPlay()
etc.

P.S. I add Unreal prefixes to the names of the C# classes as well (e.g. CropoutPlayer -> ACropoutPlayer) to keep the existing blueprints happy.
Visual Studio PrefixAnalyser also complains about the naming prefixes if it doesn't match the Unreal naming prefix (I think because I have the Unreal Tools installed) - but you can disable that for C# by adding an .editorconfig file with:
[*.cs]
dotnet_analyzer_diagnostic.category-Naming.severity = suggestion


nonTextTags is not working for script tag

I want to allow script tags only with src attributes from specific domains, but nonTextTags: ['script'] option doesn't remove the code contents from it.
Or, is there other way to remove script contents?
To Reproduce
const content = sanitizeHtml('<script src="https://apps.elfsight.com/p/platform.js"></script><script>alert(1)</script>', {
    allowedTags: ['script'],
    allowedAttributes: {
        script: ['src'],
    },
    nonTextTags: ['script'],
    allowedScriptHostnames: ['apps.elfsight.com'],
});

Expected behavior
Should return:
<script src="https://apps.elfsight.com/p/platform.js"></script><script></script>
// or even better, without empty script tag:
<script src="https://apps.elfsight.com/p/platform.js"></script>

Describe the bug
It doesn't cleanup script contents. Returns the same:
<script src="https://apps.elfsight.com/p/platform.js"></script><script>alert(1)</script>

Details
It doesn't work in latest version 2.5.0.

I can reproduce this issue. The intent was made clear by the code that cleans out the content if an allowed source is present, so it doesn't make any sense to keep the content if no source at all is present.

Thank you for fixing it fast! 🎉


notmuch: remove org-mime

Hi Henrik,
I'm not sure about this one. Feel free to decline.
This module is minimally configured and we're not providing anything extra on top with it. There may be many people that use this module and don't know org-mime is available to them. This PR removes org-mime and adds a section to the readme under a heading "Writing HTML Emails."
If you have ideas for why this module should stay, please share.
Best,
Will

Thanks for the help!