The property "created" in the input was not defined in the context.

I tried to run the following code for the universal wallet vc plugin and got the error below. Does anyone know why it happened?
https://github.com/transmute-industries/verifiable-data/tree/main/packages/universal-wallet-vc-plugin/src/__tests__/JsonWebSignature2020
const vc = await plugin.issue({         credential: { ...credential, issuer: key.controller },         options: {           suite,           documentLoader         }       }); console.log(JSON.stringify(vc));

@OR13 I tried to use the latest package but this issue is still available. Do you have any idea why it did not work?
0.7.0-unstable.7
`
import * as Factory from 'factory.ts';
import * as Vc from '@transmute/universal-wallet-vc-plugin';
import key0 from './key-0.json';
import credential from './credential.json';
import { documentLoader } from './documentLoader';
import { Wallet, walletFactory, walletDefaults } from '@transmute/universal-wallet';
import { Ed25519Signature2018, Ed25519VerificationKey2018 } from '@transmute/ed25519-signature-2018';
export interface MyWallet extends Wallet, Vc.VcPlugin { }
const factory = Factory.Sync.makeFactory({
...walletDefaults,
...Vc.factoryDefaults
});
factory.combine(walletFactory)
.combine(Vc.pluginFactory);
export const wallet = factory.build();
async function main () {
const key = await Ed25519VerificationKey2018.from(key0);
const suite = new Ed25519Signature2018({
key,
date: "2021-06-19T18:53:11Z"
});
const vc = await wallet.issue({
    credential: {
        ...credential,
        issuer: key0.controller
    },
    options: {
        suite,
        documentLoader,
    }
});
console.log(vc);

}
main();
`

its possible that the universal wallet is pinned to older versions, that have a bug.
sorry for the late reply, hav you tried the latest version?

Hi @OR13 I used the latest wallet and it did not work. Here is the example
https://codesandbox.io/s/sparkling-field-emgbw

@thomas-tran thanks for reporting this!

Any news? I can't reproduce the example of bbs-bls12381-signature-2020 with the same error

@transmute/universal-wallet-vc-plugin currently has a pinned version of @transmute/vc.js that is older that has this bug.  In the meantime you should be able to issue a credential by not using the wallet plugin and using vc.js directly with the most recent version.
const Vc = require("@transmute/vc.js");
const vc1 = await Vc.verifiable.credential.create({
    credential: {
      ...credential,
      issuer: key0.controller,
    },
    format: ["vc"],
    documentLoader,
    suite,
  });


🐛 Disable EoSR for in-progress delivery, with first substantive appointment (FSA)

What does this pull request do?
IPB-84: Fixes regression caused by #1377:
Given

There are two delivery sessions
And the 1st is "completed" (attended or late)
And the 2nd is "not scheduled" (does not have any attendance)

Then the expected behaviour is

The delivery is still in progress
SPs cannot start an end-of-service report

The actual behaviour was

✅ The delivery is still in progress
❌ SPs can start an end-of-service report

What is the main change?
There is now a list of examples detailing

in which referral state (function name)
in what delivery state (first argument)
what is expected

fun inProgressExamples(): Stream<Arguments> = Stream.of(
  arguments(notStarted, ExpectThat(requiresEoSR = false)),
  arguments(allSessionsHaveOutcomeNoFSA, ExpectThat(requiresEoSR = false)),
  arguments(inProgressNoFSA, ExpectThat(requiresEoSR = false)),
  arguments(inProgressWithFSA, ExpectThat(requiresEoSR = false)),
  arguments(allSessionsHaveOutcomeSomeDNAWithFSA, ExpectThat(requiresEoSR = true)),
  arguments(allSessionsHaveOutcomeAllAttendedWithFSA, ExpectThat(requiresEoSR = true)),
)

fun afterCancelExamples(): Stream<Arguments> = Stream.of(
  arguments(notStarted, ExpectThat(requiresEoSR = false, endingWith = CANCELLED, concludesWith = CANCELLED)),
  arguments(allSessionsHaveOutcomeNoFSA, ExpectThat(requiresEoSR = false, endingWith = CANCELLED, concludesWith = CANCELLED)),
  arguments(inProgressNoFSA, ExpectThat(requiresEoSR = false, endingWith = CANCELLED, concludesWith = CANCELLED)),
  arguments(inProgressWithFSA, ExpectThat(requiresEoSR = true, endingWith = PREMATURELY_ENDED)),
  arguments(allSessionsHaveOutcomeSomeDNAWithFSA, ExpectThat(requiresEoSR = true, endingWith = COMPLETED)),
  arguments(allSessionsHaveOutcomeAllAttendedWithFSA, ExpectThat(requiresEoSR = true, endingWith = COMPLETED)),
)

fun afterEoSRSubmittedExamples(): Stream<Arguments> = Stream.of(
  arguments(inProgressWithFSA, ExpectThat(requiresEoSR = false, endingWith = PREMATURELY_ENDED, concludesWith = PREMATURELY_ENDED)),
  arguments(allSessionsHaveOutcomeSomeDNAWithFSA, ExpectThat(requiresEoSR = false, endingWith = COMPLETED, concludesWith = COMPLETED)),
  arguments(allSessionsHaveOutcomeAllAttendedWithFSA, ExpectThat(requiresEoSR = false, endingWith = COMPLETED, concludesWith = COMPLETED)),
)

What is the intent behind these changes?

Fix the regression
Define a truth table in tests so we can always test any transition

We reviewed the terminology and correctness with @SSMITH-MOJ and the result is ed492e82206c5e7718ca86cd62f5e733b04b6e0c


Every artisan command stuck.

Laravel Version: 5.7
PHP Version:7.2.8
Database Driver & Version:mysql 5.7

Description:
recently when I run php artisan commands, it just stuck without any output error or message.
I have two other  projects in my computer ,The 5.2 works fine,but 5.5 has the same error.
I guess it was because my environment, but 5.2 works ,I have no clue.
Methods I had tried

I tried composer install, update, dump-autoload, still get nothing.
I tried install a new 5.7, same problem.
Then I clear composer cache, redownload , reinstall.Still noting.
I tried put

ini_set('display_errors',1);
error_reporting(-1);

in the artisan file,no error message.

Tried put a / in $kernel->terminate($input, $status);
then I get the error

Parse error: syntax error, unexpected '->' (T_OBJECT_OPERATOR) in /Users/xxx/Documents/devworkspace/php/integrate/artisan on line 50

I checked storage/logs,it was writeable,and no error logs.
DB config is fine.The project works fine, except the artisan command,  just can't publish config files

Steps To Reproduce:
Install laravel  5.7,and it happens

Hi there,
Welcome to Laravel and we are glad to have you as part of the community.
Unfortunately this GitHub area is not a support area for general application issues. This is only for issues/bugs with the framework code itself.
I will be closing your ticket here. Instead please try asking your question on one of the many great community support areas that will likely give you a better answer more quickly:

Laravel Slack (https://larachat.co/)
Laravel.io Forum (https://laravel.io/forum)
Laracasts Forum (https://laracasts.com/discuss)
StackOverflow (http://stackoverflow.com/questions/tagged/laravel)

If you feel I've closed this issue in error, please provide more information about how this is a framework issue, and I'll reopen the ticket.
Thanks in advance.


a "stub not nil" mechanism for apis

Some API outputs are labeled nilable by docs but it would be convenient for their default stubs to be non-nil. An example: C_QuestInfoSystem.GetQuestRewardSpellInfo in classic era ptr.

C_UnitAuras.GetAuraDataBySlot will have the same issue.


'log' doesn't work if the jobs use data-assets as output

'log' calls DOWMLLib.get_job_details with with_content == 'log'. This uses output_data as a filter. But what if the log was stored as a data-asset?  Is the log always inline? Does output_data as a filter also gets output_data_references?

Indeed, when 'outputs assets' is used, the log is stored in output_data_references and that is not fetched when the filter list only has output_data.
dowml> log 22e7237b-d7e8-4f66-b82a-07ebfd65424a
2021-10-05 18:20:57,647 Fetching output...
           GET https://eu-de.ml.cloud.ibm.com/ml/v4/deployment_jobs/22e7237b-d7e8-4f66-b82a-07ebfd65424a?version=2021-06-24&space_id=4645be25-e08e-4a34-a475-ff3cd0dc9635&include=output_data
2021-10-05 18:20:58,675 Done.
None


Call plugin at last

Is there a way to call a plugin at the very end of the build? I'm using laravel-mix-nunjucks extension and minify-html-webpack-plugin. But when I try to minify, the html files don't exist yet.
Any suggestion?

Sorry for the delay in responding to you. I'm assuming you've already moved on, but mix.override() allows for this.


add camry hybrid SL fingerprint

Australian model

@bugsy924 , thanks. Merged internally (without tuning changes). Will be in next OP release


Should we be using IndexedDB?

Right now, MicrobeTrace is using a proto-MVC design where the data is stored in a global object (session.data). I don't know much about IndexedDB, but it's very easy for me to imagine that it could speed up access to the data and give us stronger assurances about it. Let's do a bit of testing to figure out if this is the case.

Conclusion: Probably not. Indexed provides persistence, but slower IO than tracking data in the session's active memory.


Feature Request / Bounty ?

Hi @xwinstone.
Love your project.  I've been looking for a canvas table just like this. I need to be able to do high frequency updates from an array of objects every 500ms but keeping CPU usage low. Cam this do it?
Also I need row selection, column sorting and column re-ordering.
Any chance I could I pay to get some of these features done and a high frequency update demo please? :)

hey, thanks for your love.
The performance is mainly depends on the size of data, if it's small size, I think it will not use many CPU when you do frequency updates.
can you leave your email? i will contact you for the feature you mentioned.

<EMAIL_ADDRESS>


Tweak CMakeLists to reflect migration from urdfdom

I suspect the Travis metafiles have to be merged to master for the build to trigger, so I'm merging this


Very easy request, edit view stays in edit view, even when navigating to other servers.

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
Hello and thanks for the hard work!
I often click edit, to check how I have configured something (example the 'retries' before issuing an alert)
I adjust the retries and click save which is handy.
I would then lick to click on another entry, on the left hand column and continue to see the edit view, for the new entry
Instead it goes to the front entry and I then need to click edit, again.
Here's a very rough pic:
https://i.imgur.com/EoSMtM6.png
✔ Solution
Basically if you're in the EDIT ENTRY view and you click on a different entry on the left column to work with, I'd like to not have to click "edit" again.
❓ Alternatives
There's no real alternative truth be told, this is the quickest and easiest solution, unless you break the entire data out in to some kind of highly detailed looking table (almost like excel?) so I can see all entries at a glance.  That would also be lovely.
I will paypal $20 USD for this request.
Regardless thank you for the hard work, really, it's wonderful and I appreciate your efforts.
📝 Additional Context
No response

I am not convinced that that would be transparent to the user.
Users commonly tab outside of a modal to get out of this window
=> I would argue that the edit window should behave the same as if this were a modal, given how it animates up.
What you most likely want is a bulk-edit option.

You could add a simple "close" next to the save button down the bottom, which would THEN finally close the edit view, regardless of which server entry you'd clicked and worked on.
The bulk edit option, would probably also be viable, assuming the interface was big enough to work with.
I would like the easiest solution, for the developers at the end of the day.

I am not convinced that that would be transparent to the user. Users commonly tab outside of a modal to get out of this window => I would argue that the edit window should behave the same as if this were a modal, given how it animates up.
What you most likely want is a bulk-edit option.

I've changed my mind.
You're right. I have another use this morning for a bulk edit option, which would also eliminate my first issue as well.
I will  bump the thread for bulk edit.
Thanks for your reply!

which would also eliminate my first issue as well

I think this is a duplicate of https://github.com/louislam/uptime-kuma/issues?q=is%3Aissue+is%3Aopen+bulk+edit
If you agree, could you please close this Issue, as duplicates only create immortal zombies and are really hard to issue-manage?
If not, what makes this issue unique enough to require an additional issue? (Could this be integrated into the issue linked above?) ^^

Yes my intention here is that the bulk edit does infact sound like a better option overall.


m68k/coldfire disassembles immediate -1 in mov3q instruction as 0

Describe the bug
According to NXP ColdFire Programmer's Reference Manual, page 122, the data value 0 in the immediate data field represent -1 instead of 0. Ghidra does not implement this edge case.
To Reproduce
Steps to reproduce the behavior:

Create a file with contents as \xa1\x50, eg. by $ echo -ne '\xa1\x50' > test
Open the file in ghidra, format: Raw binary, language: 68000/Coldfire
Disassemble the code in CodeBrowser
See it is 00000000 a1 50           mov3q      #0x0,(A0). The decompiled code
also show *in_A0 = 0;
Compare it with binutils:

$ objdump -b binary -m m68k -D test

test:     file format binary

Disassembly of section .data:

00000000 <.data>:
   0:	a150           	mov3ql #-1,%a0@

Expected behavior
The disassembly should be 00000000 a1 50           mov3q      #-1,(A0) or 00000000 a1 50           mov3q      #0xffffffff,(A0). The decompiled code should be *in_A0 = -1; or *in_A0 = 0xffffffff;
Environment (please complete the following information):

OS: Gentoo Linux
Java Version: 11.0.4
Ghidra Version: 9.0.x-DEV

Additional context
As far as I am aware this instruction is not part of the legacy m68k architecture (not part of Motorola M68000 Family Programmer's Reference Manual) so I am unaware of where this 'edge case' does not apply.
Likely related to above, Capstone cannot disassemble this instruction. IDA version 6.95.160808 (32-bit) disassembles this instruction correctly.

this might be a fix in Ghidra/Processors/68000/data/languages/68000.sinc
-d3bits: d911                   is d911                                         { export *[const]:1 d911; }
+attach values d911 [ -1 1 2 3 4 5 6 7 ];
 :mvs.b: eab, reg9dn            is (op=0x7 & op68=4 & reg9dn )... &eab          { reg9dn = sext(eab); }
 :mvs.w: eaw, reg9dn            is (op=0x7 & op68=5 & reg9dn )... &eaw          { reg9dn = sext(eaw); }
 :mvz.b: eab, reg9dn            is (op=0x7 & op68=6 & reg9dn )... &eab          { reg9dn = zext(eab); }
 :mvz.w: eaw, reg9dn            is (op=0x7 & op68=7 & reg9dn )... &eaw          { reg9dn = zext(eaw); }
-:mov3q "#"^d3bits, eal         is (op=0xa & op68=5 & d3bits )... &eal          { eal = zext(d3bits); }
+:mov3q "#"^d911, eal           is (op=0xa & op68=5 & d911 )... &eal            { eal = d911; }

Fixed here.


Revisit "on source delete" policy

Currently the on source delete delete target policy on links deletes targets unconditionally, which might be dangerous and unexpected if the relationship is not exclusive.  We should consider:

changing the behavior to delete orphan and only perform deletion if no other links to the object exist (though this might be an expensive check unless we restrict it only to the link in question, which is also fine)
only allow delete target on exclusive links.

Thoughts?

which seems fine?

But if we throw an error, that would defeat the point of having the policy in the first place, because then, to be safe you would have to unlink the linked object and then delete.

Basically I'm thinking of a non-exclusive link:
type Foo {
  link bar -> Bar {
    on source delete delete target
  }
}

Then, delete Foo will fail if there happens to be some other Foo that links to this Bar.  So, there appears to be no convenient way of deleting orphan objects here.


Remove extern crate hashbrown

(Merge candidate only after release of 0.30.0)
We no longer have a "hashbrown" feature, the feature gated pub extern crate hashbrown should have been removed when we removed the feature.

I don't think this needs to be gated on 0.30.0, AFIACT it has no user-visible effects and is very unlikely to cause merge conflicts with anything else.

Indeed, feel free to merge it into 0.30.

As for the other one, I don't want rebasing #1699 and waiting for timezones and acks to hold up the release.


[Feat] - script engine support in web viewer

Hi, scripting engine is very interesting feature, but it's not available in web viewer

Hello!
Use Online Designer to edit the script
Specify in the properties of WebReport:
DesignScriptCode = true

Best regards
Marat


Adding termenv to gum's build dependencies

Adding termenv to gum's build dependencies. This seems to let it build without errors

Will close this as it's no longer required


Analyze Import after function

Environment
node v16
Reproduction
import { findStaticImports } from "mlly";

const [match0] = findStaticImports(`function a(){}import baz, { x, y as z } from 'baz'`);

console.log("🚀 ~ file: test.ts:5 ~ match0:", match0) // undefined

Describe the bug
the static import is after the function, can't find static imports
Additional context
No response
Logs
No response

Thanks for report will be fixed in next release


ProtocolSupport is not compatible with ViaVersion & 1.9.4 server

What version of ViaVersion are you using? Type /ver viaversion
0.9.4
What version of Spigot are you using? Type /ver
https://gyazo.com/ac7b39613d13de8adfd4d169f4b85ed3
What plugins are you using? Type /plugins
https://gyazo.com/9bc8ee0e825e39d960fbbc94a82c6ba9
Are you using any additional software like BungeeCord? If so, what software and version? https://gyazo.com/d462b77b0413cdbe12a696c00cb9cb46
How does this error happen? login? Using an item?
Mc 1.9.4, protocolsupport and viaversion won't allow a 1.10 client to join the server
Is there an error in the console? Use pastebin.com. Is there a kick message?
https://gyazo.com/9f30328c9cc146402ec4f3f7dff8733d

Same here, and my server crashes every 2 minutes with this error:
http://pastebin.com/t1jFZ7z0
Using ViaVersion 0.9.4
ProtocolSupport 4.23
Spigot : 1.9.4

[15:08:54 ERROR]: Encountered an unexpected exception
java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) ~[?:1.8.0_73]
at java.util.ArrayList$Itr.next(ArrayList.java:851) ~[?:1.8.0_73]
at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:136) ~[server.jar:git-Spigot-e4d4710-e1ebe52]
at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:814) ~[server.jar:git-Spigot-e4d4710-e1ebe52]
at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) ~[server.jar:git-Spigot-e4d4710-e1ebe52]
at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:654) ~[server.jar:git-Spigot-e4d4710-e1ebe52]
at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:557) [server.jar:git-Spigot-e4d4710-e1ebe52]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_73]
Server crashes and stops itself.

I already have player shuffle set to 0. However my server isn't crashing, it just won't accept 1.10 clients

ProtocolSupport works with 1.8.8 server but has issues with 1.9.4 servers in initial boot.
I've removed irrelevant comments to this case, this will be looked into when I get the time.

As an update, I'm a bit stuck with getting this working.
https://github.com/MylesIsCool/ViaVersion/blob/PS1.9.4fix/src/main/java/us/myles/ViaVersion/handlers/ViaEncodeHandler.java#L40
Hopefully eventually we'll support it but newer ProtocolSupport has changed quite a bit.

1

Sadly no progress on this, had a fiddle the other day and in my branch Chunk packets seem to do something weird. :(

This will never be fixed ? :(

@TheIntelloBox As previously stated the issue is to do with a packet issue and I've previously spent 12+ hours straight looking into this and it's not worth my time unless anyone knows the solution, the code is on a branch if someone figures it out.

With huge help from @Maxqia all versions of ProtocolSupport should be compatible with the 1.11-DEV build.


[HUDI-5031]Hudi merge into creates empty partition files when the sou…

…rce table has partitions and the target table does not
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@weimingdiit i think only merge into can cause this issue, right?

@weimingdiit i think only merge into can cause this issue, right?

yes, it is

@xushiyan @yihua @XuQianJin-Stars  hi, please take a review for this pr.  thks!

@weimingdiit : FYI: Have rebased and made slight changes. Will help take this to completion


Minigames fails

The bot doesnt play the minigame at all, it just keeps sending commands

Bug in v1.3.0 and fixed in a59d9e0 (next release)


Fix typo in vllm extra requirements

Fixes #1314
🚧 Thank you for opening a PR!
A few important guidelines and requirements before we can merge your PR:

[x] We should be able to understand what the PR does from its title only;
[x] There is a high-level description of the changes;
[ ] If I add a new feature, there is an issue discussing it already;
[ ] There are links to all the relevant issues, discussions and PRs;
[x] The branch is rebased on the latest main commit;
[x] Commit messages follow these guidelines;
[ ] One commit per logical change;
[ ] The code respects the current naming conventions;
[ ] Docstrings follow the numpy style guide;
[x] pre-commit is installed and configured on your machine, and you ran it before opening the PR;
[ ] There are tests covering the changes;
[ ] The documentation is up-to-date;

Consider opening a Draft PR if your work is still in progress but you would
like some feedback from other contributors.

Good find, thank you for submitting a fix!


Enable JS toggle switch in table global style options

Description
Enable JS toggle switch in table global style options
Fixes #2906
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

The way we handle property updates, its conflicting with individual column property values.

@vicky-primathon Is this PR still valid? Do we have a fix here?

Closing this, as this fix needs data manipulation on the table widget. Will re-open once we get to this.


do (doseq etc.) body should be newline seperated

boot.user=> (->> (zprint.core/zprint-str "(doseq [x xs]\n  (foo x)\n  (bar x))" {:parse-string-all? true, :parse {:interpose "\n\n"}}) println)
(doseq [x xs] (foo x) (bar x))

Based on clojure code I've read, I would expect each form in the body to be separated by a newline for do and do-likes (doseq, dotimes, dosync).
I think the same is true for a lot of other macros as well, e.g. with-open, future

Thanks for bringing this up!
I'm on the fence for this one.  Personally, I like to see as much as I can in an editor window, so I'm not wild about having my short doseq functions taking up three lines instead of one line.  However, I certainly think that it should be possible to configure zprint to do that if you want to do that.  I assume that what you want here is:
(doseq [x xs]
  (foo x)
  (bar x))

Currently, you can not really get zprint to do that, unfortunately:
"(doseq [x xs] (foo x) (bar x))"
zprint.zprint=> (czprint ds {:parse-string? true})
(doseq [x xs] (foo x) (bar x))
nil
zprint.zprint=> (czprint ds {:parse-string? true :fn-map {"doseq" :force-nl-body}})
(doseq [x xs]
       (foo x)
       (bar x))
nil
zprint.zprint=> (czprint ds {:parse-string? true :fn-map {"doseq" :arg1-force-nl}})
(doseq [x xs]
  (foo x)
  (bar x))
nil

The last one looks like it worked, but it didn't really, as the binding form won't be handled as a vector of pairs.  What we really need is a :binding-force-nl function type.    So that is something I'll have to build, though it won't be hard.  I will do that.
The remaining question is -- should all of the binding functions be converted to :binding-force-nl once I get it finished?  These are the functions:
   "let" :binding
   "binding" :binding,
   "with-redefs" :binding,
   "with-open" :binding,
   "with-local-vars" :binding,
   "with-bindings" :arg1,
   "with-bindings*" :arg1,
   "when-some" :binding,
   "when-let" :binding,
   "when-first" :binding,
   "loop" :binding,
   "if-some" :binding,
   "if-let" :binding,
   "for" :binding,
   "dotimes" :binding,
   "doseq" :binding

Certainly I've thought a lot about forcing let to have newlines between the body forms.  I also have zero idea why I set with-bindings and with-bindings* to be :arg1 and not :binding.  I'll have to look into that!
I could be convinced to make :binding-force-nl the default (as opposed to maybe a style).  Maybe you could send me some pointers to code on github (perhaps in clojure.core, though not necessarily) that you think looks like good code that does what you want?  Probably we should have the default be one way, and have a style that does it the other way.
Of course, you can only configure one style in an options map, say in .zprintrc, so if I keep adding styles I might need to do something different about that.  Maybe a vector of styles or something.  But that is an enhancement for another day.

Interestingly, when looking at a comment on the other issue you raised, I realized that you can, indeed, configure this:
(doseq [x xs]
  (foo x)
  (bar x))

You would add :binding to the set which is the value of :fn-force-nl.  Now, there is a bug, so it isn't trivial to add to that set -- you need to reproduce the whole set.  But if you do that, you can get what you want now.  At least for all :binding fns.  Which may be what you want.  But it isn't very fine grained.  Thus:
zprint.zprint=> ffn
#{:force-nl :noarg1 :noarg1-body :force-nl-body :arg1-force-nl}
zprint.zprint=> ds
"(doseq [x xs] (foo x) (bar x))"
zprint.zprint=> (czprint ds {:parse-string? true :fn-force-nl (into #{} (concat ffn #{:binding}))})
(doseq [x xs]
  (foo x)
  (bar x))

My question for you:  Do you need to configure this fn by fn (i.e., do I need to build a specific :fn-type for this), or are you ok with just having all :binding fns be multi-line?

Thanks for your response! You're right, I prefer
;; newline style
(doseq [x xs]
  (foo x)
  (bar x))

to
;; compressed style
(doseq [x xs]
  (foo x)
  (bar x))

I'll address the issue of why I want doseq (and other forms) to adhere to newline style first.
I think the core of the issue is that typically do is used to indicate imperative-style code. The value of a do block is the value of its last form, so the other forms must be evaluated for side-effects. An example from clojure
(do
   (write-white-space this)
   (.col_write this x))

As a side-note, this is also common in clojure.core:
(do (.appendReplacement m buffer (Matcher/quoteReplacement (f (re-groups m))))
    (recur (.find m)))

but that's a different discussion I think.
As I understand it, people write dos in multiple lines as this reflects the sequential nature of imperative code.
doseq is explicitly imperative (the docstring mentions that the body is executed "presumably for side-effects"). But many other macros (when, time, let) support "implicit do", i.e. they take a body containing multiple forms. For example, when takes [test & body] and wraps the body in a do. The bodies of let, fn and defn are do-likes as well.

Empirically, looking at the clojure git repository (git grep -A5 -B0 '(doseq'), all doseqs or dotimes with multiple body forms use newline style.
I did find some doseqs with a single body form written in a single line. Personally I prefer newline style even for single-form doseqs and the majority of those in the clojure use that style. But my main concern is with multiple-form doseqs (and do-likes in general). My personal sense is that compressed style for these obscures the imperative structure of the code.

I should add that these are all debatable and I may be wrong in my judgments about community conventions. Ideally all of this should be configurable (and making this possible is IMO the most powerful thing about zprint).
Having said that, IMO a library like zprint (like a style guide) should aim to have defaults (or defaults easily accessible) that best reflect community conventions. Ideally we should be able to say,  "If in doubt, just let zprint (lein-zprint, boot fmt) handle it", similar to how things work in the golang community.

To your final question, I'll have to look more into how zprint configuration works to give a more informed answer.

Thanks for the discussion!  It is pleasure to have someone to discuss this with, actually.
First, I totally agree that:

All of this (i.e., the multi-line nature of do-likes) should be configurable.
zprint, by default, should do a nice job.   You shouldn't have to bother to configure zprint unless you want something a particular way. (Which is not exactly what you said, I acknowledge).

I'm completely on board with the idea that by zprint should be easily configurable in order to follow community conventions.  That said, there are multiple communitiies.
The community-style-guide has what are to me very strange conventions about the indent depth based on whether or not  a function has "body parameters" or "arguments".  Personally, I see them pretty much the same way, and I have found limited actual code doing this in practice, though it has been a while since I looked.  I did implement this capability in zprint, because I thought it was important to be able to do it the way the style guide says, but I am not keen to make that the default.
I tend to look at clojure.core as a large part of the community, though it is far from internally consistent.
For defaults I tend to pick what I like from the various example "communities".  Plus my own idiosyncratic issues, like indented second things in cond and initializers in let.
Enough philosophy, let's talk do-like details.
I found this function in zprint:
(defn map-stop-on-nil
  "A utility function to stop on nil."
  [f out in]
  (when out (let [result (f in)] (when result (conj out result)))))

This must drive you crazy.  I realize that an if-let would make it clearer, but
that's not today's point.  You would like it to be:
(defn map-stop-on-nil
  "A utility function to stop on nil."
  [f out in]
  (when out
    (let [result (f in)]
      (when result
        (conj out result)))))

and I don't disagree.
I have added, but not pushed to github, a :fn-type of :gt2-force-nl, to try to get some 1.9-alpha clojure.core spec files to look better than they do today without also looking worse.  The idea here was to have s/or be :gt2-force-nl, where if there were more than two arguments, the s/or would be force-nl.  So, you get this:
(s/or :sym ::local-name
      :seq ::seq-binding-form
      :map ::map-binding-form))

[The reason you this the pairs is because of "constant-pairing", just FYI.]
but you also get this:
(s/or :sym ::local-name)

as opposed to this:
(s/or :sym
      ::local-name)

which is what you would get if it were :force-nl like s/cat is.  This is what the spec file does
today with s/or.
What I am thinking now is that instead of a :fn-type of :gt2-force-nl, that there would be several sets like :fn-force-nl, e.g. :gt2-force-nl, :gt3-force-nl.  This way if doseq was :binding, and :binding was in :gt2-force-nl, then you would get this:
(doseq [x xs] (dostuff x))

and this
(doseq [x xs]
  (stuff x)
  (bother x))

If, on the other hand, :binding was in :fn-force-nl, then you would get this:
(doseq [x xs]
  (dostuff x))

(doseq [x xs]
  (stuff x)
  (bother x))

This doesn't let you configure different handling for, say, doseq and let, as both are :binding functions.  It is, however, a bit more general as the force-nl configuration is taken from the :fn-type, but is not encoded in it directly.  I'm trying to avoid an explosion of :fn-types.
Were I to go this direction, I would have to have some :fn-type to use for s/or and s/and, so I could put them into the :gt2-force-nl set, as they are not otherwise configured as anything today.
How does that sound to you?

Your suggestion sounds great and would cover all cases I can think of right
now.
I'm assuming gt2 stands for greater than two? Does that number include the
bindings vector?
By the way, I don't think writing a doseq in a single line is crazy at all
(though i have a mild preference for inserting a newline). What does
confuse my sense of aesthetics is two sexps in addition to the bindings,
all in one line. But I'm more than happy if I can customize zprint as you
suggest.
On Dec 11, 2016 00:04, "Kim Kinnear"<EMAIL_ADDRESS>wrote:
Thanks for the discussion! It is pleasure to have someone to discuss this
with, actually.
First, I totally agree that:

All of this (i.e., the multi-line nature of do-likes) should be
configurable.
zprint, by default, should do a nice job. You shouldn't have to
bother to configure zprint unless you want something a particular way.
(Which is not exactly what you said, I acknowledge).

I'm completely on board with the idea that by zprint should be easily
configurable in order to follow community conventions. That said, there are
multiple communitiies.
The community-style-guide https://github.com/bbatsov/clojure-style-guide
has what are to me very strange conventions about the indent depth based on
whether or not a function has "body parameters" or "arguments". Personally,
I see them pretty much the same way, and I have found limited actual code
doing this in practice, though it has been a while since I looked. I did
implement this capability in zprint, because I thought it was important to
be able to do it the way the style guide says, but I am not keen to make
that the default.
I tend to look at clojure.core as a large part of the community, though it
is far from internally consistent.
For defaults I tend to pick what I like from the various example
"communities". Plus my own idiosyncratic issues, like indented second
things in cond and initializers in let.
Enough philosophy, let's talk do-like details.
I found this function in zprint:
(defn map-stop-on-nil
"A utility function to stop on nil."
[f out in]
(when out (let [result (f in)] (when result (conj out result)))))
This must drive you crazy. I realize that an if-let would make it clearer,
but
that's not today's point. You would like it to be:
(defn map-stop-on-nil
"A utility function to stop on nil."
[f out in]
(when out
(let [result (f in)]
(when result
(conj out result)))))
and I don't disagree.
I have added, but not pushed to github, a :fn-type of :gt2-force-nl, to try
to get some 1.9-alpha clojure.core spec files to look better than they do
today without also looking worse. The idea here was to have s/or be
:gt2-force-nl, where if there were more than two arguments, the s/or would
be force-nl. So, you get this:
(s/or :sym ::local-name
:seq ::seq-binding-form
:map ::map-binding-form))
[The reason you this the pairs is because of "constant-pairing", just FYI.]
but you also get this:
(s/or :sym ::local-name)
as opposed to this:
(s/or :sym
::local-name)
which is what you would get if it were :force-nl like s/cat is. This is
what the spec file does
today with s/or.
What I am thinking now is that instead of a :fn-type of :gt2-force-nl, that
there would be several sets like :fn-force-nl, e.g. :gt2-force-nl,
:gt3-force-nl. This way if doseq was :binding, and :binding was in
:gt2-force-nl, then you would get this:
(doseq [x xs] (dostuff x))
and this
(doseq [x xs]
(stuff x)
(bother x))
If, on the other hand, :binding was in :fn-force-nl, then you would get
this:
(doseq [x xs]
(dostuff x))
(doseq [x xs]
(stuff x)
(bother x))
This doesn't let you configure different handling for, say, doseq and let,
as both are :binding functions. It is, however, a bit more general as the
force-nl configuration is taken from the :fn-type, but is not encoded in it
directly. I'm trying to avoid an explosion of :fn-types.
Were I to go this direction, I would have to have some :fn-type to use for
s/or and s/and, so I could put them into the :gt2-force-nl set, as they are
not otherwise configured as anything today.
How does that sound to you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kkinnear/zprint/issues/3#issuecomment-266246202, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGfWL3SdXSnahgHr09-q9L87eH1CMDKks5rGy_4gaJpZM4LFt__
.

This is fixed in 0.2.10.
I ended up creating two new sets, :fn-gt2-force-nl and :fn-gt3-force-nl, which will keep a function type which appears in either set from printing all on one line if it has greater than 2 (gt2) or greater than 3 (gt3) arguments.  I have put the :binding in the :fn-gt2-force-nl set, so that a doseq with one thing after the binding will print on one line, and with two things to do after the binding it will print on multiple lines even if it is short.  If you always want doseq, or anything with a binding, to print on multiple lines, put :binding in :fn-force-nl instead of :fn-gt2-force-nl, and it will do that.
Thanks for the suggestions!


chore: add integration tests

Issue
Currently there are no integration tests to check a plugin update with the reaction version
Solution
This PR adds a circle CI step that runs the integration tests on the plugin.
Breaking changes
None expected
Testing

Go to the CircleCI jobs, in the logs you can see the integration tests being run.

This is failing because of nodemailer authentication issue. Will ask others to get the latest creds for this.


Add traits for delta E and the improvemed formulas from Huang et al

Adds the DeltaE, ImprovedDeltaE and ImprovedCiede200 traits. The first one represents the "default" or canonical delta E formula for a color space as it was originally specified. If there is no specification for delta E, it's not implemented. It's also not necessarily the best. The other two implement the enhancements described in Power functions improving the performance of color-difference formulas by Huang et al. They are provided as separate traits so the user can choose which one is the most appropriate for their use case.
This is the result of me trying to sort out where different formulas come from and prepare for adding a delta E for CAM16-UCS in #342. The recommended formula for CAM16 turns out to be the "improved" one.

Ok, this is a pickle. The memchr dependency is only used in tests, so the dependency shouldn't matter for MSRV. Yet, I can't run the full tests without it. I'll see if I can re-shuffle the tests for now.

Interesting, those benchmarks run about 10 to 20 times faster on my machine. Either way, it's the relative difference that's interesting.

bors r+


Homepage images are cut off by the informational footer when mobile keyboard is open

Description

Reproduction

 Open the homepage in a mobile browser like Firefox for Android and select the search input. See the screenshot below for example.

Screenshots

Environment

Device:  Pixel 6
OS:  Android
Browser:  Firefox

Resolution

[ ] 🙋 I would be interested in resolving this bug.

Closing this issue because the new homepage design does not contain images on mobile.


Update Python version on Windows installer to 3.10 to not flag match as an error

Description
What steps will reproduce the problem?

I've been using python 3.10 on spyder 5.3.3, using the external interpreter to be able to use the last python version (standard included spyder python is 3.8.10). Everything works fine but the pyflakes linter gives sintax errors whenever I use the match - case structure.
This is pretty annoying and I tried to install pyflakes 2.5.0 (which should in theory solve the issue) but there is no effect on Spyder. I installed it from my external terminal, thus I thought that Spyder was still trying to get the internal version of spyder. It turns out that the internal version of pyflakes was still 2.4.0, and I couldn't upgrade it to 2.5.0 beacause it is not supported by python 3.8.10.
Is it possible to have pyflakes read from my external python build?
 We're going to increase the Pyflakes version we use in the next Spyder version (5.4.0), to be released next month.

Sorry, I just saw you said

Is it possible to have pyflakes read from my external python build?

Sorry, that's not possible. You have to wait until 5.4.0 is out.

Alright thank you anyway. I'll wait for the 5.4.0 then ;)

Just in case, @dalthviz, could you check if we're still showing errors in the editor for match cases using our Windows installer built in our latest pull requests?

@ccordoba12 I think the installers build on PRs for Windows uses python-lsp-server1.5.0 (python-lsp-server is not being installed from the external-deps folder, only spyder-kernels and qdarkstyle). Also, just in case, the way Spyder will depend on Pyflakes >=2.5.0 will be due to an update to constraint python-lsp-server to be >=1.6.0 for Spyder 5.4.0 (which will include these changes: https://github.com/python-lsp/python-lsp-server/pull/257).
So the installers for Windows (even the ones that come from PRs) use for the moment Pyflakes 2.4.0 and python-lsp-server 1.5.0

Ok, I tested this locally with Spyder running on Python 3.7 and Pyflakes 2.5.0, and Pyflakes still marks match as an error. So I think the only solution for this is to update the Python version that comes with our Windows installer to 3.10.
However, that's going to take us between three to six months because it's not that easy.

Just curious about the status of this update.  I'm running python 3.10.9 externally, and I'm on the Windows version 5.4.2 of Spyder which still seems to be using python version 3.8.10 internally.  Of course the code still runs even when flagged up as being in error, so it's not crazy urgent or anything, but it would be nice not to have spurious syntax errors flagged up in my scripts.

This will be fixed in Spyder 6.0, to be released in the second half of the year.

Closing because our new Windows, Mac and Linux installers, which are going to be based on Conda, will come with a more recent Python version.


Renovate's GitHub app worker blocked from looking up tags for this action

Summary
We're using renovatebot/renovate's GitHub app to manage our dependency updates.  Recently, we've noticed that Renovate can't lookup this action's tags, with the following error:
"response": {
    "statusCode": 403,
    "statusMessage": "Forbidden",
    "body": {
        "message": "Although you appear to have the correct authorization credentials, the `bridgecrewio` organization has an IP allow list enabled, and <IP_ADDRESS> is not permitted to access this resource.",
    }
}

This used to work, so I'm guessing there's been a change to your GitHub org's IP allow list.  Any chance someone could look into this?
Here's the associated discussion with Renovate support:
https://github.com/renovatebot/renovate/discussions/17826
Related

#46

hey @patheard thanks for reaching out. I answered inside the discussion thread. I don't see any problem on our side, either renovate changed something or GitHub did. This repo is public for any reads and we keep an IP whitelist for direct write permissions to it. This behaviour is in place for many months, so I don't think we can change anything and I don't understand why we should.

Yup, totally agree - I dug into it more and the responsibility is on the Renovate side to first safe-list their app's IP address:
https://github.com/renovatebot/renovate/discussions/17826#discussioncomment-3668839
If they did that, then it would be possible on your side to have your org allow those app IP address.
Thanks for looking into it.


Make retry with different request possible

It often needs change request a little when retrying a request. For example, access_token is expired so request failed. When retrying this request, we need to use new access_token.  But Psr\Http\Message\RequestInterface is immutable. This PR makes retry with different request possible.

Hm, this looks interesting, wonder why I missed it. I will check if I can include it in the 6.3 release.

Can you please rebase your branch? Also, can you please provide some tests?

Tests have been added.

The implementation looks good to me. Can you please also add a note about this feature to the middleware's docblock?

I like this. But as Mark says, the doc block needs to be updated.

Also, make a comment on why we cannot use strict comparison.

I think so. Could you rebase this?

Closing due inactivity.

Feel free to reopen this PR if someone wants to work on it

Any progress regarding this feature?


Alow to pass DLNA featureas and getTransportInfo

Consider to merge this PR.
I have to do hard-code to make the media seekable on my TV.
var protocolInfo = 'http-get:*:' + contentType + ':DLNA.ORG_PN=AVC_MP4_BL_L3L_SD_AAC;DLNA.ORG_OP=01;DLNA.ORG_FLAGS=01700000000000000000000000000000';

@ReeganExE You can use my fork with this feature https://github.com/Andro999b/node-upnp-mediarenderer-client

it's a wonder why no one actually merged this 😮 I was trying to make seek working on TV since last 2 weeks, and read up on all specifications, and used wireshark to capture requests etc, and to find out the only change I really need to do is add the flags on protocolInfo, I was about to make a PR to this repo, but found this PR here, but it's opened since a long time,
can please merge to this repo? If not someone will have to end up maintaining a fork of this 😞

If this doesn't get merged till tonight, I'll probably fork it, and put it on my organization, at least others can respond if I don't in future if someone needs this.

@Andro999b would you mind publishing the package to npm and allow issues to be created?

I’m really sorry I have no time to review pull requests. I accepted this one without review and will publish to npm asap. I’ll be happy to add a maintainer for future PR approval.

It's published. Really sorry about the reactivity (or lack of, that is)

you have no idea how much this means to me, thanks a lot, and I really appreciate you doing this I know you're quite busy. (I thought you retired) 😄
I'll now be able to not do monkey patching anymore. Thanks


Clarify which version the docs apply to

As reported here (internal link), some users of the previous beta release are getting confused since the contents of the docs page no longer reflect the data structure and sample names of the old integration.
We should make this more evident in the docs, clarifying to which version this applies in a visible Callout.

I've done this PR so we can consider this ticket as closed.
https://github.com/newrelic/docs-website/pull/3948
https://docs.newrelic.com/docs/integrations/host-integrations/host-integrations-list/windows-services-integration/


tests: run all tests for jewel and kraken

Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>(cherry picked from commit 1b6b6d6255fedddd6f44b932f0da5d2390920092)
Conflicts:
tox.ini
backports #1410

jenkins test jewel-ansible2.2-centos7_cluster

jenkins test jewel-ansible2.2-update_cluster

jenkins test jewel-ansible2.2-update_dmcrypt

jenkins test kraken-ansible2.2-update_cluster

jenkins test kraken-ansible2.2-update_dmcrypt

I expect the docker scenarios to fail, I don't think they've ever passed on the stable-2.1 branch.

we're missing some scenarios, will need to backport more commits here

@andrewschoen bump


Missing reporting for manual tests

In this PR https://github.com/rpm-software-management/ci-dnf-stack/pull/1475, tests were triggered by a comment and Packit did not report anything to user, even though the tests were actually submitted.
Configuration: https://github.com/rpm-software-management/ci-dnf-stack/blob/main/.packit.yml

Looks like this affects the manual_trigger tests in general, not only corner case, e.g. https://github.com/oamg/convert2rhel/pull/1138 (tests stuck at Tests have been submitted)


Create WSGI entrypoint for gunicorn for production deployments

@tw4l sorry to be that guy, but is is possible for you to describe this as problem: statement of the problem? This looks like a solution, but are there other alternatives we might consider here?

@ross-spencer Yes, fair! The real problem is that we're using Flask's development server in production, which it isn't intended for, and I jumped to this solution based on what we use for other applications. But happy to take a step back - I'll modify the issue title now.

Addressed in commit https://github.com/artefactual-labs/AIPscan/commit/c16a2a1452ffe987cd980304100d0f3b3c8b7fce, which includes instructions for how to serve AIPscan and its dependencies using gunicorn and persistent services.


exported err variables should be of type error

Ohai! Cool package!
This changes the ErrXxx things to be of type error. Why? It's not good practice to match errors based on their .String() value. If the package's exporter ErrXxx.. are of type string, it encourages users to do just that.
r: @ryanuber

Hey @aybabtme, thanks for the PR! I completely agree that the errors should be static. I think what I'll do is merge this, then bring in #15 after a rebase on top of your changes. I think we need to just break this API and defer to vendoring for those who are affected by it, since all of these changes are important. I never like breaking BC, but in go-license's case I think it is worth it. See the comments in #15 also.

Yeah I think breaking BC here is not big deal.


Introduced custom validator

Added bonus is the ability to see if forms are valid
part of https://github.com/fabric8-launcher/ngx-launcher/issues/216
@ia3andy step one

@edewit can you please change the commit message to support semantic release. For eg: fix(something): <message>

@edewit needed help here, I tried testing it locally with linking to fabric8-ui

GitHub repo name is not getting validated looks like.

Even Login and Authorize was not working  for gitHub

@invincibleJai could you tell me how to reproduce that when I do the following:
$ ngx-forge> npm link
$ ngx-forge> cd ../fabric8-ui
$ fabric8-ui> npm link ngx-forge
$ fabric8-ui> npm start

I get the following compile errors

@edewit one more info on this, as of now App Name and repo name has to be same and unique. Can know from here

https://github.com/openshiftio/openshift.io/issues/3095#issuecomment-386208142
https://github.com/openshiftio/openshift.io/issues/3432

And this scenario is already implemented for OSIO flow, we need to make sure that these changes doesn't break this.
CC @jyasveer @arunkumars08

@edewit If this is also about taking care of same name for both Github and app, could this wait until this - https://github.com/openshiftio/openshift.io/issues/3662? As this will remove the validation of github repo and app name to be same.


Add badges for pypi, github action, codecov

Codecov Report

Merging #2 (439d1ad) into master (141bd9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   41.69%   41.69%
=======================================
  Files          11       11
  Lines         259      259
=======================================
  Hits          108      108
  Misses        151      151

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Display text wrong

It should be something like "1 month ago", but it writes "yesterday".

Edit:
I just notice #281, but it seems not fixed.

Can you please make a PR with a failing test? We have a bunch of tests in a file that look like this:
https://github.com/github/relative-time-element/blob/15ca61e1992f39f242aa4de0b35c14ce76062990/test/relative-time.js#L1806-L1812
If you copy that object and add a new one right below it with the values tweaked to represent the expected output, and we can see if it fails. If it does fail we can look at a fix.

It's not a problem with relative-time-element. GitHub is not using version 4.4.2 yet.
See https://github.com/primer/react/pull/4803


Label colors not color blind accessible

Opening this after discussion on #52
Maybe use a dark thicker border to distinguish selected labels...
@fenollp do you have any ideas/suggestions on this?

I'd say when unactivated set all the labels to the same neutral color, do whatever you want in all other cases


how to reproduce the results on vqa_RAD

Thank you for publishing this great work.
I have several issues about reproducing the results on vqa_RAD.

I found the model weights are removed from the huggingface repo.

What is the difference between MoE-Tinymed-phi2-llava and llavaphi-2.7b-finetune-3epoch?

I have to change the "mm_image_tower": "/data/songtao/clip-vit-large-patch14-336" to "mm_image_tower": "openai/clip-vit-large-patch14-336" in the config file, otherwise the testing script can not be run. Is it the right way?

Which --conv-mode should be used? The "simple" one used in the readme example can not be found in the codes.

Which models should be used to reproduce the results in Table 2 in your paper?

Hello! Due to some files not being uploaded correctly to Hugging Face when using the VPN earlier, I have just re-uploaded them. I have updated the conversations.py file to add the simple option for conv_mode. You need to download the stage2 and stage3 models, then update the vit and model path in the config file (your third step of modifying the vit path should be correct). Our Table 2 results were produced using the stage3 model.


Add ability to create template from string

Couldn't figure out a way to create a template from a string vs only reading from a directory. This would be very handy to have as the standalone version of handlebars has it.

I just posted another fix to a sort-of related issue, but you might be able to do this with a custom helper
var Hbs = require('express-handlebars');
_helpers.partialFromString = function (markup, data, options) {

    var hbs = Hbs.create({});
    var template = hbs._compileTemplate (markup);

    // call inner nested helpers, this might not be necessary for you
    options.fn(options.data.exphbs);

    return template(data, options.data.exphbs, options);
};

and then call it with
{{#partialFromString "<div>{{text}}</div>" someModel}}{{/partialFromString}}

with your calling view having "someModel" in its data context.


Add headings and enable anchors to network parameters

Story
As a user
I want to see network parameters organised by type
So that I can find it more quickly / avoid having to guess at the naming
Acceptance Criteria

[ ] I can see network parameters grouped by type e.g.

GOVERNANCE PROPOSALS
Asset
Governance.Proposal.Asset.MaxClose 720h
Governance.Proposal.Asset.MaxEnact 720h
Free form
Governance.Proposal.Freeform.MaxClose 8760h0m0s
Governance.Proposal.Freeform.MinClose 72h0m0s

[ ] Network parameter headings act as linkable anchors i.e. a third party website can link directly to a "section" of the network parameter page

Tasks

[ ] Implementation
[ ] Team review

Additional details / background info

Have a sketch ready for this to discuss with Elmar, once happy with it it can go to Joëlle to be designed

This is already implemented, but buggy. See: https://github.com/vegaprotocol/frontend-monorepo/issues/1732

It's a wee bit different @edd, this ticket is about adding more structure to the page to improve readability and navigability, i.e. grouping parameters, giving each of those groups a section/heading, then making those new sections/headings linkable
So we'd be able to link people to the section for new asset proposals, for example
Some exploration on the Block explorer Miro board

Oops! I see it now - my fault for skipping the intro.


feat: forgot password, schema

In this we have created the forgot Password feature directly in the Auth and plus its schema and validation.

Hello Sir
I have submitted a pull request for issue #10, which includes a feature forgot password and schema. I kindly request you to review the pull request and any changes require ping me.


🐛 BUG: Alpine intellisense does not work in .astro files

Describe the Bug
I tried out the Alpine extensions for syntax highlighting and intellisense, and found neither seem to work in .astro files; only .html. It sounds like VS Code has a customData format we need to adhere to according to @Princesseuh.
To quote the README:

This extension aims to keep as small a footprint as possible by injecting a simple grammar to provide JavaScript highlighting rather than implementing an entirely new language and by using the Custom Data Extension to add custom HTML attributes.

Steps to Reproduce

Install the Alpine intellisense extension
Visit a .html file. Note that typing an example like <p x- pulls up intellisense.
Do the same in .astro file. Note intellisense options do not appear.

This happens because currently we don't collect the contributed customData of other extensions, like the HTML language server does.
In the meantime, you can manually specify the paths to the custom data in html.customData in your config, like such:
  "html.customData": [
    "/Users/erika/.vscode/extensions/adrianwilczynski.alpine-js-intellisense-1.2.0/customData/html.json"
  ],

Hmm workaround is problematic, when you use 1 setup for different project types. It would be super cool to make this extension just work out of the box, without any hacky solutions.

Hmm workaround is problematic, when you use 1 setup for different project types. It would be super cool to make this extension just work out of the box, without any hacky solutions.

You can put that setting in the project's config.

Upstream issue: https://github.com/volarjs/services/issues/88

If anyone is interested in implementing this, Johnson's Volar port of the VS Code HTML language server would be a good reference: https://github.com/microsoft/vscode/pull/171547

This happens because currently we don't collect the contributed customData of other extensions, like the HTML language server does.
In the meantime, you can manually specify the paths to the custom data in html.customData in your config, like such:
  "html.customData": [
    "/Users/erika/.vscode/extensions/adrianwilczynski.alpine-js-intellisense-1.2.0/customData/html.json"
  ],

As for the syntax highlighting, the extension linked needs to inject into the Astro syntax: https://github.com/Sperovita/alpinejs-syntax-highlight/blob/2cf4f66f264dabeb218bb28128c2844aceb4a4a9/syntaxes/injection.json#L3

Not working on windows or iam too stupid

Make sure the path is correct for you. The path I gave is an example.

Make sure the path is correct for you. The path I gave is an example.
Yea i did that, just vscode ignores it :D


How to change background image

Hi everyone, I apologize for the trivial question .. but how do you replace the background image of the template? thank you very much

You can change the background image by changing the background property in the the-big-picture.css file. There is a background image set using a placeholder URL. You can add an image to your project and point to it, or use an external image URL in that spot.


Store Todoist completed tasks

[ ] Sync with Todoist
[ ] Parse task id
[ ] Store tasks in the database using task id
[ ] Skip duplicates
[ ] Complete some tasks in Todoist
[ ] Sync again
[ ] Compare open tasks with saved tasks
[ ] If not found, mark tasks as completed/deleted/not active

Not needed for now.


"CalledProcessError" when training data on my workstation

I use a new machine(CentOs7) and the program return CalledProcessError when running dist_train.sh:

this is train.sh file:

and dist_train.sh:

All dependencies install succeed. cudnn version 7.6.3
Could you please help me figure out the problem? Thank you!

Please use the Error Template.


how to trace the transaction link according to the XID

Why you need it?
I want to implement the distributed transaction tracing according to the XID, but  seata-plugin could not finish it.
How it could be?
Intercept distributed transaction requests with xid and span xid into the seata-plugin
Other related information
End-to-end distributed transaction tracing

https://seata.io/zh-cn/docs/user/apm/skywalking.html  Did you actually encounter any problems based on this document?

https://seata.io/zh-cn/docs/user/apm/skywalking.html Did you actually encounter any problems based on this document?
yes，i want use xid as a conditional trace distributed transaction in skywalking

i got ,we will review this pr you submit


feat: story/GD-31 AWS S3 document structure provider added.

Codecov Report
Base: 70.61% // Head: 70.70% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (beebe36) compared to base (6681c5e).
Patch coverage: 71.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #82      +/-   ##
============================================
+ Coverage     70.61%   70.70%   +0.09%
- Complexity     1165     1231      +66
============================================
  Files           127      131       +4
  Lines          3549     3735     +186
  Branches        236      245       +9
============================================
+ Hits           2506     2641     +135
- Misses          910      955      +45
- Partials        133      139       +6

Impacted Files
Coverage Δ

...esystem/FileSystemDocumentStructureRepository.java
36.95% <ø> (ø)

...ntstructure/repository/aws/s3/S3ClientFactory.java
61.53% <61.53%> (ø)

...y/aws/s3/AwsS3DocumentStructureRepositoryTest.java
68.75% <68.75%> (ø)

...itory/aws/s3/AwsS3DocumentStructureRepository.java
70.83% <70.83%> (ø)

...ructure/repository/aws/s3/S3ClientFactoryTest.java
92.59% <92.59%> (ø)

...gine/core/documentstructure/DocumentStructure.java
79.48% <0.00%> (+5.12%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add support for built-in default reviewers

Instead of relying on the Workzone plugin it would be nice if you could also add default reveiwers using the feature that comes out of the box with Bitbucket.
I believe it should be possible to deprecated the old default-reviewers since there is already a separate workzone config for that and the key default-reviewers could be updated to support the built-in one.
I guess it would look something like this:
default-reviewers:
  - source-branch: PRE-**
    target-branch: main
    groups: []
    users: []
    required-approver-count: 1
  - source-branch: feature/**
    target-branch: *

They have a few different modes for the source and target branches but I guess most of them could be achieved with the wildcards.

Hi @terlar , that makes sense. Will see what I can do.

Old comment from a user, which could still be relevant:

Please continue to support Workzone and add support for the native Bitbucket default reviewers feature. The native implementation is limited compared to the Workzone plugin, but has a better UX in the simple cases.
If you use the native Bitbucket functionality, the Reviewers field on the Create Pull Request form is pre-populated. I can see upfront that people are being added automatically, and I can remove people from the list (if I want to focus the PR to a subset of the default reviewers).
If I use Workzone, the Reviewers list is not pre-populated and I don’t have any indication that it will be. The reviewers are all added automatically after I create the PR.
Our team decided we want the default reviewer list to include (almost) everybody, but that we want the flexibility to focus the list down to certain people.
Just to clarify, I don't think it's a good idea to have default-reviewers work for both Workzone and native Bitbucket, nor should you drop Workzone and switch exclusively to native. I would appreciate that the bitbucket-erlang-client be simply a programmatic alternative to manually configuring the repo, so that we can maintain consistency among multiple repositories and have the config in version control. It really should not impose additional restrictions on what can be configured.


[ci:component:github.com/gardener/etcd-druid:v0.13.2->v0.13.3]

Release Notes:
A bug has been fixed that caused the wrong `minAvailable` configuration being calculated for multi-node etcd `PodDisruptionBudget`.

The `BackupReady` condition is not considered anymore when the `PodDisruptionBudget` configuration is calculated. This earlier blocked rolling out fixes that potentially solved problems with backup procedures.

/kind bug

/cherrypick release-v1.55

/cherrypick release-v1.56


[Add]

Site URL
https://www.youtube.com/@ApnaCollegeOfficial
Description of the above provided site
Apna College is a popular YouTube channel dedicated to providing valuable content and resources to college students. The channel aims to support students in navigating various aspects of college life, including academics, career development, personal growth, and student well-being.
Category
Youtube
Sub Category
"Web Development"
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Hi @Soumyajit2825! :) Just to confirm, are you participating in GSSOC'23?

@CBID2 yeah !!
Obviously I am !

@CBID2 yeah !!
Obviously I am !

Lol, it's protocol to ask @Soumyajit2825.
Obviously I am !

Lol, it's protocol to ask @Soumyajit2825. You're assigned

😄 thanks


Convert commands with para like s/retail

https://github.com/Arkyo/Sailron/commit/8071432a14be55fb27c026a100d4f0c4831d2e1b


Add event field to interactions

Codecov Report

Merging #504 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    96.56%   96.57%   +<.01%
===========================================
  Files          122      122
  Lines         3726     3734       +8
  Branches       339      340       +1
===========================================
+ Hits          3598     3606       +8
  Misses          87       87
  Partials        41       41

Impacted Files
Coverage Δ

datahub/search/interaction/serializers.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ae504...1fb506c. Read the comment docs.


Question: GraphQL

Any plans to support GraphQL in Denali?

@lifeiscontent definitely. That would most likely come as a semi-official addon, i.e. denali-graphql. I don't know GraphQL well enough at the moment to comment on how that would be structured, but if you're interested in trying to implement it, I'm happy to brush up on the details and talk through how to approach it.
P.S. Feel free to hop on the Slack team - it's usually a better outlet than an issue to discuss something like this. I'm on there pretty regularly. https://denali-slack.now.sh/

Closing since there is no immediate action here, but happy to reopen to continue the conversation with anyone willing to contribute here.


Zen Mode Resize Cursor on Left

VSCode Version: Insiders
OS Version: macOS

Regarding test item #15647

Steps to Reproduce:

Drag cursor to far left
Note the resize cursor.
Also, I'm not sure if this by design, but while this resize cursor is present, sometimes you can drag the Explorer viewlet out and other times you can't.

This is by design - it is the same behavior when you are not in zen mode and you just hide the sidebar.
Closing as it has been like that forever before the introduction of zen mode


instana-agent - update example for 1.11

https://github.com/dcos/examples/tree/master/instana-agent
Pick any open and unassigned issue in the list of GitHub issues and assign it to yourself by leaving a comment here in the issue. Then update the example by following these steps:

[ ] Fork the examples repo on GitHub.
[ ] On a new branch, make a copy of latest example directory (mostly 1.10 or 1.9) for your package and name it 1.11.
[ ] Test the example on a DC/OS 1.11 cluster. As you test, replace the old screenshots with new ones and make any necessary corrections to the example.
[ ] Feel free to also improve the instructions.
[ ] Add a link to your newly created 1.11 example to the README.md file for your package's directory.
[ ] Report your results:

If the example works out of the box, or you are able to correct it, open a PR with your changes (including the example itself and its addition to the README.md file) and add it to the issue.
If you can’t get your example to work, add a detailed description of what went wrong on the issue (you still get stickers!).

When you’re done, email<EMAIL_ADDRESS>with the following information:
Subject: 1.11 Example Testing - [Service Name]
Body:

Your name
GitHub Issue link
Your Twitter handle, if you have one
Community Slack handle if you have one
Mailing address (for the stickers)

The Community team shepherd will review your PR and either work with you to make modifications or just merge it if it looks good.

https://github.com/dcos/examples/pull/354

Done! Thanks again @jmsprkr


[lit] Do not delete the cache.

Otherwise, running some tests locally takes 15+ seconds even though
the test should finish within a few hundred milliseconds.
Fixes SR-15044, rdar://problem/81672238.

@swift-ci test

Deletion was added here: https://github.com/apple/swift/commit/9e9116229047f8df404cfd2813bb8894d56efb39

Maybe we should have a setting we can enable to turn on deletion if someone wants it? Rather than removing it completely?

The original problem which caused this patch to be introduced was due to the use of
clang_module_cache_path = tempfile.mkdtemp(prefix="swift-testsuite-clang-module-cache")

which would create N copies of the cache for N lit invocations.
However, because the change stopped creating temporary directories, that itself should be enough to stop creating N copies across N invocations. Now, while bisecting, you'll end up with K copies of things where K is the number of different swiftmodule serialization versions across the range of bisection. However, the serialization version is not bumped very frequently at the moment (I'm guessing it was changing more earlier), which means that unless you are bisecting across a very large range of changes, there should be a fair bit of sharing across commits.
Also, if it really is an issue in practice, that can be handled in the bisection script quite easily with something like:
find $TEST_DIR -type d -iname 'clang-module-cache' -delete

which is not that complicated compared to passing an option LIT_DELETE_CACHE=1 (you'd still need to know that such an option exists).
That said, if we decide that this is indeed a usability issue and a problem folks are running into a fair bunch, I think it's okay if we add an option in the future. But for now, I think it's preferable to leave it in a simpler state.

Deletion was added here: 9e91162
However, because the change stopped creating temporary directories, that itself should be enough to stop creating N copies across N invocations.

The above change preserved the behaviour of always having a fresh module cache when running tests, it didn't introduce it.

Now, while bisecting, you'll end up with K copies of things where K is the number of different swiftmodule serialization versions across the range of bisection.

For clang modules you'll get a copy per llvm/clang commit, which is a component of the module directory hash.

This change seems reasonable to me: you should only need to care about cleaning the cache when you're working on either clang or swift modules (ie making changes without bumping the format version or without an llvm commit being made yet).  It would probably be a good idea to get a review from the owner of the clang importer though, since clang modules are notorious for hard to debug/reproduce cache-consistency issues, and I may not have thought of all the possible ramifications of this change.

It would probably be a good idea to get a review from the owner of the clang importer though

Added @beccadax for review.
Yeah, there was concern about module issues on Twitter from Michael G and Jordan, but if that's an issue I think we should do a clean at the build-script level instead of inside lit, because lit is used iteratively.

I can reproduce the issue with test/ClangImporter/non-modular-includes.swift, marking this as DNM until we figure out a fix for that.

in that the debugger can insert modules into the module cache that Swift normally wouldn't produce
…
and then Swift can't detect that there's something wrong when it loads those modules.

@beccadax I'm wondering if these are implying lldb should operate differently? Would you mind providing an example? What modules would lldb insert that Swift wouldn't normally produce? In what ways is there something wrong with the modules?


[Game Crash] Trying to use some SM5.0.12 themes

Describe the crash
I tried using the Staiain Ultralight edit but then the game not only crashed himself but it also crashed my computer.
How can you reproduce the error?

Install Staiain Ultralight theme
Try to set it on the game

Screenshots/Videos
No response
Game Mode
None
Additional Information
Also happens when I try to use default SM5.0.12 but that one crashes on music select

This could more likely be a Lua error by the theme approaching an invalid situation when entering the theme (or Select Music in your case with 5.0.12). Will still look into this and see what's going on.

Found out the hang reason for the staiain theme: The metrics for the theme have the following:
[ScreenTitleMenu]
ChoiceJ="screen,ScreenJukeboxMenu;text,Juke'm box"

The issue here is how the text for Juke'm box contains a quote that is never closed. This causes the game to hang because it's expected to find an ending but never does. To fix this, just replace Juke'm box to Jukebox.
There's also the fact that Juke'm box isn't even a registered string in the language files, so even if it worked, it would complain that the string is missing.


Regenerator runtime in lib/dist

Hello and thanks for your work on this library!
I noticed that there are some generator functions in the src that are being compiled to use the regenerator runtime within lib and dist:
https://github.com/yelouafi/redux-saga/blob/master/src/internal/proc.js#L377-L382
else {
  _iterator = (error ?
      function*() { throw error }
    : function*() { return (yield result) }
  )()
}

https://github.com/yelouafi/redux-saga/blob/master/dist/redux-saga.js#L857-L886
else {
    _iterator = (error ? regeneratorRuntime.mark(function _callee() {
        return regeneratorRuntime.wrap(function _callee$(_context) {
            while (1) {
                switch (_context.prev = _context.next) {
                    case 0:
                        throw error;

                    case 1:
                        case 'end':
                        return _context.stop();
                }
            }
        }, _callee, this);
    }) : regeneratorRuntime.mark(function _callee2() {
        return regeneratorRuntime.wrap(function _callee2$(_context2) {
            while (1) {
                switch (_context2.prev = _context2.next) {
                    case 0:
                        _context2.next = 2;
                    return result;

                    case 2:
                        return _context2.abrupt('return', _context2.sent);

                    case 3:
                        case 'end':
                        return _context2.stop();
                }
            }
        }, _callee2, this);
    }))();
}

I don't think this was intentional because it basically requires the end user to have the regenerator runtime library in place.  I think some form of this issue has been in place for a while in the library and I've been using it without issue, so it seems like an edge case.  But just for reference, here's a quick fiddle that shows the failure case:  https://jsfiddle.net/npbee/bbz17aak/1/
There are a couple of different ways to solve this and I'm not sure which you think would be the best way.  I'm happy to help in any way I can!

@npbee Thanks for pointing to this. it was an inattention from my part


Destroying Movieclip not working properly?

HI I am creating an instance with new PIXI.extras.MovieClip.fromFrames(frameTextures);
And after i am done with the animation I am destroying the Movieclip with instance.destroy(true, true); to remove the texture and basetexture.
But in renderer._managedTextures the textures are not destroyed and keep adding up.
Right now i am destroying the _managedTextures with renderer.destroyTexture(renderer._managedTextures[i]);

Thanks for sharing! If you could provide a fiddle for us to debug that would be ace 👍

Closing this since it should be fixed in v4.


Separate the library and the toolchain

In order to allow easier updates when using an alternative toolchain, for example, using Linux with the gendev script, I think it would be much more convenient if the SGDK libraries could be in their own repository, separate from the precompiled toolchain binaries. This way it would be possible to integrate SGDK as a sub-module in another repository and keep it synced with upstream.
The current behavior of including windows binaries is nice for Windows users, and could be preserved by providing an SGDK-windows repository that brings in the parent SGDK repository as a submodule, alongside the precompiled tools

Also a Gendev user here and I think this would be a good idea too.

I agree. Even when using Windows, sometimes you might not want to use the compiler included in SGDK (I use other with newlib support).

I am willing like to work in this direction and submit pull-requests, but I do not know if @Stephane-D would be interested in merging these kind of changes. Any words about it?

I am developing on ubuntu (22.10) and use the default m68k compiler/toolchain from the ubuntu repository (currently version 11.3.0):
sudo apt install gcc-m68k-linux-gnu g++-m68k-linux-gnu
For the build I installed the package of gendev bundling SGDK and another (in my opinion outdated) m68k toolchain (omitting in favor of ubuntu one).
The SGDK provided Makefile for building roms just needs to change the toolchain part:
BIN := /usr/bin/m68k-linux-gnu-

CC := $(BIN)gcc
CPP := $(BIN)g++
LD := $(BIN)ld
NM := $(BIN)nm
OBJCPY := $(BIN)objcopy


LOG taking forever to open: option to have smaller log?

I think my log has many entries, after 10 minutes I still see
"Please wait while fetching data..."
Would it be possible to limit the amount of log, also to speed it up?

You are right, logging logic needs refactoring.


The method UseLog4Net is not available

Hello!
I'm trying use Log4Net in my app, but when I try set it up as the documentation, the method UseLog4Net is not available.
What am I doing wrong?
Version: 3.3.1
My code:
using log4net.Config;
using Topshelf;

namespace MyApp
{
    class Program
    {
        static void Main(string[] args)
        {
            XmlConfigurator.Configure();

            HostFactory.Run(t =>
            {
                //Method below is not available
                //t.UseLog4Net();
                t.Service<MyService>(s =>
                {
                    s.ConstructUsing(name => new Service());
                    s.WhenStarted(tc => tc.Start());
                    s.WhenStopped(tc => tc.Stop());
                    s.WhenShutdown(tc => tc.Shutdown());
                });

                t.RunAsNetworkService();

                t.SetDescription("Consume the informations.");
                t.SetDisplayName("Consumer");
                t.SetServiceName("Consumer");
            });
        }
    }
}

Thank you!

Did you include the matching logging package, Topshelf.Log4net?

Hello!
No, I didn't. Now it works!
Thank you so much!


[WIP] E2E flow with custom ipsec ports

After #157 was merged we should start testing with non-standard ipsec ports.
This PR must be merged after submariner-io/submariner-charts#7.
The CI should pass only after the helm charts changes are merged.
Original Issue: https://github.com/submariner-io/submariner-charts/issues/6

The testing matrix will keep complicating. We will need to figure out how to handle those things.
For example, in the future we wanted to setup udp port numbers via the labels of nodes (it would be in addition to this which changes the system default). I think that will be a great opportunity to manage those labels from the E2E tests and ensure that the port changes but connectivity does not break.

Ok related changes are merged, this was ok for checking on travis.


more file formats for IStreamQuadIterator

resolve #164

was a bug in serd, link to the issue: https://github.com/drobilla/serd/issues/42


NoEmptyPhpdocFixer - do not leave empty line after docs removal

As suggested here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3574#issuecomment-373484579
Tests should fail now.
I can fix/complete tests, after initial review

we strongly follow tests driven development, hard to review without tests ;)

Nah. Just obvious fails on 10 lines :)

@TomasVotruba  test results are in ;)

@TomasVotruba did you find some time for this project to wrap this up? If not, no problem at all of course :)

Thanks for the ping :)
Nono, I have no motivation since working with tests on PHP CS Fixer is very confusing for me and I use own fixer for this.

OK, I gave it a try but I'm still no fan of copy pasting the whole remove empty line logic into other rules because it becomes a mess. Anyway I drop the test cases here so I work on this later maybe;
public function provideFixCases()
    {
        return [
            [
                '<?php
                    /** a */

                    /**
                     * test
                     */

                     /** *test* */
                ',
                '<?php
                    /**  *//** a *//**  */

                    /**
                    */

                    /**
                     *
                     */

                    /** ***
                     *
                     ******/

                    /**
**/
                    /**
                     * test
                     */

                     /** *test* */
                ',
            ],
            [
                '<?php #'
            ],
            [
                '<?php //'
            ],
            [
                '<?php /* */'
            ],
            [
                '<?php
                echo 1;
                echo 2;
                ',
                '<?php
                echo 1;
                /** */
                echo 2;
                ',
            ],
            [
                '<?php
                echo 3;

                echo 4;
                ',
                '<?php
                echo 3;

                /** */

                echo 4;
                ',
            ],
            [
                '<?php
echo 5;
echo 6;
                ',
                '<?php
echo 5;
/**  */
echo 6;
                ',
            ],
            [
                '<?php
echo 7; // 1  '.'
echo 8; // 2  '.'
',
                '<?php
echo 7; // 1  '.'
/**  */
echo 8; // 2  '.'
',
            ],
            [
                '<?php echo 9;  echo 10;',
                '<?php echo 9; /**  */ echo 10;',
            ],
            [
                '<?php echo 11;echo 12;',
                '<?php echo 11;/**  */echo 12;',
            ],
            [
                '<?php
echo 13; // 1
echo 14; // 2
',
                '<?php
echo 13; // 1
/**  */echo 14; // 2
',
            ],
            [
                '<?php
echo 131; // 1
 echo 141; // 2
',
                '<?php
echo 131; // 1
/**  */ echo 141; // 2
',
            ],
            [
                '<?php
                echo 101;
                echo 201;',
                '<?php
                echo 101;
                /**  */
                echo 201;',
            ],
            [
                '<?php
                echo 102;
                echo 202;
                ',
                '<?php
                echo 102;
                /**  *//**  *//**  *//**  */
                echo 202;
                ',
            ],
            [
                '<?php
                echo 1021;
                echo 2021;
                ',
                '<?php
                echo 1021;
            /**  *//**  *//**  *//**  */
/**  *//**  *//**  *//**  */
                        /**  *//**  *//**  *//**  */
                echo 2021;
                ',
            ],
            [
                '<?php
                echo 1022;
                ',
                '<?php
                echo 1022;
                /**  *//**  *//**  *//**  */',
            ],
            [
                '<?php
                echo "open tag fun 1";',
                '<?php
                /**  */
                echo "open tag fun 1";',
            ],
            [
                '<?php
                '.'
                '.'
                echo "open tag fun 1a";',
                '<?php
                /**  */
                '.'
                '.'
                echo "open tag fun 1a";',
            ],
            [
                '<?php
                echo "open tag fun 1b";',
                '<?php
                /**  */echo "open tag fun 1b";',
            ],
            [
                '<?php
                 echo "open tag fun 1c";',
                '<?php
                /**  */ echo "open tag fun 1c";',
            ],
            [
                '<?php '.'
                echo "open tag fun 2";',
                '<?php /**  */
                echo "open tag fun 2";',
            ],
            [
                '<?php
echo "open tag fun 2a";',
                '<?php
/**  */
echo "open tag fun 2a";',
            ],
        ];
    }

Why not push it to this branch so someone else could build on it?

TBH I don't have the time to worry about multiple-user-PR's, so if I fixed it I prefer doing it on a new branch

I see

closing in favor of https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3961 and because the author of this PR stated to have no intentions to finish this PR

Of source, awesome :+1:  Thanks for continuing this

thanks man, hope we'll see the processed and merged in :D


Writing model output to FDB (GRIB)

Short Description of the issue
For DestinE, data needs / should to be written to FDB to leverage DestinE's federated data management.
FDB requires that the data compliant with the WMO standard.
Here we discuss the requirements to do so and whether or not this is within scope for interTwin.

Currently our flood map output is netcdf format. It should be possible to write this in grib format instead, but we'd need to know what it means for our data to be WMO compliant

FDB is also able to work with netcdf directly with some tuning of the metadata in the netcdf, this may be a solution.
As mentioned converting youre netcdf files to grib is the most straightforward solution however this is quite difficult as grib has strict metadata and format requirements. There are a few tools out there to do this like cdo ( https://code.mpimet.mpg.de/projects/cdo) and YAC (https://dkrz-sw.gitlab-pages.dkrz.de/yac/) but these take quite a bit of work and knowledge of the netcdf files and grib to get working.
I'm currently trying to find out if this has been done internally in an easier way as this problem has come up in a few contexts in other use cases also.

notes from meeting with THomas

FDB can work with a lot of different files in the backend
netcdf files are a bit too liberal in terms of metadata, fdb can interpret grib better
YAC can write directly to fdb, this could become a generic way to write to fdb

action

explore using YAC to write data to fdb
collaborate with DT-GEO and GLORI who also need this functionality


Change input_for label on gene page

Here it might be nicer to have
"transcribed by"
and "ubiquitinated by"
if we can.

I think Mark does some stuff t change the display labels in the existing code. Eventually this should be a curator maintained config file like Canto.

@mah11  is there a config file for this.
Is this the same  question I always ask?
Or is that about a different config file?
If this is not configurable at present add pls add "discuss".

The configuration for extensions and labels is here:
pombe-embl/supporting_files/chado-json-config.yaml
When should it be "transcribed by" and when should it be "ubiquitinated by"?

Can anyone help here?
We just need to change the config file to allow more detailed display labels?

That's correct. I can do the config file changes if you put more specifics here about what display text  you want to appear for which GO terms in both "forward" and "target of" directions. (That's essentially what Kim was asking for with "When should it be "transcribed by" and when should it be "ubiquitinated by"?".)

I guess the info is here (with different display labels as appropriate....?)
/Users/val/Desktop/pombe-embl/supporting_files/annotation_ex_config
except  at present  "ubiquitinated by" would be plain "modified by" because I haven't configured that deeply yet in this branch...
Ideally we would do this in a way that we didn't  need to maintain 2 config files?

Right now there are two config files/sets of files because one is for Canto and the other is for the web page display. Kim will have to comment on whether it's code-riffically* feasible and sensible to merge them.

pombe-embl/supporting_files/annotation_ex_config

Only the "forward" direction is in the files in that directory, because Canto has no need to display the reciprocal ("target of") text. Reciprocal display text is in the file Kim indicated - pombe-embl/supporting_files/chado-json-config.yaml
*yeah, I just made that word up

hmm, of course, it probably makes sense to have 2 files then....
pinta to keep them aligned but not beyond us.
Let's see what Kim says...

The admin vs. user distinction is also only relevant to Canto.

Let's see what Kim says...

I think we can merge them but I'd like to put it off.  In the Canto file there are domain restrictions like "FYPO:0001985-FYPO:0005448&FYPO:0005449" which make it fiddly.

No problem to wait. We will keep separate files for now.
In the whole scheme of things we have far less duplication of anything, than anyone, for anything ;)

so for example if the input term is
DNA-binding transcription activator activity (GO:0001216)
or one of its descendants the relation would be "transcribed by"
If
DNA-binding transcription activator activity (GO:0001216)
or one of its descendants the relation would be "ubiquitinated by"
protein kinase activity (GO:0004672)
or one of its descendants the relation would be "phosphorylated by"
phosphoprotein phosphatase activity (GO:0004721)
or one of its descendants the relation would be "dephosphorylated by"
This would  cover a lot and be enough to get it working.
Then we can  extend on an ad-hoc basis. Is this what you needed? or do you need more?

@ValWood

DNA-binding transcription activator activity (GO:0001216)
or one of its descendants the relation would be "ubiquitinated by"

what's the correct GO term for this one?

@kimrutherford question:
Right now the website config has this for "catalytic activity":
{
  "rel_name": "has_input",
  "if_descendant_of": "GO:0003824",
  "display_name": "has substrate",
  "reciprocal_display": "substrate of"
},

Val has some more specific display suggestions for some, but not (yet) all, descendants of GO:0003824. What will happen if I add them to the config? E.g. will a phosphatase substrate get both "substrate of (kinase)" and "dephosphorylated by (kinase)" or will it be clever enough not to include the less specific one?
Do we (read: you, lucky ol' you) need to use the "FYPO:0001985-FYPO:0005448&FYPO:0005449"-style syntax for the website config too?
Happy to chat if talking you through it will help.

what's the correct GO term for this one?
corrected above

What will happen if I add them to the config?

It currently uses the first configuration that matches.  So if you put the more specific ones first it should work.

It currently uses the first configuration that matches. So if you put the more specific ones first it should work.

Cool. I've added a bunch of new entries, so I'll close this. If I've botched it, fix or reopen for me; for new entries open a new ticket.

DNA-binding transcription activator activity (GO:0001216)
or one of its descendants the relation would be "transcribed by"

Well, no, actually, it's always transcribed by RNA polymerase, so I used "transcription activated by" for this one.


Install without composer

Hi there, i would love to test your plugin out but have a shared host without composer. Is there any way on how to get the plugin by simply uploading a zip or extracted zip? Thanks a lot!

I asked for help on the Winter CMS Discord channel and there i also got the info that either i use composer or upload the plugin and then make an artisan php refresh.
It would be fantastic if you could provide this plugin through the backend for noobs like me. Thanks in advance.