Wrap up CHANGELOG for releasing 3.5.3

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #1069

@CocoaLumberjack/collaborators
These changelogs need to be merged before we release new version, I think. Can you have a look?

Codecov Report

Merging #1070 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1070     +/-   ##
=========================================
+ Coverage   38.25%   38.35%   +0.1%
=========================================
  Files          27       27
  Lines        3916     3916
=========================================
+ Hits         1498     1502      +4
+ Misses       2418     2414      -4

Impacted Files
Coverage Δ

Classes/DDFileLogger.m
58.66% <0%> (-0.14%)
:arrow_down:

Tests/Tests/DDAtomicCounterTests.m
100% <0%> (+1.85%)
:arrow_up:

Classes/DDOSLogger.m
63.46% <0%> (+7.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8aefe4...c3b2594. Read the comment docs.

@ffried Thanks many times🙂


Run Tensorflow model on GPU

I was trying to run the example-tensorflow-mnist on GPU.
To achieve this, I edited the ServingRuntime  object adding nvidia.com/gpu: 1 to the spec.containers.resources.limits and  spec.containers.resources.requests sections of the tritonserver container and the needed tolerations.
Once done that, I noticed that the example-tensorflow-mnist predictor always failed to be loaded.
This is the error I'm getting from the Predictor:
UNAVAILABLE: Failed to load Model due to Triton runtime error: rpc error: code = Unavailable desc = error reading from server: EOF
Before setting the nvidia.com/gpu: 1 I was able to run an inference on example-tensorflow-mnist.
My goal is to load with success the model and then run an inference using the GPU.
Thanks in advance.

@andreapairon from what you described it sounds like Triton may not be running properly in the GPU case, and possibly restarted. Could you check whether the triton container in any of the pods restarted, and also look at the logs from that container for clues?

@njhill unfortunately, at the moment, I'm not able to assign any predictor to any runtime due to the following error from the modelmesh-controller:
{"level":"info","ts":1642066059.726149,"logger":"controllers.ServingRuntime","msg":"No runtime found to support predictor","name":"example-mnist-predictor","source":"Predictor"}
I tried to uninstall and reinstall ModelMesh a couple of times and to follow the quickstart installation guide, but the above error comes up every time :(
All the needed pods and serving runtimes are deployed:

Seems strange because yesterday always worked fine.
Any ideas?

@andreapairon changing the pod/container config for GPU should not have affected the logic to match predictors with runtimes. Really the next step in diagnosis is inspecting the triton runtime Deployment/Pods - even before checking the logs just verifying that the pod and containers are running and in ready state, and not restarting unexpectedly. And even if you can't provide the raw logs, maybe you can inspect them yourself for clues. It should be straightforward to get them using kubectl logs -c triton <podname> (if the container has restarted also try with --previous=true arg).

Log update:
the triton logs (before the restart) seems really ok:

the triton-adapter downloads the needed object (.pbtxt and .pt files) but then crashes due to an error:
"error": "rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial tcp [::1]:8001: connect: connection refused\""

@andreapairon I'm still not completely sure what's going on but my guess based on all the evidence above is that this is the significant part:

if I start with the GPU config (without Predictors created earlier) the triton pods are not created.

My guess is that when you got Triton to start loading the pod, it was actually the CPU configured version of it, and the loading failed because the pods were torn down due to the GPU reconfiguration. The errors shown above shouldn't have caused the adapter container to crash - probably it was killed but slightly after the triton container was killed, latter could explain the above observed errors (and you seem to imply that saying "before the restart").
To help get to the bottom of this, could you check the state of the triton Deployment assuming it exists but has no running pods. If you kubectl describe it there should be some clues in the status/events at the bottom - you may need to follow the referenced replicasets and describe those too to see relevant messages.
And/or it would be useful to get the log of the modelmesh-serving controller (different deployment/pod) while all of this is going on. This is what translates the ServingRuntime to a Deployment and so may contain some relevant errors.

This issue has been stale for two years and much of the code has changed since. Feel free to reopen if you can still reproduce this issue in the latest version of ModelMesh-Serving v0.11.2.


How to change the color of DICOM image in the form of RGB selector

Hello, I want to change the color of DICOM image in the form of RGB selector. Is there any way to use it
thank

I tried to use LUT, but did not find the detailed API, do not know how to use
Can you give me a hint, thank you

Is there any way to use it


 and asks me to enter /mv confirm to enter the world, so it becomes Very troublesome, is there any solution?
Steps to reproduce

Enter /mvtp{world}
The plug-in prompts "world unsafe" and requires input /mvconfirm to enter the world

Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

/mvconfirm is intended to exist, and the confirmation that you're seeing is expected for worlds with an unsafe spawn.
This is not a bug.
A feature request has been opened here that will let you bypass the confirm option and is roadmapped to be implemented with MV5.

Closing, as this is currently a non-issue and the new feature should be tracked in #2764


JSON generation fails for Llama-2-7b-chat-hf

Describe the issue as clearly as possible:
When running vLLM serve with outlines version 0.0.32 and Llama-2-7b-chat-hf the output does not create a valid json output. The serve.py I am using is
# Copyright 2023 the vLLM developers

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at

#     http://www.apache.org/licenses/LICENSE-2.0

# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import argparse
import json
from typing import AsyncGenerator

import uvicorn
from fastapi import FastAPI, Request
from fastapi.responses import JSONResponse, Response, StreamingResponse
from vllm.engine.arg_utils import AsyncEngineArgs
from vllm.engine.async_llm_engine import AsyncLLMEngine
from vllm.sampling_params import SamplingParams
from vllm.utils import random_uuid

from .vllm import JSONLogitsProcessor, RegexLogitsProcessor

TIMEOUT_KEEP_ALIVE = 5  # seconds.
TIMEOUT_TO_PREVENT_DEADLOCK = 1  # seconds.
app = FastAPI()
engine = None

@app.get("/health")
async def health() -> Response:
    """Health check."""
    return Response(status_code=200)

@app.post("/generate")
async def generate(request: Request) -> Response:
    """Generate completion for the request.

    The request should be a JSON object with the following fields:
    - prompt: the prompt to use for the generation.
    - schema: the JSON schema to use for the generation (if regex is not provided).
    - regex: the regex to use for the generation (if schema is not provided).
    - stream: whether to stream the results or not.
    - other fields: the sampling parameters (See `SamplingParams` for details).
    """
    assert engine is not None

    request_dict = await request.json()
    prompt = request_dict.pop("prompt")
    stream = request_dict.pop("stream", False)

    json_schema = request_dict.pop("schema", None)
    regex_string = request_dict.pop("regex", None)
    if json_schema is not None:
        logits_processors = [JSONLogitsProcessor(json_schema, engine.engine)]
    elif regex_string is not None:
        logits_processors = [RegexLogitsProcessor(regex_string, engine.engine)]
    else:
        logits_processors = []

    sampling_params = SamplingParams(
        **request_dict, logits_processors=logits_processors  # type: ignore
    )
    request_id = random_uuid()

    results_generator = engine.generate(prompt, sampling_params, request_id)  # type: ignore

    # Streaming case
    async def stream_results() -> AsyncGenerator[bytes, None]:
        async for request_output in results_generator:
            prompt = request_output.prompt
            text_outputs = [prompt + output.text for output in request_output.outputs]
            ret = {"text": text_outputs}
            yield (json.dumps(ret) + "\0").encode("utf-8")

    if stream:
        return StreamingResponse(stream_results())

    # Non-streaming case
    final_output = None
    async for request_output in results_generator:
        if await request.is_disconnected():
            # Abort the request if the client disconnects.
            await engine.abort(request_id)  # type: ignore
            return Response(status_code=499)
        final_output = request_output

    assert final_output is not None
    ret = {"text": final_output.outputs[0].text}
    return JSONResponse(ret)

if __name__ == "__main__":
    parser = argparse.ArgumentParser()
    parser.add_argument("--host", type=str, default=None)
    parser.add_argument("--port", type=int, default=8000)
    parser.add_argument("--ssl-keyfile", type=str, default=None)
    parser.add_argument("--ssl-certfile", type=str, default=None)
    parser = AsyncEngineArgs.add_cli_args(parser)
    args = parser.parse_args()

    # Adds the `engine_use_ray`,  `disable_log_requests` and `max_log_len`
    # arguments
    engine_args: AsyncEngineArgs = AsyncEngineArgs.from_cli_args(args)  # type: ignore

    # Sets default for the model (`facebook/opt-125m`)
    engine = AsyncLLMEngine.from_engine_args(engine_args)

    uvicorn.run(
        app,
        host=args.host,
        port=args.port,
        log_level="debug",
        timeout_keep_alive=TIMEOUT_KEEP_ALIVE,
        ssl_keyfile=args.ssl_keyfile,
        ssl_certfile=args.ssl_certfile,
    )

Steps/code to reproduce the bug:
curl localhost:10001/generate -H "content-type: application/json" -d '{
  "prompt": "toyota corolla black",
  "max_tokens": 128,
  "schema": {
    "properties": {
      "color": {
        "title": "Color",
        "type": "string"
      },
      "maker": {
        "title": "Maker",
        "type": "string"
      }
    },
    "required": [
      "color",
      "maker"
    ],
    "title": "Car",
    "type": "object"
  }
}'

Expected result:
{"text":"{\n            \"color\": \"black\",\n            \"maker\": \"Toyota\"\n          }"}

Error message:
{"text":"{\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n"}

Outlines/Python version information:
Version information

```
python3 -m pip show outlines
Name: outlines
Version: 0.0.32
Summary: Probabilistic Generative Model Programming
Home-page:
Author: Outlines Developers
Author-email:
```

Context for the issue:
I would like to know if this is a known issue for Llama-2-7b-chat-hf? thanks!

It's a known problem with small models. By default, Outlines lets the model choose the number of line breaks and white spaces (following the JSON standard). In outlines.generate.json you can play with the white space pattern for the JSON, usually passing whitespace_pattern="" works better.

Interesting @rlouf I updated the above JSONLogitsProcessor constructor with the whitespace_pattern and it seems to work
logits_processors = [JSONLogitsProcessor(json_schema, engine.engine, whitespace_pattern="")]

Produces
{"text":"{\"color\":\">Black•Rust\",\"maker\":\">Toyota\"}"}

Do you know is it generally safe to define this whitespace-pattern for all models? or just llama ones?

@vegaluisjose this should be fine for any model which is capable of generating json without whitespace separation, which I believe should be almost all of them. IMHO,  [ \n\t]? is slightly safer though.
@rlouf We should consider making the whitespace_pattern default to [ \n\t]?.

Do you know is it generally safe to define this whitespace-pattern for all models? or just llama ones?

My honest answer is I don't know, for now it's all empirical. When you guide generation, you force the sequences to be sampled from a subspace of all the sequences that can possibly be sampled given the prompt. When you set a whitespace pattern, you are further reducing the size of that subspace. It might be that this overall gives better results because it's the "right" subset, but hard to tell without evaluation.
Note that all of this is also conditional on the type of sampling algorithm that you use (greedy, multinomial, beam search, etc.), so it might also be that what works with one algorithm, actually doesn't with another one.
Structured generation is more like a new line of research than a simple feature :)


No difference between no security requirement and empty security requirement on Operations

Describe the bug
There is no way of telling 'empty' from 'not defined' security requirement objects, during deserialization.
I.e no way of distinguishing the 2 different security requirement objects
paths:
  /pets:
    post:
      responses:
        '201':
          description: Created
      security: []
    get:
      responses:
        '200':
          description: A paged array of pets

Why is this important?
The specification states the following for Operation Security

To remove a top-level security declaration, an empty array can be used.

i.e security: []
however it is expected that if security is not defined on an operation level
get:
  responses:
    '200':
      description: A paged array of pets

That the global security is applied, defined on the top level document object.
in the following spec
openapi: '3.0.0'
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
security:
  - Authorization:
    - readwrite
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /pets:
    post:
      responses:
        '201':
          description: Created
      security: []
    get:
      responses:
        '200':
          description: A paged array of pets
components:
  securitySchemes:
    Authorization:
      type: http
      scheme: bearer
      bearerFormat: JWT

post deserialization, it is impossible to determine which security is actually applied between the 2 operations, as both security requirements are deserialized into the same value
public IList<OpenApiSecurityRequirement> Security { get; set; } = new List<OpenApiSecurityRequirement>();
which ends up being empty in both cases.
The reason for this is most likely that during reading a new OpenApiSecurityRequirement() and as this is a dictionary, there is no way of specifying a null key, so to speak.
The problem being that the semantics between the 2 operations are different in the spec.
To Reproduce
Deserialize the above spec.
Expected behavior
To have a way of differentiating the 2 scenarios. (feasibly one would be empty, the other would be null.
Screenshots/Code Snippets
var input = @"openapi: '3.0.0'
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
security:
  - Authorization:
    - readwrite
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /pets:
    post:
      responses:
        '201':
          description: Created
      security: []
    get:
      responses:
        '200':
          description: A paged array of pets
components:
  securitySchemes:
    Authorization:
      type: http
      scheme: bearer
      bearerFormat: JWT";
var document = new OpenApiStringReader().Read(input, out var diagnostics);

Thank you for bringing this to our attention.  We have two options here to solve this problem. We can either add a new AnonymousAccess property to the OpenApiOperation object to allow users to explicitly state they want to override the security with no security.  Or the the option is to stop defaulting the Security property to an empty list and treat a non-null value as an indication that they want to override the security.

// Option 1 - Breaking change
var operation = new OpenApiOperation();
operation.Security = null;  // Default value

// Set Anonymous access
operation.Security = new List<OpenApiSecurityRequirement>() [];

// Option 2 - Non breaking change
var operation = new OpenApiOperation();
operation.Security = new List<OpenApiSecurityRequirement>() [];  // Default value
operation.AnonymousAccess = false;  // Anonymous access default

// Set Anonymous access
operation.AnonymousAccess = true;

We can do Option 2 in the current major version of OpenAPI.NET because it is not breaking, however, if we go with Option 1 we will need to wait until the v2 release.

Personally, I think option 2 is more in line with what is expected from a dotnet point of view (Empty list vs null list).

We specifically found empty vs we found nothing. so to speak.

Option 2 does have the added effect of it, then being the ONLY dictionary, that isn't newed up automatically - so it 'might' technically be a breaking change for everyone using the existing behaviour.
So waiting for v2 might be the safest bet, in any case.

I think option 1 and 2 have been flipped around, from the description to the examples: Option 1 adding AnonymousAccess, Option 2 defaulting to null.
Defaulting to null is the breaking change, so you both seem in agreement to wait for a v2 with it.
Null vs. default is similar to how it would be treated in F# (to my understanding) with option, where Some [] is the explicit override, and None is the lack of the property. The None tends to be mapped from null. I'd feel more comfortable with this option 2, explicit null, rather than a new property whose name I can't see mapping to the OpenAPI spec itself.

Hello,
Any update on this issue ?
Is there a known workaround other than not using global security specifications ?
Thanks


fix(common): fix catching error on PlatformMulterMiddleware

Closes: #1809

:tada: This PR is included in version 6.107.2 :tada:
The release is available on:

v6.107.2
GitHub release

Your semantic-release bot :package::rocket:


Heatmap/contact projection error

Hello,
I was trying to visualise the contact projection (heatmap)  and got this error (below ) could you help me please ?
pl.show_contact_projection(T, bf=js[metrics[0]], cmap="Spectral_r")
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_3340230/3395143762.py in
1 # visualize the first metric
----> 2 pl.show_contact_projection(T, bf=js[metrics[0]], cmap="Spectral_r")
/softwares/Anaconda3/2023.07/envs/prolint/lib/python3.7/site-packages/prolintpy/vis/show_contact_projection.py in show_contact_projection(t, bf, protein, residue_list, ngl_repr, cmap)
69     else:
70         if len(df.resSeq.unique()) != len(bf):
---> 71             raise TypeError ('When projecting only a subset of residues provide a list of tuples: [(residue_id, value), ...]')
72         for atom in resseq:
73             atomic_bfactors.append(bf[atom-1])
TypeError: When projecting only a subset of residues provide a list of tuples: [(residue_id, value), ...]
i used the data.json file and P454_BB.pdb (which is the file of 2 peptides ) from the output

Hi Amiel, sorry for the late response. Please provide me with the .pdb file you are using so I can try it on my local installation and find out where the issue is. I am looking forward to solving this for you as soon as possible.

Hello Daniel,
Thank you for your reply.
Here is the initial PDB file for the peptide, the membrane was generated with insane.
Take the time you need.
Amiel

De : Daniel Pastor Ramirez @.>
Envoyé : mercredi 11 octobre 2023 04:10
À : ProLint/prolint2 @.>
Cc : amiel-ab @.>; Author @.>
Objet : Re: [ProLint/prolint2] Heatmap/contact projection error (Issue #82)
Hi Amiel, sorry for the late response. Please provide me with the .pdb file you are using so I can try it on my local installation and find out where the issue is. I am looking forward to solving this for you as soon as possible.
—
Reply to this email directly, view it on GitHubhttps://github.com/ProLint/prolint2/issues/82#issuecomment-1756736188, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2IDO5ZZNLENJLG23M4QVTTX6YLZ5AVCNFSM6AAAAAA5SI62ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWG4ZTMMJYHA.
You are receiving this because you authored the thread.Message ID: @.***>


fix: Fix error in R test path

/azp run

Codecov Report

Merging #1281 (0858afc) into master (c65423c) will decrease coverage by 12.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1281       +/-   ##
===========================================
- Coverage   83.25%   71.05%   -12.21%
===========================================
  Files         300      248       -52
  Lines       13720    12000     -1720
  Branches      670      670
===========================================
- Hits        11423     8526     -2897
- Misses       2297     3474     +1177

Impacted Files
Coverage Δ

...la/org/apache/spark/ml/param/TypedArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...rk/sql/types/injections/OptimizedCKNNFitting.scala
0.00% <0.00%> (-88.24%)
:arrow_down:

...soft/azure/synapse/ml/cognitive/AudioStreams.scala
0.00% <0.00%> (-87.88%)
:arrow_down:

...a/com/microsoft/azure/synapse/ml/nn/BallTree.scala
0.00% <0.00%> (-87.62%)
:arrow_down:

...ft/azure/synapse/ml/cognitive/AzureSearchAPI.scala
2.59% <0.00%> (-87.02%)
:arrow_down:

...oft/azure/synapse/ml/nn/BoundedPriorityQueue.scala
0.00% <0.00%> (-86.67%)
:arrow_down:

...osoft/azure/synapse/ml/cognitive/AzureSearch.scala
7.19% <0.00%> (-80.58%)
:arrow_down:

...ynapse/ml/train/ComputePerInstanceStatistics.scala
11.11% <0.00%> (-77.78%)
:arrow_down:

...e/synapse/ml/cognitive/FormRecognizerSchemas.scala
7.69% <0.00%> (-76.93%)
:arrow_down:

...rosoft/azure/synapse/ml/train/TrainRegressor.scala
10.71% <0.00%> (-76.79%)
:arrow_down:

... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65423c...0858afc.


Immer patches for Array are correct, yet inefficient. Suggesting a new algorithm for optimized patches

I am thinking as offering it as a pull request - let me know what you think
🚀 Feature Proposal
Today when computing a patch on arrays, immer compares objects by index, which results in all array change in case of unshift or splice usage. An example is the following test taken from immer testing -
https://github.com/immerjs/immer/blob/main/__tests__/patch.js#L543-L559
describe("arrays - multiple prepend", () => {
	runPatchTest(
		{x: [1, 2, 3]},
		d => {
			d.x.unshift(4)
			d.x.unshift(5)
			// 4,5,1,2,3
		},
		[
			{op: "replace", path: ["x", 0], value: 5},
			{op: "replace", path: ["x", 1], value: 4},
			{op: "replace", path: ["x", 2], value: 1},
			{op: "add", path: ["x", 3], value: 2},
			{op: "add", path: ["x", 4], value: 3}
		]
	)
})

the expected result should be instead
		[
			{op: "add", path: ["x", 0], value: 5},
			{op: "add", path: ["x", 1], value: 4}
		]

Motivation
I am working on a new framework that also serializes patches, and the above is a performance issue.
Consider the above case - for an array of object, lets say an array of 100 objects with 10 attributes each, the current algorithm will generate 1000 patches, while my suggestion is to produce only 1 per added / removed object
Can this be solved in user-land code?
no
Example
See the example above.
Usage: immer -> serialize -> deserialize -> patched object
suggested algorithm
(pseudo code)
the problem with json diff is that given two arrays, without any additional knowledge, to figure out if an item was
pushed to the front, we have to do a === comparison between the array items, which is O(n^2) complexity.
for (let a = 0; a < A.length; a++) {
    for (let b = 0; b < A.length; b++) {
        if (A[a] === B[b])
            // compute the diff
    }
}

However, we can create an algorithm focused on small changes that has complexity O(n) with a cutoff.
The algorithm makes the assumption that small changes can be found fast and require small number of mutations to describe.
The cutoff is set at let limit = log(min(A.length, B.length)) and the algorithm has complexity O(limit^2) ~ O(n)
The algorithm -
let limit = log(min(A.length, B.length));
let a=0, b=0;
mainLoop: while (a < A.length && b < B.length) {
    if (A(a) === B(b)) {
        a += 1;
        b += 1
    }
    continue;
    for (let seekSize = 1; seekSize < limit; seekSize++) {
        for (let index = 1; index <= seekSize; index++) {
            if (A[a+index] === B[b+seekSize-index])
                // we have a match, the elements from A between (a..a+index) and replace them with the items from B between (b..b+seekSize-index)
            continue mainLoop;
        }
    }
    // revert to direct comparison of attributes json diff model (the standard model used by all other algorithms)
}

Update:
Reading the Immer source again, I can see that for objects there is the state.assigned_ member which marks which object properties have been updated or deleted.
I suggest to extend the idea for arrays to also include added and removed array items, those making the above algorithm redundant and making for a simpler solution.
What do you think?


Update README

bors r+

@torkleyy You can add @kvark as a reviewer by going to your repositories page, then to slide-rs/specs, then to Settings.

@notriddle Thanks!
@kvark Should work now. Please try again.

bors r+


Move code from lessons to notebooks

I've moved the code from lesson4.py and lesson5.py into Jupyter notebooks. Now, the pitch plots can be investigated directly on github.
I've updated the readme to link to each lesson notebook and allow to run them on binder without installation
I've added an environment.yml file for an easy installation of the dependencies using conda.
I've added a .gitignore file.

I haven't touched any code, therefore it should be okay to merge without any conflicts.

@seidlr one minor suggestion on Lesson6.ipynb:
You can use %matplotlib notebook (to render interactive plots) before cell 5. In this way, as Laurie does in his video, will be able to see the actual values of the Pitch Control surface as you move your cursor around the field.

@malo4 Sounds great. I tested it offline in my notebook and I get way too large plots. This might have to do with my setup. I also tested it on Google Colab and here the plots are not shown at all.
Thus, I will keep it this way for the moment even though visually inspecting the pitch control surface would, indeed, be very valuable.

@seidlr Aw, you are right. Seems that there's an issue w/ google colab and interactive plots.
As for the jupyter notebook, %matplotlib notebook used figure.dpi, so to get consistent sizes you'll need something like:
import matplotlib as mpl
mpl.rcParams['savefig.dpi'] = 80
mpl.rcParams['figure.dpi'] = 80
Hope this helps!


Add optional TOML configuration support

Adds support for TOML configuration files, in particular pyproject.toml inside a [tool.pylama] section.
This seemed like the least intrusive way to add support. Reuses the existing vendored inirama with a simple shim to parse TOML tables. The resulting objectis still just a inirama.Namespace so no usage changes are needed. All behind a toml extras for anyone who doesn't want to pull in the added dependency.
Needed a couple pylint config changes for tests to pass on current pylint version 2.14.4:

Disable W0012/unknown-option value
Disable C3001/unnecessary-lambda-assignment in core.py

@villainy The great PR! Thank you very match!


Climate toon

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
**Home Assistant release (`hass --version):**0.60
**Python release (python3 --version):**polymer 2.1.1
**Component/platform:**climate
**Description of problem:
Climate toon Updating to hassio is slow.
After rebooten on hassio everything works fine but  after a short time the sensors switches and tempreture doesn't sync with hassio
**Expected:
Sync works faster and better
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

Maybe this is related to https://github.com/home-assistant/home-assistant-polymer/issues/711 which might be fixed in next version by https://github.com/home-assistant/home-assistant-polymer/pull/745


Affiliation mappings translations not working

Critical Changes
Changes
Updates to Affiliation Mappings

We’ve fixed an issue that prevented the Primary Affiliation lookup field on Contact from being populated in languages other than English when translated field labels are in use. Now, instead of specifying a translated value in the Primary Affiliation field, specify the Field API name in the Primary Affiliation field to populate Primary Affiliations on Contact in English and one or more other languages.
For example, for a Spanish translation, leave the University Department Account Record Type as University Department and change the Contact Primary Affiliation field label to hed__Primary_Department__c (instead of the translated version that was previously used).

You can no longer create Affiliation Mappings in EDA Settings that use an existing Account Record Type name. Trying to do so returns a new error message.

Issues Closed
Closes #320
New Metadata
Deleted Metadata
Testing Notes
Steps to Reproduce the bug:

Create an Account with record type “Business organization” or any other record type.
Create a Contact.
From the Contact’s related list create an “Affiliated Account” choosing the account created on step 1 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is populated with the Account created on step 1 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for English language.
Now, change the language from Setup →  User → User record →  Change Language to Español OR
click your avatar on top right → Settings → Language and Time zone → Español.
Repeat the step 2 through 4.
Bug : The “Primary Business organization” in this case “Organización comercial principal” is not populated with the Account.

Steps to confirm the the bug is fixed:
Scenario 1: Mappings contain Field Labels (not api names) and Language is English

Make sure the mappings in “Affl Mappings” custom settings for the field “Primary Affl Field” has field labels (this is default mapping when EDA is created)
Make sure the language is English:
Change the language from user → User record →  Change Language to English OR
click your avatar on top right → Settings → Language and Time zone → English
Create an Account with record type “Business organization” or any other record type.
Create a Contact.
From the Contact’s related list create an “Affiliated Account” choosing the account created on step 1 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is populated with the Account created on step 1 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for English language.
Create an Account with record type same as step 1
Again, from the Contact’s related list create an “Affiliated Account” choosing the account created on step 6 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is updated with the Account created on step 6 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for English language.

Scenario 2: Mappings contain Field api names (not Labels) and Language is English

Make sure the mappings in “Affl Mappings” custom settings for the field “Primary Affl Field” has field API names
Make sure the language is English:
Change the language from user → User record →  Change Language to English OR
click your avatar on top right → Settings → Language and Time zone → English
Create an Account with record type “Business organization” or any other record type.
Create a Contact.
From the Contact’s related list create an “Affiliated Account” choosing the account created on step 1 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is populated with the Account created on step 1 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for English language.
Create an Account with record type same as step 1
Again, from the Contact’s related list create an “Affiliated Account” choosing the account created on step 6 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is updated with the Account created on step 6 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for English language.

Scenario 3: Mappings contain Field api names (not Labels) and Language is Not English

Make sure the mappings in “Affl Mappings” custom settings for the field “Primary Affl Field” has field API names
Make sure the language is not English:
Change the language from user → User record →  Change Language to Español OR
click your avatar on top right → Settings → Language and Time zone → Español
Create an Account with record type “Business organization” or any other record type.
Create a Contact.
From the Contact’s related list create an “Affiliated Account” choosing the account created on step 1 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is populated with the Account created on step 1 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for Spanish language.
Create an Account with record type same as step 1
Again, from the Contact’s related list create an “Affiliated Account” choosing the account created on step 6 for the field “Organization” and check the the box “Primary”.
Go to the Contact created on step2 and make sure “Primary Business organization” is updated with the Account created on step 6 (If not visible on the detail page it should be visible on edit page).
Confirmed working as expected for Spanish language.

Steps to test error message from Settings UI:

Go to EDA Settings → Affiliations → Affiliation Mappings
Copy an Account Record type name from Affiliation Mappings, say "Business Organization"
Paste it in the "New Affiliation Mappings" section in the field "Account Record Type*" and paste "Primary_Organization__c" in "Primary Affl Field*" field and hit "Add Mapping"
You should see a toast - error message at the top - "We can’t map this Affiliation because it references a record type that is already referenced by another Affiliation Mapping. If you want to add this mapping so the Affiliation is translated, click Edit to modify the existing mapping. Then, specify the field API name under Contact Primary Affl Field. Do not change the name specified for Account Record Type."
Close the error message
Now, Slightly update the text in the field "Account Record Type" to make it unique say, Business Organization2" with any value in "Primary Affl Field*" field and hit "Add Mapping"
The mapping should reflect in the above section "Affilaition Mappings" and the newly created record should also get added to the custom settings -> Affl Mappings -> Manage.

@ceiroa I have updated the code based on feedback and commented in the PR above with a question. Can you please give it another shot? Thanks.

Hey Carlos, I have made the changes based on feedback. Can you please give it another shot? Thanks.

Hi @skosgi1 ~ I tested the fix and it works great. The message is a lot more noticeable now, so good job on that. I do however have couple more comments:

It is possible to update the settings directly from the EDA Settings UI, so we should update the error message to reflect that (yeah, I didn't realize initially either - sorry about that)

I checked with Xinnan about the lines 83-88 in AFFL_MultiRecordType_TDTM and he sees the same spacing issue I see. Not a huge deal, but please take another look to see if it can be fixed. (Maybe edit the file with a different editor?)
It makes me queasy that you can sometimes save an entry with the same value for record type name that's already there. I know you mentioned this might be due to an extra space or something like that, but I don't see any extra spaces in the method that enters the defaults and I think it'd be good to take another look to understand why this might be happening.

Please let me know if you have any questions. Thank you!

Hi @ceiroa Quick update: I fixed 1 and 2 for above. Still trying to figure out if 3 is a problem or not.

Hi @skosgi1 ~ I tested the fix and it works great. The message is a lot more noticeable now, so good job on that. I do however have couple more comments:

It is possible to update the settings directly from the EDA Settings UI, so we should update the error message to reflect that (yeah, I didn't realize initially either - sorry about that)

I checked with Xinnan about the lines 83-88 in AFFL_MultiRecordType_TDTM and he sees the same spacing issue I see. Not a huge deal, but please take another look to see if it can be fixed. (Maybe edit the file with a different editor?)
It makes me queasy that you can sometimes save an entry with the same value for record type name that's already there. I know you mentioned this might be due to an extra space or something like that, but I don't see any extra spaces in the method that enters the defaults and I think it'd be good to take another look to understand why this might be happening.

Please let me know if you have any questions. Thank you!

Hi @ceiroa Quick update: I fixed 1 and 2 for above. Still trying to figure out if 3 is a problem or not.

Hi @ceiroa Figured out the issue! When we try to add a mapping from Settings UI, it inserts the record by taking  "Account Record Type" as the "Name" for the affl mapping's record . We would get a FIELD_INTEGRITY_EXCEPTION if there is a record with the same name in Affl Mappings. For example, if we try to insert a mapping with "Account Record Type" as "Business Organization" we would get the error as there is already a Affl Mappings record with the name "Business Organization". However, we wouldn't notice this error when we try to add "University Department" or "Sports Organization" because the names for these mappings are "Department" and "Sports" respectively. Hence these are not treated as duplicates and we don't see any errors for these two.

Tested / Passes QE.

I am using EDA in Spanish and have done some translations on EDA fields to fit my client's nomenclature.
I have created an Academic Program type account and it lets me create it correctly, but then when I go to edit it it always shows me the following error

I have also created 3 record types on contact.
It allows me to create the contact without problems, but when I then go to the related lists and try to create a new affiliation and check the main affiliation check, it shows me the same error again, without allowing me to create the affiliation with the previously created account.

This is how I have configured my affiliation assignments. I have copied in the main contact affiliation field the api name of the fields as you comment, but it still doesn't work.

Finally, I also have problems when I try to edit a contact that has already been created. It tells me that we cannot find the phone specified in Preferred Phone. Make sure you are entering the field label of an existing Custom Phone field.
I have all of the phone fields filled in and select from the picklist which is the preferred phone field and still get the error skipped.
I have noticed that when I change my user's language to English, all these problems I am talking about mysteriously disappear.
Can someone explain to me if all this is due to an EDA Bug or what I am configuring wrong?

I've already spent enough hours researching what the problem might be without any success.
Thanks in advance.

Hi Luis, as per the comment on the other closed issue. Please could you post this in the Power of Us Hub instead:
https://powerofus.force.com/s/group/0F980000000D6ujCAC/education-data-architecture


loop over each page in a thread to speed up generation

PR referencing #25
(untested here but only because I must have done something silly while trying to sort out the kids breakfast and check my work :))

One thing that I fear is what happens when spawning a new thread for each post affects very large sites (thousands of posts). I think there's a chance that the system runs out of threads though that would require a very large number of posts (my OS seems to set the maximum to 61028 by default).
A more realistic concern might be that with a large number of short tasks the overhead of context switching between threads becomes a bottleneck for performance. I think it would be a good idea to implement a setting to disable multithread usage if a user encounters a problem related to this. I'll open an issue for that.

Hmm, yeah, that's a good point. Might be worth pushingwith into a queue
and having a configurable number of threads to pull and then process the
pages. Could be getting a bit fancy at that point though :)
On Sat, 1 Apr 2017, 16:00 Juuso Mikkonen<EMAIL_ADDRESS>wrote:

One thing that I fear is what happens when spawning a new thread for each
post affects very large sites (thousands of posts). I think there's a
chance that the system runs out of threads though that would require a very
large number of posts (my OS seems to set the maximum to 61028 by default).
A more realistic concern might be that with a large number of short tasks
the overhead of context switching between threads becomes a bottleneck for
performance. I think it would be a good idea to implement a setting to
disable multithread usage if a user encounters a problem related to this.
I'll open an issue for that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/juusaw/amp-jekyll/pull/26#issuecomment-290925344, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA8G8Qv8ZOuKo6uyWw6o4fE9Q0BtQtHaks5rrmaXgaJpZM4MweFP
.

@juusaw Added an implementation that limits the number of threads. I've pulled the number of threads from an environment variable to try and keep things simple.


Implement Custom Java Installation

A minimum Java version may be specified in getdown.txt along with resource locations for alternative Java runtimes that may be downloaded (OS specific) to satisfy that requirement.
The Maven plugin should accept a minimum version configuration option (java_min_version) and location of runtime bundles and inject these into getdown.txt. The runtime bundles must be in JAR format, so in order to add value to using the Maven plugin, it should be capable of accepting of generating these jars from :-

The current Maven Java runtime. This would obviously only be for the current platform
File locations. Either an expanded runtime, a zip of a runtime, a jar of a runtime or a tgz of a runtime.
HTTP locations. A zip of a runtime, a jar of a runtime or a tgz of a runtime.

Other configuration options that should be exposed include :-

java_max_version
java_exact_version_required

See https://github.com/threerings/getdown/wiki/Getdown-Dot-Text for full details

Fixed in #10


Added confidence to tagging suggestions

This PR adds a confidence percentage to tagging suggestions.
Example response of the route:
{
    "suggestions": [
        {
            "value": "Victor",
            "confidence": 50
        },
        {
            "value": "Jeremy",
            "confidence": 16
        },
        {
            "value": "Bastien",
            "confidence": 12
        },
        {
            "value": "Romain",
            "confidence": 8
        },
        {
            "value": "Alexandre",
            "confidence": 4
        },
        {
            "value": "Clement",
            "confidence": 4
        },
        {
            "value": "Nicolas",
            "confidence": 4
        }
    ],
    "tagKey": "Owner"
}

Note: have to wait for the front-end to be ready in order to merge this because there are breaking changes in the request's format.


https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Admin_site

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

Hi i refer to this paragraph near the bottom of the page:

In this sentence, "The first option can be done by setting the extra attribute to 0", the 0 is hard to read as a normal font. Maybe can provide the 0 as an inline code font, or extra = 0?

I've set it to code font, and now it is easier to read. Thanks!


chore(masthead): add masthead-l1 web components codesandbox example

Description
This adds a Codesandbox example for masthead - L1.
Changelog
New

Codesandbox example for masthead - L1

Thank you for adding @kennylam !
The CDN version seems to be broken though:
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7246/masthead-l1/cdn.html


Use os_log APIs to log PowerShell events on OSX

This change replaces calls to syslog with os_log on OSX.  syslog calls on 10.12 was not producing log output and the functions do not report errors.
See https://github.com/PowerShell/PowerShell/issues/3766.
NOTE: PR https://github.com/PowerShell/PowerShell/pull/5144 depends on this PR.

@adityapatwardhan Would you mind taking a look at this?  My syslog PR is blocked until this gets into main and the nuget  package is published.
Thanks.


Crash in CompletionQueue.next()

What version of gRPC and what language are you using?
1.46.3
What operating system (Linux, Windows,...) and version?
Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
Gcc
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
We use the libuv based iomgr.
Waiting on completion queue(next) crashes randomly. Trace:
grpc_combiner_continue_exec_ctx () at external/com_github_grpc_grpc/src/core/lib/iomgr/combiner.cc:188 188     external/com_github_grpc_grpc/src/core/lib/iomgr/combiner.cc: No such file or directory. (gdb) bt #0  grpc_combiner_continue_exec_ctx() () at external/com_github_grpc_grpc/src/core/lib/iomgr/combiner.cc:188 #1  0x000055567a71593a in grpc_core::ExecCtx::Flush() (this=0x7f771d7fd010) at external/com_github_grpc_grpc/src/core/lib/iomgr/exec_ctx.cc:82 #2  0x000055567a6e7a71 in end_worker(grpc_pollset*, grpc_pollset_worker*, grpc_pollset_worker**)     (pollset=pollset@entry=0x55567deb08b8, worker=worker@entry=0x7f771d7fcee0, worker_hdl=worker_hdl@entry=0x0)     at external/com_github_grpc_grpc/src/core/lib/iomgr/exec_ctx.h:233 #3  0x000055567a6e8e33 in pollset_work(grpc_pollset*, grpc_pollset_worker**, grpc_core::Timestamp) (ps=<optimized out>, worker_hdl=<optimized out>, deadline=...)     at external/com_github_grpc_grpc/src/core/lib/iomgr/ev_epoll1_linux.cc:1059 #4  0x000055567a6e31fc in pollset_work(grpc_pollset*, grpc_pollset_worker**, grpc_core::Timestamp) (pollset=0x55567deb08b8, worker=0x0, deadline=...)     at external/com_github_grpc_grpc/src/core/lib/iomgr/ev_posix.cc:321 #5  0x000055567a6968f8 in cq_next(grpc_completion_queue*, gpr_timespec, void*) (cq=0x55567deb07b0, deadline=..., reserved=<optimized out>)     at external/com_github_grpc_grpc/src/core/lib/surface/completion_queue.cc:1047 #6  0x000055567a20c7a5 in grpc::CompletionQueue::AsyncNextInternal(void**, bool*, gpr_timespec)     (this=this@entry=0x7f764fc3bad0, tag=tag@entry=0x7f771d7fd110, ok=ok@entry=0x7f771d7fd118, deadline=...)     at external/com_github_grpc_grpc/src/cpp/common/completion_queue_cc.cc:146 #7  0x000055567a1a48e0 in grpc::CompletionQueue::Next(void**, bool*) (ok=0x7f771d7fd118, tag=0x7f771d7fd110, this=0x7f764fc3bad0)
What did you expect to see?
No crash
What did you see instead?
Crash as mentioned above.
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?

Completion queue has write tag waiting and this happens while receving write tag

This was a side effect of another issue in the code.

Could you link that issue here? I encounter the same problem on v1.48

this has been before few weeks, I am think it was due to same tag multiple times, there was a race condition in my code which was leading to this. Do you mind sharing your code here, I can give it a shot.

This was a side effect of another issue in the code.

Could you link that issue here? I encounter the same problem on v1.48

this has been before few weeks, I am think it was due to same tag multiple times, there was a race condition in my code which was leading to this. Do you mind sharing your code here, I can give it a shot.

It seems to be a different cause on my side, it is happening on channel credentials initialization
    /data/app/com.tophatch.concepts-1/lib/arm/libgrpc.so:3257717 grpc_combiner_continue_exec_ctx()
    /data/app/com.tophatch.concepts-1/lib/arm/libgrpc.so:3274409 grpc_core::ExecCtx::Flush()
    /data/app/com.tophatch.concepts-1/lib/arm/libgrpc++.so:554541 grpc::SecureChannelCredentials::~SecureChannelCredentials()
    /data/app/com.tophatch.concepts-1/lib/arm/libgrpc++.so:555861 std::__ndk1::__shared_ptr_pointer<grpc::SecureChannelCredentials*, std::__ndk1::default_delete<grpc::SecureChannelCredentials>, std::__ndk1::allocator<grpc::SecureChannelCredentials> >::__on_zero_shared()

on this line
grpc::SslCredentialsOptions               credentialOptions;
std::shared_ptr<grpc::ChannelCredentials> channel_creds = grpc::SslCredentials(credentialOptions);

seems like your channel_creds is getting destroyed and it is being used somewhere else. Maybe share your code snippet here.

    grpc::SslCredentialsOptions credentialsOptions;
    std::shared_ptr<grpc::ChannelCredentials> channel_creds = grpc::SslCredentials(credentialsOptions);
    if (!channel_creds)
    {
       // return error
    }

    channel  = grpc::CreateCustomChannel(address.c_str(), channel_creds, args);

After grpc::CreateCustomChannel, the function which contains this code ends so channel_creds is destroyed and not used anymore.

yeah, this part seems okay. did you actually check line number from your source code?

Yes, I'm thinking that this can be a bug specific for arm architecture as it happens on an Android device with arm architecture and API level 25 which is a bit old.
Thanks!


Update chain.json

Added Apeiron Nodes seed and rpc.

Please use a more descriptive PR titles

Please use a more descriptive PR titles

Done

Please use a more descriptive PR titles

Done

I don't see any changes. He means for you to change the name of the the PR itself (you can do this by clicking edit on the PR title at the top of this page).

Please use a more descriptive PR titles

Done

I don't see any changes. He means for you to change the name of the the PR itself (you can do this by clicking edit on the PR title at the top of this page).

Now it's okay?🤔


Bug when combined with Illandril's Inventory Sorter

When dragging an inventory item from one token to another (not from a compendium to a token) I get an error with the following message in the console:
Uncaught (in promise) Error: The key B3EbdfIsEwnQO4up does not exist in the EmbeddedCollection Collection
[No packages detected]
at Map.get (/G:/FoundryVTT/resources/app/common/utils/collection.mjs:106)
at ServerDatabaseBackend._updateEmbeddedDocuments (/G:/FoundryVTT/resources/app/dist/database/backend/server-backend.mjs:1)
at ServerDatabaseBackend.update (/G:/FoundryVTT/resources/app/common/abstract/backend.mjs:153)
at async Socket.handleEvent (/G:/FoundryVTT/resources/app/dist/server/sockets.mjs:1)
This bug goes away when I turn off Variant Encumbrance, or when I turn off Illandril's Inventory Sorter. I haven't always gotten this bug though, and he hasn't updated his in a few months so I suspect the issue is from this module.

Can't replicate, ut i think i solved the issue anyway with 0.6.5 version


Improvements to acquisition / CSV file loading.

SQL batching improves ingestion speed significantly.
Loads files in name-sorted order for determinism and saner progress tracking.
Individual transactions for each file (instead of one transaction for the full collection of files) results in:
-an UPSERT failure means the entirety of the file will not be loaded (before a single line failure would preserve the preceding lines and attempt the following lines of the same file).
-lock should be released more frequently, meaning read access should not block as much while acquisition is in progress.

i started but then resisted the urge to rewrite more of this stuff in lieu of a smaller changelist...  there is some dead code that could be removed but i thought leaving it might provide context as to why the call structure is the way it is.  i also began to look into better handling of import failures, but decided that should go into its own issue, and i wasnt sure how representative my sample data files are.  can we try this out on the staging server?  if so, how can i do that?

some TODOs i didnt put in the code:
--do more speed testing with UPDATEs instead of clean INSERTs (UPDATE will be slower than INSERT in any case, but its unclear how much batching improves this)
--better deal with failure files - save error message somewhere, alert someone that errors happened, perhaps preserve a summary of what files were/werent loaded in each run, etc...
--ON DUPLICATE KEY - update (zero out) timestamp2 & direction ?? [ database.py:104 -ish ]
--make sure directories exist before writing files?  it might do this already?

im seeing 2-4x speed up for acquisition depending on which subsets of sample data i provide it with, though that is on a beefy but shared test machine.  @AlSaeed is there a particular tool used to get this profiling output, or was that just something you did by hand?  https://github.com/cmu-delphi/delphi-epidata/pull/133#issuecomment-645358029

im seeing 2-4x speed up for acquisition depending on which subsets of sample data i provide it with, though that is on a beefy but shared test machine. @AlSaeed is there a particular tool used to get this profiling output, or was that just something you did by hand? #133 (comment)

This was done by hand via inserting boilerplate timing code around specific code blocks.


Metric used for reducing number of features? [GAFeatureSelectionCV]

The doc states that 'The features (variables) used by the estimator are found by optimizing the cv-scores and by minimizing the number of features' in the GAFeatureSelectionCV class. For the cv-score I guess the scoring metric (e.g. accuracy, F1...) is used.
What metric is used to reduce the number of features and how is that achieved? I have not found anything in the source code yet.
Appreciate the help!

Hi @nonajet, the metric used is the total number of selected features, so here is roughly how it goes
First, we register what is called the FitnessMax, which is the optimization criteria

        if criteria not in Criteria.list():
            raise ValueError(f"Criteria must be one of {Criteria.list()}, got {criteria} instead")
        # Minimization is handle like an optimization problem with a change in the score sign
        elif criteria == Criteria.max.value:
            self.criteria_sign = 1.0
        elif criteria == Criteria.min.value:
            self.criteria_sign = -1.0

    def _register(self):
        """
        This function is the responsible for registering the DEAPs necessary methods
        and create other objects to hold the hof, logbook and stats.
        """
        self.toolbox = base.Toolbox()

        # Criteria sign to set max or min problem
        # And -1.0 as second weight to minimize number of features
        creator.create("FitnessMax", base.Fitness, weights=[self.criteria_sign, -1.0])
        creator.create("Individual", list, fitness=creator.FitnessMax)

As you can see I added two weights one that depends if we want to maximize or minimize the metric (accuracy, f1-score, etc), and the second one is -1 indicating we want to minimize the second criterion, which is the number of features
Then there is a function called evaluate, which is used to judge the quality of each solution, this is register to use as the scoring function
self.toolbox.register("evaluate", self.evaluate)

The function returns a tuple (actually a list) with the cv-score and the number of features selected
return [score, n_selected_features]

This is what the model takes as input to calculate the overall fitness

Thanks for the swift reply @rodrigo-arenas!
Alright, now I see where the two objectives (maximize score/metric and minimize no. of features) are set.
But what I still not quite understand is how the two objectives are evaluated for one individual. As I see it, this is then an multi-objective problem meaning that we should get something like a Pareto front, don't we?
To be more specific, let's take this example:
We have two individual which are to be evaluated: A has a score/metric value of 80 and 5 features used, B has score of 85 and 7 features.
How would the algorithm value each of these individuals in regards to the two objectives (max. score & min. no. of features)?
Or in other words: Which individual is better? A or B?
Thanks in advance for taking the time!

Hi @nonajet, to figure out which solution is better it does use a Pareto dominance criterion, which is handled by the underlying DEAP package
You can check more details here:
https://deap.readthedocs.io/en/master/api/base.html#fitness
https://deap.readthedocs.io/en/master/api/tools.html#deap.tools

I'm closing this issue for now, let me know if you have further questions


Minor improvements

What's new?

Added pause button

Removed "INSTRUCTIONS" line

The instructions now scroll at a slower pace

Sound stops when player pauses the game

Included a .gitignore

thankies

did you put yourself in credits?

@RachelJMorris  No, i did not :p


GroupRectangle not working

Summary of your issue
I don't get any useful results with groupRectangle. Setting the threshold to 1, it removes all rectangles.
Example code:
What I am using currently:
Cv2.GroupRectangles(rectList, 1, 0.2);
What did you intend to be?
I have a lot of rectangles in a list. I want overlapping rectangles to be merged.

Hi,
Have you solved the problem？
Because I meet the same problem.
Thanks.

No, as far as I am remember I didn't find a solution for this. I used a work around, that's not available anymore.


Add Systemd instructions

The scope of this task is to prepare a system.d script for running the application.

Changes are merged, closing.


CU-67ugqz Add return data to create vault, backup and create collecti…

…on when it is existing

Task linked: CU-67ugqz Add data to create vault and create collection when it is existing

Task linked: CU-67ugqz Add data to create vault and create collection when it is existing


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?
Pattern Module
Module Name
avm/ptn/chat-with-your-data-solution-accelerator
Module Details
https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

First draft is here: https://github.com/segraef/bicep-registry-modules/tree/feat/chat-with-your-data-solution-accelerator/avm/ptn/chat-with-your-data-solution-accelerator

@segraef, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

Leaving this for a later point in time.


Fix opening existing Realms with seedFilePath set

Fixes #7840.

Yes, the seed file should be copied over if the Realm file doesn't exist on open, and ignored entirely if it does. This should now actually be tested.


Fix Vertical Stepper Line Interruption by Content

Fix Vertical Stepper Line Interruption by Content
This PR addresses an issue where the vertical stepper line is interrupted by its content (#160156).
Problem

ColoredBox Behavior: When used, ColoredBox requires wrapping it with a SizedBox, as SizedBox defaults to a zero size when no dimensions are specified.
This behavior leads to unexpected layout inconsistencies unless explicitly addressed.
Container Comparison: Unlike SizedBox, Container automatically expands to fit its parent's constraints, resulting in a more intuitive layout.

Solution

Ensure a consistent layout behavior by addressing the size handling when SizedBox is used.
Container automatically expands to fit its parent's constraints.

Related Issue

Fixes: #160156

@ayyoub-coder thank you so much!
Unfortunately I didn't notice you'd contributed a fix before I started working on it myself.
I have a slight preference toward avoiding Container objects, but I also appreciate the effort you put into this fix. I've opened #160193, but we can merge your change instead if you add a regression test and make sure all checks are passing.
Thanks again!

@nate-thegrate Thank you for reviewing my PR and providing valuable feedback!
I noticed the test you authored in PR #160193 for verifying the connector line in the vertical Stepper widget.
It’s a fantastic contribution and aligns seamlessly with the changes I’m implementing, so I’ve included your test in my PR.
Thanks again for your great work!

Thanks again @ayyoub-coder for your fantastic contribution!
I'm ashamed to go back on my word, but I think it's most likely that #160193 will be merged instead of this one, for a couple of reasons:

Per the Tree Hygiene page, contributions from those without commit access need 2 approvals before they can be merged, which means we'd need to continue putting resources into this fix.
Container is a kind of "heavy" class, with 11 fields and a beefy build method. At a bare minimum, it builds a ConstrainedBox wrapped with a LimitedBox, which is more expensive than render object widgets (they don't "build" anything).

Visual representation of number 2:
// this PR
PositionedDirectional
└── SizedBox
    └── Center
        └── ConstrainedBox
            └── ColoredBox
                └── LimitedBox
                    └── ConstrainedBox

// other PR
PositionedDirectional
└── Center
    └── SizedBox
        └── ColoredBox

The good first issue label might be worth checking out—next time you open a pull request, feel free to @ me and I'll make it a priority to help you get it to the finish line :)

Thank you so much for your kind words and detailed explanation, @nate-thegrate! I really appreciate the time and effort you’ve put into reviewing my PR and providing such insightful feedback.
I completely understand the rationale for moving forward with #160193—it’s a more efficient and streamlined approach. While I’m a bit disappointed that this PR won’t be merged, I’m grateful for the learning experience and the chance to contribute.
I’ll definitely explore the "good first issue" label and take you up on your generous offer to help with my next PR. It means a lot to know that you’re willing to support and guide me through future contributions.
Thanks again for everything! I look forward to collaborating with you on future Flutter improvements.


chore(fun_prop): move examples to a separate test file

chore(fun_prop): move examples to a separate test file

Moved examples to a separate file as suggested on Zulip

bors delegate+

bors r+


defStyleAttr was ignored

this is button ... the problem in class ActivityMainLayout's init method
 id_btn = new Button(getContext(), null, 0); //you generate code , you make defStyleAttr = 0

thanks for finding this bug. I released 0.0.2-alpha9 right now.


[Issue-556] Support for bigInt and decimal data type

Code Modifications done:

Modified code to parse decimal and bigInt datatype in create table command (handled by @nareshpr ).
Modified data load flow to load data with big decimal and bigInt data type.
Added test cases for testing decimal and bigInt datatype functionality.

Usage example:
Create table tablename (col1 String, col2 decimal(9,2)) stored by 'org.apache.carbondata.format'
Create table tablename (col1 String, col2 bigInt) stored by 'org.apache.carbondata.format'

@ravipesala ...I have handled all the review comments. Kindly review and merge

LGTM

retest this please


Fix watcher for promised/async initial data

Fixes #15; ngModel is not set as a $scope attribute just by having ngModelController, and at the post-link phase $attrs.ngModel may not be present. Go instead through $element.attrs('ng-model'), which returns a string that should evaluate properly in the element scope to the ng-model value.

Is there something missing here?

Can this get merged?

This PR was not working. I resolved in 3.0.12. Please check the jsbin: http://jsbin.com/xeheyi/1.


Bug/Feature: Mobile controls and view

Currently the mobile view is fairly broken, including white space, the context menu being too big for some screens, and the inability to use the application on mobile devices.
A proposal for those looking to make impactful additions and modifications to TLPP would be to introduce mobile controls, either by implementing a mobile joystick or simply using the displayed WASD image by adding event listeners to the image for where a user is pressing. As well as managing the HTML and CSS to display properly on smaller/mobile devices. Debugging the application for mobile displays is easy; most browsers have the option to toggle device view in developer settings, for example if you're using chrome, open developer tools using Ctrl+Shift+I and there will be a symbol on the top left of the window displayed labeled "toggle device toolbar", this will let you switch between simulated devices to see your changes in effect.

hi @Glowstick0017 I would like to give it a try, can you assign this to me?

Hello, I'd be happy to assist if additional help is needed! Would it be possible to assign it to me too?


fix(ci): add ci-dev profile flags to main-cron config

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?

Use ci-dev flags for our cron workflow as well, otherwise streaming e2e will timeout (exits with 124).
Configure ci-dev profile for e2e-source-test in cron config as well.

See failing cron report here: https://buildkite.com/singularity-data/main-cron/builds/93#01829487-b997-47a5-be2f-71e98fa13f32
Checklist
- [x] I have written necessary rustdoc comments
- [x] I have added necessary unit tests and integration tests
- [x] All checks passed in ./risedev check (or alias, ./risedev c)
Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

LGTM. BTW, why are we not using release profile for main-cron? 🤔 cc @huangjw806 @skyzh

I think we should, let's fix this next time 🤣

LGTM. BTW, why are we not using release profile for main-cron? 🤔 cc @huangjw806 @skyzh

I think we should, let's fix this next time 🤣

Using ci-dev in main-cron also LGTM, since we're already using release for main. Adding test analytics for main-cron with ci-dev can also make us easier to check performance degradation.


fix: InvalidStatusError not being handler correctly

Done
https://github.com/bucketeer-io/node-server-sdk/pull/61


enter key triggers an error

When chatting using the enter key to send, triggers this warning:
Uncaught TypeError: Cannot read property 'preventDefault' of undefined
    at o.handleSubmit (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:24057)
    at onKeyPress (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:24057)
    at HTMLUnknownElement.callCallback (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:1466)
    at Object.invokeGuardedCallbackDev (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:1516)
    at invokeGuardedCallback (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:1569)
    at invokeGuardedCallbackAndCatchFirstError (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:1583)
    at executeDispatch (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:1914)
    at executeDispatchesInOrder (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:1936)
    at executeDispatchesAndRelease (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:2034)
    at executeDispatchesAndReleaseTopLevel (modules.js?hash=cfa01d0b1989b1ac4f1e257f2151da0338ead237:2045)

  "_id": "<EMAIL_ADDRESS>

Thank you @shawnzam. Looking into it. What browser (name and version) and OS (same, name and version) are you using? Thanks
@hubertusputu1 I don't quite see how this would happen from what seems to be the code in question. Any ideas? Whichever way, we can probably just ignore the event if it's not available, but I really don't see how this is possible in the first place. Maybe a browser version issue.

I was using Version 85.0.4183.83 (Official Build) (64-bit) of Chrome. I will try to isolate it in a fresh app and report back later this week.

Hi @shawnzam , could you please update the Empirica Chat to the latest version 2.1.1 ? I saw you used a version 2.0.1, which maybe lead to that bug. https://www.npmjs.com/package/@empirica/chat. Thank you, please let use now if that might be still happen.

Bumping version resolved the issue. Thanks.

Awesome @shawnzam . You're welcome 🙌.


fix(context): do not error when karma is navigating in iframe

reset karmaNavigating flag only after iframe is loaded. otherwise we run in to a race condition where the flag is reset before URL changes and onbeforeunload is called afterwards making the handler think the navigation was not part of context change.

:x: Build karma 2889 failed (commit https://github.com/karma-runner/karma/commit/023f5f2948 by @radnan)

:x: Build karma 2889 failed (commit https://github.com/karma-runner/karma/commit/023f5f2948 by @radnan)

:x: Build karma 2890 failed (commit https://github.com/karma-runner/karma/commit/fb80878998 by @radnan)

:x: Build karma 2890 failed (commit https://github.com/karma-runner/karma/commit/fb80878998 by @radnan)


Compilation failure due to mismatched function signature in ec2cluster

The call to WatchLifecycleEvents in the etcd-aws source is short a parameter (the queueURL) according to ec2cluster source.
As a result the project does not compile.

#15
I am not sure if we want to panic on error, or what will happen if we pass in an empty string.

@crewjam bump. Any change to get https://github.com/crewjam/etcd-aws/pull/14 or https://github.com/crewjam/etcd-aws/pull/15 merged?

Yeah sorry for the delay. Travel today, I'll try to take a look today or
tomorrow.
On Wed, Jan 11, 2017 at 08:43 Pieter Lange<EMAIL_ADDRESS>wrote:

@crewjam https://github.com/crewjam bump. Any change to get #14
https://github.com/crewjam/etcd-aws/pull/14 or #15
https://github.com/crewjam/etcd-aws/pull/15 merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/crewjam/etcd-aws/issues/13#issuecomment-271871388,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFY8W1PxyeNPgx3XQx48vvImaMseBv9tks5rRNx8gaJpZM4K0EWv
.

A few days doesn't matter at this point. ;-) Thanks for the continued support on this project.

Merged #14. Is it working for you now?


Task result is not clear from documentation

It'd help me understand how to use this if documentation called out what the result of running specific actions looked like.

I added the output from the commands into the examples. was there anything else you would like to see ?
@HelenCampbell  for context

Works for me.


Add zigate support to zha

Description:
Add zigate support to zha component
zigate is a universal zigbee gateway http://www.zigate.fr
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9990
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

Is the branch based on latest dev branch? We were having troubles with CI during a time interval yesterday but I thought it was resolved.

@doudz can you rebase this and force push?

Looks like some tests need to be updated/added for the new code to address the drop in coverage.

Looks like some tests need to be updated/added for the new code to address the drop in coverage.

What should I do ?

I really don't know how I can improve coverage
Any help will be appreciate

Hi, @doudz
Maybe you can test get_zigate_radio() or if this method is untestable, registries.py should be excluded from .coveragerc file because it does not contains any testable code. This should increase coverage.
Maybe @dmulcahey can confirm ?

As you said, it's almost untestable

Hrm, we  have some conflicting changes merged upstream. Can you please rebase against latest dev?

@doudz I'm gonna try resolve conflicts manually, but you would have to double check me

Looks good to me too

@doudz Looks like you need to sync these changes to your local repo and run changed files through black code formatter. Github should really add that button :)


:recycle: Refactor the folder-based repository management processes f…

…or jobs, schemas and mappings. Fix issues regarding the initialization for existing folder structures.

I think it is necessary to remove .StructureDefinition from schema names in repositories after merging this PR.

Yes it is. Otherwise, in case an update happens on a schema, a new file will be written to the folder repository.


fix jni_GetByteArrayElements release

fix jni_GetByteArrayElements release
Caught the memory overflow stack
_malloc_zone_malloc_instrumented_or_legacy libsystem_malloc.dylib
os::malloc(unsigned long, MemoryType, NativeCallStack const&) libjvm.dylib
AllocateHeap(unsigned long, MemoryType, NativeCallStack const&, AllocFailStrategy::AllocFailEnum) libjvm.dylib
jni_GetByteArrayElements libjvm.dylib

@wuhaocn did you sign our icla yet ? https://netty.io/s/icla

@wuhaocn did you sign our icla yet ? https://netty.io/s/icla

It has already been signed

@wuhaocn thanks a lot! Let me merge this one and do a new release next week


Update the Readme.md file

The README.md file can be updated with contributors section and tech stacks.
Can you assign it ?

I can do this Please assign me this issue

@0xCipher-max please find other issues, as @LizaHaddock asked for this issue first ,I am assigning the issue to @LizaHaddock

copy of #46


What about auto build ?

If you have no time to publish the app. What about using Travis-CI (Free for open source projects) to auto build and publish on the play store.
It will save you a lot of time, you'd only have to merge changes and pull-request on master to trigger a build and publish (or trigger it manually).

Good suggestion, because the development has stalled on this Repo i created a fork and will continue developing the app. I will implement this later.

Good suggestion, because the development has stalled on this Repo i created a fork and will continue developing the app. I will implement this later.

Cool ;)
(Some doc how to do it : https://blog.fossasia.org/automatic-signing-and-publishing-of-android-apps-from-travis/)

According to Me, you already have this working? @Uneo7

@klaasnicolaas not with gapps. I have similar projects working with auto deployment like this.


Add a section about friendly/similar repositories?

Hello, @EvgenyKarkan.
How about adding section with similar repositories? I think this growing one is a good candiate to start section.
I haven't been doing anything on this algorithms topic during these latest months because of almost entire focus on patterns/architecture area so no contributions :smile:  Anyway I like it a lot that we created and now have this basic base of algorithms just in case if a need in some of them raises! Good work!
Thanks,
Stanislaw

Also note how they nicely arrange problems and solutions into the tables. I think EKAlgorithms repository could make friends with sagivo/algorithms and vice versa.

Hi @stanislaw, I don't mind.
Moreover, it will be cool if maintainer add our work as friendly/similar repo too :)

Looks like @sagivo is hesitating to add us back as friends for some reason. Anyway for us it is still good to have link to friendly repository because in Open Source networking is everything. @EvgenyKarkan, I think you'll agree with that. So I am closing this.

Hi @stanislaw !
Well, I am not sad about it, & hope you too :)
It's up to maintainer.

Yes and yes :smile:


Master doesn't build on x11 with werror=yes

Godot commit
6ac6bade0af42207ae33f3d44b5d70a9a9e3a1d4
OS version
x11
Issue
The engine can't build on my machine for warning as error rule - since the CI passed I'm not sure this is a problem of my machine or an engine problem, but here the errors:
First error
In file included from ./servers/visual/rasterizer_rd/rasterizer_rd.h:35,
                 from platform/x11/os_x11.cpp:44:
./core/thread_work_pool.h:42:9: error: 'struct ThreadWorkPool::BaseWork' has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
   42 |  struct BaseWork {
      |         ^~~~~~~~

Second error
In file included from ./core/error_macros.h:34,
                 from ./core/hash_map.h:34,
                 from ./core/object.h:34,
                 from ./core/os/input.h:34,
                 from platform/x11/os_x11.h:34,
                 from platform/x11/os_x11.cpp:31:
./servers/visual/rasterizer_rd/rasterizer_storage_rd.h: In member function 'VisualServer::PrimitiveType RasterizerStorageRD::mesh_surface_get_primitive(RID, uint32_t)':
./core/error_macros.h:151:25: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
  151 |  if (unlikely((m_index) < 0 || (m_index) >= (m_size))) {                                                     \
      |               ~~~~~~~~~~^~~
./core/typedefs.h:319:41: note: in definition of macro 'unlikely'
  319 | #define unlikely(x) __builtin_expect(!!(x), 0)
      |                                         ^
./servers/visual/rasterizer_rd/rasterizer_storage_rd.h:660:3: note: in expansion of macro 'ERR_FAIL_INDEX_V'
  660 |   ERR_FAIL_INDEX_V(p_surface_index, mesh->surface_count, VS::PRIMITIVE_MAX);
      |   ^~~~~~~~~~~~~~~~
./servers/visual/rasterizer_rd/rasterizer_storage_rd.h: In member function 'void RasterizerStorageRD::mesh_surface_get_arrays_and_format(RID, uint32_t, uint32_t, RID&, RID&, RenderingDevice::VertexFormatID&)':
./core/error_macros.h:126:25: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
  126 |  if (unlikely((m_index) < 0 || (m_index) >= (m_size))) {                                                     \
      |               ~~~~~~~~~~^~~
./core/typedefs.h:319:41: note: in definition of macro 'unlikely'
  319 | #define unlikely(x) __builtin_expect(!!(x), 0)
      |                                         ^
./servers/visual/rasterizer_rd/rasterizer_storage_rd.h:668:3: note: in expansion of macro 'ERR_FAIL_INDEX'
  668 |   ERR_FAIL_INDEX(p_surface_index, mesh->surface_count);

Yes, @reduz introduced many warnings, you can't build with werror=yes currently.

Do you want to postpone the fix or can I submit a fix now?

A fix would be great, but I assume there's a lot more warnings to fix after this one :)

If you fix all warnings, please re-enable werror=yes on Travis builds.

@akien-mga yee, you are right. nevermind... even because I don't know how @reduz want to deal with comparison of unsigned expression < 0 is always false [-Werror=type-limits]

If you fix all warnings, please re-enable werror=yes on Travis builds.

Seems that also Include a lot TODO work ;-)
modules/gdnative/arvr/arvr_interface_gdnative.cpp:290:2: warning: this needs to be redone [-W#warnings]
modules/gdnative/arvr/arvr_interface_gdnative.cpp:304:2: warning: need to obtain this ID again [-W#warnings]
editor/import/editor_scene_importer_gltf.cpp:993:2: warning: line loop and triangle fan are not supported and need to be converted to lines and triangles [-W#warnings]
scene/3d/soft_body.cpp:51:2: warning: Softbody is not working, needs to be redone considering that these functions no longer exist [-W#warnings]
scene/2d/sprite.cpp:367:2: warning: this need to be obtained from CanvasItem new repeat mode (but it needs to guess it from hierarchy, need to add a function for that) [-W#warnings]
scene/resources/mesh.cpp:1113:2: warning: need to add binding to add_surface using future MeshSurfaceData object [-W#warnings]
servers/visual_server.cpp:1593:2: warning: TODO all texture methods need re-binding [-W#warnings]
servers/visual_server.cpp:1714:2: warning: TODO all giprobe methods need re-binding [-W#warnings]
servers/visual_server.cpp:1871:2: warning: TODO method bindings need to be fixed [-W#warnings]
servers/visual/rasterizer_rd/rasterizer_canvas_rd.cpp:1328:2: warning: TODO obtain from framebuffer format eventually when this is implemented [-W#warnings]
servers/visual/rasterizer_rd/rasterizer_rd.cpp:88:2: warning: TODO: likely passa bool to swap buffers to avoid display? [-W#warnings]
servers/visual/rasterizer_rd/rasterizer_scene_rd.cpp:105:2: warning: TODO, should probably use this algorithm instead. Volunteers? - https://www.ppsloan.org/publications/ggx_filtering.pdf      / https://github.com/dariomanesku/cmft [-W#warnings]
servers/visual/rasterizer_rd/rasterizer_storage_rd.cpp:189:2: warning: TODO need to make a function in Image to swap bits for this [-W#warnings]


Allow for installing Python packages when starting Jupytrer

This has been added with the additional configuration property JUPYTER_python_packages to be added to the config.yml.


README has some auto-generated snippet replacer text

The text C:/repo/sdk-tools/packages/java-packages/snippet-replacer-maven-plugin is at the bottom of the tools readme. I assume this was just added by accident once, but it would be good to know why so it doesn't get re-added.
https://github.com/Azure/azure-sdk-tools/blob/main/README.md?plain=1#L32
CC @mikeharder @scbedd as you're both on the git blame around this line.

@benbp I seriously doubt this was automation. I'll remove it and close. If it pops up again I'll re-open this issue.

Hasn't come back. Closing.


Deployment pipeline

To build and attach the binaries on each new tag created.
Probably create with GitHub Actions?

Done in v1.0.2!


different in jit to pt model

Why do I find that the JIT model provided initially performs significantly better than the current PT model or the converted ONNX model during testing? Additionally, I noticed three nodes in the JIT model that are missing in the PT models.

Hi @Whatsetsthisend
We just confirmed that the original torchscript and the model in the current repo produces the same outputs and has identical evals on LVIS and COCO. Let us know if you see any descrepancies. An example would be great.

@Whatsetsthisend, we checked that the outputs are the same. I close this.


Change highlighting of symbol under cursor

First of all, thank you for the beautiful colorscheme, I have started using it everywhere.
I was wondering if it is possible to change the way the character and the symbol under the cursor are highlighted. Currently, the char under the cursor maintains its bg and fg, while the rest of the symbol (and all other occurrences of the symbol) get inverted. Is is possible to instead invert the current char, maintain the font colour for the rest of the symbol, and maybe lightly highlight the bg.
For example, this is how Solarized looks when the cursor is over the keyword "vim":

while this is how OnedarkPro looks like:

I tried looking into the source code for an answer, but I am quite new to NeoVim and Lua, so I was not able to find much. I am using kickstart with some basic modifications as a config.

There are two ways to fix this, you can use a plugin, such as mini-cursor or RRethy/vim-illuminate , or you can be use :h vim.lsp.buf.document_highlight.

Hello @andcov! I've noticed the same problem in my LazyVim configuration. The cursor is really hard to distinguish from the background with default solarized theme.
However, by changing highlight color I could achieve this result:
Before:

After:

The code:
  {
    "maxmx03/solarized.nvim",
    opts = {
      highlights = function (c)
        return {
          Visual = { bg = c.base1, fg = "#cccdfb" },
        }
      end
    }
  }

Hope it helps!


google-services.json requirement

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugGoogleServices'.
> File google-services.json is missing. The Google Services Plugin cannot function without it.

Getting this error when building my app.  I understand this is required if you want to use Android push notifications, but what if I just want to capture analytics, how can this error be resolved?
Thanks

Having the same issue

Hello, yes it's required for using push notifications on android. If you would want to remove it, you would have to do these steps for Cordova:

go into "plugins" folder
open "fetch.json" and remove entry for "cordova-support-google-services"
open  "android.json" and remove entry for "cordova-support-google-services"
delete "cordova-support-google-services" folder
go into our SDK folder in the plugins folder
open "plugin.xml" and remove lines from the android push notification section, EXCEPT this one:

This:
https://github.com/Countly/countly-sdk-cordova/blob/master/plugin.xml#L92-L100
And this:
https://github.com/Countly/countly-sdk-cordova/blob/master/plugin.xml#L102


Commitlint setup

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR adds commitlint configuration which ensures that the commit messages match the form type(scope): message etc..
It adds

a precommit hook using husky which verifies the commit is properly formatted before committing the staged files
a Travis config for verifying it during the Travis build

The configuration is in the commitlint.config.js at the root. Let me know what you think about it 😃
Please check if the PR fulfills these requirements

[x] The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] A unit test has been written for this change.
[x] Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
[ ] My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

This change is

Codecov Report

Merging #871 into next will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #871   +/-   ##
=======================================
  Coverage   93.42%   93.42%
=======================================
  Files          22       22
  Lines         943      943
  Branches      265      265
=======================================
  Hits          881      881
  Misses         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a25fc1...1a9b316. Read the comment docs.

Thank you @juristr!!


Coaches, Lone Druid and Such: People that pollute the hero table

Coaches and heroes with hero type versions of themselves pollute the hero/bot tables with their shenanigans.  Adjust the initial table routine to ignore these.

Should be fixed in <IP_ADDRESS>, adjusted data table initialization to ignore fake heroes.


Fix bad reference on scene when fetching textures asynchronously

Should fix #829 .
For safer use in async tasks, use a shared_ptr to the scene (retained in the lambda functions to fetch textures). What happens is that the reference to the scene used at the beginning of the scene loader pipeline would become inconsistent in the lambda functions and could potentially result in bad access, since it's copying the address of the reference here.

Looking at this now.

This looks fine, apart from the slight racecondition mentioned by @hjanetzek for copying of m_newScene to scene.
Even though this fixes the issue we need to have synchronous calls for URL fetching, which needs implementation for all platforms (refer #814).

@hjanetzek you good with this change?

Ready to merge if no more comments.

I'm not clear how these changes would resolve the issue. A std::shared_ptr<Scene>& is still a non-owning reference (i.e. it doesn't add to the reference count of the shared_ptr) so wouldn't this cause the same dangling reference problem?

The lambda where the problem happens would retain this shared pointer since it's given by copy instead of accessing the address of the reference to it.

Interesting - looking at the offending lambda, I would've expected [=] to make a copy of a reference, since the local scene is a reference, but in a debugger I can see that the reference count on the shared_ptr increases after the lambda is created, so the problem would seem to be solved.
LGTM

Yes this was an interesting bug, it wasn't obvious to me at first too. I tested that on a small program to see how this was behaving clearly. Merging!


Error processing font in library

Can't decode
The monaco-editor library includes a font, which is included during renedering but produces a
Failed to decode downloaded font<EMAIL_ADDRESS>OTS parsing error: incorrect entrySelector for table directory
Same problem occurs when using vue or preact
Reproduction
https://gitlab.com/fluxin/testvite
System Info

vite version: 15.0
Operating System: Pop!_OS
Node version: 12.16.3

With 0.15.5, you can remove monaco-editor from optimizeDeps.exclude and Vite will pre-bundle it properly. Your repro should work as intended (and faster).
I'll keep this open since the font decoding is still to be addressed.

Dep asset handling should be handled properly by 944e163 - closing for now. Please try it out after 0.20.3 is released and open new issue if the problem persists.


MSBUILD Clickonce Publish not created publish.html page [Azure DevOps]

/target:publish
/p:ApplicationVersion=$(AssemblyVersion)
/p:PublishURL=http://custome url/
/p:UpdateEnabled=true
/p:UpdateMode=Foreground
/p:CreateWebPageOnPublish=true
/p:WebPage="publish.html"
/p:IsWebBootstrapper=true

@kuldip1490 Thanks for your feedback; we appreciate it. To make sure we have all the information needed to triage your issue, please let us know which topic you’re referencing, or provide more context around the general task.

please check the details https://github.com/MicrosoftDocs/vsts-docs/issues/5278#issuecomment-522860342


[Feature Request] Skip back or ahead buttons.

It would be handy if I could display two buttons "Below Player".
One that skips backwards 5 seconds and one that skips forwards 5 seconds.
Thank you very much!

Thanks for the suggestion again, I'll get to it as soon as possible.

@vbmark Do you think it would be a good idea to let the user customize how much the buttons go back and forward? I can do that when I implement the feature.

Yes, it would be nice.  If I'm trying to understand some detail in a video, I may want to frequently go backwards in very small increments to get to just the right part.  However, if I just want an overview of something and am skipping around, then a larger increment setting is more useful.

Yes, it would be nice. If I'm trying to understand some detail in a video, I may want to frequently go backwards in very small increments to get to just the right part. However, if I just want an overview of something and am skipping around, then a larger increment setting is more useful.

thank you for replying.

@vbmark the feature is almost done. I just need to fix a few issues related to the feature

@vbmark I'm still working on the feature, The functionality works but two of the button placement locations have the buttons out of order. I need to fix that then I will merge to dev branch and upload the extension built with the new feature. It will be a bit until it is released on the webstores. Thanks for your patience!

@vbmark thanks for your patience, until a new version of the extension is published I will attach the extension built here.
The version says 1.25.0 but it does have the new feature I just didn't update package.json

File Name
SHA-256 Hash

[youtube-enhancer-v1.25.0-Chrome.zip](https://github.com/user-attachments/files/15888354/youtube-enhancer-v1.25.0-Chrome.zip
ce6f10b5080203f09f04ef8377702489ed097b37edd1995d61ff540bdfa20cb7

youtube-enhancer-v1.25.0-Edge.zip
ce6f10b5080203f09f04ef8377702489ed097b37edd1995d61ff540bdfa20cb7

youtube-enhancer-v1.25.0-Firefox.zip
71a83160e10e1b6e9a4c49ecb718a595ea2d6d092a41cb44565a87849c2f1f3d

When trying to install in Firefox, I get the message, "This addon could not be installed because it has not been verified".
I don't want to disable addon security so would it be possible for you to sign it?

When trying to install in Firefox, I get the message, "This addon could not be installed because it has not been verified".
I don't want to disable addon security so would it be possible for you to sign it?

You have to load the extension has a temporary addon. This file isn't meant to be loaded as a normal extension

The extension will be signed when a new release is made and I uplpad the extension to the stores


Social — Relations View Does Not Show Relation

Seems this page was fired out the door before it was fully baked. The Relations page shows any Persona an account is following and the Personas following the calling account (across all of their Personas). However, without knowing whether we already follow or are being followed, the page is sort of incomplete.

Done and done. The necessary information is shown as one would expect it to be. Not sure why this wasn't coded sooner ...
Update is part of 20B200 and will be deployed momentarily.