[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependabot-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report
Patch coverage has no change and project coverage change: -0.09 :warning:

Comparison is base (7e8ca2b) 82.03% compared to head (aedf0a9) 81.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   82.03%   81.95%   -0.09%
==========================================
  Files          42       42
  Lines        1197     1197
==========================================
- Hits          982      981       -1
- Misses        215      216       +1

Flag
Coverage Δ

linux
81.95% <ø> (ø)

linux-extra_libs
81.95% <ø> (ø)

windows
?

windows-extra_libs
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove Repositories from ACL in UI

This PR really needs to link to an issue. It is of intense interest to users, and it retreats on a documented commitment  that we made to our users.

I've also mentioned it on Slack, link is just for one instance.
So we need to state the requirement explicitly and explain why it changes, at the product level.

This PR really needs to link to an issue. It is of intense interest to users, and it retreats on a documented commitment that we made to our users.

You're absolutely right, I've created an issue to represent this feature change request.


How to start loading from the first image every time?

How does it always start from image-001?

Are you running local, or on a service? If on a service it requires the same machine to be able to increment to the next image, as the counter is stored in memory under the "label" name. It also only increments every run of the workflow, if that wasn't obvious. I know I've had to point that out once or twice in the past.

您是在本地运行，还是在服务上运行？如果在服务上，它需要同一台计算机才能递增到下一个映像，因为计数器以 “label” 名称存储在内存中。它还只会增加工作流程的每次运行（如果这并不明显）。我知道我过去不得不指出一两次。

是不是意味着不能用purge cache节点？


Add Qt

https://github.com/JesseTG/awesome-qt
Qt is a popular framework for desktop (and recently mobile) application development.  Some well-known software uses it, too.  This lists includes libraries, tools, blogs, and books that are useful for beginners and experts alike.
By submitting this pull request I confirm I've read and complied with the below requirements.
Failure to properly do so will just result in the pull request being closed and everyone's time wasted. Please read it twice. Most people miss many things.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title. For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should include a short description about the list project/theme (not the list itself), and should be added at the bottom of the appropriate category.
The list I added

has been around for at least 30 days,
is the result of hard work and is the best I could possibly produce,
is a non-generated Markdown file in a GitHub repo,
is not a duplicate,
includes a succinct description of the project/theme at the top (example),
includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website. The logo should be high-DPI, so set it to maximum half the width of the original image.),
only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
contains the awesome badge on the right side of the list heading,
has a Table of Contents section named Contents as the first section,
has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc) (If you use a license badge, it should be SVG, not PNG),
has contribution guidelines,
doesn't include a Travis badge,
has been checked for inconsistent formatting, spelling, and grammar:

Each link description starts with an uppercase character and ends with a period.
Drop all the A / An prefixes in the descriptions.
Consistent naming. For example, Node.js, not NodeJS or node.js.

Nice work. Looks pretty good :)

The entry in the Awesome list should include a short description about the list project/theme (not the list itself), and should be added at the bottom of the appropriate category.

Not followed.

includes a succinct description of the project/theme at the top (example),

Not followed.

includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website. The logo should be high-DPI, so set it to maximum half the width of the original image.),

Not followed.

Would be nice if the channel names in and include #qt, #qt-quick, #qt-creator, and #qt-chat. linked to the the channel on the Freenode webchat. For example: https://webchat.freenode.net/?channels=qt

The entry in the Awesome list should include a short description about the list project/theme (not the list itself), and should be added at the bottom of the appropriate category.
How's the one I just added?

includes a succinct description of the project/theme at the top (example),
Is there a particular example you have in mind?

includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website. The logo should be high-DPI, so set it to maximum half the width of the original image.),
You mean the Qt logo, or a logo that I will make?

Is there a particular example you have in mind?

There's an example linked in the guidelines.

OK, how about now?

includes a project logo/illustration (whenever possible) at the top right of the readme (example). (The logo should link to the project website or any relevant website.)

Please read all the text.

Okay, revised the logo a bit.

Looks good now :)

Thank you very much!


Make extensions load definition easier for multiple extensions collections

As it currently stands, it is possible to have extensions which are applicable only to certain microservices within druid. For example: a broker does not need to load in a deep storage extension, coordinator does not need a cache extension, historicals don't need to load the spark batch indexer.
MOST of the time this is harmless, but if there is a reason to have an extension loaded only on certain nodes, it becomes very cumbersome to keep track of the load list.
Since we have a common.runtime.properties and a runtime.properties I suggest moving the extension list to something that can work with a definition in both properties files.
Potential solutions include, but are not limited to:

A common extension load list and a load list for runtime.properties
A special property prefix which can be grep'd to find the extensions. ex: druid.extension.list.foo, druid.extension.list.bar --> extensionList=["foo", "bar"]

Option 2 sounds better.
I currently face the same problem. I have an extension which requires QuerySegmentWalker, but overlord doesn't have one and overlord failed to start, I have to override extension list in runtime.properties to fix it.


[Problem] Add software interrupt.

I would like to implment the software interrupt on idt[0x80] ( likes linux's syscall ), but I've run into a calling convention problem:
eax will be overwrited when extern "x86-interrupt" fn foo {} is executed.
Is this the feature of the x86-interrupt?  Or am I missing anything?
And where can I found the doucuments about x86-interrupt?

RFC mention x86-interrupt was clobbered rax.
Is that mean we need to use other register to pass the syscall's number? More over, should we need to consider other registers are callee-save registers or define them by myself?

AFAICT there are no guarantees about the contents of registers once the function has been entered. If you want to inspect/modify registers you could use the #[naked] attribute on a function and implement the calling convention yourself.

@Freax13 Thanks for your suggestion.
In these days, I trace the asm code of different kind x86-inerrupt function, and found the interesting behavior:
If we use the InterruptStackFrame, the asm code like below, which will overwrite the rax

however, if we unuse the InterruptStackFrame, it looks like this, which will not overwrite the rax.

On the other hand, @xfoxfu (repo.) provides a good solution to do the type wrapping (extern "C" -> extern "x86-interrupt") which has already perplexed me for a long time.

however, if we unuse the InterruptStackFrame, it looks like this, which will not overwrite the rax.

There's no guarantee that this will always be the case. This might work for now, but can (and most certainly will) break at any time in the future.

On the other hand, @xfoxfu (repo.) provides a good solution to do the type wrapping (extern "C" -> extern "x86-interrupt") which has already perplexed me for a long time.

The thing that makes this work is their wrap! macro which generates a naked function that pushes the registers onto the stack and prepares the registers for calling a function with the C abi before calling the wrapped function.
I think they could use the x86-interrupt calling convention for their generated function and then they wouldn't have to transmute the function when setting the entry.


Out of memory errors

We've got a couple of these in Sentry
https://nwac.sentry.io/issues/4577668605/?project=4504317393436672&query=is:unresolved&stream_index=0
https://nwac.sentry.io/issues/4577466920/?project=4504317393436672&query=is:unresolved&stream_index=5
Also anecdotal reports of the app behaving weirdly when it runs for a long time make me believe that we might be leaking somewhere.
This looks like a good place to start: https://blog.swmansion.com/hunting-js-memory-leaks-in-react-native-apps-bd73807d0fde

xref https://github.com/NWACus/avy/issues/249

so far there's only 1 instance of each error in Sentry in the last 30 days, so this might not be the highest priority investigation.

Closing this as there's nothing actionable, the Sentry errors haven't recurred


[Autocomplete] Warn when value is invalid

[x] I have followed (at least) the PR section of the contributing guide.

Closes #24194

Please add a test similar to
https://github.com/mui-org/material-ui/blob/70e6c6b7268918502f9c82b2820146d3a1f2ff33/packages/material-ui-lab/src/TreeItem/TreeItem.test.js#L35-L61

Hi Mr. @oliviertassinari can you please provide required changes which Mr. @eps1lon want. Thank you


ci: disable secrets for dependabot PRs

Issue #, if available: https://github.com/dependabot/dependabot-core/issues/3253#issuecomment-852541544
Description of changes:
We've seen several tests fail lately, mainly on Windows, for the reason that the aws-actions/configure-aws-credentials action is failing like so:
Run aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a
  with:
    role-session-name: credhelper-test
    audience: sts.amazonaws.com
  env:
    has_creds: true
Error: Input required and not supplied: aws-region

The role-to-assume and aws-region aren't even passed into the action as inputs. Since this seems to only happen on Windows and on dependabot PRs, it leads me to believe that this is the root cause: https://github.com/dependabot/dependabot-core/issues/3253#issuecomment-852541544. The issue describes how/why dependabot PRs are have secrets disabled in depth, which lines up with the errors we're seeing.
The reason this only occurred for Windows e2e test runs is because the condition that was set for macOS always evaluated to false, due to a syntax error (which should also be fixed by this PR).
Testing done:

It's pretty hard to test this since I'm not dependabot, but we'll know as soon as this PR is merged and the dependabot PRs are rebased.

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Overriding merge since this doesn't change finch functionality at all.


[$125] [Search v2.1] Open reports show fake in To column

Problem
Coming from here, open reports show __Fake__ in the To column because they don't have a managerID.
Solution
We should just display an empty column in that case.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021831386678971022108
Upwork Job ID:<PHONE_NUMBER>971022108
Last Price Increase: 2024-09-04
Automatic offers:

ikevin127 | Contributor | 103817750

Issue OwnerCurrent Issue Owner: @rushatgabhane

Proposal
Please re-state the problem that we are trying to solve in this issue.
Open reports show fake in To column
What is the root cause of that problem?
The formattedTo can be _fake_ if we don't have a mangerID and we don't display empty string in this case.
https://github.com/Expensify/App/blob/62e6f636e54062888409091290427a7683ea3308/src/components/SelectionList/Search/TransactionListItemRow.tsx#L391-L395
What changes do you think we should make in order to solve the problem?
We should fix the core function that returns the transaction item here then the bug can be fixed in all places that we used this item.
OPTIONAL: We can do the same check for formattedFrom but I think this will always exist
formattedTo: formattedTo === CONST.REPORT.OWNER_EMAIL_FAKE ? '' : formattedTo

https://github.com/Expensify/App/blob/65c8db539450437d4db2ca7f73e9a3d8b2d24f13/src/libs/SearchUtils.ts#L72
What alternative solutions did you explore? (Optional)

@luacmartins Should we have one of the Contributors work on this based on proposals or will this be handled by a Contractor as most of the Search v2.1 issues ?

@ikevin127 yes, we can open this to other contributors

In that case, @Krishna2323's updated proposal  LGTM, being the first to point out the root cause and suggest a working solution.
🎀👀🎀 C+ reviewed

Hmm we shouldn't render the avatar either. I think if item.managerID = 0 we should just avoid rendering the UserInfoCell data

@luacmartins What do you think, should we strictly avoid rendering the UserInfoCell data where this component is located as mentioned in proposal 1 or do this from getTransactionItemCommonFormattedPropertie as suggested by the other proposal ?
Either way, both proposals need to be updated to comply with:

if item.managerID = 0 we should just avoid rendering the UserInfoCell data

and early return instead when managerID = 0.

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.
Current status: working through proposals

♻ Will review the updates in ~12h, starting with @Nodebrute since they were first to update according to the new expected result.

@luacmartins Unfortunately I am not able to reproduce the managerID = 0 and __fake__  in the way it was reproduced in the Slack report, meaning it happened without having to set any onyx data locally or hardcoding values.
Given this, to even begin to have proper proposals I think we first need to be able to reproduce the issue since without that I don't know the conditions in which the __fake__ would appear, it can be only if managerID = 0 or we can get it in other cases as well (❓) - which will dictate the proposal's root cause and solution.
I think there's two ways to to get this issue fixed:

Make it Internal since it would be easier for an Expensify engineer to both reproduce and fix the issue.
If issue remains External, we need steps to reproduce the issue as shown in the Slack report in order to be able to get complete proposals that Contributors can come up by actually reproducing the issue instead of improvising.

What do you think on the above @luacmartins?

@luacmartins Unfortunately I cannot reproduce, when I follow the steps you provided - the transaction I get in ND does have a managerID. Not sure what to do in this case, I'm happy to pass the issue to another C+ if they can reproduce this.

@ikevin127 hmm it seems like the report in the OP had a pending card transaction, maybe that could be related. I'll try to reproduce this on my end and report back.

Are we still accepting proposals from contributors? If not I can work on this if you assign me.
At this moment we're in the polishing phase for v2.1 and v2.2 so I have some free time on my hands for smaller bugs.

All yours @Kicu!

PR merged! Awaiting deploy to staging -> prod

⚠ Automation failed here -> this should be on [HOLD for Payment 2024-09-25] according to today's production deploy from Deploy Checklist: New Expensify 2024-09-17 which was shipped to production today.
cc @greg-schroeder

Updated

@bfitzexpensify gonna leave this one back in your capable hands now that you're back - should be set to go for 9/25!

Offer sent @ikevin127

@bfitzexpensify Accepted, thank you!


['Інформація про заклад' tab] Data fields and UI element are missed

Environment: Windows 10 Corporate LTSC 64-bit, Google Chrome v98.0.4758.82
Reproducible: always
Build found: Frontend: gcp-0.0.53, Backend: gcp-0.0.112
Preconditions

Follow link https://oos.dmytrominochkin.cloud/#/
Log into system as a SP (e.g<EMAIL_ADDRESS>'Password'="1qaz@WSX").
Select 'Інформація про заклад' in the menu bar at the top right corner.

Steps to reproduce

Look at the 'Інформація про заклад' section.
Look at the 'Опис' section.

Actual result

There is no 'Засновник' field's data in the 'Інформація про заклад' section.

There is no 'Тип закладу' field's data in the 'Опис' section.

Expected result

There should be 'Засновник' field's data in the 'Інформація про заклад' section according to the requirements.

There should be 'Тип закладу' field's data in the 'Опис' section according to the mock-up.

User story and test case links
User story https://github.com/ita-social-projects/OoS-Backend/issues/312; https://github.com/ita-social-projects/OoS-Backend/issues/236
Test case: OS-278
Labels to be added
Bug, pri: medium, severity: minor, UI

The bug report was edited because there was some clarification with BA.

'Засновник' field's data exists in the 'Інформація про заклад' section.
'Тип закладу' field will be implemented in the next release.


Please add the option to load subtitles

WebTorrent version: Latest
Node.js version: Not sure
Browser name/version (if using WebTorrent in the browser): using the mac app

This is an issue for webtorrent-desktop. Duplicated https://github.com/feross/webtorrent-desktop/issues/281


remove js files for now, remove docker, consolidate bumpversion config, update makefile for javascript

Codecov Report

Merging #184 (d946e99) into main (74106cd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   41.91%   41.95%   +0.04%
==========================================
  Files         119      118       -1
  Lines        5750     5746       -4
  Branches      876      876
==========================================
+ Hits         2410     2411       +1
+ Misses       3190     3185       -5
  Partials      150      150

Impacted Files
Coverage Δ

aat/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74106cd...d946e99. Read the comment docs.


UI design for ticket 136

Hi, @jacobwindsor @yusra-haider
I have also invited you to the Figma file by email and here..
https://www.figma.com/proto/tMrlll3t2XRScDe5K1SG0P/HCA-Ingest-Sprint-related-designs?node-id=122%3A218&viewport=-22%2C568%2C0.0625&scaling=min-zoom
Let me know if any questions or comments.
Gabs

Just to say that this first screen was substantially simplified like this:
And I think Yusra is working on it. I will tick my ticket for the design only as done.


In the “?help”, the javascript document can’t be displayed correctly when turn back from one item such as “Calling”

Repro steps:
•	Navigate to https://pxt.microbit.org/beta
•	Click “?help” , choose “JavaScript”
•	Click one item of the JavaScript list, such as “Calling”
•	Click the “js” of “js > call”

Expect result :
The display should turn back to the page of JavaScript list
Actual result :
The display could not  turn back to the page of JavaScript list

Fixed


Apply most of PyCharm's code inspection suggestions

Ready for another look.

Ready for another look.
I still see @classmethod before setUp . (I accidentally added it there but it shouldn't be there)
Did you forget to use git commit --amend after making changes?

I did indeed forget to commit!
Better to have one commit for this pull or two? I just committed without --amend. I can rebase before I push.

Better to have one commit for this pull or two? I just committed without --amend. I can rebase before I push.

I think one commit sounds good.
A potential alternative would be to split fixes to many small related commits like one commit fixing too long lines, another commit removing useless imports etc. Our code is still so small that there is no need to split the clean up commit.

Better to have one commit for this pull or two? I just committed without --amend. I can rebase before I push.

There is an alternative way in this case. You can use git reset HEAD^ to remove the latest commit from history. Then you can use git commit -a --amend to add all changes in working tree to the previous commit. git reset can be useful in many cases. But one has to be extra careful if using git reset --hard which rewrites history and removes working tree changes. It is often better to use git stash than git reset --hard.

Thanks! reset worked better for me than rebase. Git still complained that the repo was ahead of me, so I resorted to a force push. I think all looks well now - let me know.

I noticed changes to the branch. I used git diff 92edf3f 96cc8bc to see what changed in the branch (commit hashes from the message generated by git fetch origin)

The code on GitHib is the latest. I'll merge now.
PyCharm identified typos even in the comments!
# East, South, and Eest, with the suits separated by periods, e.g.

->
# East, South, and West, with the suits separated by periods, e.g.


automation: Fix CentOS version in Dockerfile

The CentOS version mentioned in the Dockerfile is now pointing to a
specific build (7.5.1804) instead of 'latest'.
The current 'latest' image has been found not to work well with NM.

Coverage remained the same at 71.017% when pulling 1f247b5e7da0e662f12a2bdf0b95fbc080ae18f8 on EdDev:docker-fix-centos-version into c87bdecefcfc5640b12ab42c3089d0400c65b3fc on nmstate:master.


initial implementation of saving gram and subsequent training

Hi,
This pull request is in regards to refactoring existing UF3 model training code into smaller functions. More specifically, gram and ordinate generation operations.
Background:
During model training the gram and ordinate matrices are generated prior to performing linear regression operations. In the current code, gram and ordinate matrices are generated each time a model is trained. However, repeatedly computing these matrices during a hyperparameter grid search adds a non-trivial computational expense to model training.
Motivation:
The purpose of this pull request is to significantly reduce the computational bottleneck associated with gram and ordinate matrices generation during model hyperparameter optimization. To accomplish this, existing UF3 code has been refactored into smaller functions, such that the gram and ordinate matrices are generated once and then saved to a .npz file. Subsequent model training involves reading in saved .npz files, hence eliminating the need to repeatedly compute these matrices
Code changes
Change 1
Addition of 'generate_gram_ordinate' function, which generates the gram and ordinate matrices.
Change 2:
Addition of 'save_gram_ordinate' function, which saves the gram and ordinate matrices.
Change 3:
Addition of 'fit_from_gram' function, which fits a model from saved gram and ordinate matrices.
Change 4:
Modification to 'fit_from_file' function. Added in functionality to save gram and ordinate matrices, as well as read in previously generated gram and ordinate matrices.
@monk-04 , please review per your request.

Cool I will take a look

There are a couple of sections in Michael's branch that are outdated. compared to the latest commit of the develop branch. I'll annotate them

I think the drop columns feature is also missing, but I'm not familiar with that, so I didn't leave any comments.

Other than line 488, everything else looks good to me.
In fit_from_file(), I would have tried to find a way to not write generate_gram_ordinate() 3 different times for cleanliness, but that's just my preference.

@sunghjung3 @michaelmacisaac There's no unittest. I won't accept the pull request unless there's a unittest or someone explains why there's no need for a unittest

Stephen and I believe since it is all code refactoring a unit test is not necessary. If you like I can make a minimum working example.
On May 15, 2024, at 9:23 PM, Ajinkya Hire @.***> wrote:

[External Email]
@sunghjung3https://github.com/sunghjung3 @michaelmacisaachttps://github.com/michaelmacisaac There's no unittest. I won't accept the pull request unless there's a unittest or someone explains why there's no need for a unittest
—
Reply to this email directly, view it on GitHubhttps://github.com/uf3/uf3/pull/115#issuecomment-2113734109, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXF2HGAKNSN6AKGLH5Z4XP3ZCQDCFAVCNFSM6AAAAABHYRDGF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTG4ZTIMJQHE.
You are receiving this because you were mentioned.Message ID: @.***>


Support empty input tensor for some ops (fix #14657)

Cudnn kernels doesn't work for empty input tensors.
This PR adds support for empty input tensor for FusedBatchNorm,FusedBatchNormGrad,Conv2DBackpropFilter, and cudnn pooling. (fix #14657)

Can one of the admins verify this patch?

When input tensor has zero elements, the reference BN forward implementation in the test script gives NaN for mean/variance, however I return zeros.
NaN seems to make more sense in terms of math, though it will then require some special treatment in the actual training. If there is no objections I'll switch to NaNs.

@zhangyaobit Could you comment on this: https://github.com/tensorflow/tensorflow/pull/15264#issuecomment-352926246 please?

@tensorflow-jenkins test this please

I haven't switched from returning zeros to returning NaNs, so the test is failing.

Let's wait for @zhangyaobit 's comment on this first then.

@ppwwyyxx, could you comment on the use case of an empty input (e.g. [0, 64, 64, 3])? Should we require the empty is non-empty?

In object detection we may run CNN on patches (object candidates) cropped from an image with predicted boxes. When the image has no candidates we'll get zero patches. In training we can filter out these data but still can't avoid it in testing. A workaround is to use tf.cond but I hope the op can support it by itself.
In fact, I just found that the CPU (eigen) implementation of fused_batch_norm can work with empty input and returns NaNs for mean/variance.

Thanks! This sounds good. Could you the behavior of GPU implementation consistent with Eigen (return NaNs)? Please let me know once the PR is ready for review.

@zhangyaobit The changes have been made. Could you review it when you have a time? Thanks!

@tensorflow-jenkins test this please

The implementation of FillFunctor, SetZeroFunctor, etc, are split in two bazel targets: :fill_functor and :constant_op. However :constant_op depends on a lot of stuff: it depends on :transpose_functor which depends on conv2d (I saw a TODO for this by @yzhwang). But I need conv2d to use SetZeroFunctor which ends up being a cyclic reference.

-    deps = ARRAY_DEPS,
+    deps = [
+        "//tensorflow/core:array_grad",
+        "//tensorflow/core:array_ops_op_lib",
+        "//tensorflow/core:framework",
+        "//tensorflow/core:lib",
+        "//third_party/eigen3",
+        ":bounds_check",
+        ":fill_functor",
+        ":ops_util",
+    ],

Cherry-picking the dependencies seems to make this PR build, but doesn't sound like an ideal solution. In general I guess functors should not depend on ops, but here fill_functor is actually in :constant_op, and :transpose_functor depends on :conv_ops.

Jenkins, test this please.

Thanks @drpngx for help! However I haven't yet fixed the cyclic dependency error mentioned above. I
think a proper fix would be one of the following:

Move GPU implementation of fill_functor to target :fill_functor.
Don't let :transpose_functor depend on :conv_ops.

The first one seems to be within my reach. I can give it a try but not sure if there is any reason why this is not done before.

Yeah, I would go for moving the stuff out of the constant op to the fill functor. If you feel that it is a generic library that could be used by more than one, then you could extract it out of constant op and have both depend on it.

@yifeif for some reason, this is stuck with kokoro-run. There are others PRs as well.

Ah if a PR has ran Kokoro tests before, it will need the force-run tag :).

Oh, makes sense, of course.

@ppwwyyxx there are some build breakages on GPU, could you check?

The build was failing because of the bazel dependency problem, which should've been fixed now after I moved implementations to :fill_functor target.

Jenkins, test this please.

/CC @gunan ran out of devmapper space on the Jenkins build.
devmapper: Thin Pool has 968455 free data blocks which is less than minimum required 983040 free data blocks. Create more free space in thin pool or use dm.min_free_space option to change behavior
ERROR: docker build failed. Dockerfile is at /var/lib/jenkins/workspace/tensorflow-pull-requests-cpu-python3/tensorflow/tools/ci_build/Dockerfile.cpu

Jenkins, test this please.

Why is 'XLA' build failing without details?

OK, looks like @yifeif might have fixed it. We just ran out of space on the machine.

@ppwwyyxx looks like an internal infra failure. I kicked it off again.

Merged. Woohoo!


A note regarding baseURL's for enterprise Github instances.

To whomsoever it may concern,
There is an important caveat regarding the baseURL when creating clients for enterprise Github instances ( for example with the NewEnterpriseClient method).
The baseURL of the public facing API is simply: https://api.github.com/"
However for enterprise Github instances the baseURL for the API is slightly different: https://<mycompany>.github.com/api/v3/"
Using a baseURL without the /api/v3/ suffix will result in HTTP 406 Not Acceptable errors and lead you down a path of debugging Oauth clients and request headers. I learnt this after many hours and tears.
Documenting this as an issue to help others in the future. Perhaps we could add note on the godoc regarding the difference in baseURL structures between public and enterprise Github.

Thank you, @vanugrah! We definitely want to make life easier for Enterprise GitHub users of this package.
We would greatly appreciate PRs that would help others to reduce or eliminate their pain points. If you or others could create these PRs (who are actually using this package with Enterprise GitHub), that would be excellent.
Also, wouldn't the baseURL be https://github.<mycompany>.com/api/v3/ for Enterprise users?

Thanks for the reply @gmlewis - I'll submit a PR shortly. To answer your question regarding the baseURL, if the Github enterprise instance is hosted by Github then the baseURL would in fact be https://github.<mycompany>.com/api/v3/ as you've mentioned. However in the case that enterprise instance is licensed and self hosted then it will likely have a subdomain under the companies domain i.e. https://<mycompany>.github.com/api/v3/.


disable dispatching of meshery extensions rollout on release

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

Where is this now being triggered?

This PR's description is incomplete.


Minor repo cleanup

Added packages readme to override the Github behavior of using the docs directory
Fixes #578
Deleted docs/build.zip
Deleted old authors file

Coverage remained the same at 95.216% when pulling c60f1fcba734d3c2eab3084be04877f3088f2859 on cody-repo-cleanup into ab785dc98cf3aed407e2470c01ec69964e783fdf on main.


Message provider test fails on maven-surefire-plugin 3.0.0-M4

After updating surefire plugin from 2.22.2 to 3.0.0-M4, pact message provider tests starts failing.
Looks like it fails to find annotated method that produce example message.
Below you can find test run (obfuscated a bit) with enabled debug logs for au.com package. The only difference is version of surefire-plugin. Not sure if it matters, but codebase is Kotlin.
2.22.2 (passes)
[INFO] Running com.example.pact.TpsCommandsProviderTest
2020-06-01 13:07:46.590 DEBUG   --- [           main] actVerificationInvocationContextProvider : provideTestTemplateInvocationContexts called
2020-06-01 13:07:46.619 DEBUG   --- [           main] actVerificationInvocationContextProvider : Verifying pacts for provider 'MYPROVIDER' and consumer 'null'
2020-06-01 13:07:46.621 DEBUG   --- [           main] actVerificationInvocationContextProvider : Pact source on test class: null
2020-06-01 13:07:46.782 DEBUG   --- [           main] actVerificationInvocationContextProvider : Pact loaders on test class: [@au.com.dius.pact.provider.junit.loader.PactBroker(scheme=${pactbroker.scheme:http}, port=${pactbroker.port:}, valueResolver=class au.com.dius.pact.core.support.expressions.SystemPropertyResolver, host=${pactbroker.host:}, consumers=[${pactbroker.consumers:}], tags=[${pactbroker.tags:latest}], authentication=@au.com.dius.pact.provider.junit.loader.PactBrokerAuth(password=${pactbroker.auth.password:}, scheme=${pactbroker.auth.scheme:legacy}, username=${pactbroker.auth.username:}, token=${pactbroker.auth.token:}))]
2020-06-01 13:07:46.816 DEBUG   --- [           main] a.c.d.p.p.junit.loader.PactBrokerLoader  : Loading pacts from pact broker for provider MYPROVIDER and tag latest
2020-06-01 13:07:46.826 DEBUG   --- [           main] a.c.d.p.p.junit.loader.PactBrokerLoader  : Authentication: basic
2020-06-01 13:07:46.848 DEBUG   --- [           main] a.c.dius.pact.core.pactbroker.HalClient  : Fetching: /
2020-06-01 13:07:49.267 DEBUG   --- [           main] a.c.dius.pact.core.pactbroker.HalClient  : Fetching: MYBROKER_URL/pacts/provider/MYPROVIDER/latest
2020-06-01 13:07:49.873 DEBUG   --- [           main] a.c.dius.pact.core.pactbroker.HalClient  : Fetching: MYBROKER_URL/pacts/provider/MYPROVIDER/consumer/tps/version/0.0.1
2020-06-01 13:07:50.688 DEBUG   --- [           main] p.j.PactVerificationStateChangeExtension : beforeEach for interaction 'INTERACTION'

Verifying a pact between tps and MYPROVIDER
  [Using Pact Broker MYBROKER_URL:]
  INTERACTION
2020-06-01 13:07:50.993 DEBUG   --- [           main] a.c.dius.pact.provider.ProviderVerifier  : projectClasspath = [file:/C:/Users/dpavlov/AppData/Local/Temp/surefire6061037475517929924/surefirebooter2462921145485977477.jar, file:/C:/Users/dpavlov/.m2/repository/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar, file:/C:/Users/dpavlov/.m2/repository/net/bytebuddy/byte-buddy-agent/1.10.10/byte-buddy-agent-1.10.10.jar]
2020-06-01 13:08:03.206 DEBUG   --- [           main] a.c.dius.pact.provider.ProviderVerifier  : found class public final class com.example.pact.TpsCommandsProviderTest
2020-06-01 13:08:03.220 DEBUG   --- [           main] a.c.dius.pact.provider.ProviderVerifier  : found method [@au.com.dius.pact.provider.PactVerifyProvider("INTERACTION") @org.jetbrains.annotations.NotNull("") public final java.lang.String buildTreatmentMessage()]
2020-06-01 13:08:03.284 DEBUG   --- [           main] a.c.dius.pact.provider.ProviderVerifier  : Found methods = [public final java.lang.String com.example.pact.TpsCommandsProviderTest.buildTreatmentMessage()]
    generates a message which
.....
      has a matching body (OK)
      has matching metadata (OK)
2020-06-01 13:08:05.507 DEBUG   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : Received test result 'au.com.dius.pact.core.pactbroker.TestResult$Ok@186dc515' for Pact MYPROVIDER-tps and INTERACTION
2020-06-01 13:08:05.515 DEBUG   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : Number of interactions #1 and results: [au.com.dius.pact.core.pactbroker.TestResult$Ok@186dc515]
2020-06-01 13:08:05.517 DEBUG   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : All interactions for Pact MYPROVIDER-tps have a verification result
2020-06-01 13:08:05.521  WARN   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : Skipping publishing of verification results as it has been disabled (pact.verifier.publishResults is not 'true')
2020-06-01 13:08:05.525 DEBUG   --- [           main] p.j.PactVerificationStateChangeExtension : afterEach for interaction 'INTERACTION'

3.0.0-M4 (fails)
[INFO] Running com.example.pact.TpsCommandsProviderTest
2020-06-01 13:11:16.077 DEBUG   --- [           main] actVerificationInvocationContextProvider : provideTestTemplateInvocationContexts called
2020-06-01 13:11:16.120 DEBUG   --- [           main] actVerificationInvocationContextProvider : Verifying pacts for provider 'MYPROVIDER' and consumer 'null'
2020-06-01 13:11:16.122 DEBUG   --- [           main] actVerificationInvocationContextProvider : Pact source on test class: null
2020-06-01 13:11:16.275 DEBUG   --- [           main] actVerificationInvocationContextProvider : Pact loaders on test class: [@au.com.dius.pact.provider.junit.loader.PactBroker(scheme=${pactbroker.scheme:http}, port=${pactbroker.port:}, valueResolver=class au.com.dius.pact.core.support.expressions.SystemPropertyResolver, host=${pactbroker.host:}, consumers=[${pactbroker.consumers:}], tags=[${pactbroker.tags:latest}], authentication=@au.com.dius.pact.provider.junit.loader.PactBrokerAuth(password=${pactbroker.auth.password:}, scheme=${pactbroker.auth.scheme:legacy}, token=${pactbroker.auth.token:}, username=${pactbroker.auth.username:}))]
2020-06-01 13:11:16.316 DEBUG   --- [           main] a.c.d.p.p.junit.loader.PactBrokerLoader  : Loading pacts from pact broker for provider MYPROVIDER and tag latest
2020-06-01 13:11:16.331 DEBUG   --- [           main] a.c.d.p.p.junit.loader.PactBrokerLoader  : Authentication: basic
2020-06-01 13:11:16.363 DEBUG   --- [           main] a.c.dius.pact.core.pactbroker.HalClient  : Fetching: /
2020-06-01 13:11:18.484 DEBUG   --- [           main] a.c.dius.pact.core.pactbroker.HalClient  : Fetching: MYBROKER_URL/pacts/provider/MYPROVIDER/latest
2020-06-01 13:11:18.837 DEBUG   --- [           main] a.c.dius.pact.core.pactbroker.HalClient  : Fetching: MYBROKER_URL/pacts/provider/MYPROVIDER/consumer/tps/version/0.0.1
2020-06-01 13:11:19.863 DEBUG   --- [           main] p.j.PactVerificationStateChangeExtension : beforeEach for interaction 'INTERACTION'

Verifying a pact between tps and MYPROVIDER
  [Using Pact Broker MYBROKER_URL:]
  INTERACTION
2020-06-01 13:11:20.625 DEBUG   --- [           main] a.c.dius.pact.provider.ProviderVerifier  : projectClasspath = [file:/C:/Users/dpavlov/AppData/Local/Temp/surefire2807362591171876872/surefirebooter3628354656395821945.jar, file:/C:/Users/dpavlov/.m2/repository/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar, file:/C:/Users/dpavlov/.m2/repository/net/bytebuddy/byte-buddy-agent/1.10.10/byte-buddy-agent-1.10.10.jar]
2020-06-01 13:11:21.618 DEBUG   --- [           main] a.c.dius.pact.provider.ProviderVerifier  : Found methods = []
      Verification Failed - No annotated methods were found for interaction 'INTERACTION'. You need to provide a method annotated with @PactVerifyProvider("INTERACTION") on the classpath that returns the message contents.
2020-06-01 13:11:21.736 DEBUG   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : Received test result 'au.com.dius.pact.core.pactbroker.TestResult$Ok@63a846fe' for Pact MYPROVIDER-tps and INTERACTION
2020-06-01 13:11:21.749 DEBUG   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : Number of interactions #1 and results: [au.com.dius.pact.core.pactbroker.TestResult$Ok@63a846fe]
2020-06-01 13:11:21.752 DEBUG   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : All interactions for Pact MYPROVIDER-tps have a verification result
2020-06-01 13:11:21.757  WARN   --- [           main] a.c.d.p.p.DefaultTestResultAccumulator   : Skipping publishing of verification results as it has been disabled (pact.verifier.publishResults is not 'true')
2020-06-01 13:11:21.760 DEBUG   --- [           main] p.j.PactVerificationStateChangeExtension : afterEach for interaction 'INTERACTION'
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.814 s <<< FAILURE! - in com.example.pact.TpsCommandsProviderTest
[ERROR] com.example.pact.TpsCommandsProviderTest.pactVerificationTestTemplate(PactVerificationContext)[1]  Time elapsed: 2.016 s  <<< ERROR!
java.lang.IllegalArgumentException: [Ljava.lang.String;@3a52b3a2 cannot be converted to JSON
	at com.example.pact.TpsCommandsProviderTest.pactVerificationTestTemplate(TpsCommandsProviderTest.kt:33)

I haven't been able to replicate this. My test project https://github.com/uglyog/pact-maven-amqp-test worked fine after upgrading to 3.0.0-M4.
Looking at the logs, I can see
projectClasspath = [file:/C:/Users/dpavlov/AppData/Local/Temp/surefire2807362591171876872/surefirebooter3628354656395821945.jar, file:/C:/Users/dpavlov/.m2/repository/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar, file:/C:/Users/dpavlov/.m2/repository/net/bytebuddy/byte-buddy-agent/1.10.10/byte-buddy-agent-1.10.10.jar]

From that you can see that your test code is not available on the classpath, that is why it has not found the method. Make sure you have useSystemClassLoader enabled for Surefire plugin: https://github.com/uglyog/pact-maven-amqp-test/blob/master/provider/pom.xml#L100

@uglyog indeed I don't have this option configured and can try to do it.
Maybe it is a separate question, but still - why do it matters? Is there any option for "lightweight" approach that does not require any class path scanning? After all junit extension has access to already created instance of test class and it'd be way simpler to just call methods on it instead of any of classpath scanning

That was just how it was implemented.


Hammer/generic alerts

What's new
This works with https://github.com/open-rmf/rmf_internal_msgs/pull/71
Replaces the existing task alert system to be much more flexible and generic, with the key purpose to support the smart cart API server interaction.

Test with regular task

task complete
failed dispatch

Test with fleet alerts
ros2 topic pub /fleet_alert rmf_fleet_msgs/msg/FleetAlert '{id: test2, title: title, subtitle: subtitle, message: message, display: true, tier: 0, responses_available: [move_off, timeout], alert_parameters: [{name: waiting_at, value: test_location}], task_id: test_task}' --once

Test location_result fleet alert
Mimic fleet adapter publishing an alert with the correct parameters, informing the backend that it is waiting for a location_complete call.
Note that this call has

display: false
task_id: test_task_id
responses_available: [success, fail]
alert parameters of {name: type, value: location_result} and {name: location_name, value: test_location_name}

ros2 topic pub /fleet_alert \
  rmf_fleet_msgs/msg/FleetAlert \
  '{id: test_id, title: title, subtitle: subtitle, message: message, display: false, tier: 0, responses_available: [success,fail], alert_parameters: [{name: type, value: location_result}, {name: location_name, value: test_location_name}], task_id: test_task_id}' --once

This will be saved in the database, but not displayed on the frontend.
Start listening to the alert response in another terminal,
ros2 topic echo /fleet_alert_response

We can now mimic the Smart Cart API server calling the destination complete route, by navigating to localhost:8000/docs, and using the /tasks/location_complete POST route. Make sure that the task_id and location_name matches.

After the call is done, we should see a response on the ROS 2 topic, to be picked up by the fleet adapter to move off and continue with the next location.
What's left:

align parameters and less hard coding

What's next:

Migrate delivery_alerts to use this as well
Frontend for new task types

Self-checks

[ ] I have prototyped this new feature (if necessary) on Figma
[ ] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

not sure if this image is still updated, there are multiple issues with the design

The number of available responses is unbounded, better to list them in a dropdown.
The buttons are different size.

A suggestion for the alert responses is to use split buttons https://mui.com/material-ui/react-button-group/#split-button


store: GetRangeByHeight should not Verify headers internally

The Getter interface, which Store implements, guarantees that GetRangeByHeight always returns valid headers. This was likely the motivation behind doing Verify over each header inside GetRangeByHeight. However, headers appended to the Store are verified in the Append, and assuming trust in the underlying Datastore, we can skip redundant verification on every range read. The main reason to avoid additional verification is the computation cost of signature checks, which is predominant for user's like celestia-node

cc @renaynay  for thoughts


[firestore-bigquery-export] Add lifecycle event

Adds lifecycle event to export existing documents to BigQuery
TODO

[x] Docs review from @kevinthecheung - done in firebaseprivate
[x] Update package-lock.json once<EMAIL_ADDRESS>is published
[x] Code review
[x] Republish and test to ensure that nothing broke while switching to published deps
[ ] Decide whether to deprecate or fully remove old import script
[x] Test this lifecycle hook more thoroughly - I don't have a great understanding of how the BigQuery import script should behave, so I'd like an extra look at this. Do we need to make more changes to make the import code idempotent?
[x] Should we add an onConfigure hook here too?

@joehan The onConfigure would be very useful, ideally we could use this to move the tables creation/update into the events. With this we would no longer be required to create/update the tables on each record written, which would support a few performance issues!

All lifecycle hooks are included in this update.
For update and reconfiguration, the option is there to not perform the backfill. The question could be whether this enough for users to know that this will cause a new import if the value is not update?

The best discussed option here is still still allow the Import script, as this is currently built into many developers workflows.
This could be still deprecated in the future


[DropdownMenu] Document that the z-index is shared between Content and Portal

Documentation
I was looking for how to set the z-index on the Portal of the DropdownMenu, and only by shear luck - and an eagle eyed colleague - did we notice that it was shared (the z-index set on the Content was lifted to the Portal), from the elements devtool view.
Can we please make note of this in the docs so it is clear?
Relevant Radix Component(s)
Dropdown menu (and any other that also do this, if applicable)

Absolutely, thanks for raising @LewisAlderman

Just to add some clarity on this, it isn't technically shared between Portal and Content but rather the Portal part doesn't render an element and so uses the Content element itself as the portal node in body. Hence you set the z-index styles on your Content part and you're done.
What you might be seeing is rather for components that are "placed" via our Popper abstraction (like Popover, DropdownMenu, etc) there is an extra wrapper for the positioning which users don't have access to, so to ensure correct z-index, we automatically "copy" the z-index you set on Content onto the parent wrapper which handles positioning as it's the higher up one that matters.
But it's a good shout that we can add a note as to where to apply z-index 👍


Fix failing tests

Thanks for this! I'll be adding this soon along with @httpdop's changes too. It won't be the exact hash of this, so this PR will probably get closed, but rest assured you'll get credit :)
I can't believe a HashMap was used, reversed and then thought iteration would be "ok". I bet we were just getting lucky. I've run the git blame but I'll leave that for the code gremlins to discover :)
Here: have this: 🍺
PS: You made the files executable.

Closing this PR since I've put the changes on master. Thanks again.

PS: You made the files executable.

Haha, I'm using Git Bash on Windoze, not sure how/why it changed the filemode, wasn't intentional.
No need for credit, just like to get stuff working :)


Revert "set deployment API to apps/v1 if k8s >= 1.9"

This reverts commit a226971e4d7bb06850704b7c86ca463ff1b77fec.
Users on GKE experience an issue with this change, because the cluster Minor version is usually (9+) or (11+) not parseable in semver. #92
Users on AKS experience an issue with this change that disables deis ps:scale #93 – the cause is unknown, since AKS version numbers are parseable; the error message in the linked issue seems to indicate that "Scale" has moved, so I'm not sure it's as easy as this PR makes it out to be.  In earlier versions, the Scale resource was under extensions/v1beta2 with the Deployment resource.  In this version, it looks like it lives in the autoscaling/v1 API group.
This is a problem because our code assumes that the Scale resource/kind lives in the same API group as the Deployment kind, now apps/v1 – they don't live together anymore, and I wasn't able to find the lines of code representing this assumption, unfortunately.  (They're in here somewhere.)
(Has anyone tested ps:scale on any cluster above 1.9 with this change? I think I understand this change was made to support Horizontal Pod Autoscaling, so it stands to reason that maybe nobody has.  If everyone who has this change uses HPA, then maybe nobody would have needed ps:scale.  I'm not using HPA, and I still use ps:scale, so this affected me on my AKS cluster with versions: Major:"1", Minor:"11", GitVersion:"v1.11.5" and BuildDate: BuildDate:"2018-11-26T14:31:35Z")
It just looks a bit like we didn't do all our homework on this one.  I'm trying to find a good document about how the "v1" API itself is defined, and exactly what named groups are included in it (apps/v1, autoscaling/v1, etc) – and whether this is actually a well-defined thing, with clear lines between "what is in v1" and "what isn't in v1", or if there's a possibility that more named groups will sneak into v1 in later releases, or if it depends on implementation/cloud provider, etc.  So far coming up empty.
I added a branch that is incomplete which provides access to the kubectl api-versions output, or "get_api_versions" as it's sometimes called in k8s client libraries.  But it looks like that by itself is not enough, and I'm miserable at Python, so no idea how to start with interactively debugging.  I found this gist which says you can use this line, as a surrogate for Pry (I'm a ruby programmer, so binding.pry is one of the go-to tools in my arsenal.)
import code; code.interact(local=dict(globals(), **locals()))

Haven't tried that yet.  Maybe it will help me make more progress.  I think I will need a controller running interactively to facilitate that, so I'm stuck for now.  I think we should revert the change from #86 and cut a release v2.20.2, so that new users coming in using GKE and AKS (and probably others) are not stuck with issues until they find this blog post about how to revert the controller to v2.20.0: https://blog.teamhephy.info/blog/posts/announcements/rollback-v2-20-1-v2-20-0-controller-GKE-bug.html
I would think that it makes sense to look for autoscaling/v1 in the APIs endpoint, but it's more complicated than that.  I think that later k8s versions omit a lot of the named groups and assume that you know what is in v1.  I will find an example of a k8s version that does this, but what I'm expecting is that the controller will have to deal with a return from GET /apis which just contains v1 and doesn't call out any named groups.

Testing... reverting this commit indeed brings back manual scaling
Built the image at kingdonb/controller:canary
$ deis ps:scale web=3
Scaling processes... but first, coffee!
done in 35s
=== rocksolidapp Processes
--- web:
rocksolidapp-web-5cc7fd55bd-44qsd up (v5)
rocksolidapp-web-5cc7fd55bd-8js7h up (v5)
rocksolidapp-web-5cc7fd55bd-sjhkq up (v5)

Thanks @kingdonb for the image! For those looking for a patch in the interim, this worked for me:
kubectl -n deis patch deployment/deis-controller -p '{"spec": {"template": {"containers": [{"image": "kingdonb/controller:canary"}]}}}'

Thanks for the feedback! I see this was merged on Sunday, should land soon on Docker Hub at: hephy/controller:v2.20.2 (so you won't need to patch your clusters with something called "Canary")

New release is out tonight. Users can upgrade to Hephy Workflow v2.20.2 and it should have the rollback of the controller. Thank you for this PR @kingdonb .


Move create/edit dialog for modeling exercise to a separate page

Checklist

[x] I tested the changes and all related features on the test server https://artemistest.ase.in.tum.de.
[x] I documented my source code using the JavaDoc / JSDoc style.
[x] I added integration test cases for the server (Spring) related to the features
[x] I added integration test cases for the client (Jest) related to the features
[x] I added screenshots/screencast of my UI changes
[x] I translated all the newly inserted strings

Motivation and Context

This PR solves the #777 issue for Modeling Exercise.
Description

Changed create/edit dialog into a page and separated titles for this cases.
Steps for Testing

Log in to Artemis
Navigate to Course Administration
Select Exercise in one of the Courses.
Create new Modeling Exercise
Edit existing Modeling Exercise.

Screenshots

Creating Exercise

Editing Exercise

Great that you moved the create/edit dialog to a separate page. It looks really great now :)
I have found one issue: if you go to course administration and click on 'View' for the modeling exercise and then try to edit it, the error Error: Uncaught (in promise): Error: Cannot match any routes. is thrown.
(I have noticed one smaller issue with the category tags (if you add tags and edit the exercise again, you can't see the existing ones). I know that it's not part of this PR, but since you're working with these pages, maybe you can fix that in another PR?)

Thank you, for the review. I fixed the issue with View dialog, I didn't notice before that the route was still incorrect.
Regarding the issue with category tags I can definitely address it in a next PR.


fix: add missing impl for withdrawing tx fees

Task linked: CU-2p79uye Upgrade to polkadot-v0.9.26


2nd order finite differences to compute forces

We need to improve the numerical methods to solve the field equations. This pull request include 2nd order finite differences to solve the Poisson eq.

pw-008.pdf
Correcting the forces in k-space for the CIC interpolation/sampling do not solve the problem.

There seems to be something wrong with the 2nd order Finite Differences method proposed here.

Bug fixed: 2 ghost cells where necessary.

Notice that the small 2% difference with respect to gadget is already reduced with the use of a 2nd order FD.

If the CIC correction (p=4) is applied, the power spectrum approximates better to Gadget's

TreePM with the 2nd order finite differences:


Use notify-build-status action

Details
Use apm-pipeline-library's notify-status-build action.
Will look something like this:

(Sorry, was watching the wrong slack channel, please ignore my review 😅 )


Pinpoint lowers cpu usagent

in my netty server not add pinpoint this picture show cpu used

and that is add pinpoint cpu use very low

#3343
I believe that isn't the case. check referred issue


Icons for Delete submenu

We should only have the trash icon on the submenu itself, not the items in the submenu.  The one on "Delete Messages Before" should get removed:
https://github.com/tarasglek/chatcraft.org/blob/65597c70b3d0e484a4400a0836e39678aff871a3/src/components/Message/MessageBase.tsx#L550
Someone new to the project that wants to get started contributing should take this.

Hey Can I pick this?

@humphd Fixed the issue Please review and lmk


lib: Add a function to filter sources by regular expressions.

Branch as discussed on the mailing list @basvandijk. Discussion points:

If we following the one existing naming example sourceFilesBySuffices this should be called sourceFilesByRegexes but I find that quite untypeable.
I can't figure out how to add or run tests in lib/tests.nix - any ideas?

As I mentioned on the mailinglist the following implementation might be more efficient:
{ sourceByRegex = src: regexes: builtins.filterSource (path: type:
      let relPath = lib.removePrefix (toString src + "/") (toString path);
      in builtins.match (concatStringsSep "|" (map (r: "(${r})") regexes)) relPath != null)
    src;
}

But I'm not sure so this has to be benchmarked. But we can always do that later.
Regarding tests, I see there's <nixpkgs/lib/tests/release.nix>. Maybe you can hook up a test in there?

I'm not a huge fan of concatStringsSep "|"  because that breaks when users use | in their own regex. If speed becomes an issue I think we should move this to builtins. What do you think?

I did put parenthesis around the individual regexes so that the | from users didn't clash. Although I agree that speed isn't a big priority now.

nix-build pkgs/top-level/release.nix -A lib-tests does something but it always succeeds, even if I intentionally break a test.
Even with parenthesis I can write )|( . It's unlikely but I don't feel we need to introduce a potentially unsound behaviour when the number of regexes is usually pretty small, and we always have the escape hatch of introducing a builtin.

Ok agreed.


Enable Easy queue to be matched with Easy.* queue (as well as other Complexity)

Matching Service
E.g., Easy queue can be matched with any of the EasyPython, EasyJava or EasyC++ queue. However, the contrapositive is not true.

We have decided not to go with this way


Training using Nvidia A100 GPU

Hi, i'm using one A100 GPU to train PICK and i've set distributed to false.
[2022-06-08 01:41:58,561 - train - INFO] - One GPU or CPU training mode start...
[2022-06-08 01:41:58,565 - train - INFO] - Dataloader instances created. Train datasets: 100 samples Validation datasets: 20 samples.
[2022-06-08 01:41:59,276 - train - INFO] - Model created, trainable parameters: 68571598.
[2022-06-08 01:41:59,277 - train - INFO] - Optimizer and lr_scheduler created.
[2022-06-08 01:41:59,277 - train - INFO] - Max_epochs: 35 Log_per_step: 20 Validation_per_step: 100.
[2022-06-08 01:41:59,277 - train - INFO] - Training start...
[2022-06-08 01:41:59,289 - trainer - WARNING] - Training is using GPU 0!
I've been struck here for so long and after 10-15 mins, it throws CuDNN error. any solution?
cuda version = 10.1 and pythorch = 1.5.1+101

@ajaysurya1221 A100 has Ampere architecture with so-called computational capabilities of sm_8x. Some parts of the cuda computations are not running the way they should under cu101 as required in PICK's implementation. You can try different Pytorch versions with different cuda (e.g., cu111).
You will experience different issues with that library as well on the decoder side of the model. There are a few quick patches that you can utilize to avoid those issues as well.


add spec for file arguments and fix the method repeat.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Mohamedali10 Looking good! Can you please run scalafmt to format the sources? This should help fix the failed build.

@jdegoes all checks have passed now, thanks

@Mohamedali10 Thank you, great work on this!

@jdegoes I will try to work on other issues when I have time.


Merge remote-tracking branch 'origin/CB-2.48.0' into master

See detailed description in the commit message.

i have added an extra revert commit to not change runtime version for its to 7.2.10 from 7.2.12


A port for debugging and stepping into the code

When running the service locally it would be helpful to step into the code. This is possible when using SAM but not when we use container images and run the function using RIE.
Can you add a debug port mapping to be used? It can be enabled and disabled via the environment variable.
For example, when running usual java apps we can add  -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 to the run command and then listen to 5005 to be able to step into the code.
I have previously created a ticket in the aws-lambda-runtime-interface-emulator project. It was suggested that I reach out here instead.

I am interested in this as well, I use CDK with docker lambdas and most info on this is suggesting to use SAM, but I'd rather not take on another dependency.
It would be great to be able to add this to the base image or pointers on how to set this up yourself.

you can add into environment variable
NODE_OPTIONS='--inspect-brk=<IP_ADDRESS>:9229'


pfs+curve sdk document

Signed-off-by: Cyber-SiKu<EMAIL_ADDRESS>

@Cyber-SiKu This commit should be merged into POLARDB_11_DEV. Also, a conflict should be resolved.

ok

@Cyber-SiKu 4 more configuration files should also be updated, or else the page cannot be indexed. See the example here.

4 more configuration files should also be updated, or else the page cannot be indexed. See the example

fix

/rebase-and-merge


Additional: cifES

Bug when codes beginning with lower case letter.

Description

Thank you!

I went to the Wikipedia link provided in the source code, and then to the referenced documents at the "Agencia Estatal Boletín Oficial del Estado".  Although all the examples show an upper-case letter, I saw nothing that said it was required to be upper-case.
Full discretion, I'm functional in Spanish, and use it almost every day in some way, but I'm far from fluent.  I stand to be corrected.

Hello @RobJohnston ,
As you said is not required that the NIF uses upper-case letters only.
The problem with the actual code (and wich this pull request solves) is that the current regexp only works with upper case letters.
If you see the detail of the PR, the change only applies upper-case transformation to the NIF letter in order to match the existent regexp and solve the validation problem that exists in case that is specified a NIF with lower-case letter.
Regards.


Add legal-frontend and claim-store to prod

Adding missing CMC projects - MichaelO is taking care of adding nightly security scanning e.g.:
https://github.com/hmcts/cmc-claim-store/pull/764

Sorry @timja - I'm adding these now instead 😬


Diagnosis fields

In Progress. Fixed Patient-slice test file. Wanted to make sure passes tests on github and let maintainers know I am still working. Need to fix blank date bug (which I believe is in other parts of the project as well), and rewrite the diagnosis test files.

Might want to make the abatement date optional, but will save that for another issue/pull request.


beta 2.0 label

Noticed a container offset issue when trying to edit or move a label generated by the Toolbar 2.0.  See screenshot.

@leeyuanjuan  , please give this a try:
Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.
Also, make sure you're using Sketch v53.2 (72643).
Get the Fork version (v2.8.0)
Download from sketch-measure-latest
Still not working?
Follow the steps below:

[ ] Uninstall the plugin
[ ] Quit Sketch
[ ] Follow the steps bellow to remove the PluginsWarehouse folder
[ ] Download the latest zip file from the fork
[ ] Reinstall the plugin
[ ] Test the Mark Properties / Spec Export again

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

Go to the Finder of Mac OS
From the “Go” menu navigate down to “Go to Folder” or...
Hit Command+Shift+G from the Mac OS X desktop or a Finder window
Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
Remove/Delete the PluginsWarehouse folder

A note on Toolbar 2.0 (beta)
Some functions won't work as proper with the Toolbar 2.0 (e.g.: Text Styles will not output).
Although I've added the SMFramework from the latest v2.7.7 released by @utom, it uses a compiled codebase done in XCode that I don't have access to make changes.
Let me know how it goes 😊
If after all this it still doesn't work, please share a small sketch example file (doesn't need to be your actual design file) that you can reproduce the bug and I'll take a look.


Running haddock in reverse?

Here is my understanding of how haddock works now:
Haddock takes some text like this:
-- |The 'square' function squares an integer.
square :: Int -> Int
square x = x * x

And returns some HTML describing square.
I would like to sort of do this in the opposite direction. Given two inputs,
square :: Int -> Int
square x = x * x

and
"The 'square' function squares an integer."

I would like to retrieve:
-- |The 'square' function squares an integer.
square :: Int -> Int
square x = x * x

This obviously is pretty easy if the only thing necessary is putting the documentation in front of a tld. But I would like to be able to do this with all the kinds of documentation Haddock supports (class methods, function arguments, etc.).
If this is not possible I would be interested in contributing this functionality. I think it would be useful for writing UIs to make it easier to write documentation. However I'm unfamiliar with the haddock code base so I might need a nudge in the right direction

Here is my understanding of how haddock works now:
Haddock takes some text like this:
-- |The 'square' function squares an integer.
square :: Int -> Int
square x = x * x

And returns some HTML describing square.

At a very high level, that is true. Under the hood, however, Haddock doesn't do much of the text-level processing. Instead, we depend on ghc-the-library to parse the code and comments. Most of Haddock's code is concerned with rendering nice looking HTML (and some other formats) as well as parsing and rendering markup in the doc comments.
I'm not clear on the precise nature of the inputs for the functionality that you propose (for instance, how would one decide that the string "The 'square' function squares an integer." should be associated with the function square and not, say, the function circle?) or what end goal you have in mind.
Since you will need to parse and pretty-print Haskell code, you may want to depend on ghc-the-library, in which case Haddock's code might be a good example of setting up the necessary configuration options. Alternately, you could use haskell-src-exts library, which has a much simpler API.

Closing for now, feel free to re-open with a more concrete request.

Closing for now, feel free to re-open with a more concrete request.


Adds 4 Linear Algebra links (Better Explained).

Adds 4 links to Kalid Azad's articles on Linear Algebra topics, from his website Better Explained https://betterexplained.com

This is fantastic! What a great blog, I'm so happy you added these. It doesn't quite fit the format so I'll refactor after merging. Thank you for contributing!


Introduce change log

If there are no objections I'll add a changelog markdown document soon. After that is merged we should expect that the author of a new pull request adds new changes to that document, or the person that merges the PR should add the information to the change log itself.

Where is actual changelog detailed ? In only found this one.
I think it would be cool if @katspaugh could write in in the releases page. :P

@X-Raym it's at the root of the repository, CHANGES.md. I think @katspaugh will copy/paste from there into releases each time.

@thijstriemstra oh yes ok, I was looking for a changelog which already add info on it hehe :P
anyway, this markdown file is a great initiative.


long_schedule warning happened

Environment

OS: CentOS 7.4
Erlang/OTP:
EMQ: 2.3.5 (docker image)

Description
console log

2018-03-23 16:07:34.900 [warning] <0.1341.0>@emqttd_sysmon:handle_info:99 long_schedule warning: pid = <0.21027.24>, info: [{timeout,249},
{in,{prim_inet,ctl_cmd,3}},
{out,{prim_inet,ctl_cmd,3}}]
[{initial_call,{proc_lib,init_p,5}},{current_function,{prim_inet,ctl_cmd,3}},{registered_name,[]},{status,running},{message_queue_len,1},{group_leader,<0.1163.0>},{priority,normal},{trap_exit,false},{reductions,190403074},{last_calls,false},{catchlevel,2},{trace,0},{suspending,[]},{sequential_trace_token,[]},{error_handler,error_handler},{memory,6993120},{total_heap_size,833047},{heap_size,833026},{stack_size,8},{min_heap_size,233}]

The utilization of CPU on my server was up to 100%
On what condition this warning might happen?

The long_schedule warning will be reported, if a process in the system runs uninterrupted for at least Time wall clock milliseconds.
The Time can be specified in the emq.conf, default is:
## Enable Long Schedule(ms) monitoring.
##
## See: http://erlang.org/doc/man/erlang.html#system_monitor-2
##
## Value: Number
sysmon.long_schedule = 240

@dingzhengkai What were you doing at that time? Were you publishing a lot of messages to EMQ and decode them in your plugin? Decoding large messages such as JSON using NIFs might cause this kind of problem.
Or your server was too busy at that time? The warning would also be reported if you run EMQ on a very busy server.

@terry-xiaoyu @HJianBo thanks for reply.
At that time, the utilization of cpu on my server was almost up to 100%(the emq erl process), but my server(or the emq server) did not run a lot of tasks, so i thought whether there was something wrong in emq.
My server was up about 60 days, i rebooted it to solve the problem.


Update react & react-dom to 15.1.0

Update react & react-dom to latest version - 15.1.0

Please try out version 0.0.3-beta3.

Done as of 0.0.3-beta6.


Visualization of high-dimension vector field

Hi,
Thanks for deliverying this amazing work!
I'm think about visualization the vector field of my model, however, it is a high dimensional one with shape [16, 16, 256].
Do you have any idea abou how to visualization it?
Cheers,
Hilbert

Hi Hilbert, thanks for your message! Unfortunately it is difficult to visualize high dimensional vector fields and I don't think there is a single good solution for this. You could try to visualize it slice by slice or use some dimensionality reduction techniques. Good luck!

Hi Hilbert, thanks for your message! Unfortunately it is difficult to visualize high dimensional vector fields and I don't think there is a single good solution for this. You could try to visualize it slice by slice or use some dimensionality reduction techniques. Good luck!

Hi Emilien,
I think you are right.
I've tried the dimensionality reduction techniques, however, as I reduce the dimension of latent space to 2D, most ofthe information is lost.
Cheers,
Hilbert


PreviewData is Empty and no preview

The following code is placed on my StatefulWidget.
    LinkPreview(
      enableAnimation: true,
      onPreviewDataFetched: (data) {
        print(data);  // data is empty
        setState(() {
          httpdata = data;
        });
      },
      previewData: httpdata,
      text: s, // the url is passed here
      width: MediaQuery.of(context).size.width * 0.7,
    ),

Called with two URLs on the Web platform I get the following response in the data parameter and (of course) no preview is shown, but why is the PreviewData object empty? I have a feeling that the data are never fetched because of an async call somewhere in the flutter_link_previewer library?
_PreviewData(null, null, https://dr.dk, null)
_PreviewData(null, null, https://tv2.dk, null)

An error comes in getPreviewData  when http.get is called and it goes to the catch block.
[log] XMLHttpRequest error.

Please have a look at this post for solving the problem: dart-flutter-http-request-raises-xmlhttprequest-error as it is probably the issue???

I figured it out.
Running from a mobile platform it works, but from web it does not.
The reason was because of cross cors.
headers: {
  "Access-Control-Allow-Origin": "*",
  "Content-Type": "application/json",
  "Accept": "*/*"
}

Adding the option using such headers might be an idea?  @demchenkoalex


Add support for HTTP and WebSocket server

This will be important for developing web apps. Ideally, the logger would be able to handle a stream of server events. It might be tricky, if there are multiple long-running processes happening at the same time (e.g. file watcher and network listener).

Implemented with #26


Merge remote-tracking branch 'origin/dcba9d4'

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/110838&drop=dogfoodAlpha

I did not use the PR template as this is not for a package, rather a fix in the code.


Android Basics: Introduction to Room and Flow

In section 8. Create the ListAdapter
busStopAdapter.submitList(viewModel.scheduleForStopName()) missing parameter for scheduleForStopName method.
Should to pass stopName.

Thanks for pointing this out! We'll be closing this issue in favor of this issue that describes the same error:
https://github.com/google-developer-training/android-basics-kotlin-bus-schedule-app/issues/32
In the mean time, feel free to refer to the main branch which contains the correct code


Cohesion time on page (PLATFORM-2414)

Changed time on page events to fire using cohesion standards
collaboration with @jo-rs
Review app: https://new-time-on-page.artsy.net/

extracts trackEvent to helper. We already use to grab action names from react-tracking, and because events in Cohesion use the same schema as v2/reaction events, we can use this helper to ensure the schema is correct rather than firing to window.analytics directly.
extracts timeOnPageListener

Review app has been Qa'd and is ✅ - thread here: https://artsy.slack.com/archives/C015KTU8RQT/p1596060659009300


Support for HftL

HftL uses QIS as well (https://qis.tel.hispro.de/qisserver/rds?state=user&type=0) so should be easy to integrate.
I might create a PR soon.
Edit: After looking a bit closer at the code I realized it's better to create the issue over at mygrades-server :grin: => Closing. Sorry.

Hey, no problem. Just create a new one at mygrades-server.
The code you're probably looking for is here, there you can create a new file for the HftL.
The repository is still missing some installation guides, so if you need help, please reach out to<EMAIL_ADDRESS>Thanks! :)


Backport: "remove ceph-iscsi-gw play from site.yml.sample #1589"

backport of #1589

CI failures here are not related to this PR.


Expand lookup order

Can't find a spot where the lookup order for cli and environment are, so added it here. Please fell free to deny this request or change it as you see fit.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We have moved the Hugo site source to its own repository, so we would appreciate if you could open this PR directly in hugoDocs:  https://github.com/gohugoio/hugoDocs/pulls
Also, if you consider the config directory, the lookup order for config is slightly more elaborated.


NodeGoat Research page SSRF also enables DoS

The research page intentionally exposes a SSRF vulnerability which allows an attacker to submit unexpected url and query params. The tutorial demonstrates how this can be used to make the server connect to an attacker-controlled site.
As well as this expected vulnerability there's a bug in app/routes/research.js which crashes the server if the request to that target URL fails.
This happens when visiting (eg) http://localhost:4000/research?url=localhost%3A4001%2F&symbol=login while the server is running locally on port 4000:
[...]\app\routes\research.js:23
                res.write(newResponse.body);
                                      ^

TypeError: Cannot read property 'body' of undefined
    at [...]\app\routes\research.js:23:39
    at done ([...]\node_modules\needle\lib\needle.js:442:14)
    at ClientRequest.had_error ([...]\node_modules\needle\lib\needle.js:452:5)
    at ClientRequest.emit (events.js:310:20)
    at Socket.socketErrorListener (_http_client.js:426:9)
    at Socket.emit (events.js:310:20)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

What's happening is that the needle callback skips setting the content-type when there's an error, but still tries to append newResponse.body to res. If there's an error, newResponse is undefined and the server crashes.

@rcowsill Thanks for reporting this issue and identifying the root cause. Yes, there should be a check for  undefined value of newResponse. I'd be happy to merge a PR in case you have bandwidth to fix it.

@rcowsill Thanks for reporting this issue and identifying the root cause. Yes, there should be a check for  undefined value of newResponse. I'd be happy to merge a PR in case you have bandwidth to fix it.


gem install hermann -v '0.20.1' failing

I'm trying to install the hermann gem on OS X Yosemite Version 10.10.2, but it isn't working :( .
gem install hermann -v '0.20.1'
Building native extensions.  This could take a while...
ERROR:  Error installing hermann:
	ERROR: Failed to build gem native extension.

    /Users/sdaswani/.rvm/rubies/ruby-1.9.3-p551/bin/ruby -r ./siteconf20150326-6859-16ln9w0.rb extconf.rb
Library Dir: /Users/sdaswani/.rvm/rubies/ruby-1.9.3-p551/lib
Include Dir: /Users/sdaswani/.rvm/rubies/ruby-1.9.3-p551/include
Downloading 0.8.4.tar.gz (100%) ding 0.8.4.tar.gz
Extracting 0.8.4.tar.gz into tmp/i686-apple-darwin11/ports/librdkafka/0.8.4... OK
Running git apply with /Users/sdaswani/.rvm/gems/ruby-1.9.3-p551/gems/hermann-0.20.1/ext/patches/librdkafka/0006-Update-some-headers-to-include-the-right-headers-to-.patch...
Running 'patch' for librdkafka 0.8.4... OK
Running 'configure' for librdkafka 0.8.4... OK
Running 'compile' for librdkafka 0.8.4... OK
Running 'install' for librdkafka 0.8.4... OK
Activating librdkafka 0.8.4 (from ports/i686-apple-darwin11/librdkafka/0.8.4)...
creating Makefile

make  clean

make
compiling hermann_lib.c
couldn't understand kern.osversion `14.1.0'
hermann_lib.c: In function ‘msg_delivered’:
hermann_lib.c:118: warning: comparison between pointer and integer
hermann_lib.c: In function ‘consumer_consume’:
hermann_lib.c:411: warning: format not a string literal and no format arguments
hermann_lib.c: In function ‘producer_push_single’:
hermann_lib.c:555: warning: assignment makes integer from pointer without a cast
hermann_lib.c: In function ‘producer_tick’:
hermann_lib.c:646: warning: format not a string literal and no format arguments
hermann_lib.c: In function ‘producer_connect’:
hermann_lib.c:670: warning: passing argument 4 of ‘rd_kafka_metadata’ from incompatible pointer type
linking shared-object hermann/hermann_lib.bundle
couldn't understand kern.osversion `14.1.0'
ld: targeted OS version does not support use of thread local variables in _rd_kafka_op_reply for architecture x86_64
collect2: ld returned 1 exit status
make: *** [hermann_lib.bundle] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/sdaswani/.rvm/gems/ruby-1.9.3-p551/gems/hermann-0.20.1 for inspection.
Results logged to /Users/sdaswani/.rvm/gems/ruby-1.9.3-p551/extensions/x86_64-darwin-14/1.9.1/hermann-0.20.1/gem_make.out

For additional context, since @sdaswani-lookout and I discussed this over IM. He can in fact build librdkafka 0.8.4 standalone on his machine

Without a reproduction case, I'm going to close this for now. We're on a newer version of librdkafka and I've not seen other similar reports.
@sdaswani-lookout let me know if you find this behavior still exists with the current released version


[build] macos build failed to run Apple m1

trying to build libmediainfo for homebrew, but failed to run against the library as some error show below:
Undefined symbols for architecture arm64:
  "MediaInfoLib::MediaInfo::Get(MediaInfoLib::stream_t, unsigned long, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, MediaInfoLib::info_t, MediaInfoLib::info_t)", referenced from:
      _main in test-4efa00.o
  "MediaInfoLib::MediaInfo::Open(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)", referenced from:
      _main in test-4efa00.o
ld: symbol(s) not found for architecture arm64

I am running on Ventura ARM, and let me know I need to provide more info

Probably just need to #define _UNICODE at the top of the source file when building/linking against mediainfolib, as described at https://sourceforge.net/p/mediainfo/discussion/297610/thread/db175ffe96/#5bf8/abaf.

Thanks to @alebcay's test update, resolved on my end :)


Unit tested JS files according to karma setup

It looks like you targeted the develop branch this time, which is good, but this one still mixes in the linting changes. Can you please close this PR and open a new one with only one set of changes?

These changes adds up on my previous linting changes. So will make PR again once those are merged.


add splits per port (Packet Browser)

packet browser seems to have lost its per port split functionality. need to add it back in

duplicate, fixed


input-output-hk/plutus-apps#1078 Repro

Description
Running 1 test suites...
Test suite cardano-api-test: RUNNING...
Cardano.Api
  Test.Cardano.Api.SerialiseTextEnvelope
    unsigned tx envelope:      FAIL (0.02s)
        ✗ <interactive> failed at test/Test/Cardano/Api/SerialiseTextEnvelope.hs:20:26
          after 1 test.
          shrink path: 1:

             ┏━━ test/Test/Cardano/Api/SerialiseTextEnvelope.hs ━━━
          19 ┃ tryReadEnvelope :: TextEnvelope -> H.PropertyT IO ()
          20 ┃ tryReadEnvelope = void . H.evalEither . first displayError .
             ┃ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
             ┃ │ "TextEnvelope type error:  Expected one of: Tx AlonzoEra, Tx BabbageEra Actual: Unwitnessed Tx BabbageEra"
          21 ┃   deserialiseFromTextEnvelopeAnyOf
          22 ┃     [ FromSomeType (AsTx AsAlonzoEra) (InAnyCardanoEra AlonzoEra)
          23 ┃     , FromSomeType (AsTx AsBabbageEra) (InAnyCardanoEra BabbageEra)
          24 ┃     ]

          This failure can be reproduced by running:
          > recheckAt (Seed<PHONE_NUMBER>0588185404<PHONE_NUMBER>1387351559) "1:" <property>

      Use "--pattern '$NF ~ /unsigned tx envelope/' --hedgehog-replay '1: Seed<PHONE_NUMBER>0588185404<PHONE_NUMBER>1387351559'" to reproduce from the command-line.

      Use -p '/ tx envelope/&&$0=="Cardano.Api.Test.Cardano.Api.SerialiseTextEnvelope.unsigned tx envelope"' to rerun this test only.
    signed tx envelope:        FAIL
        ✗ <interactive> failed at test/Test/Cardano/Api/SerialiseTextEnvelope.hs:20:26
          after 1 test.
          shrink path: 1:

             ┏━━ test/Test/Cardano/Api/SerialiseTextEnvelope.hs ━━━
          19 ┃ tryReadEnvelope :: TextEnvelope -> H.PropertyT IO ()
          20 ┃ tryReadEnvelope = void . H.evalEither . first displayError .
             ┃ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
             ┃ │ "TextEnvelope type error:  Expected one of: Tx AlonzoEra, Tx BabbageEra Actual: Witnessed Tx BabbageEra"
          21 ┃   deserialiseFromTextEnvelopeAnyOf
          22 ┃     [ FromSomeType (AsTx AsAlonzoEra) (InAnyCardanoEra AlonzoEra)
          23 ┃     , FromSomeType (AsTx AsBabbageEra) (InAnyCardanoEra BabbageEra)
          24 ┃     ]

          This failure can be reproduced by running:
          > recheckAt (Seed<PHONE_NUMBER>8600810554<PHONE_NUMBER>665831511) "1:" <property>

      Use "--pattern '$NF ~ /signed tx envelope/' --hedgehog-replay '1: Seed<PHONE_NUMBER>8600810554<PHONE_NUMBER>665831511'" to reproduce from the command-line.

      Use -p '/ tx envelope/&&$0=="Cardano.Api.Test.Cardano.Api.SerialiseTextEnvelope.signed tx envelope"' to rerun this test only.
    unsigned tx envelope cddl: OK
        ✓ <interactive> passed 100 tests.
    signed tx envelope cddl:   OK
        ✓ <interactive> passed 100 tests.

2 out of 4 tests failed (0.03s)
Test suite cardano-api-test: FAIL

Changelog
- description: |
    <insert-changelog-description-here>
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: <no-api-changes|compatible|breaking>
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: <feature|bugfix|test|maintenance>

Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] The change log section in the PR description has been filled in
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
roundtrip tests
integration tests
See Runnings tests for more details

[ ] Any changes are noted in the CHANGELOG.md for affected package
[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG node developers to do this
for you.

Closed as https://github.com/input-output-hk/plutus-apps/pull/1081 got merged


Make pedestrians walk through a list of waypoints

Hello all,
I am using 0.9.6 version and want to move pedestrians through a list of waypoints. However, with the current implementation what I understand is after the "go_to_location" method, once the pedestrian reaches the target, its next target is generated randomly.
I wanted to know if there is some functionality existing to make the pedestrian move through desired list of waypoints?
Thank you.

Any comments? I need this feature too.

I have the same question, and how can I replay trajectories of pedestrians in Carla?


fix(docs): fix formatting in falco binary section

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
The page https://falco.org/docs/install-operate/installation/#falco-binary have wrong formatting in the "Binary" section.

Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mavimo
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, mavimo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ad2551b0f02db647394bb62bc214f4790c517e7f

cc @vjjmiras

Closed in favor of https://github.com/falcosecurity/falco-website/pull/1257

/close

@leogr: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Linky sensor : cannot log to Enedis again

Hi !
It seems that the problem reappeared (see https://github.com/home-assistant/home-assistant/pull/17110 ) !
It worked fine for me until recently (1 or 2 weeks I guess).
And now it fails saying my password and user are wrong.
PyLinky version I have is 0.1.8. It is the latest right ?
I'm using it on a Synology NAS DS216j.
I modified the python source file to expose the user and names, and I can guarantee they are valid.
Trying to trace the execution, it seems that it fails finding the cookie iPlanetDirectoryPro. I checked with the debug options of my web browser, and locally I've got this cookie...
I've also checked the SunQueryParamsString, and it seems that it is good.
One thing though, now, when connecting on the Enedis webpage, it doesn't bring you to your user space, but it rather do several redirections (during these redirections the cookie seems to be not accessible) and brings to you to the website welcome page (iPlanetDirectoryPro) is then available.
Am I the only one with this issue ?

Seems pyLinky new version 0.2.1 fix an issue with login: https://github.com/Pirionfr/pyLinky/releases/tag/v0.2.1
Currently version 0.1.8 is used

I confirm, forcing pyLinky to 0.2.1 is solving the issue on my hass 0.88.0

Should be fixed by commit where pylinky is upgraded to 0.3.0

Sadly, the 0.89 does not fix the linky component
Now I had the following error:
linky: Error on device update!

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 248, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 348, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.7/site-packages/homeassistant/util/__init__.py", line 224, in wrapper
    result = method(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/homeassistant/components/sensor/linky.py", line 87, in update
    _LOGGER.debug(json.dumps(self._client.get_data(), indent=2))
  File "/usr/local/lib/python3.7/site-packages/pylinky/client.py", line 202, in get_data
    formatted_data[t] = self.format_data(self._data[t])
  File "/usr/local/lib/python3.7/site-packages/pylinky/client.py", line 142, in format_data
    start_date = datetime.datetime.strptime(data.get("periode").get("dateDebut"), "%d/%m/%Y").date()
AttributeError: 'NoneType' object has no attribute 'get

same issue here

same for me

I investigate on this issue and I fix the pb in the pylinky lib. PR is in progress.
Issue linked to hourly consumption which is not activate by default. As a workaround, you can activate hourly consumption in your enedis account.


luci-app-ddns: remove block-loading function

Load the massive ddns tools function adds 10s delay to luci interface, this cause every XHR requst that refresh every 5 second to fail. The "ddns" variable is not even used in index function, so it's just a waste of resource and cause lots of problem. By removing itall the delay problem are solved.
@jow-  another fix... remeber all my issue? well this was causing all the xhr error
Signed-off-by: Ansuel Smith<EMAIL_ADDRESS>

@Ansuel
is this still valid as individual optimisation, or superseded by #1819 ?

I can include this in the other pr if you want...
Removing this solve slow on every Luci page.
The other pr improve speed in the ddns page.

Suppressed by #1819

As stated in #1819
I did not check the patches but if it works it's fine for me.
Please increase PKG_RELEASE inside Makefile to reflect changes.
If you merge this pull before #1819 only one "increase" needs to be done
Many thanks

@chris5560  i included this to #1819  so this is not needed ;)


new */prometheuscadvisor redirect issue

Please make sure that the new */prometheuscadvisor is accessible for all deployments (ex. in aws staging, i can see there is similar problem with redirecting to */prometheus-cadvisor which causes problems) Thanks!

Thanks for the ticket.
This was fixed by re-dploying the monitoring stack everywhere.


Allow empty record patterns

Related to #3320, I noticed we cannot write matches over a record without specifying one of its fields. The pattern {} does not even parse, and will not desugar even if it did. I think this comes from when we really needed to resolve the fields immediately to find the record type, but now that we have unresolved record constructors and projectors, we definitely can allow empty patterns.
The patch seems easy enough and we can now write something like this:
type t =
  | A { x:int; y:int }
  | B { z:bool }

let is_A (x:t) : bool =
  match x with
  | A {} -> true
  | _ -> false

I don't think this should be controversial, so merging.


Design spec for Github Integration migration

Signed-off-by: Jesse Keating<EMAIL_ADDRESS>

Merge Failed! Help can be found at https://bonnyci.org/lore/end_users/use/#handling-merge-failures

Closing this as everything was already performed.


Randomly pad executions that overrun

We've had a couple of instances where the padding time wasn't sufficient for the execution time of the block. This causes sleep to raise an exception because of a negative sleep time.
This logs when we are insufficiently padding, and them always applies a random padding based on the execution time to make it harder to carry out timing attacks.

@tatyree This is what I came up with to avoid the 5XX error in pad_execution_time you found. Waddya think?

It occurs to me that this might actually not be a safe solution: repeating the same input would allow an attacker to eliminate the random component.

@threedaymonk A good point.
@ohmygauss: do you have any thoughts on how we might safely extend the time of an intended-to-be-constant execution when it overruns?

@SteveMarshall once we've heard back from @ohmygauss, could we get a couple of specs on this, please?

@tatyree Yeah, definitely. I might end up wanting to include Minitest::Benchmark so I can use assert_performance_constant  to test the timeliness of this, I think.

@SteveMarshall sounds like a plan.  At a minimum, I'd suggest something like this should pass:
  describe '.pad_execution_time' do
     it 'does not raise exception if padding time is lower than run time' do
        expect{
          controller.pad_execution_time 0.1 do
            sleep 0.2
          end
        }.not_to raise_exception
     end
  end

@tatyree :+1:

So pad time shouldn't be a random multiple of max_pad, but a fixed one. Through some load testing I'd imagine you would have a better idea of the worst case scenario. The pad time should be a fixed (smallest possible) multiple to account for the worst case scenario.
Ideally the intended padding time should account for exceptions.

@SteveMarshall based on @ohmygauss's comment, I vote we put in a test, a bit of logging and raise the padding on the current calls to 0.2 or 0.3 and see what happens.

If we are concerned about timing attacks and leaking key lengths why can't we just hash the inputs first (e.g. bcrypt) and then use ActiveSupport::SecurityUtils.secure_compare ?

Do you mean some kind of HMAC and then secure_compare?

@dan-palmer The argument against secure_compare is that we'd have to HMAC both sides (or something) before passing through secure_compare to avoid a timing attack.

@dan-palmer Oh, that's what you said :disappointed_relieved:

It seems we've concluded that padding the execution time is the wrong way to do this and, instead, we should generate HMACs for the inputs as I think we discussed when I was originally working on this. :sweat:


Capistrano bin/rails stub

Hello,
When I try to execute commands in cron, I get this error:
Looks like your app's ./bin/rails is a stub that was generated by Bundler.
In Rails 4, your app's bin/ directory contains executables that are versioned
like any other source code, rather than stubs that are generated on demand.
Here's how to upgrade:
bundle config --delete bin    # Turn off Bundler's stub generator
rake rails:update:bin         # Use the new Rails 4 executables
git add bin                   # Add bin/ to source control
I also have problems with capistrano deploy as you can see here:
https://github.com/javan/whenever/issues/431#issuecomment-43485781
Any suggestion?
Thanks

Is there anyway to prevent this?  It's kind of making the log files harder to read.