[HUDI-2879] Removing rfc from release package and fixing release validation script

What is the purpose of the pull request
In 0.10.0, we added rfc to hudi repo. these could contain images as well. These may not make sense in the release bundle and hence we need to remove it.
Also, fixed license check in validation script to ignore test fixture directory.
If not for rfc fix in this patch, I get below errors when trying to validate 0.10.0 RC1.
./release/validate_staged_release.sh --release=0.10.0 --rc_num=1 --release_type=dev
/tmp/validation_scratch_dir_001 ~/Documents/personal/projects/a_hudi/hudi/scripts
Downloading from svn co https://dist.apache.org/repos/dist//dev/hudi
Validating hudi-0.10.0-rc1 with release type "dev"
Checking Checksum of Source Release
		Checksum Check of Source Release - [OK]

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 45904  100 45904    0     0   135k      0 --:--:-- --:--:-- --:--:--  135k
Checking Signature
		Signature Check - [OK]

Checking for binary files in source release
There were non-text files in source release. Please check below

./rfc/rfc-39/arch.png: image/png; charset=binary

./release/validate_staged_release.sh --release=0.10.0 --rc_num=1 --release_type=dev
/tmp/validation_scratch_dir_001 ~/Documents/personal/projects/a_hudi/hudi/scripts
Downloading from svn co https://dist.apache.org/repos/dist//dev/hudi
Validating hudi-0.10.0-rc1 with release type "dev"
Checking Checksum of Source Release
		Checksum Check of Source Release - [OK]

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 45904  100 45904    0     0   142k      0 --:--:-- --:--:-- --:--:--  142k
Checking Signature
		Signature Check - [OK]

Checking for binary files in source release
		No Binary Files in Source Release? - [OK]

Checking for DISCLAIMER
		DISCLAIMER file exists ? [OK]

Checking for LICENSE and NOTICE
		License file exists ? [OK]
		Notice file exists ? [OK]

Performing custom Licensing Check
There were some source files that did not have Apache License
./rfc/rfc-39/arch.png
./hudi-utilities/src/test/resources/fixtures/testUpsertsContinuousModeWithMultipleWriters.MERGE_ON_READ.zip
./hudi-utilities/src/test/resources/fixtures/testUpsertsContinuousModeWithMultipleWriters.COPY_ON_WRITE.zip

Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure


Updated undeaD to get rid of deprecation warnings

Two builds failing, but that has nothing to do with this PR.


Please provide ES5 version of module

A lot of tooling and browsers are not ES6-ready. Please consider compiling to ES5 before publishing to NPM.
ES6 Example: https://github.com/Bilibili/flv.js/blob/master/src/utils/logger.js
More Information: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

The published npm package contains compiled & packaged es5 flv.js and flv.min.js in the dist/ folder.
Also provided in https://github.com/Bilibili/flv.js/releases

https://github.com/Bilibili/flv.js/blob/master/package.json#L5
I think it has no problem. It has pointed to compiled file.

Yes, that's exactly what happens and which triggers this issue in Webpack for me.
Steps to reproduce:

create-react-app foo
cd foo
yarn add flv.js
echo "import flvjs from 'flv.js'; flvjs.isSupported();" > src/index.js
yarn build

Oh I think in theory the whole flv.js src/ should be compiled and packaged together with your app through the webpack pipeline in this situation.
BUT pay attention that the depended webworkify package may not be compatible with webpack, because it was designed for browserify.

What happens is now: the vanilla ES6 is packaged and then minification fails for ES6. If you want to close this as Won't Fix I can understand.

So in my opinion, the flv.js src/ should be compiled through your own build pipeline, that's all.

Got it. Thanks for the swift reply!


Unable to create cluster after upgrading to 2.2.1 - ERROR: Unable to check AWS Account limits

Environment:

AWS ParallelCluster version: aws-parallelcluster-2.2.1
OS: alinux/MacOS

Bug description and how to reproduce:
pcluster create test
pcluster configure
After upgrading to 2.2.1 I am no longer able to create clusters, or even re-run the configure utility without encountering this error:
ERROR: Unable to check AWS Account limits. Please double check your cluster configuration.
No default VPC for this user

Additional context:
~/.parallelcluster/pcluster-cli.log :
2019-03-04 22:22:36,136 - DEBUG - pcluster.pcluster - Namespace(command='configure', config_file=None, func=<function configure at 0x7efe3b8f7938>)
2019-03-04 22:23:06,754 - DEBUG - pcluster.pcluster - pcluster CLI starting
2019-03-04 22:23:06,759 - DEBUG - pcluster.pcluster - Namespace(command='configure', config_file=None, func=<function configure at 0x7fad66286938>)
2019-03-04 22:23:48,901 - DEBUG - pcluster.pcluster - pcluster CLI starting
2019-03-04 22:23:48,907 - DEBUG - pcluster.pcluster - Namespace(command='configure', config_file=None, func=<function configure at 0x7fed693c5938>)

~/.parallelcluster/config:
aws_region_name = us-east-1

[cluster default]
key_name = <my_key>
vpc_settings = vpc

[vpc vpc]
vpc_id = vpc-d444ebaf
master_subnet_id = subnet-3e947c74
ssh_from = <my_ip>

[global]
cluster_template = default
update_check = true
sanity_check = true

[aliases]
ssh = ssh {CFN_USER}@{MASTER_IP} {ARGS}

AWS CLI:
aws --version
aws-cli/1.16.117 Python/3.6.2 Darwin/18.2.0 botocore/1.12.107

What I've tried:

Cluster creation and general management worked fine on the previous version (2.0.0), this only began happening after the upgrade.
Confirmed this both on my local machine (MacOS) and with an Amazon Linux 2 instance in AWS.
I do not have a default VPC, but I also did not have one before the upgrade.
I have tried this with IAM API Keys and an assumed role, both of which have AdministratorAccess

I know that with the new release, there was logic added to check AWS Account Limits.  Could that be related?    Please let me know if there's any further context I can provide.
Thanks,
Jack

Hi,
Please set sanity_check = false as a workaround so you can launch clusters. This is part of the logic we added to validate that you have the right limits.

Ok, the problem is coming from #L403
We do an ec2 dry-instance run to validate the account limits. It tries to use the default VPC as there's no VPC specified in the call. That's failing and we catch it and return that error.
For now the workaround is not using sanity_check = false, until we fix it.

Fixed by #911,
@privojack thank you for the feedback!

I'm trying to configure ParallelCluster for the first time, and I try to modify the config file to not do the sanity check, but it keeps setting it back.  Is there a way to configure it on initial configuration so that it doesn't do the sanity check?

Hi @hellmersjl3ds I created a new issue https://github.com/aws/aws-parallelcluster/issues/913 for your last question since it is not strictly related to the AWS account limits check error.


ParseJson hangs/extremely slow in new Excel version

With the newest version of Excel (64-bit), ParseJson now takes up to 5+ minutes to handle .json files compared to only seconds in the past.

Appears to have been an issue with Version 1710, now resolved in 1711.
I believe it was append and/or VBA.Mid that was causing the issue, as I could shave off time by trimming my .json down.
During the issue a 30,000+ character .json would take over 90s to parse, but now that it is resolved it is down to under a second!
Going to close the issue, but I do wonder if there's any better way to handle the parsing instead of character by character?

Sweet! There are probably more efficient ways, but I'm glad it's back down to a reasonable time.

Thanks for the reply!
One thing I was experimenting with while I was trying to shave off time was using InStr and InStrRev.
You'd have to use place markers, but something along the lines of
'Dim Quote1, Quote2 as Long'
'Quote1 =InStr(1, jsonstring, Chr(34))' to find a quote, then
'Quote2 = InStr(Quote1, jsonstring, Chr(34))' to find the closing quote, and then
'Mid(jsonstring, Quote1, Quote2 - Quote1)' to get what's in between.
Not sure if it'd be faster or not, but I might test it as I had already started the code for it :).


Add more scoring rules to Part II

Just add some more literature in conclusion for more losses people can look into


Add a test script

I think we should add a simple test script that executes each of the examples and makes sure that no error occurs during execution. IMO, attempting to test anything beyond this (e.g., an output baseline) would require too much work on the part of contributors.
There are two issues that I can think of that complicate this:

How do we execute an example?
I think the answer is that for each example, we convert the .ipynb file into a temporary script using the the commnd: jupyter nbconvert --to script [filename].ipynb. As long is we can install jupyter on Travis, this seems like a straightforward thing to do.

When do these tests get executed?
Obviously, when someone pushes a new example to this repo. However, we really want to be testing after pushes to the Pyomo/pyomo master branch, just like we should be testing Pyomo/pyomo after pushes to Pyutilib/pyutilib master. It looks like we are currently not doing this (with Travis / Appveyor at least), so it makes me think it is not currently possible. @whart222, @jsiirola : Do either of you know if this is possible?
I suppose it's also reasonable that we only test examples against the latest Pyomo release. Thoughts?

I've setup tests for the jupyter notebooks.  But these tests will not be run when Pyomo gets updated.  The only way that I know to do that is to move the notebooks into the Pyomo repos.  So, perhaps we should integrate this repos into the main Pyomo repos?

OK.  I figured out how to trigger the test after a successful build on Pyomo's master branch.  I'm closing this ticket.


Suggestion: Provide help for people coming from different languages

Allow users to specify that they are coming from another language java, javascript, etc,  Then provide language specify pointers when users language features that are different in their language.  This would be especially helpful when the same syntax yield different results or where there is a way to do something in one language that is easy but different in another.
For example:
the || javascript operator is roughly equivalent to the C# ?? operator.
If someone indicates they are coming from JS, and they make write something like
Console.WriteLine(firstName || lastName)
recognize the issue and suggest ??.

Adding @BillWagner to see if docs the teams has any thoughts on this. This is an interesting and useful request but, we need some insight from the content providers on the implementation.

We discussed this a bit at the user group last night. Doing this right involves both teams, and the site engineering team with @EisenbergEffect and @dend  to look at how to learn who a user is.
It's a great suggestion, we need to think through a design that surfaces the right information without introducing knows when we get it wrong.

adding @yunyunyunyun to the discussion since she's taking over the .NET REPL work

@yunyunyunyun have you had a chance to look over this?


PCFDEV deployment issue

Hi,
I am trying to deploy PCFDEV on a Win 8 machine. I have redirected the deployment path to my D drive and the ova and vmdk files are created there. There is plenty of space on that drive however my C drive has limited space of 10 GB. I am getting this error while the installation is ongoing:
Progress state: VBOX_E_FILE_ERROR
VBoxManage.exe: error: Failed to clone medium
VBoxManage.exe: error: Could not create the clone medium 'D:\Users\xxxxx\vmdk\vms\pcfdev-v0.436.0\pcfdev-v0.436.0-disk1.vmdk' (VERR_DISK_FULL)
VBoxManage.exe: error: Details: code VBOX_E_FILE_ERROR (0x80bb0004), component MediumWrap, interface IMedium
VBoxManage.exe: error: Context: "enum RTEXITCODE __cdecl handleCloneMedium(struct HandlerArg *)" at line 928 of file VBoxManageDisk.cpp
Can anyone help ?
Thanks.

If PCFDEV_HOME is set, the OVA should be downloaded directly into that directory? Can you tell us what directory on your C drive is filling up?

Closing due to inactivity.


[spi_device] abort_done implementation

abort_done is not implemented in the design. Add this functionality.

@eunchan will this feature be implemented. If so, what is timeline?

I think, this can be P3 item, good to have. So, I probably work on this in next revision or later. Please waive this item.

Triaged for spi_device. I think this is not necessary for this release and thus correctly labeled https://github.com/lowRISC/opentitan/labels/Type%3AFutureRelease.

CC @a-will

The notion of the device side being able to "abort" anything doesn't make sense to me. It is not in control of timing and software cannot reasonably time the effect of any CSR write here.
Besides, generic mode is being removed. Closing.


R113

Bad rows + R119

@chuwy can we document what impact the two patches would have on existing pipelines/why we think it's safe please?

Hey @colmsnowplow , without this patch, EnrichmentFailures 1-0-0 and SchemaViolations 1-0-0 emitted by enrich are not valid according to their schema, so any consumer that would try to validate them would fail. The patch is only there to make these 2 bad rows valid. I can't think of any impact on existing (QA) pipelines.

To add to that: none of current consumers actually validate the data against existing schemas, but if they did - bad rows would be invalid. What we're doing is making sure that in future if consumers start validate data or DDLs were derived out of these schemas - data would be valid.


Request: standalone EBR implementation

I appreciate your implementation of EBR and plan to incorporate it into future projects, specifically for implementing a slab structure. However, I have concerns regarding the scc dependency potentially becoming heavy. Consequently, I would prefer to rely on a more lightweight crate.
Additionally, segregating EBR into its own dedicated crate would help scc's evolution, including potential breaking changes (e.g. https://github.com/wvwwvwwv/scalable-concurrent-containers/issues/105). This separation allows for the coexistence of multiple scc versions (such as v2, v3, etc.) within the same project, each using the same collectors. A similar modular approach is already used across the ecosystem (e.g., signal_hook and signal_hook_registry crates).
So, what do you think about publishing scc-ebr and moving scc to use it?

Looks like a great idea! Right now, I’m way too busy to make big changes to the crate, but I’ll definitely do this in the long run.

FYI: published https://crates.io/crates/sdd / source: https://github.com/wvwwvwwv/scalable-delayed-dealloc
=> This will be integrated into it next month.

https://crates.io/crates/sdd

Thanks a lot!


Only suggest @param codefixes in TS

Fixes bug discovered by @DanielRosenwasser

@a-tarasyuk I can't add you as a reviewer, but you're probably interested in this.

Fixes https://github.com/microsoft/TypeScript/issues/47949. I thought all suggestions should work for TS/JS, so I’ve created PRs that ignore errors on resolving type references. :(. Anyway, I’ve closed it in favor of your PR. Thanks.


Daily adjusted run time calculation

Hello, my daily adjusted run time has been 0 for a few days now following a period of heavy rain about 4 days ago. However it was quite sunny today so I would have thought it would require some watering. My hourly adjusted run time has been above 0 all day. Could this be an issue or does this sound like normal behaviour? Thanks!

sounds like normal behavior. Is your bucket > 0? Your daily adjusted run time (DART) will be calculated at 11PM by default and will be based on the hourly adjusted run time (average or most recent value depending on your config). the value for the DART will be subtracted from your bucket. Here is a good example of how this works: https://github.com/jeroenterheerdt/HAsmartirrigation/wiki/Example-behavior-in-a-week

Thanks!

I installed the component few days ago, but actually I'm not able to make it working.
I can see that hourly_adjusted_run_time is calculated and updated (every hour), but the daily_adjusted_run_time is updated at 23PM to an high value, than after few minutes it resets to zero, so my automation (running at 7AM) never starts.
Any ideas?

@mvimercati I am not sure what is going on here - can you send me screenshots from the entities and their attributes?

@mvimercati I am not sure what is going on here - can you send me screenshots from the entities and their attributes?

Sure, here's the plots of last day:

As you can see at 23.00 the DART go up to 8000s, than after few seconds it seems recalculated to another value (near 8k) and than again it goes to 600 for 5-6s. After that it change again to zero, so the automation do not run (it is triggered at 7am).
Any ideas?
thx

thanks for sharing. The fact that DART goes from 8000+ to 600 is because you have a maximum duration set up, so that's logical. Why then the 600 seconds gets reset to 0 doesn't make sense to me. Is there anything in the logs?

just the general HA log - anything that's in there for Smart Irrigation?

https://github.com/jeroenterheerdt/HAsmartirrigation/blob/59986e72c684fe697d6476694070daf6c1963b86/custom_components/smart_irrigation/sensor.py#L724 from here the run time is calculated...

hello i also have a feeling that after the HA update I have 7 days
0 Daily Adjusted Run Time
is the problem in the update?
I copied the application again I still have 0 DART

hello i also have a feeling that after the HA update I have 7 days
0 Daily Adjusted Run Time
is the problem in the update?
I copied the application again I still have 0 DART

Yes.. I was waiting to reply because I'm not sure what is happening. After an update of HA (2021.7.1) I had one correct activation of the irrigation (the Dart was set at the max allowed running time). Then I got a lot of days (maybe 7 as brano1990) with DART at zero. Bucket was about 20mm and it seems now going very slowly to zero day by day).
I will update you if I understood something else, thx.

so when the bucket is > 0 there is no irrigation and the netto precipitation amount per day will be subtracted from the bucket.

Hello
I have similar problems. The calculated 23:00 watering time sets itself correctly for a few seconds. Then it restarts to 0 and after 30 minutes it returns to the previous value.
Earlier I noticed that after heavy rainfall the bucket did not change and stopped watering.
After a manual reset, the bucket seems to work.
2021-07-16 23:00:00 ERROR (MainThread) [homeassistant] Error doing job: Future exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/smart_irrigation/sensor.py", line 137, in
lambda event: self._bucket_updated( # pylint: disable=unnecessary-lambda
File "/config/custom_components/smart_irrigation/sensor.py", line 301, in _bucket_updated
self.update_adjusted_run_time_from_event()
File "/config/custom_components/smart_irrigation/sensor.py", line 275, in update_adjusted_run_time_from_event
sun_rise = datetime.datetime.strptime(sun_rise, "%Y-%m-%dT%H:%M:%S.%f%z")
File "/usr/local/lib/python3.8/_strptime.py", line 568, in _strptime_datetime
tt, fraction, gmtoff_fraction = _strptime(data_string, format)
File "/usr/local/lib/python3.8/_strptime.py", line 349, in _strptime
raise ValueError("time data %r does not match format %r" %
ValueError: time data '2021-07-17T02:56:23+00:00' does not match format '%Y-%m-%dT%H:%M:%S.%f%z'

Ha, finally an error log! Now we can get somewhere with this. I'll look into it and see if I can make a special version for you to test.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: RobinI30N @.>
Sent: Thursday, July 29, 2021 11:31:20 PM
To: jeroenterheerdt/HAsmartirrigation @.>
Cc: Jeroen ter Heerdt @.>; Comment @.>
Subject: Re: [jeroenterheerdt/HAsmartirrigation] Daily adjusted run time calculation (#63)
Hello
I have similar problems. The calculated 23:00 watering time sets itself correctly for a few seconds. Then it restarts to 0 and after 30 minutes it returns to the previous value.
Earlier I noticed that after heavy rainfall the bucket did not change and stopped watering.
After a manual reset, the bucket seems to work.
2021-07-16 23:00:00 ERROR (MainThread) [homeassistant] Error doing job: Future exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/smart_irrigation/sensor.py", line 137, in
lambda event: self._bucket_updated( # pylint: disable=unnecessary-lambda
File "/config/custom_components/smart_irrigation/sensor.py", line 301, in _bucket_updated
self.update_adjusted_run_time_from_event()
File "/config/custom_components/smart_irrigation/sensor.py", line 275, in update_adjusted_run_time_from_event
sun_rise = datetime.datetime.strptime(sun_rise, "%Y-%m-%dT%H:%M:%S.%f%z")
File "/usr/local/lib/python3.8/_strptime.py", line 568, in _strptime_datetime
tt, fraction, gmtoff_fraction = _strptime(data_string, format)
File "/usr/local/lib/python3.8/_strptime.py", line 349, in _strptime
raise ValueError("time data %r does not match format %r" %
ValueError: time data '2021-07-17T02:56:23+00:00' does not match format '%Y-%m-%dT%H:%M:%S.%f%z'
[SamrtI]https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F72595369%2F127609304-5a2c5391-cc4a-489d-8d81-acdb1bb9e633.PNG&data=04|01||24966b70ead8439cdfa608d95323a515|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637632234826002149|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=b2stIFuSK0Nl4Af4uxmhkqoYlKP0NeLcnH7mIFSVobA%3D&reserved=0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjeroenterheerdt%2FHAsmartirrigation%2Fissues%2F63%23issuecomment-889663419&data=04|01||24966b70ead8439cdfa608d95323a515|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637632234826002149|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=w%2FsC0736yVihRK20pyvOePC6zOJ0qnLjuGtd%2BJtgfdI%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB6PIPUIALDSS27CI5GV5OTT2JBLRANCNFSM47VJ7ZEA&data=04|01||24966b70ead8439cdfa608d95323a515|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637632234826012148|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=EdGLdqQcr4dAyckLLXq50FrMJ6eqfwenqdJPpVuvVlA%3D&reserved=0.

@RobinI30N please update to 0.0.68 and see if that fixes the issue

I'm sorry but I can't fix this.
Immediately after reset
I don't even know how to undo the version.
2021-07-30 19:37:06 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Podlewanie przód for sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 248, in async_setup
result = await component.async_setup_entry(hass, self) # type: ignore
File "/usr/src/homeassistant/homeassistant/components/sensor/init.py", line 67, in async_setup_entry
return await hass.data[DOMAIN].async_setup_entry(entry)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 140, in async_setup_entry
platform = await async_prepare_setup_platform(
File "/usr/src/homeassistant/homeassistant/setup.py", line 298, in async_prepare_setup_platform
platform = integration.get_platform(domain)
File "/usr/src/homeassistant/homeassistant/loader.py", line 499, in get_platform
cache[full_name] = self._import_platform(platform_name)
File "/usr/src/homeassistant/homeassistant/loader.py", line 504, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
File "/usr/local/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 975, in _find_and_load_unlocked
File "", line 671, in _load_unlocked
File "", line 779, in exec_module
File "", line 916, in get_code
File "", line 846, in source_to_code
File "", line 219, in _call_with_frames_removed
File "/config/custom_components/smart_irrigation/sensor.py", line 369
data["wind_speed"] = data["wind_speed"] * (4.87 / math.((67.8 * 10) - 5.42))
^
SyntaxError: invalid syntax

oops. not sure what happened here. Please update to 0.0.69 and try again.

So far it is fine, the entity started correctly.
It's 21:17 so I'll write about the action tomorrow

Thanks!

Thanks for the good job

Explain whether it is still necessary to convert the wind speed to a height of 2 m.
Currently I'm switching to node-red from 7m to 2m. I have my own weather station

as this page explains: https://github.com/jeroenterheerdt/HAsmartirrigation/wiki/Measurements-and-Units, you need to provide the wind speed at a height of 2m if you use your own weather station or in general do not use OWM. If you use OWM then the component does the conversion for you.

There was no question. My interpretation error: I thought why is the formula executing when I have my own wind sensor?
.. it was a syntax error.
Currently it does not log errors, calculations look correct.
Thank you!

thanks for letting me know. @mvimercati can you please also update and confirm this fixes your issue? If so, please close the issue.

@RobinI30N - if the formula is executed at least part of the data is configured to come from OWM. Is that correct or are you using another source (such as your weather station) for all of your data?

For me, that probably solves the problem.
There has only been one update, so it's categorically hard to say?
All data comes from the weather station. I have 4 instances for 5 circuits. Additionally, I have a percentage slider for each of them to calibrate the watering time. ESP Easy works as a controller.

thanks for letting me know. @mvimercati can you please also update and confirm this fixes your issue? If so, please close the issue.

Unfortunately (well, maybe not) I'm on holidays 'til end of month and I can't monitor HA. The irrigation is running with your extension plus 10 minuts of fixed running :)

Hallo, sorry for maybe wrong question, sometimes the irrigation suddenly stops working,
It was working quite good for few months, but I noticed sometimes the hourly irrigation goes mad... resets to 0 (even when is sunny) or counts big values (even when is cloudy or patrly raining)...
Now current example - yesterday (16.5. at time 00:25 at night) reseted the hourly adjusted run time to 0 - whole previous day was sunny, as well is now... so for few hours is still 0 (even if it should be IMHO counting some values) can somebody plz explain where might be a mistake?

I have set very precisely the 30years average statistics evapotranspiration data, and I am not using any rain sensors - so variant maybe not precise enough? It is a bit wired now, since usually until the last weeks used to work almost perfectly. thx foa any clue.
Willy

@berkavil please open your own issue thread and capture the debug logs.

Hallo thank you, plz how I can collect debug logs?
There is no error or any other issue mentioned in the system logs.
thx
Vilem
From: Jeroen ter Heerdt <>
Sent: Monday, May 16, 2022 7:50 PM
To: jeroenterheerdt/HAsmartirrigation @.>
Cc: Willy @.>; Mention @.***>
Subject: Re: [jeroenterheerdt/HAsmartirrigation] Daily adjusted run time calculation (#63)
@berkavil https://github.com/berkavil  please open your own issue thread and capture the debug logs.
—
Reply to this email directly, view it on GitHub https://github.com/jeroenterheerdt/HAsmartirrigation/issues/63#issuecomment-1127962351 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AUH5V3H3KPA5OXZTSYNNEGDVKKDDNANCNFSM47VJ7ZEA .
You are receiving this because you were mentioned.Message ID: @.***>

Again, stop hijacking some thread. Make your own issue. To collect debug logs, add this to your configuration.yaml:
logger:
  logs:
    custom_components.smart_irrigation: debug

closing this issue because of staleness, please re-open an issue if this is still a problem in 2.0 version (now in beta)


Gauge should not remove the latest reported value when flushing

Describe what happened:
Gauge clears previous value after flush.
https://github.com/DataDog/datadog-agent/blob/33db6c888082da73e04a7d344b9c78ee3a72371d/pkg/metrics/gauge.go#L21
Describe what you expected:
The latest value should be kept and therefore sent so no gaps should happen if the gauge is not updated in a while.
StatsD explicitly says:

If the gauge is not updated at the next flush, it will send the previous value.
Source: https://github.com/statsd/statsd/blob/master/docs/metric_types.md#gauges

I found the gauge type in datadog is very confusing, in the official document, it was also said that the gauge metric will add up the previous value:
https://docs.datadoghq.com/developers/metrics/types/?tab=gauge#metric-type-definition

Each value/data point represents the total number of requests received at a point in time. The metric then reports the following values:
10 for the first 30 seconds
30 for the second interval of 30 seconds (10 + 20 requests)
30 for the last interval of 30 seconds (no new request are received so the value stays the same)

The official should clarify and make it consistent everywhere.

Hi,
Is this expected behaviour of the datadog client?  Maybe as an optimization?

Hi,
Is this expected behaviour of the datadog client?  Maybe as an optimization?

I can't really say so. However, if its not compliant with StatsD behavior, i would expect a note about that somewhere (maybe there is one?).

Is this still a problem? Seems pretty unintuitive and destined to catch people off guard in monitors/alerts they set up according to Gauge metrics?


📎 Implement lint/noFlatMapIdentity - clippy/flat_map_identity

Description
Implement flat_map_identity.
Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.
You can use the implementation of useFlatMap as a staring point.

i'm interested


Remove Hops 11 deprecations

BREAKING CHANGE: Replace the outdated `shouldPrefetchOnServer` in your Hops
configuration with the new config value `allowServerSideDataFetching`.

BREAKING CHANGE: `importComponent` now requires the second argument,
that resolves a named export, to be a function.

BREAKING CHANGE: `importComponent` does not accept a module identifier
as the first argument anymore, but requires you to pass in a function,
that returns the `Promise` of the dynamic import of the module.

BREAKING CHANGE: Hops does not support the synchronous
`react-helmet`-package anymore; you have thus to update your
`import`-statements to import the `Helmet`-component from
`react-helmet-async` instead.

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

Don't know what's the matter with Canarist #7029. Tried removing hops-config from internal Hops & tested against that. Made things even worse… 😅

bors merge


Mlapps

Updated marketplace main article:

Changed format.
Added content related to the new text analytics application.
Made it more formal (not "sample apps")

Hi @LuisCabrer, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (luisca). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Media Capture and Streams

Media Capture and Streams is in Last Call review period, and the TAG was among the groups flagged to bring a review:

Technical Architecture Group, for an overall review of the API,
especially the introduction of the concept of a IANA registry-based
constraints system, the use of promises, and our handling of persistent
permissions

The last call period ends on May 15.

@travisleithead "use of promises looks fine to me."

@slightlyoff: asks how this relates to Streams regarding who's buffering (if at all) and when. There may be an inconsistency between the two models. Specifically, this came up in regards to the MediaStream.clone() API.
@mnot notes that the per-origin uniqueness aspect of deviceID isn't clearly speced in the normative section of the document (it's mentioned in the privacy considerations though).

Specifically, I think we need to chat with @domenic about the consumption model and the implicit semantics that come from having a .clone() method.
Similarly, I think we should talk to @cwilso et. al. about AudioContext::createMediaStreamSource() and how these streams get from bytes to decoded bytes. How the heck does that happen? Where does decode take place? On what thread? Can I have access to those decoders from script too?

I assume this input will be built into a more formal feedback to the WebRTC and DAP groups? If so, any idea of when that feedback might be available? Thanks!

@travisleithead could you make sure the review incorporates or addresses https://github.com/w3c/mediacapture-main/issues/212?

Taken up at Boston f2f. Looks like issue 212 was taken on board.

@travisleithead : @dontcallmedom still waiting on feedback on use of streams, relation of media streams to Streams cap-s. Are we happy with the media streams spec?

@dontcallmedom can you join us on the tag telecon 10-7 possibly to close this off?

is it at 8pm UTC on Oct 7? I can probably make it, yes

I think we discussed this already and had no further comments, but forgot to close this. I'm closing it now--if I'm in error, please re-open.


Effects Scoreboards of other plugins

For some reason when i enable Gringotts on the server, scoreboards break?
Any reasoning to why this is happening?
I am using Gringotts v 2.7

Is this still an issue? Can you give a specific, minimal, set of plugins and configs that exhibit this issue?


Collective page: v1 → v2 migration

The goal of this issue is to describe the migration process to the new collective page. It's just a proposal and all periods are chosen arbitrarily so feel free to suggest edits!
Timeframe
I'd like to have the first releasable version of the new collective page at the end of next week (28th June) (right now the main blocker is that the "budget" section doesn't exist).
Though it will be usable, we don't want to break anything for collectives so we should deploy it progressively. Here is the schedule I'm proposing:

1st July

Start communicating to some collectives (on Slack & with good friends) about the /v2 URL so they can preview their page. Get a list of collectives willing to join the Beta program.
Implement the setup to redirect collectives in the Beta program to the new collective page properly (may take one or two days to be done properly). Once the setup is ready, start onboarding collectives on the new page.

15th July

Based on the feedback and improvements made during the 15 days

All good → Make v2 the default, with possible fallback on v1 based on a simple setting
Not ready →

Add a checkbox on /edit so users can activate v2 themselves
Keep improving the page

Communicate about the new collective page on the newsletter

5th August

If new collective page is not the default, now is a good time to do it (@znarf's will be back from holidays to save us if everything goes wrong)

Two months after the new collective page is live

If there's no blocker, kill the old one :hocho:

Technically
TODO

What's the plan for the "conversations" section?

@xdamman This one has a pretty high cost and is currently not planned for the initial release (see https://github.com/opencollective/opencollective/projects/18). The goal is to work on it once the base page with all required sections is done, so (in theory)  during this summer.

@Betree What about the documentation? Do we have to update it as well according to the new release?

@yellowwoods12 I have nothing planned for documentation yet but we should probably update it as soon as the new collective page becomes the default. Do you have some documentation pages in mind?

@Betree Yes. We can add some documentation pages informing about the design and features of the new release; what were the challenges and issues with the old design; how we overcame them in the new one; what are the deprecated components in the old one that what alternatives are we using for it.
My whole idea is to properly document every feature related to the new release for future use as well as for new contributors. This documentation should be such that both developers and Open Collective contributors can benefit from that.

@Betree Yes. We can add some documentation pages informing about the design and features of the new release; what were the challenges and issues with the old design; how we overcame them in the new one; what are the deprecated components in the old one and what alternatives are we using for it.
My whole idea is to properly document every feature related to the new release for future use as well as for new contributors. This documentation should be such that both developers and Open Collective contributors can benefit from that.

@Betree  Should I create an issue for the same so that it can be discussed further?

Yes. We can add some documentation pages informing about the design and features of the new release; what were the challenges and issues with the old design; how we overcame them in the new one; what are the deprecated components in the old one and what alternatives are we using for it.
My whole idea is to properly document every feature related to the new release for future use as well as for new contributors. This documentation should be such that both developers and Open Collective contributors can benefit from that.

There are some good points in there @yellowwoods12. Some of what you suggested would be more relevant to put in a blog post but I could see a FAQ with questions like What happened the collective bar? as we won't have a replacement for the feature it provides right now.

@Betree Should I create an issue for the same so that it can be discussed further?

Let's start with that, we'll try to reference in the issue all the important changes that users are going to face and the questions that they may have.
Thanks!

Issue created for discussing about documenation : opencollective/opencollective/#2148

In the end I took the decision to limit the "beta program" idea because the way to implement it correctly added too much complexity. Some internal collectives such as https://opencollective.com/general-intellect have been activated with the "partial" beta though.
Final resolution: https://github.com/opencollective/opencollective-frontend/pull/2400 added the option to enable the new collective page site-wise. We'll take this approach to migrate everything at once, with the option to rollback easily if anything goes wrong.


Fix FroalaEditor import related to #217

See #217 for more details about this issue.

https://github.com/froala/angular-froala/issues/217#issuecomment-598727932


[FLINK-8966][tests] Port AvroExternalJarProgramITCase to flip6

What is the purpose of the change
This PR ports the AvroExternalJarProgramITCase to flip6.
Brief change log
This test required support for setting extra jar files in the used TestEnvironment:

modify TestEnvironment#setAsContext to pass on jarfiles/classpaths to the environment factory
upload user-jars when submitting jobs through the MiniCluster
allow setting extra jarfiles/classpaths on the MiniClusterResource

Finally:

port AvroExternalJarProgramITCase to flip6

@tillrohrmann I've updated the PR.

check whether there are jars to upload
de-duplicate jar upload code
reverted changes to the MiniClusterResource
added a legacy version of the test
updated the new version of the test to use a MiniCluster

@tillrohrmann Could you take another look? I moved the blob upload into a separate method,


Support ZIP file operations in Ballerina

Description:
Support file compression. refer : wso2-enterprise/internal-support-ballerina#27
Spec: https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT
This will be a separate Ballerina module. name can be ballerina/zipfile.
[ ] Study the spec and other languages support
[ ] Come up with a design proposal
[ ] Implementation
[ ] Testing
[ ] Release to BC

We have published the zip package that we have used for Ballerina Central in https://central.ballerina.io/ballerinacentral/zip/1.0.0.


No way to detect timeouts

It does not seem possible to detect whether or not a timeout occurred. I would have expected some sort of TimeOutException to be thrown, but it just throws a RequestException.
$response = $this->http_client->send($request, $options);
// RequestException

How can I check for this in a reliable manner? Checking RequestException::getMessage() for the 'timed out' string does not seem very reliable.

Hello,
Could you specify which version of Guzzle you are using, as well as the timeout options?
For Guzzle 6.3.0 with the following request, I get a GuzzleHttp\Exception\ConnectException exception.
$client = new Client();
$response = $client->request('POST', 'http://localhost/test-guzzle/upload.php', [
    'connect_timeout' => 1,
]);

You should catch the ConnectException, see the class docs:

Exception thrown when a connection cannot be established.

Thank you @tomzx

I have the timeout error but the ConnectException exception did not works for me !!!

Please note that a ConnectException is also thrown for errors like Failed to connect to localhost port 9020: Connection refused, which is not a timeout.

So, what's the proper way to detect timeouts when? Not connection timeouts, but request timeouts?


#30224 - Removed duplicate text - limited number

Duplicate Text - limited number limited number

@mkalkere : Thanks for your contribution! The author, @dkamstra, has been notified to review your proposed change.

Merging the typo fix.
@mkalkere Thanks!


steam-run-native: Add gtk3

Motivation for this change
This is needed to run The Curious Expedition.
Unfortunately it still won't run through the Steam launcher, as our version of gtk3 conflicts with the libraries in the steam runtime, but it's a start.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Builds ok for me but I'm not able to run the game as it's looking for libatk-bridge. This is included in the bundled Steam runtime but not in the list of native dependencies:
[nix-shell:~/.cache/nix-review/pr-50508-1]$ results/steam-run-native/bin/steam-run ~/.local/share/Steam/steamapps/common/The\ Curious\ Expedition/The\ Curious\ Expedition
/home/chris/.local/share/Steam/steamapps/common/The Curious Expedition/The Curious Expedition: error while loading shared libraries: libatk-bridge-2.0.so.0: cannot open shared object file: No such file or directory

Adding at-spi2-atk to multiPkgs fixes it, and the game then runs. Can you confirm?

As I've lost all motivation to actually play this game, I'm going to close this. Feel free to build on the PR if you want.


qunit dropped node 8 without a breaking change

qunit 2.11.0 changed its engines declaration to >=10.
The current stable release (4.6.0) of ember-qunit supports node 8, and depends on qunit ^2.9.3.
Should we do a 4.6.1 release that restricts the qunit range to avoid the breakage?

The qunit commit was https://github.com/qunitjs/qunit/commit/d7927a0bde1d7223dfea3891360300e1ca145f39

FWIW, they consider that SemVer compatible in the same way that Ember itself does.

I'll do a (hopefully) final 4.x release with it pinned

@rwjblue is this still relevant or should we close it, now that v5 is out?

😞  I should've fixed in 4.x, but didn't get to it. Sorry folks.

😞  I should've fixed in 4.x, but didn't get to it. Sorry folks.


invokable hits iterator through queryCallback

I realise this is probably not exactly what you were thinking, but I have tried to implement via the API you proposed.
This works by passing an invokable hits iterator through the query callback as hinted at in https://github.com/matchish/laravel-scout-elasticsearch/issues/88#issuecomment-585557200 but it does not address https://github.com/matchish/laravel-scout-elasticsearch/issues/86#issuecomment-585559715 which you suggest are both solved in the same solution.. so I think I may have got this totally wrong!
Looking forward to feedback so I can revise.
Order::search($this->search, function(Client $client, Search $body) use($model){
    $body->addHighlight((new Highlight())->addField('*'));
    return $client->search(['index' => $model->searchableAs(), 'body' => $body->toArray()]);
})->query(new HighlightedHitsIterator)->paginate(25);

You understood the idea right. And in this case, is no need for overengineering. But I think it will be better for others(as an example) if we'll break HighlightedHitsIterator into callable SearchResults and HighlightedHitsIterator. The reason is that often a results it's not only hits but also aggregations or maybe its multi-search request. So we pass callable   SearchResults
as callback and inside apply HighlightedHitsIterator to results. SearchResults also must be iterator
What do you think?


Screensize change for F plans not changed to 10.9"

Screensize hasn't been changed to 10.9" for F plans on this site.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a66e2933-c8de-0ae5-c6a4-bb83d7152b56
Version Independent ID: a66e2933-c8de-0ae5-c6a4-bb83d7152b56
Content: Changing from a Microsoft 365 E plan to a Microsoft 365 F plan - Microsoft 365 for frontline workers
Content Source: microsoft-365/frontline/switch-from-enterprise-to-frontline.md
Service: microsoft-365-frontline
GitHub Login: @LanaChin
Microsoft Alias: v-lanachin

@basbax Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/10267
Once the author approves, the changes will be live.
Thanks
Sri


Updates to "other operations and configurations"

Specify name of network to HNS
Bind to specific network interface
VLAN IS
DNS Suffix and/or servers

Ping me when you're ready to merge.

Will do ☺
From: Sarah Cooley<EMAIL_ADDRESS>Sent: Saturday, January 21, 2017 6:36 PM
To: Microsoft/Virtualization-Documentation<EMAIL_ADDRESS>Cc: Kallie Bracken<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/Virtualization-Documentation] Updates to "other operations and configurations" (#546)
Ping me when you're ready to merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/Virtualization-Documentation/pull/546#issuecomment-274303458, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVdoi5TRR-2pc_rL81d9JR56fyLgh3MOks5rUsCDgaJpZM4Lp28b.

Sarah I just merged this commit to master because I need to keep working locally rather than from the online GUI. I'll let you know when I'm ready to merge again.


Change key alignment issue on SS and IKS

Please check both SS and IKS

Can't test unable to create 3 of 5

Completed


feat: Implementation of a fetcher that supports OAuth2

closes #38 #36

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (8fec0da) compared to base (cb3df1f).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         7    +1
  Lines          133       142    +9
  Branches         7         7
=========================================
+ Hits           133       142    +9

Impacted Files
Coverage Δ

oauth2/fetcher.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


What about tailcalls?

The inevitable F# questions :)

Are tailcalls supported?
If not, is the tailcall prefix at least ignored? (The majority of F# code can still execute correctly when the tailcall prefix is ignored, though ideally it should be supported)

Thanks!

Sadly not
Probably not

This was all developed quite some time ago, so I can't exactly remember if I ever came across tailcalls.
But I only implemented exactly what was required to execute the things I tested it with, and I only ever used C# code during testing. I expect I never came across a tailcall at all, so I expect it's totally unhandled.
I don't anticipate developing this any further, so it will probably languish in this unloved tailcallless state forevermore...

Ok, thanks for taking the time to close this out!

@dsyme Since closing this I've since discovered that this code lives on in Blazor, where there is a recent PR#7  to make tailcalls at least not crash the interpreter :)

@dsyme @chrisdunelm
I added some tail calls optimizations in a downstream repo, and also in the Blazor PR#7 that adds F# support. (Sorry for resurrecting this issue, I'll show myself out.)


ItemsRepeater leaks parent UserControl and children if event handler is attached in Xaml.

Describe the bug
Xaml like the below causes instances of UserControl1 to never be cleaned up and stay around in memory forever:
<UserControl
    x:Class="WinUI3Leaks.UserControl1"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:WinUI3Leaks"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">

    <Grid>
        <ScrollViewer>
            <ItemsRepeater  ItemsSource="{x:Bind ViewModel.Items, Mode=OneWay}">
                    <ItemsRepeater.ItemTemplate>
                        <DataTemplate x:DataType="x:String">
                            <local:UserControl2 AutomationProperties.Name="{x:Bind}" ViewModelChanged="UserControl2_ViewModelChanged" />
                        </DataTemplate>
                    </ItemsRepeater.ItemTemplate>
            </ItemsRepeater>
        </ScrollViewer>
    </Grid>
</UserControl>

Specifically the UserControl2_ViewModelChanged event handler seems to be the culprit. Removing it resolves the leak, but since this is defined in xaml this should not be causing the leak.
Steps to reproduce the bug

Run the attached sample:WinUI3Leaks.zip
Click the button multiple times and notice that the amount of UserControl1 instances in memory keeps increasing.

Expected behavior
UserControl1 instances should be cleaned up.
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Insider Build (xxxxx)
Additional context
No response

Updated repro to 1.1.0-preview1

Fixed in WinUI 3.

I'm having the same problem with Win UI 2.8(2.8.0-prerelease.220413001), is this getting fixed soon?

:tada:Microsoft.WindowsAppSDK v1.1.4 has been released which fixes this issue.
Handy links:

Release Notes
Official Nuget Release


About box is not modal / masked improperly. Unexpectedly allows text entry behind it.

Environment
Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 0.11.1251.0

Any other software?
Using focus-follows-mouse

Steps to reproduce
Open a terminal.
click on the down arrow and bring up the about box.

Method 1: resize the terminal horizontally so it's wider than the original terminal width.
Method 2: resize the terminal vertically so it's taller than the original terminal width.

near the right edge you can see the lighter grey section. If you put your cursor there, you can enter text at the cursor (in the picture, you can see I added "hello covid-19")

similarly, when resized vertically, entering text in the light grey section works.

Once you've entered text in the textarea:
Pressing ESC in the light grey section doesn't close the About box.
Pressing ESC in the dark grey section outside the About box doesn't close the About box.
Pressing ESC anywhere doesn't close the About box.
The only way to dismiss the About box is to click the OK.

Expected behavior
The about box should be modal, it should not be possible to enter text behind it.
But perhaps, resizing the terminal should close the About box. Avoiding this issue.

Actual behavior

Thanks for the report! This is actually already being tracked by another issue on our repo - please refer to #2380 for more discussion.
/dup #2380


Configuration of setting.json is modified

I modify setting.json, which is the configuration of $\LaTeX$ in VScode.
So the new features are two functions:

Forward and inverse search
Delete some useless file which may be terrible for a user after compiling

Happy to receive your PR. I will review it in the next few days.


Gallery Spinner Problem

We create multiple Galleries on one Page out of a data-object via ng-repeat.
One Gallery has e.g. 3 Pictures, the next one has 4 pictures and the last one has 8 pictures.
If I click on the first gallery (Thumbnails of any picture) everything is fine, it slides through 3 pictures.
If I click on the second gallery (Thumbnails of the first 3 pictures) i can only slide through the first 3 pictures, then it starts again. 1 -> 2 -> 3 -> 1 (Where is 4?)
If I click on the third gallery (Thumbnails of the first 3 pictures) i can only slide through the first 3 pictures, then it starts again. 1 -> 2 -> 3 -> 1 (Where is 4,5,6,7,8?)
If I click on the second or third gallery (Thumbnails not of the first 3 pictures) i can slide through the whole gallery once 8 -> 7 -> 6 -> 5 -> 4 -> 3 -> 2 -> 1. When I reach the point where the gallery starts again from beginning or end, again there is the 3 picture issue. 8 -> 7 -> 6 -> 5 -> 4 -> 3 -> 2 -> 1 | -> 3 -> 2 -> 1 (Where is 4,5,6,7,8?)

Interesting. Never tried with more than on gallery on the same page, have to test it.
So on your template you have this ?
<div ng-repeat="items in item">
<ion-gallery ion-gallery-items="items"></ion-gallery>
</div>

(This code snippet might be wrong, just typed it from memory)

It is like this:

Do you have an update for me?
Greetings

I've found the issue. It's because the gallery length is set inside a service, which makes it persistent across all instances. I need to pass that to scope to make it independent.
I'll have a fix this weekend, because it might need some refactoring

Hi there,
i just wanted to know how far you are with the fix.
I found the problem myself and could fix it, but if you have already done it this would be a waste of time.
Greetings,
Adrian

Hey
I started doing the changes but haven't finish them. If you can, open up a PR and I'll have a look and change something if needed.


simulating problems

Hey,
Im trying baremetal asawmblies and also booting linux on your core.
After make command when i run dhry_1.s program:
~/riscv/SoomRV$ ./obj_dir/VTop test_programs/dhry_1.s

i just see the output like this:
riscv32-unknown-linux-gnu-ld: warning: section `.data' type changed to PROGBITS
804 0

When i run make linux command output will be like this:
find: ‘/home/user/riscv/SoomRV/test_programs/linux/buildroot/output/target/usr/share/’: No such file or directory
find: ‘/home/user/riscv/SoomRV/test_programs/linux/buildroot/output/target/usr/libexec/’: No such file or directory
0+0 records in
0+0 records out
0 bytes copied, 4,6089e-05 s, 0,0 kB/s
make: *** [Makefile:91: linux] Error 1

when trying to run linux output will:
~/riscv/SoomRV$ ./obj_dir/VTop --device-tree=test_programs/linux/device_tree.dtb --backup-file=soomrv.backup test_programs/linux/linux_image.elf
826 0

my verilator version is:
Verilator 5.022 2024-02-24 rev v5.020-157-g2b4852048

How can i run linux or maybe C codes in baremetal? Are you running coremark in baremetal mode?
Thank you for your interest.

I am having the same problem, here is the version of Verilator.
Verilator 5.024 2024-04-05 rev v5.024

Hi guys, thanks for reporting the issue! This crash just occurs because I accidentally pushed some debugging code. For a quick fix, simply comment out this if statement:
https://github.com/mathis-s/SoomRV/blob/8b697b9399ada90d88f618891f6179ed058b598d/Top_tb.cpp#L1058-L1062
Unfortunately I can't work on SoomRV right now. I will properly fix this once I can get back to SoomRV in 3.5 weeks.


Type annotate qcodes.math.*, make FieldVector's attributes always computed

todo until completion:

[ ] rework the logic regarding _compute_unknowns method so that a FieldVector instance ALWAYS has ALL of its coordinates calculated (currently it is possible to end up with a FieldVector that has some of its attributes equal to None)
[ ] remove T TypeVar completely becuase mypy complained when it was used to annotate dunder methods :( or use T such that mypy understands the typing of dunders

closing because adjusting FieldVector is a bit too much work with not too much benefit


vscode-extensions.rust-lang.rust-analyzer:0.3.1059 -> 0.3.1386

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

I think I messed up the dependencies, let's see what the CI says, but also might try to figure it out locally in the meantime.

Superseded by #216246.


"Trait is not defined" preventing Tool checks from being enriched

https://github.com/foundryvtt/dnd5e/blob/afe245632ddd40c350d4c44dda223525e1c029bb/module/enrichers.mjs#L139C32-L139C37

Can't reproduce this issue, Trait is properly imported into that file.


Added click UI tests to Canary URL monitoring

Description
Added click tests to the Canary script that tests if OpenSearch Dashboards is accessible to test the UI and make sure the dashboard is working.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR is an enhancement to this issue https://github.com/opensearch-project/opensearch-metrics/issues/37.


New logo proposal for Chorus RF Laptimer app

Hi admin, I would like to offer a simple new logo design for Chorus RF Laptimer app. This logo is my special design for you. If you are willing to accept it, you simply reply to this proposal. I will send you a new logo of this file. And if you want another color variation or some additional icon in it. You can tell me. I will update it soon. thank you

Thanks for the proposal, but I don't think it needs rebranding yet :)


resolve licencing

Overview
Expected Behavior
Actual Behavior
Steps to reproduce
(Links to sample github project preferred)
Unity Editor Version
Mixed Reality Toolkit Release Version

Can you please fill in the form for the issue @heatherbarry
We can't accept issues with no description

Resolve licencing

Won't open to mute thread or resolve licencing

Remove unwanted device permanently


Update README.md with recent master changes and add try to make the  Docker pre-requisite more clear

Fixes #235

I signed it!

LGTM


incorrect result of dayOfWeek.getDisplayName(TextStyle.NARROW, Locale.getDefault())

Thanks your library help to develop, but I find an exception when I used "LocalDate.now().dayOfWeek.getDisplayName(TextStyle.NARROW or STANDALONG, Locale.getDefault())". My Location and device region is China, System language is Chinese. For example, today is Wednesday, the correct result should be “三” (third) instead of "星" and other day's result is "星" which should be "一、二、三...". When I set locale to US, the result is "W", it's right.

The text that is used varies by JDK version, because it uses the underlying JDK data. It is unlikely that much can be done to fix this.

@VinsonGuo From your avatar I'd guess you're running this on an Android device.
Judging from my own (extensive) Android experience, many devices have issues with localized text. If localization for English works as expected, then it is most likely that (as @jodastephen notes) the platform-provided localizations are incorrect. I would recommend that you try to reproduce the issue on either a proper JDK environment, or on another Android device. In the latter case, try a flagship device of a top-tier manufacturer; there tends to be more attention to detail in the ROMs for those.

@jodastephen @sschaap Thanks for your explain, I forgot to explain my running env. I use jdk1.8.0_77 and my targetSdkVersion of Android is 26. I had resolved it by this code:
String name;
switch (date.getDayOfWeek().getValue()) {
case 1:
name = "一";
break;
case 2:
name = "二";
break;
case 3:
name = "三";
break;
case 4:
name = "四";
break;
case 5:
name = "五";
break;
case 6:
name = "六";
break;
default:
name = "日";
break;
}
return name;
but I think it's not a best way to solve it.

@keithharris
I have traced this issue. It's seem not jdk's bug because "org.threeten.bp.format.SimpleDateTimeTextProvider"'s  field variable valueTextMap have something wrong when Locale.lauguage="zh" and Locale.region="CN".

There shouldn't use substring(0, 1) when locale is "CN", you should substring last char.

I'd appreciate confirmation that this branch is correct before merging: https://github.com/ThreeTen/threetenbp/commit/025bd8f6a27d4be93f091c8b9d8a2831e1ed1fc7 (topic/narrow-text)

@jodastephen the issue occurs for the "ar" locale as well (and potentially all non latin languages judging from your commit)
@Test
fun `print AR narrow days`() {
  DateFormatSymbols.getInstance(Locale("ar")).shortWeekdays.forEach { println(it) }

  DayOfWeek.values().map { it.getDisplayName(TextStyle.NARROW, Locale("ar")) }.forEach { println(it) }
}

ح
ن
ث
ر
خ
ج
س
ا
ا
ا
ا
ا
ا
ا

Hebrew is also affected by this

Would someone like to take the branch and enhance it for other languages?
https://github.com/ThreeTen/threetenbp/commit/025bd8f6a27d4be93f091c8b9d8a2831e1ed1fc7

I'd be happy to pick it up, but I don't speak any of the affected languages. As soon as I've got a bit of time I will prepare a PR, to at least get this into a state where it could be reviewed.

google calendar appears to be a good source of single character days


Patch for device placement (Reduce host and device syncs)

What does this PR do?

Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

The main idea is to reduce host and device sync.
We also want to use CUDA graphs with DDP. So adding necessary changes.


WIP Allow creation of Selects using TextField

Closes #8270.
Todo:

[ ] Type Definitions
[ ] Tests
[ ] Support multiple/native/etc (all Select options)
[ ] Docs examples

@oliviertassinari this is a very early WIP but I would be thankful about your feedback and whether you think the direction (i.e. including the Select within TextField) is right.
One thing I already stumbled upon is that, unlike with normal text inputs, it doesn't work for me to specify the onChange prop directly on the TextField, that somehow doesn't get passed through. Any idea why that works for text inputs but not for Select?

I agree, options should probably not be abstracted away. I have changed it to accept children.
However I still have quite a few design questions:

Right now I've introduced a boolean flag select that causes a Select to be rendered instead of an Input. Any idea how to make that more future-proof?
An alternative could be to instead add an InputComponent prop directly which would accept Input and Select? I guess I would have to use React.cloneElement then.
In the select case currently the InputProps are spread into the Select element. Should this be made more explicit by introducing a new SelectProps prop that would be mutex with the InputProps? However I see us ending up adding many new props to the TextField API…
My initial question of on the onChange behavior also still remains.

Apart from these questions I already find it quite functional. I'm curious about your feedback and I'll be happy to polish this further according to that feedback.

Right now I've introduced a boolean flag select that causes a Select to be rendered instead of an Input. Any idea how to make that more future-proof?

This sounds like a good idea. I was also thinking of using a type="select" but it could be confused with the native meaning. Do we need it to be more future-proof? Do we want the text field to support something more than an Input or a Select? Well, I guess. I think that we can wait for this use case to introduce a breaking change in order to support it. I can't think of a good enum property name for it. Maybe fieldType?

An alternative could be to instead add an InputComponent prop directly which would accept Input and Select? I guess I would have to use React.cloneElement then.

I think that asking people to provide the Select component would be against the TextField "one size fits all" purpose of the component.

In the select case currently the InputProps are spread into the Select element. Should this be made more explicit by introducing a new SelectProps prop that would be mutex with the InputProps? However I see us ending up adding many new props to the TextField API…

I like the idea of adding a new SelectProps property. However, I would change the implementation. The Select component is a wrapper on top of the Input component that injects his own input: the SelectInput component.
So the Select component accepts an input property. We could wrap the existing Input of the Textfield when select={true} or fieldType="select" (depends on what you prefer). Something like this:
<Select
  input={
    <Input
      autoComplete={autoComplete}
      autoFocus={autoFocus}
      className={InputClassName}
      defaultValue={defaultValue}
      disabled={disabled}
      multiline={multiline}
      name={name}
      rows={rows}
      rowsMax={rowsMax}
      type={type}
      value={value}
      id={id}
      inputProps={inputProps}
      inputRef={inputRef}
      placeholder={placeholder}
      {...InputProps}
    />
  }
  {...SelectProps}
/>

My initial question of on the onChange behavior also still remains.

Wow, this is an easter egg! It's crazy nobody has been asking to add the onChange property before. I think that the TextField should forward it to the right component.

Let me know what you think above the previous point. Given that most people will start with this textfield component, over the lower level ones. We need to get the API right 😁 .

This sounds like a good idea. I was also thinking of using a type="select" but it could be confused with the native meaning. Do we need it to be more future-proof? Do we want the text field to support something more than an Input or a Select? Well, I guess. I think that we can wait for this use case to introduce a breaking change in order to support it. I can't think of a good enum property name for it. Maybe fieldType?

We already have the multiline flag which renders a textarea instead of an input, so I guess a select flag is in line with that concept. I also have a hard time coming up with a better name for now. The only alternative I can think of would be enum, but I don't think that name is a huge improvement.

I think that asking people to provide the Select component would be against the TextField "one size fits all" purpose of the component.

OK.

I like the idea of adding a new SelectProps property. However, I would change the implementation. The Select component is a wrapper on top of the Input component that injects his own input: the SelectInput component.
So the Select component accepts an input property. We could wrap the existing Input of the Textfield when select={true} or fieldType="select" (depends on what you prefer). Something like this:

I will give that a try.

Wow, this is an easter egg! It's crazy nobody has been asking to add the onChange property before. I think that the TextField should forward it to the right component.

What I just don't understand is why everything works as expected for regular TextFields, do you have an idea?

@oliviertassinari I've changed the interface to accept SelectProps and did the Input-wrapping as you suggest and I think it feels much better now :).
For now my only remaining question is regarding the onChange behavior. Why does that work for normal Input-based TextFields but not for the Select-based text fields.
As far as I understand the code, the onChange prop of a TextField is passed on to the FormControl through the ...other here:
https://github.com/callemall/material-ui/blob/6107db2c900d67a5259511f9892f0977d1e734af/src/TextField/TextField.js#L175-L182
But then in the FormControl I would assume the onChange prop is forwarded to the ComponentProp:
https://github.com/callemall/material-ui/blob/6107db2c900d67a5259511f9892f0977d1e734af/src/Form/FormControl.js#L194-L225
So I do quite well understand, why the onChange event doesn't work for the Select-based TextField, I just don't understand why/how the onChange prop is ever forwarded to the Input when specified on a "normal" TextField, like in the first example on the demo page?!

Why does that work for normal Input-based TextFields but not for the Select-based text fields.

First, the Input can be uncontrolled while the non-native version of the Select component needs to be controlled.
Second, in the case of the Input, we rely on a native input, hence the onChange event bubble up in the tree. I'm gonna assume the FormControl component catch it.
So, I think that we can remove the indirection and apply the onChange property directly on the input component.

Hold on, I'm continuing this PR :)

We just need some small tweaks to merge it 💃 .

@ctavan Great work :)

Awesome! Could have continued on Monday but even better to have this merged already. Thanks a lot!


[Authorize] tag not working

I've downloaded the code, trusted the IIS self-signed certificate, updated visual studio (15.7.1), restarted my machine (Windows 10), tried chrome incognito mode (version 66), but nothing will make this [Authorize] tag work. The call to localhost:44332/api/tasks always returns HTTP unauthorized.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 906907ec-cbe2-59b1-a84e-ce1b1343756f
Version Independent ID: f498962c-f738-ccd8-a619-de854fac37da
Content: Authentication, sign-up, password reset ASP.NET Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-devquickstarts-web-dotnet-susi.md
Service: active-directory-b2c
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@sirdank Thanks for your feedback! We will investigate and update as appropriate.

@sirdank The solution has two parts -  a web app and web api. The link which you have shared is for configuring the WebApp. Have you followed the other documentation to configure the web api -
Azure Active Directory B2C: Build a .NET web API

I do not believe I have. Am I required to follow that document as well for this example solution to work?

@saurabhsharma-msft Now I remember: I began stepping through that doc but the example solution appeared already to include the configuration and code that it describes so I did not continue with it. However, there are a few values that are missed between the code in the example solution and the web app doc and which you will only find if you follow the API doc all the way, ignoring that most of what it describes is duplicated or already done for you.. I believe they include: adding the Reply URL for TaskService to the B2C application, updating ApiIdentifier in the TaskWebApp web.config, updating the TaskService web.config. After making those updates, I've gotten past HTTP Unauthorized to 'Internal Server Error'. I'll try to move forward on my own. Thanks!

@sirdank We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Morphology level radial distance features default on using tree root as origin

Radial distance features at the morphology level use the start of neurites as their origin.
However, the radial distance at the morphology level is usually calculated from the soma, not the neurite root.
The current convention of radial distances is also conflicting with the calculation of radial distance features using subtrees. For example, if an axon on dendrite is processed, the distal axon part will have its radial distances calculated from the axon root, not the basal one.
My proposal for NeuroM v4 is:

Set the soma center as the default origin for radial distance features at the morphology level
Set the neurite root as the default origin for radial distance features at the neurite level (current behavior)

@lidakanari , @arnaudon

+1!

+1 from me


An app for a guided neck stretch

This app contains features to set goals for your stretching angles and check on on your head position. It recycles some of the code from the head position tracker but adds a lot of new features such as custom timers and goal threshold for the 3 stretches and stats for the last stretching exercise (whilst still in the app subsection).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


UF-199: General support for UberFire navigation system.

Now PerspectiveChange event keeps the original PlaceRequest. This is important for #136

@porcelli You need this merged before https://github.com/uberfire/uberfire/pull/136?

I don't see what this has to do with #136 ?
Looks like you're going to capture the PlaceRequest after the Perspective has been switched; I guess I was proposing to capture the PlaceRequest before the Perspective had been switched; e.g. if the Activity resolved in placeManager.goTo(...) was an AbstractPerspectiveActivity then keep this as the active perspective.. your approach is probably (possibly) better if the "new" perspective failed to be launched (IDK if we can veto a "goto"? - e.g. Editors preventing navigation if they contain dirty content?).

Humm... I think now I got what you mean. It maybe over engineered, but it makes some sense. i'll try to talk to @cristianonicolai and clarify this with him.
Put on hold this for now ;)

@porcelli, open, closed, re-opened, closed, open, close.. make your mind up ;)
Did you want this merged?

@manstis PR update.. mind merge it?

http://github.com/uberfire/uberfire/commit/5614a4051


switch.tplink: fix overlooked issue with statically defined names

Description:
I fix that did not land in #9454, fixes loading the name from the config and falls back to device given name only when there's none defined.
Related issue (if applicable): fixes #10020
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

This appears to have affected Wimo switches too.


Consistent spacing between children component on BasePage

Now we know, round about, what children etc we are going to have on the Content / Base pages, we should find a way to consistently space the component on it.

Here are some examples.
Quotes

Exhibitions

Events

Event Schedule


feat(plugin): add options to disable cookie and session plugin

Adds the options to disable the cookie and session plugin registration, in case someone wants to initialize the plugins himself, to provide his own set of configurations for these plugins.

LGTM, could you please also update the Configuration section of the README?

LGTM, could you please also update the Configuration section of the README?

Valid point. Added it to the README.md as well as some minor improvements.

Hey, I update some styles in README to make the same code style.

Released in 1.2.0, thanks!


How to clone private repos at evaluation time?

This is a write-up of a question I had, I will answer it myself below.
Some articles (like this one) describe how to use private source code repositories in nix, e.g. with fetchgitPrivate.
The problem with this approach is that you have to give the nixbld* nix-daemon unix users access to an SSH key with which they can clone the private repo.
This doesn't work well if you just want to use your local user credentials (e.g. ssh-agent) to provide access to the repo.
Is there a way to clone at evaluation time, so that the SSH-agent works nicely?

Yes, I found that builtins.fetchGit can do that at evaluation time; for example a file test.nix:
let
  pkgs = import <nixpkgs> {};

  my_private_repo_contents = (builtins.fetchGit {
    url =<EMAIL_ADDRESS>    rev = "a6f338e0f9bedba33f74f605c298623ed19fb8e7";
  });
in
  pkgs.writeText "mytext" "${toString my_private_repo_contents}"

and I could build it with nix-build test.nix.
Here I write a very boring package/derivation that just writes the path to the checked out repo to a file. But you could also use it in a real package that has e.g. src = my_private_repo_contents;.
Note that for me, trying this the first time didn't work, it just hung forever. In strace I could see that it was hanging at a git fetch command into the ~/.cache/nix/git directory. I solved this by just deleting this cache directory and running again.

What's that cache directory doing, and does this ensure we are not storing secrets into world readable /nix/store?

What's that cache directory doing

I believe this is used when you do e.g. NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/2c07921cff84dfb0b9e0f6c2d10ee2bfee6a85ac.tar.gz nix-build ..., it uses that cache directory to place the unpacked .tar.gz nixpkgs tree in there.

does this ensure we are not storing secrets into world readable /nix/store?

No, this approach assumes full trust in the local machine.

See also https://github.com/NixOS/nix/issues/2431, TLDR always add ref="mybranch".


Upgrade to RocksDB-5.3 to do range delete to clean bookie index

In recent release of RocksDB-5.3, a new option feature to delete a range of key in one shot was added to the RocksJNI bindings (https://github.com/facebook/rocksdb/commit/5f65dc877806f8d60d64144ddee9023b178c2d50). The feature was already there in C++ API since 5.0.
Doing delete range when cleaning up the bookie rocksdb index is a lot more efficient, since it can replace the current behavior:

Find what was the 1st entry in the ledger (involves using iterators that can be slow on big DBs)
Find what was the last entry in the ledger

with:

Delete the range of keys for a single ledger (ledgerId, 0) --> (ledgerId, MAX_LONG) in one single operation

cc: @msb-at-yahoo

@revans2 Can you take a look as well?

looks good to me.
one improvement: make first and last key static final  byte[] now that they're constants.

one improvement: make first and last key static final byte[] now that they're constants.

The keys are not constant since they include the (ledgerId, entryId). In any case the KeyWrapper that holds the byte[16] arrays are themselves recycled, so that it just translates into a thread-local access which is done just once for all the ledgers to delete.

@rdhabalia Shouldn't this have been merged in the internal branch?

yes, actually this time I have merged it here, and doing cherry-picking in internal branch and which will generate the artifact which I will cherry-pick to this external branch.
do you see any issue with this process?

I think you might need to force push at that point because the hashes of
the commit will be different after the rebase
On Fri, Jun 16, 2017 at 1:34 PM Rajan<EMAIL_ADDRESS>wrote:

yes, actually this time I have merged it here, and doing cherry-picking in
internal branch and which will generate the artifact which I will
cherry-pick to this external branch.
do you see any issue with this process?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yahoo/bookkeeper/pull/5#issuecomment-309127729, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD0JKB5euVd76U6i24rYZufadwpw9XEks5sEubjgaJpZM4Nbxa3
.

Ok. But I am able to cherry-pick and push those commits without force-push.
However, I will cherry-pick the #8 and will update once the new version will be available.


improve link shortening & add descriptive

this pr fixes shortening of already short http links (i.e. stops appending of .. to short links)
it also makes it possible to link passages of text using [markdown style](https://guides.github.com/features/mastering-markdown/#examples)
i'm doing this as a pr since it's been a subjective while since i last contributed, and the previous time i made a patch with regexes turned out, ehm, sub-optimal.
potential concerns! the (url) regex isn't strict at all, so you can basically [link](whatever)
i'm not sure how much of a problem that will pose, i don't think it should allow for executing javascript since we escape the html before we even get to this stage
anyway i think this feature will be great for The Daily Descent among other things :~

I'll merge this for now, but I would prefer if we used the curlies {text|link} since we're already using curlies for {%image.jpg%} and {bold} and {italic}.

I'll merge this for now, but I would prefer if we used the curlies {text|link} since we're already using curlies for {%image.jpg%} and {bold} and {italic}.

aight changed ^


Remove v0 encoding logic

Once #2050 has been merged and sway encoding improvements to v1 have been completed, we should remove all v0 specific logic:

Encoding should now fallback to v1, strategy can remain in place for future custom encoding
Remove redundant v0 coders, some redistribution may be required for anything still being used by transactions
Remove v0 function selector encoding and contract call script
Remove heap pointer logic
Remove heap type validation for multicalls
Remove experimental tests

@danielbate I think we can start this right after https://github.com/FuelLabs/fuels-ts/pull/2050, regardless of https://github.com/FuelLabs/sway/issues/5727.
Only v1 will be accepted anyway, and the stabilization should be transparent.

Agreed 👍🏻