[DARGA] Api for openshift container deployments

A rebase on Darga of https://github.com/ManageIQ/manageiq/pull/9231.

@alongoldboim Please review failing tests on Travis

@chessbyte checking it with @abellotti

Currently can't check it, server doesn't run on darga branch.

@chessbyte had to change it a bit from the original pr to make it pass, seems ok now.

@alongoldboim was this cherry picked? Were there any conflicts?

@imtayadeway this was a cherry pick, had some conflicts:

spec/models/miq_product_feature_spec.rb

<<<<<<< HEAD
  let(:expected_feature_count) { 1034 }
=======
  let(:expected_feature_count) { 1051 }
>>>>>>> c47519e... Api for openshift container deployments

config/api.yml

<<<<<<< HEAD
=======
    :collection_actions:
      :get:
      - :name: read
        :identifier: chargeback
      :post:
      - :name: create
        :identifier: chargeback_rates_new
      - :name: edit
        :identifier: chargeback_rates_edit
      - :name: delete
        :identifier: chargeback_rates_delete
    :resource_actions:
      :get:
      - :name: read
        :identifier: chargeback
      :post:
      - :name: edit
        :identifier: chargeback_rates_edit
      - :name: delete
        :identifier: chargeback_rates_delete
      :delete:
      - :name: delete
        :identifier: chargeback_rates_delete
  :container_deployments:
    :description: Container Provider Deployment
    :identifier: container_deployment
    :klass: ContainerDeployment
    :methods: *70174834084700
    :options:
    - :collection
    :collection_actions:
      :get:
      - :name: read
        :identifier: container_deployment_show
      :post:
      - :name: create
        :identifier: container_deployment_create
    :resource_actions:
      :get:
      - :name: read
        :identifier: container_deployment_show
  :currencies:
    :description: Currencies
    :identifier: currency
    :options:
    - :collection
    :methods: *70174834086080
    :klass: ChargebackRateDetailCurrency
  :measures:
    :description: Measures
    :identifier: measure
    :options:
    - :collection
    :methods: *70174834086080
    :klass: ChargebackRateDetailMeasure
>>>>>>> c47519e... Api for openshift container deployments

@imtayadeway will merge after your 👍

@alongoldboim if you can update as per https://github.com/ManageIQ/manageiq/pull/9709#discussion_r72280479 this should be GTG. Thanks!
/cc @chessbyte

@chessbyte Done.

:thumbsup: LGTM I would say merge when green /cc @chessbyte

@chessbyte I think this one is ok.

@alongoldboim why was this closed?

@chessbyte deployment was re-targeted to 4.2


tuples.scala failing to compile on latest 2.13 nightly

after https://github.com/scala/community-builds/commit/7b464c22571aa83d5d16093d8718bfd2b5224a56 https://scala-ci.typesafe.com/view/scala-2.13.x/job/scala-2.13.x-integrate-community-build/1405/ has
[shapeless] [error] /home/jenkins/workspace/scala-2.13.x-integrate-community-build/target-0.9.14/project-builds/shapeless-322d363001f435a63f5781c5552ae815938967a1/core/src/test/scala/shapeless/tuples.scala:398:27: could not find implicit value for parameter e: shapeless.ops.tuple.Unifier.Aux[(TupleTests.this.Apple, TupleTests.this.Pear, TupleTests.this.Apple, TupleTests.this.Pear),(TupleTests.this.PWS, TupleTests.this.PWS, TupleTests.this.PWS, TupleTests.this.PWS)]
[shapeless] [error]     val uapap = implicitly[Unifier.Aux[(Apple, Pear, Apple, Pear), (PWS, PWS, PWS, PWS)]]
[shapeless] [error]                           ^
[shapeless] [error] one error found

@milessabin any insight on this? I'm interested in getting this resolved in order to unblock downstream projects in the 2.13 community build

It's at the front of the queue for tomorrow.

git bisect is pointing it's finger, somewhat surprisingly, at https://github.com/scala/scala/pull/6729. I'll try and find out what's going on.


refactor: Linting fix

Signed-off-by: k-kumar-01<EMAIL_ADDRESS>

Closes #265

The PR fixes the linting fix.
Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to master from fork:branchname
[ ] Manual accessibility test performed

[ ] Keyboard-only access, including forms
[ ] Contrast at least WCAG Level A
[ ] Appropriate labels, alt text, and instructions

Agreed these all look great. But I think this shouldn't be addressed until https://github.com/accordproject/techdocs/issues/308 has been resolved and we have a plan going forward. Once we have a linter, we just plug it in and can open PRs against all our repos in one go so we don't deal with piecemeal solutions.


Non-voting nodes should only broadcast blocks once

To reduce outbound traffic

Given vote-by-hash and our changes to block resending, what should we do here ?

Not sure if this will not break network integrity. Broadcasting node connection can be broken for a few seconds at broadcasting time

Was it resolved with broadcasting until confirmed, @clemahieu ?

Yes this was fixed when we removed the 4-count of rebroadcasting. Closing.


Toggle-slide : Blink value on loading form

Bug, feature request, or proposal:
When I load a page with a form with amodel, there is something weird with the toggle slider. In my model, the value is false but when I load the page, I can see the toggle slide "checked" (true) but it changes few milliseconds after to the the good value ("false").
(enabled fields is false)
									<md-slide-toggle [(ngModel)]="enabled" name="enabled" color="primary">
{{ 'category.enabled' | translate }}

{{ 'category.disabled' | translate }}
 									</md-slide-toggle>
What is the expected behavior?
It should display the correct value immediately
What is the current behavior?
What are the steps to reproduce?
Providing a StackBlitz/Plunker (or similar) is the best way to get the team to see your issue.
Plunker starter (using on @master): https://goo.gl/DlHd6U
StackBlitz starter (using latest npm release): https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 4.3.6
Angular/material 2.0.0-beta.10
Is there anything else we should know?

Can you reproduce? Also try upgrading to beta.12

I'll try beta 12 and up this post

I updated my project to beta.12. Still the same problem. The value is not correct when the page is loading and then, when the page is totally loaded, the toggle change to the good value.

What specifically do you mean by "when the page is totally loaded"? Are you using SSR or you have some ajax call that brings in the value after the app bootstrap?

It's weird but i can't see the problem anymore. I can't explain it... my browser maybe :/
By the way, the data are loaded through an API call.
I think you can close it. Sorry about that


zone.js 0.6.x changelog

@mhevery
I like how angular2 documents breaking changes in the changelog.md
Do you plan to commit a changelog.md or does angular2 communicate the changes when they switch to 0.6? It's impossible the extract any changes from https://github.com/angular/zone.js/commit/63d4552bed2850d5610e1a13dfb728c14651184f
I guess almost all issues and pull request might be out of date because of this?
Did you publish a blogpost/podcast/talk on why you rewrote everything for 0.6? Just curious :)

Yes, we should set up the change log. Yes, I will have to deal with the PRs separately, or ask people to rebase.


[json-rpc] rename json-rpc method get_account_state to get_account

Motivation
get_account_state returns a struct named AccountView on the server side, it contains account resources data as field values. The name account_state is widely used as internal data structure AccountState, which is a btree map.
For non-verifying API, we will never return the btree map AccountState, but for verifying client API (will be added in future, or existing experimental method get_account_state_with_proof), we will return the btree map AccountState.
Using the name get_account_state to return data structure that is not the btree map AccountState is confusing, especially when we publish verifying client APIs.
This change renames get_account_state method name to get_account to reflect common meaning of Account struct, it also aligns with the return value struct AccountView on server side.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

Unit test
Manual test with testsuite cli

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

can we also test the new endpoint with a local curl? (so curling against a local Libra swarm)

can we also test the new endpoint with a local curl? (so curling against a local Libra swarm)

did the test with local libra swarm

Local test console log (trimmed most of unrelated output):

Connected to validator at: http://localhost:54135, latest version = 5, timestamp = 2020-07-16 01:57:51.933954 UTC
usage: <command> <args>

......

libra% a create
>> Creating/retrieving next account from wallet
INFO 2020-07-16 01:58:36 testsuite/cli/src/libra_client.rs:268 Verified version change to: 205
Created/retrieved account #0 address d0935c7f74e6ac1d2976b425ed84ab05

libra% a mb 0 2 LBR false
>> Minting coins
waiting for<PHONE_NUMBER>000000000000000a550c18 with sequence number 2

......

Finished minting!

libra% q b 0
Balance is: 2.000000LBR
libra% q as 0
>> Getting latest account state
Latest account state is:
 Account: (
    d0935c7f74e6ac1d2976b425ed84ab05,
    Some(
        AuthenticationKey(......),
    ),
)
 State: Some(
    AccountView {
        balances: [
            AmountView {
                amount: 2000000,
                currency: "LBR",
            },
        ],
        sequence_number: 0,
        ......
    },
)
 Blockchain Version: 564

@bors-libra retry

@bors-libra r=sunmilee

:pushpin: Commit 705bcce has been approved by sunmilee

@bors-libra retry

:hourglass: Testing commit 705bcce3b69e5dd5594a4e80debc48430ffc0694 with merge e1ea641325a9329abd959b59b44716a19753cdbb...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sunmilee
Pushing e1ea641325a9329abd959b59b44716a19753cdbb to master...


🐞 Scroll does not follow cursor when adding new line ouside of viewport

Description
Adding a new line that is located outside of the visible viewable editor does not scroll to the new line. However once a character is typed, the scroll position jumps to the new line as expected.
To Reproduce

Open a new file.
Scroll to the bottom
Start adding new lines by pressing the Return key until the cursor is out of view
Notice that the scroll position doesn't follow the cursor
Type a character
Notice that the scroll position jumps to the cursor

Expected behavior
The scroll position should follow the cursor when adding new lines.
Additional context
https://user-images.githubusercontent.com/806104/222929377-ba0bb2cc-6114-423e-9327-d848a4312168.mov

I can't repro this issue could you add more steps/requirements @austincondiff?
https://user-images.githubusercontent.com/128280019/230960717-428ea32d-9822-4da8-bc30-a649b509ad2e.mov

Transferring to CodeEdit as this is mostly fixed however the bottom inset needs adjusting.


So this repo just proved that AlpacaEval and Vicuna GPT-4 evals are bad. What's next?

[2023/07] We released the OpenLLMs model series. Among them, OpenChat obtains 80.9% win-rate on AlpacaEval and 105% ChatGPT performance on Vicuna GPT-4 evaluation.

Are you saying your model is generally better than a 10x bigger model?
If not, what is the plan to fix metrics so they show the expected ranking?

GPT-4 is predisposed to prefer models trained on data bootstrapped using InstructGPT/GPT-4/ChatGPT over more factual and useful content.

https://huggingface.co/blog/llm-leaderboard

To the best of my knowledge, @imoneoi mentioned that he was working on alternative benchmarks, including MMLU. I believe he reached just shy of 50% on MMLU, whereas GPT3.5 reaches 70%. (https://arxiv.org/abs/2303.08774)

Exactly, we are in the progress to verify the real reason behind this interesting phenomenon. The model is powerful or just the evaluation is bias? It is worth noting that there were also other SFT models fine-tuned on GPT-4 generated data, but our performance is much better.

[2023/07] We released the OpenLLMs model series. Among them, OpenChat obtains 80.9% win-rate on AlpacaEval and 105% ChatGPT performance on Vicuna GPT-4 evaluation.

Are you saying your model is generally better than a 10x bigger model?
If not, what is the plan to fix metrics so they show the expected ranking?

Note that AlpacaEval is a highly recognized benchmarks in the community, with many well-known models trained under SFT evaluated on it (Vicuna, Alpaca, UltraLM, etc) achieving expected ranking. This benchmark can provide some insight into the performance of data-centric methods to a certain extent.
However, we acknowledge that the metrics are not perfect, and recent studies have shown that the win rate under GPT-4 evaluation is correlated with the length of unique tokens. Auto-evaluating a chatbot is a daunting task, and the community has made a long-term effort to improve language generation evaluation. We will continue to consider this issue, refrain from focusing solely on the ranking, and explore other evaluation methods including human evaluation. Thank you for your valuable suggestions.

Thank you for your interest in our OpenLLMs model series, and for bringing up important questions about our performance metrics.
To clarify, we believe that OpenChat is a powerful alignment method that demonstrates the importance of data quality and diversity in achieving high performance. While we acknowledge that there is still a gap between OpenChat and ChatGPT, as shown by the 80.7% vs 86.1% on AlpacaEval, we are proud that despite being limited to 6K data, OpenChat still performs better than other open-source models that use 0.2~1M data.
We understand that the evaluation of language generation models is a complex and ongoing challenge, and we are committed to exploring different evaluation methods, including human evaluation, to gain a deeper understanding of our model's strengths and limitations.
We are also continuously working to improve our alignment methods and training larger models to achieve even better performance. We are excited to release OpenChat V2 and V3 in the future and will keep the community updated on our progress.
Thank you again for your valuable suggestions and for your interest in our work.

Awesome. I'm glad to see that you're aware of the perils of automated evaluation of generative models. I trust that your work  here, as well as future versions, are indeed as good as reported. I'm quite interested in this project personally, and I'd love to find some time to contribute in the future.

Notice there's this new MT-bench that is supposed to replace the Vicuna benchmark and shows a bigger gap between open models and GPT-3.5: https://twitter.com/lmsysorg/status/1675612625273761793


Unable to install Version 2.2.1 (Kodi v19.3)

I previously had Version 2.2.0 installed from the Lime repository. I tried to install the update for Version 2.2.1 but all it did was remove 2.2.0 and the new version failed to install. I tried to install it again from the repository, but it looks like it just installs the dependencies but does not install the add-on. How do I go back to 2.2.0?

Same as me here.. i using the dramacool as widget as well and out of sudden keep prompting me to download dramacool addon but after press install nothing happens and it keep asking me to download the dramacool addon again and again

Yes, there seems to be some issue with installation. Currently working with it.

Couldn't find any issue with the installations, but I did find some bug when trying to open the plugin. It's now fixed in 2.2.2, could someone check if the issue still exists or if it's fixed.

Couldn't find any issue with the installations, but I did find some bug when trying to open the plugin. It's now fixed in 2.2.2, could someone check if the issue still exists or if it's fixed.

Thanks, just tried installing 2.2.2 and it works fine. The only working servers are StreamSB and DoodStream, is this expected?


Fix incorrect information about nested virt support for Easv4-series

@brucesherwin : Thanks for your contribution! The author(s) have been notified to review your proposed change. @ayshakeen

@mimckitt,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.

#sign-off

@mimckitt: I'm sorry - only the author of this article, @ayshakeen, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Break out filter content

This is based on #207, so that will have to be merged and the base for this will have to be updated.
As I've been adding stuff to filtering, I keep thinking "I should make that it's own component". Well, now I have. I wish I had done it sooner. I am sorry 😭
This is mostly just removing the d2l-filter-list-item out, but there are some other changes too, done due to (really small) problems found in redoing the d2l-all-courses tests.
To do:

[x] Merge #207
[x] Change base for this PR
[x] Write tests for new broken-out component
[x] Get milk

Yay, this does what it's supposed to now! Pretty sure I haven't broken anything in the process of doing this - it was mostly just moving the filter menu content out into its own component and doing some minor tweaks/improvements along the way (+ tests).


ADCE deletes label, but leaves a branch to the label.

If an empty structured-if has a merge block that is also the continue target of a loop construct, the block in the if is removed, but the branch is left as is.  This leaves a use of a label id that has no definition.
The following SPIR-V demonstrates the problem.  Assemble it, and run it through ADCE.
               OpCapability Shader
          %1 = OpExtInstImport "GLSL.std.450"
               OpMemoryModel Logical GLSL450
               OpEntryPoint Fragment %2 "main" %3
               OpExecutionMode %2 OriginUpperLeft
               OpSource GLSL 430
               OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
               OpSourceExtension "GL_GOOGLE_include_directive"
               OpName %2 "main"
               OpDecorate %3 Location 0
          %4 = OpTypeVoid
          %5 = OpTypeFunction %4
          %6 = OpTypeFloat 32
          %8 = OpConstant %6 0
          %9 = OpTypeInt 32 1
         %10 = OpTypePointer Function %9
         %11 = OpConstant %9 0
         %12 = OpConstant %9 10
         %13 = OpTypeBool
         %14 = OpConstant %6 1
         %15 = OpConstant %9 1
         %16 = OpTypePointer Output %6
          %3 = OpVariable %16 Output
          %2 = OpFunction %4 None %5
         %20 = OpLabel
               OpBranch %21
         %21 = OpLabel
         %22 = OpPhi %6 %8 %20 %23 %24
         %25 = OpPhi %9 %11 %20 %26 %24
               OpLoopMerge %27 %24 None
               OpBranch %28
         %28 = OpLabel
         %29 = OpSLessThan %13 %25 %12
               OpBranchConditional %29 %30 %27
         %30 = OpLabel
         %23 = OpFAdd %6 %22 %14
         %31 = OpConvertFToS %9 %23
         %32 = OpSGreaterThan %13 %25 %31
               OpSelectionMerge %24 None
               OpBranchConditional %32 %33 %24
         %33 = OpLabel
               OpBranch %24
         %24 = OpLabel
         %26 = OpIAdd %9 %25 %15
               OpBranch %21
         %27 = OpLabel
               OpStore %3 %22
               OpReturn
               OpFunctionEnd

Good catch!
A related question: how do you interpret the following from the SPIR-V spec, giving requirements for the Shader capability:
Selections must be structured, having an OpSelectionMerge instruction in their header.
Specifically, how do you interpret the word "Selections"? Specifically, does this mean that every OpBranchConditional must be preceded by an OpSelectionMerge? If not, which ones must be?

I believe every OpBranchConditional must be related to an Op*Merge instruction.  The OpBranchConditional in BB 28 does not have an OpSelectionMerge because it is the loop exit related to the OpLoopMerge in BB 21.
The example above was generated by glslc from the shaderc repository, with a small change by hand.  The original source was
#version 430

layout(std430) buffer U_t { float g_F[10]; };

layout(location = 0) out float o;

void main(void) {
  float s = 0.0;
  for (int j = 0; j < 10; j++) {
    s += 1.0;
    if (j > int(s));
  }
  o = s;
}

#1088 has been merged.

Specifically, how do you interpret the word "Selections"? Specifically, does this mean that every OpBranchConditional must be preceded by an OpSelectionMerge? If not, which ones must be?

This unfortunately vague, and has been a topic of debate.
No, not every OpBranchConditional has to have a merge instruction.  Question is, which ones.
I'd like to say "Selections" should be interpreted as a "selection construct" but that's defined in terms of a "selection header" which itself is not defined in the spec.  You might guess that it means "a header block which is not a loop header".  But then that would mean "a block that has an OpSelectionMerge instruction".  Which then leads to a circularity.  (Ouch.)
I assert the way to think about it is in terms of dominating header and merge blocks:

Consider a branch instruction in block B, branching to block C. (For a conditional branch, C will stand in the text below for either of the two targets.)
Intution: You need a merge instruction in B if its branch introduces a "new" divergence in control flow.
More formally: You need a merge instruction in B if all of the following are true for C:

C is not the merge or continue target for an enclosing header block H.  (H encloses B if B is strictly dominated by H, and B is not dominated by the merge block named by H.)
C is not one of the case targets of an OpSwitch

I think I got that right.
Basically, branches to targets "out" of a construct are not counted as forcing the need for a selection merge.

Thanks David, that's very helpful. Perhaps that statement in the spec could be amended to?:
Selections must be structured, having an OpSelectionMerge instruction in their header, unless they are an allowed branch out of the enclosing control flow construct.


enhance adding node public configs

Description
The ip v6 fields are optional, but if the user starts typing in any of them the other will be mandatory.
Changes

enable the remove config button if the node has ip4 only
resolve update node info error after submitting the new public configs

Related Issues

#52

Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings

Good job ya Omar


[Feature Request] Support POST method in SSE requests

The SSE connection is hardcoded to use GET method (https://github.com/wundergraph/graphql-go-tools/blob/master/pkg/engine/datasource/graphql_datasource/graphql_sse_handler.go#L188).
But for my use case, the graphql server only takes POST requests. I believe this is a very common practice in graphql servers. Can we make the http method configurable?

We don't have a use case for this, but you can open a PR if you're interested.

fixed by https://github.com/wundergraph/graphql-go-tools/pull/449


Dev Lite Test: Greenhouse Effect 1.1.0-dev.10

Dev-Lite Test
This is a dev lite test of the first screen only for the Greenhouse Effect sim.  This test is being done to make sure
that this screen is ready for a set of interviews that will be focused on interactive descriptions.  This is the
second dev test for this purpose, and several issues have been addressed based on the first dev test.
Mentions: @KatieWoe, @arouinfar, @kathy-phet, and @jessegreenberg
Simulation links

github repository for issues
phet top level directory
sim: all_phet.html

Test Matrix

[x] Tester 1 (Tester = NS , Platform = macOS 12.4 + safari + VO, Time = 2hrs {max 2 hours}
[x] Tester 2 (Tester = KW, Platform = iPad Mobile VO, Time = .75 {max 2 hours}
[x] Tester 2.5 (Tester = E2, Platform = Win10 Firefox + NVDA, Time = 1 {max 2 hours}

Features included

[x] Alternative Input
[x] UI Sound
[x] Sonification
[x] Description

Focus and Special Instructions
The focus for this testing should be on description and on any egregious bugs that could block interviews.

Issues to Verify
These issues should have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.

[x] https://github.com/phetsims/greenhouse-effect/issues/182
[x] https://github.com/phetsims/greenhouse-effect/issues/169
[x] https://github.com/phetsims/greenhouse-effect/issues/168
[x] https://github.com/phetsims/greenhouse-effect/issues/176

For QA...

General features

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Try to include browser version numbers
If there is a console available, check for errors and include them in the Problem Description.
Run through the string tests on at least one platform, especially if it is about to go to rc.
Check the Game Up harness on one platform.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnification and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

@KatieWoe @Nancy-Salpepi @stemilymill
When testing with a screen reader, please compare the responses to the Activity Log in the a11y view. In particular, when changing the greenhouse gas concentration with the slider, there is a set of responses like this: (numbered in order of how they should be heard)
1. More infrared radiation redirecting back to surface.
2. Surface temperature warming, now 286.1 Kelvin.
3. More infrared radiation emitting from surface.

It's important to know if all of these statements get heard, or if they get cut off before starting the repeated "Warming" or "Cooling" responses.
The same goes when switching between the slider/date modes, and when switching between dates. In all of these cases, the greenhouse gas concentration changes, which should queue up several responsive descriptions. Things look good in the a11y view, but I want to make sure that what we see in the a11y view Activity Log matches what is said by screen readers.

Calling QA here.

Thanks @KatieWoe and team.  We will follow up on the individual issues.  Closing.


Are Exchange 2016 and 2013 supported in all WMF versions

Can we have a support statement and if not supported with all WMF add a support matrix

It may be best to defer to the Exchange team's supportability matrix on TechNet. Where do you think this should be included?
https://technet.microsoft.com/en-us/library/ff728623(v=exchg.160).aspx#Windows Management Framework
The short answer (from the above link) for the supported version of WMF in both Exchange 2013 and 2016 is: "Version of Windows Management Framework built into the release of Windows Server you're installing Exchange on."

Do we have this link in the docs for this resource?  If not can we add it?

It makes sense to me to add a Supportability section towards the top of the README. Is there anything else we should add in there? I'm not sure where our support statements are on DSC itself, or our stance on custom modules, including xExchange. Seems like those would be good to add if we're going to call out supported WMF versions.

I think the module support WMF4 and newer.  We should mention that and then refer to Exchanges statement on what exchange actually supports.

The only combo of Exchange/Windows that the Exchange team supports for greater than WMF4 is Windows Server 2016/Exchange 2016. All other combos of Exchange 2013/2016 with Windows are only supported on WMF4, and it doesn't look like that will change.
Regarding custom module support, I was thinking that's more of a PowerShell team supportability question. The Exchange team definitely isn't going to support custom modules, or anything to do with DSC for that matter. Not sure what the PowerShell team's stance is though. Are custom modules supported at all, or is only the underlying DSC engine supported? Do we have any articles we can link to showing what is and isn't supported by the PowerShell team for DSC?

I think the support statement should be relative to the module itself.  We could mention that this is not provided by the exchange team and support is, therefore limited.

Sounds good to me. We can add a support disclaimer in regards to the module itself, and then also add a support disclaimer linking to the Exchange team's WMF guidance on TechNet. Maybe also specifically say that the only combo the Exchange team supports for WMF5 is Windows 2016/Exchange 2016, else WMF4 is what they support.

We managed to deploy Exch2016Cu4 on a 2012R2 server with WMF5.1 in a fresh lab. Not sure how, but it works, I am not noticing any errors when opening shell and connecting to exch server as well as executing basic cmdlets.
Possibly someone has same experience?
Still don't thing if it is a good idea to deploy new servers in prod with above described scenario.

Hi @drewz0ne , no one has claimed that it won't work. It's just not tested by the Exchange product group, and thus not supported. If you do happen to run into an issue and want to call MS Support for assistance, they may ask you to roll back to an older version of WMF if they suspect it's a problem.


Cannot call CompleteChatAsync with options after ToolChatMessage in messages of type List

Confirm this is not an issue with the OpenAI Python Library

[X] This is not an issue with the OpenAI Python Library

Confirm this is not an issue with the underlying OpenAI API

[X] This is not an issue with the OpenAI API

Confirm this is not an issue with Azure OpenAI

[X] This is not an issue with Azure OpenAI

Describe the bug
I really like the idea of this codesnip, but it seems like the client.CompleteChat(messages, options); throws exception from server without any specific errors (only 400 Bad Request has been returned), if we call this method after the ToolCall were processed in the previous loop. If we remove options and only keep messages without options CompleteChat(messages), and again after ToolCall, it would work fine.
do
{
    requiresAction = false;
    ChatCompletion chatCompletion = client.CompleteChat(messages, options);

    switch (chatCompletion.FinishReason)
    ...
while (requiresAction)

in some forums, I see that they suggest to use CompleteChat with options for the first time, and then go through the tool before call the CompleteChat for the last time without options. In this case how we can include the whole history? For example when the bot need a parameter from user and ask a question before the bot can run function further?
On other words, how can we process tool calls as chain (not parallel), output from the first tool can be input for the next tool.
To Reproduce
Just run the codesnip and make sure that the model runs at least one tool. You will see that it throws exception.
do
{
    requiresAction = false;
    ChatCompletion chatCompletion = client.CompleteChat(messages, options);

    switch (chatCompletion.FinishReason)
    ...
while (requiresAction)

The error I have gotten:
System.ClientModel.ClientResultException: Service request failed.
      Status: 400 (Bad Request)

         at Azure.AI.OpenAI.ClientPipelineExtensions.ProcessMessageAsync(ClientPipeline pipeline, PipelineMessage message, RequestOptions options)
         at Azure.AI.OpenAI.Chat.AzureChatClient.CompleteChatAsync(BinaryContent content, RequestOptions options)
         at OpenAI.Chat.ChatClient.CompleteChatAsync(IEnumerable`1 messages, ChatCompletionOptions options, CancellationToken cancellationToken)

Code snippets
No response
OS
Windows
.NET version
8.0.6
Library version
2.0.0-beta.2

Thank you for reaching out, @taihuy ! This snippet is from our function calling example linked below, correct?
🔗 https://github.com/openai/openai-dotnet/blob/main/examples/Chat/Example03_FunctionCalling.cs
I just ran the example using the latest version of the library, and it works as expected. Did you make any modifications to the code? If you could share an end-to-end repro, that would be very helpful!

Hi @joseharriaga,
Thanks very much for your quick answer. I really appreciate it. It is even more helpful when we work with this kind of innovative technology and still in beta test.
I figured why it happened with my code. It were because I used data source in addition to tools in my ChatCompletionOptions. When I removed the data source, the code worked well as the example.
       {
           Endpoint = new Uri(searchEndpoint),
           IndexName = searchIndexName,
           Authentication = DataSourceAuthentication.FromApiKey(searchApiKey),
       };

var options = new ChatCompletionOptions
       {
           Tools = { _projectsInCompanyTool, _timeEntriesInProjectTool, _timeEntriesInCompanyTool, _usersInCompanyTool}, ToolChoice = ChatToolChoice.Auto
       };

#pragma warning disable AOAI001 // Type is for evaluation purposes only and is subject to change or removal in future updates.
       // options.AddDataSource(searchDataSource);
#pragma warning restore AOAI001

I got the following warning "Azure.AI.OpenAI.AzureChatCompletionOptionsExtensions.AddDataSource(OpenAI.Chat.ChatCompletionOptions, Azure.AI.OpenAI.Chat.AzureChatDataSource)' is for evaluation purposes only and is subject to change or removal in future updates.", but I need both tools and Azure Search Service in my bot. Is there any ways that I can have both?

@joseharriaga I have the same issue when using AzureSearchChatDataSource and function calling together. The response is 400 (Bad Request) Invalid chat message detected: message content must be string.
I noticed that it's related to AssistantChatMessage serialization - it works differently depending on content parameter.
I tried it with following test code snippet:
var messages = new List<ChatMessage>
{
    new AssistantChatMessage(toolCalls: [], content: null),
    new AssistantChatMessage(toolCalls: [], content: string.Empty),
    new AssistantChatMessage(toolCalls: [], content: "test")
};

var result = await client.CompleteChatAsync(messages);

This is how the request looks like:
{
   "messages":[
      {
         "role":"assistant"
      },
      {
         "role":"assistant",
         "content":[
            {
               "type":"text",
               "text":""
            }
         ]
      },
      {
         "role":"assistant",
         "content":"test"
      }
   ],
   "model":"gpt-4o"
}

When content is null - content property won't be present in request.
When content is an empty string - content property in request will be an array of objects with "type": "text" and "text": "".
When content is non-empty string - content property in request will be a string.

It looks like Azure OpenAI with data service works only when content property is a string, not an array, and it should exist in request body, even when it's null (in this case it should be empty). I'm not sure where exactly this fix should be applied, but I'm wondering if serialization logic on OpenAI SDK side should be updated for case with empty string to send "content":"" or it should remain as "content":[{"type":"text", "text": ""}]?

Thank you for providing more context! Unfortunately, the Azure OpenAI service does not support function calling in combination with data sources. You can find more information about it here:
🔗 https://learn.microsoft.com/azure/ai-services/openai/concepts/use-your-data?tabs=ai-search%2Ccopilot#function-calling

Thank you for providing more context! Unfortunately, the Azure OpenAI service does not support function calling in combination with data sources. You can find more information about it here: 🔗 https://learn.microsoft.com/azure/ai-services/openai/concepts/use-your-data?tabs=ai-search%2Ccopilot#function-calling

@joseharriaga It's not supported, but in this case the request should still be successful and either function calling, or data sources should be ignored. But taking into account the serialization aspect of assistant messages that I shared above, instead of ignoring function calling/data source configuration, it throws 400 (Bad Request) Invalid chat message detected: message content must be string.

I'm not sure where exactly this fix should be applied, but I'm wondering if serialization logic on OpenAI SDK side should be updated for case with empty string to send "content":"" or it should remain as "content":[{"type":"text", "text": ""}]?

Ah! We merged and released a change where an empty string is represented as "content": "" instead of an array of content parts starting with version 2.0.0-beta.13.

I'm not sure where exactly this fix should be applied, but I'm wondering if serialization logic on OpenAI SDK side should be updated for case with empty string to send "content":"" or it should remain as "content":[{"type":"text", "text": ""}]?

@dmytrostruk Ah! We merged and released a change where an empty string is represented as "content": "" instead of an array of content parts starting with version 2.0.0-beta.13.

@joseharriaga Great news, thanks a lot!


Bluetooth: Controller: Fix missing recv fifo reset

Fix missing recv fifo reset on HCI reset. This fix handles a
scenario where in Rx Prio thread has enqueued a node rx, Tx
thread handles HCI Reset Command, and Rx thread wakes up
from call to k_fifo_get to handle invalid node rx. The
changes here ensure Rx thread does not get any invalid node
rx post HCI Reset Command handled in Tx thread.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@Thalley @ppryga please take a look


Can't create npm shrinkwrap with express-jwt in package.json

I have a project where I use both node-jsonwebtoken and express-jwt. After the upgrade to node-jsonwebtoken 5.0.0, I can't create a npm shrinkwrap, as express-jwt, I believe, depends on 4.x. Here's the npm debug log.
0 info it worked if it ends with ok
1 verbose cli [ 'node', '/usr/local/bin/npm', 'shrinkwrap' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose node symlink /usr/local/bin/node
5 warn unmet dependency /Users/gp/Projects/myproject/node_modules/express-jwt requires<EMAIL_ADDRESS>but will load
5 warn unmet dependency /Users/gp/Projects/myproject/node_modules/jsonwebtoken,
5 warn unmet dependency which is version 5.0.0
6 verbose stack Error: Problems were encountered
6 verbose stack Please correct and try again.
6 verbose stack invalid<EMAIL_ADDRESS>/Users/gp/Projects/myproject/node_modules/jsonwebtoken
6 verbose stack     at shrinkwrap_ (/usr/local/lib/node_modules/npm/lib/shrinkwrap.js:37:15)
6 verbose stack     at /usr/local/lib/node_modules/npm/lib/shrinkwrap.js:31:5
6 verbose stack     at /usr/local/lib/node_modules/npm/lib/ls.js:47:30
6 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-installed/read-installed.js:138:5
6 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
6 verbose stack     at cb (/usr/local/lib/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
6 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
6 verbose stack     at cb (/usr/local/lib/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
6 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-installed/read-installed.js:251:14
6 verbose stack     at cb (/usr/local/lib/node_modules/npm/node_modules/slide/lib/async-map.js:47:24)
7 verbose cwd /Users/gp/Projects/myproject
8 error Darwin 14.3.0
9 error argv "node" "/usr/local/bin/npm" "shrinkwrap"
10 error node v0.12.2
11 error npm  v2.7.6
12 error Problems were encountered
12 error Please correct and try again.
12 error invalid<EMAIL_ADDRESS>/Users/gp/Projects/myproject/node_modules/jsonwebtoken
13 error If you need help, you may report this error at:
13 error     <https://github.com/npm/npm/issues>
14 verbose exit [ 1, true ]

@paambaati We have released<EMAIL_ADDRESS>that fixes this issue by updating dependency to<EMAIL_ADDRESS>Feel free to reopen if you still experiencing this issue. Thanks!


:seedling: Remove release 1.5

/hold

This again is doing two things at the same time. For sync job this is fine, but make the title and description about switching the release, and not just mention removing.

This again is doing two things at the same time. For sync job this is fine, but make the title and description about switching the release, and not just mention removing.

OK, this is two commit PR again, which one is already in another PR to be first merged. So we're rebasing and then removing.

/unhold


Lengthen Powerdot duration to 1 minute

As discussed during today's playtesting, 30 seconds is not enough time for Pacman to catch a Ghost over multiple city blocks and intersections.
This should be put into the configuration so it is more easily changed.

Closed as a duplicate of issue #65.


Review

Code clean-up, improvements.

FTR:
Breaking change for use of 'Smile' as sleeptime is gone
Breaking change for all 'on'/'off' as these have become True/False

Approved - not sure why codecov is behaving


SSO cookie expiration is set to Session regardless of configuration

I'm using Custom Policies.
In the section here you seem to imply that the cookie expiration time can be set in minutes. From that section as well I understood that the setting to configure this in the Relying Party is SessionExpiryInSeconds, which is confusing since this one is in seconds.
What I'm seeing in the browser doesn't match this description. The cookie is set with an expiration type of Session, instead of the 1200 seconds I set it to.
Is AD-B2C respecting this setting? I'm missing the actual way to configure this? Is the documentation correct and what I'm seeing in the browser is wrong or is it the other way around?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9627f2fa-6005-9c15-2824-03b7bcd4aae9
Version Independent ID: 619e1eea-ed67-994b-7eee-469123e9b7ef
Content: Configure session behavior - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/session-behavior.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@reydelleon-skuvault
Thanks for your feedback! We will investigate and update as appropriate.

Hi @reydelleon-skuvault , the expiration type won't be the time. If you look in the XML example:
<SessionExpiryType>Absolute</SessionExpiryType>  <SessionExpiryInSeconds>1200</SessionExpiryInSeconds>
Check to see if your browser shows SessionExpiryInSeconds. From my end I believe the documentation is correct, you just need to convert from minutes to seconds where needed.

The browser literally shows the word Session in the column where other cookies have an expiration date. There is no expiration date set for it, neither in seconds nor in minutes.


#2271

Describe what this PR does / why we need it
Change NacosServiceManager injection mode to constructor injection
Does this pull request fix one issue?
Fix #2271
Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: elve.xu@yunlsp.com:x<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[IAM] On policy creation allow role attachment

Is your feature request related to a problem?
An IAM Policy can be attached to a Role on the Role's creation time via the policies or policyRef fields, but it is not always the case that they are created together.
In our case, we have some pre-existing IAM Roles which would benefit from being able to be attached to from new policies created from Kubernetes manifests via ACK.
Describe the solution you'd like
I can see 2 possible solutions (although there is likely a better one):

The current Policy resource is updated to include a roleRef (or equivalently named field) that allows the attaching of the created Policy  directly to a specified role.
A new resource is created which handles this attachment, e.g. PolicyAttachment.

I believe that both of these would be possible through the use of the AttachRolePolicy API.
Describe alternatives you've considered
Initially I thought that the AdoptedResource kind would solve this issue, but from what I understand this simply allows the editing of metadata from the Kubernetes API perspective and whilst the relevant object is created this is after-the-fact of applying the AdoptedResource, i.e. we do not have the specific kind (e.g. Role) to then manipulate in code - it only exists within the Kubernetes API and not from inception of an entirely new cluster.
Happy to consider any other alternatives that I may have missed or contribute to this feature request in anyway I can. It may also be possible that this request muddies the lines between the resource's responsibilities and may need further consideration.

Hi @jdockerty. Please see https://github.com/aws-controllers-k8s/community/issues/1579#issuecomment-1345606976 for an explanation as to why we won't be supporting Policy.RoleRefs and will only be supporting the Role -> Policy relationship via Role.PolicyRefs.

Makes sense! Thanks for the explanation @jaypipes


Enhancement PlanValidationResult with invalid plans

With this PR we add:

an Enum representing the possible reasons of a failed plan (for now INAPPLICABLE_ACTION or UNSATISFIED_GOAL)
an Optional field to the PlanValidationResult called reason, that is an instance of the Enum described above
an Optional field to the PlanValidationResult called inapplicable_action, that might contain the failed action instance when the reason of the failed plan is INAPPLICABLE_ACTION

Codecov Report
Patch coverage: 96.77% and project coverage change: +0.05 :tada:

Comparison is base (90b4413) 86.89% compared to head (7a32581) 86.95%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   86.89%   86.95%   +0.05%
==========================================
  Files         184      184
  Lines       23110    23137      +27
==========================================
+ Hits        20081    20118      +37
+ Misses       3029     3019      -10

Impacted Files
Coverage Δ

unified_planning/engines/__init__.py
100.00% <ø> (ø)

unified_planning/engines/plan_validator.py
96.00% <83.33%> (+8.24%)
:arrow_up:

unified_planning/engines/results.py
81.72% <100.00%> (+1.48%)
:arrow_up:

unified_planning/test/test_validator.py
98.55% <100.00%> (+0.51%)
:arrow_up:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feature/auto [infer-schema & auto-directory ingestion]

made it very easy to write dataset auto ingestion code. this branch supports image_classification directories that are structured as class_folder -> images.
it also removed the from_directory method on hub.Dataset & replaced it with from_path.

the tests i wrote may fail for windows... hopefully not though

don't merge yet, i added some asserts that should fail, if they don't then there might be a problem.

I think many image datasets follow coco or voc style annotations, should we take that into account?

I think many image datasets follow coco or voc style annotations, should we take that into account?

yes, but this is version 1. i don't care to support all datasets right off the bat. this is to get the feature into the hands of testers immediately so we can iterate. there will be many followup PRs.

this is basically ready to merge, i rewrote the tests to not use kaggle datasets. but only 1 test failed and its outside my context (the master branch clci is failing). should we merge it anyways?
source: https://app.circleci.com/pipelines/github/activeloopai/Hub/2089/workflows/6f462b61-3e37-4529-a88a-73c55fe6d94a/jobs/3082

nice i see you fixed the tests! @AbhinavTuli good stuff


Fix module specifiers.

@adamkozuch @andipavllo
The current navigation template has the following problems:

import page1 from 'Page1'; should be import page1 from './Page1';

'Page1' impiles Page1 is a module package.
'./Page1' impiles Page1 is a module file.
Therefore we should use relative paths for our files.

import customToolbar from 'customToolbar'; should be import customToolbar from './CustomToolbar';

The original file name is CustomToolbar.vue, not customToolbar.vue.
This causes a problem on OS which has a case-sensitive file system such as Linux.
In fact, this template does not work on Linux: https://circleci.com/gh/monaca-templates/onsenui-v2-vue-navigation/3

import App from './App.vue'; should be import App from './App';

We do not have to include extensions since we have the setting about default extensions (in webpack.prod.config.js and webpack.dev.config.js).

Could you merge this and retag 2.2.7?

@asial-matagawa LGTM. Thank you.


Bug: The getFiles method of \CodeIgniter\Events class is declared as 'public', but it should probably be 'public static'.

PHP Version
8.2
CodeIgniter4 Version
4.2.11
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
apache
Database
MySQL
What happened?
The getFiles method of \CodeIgniter\Events class is declared as 'public', but it should probably be 'public static'?
Steps to Reproduce
Just try to make this call (which will throw an error since the getFiles is not static, and its an anti-pattern to instantiate the Events class just to be able to call this method.):
\CodeIgniter\Events\Events::getFiles();
Expected Output
A list of Events.php config file locations.
Anything else?
We ran into this issue while trying to implement a solution that requires us to get a list of those locations, our system is a web-based configuration for installations were you don't have access to modify the files on the drive.
Our current workaround was just to patch the class to add the static keyword to that method definition and update our installation. Just wondering if there is maybe a valid reason why the getFiles method is not public static and if maybe we should change it to include the static keyword.

The properties in the Event class are all static and all methods other than getFiles() are static.
So I agree that the method should be static.

That looks like just a typo to me. It will still work in an instantiated object even if we change it to static so let's do just that. @benedict-tshaba Would you send a PR for this please? Literally just add the word static - you can donut through GitHub's UI if you're not comfortable with the workflow, it will guide you.


Provide HHVM installer

Reference:

https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-OSX-10.8
https://github.com/facebook/hhvm/wiki

:+1:
any news on that ?

I found that the HHVM build system currently is pretty unstable to build.
for now, to install on Mac OS X, you can check out:  http://github.com/c9s/hhvm-macports

HHVM provides a bunch of precompiled version for a wide range of Linux distributions:
https://github.com/facebook/hhvm/wiki/Prebuilt Packages for HHVM
The Debian project as an intent to package it https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727085 and the packaging work is hosted on http://anonscm.debian.org/cgit/pkg-hhvm/hhvm.git/ . Look at files under /debian for some clues:
http://anonscm.debian.org/cgit/pkg-hhvm/hhvm.git/tree/debian/control (list dependencies)
http://anonscm.debian.org/cgit/pkg-hhvm/hhvm.git/tree/debian/rules (build commands)

Given that it's been more than 2 years since the last comment, and HHVM doesn't seem that demanded by the PHP community [1][2], closing this as unlikely to be ever implemented.
[1] https://symfony.com/blog/symfony-4-end-of-hhvm-support
[2] https://github.com/doctrine/annotations/pull/134

Since my March 2015 comment, HHVM entered Debian in July 2015 though it did not make it to the stable versions.  It is maintained by Debian Developers from the Wikimedia Foundation (Faidon Liambotis and Moritz Muehlenhoff).


Attempt to use pkg-config even on Windows

The buildscript currently never attempts pkg-config on Windows, even though MSYS2 provides pkg-config and a libcurl package. This need not be the case.
This is especially relevant because compiling curl from unpatched source under MSYS2 is tricky because MSYS2 does not provide the strtok_r function, leading to errors of this sort:
...\target\release\deps\libcurl_sys-d0dfe3f28a72a4ef.rlib(libcurl_la-cookie.o):cookie.c:
(.text$Curl_cookie_add+0x152): undefined reference to `strtok_r'

Thanks for the PR! This is actually intentional though because using reams of code from MSYS2 ends up not playing nicely sometimes.
Unfortunately the standard installer for Rust that targets MinGW also installs an instance of gcc.exe. When the Rust compiler links binaries it then uses this gcc.exe instance, and then it also prioritizes using bundled versions of libraries with Rust rather than the system.
This ends up meaning that if you have the bundled gcc.exe instsalled, you can compile C code with one runtime and link it with another, causing lots of problems! I believe your original error (an undefined reference to strtok_r) can be fixed by uninstalling the Rust-bundled MinGW gcc.exe (it's an option in the installer).
I'm somewhat hesitant to use libcurl/pkg-config from the system as well as I've generally had not much luck in the past with doing so. I'm a little hazy on the exact details right now but would uninstalling the gcc.exe that Rust installs suffice for you for now?

Ah, I think it's perhaps the other way around - compiling curl during the build step finds the headers from MSYS2, where strtok_r exists, and then links against the bundled MinGW libraries which lack it. Deleting all the $toolchain/lib/rustlib/$target/lib/*.a files allowed curl to be built again. While the option not to install this may exist in the .msi installer, it is sadly missing from rustup.
Is it even possible for the gcc crate to compile the curl dependency without a full (i.e. more than the bundled) MinGW toolchain installed?

Support should be coming soon to rustup to configure this! But yes this library requires a full MinGW installation. The gcc.exe we ship is only used as a linker, not a C compiler.
I believe one issue with MSYS2 packages is that they're compiled with the pthread threading model rather than the Win32 one which Rust needs? I'm not sure exactly how that played out though.

Hi, i just come across this issue as well. I'm using MSYS2 dist and used to using rustup, cargo and other tools under cmd.exe, so libcurl 's sh ./configure doesn't execute correctly. Never mind, that's another story.
I think the problem mentioned in this thread is as follows:

We CAN use windows-gnu version of rust (at least almost) flawlessly with w64-mingw32 versions of prebuilt packages with corresponding target cpu. We can argue that there're chances that the gcc-libs or other dependencies versions are different, compiler bugs etc. However then it's user's duty to make them consistent. If the user can't get a consistent version. Then they'll have to build one. (I still think prepare a environment compatible to that of rust-mingw, write a PKGBUILD file and makepkg and install with pacman is much much more desirable)

We CAN NOT use windows-gnu version of rust with anything built within the real MSYS2 runtime (those not prefixed with x86_64-w64-mingw32 etc) and use the corresponding gcc toolchain, because essentially that's a very different game in the name of POSIX. As you mentioned: "they're compiled with the pthread threading model rather than the Win32", etc.

To ensure this, I think:

The gcc crate: when using windows-gnu toolchain of rust, shall always execute the corresponding x86_64-w64-mingw32-gcc.exe or i686-w64-mingw32-gcc.exe. It is not allowed to use the MSYS2\usr\bin\gcc.exe, which is actually x86_64-pc-msys-gcc.exe.

The pkg-config crate: when using windows-gnu toolchain of rust, shall always execute the corresponding x86_64-w64-mingw32-pkg-config.exe or i686-w64-mingw32-pkg-config.exe. It is not allowed to use the MSYS2\usr\bin\pkg-config.exe, which is actually x86_64-pc-msys-gcc.exe.
(those pkg-config.exe can manage the library directories themselves)

After that, we're always safe to use gcc crate and pkg-config crate to resolve those dependencies.
If unsuccessful, download and compile and build from source as a fallback.

@crlf0710 the incompatibilities aren't just with misusing the wrong compiler or such, but rather the Rust distribution itself. Accepting a change like this would make curl-sys stop compiling by default on many Windows installations of Rust due to the installed rust-mingw component.

@alexcrichton Yes, I understand your concerns about this, and i also think that now is not the right time for accepting this.
One thing i don't really understand is that, even in the rust-mingw case, There's no pkg-config.exe or libcurl.a shipped with it at all. Why would that be a problem?
I believe that what pkg-config(-rs) does (or should do) is exactly to probe and provide the correctly dependencies if they exist. If they do not exist or are not compatible, pkg-config should not return anything.
Well, i'm not complaining, but it seems to me that something's broken... Now i'm also not sure what is the correct thing to do... But...rust is actually still linking things from my mingw64 dist because of other crates, like libz or things like that and... it's just weird to see that just this crate is requiring a library compilation locally even if i've installed libcurl.a and libcurl-4.dll (they're compatible with the only gcc.exe i'm able to use) and i'm not sure whether some crate else is actually using that copy directly or indirectly...
I don't know what to do now...  What do you think?

I believe the problem happens when:

You have the rust-mingw component installed
You're running in an MSYS environment with pkg-config and libcurl.a
You attempt to link in libcurl.a, but you also link in older support of libc and such that's in rust-mingw

That causes undefined symbols and such because libcurl.a is compiled against a different version of the libraries that are being linked.

What I do to avert the problem is uninstall the rust-mingw component. Unfortunately rustup doesn't make that easy.

@alexcrichton  @SpaceManiac
Thanks for the explanation! Then the situation is much better than what i thought. Thanks again.

@SpaceManiac yeah that's what I'd prefer to happen by default. We're in sort of an unfortunate situation here... Currently though we're basically in a state where landing a PR like this would break curl-rust by default on many MinGW installations, so to land this we'd have to change the current state somehow. Unfortunately I'm not entirely sure how :(

Closing due to inactivity


Draw Arcs

Feature Request
How can i draw an arc with a specific angle?
Why it is needed
I tried using the circle but i cant define a start or end angle.

https://www.youtube.com/watch?v=UMvw20nRZls


fix Tables types

Description
For v1 endpoint we don't expose directly CoreAPITable (don't want to expose types). Doing so we messed with a sharead type that is used with internal routes that depend on that type
This PR breaks the type in two.
Risk
N/A
Deploy Plan

deploy front

PMRW


Mock Akka Streams during test

Currently the streams in Validator class is not mocked and if a valid file is supplied in test it will invoke the stream. This is not the ideal behaviour and need to be changed.

not relevant


New version of VSCode breaks the formatter (forge)

with forge 0.2.0 (https://github.com/foundry-rs/foundry/commit/93aa2d071b635a838030aa29ad85b52d361f5728 2023-03-11T00:09:06.544116259Z)
on linux with  VSCode 1.76.1 with JuanBlanco.solidity extension installed
in a mono repo with this .vscode/settings.json
{
    "editor.formatOnSave": true,
    "[solidity]": {
        "editor.defaultFormatter": "JuanBlanco.solidity"
      },
    "solidity.compileUsingRemoteVersion": "v0.8.16",
    "solidity.formatter": "forge",
    "solidity.packageDefaultDependenciesContractsDirectory": "src",
    "solidity.packageDefaultDependenciesDirectory": "lib"
}

forge fmt works as expected
I have prettier installed at root
but after vscode update the format on save doesn't work anymore
I tried opening only the packages/contracts folder in vsCode and also updating the vscode user's setting
It also doesn't work when I do a Format Document (forced)

@zgorizzo69 I have managed to replicate the issue, the solution was to reinstall forge as for some reason the path was not found by vscode.

Indeed, the formatter is not listed

@juanfranblanco Is there any other way to fix?

Really strange. It is listed now

But still does not format the document (upon save, but also upon direct Format command).
It looks like forge fmt -  is not called at all (or file not found).
I am using VSCodium in flatpack. Tried to enable ~/.foundry/bin/ in Flatseal.
Forge fmt works from the within the VSCodium terminal.
Is there any way to debug the invocation?

it works if i use prettier. when using forge the format on save is not working

This issue still exists. I created a new project with forge init, configured formatter the same way as described in the issue - everything was fine. After restarting VSCode formatter doesn't work any more. Had to switch from "forge" to "prettier".

For anyone having the same issue - this is the workaround:
CTRL-SHIFT-P Preferences: Open Keyboard Shortcuts (JSON)
add this:
  {
    "key": "ctrl+alt+f",
    "command": "workbench.action.terminal.sendSequence",
    "args": {
      "text": " forge fmt\u000D"
    }
  }
]

Mind the space before forge to avoid cluttering command history.

I faced the same issues after the initial setup. Got resolved automatically after restarting VSCode.

Yes you will need to restart (sometimes) when changing the setting as is not picked up by vscode. As usual, is intermittent to make it more confusing to spot the problem, as other settings are ok.


'type' object is not subscriptable

'type' object is not subscriptable

could you provide more log?

could you provide more log?

2023-07-20 19:45:04.191 | INFO     | metagpt.config:init:43 - Config loading done.
Traceback (most recent call last):
File "/Users/lucas/tal/github/ai/MetaGPT/startup.py", line 5, in
from metagpt.software_company import SoftwareCompany
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/software_company.py", line 11, in
from metagpt.actions import BossRequirement
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/actions/init.py", line 10, in
from metagpt.actions.action import Action
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/actions/action.py", line 11, in
from metagpt.llm import LLM
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/llm.py", line 9, in
from metagpt.provider.openai_api import OpenAIGPTAPI as LLM
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/provider/init.py", line 9, in
from metagpt.provider.openai_api import OpenAIGPTAPI
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/provider/openai_api.py", line 15, in
from metagpt.provider.base_gpt_api import BaseGPTAPI
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/provider/base_gpt_api.py", line 15, in
class BaseGPTAPI(BaseChatbot):
File "/Users/lucas/tal/github/ai/MetaGPT/metagpt/provider/base_gpt_api.py", line 19, in BaseGPTAPI
def _user_msg(self, msg: str) -> dict[str, str]:
TypeError: 'type' object is not subscriptable
Process finished with exit code 1

Provide OS, python version, pip freeze result

macos   python3.8.8

Step 1: Ensure that NPM is installed on your system. Then install mermaid-js.
npm --version
sudo npm install -g @mermaid-js/mermaid-cli
Step 2: Ensure that Python 3.9+ is installed on your system. You can check this by using:
python --version
Step 3: Clone the repository to your local machine, and install it.
git clone https://github.com/geekan/metagpt
cd metagpt
python setup.py install

thanks


Add a static page that describes what this project is about.

Describe the feature you want to request
Currently, there is not enough detail on the page when the users see when they first install "ai-sidebar"(below image is the landing page when users see on first installation)

Let's design a page that can be seen by users when they first install the plugin.
Describe how you want to implement the feature
Refer to public/html/page.html and public/js/script.js

We still need a lot of modifications on the static page.

Add description about features
Improve design(fonts, layout, images ...)


Add instructions to set TBM call sign

The method from the forums does not work (any more) and is mightily complicated.

Hm, recently I seem to have issues opening PR's - hope this is no du0plicate.

In other news, I think the same call sign change can be done by overwriting en-US.locPak here. You think this is worthwhile?


Mirrors for build artifacts

Our current hosting provider (which shall remain unnamed, but they claim to be a market leader in what they do) has been going from downtime to planned maintenance that lasts "several days".
We should abandon all hope that it's going to get better and move at least build artifacts to AWS.

As of 3.7.0, we distribute artifacts exclusively via Bintray, Package Cloud and GitHub plus rabbitmq.com/releases, a legacy source, is now backed by Cloud Flare so the redundancy story is pretty solid now.


Extending Core Classes

Coming from CI3 it was easier to edit functionality to the core. I have asked a buddy and have been messing with it myself but we can't seem to edit core classes without some hacky workarounds. According to the documentation it doesn't work as described? Maybe I am blind but this is what I have. I am trying to modify how this appends the code, but I can't get the function to override the original. Am I missing something?
  $classmap = [
          'CodeIgniter\\HTTP\\Message' => APPPATH . '/Libraries/Message.php',
      ];

<?php

//namespace CodeIgniter\HTTP;

class Message extends \CodeIgniter\HTTP\Message {

   public function appendBody($data) {
      $this->body .= (string) $data;

      return 'Does this work?';
   }

}

The Message class is a little bit of a different beast, honestly, since the Request and Response classes directly extend that class. If you're trying to add this method to the Response class, then you'd create a new class that extends CodeIgniter\HTTP\Response, we'll just add it to our application folder directly for now:
<?php namespace App;

class Response extends \CodeIgniter\HTTP\Response
{
    public function appendBody(string $data)
    {
        $this->body .= $data;
        return $this;
    }
}

Then you'd modify the Service the system uses to use the new class instead of the existing one. The best way to do this is to copy the response() method from system/Config/Services.php to application/Config/Services.php and modify it to use the new class:
public static function response(\Config\App $config = null, $getShared = true)
	{
		if ($getShared)
		{
			return self::getSharedInstance('response', $config);
		}

		if (! is_object($config))
		{
			$config = new \Config\App();
		}

		return new \App\Response($config);
	}

And that's done. Now, when the system starts up, it should use your new class in place of the built-in one during all Response interactions throughout your application.
No need to mess with the ClassMap directly in most cases, at least not when you have a namespaced class the autoloader can find.

Oh - and next time, please use the forums to ask questions. This should be for bug reports only.

Ahh, perfect! It works. This makes a lot more sense and is exactly what i needed to keep extending. Thank you!


symmetric nat in other system

as I see in this doc https://github.com/AlexxIT/go2rtc?tab=readme-ov-file#module-webrtc
your app can work normally with webRTC  without use TURN server even the network is behind a symmetric nat. In my understanding, only solution to deal with symmetric nat is TURN server, am I right ? how do you deal with this ?
P/S: sr,  This issue is not related to this repo

I don't understand your question. All the answers are in the link you provided


Renderer Issue

Hello ! Thanks for such a great work and congratulations on being accepted by ICLR2023.
I've run your code for a customized dataset and found out that the lip does not match the audio as well as the demo video. I have visualized the landmark and found out that the landmark matches the audio, so I think it is a renderer issue. I'm currently using the radnerf renderer, do you have any suggestions on solving this issue?
Thanks in advance!

hi，how about the video length? It may need 3-5 minutes to learn a good tenderer. By the way, a learning curve about your head_nerf may help me find out the problem.

Thanks, the video length is over 4 minutes, and the learning curve is provided as follows.

Thanks in advance!

Hi, it seems that the adversarial training of postnet has failed (the confidence of discriminator to the generate sample is only around 0.3, which ideally should be 0.5). I have two suggestions:

try lm3d_vae_sync_pitch and lm3d_postnet_sync_pitch. Because we found pitch is a useful hint for the postnet to successfully perform the domain adaptation.

reduce the number of layers in discriminator, which may ease the adversarial training.

Hi, I notice that you closed this issuse as completed. Can you feedback is you problem solved? And which method helps you out?


Rust Implementation?

Can be implemented as a wrapper for openssl and soduim or by porting ring, which is based on boringssl.

Here is my preliminary implementation; progress follows the inheritance hierarchy in the Java codebase (from the interfaces towards the final subclasses)

@denim2x you can open a pull request prefixed with "WIP: " if you'd like to receive some early feedback.
The contribution guidelines are quite brief: https://github.com/google/tink/blob/master/docs/CONTRIBUTING.md
I assume one should be able to build the Rust implementation with Bazel (to be consistent with other languages in the repo). This plugin may be helpful: https://github.com/google/cargo-raze

Hopefully Mozilla interested enough.

Hello, may I ask what is the progress on this one?

Any updates on this?

There's now a Rust port at https://github.com/project-oak/tink-rust (docs).  It's currently based on the RustCrypto crates and is still under construction, but there's a reasonable fraction of the Tink functionality implemented.

I will close this issue since rust will not be available in this repo. For updates follow the repository which David linked above.


Export: Remove temp files from cache after export

So far we left most temporary files lying around, so this attempts to
fix that.
I added a helper method to DirAccess to factor out the boilerplate of
creating a DirAccess, checking if the file exists, remove it or print
an error on failure.

Note: I haven't tested the new code much yet, I'll try PC and Android exports to see if things behave as expected.

Rebased with a couple FIXMEs handled.
Tested Linux, macOS (zip), Android and HTML5 exports, it seems to work fine.


Adjust how CRPS for ensemble methods are grouped in included.md

Fixes #731

Note, I am aware the ordering within the group is not alphabetical. In this case I think there's a clear conceptual progression to the method ordering which is more important for readability.


Add generic efuse driver for NuttX

Summary
Add generic efuse driver for NuttX
Impact
Add a new efuse subsystem to NuttX
Testing
ESP32

hi @xiaoxiang781216 the building is passing on everything, except MacOS. Could you please help me and/or merge this PR?

hi @xiaoxiang781216 the building is passing on everything, except MacOS. Could you please help me and/or merge this PR?

@acassis I will take a look tonight.

@acassis I will take a look tonight.

@acassis I will take a look tonight.

Thank you!

@acassis I will take a look tonight.

Thank you!

@acassis the change look perfect, could you squash all patches into one?

@acassis the change look perfect, could you squash all patches into one?

Sure, I will do it now! Thank you very much @xiaoxiang781216

Sure, I will do it now! Thank you very much @xiaoxiang781216

@acassis why not merge into one patch? it doesn't make sense to left the intermediate result in the history.

@acassis why not merge into one patch? it doesn't make sense to left the intermediate result in the history.

@acassis why not merge into one patch? it doesn't make sense to left the intermediate result in the history.

Ok, I was separating your and Sara commits, but I will squash them all in the original PR

@acassis why not merge into one patch? it doesn't make sense to left the intermediate result in the history.

Ok, I was separating your and Sara commits, but I will squash them all in the original PR


GEODE-3413: overhaul launcher and process classes and tests

This is primarily an overall of all ServerLauncher and LocatorLauncher
tests and org.apache.geode.internal.process tests. The main classes in
org.apachage.geode.internal.process package are also cleaned up.
In addition, several bugs involving these classes and tests are fixed.
Here is the complete list of tickets that are resolved in this overhaul:

GEODE-1229: LocatorLauncherRemoteJUnitTest.testStartOverwritesStalePidFile
GEODE-2791: LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero fails intermittently with AssertionError
GEODE-1308: CI failure: LocatorLauncherTest.testSetBindAddressToNonLocalHost
GEODE-1309: CI failure: ServerLauncherTest.testSetServerBindAddressToNonLocalHost
GEODE-3193: locator pid file is removed even if there was a problem while shutting down
GEODE-3413: Overhaul launcher tests and process tests
GEODE-3414: Cleanup org.apache.geode.internal.process package

Note I moved all useful tests from LocatorLauncherAssemblyIntegrationTest
into the other launcher tests in geode-core.

These tests have also now been overhauled or rewritten:

LauncherMemberMXBeanIntegrationTest
ServerLauncherWaitOnServerMultiThreadedTest
ServerLauncherWithProviderIntegrationTest -> ServerLauncherWithProviderRegressionTest

Merged this PR to develop. Done!


fix(dashboard): i18n need to come in as props

fix the proptypes in Card and a typo in the defaultProps for Card

:tada: This PR is included in version 1.61.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.61.3 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Agg Github icon ans include the link in website

Add a Github link in the website footer

i would like to contribute to this issue @Astrodevil should i create pull request directly as i am a beginner to open source or i should wait

i have done that in the local branch @Astrodevil  waiting for approval to create pull request

i would like to contribute to this issue @Astrodevil should i create pull request directly as i am a beginner to open source or i should wait

Create a PR man !


Unregister-...

I am glad to see that both Register-AzsGuestDirectoryTenant and Register-AzsWithMyDirectoryTenant are working.  However, we have a scenario where in we need to UnRegister both (e.g. service provider is severing their relationship with an existing tenant).  How can this be done?

I only comment about Register-AzsGuestDirectoryTenant.
AzsGuestDirectoryTenant adds DirectoryTenant to Azure Stack by using New-AzureRmResource. So if you want to delete directory tenant from Azure Stack, you can use Remove-AzureRmResource. You can check the resource id of directory tenant at the resource explorer.

@aricbernard we're working on a script to remove Azure Stack from the directory tenant. the other half of this as @kongou-ae mentioned is right. if either of you can propose a pull request with this we'll accept it. Let me know if you can work on this!


mu4e spell check

I have the email app enabled in Doom with spell-checking and I noticed that when composing a message if  my pointer moves from the text body to the message header, spell checking is disabled, but then if my pointer moves back to the text body, spell checking is enabled again (because of the hook in mu4e-compose-mode-hook). Because flyspell is very slow, this means that for long messages I have to wait while the buffer is being scanned before gaining back control of emacs.
Is there a way to fix this? Spell checking should really be enabled only once when first entering compose mode.

It appears org-mu4e is to blame. It switches the buffer to org-mode when your cursor is below --text follows this line--. If you are willing to get rid of this feature, this is easily resolved (at the cost of writing your emails in org-mode) with:
(remove-hook 'mu4e-compose-mode-hook #'org-mu4e-compose-org-mode)

I'm afraid there's little else that can be done. Switching major modes is a very destructive operation; it deletes a lot of buffer-local state, making it impractical to persist minor modes through major mode changes, so Emacs simply disables them. So long as flyspell-mode has to be restarted, you will feel that pause as it initializes.
A possible alternative: write them in markdown and using mu4e-action-view-in-browser to preview your messages beforehand.

Thanks. I opted to disable org-mode editing as you suggested. However, I just want to check, in my case the "pause" while spell-checking is a second or so while the pointer visually traverses every character in my buffer.
My machine is not slow by any stretch. So is this normal?

It is normal, unfortunately. It's a combination of flyspell's design, the slow-to-initialize background processes (ispell/aspell/hunspell) that flyspell employs, and Emacs lacking a decent mechanism for concurrency. Your machine definitely isn't the bottleneck here.


Update provisioning.adoc

Fix two different variations of typos that should be "comma-separated".

R: @jbonofre


Dev

lots of changes!

Again, I didn't thoroughly review your tests.  But for now, I'd stick with high-level testing until you're positive the structure of your code isn't going to change.  Otherwise, you're spending time unit-testing methods that may not be used and will make it harder to refactor later.

The tests are shit right now anyways, you'd be terrified by them, but yeah
I'll address these first before doing any work with the test suite.  Still
have to completely redo some of the functions anyways since this is old
"production code" mostly in the bodies of the functions other than what
I've been reworking already.  More updates to come!
Cheers,
Andres Weber
*Asset Supervisor MPC - NY | *www.moving-picture.com
https://email.moving-picture.com/OWA/redir.aspx?C=b05dc34e5ba941f886a3b21afad35973&URL=http%3A%2F%2Fwww.moving-picture.com%2F
M: +1<PHONE_NUMBER>
E<EMAIL_ADDRESS>On Mon, Dec 19, 2016 at 12:02 PM, Stu Schwartz<EMAIL_ADDRESS>wrote:

Again, I didn't thoroughly review your tests. But for now, I'd stick with
high-level testing until you're positive the structure of your code isn't
going to change. Otherwise, you're spending time unit-testing methods that
may not be used and will make it harder to refactor later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AndresMWeber/Nomenclate/pull/3#issuecomment-268018559,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABg4RlvI3T1jMiyUF3BPietC20vPTEv2ks5rJriOgaJpZM4LQ6EP
.

WOOOO!!!!

yeeeeeeeeeeeeeeeeeeeeeeeeeeeeeehaw!
Coming along nicely
Cheers,
Andres Weber
*Asset Supervisor MPC - NY | *www.moving-picture.com
https://email.moving-picture.com/OWA/redir.aspx?C=b05dc34e5ba941f886a3b21afad35973&URL=http%3A%2F%2Fwww.moving-picture.com%2F
M: +1<PHONE_NUMBER>
E<EMAIL_ADDRESS>On Thu, Dec 22, 2016 at 3:03 PM, Stu Schwartz<EMAIL_ADDRESS>wrote:

WOOOO!!!!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/AndresMWeber/Nomenclate/pull/3#issuecomment-268879285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABg4Rm_cDUP-6qUr2gBaBwM0RzmlR7DSks5rKtebgaJpZM4LQ6EP
.


jobs: fix AST, MNK and add SCH part

fix outdated AST part
fix demolishbox countdown error in MNK part (it start counting down when you cast demolish but DOT appears on target about 1 second later)
add a new part for SCH (based on AST part, in progress and need help, but better than nothing)

This is my first time to use Github and Pull Request and I am new to coding, if something amiss, pray tell me :D

Note: This Pull Request is Work in Progress now, there are some features that would be added in:
[ ] track all the DoTs that SCH have (Bio / Bio II and Biolysis).
[ ] track seraph cooldown
[ ] monitor the aetherflow stacks and fairy duration
[ ] announce user when aetherflow cooldown was going to finish, but they even have several aetherflow stacks to throw. ( e.g. 3 stacks when cd < 15, or 2 stacks when cd < 5 )

Thanks for your review. Most fix has been done.
I've falsed to commit my master branch so it's hard to split AST&MNK out of SCH part.
"track all the DoTs that SCH have"&"announce user when aetherflow cooldown was going to finish, but they even have several aetherflow stacks to throw" has been done.
"track seraph cooldown"&"monitor fairy duration" I think is not needed.
if no more issue or bug appears, I think this PR is ready to be merged.

Fairy Gauge Box has been added
camelCase name has been fixed
smaller fix

@quisquous Done. Local testment pass. Thanks again!

Thanks for the pull request and all the changes.  This looks really nice!  Thanks also @MaikoTan for the assistance and feedback too.  :)