Look: Validate Look Sets fail if mesh has only face assignments

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
When publishing a look on a mesh that for whatever reason has the looks assigned to all the components instead of the shape itself the validation will log it as 'invalid'.

Why does this happen?
This is because querying the members for a shader when there are face assignments Maya returns those like pCube1.f[0:200] instead of pCubeShape1.f[0:200] so it returns the transform - instead of the shape. Which is wildly confusing.
Anyway, we may want to, on collect, if the member has components and the node is a transform collect the shape instead. That may actually even fix potential issues where we're accidentally collecting the ids from the transform instead of the shape?
Expected Behavior:
It should either be allowed (if it doesn't provide issues elsewhere) or provide a clearer validation error so the user knows how to fix it.
Version
1.0.0
What platform you are running on?
Windows
Steps To Reproduce:

Select all faces of a mesh.
Assign a material
Publish

(This is just to make an easy reproducable; however, similar issues may arise on merging or separating meshes or other maya construction history)
Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
ERROR: Missing '|cube|cubeShape' in collected set node 'blinn1SG'
Traceback (most recent call last):
  File "C:\Users\Maqina-RTX-03\AppData\Local\Ynput\AYON\dependency_packages\ayon_2407291312_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "C:\Users\Maqina-RTX-03\AppData\Local\Ynput\AYON\addons\maya_0.2.12-cb.1\ayon_maya\plugins\publish\validate_look_sets.py", line 47, in process
    raise PublishValidationError(
ayon_core.pipeline.publish.publish_plugins.PublishValidationError: 'lookMain' has relationships that could not be collected, likely due to lack of a `cbId` on the relevant nodes or sets.

Additional context:
No response

Workaround for now in the workfile is to run:
from maya import cmds

for sg in cmds.ls(type="shadingEngine"):
    members =cmds.sets(sg, query=True)
    if not members:
        continue

    invalid = []
    for member in members:
        if "." in member:
            invalid.append(member)

    if not invalid:
        continue

    print(f"Fixing {sg}: {invalid}")
    cmds.sets(invalid, remove=sg)

    # Add them as full node
    correct = [member.split(".", 1)[0] for member in invalid]
    cmds.sets(correct, forceElement=sg)
print("Done")

This will basically replace all face assignments to assignments on the full object - and hence avoids the issue.


Automate RV Number Correction

🚀 Feature Proposal
Sometimes RV numbers are received which are formatted incorrectly. Instead of having the user change the filename, the code should be able to automatically correct the number based on the most common errors.
Motivation
Completely automate this process by removing the need to have the user rename the file.
Example
I provide a JSON file which has an RV number such as RV0RV0652. The code should automatically determine the valid RV number from within the incorrectly formatted text and adjust accordingly. The correct RV in this situation would result in RV0652.
Pitch
Automating the RV number in this project removes one of the user processes defined in the README, thus saving users time and completely automating this process from user upload to ingestion.

Closing issue as this was resolved with PR #14


Brand-new burnable pasta already shows 2 views

Describe the bug
When creating a burnable pasta, it instantly shows 2 views. This makes the Burn After: First Read setting useless since it'll be deleted instantly upon creation, before anyone else can see it.
To Reproduce

Go to the Public Test Site: https://pub.microbin.eu/
Set the Burn After option to 10th read
Set the Privacy option to Unlisted (to eliminate the possibility of someone else's views being counted)
Click the Save button.

Expected behavior
The view count would be at 0 because you've just created it and nobody has seen it yet.
Screenshots

Desktop:

OS: Windows 10
Browser: Google Chrome v114.0
Version: v2.0.4 (public test instance, not hosted by me)

Same here. Issue appears on the public demo server as well as on my private instance,
This issue renders the burn after first read option useless unfortunately.
Quick temporary workaround could be to allow a burn after 3 reads options.

the redirect should not count as read..
if you set it to 1 it is already burned when its redirecting after creating

This is still an issue 🤣

Same here, this really does not make any sense to me. To achieve a similar behavior I need to either make it burn after a short period of time or to burn after 10th read.


error will installation with cuda enabled

Hi!
I am trying to install Racon v 1.4.2 with CUDA (10.1) enabled but it throws an error during make (below). Can you please help to identify the issue.
Thanks
Michael
cmake (v. 3.10.2) ran without error
cmake -DCMAKE_BUILD_TYPE=Release -Dracon_enable_cuda=ON -Dracon_build_tests=ON ..

-- The C compiler identification is GNU 7.4.0
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Using CUDA 10.1 from /usr/local/cuda
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of off64_t
-- Check size of off64_t - done
-- Looking for fseeko
-- Looking for fseeko - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Renaming
--     /home/ubuntu/racon/vendor/bioparser/vendor/zlib/zconf.h
-- to 'zconf.h.included' because this file is included with zlib
-- but CMake generates it automatically in the build directory.
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
Setting warning flags
-- Build type: Release
-- Using CUDA 10.1 from /usr/local/cuda
-- Using CUDA 10.1 from /usr/local/cuda
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.13") found components:  doxygen dot
-- Found PythonInterp: /usr/bin/python (found version "2.7.15")
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ubuntu/racon/build

running make resulted in an error:

Scanning dependencies of target spoa
Scanning dependencies of target logging
Scanning dependencies of target gtest
Scanning dependencies of target thread_pool
Scanning dependencies of target zlibstatic
Scanning dependencies of target edlib_static
Scanning dependencies of target logger
[  3%] Building CXX object vendor/thread_pool/CMakeFiles/thread_pool.dir/src/thread_pool.cpp.o
[  6%] Building CXX object vendor/spoa/CMakeFiles/spoa.dir/src/sisd_alignment_engine.cpp.o
[ 10%] Building CXX object ClaraGenomicsAnalysis/common/logging/CMakeFiles/logging.dir/src/logging.cpp.o
[ 13%] Building CXX object vendor/edlib/CMakeFiles/edlib_static.dir/edlib/src/edlib.cpp.o
[ 13%] Building CXX object vendor/spoa/CMakeFiles/spoa.dir/src/alignment_engine.cpp.o
[ 16%] Building CXX object vendor/spoa/CMakeFiles/spoa.dir/src/graph.cpp.o
[ 16%] Building CXX object vendor/spoa/CMakeFiles/spoa.dir/src/simd_alignment_engine.cpp.o
[ 20%] Building CXX object vendor/logger/CMakeFiles/logger.dir/src/logger.cpp.o
[ 23%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/crc32.o
[ 23%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/deflate.o
[ 23%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/inflate.o
[ 26%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/gzwrite.o
[ 30%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/infback.o
[ 30%] Building CXX object vendor/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 30%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/compress.o
[ 33%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/adler32.o
[ 36%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/gzclose.o
[ 36%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/gzread.o
[ 36%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/gzlib.o
[ 36%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/inftrees.o
[ 40%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/inffast.o
[ 40%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/trees.o
[ 43%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/uncompr.o
[ 43%] Building C object vendor/bioparser/vendor/zlib/CMakeFiles/zlibstatic.dir/zutil.o
[ 43%] Linking CXX static library lib/liblogger.a
[ 43%] Built target logger
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:313:30: warning: ignoring attributes on template argument ‘spoa::__mxxxi [] {aka __vector(4) long long int []}’ [-Wignored-attributes]
std::unique_ptr<__mxxxi[]> sequence_profile_storage;
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:318:30: warning: ignoring attributes on template argument ‘spoa::__mxxxi [] {aka __vector(4) long long int []}’ [-Wignored-attributes]
std::unique_ptr<__mxxxi[]> M_storage;
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:322:30: warning: ignoring attributes on template argument ‘spoa::__mxxxi [] {aka __vector(4) long long int []}’ [-Wignored-attributes]
std::unique_ptr<__mxxxi[]> masks_storage;
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:326:30: warning: ignoring attributes on template argument ‘spoa::__mxxxi [] {aka __vector(4) long long int []}’ [-Wignored-attributes]
std::unique_ptr<__mxxxi[]> penalties_storage;
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp: In member function ‘void spoa::SimdAlignmentEngine::realloc(uint32_t, uint32_t, uint32_t)’:
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:386:69: warning: ignoring attributes on template argument ‘spoa::__mxxxi [] {aka _vector(4) long long int []}’ [-Wignored-attributes]
pimpl->sequence_profile_storage = std::unique_ptr<_mxxxi[]>(storage);
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:397:54: warning: ignoring attributes on template argument ‘spoa::mxxxi [] {aka vector(4) long long int []}’ [-Wignored-attributes]
pimpl->M_storage = std::unique_ptr<mxxxi[]>(storage);
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:405:58: warning: ignoring attributes on template argument ‘spoa::mxxxi [] {aka vector(4) long long int []}’ [-Wignored-attributes]
pimpl->masks_storage = std::unique_ptr<mxxxi[]>(storage);
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:413:62: warning: ignoring attributes on template argument ‘spoa::mxxxi [] {aka vector(4) long long int []}’ [-Wignored-attributes]
pimpl->penalties_storage = std::unique_ptr<mxxxi[]>(storage);
^
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp: In instantiation of ‘T* spoa::allocateAlignedMemory(T**, uint32_t, uint32_t) [with T = vector(4) long long int; uint32_t = unsigned int]’:
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:384:61:   required from here
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:36:16: warning: ‘new’ of type ‘vector(4) long long int’ with extended alignment 32 [-Waligned-new=]
storage = new T[size + alignment - 1];
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:36:16: note: uses ‘void operator new ’, which does not have an alignment parameter
/home/ubuntu/racon/vendor/spoa/src/simd_alignment_engine.cpp:36:16: note: use ‘-faligned-new’ to enable C++17 over-aligned new support
[ 46%] Linking C static library ../../lib/libz.a
[ 46%] Built target zlibstatic
[ 46%] Linking CXX static library lib/libthread_pool.a
[ 46%] Built target thread_pool
[ 46%] Linking CXX static library ../../lib/libedlib_static.a
[ 46%] Built target edlib_static
[ 46%] Linking CXX static library lib/libspoa.a
[ 46%] Built target spoa
[ 50%] Linking CXX static library ../../../lib/libgtest.a
[ 50%] Linking CXX static library ../../../lib/liblogging.a
[ 50%] Built target gtest
Scanning dependencies of target gtest_main
[ 50%] Building CXX object vendor/googletest/googletest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o
[ 50%] Built target logging
[ 50%] Building NVCC (Device) object ClaraGenomicsAnalysis/cudaaligner/CMakeFiles/cudaaligner.dir/src/cudaaligner_generated_ukkonen_gpu.cu.o
[ 53%] Building NVCC (Device) object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa_generated_cudapoa_nw_banded.cu.o
[ 53%] Building NVCC (Device) object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa_generated_cudapoa_kernels.cu.o
[ 53%] Building NVCC (Device) object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa_generated_cudapoa_nw.cu.o
[ 56%] Building NVCC (Device) object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa_generated_cudapoa_topsort.cu.o
[ 56%] Building NVCC (Device) object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa_generated_cudapoa_add_alignment.cu.o
[ 56%] Linking CXX static library ../../../lib/libgtest_main.a
[ 56%] Built target gtest_main
Scanning dependencies of target cudaaligner
[ 60%] Building CXX object ClaraGenomicsAnalysis/cudaaligner/CMakeFiles/cudaaligner.dir/src/cudaaligner.cpp.o
[ 60%] Building CXX object ClaraGenomicsAnalysis/cudaaligner/CMakeFiles/cudaaligner.dir/src/aligner.cpp.o
[ 63%] Building CXX object ClaraGenomicsAnalysis/cudaaligner/CMakeFiles/cudaaligner.dir/src/alignment_impl.cpp.o
[ 63%] Building CXX object ClaraGenomicsAnalysis/cudaaligner/CMakeFiles/cudaaligner.dir/src/aligner_global.cpp.o
Scanning dependencies of target cudapoa
[ 63%] Building CXX object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa.cpp.o
[ 66%] Building CXX object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/batch.cpp.o
[ 66%] Building CXX object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/cudapoa_batch.cpp.o
[ 70%] Building CXX object ClaraGenomicsAnalysis/cudapoa/CMakeFiles/cudapoa.dir/src/allocate_block.cpp.o
[ 73%] Linking CXX static library ../../lib/libcudaaligner.a
[ 73%] Built target cudaaligner
[ 73%] Linking CXX static library ../../lib/libcudapoa.a
[ 73%] Built target cudapoa
Scanning dependencies of target racon_test
Scanning dependencies of target racon
[ 73%] Building CXX object CMakeFiles/racon.dir/src/cuda/cudabatch.cpp.o
[ 76%] Building CXX object CMakeFiles/racon.dir/src/cuda/cudaaligner.cpp.o
[ 76%] Building CXX object CMakeFiles/racon_test.dir/test/racon_test.cpp.o
[ 80%] Building CXX object CMakeFiles/racon.dir/src/cuda/cudapolisher.cpp.o
[ 80%] Building CXX object CMakeFiles/racon.dir/src/main.cpp.o
[ 83%] Building CXX object CMakeFiles/racon_test.dir/src/polisher.cpp.o
[ 83%] Building CXX object CMakeFiles/racon_test.dir/src/overlap.cpp.o
[ 83%] Building CXX object CMakeFiles/racon.dir/src/overlap.cpp.o
[ 86%] Building CXX object CMakeFiles/racon_test.dir/src/sequence.cpp.o
[ 86%] Building CXX object CMakeFiles/racon_test.dir/src/window.cpp.o
[ 86%] Building CXX object CMakeFiles/racon.dir/src/window.cpp.o
[ 90%] Building CXX object CMakeFiles/racon.dir/src/sequence.cpp.o
[ 93%] Building CXX object CMakeFiles/racon.dir/src/polisher.cpp.o
[ 93%] Building CXX object CMakeFiles/racon_test.dir/src/cuda/cudabatch.cpp.o
[ 96%] Building CXX object CMakeFiles/racon_test.dir/src/cuda/cudaaligner.cpp.o
[100%] Building CXX object CMakeFiles/racon_test.dir/src/cuda/cudapolisher.cpp.o
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In member function ‘virtual void racon::CUDAPolisher::find_overlap_breaking_points(std::vector<std::unique_ptrracon::Overlap >&)’:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:96:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In member function ‘virtual void racon::CUDAPolisher::find_overlap_breaking_points(std::vector<std::unique_ptrracon::Overlap >&)’:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:96:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In lambda function:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:150:36: error: invalid use of incomplete type ‘class logger::Logger’
logger->bar("[racon::CUDAPolisher::initialize] aligning overlaps");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In lambda function:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:150:36: error: invalid use of incomplete type ‘class logger::Logger’
logger->bar("[racon::CUDAPolisher::initialize] aligning overlaps");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In member function ‘virtual void racon::CUDAPolisher::polish(std::vector<std::unique_ptrracon::Sequence >&, bool)’:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:219:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] allocated memory on GPUs");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:260:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In lambda function:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:297:36: error: invalid use of incomplete type ‘class logger::Logger’
logger->bar("[racon::CUDAPolisher::polish] generating consensus");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In member function ‘virtual void racon::CUDAPolisher::polish(std::vector<std::unique_ptrracon::Sequence >&, bool)’:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:327:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] polished windows on GPU");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:330:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In member function ‘virtual void racon::CUDAPolisher::polish(std::vector<std::unique_ptrracon::Sequence >&, bool)’:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:219:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] allocated memory on GPUs");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:260:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:356:20: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] polished remaining windows on CPU");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:357:20: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In lambda function:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:297:36: error: invalid use of incomplete type ‘class logger::Logger’
logger->bar("[racon::CUDAPolisher::polish] generating consensus");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp: In member function ‘virtual void racon::CUDAPolisher::polish(std::vector<std::unique_ptrracon::Sequence >&, bool)’:
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:327:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] polished windows on GPU");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:330:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:388:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] generated consensus");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:356:20: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] polished remaining windows on CPU");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:357:20: error: invalid use of incomplete type ‘class logger::Logger’
logger->log();
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
/home/ubuntu/racon/src/cuda/cudapolisher.cpp:388:16: error: invalid use of incomplete type ‘class logger::Logger’
logger->log("[racon::CUDAPolisher::polish] generated consensus");
^~
In file included from /home/ubuntu/racon/src/cuda/cudapolisher.hpp:11:0,
from /home/ubuntu/racon/src/cuda/cudapolisher.cpp:13:
/home/ubuntu/racon/src/polisher.hpp:29:11: note: forward declaration of ‘class logger::Logger’
class Logger;
^~~~~~
CMakeFiles/racon.dir/build.make:182: recipe for target 'CMakeFiles/racon.dir/src/cuda/cudapolisher.cpp.o' failed
make[2]: *** [CMakeFiles/racon.dir/src/cuda/cudapolisher.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/racon_test.dir/build.make:182: recipe for target 'CMakeFiles/racon_test.dir/src/cuda/cudapolisher.cpp.o' failed
make[2]: *** [CMakeFiles/racon_test.dir/src/cuda/cudapolisher.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:120: recipe for target 'CMakeFiles/racon_test.dir/all' failed
make[1]: *** [CMakeFiles/racon_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:74: recipe for target 'CMakeFiles/racon.dir/all' failed
make[1]: *** [CMakeFiles/racon.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Hi Michael,
I was refactoring without a valid nvcc compiler, I hope I fixed it in the latest commit. Could you please verify that?
Best regards,
Robert

Fixed. Compilation work!
Thanks a lot for that incredibly fast fix!
Michael


test(slo): reorder jobs

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Codecov Report
Patch coverage has no change and project coverage change: -23.87 :warning:

Comparison is base (e663076) 65.02% compared to head (3bab683) 41.16%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #751       +/-   ##
===========================================
- Coverage   65.02%   41.16%   -23.87%
===========================================
  Files         229      172       -57
  Lines       22698    18711     -3987
===========================================
- Hits        14759     7702     -7057
- Misses       7186    10676     +3490
+ Partials      753      333      -420

Flag
Coverage Δ

?

go-1.17.x
40.89% <ø> (-23.92%)
:arrow_down:

go-1.19.x
41.21% <ø> (-23.42%)
:arrow_down:

go-1.20.x
41.18% <ø> (-23.65%)
:arrow_down:

integration
?

macOS
41.16% <ø> (-0.04%)
:arrow_down:

ubuntu
?

unit
41.16% <ø> (-0.13%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 172 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Predicate writing a key with another's modifiedIndex

Scenario:
Client A wants to write a key iff another critical key's value has not changed since it last read its value.
GET /schema/version
{value: 2, modifiedIndex: 66}

Client A determines it can update another key /foo because of its arbitrary rule based on /schema/version being 2 at the time the write is applied to the store. To avoid a race where Client B updates /schema/version between Client A's read of /schema/version and its write of /foo, we need a write-predicate.
Example:
PUT /foo
value=bar&predicatePath=/schema/version&predicateIndex=66

200 OK

If the PUT fails then:
412 Precondition Failed

This API is purely for demonstration and likely needs more thought.

Addressed by v3 api rfc.


Console logging gets extremely mixed up after a retry

I'm running a very long test suite that sends many requests to our API, so it's nice to be able to log what request I'm sending and what the response is for debugging purposes if a test fails. All goes well if I don't allow retries. Everything stays in order and everything gets printed. However, if I turn on any retrying using this.retries(1) the logging is fine until it hits a retry. Then it starts getting really weird. It continues logging most(some of the console.log statements appear to never be printed), but it puts some out of order and no longer splits into the separate suites. It begins printing everything into one suite until it randomly moves on to the next and is completely out of order. In addition, it doesn't actually print the error that caused the retry until ~3 tests after it happened.
My best guess as to what is causing this is that it has something to do with using promises and/or a setTimeout function in the area that gets retried.

@brubakbd Can you provide an example suite that will reproduce this?

require('mocha');
var variables = require('./../variables.js');
var rules = require('./../rules.js');
var async = require('async');

describe("overall suite", function(){
    this.retries(2);
    it("test one",function(){
        console.log("test one-1");
        console.log("test one-2");
        return new Promise(function(resolve, reject){
            setTimeout(function(){
                resolve("Test one promise response")
            },1000);
        })
            .then(function(resp){
                console.log(resp);
                console.log("Finished test one");
            });
    });
    it("test two",function(){
        console.log("test two-1");
        console.log("test two-2");
        return new Promise(function(resolve, reject){
            setTimeout(function(){
                resolve("Test two promise response")
            },1000);
        })
            .then(function(resp){
                console.log(resp);
                console.log("Finished test two");
            });
    });
    var i = 0;

    it("test three",function(){
        console.log("test three-1");
        console.log("test three-2");
        return new Promise(function(resolve, reject){
            setTimeout(function(){
                if(i===2)
                    resolve("Test three promise response")
                else{
                    reject("i = "+i);
                }
            },1000);
        })
            .then(function(resp){
                console.log(resp);
                console.log("Finished test three");
            });
    });

    it("test four",function(){
        console.log("test four-1");
        console.log("test four-2");
        return new Promise(function(resolve, reject){
            setTimeout(function(){
                resolve("Test four promise response")
            },1000);
        })
            .then(function(resp){
                console.log(resp);
                console.log("Finished test four");
            });
    });

    it("test five",function(){
        console.log("test five-1");
        console.log("test five-2");
        return new Promise(function(resolve, reject){
            setTimeout(function(){
                resolve("Test five promise response")
            },1000);
        })
            .then(function(resp){
                console.log(resp);
                console.log("Finished test five");
            });
    });
});

When looking at the console log for test one I see:
test one-1
test one-2
Test one promise response
Finished test one

Test two:
test two-1
test two-2
Test two promise response
Finished test two

First attempt of test three:
test three-1
test three-2test three-1
test three-2test three-1
test three-2test four-1
test four-2
Test four promise response
Finished test fourtest five-1
test five-2
Test five promise response
Finished test five
Process finished with exit code 1

Test four has nothing
Test five has nothing
Second iteration of test three has nothing
3rd iteration of test tree that fails:
Error: the string "i = 0" was thrown, throw an Error :)

Also, should the test three retries be running at the end? It appears that it fails once, then goes to four and five, then comes back to three for the retries. I couldn't find any documentation on what Mocha's retry is supposed to do.

someone should review this

Closing this as I am unable to reproduce with the latest mocha, feel free to re-open if this issue persists.


HTML

Instructions:
Translate canvas from SVG to HTML.

Solve problem with uncentering toolbar.

Add ability for adding image.

Separate redrawing methods in blockshot.

closed #37


Delve

Delve is missing from the approved apps list

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0073f5a8-daf6-7f14-127f-e0c9d80af78d
Version Independent ID: d6d0afdf-3619-ca03-718b-a40bfd07bab9
Content: Azure Active Directory conditional access settings reference
Content Source: articles/active-directory/conditional-access/technical-reference.md
Service: active-directory
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@ri-we
Thanks for your feedback! We will investigate and update as appropriate.

@ri-we Please note that currently the setting applies to the client apps mentioned here. Look forward to see updates on adding more client apps in near future.

@ri-we We will now proceed to close this thread. If there are further questions regarding this matter, please open a new issue and we will gladly continue the discussion.

@ri-we We will now proceed to close this thread. If there are further questions regarding this matter, please open a new issue and we will gladly continue the discussion.


Fix APIScanner NPE when running MTE tests

there are two packages named org.terasology.input.binds.inventory: one in the engine, one in the Inventory module. The engine one is @API, but the Inventory one is not. When the APIScanner looks for API annotated types, Reflections sometimes thinks it's returning the engine package but actually returns the Inventory package. APIScanner is unable to find the annotation on the Inventory package,  causing an NPE.
This is fixed by removing the API annotation from the package and moving it to the only class in the package, UseItemButton.
Resolves Terasology/ModuleTestingEnvironment#9.

Hooray Jenkins reported success with all tests good!

Tested this locally but weirdly can't seem to push my merge from the local workspace. Merging via UI button instead.
Thanks for the detective work @eviltak this is an important fix!


[build-script] NFC: Update URL of Swift repository in message.

Since Swift project had adopted new GitHub organization, the URL of this repository was changed.
This PR fixes the URL in 'build-script'.

While there are more than 1000 old URL descriptions(https://github.com/apple/swift/*) in this repository, changing them at once may be an excessively huge commit.
That's why this PR contains only one commit.
As a side note, 'GettingStarted.md' has been already updated by another PR.

@swift-ci Please Python lint

@swift-ci Please smoke test

@swift-ci Please smoke test macOS platform

Unrelated failure again...
@swift-ci Please smoke test macOS platform

Test Case '-[SwiftDriverTests.SwiftDriverTests testRelativeResourceDir]' failed has occurred repeatedly from smoke test on macOS #14408 to smoke test on macOS #14432.
But it seems now to be fixed.
@swift-ci Please smoke test macOS platform

@swift-ci Please smoke test macOS platform

@swift-ci Please smoke test macOS platform

@swift-ci Please smoke test macOS platform


Let's notify Mac Silicon users who are running VS Code Intel build

Based on https://twitter.com/irreverentmike/status/1463532471614681105 I think we should make our Apple Silicon builds more discoverable.
I hate notifications but I think for Mac Silicon users that are running VS Code Intel we should show a notification in the sense "We noticed you are running an intel build while you are on a sillicon machine, consider switching to sillicon..."
If we do not want to use a barbaric notification on startup I suggest to show a dialog box once the user clicks on the Update button - that means the user is "in the zone" to switch builds.
fyi @bpasero @joaomoreno

Another option I could think of is doing the update transparently to the user. This would also cause less confusion for those who are not that familiar with architectures.
Next time there's a new VS Code release, we could fetch the Apple Silicon build rather than the Intel build and automatically install that. (We can then show a notification saying "we updated your app to take advantage of the performance optimizations for Apple Silicon" or something like that).

Thanks for sharing my article @isidorn, this is a great idea for an improvement. I wonder if there might be an opportunity to work this into electron as well - I'm going to do some spelunking in their issues to see if anyone has brought up a similar notion in the past.

/duplicate https://github.com/microsoft/vscode/issues/132598


Backport mbedtls-sys to 0.7

Ported the latest mbedtls-sys from 0.8 to 0.7

This is making all kinds of breaking changes, it can't be an update to 0.7

dropping as it's not needed


Update cmdlets in deployment-guide.md

Closes https://github.com/MicrosoftDocs/Viva/issues/311.

@lilyolason PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@madehmer @lilyolason PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


add RDG012 example

Fixes #30484
https://github.com/dotnet/AspNetCore.Docs.Samples/pull/207 needs to be merged first

Internal previews

📄 File
🔗 Preview link

aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg012.md
RDG012: Unable to resolve inaccessible type

@timdeschryver  when I run the sample, I get
 System.InvalidOperationException
  HResult=0x80131509
  Message=Call UseKestrelHttpsConfiguration() on IWebHostBuilder to automatically enable HTTPS when an https:// address is used.
  Source=Microsoft.AspNetCore.Server.Kestrel.Core

@Rick-Anderson I'll take a look at it later today

@Rick-Anderson if I'm not mistaken this is because the snippets use WebApplication.CreateSlimBuilder() . With the slim builder you need to enable/configure https support. Using WebApplication.CreateBuilder() fixes this problem.
If you agree we can update all the examples to use  WebApplication.CreateBuilder() (I think this is also the most used)
in https://github.com/dotnet/AspNetCore.Docs.Samples/issues/201.

If you agree we can update all the examples to use WebApplication.CreateBuilder() (I think this is also the most used)
in https://github.com/dotnet/AspNetCore.Docs.Samples/issues/201.

Let's do one PR and have the PU (product unit) review it. Anything we can do to simplify the code is beneficial.

@Rick-Anderson if I'm not mistaken this is because the snippets use WebApplication.CreateSlimBuilder() . With the slim builder you need to enable/configure https support. Using WebApplication.CreateBuilder() fixes this problem.

That fixes it. The Properties\launchSettings.json I added didn't, so I'll remove that file. But I'm not getting a warning.


Is this the wrong part of the code or did you mean it?

First of all, thank you for the code of this nice research! I am currently trying to evaluate its performance on Gibson dataset with the same configuration settings as for MP3D. I’ve noticed an issue where the planned paths incorrectly pass through walls, particularly in scenes with multiple rooms connected only by narrow doors. An example of this can be seen in the attached pictures from the Cantwell scene. (I changed viewpoint of o3d visualizer)

While investigating, I suspect there might be an issue with the collision check in the RRT implementation. It seems that the line of code intended to move from point pa to point pb but stops just before a collision occurs,  but curiously, self.goal._xyz_arr is located at pa instead of pb. Is this intentional, or could it be an error?
(Actually, swapping the positions of self.nodes[-1]._xyz_arr and self.goal._xyz_arr in the function input seems to correct the issue with the erroneous paths.)
Could you please clarify if there’s a rationale behind this implementation, or if it is indeed a mistake?
Thank you for your assistance.

Hi @Taekbum , thanks for pointing out this issue.
It seems to me that it is a mistake in our released code (I will double check the internal commit history and see if we had this issue while running our experiements).
I think the reasons this wasn't discovered previously are
(1) most of our scenes are not multi-room environement , probably the major reason;
(2) we have additional collision detection mechanism in MP3D that prevents it from collision, even the planned path turns out to be not completely free from collision. Please see https://github.com/oppo-us-research/NARUTO/blob/0eb0240033d5252228ffc88a9a15a78700cdd89b/src/planner/naruto_planner.py#L566
I have already updated the release code. Thanks again.


convolutional_recurrent.py:get_initial_state type mismatch

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary (pip, tf-nightly-gpu)
TensorFlow version (use command below): 2.1.0-dev20191228
Python version: 2.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.0
GPU model and memory: Tesla M60 7618MiB

Training a model with a ConvLSTM2D layer and float16 (K.set_floatx('float16')) results in a type mismatch. convolutional_recurrent.py:get_initial_state initializes zeros without specifying a type, defaulting to float32.
For me, specifying the dtype as that of the function inputs resolved the issue:
    initial_state = self.cell.input_conv(initial_state,
                                         array_ops.zeros(tuple(shape)),
                                         padding=self.cell.padding)

becomes
    initial_state = self.cell.input_conv(initial_state,
                                         array_ops.zeros(tuple(shape),dtype=inputs.dtype),
                                         padding=self.cell.padding)```

@dancaselden
Request you to provide simple standalone code to reproduce the issue in our environment. It helps us in localizing the issue faster. Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

@dancaselden
Any update on this issue please. Thanks!

@dancaselden Is this still an issue for you? I ran your code with tf-nightly and cannot reproduce the error. Can you PTAL at the gist here. Thanks!
Please verify and close the issue if this was resolved for you. Thanks!

@jvishnuvardhan with python 3.6 and tf-nightly-gpu on June 5 2020, this issue does not occur. closing!


Specify CommandType as Application

Related to #478. This is a better fix. By specifying the CommandType as Application we can continue looking for git (exe or cmd) but avoiding any potential aliases the user may have created for "git".

You beat me to it.  :-)


Upgrade httpclient to 4.5.12 and upgrade httpcore to 4.4.13

httpclient has dependency on httpcore and most others that depend on httpclient also depend on httpcore. Note also that httpclient 4.5.11 upgraded httpcore dependency to 4.4.13 accoridng to the changelogs. Here are the list of other dependencies with a dependency on httpclient/httpcore.
libthrift
aws-java-sdk-core
cos_api
hadoop-auth
aliyun-sdk-oss
joss
hadoop-azure
hadoop-ozone-filesystem
hadoop-auth

libthrift
aws-java-sdk-core
cos_api
hadoop-auth
aliyun-sdk-oss
joss
hadoop-azure
hadoop-ozone-filesystem
hadoop-auth

Do all of these use the same version of httpclient/httpcore? Do they all at least use the same major version?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10575/
Test FAILed.

alluxio-bot, test this please.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10588/
Test FAILed.

httpcore upgrade seems to be happening very cleanly but everything seems to break down when I go from httpclient 4.5.6 to 4.5.7 so going to check 4.5.6 to see if things are working before looking through to see what has changed in 4.5.7 to cause everything to break down.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10592/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10591/
Test FAILed.

Wow so this passed?.. Alright time to get to bottom of the difference between 4.5.6 and 4.5.7

alluxio-bot, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10593/
Test PASSed.

Found the reason for this issue:
https://issues.apache.org/jira/browse/HTTPCLIENT-1975
https://issues.apache.org/jira/browse/HTTPCLIENT-1983

I'm gonna have to revisit later in upgrading httpclient past 4.5.6. There are some ways but it will get annoying.

@ZacBlanco Yes, all the version upgrades that happened in the dependency tree were all minor version upgrades from 4.5.3 -> 4.5.6 and 4.4.6 to 4.4.13

Can you merge this for me? @ZacBlanco

alluxio-bot, merge this please


flashing on F091RC fails (Same as #356 but mass erase does not work)

[X] Programmer/board type: Stlink/v2
[X] Operating system: Linux
[X] Stlink commandline tool name: st-flash &  st-util
[X] Target chip (and optional board): STM32F091RC

I am seeing the issue mentioned in : https://github.com/texane/stlink/issues/356
I tried mass erase and flash but that did not work.
OUTPUT/ERROR of the commandline tool(s)

F091RC$ st-flash erase
st-flash 1.3.1-19-g55c0572
2017-06-30T18:51:00 INFO src/common.c: Loading device parameters....
2017-06-30T18:51:00 INFO src/common.c: Device connected is: F09X device, id 0x10006442
2017-06-30T18:51:00 INFO src/common.c: SRAM size: 0x8000 bytes (32 KiB), Flash: 0x40000 bytes (256 KiB) in pages of 2048 bytes
Mass erasing

F091RC$ st-flash write ./BUILD/NUCLEO_F091RC/GCC_ARM/example.bin 0x8000000
st-flash 1.3.1-19-g55c0572
2017-06-30T18:51:11 INFO src/common.c: Loading device parameters....
2017-06-30T18:51:11 INFO src/common.c: Device connected is: F09X device, id 0x10006442
2017-06-30T18:51:11 INFO src/common.c: SRAM size: 0x8000 bytes (32 KiB), Flash: 0x40000 bytes (256 KiB) in pages of 2048 bytes
2017-06-30T18:51:11 INFO src/common.c: Attempting to write 124096 (0x1e4c0) bytes to stm32 address: 134217728 (0x8000000)
Flash page at addr: 0x0801e000 erased
2017-06-30T18:51:13 INFO src/common.c: Finished erasing 61 pages of 2048 (0x800) bytes
2017-06-30T18:51:13 INFO src/common.c: Starting Flash write for VL/F0/F3/F1_XL core id
2017-06-30T18:51:13 INFO src/flash_loader.c: Successfully loaded flash loader in sram
2017-06-30T18:51:13 ERROR src/flash_loader.c: write error, count ==<PHONE_NUMBER>
2017-06-30T18:51:13 ERROR src/common.c: stlink_flash_loader_run(0x8000000) failed! == -1
stlink_fwrite_flash() == -1

Expected/description:
Should be able to flash without issues

I could reproduce it again today.
Mass erase did not work.
But when i unplugged st-link from power and connected back(basically reset st-link), i was able to flash..

Hi, same problem on  L073RZ.
Mass erase did not work. Reset did not work too.
It works some time but not a lot ...
Always this errors :
st-flash 1.4.0-1-g5e740a8
2017-07-06T15:51:16 INFO src/common.c: Loading device parameters....
2017-07-06T15:51:16 INFO src/common.c: Device connected is: L0x Category 5 device, id 0x20086447
2017-07-06T15:51:16 INFO src/common.c: SRAM size: 0x5000 bytes (20 KiB), Flash: 0x30000 bytes (192 KiB) in pages of 128 bytes
2017-07-06T15:51:16 INFO src/common.c: Attempting to write 105836 (0x19d6c) bytes to stm32 address: 134217728 (0x8000000)
Flash page at addr: 0x08019d00 erased
2017-07-06T15:51:22 INFO src/common.c: Finished erasing 827 pages of 128 (0x80) bytes
2017-07-06T15:51:22 INFO src/common.c: Starting Half page flash write for STM32L core id
2017-07-06T15:51:22 INFO src/flash_loader.c: Successfully loaded flash loader in sram
2017-07-06T15:51:26 ERROR src/flash_loader.c: flash loader run error
2017-07-06T15:51:26 WARN src/common.c: l1_stlink_flash_loader_run(0x8000000) failed! == -1
2017-07-06T15:51:26 WARN src/common.c:
write_half_pages failed == -1
825/826 pages written
2017-07-06T15:53:05 INFO src/common.c: Starting verification of write complete
2017-07-06T15:53:07 INFO src/common.c: Flash written and verified! jolly good!
Of course it's not working.

I had this issue, and resolved it by bringing my st-link firmware up-to-date using the windows utility.  It now functions in linux perfectly.

Update:  After firmware update, I was able to flash my own code, but I was still unable to flash the bootloader using st-flash or gdb.  The windows utility reported that the pages involved were write-protected in the option bytes.  When told to program the area, it was able to disable the write protection, flash, and then re-enable it, which I suppose is a feature that st-flash lacks.

Please verify if the problem still exists in Release v1.6.0.

@binary-nerd @fuzzyTew: Any updates on this? Have you tried with Release v1.4.0?

I'm sorry, I no longer have ready access to this hardware.

Ok, no problem. Thx for your feedback tough.

Duplicate of #597.


Crashes Server

Loading this mod on an Minecraft Server caused the whole server to crash instantly...

Don't load it on a server, it's a client-side mod.


add Global Banking School

GBS
Domain - @globalbanking.ac.uk

@send-js Thank you for your patience while waiting for a review and processing your request. Pull request merged.


[Bug] Ark crashes after a fixed time in the menu after patching

So, prior to patching, the game always crashed as I expect.
After the patch though, the game boots up, plays music and crashes after a few seconds. It seems the time it takes to crash is always the same.
Here's a screen recording of that in action:
https://user-images.githubusercontent.com/47925793/179478987-4da86958-4229-470d-b71b-02480ca9603e.mov
And here's a crash dump from the console app:
https://paste.sangelo.space/opifisufep.pl
I don't know weather this is due to the patcher or my M1 mac. I've tried both the Intel and the NVIDIA options.
I am running this on a 2020 13" MacBook Pro

That is very very strange. Could you post the crash log when the patch is removed?

How can I grab the crash log ?
I've got this issue too can remove patch and grab log.

Just the log at the bottom of the patcher window.

URL: file:///Users/jackhonour/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/
Starting patch...
Exec URL: file:///Users/jackhonour/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/Contents/MacOS/ShooterGame
Backup URL: file:///Users/jackhonour/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/Contents/MacOS/ShooterGame.bak
Patch removed!

and
URL: file:///Users/jackhonour/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/
Starting patch...
Exec URL: file:///Users/jackhonour/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/Contents/MacOS/ShooterGame
Backup URL: file:///Users/jackhonour/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/Contents/MacOS/ShooterGame.bak
Macho: Executable (x86_64)
Symbol:
<Section Symbol 0x60001447ca00; contextAddress = 0x65663c8; size = 16> {
	strx = 35266274
	type = 15
	sect = (null)
	desc = 0
	value =<PHONE_NUMBER>
	name = __Z16IsRHIDeviceIntelv
	section = __TEXT,__text
	address = 0x00000001026d29d0
}
Section:
<Section 0x60001447cda0; contextAddress = 0x8980; size = 65429174> {
	name = __text
	alignment = 32
	fileOffset = 0x0000000000008980
	vmAddress = 0x0000000100008980
	size = 65429174
	type = S_REGULAR
	userAttributes = S_ATTR_PURE_INSTRUCTIONS
	systemAttributes = (1<<10)
}
Symbol file offset: 0x26D29D0
Patched symbol at 0x26D29D0
Symbol:
<Section Symbol 0x60001447c2c0; contextAddress = 0x6566758; size = 16> {
	strx = 35269544
	type = 15
	sect = (null)
	desc = 0
	value =<PHONE_NUMBER>
	name = __Z17IsRHIDeviceNVIDIAv
	section = __TEXT,__text
	address = 0x00000001026d2a10
}
Section:
<Section 0x60001447c840; contextAddress = 0x8980; size = 65429174> {
	name = __text
	alignment = 32
	fileOffset = 0x0000000000008980
	vmAddress = 0x0000000100008980
	size = 65429174
	type = S_REGULAR
	userAttributes = S_ATTR_PURE_INSTRUCTIONS
	systemAttributes = (1<<10)
}
Symbol file offset: 0x26D2A10
Patched symbol at 0x26D2A10
Patch successful!

hmmm, after removing patch and re-applying to get that log it no longer crashes.

Glad to hear it! I'm going to close this issue for now, if you or someone else runs into this issue again please leave a comment.

Sorry for commenting on a closed issue, but since I found that I'm facing an extremely similar issue as this.
In my case, the ARK crashing behavior just looks the same as the one shown in the above recording. The game boots up, plays music and crashes after a few seconds. Also, the time it takes to crash also seems to be the same always.
I have tried to verify the game file with Steam, and repatch "ShooterGame.app", but it hasn't made any change. Here below is my patching log(Intel mode):
URL: file:///Users/gordon/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/
Starting patch...
Exec URL: file:///Users/gordon/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/Contents/MacOS/ShooterGame
Backup URL: file:///Users/gordon/Library/Application%20Support/Steam/steamapps/common/ARK/ShooterGame.app/Contents/MacOS/ShooterGame.bak
Macho: Executable (x86_64)
Symbol:
<Section Symbol 0x600024b68400; contextAddress = 0x6570298; size = 16> {
	strx = 35272103
	type = 15
	sect = (null)
	desc = 0
	value =<PHONE_NUMBER>
	name = __Z16IsRHIDeviceIntelv
	section = __TEXT,__text
	address = 0x00000001026d7ca0
}
Section:
<Section 0x600024b68500; contextAddress = 0x9420; size = 65454678> {
	name = __text
	alignment = 32
	fileOffset = 0x0000000000009420
	vmAddress = 0x0000000100009420
	size = 65454678
	type = S_REGULAR
	userAttributes = S_ATTR_PURE_INSTRUCTIONS
	systemAttributes = (1<<10)
}
Symbol file offset: 0x26D7CA0
Patched symbol at 0x26D7CA0
Symbol:
<Section Symbol 0x600024b68760; contextAddress = 0x6570628; size = 16> {
	strx = 35275373
	type = 15
	sect = (null)
	desc = 0
	value =<PHONE_NUMBER>
	name = __Z17IsRHIDeviceNVIDIAv
	section = __TEXT,__text
	address = 0x00000001026d7ce0
}
Section:
<Section 0x600024b68840; contextAddress = 0x9420; size = 65454678> {
	name = __text
	alignment = 32
	fileOffset = 0x0000000000009420
	vmAddress = 0x0000000100009420
	size = 65454678
	type = S_REGULAR
	userAttributes = S_ATTR_PURE_INSTRUCTIONS
	systemAttributes = (1<<10)
}
Symbol file offset: 0x26D7CE0
Patched symbol at 0x26D7CE0
Patch successful!

Environment:
2021 MacBook Pro M1 Max
MacOS 13.2.1（22D68）


Upgrade to 2020-11-08

If anyone wants to help out: instructions are in https://github.com/theduke/quickjs-rs/blob/master/libquickjs-sys/README.md

trying this out, the readme is slightly off the command is not
just quickjs-update
but
just update-quickjs

ok, i updated under https://github.com/HiRoFa/quickjs-rs/tree/issue87
(yes i was 2 of, doesn't matter :)
running cargo test runs fine,
but when running cargo test --all-features i get the following error
Applying patches...
Applying "js-tobigint64-overflow.patch"...
thread 'main' panicked at 'Could not apply patches: Os { code: 2, kind: NotFound, message: "No such file or directory" }', libquickjs-sys/build.rs:142:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

When examining that file the only file references i see are to libbf.c and quickjs.c which both still exist..
the only thing i can see is that the line number 11244 is now at 12201.. i tried changing that but lets face it, i have absolutely no clue what i'm doing here :) and it changed nothing...
so good luck to the next guy!

Haha, thanks.
Please open a PR, I will look into fixing up the patch.

reopended https://github.com/theduke/quickjs-rs/pull/90


Stop marking attachments as present at unpublished

Now that we have an unpublished state for editions, we no longer need to keep track of whether attachments were present at the edition's unpublishing, because unpublished editions now have to be superseded. Previously, unpublished editions were put into the draft state and it was therefore necessary to track which attachments were present when it was unpublished so that we could distinguish them from attachments which had been added to the draft since unpublishing.
I have added a migration to remove the database column from the attachment data table as well. I was undecided about whether to include this in the PR. On the one hand it's an irreversible change, so it would probably make sense to merge this PR and run for a few days without marking attachments as present to check that there are no ill effects. On the other, not including the migration presents the risk that we might forget to come back to tidy up and we'll have a dead database column hanging around. Let me know if the preferred option would be option 1 and I'll remove the migration commit from the PR.
Trello: https://trello.com/c/X4KpEBA7

Looks good to me too 👍


refactor: Manifest required keys

# Required keys in a mod's manifest.json file
const REQUIRED_MANIFEST_KEYS_ROOT = [
	"name",
	"namespace",
	"version_number",
	"website_url",
	"description",
	"dependencies",
	"extra",
]

# Required keys in manifest's `json.extra.godot`
const REQUIRED_MANIFEST_KEYS_EXTRA = [
	"authors",
	"compatible_mod_loader_version",
	"compatible_game_version",
	"incompatibilities",
	"config_schema",
]

The following keys can be made optional:

[x] website_url ( required by Thunderstore )
[x] incompatibilities done in #237
[x] config_schema done in #261

closed by #261


[ChatAI] SDK - Ainize Container E2E testing

Summary

Conducted end-to-end(E2E) testing covering Chat, Credit, Assistant, Thread functionalities.

Quickly resolve the issue with the container response format for Message by tomorrow.
Currently, temporarily commented out the test code for Message.

Simplified the request parameters.
Removed mock data from test codes to enable direct communication with ainize container through ainize-js.

Thank you for reviews! @platfowner @minsulee2 now merging..


ONVIF Motion Events not working on recent firmwares

Description

ONVIF events no longer work on firmware 1.3.4 and 1.3.5.
The issue affects also https://www.home-assistant.io/integrations/onvif/
Issue will most probably need to be fixed on cameras via firmware

Reproduction Steps

Update to firmware 1.3.5 or 1.3.4
Observe motion sensor no longer working

Expected behavior
Motion sensor working.
If applicable, add error logs.
No response
Device Firmware
1.3.4 build 230305 rel. 65277n(4555), 1.3.5 build 230307 rel. 6847n(4555)
Using stream component
Yes
Does camera work via official integrations?
Yes
Camera has all attributes filled out in developer tools
Yes
HASS Environment
All
Search for similar issues
Yes
Additional information
No response

Please test with https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/releases/tag/5.1.0 .

It works with 5.1.0!

It works with 5.1.0!

What camera model? I have 2 x C200, FW 1.3.4 & 1.3.5 and the motion sensor is still 'unavailable' after updating the integration. Will take a look at the logs later today, on the phone right now. Thanks!

C225. Make sure HA is updated to the latest version. After updating the integration, restart both the container/computer and the camera.

Please follow steps above.

It's the same problem and I included logs unlike most others? Now it's worse because I removed the C210 as my map is still screwed, now it too has lost the motion sensor?

I marked your comment as off topic to keep the discussion on topic.

Your comment is unrelated to this issue
You have not followed instructions I posted above, rendering the comment not helpful at all
Logs posted have nothing to do with onvif, motion sensor or binary sensor.

Please refrain from posting more unrelated comments unless you follow instructions I posted above.

Hello.
I have 2 different cameras:
1 C200 running on 1.3.5 Build 230307 Rel.6847n(4555) contains string 'hol' in it's name
1 C210 running on 1.3.0 Build 220830 Rel.69909n(4555) contains string 'living' in it's name
For some time, the motion sensor from C200 is not working. Usually when I had this issue, it was fixed after a restart of HA or reboot of the camera.
The C210 one is still working as expected.

I have enabled the debug on the two entities and got the attached log.
I cannot see any ERRORS, maybe you can spot something that it shouldn't be there.
home-assistant_2023-04-19T07-20-50.421Z.log

Thank you for your report and logs @mitzu2250 .
The important part of the logs is below:
2023-04-19 10:17:09.551 DEBUG (MainThread) [custom_components.tapo_control] Setting up subscription to motion sensor...
2023-04-19 10:17:09.551 DEBUG (MainThread) [custom_components.tapo_control] Initiating onvif.
2023-04-19 10:17:10.031 DEBUG (MainThread) [custom_components.tapo_control] {'device': <onvif.client.ONVIFCamera object at 0x7f00c5ddb8b0>, 'device_mgmt': <onvif.client.ONVIFService object at 0x7f00c5ddad10>}
2023-04-19 10:17:10.031 DEBUG (MainThread) [custom_components.tapo_control] setupOnvif - entry
2023-04-19 10:17:10.031 DEBUG (MainThread) [custom_components.tapo_control] Setting up onvif...
2023-04-19 10:17:10.031 DEBUG (MainThread) [custom_components.tapo_control] setupEvents - entry
2023-04-19 10:17:10.031 DEBUG (MainThread) [custom_components.tapo_control] Setting up events...
2023-04-19 10:17:10.910 DEBUG (MainThread) [custom_components.tapo_control] async_update_data - entry
2023-04-19 10:17:10.910 DEBUG (MainThread) [custom_components.tapo_control] Motion sensor or time sync is enabled.
2023-04-19 10:17:10.910 DEBUG (MainThread) [custom_components.tapo_control] Setting up subscription to motion sensor...
2023-04-19 10:17:10.910 DEBUG (MainThread) [custom_components.tapo_control] Initiating onvif.
2023-04-19 10:17:11.160 DEBUG (MainThread) [custom_components.tapo_control] {'device': <onvif.client.ONVIFCamera object at 0x7f00c6fddbd0>, 'device_mgmt': <onvif.client.ONVIFService object at 0x7f00c6fde6e0>}
2023-04-19 10:17:11.160 DEBUG (MainThread) [custom_components.tapo_control] setupOnvif - entry
2023-04-19 10:17:11.160 DEBUG (MainThread) [custom_components.tapo_control] Setting up onvif...
2023-04-19 10:17:11.160 DEBUG (MainThread) [custom_components.tapo_control] setupEvents - entry
2023-04-19 10:17:11.160 DEBUG (MainThread) [custom_components.tapo_control] Setting up events...
2023-04-19 10:17:15.275 DEBUG (MainThread) [custom_components.tapo_control] Events started.
2023-04-19 10:17:15.275 DEBUG (MainThread) [custom_components.tapo_control] Creating binary sensor entity.
2023-04-19 10:17:15.275 DEBUG (MainThread) [custom_components.tapo_control] Binary sensor creation for motion has been forwarded to component.

This shows us the difference in behaviour in C200 on 1.3.5 and C210 1.3.0, where C210 allows to be subscribed into (the second "setupEvents - entry" followed up by "Events started.") and C200 does not (no "Events started.").

This integration is using onvif from HA, so it will need to be fixed upstream (if there is anything to fix). It is also possible that there is a bug in the new firmware that bricked the onvif. At this point I would recommend:

Testing with official onvif integration, if it does not work, open issue in HA github for onvif integration
Downgrading firmware back to 1.3.0 or below which is confirmed to work.

Any advice/link on how the downgrade can be done? Couldn't find anything really useful. Thanks!

https://github.com/nervous-inhuman/tplink-tapo-c200-re/issues/4#issuecomment-1030056785

Just checked with the main ONVIF integration. I can confirm that for my C200 camera, the "Camera Living Cell Motion Detection" entity doesn't pop up when motion is happening but it works good on C210.
I'll open a issue on ONVIF side to see if this can be solved there or it's a TP-Link issue.

With the latest updates (Alpha Channel), the motion sensor starts working with my C320WS (latest Firmware: 1.0.4 Build 221031 Rel.40874n).
I'm currently getting some new error messages that I haven't had before, but it still works, so not a big deal for me - and i'm on the alpha version.
The error messages i get are:
    if not hass.data[DOMAIN][config_entry.entry_id]["events"].started:
AttributeError: 'bool' object has no attribute 'started'

The second error is:
    hass.data[DOMAIN][entry.entry_id]["events"] = EventManager(
TypeError: EventManager.__init__() missing 1 required positional argument: 'name'

I don't have any error messages before the last updates.
Home Assistant 2023.5.0.dev20230424
Supervisor 2023.04.1
Operating System 11.0.dev20230420
Frontend 20230424.0.dev - latest
Tapo: Cameras Control 5.1.2

New version for testing is available at https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/tree/5.1.3 . Install manually, warnings expected (using them as debugging). Only usable with DEV version of HA.

@thomasramm just released new version, could you please test?

Tested Version 5.1.3: no error messages!
Make some reboots, motion detections with saving snapshots, try the live stream and change some settings. Everything works well.
I Forget to write, that the binary sensor "TapoCamera Motion" is shown in the system, but did not work (a message says it is not available and i should remove it). But the  Onvif "Cell Motion detection" is working, so this is not a problem.
(I have add the Tapo Integration and the Onvif Integration for the same cam. Both Entities are shown together on the same device).
Yesterday i get 500 motion detections, it works stable at my installation. I'm very happy :-)
Tested with this configuration:
Home Assistant 2023.5.0.dev20230425
Supervisor 2023.04.1
Operating System 11.0.dev20230424
Frontend 20230425.0.dev - latest

It should be working just from this integration. It is possibly it is not working for you because you are hitting it twice at the same time. Try removing onvif and using just Tapo, it should expose motion sensor.

2023.4 here. Do I have to wait until I will update to 2023.5? Thanks.

New version is usable with DEV version of HA or 2023.5.0 and higher if you are reading this from the future.
So if you want to use stable version, yes.

It should be working just from this integration. It is possible it is not working for you because you are hitting it twice at the same time. Try removing onvif and using just Tapo, it should expose motion sensor. Test for at least an hour or so, camera is really unstable when ending and creating new onvif sessions (at least my c200 is). If not working please enable debug logs and attach here.

you are right, i remove the onvif integration, after some reboots or after a longer time (doesn't know which was the reason) the Tapo Motion Sensor starts working.
Thanks to your support and your hard work on this integration.
Thomas

@thomasramm Hi! Could you help me please?
I have this configuration:
Home Assistant 2023.5.0.dev20230426
Supervisor 2023.04.1
Frontend 20230426.0.dev - latest

but HACS doesn't install Tapo: Cameras Control integration.
When I trying to (re)install integration I see next error message in the log file:
2023-04-26 22:07:55.614 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [281472534378960] Error handling message: Unknown error (unknown_error) Ivan from <IP_ADDRESS> (Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Home Assistant/2023.4 (io.robbie.HomeAssistant; build:2023.460; macOS 13.3.1) Mobile/HomeAssistant, like Safari)
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/config/custom_components/hacs/websocket/repository.py", line 216, in hacs_repository_download
    await repository.async_install()
  File "/config/custom_components/hacs/repositories/base.py", line 899, in async_install
    await self.async_install_repository()
  File "/config/custom_components/hacs/repositories/base.py", line 939, in async_install_repository
    raise HacsException("The version of Home Assistant is not compatible with this version")
custom_components.hacs.exceptions.HacsException: The version of Home Assistant is not compatible with this version

Follow manual installation steps.

I have C200, firmware 1.3.5, Tapo: Cameras Control - 5.1.2
HA Core:  2023.4.6
HA Supervisor: 2023.04.1
Tapo Camero Motion sensor always unavailable.
Restart of camera doesn't help.
Is the any way to activate it?
Is my understanding correct: downgrade firmware to 1.3.0 or wait for HA 2023.5.0 upgrade?

HA 2023.5.0 might not solve the issue if it is indeed a firmware issue, we will see what users report.

HA 2023.5.0 might not solve the issue if it is indeed a firmware issue, we will see what users report.

OK.
One more thing: On camera TAPO software I receive push notifications about motion detection, but in sensor HA still have status unavailable.

I wrote to TP-Link regarding this issue and from the replies, the Tapo developers are stating that there is no change on the ONVIF part of the cameras in the latest 1.3.x firmware.
Given this, looks like it's an issue on Home Assistant side, as the ONVIF is working with other software like iSpy as per these instructions on the official TP-Link website https://www.tp-link.com/en/support/faq/2680/

@aIexus I noticed that too with the push notifications, is that new?
Doesn't show the motion sensor in HA. Otherwise the movement was marked in orange.
@mitzu2250
I have the problems too. With the current firmware Tapo C200
Version 1.3.6 Build 230424 Rel.77225n(4555)
I use 4 camera models from C200 and all have these problems.
Tp-Link itself does not list the current firmware either. See https://www.tp-link.com/de/support/download/tapo-c200/v1/#Firmware-Release-Notes
Only the latest version will be published there.
Tapo C200(EU)_V1_1.3.5 Build 230307
Date of publication: 2023-04-04
Changes and bug fixes:

Improve camera stability.
Support to receive detection notifications on Alexa.
Support for more Smart Action functions.
Fix missing cloud videos issue in some cases.
Fix some minor bugs.

Furthermore, there are probably errors with the recognition recording. As soon as the mode was switched, only the sensor worked and did not record correctly in history. Maybe it freezes.
Is there a way to roll back the update? It was working correctly before.

When I do a hard reset it goes back to
Version 1.3.5 Build 230307 Rel.6847n(4555)
Problem the motion sensor / detection is not available for the new firmware, before it worked fine.

When I do a hard reset it goes back to
Version 1.3.5 Build 230307 Rel.6847n(4555)
Problem the motion sensor / detection is not available for the new firmware, before it worked fine.

I contacted TP-link support asking them to revert the FW. I had to give them my account name / serial number and they will push the previous firmware to the device. I'll report back once it's done.

When I do a hard reset it goes back to
Version 1.3.5 Build 230307 Rel.6847n(4555)
Problem the motion sensor / detection is not available for the new firmware, before it worked fine.

I contacted TP-link support asking them to revert the FW. I had to give them my account name / serial number and they will push the previous firmware to the device. I'll report back once it's done.

I'm also experiencing this issue now too..  The binary sensor no longer works on HA 2023.5..  A reinstall of the latest version of Tapo Control doesn't help either.

So, with Tapo Control 5.1.7 and HA 2023.5.0 I have 3 motion sensors :)
1 - old one, still not active...
and 2 new ones - I don't understand how  - but I have them now, and these two are working.

@alexus you can delete the unavailable one. Now for the two active ones - I bet one comes from onvif integration and one from Tapo. I recommend disabling onvif, it creates unnecessary stress on camera hitting it twice.

@JurajNyiri but I don't use ONVIF integration at all

Interesting! That would mean camera must've issues more than 1 onvif category event. Could you enable debug logs and post them here? Are you using person detection by any chance?

Yes - I use person detection.
Yes - They are triggers at the same time.
Do you mean reboot of HA or Camera?

Reboot of HA

How to get logs? I enabled it but cannot find where I may view on it :(

Reboot of HA

Yes, they are stick after HA reboot I already tried it.

 The logs above do not contain onvif portion yet.

I see only these lines related to onvif
cat home-assistant.log | grep onvif
2023-05-04 12:04:59.329 DEBUG (MainThread) [custom_components.tapo_control] [initOnvifEvents] Creating onvif connection...
2023-05-04 12:05:00.013 DEBUG (MainThread) [custom_components.tapo_control] {'device': <onvif.client.ONVIFCamera object at 0x7f7b63d900>, 'device_mgmt': <onvif.client.ONVIFService object at 0x7f7b63da50>}
2023-05-04 12:05:00.013 DEBUG (MainThread) [custom_components.tapo_control] Setting up onvif...

Right, after you see Setting up onvif... move in front of the camera, after the first movement is detected there should be additional logs.

OK, attached
home-assistant.log

I updated my cameras to latest version of firmwares.
C200 HW 1.0:
1.1.18 to 1.3.6: Onvif motion sensor does not work
C200 HW 3.0:
1.1.18 to 1.3.4: Onvif motion sensor works

Updated main post in this issue with confirmed working/broken camera/firmware/hw/ha/integration combinations.
Gathered logs on latest HA in isolated camera scenario and posted here.

@JurajNyiri
One note: my config is
C200 HW 2.0, Firmware: 1.3.5 Build 230307 Rel.2897n(4555)
Tapo Control: 5.1.7
HA: 2023.5.0

@alexus thank you, and is it working?

Two working motion sensors is much better than one which is not working...  :-)

I updated my cameras to latest version of firmwares.
C200 HW 1.0 x6:
1.1.18 to 1.3.6: Onvif motion sensor no longer works
C200 HW 3.0 x1: 1.3.0 to 1.3.4: Onvif motion sensor still works
I will do some further investigation later.

Issue seems a bit random.. I have a C200 HW 3.0 (EU) at 1.3.4 and motion detection does not work. The motion detection sensor is sometimes created after a while and is just stuck in "Detected"
I now also received a C210 HW 2.0 (EU) which I didn't update, but even with the stock 1.3.1 firmware it is not working.
I tested with the latest HA beta on ONVIF & Tapo custom component.
A few days ago I contacted TP-link to see how to downgrade the camera firmware on my C200 to 1.3.3. At first they seemed helpful and told me they could downgrade the machine remotely, but today I received this message from them:

 It`s not possible to roll back the firmware of this model camera.
Also the camera officially only is to be used with the tapo app, not with any 3rd party apps.

Please keep the discussion in here strictly related to the "Binary sensor not appearing" - if the binary sensor appears and gets stuck, create a separate issue.
Version 5.1.8 has been released

Fixes https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/330: Cameras getting stuck in "Clear" and "Detected" state since 2023.5.0

Important note
I was able to restore original flawless working functionality on all of my cameras(*except the ones with unrelated firmware issue) by including the old version 0e8f139) of onvif integration (Tapo-Control uses EventManager from it) along with onvif-zeep-async==1.2.11.
This is not a long term solution, and we should work on getting this fixed upstream.
Sooner or later we want to jump back to using the latest and greatest onvif code from HA. If you have a Tapo camera, please test it with official onvif integration. If you are experiencing inconsistencies like described above:

Disable tapo_control integration
Restart camera
Enable debug logs:

logger:
  default: error
  logs:
    custom_components.tapo_control: debug
    custom_components.onvif: debug
    homeassistant.components.onvif: debug
    zeep: debug
    httpx: debug
    onvif: debug

Add onvif for that camera
Report your observation in the issue.

Please keep the discussion in here strictly related to the "Binary sensor not appearing" - if the binary sensor appears and gets stuck, create a separate issue.

Combination of https://github.com/home-assistant/core/pull/92551, https://github.com/home-assistant/core/pull/92627 and https://github.com/home-assistant/core/pull/92629 makes the latest firmware 1.3.6 work. 🎉
It will be released in https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/pull/333#pullrequestreview-1415073531 once the above PRs are merged. I will be out for the next week but you can expect a release once I am back and the PRs are merged & released.

Home Assistant 2023.5.1 Supervisor 2023.04.1 Operating System 10.1 Frontend 20230503.2 - latest
Integration Version 5.1.8
Camera C200
HW 1.0
Firmware 1.3.6 Build 230424 Rel 77225n(4555)
Motion Sensor not exists

C200
Firmware: 1.3.6 Build 230424 Rel.77311n(4555)
Matériel : 2.0
Home Assistant 2023.5.1
Supervisor 2023.04.1
Operating System 10.1
Integration Version 5.1.8

Hi!
Home Assistant 2023.5.1
Supervisor 2023.04.1
Operating System 10.1
Frontend 20230503.2 - latest
Tapo: Cameras Control
5.1.7
Tapo C200
HW 1.0
FW 1.3.5 Build 230307 Rel.6847n(4555)
Since last Home Assistant 2023.5.0 update, motion sensor works fine, but appears twice.
I don't want to update camera's fw because I see other users lost again the sensor.
I tried also with Onvif integration and also appears the sensor, but once.

I just bought one of these cams today, and integrated it with the WebRTC and this integration.
For me everything is working fine, just one working Motion sensor, as expected.
Big thanks!
C200 HW3.0 1.3.4 Build 230424 Rel.76394n(4555)
Home Assistant 2023.5.1
HomeAssistant-Tapo-Control 5.1.8
(P.S.: Excited to see the progress in https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues/304)

@Agimgrue please use the latest version when reporting issues.

@Agimgrue thank you for the report, but please use the latest version when reporting issues.

Sorry, I don't see that there was an update.
Updated to 5.1.8 version and binary sensor becomes unavailable.

Home Assistant 2023.5.1
Supervisor 2023.04.1
Operating System 10.1
Frontend 20230503.2 - latest
Tapo: Cameras Control
5.1.8
Tapo C200
HW 1.0
FW 1.3.5 Build 230307 Rel.6847n(4555)
I'll try to downgrade to Tapo: Cameras Control 5.1.7

Make sure to always restart camera between HA restarts.

I had this issue once today where multiple sensors where shown but none where available.
For me it was fixed by closing all streams accessing the camera and then reinstalling the integration.

Issue has now been fixed in 5.2.0.

Strange, I had it working again on 5.1.8 (C200 3.0 1.3.4 & C210 2.0 1.3.1) and just updated to 5.2.0 and motion sensor is not showing up anymore.
HA is updated to 2023.5.2
2023-05-06 00:52:28.072 ERROR (MainThread) [custom_components.tapo_control] [initOnvifEvents] Initiating onvif connection failed.

@MunkeyBalls are you running HA with certificate on HTTPS?

It load the HA webui through a https proxy, should I try re-add the integration without HTTPS?

What is your internal HA url? Does your HA instance work on http://:8123?

I should be able to connect directly. I have a local DNS record and connect via that for ease of use (https://home.lan)

Does your HA instance work on http://<your ip>:8123?

Yes. I just reverted back to 5.1.8 and everything is working again.

Make sure you have correct IP set for Home Assistant. Turn on Advanced Mode under /profile. Go to /config/network and under Network Adapter verify correct IP is shown for the device. If it is not correct, under Home Assistant URL uncheck Automatic next to Local Network and set it to http://:8123. DO NOT USE HTTPS.

Could having the camera on a separate VLAN which cannot reach HA nor the internet have anything to do with it?

Yes.

Mystery solved then :P
I guess I'm going to have to set some firewall rules for the camera to be able to reach HA.
5.1.8 seems to be working fine for me however, maybe make it possible to choose the old method of fetching the sensor/events?

5.1.8 should be avoided, it uses really old onvif integration and bundles both onvif-zeep and old onvif integration. I am working on a better solution.

I'll do some tweaking on the internal network tomorrow and give 5.2.0 another spin. Thanks for resolving this issue so quickly, amazing how quickly you and bdraco pushed out those new versions.

@MunkeyBalls you can try with 5.2.1, if it detects usage of https it disables webhooks. If you can reach HA through http:IP:8123 and you set a proper internal URL (read FAQ), and fix vlan so that camera can reach it, you should be able to use webhooks to the fullest potential.

Thanks! I'll give it a try tomorrow. Nothing good is going to come from me messing around with my network this late in the night 😄

I am going to copy&paste part of readme/faq here for awareness;

If you have webhooks enabled, and your Home Assistant internal URL is reachable on HTTP, make sure camera can reach it.
Make sure you have correct IP set for Home Assistant. Turn on Advanced Mode under /profile. Go to /config/network and under Network Adapter verify correct IP is shown for the device. If it is not correct, under Home Assistant URL uncheck Automatic next to Local Network and set it to http://<some IP address>:8123. DO NOT USE HTTPS.
Certain camera firmwares have pullpoint broken, with only webhooks working. If you are not able to run webhooks because of above (https, or vlan setup), binary sensor will never show up.

Working fine for me, only the entity name changed. From ...._motion to ..._motion_alarm

@JurajNyiri
Hi!
As for 5.2.0 and HA 2023.5.2 - two motion sensors, but with different names:

binary_sensor.tapo_camera_cell_motion_detection
binary_sensor.tapo_camera_motion_alarm
I understand 'alarm' one, but what is 'cell motion detection'?

That works as expected, both are reported by camera. "Cell motion detection" is the one we always had. I do not know the purppse of motion alarm, it is something to link added recently.

Home Assistant 2023.5.2 Supervisor 2023.04.1 Operating System 10.1 Frontend 20230503.3 - latest
Integration Version 5.2.2
Camera C200
HW 1.0
Firmware 1.3.6 Build 230424 Rel 77225n(4555)
Motion Sensor still not exists
in preview version sensor become stuck so i deleted it (as suggested by the frontend).
Now i've updated integration and core but sensor don't appear.
I tryed removing integration, restart HA and camera.
Maybe is there something i can do for make sensor become available again?

I noticed the sensor not being available directly after installing the integration.
The two motion sensors became available when they detected the first movement.
So movement detection needs to be enabled and you need to move once in front of the camera.

I noticed the sensor not being available directly after installing the integration. The two motion sensors became available when they detected the first movement. So movement detection needs to be enabled and you need to move once in front of the camera.

tryed to do.
i also activate cloud account and webhooks (i think correctly)
Here is the debug log
home-assistant_tapo_control_2023-05-07T22-13-48.783Z.log


Text broken on IE

I've just noticed labels/text aren't working for me on IE any more. I'll try and figure out where they broke (my guess is in the changes to text-buffer a couple of months ago)

Strange, the changes I made should have made the code less browser dependent, i.e. it is not using the canvas anymore to calculate the signed distance field.
Thanks for looking into it!

I think the canvas objects created by TextAtlas are empty in IE (at least, if I call canvas2.toDataURL() at the end of the TextAtlas constructor in IE I get an empty image, but in Chrome I get an image with a bunch of letters in), will dig a bit more...

Number.MAX_SAFE_INTEGER is not defined in IE. There's a simple polyfill here which fixes the bug:
https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Number/MAX_SAFE_INTEGER/polyfill.js
I can copy and paste this into polyfills.js. Is it sufficient license-wise to include a comment with:

URL to the source
Copyright line from source project
Note that it's MIT licensed?

Or do I need to attribute the source somewhere else too?


[question] is there an example of how to transform the MusicXmlDocument into a MIDI?

I know that the context of this package is just to parse XML. But would you have an example of MusicXmlDocument being used to build a MIDI file or to play MIDI notes in a sequenced and timed manner?

@thaihuynhxyz

Sorry @rafaeljustinox, I have no time right now. Please feel free to contribute your example to this repository.

@thaihuynhxyz I can contribute as soon as I manage to implement it. But I would like to understand for what purpose this package was used besides parsing the xml. Is there any other project where you used this package? Or was the idea just to extract information from the xml? If you have any tips on how I could use the parsed object to play the sounds synchronously, I'd appreciate it.

Have you build anything with this project yet? If not, here's some help with your questions:
I think the scope of this package is to read MusicXML into an object representation so that people can build programs that interop with MusicXML. Integrating MIDI would be a Bring Your Own Code use case that this package is meant for.
A lot of MIDI related packages on pub.dev read MIDI from .sf2 files.
Here is one that lets you build a MIDI programmatically: dart_midi_pro.
MIDI related: pub.dev search for MIDI.


tried a go get, got an error, not sure what to do

go get https://github.com/devfacet/worker
package https:/github.com/devfacet/worker: https:/github.com/devfacet/worker: invalid import path: malformed import path "https:/github.com/devfacet/worker": invalid char ':'

What are you trying to do?
Try the following command:
go get github.com/devfacet/worker

That worked fine. Thanks

I am fairly new to go. I have run your test files. I am reviewing your code but I wish you provided a clear description on how to use your library. I am trying to pull it out of the testing files is very time consuming.

There are so many different ways to use this library. I just added an example application https://github.com/devfacet/worker/blob/main/examples/pool/main.go

Thanks very much for that.


Add tide alternative

Description
Add All checks passed action. It checks if all GitHub actions have passed, except those under checks_exclude. This allows to remove other required checks from branch protection and add only this one that acts as a guard. This allows to use path filtering in other workflows that are required in some cases and not required in others, such as the image-builder workflow that doesn't need to be run on sec-scanner bump PR's. This allows to speed up some PR and the release
Translated with DeepL.com (free version)
Changes proposed in this pull request:

Add All checks passed action
Change label validator triggers

Related issue(s)

/kind enhancement


move card after answer

If the answer to a card is wrong, move it to the previous box.
If correct, move it to the next box.
Also consider edge-cases:

when a card is answered wrong in the first box
cards in the last box

getRandomCardfromCurrentBox
getQuestion
askQuestion
getAnswer
MoveCardUP/Down
NextCard?


Implement join reordering of fact-dimension joins

Reopening #950 here.
This PR implements a new logical plan optimization rule based on the paper Improving Join Reordering for Large Scale Distributed Computing.

Codecov Report

Merging #1027 (a2b9f67) into main (5789b58) will decrease coverage by 0.40%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   81.09%   80.70%   -0.40%
==========================================
  Files          77       77
  Lines        4338     4338
  Branches      779      779
==========================================
- Hits         3518     3501      -17
- Misses        648      657       +9
- Partials      172      180       +8

Impacted Files
Coverage Δ

dask_sql/integrations/fugue.py
85.71% <0.00%> (-14.29%)
:arrow_down:

dask_sql/physical/rex/core/literal.py
58.09% <0.00%> (-2.86%)
:arrow_down:

dask_sql/physical/rel/logical/window.py
95.37% <0.00%> (-1.74%)
:arrow_down:

dask_sql/physical/utils/statistics.py
89.41% <0.00%> (-1.18%)
:arrow_down:

dask_sql/_version.py
32.76% <0.00%> (-1.13%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks @charlesbluca and @ayushdg ! Updated from your suggestions, lmk what you think.

Thanks @charlesbluca ! I've updated from your suggestions. I also added an additional test: by default, join reordering should only be done with filtered tables, so we demonstrate that the plan remains unchanged with unfiltered tables. Let me know if there's any additional conditions we should check.


Cannot infer type of custom class when casting

Godot version
66ab3ce
System information
W10
Issue description
When you use := with casting and try to cast as custom class, it fails saying it cannot infer, because initial value is null.
Example:
extends Node
class_name Test

Another script:
var test := get_parent() as Test

Works fine if you use e.g. Node2D instead of Test.
Steps to reproduce
See above.
Minimal reproduction project
No response

No longer happens in c591ebf0127296f0a2c571d2ed18ae6619da2a76


Bootstrap 4 Version

If it is not already on the roadmap, please release a bootstrap 4 version.
Thank you!

There is already a fork here: https://github.com/maxfisher05/ng2-bs4-modal

Excellent - thank you.


[Avatar Addition] AS.4VA-L1

Adding hash data from demo version of AS.4VA-L1 by Aeyon Systems, still not sure I did the branching correctly but feel free to yell at me and i'll get this cleaned up asap, just like last time!

syntax error spotted, gimme a second

Posting the link for documentation purposes https://aeyonsystems.gumroad.com/l/AS-4VA-L1


Router push not work with lazyload route

Version
4.0.0-beta.9
Steps to reproduce

create lazy load router example :

const router = createRouter({
  history: createWebHistory(process.env.BASE_URL),
  routes: [
    {
      path: '/',
      name: 'Home',
      component: Home,
    },
    {
      path: '/about',
      name: 'About',
      component: () =><EMAIL_ADDRESS>    }
  ],
});

use router push from Home Page -> About Page

<template>

    test router

</template>

seem like vue load chuck of page, but it's still not redirect to new page

** If use normal route it's work fine
What is expected?
Can use router.push({}) with lazy route
What is actually happening?
Cannot use router.push({}) with lazy route

UPDATE : I try to use router-link it work correctly, not sure we can use router.push in this version.

Use à click.prevent or a router link (better) to prevent the regular a behavior


Don't try networking if in offline mode

Found this out during my flight back home. Should be a nice addition.
It does surprise me a bit that blowdryer can cache stuff locally and work in full offline mode.

Haha I ran into this issue myself on a flight before. Glad to see it fixed.


Injection?

I'm wondering if this library is safe from user injection attacks?
Thanks!

Hi Jonathan - it depends. The driver is sending a user-given set of Neo4j (Cypher) commands to the server, being concerned about connection, transactions, pooling, errors, various transformations, etc.  Why would it?! But why do you have this concern?! I'd imagine you'll not simply just accept external commands (free text) from anybody crafting cypher commands and just run them indiscriminately?! You'll most probably write functions (business logic) that will convert higher level business concerns i.e. Delete user, to an equivalent set of Cypher commands that would be defined into Module/named function/etc. where the user identification was already considered and so on, making sure only that user will be deleted and not other users too :) I'm over simplifying, but I believe you got the idea?! The short answer is: no, the driver is not validating the query contents, but I welcome any pull requests :) HTH - Florin

@florinpatrascu thanks!

Although it is indeed the task of the developer of the app to make sure no weird queries run... just like in SQL it's easy to make the following mistake:
def index(conn, %{"prop" => prop}) do
  cypher =
    ~s"""
    MATCH (n)
    WHERE n.prop = "#{prop}"
    RETURN n
    """
  results = Neo4j.query!(Neo4j.conn, cypher)
  render("view.json", results)
end

... where prop is now user content, which means it can also be x" DELETE n WHERE n.prop = "x, for example.
The following is not currently documented (I believe?), but through a bit of trial and error I found out that it works like this:
def index(conn, %{"prop" => prop}) do
  cypher =
    ~s"""
    MATCH (n)
    WHERE n.prop = {prop}
    RETURN n
    """
  results = Neo4j.query!(Neo4j.conn, cypher, %{"prop" => prop})
  render("view.json", results)
end

correct. If you simply interpolate any incoming params (from untrusted sources) yes, this can happen. Thank you for your comment and examples! What would you recommend, in the scenario above?

I just learned more about this at a Neo4j Workshop. Turns out the interpolation is actually slower, because when using params, Neo4j can cache the query plan.
Also, my example is deprecated. The {prop} syntax does still work, but the new way of doing it is $prop in your query.
So I am recommending to always use props over interpolation. I would also recommend to update the docs to explain this feature of passing the props into the query :)

Thank you, @sebsel!