LHN - LHN briefly show reports from all workspaces on refresh when workspace is filtered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

User has at least one workspace

Go to staging.new.expensify.com
Open workspace switcher
Select a workspace
Refresh the page
Might have to select another workspace from the workspace switcher and refresh the page again if the issue is not reproducible

Expected Result:
LHN will only show the reports from the selected workspace after the page is refreshed
Actual Result:
LHN briefly show the reports from all workspaces after the page is refreshed
On mweb, the workspace switcher is reset to Expensify
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/79395494-9826-4d20-8b5f-0ed4c0d48777
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN briefly shows all report when the LHN is filtered by workspace.
What is the root cause of that problem?
The list of LHN chats is filtered using activeWorkspaceID from useActiveWorkspace.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/hooks/useReportIDs.tsx#L66-L73
It's updated every time the nav state changes, but with a delay.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/libs/Navigation/NavigationRoot.tsx#L166-L170
This causes the activeWorkspaceID to be undefined for a moment before switching to the correct value. But if we see the LHN topbar, the correct workspace is shown.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx#L52-L54
That's because we get the active workspace from the nav state directly using useActiveWorkspaceFromNavigationState.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx#L21
useActiveWorkspaceFromNavigationState is made specifically for the bottom tab screen.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/hooks/useActiveWorkspaceFromNavigationState.ts#L7-L29
What changes do you think we should make in order to solve the problem?

ReportIDsContextProvider is currently put at App.tsx, not in a bottom tab screen. We can move ReportIDsContextProvider to the sidebar screen since useReportIDs hook is only being used there and use useActiveWorkspaceFromNavigationState in ReportIDsContextProvider.
But if we want to keep the context to be shareable with other screens, we can move ReportIDsContextProvider to the AuthScreens.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L409-L410
Then in ReportIDsContextProvider, we still get the active workspace from useActiveWorkspace, but if it's undefined, we fallback to the policy ID from the state.
https://github.com/Expensify/App/blob/51e25af3df2eef49c2ac87e0aef816099f9d3747/src/hooks/useReportIDs.tsx#L66-L73
const {activeWorkspaceID: activeWorkspaceIDContext} = useActiveWorkspace();
const activeWorkspaceIDFallback = useRef(navigationRef.current ? getPolicyIDFromState(navigationRef.current?.getState() as State<RootStackParamList>) : undefined);
const activeWorkspaceID = activeWorkspaceIDContext ?? activeWorkspaceIDFallback.current;

I wasn't able to reproduce yet

I was not able to reproduce this. Closing

@abekkala I can still reproduce this.
https://github.com/user-attachments/assets/f7556d41-dfdc-44c4-ba0c-57f879e4dd88
You can try switch to a workspace which has small amount of chats to notice it easier.

@abekkala hi, can you recheck this one, please?

@abekkala bump


Combine a music.m4a on a video.mp4 overwrite my video audio

Hi,
I need to combine a song (.m4a) with a video (.mp4). I'm using mp4Parser, it's worked but my song overwrite the audio track of my video, and I need to have these two audio tracks on my video.
Can you help me please ?
There is my function for muxing my video with a song :+1:
videoFile : mp4
audioFile : m4a
outputFile : mp4
public boolean mux(String videoFile, String audioFile, String outputFile) {

	Movie video;
	try {
		video = new MovieCreator().build(videoFile);
		Log.d("ATTENTION","On a fini le try du montage de video");
	} catch (RuntimeException e) {
		e.printStackTrace();
		return false;
	} catch (IOException e) {
		e.printStackTrace();
		return false;
	}

	Movie audio;
	try {
		audio = new MovieCreator().build(audioFile);
		Log.d("ATTENTION","On a fini le try de montage de audio");
	} catch (IOException e) {
		e.printStackTrace();
		return false;
	} catch (NullPointerException e) {
		e.printStackTrace();
		return false;
	}

	Log.d("TAILLE",String.valueOf(video.getTracks().size()));
	Track audioTrack = audio.getTracks().get(0);
	Track videoTrack = video.getTracks().get(0);
	Track videoAudioTrack = video.getTracks().get(1);
	Movie result = new Movie();

	//Append all audio and video
	result.addTrack(videoTrack);
	result.addTrack(audioTrack);
	result.addTrack(videoAudioTrack);

	Container out = new DefaultMp4Builder().build(result);

	FileOutputStream fos;
	try {
		fos = new FileOutputStream(outputFile);
	} catch (FileNotFoundException e) {
		e.printStackTrace();
		return false;
	}
	BufferedWritableFileByteChannel byteBufferByteChannel = new BufferedWritableFileByteChannel(fos);
	try {
		out.writeContainer(byteBufferByteChannel);
		byteBufferByteChannel.close();
		fos.close();
	} catch (IOException e) {
		e.printStackTrace();
		return false;
	}
	Log.d("ATTENTION","On a finis la conversion");
	return true;
}

And my BufferedWritableFileByteChannel metod :+1:
private static class BufferedWritableFileByteChannel implements WritableByteChannel {
private static final int BUFFER_CAPACITY = 1000000;
	private boolean isOpen = true;
	private final OutputStream outputStream;
	private final ByteBuffer byteBuffer;
	private final byte[] rawBuffer = new byte[BUFFER_CAPACITY];

	private BufferedWritableFileByteChannel(OutputStream outputStream) {
		this.outputStream = outputStream;
		this.byteBuffer = ByteBuffer.wrap(rawBuffer);
	}

	@Override
	public int write(ByteBuffer inputBuffer) throws IOException {
		int inputBytes = inputBuffer.remaining();

		if (inputBytes > byteBuffer.remaining()) {
			dumpToFile();
			byteBuffer.clear();

			if (inputBytes > byteBuffer.remaining()) {
				throw new BufferOverflowException();
			}
		}

		byteBuffer.put(inputBuffer);

		return inputBytes;
	}

	@Override
	public boolean isOpen() {
		return isOpen;
	}

	@Override
	public void close() throws IOException {
		dumpToFile();
		isOpen = false;
	}
	private void dumpToFile() {
		try {
			outputStream.write(rawBuffer, 0, byteBuffer.position());
		} catch (IOException e) {
			throw new RuntimeException(e);
		}
	}
}

Sry for my english.

Basically you want to merge two audio tracks to one. Players won't play two
audio tracks at the same time. This is a use case that requires decoding,
then merging and encoding into one audio track again. The MP4parser cannot
do that. I guess you'll need to use ffmpeg or the MediaCodec API.
Best Regards,
Sebastian
mico81<EMAIL_ADDRESS>schrieb am Mi., 1. Juli 2015 um 15:58 Uhr:

Hi,
I need to combine a song (.m4a) with a video (.mp4). I'm using mp4Parser,
it's worked but my song overwrite the audio track of my video, and I need
to have these two audio tracks on my video.
Can you help me please ?
There is my function for muxing my video with a song [image: :+1:]
videoFile : mp4
audioFile : m4a
outputFile : mp4
public boolean mux(String videoFile, String audioFile, String outputFile) {
Movie video;
try {
    video = new MovieCreator().build(videoFile);
    Log.d("ATTENTION","On a fini le try du montage de video");
} catch (RuntimeException e) {
    e.printStackTrace();
    return false;
} catch (IOException e) {
    e.printStackTrace();
    return false;
}

Movie audio;
try {
    audio = new MovieCreator().build(audioFile);
    Log.d("ATTENTION","On a fini le try de montage de audio");
} catch (IOException e) {
    e.printStackTrace();
    return false;
} catch (NullPointerException e) {
    e.printStackTrace();
    return false;
}

Log.d("TAILLE",String.valueOf(video.getTracks().size()));
Track audioTrack = audio.getTracks().get(0);
Track videoTrack = video.getTracks().get(0);
Track videoAudioTrack = video.getTracks().get(1);
Movie result = new Movie();

//Append all audio and video
result.addTrack(videoTrack);
result.addTrack(audioTrack);
result.addTrack(videoAudioTrack);

Container out = new DefaultMp4Builder().build(result);

FileOutputStream fos;
try {
    fos = new FileOutputStream(outputFile);
} catch (FileNotFoundException e) {
    e.printStackTrace();
    return false;
}
BufferedWritableFileByteChannel byteBufferByteChannel = new BufferedWritableFileByteChannel(fos);
try {
    out.writeContainer(byteBufferByteChannel);
    byteBufferByteChannel.close();
    fos.close();
} catch (IOException e) {
    e.printStackTrace();
    return false;
}
Log.d("ATTENTION","On a finis la conversion");
return true;

}
—
Reply to this email directly or view it on GitHub
https://github.com/sannies/mp4parser/issues/92.

Ok, i'll try with ffmpeg.
Thanks for your quick answer !
Best Regards,
Nicolas


load_model ValueError: axes don't match array

I'm studying gan with keras-gan/wgan-gp example with my own dataset. I save models with
wgan.generator.save('generator.h5')
wgan.critic.save('critic.h5')
and load with
model = load_model('generator.h5')
model = load_model('critic.h5')
But this only works fine at the fist time.When I save the models again after the second training and run
model = load_model('generator.h5')
model = load_model('critic.h5')
again, the error occur ：

ValueError                                Traceback (most recent call last)
 in ()
----> 1 model = load_model('generator.h5')
D:\keras\engine\saving.py in load_model(filepath, custom_objects, compile)
262
263         # set weights
--> 264         load_weights_from_hdf5_group(f['model_weights'], model.layers)
265
266         if compile:
D:\keras\engine\saving.py in load_weights_from_hdf5_group(f, layers, reshape)
914                                                        original_keras_version,
915                                                        original_backend,
--> 916                                                        reshape=reshape)
917         if len(weight_values) != len(symbolic_weights):
918             raise ValueError('Layer #' + str(k) +
D:\keras\engine\saving.py in preprocess_weights_for_loading(layer, weights, original_keras_version, original_backend, reshape)
555         weights = convert_nested_time_distributed(weights)
556     elif layer.class.name in ['Model', 'Sequential']:
--> 557         weights = convert_nested_model(weights)
558
559     if original_keras_version == '1':
D:\keras\engine\saving.py in convert_nested_model(weights)
543                     weights=weights[:num_weights],
544                     original_keras_version=original_keras_version,
--> 545                     original_backend=original_backend))
546                 weights = weights[num_weights:]
547         return new_weights
D:\keras\engine\saving.py in preprocess_weights_for_loading(layer, weights, original_keras_version, original_backend, reshape)
555         weights = convert_nested_time_distributed(weights)
556     elif layer.class.name in ['Model', 'Sequential']:
--> 557         weights = convert_nested_model(weights)
558
559     if original_keras_version == '1':
D:\keras\engine\saving.py in convert_nested_model(weights)
531                     weights=weights[:num_weights],
532                     original_keras_version=original_keras_version,
--> 533                     original_backend=original_backend))
534                 weights = weights[num_weights:]
535
D:\keras\engine\saving.py in preprocess_weights_for_loading(layer, weights, original_keras_version, original_backend, reshape)
673             weights[0] = np.reshape(weights[0], layer_weights_shape)
674         elif layer_weights_shape != weights[0].shape:
--> 675             weights[0] = np.transpose(weights[0], (3, 2, 0, 1))
676             if layer.class.name == 'ConvLSTM2D':
677                 weights[1] = np.transpose(weights[1], (3, 2, 0, 1))
c:\users\administrator\appdata\local\programs\python\python35\lib\site-packages\numpy\core\fromnumeric.py in transpose(a, axes)
596
597     """
--> 598     return _wrapfunc(a, 'transpose', axes)
599
600
c:\users\administrator\appdata\local\programs\python\python35\lib\site-packages\numpy\core\fromnumeric.py in _wrapfunc(obj, method, *args, **kwds)
49 def _wrapfunc(obj, method, *args, **kwds):
50     try:
---> 51         return getattr(obj, method)(*args, **kwds)
52
53     # An AttributeError occurs if the object does not have
ValueError: axes don't match array`

I'm using
Python     3.5.3
Keras        2.2.2
h5py         2.8.0
tensorflow-gpu 1.9.0
keras-contrib     2.0.8
Keras-Applications   1.0.4
Keras-Preprocessing 1.0.2
Any advice and suggestions will be appreciated.

hi, how do u fix this problem

hi, how do u fix this problem

i try desnet, xception , resnext,.... all have this pro, it is keras's bug

bump, am having the same bug

In case you use the Tensorflow implementation of Keras (tensorflow.keras)
I get the same error with a modified version of the WGAN GP if I save the model weights in keras's h5 file format. However, switching to tensorflow format solves the issue for me:
model.save_weights('path_to_my_weights', save_format='tf')
model.load_weights('path_to_my_weights')

See tensorflow docu on saving subclassed models for more details.

For reference, as Crispy13 mentions in his reply to this SO answer:
The same layers that were frozen when training the model must be frozen before loading the weights. I will experiment with unfreezing these weights after loading the weights. Any ideas why this is happening @fchollet? If I get time I might peep the source and create a PR


Rework logic to get declaration statuses.

Pull request addresses two things.

Script was failing on the parameter name: it was looking for path_to_declaration_manifest not path_to_manifest
Script uses same logic as in the generate email script to add an extra State of Declaration column to the resulting .csv file.

Only suppliers whose declarations are started or completed will be returned

Probably better to put this into digitalmarketplace-scripts if we're planning to use this very often.
Oh, and p.s., this breaks in Python3.

Oh, and p.s., this breaks in Python3
Then use Python3 and make it break in Python2 :trollface:

Other than deleting the comment, looks :+1:  to me.

This should, at some point, move to https://github.com/alphagov/digitalmarketplace-scripts


[Bug] Upgrade from 0.22.3 to 0.23.0-beta2 loses/forgets routes

Is this a support request?

[X] This is not a support request

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Routes that are advertised and approved in instance running version 0.22.3 are lost/forgotten after upgrading the config to 0.23.0-beta2. Also re-advertising the routes on the nodes that already shared them do not show up at all, restarting device or tailscale service doesn't seem to have any effect.
Expected Behavior
Routes migrated, show up under routes and other nodes can access them.
Steps To Reproduce
docker-compose.yml
services:
  headscale:
    image: headscale/headscale:0.22.3
    restart: unless-stopped
    networks:
      - traefik
    volumes:
      - ./headscale-config:/etc/headscale
      - ./headscale-data:/var/lib/headscale
    command: headscale serve
    labels:
      - "traefik.enable=true"
      - "traefik.docker.network=traefik"
      - "traefik.http.routers.headscale.entrypoints=https"
      - "traefik.http.routers.headscale.rule=Host(`X.Y`)"
      - "traefik.http.routers.headscale.tls.certResolver=ledns"
      - "traefik.http.services.headscale.loadbalancer.server.port=8080"
networks:
  traefik:
    external: true

Advertise routes, check that the show up
Change compose file image: headscale/headscale:v0.23.0-beta2, command: serve
Check routes, and re-advertise
Environment
- OS: Ubuntu 20.04.6 LTS
- Headscale version: 0.22.3 to 0.23.0-beta2
- Tailscale version:  1.70.0

Runtime environment

[X] Headscale is behind a (reverse) proxy
[X] Headscale runs in a container

Anything else?
No response

Could you query in the database to see if they are present? Are they dropped or just not migrated/readable?

The routes table is empty, advertising new route is not populating it either.

do you have a copy of the database I could have?

I've emailed the upgraded DB to you

Do you also have the 0.22.3 backup? that is what I would need for testing.

This should be fixed in #2076, some old poor design of migration is biting us and we dont have enough of an overview to cover all cases. Thanks for reporting, would be great if you can test that branch, otherwise I'll merge and do a new beta soon.


Can i use custom child to play videos?

I want to create a gallery to show all files inside of a folder. So there is videos and images.
Can i use custom child to play videos? If so, how do i do?

I have no idea.

Same problem here

hack: errorBuilder :)

any example please?


python3Packages.{shiboken,pyside}6: 6.5.2 -> 6.6.0

Description of changes
https://code.qt.io/cgit/pyside/pyside-setup.git/tree/doc/changelogs/changes-6.6.0
This allows using Pyside6 with Qt 6.6

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Duplicate of #265987
I'll review this one later though and can close that one if this one is better

it's fine, I'll leave a review on your PR


[ plugin-legacy ] 页面内import  worker 。构建后，chunk或者 assets目录内并没有生成work文件（已定位问题为使用plugin-legacy导致）

Describe the bug
import Worker from '@XXX/worker/down-count?worker';
开发源码

生产报错

开发环境 下正常, 构建后生产环境找不到dow-count.js 并报错。进入dist后，也没有生成down-count相关的chunk
### 2022-07-25 问题已定位，在使用 plugin-legacy 的情况下，会出现上述问题，注释legacy代码，worker正常打包

Reproduction
git@gitee.com:henry-the-great/vite_worker_bug.git
System Info
System:
    OS: Windows 7
    Memory: 12GB
  Binaries:
    Node: 16.3 - C:\Program Files\nodejs\node.EXE
    npm: 7.24.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    chorme: 103.0.5060.134

  npmPackages:
    @vitejs/plugin-vue: ^3.0.1 => 3.0.1
    vite: ^3.0.2 => 3.0.2

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

same issue

It seems it happens with plugin-legacy + worker as you said.
Minimal reproduction: https://stackblitz.com/edit/vitejs-vite-nzeh9i?file=package.json


Update getGaeRuntime to handle java11

Minor fix to injected dev appserver variables.
Looks like kickstart might be doing this a little differently.
fixes #745

@chanseokoh, yeah was discussing offline with ludo the correct way to do this.


Hook configuration via Spring Bean

With keep old Configuration.addHook and Configuration.addGeneticHook methods.

Support like:
// Ofc, similar in Java

@Configuration
class MDCHookConfiguration {

    @Bean
    fun hook1() = MDCHook<String>("hook1", "", 100) { _, _ -> mapOf() }

    @Bean
    @ConditionalOnClass(TraceContext::class)
    fun hook2() = MDCHook<TraceContext>(MDC::class.simpleName, TraceContext::class.java) { traceContext, _ ->
        mapOf(
            "traceId" to (traceContext?.traceId() ?: ""),
            "parentId" to (traceContext?.parentId() ?: ""),
            "spanId" to (traceContext?.spanId() ?: "")
        )
    }
}

// application.properties/yml configuration
reactive-logger:
  default:
    key: "defaultKey"
    scheduler: parallel


An easy installer

The installation process is relatively straightforward, but an even smoother one might be nice, along with init scripts.

see also: https://github.com/whiteley/chef-goiardi

Why not platform/os native packages?

Looks like @ctdk is working on that using packagecloud.io https://github.com/whiteley/chef-goiardi/pull/12

Yup. The packages need a little bit of work still, I think, because I think they're blowing away previous configuration files silently, and of course they need to be available for more than just certain versions of Debian and Ubuntu. Soon, though.

packages have been available for a while now in packagecloud.


Quote username and password in installation instructions

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   40.32%   40.32%
=======================================
  Files          14       14
  Lines         977      977
=======================================
  Hits          394      394
  Misses        554      554
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf13af...ff83418. Read the comment docs.


added 2 of my projects url shortener and todolist

Related Issue

Description

Screenshots

src/DB/projects.json format this file using pnpm format
Suggestion:

add a good title like this: data: added oyepriyansh's projects
add a description with screenshots(if needed)
add the issue number(if needed)

will open new pr


Invite history missing

Hi. After recent update no invite history for most accounts.
Returns codes=[]
res = client.com.atproto.server.get_account_invite_codes(
models.ComAtprotoServerGetAccountInviteCodes.Params(
createAvailable=True,
includeUsed=True)
)

Hi. But do you have it in UI? On bsky.app

That works perfectly for me

Nope. I have 5 accounts, all approx 70 days old. Only one shows invite history, and I have sent invites to others from all of them. On the app, desktop and sdk , its all the same. Very strange.

Yeah strange. But not a SDK problem as I can understand

I agree, sdk is the same as web, looked at the calls in the browser. All the same.
Very strange.
I have tried with different User-Agents, but the results are the same. No history on most.

Probably that's why https://bsky.app/profile/intrnl.bsky.social/post/3k7uql33z3y27


Add ms-resolution to log messages

Part of the eth2 interop cleanup.
From @lithp .
More data!
Cute Animal Picture

In particular, this was added to try to debug a race condition where Trinity might have been creating and gossipping a block before lighthouse had noticed that a new slot had started. Because Trinity was only giving us second-resolution logs it was impossible to tell when exactly the block was gossiped, and I think this additional data is generally useful!
I feels weird to approve my own PR though, so roping @carver in :)

going to go ahead and merge this in so we can keep moving on the interop front...
@carver feel free to revisit if you have more input to add here :)

I think my ideal would be something like: show ms in the debug log file, show the truncated %S in the console output. I don't have any advice on implementing that, would just be digging into the logging docs to figure it out.


eventregistration.js triggers build warning regarding size limit

Where to find the issue
https://github.com/corona-warn-app/cwa-website/blob/master/src/assets/js/eventregistration.js
Describe the issue
When the website is built through https://github.com/corona-warn-app/cwa-website/blob/master/.github/workflows/build.yml a warning is shown regarding eventregistration.js.
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  eventregistration.js (658 KiB)

For example the pull request https://github.com/corona-warn-app/cwa-website/pull/1167 triggered the action which is shown in the logs under https://github.com/corona-warn-app/cwa-website/actions/runs/788829128. Here is the relevant part of the log:
Built at: 04/27/2021 11:00:24 AM
               Asset     Size  Chunks                    Chunk Names
              app.js  139 KiB       0  [emitted]         app
eventregistration.js  658 KiB       1  [emitted]  [big]  eventregistration
Entrypoint app = app.js
Entrypoint eventregistration [big] = eventregistration.js

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  eventregistration.js (658 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  eventregistration (658 KiB)
      eventregistration.js

WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

Suggested change
Please consider if something should be done to avoid this warning appearing.

Internal Tracking ID: EXPOSUREAPP-13404

It seems that #1575 may partially address this issue.

PR #1772 causes the warning to no longer appear
[17:42:45] Version: webpack 4.46.0
Built at: 29/09/2021 17:42:45
               Asset      Size  Chunks                    Chunk Names
              app.js   140 KiB       0  [emitted]         app
eventregistration.js   679 KiB       1  [emitted]  [big]  eventregistration
      screenshots.js  90.1 KiB       2  [emitted]         screenshots
Entrypoint app = app.js
Entrypoint eventregistration [big] = eventregistration.js
Entrypoint screenshots = screenshots.js

eventregistration.js is still labelled as [big] though.
It seems that performance hints have been disabled:
https://github.com/corona-warn-app/cwa-website/blob/8d3a36a769375f4be50461052ff23cb87acc0fad/gulpfile.js#L270-L272
https://webpack.js.org/configuration/performance/#performancehints

Closing, since the symptoms no longer appear.

PR https://github.com/corona-warn-app/cwa-website/pull/1774 reverted the change to gulpfile.js which suppressed the performance warning from webpack, so this issue is re-opened.

I wonder if the label bug is correct here, as this is not a bug, or? The warning message appears as intended.

@Ein-Tim

I wonder if the label bug is correct here, as this is not a bug, or? The warning message appears as intended.

This is a question for a JavaScript expert.
"bug" is the correct label until an expert qualifies the issue and says it can be dismissed or the issue has been addressed. The Open Source Team has so far not responded.
In the meantime the npm run build reports that eventregistration.js has grown even further in size
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  eventregistration.js (993 KiB)

and that there is a problem additionally with cwaa.js
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  cwaa.js (813 KiB)

Lighthouse shows a performance impact due to JavaScript size in mobile mode for the Event registration page https://www.coronawarn.app/en/eventregistration/.
The most improvement however would be gained through enabling text compression.

See open issue https://github.com/corona-warn-app/cwa-website/issues/60

Steps to reproduce report

Open https://www.coronawarn.app/en/eventregistration/ in Google Chrome Incognito mode
Press F12
Select Performance and Mobile or Desktop, then click on Generate report

Device
LighthousePerformance score (0-100)
Highest opportunity

Mobile
58
Enable text compression

Desktop
97
Enable text compression

@MikeMcC399 Thank you for reporting the issue and all the information. Internal Tracking ID: EXPOSUREAPP-13404

@MikeMcC399 Just FYI, we had forwarded  the issue, however were told that enable compressing would request to much ressources on CDN side, and that it would not be implemented.


Copy button example

cc @sebastianbenz

All done, awaiting another review 👍

It's live (I had to make some cosmetic changes to improve the way the sample is rendered in the doc view). Thanks again!


ESBuild options not being used

The es2022 esbuild setting should be compiling the await using, the error implies the target is still ESNext
| Error
| Unexpected identifier 'dbHandle'
| ↳ at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:168:18)
| ↳ at callTranslator (node:internal/modules/esm/loader:279:14)
| ↳ at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:285:30)
| ↳ at async link (node:internal/modules/esm/module_job:78:21)

/// <reference path="./.sst/platform/config.d.ts" />

export default $config({
  app(input) {
    return {
      name: "test",
      removal: input?.stage === "production" ? "retain" : "remove",
      home: "aws",
    };
  },
  async run() {
    const test = new sst.aws.Function("Test", {
      url: true,
      handler: "./src/lambda.handler",
      runtime: "nodejs20.x",
      architecture: "arm64",
      nodejs: {
        esbuild: {
          target: "es2022",
          supported: { using: false },
        },
      },
    });
    return {
      test: test.url,
    };
  },
});

import postgres from "postgres";
import { drizzle } from "drizzle-orm/postgres-js";

Symbol.dispose ??= Symbol("Symbol.dispose");
Symbol.asyncDispose ??= Symbol("Symbol.asyncDispose");

const getDbHandle = () => {
  const pgClient = postgres("Resource.PostgresUrl.value");

  return {
    db: drizzle(pgClient),
    async [Symbol.asyncDispose]() {
      await pgClient.end();
    },
  };
};

export async function handler() {
  await using dbHandle = getDbHandle();
  return {
    statusCode: 200,
    body: "Hello World",
  };
}

Just tested and still an issue with 0.0.430

in v0.0.463 i specifically handled Target to unblock you - still thinking about the general problem though

@thdxr thanks boss! I think leaving the default as Esnext is totally fine. For people wanting to use "using" they can now set the target, or you could also support the "supported" feature of esbuild in the future https://esbuild.github.io/api/#supported


⚠ Bofrost.lu has degraded performance

In 049a1d8, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1358 ms

Resolved: Bofrost.lu performance has improved in a337191 after 9 minutes.


[Hub Generated] Publish private branch 'RPSaaSMaster-easm'

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/6901

@dw511214992 saw the staging readiness error - all I did was pull this PR from the private repo to this public repo. Was there anything else that needs to be done?

@dw511214992 Could we get some movement on this PR?  As @soniaab mentioned, we are failing one of the readiness tests but we do not deploy to that region so it's unclear why this is occurring.  Any help would be appreciated.

@dw511214992 Another ping ...

Hi, there are conflict files, pls resolve conflict.

Are you publish your service to public? If so, could you pls paste your private signed off PR here.

Are you publish your service to public? If so, could you pls paste your private signed off PR here.

https://github.com/Azure/azure-rest-api-specs-pr/pull/6901

@ruowan The conflicts have been resolved.

@soniaab Sorry, I missed your messages. Are you ready to merge this PR?


Add unittests to Trino Charm

This PR adds the following unittests:

test_initial_plan
test_waiting_on_peer_relation_not_ready
test_blocked_by_tls
test_ready
test_ingress
test_invalid_config_values
test_config_changed

Note that the _validate_config_params method is patched in 2 of these unittests due to this method checking for the existence of a keystore.p12 file that is created on relation with the tls-certificates-operator. In these simulations there is no such file.

This is becoming a combination of unittest and ci/cd workflow so I will close and open 2 distinct PRs


auth: add missing config values to helm values

Currently, some auth-related config properties are not exposed/configurable via Helm Chart.
This PR adds the missing properties to the Helm Chart.

Rebased to main to fix generate-k8s-check issues after https://github.com/cilium/cilium/pull/25824 has been merged

Rebased to main to fix generate-k8s-check issues after #25824 has been merged

It looks like this is not enough?

rebased to main to fetch fixes for blocking CI issues

/test


[BEAM-3357] Add grpcio upper bound

Latest grpcio 1.8.1 is not compatible with the protobuf version beam depends on.
R: @chamikaramj @robertwb

python tests failed with TypeError: __new__() got an unexpected keyword argument 'file'. I am not sure how that is related.

retest this please

Tests are failing due to https://issues.apache.org/jira/browse/BEAM-3343


Problems with relaying

I have a problem relaying mails from another container via docker-mailserver. Because of certificates I use the FQDN and public-ip when connecting to docker-mailserver, and I guess that means the client is not using a <IP_ADDRESS>/16 address but the public IP of the server.
So as far as I can see I have three options:
Add an entry in the local hosts file so that mail.domain.xx resolves to localhost. - I don't really like this approach. Easy to forget that hosts file when doing other changes.
Remove permit_mynetworks from smtpd_relay_restrictions. I assume that clients will still have to be authenticated with correct username and password, but it is a less secure option.
Add my public IP to mynetworks, but that is hard to maintain.
Is there any other way of getting this working with minimal ongoing maintenance?

For implementing option #2 I suggest this code added in start-mailserver.sh so that the option can be set via env-vars in docker-compose.yml
if [ "$ALLOW_AUTHENTICATED_RELAY_FROM_OTHER_NETWORKS" != 1 ]; then
  # We are removing the requirement of having to be in mynetworks ACL. Users still have to be authenticated with username and password.
  sed -i -r 's/smtpd_relay_restrictions = permit_mynetworks permit_sasl_authenticated defer_unauth_destination/smtpd_relay_restrictions = permit_sasl_authenticated defer_unauth_destination/g' /etc/postfix/main.cf
fi

It turns out I grossly underestimated how many changes are required to get relay working. So the above snippet is not enough. Still working on getting relay to work in Postfix.

Why not using authentication from the outside world?
Note that you can override default postfix configuration out of the box:
https://github.com/tomav/docker-mailserver/wiki/Override-default-postfix-configuration

Thanks. I have tried everything to get Postfix to accept relay from authenticated clients outside of mynetworks without luck. I will have another stab at this next week.

What kind of services are running into your other containers? Web applications?

@StianOvrevage any update on this?

I ended up adding my public ip to "mynetworks" in the postfix configuration. Not a good solution but it'll work for now. It's probably a postfix problem as well and not a docker-mailserver problem.


log video v5

See the docstring of PyPlotVideo for an explanation. I use the numpy format for the docstrings, but with an indentation of two spaces instead of four.
Compared with #76 child processes are now properly closed when the user kills the simulation (13d873c) and time-dependent examples can generate videos when running with --plt=video (625e1e6).

Looks good! The only question I have is unrelated to video: why did you add 'frames is None' to util.run? The main point of waiting for subprocesses to end is to not have their output overrunning the traceback explorer, which exactly applies to when frames is not None. I'm sure the answer is in 'deadlock' in the comment but I didn't get that.

Ah, now I get understand why you were waiting for subprocesses to die. Well, keeping the stack alive might keep subprocesses alive, resulting in a deadlock when waiting for them to die. What about killing subprocesses iff the traceback explorer is started?

Something else. Shall I automatically 'focus' a figure when entering a with-block? This eliminates the plt._pyplot.figure(plt._fig.number) lines in 625e1e6.

That would be much better, except I couldn't think of a way to do that without maintaining a global list of child pids. Until now, that is: I can probably kill them from Fork.exit directly. Let me look into that.

Regarding focusing: absolutely. That should be the entire purpose of the with-block as far as I'm concerned.

We could also redirect stdout of subprocesses when starting the traceback explorer.

Interesting. Never considered that. We might want to do both: killing child processes from within Fork, and muting output prior to starting the explorer just to be safe. This is out of the video scope though, is it an idea to remove the util.run modification and pull in the rest, then fix the child issue?

See #78.


[SPARK-44361][SQL][FOLLOWUP] Use PartitionEvaluator API in MapInBatchExec

What changes were proposed in this pull request?
This is a follow-up of https://github.com/apache/spark/pull/42024, to set the partition index correctly even if it's not used for now.

Why are the changes needed?
future-proof

Does this PR introduce any user-facing change?

No
How was this patch tested?

existing tests

CC @cloud-fan

the test failure is unrelated, thanks, merging to master/3.5!


⚠ jaswdr.dev has degraded performance

In 0f90a15, jaswdr.dev (https://jaswdr.dev/) experienced degraded performance:

HTTP code: 200
Response time: 1168 ms

Resolved: jaswdr.dev performance has improved in 27c2c3d.


Error from Here: undefined undefined

Adapter instance stays yellow.
Log: Error from Here: undefined undefined
Raspberry Pi 4 8GB, Debian 11, js-controller: 4.0.24, Nodejs: v16.19.0, NPM: 8.19.3

fixed with 1.1.0


Support SampleSet for initial_states

Deprecate the old tuple format.
Close #53.

This is a minor, backwards-compatible, PR, so I'll just go ahead and merge it in.
But, how do you feel about deprecation of the tuple format for initial_states, @arcondello, @wbernoudy?

Could we use dimod's concept of samples_like? Otherwise, I'm fine with deprecation of the tuple format and just using SampleSet.

@wbernoudy, the "samples_like" support sounds good (and note that dimod.as_samples() returns the samples/labels tuple we're deprecating), but it doesn't solve the problem of stating the vartype of the samples.
SampleSet includes everything as_samples returns + vartype + energies.
Energies are spam here, but at least conversion is simple:
initial_states = dimod.SampleSet(samples_like, 'SPIN', 0)

On a related note, I've been advocating for null energies in SampleSet, by default. But we still haven't gotten to an agreement there. /cc @arcondello.

We can infer the vartype from the samples, and in the ambiguous (all-1s) case we could assume it matches the BQM.


Import a path from public folder by import.meta.glob has a unexpected behavior

Description
For example, we got a file named 'bar.json' at /public/lfs/bar.json. We can use import to get the path.
import url from '/lfs/bar.json?url'

console.log(url)
// Will log '/lfs/bar.json'

However, by using import.meta.glob:

import.meta.glob('/lfs/bar.json') will get nothing, because there is no 'bar.json' in /lfs/, it is actually in /public/lfs/
import.meta.glob('/public/lfs/bar.json') will get /public/lfs/bar.json. But what we want is /lfs/bar.json

Suggested solution
None :(
Alternative
Instead of import.meta.glob('/public/lfs/bar.json'), using import.meta.glob('/lfs/bar.json') like import()
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

我也遇到了相同的问题，单独引入是可以的，批量引入必须带/public，而且批量引入控制台会警告，请问您解决了吗

I face the same problem, rn I use regex to change the path according to different env modes!
if (import.meta.env.PROD) {     const regex = /\/public(.+)/;     imgPath = imgPath.replace(regex, "$1");   }

Yeah, encountering the same problem with import.meta.glob("/public/avatar/*.png") - either I use /public path and get Assets in the public directory are served at the root path warinig, or remove public and get no avatars. Weird and confusing...


CI things

We most likely need go get off Travis, so we should figure out how to do that.
Current proposals include:

use conda-forge's system
github actions

@martindurant

Ref: https://github.com/dask/community/issues/107

Looking for volunteers...
With any luck, changing the CI will also fix the kafka test that times out on travis (but passes locally).

Can this be closed? It looks like CI was migrated to GitHub actions in https://github.com/python-streamz/streamz/pull/402/files and Travis was removed in https://github.com/python-streamz/streamz/pull/403

Can this be closed? It looks like CI was migrated to GitHub actions in https://github.com/python-streamz/streamz/pull/402/files and Travis was removed in https://github.com/python-streamz/streamz/pull/403


 I don't have it showing by default as I would like to get people to use the TOP items and mod integrations. I don't want to render them useless, so here is my idea:
Without the item, TOP displays only very basic information. Like the block's name and picture. Then, when you craft the item you unlock all the "bonus" information that you need to sneak to find out. Such as the harvest level, rf level, etc.
That way, the items aren't useless, and people used to waila not needing an item are happy.

Implemented next release


Material-Sprint: app/styleguide/radio

button.js

Consider putting classname strings in their own enum object near top of file so they can easily be changed in 1 place going forwards. For example:

this.ClassNames_ = {
  TRANSITION_LONG: 'transitionLong',
  UNSCALED: 'unscaled',
  SCALED: 'scaled'
};

Move functions to prototype. After discussing this with Addy, conclusion is that it was better to favor memory savings.  This means private variable declarations that need to be used in a prototyped function would need to be converted from var x to be this.x  so it can be accessed. We should therefore use the common convention of adding an underscore on the end to indicate it is private and shouldn't be used directly. So the variable would be defined as: this.x_ = blah;

What happens when radio buttons are added to the dom via javascript AFTER the document load has already fired? Handle this case as it is quite possible someone will need to programatically add a button.

Use Strict should be limited to function scope. Declaring outside of this leads to issues with code that is not strict. For example consider you have strict code like this which you then append before some non strict code (3rd party site). The fact this is declared globally  means it will assume the whole site is strict, when it is not, which of course then breaks the site. :-)

Should be addressed by https://github.com/google/web-starter-kit/commits/material-sprint?author=jasonmayes (December patterns sprint by Jason)


Support spdlog format pattern.

Should support both global and per logger format patterns.

Supported both global and per logger format patterns since 02b2caffea59042a87d7840b4be138bad71e7b9f.


4.0.46 tick label floating point rounding accumulation error

Plots like this keep occurring. I think this is because the new tick/layout system.

With hindsight I now realize should have forked the 4.0 stable branch before modifying the tick/layout system...

Fixed in 4.0.47
https://swharden.com/scottplot/cookbooks/4.0.46/#customize-grid-defined-grid-spacing
https://swharden.com/scottplot/cookbooks/4.0.47/#customize-grid-defined-grid-spacing

4.0.46
4.0.47


Codeunit 706 - Zip Stream Wrapper Encoding

The Zip Stream Wrapper Codeunit should be extended with a Encoding Parameter.
If the Zip content includes file names with special characters then you cant store the file name correctly.
To be able to use e specific codepage the OpenZipFromStream Function could look something like that:
variable gSystemTextEncoding = System.Text.Encoding.'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'
Code:
OpenZipFromStream(pInputStream : InStream;pZipArchiveModeIsUpdate : Boolean;pCodePageNumber : Integer)
CLEAR(gZipTempBlob);
gZipTempBlob.Blob.CREATEOUTSTREAM(OutputStream);
COPYSTREAM(OutputStream,pInputStream);
IF pZipArchiveModeIsUpdate THEN
gZipArchive := gZipArchive.ZipArchive(OutputStream,gZipArchiveMode.Update,FALSE,gSystemTextEncoding.GetEncoding(pCodePageNumber))
ELSE
gZipArchive := gZipArchive.ZipArchive(OutputStream,gZipArchiveMode.Read,FALSE,gSystemTextEncoding.GetEncoding(pCodePageNumber));

Info: Seems related to: https://github.com/microsoft/ALAppExtensions/issues/1173.

We've just completed our work on our Compression Management module, which I will publish to GitHub very soon. If it does not address your needs, we may have to tweak that module. However, the module is not going to be made available to BC before our fall 19 release. Is that an issue? If so, we will have to backport a solution, which we will have to break again coming fall 19.

We support 4 binary data encodings in Business Central AL - MsDos, Windows, UTF8 and UTF16. Is it good enough that we add an extra parameter of AL type TextEncoding (so you get support for these four encodings), or do you need ability to make a ZipArchive with any given encoding?
If you need the latter, keep in mind that the method that saves the zip archive to an OutStream will return an OutStream that is in the encoding that is not supported within Business Central.

I would like to give my comment about encoding, as somehow it is incorrectly assumed that 4 categories of encoding is enough. As I come from country where 4 basic encodings are not enough at all I see NAV/BC encoding support as broken and in our add-ons we usually need to fallback to .NET Encoding object to overcome this limitation (and for on-premise deployments it is good enough solutions).
It is normal for one client to use Windows-1252 encoding as their own, while others use Windows-1257, Windows-1253 and so on. No imagine that I need to import CSV file saved in Windows-1251 encoding while originally my regional settings says that my Windows encoding is Windows-1252. Using standard functionality application treats file as Windows-1252 and all non-Latin characters are completely incorrect. Since database internally uses UTF encoding if I can somehow read CSV file correctly (by doing that in .NET for example) in the end I get correct data and everything else works correctly.
The same can be said about ZipArchive functionality as well. It is completely normal to get an archive from client where file names in this archive are in different encoding than my Windows encoding. So what should be done in this situation - explaining client how to fix his archive file is not the solution as generally speaking archive isn't incorrect, so we fallback to .NET again and it works, but again we need to use custom solution in place of standard one.
So what I wanted to illustrate with my examples - maybe it is good time to think again about NAV TextEncoding implementation.  For example using codepage number as parameter in all functions where TextEncoding type currently is used and then giving developers such constants as TextEncoding.UTF8, TextEncoding.UTF16, TextEncoding.Windows, TextEncoding.MsDos which basically are just numbers indicating current codepages based on regional settings.

@dcenic:
The 4 supported data encodings are good enough for us. We actually use Codepage 850.
You can go ahead. Thank you very much for your answer.

The new method is checked in - you will be able to specify the code page number for the ZipArchive text encoding. It will be available in Zip Stream Wrapper codeunit in Business Central Update 27, which will most likely be available during August.
In the Business Central Fall 19 release, Zip Stream Wrapper codeunit is deprecated and replaced by Compression Management codeunit, and you will be able to do the same with Compression Management.

A new version of COD706 was checked in and pushed to this repo. It will ship in the next update. Resolving issue.


Is there a way for the new lock screens?

42 Paris gradually changes ft_lock by a new lock called dm-tool lock.  I tried changing the bash to try to make it compatible but it seems harder than I think.

In the end I managed to find a way to customize. but the project has nothing to do with the basic structure of pimp ma lock. So I created a new project : pimp_my_new_lock

Hi!
Is dm-tool lock back in the school? I tried to adapt PML to the new lock tool some months ago, and then, 42Paris reverted the changes and were back to ft_lock.

Yes the new lock only lasts a few weeks. So for the moment the problem is no longer really present.


(chore) <IP_ADDRESS> Changelog

Description
Just starting the PR for now, will add source changelog when it's available.
Testing instructions
Preview link: https://deploy-preview-6683--kongdocs.netlify.app/gateway/changelog/#3432
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

Github is returning 429 because we are sending too many requests, the links should work


Python stops and throws segmentation fault error

Environment info
Operating System: Ubuntu 16.04
Compiler: GCC 4.9.3
Package used (Python/R/Scala/Julia): Python
MXNet commit hash (git rev-parse HEAD): 5e5f19a
Python version and distribution: 2.7.12 GCC 5.4.0 20160609
Error Message:
Segmentation fault (core dumped)
Steps to reproduce

compile mxnet according to the official tutorial
go to python directory and input sudo python setup.py install
run python -c 'import mxnet'

Closed due to inactivity.


Add Mac OS tracy info to profiling docs

Explanation
I got kind of lost on this earlier (the Tracy docs are not very helpful) and required some assistance, so I thought it might be helpful to add this somewhere in the profiling docs. The way it's presently inserted is kind of awkward, but I don't know enough about the other operating systems to make similar sections for them, which I think would be helpful, since it's going to be different on each one.

@mweatherley I'll merge this once the merge conflicts and linting errors are resolved.

This is the markdownlint error message for reference, copied from CI:
/github/workspace/docs/profiling.md:45:1 MD033/no-inline-html Inline HTML [Element: details]
/github/workspace/docs/profiling.md:46:3 MD033/no-inline-html Inline HTML [Element: summary]
/github/workspace/docs/profiling.md:48:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
/github/workspace/docs/profiling.md:48:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
/github/workspace/docs/profiling.md:49:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
/github/workspace/docs/profiling.md:49:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
/github/workspace/docs/profiling.md:50:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
/github/workspace/docs/profiling.md:50:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
/github/workspace/docs/profiling.md:50:43 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
/github/workspace/docs/profiling.md:51:1 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 4]

Yeah, the issue is just that it has to be redone completely, since the current formatting can't actually be done in markdown without inline HTML. I can try rewriting the section in a way that incorporates it, I guess.


Highlighting in tsx seems broken

VSCode Version: Code - Insiders 1.3.0-insider (41f53d27a8cb477130f84116c78f43ddacbaf24b, 2016-06-27T05:07:29.758Z)
OS Version: Windows_NT ia32 10.0.10586

It seems to break on the <T,T> parts
Steps to Reproduce:

Create a tsx file with at least one class that extends React.Component
See!

import * as React from 'react';

class Test extends React.Component<{},{}> {
    public constructor() {
        super();
        console.log('created');
    }
}

class OtherTest extends React.Component<{},{}> {
    public constructor(){
        super();
        console.log('created');
    }
}

This seems to be related to commit 88f88a90938243434488ed72a81498651782607b, where the processing of angle brackets has been changed.

This issue was moved to Microsoft/TypeScript-TmLanguage#196


Project > Files > Getting "Unhandled Rejection (Invariant Violation): cache-only fetchPolicy option should not be used together with query refetch." error while deleting the main version of the file

Roles: All
Describe the bug
Project > Files > Getting Unhandled Rejection (Invariant Violation): cache-only fetchPolicy option should not be used together with query refetch. error while deleting the main version of the file
Steps to Reproduce

Login as Admin user
Create a new project and go to the created project's listing page
Open project created by Admin
Click on the view files button
Upload a new file e.g. test1
Click on the file kebab menu and add the file new version e.g.test2
Close the file Upload Manager menu
Again click on the kebab menu and click on the history button
Delete the main version of the file i.e. test1 and wait

Expected Result
The event should be performed without an error.
Actual Result
Getting Unhandled Rejection (Invariant Violation): cache-only fetchPolicy option should not be used together with query refetch. error while deleting the main version of the file.
See video - https://drive.google.com/file/d/1U6CryIpEFtu-RqDyY5aljQMKC53itena/view?usp=drivesdk
cord-field# 89ee57a1

Closing this out, we haven't seen this since launch. If it comes up again we can reopen.


Improve UI/UX by preventing or warning users when there are insufficient signer bonds to cover deposit refunds

Description:
The UI should warn or prevent users from initiating a deposit when there are is sufficient signers.
As shown in the transaction below, gas fees were incurred when a deposit is initiated but subsequently rejected by the smart contract.
https://ropsten.etherscan.io/tx/0xc6af32241decdc2e6a71a21fd47e6bce0b0d4db312829fcb1aa4ff3317ce1da5
A better UX will be to prevent this from happening or at least show a prominent warning that this transaction is bound to fail.
Steps to reproduce the behavior:

Go to tBTC minting dapp
Initiate a tBTC minting request
On step 2, "Initiating Deposit". An error is shown on Metamask but not on the page UI. Users may just proceed with the transaction and rejected at the smart contract.

Screenshots:

This is actually different than having insufficient signers. In the rare case that signers fail to properly form the signing group, the depositor (i.e., you) can claim a refund of the payment made to open the deposit. This revert happens when the bond the deposit requires from the signers is not enough to cover that refund. Rather than allow you to open a deposit you might not get refunded for, we quit early.
I adjusted the title accordingly; the core point of having a clearer earlier sooner in the flow is still absolutely valid.

This is actually different than having insufficient signers. In the rare case that signers fail to properly form the signing group, the depositor (i.e., you) can claim a refund of the payment made to open the deposit. This revert happens when the bond the deposit requires from the signers is not enough to cover that refund. Rather than allow you to open a deposit you might not get refunded for, we quit early.
I adjusted the title accordingly; the core point of having a clearer earlier sooner in the flow is still absolutely valid.

Thanks for the clarfication!


Track attempts to guess the 2FA code

Preflight Checklist

[X] I could not find a solution in the existing issues, docs, nor discussions
[X] I have joined the ZITADEL chat

Describe your problem
Password input attempts are tracked, 2FA code - are not. User can guess 2FA code with no limit, it has no attempts tracker. It gives attacker ability to bypass 2FA check with code guess,
Describe your ideal solution
2FA code input attempts are tracked alongside with password input attempts.
Version
2.36.0
Environment
Self-hosted
Additional Context
No response

Thank you for sharing your idea.
If there is a significant demand from customers/community, we will carefully consider implementing the feature.
Currently, the issue will be added to our product backlog.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

I quickly checked this and we have already implemented it.
You can see on the user changelog if otp verification has worked or not.
Also in the lockout settings you can choose how many attempts should be possible before the account is locked.


CAN Driver

Hi devs,
are there any plans to support a CAN driver in the ESP-IDF. I saw there is no describtion of the CAN interface in the ESP32 technical refence. But for example Simba RTOS has implemented the CAN interface.

There isn't a CAN driver in official ESP-IDF, but it seems someone has made one: https://www.esp32.com/viewtopic.php?f=12&t=380

@ThomasBarth has written a CAN driver for the ESP32, it is available as a component here:
https://github.com/ThomasBarth/ESP32-CAN-Driver/
I'll keep this issue open, but for now we don't have near term plans for a CAN driver.

A minimal CAN driver is available in Lua RTOS:
https://github.com/whitecatboard/Lua-RTOS-ESP32/blob/master/components/lua_rtos/drivers/can.c
https://github.com/whitecatboard/Lua-RTOS-ESP32/tree/master/components/can
https://github.com/whitecatboard/Lua-RTOS-ESP32/wiki/CAN-module

is can driver is available now officially?


Aerialway pylons missing

In #755, we added support for aerialway lines, but not for pylons, as they aren't present in OpenMapTiles:

Some map styles, like OSM-Carto, opt to style aerialway lines with an icon pattern that alludes to pylons, but the actual position of pylons is ignored:

Pylons are a useful visual reference when navigating urban areas on foot, and when represented on the map with a simple shape like a dot or square, they provide a pattern effect that complements aerialway lines. For reference, here's the same screenshot of OSM-Americana with crudely drawn dots representing aerialway=pylon and squares for aerialway=station:

That's amusing that osm-carto uses a pattern rather than the actual position. I agree it make sense to style the pylon nodes at the higher zooms where that level of detail makes sense.

Do we expect to eventually symbolize aerialway stations? If so, we’d need to ensure that the pylon icons aren’t so prominent that the reader could mistake them for stations.


WIP: Upgrade to PSR12 coding standard

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
yiisoft/yii2-coding-standards#42

Funny thing is... because of PSR12.Files.FileHeader.SpacingAfterBlock we need to change every file to add a new line before the copyright docblock....

Only PSR12.Properties.ConstantVisibility.NotFound left, I will put all of them to public, which is implied/default already.

Overall it looks good except what's mentioned in comments. Let's fix it and merge.

@rob006 do you think we should remove the cs folder and friendsofphp/php-cs-fixer dependancy at this point?
ref: https://github.com/razvanphp/yii2/commit/ba0ab403b52124c941dbeb46fbd9efdc12252a5d

@razvanphp Yes, it was never finished and AFAIK never worked as part of CI.

@samdark this is ready for merge FMPOV, but we need to bump the coding standard repo to use PSR12, then all the tests will pass.
BTW: why is this PHP 5.4 test failing now? seem that indeed array_column function was added only in PHP 5.5, so that's why it fails in 5.4, but we did not touch that file....

Done. Still errors.

Done. Still errors.

but we need a major tag to bump the coding standards in composer.json here

PHP 5.4 error is very weird cause it doesn't error in master branch and function call is there.

Tagged 3.0.0.

Good catch @rob006, fixed the test in b2585a6
Now we have to decide what we do with: Squiz.NamingConventions.ValidVariableName.PrivateNoUnderscore
The framework code initially decided to use underscore for private vars, even tho PSR2 had this rule (which is now included in PSR12 too). Should we goo all-in without underscores and adhere to PSR12 fully or add underscore for missing ones?

AFAIK underscore in Yii is not to indicate visibility, bot to avoid conflicts with virtual attributes provided by getters and setters. So sometimes you use it, sometimes not, I don't think there is a rule smart enough to cover this.

Underscores are to be kept. This is a technical thing, not just style.

All checks have passed. Please see my last 2 commits.

Merged. Thank you for working on it.


Merge pull request #8 from tobisupreme/dev

Update scripts for Prettier
This PR...
Changes

Fixes

Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] linter passes
[ ] added a test

Fixes #

This PR doesn't change any files 😅


Account tree

I've refactored the account "tree-tables" to also use ordered lists and flexbox like the journal.

This means we can better preserve the hierarchical structure of the account tree, which greatly simplifies the Javascript part.
The account "table cells" are not all of the same size anymore but also indented according to the hierarchy, which looks nicer IMHO.
The whole account "cell" is now clickable to collapse the account.

I'll clean up the SCSS some more in the coming days and then merge this.

@yagebu This looks awesome, not just code-wise.
I quite like account "table cells" that are intended as well. The SCSS needs some polish - things like line-heights - but shouldn't be too much.


Update README.md

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[ ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ ] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @AmrutaJayanti ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

#3150 I solved the issue
Could you please check and approve

Hey @AmrutaJayanti,
Please make sure to link the relevant issue using the appropriate syntax, such as "#issueNumber" 👀.
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

Thank you  @AmrutaJayanti , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Availability at f-droid.org

I would like to see this app on f-droid.org. It is an Android app store that only lists open source software, and builds the apks on their own.
Would you be ok with me submitting a "request for packaging" on the f-droid issue tracker? (See https://f-droid.org/en/issues/)

@cweiske even if the author agreed, F-Droid would not. The app comes with several proprietary libraries: Firebase, GMS and AppsFlyer Analytics. I've just added it to my repo for your convenience (should turn up with tomorrow's sync) – though I wish @zhaobao would remove those libraries. They don't go well with his promise never to collect the users' data.

@IzzySoft  Thanks for you suggestion, i just release a new version, remove Firebase and Appsflyer from the source code and fixed some gradle problem

@zhaobao Thanks – that's great! My library scanner confirmed the 3 are gone (I've added your app to my repo around the time I created above comment, the update should show up there with the next sync in half a day).
As the "offending libraries" are gone now, I've created a Request For Packaging (RFP), linking here for confirmation you agree with that. You might wish to setup Fastlane file structure (to provide screenshots and maintain summary/description here); if you do so, please drop me a note to update the RFP accordingly.
If you wonder why I "unframed" your screenshots in my repo: I have in mind that people view them on their phones, where framing "wastes" valuable space and make it harder to see details on the screenshots themselves. But that's my personal opinion, YMMV :wink:

PS: cool side-effect, the app size went down to half of what it had been before :smile:

@cweiske can you please take a look at this? Seems there are some remains requiring some Google API key. Any hints on how to (get around | get rid of) that? Thanks!

That's more for @zhaobao and not for me.

Ooops… true, my bad – apologies! Guess I had too many issues today :rofl:

While building project,
ERROR :- File google-services.json is missing. The Google Services Plugin cannot function without it.
How i will get google-service.json file ? @AnyBody Help Me If You Know....

My bad, the repository is no logger supported. But, for your need, please go with "no-ads" branch

@zhaobao umpf… does that mean we shall close the RFP at F-Droid again? Or would you be so kind to have a "no-ads" build flavor? F-Droid won't accept the following, taken from your build.gradle:
    implementation 'com.google.android.gms:play-services-ads:18.3.0'

apply plugin: 'com.google.gms.google-services'

So in order to build your app, it would need a build flavor coming without that.

Sorry, but without that we cannot include your app in F-Droid. I'll close the corresponding RFP then. Give us a ping should you still be interested and have a corresponding build flavor available, @zhaobao. Thanks!

Sorry, but without that we cannot include your app in F-Droid. I'll close the corresponding RFP then. Give us a ping should you still be interested and have a corresponding build flavor available, @zhaobao. Thanks!


Match fragment ions with multiple charges or not

Currently, MetaMorpheus matches deconvoluted masses. If one fragment ion has multiple charge states, only the closed one will be matched.
'Matching all charge states' is not evaluated.
Annotation of all charge states should be included.

I notice that charge 2 fragment ions are being searched/matched, even when the precursor charge is <3. Is there a rhyme or reason as to which fragment ions are searched now? Historically, we only looked at +1 fragment ions. Do we always look for +1 and +2 now?

The fragment charge needs to be less than or equal to the precursor charge.
Line 124 of MetaMorpheusEngine:
if (commonParameters.ProductMassTolerance.Within(closestExperimentalMass.monoisotopicMass, product.NeutralMass) && closestExperimentalMass.charge <= scan.PrecursorCharge)


detach() should not be used

When plugin deinits, the library is unloaded.  Detached thread will be using address that is no longer in the address space of the application. Hence segfault. Crashes like this with empty stack trace are not possible to triage.
https://github.com/search?q=repo%3Ardkcentral%2Frdkservices detach()&type=code

empty stack trace examples
14|0|||||0x9414b650
14|1|libpthread-2.31.so|start_thread|/usr/src/debug/glibc/2.31+gitAUTOINC+3ef8be9b89-r0/git/nptl/pthread_create.c|477|0x1

13|0|||||0xafa12a0e
13|1|libstdc++.so.6.0.28|std::execute_native_thread_routine|/usr/src/debug/gcc-runtime/9.3.0-r0/arm-rdk-linux-gnueabi/libstdc++-v3/src/c++11/../../../../../../../../../../work-shared/gcc-9.3.0-r0/gcc-9.3.0/libstdc++-v3/src/c++11/thread.cc|80|0x3
13|2|libpthread-2.31.so|start_thread|/usr/src/debug/glibc/2.31+gitAUTOINC+1094741224-r0/git/nptl/pthread_create.c|477|0x1


Tilt range filter wording correction

Min/Max Tilt "Range" sounds wrong to me... should it be "Angle" instead?

I checked with Anchi that it's actually tilt range, so this isn't an issue and I was mistaken when I created it.


Fix COLORREF links pointing to a 404

This pull request fixes links to documentation on COLORREF on DWMWINDOWATTRIBUTE enumeration (dwmapi.h) pointing to a 404 page.

@hyblocker : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Popover's methods

When you use the manual methods from the docs http://v4-alpha.getbootstrap.com/components/popovers/#methods they have unexpected behavior, i.e. if you have a button that show a popover and use the hide method via js, when you try to show your popover again when you click the button, the first click doesn't work, until the second

please provide an example as noted in CONTRIBUTING.md

Duplicate of #16732.


What is mean leaf_value?

Please search your question on previous issues, stackoverflow or other search engines before you open a new one.
For bugs and unexpected issues, please provide following information, so that we could reproduce on our system.
Environment info
Operating System: Windows 7
CPU: intel i5
C++/Python/R version: python 3.6
Error Message:
Reproducible examples
#importing standard libraries
import numpy as np
import pandas as pd
from pandas import Series, DataFrame
import graphviz
import lightgbm as lgb
#loading our training dataset 'adult.csv' with name 'data' using pandas
data=pd.read_csv('./adult.csv',header=None)
#Assigning names to the columns
data.columns=['age','workclass','fnlwgt','education','education-num','marital_Status','occupation','relationship','race','sex','capital_gain','capital_loss','hours_per_week','native_country','Income']
#Label Encoding our target variable
from sklearn.preprocessing import LabelEncoder,OneHotEncoder
l=LabelEncoder()
l.fit(data.Income)
data.Income=Series(l.transform(data.Income))  #label encoding our target variable
#One Hot Encoding of the Categorical features
one_hot_workclass=pd.get_dummies(data.workclass)
one_hot_education=pd.get_dummies(data.education)
#removing categorical features
data.drop(['workclass','education','marital_Status','occupation','relationship','race','sex','native_country'],axis=1,inplace=True)
#Merging one hot encoded features with our dataset 'data'
data=pd.concat([data,one_hot_workclass,one_hot_education],axis=1)
#Here our target variable is 'Income' with values as 1 or 0.
#Separating our data into features dataset x and our target dataset y
x=data.drop('Income',axis=1)
y=data.Income
#Imputing missing values in our target variable
y.fillna(y.mode()[0],inplace=True)
#Now splitting our dataset into test and train
from sklearn.model_selection import train_test_split
x_train,x_test,y_train,y_test=train_test_split(x,y,test_size=.3)
train_data=lgb.Dataset(x_train,label=y_train)
#setting parameters for lightgbm
param = {'num_leaves':150, 'objective':'binary','max_depth':3,'learning_rate':.05,'max_bin':200}
param['metric'] = ['auc', 'binary_logloss']
#training our model using light gbm
num_round=50
lgbm=lgb.train(param,train_data,num_round)
graph = lgb.create_tree_digraph(lgbm)
graph.render(view=True)
example : https://www.analyticsvidhya.com/blog/2017/06/which-algorithm-takes-the-crown-light-gbm-vs-xgboost/
Question.
I use create_tree_digraph. But I face trouble to understand plot. What is mean leaf_value? I heard leaf_value is predict score but I can't understand because it has negative  values not probability.

then If I apply sigmoid function to the score, can I get predicted value?

@yoonespi if you want to predict by yourself, not by LightGBM, you should apply sigmoid.

okay thanks!


Use nmt wrapper when creating commitments for PayForData transactions

currently, we're not using the nmt wrapper when generating commitments for pfd transactions. This is problematic because the wrapper is used when creating the data commitments, so when we modify the message inclusion check to actually use subtree roots, it won't be able to find them.
Also, we need the payment module to be more or less stable so that the audit process can begin.

An ErrInvalidShareCommit (11116) is thrown occasionally when a node running an earlier app version (v0.7.0-rc-1) submits a pfd to an app with #618.


Next release date?

Hi,
I would like to use the newly added "restart_policy" parameter (see https://github.com/docker/fig/pull/712#issuecomment-66755754). When is the next release of Fig scheduled? (I suppose version 1.0.2 is next).
Thanks

I really think there should have been a minor version bump by now. 2 months and 60 commits since v1.0.1 – a few bugs has been fixed too.


feat: update how to integrate

Signed-off-by: Takayuki Murooka<EMAIL_ADDRESS>Description
Add a explanation of how to integrate Autoware to your vehicle, considering config in the autoware_launch package described here
https://github.com/autowarefoundation/autoware_launch/issues/66

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 could you go over the reviews and also rebase it to the main branch?

I don't have much time for this. So I close the PR.


[3.x] Update Android Editor default display scale

Updates  the editor display scale based on the device's scaled density

I'm worried that the device's density can be very high (3 or 4), which causes the editor to be at an usable size by default on phones.
The automatically used value should probably be capped at 2 by default.

Thanks!


feat: async linting

This PR runs all linters for a single command (together) on a separate thread from further elaboration, making a first step towards parallelizing the elaborator.
Enabling #4363 would require further thought with this.

!bench

!bench

!bench

!bench

!bench

!bench


Exempt cfn stacksets service role from quarantine policy

Add CFN Stacksets service role to quarantine policy, to allow management account Stacksets to be able to bootstrap new accounts.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for contributing to ASEA. Note that customers should look at using Landing Zone Accelerator on AWS (LZA) We're currently only merging security and critical bug fixes. However all ASEA PRs and Issues are noted by the LZA team while developing that solution. Thank you!


Passing directories results in all non-js files being globbed

For example, running eslint-parallel ./src will attempt to lint all files under src, whether they be JavaScript or not.
Replacing ./src with ./src/**/*.js will attempt to lint files specified in .eslintignore, causing warnings.
Eslint itself has a utility for constructing the necessary globs, see https://github.com/eslint/eslint/blob/4def8764273e7cc53c71f0dd67da271636e4c1be/lib/util/glob-util.js#L47-L53. It doesn't look like it's exported from the package, but it's a small piece of code to reproduce.

Would be interested to hear about updates on this, as it's preventing me from being able to use this otherwise neat library to lint my large projects 😭

sure. pull requests are gladly appreciated

https://github.com/alansouzati/eslint-parallel/releases/tag/v1.0.0


Intergration of Prometheus and Grafan

This PR integrates basic monitoring with Prometheus and Grafana.
The services are included in the docker-compose files and run by default in the development environment. You can reach the Grafana web UI at localhost:3000. The credentials are admin:password. For now, no metric data is persisted.
Currently the following metrics are covered:

Resource Usage (per service)

CPU Usage
Memory Usage

HTTP Metrics (per service)

Amount of inbound requests along with the code the service responded with
Duration it took to respond
API calls per minute per route

Time to insert inbound records into the landscape model
System overview

Up/Down status of each service
Average amount of requests going into the system
Resource usages (CPU, nemory) of the hosts systems ExplorViz runs on

A distinct dashboard corresponds to each of the above categories. Let me know if you need more/other metrics.

@Alexander-Krause can you verify this works on Mac? I have the feeling that this breaks due to the lack of support for running containers in the host network. Prometheus expects to find the ExplorViz services at localhost:XXXX.

Will do.


Fix site

Site build on gh-pages is f**ked up.

This looks promising: https://wiki.bitplan.com/index.php/Multi-Module_Maven_with_github_pages#Whats_the_work-around


Fix np.searchsorted regression

Fixes https://github.com/numba/numba/issues/9441
Note for the reviewer: Previous code would allocate an array (np.array([v])) when v was a scalar. This allocation caused the code to be 4x slower when compared to previous implementation. This fixes this by only allocating an array when v is a container (list, tuple, ndarray)
import numba as nb
import numpy as np
import time

n_samples = 10000

segment_len = np.array([10_000] * n_samples)
stop_index = np.cumsum(segment_len, dtype=np.int64)
start_index = np.concatenate(([0], stop_index[:-1]))

upper_limit = 1000.0
lower_limit = 0.0

intensities = []
for i in range(n_samples):
    intensities.append(
        sorted(
            np.random.uniform(lower_limit, upper_limit, size=segment_len[i]).astype(np.int64)
        )
    )

intensities = np.concatenate(intensities)
search_values = np.random.uniform(lower_limit, upper_limit, size=n_samples).astype(np.int64)

@nb.njit(parallel=False, fastmath=True)
def test_np_search(search_values, intensities, start_index, stop_index):
    y = 0
    for i in range(n_samples):
        for search_value in search_values:
            y += np.searchsorted(intensities[start_index[i]:stop_index[i]], search_value, "left")

    return y

test_np_search(search_values, intensities, start_index, stop_index)

start = time.time()
test_np_search(search_values, intensities, start_index, stop_index)
end = time.time()

print(end - start)

Numba 0.58: 3.0s
Numba 0.59: 12s
This patch: 3.3s

NAT test that is failing on my branch (https://github.com/numba/numba/pull/9445) and before https://github.com/numba/numba/pull/9189 is:
import numpy as np

from numba import njit

@njit
def foo(a, v):
    return np.searchsorted(a, v)

a = np.array([
    np.datetime64(1, 'ns'),
    np.datetime64('NAT'),
])

args = (a, a[-1])
# got
r = foo(*args)
print(r)
# expect
r = foo.py_func(*args)
print(r)

Outputs:
$ python chk_nat.py
0
1

My branch has a searchsorted datetime64 test at https://github.com/numba/numba/pull/9445/files#diff-20a798fb06097b4e960ba71473dd4aae54d2f87466fb460bbea151000b6076aaR1135 and it currently filtering out NAT.

/azp run

/azp run


Enhance language detection

Summary
Some completely unrelated Languages can share the same characters, in Meilisearch we detect the Languages using whatlang, which works well on large texts but fails on small search queries leading to a bad segmentation and normalization of the query.
This PR stores now the Languages detected during the indexing in order to reduce the Languages list that can be detected during the search reducing the fails.
Detail

Create a 19th database mapping the scripts and the Languages detected with the documents where the Language is detected
Fill the newly created database during indexing
Create an allow-list with this database and pass it to Charabia
Add a test ensuring that a Japanese request containing kanjis only is detected as Japanese and not Chinese

Related issues
Fixes #2403
Fixes #3513

Arf, there is a conflict @ManyTheFish


feat: [DO NOT MERGE] support customer managed instance configurations

DO NOT MERGE: Depends on proto changes that have not yet been released.
Adds support for customer managed instance configurations.

cc @rahul2393

@olavloite 👋 , just wanted to check in on the status here. Do we need to keep this PR open or can development be done off of your fork?

@olavloite 👋 , just wanted to check in on the status here. Do we need to keep this PR open or can development be done off of your fork?

@dwsupplee
I would be happy to move this development into a branch directly in this repo, but then I would need to be granted access first (I currently don't have permission to push branches to the repo)

Seems already merged as part of https://github.com/googleapis/google-cloud-php/pull/5523/


zsh: command not found: composer after plugins/composer/composer.plugin.zsh updated

After update the composer.plugin.zsh the c* command can't work any more.
I also leave a comment on the #5886
My composer lives in the *composer/vendor/bin, installed by composer global require composer/composer. I wonder you guys installed composer in system bin directory by other way like apt-get or brew，so composer command should work before the *composer/vendor/bin set in the PATH.
However I'd like my composer lives in *composer/vendor/bin because I'd like to have my composer up to date everytime I ran cgu.
So is there some better way? maybe use find to find composer bin file in the user home directory and add it's path to PATH? Sorry that I am not familiar with shell so I can't tell what the exact code looks like.

current workaround
add composer vendor bin path manually in .zshrc
export PATH="$PATH:$HOME/.composer/vendor/bin"


feat: Store relationships between queries and tables

As mentioned in today's community meeting, the current method of associating dashboards to tables is through a relationship between dashboards and tables. There is no relationship stored between queries and tables. It seems to me that storing a relationship between queries and tables would be an easy add that would allow for greater flexibility in terms of how we use the data.
Service or Ingestion ETL
Metadata
Possible Implementation

Option 1: Store the relationship between queries and tables instead of between dashboards and tables. Dashboard--table relationships would only exist through intermediate query nodes.
Option 2: Store the relationship between queries and tables in addition to the relationship between dashboards and tables. This would require no immediate changes but would store additional relationships for potential use.

Context
I have no real immediate use-case for this, but this would potentially be useful for displaying example queries directly on tables (rather than showing relevant dashboards and making the user find the query) or even example queries that join some set of tables.

thanks @jonhehir for putting lots of great details on improving the project!

also I wonder whether it is now a good time to put asana as one of Amundsen users in https://github.com/lyft/amundsen#who-uses-amundsen given all the great work you and your team is doing ? also cc @jdavidheiser

RFC for this https://github.com/amundsen-io/rfcs/pull/27, would love your thoughts @jonhehir

Jon may not be available (his internship where he worked on this ended a while ago), but I have some context on what he was doing, so will take a look.

Hey, folks! Sorry for the delayed response. As @jdavidheiser mentioned,  I'm out of the internship and back on the grad school grind, so this isn't something I'm focused on currently. I'll leave a few comments in the RFC, though. Thanks!


Missing apt sources?

I am trying to setup an android build environment based on java 7 image as described on https://source.android.com/source/initializing.html. but at the very beginning I get a package not found:
$  apt-get update && apt-get install bison g++-multilib git gperf libxml2-utils make python-networkx zlib1g-dev:i386 zip
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package zlib1g-dev

I always assumed that base image is ubuntu, also the content of /proc/version says that base is ubuntu but content of /etc/apt/sources.list is only:
deb http://httpredir.debian.org/debian jessie main
deb http://httpredir.debian.org/debian jessie-updates main
deb http://security.debian.org jessie/updates main

so is this intentional not to have ubuntu sources? if so is there a way of installing zlib1g-dev on this image?

The problem is that you're trying to install the 32bit version of zlib1g-dev without 32bit sources.
Do a dpkg --add-architecture i386 and then try your apt-get update && ... again and it should work.

@tianon I did try that one too and it did not fix the problem, however I managed to fix problem by adding ubuntu's sources into sources file. not sure if that the correct way but it fixed my problem.

@mohamnag I think you did right, the source repo list should be updated when needed.

Doh, right, re-reading I realize you were asking about deb-src entries.  You are correct that they're not necessary for the way most folks use the debian and ubuntu base images, so they're not included by default (since they'll just slow down apt-get update runs for most folks), and should be added manually if they're necessary.  I usually like a one-liner like RUN find /etc/apt/sources.list* -type f -exec sed -i 'p; s/^deb /deb-src /' '{}' + for this purpose (to make sure I catch them all).  If this somehow creates duplicate deb-src entries, the result is harmless since apt-get will ignore the dupes. :+1:


cmd: add helper for seed generation

To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename.
This should fix the issue discovered in
osbuild/manifest-db#124
that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors.
This is the same as
osbuild/osbuild-composer#4124 hopefully for the right place this time.

LGTM but the linter is unhappy (fakeNamer is unused).

Thank you! Silly me, fixed now :)


Rspec-rails 3.2.1 - rspec-expectation specs failed on it block

It's a Rails 4.2.1 app with rspec-rails 3.2.1. For example consider a sample user notifier email
user_notifer.rb
class UserNotifier < ApplicationMailer
  def welcome(recipient)
    @user = User.find(recipient)
    mail(to: @user.email, subject: 'welcome')
  end
end

user_notifier_spec.rb
require "rails_helper"

RSpec.describe UserNotifier, type: :mailer do
  let(:recipient) { double(:recipient) }
  let(:user) { double(:user, email<EMAIL_ADDRESS>}

  subject { described_class.welcome(recipient) }

  it "welcome email" do
    expect(User).to receive(:find).with(recipient).and_return(user)
    subject
  end
end

When i run this spec, it got failed

when i was debugging, it looks subject didn't called

I'm not sure, what was the problem for this issue?

You've run into an edge case with the "magic" of ActionMailer. Your subject is not actually creating the mailer instance and calling welcome on it. It is instead creating an ActionMailer::MessageDelivery object.
The reason this "appears" to work in pry is that when you inspect the subject object ActionMailer actually instantiates the mailer instance and sends the message. Since pry uses inspect to display the value of a LOC, you get the behavior you see.
You should call deliver_now per the ActionMailer API if you would like to create the mailer object.
Also note that your actual code will get a warning from Rails the way you are using User.find with an instance of a user object:
DEPRECATION WARNING: You are passing an instance of ActiveRecord::Base to `find`. Please pass the id of the object by calling `.id`. (called from block (2 levels) in <top (required)> at /project/path/spec/mailers/user_notifier_spec.rb:16)

However, since you are stubbing this call, you will not see the warning in your spec output.

@cupakromer Thanks for your updates, yes it was specific to ActionMailer, similar specs for other objects/services(except ActionMailer object) were working fine.


TAG Lifecycle

Hi all, :)
I started using the terraform-aws-modules a few weeks, everything is working fine except I have a problem with TAG lifecycle.
Many tags, specially on Root EBS have issue with the lifecycle, everytime I run a terraform apply, they are in turn created or deleted.
Some Root EBS Name are modified, once with the EBS Name, the following time with the EC2 Name ...
I thought I should add a lifecycle Meta-Argument in my code but while I manage to do it in ressource, I can not use it with modules.
Is it the right way to solve this issue?
Any feedback are welcomed! ;)
Thanks in advance,
David

OK, i discovered this conversation.
https://stackoverflow.com/questions/67778177/terraform-can-i-pass-ignore-changes-to-the-module
I am really troubled now.
Modules (especially these modules) are great but this is a big drawback if lifecycle can't be implemented easily...
Thanks

Make sure to specify tags on root_block_device or volume_tags to have them adequately propagated to the resources.
There is nothing we can do in the modules to allow parametrization of lifecycle meta-argument because, as you discovered, it is not supported by Terraform.


use Boolean in models instead of boolean

the default value of boolean is false, that means that the serializer will always serialize it to false in every request example:
Ticket x=new Ticket();
x.setId(ticket.getId());

json will be
{
  "tickets" : [ {
    "id" : 409671,
    "has_incidents" : false
  } ]
}

because of private boolean hasIncidents; need to be change to private Boolean hasIncidents; also the setter and the getters
i will create PR for it by the end of the day

pull request created


Lemonbar is started on unplugged screens

When instance_per_screen is enabled, lemonbar is started even on screens that are not detected by xrandr (or not plugged).

Still randomly the case. Re-opening the issue to try finding a pattern that could be tested.


Allow passing location of configuration file to ParseFile

It's quite common nowadays to keep github-related files under the .github directory in a repository, to keep the root file listing cleaner.
I've been trying to figure out a way to pass the path to the .github-changelog-generator somehow, which seems to be supported but not actually used or surfaced.
I think it would be good if passing the file path were supported and documented as part of the advanced examples doc.
Thanks!

Right, good dig!
Would you like to improve the implementation and write a test for it?

He, would love to, but would have to learn ruby from scratch too as part of that. Seems like a large-ish endeavor. Maybe some other kind soul will volunteer 🙏

I think this is already supported with the --config-file parameter that is documented in referenced page.

Ha! I see you added that support after I reported it @anakinj 😉


Added convolutional code

I'm still going to compare the speed of this vs GPflow 1.0.

The speed is roughly equivalent, as you expected.


FAI-397: Score Cards: Support deletion of Attribute labels

See https://issues.redhat.com/browse/FAI-397

@kelvah @tiagobento @sjamboro This PR has finally become available for review...
After this one I should be able to work on moving the inlined functions to useCallbacks and the Validation refactor :-)

@kelvah FYI updates completed:

Hi @tiagobento could you please review. Thank-you.

Hi @tiagobento this is just needing your review please.


Scatter Plot - Legend

Hi,
I am trying to plot simple Scatter Plot using D3Plus. Here is the fiddle - http://jsfiddle.net/Bq7Lc/9/
In this, I have used size function also to control size of circles and in doing so, I do not get labels for all circles in one go.
Also, legends do not appear. I tried enabling legend but still it doesn't work. Can someone please look?
Thanks,
Himanshu.

Labels will not be placed inside circles that are too small for text.
To enable the legend, you must explicitly set a .color( ) variable. I've updated your fiddle: http://jsfiddle.net/Bq7Lc/10/