'gameinput.h': No such file or directory

Description
The same project stopped compiling
https://github.com/dviglo2d-learn/minimal_app/actions/runs/11765110312/job/33081717138
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Current runner version: '2.320.0'
Operating System
Microsoft Windows Server 2022
10.0.20348
Datacenter
Runner Image
Image: windows-2022
Version: 20241113.3.0
Included Software: https://github.com/actions/runner-images/blob/win22/20241113.3/images/windows/Windows2022-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3
Runner Image Provisioner
2.0.384.1
https://github.com/dviglo2d-learn/minimal_app/actions/runs/11765110312/job/33081717138
Is it regression?
Version: 20241021.1.0  https://github.com/dviglo2d-learn/minimal_app/actions/runs/11765110312/job/33081717389
Expected behavior
а
Actual behavior
а
Repro steps
Fork and build https://github.com/dviglo2d-learn/minimal_app

Version: 20241113.3.0

Might be related to https://github.com/actions/runner-images/issues/10978.

Hi @1vanK - Thank you for bringing this issue to our attention. We will look into this issue and will update you after investigating.

This blocks everything that tries to compile SDL3

Can confirm that a previously working job to compile SDL3 started mysteriously failing on windows runners, even at the same commit. Last known success was November 13th.
Specifically, the same job is passing on Windows 2022, version 20241021.1.0, but failing on Windows 2022, version 20241113.3.0.

Hi @1vanK - We would like to inform you that the latest windows-2022 image version (20241125.1) has been rolled out. Please update your sync process and try using the new version. Let us know if you encounter any further issues. Thanks

Tested here: https://github.com/dviglo2d/dviglo2d/actions/runs/12081991276/job/33692185689
The error remains

Hi @1vanK  Thanks for your input. We will look into this and will update you with possible solutions.

I think there's something wrong with either MSBuild files or the CMake Visual Studio generator on the runner image.
Switching to the Ninja CMake generator does not cause a gameinput.h error.

What is default SDK version in https://github.com/actions/runner-images/blob/win22/20241201.2/images/windows/Windows2022-Readme.md?
With -D CMAKE_SYSTEM_VERSION=10.0.26100.0 the building is successful
Branch: https://github.com/dviglo2d/dviglo2d/tree/test_26100
https://github.com/dviglo2d/dviglo2d/actions/runs/12165886093/job/33930879971

Hi @1vanK- Thanks for your input, we will check into your above link and will update you. Thanks!


Bump to support PSC 0.9

Looking for opinions on these changes. I'm new to PS. I haven't used this as-is yet, but it successfully builds.
Bump dependency versions. Require mustache in the FFI JS to support running pulp test.

@chexxor Thanks for making these changes! It's been a while since I used PureScript but I'll take a closer look soon and merge it in so that the code can be used with a more modern PureScript version.

No problem. This PR doesn't even compile, I believe, as I think I used the wrong comment syntax.
I'm still iterating on this - I'm getting rid of the StrMap and replacing with native PS records. I'm adding some tests, too.
We can discuss making me the maintainer instead of you, if you'd like. I'm planning to use this in a project I'm starting.

@chexxor hey there, sorry for not getting back to you. Are you perhaps still interested in becoming the maintainer of this project? I do think it's better if an active user of this code also maintains the project.
If not, that's okay too - in that case I'll refresh my PureScript knowledge, merge in your changes and produce a new package.

I'm not using this package myself, but I don't mind maintaining it. I'm relatively active with PureScript right now, and I'm planning to continue for several months.

@chexxor the project now supports the latest compiler as a result of this pull request: https://github.com/svisser/purescript-mustache/pull/3.
However, looking at the changes in this pull request, the project still uses Data.StrMap. I'm not familiar with Record but would you say it's worthwhile to convert this project over to use that instead?

Thanks for poking me about this again! I'm quite a bit more experienced with PS now, so I can see that my MR got some things wrong, and I can see a more type-safe way to do this FFI.
If this project switches to Record, there can be much better type-checking. For example:
newtype Template i = Template String
type View i = Record i
foreign import data MUSTACHE :: Effect
-- This function type-checks that the Template and its ViewModel have the same properties.
foreign import render :: forall i eff. Template i -> View i -> Partials -> Eff (mustache :: MUSTACHE | eff) String

-- Owner of this function needs to accurately represent the parameters of the template.
-- Be responsible!
emailTemplate :: Template ( name :: String, amount :: Int )
emailTemplate =
  """
  Hello {{name}}, you have won ${{amount}}!
  """

-- A model is just a Record.
emailModel :: View ( name :: String, amount :: Int )
emailModel = { name: "John", amount: 1000000 }

main = do
  -- emailTemplate and emailModel must have the same keys
  formattedTemplate <- render emailTemplate emailModel mempty

gtg for now.

LMK if you're interested in my updating my PR to make render more safe like this.

Closing in favor of https://github.com/svisser/purescript-mustache/pull/4
Thanks!


Build instructions for spawnedshelter

Please add a paragraph to README how to install (something-something npm install didn't really succeed for me first with missing packages then with some exceptions which i would not care to investigate) and how to make the website. For javascript-challenged minds. We do Erlang, not Javascript.
In short: I installed node, installed stylus for npm, installed pandoc, installed god knows what else (sudo npm install -g), and it gave me postcss error Promise not defined. That is not something i want to fix. Did I install it wrong? A wrong node maybe.
Perfectly a single run of make should have done all preparations.

@kvakvs thanks for submiting the issue. Las week I created a task for this #19. I did not have time to do it yet.
make deps should be enough to get the dependencies if you have node and haskell (needed for pandoc) installed. Probably postcss (a library needed for adding css prefixes for each browser) has some  issue with your node version. At the end of the day I will try it and I will add the instructions.

I added the build instructions and requirements to the readme.


500 Error

When I search the Measure from Master Patient List and Try to open the Patient file from there. I'm getting the 500 error.

Does this happen with all patient pages, or a particular patient?

Moving forward, can you please use the Cypress JIRA when reporting issues.
https://oncprojectracking.healthit.gov/support/browse/CYPRESS

It happens after you search the patients by measure and click one of the patient. The above error is coming in cypress 3.0.0.

Is this still occurring in Cypress 3.0.1?


Using webClient in global filter,Some requests result in timeout when blocking reading，But some requests are normal，Why？

Hi：
Using webClient in global filter,Some requests result in timeout when blocking reading，But some requests are normal，Why？
main code
<spring-cloud-gateway.version>2.2.5.RELEASE</spring-cloud-gateway.version>
<dependency>
        <groupId>com.github.ben-manes.caffeine</groupId>
        <artifactId>caffeine</artifactId>
</dependency>
<dependency>
        <groupId>org.springframework.cloud</groupId>
        <artifactId>spring-cloud-starter-loadbalancer</artifactId>
</dependency>

@Bean
@LoadBalanced
public WebClient.Builder loadBalancedWebClientBuilder() {
    return WebClient.builder();
}
@Autowired
private WebClient.Builder webClientBuilder;

Mono<JSONObject> checkUser = webClientBuilder
            .build().get().uri("url", HttpMethod.GET)
            .headers(e -> e.putAll(newHeaders))
            .header(HttpHeaders.CONTENT_TYPE, "application/json")
            .retrieve().bodyToMono(JSONObject.class);
CompletableFuture<JSONObject> userFuture = CompletableFuture.supplyAsync(() -> carInfo.block(Duration.ofSeconds(5)), GlobalThreadPool.getExecutor());
JSONObject body = userFuture.get();
return chain.filter(exchange);

Do you actually know why?
Thanks

the error msg is java.lang.IllegalStateException: Timeout on blocking read for<PHONE_NUMBER> NANOSECONDS

You should never call block() on WebClient

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

You should never call block() on WebClient

However, I need to query user permissions in the gateway, and cannot avoid using synchronization requests，What should I do？

In a reactive flow, you need a subscriber to the mono or flux. With gateway, the framework does the subscription and you just need to attach to the reactive filter chain.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Add Welcome Bot message to first time contributors

Description of the desired feature:

Follow the PyGMT example: https://github.com/GenericMappingTools/pygmt/blob/d01da5ae66ede8b23d1765554a943adc23b1936d/.github/config.yml
Are you willing to help implement and maintain this feature?

Yes

Closed with 8b6119e1056274fb0641fbbe0c302ceedd3fa8e0. Used Welcome Bot and .GITHUB/config.yml to add welcome messages for issues, PRs, and merges.


update extension

Steps to reproduce
The "ikigai mangas" extension has changed its web address to: nocbro.xyz
Expected behavior
all the mangas in the extension should load my pages
Actual behavior
But now it tells me that there are no pages found in any manga of the extension
Crash logs
No response
Mihon version
App version: 0.16.5 (standard, 2a01a2a, 6, 2024-04-09T09:58:14Z) Android version: 13 (SDK 33; build LH7n-H894JKLM-T-GL-240313V1715) Device brand: TECNO Device manufacturer: TECNO Device name: TECNO-LH7n (LH7n-GL) Device model: TECNO LH7n WebView: Android System WebView 124.0.6367.123
Android version
Android 13
Device
Tecno LH7n
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Mihon doesn't have, associate, or provide any extensions, go ask whoever maintains your extensions instead


bors-ng should read CircleCI config

This change is

bors try

bors try

bors r-

bors r+

bors r+

bors try-


Use // to sand box directories

Sometime you need to create a path from the user input, and you want to prevent the user to add "~", ".." and the likes to the path and access parts of your system you don't want them to do.
Suggested syntax:
Path('stuff') / 'foo/sandbox' // user_input

'//' would then do:
basedir = (Path('stuff') / 'foo/sandbox').realpath()
fulldir = (basedir / user_input).expanduser().expandvars().realpath()
if not fulldir.startswith(basedir):
    raise ValueError("%s is outside of the %s sandbox" % (fulldir, basedir))

This is an intriguing idea. It does describe what I would say is a common use case and uses a reasonable symbol for the operation.
I can think of some downsides, however.

The implicitness of it is striking. Anybody taking advantage of this operator would almost certainly need to provide a comment explaining what the // does, or run the risk of it getting replaced with /.
I'm not sure that Python 2 even has a distinct // on which you may rely.

May I suggest instead, first create a method .safe_join or .sandbox_join which implements the desired behavior. That method would not be subject to the downsides. Then, if __floordiv__ or similar can be used to provide //, that method could be a simple alias for the named method. This approach would also provide a good place for documentation of the functionality (in a docstring).
Do you have a use case where this function would be used today that you could share?

Le 29/03/2016 18:15, Jason R. Coombs a écrit :

This is an intriguing idea. It does describe what I would say is a
common use case and uses a reasonable symbol for the operation.
I can think of some downsides, however.

The implicitness of it is striking. Anybody taking advantage of this
operator would almost certainly need to provide a comment explaining
what the |//| does, or run the risk of it getting replaced with |/|.
I'm not sure that Python 2 even has a distinct |//| on which you may
rely.

You just gave me an idea:

p = Path('/foo/bar').sandbox()
type(p)

p / 'anything' # this always get the sandbox check

May I suggest instead, first create a method |.safe_join| or
|.sandbox_join| which implements the desired behavior. That method would
not be subject to the downsides. Then, if |floordiv| or similar can
be used to provide |//|, that method could be a simple alias for the
named method. This approach would also provide a good place for
documentation of the functionality (in a docstring).
Do you have a use case where this function would be used today that you
could share?

any web service offering file browsing as an REST API;
script you want to ward against people using it in a context where
user data is not properly checked or escaped;

And we could also define a security policy for any sandboxed path so
that it can never result in some paths.
Something like:
Path.add_sandbox_policy(exclude=['/', '/var', '/usr'])
(not a definitive API proposal, just to show off the concept)
So that if you use sanboxed paths, you will get an error trying to
resolve to those path anywhere in the program.
This is a good warding against typos, accidental data corruption and
mischiefs. Indeed, in theory your code should double check 3 times that
something is not going to unlink() your entire server, but we all did
the mistake once.
Now, but using sandbox paths in your project where critical data is
manipulated, you have an additional layer of security. Not perfect, but
still useful.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jaraco/path.py/issues/108#issuecomment-202980784

// looks too much like a samba access on windows for my taste. Take it as a remark only, it's not a feature I'd personally use in the near future anyway.

Yes, the second proposal with the sandbox() method seems better to me now.

Closing due to inactivity. Feel free to revive.


Add Prefix & Suffix Widget in TextField

Added prefix icon and suffix icon as optional parameters to textfield also added prefixIconAction and suffixIconAction as optional parameters.

Thanks for the contributions @Aditya-Mi 👍🏼

Thanks @Aditya-Mi for your contribution 👍

This PR Closes #90 and #110


License?

@wesleyi23 Thanks for all this work, it's great to see!
Could you add a license header for each file and a general license file in the repo?
Looks like Stephen Gate's original work is licensed under CC BY 4.0:
https://github.com/wesleyi23/GTFS-Frictionless
So it probably makes sense for any related/derivative content to be under that license?
FWIW, for code my personal preference is Apache v2.0.

Done


Please upgrade to the latest version to get a critical bugfix

Heads up!
NPM should no longer be listing this as a vulnerability.
We worked with Snyk to resolve this immediately when it was reported, you can confirm that it was fixed by running snyk (instead of npm audit). See https://github.com/base/base/issues/36 for more details.
v2.0.1 is a patch release to prevent unsafe properties from being assigned. See this guide if you need more assistance.

Unfortunately, choosing to upgrade the major version number to v2.0.0 (rather than, say, v1.4.0), given that there are not breaking changes, makes this a bit more painful than necessary as many dep chains like webpack-dev-server > http-proxy-middleware > micromatch > snapdragon > base > mixin-deep use ^1.2.0, forcing application owners to use yarn's "resolutions" feature to override.

https://github.com/micromatch/micromatch/issues/174


README: Describe how to load auto_apt before bash

apt_tabcomplete does not work if bash completion is loaded before auto_apt. I've added a note to the readme which explains how to load the completer in the right order so that apt_tabcomplete will be able to catch completions for apt-* before bash does.

Awesome, thank you!


Device statistics does not show details of the enrolled android device

I have enrolled an android device and performed some operations too. When I navigate to the device statistics portal the. Device count is 0 and there are no information displayed for the enrolled device.

Labels - 3.1.0-M8, Bug, Blocker

This portal will be removed from the IoT server 3.1.0. Hence no fixes are needed.


AlphaFold Multimer

Hi!
I'm enquiring if it is planned to include support for AlphaFold multimer in a future release. Would be greatly appreciated!
Esa-Pekka

Ahhh, my bad. I was using the : separator as in the colabfold implementation which obviously didn’t work. Thank you for the response!
--
Esa-Pekka Kumpula, PhD
Postdoctoral Researcher
Laboratory of Structural Biology
Institute of Biotechnology
Helsinki Institute of Life Science HiLIFE
University of Helsinki
https://www.helsinki.fi/lsb

From: Laura Luebbert @.>
Sent: Friday, September 9, 2022 5:35:38 PM
To: pachterlab/gget @.>
Cc: epkumpu @.>; Author @.>
Subject: Re: [pachterlab/gget] AlphaFold Multimer (Issue #43)
Hi Esa-Pekka, gget alphafold already supports multimers. Simply pass multiple sequences as a list, or a fasta file containing more than one sequence, and it will automatically use the multimer model. Let me know if it works for you! :)
—
Reply to this email directly, view it on GitHubhttps://github.com/pachterlab/gget/issues/43#issuecomment-1242054078, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2RUI2Q4FGW7YM7VFWWKVHLV5NDLVANCNFSM6AAAAAAQIXCYIA.
You are receiving this because you authored the thread.Message ID: @.***>

gget will currently create a "tmp" folder in your home directory ("~/tmp/jackhmmer/") for the Jackhmmer search. I think adding an option to change this path is a great idea for a future version. The temporary files will take up to ~2 GB (in case it is possible to free this space until I have implemented your request).


Hotfix v3.25.4

Fixes
Update isValidMessage check for Safe Apps https://github.com/safe-global/safe-react/pull/3907

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.261%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/safe/components/Apps/communicator.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3605

Relevant Lines:
9284

💛  - Coveralls

Tested briefly, the communicator works. ✅

Buenos días gentlemen, I have been playing with our apps and a few external ones on Rin, Polygon, Gnosis Chain and Aurora and have been working as usual for me :)


Grammar

Fixed minor grammar, spelling, and wording typos.

Pull Request Test Coverage Report for Build 159

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.927%

Totals

Change from base Build 158:
0.0%

Covered Lines:
1065

Relevant Lines:
1316

💛  - Coveralls

Pull Request Test Coverage Report for Build 159

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.927%

Totals

Change from base Build 158:
0.0%

Covered Lines:
1065

Relevant Lines:
1316

💛  - Coveralls

Thank you!  Merged.


Not allow multiple Django/Flask servers to run on the same port

When you open a terminal and manually run a Django app and then start debugging it, it looks like there are two servers running on the same port. If you add a breakpoint to the editor, it may not hit it as the application running 1st could get preference (the preference seems to be non deterministic on Windows).
My feature request is to either not allow it to happen, or display a warning saying there is another application running on the same port and this could conflict with the debugging one.

@int19h Do you think this can be avoided/identified?

Not on our end. In this scenario, the other app is completely out of the picture as far as anything in VSCode is concerned.
The framework itself can handle it if it opens the server socket in a mode that prevents other apps from reusing the same port. It might be something that is configurable in Django.

Got it... closing this as this is something user needs to configure themselves.


Bug in Objective - Missing Beta?

Looking at the objective function in the dev branch.... is it missing the coefficient and just using the adstock and saturation? And is this taking the full channel budget and applying it every period? spend = np.full(self.num_periods, budget)
def objective(self, budgets: list[float]) -> float:
        """Calculate the total response during a period of time given the budgets.

        It considers the saturation and adstock transformations.

        Parameters
        ----------
        budgets : list[float]
            The budgets for each channel.

        Returns
        -------
        float
            The negative total response value.

        """
        total_response = 0
        first_transform, second_transform = (
            (self.adstock, self.saturation)
            if self.adstock_first
            else (self.saturation, self.adstock)
        )
        for idx, (_channel, params) in enumerate(self.parameters.items()):
            budget = budgets[idx] / self.scales[idx]
            first_params = (
                params["adstock_params"]
                if self.adstock_first
                else params["saturation_params"]
            )
            second_params = (
                params["saturation_params"]
                if self.adstock_first
                else params["adstock_params"]
            )
            spend = np.full(self.num_periods, budget)
            spend_extended = np.concatenate([spend, np.zeros(self.adstock.l_max)])
            transformed_spend = second_transform.function(
                x=first_transform.function(x=spend_extended, **first_params),
                **second_params,
            ).eval()
            total_response += np.sum(transformed_spend)
        return -total_response

Nevermind, I see that Beta is applied in the saturation function.....


GH-2315 bugfix: some complex unicode characters fail to unread properly

e.g. this character:
https://www.compart.com/en/unicode/U+1109D
the following string fail to unread:
"<r:\uD804\uDC9D>"

since same position is loaded more than once into reader's buf.
GitHub issue resolved: #2315
Briefly describe the changes proposed in this PR:
unread index is decremented properly to ensure proper unread

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[x] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

Could you please digitally sign the Eclipse Contributor Agreement (ECA)? See the Contributor Guidelines for more details on how to sign. Unfortunately, we cannot accept your contribution until you have signed this. It shouldn't take more than 5 minutes.

@jeenbroekstra , what is holding back this PR? How can the checks be rerun?

It's mostly just me having a deadline at work and therefore not finding the time yet to look at this. But I'll try and take a peek tomorrow or Friday.

@jeenbroekstra thank you!

No worries mate. Take your time and let us know if we can donanything to help :)

It looks as if the CI build just failed due to a temporary glitch. I've restarted it.

Looks all good to me now. Thanks again!


Add icon to Photino.Blazor nuget package and sample

added photino default favicon.ico to nuget package
added photino default favicon.ico to process and window

Your example (MudBlazor) is not working, if you often switch between Nav-Links, then "An unhandled error has occurred" appears.
blazor.webview.js:1

Received unexpected acknowledgement for render batch 46 (next batch should be 45)
at Microsoft.AspNetCore.Components.WebView.Services.WebViewRenderer.NotifyRenderCompleted(Int64 batchId)
at Microsoft.AspNetCore.Components.WebView.IpcReceiver.OnMessageReceivedAsync(PageContext pageContext, String message)
at Microsoft.AspNetCore.Components.WebView.WebViewManager.<>c__DisplayClass18_0.<<MessageReceived>b__0>d.MoveNext()

@NewMySQL , with your sync fix in your PR is MudBlazor sample stable?

@NewMySQL , with your sync fix in your PR is MudBlazor sample stable?

Yes, stable

OK, this is now just adding the icon.
BTW: The link to vs code templates is either broken or the project is private.
This url:
https://github.com/tryphotino/PhotinoSamples.VSExtension


feat: hyperlinks

str := lipgloss.NewStyle().
    Foreground(lipgloss.Color(63)).
    Underline(true).
    Hyperlink("https://charm.sh").
    Render("Charm!")

Closes #220.

Getting this right will be more work that we think, namely because of wrapping. Consider the following:
https://github.com/charmbracelet/lipgloss/assets/25087/1b3fee5f-e91e-4fab-8161-19c27838ffc9


Add mouse_passthrough_rects

Resolves https://github.com/godotengine/godot-proposals/issues/8568
Implements the following:

DisplayServer: Adds window_set_mouse_passthrough_rects(const TypedArray<Rect2i> &p_rectangles, WindowID p_window)
Window: Adds property mouse_passthrough_rects which define input regions

For display servers supporting mouse_passthrough_polygon (X11, Windows, macOS) a combined input region is created out of both properties. As before everything outside of the region will be passed through.
For Wayland only mouse_passthrough_rects is implemented.
I tested on X11, Wayland and Windows. I can't test macOS myself. A simple test project showcasing both passthrough types used together is here: input_region_test.zip (the root node has export variables to cover all test cases, default is just polygon and rect passthrough on)
I'm making this a draft for now since I want to check how much we can change the existing API. Also unsure if the display server specific implementations are fine since I never wrote something like that before.

Not sure if I see any reason for adding separate functions for rects, may it's better to extend existing functions to take multiple polygons instead of one?
Both renaming window_set_mouse_passthrough and changing it to accept multiple values will be breaking change and require a compatibility wrapper added, but in both cases adding _polygon/_polygons to seems like a good idea.

window_set_mouse_passthrough_(polygons/rectangles) modify variables stored within each DisplayServer, that's why I let them stay separate, but since the method names are getting quite long and you can't query the values I guess we could put them together into one window_set_mouse_passthrough(const TypedArray<PackedVector2Array> &polygons, const TypedArray<Rect2i> &rects) .
I also agree with adding multiple polygon support then. Since this would be a breaking change anyways might as well complete the API.
I have no idea about compatibility wrappers. Do you just mean leaving the old method in and making it call the new one and marking it as deprecated?

Not sure if I see any reason for adding separate functions for rects.

I guess the main reason is wl_region limitations, it would be nice to evaluate how slow will be approximating polygon with rects.

I have no idea about compatibility wrappers. Do you just mean leaving the old method in and making it call the new one and marking it as deprecated?

Add something like this to the protected part of display_server.h:
#ifndef DISABLE_DEPRECATED
	void _window_set_mouse_passthrough_comat_bind_88558(const Vector<Vector2> &p_region, WindowID p_window = MAIN_WINDOW_ID);
	static void _bind_compatibility_methods();
#endif

Add display_servrer.compat.inc (plus standard header comment):

#ifndef DISABLE_DEPRECATED

void DipslayServer::_window_set_mouse_passthrough_comat_bind_88558(const Vector<Vector2> &p_region, WindowID p_window) {
	// Call new function with transformed argument here, like:
	TypedArray<PackedVector2Array> polygons;
	polygons.push_back(p_polygon);
	window_set_mouse_passthrough(polygons, TypedArray<Rect2>(), p_windows);
}

void DipslayServer::_bind_compatibility_methods() {
	ClassDB::bind_compatibility_method(D_METHOD("window_set_mouse_passthrough", "region", "window_id"), &DipslayServer::_window_set_mouse_passthrough_comat_bind_88558, DEFVAL(MAIN_WINDOW_ID));
}

#endif // DISABLE_DEPRECATED

Add #include "display_servrer.compat.inc" to the display_server.cpp
Update /misc/extension_api_validation/4.2-stable.expected, run ./misc/scripts/validate_extension_api.sh godot_executable to get list of error message.

Check git blame for the /misc/extension_api_validation/4.2-stable.expected for the recent changes, there are a lot of merged PRs adding compat. methods to use as example.

I've reviewed the Wayland part only for now, thanks a lot for working on this :D
Regarding the WaylandThread API, I'd propose a plain and simple WaylandThread::window_set_input_rects(DisplayServer::WindowID p_window_id, Vector<Rect2i> p_rects). It would be basically a dumbed down copy of the update method, which just blindly sets/clears the thing depending on what's in the list. The DS would then call it depending on the flag result wherever it needs.
Following the above logic, the DS keeps track of the rects and the flags, while the WT (WaylandThread) does the Wayland stuff ;)
I hope that helps! Don't hesitate to ask further explanations, there's a lot to unwrap.

Thanks for the review and explanation! Yes that helps a lot. If the WaylandThread shouldn't keep track of anything is it fine to let a utility method _update_window_mouse_passthrough stay? It would look something like this:
void DisplayServerWayland::_update_window_mouse_passthrough(WindowID p_window) {
	if (main_window.flags & WINDOW_FLAG_MOUSE_PASSTHROUGH_BIT) {
		wayland_thread.set_mouse_passthrough(p_window, true);
	} else if (main_window.passthrough_rectangles.is_empty()) {
		wayland_thread.set_mouse_passthrough(p_window, false);
	} else {
		wayland_thread.set_input_region(p_window, main_window.passthrough_rectangles);
	}
}

this would handle all godot stuff in the DS and keep all the wayland stuff in the WaylandThread.
This is needed since as I explained somewhere above you always need to take the window passthrough flag in consideration, just because the passthrough_rects update doesn't mean the input region updates and e.g. when the passthrough flag gets disabled and there are passthrough_rects you do need to set the input region again.

I'm a casual game dev and a LOT of this talk is just going right over my head. Think you could answer a few questions, whoever is able/working on it?
Firstly, is this change expected to go through? If so, any idea when?
Second, is this change completed? (aka can I try to compile Godot with this change right now?)
Third, would this only allow me to add in rectangle objects to the passthrough function? Or any polygons, like how it is currently (but more than just one)?
For context: The game I'm trying to make is essentially a desktop pet that includes various minigames. Currently, the passthrough function works perfectly. That is, assuming I only have one object on screen that needs to register mouse clicks. Two objects can also work, if you manipulate the list of points and add the two polygon arrays together. Past that it's impossible. I've tried using multiple windows, one for each object, but it turns out the DisplayServer controls all windows. In case it matters, I'm developing for Windows.

@TheMagmaPsychic

I'm a casual game dev and a LOT of this talk is just going right over my head. Think you could answer a few questions, whoever is able/working on it?

I was working on it and will continue at some point. I kinda stopped the project that needed this since I found a finished program outside of Godot that did 90% of what I wanted (just an integrated Popup chat for AI).

Firstly, is this change expected to go through? If so, any idea when?

Didn't see anyone actively complain against the idea behind it so probably. I planned to target Godot 4.4. I thought 4.3 would hit alpha earlier so I might clean this up for 4.3 after all, but likely too late now. I can't control when it is merged and review might take a bit considering this affects all platforms with individual changes.

Second, is this change completed? (aka can I try to compile Godot with this change right now?)

Comes down to what you need. The multiple Rectangle thing should still work. I never did the multiple polygon thing, shouldn't be too hard. I have some time next week so maybe recheck then if anything changed.

Third, would this only allow me to add in rectangle objects to the passthrough function? Or any polygons, like how it is currently (but more than just one)?

Refer to last answer. And yes the idea is to just simply be able to pass an Array / List of rectangles and later another list of polygons as well to construct an input region.

For context: The game I'm trying to make is essentially a desktop pet that includes various minigames. Currently, the passthrough function works perfectly. That is, assuming I only have one object on screen that needs to register mouse clicks. Two objects can also work, if you manipulate the list of points and add the two polygon arrays together. Past that it's impossible. I've tried using multiple windows, one for each object, but it turns out the DisplayServer controls all windows. In case it matters, I'm developing for Windows.

I also used this for a desktop pet so you can assume this works :) or at least it should. I didn't test that for Windows.  Btw I had issues with passthrough and black rectangles (in borderless mode I think this was related #88852), but I remember that being even without this PR so if you can use a single passthrough region without that issue, multiple rectangles should also work.
Also imo not worth it to compile the engine for this if you are just a casual user. E.g. Window Kill was made with godot and I think you should be able to avoid mouse passthrough altogether by just using multiple borderless windows. You say you already tried that, but I think you meant multiple windows with passthrough. Just do multiple windows without passthrough, not as performant as mouse passthrough but should have the same effect.

Oh yeah, I've seen Window Kill before. Really neat idea.
I'm specifically looking for non-rectangle polygons, so multiple windows like that wouldn't quite work. All windows use the same displayserver, so you can't make one window per game object like that. Anything outside of the clickable area isn't even drawn in Windows, so you can't dynamically turn it on and off depending on where the mouse is.
I'll be looking at this more in the future. Eager to utilize it!


feat: improved IBM datapower parser

:tada: This PR is included in version 2.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Russian characters in names are not supported

/var/log/packages/FLACCue.log:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 498, in _wrapper
    return func(*args, **kwargs) or 0
  File<EMAIL_ADDRESS>line 708, in readdir
    if filler(buf, name.encode(self.encoding), st, offset) != 0:
UnicodeEncodeError: 'utf-8' codec can't encode character '\udcd0' in position 0: surrogates not allowed

https://github.com/acenko/FLACCue/blob/master/synology_package/FLACCue/fuse.py#L708

@acenko I've created PR with fix


Provision to create a Dev Drive does not appear in Settings

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.22621.1702
Other software
No response
Steps to reproduce the bug

Navigate to the Introducing Dev Home page
Click on Create Dev Drive button under the Create a Dev Drive card group
This should redirect you to the Disks and Volumes page in Settings
The supposed to be Create Dev Drive feature is absent.

Expected result
I should have got a screen that contains the provision like the one in the image below

Actual result
On my PC, the feature was not available

Included System Information
OS : Windows 11 Home Single Language
Version: 10.0.22621 Build 22621
Processor: AMD Ryzen 5 4600H with Radeon Graphics, 3001 Mhz, 6 Core(s), 12 Logical Processor(s)
Included Extensions Information
Dev Home GitHub extension (came pre-installed with application)

@jayanzth you need to be in the Dev channel of the Windows Inisder Program to see this option. Once there make sure you have build 23466.1001 or newer and the option will appear.
For more information check the prerequisites for Dev Drive.

The issue has been resolved. Dev channel of the Windows Insider Program is a requirement for this option to be enabled. Thanks to @Spatacoli for helping with this issue!

I'm on the Dev channel and my current build is 23506.1000 ni_prerelease and I still have the same problem. I'm also using Windows Pro if that helps.


Clean up docker resources

(partially) resolves https://github.com/fishtown-analytics/dbt-release/issues/3

Description

rm older dockerfiles
add dockerfile from dbt-releases
rename the development dockerfile to Dockerfile.dev to avoid confusion

Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Will merge into dev/margaret-mead after PR merge.

Will merge into dev/margaret-mead after PR merge.

Will merge into dev/margaret-mead after PR merge.

We'll need to merge into / rebase dev/margaret-mead against dev/kiyoshi-kuromiya after final v0.19.0 release, and again with dev/0.19.1 once we have a release candidate there. Lots of git fun ahead of us :)

Will merge into dev/margaret-mead after PR merge.

We'll need to merge into / rebase dev/margaret-mead against dev/kiyoshi-kuromiya after final v0.19.0 release, and again with dev/0.19.1 once we have a release candidate there. Lots of git fun ahead of us :)


PMDK:x64-windows failed

Error: Building package pmdk:x64-windows failed with: BUILD_FAILED
Package: pmdk:x64-windows
Vcpkg version: 2019.06.26-nohash

Hi @weishuo2, can you provide the information about your environment? And attach your build log.
Thanks!

------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年7月17日(星期三) 上午10:49
收件人<EMAIL_ADDRESS>抄送: "华中科技大学魏硕"2411602273<EMAIL_ADDRESS>主题: Re: [microsoft/vcpkg] PMDK:x64-windows failed (#7274)
Hi @weishuo2, can you provide the information about your environment? And attach your build log.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

windows10,vs2019
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年7月17日(星期三) 上午10:49
收件人<EMAIL_ADDRESS>抄送: "华中科技大学魏硕"2411602273<EMAIL_ADDRESS>主题: Re: [microsoft/vcpkg] PMDK:x64-windows failed (#7274)
Hi @weishuo2, can you provide the information about your environment? And attach your build log.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I can't reproduce this issue locally. I installed it successfully with Visual Studio 2019 and VCPKG latest source. Do you run command git pull before installing this port.
.\vcpkg.exe install pmdk:x64-windows
The following packages will be built and installed:
pmdk[core]:x64-windows
Starting package 1/1: pmdk:x64-windows
Building package pmdk[core]:x64-windows...
-- Downloading https://github.com/pmem/pmdk/archive/1.6.tar.gz...
......
Building package pmdk[core]:x64-windows... done
Installing package pmdk[core]:x64-windows...
Installing package pmdk[core]:x64-windows... done
Elapsed time for package pmdk:x64-windows: 12.7 min
Total elapsed time: 12.7 min

Thanks for posting this issue. Please open a new issue if this is still a problem for you.

Error: Building package pmdk:x64-windows failed with: BUILD_FAILED                                                                  Please ensure you're using the latest portfiles with .\vcpkg update, then                                                         submit an issue at https://github.com/Microsoft/vcpkg/issues including:                                                               Package: pmdk:x64-windows                                                                                Vcpkg version: 2020.06.15-nohash

Error: Building package pmdk:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then  submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: pmdk:x64-windows
Vcpkg version: 2020.06.15-nohash


Crashes my minecraft

I don't know why but everytime i load a shader pack it crashes my Minecraft I am using a galaxy j5 2016 android 6.0 it will just be stuck at loading screen a freeze the game

Crashes for me too while loading with Android 9.0 and a Kirin 980.

Works for me on my Pixel 2 XL running Pie.

Galaxy J5 2016 has a GPU Adreno 306, and Kirin 980 has Mali-G76MP10.
Sadly I can't debug those crash problems atm due to MCPE-41076. Closing the issue as a dupe of #50.


Ingressgw fails to become ready if k8s service has tls config without certificate

Bug description
Istio ingress gateway fails with below error if there is K8s ingress with TLS block, but no TLS secret configured.
Error:
2020-06-17T21:23:31.041568Z	warning	envoy config	[external/envoy/source/common/config/grpc_subscription_impl.cc:101] gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) <IP_ADDRESS>_443: Proto constraint validation failed (DownstreamTlsContextValidationError.CommonTlsContext: ["embedded message failed validation"] | caused by CommonTlsContextValidationError.TlsCertificates[i]: ["embedded message failed validation"] | caused by TlsCertificateValidationError.CertificateChain: ["embedded message failed validation"] | caused by DataSourceValidationError.Filename: ["value length must be at least " '\x01' " bytes"]): common_tls_context {
  tls_certificates {
    certificate_chain {
      filename: ""
    }
    private_key {
      filename: ""
    }
  }
  alpn_protocols: "h2"
  alpn_protocols: "http/1.1"
}
require_client_certificate {
}

[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Istio Ingress should not completely fail if one of the k8s ingresses has no secret in TLS block
Steps to reproduce the bug

Install Istio 1.6.2

helm upgrade --install istio-base ./downloads/istio-1.6.2/manifests/charts/base --version ~x.x.x --kube-context lab --namespace kube-system

helm upgrade --install istio-16 ./downloads/istio-1.6.2/manifests/charts/istio-control/istio-discovery --version ~x.x.x --kube-context lab --namespace istio-system -f downloads/istio-1.6.2/manifests/charts/global.yaml -f values/istio-16/default-config.yaml

Create istio ingress

helm upgrade --install istio-ing  ./downloads/istio-1.6.2/manifests/charts/gateways/istio-ingress --version ~x.x.x --kube-context lab --namespace istio-system   -f downloads/istio-1.6.2/manifests/charts/global.yaml

Create Gateway resource
deploy app with ingress that has TLS:

spec:
  rules:
  - host: sampleapp.mydomain.com
    http:
      paths:
      - backend:
          serviceName: sample-service
          servicePort: 80
        path: /
  - host: sampleapp.com
    http:
      paths:
      - backend:
          serviceName: sample-service
          servicePort: 80
        path: /
  - host: sampleapp.mydomain.com
    http:
      paths:
      - backend:
          serviceName: sample-app-sox-sample-ap-service
          servicePort: 80
        path: /
  tls:
  - hosts:
    - sampleapp.mydomain.com
status:
  loadBalancer: {}

Observer the error in the pod log:

2020-06-17T21:23:31.041568Z	warning	envoy config	[external/envoy/source/common/config/grpc_subscription_impl.cc:101] gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) <IP_ADDRESS>_443: Proto constraint validation failed (DownstreamTlsContextValidationError.CommonTlsContext: ["embedded message failed validation"] | caused by CommonTlsContextValidationError.TlsCertificates[i]: ["embedded message failed validation"] | caused by TlsCertificateValidationError.CertificateChain: ["embedded message failed validation"] | caused by DataSourceValidationError.Filename: ["value length must be at least " '\x01' " bytes"]): common_tls_context {
  tls_certificates {
    certificate_chain {
      filename: ""
    }
    private_key {
      filename: ""
    }
  }
  alpn_protocols: "h2"
  alpn_protocols: "http/1.1"
}
require_client_certificate {
}

if pod is killed and a new pod started, it will never be in ready state and log will show these errors:

2020-06-17T21:58:20.681128Z	info	Starting gateway SDS
2020-06-17T21:58:20.702537Z	warn	secretfetcher	failed load server cert/key pair from secret sh.helm.release.v1.k8stgt-istio-int.v1: server cert or private key is empty
2020-06-17T21:58:20.786947Z	info	sds	SDS gRPC server for workload UDS starts, listening on "./etc/istio/proxy/SDS"

2020-06-17T21:58:20.787034Z	info	sds	Start SDS grpc server
2020-06-17T21:58:20.787334Z	info	sds	SDS gRPC server for ingress gateway controller starts, listening on "./var/run/ingress_gateway/sds"

2020-06-17T21:58:20.787423Z	info	sds	Start SDS grpc server for ingress gateway proxy
2020-06-17T21:58:20.787453Z	info	Starting proxy agent
2020-06-17T21:58:20.787481Z	info	Opening status port 15020

2020-06-17T21:58:20.787521Z	info	Received new config, creating new Envoy epoch 0
2020-06-17T21:58:20.787729Z	info	Epoch 0 starting
2020-06-17T21:58:20.796984Z	info	Envoy command: [-c etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster k8stgt-ingressgw-int --service-node router~<IP_ADDRESS>~k8stgt-ingressgw-int-6b59fc799c-89vbw.k8stgt-istio-int~k8stgt-istio-int.svc.cluster.local --max-obj-name-len 189 --local-address-ip-version v4 --log-format %Y-%m-%dT%T.%fZ	%l	envoy %n	%v -l warning --component-log-level misc:error]
2020-06-17T21:58:20.919237Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamAggregatedResources gRPC config stream closed: 14, no healthy upstream
2020-06-17T21:58:20.919327Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:54] Unable to establish new stream
2020-06-17T21:58:20.935500Z	info	sds	SDS: starting legacy v2 discovery stream
2020-06-17T21:58:20.936457Z	info	sds	resource:default new connection
2020-06-17T21:58:20.936671Z	info	sds	Skipping waiting for ingress gateway secret
2020-06-17T21:58:21.341359Z	info	cache	Root cert has changed, start rotating root cert for SDS clients
2020-06-17T21:58:21.341433Z	info	cache	GenerateSecret default
2020-06-17T21:58:21.341672Z	info	sds	resource:default pushed key/cert pair to proxy
2020-06-17T21:58:21.929737Z	info	sds	SDS: starting legacy v2 discovery stream
2020-06-17T21:58:21.929805Z	info	sds	SDS: starting legacy v2 discovery stream
2020-06-17T21:58:21.930265Z	info	sds	resource:ROOTCA new connection
2020-06-17T21:58:21.930410Z	info	sds	resource:default new connection
2020-06-17T21:58:21.930455Z	info	sds	Skipping waiting for ingress gateway secret
2020-06-17T21:58:21.930519Z	info	cache	Loaded root cert from certificate ROOTCA
2020-06-17T21:58:21.930595Z	info	sds	Skipping waiting for ingress gateway secret
2020-06-17T21:58:21.930758Z	info	sds	resource:ROOTCA pushed root cert to proxy
2020-06-17T21:58:22.353293Z	info	cache	GenerateSecret default
2020-06-17T21:58:22.353436Z	info	sds	resource:default pushed key/cert pair to proxy
2020-06-17T21:58:22.391323Z	warning	envoy config	[external/envoy/source/common/config/grpc_subscription_impl.cc:101] gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) <IP_ADDRESS>_443: Proto constraint validation failed (DownstreamTlsContextValidationError.CommonTlsContext: ["embedded message failed validation"] | caused by CommonTlsContextValidationError.TlsCertificates[i]: ["embedded message failed validation"] | caused by TlsCertificateValidationError.CertificateChain: ["embedded message failed validation"] | caused by DataSourceValidationError.Filename: ["value length must be at least " '\x01' " bytes"]): common_tls_context {
  tls_certificates {
    certificate_chain {
      filename: ""
    }
    private_key {
      filename: ""
    }
  }
  alpn_protocols: "h2"
  alpn_protocols: "http/1.1"
}
require_client_certificate {
}

2020-06-17T21:58:23.554366Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2020-06-17T21:58:25.551414Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected

istioctl proxy-status
NAME                                                       CDS        LDS                            EDS        RDS        PILOT                       VERSION
myingress     SYNCED     STALE (Never Acknowledged)     SYNCED     SYNCED     istiod-689668575d-zxxsw     1.7-alpha.06ea60ac3da305b43480cae75f215724adc3e820

If I delete tls section from the K8s ingress spec, istio ingress pod starts and log shows:

2020-06-17T22:09:01.551539Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 2 successful, 0 rejected; lds updates: 0 successful, 2 rejected
2020-06-17T22:09:03.552393Z	info	Envoy proxy is ready

istioctl proxy-status
NAME                                                       CDS        LDS        EDS        RDS        PILOT                       VERSION
myingress     SYNCED     SYNCED     SYNCED     SYNCED     istiod-689668575d-zxxsw     1.7-alpha.06ea60ac3da305b43480cae75f215724adc3e820

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istioctl version --remote
client version: 1.6.2
control plane version: 1.7-alpha.06ea60ac3da305b43480cae75f215724adc3e820
data plane version: 1.7-alpha.06ea60ac3da305b43480cae75f215724adc3e820 (1 proxies)

kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.11", GitCommit:"d94a81c724ea8e1ccc9002d89b7fe81d58f89ede", GitTreeState:"clean", BuildDate:"2020-03-12T21:08:59Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.11", GitCommit:"d94a81c724ea8e1ccc9002d89b7fe81d58f89ede", GitTreeState:"clean", BuildDate:"2020-03-12T21:00:06Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"linux/amd64"}

helm version
version.BuildInfo{Version:"v3.2.3", GitCommit:"8f832046e258e2cb800894579b1b3b50c2d83492", GitTreeState:"clean", GoVersion:"go1.13.12"}

How was Istio installed?
Istio was installed with helm3
Environment where bug was observed (cloud vendor, OS, etc)

BYO k8s on baremetal and GCE

Interesting, what is the expected behavior when certificate is not provided? I am surprised that passes k8s validation

there is no validation in k8s for this - all other ingress controllers just ignore this configuration

Ok thanks, so we should ignore it to - I wasn't sure if this was somehow supposed to do something. Thanks!

@howardjohn I'm trying to use istio as k8s default ingress and running into a lot of issues, seems like redirects are not working correctly. Should I open another issue?

@darkstarmv that would be great

This is expected behavior for now. A better behavior is the problematic gateway config gets an error when applied (the configuration validation hook rejects it). I see this is necessary since Ingress gateway is shared across different namespaces. We don't want a tenant's config error to cause ingress gateway to be down.
@JimmyCYJ @costinm WDYT?

We cannot reject it, we don't validate Ingress objects

I also disagree with it is "intended" - sending envoy invalid config is wrong in every case


PDFView cannot display electronic signature

Please help!The PDFView cannot display electronic signature.

Because it does not display signatures

+1


change: [M3-8439] - Tag form events in Linode Create v2

Description 📝
This PR tags the UI elements from Linode Create v2 that were not shared with the v1 flow (which was tagged in #10722).
Changes  🔄
See #10722 for an overview how form events are handled.
Target release date 🗓
9/3
Preview 📷

Screenshots of Main Create Flow Events

Component
Analytics Event

Current:  Two step:

  VPC is selected:  VPC is cleared:

  Firewall is selected:   Firewall is cleared:

click 'Create Linode' without filling in required fields

Screenshots of PG Branch Flow Events

Component
Analytics Event

Screenshots of Firewall Branch Flow Events

Component
Analytics Event

Screenshots of VPC Branch Flow Events

Component
Analytics Event

How to test 🧪
Prerequisites
(How to setup test environment)

You must have the Adobe Analytics environment set in your .env.
Check out this PR, yarn dev, and in the browser console, type _satellite.setDebug(true).

Verification steps
(How to verify changes)

Below are the two color-coded keys for what events should be tagged in the flow. Please see the Preview section for the events and confirm they are firing as expected.

Main Flow
Branching Flows (Drawers)

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[x] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[x] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

A couple things are not firing on my end

region selection
plan selection

Am i missing something?

@abailly-akamai Thanks for verifying!
For Region selection, you should be seeing the logged formStart event, even if the second message says something like "criteria not met". The first message is sufficient for confirming the event in CM; the second message has to do with whether this url has been configured for the formStart in the analytics backend. (I think they turned formStart events off on localhost to save some event calls when we went to prod last week.)

For Plan selection, you should not be seeing any form events, but you should be seeing a formInput event upon clicking the "Choosing a Plan" docs link. (There are actually two analytics events here; a custom event and a form event. Form event is in orange below.)

I'm not seeing Firewall change/clear events 🤔

I'm not seeing Firewall change/clear events 🤔

@hana-linode But you were seeing other events and just not the change/clear? That's odd. I just verified that I can see all the events in the Firewall panel, and this looks consistent across create flow tabs.

@mjac0bs Yes, I'm seeing all other events
https://github.com/user-attachments/assets/21015bd0-1502-460f-ab89-151530b442d9


Character cannot be clerical and magical at the same time

Describe the bug
According to TDE rules, a character can have a magical and a karmal tradition. While the combination is rare, it is possible.
To Reproduce
Steps to reproduce the behavior:

Create a character
Add a spell, ritual or cantrip
Add a liturgy, ceremony or blessing
Character sheet displays "Magie" tab but no "Religion" tab

Expected behavior
Character sheet displays "Magie" tab and "Religion" tab.
Additional context
The main culprit is in line 446-447 of actor-dsa5.js:
//CHAR cannot be clerical and magical at the same time
magic.hasPrayers = magic.hasPrayers && !magic.hasSpells
Apart from that, the character sheet will probably have to be changed to allow for the display of both tabs.

Will be part of the next patch

Should be ok in the current patch


Prevent batching of child reducers?

Hi there,
I have two unrelated async tasks I want to run after a location change. One is quick (geolocation) while the other is slow (loading the Google Maps API). I've noticed that combineReducers from redux-loop batches all child effects. This means that even though geolocation is finished, its action won't dispatch until the Maps API loads. Is there a way to prevent batching at the top level or is there a more idiomatic solution to this problem?

For now I'm afraid there's no way around this other than to avoid using combineReducers and wire things together manually. I'm going to be looking into this for the next version of the library -- you are not alone in this complaint!

This enhancement might allow for something like that

@bdwain thank you for the reminder!! I'll put that on the list of 3.0 things (#79)

I worked around this by "scheduling" actions with Effects.constant and having the child reducers return the actual Effects.promise. Everything runs in parallel without being batched AFAICT. That said, an Effects.parallel without batching would be an awesome thing for 3.0 😀

And I guess making the combineReducers behavior configurable as well...
Also, this library is the bomb, and I'm hoping to contribute soon in the future 👍

@tptee i'm hoping to get everything to a place where we can have much more active community involvement very soon. i'm looking forward to your contributions!

I'm thinking of removing combineReducers altogether so this may not end up being an issue going forward


The Provided Example gives an error: BeginPolling Only Takes 1 Argument

title sums up the error
CS1501	No overload for method 'BeginPolling' takes 2 arguments

Classic example of updating the API and not updating the docs. You would now subscribe to one or more events on the DualSense instance, as shown here: https://github.com/BadMagic100/DualSenseAPI/blob/a121e53ed806ec8ecacd92741ff048c3ce7e585b/TestDriver/Program.cs#L116


feat: add CorporateActions TxGroup

:tada: This PR is included in version 5.0.0-beta.7 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0-alpha.9 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Regression: properties erroneously reported as possibly null

With the following contrived example.vue file:
<script setup lang="ts">
type Bar = {
	id: string;
} | null;

type Example = {
	foo: {
		bar: Bar;
	};
	doSomething(id: string): void;
};
const example: Example = {
	foo: {
		bar: {
			id: '123',
		},
	},
	doSomething(id: string) {
		console.log(id);
	},
};
</script>
<template>
	<button
		v-if="example.foo.bar"
		type="button"
		v-on:click="example.doSomething(example.foo.bar.id)"
	>
		{{ example.foo.bar.id }}
	</button>
</template>

<EMAIL_ADDRESS>reports no errors.
<EMAIL_ADDRESS>reports: '__VLS_ctx.example.foo.bar' is possibly 'null'. [Ln 27, Col 35]
Given that this is wrapped in a v-if="example.foo.bar", I wouldn't expect this to ever be null.

Specifically, it seems to be due to the bump of volar. Here's a minimal reproduction:

See branch main for working in<EMAIL_ADDRESS>and older volar
See branch 2.1.0 for erroring in<EMAIL_ADDRESS>and newer volar

https://github.com/Cherry/volar-erroneous-null-repro
Run npm run test in each branch to see the issue.

I have the same issue. v-if doesn't narrow the type for events anymore in 2.0.10.


get local system information from server

As of now this code only fetch the system info in which the script runs locally. I just want to get the user's system info who runs the script using a live URL.

@harishksoft can you please describe your use case a little bit more detailed? I am not sure that I really understood your feature request ;-)

@harishksoft can you please describe your use case a little bit more detailed? I am not sure that I really understood your feature request ;-)

I want to build an app, hosted in the live server, which is for showing the user's system information in a browser like name, serial number, ports,battery status, hdd health report etc.. when I visited a URL. As of now when I run the code in the server, it takes the information of the live server instead of my local system. but when run in locally it takes my local system information.

@harishksoft still not sure, what you want to accomplish.
First of all, there is no possibility to get detailed system information from a script running within a browser.
So you will only get detailed system information when you run a script (in our case a node script) locally on a specific machine. So you can grab all local system information with the  systeminformation package within a node script on nearly any machine. Then you need to send this data to your server which then collects all information and displays it. This can be achieved by "pushing" it to the server or by "pulling" it from the client (then the client must be "reachable" from your server)
Is this what you want to achieve?

@sebhildebrandt i'm just building a web app through which user can check his system information. I don't know to explain more than this ;)
"First of all, there is no possibility to get detailed system information from a script running within a browser." - all clear now. There is no chance of building an app as I planned.
In order to run the script user first need to setup the node environment in his local, so peoples without knowlege in programming can't do that.

Yes this is correct. Due to security reasons, a browser cannot determine system information (except those from user agent sent in the header). And this is absolutely fine ;-)

@sebhildebrandt ia there any option to get keyboard and monitor details

@harishksoft As far as I now, this is what you can determine:

device type (mobile, tablet, smart-tv, desktop, watch, ...)
OS and OS version (e.g. Windows 10)
CPU architecture (arm, amd64, ...)
browser
locale

by parsing the user agent ... I do not see any possibility to get keyboard details ...


Change Items.Add to Items.Append

ListView.Items is a ItemCollection.

@jwmsft: The PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks!

I opened a separate issue on ItemCollection class page to update/explain the different language projections.


try-state: include some pallet identifier in error

Description
try_state error handling more or less seems to follow this pattern:
ensure!(
    invariant_holds,
    "some explanation of the invariant not holding"
)

If !invariant_holds, the try_state call will return a DispatchError::Other(message) to Executive, who calls it like this:
		// run the try-state checks of all pallets, ensuring they don't alter any state.
		let _guard = frame_support::StorageNoopGuard::default();
		<AllPalletsWithSystem as frame_support::traits::TryState<
			BlockNumberFor<System>,
		>>::try_state(*header.number(), select)
		.map_err(|e| {
			frame_support::log::error!(target: LOG_TARGET, "failure: {:?}", e);
			e
		})?;
		drop(_guard);

The issue here is that Executive does not log which pallet the error emitted from, which is vital information when there are multiple instances of the same pallet in the runtime.
I encountered this issue when investigating a collective pallet error in polkadot which has two instances. I needed to add additional logging to try_state and replace the ensure! with a conditional to learn which instance the error is coming from:
        fn do_try_state() -> Result<(), TryRuntimeError> {
+               use frame_support::traits::PalletInfo;
+               let pallet_error_log = "try-state invariant failed for pallet ".to_owned() +
+                       T::PalletInfo::name::<Pallet<T, I>>().unwrap_or("unknown_pallet") +
+                       ".";
+
                Self::proposals()
                        .into_iter()
                        .try_for_each(|proposal| -> Result<(), TryRuntimeError> {
@@ -1041,10 +1046,10 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
                        "The member count is greater than `MaxMembers`."
                );

-               ensure!(
-                       Self::members().windows(2).all(|members| members[0] <= members[1]),
-                       "The members are not sorted by value."
-               );
+               if !Self::members().windows(2).all(|members| members[0] <= members[1]) {
+                       log::error!("{}", &pallet_error_log);
+                       return Err("The members are not sorted by value.".into())
+               };

Solutions?
Replace ensure with conditionals and additional logging
The simplest way to resolve this is likely to simply replace all the ensure usage with conditionals, and an extra log containing the pallet name (optionally also index) like I did when investigating the collectives pallet issue.
This solution kind of sucks, making the code verbose.
Change try_state to return a new error type
I may be wrong but I'm not sure if it even makes sense for try_state to return a DispatchError, because it only ever checks storage and never actually dispatches anything?
Something very roughly like
// If you want P to be something that can be converted into a String or has some relation to String
#[cfg(feature = "try-runtime")]
#[derive(Eq, Clone, Copy, Encode, Debug, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct TryStateError<P: PalletInfo>(pub P, pub &'static str);

This way, Executive will have access to P as well as the error message and be able to log which pallet it came from.

@kianenigma I think you are likely best qualified to provide valuable insights about this :)


⚠ Jenkins Plugins Artifactory has degraded performance

In 45963af, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1389 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 8e0e6d9 after 2 hours, 42 minutes.


Replace Erubis with Erubi

The erubis gem (https://rubygems.org/gems/erubis/versions/2.7.0) was last updated April 2011.  It also has at least one reported security vulnerability: https://www.immun.io/blog/will-it-pwn-cve-2014-0130.  This PR replaces erubis with the more modern erubi (https://github.com/jeremyevans/erubi) for Flipper UI templates.

Closing in favor of #407.
Thanks for starting this!


Investigate google analytics

As a team member, I want to know the google analytics to know visitor traffic to the cam API portal
Check how this is impacted by a single page web app

According from Kevin H., GA are automatically included on all Drupal pages.  No need to add custom code.

Must be on VPN to follow Instruction for setting up GA account

Set up Google account using EPA email address

Fill out the form to be added to the EPA GA group


Update README.md for 86/96

86 status changed to closed
96 status changed to approved

merging this on behalf of the team.


Add info about stable branch to the readme

Coverage remained the same at 98.947% when pulling b1e82fcca241fd464855c8ba0dbd40474fd202ee on web2style:master into 4487d298980ed002a7423c46bebe880ad4de81a2 on mxstbr:master.

Coverage remained the same at 98.947% when pulling 60af2143556603e210b9cff990d81cd6e0d082f8 on web2style:master into 88fd712f2a54558c24cd097ef90e17f251db40c6 on mxstbr:master.

Thanks for this! I took my own wording and added it to the README when I merged v3.3, so I won't merge this specific PR, but thank you so much for taking the time to add it!


Experiment form population

Describe the bug
Application errors with TypeError: Cannot add property spotDescriptor, object is not extensible when user tries to edit experiment draft object
To Reproduce
Steps to reproduce the behaviour:

Save an experiment form as a draft
Try to edit newly saved draft

Expected behavior
Form should be populated without errors.

This seems to be related in React Hook Form useFieldArray method in WizardJSONSchemaParser FormArray method.
Form renders without errors if useFieldArray is disabled.

This also happens while trying to edit analysis form if eg. Analysis type and it's children has been filled. Error message: TypeError: Cannot assign to read only property 'referenceAlignment' of object '#<Object>'
This also point to useFieldArray

Close again as it's fixed with PR https://github.com/CSCfi/metadata-submitter-frontend/pull/344


Reading large files

NPOI Version Used
2.7.0
File Type

[x] XLSX
[ ] XLS
[ ] DOCX
[ ] XLSM
[ ] OTHER

Use Case
Reading Excelfiles > 200 Kilobyte
Reading Excelsheets > 80 Kilobyte
Description
I have a problem with reading "large" Excel-Files / Sheets
is or will there be a feature that "allows" reading those files?

What's the issue you encountered? Out of memory? Or slowness?

@tonyqus
I assume that the issue i ran into was slowness but I just found the problem.
There were some sheets with loads of emty cells in my workbook, after removing all of them the filesize went from 980 kb to ~500 kb and now everything just works fine with XSSFWorkbook, thanks for the fast answers and sorry for "wasting" your time.


Bounded Capacity

What's the recommended way to introduce DataflowBlockOptions to this example? Mainly bounded capacity.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe912a6b-f1de-948b-c1d3-bc873aa413e4
Version Independent ID: 47c42c32-2b0d-c708-deb1-f79ff6e96988
Content: Walkthrough: Creating a Custom Dataflow Block Type
Content Source: docs/standard/parallel-programming/walkthrough-creating-a-custom-dataflow-block-type.md
Product: dotnet
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

I think the best approach is to split the incoming BoundedCapacity in two (say, 50-50) and use those values to set BoundedCapacity of the two component blocks. That way, the resulting block will have capacity that is the sum of capacities of its components.

@turowicz, I'm closing this issue as it looks like it's been resolved. Please reopen if that is not the case. Thanks!


Consecutive publishing to (Test)PyPI fails

When using two consecutive publish actions like this
- name: Release to TestPyPI
  uses<EMAIL_ADDRESS>  with:
    python-version: ${{ env.python-version }}
    working-directory: ${{ env.BACKEND_DIR }}
    pypi-token: ${{ secrets.test-pypi-token }}
    publish-to-test: "true"

- name: Release to PyPI
  uses<EMAIL_ADDRESS>  with:
    python-version: ${{ env.python-version }}
    working-directory: ${{ env.BACKEND_DIR }}
    pypi-token: ${{ secrets.pypi-token }}
    publish-to-test: "false"

https://github.com/bakdata/streams-explorer/blob/079ab9e23f057dc5e01d91c1aba331c73954c922/.github/workflows/publish.yml
the second publish action fails with the following error:
Cache not found for input keys: venv-Linux-3-9-12-final-0-

Run poetry install --no-dev --no-interaction
Installing dependencies from lock file
No dependencies to install or update

Installing the current project: streams-explorer (1.6.1)
Run # first build the project then publish to PyPI

  RuntimeError

  Aborted

  at /opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/clikit/ui/components/question.py:263 in _read_from_input
      259│         """
      260│         ret = io.read_line(4096)
      261│
      262│         if not ret:
    → 263│             raise RuntimeError("Aborted")
      264│
      265│         return decode(ret.strip())
      266│
      267│     def _has_stty_available(self):

There are 2 files ready for publishing. Build anyway? (yes/no) [no]
Process completed with exit code 1.

should be fixed by recent restructuring of the Poetry publish action


Remove ExampleDS

Is there a clean way to remove ExampleDS from the default JBoss install?  I don't see ensure=> absent as being viable, but I'll bet there's another way...

Other than convince RedHat not to include an example datasource in all configuration files? :smile:
If you're hosting your own JBoss/Wildfly packages you could remove this configuration from your XMLs using augeas, XSLT or something like that.
If you're using roles/profiles, include this resource with ensure absent in your profile. I'd probably use this option, what's wrong with ensure => absent?

I tried:
  wildfly::datasources::datasource { 'ExampleDS':
    ensure => absent,
  }

....but it resulted in:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter: 'ensure' on Wildfly::Datasources::Datasource[ExampleDS] at /etc/puppetlabs/code/environments/links/modules/profile/manifests/gwjboss.pp:89 on node gwappdevbc01

You can do:

  wildfly::util::resource { '/subsystem=datasources/data-source=ExampleDS':
    ensure => absent,
  }

I used:
  wildfly::util::resource { '/subsystem=datasources/data-source=ExampleDS':
    ensure => absent,
  }

and got:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Function Call, delete_undef_values(): expected an array or hash, got  type  String  at /etc/puppetlabs/code/environments/links/modules/wildfly/manifests/util/resource.pp:21:18 on node gwappdevbc01

Oh, you need na empty content:
content => {}
It should be the default value in wildfly::util::resource. Fixed in v1.0.0, but forgot to backport.

Ah, awesome.  Thanks so much!


Normal map with unrotated camera will make a quad black

Operating system or device - Godot version: Tested in Godot 2.1.2 and Godot 3. Both display the same issue
Issue description:
Setting a normal map on a quad, with the camera facing straight at it, will show only a black quad. In the editor everything looks fine, but the problem appears when running the game.
Rotating the camera even a tiny bit will solve the issue. Which suggests to me that when something is 0, something breaks :p
Link to minimal example project:
Reported in Q&A with sample project: https://godotengine.org/qa/13060/cannot-normal-mapping-fixedmaterial-screenshots-project

this may have been fixed as i solved a normal map bug recently importing collada.. does it still happen?
i can't get the demo project

Quad node is gone and i can't reproduce this in current master using quad mesh, so closing.


Previous route in stack gets rebuilt on every frame when virtual keyboard appears/disappears

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Create a new project with the provided code sample
Run the project;
Click on red container. You will be navigated to the screen with a form;
Click on the form in order to bring it in focus/click Done on the keyboard to remove focus;
Look inside the console, First screen is being rebuilt on every frame when keyboard appears/disappears.

Seems like using MediaQuery inside the first screen is somehow broken or I'm not using it correctly
Expected results
I expect the following results:
first screen to not rebuild since keyboard is appearing/disappearing on the second screen
Actual results
read above
Code sample
Code sample

First screen

import 'package:flutter/material.dart';

import 'form_screen.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Builder(builder: (context) {
            print('build');
            return GestureDetector(
              onTap: () {
                Navigator.of(context).push(
                  MaterialPageRoute(
                    builder: (context) => const FormScreen(),
                  ),
                );
              },
              child: Container(
                height: MediaQuery.of(context).size.height / 2,
                width: MediaQuery.of(context).size.width / 2,
                color: Colors.red,
              ),
            );
          }),
        ),
      ),
    );
  }
}

Second screen

import 'package:flutter/material.dart';

class FormScreen extends StatelessWidget {
  const FormScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: TextField(),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/54116985/d8dd43e2-9b92-4291-9b10-800fb2a7e243

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.2, on macOS 13.3 22E252 darwin-arm64, locale ru-RU)
    • Flutter version 3.10.2 on channel stable at /Users/gidrokolbaska/Developer/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9cd3d0d9ff (7 days ago), 2023-05-23 20:57:28 -0700
    • Engine revision 90fa3ae28f
    • Dart version 3.0.2
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/gidrokolbaska/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode14.2.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.64.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • 442951FA-0B23-43B4-B975-ADBD0B8D4D4F • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 13.3 22E252
      darwin-arm64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome
      113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for filing this issue. I am able to reproduce this issue on the latest master and stable channels. This seems to be related to using MediaQuery to set the height and width of the Container while keyboard appears and disappears on the next screen as this doesn't occur when MediaQuery isn't used.
  flutter doctor -v
[✓] Flutter (Channel master, 3.11.0-2.0.pre.55, on macOS 13.3 22E252 darwin-arm64, locale en-NG)
    • Flutter version 3.11.0-2.0.pre.55 on channel master at /Users/dammya/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 835b892d7f (3 weeks ago), 2023-05-07 01:30:22 +0530
    • Engine revision 23f730efbf
    • Dart version 3.1.0 (build 3.1.0-83.0.dev)
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/dammya/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.78.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.78.0)
    • VS Code at /Users/dammya/.Trash/Visual Studio Code 20.07.05.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile) • emulator-5554                        • android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 14 Pro (mobile)    • DCF2031A-7EA9-42FF-8CD4-D4584F3E7A6D • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)           • macos                                • darwin-arm64   • macOS 13.3 22E252 darwin-arm64
    • Chrome (web)              • chrome                               • web-javascript • Google Chrome 113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[✓] Flutter (Channel stable, 3.10.2, on macOS 13.3 22E252 darwin-arm64, locale
    en-NG)
    • Flutter version 3.10.2 on channel stable at /Users/dammya/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9cd3d0d9ff (5 days ago), 2023-05-23 20:57:28 -0700
    • Engine revision 90fa3ae28f
    • Dart version 3.0.2
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version
    32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/dammya/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.78.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.78.0)
    • VS Code at /Users/dammya/.Trash/Visual Studio Code 20.07.05.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile) • emulator-5554                        •
      android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 14 Pro (mobile)    • DCF2031A-7EA9-42FF-8CD4-D4584F3E7A6D • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)           • macos                                •
      darwin-arm64   • macOS 13.3 22E252 darwin-arm64
    • Chrome (web)              • chrome                               •
      web-javascript • Google Chrome 113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Now imagine how many people are using MediaQuery in their code on latest release without realising that their widgets are being rebuilt :D

StatelessWidget.build

The framework calls this method when this widget is inserted into the tree in a given BuildContext and when the dependencies of this widget change (e.g., an InheritedWidget referenced by this widget changes). This method can potentially be called in every frame and should not have any side effects beyond building a widget.

Since MediaQuery has changed, this is the expected behavior. For instance, if you change the text scale factor, your dependent widgets will rebuild. The same goes for Theme.of.
The build method returns widgets, which are blueprints. The framework is smart enough to determine what has changed, but you can assist it if you are returning the same instance, for instance, by using the const keyword, so build method won't do too many things.

StatelessWidget.build

The framework calls this method when this widget is inserted into the tree in a given BuildContext and when the dependencies of this widget change (e.g., an InheritedWidget referenced by this widget changes). This method can potentially be called in every frame and should not have any side effects beyond building a widget.

Since MediaQuery has changed, this is the expected behavior. For instance, if you change the text scale factor, your dependent widgets will rebuild. The same goes for Theme.of.
The build method returns widgets, which are blueprints. The framework is smart enough to determine what has changed, but you can assist it if you are returning the same instance, for instance, by using the const keyword, so build method won't do too many things.

So you are telling me that behavior displayed in video below is okay?...
https://github.com/flutter/flutter/assets/54116985/363e3bfc-39a9-4e7d-af57-eac289182877

Was it always like this in flutter or it was caused by one of the PRs (this one or that one, specifically)?

#114459 is one of my favorite changes, for instance your first screen won't rebuild if user changes text scalfactor if you write MediaQuery.sizeOf(context) instead of MediaQuery.of(context).size so your build method will rerun only if size changed but not other properties on MediaQueryData
#118004 it just splits MediaQuery
Check out this code, this is not using MediaQuery but Theme and you can observe the first screen also calls build:
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

// do not use global variables like this, this is for demonstration purposes
final globalTheme = ValueNotifier<ThemeData>(ThemeData.light());

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
      animation: globalTheme,
      builder: (context, child) => MaterialApp(
        theme: globalTheme.value,
        home: const FirstScreen(),
      ),
    );
  }
}

class FirstScreen extends StatelessWidget {
  const FirstScreen({super.key});

  @override
  Widget build(BuildContext context) {
    print('build');

    // dependency on Theme
    final theme = Theme.of(context);

    return Scaffold(
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            Navigator.of(context).push<void>(
              MaterialPageRoute<void>(
                builder: (context) => const SecondScreen(),
              ),
            );
          },
          child: const Text('Go to SecondScreen'),
        ),
      ),
    );
  }
}

class SecondScreen extends StatelessWidget {
  const SecondScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            globalTheme.value.brightness == Brightness.light ? globalTheme.value = ThemeData.dark() : ThemeData.light();
          },
          child: const Text('Change Theme'),
        ),
      ),
    );
  }
}

Do not forget widgets are blueprints and Flutter framework (RenderObjectWidget) is smart enough to avoid rerenders if nothing changed in the Widget / blueprint.

Aha, understood, thanks for clarification . Well, I guess in my case I should just go for LayoutBuilder instead of MediaQuery then

Aha, understood, thanks for clarification . Well, I guess in my case I should just go for LayoutBuilder instead of MediaQuery since I don’t want those rebuilds. What do you think?

The MediaQuery always returns the view size, i.e., the screen size. Some widgets like to provide their own, but they usually copy the original one and add some padding, although this is rare. On the other hand, LayoutBuilder returns constraints. For instance, if your LayoutBuilder is deep down in the widget tree, it will have different constraints based on its position in the tree. Sometimes, you may get double.infinity height/width if the constraint is a loose one. Therefore, you should choose the one that best fits your job.
You can still use MediaQuery. However, use MediaQuery.sizeOf(context) instead of MediaQuery.of(context).size, since when the keyboard opens, the size will be unaffected. This means your first screen won't call the build method.

@chunhtai Do you think this is working as intended based on your understanding of Flutter navigation?

I vaguely remember there is already an issue about this. but this is expected. You should consider using MaterialPageRoute(maintainState: false)

Got it, thanks.
Does anyone object to closing this issue as a "won't fix"?  Or is there any docs change we can make or anything to help people avoid this problem?

Got it, thanks.
Does anyone object to closing this issue as a "won't fix"? Or is there any docs change we can make or anything to help people avoid this problem?

Would be cool to have this info somewhere in the docs. Other than that, I don’t mind closing the issue since all my questions have been answered.

I don't like the fact that once a BuildContext becomes dependent on an InheritedWidget, it stays so until the end of its lifecycle.
For instance, when ElevatedButton's onTap creates a dependency on _InheritedTheme. Consequently, build method called again when ThemeData is changed, which doesn't make dependency on _InheritedTheme any more inside build method, it is still considered dependent on _InheritedTheme because onTap made it so.
Example code:
class MyWidget extends StatelessWidget {
  const MyWidget({super.key});

  @override
  Widget build(BuildContext context) {
    return ElevatedButton(
      onPressed: () {
        print(Theme.of(context).primaryColor);
      },
      child: const Text('Press me and BuildContext will be forever dependent on _InheritedTheme even if build method does not use Theme.of().'),
    );
  }
}

This way you cannot use tricks like this:
class MyWidget extends StatelessWidget {
  const MyWidget({super.key});

  @override
  Widget build(BuildContext context) {
    if (!ModalRoute.of<dynamic>(context)!.isCurrent) {
      // when route is not current just return empty Widget
      // Theme.of(context) is not called this time however BuildContext is already dependent on Theme
      return const SizedBox.shrink();
    }

    final theme = Theme.of(context);
    return Text('Dependency on Theme', style: TextStyle(color: theme.primaryColor));
  }
}


Update KUDOS.md

Add quote and link for why I love react_on_rails so much that I made a course based on it.

This change is

@justin808 Hi Justin, I wasn't sure about the text format you're using for image alt tags, so please edit as necessary. Thanks!

Coverage remained the same at 99.329% when pulling 3178ca028dd0ce9df42d050c8dee45f3e003f683 on hrishimittal:patch-1 into 24d3eb2ebca337dbc64d725fbf86bb3111e3680d on shakacode:master.

Thanks @hrishimittal. Good job!


Reference files for DMS data

Hi, thank you very much for this paper and codebase. Sorry if my question is super simple, but I was curious about the DMS_filename entries you referenced in DMS_substitutions.csv. I am trying my best to find the exact filenames you provided in the CSV file, but I can't find most of those DMS data where I would have mutation sequences for the referenced protein. For example, I am trying to look for CAS9_STRP1_Spencer_2017_positive.csv, where I would have thousands of mutated sequences along with the target sequence and possibly LFC after positive selection. When you mentioned those names in the file, where can we reference them to get them?
The reason why I am also asking is that I wanted to run the notebook code, but I need DMS_reference_file like those .csv documents. I know each of these reference papers has their data in supplementary. Still, I checked that the files are not named in the same manner, + I feel like, for example, you are choosing some specific criteria, like positive selection for Cas9, which might not be the only functionality criteria in the reference papers.

I could only find some .csv files from this link, but it seems to be outdated as there are way more DMS substitution files included in the ProteinGym paper.

Hi @ArXiv-sketch -- if I understand your question well, the files that you are looking for are downloadable via the following location (see download instructions from the README page): https://github.com/OATML-Markslab/ProteinGym/blob/main/README.md?plain=1#L113.
Also via our website here: https://proteingym.org/download
Does that address your question?
Best,
Pascal


replace map count/insert w/emplace in instantx.cpp

This feels like an optimization, something about:
if map.count(key)
     return false
else
     insert(pair)
     return true

... just feels icky. Plus, vote.GetMasternodeOutpoint() is only called
once. The previous version might be slightly more readable, however.

You're right, good catch.

Also, maybe apply a similar fix to AcceptLockRequest/RejectLockRequest while at it?

These functions just call insert, so it wouldn't replace as much code as in this case, but is syntactically cleaner though. Is that what you're going for?

@UdjinM6 I fully agree: https://github.com/nmarley/dash/commit/03af44a0825087907bd13bd8f137ebfcb03ac583
;-)
Would like to get that larger PR in after iterator cleanup if possible, so easier to merge w/o conflicts.


Publish main to live on 8/24 @ 10:30 am

Docs Build status updates of commit ff9bfae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Could you please provide Swift initialization documentation?

Thanks for bringing this up. I've added a Swift section: https://github.com/BranchMetrics/react-native-branch-deep-linking/blob/master/docs/setup.md#swift. We'll get this into the docs site as well.

Also note there is a working Swift example in this repo: https://github.com/BranchMetrics/react-native-branch-deep-linking/blob/master/examples/webview_example_native_ios/WebViewExample/AppDelegate.swift. This is a native Swift app with a RN component included, so the structure is slightly different. The RCTRootView is added in the ArticleViewController, not the AppDelegate. But the Branch initialization calls are the same in both cases.


Nomad in CI/CD

Nomad should run in the background while we run tests as part of the GitHub workflows.

Confirmed that Nomad can run in CI/CD: https://github.com/pipalacademy/capstone/actions/runs/4723789411/jobs/8380213096
Running it in -dev mode shouldn't require any new configuration files either.
If configuration files are needed for github workflow to work, they should be stored in .github only, so that it is obvious that it is only used in github workflow.
We can run Gitto and Registry as part of Nomad, and run integrated tests that deploy to Nomad.


Adds a new API that can customize the ingest sender.

This allows users to get access to the guts of the Zipkin OkHttpSender.Builder in order to do things like add custom headers and control compression settings, etc. The sender used in both paths (with or without disk buffering) can be impacted by this customizer.
It also includes a sample usage in the sample app.
This would ideally supersede #739. Thanks to @magdamagda for the original ideas and inspiration here.

@breedx-splk this approach will cover the functionality of #739. Thank you!
Hope it will be released soon.