Support shiftright and shiftleft functions

(you don't have to strictly follow this form)

Use case

A clear and concise description of what is the intended usage scenario is.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

velox already implemented: https://github.com/oap-project/gluten/pull/606/files
clickhouse WIP

done

done in

https://github.com/Kyligence/ClickHouse/pull/217


object 'prepro' not found

Hello. I used the script on May 21, 2020, and it worked without a problem. Today, June 9, 2020, I am running the exact same script with the same data but now I am getting errors in
Step 1: Data preprocessing
These are the commands that are giving me errors
prepro = feature_table_pre_process(feature_table, meta_data, sample_var, group_var,
out_cut, zero_cut, lib_cut, neg_lb)
feature_table = prepro$feature_table
I get the following errors:
Error in [.data.frame(meta_data, , sample_var) :
undefined columns selected
Error during wrapup: object 'prepro' not found
Error: no more error handlers available (recursive errors?); invoking 'abort' restart
Thank you.

Hello, I am encontering the same error here.

Hello,
I'm the OP of this thread. The culprit in my case was that another loaded R package was apparently interfering with this one. My colleague thinks that it was another package that also had a "rename" function, and thus the "prepro" object didn't get created. Once the other packages were unloaded, the script worked for me.

Hi All,
Sorry for responding late!
Just as Jaimes said, it might due the conflicts with other packages. If it is still not working, could you please upload the code you wrote with an example dataset?
Best,
Huang

Yes, I had the same issue as well. Just close your R completely and run everything carefully again. It is most definitely confusing values or functions with another R session.


Refactor existing code to match Module style guide

The style guide has been updated with recommendations about how to use modules: https://angular.io/styleguide#!#04-09

The recommendation is now to create a separate module for each feature

The main reasons are because it creates better separation of concerns
makes it easier to lazy load them
makes it easier to test

They also recommend a SharedModule

that should contain components and pipes that are used all over the application
we already have this, but it also contains services, and the recommendation is now to add services to a different globally shared module:

And a CoreModule

that should contain Singletons that need to be shared throughout the application -> services
The module helps to ensure all your services are actually singletons. They should be added to the provider's list of only the CoreModule, and not anywhere else
It should also contain other single use components, that are only used in the appComponent. a sidebar-component or a notification component would be examples of those
We don't have a CoreModule yet
Note that not every service needs to be in this module, if it's only need across a subset of the app, move it up to the first module that encompasses them all, not further

Refactor the current code to fit this structure.

This appears to possibly have been done in #152?

Yes, this can be closed


Logger doc

What type of PR is this?
docs
What this PR does / why we need it (en: English/zh: Chinese):
en: Enriched the tutorial documentation of the logger component under the hertz framework
zh:丰富了hertz框架下logger组件的教程文档
Which issue(s) this PR fixes:
Fixes #<488>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

参考其它 PR 优化下 PR title

I will CR it today and can resolve a code conflict @ViolaPioggia ❤

PATL @GuangmingLuo @rogerogers @welkeyever


Improve the image actions with some features

The image action button has missing few features for to gain in perform like to upload a local image, and resize the image selected.

They are missing on purpose, to keep the library lightweight.
You can either try to make a custom action with desired functionality, or use other editors (quill.js, ckeditor,...) that have those functionalities already.


Viewing contents of non-existing file should throw 404 instead of 500

See https://github.com/pelican-dev/panel/issues/678
Wings should return a 404 instead of a 500 error when the file doesn't exist.
Example:

https://github.com/pelican-dev/wings/blob/main/router/router_server_files.go#L40

@parkervcp I am working on this
I can edit this:
router/middelware/request_error.go L121

It will return the right error but the code is 200 (even tho is sas it should respond with 404, and I can for the live of god not figure out wy)
What I know is that router/middleware/middleware.go L60
	c.Error(errors.WithStackDepthIf(err, 1))

returns the 200 even tho the function
func CaptureErrors() gin.HandlerFunc {
line 84 does say satus is 404 (gets called after L60)

Or do it like this:
router/router_server_files L39

It will respond with the same error but code 404
So both fix the 500 but the first one makes it a 200 and the 2nd option a 404

Can be closed because #54 was merged


remark-docz prevents markdown from rendering as React components children

In some instances one needs to render markdown as React Components children.
At the moment, you can do this by leaving a blank line between the React component tag and the markdown content. For example:
<Notice type={"tip"} title={"Side note"}>

does this `really` work?

</Notice>

However, due to the remark-docz plugin this is not possible when using gatsby-theme-docz. Is there anyway you can change gatsby-theme-docz options so that you can opt-out remark-docz. At the moment, this is not possible due to the way gatsby-config.js is coded.
Otherwise, can you suggest any workaround?
Many thanks

Hey @homearanya, are you sure that the problem comes from remark-docz ? I was able to reproduce it with just gatsby and mdx.
In terms of workarounds I'm not sure what I can recommend other than leaving a blank line 🤔 .

When I comment out remark-docz on gatsby-theme-docz's gatsby-config, it works with the blank line. With remark-docz it doesn't.
Somebody else experienced the same issue a while back: https://github.com/mdx-js/mdx/issues/628#issuecomment-529551009

Oh that's weird then, I'm not able to reproduce 🤷♂
You've commented out require('remark-docz') in node_modules/gatsby-theme-docz/gatsby-config.js and were able to get "really" to be rendered as markdown using something like this :

does this really work?

We can add a flag to the config if someone would like to submit a PR, I'm just curious about what I'm missing in the repro.

Yes, that's right. I commented out require('remark-docz') in node_modules/gatsby-theme-docz/gatsby-config.js and I was able to render markdown as children
---
name: Getting Started
route: /
---

import Box from "../src/components/box"

# Getting Started

## Hello world

Type here the most beautiful getting started that you ever saw!

<Box>

does this `really` work?

</Box>

rendered as
...

        does this
        really
        work?

...

If I don't comment out "render-docz" I get:

work? really does this

This is the test repo: https://github.com/homearanya/tester-docz

Getting the same issue, I cannot nest markdown inside of react components with docz.
<Component>

this component has _markdown_ styled `text` inside.

</Component>

The above does not handle the inner markdown properly, like I'm used to with MDX.
It just outputs the raw text as a node, instead of properly parsing the markdown and returning:

this component has markdown style
text
 inside.


Using LLDB with st-util?

I successfully built code and ran it via gdb on my STM32F4 Discovery board, on OS X 10.9. Thanks for that!
I was hoping to use LLDB, and so I tried the same steps. LLDB uses slightly different instructions (gdb-remote 4242 instead of target extended-remote), but it doesn't seem to have a "load" command.
I wonder if anyone has tried to use LLDB with st-util? How do you do it? Thanks!

For extended gdb-server you should use OpenOCD (for now).


Add more details to readme

I left out examples for the runtime spec for now, because I plan to bring the io methods in line with the image spec methods soon. Feel free to propose additional items.
Rendered

Codecov Report

Merging #63 (0e68eb0) into main (f9a74af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   26.44%   26.44%
=======================================
  Files          19       19
  Lines        1301     1301
  Branches      672      672
=======================================
  Hits          344      344
  Misses        368      368
  Partials      589      589


Requesting info about long term strategy for Iot Edge. AKS EE + Windows IoT alternative?

Hi,
I have seen the new blog entry describing using Windows IoT and AKS Edge Essentials. Powering the next generation of Digital Operations with Windows IoT and Azure Kubernetes Service.

What kind of investment can we expect for IoT Edge in the future? Does this mean that IoT edge is in a stand still, and that major future investment will be towards AKS Edge essentials instead?
The new AKS EE solution seems to bypass the IoT hub entirely, using OPC UA PubSub over MQTT. Correct?
If AKS Edge Essentials is where we are headed, what are the current recommendation when it comes to solving customer needs today for connecting OPC UA servers with  bidirectional communication, using the PubSub format?
Will this project be turned into kubernetes containers/pods, so that we can use a hybrid solution when it comes to edge?
Can you comment a bit on the architecture drawing in the bottom of this post?

Best regards

It seems like this is the new route of the "roadmap" when it comes to connecting OPC UA on the edge to the cloud.

https://github.com/digitaltwinconsortium/ManufacturingOntologies/blob/main/Docs/architecture.png

Hi there,
IoT Edge continues to be fully supported. Our portfolio is growing and includes now multiple customers' demands for AKS EE.  The referenced solution and diagram refer to a set of samples published in the context of the DTC to showcase standardization work the DTC is championing and they don't aim to highlight any implication for any future product plans.
In addition, we are of course open to community feedback on how to evolve this project, please let us know what you would like to see going forward.
For further questions, feel free to contact me or the Microsoft account team.
Best regards


Try increasing timeout ? local build fails to fail so have to give a …

…try to Bamboo

Applied changes in 46e2b385f3f7dcf37397c9cd728f65833595e0c0 as 4396aeb0c760a7a19d91ff3d2a82c25101e82e94 as the minimal changes to resolve failing test issue.  Changes wrt to orderly shutdown should be done in a separate PR.
Note, also added additional exception message in BroadcasterMessageHandler to be in sync with behavior in MultipleBroadcasterMessageHandler


Project Page Search Bar Bug

@smaranjitghose I can fix this as I've also fixed the search icon for the component. So if you wish I can fix this.

@smaranjitghose I can fix this as I've also fixed the search icon for the component. So if you wish I can fix this.

If you want then I can make search bar expanded animations. For that you can assign me @smaranjitghose sir.

If you want then I can make search bar expanded animations. For that you can assign me @smaranjitghose sir.

Sure, raise a separate issue for this so that it is convenient to keep track.
Also, elaborate in the description of the issue "Search Bar Expanded Animations" Or give some reference


PWA Support

I should figure out how to make this a PWA so people can install it and use it offline

I tried using  offline-plugin for webpack but I couldn't figure out how to actually let the app update after I update assets, so I'm not going forward with this for now. The last thing I want is a bad service worker getting installed and nobody can ever update the app any more. Why are service workers so confusing and dangerous? 😬


Flow type checking only works in VSCode when file is "modified"

I'm trying to integrate flow into an existing React/Redux/JS project.  I am finding flow to be inconsistent in finding type issues in source code.
For example, when using Visual Studio Code with the Flow Language Support (0.8.2) extension I added this file to the top level of my project source code:
flow-check.js
// @flow

function square(n: number): number {
	return n * n;
}

square('a');

If I open this file flow finds no issues with it. If I use flow from the command line, it finds no issues either:

Output from flow cli:
$ flow
No errors!

The Weird Thing
I assumed I had perhaps configured things wrong, but I would occasionally get flow type checking issues surfaced in the issue reporter inside Visual Studio Code.
I have found that the only time I can consistently get flow to type check a file is to modify it in the Visual Studio Code editor but not save it:

If I save the file the errors go away, and flow cli never sees any issues:
$ flow
No errors!

Sometimes the Atom/nuclide editor will display the error but I haven't found a way to trigger it.
Bare Setup
If I duplicate the babel/flow/eslint configuration to a bare project, flow seems to work fine.
Configuration
 $ flow version
Flow, a static type checker for JavaScript, version 0.76.0

In package.json:
"babel-preset-flow": "^6.23.0",

In .babelrc:
{
	"presets": [
		[
			"env", {
				"targets": {
					"browsers": [
						"last 2 versions",
						"IE >= 11"
					]
				}
			}
		],
		"flow",
		"react",
		"stage-0"
	]
}

I've believe I have found the issue. In .flowconfig we added the ./src directory to for module resolution because the project runs with NODE_PATH=src to help with relative imports.
[options]
module.system.node.resolve_dirname=src
module.system.node.resolve_dirname=node_modules
module.name_mapper='.*\(.css\)' -> 'empty/object'

As soon as I remove the line:
module.system.node.resolve_dirname=src

It breaks all the relative imports
The type checker works in the flow-check.js example again as expected.

I need to be able to add the ./src directory as a location to resolve modules but it seems to be incompatible with flow working correctly.

Solution found. If I use a ./ in front of the src everything works correctly again.
[options]
module.system.node.resolve_dirname=./src
module.system.node.resolve_dirname=./node_modules
module.name_mapper='.*\(.css\)' -> 'empty/object'


No reset in policy?

Habitat-Lab and Habitat-Sim versions
Habitat-Lab: v0.3.0
Habitat-Sim: v0.3.0
Habitat is under active development, and we advise users to restrict themselves to stable releases. Are you using the latest release versions of Habitat-Lab and Habitat-Sim? Your question may already be addressed in the latest versions. We may also not be able to help with problems in earlier versions because they sometimes lack the more verbose logging needed for debugging.
Master branch contains 'bleeding edge' code and should be used at your own risk.
Docs and Tutorials
Did you read the docs? https://aihabitat.org/docs/habitat-lab/ Yes
Did you check out the tutorials? https://aihabitat.org/tutorial/2020/ Yes
Perhaps your question is answered there. If not, carry on!
❓ Questions and Help
Thank you for such a huge project and continuous updates.
Recently I focused on the RL part of Habitat. It seems that in PPOTrainer the Agent part and the Enviroment part are largely isolated. But if an rnn_state_encoder is applied in policy, how does it get the 'reset' command from the env?

Sorry for the time. I've found that the masks have been used to reset the rnn_state to zero. I'll close this issue.


Creating(or importing) new customized map

Hello,
can I create new maps rather than default maps?
Or, if I have some Unity models, can I import and use as a map of this simulator?
I want to try the simulator with my town's map that I made.
thank you

Hi,
I am not sure if we can create any new map for this simulator. Please let me know if we can create a new map.


Graphene backend with django-graphql-jwt honoring expired token

Using version 0.1.13 of django-graphql-jwt.
I am finding that the package is honoring expired tokens. I've used the Insomnia desktop client to verify. On the Django-side I am using a Graphene backend. To test, I used a simple graphql query, with a resolver that is protected using the @login_required decorator. The token I used in the header had been fetched 5 hours ago and should have expired 5 minutes later (I verified that by using jwt.io debugger to decode the token and determine the expiration time, then used the Epoch Converter at epochconverter.com to verify that the token did indeed expire 5 hours ago).
To make sure that the decorator is functional, I disabled the token in the header. And as expected the graphql query failed with:
{
	"errors": [
		{
			"message": "You do not have permission to perform this action",
			"locations": [
				{
					"column": 3,
					"line": 2
				}
			]
		}
	],
	"data": {
		"allUsers": null
	}
}

Also on the backend the following trace was logged, indicating that it was django-graphql-jwt package that was doing the authentication:
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphql/execution/executor.py", line 311, in resolve_or_error
    return executor.execute(resolve_fn, source, info, **args)
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphql/execution/executors/sync.py", line 7, in execute
    return fn(*args, **kwargs)
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphene_django/debug/middleware.py", line 56, in resolve
    promise = next(root, info, **args)
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphql/execution/middleware.py", line 57, in make_it_promise
    return Promise.resolve(next(*a, **b))
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphene_django/fields.py", line 122, in connection_resolver
    iterable = resolver(root, info, **args)
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphql_jwt/decorators.py", line 27, in wrapper
    return func(info.context, *args, **kwargs)
  File "/home/xxx/code/dev/local/lib/python2.7/site-packages/graphql_jwt/decorators.py", line 39, in wrapper
    raise exceptions.PermissionDenied()
PermissionDenied: You do not have permission to perform this action

Have  I got something misconfigured or is this a regression? I am using default django-graphql-jwt settings. I found this to also occur on 0.1.12.

Another interesting thing of note: When I do get the 'permission denied' message above without the auth token, I get a http status code of 200 (I would have expected a 401). Is this expected behavior?

Hi @amreshprasad ,
Have you set the flag JWT_VERIFY_EXPIRATION in your settings?
GRAPHQL_JWT = {
    'JWT_VERIFY_EXPIRATION': True
}

Thanks Mongkok. That's what it was. I should have read the documentation more carefully, duh!!
Am now facing another issue, wherein if the token expires and the user provides username/password again and the code hits the TokenAuth graphql query with the credentials, I get an unauthorized error based on the expired token in the header. Should the module not ignore the expired token for the TokenAuth query?
Thanks once again. Much appreciated.

wherein if the token expires ... I get an unauthorized error based on the expired token in the header

... you need to clean the header once token is expired (or do not let token to be expired by refreshing it every x mins and replacing it in the header)
So by cleaning the header, the next

the user provides username/password again and the code hits the TokenAuth graphql query with the credentials

... does not happen and user gets fresh token.

Yes, TitanFighter. I figured that out too. Just thought that the backend could have handled that scenario.
Got it working now. Thanks to you and Mongkok. Closing....

yes @amreshprasad,
I agree, but it is the middleware that checks if the token has expired, not the mutation.
I can not find an easy way to avoid the expiration error for TokenAuth.


Update hooks documentation - setField

This pull request is the follow up from the discussion,  refactor(set-field hooks): Handle 'as' field startsWith data and data type array
File docs -> hooks.md -> line 1700: Added
 __Note:__  When the service enable `multi:true` and `data` is an array data type, this hook may working to an unexpected result
I had revert the changes on the setField.ts and updated the hooks documentation. Please have a look.

Thanks! 👍


./CarlaUE4 to ./CarlaUE4.sh

It seems in pre-compiled version 0.9.0 to cmd line is:
./CarlaUE4.sh  -carla-server -windowed -ResX=320 -ResY=240

Description

Fixes #
Where has this been tested?

Platform(s): ...
Python version(s): ...
Unreal Engine version(s): ...

Possible Drawbacks

This change is

Hi @sunpochin, thanks for the fix! Don't worry about the build failing, it's some temporary issue with one of our tests.


Add support for Fabric's "Answers" event reporting

The previous implementation would just log events. This implementation actually sends the events to Fabric's "Answers" service.

Cool, looks good to me. :+1:

Cheers.


Error send

[nestor@archi trans]$ ./trans es "Hello"
trans: error: unknown error occurred while sending the Request. Maybe the amount of the text is too big.
HTTP Error 429: Too Many Requests
ideas

So, what was that?

Sorry its my problem , i send too match request, google temporarily  block me


Update README.md

Updated directories layout

Will add brief description of each directory/file later on.


before bots working , now not?

I had the proxies of a page.
but ,any new proxy now does not work.
even check proxies , but not.
I do not change any settings
I only get closed shocks

Get proxies from good sites like http://proxybag.blogspot.com/ or www.vipsocks24.net or both


If running against a branch head, ask for pulling the latest version

Check whether being on branch head by using:
[jakob@rs-fe1 cmd_wgs]$ git rev-parse --abbrev-ref HEAD
jw_update_genmod

Check added, now it asks about pulling if on a branch


How to use it in c#?

Feature Description
How to use it in c#?
Contribution Request
No
Additional Notes (Optional)
No response

@LeonFretter ported the plugin to C# (see https://github.com/LeonFretter/godot-utility-ai-cs) and it's available in the Asset  Library too (https://godotengine.org/asset-library/asset/2110).
I'm not at all familiar with the C# version of Godot, and I have no plans to support it myself.  I'd be open to contributions if somebody could figure out how to make the GDScript and C# versions coexist in one place, but I'm not sure that's possible.


Fix more unsafe casts to int.

Taking values from JSON and directly casting them to int or double makes them incompatible with dart2wasm, since in wasm they are two distinct types (as opposed to JavaScript where they are actually the same under the hood).

I think these were addressed in another PR


Add php command

Copying the idea from @angrybrad:

could we do something like nitro php ini where we could pass in flags like --memory-limit=512M, --max_execution_time=120, etc?

Is there any way to modify the ini file today?

@peirix you can log into the machine and you are free the edit the php.ini manually using:

nitro ssh
sudo vim /etc/php/7.4/fpm/php.ini
sudo service php7.4-fpm restart

Just replace the version of PHP with your installed version.

This was added and released with 1.0!


Fix: Calendar. Set displayedMonthIndex.

Hello!
After month change via select displayedMonthIndex became string value instead number. It generates errors in another parts of calendar (Calendar.changeMonth)

Hi @ryaza
Thanks for PR! Merged.
This Calendar is so old. I am going to update it and add select range (from-to) support. But that probably will be after 1.0.
What is your experience on using BunnyJS so far? If you have any ideas or feedback, please, let me know, thanks!


FaceDetector finds only one face (depending on FaceDetectorOptions)

Take this simple snippet of code:
var selectedFile = File(result.file.path);
    var inputImage = InputImage.fromFile(selectedFile);
    final options = FaceDetectorOptions(enableContours: true,enableLandmarks: false,enableClassification: false,enableTracking: false);
    final faceDetector = FaceDetector(options: options);
    faces = await faceDetector.processImage(inputImage);

-When enableContours is true but everything else is false (that's the default) then it returns only one face (in an image with 8 faces).
-When both enableContours and enableLandmarks are true, then it finds 7/8 faces for the same image as above (in fast mode which is reasonable) but returns contours for just one face (every other contour eg for any other face is null for all entries).
Test on Latest version ( google_mlkit_face_detection: ^0.5.0),
on several emulators (Nexus 5 API 29 was one of them).

That is by design:

https://developers.google.com/ml-kit/vision/face-detection/android#1.-configure-the-face-detector


Second Order SCF Stability

Hi, I found that some times SOSCF results are not internally stable. Like this one for example:
macro= 16  E= -1171.43462197624  delta_E= 2.1746e-09  |g|= 3.90934e-05  1 KF 9 JK
macro= 17  E= -1171.43462197647  delta_E= -2.23281e-10  |g|= 1.75659e-05  1 KF 10 JK
Canonicalize SCF orbitals
macro X = 18  E=-1171.43462197647  |g|= 1.75659e-05  total 44 KF 302 JK
converged SCF energy = -1171.43462197647
rohf_internal: lowest eigs of H = [-0.29657194 -0.06225346  0.00713301]
<class 'pyscf.soscf.newton_ah.SecondOrderROHF'> wavefunction has an internal instability
I wonder if this is because by some approximation in the SOSCF algorithm?

@zh-yichi thanks for sharing. Could you please post a minimal working example so maintainers can try to reproduce your problem?

SOSCF does not guarantee the internal stability.


Obtain value federate object from its name

this capability will be useful for HLA-HELICS Interface

this was added in #215


Service Tile - Text Wrapping

The text on One-Time Shredding tile is too close to edges. Should have more padding around edges to keep text more confined.
Example on: https://main--shredit--stericycle.aem.live/en-us/service-locations/boston

Will be covered via https://github.com/aemsites/stericycle-shared/pull/259


Enzyme Internal Error: Enzyme expects an adapter to be configured, but found none.

Following the documentation of this tutorial the Hello.test.tsx files errors like the title above.
From what I read online, the packages @types/enzyme and react-addons-test-utils would suffice the need to configure an adapter manually on a testsSetup.js
That didn't work.
I took the second route and wrote a testsSetup.js inside my src
setupTests.js (should this be .ts , .tsx?, either way it did not work)
import * as enzyme from 'enzyme';
import * as Adapter from 'enzyme-adapter-react-16';

enzyme.configure({ adapter: new Adapter() });

Hello.test.tsx
import * as React from 'react';
import * as enzyme from 'enzyme';
import Hello from './Hello';

it('renders the correct text when no enthusiasm level is given', () => {
    const hello = enzyme.shallow(<Hello name='Daniel' />);
    expect(hello.find(".greeting").text()).toEqual('Hello Daniel!')
});

Package.json
{
  "name": "my-app",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "react": "^16.3.1",
    "react-dom": "^16.3.1",
    "react-scripts-ts": "2.14.0"
  },
  "scripts": {
    "start": "react-scripts-ts start",
    "build": "react-scripts-ts build",
    "test": "react-scripts-ts test --env=jsdom",
    "eject": "react-scripts-ts eject"
  },
  "devDependencies": {
    "@types/enzyme": "^3.1.9",
    "@types/enzyme-adapter-react-16": "^1.0.2",
    "@types/jest": "^22.2.2",
    "@types/node": "^7.0.60",
    "@types/react": "^16.3.6",
    "@types/react-dom": "^16.0.4",
    "enzyme": "^3.3.0",
    "enzyme-adapter-react-16": "^1.1.1",
    "react-addons-test-utils": "^15.6.2",
    "typescript": "^2.8.1"
  }
}

Another source suggested adding extra config to jest on package.json such as
........
  "jest": {
    "setupTestFrameworkScriptFile": "<rootDir>/src/setupTests.js"
  }

However that errors as:
These options in your package.json Jest configuration are not currently supported by Create React App:

  • setupTestFrameworkScriptFile

Further...
A fresh clone of this repo errors out not running any test suites and complaining about cheerio names.
How can we get the Enzyme Adapter to work with the current project setup on .tsx files?

Hey there, so it didn't work for me as well. So I run npm run eject and added the src/setupTests.js with:
import * as enzyme from 'enzyme';
import * as Adapter from 'enzyme-adapter-react-16';

enzyme.configure({ adapter: new Adapter() });

and then
// package.json
"jest": {
  // ...
  "setupTestFrameworkScriptFile": "<rootDir>/src/setupTests.js"
 }

I ran into this as well while trying to get started with React. When running npm run eject, it sure sounds like something I don't want to do. I don't know if coming back from an eject is simple, but if anyone else hits that situation, you can also add that enzyme.configure line (and imports) just to the tutorial's Hello.test.tsx file.

If it's just a tutorial when I don't see why you should be scared to eject? It's not like you'll need update your tutorial. But didn't thought about adding it in same file. Still would be a bit tedious to add it everywhere you write test.

Sorry, I’m just too new to the land of npm. I have no idea what eject does, but the warnings it throws up before confirming had me convinced I shouldn’t. I definitely agree that having to do that for every test file in a large app would get old.

Eject is not is just react specific, all it does is spits out the configuration which create-react-app uses so you won't get updates from cra but you can customize it the way you won't.

When using a file called src/setupTests.ts with the content mentioned in @rimatla's first post, it works out of the box for me without ejecting.
BTW: This functionality is referenced in this pr from react-scripts-typescript.

@catchin I follow your pr to add react-test-renderer and enzyme-adapter-react-16 without use eject. npm test still fail.
The error message is the same as
These options in your package.json Jest configuration are not currently supported by Create React App:

  • setupTestFrameworkScriptFile

Why did I get an error in setupTests.js, i have executed npm run eject:
Test suite failed to run

     TypeError: Adapter is not a constructor

invalid code:
import * as Adapter from 'enzyme-adapter-react-16';
valid code:
import Adapter from 'enzyme-adapter-react-16';
Package.json
  "scripts": {
    "start": "node scripts/start.js",
    "build": "node scripts/build.js",
    "test": "node scripts/test.js --env=jsdom"
  },
  "devDependencies": {
    "@types/enzyme": "^3.1.11",
    "@types/enzyme-adapter-react-16": "^1.0.2",
    "@types/jest": "^23.1.1",
    "@types/node": "^10.3.4",
    "@types/react": "^16.4.1",
    "@types/react-dom": "^16.0.6",
    "enzyme": "^3.3.0",
    "enzyme-adapter-react-16": "^1.1.1",
    "identity-obj-proxy": "^3.0.0",
    "node-sass": "^4.9.0",
    "react-addons-test-utils": "^15.6.2",
    "sass-loader": "^7.0.3",
    "typescript": "^2.9.2"
  },
  "jest": {
    "setupTestFrameworkScriptFile": "./src/setupTests.js",
    "collectCoverageFrom": [
      "src/**/*.{js,jsx,ts,tsx}"
    ],
    "setupFiles": [
      "<rootDir>/config/polyfills.js"
    ],
    "testMatch": [
      "<rootDir>/src/**/__tests__/**/*.(j|t)s?(x)",
      "<rootDir>/src/**/?(*.)(spec|test).(j|t)s?(x)"
    ],
    "testEnvironment": "node",
    "testURL": "http://localhost",
    "moduleNameMapper": {
      "\\.scss$": "identity-obj-proxy",
      "^react-native$": "react-native-web"
    },
    "transform": {
      "^.+\\.(js|jsx|mjs)$": "<rootDir>/node_modules/babel-jest",
      "^.+\\.tsx?$": "<rootDir>/config/jest/typescriptTransform.js",
      "^.+\\.css$": "<rootDir>/config/jest/cssTransform.js",
      "^(?!.*\\.(js|jsx|mjs|css|json)$)": "<rootDir>/config/jest/fileTransform.js"
    },
    "transformIgnorePatterns": [
      "[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs|ts|tsx)$"
    ],
    "moduleFileExtensions": [
      "web.ts",
      "ts",
      "web.tsx",
      "tsx",
      "web.js",
      "js",
      "web.jsx",
      "jsx",
      "json",
      "node",
      "mjs"
    ],
    "globals": {
      "ts-jest": {
        "tsConfigFile": "./tsconfig.test.json"
      }
    }
  }

import Enzyme from "enzyme";
import Adapter from "enzyme-adapter-react-16";

Enzyme.configure({ adapter: new Adapter() });

This prevents the error Adapter is not a constructor


Cannot read property 'APP_ENGINE' of undefined

Creating the express middleware for logging causes the application to crash, as the variable that APP_ENGINE is being read from is undefined.
Environment details

OS: AppEngine Standard Env
Node.js version: 8.x.x
npm version: 6.4.1
@google-cloud/logging-bunyan version: 0.10.0

Steps to reproduce

Create the express.middleware() from the logging library
See crash due to value APP_ENGINE being read from some undefined object.

Stacktrace
TypeError: Cannot read property 'APP_ENGINE' of undefined
    at Object.<anonymous> (..../node_modules/@google-cloud/logging-bunyan/build/src/middleware/express.js:55:50)
    at Generator.next (<anonymous>)
    at fulfilled (..../node_modules/@google-cloud/logging-bunyan/build/src/middleware/express.js:4:58)
    at propagateAslWrapper (..../node_modules/async-listener/index.js:504:23)
    at ..../node_modules/async-listener/glue.js:188:31
    at ..../node_modules/async-listener/index.js:541:70
    at ..../node_modules/async-listener/glue.js:188:31
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:229:7)
    at process.fallback (..../node_modules/async-listener/index.js:565:15)

I tested that this error vanishes on 0.9.5. I'm not sure if there is some breaking change introduced in the new release which needs me to change how I'm setting up the middleware.
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

@sushshring thanks for the bug report. Can you check and report what version of the google-auth-library module you have in your application?

This is most likely related to https://github.com/googleapis/nodejs-logging-bunyan/pull/251

It is<EMAIL_ADDRESS>

Hmm.. that version should work. Are you sure there are no other copies of it more deeply nested in your node_modules?
I do see a bug in this repo: we require google-auth-library but have no dependency on it. This means that we will get whatever auth library that happened to exist in the system even if it is lower than the minimum version we wanted.

Would it be possible for you to provide your package.json and package-lock.json?

My npm list shows that there is an older version:
<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     └──<EMAIL_ADDRESS>
I don't know how this affects it

Would it be possible for you to provide your package.json and package-lock.json?

They're big files. I'd be happy to, but it'd be messy to do here. Any other way to share?

Your npm list output answers my question. That's the version I think we end up picking up depending on how npm is hoisting things.

Fix in #278.


Request: Apple Watch Support

According to litmus, including a third section in a mail with Content-Type: text/watch-html lets us supply an version of the mail formatted for the Apple Watch.
https://litmus.com/blog/how-to-send-hidden-version-email-apple-watch

Can't this be done via a plugin? Perhaps a variant of https://github.com/andris9/nodemailer-html-to-text that adds that content type.

Added new message option appleWatch in v1.4.0
Usage:
transport.sendMail({
    text: "Plaintext content",
    html: "HTML content",
    watchHtml: "Apple Watch specific content"
});

I do not have an Apple Watch or emulator myself, so this is untested, I have no idea how the watch actually treats this.


CDPS-873: Adding a bit more typing into PhysicalAttributesUpdateRequest

Codecov Report
Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (7b28dee) to head (4e7ff0a).

Files
Patch %
Lines

...son/dto/request/PhysicalAttributesUpdateRequest.kt
90.00%
1 Missing :warning:

Additional details and impacted files
@@                            Coverage Diff                            @@
##             CDPS-873-update-physical-attributes      #45      +/-   ##
=========================================================================
+ Coverage                                  82.87%   82.90%   +0.03%
+ Complexity                                   303      301       -2
=========================================================================
  Files                                         55       55
  Lines                                        981      977       -4
  Branches                                      79       78       -1
=========================================================================
- Hits                                         813      810       -3
+ Misses                                       119      118       -1
  Partials                                      49       49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to save migration IPs whitelist

Steps to reproduce:

Go into the Advanced settings of the plugin.
Input any value (including the latest whitelist from the Custom database tab in your database # settings in Auth0, that should be valid) into the Migration IPs whitelist.
Click Save Changes.
You'll get a message indicating the settings were saved, but the IPs whitelist remains empty.

Looking at the code, this appear to be because $old_options are being used instead of $input. Judging by the commit history it has always been this way.

Feel free to write a PR for these kind of issues 😄


V1.0.1 Build Failure

Log https://jitpack.io/com/github/aliab/RTLMaterialSpinner/V1.0.1/build.log

humm, seems JitPack has a bug in accepting licence
You have not accepted the license agreements of the following SDK components:   [Android SDK Build-Tools 25.0.2, Android SDK Platform 25].
I will change build tools and update library soon. thank's for your report.


Create piyush_kumar.md

Notes for Reviewers

This PR fixes #

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit d17635d0723df30185cfb29879f2e44bef292c4f at: https://67487a17ae85c4c4a1b3c7b8--meshery-docs-preview.netlify.app

🚀 Preview for commit d17635d0723df30185cfb29879f2e44bef292c4f at: https://67487a6686d4e8ccdd61f040--meshery-docs-preview.netlify.app


Added translation for edit button text

Details

Added translations for edit button text

Fixed Issues

$ #4494
Tests

Tested texts in both the languages - English and Spanish
Verified the button texts, on language change

QA Steps

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Jag96 in version: 1.0.83-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24.  :confetti_ball:

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


New Command to Rename in Scope

Command to rename var, namespace, keyword.

There's an undocumented pg_pep_rename command in v0.7.0 that works for views only.


FIREBREAK: Support Stats v2.0

Background
The support requests we receive are recorded daily and uploaded to the KPI Dashboard repo to provide statistics of request types daily, monthly and for the year.  This process involves updating a Google Sheet and generating a csv file on a daily basis, then pushing the changes to the KPI repo.  As we will be moving away from the Google Suite in the future, a new way of recording the stats is required.
Questions / Assumptions

What tooling can we use to improve data recording and analysis?
Can we improve the process to reduce the amount of manual work required?

What hypothesis do we want to test?/What do we want to learn?

We want to test if the stats can be recorded in a database, and what type of DB would be suitable
We want to test if it's possible to create a web front end for data input
We want to test if it's possible to generate ad-hoc reports based upon historical data
We want to test that stats can still be displayed on the KPI dashboard on a daily basis

Definition of done

[ ] Firebreak finding documented appropriately
[ ] Demo completed
[ ] Decision made on whether to progress Firebreak work
[ ] Does next steps require User Research?
[ ] Firebreak next step Issues created
[ ] New Issues referenced in this story before closure

Created test web app (running locally) using Flask, currently has pages for:

Adding a record to the database
Reporting (querying the database)
Manage (upload/download all data in case of db error etc)

Building out the pages and adding functionality atm

Web front end is now ready to add records.  Database has been setup, issue atm is that the frontend isn't submitting records - investigating and fixing this issue.
Need to design the app so multiple records can be added at once, and some form of preview of the records to be added.


added setMe (update/put)

Good and simple, just the way I like it! :)

thought those where strange, but i though safest would be to copy them. so now i went the other direction and kicked them from link/unlink as well

Boss!


On Android can only back up a wallet with no passcode

Steps to reproduce
try to back up a wallet when the passcode is on. Can't get past the pastcode screen after scanning with my fingerprint.
if I remove the passcode and the wallet is unprocted, I can.
Expected behavior
Should be able to back up wallets whether there is a passcode or not.
Affected Version
Android v10, Galaxy S10

@jabo38 this is backup when you already logged in settings right? This must be device specific because I'm able do it on my Samsung S20 with Android 11

yes. I'm using the Symbol Beta app on a Galaxy S10
Go to settings ->
Go to "Backup" ->
Asked for passcode via fingerprint ->
Scan fingerprint ->
Stuck on panel that has numbers to enter passcode even though my passcode has been entered via fingerprint.
This getting stuck on this screen has happened in other places too like for sending transactions, so it is a repeat of that same issue.

This should be corrected in the last version of the app.
Please test it and close this issue if fixed

This should be corrected in the last version of the app.
Please test it and close this issue if fixed

@jabo38 for me it looks correct in new version so I'm closing. But please check on your phone too. Latest version available here: http://symbol-mobile-builds.peersyst.com/

@jabo38 for me it looks correct in new version so I'm closing. But please check on your phone too. Latest version available here: http://symbol-mobile-builds.peersyst.com/


Added links to documentation in README.md

Motivation:
For newcomers that start to explore SwiftNIO on GitHub, the first thing they stumble upon is README.md. This file contains a high level description of the framework and mentions a few types that are important when getting started. Adding links from these types to the generated HTML documentation reduces possible friction and makes it easier for newcomers to grasp fundamental building blocks of SwiftNIO.
Modifications:

Added Markdown links from first use of types in README.md to generated documentation at https://apple.github.io/swift-nio/
Added Wikipedia links for few important concepts: pthreads, kqueue, epoll

Result:
Easier navigation from README.md to related documentation.

@swift-nio-bot test this please

thanks for the feedback, I still haven't converted all my new links, maybe better if I'll manage to get that done for this PR as well

@maxdesiatov totally up to you if you do it in this PR or in another one :). Thanks very much for your help!

@maxdesiatov just ping me when you're done with this, then I'll get it merged :)

@weissi all links now added in the format as you suggested, hope this can be merged. thanks a lot for your feedback on the PR 👍

@swift-nio-bot test this please

4.1 build failed 😳 sporadic errors? Not sure my changes would be able to cause this

@maxdesiatov it's #554 I'll look into it soon

@swift-nio-bot test this please

again, I fixed it in #555

@swift-nio-bot test this please

@swift-nio-bot test this please


Recursively delete child modules

I have a case where the entry point of a module was not the file storing the state, it only surfaces it. This caused me to recurse module.children and delete, which solved the problem. Would you like me to add this feature, perhaps behind an option?

Addressed here https://github.com/sindresorhus/clear-module/pull/9

Oppologies I missed that.


Manual Testing of Pending Transactions/Transaction Selection

In #1285, we had the suboptimal mining behavior of not choosing high gas cost transactions. We should perform more validation around mining and transaction selection. A key step in this process is probably reaching out to a miner and discussing what behavior and options they wish to see.

Closed via new tx pool behavior in proof of stake


Tests seem to be failing?

davida@suki ~/s/node-github> mocha api/v3.0.0/authorizationTest.js

  ․․․․․

  3 passing (8s)
  2 failing

  1) [authorization] should successfully execute GET /authorizations (getAll):
     Uncaught AssertionError: 41 == 2
      at /Users/davida/src/node-github/api/v3.0.0/authorizationTest.js:48:32
      at /Users/davida/src/node-github/api/v3.0.0/authorization.js:59:17
      at IncomingMessage.<anonymous> (/Users/davida/src/node-github/index.js:752:21)
      at IncomingMessage.EventEmitter.emit (events.js:117:20)
      at _stream_readable.js:910:16
      at process._tickCallback (node.js:415:13)

  2) [authorization] should successfully execute PATCH /authorizations/:id (update):
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/usr/local/lib/node_modules/mocha/lib/runnable.js:175:14)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

This issue is very outdated so I’m going to close it :) We are working on bringing back tests as part of the transition to the @octokit org: https://github.com/octokit/discussions/issues/7


87

Closes #87
Basic usage:

dev:

VITE_ADMIN_API_URL=<url> npm run dev

production:

VITE_ADMIN_API_URL=<url> npm run build

or just type

npm run dev

and it will get default url, i.e. http://localhost:8080/api/v1/admin, same thing for rest-app

PR-Codex overview
This PR updates the API URL in the client code of two applications.
Detailed summary

Added .env to both client .gitignore files
Updated the API_URL constant in qa-rest/src/main/client/src/constants/api.ts to use the environment variable VITE_API_URL or default to http://localhost:8081/api/v1
Updated the API_URL constant in qa-admin/src/main/client/src/constants/api.ts to use the environment variable VITE_API_URL or default to http://localhost:8080/api/v1/admin
Updated the baseURL property in qa-rest/src/main/client/src/http/api.ts to use the updated API_URL constant instead of the old BASE_API_URL constant.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report
Patch and project coverage have no change.

Comparison is base (b71a6ed) 71.18% compared to head (ad26a33) 71.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #89   +/-   ##
=========================================
  Coverage     71.18%   71.18%
  Complexity      172      172
=========================================
  Files            78       78
  Lines          1211     1211
  Branches        103      103
=========================================
  Hits            862      862
  Misses          254      254
  Partials         95       95

Impacted Files
Coverage Δ

qa-admin/src/main/client/src/constants/api.ts
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use EntryRefFilter to filter calls to UniqueStoreRemapper::remap() for

single refs.
Use less indirection for RcuVectorHeld.
@geirst : please review

@toregge please merge after merge stop has been lifted.


Type Annotations: Fixing errors showing up in static type checking tool mypy

In light of some of the issues I raise in #1212, I have started a process of going through all mypy errors and trying to fix them.
This PR started by adding some Type Annotations to animations.py and a few to rate_functions and a few more places... I was following the mypy output on error at a time, skipping over harder ones and solving the simple ones.
Changelog / Overview
I have added and corrected typing hints in animations.py and rate_functions.py I have removed the use of np.clip in favour or min and max, so that a rate function is just float -> float as expected (and not Union[float, numpy.ndarray])
I have added a TypeVariable to Mobject.copy so that derived objects (like Group) are preserved by copying.
I continued into composition.py, transform.py, creation.py picking off the low hanging fruit. Mostly a change in type hints, but also a few minor refactors. Prime example: in the Write animation, self.run_time and self.lag_ratio were being set in the __init__ function and then set again in the parent __init__ function. I cleaned that up. Each variable should have only one level in the hierarchy where it is set/written during __init__.
I have changed the Wait() animation so that it has a Mobject attached to it - albeit an empty Mobject(). This allows us to tag the first argument to Animation() as Mobject instead of Optional[Mobject]. Keeping it as the latter would have required a myriad of checks of the form if animation.mobject is not None: animation.mobject.method(...) and that's not too nice.
There is a slight hickup in that a GLMobject is not (yet) a Mobject and using the Wait Animation in the GL context causes an error. I have found an ugly quick fix for this that I hope will become unnecessary soon as GLMobjects mature.

Motivation
This fixes a bunch of errors found by running the mypy type checker. See Issue #1212. I think we should have everything correctly typed, and no typing errors shown by mypy
Explanation for Changes
Animations will not crash when given a None type object. AnimationGroups can contain a Wait() animation.
Testing Status
All tests pass locally. No new tests added.
Further Comments

Try running mypy ./ before and after this PR to see the difference.
Before:
mypy Found 538 errors in 90 files
After:
mypy Found 491 errors in 90 files
... there is plenty more to clean up.
Checklist

[ ] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[x] My new functions/classes either have a docstring or are private
[x] My new functions/classes have tests added and (optional) examples in the docs
[ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

I just realised that this PR was from my dev branch and I've been pushing too it constantly.
Shall I close this PR for now and recreate when it is ready again, or is it OK to stay open?
The theme of this PR is - fix many - but not all - errors coming from mypy.

Before:
mypy Found 538 errors in 90 files (checked 208 source files)
After:
mypy Found 491 errors in 90 files (checked 208 source files)

I managed merge conflict in web editor. I hope it's OK. It's always hard to satisfy black and flake while working in web edit mode...

@cobordism : can you wait with merging until #1338 is a bit more formulated?
Then we can come back to this pr and know exactly how we want to have things consistent.

It's always hard to satisfy black and flake while working in web edit mode...

Oh, you dont' have to satisfy black anymore, that does pre-commit.ci for you ;)

@kolibril13

@cobordism : can you wait with merging until #1338 is a bit more formulated?
Then we can come back to this pr and know exactly how we want to have things consistent.

do you think that helps? Rather than merging and then continuing the work? After all, the type hints still require a lot of work overall... and at least this PR makes a start at reducing mypy errors.
On the whole, I'm somewhat ambivalent. It's up to you.

and at least this PR makes a start at reducing mypy errors.

Let's merge it then.
I think waiting would only cause merge conflicts.


Hex code input support for Color Picker

It will be great if Color Picker can provide a Hex code input field. GUI sometimes serve as a way to allow the designer to adjust the color and feedback to the developer. Using Hex code input field makes it way easier to read/write.

Yep agreed. I'd like to have an RGB field too, but hex is probably more important

!!


Match the color of the app to the color of the Status bar

Describe the idea
You can check the image.
The current app is above. And the design is under.
Reference images and links
https://www.figma.com/file/NcSMs6dMsD88d4wOY0g3rK/Conference-App?node-id=0%3A1

🙋♂


ign -> gz Header Migration : ign-cmake

See https://github.com/ignition-tooling/release-tools/issues/711

Note
This PR will require a lot of manual patching for REPLACE_IGNITION_INCLUDE_PATH for the examples because the examples have a bunch of subdirectories/subprojects.

Note
This PR will require a lot of manual patching for REPLACE_IGNITION_INCLUDE_PATH for the examples because the examples have a bunch of subdirectories/subprojects.
I won't script that because there's a lot of variance between how the examples are done for the different packages.

I think the examples in this repository can wait if they take extra work. They can switch when we update the default include path in the ign-cmake macros themselves

@osrf-jenkins run tests please!

Looking at this PR now, I think gz-cmake is a special case where we don't need to migrate any includes to gz because they're all deprecated (#171). So I think we can close this PR and call the gz-cmake header migration done.

:thinking: We might want to consider migrating the examples when we're ready then, but I'll close this for now.

Looking at this PR now, I think gz-cmake is a special case where we don't need to migrate any includes to gz because they're all deprecated (#171). So I think we can close this PR and call the gz-cmake header migration done.

🤔 We might want to consider migrating the examples when we're ready then, but I'll close this for now.

we can migrate the #include <ignition/* statements in the examples when we change the default PROJECT_INCLUDE_PATH path to gz/

https://github.com/ignitionrobotics/ign-cmake/blob/fd2e2610d9138dad8cc3214d4f00ddf98ab3b599/cmake/IgnConfigureProject.cmake#L91


Multiple genres

While organizing my library, I noticed that it would be fantastic for musikcube to parse multiple genres, so that a track tagged as "Drone; Ambient" would be found in the genres "Drone; Ambient", "Drone", and "Ambient".
I looked up if there is a convention on the separator and storing multiple genres, but from what I read it seems to be up to the program to handle that.

Apologies for the late response, I've been very focused on cleaning up some fundamental issues and getting the code base in a bit better shape.
musikcube does indeed index multiple genres, but the UI is only configured to read the first one. This is something I'd like to improve in the future.

Apologies for the late response, I've been very focused on cleaning up some fundamental issues and getting the code base in a bit better shape.
musikcube does indeed index multiple genres, but the UI is only configured to read the first one. This is something I'd like to improve in the future.


Sahara, sand theme.

v0.5

thanks

@GianlucaGuarini tnx!, when does it show up under https://colorsublime.github.io/ ? tnx again!
quick q: how do you target 'markdown' syntax. i don't have the styling right in my theme. i didn't have time to research the syntax specific configs. if there's a cheetsheet somewhere, etc, tnx


Android low FPS and GPU timer not updating after 73eff10

Tested versions
Bug appears in 4.x 73eff10c76c201a083193c044de1836217b4d72b
Previous commit f317cc713aa4dbcee2efa10db764473a56680be7 doesn't have the bug
(builds are here: https://github.com/roalyr/godot-for-3d-open-worlds/releases/tag/Test2 )
System information
Lenovo TB350FU, ARM Mali-G57 MC2 and Motorola moto g(60), Adreno 618, all in Vulkan mobile mode.
Issue description

GPU timer freezes and rarely updates.
FPS is lower than expected in 3D scenes (bug-free editor has 2 - 2.5 more FPS, both in editor itself and when launching the scene).
Occasionally prints out error:

drivers/vulkan/rendering_device_driver_vulkan.cpp:2538 - Condition "err != VK_SUCCESS" is true. Returning: ERR_CANT_CREATE

Steps to reproduce
Compile Android editor of both version (see commit numbers above) and test 3D scenes that are expected to render at less FPS than screen refresh rate (moderately demanding renders). This way on the same scenes the difference in FPS will be clearly visible.
Minimal reproduction project (MRP)
Any (I noticed on this scene (just launch it after cloning the repo): https://github.com/roalyr/GD4Lancer/blob/main/Scenes/Stellar/Nebulas/Nebula.tscn the FPS difference was 17-18 vs 38-42 less or more).

Builds: https://github.com/roalyr/godot-for-3d-open-worlds/releases/tag/Test2

A few things to confirm that come to mind:

[ ] If this behavior actually happens in upstream Godot or only in the fork you linked.
[ ] Testing with and without V-Sync to see if behavior is any different.
[ ] Adding some printing to swap chain resizing to see if for some reason it's not constantly being triggered.

There's not many much behavior changes I can think of yet that could trigger such an issue. I'll try to test myself on Android but I don't recall other people noticing any such behavior when testing the PR on the platform, so I'm a bit lost on what it could possibly be at the moment.

Adding some printing to swap chain resizing to see if for some reason it's not constantly being triggered.

This is what's constantly happening for some reason apparently!

It seems we're stuck in a loop where VK_SUBOPTIMAL_KHR is returned during present no matter what we do in Android.
I'm not sure how we can retrieve why it does this, but whatever we're doing to recreate the swap chain. It could be easily explained why the previous version didn't trigger this bug: it just ignored suboptimal.
I'll try to confirm whether the previous version was running into this as well and simply ignored it or if the swap chain recreation we're doing right now is missing something from doing it as optimal.

It seems indeed the previous version has always triggered VK_SUBOPTIMAL_KHR in android, it just chose to ignore it during presentation and it never led to resizing. I'll investigate as to why it never achieves the optimal presentation but I suspect it might be due to something...

So my suspicion was right.
Godot does not handle screen rotation natively, as it always creates the swap chain with VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR despite the current transform being different (for example VK_SURFACE_TRANSFORM_ROTATE_90_BIT_KHR on my landscape mode during testing).
The error goes away if I use the transform that is marked as the current transform, but the screen looks distorted and incorrect.

But the constant resizing error goes away.
Since it's unlikely Godot will get modified to support screen rotations natively, I guess our only choice is to handle Suboptimal as a valid result. I'll do a PR and we can verify if it fixes the error.

A reminder to self to to open (or link to existing) an issue related to mouse handling on Android when dragging sliders and rotation gizmo in 3D view (left-right mouse motion is perceived as up-down and vice versa). Might also be related to poor orientation handling.

So my suspicion was right.
Godot does not handle screen rotation natively, as it always creates the swap chain with VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR despite the current transform being different (for example VK_SURFACE_TRANSFORM_ROTATE_90_BIT_KHR on my landscape mode during testing).
The error goes away if I use the transform that is marked as the current transform, but the screen looks distorted and incorrect.

But the constant resizing error goes away.
Since it's unlikely Godot will get modified to support screen rotations natively, I guess our only choice is to handle Suboptimal as a valid result. I'll do a PR and we can verify if it fixes the error. It's not the best solution but at least it'll bring it back to the behavior previous to the commit: it just basically exposed an underlying error that was being suppressed before. Therefore it should be clearly documented in code as well that the behavior is intentional.

@DarioSamo Are we applying this vulkan Android optimization tip, I wonder if that's the cause of the issue you're seeing when applying the current transform.


Electron rebuild didn't work with node-serialport and Raspberry PI

Console log:

pi@raspberrypi ~/rfid/electronApp % ./node_modules/.bin/electron-rebuild -f -p -m node_modules

./node_modules/.bin/electron-rebuild -f -p -m node_modules  45.88s user 3.34s system 100% cpu 49.079 total

Project structure and package.json

I want rebuild node-serialport, because if i run electron app, they says me "Module version mismatch" on serialport module.
How i can solve this?

I don't think electron-rebuild properly supports ARM at the moment :(

Oh, well....
So, how to rebuild manual module for electron?

Solved by:
cd node_modules/serialport && node-gyp rebuild --target=1.2.0 --dist-url=https://atom.io/download/atom-shell

You won't fix script?:)


How do I get the background color of the tray bar on a mac?

The color of the tray on a mac is usually related to the wallpaper rather than whether it is dark mode, on electron you usually use template-image to solve this problem, I wonder if there is such a solution in compose-jb or an interface to get the background color of the tray bar?

This can be done via AWT using System.setProperty("apple.awt.enableTemplateImages", "true") (assuming that your image follows the template conventions of just using pure black and the alpha channel)

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Cannot Find config.php in Docker Image

Hello,
I recently installed munkireport via the docker image.
I do not see the config.php file in /var/munkireport/
root@munkireport:/var/munkireport# ls
CHANGELOG.md  _config.yml  composer.json  docs	       storage
Dockerfile    app	   composer.lock  index.html   system
LICENSE.md    bootstrap    database	  phpunit.xml  tests
README.md     build	   docker	  public       vendor

or in its sub folders.
I looked in app and in app i looked in config but it wasn't there.
root@munkireport:/var/munkireport/app# ls
config	controllers  db  helpers  lib  models  views

root@munkireport:/var/munkireport/app/config# ls
app.php  auth  auth.php  dashboard.php	db.php	widget.php

Any direction would be helpful. Just want to get in so i can make an actual username with a password.
Thanks
Nick

MunkiReport now uses environment variables for configuration. See the wiki: https://github.com/munkireport/munkireport-php/wiki/Server-Configuration
Sent from my iPhone

On 14 Feb 2019, at 00:42, NickFuscoMeriden<EMAIL_ADDRESS>wrote:
Hello,
I recently installed munkireport via the docker image.
I do not see the config.php file in /var/munkireport/
`root@munkireport:/var/munkireport# ls
CHANGELOG.md _config.yml composer.json docs	storage
Dockerfile app composer.lock index.html system
LICENSE.md bootstrap database	phpunit.xml tests
README.md build	docker public vendor'
or in its sub folders.
I looked in app and in app i looked in config but it wasn't there.
Any direction would be helpful.
Thanks
Nick
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Add Another button on browse

Is there any way to add html code (specially a buttom or a link) in this table witchout edit hardcode ?

I did it with overriding views.
Check docs: https://voyager.readme.io/docs/overriding-views

Just add an Action class.
You create a class that extends TCG\Voyager\Actions\AbstractAction, then add it to a ServiceProvider like this: Voyager::addAction(MyNewAction::class).  As an example, you can copy the Edit button Action class here: https://github.com/the-control-group/voyager/blob/1.1/src/Actions/EditAction.php

I think itswill be greet if we can add it using html data at the form

@fletch3555  how can we remove edit action button from any 1 browse page?


Success function invoked in source for any status code returned

So we updated to 0.9.12 and we're currently seeing the success promise invoked always even though the response.ok is set to false.
We have tried by changing the response status code we return to ones in the 3 and 400 ranges and even though that response object properly has the response.ok set to false, we cannot find a way for it to trigger the failure function instead.
this.post({
      url: '/services/legistar/meeting_statuses',
      body: payload
    }).then(function(response) {
      SomeActionCreators.create(response.body);
    }, function(response) {
      response.json().then(callback, sourceError);
});

The above is a sample selection from our codebase. Is anyone else seeing this?

Do you know that this would reject the promise in earlier versions? Fetch itself does not reject the promise for non-"OK" status code.

It did reject previously. We updated today and we return an array of errors which are coming back in the success function of the promise.
The response.ok is now false inside the success function which doesn't seem to be valid to me.

Thanks. What version were you on previously?

cc @martyjs/core
I took a quick look. It looks like this commit for v0.9 removed the old behavior of throwing on status >= 400: https://github.com/martyjs/marty/commit/5537f160ce96c4cc137e9076019464e8f90b0181#diff-6359462e10b92745eaee57745617ccf3
The re-write actually broke the test case here: https://github.com/martyjs/marty/blob/master/test/browser/stateSources/httpStateSourceSpec.js#L182-L206 because expectedResponse is never set, so both expectedResponse and actualError are undefined.
I don't know what the right thing to do here is. The underlying fetch API does actually resolve the promise even when the request fails. It'd probably be best to add back the old behavior, but the wrappers around fetch in the HTTP state source are somewhat odd - I feel like it would make more sense to just wrap Axios (https://github.com/mzabriskie/axios) or something instead of having an HTTP client in Marty.

we previously were on 0.8.12

:+1: Yay.

@cdownard I've just released Marty v0.9.13 which adds a hook that replicates this behaviour. Its not enabled by default so you need to add HttpStateSource.addHook(require('marty/hooks/throwError')) when the application starts to have

:+1: It might be helpful to update the docs to show explicit error handling on the HTTP state source, though.

Yup, added to the list


MD CONTRIBUTING.md README.md

fixed spelling errors in  CONTRIBUTING.md README.md files
fixed markdown violations in  CONTRIBUTING.md README.md

Hey thank you so much for the edits especially the spelling!!
Your pull request seems behind on the commit history hence the merge conflict (i.e. you made the readme change on an older version of the file).
Have a look at this link to keep your fork in sync https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork
Do you want to try update the pull request? Otherwise I can resolve the conflicts from my side.

Hi @runningdeveloper  I've fixed the merge-conflict


[🐛 bug] Deployment Logs UI bugs (and some improvements)

Describe the bug
Other bugs noticed when making the deployment UI :

[x] #291

[x] Not very performant :

[x] #293
[x] #294

[x] #289

Some improvements :

[x] #292
[x] #305
[x] #306
[x] #300

[x] #297

Additional context
Add any other context about the problem here for example if the issue only appears in one browser or OS.

[x] Are you willing to make a PR for this ?

done !


"Polling the networking future took ... seconds" tracking issue

There is occasionally a warning being printed about spikes in the networking worker polling function.
The yellow bars in this graph show every time the networking tasks of all Parity nodes combined took more than one second to poll:

This should be investigated to determine the cause.

I've added some additional benchmarking on a custom branch: https://github.com/paritytech/substrate/compare/master...tomaka:benchmark-network-future?expand=1
The graph here shows the time it took to execute the various pieces of code:

And the culprit (the blue line) seems to be the block of code here: https://github.com/paritytech/substrate/blob/ee098e9e5c9ab813ff98a0fdb6dba25e1fad3ddf/client/network/src/protocol.rs#L1962-L1978
I'm running with the "new" sync protocol. In other words use_new_block_requests_protocol is always true.
Nothing really strikes me as obviously slow (i.e. something that could cause the whole thing to take more than one second) other than the fact that we call the client.

I've thought a bit more, and I think I figured out.
The problem is not that block_requests() takes a long time by itself, it's just that it is called too often.
Whenever we emit for example a Kademlia request, we emit one event towards each node we're connected to. These events are produced by returning Poll::Ready.
The swarm, in turn, continues calling poll in a loop for as long as there are events available.
The problem is here: if we have 200 connections and want to send one event for each connection, that means we're going to call for _ in self.sync.block_requests() 200 times.

A spike in my graphs just appeared where process-libp2p-outcome took 8ms, but in the absolute 8ms is fine and might not be worth investigating if the cause is indeed what I'm suspecting.

Should be fixed in #5829

Fixed indeed


Error when using lovesay on Fedora

Problem
I installed lovesay via pip3 as specified in the README, but when I tried to run it I got this error

I created the $HOME/.config/lovesay/quotes file and have two quotes in it

System Info

OS: Fedora 35

Hi! lovesay is intended to display a quote for each day of the month, so it looks like it's throwing an error since it's trying to find a quote for 27th day and there aren't any since your file only has two quotes. Regardless, it should've been handled on my end. I've pushed out a hot fix where it should print out an empty heart if there is no quote for the current day, but I'll look into a more elegant solution soon enough :)

Oh interesting, but why not default to a random quote?

I certainly thought of that at one point, I just figured printing out an empty heart was the easiest way to let the users know something was wrong. but perhaps making the quote an error message letting the user know what to fix would be a better idea?

I've pushed out an update to print "No quote found for today, here's a hug :)" if there is no quote for the current day. Not having a quotes file still prints out an empty heart, but with the new update, lovesay can also print out on-demand messages.
For example:
lovesay "hello world"

prints out:


Introduce masthead utility menus to Page Layout demo

Define standard masthead utility menus - organization and content and incorporate into the standard page layout demo. Need to consider what menus are required and how content is organized. Consider requirements for user management, help, support, language selection, and other settings.
Results should be incorporated into the existing page layout demo.
Related issues: #1832 , https://github.com/patternfly/patternfly-org/issues/714

@dongniwang per our discussion, I have created this issue and assigned in to you for discovery work. I am working with @maryshak1996 on a separate issue to better define the behavior of utility items in general as a first priority. Once we have standard menus defined, the goal would be to implement as a demo and publish design guidelines to the website. Let me know if you have questions.

FYI, if you log in with your Red Hat Account you can see the early attempt at cloud.redhat.com. Screen shots here for convenience.

@mcarrano thank you!
@jeperry thank you for the screenshots! Two questions:

The "username" and "account number" in the first screenshot are greyed out, is there a reason for it? For the user avatar, is it clickable? How would users update their avatars?
The second screenshot (help dropdown menu) - is there a reason behind opening the links in the existing browser tab instead of a new tab?

username and account number are included as information only. These are necessary for account differentiation, but they are static info and cannot be clicked, so that is why the text treatment is different than actionable menu items below the divider. The clickable area to invoke this menu is the user name and the arrow,  the avatar is not included in this. Avatar image is updated via Customer Portal profile (on another domain) which is reached via the link "My Profile."
The first three links are on different domains and should probably open in another tab, but have not been implemented this way. Is there a design pattern to indicate links in these menus that open new tabs vs those that do not? 'About' simply opens the about modal.

fyi @KendraMar

@dongniwang Hi, the Cloud Services team is asking about the avatar as well. Here's what one of the team reported in Jira:
"currently the user avatar icon sits without a way to interact with it directly beside the username/action drop-down
other websites/apps like google, Jira, github and manymorehave the icon integrated with that user actions drop-down, or even use only the icon as a way to open the drop-down/context
i believe that from a ux familiarity standpoint the icon should be either integrated into the drop-down or at least trigger it as well"

Thanks for the info @jeperry and @KendraMar !

Documentation on potential menu items can be found here: https://docs.google.com/document/d/1fuII5EhFAQMtYpSBOLPgWPLuQ0cQUgHVUbmSjrtMUJE/edit?usp=sharing

My working doc: https://docs.google.com/document/d/1iN-FV-JsS1kial7wza7GG4Vu4jA0KfaXaxz5a0lrYcU/edit?usp=sharing

In the interest of reducing duplication, I am closing this out in favor of the related documentation issue referenced above. This seems like primarily a doc problem.


[10.x] Add suport to streamed responses in APIResources

Based on this discution #50242 and this pull request #49873:

I was taking a look at pull request https://github.com/laravel/framework/pull/49873, and I identified a feature that would be very useful in the APIResources that already exist.
I generally do the following in my controllers:

public function index(IndexRequest $request)
    {
        $query = Client::with(['user', 'address']);

        return ClientResource::collection($query->get());
    }

And in some entities it may take time to start transmitting data to the user.
I believe it is plausible to add the StreamedResources functionality to the API Resources, especially in the static ::collection() function. I don't think it's a difficult addition.

And by coding a little in the library in a project I arrived at a good construction of a StreamedResource while still maintaining support for existing functionality.
I believe it would be a good addition to completely transform the APIResource to only return StreamedJsonResponses, as it would make it possible to use generators within Responses, like so:
class ClientResource extends JsonResource
{
    /**
     * Transform the resource into an array.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return array
     */
    public function toArray($request)
    {
        return [
            'id' => $this->id,
            'address' => new AddressResource($this->address),
            'name' => $this->name,
            'email' => $this->email,
            'birthday' => $this->birthday,
            'contacts' => $this->yieldContacts(),
        ];
    }

    protected function yieldContacts(): Generator
    {
        foreach ($this->contacts()->cursor() as $contact) {
            yield new ContactResource($contact);
        }
    }
}

I think it needs a little more refinement before a APIResource only return StreamedJsonResponse. So in this pull request only add the possibility of returning streamed responses if the toStream() function is defined within the Resource class. And I also added the toStream() function to the AnonymousResourceCollection class, which I believe will not affect existing code and will even improve memory usage.
Tell me if it needs any change.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


terraform-providers: support dependencies

Issue description

I think the update script needs updating as it currently assumes that providers do not have dependencies.

from: https://github.com/NixOS/nixpkgs/pull/63463#issuecomment-503266614

@kalbasit while being at it, you could probably pick up https://github.com/NixOS/nixpkgs/pull/57026 :-)

I am able to build terraform-providers.{ansible,matchbox} on master, so I don't think this is an issue currently. Closing.


ironSession as a Next Middleware

[QUESTION]
Hey. I Just upgraded my app from next-iron-session to  iron-session.
But one thing i had before and i could not cleanly refactor with was using iron-session as a next-connect middleware.
Before i could simply declare this function:
import { ironSession } from 'next-iron-session';
export const withSession = ironSession(sessionConfig);

And use middleware (express/connect) like pipes via 'next-connect' no problem like:
route
  .use(cors)
  .use(logger)
  .use(drugs)
  .use(withSession) // <- HERE
  .post(CreateSomethingHandler);

I really like this style, so if im missing something on how to use it now let me know.
i tried the export from import { ironSession } from 'iron-session/express'; but doesn't work, probably cuz im in next, so not really express.

Hey @itsmelion could you create a small example so I can try it online?

Sure!
I did this sandbox with all ways i tried to declare a route with session.
Only one of them is working for me.
https://codesandbox.io/s/busy-sound-s5n05?file=/middlewares/withSession.js
worth noting that on my project, currently<EMAIL_ADDRESS>the export mentioned here in the Readme is not present:

Hey there @itsmelion the documentation was updated, you should be using:
import { ironSession } from "iron-session/express";

Even in your Next.js code, this should be working, if not let me know what needs to be updated from your point of view.

I'm also using next-connect and
import { ironSession } from "iron-session/express";

worked!

@vvo thank you, this is good but why not export it from /next instead?

@deadcoder0904 This is really an Express middleware that happens to work in different environments like next-connect. But this is not a Next.js middleware since Next.js has no middleware pattern like Express (req, res, next)

oh cool, that makes sense!


Load python backend models when pytriton starts

Is your feature request related to a problem? Please describe.
We would like to load exiting triton model repository with a few python_backend models when we start pytriton. We would like to do this in colab.
Describe alternatives you've considered
We can potentially run a docker to spin up a triton server, but it's in colab where we can not run docker.
@ctr26

@oeway @ctr26 Could you describe how your use case differ from loading the models in main Python thread, where Triton() object is created, instead of using the Python Backend models? Each model can be bind as separate inference callable in PyTriton. Would in such case models be available in colab?

Thanks for explanation @oeway. Yes, you can use your own model repository path in TritonConfig which I see fill the need. Closing in such case.


Package manager leaves dependencies behind after otherwise successful conversion

After a successful, otherwise trouble-free conversion, the package manager leaves an issue:
# package-cleanup --problems
Last metadata expiration check: 0:10:06 ago on Thu 21 Mar 2024 10:58:51 AM CET.

 Problem: problem with installed package leapp-upgrade-el7toel8-1:0.16.0-6.el7.elevate.19.noarch
  - nothing provides leapp needed by leapp-upgrade-el7toel8-1:0.16.0-6.el7.elevate.19.noarch from @System
  - nothing provides python2-leapp needed by leapp-upgrade-el7toel8-1:0.16.0-6.el7.elevate.19.noarch from @System
  - nothing provides leapp-framework >= 2.2 needed by leapp-upgrade-el7toel8-1:0.16.0-6.el7.elevate.19.noarch from @System

# rpm -q  leapp-upgrade-el7toel8-1:0.16.0-6.el7.elevate.19.noarch
leapp-upgrade-el7toel8-0.16.0-6.el7.elevate.19.noarch

Is it advised to remove that package? What would the best practice command be?

It seems that several post-upgrade steps are not performed. Described in https://access.redhat.com/documentation/de-de/red_hat_enterprise_linux/8/html/upgrading_from_rhel_7_to_rhel_8/performing-post-upgrade-tasks-rhel-7-to-rhel-8_upgrading-from-rhel-7-to-rhel-8


Move API from Parmyay into its own repo.

Since the Parmyay and Parmyaymobile will both be presumably using the same API, I think it is appropriate to have it moved into its own repo.

Yes! We definitely need to do this with the new addition of a mobile
platform
On Apr 3, 2017 4:47 PM, "CaptainAchilles"<EMAIL_ADDRESS>wrote:

Since the Parmyay and Parmyaymobile will both be presumably using the same
API, I think it is appropriate to have it moved into its own repo.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MrCeleryman/Parmyaymobile/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AE-ewJxyCw0CHT4_UMMIXd9g_YajBqiHks5rsJYHgaJpZM4MxJgs
.

Should we move the web to its own repo and leave the api in Parmyay and make Parmyayweb?

I think moving the web to its own repo is a better option.

Ok I will make an issue on the Parmyay Repo to move the Web to a new Repo called Parmyayweb and also create that repo in the process 💃


Bug - Minor - Chrome browser - Trucks: Anthem: Specs - Line above the Base Configurations slightly overlaps the Truck image

On the Trucks: Anthem: Specs page, the line above Base Configurations slightly overlaps the truck image
Steps to reproduce:

Open https://develop--vg-macktrucks-com-rd--netcentric.hlx.page/trucks/anthem/specs/ on Chrome browser
Notice the line overlapping the image

Expected result
Line should be just below the image
Actual result
The line above Base Configurations slightly overlaps the Truck image

#92

@cogniSyb @DanielaPedrochevd same for this ticket, since it's a bug on the live website can it be moved to the Franklin board

still present and on Live

Please remove this from the redesign board

Closing this ticket as we have moved it to the Production board.


conflicts

Closes #

Changes

Flags

Screenshots or Video

Related Issues

Issue #
Pull Request #

Author Checklist

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to master from fork:branchname

Pull Request Test Coverage Report for Build 783424648

0 of 20 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 92.581%

Totals

Change from base Build 780350712:
-0.08%

Covered Lines:
845

Relevant Lines:
905

💛  - Coveralls


React router with lazy loading

Hello, I'll describe my current problem, I'm trying to implement the lazy loading feature into my project, for the moment I was unable to make it work, I'll leave the important pieces of my code:
webpack.config.js
loaders: [
      {
        test: /\.(js|jsx)$/,
        include: [paths.appSrc],
        exclude: [paths.appSrc+'/components/collateral'],
        loader: 'babel',
        query: {
          cacheDirectory: findCacheDir({
            name: 'react-scripts'
          })
        }
      },
      {
        test: /\.(js|jsx)$/,
        include: [ paths.appSrc+'/components/collateral' ],
        loaders: ['bundle?lazy', 'babel']
      }
   // ...rest of config..
]

router:
import React from 'react';
import ReactDOM from 'react-dom';
import { Router, Route, IndexRoute, browserHistory } from 'react-router';

import App from './App';
import Explorer from './components/collateral/Explorer';
import Balance from './components/collateral/Balance';

function getLazyComponent(component) {
    return  (loc, cb) => {
        component(comp => {
            cb(null, comp.default || comp)
        })
    }
};
 // ... some code

<Router history={browserHistory}>
        <Route path="/home" component={App}>
                <Route path="/collateral" getComponent={getLazyComponent(Explorer)} />
         </Route>
 </Router>

now, as you can see I'm trying to render the component "Explorer" which I modified to show the code here:
import React from 'react';
import Balance from './Balance';

export default class Explorer extends React.Component {

    // ...rest of the code..

    render() {
        return (

                <Balance />

        );
    }
}

and this is the Balance
import React from 'react';

export default class Balance extends React.Component {

    render() {
        return (

 some random text with balance

        );
    }
}

now, when I call http://localhost:3000/collateral trying to access the Explorer component I get this error:
Uncaught TypeError: cb is not a function
    at eval (Balance.js?./~/bundle-loader?lazy:3)

but if I modify the router to point directly to the balance it works (I mean this):
<Route path="/collateral" getComponent={component(Balance)} />
or another solution that I found was to remove the Balance component from the Explorer and replace it with something.....
so the problem is when we have some component inside one component called async, right? how can I solve this? maybe the problem is the function getLazyComponent which is not resolving the component inside Explorer.
I hope you can help me, thanks.

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


Added custom error pages

Fixes Issue
Feature added as mentioned in issue #75
Changes proposed

Added error page to handle 404 error code
Error page added to handle internal server error

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots
Page displayed when some internal error occurs

Page displayed when a 404 error occurs (dark mode)

Page displayed when a 404 error occurs (light mode)

Additional: Do we need a 500 - gif for darkmode?
All in all it's a pretty nice implementation!
Just out of curiosity, where did you get the gifs from? :)

I guess when a 500 (Internal error occurs) there no state information for dark or light mode although i am not confident on this.  It only render the default error that i replaced with current one.
I found these gifs on tenor.com, had to edit them for dark and light mode.


Not receiving OnText messages

I was just trying the examples.  I've created a group and added the bot. I provide the bot token to
	b, err := tb.NewBot(tb.Settings{
		Token:  token,
		Poller: &tb.LongPoller{Timeout: 10 * time.Second},
	})

The bot is behind a NAT firewall but it does receive the /help just fine.
	b.Handle(tb.OnText, func(m *tb.Message) {
		fmt.Println("text")
		b.Send(m.Chat, m.Text)
	})

	b.Handle("/help", func(m *tb.Message) {
		fmt.Println("help")
		b.Send(m.Sender, "HELP!!")
	})

But I am not getting any OnText messages for an "echo" example.
What am I missing?

Seems like I am receiving OnText messages when I use /foo - but not foo.
Why is that? Are only Commands supported?
Is there no way to receive the messages that get posted to the group the bot is part of?

Nevermind - I forgot to disabled privacy mode :)


[Feature Request] Make installing modal dependancies in image optional

Hey!
I've noticed that currently in Image._registry_setup_commands (https://github.com/modal-labs/modal-client/blob/b6f889afc43807f009b8677fc3adb778e44ed020/modal/image.py#L1074) you add extra lines to docker file to install modal + it's deps. In cases when everything is already installed this simply leads to extra build time + adds few extra MB to the image size due to pip cache.
Would it be possible to make it optional? Either through env var or through some flag?

By the way, our Images disable the pip cache be default. Are you observing otherwise?

Thanks for a quick response. Regarding the pip cache - i've double checked, you're right, the cache is disabled. Regarding making it optional - it's for the case when the modal is already installed in the image and this step is unnecessary.

okay, not it makes sense. Closing the issue


Apply the changes proposed by the linter on the main branch

Hi,
It seems like the code on the "main" branch does not pass the make check command.
This pull request corrects this.
Have a nice day!

Sorry, I think I got these errors because I had installed Ruff 0.3.7 instead of Ruff 0.3.4 for some unknown reason.
Therefore, errors will not appear for now, but the next time Ruff is updated, they will.

Fixed with Pynguin 0.37.0, thanks for the fix!


Implement Telemetry to Enhance Library Development and Optimization

Implement a telemetry system within AgenticJS to collect data on agent usage and performance. This data will be instrumental in driving library enhancements, optimizing performance, and ensuring that the library meets the evolving needs of the development community effectively.
Problem to Solve:
Currently, there's a lack of detailed data on how agents are used and how they perform in various environments, which can hinder targeted improvements and optimizations in the library. Implementing robust telemetry will allow us to gather essential insights that are critical for refining and advancing AgenticJS.
Advantages of Implementing Telemetry:

Informed Library Development: Data collected will directly inform decisions about library enhancements, bug fixes, and performance optimizations.
Enhanced Performance Insights: Understand performance bottlenecks and usage patterns to better tailor the library to user needs.
Proactive Issue Resolution: Identify and address potential issues before they impact users, based on trends and anomalies detected through telemetry.

Goals:

Establish a comprehensive telemetry infrastructure that captures detailed metrics on agent operations.
Use telemetry data to guide library development priorities and resource allocation effectively.
Develop tools and dashboards for the internal team to monitor and analyze telemetry data easily.

Implementation Steps:

Define the specific metrics and events that are most valuable for library development and user experience enhancement.
Design the telemetry system to integrate seamlessly within the AgenticJS framework without impacting agent performance.
Implement analysis tools and dashboards that allow the development team to visualize and interpret the data for actionable insights.

Testing:

Rigorously test the telemetry system to ensure data accuracy and reliability.
Validate that the telemetry collection does not degrade agent performance or user experience.

Documentation:

Document the telemetry system internally for the development team’s use.
Ensure all telemetry practices comply with privacy laws and user consent requirements, where applicable.

By integrating this telemetry system, we aim to enhance the AgenticJS library's capabilities and ensure it remains a robust and effective tool for developing AI agents.

Solved by #95


Handle errors from server

Coverage increased (+0.6%) to 27.652% when pulling 114815308eb36661d6444533a4428327d1c76fdb on handleErrorsFromServer into 7ae3c6f2e35043077ba7922e70213795f5673aa3 on development.


OnDemand Follow-on: Optimize how clients request tablet hosting

Clients interact with tablets in a serial manner. For example, a Scanner or BatchWriter will interact with a Tablet and then when done it will interact with the next Tablet. Watching the output from the tests, the TabletLocator will request that a Tablet be hosted in the same manner. This could be optimized up front, where the client tells the TabletLocator that it's going to be working with a Range of keys, and then the TabletLocator in another thread ensures that those Tablets are hosted. In the case where the TabletLocator is waiting for a Tablet to be loaded, it might be possible to return a Future to the caller when the hosting has been completed vs constant metadata table lookups.

@keith-turner  - Can this be closed?