Missing wheels?

On PyPI I see there are many wheels available for 0.7.4, but the latest version only has a wheel for macOS, thus requiring other platforms to build from source, which means they need to have the Python development headers installed, etc. For casual users who are installing some package that depends on marisa-trie, this can be quite a burden.
Is it possible to setup some CD workflow that generates the wheels for various platforms?

This repo hasn't been touched in 2.5 years. Is it still active? Should users move to datrie instead?

(these are just notes for anyone stumbling upon this issue)
After some further digging, it looks like libdatrie doesn't work well with unicode, which is important for my use case. DAWG looks promising, but it also has a lack of prebuilt wheels except for macOS. I guess the options are to distribute the DAWG-built tries DAFSAs and use the pure-Python DAWG reader, or a pure-Python solution like pygtrie (or require users to build the extension modules from source).

FTR I forked the repos (https://github.com/BoboTiG/marisa-trie) and there are now wheels for all platforms.

There is also https://github.com/rushter/marisa-trie (marisa-trie-m on PyPI), which is what https://github.com/LuminosoInsight/language_data switched to. The language_data repo, or rather langcodes before the data was split out, is why I created this issue in the first place. It looks like your repo has more work done after the fork than this other one, but is there a reason to use one over the other?

If it works for you, I do not think you should change something. I wanted to have wheels and did not had a look at that repos first,  my repos simply ships wheels for all platforms and it seems the most up-to-date version out there.
I'll keep it updated if someone wants to open PRs, so it may be a good fit for the future. I do not try to sell it, just a reminder for those looking for alterntives :)


Root React component is not observing changes in store

In version 5.1.2, This piece of code does not work (the store changes its values but the App component does not trigger a rerender)
@observer
class App extends Component {
  render = () => (
    <div className="app container-fluid">
      {this.props.store.auth.status === 'authenticated'
        ? <p> Hello, world </p>
        : <p> We're not ready yet </p>
      }
    </div>
  );
}

document.addEventListener('DOMContentLoaded', () => {
  ReactDOM.render(
    <App store={ AdminStore }/>,
    document.querySelector('#app'))
});

When I roll back to version 5.0.0, everything works as expected: Once I trigger any action that changes the auth.status in the store, the component renders the 'Hello, world' message.
Additional info:

React version: 16.4.0
Mobx version: 4.3.0

Don't use arrow function with render. More info here: https://github.com/mobxjs/mobx-react/issues/473

Thanks. I'm closing this now.


Add option to ignore pluralize option per field

Original model:
model Model {
  id               String   @id @default(cuid())
  columnsSingular  String[]
}

After running prisma-case-format -p:
model Model {
  id                String     @id @default(cuid())
  columnsSingulars  String[]   @map("columns_singulars")
}

The only way to prevent this is by adding the following to .prisma-case-format:
Model:
    field:
      columnsSingular: disable

But this disables all formatting on the following field as I'd like to keep the option of mapping e.g. camel case to snake case.
Something like this would be great:
Model:
    field:
      columnsSingular: 'pluralize=disable'

I swear this is possible today, let me look through the code for a moment and get back to you but if it's not possible then yes I agree let's support this

@antonioorct I have two solutions that you might explore:
1: using !
Model:
  field:
    columnsSingular: 'mapField=!columns_singular'

The exclamation point tells the mapField to "use this exact value".
2: using ,singular
Model:
  field:
    columnsSingular: 'mapField=snake,singular'

This says "use snakecase with a singular plurality convention when trying to map this field"
This works, because case-convention syntax is always:
(snake|pascal|camel)[,(singular|plural)]

Also, a plural=disable would probably be equivalent to specifying ,singular

@antonioorct another thing you could do that would help me to help you is to clarify, explicitly, what your desired outcome is: right now, it's still a bit ambiguous and unclear which of the following you want to occur:
columnsSingular   String[]   @map("columns_singular")     // both field & mapField singular
columnsSingulars  String[]   @map("columns_singular")     // mapField singular
columnsSingular   String[]   @map("columns_singulars")    // field singular

I'm running prisma-case-format --pluralize because I want to pluralize array fields, but I have a field I want ignored.
I've tried both of your solution and neither of them worked and I've also tried various combinations of field, mapField and similar with also explicit naming ! and that also didn't work.
Essentially I want the field name to be forced to singular
I want the following to be the final output:
columnsSingular   String[]   @map("columns_singular")

https://github.com/antonioorct/prisma-case-format-test
I've created a reproducible example in this repository:
npm install
npm run format-prisma

I've set field=camel,singular but running with --pluralize ignores that, sets the field to be plural but the mapped field remains singular.

Okay, I'll be able to get to this issue by Tuesday next week at the earliest. I think you're probably right that this is broken slash an oversight in needed functionality

Hey @antonioorct, please install<EMAIL_ADDRESS>and give it a test. You should be able to do any of the following columnsSingular paradigms:
default: 'field=camel; table=pascal; enum=pascal; pluralize=true'
override:
  Model:
    field:
      columnsSingular: 'mapField=snake,singular'
      columnsSingular: 'mapField=snake; pluralize=disable'
      columnsSingular: 'mapField=!columns_singular' # this will preserve pluralization

Additionally, you can now specify -p at the command line or embed it in the config file. Up to you.

closing due to inactivity.


Pollution Filter settings?

I can't find the pollution filter settings in any of the config files, probably my own fault but if you wouldn't mind pointing me in the right direction I'd like to adjust it.  They don't seem to have any effect in my world at the moment and I've put them next to everything I didn't destroy already.

I found it, sorry bout that.


Add public constant for asctime format string

https://github.com/ruby/ruby/blob/v3_1_2/time.c#L3975-L3990
Add a public constant for the asctime format string from Ruby and time.h in C. This constant should have docs, an examples section that shows the formatted output, and tests.

This is the same as the %c specifier.

Awesome. I still think I'd like a named constant as part of the API to make it a bit more obvious how to replicate the asctime C API.


[1pt] Create Music and genre class

Create MusicAlbum class in a separate .rb file.
Create Genre class with an association to the Item class (in a separate .rb file).

Closing this issue as this task has been completed in Pull request No. 36


Feature/ub 392 align glide versions

This change is

There seem to be some problems with this review (changes that were not intended, possibly merge issues). Will open another PR instead.

@alonm  what is this PR?   is it still relevant? if not please close it without merging

these changes were implemented in another pull request and merged. closing..


I'd love to have this for Visual Studio

Please include the language you are using, a screenshot, and copy/pastable example.

Duplicate issue

Duplicate issue


Enahnce/integrate docs

Here's a stab at doing the docs integration for SC. I've tested the basic CMake bit locally, and I guess the CI will let us know if that bit works presently...

Ah, can't run the workflow from a fork. Going to close and push to origin (this once) instead


String references should be nullable

Describe the bug
The following struct:
type Response struct {
    Field *string `json:"field"
}

generates:
"definitions": {
  "Response": {
    "type": "object",
    "properties": {
      "string": {
        "type": "string"
      }
    }
  }
}

To Reproduce
Steps to reproduce the behavior:
Full Code for the repro
package main

type Response struct {
	Field *string `json:"string"`
}

// @Success 200 {object} Response
func HandleStuff() {
}

Expected behavior
I expect to see either: "type": ["string, "null"] or "required": true field. A reference to a string (or anything) will create a null value when serializing to json
Your swag version
e.g. 1.16.2
Your go version
go version go1.21.1 darwin/arm64
Desktop (please complete the following information):

OS: mac
Browser: chrome
Version: 119

Additional context
Add any other context about the problem here.

type Response struct {
    Field *string `json:"field" extensions:"x-nullable"`
}


Move GpuPartitioning to a separate file

GpuPartitioning is oddly in the Plugin.scala file which is not where most would expect to find it.  There's enough logic there to warrant having its own file, and I have some upcoming changes to partitioning.  I thought it'd be better to move it now rather than as part of those changes to make the upcoming partitioning changes easier to read.
This also removes the unused GpuSpillable trait which I stumbled across during the refactor.

build


Retro-adding serialisation override breaks things

To implement one single persistence (DocumentDb), this line was added and now each time any instance of ISaga is serialised, it gets id field instead of CorrelationId, no matter if I want it or not.
https://github.com/MassTransit/MassTransit/blob/0086b67dc0133e21065351a45c5070e93bd37c89/src/MassTransit/Saga/ISaga.cs#L30
I don't think it was a good idea. @maldworth please consider doing it somehow differently.

Ouch, yeah, I can't believe I missed this on the merge - putting that on the base interface is a bad idea. Let's figure out how to get this out without breaking DocumentDb - surely the mapping can add it without the JSON tag.

The test uses this attribute explicitly on the saga class. I think it can be just solved by the documentation - "if using DocumentDb, ensure to decorate the CorrelationId with this ...."

I think if I remove the attribute from that interface, tests will still pass:
https://github.com/MassTransit/MassTransit/blob/0086b67dc0133e21065351a45c5070e93bd37c89/src/Persistence/MassTransit.DocumentDbIntegration.Tests/Saga/Data/SimpleSaga.cs#L32

Well, I think DocumentDb needs this to be called "id" for the behavior to work as a primary key. So I'm hoping there is an easier way to do this automatically in the saga repository.

1.22.0
Added ConsistencyLevel Property to FeedOptions.
Added JsonSerializerSettings to RequestOptions and FeedOptions.
Added EnableReadRequestsFallback to ConnectionPolicy.
https://docs.microsoft.com/en-gb/azure/cosmos-db/sql-api-sdk-dotnet#release-notes
Should be possible

I think we need to fix it by removing this attribute from the interface. For Marten, it is written in the docs that you gave to put an attribute on your saga instance http://masstransit-project.com/MassTransit/advanced/sagas/persistence.html#marten and I never heard people complaining. It should have been done in the same way.

Can we put something on the configuration for the saga repository that a saga without the attribute on that property throws an exception or configuration error, to avoid seeing the issue creep up without warning?

We could create an interface, IValidateSagaRepository, or something, that would optionally be supported by a saga repository, and if supported, would allow the configuration to assert if the saga is properly typed for the repository. It could be called by the saga specification on the repository if present to ensure that any required features are present.

I am adding Json options to DocumentDb persistence now. If it works - this issue could be closed and we can do the validation for other persistence drivers.

Right on, I'll wait for you changes 👍

Ok, it seems to be working, assuming that tests are covering everything.


Instances in drain due to enroot directory permissions

I ran into the following issue when standing up a cluster with pyxis/enroot:
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: couldn't execute enroot command
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: printing enroot log file:
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis:     /usr/bin/enroot: line 44: HOME: unbound variable
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis:     mkdir: cannot create directory '/opt/dlami/nvme/tmp/enroot/data': Permission denied
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: couldn't get list of existing containers
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: couldn't cleanup pyxis containers for job 2
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: spank: required plugin spank_pyxis.so: job_epilog() failed with rc=-1

Is there a reason the following lines are commented out?
https://github.com/aws-samples/awsome-distributed-training/blob/3c92cd61b1419e303609ea12eb81307556c9a8e3/1.architectures/5.sagemaker-hyperpod/LifecycleScripts/base-config/utils/install_enroot_pyxis.sh#L76C1-L77C1

If you see a node in drain do the following:
$ ssh <ip-of-effected-node>
$ sudo systemctl status slurmd # make sure error matches error above.

$ chmod 777 /opt/dlami/nvme/tmp/enroot/data
$ sudo systemctl restart slurmd # make sure error went away
# on the headnode:
$ sudo scontrol update nodename=ip-... state=idle

Will uncomment. It was working fine on my SMHP clusters hence commented out.

encountered this issue today, present on every compute node of a newly created 16 node cluster.
Thank you @sean-smith for debugging steps.
We ran a script to allow permissions to chmod 777 /opt/dlami/nvme/tmp/enroot/data on all the compute nodes and restart slurmd. This fixed the issue.
$ chmod 777 /opt/dlami/nvme/tmp/enroot/data
$ sudo systemctl restart slurmd # make sure error went away

I'm curious why I didn't see this permission error, even as I use the old, commented-out version. Did the error happen during LCC, or when running a container job?

During a containerized job and only when the status of slurmd is examined. It lead to job failures with weird error messages like:
torch.distributed.DistBackendError: NCCL error in: /opt/conda/conda-bld/pytorch_1699449201450/work/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1333, unhandled system error (run with NCCL_DEBUG=INFO for details), NCCL version 2.18.6
ncclSystemError: System call (e.g. socket, malloc) or external library call failed or device error.
Last error:
socketStartConnect: Connect to <IP_ADDRESS><60369> failed : Software caused connection abort

When we investigated and checked systemctl status slurmd we saw:
$ systemctl status slurmd
...
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: couldn't execute enroot command
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: printing enroot log file:
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis:     /usr/bin/enroot: line 44: HOME: unbound variable
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis:     mkdir: cannot create directory '/opt/dlami/nvme/tmp/enroot/data': Permission denied
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: couldn't get list of existing containers
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: pyxis: couldn't cleanup pyxis containers for job 2
Feb 16 19:30:06 ip-10-1-101-117 slurmd[53634]: spank-epilog: error: spank: required plugin spank_pyxis.so: job_epilog() failed with rc=-1

Noted, and thanks for the details.
Looks similar to this https://github.com/NVIDIA/pyxis/issues/123


Configure mass storage and add scripts for mounting

I was familiarising myself with configfs and mounting a mass storage today. (So far it’s the basic setup and a script for mounting a flash drive, but it’s all still WIP.)
One question I was running into: we want to support both CD-ROM and flash-drive mode, right? (See the cdrom option.) Just double-checking, because CD-ROMs seem to be a bit more “unruly” code-wise, so e.g. swapping out the backing file appears to require rebinding the gadget to the UDC, see here. Not super bad, but in case we wouldn’t want it it’s a bit simpler.

Ah, and another question (sorry if we had discussed that already): is mass storage pro-exclusive or community as well?

Yeah, this is for Pro. Can we move the PR there?
Also, could we include an example command in the header comment for mass-storage-mount? I'm not clear from the description what kind of argument we pass to the script.


Update to 1.20.2

Also bumps the version of MixinExtras to 0.2.0-rc.5, as it's causing issues to mods that are using the release candidate versions of MixinExtras

Looks perfect to me, thanks a ton!
I'll run a few tests and prepare a release.


Exception should not be swallowed when creating command instance

🎉 Feature Request
using exception chaining
Summary
https://github.com/php-telegram-bot/core/blob/46646884f5c05f1161f10605a0705aa24df3e583/src/Telegram.php#L252
this line may be changed to
throw new TelegramException('Error getting commands from path: ' . $path, $e);
attach the original exception can be provide more information to the developer.

@CyberKoo Thanks for the suggestion, this is a good idea!
Feel free to make a PR if you like :+1:


Preserve geometry when transforming CZML entities

CZML entities like boxes can be optimized so that they don't recreate their geometry during translation/rotation/scale animations. This would help speed up czmls containing a large number these entities.
Example CZML - you can check in the debugger that a new BoxOutlineGeometry is created per frame.

Ellipsoid already does something like this.  We should be able to apply the same logic to boxes and cylinders.

Yep, I mentioned this to @lilleyse offline.  It won't even be that hard to do, you can just use the DynamicGeometryUpdater in EllipsoidGeometryUpdater as a template.


How to access the access token from GoogleApiClient for connecting with REST Api

Hi,
I am trying to fetch the access token on the android device after the user authorise and then send this access token to my backend server so that we can fetch steps data using Google Fit Rest API.
I have tried this code to get the token after the connection is established:
// in GoogleFitManager inside **onConnected** callback
GoogleSignInAccount gsa = GoogleSignIn.getAccountForScopes(mReactContext.getApplicationContext(), new Scope(Scopes.FITNESS_ACTIVITY_READ));
new RetrieveTokenTask().execute(gsa.getEmail());

// --------------- //
private class RetrieveTokenTask extends AsyncTask<String, Void, String> {

        @Override
        protected String doInBackground(String... params) {
            String token = null;
            String accountName = params[0];
            String scopes = "oauth2:https://www.googleapis.com/auth/fitness.activity.read";
            try {
                token = GoogleAuthUtil.getToken(mActivity.getApplicationContext(), accountName, scopes);
            } catch (IOException e) {
                Log.e(TAG, "IOException");
                Log.e(TAG, e.getMessage());
            } catch (UserRecoverableAuthException e) {
                Log.e(TAG, "User recoverable auth exception");
                Log.e(TAG, e.getMessage());
            } catch (GoogleAuthException e) {
                Log.e(TAG, "Google auth exception");
                Log.e(TAG, e.toString());
            }
            return token;
        }

        @Override
        protected void onPostExecute(String s) {
            super.onPostExecute(s);
            Log.d(TAG, "GOOGLE FIT TOKEN: " + s);
        }
    }

My problem is getEmail() is always returning default-account as value (not the actual email address used) which is causing the getToken call to fail. If I hard code account name to my email id then this works and I can access data using the Rest API. But I cannot get the user's email id this way.
Is there anyway to access the email id or the access token from the GoogleApiClient ?
Thanks

I would also like to know this

@StasDoskalenko : Any help on this ?

hey @im-aditya , Did you get any solution for an email address or access token?
i have same issue like you.

@Dhaval240420 : Nope

Hello @aboveyunhai @StasDoskalenko  Any help on this ?

@patelrushabh Unfortunately, I did try to implement this feature in the past. After going through the entire google android api doc with all the possible hacky ways. It seems like it's simply impossible without the default Signin method and .requestEmail() etc.
https://github.com/react-native-community/google-signin <<<=== the default signin package. Then through some ways if we can SAFELY share the sign in account from both packages. There are a lot of configs with that package.
https://developers.google.com/identity/sign-in/android/people<<< Then we can simply get all infos through the simple code from this link.
No matter what, it's required or better to completely rewrite the deprecated code to standard api especially the current api connection part , and if possible we can integrate the default sign in, but this simply excess my current abilities, Or hopefully I'm completely wrong and some experts can facepalm me

Hey @aboveyunhai thanks for response and suggestion.
I get user data with the help of https://github.com/react-native-community/google-signin
i use GoogleSignin.configure() and signInSilently() method. after google fit authorization.
getCurrentUserInfo = async () => {
try {
  const userInfo = await GoogleSignin.signInSilently();
  this.setState({ userInfo });
} catch (error) {
  if (error.code === statusCodes.SIGN_IN_REQUIRED) {
    // user has not signed in yet
  } else {
    // some other error
  }
}
};

@patelrushabh  Good to hear, if account is already shared by default then probably it's no need to reinvent the wheels. I will try it later

@patelrushabh based on what you mention, I just go through https://developers.google.com/android/reference/com/google/android/gms/auth/api/signin/GoogleSignInClient,
and successfully implement the getUserInfo() from the existing package. So probably we don't need to install other packages just for getting some account info. Just no sure if there is any side effects.

@patelrushabh Probably my last update. Indeed there are some side effects if we don't carefully signin and signout the account from the app, which can lead to some undesired behaviors and bugs. And I will eventually end up reinventing the Signin package in order to solve those edge cases, which it's not my intent and the intent of this packages. So it's better to just use other package to retrieve user info, just don't forget to do signout from both packages.

Okay Thank you! @aboveyunhai
can we stop step counting when user close application with this package ?  I want step counting only when app is in background and open.
what is use of google fit disconnect() ? does this help me to stop step counting when app is close ??

Okay Thank you! @aboveyunhai
can we stop step counting when user close application ? I want step counting only when app is in background and open.
what is use of google fit disconnect() ? does this help me to stop step counting when app is close ??

It signs out from current account but seems like did not unsubscribe from service subscription if you are using recording api.

hii @aboveyunhai are you working on unsubscribe service of recording api ??

Is there any update on this? I need the server auth code for my backend server.

Hi @patelrushabh,
I have tried that calling   GoogleSignin.signInSilently() after selecting email after that I am not getting Userinfo.
on GoogleSignin.configure() i am giving only webClientid and offlineAccess as false.
can you help me to get userinfo after google fit authorization?

@Karthiksheety  have you added scope ? 'https://www.googleapis.com/auth/userinfo.email' , 'https://www.googleapis.com/auth/userinfo.profile'

@patelrushabh i had given https://www.googleapis.com/auth/userinfo.profile on scope.
`await GoogleSignin.configure({
scopes: ['https://www.googleapis.com/auth/userinfo.profile'], // what API you want to access on behalf of the user, default is email and profile
webClientId: '287799221164-7gk256hpc5l4c0u52r60q8ram51tgu11.apps.googleusercontent.com', // client ID of type WEB for your server (needed to verify user ID and offline access)
offlineAccess: false, // if you want to access Google API on behalf of the user FROM YOUR SERVER
});
		try {
			const userInfo = await GoogleSignin.signInSilently();
			console.log('inside',userInfo)
		} catch (error) {
			if (error.code === statusCodes.SIGN_IN_REQUIRED) {
			// user has not signed in yet
			} else {
			// some other error
			}
		}`

@Karthiksheety have you try with adding scope in await GoogleFit.authorize(ScopeOptions) ?

@Karthiksheety  since the question relates to another package, I highly recommend you read through the documentation from that package and the related issues to see how to use that package properly. I used the package successfully in the past without mixing or hacking around two packages. You probably want to find solution in signin package instead of here.

Recently when I try to add some new functionalities,
I tried to twist some old/deprecated AUTH codes from fewer years ago,
With the new/standard AUTH implement, I was able to get all the user profile info (email, id, etc.) but does not include token with only fewer lines of configs. Most importantly, it can cut down the codebase by 30%.
So I am going to reopen it. but it may not happen.

@aboveyunhai
I have a somewhat of a workaround here. But it should work along with GoogleSignIn.
I needed to know the idToken of the google fit user in the app that I am developing because we store that token in db as a anti-cheat system because we need to know if a user uses his friend's google fit account to get the health data and receive rewards from the app.
Because the app also has google sign in, I ended up creating a solution like this:
const permissions = {
  scopes: [Scopes.FITNESS_ACTIVITY_READ, Scopes.FITNESS_HEART_RATE_READ],
};

const connect = () => {
      // ... some code...

      await GoogleFit.disconnect();

      const isSignedIn = await GoogleSignin.isSignedIn();
      if (isSignedIn) {
        await GoogleSignin.signOut();
      }
      await GoogleSignin.signIn();

      await GoogleFit.authorize(permissions);

      const idToken = await GoogleFit.getUserToken();
      // store idToken in db...
}

It's not the most fancy solution, but since I know the Google Fit API itself doesn't provide any help, I added a function getUserToken() in a local fork of this lib. The function and returns the last signed in account which corresponds to the one connected account from signin(). The google-fit library seems to take this account(from googlesignin) and use it for it's functionalities, but if I signout from the account, signin again with another account, the account that the library uses for health data retrieval is the old one, not the new connected one - thus I added the await GoogleFit.disconnect(); in the beginning so that it always uses the last account logged in googleSignin. I am not sure why it behaves like this, it's somewhat odd... maybe you know better.
There's another odd behavior. If I sing out of googleSignin but not sign in again, then call the authorize function, and then call the getUserToken, the idToken is null even though the authorize was successful and probably the health data retrieval will be as well. So it's a bit confusing because the GoogleFit library takes in the account from googlesignin, however, if there is no account in googlesignin, it still somehow takes the last one you logged into but the idToken cannot be fetched because it doesn't exist.
I couldn't figure out exactly why it behaves like this but the code above works for me. Every time the user connect to google fit he/she can pick the account and I can save the idToken. You can also get the token from the googleSignin itself via const { idToken } = await GoogleSignin.signIn(); or with the function I made. I can make a pull request with the functionality and add some info in the docs for people that want to use it and explain the necessity to couple it with the googlesignin library used for auth. Please let me know and as soon as I find some time I'll make the PR, or not make the PR and use the example above but with idToken from the googlesignin.


WebTracer - auto instrumentation - plugins

I want to start adding auto instrumentation for WebTracer and as first thing would be simply the document load. But together with this I'm thinking of the architecture and how to structure things.
NodeTracer (TracerSDK)  does this by creating a PluginLoader which is kind of cool and I thought that maybe thats the way to go. Then the first plugin for web tracer would be something like document-load. But then I was also thinking where it should be located. Probably some of the plugins can be shared between node and browser but not all of them. Now we have just opentelemetry-plugin-* and I wonder if that will be appropriate place or we should rather have a separate namespace and then even if some plugins can be shared we can simply reference them. I think that would be a cleaner solution so it will look like:
opentelemetry-plugin-web-* ?
and for the first plugin it would be something like :
opentelemetry-plugin-web-document-load
Any thoughts , objections, suggestions :) ?

The plugins then would be lazy loaded so they won't be bundled together with WebTracer. The Plugin Loader would be responsible for that

Would we then have opentelemetry-plugin-node-* for things that are specific to node?

As it is possible to have some of the plugins shared between node and browser, I would suggest to follow opentelemetry-plugin-* pattern.

We will have more and more plugins in a future and it might be misleading which one is supported in browser only and which one in node only or both. Just looking at repo now we already have 3 plugins for http, are they going be all supported in browser too ?

The 3 that exist are for the Nodejs standard library modules and afaik browser support for them is N/A

Maybe the plugins could be folder organized based on their supported environments: nodejs/opentelemetry-plugin-mongodb, web/opentelemetry-plugin-document-load, js/opentelemetry-plugin-purejslibrary

My main suggestion here is that we don't rely on plugins as runtime objects or any kind of require function usage, since I think that could put limits on how people bundle their code. E.g. webpack, Rollup, Closure, etc. all support ES6 modules but may collapse them down into a flattened code bundle rather than having them as runtime objects.
What if the plugin model looked something like this:
const opentelemetry = require('@opentelemetry/core');
const { WebTracer } = require('@opentelemetry/web');
const { DocumentLoadPlugin } = require('@opentelemetry/web-document-load');
const { UserInteractionPlugin } = require('@opentelemetry/web-interaction');
const { XhrPlugin } = require('@opentelemetry/web-xhr');
const { ReactPlugin } = require('@opentelemetry/web-react');

const tracer = new WebTracer({
  plugins: [
     new DocumentLoadPlugin(),
     new UserInteractionPlugin,
     new XhrPlugin({ hostRegex: '.*' })
  ]
});

opentelemetry.initGlobalTracer(tracer);

This way we are just using the normal import system and passing the plugins to the tracer as objects rather than trying to hook into the module system, which I think is good for Node, but feels hacky in the browser to me.


Update nodelocaldns.md with config steps.

Modify the config steps so that they can be run from anywhere and not reference k8s developer tools/scripts only.
@sftim

As I've understood it, @prameshj, you are OK with the idea of not promoting <IP_ADDRESS> as special.
To achieve that, you should remove all the mentions of that IP address in the page that could lead readers to treat <IP_ADDRESS> specially or to assume that they should run their cluster using that address.
Is that in line with your thinking?

I think the note we have added saying that any ip address would work and that "<IP_ADDRESS>" is just used as an example is fine. It clarifies why we used it in the doc, and also notes that user needs to pick an ip and ensure it does not conflict. I think it is ok to leave the existing references to that ip address. Any reason you think leaving those in might be problematic?

@prameshj, I don't see how to reconcile this wording from the page (as proposed):

a link-local IP (<IP_ADDRESS> by default)

with “"<IP_ADDRESS>" is just used as an example”
Default values are not example values, and it's a good idea to pick example values that don't get confused with defaults.
It seems to me that <IP_ADDRESS> was previously suggested and recommended as an address to use with node-local DNS cacheing, and that this PR doesn't yet do enough tidying up to remove that.
How do you plan to resolve that before the add-on goes GA?

@prameshj, I don't see how to reconcile this wording from the page (as proposed):

a link-local IP (<IP_ADDRESS> by default)

with “"<IP_ADDRESS>" is just used as an example”

I see what you mean.. I removed references to "<IP_ADDRESS> by default" in the doc. could you take another look?

/lgtm

/assign @MrHohn

/approve

Thanks for sticking at this one @prameshj

Thanks @sftim. Would you also be able to approve this?

@prameshj I'd like to leave this for another approver to pick up: it's size/M

/assign @jimangel @makoscafee
Assigning to you both since you had helped review this page when it was added in -  https://github.com/kubernetes/website/pull/14625
Thanks.

Pinging this again since the code freeze is in 2 days, can one of you take a look and approve? Thanks!
@jimangel @makoscafee @sftim

@sftim Could you suggest approvers or help approve this since you have most context of these changes? Thanks so much!

@kbhawkey if you have the cycles, I'd appreciate your eyes on this as well as mine.

Page preview:
https://deploy-preview-18716--kubernetes-io-master-staging.netlify.com/docs/tasks/administer-cluster/nodelocaldns/

Here's a suggested fix; see #18716 (comment)

Thanks Tim!

@prameshj this looks fairly OK to me, and I'm fine with the overall aim of these changes. however, at the moment I'm going to stop short of adding /lgtm.
I wonder: can you get another person from SIG Network to take a look in light of my concerns about documenting use of <IP_ADDRESS>/16? I'd welcome that second perspective.

Adding @bowei to take a look as well.

/lgtm
/approve

/assign @kbhawkey

/approve


Inserting/Deleting cells on iOS 11 causes tableView subviews to be unresponsive

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Description
Inserting/Deleting cells on iOS 11 causes tableView subviews to be unresponsive. The cells become untappable and if you use a header supplementary view, the subviews in there also become untappable.
Scrolling the tableView can also cause this to happen.
Reproducible in:

[x] This is reproducible in the sample project.
SlackTextViewController version: Latest
iOS version(s): 11
Device(s): 6s physical, multiple simulators

Steps to reproduce:

Scroll tableview or insert/delete cell
Click on cell

Expected result:
Cell should be tappable or subviews inside should still respond.
Actual result:
Nothing happens

Experiencing the same thing. When I delete a cell, it does not fully remove itself from the tableview. Anyone have any fixes for this yet? Been nearly a month.


fix(i18n): reverse only locales logic

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[X] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Former PR reversed the logic of only locales. It's not excluding, it's including!
Added one test to document the behavior.
Apologies for the former blunder.

Thanks for the fix 🙂


Lnd, Lndhub...shouldn't appear on accounts menu

I don't think Lnd, lndhub... should appear on Accounts menu. I don't se a reason to show this info to users, and I think more confuse than help.

+1 @johnsBeharry any idea what else we thought of with those badges?

maybe we just remove the badge and see how it is?

Let's try. As long as it's still visible in the account-overview we're good I think.

I put a PR in for this: #916


fix(quran): scroll to last read delay

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix library names being misinterpreted as linker args

When the list of libraries contains non-full library paths like "asan" we would interpret those as linker args and emit rustc-link-arg instead of rustc-link-lib.
Instead assume that linker args always start with a dash, and assume everything else is a library name
Fixes https://github.com/danvratil/cmake-package-rs/issues/26

Do you have an example where CMake's INTERFACE_LINK_LIBRARIES actually contains an argument? Can it actually contain like -lfoo? I made an assumption that it cannot in #28, trying to address the same issue.
Big chunk of the PR is a test that I will commit anyway, since it should pass for both our approaches, you can ignore that.

Do you have an example where CMake's INTERFACE_LINK_LIBRARIES actually contains an argument?

I haven't encountered it in real code. I can write something like "target_link_libraries(foo PUBLIC -Wl,--no-undefined)" and it will build.

Can it actually contain like -lfoo?

I can write CMake code that results in that, yes. "cargo:rustc-link-arg=-lfoo" seems to work okay though, I've seen cxx-qt emit this. Similarly "cargo:rustc-link-lib=dylib=-Wl,--no-undefined" also seems to work, at least it doesn't break here


Shuffle Join Supports shuffle column order adjustment

Enhancement
Different joins maybe different on-clause predicate order, so the order of shuffle key is different, for example
sql :
select
  t0.v1,
  t1.v4,
  t2.v7
from
  t0 join[shuffle] t1 on t0.v1 = t1.v4 and t0.v2 = t1.v5
  join[shuffle] t2 on t0.v2 = t2.v8 and t0.v1 = t2.v7

we will get plan like this
PLAN FRAGMENT 0
 OUTPUT EXPRS:1: v1 | 4: v4 | 7: v7
  PARTITION: HASH_PARTITIONED: 2: v2, 1: v1

  RESULT SINK

  10:Project
  |  <slot 1> : 1: v1
  |  <slot 4> : 4: v4
  |  <slot 7> : 7: v7
  |
  9:HASH JOIN
  |  join op: INNER JOIN (PARTITIONED)
  |  hash predicates:
  |  colocate: false, reason:
  |  equal join conjunct: 2: v2 = 8: v8
  |  equal join conjunct: 1: v1 = 7: v7
  |
  |----8:EXCHANGE
  |
  6:EXCHANGE

PLAN FRAGMENT 1
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 08
    HASH_PARTITIONED: 8: v8, 7: v7

  7:OlapScanNode
     TABLE: t2
     PREAGGREGATION: ON
     partitions=0/1
     rollup: t2
     tabletRatio=0/0
     tabletList=
     cardinality=1
     avgRowSize=2.0
     numNodes=0

PLAN FRAGMENT 2
 OUTPUT EXPRS:
  PARTITION: HASH_PARTITIONED: 1: v1, 2: v2

  STREAM DATA SINK
    EXCHANGE ID: 06
    HASH_PARTITIONED: 2: v2, 1: v1

  5:Project
  |  <slot 1> : 1: v1
  |  <slot 2> : 2: v2
  |  <slot 4> : 4: v4
  |
  4:HASH JOIN
  |  join op: INNER JOIN (PARTITIONED)
  |  hash predicates:
  |  colocate: false, reason:
  |  equal join conjunct: 1: v1 = 4: v4
  |  equal join conjunct: 2: v2 = 5: v5
  |
  |----3:EXCHANGE
  |
  1:EXCHANGE

PLAN FRAGMENT 3
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 03
    HASH_PARTITIONED: 4: v4, 5: v5

  2:OlapScanNode
     TABLE: t1
     PREAGGREGATION: ON
     partitions=0/1
     rollup: t1
     tabletRatio=0/0
     tabletList=
     cardinality=1
     avgRowSize=2.0
     numNodes=0

PLAN FRAGMENT 4
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 01
    HASH_PARTITIONED: 1: v1, 2: v2

  0:OlapScanNode
     TABLE: t0
     PREAGGREGATION: ON
     partitions=0/1
     rollup: t0
     tabletRatio=0/0
     tabletList=
     cardinality=1
     avgRowSize=2.0
     numNodes=0

top join need shuffle key (v2,v1), but the below one need to shuffle on (v1,v2)，the below join node need to shuffle again for get right result,  we could adjust the below join node shuffle columns orders to reduce the shuffle process. plan like this
PLAN FRAGMENT 0
 OUTPUT EXPRS:1: v1 | 4: v4 | 7: v7
  PARTITION: UNPARTITIONED

  RESULT SINK

  10:EXCHANGE

PLAN FRAGMENT 1
 OUTPUT EXPRS:
  PARTITION: HASH_PARTITIONED: 2: v2, 1: v1

  STREAM DATA SINK
    EXCHANGE ID: 10
    UNPARTITIONED

  9:Project
  |  <slot 1> : 1: v1
  |  <slot 4> : 4: v4
  |  <slot 7> : 7: v7
  |
  8:HASH JOIN
  |  join op: INNER JOIN (BUCKET_SHUFFLE(S))
  |  hash predicates:
  |  colocate: false, reason:
  |  equal join conjunct: 2: v2 = 8: v8
  |  equal join conjunct: 1: v1 = 7: v7
  |
  |----7:EXCHANGE
  |
  5:Project
  |  <slot 1> : 1: v1
  |  <slot 2> : 2: v2
  |  <slot 4> : 4: v4
  |
  4:HASH JOIN
  |  join op: INNER JOIN (PARTITIONED)
  |  hash predicates:
  |  colocate: false, reason:
  |  equal join conjunct: 1: v1 = 4: v4
  |  equal join conjunct: 2: v2 = 5: v5
  |
  |----3:EXCHANGE
  |
  1:EXCHANGE

PLAN FRAGMENT 2
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 07
    HASH_PARTITIONED: 8: v8, 7: v7

  6:OlapScanNode
     TABLE: t2
     PREAGGREGATION: ON
     partitions=1/1
     rollup: t2
     tabletRatio=3/3
     tabletList=10024,10026,10028
     cardinality=1
     avgRowSize=2.0
     numNodes=0

PLAN FRAGMENT 3
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 03
    HASH_PARTITIONED: 5: v5, 4: v4

  2:OlapScanNode
     TABLE: t1
     PREAGGREGATION: ON
     partitions=1/1
     rollup: t1
     tabletRatio=3/3
     tabletList=10015,10017,10019
     cardinality=1
     avgRowSize=2.0
     numNodes=0

PLAN FRAGMENT 4
 OUTPUT EXPRS:
  PARTITION: RANDOM

  STREAM DATA SINK
    EXCHANGE ID: 01
    HASH_PARTITIONED: 2: v2, 1: v1

  0:OlapScanNode
     TABLE: t0
     PREAGGREGATION: ON
     partitions=1/1
     rollup: t0
     tabletRatio=3/3
     tabletList=10006,10008,10010
     cardinality=1
     avgRowSize=2.0
     numNodes=0

@Youngwb no relative PRs?


Add possibility to test consistency of docstring content between base class and class

Description
This PR add validate_docstring_parent_class_consistency function that is designed to validate consistency between base class and class docstring.
In many places we update docstring in one class, but not in another. Good example is docstring of blending for Points layer, that is updated in this PR.

Are we sure this is always usable? There might be cases where a subclass has a more specific use of a parameter

For such use case, I introduce skip parameter.


tidybyt/community  GitHub Workflow check for print statements

is there a way to get the workflow to check that print statements aren't in the published app to prevent unnecessary data in the build logs / workflow logs?

I don't think having some print statements present is necessarily a bad thing. But if you have tons you could create a debug variable and set to false in the community app and change in production worst case if you don't want to just comment them out.

or (and I don't know if this is possible) - shunt that output during compile/test in the workflow so it doesn't flood the github logs.

So I'm sure it is possible, but even if it doesn't flood the github logs, I think it would still flood their logs on their servers?
I was simply giving you an alternative if you wanted at least a quicker temporary fix if this is possible to do. Not having to worry about commenting them out would be nice though, I don't disagree.

I don't typically leave them in code I submit - I use it for debugging & then delete them.   But I see other folks still have them.  was helping someone else out with a failed test & I had to weed through a bunch of another submitter's app debugging/print to find the error in the app we were working on.   Just trying to streamline it as a general rule.     we're on the same page.

Yeah, I'm with you if they are super useful and beyond just hit or miss on the api, usually they get commented out or just deleted.
But agreed, wading through those is a pita.


Add mask WF, move tasks to own file

This is a little bit messy, but it's a good idea to make a beta release for this so I can report back to CDPH, and keep a record of what thing were like before switching from matutils mask (as is in this PR) to backmasking (which seems to work better).


MWPW-133659 l1 to l2 rotate pdf

Resolves: https://jira.corp.adobe.com/browse/MWPW-133659
Llinks:
Before: https://stage--dc--adobecom.hlx.page/acrobat/online/rotate-pdf
After: https://mwpw-133659-l1-to-l2-rotate-pdf--dc--adobecom.hlx.page/acrobat/online/rotate-pdf

@Blainegunn @peller
Given the requests to remove the footer background-color and reposition the white part of the widget close to the top orange edge, I had to introduce a specific class for such pages. Thus, I added the class 'l2-state' to the  tag. This approach might not be conventional, which is why I wanted to verify with you if you have any concerns about it. I incorporated this change into the dc-converter-widget.js file to ensure the class is applied at the earliest possible moment.

An alternative method using a query selector could cause delays, with changes taking effect after the page has already rendered. This could lead to late adjustments in elements' positions or styles, resulting in an unfavorable appearance. Particularly, the loading time of the small-footer might exacerbate this issue.

Once again, due to the need for some time to calculate the footer height and the requirement for the widget's height to be 100vh - (navHeight + footerHeight), certain content might experience displacement. In order to prevent a scenario like the one shown in the image at https://jira.corp.adobe.com/secure/attachment/10596793/10596793_image-2023-08-16-16-18-39-949.png , I expanded the orange background size. As a result, the footer will only slightly extend under the widget section (and perhaps in the production environment, where things are faster, this difference might not be as noticeable). However, this solution differs from the design, which anticipates that the orange background should occupy about half of the height as shown here:  https://xd.adobe.com/view/41201c56-4094-4482-8d51-caf5faa044c2-1473/screen/210ec4d2-bf4d-4d60-b991-fe66c317ff31/.

Please take a look, I need you approval so I can continue to work on responsive screens.

@Blainegunn Last commit for responsive design is pushed


chore: Add just targets for simple stack handling

Pull Request Checklist
Task Description/Number
@irmastnt this automates the commands that worked yesterday which are a lot faster than make stack-up which first has to build images for SIPI and the API.
PR Type

[x] build/chore: maintenance tasks (no production code change)
[ ] docs: documentation changes (no production code change)
[ ] feat: represents new features
[ ] fix: represents bug fixes
[ ] perf: performance improvements
[ ] refactor: represents production code refactoring
[ ] test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

[ ] Tests for the changes have been added
[ ] Docs have been added / updated

Does this PR introduce a breaking change?

[ ] Yes

Does this PR change client-test-data?

[ ] Yes

@BalduinLandolt  as discussed, I have added the recipes and fine tuned it a bit.
Please have a look.

@BalduinLandolt as discussed, I have added the recipes and fine tuned it a bit.
Please have a look.

I like it much better now, thanks!
Do we want to have an alias for most commands? then stack-restart might be a candidate


Rename Banner to Badge, add variants and icon

[ ] Rename Banner to Badge
[ ] Rename info/warning/error to info/negative/positive + the 8 colors above
[ ] Remove spectrum-Banner-header
[ ] Add spectrum-Banner-icon
[ ] Add size=small for number/notification badges
[ ] Add CSS for alignment to remove corner radii?

synced to jira: https://jira.corp.adobe.com/browse/SDS-7330

Remove Label as part of this, would close #140


[WIP] Fix deprecated functions

I did the following changes:

I update the LTS in the stack.yml file.
Apply a few suggestions from hlint.
Replace the deprecated functions with the suggestions given (to solve #36).

Could you please take a look @jpvillaisaza?

I'll check it out.

@CristhianMotoche The parseUrlThrow is in http-client since version 0.4.30, so that part should be handled differently for older versions (like for LTS 2, which is getting 0.4.18).

I added CPP options for conditional compilation. However, I'm not sure if that is the best solution. Please, let me know what do you think about it.

@CristhianMotoche Thanks!


No Gamepads Detected

Updated to the latest beta but none on my gamepads are showing up detected. Xbox via BT or PS4 via USB wired.

Uninstalled the current beta and reinstalled Beta7 and having the same issue. Unsure what the issue might be(before I updated, everything worked 100%).
When I connect now, it gives me a prompt every time.

Ok apparently I was on Beta6 previously as I just downgraded and it works as expected. Gamepads being detected as well.

Beta 12 and issue still remains - Xbox Elite 2 controller not detected :(
Running on Mac OS (M1)
I assume we are meant to connect them directly to the Xbox and not to our client?

Beta 14 and the issue still exists. :/ M1 mac. Tried with normal series X controller and the Elite 2.

Check the workaround provided by idlehand79 posted here:
https://github.com/unknownskl/greenlight/discussions/1060#discussioncomment-7924310


mbt does not work in alpine

Question:
mbt does not work in alpine, don't know why I tried to download it and gave it executable permission but still, it shows me mbt not found and it works in ubuntu. it's weird. trust me i'm not missing any steps but i think it's something related to libraries
/ # apk update; apk add curl
fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/community/x86_64/APKINDEX.tar.gz
v3.13.2-103-gb3fbe92d7e [https://dl-cdn.alpinelinux.org/alpine/v3.13/main]
v3.13.2-103-gb3fbe92d7e [https://dl-cdn.alpinelinux.org/alpine/v3.13/community]
OK: 13878 distinct packages available
(1/5) Installing ca-certificates (20191127-r5)
(2/5) Installing brotli-libs (1.0.9-r3)
(3/5) Installing nghttp2-libs (1.42.0-r1)
(4/5) Installing libcurl (7.74.0-r1)
(5/5) Installing curl (7.74.0-r1)
Executing busybox-1.32.1-r3.trigger
Executing ca-certificates-20191127-r5.trigger
OK: 8 MiB in 19 packages
/ # mbt does not work in alpine or ubuntu dont know why i tried to download it and gave it executable permission but still^C
/ # curl -L https://github.com/mbtproject/mbt/releases/download/v0.24/mbt_linux_x86_64 -o mbt; chmod +x mbt; ./mbt
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   624  100   624    0     0   4837      0 --:--:-- --:--:-- --:--:--  4837
100 10.7M  100 10.7M    0     0  5830k      0  0:00:01  0:00:01 --:--:-- 5613k
sh: ./mbt: not found
/ # ls
bin    dev    etc    home   lib    mbt    media  mnt **green**    opt    proc   root   run    sbin   srv    sys    tmp    usr    var
/ # mbt
sh: mbt: not found
/ #

Thank you

Alpine is musl libc (as opposed to glibc). This means programs linking to glibc would not work. We don't have a pre-built binary for alpine at the moment. If you want to use it it alpine, you have to build it with source.
We can make a few build improvements once I find some time to merge https://github.com/mbtproject/mbt/pull/137 :). One of them would be alpine bin.

i got workaround mbt in alpine by installing glibc :see_no_evil:
Thanks to sgerrand/alpine-pkg-glibc
apk add curl &
curl -L -o /usr/local/bin/mbt https://github.com/mbtproject/mbt/releases/download/v0.24/mbt_linux_x86_64
chmod +x /usr/local/bin/mbt
wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub
wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.33-r0/glibc-2.33-r0.apk
wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.33-r0/glibc-bin-2.33-r0.apk
wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.33-r0/glibc-i18n-2.33-r0.apk
apk add glibc-2.33-r0.apk
apk add glibc-bin-2.33-r0.apk glibc-i18n-2.33-r0.apk
/usr/glibc-compat/bin/localedef -i en_US -f UTF-8 en_US.UTF-8
mbt


improves python 3.9 on al2 builder base

Issue #, if available:
Description of changes:
My first attempt at adding python3.9 to the al2 builder base was bad. It was copying the entire minimal python image root over top the builder base root. This seemed fine in theory, but since the builder rebuilds bash from source this copy was replacing the built bash 4.3 with the older 4.2. This causes issues in certain builds that require 4.3+.
This new approach targets the specific python bins/libs that we need instead of the whole root.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm
/hold

/unhold


Shaiahwren approve collections

This pr add functionality to the approval page for approving and rejecting collections.
The approval "state" on the UI in columns updates about 5 seconds after modal close. Any suggestions for remedying this are welcome:)

The approval "state" on the UI in columns updates about 5 seconds after modal close. Any suggestions for remedying this are welcome:)

What http request status code do you get back a 202? If that is the case we may need to parse the task system.


Add circular effect on mouse over

In order to finish the material design mode all buttons should have a circle on mouse over.
For example:

Potential idea:
Pure CSS Click Effect.
https://speckyboy.com/custom-hover-click-effects-css-javascript


scatter.eos(network, Eos, eosOptions);  has error

Eos is not a function now!
the error message:
TypeError: t is not a function     at t.default.eos (inject.js:40)

sorry ,
npm install eosjs ,  again
it's ok

the same question occurs to me,Just lower vision of eosjs@20 to eosjs@16,
and npm start It works for me.
Good luck!


no hover zone

this piggybacks off the existing implementation for the helper method we added to mod base to detect hovering
lays the groundwork for #11
we should probably make this a toggle in the progress menu somewhere

One thing I was thinking here that would be interesting would maybe be supporting a few different kinds of hover restrictions.

No restriction
Can hover for a decent amount of time
Can hover for a short amount of time
Can't hover at all

An alternative to restricting it by time - it would be really easy to limit the number of L1 tricks/taps, since thats basically how the detection is coded

An alternative to restricting it by time - it would be really easy to limit the number of L1 tricks/taps, since thats basically how the detection is coded

Yeah this was how I was intending to suggest to approach this


Signatures should not be used to derive keys

Hi
A BitBox02 user cannot regain access to their rhino.fi account after successfully registering using a EIP-712 signed message.
It seems like the signature is used as some sort of account identifier or encryption key.
The user mentioned that rhino.fi uses this repo. I am not sure if this is true, but maybe this function is being used?
https://github.com/starkware-libs/starkware-crypto-utils/blob/bf4066c81e4389daea0c388370ac509d89f1a3e1/src/js/key_derivation.js#L49-L60
This function is problematic, as signatures should not be assumed to be deterministic or be used as an encryption key or account identifier. There are many different valid signatures for one private key and message, and one cannot assume that a signer will always return the same one.
The problem in practice is that the BitBox02 hardware wallet returns a different valid signature every time a message is signed, even for the same private key and message, as a result of deploying the anti-klepto-protocol. This seems to have locked the user out of his account.

Any response here? It seems multiple projects like loopring and DYDX are using this, potentially risking the funds of users which use signers that do not produce the same signatures every time.

Hey @benma . It is our understanding that you approached RhinoFi with this issue and were refunded appropriately, which we are happy to hear.
Regarding this issue note that there is an explicit warning in our documentation regarding the use of non-deterministically signing in the process of Stark key pair derivation process. Please see this link for more information.
Please note the code in this repo provides tools for exchanges integrating with StarkEx to implement their own key derivation and signature schemes. We discussed this issue with RhinoFi and other StarkEx powered system to make sure measures are in place to prevent such issue from occuring in the future. Thank you very much for pointing this out.

@AlonStark why do you even use signatures for key derivations?
There seem to be more and more apps using this function.
So far I am aware of rhino.fi, loopring and dydx. Using the signature for this sort of this is not a good idea and is not compatible with ECDSA in general. It's bad to require deterministic signature as it is not compatible with security protocols like the anti-klepto protocol.


minor bug fixes raised by FE

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@a9b2c2c). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #95   +/-   ##
=========================================
  Coverage          ?   72.44%
=========================================
  Files             ?       64
  Lines             ?     2765
  Branches          ?        0
=========================================
  Hits              ?     2003
  Misses            ?      762
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow ContainerData to be used only under HostAdmin

@freva please merge.
@hmusum @hakonhall FYI

Hang on, failing tests.

I'll rather restrict only the motd and prompt this way -- the config thing restricts itself, as noted in comments. This is to avoid changing too much test code.


fail to rebuild base image from Dockerfiles

Hi,
I'm trying to rebuild a base image from Dockerfile.debian
It fails because of unknown commands: add-pkg, del-pkg, sed-patch and install-icon...
same for Dockerfile.alpine.
I must have missed something...
Thans for your comments

Are you using the build script?
./build.sh debian-8

no as I was planning to debian-9 or even debian testing...
I would like to rebuild your image from scratch...
The missing functions are defined somewhere in the "hooks"?

This baseimage is not built from scratch, but depends on another one (jlesage/baseimage).  So you need to add support for a new distro in jlesage/baseimage first.  You could add a version file in the versions directory.

but how is build jlesage/baseimage?

Same principle as this one: you have a build.sh you can use.
https://github.com/jlesage/docker-baseimage

Closing this issue.


Allow extensions to provide tooltips on Type Hierarchy and Call Hierarchy nodes

Currently on Call Hierarchy and Type Hierarchy, the tooltips are just a repeat of the main tree node label which adds no value. There's extra detail that extensions might want to provide that won't fit into the node text / display text - for example on type hierarchy you might want to include the relationship of nodes - eg. implements/extends/mixin/constraints, the package/namespace of the class, maybe even the documentation hover (although in theory VS Code could get that itself from the location).

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Bug: When trying to enter Vim mode, the text field in the popup to enter the command to exit Vim is missing

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Check for updates).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] The bug is about Obsidian desktop, Obsidian mobile is not supported by this theme.
[X] My Obsidian installer version 1.1.9 or later. If not, please update first. You can find the version in the About tab of the Obsidian settings.

Bug Description
I want to learn to use Vim so I was trying to enter Vim mode, but with Shimmering Focus the popup warning about Vim is different, in this case missing the actual text field. First I thought Obsidian had changed the way they check if the user knows Vim because there's a little warning box saying Enter the command to enable Vim mode so I was initially looking for a command to do that, when I realized that with the default theme the popup looks differently.
This is in a brand new vault I made to practice Vim in, so there are no snippets, and all I have installed is Style Settings (with no settings changed), and Vimrc Support (with no settings changed).
Relevant Screenshot

To Reproduce
No response
Plugins Involved
Vim
Sample Text
No response
Obsidian Version
1.6.7
Installer Version
1.6.7
In which mode(s) does the problem occur? (if applicable)

[ ] Source Mode
[ ] Reading Mode
[ ] Live Preview

Which operating system?

[ ] macOS
[ ] Linux
[ ] Windows

fixed 👍


[Supernova][Doop] Change initial support group filter from team to new support group info

For some people their team membership doesn't align with their support groups (e.g. there are multiple support groups in Team Core). For them the nice initial filter doesn't work which is annoying.
@uwe-mayer is currently working on adding the support group info to the token of the logged in user. Once this is done we should change our initial support group filter such that it takes the support group membership as value for the filter instead of the team.
This needs to be changed in Supernova and Doop.

PR is merged.
Who will add the necessary greenhouse.sap/support-group label for ccloud? @auhlig ?


Email Alerts: Create a script to generate html snippets for threat level changes.

This is a proof-of-concept.  I just threw in the old/new risk thermometers as a test.  We'd need to update this to use the actual React components for the email.
It generates html files like this.
Which render to something like:

cc/ @chasulin

This didn't end up being useful.


IndexError

Hi:
I met an error when executing https://github.com/darrenjkt/MS3D/blob/7e65e6d59d4c9cbc6675dd6fdf155bc2cb53baf8/tools/ensemble_kbf.py#L51 in ensemble_kbf.py,
the function it goes to is https://github.com/darrenjkt/MS3D/blob/7e65e6d59d4c9cbc6675dd6fdf155bc2cb53baf8/pcdet/utils/box_fusion_utils.py#L366
The error message is:
Exception has occurred: IndexError
index 9 is out of bounds for axis 1 with size 0
File "/home/weijiarong/Desktop/MS3D/pcdet/utils/box_fusion_utils.py", line 376, in get_initial_pseudo_labels
cls_boxes = cls_boxes[cls_boxes[:,9] > 0] # Discard if box weight == 0
File "/home/weijiarong/Desktop/MS3D/tools/ensemble_kbf.py", line 51, in
ps_dict = box_fusion_utils.get_initial_pseudo_labels(detection_sets, cls_kbf_config)
IndexError: index 9 is out of bounds for axis 1 with size 0
When I print the frame_boxes variable where the error occurs, it's like this:
{'boxes_lidar': array([], shape=(0, 7), dtype=float64), 'score': array([], dtype=float64), 'source': array([], dtype=float64), 'source_id': array([], dtype=float64), 'frame_id': '1226', 'class_ids': array([], dtype=float64), 'names': array([], dtype=float64), 'box_weights': array([], dtype=float64)}
The error is met when executed to the 235th sample of my target unlabeled dataset:
/tools/cfgs/target_custom/label_generation/round1/cfgs/ps_config.yaml
load detection sets: 100%|██████████████████████████████████████| 1585/1585 [00:00<00:00, 12912.92it/s]
Number of detection sets:  1
get initial ps labels:   0%|                                                  | 0/1585 [00:00<?, ?it/s]/home/weijiarong/Desktop/MS3D/tools/../pcdet/utils/box_fusion_utils.py:374: FutureWarning: elementwise comparison failed; returning scalar instead, but in the future will perform elementwise comparison
cls_mask = (frame_boxes['names'] == class_name)
get initial ps labels:  16%|██████                                | 253/1585 [00:00<00:00, 7138.45it/s]
It seems the problem happen because the boxes_lidar varible is empty. That occurs, if I'm understanding correctly, when the model do not have any predictions for a lidar point cloud. So this is a bug or I missed something?
My ps_config.yaml file is:
_DETS_TXT: /home/weijiarong/Desktop/MS3D/tools/cfgs/target_custom/label_generation/round1/cfgs/ensemble_detections.txt
SAVE_DIR: /home/weijiarong/Desktop/MS3D/tools/cfgs/target_custom/label_generation/round1/ps_labels
DATA_CONFIG_PATH: /home/weijiarong/Desktop/MS3D/tools/cfgs/dataset_configs/custom_dataset_da.yaml
PS_SCORE_TH: # veh,ped,cyc
POS_TH: [0.7,0.6,0.5]
NEG_TH: [0.3,0.3,0.3]
ENSEMBLE_KBF:
DISCARD: [3, 3, 3]
RADIUS: [1.5, 0.3, 0.2]
NMS: [0.1, 0.3, 0.1]
TRACKING:
VEH_ALL:
RUNNING:
SCORE_TH: 0.7
MAX_AGE_SINCE_UPDATE: 2
MIN_HITS_TO_BIRTH: 2
ASSO: giou
ASSO_TH: 1.0
REDUNDANCY:
SCORE_TH: 0.3
MAX_REDUNDANCY_AGE: 3
ASSO_TH: 0.0
VEH_STATIC:
RUNNING:
SCORE_TH: 0.5
MAX_AGE_SINCE_UPDATE: 3
MIN_HITS_TO_BIRTH: 2
ASSO: iou_2d
ASSO_TH: 0.5
REDUNDANCY:
SCORE_TH: 0.1
MAX_REDUNDANCY_AGE: 2
ASSO_TH: 0.5
PEDESTRIAN:
RUNNING:
SCORE_TH: 0.3
MAX_AGE_SINCE_UPDATE: 2
MIN_HITS_TO_BIRTH: 2
ASSO: giou
ASSO_TH: 0.8
REDUNDANCY:
SCORE_TH: 0.1
MAX_REDUNDANCY_AGE: 3
ASSO_TH: 0.2
TEMPORAL_REFINEMENT:
TRACK_FILTERING:
MIN_NUM_STATIC_VEH_TRACKS: 10
MIN_NUM_PED_TRACKS: 10
MIN_DETS_ABOVE_POS_TH_FOR_TRACKS_VEH_ALL: 4
MIN_DETS_ABOVE_POS_TH_FOR_TRACKS_VEH_STATIC: 5
MIN_DETS_ABOVE_POS_TH_FOR_TRACKS_PED: 2
USE_STATIC_PED_TRACKS: false
ROLLING_KBF:
MIN_STATIC_SCORE: 0.8
ROLLING_KDE_WINDOW: 15
PROPAGATE_BOXES:
MIN_STATIC_TRACKS: 10
N_EXTRA_FRAMES: 10
DEGRADE_FACTOR: 0.99
MIN_SCORE_CLIP: 0.3_

An update here:
If these lines:
https://github.com/darrenjkt/MS3D/blob/7e65e6d59d4c9cbc6675dd6fdf155bc2cb53baf8/pcdet/utils/box_fusion_utils.py#L378
https://github.com/darrenjkt/MS3D/blob/7e65e6d59d4c9cbc6675dd6fdf155bc2cb53baf8/pcdet/utils/box_fusion_utils.py#L379
are moved above this line:
https://github.com/darrenjkt/MS3D/blob/7e65e6d59d4c9cbc6675dd6fdf155bc2cb53baf8/pcdet/utils/box_fusion_utils.py#L377
then the error is fixed.


Make nad2bin output reproducible

initialize the struct CTABLE
Without this patch,
./nad2bin /tmp/x < datumgrid/stpaul.lla && md5sum /tmp/x
would differ after byte 41 because uninitialized memory was written
to the file and ASLR randomized the memory content
See https://reproducible-builds.org/ for why this matters.

nad2bin.c external vendor code from PROJ.4 C library.

Submitted the fix at https://github.com/OSGeo/proj.4/pull/1141

Turned out that the fix is already in line 101, but our pyproj-<IP_ADDRESS> (the latest release?) does not have it.

Are there plans to make a new release? There are probably more fixes like this in there and I do not want to search to backport these.

we hope to release 2.0.0 (which required proj4 version 6.0.0) this month


Search box removed

This commit will remove the unnecessary search box that we had in the top right corner  @stevevance

Sufyan (or is it Syed?) - can you remove the lines instead of commenting them out? If it turns out we need the lines later, we can retrieve them from a prior version of the codebase.

Removed the codes :) thanks @rguico


add links to attribution

add links to profile and original icon

@janniks: I apologize for taking so long to merge this. I really appreciate your work on the original icon.

No problem at all.. Thanks, that very nice to hear! :)


sign failed

Hello i just want to sign my app with your package.
when i run this command.
electron-osx-sign 'eRadioEdicion.app' --platform=darwin --type=distribution --identity='Developer ID Application: SOLUCIONES INTEGRALES MULTIMEDIA SA DE CV (ZPCJ36USJG)' --entitlements='entitlements.plist' --version=1.6.6 --provisioning-profile='distribution.provisionprofile'

i get this error
Sign failed:
Command failed: codesign --sign B452AFD22F5E28285DC455D17ED33DC89503D6F0 --force --entitlements /usr/local/lib/node_modules/electron-osx-sign/default.entitlements.darwin.inherit.plist eRadioEdicion.app/Contents/Resources/app/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Electron Framework
eRadioEdicion.app/Contents/Resources/app/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Electron Framework: bundle format is ambiguous (could be app or framework)

i test my app with RB App Checker Lite
and the output is this
Evaluating the application “eRadioEdicion”.

The application is unsigned. ￼
	Executable code for x86_64 has the UUID “645381EB-354A-3740-8CDD-DF9F333944EE”.

The application is not sandboxed.

There are 8 embedded frameworks. ￼

119 auxiliary executables have been found. ￼
	254 data files have executable permissions, but should not. ￼ ￼
	469 files are invisible in the Finder. ￼ ￼
	119 executables are unsigned. ￼ ￼
	108 executables are in the Resources folder. ￼
	13 executable files have no executable permissions, but should. ￼ ￼

what am i doing wrong?

Hi @cinder92, I would recommend checking out #138 (comment).
Seems that you have included electron in your node_modules directory. Since it is packed along with your code, we are having a nested app structure here... Removing electron from node_modules should resolve the issue.

Original post: https://github.com/electron-userland/electron-osx-sign/issues/89#issuecomment-308950562

Closing this issue for now since it's been inactive for quite a while.


[WIP ]Add viewport histogram example

Related with  https://github.com/CartoDB/carto-vl/issues/778
Blocked by https://github.com/CartoDB/carto-vl/pull/869

Could you change the PR base to 572-add-get-legend-method in order to check better the changes?


stanford car analysis 1st commit

Pull Request for ML-Crate 💡
Issue Title: Mid Evaluations , EDA of the dataset

Info about the related issue (Aim of the project) :
Name:  Prince Thakkar
GitHub ID:  rising-star2712
Idenitfy yourself: Contributor

Closes: #issue number that will be closed through this PR
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

This is not acceptable, create a fresh PR properly. You have added more than 5000 files, it may happen as you have not updated the git repository in your local system.


WRQ-14637: Updated storybook to version 8

Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Storybook needed to be updated to the latest version
Resolution
Updated list of storybook dependencies and their version to v8.x based on the migration guide https://github.com/storybookjs/storybook/blob/next/MIGRATION.md
Changed configuration based on the storybook v7 and v8 requirements

main.js: core.builder information replaced by framework.name.
Addon '@enact/storybook-utils/addons/docs' replaced by '@storybook/addon-docs' because storybook addon for docs does not support customization anymore https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#dropped-addon-docs-manual-configuration
storybook docs behave differently now. Thay are on the left menu, together with the story for each component. In order to activate docs, autodocs:true was added in main.js. https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#dropped-addon-docs-manual-configuration
story filenames different than xxx.stories.js need an indexer https://github.com/storybookjs/storybook/pull/20700/files#diff-ea5ebe92abd71b6467c58252b92c04b8d49cc140e8a94f9cf5bb7a76bf2256a4 storyindexer information was added in main.js
preview.js: docs.inlineStories has been renamed docs.story.inline; docs.iframeHeight has been renamed  docs.story.iframeHeight
package.json storybook dev and build commands adapted to v7 naming.
new root container id used by storybook is called "storybook-root". This change breaks enact's logic to apply spotlight related styling in SpotlightRootDecorator https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#change-of-root-html-ids ThemeDecorator already has a rootId prop and can be set from the sampler app to storybook-root, but it was not passed to SpotlightRootDecorator. A PR in enact repo is needed also and is attached to the user story

Additional Considerations
Links
WRQ-14637
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: daniel-stoian-lgp:x: Daniel StoianDaniel Stoian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add announcements section

To amplify related work from our partners that don't necessarily fit on a calendar or in a Library.

This is done!
https://github.com/github/maintainermonth/pull/108
Huge thanks @AbhinavRajesh


Icon not updating

When I click on the reload button at the bottom-left corner and the commits go from 0 to 1 the icon is not updated, it stays red.

Can you please check which version you're using? It was fixed on fa863de and released on v0.2.1

I have no idea, is there a way to see the version? I will update here.

You can just find the app on finder quick look it and it'll show the version.


Use location.hostname instead of document.URL.split

Thanks, location.hostname has support on all browsers except Internet Explorer and Opera link just as reference hostname


Images broken in preinstall

Bug report

Extension name: firestore-stripe-subscriptions

Describe the bug
The images in PREINSTALL.md don't display in github or in the extension details page.
Expected behavior
The images should show in both places. Should we re-host them somewhere else?
Screenshots
Extension details page:

Github:

Looks like they are back 👍


Fix issue driving values on 32-bit systems.

This fixes an issue with driving signals larger than 32-bit on modelsim 32-bit as reported in #409. The issue is caused by following function in VpiCbHdl.cpp:
int VpiSignalObjHdl::set_signal_value(long value)
A long is 8 bytes on 64-bit platforms, but only 4 bytes on 32-bit platforms. Driving a 64 bit verilog signal with a 32 bit value results in undefined behaviour for the upper 32 bits on a 32-bit platform.
On a 64-bit platform a similar problem occurs when driving verilog signals larger than 64 bit as reported in #507.


Don't trigger changeSchema when schema is not set yet

Related ticket: #12299 .
When a new analysis is added, it was rendered twice because after creating that view, the analysis-form-model was triggering a changeSchema event where the analysis-form-view was listening it and doing a new render.
It is true that several analyses need to render again when, for example, a fetch has finished (example with georeference-analysis-form-model).
The new idea is, don't trigger a changeSchema until it is initialized the first time. When it is set for the first time, we will trigger a createSchema.
@nobuti @rjimenezda

I've setup a breakpoint to check how many renders of the analysis form view happen and these are the results:

Analysis
this branch
production
Observations

Filter by layer
3 renders
3 renders
-

Georeference
2 renders
2 renders
-

Join Columns
3 renders
3 renders
-

Intersect
2 renders
2 renders
-

Areas of Influence
1 render
1 render
-

Centroid
1 render
1 render
Aggregation checkbox causes render, weighted_by causes 2

Convex Hull
2 renders
2 renders
Method causes 2 renders, operation causes 1

Filter by Column
2 renders
2 renders
Column causes 2 renders, some even more (featurecla causes 4!)

Filter in Polygons
2 renders
2 renders
-

Connect with lines
4 renders
4 renders
Sequential causes 2 on this branch, 1 on prod

Subsampling
1 render
1 render
-

Clustering
1 render
1 render
-

Outliers
2 renders
2 renders
-

Trends
2 renders
2 renders
-

Find Nearest
2 renders
2 renders
Target causes 2 renders

I wonder if I've done something wrong because I find it strange that both are exactly the same. I double checked and the code in staging is definitely the one from the branch. In any case, quite a cool table to have right?

No changes? Let's not merge it then :(.

And yes, nice table! 💃 .

On production I do have DO enabled, but not on staging, I don't think that makes a difference 🤔 ?


Correct Oozie's catalina path

Makes oozie to boot back up to prevent the following error:
WARNING: Can't load server.xml from /usr/hdp/current/oozie-server/conf/server.xml
<Date> <Time> org.apache.catalina.startup.Catalina start
SEVERE: Cannot start server. Server instance is not configured.

UPDATE: To be backported to 3.0 (Backport done in 3.0.27)

@aespinosa It looks like there is a merge conflict here?

Ah yes now that #982 is in.  This needs to be pulled together when #969 is resurrected.


Issues trying to access Characters/Staff API

I'm currently using client_credentials for my token. I am successfully making GET browse/{series_type} calls and obtaining the "id" returned from each of those entries.
What I then try to do is use those IDs to obtain Characters/Staff; first I tried using  GET anime/[ID]/characters but I get a 404. I realize that the format is GET {series}/{id}/characters, but what do I need to put into {series} parameter since it's not the same as {series_type}?
I also tried following using GET: {series_type}/{id} under Routes/Basic doc by using GET anime/[ID] (ID obtained from the previous browse call) but this gives me an access_denied error.
Any advice will help.
Thanks!

Can you give me an example of a specific call you're trying to make? It looks like I can call GET anime/[ID]/characters just fine.

D'oh, I somehow didn't pass in the token in my new call, sorry about that. anime/[ID]/characters indeed is working now, but trying to do anime/[ID]/staff or anime/[ID]/actors gives me an unavailable route. Have these two options been deprecated?

I can't find anything that shows they were ever valid routes at all to be honest, it seems like a bit of misinformation to me.
I'll pester Josh about it in the morning, but yeah it seems like they're not there anymore and should be removed from the documentation at least.

Thanks for the quick response and clarification! It seems I can leverage the actor key/value from the anime/[ID]/characters response for my use case.

Glad to hear it worked out. Feel free to open another issue if you have anymore questions or concerns!


ServiceRequest timeline, get most recent media

Coverage remained the same at 94.367% when pulling 2c817fcf1eddd79da8340807a992c641a40d9288 on cody-service-request-timeline-sort into 211b7c16d70e6b320d09da6d50e9d1770b40aa85 on main.


Extension methods are not supported

The following snippet:
public static class X
{
  public static void Test(this string t)
  {
    Console.WriteLine($"Value {t}");
  }
}

public class Program
{
  public static void Main()
  {
    string foo = null;

    foo.Test();
  }
}

Gives the following build errors:

(2,22): error CS1109: Extension methods must be defined in a top level static class; X is a nested class
(14,9): error CS1061: 'string' does not contain a definition for 'Test' and no extension method 'Test' accepting a first argument of type 'string' could be found (are you missing a using directive or an assembly reference?)

This is a consequence of the default Try .NET experience using C# scripting. If you switch to the full .NET Core experience (https://try.dot.net/?workspaceType=console) this will work.

Also, it does work if you declare the extension method outside the class:
public static void Test(this string t)
{
  Console.WriteLine($"Value {t}");
}

public class Program
{
  public static void Main()
  {
    string foo = null;

    foo.Test();
  }
}


[cxx-interop] Add test for lifetimebound annotation in ctor

There was an off by one error in this case.

@swift-ci please smoke test

@swift-ci please smoke test


docs: write / adapt script to extract API docs from directives source code

We can start by adapting: https://github.com/angular/react-native-renderer/blob/master/doc/parser.js

Fixed by f905b7d093829e99c40b40da7cd7316083d788e5


perf: experiment with different semiring definition

Try to keep the weird classes like NonAssocNonUnitalSemiring out of the main hierarchy.

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.


sbt warning when using scala-pickling 0.8.0 with scala 2.11.1

I'm creating a new sbt project with sbt 0.13.5, here's my build.sbt
name := "pickling-test"

version := "dev"

scalaVersion := "2.11.1"

libraryDependencies ++= Seq(
  "com.github.scala-incubator.io" %% "scala-io-core"  % "0.4.3-1",
  "org.scala-lang"                %% "scala-pickling" % "0.8.0"
)

And I get the following sbt warning when initializing the project:
[warn] Binary version (0.8.0) for dependency org.scala-lang#scala-pickling_2.11;0.8.0
[warn] 	in default#pickling-test_2.11;dev differs from Scala binary version in project (2.11).

Any suggestion on how to resolve this warning?

Pickling 0.10.0 is in org.scala-lang.modules, so this should no longer happen.


⚠ ClamAV has degraded performance

In 0d00234, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 65 ms

Resolved: ClamAV performance has improved in e49891a.


SW-5559 Add table for user deliverable categories

Create the database table to hold the association between users and deliverable
categories.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2117
#2116
#2115  👈
#2114
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

Jun 28, 2:23 PM EDT: @sgrimm started a stack merge that includes this pull request via Graphite.


(Hair) dye issues

Description

Numerous problems:

Dyes are not unloaded well
Hair dye is stored on the player save, but not handled by tML correctly.

Commit https://github.com/blushiemagic/tModLoader/commit/aa655a3039c93e8978e429da0605c89462f4e704 makes changes that allow removing Armor dyes manually, but it doesn't reset _shaderDataCount, and the changes don't affect Hair dyes. In my opinion, removing dyes should be handled by tmodloader itself after mods unload.
Also, if the dye limit could be increased from 255 somehow, that'd be great.

0de88ac41c8396cbf59a4154a3aeb746c014cab1 fixed, mods don't need to remove their shaders/effects anymore.
As for the dye limit, there's the 255 limit check but I'm not sure what other systems that's tied into. You're welcome to change it and submit a PR

The part about modded hair dyes not saving correctly for players is still a problem. Basically, just like modded items, hair dyes added by mods may get different ids between sessions depending on mods loaded, and these ids are saved to the player file directly.


feat(backend): Add endpoint to select utxos and fee for bitcoin transaction.

Motivation
To make a bitcoin transaction utxos and a fee must be selected.
In this PR, I introduce an endpoint that calculates the utxos for a transaction with a specific amount and then the fee related to it.
Changes
Manual changes

New bitcoin_api module with exposed functions: get_all_utxos and get_fee_per_byte.
New bitcoin_utils module with expose functions: estimate_fee and utxos_selection. These utils are based on the ckBTC minter's code.
New endpoint btc_select_user_utxos_fee that uses helpers to calculate and return utxos and fees.
New endpoint types.

Automatic changes

Changes in backend.did with ./scripts.did.sh.
Changes in src/declarations/backend/* with npm run generate.

Tests

Unit tests for the bitcoin_utils.
Dummy integration test for the new endpoint. Pocket-ic doesn't support (yet) bitcoin.

@bitdivine please review

Regarding the Oisy payment sequence diagram, does it make sense to put it in the repo itself? GitHub markdown supports mermaid:
sequenceDiagram
    actor U as User
    participant F as Oisy Frontend
    participant B as Oisy Backend
    U->>F: User makes transaction
    F->>B: Request utxos and fees for transaction

etc?

Regarding the Oisy payment sequence diagram, does it make sense to put it in the repo itself? GitHub markdown supports mermaid:
sequenceDiagram
    actor U as User
    participant F as Oisy Frontend
    participant B as Oisy Backend
    U->>F: User makes transaction
    F->>B: Request utxos and fees for transaction

etc?

This is really cool! Do you mean the slides? Yes, that makes sense to put it in the repo.


Data Source

It seems https://ona-data.org is down. So, the link in the first blue box of chapter 3 should change to https://ona-book.org/data/koenigsberg.csv.

Many thanks!


Can anchor test loads other smart contracts?

Is there a way to load other smart contracts on my local machine when I run the anchor test command?
For some reasons (such as wanting to load metaplex when testing). During development, I use:
"solana-test-validator -r --bpf-program metaqbxxUerdq28cj1RbAWkYQm3ybzjb6a8bt518x1s ./metaplex-local-validator/mpl-token-metadata.so

I hope to load these smart contracts when running tests. I have read the documentation and cli implementation, but I did not find this function. Am I missing something? Or is there another way to achieve it?
Thank you

Yes, there are multiple ways to achieve this:

Using test.genesis (see https://www.anchor-lang.com/docs/manifest#test)
Using test.validator.clone (see https://www.anchor-lang.com/docs/manifest#test-validator)
Passing the arguments to the anchor test command (note the extra --):anchor test -- --bpf-program metaqbxxUerdq28cj1RbAWkYQm3ybzjb6a8bt518x1s ./metaplex-local-validator/mpl-token-metadata.so

Also, please use the Solana StackExchange or the Anchor Discord instead of GitHub for questions like this in the future.


[WebToolsE2E][Aspire] The attribute value column in the resource table does not support sorting yet.

REGRESSION INFO: This is a new feature added in Aspire 9.0 RC1
INSTALL STEPS

Clean machine: Win11 x64 23h2 ENU
Install SDK 8.0.402
Install Aspire 9.0 RC1 [9.0.0-preview.4.24478.1]

REPRO STEPS

Open CMD, run following command to create an Aspire Starter App project

dotnet new aspire-starter -o AspireStarterApp
cd AspireStarterApp/AspireStarterApp.AppHost

Dotnet run the project in CMD, and open URL in the browser.
dotnet run
Go to Resources page, click a resource. The attribute value column in the resource table does not support sorting.

ACTUAL
In the Resource table, the Value column does not support sorting.

EXPECTED
Should have the same appearance and functionality as the endpoint and environment variables tables.

I see that issue https://github.com/dotnet/aspire/issues/5377 has been fixed in Aspire 9.0 RC1, but the attribute value column in the resource table still does not support sorting. So I opened this issue to confirm whether it is by design.

We explicit set sortable to false in ResourceDetails, but before closing as by design, tagging @JamesNK

I'm not sure why it is false. Is there a reason to not make it true and consistent?


Integrate Overworld Map Editor with JSON project

The overworld map editor should work with the JSON project.

Closed by #190


Downgrade dependencies for use with Ruby 2.3

The dependencies pulled, require the use of Ruby 2.4. With this PR, the dependencies used, lower the minimum Ruby version to 2.3.

I don't see how this can be a good change: dependencies should be upgraded to address upstream issues. If you need to use an older version of Ruby - use an older version of the library. Happy to hear your thoughts on this

TBH, I needed to use ruby 2.3 and I couldn't get it working with an older version, as far as I can remember. Will close it.


Create endpoint for slicing zone facts

Create an endpoint that returns matching zones for any desired field from the ZoneFacts table for a user selected zone_type.
Example: user requests crime_all_12_months for the 'ward' zone type
API response:
{
  "data_id": "crime_all_12_months",
  "grouping": "ward",
  "items": [
    {
      "count": 4402,
      "group": "Ward 1"
    },
    {
      "count": 5663,
      "group": "Ward 2"
    },
    {
      "count": 1492,
      "group": "Ward 3"
    },
    {
      "count": 2646,
      "group": "Ward 4"
    },
    {
      "count": 4183,
      "group": "Ward 5"
    },
    {
      "count": 5183,
      "group": "Ward 6"
    },
    {
      "count": 3723,
      "group": "Ward 7"
    },
    {
      "count": 3255,
      "group": "Ward 8"
    }
  ]
}

This API endpoint will replace the 'summarize_observations' endpoint in the current API. Creation of various permutations of the calculations (different number of months, different type of crime incidents, etc.) will be done by the calculation of the ZoneFacts table; this endpoint will only need to handle the where zone_type='ward' portion of the query, and formatting of results.

I'm hopping on this now!

Resolved in #440


Update retrofit 2.1.0 -> 2.2.0

Overview
I have updated retrofit library version 2.1.0 -> 2.2.0.
This allows us to remove Jake's retrofit2-rxjava2-adapter dependency as retrofit itself now officially supports rxjava2-adapter. :eagle:
reference: https://github.com/square/retrofit/blob/master/CHANGELOG.md#version-220-2017-02-21

Thanks! And sorry, CI is not stable now... I'll fix it today 🙇
Anyway, thanks for continuous update! You are "friends" who is good at updating libraries 🦁

@konifar Thank you so much for your review! Actually for my PR, the CI failed as it should be, because I forgot to update license information on license.yml file. :)
You are "friends" who is good at reviewing everyones' work with a speed of light! 🐯


Always disable low-processor usage mode on mobile platforms

This partially addresses https://github.com/godotengine/godot/issues/19304.
Note: It may be easier to cherry-pick this PR by copy-pasting the relevant parts rather than using git cherry-pick.

@Calinou Thank you for this! 🎉

I don't think it's a good idea, the proper fix would be to make low processor usage actually work reliably on Android.
Additionally, there might still be use cases for it for non-game apps that don't use high FPS features.
I'm not against adding a workaround as a stopgap solution for now, but this should be done via feature tags, not hardcoded.

Superseded by https://github.com/godotengine/godot/pull/55604.


rapids_cpm_thrust doesn't place temp file in a searched location

This makes sure that find_package(Thrust) which searches a build directory doesn't accidentally use files meant for installation.

@gpucibot merge