BEAM-13939: Restructure Protos to fix namespace conflicts

Generated protobuf files contain additional information about the messages and services they were compiled from such as the file path to the original source proto file. The protobuf runtime for Golang maintains a global registry of all protobufs being used by registering the descriptors using the file path to the source proto file. If multiple descriptors with the same source file path are registered to the global registry, then the initialization code will prevent startup by panic-ing and printing a message like this to stdout:
panic: proto: file "metrics.proto" is already registered
	previously from: "github.com/apache/beam/sdks/v2/go/pkg/beam/model/pipeline_v1"
	currently from:  "..."
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

This behavior in the Go Protocol Buffer SDK is unlikely to go away:

reflect/protoregistry: restore conflicting file names check
There are inconsistencies between implementations on what happens when a single program contains generated code for multiple files with the same source path. At least one canonical implementation (C++) will fail at link time. Others print warnings. Some silently resolve the registry conflict in favor of one file or the other. The protobuf maintainers agree, however, that the desired behavior is for this condition to be an error.

This change aims to bring the protobuf imports in Beam to follow the guidance from a comment in this issue filed with the protobuf repo:

To avoid conflicts, every source .proto that is part of a program must have a unique name. Practically speaking, this means that any .proto that is part of a public package should be placed in a directory that uniquely identifies the owner of the proto. For example, google/protobuf/descriptor.proto and k8s.io/apimachinery/pkg/types both have prefixes which specify the creating organization and a specific package within that organization.

As such, I've elected to place each protobuf package in a directory org/apache/beam/model relative to its respective module root and have updated the build system where necessary.
P.S. This is still a work in progress, but opened the PR to socialize since this will affect all of Beam.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

For python, thinking it might actually be better to make the structure of apache_beam.portability.api opaque, and find some way to hoist the modules within so we don't have to change imports in the rest of the SDK, hoping to find time to investigate

R: @lukecwik

Is there an easy way to run these CI tasks locally? I'm trying some gradle tasks and some work, some don't and some that used to work don't work 😬 . Want to speed up my iteration speed, if there's a doc/readme I can read somewhere, that would be great too!

I will start here

retest this please

retest this please

@lostluck @lukecwik I think (🤞🏽 ) this is ready for a formal review

retest this please

Run Java PreCommit

Run GoPortable PreCommit

Looks good for me for the proto file changes.
R: @tvalentyn Can you review the python changes?
R: @lostluck Can you review the go changes?

Why are we losing the license header on the generated GRPC pb.go files, but not the standard pb.go files? Not really an issue, since we can ignore it in the RAT check, but it is strange.

TBH I don't know (sad). I saw that and spent some time loosely investigating. I agree that ideally we would have the license header, so I am happy to find some fix before merging! If you have tips on direction or if your google-foo is good, would love any help 🙏🏽

Why are we losing the license header on the generated GRPC pb.go files, but not the standard pb.go files? Not really an issue, since we can ignore it in the RAT check, but it is strange.

TBH I don't know (sad). I saw that and spent some time loosely investigating. I agree that ideally we would have the license header, so I am happy to find some fix before merging! If you have tips on direction or if your google-foo is good, would love any help 🙏🏽

Ok so here's the diff:
https://github.com/protocolbuffers/protobuf-go/blob/3992ea83a23c00882339f33511074d251e19822c/cmd/protoc-gen-go/internal_gengo/main.go#L73-L75
https://github.com/grpc/grpc-go/blob/f95b001a48df30dbbdb89ccb9a4781a242591651/cmd/protoc-gen-go-grpc/grpc.go#L89-L95
it's a difference in plugins, was the v1 grpc plugin used to generate the previous bindings or was the ASF manually added?

Why are we losing the license header on the generated GRPC pb.go files, but not the standard pb.go files? Not really an issue, since we can ignore it in the RAT check, but it is strange.

TBH I don't know (sad). I saw that and spent some time loosely investigating. I agree that ideally we would have the license header, so I am happy to find some fix before merging! If you have tips on direction or if your google-foo is good, would love any help 🙏🏽

It's most likely an artifact from when you were experiementing and getting things aligned properly. There's nothing that inserts the header into the files, so it should be maintaining the headers through regeneration.
At this point, I'd suggest simply re-adding the header texts manually to start, and commit that. Then we can try a re-gen with your scripts, changing nothing else. If they don't get stripped from that process, we know it was an accident as the scripts were being worked on.
If they do get stripped, we could also just use the scripts to ensure the header is prefixed onto all the generated Go files. There's a go tool that can do this: https://github.com/google/addlicense

Ha! Simutaneous posting.
Ah good find. Seems like a new thing then.
I think the headers were previously manually added. We can likely automate ensuring they're added since we have your scripts to manage it during generation. I mentioned https://github.com/google/addlicense in my other comment, which might help.

sweet, I will look into that!

It looks like addlicenses won't touch generated files
https://github.com/google/addlicense/blob/2b44b367595cb6a29e43d59dfe70ba53e6b2b213/main.go#L254-L256
so i went ahead and wrote my own hacky implementation

ping @tvalentyn, should we tag in another reviewer?

Run Java PreCommit

taking a look, sorry for delay.

no problem! take your time, glad to hear from you

Tiny note: https://github.com/apache/beam/pull/17045 is ready to go in, and it makes a necessary change to graphx/v1.proto. If there are weird merge conflicts, it should be fine if you just re-generate.
I also have a small change I need to make to that same file to fix a different bug, which would also need regeneration.

Thanks for taking on this change, @thempatel .
The new suggested import aliases for Python (proto_file_name.message_name, such as beam_runner_api_pb2.SideInput) sounds good to me. It also does not preclude from using the fully-qualified import path if someone would like that.
For further steps on this PR I'd suggest to cleanup the commit history if comments from other reviewers have been addressed.
Please do keep separate commit(s) for tooling changes, for regenerated stubs and fixes in the code to use new namespaces. I think it would be useful to break it down instead of all squashing into one change.

So the vast majority of Python changes seem to be unrelated to this (mostly go specific, already very large) change. Is there a way we could break them out and review them separately? The one change I see is that we (now) have to do renaming of the proto files in apache_beam/portability/api back to a flat structure (and fix their internal imports).

Also, for auto-generated files, I think adding them to RAT is better than modifying these files--they're (clearly marked) machine output.

So the vast majority of Python changes seem to be unrelated to this (mostly go specific, already very large) change. Is there a way we could break them out and review them separately? The one change I see is that we (now) have to do renaming of the proto files in apache_beam/portability/api back to a flat structure (and fix their internal imports).

Milan can confirm, but since the changes are rooted in changing how the proto files import each other, I don't know how separable  each change at a PR level.
Might be able to organize the changes as commits with: "proto file changes" "generator changes" "go generated code" "python things."... granularity though.
I'm ambivalent, since the go side is finished review at this point, and I don't understand the nature of the python side of the change.

Just to confirm, imports of the form from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload are no longer supported, and that's why the diff is so huge?

Just to confirm, imports of the form from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload are no longer supported, and that's why the diff is so huge?

correct, this PR changes the the proto structure from a flat one to a hierarchical one, like so:
model/
  beam_fn_api.proto
  beam_provision_api.proto
  beam_interactive_api.proto
  beam_artifact_api.proto
  ...

apache_beam/portability/api/
  beam_fn_api_pb2.py
  beam_provision_api_pb2.py
  beam_interactive_api_pb2.py
  beam_artifact_api_pb2.py
  ...

to
model/org/apache/beam/model/
    beam_fn_api.proto
    beam_provision_api.proto
    beam_interactive_api.proto
    beam_artifact_api.proto
    ...

apache_beam/portability/api/org/apache/beam/model/
    beam_fn_api_pb2.py
    beam_provision_api_pb2.py
    beam_interactive_api_pb2.py
    beam_artifact_api_pb2.py
    ...

so the reason you can no longer do from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload is because there is no module there! The fully qualified import is now apache_beam.portability.api.org.apache.beam.model.beam_runner_api_pb2 import TestStreamPayload.
In order to make this easier to work with, I updated the proto generator to also generate module bindings in the __init__ file of apache_beam.portability.api, like so
from .org.apache.beam.model import pipeline
# ...

external_transforms_pb2 = pipeline.external_transforms_pb2
# ...

so that you don't need to provide the fully qualified path. If we didn't do this, this PR would be even more huge, since we'd have to update every import of the generated bindings in the SDK

I guess @lukecwik needs to validate/approve his requested changes first.

thanks @lostluck @lukecwik @tvalentyn @robertwb for the thoughtful reviews, i had fun on this one! 🙏🏽

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Jasmine Unit Test fail : how to fixture anchors for scroll

Hi,
I insert angular-scroll in my angular app.
I insert anchors in pages targeted in controller methodes with the method scrollToElementAnimated.
It run well in the app, but all my controller methodes are tested with Jasmine tests (run with maven).
Tests fails with the error :
TypeError: 'undefined' is not an object (evaluating 'd(e).getBoundingClientRect') in http://localhost:56972/src/main/webapp/vendor/angular-scroll.min-0.7.2.js

I think the problem is that, JS tests dont have DOM elements, and when the test pass on the line :
$document.scrollToElementAnimated(angular.element(document.getElementById('myAnchorId')));

,the methode document.getElementById('myDivIdToScroll') return undefined.
How can I tell the JS Unit tests to load a fixture page or a mock for the getElementById method or directly for the scrollToElementAnimated methode?
PS : I've seen a plugin : jasmine-jquery.js that can load HTML fixtures for Jasmine Unit test but : This plugin need Jquery and I dont have it in m'y app (angular jglite only) and I do not know if this will solve the problem that I have with the angular-scroll method call.
( I even though try to use it but I didn't succeed to run it in maven jasmine plugin...)
Thank you for your help
ps: sorry for my English... ^^'

Sorry, but this is a question for stack overflow :-)

Ok Thx


PWD Help

The PWD Help Website is a comprehensive online platform designed to assist individuals with disabilities in India by providing them with valuable resources, information, and support.
Through this website, users can access a wide range of opportunities and schemes offered by the Indian government, World Bank programs, and UNICEF initiatives, aimed at improving the lives of people with disabilities.
Additionally, the website provides valuable information about disability-friendly facilities such as hotels and restaurants, as well as a curated list of special schools catering to the unique educational needs of individuals with disabilities in India.
[Issue no. #398 ]

https://github.com/Vikash-8090-Yadav/Future.WebNet/assets/113535580/78168d82-0e12-4298-8cb8-e62279595389


[2.x] FunctionScoreQuery does not reflect Elastic Document

Regarding Document on Elastic.co
I think script_score has incorrect format

The documentation you are looking is for 5.1 version.
As I see from the docs there is completely different structure to use score with script and inline.
Let me test a bit with this change, primeraly it looks good, just want to be sure not to brake things.

this bug were found through my application @saimaz
my Elasticsearch server is 5.1.1.
This commit fix a crash on my app as well ;)

Yes, but 2.x branch is only for elasticsearch 2.x, 5.0 will work only with 5.x branch. It's not released yet, but check the version matrix in the readme. There are some incompatibilities alongside with those two versions and we need to split support be dedicated version.

@weburnit If you are using ES 5.x, you should use library in 5.x version. Right now 5.x is under development, but this bug is fixed. Just pull dev-master and check it out yourself.

Solved in v2.2.1. There is also a function score test case. If there are still any problems with this query, please open an issue or provide a test case which represents the problem.
Closing by considering it's solved.


Fix warnings displayed by workflow

This PR is for fixing all warning suggested by github workflow build.

It doesn't fix all warnings
It mostly ignores the warnings. And they were left there, so we can introduce a proper handling of those cases later. Like if command requires to be used in guild (GuildId cannot be null) then it should not be registered as global, so it's not visible in dms


Support linking directly into a specific program application

Users will mostly enter into CiviForm when the apply for a specific program from affordableseattle.com.  We need to provide the program admin the URL that they should link to for that specific program. CiviForm should support guest entry into a specific application and language selection before they start the specific application.

Connected to #317 (except this one is on our side, while the other one is for other websites).

The main type of deep-linking we have to support is a link that sends the user to a program's "info" or "detail" page, which is the screen that shows up right before the applicant actually starts filling things out. Something like the below.
The URL structure would be something like civiform.seattle.gov/programs/seattle-parks-and-recreation-scholarship. The last bit of the URL could be a slugified version of the program name. If it's easier, we could use the program ID, so like civiform.seattle/gov/programs/32, but that's less readable.

cc @ndmckinley

Is it possible to have the deep link go directly into the specific program? The deep link currently takes users to the "All Programs" page of CiviForm and they have to hunt around for the right program in order to apply. The ideal state would have users click on the deep link >> login >> select language >> directs right into the specific program they originally intended.
Deep links not program specific.pdf


luci-app-mjpg-streamer: Add new module for mjpg-streamer management

Signed-off-by: Ted Hess<EMAIL_ADDRESS>

Thanks!


I still see the cursor when moving blocks

Describe the bug A clear and concise description of what the bug is.
When I move a block and I go through the start of a block I still see the cursor with a green plus which is a bit confusing for the user.
To Reproduce Steps to reproduce the behavior:

Go to a document create some blocks
Move block to the top and stay in the beginning of another block
See error

Expected behavior A clear and concise description of what you expected to
happen.
Clean moving blocks.
Screenshots If applicable, add screenshots to help explain your problem.

Please re-open if this is an issue in the new editor


add origin

@shiwk the implements of Context.Origin, add more tests

:white_check_mark: Build AElf <IP_ADDRESS>73 completed (commit https://github.com/AElfProject/AElf/commit/ccc380219e by @YueZh127)

:white_check_mark: Build AElf <IP_ADDRESS>76 completed (commit https://github.com/AElfProject/AElf/commit/a604e2c72d by @YueZh127)

@YueZh127 add a new test with inline transaction, to ensure in the inline tx, you can get the Origin,
contract A call contract B, TxA -> TxB
Test TxA's origin, and TxB's origin

:white_check_mark: Build AElf <IP_ADDRESS>26 completed (commit https://github.com/AElfProject/AElf/commit/c8b8a39189 by @YueZh127)

:white_check_mark: Build AElf <IP_ADDRESS>33 completed (commit https://github.com/AElfProject/AElf/commit/9949d55ec5 by @YueZh127)


⚠ Fortnite has degraded performance

In a980215, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1674 ms

Resolved: Fortnite performance has improved in 26ac0d0.


🐛 BUG: ReferenceError: KV is not defined

What version of Wrangler are you using?
2.0.16
What operating system are you using?
macOS
Describe the Bug
Module Syntax mode is fine (via env). but when I use Service Worker syntax, I faced error is ReferenceError: KV is not defined
index.ts
declare const KV: KVNamespace

addEventListener('fetch', (event: FetchEvent) => {
  // @ts-ignore
  console.log({ ...global })
  console.log(KV)
  event.respondWith(new Response("hello"))
})

wrangler.toml
name = "firebase-auth-example"
compatibility_date = "2022-07-05"
workers_dev = false

[vars]
PROJECT_ID = "example-project12345"

kv_namespaces = [
  { binding = "KV", id = "", preview_id = "" }
]

tsconfig = "./tsconfig.json"

Output (when commented out console.log(KV) line)
[mf:inf] Worker reloaded! (248B)
[mf:inf] Listening on localhost:8787
[mf:inf] - http://localhost:8787
{
  global: ServiceWorkerGlobalScope {},
  self: ServiceWorkerGlobalScope {},
  addEventListener: [Function: addEventListener],
  removeEventListener: [Function: removeEventListener],
  dispatchEvent: [Function: dispatchEvent],
  console: Object [console] {
    log: [Function: log],
    warn: [Function: warn],
    dir: [Function: dir],
    time: [Function: time],
    timeEnd: [Function: timeEnd],
    timeLog: [Function: timeLog],
    trace: [Function: trace],
    assert: [Function: assert],
    clear: [Function: clear],
    count: [Function: count],
    countReset: [Function: countReset],
    group: [Function: group],
    groupEnd: [Function: groupEnd],
    table: [Function: table],
    debug: [Function: debug],
    info: [Function: info],
    dirxml: [Function: dirxml],
    error: [Function: error],
    groupCollapsed: [Function: groupCollapsed],
    Console: [Function: Console],
    profile: [Function: profile],
    profileEnd: [Function: profileEnd],
    timeStamp: [Function: timeStamp],
    context: [Function: context]
  },
  setTimeout: [Function (anonymous)],
  setInterval: [Function (anonymous)],
  clearTimeout: [Function: clearTimeout],
  clearInterval: [Function: clearInterval],
  queueMicrotask: [Function: queueMicrotask],
  scheduler: Scheduler {},
  atob: [Function: atob],
  btoa: [Function: btoa],
  Math: Object [Math] {},
  crypto: Crypto {},
  CryptoKey: [Function: bound CryptoKey],
  TextDecoder: [class TextDecoder],
  TextEncoder: [class TextEncoder],
  fetch: [AsyncFunction: fetch],
  Headers: [class Headers],
  Request: [class Request extends Body],
  Response: [class Response extends Body],
  FormData: [class FormData] { name: 'FormData' },
  Blob: [class Blob],
  File: [class File extends Blob],
  URL: [class URL],
  URLSearchParams: [class URLSearchParams],
  URLPattern: [class URLPattern],
  ByteLengthQueuingStrategy: [class ByteLengthQueuingStrategy],
  CountQueuingStrategy: [class CountQueuingStrategy],
  ReadableByteStreamController: [class ReadableByteStreamController],
  ReadableStream: [class ReadableStream],
  ReadableStreamBYOBReader: [class ReadableStreamBYOBReader],
  ReadableStreamBYOBRequest: [class ReadableStreamBYOBRequest],
  ReadableStreamDefaultController: [class ReadableStreamDefaultController],
  ReadableStreamDefaultReader: [class ReadableStreamDefaultReader],
  TransformStream: [class TransformStream],
  TransformStreamDefaultController: [class TransformStreamDefaultController],
  WritableStream: [class WritableStream],
  WritableStreamDefaultController: [class WritableStreamDefaultController],
  WritableStreamDefaultWriter: [class WritableStreamDefaultWriter],
  FixedLengthStream: [class FixedLengthStream extends TransformStream],
  Event: [class Event] {
    NONE: 0,
    CAPTURING_PHASE: 1,
    AT_TARGET: 2,
    BUBBLING_PHASE: 3
  },
  EventTarget: [class EventTarget] { [Symbol(nodejs.event_target)]: true },
  AbortController: [class AbortController],
  AbortSignal: [class AbortSignal extends EventTarget],
  FetchEvent: [class FetchEvent extends Event],
  ScheduledEvent: [class ScheduledEvent extends Event],
  DOMException: [class DOMException2 extends Error] {
    INDEX_SIZE_ERR: 1,
    DOMSTRING_SIZE_ERR: 2,
    HIERARCHY_REQUEST_ERR: 3,
    WRONG_DOCUMENT_ERR: 4,
    INVALID_CHARACTER_ERR: 5,
    NO_DATA_ALLOWED_ERR: 6,
    NO_MODIFICATION_ALLOWED_ERR: 7,
    NOT_FOUND_ERR: 8,
    NOT_SUPPORTED_ERR: 9,
    INUSE_ATTRIBUTE_ERR: 10,
    INVALID_STATE_ERR: 11,
    SYNTAX_ERR: 12,
    INVALID_MODIFICATION_ERR: 13,
    NAMESPACE_ERR: 14,
    INVALID_ACCESS_ERR: 15,
    VALIDATION_ERR: 16,
    TYPE_MISMATCH_ERR: 17,
    SECURITY_ERR: 18,
    NETWORK_ERR: 19,
    ABORT_ERR: 20,
    URL_MISMATCH_ERR: 21,
    QUOTA_EXCEEDED_ERR: 22,
    TIMEOUT_ERR: 23,
    INVALID_NODE_TYPE_ERR: 24,
    DATA_CLONE_ERR: 25
  },
  WorkerGlobalScope: [class WorkerGlobalScope extends ThrowingEventTarget],
  structuredClone: [Function: structuredClone],
  ArrayBuffer: [Function: ArrayBuffer],
  Atomics: Object [Atomics] {},
  BigInt64Array: [Function: BigInt64Array],
  BigUint64Array: [Function: BigUint64Array],
  DataView: [Function: DataView],
  Date: [Function: Date],
  Float32Array: [Function: Float32Array],
  Float64Array: [Function: Float64Array],
  Int8Array: [Function: Int8Array],
  Int16Array: [Function: Int16Array],
  Int32Array: [Function: Int32Array],
  Map: [Function: Map],
  Set: [Function: Set],
  SharedArrayBuffer: [Function: SharedArrayBuffer],
  Uint8Array: [Function: Uint8Array],
  Uint8ClampedArray: [Function: Uint8ClampedArray],
  Uint16Array: [Function: Uint16Array],
  Uint32Array: [Function: Uint32Array],
  WeakMap: [Function: WeakMap],
  WeakSet: [Function: WeakSet],
  WebAssembly: Object [WebAssembly] {
    compile: [Function: compile],
    validate: [Function: validate],
    instantiate: [Function: instantiate],
    compileStreaming: [Function: compileStreaming],
    instantiateStreaming: [Function: instantiateStreaming]
  },
  MINIFLARE: true,
  caches: CacheStorage {},
  HTMLRewriter: [class HTMLRewriter],
  MessageEvent: [class MessageEvent extends Event],
  CloseEvent: [class CloseEvent extends Event],
  WebSocketPair: [Function: WebSocketPair],
  WebSocket: [class WebSocket extends InputGatedEventTarget],
  PROJECT_ID: 'example-project12345',
  kv_namespaces: [ { binding: 'KV', id: '', preview_id: '' } ],
  tsconfig: './tsconfig.json'
}

Run Command
$ wrangler dev index.ts  --config=wrangler.toml --local=true

I note that you have not specified a valid id to a KV namespace in your wrangler.toml. Is that because you have removed it for the purposes of this report or have you not specified that in your reproduction?

I'm going to close this since I've confirmed the suggested fix also works, but lemme know if it doesn't.

@threepointone Thanks!
It works on my environment.

For anyone else who may come across this, another alternative is to just move the inline-table version (as was used in the OP for kv_namespaces), to be before all other arrays (i.e. the "sections" surrounded in double-square-brackets, [[array_item]] in the config file).
This behaviour actually has nothing to do with Wrangler, and is just how the TOML format works: https://toml.io/en/v1.0.0


Implement empty macros, -D, ?=, and or

Closes #52 and #65.

Awesome, it looks like the failing Travis tests are because of something trivial. I'll be checking this tonight :)

Build's green now!

You are gentleman and a scholar

I'll close the relevant issues once I stress test these new additions tonight or tomorrow afternoon


[TempMail] ...

Extension
https://www.raycast.com/Joshlucpoll/tempmail
Description

Error:

Steps To Reproduce

On raycast on macbook pro with macOS 13.4
View Email is not working.

Current Behaviour
No response
Expected Behaviour
No response

Hey @Arnav12S, is this with all emails you try to open or just one?

Hmm, do you have the specific error message @Arnav12S ? Also have you tried to reset TempMail using the 'Reset TempMail' command? That might solve the problem

@Arnav12S I've pushed a new release for TempMail, can you update the extension and let me know if your problem is fixed? Thanks


added input type as number

Inspector P2 - Better control for number input (something like up/down that we can manipulate with mouse)
Ref - https://www.w3.org/TR/2010/WD-html-markup-20101019/input.number.html
Browser support ->https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number#Browser_compatibility

Well I used to have that before but I had to remove it because of negative numbers (also can you check if you can manually enter a value?)

Hmm.. but position can be negative right ? and for alpha I can add min="0" to avoid negative values. @deltakosh did I miss anything ?

Well I can test if you want but when I used input type=number I was not able to enter negative value manually (using the keyboard)

yeah, solution would to add min property in code, but I don't want to generalise it as for some other control, a negative value would be a valid option. That's why having separate checks is better :)

ok but then this won't work for now as if I want to specify a negative number then I will not let me do it

I haven't added the "min" property so it will work :)
Regarding entering -ve values manually I can say -
I can't check for edge but it's working on rest 3.

No thank you!


diff views/materialized views

same as https://github.com/gimenete/dbdiff/issues/9
will send a PR when I get around to it if nobody else has

Thanks a lot @contra
I've merged all your PRs and published a new version. Thanks a lot again!


[SPARK-48655][SQL] SPJ: Add tests for shuffle skipping for aggregate queries

What changes were proposed in this pull request?
Add unit test in KeyGroupedPartitionSuite to verify that aggregation can also skip shuffle if key matches partition key
Why are the changes needed?
This lacked test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran unit test
Was this patch authored or co-authored using generative AI tooling?
No

@sunchao can you take a look?
Ill next take a look at less group keys than partition keys / incompatible groups, not sure if we can support those.

Merged to master, thanks!


System provide error instead of suggesting a merge

I believe it would be more intuitive to allow users to review the duplicate and decide to merge or not. Currently, my users receive an error and can't save the added information and get frustrated with the workflow. It's there a solution for this instance?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db3b3856-c29f-25db-0987-5306401ccbe9
Version Independent ID: 0caa7372-d8f0-b253-4f8f-be414eb21f77
Content: Set up duplicate detection rules to keep your data clean in Dynamics 365 for Customer Engagement apps
Content Source: ce/customerengagement/on-premises/admin/set-up-duplicate-detection-rules-keep-data-clean.md
Service: crm-online
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@pb1051
Thanks for the suggestion. I have passed this information on to the product team.


Warnings and vulnerability report

Warnings
Passive Mixed Content over HTTPS
url - https://airbrake.io/docs/installing-airbrake/installing-airbrake-in-a-magento-app/
asset - http://f.cl.ly/items/0e2f2R2I0i081N2w3R0a/php.jpg
url - https://airbrake.io/docs/features/private-sourcemaps/
asset - http://f.cl.ly/items/443E2J1D2W3x1E1u3j1u/JS-airbrakeman.jpg
Resolution
Migrate assets to https

Resolved by #204


Reorganize the Singularity install doc

The main things:

Two verification sections are h3's belonging to the priv vs unpriv track instead of h2's
Used the original wording of the priv vs unpriv note

New layout viewable here: https://opensciencegrid.github.io/docs-itb/worker-node/install-singularity/

@DrDaveD good catch! Please re-review

Travis failed, but it doesn't seem to be related to the changes.


Mike-Bug: Remove references to the deprecated entity Client Registration

🐞 Bug Report
Affected Command
Any reference to Export Services/Client Registration should be removed as it has been removed for Geneva. We will probably have to figure out best way to manage (if needed) App Service Configurable
edgex-cli/cmd/status/status.go
Line 55 in 40e914d
microservices["Client Registration"] = "48071"
 The issue is located in:
Is this a regression?
No
Description and Minimal Reproduction
🔥 Exception or Error

🌍  Your Environment
Deployment Environment:
EdgeX Fuji
Anything else relevant?

addressed https://github.com/edgexfoundry-holding/edgex-cli/pull/152
Still need to figure out best way to manage (if needed) App Service Configurable


vscode-extensions.vadimcn.vscode-lldb: 1.6.1 -> 1.6.2

Motivation for this change
Version bump.
The dependencies of node package didn't change, so it's not required to regenerate the whole node-packages.nix.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
335.5M -> 354.6M
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119945 at 0976b4e6 run on x86_64-linux 1

1 package built successfully:

vscode-extensions.vadimcn.vscode-lldb

3 suggestions:

warning: fixup-phase
fixupPhase should not be overridden, use postFixup instead.
Near pkgs/misc/vscode-extensions/vscode-lldb/default.nix:83:3:
   |
83 |   fixupPhase = ''
   |   ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/misc/vscode-extensions/vscode-lldb/default.nix:53:15:
   |
53 |   patches = [ ./cmake-build-extension-only.patch ];
   |               ^

warning: unused-argument
Unused argument: jq.
Near pkgs/misc/vscode-extensions/vscode-lldb/default.nix:1:60:
  |
1 | { lib, stdenv, fetchFromGitHub, rustPlatform, makeWrapper, jq, callPackage
  |                                                            ^

Please remove jq from inputs and use postFixup like the bot discovered.

ping @SuperSandro2000

Seems the extension on master is broken due to splitting output of lldb. This update fixes that issue. Now ready to be reviewed.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/546


List index out of range before exchanging

Currently I have 0 pokemons, that might be the issue?
[#] Something rustles nearby!
[#] A Wild Scyther appeared! [CP25]
[x] Using Pokeball...
[x] Captured Scyther! [CP25] - exchanging for candy
[x] Exchanged successfuly!
Traceback (most recent call last):
  File "pokecli.py", line 116, in <module>
    main()
  File "pokecli.py", line 113, in main
    bot.take_step()
  File "/home/alvaro/Pokemon/PokemonGo-Bot.git/bot.py", line 29, in take_step
    self.stepper.take_step()
  File "/home/alvaro/Pokemon/PokemonGo-Bot.git/stepper.py", line 64, in take_step
    self.bot.work_on_cell(cell,position)
  File "/home/alvaro/Pokemon/PokemonGo-Bot.git/bot.py", line 36, in work_on_cell
    worker.work()
  File "/home/alvaro/Pokemon/PokemonGo-Bot.git/cell_workers/pokemon_catch_worker.py", line 77, in work
    self.transfer_pokemon(list(Set(id_list2) - Set(id_list1))[0])
IndexError: list index out of range

#122

Sorry


[directory] patterns will now match relative paths of files within th…

…e instance directory
Previously, patterns were compared to the absolute pathnames of files using fnmatch. For example, a pattern foo would not match a file named foo in directory bar. Instead you would have to specify the absolute pathname of foo as the pattern. This commit changes the directory check so that a pattern foo will match a file named foo in a directory bar (but it must match the relative path. A pattern foo will not match a file named foo in a subdirectory of bar called baz. The pattern would need to be baz/foo to match this file).
Motivation
It is unintuitive (and tedious) to specify the absolute path of a file as a pattern to match that file. The alternative of prepending a * to all file names wouldn't work in all cases (e.g. in a directory with files named bar and foobar, it isn't possible to write a pattern that will only match bar).
Testing Guidelines
The directory integration's tests were updated to test this feature.
Additional Notes

Thanks @cmatteri, changes LGTM.
Before merging, could you do the following:

update the conf.yaml.example accordingly to the changes.
bump the check version in manifest.json.
update the CHANGELOG adding a section Unreleased containing link and description to this PR so we don't forget about it during the release.


Fixed log typo

fixed https://github.com/SamKirkland/FTP-Deploy-Action/issues/130

Thanks for the fix ❤


Add io2 drives and allow ES to use it if shown it

This starts working towards exploring the new gp3, io2 and io2 block express cloud drive families AWS has released. Makes progress towards #20 but since @jsjeannotte has requested we focus on io2 for elasticsearch.
Also adds the ability for callers to request specific hardware (instance families or drive families).

Will close #20


Finalized Market Header doesn't show show winning outcome

https://augur.casino/id=0x4ce1f159b8e2ed4f32684b16f933e2273f09513b
https://augur.casino/id=0xfd23e32d0902b3d1ae24986d34e1a59d10f87f2d
between these 2 finalized markets, one shows the winning outcome and the other doesn't. Both are finalized.

Won't Fix V1 Issue


Closes #3217

Description (required)
Fixes #3217 NullPointerException at ContributionsFragment.onAuthCookieAcquire when starting the app after a few hours
What changes did you make and why?
uploadServiceIntent throws null pointer exception onActivity recreation
Tests performed (required)
Tested ProdDebug} on Pixel2 with API level 27.

Codecov Report

Merging #3220 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3220      +/-   ##
=========================================
- Coverage    6.22%   6.22%   -0.01%
=========================================
  Files         264     264
  Lines       11205   11208       +3
  Branches      851     850       -1
=========================================
  Hits          698     698
- Misses      10450   10453       +3
  Partials       57      57

Impacted Files
Coverage Δ

...w/commons/contributions/ContributionsFragment.java
0% <0%> (ø)
:arrow_up:

...r/free/nrw/commons/contributions/MainActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891d9ec...0fee2d3. Read the comment docs.


[vb.net] Doesn't work in XP

Hello,
I am trying to use this library in my app. Here is the code I was testing:
Dim ts As New TaskService()
Dim td As TaskDefinition = ts.NewTask
td.RegistrationInfo.Description = "Test"
Dim dt As New BootTrigger
dt.Repetition.Interval = TimeSpan.FromMinutes(20)
dt.Delay = TimeSpan.FromMinutes(20)
td.Settings.Hidden = True
td.Triggers.Add(dt)
td.Actions.Add(New ExecAction("notepad.exe", "C:\test.log", Nothing))
ts.RootFolder.RegisterTaskDefinition("Test", td)
It's based on the provided example. It works well in Win 7 X64, I tried it on XP 32 and it didn't work. I am not sure why it's not working. Any help would be appreciated.
Thanks
Originally posted: 2012-05-20T15:42:41

You must set dt.Repetition.Duration to a value larger than the Interval under XP. You should be getting an exception that says that. Everything else looks good.
Originally posted: 2012-05-21T07:27:43

Thank you Dahall, yes I did actually, right after my post. I tried this:
Added:
dt.StartBoundary = DateTime.Now.AddMinutes(20)    ' Got from another thread with a similar issue
dt.Repetition.Duration = TimeSpan.FromDays(1)
I didn't get any errors, but the task still not added! Is there anything thing else need to be defined, in order to make work under XP.
Originally posted: 2012-05-21T08:45:25

Adding 20 minutes to the StartBoundary doesn't do anything with a BootTrigger. I'd leave that out.
You have set the Hidden property to true. If you didn't get any errors, the task may have been created and is just not visible. Under XP, you can open a Command Prompt, go to the \Windows\System32\Tasks folder and look to see if the "Test" file exists when you do "dir /ah" to view hidden files.
Originally posted: 2012-05-21T10:04:49

hi Dahall, Thanks for your replay. you're completely right. It was there but hidden. I removed the startboundary, it didn't make any difference.
The only issue now! It's not set right. if the same code is excuted under win 7 it will be triggered at start-up and then repeated every 20 min. In XP, it only starts up and it doesn't repeat. I am not sure if this option is supported under xp, but not sure.
Originally posted: 2012-05-21T10:57:32

This may be a subtle difference of the BootTrigger between versions.
Originally posted: 2012-05-23T18:55:16


[RFC] Drop digital bitbox (Bitbox01)

Should we drop the Digital BitBox (BitBox01)?
Shift Crypto has stopped manufacturing and selling this device. Furthermore, according to their website, they will be dropping support for this device this November.
The Digital BitBox also has some quirks with passphrases, backups, restoring, and setup. This has resulted in a little strangeness in our APIs for those things that we could cleanup with the removal of the Digital BitBox. It also doesn't quite conform to our "universal API" goal. The passphrase isn't a BIP 39 passphrase which differs from every other device. Rather it is used for encrypted communications and needs to be provided with every command.
Lastly the Digital BitBox doesn't have a screen which brings into question the safety of using the device. We may not want to appear to be endorsing the device (even though inclusion of a device is not an endorsement, it can seem like it is).

Conversely, the Digital BitBox doesn't really cause us any problems. It's implementation is self contained and it's a nice test case to see if some parts of our API has been broken.

If it's not causing problems I say hold onto it for now. If it does down the line, nuke it?

Maybe some trouble: #567


Please Add Eureka, CA to the list

To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Commit to reallocate for social equity
Message:
To whom it may concern,
I am a resident of Eureka's [X]  Ward. I am writing to demand that the City Council adopt a budget strategy that prioritizes community well-being and redirects funding away from the police in the next budget evaluation period.
We have seen mounting evidence that police departments are ineffective institutions that marginalize minority communities and put citizens at risk of injury and death, yet the police budget accounts for 46% of our general fund (see this article). I ask that you redirect the majority of the $14.2M allotted for crime prevention toward community programs that provide citizens with basic human needs, like affordable healthcare and housing. We don’t need a militarized police force. We need to create a space in which more mental health service providers, social workers, victim/survivor advocates, religious leaders, neighbors, and friends - all of the people who really make up our community - can look out for one another. This is of course a long transition process, but real, actionable change starts with reallocating funding and investing in inclusive and diverse support strategies for our community.
As the City Council, the budget proposal is in your hands. It is your duty to represent your constituents. I am urging you to completely revise the budget for the 2020-2021 fiscal year. We can be a beacon for other cities to follow if only we have the courage to change.
Thank you for your time,
[NAME]
[ADDRESS]
[PHONE NUMBER]
[EMAIL ADDRESS]

on it now

Holy moly thank y’all so much !!

on it now

Lifesaver thank you for your time and work


HDDS-1758. Add replication and key deletion tests to MiniOzoneChaosCluster. Contributed by Mukul Kumar Singh.

This patch adds key deletion and replication manager capability to MiniOzoneChaosCluster.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
51
Maven dependency ordering for branch

+1
mvninstall
485
trunk passed

+1
compile
259
trunk passed

+1
checkstyle
76
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
888
branch has no errors when building and testing our client artifacts.

+1
javadoc
164
trunk passed

0
spotbugs
313
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
504
trunk passed

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
440
the patch passed

+1
compile
269
the patch passed

+1
javac
269
the patch passed

+1
checkstyle
80
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
650
patch has no errors when building and testing our client artifacts.

+1
javadoc
158
the patch passed

+1
findbugs
519
the patch passed

_ Other Tests _

+1
unit
241
hadoop-hdds in the patch passed.

-1
unit
1247
hadoop-ozone in the patch failed.

+1
asflicense
35
The patch does not generate ASF License warnings.

6295

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1049/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1049

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux cc9804cd8014 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 15d82fc

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1049/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1049/1/testReport/

Max. process+thread count
5070 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1049/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks @mukul. The patch looks good to me. I am
+1 on this.


closes #12: logback logging configuration support

@JonasKunz I am missing the automatic logging updates on properties change, I was not sure how can I have this expression annotation thingy set.. I would do this in the additional commit and add this feature in the documentation as well -> as soon as you show me the way :smile: .
Some info:

I kept using the piccolo parser as in the original project, this way we are not interacting with system Sax parser and having everything we need in our own class loader..
disabling of the console or file appenders is done with logback filters, I am not aware of better solution..

Regarding the dynamic configuration changes:
It would be easiest to pass the ApplicationContext to the LogbackInitializer.init method.
There you can then register a listener. The listener should be specialized for InspectitConfigChangedEvents. In this listener you the ncompare the relevant proeprties of the old configuration with the new ones. If a change has occurred, reinit the logging.


evaluate_results is slow, should only calculate new results

The mock community eval_framework.evaluate_results function takes a very long time to run. Would be greatly improved by one or both of the following:

only add new results, do not recalculate full table (e.g., for pre-computed results that are already calculated in data/precomputed-results/mock-community/mock_results.tsv. Unless if new parameter force=True.
make the code that we are using more efficient. My hunch is that using biom tables is slowing us down.

This functionality now exists with append and force parameters. From the docs:
            if force=   append= Action
                True	True	Append new to results_fp; pre-existing results
                                are overwritten if they are requested by the
                                "results params": dataset_ids, reference_ids,
                                method_ids, parameter_ids. If these should be
                                excluded and results_fp should only include
                                results specifically requested, use force==True
                                and append==False.
                True	False	Overwrite results_fp with results requested by
                                "results params".
                False	True	Load results_fp and append new to results_fp;
                                pre-existing results are not overwritten even
                                if requested by "results params".
                False	False	Load results_fp. If "results params" are set,
                                the dataframe returned by this function is
                                automatically filtered to include only those
                                results.


Adds a clear error message to address a common student misuse of geo_mean

Description
Many of my students wrote geo_mean(x, y) when they needed to write geo_mean(hstack([x, y])). They would get a type error about strict inequalities not being allowed, and be stuck on how to fix the issue. This was disappointing because we encouraged them to pay a lot of attention to error messages, so having a bad error message undermined our ability to make this point.
In order, to guide users to the correct use of the atom, I added an error message when the second argument is $p$. Further, I went through the atoms table and did not find any other atoms who are both sensibly used as a multiple argument function (I think norm taking a vector input is obvious enough there's no need to warn on it) and had a second argument which wasn't what someone might naively think. If I missed any please let me know and I'll add it to this PR.
Do we want tests of error messages? If so, I'll happily add one, but I don't recall the rules on atom testing tbh.
Type of change

[x] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[ ] Bug fix
[x] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[x] Check that your code adheres to our coding style.
[ ] Write unittests.
[ ] Run the unittests and check that they’re passing.
[ ] Run the benchmarks to make sure your change doesn’t introduce a regression.

We do have tests for error messages. There should be some examples in test_atoms.py Could you take a look and add a test?

FWIW: At the last tutorial a typical path for the $\sqrt{x^2 + 1}$ example was:

cp.norm2(x, 1), raises ValueError("Invalid argument for axis.")
cp.norm2([x, 1]), raises ValueError: The input must be a single CVXPY Expression, not a list. Combine Expressions using atoms such as bmat, hstack, and vstack.
cp.norm2(cp.hstack([x, 1])) -> success on 3rd try

So there is at least some evidence that indicates we should add a similar message for norms.

I added a test and fixed the linter errors.


Factor out tests for inclusion of parts of LinkedClasses in Emitter and ScalaJSClassEmitter

Follow up to #1757.

Closing as won't fix, because the tests done by ScalaJSClassEmitter are only for Rhino, and Rhino will be removed, so this will be soon be a non-issue.


Fix abusing URI scheme

Task/Issue URL: https://app.asana.com/0/4665784270797/1148690082200046
Tech Design URL:
CC:
Description:
Certain URL schemes can cause undesired consequences when loaded as part of an iFrame. We released a patch for API 24+, however this one aims to solve the issue in lower APIs as well.
As part of this PR I have rolled back the changes done for the 24+ patch since they are not needed anymore.
Steps to test this PR:
Normal behaviour

Go to yelp.com, select any restaurant and click on the call button.
You should see a dialog asking you to open in another app.
Clicking on "Yes" should open the phone app.
Clicking on "No" should cancel the dialog.
Selecting "Close tab" should close the tab and remove from the tab switcher screen.

Normal behaviour intents

Open the Google PlayStore in the browser
Click in the "Open in play store app" button at the bottom of the screen
You should see a dialog asking you to open in another app
Clicking on "Yes" should open the phone app.
Clicking on "No" should cancel the dialog.
Selecting "Close tab" should close the tab and remove from the tab switcher screen.

Abusing URI schemes

Open http://qfe8.000webhostapp.com/death.html
You should see a dialog asking you to open in another app.
Immediately closing the dialog will triggered it again due to the website making several requests.
Selecting "Close tab" should dismiss the dialog and close the tab taking you back to a safe place.

Multi selection test
By default we directly launch the email, sms and phone apps without letting the user select any other apps that can also handle those intents. We do let them choose for other cases. To test this:

Install Skype
Change the line 442 in BrowserTabFragment to openExternalDialog(intent, requireContext(), null, false) to allow multiple selection for the phone scheme.
Open yelp, find a restaurant and tap the call button.
A dialog should appear with the normal options but when clicking on "Yes" that will trigger a new dialog/bottom sheet (depending on the OS version) asking you to choose the app that you want to use.

Internal references:
Software Engineering Expectations
Technical Design Template

This is getting close. There are a couple of tiny clean up tasks and we need to protect against long SMS url crashes as I can still crash the sms app with http://qfe8.000webhostapp.com/killsms.html from the HackerOne report and even a reboot doesn't fix it - the only way to recover is to clear data and caches which most users wouldn't know to do.
Can we limit the SMS url size to something really large but that doesn't crash e.g 10,000 chars (or whatever is appropriate)?

Thanks for the review! I have added a maximum length for the email, sms and phone schemes to avoid that issue. Let me know if you are happy with the sizes :)

How is a brand new coder supposed to get answers if he does not follow and learn from the ones with much greater knowledge.  I sorry for just starting out at an older age just wanting to learn something new.  the other major sites have encouraged me to learn and get answers to all my questions and here I getting shamed and kicked off of post I really need to learn about.  I never thought it would be like that at GitHub.   Tim


trilium-{desktop,server}: 0.60.4 -> 0.61.13

Description of changes
Link to changelog
This version can only be used if the prior installed version is 0.60.x. Not sure if we can enforce this at package level, but the 0.60.x upgrade was backported for 23.05 in https://github.com/NixOS/nixpkgs/pull/253795 since September thanks to @FliegendeWurst .
Also cleaned up some unused code.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This version can only be used if the prior installed version is 0.60.x. Not sure if we can enforce this at package level, but the 0.60.x upgrade was backported for 22.05 in https://github.com/NixOS/nixpkgs/pull/253795 since September thanks to @FliegendeWurst .

We can document it in https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md#backward-incompatibilities-sec-release-2311-incompatibilities
For example, there is already: "consul has been updated to 1.16.0. [...]. Once a new Consul version has started and upgraded its data directory, it generally cannot be downgraded to the previous version." For Trilium, we also need to mention that users need to run 0.60.X at least once before upgrading to NixOS 23.11.

This version can only be used if the prior installed version is 0.60.x. Not sure if we can enforce this at package level, but the 0.60.x upgrade was backported for 22.05 in #253795 since September thanks to @FliegendeWurst .

We can document it in https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md#backward-incompatibilities-sec-release-2311-incompatibilities
For example, there is already: "consul has been updated to 1.16.0. [...]. Once a new Consul version has started and upgraded its data directory, it generally cannot be downgraded to the previous version." For Trilium, we also need to mention that users need to run 0.60.X at least once before upgrading to NixOS 23.11.

Really good point. Added an entry to the release note, let me know if it's clear enough.

By the way, it was recently suggested that we switch to nixpkgs' electron (instead of patching the binary). I think we can attempt that in another PR once 23.11 is branched off.

By the way, it was recently suggested that we switch to nixpkgs' electron (instead of patching the binary). I think we can attempt that in another PR once 23.11 is branched off.

@FliegendeWurst , sure, we can give that a try. Do you have more info on the subject?

By the way, it was recently suggested that we switch to nixpkgs' electron (instead of patching the binary). I think we can attempt that in another PR once 23.11 is branched off.

@FliegendeWurst , sure, we can give that a try. Do you have more info on the subject?

Most recently this sort of change was done in #266084.

Please fix the merge conflict. I suspect the conflict is in the rl-notes.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1222

Another merge conflict in the rl notes?
And 0.61.14 was released a few hours ago.

Another merge conflict in the rl notes?
0.61.14 was released a few hours ago with some important bugfixes.

Done.


List deserialization (serde) broken (tested with bincode)

The List type does not correctly serialize its size (serde), thus breaking any serialization implementation (tested with bincode) that requires a correct length. The test below serializes and then immediately deserializes a List of length 5 with a maximum size of 32, but the serialized data contains the length<PHONE_NUMBER>000000 (32), thus breaking the deserialization.
---- test::bincode_sszlist stdout ----
[ethereum-runner/src/bin/eth-runner-inprocess.rs:64] list.encode_hex::<String>() = "48656c6c6f"
[ethereum-runner/src/bin/eth-runner-inprocess.rs:66] data.encode_hex::<String>() = "200000000000000048656c6c6f"
thread 'test::bincode_sszlist' panicked at ethereum-runner/src/bin/eth-runner-inprocess.rs:67:65:
called `Result::unwrap()` on an `Err` value: Io(Kind(UnexpectedEof))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

#[cfg(test)]
mod test {
    use hex::ToHex;
    use ssz_rs::List;

    #[test]
    fn bincode_sszlist() {
        type MyList = List<u8, 32>;

        let mut list: MyList = MyList::default();
        list.push(b'H');
        list.push(b'e');
        list.push(b'l');
        list.push(b'l');
        list.push(b'o');
        dbg!(list.encode_hex::<String>());

        let data = bincode::serialize(&list).unwrap();
        dbg!(data.encode_hex::<String>());

        let out: MyList = bincode::deserialize(data.as_slice()).unwrap();
    }
}

[dependencies]
ssz-rs = { package = "ssz_rs", version = "0.9.0" }
bincode = "1.3.3"
hex = { version = "0.4.3", features = ["serde"] }

it seems that this is only an issue w/ bincode and this repo doesn't aim to support any possible serialization scheme, just ssz.
if you try your example w/ just the relevant SimpleSerialize and serde traits, there is no problem with encoding/decoding
it looks like there are specific bincode traits to derive Encode and Decode -- do you still have this problem if you derive those on your type?

if you try your example w/ just the relevant SimpleSerialize and serde traits, there is no problem with encoding/decoding

bincode just uses serde and its derived types. I assume there is no issue when using other serde formats (e.g. serde_json) because they don't rely on the size for deserialization.

it looks like there are specific bincode traits to derive Encode and Decode

Not that I know of and I couldn't find specific traits in bincode. As mentioned above: As far as I can tell bincode just uses the serde types.
In fact, when I tell the serde derive macro to set the correct length everything works as expected:
pub mod sszlist_hotfix {
    use serde::ser::SerializeSeq;
    use ssz_rs::List;

    pub fn serialize<S, T, const N: usize>(
        value: &List<T, N>,
        serializer: S,
    ) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
        T: ssz_rs::SimpleSerialize + serde::Serialize,
    {
        let mut seq = serializer.serialize_seq(Some(value.len()))?;
        for element in value.iter() {
            seq.serialize_element(element)?;
        }
        seq.end()
    }

The following is the serde::Serialize implementation for List<T, N> in ssz-rs. According to the documentation of serde, this argument is not the max size but the actual amount of elements.
#[cfg(feature = "serde")]
impl<T: SimpleSerialize + serde::Serialize, const N: usize> serde::Serialize for List<T, N> {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
    {
        let mut seq = serializer.serialize_seq(Some(N))?;      // <---- Bug?
        for element in &self.data {
            seq.serialize_element(element)?;
        }
        seq.end()
    }
}

The argument is the number of elements in the sequence, which may or may not be computable before the sequence is iterated.

Not that I know of and I couldn't find specific traits

ah sorry, looks like this is in version 2 of bincode and im not sure what the difference is

his argument is not the max size but the actual amount of elements.

yeah, I see this and I think you are correct this is a bug! thanks for raising this issue
I'll triple-check and go fix today if its an issue

@DragonDev1906 this should work now after #111
let me know if you have any trouble


multilingual chatbot

Rasa Core version: 0.9.6
Python version: python 3
Operating system (windows, osx, ...): Ubuntu
Issue:
I want to build a multilingual chatbot. for EX, when a user starts a conversation in French, The bot will response in French. if user types something in English, the bot will start the conversation in English. How can I do this? (I will use google translate API to detect language and translate)
My idea is:

Create multiple agents in some languages
Choose a default language, but allow switching to the other languages
Use language detection.
but I do not know how to make it work .

Content of domain file (if used & relevant):

I want to detect the language which user uses and translate user input into French before tokenization, featurization, extraction...
Could you tell me from the code, where should I modify it?

I think the ideal case here would be to have seperate bots that get loaded dependent on whether the language detected was english or french. I don't think translating the user input into french is such a good idea, google translate often messes that up and so you might not get the meaning you want

@akelad in run_bot(), how can I get the latest message from user?. I tried: DialogueStateTracker.latest_message but It gives me the error: type object 'DialogueStateTracker' has no attribute 'latest_message'

I want to get the latest_message to detect the language user uses

It's best to do that in a custom action, where you can call tracker.latest_message.text

I can get it in a custom action but I want to do in bot.py file because from there, I will decide which model should be loaded

@souvikg10 I think you had some suggestions on how best to get this working?

@MinhMinnie I think the models are loaded on startup, Imo, once your model becomes very large it is not a good idea to load it on the fly based on input message. You should spin up two bots with pre-loaded models and then put an detector in the middle that diverts traffic to each bot based on language detection( we use cookies to do that) but there are other methods. but as I mentioned in Gitter I suppose - lang detect is not easy specially English and French ( they are very similar in written when it comes to one word replies and you won't be able to make out anything).
Can you explain me a scenario where you might face this on a regular basis? I work in Belgium and we deal with 4 languages but never heard a scenario where people are switching languages during a conversation and for each language we manage separate channels today.

@souvikg10 Could you help me please?
I start the conversation by "Get started" button in fb messenger.
The bot gives me 3 options, "Choose a language" is one of them
After choosing "Choose a language", I have 2 choices : English and Français (I have 2 models : English and French)
The bot is pre loaded with English model
If I click on button "Français", How to reload the bot with the French model?

i wrote the solution in the above comment, create two bots in each language and use the same tracker store

@souvikg10 but in my case, the English model is loaded before the user chooses "French model". that means the user wants to switch the language during the English conversation.
I have 2 bots in each language, use Redis server as a tracker-store

You need an intermediary layer between two rasa chatbots(FR/EN), some sort of dispatcher,
Dispatcher could be a simple application in python that has a webhook for your channels or in node js(we are using botkit) this dispatcher is able to detect the user language( in case of Facebook, you can get user's profile language to start with.
In the backend you have two rasa servers with two endpoints for /parse, using the same user id you call either one of them using the ID
Channels --> Dispatcher(FR/NL) --> CoreFR OR Core NL --> TrackerStore(Redis)

I will write up an example multilingual chatbot this weekend to better describe this case using Rasa.

Thanks @souvikg10. Waiting for the example

awesome, looking forward to seeing this @souvikg10!


fix: Split settings.host into servicePath and port

I think https://github.com/googleapis/nodejs-firestore/pull/680 doesn't split the settings.host correctly into port and servicePath. We only do this for FIRESTORE_EMULATOR_HOST.

cc @thebrianchen


Documentation changes needed

create_netcdf.main, create_netcdf.make_netcdf, and create_netcdf.make_product_netcdf can now return the netCDF file as an open object.
Current method of closing file is being deprecated - need to add page about deprecation.
How to download tsv files for offline use.

Another change:

If trying to add a value to a QC flag variable that is not in the flag_values attribute, an error is raised (or a warning if the correct argument is given) - add in history page and in usage page in add data section.


🔌 Added Color Space Plugins & Webpack ES/CommonJS Modules

Added

Simplified logic of CM constructor
LAB[A] HSV[A], HWB[A], XYZ[A], LCH[A], CMYK[A] parsers - along with respective plugins - and fully tested them
Community documents such as CONTRIBUTING.md
Issue & PR templates

Fixed

README to include more plugin information
typeGuard logic to be more specific in scope
Logic in parsers for object clamping

Changed

Webpack to not give sourcemaps
Produce ES and CommonJS modules during bundling
Test CI GitHub Action to use a matrix build - test common NodeJS version in parallel
Exports field in package.json to show in bundlephobia
Adjusted Jest config to reduce CLI command

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bdba44b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master       #17   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?        33
  Lines             ?       554
  Branches          ?       150
==========================================
  Hits              ?       554
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdba44b...81fe3f2. Read the comment docs.


feat: add statutory events on dashboard

First need the back-end PR for oms-statutory #226

:tada: This PR is included in version 0.38.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add subframe tutorial

Add subframe tutorial
Add resolve contraint frames to other tutorials, (so if people want to use subframes from those tutorials it would work)

Currently blocked by https://github.com/ros-planning/moveit_resources/pull/64

This demo also suffers from this bug

This is correct. Anything using move_group with and attached object is effected.

I get errors saying the move is timing out every once in a while (someone testing calibration with the Panda robot was saying they were have the same issue)

In the case that you get these errors. Is the tutorial still working or not?

Everything works as expected, except for the message printing.

Everything works as expected, except for the message printing.

I will have a look and try to understand what happens

Today I updated all of my moveit repos and tried to test this branch again and it is seg faulting when I run this demo.  I double checked to make sure default_planner_request_adapters/ResolveConstraintFrames was listed in ompl_planning_pipeline.launch.xml and it is but not in the recommended order that is suggested in the Troubleshooting section. Changing the order didnt help so I will keep digging for the issue...
[ERROR] [move_group-4]: process has died [pid 221215, exit code -11, cmd '/home/marq/moveit_ws/install/moveit_ros_move_group/lib/moveit_ros_move_group/move_group --ros-args --params-file /tmp/launch_params_ta9prs0_ --params-file /tmp/launch_params_4lmt_ds2 --params-file /tmp/launch_params_rpy3poyd --params-file /tmp/launch_params_yt8jqzwb --params-file /tmp/launch_params_8j_mcseo --params-file /tmp/launch_params_sg8szb1i --params-file /tmp/launch_params_z_jhxddx'].

Today I updated all of my moveit repos and tried to test this branch again and it is seg faulting when I run this demo. I double checked to make sure default_planner_request_adapters/ResolveConstraintFrames was listed in ompl_planning_pipeline.launch.xml and it is but not in the recommended order that is suggested in the Troubleshooting section. Changing the order didnt help so I will keep digging for the issue...

Thanks for digging in @MarqRazz I'll also have a look soon. I completely forgot this existed lol

Same with #80.


微信登录分享和支付无法授权成功～闪一下就没了～

Your questions.

Environment.

Mobile model: 华为荣耀10
Mobile system:安卓 8
Dev platform: darwin
Node: v9.2.0
Npm: 6.4.1

What do you think may be caused by the analysis of the problem.

微信开放平台生成的签名和包名一致 在app内点击授权 报错信息
https://developer.umeng.com/docs/66632/detail/66787
复查 签名和包名一致
删除微信缓存重试 卸载微信 也不行

求思路
Reappearance of the problem (It's best to have a screenshot).

遇到同样的问题了


Every device went to wrong after update 2023.3.x

Logs:
Home Assistant Core
2023-03-02 23:38:37.298 WARNING (SyncWorker_4) [homeassistant.loader] We found a custom integration tuya_local which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2023-03-02 23:39:10.830 INFO (MainThread) [homeassistant.bootstrap] Setting up stage 2: {'localtuya', 'mass', 'default_config', 'search', 'waze_travel_time', 'diagnostics', 'input_number', 'config', 'withings', 'logbook', 'scene', 'person', 'open_meteo', 'my', 'alarm_control_panel', 'image_upload', 'mobile_app', 'energy', 'repairs', 'rpi_power', 'raspberry_pi', 'conversation', 'device_automation', 'input_boolean', 'media_player', 'tts', 'upnp', 'homeassistant_alerts', 'tuya', 'media_source', 'blueprint', 'input_text', 'trace', 'icloud', 'auth', 'radio_browser', 'cast', 'switch', 'hacs', 'plex', 'synology_dsm', 'sun', 'local_ip', 'google_assistant_sdk', 'xiaomi_airfryer', 'scrape', 'input_select', 'tag', 'google', 'sensor', 'speedtestdotnet', 'group', 'timer', 'daikin', 'ipp', 'tuya_local', 'camera', 'history', 'dlna_dms', 'input_datetime', 'ffmpeg', 'mqtt', 'zone', 'homeassistant_hardware', 'hardware', 'samsungtv', 'homeassistant_sky_connect', 'shell_command', 'zha', 'watchman', 'onboarding', 'file_upload', 'androidtv', 'analytics', 'thread', 'jellyfin', 'persistent_notification', 'cpuspeed', 'input_button', 'script', 'system_health', 'smartthings', 'application_credentials', 'xiaomi_miot', 'schedule', 'counter', 'lovelace', 'panel_custom', 'automation', 'map'}
2023-03-02 23:39:15.437 INFO (MainThread) [homeassistant.setup] Setting up tuya_local
2023-03-02 23:39:15.437 INFO (MainThread) [homeassistant.setup] Setup of domain tuya_local took 0.0 seconds
2023-03-02 23:39:15.576 INFO (MainThread) [custom_components.tuya_local.device] Creating device: bfb42871b042248b25mxz7
2023-03-02 23:39:15.577 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Mosógép konnektor for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.584 INFO (MainThread) [custom_components.tuya_local.device] Creating device: bf7d45aa4a47b2c585t2nx
2023-03-02 23:39:15.585 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Torolkozoszarito konnektor for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.589 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 22156617ecfabc609099
2023-03-02 23:39:15.590 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Konyhai menyezeti lampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.594 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 22156617ecfabc60952c
2023-03-02 23:39:15.594 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Nappali menyezeti lampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.599 INFO (MainThread) [custom_components.tuya_local.device] Creating device: bf4c143d28fefd43f4dla6
2023-03-02 23:39:15.600 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Ablak feloli olvasolampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.603 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 22156617ecfabc608a23
2023-03-02 23:39:15.604 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Bejarat feloli eloszoba lampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.608 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 22156617ecfabc608858
2023-03-02 23:39:15.609 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Haloszoba feloli eloszoba lampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.613 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 22156617ecfabc608bde
2023-03-02 23:39:15.615 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Haloszoba nagylampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-02 23:39:15.618 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 20268362d8bfc0080ec9
2023-03-02 23:39:15.619 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry BlitzWolf BWSH2 humidifier for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-03 00:35:04.154 INFO (MainThread) [custom_components.tuya_local.device] Creating device: bf4c143d28fefd43f4dla6
2023-03-03 00:35:04.159 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Ablak feloli olvasolampa for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-03 00:35:36.688 INFO (MainThread) [custom_components.tuya_local.device] Creating device: 20268362d8bfc0080ec9
2023-03-03 00:35:36.695 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry BlitzWolf BWSH2 humidifier for tuya_local
File "/config/custom_components/tuya_local/init.py", line 238, in async_setup_entry
File "/config/custom_components/tuya_local/device.py", line 543, in setup_device
File "/config/custom_components/tuya_local/device.py", line 65, in init
2023-03-03 00:36:40.310 WARNING (MainThread) [custom_components.tuya_local.config_flow] Connection test failed with <class 'OSError'> [Errno 98] Address in use
2023-03-03 00:39:11.307 WARNING (MainThread) [custom_components.tuya_local.config_flow] Connection test failed with <class 'OSError'> [Errno 98] Address in use

I'm not sure what the problem is, as the details of the exception are not shown in the log, only the trace of where it is thrown from which is the call to the device constructor in tinytuya.

I may need to revert the changes to poll for power/current/voltage then.  Stability is more important than working around shortcomings with specific Tuya devices.

I figured out the issue. After i uninstalled the localtuya everything came back :)


New package: RubyInstallerTeam.Ruby.3.1 version 3.1.2-1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.1 schema?

This is a partial address of #47664 in which winget would be able to manage several Ruby versions alongside each other. If this PR is okay, more PRs can be created for each major Ruby version (3.0, 2.7, etc) and then old versions that don't follow this naming schema can be deleted.

/azp run


Added mode property to backend and frontend resources

Description
Add a 'mode' property to the frontend and backend resources. Mode is a valid configuration option for HAProxy frontends and backends. See,  http://cbonte.github.io/haproxy-dconv/1.7/configuration.html#4-mode
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@dylancanfield thank you for your update.

So annoying timing, but we probably don't need this anymore as of about an hour ago...
https://github.com/sethvargo/chefspec/blob/v7.1.0/CHANGELOG.md#710-may-9-2017


Fixed navigation link for contact us

I have Fixed Navigation for Contact Us Link on Team Page for the issue #512.
@mansiruhil13 ma'am, now if u click on Contact Us , it navigates to Contact page.
Kindly add the labels and assignee while merging .
Thank you @mansiruhil13 ma'am!!

resolve conflicts

@mansiruhil13  ma'am , Kindly check it now, I have resolved the conflicts..
Thank you @mansiruhil13


Add prefix/postfix to emitted API function definitions

CALLBACK-HEAVEN> (emit-api-function-definitions (compute-c-space-translation (api-group 'testy)) *standard-output* :prefix "printf(\"hi\");" :postfix "printf(\"bye\");")

int test(int a, int b) {
    int ret;
    printf("hi");
    ret = ((int (*)(int, int))(function_index_group_testy[0]))(a, b);
    printf("bye");
    return ret;}

NIL

@notmgsk is this still [don't merge]?

No. Please give it another look.

No. Please give it another look.

Looks swell to me. I already approved last week, but don't have write access to this repo, so my approval doesn't count 😞.  Should probably summon @stylewarning to get the merge merge.

@stylewarning hand out some merge permissions


Add Polyglot Tech Blog starter

Hello,
This PR intends to add Polyglot Tech Blog, a new 11ty starter project for multilingual personal pages and blogs.
Thank you!

I'll be adding this to the starters section of the 11tybundle.dev site.

I'll be adding this to the starters section of the 11tybundle.dev site.

That sounds great, thanks! 😊

😍
<meta name="generator" content="Eleventy v2.0.1">


DCOS-57500: [UI] Add filter hiding community packages to catalog page

Add a filter to the pacakges page that
allows the user to filter for certified, community
and all packages with certified as default.
Closes https://jira.mesosphere.com/browse/DCOS-57500
Testing

Go to Catalog tab.
Verify that the new filters are shown.
Verify that clicking them works as expected.
Verify that after using the input filter, they work as expected (changing the badge nubmers, etc.).
Verify that the added tests make sense.

Trade-offs
See my comments.
Dependencies
None.
Screenshots

Snapshots are failing in CI, but passing locally.

I (hopefully) fixed a failing integration test.

i'm on it. looks like you updated the snapshots with an old version of ui-kit!

thanks for doing the heavy lifting.

i changed the behaviour of "view all" to also switch the filter to "all".
i made some structural changes to the code.
i removed some functionality that first confused me. digging through the git-history revealed that by now we should not need to "rank" packages, because they are now rendered in their own sections.

@pierrebeitz , thanks for the help.

:tada: This PR is included in version 2.143.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Process inherits vscode environment when launched by debugger

I noticed that if I launch code from the terminal, it uses a logs folder in the code-oss user data folder. But if I launch it with a debugger, it uses the code - insiders user data folder. This is because the debug adapter inherits the VSCODE_LOGS environment variable.
The terminal explicitly removes all the vscode environment variables from the terminal process. https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/terminal/node/terminalProcess.ts#L107. Maybe we should do the same when spawning debug adapters?
cc @weinand

Yes, it probably makes sense to remove VS Code environment variables.
(But there is always the risk of breaking a debug extension...)

Seems to be fixed


fix(footer): ClipboardEvent constructor throws exceptions

Remove Clipboard usage as the API is too unstable across browsers and the use case is not compelling.
Remove extraneous Bootstrap classes.

:+1:


Does Number box check Number is entered?

Checking is entered is number or not.

hii i will do it can you assign this issue to me

otherwise plz create new issue and assign it me

Hi @Kise07 , can you please assign this task to me.

Please see the Issues and raise PR.


Weak Mode

Hi there,
I'm curious why weak mode is being removed? I didn't find any issues regarding it and would advocate for it staying around.
It makes incremental adoption of flow much easier for those of us who are attempting to add it to a codebase that was largely written without the guard rails that typing provides. Just recently we've decided to start using weak mode on the areas of code proving to be costly to type.
The add any workaround is nice, but seems to make adopting flow incrementally much harder. Could anyone shed some light on why this decision was made?

@wbeard The main reason was that it wasn't maintained and had rotted to the point where it was unclear what it was doing. There was absolutely no predictability / specification. Tomorrow we could make a change that would cause @flow weak to either miss more errors or suddenly start reporting more errors.
I agree that such decisions should be taken more openly: we should have created an issue to discuss it. Instead the core team agreed (1) removing it was good to clear technical debt and minimize confusion among new users (2) something like weak mode is potentially useful for incremental adoption but needs to be designed more deliberately.

@avikchaudhuri Thank you for the quick response. I understand rot and tech debt are expensive, and appreciate the care your team is taking in making the best decisions possible to ensure this project is successful.
I would challenge that this feature helps the incremental narrative of flow and is worth having. Maybe not keeping in its current state, as it sounds like it's too expensive to maintain, but a replacement for it. I love that flow infers, rather than labeling anything not annotated as any. Our team tries to take advantage of the inference where possible. But, we also like the shortcut that weak mode provides us in adopting flow.

Is there a deliberate design for a replacement other than littering code with any, which adds meaningless clutter?  We are attempting to introduce @flow to a project with tens of thousands of JS files, and are facing pushback from some teams, because it can be very difficult to type a complex existing codebase, even with @flow's incremental approach.  Having @flow weak gets the foot in the door for developers to start seeing benefits with a minimum of pain.

I was going to suggest that one intermediate fix might be to tweak the flow suggest command to emit any for all declarations, to get a starting point for a file like @flow weak.
@object88 I would argue that typing one file completely with @flow is better than typing multiple files with @flow weak. A module is a good unit to reason about, modularly.

@avikchaudhuri, I agree, however, I am whole-heartedly in the "More Flow Please!" camp.  My issue is attempting to convince others to start adopting @flow.  Our usage of @flow weak is centered around getting people to starting being able to consume the strong typing that others have done, in the hope that they will then decide to engage further.

@avikchaudhuri , I'm going to assume that @flow weak will be going away in the next release.  I'd like to point out that there are 4500+ instances of it across github, and that could be a surprising change if the tool treats @flow weak as @flow.
Can you give some insight as to what the behavior will be once this change is released?

@object88 I'll update on this thread soon. Thanks for the thoughtful feedback. The next release was already cut before this got committed so doesn't include this change. The next to next, yes.

That would be very appreciated; thanks @avikchaudhuri .

We've reverted the removal of weak mode in time for v0.40.0. We may remove weak mode in the future, but we won't do it without having something better to replace it.

This is fantastic news!  Thank you very much -- I personally very much appreciate your listening to our feedback, and our team will benefit from the continued support.

Should weak mode be working then in 0.45.0? I'm writing a language that compiles to ES3, and it's sure not happy, even when I use "// @flow weak" and/or "flow check --weak".
I assume I could target ES6/Babel, but that would require extra compilation steps. But then again, I may need it for flow-remove-types. Hmm.
"use strict";

// @flow weak

Array.prototype.foo = function () { }

Mikes-MacBook-Pro:impulse-js mikeaustin$ flow check --weak
test.js:5
5: Array.prototype.foo = function () { }
^^^ property foo. Property not found in
5: Array.prototype.foo = function () { }
^^^^^ Array


Support transforming html templates for Angular

Summary
I'm working on integrating Jest with new Angular (a.k.a Angular 2). Since there are issues with html-loader in angular-cli, it's currently impossible for Jest to interpret HTML files correctly.
This PR adds simple check for .html files and wraps their contents in a string, introducing __TRANSFORM_HTML__ global option.
I hope this is only a temporary solution. It doesn't break anything – aims for a patch release.

Would you be able to add tests for this?

Yup, just added a test. The scenario is that source is pure html and it needs to be wrapped with string export.

For sanity I've added a test case where the __TRANSFORM_HTML__ flag is not present. This is now ready to review.

Changed the location and inlined the config, which also got simplified.

Thank you sir!


[WIP] Fix UdpTransport on macOS

To start with, this PR just adds a test that sending a metric does not throw an exception. Once Travis CI enable macOS parallel builds for us, this test should fail.
After that, we can apply the suggested fix and verify.
Relates to #42.

🥁

Failure "successful" on macOS: https://travis-ci.org/justeat/JustEat.StatsD/jobs/343973341#L327-L351

Fixed - I think this is ready to go.


Reset Demystifed 404

The link to Reset Demystified on this page is pointing to http://git-scm.com/book/en/v2/1-git-tools/_git_reset which gives a 404 error.
I wanted to fix this, but it seems that it needs to be done one a DB level to which I don't have access. :disappointed:

I see this problem too. In the Book there are a lot of links not working, maybe the old style urls are left the same after some change?
For example a "Stashing and Cleaning" url is :"https://git-scm.com/book/en/v2/1-git-tools/_git_stashing" and gives 404 error

This issue seems to be resolved.


Neo4j-JDBC doesn't work with neo4j-java-driver 4.0+

Due to various changes in both packages and API, Neo4j-JDBC won't work with the upcoming Bolt-Driver.
There is no easy / possible way to have both on the class path (1.7.x and 4.x), so there's a need for an updated JDBC driver.

Separate release/branch
updates similar to: https://github.com/neo4j/neo4j-ogm/commit/0abfefb2b5bacc291a230a111fe2ad21974ede0f

Any idea when this would be available?
This is actually blocking anyone wishing to upgrade to spring boot 2.2 + OGM 3.2.2 ... :-/
(OGM 3.2.2 depends on neo4j-java-driver 4.0.0-beta02)

@conker84 Any idea when we could expect a release with the new driver?

@ctytgat the next week we'll do a beta release


Format on save fails quietly if rustfmt is not installed for the current toolchain

System: Ubuntu 18.04 with VS-Code
Observed: format on save does not work when rustfmt is not installed for the current toolchain
Expected: Either some kind of (additional) feedback that formatting failed (e.g. a pop up in vs-code) or an automatically triggered installation of rustfmt
Actually the log of the language server already prints a message that rustfmt is not installed for the current toolchain. But I would argue that an additional pop-up would be a better solution, since the first impulse (meaning my first impulse^^) is to check the settings (followed by confusion and resignation) instead of checking the log.

The current "master" already shows a popup: "A request has failed. See the output for more information. Source: rust-analyzer (Extension). [Go to output button]".
L735 is failing when rustfmt is not installed (thanks @matklad !). I could try to add some error handing to override that generic message.

I think "A request has failed" is a low-level error from the protocol. There might be some way to render an error in a nicer way here, but I am not sure.


Symbol on covenant scroll is 1hive bee

Should the symbol on the covenant scroll image found on the "sign covenant" page be of the org that the covenant belongs to?

Maybe we could have a more general image? cc. @fioreb
We could also perhaps do a bit of hacking and place the garden's logo on top of this image at the right place, the thing is that if the logo is not rounded it would look very odd.

We can have a more general image, I can work on that!
For the other option, that image needs to be the same that the community has on their site? or it can be a new image?
We can leave the image of the contract as it is, remove the bee, place a white circle and add with hacking each community logo on top, we just need to be careful that those logos doesn't have white on them.


Use UDS for optimistic block and bundle streams in the Auctioneer

We want to minimize transport issues and latency. Since we assume the optimistic block and bundle streams (link to proto) will be served by a sequencer in the same cluster as the auctioneer we can use UDS instead of TCP for the gRPC connection.

tonic/examples/src/uds

┆Issue Number: ENG-979

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

This issue was closed because it was stale


feat(backend): add stablediffusion-ggml

Description
This PR is a first attempt into adding a very straightforward backend for stablediffusion.cpp (which is using ggml-based engine).
Notes for Reviewers
It does not wire up all the options available to stablediffusion.cpp, the purpose of this PR is to introduce the backend first, optimizations are left as an exercise for later.

It does wire SchedulerType, EnableParameters (used as sampler method)

Signed commits

[ ] Yes, I signed my commits.

Testing with:
name: sd-ggml
backend: stablediffusion-ggml
parameters:
  model: huggingface://city96/FLUX.1-dev-gguf/flux1-dev-Q2_K.gguf

WIP as doesn't work still

Testing it with:
name: sd-ggml
backend: stablediffusion-ggml
parameters:
  model: huggingface://city96/FLUX.1-dev-gguf/flux1-dev-Q2_K.gguf

options:
 - "diffusion_model"
 - "clip_l_path:clip_l.safetensors"
 - "t5xxl_path:t5xxl_fp16.safetensors"
 - "vae_path:ae.safetensors"
 - "sampler:euler"

download_files:
- filename: ae.safetensors
  sha256: 	afc8e28272cd15db3919bacdb6918ce9c1ed22e96cb12c4d5ed0fba823529e38
  uri: https://huggingface.co/ChuckMcSneed/FLUX.1-dev/resolve/main/ae.safetensors
- filename: clip_l.safetensors
  sha256: 660c6f5b1abae9dc498ac2d21e1347d2abdb0cf6c0c0c8576cd796491d9a6cdd
  uri: https://huggingface.co/comfyanonymous/flux_text_encoders/resolve/main/clip_l.safetensors
- filename: t5xxl_fp16.safetensors
  sha256: 6e480b09fae049a72d2a8c5fbccb8d3e92febeb233bbe9dfe7256958a9167635
  uri: https://huggingface.co/comfyanonymous/flux_text_encoders/resolve/main/t5xxl_fp16.safetensors

finally working now:
name: sd-ggml
backend: stablediffusion-ggml
parameters:
  model: huggingface://city96/FLUX.1-dev-gguf/flux1-dev-Q2_K.gguf

options:
 - "diffusion_model"
 - "clip_l_path:clip_l.safetensors"
 - "t5xxl_path:t5xxl_fp16.safetensors"
 - "vae_path:ae.safetensors"
 - "sampler:euler"

step: 25

download_files:
- filename: ae.safetensors
  sha256: afc8e28272cd15db3919bacdb6918ce9c1ed22e96cb12c4d5ed0fba823529e38
  uri: https://huggingface.co/ChuckMcSneed/FLUX.1-dev/resolve/main/ae.safetensors
- filename: clip_l.safetensors
  sha256: 660c6f5b1abae9dc498ac2d21e1347d2abdb0cf6c0c0c8576cd796491d9a6cdd
  uri: https://huggingface.co/comfyanonymous/flux_text_encoders/resolve/main/clip_l.safetensors
- filename: t5xxl_fp16.safetensors
  sha256: 6e480b09fae049a72d2a8c5fbccb8d3e92febeb233bbe9dfe7256958a9167635
  uri: https://huggingface.co/comfyanonymous/flux_text_encoders/resolve/main/t5xxl_fp16.safetensors

curl http://localhost:8080/v1/images/generations -H "Content-Type: application/json" -d '{
  "prompt": "A cute baby sea otter", "model": "sd-ggml",
  "size": "256x256"
}'


⚠ Bofrost.at has degraded performance

In 42a0ab1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2346 ms

Resolved: Bofrost.at performance has improved in 077e1df after 13 minutes.