Expressive design kit – Gray 10 theme

User Story

As a [user role below]:

DDS designer

I need to:

update the expressive design kit

so that:

designers have a kit that is aligned with the expressive theme code
Additional information
Follow instructions within this issue for updating.
High level tasks

[ ] Duplicate the white theme file
[ ] Rename library
[ ] Run Plugin: Automate / Development / Show and change layer info
[ ] Re-link any broken nested symbols that occurred from running the automation plugin
[ ] Update color tokens. Reference the Carbon website documentation for hex values for the Gray 10 theme.

Step by Step instructions

Duplicate the White theme file.

Rename the duplicated library following instructions on renaming a Library in Sketch documentation here
Rename to correct theme color: IBM.com Library (Gray 10 theme)

Run the Automate Plugin: Automate / Development / Show and change layer info on all symbols
Install plugin if you don't have it

Select Change and hit Save once the ID has changed

*Note: Control + Shift + R will allow you to run the same plugin over again without needing to navigate through the finder flyout each time

Re-link any broken nested symbols that occurred from running the automation plugin
All group symbols and any nested items (like progress indicator steps) will be broken.

Update color tokens on the Elements page.
Reference the Carbon website color documentation for hex values for the Gray 10 theme.
Note: the color tokens within the elements page are not necessarily in the same order as the Carbon website (which is alphabetical)

Directly select the layer (you may need to unlock it)
Update hex value on the layer style
Hit Update symbol on the right panel

Update the color and hex value within the document, you will reference the Carbon website for this too.

Go through the design kit and make any manual overrides updates needed:
Reference this Box note of overrides list I created.
Note: it may be outdated, this is 11 months old!

Acceptance criteria

[ ] All updates have been made
[ ] Reviewed by Olivia
[ ] Uploaded to Box

Uploaded design kit to box, waiting for review from Olivia.
https://ibm.box.com/s/zfglqxij1la2j675hrpgbo0xdzge3p0e


[Event Request] Table 27 - OnBeforeCheckStdCostWksh

Describe the request
In two of the three procedures called from CheckJournalsAndWorksheets(...) an OnBefore... event was implemented. In CheckStdCostWksh this is missing. Please add.
    local procedure CheckStdCostWksh(CurrentFieldNo: Integer)
    var
        StandardCostWorksheet: Record "Standard Cost Worksheet";
        IsHandled: Boolean;
    begin
        // New Event >>
        if "No." = '' then
            exit;

        IsHandled := false;
        OnBeforeCheckStdCostWksh(Rec, CurrentFieldNo, IsHandled);
        if IsHandled then
            exit;
        // New Event <<

        StandardCostWorksheet.Reset();
        StandardCostWorksheet.SetRange(Type, StandardCostWorksheet.Type::Item);
        StandardCostWorksheet.SetRange("No.", "No.");
        if not StandardCostWorksheet.IsEmpty() then
            if CurrentFieldNo = 0 then
                Error(Text023, TableCaption(), "No.", StandardCostWorksheet.TableCaption());
    end;

    // New Event >>
    [IntegrationEvent(false, false)]
    local procedure OnBeforeCheckStdCostWksh(Item: Record Item; CurrentFieldNo: Integer; var IsHandled: Boolean)
    begin
    end;
    // New Event <<

Additional context
We want this functionality to handle CheckJournalsAndWorksheets(...) in the same way for all underlying checks.
Internal work item: AB#538710

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 21073.


Add polygon feature to geojs

@jbeezley as discussed, please add support in d3 and fix issues such as download of the external library as the build time

Looks good.  I'll work on fixing the tests tomorrow.


Remove explicit poethepoet dependency

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.912%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
373

Relevant Lines:
488

💛  - Coveralls


Use blackfriday v2

Hello Mathieu,
Looks like you upgraded the blackfriday package in dep, but not in your regular imports, which breaks the build. This PR is a proposal to fix it.
Not sure if the Gopkg.toml should also be updated for the constraint path of blackfriday, I'm not (yet) a regular user of dep.
Thanks,
Pierre

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   98.45%   98.45%
=======================================
  Files           3        3
  Lines         907      907
=======================================
  Hits          893      893
  Misses          8        8
  Partials        6        6

Impacted Files
Coverage Δ

hermes.go
77.77% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e4381...9a9156d. Read the comment docs.

Weird, the build is working though in my laptop and in CI : https://travis-ci.org/matcornic/hermes/jobs/315521876

I'd say it is because you use dep in your travis script. With a regular `go get -u ./...", you probably will see the issue.

Tested at home and you're right.
I created a new MR #30 and updated other dependencies as well. I deleted both godep files and used dep init to generate new files.
Sorry for the inconvenience ;)


Remove PP Grad Tail Check

After the patch in https://github.com/microsoft/DeepSpeed/pull/1400 for BigScience, the final element of the inputs tuple is conditional on whether its grad is null (https://github.com/microsoft/DeepSpeed/blob/v0.7.5/deepspeed/runtime/pipe/engine.py#L995).
This will always fail if elt.grad is None in (https://github.com/microsoft/DeepSpeed/blob/v0.7.5/deepspeed/runtime/pipe/engine.py#L1026) with a IndexError: tuple index out of range because the index_grad_tail in (https://github.com/microsoft/DeepSpeed/blob/v0.7.5/deepspeed/runtime/pipe/engine.py#L1006) doesn't exist.
We're facing this issue intermittently whenever the grad tail is full of nan. I propose we just always include the grad tail.
@dashstander @jeffra @ShadenSmith

Hi @Quentin-Anthony - is this an active PR you'd still like to see merged?  Just going through some older PRs and trying to see if we should review/prioritize or close.

Hi @Quentin-Anthony - is this an active PR you'd still like to see merged? Just going through some older PRs and trying to see if we should review/prioritize or close.

Yes I'm still interested! I'll take another look sometime over the next few days and decide how best to close this out.

Hi @Quentin-Anthony - is this an active PR you'd still like to see merged? Just going through some older PRs and trying to see if we should review/prioritize or close.

Yes I'm still interested! I'll take another look sometime over the next few days and decide how best to close this out.

Thanks!  Other than a current known failure, it is passing all tests at least, but we will just want to figure out who would be best to review.

Hi, I have met the same problem as well. I wonder if we can move forwards and merge this solution ASAP?


Feature/handle font scale min scale

Fixes # BLUI-3647

Changes proposed in this Pull Request:

Added adjustsFontSizeToFit prop required for min scale

Screenshots / Screen Recording (if applicable)

To Test:

Checkout bugfix/extra-large-font-size-min-scale branch in blui-react-native-showcase-demo
yarn build
yarn start:showcase

Any specific feedback you are looking for?

This PR is raised to target the min font scale
Change MIN_FONT_SCALE constant defined in blui-react-native-showcase-demo

Side comment, I don't see how github bot is tagging this PR as "feature" here

Side comment, I don't see how github bot is tagging this PR as "feature" here

This is bizarre, I'm not sure why either since we don't have an option to label anything as a 'feature' in our config.

labeler config is only in dev, may need to push it to master... perhaps the default config is producing this?


fixed register

register should work with this (still need to add response text)
set all endpoints to be allowed in security for now

Opened new pull request, so closing this one (same changes) and deleting this branch.


🛡 Faulty implementation for Balance Fetching

[!NOTE]
Severity: Low
target: v7.1.0 - Commit: 3c854270b006db30aa3894da2cdba10cc31b8c5f
Ref: OKP4 Blockchain Audit Report v1.0 - 02-05-2024 - BlockApex

Description
Okp4 includes custom predicates within its bank module to facilitate operations like balance fetching. The available predicates —bank_balances, bank_spendable_balances, and bank_locked_balances — are intended to query and return various account balances. According to Okp4 documentation, bank_balances(X,Y) should fetch the balances for all accounts.
However, our comprehensive testing revealed a significant issue: the maxOutput result limit in the Logic module is set too low (e.g., 3 on the testnet) relative to the potential thousands of accounts on the blockchain. This setting prevents the predicate from returning comprehensive results when triggered, thus impeding the correct functioning of any Prolog logic dependent on this data.
Impact
The implications of this issue are critical for operations that rely on fetching and processing comprehensive account balance data. Since the predicate fails to return full results due to the maxOutput limit, any logic in the Prolog that depends on these results will not function as intended.
Recommandation
Revise the maxOutput setting in the Logic module to accommodate the highest possible number of accounts, ensuring all balance-related predicates function as documented.

@amimart Yes! I agree that increasing the maxOutput parameter to return more results is not desirable. As you mentioned, we should implement pagination at the predicate level or use predicates to fetch the required solutions. While findall/3 can be used to gather more results, using it with bank_balance/2 may lead to an out-of-gas error due to the fetching of thousand and thousand balances at one time.
For now, I believe we should leave it as is since it is not blocking and work on finding a proper solution for pagination.

For now, I believe we should leave it as is since it is not blocking and work on finding a proper solution for pagination.

Agree, let's closing it.


DNM examine

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/pull-integration-test

/retest

/close


KeyError: 'tied_weights'

Describe the bug
Using API to load a pre trained model and getting the error
KeyError: 'tied_weights'
To Reproduce
Steps to reproduce the behavior:
Run in Google Colab
Python code so indents may need to be added for loops and conditionals for code to work.
Imports and Installations
from future import print_function
import math
import time
from IPython import display
from matplotlib import cm
from matplotlib import gridspec
from matplotlib import pyplot as plt
import numpy as np
import pandas as pd
from sklearn import metrics
import tensorflow as tf
from tensorflow.python.data import Dataset
tf.logging.set_verbosity(tf.logging.ERROR)
pd.options.display.max_rows = 10
pd.options.display.float_format = '{:.2f}'.format
!pip3 install ludwig
import yaml
from ludwig import LudwigModel
ModelDefinition:
dict = {'input_features': [{'name': 'Open_Price', 'type': 'numerical'}], 'output_features': [{'name': 'Closing_Price', 'type': 'numerical'}], 'training':{'epochs': 3000}}
model_definition = dict
ludwig_model = LudwigModel(model_definition)
Sample Data:
The full code pulls data from an exchange through their API, the below is a modified version to generate a sample.
Data is generated in code
Create a data frame with first series having numerical and a second series having numerical...
Series are generated in a loop using append
Replace stock_bars[i].o and stock_bars[i].o with a constant like 200.00 in following code to generate sample series
limit = 1000
stock_open = []
stock_close = []
if len(stock_open) == 0:
for i in range(limit):
stock_open.append(stock_bars[i].o)
if len(stock_close) == 0:
for i in range(limit):
stock_close.append(stock_bars[i].c)
df = pd.DataFrame({ "Open_Price": pd.Series(stock_open), "Closing_Price": pd.Series(stock_close)})
print(df)
df.describe()
Training
train_stats = ludwig_model.train(df)
Saving (Drive needs to be mounted before saving, will need to also replace stock_symbol)
save_path = "gdrive/My Drive/Colab Notebooks/" + stock_symbol
ludwig_model.save(save_path)
Loading
model_dir = "gdrive/My Drive/Colab Notebooks/" + stock_symbol
ludwig_model = []
ludwig_model = LudwigModel.load(model_dir)
Please provide code, yaml definition file and a sample of data in order to entirely reproduce the issue.
Issues that are not reproducible will be ignored.
Expected behavior
Model loaded
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: [e.g. iOS]  (colab)
Version [e.g. 22] (colab)
Python version (colab)
Ludwig version (!pip3 install ludwig)

Additional context
Add any other context about the problem here.
Code for mounting a drive
from google.colab import drive
drive.mount('/content/gdrive')

@Rhasz Could you please paste the stacktrace?

KeyError                                  Traceback (most recent call last)
 in ()
1 model_dir = "gdrive/My Drive/Colab Notebooks/" + stock_symbol
2 ludwig_model = []
----> 3 ludwig_model = LudwigModel.load(model_dir)
/usr/local/lib/python3.6/dist-packages/ludwig/api.py in load(model_dir, logging_level)
197             set_disable_progressbar(True)
198
--> 199         model, model_definition = load_model_and_definition(model_dir)
200         ludwig_model = LudwigModel(model_definition)
201         ludwig_model.model = model
/usr/local/lib/python3.6/dist-packages/ludwig/models/model.py in load_model_and_definition(model_dir, use_horovod)
1619         )
1620     )
-> 1621     model = Model.load(model_dir, use_horovod=use_horovod)
1622     return model, model_definition
/usr/local/lib/python3.6/dist-packages/ludwig/models/model.py in load(load_path, use_horovod)
1331         )
1332         hyperparameters = load_json(hyperparameter_file)
-> 1333         model = Model(use_horovod=use_horovod, **hyperparameters)
1334         model.weights_save_path = os.path.join(
1335             load_path,
/usr/local/lib/python3.6/dist-packages/ludwig/models/model.py in init(self, input_features, output_features, combiner, training, preprocessing, use_horovod, random_seed, debug, **kwargs)
107             preprocessing,
108             random_seed,
--> 109             **kwargs
110         )
111
/usr/local/lib/python3.6/dist-packages/ludwig/models/model.py in __build(self, input_features, output_features, combiner, training, preprocessing, random_seed, **kwargs)
157                 self.regularizer,
158                 self.dropout_rate,
--> 159                 is_training=self.is_training
160             )
161
/usr/local/lib/python3.6/dist-packages/ludwig/models/inputs.py in build_inputs(input_features, regularizer, dropout_rate, is_training, **kwargs)
37                                                     dropout_rate,
38                                                     is_training=is_training,
---> 39                                                     **kwargs)
40         feature_representations[input_feature['name']] = feature_representation
41     return feature_representations
/usr/local/lib/python3.6/dist-packages/ludwig/models/inputs.py in build_single_input(input_feature, regularizer, dropout_rate, is_training, **kwargs)
52         input_feature['name']
53     ))
---> 54     if input_feature['tied_weights'] is not None:
55         scope_name = input_feature['tied_weights']
56
KeyError: 'tied_weights'

Fixed, closing this, comment if it doesn't solve the isue for you.

I got same error


WWDC

Hey Jesse. It's pj from cocoa heads.
I have an emergency situation and I need to get in touch with someone who's at wwdc before event is over (to ask an app review consultant)
can you get me in touch with some over there who'd be happy to help.

Hey pj,
Send me an email with your email address and I'll invite you to the melbournecocoa slack channel. You can get in touch with most of the community who are over there in the #wwdc channel.
cheers,

<EMAIL_ADDRESS>

Jesse how do I use it to write a global message asking anyone at wwdc if they can help me


Usage of "FIRActionCodeSettings"

Xcode version: 9.0
Firebase SDK version: 4.3.0
Firebase Component: Auth
Component version: 4.2.1

Steps to reproduce:
Try to use the sendPasswordResetWithEmail:actionCodeSettings:completion API.
Question
Where do I get an instance of the FIRActionCodeSettings for the actionCodeSettings parameter? I cannot find anything that returns one in the public API. I noticed this docs, but important properties like iOSBundleID and androidPackageName are read-only (which would make sense if it's returned based on the app-bundle, but then the other platform (in this case Android) would not make sense. Thanks!

Hi  @hansemannn,
You can create an instance of FIRActionCodeSettings yourself using the default initializer and use the properties and methods exposed on the class to configure that instance.
For example:
FIRActionCodeSettings *actionCodeSettings = [[FIRActionCodeSettings alloc] init];   actionCodeSettings.URL = _actionCodeURL;  actionCodeSettings.handleCodeInApp = YES;  [actionCodeSettings setIOSBundleID:[NSBundle mainBundle].bundleIdentifier];
For a more elaborate example (and a swift version) please take a look at the example code under the Passing state/continue URL in email actions section of the documentation.
-Z

Closing this issue, if the issue persists please feel free to re-open it.

Looks great, thank you!


Submission class and test submissions

First pass at a submission class to be located in the server directory.
Initialized with full path to submission file.
Methods:

hit_target(targetError) - takes input string for target error and checks if it is in an error raised by submission
get_error() - runs the submission and returns the text of the error if there is one and an empty string if no error
check_cheating - template method to check submission for cheating
delete_submission - template method to delete submissions after they are checked. Possibly just move to class destructor

Also added a folder to store test submissions - these probably need to be ignored by black/flake8 somehow.
I setup the name=='main' boilerplate stuff to enable CLI checking of submissions. Navigate to server dir and input:
python submission.py <file_to_check.py> <error_target_string>

Wouldn't it be better to just take in a string instead of a file? Because in terms of the game logic, keeping track of multiple files as users keep submitting them would be tricky. Storing each users current submission in a dictionary is what I thought we were going to use.


Synchronisation problems

Environment

Operating System: Linux
Node Version:     v16.18.0
Nuxt Version:     3.5.3
Nitro Version:    2.4.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      ssr, telemetry, sourcemap, serverHandlers, vue, routeRules, vite, css, dir, plugins, modules, imports, electron, nitro, hooks, runtimeConfig, session
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
I use mongodb driver for storageOptions but I think this would probably happen with any asyn storage. The problem I describe here does not happen when using memory storage.
I have 2 requests to my api, called in a sequence. First request modifies the session, second request reads it.
await fetch("endoint1"); // session modified
await fetch("endpoint2") // session read

When session value is read in endpoint2, the changes made in endpoint1 are absent.
I can mitigate that as a workaround doing something like:
await fetch("endpoint1");
await new Promise((resolve) => setTimeout(resolve, 2000));
await fetch("endpoint2");

I ended up using an other workaround, that is overwrite the session in the database myself instead of waiting for the plugin to do it, it solves my problem but may create other issues.
event.res.on('finish', async () => {
    // Session id may not exist if session was deleted
    const session = await getSession(event)
    if (!session) {
      return
    }

    await setStorageSession(session.id, event.context.session)
  })

It looks like h3 sends the response before the callbacks on the finished events are done so I'm not sure what to do about that.
Describe the bug
Using an async storage (in my case mongodb), when calling 2 requests in a sequence, first request modifies the session, the second reads it, data is not updated in the session in request 2.
Additional context
No response
Logs
No response

I am also facing the same issue in my project, the session data is getting overwritten by the new data in concurrent request

Same issue!


Support for negative prompts in Swift CLI

As far as I could see, the Swift CLI implementation currently doesn't support negative prompts.
In the Python implementation, the negative prompt argument is tokenised, encoded into uncond_embeddings, and prepended to the text embeddings of the regular prompt: https://github.com/apple/ml-stable-diffusion/blob/583cc04ece3dce9e1e8d44449f58d2eb7edef11c/python_coreml_stable_diffusion/pipeline.py#L145-L165
The Swift implementation on the other hand does not handle a negative prompt argument: https://github.com/apple/ml-stable-diffusion/blob/583cc04ece3dce9e1e8d44449f58d2eb7edef11c/swift/StableDiffusion/pipeline/StableDiffusionPipeline.swift#L76-L84
I don't really know how Stable Diffusion (v2) deals with negative prompts but how would one add support for them to the Swift implementation? The Core ML model seems to support it after all.

I just opened a PR with the Swift implementation. See: #61


Expand the logpath attribute using environment variables

This should allow to declare something like
%BASE%\logs

Where is WinSW current home? Is the Kenai location deprecated? I assume latest code is here. I was looking for a fix to the logpath expansion. Looks like it's fixed here, but is there a place to get the latest stable binary with this included? The lates t location I know of is the 1.9 release here. Thanks

Yes, this is where the code is. The release is available at http://maven.jenkins-ci.org/content/repositories/releases/com/sun/winsw/winsw/
I should write some README.


Fix ChatModule initalization with model_lib_path argument

Fixes changes to mlc-chat module based on the PR : https://github.com/mlc-ai/mlc-llm/issues/1080 , which changed lib_path argument to model_lib_path

@ChenMnZ  , please note that have also included two PRs with the Llama-7b and Llama-13b quantized models as well fixing config.json related issues. Tested post that it's working on A100 systems.

ChenMnZ/Llama-2-7b-chat-omniquant-w3a16g128asym
This one solves the issue noted in Issue #18

ChenMnZ/Llama-2-13b-chat-omniquant-w3a16g128asym


Document functions

Used this AI Doc Writer extension to document some of the functions in both the client and server

@hahnbeelee since all these function are internal I think there is no extra value of adding JSDoc to them. I will therefore close the PR.


Page not found 404 of the full usage manual

What's up?
Is there another source available for the documentation?
Due diligence

[X] I have read the docs

https://nprint.github.io/nprintml/
Link fixed on repository as well. Our bad!


[WIP] WorkflowProfiler

Description
Initial PR to get feedback on design.
Current thinking:

WorkflowProfiler wraps Workflow and takes care of checkpointing a Workflow execution
WorkflowProfiler has methods such as run_from(checkpoint) to begin execution of the Workflow, and under the hood there is some method to load the checkpoint's Context
Key premise here is serializing/de-serializing Context.
If we go this route, we probably want to make use of some KVStore to cache these Contexts

Comment:

There was some discussion around using broker log to facilitate the ability to run from previous checkpoints. For which we would need to enrich the broker log with necessary artifacts and the ability to navigate through them to load previous checkpoints.

After discussing with @masci, we landed on the following:

If we want mostly to run from a checkpoint, then we can (and probably should) just do this in Workflow itself
have _broker_log maintain the Checkpoint -- ofc, the Checkpoint should contain all that it needs in order to be executed from it (events, Context states etc.)
have a way to navigate/filter Checkpoint
have a way to start from a Checkpoint

Will rework to this shape.


EXE file outputs sharktank location 4+ times

Probably related to [https://github.com/nod-ai/SHARK/issues/1458](Users\Name.local directory is created (but not used) even if --local_shark_tank is enabled).  This only happened with the web UI for a while but showed up again for everything.


List Formatting - Style issue using inlineEditField with field type Choice

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
Declarative list formatting
Developer environment
None
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details
No response
Describe the bug / error
Dear Mr. @shagra-ms,
I would like to report the following issue using inlineEditField with choice field that width doesn't fits the size to display the options, but size defined in List formatting json. when using sharepoint page with inlineEditField.
When using SharePoint Page inlineEditField choice field display correctly where all options are visible.
Below sample of the error:

Steps to reproduce

Create List
Add Field "Tags" and add multiple options
Access to view and include List formatting json below

{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/row-formatting.schema.json",
  "hideColumnHeader": true,
  "hideSelection": true,
  "rowFormatter": {
    "elmType": "div",
    "children": [
      {
        "elmType": "div",
        "style": {
          "padding": "20px",
          "width": "10px"
        },
        "txtContent": "[$Tags]",
        "inlineEditField": "[$Tags]"
      }
    ]
  }
}

Click on "Tags" field and dropdown option doesn't resize width but assume the with defined in json style.
Create SharePoint Page and add WebPart List with associated View.
Click on "Tags" field and dropdown option does resize width that all choice options are displayed.

Expected behavior
It's expected when apply List formatting json with option inlineEditField  + choice field, the options should display to be selected even when defined in json the width of field.

@aaclage we are currently looking into this.

Dear @shagra-ms @arkogupta,
Here my feedback on current issue:
1- "Style issue using inlineEditField on choice field" was fixed.
Thank you for your support and going to close ticket,
A L


debug flag

Want to make running in debug_mode easier, adding a debug flag allows me to not have to edit the config file every time I want to debug.

Pull Request Test Coverage Report for Build 364

6 of 7 (85.71%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 29.951%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

air.go
6
7
85.71%

Totals

Change from base Build 363:
0.1%

Covered Lines:
732

Relevant Lines:
2444

💛  - Coveralls

Pull Request Test Coverage Report for Build 364

6 of 7 (85.71%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 29.951%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

air.go
6
7
85.71%

Totals

Change from base Build 363:
0.1%

Covered Lines:
732

Relevant Lines:
2444

💛  - Coveralls

Pull Request Test Coverage Report for Build 364

6 of 7 (85.71%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 29.951%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

air.go
6
7
85.71%

Totals

Change from base Build 363:
0.1%

Covered Lines:
732

Relevant Lines:
2444

💛  - Coveralls

Also, consider using flaggy, since it allows you to set shorthand flags easilly.
var configfile string
flaggy.String(&configfile , "c", "config", "tell air where to look for the configuration file")

if configfile == "" {
   configfile = "config.toml"
}

myapp -c ./private/config.toml

It would also be nice if you could set the config file's location programmatically.
air.ConfFile("./private/config.toml") // ...reinterpret

And there should be a warning/error printed out, when air can't find the config.toml, instead of exiting abruptly

In this case, I think it would be more convenient to support a little more flags. Such as: --address, --tls-cert-file, --tls-key-file and other handy flags. What do you think?

It would also be nice if you could set the config file's location programmatically.
...

I don't think so. Dynamically reloading a configuration file is not an easy task. After all, we have too many configuration items to use only when starting the server. So, I think, the configurations should not support dynamic reloading. Or we add a func (such as Restart()) to restart the server. But that's too much.

Inside air.go
var ConfigFile = "config.toml"

var called = false
func Init(configfile string) {
 if called {
  return
}
called = true
 /* ... everything that was in init */
}

inside server.go
func Serve() {
  air.Config(ConfigFile)
}

^_ It's a bit rough but what if we did something like this?
Only reason it might be nice to set these things programmatically is so that the main Application using air can take back control of the flags, or at least, offer sensible defaults without making the end user think about flags or even try to remember them. But it's your call...

Yes, gimme all the flags you got, I love it!

Yeah, you are right, Air should not dominate the flags.  A framework should never control the flags.

Hi @SaulDoesCode,
I think adding a func Config(file string) error might be good, but should it be called automatically in the server#serve()?
The config.toml:
address = "localhost:6677"

The main.go:
package main

import "github.com/aofei/air"

func main() {
	air.Address = "localhost:7788"
	air.Serve()
}

The air.Address will be replaced with localhost:6677 if there is an implicit call in the air.Server().

The user should not have to think about these things, just like the saying innocent until proven guilty, try to parse the config file, unless explicitly told not to.
I might go about it like this:
var HasConfig = true

// ... do everything the same, normal if HasConfig

// in user-land
air.HasConfig = false
air.Address = ":2443"
air.AppName = "A Big Idea"
// ...more config options

// back in Air-land
if !HasConfig {
  // skip parsing
}

When HasConfig is false don't parse any files
But if it's true, which is should be by default, then parse.
Though, perhaps, you should still retain a post-processing step for the config params,
a Config Digest
// this is from another project
func digestConfig(config *Config) {
	if config.Private == "" {
		config.Private = "./private"
	}

	if config.Assets == "" {
		config.Assets = "./assets"
	}

	if config.Cache == "" {
		config.Cache = config.Private + "/cache"
	}

	if config.AutoCert && len(config.Whitelist) == 0 && config.Domain != "" {
		config.Whitelist = []string{config.Domain}
	}

       // [...more checks/defaults]
}

^- this project just maintains a global Config struct
it can populate the values from a file or from a user's manual setting.
But, it always run's the digest to check that values are valid

Also, air.ConfigFile could be a useful option.
Then a user can set where to look before hand.

I prefer air.Address more than air.Config.Address, so I gave up using a Config-like struct stuff.
See 026794c7d9949001ab85ea6bb6b17fc96ac0d907, I decided to use the ConfigFile. What do you think?

For this project that also makes sense because air runs as a singleton, so there's no conflicting instances to worry about anyway. So yeah, that's fine.

Awesome ConfigFile simplifies things a lot!


Absinthe?

Is this a different solution to:
https://github.com/absinthe-graphql/absinthe/issues/156
?

@elie222 I'd say it's not a different solution.
Absinthe is awesome, (currently using it four a couple of APIs of mine) and it's a server side technology, not really tied to any client you could use this or relay or plain curl to ask some gql.
Actually I'm using Absinthe for executing the queries, and used that as an example on the readme. I'm also interested on that issue, how to use absinthe for gql subscriptions and certainly using sockets can be a good candidate for that, so I guess I'll be looking forward to integrate subscriptions when @benwilson512 reports on what they'll look like with an Absinthe backend.

@vic - @benwilson512 has posted an example of what subscriptions look like with an Absinthe backend. We should definitely start exploring how we can add subscription support to this repo.

@conor-mac-aoidh great! thanks for the link to the example. And yes we should start adding subscriptions
AFAIK apollo-client supports two kind of subscriptions, real gql subscriptions and polling-subscriptions (particular to apollo) not requiring the server to support nothing more than queries/mutations.  So I guess the second ones are already possible with this repo. But certainly we should explore looking at the linked example and support real gql subs.
As a side note, the Apollo guys are willing to accept some documentation PR for how to integrate with a Phoenix backend see this issue, some nice people have already written posts about it (see links in the issue).

So let's close this as I guess there's nothing to do for this issue.


add trait ClientHello

Since TLS's client hello and DTLS's client hello have some common fields, add a ClientHello trait could let users to handle these fields by using one same generic function. Sure users could implement this trait by themselves, but it would be nice if it is out of box.

Merged, thanks!


Simple Commander API Breaks

Hello,
In the past I have been able to successfully use Nav2's Simple Commander API, but I get the following error after having included this package (I'm hoping to use both):
[ERROR] [bt_navigator-9]: process has died [pid 139, exit code 127, cmd '/opt/ros/humble/lib/nav2_bt_navigator/bt_navigator --ros-args --log-level info --ros-args -r __node:=bt_navigator --params-file /tmp/launch_params_9176n68w -r /tf:=tf -r /tf_static:=tf_static'].
[bt_navigator-9] /opt/ros/humble/lib/nav2_bt_navigator/bt_navigator: symbol lookup error: /opt/ros/humble/lib/nav2_bt_navigator/bt_navigator: undefined symbol: _ZN17nav2_bt_navigator11BtNavigatorC1EN6rclcpp11NodeOptionsE

My binaries are:
Package: ros-humble-navigation2
Version: 1.1.14-1jammy.20240518.070250

And I am using the latest commit of opennav_coverage on the humble branch.
I can confirm that the error does not appear after removing this package and then rebuilding (and launching in the exact same way). Likewise, I can successfully execute the coverage task, so I suspect there is some cross-compatibility issue.
I understand that the humble branch has a backported_bt_navigator, but I'm somewhat of a novice at C++ and I'm not quite sure why it wouldn't work with the existing packages. In fact, I tried changing the CMakeLists.txt to install the behavior_trees:  install(DIRECTORY behavior_trees DESTINATION share/${PROJECT_NAME}) (as well as copying that directory to the backported_bt_navigator directory). It compiled, but the error still occurs. Otherwise I haven't touched anything as I'm not very comfortable with C++.
Any help would be appreciated.

Try apt update, apt upgrade, purging the binaries, and reinstalling. Could just be that you’re out of sync with some core libraries.

Okay, I believe I did those correctly by updating my Dockerfile as follows:
RUN apt update && apt upgrade -y && apt dist-upgrade -y

RUN apt purge -y \
        ...
	ros-${ROS_DISTRO}-navigation2 \
        ros-${ROS_DISTRO}-nav2-bringup \
	...
	&& \
    rm -rf /var/lib/apt/lists/*

RUN apt update && \
        apt install -y --reinstall \
        ...
	ros-${ROS_DISTRO}-navigation2 \
        ros-${ROS_DISTRO}-nav2-bringup \
	...
	&& \
    rm -rf /var/lib/apt/lists/*

Unfortunately, though. I'm still getting the error above. In the meanwhile, I can try it with Iron and report those results.

I'm currently working on a project with Humble binaries doing some basic navigation and not running into this issue, I'm pretty sure its to do with your setup and something not being up-to-date.
I think we should close unless you have more you can add to this or someone else reports a similar issue (I imagine if the Humble binaries are broken, we'd be seeing alot of reports!). I'd recommend updating your docker image with a pull and trying with a fresh re-build after deleting your install/build/log directories. Sometimes caches after apt updates can make things wacky.

Okay, I'll try that and give an update. Other than that I don't have anything to add, but thank you for your help (and all the amazing work)!


Removing line between form fields and disclaimer

This removes the line between the form fields and disclaimer so it doesn't look like something failed to load when "myself" is selected.

fixes eregs/notice-and-comment#327

:+1:


Wrapped call to @items inside Zotero.Items.get; Made 2nd argument option...

Wrapped call to @items(...) inside Zotero.Items.get.
Also made 2nd argument optional since it allows for nice POST body like this
{"method":"bibtex","params":[["Eysenbach2004", "Gustafson2002"]]}

instead of this
{"method":"bibtex","params":[["Eysenbach2004", "Gustafson2002"], {}]}

A new version of the plugin is out that has these methods enabled, and I mentioned your work in the index/readme

Well that was really quick, thanks, And I really appreciate that you
considered my work worth mentioning. I will be releasing my plugin soon. I
am still very new to this and learning a lot but I am really liking it.
On Wed, Jan 28, 2015 at 5:33 PM, AllThatIsTheCase<EMAIL_ADDRESS>wrote:

A new version of the plugin is out that has these methods enabled, and I
mentioned your work in the index/readme
—
Reply to this email directly or view it on GitHub
https://github.com/ZotPlus/zotero-better-bibtex/pull/138#issuecomment-71939801
.


Add the concept of a top-level dependency

Motivated by https://github.com/JuliaParallel/MPI.jl/issues/646
In order for invalidation to happen we need to declare the dependency on the top-level of the file instead of in one of the platform specific wrappers.

Can you please elaborate a bit on how you plan to use this concretely?

For projects like OpenMPI_jll that use Preferences for artifact selection we need to add the package that holds the "key=>value" to the deps, thus we added OpenMPI_jll, but when the artifact is not available we create a cache file
in which we never have done using MPIPreferences. Thus the cache file is not invalidated when the cache file changes. Leading to the behaviour in JuliaParallel/MPI.jl#646

OpenMPI_jll already depends on MPIPreferences in the project file: https://github.com/JuliaBinaryWrappers/OpenMPI_jll.jl/blob/a4b7bf25afd5e5c134e8e4f9117d47c2cdf12ac2/Project.toml#L6.  I'm missing what this PR adds to that.

When we cache a Package we do not care about the Project.toml, the cache file is only dependent on the code being parsed. We track what files are included and what Packages are pulled in with import/using. The cache file thus is missing a dependency edge on MPIPreferences and only MPIPreferences is invalidated when the Preference itself is changed.

To understand: this means that we'll have using MPIPreferences in src/OpenMPI_jll.jl instead of src/wrappers/PLATFORM.jl?

Yes exactly, we just move it up so that when there is no valid wrapper file we still add the dependency

Ok, now I got it! :smiley:

@giordano I don't think I am responsible for the 1.8 error xD


[Bug]: Kwargs in record_video.py not preserved by SB3 Vector Environment wrappers

🐛 Bug
The render_mode in record_video.py is not preserved after create_test_env is called here: https://github.com/DLR-RM/rl-baselines3-zoo/blob/2d5db11f6aee6d231d2154849715b0f7a9435038/rl_zoo3/record_video.py#L96-L105.
I have traced it to exactly this line in utils.py, where the VecNormalize wrapper of Stable-Baselines3 seems to set it back to None: https://github.com/DLR-RM/rl-baselines3-zoo/blob/2d5db11f6aee6d231d2154849715b0f7a9435038/rl_zoo3/utils.py#L284.
My temporary solution was to set env.render_mode = 'rgb_array' back in record_video.py right after create_test_env: https://github.com/DLR-RM/rl-baselines3-zoo/blob/2d5db11f6aee6d231d2154849715b0f7a9435038/rl_zoo3/record_video.py#L106, but I think a more general solution should be developed to ensure kwargs are preserved by environment wrappers.
To Reproduce
python3 -m rl_zoo3.record_video --algo ppo --n-timesteps 1000 --env Swimmer-v3 --load-best

Relevant log output / Error message
Loading /om/weka/yanglab/anayebi/zfa/logs/ppo/Swimmer-v3_3/best_model.zip
Traceback (most recent call last):
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/rl_zoo3/record_video.py", line 141, in <module>
    env = VecVideoRecorder(
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/stable_baselines3/common/vec_env/vec_video_recorder.py", line 50, in __init__
    assert self.env.render_mode == "rgb_array", f"The render_mode must be 'rgb_array', not {self.env.render_mode}"
AssertionError: The render_mode must be 'rgb_array', not None
Exception ignored in: <function VecVideoRecorder.__del__ at 0x2b570cf051f0>
Traceback (most recent call last):
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/stable_baselines3/common/vec_env/vec_video_recorder.py", line 113, in __del__
    self.close_video_recorder()
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/stable_baselines3/common/vec_env/vec_video_recorder.py", line 103, in close_video_recorder
    if self.recording:
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/stable_baselines3/common/vec_env/base_vec_env.py", line 392, in __getattr__
    return self.getattr_recursive(name)
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/stable_baselines3/common/vec_env/base_vec_env.py", line 415, in getattr_recursive
    attr = self.venv.getattr_recursive(name)
  File "/om2/user/anayebi/miniconda/envs/pong_env/lib/python3.9/site-packages/stable_baselines3/common/vec_env/base_vec_env.py", line 417, in getattr_recursive
    attr = getattr(self.venv, name)
AttributeError: 'DummyVecEnv' object has no attribute 'recording'

System Info
Library was installed via pip.
({'OS': 'Linux-3.10.0-1062.el7.x86_64-x86_64-with-glibc2.17 # 1 SMP Wed Aug 7 18:08:02 UTC 2019',
  'Python': '3.9.7',
  'Stable-Baselines3': '2.1.0',
  'PyTorch': '2.0.0+cu117',
  'GPU Enabled': 'True',
  'Numpy': '1.21.2',
  'Cloudpickle': '2.0.0',
  'Gymnasium': '0.28.1',
  'OpenAI Gym': '0.26.2'},
 '- OS: Linux-3.10.0-1062.el7.x86_64-x86_64-with-glibc2.17 # 1 SMP Wed Aug 7 18:08:02 UTC 2019\n- Python: 3.9.7\n- Stable-Baselines3: 2.1.0\n- PyTorch: 2.0.0+cu117\n- GPU Enabled: True\n- Numpy: 1.21.2\n- Cloudpickle: 2.0.0\n- Gymnasium: 0.28.1\n- OpenAI Gym: 0.26.2\n')

Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the SB3 documentation
[X] I have read the RL Zoo documentation
[X] I have provided a minimal and working example to reproduce the bug
[X] I've used the markdown code blocks for both code and stack traces.

Hello,
I guess your issue is a duplicate of https://github.com/DLR-RM/rl-baselines3-zoo/pull/379 (see dicussion in https://github.com/DLR-RM/stable-baselines3/pull/1525)
I thought the bug was fixed but it is still there apparently...
and yes env = VecNormalize.load(path_, env)  is the issue, when the VecNormalize is unpickled, some attributes are not set properly (self.class_attributes doesn't contain render_mode).
A fix would be to do self.render_mode = self.venv.render_mode L166 of the VecNormalize (right after self.class_attributes = dict(inspect.getmembers(self.__class__)))

I've pushed a fix here: https://github.com/DLR-RM/stable-baselines3/pull/1671/files

Great, thanks so much!


Runtime error "Cannot find module ...ngfactory" for lazy module with @ngtools/webpack 1.3.3

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

#4637 has been closed due to changed version, and it is suggested to open a new issue for the currently available version.
#6443 at some point shows this error in a log, but I don't think it is really related.
Versions.

Output from: ng --version. ng is not installed in this project. @ngtools/webpack is.
output from: node --version: v6.2.2
npm --version: 3.9.5
OS: Windows 10 version 1703, as well as Mac OS Sierra
angular 4.1.3,
@ngtools/webpack 1.3.3,
webpack 2.5.1,
typescript 2.3.2,
tslib 1.7.1

Repro steps.
There's a mini sample project showing the issue.

Clone repository https://github.com/BrainCrumbz/ngtools-webpack-demo and change dir
npm i
npm run build-prod
npm run serve
browse to http://localhost:3000
open developer console
click on link to private area

The log given by the failure.

ERROR Error: Uncaught (in promise): Error: Cannot find module '../private/module.ngfactory'.
Error: Cannot find module '../private/module.ngfactory'.
at webpackEmptyContext (src async:2)
at SystemJsNgModuleLoader.loadFactory (core.es5.js:5915)
at SystemJsNgModuleLoader.load (core.es5.js:5887)
at RouterConfigLoader.loadModuleFactory (router.es5.js:3334)
at RouterConfigLoader.load (router.es5.js:3318)
at MergeMapSubscriber.project (router.es5.js:1565)
at MergeMapSubscriber._tryNext (mergeMap.js:120)
at MergeMapSubscriber._next (mergeMap.js:110)
at MergeMapSubscriber.Subscriber.next (Subscriber.js:89)
at ScalarObservable._subscribe (ScalarObservable.js:49)
at webpackEmptyContext (src async:2)
at SystemJsNgModuleLoader.loadFactory (core.es5.js:5915)
at SystemJsNgModuleLoader.load (core.es5.js:5887)
at RouterConfigLoader.loadModuleFactory (router.es5.js:3334)
at RouterConfigLoader.load (router.es5.js:3318)
at MergeMapSubscriber.project (router.es5.js:1565)
at MergeMapSubscriber._tryNext (mergeMap.js:120)
at MergeMapSubscriber._next (mergeMap.js:110)
at MergeMapSubscriber.Subscriber.next (Subscriber.js:89)
at ScalarObservable._subscribe (ScalarObservable.js:49)
at c (zone.min.js:1)
at c (zone.min.js:1)
at zone.min.js:1
at e.invokeTask (zone.min.js:1)
at Object.onInvokeTask (core.es5.js:4140)
at e.invokeTask (zone.min.js:1)
at r.runTask (zone.min.js:1)
at o (zone.min.js:1)
at HTMLAnchorElement.invoke (zone.min.js:1)

NOTE: UglifyJs has been temporarily disabled in production build, to have a clearer stacktrace. Problem shows up also with UglifyJs applied, showing this stacktrace:

ERROR Error: Uncaught (in promise): Error: Cannot find module '../private/module.ngfactory'.
Error: Cannot find module '../private/module.ngfactory'.
at e (main-bundle.js:1)
at t.loadFactory (vendor-bundle.js:162)
at t.load (vendor-bundle.js:162)
at t.loadModuleFactory (vendor-bundle.js:415)
at t.load (vendor-bundle.js:415)
at e.project (vendor-bundle.js:415)
at e._tryNext (vendor-bundle.js:436)
at e._next (vendor-bundle.js:436)
at e.next (vendor-bundle.js:1)
at e._subscribe (vendor-bundle.js:436)
at e (main-bundle.js:1)
at t.loadFactory (vendor-bundle.js:162)
at t.load (vendor-bundle.js:162)
at t.loadModuleFactory (vendor-bundle.js:415)
at t.load (vendor-bundle.js:415)
at e.project (vendor-bundle.js:415)
at e._tryNext (vendor-bundle.js:436)
at e._next (vendor-bundle.js:436)
at e.next (vendor-bundle.js:1)
at e._subscribe (vendor-bundle.js:436)
at u (vendor-bundle.js:662)
at u (vendor-bundle.js:662)
at vendor-bundle.js:662
at t.invokeTask (vendor-bundle.js:662)
at Object.onInvokeTask (vendor-bundle.js:148)
at t.invokeTask (vendor-bundle.js:662)
at r.runTask (vendor-bundle.js:662)
at o (vendor-bundle.js:662)
at HTMLAnchorElement.invoke (vendor-bundle.js:662)

Desired functionality.
When clicking on link to lazy loaded module, page should show correctly.
Mention any other details that might be useful.

Somewhat differently than other projects, in this one module files are all named module.ts (and of course placed in their own whatever directory), instead of being whatever.module.ts.

This project uses tslib, Microsoft Runtime library for TypeScript helpers, together with noEmitHelpers and importHelpers flags as suggested in this post

After a development build, the JS chunk for lazy loaded module is correctly found in output directory: dist/js/0-chunk.js, as well as its sourcemap. After a production build instead, only sourcemap is found, no JS.

As said, a demo project is available at https://github.com/BrainCrumbz/ngtools-webpack-demo.

Duplicate of https://github.com/angular/angular-cli/issues/4431

May not be duplicate as in this bug chunks are created.
With ContextReplacementPlugin chunks are not created.

@sumitarora you are right. Not sure what has changed, as in previous iterations of that sample project I did try commenting out that plugin, having read about that issue already, and it did not help.
I can confirm that the lazy module chunk gets built:
          js/0-chunk.js   11.5 kB       0  [emitted]
      js/main-bundle.js    187 kB       1  [emitted]         main
    js/vendor-bundle.js   1.77 MB       2  [emitted]  [big]  vendor
    css/main-bundle.css   1.45 kB       1  [emitted]         main
      js/0-chunk.js.map   12.7 kB       0  [emitted]
  js/main-bundle.js.map    255 kB       1  [emitted]         main
css/main-bundle.css.map  96 bytes       1  [emitted]         main
js/vendor-bundle.js.map   2.17 MB       2  [emitted]         vendor
             index.html   1.35 kB          [emitted]
     images\favicon.ico     32 kB          [emitted]

I will subscribe to that issue so. I'm already subscribed to that issue so I'll keep on following that


Cannot debugWithChrome

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 192
OS Version: OS X

Steps to Reproduce:

Version: 1.92.0-insider (Universal) Commit: a35380d6f0ff65f7c35345baafcf1c3f8a378d38 Date: 2024-07-12T05:08:08.550Z (1 day ago)
Launch chrome debugger with
{
"name": "React Debug",
"type": "node",
"request": "launch",
"cwd": "${workspaceRoot}/typescript",
"runtimeExecutable": "pnpm",
"runtimeArgs": ["web:debug"],
"serverReadyAction": {
"pattern": "localhost:([0-9]+)",
"uriFormat": "http://localhost:%s",
"action": "debugWithChrome",
"webRoot": "${workspaceRoot}/typescript",
"killOnServerStop": true,
},
},
This shows when no sessions are running:

Browser opens and immediately crashes.

Open VS code 191.1 and everything works as expected.

Please open an issue on Chrome for this. They will probably want a crash log that you can get from ~/Library/Logs/DiagnosticReports or chrome://crashes


Protect against 'path' reassignment when evaling dangerfile

Move eval into seperate method to prevent local variable reassignment.
If the eval rescue is hit and path has been reassigned Danger will crash.
This doesn't address any concerns around a malicious Dangerfile rewriting methods.
#trivial

Hah, yea, that's an interesting edge case 👍


seralize says it supports POCOs, this is not correct

Serialize section lists support types, includes saying it supports POCOs (with surprisingly a link to wikipedia page). This is not so, it only supports objects that have setters and getters for its members. Plain public fields are not handled. Just spent a few happy hours trying to work out why this wasnt working

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 588ae32f-3429-143f-824c-5ab2d046d24a
Version Independent ID: 002f9f2a-48d1-0671-a079-b99b9f6bab58
Content: How to serialize and deserialize JSON using C# - .NET
Content Source: docs/standard/serialization/system-text-json-how-to.md
Product: dotnet-fundamentals
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Hi @pm100, I believe that the term POCO is in fact accurate. While WikiPedia is not always the best choice to link to, the term has been around for a very long time and within .NET it's been globally accepted as a term that is defined as an object which has properties with get and set.
Hey @tdykstra, I think for this one we should probably add POCO to the .NET glossary and make it official. We could then update all other references to the term's usage throughout docs, pointing to the new entry. Thoughts?

@IEvangelist Makes sense, please go ahead.
@pm100 Fields are supported -- there is an option and an attribute for that.  See https://docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-how-to?pivots=dotnet-6-0#include-fields


FIX #1027 added link to error box

i think it can solve this issues.. @tzarebczan

Closing for https://github.com/lbryio/lbry-app/pull/1039 instead.


Please Update to egui 0.22

Hello! I wanted to inform you that Egui 0.22 was released yesterday. Although there weren't many changes, transitioning to the new version should be relatively straightforward. I personally use Egui and Egui Dock as well, and I'm interested in updating to 0.22. It would be great if you could update it and release a new version at your earliest convenience. Thank you! 😄

Hey, yes I'm going to make a new release today.


feat(iter): Added context accepting variants of Map & ForEach

Added context handling to the functions in the iter package to support cancelling execution if any of the tasks fail or if the context itself is cancelled externally. As part of this change, I also re-implemented the ForEach* functions to use ContextPool from the pool package.

Hi @rkoehl05! Thanks for the PR and sorry for the slow response. Taking a look this morning

Would be nice to get this merged! 🙏


Suggestion: Prettier like parameters to allow for easy script usage

Hi,
first of all, thanks for your tool that helps keeping API definitions and commits clean. ❤
prettier has a CLI that makes it really easy to use it in scripts, e.g. in CI:

--write replaces the input files
it accepts (multiple) paths/glob patterns
--check makes it fail if something changed

That might be a nice addition to openapi-format, too, although you can work arround the first two with find . -name '*.yaml' -exec yarn run openapi-format {} -o {} \;.

@wedi It will be a bit more work, since I would have to scan folders for patterns.
I understand the local usage use case for ---write

Maybe you could use a library for that, e.g. https://www.npmjs.com/package/glob

This would be extremely helpful.
You don't even have to implement the globbing as a first step.
Just doing npx openapi-format --write *.yaml and npx openapi-format --check *.yaml in the CI without any output format would things make easier.

hi @wedi & @bodograumann
Although it is not exactly the feature requested, in release v1.23.0, we introduced the support for  .openapiformatrc which allows you to define all openapi-format options in 1 file, that will be automatically picked up.


Solve binding error

I've noticed this for awhile but ignored it as it seems to not affect anything we're doing but I'd really like to find and solve this for the sake of not having rouge errors in the project. At runtime the error [Binding]Error in binding to 'Avalonia.Controls.ColumnDefinition'.'Width': 'Null value in expression '{empty}' at '$self.TemplatedParent'.'(ColumnDefinition #7689721) is thrown. I believe this is from the color picker

Could be...
If not this color picker still might be something to replace as I'm stupid and added a package to get access to a color picker completely forgetting that Avalonia has a color picker built in which we should probably use instead🙃


Fixes #15076: Perfect yii\db\QueryBuilder buildColumns function

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#15076

Merged. Thanks!


add new generic parameter and field/accessors to IterState for residuals

I took a stab at updating the definition of IterState to support a fix for #342.   Library builds.  Tests likely don't build.  I currently don't have the ability to build the tests.

Yup, I think I get it all.  I have it in progress.  Unfortunately I'll be offline until mid-next-week, FYI.

I currently don't have the ability to build the tests.

Are you on Windows? Tests require netlib which isn't available on Windows. A fix is described in https://github.com/argmin-rs/argmin/pull/234#issuecomment-1518395567 .

I tried to fix the conflicts with main in order to get the CI to run again because all the old logs were already deleted.

Codecov Report
Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (852f6a2) 90.25% compared to head (cafef7f) 90.23%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

argmin/src/core/solver.rs
33.33%
4 Missing :warning:

argmin/src/solver/brent/brentroot.rs
0.00%
4 Missing :warning:

argmin/src/solver/quasinewton/sr1.rs
70.00%
3 Missing :warning:

argmin/src/solver/quasinewton/sr1_trustregion.rs
70.00%
3 Missing :warning:

argmin/src/solver/simulatedannealing/mod.rs
57.14%
3 Missing :warning:

argmin/src/solver/trustregion/steihaug.rs
62.50%
3 Missing :warning:

...rgmin/src/solver/trustregion/trustregion_method.rs
57.14%
3 Missing :warning:

argmin/src/core/state/iterstate.rs
98.63%
2 Missing :warning:

argmin/src/solver/linesearch/hagerzhang.rs
60.00%
2 Missing :warning:

...n/src/solver/gaussnewton/gaussnewton_linesearch.rs
66.66%
1 Missing :warning:

... and 4 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   90.25%   90.23%   -0.02%
==========================================
  Files         141      141
  Lines       19679    19778      +99
==========================================
+ Hits        17761    17847      +86
- Misses       1918     1931      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Height level out of bounds issue

When you try to go to height level 4 it will not let you go and there are a few castles like rouges castle in the wilderness that does need this fixed if you want to go all the way too the top.

When you say "height level 4", do you actually mean 3? In apollo the height levels are 0-3 inclusive, there is no 4.

ya that is what i meant @Major-

So what's the issue? You need to go to 4 or you need to go to 3? IIRC the only bounds issue that would occur is when you meet or exceed height 4, not 3.

Never mind -- I see the flaw with the check, making a pull request in a second.

@Major- close


SLC not working for Kia K5 Hybrid (2020)

Hi. I'm using C3 with Kia K5 Hybrid (2020). It has HDA1 feature, however SLC is not working.
I selected "Hyundai Sonata Hybrid 2020-22", and added fingerprint of the car on the values.py:
FINGERPRINTS = {
CAR.SONATA_HYBRID: [{
127: 8, 304: 8, 320: 8, 339: 8, 352: 8, 356: 4, 516: 8, 544: 8, 576: 8, 593: 8, 688: 6, 757: 2, 832: 8, 881: 8, 882: 8, 897: 8, 902: 8, 903: 8, 905: 8, 909: 8, 913: 8, 916: 8, 919: 8, 1040: 8, 1042: 8, 1056: 8, 1057: 8, 1078: 4, 1096: 8, 1102: 8, 1114: 8, 1136: 6, 1138: 5, 1151: 8, 1155: 8, 1156: 8, 1157: 4, 1162: 8, 1164: 8, 1168: 8, 1173: 8, 1180: 8, 1184: 8, 1186: 2, 1191: 2, 1193: 8, 1210: 8, 1225: 8, 1227: 8, 1265: 4, 1280: 8, 1287: 4, 1290: 8, 1291: 8, 1292: 8, 1294: 8, 1312: 8, 1322: 8, 1330: 8, 1339: 8, 1342: 8, 1343: 8, 1345: 8, 1348: 8, 1355: 8, 1363: 8, 1369: 8, 1371: 8, 1378: 8, 1379: 8, 1407: 8, 1419: 8, 1427: 6, 1429: 8, 1430: 8, 1446: 8, 1448: 8, 1456: 4, 1460: 8, 1470: 8, 1476: 8, 1485: 8, 1535: 8
}],
...
(Checked that it has 0x544 in the fingerprint)
Thanks.

Hello, is this car supported in upstream openpilot? If not already, I recommend reaching out to me in the comma Discord server #hyundai-kia-genesis channel and work on officially supporting this car.
Once complete, it can be easily supported in sunnypilot.


Close tags

Hi guys, I am using the script for post the content, and then be able to edit it any time..
But I have a problem..
At some point, the tags (even when I press the button to close the  tag for example), it just doesn't close.
And then, you can imagine what happens. Everything is broken.
¿How can I close all the open tags when I press the 'Save' button?
Thanks in advance, I'm sure the workaround will be helpful for everyone who is using this beautiful script.

Can you copy and paste an example of what you're seeing into a comment below? That way we can get a better idea of what tags this is happening with.


Can't instantiate actor when props defined with Props(classOf[Foo])

Playing around with akka.js at https://scalafiddle.io I noticed a problem with actor instantiation.
This one works fine. Link to fiddle: https://scalafiddle.io/sf/h8XVHMe/0
import akka.actor._

object ShoutBox  {
  def props: Props = Props(new ShoutBox)
}

final class ShoutBox extends Actor {

  override def receive: Receive = {
    case x: String  => println(x.toUpperCase)
  }

}

val system = ActorSystem()

val shout = system.actorOf(ShoutBox.props)
println("Shoutbox created")

shout ! "hello"
shout ! "world"

This one doesn't work. Link to fiddle: https://scalafiddle.io/sf/luBGLkI/1

import akka.actor._

object ShoutBox  {
  def props: Props = Props(classOf[ShoutBox])
}

final class ShoutBox extends Actor {

  override def receive: Receive = {
    case x: String  => println(x.toUpperCase)
  }

}

val system = ActorSystem()

val shout = system.actorOf(ShoutBox.props)
println("Shoutbox created")

shout ! "hello"
shout ! "world"

Can somebody clarify, is this behaviour right, or both ways should work?

I wait long enough for this issue to be opened! Seriously, thanks a lot @rockjam !
I always forget to mention this caveat, probably I'll need to write a dedicated section in Readme.
The problem here is that in Scala.Js I cannot retrieve the name of the underlying T exported name from a Class[T]. On JVM this is easy due to reflection... (@sjrd can correct me if I'm wrong )
So the current approach is to store in a Map the bindings between matching strings and Classes.
So what is needed here is to add to that map the proper entry to get the job done using
akka.actor.JSDynamicAccess.injectClass("TClassName" -> classOf[T])

Said that everything work in this: https://scalafiddle.io/sf/YbJgRwZ/1 (Scala -> show template for the full content).
Unfortunately I think there is a bug resolving the string name within the ScalaFiddle object, I need to dig into this or @sjrd can help here :-)
Thanks a lot for rising the issue!

The problem here is that in Scala.Js cannot retrieve the name of the underlying T exported name from a Class[T].

Do you mean clazz.getName()? That is supported in Scala.js. At least as long as the user doesn't change the information with scalaJSSemantics ~= { _.withRuntimeClassName(...) }.

Note that Fiddle, with the default template, wraps your code in a top-level object; so the apparent name of your classes are artificially namespaced in that top-level object. This could explain the "bug" with resolving the string name (I didn't fully get what it was).

ok, got it the problem is evident here:
https://scalafiddle.io/sf/YbJgRwZ/2
you cannot export the inner object so it cannot be loaded at runtime via name resolving.
I'm wondering why the error is triggered only if I explicit JSExport annotation and not if the class is targeted by a JSExportDescendentClasses from Actor trait.
I definitely need to write some docs on this.

I'm wondering why the error is triggered only if I explicit JSExport annotation and not if the class is targeted by a JSExportDescendentClasses from Actor trait.

Maybe because you set ignoreInvalidDescendants = true in JSExportDescendantClasses. This setting silently ignores descendant classes which cannot be exported, instead of reporting errors.

uh
yes, there are inner class in Akka itself that cannot be exported :-(

@andreaTP @sjrd Thanks for clarification. It was not obvious at first, cause previously I used classOf[Foo] in scala.js without any problem

Explained in Readme, I'll close this.


The LINQ expression could not be translated in GetDataView()

Describe the bug
The LINQ expression could not be translated in GetDataView()
To Reproduce
Steps to reproduce the behavior:

new project with Datasync template
follow this post to add IAccessControlProvider
send GET request https://localhost:44317/tables/todoitem?ZUMO-API-VERSION=3.0.0
See error: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.InvalidOperationException: The LINQ expression 'DbSet()
.Where(t => __predicate_0.Invoke(t))' could not be translated ...

What platforms?

Server:

[x] ASP.NET Core

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
public class TodoItemController : TableController<TodoItem>
{
    public TodoItemController(AppDbContext context)
        : base(new EntityTableRepository<TodoItem>(context))
    {
        AccessControlProvider = new TodoItemControlProvider();
    }
}

internal class TodoItemControlProvider : IAccessControlProvider<TodoItem>
{
    public Func<TodoItem, bool> GetDataView() => model => model.IsComplete;

    public Task<bool> IsAuthorizedAsync(TableOperation op, TodoItem entity, CancellationToken token = default)
        => Task.FromResult(true);

    public Task PreCommitHookAsync(TableOperation operation, TodoItem entity, CancellationToken token = default)
        => Task.CompletedTask;
}

Can you confirm the version of the NuGet packages you are using in your project?  (Will assume 5.0.0-beta.8, but would like the confirmation)

Yes, it is beta 8, I have used the official template to reproduce the issue

Issue is that the ApplyDataView extension method uses Invoke, which causes a permanent client-side evaluation.
Investigations:

How to do an automatic client-side evaluation (since someone is going to do something in the data view at some point to cause it, and then I'll have the problem again)
How to detect client-side evaluation in EF Core (so I can alert in logging on a performance issue)

The fix for the specific situation is relatively easy.  However, want to solve the bug more generically.
Target: beta-9

Also TODO: Convert the RRatedMovieController (and/or the LegalMoviesController) in the common web service used for testing to use SQLite in-memory store.  This will slow down the tests (currently each run takes ~ 20 minutes in VS 2022), but will allow us to test the access control provider using the EF repository rather than the in-memory repository (in-memory repository returned an IEnumerable.AsQueryable(), which masked the problem that is being reported).

Update: I'm doing all the changes for this bug here: https://github.com/adrianhall/azure-mobile-apps/tree/issue255 - as of right now, the bug is fixed.
However, I'm converting the tests over to use the EF Core SQLite in-memory database instead of an In-Memory repository.  The net result of this is that there are a lot of tests failing right now in an unrelated manner.  I've got approximately 3,577 tests to update, so it will be a few days before the PR for this will appear.  Hoping to have it done by Friday.

Just putting a placeholder update here.  Today was one of those cases of "Oooohhhh - I remember why I was using InMemory instead of SQLite now!!!"  SQLite has "issues" with DateTimeOffset (like, no support for), and Datasync Service relies on DateTimeOffset support to the ms accuracy.
Current adrianhall/azure-mobile-apps issue255 branch has the changes in the Microsoft.AspNetCore.Datasync.Test project, but requires the WebService to be updated to support DateTimeOffset, which is documented here: https://blog.dangl.me/archive/handling-datetimeoffset-in-sqlite-with-entity-framework-core/ - so that's the next step.

... Turns out that switching the tests over to use a SQLite db (given the constraints of the DB) is a big undertaking.  I'm going to check in the fix (assuming it hasn't actually broken anything in the tests), and then I'll file another bug to update the tests projects.

Merged in PR #260


Fix broken link

I just realized that this link is also present in the beginning of GroversAlgorithm.ipynb. Could you please do a matching change there?


Iframe blocker make perfomance hit

opacity, even very small create extra layers composition
It very sensitive for high quality 60fps videos.

You are absolutely right. We should find another way than using opacity to 0.01. I'll check what might be better for performance and still catch the mouse events.

looks like iframeblocker is used solely to respond to click events to implement pause/play.
but the play/pause is implemented by youtube themselves, so it can be used instead
onStateChange()  can be used to subscribe to the events
https://developers.google.com/youtube/iframe_api_reference#onStateChange

also, looks like youtube agreement not allow it
"F. If you use the Embeddable Player on your website, you may not modify, build upon, or block any portion or functionality of the Embeddable Player, including but not limited to links back to the YouTube website."

@zowers We are using the iframe blocker only to catch when the mouse is over the player for the navigators that doesn't support pointer-events: none; (IE and mobile), then it disappear. It is not about the play/pause events.
@mogadanez We are not altering in any way the YouTube player. The YouTube watermark is still there and no functionality has been changed. The iframeblocker is only about detecting when your mouse is over the video.

@eXon
  if(/MSIE (\d+\.\d+);/.test(navigator.userAgent)) {
        var ieVersion = Number(RegExp.$1);
        this.addIframeBlocker(ieVersion);
      } else if(!/(iPad|iPhone|iPod|Android)/g.test(navigator.userAgent)) {
        // the pointer-events: none block the mobile player
        this.el_.className += ' onDesktop';
        this.addIframeBlocker();
      }

first condition is for IE,
but second one check that it is NOT mobile, my chrome pass the check and create an iframeBlocker

mousemove used to detect and set userActive is needed only when controls are shown

@zowers means that controls can be disabled. and at least in this case bblockerblockrr ceation can be skipped

My bad I meant not mobile.
We can certainly disable that if the VJS controls are not shown.

We can certainly disable that if the VJS controls are not shown.
that will fix performance issue only in this case

so how was it fixed?


Add performance and longevity testing validation to the release template

Signed-off-by: Travis Benedict<EMAIL_ADDRESS>Description
Add steps to the release template for validating performance and longevity test results. These steps are not necessarily exhaustive but can serve as a starting point for our release process. Ultimately, these validations should be automated as our performance testing automation is built out more.
More details on the testing setup can be found in this issue outlining the results of performance experiments that I conducted - https://github.com/opensearch-project/OpenSearch/issues/2461
Issues Resolved
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1752 (c6979b7) into main (faf26d1) will increase coverage by 5.20%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #1752      +/-   ##
=============================================
+ Coverage     94.79%   100.00%   +5.20%
=============================================
  Files           169         6     -163
  Lines          3536       105    -3431
  Branches         26        19       -7
=============================================
- Hits           3352       105    -3247
+ Misses          181         0     -181
+ Partials          3         0       -3

Impacted Files
Coverage Δ

src/manifests/build/build_manifest_1_1.py

src/sign_workflow/signer.py

src/test_workflow/integ_test/integ_test_runners.py

tests/jenkins/jobs/PublishNotification_Jenkinsfile

src/test_workflow/test_kwargs.py

src/assemble_workflow/bundle_opensearch.py

src/assemble_workflow/dist.py

src/test_workflow/integ_test/local_test_cluster.py

src/assemble_workflow/bundle_locations.py

src/run_checkout.py

... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf26d1...c6979b7. Read the comment docs.

Thanks for the help on this @dblock. I really appreciate the feedback


[bug] can't run gpu_pkl_to_cpu_pkl.py

As you can see in the traceback I had a problem converting between gpu and cpu variants.
I've added after this line
        elif isinstance(obj, (types.FunctionType, types.BuiltinFunctionType)):
            print(prefix + "skipping a function (can't pickle function objects)")
            rval = None

I've also modified these lines:
        if hasattr(obj, 'set_value'):
            # Base case: we found a shared variable, must convert it
            rval = shared(obj.get_value())
            try:
                rval.name = obj.name
            except AttributeError:
                pass
            # Sabotage its getstate so if something tries to pickle it, we'll find out
            obj.__getstate__ = None

The script only seems to work with device=cpu so we could spare a bit of time to future guys by adding
# ...
if __name__ == '__main__':
    # theano.config.device is read-only so we change the value in environment
    # before importing theano
    thflags = os.environ['THEANO_FLAGS']
    if thflags:
        thflags = thflags + ",device=cpu"
    else:
        thflags = "device=cpu"
    os.environ['THEANO_FLAGS'] = thflags

    _, in_path, out_path = sys.argv
    # ...

I was then able to show_weights.py, browse_conv_weights.py, num_parameters.py, pkl_inspector.py, plot_monitor.py, etc. I did not try to fprop() in any way.
I am aware of the discussion in pylearn-users and the comments by @goodfeli in the file header.
Anyone facing issues with gpu_pkl_to_cpu_pkl.py should read this thread.

Regarding the first point, maybe the reason it is not able to pickle that function is because it existed in the version of Pylearn2 that saved the model in the first place, but it does not exist in the current version. In that case, I'm not sure we should always skip them. I don't know what the right way of detecting that would be, except by trying to pickle it in a string and seeing if it works.
Regarding the second point, yes, keeping the name is a good idea. I would probably call hasattr rather than try/catch, but it does not really matter.
Regarding the last point, sure.

I happened to have test_print_monitor_cv.py opened in an editor so I've copied to a GPU-equipped machine, modified it to preserve the file and run it. On the same console I then run gpu_pkl_to_cpu_pkl.py and I was able to reproduce the error. No difference in environment, pylearn2 version, etc
But your comment made me realize that there is no _check_is_symbolic in pylearn2.space. Previously I just assumed that it exists and never checked.
As it turns out there is a VectorSpace object that has a __reduce_ex__() method inherited from object that returns this funky dictionary:
{'dim': 10,
'_check_is_symbolic': <function _check_is_symbolic at 0x7ff5a9c2d1b8>,
'validate_callbacks': [],
'sparse': False,
'_dtype': 'float32',
'_check_is_numeric': <function _check_is_numeric at 0x7ff5a9c2d140>,
'np_validate_callbacks': []}

After that pickle tries to save that dictionary, attempts to locate  _check_is_symbolic in pylearn2.space and fails (obj is VectorSpace, rv +/- is the dictionary):
> /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(331)save()
-> self.save_reduce(obj=obj, *rv)
  /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(419)save_reduce()
-> save(state)
  /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(286)save()
-> f(self, obj) # Call unbound method with explicit self
  /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(649)save_dict()
-> self._batch_setitems(obj.iteritems())
  /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(663)_batch_setitems()
-> save(v)
  /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(286)save()
-> f(self, obj) # Call unbound method with explicit self
  /home/ubuntu/devel/anaconda/lib/python2.7/pickle.py(748)save_global()
-> (obj, module, name))

A newly constructed VectorSpace's __reduce_ex__() returns, amongst other things:
{'dim': 1,
'_dtype': 'float32',
'validate_callbacks': [],
'sparse': False,
'np_validate_callbacks': []}

Both _check_is_symbolic() and _check_is_numeric are tagged as @staticmethod.
I have no elegant idea about how to fix the things.

These changes are now part of pyl2extra.
Feel free to update the script from there if you see fit.
Closing this issue down as it has been inactive for a while.


CB-13166: Introduce 7.2.12 Cloud Runtime version in CB

Introduce 7.2.12 Cloud Runtime version in CB.

retest this please


Sunflower | Bootstrap => Foundation

Update: http://test.sunflower.sahanafoundation.org/
I've introduced a few styling changes(not significant ones) that differ from the default

the side nav & the inline component color is a bit lighter.
Added a background-color to the comments, it's hard to notice otherwise
Added a bit of styling to the content header
the rest is for the homepage

Thoughts ?

Hard to tell without screenshots

Side nav color, content header color difference
default

sunflower

Inline Components color
default:

Sunflower + (comments background-color)

@nursix btw you answered only one of the questions asked about the navigation ;), Let me repeat --
As soon as the filter comes off the url, the "highlighted" option in the Main menu changes from "Project" to "Deployment" even if I am in the "Projects" page, because there's no filter to tell it what page it is in - that's how I defined the MM() for Projects and Deployments - the two are distinguished based on the filter.
How can I resolve this ?

Not sure I understand your question re: filter coming off the URL...can you explain, or point to the respective code?

For eg:
http://test.sunflower.sahanafoundation.org/eden/project/project?sector.name=None%2CProject
In this page, "Project" in the Main menu is highlighted.
Click on 'open'
Now, "Deployment" gets highlighted even though you're in the projects page.

It looks fine in general - but before it gets merged you should probably send another email to the mailing list (because your previous email introduced a different design, so people may not expect this one here).
Either point to this PR, or attach some screenshots, clarify that you have abandoned your previous proposal and this is your new draft - then give people a couple of days to comment and discuss before we merge this.
Ok?

Yes, that sounds good.

@nursix as long as the filter stays in the url, i.e, ?sector.name=None,Project/Deployment, the Main menu shows the correct part being highlighted, I guess it's because of this:
https://github.com/hitesh96db/eden/commit/a5014026b827f06f9e8ed421f942fa4bbdee49bc#diff-d11854e3068b88cd7e7c34112ff346c9L79 ?
For eg:
http://test.sunflower.sahanafoundation.org/eden/project/project?sector.name=None%2CProject
In this page, "Project" in the Main menu is highlighted.
Click on 'open'
Now, "Deployment" gets highlighted even though you're in the projects page.

Ok - got you.
This is the automatic URL matching - S3Navigation matches the request URL against the item URL to determine which item to highlight. If two items match (like in this case), it picks the first match.
This is difficult to resolve because the paths are identical (project/project in either case). The best thing you can do is to set it manually at the point where you set the side menu. Tag the one menu item as "project", the other one as "deployment", and then set:
if ...condition for deployment...:
    topnav = current.menu.main
    topnav.findall("deployment")[0].selected = True
    topnav.findall("project")[0].selected = False

This overrides the automatic detection for those items.

well, plus the corresponding "else", of course ;) I think I don't need to say that, do I?

Nah ;), Thanks.

Sure, if the URL still has the filter, then the "Projects" item is the better match (it's tight, but still...).
But the URL project/project/11 only matches up to "project/project" with either item URL - so 100% equal, hence it picks the first match. You can only manually override this.
There is an alternative, though (that is, generally speaking, not a recommendation) - you could also define a separate controller. E.g.:
def project():
    return s3_rest_controller("project", "project")

def deployments():
    return project()

Both controllers do basically exactly the same thing - but they have different URLs, and hence would match different menu items. But as I say - not a recommendation, but just a possibility.

Btw - the shadow for the headline box contradicts the shadows in the forms. You have the light source at the top right, but the forms have the light source from above - which looks a bit strange.
I would remove the headline box shadow.

Can't have one shadow on the page in another direction than other shadows on the same page ;)
You have a big desire for some artistic extravagance :D but I do have an artistic eye (I've been painting for money some time in my life).

Uhm - and I see that the test instance doesn't yet have the latest default/style.css. Maybe you should update that before pointing to it (it has better support for mobile).

And fewer colours on the homepage would be better IMHO. Too many shades which don't harmonize.
Try to reduce noise: fewer colours (or shades of the same colour), fonts and button styles, maintain consistency. Don't make button labels bold, they are already in a prominent box. Ideally remove the icons, they don't really help here.
Well, ok - so much for now as feedback on the design ;)

Nah - ok, one more: rounded corners for buttons are out :D
But at least they are inconsistent with the rest of the theme. Either you have rounded corners everywhere (like here on GitHub = bootstrap), or not at all.

@nursix I tried --

if ...condition for deployment...:
    topnav = current.menu.main
    topnav.findall("deployment")[0].selected = True
    topnav.findall("project")[0].selected = False

But it didn't work, i.e, if I set project to False, it still remains selected.
I believe it's because of this -
https://github.com/flavour/eden/blob/master/modules/s3/s3navigation.py#L480,
the value gets overwritten and set to True.
Maybe we can add a check there to see if it has been set before - to either True or False ?

I have a better idea, I'll implement it then get back to you. Hold off this PR for noew.

Okay

Yup, a little patience please, though (it's weekend, so I have some family appointments first). Will work on it later in the evening.

Take your time, no urgency here.

Pushed. Once merged into trunk, you can do as follows:
if ...condition for deployment...:
    current.menu.main.select("deployment")
else:
    current.menu.main.select("project")

...though with the menu items in project=>deployment order, you can probably omit the else-branch.

Thanks :)

Updated look: http://test.sunflower.sahanafoundation.org/eden/
Changes made -

ICON instead of hardcoded classes
Menu font slightly larger
Header shadow removed
Round buttons everywhere
Usage of large, small and medium classes.
Fixed Menu Navigation problem

I'd say: good to merge.
The initial discussion had been open long enough, and subsequent enhancements can only be submitted once this is merged - so no point to hold off any further.

Added minified CSS file.

No need to add a minified CSS file - will be minified upon merge by Fran ;)


Stalls at Processing... on upload from iPhone Chrome

When I try to upload an existing picture from the camera roll on my iPhone using Chrome my website shows the spinner, filename and "Processing...." text but does not get any further--endless loop (see attached pic). If I take a picture with the camera on the spot that seems to work. On my desktop Mac using Chrome I see the preview image almost right away and the add files and upload buttons  always work. I am having trouble uploading images from a variety of mobile devices and browsers (chrome, safari, iphone, samsung, etc.). Is anyone else having the same issue on mobile?
Here are the libs I'm using:
Website:

php v7.3, codeigniter v3.1.11, jquery v3.2.1, bootstrap 3.3.7, blueimp jquery file upload 10.23.0
Mobile device:
iPhone 6 running iOS v13.3, mobile Chrome v81.0.4044.124

Any help would be greatly appreciated.

Thanks for your report @RentalGauge.
Can you reproduce this issue on the demo page?
Otherwise you might wanna upgrade to the latest version (including dependencies) and have a look at #3639.

The demo page worked perfectly on my iPhone. Thank you for pointing me in that direction.
I noticed that the demo code uses jQuery 1.12.4. My project was linking to jQuery 3.2.1. When I linked my project to jQuery 1.12.4, jquery file uploader worked!!
Is there a way to make jquery file uploader work with a more recent version of jQuery? Or is there a way to determine what the latest version of jQuery that jfu works with? I'm worried that some other feature of my site depends on features only found in jQuery 2x or 3x. Thanks again.

jQuery File Upload should definitely work with jQuery 3.2.1 as well - in fact the demo was set up with that version until very recently and has only been downgraded to be able to test old browser versions: 562354b
Could you provide more details on what did not work with jQuery 3.2.1?
e.g. error messages, step-by-step examples on how to reproduce the issue.
You can also run the demo locally - all you need is Docker - and change the jQuery script section to the following to try to reproduce any issues isolated to this project:
<script
  src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"
  integrity="sha384-vk5WoKIaW/vJyUAd9n/wmopsmNhiy+L2Z+SBxGYnUkunIxVxAv/UtMOhba/xskxh"
  crossorigin="anonymous"></script>

Closing this as not reproducible with the demo.


Add FULLTEXT indexes on MySQL one at a time

SQLSTATE[HY000]: General error: 1795 InnoDB presently supports one FULLTEXT index creation at a time
Ref #1392

Thanks a lot!