adapterOptions.isTlsRejectUnauthorized defaults to True even when set to false

Title says it all, if I pass false to isTlsRejectUnauthorized through adapterOptions it will resolve to false. Which invokes the logical OR so will always be set to true. Best to check if undefined

@swratten you can close your issue 🤓


Fixed time entry report UI bug

Notion card
https://www.notion.so/saeloun/Bugs-in-Time-Entry-Report-116e6536ff87433ca8f7c0fe0852a54d
Summary

Added scroll bar to report filter to access accept and reset buttons when multiple team members are added.
Fixed the last week date range issue while displaying the date between last month's and this month's date.
Added custom date range filter.
Implemented grid on the report page.
Moved Note column close to Project/Client column.

Preview

https://www.loom.com/share/06dd136fff024720831165e85b1fd620
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

[X] I have manually tested all workflows
[X] I have performed a self-review of my own code
[ ] I have added automated tests for my code

Yeah sure @onkar-saeloun, I will request other reviewers to review this PR by today.

@gowsik-ragunath your changes are causing some type errors in your branch
e.g. app/javascript/src/components/Reports/timeEntry/index.tsx line no 142.

@onkar-saeloun Could you share the error?

@onkar-saeloun Could you share the error?

Property 'onClickInput' does not exist on type 'IntrinsicAttributes & { setFilterVisibilty: any; resetFilter: any; handleApplyFilter: any; }'.
there is other one as well should we connect so that I can show it to you.

After compilation error won't be there. LGTM

@apoorv1316 Please test this on local and share results.

@apoorv1316 Separate ticket created for suggestions. Merging this PR into staging


PickerIOS style is actually style of View around RCTPickerIOS

When I put style on PickerIOS it's actually style for View which is around RCTPickerIOS in PickerIOS.ios.js, and when I change it and place {this.props.style} to RCTPickerIos style (instead of View around it), it applies directly to picker and it solves my problem. Can someone apply it (and if not, why is that so)? I can change it locally, but for every new version I would had to merge it or change it all over again. Thanks in advance

Hey, there's also itemStyle property as of this commit that is applied to RCTPickerIOS component -> https://github.com/facebook/react-native/commit/e2c35dddbac6ce305f1ed7b445e92fd392b42865. That's probably what you have been looking for :)

That's it! Thank you very much! :)


Cow: Watch skl-group.in

Cow requests the watch of the watch_keyword skl-group\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

skl-group\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Cody Gray in Charcoal HQ


Sometimes when user hits enter, an E appears in active square

This appears to be caused by the enter letter function to load the E from ENTER into the square.

Fixed by adding a return after the user hits the enter key so the function does not continue to evaluate the keystroke.


fix-issue-timedelta

Description
There seems to be an issue with the _set_timeout function of Tornado. If timeout is a timedelta with value zero it evaluates to false here which causes issues
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in f65386cf4fa6848fb680148eb62c3dc2b2be6333

Processing #5992.


rmlint: fix running rmlint --gui

rmlint has a --gui option which is writing a python "bootstrap" script
in /tmp.
It currently can't find its own python modules, as we don't prefix
PYTHONPATH to point to it. Also, there's some other runtime
dependencies, mostly due to using gtk from python(3), which also needs
to be preprended to PYTHONPATH.
rmlint also executes itself again with --version to determine some
features, for which we need to prefix PATH with $out/bin.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @k0ral

I'm not sure if we should put all these additions behind a withGui argument - it's not a separate binary here, but the (already existing) option is broken :-/

From documentation:
If you compiled rmlint from source, scons will try to build and install the GUI, except you pass --without-gui to it.

Therefore, a withGui derivation flag would definitely make sense, wouldn't it ?

So weird, why do not they just build a separate shredder executable? Then we could make a separate package for shredder using buildPythonApplication.
But yeah, I would use wrapPython as suggested by @Mic92 and https://nixos.org/nixpkgs/manual/#ssec-gnome-common-issues-double-wrapped

But yeah, I would use wrapPython as suggested by @Mic92 and https://nixos.org/nixpkgs/manual/#ssec-gnome-common-issues-double-wrapped

wrapPython also won't work, as it assumes to be handling a python script (and prepends to it), which of course doesn't work with ELF binaries…

@jtojnar, @Mic92 did I oversee something, or is the wrapProgram the only approach possible here?
In that case, I'd go with that (and add a withGui option and pass --without-gui conditionally, as suggested in https://github.com/NixOS/nixpkgs/pull/90267#issuecomment-643720856).

Yeah, that sounds right. If you want to prevent double wrapping, you can also go the other way round with gappsWrapperArgs+=(--prefix PYTHONPATH : …).
I would still prefer working with upstream to decouple the GUI into a separate executable and possibly package, though.

I pushed a new version, preventing the double wrapping as recommended in https://github.com/NixOS/nixpkgs/pull/90267#issuecomment-644727114.

I opened an issue at https://github.com/sahib/rmlint/issues/419 about moving the GUI into a separate binary.
After some thinking, I'll also flip withGui to false for the time being.
I could imagine people wanting to run this on headless systems, without pulling in all of GTK+.


little bug with puppet4 iteration + this module

Hiya - I've just noticed that ipcalc is not chomping off /subnets from cidr after doing it once.  This is reproducible when dealing with ip_netmask/ip_broadcast/ip_network in a single profile.
I was able to duplicate this pretty consistently but it might be a pain to set up.  I'm using the example42/network module but that's irrelevant here.
So from this hiera:
profile::virtualinterfacehash:
 vlan33:
    ipaddr: '<IP_ADDRESS>/24'

and in the profile:
$virtualinterfacehash.each |$name, $ipinfo| {
network::interface { "${name}":
      ipaddress         => ip_address($ipinfo["ipaddr"]),
      netmask           => ip_netmask($ipinfo["ipaddr"]),
      broadcast         => ip_broadcast($ipinfo["ipaddr"]),
      network           => ip_network($ipinfo["ipaddr"]),

The final output is :
auto vlan33
iface vlan33 inet static
    address <IP_ADDRESS>
    netmask <IP_ADDRESS>
    broadcast <IP_ADDRESS>/24
    network <IP_ADDRESS>/24

You see the last two lines barf this config - the cidr transform happens, but the /subnet is not stripped  This isn't an issue with just ip_broadcast or ip_network - having any two of those values (netmask/broadcast/network) means the second value (and any subsequent ones) will not strip the /subnet from the final output.
Let me know if you need any more information from me about this issue

That's the intended behavior of ip_broadcast and ip_network. These two functions produce a CIDR-pair. At the point where you're declaring your interface I think what you want instead of ip_network($ipinfo["ipaddr") is ip_address(ip_network($ipinfo["ipaddr"])). Same with ip_broadcast.

I'll add some example usage to the documentation.

Ah that makes a lot of sense. Thankyou.


Add tracking of basic states in Trainer [wip - to-be-merged after v0.9]

What does this PR do?
Fixes #1633
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

I was thinking maybe it would be better and cleaner if we made these state updates in decorators and add the decorators to methdods like the training loop, validation loop etc.
Haven't thought it through in detail. What do you think?
https://github.com/PyTorchLightning/pytorch-lightning/issues/1633#issuecomment-655859376

Hi @awaelchli! Yes I think it could look nicer with decorators, I try to implement it and mention you as soon as it's ready.

ummm. can you give an example?
i’d prefer to avoid decorators as much as possible

@williamFalcon my idea is something like this to wrap run functions (fit, test)

def decorate_run(run_fn):
    def wrapper():
        state = RUNNING
        try:
            run_fn()
        except KeyboardInterrupt as e:
            state = INTERRUPTED
        finally:
            if state != INTERRUPTED:
                state = FINISHED
    return wrapper

Not sure what to do with failing checks, the errors are unrelated to this PR I think.

@zerogerc mind rebase on master, thx :rabbit:

@Borda done.

as a follow-up pr lets replece all assres in test from assert result == 1 to trainer.state == TrainerState.FINISHED

Rebased. Could you please elaborate on the comment? as a follow-up pr lets replece all assres in test from assert result == 1 to trainer.state == TrainerState.FINISHED I think my tests already look like trainer.state == TrainerState.FINISHED

Rebased. Could you please elaborate on the comment?

as a follow-up pr lets replece all assres in test from assert result == 1 to trainer.state == TrainerState.FINISHED

I think my tests already look like trainer.state == TrainerState.FINISHED

yes, your tests are fine 👍
but I am talking about all other tests in folder tests - this would touch many files, some let's merge this one and the other make as separate PR... you are welcome to make it 🐰

Sure. I could do it as well. Next PR

@zerogerc one test was failing, but it seems unrelated, so I have just rebased it again, let's see if it helps...

@williamFalcon said he wants to wait with this, so we should probably wait for his approval before automerging

@williamFalcon said he wants to wait with this, so we should probably wait for his approval before auto merging

yes, this goes after v0.9, so I ll put there wip just in case...

this looks great! let's merge it

this looks great! let's merge it

I know that's why we made it =) just you we a bit conservative and leave it for 0.9.1
@zerogerc let's update all tests checks accordingly https://github.com/PyTorchLightning/pytorch-lightning/pull/2541#issuecomment-670520768


security by amigosCode

JWT authentication and authorization in a Spring Boot 3.0 application using Spring Security 6 and Postgres.

Config

authentication filter
JwtService
SecurityConfig
ApplicationConfig

Auth

controller
service
request
response


Naming arguments in Fn traits

Hi,
Right now If there's a Fn* trait that has 2 parameters of the same type it's really easy to confuse which is which.
i.e.:
type Callback = FnMut(&[u8], &[u8]) -> Point;

If we could name the arguments it would become easier to read and harder to misuse.
type Callback = FnMut(x: &[u8], y: &[u8]) -> Point;

Here, x and y represent types. They’re type variables. Type variables should be PascalCase.

No they're not?

Duplicate of https://github.com/rust-lang/rfcs/issues/557 (but this issue has a better name and examples, not mentioning some pre-1.0 features).

Duplicate of #557 (but this issue has a better name and examples, not mentioning some pre-1.0 features).

yeah but sugar syntax for closures is a few levels above what i'm proposing.

No they're not?

Yikes yeah, I was mistaken about what the OP wanted to do.

The "duplicate" issue is marked as completed but it doesn't work. Playground link.


Product recommendations

Default to showing the top 5 products sold when first opening up the widget, and then 1 or 2 lines of highlighted product recommendations based on your current search

We have three different types of recommendations that we want to display in the widget:

personal product recommendation, based on previous purchases
similar product recommendations, based on one product
complementary product recommendations, based on your basket of products

@pedropregueiro & @datascienceit, please correct me if I'm wrong

personal recommendations

similar recommendations

complementary recommendations

I think the complementary items, aka. "people who bought X also bought this:" should be on the product page as well.
for the checkout, we could have bundles, but we don't have it today, correct @datascienceit ?

@pedro, so there would be one recommendation feed with both types?

for "1. personal product recommendation, based on previous purchases", if you send a random user id "123", you'll get popular items, instead of user recommendations

Will implement https://github.com/kvassAI/javascript-sdk/issues/19 first before moving to this issue

Training two models for our ecommerce demo company: content_similarity_graph and  frequent_items_recommender


Allow traversals as predicates

See #158

Codecov Report

Merging #184 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   99.83%   99.59%   -0.24%
==========================================
  Files           1        1
  Lines        1227     1242      +15
==========================================
+ Hits         1225     1237      +12
- Misses          2        5       +3

Impacted Files
Coverage Δ

dist/partial.lenses.cjs.js
99.59% <0%> (-0.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4187f91...cedd6b0. Read the comment docs.


[TW#13148] i2c timeout error

I'm polling a i2c device every half second and after a while (sometimes 4 minutes, sometimes half an hour). The i2c_master_cmd_begin function returns ESP_ERR_TIMEOUT, and every next call to i2c_master_cmd_begin returns ESP_ERR_TIMEOUT.
I tried deleting the driver using i2c_driver_delete and then i2c_driver_install but it keeps giving the error.
At this time the SDA line remains low and the SCL line remains high. I also tried to delete the driver and then change the pins to output and change to no avail.
The device I am communicating with is a battery monitor (LC709203F). But I have the same problem with an accelerometer.
init code
    i2c_config_t conf;
    conf.mode = I2C_MODE_MASTER;
    conf.sda_io_num = I2C_MASTER_SDA_IO;
    conf.sda_pullup_en = GPIO_PULLUP_DISABLE;
    conf.scl_io_num = I2C_MASTER_SCL_IO;
    conf.scl_pullup_en = GPIO_PULLUP_DISABLE;
    conf.master.clk_speed = I2C_MASTER_FREQ_HZ;
    i2c_param_config(I2C_MASTER_NUM, &conf);
    i2c_driver_install(I2C_MASTER_NUM, conf.mode, I2C_MASTER_RX_BUF_DISABLE, I2C_MASTER_TX_BUF_DISABLE, 0);

communication code
    int ret = 0;
    uint8_t crc = 0, crc_read, valh, vall;
    i2c_cmd_handle_t cmd;

    cmd = i2c_cmd_link_create();
    i2c_master_start(cmd);
    i2c_master_write_byte(cmd, ( FG_SLAVE_ADDR << 1 ) | WRITE_BIT, ACK_CHECK_EN);
    i2c_master_write_byte(cmd, command, ACK_CHECK_EN);
    i2c_master_start(cmd);
    i2c_master_write_byte(cmd, ( FG_SLAVE_ADDR << 1 ) | READ_BIT, ACK_CHECK_EN);
    i2c_master_read_byte(cmd, &vall, ACK_VAL);
    i2c_master_read_byte(cmd, &valh, ACK_VAL);
    i2c_master_read_byte(cmd, &crc_read, NACK_VAL);
    i2c_master_stop(cmd);
    ret = i2c_master_cmd_begin(I2C_MASTER_NUM, cmd, 1000 / portTICK_RATE_MS);
    i2c_cmd_link_delete(cmd);

Maybe this could be related to https://github.com/espressif/arduino-esp32/issues/349 . I've noticed similar things when I poll some I2C-GPIO-Expander every 20ms. At some point the request will either always fail or just lock up.

debugging a bit more it seems something locks up the lines. I tried disconnecting the device but the lines remain in their locked state.
This is really frustrating as the only solution seems to be to reset the device when this happens. But that means data loss since we use the esp32 to measure sensors continuously and report this data to the cloud.
Well we can continue our measurements but we will be missing all info we get via i2c (battery and accelerometer at this point).

Also this kind of problem seams to be noticed in the forum:

https://esp32.com/viewtopic.php?f=2&t=2181&p=10333#p10333
https://esp32.com/viewtopic.php?f=2&t=2178&p=10265&hilit=i2c#p10265
I would guess this more widespread than one may think.

I think I have the same problem but with a DS3231 / DS1307. The interesting thing is, that I have exactly your behavior using the ESP-IDF. But if I use the ESP-Arduino SDK (as a component in IDF) it works without any problems.

+1.
I experience this with ft6206 touch controller and mvh3002d temperature/humidity sensor.

Weird, is there a soft reboot during reading the I2C slave?

As far as I know, the device will only get stuck when the slave hold the bus wires and get the bus into a wrong state. Would you please post some of your reading code here? @Sermus @Curclamas @tdesmet

Nop, there is no soft reboot (until i force it)

I have no problem with I2C and MPU6050, even i can polling every 20ms, but im having problem with mcp23017.

The patch will be merged into master branch recently

@costaud  how did you fix it? Can we already see the fix on master?
Am 18.10.2017 04:34 schrieb "costaud"<EMAIL_ADDRESS>
The patch will be merged into master branch recently
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/issues/680#issuecomment-337442918,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC_DS7uqY_KVwjNpkpc20taPWvw1ba9Mks5stWO7gaJpZM4Nz80L
.

The state machine of I2C bus could be dead if the bus is influenced in some circumstance(for example, short the sda/scl to gnd for a while). The hardware would get stuck and be always sending clock on scl or only sending a single pulse on scl. We can only reset the I2C hardware to get the hardware back working.
To reset the hardware, we can call periph_module_disable then periph_module_enable, but all the register settings will be lost.  We will try to merge this patch ASAP. In the next version of chips, we will find some way to void this situation.

I am facing the same issue with I2C example provided in idf.
ESP32 Arduino works as expected whereas esp-idf gives the following errors

timeout : 0x107 (generated by I2C_STATUS_TIMEOUT)
failed: -1 (generated by I2C_STATUS_ACK_ERROR)

The slave is an Arduino device.
ESP-idf version: v3.1
Code:

#include <stdio.h>
#include "driver/i2c.h"

#define I2C_EXAMPLE_MASTER_SDA_IO 22           /*!< gpio number for I2C master data  */
#define I2C_EXAMPLE_MASTER_SCL_IO 23           /*!< gpio number for I2C master clock */
#define I2C_EXAMPLE_MASTER_NUM I2C_NUM_0       /*!< I2C port number for master dev */
#define I2C_EXAMPLE_MASTER_TX_BUF_DISABLE 0    /*!< I2C master do not need buffer */
#define I2C_EXAMPLE_MASTER_RX_BUF_DISABLE 0    /*!< I2C master do not need buffer */
#define I2C_EXAMPLE_MASTER_FREQ_HZ (10 * 1000) /*!< I2C master clock frequency */

#define DATA_LENGTH 1   //18             /*!<Data buffer length for test buffer*/
#define I2C_SLAVE_ADDR (8)         /*!< ESP32 slave address, you can set any 7bit value */
#define WRITE_BIT I2C_MASTER_WRITE /*!< I2C master write */
#define READ_BIT I2C_MASTER_READ   /*!< I2C master read */
#define ACK_CHECK_EN 0x1           /*!< I2C master will check ack from slave*/
#define ACK_CHECK_DIS 0x0          /*!< I2C master will not check ack from slave */
#define ACK_VAL 0x0                /*!< I2C ack value */
#define NACK_VAL 0x1               /*!< I2C nack value */

static esp_err_t i2c_example_master_read_slave(i2c_port_t i2c_num, uint8_t *data_rd, size_t size)
{
    esp_err_t err = ESP_OK;

    i2c_cmd_handle_t cmd = i2c_cmd_link_create();
    i2c_master_start(cmd);
    i2c_master_write_byte(cmd, (I2C_SLAVE_ADDR << 1) | READ_BIT, ACK_CHECK_EN);
    if (size > 1)
    {
        i2c_master_read(cmd, data_rd, size - 1, ACK_VAL);
    }
    i2c_master_read_byte(cmd, data_rd + size - 1, NACK_VAL);
    i2c_master_stop(cmd);
    err = i2c_master_cmd_begin(i2c_num, cmd, 1000 / portTICK_RATE_MS);
    i2c_cmd_link_delete(cmd);

    return err;
}

static void i2c_example_master_init()
{
    int i2c_master_port = I2C_EXAMPLE_MASTER_NUM;
    i2c_config_t conf;
    conf.mode = I2C_MODE_MASTER;
    conf.sda_io_num = I2C_EXAMPLE_MASTER_SDA_IO;
    conf.sda_pullup_en = GPIO_PULLUP_ENABLE;
    conf.scl_io_num = I2C_EXAMPLE_MASTER_SCL_IO;
    conf.scl_pullup_en = GPIO_PULLUP_ENABLE;
    conf.master.clk_speed = I2C_EXAMPLE_MASTER_FREQ_HZ;
    esp_err_t err = i2c_param_config(i2c_master_port, &conf);
    if (ESP_OK == err)
    {
        err = i2c_driver_install(i2c_master_port, conf.mode,
                                 I2C_EXAMPLE_MASTER_RX_BUF_DISABLE,
                                 I2C_EXAMPLE_MASTER_TX_BUF_DISABLE, 0);
        printf("i2c_driver_install 0x%x \n", err);
    }
    else
    {
        printf("i2c_param_config fail 0x%x \n", err);
    }
}

static void i2c_test_task(void *arg)
{
    uint8_t data_rd[DATA_LENGTH] = {0};
    int cnt = 0;
    esp_err_t ret = 0;

    while (1)
    {
        printf("cnt: %d\n", cnt++);

        vTaskDelay(100 / portTICK_RATE_MS);

        ret = i2c_example_master_read_slave(I2C_EXAMPLE_MASTER_NUM, data_rd, DATA_LENGTH);

        if (ESP_OK == ret)
        {
            data_rd[DATA_LENGTH] = 0;
            printf("Data: %s \n", data_rd);
        }
        else
        {
            printf("err: 0x%x %s \n", ret, esp_err_to_name(ret));
        }
    }
}

void app_main()
{
    i2c_example_master_init();
    xTaskCreate(i2c_test_task, "i2c_test_task_1", 1024 * 5, (void *)1, 10, NULL);
}

I can confirm this error still exists...I Incorporated the one-line
fix/cludge into a local fork of the esp-idf repo and keep track of it that
way.
On Mon, Apr 22, 2019, 8:28 AM Amruta<EMAIL_ADDRESS>wrote:

I am facing the same issue with I2C example provided in idf.
ESP32 Arduino works as expected whereas esp-idf gives the following errors

timeout : 0x107 (generated by I2C_STATUS_TIMEOUT)
failed: -1 (generated by I2C_STATUS_ACK_ERROR)

The slave is an Arduino device.
ESP-idf version: v3.1
Code:
#include <stdio.h>
#include "driver/i2c.h"
#define I2C_EXAMPLE_MASTER_SDA_IO 22           /*!< gpio number for I2C master data  /
#define I2C_EXAMPLE_MASTER_SCL_IO 23           /!< gpio number for I2C master clock /
#define I2C_EXAMPLE_MASTER_NUM I2C_NUM_0       /!< I2C port number for master dev /
#define I2C_EXAMPLE_MASTER_TX_BUF_DISABLE 0    /!< I2C master do not need buffer /
#define I2C_EXAMPLE_MASTER_RX_BUF_DISABLE 0    /!< I2C master do not need buffer /
#define I2C_EXAMPLE_MASTER_FREQ_HZ (10 * 1000) /!< I2C master clock frequency */
#define DATA_LENGTH 1   //18             /!<Data buffer length for test buffer/
#define I2C_SLAVE_ADDR (8)         /!< ESP32 slave address, you can set any 7bit value /
#define WRITE_BIT I2C_MASTER_WRITE /!< I2C master write /
#define READ_BIT I2C_MASTER_READ   /!< I2C master read /
#define ACK_CHECK_EN 0x1           /!< I2C master will check ack from slave/
#define ACK_CHECK_DIS 0x0          /*!< I2C master will not check ack from slave /
#define ACK_VAL 0x0                /!< I2C ack value /
#define NACK_VAL 0x1               /!< I2C nack value */
static esp_err_t i2c_example_master_read_slave(i2c_port_t i2c_num, uint8_t *data_rd, size_t size)
{
esp_err_t err = ESP_OK;
i2c_cmd_handle_t cmd = i2c_cmd_link_create();
i2c_master_start(cmd);
i2c_master_write_byte(cmd, (I2C_SLAVE_ADDR << 1) | READ_BIT, ACK_CHECK_EN);
if (size > 1)
{
    i2c_master_read(cmd, data_rd, size - 1, ACK_VAL);
}
i2c_master_read_byte(cmd, data_rd + size - 1, NACK_VAL);
i2c_master_stop(cmd);
err = i2c_master_cmd_begin(i2c_num, cmd, 1000 / portTICK_RATE_MS);
i2c_cmd_link_delete(cmd);

return err;

}
static void i2c_example_master_init()
{
int i2c_master_port = I2C_EXAMPLE_MASTER_NUM;
i2c_config_t conf;
conf.mode = I2C_MODE_MASTER;
conf.sda_io_num = I2C_EXAMPLE_MASTER_SDA_IO;
conf.sda_pullup_en = GPIO_PULLUP_ENABLE;
conf.scl_io_num = I2C_EXAMPLE_MASTER_SCL_IO;
conf.scl_pullup_en = GPIO_PULLUP_ENABLE;
conf.master.clk_speed = I2C_EXAMPLE_MASTER_FREQ_HZ;
esp_err_t err = i2c_param_config(i2c_master_port, &conf);
if (ESP_OK == err)
{
err = i2c_driver_install(i2c_master_port, conf.mode,
I2C_EXAMPLE_MASTER_RX_BUF_DISABLE,
I2C_EXAMPLE_MASTER_TX_BUF_DISABLE, 0);
printf("i2c_driver_install 0x%x \n", err);
}
else
{
printf("i2c_param_config fail 0x%x \n", err);
}
}
static void i2c_test_task(void *arg)
{
uint8_t data_rd[DATA_LENGTH] = {0};
int cnt = 0;
esp_err_t ret = 0;
while (1)
{
    printf("cnt: %d\n", cnt++);

    vTaskDelay(100 / portTICK_RATE_MS);

    ret = i2c_example_master_read_slave(I2C_EXAMPLE_MASTER_NUM, data_rd, DATA_LENGTH);

    if (ESP_OK == ret)
    {
        data_rd[DATA_LENGTH] = 0;
        printf("Data: %s \n", data_rd);
    }
    else
    {
        printf("err: 0x%x %s \n", ret, esp_err_to_name(ret));
    }
}

}
void app_main()
{
i2c_example_master_init();
xTaskCreate(i2c_test_task, "i2c_test_task_1", 1024 * 5, (void *)1, 10, NULL);
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/issues/680#issuecomment-485406352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUPXOUKJFB6TDUTDA57XXLPRWVPBANCNFSM4DOPZUFQ
.

@arsinio can you share the changes which are working for you?
It would of great help.

I am facing the same issue with I2C example provided in idf.
ESP32 Arduino works as expected whereas esp-idf gives the following errors
* timeout : 0x107 (generated by I2C_STATUS_TIMEOUT)

* failed: -1 (generated by I2C_STATUS_ACK_ERROR)

The slave is an Arduino device.
ESP-idf version: v3.1
Code:
init
 int i2c_master_port = I2C_EXAMPLE_MASTER_NUM;
    i2c_config_t conf;
    conf.mode = I2C_MODE_MASTER;
    conf.sda_io_num = I2C_EXAMPLE_MASTER_SDA_IO;
    conf.sda_pullup_en = GPIO_PULLUP_ENABLE;
    conf.scl_io_num = I2C_EXAMPLE_MASTER_SCL_IO;
    conf.scl_pullup_en = GPIO_PULLUP_ENABLE;
    conf.master.clk_speed = I2C_EXAMPLE_MASTER_FREQ_HZ;
    esp_err_t err = i2c_param_config(i2c_master_port, &conf);
    if (ESP_OK == err)
    {
        err = i2c_driver_install(i2c_master_port, conf.mode,
                                 I2C_EXAMPLE_MASTER_RX_BUF_DISABLE,
                                 I2C_EXAMPLE_MASTER_TX_BUF_DISABLE, 0);
        printf("i2c_driver_install 0x%x \n", err);
    }
    else
    {
        printf("i2c_param_config fail 0x%x \n", err);
    }

read data from slave
    i2c_cmd_handle_t cmd = i2c_cmd_link_create();
    i2c_master_start(cmd);
    i2c_master_write_byte(cmd, (I2C_SLAVE_ADDR << 1) | READ_BIT, ACK_CHECK_EN);
    if (size > 1)
    {
        i2c_master_read(cmd, data_rd, size - 1, ACK_VAL);
    }
    i2c_master_read_byte(cmd, data_rd + size - 1, NACK_VAL);
    i2c_master_stop(cmd);
    err = i2c_master_cmd_begin(i2c_num, cmd, 1000 / portTICK_RATE_MS);
    i2c_cmd_link_delete(cmd);

More details:
On Arduino slave side, it gives TW_BUS_ERROR

@AmrutaCh
You'll need to modify components/driver/i2c.c...I'm not up-to-date with the latest version so I'll just walk you through the change:
In esp_err_t i2c_param_config(i2c_port_t i2c_num, const i2c_config_t* i2c_conf) there is an if block...something like:
if (i2c_conf->mode == I2C_MODE_SLAVE) {  //slave mode
...
} else {
...
}

You'll need to modify the else clause changing
I2C[i2c_num]->timeout.tout = cycle * I2C_MASTER_TOUT_CNUM_DEFAULT;

To
I2C[i2c_num]->timeout.tout = 1048575;

That number was picked because, to the best of my knowledge, it's the largest supported by the hardware.
That being said there is a "newer" function that may help:
i2c_set_timeout
When first introduced I found that it did not resolve my issue, but I should really give it another try.

@arsinio
Sadly, it didn't work for me.
Setting the value to 0xfffff (=I2C_TIME_OUT_REG_V) resulted in salve being able to write 2 bytes.
Previously it was not able to write it at all

i2c_set_timeout worked
Thanks @arsinio

Hi
I tried to read SHT20 registers with I2C tool with "i2cget" command, but it has error
"ESP_ERR_TIMEOUT Operation timeout because the bus is busy"
esp_err_t = 0x107
what does it mean?
Maybe it depends on the timout setting. (i2c_set_timeout)
I trid to set timeout in multi value but it doesn't work

Hi
I tried to read SHT20 registers with I2C tool with "i2cget" command, but it has error "ESP_ERR_TIMEOUT Operation timeout because the bus is busy" esp_err_t = 0x107 what does it mean? Maybe it depends on the timout setting. (i2c_set_timeout) I trid to set timeout in multi value but it doesn't work

Hi
Wondering if you solved this issue, because I'm facing the same problem with esp32-s3-pico and pn532. If yes, can you provide the solution that worked for you?

Hi Wondering if you solved this issue, because I'm facing the same problem with esp32-s3-pico and pn532. If yes, can you provide the solution that worked for you?

I couldn't solve this problem, but with a program that I wrote myself based on the SHT20 datasheet, it worked easily. I also used a DS1307 module with the i2c tool, which worked properly as well. I was able to read and write to the registers perfectly. I think in some i2c devices, there's a need for a short response time for the device to respond and send data, which hasn't been considered in the i2c tool code.

Also having the same issue in v5.2.2, having said that I'm using the legacy driver I think. I will git it a go with the new driver in i2c_master.c

Also having the same issue in v5.2.2, having said that I'm using the legacy driver I think. I will git it a go with the new driver in i2c_master.c

Have you been succesfull with the new driver?
I am having ESP_ERR_TIMEOUT with the legacy I2C driver in the ESP32S3 with idf 5.3.1.
The exat same code runs without any problem on esp32 with espidf 4.X.

I defaulted to using v5.1.4, (legacy driver) hybrid approach. Port 0 on IDF and port 1 in Arduino wire function!


how to generate a mesh with external datas ?

Hi @pissang,
I hope that you're in good health.
Thank's a lot for ClayGL which is a really cool project.
This is a question, not an issue :
Is it possible to generate a mesh by injecting an array of vertices and an array of edges generated outside of ClayGL ?
The idea would be to inject some datas in a component closed to the ParametricSurface, for example. By this way, I could reuse some components I wrote for other WebGL experiments, and which are "framework agnostic". I didn't find an example on that principle in the project.
Take care,
Greg

Hi,
I found a solution to solve my problem, with this exemple of cx20 :
https://cx20.github.io/jsdo.it-archives/cx20/gltS/
Thank's


Long-Form Generation

Hi,
Do you know if it's possible to smoothly generate longer audio with WhisperSpeech? And dialogue with multiple characters?
Thanks!

Both these features should be possible if we implement #52

Nice! What about generating dialogue? Should that be done separately (ie quote extraction + attribution -> WhisperSpeech w/ voice cloning)?

Yes, you're right. This would give you the most control over the style and voice of each speaker.
One could probably find or train a traditional NLP preprocessing model to do this automatically.

Thanks! Should I close this issue in favor of #52?

These is also #58 , which would also be useful.
Maybe this can be the umbrella task. :)


Auto-link HTML in Package Description

Would be great for everyone !! :+1:

Related #2280

Is a PR accepted on this one?

Bump

/cc @joyhui

Will be part of Support formatting in description #2280 (when we tackle it)

Lol doesn't look like formating will ever be implemented.

Same for this one. 5 years old and even no response if a PR is accepted.


Relation using mongodb and mysql

I have to model

themes ( mongodb )
users ( mysql )

I'm create a method user on theme model to call the user who's create
public function user ()
{
    return $this->belongsTo( 'ThemeGenerator\User' );
}

After when I call the user in the view I try $theme->user()->username, $theme->user->username.
But noting happens.
Please help me thanks!

Does your User model extend Jenssegers\Eloquent\Model? It needs to extend that, rather than the default Illuminate\Database\Eloquent\Model.

Yeah, but the user model run directly on mysql. It's maybe cause a trouble?


⚠ Bofrost.at has degraded performance

In 9195ab1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 15190 ms

Resolved: Bofrost.at performance has improved in f8d08d5.


core: Add additional properties recursively for structured output(openai) when nested object is generated

Hello.
First of all, thank you for maintaining such a great project.
Description
In https://github.com/langchain-ai/langchain/pull/25123, support for structured_output is added. However, "additionalProperties": false needs to be included at all levels when a nested object is generated.
error from current code: https://gist.github.com/fufufukakaka/e9b475300e6934853d119428e390f204
BadRequestError: Error code: 400 - {'error': {'message': "Invalid schema for response_format 'JokeWithEvaluation': In context=('properties', 'self_evaluation'), 'additionalProperties' is required to be supplied and to be false", 'type': 'invalid_request_error', 'param': 'response_format', 'code': None}}

Reference: Introducing Structured Outputs in the API
{
  "model": "gpt-4o-2024-08-06",
  "messages": [
    {
      "role": "system",
      "content": "You are a helpful math tutor."
    },
    {
      "role": "user",
      "content": "solve 8x + 31 = 2"
    }
  ],
  "response_format": {
    "type": "json_schema",
    "json_schema": {
      "name": "math_response",
      "strict": true,
      "schema": {
        "type": "object",
        "properties": {
          "steps": {
            "type": "array",
            "items": {
              "type": "object",
              "properties": {
                "explanation": {
                  "type": "string"
                },
                "output": {
                  "type": "string"
                }
              },
              "required": ["explanation", "output"],
              "additionalProperties": false
            }
          },
          "final_answer": {
            "type": "string"
          }
        },
        "required": ["steps", "final_answer"],
        "additionalProperties": false
      }
    }
  }
}

In the current code, "additionalProperties": false is only added at the last level.
This PR introduces the _add_additional_properties_key function, which recursively adds "additionalProperties": false to the entire JSON schema for the request.
Twitter handle: @fukkaa1225
Thank you!

When is this expected to be merged? would be super useful

thank you @fufufukakaka! will be out in langchain-core 0.2.35, which will be released later today

thanks!


Cannot find com ports on windows

While trying to get the COM ports on windows  using
ports, err := serial.GetPortsList()

it always returns an empty array

Duplicate of #85


Bring devcontainer definition to this repo

The current definition lives in this repo. This is the only devcontainer definition in this repo. Until this repo gain traction, bring the devcontainer definition used in this project to the present monorepo.

The devcontainer is neither an app nor a library. The best place to store it is the folder tools/.

Options:

SQLTools
MySQL Shell for VS Code (preview)

For now I'm going with SQLTools because:

one of the highest SQL installation count (1.7M)
Open-source
Explicitly supports MariaDB as well as other drivers

Extension IDs:
"mtxr.sqltools",
"mtxr.sqltools-driver-mysql"


🐛 BUG: CRLF line endings in comments causes an error

What version of Wrangler are you using?
0.0.30
What operating system are you using?
Windows
Describe the Bug
Comments in wrangler.toml files saved with CRLF line endings cause an error.
Example wrangler.toml
name = "my-worker"
main = "src/index.ts"
compatibility_date = "2022-05-06" # comment

When saved with LF line endings, there are no issues.
When saved with CRLF line endings, an error is thrown.

Error
 ⛅ wrangler 0.0.30
--------------------

X [ERROR] X [ERROR] Control characters (codes < 0x1f and 0x7f) are not allowed in comments, use \u000d instead

Example reproduction (on Windows) - uses the https://github.com/cloudflare/rustwasm-worker-template/blob/master/wrangler.toml template since it's the one I first encountered the issue on.
git clone https://github.com/cloudflare/rustwasm-worker-template.git
cd rustwasm-worker-template
npx<EMAIL_ADDRESS>dev

PS C:\Users\K\Desktop\rustwasm-worker-template> npx<EMAIL_ADDRESS>dev
 ⛅ wrangler 0.0.30
--------------------

X [ERROR] X [ERROR] Control characters (codes < 0x1f and 0x7f) are not allowed in comments, use \u000d instead

      C:\Users\K\Desktop\rustwasm-worker-template\wrangler.toml:10:77:
        10 │ command = "cargo install -q worker-build && worker-build --release" #
  required
           ╵                                                                              ^

    If you think this is a bug, please open an issue at:
    https://github.com/cloudflare/wrangler2/issues/new

PS C:\Users\K\Desktop\rustwasm-worker-template> git ls-files --eol
i/lf    w/crlf  attr/                   .gitignore
i/lf    w/crlf  attr/                   CODE_OF_CONDUCT.md
i/lf    w/crlf  attr/                   Cargo.lock
i/lf    w/crlf  attr/                   Cargo.toml
i/lf    w/crlf  attr/                   LICENSE_APACHE
i/lf    w/crlf  attr/                   README.md
i/lf    w/crlf  attr/                   src/lib.rs
i/lf    w/crlf  attr/                   src/utils.rs
i/lf    w/crlf  attr/                   wrangler.toml

Great catch, looks like an issue with our parser https://github.com/iarna/iarna-toml/issues/33 I'll work on a fix soon.


Updated dependencies

Updated following dependencies:
loader-utils:  "^0.2.7" => "^0.2.12",
eslint: "^2.0.0" => "^2.4.0",
eslint-friendly-formatter: "^1.0.3" => "^1.2.2",
npmpub: "^3.0.1" => "^3.1.0",
tape: "^4.0.0" => "^4.5.1",
webpack: "^1.12.14" => "^1.12.14"

According to the version using ^, this updates are automatic for each fresh install, so I will pass. Thanks anyway.


[CLI]: Artifact cannot be created when metadata contains Tensors with wandb 0.13.5

Describe the bug

When I try to create an Artifact with wandb 0.13.5, I got the error
TypeError: Object of type Tensor is not JSON serializable

, while the same code works with wandb 0.13.4.
After a quick check, I found the behavior change in _normalize_metadata
in 0.13.4:
https://github.com/wandb/wandb/blob/d622ee37b232e54addcd48e9f92d9198a3e2790b/wandb/sdk/wandb_artifacts.py#L92-L99
in 0.13.5:
https://github.com/wandb/wandb/blob/e85ba97972308091d22f34e275cd58fea4b774dc/wandb/sdk/wandb_artifacts.py#L92-L99
In 0.13.4, json_friendly_val will check and convert the tensor type, and this is removed in 0.13.5.
It this change intentionally?
Additional Files
No response
Environment
WandB version: 0.13.5
OS: Ubuntu 20.04
Python version: 3.8
Versions of relevant libraries:
Additional Context
No response

Hi @jchengai , thank you for writing in. I will review the change on our end and get back to you.

I can confirm the same issue, wandb==0.13.5 python==3.10.6 on Ubuntu 20.04 as well. wandb==0.13.4 works fine.

I had the same issue, but this was resolved by downgrading to wandb==0.13.4


Prevent default "close editor" behavior of going to previously opened editor

When closing an editor/tab in VSCode, it navigates back to the previous editor/tab you were using. Compare this behavior to Firefox or Chrome, which simply go to the next tab to the right.
This can be annoying, because it depends on state that is not visible. If possible, could you create a setting that depends on the horizontal locations of the tabs? This may be more predictable.
Thanks!

@bpasero not sure how this is a question instead of feature request. I am requesting a new settings option.

@bpasero not sure how this is a question instead of feature request. I am requesting a new settings option.

I suggested to search on SO for discovering the existing workbench.editor.focusRecentEditorAfterClose setting.

I suggested to search on SO for discovering the existing workbench.editor.focusRecentEditorAfterClose setting.


Updated ReverseDSC Sizing on the screen for responsiveness

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[ ] New/changed code adheres to DSC Community Style Guidelines.

This change is

@jasonwbaxter The HQRM test failed because there are tabs in your changes and the HQRM rules requires that all tabs are four spaces. Can you please correct this issue?


[TwigComponent] Public property not found

Hey,
I've got an issue with TwigComponent not finding public properties. Simplified it looks like this:
#[AsTwigComponent]
final class SwitchToggle
{
    public string $formId;
    public string $label;
}

Rendering fails (sometimes) with
Neither the property "formId" nor one of the methods "formId()", "getformId()"/"isformId()"/"hasformId()" or "__call()" exist and have public access in class "App\Core\Twig\Component\SwitchToggle".
  at templates/components/SwitchToggle.html.twig:3
  at twig_get_attribute()
     (var/cache/dev/twig/ca/caf2b40685d6b6a5bce6b357a77dfb58.php:48)
  at __TwigTemplate_2fee75614958a766d9c4f01e39f158f8->doDisplay()
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling()
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display()
     (vendor/twig/twig/src/Template.php:379)
  at Twig\Template->render()
     (vendor/symfony/ux-twig-component/src/ComponentRenderer.php:79)
  at Symfony\UX\TwigComponent\ComponentRenderer->render()
     (vendor/symfony/ux-live-component/src/EventListener/LiveComponentSubscriber.php:340)
  at Symfony\UX\LiveComponent\EventListener\LiveComponentSubscriber->createResponse()
     (vendor/symfony/ux-live-component/src/EventListener/LiveComponentSubscriber.php:268)
  at Symfony\UX\LiveComponent\EventListener\LiveComponentSubscriber->onKernelView()
     (vendor/symfony/event-dispatcher/Debug/WrappedListener.php:116)
  at Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke()
     (vendor/symfony/event-dispatcher/EventDispatcher.php:206)
  at Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
     (vendor/symfony/event-dispatcher/EventDispatcher.php:56)
  at Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
     (vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:127)
  at Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch()
     (vendor/symfony/http-kernel/HttpKernel.php:183)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor/symfony/http-kernel/HttpKernel.php:76)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor/symfony/http-kernel/Kernel.php:185)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (public/index.php:29)

I've dumped the section in the corresponding Twig template file:

(Ignore the value-true-thing... the screenshot comes from a different try.)
I've got now clue, why Twig cannot find the attribute? I've also tried a LiveComponent variant and then it renders, but fails on re-rendering.
It feels that I'm making a basic mistake, but I dunno why most of my components work, but some fail this hard.
Kind regards
Matthias

Oh... template looks like this:
    {# @var \App\Core\Twig\Component\SwitchToggle this #}

        <input class="form-check-input" type="checkbox" role="switch" id="{{ this.formId }}">
        {{ this.label }}

Could you show us how you're calling your component ?  Is it from a controller template or is it from another component ?
Also if you can a stack (as a TwigComponent) could help too
It's like it was never mounted, because not passing the vars should have throw an error, and still it has no id/label properties..

It's just from a normal controller template:

    <twig:SwitchToggle formId="someId" label="someLabel />

(i think the missing quote is from a copy/paste error ?)
Very strange. Does the TwigComponent profiler panel give you any information ?
You said your template is found and rendered right ?

Yes, missing quote was a typo. It may be that I've mixed up code during the transition to a LiveComponent. At least I cannot generate a reproduction case at the moment.
I'll keep this open and check I can get the error back.

Hmm... here we go again:
Twig\Error\RuntimeError:
Neither the property "message" nor one of the methods "message()", "getmessage()"/"ismessage()"/"hasmessage()" or "__call()" exist and have public access in class "App\Core\Twig\Component\Alert".

  at templates/components/Alert.html.twig:6
  at twig_get_attribute()
     (var/cache/dev/twig/7e/7eb49676d3bf607246e51be2ba4678c0.php:60)
  at __TwigTemplate_a857696e00cbd69c149693c620c8ce38->doDisplay()
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling()
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display()
     (vendor/twig/twig/src/Template.php:379)
  at Twig\Template->render()
     (vendor/symfony/ux-twig-component/src/ComponentRenderer.php:79)
  ...

That's a component which used to work before I've updated the UX dependencies. I don't know what update lead to this error, but the component was working some months ago.
{# @var \App\Core\Twig\Component\Alert this #}

    {% if this.icon is not null %}
        {{ icon(this.icon, 'me-2') }}
    {% endif %}
    {{ this.message }}

<?php

declare(strict_types=1);

namespace App\Core\Twig\Component;

use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;

#[AsTwigComponent(template: 'components/Alert.html.twig')]
final class Alert
{
    public string $type = 'success';
    public string $message;
    public bool $solid = false;

    public function getIcon(): ?string
    {
        return match ($this->type) {
            'success' => 'check-circle',
            'info' => 'info-circle',
            'warning' => 'exclamation-circle',
            'danger' => 'exclamation-triangle',
            default => null,
        };
    }

So it's basically a pimped version of the Alert from the UX documentation. If I add getter to the properties the exception changes to

An exception has been thrown during the rendering of a template ("Typed property App\Core\Twig\Component\Alert::$message must not be accessed before initialization").

The call is a simple
<twig:Alert type="error" messsage="Yo, broken" />

in a simple show controller action.

Oh I'm running on the latest releases:
symfony/ux-live-component           v2.16.0            Live components for Symfony
symfony/ux-twig-component           v2.16.0            Twig components for Symfony

Oh... this is interesting... using the component function is working fine:
{{ component('Alert', {
    type: 'danger',
    message: 'Danger Will Robinson!'
}) }}

So it's breaking using the HTML element syntax.

<twig:Alert type="error" messsage="Yo, broken" />

You have an extra "s" in "message"

Just coming back to read that I'm plan stupid. ✅
Will check double-twice next time.

Oh.. that happens to some of us (me 😅)
If everything is ok, could you close the issue ? :)

@althaus, feel free to re-open if you need to!


fix: delete pod panic when delete vm or statefulset.

sorry, if vm or statefulset is deleted, vm or statefulset  != nil; so need use err == isNotFound.
What type of this PR
Examples of user facing changes:

Bug fixes

已回合release-1.9 和 release-1.10 分支


python files besides notebook

Currently, the download links for python files are not working.
https://pytorch-ignite.ai/tutorials/getting-started/
Because there is no python files in this repo which is used as submodule in the website repo.
It would be great if python files are also in this repo to ease the download of python files.
cc @Priyansi @trsvchn @vfdev-5

@ydcjeff can't we automatically generate python files from ipynb ?

@ydcjeff can't we automatically generate python files from ipynb ?

I think we can, but that will make changes to the submodule.

I was thinking about on-fly generation when the download button is pressed. However, there will be a question where to store generated file etc. I think we can just remove download python files for simplicity ... What do you think ?

We need to generate beforehand to download. I will remove download python files button.


Navigation with multiple items to show, .hooper-next.is-disabled not happening when it should

Description
I'm working on the case of a vertical carousel, with 5.5 items to show but only one item to slide. The .hooper-next button should be toggled with the .is-disabled class when the last .hooper-slide is fully visible, but instead, it happens at the last .hooper-slide totally visible + 3 clicks. Could you fix this issue please?
Expected behaviour
.hooper-next.is-disabled should happen when the last slide is visible, it shouldn't be possible to continue sliding when there's no more slides to show, like a vertical scrollbar for instance.
Screenshots

Stack
I'm on desktop:

OS: macOS Big Sur version 11.2.3
Browser: Chrome version 92.0.4515.131

@mel0mani4  try to use trimWhiteSpace


Anime Studio Listing / Manga Magazine Listing

https://myanimelist.net/anime/producer
https://myanimelist.net/manga/magazine

Data

mal_id
name
count
url

Proposed Model
ProducerListItem and MagazineListItem

Jikan\Model\Common\MalUrl
count (integer)

Response
Array listing of the model above
REST API

/producers
/magazines

Conflicts
/producer and /magazine already exist. With the option to pass along the producer ID: /producer/1, to fetch producer details and anime listing. Same for /magazine/1
This is bad design. Need to use plurals at this point.
Resolution
GET /producers // fetches listing
GET /producers/1 // fetches details on the producer with the respective ID
Therefore, proposed for v4+ only - where we can use /producers only and remove /producer (or keep as backward compatibility).

Added in branch v4

Added in branch v4


TypeError (no implicit conversion to float from string) on Ubuntu

Hi all,
I've updated my gems to their latest version and updated libvips to 8.10.0. Everything works perfectly well on MacOS, however, on Ubuntu, I'm getting the following message:
TypeError (no implicit conversion to float from string):

ruby-vips (2.0.17) lib/vips/gvalue.rb:106:in `g_value_set_double'
ruby-vips (2.0.17) lib/vips/gvalue.rb:106:in `set'
ruby-vips (2.0.17) lib/vips/object.rb:258:in `set'
ruby-vips (2.0.17) lib/vips/operation.rb:249:in `set'
ruby-vips (2.0.17) lib/vips/operation.rb:384:in `block in call'
ruby-vips (2.0.17) lib/vips/operation.rb:377:in `each_index'
ruby-vips (2.0.17) lib/vips/operation.rb:377:in `call'
ruby-vips (2.0.17) lib/vips/image.rb:211:in `method_missing'
image_processing (1.11.0) lib/image_processing/processor.rb:62:in `public_send'
image_processing (1.11.0) lib/image_processing/processor.rb:62:in `apply_operation'
image_processing (1.11.0) lib/image_processing/processor.rb:39:in `apply_operation'
image_processing (1.11.0) lib/image_processing/processor.rb:19:in `block in call'
image_processing (1.11.0) lib/image_processing/processor.rb:18:in `each'
image_processing (1.11.0) lib/image_processing/processor.rb:18:in `call'
image_processing (1.11.0) lib/image_processing/pipeline.rb:50:in `call_processor'
image_processing (1.11.0) lib/image_processing/pipeline.rb:28:in `block in call'
image_processing (1.11.0) lib/image_processing/pipeline.rb:64:in `create_tempfile'
image_processing (1.11.0) lib/image_processing/pipeline.rb:27:in `call'
image_processing (1.11.0) lib/image_processing/builder.rb:13:in `call!'
image_processing (1.11.0) lib/image_processing/chainable.rb:65:in `call'
activestorage (<IP_ADDRESS>) lib/active_storage/transformers/image_processing_transformer.rb:15:in `process'
activestorage (<IP_ADDRESS>) lib/active_storage/transformers/transformer.rb:25:in `transform'
activestorage (<IP_ADDRESS>) app/models/active_storage/variation.rb:52:in `block in transform'
activesupport (<IP_ADDRESS>) lib/active_support/notifications.rb:182:in `instrument'
activestorage (<IP_ADDRESS>) app/models/active_storage/variation.rb:51:in `transform'
activestorage (<IP_ADDRESS>) app/models/active_storage/variant.rb:105:in `transform'
activestorage (<IP_ADDRESS>) app/models/active_storage/variant.rb:100:in `block in process'
activestorage (<IP_ADDRESS>) lib/active_storage/downloader.rb:15:in `block in open'
activestorage (<IP_ADDRESS>) lib/active_storage/downloader.rb:24:in `open_tempfile'
activestorage (<IP_ADDRESS>) lib/active_storage/downloader.rb:12:in `open'
activestorage (<IP_ADDRESS>) lib/active_storage/service.rb:86:in `open'
activestorage (<IP_ADDRESS>) app/models/active_storage/blob.rb:219:in `open'
activestorage (<IP_ADDRESS>) app/models/active_storage/variant.rb:99:in `process'
activestorage (<IP_ADDRESS>) app/models/active_storage/variant.rb:67:in `processed'
activestorage (<IP_ADDRESS>) app/controllers/active_storage/representations_controller.rb:12:in `show'
actionpack (<IP_ADDRESS>) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
actionpack (<IP_ADDRESS>) lib/abstract_controller/base.rb:195:in `process_action'
actionpack (<IP_ADDRESS>) lib/action_controller/metal/rendering.rb:30:in `process_action'
actionpack (<IP_ADDRESS>) lib/abstract_controller/callbacks.rb:42:in `block in process_action'
activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:135:in `run_callbacks'
actionpack (<IP_ADDRESS>) lib/abstract_controller/callbacks.rb:41:in `process_action'
actionpack (<IP_ADDRESS>) lib/action_controller/metal/rescue.rb:22:in `process_action'
actionpack (<IP_ADDRESS>) lib/action_controller/metal/instrumentation.rb:33:in `block in process_action'
activesupport (<IP_ADDRESS>) lib/active_support/notifications.rb:180:in `block in instrument'
activesupport (<IP_ADDRESS>) lib/active_support/notifications/instrumenter.rb:24:in `instrument'
activesupport (<IP_ADDRESS>) lib/active_support/notifications.rb:180:in `instrument'
actionpack (<IP_ADDRESS>) lib/action_controller/metal/instrumentation.rb:32:in `process_action'
actionpack (<IP_ADDRESS>) lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
activerecord (<IP_ADDRESS>) lib/active_record/railties/controller_runtime.rb:27:in `process_action'
actionpack (<IP_ADDRESS>) lib/abstract_controller/base.rb:136:in `process'
actionview (<IP_ADDRESS>) lib/action_view/rendering.rb:39:in `process'
actionpack (<IP_ADDRESS>) lib/action_controller/metal.rb:190:in `dispatch'
actionpack (<IP_ADDRESS>) lib/action_controller/metal.rb:254:in `dispatch'
actionpack (<IP_ADDRESS>) lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
actionpack (<IP_ADDRESS>) lib/action_dispatch/routing/route_set.rb:33:in `serve'
actionpack (<IP_ADDRESS>) lib/action_dispatch/journey/router.rb:49:in `block in serve'
actionpack (<IP_ADDRESS>) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (<IP_ADDRESS>) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (<IP_ADDRESS>) lib/action_dispatch/routing/route_set.rb:834:in `call'
http_accept_language (2.1.1) lib/http_accept_language/middleware.rb:14:in `call'
rack (2.2.2) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.2.2) lib/rack/etag.rb:27:in `call'
rack (2.2.2) lib/rack/conditional_get.rb:27:in `call'
rack (2.2.2) lib/rack/head.rb:12:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/content_security_policy.rb:18:in `call'
rack (2.2.2) lib/rack/session/abstract/id.rb:266:in `context'
rack (2.2.2) lib/rack/session/abstract/id.rb:260:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/cookies.rb:648:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:101:in `run_callbacks'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:37:in `call_app'
railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:26:in `block in call'
activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:80:in `block in tagged'
activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:28:in `tagged'
activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:80:in `tagged'
railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:26:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/request_id.rb:27:in `call'
rack (2.2.2) lib/rack/method_override.rb:24:in `call'
rack (2.2.2) lib/rack/runtime.rb:22:in `call'
activesupport (<IP_ADDRESS>) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/executor.rb:14:in `call'
rack (2.2.2) lib/rack/sendfile.rb:110:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/ssl.rb:74:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/host_authorization.rb:76:in `call'
railties (<IP_ADDRESS>) lib/rails/engine.rb:527:in `call'
/usr/lib/ruby/vendor_ruby/phusion_passenger/rack/thread_handler_extension.rb:97:in `process_request'
/usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:149:in `accept_and_process_next_request'
/usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:110:in `main_loop'
/usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler.rb:415:in `block (3 levels) in start_threads'
/usr/lib/ruby/vendor_ruby/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'

I followed all installation instructions, set the variables in .bashrc and .bash_profile as requested for libvips and ruby-vips:
.bashrc file:
export VIPSHOME=/usr/local
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$VIPSHOME/lib
export PATH=$PATH:$VIPSHOME/bin
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:$VIPSHOME/lib/pkgconfig
export MANPATH=$MANPATH:$VIPSHOME/man
export PYTHONPATH=$VIPSHOME/lib/python2.7/site-packages

.bash_profile file:
[[ -s "$HOME/.profile" ]] && source "$HOME/.profile" # Load the default .profile

[[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm" # Load RVM into a shell session *as a function*

.profile file:
[[ -s "$HOME/.profile" ]] && source "$HOME/.profile" # Load the default .profile

[[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm" # Load RVM into a shell session *as a function*
rails@ip-172-31-79-166:~$ cat .profile

# Add RVM to PATH for scripting. Make sure this is the last PATH variable change.
export PATH="$PATH:$HOME/.rvm/bin"

[[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm" # Load RVM into a shell session *as a function*

export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig:/usr/X11/lib/pkgconfig

Using Rails with RVM 1.29.10 and Ruby 2.6.5 on all my systems.
Any suggestions as to why it won't work on Ubuntu, but works on MacOS?

Hi @belangp,
image_processing (1.11.0) lib/image_processing/processor.rb:62:in `public_send'

It looks like image_processing is passing a string where ruby-vips is expecting a float. But that's all I can tell from your backtrace. We need to know what operation IP is calling and what parameters it is passing.
ruby-vips has debug logging. Try:
require 'vips'
GLib::logger.level = Logger::DEBUG

Though it's incredibly chatty. You could try enabling that and see if there's any useful output before the error.

Thanks @jcupitt , the logger output is:
D, [2020-05-31T12:11:38.977708 #2952] DEBUG -- Vips::VipsOperation.call: name = VipsForeignLoadPngFile, supplied = ["/tmp/ActiveStorage-4-20200531-2952-6rkqzw.png"], optional = {}, option_string =
D, [2020-05-31T12:11:38.977895 #2952] DEBUG -- Vips::Object.set: filename = /tmp/ActiveStorage-4-20200531-2952-6rkqzw.png
D, [2020-05-31T12:11:38.978350 #2952] DEBUG -- Vips::Object.get: out == #<Vips::Image:0x00005646f13e6398>
D, [2020-05-31T12:11:38.978389 #2952] DEBUG -- Vips::Operation.call: result = #<Vips::Image:0x00005646f13e6398>
D, [2020-05-31T12:11:38.978695 #2952] DEBUG -- Vips::VipsOperation.call: name = autorot, supplied = [#<Image 3099x1819 uchar, 4 bands, srgb>], optional = {}, option_string =
D, [2020-05-31T12:11:38.978826 #2952] DEBUG -- Vips::Object.set: in = #<Vips::Image:0x00005646f13e6398>
D, [2020-05-31T12:11:38.979128 #2952] DEBUG -- Vips::Object.get: out == #<Vips::Image:0x00005646f13e9d18>
D, [2020-05-31T12:11:38.979160 #2952] DEBUG -- Vips::Operation.call: result = #<Vips::Image:0x00005646f13e9d18>
D, [2020-05-31T12:11:38.979441 #2952] DEBUG -- Vips::VipsOperation.call: name = resize, supplied = [#<Image 3099x1819 uchar, 4 bands, srgb>, "150x150>"], optional = {}, option_string =
D, [2020-05-31T12:11:38.979581 #2952] DEBUG -- Vips::Object.set: in = #<Vips::Image:0x00005646f13e9d18>
D, [2020-05-31T12:11:38.979661 #2952] DEBUG -- Vips::Object.set: scale = 150x150>

Yes, the call to resize is wrong. It expects a single float number (the ratio), but someone is passing a string "150x150>". You'll need to track down where that's coming from.

Found it! Thanks a lot for your help and quick responses, really appreciate it!

No problem.
I'd avoid resize (in case it was your code triggering that). It's /much/ faster to use thumbnail instead (perhaps 4x faster), and quality is better too.

For others struggling with this issue, ActiveStorage switched from using MiniMagick to using image_processing.
If you used to do something like this:
image.variant(resize: "150x150>")
the new correct way is to use:
image.variant(resize_to_fill: [150, nil])
Refer to this page for details on the options available:

It was indeed in my code. Thanks for the tip @jcupitt I'll look into this for sure! :)

I think if you're using resize_to_fill you should be OK. It'll call thumbnail for you behind the scenes.
You can verify by enabling logging and looking at the sequence of calls image_processing is making.
You can also set the VIPS_TRACE env var and you'll see output like:
$ VIPS_TRACE=1 vipsthumbnail k2.jpg
vips cache+: jpegload filename="k2.jpg" out=((VipsImage*) 0x558a01c571b0) flags=((VipsForeignFlags) VIPS_FOREIGN_SEQUENTIAL) -
vips cache : jpegload filename="k2.jpg" out=((VipsImage*) 0x558a01c57340) shrink=8 flags=((VipsForeignFlags) VIPS_FOREIGN_SEQUENTIAL) access=((VipsAccess) VIPS_ACCESS_SEQUENTIAL) -
vips cache+: colourspace in=((VipsImage*) 0x558a01c57340) out=((VipsImage*) 0x558a01c574d0) space=((VipsInterpretation) VIPS_INTERPRETATION_sRGB) -
vips cache : copy in=((VipsImage*) 0x558a01c574d0) out=((VipsImage*) 0x558a01c577f0) -
vips cache : copy in=((VipsImage*) 0x558a01c577f0) out=((VipsImage*) 0x558a01c57b10) -
vips cache+: embed in=((VipsImage*) 0x558a01c57b10) out=((VipsImage*) 0x558a01c57ca0) x=0 y=5 width=181 height=269 extend=((VipsExtend) VIPS_EXTEND_COPY) -
vips cache+: linecache in=((VipsImage*) 0x558a01c57e30) out=((VipsImage*) 0x558a01d00190) tile-height=10 access=((VipsAccess) VIPS_ACCESS_SEQUENTIAL) persistent=TRUE -
vips cache+: sequential in=((VipsImage*) 0x558a01c57e30) out=((VipsImage*) 0x558a01d00000) tile-height=10 -
...

It's not quite as insanely chatty as ruby-vips logging.

I did check the image_storage documentation and that's correct. All resize_to_* will call thumbnail.


Linting Helpers pre-commit hooks, CICD Checks, and all warnings fixed

Soundtrack of this PR: Drexciya - Sighting in the Abyss
Motivation
In an effort to improve and enforce high-quality coding standards. Linting is now part of CICD. Any linting warning will cause a test failure and must be fixed before merge.
Additionally to help keep warnings to a minimum a swiftlint autocorrect pre-commit hook will run on all changed files, and then a swiftlint lint will run on those same files which will highlight any remaining linting issues. Not all warnings are auto-correctable.
In this PR

Add pre-commit config
Update .circleci to enforce strict linting rules
Update README.md with new setup instructions
Fix all outstanding swiftlint warnings

rebased onto master in a new branch https://github.com/mobilecoinofficial/MobileCoin-Swift/pull/150


Hi! Friends, can you highlight the foreground color of the arrow?

Hi! Friends, can you highlight the foreground color of the arrow?

Hi Zhou. How are you my friend? Could you explain it better? I think I can do this. I just don't plan on doing the same highlight area effect as I did for folders (file explorer - sidebar open folder area feature). My problem is lack of time.
By the way, I was thinking about making the style settings current open options with a different background color, for example, when you open a menu it will have a different background color (or something similar). This way the user can see which menus or submenus are open. But not the entire area of options.
Your suggestions are always welcome here. Please do not open and quickly close an issue. There is always room for friends and constructive criticism here. If possible, I will do my best to implement the suggestions.
All the best

Quick preview. Let me know what do you think.

All the best

I like it so much!

Please check theme version 16.0.0. I hope you enjoy.
All the best

If you have other suggestions, just open another issue.
Take care, my friend


SD_MODE pin connection to the Pinout

Hi,
I have a question on the Pin out. Where is the SD_MODE pin of the DAC routed to the Pin out, is it the BCM21(I2S) pin or is it a different pin., I need to enable this pin separately for enabling the audio in Android-things running on Raspberry pi. As shown on this stack overflow thread link.
Thanks for your support in advance.

The SD_MODE pin is not broken out. It's, effectively, tied on since it's used, with accompanying circuitry, to enable the amp when the PCM frame-sync is detected. This prevents an issue on the Pi/Raspbian where, if I remember correctly, the PCM clock would be running without frame-sync or data which is a huge no-no for this amp, and basically turned it into a tiny heater.


Set expand policy on observed concepts label

Currently, the observed concepts label (below the image view) expands to fill its contents and does not shrink. This causes some weird resizing in the UI, particularly in cases of many observed concepts in the same imaged moment. The expand policy should be changed to fix this.

Considering removing this UI element altogether; it doesn't seem to be used and adds unnecessary overhead.

Removed the observed concepts label in v0.5.0.


Update logic to account for middle names

Details
The logic in the RequestCallPage was assuming that a user's display name would only include their first and last names, and wasn't accounting for names that were longer than 2 words. This PR fixes it to take the first and last names correctly, even for names that are longer than 2 words.
Fixed Issues
N/A (see screenshot for the issue)

Tests

Set a display name for yourself that's more than just two words.
Navigate to the request call page.
Verify that the last name form is prefilled correctly.

QA Steps

Sign into<EMAIL_ADDRESS>with the password asdfASDF00.
Navigate to the chat with Concierge. Click the call button.
Verify that the first name input is auto-filled with "Name1", and the last name input is auto-filled with "Name3".

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@sketchydroide Should be good for another review, thanks!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.


"Could not determine inheritance" error when inheriting from an inner class

Operating system or device - Godot version:
X11 (master), X11 (2.0.3-stable), and X11 (2.0-stable) have been tested.
Issue description (what happened, and what was expected):
When inheriting from an inner class (according to the documentation at http://docs.godotengine.org/en/latest/reference/gdscript.html) the following error occurs:
SCRIPT ERROR: GDScript::reload: Compile Error: Could not determine inheritance
followed by:
ERROR: reload: Method/Function Failed, returning: ERR_COMPILATION_FAILED
Minimal example:
test1.gd
class Test1:
	func hello():
		print("hello")

test2.gd
extends "test1.gd".Test1

main.gd
extends MainLoop

func _init():
        print("begin")
        var test2 = load("test2.gd")
        print("end")

Running the script using the following command: godot -s main.gd causes the error. I have also tested this in the editor with the same results.

you may need to specify full path in extends, alternatively just make an example project and I will give it a check

Here's a minimal example project: https://github.com/jrimclean/godot-innerclass-test
It demonstrates loading a class with regular inheritance and then loading a class that extends an inner class.

I tested eska's fix and it solves the problem.

this was fixed recently, closing


e2e: Cleanup shared OIDC provider on SIGTERM

What this PR does / why we need it:
some OIDC providers created by the CI are not cleaned up, properly because the run was terminated abnormally.
I am assuming the reason is that the defered functions are not called when the test is terminated abnormally (for some reason). This adds the cleanup logic when  for that case when we detect a SIGTERM .
I also moved the actual creation of the provider to the end of the setupSharedOIDCProvider function, so that if we fail previously, the provider will not be created yet. Before, we could create the provider, fail at the next step and then return in main without calling the cleanup.

/approve

/cherry-pick release-4.12

/cherry-pick release-4.13


Error after Logged into Steam web

Hey, can someone tell me how i can fix this error. Thanks for incomming help.
2016-02-01T23:11:52.019Z - error: [BOTNAME] Error: This account is not authorized to use this feature.     at SteamCommunity._checkCommunityError (/root/bots/node_modules/steamcommunity/index.js:344:12)     at Request._callback (/root/bots/node_modules/steamcommunity/components/webapi.js:54:11)     at Request.self.callback (/root/bots/node_modules/request/request.js:199:22)     at emitTwo (events.js:100:13)     at Request.emit (events.js:185:7)     at Request.<anonymous> (/root/bots/node_modules/request/request.js:1036:10)     at emitOne (events.js:95:20)     at Request.emit (events.js:182:7)     at Gunzip.<anonymous> (/root/bots/node_modules/request/request.js:963:12)     at emitNone (events.js:85:20)

Someone recently had this error in #8, make sure your account meets the requirements for a non-limited user (must spend > $5 on steam).

well i allready did thats the problem

i used this account already as trade bot but only with e-mail validation on trades. i want it now on f2a.

After activating/reactivating the 2fa, you will be limited for 2 weeks. You cannot trade in that time. I think that's why you are limited.

is there really a connection between market and chat?. The point is i cant really log in and that ist strange. i mean i have access to api key and i can send chat messages and so on. I wrote also to steam support like in #8.

not correctly working until now. steam support fails as well. i will ignore that message and close this issue.


add magma testnet

Description
Add magma testnet as deploy option.
Magma docs: https://docs.magma.foundation/
Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

ENS: vrycmfy.eth

@technophile-04 @OwlWilderness for your consideration :pray:

Thanks @chair28980 !
But we are trying to keep the list small with the main ones. People can always add the chains they want in their builds 🙌


fixed CRD for migmigration to make sure step started/completed appear

Tested this and it worked for me


Change variable names

Codecov Report

Merging #46 (1d4d732) into master (1e3f0bd) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     65.21%   65.21%
  Complexity      403      403
=========================================
  Files            80       80
  Lines          1423     1423
  Branches        139      139
=========================================
  Hits            928      928
  Misses          452      452
  Partials         43       43

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/lineup/Lineup.java
0.00% <0.00%> (ø)

.../seedu/address/model/lineup/LineupPlayersList.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3f0bd...1d4d732. Read the comment docs.


Authorised countdown not displayed

https://app.zeitgeist.pm/markets/132

Should be fixed in pr #1914


chore(cspell): update .cspell-partial.json

Description
the words, quantizer, imageio and mimsave are added to autoware-spell-check-dict in folloing pull-request.
https://github.com/tier4/autoware-spell-check-dict/pull/656
https://github.com/tier4/autoware-spell-check-dict/pull/655
So, I delete these words from .cspell-partial.json
Tests performed
Check spell-check-partial is green
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

And routable is added in https://github.com/tier4/autoware-spell-check-dict/pull/654


Unit testing

Love this library, makes life so much easier.  When writing unit tests for any action that uses the extension methods I am running into an issue:
Object reference not set to an instance of an object.
at Microsoft.AspNetCore.Mvc.ControllerExtensions.GetExpresionRouteHelper(Controller controller)\n   at Microsoft.AspNetCore.Mvc.ControllerExtensions.RedirectToAction[TController](TController controller, Expression`1 action, Object routeValues)\n   at insights.headset.io.Controllers.HomeController.d__24.MoveNext() in /Users/scottvickers/dev/insights.headset.io/Controllers/HomeController.cs:line 246
Here is a simple example:
public async Task<IActionResult> RedirectTest(){
    return this.RedirectToAction<HomeController>(c=>c.Index(""));
}

[Fact]
public async Task RedirectTest(){
    var result = await controller.RedirectTest() as RedirectToActionResult;
    Assert.NotNull(result);
}

Any ideas?

@svickers You can take a look at this issue:
https://github.com/ivaylokenov/AspNet.Mvc.TypedRouting/issues/15
Let me know whether it fixes your problem. I am planning to enhance the unit testing experience when using the library.

I added the TestInit stuff but not having any luck still.  When debugging I've verified that the testinit methods are called appropriately but still null reference exception on GetExpressionRouteHelper.  Any ideas what I might be missing?

Scratch that, was missing the ControllerContext update when instantiating my controllers:
https://github.com/ivaylokenov/AspNet.Mvc.TypedRouting/blob/master/test/AspNet.Mvc.TypedRouting.Test/LinkGeneration/ControllerExtensionsTest.cs#L447


Client - Unable to create docker image for MacOS and Ubuntu20.04 using development branch

Describe the bug
While testing we noticed that we could not create a docker image for macOS running on M1 and got the error conda clean: error: argument -p/--packages: ignored explicit argument 'sy'. Crosschecked on the development branch and tested on AWS running on Ubuntu20.04 and getting the same error
macOS (M1)

AWS ubuntu 20.04

Tried to run using Windows Ubuntu18LTS terminal with docker desktop not getting the reported error

Steps To Reproduce

Install client using development branch via source
Build docker image using docker build -t coinalpha/hummingbot:dev -f Dockerfile .
Monitor the process and notice the error

Release version
development dev-1.5

That issue also showing for Windows 10 WSL

Fixed


Bug: Some videos are causing the channel to crash

Noticed when playing some videos it causes the app to crash after selection. Need to debug deeper.
debug:
LT -> Week in History -> Select second video and it crashes.

Debug:
Type Mismatch. (runtime error &h18) in pkg:/components/Slideshow/Browse/Browse.brs(201)
201:         if Strtoi(videoStore.width) >= 720 and Strtoi(videoStore.width) < 1920 then
Backtrace:
#1  Function dovideoshow(videostore As Object) As String
file/line: pkg:/components/Slideshow/Browse/Browse.brs(201)
#0  Function onitemselected() As Void
file/line: pkg:/components/Slideshow/Browse/Browse.brs(182)
Local Variables:
videostore       roAssociativeArray refcnt=2 count:5
forceres         String (VT_STR_CONST) val:""
global           Interface:ifGlobal
m                roAssociativeArray refcnt=3 count:25
thumbnailpath    roPath refcnt=1
thumbnailobj     roAssociativeArray refcnt=1 count:5
videofile        roString refcnt=2 val:"https://lh3.googleusercontent.com/lr/AFBm1_aRPgIrePAFDH8LVF_jRuEc1rPJPSKgZ-DujIK7v-DQwhDgH5FZz"...
videopath        roPath refcnt=1
videoobj         roAssociativeArray refcnt=1 count:5
regstorage       roString (2.1 was String) refcnt=1 val:"AFBm1_YWUqJtiD6U2ew9TeU4B2UXhvX0hZ418E9bmzmLlvoZeiH-ae-Y0ue2EVVbZ59uW2JbfMRoIUSypEqHG8GmsH7DsH"...
videores         String (VT_STR_CONST) val:"m18"
videocontent

This is due to the dynamic album missing the GetWidth param set which was added in the main Album.brs during last release.


Adding Readzi application to showcase.

Adding my application Readzi to the showcase.

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@strazi updated the pull request.

@strazi updated the pull request.

@strazi updated the pull request.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Unable to build on Android

Hello, I am using an expo manged project.
TheoPlayer was working fine after a bit of configuration, but since I installed youbora I have the following issue when I do
expo run:android

* What went wrong:
Could not determine the dependencies of task ':app:processDebugResources'.
> Could not resolve all task dependencies for configuration ':app:debugRuntimeClasspath'.
   > Could not find any matches for com.nicepeopleatwork:theoplayer-unified-adapter:+ as no versions of com.nicepeopleatwork:theoplayer-unified-adapter are available.
     Searched in the following locations:
       - file:/Users/michelecocuccio/Desktop/THE_WAVE/PROJECTS/LBA/lba-app/node_modules/react-native-theoplayer/android/local/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
       -<EMAIL_ADDRESS>       - file:/Users/michelecocuccio/Desktop/THE_WAVE/PROJECTS/LBA/lba-app/node_modules/react-native/android/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
       - file:/Users/michelecocuccio/Desktop/THE_WAVE/PROJECTS/LBA/lba-app/node_modules/jsc-android/dist/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
       - https://dl.google.com/dl/android/maven2/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
       - https://www.jitpack.io/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
       - https://oss.sonatype.org/content/repositories/snapshots/com/nicepeopleatwork/theoplayer-unified-adapter/maven-metadata.xml
     Required by:
         project :app > project :theoplayer_react-native-analytics-youbora
   > Could not find com.nicepeopleatwork:configutil:0.4.7.
     Searched in the following locations:
       - file:/Users/michelecocuccio/Desktop/THE_WAVE/PROJECTS/LBA/lba-app/node_modules/react-native-theoplayer/android/local/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
       -<EMAIL_ADDRESS>       - file:/Users/michelecocuccio/Desktop/THE_WAVE/PROJECTS/LBA/lba-app/node_modules/react-native/android/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
       - file:/Users/michelecocuccio/Desktop/THE_WAVE/PROJECTS/LBA/lba-app/node_modules/jsc-android/dist/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
       - https://dl.google.com/dl/android/maven2/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
       - https://repo.maven.apache.org/maven2/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
       - https://www.jitpack.io/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
       - https://oss.sonatype.org/content/repositories/snapshots/com/nicepeopleatwork/configutil/0.4.7/configutil-0.4.7.pom
     Required by:
         project :app > project :theoplayer_react-native-analytics-youbora

expo is configured to use this settings on android
     "expo-build-properties",
        {
          "android": {
            "networkSecurityConfig": "@xml/network_security_config",
            "kotlinVersion": "1.9.10",
            "compileSdkVersion": 34,
            "targetSdkVersion": 34
          },
          "ios": {
            "useFrameworks": "static"
          }
        }

package.json
    "react-native": "0.72.6",
    "@theoplayer/react-native-analytics-youbora": "^1.1.1",
    "@theoplayer/react-native-ui": "^0.3.0",
    "react-native-theoplayer": "^3.2.1",

it seems like it fails in line 96 of the build.gradle properties of the library
  implementation "com.nicepeopleatwork:theoplayer-unified-adapter:$youbora_version"
  implementation "com.nicepeopleatwork:configutil:$youbora_config_version"

Closing this ticket for now


Be resilient to corrupted cache files

If a cache file was left in a corrupted state (which causes an ArgumentError during unmarshal) then detect it, delete it, and move on as if it was uncached.

Updated to make the rescue more precise and capture only errors related to unmarshalling.

One style comment, otherwise behavior makes sense. :+1:

Removed the return's as requested!


Fix skipped test stderr change for Python 3.12.1.

Python 3.12.1 fixed an issue with the exit code unittest reported for skipped tests and also changed the string sent to stderr. Numba was using this string as part of its testing and so was susceptible to this change, this patch fixes Numba's tests.

Looks like the test_svml tests are failing, numba.tests.support probably needs adjusting similarly to the rest of the changes in this patch. Will take a look.

The new regex seems to be matching a specific text pattern that maybe be guaranteed to be stable but it's sufficient for the current 0.59 release.
Maybe, in the long run, we need to not rely on the stdout/stderr text matching.

I agree, post 0.59.0 it would be good to see if just using the exit code of the subprocess is sufficient for Numba's needs.


Swiper Slide CSS Issues With CubeEffect

Check that this is really a bug

[X] I confirm

Reproduction link
https://github.com/aagam29/swiper-core-bug-repro
Bug description
First of all thanks for this awesome library.
So I wanted this really cool cube effect for a project, I had used Vue 2.0 with my project,
Since swiper did not have support for Vue 2.0 components, I decided to go ahead with Swiper Core.
After Integrating everything, I realized there are two Issues with the Cube Effect.
BUG 1
I've set the autoplay to true, there is a glitch after each rotation that makes some icons disappear for a while, which makes it kind of unusable and buggy.
BUG 2
I have some cards which with tooltips on hover which work fine when used individually, but when used with the cube effect the hover/tooltips get weird and messy as well.
The reproduction repo  might make things much clear for you.
git clone --> yarn install --> yarn serve.
Also, bug1 was around for some time and I had moved on to cope up with it,
But then recently for some reason, I don't know how BUG 2 came up, and my feature broke which was working completely fine earlier and now I can't reproduce the working version one way or another.
Swiper Version:   6.8.1
Vue Version:       2.6.11
Vuetify Version:  2.4.0
Also, There is another CSS issue that happens when I turn on/off dark mode in my original project.
However for the time being, can you please look into the reproduction repo for bug 1,2 and do something about this?
Thanks in advance.
Expected Behavior
Internal CSS and Structure of components should be preserved.
Actual Behavior
Glitchy, Weird Icons & Hover Effect
Swiper version
6.8.1
Platform/Target and Browser Versions
Windows 10 | Chrome Version 94.0.4606.54 (Official Build) (64-bit)
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[X] I'm willing to open a PR

The bugs you described is how CSS 3D works in general. The flashing elements happens due to browser bugs, as they treat perspective differently, you can try to play with translateZ on those elements. Same with tooltip, it is due to shifted perspective.
Closing as not really a Swiper's issue

Huff, Hover just doesn't work normally on a 3D cube, I'll probably have to drop the feature.


Add filter for 'empty' column

I've been using left/right outer joins and need to identify rows where the join didn't match.
I can do this with a filter and a regex but that's a bit painful.
It would be nice to have a filter that explicitly matches a blank/empty column.
e.g.
gocsv filter --columns a,b --empty

I think the semantics of empty should evaluate to true even if the field contains spaces.

Yeah when I have to do something like that I will generally use the regular expression "^$" for an empty column. Or if you want blank columns maybe "^\s*$" or `"^\W*$" (depending on what you want).
I worry a little that not everyone agrees on what "empty" means (i.e. the only characters are whitespace? tabs? newlines?). So I'd rather have the end user specify what they mean through the regular expression.

I'll add an example to the docs, though. That is definitely a common use case!

There is always a balance between keeping to a minimum useful set of features and usability.
An example will probably be adequate but an explicit option would be nice :)
If you clearly define what 'empty' is defined as and give some regex alternatives you do get the best of both worlds.
my two cents worth :)


[bugfix #111] no activity with the prompt in extension

close #111

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Default vanilla.xml gives false info on vanilla ore generation setting.

When testing the issue with OTG and COG not generating ores. I was mislead by the following in vanilla.xml
    <OptionChoice name='vanillaOreGen' displayName='Allow Vanilla Ore Generation?' default=':= !?enableVanilla' displayState='hidden' displayGroup='vanillaHiddenAssignments'>
      <Description> Should Custom Ore Generation handle Vanilla ore generation? </Description>
      <Choice value=':= ?true' displayValue='Yes' description='Keep the vanilla oregen disabled.'/>
      <Choice value=':= ?false' displayValue='No' description='Vanilla ores will be handled by Minecraft directly.'/>
    </OptionChoice>

Since description for false says Vanilla ores will be handled by Minecraft directly I have always had it set to false, so that all ores could be generated. However I should have followed the DisplayName.
As setting it to false, disables vanilla oregen, thus also the oregeneration provided by e.g. OTG. That was the reason that with OTG 1.12.2 v6 and still wasn't seeing ores, while COG did generate ores. When switching the setting of vanillaOreGen to true. The ores from OTG appeared aswell.
So alter vanilla.xml to:
    <OptionChoice name='vanillaOreGen' displayName='Allow Vanilla Ore Generation?' default=':= !?enableVanilla' displayState='hidden' displayGroup='vanillaHiddenAssignments'>
      <Description> Should Custom Ore Generation handle Vanilla ore generation? </Description>
      <Choice value=':= ?true' displayValue='Yes' description='Vanilla ores will be handled by Minecraft directly.'/>
      <Choice value=':= ?false' displayValue='No' description='Disable the vanilla oregeneration.'/>
    </OptionChoice>

I haven't tested this with the v5 of OTG, as the issue of no COG oregen was fixed with v6 and I continued trying to find what was wrong.
Guinaro

Thanks for this. Of course, it's best to avoid configuring this internal option directly.

The trouble is that OTG forces your hand to do everything directly into scripts as you do not get to see a COG configuration menu. So I simply had to. Sorry it took so long to check this parameter.


Merging heapDebugging into master - please review 'sdkconfig.defaults' & 'nvs.csv'

@LIFsCode I believe I've merged most of the required from heapDebugging into master. When you get a chance could you please review the files below to see what you'd like to retain?

sdkconfig.defaults
nvs.csv

@OOHehir Thanks for the merge.
I'm not sure how familiar you are with the git cherry-pick feature. I guess this would be the more simple and clearer option for picking the important bugfix changes to master branch, but that's just for the future.
I added a fix for starting the AI detection that's all. The sdkconfig.defaults looks good. In the end we can discuss on which core we want to have the BT running.  Since this had no effect on the crashs we could keep it on core 0 which is under less load. But that's a story after the Release of the batch of ELOCs on thursday.
I also did a few tests today (also with extended heap poisoning) and didn't run into any crashs.
@EDsteve Could you run your tests with 6d0dd72 This is most likely the version to be released on the ELOCs.
I still have a few questions/remarks for this merge. But these are not for now, first let @EDsteve deploy the first batch of ELOCs and then we can start cleaning things up a bit:

You still delete the EI Task  which may be potentially harmfull if it is triggered via TaskNotify. Is there any reason for this? Because I guess since the system must support running recording & detection in parallel. We could also just leave the tasks created throughout the whole runtime. If the task is blocked via a xTaskNotifyWait or xQueueReceive with portMAX_DELAY  timeout the task will seldomly run and thus won't affect power consumption. Having the tasks created throughout the whole runtime also has a positive effect on heap fragmentation. Or what do you think about runtime static threads?
I must admit I don't get this commit 941e785.  As I see it this commit has 2 parts:

Changes in I2SMEMSSampler.cpp --> not notiying the AI task when it's not running --> solves problem with a deleted task (see my point 1 here) That's the actual bugfix
Changes in main.cpp: This does not make sense in my opinion. Using the intermediate variable before assigning the global should not affect execution behavior. Or if it does it is only in a random timing related behavior and thus not really stable. So in my opinion these changes could be reversed.