Cannot install project dependencies

Describe the bug
I was trying to setup the project following the Contributing section in doc, but found errors during dependency install.
To Reproduce

Clone the repo
Run rye sync --features=dev

Expected behavior
Dependencies installed without issues.
Screenshots

Desktop (please complete the following information):

OS: MacOs
Python Version: Tried 3.8, 3.9 and 3.12
Additional context
Removing rust-toolchain.toml makes the issue disappear, but causes errors during unit tests.

Ciao Graziano, thanks for opening the issue.
@abstractqqq do you think it'd be safe to move the rust-toolchain to nightly? v1.79 should be out in two days. We'd need to update the tests again.
@montanarograziano can you show what test fail? If you remove the rust-toolchain is removed, rustup should just use stable rust (1.78) which is older than the version that TQ used to write the code.

Oddly enough, I cannot reproduce the errors on the test anymore 😅 I think it was something you fixed in the last commits. Tried different python versions and all tests pass.

Last time we updated rust compiler  and package versions. So this should be solved.

Last time we updated rust compiler and package versions. So this should be solved.

I don't think that's the case: they are trying straight from master.

Rust 1.79 is out today! You can give this another shot, I guess (?):

Remove .rust-toolchain.toml
rustup update stable
Run install command

The toolchain file will switch to nightly rust I think

The toolchain file will switch to nightly rust I think

I think this might be it! I could not compile on stable release so I pushed a commit switching to nightly. Could someone try to see if it builds? Next week I will try to find the time to split functime-rs from python.

The toolchain file will switch to nightly rust I think

I think this might be it! I could not compile on stable release so I pushed a commit switching to nightly. Could someone try to see if it builds? Next week I will try to find the time to split functime-rs from python.

Just tested on 3.12 and I confirm I can build and test correctly. Thank you!


Problems with use of Math.Floor and with comparisons of inexact data.

General Bug Report
I recently experiment with making my CSharp port of JSCAD using single precision arithmetic. (This was in hopes of using some special Microsoft features that would speed things like Transformations, but only used Single precision.) This experiment failed, but it did uncover some general bugs in JSCAD. These all fall into the realm of side effects of floating point precision.
I'll start with a detailed explanation of the first issue I encountered. This was AFTER the cos/sin (with rezero) changes that were
recently made. I have removed those changes from my code base, this new way seems more robust and the rezero functions are no longer needed.
So I immediately hit three bugs in ellipse.cs... I'm showing you what it would look like in ellipse.js.
The first one (line 58) is a totally inappropriate use of Math.floor.
The problem is simple... I was getting a 4.9999... value that was getting chopped to 4.
The others are basically incorrect comparisons of a calculated value (thus inprecision) with Math.PI*2.
Thus I created the "Equalish" routines. Basically before doing a floor it checks to see if the value is "Equalish" to the ceiling,
choose Ceiling if it is, otherwise it does the floor.
Likewise lessThanish... first checks "Equalish" then if it is not Equalish it does the < comparison.
I have include my CSharp versions of these routines at the end.
Also a complete list of the changes I made in the primitives and extrusions... I'm sure I'll find more and will let you know when I do.
ellipse.js: 58
segments = Math.floor(segments * (rotation / (Math.PI * 2)))
segments = floorish(segments * (rotation / (Math.PI * 2)))
--
ellipse.js: 64
segments = (rotation < Math.PI * 2) ? segments + 1 : segments
segments = lessThanish(rotation, Math.PI * 2) ? segments + 1 : segments
--
ellipse.js: 71
if (rotation < Math.PI * 2) points.push(centerv)
if (lessThanish(rotation, Math.PI * 2)) points.push(centerv)

--- Here's the complete list of the "ish" changes' I've made so far (translated to javasscript and your current line numbers.)
--- Note, I just discovered some changes had been made to extrudeRotate since I last pulled. line might be off a few...
please let me know if I need to disambiguate!---
extrudeRotate.js: 50
if (totalRotation <= 0.0) totalRotation = (Math.PI * 2)
if (lessThanOrEqualish(totatalRotation, 0.0) totalRotation = (Math.PI * 2)
--
extrudeRotate.js: 55
segments = Math.floor(Math.abs(totalRotation) / anglePerSegment)
segments = floorish(Math.abs(totalRotation) / anglePerSegment)
--
cylinderElliptic.js: 67
const slices = Math.floor(segments * (rotation / (Math.PI * 2)))
const slices = floorish(segments * (rotation / (Math.PI * 2)))
--
cylinderElliptic.js: 120
if (rotation < (Math.PI * 2)) {
if (lessThanish(rotation < (Math.PI * 2))) {
--
ellipse.js: 58
segments = Math.floor(segments * (rotation / (Math.PI * 2)))
segments = floorish(segments * (rotation / (Math.PI * 2)))
--
ellipse.js: 64
segments = (rotation < Math.PI * 2) ? segments + 1 : segments
segments = lessThanish(rotation, Math.PI * 2) ? segments + 1 : segments
--
ellipse.js: 71
if (rotation < Math.PI * 2) points.push(centerv)
if (lessThanish(rotation, Math.PI * 2)) points.push(centerv)
--
roundedCylinder.js: 64
const qsegments = Math.floor(0.25 * segments)
const qsegments = floorish(0.25 * segments)
--
// My best guess on this one is that they had the "floorish" sort of issue and used
// Math.round to "fix" it, but that really isn't the appropriate way.
// And it could fail on edge cases.
ellipsoid.js: 41
const qsegments = Math.round(segments / 4)
const qsegments = floorish(segments / 4)

--- Below is my C# version of the routines... you shouldn't have trouble making the JS version. ---
--- The value C.EPS is 1e-5 which you generally reference as EPS everywhere. ---
    public static bool Equalish(double a, double b, double epsilon = C.EPS)
    {
        if (a == b)
        { // shortcut, also handles infinities
            return true;
        }

        var absA = Math.Abs(a);
        var absB = Math.Abs(b);
        var diff = Math.Abs(a - b);
        if (double.IsNaN(diff))
        {
            throw new ValidationException("Should never have NaN.");
        }
        return diff <= epsilon;
    }

    public static bool GreaterThanOrEqualish(double a, double b, double epsilon = C.EPS) {
        if (Equalish(a, b, epsilon)) {
            return true;
        }
        return a >= b;
    }

    public static bool GreaterThanish(double a, double b, double epsilon = C.EPS) {
        if (Equalish(a, b, epsilon)) {
            return false;
        }
        return a > b;
    }

    public static bool LessThanOrEqualish(double a, double b, double epsilon = C.EPS) {
        if (Equalish(a, b, epsilon)) {
            return true;
        }
        return a <= b;
    }

    public static bool LessThanish(double a, double b, double epsilon = C.EPS) {
        if (Equalish(a, b, epsilon)) {
            return false;
        }
        return a < b;
    }

    public static int Floorish(double a, double epsilon = C.EPS)
    {
        var a_ceil = Math.Ceiling(a);
        if (Equalish(a, a_ceil, epsilon)) {
            return (int)a_ceil;
        }
        return (int)Math.Floor(a);
    }

@briansturgill i have read this several times now in order to understand the issues.
first, the changes made by @platypii were to correct the primitive shapes, and make sure those are water-tight meshes.
second, you're trying to solve something with the changes but I'm not certain of the issues. Maybe a slightly better example would help.
third, although the 'math' might be off, there are expected results when using segments, start rotation, and end rotation. These three parameters make a pretty spicy problem, which needs to be consistent.
forth, there are utility functions to assist with the calculation of segments. Users may want to have a specific number of segments, or a specific length of segments.

I am still looking into this, so far I've only looked at the ellipse feedback, but I am not sure I agree with your issue. Maybe you could give a specific example ellipse that demonstrates the problem?
The code is different for full rotation vs less-than-full rotation. Which case do you think contains a bug? Assuming the case of a full rotation, the rotation is set on line 45:
let rotation = (Math.PI * 2)

Since the defaults have startAngle < endAngle, the rotation will be re-set on line 47:
rotation = endAngle - startAngle

Which is still exactly Math.PI * 2. Do you agree that rotation is exactly Math.PI * 2 there?
Now looking at line 58 which you propose to change.
segments = Math.floor(segments * (rotation / (Math.PI * 2)))

Since rotation === Math.PI * 2, the latter part of the formula will evaluate to (rotation / (Math.PI * 2)) === 1. Exactly one. So that implies that Math.floor(segments * 1) === segments. So I am unable to reproduce your 4.9999 bug.
I am also not sure your changes remove the need for rezero, because that is fixing a different issue than the one you are pointing out (not related to segments?).
Is it possible you are hitting a difference between single and double precision Math.PI * 2? That wouldn't be an issue in JS.
I'm sure there are bugs (I've found many :smile:) but I'd just like to understand a bit more what the issue is here.

For ellipses, it seems this is not actually a bug in JSCAD. But it is a bug when porting JSCAD to a new language that has mixed float and double precision numbers.
Relying on exact floating point arithmetic seems valid in this particular case in javascript, but we could make the code a bit more robust for porting by making the logic of "is this a full or partial rotation?" more explicit.
The code could be restructured to have a isFullRotation boolean variable. This could make the code easier to logically port to other languages. I'm not sure that "portability" would be considered an explicit goal of the project, but in this case I think it would also make the code easier to read.

OK, people keep looking at specific cases (for example at Math.PI2) and not looking at the bigger picture.
I see this happening all through the JSCAD code... simple comparisons are made on numbers that are not safely considered exact.
What first triggered this was the fact I was using Single precision, but that is only because your normal unit test started failing.
The problem isn't the single precision, but rather that comparison and Math.floor were making invalid assumptions about the exactness of incoming data.
First of all I will point out that Math.PI2 is not the same as 2pi. (pi being the irrational number). There is immediately error there by necessity. ANY code that does a simple floating point comparison to Math.PI*2 is flat out wrong.
The places where I used the "ish" routines were all places where you are checking a coordinate value. And coordinates in all computational geometry packages are not specific points. Leeway has to be allowed.
The unit tests in JSCAD may be fooling you... they are often integer values... I don't think they are catching edge cases.
Having you considered doing what used to be called "monkey" testing (after the old joke about how many typing monkey it would take to produce Shakespeare)? It's a form of random testing where you literally throw random values (that are in the allowed range) at routines and then check validity of output.
I'm not the only one seeing this problem... the guy that wrote recently about his "willow" project was saying the same thing... there's a lot of places in JSCAD where absolute checks are done when range checks should be done instead.

We understand that. The challenge is where exactly to put fuzzy checks vs exact checks. There are lots of places in the code base with epsilon checks, and there are certainly more places needed.
My point though is that I presented an argument why, in the ellipse case, I can prove that the checks are correct as-is, assuming we're in a double-only environment like javascript. This has nothing to do with the irrational number 2*Pi, just the floating point representation of Math.PI * 2. Which is why my comment focused on refactoring for clarity and robustness on other platforms, not necessarily fixing a bug. I don't agree with your categorical statement "there is immediately error there by necessity". It is possible to reason deterministically about certain floating point code.
That being said, if we can improve the code whether for correctness, portability, or readability, I am enthusiastically in favor of it. I intend to review all of the lines you've suggested in the code to see if they should be changed.

A circle has a circumference of 2pi, not Math.PI*2, so YES there is definitely error there.

A circle has a circumference of 2pi, not Math.PI*2,

@briansturgill I am a noob, could you point to a link or an explanation

A circle's circumference is 2 "pi" (the Greek letter) radians.
Pi represents an irrational number which is: 3.14159265358979323846264338327950288419716939937510582097494459230781640628620899862803482534211706...
The ... means it goes on literally forever... it has an infinite length.
Math.PI is a JavaScript floating point number that is EXACTLY: 3.141592653589793
It is finite.
Meaning any attempt to use it for the circumference of a circle will be off by:
0.00000000000000023846264338327950288419716939937510582097494459230781640628620899862803482534211706...
As JSCAD really only cares about number bigger than 1e-5 (0.000001). It is often not an issue.
However it is big enough that it can cause a normal floating point number comparison to fail...
Frequently in JSCAD you'll see Math.PI*2 being used as the boundary condition for the end of a circle.
That works, but you need to be using an "ish" comparision... i.e. see that it is within the bounds +/-1e-5 from Math.PI.

A circle has a circumference of 2pi, not Math.PI*2, so YES there is definitely error there.

Tis so with any CPU based math, float, double, integers, etc.
All calculations are inherently inaccurate. If the code can be rewritten (and it has been) to eliminate comparisons between inaccurate numbers then there's improvements.

One odd note... if the routines were written in degrees, not radians, much of the pain would be gone.

Before I used OpenSCAD then JSCAD, I used Povray and its source is C++, maybe it can give you some hints that JSCAD cannot.
Do you have an use case where Math.PI value is not precise enough ? I'm not specialist but I already use code like your *ish and I'm sure that we all do the same, use comparaisons adapted to our needs, more precisely to the granularity of our needs. What you say about Math.PI is odd, we all know what is PI and also that javascript has limitations that we must cope with, what would you propose to be able to handle PI infiniteness and won't cripple JSCAD performances ?

I'm not the only one seeing this problem... the guy that wrote recently about his "willow" project was saying the same thing... there's a lot of places in JSCAD where absolute checks are done when range checks should be done instead.

@briansturgill can you provide a reference for the "willow" project? It would be good reference for this issue.

I'm not the only one seeing this problem... the guy that wrote recently about his "willow" project was saying the same thing... there's a lot of places in JSCAD where absolute checks are done when range checks should be done instead.

@briansturgill can you provide a reference for the "willow" project? It would be good reference for this issue.

The "willow" project was pointed out to me by @hrgdavor a couple of months ago. I had assumed at the time it was from an OpenSCAD.org discussion, but I cannot find it searching for it. Perhaps @hrgdavor will remember where the reference originated. Basically the guy was tired of problems in JSCAD and was writing his own CAD... I think it was in C++ and it definitely was going to use large integer arithmetic (if you want to see an example of that, see: http://www.angusj.com/delphi/clipper.php). The use of integers instead of floating point is kind of the latest fad in CAD.
I've seen it said that CGAL uses rational arithmetic, and it of course is very slow (and surprisingly still has a fair bit of error).

Ah... I see. It's actually called Walnut. See the discussion on trying to integrate/ use as part of JSCAD.

Side note, but I don't see how switching to BigInt rationals really helps. As soon as there is any nontrivial rotation you'll end up with irrational numbers, and you'll need to approximate again anyway.
It seems like every system will approximate at some level. Maybe some operations can be made precise with rationals that floating point cannot, I'm not sure. But overall it seems like it would significantly increase complexity, hurt performance, and ultimately still have possible errors.
Especially in JS with no first class integer types, improving the stability and robustness of the floating point algorithms is the way to go.

Side note, but I don't see how switching to BigInt rationals really helps. As soon as there is any nontrivial rotation you'll end up with irrational numbers, and you'll need to approximate again anyway.
...
I agree, I don't really think it's that much of a help and it's a definite performance hit.
Note, there might be a good reason on the horizon though. I'm thinking that they may be thinking that GPU hardware could handle large ints better than floating point.
A lot of CAD research these days is more display oriented than creation of model oriented.
One problem I've had finding a good 3D booleans algorithm is that many of them are geared wrong.

BTW, I think that the move to a new 3D algorithm will require them all to be triangulated. Booleans are MUCH easier on triangles and it has the added benefit of having control over inserted point values as you can handle both sides of an intersection at the same time.

I'm closing this as there's very little to 'take home'. The issues with floating point is well known and documented all across the internet. Let's focus on discrete examples where the floating point is failing, and try to improve those calculations.


Auf timestamp (anstatt timeStamp) vereinheitlichen

The following "timeStamp" to be changed to "timestamp":
CurrentProblem:timeStamp
ObjectCreationNotification:timeStamp
ObjectDeletionNotification:timeStamp
AttributeValueChangedNotification:timeStamp

All "timeStamp" have been changed to "timestamp".


Since 0.27.1 no Release Notes

💬 Questions and Help
Since version 0.27.1 there are no "Releases" and no Release notes anymore. But the releases are available on nuget.org.
Have the release notes location changed?

The issue seems to be that the integration is not firing, e.g. here

2020-05-19T13:35:26.6507528Z ##[warning]Release will not be created as the tags for the target commit do not match with the given tag pattern


Refactoring (again) Msg and MsgRing

This is just for a preview.

I didn't much like this exact approach, see https://github.com/gholt/ring/pull/25 instead.


Update monaco to 0.24.0

fixes https://github.com/microsoft/pxt-microbit/issues/3987
I wasn't sure if I was supposed to add all the public/vs* files, but it looked like they were recently updated so I did. Only change is updating monaco-editor from 0.23.0 -> 0.24.0 in package.json
And an uploadtrg to try here!
https://makecode.microbit.org/app/b163c36f033854ba751c5d0ae4da16119ab322fa-447c9e7176

This fixes ios 13.7!  I can't test windows app...

This fixes ios 13.7! I can't test windows app...

I'll try the windows app!

Ah so it looks like this breaks all monaco click behavior on safari (besides one that richard caught, which is 'click just above line number to select whole line'. :(

^^ looks like that was https://github.com/microsoft/pxt/pull/8189 slipping into the uploaded build I tested so everything looks good to merge now~

Hm it looks like it might be hard to test windows app with local build, so since this seems to work okay for everything else I'll just merge it and test with beta. I'll close https://github.com/microsoft/pxt-microbit/issues/4091 if this fixes it


Emission at a point in world space

An important use case is the ability to ask for the emission from any given point in the scene. For example:
world.emission(point = Point(x, y, z), direction=Vector(vx, vy, vz))

Unfortunately, at the moment it is not possible to ask for the emission at a point without providing a ray as argument.
cpdef Spectrum emission_function(self, Point point, Vector direction, Spectrum spectrum,
                                 World world, Ray ray, Primitive primitive,
                                 AffineMatrix to_local, AffineMatrix to_world):

    raise NotImplementedError("Virtual method emission_function() has not been implemented.")

This sort of functionality could be trivially added if the emission model doesn't need access to the ray itself. Most of the volume emitter classes we have written so far don't require ray for their implementation.

The emission_function() isn't generally available for all materials. It is only available for the inhomogeneous volume emitter. This functionality is not as trivial to implement in a general way as stated. The requested behaviour would be considered outside the main work flow of the raytracer.

I've been thinking about this. I'm starting to agree with you that it might be best to support this sort of functionality in the users emission model, rather than as a general feature. Its a bit of a shame since it would be a very useful feature to have. But I take your point that it could potentially break the raytracers workflow. I'm going to try it in a user emission model to test the workflow. If it looks possible to include this in raysect, I'll re-open the ticket.


Value Conversion Error - Cadence

Similar issue to #19 - if the TCX file contains Cadence as a float value, e.g. '86.0' it will cause "ValueError: invalid literal for int() with base 10: '0.0'". If helpful, I've attached a truncated TCX file exported from a Peloton bike which has the issue, saved as .txt to allow Github import.
Example_Issue.txt
Code on line https://github.com/alenrajsp/tcxreader/blob/9d0f07e4cfcd5e8d4eafb9f5c2ce6eaec91d5693/tcxreader/tcxreader.py#L146 appears to cause the issue. You previously fixed a similar problem for heart rate on https://github.com/alenrajsp/tcxreader/commit/ddcd8253a13e99067ab3d77ae1b1f1614611d5bf.

Thanks for the raised issue I will change it to float.

@all-contributors
please add @rwinklerwilkes for bug reports.

@rwinklerwilkes
I have fixed the raised issue in new release 0.4.9. Cadence is now parsed like.
               try:                     tcx_point.cadence = int(float(trackpoint_data.text))
I am closing the issue for now.


Correct install for Mk3MiniExpansionPack.netkan

This will allow us to index v1.2 onward.

Passes local & jenkins, let's go get those new versions.


Can't build recent version on macOS or Ubuntu

Describe the bug
I get a couple error messages when attempting to build and run locally the ExceLint binary.

I'm using a MacBook Pro, macOS 10.15.7
Node 16.14.0
I get "node: --no-experimental-fetch is not allowed in NODE_OPTIONS" when I enter npm install
If I set NODE_OPTIONS="", npm install gives an error "Cannot read properties of null (reading 'resolve')"

To Reproduce
Steps to reproduce the behavior:

Follow the steps in the README; git clone, cd , etc.
The full terminal session is shown below

Expected behavior
I expected not to see error messages
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOS 10.15.7
Browser -none-
Version -none-

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, Safari]
Version [e.g. 22]

Additional context
√ ExceLint-addin % nvm list
       v12.18.4
        v14.8.0
       v14.17.0
       v16.13.1
->     v16.14.0
         system
default -> 14.8.0 (-> v14.8.0)
iojs -> N/A (default)
unstable -> N/A (default)
node -> stable (-> v16.14.0) (default)
stable -> 16.14 (-> v16.14.0) (default)
lts/* -> lts/gallium (-> v16.14.0)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.24.1 (-> N/A)
lts/erbium -> v12.22.10 (-> N/A)
lts/fermium -> v14.19.0 (-> N/A)
lts/gallium -> v16.14.0
√ ExceLint-addin % export NODE_OPTIONS=--no-experimental-fetch
√ ExceLint-addin % npm install
node: --no-experimental-fetch is not allowed in NODE_OPTIONS
?9 ExceLint-addin % export NODE_OPTIONS=""
√ ExceLint-addin % npm install
npm ERR! Cannot read properties of null (reading 'resolve')

npm ERR!      /Users/richb/.npm/_logs/2022-06-12T20_54_37_578Z-debug-0.log
?1 ExceLint-addin %

I had trouble on Ubuntu 22.04 as well. I'm running a fairly clean Parallels VM on my MacBook of Ubuntu 22.04. I installed git, node, and then followed the instructions on the README. npm install worked fine (but there were > 75 audit warnings). This is what i saw when I used npm run start-local:
What other troubleshooting information could I provide? Many thanks!
richb@richb-Parallels-Virtual-Platform:~/Documents/github/ExceLint-addin$ npm run start-local

><EMAIL_ADDRESS>start-local
> webpack serve --inline --host localhost --port 3000 --config config/webpack.dev-local.js --progress

  Replace Autoprefixer browsers option to Browserslist config.
  Use browserslist key in package.json or .browserslistrc file.

  Using browsers option can cause errors. Browserslist config can
  be used for Babel, Autoprefixer, postcss-normalize and other tools.

  If you really need to use option, rename it to overrideBrowserslist.

  Learn more at:
  https://github.com/browserslist/browserslist#readme
  https://twitter.com/browserslist

10% building 5/5 modules 0 activeℹ ｢wds｣: Project is running at https://localhost:3000/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /home/richb/Documents/github/ExceLint-addin/dist
ℹ ｢wds｣: 404s will fallback to /index.html
✖ ｢wdm｣: Hash: 8e2ed6884bef2f395190
Version: webpack 4.46.0
Time: 22336ms
Built at: 06/12/2022 6:16:16 PM
                                Asset      Size  Chunks               Chunk Names
          app.8e2ed6884bef2f395190.js  14.3 MiB       0  [immutable]  app
function-file.8e2ed6884bef2f395190.js   921 KiB       1  [immutable]  function-file
       vendor.8e2ed6884bef2f395190.js    10 MiB       2  [immutable]  vendor
Entrypoint vendor = vendor.8e2ed6884bef2f395190.js
Entrypoint app = app.8e2ed6884bef2f395190.js
Entrypoint function-file = function-file.8e2ed6884bef2f395190.js
[1] multi ../node_modules/webpack-dev-server/client?https://localhost:3000 ../node_modules/webpack/hot/dev-server.js react react-dom core-js office-ui-fabric-react 88 bytes {2} [built]
[2] multi ../node_modules/webpack-dev-server/client?https://localhost:3000 ../node_modules/webpack/hot/dev-server.js react-hot-loader/patch ./index.tsx 64 bytes {0} [built]
[5] multi ../node_modules/webpack-dev-server/client?https://localhost:3000 ../node_modules/webpack/hot/dev-server.js ../function-file/function-file.ts 52 bytes {1} [built]
[../function-file/function-file.ts] 1.32 KiB {1} [built]
[../node_modules/core-js/es/index.js] 8.89 KiB {2} [built]
[../node_modules/core-js/index.js] 123 bytes {2} [built]
[../node_modules/core-js/internals/path.js] 71 bytes {2} [built]
[../node_modules/core-js/proposals/index.js] 21 bytes {2} [built]
[../node_modules/office-ui-fabric-react/lib/index.js] ../node_modules/office-ui-fabric-react/lib/index.js + 625 modules 2.17 MiB {0} {2} [built]
    | ../node_modules/office-ui-fabric-react/lib/index.js 2.6 KiB [built]
    | ../node_modules/office-ui-fabric-react/lib/ActivityItem.js 89 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Autofill.js 81 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Announced.js 83 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Breadcrumb.js 85 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Button.js 77 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/ButtonGrid.js 84 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Calendar.js 81 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Callout.js 79 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Check.js 75 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Checkbox.js 81 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/ChoiceGroup.js 87 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Coachmark.js 83 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/Color.js 74 bytes [built]
    | ../node_modules/office-ui-fabric-react/lib/ColorPicker.js 87 bytes [built]
    |     + 611 hidden modules
[../node_modules/react-dom/index.js] 1.33 KiB {0} {2} [built]
[../node_modules/react-hot-loader/patch.js] 229 bytes {0} [built]
[../node_modules/react/index.js] 190 bytes {0} {2} [built]
[../node_modules/webpack-dev-server/client/index.js?https://localhost:3000] ../node_modules/webpack-dev-server/client?https://localhost:3000 4.29 KiB {0} {1} {2} [built]
[../node_modules/webpack/hot/dev-server.js] 1.59 KiB {0} {1} {2} [built]
[./index.tsx] 2.04 KiB {0} [built]
    + 766 hidden modules

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

ERROR in ./components/App.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/colorize' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/App.tsx 7:19-58
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/App.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/config' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/App.tsx 11:17-54
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/Content.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/config' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/Content.tsx 7:17-54
 @ ./components/App.tsx
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/App.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/exceljson' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/App.tsx 9:20-60
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/App.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/excelutils' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/App.tsx 8:21-62
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/Content.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/excelutils' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/Content.tsx 6:21-62
 @ ./components/App.tsx
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/App.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/option' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/App.tsx 13:17-54
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in ./components/App.tsx
Module not found: Error: Can't resolve './ExceLint-core/src/timer' in '/home/richb/Documents/github/ExceLint-addin/src/components'
 @ ./components/App.tsx 10:16-52
 @ ./index.tsx
 @ multi react-hot-loader/patch ./index.tsx

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(5,26)
      TS2307: Cannot find module './ExceLint-core/src/colorize' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(6,28)
      TS2307: Cannot find module './ExceLint-core/src/excelutils' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(7,27)
      TS2307: Cannot find module './ExceLint-core/src/exceljson' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(8,23)
      TS2307: Cannot find module './ExceLint-core/src/timer' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(9,24)
      TS2307: Cannot find module './ExceLint-core/src/config' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(10,23)
      TS2307: Cannot find module './ExceLint-core/src/ExceLintTypes' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(12,32)
      TS2307: Cannot find module './ExceLint-core/src/ExceLintTypes' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx
./components/App.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/App.tsx(13,36)
      TS2307: Cannot find module './ExceLint-core/src/option' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/Content.tsx
./components/Content.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/Content.tsx(3,28)
      TS2307: Cannot find module './ExceLint-core/src/excelutils' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/Content.tsx
./components/Content.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/Content.tsx(4,45)
      TS2307: Cannot find module './ExceLint-core/src/ExceLintTypes' or its corresponding type declarations.

ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/Content.tsx
./components/Content.tsx
[tsl] ERROR in /home/richb/Documents/github/ExceLint-addin/src/components/Content.tsx(5,24)
      TS2307: Cannot find module './ExceLint-core/src/config' or its corresponding type declarations.
Child HtmlWebpackCompiler:
                          Asset      Size  Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  7.26 KiB       0  HtmlWebpackPlugin_0
    __child-HtmlWebpackPlugin_1  7.22 KiB       1  HtmlWebpackPlugin_1
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_1 = __child-HtmlWebpackPlugin_1
    [../node_modules/html-webpack-plugin/lib/loader.js!../function-file/function-file.html] 1.14 KiB {1} [built]
    [../node_modules/html-webpack-plugin/lib/loader.js!./index.html] 1.19 KiB {0} [built]
ℹ ｢wdm｣: Failed to compile.

Hi @richb-hanover, thanks for the bug report.  I'm at a conference this week, but I'll try to reproduce this when I have a moment.

And I'm happy to provide more troubleshooting info if needed. Thanks!

Solved with #46 (Run a local copy with Docker) or #48 (use the version served by a Github Page)


Assigning colors to events ?

Hi @haydenull
I think this plugin is so great that I plan to manage my professional and personal calendars in it. But for that I would need to be able to visually distinguish the colors depending on the type of calendar. My idea would be the following: use "daily logs" to act as a diary and a calendar... it could look like this.
Imagine we are the 2022-03-08
[[daily logs]]
 - 08:30-08:45 Go to school with my daughter
 - 09:00-10:30 Meeting with my boss
 - 13:00-13:30 Call with Bob about his report
   - TODO Read Bob’s report before
     DEADLINE: <2022-03-07 Mon>
 - 15:30 Call Alice

I would like personal events to appear in green and professional events in red. What solution could we imagine?

using #green or #red tags at the end of the lines could be interpreted as a color parameter in the calendar.
use or hijack the create a new calendar function? But how ? Currently, it is rather to think to have separate calendars per project. Here I would like to do the opposite, to have different types of events or tasks in the same calendar. I already manage for example tasks with tags #pro #perso to be able to filter in normal time.

What do you say about all this?

Are you referring to the distinction between 13:00-13:30 Call with Bob about his report and TODO Read Bob’s report before?
I have add style configurations to the logKey in version 1.2.0.

At present, the color is bound to the calendar, if you want to use a different color, it is recommended to customize a new calendar.
If use different styles in the same calendar, we must also fill in the rules to let the plug-in know how to apply, and the final complexity is similar to creating a new calendar, so this feature may not be supported for the time being.

welcome to reopen issue if you still have questions


Fix GPS categories not displaying due to no args constructor error

Sorry I can't easily test, but it looks good so if it works on your device don't hesitate to release :-)
Thanks!

Sure, will do :)


Show details about LOCATION from EXTERNAL TABLES

I'm try to use only DBeaver, but always want to use EXTERNAL TABLES I have been feel upset. SSMS and Azure Data Studio are worst when compare with DBeaver, but, I have to use it, because I can't see information about data LOCATION from external tables on DBeaver.
I attached a print screen to show what I talk about.
DBeaver could show the information about external tables like SSMS, I my vision. It is the best form to show it.
A alternative option maybe show a additional  tab on table properties with this information. But, when the table was not a external table, only show "not applied for this object".
Another possibility to help the developers is create a subfolder inside the "tables" folder on left view "Database Navigator" to show only external tables for a better organization. It's a suggestion.

After some tests, I got the location with a SELECT.
That the result of this query  I want see at the  end of CREATE TABLE.
select top 1 t1.name as name_table
     , T2.name AS data_source
     , T1.location
     , t3.name as file_format
     , T1.reject_type
     , T1.reject_value
from sys.external_tables T1,
     SYS.EXTERNAL_DATA_SOURCES T2,
     sys.external_file_formats T3,
     INFORMATION_SCHEMA.COLUMNS t4
where T1.data_source_id = T2.DATA_SOURCE_ID
and t1.file_format_id = t3.file_format_id
AND upper(T1.name) = UPPER(T4.TABLE_NAME)
AND UPPER(t4.TABLE_SCHEMA) = <input_schema_name>
AND UPPER(T4.TABLE_NAME) = <input_table_name>

Thanks for the suggestion and script.

Implemented:
https://user-images.githubusercontent.com/35821147/145281208-d362742d-82b0-4f59-bbc2-9b457d9dc9ed.png

Verified


Workaround SWDEV_247082

Disabled kperblock = 8

@asroy update:
This is to workaround a compiler bug
http://ontrack-internal.amd.com/browse/SWDEV-247082
The failure was on 3.5/3.6
bin/MIOpenDriver conv -n 64 -c 16 -k 96 -H 55 -W 55 -y 1 -x 1 -u 2 -v 2 -p 0 -q 0 -g 1 -i 1 -F 2

@zjing14 What is going on with this PR?

The PR is for temporarily workaround the failure reported in SWDEV_247082. The PR is ready.

It looks good to me. Needs to push it through CI.

Let me push it once...

Restarted CI job another time. /cc @zjing14

@zjing14 Is the bug only to fp32 or fp16/bfp16 as well?

@zjing14 Merge conflicts.

@daniellowell PR https://github.com/ROCmSoftwarePlatform/MIOpen/pull/423 with the same workaround already merged. Closed this.


onOverflowCleared and onOverflowDetected are swapped

Hey! It seems the onOverflowDetected and onOverflowCleared are swapped. Currently, when the animation is running due to overflow, the onOverflowCleared is emitted. I created a PR that addresses this issue.  #345

Thank you for catching that! Fixed in https://github.com/megasanjay/vue3-marquee/pull/345


Testing Cloudflare Bindings locally

Describe the bug
Hello.
I'm facing a problem which is related to Cloudflare Bindings when using SvelteKit. The documentation on bindings is rather vague.
There is a note at the end stating:

Assuming I'm on right track, wrangler can be used to serve SvelteKit in development locally as:

wrangler pages dev -- npm run dev

It will proxy request to SvelteKit. However, to include the binding, I can use (for example KV):

wrangler pages dev --kv=TODO -- npm run dev

I states :

Your worker has access to the following bindings: KV Namespaces: - TODO: TODO

But the problem raises when I try to access platform.env when it running. It states that platform is undefined.
Reproduction
I've created a simple API endpoint.
In a fresh Sveltekit app, in src/routes add folder /kv. In it, create a +server.js with following code:
import { json } from '@sveltejs/kit';

/** @type {import('./$types').RequestHandler} */
export async function POST({ platform }) {
    console.log(platform)  // This is `undefined`.
    console.log(platform.env.KV_NAME.get("example")) // raises error.
    const { a, b } = {a: 1, b: 2}
    return json(a + b);
}

Logs
[mf:inf] POST /kv 500 Internal Server Error (501ms)
[proxy]: 1:36:49 PM [vite] page reload src/routes/kv/+server.js

[proxy]: undefined

✘ [ERROR] [proxy]: TypeError: Cannot read properties of undefined (reading 'env')

      at POST (/home/raziel/Projects/stanovi/src/routes/kv/+server.js:11:33)
      at Module.render_endpoint
  (/home/raziel/Projects/stanovi/node_modules/@sveltejs/kit/src/runtime/server/endpoint.js:49:24)
      at resolve
  (/home/raziel/Projects/stanovi/node_modules/@sveltejs/kit/src/runtime/server/respond.js:409:45)
      at async Module.respond
  (/home/raziel/Projects/stanovi/node_modules/@sveltejs/kit/src/runtime/server/respond.js:279:20)
      at async
  file:///home/raziel/Projects/stanovi/node_modules/@sveltejs/kit/src/exports/vite/dev/index.js:505:22

System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (4) x64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
    Memory: 5.08 GB / 7.70 GB
    Container: Yes
    Shell: 3.6.1 - /home/raziel/.nix-profile/bin/fish
  Binaries:
    Node: 18.16.1 - ~/.local/share/pnpm_bin/node
    Yarn: 1.22.19 - ~/.nix-profile/bin/yarn
    npm: 9.5.1 - ~/.local/share/pnpm_bin/npm
    pnpm: 8.6.5 - ~/.nix-profile/bin/pnpm
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.1.0
    @sveltejs/adapter-cloudflare: ^2.3.1 => 2.3.1
    @sveltejs/kit: ^1.20.4 => 1.22.3
    svelte: ^4.0.5 => 4.0.5
    vite: ^4.4.2 => 4.4.4

Severity
serious, but I can work around it
Additional Information
I would like to use bindings when testing locally.
Also, Cloudflare Workers has good documentation on how to test using Jest your worker. It also works with bindings. I'm not sure how to use SvelteKit with this unstable_dev API.

Hey, currently it's only possible to use bindings after building. We should probably make that a bit more clear in the docs :pray:

I've created #10390 to clarify in the docs that you can use wrangler to test your local build. For everything else I believe this may be a duplicate of #4292
There is no perfect way to mock platform.env but it's possible for some things like kv, see this example: https://github.com/ghostdevv/short/blob/2d161720df6243c5ce4d107d90272c77fe13c14e/src/hooks.server.ts#L26

@ghostdevv Thank you for explaining it. I had doubts how does it work with bindings.
So I should build sveltekit app locally likenpm run build then use wrangler to expose built app ? The bindings would be available then?

Off the top of my head you can use wrangler pages dev to test locally

@ghostdevv Actually, your solution helped. With @miniflare packages, we can mock this functionality locally and even unit test. Finally, it all makes sense now. I can use SvelteKit app to build full stack app 😸
Thank you 🚀

@ghostdevv Actually, your solution helped. With @miniflare packages, we can mock this functionality locally and even unit test. Finally, it all makes sense now. I can use SvelteKit app to build full stack app 😸
Thank you 🚀

@dinko-pehar , you are talking about Miniflare 2? DurableObjects is not possible to mock in dev mode. I've yet to seen a proper solution.

@ghostdevv Actually, your solution helped. With @miniflare packages, we can mock this functionality locally and even unit test. Finally, it all makes sense now. I can use SvelteKit app to build full stack app 😸
Thank you 🚀

@dinko-pehar , you are talking about Miniflare 2? DurableObjects is not possible to mock in dev mode. I've yet to seen a proper solution.

Hi @gerhardcit
I haven't checked all. For example, KV had a simple API like get or set. So the example above that is linked helped me understand that I can mock this simple API when in dev mode.
For R2, I saw one repository that used R2 through fetch and not through bindings.
At the end, I didn't check all bindings that Cloudflare provides. You can try to mock them when in development or try to use Miniflare packages.

wrangler pages dev .svelte-kit/cloudflare --local --d1=local_db
vite build -w
These two commands worked for me when I run both parallelly

wrangler pages dev .svelte-kit/cloudflare --local --d1=local_db vite build -w These two commands worked for me when I run both parallelly

Do you know if anything has changed with this? When vite rebuilds the app, wrangler doesn't seem to detect it and reload. I have to stop the server and start it up again.

FWIW, CF intro'd Hyperdrive which let you connect your DB (currently only Postgres), e.g. Neon, without all the comm overhead, e.g. so no TCP handshake (1x), TLS negotiation (3x), and database authentication (3x).
However and before I try to migrate my stuff, I wonder how the local dev story would be. I would need to setup a dev dv at Neon (easy), connect it through Hyperdrive (should be easy) and use that remotely via a binding through local wrangler and SvelteKit. Wondering if I should enter this rabbit-hole...

wrangler pages dev .svelte-kit/cloudflare --local --d1=local_db vite build -w These two commands worked for me when I run both parallelly

Do you know if anything has changed with this? When vite rebuilds the app, wrangler doesn't seem to detect it and reload. I have to stop the server and start it up again.

Had the same problem here. Did you find any way to asset this ? I looked in the documentation but there doesn't seem to be anything for that.

@Cikmo @manuelernestog, I've noticed that the wrangler pages dev command is responding with 304 not modified status for the html document, resulting in page being stale.


Add d3, visualize, EventNetwork.svelte

I see this, but there are no arrows in the diagram, only nodes and edges.

Yeah, it's taking some time moving from prototyping to being more integrated with the rest of the codebase

This can be a v0.2.0 feature, I think.  So we can take our time to get it right.

I think getting the nodes to display at a minimum is a manageable task. Was up to the flowbite check when I noticed hovering was lost, so I'm going back into it.

A recording of the functionality is shown here:
https://v.nostr.build/Ubo0WSzRVnXCCMbY.mp4

After fixing the changes @buttercat1791 suggested, of course. Some still seem to be open.


Adding a marketplace mode for ttk and including new tests for external URIs

This PR does 2 things :

Adds a marketplace mode for ttk. This allows us to run the tests in a mode that reduces some of the warnings to errors so that some of the cases that are not relevant for marketplace can be made optional.

@raosuhas - can you separate these into 2 PRs?  One for the new tests and one for the new mode?

@StartAutomating - can you take a look at the one for the new mode?  I think we might have a simpler way to do it?

Ok .. I am keeping this as the PR for adding the mode. Will submit a separate one for the test.

In reply to:<PHONE_NUMBER>

Let me know if there is a simpler way. Unfortunately the decision where the tests is to be made into a error or warning is only done by the Write-Error Command which is why i needed to abstract that away

In reply to:<PHONE_NUMBER>


Lading page

Design the landing page for the website
Something following https://huggingface.co/
The current design on figma: https://www.figma.com/file/QN2ZaIbj5GBLfkP5IU7knm/Eyes?node-id=0%3A1

We created one repo to work specifically on this issueL
https://github.com/FrancescoSaverioZuppichini/glasses-webapp


WIP: Remove warnings as Errors on win32 builds

This matches the Win64 options.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

@levitte On win icl builds I am running into quite a few casting issues (The next one is in TSAN related to Interlocked exchange). The 64 bit build is working fine with the warnings not as errors.

How come we're not getting those errors in Appveyor?  The /WX flag was added there to try and get something similar to --strict-warnings, albeit perhaps a bit misplaced...

How come we're not getting those errors in Appveyor? The /WX flag was added there to try and get something similar to --strict-warnings, albeit perhaps a bit misplaced...

Are you are building with an intel compiler..

So I can attempt to fix some of these..
I could also create another target in 10-main.conf for ICL32 that removes the /WX option somehow

Is this still relevant?
Marking as inactive to be closed at the end of 3.4 dev barring further input.


Project status

Is this project still safe to use?
Will it work with AWS cli v2?
It can not be installed using go install:
$ go install github.com/99designs/iamy@latest
go: finding module for package github.com/fatih/color
go: finding module for package github.com/ghodss/yaml
go: finding module for package github.com/aws/aws-sdk-go/aws/awserr
go: finding module for package github.com/aws/aws-sdk-go/service/sts
go: finding module for package github.com/aws/aws-sdk-go/aws
go: finding module for package github.com/aws/aws-sdk-go/service/iam
go: finding module for package github.com/aws/aws-sdk-go/aws/session
go: finding module for package github.com/aws/aws-sdk-go/service/iam/iamiface
go: finding module for package github.com/aws/aws-sdk-go/service/ec2
go: finding module for package github.com/aws/aws-sdk-go/service/s3/s3iface
go: finding module for package github.com/aws/aws-sdk-go/service/s3
go: finding module for package gopkg.in/alecthomas/kingpin.v2
go: finding module for package github.com/pkg/errors
go: found github.com/fatih/color in github.com/fatih/color v1.16.0
go: found gopkg.in/alecthomas/kingpin.v2 in gopkg.in/alecthomas/kingpin.v2 v2.4.0
go: found github.com/aws/aws-sdk-go/aws in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/aws/awserr in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/aws/session in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/service/ec2 in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/service/iam in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/service/iam/iamiface in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/service/s3 in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/service/s3/s3iface in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/aws/aws-sdk-go/service/sts in github.com/aws/aws-sdk-go v1.51.3
go: found github.com/ghodss/yaml in github.com/ghodss/yaml v1.0.0
go: found github.com/pkg/errors in github.com/pkg/errors v0.9.1
go: github.com/99designs/iamy imports
	gopkg.in/alecthomas/kingpin.v2<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: github.com/alecthomas/kingpin/v2
	       but was required as: gopkg.in/alecthomas/kingpin.v2

Is this fork any better? https://github.com/envato/iamy


How to use LOOP and HOLD nodes to recursively add overlapping layers to base image?

Hi! I wanted to write regarding your ComfyUI nodes for looping- I’m trying to use LOOP and HOLD to repeatedly pass an image through for additive collage on the same base layer but can’t seem to figure out how to properly implement it.
I have a base image that I want to overlay multiple images onto similar to applying small stickers over a larger image
When I pipe the batch of images into a Paste By Mask node with randomized mask locations, it creates 3 different versions of the base image with 1 sticker applied to each version—-
Instead I would like for it to create a single image with all 3 stickers stacked on top of it by looping back the output image to have the next batched sticker overlayed onto it
What would be the proper way to set up this pipeline using your looping nodes?

I totally forgot about porting my guide on matrix to here so if you join the official comfyui matrix server then you can take a look at this
https://matrix.to/#/!SLQulqwEQbBXcnBrCi:matrix.org/$MRco2WhaGqmr2weIl_Krc-3YyxwHe9Jc5uACpFiu8vo?via=matrix.org&via=tchncs.de&via=cutefunny.art

Thank you for this- I’ve tried following your matrix thread but I am still confused, can you explain to me how I can connect the nodes to make the output image pipe back and be put through the same process that assembled it?
I described a bit more in detail in my first post, but basically I am trying to push an output image back through a pipeline for overlapping images ontop of it so that it would have more and more images overlaying the base image

I totally forgot about porting my guide on matrix to here so if you join the official comfyui matrix server then you can take a look at this
https://matrix.to/#/!SLQulqwEQbBXcnBrCi:matrix.org/$MRco2WhaGqmr2weIl_Krc-3YyxwHe9Jc5uACpFiu8vo?via=matrix.org&via=tchncs.de&via=cutefunny.art

I know the workflow I’m pasting an image of wouldn’t achieve what I’m describing above (would be grateful for any advice how I can actually achieve what I describe in my previous post)
BUT
I’m having trouble even getting a basic implementation of your nodes to work- what am I doing wrong in these images?

Hm the node that connect to _event looks invalid. Can you give me the workflow so I can take a look?


Missing documentation for zephyr API to query kernel version: sys_kernel_version_get

sys_kernel_version_get() returns the kernel version of the current build.

It would be good to have this documented in website for general information to be used by product manufacturing teams.
In real products, kernel version is generally displayed as part of initial messages or crash log.
This will help in debugging crash or non-reproducible scenarios.
could not find related documentation http://docs.zephyrproject.org

Best to report this as an issue on GitHub:  https://github.com/zephyrproject-rtos/zephyr/issues/new
BTW, looks like there are no doxygen comments in include/kernel_versoin.h where this function is defined ☹
-- david
From: Praful Swarnakar<EMAIL_ADDRESS>Sent: Thursday, February 22, 2018 7:10 AM
To: zephyrproject-rtos/zephyr<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [zephyrproject-rtos/zephyr] Missing documentation for zephyr API to query kernel version: sys_kernel_version_get (#6319)
sys_kernel_version_get() returns the kernel version of the current build.
It would be good to have this documented in website for general information to be used by product manufacturing teams.
In real products, kernel version is generally displayed as part of initial messages or crash log.
This will help in debugging crash or non-reproducible scenarios.
could not find related documentation http://docs.zephyrproject.org
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/zephyrproject-rtos/zephyr/issues/6319, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKjRQpYdSG1rwLFbvOlByjfnpy_QkWi6ks5tXYNcgaJpZM4SPd7s.

Best to report this as an issue on GitHub:  https://github.com/zephyrproject-rtos/zephyr/issues/new

huh, and where is this? we are on github

Doh. Sorry about that. I misread the address thinking this was posted to the mailing list.


RC5 - Error in :0:0 caused by: Cannot set property 'paginationClickable' of undefined

Ionic version:  (check one with "x")
[ ] 1.x
[ X ] 2.x
I'm submitting a ...  (check one with "x")
[ X ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Throwing the below error:

EXCEPTION: Error in :0:0 caused by: Cannot set property 'paginationClickable' of undefined
ORIGINAL EXCEPTION: Cannot set property 'paginationClickable' of undefined

Expected behavior:
It should be working as per the documentation:

http://ionicframework.com/docs/v2/nightly/api/components/slides/Slides/#advanced

Related code:
    @ViewChild(Slides) cuisinesSlideOptions: Slides;

    ngAfterViewInit(){
      this.cuisinesSlideOptions.slidesPerView = 3;
      this.cuisinesSlideOptions.paginationClickable = true;
    }

HTML:
       <ion-slides pager #cuisinesSlideOptions>
        .....
      </ion-slides>

For the time being, I've rolled back to RC4, hoping that it'll be fixed soon.

That will be fixed in RC6. They dropped the dependency for the old slider component, so some stuff got lost in the mix, but it will be available very soon in the next version.

I think the issue is related to your  code.  Used the following example
  <ion-slides pager="true">
    <ion-slide style="background: red; color: white;">

Slide 1

    </ion-slide>
    <ion-slide style="background: white; color: blue;">

Slide 2

    </ion-slide>
    <ion-slide style="background: blue; color: white;">

Slide 3

    </ion-slide>
    <ion-slide style="background: purple; color: white;">

Slide 4

    </ion-slide>
    <ion-slide style="background: aqua; color: black;">

Slide 5

    </ion-slide>
    <ion-slide style="background: goldenrod; color: white;">

Slide 6

    </ion-slide>
  </ion-slides>

export class HomePage {
  @ViewChild(Slides) slider: Slides
  constructor(public navCtrl: NavController) {

  }
  ngAfterViewInit() {
    this.slider.slidesPerView = 3;
    this.slider.paginationClickable = true;
  }
}

And was able to set the properties correctly.


Cluster Explorer: Deployment pods are not filtered by namespace

What kind of request is this:
bug (I assume it's not a feature)
Steps to reproduce:

Create the same deployment (with the same name) in two namespaces
Ensure that Cluster Explorer is in All namespaces or Only user namespaces mode
In the Cluster Explorer sidebar go to Workload / Deployments
View the deployment in one of the namespaces

Result:
Pods from both namespaces are listed in the Pods section
Other details that may be helpful:
Only pods from the selected deployment should be visible, regardless of the global namespace filter mode.
This may be the case with other workloads, and not only with pods.
Environment information

Rancher version: 2.5.2
Installation option: single

This was previously fixed and will ship in 2.5.4


nomad: update 1.6 and 1.8, build with go 1.22 for 1.8 and 1.6, deprecate 1.5

Description of changes
This is a bit of a cleanup in a single PR, see individual commits for each of the changes.
In short:

Nomad 1.7+ be built with Go 1.22, as in upstream

I did this in a different PR but it did not get merged. Therefore this closes #316635

Update nomad_1_8 to 1.8.2
Update nomad_1_6 to 1.6.10
Deprecate nomad_1_5, as it has reached EOL.

added release note accordingly

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

tagging @techknowlogick and @rushmorem as maintainers 🙏


feat/add integration test for ADDRESS opcode

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: Fix #252 and fix #276
What is the new behavior?

Add integration test for ADDRESS opcode

Add sol for IntegrationTestContract
Create pytest mark

Modify build-sol to compile all .sol files

Other information

resolve conflicts and good-to-go:)
as @ClementWalter said, it's a bit annoying to have conflicts on coverage files, we'll prioritise fixing that


flyEasy-Reservations Kanban Board

Hello Code Reviewer,
For our final capstone project we are five(5) in our group. Below are the project info:

Kanban Board

Team Members:

@MargaretTechworld
@zbahati
@JoyTaribagshaw
@GhostEsso
@BranBayou

Screenshot to the description

Wow, you did it 🎉

Your project is complete!  :shipit:
Congratulations! 🎉
To highlight

All cards have descriptions, assignees, and pointings according to spec✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:

All tasks have descriptions✔

Required Changes ♻

[ ] At the time of this review, the pointings are as follows:

@geekelo 14
@fatima-najafi 13
@fatima-najafi 11
@Nasirkhan294 9
@yemidada 4
According to the project requirements:

Kindly, make sure the pointings are more equal. The rule is that nobody should have more than 5 points than any other member in the team. 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


SES KMS S3 bucket decryption

(leveraging feature request from js lib)
Recently AWS SES started accepting inbound email, saved in an S3 bucket. There's an option to encrypt the data, which is great, otherwise everything is exposed as plain text in your bucket.
The problems start with only accepting a KMS key for encryption. That means it needs to be managed from the AWS side.
The official documentation says on the subject:
Your mail is encrypted by Amazon SES using the Amazon S3 encryption client before the mail is submitted to Amazon S3 for storage. It is not encrypted using Amazon S3 server-side encryption. This means that you must use the Amazon S3 encryption client to decrypt the email after retrieving it from Amazon S3, as the service has no access to use your AWS KMS keys for decryption. This encryption client is available with the AWS Java SDK and AWS Java Ruby only.
http://docs.aws.amazon.com/ses/latest/DeveloperGuide/receiving-email-action-s3.html
How can we bring that functionality to the .net lib, so we can decrypt and read our messages using c#?
Thanks!!

At the moment, this is not supported. This request has been added to our feature request list for tracking. Closing the issue.
https://github.com/aws/aws-sdk-net/blob/master/FEATURE_REQUESTS.md


Search does not suggest homebrew-cask formulae when untapped

brew config output
HOMEBREW_VERSION: 3.3.7
ORIGIN: https://github.com/Homebrew/brew
HEAD: dbec9de77ebc65a4845a5e672950219aa19b35b8
Last commit: 7 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 9cec8a98224cf1cdfd1f21567306e83a86e096fb
Core tap last commit: 17 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_CORE_GIT_REMOTE: https://github.com/Homebrew/homebrew-core
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 2.6.8 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 13.0.0 build 1300
Git: 2.30.1 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.77.0 => /usr/bin/curl
macOS: 12.0.1-arm64
CLT: <IP_ADDRESS>.1.1633545042
Xcode: N/A
Rosetta 2: false

brew doctor output
Your system is ready to brew.

Verification

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
On a fresh install, I was searching for the name of the iterm2 formula, so I ran brew search iterm2.
What happened (include all command output)?
dnw@192 ~ % brew search iterm2
==> Formulae
term

==> Casks
homebrew/cask-versions/iterm2-beta                                     homebrew/cask-versions/iterm2-legacy                                   homebrew/cask-versions/iterm2-nightly

What did you expect to happen?
I expected to see the regular iterm2 formula, but it wasn't in the output.
Seeing the naming convention I gave brew install iterm2 a try, which forced the tap of homebrew-cask, where the iterm2 formula is:
dnw@192 ~ % brew install iterm2
==> Homebrew is run entirely by unpaid volunteers. Please consider donating:
  https://github.com/Homebrew/brew#donations
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> New Formulae
brigade-cli
Running `brew update --preinstall`...

==> Tapping homebrew/cask
Cloning into '/opt/homebrew/Library/Taps/homebrew/homebrew-cask'...
remote: Enumerating objects: 609514, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 609514 (delta 10), reused 19 (delta 7), pack-reused 609490
Receiving objects: 100% (609514/609514), 274.36 MiB | 6.91 MiB/s, done.
Resolving deltas: 100% (430989/430989), done.
Tapped 3938 casks (4,018 files, 293.9MB).
==> Downloading https://iterm2.com/downloads/stable/iTerm2-3_4_14.zip
######################################################################## 100.0%
==> Installing Cask iterm2
==> Moving App 'iTerm.app' to '/Applications/iTerm.app'
🍺  iterm2 was successfully installed!

Looking at brew tap I see that cask-versions isn't tapped, so I don't see why the cask-versions formulae are suggested but not the regular cask formulae.  Is it because "iterm2" is the whole name?
Step-by-step reproduction instructions (by running brew commands)
Looks like I can reproduce it by reverting some effects:

dnw@192 ~ % brew uninstall iterm2
b==> Uninstalling Cask iterm2
==> Backing App 'iTerm.app' up to '/opt/homebrew/Caskroom/iterm2/3.4.14/iTerm.app'
r==> Removing App '/Applications/iTerm.app'
==> Purging files for version 3.4.14 of Cask iterm2
dnw@192 ~ % brew untap homebrew/cask
Untapping homebrew/cask...
Untapped 3938 casks (4,019 files, 293.9MB).
dnw@192 ~ % brew search iterm2
==> Formulae
term

==> Casks
homebrew/cask-versions/iterm2-beta                                     homebrew/cask-versions/iterm2-legacy                                   homebrew/cask-versions/iterm2-nightly

(I assume it's expected that I have to manually tap homebrew/cask the second time to be able to reinstall iterm2.)

I cannot reproduce this:
$ brew search iterm2
==> Formulae
term

==> Casks
iterm2-beta               iterm2-legacy             iterm2-nightly            iterm2

Leaving this open for a bit to see if any other maintainers can.

Is that without the cask repo tapped?

I have the cask repo tapped. I missed that this can only be reproduced with it untapped. How did it end up untapped in your case?

It was a fresh install.

Gotcha. Yeh, we should probably either:

Gotcha. Yeh, we should probably either:

adjust the search logic to search homebrew-cask correctly
or:
tap homebrew/cask by default on macOS in the installer (and/or consider doing so in search, too)

Homebrew/cask and Homebrew/core code search is non-functional. This is a GitHub issue and has been a problem for a while.
The only real fix from our side would be to rewrite this to use our own JSON API instead.

Oh, so iterm2 isn't found in untapped Homebrew/cask because there are too many casks before the threshold cutoff, while casks-versions is small enough that it finds iterm2-beta, etc?

I'm not 100% sure of the technical reason but repo size is probably a contributing factor.
Try code search the repo: https://github.com/Homebrew/homebrew-cask/search?q=cask. No matter the input, it doesn't work at all and brew search uses this exact search system when the repo is untapped.

The only real fix from our side would be to rewrite this to use our own JSON API instead.

Well, auto-tapping homebrew-cask would be another option.

Try code search the repo: https://github.com/Homebrew/homebrew-cask/search?q=cask. No matter the input, it doesn't work at all and brew search uses this exact search system when the repo is untapped.

https://cs.github.com/Homebrew/homebrew-cask?q=cask works so it may be that this gets addressed in future. I don't think we should rely on that to happen soon, though.

https://cs.github.com/Homebrew/homebrew-cask?q=cask works so it may be that this gets addressed in future.

I did not know that existed - that's useful to know. I'll sign up for that since code search not working in general has been a bit annoying at times.

Another option is we use something like the tree API instead: https://docs.github.com/en/rest/reference/git#get-a-tree
https://api.github.com/repos/homebrew/homebrew-cask/git/trees/master?recursive=1
or the repo contents API:
https://docs.github.com/en/rest/reference/repos#get-repository-content
https://api.github.com/repos/homebrew/homebrew-cask/contents/Casks

Another option is we use something like the tree API instead: https://docs.github.com/en/rest/reference/git#get-a-tree https://api.github.com/repos/homebrew/homebrew-cask/git/trees/master?recursive=1
or the repo contents API: https://docs.github.com/en/rest/reference/repos#get-repository-content https://api.github.com/repos/homebrew/homebrew-cask/contents/Casks

Since we only search filenames anyway, this makes sense to me (although my guess is that its not faster, I'd rather get code searching to work on Homebrew/cask).

The only real fix from our side would be to rewrite this to use our own JSON API instead.

I believe your suggestion in #12350 will make this work (maybe not as-is but pretty effortlessly). If not, we should definitely make searching work with HOMEBREW_INSTALL_FROM_API (although that doesn't solve this problem in general)

Since we only search filenames anyway, this makes sense to me (although my guess is that its not faster, I'd rather get code searching to work on Homebrew/cask).

It'll be faster until the code search APIs are ported over to the beta code search. This is likely to be a little while and even then I'm not convinced they will be faster.

I believe your suggestion in #12350 will make this work (maybe not as-is but pretty effortlessly). If not, we should definitely make searching work with HOMEBREW_INSTALL_FROM_API (although that doesn't solve this problem in general)

👍🏻

Since Algolia is already providing search best-in-class search results on https://formulae.brew.sh, why not simply use that instead?
QUERY=swiss-army COUNT=5 \
      curl 'https://bh4d9od16a-dsn.algolia.net/1/indexes/*/queries?x-algolia-application-id=BH4D9OD16A&x-algolia-api-key=a57ef92bf2adfae863a201ee43d6b5a1' \
      -d '{"requests":[{"indexName":"brew_all","params":"query='$QUERY'&hitsPerPage='$COUNT'&facetFilters=%5B%22site%3A%20formulae%22%5D"}]}' |
      jq '.results[0].hits[].hierarchy | { type: .lvl0, name: .lvl1 }'

{
  "type": "Formulae",
  "name": "pandoc"
}
{
  "type": "Formulae",
  "name": "mailutils"
}
{
  "type": "Formulae",
  "name": "m-cli"
}
{
  "type": "Formulae",
  "name": "aptly"
}
{
  "type": "Formulae",
  "name": "bnd"
}

Tapping the casks repo on install (this is ideal because you can see casks even if you aren't specifically requesting them)
Tapping the casks repo the first time you try doing anything related to casks (e.g. brew search --cask)

Either of these make sense to me 👍🏻

Since Algolia DocSearch is already providing best-in-class search results on https://formulae.brew.sh/, why not simply use that instead?

This actually makes sense since it would be a single network operation for all official taps, like what we were doing before for code search. Doesn't include cask-versions at the moment however.

Doesn't include cask-versions at the moment however.

Probably because cask-versions isn't in the cask list, so DocSearch won't crawl them.

Good catch @kidonng.
IMO this is another reason we should think about consolidating all the Homebrew/homebrew-cask-* taps into Homebrew/homebrew-cask CC @Homebrew/cask.

Even if we end up not consolidating repos, it wouldn't be a big task to add to formulae.brew.sh - we would just need to decide how that works in terms of API endpoints.

consolidating all the Homebrew/homebrew-cask-* taps

There’s four: main, versions, drivers, and fonts. I’d say it makes sense for fonts to remain separate. Versions and drivers could be merged into main, but drivers would need a cleanup beforehand. My suggestion would be to take the most popular ones and move them to main, dumping the rest. The reason that’s a separate repo is that otherwise the main one would be filled with highly-specific drivers.

Versions and drivers could be merged into main, but drivers would need a cleanup beforehand. My suggestion would be to take the most popular ones and move them to main, dumping the rest. The reason that’s a separate repo is that otherwise the main one would be filled with highly-specific drivers.

Sounds good, let's do it.

I’d say it makes sense for fonts to remain separate.

@vitorgalvao Can you elaborate on why? Relatedly, do you think it would matter if these e.g. didn't show up in search by default?

I’d say it makes sense for fonts to remain separate.

@vitorgalvao Can you elaborate on why?

Probably because there are about 2000 font casks out there, mostly pulled from Google Fonts automatically. It would operate better standalone. This is just my observation, I can't speak for anyone.

Probably because there are about 2000 font casks out there, mostly pulled from Google Fonts automatically. It would operate better standalone.

Pretty much. The repo has specific requirements (SVN) and its own rules which make sense for its own niche goal of fonts but not apps (other casks).

Relatedly, do you think it would matter if these e.g. didn't show up in search by default?

It wouldn’t matter as much from the user’s perspective, no. But from the contributing side, it becomes harder to manage when a third of the repo (main has about 4000 casks) are casks you’re not supposed to touch. It’s clutter.
Most people don’t care about the vast majority of font casks. But a fonts resource which only has a handful of popular ones isn’t very useful either. The fonts repo is a dump. But because it’s automated and contained, it’s a useful dump. I ultimately feel that throwing all that on the main repo would make both situations worse.

The repo has specific requirements (SVN)

There's a PR open to make this go away sooner rather than later 😄

But from the contributing side, it becomes harder to manage when a third of the repo (main has about 4000 casks) are casks you’re not supposed to touch. It’s clutter.
But because it’s automated and contained, it’s a useful dump. I ultimately feel that throwing all that on the main repo would make both situations worse.

Fair 👍🏻

To fix this, I immediately brew tap homebrew/cask after a fresh Homebrew install.

https://github.com/Homebrew/brew/pull/14407 should address this.


[copy_artifacts] Fix documentation

While working with copy_artifacts I encountered a few docs problems with it. This PR fixes these:

Fix wrong keep_original description - default is true, so by default the files are copied, not moved.
Add example_code showing paths
Add default functionality (copy) to description

          1 Warning

:warning:
Pull Request is Work in Progress

  Generated by :no_entry_sign: Danger

Tests failing because of Circle/Heroku problems:

We had an unexpected error preparing a VM for this build, potentially due to our infrastructure or cloud provider.  Please retry the build in a few minutes

Fixed, tests ok.


Generating mocks (reflect mode) fails if interface contains methods with generic types

Actual behavior A clear and concise description of what the bug is.
Same issue from github.com/golang/mock https://github.com/golang/mock/issues/677.
Interface:
package mypkg

type S struct{}

type GS[T any] struct {
	T T
}

type I interface {
	M() GS[*S]
}

Mock package:
package mypkgmock

//go:generate go run go.uber.org/mock/mockgen -destination=mock.go -package=$GOPACKAGE github.com/yz89122/gomock-test/mypkg I

Command:
go generate ./...

2024/04/24 06:33:24 Failed to format generated source code: mock.go:42:39: missing ',' in type argument list (and 1 more errors)
// Code generated by MockGen. DO NOT EDIT.
// Source: github.com/yz89122/gomock-test/mypkg (interfaces: I)
//
// Generated by this command:
//
//      mockgen -destination=mock.go -package=mypkgmock github.com/yz89122/gomock-test/mypkg I
//

// Package mypkgmock is a generated GoMock package.
package mypkgmock

import (
        mypkg "github.com/yz89122/gomock-test/mypkg"
        gomock "go.uber.org/mock/gomock"
        reflect "reflect"
)

// MockI is a mock of I interface.
type MockI struct {
        ctrl     *gomock.Controller
        recorder *MockIMockRecorder
}

// MockIMockRecorder is the mock recorder for MockI.
type MockIMockRecorder struct {
        mock *MockI
}

// NewMockI creates a new mock instance.
func NewMockI(ctrl *gomock.Controller) *MockI {
        mock := &MockI{ctrl: ctrl}
        mock.recorder = &MockIMockRecorder{mock}
        return mock
}

// EXPECT returns an object that allows the caller to indicate expected use.
func (m *MockI) EXPECT() *MockIMockRecorder {
        return m.recorder
}

// M mocks base method.
func (m *MockI) M() mypkg.GS[*github.com/yz89122/gomock-test/mypkg.S] {
        m.ctrl.T.Helper()
        ret := m.ctrl.Call(m, "M")
        ret0, _ := ret[0].(mypkg.GS[*github.com/yz89122/gomock-test/mypkg.S])
        return ret0
}

// M indicates an expected call of M.
func (mr *MockIMockRecorder) M() *gomock.Call {
        mr.mock.ctrl.T.Helper()
        return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "M", reflect.TypeOf((*MockI)(nil).M))
}
exit status 1

Expected behavior A clear and concise description of what you expected to
happen.
No error.
To Reproduce Steps to reproduce the behavior

Run go generate ./... for above code.

Additional Information

gomock mode (reflect or source): reflect
gomock version or git ref: v0.4.0
golang version: 1.22.2

Triage Notes for the Maintainers

Okay, I find it annoying and it blocks me.
Can I take care of this one? 😄

@cebilon123 You can submit a PR if you have a fix. We welcome any contribution.

Any progress? If I understand correctly, there is some issue with reflect package itself.
But there should be new API in Go 1.22 based on this comment https://github.com/uber-go/mock/issues/197#issuecomment-2270138135
Can that help fix this issue too?


Remove node_modules

The node_modules folder should not be checked into version control. I have removed it and made changes to the action/CI to accommodate for this, which are modelled after GitHub's template for JavaScript actions.
Specifically:

package.json now contains a command (npm run package) for compiling the action to a single file, which gets stored as dist/index.js. This file should be added to the repository and updated when there are changes.
A new CI workflow, named check, will check that dist/index.js is up-to-date.
action.yml is updated to point to dist/index.js instead of src/main.js.
The test workflow is unchanged.

Thanks for taking a look at the repo.

The node_modules folder should not be checked into version control.

In my defense, this was the default way of doing things when I created this repository. And, the good news is that the repo worked even though I haven't touched it in over a year. Just to check, the package-lock.json is used to reproduce the versions?

Just to check, the package-lock.json is used to reproduce the versions?

Yep, at least that's npm's intention. Thanks for the very quick response!

Can you remove the - mbg/improvements from test.yml? It could be a bit confusing to future readers. If you want to run CI on your fork, my tip is to create a PR inside the fork from the changed branch to main/master. Then, CI will run there. Once everything looks good, close the PR inside the fork and create a fork to the main repo.
Finally, could you please explain a bit more about the check? It's probably good, but I don't understand yet what it does :)

Can you remove the - mbg/improvements from test.yml?

Oops, my mistake, I thought I had removed that already. It's gone now!

Finally, could you please explain a bit more about the check? It's probably good, but I don't understand yet what it does :)

The check is more or less identical to the one for the JavaScript template. It installs Node+npm, then uses npm ci to install the dependencies according to package-lock.json, and then rebuilds the contents of the dist/ folder using npm run package. The "Compare the expected and actual dist/ directories" step uses git diff to check whether running npm run package has produced different files to the ones that are already in the repository. If not, it means that the contents of dist/ are up-to-date and the workflow succeeds. If they are different, the last step runs which uploads the contents of dist/ as a build artifact and the workflow fails.

Looks good. I gave you access to this repo so you can merge when you're happy

Thanks, although that wasn't necessary!

We can by the way probably simplify this project a lot because there is now a composite feature for GitHub Actions.

True. I think the main value of this action is in the core.sh script. You could probably move that into a composite action, preceded by actions/cache.

True. I think the main value of this action is in the core.sh script. You could probably move that into a composite action, preceded by actions/cache.

Implemented now with:

#13
#14
#15


Issue with name decoration on Linux

Narrowed it down to: https://github.com/webpack-contrib/webpack-log/blob/9e215a07efa0a0a069b27c30291652241c0f4c82/index.js#L24
The square-thingy that's being used there appears like this when using webpack-serve:

Perhaps a different symbol (or none at all) is better for cross platform?

Uh-oh! But I didn't remove it! I simply clicked the line -> three dots -> Open new issue

Opened it correctly over at https://github.com/webpack-contrib/webpack-log/issues/3 :+1:

Hm. Perhaps we've encountered a rare Github bug? In any case, thanks for opening a new one. I have a service running that snipes issues without templates automagically.

Could be! Anyway - I understand that very well, impossible to handle OSS of such scale as this without :+1:


Add PageMargin to ViewPager in SessionsFragment

Issue

This PR has no issue 🙇

Overview (Required)

This is just suggestion.  🙌
Add page margin 16dp to ViewPager in SessionFragment.
I think each cards should be splitted, but there are sticking to cards in next page.

Details

This margin can be seen when only scrolling.
set Viewpager.pageMargin is not enough, and to achieve this correctly, we have to add android:clipChildren="false" to parents of CardView. (To show left and right shadow of CardView.)

Links

No links.

Screenshot

Before
After

:cool:

I learned a lot 👍 Thanks!


Support a generic POJO convertor to a BulletRecord

This will help us write connectors to read from various datasources and support converting those objects into an implementation of the BulletRecord.
Support Map, Avro, Reflection?

Can I do this on the side?


Nuxt adapter

Moves build, codegenPublicDirectory and codegenFunctionsDirectory logic to adapter
This is the companion PR for https://github.com/firebase/firebase-tools/pull/7297

Where are we at with this update? Really excited for native Nuxt support.


Deploy to AMO

[x] Initial submit to AMO
@sindresorhus do you want to submit it yourself? Otherwise I'll do it. Either way you're going to have to create an account on https://addons.mozilla.org/en-US/developers/
[ ] Set up auto-deployment using web-ext
https://github.com/sindresorhus/refined-github/pull/403#issuecomment-302838065
[ ] Fix review warnings:Unsafe assignment to innerHTML linkify-urls-in-code.js 26:5Warning: Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.
Unsafe assignment to innerHTML linkify-urls-in-code.js 36:5Warning: Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.
"storage.local" can cause issues when loaded temporarily content.js 60:3Warning: This API can cause issues when loaded temporarily using about:debugging in Firefox unless you specify applications > gecko > id in the manifest. Please see: https://mzl.la/2hizK4a for more.
"storage.local" can cause issues when loaded temporarily content.js 62:3Warning: This API can cause issues when loaded temporarily using about:debugging in Firefox unless you specify applications > gecko > id in the manifest. Please see: https://mzl.la/2hizK4a for more.
Unsafe assignment to innerHTML content.js 284:3Warning: Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.
"storage.local" can cause issues when loaded temporarily show-names.js 5:3Warning: This API can cause issues when loaded temporarily using about:debugging in Firefox unless you specify applications > gecko > id in the manifest. Please see: https://mzl.la/2hizK4a for more.
"storage.local" can cause issues when loaded temporarily show-names.js 9:3Warning: This API can cause issues when loaded temporarily using about:debugging in Firefox unless you specify applications > gecko > id in the manifest. Please see: https://mzl.la/2hizK4a for more.

@jgierer12 I've submitted it for review and added you as owner on AMO.
@hkdobrev @paulmolluzzo Register on https://addons.mozilla.org/en-US/developers/ and let me know and I'll add you as owners too.

@sindresorhus Here you go: https://addons.mozilla.org/en-US/firefox/user/paulmolluzzo/

I can set up the amo autodeployment if you want

Wow, that was fast!

@sindresorhus https://addons.mozilla.org/en-US/firefox/user/hkdobrev/ Thanks!

Why does the URL contain a dash at the end?
https://addons.mozilla.org/en-US/firefox/addon/refined-github-/
https://addons.mozilla.org/en-US/firefox/addon/refined-github/ ⬅ doesn't work

@bfred-it I had to add a dash as the AMO UI insisted the one without a dash was already taken.

Can you give me access to AMO? I can try contacting them

@hkdobrev @bfred-it I need the email you used to sign up for the AMO account.

<EMAIL_ADDRESS>

Added

Still missing: #470 (auto-deployment) and #467 (unsafe innerHTML)

I think we're good for now.


[WIP] Refactor NativeXR for performance

This refactor gives an 8% improvement in frame time on HoloLens when visualizing scene understanding meshes, and significantly decreases (90%) xrFrame.getPose CPU time. In a performance test with 200 anchors, time spent per frame was reduced 70%.

Set properties directly on native-backed javascript objects as instance values rather than instance accessors to make for fast reading on the javascript side.
Rewrite part of the XRFrame::getPoses function in javascript and use memcpy to avoid multiple expensive Set calls over-the-wire (see the babylon.js part of this PR (https://github.com/BabylonJS/Babylon.js/pull/11276) for more details).
Return spaces instead of reference spaces for planes and anchors.
Move the Space struct from xr::System::Session::Frame::Space to xr::Space so that (1) we can attach a space to an anchor to be consistent with the OpenXR and WebXR specs and (2) remove the implication that a space is a frame-bound construct.

Still want to do some more profiling & cleaning up, some other small to-do's:

[x] Profile anchor tracking performance
[x] Fix mobile compile errors
[ ] Test & profile on mobile

Closing as I've been splitting this into smaller PR's.


App redirection broken when mounted on a subdirectory

Hi,
The PR #594 breaks redirection to /path/to/kue/active when the kue app is mounted on /path/to/kue.
Users are redirected to /path/to/kueactive.
Hopefully it's very easy to fix.
My PR is coming.

+1

merged


jekyll: 3.0.1 -> 3.4.1

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Ah, I guess this is broken:
$ nix-shell -p jekyll --command "jekyll new test"
Running bundle install in /private/tmp/test...
  Bundler: There was an error while trying to write to
  Bundler: `/nix/store/l67429rhvrmr7c4c1msb7s8zjq4fx7ad-gemfile-and-lockfile/.bundle/config`.
  Bundler: It is likely that you need to grant write permissions for that path.

Basic functionality works in my tests now. There is still a problem with building sites that depend on additional plugins (e.g. #20617), but it is there already and this PR has nothing to do with it.

LGTM – I don't immediately see a better way to handle the bundler issue. The fact that jekyll new now generates its own Gemfile makes things a little complicated for NixOS – but at least with this solution the basic tutorials for building a new site with default plugins will work. Maybe one day, commonly-used plugins could be optional arguments to the nix expression…?

@veprbl Now that I see how one patches up the installed Ruby code, this small addition to gem-config would also address #22858… but either way, I'll see how far I get upstream.
  # disable bundle install as it can't install anything in addition to what is
  # specified in pkgs/applications/misc/jekyll/Gemfile anyway. Also do chmod_R
  # to compensate for read-only files in site_template in nix store.
  jekyll = attrs: {
    postInstall = ''
      installPath=$(cat $out/nix-support/gem-meta/install-path)
      sed -i $installPath/lib/jekyll/commands/new.rb \
          -e 's@Exec.run("bundle", "install"@Exec.run("true"@' \
          -e<EMAIL_ADDRESS>site_template + "/."<EMAIL_ADDRESS>site_template + "/.", path; FileUtils.chmod_R "u+w", path@'
    '';
  };

@league cp_r has :preserve argument. Can't find docs for it though.

Seems to not be able to do what we want. The problem seems to be standard: how to get files at 644 and directories at 755. I don't know if this can be done beautifully enough to upstream.

@veprbl Right. I also read (not under cp_r doc, but for copy_entry) that "If preserve is true, this method preserves owner, group, and modified time. Permissions are copied regardless preserve." https://ruby-doc.org/stdlib-2.2.2/libdoc/fileutils/rdoc/FileUtils.html

This call for a ruby wizard :)

this is good to be merged btw


broken formatting in the README file

tables in the README file are broken in the following
Examples
||| |---|---| | pythagorean| example of scopes| | Evals| different evals | | Debugger Statements|| | exceptions| different caught / uncaught exceptions| | large objects| large arrays / objects | | objects| objects | | promises|| | iframe|pausing in an iframe| | large-files|| | localStorage Keys|| | Optimized Away Variable|| | typescript - greeter|| | coffeescript - tutorial|| | Create React App - (jsx, flow)|| | asm.js||
Source Maps
||| |---|---| | increment| a simple source map example| | source mapped js.min files| simple webpack example|
Local Test Pages
||| |---|---| |asm|| |debugger-statements|| |exceptions|| |frames|| |iframes|| |minified|| |return-values|special scope variables | |script-switching|| |scripts|| |sources|| |sourcemap-bogus|| |sourcemaps|| |sourcemaps2||

I have fixed the issue and have submitted a pull request for the same.


Version conflicts when trying to run another project that is pre Flutter 2

For a client I am trying to run a project that uses Flutter SDK 1.22.5 and Dart SDK 2.7 - my locally installed SDK is 2.0.2 and it crashes in any possible way (f.e material_localizations that are null-safe conflict with the app). Is there any way to downgrade my SDK to their version?

The Flutter CLI tool offers a downgrade command, which will take your SDK to the previous stable version.
One thing that may help you, is using fvm which is a third party tool that lets you easily work with different Flutter versions on the same computer.

yeah struggling a bit with fvm but there isnt by any chance the option to downgrade to a specific version from the flutter CLI tool?

Hi @nik-v-hax
When I want to use a specific version I use git-fork and check out the release tag for that version screenshot
you can only downgrade to previous from your tool history using flutter downgrade
Other than this, it is expected to run into issues between big releases
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Totally agree to close this - just didn't know where to put it because there were no resources on how to approach this but I'll defnietly try to checkout release tags if fvm doesn't work


Allow missing closing delimiter in block comments.

https://github.com/natefaubion/purescript-tidy/issues/56


Expose io_error in SyscallError

If a bpf syscall fails, it would be useful to know if this is due to not having enough permissions or that the kernel does not have BPF support.
Ubuntu kernels are compiled without CONFIG_BPF_LIRC_MODE2 so this is important for https://github.com/seanyoung/cir/ : I would like to present a useful error saying your kernel does not support BPF IR decoders, go fix your kernel.
Also, when removing all BPF programs using cir config --clear then if there is no support for BPF, there is nothing to clear and the syscall error can be ignored.

It would be great to have this merged, please let me know if there is anything I can do to make this more amenable

Oops sorry forgot to merge when I approved two weeks ago!

Wonderful thank you @alessandrod


nsis: Upgrade 3.05

Motivation for this change
Upgrade to 3.05 to prepare for upgrade to Python 3 usage in SCons.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Please, use nsis: 3.04 -> 3.05 for commit message as described in Submitting changes.