Update installation.rst instructions

ref: #869

Add Prerequisites section
remove sudo
use --user install option
use --upgrade for consistency

Current coverage is 99.70% (diff: 100%)

Merging #880 into master will decrease coverage by 0.29%

@@           master       #880   diff @@
========================================
  Files          17         17
  Lines         685        685
  Methods         0          0
  Messages        0          0
  Branches        0          0
========================================
- Hits          685        683     -2
- Misses          0          2     +2
  Partials        0          0

Powered by Codecov. Last update 2b8a8eb...4626763

@stevepiercy While you're here, I'm not convinced that the verbosity of the Debian installation instructions are justified.  I think we should just be recommending apt-get install cookiecutter?
@vincentbernat do you have any thoughts on this? Is there an easier way to install the latest/unstable cookiecutter on a Debian system?

@stevepiercy While you're here, I'm not convinced that the verbosity of the Debian installation instructions are justified.  I think we should just be recommending apt-get install cookiecutter?
@vincentbernat do you have any thoughts on this? Is there an easier way to install the latest/unstable cookiecutter on a Debian system?

Yep, manually installing packages is calling for trouble. You can break other parts of the distribution and it is far possible that you get a non-functional cookiecutter at the end. Also, documentation needs to be kept up-to-date with the list of packages.
For Ubuntu Xenial, we have 1.3. For the future Debian Stretch (to be released in February or March), we will have a 1.5. For Debian, I can also do backports to let people have 1.5 for Debian Jessie. For Ubuntu, I can maintain a PPA. However, this is a bit of work (because dependencies will have to be backported too), notably for Ubuntu. Is there an audience for this?
If the version of cookiecutter in Debian/Ubuntu is not recent enough, people should use pip as a fallback.

Yep, manually installing packages is calling for trouble. You can break other parts of the distribution and it is far possible that you get a non-functional cookiecutter at the end. Also, documentation needs to be kept up-to-date with the list of packages.
For Ubuntu Xenial, we have 1.3. For the future Debian Stretch (to be released in February or March), we will have a 1.5. For Debian, I can also do backports to let people have 1.5 for Debian Jessie. For Ubuntu, I can maintain a PPA. However, this is a bit of work (because dependencies will have to be backported too), notably for Ubuntu. Is there an audience for this?
If the version of cookiecutter in Debian/Ubuntu is not recent enough, people should use pip as a fallback.

Thanks for the insight @vincentbernat- I think those default versions are fine, we should just cater for easily supported installation scenarios.
@stevepiercy would you be up to revising the Debian/Ubuntu installation section to just be:
$ sudo apt-get install cookiecutter

?

Thanks for the insight @vincentbernat- I think those default versions are fine, we should just cater for easily supported installation scenarios.
@stevepiercy would you be up to revising the Debian/Ubuntu installation section to just be:
$ sudo apt-get install cookiecutter

?

Done in https://github.com/audreyr/cookiecutter/pull/880/commits/271c515a472b054cd97b5aa8cbe84b3b39c43aae I hope I understood what you meant. If not, I can fix tonight.

Done in https://github.com/audreyr/cookiecutter/pull/880/commits/271c515a472b054cd97b5aa8cbe84b3b39c43aae I hope I understood what you meant. If not, I can fix tonight.

Here it is: https://github.com/audreyr/cookiecutter/pull/880/commits/8383d010cc635271b1f0840a7b19e75550648972

Here it is: https://github.com/audreyr/cookiecutter/pull/880/commits/8383d010cc635271b1f0840a7b19e75550648972

Awesome stuff @stevepiercy, thanks :smile_cat:

Awesome stuff @stevepiercy, thanks :smile_cat:


UnityEngine namespace to avoid collisions

Overview
Fixing namespace (UnityEngine.Mesh) clash, when MRTK is used with other packages.
Changes

Fixes:  HandJointVisualizer uses UnityEngine.Mesh as a type. To avoid clashing with other types, full namespace was added.

We found a reason, why collision happened (our artifact was referenced inside mrtk.input). We applied fix on our side, so there is no need fot this change. I will close this PR


Basket. Refresh button. If selected operations refresh button lead to confirm screen.

Description
If user click on refresh button, while some operations is selected it will refresh the validations and then lead to confirm page.

Example
https://github.com/novasamatech/nova-spektr/assets/40560660/d65c18a6-5d86-4bcb-8da3-b09d58356988

Steps to Reproduce

Go to the Basket

Basket has a few operations

Select some operations
Click refresh list

Expected Behavior
Validation state has updated for all operations
Actual Behavior
Validation state has been updated and then open confirmation page for that operations
Environment
https://github.com/novasamatech/nova-spektr/commit/36c791f377a0a3f16c7fca5cc1945b59428d328c

Status verification: ✅


feat: linter aspect factories allow customizing rule kinds

This lets users adapt for situations where they have a custom rule, for example.

Note, I didn't touch clang_tidy.bzl in this PR because it uses the built-in CcInfo provider to determine what to visit.

Are "kinds" purely based on the string name of a target? It doesn't matter where it loaded from, macro vs rule etc?

@jbedard I believe the kind is what appears after the analysis phase, so macros have been expanded already and the kind is always what you would see in bazel query, which is to say it's the actual rule() declaration.
But yes, if it's named ts_library then this matches, whether it's the one from rules_ts or something the user defined.
We could decide to load provider symbols here instead, and then require that the rule provides something. For example ruff and flake8 could be based on a PyInfo provider. But of course we want a provider of sources, and adding a dependency just for that load is probably not desirable


readers annotation generating reader for self

The following bit of code (excluded all imports and ceremony for brevity) fails to compile. (The usecase might be specific, but it would be great if it would also just work)
@readers
case class ApplicationConfig(
  dbConfig: DbConfig
)

@reader[ApplicationConfig]
case class Foo(config: ApplicationConfig, db: DB)

It fails because there's no implicit reader instance (Reader[ApplicationConfig, ApplicationConfig]) to be found.
It would be resolved if the @readers annotation would also generate the following
object ApplicationConfig {
  implicit val reader: Reader[ApplicationConfig, ApplicationConfig] =
    Reader.apply(identity)
}

@etorreborre you beat me to it. I was opening a PR for it, but when looking for the issue, I just saw you already addressed it. 🚀

:-). Now I'm just waiting a bit to see if I can get the final version of Kiama 2.1.0 before I publish a new grafter version. But I can publish an interim version if you need it now.

We can temporarily live with the additional 4 LoCs. We opened an issue to remove these once an updated version is released, so we can wait it out.
btw: our latest service uses both grafter and eff extensively (in combination with cats, pureconfig & tagless final) and the modularity this all offers us is nothing short from amazing.

Very nice! A blog post coming up :-) ?


EgressIP: add route policies for east-west traffic between networks

📑 Description
When primary network have multiple networks, the ovn_cluster_router only has route policies to allow east-west traffic within the individual network, e.g.:
    102 ip4.src == <IP_ADDRESS>/16 && ip4.dst == <IP_ADDRESS>/16    allow
    102 ip4.src == <IP_ADDRESS>/16 && ip4.dst == <IP_ADDRESS>/16    allow

This change adds the necessary route polices to allow east-west traffic across different CIDRs:
    102 ip4.src == <IP_ADDRESS>/16 && ip4.dst == <IP_ADDRESS>/16    allow
    102 ip4.src == <IP_ADDRESS>/16 && ip4.dst == <IP_ADDRESS>/16    allow

✅ Checks

[ ] My code requires changes to the documentation
[ ] if so, I have updated the documentation as required
[ ] My code requires tests
[ ] if so, I have added and/or updated the tests as required
[ ] All the tests have passed in the CI

How to verify it
This issue was found in our downstream with below scenario:

cluster has two networks(net_cidr): <IP_ADDRESS>/16 and <IP_ADDRESS>/16
two k8s nodes have subnet allocated from different networks

When a pod on node with network <IP_ADDRESS>/16 sends a packet to another pod on node with network <IP_ADDRESS>/16, the packet can  not be matched by:
    # 102 - DefaultNoRereoutePriority
   # DefaultNoRereoutePriority policies are added when EgressIP feature is enabled, they ensure that east-west traffic is not using egress IPs.
    102 ip4.src == <IP_ADDRESS>/16 && ip4.dst == <IP_ADDRESS>/16    allow
    102 ip4.src == <IP_ADDRESS>/16 && ip4.dst == <IP_ADDRESS>/16    allow

So it could be matched by egressIP reroute policy if the pod matching a EgressIP:
      # 100 - EgressIPReroutePriority
      # added for the pod matching egressip-prod EgressIP, and it redirects the traffic to one of the egress nodes
       100                              ip4.src == <IP_ADDRESS>         reroute                <IP_ADDRESS>, <IP_ADDRESS>

Our downstream has a in-house node subnet allocation mechanism based on the node's pod density(indicated by an annotation), so it's easier to allocate node subnet from different network. Upstream e2e test only has one cluster network, even it has multiple networks there are no way to allocate node subnet from different network.
It's not possible to cover this change in e2e for now, but this change is straightforward, please take a look if it can be merged.

CC @flavio-fernandes @cathy-zhou @girishmg

/retest

Hi @martinkennelly PTAL: iirc, you have worked a lot with this code and can be a good person to review it too.
Happy New Year! 🥳


[Site] List the author name and date on the blog posts

Description
In the blog page of Service Mesh Performance, currently we are missing out author name and date on the blog posts.
Expected Behavior
The blog page should contain the respective author name and date on the blog posts. We can use the the style of Layer5.io/blog for reference :)

NOTE : If anyone wants to fix the blog card padding issue in blog page, he/she might open a new issue regarding it & start fixing it!

@Neilblaze many people coming to look at this site. I'm making some quick updates. I added blog author and date to the page layout. The name and date are still missing on the posts_grid.
You can change how this is done in the page layout (or create a layout for posts). We just needed something quick.

I'm on it :zap:

Thank you, sir.


Replacing completeopt

Is there a reason ALE depends upon replacing the completeopt setting? I don't like having the preview menu pop up when I'm typing, so my vimrc has set completeopt-=preview. However, it seems that using completion via ALE will always mutate this field for the user:
https://github.com/w0rp/ale/blob/bda89506bac3bf25d56a0ad8aef81a4cae848bb8/autoload/ale/completion.vim#L137
I would think completeopt should be a field that plugins leave alone, and let the user decide what their menu does or doesn't look like. If we don't do that, do you think that a setting that lets the user decide if ALE overrides this would be a fine compromise?
Thanks!

Yes, there are some options which are required at least. noselect and noinsert have to be set for completion to work as you type, so those have to be set for sure.  menuone needs to be set or words will suddenly start being inserted while you type, and therefore menu is also needed. Pretty much the only thing that could be optional is preview.
The options are changed only temporarily while ALE is displaying completion results.
I could make it so ALE doesn't show completion previews if you have the option off. That could be reasonable.

Great, I'll follow this thread for any improvements. I would like to only use ALE, but in the mean time, I'm going to be using https://github.com/autozimu/LanguageClient-neovim (minus diagnostics) for most of my language-server needs and rely on ALE for linting/fixing.
I would love to only use plugin, so if this gets added, I'll be sure to revisit completion via ALE

Now the preview setting will be respected for completion as you type.

great! thanks so much


ITI Tech committee review

The IUA supplement has gone through some radical changes based on our current work item on IUA, and the regular call consensus. This is has resulted in a major rewrite of the supplement. I would like to get the ITI Tech membership to review the text over the next three weeks, and provide comments to resolve in October. The goal is to have a review-ready version for our November virtual-face-to-face meeting approval for formal Ballot. Thus this September review is not the formal ballot review, but rather the kind of review we do prior to going to public comment.
Given this is a radical rewrite, please comment on the whole document. Is volume 1 clear? is volume 2 clear? What questions does it leave you with? What more would you like to see? Are their sentence or spelling issues?
We request that your comments are submitted by September 25th. We realize this is competing with HL7 ballot and HL7 workgroup meeting.
We request that you enter your comments using GitHub Issues, would be glad to get some pull-requests too. (if you struggle with GitHub Issues, please just email your comments)
https://github.com/IHE/IT-Infrastructure/issues
The IUA supplement for review
https://github.com/IHE/IT-Infrastructure/blob/master/IUA.b/IHE_ITI_Suppl_IUA.md
The closed issues
https://github.com/IHE/IT-Infrastructure/issues?q=is%3Aissue+is%3Aclosed+

Reminder to committee review of IUA draft due on 25th.
Note I added three discussion "issues" coinciding with the open issues in the IUA supplement under review. you could add your comments there.


ERROR Unwinding{stage=MerkleUnwind}: Failed to verify block state root!

Describe the bug
v1.0.6+bsc mainnet, restart node with --enable-prefetch and --optimize.enable-execution-cache flags, get 'Failed to verify block state root' error and node shutdown
Steps to reproduce

run node works well with cli: bsc-reth node --datadir=/data/reth --config=/root/reth.toml --peers-file=/data/peers-bsc  --http --http.api=admin,debug,eth,net,trace,txpool,web3,rpc,reth,ots --ws --ws.api=admin,debug,eth,net,trace,txpool,web3,rpc,reth,ots --ipcpath=/data/reth/reth.ipc --txpool.pending_max_count=51200 --txpool.queued_max_count=30240 --full
stop node with command kill -9, add --enable-prefetch and --optimize.enable-execution-cache flags and restart, the bug occur
stop node again, remove the above two flags and restart node, the bug also occurs

Node logs
2024-11-14T15:07:17.797203Z  INFO Setting unwind target. highest_block=43992628 unwind_target=43627209 segment=Receipts
2024-11-14T15:07:17.797206Z  INFO Setting unwind target. highest_block=43992628 unwind_target=43627208 segment=Receipts
2024-11-14T15:07:17.797209Z  INFO Setting unwind target. highest_block=43992628 unwind_target=43627207 segment=Receipts
2024-11-14T15:07:17.797212Z  INFO Setting unwind target. highest_block=43992628 unwind_target=43627206 segment=Receipts
2024-11-14T15:07:17.797214Z  INFO Setting unwind target. highest_block=43992628 unwind_target=43627205 segment=Receipts
2024-11-14T15:07:17.797227Z  INFO Setting unwind target. checkpoint_block_number=43992628 unwind_target=43627205 segment=Receipts
2024-11-14T15:07:17.798947Z  INFO Executing an unwind after a failed storage consistency check. unwind_target=Unwind(43627205)
2024-11-14T15:07:17.799948Z  INFO Unwinding{stage=MerkleUnwind}: Starting unwind from=43992628 to=43627205 bad_block=None
2024-11-14T15:12:16.551181Z  WARN Long-lived read transaction has been timed out open_duration=300.000075041s
2024-11-14T16:14:17.991248Z ERROR Unwinding{stage=MerkleUnwind}: Failed to verify block state root!
Invalid state root error on stage verification!
This is an error that likely requires a report to the reth team with additional information.
Please include the following information in your report:
 * This error message
 * The state root of the block that was rejected
 * The output of `reth db stats --checksum` from the database that was being used. This will take a long time to run!
 * 50-100 lines of logs before and after the first occurrence of the log message with the state root of the block that was rejected.
 * The debug logs from __the same time period__. To find the default location for these logs, run:
   `reth --help | grep -A 4 'log.file.directory'`

Once you have this information, please submit a github issue at https://github.com/bnb-chain/reth/issues/new
 target_block=43627205 got=0xc8a20d141f2dc0b1039d25eda472561e0526790823860cb83d5ff666cd2bc816 expected=SealedHeader { hash: 0xcbd43481ea3f8cf28e18baaf5b6b6486359f5e62fb2fea72edfabbdd5c985a25, header: Header { parent_hash: 0xe04f109dc3283dc75bfe4d9370fbb5ead51971c1f7c7c449161495f8ed6119e0, ommers_hash: 0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347, beneficiary: 0xf8de5e61322302b2c6e0a525cc842f10332811bf, state_root: 0x4140a8f3e9c42b0c4bb1f2d359af2700ece48bdc7500e69d2c0ab8b818e658e2, transactions_root: 0x551b72e007890f4814ae9778ffdcaff97db6c4b962b3ff40c879fd1423f060c5, receipts_root: 0x703e2b1df5dce452f26c31e6d115297b208b69c24789527efd2c27ea7256eb73, withdrawals_root: Some(0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421), logs_bloom: 0xdcae3270340b5511a08d8f7fe83e6f569f4a99b9ae21179ad14d82c5e3fd26250bfa12e18537c7194f2cdcb7c32ff1b5c7fbfebaf7392dc31d2ac5b9732f9fa2269d5ead37c76fc883534d5bda8fa5f72b34e9730ee5b43b2f74ceb8ccd0e2933a09182327ebd9152619757361e03b4bd9a19c73de03fe1d341dea7cc4c87f6868423bf401db964657893f6cbf77c88a65368f5b7525dcd976d20750d7c150eae3023a8bd69ea7e73a4521c3567cc745bd0c40ed54caf12783064015ff27fd0a5fb98f2a220d8ca243316d3e6bfd12a022f6aba7c9ed629143567dab992afc256a77337d27a6fe479f56d2ec97d42bb86111ea6b1690a44dd46092dc173c6d36, difficulty: 2, number: 43627205, gas_limit: 139997863, gas_used: 16117864, timestamp:<PHONE_NUMBER>, mix_hash: 0x0000000000000000000000000000000000000000000000000000000000000000, nonce: 0x0000000000000000, base_fee_per_gas: Some(0), blob_gas_used: Some(0), excess_blob_gas: Some(0), parent_beacon_block_root: Some(0x0000000000000000000000000000000000000000000000000000000000000000), requests_root: None, extra_data: 0xd98301040e846765746889676f312e32312e3133856c696e7578000060adae27f8b5831fffffb860a7b9da07509269c035ac2c3ad7bbe8fe7cedf0257640a0c6faae6e97ba6bc6e54de7079d929ad610a879385b7b8a7e170e9a2ef8f83d5a035cd91fadd6f0eef56767f3806dab76989d3c86fc7ac8bda9dee37cdedba48a5f1259310431dcc990f84c840299b2c3a0803eb9fe037c1d40c4661d30ac99b5e040c375f3ba7d602954b053f93ca7fe4e840299b2c4a0e04f109dc3283dc75bfe4d9370fbb5ead51971c1f7c7c449161495f8ed6119e0807e4b6a6f02c9950b0d9bc033a693da1124ba9e15ca680ca2fde22474ec1e3a9f4b14e84d6b4236a35bbf9def2476259fe4c46efb7613444c8cdea5410dbbcdfd01 } }
2024-11-14T16:14:20.510553Z  WARN The database read transaction has been open for too long.
Full via --full flag
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

Hi, Has the node been restored? I think the data corruption may have occurred during the forced shutdown.
Did you try manually rolling back to the previous block?
The command would be like. bsc-reth stage unwind --datadir ${datadir} to-block ${block_height}

Hi, Has the node been restored? I think the data corruption may have occurred during the forced shutdown.
Did you try manually rolling back to the previous block?
The command would be like. bsc-reth stage unwind --datadir ${datadir} to-block ${block_height}

no, I give up and delete all data, restart node via snapshot

Thank you for your response! We are currently testing the next release version. The unwind function in this update will be more stable, allowing users to rewind and recover their nodes if any issues occur.
If you have any further questions, please feel free to open a new issue or reopen this one. Thank you!

Thank you for your response! We are currently testing the next release version. The unwind function in this update will be more stable, allowing users to rewind and recover their nodes if any issues occur.
If you have any further questions, please feel free to open a new issue or reopen this one. Thank you!


Build construct in kedge manifests

Kedge support doing build using docker daemon. Which takes input of Dockerfile, build context and container image name.
To support build using OpenShift, we will need to figure out the way to take input of build data. If we define our own way of taking input then we are limiting folks who wanna do builds and wanna use the full fledged functionality of OpenShift builds.
So what I propose is that we take embed OpenShift Buildconfig spec inside Container spec.

This is blocked on https://github.com/kedgeproject/kedge/pull/315

This is blocked on #315

not blocked anymore

For OpenShift builds we shouldn't be creating anything special, just adding BuildConfig support as described in https://github.com/kedgeproject/kedge/issues/385

So what I propose is that we take embed OpenShift Buildconfig spec inside Container spec.

don't understand what do you mean?

@surajssd could post a snippet of how bc spec + container spec look like, and which fields will auto populate using the merge?


Formatting all files

The PR that suggested the pre-commit routine was merged before all files could be reformatted according to flake8, isort, and black.
Therefore I open this PR that will finish formatting all other files too. Once this PR is merged into master, we can start to focus on the important bits :smiley_cat:

The only weird thing that I encountered in the code is this line in archive.py
flake8 pointed out that the variable future_comparison is never used, so I just removed it.
But that leaves me asking whether the for loop is necessary...

Great work. Thanks for this @Christovis
As part of this merge I'm adding a change to the repo_loader regex that fixes a failing test on my local instance.
I'm not sure why those test failures are cropping up --  a bit mysterious.

Btw. thanks for having resolved the regex issue in the repo_loader.py! I missed it :grimacing:


Domain join all nodes schema error

when trying to join  all nodes to active directory it fails, looks the payload format is not right,

data "ciscoise_active_directory_join_domain_with_all_nodes" "example" {
  provider = ciscoise
  id       = "12345"
  additional_data {
    name  = "admin"
    value = "test123"
  }
}

The payload format should be as below,

 {
              "OperationAdditionalData" : {
                  "additionalData" : [
                      {
                          "name" : "username",
                          "value" : "admin"
                      },
                      {
                          "name" : "password",
                          "value" : "test123"
                      }
                  ]
              }
          }

error:
2021-12-24T06:09:46.511-0800 [INFO]  provider.terraform-provider-ciscoise_v0.0.3-beta: 2021/12/24 06:09:46 [DEBUG] Selected method 1: JoinDomainWithAllNodes: timestamp=2021-12-24T06:09:46.511-0800
2021-12-24T06:09:46.529-0800 [INFO]  provider.terraform-provider-ciscoise_v0.0.3-beta: 2021/12/24 06:09:46 [DEBUG] request sent => {"OperationAdditionalData":{"additionalData":[{"value":"test123","name":"admin"}]}}: timestamp=2021-12-24T06:09:46.528-0800
2021-12-24T06:09:46.529-0800 [TRACE] provider.stdio: received data: channel=STDERR len=1024
2021-12-24T06:09:46.529-0800 [TRACE] provider.stdio: waiting for stdio data
2021-12-24T06:09:46.529-0800 [TRACE] vertex "data.ciscoise_active_directory_join_domain_with_all_nodes.domainjoin": visit complete
2021-12-24T06:09:46.529-0800 [TRACE] provider.stdio: received data: channel=STDERR len=12
2021-12-24T06:09:46.529-0800 [TRACE] vertex "data.ciscoise_active_directory_join_domain_with_all_nodes.domainjoin": dynamic subgraph encountered errors: Failure when executing JoinDomainWithAllNodes
2021-12-24T06:09:46.529-0800 [TRACE] vertex "data.ciscoise_active_directory_join_domain_with_all_nodes.domainjoin": visit complete
2021-12-24T06:09:46.529-0800 [TRACE] vertex "data.ciscoise_active_directory_join_domain_with_all_nodes.domainjoin (expand)": dynamic subgraph encountered errors: Failure when executing JoinDomainWithAllNodes
2021-12-24T06:09:46.529-0800 [TRACE] provider.stdio: waiting for stdio data
2021-12-24T06:09:46.529-0800 [TRACE] vertex "data.ciscoise_active_directory_join_domain_with_all_nodes.domainjoin (expand)": visit complete
2021-12-24T06:09:46.529-0800 [TRACE] dag/walk: upstream of "meta.count-boundary (EachMode fixup)" errored, so skipping
2021-12-24T06:09:46.529-0800 [TRACE] dag/walk: upstream of "provider["registry.terraform.io/ciscoise/ciscoise"] (close)" errored, so skipping
2021-12-24T06:09:46.529-0800 [TRACE] dag/walk: upstream of "root" errored, so skipping
╷
│ Error: Failure when executing JoinDomainWithAllNodes
│
│   with data.ciscoise_active_directory_join_domain_with_all_nodes.domainjoin,
│   on adjoin.tf line 57, in data "ciscoise_active_directory_join_domain_with_all_nodes" "domainjoin":
│   57: data "ciscoise_active_directory_join_domain_with_all_nodes" "domainjoin" {
│
│ error with operation JoinDomainWithAllNodes
╵

Hi, @ragu2k8. To represent the payload format the data source should look something like this.
data "ciscoise_active_directory_join_domain_with_all_nodes" "example" {
  provider = ciscoise
  id       = "12345"
  additional_data {
    name  = "username"
    value = "admin"
  }
  additional_data {
    name  = "password"
    value = "test123"
  }
}

2021-12-24T08:43:39.204-0600 [INFO]  provider.terraform-provider-ciscoise: 2021/12/24 08:43:39 [DEBUG] Selected
method: JoinDomainWithAllNodes: timestamp=2021-12-24T08:43:39.204-0600
2021-12-24T08:43:39.813-0600 [INFO]  provider.terraform-provider-ciscoise: 2021/12/24 08:43:39 [DEBUG] request
sent => {"OperationAdditionalData":{"additionalData":[{"value":"admin","name":"username"},
{"value":"test123","name":"password"}]}}: timestamp=2021-12-24T08:43:39.813-0600

Hopefully, that clarifies it.

thanks for clarification. however i dont see any ISE API response
╷
│ Error: Failure when executing JoinDomainWithAllNodes
│
│   with data.ciscoise_active_directory_join_domain_with_all_nodes.example,
│   on adjoin.tf line 66, in data "ciscoise_active_directory_join_domain_with_all_nodes" "example":
│   66: data "ciscoise_active_directory_join_domain_with_all_nodes" "example"{
│
│ error with operation JoinDomainWithAllNodes
╵
Log:
2021-12-24T07:29:02.078-0800 [DEBUG] provider: starting plugin: path=.terraform/providers/registry.terraform.io/ciscoise/ciscoise/0.0.3-beta/darwin_amd64/terraform-provider-ciscoise_v0.0.3-beta args=[.terraform/providers/registry.terraform.io/ciscoise/ciscoise/0.0.3-beta/darwin_amd64/terraform-provider-ciscoise_v0.0.3-beta]
2021-12-24T07:29:02.084-0800 [DEBUG] provider: plugin started: path=.terraform/providers/registry.terraform.io/ciscoise/ciscoise/0.0.3-beta/darwin_amd64/terraform-provider-ciscoise_v0.0.3-beta pid=82731
2021-12-24T07:29:02.084-0800 [DEBUG] provider: waiting for RPC address: path=.terraform/providers/registry.terraform.io/ciscoise/ciscoise/0.0.3-beta/darwin_amd64/terraform-provider-ciscoise_v0.0.3-beta
2021-12-24T07:29:02.101-0800 [INFO]  provider.terraform-provider-ciscoise_v0.0.3-beta: configuring server automatic mTLS: timestamp=2021-12-24T07:29:02.101-0800
2021-12-24T07:29:02.132-0800 [DEBUG] provider: using plugin: version=5
2021-12-24T07:29:02.132-0800 [DEBUG] provider.terraform-provider-ciscoise_v0.0.3-beta: plugin address: address=/var/folders/4v/rvvnj2xx3ns7ylg5bdpy6v4c0000gq/T/plugin798887526 network=unix timestamp=2021-12-24T07:29:02.131-0800
2021-12-24T07:29:02.305-0800 [DEBUG] Resource instance state not found for node "data.ciscoise_active_directory_join_domain_with_all_nodes.example", instance data.ciscoise_active_directory_join_domain_with_all_nodes.example
2021-12-24T07:29:02.305-0800 [DEBUG] ReferenceTransformer: "data.ciscoise_active_directory_join_domain_with_all_nodes.example" references: []
2021-12-24T07:29:02.326-0800 [INFO]  provider.terraform-provider-ciscoise_v0.0.3-beta: 2021/12/24 07:29:02 [DEBUG] Selected method 1: JoinDomainWithAllNodes: timestamp=2021-12-24T07:29:02.326-0800
2021-12-24T07:29:05.491-0800 [INFO]  provider.terraform-provider-ciscoise_v0.0.3-beta: 2021/12/24 07:29:05 [DEBUG] request sent => {"OperationAdditionalData":{"additionalData":[{"value":"admin","name":"username"},{"value":"test123","name":"password"}]}}: timestamp=2021-12-24T07:29:05.491-0800
2021-12-24T07:29:05.508-0800 [DEBUG] provider.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = transport is closing"
2021-12-24T07:29:05.511-0800 [DEBUG] provider: plugin process exited: path=.terraform/providers/registry.terraform.io/ciscoise/ciscoise/0.0.3-beta/darwin_amd64/terraform-provider-ciscoise_v0.0.3-beta pid=82731
2021-12-24T07:29:05.511-0800 [DEBUG] provider: plugin exited

Three things.
First, it seems to me that the nodes could be already joined. In those cases, Cisco ISE returns an error.
Second, '[DEBUG] Retrieved response', if you have TF_LOG set, is the line that should give you the ISE response.
Third, you could also get the response using an output block
output "join_result" {
  value = data.ciscoise_active_directory_join_domain_with_all_nodes.example
}

thanks @wastorga,

I am letting the domain join to fail explicitly hoping to see api failed response in logs.
something like below but dont see any such response in logs.

"ERSResponse\" : {\n    \"operation\" : \"PUT-joinAllNodes-activedirectory\",\n    \"messages\" : [ {\n      \"title\" : \"Operation [join] failed [com.cisco.cpm.ers.api.exception.ERSCRUDHandlerException: nodes not able to join/remove : [isetest.cisco.com]\",\n      \"type\" : \"ERROR\",\n      \"code\" : \"CRUD operation exception\"\n    } ],\n    \"link\" : {\n      \"rel\" : \"related\",\n      \"href\" : \"https://isetest.cisco.com/ers/config/activedirectory/61c9a1e0-6478-11ec-aa94-f6a74d56418c/joinAllNodes\",\n      \"type\" : \"application/xml\"\n    }\n  }\n}"
}

have the set TF_LOG='trace' and ise debug to 'true'

however if there is no issue during api call, it works fine.

I need to look into the debug option of the SDK. The resty logs do not appear in Tf. Currently, Tf only catches the logs from the "log" package.
I have added code to display the error responses for the missing data source "actions" on the develop branch.
I will later add it to the next version.

@wastorga appreciate it . thanks for looking.

I changed the Resty Logger to be Terraform compatible. The Resty logger appears if TF_LOG is set, and the ISE_DEBUG env is true or provider debug param is true.
Version 0.1.0-rc.2 is currently in the process of publishing.


add abandon to transaction list filter

#608

Maybe these should all be constants?

We can just add it to this PR, it's not a big rush.


How to create a variable which returns if any storage was granted

Hello,
how to create for example "ad_analytics_storage" variable, which returns if both ad_storage and analytics_storage was granted? Thank you very much.

Hello,
I don't know exactly what you want to achieve. Are you talking about GTM variable or javascript variable?
I tried something like this:
GTM variable (the variable contains a closure):

Tag:

Using in the console (before consent and after "accept all"):

But I don't know your UC.

That's exactly what I wanted. Thank you!


HTC mobile --

Hi Bcsphere,
My device is HTC 516 desire, Android-4.3, i.e APi-18.
1> Please suggest where to get 'com.htc.android.bluetooth.le.jar' library ?
2> Which location to add this jar file ?
3> Is this library written by you or is given by HTC ?
Please suggest.
Git hub use to say :----
Android API 16+, HTC devices with Bluetooth Low Energy HW,
note: HTC use shared library to operate BLE device, you should add the 'com.htc.android.bluetooth.le.jar' in the build path manually to support HTC devices, the files is in /others/HTC for optional use.
Regards,
Dinesh

Ok I found the file here :--
https://github.com/bcsphere/bcfindme/tree/master/platforms/android/com.htc.android.bluetooth.le
Still please suggest about question 2 & 3.
Regards,
Dinesh

Please suggest.
if i have to build my intel-xdk cordova project with this JAR file then what i have to do ?
Do i have to add this file in plugin src folder ?
Means how to include this JAR file in my project so that it got build ?
Regards,
Dinesh

Dinesh,
Do you have to work this out? It has compilation issue previously. That's the reason the htc lib was removed. Suggest to forget about this since it is legacy.
Regards.


Cannot get downloads for scoped packages

https://api.npmjs.org/downloads/point/last-month/@kadira/storybook-ui -> 404
https://api.npmjs.org/downloads/point/last-month/%40kadira%2Fstorybook-ui -> fail?

By the way, since May approximately, it's possible to get downloads for single packages, but not multiple. So either we leave it like it's now (skip scoped packages), either we get the downloads of scoped packages one by one, increasing our requests.

https://api.npmjs.org/downloads/point/last-month/@kadira/storybook-ui <-- works
https://api.npmjs.org/downloads/point/last-month/@kadira/storybook-ui,algoliasearch <-- gives an error response

Since scoped packages are not that frequent we could do some optimisation where when we have 200 packages we sort them by scoped/non scoped. For each scoped we do 1 req, for other we do bulk.
We are already doing single requests for dependedUpon so that should be fine.


Rotom forms unobtainable by the usual way.

Describe the bug
You are unable to change Rotom forms by throwing it out at a machine. Tested in singleplayer and it works as intended, however does nothing in the server. Tested with two different rotoms, in a claim and outside of a claim. Tried a Fan, Fridge and Washing machine.
-unsure if we had another way to obtain them, but could not find information on that in discord-
To Reproduce
Place a fan
Throw base form Rotom at the fan
See error
Expected behavior
Rotom should have turned into Rotom-fan and learned a new move.
This persists on all servers.

We can write some alternative way of obtaining these.

Forwarded to Internal! Will update here when implemented!


Use bigchaindb (server + common) 0.7.0

Current coverage is 100% (diff: 100%)

Merging #128 into master will not change coverage

@@           master   #128   diff @@
====================================
  Files           7      7
  Lines         139    139
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          139    139
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 143b805...d98cc34


npm install fails on Node 4.6.2

Hello.
Tried to launch the installer on clean installation of version 4.6.2 of node.js (Windows10 Pro) and if fails on node-gyp. Additional details can be found in the attached file.
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuildnpm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the durable package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR!     node-gyp rebuild npm ERR! You can get information on how to open an issue for this project with: npm ERR!     npm bugs durable npm ERR! Or if that isn't available, you can get their info via: npm ERR!     npm owner ls durable npm ERR! There is likely additional logging output above. npm verb exit [ 1, true ]
Best regards,
DP.
npm-debug.txt

Hi, thanks for reporting the problem. Windows requires a few extra steps to enable building extensions written in C. Would you mind trying the following steps?

Install VC++ build tools (http://go.microsoft.com/fwlink/?LinkId=691132), make sure you select Windows 8.1 and Windows 10 SDKs (if you don't select both, the installer will set the ucrt path incorrectly and node-gyp build will fail)
Install Python 2.7 (https://www.python.org/downloads/) and add it to your PATH
npm config set python python2.7 (from cmd terminal)
npm config set msvs_version 2015 --global (from cmd terminal)

At this point you can do:
npm install durable

Hi @jruizgit!
Link http://go.microsoft.com/fwlink/?LinkId=691132 doesn't seem to work. What should I download?
Will this be OK?
http://landinghub.visualstudio.com/visual-cpp-build-tools

@jruizgit - the installation worked, but the script doesn't seem to produce any output.
Here is the code:
`'use strict';
var d = require('durable');
var m = d.m, s = d.s, c = d.c, timeout = d.timeout;
d.ruleset('fraud1_0', {
whenAll: [ m.amount.eq(null) ],
run: function(c) {
console.log('fraud1_0 detected ' + c.m.amount);
}
},
function (host) {
host.post('fraud1_0', {id: 1, sid: 1, amount: 200});
host.post('fraud1_0', {id: 2, sid: 1, amount: null});
}
);`
And here is the output:

C:\Users\Darek\WebstormProjects\game>npm config set python python2.7

C:\Users\Darek\WebstormProjects\game>npm config set msvs_version 2015 --global
C:\Users\Darek\WebstormProjects\game>node test.js
C:\Users\Darek\WebstormProjects\game>

I'm sorry for the delay in my reply, I'm just catching up. I'm happy to hear the installation is working.
I think you are missing one line at the end:
d.runAll();

The last line will fail if you don't have a redis server running in the localhost port 6379. If you are using a redis server in a different host:
d.runAll({host: hostName, port: portNumber , password:null}]);


Need to rebuild pouchcontainer/pouchlinter:v0.1.2 image.

Ⅰ. Issue Description
Need to rebuild pouchcontainer/pouchlinter:v0.1.2 image, because of Unauthorized access to Docker Hub database.
Ⅱ. Describe what happened
@spiffxp

Wasn't familiar with this container so went looking:
https://github.com/pouchcontainer/pouchlinter/blob/master/Dockerfile
https://github.com/kubernetes/cloud-provider-alibaba-cloud/blob/master/Makefile#L59
Seems like a lot just to run gometalinter
Has this container been updated / rebuilt since DockerHub's recent breach? https://success.docker.com/article/docker-hub-user-notification
Ⅲ. Describe what you expected to happen
https://github.com/kubernetes/test-infra/pull/12580/files
Ⅳ. How to reproduce it (as minimally and precisely as possible)
NA
Ⅴ. Anything else we need to know?
NA
Ⅵ. Environment:
NA

Currently I have rebuild this image.
root@iZ6we733xvy9ylvtdlolfhZ:/tmp/5/pouchlinter# docker push pouchcontainer/pouchlinter:v0.1.2
The push refers to repository [docker.io/pouchcontainer/pouchlinter]
61245a8ea066: Pushed
c9053237c142: Pushed
790815097f0b: Pushed
2f03d8033b28: Pushed
3b1d0f3af8e7: Pushed
87df6ab0876c: Pushed
5dfa46f41441: Pushed
a6732a5cb7f8: Pushed
9e8a6cfff524: Pushed
fe68620297bb: Pushed
7d878ed2a763: Pushed
d908c11b1a82: Mounted from library/ubuntu
7ccfaa7554e3: Mounted from library/ubuntu
89ec57aea3bf: Mounted from library/ubuntu
a0c1e01578b7: Mounted from library/ubuntu
v0.1.2: digest: sha256:a3af21968d02123cafc659afc11bfd104942e33cb09bef52da1eec4fb8205327 size: 3472


work with tinkers without registerAllItems=true

TL;DR: How much work would it be to have Mekanism advertise the metals it provides such that Tinkers Construct will automatically include support for them?
I'm working on a modpack that contains both Mek and TC, and I've found that without the TC config setting registerAllItems=true, TC does not recognize that Mek is providing Tin and Copper, so , for example, the tin and copper variants of the tool forge are not available to craft, among many other issues.
If it could also support Osmium as part of this integration work, that would be even better.

If someone wanted to submit a TC support pull request I'd consider merging it, but in the meantime I have too many other issues to look at.

@aidancbrady Out of curiosity, do you have something you use to track
planned work, or is all in your head?

It should automatically register them (TiC catches oredict event for that). Wonder what's the bug is.

@aidancbrady @laz2727 @BrianEdmonds The reason why they are not automatically registered is that

you are registering them in init, whereas they are supposed to be registered in preInit. This is causing problems with other mods which depend on the oredicts, such as Tinkers Construct.
The same problem occurs with your copper, tin, and bronze.
(I discovered this problem early on when working on my addon mod PlusTiC and adding Mekanism integration, and had to manually register the metals as a workaround.)

(from my comment on #4463)

Created pull request #4465 to fix this issue.


Add support to Http.sys delegation to handle receiver restarts

This expands on #1503.
When using http.sys delegation, there are two processes involved, the delegator (the process creating the DelegationRule to delegate requests it receives) and the receiver (the process the delegator transfers requests to). It's possible that the receiver may restart independently from the delegator and ideally, delegation continues to work once the receiver has finished restarting.
The problem is the delegator has a handle open to the receiver's queue which prevents it from getting removed when the receiver shuts down. There are two possible issues due to this:

The receiver may fail to properly start because trying to create the queue will fail. Instead, the receiver needs to be smart enough to attach instead and properly re-configure the queue. The current ASP.NET core http.sys server does not support this (https://github.com/dotnet/aspnetcore/issues/40359), and I wouldn't expect most others to either since this is a newer concept.
If the receiver does attach and re-configure the queue, delegation will fail due to this bug: https://github.com/dotnet/aspnetcore/issues/40358.

To work around #2, we can check if the error received while delegating is ERROR_INVALID_PARAMETER, and if so dispose and re-create the DelegationRule.
Solving for #1 is less straightforward. There is no way to get notified when the receiver detaches from the queue. We could poll but that doesn't seem ideal. Another option would be to monitor for when the receiver process exits and when it does to dispose the rule so it can properly start back up.
I suggest we add support for consumers to "reset" a rule. This allows consumers to setup any type of monitoring they would like and then gives them the ability to force the DelegationRule to be rest.
I suggest adding the below public interface to allow for this:
public interface IHttpSysDelegator
{
    void ResetDestination(DestinationState destination);
}

Why pass in a DestinationState? If it's an out of process resource being monitored, I'd expect the inputs to that method to match those from the original config: the queue name and url prefix.

queue name and url prefix also make sense. I was debating which one to use or I guess we could support both?

I forgot to mention one other mitigation for #1 we could do within YARP. If we get a ERROR_FILE_NOT_FOUND error during delegation, we could reset the rule. This mitigation should probably be opt-in based on destination since it depends on receiver behavior. This mitigation may be "good enough" for some.
I was thinking of something like below. @Tratcher thoughts?
"Destinations": {
  "SampleHttpSysServer": {
    "Address": "http://localhost:5600/",
    "Metadata": {
      "HttpSysDelegationQueue": "SampleHttpSysServerQueue",
      "ResetDelegationQueueOnErrorNotFound": "true"
    }
  }
}

ERROR_FILE_NOT_FOUND is the error returned if you try to delegate while the destination is down? If you reset the rule immediately, won't that still prevent the destination from coming back up? And wouldn't you end up trying to reset the rule on every request until it worked?

Yes, that is the error you get if the receiver is not attached to the queue. The reset would dipose first and then try to re-create the rule. Re-creation will probably fail with the same error but we already re-try initialization for every request so once the receiver comes back, requests will start being delegated again.


DRAFT, New TestClientApp implementation

This commit [1] is a DRAFT proposal to get a new implementation of the current make_mocked_request.
This new approximation is formulated to be used for testing and keeping the interface
quite close to that one used by the test_client fixture where a full HTTP service is used.
As an example of how tests can be coded right now:
@pytest.mark.run_loop
@asyncio.coroutine
def test_test_client_app(loop, app):
    client = app.test_client()
    response = yield from client.get("/")
    assert (yield from response.text()) == "Hello, world"

Looking forward for comments and feedback.
[1] https://github.com/pfreixes/aiohttp/commit/7956a1a0d7fea9cf50fb8cbd7dcd2621f31877fd

Regarding make_mocked_request right now can be perceived as another way, rather than the test_client fixture, to test your views. IMHO the use of this object can give a false sensation of security - perhaps app routing is not take into account or make impossible formulate many situations - perhaps the URL params are not supported.
As a "side effect" it also can be seen as a replacement of the test_client fixture that tries to minimize the use of none related resources such as network [1] or reducing the time needed to load them.
To sum up, this DRAFT wants to open a discussion to get an unified test way to test the different views belonging to an aiohttp application.
[1] http://stackoverflow.com/questions/1257560/when-is-a-test-not-a-unit-test

Well, the example in http://aiohttp.readthedocs.io/en/stable/testing.html#faking-request-object is wrong.
The make_mocked_request is intended to be used for testing transport layer and may be useful in middleware tests.
I suspect the most part of unittests for aiohttp usage on application level will connect to real local database, perform real queries etc.
In other words for web-handler testing functional tests are more suitable than pure-unittests.
I suggest to use mock objects and derivatives like make_mocked_request as little as you can.

Well for integration tests or acceptance current test stack is plenty of util, but integration/acceptance are just tens over hundred of UTs regarding a well distributed amount of tests [1].
Have the amount of dependencies for you UTs, rather than the functional ones, as minimum as possible is always a good point for many raesons, even the network dependency.
I disagree about reduce the mock objects as little as you can, it is not an option it is a needed when you code each UTs, in that case the mock objects are mainly used to characterize the environment of your UTs and allowing to them get a deterministic behavior. Adding external dependencies UTs will become less deterministic.
The view layer, regarding perhaps a MVC model, where the aiohttps views live have to be covered with all of the needed tests. For example check mandatory fields, check error handling, and so on. Only with a good coverage the amount of functional tests will keep at some tens, you wont need to check all the cases regarding mandatory fields when these scenarios are already covered by your UTs.
I got your point about don't use make_mocked_request instead of use the full stack composed by a full aiohttp app and its dependencies, but IMHO this is not the right way to code the the test suite belonging to your aiohttp views.
Regarding the documentation, will be good to know the opinion of @jettify that was the author. I would like to get more opinions.
[1] http://martinfowler.com/bliki/TestPyramid.html

I have an answer but It's long enough.
First, why libraries like Django or Flask have a fake tool for performing send queries to views without touching network layer? That's because they are WSGI frameworks.
In WSGI world is impossible to run both tested and testing code in the same thread. Starting two threads is slow and cumbersome, especially when you need thread synchronization.
From other hand with asyncio co-existing testing and tested code in the same thread and even in the same function works perfectly fine!
Expenses for opening new localhost socket and starting server on it are very low. Passing test data through real network allows to avoid subtle bugs when test behaves a little bit different than real code.
Tornado framework use the same approach for testing as aiohttp has BTW.
What am I thinking about unitests, test isolation and retting rid of access to DB and network?
That's a brilliant concept.
But please write isolated tests not for web-handlers (views) but for business-logic objects. Do you have a separate layer for business logic handling, isn't it? On this layer you never need to cope with HTTP request and response but operate with entities like User, Product, Transaction, Account -- nothing from HTTP world.
Anyway, if you really need mocked approach for testing aiohttp server -- please do it outside of the main library. Feel free to push your tool into separate lib and publish it on PyPI if needed.


Clean up old mongo code

A lot of code depends on the mongodb model we originally developed. I think now that mongo is way overkill and we should use simple database or even dataframe models together with the filesystem for the images. Scalability might be an issue, but for the time being I anticipate microscopium to be single-machine-single-dataset deployments only.

PR https://github.com/microscopium/microscopium/pull/157 removed mongo from this project. But we have two mongo related files left behind in the test folders, they should be deleted as well:

microscopium/tests/testdata/mongodb/.gitkeep
microscopium/tests/testdata/mongodb/dummy_empty_file


Fix use of Start-Process http://bing.com

PR Summary
The change in #9202 introduced this regression by searching for a literal path.  In the case of http://bing.com, this results in an exception because the http: drive doesn't exist.  The fix is to catch this exception and let the search continue which will end up using ShellExecute to find a handler.
Since this specific case brings up the browser, I didn't add a test but validated it manually.
PR Context
Fix https://github.com/PowerShell/PowerShell/issues/9791
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-macos
Command Discovery tests.error cases.Get-Command "less "-PsPage %db?B of %DoesNotExist:"" should throw Drive not found
Expected an exception, with FullyQualifiedErrorId 'DriveNotFound' to be thrown, because The drive 'DoesNotExist:' should not exist, but no exception was thrown.
at <ScriptBlock>, /Users/vsts/agent/2.150.3/work/1/s/test/powershell/engine/Basic/CommandDiscovery.Tests.ps1: line 211
211:             {Get-Command -Name "less `"-PsPage %db?B of %DoesNotExist:`""} | Should -Throw -ErrorId 'DriveNotFound' -Because "The drive 'DoesNotExist:' should not exist"

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-windows
Command Discovery tests.error cases.Get-Command "less "-PsPage %db?B of %DoesNotExist:"" should throw Drive not found
Expected an exception, with FullyQualifiedErrorId 'DriveNotFound' to be thrown, because The drive 'DoesNotExist:' should not exist, but no exception was thrown.
at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Basic\CommandDiscovery.Tests.ps1: line 211
211:             {Get-Command -Name "less `"-PsPage %db?B of %DoesNotExist:`""} | Should -Throw -ErrorId 'DriveNotFound' -Because "The drive 'DoesNotExist:' should not exist"

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-linux
Command Discovery tests.error cases.Get-Command "less "-PsPage %db?B of %DoesNotExist:"" should throw Drive not found
Expected an exception, with FullyQualifiedErrorId 'DriveNotFound' to be thrown, because The drive 'DoesNotExist:' should not exist, but no exception was thrown.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Basic/CommandDiscovery.Tests.ps1: line 211
211:             {Get-Command -Name "less `"-PsPage %db?B of %DoesNotExist:`""} | Should -Throw -ErrorId 'DriveNotFound' -Because "The drive 'DoesNotExist:' should not exist"

In the case where there is no further path that works, does it still not make sense to throw the DriveNotFound exception?

@vexx32 currently, we fall through to using ShellExecute if the command is not found.  This is consistent with Windows PowerShell (and prior versions of PSCore6).  At that time, we leave it to the shell to find an associated app to run so there isn't an opportunity to rethrow.

It seems this PR also fixes my recently opened issue #9814 as well, it might be useful to add a test for this as well.

@bergmeister Can you file an issue to add a test for the the issue?   I don't think we should block this PR on that.

@PoshChan Please remind me in 1 hour.

@TravisEz13 I suggest to just edit the issue after the merge to add a test scenario for it.

@TravisEz13, this is the reminder you requested 1 hour. ago

@SteveL-MSFT I reviewed where this was regressed and I think we missed a few exceptions that should be handled.  I refactored your code to add the exception handlers back.  I remember discussing this but I think our conclusion was wrong.
Adding the exception handlers in the other two locations causes different regressions, so I have a wrapper for the helper that handles exceptions and use it where we need to handle exception and use the inner helper where we don't need to handle exceptions.

Verified the gcm global:help is consistent with 5.1

@PoshChan Please remind me in 1 hour

@TravisEz13, this is the reminder you requested 1 hour ago


Fix BiGG IDs

Main improvements in this PR:
This fix addresses Issue #124, which states that the model annotation files humanGEMMetAssoc.JSON and humanGEMRxnAssoc.JSON contain many BiGG IDs that do not correspond to any IDs on the BiGG Database.
The updateBiGGIDs script corrects/updates the metabolite and reaction BiGG IDs in the annotation files. The only IDs that could not be successfully updated are metabolite eumelanin, and reactions DM_Asn-X-Ser/Thr(ly) and sink_pre_prot(er), for which BiGG IDs do not exist (that properly correspond to the metabolite/reaction with which they are associated).
I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected devel as a target branch

Since this PR doesn't modify the model and only modify the JSON annotation files, which can be directly updated here.


Show Clear-button when selection is applied regardless org unit is truncated or forbidden

DE46040: AQD: load url with filter specifying courses current user cannot view is quirky

Functional Testing

[x] Test cases

[x] A user sees Clear-button if selection is applied. A selected org unit can be forbidden or truncated.

Security, devops, perf: N/A

UX and docs

[x] Demo

FYI @Brightspace/draco-vis

I've posted in Slack Considered and rejected solutions here


Fixed exception call in modules/mono/config.py

Fixed absent variable exception while trying to raise another exception.

The fix is good but the commit title should be more explicit than config.py. A commit title should be short (that part is fine ;)) but also descriptive, so that we can understand what a commit does when reading it.
I guess you've used the GitHub web editor which encourages such bad commit logs, so I won't bother you with a rebase, I'll merge it manually and edit the log myself.

Merged as 51a0a381.

Thank you!

Cherry-picked for 3.0.7.


Problem with forge version or with the hole modpack?

Hi @aidancbrady ,
long time not seen ^^.
EDIT: After some magic it seems now to be working (updated a few mods, reassigned some IDs). I'll edit it again, if error are still left otherwise I'll close this error self :)
Ok, that's all for now :).
Oh, last thing: Great work for v9 - looked the video and it's awsome <3

This had nothing to do with your forge version, the problem was that the version of minetweaker you were using wasn't up to date with the new Mekanism API.

Ok, then this is fixed now because I changed the mod-packs version to the correct one :) (will close it then).
Will be funny to setup the ore-processing again with the new images. Are there any changes made since v7/v8?


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage remained the same at 100.0% when pulling 999fd12a1613b042464d29edbb1657282bbe1572 on analysis-gOKPLk into a74976d36ce9171304999d20daad20a9df9c6bcf on master.

Coverage remained the same at 100.0% when pulling 999fd12a1613b042464d29edbb1657282bbe1572 on analysis-gOKPLk into a74976d36ce9171304999d20daad20a9df9c6bcf on master.

Coverage remained the same at 100.0% when pulling 999fd12a1613b042464d29edbb1657282bbe1572 on analysis-gOKPLk into a74976d36ce9171304999d20daad20a9df9c6bcf on master.


Github groups

We'd like to move completely off of dex to kubehook but our current issue is groups. How do we map groups in our github to an acl mapping kubernetes. In our case, we have a namespace we wanna restrict to members in a github group. Love the product!

Some notes from our setup, which might provide some insight:
Kubehook does not authenticate users. Instead it assumes it is running behind an
authenticating reverse proxy. Kubehook generates a JWT for the user specified
via a configurable HTTP header, in our case `X-SAML-Email`. This JWT also
includes a user's LDAP groups, which are passed via the `X-SAML-Groups` header.

We control that with the --user-header and --group-header flags, which are also bound to envvars:
KUBEHOOK_USER_HEADER=X-SAML-Email
KUBEHOOK_GROUP_HEADER=X-Saml-Groups

I don't believe there is a facility to e.g. mapping group names (say stripping / injecting a prefix). If patterned off of what we're doing, you might do something akin to:

Forward to Github for auth.
You've now got an OIDC token (I presume - haven't integrated with their auth setup myself).
A custom backend proxy that you write validates your OIDC token, implements your group matching / filtering logic.

Does that mean I should run 3 kubehook endpoints which generate kubecredentials with different acls and have nginx send to the correct kubehook? How do I control the acls that kubehook runs.

I shouldn't even need a proxy. I can just run 3 different ingresses for the 3 different groups I have. However, how do I limit the kubectl credentials that kubehook is printing in each different configuration?


LDAP binding fails with TLS enabled

LDAP binding without TLS is successful, but turning on Enable TLS Encryption fails with an error. I run into the same error if I also enable Skip TLS Verify
2015/09/21 03:49:19 [T] LDAP will use BindDN.
2015/09/21 03:49:19 [D] Using TLS for LDAP without verifying: false
2015/09/21 03:49:19 [...es/auth/ldap/ldap.go:93 SearchEntry()] [E] LDAP Connect error, example.net:LDAP Result Code 200 "": EOF
I have verified the LDAP server does support TLS by passing the -Z option used to "Start TLS request (-ZZ to require successful response)"
$ ldapwhoami -vvv -H ldap://ldap.example.net -x -ZZ
ldap_initialize( ldap://ldap.example.net:389/??base )
anonymous
Result: Success (0)
Gogs Version: <IP_ADDRESS>8 Beta

Thanks your feedback!
cc @SergioBenitez can you help on this?

@Unknwon Sure thing.
@variablenix It seems that you are conflating "StartTLS" with "LDAP over TLS". The former refers to an insecure LDAP connection being upgraded to a secure connection over TLS, while the latter refers to a connection to an LDAP server that is initiated via TLS. The LDAP implementation in Gogs only supports the latter: LDAP over TLS, otherwise known as "secure LDAP" or "ldaps". You'll need to configure your server to support ldaps if you wish to encrypt your traffic from Gogs to the server and vice-versa.

@SergioBenitez Thanks for the update. Maybe adding Start TLS v. ldaps:// can be added as a feature request so either method can be used. My understanding is LDAP over SSL or ldaps:// encryption method is deprecated. I can confirm binding over LDAPS does succeed.

@variablenix In my opinion, LDAPS is superior to Start TLS simply because (without too much thought, I've concluded that) Start TLS is susceptible to a downgrade attack. After some research, I've learned that this is indeed true and is termed "STRIPTLS". Further, there does not seem to be any consensus on whether Start TLS is preferred to simply using a TLS connection for LDAP specifically, and I've found no evidence that suggests that major LDAP servers will remove support for LDAPS. In fact, since LDAPS is simply LDAP over TLS, most servers require very little change to implement LDAPS, and so I see no good reason for not supporting LDAPS.
Personally, I'd recommend using LDAPS. I don't think adding Start TLS support to Gogs is a route we should take when LDAPS exists and is likely superior.

:beers:
Thank you both for discussion on this thread @SergioBenitez @variablenix :wink:

Maybe this issue should be reopened. It seems that LDAPv2 and ldaps have been deprecated since 2003. In addition, the gopkg.in/ldap.v2 library is LDAPv3 implementation that should support StartTLS. Any ldaps compatibility is there for legacy support.

@vilppuvuorinen Thanks your info!
If gopkg.in/ldap.v2 already supports StartTLS, I think the issue is solved by itself. Otherwise, nothing has changed.
So... can you offer help to test it?

I'm afraid I cannot provide any solid unit tests covering this issue. However, the func ldapDial(ls *Source) (*ldap.Conn, error) function could be modified to accommodate conditional/adaptive StartTLS promotion.
I could provide a pull request for this, but I don't know if the way I would implement this covers all bases. Extending models would be pretty much overkill at this point making some sort of trial and error alternative a good option. In addition, port number based optimization could make the implementation almost seamless in most setups.
When ldapDial is called with UseSSL set to true the port number should be checked to determine first protocol that is tried. ldaps uses port 636 by default making it a good first indication of the preferred protocol. Otherwise StartTLS is tried first. If the attempt with the preferred protocol fails the other protocol is tried instead.
Pseudo-code-ish example:
if UseSSL {
  if port == 636 {
    dialTLS()
    if err {
      dialStartTLS()
    }
  } else {
    dialStartTLS()
    if err {
      dialTLS()
    }
  }
}

Pros:

Zero configuration
No api/documentation changes
First try is successful in most setups

Cons:

Worst case is that both protocols are tried on every authetication

What do you think? Should I go ahead with a PR?

On the other hand. Openshift does have pretty compelling implementation for ldaps and StartTLS selection: https://github.com/openshift/origin/blob/89d213ab9a04acaaa8def766c5f3e5c8ebd953be/pkg/auth/ldaputil/client.go#L79

Looks like one comment is missing?

Yeah. I ended up deleting for some reason. Sorry about that.
However, the approach from Openshift should work, but it will break insecure ldap auth on some of currently running instances where insedure tls is not explicitly set. Running a migration toggling insecure TLS on when use tls is not checked could prevent this.

However, the approach from Openshift should wor

I'm confused somehow, shouldn't the work already be done by the ldap.v2 package?

The support is there, but StartTLS elevates the connection from regular one.
ldaps
con, err = ldap.DialTLS("tcp", l.host, tlsConfig)

ldap over TLS'
con, err = ldap.Dial("tcp", l.host)
err = con.StartTLS(tlsConfig)

In Openshift the insecure TLS flag is used to select correct protocol:
switch l.scheme {
	case SchemeLDAP:
		con, err := ldap.Dial("tcp", l.host)
		if err != nil {
			return nil, err
		}

		// If an insecure connection is desired, we're done
		if l.insecure {
			return con, nil
		}

		// Attempt to upgrade to TLS
		if err := con.StartTLS(tlsConfig); err != nil {
			// We're returning an error on a successfully opened connection
			// We are responsible for closing the open connection
			con.Close()
			return nil, err
		}

		return con, nil

	case SchemeLDAPS:
		return ldap.DialTLS("tcp", l.host, tlsConfig)

	default:
		return nil, fmt.Errorf("unsupported scheme %q", l.scheme)
	}

Enable TLS Encryption could be used instead of the scheme field and Skip TLS Verify instead of insecurefield. Current configuration parameters are sufficient, but the labels are a bit off.

Thanks @vilppuvuorinen !
Maybe it's a good chance to propose a PR?

That's what I was thinking. I'll try to cook up one.


How to treat punctation with non-existing data

Let's say I have an custom template that ends with the following code
,

If the entry has a volume then everything is fine and I get something like my address, vol4. But if no volume is specified, a superfluous comma is added at the end, i.e. my address, .
Is there a way to remove this comma?

In this case, I would move the comma in front of the volume since you only need it when volume is specified. See below:

,

Ok, this may work for most cases. Sometimes, a bit more control would be nice. For example, it seems to be possible to generate the following output:
address
address, pages
address, pages. volume
address, volume
`̀ ``
(because in your solution one would have to put the comma and the point in the `if volume` span).

[BibLaTeX](http://ctan.mackichan.com/macros/latex/contrib/biblatex/doc/biblatex.pdf) has a quite sophisticated algorithm (described in section 4.7.2-5), which may give some inspiration.

Okay, I believe the following solution works for this situation. More if/else statements can be added for more complex situations. Also I cannot access your link.

,

    .
    ,

Ok, that's a nice solution. It would be a bit more readable if a test like if notlast would be supported, i.e
<span class="if address"

    ,

    .

But for me, your solution is also fine and you can close this issue if you want.
Here the correct link to biblatex: http://tug.ctan.org/macros/latex/exptl/biblatex/doc/biblatex.pdf

I don't think I want to add another key term like notlast since the check for each if statement does not look ahead at future if statements. I could see the addition of or and and to the if logic so that the code looks similar to yours. This method would keep the logic in the designers hands:

    ,

    .

I don't know how much use this would get from people using bibtexjs.

Closing


Make bookmarks folder naming configurable

The bookmark folder name selection is very flakey at the moment. I think we should just make the folder name configurable. We could read all available folders and have users select b/w them. The empty state and the bookmark display could have that settings icon.

Done!


Support / documentation for Windows

At minimum, we should document setting up and using the Windows Subsystem for Linux, but I'd also like to support "real" Windows.  This is unfortunately a fairly big hassle, since node-gyp and Windows don't get along as well as they could, and running node on Windows is kind of awkward at the best of times.  Or maybe I'm just out of touch with the platform, so things feel harder than they should 😄
Notes on the Linux/windows install:

Enable WSL -  all following instructions are run from inside bash
Install dependencies: apt-get install build-essential g++ libssl-dev git
Install node: curl -sL https://deb.nodesource.com/setup_6.x | bash, then apt-get install nodejs
Install aleph: sudo npm install -g aleph (takes a while... it helps to add the -d flag to get verbose output)

Here's what I've been able to piece together so far for the "real Windows" install on a Windows 10 VM:

Install node from the official Windows installer.
Install git for windows.

Install C++ build tools:
Installation method depends on whether you have Visual Studio installed, although hopefully that will be fixed soon, and we can just recommend everyone use the windows-build-tools package.
If you do have Visual Studio, you need to ensure that you've installed  the Common Tools for Visual C++.  You can either re-run the installer, or open VS and try to create a new C++ project that targets Windows, which will open the installer for you.  Make sure the box for the Common Tools for Visual C++ is checked.  After the installation, open a Command Prompt or Git Bash and run npm config set msvs_version 2015
If you do not have Visual Studio installed, open a Command Prompt (or Git Bash) as an Administrator and run npm install -g --production windows-build-tools.

try to install aleph:

global installation seems to choke with a bunch of git errors; this can probably be resolved by running in an elevated shell, but for now I'm just trying to install to a local node_modules dir.
die trying to install node-webcrypto-ossl
probably die trying to build jq

So, I managed to get aleph to install on windows (outside of the linux subsystem) with some gross hacks, mostly related to building node-webcrypto-ossl.
Building node-webcrypto-ossl required downloading a 64-bit binary OpenSSL 1.0.2 package from here, installing it to c:\OpenSSL-Win64, then copying files from the installed location to a new folder.  At a cmd.exe prompt in some working dir (e.g. c:\Users\yusef\test):

make the directory structure node-webcrypto-ossl expects

md openssl\out32dll

copy openssl headers

xcopy /S /I c:\OpenSSL-Win64\include openssl\inc32

copy the static openssl lib we need to the place node-webcrypto-ossl will look for it

copy c:\OpenSSL-Win64\lib\VC\libeay32MTd.lib openssl\out32dll\libeay32.lib

resolve a build failure caused by tsc not being on the PATH

npm install -g typescript

install node-webcrypto-ossl, overriding the node-gyp variable openssl_root to point to the directory we setup (the %cd% expands to the absolute path of the current dir, like $PWD on unix)

npm install node-webcrypto-ossl --openssl_root=%cd%\openssl

Once I figured that out, I was able to clone aleph and build it with a couple changes:

download windows jq binary and stick it in ./bin to keep build-jq.js from choking (need to fix this)
change the build script in package.json from mkdir -p ./lib && babel --copy-files src -d lib to mkdirp ./lib && babel --copy-files src -d lib, which uses the (already installed) npm mkdirp tool instead of mkdir, since mkdir doesn't understand the -p flag on Windows.
delete the npm-shrinkwrap.json file (weird git error, not sure what's up there)
create the openssl dir as above
run npm install --openssl_root=<absolute-path-to-openssl-dir>

Then I could run npm link, and finally this (with concat running locally in WSL bash):
C:\Users\yusef\test\aleph>mcclient id
Peer ID: QmbVHyoG9AqNUaCpDXpph5RNsJY5e65MCHE5N5Pt1yzyDi
Publisher ID: 4XTTM8R4MRbqKKfGTWGinn5cAmrqjZ44VW6wJSZLF1d2n3MVR
Info:

All of this is to say that Windows support doesn't require that many changes, apart from the webcrypto stuff.  If / when that gets fixed, we should be able to support real Windows without too much fuss.


[Go Live][Jan 17]

Docs Build status updates of commit d606ce8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-together-mode.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/conversation-messages.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/send-proactive-messages.md
:white_check_mark:Succeeded
View

msteams-platform/bots/what-are-bots.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/apps-package.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/device-capabilities/browser-device-permissions.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/get-started-overview.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/m365-apps/extend-m365-teams-message-extension.md
:white_check_mark:Succeeded
View

msteams-platform/m365-apps/extend-m365-teams-personal-tab.md
:white_check_mark:Succeeded
View

msteams-platform/m365-apps/overview.md
:white_check_mark:Succeeded
View

msteams-platform/m365-apps/prerequisites.md
:white_check_mark:Succeeded
View

msteams-platform/m365-apps/using-teams-client-sdk-preview.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/overview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/dev-preview/developer-preview-intro.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-bots-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-csharp.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-javascript.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-nodejs.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-gs-spfx.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-meeting-content-bubble.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-meeting-token-generator.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-meetings-sidepanel.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-meetings-stage-view.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-send-proactive.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tab-device-permissions.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tab-with-adaptive-cards.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/authentication/auth-aad-sso.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-format.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-reference.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/dynamic-search.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/what-are-cards.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/add-outgoing-webhook.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/how-to/connectors-using.md
:white_check_mark:Succeeded
View

msteams-platform/webhooks-and-connectors/what-are-webhooks-and-connectors.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


RSocketClient: Allow payload in conn setup frame

RSocket supports including a payload in the initial connection frame when setting up a connection.
This is implemented in the rsocket-cpp client, so I'm bringing the js client up to feature parity.

Thanks @lexs good point.
I've updated it to do the same as metadata.


In terminal emulators, bash fails to render correct background color

From @Elderry on July 17, 2017 8:2
My Windows build number:  Microsoft Windows [Version 10.0.15063]
It seems that in many terminal emulators, after running a command that outputs colors to the terminal using bash, the background will become a strange gray or black. But the default Windows Console doesn't has this problem. Here are the examples:
Integrated Terminal of Visual Studio Code:

Integrated Terminal of Intellij IDEA:

Default Windows Console:

To provide more detail, here is my bash prompt:
BLUE='\e[1;34m'
GREEN='\e[1;32m'
RESET='\e[0m'
source $HOME/Projects/Personal/posh-git-sh/git-prompt.sh
PROMPT_COMMAND='__posh_git_ps1 "" "${BLUE}\w\n${GREEN}\u@\h${RESET} > "'

Copied from original issue: Microsoft/WSL#2344

From @zadjii-msft on July 17, 2017 16:35
I believe this is already fixed in Insider's builds - I believe it's a dupe of #1706

From @zadjii-msft on October 18, 2017 15:56
Hmm. That's certainly weird.
@Elderry Can you open a powershell window, and post a screenshot of the colors tab of the property sheet?

From @Elderry on October 18, 2017 5:50
@zadjii-msft I'm afraid this issue remains, today my Windows updated to: Microsoft Windows [Version 10.0.16299.19], and I reinstalled Ubuntu using Microsoft Store.

From @Elderry on October 19, 2017 1:25
@zadjii-msft Here it is:

From @zadjii-msft on October 19, 2017 15:22
@Elderry Okay, this is gonna sound crazy, but what happens if you switch the first and last values of the color table in the Powershell properties dialog, and instead choose the first color (now white) as your "Screen Background" and the last (now black) as the "Screen Text", then open a new vscode?

From @Elderry on October 23, 2017 2:1
@zadjii-msft I did as you say, nothing changes:

From @zadjii-msft on October 23, 2017 17:30
Okay shoot. I was hoping that might help. Can you try pasting this file into a file called 256color.pl and running it (with perl 256color.pl) in both the console window and the vscode window?

From @Elderry on October 24, 2017 1:30
It looks terrible in vscode's terminal:

From @zadjii-msft on October 24, 2017 16:1
Oh, that's not the issue I was mostly concerned about. I was more concerned about the white and black entries in the first 8 colors printed are reversed in VScode from what you'd expect.
I think I have an idea of how this happened. If you look in the registry, under Computer\HKEY_CURRENT_USER\Console, is ScreenColors set to 0xf0 (240)?
I think VSCode is using the console defaults, not the properties. So because your default color selection is Color00 (dark_black) text on Color15 (bright_white) background, and VScode changes 00->white and 15-> black, your "default" colors in vscode are white on black, even if the rest of the background is white.
If you really want black text on white for all of your terminals, then I'd just replicate VSCode's behavior in your defaults manually, and switch the first and last entries of the "Defaults" in the console settings.

From @Elderry on October 24, 2017 1:38
@zadjii-msft Seems it is an upstream issue caused by winpty referred here.

From @Elderry on October 25, 2017 2:16
@zadjii-msft You are right, my ScreenColors entry is set to 0xf0, and other things happen just like you say. I prefer to keep my current settings because switching entries will change the definition of my DARK_BLACK and BRIGHT_WHITE. Thank you for your time.
Now my problem is why vscode choose to changes 00->white and 15->black, even Intellij IDEA's integrated terminal does the same.

It seem this issued is fixed in windows 10 1803.

I tested it again and confirmed 1803 fixed part of this issue.

You can compare this capture to the above one, the mainly difference is that the black background no longer overflow. Though white and black entries are still reversed, the pain point for me no longer exists.

@Elderry oh ok thanks
But the color cube still broken in  3rd-party terminal simulators...
It seems that Windows doesn't provide enough API to get the 256 color information to let these simulators to paint the correct color

Correct, our API ReadConsoleOutput and friends doesn't provide the ability to read this information out of the screen buffer. VSCode uses WinPTY which scrapes this information out of our buffer with the console APIs.
We've been focusing on #57 instead to allow 3rd-party terminals to receive this information on a standard PTY stream like other platforms instead.

Thanks @Elderry for confirming that this is fixed in 1803.
I'm going to close this as resolved, @miniksa is right about the 256 color stuff.

I'm sad to say that this issue re-occurred in Windows 10 1809.

You can see that in VScode's terminal, there are white characters on black background, while this is reversed in 1803.
@zadjii-msft


[FEATURE] Persist Profile Type selection when navigating back from user's page

Description
Persist Profile Type selection when navigating back from user's page
https://user-images.githubusercontent.com/55010070/167561491-9e8b49bf-bf72-45d5-bdf3-69cf73595601.mov
Screenshots
No response
Additional information
No response

Great job!


Update the license headers in SDK

can we leave this as the last thing to do? right now we can do cherry pick from master to v3 for new fixes, as soon as you touch all the files (with updating header) cherry picking will become impossible.

@mbhaskar - what are we supposed to update them to?


Fixes #13 using @unlink for gc on concurrent requests

Fixes #13

@weierophinney I've wrap the unlink() with Zend\Stdlib\ErrorHandler::start() and Zend\Stdlib\ErrorHandler::stop(), please let me know if any something I missed.
Thank you.

@samsonasik Can you open this PR against develop please to ensure that travis passes?

@akrabat rebased against develop and change target repo to develop branch

@akrabat travis green \m/

Thanks, @samsonasik!


[DRAFT] Remove etc odbc deprecated module

Experimental removal to see what breaks

Looks like nothing on buildkite breaks (the Azure OMF failure is unrelated), but the deprecation comment says to wait until version 2.106

Please do not merge this. This PR is based on an incorrect premise.
The etc.d.odbc.* modules should not be deprecated, and conversely, there should not have ever been core.sys.windows.sql* modules, those should be deprecated instead.
ODBC is not a Windows specific system. Both MacOS and Linux fully support ODBC and all major DB vendors support ODBC on all three platforms. MySql/PGSQL/MSSQL/Oracle, all maintain supported ODBC drivers for the above platforms, even cloud DB's such as Amazon Redshift maintain supported ODBC drivers for all three systems. And in some cases, as with MSSQL, ODBC is the only way to access the database on Linux. I currently have a non-public project that uses ODBC on Linux to access MSSQL.
Additionally, database drivers of any kind do not belong in DRT as they are not germane to the runtime of every D app.

Resurrecting this. I have posted two new PRs. The first PR deprecates ODBC in DRT. The second puts ODBC back into Phobos and updates it to support non-Windows systems.
DRT: https://github.com/dlang/dmd/pull/15560
Phobos: https://github.com/dlang/phobos/pull/8804

@Dany12LU The above two referenced PRs have been merged. This PR has been superseded and can be removed.


LICENSE file missing some templating information

This is a trivial issue. Your license file is missing some template info.

We check other projects with same license and seems it's ok to keep as it is (e.g. https://github.com/kubernetes/kubernetes/blob/master/LICENSE#L190).
We add LICENSE header to every single source code file, which is good enough.
Thanks.


Fixed grammar issues

Thanks for the PR @acidshards! Would it be possible to edit the original source file at https://github.com/elastic/elasticsearch-net/tree/6.x/src/Tests/ClientConcepts/LowLevel/GettingStarted.doc.cs from which the documentation is generated? Also, have you signed the CLA?

Hi @acidshards, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Hi @russcam, no problem, I will edit the source file after the weekend.
Hi @karmi, I deleted the e-mail used in my Git commit from Github because I couldn't access it any more. Maybe we should close this pull request without merging and I will create a new one together with the changes to the source file?

Sounds good to me @acidshards , feel free to close


pio train error

"pio build" is successfully executed on my machine. But when I tried "pio train", an error occurred to me, the log is as follows:
[INFO] [Engine] Extracting datasource params...
[INFO] [WorkflowUtils$] No 'name' is found. Default empty String will be used.
[INFO] [Engine] Datasource params: (,DataSourceParams(myapp1,None))
[INFO] [Engine] Extracting preparator params...
[INFO] [Engine] Preparator params: (,Empty)
[INFO] [Engine] Extracting serving params...
[INFO] [Engine] Serving params: (,Empty)
[WARN] [Utils] Your hostname, yang resolves to a loopback address: <IP_ADDRESS>; using <IP_ADDRESS> instead (on interface wlan0)
[WARN] [Utils] Set SPARK_LOCAL_IP if you need to bind to another address
[INFO] [Remoting] Starting remoting
[INFO] [Remoting] Remoting started; listening on addresses :[akka.tcp://sparkDriver@<IP_ADDRESS>:59618]
[WARN] [MetricsSystem] Using default name DAGScheduler for source because spark.app.id is not set.
[INFO] [Engine$] EngineWorkflow.train
[INFO] [Engine$] DataSource: org.template.recommendation.DataSource@41d16cc3
[INFO] [Engine$] Preparator: org.template.recommendation.Preparator@649f25f3
[INFO] [Engine$] AlgorithmList: List(org.template.recommendation.ALSAlgorithm@bf75b5c)
[INFO] [Engine$] Data sanity check is on.
[INFO] [Engine$] org.template.recommendation.TrainingData does not support data sanity check. Skipping check.
[INFO] [Engine$] org.template.recommendation.PreparedData does not support data sanity check. Skipping check.
[WARN] [BLAS] Failed to load implementation from: com.github.fommil.netlib.NativeSystemBLAS
[WARN] [BLAS] Failed to load implementation from: com.github.fommil.netlib.NativeRefBLAS
[WARN] [LAPACK] Failed to load implementation from: com.github.fommil.netlib.NativeSystemLAPACK
[WARN] [LAPACK] Failed to load implementation from: com.github.fommil.netlib.NativeRefLAPACK
[ERROR] [Executor] Exception in task 0.0 in stage 44.0 (TID 152)
[ERROR] [Executor] Exception in task 3.0 in stage 44.0 (TID 155)
[ERROR] [Executor] Exception in task 2.0 in stage 44.0 (TID 154)
[ERROR] [Executor] Exception in task 1.0 in stage 44.0 (TID 153)
[WARN] [TaskSetManager] Lost task 3.0 in stage 44.0 (TID 155, localhost): java.lang.StackOverflowError
at java.lang.Exception.(Exception.java:102)
at java.lang.ReflectiveOperationException.(ReflectiveOperationException.java:89)
at java.lang.reflect.InvocationTargetException.(InvocationTargetException.java:72)
at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
Any help, thanks.

Did you resolve this?

@steven-haddix  I solved this with the help of this page http://predictionio.incubator.apache.org/resources/faq/.
You can have a try.

@steven-haddix to resolve at this ""com.github.fommil.netlib" % "all" % "1.1.2" pomOnly()" to your dependencies if you are running on sbt.

If this is required, how about a PR to change it for everyone?


Improved Apache Drill and JSON/CSV documentation

Added specific links for running Drill against Azure Blob Storage
Added link to described a solution to query JSON files right from Azure SQL and another one to automatically import CSV files into Azure SQL as soon as they are dropped into an Azure Blob Store

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/data-guide/scenarios/interactive-data-exploration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/data-guide/scenarios/csv-and-json.md
:white_check_mark:Succeeded
View

docs/data-guide/scenarios/interactive-data-exploration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/data-guide/scenarios/csv-and-json.md
:white_check_mark:Succeeded
View

docs/data-guide/scenarios/interactive-data-exploration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/data-guide/scenarios/csv-and-json.md
:white_check_mark:Succeeded
View

docs/data-guide/scenarios/interactive-data-exploration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks! :)

Thanks! :)


[camera_windows]  Error occurs when executing startVideoRecording: PlatformException(camera_error, The data specified for this media type is invalid, inconsistent, or not supported by this object., null, null)

What package does this bug report belong to?
camera
What target platforms are you seeing this bug on?
Windows
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
 camera_windows: 0.2.1+9

Steps to reproduce
The error occurs when executing await CameraPlatform.instance.startVideoRecording(_cameraId);
Expected results
should start recording
Actual results
I get the error: [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(camera_error, The data specified for this media type is invalid, inconsistent, or not supported by this object., null, null)
I am using exactly the example from https://pub.dev/packages/camera_windows/example and a logitech webcam
Code sample
Code sample
  Future<void> _toggleRecord() async {
    if (_initialized && _cameraId > 0) {
      if (_recordingTimed) {
        await CameraPlatform.instance.stopVideoRecording(_cameraId);
      } else {
        if (!_recording) {
          await CameraPlatform.instance.startVideoRecording(_cameraId);
        } else {
          final XFile file = await CameraPlatform.instance.stopVideoRecording(_cameraId);
          _showInSnackBar('Video disponible: ${file.path}');
        }

        if (mounted) {
          setState(() {
            _recording = !_recording;
          });
        }
      }
    }
  }

Screenshots or Videos

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
 [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(camera_error, The data specified for this media type is invalid, inconsistent, or not supported by this object., null, null)

Flutter Doctor output
Doctor output
$ flutter doctor -v
[√] Flutter (Channel stable, 3.13.9, on Microsoft Windows [Versi¢n 10.0.19045.3930], locale es-ES)
    • Flutter version 3.13.9 on channel stable at C:\Users\Sklum\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (3 months ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\Users\Sklum\AppData\Local\Android\sdk
    • Platform android-34, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.5.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.5.33627.172
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[√] VS Code (version 1.85.2)
    • VS Code at C:\Users\Sklum\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.80.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Versi¢n 10.0.19045.3930]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 118.0.5993.120
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 120.0.2210.121

[√] Network resources
    • All expected network resources are available.

• No issues found!

Hi @in-rivars
I checked this with my Genius FaceCam on Windows using plugin example but it can record video well without this issue.
Could you also try running plugin example and confirm if the issue persists on your end?
I also see you are using an old Flutter version, you can try upgrading and using the latest Flutter stable channel (the current version is 3.16.8) and check this again.
Please share your logitech webcam info (model) as well. Thanks!

Hi, I have tried updating flutter and running the example plugin and I still get the same error. The camera I have is https://www.logitech.com/es-es/products/webcams/streamcam.960-001281.html

###New Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.16.8, on Microsoft Windows [Versi¢n 10.0.19045.3930], locale
    es-ES)
    • Flutter version 3.16.8 on channel stable at C:\Users\Sklum\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 67457e669f (6 days ago), 2024-01-16 16:22:29 -0800
    • Engine revision 6e2ea58a5c
    • Dart version 3.2.5
    • DevTools version 2.28.5

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\Users\Sklum\AppData\Local\Android\sdk
    • Platform android-34, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.5.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.5.33627.172
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[√] VS Code (version 1.85.2)
    • VS Code at C:\Users\Sklum\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.80.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Versi¢n 10.0.19045.3930]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 118.0.5993.120
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 120.0.2210.121

[√] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for checking that. Looks like this occurs on a specific camera.

So, for now with this camera there is no solution, right?

So, for now with this camera there is no solution, right?

The issue then will be prioritized by a domain team. You might want to take a look at this: How issue prioritization works

PlatformException (PlatformException(camera_error, Failed to initialize video preview, null, null))

This is another issue at https://github.com/flutter/flutter/issues/140014

fyi @bparrishMines

I have the same issue and have open the thread. It seem like there are also other like me. https://github.com/flutter/flutter/issues/143151
It seem like most generic usb webcam are working fine, I have the same problem with Elgato Facecam Pro, OBSBOT Tiny, and insta360 Link.