Unclear how to migrate to cephadm

Bug Report
What happened:
There is a warning in the root README that indicates these Ansible roles are effectively deprecated, in favour cephadm:

NOTE: cephadm is the new official installer, you should consider migrating to cephadm.
The project is still maintained for the time being but it is encouraged to migrate to cephadm.

Unless I'm missing something (possible, as I've only just started looking at deploying Ceph!), cephadm is a CLI tool, and not an Ansible module/role. It is therefore unclear how one should use (or migrate their existing setup to use) cephadm with Ansible, as an alternative to the roles in this repository.
What you expected to happen:
A link alongside the deprecation warning to the alternative, non-deprecated Ansible roles/modules that are backed by cephadm/the latest supported libs. If these do not exist, it could be useful to make that clear (e.g. it is temping to think ceph/cephadm-ansible might be the alternative - but I don't think it is. There is also a guide on IBM's website about cephadm-ansible modules that wrap cephadm and ceph orch but I can't find any other trace of them so I assume they're not freely available).
It would be unfortunate if using command/shell with cephadm is the official alternative, as this repository looks like it provides a very extensive selection of Ansible roles!

Noting for anyone else interested in the cephadm-ansible modules referenced on Red Hat's/IBM's website - their support let me know that:

The product is open source but it is not freely distributed. To access Red Hat Ceph Storage on Red Hat Enterprise Linux, you will need to have access to the paid subscription.

Hi @colin-nolan
RH/IBM decided to deprecate ceph-ansible in Ceph 5 (Pacific) in favor of cephadm. So far, upstream ceph-ansible is still maintained and can be used to install latest versions of Ceph.
As Ceph 4 is still supported downstream till April 30, 2025, we will continue fixing bugs until that time (mainly in rolling_update,  cephadm-adopt playbooks) but also improve roles and support latest versions of Ceph.
Regarding cephadm-ansible it is available here (https://github.com/ceph/cephadm-ansible). It covers some feature still not available in cephadm. Feel free to create Issues/PR against cephadm-ansible to improve it.
For upstream documentation you should take a look here https://docs.ceph.com/en/latest/ instead of the IBM/RH documentation.
Hope this helps


Fix memory leak reported by ASAN.

If params is not used in a new macro then it should be deallocated.
Signed-off-by: Dibyendu Majumdar<EMAIL_ADDRESS>

Thank your for the patch, Dibyendu.  I've merged it into the main line.


revert literals and fix miniupnpc>1.9

miniupnpc api_version>=14 requires ttl arg for upnpDiscover()

Merged into master.


Problem submitting a form

Hi, I am defining a pjax container in that way:
$.pjax({
            async: false,
            push: false,
            url: "http://theurl.com/form",
            container: ".pjax-component[data-pjax-component-id='123']",
            timeout: 30000,
        });

It loads well the url (which contains a form), and I am implementing the form submission in that way:
// trap form submit
$(document).on('submit', ".pjax-component[data-pjax-component-id='123'] form", function(event) {
    event.preventDefault(); // stop default submit behavior
    $.pjax.submit(event, ".pjax-component[data-pjax-component-id='123']");
});

When the form is sumitted it reloads the whole page. I track the problem to the handleSubmit() function, it gets a null options value, and the optionsFor() function returns an options object with "http://theurl.com/#" as url value, when it should be "http://theurl.com/form", in fact, if I add the line:
options.url = "http://theurl.com/form";

to the handleSubmit() function, it works well (only for that container, of course)

I may be seeing something similar; the POST to the back-end server contains no form data.  This is in Chrome; I'm not setting any pjax options like OP.  My submit code is very similar:
$(document).on('submit', 'form[data-pjax]', function(event) {
     if ($('#theform').validator('validate').has('.has-error').length == 0) {
           $.pjax.submit(event, '#key', {type: "POST"});
     }
});

and my form declaration looks like this:
 <form id="theform" class="form-horizontal" data-toggle="validator"
            role="form" method="post" data-pjax>

The server does receive the POST and the query has the expected headers; it's just that the post contains no form data, at all.
@cccaballero, did you ever figure out your issue?

I found a (really hacky) solution:  #539 .  That issue refers to old browsers, but at the moment the pjax bug that forces the need for the hack also appears to be affecting the most current (at the time of this writing) version of Chrome.  Adding the following code inside the $(document).on('submit', .... function causes pjax to begin correctly submitting form data:
/* BEGIN HACK */
  var formDataBkp = window.FormData;
  window.FormData = undefined;
  $("#theform").on("pjax:beforeSend", function (options, xhr) {
     window.FormData = formDataBkp;
  });
/* END HACK */

Hope this helps somebody else, and looking forward to the fix that allows us to remove the hack.


Fix race condition for composite monitors

This fixes #52 by making sure all values are read at the same time

The failing tests very timing issues so merged anyway, this should be fixed in another PR


Uncrafting copper ingot gives Tome of Alkahestry

Minecraft version & Mod Version: 1.12.2 & Cyclic-1.12.2-1.14.9
Single player or Server: Server
Describe problem (what you were doing / what happened): Uncrafting copper ingot gives Tome of Alkahestry (from Reliquary), which is definitely not something it should be outputting, should fail instead.

What modpack are you playing?
Is there a recipe where you craft a Tome of Alkahestry into a copper ingot?
The grinder just looks up existing recipes in forge registry.
Ill look into it a bit, but best solution is probably just adding the Tome to blacklist config.  (config file where it says "Blacklists and other tweaks for the Uncrafting Grinder")

When I install just a few mods the uncraft correctly finds the recipe, it matches the crafting.  If youre in a big modpack there could be other scripts or things going on maybe

It's a big modpack on a private server.  I can zip up the mods if you wish.  Also I forgot to mention it does it when 2 copper ingots are put in.  And I'll go ahead and blacklist Tome of Alkahestry, but just letting you know that it does that so you can blacklist it in an update I guess

Yep thanks for the report as always!


Cleanup, updates & add NodeJS 20

Changes

[x] Remove unsupported Debian versions
[x] Remove unsupported NodeJS versions
[x] Add more recent Debian versions
[x] Add NodeJS 20
[x] Other small updates (see commits)

Hi @Unitech, is there any chance you could take a look at this when you have time & get these images built & released?

@Unitech could we get this reviewed and merged? Node 20 is the latest LTS as of Oct 2023, no one can move to this new version using this image without it being updated.


⚠ Jenkins Plugins Artifactory has degraded performance

In 5508e6d, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1296 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 99a3642 after 12 minutes.


Upload test results to database in framework level

Now test results are uploaded by each case, it should be handled in framework level

@lizzha can you please close this one if the PR is enough, or create a new feature addition for the other test to move to the new model?

The PR is only a pilot. Performance cases and nested cases need to be updated to use the new model.

Close non-P0 issues


Implemented screen protection

Implemented screen protection against:

prints;
protection on the recent apps;
protection against overlay attacks


Revert "Enhancements and Refactorings to Support New iPhone Features and Improve Accuracy"

Reverts chlee1001/react-native-iphone-screen-helper#6

The react-native-device-info library was tested on a project in use and failed to consider an unused project.
So I restored it to its original state


feat: re-add totals and limits

Changes
Re-add totals and limits removed in #2625 due to performance issues.
Uses separate queries instead of annotate(Count(..., distinct=True)) to avoid further performance issues.
How did you test this code?
Updated the test from the previous iteration to ensure its verifying that the numbers are correct. I've been unable to really reproduce the performance issues we saw in production, but there is a lot less black magic going on with this approach. The additional queries should have a negligible impact on performance.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (1514bf7) 95.44% compared to head (7010811) 95.44%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2631   +/-   ##
=======================================
  Coverage   95.44%   95.44%
=======================================
  Files         976      976
  Lines       27319    27327    +8
=======================================
+ Hits        26074    26082    +8
  Misses       1245     1245

Files Changed
Coverage Δ

api/projects/views.py
94.16% <ø> (-0.15%)
:arrow_down:

api/projects/serializers.py
100.00% <100.00%> (ø)

...pi/tests/unit/projects/test_unit_projects_views.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add configurable default-api-timeout-ms

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.07 :tada:

Comparison is base (065f64c) 60.37% compared to head (73b4ea1) 60.45%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   60.37%   60.45%   +0.07%
==========================================
  Files         152      152
  Lines        3276     3277       +1
  Branches      106      101       -5
==========================================
+ Hits         1978     1981       +3
+ Misses       1298     1296       -2

Impacted Files
Coverage Δ

.../src/main/scala/surge/kafka/KafkaAdminClient.scala
94.11% <100.00%> (+0.36%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chuangmi.camera.27a02 - no camera preview

Hello,
yesterday i received the chuangmi.camera.27a02 ordered from AliExpress. I add the camera through integration. All sensors are working fine but the preview of the camera is not working. I cannot access the actual camera......
Any suggestion what is wrong?

There's nothing I can do !


Designed project structure

Created a structure for the project where all robot subsystems are written as singleton enumerations implementing a subsystems interface. This is mostly to enforce single instantiation of the robot and other organizational classes.

Received Sean's verbal approval. Bypassing protections.


Give devise logged in users a pretty dashboard

and maybe give them a little hello, heres how to get started prompt as well.

Controller created, dashboard view created


[BUG] Compilation error on defining CHIP_DEVICE_CONFIG_DEVICE_PRODUCT_ID outside test value range

Reproduction steps

Add #define CHIP_DEVICE_CONFIG_DEVICE_PRODUCT_ID 0x7FFF (or any value outside [0x8000, 0x801F]) for an example app (say in tv-casting-app's CHIPProjectAppConfig.h)
Try building the example app.

Expected: able to compile the app
Actual: Compilation failure with the following errors:
Undefined symbols for architecture arm64:
  "chip::DevelopmentCerts::kDacPublicKey", referenced from:
      chip::Credentials::Examples::(anonymous namespace)::ExampleDACProvider::SignWithDeviceAttestationKey(chip::Span<unsigned char const> const&, chip::Span<unsigned char>&) in libTvCastingCommon.a(libCredentials.DeviceAttestationCredsExample.cpp.o)
  "chip::DevelopmentCerts::kDacPrivateKey", referenced from:
      chip::Credentials::Examples::(anonymous namespace)::ExampleDACProvider::SignWithDeviceAttestationKey(chip::Span<unsigned char const> const&, chip::Span<unsigned char>&) in libTvCastingCommon.a(libCredentials.DeviceAttestationCredsExample.cpp.o)
  "chip::DevelopmentCerts::kDacCert", referenced from:
      chip::Credentials::Examples::(anonymous namespace)::ExampleDACProvider::GetDeviceAttestationCert(chip::Span<unsigned char>&) in libTvCastingCommon.a(libCredentials.DeviceAttestationCredsExample.cpp.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Bug prevalence
Everytime
GitHub hash of the SDK that was being used
eff5773ed3f2352a769c334c2e2630388e7bad9d
Platform
core
Platform Version(s)
No response
Anything else?
No response

Looks resolved


[Canary]: Tab tear-off leads to crash

Windows Terminal version
1.21.991.0
Windows build number
10.0.22631.0
Other Software
No response
Steps to reproduce

Open Windows Terminal Canary.
Try tearing off a tab.

Expected Behavior
The tab is opened in a new WT window.
Actual Behavior
WT crashes.

In debug build on main, Closing a tab with the "❌" button also leads to the same crashing behavior. This is not reproducible on the latest Canary build (maybe due to release vs debug build?)

Exception: Unhandled exception at 0x00007FFDD7FBEBDF (ntdll.dll) in WindowsTerminal.exe: Indirect call guard check detected invalid control transfer.

Indirect call guard check detected invalid control transfer.

Hmm, this is just a hunch, and I apologize for your SSD 😣, but could you try cleaning the entire solution and building it again?

Some of us had this issue happen before and back then it could be resolved with a clean build. My suspicion is that the build system doesn't properly invalidate some compiled objects which results in mismatched vtables.

@lhecker Thanks for the info. I'll try doing a clean build next time.
I'm also curious why Canary might crash on tab tear-off 🤔

FWIW I can repro the tear-off crash on my own canary 21.991 (and after upgrading, my 21.1011) here as well. So, it's definitely not just a clean build problem.


[FRONTEND][TENSORFLOW] NCHW layout support (Resnet V1/V2).

NCHW end to end support.
Resnet V1/V2 work fine, added an end to end test case.
Mean, FusedBatchNormV2 ops added for Resnet.

Just to confirm this, is there anything special about NHWC support? Did you try to convert it on the fly to NCHW ?

#1718 does on the fly conversion of NHWC to NCHW  (convolution and pool) to compile for cuda target.
This PR is to support native NCHW models (like resnet which is NCHW across the layers.)

cc @masahi @siju-samuel @yzhliu welcome to review.

I see, ideally, we want to let the front end just to simple translation and apply followup passes in the IR to transform the layout when necessary


Align GEDI_L2A to VEDA notebook guidelines

EPIC
#240
Description
The GEDI L2A Product Tutorial notebook should be reviewed using the this guidance and includes the following components:

Style
Rendering Information
Notebook Sections

Acceptance Criteria (Tasks):

[x] Style should be consistent with guidance provided
[x] Rendering information should be complete and accurate. If there is no author/date information available, consult MAAP leads @wildintellect @abarciauskas-bgse for guidance
[x] Ensure notebooks include the recommended standard sections

Additional Task(s):

[x] remove STAC component of tutorial

In progress - PR should be ready later today or tomorrow

PR: https://github.com/MAAP-Project/maap-documentation/pull/294

Approved and merged


Info section doesn't show

https://github.com/aramis-lab/clinicadl_handbook/blob/9b30382d68f0ff356589cd4cfdcace1154ba8f61/notebooks/preprocessing.ipynb#L321-L329
Those lines don't show in:
https://aramislab.paris.inria.fr/clinicadl/tuto/2023/html/notebooks/preprocessing.html

Good catch ! Seems to be the case also for:
{info}
You need to have performed the t1-linear pipeline on your T1-weighted MR images.

Any idea why?

Any idea why?

Nope, I don't see anything problematic and the warning blocks seem to work as expected... 🤔
Maybe we could try to replace "info" with "note" to see if it works better (see the doc of jupyterbook here).

Yes I will try, but how is it possible to have a preview before the PR is merged to main?

Ok thanks!


Update styling of buttons

Hi
I wanna work on this . Please assign this to me.

Can you please assign me this task.

hey!! @chetanbhasney02
pls assign this issue to me .

Heyy please assign me this issue ,as I already created a full website so I know how to do this.


Improve the error message, when user trying to use connector defined on same file with package name:connector name

Steps:

Define connector as per below

package asanka.connectors;

import ballerina.net.http;
import ballerina.util;

connector etcd (string etcdURL, string username, string password, string apiVersion) {

Try to use the connector as below in a service define on the same file

@http:BasePath ("/etcdUsesample")
service stockService {

    @http:POST
    resource stock (message m) {
      http:ClientConnector stockEP = create http:ClientConnector("http://localhost:9000");
      connectors:etcd etcdConnector = create connectors:etcd("http://<IP_ADDRESS>:2379", "root", "test123", "v2");

Invoke the service as per blow.

Issue:
Error message does not give clear idea on what is the issues
Note: Attached full code here
etcdConnectorUsageService.txt

Actually, the error message is correct since there are no imported packages connectors.


Concept Map: Write up high-level  content summaries and how they relate to each other

dependency graph of all 10-20 min chunks in this lecture
explicit definitions of learning goals for each chapter / chunk

--> make this more modular, more easily extensible, improve didactic structure
(kind of like a header file for a C program.)
(should ideally also include -- at some point -- mathematical / prob-theory / programming prerequisites for each chunk)

Can we generate this automatically from the lines in slides:
%! Includes:

?

Can we generate this automatically from the lines in slides:
%! Includes:

?

... that would be the hope, yes.


Fix compilation issues on Java / JDK 17 (latest LTS release)

Description
Recently on the dspace-community list it was noted that DSpace 7 doesn't compile with JDK 17 (latest LTS release).
This PR fixes those compilation issues by updating the following:

Upgrades us to latest version of errorprone which is compatible with JDK 17

Also some minor code fixes to resolve new errorprone errors reported after this upgrade. See 52a8edc7d62fb5ef8a2186144573338c73d02277

Upgrades us to more recent version of mockito-inline to ensure it is also compatible with JDK 17
Updates our CI build/test process to run our tests BOTH for JDK 11 and JDK 17  (Optionally, we could remove this as needed, but I added it to prove that the tests work for both JDK 11 and 17.)

I have NOT fully tested all functionality with JDK 17 at this time.  This PR simply ensures everything compiles and tests all seem to pass (at least locally).

NOTE TO REVIEWERS:  Because this PR renames/changes the CI build process, it won't ever build the older "required" tests (meaning this PR will never get the green checkmark).  However, you can see that all the new tests succeed for both Java 11 and Java 17 here: https://github.com/DSpace/DSpace/actions/runs/1668711004

I've been testing the backend with JDK 17 over the past few days, and so far, I've not had any issues running this PR + openJDK 17 + Tomcat 9. It's all working the same as JDK11.
So, this small PR seems to add support for JDK 17 to DSpace 7.x

In today's meeting, @abollini pointed out that we may want to consider only building on one version of Java (even if we support multiple), because GitHub actions has a free tier limit of 2,000 build minutes per month: https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions  Building on both JDK 11 and JDK17 will double the amount of minutes we are using per month, which could send us near that limit.
So, I'll refactor the CI changes in this PR to only build on JDK 11 again... then we can merge this and updated documentation that JDK 17 also works.

I just rebased this on latest main, just as a final verification that these tests all still pass (they should).  Once this passes CI, I'll merge immediately with +1 approval.


Fixed #91.

Fixed move construction algorithm on type erased defer_event.

The pull request includes subtle code style modification on the line 1274. Last time I remove the modification. Because it is nothing related to the fix.
Here is my process to update sml code.

Modify individual files to fix.
Execute pph.sh at the include directly as ../tools/pph.sh
Then pph.sh updates sml.hpp

The result of the process, the line 1274 in the sml.hpp is modified.
Maybe someone edit only sml.hpp and commit it.
It doesn't change the meaning of the code, so I include it to avoid reverting the line 1274 every time.

Changes Unknown when pulling 0aa024e92d163ef0ff3542571fff9e1bea9b86e8 on redboltz:fix_91 into ** on boost-experimental:master**.

Awesome, thank you @redboltz very much, great job!


request.location is nil in 1.3.5

Accessing the request.location object from a Sinatra GET handler (which returns a Sinatra::Request, which inherits from Rack::Request), throws an error.
This works fine in 1.3.4
11:22:55 web.1  | 2016-05-30 11:22:55 - NoMethodError - undefined method `location' for #<Sinatra::Request:0x007ff32e027f78>:

Thanks! And sorry about that. This was caused by #1041. The fix should be simple.

Just released 1.3.6, which should fix this.

Awesome, thanks!


Loss do not decrease.

Hi, I have some problems with affine model training. I use the affine model for skull registration, but the loss does not decrease during training. What parameters do I need to adjust to solve this problem?  Thanks for your reply.

I've come across a similar problem before. It's probably related to the NCC loss from VoxelMorph:
https://github.com/junyuchen245/TransMorph_Transformer_for_Medical_Image_Registration/blob/9c34ac92ec4626c88714fd2336aaff59c163e626/TransMorph/losses.py#L211C7-L211C14
, which doesn't seem to descrease with Pytorch versions later than 1.9.1. Try exploring alternative loss functions or take a look at my implementation of NCC using a Gaussian kernel, available here:
https://github.com/junyuchen245/TransMorph_DCA/blob/09e32758e5788a358c8543ca61fe0cc76e75b0dc/OASIS/losses.py#L9C7-L9C16


UnicodeEncodeError: 'charmap' codec can't encode character

What happened?
some subtitle to convert from vtt to srt
error
UnicodeEncodeError: 'charmap' codec can't encode character '\u010d'
Expected Result
all sub its true
Branch
master/main
What operating systems are you seeing the problem on?
Windows
Relevant log output
[udemy-downloader] [process_caption:1301] ERROR:     > Error converting caption
Traceback (most recent call last):
  File "\main.py", line 1296, in process_caption
    convert(lecture_dir, filename_no_ext)
  File "\vtt_to_srt.py", line 17, in convert
    srt.write(
  File "Python\Python39\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u010d' in position 86: character maps to <undefined>

Other information
No response

I'm going to close this in favor of #98.


Error running CEST modelling when ROI is 2D and data is 3D

This was an issue in Fabber recombination which has now been fixed

v0.9.1


Path and event variable replacement in custom command

Resolves #11
Used {path} as the replacement string instead of mimicking env var syntax like $path, because the latter did not work for me using zsh. Open to changing the format to anything else that works if there are any preferences to do it differently.

Did you try to pass the path as an env option for child_process.spawn? See https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options
Templating works, but sounds like that could be achieved easier by passing inside the env object.

No, but it wouldn't work since zsh has already done the env var substitution by the time the chokidar-cli bin has it in argv.
Plus it doesn't seem wise to clobber the normal meaning of $PATH

Ok now I got it why it wouldn't work. Yeah as you said, in any case reusing the standard $PATH wouldn't be good.

I added the documentation of command var replacement to cli --help. I'll merge this to master and release it.

Now released in 1.2.0: https://github.com/kimmobrunfeldt/chokidar-cli/releases/tag/1.2.0


allow 2 * x + 1

Disable the lint rule that warns you if you mix multiplication and addition without parentheses. That seems stylistic & thus too strict for the goals of this project, especially if you are doing a bunch of math in your code.
I kept the lint warnings for mixing the more advanced operators.

LGTM


Removes old dependencies via Brave 5

Brave v5 is the same as v4 except no old deps. Notably, there is no
current constant file, so that's why literals are used in this change.
See https://github.com/openzipkin/brave/issues/699

ICLA confirmed. Thanks, @adriancole !

happy to help :)

Good luck for today's meetup, and I hope you enjoyed your stay in Japan. :heart:

Thanks! PS I made an armeria example and gave you admin (feel free to add
others). It will be a nice way to collaborate and is exactly the same
example app we use for other tools like finagle and pyramid.

https://github.com/openzipkin-contrib/zipkin-armeria-example


Bug:  Missing data service type instance name returns 500 error code.

getting this error when using hyper-connect with a service instance name that does not exist for the data service:
example HTTP call with the bad instance name in the query string
https://3000-harlequin-mockingbird-r5psl5u7.ws-us21.gitpod.io/api/data?serviceinstancename=default2

Example NodeJS/Express route handler:

export default async function (req, res) {
  // connecting to any service type named by the 'serviceinstancename' query string.
  //  Fallback to a service instance name of 'default'
  const serviceinstancename = pathOr(
    'default',
    ['query', 'serviceinstancename'],
    req,
  )
  const hyper = connect(process.env.HYPER, serviceinstancename)

  console.log('data: get: ', req.params.id)
  const result = await hyper.data.get(req.params.id).catch(err => {

	return {ok: false, err}
  })
  console.log('data: get result', result)
  return res.send(result)
}

This is what is returned from the example API:
{
"ok": false,
"err": {
"error": "not_found",
"reason": "Database does not exist.",
"status": 500
}
}

[ ] Change status code to 404.
[ ] Ensure it is not an unhandled exception

@tripott @TillaTheHun0
What version of this adapter are you currently using in hyper-cloud?
When I curl localhost:6363/data/foo/1 and there is no db, I get 404 Not Found
So the adapter is returning the correct status code.

@twilson63 currently deployed is v0.0.18. Trunk is running v0.0.23, as part of El Dorado work, but that hasn't been deployed. We can deploy whenever we'd like.

@TillaTheHun0
Sounds good, I think this version should correct this issue at least based on running the harness script which runs everything through hyper core and hyper opine

Closing issue for now, we can re-open if the latest version of the couchdb adapter does not resolve this bug.


Quick Accent E

Microsoft PowerToys version
0.62.0
Running as admin

[X] Yes

Area(s) with issue?
Quick Accent
Steps to reproduce
The quick accent feature doesn't run with the uppercase E char in French language.
✔ Expected Behavior
In French language, the uppercase E can be accentuated as the A, I, O or U characters
❌ Actual Behavior
No response
Other Software
No response

Thanks for your message. This is a Duplicate of an other issue. Additional comments may be added there. /dup #20317


Fix a missing import

Checklist

[x] I've tested my changes.
[x] I've read the Contribution Guidelines.
[x] I've updated the documentation if necessary.

Motivation and Context
The current Objective-C example cannot build.
Description
This PR fixes a missing import to be able to build it.

Thanks for looking at this


sha256 hashing of JSON documents

The EBL Envelope transfers requires SHA-256 hashes of the EBL document (Transport document) and EBL envelopes, which are JSON documents. Calculating SHA-256 hashes directly in JSON documents can lead to inconsistencies.
We should consider to calculate the SHA-256 hash the cannonified JSON document to prevent mismatches in character encodings and formatting discrepancies. RFC8785 seems most appropriate for this purpose: https://datatracker.ietf.org/doc/html/rfc8785

another solution could be to move from the detached unencoded payload to an encoded JWS

The envelopes and documents should be immutable and their binary representation constant. In consequence it is not obvious to me why canonicalization is needed as such.
This issue reportedly stems from a concrete case of SHA256 hashes not matching. Can we possibly get access to the given envelopes in order to reproduce the error?

there was an issue where the receiving service formatted the http payload slightly differently (pretty printed) the json message. Resulting in a different hash upon verification. This could potentially be mitigated by mandating RFC8785 formatting. Or to be even more robust encode the JSON as base64


Pin tag/version for zeek-af_packet-plugin

This will pin the version of the zeek-af_packet-plugin to be 2.1.2, which is compatible with Zeek prior to 4.x. This fixes the docker build error.
Closes #23

Verified. :+1:


[Bug]Strange bug when using fmt.Scanln after upgrade to v0.2.6

Bug reports
A very strange bug. After upgrade to v0.2.6, seems using go-prompt in code will change some status of my shell (I'm using zsh on MacOSX) and breaking the function of fmt.Scanln() after that. The symptom is "Return" key will be recognized as "^M" so it will block on the input.
The code to repro:
var pr *prompt.Prompt

func main() {
	user := ""
	fmt.Printf("user: ")
	fmt.Scanln(&user)
	fmt.Printf("got %s\n", user)
	pr = prompt.New(
		func(_ string) {
			os.Exit(0)
		},
		func(d prompt.Document) []prompt.Suggest {
			return nil
		},
	)
	pr.Run()
}

And in the shell, 1st time it works as expected:
$ go run ./main.go
user: test
got test
>

But run it again, the input following user: will be broken:
$ go run ./main.go
user: test^M^M^M^M^M

go version go1.16.2 darwin/amd64
Downgrade to v0.2.5 and it works as expected
Expected Behavior
Should always run as the 1st time
Current Behavior and Steps to Reproduce
What is the current behavior? Please provide detailed steps for reproducing the issue.
A picture or gif animation tells a thousand words
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Operating System: Mac OSX 10.15.7
Terminal Emulator: (i.e. iTerm2) iTerm2/zsh
tag of go-prompt or commit revision: v0.2.6

any updates on this?


Electrostatics

Part of https://github.com/votca/votca/pull/175 and https://github.com/votca/votca/pull/178

@JensWehner can you look at this Codacy warning?

Yeah I am on it. :)

done.

Thanks!


[BUG] Custom origin header is not used in Linux desktop app

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Despite of setting a custom origin header, Altair always uses "Origin: electron://altair". Other headers are send correctly.
On a site, which requires setting the original header, I always get a "401 Unauthorized" response. Using curl with same parameters I get the correct results.
Expected Behavior
No response
Steps To Reproduce

Open new tab
Set custom origin header (using environment, global environment or Set Headers menu)
Send a request
Watch proxied traffic, you will always find "Origin: electron://altair".

Environment
- OS:Kali Linux
- Browser:
- Platform: Electron Desktop App
- Version: 5.2.5_x86_64_linux

Additional context
No response

Having the same problem on altair_5.2.5_arm64_mac. My first time trying Altair but can't use it because my service demands that host and origin match. :/

And also on altair_5.2.5_x64_win and Firefox-Addon.

Fixed in 5.2.6, thanks for your great app and support!


feat(hydrated_cubit): hydrated storage compaction

Description

With intention to address https://github.com/felangel/hydrated_bloc/issues/57 issue,
add compact method to HydratedStorage class, but not Storage interface.
So you'll need to downcast.
In addition to compact, introduce compactionStrategy for HydratedStorage.build function.
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Build configuation change

Non breaking chang🥰🥰

Build a none breaking  configuation change  that has functionality existing features you can merg your branches

@freetoken-Tg1483 I have found new friend for you🥳! His name is @bors

Don't rly like what happened. Hive specifies that default defaultCompactionStrategy inside interface, and not doing ??= defaultCompactionStrategy inside HiveImpl

@orsenkucher closing this since the repository has been moved to https://github.com/felangel/bloc. Let me know if you want me to migrate this PR or if you can. Thanks 🙏


Apply several enhancements for 'chatgpt' command

Make default context length = 16
Make context length customizable using '--ctx' parameter
Add debug logging for prompt and context length

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.00%. Comparing base (2d728db) to head (848fe1e).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   36.00%   36.00%
=======================================
  Files          44       44
  Lines        3580     3580
=======================================
  Hits         1289     1289
  Misses       2291     2291

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
update assignment_2
What did you learn from the changes you have made?
Linear Regression
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
NA
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
NA
How were these changes tested?
NA
A reference to a related issue in your repository (if applicable)
NA
Checklist

[x] I can confirm that my changes are working as intended

A2: Complete
I would suggest reworking Q4 as yo do not have the correct RMSE. It should roughly be 3.18547.


oauthlib.oauth2.rfc6749.errors.InvalidClientIdError: (invalid_request) <....SANITIZED> when i'm using Django>=4.0.4

I followed the README to get this package working on Django>=4.0.4 and created an application as mentioned in the django-oauth-toolkit section, but when im trying to use social authentication, it gives the above error. The jwt authentication is working just fine though .

This is impossible to reproduce, there are no instructions, steps, docs, images etc.


[Bug] Oracle cdc repeatedly consumes snapshot data and does not consume binlog data

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
1.13.5
Flink CDC version
2.1.1
Database and its version
Oracle Database 11g Enterprise Edition Release <IP_ADDRESS>.0 - 64bit Production
and

Non-CDB
Minimal reproduce step
I follow the steps on the official website (https://ververica.github.io/flink-cdc-connectors/release-2.1/content/connectors/oracle-cdc.html),  everything is ok
What did you expect to see?
I expect the oracle cdc consume snapshot data only once and continus consume binlog data
What did you see instead?
when I consume the oracle data with flink sql client, it return all null value, when I consume the oracle data with datastream api ,it consumes snapshot data repeatedly and does not consume binlog data, what happened?
Anything else?
no
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

    This is the code:
    Properties properties = new Properties();
    properties.put("database.tablename.case.insensitive","false");
    properties.setProperty("database.connection.adapter", "logminer");
    properties.setProperty("log.mining.strategy", "online_catalog");
    properties.setProperty("log.mining.continuous.mine", "true");
    SourceFunction<String> sourceFunction = OracleSource.<String>builder()
            .hostname("")
            .port(1521)
            .database("hzdb")
            .schemaList("hzuser")
            .tableList("hzuser.flink_test_cdc")
            .username("hzuser")
            .password("hzuser_2019")
            .deserializer(new JsonDebeziumDeserializationSchema())
            .startupOptions(StartupOptions.initial())
            .debeziumProperties(properties)
            .build();

    StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
    env.setParallelism(1);

    env.enableCheckpointing(10000);
    env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);

    env
            .addSource(sourceFunction)
            .print("cdc").setParallelism(1);

    env.execute();

2.4.0 may fix this issue.

2.4.0 may fix this issue.

什么原因导致的

Closing this issue as it has been migrated to Apache Jira.


Goto definition for type in tuple

Environment data
dotnet --info output:
.NET Command Line Tools (2.0.0-preview1-005977)

Product Information:
 Version:            2.0.0-preview1-005977
 Commit SHA-1 hash:  414cab8a0b

Runtime Environment:
 OS Name:     linuxmint
 OS Version:  18.1
 OS Platform: Linux
 RID:         linuxmint.18.1-x64
 Base Path:   /usr/share/dotnet/sdk/2.0.0-preview1-005977/

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview1-002111-00
  Build    : 1ff021936263d492539399688f46fd3827169983

VS Code version: 1.15.0-insider
C# Extension version: 1.11.0
Steps to reproduce
class C
{
	(C, C) pair() =>
		(new C(), new C());
}

Move the cursor to either C in (C, C) and goto definition.
Expected  behavior
Get taken to C in class C.
Actual behavior
Don't get taken anywhere.

@akshita31 Want to take a look?

Version:            2.0.2
Commit SHA-1 hash:  a04b4bf512
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.16299
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.0.2\
Microsoft .NET Core Shared Framework Host
Version  : 2.0.3
Build    : a9190d4a75f4a982ae4b4fa8d1a24526566c69df
VS Code version: 1.19.0
C# Extension version: 1.13.1
Could you try updating your vscode version and checking whether the issue still persists?

This has been resolved - feel free to reopen if it still repros.


app/services autoscaling status column

Adds an autoscaling status column on the app/services page. The global services page (services by org) is unaffected.
Adds service sizing policies to the schema and updates existing pages to use it.
Adds the variant option to Pill to conform to our other elements.

Disabled:

Enabled:

Open tasks:

[ ] Requires https://github.com/aptible/deploy-api/pull/1345 to be deployed

https://app.shortcut.com/aptible/story/21734/app-ui-display-autoscaling-enabled-disabled-on-app-services-page


add hug command & change ash reactions

I implemented Rico's hug command idea, which should hopefully work, and changed Ashwin's reactions to "MEME" instead of "YOLO" as he asked.

Hey Vik! The hug command looks good :) However, you need to add the unicode for the MEME emojis in default_map !


langchain-chroma/store.py makes LocalAI crash

LocalAI version:
latest version quay.io/go-skynet/local-ai:latest on jun 19 6pm MT

Environment, CPU architecture, OS, and Version:
Linux rdei-local-ai-5f8fc75c56-z5lfb 5.4.77-flatcar #1 SMP Wed Nov 18 17:29:43 -00 2020 x86_64 GNU/Linux

Describe the bug
localAI log  at the crash:
1:54PM DBG Loading model bert-embeddings from bert
11:54PM DBG Model already loaded in memory: bert
11:54PM DBG Loading model bert-embeddings from bert
11:54PM DBG Model already loaded in memory: bert
GGML_ASSERT: /build/go-bert/bert.cpp/ggml/src/ggml.c:6801: ggml_bert_nelements(dst) == ggml_bert_nelements(src0)
SIGABRT: abort
PC=0x7f55b5641ce1 m=5 sigcode=18446744073709551610
signal arrived during cgo execution

goroutine 98 [syscall]:
runtime.cgocall(0x9f7870, 0xc0006be768)
	/usr/local/go/src/runtime/cgocall.go:157 +0x5c fp=0xc0006be740 sp=0xc0006be708 pc=0x47b41c
github.com/go-skynet/go-bert%2ecpp._Cfunc_bert_token_embeddings(0x7f5360002b40, 0x7f5360000d60, 0x7f53600026d0, 0x1, 0xc000ac4000)
	_cgo_gotypes.go:168 +0x4c fp=0xc0006be768 sp=0xc0006be740 pc=0x8f998c
github.com/go-skynet/go-bert%2ecpp.(*Bert).TokenEmbeddings.func1(0x7f5360002b20?, 0x4?, 0x7f5360002b40?, {0xc0006df390?, 0x1, 0x0?}, 0x0?)
	/build/go-bert/gobert.go:70 +0x9d fp=0xc0006be7c8 sp=0xc0006be768 pc=0x8fa37d
github.com/go-skynet/go-bert%2ecpp.(*Bert).TokenEmbeddings(0x0?, {0xc0006df390?, 0x1, 0x1}, {0xc0006be8a8, 0x1, 0x0?})
	/build/go-bert/gobert.go:70 +0x190 fp=0xc0006be850 sp=0xc0006be7c8 pc=0x8fa150
github.com/go-skynet/LocalAI/api.ModelEmbedding.func2()
	/build/api/prediction.go:127 +0x85 fp=0xc0006be8c0 sp=0xc0006be850 pc=0x982ee5

...

CRASH
To Reproduce
called store.py from examples/langchain-chroma
$ python3 store.py
Created a chunk of size 604, which is longer than the specified 300
Created a chunk of size 494, which is longer than the specified 300
Created a chunk of size 510, which is longer than the specified 300
Created a chunk of size 583, which is longer than the specified 300
Created a chunk of size 517, which is longer than the specified 300
Created a chunk of size 338, which is longer than the specified 300
Created a chunk of size 374, which is longer than the specified 300
Created a chunk of size 412, which is longer than the specified 300
Created a chunk of size 530, which is longer than the specified 300
Created a chunk of size 594, which is longer than the specified 300
Created a chunk of size 314, which is longer than the specified 300
Created a chunk of size 359, which is longer than the specified 300
Created a chunk of size 513, which is longer than the specified 300
Created a chunk of size 523, which is longer than the specified 300
Created a chunk of size 739, which is longer than the specified 300
Created a chunk of size 536, which is longer than the specified 300
Created a chunk of size 537, which is longer than the specified 300
Created a chunk of size 505, which is longer than the specified 300
Created a chunk of size 310, which is longer than the specified 300
Created a chunk of size 491, which is longer than the specified 300
Using embedded DuckDB with persistence: data will be stored in: db
Retrying langchain.embeddings.openai.embed_with_retry.<locals>._embed_with_retry in 4.0 seconds as it raised APIConnectionError: Error communicating with OpenAI: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')).
Retrying langchain.embeddings.openai.embed_with_retry.<locals>._embed_with_retry in 4.0 seconds as it raised APIConnectionError: Error communicating with OpenAI: HTTPConnectionPool(host='<IP_ADDRESS>', port=8080): Max retries exceeded with url: /v1/engines/text-embedding-ada-002/embeddings (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fbd80d2be50>: Failed to establish a new connection: [Errno 111] Connection refused')).
[[ CRASHED CONTAINER ]]

Expected behavior

Logs

Additional context

fixed by changing the chunk size


Angular Native Federation serve command doesn't live reload the application

I've been trying to create a POC project to work with the Native Federation in a NX Monorepo, following a DDD approach structure.
The mfe1 application in the project has a dependency to its domain and feature-content existing in the repo and defined in the tsconfig.base.json.
{
  "compileOnSave": false,
  "compilerOptions": {
    "rootDir": ".",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "importHelpers": true,
    "target": "ES2022",
    "module": "esnext",
    "lib": ["ES2022", "dom"],
    "skipLibCheck": true,
    "skipDefaultLibCheck": true,
    "allowSyntheticDefaultImports": true,
    "esModuleInterop": true,
    "baseUrl": ".",
    "paths": {
      "@native-federation/mfe1/domain": ["libs/mfe1/domain/src/index.ts"],
      "@native-federation/mfe1/feature-content": ["libs/mfe1/feature-content/src/index.ts"]
    }
  },
  "exclude": ["node_modules", "tmp"]
}

I use the component defined in the feature-content in app.component.ts of the mfe1
import { Component } from '@angular/core';
import { RouterModule } from '@angular/router';
import { ContentComponent } from '@native-federation/mfe1/feature-content';

@Component({
  standalone: true,
  imports: [RouterModule, ContentComponent],
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrl: './app.component.scss',
})
export class AppComponent {}

That just show some random content via the tag <mfe1-content /> in the app.component.html.
But when I make changes to files defined in the mfe1 feature-content the build seems to be run but it looks like the changes are not detected and the live reload is not triggered. I have to refresh the page manually to see the changes have effect.

I'm not sure if i'm doing something wrong but when I run the application without the Native Federation build process everything works as expected.
I've created a github repo of this project to try this out.
Repro steps
Install dependencies:
npm i
Serve mfe1 with Native Federation:
npx nx run mfe1:serve
Change something in libs/mfe1/feature-content/src/lib/content.component.html.
The live reload is not triggered, but it will if something is not buildable.
On the other hand npx nx run mfe1:serve-original --configuration=development take changes as expected.
Additional infos
package.json
{
  "name": "@native-federation/source",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {},
  "private": true,
  "dependencies": {
    "@angular-architects/native-federation": "^17.1.7",
    "@angular/animations": "17.3.3",
    "@angular/common": "17.3.3",
    "@angular/compiler": "17.3.3",
    "@angular/core": "17.3.3",
    "@angular/forms": "17.3.3",
    "@angular/platform-browser": "17.3.3",
    "@angular/platform-browser-dynamic": "17.3.3",
    "@angular/router": "17.3.3",
    "@ngrx/signals": "^17.1.1",
    "es-module-shims": "^1.9.0",
    "rxjs": "7.8.1",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.3"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "17.3.3",
    "@angular-devkit/core": "17.3.3",
    "@angular-devkit/schematics": "17.3.3",
    "@angular-eslint/eslint-plugin": "17.3.0",
    "@angular-eslint/eslint-plugin-template": "17.3.0",
    "@angular-eslint/template-parser": "17.3.0",
    "@angular/cli": "~17.3.0",
    "@angular/compiler-cli": "17.3.3",
    "@angular/language-service": "17.3.3",
    "@nx/angular": "18.2.3",
    "@nx/eslint": "18.2.3",
    "@nx/eslint-plugin": "18.2.3",
    "@nx/jest": "18.2.3",
    "@nx/js": "18.2.3",
    "@nx/workspace": "18.2.3",
    "@schematics/angular": "17.3.3",
    "@swc-node/register": "1.8.0",
    "@swc/core": "1.3.101",
    "@swc/helpers": "0.5.3",
    "@types/jest": "29.4.4",
    "@types/node": "^18.16.9",
    "@typescript-eslint/eslint-plugin": "7.3.0",
    "@typescript-eslint/parser": "7.3.0",
    "autoprefixer": "^10.4.0",
    "eslint": "8.57.0",
    "eslint-config-prettier": "9.1.0",
    "jest": "29.5.0",
    "jest-environment-jsdom": "29.5.0",
    "jest-preset-angular": "14.0.3",
    "jsonc-eslint-parser": "^2.1.0",
    "ng-packagr": "17.3.0",
    "nx": "18.2.3",
    "postcss": "^8.4.21",
    "postcss-url": "10.1.3",
    "prettier": "2.8.3",
    "ts-jest": "^29.1.0",
    "ts-node": "10.9.1",
    "typescript": "5.4.4"
  }
}

mfe1 project.json
{
  "name": "mfe1",
  "$schema": "../../node_modules/nx/schemas/project-schema.json",
  "projectType": "application",
  "prefix": "app",
  "sourceRoot": "apps/mfe1/src",
  "tags": [],
  "targets": {
    "build": {
      "executor": "@angular-architects/native-federation:build",
      "options": {},
      "configurations": {
        "production": {
          "target": "mfe1:esbuild:production"
        },
        "development": {
          "target": "mfe1:esbuild:development",
          "dev": true
        }
      },
      "defaultConfiguration": "production"
    },
    "serve": {
      "executor": "@angular-architects/native-federation:build",
      "options": {
        "target": "mfe1:serve-original:development",
        "rebuildDelay": 0,
        "dev": true,
        "port": 0
      }
    },
    "extract-i18n": {
      "executor": "@angular-devkit/build-angular:extract-i18n",
      "options": {
        "buildTarget": "mfe1:build"
      }
    },
    "lint": {
      "executor": "@nx/eslint:lint"
    },
    "test": {
      "executor": "@nx/jest:jest",
      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
      "options": {
        "jestConfig": "apps/mfe1/jest.config.ts"
      }
    },
    "esbuild": {
      "executor": "@angular-devkit/build-angular:application",
      "outputs": ["{options.outputPath}"],
      "options": {
        "outputPath": "dist/apps/mfe1",
        "index": "apps/mfe1/src/index.html",
        "browser": "apps/mfe1/src/main.ts",
        "polyfills": ["zone.js", "es-module-shims"],
        "tsConfig": "apps/mfe1/tsconfig.app.json",
        "inlineStyleLanguage": "scss",
        "assets": ["apps/mfe1/src/favicon.ico", "apps/mfe1/src/assets"],
        "styles": ["apps/mfe1/src/styles.scss"],
        "scripts": []
      },
      "configurations": {
        "production": {
          "budgets": [
            {
              "type": "initial",
              "maximumWarning": "500kb",
              "maximumError": "1mb"
            },
            {
              "type": "anyComponentStyle",
              "maximumWarning": "2kb",
              "maximumError": "4kb"
            }
          ],
          "outputHashing": "all"
        },
        "development": {
          "optimization": false,
          "extractLicenses": false,
          "sourceMap": true,
          "namedChunks": true
        }
      },
      "defaultConfiguration": "production"
    },
    "serve-original": {
      "executor": "@angular-devkit/build-angular:dev-server",
      "options": {
        "port": 4201
      },
      "configurations": {
        "production": {
          "buildTarget": "mfe1:esbuild:production"
        },
        "development": {
          "buildTarget": "mfe1:esbuild:development"
        }
      },
      "defaultConfiguration": "development"
    }
  }
}

Yes, this is how it currently works. If you change MFE1, MFE1 is live-reloaded, but not the shell. There, you need to press F5

Yes, this is how it currently works. If you change MFE1, MFE1 is live-reloaded, but not the shell. There, you need to press F5

At the moment I'm stucked in a point where I don't even serve the shell yet, I'm just serving the MFE1 and I try to change some files which the MFE1 depends on, defined in the tsconfig.json, but no reaload is happening.
With module federation I could serve mfe applications and work on them by in "standalone". It looks like the serve doesn't detect changes happening in files defined as dependency in the tsconfig.

Hi,
Ah, now I got you. It's the combination of an app and local, repo-internal libs. If you change the lib you need to press F5 by hand.
Yes, that's currently the case because, by default, all libs are shared and can hence be loaded from a different remote.
There are several options for bypassing this behavior:
a) when developing/ debugging in standalone mode, start the dev server without federation, e.g. nx run project-name:server-original
b) If you don't need to share your lib, e.g. because its just used in your app, add the lib name to the skip list in your federation.config.js
skip: [
    'test-lib',
    'rxjs/ajax',
    'rxjs/fetch',
    'rxjs/testing',
    'rxjs/webSocket',
    // Add further packages you don't need at runtime
  ]`


The simplifies structure dosent work anymore.

@sergioteula I know in a recent patch you removed the "structure" file, is it okay if you could please retrieve it or restore it to the site as I am struggling to get data such as offer price without the structure.

The structure now follows the official documentation for Amazon Product Advertising API, so you can check it for your reference: https://webservices.amazon.com/paapi5/documentation/get-items.html
Moreover, if you're using and IDE like Visual Studio Code, it should help you with suggestions once you type the dot (or pressing CTRL+Space after the dot). If you are not using and IDE, I highly recommend you using VS Code with the Python plugin: https://code.visualstudio.com/


Adding ModuleExports getters for FunctionId, TableId, MemoryId and GlobalId

See #113
TODO:

[ ] Make sure there are no other ways to remove exports except ModuleExports::delete
[x] Add FunctionId test case
[x] Add TableId test case
[x] Add MemoryId test case
[x] Add GlobalId test case

@fitzgen quick question: can we remove ModuleExports::iter_mut() function? Is it being used?
The issue with it, it allows making modifications to the exports without updating the IdHasMaps:
    fn_id_to_export_id: IdHashMap<Function, ExportId>,
    tbl_id_to_export_id: IdHashMap<Table, ExportId>,
    mem_id_to_export_id: IdHashMap<Memory, ExportId>,
    global_id_to_export_id: IdHashMap<Global, ExportId>,

here is an example:
let export_id: ExportId = module.exports.add("dummy", fn_id0);
module
    .exports
    .iter_mut()
    .for_each(|x: &mut Export| x.item = ExportItem::Function(fn_id1));

If we really need to keep the mutable iterator, I will have to remove the IdHashMaps and implement get_exported_func, get_exported_table, get_exported_memory and get_exported_global using iterator().find() which means the complexity will change from O(1) to O(n).
Let me know what you prefer. I'd say let's just kill the ModuleExports::iter_mut() and if any something needs to be removed from the ModuleExports users might create a new instance without specific exports.
Let me know what you think.

Good catch! It is being used by wasm-bindgen, although wasm-bindgen will skip non-function exports, which tells me that the use case is really "iterate over all exported functions" or "iterate over all exported memories" etc. If we only ever hand out &mut Functions instead of &mut Export or &mut ExportItem then user code can't change the item.
What do you think of switching this to iter_funcs_mut() etc?

What do you think of switching this to iter_funcs_mut() etc?

Yeah we can do this... but it is just I don't see a good reason to allow users changing Export.item values. How about making this field private? Export.id is already private, we can make item private and we are good, the end users will not be able to change FunctionId, MemoryId, etc... So the ID mappings won't change:
https://github.com/rustwasm/walrus/blob/8cebc2ce2029bf02400ddac0db5bac89927b1feb/src/module/exports.rs#L15-L21
The only thing they will be allowed to change is the Export.name.

If we only ever hand out &mut Functions instead of &mut Export or &mut ExportItem then user code can't change the item.

thinking about this... if they can't change FunctionId in ExportItem::Function, why do we need to provide a mutable iterator? :)

if they can't change FunctionId in ExportItem::Function, why do we need to provide a mutable iterator? :)

Sorry, I meant &mut FunctionId!
The use case we want to support is essentially generating thin wrappers around an exported function and then swapping the export to the wrapper function and making the wrapped function internal to the module.

Sorry, I meant &mut FunctionId!

Ok, makes sense... BTW how many exports do we expect? tens, hundreds, thousands? Or we don't know and this can differ per use case. I am just thinking if we can leave with O(N), assuming N is reasonably small. This would simplify the entire solution. We would not need to keep the ID mappings.

The usual case is probably on the order of tens to hundreds, but there is probably a pretty long tail that is in the thousands.
I think either way will probably be fine, honestly.

@fitzgen Please have a look, it is ready for review. I have removed the IdHashMaps, this simplified a few things.

Looks great! Thanks @lshlyapnikov :)


Dependency missing from package.json

https://github.com/dy/point-cluster/blob/bdda757def9481be00cb886298e48c0929ee5186/quad.js#L14
defined should be defined in package.json. I suspect it is a phantom dependency.

Thanks!

Amazing response time! Thank you!


fix(balancer) avoid unnecessary indices redistribution

this change was only tested without health checks and (for now) is
aimed for an environment with a ton of invalid hostnames configured.
it must be better tested before merging.

Closing this due to lack of activity. Please re-open if needed.


YesNoPreference and OpenFileDialog plans ?

Is there any way to create YesNoPreference and OpenFileDialog ?

I found solution for me. Not relevant!


az storage directory create python error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az storage directory create
Errors:
'in <string>' requires string as left operand, not NoneType
Traceback (most recent call last):
storage/v2018_11_09/common/storageclient.py, ln 358, in _perform_request
    raise ex
storage/v2018_11_09/common/storageclient.py, ln 344, in _perform_request
    HTTPError(response.status, response.message, response.headers, response.body))
storage/v2018_11_09/common/_error.py, ln 115, in _http_error_handler
    raise ex
azure.common.AzureHttpError: Bad Request
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
...
</BODY></HTML>

storage/v2018_11_09/common/storageclient.py, ln 374, in _perform_request
    if isinstance(ex, AzureHttpError) and expected_errors is not None and ex.error_code in expected_errors:
TypeError: 'in <string>' requires string as left operand, not NoneType

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az storage directory create --account-name {} --account-key {} --share-name {} --name {}

Expected Behavior
Create fileshare storage directory
Environment Summary
Linux-4.14.177-139.254.amzn2.x86_64-x86_64-with-glibc2.2.5
Python 3.7.6
Installer: RPM

azure-cli 2.10.0 *

Additional Context

add to S178

Hi @cmrkz, could you share your debug info with --debug in your command?

Hi @cmrkz, any feedback?

Here's the debug output
Command arguments: ['storage', 'directory', 'create', '--account-name', '', '--account-key', '', '--share-name', '', '--name', '', '--debug']
Event: Cli.PreExecute []
Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x7fc8f037a710>, <function OutputProducer.on_global_arguments at 0x7fc8ef7523b0>, <function CLIQuery.on_global_arguments at 0x7fc8efc033b0>]
Event: CommandInvoker.OnPreCommandTableCreate []
Modules found from index for 'storage': ['azure.cli.command_modules.storage']
Loading command modules:
Name                  Load Time    Groups  Commands
storage                   0.075        52       238
Total (1)                 0.075        52       238
Loaded 52 groups, 238 commands.
Found a match in the command table.
Raw command  : storage directory create
Command table: storage directory create
Event: CommandInvoker.OnPreCommandTableTruncate [<function AzCliLogging.init_command_file_logging at 0x7fc8ebec0440>]
az_command_data_logger : command args: storage directory create --account-name {} --account-key {} --share-name {} --name {} --debug
metadata file logging enabled - writing logs to '/home/e489yh/.azure/commands'.
Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument..add_subscription_parameter at 0x7fc8eb1c1b90>, <function register_global_query_examples_argument..register_query_examples at 0x7fc8ead407a0>]
azure.cli.core.util.handle_exception is called with an exception:
Traceback (most recent call last):
File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 215, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 553, in execute
self.commands_loader.load_arguments(command)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 479, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/init.py", line 36, in load_arguments
load_arguments(self, command)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/_params.py", line 570, in load_arguments
"Options include: {}. Can be combined.".format(get_include_help_string(t_blob_include)),
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/_validators.py", line 589, in get_include_help_string
for include in include_list:
TypeError: 'NoneType' object is not iterable
cli.azure.cli.core.azclierror : CLIInternalError: The command failed with an unexpected error. Here is the traceback:
CLIInternalError: The command failed with an unexpected error. Here is the traceback:
cli.azure.cli.core.azclierror : 'NoneType' object is not iterable
Traceback (most recent call last):
File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 215, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 553, in execute
self.commands_loader.load_arguments(command)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 479, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/init.py", line 36, in load_arguments
load_arguments(self, command)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/_params.py", line 570, in load_arguments
"Options include: {}. Can be combined.".format(get_include_help_string(t_blob_include)),
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/_validators.py", line 589, in get_include_help_string
for include in include_list:
TypeError: 'NoneType' object is not iterable
'NoneType' object is not iterable
Traceback (most recent call last):
File "/usr/lib64/az/lib/python3.6/site-packages/knack/cli.py", line 215, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 553, in execute
self.commands_loader.load_arguments(command)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 479, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/init.py", line 36, in load_arguments
load_arguments(self, command)
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/_params.py", line 570, in load_arguments
"Options include: {}. Can be combined.".format(get_include_help_string(t_blob_include)),
File "/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/_validators.py", line 589, in get_include_help_string
for include in include_list:
TypeError: 'NoneType' object is not iterable
To open an issue, please run: 'az feedback'
Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x7fc8ebecc3b0>]
az_command_data_logger : exit code: 1
Command ran in 1.507 seconds (init: 0.306, invoke: 1.200)
telemetry.save : Save telemetry record of length 9106 in cache
telemetry.check : Negative: The /home/username/.azure/telemetry.txt was modified at 2020-10-29 16:09:23.968902, which in less than 600.000000 s

Hi @cmrkz, thanks a lot for your information.
As debug log, it is caused be None type for include_list. But in our code, we already make sure it is not None as below:
https://github.com/Azure/azure-cli/blob/fbb99ba30690e3bac7df563ba6bf7d5a80e453d1/src/azure-cli/azure/cli/command_modules/storage/_validators.py#L585-L589
I have tried the command with version 2.10.0 and there is no error occurred.
zuh@HUILI-DESKTOP  ~                                                                            [15:25]
❯ az storage directory create -n dirsc -s test --account-name xxxx --account-key xxxxx
{
  "created": true
}
zuh@HUILI-DESKTOP  ~                                                                            [15:32]
❯ az --version
azure-cli                         2.10.0 *

If possible, could you upgrade to latest version and try again.

if error still occurs, could you show me your package version for azure-multiapi-storage?


Incomplete prerequisites to build source

I would love to contribute but cannot anymore,
Following the readme on a fresh install of windows 7 on a VM with everything by default won't build, we need a version of VC++ because of a missing vcomp100.dll but even after that a bunch of tasks fails:
Exceptions.txt
And a bunch of *.dll metadata file missing and libcore.dll copy failed when rebuilding.
The Xenko.GameStudio.exe generated crashes on launch.
I'm running it on a VM because I can't run it on my main machine anymore, not sure what happened but after a re-installation of visual studio 2017 I couldn't preview scripts or build it anymore; a whole bunch of "project not supported" issues.
I have gone through and uninstalled / deleted every files related to visual studio, re-installed to different locations and with different configurations but this error stays there. Building from cmd>dotnet build/msbuild fails understandably, running xenko from the xenko launcher results in Exceptions2.txt
The issue could come from newer visual studio versions since I already had one at hand and everything was running fine before re-installation ?
Here are the additional components installed through VS installer on the VM:
C# and Visual Basic Roslyn compilers
MSBuild
Static analysis tools
C# and Visual Basic
.NET Framework 4.6.1 SDK
.NET Framework 4.6.1 targeting pack
Text Template Transformation
.NET Framework 4.7 SDK
.NET Framework 4.7 targeting pack
.NET Framework 4.7.1 SDK
.NET Framework 4.7.1 targeting pack
.NET Framework 4.7.2 SDK
.NET Framework 4.7.2 targeting pack
Visual Studio C++ core features
Visual C++ 2017 Redistributable Update
VC++ 2017 version 15.8 v14.15 latest v141 tools
Windows 10 SDK (10.0.17134.0)
Windows Universal CRT SDK
Windows 8.1 SDK
Windows XP support for C++
C++/CLI support
VC++ 2015.3 v14.00 (v140) toolset for desktop
Visual C++ compilers and libraries for ARM
Visual C++ runtime for UWP
.NET Core runtime
.NET Framework 3.5 development tools
NuGet targets and build tasks
.NET Compiler Platform SDK
GitHub extension for Visual Studio
Clang/C2 (experimental)
VC++ 2017 version 15.8 v14.15 Libs for Spectre (ARM)
Visual C++ compilers and libraries for ARM64
VC++ 2017 version 15.8 v14.15 Libs for Spectre (ARM64)
VC++ 2017 version 15.8 v14.15 Libs for Spectre (x86 and x64)
VC++ 2017 version 15.7 v14.14 toolset
VC++ 2017 version 15.6 v14.13 toolset
VC++ 2017 version 15.5 v14.12 toolset
VC++ 2017 version 15.4 v14.11 toolset
C++ Universal Windows Platform tools for ARM64

I ended up fixing the installation on my main machine by re-installing the build framework in the assembly cache, looks like it's required when you update VS.
On Visual Studio's dev console execute
gacutil /u Microsoft.Build.Framework
To uninstall it and
gacutil /i "Path To Your visual studio's msbuild\MSBuild\15.0\Bin\Microsoft.Build.Framework.dll"
To install the newer version.
We still need a version of visual c++ and something else to build assets on a fresh install.

Can't edit the UI/Editor for game studio with VS2017 Version 15.8.3. It compiles fine, no issues besides the warnings, just can't actually extend the editor without editing the xaml in a text editor. Is there a known issue for this or should I downgrade to 15.2?

@Eideren thanks, I also noticed localization tools didn't work well on my clean config. Will try to fix it so that your custom steps are not required anymore.

PS: Might be more than just localization (GNU.Gettext.Msgfmt.exe issue) in your case, seems log also show some other issues.

@Eideren Gave a try with a clean Win7 VM and did an update to README: 1cc4d2761db03
Does it work better with those instructions?

@xen2 cleared the VM, re-installed windows, followed the new readme and nope, still won't the editor.
Here's the very first build's output and the second one
Third+ are similar to the second one.
Here's the list of installed programs:
I didn't wait for windows to update itself though and I don't think we should expect, even if it isn't safe, other users to do either.

@Eideren Can you give us the full output? It looks like you only copied the error messages. Also after cleaning the solution, can you first start building the engine, then Xenko.GameStudio (don't try building the whole solution)?

@Kryptos-FR sure, here's the output for xenko.gamestudio.csproj after cleanup and the output for a solution rebuild just in case.

In the first log I see that Xenko.Physics was not built. Can you try to build it separately and report any errors?

Building Xenko.Physics succeeded and building Xenko.GameStudio afterward did as well.
Running GameStudio afterwards still doesn't work.
Installing and running xenko from the installer works though.

After unloading each *.Test project and clearing the bin folder the build still does not succeed but building it twice in a row does though.
Here's the first try at building the solution
Now, the crash when loading a project is related to this exception, either a lack of driver or VM graphics support. In any case Xenko supports dx9.1 so this exception shouldn't really occur, I created a new issue about it.

@Kryptos-FR no the issue wasn't fixed (I thought it was just your setup somehow, but if other people have it I will fix it with higher priority)

@Kryptos-FR so the level is the actual graphics card support while the version is the maximum level that you can achieve by supporting it ? You can run an older graphics card through the feature set of dx9 in dx11 by using the dx9 level ?

I built a new VM just to be sure and can confirm that it builds straight away, great job @xen2 , I'm closing this one off.

@Eideren cool, thanks so much for the bug report!


derived BugLearnAndValidate and BugLearn

BugDetection from Michael Pradel renamed to BugLearnAndValidate
Added BugLearn

Can you please also update the README? It seems the BugDetection command in the current README won't work anymore with this change.


windows getting AttributeError: module 'os' has no attribute 'getuid'. Did you mean: 'getpid'?

Describe the bug
getting the error AttributeError: module 'os' has no attribute 'getuid'. Did you mean: 'getpid'? on windows
updated to latest in the main branch
Steps to Reproduce

run  uvicorn opendevin.server.listen:app --port 3000
cd frontend;  npm run start -- --port 3001
wait for UI to load get the error in the uvicorn shell - "

Expected behavior
OpenDevin works
Actual behavior
PS C:\Users\boris\thirdparty\OpenDevin> uvicorn opendevin.server.listen:app --port 3000
INFO:     Started server process [111408]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:3000 (Press CTRL+C to quit)
INFO:     ('<IP_ADDRESS>', 54050) - "WebSocket /ws" [accepted]
INFO:     connection open
Task exception was never retrieved
future: <Task finished name='create controller' coro=<Session.create_controller() done, defined at C:\Users\boris\thirdparty\OpenDevin\opendevin\server\session.py:114> exception=AttributeError("module 'os' has no attribute 'getuid'")>
Traceback (most recent call last):
File "C:\Users\boris\thirdparty\OpenDevin\opendevin\server\session.py", line 132, in create_controller
self.controller = AgentController(self.agent, directory, callbacks=[self.on_agent_event])
File "C:\Users\boris\thirdparty\OpenDevin\opendevin\controller_init_.py", line 33, in init
self.command_manager = CommandManager(workdir)
File "C:\Users\boris\thirdparty\OpenDevin\opendevin\controller\command_manager.py", line 24, in init
self.shell = DockerInteractive(id="default", workspace_dir=dir)
File "C:\Users\boris\thirdparty\OpenDevin\opendevin\sandbox\sandbox.py", line 51, in init
uid = os.getuid()
AttributeError: module 'os' has no attribute 'getuid'. Did you mean: 'getpid'?
Additional context
Windows in PowerShell

Thanks for the report! I think we've mainly been running on mac.
Can you try this branch: rb/fix-uid?

Proposed fix: https://github.com/OpenDevin/OpenDevin/pull/170

Yeeah actually i started up! I think that fix is done!
but there's another issue:
Finish cleaning up Docker container
Exception ignored in atexit callback: <bound method DockerInteractive.cleanup of <opendevin.sandbox.sandbox.DockerInteractive object at 0x0000016C36CE1EA0>>
Traceback (most recent call last):
File "C:\Users\boris\thirdparty\OpenDevin\opendevin\sandbox\sandbox.py", line 148, in cleanup
self.container.remove(force=True)
File "C:\Users\boris\AppData\Local\Programs\Python\Python310\lib\site-packages\docker\models\containers.py", line 352, in remove
return self.client.api.remove_container(self.id, **kwargs)
File "C:\Users\boris\AppData\Local\Programs\Python\Python310\lib\site-packages\docker\utils\decorators.py", line 19, in wrapped
return f(self, resource_id, *args, **kwargs)
File "C:\Users\boris\AppData\Local\Programs\Python\Python310\lib\site-packages\docker\api\container.py", line 1027, in remove_container
self._raise_for_status(res)
File "C:\Users\boris\AppData\Local\Programs\Python\Python310\lib\site-packages\docker\api\client.py", line 270, in _raise_for_status
raise create_api_error_from_http_exception(e) from e
File "C:\Users\boris\AppData\Local\Programs\Python\Python310\lib\site-packages\docker\errors.py", line 39, in create_api_error_from_http_exception
raise cls(e, response=response, explanation=explanation) from e
docker.errors.NotFound: 404 Client Error for http+docker://localnpipe/v1.43/containers/7ee7554df78ae5b7f15627088f44abd478485eac5aa4cb15bc91a059ac2a87ab?v=False&link
should I raise that as a separate bug?

I have a fix for this one already--it's an error that pops up after the program exits.
Did you quit opendevin to make this appear? Are there any other logs?

I have a fix for this one already--it's an error that pops up after the program exits.
Did you quit opendevin to make this appear? Are there any other logs?

i don't think so, I just started it up per the docs... it "activated the agent" - I tried to send that message and received the error (pretty sure...)

If you manage to capture it again, I'm hoping there are some more logs above Finish cleaning up Docker container

ok right this time it actually ran for a bit(not sure what I did differently) but it errored with this:
PS C:\Users\boris\thirdparty\OpenDevin> uvicorn opendevin.server.listen:app --port 3000
INFO:     Started server process [45628]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:3000 (Press CTRL+C to quit)
INFO:     ('<IP_ADDRESS>', 49661) - "WebSocket /ws" [accepted]
INFO:     connection open
STEP 0
ACTION CmdRunAction(command='ls', background=False)
OBSERVATION CONTRIBUTING.md
LICENSE
OpenDevinLogo.jpg
README.md
agenthub
dev_config
evaluation
frontend
opendevin
requirements.txt
workspace
CONTRIBUTING.md
LICENSE
OpenDevinLogo.jpg
README.md
agenthub
dev_config
evaluation
frontend
opendevin
requirements.txt
workspace
==============
STEP 1
ACTION AgentThinkAction(thought='Before starting to build the roguelike, I should check if the README.md file contains any relevant information about the existing project structure or any specific instructions.', runnable=False)
ACTION NOT EXECUTABLE
OBSERVATION
==============
STEP 2
ACTION FileReadAction(path='README.md', base_path='')
FileReadAction(path='README.md', base_path='.')
Error in loop 'charmap' codec can't decode byte 0x90 in position 1928: character maps to

ok great now this just has to be merged into main :D I raised another issue for the other issue - here - https://github.com/OpenDevin/OpenDevin/issues/178


Document is deafult for Subs

Added explanations and examples to document what is default does for Subs. This is to fix #1040.

This won't make it searchable, right?

I'm really not sure if it will or not, as I am unfamiliar with how it
works. I am guessing that it will not be searchable.
On Fri, Dec 16, 2016, 3:40 PM Aleks-Daniel Jakimenko-Aleksejev <
<EMAIL_ADDRESS>wrote:

This won't make it searchable, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/pull/1052#issuecomment-267690842, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKDNk32MPJ5l5jTLZshKo7e5zCtO2jWFks5rIvdIgaJpZM4LNfVT
.


Configuration model changes called out in release notes

Some details
How many backends are in your application?

[ ] 1-2
[ ] 3-5
[x] 6-10
[ ] 10+

How do you host your application?

[ ] Kubernetes
[ ] Azure App Service
[ ] Azure VMs
[ ] Other Cloud Provider (please include details below)
[x] Other Hosting model (please include details below)

What did you think of YARP?
We love YARP and have been running it in production for quite some time now. As new previews are being released we of course try to upgrade to the latest preview as fast as possible. In order to do that, release notes are obviously very important since they help us determine the impact of the upgrade. Of course we understand that at this stage breaking changes are necessary, but it is sometimes unclear whether the breaking change is purely in code or whether it (also) impacts the configuration model.
For example the 1.0.0-preview9 release notes calls out that there is a breaking change in that the config model has become read only. My team assumed that this also meant that the configuration itself had to change which made them hesitant to perform the upgrade. In the end it turned out the configuration didn't have to change at all, so the upgrade went very smoothly.
Honestly it isn't a really big deal, but it would have been helpful if each released would explicitly call out whether or not changes to the configuration would need to be made. @karelz suggested I'd post this here as an issue.

We have been using the Breaking-Change label to mark PRs that affect APIs, config, etc.. Should we add a new label for Breaking-Config? I'd suggest adding that in addition to the Breaking-Change label, and we could retroactively add it to old PRs.

Yeah, I think that would work great for us.

We're making sure to call out config-breaking changes in our release notes.
Given that breaking changes to the config are relatively uncommon (compared to code), we will try to call out if the config was untouched in release notes as well.
Generally speaking, the expectation should be that the config remains valid unless breaking changes are called out.


Not operator or deployer error when deploy NFT drops contract on Ethereum & Polygon Mainnet

My team and I have been maintaining a fork of the Go SDK. But lately we are getting the error "not operator or deployer"  when deploying NFT drops contract on the Ethereum and Polygon mainnet. The same code works on Polygon Mumbai testnet and can create NFT drops contract without any error.
https://github.com/qnfnypen/thirdweb-go-sdk/blob/4c2f3df09ac938b395b6488f3ef7112cb2010922/thirdweb/contract_deployer.go#L95
func (deployer *ContractDeployer) DeployNFTCollection(ctx context.Context, metadata *DeployNFTCollectionMetadata) (string, error) {
	metadata.fillDefaults()
	return deployer.deployContract(ctx, "nft-collection", metadata)
}

The error seems to be coming from the condition checks from the Registry contracts on whether the sender of the message (_msgSender()) has the OPERATOR_ROLE or if the sender is the _deployer. We had checked many times to confirm the sender is the deployer. Still, it works on Mumbai testnet but not on Ethereum and Polygon mainnet.
Does anyone has a clue?

@iggyiccy glad to hear you're maintaining a fork of the go sdk, although we have been depriotizing it in favor of our preferred backend solution: https://github.com/thirdweb-dev/engine
it can do everything that the go sdk could do and much more, and everything is exposed via a simple rest API, which is much easier to consume from any backend language.
That said, for your specific issue, we have deprecated the old TWFactory contracts in favor of a stateless, deterministic factory that is deployable by anyone on any chain.
The address is 0x76F948E5F13B9A84A81E5681df8682BBf524805E - has the same main API for deploying minimal clones, so you should be able to just replace the address in your fork i believe.

@iggyiccy glad to hear you're maintaining a fork of the go sdk, although we have been depriotizing it in favor of our preferred backend solution: https://github.com/thirdweb-dev/engine
it can do everything that the go sdk could do and much more, and everything is exposed via a simple rest API, which is much easier to consume from any backend language.
That said, for your specific issue, we have deprecated the old TWFactory contracts in favor of a stateless, deterministic factory that is deployable by anyone on any chain.
The address is 0x76F948E5F13B9A84A81E5681df8682BBf524805E - has the same main API for deploying minimal clones, so you should be able to just replace the address in your fork i believe.

Thank you for recommending Engine. We will check it out see how can we integrate it moving forward.
Meanwhile, we had tried to point the SDK to the TWCloneFactory address "0x76F948E5F13B9A84A81E5681df8682BBf524805E" but it still doesn't work in resolving the authorisation issue we are getting. What's the different between the old factory and the new clone factory?

@iggyiccy the difference is that TWFactory (old one) also adds the deployed contract to the TWRegistry (what used to power the deployed contract list in the thirdweb dashboard and other places)
We ended up revoking all permissions on the TWRegistry as we moved to a new multichain approach (TWMultichainRegistry)
if you use the new TWStatelessFactory however, that only deploys the proxy and does not do anything else, and does not require any particular permission. Here's the signature of the deploy function: https://github.com/thirdweb-dev/contracts/blob/main/contracts/infra/TWStatelessFactory.sol#L28 which should match the old one


Add 'Erasmus University Rotterdam'

Official university website: https://eur.nl/en
IT-related course URL: https://www.eur.nl/en/master/data-science-and-marketing-analytics

@thomastunc I am sorry, the domain eur.nl is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


fix(bundler-vite): clean require cache in createBuild.ts (fix #772)

Fixes #772

Please remove 2 ; to pass the linter

Done

Thanks for your contribution. It's handled in 30bb4a8aa9d06fd52ffce5611dd7b255387c0c71


panic when use golang filter decode http2 connect tunnel data

envoy config use h2 connect tunnel config from example

envoy use golang filter envoy.filters.http.golang，code is

func (f *filter) DecodeData(buffer api.BufferInstance, endStream bool) api.StatusType {
	api.LogInfof("body len: %d", buffer.Len())
	api.LogInfof("body: %s", string(buffer.Bytes()))

	return api.Continue
}

when request arrived, then buffer.Len() run success, but buffer.Bytes() will got panic, error is

2024-01-25 14:17:29.816][608832][error][golang] [contrib/golang/common/log/cgo.cc:24] http: panic serving: not proccessing Go
goroutine 17 [running, locked to thread]:
github.com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http.(*httpRequest).RecoverPanic(0xc00007e690)
	/usr/local/go/path/pkg/mod/github.com/envoyproxy/envoy@v1.28.0/contrib/golang/filters/http/source/go/pkg/http/filter.go:83 +0x6b
panic({0x7fa388a77840, 0xc000073820})
	/usr/local/go/src/runtime/panic.go:884 +0x213
github.com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http.handleCApiStatus(...)
	/usr/local/go/path/pkg/mod/github.com/envoyproxy/envoy@v1.28.0/contrib/golang/filters/http/source/go/pkg/http/capi_impl.go:82
github.com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http.(*httpCApiImpl).HttpGetBuffer(0x7fa388ab3bc0?, 0xa388864d96?, 0x7fa387f27388?, 0x4f)
	/usr/local/go/path/pkg/mod/github.com/envoyproxy/envoy@v1.28.0/contrib/golang/filters/http/source/go/pkg/http/capi_impl.go:208 +0xd5
github.com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http.(*httpBuffer).Bytes(0xc000025fb0)
	/usr/local/go/path/pkg/mod/github.com/envoyproxy/envoy@v1.28.0/contrib/golang/filters/http/source/go/pkg/http/type.go:368 +0x43
main.(*filter).DecodeData(0xc0000125d0?, {0x7fa388ae1478?, 0xc000025fb0?}, 0x8?)
	/code/sdp/internal/gateway/envoy/go-hook/main.go:62 +0x27
github.com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http.envoyGoFilterOnHttpData(0x277cbf2469b0, 0x0, 0x277cbfd50300, 0x4f)
	/usr/local/go/path/pkg/mod/github.com/envoyproxy/envoy@v1.28.0/contrib/golang/filters/http/source/go/pkg/http/shim.go:197 +0x122

cc @doujiang24 @wangfakang

@userlxd Thanks for your reporting, it's reproducable on my side, I'll take a deeper look soon~

Oh, sorry, the current implementation do not support handling request data of full-duplex http requests, neither CONNECT nor WebSocket.
I'll figure a way to support it, may need some time. Thanks again~

In my case, I need inject the tls.conn over tunnel to control https token header.
Wasm go plugin could be work when read tunnel data, but go native tls.conn.handshake use goroutine.
So the lowest cost way is to wait for go plugin to support it, Thank you for your contribution @doujiang24

not stale, I'll fix it in the near future.

/assign @doujiang24


Google Play Music listed as not installed in Music Apps Activity

The Google Play Music app shows up in the list of music apps as Android Music Player (I think because it uses the same intents), however, at least on my Nexus One it is listed as not installed. I think this is because even though the intents are the same as the Android Music Player, the actual package name of the app is not.
Thus, when you use Util.checkForInstalledApp in MusicAppsScreen.java, it's looking for the wrong package name.
Scrobbling works fine, it's just a UI bug as far as I can tell.
Obviously, this is a fairly minor bug, but it had me confused for a while. I'll have a see if I can do anything about it, but I thought I'd raise it as an issue in any case.

Please continue discussion in #200


V4.0.0-beta.13 - VirtualScroll doesn't call ngOnInit of all its children

Bug Report
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
Ionic:

   ionic (Ionic CLI)             : 4.2.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.13
   @angular-devkit/build-angular : 0.8.6
   @angular-devkit/schematics    : 0.8.6
   @angular/cli                  : 6.2.6
   @ionic/angular-toolkit        : 1.0.0

System:

   NodeJS : v8.12.0 (/usr/local/bin/node)
   npm    : 6.4.1
   OS     : macOS

Describe the Bug
Just run this simple code on a fresh project:
import { Component, OnInit, Input } from '@angular/core';

@Component({
  selector: 'app-root',
  template: `
  <ion-app>
      <ion-content>
        <ion-list>
            <ion-virtual-scroll [items]="movies" approxItemHeight="44px">
              <app-movie *virtualItem="let item" [title]="item"></app-movie>
            </ion-virtual-scroll>
        </ion-list>
      </ion-content>
  </ion-app>
`
})
export class AppComponent implements OnInit {
  movies: string[] = [];

  ngOnInit() {
    for (let i = 0; i < 1000; i++) {
      this.movies.push(`The Movie ${i}`);
    }
  }
}

@Component({
  selector: 'app-movie',
  template: `
  <ion-item>{{title}}</ion-item>
`
})
export class MovieComponent implements OnInit {
  @Input()
  title: string;

  ngOnInit() {
    console.log('On Init', this.title);
  }
}

If you check your console, you'll notice the ngOnInit() method is not called for all MovieComponent, only some of them

Thanks for your issue! Could you please check if this is still an issue in beta.17? That would be very nice :)

Same issue on beta.17

I still facing this issue on beta.19

@JumBay the fix was merged but not released :)

@JumBay I misunderstood the problem, I think this is the expected behaviour. Virtual-scroll creates a set of components then it reuses, is it not that the point of a virtual-scroll?
Your component should be stateless if you want to use it with virtual-scroll, only depending in the inputs the component has.

As @manucorporat says - the components will be reused. So ngOnInit will not be called (the component already exist) if the components are created who are necessary to fill the viewport.
So you have to look for the changes of this component
ngOnChanges(changes) {
   console.log('CHANGES', changes.title.currentValue);
}

And then you will see it :) I also need some time to understand it. So keep in mind: Components are REUSED!

Thanks that's what I thought and I updated my code in this direction.


Mail issue subscribers, rework the function

This PR will add the issue subscribers to the list of mail recipients. The code of the function was kind of a mess, so I re-arranged it aiming for better clarity.
This also adds some checks that the previous function was doing only partially, as follows:

The users must have mail notifications enabled.
The users must be active.
The users must have login permitted.

I've cleared some possible double mail cases too.
The only thing I didn't add here is repo visibility; that -I think- should be for another PR or even for a different part of the system:

IMHO, assignees should be de-assigned when they lose issue/PR/repo permissions.
IMHO, repo watchers should unwatch when they lose issue/PR/repo permissions.
Mentions are already covered by Issue.ResolveMentionsByVisibility().
Original poster and participants.... should be checked in this function.

This function can be further improved by batching most of the queries (e.g. bring user IDs and retrieve them from user all at once), but that would involve editing several files at models and a harder to review PR. 😉
Fixes #8952

Codecov Report

Merging #9009 into master will increase coverage by 0.01%.
The diff coverage is 72.54%.

@@            Coverage Diff            @@
##           master   #9009      +/-   ##
=========================================
+ Coverage   41.19%   41.2%   +0.01%
=========================================
  Files         546     546
  Lines       71306   71325      +19
=========================================
+ Hits        29371   29388      +17
+ Misses      38208   38203       -5
- Partials     3727    3734       +7

Impacted Files
Coverage Δ

services/mailer/mail_issue.go
57.28% <72.54%> (+1.32%)
:arrow_up:

modules/migrations/migrate.go
22.09% <0%> (-1.66%)
:arrow_down:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

modules/migrations/gitea.go
8.82% <0%> (-0.64%)
:arrow_down:

models/issue.go
50.95% <0%> (-0.25%)
:arrow_down:

models/repo.go
46.51% <0%> (-0.05%)
:arrow_down:

models/error.go
33.86% <0%> (+1.18%)
:arrow_up:

modules/task/migrate.go
28.94% <0%> (+3.94%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

models/issue_watch.go
66.17% <0%> (+8.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149a9df...d68421f. Read the comment docs.

@lunny done


We don't have a place for announcements!

Which is an issue, because I want to tell everyone that it's now possible to download a zip of projects translated on the scratch-js website!
This should have happened sooner, but I'm glad it's at least done now. :P

Perhaps add a CHANGELOG? Once the website source is up you can do the same on that to announce things 📦


Error code > 0 expected when the assembler fails due to errors

This happens for me on OSX 10.15.7 with ruxnasm built from the source code.
I can see the errors and there is no rom produced but the return code is 0. This is an issue when trying to use ruxnasm from within other processes.
Expected behaviour: 0 should only be returned if the assemble was successful, greater than 0 should be returned otherwise.
~/Documents/ruxnasm/target/release(main) » ./ruxnasm ~/life.tal /tmp/yolo.rom                                                                                xyz@abc
error: macro `JSR345#%$#%@##%@$#%$#%#$%4` is not defined
   ┌─ /Users/xyz/life.tal:43:25
   │
43 │ ,fsdfdsaf ;fsdfdasfdsf  JSR345#%$#%@##%@$#%$#%#$%4
   │                         ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: macro `435` is not defined
   ┌─ /Users/xyz/life.tal:46:1
   │
46 │ 435
   │ ^^^

error: macro `345` is not defined
   ┌─ /Users/xyz/life.tal:47:1
   │
47 │ 345
   │ ^^^

error: macro `243543erf` is not defined
   ┌─ /Users/xyz/life.tal:49:1
   │
49 │ 243543erf DEO
   │ ^^^^^^^^^

error: found bytes on the zeroth page
   ┌─ /Users/xyz/life.tal:43:1
   │
43 │ ╭ ,fsdfdsaf ;fsdfdasfdsf  JSR345#%$#%@##%@$#%$#%#$%4
44 │ │ %#$543
45 │ │ 5345
46 │ │ 435
47 │ │ 345
48 │ │ 3245
49 │ │ 243543erf DEO
   │ ╰─────────────^

warning: macro `//` is never used
  ┌─ /Users/xyz/life.tal:9:40
  │
9 │ %++ { ADD2 } %-- { SUB2 } %** { MUL2 } %// { DIV2 }
  │                                        ^^^

warning: macro `!!` is never used
   ┌─ /Users/xyz/life.tal:10:40
   │
10 │ %<< { LTH2 } %>> { GTH2 } %== { EQU2 } %!! { NEQ2 }
   │                                        ^^^

warning: macro `#$543` is never used
   ┌─ /Users/xyz/life.tal:44:1
   │
44 │ %#$543
   │ ^^^^^^

-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/Documents/ruxnasm/target/release(main) » echo $?                                                                                xyz@abc
0

@xaderfos you're absolutely right. thank you for reporting this issue! i'll try to push the fix asap

That's great, I've been testing ruxnasm in my Emacs uxntal-mode and wanted to make sure it works as smooth as uxnasm.

@xaderfos alright, should be fixed in 519b8109d4a83cd86f34bb755cbc866f53303f77.
again, thank you so much for the issue. sorry you had to wait for so long, i didn't get a notification

No worries at all! I have not been slowed down by this in any way. I'll test it as soon as I can ;)

I can confirm that this is now fixed, thank you very much for this @karolbelina ;)


Stop Service from Service Interactive/Non-Interactive

Hi,
I am creating an application which is intended to be run both as a service and in interactive mode. The target is Linux and Windows platforms but I am currently developing on a Windows machine.
I was wondering if the package provides a way to stop the service from within the service itself when running in interactive mode.
I am using the following code as a test for this feature and when executed in interactive mode, execution never reaches the end of the main function. Everything works as expected when run as service.
package main

import (
	"log"
	"time"

	"github.com/kardianos/service"
	"os"
)

type program struct {
	svc service.Service
}

func (p *program) Start(s service.Service) error {
	p.svc = s
	log.Println("start")
	go p.run()
	return nil
}
func (p *program) run() {
	log.Println("Run")
	// Is this correct? Is there a way to make this work in Interactive mode?
	err := p.Stop(p.svc)
	if err != nil {
		log.Println(err)
	}
}
func (p *program) Stop(s service.Service) error {
	log.Println("Stop")
	<-time.After(time.Second)
	log.Println("Stopping")
	return nil
}

func main() {
	svcConfig := &service.Config{Name: "GoServiceExampleStopPause"}

	prg := &program{}
	s, err := service.New(prg, svcConfig)
	if err != nil {
		log.Fatal(err)
	}

	if len(os.Args) > 1 {
		err = service.Control(s, os.Args[1])
		if err != nil {
			log.Fatal(err)
		}
		return
	}

	err = s.Run()
	if err != nil {
		log.Println(err)
	}

	log.Println("Quit")
}

Is this something I should approach differently? I am trying to have an executable that can be run both as a service and as cmd line interactive utility. Both should quit when certain errors happen. Is this supported in this package? Or should I be implementing my own signal handling or something similar?

A solution was found by taking a closer look at the examples (more specifically the runner example.
The following code was added to the Stop function of the program struct:
	if service.Interactive() {
		log.Println("Quit")
		os.Exit(0)
	}