Errors related to using pygeos

Pygeos was added as a requirement to help resolve #3. However, it appears that when GeoPandas uses pygeos under-the-hood, it causes all sorts of unexpected behaviour in other parts of the workflow that were not initially detected!
During rasterization, I'm getting the error: GEOSException: IllegalArgumentException: Argument must be Polygonal or LinearRing. This originates from the overlay operation (when we "slice" the GDF with the grid lines). (I checked, and all inputs have geom_type Polygon)
During 3D tile creation, we are seeing the error: IndexError: index 2 is out of bounds for axis 0 with size 2 from py3dtiles. This may be because the output from MultiPolygon([polygon]).wkb is different when we are using pygeos than when we are not. This output is passed to TriangleSoup.from_wkb_multipolygon, where the error is originating.
Both of the above errors are resolved by uninstalling pygeos.
Additionally, I'm seeing a new error during staging that I did not see before changes made in #3, but I'm not sure yet if it's related to pygeos, or perhaps the newer version of Shapely that we're now using. Kastan was able to get through staging without these errors, so it might be unrelated.
During staging, I'm getting an error concatenating two GDFs (with pd.concat, happens when we merge new polygons into an existing tile). The error implies that the two GDFs differ in CRS, but this is not the case: Cannot determine common CRS for concatenation inputs, got ['WGS 84 (CRS84)', 'WGS 84 (CRS84)']. Use to_crs() to transform geometries to the same CRS before merging.
(See https://github.com/PermafrostDiscoveryGateway/viz-staging/issues/11 for the "Cannot determine common CRS for concatenation inputs" error during staging, which is not related to pygeos)

I created a new conda virtual environment (with python=3.9) and only installed the following packages from github:

pdgstaging with pip install git+https://github.com/PermafrostDiscoveryGateway/viz-staging.git
pdgraster with pip install git+https://github.com/PermafrostDiscoveryGateway/viz-raster.git
fork of py3dtiles (repo here) with pip install git+https://github.com/PermafrostDiscoveryGateway/py3dtiles.git
viz-3dtiles with pip install git+https://github.com/PermafrostDiscoveryGateway/viz-3dtiles.git

Then I got the staging error Robyn recorded above, so I ran pip uninstall pygeos and got the confirmation Successfully uninstalled pygeos-0.13
Restarted kernel, cleared all outputs in notebook, and got the same error during staging.
Closed remote connection to datateam server, quit VS code, and reopened connection and got the same error during staging. Used pip list --local to check that pygeos was not listed, and it was not.

Update:
After meeting with Robyn to discuss potential sources of error for the staging step, she identified the latest version of geopandas (0.12) which is imported with the pdgstaging as the source of the error. One of their bug fixes for this version is:
Combining GeoSeries/GeoDataFrames with pandas.concat will no longer silently override CRS information if not all inputs have the same CRS (#2056).
While the CRS's of both GeoDataFrames that we combine are the same, perhaps the CRS metadata or something else minor about the CRS is different, because they are flagged by geopandas 0.12 as being inconsistent. Uninstalling pygeos, then also uninstalling geopandas 0.12 and installing version 0.11.1 fixes the CRS error reported above! The files are staged successfully in parallel.
But a different staging error occurs with the same approach with Ingmar's data sample:

Both data samples are geopackages. This is something to investigate moving forward.

Reproducing staging error versus reproducing successful staging with different data inputs
Robyn found a way to fix to the CRS mismatch error mentioned in the first comment of this issue. See her solution (also linked in first comment) includes changing the TMS to WGS1984Quad instead of using WorldCRS84Quad.
However, I was able to run the staging step on a very small data subset (2 files that overlap spatially, provided by Robyn) without changing the TMS. Additionally, I reproduced the unique error reported above (IndexError: index 0 is out of bounds for axis 0 with size 0) with the exact same config and python environment, but with different input files. Both these workflows were run in parallel with parsl and process geopackages.

The error reported above that does not mention CRSs (IndexError: index 0 is out of bounds for axis 0 with size 0) can be found in this notebook. Staging summary for this file is error_staging_summary.csv.
The successful staging with the "old" TMS WorldCRS84Quad can be found in this notebook. Staging summary for this file is staging_summary.csv.
links were made with commit ID's so should persist even as documents are updated

The config and list of installed packages for these workflows is included within these notebooks just below the import chunk, as well as the following:
{
    "simplify_tolerance": 0.0001,
    "tms_id": "WorldCRS84Quad",
    "z_range": [0, 11],
    "statistics": [
        {
            "name": "polygon_count",
            "weight_by": "count",
            "property": "centroids_per_pixel",
            "aggregation_method": "sum",
            "resampling_method": "sum",
            "val_range": [0, null],
            "nodata_val": 0,
            "nodata_color": "#ffffff00",
            "palette": ["#d9c43f", "#d93fce"]
        },
        {
            "name": "coverage",
            "weight_by": "area",
            "property": "area_per_pixel_area",
            "aggregation_method": "sum",
            "resampling_method": "average",
            "val_range": [0, 1],
            "nodata_val": 0,
            "nodata_color": "#ffffff00",
            "palette": ["#d9c43f", "#d93fce"]
        }
    ],
    "deduplicate_at": ["staging"],
    "deduplicate_method": "neighbor",
    "deduplicate_keep_rules": [["staging_filename", "larger"]],
    "deduplicate_overlap_tolerance": 0.1,
    "deduplicate_overlap_both": false,
    "deduplicate_centroid_tolerance": null
  }

Package              Version
-------------------- -----------
addict               2.4.0
affine               2.3.1
asttokens            2.1.0
attrs                22.1.0
backcall             0.2.0
bcrypt               4.0.1
certifi              2022.9.24
cffi                 1.15.1
charset-normalizer   2.1.1
click                8.1.3
click-plugins        1.1.1
cligj                0.7.2
coloraide            0.18.1
colormaps            0.3
comm                 0.1.0
ConfigArgParse       1.5.3
contourpy            1.0.6
cryptography         38.0.3
cycler               0.11.0
Cython               0.29.32
dash                 2.7.0
dash-core-components 2.0.0
dash-html-components 2.0.0
dash-table           5.0.0
debugpy              1.6.3
decorator            5.1.1
dill                 0.3.6
entrypoints          0.4
executing            1.2.0
fastjsonschema       2.16.2
filelock             3.8.0
Fiona                1.8.22
Flask                2.2.2
fonttools            4.38.0
geopandas            0.11.1
globus-sdk           3.14.0
idna                 3.4
importlib-metadata   5.0.0
ipykernel            6.18.0
ipython              8.6.0
ipywidgets           8.0.2
itsdangerous         2.1.2
jedi                 0.18.1
Jinja2               3.1.2
joblib               1.2.0
jsonschema           4.17.0
jupyter_client       7.4.7
jupyter_core         5.0.0
jupyterlab-widgets   3.0.3
kiwisolver           1.4.4
laspy                2.3.0
llvmlite             0.39.1
lz4                  4.0.2
MarkupSafe           2.1.1
matplotlib           3.6.2
matplotlib-inline    0.1.6
morecantile          3.2.1
munch                2.5.0
nbformat             5.5.0
nest-asyncio         1.5.6
numba                0.56.4
numpy                1.22.4
open3d               0.16.0
packaging            21.3
pandas               1.5.1
paramiko             2.12.0
parsl                2022.11.14
parso                0.8.3
pdgpy3dtiles         0.0.1
pdgraster            0.1.0
pdgstaging           0.1.0
pexpect              4.8.0
pickleshare          0.7.5
Pillow               9.3.0
pip                  22.2.2
platformdirs         2.5.4
plotly               5.11.0
prompt-toolkit       3.0.33
psutil               5.9.4
psycopg2-binary      2.9.5
ptyprocess           0.7.0
pure-eval            0.2.2
pycparser            2.21
pydantic             1.10.2
pygeos               0.13
Pygments             2.13.0
PyJWT                2.6.0
PyNaCl               1.5.0
pyparsing            3.0.9
pyproj               3.4.0
pyquaternion         0.9.9
pyrsistent           0.19.2
python-dateutil      2.8.2
pytz                 2022.6
PyYAML               6.0
pyzmq                24.0.1
rasterio             1.3.4
requests             2.28.1
Rtree                0.9.7
scikit-learn         1.1.3
scipy                1.9.3
setproctitle         1.3.2
setuptools           65.5.0
Shapely              1.8.5.post1
six                  1.16.0
snuggs               1.4.7
stack-data           0.6.1
tblib                1.7.0
tenacity             8.1.0
threadpoolctl        3.1.0
tornado              6.2
tqdm                 4.64.1
traitlets            5.5.0
triangle             20220202
typeguard            2.13.3
typing_extensions    4.4.0
urllib3              1.26.12
viz-3dtiles          0.0.1
wcwidth              0.2.5
Werkzeug             2.2.2
wheel                0.37.1
widgetsnbextension   4.0.3
zipp                 3.10.0

@julietcohen Although you also found an IndexError, it looks like this one is being caused by something other than the pygeos library. I was able to reproduce the error thanks for your very helpful notebook! Since it occurred whether or not pygeos was installed, I moved this to its own issue in the viz-staging repo (https://github.com/PermafrostDiscoveryGateway/viz-staging/issues/12)

@robyngit Thank you for making a new issue for this. I've been troubleshooting with no resolution so far, but I'll document what I've tried in that new issue. Based on your suggestion, I created a new environment to install my locally cloned repo viz-staging, and I'm editing TileStager.py

Update on the 3D Tiles error
reproducing the error:

Install py3dtiles, shapely < 2, and pygeos:

pip install git+https://github.com/PermafrostDiscoveryGateway/py3dtiles geopandas==0.12.1 pygeos==0.13 shapely==1.8.5.post1

Run this test script, which creates a 3D box (with z-coordinate 10), re-projects it to the Cesium EPSG, and then "triangulates" the polygon as we do when generating our 3D tiles:

# test.py
from shapely.geometry import box, Polygon, MultiPolygon
from py3dtiles import TriangleSoup
import geopandas as gpd

# print(gpd.show_versions())

polygon = box(0, 0, 1, 1)
g = gpd.GeoDataFrame(geometry = [polygon], crs=4326)
g['geometry'] = g['geometry'].apply(lambda p: Polygon([(x, y, 10) for x, y in p.exterior.coords]))
g = g.to_crs(epsg=4978)
print(g) # <- ⛔ POLYGON Z without pygeos; POLYGON with pygeos
polygon=Polygon(g["geometry"][0])
multipolygon = MultiPolygon([polygon])
multipolygon_wkb = multipolygon.wkb
ts = TriangleSoup.from_wkb_multipolygon(multipolygon_wkb)

print('🎉 SUCCESS!')

See the output, where the reprojected Geodataframe contains a POLYGON rather than the expected POLYGON Z (so it has 2 dimensions rather than three), and for that reason, the conversion fails:

                                            geometry
0  POLYGON ((6377165.57884<PHONE_NUMBER>4, 6376200....
Traceback (most recent call last):
 ....
packages/py3dtiles/wkb_utils.py", line 210, in triangulate
    (curr_edge[1] - next_edge[1]) * (next_edge[2] + curr_edge[2]),
IndexError: index 2 is out of bounds for axis 0 with size 2

uninstall pygeos and run the test script again again.

pip uninstall pygeos
python test.py

See that now we do get a POLYGON Z and the transformation happens successfully:

                                            geometry
0  POLYGON Z ((6377175.57732<PHONE_NUMBER>6 0.00000...
🎉 SUCCESS!

Notes

Using the new Shapely 2+ without pygeos also causes this error.
I think these reported errors may be related: https://github.com/shapely/shapely/issues/1524,  https://github.com/shapely/shapely/issues/1573

From the docs:

The use of PyGEOS is experimental! Although it is passing all tests, there might still be issues and not all functions of GeoPandas will already benefit from speedups (one known issue: the to_crs coordinate transformations lose the z coordinate)

The issue https://github.com/geopandas/geopandas/issues/1345 confirms that this problem persists with Shapely >= 2.0, but it seems the developers are working on a fix: https://github.com/geopandas/geopandas/pull/2641

For viz_3dtiles, found a work around that transforms the geometries themselves using shapely, rather than converting the CRS with geopandas, where we are somehow losing the z-coordinate. I've tested this method with a small sample and everything looks good.
In the other PDG packages, I removed the requirement for pygeos, and upgraded version requirements to geopandas >= 0.12 and shapely shapely >= 2.0b2.
Changes in all packages are in branches named feature-shapely2-support
Left TODO:

[ ] Test all changes with a larger data sample (e.g. part of IWP)
[ ] Measure time difference in creating 3D tiles (is it slower than before?)

Updates to viz_3dtiles and Shapely 2+ & GeoPandas 0.12+ requirements are merged into the main branches now. The official shapely 2.0 release is expected to come in 1-2 weeks, so the timing is good to have our packages ready for those changes.

Although this issue is closed, I wanted to note that geopandas just released a fix for the workaround I described above, and shapely officially released version 2. There are PRs in all three viz-* packages to reflect these changes, including reverting the workaround to make use of the geopandas fix.


Integrate INLA model class

Biggest feature for the first prototype!

[x] Implement the INLA model class
[x] Write example python script similar to the one for Binomial
[ ] Figure out toggleable parameters for Gary to play around with

I'm going to close this since we have lots of kevlar+inla stuff happening these days! I'm not sure what the goal was for the last bullet point, but it doesn't seem like a priority right now.


Add reexports for defaultEndpoint, defaultTlsEndpoint, defaultScriptUrlPattern

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


F3 shortcut key support in WinForms DataGridView

These changes are made to reflect a new F3 shortcut key support for sorting WinForms DataGridView columns. The support was added in .NET Framework 4.7.2.

@foreverest,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.
It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@foreverest, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

@Tanya-Solyanik .NET Framework 4.7.2 is not even out yet. So is it ok to merge this now?
Also, do we also need to call out this only works in .NET Framework 4.7.2 and later versions?

This should not be merged yet. This will be eventually shipped as an insider preview for 4.7.2 . But we are not shipping devpack, so we don't have to merge docs yet.
Good point about the conditions when this is enabled. This is quirked, but the quirk name is not finalized , so this part can't be documented yet. We will cover this in the compat docs.

4.7.2 early access was released today. Is this still valid? Also, since the docs are somewhat versionless right now, should we add info that F3 is only supported in 4.7.2 and later versions @Tanya-Solyanik?

Sounds good, thank you!

@mairaw Do you want to approve this PR? I see that you've added the verify build before merge label, but it doesn't have an approved review. I also see that you've reviewed it a few times.

@Tanya-Solyanik I've made the changes I wanted. Ok to publish this now right? Thanks!
And thanks @foreverest for submitting this PR with the changes.

Thanks @Tanya-Solyanik. I changed the sentence a bit to future proof the sentence as well.

@mairaw @Tanya-Solyanik Thank you!


problem reading formula values

readxl_example.xlsx
The problem with the above file is that if you read in a formula, the formula evaluates to 0. At the very least, the formula should evaluate to the formula. For example, the ideal behavior might be the first column reads as text... "=DATE(2015,1,1)".
An alternative would be to evaluate the formula or use the preloaded value, but I assume the first might be a pain in the behind and the second might lead to unpredictable behavior.

read_excel("readxl_example.xlsx")

The problem with the above file is that if you read in a formula, the formula evaluates to 0

I don't see that. Can you provide a reprex showing exactly what happens for you?
library(readxl)
read_excel("iss/readxl_example.xlsx")
#>        hello hadley     thanks in advance
#> 1 2015-01-01      5 "1/1/2015"  5      10
#> 2 2015-01-01      5 "1/1/2015"  5      10
#> 3 2015-01-01      5 "1/1/2015"  5      10
#> 4 2015-01-01      5 "1/1/2015"  5      10
#> 5 2015-01-01      5 "1/1/2015"  5      10
#> 6 2015-01-01      5 "1/1/2015"  5      10
#> 7 2015-01-01      5 "1/1/2015"  5      10
#> 8 2015-01-01      5 "1/1/2015"  5      10
#> 9 2015-01-01      5 "1/1/2015"  5      10

How to provide a readxl reprex
We're in a much better position to address your issue if you can provide a reprex (reproducible example). Provide as much of this as you can:

An actual xls or xlsx file. Pick one:

Your personal xls or xlsx: try to strip it down to the minimal size and complexity to demonstrate your point. And, obviously, remove any sensitive data.
A publicly available xls or xlsx: provide URL and the code you used to download.

A small bit of R code that uses readxl on the provided xls or xlsx file and demonstrates your point.

Consider using the reprex package to prepare this. In addition to nice formatting, this ensures your reprex is self-contained.

Any details about your environment that seem clearly relevant, such as operating system.
reprex(..., si = TRUE)
will append a standard summary, folded neatly away, at the bottom of your reprex.

How to provide your own xls/xlsx file? In order of preference:

Attach the file directly to your issue. Instructions are always at the bottom of the issue or comment box.
Share via DropBox or Google Drive and provide the link in your issue.
Explain you absolutely cannot provide a relevant file via github.com and offer to provide privately.
Don't share a file and realize you're hoping for, e.g., a bug fix with no concrete example to go on.


Remove unused imports

thats enough pulls for tonight

I was about to do this before the next release because my IDE just kinda adds any imports it wants and doesn't tell me. Thanks!


Update querycontextattributes--schannel.md

Typo, "constrained delegation" should be "security package"

Thanks for your contribution @fran-ki.  I've merged your changes and they should be live soon.


fix: docs: keycloak user migration api error

The current version of the migration guide from keycloak does not work and is not correct with the zitadel import user api, see https://zitadel.com/docs/apis/resources/mgmt/management-service-import-human-user.
This should fix that:)
someone also noted this in the discord a while ago: https://discord.com/channels/927474939156643850/1206634568216616980
this pr fixes that small issue.
Definition of Ready

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[x] PR is linked to the corresponding user story
[x] Acceptance criteria are met
[x] All open todos and follow ups are defined in a new ticket and justified
[x] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[x] No debug or dead code
[x] My code has no repetitions
[x] Critical parts are tested automatically
[x] Where possible E2E tests are implemented
[x] Documentation/examples are up-to-date
[x] All non-functional requirements are met
[x] Functionality of the acceptance criteria is checked manually on the dev system.

Hey @github-tijlxyz thanks for the fix.
If you like to get a gift from us, please write an email to<EMAIL_ADDRESS>


The app window is glitchy

Type: Bug
The app window is glitchy
VS Code version: Code 1.74.0 (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:38:16.075Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.79GB (3.77GB free)

Process Argv
--crash-reporter-id 59ade396-1fd8-4530-9113-fa2bf2af5981

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

ue4-snippets
CAP
2.0.1

doxdocgen
csc
1.4.0

better-cpp-syntax
jef
1.17.2

remote-containers
ms-
0.266.1

remote-ssh
ms-
0.94.0

remote-wsl
ms-
0.72.0

cmake-tools
ms-
1.12.27

cpptools
ms-
1.13.7

cpptools-extension-pack
ms-
1.3.0

remote-explorer
ms-
0.0.3

cmake
twx
0.0.17

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848cf:30577861
nodejswelcome1:30587005
2e4cg342:30602488
gswce1:30612156
iaj6b796:30613358
dbltrim-noruby:30604474
f6dab269:30613381
fim-prod:30623723

/needsMoreInfo
Is it reproducible if you disable GPU acceleration?
You can do that with --disable-gpu CLI flag or as permanent launch setting https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

The app works well now, thanks. Is the issue with my gpu? Any solutions for that, I'm not sure what the problem with it is.
-------- Original message --------From: Andrii Dieiev @.> Date: 12/12/22  4:40 AM  (GMT-05:00) To: microsoft/vscode @.> Cc: Nino @.>, Author @.> Subject: Re: [microsoft/vscode] The app window is glitchy (Issue #168812)
/needsMoreInfo
Is it reproducible if you disable GPU acceleration?
You can do that with --disable-gpu CLI flag or as permanent launch setting https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hey @andreamah, this issue might need further attention.
@Atikk, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


add Farsi / Persian language

Farsi / Persian translation

Hey there! Thank you so much for diving in and adding a new language translation. Just a quick heads-up, though – typically, we manage all our translations through Crowdin to ensure consistency across all languages and help the community to make it easy. It's a little detail that helps us a lot, but no worries at all this time around. Currently, our setup doesn't fully support right-to-left (RTL) languages, and adapting to RTL involves complexities that we're still figuring out. Thanks again for your understanding and support 🙂

Hi. Thank you for your review.
Yes, I understand your terms. I hope RTL support is added to the widget for languages like Farsi or Arabic.


Allow to use container already present in the DOM

allows to resolve #625

Personally, I wouldn't really encourage this as it also tends to cause many display issues.  As I am essentially inactive now, though, I would leave it up to a new maintainer to make a final decision (if one hopefully comes along).


go: Fix some lint complains

The three Errorf lines where called out by one downstream project.
Some versions of lint seem pickier than others ...
Signed-off-by: Rolf Neugebauer<EMAIL_ADDRESS>

Error's should be formatted as %s which DTRT, using %v prints opaque internal pointers and the like.

Ah, I think I just copied this from somewhere else...fixed now

LGTM once CI says it is ok.


Update landscape.yml

RISC-V Landscape | Pre-submission checklist:

NOTE: Please ensure you've completed each of these items after submitting your pull request:

[x] Have you included a repo_url? Please select the most suitable GitHub repository for your project, rather than a GitHub organization.
[x] Is your project open source?
[x] Is the project currently and actively maintained (e.g., accepts pull requests, responds to issues)?
[x] Have you chosen the most appropriate (existing) category for your project?
[x] Does your submission adhere to the other guidelines from the new entries section?
[x] Have you added your logo's SVG to the hosted_logos directory and referenced it in the landscape.yml entry?
[x] Does your logo clearly display the project/product name and follow the other logo guidelines?
[x] Does the project name correspond with the text on the logo?
[x] Have you verified the accuracy of the Crunchbase data for your organization, including headquarters and LinkedIn?
[x] Approximately 5 minutes after opening the pull request, the RISC-V_Bot will post the URL for your staging server. Have you reviewed the site, confirmed it appears as expected, and then added a comment to the PR stating "LGTM"?

LGTM


Resolve system variables in the defaultInterpreterPath entry

Issue from https://github.com/microsoft/vscode-python/issues/18207, fixed by https://github.com/microsoft/vscode-python/pull/18215

Repro steps:

Have a workspace with Python files and a .code-workspace file
Create a subfolder in the workspace, and then create a virtual environment in that subfolder (any flavor of Python 3 works):   cd subfolder; python3 -m venv .venv
Add the following to the .code-workspace file:

{
    "settings": {
        "python.defaultInterpreterPath": "${workspaceFolder}/path/to/python.exe",
    }
}

On windows the path to the python executable will be something like ${workspaceFolder}/<folder>/.venv/Scripts/python.exe, while on Unix it will be ${workspaceFolder}/<folder>/.venv/bin/python.exe

Open the workspace and activate the extension
Run the Select Interpreter command, and verify that the path in the Use Python from 'python.defaultInterpreterPath' setting entry contains no system variables

/verified


Add stattrak extension

Description
Stattrak Esports
Everything you need about esports

Esports tournaments: search for esports tournaments
Esports matches: search for esports matches

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Is this ready for another review?

r

Not yet, I'm working on some improvements.

Is this ready for another review?

Not yet, I'm working on some improvements.

Converting into a draft then 🙂


Is wasm compatible with ie and Sogou browsers?

Is wasm compatible with ie and Sogou browsers?

Based from the information here:

And rustwasm has information on why they do not support IE:
https://rustwasm.github.io/wasm-bindgen/reference/browser-support.html


Copy / Paste of cells in new notebook editor links them

Pretty sure this is not intentional. When I copy a cell and then paste it, the two cells are then linked. They have the same execution count and typing in one also edits the other. So I can't copy a cell and then edit the copy with some changes. It's also causing some strange hover issues.

@IanMatthewHuff was investigating this as part of GA but I can't repro, was there anything special you did to get this to happen?

@joyceerhl Nope, just a copy / paste of a cell using the cell copy jupyter keyboard commands. Don has made some changes since then, so might have been fixed.


Allow GetRecords to consume closed shards + StreamARN support

Changes Introduced
Prior to this PR, GetRecords would not allow consumption of closed shards, which meant that users who scaled their streams could not consume from them anymore. This is incorrect behavior. That restriction is removed.
This PR also adds StreamARN parameter support to several other API calls, as Kinesis has added the same:

AddTagsToStream
RemoveTagsFromStream
DecreaseStreamRetentionPeriod
IncreaseStreamRetentionPeriod
DisableEnhancedMonitoring
EnableEnhancedMonitoring
GetRecords
GetShardIterator
ListShards
ListTagsForStream
MergeShards
SplitShard
StopStreamEncryption
StartStreamEncryption
UpdateShardCount

Applicable linked issues
N/A
Checklist (check all that apply)

[x] This change maintains backwards compatibility
[x] I have introduced tests for all new features and changes
[ ] I have added documentation covering all new features and changes
[x] This pull-request is ready for review

CC @whummer - FYI


[SPARK-42465][CONNECT] ProtoToPlanTestSuite should use analyzed plans instead of parsed plans.

What changes were proposed in this pull request?
This makes ProtoToPlanTestSuite use analyzed plans instead of parsed plans.
Why are the changes needed?
This is to increase the fidelity of the ProtoToPlanTestSuite, especially since we are going to be adding functions. Functions are special because the spark connect planner leaves them unresolved, the actual binding only happens in the analyzer. Without running the analyzer we would not know if the bindings are correct.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It is a test change.

For the reviews, I have manually tested this with 2.13.

Alright merging this.

For the reviews, I have manually tested this with 2.13.

Thank you so much, @hvanhovell !


Support Tekton v1 APIs

Feature request
With Tekton Pipelines v0.43.0, we have our first version of Tekton v1 APIs. Results should be able to support reconciliation of v1 objects.
Use case
Archive Tekton v1 versions of TaskRun and PipelineRun objects.

It appears that dependabot's blind update of pipelines to 0.43.0 introduced breaking changes: #304.
I think we should hold on this until v0.5.0 is released.

/assign khrm

I think we should do a release of v0.5.0 with v1. I would raise the pr. on Monday. v1 has been out for a while and now it doesn't make sense to do a v0.5.0 without v1.
@vdemeester

/area roadmap

@khrm something that we need to consider is backwards compatibility. Results can be backwards-compatible if we provide an option for v1beta1 reconciliation. That won't be the case if we only reconcile v1 APIs. We have a choice here:

Keep it simple, only reconcile v1 APIs, and require Pipelines v0.43.0 or higher.
Add the complexity of reconciling one of two apiVersions.

I'm inclined to favor option 1 after we cut a release of our current body of work.

@adambkaplan We decided to do a release based on v1beta1 APIs in the WG call. Afterward, we would upgrade.

@adambkaplan We decided to do a release based on v1beta1 APIs in the WG call. Afterward, we would upgrade.

Does that means v1beta1 api will be EOL after we upgraded to v1?

/lifecycle frozen
:thinking: I wonder if we need a TEP to discuss this. We currently reconcile v1beta1 APIs across the board. We could employ similar techniques that k8s does if we switch the "storage" to v1 for PipelineRun and TaskRun data, but allow clients to specify if they want PipelineRun/TaskRuns with v1beta1 apiVersion.
@dibyom @alan-ghelardi @khrm @vdemeester thoughts?

It seems that v1beta1 is now deprecated. Previously, annotations were used to transfer information during conversion. @vdemeester, do we truly need to provide support for this? Wouldn't it be simpler to just merge #526 after rebase? The results is still in alpha.

@khrm So as long as tektoncd/pipeline publish v1beta1, it's ok for results to use it. And v1beta1 is there for at least a year (counting from ~21st of July). This gives time for results to decide how to handle this.
I think at some point, results should switch to using v1 objects by default (as "the thing that gets watched") while still being able to read older objects (v1beta1). And it could even be done gradually through a feature flag, that would initially default to v1beta1 and at some point default to v1 instead.
cc @tektoncd/chains-maintainers as this is very similar.

We store v1beta1 stuff as jsonb in postgres.  And the field in the protobuff is also a byte. So we will be able to show v1beta1 even after we move to v1. New objects will be stored as v1 and show as v1 when we fetch them. The old data will continue to show as v1beta1.

We store v1beta1 stuff as jsonb in postgres. And the field in the protobuff is also a Any. So we will be able to show v1beta1 even after we move to v1. New objects will be stored as v1 and shown as v1 when we fetch them. The old data will continue to show as v1beta1. So we can move to v1 for watching and storing now.
@vdemeester @dibyom @sayan-biswas

This creates an interesting challenge for long-running instances. When we switch to reconcile with v1 objects, the database will have some information as v1, and others as v1beta1. This can be a challenge for clients (cli, web consoles) that currently expect v1beta1 objects.
What can we do here?

Nothing? At least notify clients that the data won't be changed.
Import the conversion functions from tektoncd/pipeline and render v1 objects in the apiserver?
Convert objects from v1beta1 to v1 when they are accessed?
Launch a job that does the object conversion in the background?

Note that many of the options above are not mutually exclusive.

A combination of the 2nd and 3rd option would solve the purpose, assuming that no clients will try to fetch the objects from the database directly. Most of the process would be transparent.

Launch a job that does the object conversion in the background?

This sounds a bit like the storage version migrator but for the results db: https://github.com/kubernetes-sigs/kube-storage-version-migrator/blob/master/USER_GUIDE.md

This sounds a bit like the storage version migrator but for the results db: https://github.com/kubernetes-sigs/kube-storage-version-migrator/blob/master/USER_GUIDE.md

Exactly!

Is this issue planned to implement in some near future?

Yes. I will target it after Event storage.

For the Event storage we are waiting too, so this gonna be a big release for us. Thank you @khrm.


Use theme breakpoints throughout; remove individual @media rules

Overview
Design decision was made to use consistent breakpoints, and to use MUI for that.
Action Items
Remove all @media rules and replace with [theme.breakpoint.up(x)] or similar.
Resources/Instructions
For any theme-related change, UI-THEME-STYLES.md is a good reference.
Also see https://material-ui.com/customization/breakpoints/#breakpoints

1.Progress: started working
2. Blockers: none
3. availability: medium
4.ETA: By Tuesday

Team decided to make "How to Do It" in the footer as a FAQ. Per @cnk FAQs are currently limited to text only.  There will be a link for this FAQ to the Tag Generator instructions page for full view with images.
@Olivia-Chiong find Figma "How to Do it" page for @nrrao

@chalimar are you able to find the "How to do it" Figma page please? I can see archives so don't know where to find this.

Hi Olivia,
This page was never created. In the early process of IA, we thought it would be ideal to create a page that leads to a tutorial on how to use the tag generator.

@nrrao In this case, I suggest we leave the page as is. Also no need to change it for landing page.

We can close this issue as there is no need to remove breakpoints for the landing page and"How to do it " page.


debug flutter app in atom not in browser

It's in the works! No eta, but its something we're actively working on.
On Nov 13, 2015 1:45 AM, "tain335"<EMAIL_ADDRESS>wrote:

—
Reply to this email directly or view it on GitHub
https://github.com/flutter/atom-flutter-dev/issues/12.


Fails to build with pybind11 2.6.0

The pybind11 package in Debian was recently updated to 2.6.0 which causes the pyosmium build to fail:
CMake Warning (dev) at /usr/lib/cmake/pybind11/pybind11Common.cmake:167 (if):
  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  IN_LIST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  /usr/lib/cmake/pybind11/pybind11Config.cmake:249 (include)
  CMakeLists.txt:19 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at /usr/lib/cmake/pybind11/pybind11Common.cmake:167 (if):
  if given arguments:

    "11" "IN_LIST" "supported_standards"

  Unknown arguments specified
Call Stack (most recent call first):
  /usr/lib/cmake/pybind11/pybind11Config.cmake:249 (include)
  CMakeLists.txt:19 (find_package)

-- Configuring incomplete, errors occurred!
See also "/build/pyosmium-3.0.1/build/temp.linux-x86_64-3.9/CMakeFiles/CMakeOutput.log".
See also "/build/pyosmium-3.0.1/build/temp.linux-x86_64-3.9/CMakeFiles/CMakeError.log".
Traceback (most recent call last):
  File "/build/pyosmium-3.0.1/setup.py", line 121, in <module>
    setup(
  File "/usr/lib/python3/dist-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python3.9/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib/python3.9/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python3.9/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/usr/lib/python3.9/distutils/command/build.py", line 135, in run
    self.run_command(cmd_name)
  File "/usr/lib/python3.9/distutils/cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "/usr/lib/python3.9/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/build/pyosmium-3.0.1/setup.py", line 67, in run
    self.build_extension(ext)
  File "/build/pyosmium-3.0.1/setup.py", line 110, in build_extension
    subprocess.check_call(['cmake', ext.sourcedir] + cmake_args, cwd=self.build_temp, env=env)
  File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '/build/pyosmium-3.0.1', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/build/pyosmium-3.0.1/.pybuild/cpython3_3.9_pyosmium/build', '-DPYTHON_EXECUTABLE=/usr/bin/python3.9', '-DCMAKE_BUILD_TYPE=Release']' returned non-zero exit status 1.

The following patch fixes the issue:
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,9 +8,9 @@ include_directories(SYSTEM ${OSMIUM_INCL
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/lib)

 if(MSVC)
-    set(PYBIND11_CPP_STANDARD /std:c++14)
+    set(CMAKE_CXX_STANDARD 14)
 else()
-    set(PYBIND11_CPP_STANDARD -std=c++11)
+    set(CMAKE_CXX_STANDARD 11)
 endif()

 if(PYBIND11_PREFIX)

Per: https://github.com/pybind/pybind11/blob/v2.6.0/docs/upgrade.rst#cmake-support

PYBIND11_CPP_STANDARD=<platform-flag> is deprecated, please use CMAKE_CXX_STANDARD=<number> instead, or any other valid CMake CXX or CUDA standard selection method, like target_compile_features.

Thanks for tracking this down. I'll do a proper release with support for pybind11 2.6 in the next couple of days.

I went for setting both PYBIND11_CPP_STANDARD and CMAKE_CXX_STANDARD to be backwards compatible with older pybind11 versions.
You can now also set CMAKE_CXX_STANDARD=14 via an environment variable for setup.py. Only 11 and 14 are known to work at the moment.


syncthingtray-minimal: 1.6.2 -> 1.6.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Martchus/syncthingtray/releases.
meta.description for syncthingtray-minimal is: Tray application and Dolphin/Plasma integration for Syncthing
meta.homepage for syncthingtray-minimal is: https://github.com/Martchus/syncthingtray
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.3 with grep in /nix/store/rrzp8ddjxjwr4bf1kg6w8i59y07bmycd-syncthingtray-1.6.3
found 1.6.3 in filename of file in /nix/store/rrzp8ddjxjwr4bf1kg6w8i59y07bmycd-syncthingtray-1.6.3

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

syncthingtray
syncthingtray-minimal

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rrzp8ddjxjwr4bf1kg6w8i59y07bmycd-syncthingtray-1.6.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A syncthingtray-minimal https://github.com/r-ryantm/nixpkgs/archive/e09a214457b83126ab2a70f1e93c684fc080faa9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e09a214457b83126ab2a70f1e93c684fc080faa9#syncthingtray-minimal

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rrzp8ddjxjwr4bf1kg6w8i59y07bmycd-syncthingtray-1.6.3
ls -la /nix/store/rrzp8ddjxjwr4bf1kg6w8i59y07bmycd-syncthingtray-1.6.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

syncthingtray
syncthingtray-minimal

Maintainer pings
cc @doronbehar for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

I saw that the tests failed on aarch64-linux. I'm sorry but I'm not capable of fixing those / making sure that disabling them works. The syncthingtray package doesn't seem to fail. I'd be happy to review a PR fixing syncthingtray-minimal for aarch64-linux.

Closing as this was merged in https://github.com/NixOS/nixpkgs/pull/360570 .


VMess User level Issue

提交 Issue 之前请先阅读 Issue 指引，然后回答下面的问题，谢谢。
Please read the instruction and answer the following questions before submitting your issue. Thank you.

你正在使用哪个版本的 V2Ray？（如果服务器和客户端使用了不同版本，请注明）
What version of V2Ray are you using (If you deploy different version on server and client, please explicitly point out)?

Latest

你的使用场景是什么？比如使用 Chrome 通过 Socks/VMess 代理观看 YouTube 视频。
What's your scenario of using V2Ray? E.g., Watching YouTube videos in Chrome via Socks/VMess proxy.

Chrome->Socks->VMess->       VMess(dynamic port)->Freedom

你看到的不正常的现象是什么？
What did you see?

I switched my user level to 0 (which means "strict" level), and so many things happened.

The speed is slower. When the user level is 1, it's ~3MB/s. But when the user level is 0, ~1MB/s. It's based on several tests.
The connection speed is slower. I tested this in Chrome with Switch sharp. When the user level is 1, I can open gist.github.com in seconds. But when the level is 0, I can see "waiting for response....." for a loooooooooooong time(~30s) and "establishing security connection" for a loooong time (~10s).
When the level is 1, I can open my computer at morning, leave it alone, and when back to my computer at night, it works fine, not only speed/connection but also the log. But when switch user level to 0, when I come back to my computer at night, VR seems not working. I can not connect with other websites through VR, and server log booms, filled with [Warning]Transport|Internet|TCP: failed to accepted raw connections > Retry: [accept tcp [::]:63363: use of closed network connection] > Retry: all retry attempts failed and the like. I tried to restart the VR process/service both on server and client, not working. So I have to reboot my client computer, OK.

In a word, if your VMess working incorrect, try  to set user level to 1.
I wonder what exactly "user level =0" did?(Oh I remember that you posted it about a year ago... but I forgot that post)

你期待看到的正确表现是怎样的？
What's your expectation?

请附上你的配置文件（提交 Issue 前请隐藏服务器端IP地址）。
Please attach your configuration file (Mask IP addresses before submit this issue).
seam as demo socks_vmess.config
Server Configuration File（服务器端配置文件）:
seam as demo vmess_freedom.config

请附上出错时软件输出的日志。在 Linux 中，日志通常在 /var/log/v2ray/error.log 文件中。
Please attach the log file, especially the bottom lines if the file is large. Log file is usually /var/log/v2ray/error.log on Linux.
Server Log File（服务器端日志）:

    [Warning]Transport|Internet|TCP: failed to accepted raw connections > Retry: [accept tcp [::]:63363: use of closed network connection] > Retry: all retry attempts failed

According to the official documentation: when the user level is 0, this user is not trusted, v2ray will apply more strict security restrictions to this user[1].
Moreover, referring to this issue#429, user level actually means Timeout setting, when the user lever greater than 0, this user has a longer timeout.
[1] https://www.v2ray.com/chapter_02/protocols/vmess.html

I have no idea how this happens. As mentioned above, user level only affects timeout. In another word, if the connection doesn't timeout, the speed should be the same.

Closing due to lack of information.


Convert to WebP on the fly?

Hi,
first of all, I think that is an interesting project.
I have a question about Convert to WebP on the fly, I not understand the objective.
If the original image is an JPEG or PNG format, and the component generate the WebP on the fly, the user are downloading the "unoptimized" image, right?

Wait this component is to use with a Next.js project.
I have not said anything 😅

It can also be used outside of a next.js project. But you are right, on the fly is maybe the wrong naming. The image gets converted to WebP during a webpack build, so the browsers only download the webp version in the end if they support it. I'll change the naming ;)


Detached mode fails to initialize on iOS 13.6 and below

Description
On iOS 13.6 and below the detachedMediaQuery fails to create an event listener and bugs out.
NOTE: If I set detachedMediaQuery: 'none' it works perfectly. I assume it can't read the --aa-detached-modal-media-query?
Solution might be to fall back (disable the detached mode) if the CSS variable can't be read.
Reproduction
Steps
0, have an iOS 13.6 device

Go to https://4keez.csb.app/
autocomplete crashes,

https://user-images.githubusercontent.com/21248854/120100729-8ea34880-c142-11eb-9f31-e84dfe39af91.mp4
Expected behavior
It should initialize / fall back to disable it completely.
Environment

OS: iOS 13.6 and below
Browser: Chrome, Safari
Autocomplete version: 1.1.0

While iOS 13.6 is not the latest version, but some still has this outdated update and unfortunately this bug ruins the search experience completely for them as the autocomplete crashes and fails to load.

Update:
According to this table Compatibility table
Prior to Safari 14, MediaQueryList is based on EventTarget, so you must use addListener() and removeListener() to observe media query lists.
Autocomplete 1.1.0 however uses this:
https://github.com/algolia/autocomplete/blob/970ee6acfcb0b7cbb699acbe274fec4e5e1c3a4e/packages/autocomplete-js/src/autocomplete.ts#L304
Might need to check if addEventListener is supported, if not the deprecated addListener() and removeListener() should be used.
Thanks!

Thanks for the report. We indeed need to use addListener/removeListener to support these versions.
We'll include a fix in the next release, coming this week.


Add supported browsers to README

Input uses the EventTarget constructor, which has only been available from Safari / iOS 14 onwards (released 2020-09-16). It might be worth mentioning known restrictions in the project's README.
For example, the Tangle notebook makes use of the Input widget, and cannot be used with Safari 13 or earlier.

Sorry, but I’m not planning on maintaining this information.


Preview md

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 10.0.10586
Extensions:

Extension
Author
Version

vscode-icons
robertohuertasm
7.2.0

Steps to Reproduce:

Please provide some information about the problem

Dup of #20528


Move footer options

Before Submitting Your Feature Request

[X] Check that there isn't already a similar feature request to avoid creating a duplicate.
[X] I have seen the FAQ.

Problem
Maccys footer menu takes up way to much space and is in the way.
Solution
Move the footer menu to a right click on the menubar icon.

You can hide it in settings if you don't need it.

But how will I get back into settings? Or how will I clean the clipboard? I know theres a settings keyboard shortcut, but those are easy to forget...

The shortcuts are a way to go!

Settings - Command+, - this is used in every native macOS application
Clear - Command+Option+Delete


agent: Invalidate invalid claims

Resolves #570

One important note, I just realized. When you change the state machine, please make sure that the following case can occur.
We have an unfilled request, but it got challenged by someone. Still, nobody made the invalidation. This happens exactly in the self-challenge  case. One solution could be to not process the event if we are still in the fill_wait_time. And once the fill_wait_time is passed, we process the claim once more in the started state (to trigger the invalidation) and then process the challenge state. In this solution we would need to make sure to not challenge it in the same cycle.
Let's discuss in private if you have further questions


Empty tokens should not fail scan

Is your feature request related to a problem? Please describe.
When scanning the following code, kics reports a password where non is:
  after_script:
    - >
      if [ "$CI_SAST_TOKEN" == '' ];
      then
        echo "Please create a CI_SAST_TOKEN with API access here ${CI_PROJECT_URL}/-/settings/access_tokens"
        echo "And put the CI_SAST_TOKEN into the CI/CD variables ${CI_PROJECT_URL}/-/settings/ci_cd"
      fi

Scan result:
> ~/dev/kics/bin/kics scan --minimal-ui -q ~/dev/kics/assets/queries/ -p ${PWD} -o ./

Scanning with Keeping Infrastructure as Code Secure snapshot-a85031d6

Preparing Scan Assets: Done
Executing queries: [---------------------------------------------------] 100.00%

Files scanned: 1
Parsed files: 1
Queries loaded: 279
Queries failed to execute: 0

------------------------------------

Passwords And Secrets - Generic Token, Severity: HIGH, Results: 1
        [1]: license_check.yml:3

Results Summary:
HIGH: 1
MEDIUM: 0
LOW: 0
INFO: 0
TOTAL: 1

Results saved to file results.json
Generating Reports: Done
Scan duration: 5.759818229s

Describe the solution you'd like
In my opinion this should not trigger a finding.
Additional context
using latest master-build:
> ~/dev/kics/bin/kics version
Keeping Infrastructure as Code Secure snapshot-a85031d6

Hi @rndmh3ro, hope you are doing great!
Happy new year!
The issue you describe is related to the Password and Secrets Regex Queries detecting FPs in custom user resources.  We, the KICS team, are aware of FP Passwords and Secrets results for custom resources and will inquire to determine the best approach to the problem and solve it.
For now, I can only recommend one of the ways to ignore the result:

Add the KICS ignore to the file
Exclude the result by adding the similarity ID of the result to the scan with the flag --exclude-results
Modify the Passwords and Secrets regex to fit your needs

Sorry for not being able to solve your problem right away.
Let us know if you need anything else!

Thanks, I'll ignore it for now!


Peer-to-peer morning session review

@zuhebahmed88091
@erickma1

In the case of css units you can use relative units for more responsiveness. Because px units are absolute and it can be messy if you want to make your web page responsive.
The buttons on the work section are breaking.
The spacing between two containers is not as template in figma.

In the About Me section one of your anchor element is not writen correctly, line 193.
The language selection feature in the "About Me" section could be improved. It's not very clear how it's supposed to work, and the Chevron icon looks like a down arrow, which is confusing. Perhaps consider using a different icon or adding some explanatory text.
What do you think adding a media query for the mobile less than 375px it will be better that everybody can visit your website.


Question regarding Upgrades

Just a question; what happens when sonarr/radarr upgrades a file due to having a better quality, score, etc... Does this then reset the duration of content being added?

If you talk about unplayed media, I didn't make an experiment on this
specifically, but you can do it yourself: watch for a field "Date added" in
the metadata editor.
Played/in-process doesn't care about file updates.
вс, 28 апр. 2024 г. в 03:54, Jam @.***>:

Just a question; what happens when sonarr/radarr upgrades a file due to
having a better quality, score, etc... Does this then reset the duration of
content being added?
—
Reply to this email directly, view it on GitHub
https://github.com/shemanaev/jellyfin-plugin-media-cleaner/issues/47,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICN2OTY6V47LGIZAND4FTY7RCCZAVCNFSM6AAAAABG4QOGICVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DOMRXG43TKMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yeah - the Date added resets in this case.
Is there anything we can do to combat this or a Jellyfin setting at all we can turn on to stop things being re-added on an upgrade?

Does "Date added behavior for new content" option set correctly?

Mine is set to the same option as you have.

I don't see a workaround for this behavior then...

Yeah - the Date added resets in this case.
Is there anything we can do to combat this or a Jellyfin setting at all we can turn on to stop things being re-added on an upgrade?

If you're using notifarr, you can enable the setting under Jellyfin settings to unmonitor shows after being watched but that's about it.
Also, you can use trakt to set any show as watched and then let it run the task to import watched status

Yeah - the Date added resets in this case.
Is there anything we can do to combat this or a Jellyfin setting at all we can turn on to stop things being re-added on an upgrade?

If you're using notifarr, you can enable the setting under Jellyfin settings to unmonitor shows after being watched but that's about it.
Also, you can use trakt to set any show as watched and then let it run the task to import watched status

I think you're talking about something else. We are talking about when content is upgraded (i.e there's a better file found by sonarr/radarr) then when Jellyfin scans the new file into the library, it is counted as a new film. So, that would reset this plugins data as it wouldn't be checking anymore from when the film was first added but now when it was upgraded.

Hello everyone. The reason for this issue is that when a file is modified and imported again in Jellyfin, it is seen as a new addition, regardless of previous metadata (in a way that data refers to the file, not the abstract "movie" item).
To fix this, I have written a (disgusting) python script that pulls the metadata from the API and saves the addition date in an external database. If the file is later re-added to Jellyfin, its addition date is overwritten with the older one. I've been using it for a few weeks and seems to work as it should. It's currently just a file that I start with the server (through systemd) and keeps running on its own. I'll look into packaging it in a better way, maybe with a simple container, but for the moment it's a sufficient workaround for my issue.
Here is a gist if you want to try it yourselves: https://gist.github.com/NicolaSmaniotto/aff7d01ea7055c111c85ce1828fc7ed4

Where would we run this script from? I run Jellyfin in a docker container. Inside the container or on the server that's running docker?

Ok, I created this python script on my Ubuntu vm with docker on it that has Jellyfin. I have python3 installed and ran the script and get the following messages. Something about a KeyError: 'ProductionYear' Screenshot attached. What am I doing wrong?

Apparently you have some movie without a release year, but the script tries to read it. I haven't encountered missing metadata like that and since there is no check in place, the script just crashes. You can probably solve this by putting year = item.get("ProductionYear", -1) at line 43 (if a movie is missing the year, it just uses -1).
Side note, it's probably better to write these things under the gist or writing me an email, don't want to spam these issues with unrelated stuff.


compile-fail tests don't seem to work with stable?

I have the following compile-fail test:
fn main() {
    x //~ ERROR cannot find value `x` in this scope
}

If I use compiletest_rs = "0.3" with cargo +nighly test, the test passes. However, when I use compiletest_rs = { version = "0.3", features = ["stable"] } and plain cargo test (on stable channel), the test fails with a the following log:

     Running /Users/upsuper/.cargo-target/debug/deps/compile_tests-0af93046d8980edd

running 1 test

running 1 test

error: failure produced the wrong error: exit code: 101
status: exit code: 101
command: "rustc" "tests/compile-fail/basic.rs" "-L" "/tmp" "--target=x86_64-apple-darwin" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/basic.stage-id" "-L" "/Users/upsuper/.cargo-target/debug" "-L" "/Users/upsuper/.cargo-target/debug/deps" "-L" "/Users/upsuper/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "-L" "/Users/upsuper/.rustup/toolchains/stable-x86_64-apple-darwin/lib" "-L" "/Developer/NVIDIA/CUDA-8.0/lib" "-L" "/usr/local/cuda/lib" "-L" "/tmp/basic.stage-id.aux" "-A" "unused"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
{"message":"cannot find value `x` in this scope","code":{"code":"E0425","explanation":"\nAn unresolved name was used.\n\nErroneous code examples:\n\n```compile_fail,E0425\nsomething_that_doesnt_exist::foo;\n// error: unresolved name `something_that_doesnt_exist::foo`\n\n// or:\n\ntrait Foo {\n    fn bar() {\n        Self; // error: unresolved name `Self`\n    }\n}\n\n// or:\n\nlet x = unknown_variable;  // error: unresolved name `unknown_variable`\n```\n\nPlease verify that the name wasn't misspelled and ensure that the\nidentifier being referred to is valid for the given situation. Example:\n\n```\nenum something_that_does_exist {\n    Foo,\n}\n```\n\nOr:\n\n```\nmod something_that_does_exist {\n    pub static foo : i32 = 0i32;\n}\n\nsomething_that_does_exist::foo; // ok!\n```\n\nOr:\n\n```\nlet unknown_variable = 12u32;\nlet x = unknown_variable; // ok!\n```\n\nIf the item is not defined in the current module, it must be imported using a\n`use` statement, like so:\n\n```\n# mod foo { pub fn bar() {} }\n# fn main() {\nuse foo::bar;\nbar();\n# }\n```\n\nIf the item you are importing is not defined in some super-module of the\ncurrent module, then it must also be declared as public (e.g., `pub fn`).\n"},"level":"error","spans":[{"file_name":"tests/compile-fail/basic.rs","byte_start":16,"byte_end":17,"line_start":2,"line_end":2,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    x //~ ERROR cannot find value `x` in this scope","highlight_start":5,"highlight_end":6}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0425]: cannot find value `x` in this scope\n --> tests/compile-fail/basic.rs:2:5\n  |\n2 |     x //~ ERROR cannot find value `x` in this scope\n  |     ^ not found in this scope\n\n"}
{"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
{"message":"For more information about this error, try `rustc --explain E0425`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0425`.\n"}

------------------------------------------

thread '[compile-fail] compile-fail/basic.rs' panicked at 'explicit panic', /Users/upsuper/.cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.14/src/runtest.rs:2550:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
test [compile-fail] compile-fail/basic.rs ... FAILED

failures:

failures:
    [compile-fail] compile-fail/basic.rs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

test compile_tests ... FAILED

failures:

---- compile_tests stdout ----
thread 'compile_tests' panicked at 'Some tests failed', /Users/upsuper/.cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.14/src/lib.rs:90:22

failures:
    compile_tests

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test compile_tests'

We had that discussion recently in #120, specifically here. I think the problem is the same that stable has an exit code of 101 where nightly is 1.
I think we need to fix #121 and consider how maintainable the stable feature really is. For now, don't expect it to work.

Has this fixed itself? Is the error code 1 on stable now?

Yeah, it seems to work now. Thanks.


fix: #4302 add wallet name

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #4302, Closes #4126

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </bsx/collection>
[x] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

https://user-images.githubusercontent.com/73316633/206902254-9b400645-7642-436a-b3e0-7b34f1216594.mp4

one thing left when it comes to functionality: changing wallet doesn't update the name in the dropdown, it updates only after refreshing the page. I've spent some time on how to do this and I have only stupid ideas, I'd appreciate some hints here 🥺

@exezbcz btw, I have included your comments regarding the dividers etc., one question tho, shouldn't the blue color change on hover? I couldn't figure it out from the design.

What about balance part?

What about balance part?

Must've missed that, I somehow didn't get this requirement from issue name / desc 😆 working on it.

Anyway I've logged in, and this is not the name of my account :D

Anyway I've logged in, and this is not the name of my account :D

oh okay, that's actually unrelated to this PR, also on beta, and caused by recent one here:

https://github.com/kodadot/nft-gallery/pull/4467

@daiagi would you please create supplemental PR to your fix, so it doesn't break identity?
I've reverted it and it works, it seems that identity is getting passed as empty object from IdentityIndex.vue

needs some more styling + storing basilisk/usd price (hopefully tomorrow evening).

@yangwao when it comes to USD price previews, basilisk is listed on coingecko, but not sure about tnkr, do we want to show that here? maybe hide tnkr for now ?

ah yes if price is not available we will be showing iirc "--" in current design.
yes lot of tokens on lbp at some extent won't have USD price

Anyway I've logged in, and this is not the name of my account :D

oh okay, that's actually unrelated to this PR, also on beta, and caused by recent one here:
* [bug wrench make identityIndex respond to address change #4467](https://github.com/kodadot/nft-gallery/pull/4467)

@daiagi would you please create supplemental PR to your fix, so it doesn't break identity?
I've reverted it and it works, it seems that identity is getting passed as empty object from IdentityIndex.vue

Anyway I've logged in, and this is not the name of my account :D

oh okay, that's actually unrelated to this PR, also on beta, and caused by recent one here:
* [bug wrench make identityIndex respond to address change #4467](https://github.com/kodadot/nft-gallery/pull/4467)

@daiagi would you please create supplemental PR to your fix, so it doesn't break identity?

I cloned your branch and i'm not seeing what you are seeing
what i am seeing is that without my changes both the name and the address don't change until refresh
with my changes the adress changes when switching wallets
in both cases the name is wrong, it shows "My  wallet, and not the name i have given the wallets
and in both cases the name changes only with a refresh

I've reverted it and it works, it seems that identity is getting passed as empty object from IdentityIndex.vue

FYI,i have chosen an initial value of empty object beacue that is the initial value in useIdentity
export default function useIdentity({ address, customNameOption }) {
  const { apiUrl } = useApi()
  const identity = ref<IdentityFields>({})

@daiagi okay, I think we both got a bit confused here :D

I need to start showing wallet name instead of extension name, somehow got that wrong. I will have time in the evening, I thought we want extension name. thank you for clarifying that for me 🚀
My comment was regarding the on-chain identity, as I thought that's what was being discussed as wallet name. As an example, here's my wallet on Subscan. https://github.com/kodadot/nft-gallery/pull/4467 broke that functionality, on-chain identity isn't shown anymore on beta, works for me again, after I reverted it.

Here's what I'm seeing on beta:

Here it is still working on kodadot.xyz (or on my branch after reverting your PR):

There should be petersopko instead of wallet address, you can see it working in my previous screenshots.
When it comes to reactivity in your PR, you're right, that part works, just the identity part needs to be fixed.
So three different terms here, extension name (we don't want that), custom wallet name (we do want that, will get done in this PR), on-chain identity(needs fix after #4467).
You can set the on-chain identity here https://kodadot.xyz/identity

I guess it's not worth showing assets the wallet doesn't have.
OR show them in greyscale?
wyt @exezbcz

I guess it's not worth showing assets the wallet doesn't have. OR show them in greyscale? wyt @exezbcz

other than that, this is the very last PR I would like to squeeze into the upcoming release, so I would like to keep a steady 21 days cycle :)

i would not show it.

let's refactor utils and let's go?

let's refactor utils and let's go?

working on it, for some reason I can't fetch my KSM balance on RMRK. Doesn't work on kodadot.xyz, beta or local, idk.

currently testable at snek/bsx with various wallets.
todo:

[ ] get ksm balance and show it in similar fashion. as I described, I'm currently not able to fetch KSM balance, it seems to be broken at prod and beta as well
[ ] hide the whole asset section in case there are only 0 balance assets
[ ] cleanup + style touchup

@petersopko
I've been exploring the issue you mentioned where my PR broke onchain identity and:

you were right, it does.
I have yet to understand why it breaks it or how to fix it

same here

I have solved issue with reactive wallet name by storing the wallet name in store, which is reactive when accessed through getters in components, i.e.
  get userWalletName(): string {
    return this.$store.getters['wallet/getWalletName']
  }

why is there prefix My ?

todo:

yes, we can do follow-up, 14 changed files are bit frightening to me 😅 this never went well with complex changes

Otherwise is mergable I guess?

just ${walletName}?

yes

Seems https://github.com/kodadot/nft-gallery/pull/4476/files#diff-a4a33e7ecfb7969dbf41700112aa3cf6f2880fe4a397f3faececd4a001e67384 is copy of https://github.com/kodadot/nft-gallery/blob/main/components/bsx/Asset/AssetList.vue ?
I mean, I'm a bit against copying functions over file and duplicating code.
I'm merging it because this was the very last issue to have it released; otherwise, I dislike the code approach ignoring DRY approach.
pay 60 USD

😍 Perfect, I’ve sent the payout
💵 $60 @ 29.12 USD/KSM ~ 2.06 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x190ecd6efea6a858e7132ad5d3c3418a91daa43f1824e71ca3ef9d1d61d66f9b
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

dislike the code approach ignoring DRY approach
pay 60 USD

I'm not too fond of the state in which it got merged in either, and I wish I had time to clean up/finish. Maybe next time :)


Create Work - no work created

when creating party2 for ajax mine assessment, the work did not get created!

(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

This happened only once and I think we have gone to production and many different types of works created and no one faced this issue ever. I think we can close this ticket until we see it is happening recurrently


Fix Rootable! not compiling if not directly imported

The missing $crate prefix was preventing gc_arena::Rootable![Foo<'gc>] from compiling.

Relatedly, and following our discussion on Discord a few weeks ago, should I change the name of the "default lifetime" of the short form to '__, or '_? (the latter would be most natural, but would require a proc-macro) This would make the short form usable in most scenarios, when a 'gc lifetime is already in scope.

Yeah forgetting the $crate  prefix is entirely my fault, good catch.
I definitely think the 'gc default for the short version of the macro is wrong because I find myself using the long form of the macro almost exclusively. The only thing that's giving me pause about using '_ via proc-macro is that that lifetime already has another meaning, but I can't for the life of me fathom a case where the actual placeholder lifetime would be useful there, AND the concept of the placeholder lifetime makes sense in this context already. So, I guess by that logic, the placeholder lifetime makes the MOST sense? If it's pretty easy to write that proc-macro I guess that'd be the ideal way?


Possible Docker solution

If you know how to migrate this project completely to a Docker app, please comment below ;) Thank you!

@potter420

Managed to get wg show to work, but not sure if it affect the docker interface or host interface.

Using host network allows the docker's wireguard to directly manipulate the host's network rules and interface. So this issue won't come. Simply run the docker container with these flags
--privileged --cap-add=NET_RAW --net=host

@donaldzou
You may use this as inspiration/template.
https://hub.docker.com/r/linuxserver/wireguard
If time permits today I'll provide a working docker command.

Hi @shrinidhi111 ! Thank you for doing this, I will look into too ;)

And there is https://github.com/WeeJeWel/wg-easy/ . I think your dashboard is visually more pleasing :-) The only issue i have with these kind of containers is that you always have to expose them, so i personally settled with a bridged container, volume and a inotify-reload on the host

i would reserve cuation on moving to a Docker based dashboard as still to find one that works well and easy to install even the one above wg-easy following the install guide does not work unlike what you have here

i've added a dockerized form of your excellent app in this fork - tested successfully works using an Ubuntu 20.04 LTS host on Linode.
Short Description
this fork contains 5 extra files on top of the current repo that roll up your app + wireguard into a docker image, allow for custom config at compose time, and deploy using docker-compose.   you can pull the forked repo, cd into the dir, and follow these two steps to test
bash install_docker_ubuntu.sh
docker-compose up -d --build
Long Description
these extra 5 files are

install_docker_ubuntu.sh - docker/docker-compose installs for ubuntu 20.04

#!/bin/bash

# install docker
sudo apt install -y apt-transport-https ca-certificates curl gnupg software-properties-common
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable"
sudo apt update
sudo apt install -y docker-ce docker-ce-cli containerd.io

# install docker-compose
sudo curl -L "https://github.com/docker/compose/releases/download/1.27.4/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose

Dockerfile - a basic Dockerfile rolling up your app + wireguard into an ubuntu image

FROM ubuntu:20.04

# update pack list
RUN apt update

# install utils + wireguard
RUN apt install -y apt-utils python3.8 python3-pip gcc libffi-dev python-dev default-libmysqlclient-dev python3-dev net-tools gettext-base iproute2 iptables wireguard

# configure wireguard
RUN wg genkey | sudo tee /etc/wireguard/privatekey | wg pubkey | sudo tee /etc/wireguard/publickey

# python installs
RUN pip3 install Flask tinydb ifcfg icmplib flask-qrcode

# make home directory
RUN mkdir /home/app

# copy over env and template
COPY env.sh /home/app/env.sh
COPY wg0_template.conf /etc/wireguard/wg0_template.conf

wg0_template.conf - config file template - currently allows SERVER_PRIVATE_KEY configuration based on wireguard instantiation

[Interface]
Address = <IP_ADDRESS>/24
SaveConfig = true
ListenPort = 51820
PrivateKey = $SERVER_PRIVATE_KEY
PostUp = iptables -A FORWARD -i %i -j ACCEPT; iptables -t nat -A POSTROUTING -o ens3 -j MASQUERADE
PostDown = iptables -D FORWARD -i %i -j ACCEPT; iptables -t nat -D POSTROUTING -o ens3 -j MASQUERADE

env.sh - stamps env variables into wg0_template.conf at compose time.  currently only SERVER_PRIVATE_KEY

#!/bin/bash

# set temp envs
export SERVER_PRIVATE_KEY=$(cat /etc/wireguard/privatekey)

# copy template
cp /home/app/wg0_template.conf /etc/wireguard/wg0_template.conf

# sub in vars in template .conf
envsubst < /etc/wireguard/wg0_template.conf > /etc/wireguard/wg0.conf

# clean up template
rm /etc/wireguard/wg0_template.conf

# chmod
chmod 600 /etc/wireguard/{privatekey,wg0.conf}

docker-compose.yml - a simple compose file that wraps up the docker-fied version of the app

version: '3.8'

services:
  wireguard_dashboard:
   build:
     context: .
   image: wireguard_dashboard
   container_name: wireguard_dashboard
   ports:
    - 51820:51820 # wireguard port
    - 10086:10086 # wireguard dashboard port
   volumes:
    - ./img:/home/app/img
    - ./src:/home/app/src
   working_dir: /home/app/src
   command: >
      sh -c "/home/app/env.sh &&
             sleep 5 &&
             /home/app/src/wgd.sh debug &&
             sleep infinity"
   networks:
    - wireguard_network
   restart: "always"
   cap_add:
     - NET_ADMIN

networks:
 wireguard_network:

Here you can replace /home/app/src/wgd.sh debug with /home/app/src/wgd.sh start etc.,
Final thoughts - separating your app from wireguard
This docker configuration works - eventually it would be nice to separate the app from wireguard and host each from a separate container.

i would reserve caution on moving to a Docker based dashboard as still to find one that works well and easy to install even the one above wg-easy following the install guide does not work unlike what you have here

wg-easy works out of the box for me, your kernel needs to have wireguard support. I'm using Ubuntu 20.04 LTS with kernel 5.4

Hey, I still haven't figure out how to separate dashboard and wireguard container but I manage to setup everything under 5 mins (or even less) with pre-existing wireguard image out there that works out of the box, here's how I do it:

makedir config directory to mount as volume and create empty wg-dashboard.ini, otherwise it will be created as directory instead of file, which can be frustrating. (tldr; do mkdir data then touch ./data/wg-dashboard.ini)
Setup Dockerfile and docker-compose.yml, also entrypoint script for the Dockerfile which you can find it in my fork: https://github.com/SirusDoma/WGDashboard/commit/c00932b8478e398e3ff708b18c0679735428ed24
Make sure docker compose installed and run docker-compose up -d
...
Profit!

Hope this useful for someone looking for simple setup.

Have you looked to see if there are any changes necessary to make to your docker setup here with the changes that have been applied regarding venv and sqlite?

I'm not so sure cuz i'm not an expert of Docker.. (too complicated for me lol)

Maybe #134 this can help? @ikidd

For those working on docker I'd suggest wg-gen-web is a better example than wg-easy since it uses a host installed Wireguard instead of putting it in the same container in the way wg-easy does.

@adrinux wg-easy works just fine for me. I actually prefer having wg in the container, since its easier to get updates. Host OS are slower at updating packages

Here https://gitlab.com/pgalonza/wireguard-image/-/tree/develop i using WGDashboard with podman, ansible and and scripts from https://github.com/linuxserver/docker-wireguard

unfortunately, you have to use different way, rather than "subprocess.check_output"...
Here is mine Dockerfile:
FROM --platform=$BUILDPLATFORM python:latest AS builder

WORKDIR /app

COPY requirements.txt /app
RUN --mount=type=cache,target=/root/.cache/pip \
    pip3 install -r requirements.txt

COPY . /app

ENTRYPOINT ["python3"]
CMD ["dashboard.py"]

And compose.yaml for "docker compose up -d":
services:
  web:
    build:
      context: src
      target: builder
    # flask requires SIGINT to stop gracefully
    # (default stop signal from Compose is SIGTERM)
    stop_signal: SIGINT
    ports:
      - '10086:10086'

New updates are in: https://github.com/donaldzou/WGDashboard/issues/272
Please close this issue and respond there to limit the wild growth of the same issue.

Closing this issue. Please refer to #272.


EMA and SMA gives the same result every time

The EMA is the Exponential Moving Average and the SMA is the Simple Moving Average. The EMA favors the most recent price data as opposed to taking an average of an entire period. That being said, it's highly unlikely that these two numbers should be the same. Can you share a printout?


Revert "[test] Disable debug_value_addr.swift on arm64"

This reverts commit 0a7a976d31edb7bd052b8dfaa25d8ed5bb59381e.
The problem here is related to no-asserts rather than architecture.

@swift-ci please smoke test


Documentation: add disk latency leader loss question to FAQ

/cc @xiang90

lgtm

lgtm

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6b78490). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7622   +/-   ##
=========================================
  Coverage          ?   73.46%
=========================================
  Files             ?      327
  Lines             ?    26592
  Branches          ?        0
=========================================
  Hits              ?    19537
  Misses            ?     5595
  Partials          ?     1460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b78490...faad828. Read the comment docs.


EXSWHTEC-178 - Implement tests for Graph Event Node APIs

Clean up hipGraphAddEventRecordNode, hipGraphEventRecordNodeGetEvent, hipGraphEventRecordNodeSetEvent
Clean up hipGraphAddEventWaitNode, hipGraphEventWaitNodeGetEvent, hipGraphEventWaitNodeSetEvent
Clean up hipGraphExecEventRecordNodeSetEvent, hipGraphExecEventWaitNodeSetEvent
Implement missing positive and negative tests

@rorake Conflicts are resolved.

PR has been merged into develop branch via commit 575e4cc93e0a9276b9df50c418c7e98a400531e3


.env is not loaded when .env.testing is

Laravel Version: 5.4.17
PHP Version: 7

Description:
According to the documentation

You may also create a .env.testing file. This file will override values from the .env file when running PHPUnit tests or executing Artisan commands with the --env=testing option.

However, as it seems for me, it's not how it works. It's loaded INSTEAD OF .env, but it should just override the values.
Steps To Reproduce:
Copy your valid .env file as .env.testing. The unit testing should work as expected. Now remove the APP_KEY from .env.testing. Unit testing breaks now.

@KristofMorva

Create a valid .env file with APP_KEY, and an empty .env.example. The unit testing should break. Now copy the APP_KEY to .env.example. Now everything should be fine.

You meant .env.testing, rigth?

@m1guelpf yes, sorry for that, fixed! :)

When you are creating a new .env file, all the configuration you need to generate should  be specific to that file. Since .env.testing is for testing only, you should always a APP_KEY for .env.testing like:
php artisan key:generate --env=testing

@srmklive my problem is not the APP_KEY, that's just for reproducing. My problem is, it's not working as stated in the documentation. In my scenario for example I have ~10 private keys, which are used for various services - certainly both locale and testing environment use the sandbox keys, so currently I have to manage the keys in two configs, always copying one to another - it wouldn't be necessary, if handling .env.testing was working as stated.

It is not necessarily an error in my opinion with the framework. My opinion is that env files are for development purposes only.
@themsaid @GrahamCampbell  Your thoughts?

.env files are present on production environments too, it's not only for development. And you may still miss the point: if that's the way it works, the documentation shouldn't say it otherwise.

Yes only 1 file is loaded, and by override values we mean it'll load the values from that file not the .env file.

FWIW, it would be really nice if these additional environment variables did override values from the main .env file. Quite often locally I have all my environment variables defined, and then only tweak on or two values for the unit tests or Dusk tests.
It would mean loading more than one .env file though.

You could even add some crazy extends features. :feelsgood:
@extends(.env)

DB_DATABASE=testing

@reinink or just an ENV_PARENT or something like that, which does not involve altering the .env loading package. But even without it, just loading .env file as a parent default would make env files less boilerplate.

Man the documentation is really confusing on this point.

This file will override values from the .env file when running PHPUnit tests

In fact it doesn't override values from the .env file. It doesn't depend on the .env file at all. Am I missing something?

Doesn't it use .env unless .env.testing is present? In that case it sort of does "override" them, in that it uses a totally different file instead, if present. That said, I totally agree, this threw me off as well.

Might be best for someone to simply craft a PR to make this documentation a little more clear?

Yeah I think "This file will override the .env file when running PHPUnit tests..." would be much clearer.

Sounds like a great PR. :)

So how are we supposed to override values that are in .env.testing when running tests?
I know that in phpunit.xml you can have testing defaults and override those with an unversioned .env.testing file. But that only works for PHPUnit.
I would rather have .env.testing versioned so that I could run a fresh migration of the test db just by running APP_ENV=testing php artisan migrate:fresh.
But then that brings about the problem that I could only have a single set of test db credentials there, and my colleagues wouldn't have any simple way to override them if their local db is using a different username, password or db name.


tests: rename libstorage.NewRandomDataVolume*

The renamed functions create a new DataVolume object. The fact that the
name of the DataVolume is chosen randomly is not important to the user
of the functions. We could have implemented them with a monotonously
rising index and no functionality would have been hurt.
Besides, the new names are shorter and easier to read.
/sig code-quality
NONE

/test pull-kubevirt-build

In general I have no issue with this PR or the namechange, but Random of course contains valuable information for test writers. It clearly says that they don't have to care about conflicting objects in a namespace. How they are "randomized" so that there are no conflicts is for sure not interesting but that is also not part of the name.

In general I have no issue with this PR or the namechange, but Random of course contains valuable information for test writers. It clearly says that they don't have to care about conflicting objects in a namespace. How they are "randomized" so that there are no conflicts is for sure not interesting but that is also not part of the name. NewDataVolume does not indicate at all if names will be set, if one has to override them, and so forth.

Thanks for being open to this namechange.
I'll try to elaborate on my motivation. The existing names, eg NewRandomBlockDataVolumeWithRegistryImport, suggest that the DataVolume is "random". This is misleading - the content of the data is not random, it is taken from an image registry. Everything about the DV is systematic and known is advance (except its name). It is very important that the name of the DV exists, that it includes only valid characters and that it is unique in the test namespace. These facts are important, but not important enough to be mentioned on each of the function names. It's not like we have any other function in libstorage for creating a DV without a name, or with a name the collides with a preexisting one.

I'll try to elaborate on my motivation. The existing names, eg NewRandomBlockDataVolumeWithRegistryImport, suggest that the DataVolume is "random". This is misleading - the content of the data is not random, it is taken from an image registry. Everything about the DV is systematic and known is advance (except its name). It is very important that the name of the DV exists, that it includes only valid characters and that it is unique in the test namespace. These facts are important, but not important enough to be mentioned on each of the function names. It's not like we have any other function in libstorage for creating a DV without a name, or with a name the collides with a preexisting one.

sounds good. :+1:

/test pull-kubevirt-e2e-k8s-1.24-sig-storage

Maybe we should align with libvmi and create something like libdatavolume with builder pattern.

Yes, I believe this is a good idea for a follow-up PR.

/approve
I think it is reasonable to assume we get random(in a sense we don't conflict on the name and others...) datavolume by default in our test suite.


Reduce cpu usage for proxy creation

Related issue #686

Updated license agreement, made changes as requested

Rebased onto latest master-branch. PR would be ready for review, @lukasj


Update rust-sdk.mdx

The wrong path will cause "Page Not Found" to appear when searching for "rust sdk" on the site.
Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

I believe the core issue is resolved. Closing this PR. Please reopen if you disagree.


misleading description feature...

hi, in this repo is written:
Sfvip all : "Insert an All category so you can easily search your entire catalog."...
but it is not true...cause also if i start sfvip player, i mean not yr launcher sfvip all 1.4.12
but the salezi sfvip player  i also have the -all- caregory to be search
....so this is not a unique feature of yr repo sfvip all item...isn't it...??

Please read carefully: All category into Live, Series and Vod.
Sfvip Player has an All category for the channels since only after <IP_ADDRESS>
A it's is still missing an all category for vod & series.
Cheers

Please read carefully: [...] inserts an All category into Live, Series and Vod. Sfvip Player has an All category for the channels since only after <IP_ADDRESS> And it's still missing an all category for vod & series as of today. It comes in handy when you have thousands of those... Cheers

You have to write -watch carefully-...cause what is written is very clearly..:
"Insert an All category so you can easily search your entire catalog."
i have only copy paste what you have written....
only if we see careffully the IMAGE we see the circler across vod and series....
but this is not really very easely to understand.....
i suggest you to correct mainly what you have written...:
from:
""Insert an All category so you can easily search your entire catalog."
to:
"Insert an All category in thre VOD AND SERIES  so you can easily search your entire catalog."
am i wrong...??!!... ;)

am i wrong...??!!... ;)

Yes: Sfvip Player has no All category for the channels in <IP_ADDRESS>.
And some people stick with this version.

It's been changed to "Insert an All category when missing ..." in https://github.com/sebdelsol/sfvip-all/commit/d1ea57f76e8b5de548f2fdedb4943676a32b3321

hi, hats off to you and yr very kind helping and gentle patience, i really thxs you from the very deep of my heart
i have only a simple question: have you a place where you suggest to find the iptv lists...??...in order to be able to have yr precious sfvip all tool, and of course salezi's sfvip itself, well working..?...is there a site or a place where find them...??
thxs so much in adv
cheers


The parquet files are deleted when the duckdb file is created

See https://huggingface.co/datasets/jslin09/wikisource_tw/commit/81a728d6be9f0334dd63fcb26750ff3b958057c3

Possibly related to https://github.com/huggingface/datasets-server/pull/2308.

Once fixed, we will have to look at the affected datasets, and recreate them

Fixed by https://github.com/huggingface/datasets-server/pull/2346

I don't find an easy way to identify the datasets that have been affected because it was at hub level (commits to delete files) but I will force-refresh config-parquet-and-info step for the following list:
force-refresh-result.csv (318 configs)
I used this query to get them {kind:"split-duckdb-index", http_status:200, "content.partial": true, updated_at:{$gte : new ISODate("2024-01-18T00:00:00Z")}} having in consideration that https://github.com/huggingface/datasets-server/pull/2308 has been deployed nearly 2024-01-19.


[Communication] Update sdk_packaging.toml

start auto-update
https://github.com/Azure/sdk-release-request/issues/2889

/check-enforcer override


complete sterivex dna extraction protocol using content from google doc

https://docs.google.com/document/d/1EGnPv0DjcSNZhKVBFfLPlqNNK1DCxlF4/edit
child of #1

https://github.com/aomlomics/protocols/blob/main/protocol_DNA_extraction_Sterivex.md

https://github.com/aomlomics/protocols/commit/e5fd2c7fbb04bc893b2e78fa4783ddefd4740919

@sammyharding I believe this is done so I'm closing this issue.


DI

Injector.getInjector().get<SomeService>().doSomething();

Sorry to be the bearer of bad news but that's inversion of inversion of control. Singletons and ServiceLocators were what we were trying to counter in the first place - IoC and DI were the antidote to SomeClass.getInstance().get("some_key").invokeMethodOnThat(args);
Unless getInjector() gives you a new instance every time you call it, I think we're looking at service-locator :-(

@paul-hammant the get method will give you a new instance every time unless you specify the service as a singleton in the mapping.   This library provides the tools for you to handle your services and their dependencies.  What I suggest is that you do not use this library explicitly in your code outside of module containers as you have above; but rather build containers that configure the injector with services and objects that take their dependencies in as constructor parameters.  That way you will NEVER need to use the injector explicitly outside of a container and therein have proper DI.  See the naive example below.
import 'package:flutter_simple_dependency_injection/injector.dart';

abstract class Container {
  configure(Injector rootInjector);
}

class SubModuleContainer extends Container {
  @override
  configure(Injector rootInjector) {
    _configureServices(rootInjector);
    _configureBLocs(rootInjector);
    _configurePages(rootInjector);
  }

  _configureServices(Injector rootInjector) {
    rootInjector.map<FileService>((i) => new FileService(), isSingleton: true);
    rootInjector.map<Logger>((i) => new FileLogger(i.get<FileService>()));
  }

  _configureBLocs(Injector rootInjector) {
    rootInjector.map<AuthenticationBLoc>((i) => new AuthenticationBLoc(i.get<FileService>()));
  }

  _configurePages(Injector rootInjector) {
    rootInjector.map<LoginPage>((i) => new LoginPage(i.get<AuthenticationBLoc>()));
  }
}

@paul-hammant this is a good point.  While I think people should use this similar to the example I give above it can be used as a naive service locator.  I will add and example of the above to help guide people.


Osiset\ShopifyApp\Exceptions\MissingShopDomainException

After Creating a new laravel project and  installing osiset/laravel-shopify tjhe welcome page is not show.
The error is MissingShopDomainException.
    "php": "^7.3|^8.0",
    "fideloper/proxy": "^4.4",
    "fruitcake/laravel-cors": "^2.0",
    "guzzlehttp/guzzle": "^7.0.1",
    "laravel/framework": "^8.12",
    "laravel/tinker": "^2.5",
    "osiset/laravel-shopify": "^16.0"

This is because you are not authenticated.

Login at https://partners.shopify.com/
Create a new application
Update your Laravel .env to include your app credentials
In the Shopify Partners portal click install your application into a demo store:

Once the app is installed you should see the welcome page.

@m4mehdi Please use issue template and fill in all details so we can reproduce.

@osiset I have same problem, the welcome page work correctly the first time I install the app because hmac and the others variable are setted in query string but when I try go to another page laravel throw the exception Osiset\ShopifyApp\Exceptions\MissingShopDomainException.
I have vue SPA but it throw the same error with this HOME

Closing, lack of issue template.


yotta docs should recommend inline namespaces

Yotta's namespacing recommendations could be improved. Instead of:
namespace mymodule {
    namespace current {
        using namespace ::mymodule::v1;
    }
}

Yottadocs should advocate inline namespaces in C++11 repositories instead:
namespace mymodule {
    namespace current {
        inline namespace ::mymodule::v1;
    }
}

This allows some improvements in how namespaces are handled:
e.g.:
namespace lib
{
    inline namespace v2
    {
        template< class T >
        struct traits
        { /*...*/ };
   }
}

Then, we can do this:
struct Mine
{};
namespace lib
{
template<>
struct traits< Mine >
{ /*...*/ };
}

With the using keyword, this template specialization is not possible.
cc @pan- @autopulated

:+1: This fixes a bunch of corner cases. You could also use namespace aliasing (namespace current = ::mymodule::v1;), which I think would have all the same advantages.
Both are C++11 features, so we should also note in the targets documentation that new targets should compile C++ code as C++11 (this is already the situation, but I don't think we state it explicitly).

+1,
@autopulated Yes, namespace aliasing can also solve the problem but it is more verbose lib::current::foo() is less intuitive than lib::foo()

+1 for these 2 new features, I noticed their use in boost , was planning to request this. For reference: https://svn.boost.org/trac/boost/wiki/BestPracticeHandbook