producer_name_filter and linux.ftrace

Hi,
I would like to filter some of the data collected linux.ftrace and linux.process_stats to only show the traces from a specific process name/regex. I found the producer_name_filter and producer_name_regex_filter, but I couldn't make them work.
It either filters all the processes, or don't filter anything, or crashes the traced.
I would like to know if it's possible to use producer_name_filter/producer_name_regex_filter to do it? If so, how?
Info about the crash
Perfetto versions tested : v24.0 and master-8346ef1cf74f4e911ffaadc03927f384ee52be14
Platform: Debian testing x86_64
cfg sample
 buffers {
   size_kb: 50000
   fill_policy: RING_BUFFER
 }
 data_sources {
   config {
     name: "linux.process_stats"
     process_stats_config {
       scan_all_processes_on_start: true
       proc_stats_poll_ms: 10
     }
   }
   producer_name_regex_filter: "*virgl*"
   producer_name_regex_filter: "*deqp-vk*"
 }

------------------ BEGINNING OF CRASH ------------------
Signal: Abort
Fault addr: 000003E800013B7A

Backtrace:

#00  0x00007F1B4C0FE200
#01  0x00007F1B4BDD58A1
#02  0x00007F1B4BDBF546
#03  0x00007F1B4C6A1459
#04  std::__1::__wrap_iter<char const*> std::__1::basic_regex<char, std::__1::regex_traits<char> >::__parse_ERE_branch<std::__1::__wrap_iter<char const*> >(std::__1::__wrap_iter<char const*>, std::__1::__wrap_iter<char const*>)
     ../buildtools/libcxx/include/regex:3157
#05  std::__1::__wrap_iter<char const*> std::__1::basic_regex<char, std::__1::regex_traits<char> >::__parse_extended_reg_exp<std::__1::__wrap_iter<char const*> >(std::__1::__wrap_iter<char const*>, std::__1::__wrap_iter<char const*>)
     ../buildtools/libcxx/include/regex:3132
#06  std::__1::__wrap_iter<char const*> std::__1::basic_regex<char, std::__1::regex_traits<char> >::__parse<std::__1::__wrap_iter<char const*> >(std::__1::__wrap_iter<char const*>, std::__1::__wrap_iter<char const*>)
     ../buildtools/libcxx/include/regex:3079
#07  basic_regex<std::__1::char_traits<char>, std::__1::allocator<char> >
     ../buildtools/libcxx/include/regex:2565
#08  operator()
     ../src/tracing/core/tracing_service_impl.cc:238
#09  std::__1::__wrap_iter<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const*> std::__1::find_if<std::__1::__wrap_iter<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const*>, per
     ../buildtools/libcxx/include/algorithm:933
#0A  perfetto::(anonymous namespace)::NameMatchesFilter(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::
     ../src/tracing/core/tracing_service_impl.cc:235
#0B  perfetto::TracingServiceImpl::SetupDataSource(perfetto::protos::gen::TraceConfig_DataSource const&, perfetto::protos::gen::TraceConfig_ProducerConfig const&, perfetto::TracingServiceImpl::RegisteredDataSource const&, perfetto::TracingServiceImpl::Tracing
     ../src/tracing/core/tracing_service_impl.cc:2621
#0C  perfetto::TracingServiceImpl::EnableTracing(perfetto::TracingServiceImpl::ConsumerEndpointImpl*, perfetto::protos::gen::TraceConfig const&, perfetto::base::ScopedResource<int, &(perfetto::base::CloseFile(int)), -1, true, perfetto::base::internal::Default
     ../src/tracing/core/tracing_service_impl.cc:912
#0D  perfetto::TracingServiceImpl::ConsumerEndpointImpl::EnableTracing(perfetto::protos::gen::TraceConfig const&, perfetto::base::ScopedResource<int, &(perfetto::base::CloseFile(int)), -1, true, perfetto::base::internal::DefaultValidityChecker<int, -1> >)
     ../src/tracing/core/tracing_service_impl.cc:3499
#0E  perfetto::ConsumerIPCService::EnableTracing(perfetto::protos::gen::EnableTracingRequest const&, perfetto::ipc::Deferred<perfetto::protos::gen::EnableTracingResponse>)
     ../src/tracing/ipc/service/consumer_ipc_service.cc:77
#0F  void _IPC_Invoker<perfetto::protos::gen::ConsumerPort, perfetto::protos::gen::EnableTracingRequest, perfetto::protos::gen::EnableTracingResponse, &(perfetto::protos::gen::ConsumerPort::EnableTracing(perfetto::protos::gen::EnableTracingRequest const&, per
     ../include/perfetto/ext/ipc/codegen_helpers.h:49
#10  perfetto::ipc::HostImpl::OnInvokeMethod(perfetto::ipc::HostImpl::ClientConnection*, perfetto::protos::gen::IPCFrame const&)
     ../src/ipc/host_impl.cc:243
#11  perfetto::ipc::HostImpl::OnReceivedFrame(perfetto::ipc::HostImpl::ClientConnection*, perfetto::protos::gen::IPCFrame const&)
     ../src/ipc/host_impl.cc:170
#12  perfetto::ipc::HostImpl::OnDataAvailable(perfetto::base::UnixSocket*)
     ../src/ipc/host_impl.cc:162
#13  perfetto::base::UnixSocket::OnEvent()
     ../src/base/unix_socket.cc:900
#14  operator()
     ../src/base/unix_socket.cc:740
#15  _ZNSt3__18__invokeIRZN8perfetto4base10UnixSocketC1EPNS3_13EventListenerEPNS2_10TaskRunnerENS2_14ScopedResourceIiXadL_ZNS2_9CloseFileEiEELin1ELb1ENS2_8internal22DefaultValidityCheckerIiLin1EEEEENS3_5StateENS2_10SockFamilyENS2_8SockTypeENS2_16SockPeerCredM
     ../buildtools/libcxx/include/type_traits:3529
#16  _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN8perfetto4base10UnixSocketC1EPNS5_13EventListenerEPNS4_10TaskRunnerENS4_14ScopedResourceIiXadL_ZNS4_9CloseFileEiEELin1ELb1ENS4_8internal22DefaultValidityCheckerIiLin1EEEEENS5_5StateENS4_10SockFamilyEN
     ../buildtools/libcxx/include/__functional_base:349
#17  _ZNSt3__110__function12__alloc_funcIZN8perfetto4base10UnixSocketC1EPNS4_13EventListenerEPNS3_10TaskRunnerENS3_14ScopedResourceIiXadL_ZNS3_9CloseFileEiEELin1ELb1ENS3_8internal22DefaultValidityCheckerIiLin1EEEEENS4_5StateENS3_10SockFamilyENS3_8SockTypeENS3
     ../buildtools/libcxx/include/functional:1540
#18  _ZNSt3__110__function6__funcIZN8perfetto4base10UnixSocketC1EPNS4_13EventListenerEPNS3_10TaskRunnerENS3_14ScopedResourceIiXadL_ZNS3_9CloseFileEiEELin1ELb1ENS3_8internal22DefaultValidityCheckerIiLin1EEEEENS4_5StateENS3_10SockFamilyENS3_8SockTypeENS3_16Sock
     ../buildtools/libcxx/include/functional:1714
#19  std::__1::__function::__value_func<void ()>::operator()() const
     ../buildtools/libcxx/include/functional:1867
#1A  std::__1::function<void ()>::operator()() const
     ../buildtools/libcxx/include/functional:2473
#1B  perfetto::base::RunTaskWithWatchdogGuard(std::__1::function<void ()> const&)
     ../include/perfetto/ext/base/watchdog.h:67
#1C  perfetto::base::UnixTaskRunner::RunFileDescriptorWatch(int)
     ../src/base/unix_task_runner.cc:235
#1D  decltype(*(std::__1::forward<perfetto::base::UnixTaskRunner*&>(fp0)).*fp(std::__1::forward<int&>(fp1))) std::__1::__invoke<void (perfetto::base::UnixTaskRunner::*&)(int), perfetto::base::UnixTaskRunner*&, int&, void>(void (perfetto::base::UnixTaskRunner:
     ../buildtools/libcxx/include/type_traits:3470
#1E  std::__1::__bind_return<void (perfetto::base::UnixTaskRunner::*)(int), std::__1::tuple<perfetto::base::UnixTaskRunner*, int>, std::__1::tuple<>, __is_valid_bind_return<void (perfetto::base::UnixTaskRunner::*)(int), std::__1::tuple<perfetto::base::UnixTas
     ../buildtools/libcxx/include/functional:2770
#1F  std::__1::__bind_return<void (perfetto::base::UnixTaskRunner::*)(int), std::__1::tuple<perfetto::base::UnixTaskRunner*, int>, std::__1::tuple<>, __is_valid_bind_return<void (perfetto::base::UnixTaskRunner::*)(int), std::__1::tuple<perfetto::base::UnixTas
     ../buildtools/libcxx/include/functional:2803
#20  decltype(std::__1::forward<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskRunner*, int const&>&>(fp)()) std::__1::__invoke<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskRu
     ../buildtools/libcxx/include/type_traits:3529
#21  void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskRunner*, int const&>&>(std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixT
     ../buildtools/libcxx/include/__functional_base:349
#22  std::__1::__function::__alloc_func<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskRunner*, int const&>, std::__1::allocator<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskR
     ../buildtools/libcxx/include/functional:1540
#23  std::__1::__function::__func<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskRunner*, int const&>, std::__1::allocator<std::__1::__bind<void (perfetto::base::UnixTaskRunner::*)(int), perfetto::base::UnixTaskRunner*
     ../buildtools/libcxx/include/functional:1714
#24  std::__1::__function::__value_func<void ()>::operator()() const
     ../buildtools/libcxx/include/functional:1867
#25  std::__1::function<void ()>::operator()() const
     ../buildtools/libcxx/include/functional:2473
#26  perfetto::base::RunTaskWithWatchdogGuard(std::__1::function<void ()> const&)
     ../include/perfetto/ext/base/watchdog.h:67
#27  perfetto::base::UnixTaskRunner::RunImmediateAndDelayedTask()
     ../src/base/unix_task_runner.cc:152
#28  perfetto::base::UnixTaskRunner::Run()
     ../src/base/unix_task_runner.cc:56
#29  perfetto::ServiceMain(int, char**)
     ../src/traced/service/service.cc:239
#2A  main
     ../src/traced/service/main.cc:21
#2B  0x00007F1B4BDC07FD
#2C  0x000055CB73AF7CFA
------------------ END OF CRASH ------------------
[1]    80762 IOT instruction  ./traced

This is not supported and really cannot ever be feasible.
As you can see by the comment on the proto, producer_name_filter and producer_name_regex_filter are filters for the name of the producer generating trace data when multiple producers are exposing the same data source.
In the case of linux.ftrace and linux.process_stats, the only producer which exposes this is traced_probes not your userspace processes you're trying to trace.
The main reason this is not feasible is that it would be far far too expensive to expose anything which does filtering based on process name on the trace collection side (not to mention in ftrace, we don't even have this information).
If you could provide more info on what exactly you are trying to accomplish, I'd be happy to guide further.

Hi, and thanks for the quick response.
From what you said, I think what I want is not possible.  But I will try to explain what I was trying to do.
I have two programs, and they have the "perfetto traces probes" added to them and are generating events to perfetto. But beyond these traces, I would like to have the syscalls and memory status provided by linux.ftrace and linux.process_stats from these two programs without the flood of information from other processes.
So when I open the trace in the perfetto.ui I only want to see the syscalls, memory, and the functions from these two programs(and the respective forks).
But now, I'm seeing is the status of all processes that were running on my S.O. at the time I was profiling my code.
Data source that I'm using from these two programs:
 data_sources {
   config {
     name: "track_event"
     track_event_config {
       enabled_categories: "virgl"
       enabled_categories: "virgls"
       enabled_categories: "gl"
       enabled_categories: "mesa.misc"
       enabled_categories: "mesa"
       enabled_categories: "mesa.vulkan.venus"
       disabled_categories: "*"
     }
   }
 }

If you just want to focus on the tracks you care about, you can just "star" the most important tracks relevant to your process which will pin them to the top of the screen.
This will allow you to see scheduling state + memory counter + userspace events/syscalls grouped together at the top

OK. Fair enough.
Thanks!

The main reason this is not feasible is that it would be far far too expensive to expose anything which does filtering based on process name on the trace collection side (not to mention in ftrace, we don't even have this information).

I'm not following, why would it be too expensive on the trace collection side? ftrace has native support for filtering by pid (set_ftrace_pid), so FtraceConfig could take a list of PIDs to restrict, right? In that case, are you open to an implementation of this?

1 and 2 are true, I didn't think about that... I think they alone kill a lot of use cases, so set_ftrace_pid is ruled out. :sweat_smile:
3 isn't a big deal; I think what most users would expect from this feature is vastly reduced trace size / improved performance. The probability for pid reusing is very low and if it happens, the extra spam can be filtered later.
When it comes to 4, isn't this already a problem (say a session wants a different set of events than another)?
It's true that pid/tid filtering would make the problem more obvious, but IIUC it was already there to begin with.

When it comes to 4, isn't this already a problem (say a session wants a different set of events than another)?
It's true that pid/tid filtering would make the problem more obvious, but IIUC it was already there to begin with.

Correct but we handle this inside traced_probes (see https://source.corp.google.com/android-internal/external/perfetto/src/traced/probes/ftrace/ftrace_config_muxer.h;l=68) explicitly  - you'd need to do something similar here.

Thank you! I'll keep it in mind


rethink NodePrinter

The whole relationship between NodePrinter and AbstractRefactoring is totally bogus, and only works because you guys don't have any multi-file refactorings yet. I suggest you come up with a much more robust way to associate AST nodes with token streams.

Fixed in 2063ae170045d49fd92b0d8407b9c313b79a0475


VSCode does not initialize git repository unless run as administrator.

Issue Type: Bug
I have git installed, according to the CLI, it's version '2.36.0.windows.1'.
I have the latest VSCode, version '1.69.1 (user setup)'.
I am on Windows 10 Home, version '21H2 (build 19044)'.
I have a folder (C:\Development...), which contains my project. It is initialized as a git repository and works correctly, both locally and with a remote.
Everything works as intended, if I run VSCode as an administrator. If not, the git repository is not initialized and changes are not tracked within VSCode.
This is not a huge deal, but i'd actually like to not have to run as administrator. As far as I can tell the folder (single folder workspace) is trusted, so that shouldn't be it either.
VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:12:52.460Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 3 1200 Quad-Core Processor            (4 x 3094)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.94GB (8.34GB free)

Process Argv
C:\Development\Projects\MapTool Notebook --crash-reporter-id 6b806724-34fd-41a4-8d98-c21529a9051c

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

json-tools
eri
1.0.2

code-runner
for
0.11.8

quicktask
lky
3.5.7

powershell
ms-
2022.6.3

java
red
1.8.0

LiveServer
rit
5.7.5

wikitext
Row
3.6.4

mts
Tho
0.3.0

vscodeintellicode
Vis
1.2.22

vscode-java-debug
vsc
0.42.0

vscode-java-dependency
vsc
0.20.0

vscode-java-pack
vsc
0.24.0

vscode-java-test
vsc
0.35.2

vscode-maven
vsc
0.36.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
pylanb8912cf:30529770
vsclangdc:30486549
841h4636:30531698

Could you please enable trace logging for the git extension as described in this wiki page. After you have enabled trace logging please open the folder once as an administrator, and once as a normal user, then share the two outputs so that I can further investigate this issue. Thanks!

Certainly.
Normal user:
[2022-07-27T14:54:04.744Z] Log level: Trace
[2022-07-27T14:54:04.859Z] [info] Validating found git in: C:\Program Files\Git\cmd\git.exe
[2022-07-27T14:54:05.156Z] [info] Using git 2.36.0.windows.1 from C:\Program Files\Git\cmd\git.exe
[2022-07-27T14:54:05.157Z] [trace] [swf] Scan workspace folders: [c:\Development\Projects\MapTool Notebook]
[2022-07-27T14:54:05.157Z] [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
[2022-07-27T14:54:05.157Z] [trace] [svte] Open repository for editor resource c:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html
[2022-07-27T14:54:05.157Z] [trace] [swsf] Scan workspace sub folders. autoRepositoryDetection=true
[2022-07-27T14:54:05.157Z] [trace] [swsf] Workspace folder: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:54:05.162Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:54:05.169Z] [trace] [swsf] Workspace scan settings: repositoryScanMaxDepth=1; repositoryScanIgnoredFolders=[node_modules]; scanRepositories=[]
[2022-07-27T14:54:05.169Z] [trace] [swsf] Workspace scan sub folders: [c:\Development\Projects\MapTool Notebook\.vscode, c:\Development\Projects\MapTool Notebook\build, c:\Development\Projects\MapTool Notebook\release, c:\Development\Projects\MapTool Notebook\source]
[2022-07-27T14:54:05.261Z] > git rev-parse --show-toplevel [94ms]
[2022-07-27T14:54:05.261Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:05.263Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}
[2022-07-27T14:54:05.263Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\source\library\public\pages\library
[2022-07-27T14:54:05.288Z] [trace] [swf] Scan workspace folders: [c:\Development\Projects\MapTool Notebook]
[2022-07-27T14:54:06.629Z] > git rev-parse --show-toplevel [1361ms]
[2022-07-27T14:54:06.629Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:06.629Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook\source\library\public\pages\library' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}
[2022-07-27T14:54:06.630Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\.vscode
[2022-07-27T14:54:06.758Z] > git rev-parse --show-toplevel [124ms]
[2022-07-27T14:54:06.758Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:06.759Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook\.vscode' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}
[2022-07-27T14:54:06.759Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\build
[2022-07-27T14:54:06.847Z] > git rev-parse --show-toplevel [84ms]
[2022-07-27T14:54:06.847Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:06.848Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook\build' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}
[2022-07-27T14:54:06.848Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\release
[2022-07-27T14:54:06.926Z] > git rev-parse --show-toplevel [74ms]
[2022-07-27T14:54:06.926Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:06.927Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook\release' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}
[2022-07-27T14:54:06.927Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\source
[2022-07-27T14:54:07.004Z] > git rev-parse --show-toplevel [73ms]
[2022-07-27T14:54:07.004Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:07.005Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook\source' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}
[2022-07-27T14:54:07.005Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:54:07.087Z] > git rev-parse --show-toplevel [79ms]
[2022-07-27T14:54:07.087Z] fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'
[2022-07-27T14:54:07.087Z] [trace] Opening repository for path='c:\Development\Projects\MapTool Notebook' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: unsafe repository ('C:/Development/Projects/MapTool Notebook' is owned by someone else)\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory 'C:/Development/Projects/MapTool Notebook'\n"
}

Admin user:
[2022-07-27T14:55:12.316Z] Log level: Trace
[2022-07-27T14:55:12.323Z] [info] Validating found git in: C:\Program Files\Git\cmd\git.exe
[2022-07-27T14:55:12.884Z] [info] Using git 2.36.0.windows.1 from C:\Program Files\Git\cmd\git.exe
[2022-07-27T14:55:12.885Z] [trace] [swf] Scan workspace folders: [c:\Development\Projects\MapTool Notebook]
[2022-07-27T14:55:12.885Z] [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
[2022-07-27T14:55:12.885Z] [trace] [svte] Open repository for editor resource c:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html
[2022-07-27T14:55:12.885Z] [trace] [swsf] Scan workspace sub folders. autoRepositoryDetection=true
[2022-07-27T14:55:12.885Z] [trace] [swsf] Workspace folder: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:55:12.890Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:55:12.899Z] [trace] [swsf] Workspace scan settings: repositoryScanMaxDepth=1; repositoryScanIgnoredFolders=[node_modules]; scanRepositories=[]
[2022-07-27T14:55:12.899Z] [trace] [swsf] Workspace scan sub folders: [c:\Development\Projects\MapTool Notebook\.vscode, c:\Development\Projects\MapTool Notebook\build, c:\Development\Projects\MapTool Notebook\release, c:\Development\Projects\MapTool Notebook\source]
[2022-07-27T14:55:14.330Z] [trace] [swf] Scan workspace folders: [c:\Development\Projects\MapTool Notebook]
[2022-07-27T14:55:14.338Z] [trace] [swf] Scan workspace folders: [c:\Development\Projects\MapTool Notebook]
[2022-07-27T14:55:14.416Z] > git rev-parse --show-toplevel [1520ms]
[2022-07-27T14:55:14.419Z] [trace] Repository root: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:55:14.564Z] > git rev-parse --git-dir --git-common-dir [139ms]
[2022-07-27T14:55:14.569Z] [info] Open repository: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:55:14.583Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\source\library\public\pages\library
[2022-07-27T14:55:14.583Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook\source\library\public\pages\library already exists
[2022-07-27T14:55:14.583Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\.vscode
[2022-07-27T14:55:14.583Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook\.vscode already exists
[2022-07-27T14:55:14.583Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\build
[2022-07-27T14:55:14.583Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook\build already exists
[2022-07-27T14:55:14.583Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\release
[2022-07-27T14:55:14.583Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook\release already exists
[2022-07-27T14:55:14.584Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook\source
[2022-07-27T14:55:14.584Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook\source already exists
[2022-07-27T14:55:14.584Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:55:14.584Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook already exists
[2022-07-27T14:55:14.584Z] [trace] Opening repository: c:\Development\Projects\MapTool Notebook
[2022-07-27T14:55:14.584Z] [trace] Repository for path c:\Development\Projects\MapTool Notebook already exists
[2022-07-27T14:55:14.762Z] > git status -z -uall [180ms]
[2022-07-27T14:55:14.773Z] [debug] [wt] Change: c:\Development\Projects\MapTool Notebook\.git\FETCH_HEAD
[2022-07-27T14:55:14.773Z] [debug] [.git] Change: c:\Development\Projects\MapTool Notebook\.git\FETCH_HEAD
[2022-07-27T14:55:14.833Z] > git log --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z -n21 -- c:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html [160ms]
[2022-07-27T14:55:14.866Z] > git symbolic-ref --short HEAD [98ms]
[2022-07-27T14:55:14.965Z] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/master refs/remotes/master [93ms]
[2022-07-27T14:55:15.013Z] > git ls-files --stage -- C:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html [104ms]
[2022-07-27T14:55:15.034Z] > git show --textconv :source/library/public/pages/library/show.html [131ms]
[2022-07-27T14:55:15.078Z] > git remote --verbose [102ms]
[2022-07-27T14:55:15.095Z] > git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname) [124ms]
[2022-07-27T14:55:15.137Z] > git cat-file -s cbfb4c79bbb13e37d8472a446d7b70bd79de74f1 [118ms]
[2022-07-27T14:55:15.193Z] > git config --get commit.template [89ms]
[2022-07-27T14:55:15.300Z] > git check-ignore -v -z --stdin [136ms]
[2022-07-27T14:55:15.330Z] > git status -z -uall [128ms]
[2022-07-27T14:55:15.400Z] > git fetch [824ms]
[2022-07-27T14:55:15.442Z] > git symbolic-ref --short HEAD [104ms]
[2022-07-27T14:55:15.450Z] [debug] [wt] Change: c:\Development\Projects\MapTool Notebook\.git\FETCH_HEAD
[2022-07-27T14:55:15.450Z] [debug] [.git] Change: c:\Development\Projects\MapTool Notebook\.git\FETCH_HEAD
[2022-07-27T14:55:15.529Z] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/master refs/remotes/master [80ms]
[2022-07-27T14:55:15.620Z] > git remote --verbose [80ms]
[2022-07-27T14:55:15.621Z] > git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname) [86ms]
[2022-07-27T14:55:15.694Z] > git config --get commit.template [66ms]
[2022-07-27T14:55:15.807Z] > git status -z -uall [105ms]
[2022-07-27T14:55:15.884Z] > git symbolic-ref --short HEAD [72ms]
[2022-07-27T14:55:15.971Z] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/master refs/remotes/master [81ms]
[2022-07-27T14:55:16.064Z] > git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname) [87ms]
[2022-07-27T14:55:16.072Z] > git remote --verbose [90ms]
[2022-07-27T14:55:16.146Z] > git config --get commit.template [67ms]
[2022-07-27T14:55:16.677Z] > git ls-files --stage -- C:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html [85ms]
[2022-07-27T14:55:16.711Z] > git rev-list --count cc63f193a64eac84c3710d2f91c2ea4aa3cb1542.. -- c:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html [114ms]
[2022-07-27T14:55:16.785Z] > git cat-file -s cbfb4c79bbb13e37d8472a446d7b70bd79de74f1 [103ms]
[2022-07-27T14:55:16.871Z] > git log --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z -n3 -- c:\Development\Projects\MapTool Notebook\source\library\public\pages\library\show.html [150ms]
[2022-07-27T14:55:16.904Z] > git show --textconv :source/library/public/pages/library/show.html [107ms]

I think I see the problem though, but I do not understand why VSC is claiming that the directory is unsafe. It is supposed to be trusted.

And the owner is me...

@Tdue21, thank you very much. VS Code uses git.exe to discover git repositories. Based on the shared output, when using the normal user you are impacted by a change in behaviour described here. To resolve the problem you will have to use the safe.directory configuration setting to add the folder to the list of safe directories.

@lszomoru Yes, I have used the safe.directory setting, and now the issue is resolved.
I do not understand exactly why it is an issue though. Is it because the github repository is owner by one email (mine) and my Windows user is on another email (also mine)?

I do not understand exactly why it is an issue though. Is it because the github repository is owner by one email (mine) and my Windows user is on another email (also mine)?

@Tdue21, I do not believe it is related to that but I could be wrong. If you would like to have this further investigated, I would recommend that you file in issue in the https://github.com/git-for-windows/git repository so that the git experts can take a look at it.

@Tdue21, I do not believe it is related to that but I could be wrong. If you would like to have this further investigated, I would recommend that you file in issue in the https://github.com/git-for-windows/git repository so that the git experts can take a look at it.

Thanks. i'll do that :)


New package: LGUG2Z.komokana version 0.1.2

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

No errors to post.

(Automated response - build 857.)

@wingetbot waivers Add Validation-Executable-Error


change package removals, ignore Dolphin dotfiles

The whitespaces where randomly in the textfiles it seems, in my documents there are none.
I added an experimental script to stop, disable and mask cups. If this is tested to work it could mean cups could be reinstalled.
But for now I moved the cups packages to the common-packages as they are the same for all images.
I removed the removal of kfind, kcharselect and kwalletmanager5, as these are all uncritical and useful packages.
KDEConnect needs to be removed poorly, as there doesnt seem a way to disable it sanely.
But I dont get it, where do these config/scripts run? In a chroot of the system or something? Can you put regular shell commands in there, does it need sudo or is that unnecessary?

The whitespaces where randomly in the textfiles it seems, in my documents there are none.

Right, please get rid of all whitespace changes.
Additionally, I've added Pull Request guidelines here: https://github.com/secureblue/secureblue/blob/live/CONTRIBUTING.md#pull-requests

I added an experimental script to stop, disable and mask cups. If this is tested to work it could mean cups could be reinstalled.
But for now I moved the cups packages to the common-packages as they are the same for all images.

Makes sense

I removed the removal of kfind, kcharselect and kwalletmanager5, as these are all uncritical and useful packages.

Agreed.

But I dont get it, where do these config/scripts run? In a chroot of the system or something? Can you put regular shell commands in there, does it need sudo or is that unnecessary?

Please review the startingpoint documentation, such as here: https://github.com/ublue-os/startingpoint/blob/template/config/README.md
Additionally, the uBlue discord can provide additional support if you need: https://universal-blue.org
Once you have it working, please test it and provide evidence of functionality in the PR.


Fix bug when removing users from roles

Description
Now that roles are added by ID to the user, we also need to remove the roles using the role ID (rather than the role's name).
This was discovered when attempting to remove users from roles in another application. The current workaround is to just update the whole user like so:
ApplicationUser user = await userManager.FindByIdAsync("some-id");
user.Roles.Clear();
await userManager.UpdateAsync(user);

Changes

Fix bug by using role ID, instead of role name when removing from users in UserStore.cs
Add test coverage to SelfCheck.csproj

Wow, thanks a lot !


APS-873 CAS-342 CAS Subject Access Requests

Also, could you please squash all your commits into one?

sure can do - but wanted to show the progression of the codebase for each entity worked on. happy to squash further though!

Also, could you please squash all your commits into one?

sure can do - but wanted to show the progression of the codebase for each entity worked on. happy to squash further though!

I think key thing is to squash to one just before we merge into main

squashed!


Bug: in touch event handling when gravity is set to bottom

There seems to be a bug in handling touch events when gravity is set to Bottom, means in function #onTouchDownToUp(MotionEvent event). It happens when you touch at bottom of view.
See:

Hi. it is working after your changes?

yes, it's working correctly now. or you can test by yourself!

Thank you very much!


Setting page cleanup

🕵♂ Notes for Code Reviewer
Settings page cleanup.
🙈 Screenshots

👯♀ Paired with
Solo

Something is wrong with the GH linter action, it never finishes, I will just merge this


docs: demonstrate use of onDidDismiss() with Alert

Short description of what this resolves:
There are various inaccurate examples on SO and elsewhere that suggest that onDismiss() can be used to detect dismissal of alert controllers.
This documentation showed neither the old nor new way to get this...
Changes proposed in this pull request:

Example of use of onDidDismiss()
Explanation

Ionic Version: 1.x / 2.x / 3.x
Fixes: #

Thanks!


fix(glance): convert image in s3 storage

What this PR does / why we need it:
fixes #13199

Does this PR need to be backport to the previous release branch?:

release/3.9
release/3.8
release/3.7

/area glance
/cc @zexi @swordqiu

/area image


Protect jsonModifiers merge logic against unexisting indexes

It's most likely to happen while using __extends. However, __include was chosen for the test because it doesn't require a RenderContext to load files.

👍


Null in wifi overview status

Should be Disconnect like this:

LuCI Master (git-19.310.44530-a8a7697) / OpenWrt SNAPSHOT r11426-80a799125b
(with the default Bootstrap theme, uhttpd and Firefox 71)


Rename module Core to Svg.Core

The current name looks like it was an oversight, is that right?

Yes, I never noticed because I only import elements/attributes in my project. Will fix it later today.

@kwohlfahrt Cool! Thanks. We also have a bunch of additions that I hope to clean up and contribute soon.


Opacity of Sankey should be the same as the first time it loads

First time:

After mouse-over:

@antw this is minor but do you have a clue how to fix this?


Since columns now know their own type it may be possible to factor out Table._column_types

Although since its immutable maybe this is a good denormalization anyway?

Actually because of lazy column loading this would be pretty messy. Seems unimportant. Closing.


wheelPxPerZoomLevel unit test always fails on Mac

The last unit test in Map.ScrollWheelZoomSpec.js added by @Falke-Design always fails for me locally on Mac:
Firefox 105.0 (Mac OS 10.15) Map.ScrollWheelZoom changes the option 'wheelPxPerZoomLevel' FAILED
	Error: expected 1 to be above 1 (node_modules/expect.js/index.js:96)

We should figure out if it's expected to fail and fix either the behavior of the test, making it more platform-agnostic.

@Falke-Design Experimentally, the test only passes when you set wheelPxPerZoomLevel = 13 on my Macbook. So should we do so, or does this test need more fundamental changes?

@mourner can you share the output of the console of https://plnkr.co/edit/eecQ7iqySIccbB0X?preview after scrolling one step

@Falke-Design I don't have a mouse, but scrolling on a trackpad says this:

User-agent
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) Ap…KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'

Leaflet
'1.9.1'

Win
false

Gecko
false

Chrome
true

Edge
false

Safari
false

Retina
true

wheelDeltaY
6

deltaMode
0

deltaY
-2

deltaX
-2

deltaZ
0

wheelDelta
6

detail
0

devicePixelRatio
2

Zoom delta
0

Does it still fail in Firefox or only in Chrome?

Firefox 105.0 (Mac OS 10.15) Map.ScrollWheelZoom

Chrome Headless 105.0.5195.125 (Mac OS 10.15.7) Map.ScrollWheelZoom

@Falke-Design fails the same way in Firefox.


First stab at a TS conversion

I decided to try to convert one project to Typescript to see how things work out (build commands, etc.).
It's not complete: I have to add lint, test and dev tasks -- help is appreciated.
Until tools-typescript PRs are merged, I have simply copy-pasted the tsconfig.base.json in this project. It's meant to be replaced by a reference.
Altough this is a very small and simple project, there is much to be said about the actual TS code. For now I just did some minimal changes so that it compiles without errors. Please ignore that, I'll open a separate discussion about the code, just focus on the process here.
On the upside, there are a lot less dependencies, a lot less files, build is much simpler. Also it's immediately apparent that getting strict type checking and good definitions is going to be helpful.
Please have a good look at the changes, because some are non-trivial (I'll let you discover them). As this is our first conversion, reviews and feedbacks are much appreciated.
There are a few things that I don't know how to change or if they're ok, like the jspm and bower parts, as well as CircleCI.

@jods4 We had a standard setup we were using on all the TS projects. Did you use that?

@jods4 Did you commit the dist intentionally?

@EisenbergEffect No, I wasn't aware of that! I did not know we had a few TS projects already.
I took the existing JS/gulp project and transformed it into TS/npm.
Can you point me to the standard setup? I'll compare with what I've done here.
@StrahilKazlachev This time, yes. To show and compare the difference in output.
For some reason, the JS build produced an extra index.js that simply re-exported a aurelia-pal.js file.
Not sure why as the main entrypoint in package.json actually was aurelia-pal.js not index.js.
The TS build only outputs a single index.js and I set it as main in package.json.
This is for the best but like any change it is a potential breaking change if someone used exact file paths in their build or something like that.

@jods4 It's not still standard setup, but check the aurelia-valdiation and aurelia-dialog - the package.json has a load of npm scripts. In the dialog repo I've tweaked a bit the setup(don't remember where) I copied from validation.
It would be great in the end to have all common parts in aurelia-tools-ts - configs, utils, guidelines, etc. Why not even a whole template.

I'll have a look at aurelia-dialog then.

It would be great in the end to have all common parts in aurelia-tools-ts - configs, utils, guidelines, etc. Why not even a whole template.

Absolutely. While doing that, I was really wondering if there's any way to move the scripts in npm out of this repo and into aurelia-tools-ts so that they're not duplicated everywhere. Not sure what the best approach is, though. Would be easier with a scripted build (... gulp? damn! 😭 ).
Other random thought: a benefit of mono-repo is that we could share the .editorconfig and .gitignore at root. Those things can't be linked to like tsconfig.json can, they have to be duplicated.

We've been basing most of the new work off of aurelia-validation.

I would say most is an understatement - it's more like all 😅.
I was also wondering how can the script part be shared, and gave up 😢.
tslint.json can also be linked, and we should do it next. It will be much more work.

I had a look at aurelia-validation and aurelia-dialog. I am very pleased how similar to my own they are!
Small differences I noted:

They have the lint, docs, tests and publishing tasks I haven't done yet...  I'm just going to steal those 😁
Cleaning is done for each target instead all of them in one swoop. I can do that as well.
There's a consistent cross-env usage that I just don't get. None of the commands set an env. variable, so what's the point? I'm doing fine without.
Definition files are produced in each target, which is wasteful, I only produce one. I will move it to a sub folder, though, because I realized that there might be more than one file (a future version of TS should fix that, but in the meantime...)
Targets are built concurrently, I do them in sequence. I can change that. What benefits does concurrently have compared to a simple &?

@jdanyow would be the best person to engage on this since he made the original setup.

Added linter command. I copied the lint configuration from aurelia-dialog inside tslint.base.json.
This file isn't meant to stay here, we'll either link to it inside aurelia-tools-ts or put it at the root of a mono-repo.
Linter complains, of course. I'll fix.

Linter is fixed.
Had to change a lot, I added 3 exceptions with tslint:disable-next-line comments.
You can check them out, worth thinking if we should tweak our rules. I think only-arrow-functions could be relaxed as we compile with noImplicitAny which means our code is this-safe anyway. Yes I just made it up.

@jods4 If you are interested you could open a PR in tools-ts, or I'll do when I get time.
I really think we should setup our own tslint.json(rules), don't want to link to the ones in node_modules/tslint. But we can use one of those as starting point.

@StrahilKazlachev I'd like others' opinion before making PR changes to existing ruleset.

Maybe something like yamscripts can be used to share the npm scripts.
What is team's opinion on monorepo and gulp instead of npm scripts?

Re: cross-env and concurrently:
Build needs to work on windows. Don’t want to alienate contributors, makes it easy to run the test suite in edge and IE

@jdanyow I am on Windows! 😁
My understanding is that cross-env is useful to set env. variables cross-platform, but we set none.
concurrently... I don't know? & seems to work fine?
@gheoan Thanks for the tips!
yamscripts generates scripts from a template, so you're saying we could generate from a common template, right?
Monorepo is something we're debating!
If you look at the diff, you'll find gulp was used before npm. But it's hard to justify taking a dep on gulp & friends when your "build" basically comes down to calling tsc.
I found this and I have to say it looks interesting:
https://github.com/testdouble/scripty
It allows cleaner scripts, advanced options and scripts sharing!

I don't care if the build is concurrent or if we use cross-env/concurrently. Just saying whatever we do for scripts needs to work on windows. I think cross-env is making "&" work today. If there's another way that's better let's use it and backport into validation etc.

@jods4 Yes, but the tool you found seems like a better solution.
One advantage of gulp (at least in version 4) is that tasks are functions so they can be shared. In theory the ts-tool package can export gulp tasks that can be used by the other packages.
I guess it comes down to depending on gulp plugins vs depending on tools to normalize the npm scripts commands. I think concurrently is required so that & can work on powershell on windows.
Thank you for taking the time to experiment!

Added tests commands.
One thing I disliked was using JSPM for testing because it meant having to install all dependencies yet one more time. So it made me happy to see that aurelia-dialog and aurelia-validation have moved away from jspm and replaced it with requirejs.
I did try to improve a little more by replacing karma-requirejs by karma-typescript:

Little config, no additional entry point file like requirejs.
No need for extra distributions or whatnot, reads directly from the src and test typescript files.
Watches both src and tests for reruns.
Produces code coverage in the original typescript files (see below).

What do you think?
karma-typescript supports many different code coverage tools, here's the default out-of-the-box output:

Looking good, I like the usage of extends in the tsconfig.

When I execute npm run test there's an compile error in the output. The test succeeds:
18:38 $ npm run test

><EMAIL_ADDRESS>test /home/jd/repos/aurelia/pal
> karma start --single-run

12 11 2017 18:38:57.117:INFO [compiler.karma-typescript]: Compiling project using Typescript 2.6.1
12 11 2017 18:38:59.390:ERROR [compiler.karma-typescript]: test/dom.spec.ts(1,26): error TS2307: Cannot find module 'aurelia-pal'.

12 11 2017 18:38:59.437:INFO [compiler.karma-typescript]: Compiled 3 files in 2300 ms.
12 11 2017 18:39:00.049:INFO [bundler.karma-typescript]: Bundled imports for 2 file(s) in 111 ms.
12 11 2017 18:39:00.129:INFO [karma]: Karma v1.7.1 server started at http://<IP_ADDRESS>:9876/
12 11 2017 18:39:00.130:INFO [launcher]: Launching browser Chrome with unlimited concurrency
12 11 2017 18:39:00.136:INFO [launcher]: Starting browser Chrome
12 11 2017 18:39:01.366:INFO [Chrome 62.0.3202 (Linux 0.0.0)]: Connected on socket h1kG71mKL4Ve291HAAAA with id 8129961
Chrome 62.0.3202 (Linux 0.0.0): Executed 1 of 1 SUCCESS (0.003 secs / 0.003 secs)

Could update typedoc to 0.9.0 while you're in there.

re: karma-typescript setup for the tests- looks good to me for a repo like this. I'd like to see if this can be applied to a repo like aurelia-validation that needs the loader, etc so it can run component tests using aurelia-testing

does this work in powershell and cmd? Looks like you might be using git bash?

@jdanyow One by one:
Test compilation fails: at first I was baffled because it works fine here. But I think I have a guess... I have the aurelia-pal.d.ts file somewhere higher up in a shared node_modules. My guess is that you don't (which is normal) and so TS compiler doesn't have type info for the import. I will try to fix... not sure how.
Upgrade Typedoc: I tried it was a mess. I talked with @StrahilKazlachev and he had the same experience and stopped trying. Unless someone wants to spend time on this, we're stuck at 0.8.0.
Tests with karma-typescript: I did some tests and talked with @zewa666. It doesn't work well if you try to run the full Aurelia framework (e.g. use aurelia-testing). If you do, you basically have the usual aurelia-loader situation: you have to ensure it can load every dependency, which requires lots of config and appropriate libs, etc. We can discuss this more thoroughly in gitter, but my feeling is: let's go with karma-typescript for the vast majority (if not all) of the core libs that are pure tests with aurelia-loader. There are lots of benefits here: simpler, leaner, good code coverage support. For repos that need aurelia-loader such as validation or dialog, we'll have to switch gears and use something more complex (the current setup is with karma-requirejs.
Windows: I've done all of this in cmd and it worked fine. For the sake of it I just tried a build in Powershell and it worked as well.

I know this is getting quite big, but as we discussed recently, how about adding husky + a prepush/precommit hook (whichever you think suites better) which calls tslint. Ideally the prepush hook would additionally run the tests to make sure that no unstable version gets pushed to github

@zewa666 or you could add CircleCI to the PR checks on GitHub and run the linter there. It'll save you and every contributor a bit of tooling and config. IMO we should make it as easy as possible to create a PR, there's enough hurdles to go through already.

Given the choice between blocking commit and a failing check in the PR that prevents merging, I would personnally lean toward the 2nd one.
Sometimes you want to commit stuff for discussion even if it's not right, this PR is a good example of that.
Once this is decided I will happily merge CircleCI config or Husky hooks but I need a little help/contribution as I know nada about both of those.

@jods4 I can't seem to get your karma config working for projects with templates. The change to karma-typescript instead of karma-requirejs may be the issue.
I'll continue to work on it, but I may need some help. I'm trying this on the aurelia-testing project.

@mjwwit See my comment above https://github.com/aurelia/pal/pull/27#issuecomment-344001029
aurelia-loader doesn't play nice with the karma-requirejs loader and after quite some time spent on this @zewa666 and I have given up on making them work together.
Most of tests of Aurelia core are pure JS unit tests, so we suggest that we use karma-requirejs for them: it's simpler and has good built-in code coverage.
If your tests need to use aurelia-loader a more complex setup is required, currently aurelia-validation and aurelia-dialog are based on karma-requirejs and they work, so that's the baseline currently.

@jods, Ah, I didn't see your update.
I still had to update the karma config used in aurelia-validation to be able to load templates.  The result can be seen in https://github.com/aurelia/testing/blob/typescript-port/karma.conf.js.
Are we aiming for a common config that works for all projects?

Common config -> yes, for sure. The goal is to have the same organization everywhere.
Now I personnally think that if there are compelling advantages we could go for 1-2 standard variations, for example one simple test setup with little config, no intermediate files, live watching of both sources and tests files and good code coverage reports; and one setup supporting aurelia-loader.
What do you guys think?

That makes sense since the majority of the projects are code only.
We should also check why some projects merge their files when generating the dist, is it still needed(one step less)?

Fully agree, two test solutions are ok until we find a better way

What's the status on this?

@EisenbergEffect I think we reached a point that's not too bad to start with. I'm sure there will be changes down the line, but that's how it works.
This PR is not meant to be merged. It was meant for discussion and setting up the new project structure, I think it did its part.
Next steps probably are:

set up the mono-repo structure we want to adopt;
"commit" that PR work over there.
Finalize the TS port of aurelia/pal. I worked on the project structure mostly. Code compiles without error but surely could be made a little nicer.

Sounds good. I was thinking monorepo was the next step too so I’ll help move that ahead soon.
Sent from my iPhone

On Dec 11, 2017, at 10:54 AM, jods<EMAIL_ADDRESS>wrote:
@EisenbergEffect I think we reached a point that's not too bad to start with. I'm sure there will be changes down the line, but that's how it works.
This PR is not meant to be merged. It was meant for discussion and setting up the new project structure, I think it did its part.
Next steps probably are:
set up the mono-repo structure we want to adopt;
"commit" that PR work over there.
Finalize the TS port of aurelia/pal. I worked on the project structure mostly. Code compiles without error but surely could be made a little nicer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing this out since we'll prefer to focus on vNext.


multiple fixes

Motivation
While experimenting with self-hosted-shared-dependencies, I faced 3 issues:

#19
scoped packages are not being resolved to the respective scoped registry
2.1. example: @privatescope:registry = "https://privatescope-registry.com"
PackageVersions structured as objects {version: string, include?: string[], exclude?: string[]} are ignored

Changes

extend support for private registries

provide spec property to npmFetch for it to resolve registries associated to a scope
use npmFetch to get tarball

fix support for PackageVersions structured as objects

Any news regarding this PR? I can also confirm that with fetching private packages is not working with current version. This pr, fixed my problem.

Released in https://github.com/single-spa/self-hosted-shared-dependencies/releases/tag/v2.0.1


Update SymEngine and fix build issues

[x] Remove running of tests in main repo's script

Depends on symengine/symengine#782

The changes look good, +1 if tests pass. You should probably update the hash to the latest master.

All tests pass, except the Sage ones, that it can't find GMP.

I think we need to set -DCMAKE_PREFIX_PATH in setup.py to point to $SAGE_LOCAL, then it should find it. Do you know a best place to do this in the setup.py? We should just add it on a command line to setup.py only when Sage is used.

@certik, sage issue is because of the new sage archive's naming extracted folder name is different. It's SageMath now. I fixed this in another branch, but there seems to be a problem with sage's gcc. Let me get back to you after checking

I think they use gcc 4.9.2 or so. If there are any compilation issues, then we need to fix them.

But why cannot we use the old version of Sage for this PR that worked? We can port to new Sage in a new PR.

Old sage version are not available anymore in the link. Maybe they are archived somewhere

I can't find it either. That's terrible.

How is it that this line https://github.com/symengine/symengine.py/blob/9d23ef72b83f93f46bba8e57ed33f0bd78d8dc0a/.travis.yml#L103 didn't fail the build when the script exited with an error?

We should probably call it without the source.

Because set -e isn't added to the top of install_travis.sh. source has to be used because the script is setting up the environment.

I tried to fix it in #41, but I think there is an issue with setting set -e and sourcing it, because then it propagates into the parent shell and actually makes Travis fail. So the right solution is to install things as a regular script with set -e. And then just have a tiny script that sets up environment, and that one will be sourced.

You can also do set +e at the end

Except when it fails, then set +e will never be executed. But then I guess it will fail anyway, so maybe that's ok.

Set LD_LIBRARY_PATH to $SAGE_LOCAL. That should fix it.

@isuruf let's get the Sage stuff out of this PR, and merge #42 which restores the old Sage version and all tests pass there. In this PR let's just update the SymEngine and make sure everything passes.
We can then update Sage in a new PR.

I like the changes up to 95d4aa0, did anything fail at this point? Let's fiddle with Travis in another PR, as we talked, we have to be a bit more careful here.

Closing in favor of #45.


I have the the account {not trial} still not working

When i try to run the the command it gives me below error. I have verified that the userid is correct Any idea why its not downloading ?
INFO     Logging in ...
ERROR    Username or email not found! Please try again.

Check #60 pull request ;)


Fix #14 Add flow, Windows: add downloaddir option, make installer cacheable

Fix #14
On Windows, this PR downloads the setup file to a .cache/mariadb directory by default.
The file is downloaded only if the target does not exist.
The directory is configurable.
The downloaded filename now also contains the version.
By doing so it is possible to setup a cache action that caches the setup executables.
By putting the file in the .cache directory, it may be located in the directory that is already cached in the end action.

Hi @mdeweerd, thanks for the PR. Merged the first two commits to fix #14, but don't want to include the other changes.

@ankane OK, I guess we're forking this to add more options.


Dev/update page objects

What

Use new page object package version
Update page objects to new format
Add notice on Daily accordions for when the day is today

I'm going to merge this, but Firefox tests are having trouble running.


This adds all the Python classes to the Sphinx docs

I imagine some of these should not be added,
but I'm not sure which ones :)

@llorracc or @mnwhite - can you take a quick look and tell us if any of these classes shouldn't be in the docs?

Merging this - we can remove unnecessary classes as needed.


Thread.start() doesn't accept default parameter?

Godot version
Godot_v3.4.4-stable
System information
Windows 10
Issue description
I coding like this:

Run my project and press Enter key, it report error:

It's like because of subclass!
Steps to reproduce
Please run my reprocution project.
Minimal reproduction project
ThreadTest.zip

Fixed by #62440.


dependency and docker base image updates

Pull request questions
Which issue does this address
resolves #173
Why was change needed
security updates
What does change improve
security
packages updated:

"@senzing/rest-api-client-ng": "^2.2.2"
"@senzing/sdk-components-ng": "^2.2.3"
"@senzing/sdk-graph-components": "^2.2.0"
"ssri":"6.0.2"
"url-parse":"1.5.1"
"ng-packagr":"10.1.1"
"lodash":"4.17.21"
"jspdf":"2.3.1"
"browserlist":"4.16.6"
"dns-packet":"1.3.4"

docker updates
node base image updated from "12" to "14-buster"

so funny enough @roncewind I tried running sudo docker scan senzing/entity-search-web-app:latest and the command isn't available in linux as best I can figure. looks like it's only a Windows/Mac Desktop thing( https://docs.docker.com/engine/scan/#prerequisites )
it would still be prudent to check that the fixes in this commit pass your criteria before it goes to master but last time I installed docker on my windows machine it hosed sooOooo many things. If you want to you can check out the branch->build->scan with the following:
git clone -b issue173.awinters.5 https://github.com/Senzing/entity-search-web-app.git
cd entity-search-web-app && docker build --tag senzing/entity-search-web-app .
docker scan senzing/entity-search-web-app:latest

Hey @arawinters we should probably update the base image in the Makefile too. thanks!


My wallpaper JSON file is not supporting

I hosted wallpapers on my other Github account and I am getting error "Unable to fetch data from server". I recently migrated from Polar dashboard to Candybar. I have also used Icon showcase dashboard earlier. Both dashboard supports my JSON file.
URL of JSON file looks like this:
https://raw.githubusercontent.com/xxxxxxxxx/Wallpapers/master/Wallpapers.json
Note- This URL won't load because I have replaced my username with "xxxxxxxxx".
Inside JSON File, I have a code like this.
{
  "wallpapers": [
    {
      "url": "https://raw.githubusercontent.com/xxxxxxxxx/Wallpapers/master/Wallpapers/Galaxy%20S8/Wallpaper%20(01).jpg",
      "dimensions": "2880x2560",
      "name": "Wallpaper 1",
      "copyright": "Copyright ¸ 2017 Samsung. All rights reserved.",
      "author": "Galaxy S8"
    },

Your JSON format missed "thumbUrl", dimensions  and copyright is not needed.
At the moment you need to follow JSON format from here.
The problem not comes from your JSON link.

I changed JSON array from "wallpapers" to "Wallpapers". Error is fixed now but wallpapers are still not showing up. My JSON file contains 1000+ wallpapers. I can't edit that file. Can adding some code, fetch "thumbUrl" from "url".

Wait until next release in a few hours

Thank you so much! 💃

@AnkitRawat Check release 3.1.4, it should works.

Worked! Thanks! :D

@AnkitRawat Do not use 3.1.4, use release 3.1.5 instead

okay! Just now updated again! :D


fix: branch_separator should not be a common character. Use @ instead of _

When branch_separator = "_", you may not get right branch name and directory path from session filepath.
Users may set a branch name like feat/a_b. If current directory is /Users/who/nvim, the session filepath will be %Users%who%nvim_feat%a_b.vim.
When parse the session filepath, it will get directory /Users/who/nvim_feat/a with branch b. But we expect to get the directory /Users/who/nvim with branch feat/a_b,
It is a BREAKING CHANGE for current users who have sessions stored.

I think branch_separator should not be configurable for user.

In hindsight, I agree. Unfortunately a lot of users will have _ in their branch session so this break their config

I've been thinking about this a bit in the last week. I think changing it to something like @@ is the way to go.
But...I don't want to break people's config. I think I'll add a deprecation notice, warning people that we're going to change the default value in a fortnights time and that if they wish to avoid this, they need to add branch_separator as an explicit item in their config.


Make a better sample site.

The sample site should be the documentation site. It should show off the features of wok in an attractive way, both the generated pages, and the source code itself.
The current sample site is ugly, and doesn't make much sense to anyone except me.

The doc site is pretty good at this, but it doesn't show many features of wok.

The sample site now uses hooks.


Update remove command

Proposed changes
This PR adds ngsi v1 mode to rm command.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage remained the same at 100.0% when pulling 3df8e2f437c472e2d023d58bb12a8448abbf07b9 on fisuda:update/remove_cmd into d3f2fa1b7a61342bd51e38b56f56db3bed0673e7 on lets-fiware:main.


Cut new release with gopsutil bump

Hello! We use this package widely at my work where we are in the middle of upgrading to M1 Macs. I noticed https://github.com/lightstep/lightstep-tracer-go/commit/32244bdae70ddb08f779cad6ba75a264780855e7 was recently merged to update gopsutil to fix an issue on M1.
Is there any chance you could cut a new release with this change?
cc @codeboten who looks to have cut most of the recent releases and already updated the changelog: https://github.com/lightstep/lightstep-tracer-go/commit/1770a5da4bceffbde69cd3679417bb127171135c

hi @aneeshusa! I'll be looking at making a release next week.

This has been completed: https://github.com/lightstep/lightstep-tracer-go/releases/tag/v0.26.0

Thank you @codeboten - saw you went ahead and removed the gopsutil dependency altogether! Have been rolling out the new lighstep-tracer-go version internally and it's working well.


The definition of this report is not valid or supported by this version of Reporting Services

Hi, we're trying the extension for the first time and still figuring out how to us it.
We're having issues when creating a release and get the below message
The definition of this report is not valid or supported by this version of Reporting Services. The report definition may have been created with a later version of Reporting Services, or contain content that is not well-formed or not valid based on Reporting Services schemas. Details: The report definition has an invalid target namespace 'http://schemas.microsoft.com/sqlserver/reporting/2016/01/reportdefinition' which cannot be upgraded.
Webservice URL - http://iwn-sqlbi-d01/reportserver/ReportService2010.asmx?wsdl
TFS - 2017
SQL Server version - 2012

Seems like a similar issue to #3

@ygeelen-tb
Above issues is somewhat similar, but in my case I do build the reports in TFS and Publish them

I did notice that even though my build succeeded I get a warning that the project was not built
warning MSB4078: The project file "Accounting\Accounting.rptproj" is not supported by MSBuild and cannot be built.

@jguaring - You'll need to install the appropriate tools on your build server in order to build report projects.

@dschuermans - we have SSDT for VS2015 installed on the build server is there a specific version that I should be installing?

If you deploy to an environment with a different SQL Server version than your reports, then you need an extra build task to build your reports similar to this:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\devenv.com "./MyProject.sln" /Project "./sources/MyProject.Reports/MyProject.Reports.rptproj" /Rebuild "$(BuildConfiguration)|$(BuildPlatform)"

@ygeelen-tb - not sure what you mean by similar to this:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\devenv.com "./MyProject.sln" /Project "./sources/MyProject.Reports/MyProject.Reports.rptproj" /Rebuild "$(BuildConfiguration)|$(BuildPlatform)"
So what I did on my release definition is added an agent task to build the solution using the MSBUILD task,

but im getting the below errors
1
2017-04-03T13:07:02.1213773Z ##[section]Starting: Build solution $(System.DefaultWorkingDirectory)/SSRS-Accounting-Reports/AccountingReports/Accounting/Accounting.rptproj
2
2017-04-03T13:07:04.9236575Z ##[command]"C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe" "C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj" /nologo /nr:false /dl:CentralLogger,"C:\WBI-Agent_work_tasks\MSBuild_c6c4c611-aa2e-4a33-b606-5eaba2196824\1.0.52\ps_modules\MSBuildHelpers\Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll";"RootDetailId=|SolutionDir=C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting"*ForwardingLogger,"C:\WBI-Agent_work_tasks\MSBuild_c6c4c611-aa2e-4a33-b606-5eaba2196824\1.0.52\ps_modules\MSBuildHelpers\Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll"  /p:platform="Default" /p:configuration="Dev" /p:_MSDeployUserAgent="TFS_059f91dc-25c4-4966-9489-3beaabc88cb2_release_9_54_57_1"
3
2017-04-03T13:07:05.0246676Z Build started 4/3/2017 8:07:05 AM.
4
2017-04-03T13:07:05.0796731Z ##[error]C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj(2,1): Error MSB4041: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the  element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.
5
2017-04-03T13:07:05.0816733Z Project "C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj" on node 1 (default targets).
6
2017-04-03T13:07:05.0816733Z C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj(2,1): error MSB4041: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the  element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.
7
2017-04-03T13:07:05.0816733Z Done Building Project "C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj" (default targets) -- FAILED.
8
2017-04-03T13:07:05.0826734Z
9
2017-04-03T13:07:05.0826734Z Build FAILED.
10
2017-04-03T13:07:05.0826734Z
11
2017-04-03T13:07:05.0826734Z "C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj" (default target) (1) ->
12
2017-04-03T13:07:05.0826734Z   C:\WBI-Agent_work\r1\a\SSRS-Accounting-Reports\AccountingReports\Accounting\Accounting.rptproj(2,1): error MSB4041: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the  element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.
13
2017-04-03T13:07:05.0826734Z
14
2017-04-03T13:07:05.0836735Z     0 Warning(s)
15
2017-04-03T13:07:05.0836735Z     1 Error(s)
16
2017-04-03T13:07:05.0836735Z
17
2017-04-03T13:07:05.0836735Z Time Elapsed 00:00:00.04
18
2017-04-03T13:07:05.4147066Z ##[error]Process 'msbuild.exe' exited with code '1'.
19
2017-04-03T13:07:05.4807132Z ##[section]Finishing: Build solution $(System.DefaultWorkingDirectory)/SSRS-Accounting-Reports/AccountingReports/Accounting/Accounting.rptproj
20

MsBuild is the problem, it doesn't recognize rptproj projects.
What I meant is to use a Command Line task (in your build definition preferably) that calls the devenv.com application:

Specify C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\devenv.com in the Tool parameter
Specify "./MyProject.sln" /Project "./sources/MyProject.Reports/MyProject.Reports.rptproj" /Rebuild "$(BuildConfiguration)|$(BuildPlatform)" in the Arguments parameter

@ygeelen-tb - build and release worked.
Thanks for your assistance. Great Tool

Great! Thank you, we should have time to write more documentation very soon and this will be included.
It would be nice if you would leave a review here: https://marketplace.visualstudio.com/items?itemName=tobania.SqlReportingServices

@ygeelen-tb
we just noticed that when do the release that the build server is not getting the latest version of the source code?
BuildTool - C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\devenv.com
BuildArgument - "C:\Workspaces_WBI\SSRS\Trunk\Call Log Report\CallLogReport.sln" /Project "C:\Workspaces_WBI\SSRS\Trunk\Call Log Report\Call Log Report\CallLogReport.rptproj" /Build "$(BuildConfiguration)|$(BuildPlatform)"

@ygeelen-tb
another thing that we noticed is that when we include data sources and data set on the release - reports are not associating the datasources and dataset

@jguaring
For the first issue: you could try cleaning the sourcesdirectory on build (there's an option for that on one of the build tabs). Are you sure you triggered a new build before executing the release?
This should not be related to the extension though.
For the second issue we implemented a new feature. Please try checking the "Update Data Source" path.

@ygeelen-tb
this is what I specified as per your previous post
•C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\devenv.com in the Tool parameter
•"C:\Workspaces_WBI\SSRS\Trunk\Call Log Report\CallLogReport.sln" /Project "C:\Workspaces_WBI\SSRS\Trunk\Call Log Report\Call Log Report\CallLogReport.rptproj" /Rebuild "$(BuildConfiguration)|$(BuildPlatform)" in the Arguments parameter
its the second bullet that does not get the latest version.

@jguaring The command only builds the code, it doesn't featch the latest version from source control.
You need a Get Sources build task before this build task I think.

@ygeelen-tb
do I need to reinstall the extension to get the new feature "Update Data Sources"?

Normally not. Only if an extension changes to a new major version, you need to switch to it using a dropdown at the top right of the build/release task in your definition.
So you should see the field in the task. If not please provide a screenshot if possible.

@ygeelen-tb
I had to reinstall as the option was not available.
does this option apply to both shared Data sources and Datasets?
I tried using the option but got an error below
2017-05-04T14:31:27.3443317Z Updating the DataSources of the report CallLogReport...
213
2017-05-04T14:31:27.3443317Z
214
2017-05-04T14:31:27.3443317Z
215
2017-05-04T14:31:27.5474594Z ##[error]Microsoft.PowerShell.Commands.WriteErrorException: The operation you are attempting on item '/Data Sources/DS_GISDATAWAREHOUSE' is not allowed for this item type. ---> Microsoft.ReportingServices.Diagnostics.Utilities.WrongItemTypeException: The operation you are attempting on item '/Data Sources/DS_GISDATAWAREHOUSE' is not allowed for this item type.
216
2017-05-04T14:31:27.5787247Z ##[error]PowerShell script completed with 1 errors.

@jguaring Just for our information, did you use VSTS or a TFS instance?

@muziekklas
I used TFS

Following up with this issue, we have an older SQL report server version (2012) and receive this error.  It seems that the reports still get push when this happens.  Is it possible to add an option in the Advanced steps to ignore this particular error?

https://github.com/tobania/VSTS.Extension.SqlReportingServices/pull/33
Let me know if any of you think this PR might fix this issue, or if any changes should be done to it.

Well this issue was related to a wrong configuration in VSTS of our product. Could you send us a screenshot (you can hide out passwords and domains ect with some creative paint-skills)  of your VSTS configuration?

This is actually in TFS 2017, moving older SQL reports (created in VS 2008) to a SQL reports server (SQL server 2012, I think.) which configuration screen are you looking for?  For the tasks I have the required fields, and service account credentials.

On Nov 3, 2017, at 2:07 PM, AntonK<EMAIL_ADDRESS>wrote:
Well this issue was related to a wrong configuration in VSTS of our product. Could you send us a screenshot (you can hide out passwords and domains ect with some creative paint-skills) of your VSTS configuration?
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

More specific the URI of the service

During the build phase I use devenv.com to build the solution.  Currently using an older version of VS to run the build, I receive the error with any version it seems.

In the release, using the reportservice2010 URL:

Were there any plans to put PR #33 into master? I reviewed it and it looks to be the fix that I need to be able to use this

@kbrashears I think I've found the actual issue with that error.  Verify that you are not trying to send any other files as input to the SQL Reports server.
In my case, I was attempting to upload unsupported files to the report server endpoint.  Make sure your "Local Report Path" parameter is checking for the RDL file type
IE:
Instead of this:
$(System.DefaultWorkingDirectory)/SQL Reports Build Test/drop/VS2012ReportTest/VS2012ReportTest/bin/Debug/
Use this:
$(System.DefaultWorkingDirectory)/SQL Reports Build Test/drop/VS2012ReportTest/VS2012ReportTest/bin/Debug/*.rdl


Draw kpi ID and KC uuid from source spreadsheet

Create IDs sheet to store this information; Use instead of command line arguments.

See #9:

The spreadsheet must include a worksheet called IDSheet. This sheet must be the last sheet in the workbook. It contains a minimum of two cells. Cell B1 contains the KPI ID. Cell B2 contains the KC ID. These two IDs will be provided to you.

commit: d3acca8


add etcd local backup plugin

Signed-off-by: liutao<EMAIL_ADDRESS>add etcd local backup plugin

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.liutao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Aves and Aves Libre in Fdroid

Hello,
please can you explain the difference between Aves and Aves Libre?
I am an happyuser of Aves Libre from Fdroid
Edit: I find the answer in the Wiki, thanks for Aves Libre @deckerst 🙏

Glad you found the answer!


Segmentation fault on ARM due to oversized Eigen matrix

Elevation mapping throws std::bad_alloc() as soon as the map is supposed to be moved. Adding point clouds to a map fixed in position works.
The underlying problem is probably in grid_maps, namely in EllipseIterator.cpp:32.
See https://github.com/ethz-asl/elevation_mapping/issues/42 for details.

I have managed to solve this problem by going through the grid_map_core package and initialising any variable of type Index (I also did it for uninitialised variables of type Position just in case), for example:
Index submapStartIndex;
submapStartIndex.setZero();
This exists in files outside the EllipseIterator.cpp although I could not say if other uninitialised declarations were the cuplrit.


Consolidate list view bulk action buttons

Use a bootstrap split button dropdown (drop up) to consolidate common bulk action buttons in all list views.
The primary action should be edit, the dropdown should contain "update groups" and a line separated delete (in red).
In case of custom bulk actions like the device list view (add components), leave those alone for now. Specifically for add components, convert to a drop up.
Standardize that this primary/edit group is the first set of buttons and all others come after it. Look through core for other places where this needs to be updated.

Implemented by #5885.


Use older Ubuntu

Use an older ubuntu that ships with docker-compose 1.26.x
Signed-off-by: Joe Grund<EMAIL_ADDRESS>

This change is

docker-compose is newer than advertised.


Add index exists function in index_scheduler which stops opening indexes to only check if they exist.

Pull Request
Related issue
Fixes #4784
What does this PR do?

Added index_exists function in the index_scheduler.
Resolved opening indexes to only check if they exist.
Made changes to existing tests to test this function.

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Kerollmops
Done the changes, Please review and let me know of any changes

@Kerollmops
I just realised, It should be
index_scheduler.index_exists(&index_uid) != Ok(false)
right


Use GitHub actions to autogenerate docs

I've set it up to autogenerate docs in gh-pages branch. Current docs available at https://snmishra.github.io/django-categories/
If you want to host the generated docs on GitHub pages, you'll need to create the file .nojekyll in the gh-pages branch. It should be a one time action.

Hey @snmishra thank you for that. I'm thinking about forking this repo and get your changes into it so that I can push to PyPI something like django-categories2 since this repo doesn't seems to be maintained anymore. Dozens of PRs and issues just pilling up.

Also I will try to follow these steps to generate the docs on gh pages

If you want to host the generated docs on GitHub pages, you'll need to create the file .nojekyll in the gh-pages branch. It should be a one time action.

@mazulo Would you like to be added as a maintainer of this project? I am unable to give it the attention it needs.

Hey @coordt I can imagine how it can be (been there). Now I'm having some free time that I can use to contribute again to the community. So we can either do it (add me as member/maintainer) or apply the project to https://jazzband.co/

@mazulo It is now a part of Jazzband. Thank you for the suggestion.

@coordt I'm more than happy it was helpful! Have a nice day and thank you for your hard work on this tool! I'm using and loving it!


fix(docs): update to include .rpm binaries

This PR...
Changes

changes to documentation according to #2654

Fixes

updates to monokle documentation page

How to test it

Screenshots

Checklist

[ ] tested locally
[ ] added new dependencies
[x] updated the docs
[ ] added a test

@topliceanurazvan made the changes

Hey @dipankardas011, can you fix conflicts for this so we can merge it?

Try to merge main into your branch, you should be able to fix it from there

Try to merge main into your branch, you should be able to fix it from there

Sure

Done


Use Github Releases for hosting and fetching update files. Enables our fork of Atom to update in-app.

For Windows, see: https://github.com/Squirrel/Squirrel.Windows/blob/develop/docs/using/github.md
There are no separate docs files I could see for macOS, but here is the repo: https://github.com/Squirrel/Squirrel.Mac

We should look into some higher-level abstractions already available to do this kind of thing:

https://www.electronjs.org/docs/tutorial/updates#using-updateelectronjsorg

Requires that we code sign our app, so this is sadly not an option for the time being.

https://www.electronjs.org/docs/tutorial/updates#deploying-an-update-server

Depending on your needs, you can choose from one of these:

Hazel – Update server for private or open-source apps which can be deployed for free on Now Vercel. It pulls from GitHub Releases and leverages the power of GitHub's CDN.

Actually, I think the requirement to have signed apps is just so we don't get "this code is unauthorized" warnings, and so we don't have our updater stopped with a warning by the OS. (See this documentation.)
We won't get far attempting auto-updating without code signing. (I assume update.electronjs.org probably lets you use it without code signing, but then the users would have a very hard time actually installing the updates.)
Maybe we should disable auto-updating (which is basically broken on this fork until we code sign), and instead show users the GitHub Releases page URL.
For example: we could use the GitHub API, check for updates, and just display a URL to download the new version in "About Atom". And perhaps display a bubble notification instead of running the auto-update mechanism.

We will get this kind of error in the first installation, and it will happen again during updating. So I don't think codesign is a determining factor here.

I think seeing this kind of errors at all is an issue, right? Many users aren't technical enough to understand what the error means or why it's happening. And their antivirus quarantines the update file.

I think seeing this kind of errors at all is an issue, right? Many users aren't technical enough to understand what the error means or why it's happening. And their antivirus quarantines the update file.

This will also be a significant issue for programmers working on work machines as most help desk teams will require only verified software be used, with proper signings for the purposes of auditing


fix heavy loop with lazyredraw

set lazyredraw
:terminal

This make heavy loop.

I don't bet this is best.

Codecov Report

Merging #2082 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   73.94%   73.93%   -0.02%
==========================================
  Files          90       90
  Lines      131659   131658       -1
  Branches    28923    28922       -1
==========================================
- Hits        97359    97341      -18
- Misses      34280    34297      +17
  Partials       20       20

Impacted Files
Coverage Δ

src/terminal.c
56.67% <0%> (ø)
:arrow_up:

src/if_xcmdsrv.c
83.63% <0%> (-0.9%)
:arrow_down:

src/gui_beval.c
44.47% <0%> (-0.31%)
:arrow_down:

src/libvterm/src/screen.c
71.87% <0%> (-0.11%)
:arrow_down:

src/gui.c
46.18% <0%> (-0.11%)
:arrow_down:

src/window.c
81.51% <0%> (-0.1%)
:arrow_down:

src/gui_gtk_x11.c
47.86% <0%> (-0.06%)
:arrow_down:

src/if_py_both.h
76.22% <0%> (-0.01%)
:arrow_down:

src/channel.c
82.63% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b984b80...4f2b441. Read the comment docs.


Show updated post date in feed preview

#63

Thanks for the PR! Do you have a screenshot ?

Looks good to me, thanks!


Simplify the configuration GUI

Currently there are a lot of items in the GUI. It would be better if there was a nicer way to change them all

I like the way that "Diesel Railcar Simulator" handles this, particularly in their calibration menu. When you click to assign an axis to an in-game control, it raises a window that first asks you to move the axis to the zero position (or press a button to continue), and it gives you five seconds. Then, it gives you another five seconds to move the axis through the full motion that you intend for the axis to be assigned to. Presumably it then picks the axis with the highest value range change during that period and saves the assignment.


Observations and Limitations of API Tools

Wanted to leave some observations similar to the chain of thought smirk that was mentioned over here for JSON agents.
You can copy this snippet to test for yourself (Mine is in Colab atm)
# Install dependencies
!pip install huggingface_hub cohere --quiet
!pip install openai==0.27.0 --quiet
!pip install langchain==0.0.107 --quiet

# Initialize any api keys that are needed
os.environ["OPENAI_API_KEY"] = ""
os.environ["HUGGINGFACEHUB_API_TOKEN"] = ""

import os
from langchain import LLMChain, OpenAI, Cohere, HuggingFaceHub, Prompt, SQLDatabase, SQLDatabaseChain
from langchain.model_laboratory import ModelLaboratory
from langchain.agents import create_csv_agent, load_tools, initialize_agent, Tool
from langchain import LLMMathChain, OpenAI, SerpAPIWrapper, SQLDatabase, SQLDatabaseChain
import requests
from langchain.agents import create_openapi_agent
from langchain.agents.agent_toolkits import OpenAPIToolkit
from langchain.llms.openai import OpenAI
from langchain.requests import RequestsWrapper
from langchain.tools.json.tool import JsonSpec
import yaml
import urllib
# Core LLM model
llm = OpenAI(temperature=0)

# Create an API agent

# LoveCraft - .yaml API
yaml_url = "https://raw.githubusercontent.com/APIs-guru/openapi-directory/main/APIs/randomlovecraft.com/1.0/openapi.yaml"
urllib.request.urlretrieve(yaml_url, "lovecraft.yml")
with open("/content/lovecraft.yml") as f:
  data = yaml.load(f, Loader=yaml.FullLoader)
lovecraft_json_spec=JsonSpec(dict_=data, max_value_length=4000)
headers = {}
requests_wrapper=RequestsWrapper(headers=headers)
lovecraft_json_spec_toolkit = OpenAPIToolkit.from_llm(OpenAI(temperature=0), lovecraft_json_spec, requests_wrapper, verbose=True)
lovecraft_agent_executor = create_openapi_agent(
    llm=OpenAI(temperature=0),
    toolkit=lovecraft_json_spec_toolkit,
    verbose=True
)

tools = [
    # Tool(
    #     name = "Search",
    #     func=search.run,
    #     description="useful for when you need to answer questions about current events. You should ask targeted questions"
    # ),
    Tool(
        name="Lovecraft API - randomlovecraft.com",
         func=lovecraft_agent_executor.run,
         description="Access randomlovecraft.com documentation, process API responses, and perform GET and POST requests to randomlovecraft.com"
    )
]
mrkl = initialize_agent(tools, llm, agent="zero-shot-react-description", verbose=True)

mrkl.run("Can you get me a random Lovecraft sentence?")
mrkl.run("Can you get me a random Lovecraft sentence using /sentences`?")
mrkl.run("Using the `https://randomlovecraft.com/api` base URL, make a `GET` request random Lovecraft sentence using `/sentences`. Use a limit of 1.")

I pulled the openAPI example from the docs to do some testing on my own. I wanted to see if it was possible for an agent to fetch and process API docs and to be able to return the response for use in other applications. Some of the key noted things:
🐘Huge API Responses
If your response is large, it will directly affect the ability for the agent to ouput the response. This is because it goes into the token limit. Here the Observation is included in the token limit:
 a possible workaround for this could be routing the assembled requests over to a server / glue tool like make. Still haven't looked at other tools to see what's possible! Perhaps just wrapping that request in another request to a server would suffice.
🤔Verbosity is Better?
There is a weird grey area between too detailed and not detailed enough when it comes to the user prompt: I.e. check these 3 prompts out:
✅Test1:
input:
Can you get me a random Lovecraft sentence

output:
> Finished chain.
A locked portfolio, bound in tanned human skin, held certain unknown and unnamable drawings which it was rumoured Goya had perpetrated but dared not acknowledge.

🙅♂Test2:
input:
Can you get me a random Lovecraft sentence using /sentences?

output:
> Finished chain.
To get a random Lovecraft sentence, make a GET request to https://randomlovecraft.com/api/sentences?limit=1.

✅Test3:
input:
Using the `https://randomlovecraft.com/api` base URL, make a `GET` request random Lovecraft sentence using `/sentences`. Use a limit of 1.

output:
> Finished chain.
The sentence returned from the GET request to https://randomlovecraft.com/api/sentences?limit=1 is "Derby did not offer to relinquish the wheel, and I was glad of the speed with which Portsmouth and Newburyport flashed by."

🔑Expensive Key Search
I ran out of my free OpenAI credits in a matter of 5 hours of testing various tools with Langchain 😅. Be mindful of how expensive this is because each action uses a request to the core LLM. Specifically, I noticed that json_spec_list_keys is a simple layer-by-layer search where each nested object observation costs an LLM request. This can add up especially when looping. I guess workaround wise, you'd probably want to either use a lighter/cheaper model for the agent or have someway to "store" Action Inputs and Observations. I guess that can be solved here, haven't implemented yet.
All in all, this tool is absolutely incredible! So happy I stumbled across this library!

Hey! Thank you for what you have written up here.
Im basically in your same situation:

My openapi 3.0.0 specs needs 23000 tokens so for me it's almost impossible to procede by using gpt3.5-turbo or davinci. How did you solve this problem? Should we wait GPT4?
Thanks ;)

@RizziGit93 I haven't looked back at this yet, been working on other things. Maybe this has been corrected? Will have to go back and test..


Undefined index: C:7:"MongoId":24:{58c72404911e696c6bf5b970}

Selecting my collection job and jobs has reference many with employees, when i'm selecting the jobs and job employees it comes up with this error.
/vendor/doctrine/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php
ENV:
PHP 5.5.9
ODM: 1.0.8

Please share some code that helps us reproduce the problem, ideally in form of a failing test case.
As a note, you are using MongoDB ODM 1.0 which we don't support anymore. Please upgrade to 1.1 and let us know if the issue persists. Thank you!

Thanks @alcaeus thanks for your response.
here is my document and code hopefully it will be helpful to elaborate the problem.
jobs document looks like
{     "_id" : ObjectId("58a67fd0911e69a0298b4568"),     "record_status" : "Open",     "title" : "dfdfdf dfd f",     "description" : " dfdf",     "note" : "dfdf",     "employees" : [          ObjectId("5858b7f4911e69283b8b81ff"),        ObjectId("57b6a469911e693e3a8b4568")     ] }
employee collection looks like
{     "_id" : ObjectId("5858b7f4911e69283b8b81ff"),     "record_status" : "active",     "generated_timestamp" : ISODate("2016-08-19T06:17:13.000Z"),     "salutation" : "Mr.",     "firstname" : "B",     "lastname" : "Admin1",     "username" : "user1",     "email"<EMAIL_ADDRESS>    "has_verified" : false,     "user_type" : "normal_user",     "employee_id" : "0001",     "last_login_timestamp" : ISODate("2017-05-17T02:08:48.000Z"),     "vehicle" : null }, {     "_id" : ObjectId("57b6a469911e693e3a8b4568"),     "record_status" : "active",     "generated_timestamp" : ISODate("2016-08-19T06:17:13.000Z"),     "salutation" : "Mr.",     "firstname" : "A",     "lastname" : "Admin2",     "username" : "user2",     "email"<EMAIL_ADDRESS>    "has_verified" : false,     "user_type" : "normal_user",     "employee_id" : "0002",     "last_login_timestamp" : ISODate("2017-05-17T02:08:48.000Z"),     "vehicle" : null }
code is:
$employee_id = "57b6a469911e693e3a8b4568"; 		$jobs = $dm->createQueryBuilder("Jobs") 				->field("record_status") 				->equals("open") 				->getQuery() 				-> execute(); 		foreach ($jobs as $job) { 			//when i execute the bellow statement the above error is appeared. 			if(!empty($job->getEmployeeIDs()) && in_array($employee_id, $job->getEmployeeIDs())){ 			} 		}
Job Class:
`<?php
/** @ODM\Document (collection="jobs") */
class Job
{
const open = 'Open';
const scheduled = 'Scheduled';
const cancelled = 'Cancelled';
const started = 'Started';
const ended = 'Ended';

/** @ODM\Id */
public $id;

/** @ODM\Field(type="string") */
public $record_status;

/** @ODM\Field(type="string") */
public $title;

/** @ODM\Field(type="string") */
public $description;

/** @ODM\Field(type="string") */
public $note;

/** @ODM\ReferenceMany(targetDocument="Employee", simple=true) */
private $employees;

public function __construct()
{
	$this->employees = new ArrayCollection();
}

public function getEmployeeIDs()
{

	$employee_ids = [];
	foreach ($this->employees as $record_employee) {
		if (!in_array($record_employee->id, $employee_ids)) {
			$employee_ids[] = $record_employee->getId();
		}
	}
	return $employee_ids;
}

}
`

@nationdata-it I don't see anything weird in your code, could you please write a failing test case like this one (or any other from that directory)?

Closing because of no update from OP. @nationdata-it feel free to either re-open this issue with more details or better yet, provide a failing test case.


vspd: Use filter.MatchAny instead of filter.Match.

This brings a notable performance improvement to spent ticket scanning without changing functionality.

This brings a notable performance improvement to spent ticket scanning without changing functionality.

To quantify, it cuts the scanning time roughly in half.