230 us additional views navigation

I abstracted away the schema selector in the top bar and the one in the setting into a single component( see SchemaSelector.tsx) since they have the same behaviour.
I also changed the layout of the accordion that display the views at Eddie's request. It is no longer showing the views based on the table but instead it is based on the schema.
Small demo:

I created an AdditionalViewNavBar component. When a table has additional views available it will show with the different options, otherwise it is hidden.
For the time being it only shows the available display type and the links don't lead to a view. Future stories will be the implementation of the views

I changed the style of the buttons and removed the View title


Questions about mean result?

Dear authors,
Thanks for your work, I suffer from a question when following your work.
The paper reports result for multi-category and reports a mean result.
I wonder if the result for per-category is obtained by training the model on the data of the specified category.
Thanks!

I wonder if the result for per-category is obtained by training the model on the data of the specified category.

Yes, we follow previous works to train and evaluate the tracker per category.  And the reported "mean" result is the weighted sum of the per-category results according to the number of frames.

Hi! I got it. thanks for your reply and I will close this issue soon.


Ability to customize what is hidden through a preferences menu

This feature has been requested several times, so it's going to happen. It could be similar to the preferences menu that Make Medium Readable Again provides, which is accessible through the Add-ons Manager and consists of checkboxes for each item (whether to hide it or not).
By default, everything considered "distracting" could be hidden, which allows people to use it simply by installing the add-on and without having to do any configuration.

Not going to do this because there are extensions out there that do it already, and do it better.
This extension will just be an easy, no config needed way to hide distractions on YouTube.


Removing redundant links in Readme

Removed the link to old docs (react-native-kit.github.io) as it was creating confusion.
Also, the same was already updated with new docs link and this was just redundant.

Good catch @samadritsarkar2 !


🐞 [Bug]: Bad gateway for wordpress solution main net node 481

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
Bad gateway when deploying wordpress solution on main net node 481. no ipv4.
It worked when deploying on test net node 1, no ipv4
Steps To Reproduce

go to dashboard.grid.tf
deploy wordpress solution with custom domain, gent01.grid.tf gateway, no ipv4, set DNS A record
click on admin or wordpress button
bad gateway

Note: I could SSH with wireguard on the node 481 but the wordpress site and admin site didn't work.
Note: I did a test with dashboard.test.grid.tf, node 1, no ipv4, custom domain, gent02.grid.tf and it worked. I had to go to admin panel, update the database and then access the wordpress website.
which network/s did you face the problem on?
Main
version
latest
Twin ID/s
No response
Node ID/s
481
Farm ID/s
vcc3 farm name
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
{
  "version": 0,
  "contractId": 407373,
  "nodeId": 481,
  "name": "word0",
  "created":<PHONE_NUMBER>,
  "status": "ok",
  "message": "",
  "flist": "https://hub.grid.tf/tf-official-apps/tf-wordpress-latest.flist",
  "publicIP": null,
  "planetary": "300:ef1c:abb7:eca0:4f18:784a:30bc:9f5d",
  "myceliumIP": "",
  "interfaces": [
    {
      "network": "nwwqr07",
      "ip": "<IP_ADDRESS>"
    }
  ],
  "capacity": {
    "cpu": 2,
    "memory": 4096
  },
  "mounts": [
    {
      "name": "diskm8e",
      "mountPoint": "/var/www/html",
      "size":<PHONE_NUMBER>0,
      "state": "ok",
      "message": ""
    }
  ],
  "env": {
    "SSH_KEY": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCXho85ijWqoqk3P+d4aBLs8K4wWowLnBx3mjo573Ey2yCXDO9Vx76cpoCvCW1kXKoDkVvy6OFbulKCVxYlF1rsgARCVYpHek5psnWi+TLjjnxFZcOWi8hZvveEVBE9Di59RxijGoZz//Gw4RqxzeaZJYPH/A6OdbqNvfb9/2kKQarN9LjL0dAozx5ZweCixlyzpOgiQeXbiHwkdHCI+X04lXbM4g4vgqIQ83Oh1iYlyr26IPmSz4MdbUj/B4NFFft+oV5JRn/1D35ANel+PHuI8mDKBEuK6YQ2CapC+D8oMn20fGr1Wd5NXYYJtonbID7iOUWfkR3fHkxM9nvqlk4DKSQgxEDhv38hyKrXfUmsVNioYkCMnLfScg7BD688Wxl/6pZa7QNCtTiJWXMxQux+mFw6E1Qd9toH4ncqk6TyC1VSBbvHPta5kHvHmrrKjcwUMBeumAU+emqO6oNxVYM7Brtjqaz6qdCi4ptL+HXqXgKatoPl3qY192PDqmwkEDk= pcone@pcone-computer",
    "MYSQL_USER": "admin",
    "MYSQL_PASSWORD": "X3#nTx%wZNfS",
    "ADMIN_EMAIL"<EMAIL_ADDRESS>    "WP_URL": "wp1.threefold.cfd"
  },
  "entrypoint": "/sbin/zinit init",
  "metadata": "",
  "description": "",
  "rootfs_size":<PHONE_NUMBER>,
  "corex": false,
  "gpu": [],
  "deploymentName": "word0",
  "projectName": "wordpress/word0",
  "billing": "No Data Available",
  "wireguard": "[Interface]\nAddress = <IP_ADDRESS>/32\nPrivateKey = FhffgAj3dEha2Qw9RhTJpLKMzlUbQ2E8rpZyXuVzBtw=\n\n[Peer]\nPublicKey = JQ1BulD14I0J606aIVkDdN+blzjo1EJsPB4m7XH6SUg=\nAllowedIPs = <IP_ADDRESS>/16, <IP_ADDRESS>/32\nPersistentKeepalive = 25\nEndpoint = <IP_ADDRESS>:1890"
}

I really don't think this is an issue with the Playground or the Wordpress image. Here's a copy of the log that MySQL printed when it crashed:
[+] mysql: 2024-04-24 17:15:14+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.0.34-1debian11 started.
[-] mysql: 2024-04-24 17:15:14+00:00 [ERROR] [Entrypoint]: mysqld failed while attempting to check config
[-] mysql: 	command was: mysqld --datadir /var/lib/mysql_tmp --verbose --help --log-bin-index=/tmp/tmp.LSeWGHGCP5
[-] mysql: 	2024-04-24T17:15:14Z UTC - mysqld got signal 11 ;
[-] mysql: Most likely, you have hit a bug, but this error can also be caused by malfunctioning hardware.
[-] mysql: BuildID[sha1]=957a7f933a999383cd4331a77a624f94708e2029
[-] mysql: Thread pointer: 0x0
[-] mysql: Attempting backtrace. You can use the following information to find out
[-] mysql: where mysqld died. If you see no messages after this, something went
[-] mysql: terribly wrong...
[-] mysql: stack_bottom = 0 thread_stack 0x100000
[-] mysql: /usr/sbin/mysqld(my_print_stacktrace(unsigned char const*, unsigned long)+0x3d) [0x559db33c1a3d]
[-] mysql: /usr/sbin/mysqld(print_fatal_signal(int)+0x393) [0x559db228a033]
[-] mysql: /usr/sbin/mysqld(handle_fatal_signal+0xa5) [0x559db228a0e5]
[-] mysql: /lib/x86_64-linux-gnu/libpthread.so.0(+0x13140) [0x7fac70d53140]
[-] mysql: /usr/sbin/mysqld(memory::Aligned_atomic<long>::Aligned_atomic()+0x6b) [0x559db305425b]
[-] mysql: /usr/sbin/mysqld(Delegate::Delegate(unsigned int)+0x53) [0x559db3054653]
[-] mysql: /usr/sbin/mysqld(delegates_init()+0x2e) [0x559db30547be]
[-] mysql: /usr/sbin/mysqld(+0xeddab6) [0x559db2015ab6]
[-] mysql: /usr/sbin/mysqld(mysqld_main(int, char**)+0x25ae) [0x559db201e39e]
[-] mysql: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xea) [0x7fac7085ed0a]
[-] mysql: /usr/sbin/mysqld(_start+0x2a) [0x559db1ffe3ca]
[-] mysql: The manual page at http://dev.mysql.com/doc/mysql/en/crashing.html contains
[-] mysql: information that should help you find out what is causing the crash.
[-] mysql: + mkdir -p /var/lib/mysql_tmp
[-] mysql: + chmod +x /usr/local/bin/sql_entrypoint.sh
[-] mysql: + cd /
[-] mysql: + ./usr/local/bin/sql_entrypoint.sh mysqld --datadir /var/lib/mysql_tmp

According to this line:
Most likely, you have hit a bug, but this error can also be caused by malfunctioning hardware.
It seems mostly likely to be the hardware, since the issue is isolated to a single hardware system.


Add Graphite Integration Test

This PR is to address issue ##1735.
Still WIP

Looking good @corylanou -- badly needed.

@corylanou is this guy ready to go?

This test is very brittle, just so you know.

It's why I haven't merged it yet :-)  It's only brittle because of a bug that is in the broker that Ben is currently fixing.  I'm going to wait until he has that fixed and then update all the tests to re-enable index/wait endpoints.  This will significantly speed up the integration tests, which are not taking almost a minute to run.

continues to wait patiently

Fixed at brittle test methodology.  We now have a wait that will poll for expected results, or times out.
Ready for review.

You are adding a file called influxd.exe. What is going in there?

+1


Added delay action to be used for intuitive delays on actions.

Delay[f=5] will delay the execution of the next action by 5 frames. It does not affect the timing of conditional checks.
Delay is intended to be used in combination with other actions, and the syntax allows it to be used easier with other action.
Example:
ayaka dash, delay[f=3], attack will delay the attack by 3 frames.
While ayaka dash; wait(3); ayaka attack; will not delay the attack at all.

I'm of the opinion that we shouldn't add/change the syntax for now until #1148 is done. This may or may not be necessary depending on how hooks ends up being used

implemented as part of #1148


[Help] Capabilities of pre/post scripts

Hi all!
Because of some specific use case I can not use the "citrus:randomUUID()" function to create random values in my feature file. I moved the creation of these values out of the feature file and wanted to create then in a shell script which is executed as a pre-script before the scenario. However I still need to access these created values later in my feature file. So I tried out two different approaches to pass these values to my feature-file:

I am trying to write these values as variables in a properties-file, which are then loaded in a step (Given load variables file.properties) in the feature file.
I am trying to export these values in the script as environment variables

Both approaches however are unsuccessful, because the values file are still unchanged in the file and no new environment variables exists! Are the these approaches actually feasible?
Here is my command that I executed! "yaks test --settings file.settings.yaml  --resource file-variables.properties --resource file-setup.sh --resource resources/foo.parquet --resource file-cleanup.sh  file.feature"
I suspect that my pre-script is actually not executed at all, because I put a sleep into it and the execution of the feature-file starts immediately.
Thanks for your help!

Pre/post scripts are run on your local host only. The scripts that you have added as file resources are not executed on the test runtime. This is mainly for security reasons. We have had some discussions about it in #124.
You can pass environment variables to the test runtime like this:
$ yaks test sample.feature --env MY_VAR=value

Or as configuration in yaks-config.yaml
config:
  runtime:
    env:
      - name: MY_VAR
        value: my-value

Another option I see is the use of secrets (property file) that you can bind to the test. The secrets are automatically added as test variables. See this example on secret usage
Maybe adding a custom extension would be another solution for you (see documentation). You could add Cucumber before test hooks that create test variables.

Hi Christoph
Thank you for your fast reply. The custom extension sounds like the best option for our use case!
The actual reason why I needed to be able execute a shell script in the test pod lies in these three alluxio rest calls.
streamId=$(curl -v -X POST http://alluxio-proxy.system.svc.cluster.local:39999/api/v1/paths/${ALLUXIO_FILE_PATH}/create-file)
curl -v -X POST http://alluxio-proxy.system.svc.cluster.local:39999/api/v1/streams/${streamId}/write --data-binary @"$PARQUET_FILE" -H "Content-Type: application/octet-stream"
curl -v -X POST http://alluxio-proxy.system.svc.cluster.local:39999/api/v1/streams${streamId}/close
After I created the file at the given file path I get the streamID back from alluxio as a response. With this streamID I can then upload the file content for the created file. It would be nice that one can save the response from an http step as a variable, so I can use this variable for the next http step.

You can actually save the response content to a test variable. Try this:
Then expect HTTP response body: @variable(streamId)@
And receive HTTP 200 OK
And print 'StreamId: ${streamId}'

This will use the @variable()@ validation matcher to create a new variable streamId from the response body. This should work for plaintext response bodies.

Hi Christoph!
Thank you for your solution! It worked fine! I was not aware that this validation matcher from the citrus framework was so tightly integrated.
However one issue is remaining! Because to run our test we create some folder, files and also databases and tables we would like to clean then up after the scenario. Is there a way to define/annotate scenarios or steps so that they guaranteed to run, even if the scenario failed?

Hi Nils,
Citrus provides the concept of finally blocks that should do exactly what you describe. I have added a draft to use these finally blocks in a feature in the form of Groovy scripts. please have a look at:
Scenario: Finally block
    Given $(doFinally().actions(echo('${greeting} in finally!')))
    And variable greeting is "Ciao"

The step above will use the pure Citrus action syntax in Groovy to add actions to the test. Notice that the variable greeting is defined after the finally block. It works because the finally block is run after the scenario.
You can also use multiline scripts or load the script from file resource:
Scenario: Finally block
   Given apply script
    """
    $(doFinally().actions(
        echo('${greeting} in finally!')
    ))
    """
    And variable greeting is "Ciao"

It was hard for me to find a proper BDD syntax. Especially to include this finally as "normal" step in the BDD Given-When-Then style. So I came up with the Groovy solution which works but is not perfect in terms of BDD. Maybe you have a better idea here?

@NilsBerger can we close this one?

Hi Christoph!
Thank you for you help! Yes we can close this one


Seasocks using in my sw

Hi,
I'm probably missing something stupid, but i'm trying to develope a software using seasocks for websocket.
I followed steps in tutorial to install the library and "build/src/app/c/ws_test" works correctly.
Now I started to copy the "ws_test.cpp" code to a file in other directory to test what to do to compile myown software using libsockets libs.
THIS IS MY MAKEFILE:

top_srcdir := $(abspath $(dir $(lastword $(MAKEFILE_LIST))))
top_builddir ?= $(CURDIR)
CC=g++ -std=c++11

SEASOCKS := ./seasocks

INCLUDES := -I $(SEASOCKS) -I $(SEASOCKS)/src/main/c/internal -I $(SEASOCKS)/src/main/c/seasocks \
	-I $(SEASOCKS)/src/main/c -I $(SEASOCKS)/build/src/main/c \
	-I /usr/local/include/

LIBS:= -lseasocks

LDFLAGS += -L$(SEASOCKS)/build/src/main/c

#LINKLIBS := $(SEASOCKS)/build/src/main/c/libseasocks.so.1.4.3

all: serverws

serverws: serverws.cpp
	$(CC) $(INCLUDES) serverws.cpp $(LIBS) $(LDFLAGS) -o serverws

clean:
	rm -rf *.o *.out

The "make" command compile without errors and create serverws executable, but when I try to execute I get: "error while loading shared libraries: libsockets.so.1.4.3 cannot open shared object file: No such file or directory".
I used the same kind of makefile for a lot of project without problems.
Someone can help me?
Alessandro

Does it work with the static library?

@aledisi any further thoughts on this? Can you answer @offa 's question? thanks!

@aledisi any further thoughts on this? Can you answer @offa 's question? thanks!


Add support for Ola Maps

Hello @JustinCanton,
Just for the sake to keep on the radar, there is a new maps provider which is trying to break the status quo Ola Maps.
https://maps.olakrutrim.com/
It would be nice to add support, they have a generous free tier and the first year everything is free. Their APIs also seems to be well documented.
What do you think?
Cheers

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Hi @ollie10,
This does look relatively well docummented, and the pricing tiers are actually very impressive. I will add this to the list of APIs to support.
Justin


chore: Adds deprecation warnings for app parameter when using to_asgi_response method of responses

Pull Request Checklist

[X] New code has 100% test coverage
[X] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[X] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description
This PR adds deprecation warnings for the use of app in the to_asgi_response methods of responses. The app parameter is redundant since the request parameter has the associated app available.

Close Issue(s)
Closes #2217

@provinzkraut just pinging you for another review :)

please resolve the last comment @wevonosky

@Goldziher and @provinzkraut I left a comment on why I had to modify that test.
@all-contributors please add @wevonosky

@all-contributors please add @wevonosky for code


cue: move to by-name

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#manual-migration-guidelines
Manual migrations should only be lightly encouraged if the relevant code is being worked on anyways. For example with a package update or refactoring.


Edit pass: Automate tagging

Description
Edits for "Automate tagging of your entire stack".
Reviewer Notes
Most of these edits fall into two categories:

Edits to structure and organization to improve the article as teaching content
Edits to adhere to the style guide

Didactic edits include:

Visual spacing (and use of alerts)
Parallel structure for headings
Transitions and organization
More manageable code blocks
Updated code blocks to match repo
Fuller context in sections for instructional guidance

Stylistic edits include:

Reader-centric pronouns
Avoiding "easy" and "simple"
Active voice
Punctuation
Consistent and dark mode-friendly images

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mmfred  I've pushed a new commit, resolving these comments! Let me know if you spot anything else (or if I missed anything)


PowerRename Task List

Description of the new feature / enhancement
The possibility to put in a task list multiple changes to be able to see the result before applying the changes
Scenario when this would be used?
Sometimes I need to make multiple minor changes to multiple batches of files and it's annoying having to constantly tweak each change
Supporting information
No response

What would that be for example. Almost everything should be doable in one rename action.

What would that be for example. Almost everything should be doable in one rename action.

For example I have this file:
Invader zim      -  S01e07 thieves Of Planets -   Triumph of the mud
I want to make each word start in a capital letter, then change the letter E of the episode to a capital letter and finally correct the different spaces between the hyphens
My idea is to make all the changes and add them to a "task list" to preview the final result. At the end with everything done, apply the changes.


not working on custom json response

I tried to response user with serialize, but  not success
class UserSerializer < ActiveModel::Serializer
  attributes :id, :first_name, :last_name, :email
end

class Registrations < Grape::API
   resource :users do
      get "/" do
         {"message": "Hello", user: User.first}
      end
   end
end

I want result like that {message: "hello", user: {id: 1, first_name: "A", last_name: "B", email<EMAIL_ADDRESS>but it response all attributes of User

Seems problematic, you should build a test case here for this to begin with.

@khacluan this is many months late, but you can use ASM's meta functionality to achieve your use-case. Try this:
class Registrations < Grape::API
   resource :users do
      get "/", meta_key: message, meta: 'Hello' do
         user
      end
   end
end

something like this should also work
class Registrations < Grape::API
   resource :users do
      get "/" do
         options[:meta_key] = message
         options[:meta] = 'Hello'
         user
      end
   end
end

I'm going to close this issue, as it is almost a year old. If the above doesn't work, please open a new issue.


Simple skeleton Python/Go server

On this wonderful Friday morning, I was scrolling through cool projects from the Balena team and noticed an inaccuracy in the description of the project balena-go-hello-world ^_^
I think you meant Go server instead of Python.
Good luck in your work and please with new ideas!)

Thanks @stanlyzoolo for reaching out this is very much appreciated. We are in process of upgrading our getting started guides and the examples. In the mix of making 7 similar PR's to 7 different repos, I must have mixed this up.
For your context, this description is coming from the file https://github.com/balena-io-examples/balena-go-hello-world/blob/master/balena.yml and a change here will instantly get reflected on balenahub when the fleet is pushed next. I will do the needful. Feel free to suggest more improvements.


Feh viewer right-click crash

Describe the bug
There is buffer overflow and crash on right-click in the Feh image viewer.
Steps To Reproduce
Steps to reproduce the behavior:

Install feh via nix-shell -p feh.
Run feh from console. Example: feh some_image.jpg.
Press a mouse right button and you get

*** buffer overflow detected ***: terminated
Aborted (core dumped)

Expected behavior
When you press a mouse right button there must show a menu without buffer overflow.
Additional context
The problem is in the function feh_menu_draw_submenu_at in the file src/menu.c. This function call imlib_image_fill_polygon function. After that produces buffer overflow and the application crashes.
A workaround is to edit feh_menu_draw_submenu_at like:
void feh_menu_draw_submenu_at(int x, int y, Imlib_Image dst, int ox, int oy)
{
        // Draw filled triangle
        x -= ox;
	y -= oy;

	imlib_context_set_image(dst);
	imlib_context_set_color(0, 0, 0, 255);

	for (int i= 0; i <= 3; i++) {
	  imlib_image_draw_line(x+i, y+3+i, x+i, y+9-i, 0);
	}

	return;
}

Notify maintainers
@viric @WilliButz @globin @Ma27
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
charlzk@nixos-test ~> nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.52, NixOS, 23.11 (Tapir), 23.11.20230911.3a2786e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"home-manager, nixos"`
 - channels(charlzk): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Associated issue: https://github.com/derf/feh/issues/676


Rename org/repositories to achieve consistency

Since we introduced the modules "InexorCore" and "InexorFlex" for the C++ and nodejs parts respectively, I think our InexorCore-repo ("inexor-game/code") should be renamed to "inexor-game/core" to be consistent.

Not Found.

This breaks very old links, since it would be our second rename (we renamed our organisation once), the question is, if we do care for them or if it doesn't matter.
As @Terencode suggested once, many orgs have their main repo named like their product itself, e.g. https://github.com/atom/atom
https://github.com/desktop/desktop
https://github.com/eclipse/eclipse
https://github.com/flatpak/flatpak
So I would be rather in favor of "inexor" as the name for the core repository instead of actually core.
Bringing the discussion about the organisation name from Riot here:
We couldn't get the name "inexor" because it's taken here on GitHub AND on way too many platforms already. However, we are using "inexorgame" everywhere except on GitHub (Travis and AppVeyor are using the GitHub names, so that is a consequence rather than a choice) and on GitHub "inexor-game".
If we should decide to rename the core repository, and therefore breaking already the first links, we could do now a second cut and rename the organisation to "inexorgame". The pain of breaking links will only get bigger with time. So pretty much now or never.
AFAIK GitHub is only upholding a single redirect from the latest renaming (as long as nobody else wants to use the name).  So if we do both we should first rename the repo, then the organisation, to get better found by people who are getting a 404 via URLs -> if the repo is not found people are likely trying to see if the organisation is still existing, and they should be getting redirect to the new name.

It is really good sarcasm that this issue got the number #404.

The sauerfork redirect is dead anyways. Or am I doing sth wrong?
"sauerbraten-fork" "sauerfork" and "sauerbratenfork" are all not working

We could name it:
https://github.com/inexor-game/inexor-core (or better: https://github.com/inexorgame/inexor-core)
https://github.com/inexor-game/inexor-flex (or better: https://github.com/inexorgame/inexor-flex)
If we are going to rename the organization and links are broken, we can also rename the repos.
After cloning, you would have a folder named inexor-core and inexor-flex instead of code and flex which is more meaningful and avoids conflicts.

Okay, I just tested it and it seems like the redirects are more powerful as I thought.
https://github.com/sauerbraten-fork/sauerbraten-fork/ is still redirecting here.
https://github.com/sauerbraten-fork/ is not, but most of the time we link to our main repository anyway I guess.
So our current URL of our main repository should redirect to whatever we rename our org+repo.

We could name it:
https://github.com/inexor-game/inexor-core

I don't like the "inexor-" prefix, why adding it to our main repo and flex but not e.g. website, data and so on? Seems redudant, however, naming the main repository simply "inexor" alone seems to be very common.  Imagine you don't know the name "inexor" yet. How would you react on this?
Imo the same for "inexorgame", it's clear for us but not as clear as "inexor-game" to read. But anyways..
Plz not "inexorflex". at least a dash should lead the eyes of the novice reader a bit.
@Croydon
Bc website and data are not our core products while flex and core are both (besides of the issue tracker and the wiki in the repo) more or less equally
Good to know the repo redirect works :)

To avoid any confusions it would be fine if the repository name of Inexor Core has something with core in it's name. Just inexor isn't precise enough. And core could conflict with repositories named core from other projects (search for https://github.com/search?utf8=✓&q=core&type=)

Ok, the dash makes sense. Therefore I would prefer https://github.com/inexor-game/inexor-core and https://github.com/inexor-game/inexor-flex

Bc website and data are not our core products while flex and core are both

Maybe for the website, but data is absolutely needed, in my opinion it would be another inconsistency if two, but only two, repositories do have the "inexor-" prefix. It is also more to type and remember.

And core could conflict with repositories named core from other projects (search for https://github.com/search?utf8=✓&q=core&type=)

What kind of conflict? Every half-mature git client should check that it doesn't overwrite another repository and if, optionally, the developer doesn't like the name, he can simply rename it.

Ok, the dash makes sense. Therefore I would prefer https://github.com/inexor-game/inexor-core and https://github.com/inexor-game/inexor-flex

If you meet someone and want to tell them go to https:/.... it is easier to remember when there is no dash in there and no second "inexor". Keep it short and simple.
Therefore I'm definitely for it to remove the dash at least in the organisation name. Making it consistent with other inexor accounts.

KISS would be: go 2 inexor.org

For me it's OK to remove the dash in the organization name if we can harmonize our account names. Seems to be easier than to rename all other account names.
If we remove the dash from the organization name, we have to rename the npm package names as well (@inexor-game/... --> @inexorgame/...).
From product perspective I would like to force consistent naming. We are offering two products (Inexor Core and Inexor Flex) and Inexor is an essential and homogeneous part of it. Only both words together are forming the brand. I know it's repetitive but

[...] in my opinion it would be another inconsistency if two, but only two, repositories do have the "inexor-" prefix

True, then we should rename data and data-additionalto inexor-repo-core and inexor-repo-additional or inexor-media-core and inexor-media-additional. In my opinion the name data is a leftover from the good old sauer days where we hadn't media repositories. The data folder of sauer contained everything that wasn't C/C++ code. This won't be the case anymore: the media repositories shall only contain media files (textures, models, maps, ...) and no user interfaces, cubescript and configuration files.

Reasonable compromise.
Maybe the inexorgame name appeared bc inexor-game contained a forbidden character for a name on some platforms.
I agree with the media stuff.
We shouldn't forgot to rename all occurrences in the wiki as well.
So the required steps are:

[ ] clone all repos. Replace all occurrences
[ ] clone the wiki. Replace all occurrences
[ ] search the issue tracker for the old names (??)
[ ] move all miss-named accounts

take care when merging feature branches

True, then we should rename data and data-additional to inexor-media-essential and inexor-media-additional

Please don't. It's terrible to have inexor in every repo name repeated, there is a reason why we have an organisation in the first place. There are also reasons why git clone has a parameter where you can specify a local name. We can update the Wiki respectively, by simply adding an inexor-core behind the clone command if that is getting rid of your concerns, that the default "core" or "code" is too generic @Hanack. Also in the end of the day it should be completely up to every person how to organise files.
Just imagine every GitHub organisation would do that.

[...] in my opinion it would be another inconsistency if two, but only two, repositories do have the "inexor-" prefix. [...]

You complained about inconsistencies so I tried to make a suggestion which is consistent by prefixing everything with inexorfollowed by the type of the repository like ui or media or whatever then followed by the actual name of the ui or media or whatever. So that there is a fixed naming scheme inexor-{type}-{name} for every repository.
For me the inexor- prefix is not that important for media and ui repositories. But we should at least stick with {type}-{name} for every ui or media or whatever repository.
Actually my main intention is that the Inexor Core and  Inexor Flex repositories are fully named (inexor-core and inexor-flex). The reason is that we really should make them brands:

[...] We are offering two products (Inexor Core and Inexor Flex) and Inexor is an essential and homogeneous part of it. Only both words together are forming the brand. I know it's repetitive.

You complained about inconsistencies

Yes, I pointed that out in your suggestion, but as previously explained I am not a fan of the inexor- prefix alltogether.

The reason is that we really should make them brands:

But shouldn't Flex be invisible for the average player? So from my understanding Flex is a brand for only developers and server admins. (Yes, brands can exists for these target groups, just pointing out again). And for the average player we have only one brand: Inexor. They don't care for internals.
Anyway, if we don't find further consensus, I'm willing to compromise and say let's go for:

inexor-game -> inexorgame
code -> inexor-core
flex -> inexor-flex
data -> media-core
data-additional -> media-additional
data-playground -> media-playground
data-src -> media-src
InexorGlueGen -> gluegen
leave the rest as it is

I like the {type}-{name} schema. I also used it also for the ci repositories.
How does that sound to everyone?
(And I will roll my eyes everytime I have to type the URL to our core repo 😁)

I did like the inexor-game prefix very much
Why would flex become inexor-flex, and code become inexor-core instead inexor-game/flex and inexor-game/core

I did like the inexor-game prefix very much

When we said prefix, we mean the suggestion "inexor-" prefix in the repository name, the organisation name stays of course (or the minus is getting removed from it, but stays then).

I have to correct my past-self: After reading redirections again I guess it doesn't matter if we first rename repos and then organisation or the other way around.
Since renaming the org seems to be the only agreement for sure so far I would start now with that.

search the issue tracker for the old names (??)

This can be done only manually and has very little use. I'm strongly against doing that.

Search for "inexor-game in:comments"

okay, but searching without editing is pointless and editing only works manually? or someone needs to write a script for that..

@Croydon actually im in favor of Hanacks proposal.
But if we really do your

inexor-game -> inexorgame
code -> inexor-core
flex -> inexor-flex
data -> media-core
data-additional -> media-additional
data-playground -> media-playground
data-src -> media-src
InexorGlueGen -> gluegen
leave the rest as it is

im strongly against two points:

InexorGlueGen -> gluegen
and
data -> media-core
InexorGlueGen should be called like that, its a distinct application.
media-core is a weak name since it steals core from InexorCore.
media-essential is better.

Furthermore media-src is imo not meaningful enough. media-sources skips the step in your brain to unfold "src" to sth meaningful.
However i would really like if just everything which is really for the game is named like that.
if "inexorgame" would have been called "inexor" this would not be a problem, but since the name "inexor" is taken on GitHub we have to improvise.
And to depend on the discipline of everybody to keep a good ordering on their local harddrive when cloning is not really sth anyone should ever do ;D
Hence i really prefer the verbosity of Hanacks suggestion, although it needs some adaption to read (it does not really look cool, but it adds clarity)

https://github.com/inexorgame/inexor-core
https://github.com/inexorgame/inexor-flex
https://github.com/inexorgame/inexor-media-essential (or inexor-media-main)
https://github.com/inexorgame/inexor-media-additional
https://github.com/inexorgame/inexor-ui-flex
https://github.com/inexorgame/inexor-ui-core-console
https://github.com/inexorgame/inexor-ui-core-hud
https://github.com/inexorgame/inexor-ui-core-menu
https://github.com/inexorgame/inexor-ui-core-interface

with the addition of

https://github.com/inexorgame/inexor-media-experimental
https://github.com/inexorgame/inexor-media-sources

and leaving the rest as is.
ofc inexor-core and inexor-flex are the most important ones here.
I guess we need some more voices to break the tie or we just skip "inexor-" for anything but the both above..

im strongly against two points:
InexorGlueGen -> gluegen

Okay, but the whole point is about consistency. InexorGlueGen is our only repository with upper cases (conan packages with external names excluded) AND the only compount name without hypens between each part.
New suggestion: What about inexor-gluegen?

Furthermore media-src is imo not meaningful enough. media-sources skips the step in your brain to unfold "src" to sth meaningful.

Agreed.

media-core is a weak name since it steals core from InexorCore.
media-essential is better.

We called the main media repo already media-core long before we started calling our main code repo core. And, again: consistency. Why one time main and one time core?

InexorGlueGen is sth really distinct.
It could be named anything.
koraa once even suggested the name dove for it, since its actually just a dependency we have. A totally different project if you will.
media-core:
core should disappear to make the name "core" (if you omit the "inexor" when you abbreviate) unambiguous.

media-core:
core should disappear to make the name "core" (if you omit the "inexor" when you abbreviate) unambiguous.

Alright. But then I suggest to just name it "media", it breaks for now with the {media}-{type} schema, but makes more sense in the long run. media(-core) will be the only media repository from us at some point.
We just have one website, so we don't call it site-core as well.

why not rename it after it gets the only media repo we have?

why not rename it after it gets the only media repo we have?

Because we break URLs again then, and only one redirect works, so the current URLs would break for good with a second rename. Also renaming shouldn't become a regular thing.

okay, seems legit.
so to summarize what we already agreed on:

https://github.com/inexorgame/inexor-core
https://github.com/inexorgame/inexor-flex

what we did not yet agree on:
the inexor- prefix for the following repos:

https://github.com/inexorgame/inexor-media
https://github.com/inexorgame/inexor-media-additional
https://github.com/inexorgame/inexor-media-experimental
https://github.com/inexorgame/inexor-media-sources
https://github.com/inexorgame/inexor-ui-flex
https://github.com/inexorgame/inexor-ui-core-console
https://github.com/inexorgame/inexor-ui-core-hud
https://github.com/inexorgame/inexor-ui-core-menu
https://github.com/inexorgame/inexor-ui-core-interface

I think we should agree asap since some stuff is broken until we do. (e.g. we did not yet replace the links in the code repo)

Actually I think the probability of providing multiple media repositories is higher than having only one. It could be that we break down things in the structure of media repositories as well. For example to create a media repository for a game mode or a group of game modes.

okay.
People srsly lets make this decision.
two open points:

media-essential vs media for the main data repo

react with :tada: for media-essential and with :heart: for media

inexor- prefix for the ui and media repos: yes or no.

react with :+1: for the inexor- prefix and with :-1: for no

I'd suggest the deadline to end Sunday 25.06.2017 for this voting. Anyone can vote.

If not just media then please media-main instead of media-essential. Still shorter.

media is fine, and media-essential is even finer.
A comprehensive name is very important to quickly identify things.
main does not tell you anything about the repo's function, main of what? main of submodules? main of configs? essential is much better.

main does not tell you anything about the repo's function, main of what? main of submodules? main of configs?

main of media. of course, that is why it would be named media-main and not just main. You can ask the very same question with essential.
essential does not tell you anything about the repo's function, essential of what? essential of submodules? essential of configs?
No, essential media stuff, of course.

main of media. of course, that is why it would be named media-main and not just main. You can ask the very same question with essential.

not "of course" here.

essential does not tell you anything about the repo's function, essential of what? essential of submodules? essential of configs?

I disagree. Media essential tells you: you want to get started with inexor? These media files are essential to the game.

Another note and probably my last one: We once renamed the "src" directory in our core repository to "inexor" so that it couldn't collide with other source directories (why the hell should anyone want to mix it up with other stuff anyway? keep your source clean!).
Now we have a inexorgame/inexor-core/inexor directory. Oh, and a "src" directory in flex. And we want to rename "media-src" to "media-source" because "src" needs another "translation" step in the brain.
...
My point is, I can't see the overall goal of how you want to name things. Consistency can be achieved in a lot of ways, it doesn't explain the naming schemes, which seem to make names longer without making them easier in any way. I would even argue harder, because they are longer and have redundant information. How to name stuff locally and how and where to save stuff is up to each and every one individually.

We once renamed the "src" directory in our core repository to "inexor" so that it couldn't collide with other source directories (why the hell should anyone want to mix it up with other stuff anyway? keep your source clean!).

no, it should not collide with system headers ("net/", but i srsly doubt this step was necessary, but that had been a totally different discussion. id be open for changing it back, but plz another issue)

My point is, I can't see the overall goal of how you want to name things.

Well this whole issue is about making compromises.. but yes, "src" could be "source" everywhere.

okay.
People srsly lets make this decision.
two open points:
media-essential vs media for the main data repo
react with :tada: for media-essential and with :heart: for media
inexor- prefix for the ui and media repos: yes or no.
react with :+1: for the inexor- prefix and with :-1: for no
I'd suggest the deadline to end Sunday 25.06.2017 for this voting. Anyone can vote

okay, its: 2  :+1: , 2  :-1:, 4 :tada: and 2 :heart:
this means:

the main media repo will be named media-essential
patt for the inexor--prefix

aschaeffer just said it does not bother him much
-> no inexorprefix for media and ui repos

Go!


Hovering over a cell in our AGGrid in UDD causes an error

Describe the bug
A clear and concise description of what the bug is.

Steps to reproduce the bug

Expected behavior

A clear and concise description of what you expected to happen.
Specifications

Version: n/a
Browser: n/a
OS: n/a

Additional context

<EMAIL_ADDRESS>is the version of eds which causes the error.
<EMAIL_ADDRESS>works fine!

Add any other context or screenshots about the bug. An example in CodeSandbox is very helpful

Literally the only search result on google for "invalid on disconnected popover" is the chromium source code where it is defined
chromium

I am wondering if !isConnected() here means the element is not yet attached to the dom... I am using useLayoutEffect to call showPopover() when open is true, but perhaps I should have used useEffect instead 🤔
Unfortunately I have not yet been able to reproduce this error locally but I will try more later


Unexpected result, 99/(3-1) = 32 ?

See the image below:

I expect the second result to be 49.5, see SpeedCrunch results:

There seems to be an operation priority problem.
Same with my very first test : (1+3)kg to g -> 3001 (where I expected 4000)

Seems linked to #26

@SarathSantoshDamaraju  is there a release date for v0.1.0? thanks

Yes, expect it by this weekend.
On Wed, 9 Oct 2019 at 23:23, Chao<EMAIL_ADDRESS>wrote:

@SarathSantoshDamaraju https://github.com/SarathSantoshDamaraju is
there a release date for v0.1.0? thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sarthology/caligator/issues/27?email_source=notifications&email_token=ACQKC7SUUV5UCI55MDHWEYTQNYLARA5CNFSM4I37JTA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYX6ZI#issuecomment-540114789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQKC7QVKJM3AEBZI5VEZXLQNYLARANCNFSM4I37JTAQ
.

--
[image: freshworks-dew.png]
Krishna Sarath
FrontEnd Developer - Freshworks
e<EMAIL_ADDRESS><EMAIL_ADDRESS>--
The content of this e-mail is confidential and is intended solely for the
use of the individual or entity to whom it is addressed. If you have
received this e-mail by mistake, please reply to this e-mail and follow
with its deletion. If you are not the intended recipient, please note that
it shall be considered unlawful to copy, forward or in any manner reveal
the contents of this e-mail or any part thereof to anyone. Although
Freshworks has taken reasonable precautions to ensure no malware is present
in this e-mail, Freshworks cannot accept responsibility for any loss or
damage arising from the use of this e-mail or attachments.

@SarathSantoshDamaraju any update?


help

i have the same issue it is that the song wont load event for an hour and it never loads i tried takeing it out of the files but it didnt work so please i need help (ik i didnt reply to the other one bc i forgot)

Please provide me with all the songs you have. And if you don't mind sharing them, please also send me your logs.

the songs are really not big but the one that i added made it unplayable its rush E

Can you please send me the file of that song?

https://drive.google.com/file/d/1hCIvJIgt4V5vbwffgqcHdmupbSJfwOiy/view here it is

I can't find anything wrong with that song file. Can you give me your logs so I can see if something is wrong in there?

how do i send logs?

They are located at .minecraft\logs\latest.log. On Windows, your .minecraft folder is most commonly found at %appdata%\.minecraft. If you can't figure it out, there are many tutorials on how to find your .minecraft folder.

heres the folder latest log
latest.log

Try this version of disc jockey, I think it should fix your issue.

i waited 15mins and tried but it still said songs loading maybe is there a way i could remove the rush e song?

The problem is not the song, it loads fine. My mod is apparently incompatible with feather client. Please send me your logs again, but I don't think I will put much effort into making my mod work with feather client.

The problem is not the song, it loads fine. My mod is apparently incompatible with feather client. Please send me your logs again, but I don't think I will put much effort into making my mod work with feather client.

well i use feather client and it works perfectly except that one song didn't work, but the file for the song was very big

I will not be adding specific support for feather client. If my mod doesn't work properly on feather client, try it without feather client. If my mod still doesn't work properly, create a new issue.


Multiple config

Hi Edomaru, can I ask your help? Two questions:

in my projects there is an Admin section and a Public Section; they use different menu layout. Can I set two different config file?
Is the active menu feature working fine in latest script version?

Thanks a lot for your feedback

If you have different menu configuration, you can follow this way:
<?php
// for example menu 1
$config["nav_tag_open"]          = '
';
// you can define any configuration

$this->multi_menu->initialize($config);
$menu1 = $this->multi_menu->render();

// for example menu 2
$config["nav_tag_open"]          = '
';
// you can define any configuration

$this->multi_menu->initialize($config);
$menu2 = $this->multi_menu->render();
?>

Or in the simple way you can do this way:
<?php
$config1 = array(
// your configuration
);
echo $this->multi_menu->render($config1);

$config2 = array(
// your configuration
);
echo $this->multi_menu->render($config2);
?>

For the question number two, I say yes. The active menu feature working fine

Hi Edo, thanks a lot for reply.
In my App, I'm using a config file placed into the CI3 config folder; for the second menu (the public one, on main web site) I'm following your info, in details:
Loading the library into the controller: $this->load->library("multi_menu");
Set the config var into the controller
$config["nav_tag_open"]      = '';
$config["nav_tag_close"]     = '';
$config["item_tag_open"]     = ''; // Final menu item
$config["item_tag_close"]    = '';
$config["item_active_class"] = 'active'; // Class of active item
$config["parent_tag_open"]   = '';
$config["parent_anchor_tag"] = '%s';
$config["children_tag_open"] = '';
$config["item_active"]       = 'home';
Render the menu into the view: echo $this->multi_menu->render();
But I got the coinfig setting of the first configuration file
About active menu item, I'm asking because the home active item doesn't appear activated in my menu
Thanks for any feedback/help


chore: Included githubactions in the dependabot config

This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.
Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot
GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool
Signed-off-by: naveen<EMAIL_ADDRESS>

@mraleph These are just for the GitHub actions which only do OSSF scorecards. Dependabot won't touch pubspecs or DEPS. This is good.


Unsupported countries.

Probably, this application can be used in all countries, unlike YouTube music.

Yes, this should support "all" countries because of these advantages:

Musicale is hosted on Deno Deploy, which uses Edge servers located in 35 countries, so you should also get the most close server
It's not "well-known", so maybe no one thought to block it
After loading once, the WebApp will be available offline forever, so if someone blocks the domain, you should be able to access your local copy (just without any update, if there is one)

Anyway, there are limitations:

I'm using the Piped API, instead "well-known", so if it's blocked, you may not use Musicale.
I'm using more Piped instances to grant a better and faster music streaming without any down-time, but search results currently are provided by only the official Piped instance so you could be blocked on searching

P.S.: changing this issue to discussion because just a question.


Connect DDC to explorer polkadot

What is the IPFS feature in explorer used for?
IPFS is a protocol and peer-to-peer network for storing and sharing data in a distributed file system. [explorer.cere.network](http://explorer.cere.network), by default, provides the functionality to store files using the Crust Network ecosystem. In other words, Explorer allows the storage of data in Crust Network for all Substrate-based chains.
FAQ:

Does it connect to our DDC? No, it connects to Crust Network.
Where is the data uploaded via IPFS files hosted? Uploaded files are hosted on [Crust Network](https://crust.network/) using the standard [IPFS W3Auth Pinning Service](https://wiki.crust.network/docs/en/buildIPFSW3AuthPin).
The feature is scheduled for review for update or removal.

https://www.notion.so/cere/FAQ-47632bf4e3ff45ab999e66463d634fbf?pvs=4#6295bde824f545dd97e9d6496aac276f

It was removed a recent version of explorer.


Removed the dependency of swift-json project.

Write the function toJSONLiteral() instead. As we only need the
object to JSON string conversion, we don't need to rely on the
whole project.

@zliang7 PTAL

thanks for the great review, I'll post the PR right away.

@zliang7 updated, PTAL.


Remove bootstrap dependency

Want to make web app look really professional.
Might be able to achieve current results with less code/bloat.
Still floating the idea but I think there are certain things that we definitely don't need bootstrap for and complicates the html/styling logic

Bootstrap was used back when this was made to make the site look professional and simple. It made styling really simple. If we can achieve this and remove bootstrap without too much additional code to manage, that would be great. But if it looks like we are reimplementing bootstrap then we'd have to pass on the PR.
Given how many new CSS style attributes have been added in the past few years since I started this project, I'm certain most of this can be achieved without bootstrap.


ROS2: Support default values for fields

https://docs.ros.org/en/foxy/Concepts/About-ROS-Interfaces.html

Complete in #71


WhenAsync missing CancellationToken

MustAsync takes a CancellationToken, but WhenAsync doesnt.

I've committed a change that adds CancellationToken support to both WhenAsync and UnlessAsync. This will be part of 7.3-beta3.

7.3-beta3 is out with this change. Please give it a try and feel free to re-open the issue if you run into any problems.


perf: parallelize add Query to QueryCollection method

See issue #265

I realized that the bottleneck was not the list appending operation, but the matching between the pdb files and the pssms ones. Indeed I was calling glob.glob operation (to find the correspondent pssms files) for each pdb file. Then for now there is no need to parallelize the add operation.


Update README.md

Wrong Command For Build

Nice catch, thanks!

Welcome 😊
On Mon, 10 Apr 2023, 1:05 am DreyAnd, @.***> wrote:

Nice catch, thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/DreyAnd/WhoDupMe/pull/1#issuecomment-1501198312, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AY3FAWAMLXQ36XAULOTDOQ3XAMFQBANCNFSM6AAAAAAWXQV44I
.
You are receiving this because you authored the thread.Message ID:
@.***>


Remove: Load new posts shadow

Removed the presence of unnatural lines on the Load new posts button on vertical screens.
Before

After

Which phone do you have where this bug is occurring? Please give the OS and the model name.

This got fixed by some other changes -- thanks though!


Maven build fails due to missing javafx dependency

Fresh Linux Mint 18.2 (Ubuntu 16.04) install, with apt install maven followed by mvn package, yields a bunch of lines of output and then
[INFO] Compiling Kotlin sources from [/home/wchargin/git/HNDesktop/src/main/java]
[INFO] Module name is HNDesktop
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (5, 8) Unresolved reference: javafx
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (6, 8) Unresolved reference: javafx
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (7, 8) Unresolved reference: javafx
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (8, 8) Unresolved reference: javafx
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (72, 20) Unresolved reference: JFXPanel
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (223, 13) Unresolved reference: Platform
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (224, 31) Unresolved reference: WebView
[ERROR] /home/wchargin/git/HNDesktop/src/main/java/App.kt: (225, 34) Unresolved reference: Scene

I haven't used JavaFX or Kotlin, but I see that it's not mentioned in the pom.xml anywhere. Perhaps you need to add a dependency?
Maven and Java versions:
$ mvn -version
Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.10.0-32-generic", arch: "amd64", family: "unix"

Hey thanks for pointing this out wchargin! AFAIK JavaFX is generally included as part of the standard library, but maybe there are certain cases where it's not included... In any case, I did find a javafx maven plugin which seems like it could be a solution. If you'd like to try it out, you could pull the latest on the branch javafx-fix and run mvn package again and see what happens.

Are you sure that you pushed? I am "Already up-to-date" on 8d473ab8c9, which is also the latest GitHub commit and was created before your comment. I don't see any other branches on the remote.
Try git push origin javafx-fix?

Haha! Yeah, pushing might be useful—thanks again @wchargin

The commit currently at javafx-fix, ebfacff7f2, does not fix the problem for me. But I suspect that you might not have pushed the right thing, as ebfacff7f2 is the parent commit of 8d473ab8c9, the current master commit.
If your HEAD is at the commit that you think fixes the problem, you can git push origin HEAD:javafx-fix, or git push --force-with-lease origin HEAD:javafx-fix if the preceding command has a "non-fastforward" error.

Oh wow, yep—I was working in another copy of the repo I had cloned in order to test building out. Correct branch should be pushed now.

Cool—I now have what appears to be the correct commit, 1fd7df4d11. Unfortunately, I get the same error as before when running mvn package. I also tried running mvn jfx:jar, which has the same error.
Any other suggestions?

I noticed your mvn -version lists Oracle as the Vendor, but your Java home is point to an Open JDK, which apparently does not come with JavaFX. I found this: https://stackoverflow.com/questions/34243982/why-is-javafx-is-not-included-in-openjdk-8-on-ubuntu-wily-15-10 —which suggests using sudo apt-get install openjfx to patch your jdk.
It may be that you've got to do that, or use an Oracle jdk.

Installing apt install openjfx and re-running mvn package fixed the problem. Thanks!


jp-xcode8-ci don't build

I'm install jp-xcode8-ci branch - pod 'RealmSwift', :git => 'https://github.com/realm/realm-cocoa.git', :branch => 'jp-xcode8-ci', :submodules => true
And this don't help to start project in Xcode 8.
Actual Results

Version of Realm and Tooling
Realm version: 1.0.2
Xcode version: 8 GM
iOS/OSX version: 10 GM
Dependency manager + version: CocoaPods 1.0.1

I'm found resolution - add pod 'Realm', :git => 'https://github.com/realm/realm-cocoa.git', :branch => 'jp-xcode8-ci', :submodules => true

Please don't use that branch, it's only used to troubleshoot our CI integration. Please use master.

master is already support Xcode 8?

yes, though we'll be making API changes this week and making an official Xcode 8 release later this week: https://twitter.com/realm/status/773665903946952704


Jitpack: custom domain for organization

:clipboard: Description
Jitpack.io allows custom domains to be used, but shields.io allows only VCS ones.
It would be nice to add a "custom" or "organization" endpoint to use them (eg: https://img.shields.io/jitpack/v/custom/com.open-meteo/open-meteo-api-kotlin.svg).

This sounds like a reasonable request. Just to flesh out how this would work a bit..
At the moment, if you request https://img.shields.io/jitpack/v/github/jitpack/maven-simple then we call https://jitpack.io/api/builds/com.github.jitpack/maven-simple/latestOk to get the version.
How would your example translate to a JitPack API call?

How would your example translate to a JitPack API call?

You may replace com.github.jitpack with the domain name reverse (io.jitpack); hence:  https://jitpack.io/api/builds/io.jitpack/maven-simple/latestOk

I feel like we've had some past discussions around just requesting the group id (or equivalent) as a free form route parameter instead of trying to do the version control to group id mapping, but my GitHub search skills are failing me. I would much rather we not be in the business of trying to support auto mappings

Yeah it would be nice if we could change this so that the canonical jitpack badge URLs become:

/jitpack/v/com.github.jitpack/maven-simple
/jitpack/v/com.open-meteo/open-meteo-api-kotlin

and then set up redirects so that a request to /jitpack/v/github/jitpack/maven-simple redirects to /jitpack/v/com.github.jitpack/maven-simple. I think the existing redirect we have on this probably prevents us from doing that though: https://github.com/badges/shields/blob/master/services/jitpack/jitpack-version-redirector.service.js . Any other ideas on how we could restructure it?

I think the existing redirect we have on this probably prevents us from doing that though: https://github.com/badges/shields/blob/master/services/jitpack/jitpack-version-redirector.service.js . Any other ideas on how we could restructure it?

I can only think of these possible solutions:
Not-at-all safe
Ditch the /jitpack/v/${user}/${repo} redirect to /jitpack/v/github/${user}/${repo} (terrible idea, imho, as it breaks old badges)
Safest
Implement a new /jitpack/v/any/${group}/${artifact} (or /jitpack/v/custom/${group}/${artifact}?) endpoint

Redirect /jitpack/v/${user}/${repo} to /jitpack/v/any/com.github.${user}/${repo}
Redirect /jitpack/v/${vcs}/${user}/${repo} to /jitpack/v/any/com.${vcs}.${user}/${repo}
/jitpack/v/any/${group}/${artifact} gets data from https://jitpack.io/api/builds/${group}/${artifact}/latestOk

Nicest
Use /jitpack/v/${group}/${artifact}. After the artifact a /{repo} block may be present (see points 1. and 4.)

Does ${group} match github|bitbucket|gitlab|gitee? If so it's a "new-ish" request: redirect to /jitpack/v/com.${group}.${artifact}/${repo} (group is a vcs, artifact is a user name)
Does ${group} start with com.${vcs} (with regex /^com.(github|bitbucket|gitlab|gitee)/.test(group))? If so skip to 5.
Reverse the ${group} to get a ${domain} (like .split('.').reverse().join('.'); com.domain.sub becomes sub.domain.com)
Does git.${domain} DNS redirect to a github repo (no idea how to check this like dig txt)? If not, try as last resort the old /jitpack/v/${user}/${repo} (hence redirect to /jitpack/v/com.github.${group}/${artifact}
Perform the query to https://jitpack.io/api/builds/${group}/${artifact}/latestOk

Please note that points 3. and 4. might not be required, as it's unlikely that a github user has a domain starting with a TLD (it may even be disallowed, as github.com/com.google and similars lead to a blank page; no information about that in the username policies :no_mouth:).

Its all fun games until someone turns up and says "my github username is com.bitbucket.steve"
I think I'm inclined to go with some variation of the 'safe' option. Another variation of that we could do is switch from /jitpack/v to /jitpack/version. It breaks with convention but gives us a 'clean start'. That might be the least worst option.

Its all fun games until someone turns up and says "my github username is com.bitbucket.steve"

I was thinking the same, so I decided to just test it, and the signup page throws the following error:

Username may only contain alphanumeric characters or single hyphens, and cannot begin or end with a hyphen.

We can safely assume that usernames with dots are not allowed to be registered. With that said, I had found some old issues that talked about usernames with dots: probably GitHub disallowed them somewhere in the past, but I didn't find any reference of when it happened, but most importantly if GitHub forced users to change username or simply disabled new ones from signing up with them.

I think I'm inclined to go with some variation of the 'safe' option. Another variation of that we could do is switch from /jitpack/v to /jitpack/version. It breaks with convention but gives us a 'clean start'. That might be the least worst option.

Yep, and it would also mean less risky redirects (no infinite redirect loops or similar bugs)

I have never worked with Angular, so I would prefer if someone else could test this code (I coded a lot with JavaScript, so I know the language itself, but I have never used/setup Angular).
The jitpack-version-redirector.service would become:
export default [
  redirector({
    category: 'version',
    route: {
      base: 'jitpack/v',
      pattern: ':groupId/:artifactId',
    },
    transformPath: ({ groupId, artifactId }) =>
      `/jitpack/version/com.github.${groupId}/${artifactId}`, // this change is recommended (-1 redirect)
    dateAdded: new Date('2022-08-21'),
  }),
  redirector({
    category: 'version',
    route: {
      base: 'jitpack/v',
      pattern: ':vcs(github|bitbucket|gitlab|gitee)/:user/:repo',
    },
    transformPath: ({ vcs, user, repo }) =>
      `/jitpack/version/com.${vcs}.${user}/${repo}`,
    dateAdded: new Date('2022-08-21'),
  }),
]

And the service would become:
// ...
  static route = {
    base: 'jitpack/version',
    pattern: ':groupId/:artifactId'
  }

  static examples = [
    {
      title: 'JitPack',
      namedParams: {
        groupId: 'github',
        artifactId: 'maven-simple',
      },
      staticPreview: renderVersionBadge({ version: 'v1.1' }),
      keywords: ['java', 'maven'],
    },
  ]

  static defaultBadgeData = { label: 'jitpack' }

  async fetch({ groupId, artifactId }) {
    const url = `https://jitpack.io/api/builds/${groupId}/${artifactId}/latestOk`

    return this._requestJson({
      schema,
      url,
      errorMessages: { 401: 'project not found or private' },
    })
  }

  async handle({ groupId, artifactId }) {
    const { version } = await this.fetch({ groupId, artifactId })
    return renderVersionBadge({ version })
  }
}

That looks roughly right to me - certainly a solid basis for a PR. It will be easier to test and review if you submit a PR.
The one thing I'd pick out is in your example, I think groupId: 'github', should be groupId: 'com.github',
Btw, where have you got angular from? We don't use angular in shields, so fortunately that won't be a barrier :)

That looks roughly right to me - certainly a solid basis for a PR. It will be easier to test and review if you submit a PR.

I'll fork the project and make a pull request :+1:

The one thing I'd pick out is in your example, I think groupId: 'github', should be groupId: 'com.github',

Yep, I forgot that I needed to change from the old vcs value to the full groupId: 'com.github.jitpack'. Thank you!

Btw, where have you got angular from? We don't use angular in shields, so fortunately that won't be a barrier :)

Oops, VS code automatically showed the Angular icon, because the file names matches *.service.js lol


Fix bi-weekly community meeting time

Signed-off-by: Mike Ng<EMAIL_ADDRESS>For https://github.com/open-cluster-management-io/community/issues/109

/lgtm


DSC Resource for managing W2K12+ iSCSI VHDs/Targets and Initiators

have created a DSC Resource Module for managing iSCSI Virtual Disks and iSCSI Targets on Windows Server 2012+ as well as connecting iSCSI Initiators to iSCSI Targets on Windows Server 2012+: https://github.com/PlagueHO/ciSCSI
It contains MOF based resources for the following:

ciSCSIVirtualDisk - creates/removes iSCSI Virtual Hard disks.
ciSCSITarget - creates/removed iSCSI Targets using iSCSI Virtual Hard Disks.
ciSCSIInitiator - configured iSCSI Target Portals and manages connections/sessions to iSCSI Targets.

It contains Unit and Integration tests for all resources, using the DSCResource.Test\TestHelper.psm1 functions. However, the integration tests for iSCSI Initiators are currently disabled because although the documentation for MS iSCSI Initiators states that Loopback connections are supported, the documentation doesn't show how and I couldn't get it to work. Loopback is required for Integration tests. I have left the Integration test code there in case someone can find the documentation for iSCSI Loopback and get it working.
Note about tests: Tests require Windows Server 2012 (or above) to pass because required iSCSI Server feature to be installed. Tests pass on AppVeyor because AppVeyor.yml is configured to ensure the iSCSI Server is installed and the iSCSI Initiator service is started before invoking pester.
Would there be interest in moving this module over to the community module library here?
If so, I'd need to convert the resources over from BMD_ to MSFT_ and other updates to the .PSD1,AppVeyor.yml etc before transferring the repo.
Thanks!

Hi @kwirkykat  - This is actually a new module submission - not a proposal. The module is complete. I just haven't converted it over to the MSFT/HQRM model yet. I was waiting to hear back if it was wanted. Is this a module the PowerShell team would be interested in including?
If it is wanted then I'll convert it over to HQRM and following the new guide for submitting it.

@PlagueHO Sure. We would love to have this in the Resource Kit! Just let me know when it's ready to go and I'll add the needs review label

Thanks @kwirkykat.
All ready for review. The full review PR is here:
https://github.com/PlagueHO/iSCSIDsc/pull/16

For comparison or possible merge:
https://github.com/robwi/xiSCSIServer
https://github.com/robwi/xiSCSIInitiator

Cool! Thanks @mgreenit. I'll take a look.

Module submission progess:

[x] 1. Separate public repository created
[x] 2. Review pull request open
[ ] 3. 1st reviewer approved (Katie)
[ ] 4. 2nd reviewer approved
[ ] 5. 3rd reviewer approved
[ ] 6. Tests passing
[ ] 7. Repository transferred
[ ] 8. Module released

I'm going to close this one because the resource will remain maintained by me.


fuzz: add fuzz tests for validateCustomSettingsParameters

Commit Message: add fuzz tests for validateCustomSettingsParameters
Additional Description:

the function Http2::Utility::validateCustomSettingsParameters also had to be moved out of an anonymous namespace and added to a header file
I closed another pull request that had this fix because I mistakenly branched from a non-master branch so the commit history got mangled

Risk Level: Low
Testing: ran for 2 minutes with libfuzzer
Docs Changes: N/A
Release Notes: N/A

/cc @asraa
/cc @AndresGuedez

validateCustomSettingsParameters was just the one you had on the spreadsheet! But initializeAndValidateOptions takes the exact same argument so will I change it to just fuzz that one instead?

Yeah -- sorry about that, I hadn't realized it was private until you mentioned that to me. But since the caller is public and doesn't really add much complexity I'd just opt for that.


Issue fix on accordion collapse behavior

Description
Prop isCollapsed should only be true if the selected index is not the same as the item index.
PR Type

[x] Snippets, Tests & Tags (new snippets, updated snippets, re-tagging of snippets, added/updated tests)
[ ] Tools, Scripts & Automation (anything related to files in the scripts folder, Gatsby, website, Travis CI or Netlify)
[ ] General, Typos, Misc. & Meta (everything related to content, typos, general stuff and meta files in the repository - e.g. the issue template)
[ ] Other (please specifiy in the description above)

Guidelines

[x] I have read the guidelines in the CONTRIBUTING document.

@Chalarangelo @fejes713  sorry, forgot to tag reviewers


[Python] Syntax highlighting for single backticks (code tags)

I noticed some of the challenges, like this one still has some goofy looking highlighting...

We need to change the background of these code tags to white, or maybe a lighter gray? Could just leave it I guess - it's not too bad.

I believe code blocks with triple backticks get a white background if they're in the answer area. code file : challege page
When in the question, it looks like there's some inconsistencies that are probably fine. The picture above has two codeblock sections, one background is the same as the page background, and the other gets that tan.

Good point.  Why don't we make all the backgrounds (inline, multiline, answer and question) white in day mode and dark blue in night mode?  It improves the contrast and consistency.

I tried to differentiate the questions from the answers by making the answers have a white background. So if we don't change that, then codeblocks(inline or multiline) wont have any background in the answers, or they will match anyway. And they will have the background in the questions. I don't think it looks too bad the way it is, but it does seem a little scattered. Hmm.

If we force them to be white everywhere they'll, effectively, have a background in the questions, because the page as a whole is grey.  It looks quite good, I think:

Yea, I like that I think.

So we had a similar situation where we wanted distinguish between the codes and their backgrounds so we went with quaternary background to make styling simple and make sure they stood up from their background.

Styling the code elements similar to regular text will make them less differentiable  when they are used together in the radio buttons.
We also need to consider having pre and code blocks inside radio buttons if that is ever the case, and if we need to have a hover/select styling.
Additionally, since we have recently introduced the radio button components we need to find a better way to make it consistent with the rest of the UI elements' hierarchy.
Following our current conventions> we would go one contrast level down when an element overlaps another element or we want to differentiate it from another element. that being said, following that convention here would lead to the following layout.
Here is what our current UI would look like based on our current design style guide:

Here is what happens if we style codeblocks and pre one contrast level highter.

Here is what happens when we remove the borders (things start to blend it):

I am not in love with any of them, so feedback is appreciated.

I see what you mean about making it clear that the inline text is special.  However, we're (probably) going to run into contrast issues if we stick with the convention of pale background, darker box and even darker text.  If, instead, we go with a slightly darker background to contrast with the white box then it should be obvious that the box is special and we maximise the contrast with the text.
Like this:

and this, with some (possibly too subtle) borders

I think I like Ahmad's second example the best if it weren't for the green and blue text. Even on a white background, that green text is pretty tough. Maybe we should consider looking into changing that highlighting?

All of our color/background combinations are within best practices so backgrounds should be alright as long we make them consistent across learn;
If we decide to go with white we need to lower the saturation on some of the  highlights.
I believe the current prism highlights are optimal for a slightly off white background.
Here is optimal steps to take in my opinion:

Decide on the on the optimal /learn foreground background colors. (consider night/light mode and our theme switching mechanism)
Decide on global code/code block background color.
Adjust syntax highlighting for monaco and code blocks accordingly so they are similar #37166

Thank you for reporting this issue.
This is a standard message notifying you that the issue has become stale, so we are going to close it.
If you think we're wrong in closing this issue, please request for it to be reopened. Thank you and happy coding.


Update machine-learning-r-csharp-multivariate-linear-regression.md

Content refresh #signoff

Hi @jaymathe, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (jaymathe). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@jaymathe : Thanks for your contribution to the Azure documentation! The author, @jaymathe, has been notified to review your proposed change.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It�s easy to access the private repo version of your articles in GitHub. Just add �pr to the URL, as follows:
Public repo URL: https://github.com/Azure/azure-content/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Azure/azure-content-pr/blob/master/articles/azure-portal-overview.md
We've closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions.


Freezes randomly on startup with a libcrypt fatal error

Issue Type: Bug
Visual Studio Code often freezes shortly upon startup with an error message from libgcrypt and then a "detected unresponsive" message seen in the logs, when run in a Flatpak container using org.freedesktop.Sdk/x86_64/19.08 as the runtime.
The following message characterizes the freezy startups:
fatal error in libgcrypt, file ../../src/visibility.c, line 1361, function gcry_create_nonce: called in non-operational state

The container runtime has libgcrypt 1.8.5, and the app filesystem integrates libsecret 0.20.3.
See also investigation in https://github.com/flathub/com.visualstudio.code/issues/159
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:22.494Z)
OS version: Linux x64 5.6.16-300.fc32.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 3436)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 0

Memory (System)
23.15GB (0.63GB free)

Process Argv
--extensions-dir=/home/mzabaluev/.var/app/com.visualstudio.code/data/vscode/extensions --verbose --log debug --no-sandbox

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Extensions (4)

Extension
Author (truncated)
Version

better-toml
bun
0.3.2

autoconf
mae
0.1.0

rust
rus
0.7.8

vscode-lldb
vad
1.5.3

Here is an abridged abrt report that was produced by the crash. I had /usr/bin/wget installed in the sandbox when the crash was reproduced; hopefully the crash report with a backtrace was sent as well.
I could try to analyze the coredump on my own if given instructions on where to get the debugging information from.

Please follow this wiki - https://github.com/microsoft/vscode/wiki/Native-Crash-Issues and provide us necessary information.

Backtrace accordingly to gdb (version Fedora 9.1-5.fc32):
Core was generated by `/app/extra/vscode/code --type=renderer --disable-color-correct-rendering --no-s'.
Program terminated with signal SIGABRT, Aborted.

warning: Unexpected size of section `.reg-xstate/85' in core file.
#0  0x00007fc62aec2605 in ?? ()
[Current thread is 1 (LWP 85)]
(gdb) bt
#0  0x00007fc62aec2605 in ?? ()
#1  0x0000000000000000 in ?? ()

The output of thread apply all bt:
Thread 30 (LWP 82):
warning: Unexpected size of section `.reg-xstate/82' in core file.
#0  0x00007fc62af8774e in ?? ()
#1  0x00005594878b1c53 in ?? ()
#2  0x0000000c00000000 in ?? ()
#3  0x00007fc623586ba8 in ?? ()
#4  0xffffffff00000001 in ?? ()
#5  0x00007fc623586bd0 in ?? ()
#6  0x00005594884fb7c6 in ?? ()
#7  0x00007fc623586bd0 in ?? ()
#8  0x00007fffb6d5ec9e in ?? ()
#9  0x00007fffb6d5ec9f in ?? ()
#10 0x00001c0b1f5b7400 in ?? ()
#11 0x00001c0b1f5b7808 in ?? ()
#12 0x00007fc623587700 in ?? ()
#13 0x00007fc623586bf0 in ?? ()
#14 0x00005594884fb167 in ?? ()
#15 0x0000000000000000 in ?? ()

Thread 29 (LWP 108):
warning: Unexpected size of section `.reg-xstate/108' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000001 in ?? ()
#2  0x00007fc61b3f7670 in ?? ()
#3  0x0000000000000000 in ?? ()

Thread 28 (LWP 84):
warning: Unexpected size of section `.reg-xstate/84' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000118 in ?? ()
#2  0x0000000000000001 in ?? ()
#3  0x0000000000000004 in ?? ()
#4  0x00007fc622584b40 in ?? ()
#5  0x0000000000000231 in ?? ()
#6  0x0000000000000000 in ?? ()

Thread 27 (LWP 71):
warning: Unexpected size of section `.reg-xstate/71' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 26 (LWP 90):
warning: Unexpected size of section `.reg-xstate/90' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 25 (LWP 132):
warning: Unexpected size of section `.reg-xstate/132' in core file.
#0  0x00007fc62af81f2d in ?? ()
#1  0x00007fc62c43ef46 in ?? ()
#2  0x000000000001339a in ?? ()
#3  0x0000000025775ab9 in ?? ()
#4  0x000000000000000e in ?? ()
#5  0x000000003b9ac617 in ?? ()
#6  0x0000000000000000 in ?? ()

Thread 24 (LWP 130):
warning: Unexpected size of section `.reg-xstate/130' in core file.
#0  0x00007fc62af7c8ef in ?? ()
#1  0x00001c0b20a28920 in ?? ()
#2  0x00001c0b20a28920 in ?? ()
#3  0x0000000000000002 in ?? ()
#4  0xffffffff00000001 in ?? ()
#5  0x00001c0b2020d420 in ?? ()
#6  0x00007fc62c3f322e in ?? ()
#7  0x0000000000000000 in ?? ()

Thread 23 (LWP 129):
warning: Unexpected size of section `.reg-xstate/129' in core file.
#0  0x00007fc62af7c8ef in ?? ()
#1  0x00001c0b1fce2940 in ?? ()
#2  0x00001c0b1fce2940 in ?? ()
#3  0x0000000000000001 in ?? ()
#4  0xffffffff00000001 in ?? ()
#5  0x00001c0b2020d000 in ?? ()
#6  0x00007fc62c3f322e in ?? ()
#7  0x0000000000000000 in ?? ()

Thread 22 (LWP 110):
warning: Unexpected size of section `.reg-xstate/110' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 21 (LWP 107):
warning: Unexpected size of section `.reg-xstate/107' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000001 in ?? ()
#2  0x00007fc61bbf8670 in ?? ()
#3  0x0000000000000000 in ?? ()

Thread 20 (LWP 92):
warning: Unexpected size of section `.reg-xstate/92' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x00000000000000e7 in ?? ()
#2  0x00007fc61d4ff670 in ?? ()
#3  0x0000000000000001 in ?? ()
#4  0x0000000000000001 in ?? ()
#5  0x0000000000000004 in ?? ()
#6  0x00007fc61d4ff5d0 in ?? ()
#7  0x0000000000000189 in ?? ()
#8  0x000055948854a31b in ?? ()
#9  0x00007fc62c53ca80 in ?? ()
#10 0x00007fc61d4ff5d0 in ?? ()
#11 0x00007fc61d4ff610 in ?? ()
#12 0x0000000000000000 in ?? ()

Thread 19 (LWP 91):
warning: Unexpected size of section `.reg-xstate/91' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 18 (LWP 89):
warning: Unexpected size of section `.reg-xstate/89' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 17 (LWP 88):
warning: Unexpected size of section `.reg-xstate/88' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 16 (LWP 87):
warning: Unexpected size of section `.reg-xstate/87' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 15 (LWP 86):
warning: Unexpected size of section `.reg-xstate/86' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000119 in ?? ()
#2  0x0000000000000001 in ?? ()
#3  0x0000000000000004 in ?? ()
#4  0x00007fc621582b40 in ?? ()
#5  0x0000000000000233 in ?? ()
#6  0xfffffffffffffff5 in ?? ()
#7  0x00007fc62c53ca80 in ?? ()
#8  0x00007fc621582b40 in ?? ()
#9  0x00001c0b2062e2b8 in ?? ()
#10 0x0000000000000000 in ?? ()

Thread 14 (LWP 83):
warning: Unexpected size of section `.reg-xstate/83' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000117 in ?? ()
#2  0x0000000000000000 in ?? ()

Thread 13 (LWP 81):
warning: Unexpected size of section `.reg-xstate/81' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 12 (LWP 80):
warning: Unexpected size of section `.reg-xstate/80' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000122 in ?? ()
#2  0x0000000000000001 in ?? ()
#3  0x0000000000000004 in ?? ()
#4  0x00007fc6246c8ac0 in ?? ()
#5  0x0000000000000245 in ?? ()
#6  0x00001c0b1f639458 in ?? ()
#7  0x00007fc62c53ca80 in ?? ()
#8  0x00007fc6246c8ac0 in ?? ()
#9  0x00007fc6246c8b60 in ?? ()
#10 0x0000000000000000 in ?? ()

Thread 11 (LWP 79):
warning: Unexpected size of section `.reg-xstate/79' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000121 in ?? ()
#2  0x0000000000000001 in ?? ()
#3  0x0000000000000004 in ?? ()
#4  0x00007fc624ec9ac0 in ?? ()
#5  0x0000000000000243 in ?? ()
#6  0x00001c0b1f639458 in ?? ()
#7  0x00007fc62c53ca80 in ?? ()
#8  0x00007fc624ec9ac0 in ?? ()
#9  0x00007fc624ec9b60 in ?? ()
#10 0x0000000000000000 in ?? ()

Thread 10 (LWP 77):
warning: Unexpected size of section `.reg-xstate/77' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000123 in ?? ()
#2  0x0000000000000001 in ?? ()
#3  0x0000000000000004 in ?? ()
#4  0x00007fc625ecbac0 in ?? ()
#5  0x0000000000000247 in ?? ()
#6  0x00001c0b1f639580 in ?? ()
#7  0x00007fc62c53ca80 in ?? ()
#8  0x00007fc625ecbac0 in ?? ()
#9  0x00007fc625ecbb60 in ?? ()
#10 0x0000000000000000 in ?? ()

Thread 9 (LWP 76):
warning: Unexpected size of section `.reg-xstate/76' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 8 (LWP 186):
warning: Unexpected size of section `.reg-xstate/186' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 7 (LWP 74):
warning: Unexpected size of section `.reg-xstate/74' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 6 (LWP 78):
warning: Unexpected size of section `.reg-xstate/78' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000124 in ?? ()
#2  0x0000000000000000 in ?? ()

Thread 5 (LWP 73):
warning: Unexpected size of section `.reg-xstate/73' in core file.
#0  0x00007fc62c53cd05 in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 4 (LWP 70):
warning: Unexpected size of section `.reg-xstate/70' in core file.
#0  0x00007fc62af8774e in ?? ()
#1  0x00001c0b1f5c8e00 in ?? ()
#2  0x000000141f5c8e00 in ?? ()
#3  0x00001c0b1f5b0480 in ?? ()
#4  0x00200b2000000020 in ?? ()
#5  0x00007fc628ed19b0 in ?? ()
#6  0x000055948a3a0ddb in ?? ()
#7  0x00001c0b1f5c93f8 in ?? ()
#8  0x0000000000000000 in ?? ()

Thread 3 (LWP 72):
warning: Unexpected size of section `.reg-xstate/72' in core file.
#0  0x00007fc62af8774e in ?? ()
#1  0x000055948d98ef40 in v8_Default_embedded_blob_ ()
#2  0x000000178d98ef50 in ?? ()
#3  0x00001c0b1f5b0300 in ?? ()
#4  0xffffffff00000020 in ?? ()
#5  0x00007fc627ecf9d0 in ?? ()
#6  0x000055948a3a0ddb in ?? ()
#7  0x0000000000000000 in ?? ()

Thread 2 (LWP 61):
warning: Unexpected size of section `.reg-xstate/61' in core file.
#0  0x00007fc62c53d03a in ?? ()
#1  0x0000000000000000 in ?? ()

Thread 1 (LWP 85):
#0  0x00007fc62aec2605 in ?? ()
#1  0x0000000000000000 in ?? ()

@sandy081 @deepak1556 :arrow_up:

Please follow this wiki - https://github.com/microsoft/vscode/wiki/Native-Crash-Issues and provide us necessary information.

The only two binaries in the crashy renderer process that call into libgcrypt are libsystemd and libsecret:
$ pldd 61 | tail -n +3 | while read lib; do nm -D $lib | grep -q gcry && echo $lib; done
/usr/lib/x86_64-linux-gnu/libsystemd.so.0
/usr/lib/x86_64-linux-gnu/libgcrypt.so.20
/app/lib/libsecret-1.so.0

From what I can see in the sources of libsecret, it does the right thing.

@deepak1556 No repro with 1.46 so far, but I think I've narrowed it down to a problematic usage in libsystemd: https://github.com/flathub/com.visualstudio.code/issues/159#issuecomment-642368649
If you use libsystemd APIs that pertain to the journal before creating any session with libsecret, this crash may be triggered.

In the parent issue at flathub repo, you have stated that disabling github authentication seems to have mitigated this issue, is that still the case ?

No, I have observed the crashes in 1.45.1 with or without GitHub authentication.

Thanks for narrowing down the issue, without a minidump of the crash its hard to say what is triggering this. You might have a better luck finding the offending call with strace.

A workaround is to call gcry_check_version once before any threads that use either keytar or libsystemd get to run. Accordingly to the manual and my understanding of libgcrypt code, this library can't be safely used from multiple threads in any other way, and libraries using it cannot reliably fix this on their own, as long as there is more than one such library in the process.

@deepak1556 Reproduced with 1.46, here's the output from a minidump reading script.
Please tell me where can I securely upload the entire minidump file.

@mzabaluev please follow the steps below to symbolicate the minidump and attach the final report in this thread. Thanks!

Download minidump-stackwalk and product symbols from https://github.com/deepak1556/minidump-stackwalk-prebuilt/releases/tag/v7.3.1

For stable version vscode use symbols tagged stable

Run the following command to symbolicate
minidump_stackwalk -s <path-to-minidump-file> <path-to-symbols> > stack.txt

@deepak1556 Here's a stack dump obtained accordingly to your instructions.

Thanks! you can add those missing symbols for the system libraries to get a more detailed report, looks like the offending call is made by the node keytar module https://github.com/atom/node-keytar . Maybe you can try creating a minimal example with that module and report it there ?
Looping in @chrmarti for keytar component.

Actually if you can create a minimal example with https://github.com/electron/electron-quick-start and node-keytar can confirm the idea from https://github.com/microsoft/vscode/issues/99725#issuecomment-642230385 , maybe the call to libgcrypt is from chromium and keytar is in race with initiializing libsecret

@deepak1556

you can add those missing symbols for the system libraries to get a more detailed report,

Can minidump_stackwalk get symbols from libraries in a non-system location? I can get the symbols from the org.freedesktop.Platform.Debug runtime and the libraries bundled with the Flatpak app, but these are for the sandbox, not installed in the system.

You will need to use breakpad dump_syms tool to generate the .sym files for the dowloaded system libraries.
For ex: library under /lib/libfoo.so and its debugging symbol is /usr/debug/lib/libfoo.so, run:
dump_syms /lib/libfoo.so /usr/debug/lib > /tmp/libfoo.so.sym
You will then have to arrange this symbol inside the root symbol directory following https://chromium.googlesource.com/breakpad/breakpad/+/master/README.ANDROID#99
I will upload dump_syms shortly.

I have uploaded the dump_syms binary for linux https://github.com/deepak1556/minidump-stackwalk-prebuilt/releases/tag/v7.3.1, let me know if that works. Thanks!

@deepak1556 I can't seem to get any raise out of minidump_stackwalk by providing the symbols.
It can't even see the symbols you have kindly provided:
Loaded modules:
0x5622f3a51000 - 0x5622fa232fff  code  ???  (main)  (WARNING: No symbols, code, 8A04E4BB163B06DD11A9267AFD0BEC3A0)
0x7fa9cfa00000 - 0x7fa9cfa48fff  libsecret-1.so.0.0.0  ???  (WARNING: No symbols, libsecret-1.so.0.0.0, 152D94B2A4DC03BC2B9575C6724E2DCC0)
0x7fa9cfa66000 - 0x7fa9cfa6ffff  keytar.node  ???   This has no effect.

A stack report with library symbols.
It looks as though two keytar threads are racing against each other, but I thought libsecret should survive this. libsystemd appears uninvolved.

Notes on the tools:

dump_syms could help to know to create the symbol directory hierarchy suitable for minidump_stackwalk, so that it was not necessary to rely on "various helper scripts found on the web".
minidump_stackwalk should output a warning when the symbols directory does not exist at the path specified by the parameter, instead of silently producing an uninformative stack dump.

Here is the script I have concocted to extract symbols from Flatpak files:
#!/bin/bash

FLATPAK_HOME=/var/lib/flatpak
RUNTIME_DEBUG_LIBDIR=${FLATPAK_HOME}/runtime/org.freedesktop.Sdk.Debug/x86_64/19.08/active/files/usr/lib/x86_64-linux-gnu
APP_DEBUG_LIBDIR=${FLATPAK_HOME}/runtime/com.visualstudio.code.Debug/x86_64/stable/active/files/lib
SYMBOLS_DIR=symbols

set -eo pipefail

case $1 in
  --runtime ) libdir="$RUNTIME_DEBUG_LIBDIR";;
  --app     ) libdir="$APP_DEBUG_LIBDIR";;
  * )
    echo '--runtime or --app must be specified' >&2
    exit 1
    ;;
esac
lib_name=$2

for lib in "${libdir}/${lib_name}"*; do
  if [ ! -f "$lib" ]; then
    echo "No library named $lib_name in $libdir" >&2
    exit 2
  fi
  soname=$(basename "$lib")
  soname=${soname%.debug}
  dump_syms "$lib" > ${soname}.sym
  checksum=$(head -n 1 ${soname}.sym | cut -d ' ' -f 4)
  lib_symdir="$SYMBOLS_DIR"/$soname/$checksum
  mkdir -p "$lib_symdir"
  mv ${soname}.sym "$lib_symdir"
done

gdb assisted by flatpak-coredumpctl can only decipher the stack of one of the offending threads, but it can see into the C++ symbols of node-keytar:
#17 0x00007fc744d0418a in secret_password_lookup_sync (schema=0x7fc744f40900 <keytar::(anonymous namespace)::schema>, cancellable=0x0, error=0x7fc74d3efb20) at ../libsecret/secret-password.c:884
#18 0x00007fc744d3ead0 in keytar::GetPassword(std::string const&, std::string const&, std::string*, std::string*) () at /app/extra/vscode/resources/app/node_modules.asar.unpacked/keytar/build/Release/keytar.node
#19 0x00007fc744d39b60 in GetPasswordWorker::Execute() () at /app/extra/vscode/resources/app/node_modules.asar.unpacked/keytar/build/Release/keytar.node

Thanks for the feedback in https://github.com/microsoft/vscode/issues/99725#issuecomment-643194105 , I will take those features into consideration when moving to https://github.com/nornagon/electron-minidump
As for the issue at hand, I see that you have filed an issue with libsecret. Great work, thanks!

@deepak1556 Yes, it's an issue of a dynamic library from the platform not living up to its (implied) promise of thread safety. Feel free to close this issue, or use it as a low-priority reminder to update platform requirements once that issue is resolved and a new version is released.

I will leave the issue open to track updates and also to avoid duplicate issues that may open.

Note, though, that the potential for libgcrypt initialization race is still there, between libsecret and libjournald each having its own lazy initialization not synchronized in between each other. In fact, libjournald has no thread synchronization whatsoever: https://github.com/systemd/systemd/issues/16140

Closing as issue is outside VSCode.


Add comment bot, labeller and project manager

Closes: #2574
Signed-off-by: Morgan Davies<EMAIL_ADDRESS>

For me, we can never over-communicate, so I'd be happy to have that information presented twice in rapid order to encourage folks to 'do the right thing'

For me, we can never over-communicate, so I'd be happy to have that information presented twice in rapid order to encourage folks to 'do the right thing'

I agree. Templates are useful but I find that people only really read or use the parts that allow them to populate the template, so having it reinforced in a comment is more assertive. Furthermore, the only notification you would get is at the same time the pull request is created, so you would be getting a notification anyway for the pull request that has been created (the comment gets merged into that same notification) I wouldn't be against adding similar info to the templates too but that's a conversation for another issue I think.

For me, we can never over-communicate, so I'd be happy to have that information presented twice in rapid order to encourage folks to 'do the right thing'

I'm not prepared to block this (which is why I reviewed only as a comment) but I personally consider that if someone has made the effort to "do the right thing" and read our contributing document, follow all the procedures and then gets a large block of MAKE SURE YOU'VE DONE THIS text stuck in front of them that it could be seen as quite insulting, but I do understand that others might not see it that way ...
The comment says "if you have not made a pull request here before" - could we dad in logic to only add it for new contributors to the repo?

So I have similar views, templates are great for people unsure what to do to follow, but can be patronizing to more experienced people who probably know exactly what's needed for what they are raising. I'm guilty when raising some Issues, of the first thing I do to the template is block mark, delete! It just clutters my view of what I want to raise/discuss/create...

so here is a proposal, why don't we show the message to first-time contributors only. We should be able to use the github API to work that out. Other changes in this PR (labelled and project manager) are useful to all users.

so here is a proposal, why don't we show the message to first-time contributors only. We should be able to use the github API to work that out. Other changes in this PR (labelled and project manager) are useful to all users.

That's the proposal I made above - do it for new contributors's first PR to the repo, so I'm 👍🏻 if it can be implemented.

Bear in mind this may be subject the new github rules on actions and new contributors

That's the proposal I made above - do it for new contributors's first PR to the repo, so I'm 👍🏻 if it can be implemented.

This has been done. Please re-review @gdams @sxa


Explicit NEP on Tx Witness

We should be able to mark witness VerificationScript by some "standard script" identifier.
Examples:
PUSH signature / Check signature - Standard Verification 1
PUSH signatures / Check multisig - Standard Verification 2
etc
Some time ago (months), we discussed on a similar situation, with @shargon, and he wisely commented that it wouldn't be interesting to have a NEP to inform things that could not be true... I mean, tx submitter may "lie" about which verification format is. In this case, I propose that nodes verify the format, and reject tx if a specific format is declared, but not followed.
Example:
declare multisig, but perform single sig
Positive points: this allows us to do some optimizations, specially for blockchain explorers, as they will better know witnesses intentions, and clearly indicate that (single sig / multi sig / etc).
This is important for this NEP: https://github.com/neo-project/proposals/issues/102
Negative points: this is an extra byte (if we limit to 255) on all cosigners, unless we manage to keep it optional somehow.

Seems like everyone is just parsing scripts to detect this and (three years down the road!) we still have just two main possibilities, probably it's OK as it is.