The difference between paper and code when generate detailed description

In the paper, the section of "Visual Instruction Correction" says "......this process continues iteratively until a termination symbol is encountered"
But, in the code, there is a "answer_length" variable .it is a constant num e.g. 4 in the config file.
https://github.com/opendatalab/VIGC/blob/main/vigc/tasks/llava_150k_gen.py#L215
So, it is different with paper. it only have 1+4 iterations. The answer is uncompleted
this is the "vigc/projects/mini_gpt4_vicuna13b/generate_qa/llava-150k/generate_llava_qa_detail.yaml"
datasets:
  instruct_blip_coco2017_vig_test: # name of the dataset builder

    filter:
      - llava
    vis_processor:
      eval:
        name: "blip_image_eval"
        image_size: 224
    text_processor:
      eval:
        name: "blip_caption_instruct"
        max_words: 256

run:
  runner: runner_iter
  task: instruct_blip_llava_vig
  answer_length: 4
  llava_task: desc  # desc, comp or conv
  gen_style: vig  # vig or vic

  batch_size_train: 16
  batch_size_eval: 8
  num_workers: 4

  iters_per_inner_epoch: 2000
  max_iters: 60000

  seed: 42
  output_dir: "output/result/minigpt4_13b_llava/detail"

  evaluate: True
  test_splits: [ "eval" ]

  device: "cuda"
  world_size: 1
  dist_url: "env://"
  distributed: True

  generate_cfg:
    max_len: 250
    min_len: 1
    num_beams: 5

So, when use the llava-150k/generate_llava_qa_detail.yaml, it can not generate the same result with VIGC-InstData. Can you share the same config file with VIGC-InstData?

Hi @shipengai , there is a config key named "last_infer_all"(means keep all sentence at last iteration), you can set it to True like this:
run:
  runner: runner_iter
  task: instruct_blip_llava_vig
  answer_length: 4
  last_infer_all: True
  ...

through this way, you can get a completed answer.
by the way, the value of  "last_infer_all" is False by default, you can visit the source code for more details: https://github.com/opendatalab/VIGC/blob/a1aa9f12804a816c285b600c22d4ef8c299199ae/vigc/tasks/llava_150k_gen.py#L105

@wufan-tb Thanks for your reply.But it is still different with the paper that says ".....this process continues iteratively until a termination symbol is encountered""
Is the  VIGC-InstData also use "last_infer_all =True" ?
Another question is about the key named "in_section", how to set it if i want generate the same data with  VIGC-InstData https://opendatalab.com/OpenDataLab/VIGC-InstData

when generated the released VIGC-InstData, we set last_infer_all = True, and in_section = False

@wufan-tb. The result is still different with VIGC-InstData.
for example, {'image_id': 473109, 'image': 'train2017/000000473109.jpg'}
The answer of VIGC-InstData is
The image features a man wearing a blue shirt and a bow tie, looking at the camera with a serious expression. The man has a bald head, and he appears to be in an office setting, as evidenced by the presence of a desk in the background. The man's attire, consisting of a blue shirt and a bow tie, suggests that he may be attending a formal event or working in a professional environment. Overall, the image conveys a sense of professionalism and attention to detail in the man's appearance.
The answer of my result is
The image features a close-up shot of a man wearing a shirt and tie. The man's face is prominently displayed in the center of the image, with the shirt and tie taking up most of the frame. The shirt appears to be blue, and the tie has a polka-dot pattern. The man's facial expression is neutral, and he appears to be looking directly at the camera. The overall composition of the image emphasizes the man's attire, with the shirt and tie taking center stage and the man's face providing a focal point for the viewer's attention.
my config is vigc/projects/mini_gpt4_vicuna7b/generate_qa/llava-150k/generate_llava_qa_detail.yaml
model:
  arch: blip2_vicuna_instruct
  model_type: minigpt4_vicuna7b
  finetuned: "pretained_weights/vigc7b_minigpt4_llava/vigc7b_minigpt4_llava.pth"

datasets:
  instruct_blip_coco2017_vig_test: # name of the dataset builder

    filter:
      - llava
    vis_processor:
      eval:
        name: "blip_image_eval"
        image_size: 224
    text_processor:
      eval:
        name: "blip_caption_instruct"
        max_words: 256

run:
  runner: runner_iter
  task: instruct_blip_llava_vig
  answer_length: 4
  last_infer_all: True
  llava_task: desc  # desc, comp or conv
  gen_style: vig  # vig or vic

  batch_size_train: 16
  batch_size_eval: 1
  num_workers: 4

  iters_per_inner_epoch: 2000
  max_iters: 60000

  seed: 42
  output_dir: "output/result/minigpt4_7b_llava/detail"

  evaluate: True
  test_splits: [ "eval" ]

  device: "cuda"
  world_size: 1
  dist_url: "env://"
  distributed: True

  generate_cfg:
    max_len: 250
    min_len: 1
    num_beams: 5

the config of vigc/configs/models/mini_gpt4_vicuna7b.yaml is
model:
  arch: instruct_vicuna7b
  load_finetuned: True
  load_pretrained: True

  pretrained: "pretained_weights/minigpt4//pretrained_minigpt4_7b_stage1.pth"
  finetuned: "pretained_weights/vigc7b_minigpt4_llava/vigc7b_minigpt4_llava.pth"

  # vit encoder
  image_size: 224
  drop_path_rate: 0
  use_grad_checkpoint: False
  vit_precision: "fp16"
  freeze_vit: True

  # Q-Former
  num_query_token: 32

  # path to Vicuna checkpoint
  llm_model: "pretained_weights/vicuna-7b-v1.1"

  # generation configs
  prompt: ""

preprocess:
    vis_processor:
        train:
          name: "blip2_image_train"
          image_size: 224
        eval:
          name: "blip_image_eval"
          image_size: 224
    text_processor:
        train:
          name: "blip_caption"
        eval:
          name: "blip_caption"

@wufan-tb by the way, I test with demo https://opendatalab.github.io/VIGC/ , the result of minigpt4 is
Question: Can you describe the main features of this image for me?

Answer: The image features a man wearing a blue shirt and a bow tie, looking at the camera with a serious expression. He has a bald head, which adds a unique touch to his overall appearance. The man's choice of attire, including the bow tie, suggests that he might be attending a formal or semi-formal event, such as a wedding, a business meeting, or a social gathering. The man's facial expression and the way he is looking at the camera convey a sense of confidence and professionalism. The bow tie adds a touch of elegance and sophistication to his appearance, making him stand out from the crowd. The man's bald head, on the other hand, might be perceived as unique or distinctive, depending on the context of the event and the individual's personal style.

Overall, the image showcases a well-dressed man with a serious expression, who is likely attending a formal or semi-formal event. The man's choice of attire, including the bow tie, adds a touch of elegance and sophistication to his appearance, while his bald head might be perceived as unique or distinctive, depending on the context of the event and the individual's personal style.

it is normal that laguage model generate tokens with some randomness, it should has no impact on downstream tasks.
our generate configs as follow, you can take it as a reference:
`  task: instruct_blip_llava_viqa
answer_length: 4
last_infer_all: True
llava_task: desc  # desc, comp or conv
gen_style: vqga  # vqga or vqa
batch_size_train: 16
batch_size_eval: 8
num_workers: 4
iters_per_inner_epoch: 2000
max_iters: 60000
seed: 42
output_dir: output/results/vigc7b/minigpt4_vigc7b_stage2_gen_detail
evaluate: True
test_splits: [ "eval" ]
device: "cuda"
world_size: 1
dist_url: "env://"
distributed: True
generate_cfg:
max_len: 250
min_len: 1
num_beams: 5`


Fxing typo from contraindications to contradictions

cc @jdolkowski  @druchniewicz

@sherrif10 It was not a typo, we meant contraindication.


Change the title of background section and/or subsections

Reviewer 1: "Restructuring the background section, or even simply changing the title of the Background section and/or subsections.
The Background section is not just designed to provide the ""background"" knowledge or related work, but to introduce an important motivating example used throughout the article and also present a crucial argument for the article."

fixed in commit a4cb810


Add Simplified Chinese (zh_cn) translation

Co-authored with @duckegg128

Thank you for your contribution! This will be added to a hotfix coming later this weekend.


KAFKA-15357: Aggregate and propagate assignments

A new AssignmentsManager accumulates, batches, and sends assignment
events to the Controller.
Assignments are sent via AssignReplicasToDirs requests.
Part of KIP-858.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cmccabe @pprovenzano this one also builds on KAFKA-15451 (#14368). Please take a look.

Is there a way to trigger the tests again or do I need to push additional changes? All the test pipelines show a Jenkins error: "No space left on device".

LGTM

I don't have a good place to put this comment (github only lets me comment on changed lines) but there is a problem with this code:
  private class LogDirFailureHandler(name: String, haltBrokerOnDirFailure: Boolean) extends ShutdownableThread(name) {
    override def doWork(): Unit = {
      val newOfflineLogDir = logDirFailureChannel.takeNextOfflineLogDir()
      if (haltBrokerOnDirFailure) {
        fatal(s"Halting broker because dir $newOfflineLogDir is offline")
        Exit.halt(1)
      }
      handleLogDirFailure(newOfflineLogDir)
    }
  }

If the directory that failed is the metadata directory, we need to exit unconditionally. This is because we have not implemented any way of failing over to a different directory for metadata.
I suppose we should have a post-3.7 follow-up JIRA for this.

I don't know if we want to do this in this PR, but one thing I would suggest for ReplicaManager is to use the FaultHandler paradigm we have in the QuorumController code.
Specifically, when QuorumController hits an unrecoverable condition it will invoke the FaultHandler. In normal operation this maps to logging an error message and exiting. In unit tests, it maps to an exception, and also setting a flag that will cause any integration test to always fail.
This accomplishes two things:

avoids calling exit(1) in junit tests, which will kill Jenkins dead (even after 3 decades of Java, we don't have the technology to intercept exit() in unit testrs >:( )
allows us to always know if something is going wrong in the unit / integration test.

There can also be non-fatal fault handlers, which tend to make point 2 even more important (since many times throwing an exception or logging an ERROR will not prevent the test from succeeding!)

I agree with @cmccabe regarding passing a reference for AssignmentHandler to ReplicaManager.
Maybe one other note, many integration tests are failing now with the following error
Error applying topics delta in MetadataDelta up to 78: Assignment into unidentified directory: /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14369/tools/data/kafka-2762391009500302231
		at app//kafka.server.ReplicaManager.maybeNotifyPartitionAssignedToDirectory(ReplicaManager.scala:2362)

for example https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14369/11/testReport/junit/kafka.api/PlaintextAdminIntegrationTest/Build___JDK_8_and_Scala_2_12___testElectUncleanLeadersNoop_String__quorum_kraft/

avoids calling exit(1) in junit tests, which will kill Jenkins dead (even after 3 decades of Java, we don't have the technology to intercept exit() in unit testrs >:( )

@cmccabe I'm confused, I thought that was the whole point of kafka.utils.Exit
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/utils/Exit.scala#L21-L24
https://github.com/apache/kafka/blob/00e5803cd3af89011254e734232308618403309d/clients/src/test/java/org/apache/kafka/common/utils/ExitTest.java
The FaultHandler concept in QuorumController seems great, but I'm not sure how it fits here: afaict the fault is always fatal and we can intercept it in tests - what am I missing?

@cmccabe @pprovenzano PTAL

@cmccabe I'm confused, I thought that was the whole point of kafka.utils.Exit https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/utils/Exit.scala#L21-L24 https://github.com/apache/kafka/blob/00e5803cd3af89011254e734232308618403309d/clients/src/test/java/org/apache/kafka/common/utils/ExitTest.java
The FaultHandler concept in QuorumController seems great, but I'm not sure how it fits here: afaict the fault is always fatal and we can intercept it in tests - what am I missing?

Exit has two very big flaws:

it uses static variables, so if you run tests in parallel, you can hit issues.
you have to remember to set it. most tests leave Exit's default behavior intact (which is exiting the process)

Anyway we can talk more about this later. We don't have to convert to using it in this PR.

commited, thanks

It seems that a compilation error was introduced by this PR. From the last "JDK 8 and Scala 2.12" build:
[Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-14369/core/src/test/scala/unit/kafka/server/ReplicaManagerConcurrencyTest.scala:157:36: type mismatch;

 found   : Seq[String] (in scala.collection)

 required: Seq[String] (in scala.collection.immutable)

I've also seen Build / JDK 8 and Scala 2.12 / testAssignmentAggregation() – kafka.server.AssignmentsManagerTest failing consistently in a few builds (example). @soarez Could you please double check this test?

@cmccabe Please check all the Java/Scala versions before merging, this PR clearly broke the Java 8/Scala 2.12 build in multiple ways.


Improve the tensorflow test_read_variable_op test to support tflite 2.6

Removed the placeholder and session
cc @areusch @leandron @Mousius @gromero for reviews
Co-authored-by: Grant Watson<EMAIL_ADDRESS>

After additional check found out that this change is not needed as the failure happens only when executed through the VSCode debugger. When test is executed through the test script () task_python_frontend_cpu.sh it passes.


Return NTSTATUS code list not complete.

IoAcquireRemoveLock can also return 0xc00000bb STATUS_NOT_SUPPORTED in some unusual cases.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93b50201-ea38-2862-1ae4-b72dddf23d4c
Version Independent ID: 72388b48-638a-6729-87cf-a35b2bdb303c
Content: IoAcquireRemoveLock macro (wdm.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdm/nf-wdm-ioacquireremovelock.md
Product: windows-hardware
Technology: wdk-api-reference
GitHub Login: @barrygolden
Microsoft Alias: bagold

Hi MartinCHarvey, thanks for the feedback.  I am not seeing STATUS_NOT_SUPPORTED in the code.
What was the situation in which you received this return value?

Hi Ted,
I’m not surprised. Some of the IRP’s filtering through the driver produced this return code – but, they were of unknown type, and it was in the middle of a busy boot, so I’m suspecting that it’s either a transient start-up condition in a lower level driver, or a race with some entry points being set up. I suppose if it’s not an “official” return code, then you probably don’t have to document it.
MH.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows
From: Ted @.>
Sent: 08 March 2022 17:56
To: @.>
Cc: Martin Christopher @.>; @.>
Subject: Re: [MicrosoftDocs/windows-driver-docs-ddi] Return NTSTATUS code list not complete. (Issue #1269)
Hi MartinCHarvey, thanks for the feedback. I am not seeing STATUS_NOT_SUPPORTED in the code.
What was the situation in which you received this return value?
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windows-driver-docs-ddi/issues/1269#issuecomment-1062049441, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANJKGXG66CYFTER6BEIR7PTU66IEDANCNFSM5PCP27JQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

Ok Martin, appreciate the context.  That sounds entirely plausible to me.  I'll leave it off the page for now then.  Thanks for reporting it!


FigureError : check

Hey,
I saw you have been changing some things around the figure error handling in Foundation. It seems that something doesn't work with the latest LibWiser.

I am getting this error when using ldm-kbh/Scan_Motor5_55_res.dat file with ELETTRA-LTP-JAVA1 setting. I am almost 100% that this is due to an upgrade in LibWiser, since the propagation works normally without figure error and I saw there were some changes recently.
Cheers,
Aljosa

Even after bumping the version, the problem persists

Good,
We ll get it.
Thank you for noticing.
M
Inviato da myMail per Android Mercoledì, 09 Giugno 2021, 04:20PM +02:00 da aljosahafner  @.*** :

Even after bumping the version, the problem persists
—
You are receiving this because you were assigned.
Reply to this email directly,  view it on GitHub , or  unsubscribe .

From the last joint session, it turned that - at a certain point - Aljosa's oasys started working.
We need one more one session to establish what is really going on.
In the meanwhile, the figure error can be manually load via python script, if need be.


Fix library paths and update peer dependency to RN 0.40.0

In RN 0.40.0 iOS native headers have been moved (see https://github.com/facebook/react-native/releases/tag/v0.40.0)
This leads to build errors, that were already highlighted in #6
This PR fixes the paths and bumps RN peer dependency to 0.40.0

Closing as duplicate #13


Connection Pooling

In addition to one connection per email and the bulk mode, when dealing with a high volume of user-driven email-sending tasks, it will be nice for Flask-Mail to maintain a connection pool.

Ability to open/close connections based on the load
Option to keep at least one connection for standby

I'm having the similar issue that my application is having some volume of random emails but the connection seems quite slow. Any workaround for now?

I think this is outside the scope of this extension.


TypeError: Cannot read property 'prototype' of undefined

Hi @wobsoriano thanks for this package!
I am trying to migrate CRA to Vite in Excalidraw and running into issues when migrating tests. We are using jest-canvas-mock and thats how I came across this library when migrating to Vite.
However I am getting 👇🏻 error

In addition when I disable the threads as suggested in the Readme, the tests just hangs and I have to manually terminate.
Could you tell me how can I fix it ?

On further debugging, this is where its thrown from in jest-canvas-mock in prototype.js. The win object doesn't have HTMLCanvasElement hence the error

There is an issue for the same opened in jest-canvas-mock

On further debugging, this is where its thrown from in jest-canvas-mock in prototype.js. The win object doesn't have HTMLCanvasElement hence the error

Hi,
Would you have a gist with the exact steps you followed?
Seems you've patched the code in jest-canvas-mock, then use selective version resolutions?

I have the same problem
I tried the solution above by @jenaicprb , but I use npm so my alternative to yarn's "resolution" was this:
"overrides": {     "vitest-canvas-mock": {       "jest-canvas-mock": "2.4.0"     }   }
but I still get the same error

Latest version uses<EMAIL_ADDRESS>still getting the error?

@wobsoriano the issue seems to be fixed in<EMAIL_ADDRESS>reference - https://github.com/hustcc/jest-canvas-mock/pull/116 , can you release a patch version for vitest-canvas-mock ?

@ad1992 updated to use<EMAIL_ADDRESS>

@ad1992 updated to use<EMAIL_ADDRESS>Let me know if that still works.

A little late here, but yes everything works well so I am closing this.
Thanks @wobsoriano ✨


Consider setting Console.OutputEncoding for dotnet test and friends

There was a change in Windows Terminal 1.17 that causes .NET applications that output Unicode characters to the console to have them garbled, because of the default output encoding. This does not happen in prior versions of Windows Terminal, nor in classic "conhost.exe" console windows.
xUnit.net uses characters which are corrupted now when run on Windows Terminal through dotnet test and friends.
Output from xunit.console.exe:

Output from dotnet test (in Windows Terminal-hosted Powershell):

Output from dotnet test (in conhost-hosted Powershell):

While strictly speaking this isn't a bug in VSTest (or xUnit.net), we opted fixed this in https://github.com/xunit/xunit/commit/c4b6ed0f41bb87aa3a92042bcb4f6bbc4694c12d on our side. I would recommend that you consider doing this as well, so that any output from testing frameworks which is outside of ASCII can be presented properly in Windows Terminal.

Thanks for the tip!

We will need to check with someone using some exotic system (like chinese) to see if everything looks okay and then implement this.


Migrate package-lock.json file to version 2

Reason/Context
Parser-JS requires now Node.js 14 and npm7 or higher.
This means package-lock.json version should be always set to 2.
Description
In order to unify development requirements, I suggest all repositories to stick with that requirements. In order to do that, the following is needed:

Clarify this requirement under Development section on this repository README file.
To update package-lock.json to version 2. This is automatically done when running npm install if the npm version used is 7 or higher.

Related:

https://github.com/asyncapi/.github/issues/177

Hi @smoya
I'm looking into this but my node 14 from nvm comes with npm 6 and npm i -g npm refuses to overwrite current version...
so I will need an spare moment to get it done

Hi @smoya
I'm looking into this but my node 14 from nvm comes with npm 6 and npm i -g npm refuses to overwrite current version... so I will need an spare moment to get it done

I recommend you installing and using NVM; using a newer version like 16 will be as easy as:
nvm install 16
nvm use 16

Then you can run npm install on your project and the package-lock.jsonwill be converted to version2. You can come back to 14by following the same commands replacing16by14`.

after upgrading npm I'm getting this error...
the weird thing is that I could delete package-lock.json and regenerate it to v2, but I don't know why I'm getting this error now...
maybe is just upgrade @semantic-release/commit-analyzer@
$ npm --version
8.19.2

ivan.garcia@H00HCK3 MINGW64 ~/workspace/zenwave/asyncapi-preview (feature/content-assistance)
$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/semantic-release
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@semantic-release/npm
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   3 more (@semantic-release/commit-analyzer, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS><18.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@semantic-release/commit-analyzer
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/semantic-release
npm ERR!   peer<EMAIL_ADDRESS><18.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@semantic-release/commit-analyzer
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\ivan.garcia\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR!      C:\Users\ivan.garcia\AppData\Local\npm-cache\_logs\2022-10-13T19_25_41_552Z-debug-0.log

after upgrading npm I'm getting this error...

Thats weird. I just ran the command and it worked:
❯ npm -v
8.1.2
❯ npm i
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.

added 650 packages, and audited 851 packages in 13s

86 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

I opened a PR in fact: https://github.com/asyncapi/vs-asyncapi-preview/pull/134

This is weirder, because I can also create a new package-lock.json file, but I can not npm i when the lock file was upgraded...
ivan.garcia@H00HCK3 MSYS ~/workspace/zenwave/asyncapi-preview (feature/content-assistance)
$ npm i
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

up to date, audited 852 packages in 9s

86 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

ivan.garcia@H00HCK3 MSYS ~/workspace/zenwave/asyncapi-preview (feature/content-assistance)
$ npm i
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/semantic-release
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@semantic-release/npm
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   3 more (@semantic-release/commit-analyzer, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS><18.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@semantic-release/commit-analyzer
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/semantic-release
npm ERR!   peer<EMAIL_ADDRESS><18.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@semantic-release/commit-analyzer
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\ivan.garcia\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR!      C:\Users\ivan.garcia\AppData\Local\npm-cache\_logs\2022-10-17T15_50_59_536Z-debug-0.log

ivan.garcia@H00HCK3 MSYS ~/workspace/zenwave/asyncapi-preview (feature/content-assistance)
$ npm --version
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
8.11.0

Did you try removing your node_modules directory before npm i? Just in case...

Yes, I just did...
It works if I add --legacy-peer-deps but not otherwise and I tried three different versions: with npm from nvm, npm i -g npm and npm downloaded from zip distribution...
It works for you the second time you run npm i?

It works for you the second time you run npm i?

Yes it does. However, trying with the same version of npm as you (8.11.0), it fails:

❯ npm -v
8.11.0
~/dev/vs-asyncapi-preview master                                                                                6s 18:56:58
❯ npm i
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.

added 650 packages, and audited 851 packages in 9s

86 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
~/dev/vs-asyncapi-preview master !1                                                                                9s 18:57:14
❯ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/semantic-release
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@semantic-release/npm
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   3 more (@semantic-release/commit-analyzer, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS><18.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@semantic-release/commit-analyzer
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/semantic-release
npm ERR!   peer<EMAIL_ADDRESS><18.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@semantic-release/commit-analyzer
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/smoya/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/smoya/.npm/_logs/2022-10-17T16_57_20_962Z-debug-0.log

I tried with different versions as well:
$ ~/workspace/bin/node-v16.18.0-win-x64/npm i --version
8.19.2

I'm starting thinking that the problem is with the semantic-release dependency..

I did upgrade some related packages and indeed, the issue seems to be fixed: https://github.com/asyncapi/vs-asyncapi-preview/pull/134/files

thanks for your help @smoya
I'll wait for @derberg if he wants to review the PR as well..

all good from my side


Improve base migration controller documentation

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues

Other methods currently have the If it is "all", ... comments. I thought my wording was a bit better, not sure about it though. Currently comments are a bit inconsistent. Which option do we stick to?

[x] Fix acceptable parameter types.
[x] Decide on the When equals... vs If it is... wording.

Merged. Thanks!

Glad to be of help!


[Public Catalog] A/B Test: Guided Install & Feature Quickstart Tile start: 11/23

Design Questions

[x] Define hypothesis of test

we believe a more prominent Guided install tile and /or a feature quickstart tile would lead to a higher conversion rate.

[x] A/B test treatment: what is the design for both tests?

see figma design and mockup, note this is still being refined as of 11/11

[x] What are the test requirements and duration?

2 week duration

Acceptance Criteria
Note in order to successfully measure the impact of this test for conversion data or new user sign ups, we'd need to finish #1756 and #1756

[ ] Design AC to be defined when design is finalized for treatments.
[ ] Setup test in split.io
[ ] execute test

Mock Up 🧑🎨
FIGMA

It sounds like @abrunner94 was going to take this 🎫 when the designs are ready

it's possible DevEn will need to create a new component for this treatment.

We are confirming the start time of this experiment still...

just one final AC to finish @abrunner94

Ensure the documentation is updated for Developer site only components.

Once you have a PR for that I'd be happy to review it.


copy to go to help center in contact us if campaign closed

What's this PR do?
In the Contact Us modal, added in some new logic and copy surrounding closed campaigns. If a campaign is closed, we include copy to send the user to the help center. Otherwise, we include a link to the campaign FAQs if there are any (this part is the same as before).
How should this be reviewed?

Go to a closed campaign and make sure the Contact Us box looks like this:

Also make sure the link works.

Make sure the the FAQs still show up/link works on an open campaign with FAQs.

Make sure neither of things things show up for an open campaign with no FAQs.

Relevant tickets
Fixes #6705
Checklist

[ ] Tested on staging.

cc: @namimody , @ngjo (If you want to change the copy on this before we merge, that is not hard, just let me know)

🚢

@namimody Are you ok with that text? Here is the other text I proposed:
Before submitting your question, be sure to check out our in-depth Help Center where we provide a tons of answers to frequently asked questions!
I'm fine with either -- or tweaks to either too! Thanks!

@namimody @ngjo is everyone cool with the text that is in there now or should I switch it to something else before merging?

@katiecrane I'm fine with this, but I think @namimody is at an off-site right now working on data stuff so, not sure how to proceed. @mikefantini review the wording above and confirm if that works here?

Wording update you recommended @ngjo looks good to me cc: @katiecrane.


Add workflows to improve the ease of open source contributions.

Non-exhaustive list of workflows to add:

[ ] golang-ci-lint
[ ] Unit tests
[ ] Integration tests
[ ] codeql analysis
[ ] vulnerability scanner (osv-scanner-action)
[ ] scorecard
[ ] Issue bot explaining the workflow.

When it comes to unit tests we have the github actions that run the unit tests for linux and windows on every PR - is there anything else we'd need there?

I think unit tests are covered, I missed those when initially writing this. Though I think we need to add macOS as a platform to test as well?

Also need to ad

[ ] docstring lint, all public functions and packages need docstrings.

Also need to add

[ ]  docstring lint, all public functions and packages need docstrings.

Hi @another-rex can i pick this one up ?

Sure, my original idea is to configure golangci-lint to perform this lint, but turns out to be harder to enable than expected: https://github.com/golangci/golangci-lint/issues/456

So , then what's your uptake on this ?


When a tab is torn out, content bindings' setter gets called infinitely

Out of the box, I replaced my tab control, which uses an item template for the tabs and content template for each tab's content. Immediately, when I tear the tab out, I was able to see that each property that is being bound to a property on the view model had its setter called infinitely. This is a bigger problem because I have an event fire to do some work each time one of those properties change.

Hi, typically whenever these issues get reported it is because the tab has been put into an existing application, and a bit of rework needs to be done.  Can you stuck a break point in the binding (maybe use PropertyChangedCallback) to try and decipher where it's coming from?  If you can post a test project which illustrates the problem I can try and debug it.

Hi, sorry for the delay, it's been a long week. So, the only thing in the project that touches the setter on these properties is the view, so I'm not sure how to look for the cause. What I'll do (probably tomorrow) is branch my project and drop in your tab control again and then I'll get you that copy. Thanks

Is this an issue still? If so, post a repo please.  Otherwise I'll close.

It is. Sorry, I've been swamped. I will come back to this hopefully this weekend or next. I'll have to find it again and then I'll just point you at the repo and tell you exactly where it is.

I gutted everything and rebuilt the UI and the problem seems to be gone. I don't know what the problem could have been.


docs: Mention #argo-wf-contributors in contributing guide

This is worth mentioning since we are likely miss messages in #argo-contributors channel.

Julie's got some changes upcoming to this in #12359 (c.f. https://github.com/argoproj/argo-workflows/pull/12359#discussion_r1433410150 and the current version with the "Slack" section) as well


fix(versions): update Activiti/activiti-cloud-dependencies versions into develop

UpdateBot pushed maven dependency: org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies to: 7.1.38

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies 7.1.38


GCP unsupported resources

Hello all, I just ran infracost on some stuff of ours, and it appears that the following resources are unsupported right now:
[…]
∙ 9 weren't estimated, report them in https://github.com/infracost/infracost:
  ∙ 3 x google_compute_security_policy
  ∙ 2 x google_cloud_scheduler_job
  ∙ 2 x google_recaptcha_enterprise_key
  ∙ 1 x google_app_engine_application
  ∙ 1 x google_service_networking_connection

Thanks @torbendury, we'll look into adding prices for these. In what order would you prioritize them? If you'd like to work on any of them, we'd be more than happy to help too.

Thanks @torbendury and @proffalken. I've created the following issues to track these resources and will close this issue for now. Please watch these for updates on each service:

https://github.com/infracost/infracost/issues/1356
https://github.com/infracost/infracost/issues/1357
https://github.com/infracost/infracost/issues/1358
https://github.com/infracost/infracost/issues/1359
https://github.com/infracost/infracost/issues/1360 - @torbendury I've tagged you in a comment here since I'm unsure what pricing applies.
https://github.com/infracost/infracost/issues/1361

@proffalken for google_compute_region_ssl_certificate, is this a free resource?

@aliscott that's a good point, and yes, they are free: https://cloud.google.com/load-balancing/docs/ssl-certificates#ssl-certificate-costs


Chapters View adjustments upon import

When importing games/exercises from PGN it would be nice to:

auto scroll to show the newly imported items into view
auto expand the nodes under which the new items were imported e.g. the Games list if games were imported.

Import Chapter - bring chapter into view - DONE
Import Games
Import Exercises


KEL Querying Update

This PR includes:

Add support for querying for a certain sequence number of a KEL for an AID

I don't understand.  The codecov checks are not represent the real code coverage metrics for this PR, reflected on this very page, in the codecov report.

The code coverage actions have actually passed, it is just not represented on this page.  I'm overriding and merging this.


Can't download receipt files from IPFS

When I click on the Receipt of a Vote (icon in end of a Vote row under Votes section in a this Proposal page) I got timeout error.
I tried to see receipts in this proposal but no luck.
To Reproduce

Visit https://snapshot.org/#/daocity.eth/proposal/0xc6596e12ae6391d81d73cbeee16254ebe9592fb2c47ba9bd1c2dd2861ed3c70b
Scroll down to Votes section and click the icon (with a label: "Receipt" when you hover it ) at the end of top row.
Click the Hash next to "Author" label (https://cloudflare-ipfs.com/ipfs/Qmf8vitbUDbE8EDZfXUj3KmUZJNgmA8NumHL2uotwkLEkr)
You will get a Timeout error and not be able to download the file

I got 522 and 524 errors at different times for another hash (https://cloudflare-ipfs.com/ipfs/QmY3L2eT4CfWVY5U3MQ1xzXxmS1Rz851FZAs9XduMQML9K) I tried.
Are these files pinned and stored forever or they are cached for a limited time?
If they are pinned, why I receive timeout, 522 or 524 errors and is there an alternative way to download these files when I receive this error?
Snapshots

update:
I got
ipfs cat /ipfs/Qmf8vitbUDbE8EDZfXUj3KmUZJNgmA8NumHL2uotwkLEkr: failed to get block for Qmf8vitbUDbE8EDZfXUj3KmUZJNgmA8NumHL2uotwkLEkr: promise channel was closed error when I visited this link:
https://cloudflare-ipfs.com/ipfs/Qmf8vitbUDbE8EDZfXUj3KmUZJNgmA8NumHL2uotwkLEkr

Any updates? I tried but couldn't access the file.

Any updates? I tried but couldn't access the file.

@midgerate is working on this and he will make an update here when it's done. Sorry for the delay

@trkaplan The IPFS files will work properly now. Apologies that it too so long to fix it.


URL is malformed

I'm getting a URL is malformed error when I try to configure this plugin for Rider. The URL I've entered is https://jenkins.tools.mycompany.com/ which is is the correct URL for Jenkins on my company's servers and takes me to the Jenkins UI in a browser. I read an old issue similar to this one in your history asking for some detail from the API - here is the result of my call to that URL:
<hudson _class="hudson.model.Hudson">
<nodeDescription>the master Jenkins node</nodeDescription>
<nodeName/>
<primaryView _class="hudson.model.AllView">
<name>all</name>
<url>https://jenkins.tools.mycompany.com/</url>
</primaryView>
<view _class="hudson.model.AllView">
<name>all</name>
<url>https://jenkins.tools.mycompany.com/</url>
</view>
</hudson>

I will lookat this the days

I will lookat this the days

Cheers - anything I can do to help diagnose the problem just let me know. I’m using the current version of Rider and a pretty recent version of Jenkins as it was only set up in December.

Cheers - anything I can do to help diagnose the problem just let me know. I’m using the current version of Rider and a pretty recent version of Jenkins as it was only set up in December.

Could you please try following call:
http://<IP_ADDRESS>:8080/api/json?tree=url,nodeDescription
Curl```curl
curl -v --user name:token http://<IP_ADDRESS>:8080/api/json?tree=url,nodeDescription

Then check the give url please

Could you please try following call:
http://<IP_ADDRESS>:8080/api/json?tree=url,nodeDescription
Curl```curl
curl -v --user name:token http://<IP_ADDRESS>:8080/api/json?tree=url,nodeDescription

Then check the give url please

The output of that URL is
{
_class: "hudson.model.Hudson",
nodeDescription: "the master Jenkins node",
url: "https://jenkins.tools.mycompany.com/"
}

Our Jenkins server is public facing - it's password protected obviously but I could ask my infrastructure team about providing temporary access if necessary. The way I normally authenticate to Jenkins is with my Google account - I wonder if authentication is the source of the problem? I had tried typing my Google credentials in the username/password boxes for the plugin which didn't help. I was initially dubious that it would have anything to do with auth because the message itself it literally telling me the URL is malformed (which it is not) but is it possible that an auth fail would lead to this message, perhaps because the plugin doesn't support federated OAuth providers for auth?

The output of that URL is
{
_class: "hudson.model.Hudson",
nodeDescription: "the master Jenkins node",
url: "https://jenkins.tools.mycompany.com/"
}

Our Jenkins server is public facing - it's password protected obviously but I could ask my infrastructure team about providing temporary access if necessary. The way I normally authenticate to Jenkins is with my Google account - I wonder if authentication is the source of the problem? I had tried typing my Google credentials in the username/password boxes for the plugin which didn't help. I was initially dubious that it would have anything to do with auth because the message itself it literally telling me the URL is malformed (which it is not) but is it possible that an auth fail would lead to this message, perhaps because the plugin doesn't support federated OAuth providers for auth?

I've just spoken to my infrastructure team about this and I hadn't realised that our implementation of Jenkins is hidden behind an Identityware proxy to enable authentication via Google. It works seamlessly in a web browser, but now understanding how it works I'm not surprised that a tool is unable to make a direct request to the API, and I don't think your tool can reasonably be expected to support some random third party authentication proxy, so I'll close this ticket. If you can see an easy way around the problem please do let me know, otherwise apologies for wasting your time ;)

I've just spoken to my infrastructure team about this and I hadn't realised that our implementation of Jenkins is hidden behind an Identityware proxy to enable authentication via Google. It works seamlessly in a web browser, but now understanding how it works I'm not surprised that a tool is unable to make a direct request to the API, and I don't think your tool can reasonably be expected to support some random third party authentication proxy, so I'll close this ticket. If you can see an easy way around the problem please do let me know, otherwise apologies for wasting your time ;)

Ok
Behind proxy or use authentifications we  have  some issues ( like #241)
Maybe we will add some auth providers in next time

Ok
Behind proxy or use authentifications we  have  some issues ( like #241)
Maybe we will add some auth providers in next time

it's password protected obviously but I could ask my infrastructure team about providing temporary access if necessary.
implementation of Jenkins is hidden behind an Identityware proxy to enable authentication via Google
It is possible togrant access to me? Then it could be easier to find a solution

it's password protected obviously but I could ask my infrastructure team about providing temporary access if necessary.
implementation of Jenkins is hidden behind an Identityware proxy to enable authentication via Google
It is possible togrant access to me? Then it could be easier to find a solution


Disable tooltips

Is there any method to disable/remove a tooltip programmatically?
(I've not seen any method in the source code to remove them.)

Hi @valerio-bozzolan
This seems to work: $(".tooltipped").off("mouseenter mouseleave");
Obviously replace .tooltipped with your own (specific) selector.
In case you're in the mood, making a pull request and editing the tooltip.js with a function so that the logic stays within that component will probably be really appreciated (I'm not a maintainer of this library).

Added in 30b2e1d

$('.tooltipped').tooltip('remove');
removal section


Storage Attributes

Add support for Bucket attributes, including:

CORS
logging
versioning
location
website
storage class

Add support for File attributes, including:

cache_control
content_dispostion
content_encoding
content_language
content_type

Add support for File upload validation with MD5 or CRC32c
Add File#public_url
Improve stability and error reporting of Storage ACL helpers

CLA is good. We are both confirmed contributors.


Update the General Stationary Combustion activity with changes from IRC

The General Stationary Combustion activity page work was started before final approval by IRC, so there are some updates that need to  be made to be in line with the regs & the BCIERS reporting fields V2 excel sheet.

[ ] change the activity name to General stationary combustion excluding line tracing in the database
[ ] update the name in the activity schema
[ ] decide if there are places where we've abbreviated it in a way that needs to be more specific to differentiate it from the other GSC activities
[ ] update the name wherever it is used elsewhere (ie: the route page)

I see this ticket is approved but none of the checkboxes are selected. Did these changed get made? Is this fine to close?


Changed branch of Linux kernel mentorship program

4.8_Explain_everything_related_to_Linux_Kernel_Mentorship_Program
Branch-Open source

Description 📜
Corrected the branch to be merged in.
Fixes # <300>

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Open Source

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Issue no #300

Hey @RaghavvGupta Could you please add one image of Linux kernel program in the doc, otherwise its looks good to me, I'll merge that once you done with the changes.

Done! :))

Thanks mate, cheers!🎉✌


feat(router) support for regex URIs

Summary
APIs now accept regex values in their uris property. Any such value that does not respect the reserved character set of RFC 3986 is currently considered a regex.
URI regexes can be useful for use-cases like:

/users/\d+/profile
/version/\d+/users/\S+

APIs with strip_uri = true will correctly strip off the entire matching regex from the request URI.
We also support named (or numbered) groups captures:

/users/(?P<user_id>\d+)/profile
/version/(?P<version>\d+)/users/(?P<user>\S+)

Those URIs, when matched, will make the router return a new table with both a hash and an array part, to be used at the user's convenience:
{ "1", "john", version = "1", user = "john" }

This value is not used by the core as of yet, and will be in a later contribution, and will get attached to the request's ngx.ctx structure for later usage in the plugins, at the user's convenience.
Full changelog

:warning: Breaking change: Kong now requires OpenResty to be compiled with PCRE 7.2+
🎆 APIs now accept uris values with characters outside of the reserved set (only if they are considered valid regexes as per the ngx_lua embedded PCRE interface)
:fireworks: The router now evaluates regex URIs
:fireworks: Improve the performance and maintainability of the router
:fireworks: The router captures matching groups from a regex URI if any
Provide related tests for API schema, router and proxy integration
Slight cleanup of the test suite

Issues resolved
Implement #677

Do we need to consider this:
https://tools.ietf.org/html/rfc3987

Looks good and going to test this next week.
It seems to be most useful with strip_uri = false, as in most cases the upstream most probably would need to have the matching regex parts as well.
A nice feature would to be able to specify which part of the uri should be stripped; complete uri, or up to the first match. In that case it would be possible to strip only a part of the uri and have the matching parts forwarded to your upstream.

So far it seems to be working as expected. The output seems to be somewhat strange when creating an API (and getting the API). See the \\d / in response below:
{    ...,     "uris": [         "/v1/test/\\d /testresource",         "/v1/test/\\d /testresource2",         "/v1/test2/\\d /"     ] }
This was just created with a regex like /v1/test/\d+/testresource.
Secondly, it seems not possible to start your uri with a ^. Is this used by default or not needed? Currently most of our locations start with a ^.

Found another issue: if the URI is not ending with a regex (for example \d+) the API is not found:
"uris": [         "/test/\\d",         "/test2/\\d /resource"     ]
curl http://localhost:8000/test2/123/resource {"message":"no API found with those values"}

@RolphH, Using ^ is possible but not needed as the regexes are compiled in anchored mode (so they are always anchored). I'm not sure if we want to have flexibility in that, and does that flexibility cause problems with url stripping.

Found another issue: if the URI is not ending with a regex (for example \d+) the API is not found:
"uris": [ "/test/\d", "/test2/\d /resource" ]
curl http://localhost:8000/test2/123/resource
{"message":"no API found with those values"}

@RolphH can you check your regex? you defined /test2/\d /resource, perhaps you means /test2/\d+/resource?

So far it seems to be working as expected. The output seems to be somewhat strange when creating an API (and getting the API). See the \d / in response below:
{ ..., "uris": [ "/v1/test/\d /testresource", "/v1/test/\d /testresource2", "/v1/test2/\d /" ] }

This is just a result of the data being JSON encoded (backslashes are escaped). This is expected behavior :)

@p0pr0ck5 cheked, and I added with \d+.
curl -i -X POST --url http://localhost:8001/apis/ --data 'name=testl-api' --data 'uris=/test/\d+/resource' --data 'upstream_url=http://httpbin.org'
HTTP/1.1 201 Created
Date: Mon, 10 Jul 2017 19:45:28 GMT
Content-Type: application/json; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Access-Control-Allow-Origin: *
Server: kong/0.10.3
{"http_if_terminated":false,"id":"aeb5670c-2c7b-473b-b878-0a601c1df86a","retries":5,"preserve_host":false,"created_at":1499715928000,"upstream_connect_timeout":60000,"upstream_url":"http://httpbin.org","upstream_read_timeout":60000,"https_only":false,"upstream_send_timeout":60000,"strip_uri":true,"name":"testl-api","uris":["/test/\d /resource"]}

Hi @RolphH,
You will need to url encode your uris parameter like so if you are sending a body with application/x-www-form-urlencoded, as is the default with curl:
curl -i -X POST --url http://localhost:8001/apis/ --data 'name=testl-api' --data-urlencode 'uris=/test/\d+/resource' --data 'upstream_url=http://httpbin.org'

Either that, or send your body with application/json instead.

Updated with the provided feedback and a couple of other improvements.
@RolphH, it would be of great help if you could try your use-case again (with the proper encoding or MIME type), and let us know your thoughts and whether your use-case is covered. Thanks!

@thibaultcha a quick check shows that it is working as expected. Going to do more tests tomorrow.

@thibaultcha I have tested the feature and with the improvements it works like a charm for our use case. With this, we are able to start using Kong in our environment once 0.11 is released (we will start with this change in our dev environment).
Thank you for this feature.

LGTM besides 2 pending comments

Is there a way to use the captured values in the upsteam url? I tried with $1 like suggested in #677 but didn't work.
Also took a look at the code but couldn't identify if it is possible or not.
If not possible to use directly in the upstream url like a rewrite, can this be done using the rewrite phase of a plugin?
I really need a way to do a rewrite based on regexp. I also tried to set a rewrite directly in the Nginx configuration, but Kong always uses the original url, no matter if I use last or break in the rewrite. (The idea was to rewrite the url and configure only the new one in Kong. Any help will be appreciated.

@wandenberg The Mashape Enterprise subscription has an updated version of the request-transformer plugin that allows for substituting such captured groups directly in the upstream_url value, like so: config.replace.uri=/users/$(uri_captures.user2)/foo. See our Enterprise Subscription page for more information.
Otherwise, those values are exposed in the Lua land via the ngx.ctx.router_matches value for plugins consumption.

Thanks for the quick response @thibaultcha I will take a look on it.


Refactor Integrations class to rely on CatalogReader

Description
As part of continuing work on enabling remote catalogs, more refactoring for existing code is being done. In particular, we're introducing the concept of a CatalogReader which can be freely swapped out to enable new input sources, such as a URL or a zip file.
The main conversion for the Integrations class is done, but before this PR is ready, there is still some rippling changes to apply, and more tests need updating. In particular, with the introduction of a Result type in #943, the error handling code is being refactored considerably. This PR is just opened early to get an initial look.
Ready for review.
Issues Resolved
N/A
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented.

[x] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

After talking with Peter a bit about potential directions for building on the architecture of this, I've worked out some next steps to maybe work out both comments, will see about getting this PR ready in the next couple days with some corresponding issues for further architecture work.


Support Ubuntu 20.04

Pull Request (PR) description

Add support for Ubuntu 20.04.  Had to force virtualenv to not use distribute otherwise produces errors.  Also updated virtualenv tests to consistently use Python 3 since first set of tests did this but subsequent tests did not and that broke some OS acceptance tests.
This Pull Request (PR) fixes the following issues

Replaces #576

Looks like the Ubuntu 20.02 & Puppet 5 acceptance failure was networking issues boostrapping the beaker nodeset.  Will need to be rerun.

Ubuntu 29 + puppet 5 is expected to fail because puppet does not provide packages fro them :(

Looks like majority of tests are failing virtualenv with this error:
       	Notice: /Stage[main]/Main/Python::Virtualenv[venv]/Exec[python_virtualenv_/opt/venv6]/returns:     AttributeError: module 'importlib._bootstrap' has no attribute 'SourceFileLoader'

After much googling at least with Ubuntu 20.04 the online solutions did not work.  The only way around it was not trying to install distribute pip package so forcing distribute => false for python::virtualenv.  I'm wondering if that should become the new default because majority of OSes with Python 3 seem to not work with distribute => true.

@bastelfreak I am not real familiar with how voxpupuli modulesync sets up setfiles for acceptance, my exclude didn't seem to take.   I think the hash used to define matrix causes issues with being able to exclude elements

we havn't figured out yet how to exclude sets :(

@crazymind1337 can you take a look as well?

@treydock can you rebase against master to get rid of the merge commit?

@bastelfreak I had done a merge to get in the virtualenv unit tests which needed to be adjusted for this pull request. Looks to have resolved the conflicts.

While testing on Ubuntu 20.04 I get this result: Notice: /Stage[main]/Python::Install/Package[python]/ensure: created Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install python-pip' returned 100: Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package python-pip Error: /Stage[main]/Python::Install/Package[pip]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install python-pip' returned 100: Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package python-pip

Tested on latest ubuntu:20.04 docker container. Works for me!

@treydock You still have to fix the Commit messages. It looks like there is something wrong.

@treydock You still have to fix the Commit messages. It looks like there is something wrong.

Nevermind. I will squash it.


do not allow to remove infra container

Infra container is special, sandbox won't work well
without infra container. If user really want to remove
it, they should remove sanbox instead.
this also fix a panic due to c.state is nil.
1, remove infra container
2, ocic ctr create
or
1, remove infra container
2, restart ocid
3, ocic ctr list
Signed-off-by: Gao feng<EMAIL_ADDRESS>panic on ctr list
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x605606]
goroutine 12 [running]:
github.com/kubernetes-incubator/cri-o/oci.(*History).Less(0xc820011660, 0x1, 0x0, 0xb43390)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/oci/history.go:23 +0x296
sort.insertionSort(0x7f3d4e687c80, 0xc820011660, 0x0, 0x2)
/usr/lib/golang/src/sort/sort.go:32 +0x6f
sort.quickSort(0x7f3d4e687c80, 0xc820011660, 0x0, 0x2, 0x4)
/usr/lib/golang/src/sort/sort.go:184 +0x153
sort.Sort(0x7f3d4e687c80, 0xc820011660)
/usr/lib/golang/src/sort/sort.go:199 +0x74
github.com/kubernetes-incubator/cri-o/oci.(*History).sort(0xc820011660)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/oci/history.go:34 +0x48
github.com/kubernetes-incubator/cri-o/oci.(*memoryStore).List(0xc82034ffe0, 0x0, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/oci/memory_store.go:45 +0x95
github.com/kubernetes-incubator/cri-o/server.(*Server).ListContainers(0xc82012f860, 0x7f3d4c5ff418, 0xc8201448a0, 0xc820011600, 0x0, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/server/container.go:436 +0x99
k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime._RuntimeService_ListContainers_Handler(0xb026c0, 0xc82012f860, 0x7f3d4c5ff418, 0xc8201448a0, 0xc820017590, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime/api.pb.go:2846 +0x168
google.golang.org/grpc.(*Server).processUnaryRPC(0xc82037e5a0, 0x7f3d4c5ff210, 0xc82001a990, 0xc8204d2000, 0xc820385d10, 0x10544f0, 0xc820144870, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:608 +0x10e1
google.golang.org/grpc.(*Server).handleStream(0xc82037e5a0, 0x7f3d4c5ff210, 0xc82001a990, 0xc8204d2000, 0xc820144870)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:766 +0x10a0
google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc82013c6c0, 0xc82037e5a0, 0x7f3d4c5ff210, 0xc82001a990, 0xc8204d2000)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:419 +0xa0
created by google.golang.org/grpc.(*Server).serveStreams.func1
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:420 +0x9a
panic on ctr create
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x6089fc]
goroutine 43 [running]:
github.com/kubernetes-incubator/cri-o/oci.(*Runtime).ContainerStatus(0xc820361700, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/oci/oci.go:214 +0x9c
github.com/kubernetes-incubator/cri-o/server.(*Server).createSandboxContainer(0xc8201492b0, 0xc8204b7880, 0x40, 0xc82048f530, 0x29, 0xc8202fff80, 0x0, 0xc8202efc80, 0x59, 0xc82019e540, ...)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/server/container.go:295 +0x2493
github.com/kubernetes-incubator/cri-o/server.(*Server).CreateContainer(0xc8201492b0, 0x7f5ae283fc70, 0xc82048ee40, 0xc82048eea0, 0x0, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/github.com/kubernetes-incubator/cri-o/server/container.go:113 +0xba2
k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime._RuntimeService_CreateContainer_Handler(0xb02260, 0xc8201492b0, 0x7f5ae283fc70, 0xc82048ee40, 0xc8204b4410, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime/api.pb.go:2774 +0x168
google.golang.org/grpc.(*Server).processUnaryRPC(0xc82038c5a0, 0x7f5ae283fa68, 0xc82001a7e0, 0xc82026ae10, 0xc82048e060, 0x1053490, 0xc82048ee10, 0x0, 0x0)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:608 +0x10e1
google.golang.org/grpc.(*Server).handleStream(0xc82038c5a0, 0x7f5ae283fa68, 0xc82001a7e0, 0xc82026ae10, 0xc82048ee10)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:766 +0x10a0
google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc820145000, 0xc82038c5a0, 0x7f5ae283fa68, 0xc82001a7e0, 0xc82026ae10)
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:419 +0xa0
created by google.golang.org/grpc.(*Server).serveStreams.func1
/home/gaofeng/go/src/github.com/kubernetes-incubator/cri-o/vendor/src/google.golang.org/grpc/server.go:420 +0x9a

Would be nice to have an integration test covering those scenarios.
Also, you need to sign the CLA

@gao-feng This seems reasonable. Thanks! Please add a test case and sign the CLA as @runcom suggested.

@gao-feng Okay, CLA seems to have resolved :) Can you add a test case?

@mrunalp @runcom removeing infra container case is already existed in cleanup_ctrs, with this pr. cleanup_ctrs will fail if there are some infra containers, and if infra container is stopped, the stop sandbox will fail too since the netns path in netPlugin.TearDownPod is /proc/0/ns/net.
Should we prevent infra container from being stopped by user too?
and is there a way to know if container is infra container through the ocic?
I would like to skip stop&remove infra containers in cleanup_ctrs and add an separate test case for stopping and removing infra container.
Any opinion?

@gao-feng if ocic pod status is READY, it implies that the pod infra container is running. Also, based on my testing with kubelet today, we don't want to return the pod infra container as part of container pod list. kubelet doesn't expect to see it.

@mrunalp Maybe we should tag the infra container with an annotation to make it clear that it's an infra container? And then we can filter it out when we return stuff? Personally I was also surprised that you can see infra containers in ocic ctr list since it's not a "container in the pod" in the traditional sense.

@cyphar Do we decided not to show infra container to users? Personally I don't think it is needed, otherwise we need to deal with this special case in every operation. Leaving it as it is just like is OK (just think about docker runtime, it's name will imply its a infra container).
If it get killed accidentally, kubelet should be able to re-create it.

@resouer My suggestion was in response to this:

Also, based on my testing with kubelet today, we don't want to return the pod infra container as part of container pod list. kubelet doesn't expect to see it.

Please note that ocic is not going to be used by users. It will be used by us to debug issues. The kubelet is going to be the main client for ocid.

@cyphar Yes, we will have to filter out the infra container altogether because kubelet didn't start it so it actively keeps on trying to kill it. I will fix that up.

@cyphar I see, so just ignore my comment and focus on this PR, thank you .

@mrunalp please check https://github.com/kubernetes-incubator/cri-o/pull/176

We can close this now with #176 merged.


request: allow JSON Pretty Print for output

Currently, there's no ability in Http/Response/Format/Json.php to provide configuration to json_encode:
Current:
protected function encode($content)
{
    return json_encode($content);
}

I'd like the ability to pass in the options flag to format it, such as JSON_PRETTY_PRINT :
http://php.net/manual/en/function.json-encode.php
protected function encode($content)
{
   if ( $someConfig['json_format'] ) {
      $options = $someConfig['json_format'];
   } else {
      $options = 0;
   }
   return json_encode($content, $options);
}

@davecarlson Can't say this will make it into version 1.0.0, but something I'll look into and see if it makes sense.

If it's just for the pretty print option just install a Chrome extension to do it for you.
If you need other options it's something that can be looked at. For now, if you really need this, just overwrite the existing JSON formatter with your own custom one.
https://github.com/dingo/api/wiki/Responses#custom-response-formats

We currently use:
JSON_FORCE_OBJECT
JSON_PRETTY_PRINT
JSON_PRESERVE_ZERO_FRACTION
JSON_ERROR_SYNTAX
I simply use pretty print as an example as i though it would be the most useful for other people :)


Connection killed with client certificate

Problem Description
we trying to use client certificate (.pem) and receiving
Server TLS handshake failed. Certificate verify failed: unable to get local issuer certificate
We saw similiar issue and workaround suggestion https://github.com/mitmproxy/mitmproxy/issues/5019#issuecomment-1004168018 which almost works.
the above hook fixed the Certificate issue, but then it leads to httpFlow.error 'Client Disconnect'

Steps to reproduce the behavior:

using client certificate (pem file)

System Information
Mitmproxy: 7.0.4 binary
Python: 3.9.7
OpenSSL: OpenSSL 1.1.1l 24 Aug 2021
Platform: macOS-10.15.7-x86_64-i386-64bit

See #5094.
To put it very nicely, please don't post twice.


Support for Rails < 6?

I tried upgrading a Rails 5.2.2 project to jquery-tablesorter 1.27.0 and got:
Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    jquery-tablesorter (~> 1.27.0) was resolved to 1.27.0, which depends on
      railties (>= 3.2, ~> 6.0.0)

    rails (~> 5.2.2) was resolved to 5.2.3.rc1, which depends on
      railties (= 5.2.3.rc1)

Is this only going to be supported for Rails 6 moving forward? If so that should probably be documented.

Oh snap, I'll try to look into this soon, thanks for the report. It was intended to keep working with Rails 5.

Please test the current version 1.27.1.


feat(console): limited actions

Closes #3144

users without features changing rights (e.g. org owners) must not be able change the dropdown(s):

and can we somehow mark inactive actions in flows?

disabled the inputs for users without permission and added the action state right to the name


install on windows

First of all i thank the author for the script, it works just fine, saved my time.
I had some problems with installing the script on windows & i decided to describe the workaround here in hope it helps same lamers as me.

The author didn't mention that python 2 version should be used to run the script. I don't know if py 3 was supposed to be supported but it wasn't for me. I have both 2 & 3 py versions installed so i had to use py «-2» option.

The author didn't mention that ez_setup should be installed first. Not a big deal but a short line in readme could save some time:
py -2 -m pip install ez_setup

pip doesn't want to install the script because since some time it doesn't allow unsafe simple http urls (https only). btw if the author is still alive, he could fix it i guess. Maybe i also could but i don't wanna touch the working code as i'm not so deep into py. The workaround here for me was to use easy_install:
py -2 -m easy_install srt-shift
If it can't recognize the srt-shift by itself (somehow I had this problem), u can try to specify the github archive location:
py -2 -m easy_install https://github.com/adeel/srt-shift/archive/master.zip

And at the finish line the script running also wasn't too simple. I also had to use the py version prefix as i mentioned before plus py peremptorily didn't want to find the installed srt-shift module despite pip showed it by the -list option. It was only luck that I discovered to use the underscore instead of dash:
py -2 -m srt_shift in.srt 5 > out.srt

Thanks!  When the script was written, pip and python 3 were not around yet.  I should update it but I don't know when I'll get around to it.

Also, this exists now and is much better: https://github.com/smacke/subsync


Pass along eppid to the PCK caching service

Enables the caching service to perform on demand registration by supplying EPPID when getting certs
Default the collateral version to V1 if it is not specified in the environment variable
Replace some hardcoded strings in the installer with variables

LGTM, please feel free to merge in once you have perform all appropriate testing.


Unable to load kprobe probe - Ubuntu 18.04

I am receiving a ParseError(Reloc) error when attempting to load the below BPF program:
thread 'main' panicked at 'error loading probe: ParseError(Reloc)', src/main.rs:27:49

The program in question:
#![no_std]
#![no_main]
use cty::*;

// use one of the preludes
use redbpf_probes::kprobe::prelude::*;
//use redbpf_probes::xdp::prelude::*;
//use redbpf_probes::socket_filter::prelude::*;

// Use the types you're going to share with userspace, eg:
use probe::execsnoop::SomeEvent;

program!(0xFFFFFFFE, "GPL");

// The maps and probe functions go here, eg:
//
#[map("syscall_events")]
static mut syscall_events: HashMap<u8, SomeEvent> = HashMap::with_max_entries(1024);

#[kprobe("__x64_sys_open")]
fn syscall_enter(regs: Registers) {
  let pid_tgid = bpf_get_current_pid_tgid();

  let event = SomeEvent {
    pid: pid_tgid >> 32,
  };
  unsafe { syscall_events.set(&0, &event) };
}

Here are the relocations in the program:
llvm-readelf -r probe/target/bpf/programs/execsnoop/execsnoop.elf

Relocation section '.relkprobe/__x64_sys_open' at offset 0x4690 contains 2 entries:
    Offset             Info             Type               Symbol's Value  Symbol's Name
0000000000000028  0000003a00000001 R_BPF_64_64<PHONE_NUMBER>000000 syscall_events
0000000000000038<PHONE_NUMBER>000001 R_BPF_64_64<PHONE_NUMBER>000000 .rodata

Am I doing something incorrectly with the map attribute?

It looks like this relocation is the issue:
Relocation section '.relkprobe/__x64_sys_open' at offset 0x4690 contains 2 entries:
...
0000000000000038<PHONE_NUMBER>000001 R_BPF_64_64<PHONE_NUMBER>000000 .rodata

Other probes do not contain an .rodata relocation

This is a known issue that seems to have started happening with LLVM10. If you make it
let key = 0;
unsafe { syscall_events.set(&key, &event); }

I think it will work.

I tried something similar and that fixed it :) thanks!


Problem History

First draft of the Problem History which is integrated into the ProgressHandler.
@schweikart If you have ideas on how this feature should look on the website, let me know.

I added cookies to persist the history over sessions. I hope that this is a good way to do it.
Two more things I thought about:

There could be a delete button for every history entry and a clear all button for the whole history.
I added a way to load solutions instead of solving them another time when the same problem is inside the history. This should probably be changed to be server-side instead. Distinguishing between GET /solution and POST /solve shouldn't be a thing we do here. The server can check if something was already computed once much better than we do here. POST /solve could get a shortcut to return an existing solution to the problem you're trying to solve.

@schweikart I replaced the cookie approach with localstorage and removed the additional dependency

While testing it, clicking on a previous state threw the following error to the console
Access to fetch at 'http://localhost:8080/solution/sat?id=22' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Can you fix this?

Rebased onto develop, as I have caused the conflicts with my formatting PR and merged the dependency PR


Update README.md

Updated the name and affiliation.

Zhanni's affiliation is already on the main README.md file


Specify PyPy versions in Travis build matrix

Attempts to fix the travis build and specify the versions of PyPy to be used.

Hmm, seems this has more to do with travis itself, https://travis-ci.community/t/travis-python-archive-download-is-flaky/2147.

Documentation states "pypy3.5" is still what's supported, let's keep it at that for now.


Created new flag --notifications-output-file to specify where to output notifications

What type of PR is this?

/kind feature
What this PR does / why we need it:
This PR adds a new flag called --notifications-output-file to specify where to output notifications. If the flag is not present, then notifications are send to stdout.
Which issue(s) this PR fixes:

This pull request addresses part of the issue described in #131
Does this PR introduce a user-facing change?:

Added flag `--notifications-output-file`.

/cc @mlavacca @LiorLieberman

/ok-to-test


Map - add forward backward step buttons to easy timeslider - add date pickers too (animation on the cheap)

As per title.
It's not trivial, however, because of the issue below. The Brush component will need to be controlled/controllable. If/when it's controllable, we can add date pickers (date inputs) in the expanded version of the component to allowed precise settting of the window.
After a lot of back and forth between controlled and uncontrolled behaviour of the visx Brush sub-component of the time-slider, we decided to leave it uncontroled.  The main problem was with a drift/offset being introduced in the "round trip" between appState and component state as described in this comment:
https://github.com/VEuPathDB/web-monorepo/blob/a942e926e2c91980d08c94098cd954a834ef4ab6/packages/libs/components/src/components/plotControls/TimeSlider.tsx#L159-L162

UPDATE: we can hopefully control the brush directly using the innerRef tricks mentioned here https://github.com/airbnb/visx/pull/934 and in this sandbox: https://codesandbox.io/s/github/airbnb/visx/tree/master/packages/visx-demo/src/sandboxes/visx-brush?file=/Example.tsx:4287-4295
It's still a medium cost ticket but at least this part should be straightforward.

Has this been discussed in a ux meeting? Just wondering what sort of consensus we have.

@bobular As a part of this ticket, I have extensively investigated the drift/offset issue. In summary, I found that somehow there exist additional 2 pixels in the first and last bounds: for whatever reason Brush results in adding (-2) pixel in the first bound and (+2) pixel in the last bound. This can be checked via x0 and x1 at onBrushChange function (https://github.com/VEuPathDB/web-monorepo/blob/a942e926e2c91980d08c94098cd954a834ef4ab6/packages/libs/components/src/components/plotControls/TimeSlider.tsx#L98) when selecting full range: technically it should be [0, 700] pixels in the current timeSlider configuration (for full range) but it actually has the range of [-2, 702] pixels (more exactly [-1.999999999,<PHONE_NUMBER>9]).
Thus, I think that we need to consider this inherent drift when changing range at onBrushChange. For example,
a) compute inherent domain value (drift) from range (pixel) using d3.invert() function, e.g., const drift = xBrushScale.invert(2)
b) in the onBrushChange(), compensate x0 and x1 (current domain values) with the above drift before calculating startDate/endDate, e.g., [x0+drift, x1-drift]

Hi @moontrip  - did you see my comment above https://github.com/VEuPathDB/web-monorepo/issues/775#issuecomment-1969154262 ?
I think we can control the brush without fudge factors? It's a while since I looked at this though.

@bobular I didn't see that carefully now (but saw that before) as I just focused on the drift issue. I am not quite sure if that updateBrush works better than the current approach: I saw a developer's comment that it is not for fully controlled brush and it is not done yet. The updateBrush approach existed before when I used Reset button: Brush example code used it that way to reset range. Anyway I feel that we would still need to offset the drift either way because the Brush itself seems to have such an inherent drift.

Ah, I see.
I thought the drift arose from the round-trip of setting the brush position from our props, and then reading the brush position back from the visx component, or something. This would be avoided if the component was fully controlled. I'll have to look at it in more detail.

@bobular From my observation, it is not a kind of numerical error as I can see drift at initial condition: well the term drift may not be appropriate as it looks like Brush just adds additional 2 pixels at start and end (for Brush handle or bound edges? IDK).

Not sure if either of you have looked at this, but it could account for the offset: https://airbnb.io/visx/docs/brush#Brush_brushRegion. I'm not sure what value we're using, but might be worth playing with it.

It looks like the option is just to choose what will be filtered via Brush, e.g., chart, xAxis, or yAxis, not range: default value is chart. The Brush is originally intended to use Visx Chart together but we use it as a UI only.

This part of the description caught my eye:

This part of the description caught my eye:

[...] used for margin subtraction

@dmfalke Yeah it's indeed confusing 😅

@bobular I have tested to consider the inherent(?) offset of 2 pixels as I mentioned earlier. For the example of the Geolocation visualizations of field-based studies and time slider's variable of 'species collection start date', such a 2 pixel results in about 4 months, because the data ranges widely (from 1907 to 2024). I made a draft PR just in case: https://github.com/VEuPathDB/web-monorepo/pull/1076/files

Hi @moontrip
I was reading through the Brush code today for #1075 and it's definitely inherent in the code...
https://github.com/airbnb/visx/blob/86a851cb3bf622b013b186f02f955bcd6548a87f/packages/visx-brush/src/Brush.tsx#L14
I've tested your PR but will comment over there. Thanks!

So - after #1076 there is probably no need to use the updateBrush approach via the innerRef. Yay :tada:


Platform incongruities in State.Connecting & State.Buffering events

According to RNTP docs we have two states for player loading: State.Connecting & State.Buffering:

State.Connecting indicates that the player is currently buffering (in "play" state)
State.Buffering indicates that the player is currently buffering (in "pause" state)

The Android implementation follows this spec. When the audio is set to play when ready, it emits the State.Buffering event, when it is set to not play when ready, it emits the State.Connecting event during loading / buffering.
On iOS however we get both events no matter the playWhenReady state of the player. State.Connecting is emitted during the initial load phase where the player is looking for a 'playable' key (some kind of magic key in the initial bits) in the resource. After this has found to be successful, the loading process is passed on to AVPlayer, which leads to the State.Buffering event.
What to do with this incongruity?

We force iOS to follow Android & the docs.
We change Android to always emit an initial State.Connecting event when starting to load an item.

(I tend to find the distinction between State.Connecting and State.Buffering events being dependent on the playWhenReady state a little confusing.)

This is fixed in https://github.com/doublesymmetry/react-native-track-player/pull/1713

Implement State.Loading which denotes the initial loading phase of a track and deprecate State.Connecting
State.Buffering is emitted whenever the player is buffering data, no matter whether playback is paused or not

Resolved by https://github.com/doublesymmetry/react-native-track-player/pull/1713


Create support new operator guidance to WIKI

We have support new operator guidance in private wiki, but we should have one public here.
cc @wschin @justinchuby

https://github.com/microsoft/onnxscript/wiki/TorchLib-function-authoring-guide

@justinchuby @fatcat-z @xiaowuhu  feel free to add/modify the page


Requesting vertical/horizontal split layout widget

I came across flutter devtools project, @DaveShuckerow did
implement split widget that looks like Qsplitter provided by QT

CC @tvolkert


Add PT-BR (Brazilian Portuguese) translation

This is my proposed PT-BR translation for the theme. Theme users can set the site language to pt-br and the theme should show Braziliam Portuguese default texts.

@lgfischer thanks for PR, though I do not speak Portuguese and will trust that PR/file is correct without any testing.

Thanks @Pilskalns! I'm a native portuguese speaker, and I'm sure the translation is pretty good :)


libzeep is not able to build

Following building instruction,
first libzeep is required,
with cmake version 3.26.3 and c++ (conda-forge gcc 12.2.0-19) 12.2.0
I got following errors,
cmake .. -DZEEP_BUILD_TESTS=ON
-- The CXX compiler identification is GNU 12.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: alphafill/bin/x86_64-conda-linux-gnu-c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
Using resources compiled with .local/bin/mrc
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found Boost:alphafill/lib/cmake/Boost-1.78.0/BoostConfig.cmake (found suitable version "1.78.0", minimum required is "1.70.0")
CMake Error at CMakeLists.txt:74 (find_package):
  By not providing "Finddate.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "date", but
  CMake did not find one.

  Could not find a package configuration file provided by "date" with any of
  the following names:

    dateConfig.cmake
    date-config.cmake

  Add the installation prefix of "date" to CMAKE_PREFIX_PATH or set
  "date_DIR" to a directory containing one of the above files.  If "date"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!

What is "date" package?
Also, in alphafill
@@ -44,9 +44,9 @@ set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)

 if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers")
+       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -lstdc++fs -std=c++17")
 elseif(MSVC)
-       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
+       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4 -lstdc++fs -std=c++17")
 endif()

for fliesystem, " -lstdc++fs -std=c++17" these flags are required?

As mentioned earlier, date is https://github.com/HowardHinnant/date
And I do not understand your question about the diffs you show for the CMakeLists.txt file.

And I do not understand your question about the diffs you show for the CMakeLists.txt file.

my question was CMakeLists.txt in the master, " -lstdc++fs -std=c++17" these flags should be in there?

The C++ code in alphafill uses features from C++17. So, yes, the -std=c++17 is required for gnu compilers. However, this flag is added by the cmake command set(CMAKE_CXX_STANDARD 17)
Likewise, the -lstdc++fs flag is required for some gnu compilers and the test to see if this is needed is in the FindFileSytem.cmake script.
You should not have to change the CMakeLists.txt file.


I can't "swipe the app out" when TouchID is enabled!

I don't know what that screen in which you can swipe an app up to kill the process is called...
So I double press Home button and this screen appears right?

Notice the app "EZDiary". That is the app using LTHPasscodeViewController. Now I swipe the app up to kill the process:

if the device doesn't have a TouchID, it kills the process just fine. However, if TouchID is enabled, just after I swiped the app up, the app opens again and ask me for the TouchID!  It's like an infinite loop!
I basically put this code in viewDidLoad of the initial view controller:
    if LTHPasscodeViewController.doesPasscodeExist() {
        LTHPasscodeViewController.sharedUser().showLockScreenWithAnimation(true, withLogout: true, andLogoutTitle: nil)
    }

Why did this happen? viewDidLoad certainly doesn't get called when I swipe the app up, right?
Yeah I know I didn't put the code in the app delegate. But it doesn't seem to work if I put it there. The passcode view controller just doesn't show up. It only works if I put it in viewDidLoad.

By the way, can you add my app to the list of apps that uses this at the bottom of README? Here's the link: https://itunes.apple.com/us/app/ezdiary-my-diary/id1128083826?ls=1&mt=8

Hi
In the file LTHPasscodeViewController.m comment the lines 1458, 1459, 1460 and try again
[self showLockScreenWithAnimation:NO
                       withLogout:NO
                 andLogoutTitle:nil];

Hey,
This is a known issue (sadly, I can't find the previous one to link it), it's due to the system calling didBecomeActive / willEnterForeground when killing the app. Why? No idea.
If you do remove those lines, then the app won't be protected while in the background, so you might end up disclosing sensitive information while on the multitasking view.
I haven't managed to find a way around this, due to the weird system call mentioned above. It appears to work fine on iOS 9, and, sadly, I can not test on iOS 8 anymore.

If the passcode is enable, you can add a subview to the appdelegate's window when the apps enters in background (if the passcode is enabled), this way you won't disclose any information.

@jnavarrom That sounds like a great idea! Since I can't write Objective-C, can you create a PR?
@rolandleth So that view is called "multitasking view"? I never heard of it until now. Also, it doesn't work on iOS 9! My phone is running iOS 9 and it always asks me for TouchID!

There is already logic for exactly that, 1462-1466, but only if there is a timer on the lockscreen. If there is no timer, or it has ended, the lockscreen is presented on enterBackground; I suppose it could always use the coverView on enterBackground, and show the lockscreen on enterForeground.
The multitasking view is when you double-press the home button.

You can even delete 1450-1462 and 1466, then you'll still have a cover on the multitasking view. Requires a bit of testing, though, as I haven't - I just tested it a couple of times.

I tried it on an iPhone 6s Plus running iOS 9.3.2. When I opened the app, it looks like this:

Then I tapped "Cancel" this appears:

As you can see, it's all kind of messed up!
Any ideass?

Never mind. I put the code in the wrong place...


Add more comments in the vector-add CMakeLists.txt file

This change adds instructions for the users to modify the CMakeLists.txt of the vector-add sample.
The idea is to make the vector-add sample as the empty template sample for new users.

I'll merge the change now, but like @jkinsky said, will need to update the driver based on invocation


chore: add launcher script

Thanks for sharing this project! I've added a launcher script for convenience which sets up venv and installs requirements.

Thanks chief, I appreciate it! But I want this project to be easily accessible from any os, but the .sh files are not compatible with windows without WSL. If you have other ideas to improve this project don't hesitate

Sure thing, I'll link you to the Windows launcher I'm using on another project in case you'd like to implement it in the future.
Best.


curried some more functions

pick, omit, pickWith, pickAll, eqProps, where, is, and, or, allPredicates, anyPredicates

It would be great if you could add the tests too. What I normally do is copy the examples and add the variantes for the currying.


xSQLServer: Use image 'Visual Studio 2017' as build worker image for AppVeyor

Pull Request (PR) description

Changes to xSQLServer

Change the module to use the image 'Visual Studio 2017' as the build worker image for AppVeyor (issue #685).

This Pull Request (PR) fixes the following issues:
Fixes #685
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #686 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #686   +/-   ##
===================================
  Coverage    97%    97%
===================================
  Files        30     30
  Lines      3250   3250
===================================
  Hits       3165   3165
  Misses       85     85

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

CHANGELOG.md, line 7 at r1 (raw file):

- Changes to xSQLServer
  - Added back .markdownlint.json so that lint rule MD013 is enforced.
  - Change the module to use the image 'Visual Studio 2017' as the build worker image for AppVeyor (issue #685).

This line is too long. Tests filed on this one.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

CHANGELOG.md, line 7 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This line is too long. Tests filed on this one.

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


InfVerif Task information needed

[Enter feedback here]
Hi, can you please add a section here for the InfVerif task?  Specifically how to invoke infverif.exe with different command line options. Changing settings to the InfVerif task via MsBuild is not documented anywhere. The existing sections for wmimofck, stampinf, and mofcomp tasks are good.
thank
you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1fd8158a-768a-6edc-2ced-0a9da038f6c9
Version Independent ID: 44220be0-e804-4a83-93a4-5cb1dd61ecb4
Content: Wmimofck task - Windows drivers
Content Source: windows-driver-docs-pr/devtest/wmimofck-task.md
Product: windows-hardware
Technology: devtest
GitHub Login: @DOMARS
Microsoft Alias: domars

Hi @MrDavid949,
MSBuild runs infverif as a task automatically, right after stampinf.  It uses the "Target Platform" in the project properties (Configuration Properties->Driver Settings) to auto-configure as follows:
Target Platform = Desktop. InfVerif /k
Target Platform = Universal. InfVerif /u
Target Platform = Windows Driver. InfVerif /w
We don't support changing that automatic invocation.  If you want to run infverif as a standalone, you can configure a bit more.  Those options are described on https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/running-infverif-from-the-command-line.
Does that help?

Hi, since I'm building a driver I think I need to keep the target platform set to "Windows Driver" which seems to lock me in to the /w option. I also found that page describing the command line.
I have created a custom target in my .vcxproj and called InfVerif.exe with the options I wanted.  It's not the best solution since I'm basically running InfVerif.exe twice during my build, once via the InfVerif task with /w and once in my custom step with the options I want. I guess there is no other way.

That sounds right to me.  I went ahead and added a short section with the info above in case someone else has the same question.  Thanks again for caring about the docs!
https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/running-infverif-from-the-command-line#infverif-and-msbuild-tasks


Hdfs User command re-assembler

re-create user command through granular hdfs audit logs

EAGLE-14 HDFS User Command Reassembler

@yonzhang please make sure format the pull request title with EAGLE-14 to make sure hook with jirap system: https://issues.apache.org/jira/browse/EAGLE-14

Reviewed, see comments above about the license information missing. Looks good to me for other files.

I have fixed the license header issue, I will merge


could powershell's title be custom

when running command 'node-sass ...' in powershell, powershell's title is set to be 'node-sass', i want to change it to my project name, could it be done?
Thank you

You can change it before invoking node-sass as described in the story https://devblogs.microsoft.com/scripting/powertip-change-the-powershell-console-title/