Fpc support

Hi,
I added support for FPC.
Would love to get some tips to more fully integrate this into compiler-explorer.
For example on how to add a support detection in the Makefile, 'cause that's not clear to me how that's supposed to work. (I've been testing it with the option LANG:=FPC, that does work)
Couple comments about the code:

I had to add an extra function to base-compile.js because FPC does not seem to support choosing the output name for individual units. (It does for executable names, but it needs a lot more boiler plate to support building executables)
The monaco syntax highlighting is a Python highlighter with some things changed, so its not complete at all
No demangling of names yet (and no idea how to do that yet)

Also, how do I get that fancy line highlighting going that's on the website at the moment?
Thanks

Ey! Thanks for this!
I'll give an initial review in a moment to your changes, but for now, I can answer some of your questions.
To launch CE with a different language, call it with make EXTRA_ARGS="--language FPC" instead of editing the LANG variable itself
The highlighting is based on what the compiler tells us the asm lines comes from in the code, usually by invoking it with the likes of options such as -g for GCC

As noted in the review comments, you should check the sister repo to add compilers to the live site

Hello! Sorry for the radio silence. We've been busy around here.
How is the PR going? If you feel comfortable with its current state, we can try to start into intergrating it
Cheers

@RabsRincon I have made some changes to compiler-explorer-image, but I haven't gotten around to being able to test the changes. I can rebase this PR tonight though so you can merge it if you don't need the image changes yet.

Image PR is here https://github.com/mattgodbolt/compiler-explorer-image/pull/45

I've merged and deployed all the binaries, so we'll be ready to go when this PR is complete. I haven't reviewed yet, but I see from the conversation that we're waiting a rebase? Or did you do that? I can take a look a little later if so.

@mattgodbolt already done, should be good

Merged and looks good. I just accidentally exploded the live site when testing the changes (oops); so I'll wait for the dust to settle first...so I'll test locally first.
Sadly pushing to beta isn't currently an option (but I might fix that) as beta and production share the same "run site" scripts...

Ok! I pushed to beta after fixing up a few things I found.
First up (and easy to fix I think) not all compilers came up:
info: Loading compiler from ./compilers/fpc
info: Gathering version information on fpc264
info: Gathering version information on fpc302
error: Unable to get version for compiler 'fpc264' - Error: spawn fpc264 ENOENT
error: Unable to get version for compiler 'fpc302' - Error: spawn fpc302 ENOENT
info: Gathering version information on /opt/compiler-explorer/fpc-3.0.2.x86_64-linux/bin/fpc
info: Gathering version information on /opt/compiler-explorer/fpc-2.6.0.x86_64-linux/bin/fpc
info: /opt/compiler-explorer/fpc-3.0.2.x86_64-linux/bin/fpc is version 'Free Pascal Compiler version 3.0.2 [2017/02/05] for x86_64'
info: /opt/compiler-explorer/fpc-2.6.0.x86_64-linux/bin/fpc is version 'Free Pascal Compiler version 2.6.0 [2011/12/23] for x86_64'

Secondly, of the ones that came up the compilation didn't work. The output the user sees is:
Fatal: Can't find unit system used by output
Fatal: Compilation aborted
Error: /opt/compiler-explorer/fpc-2.6.0.x86_64-linux/bin/ppcx64 returned an error exitcode (normal if you did not specify a source file to be compiled)
Compiler exited with result code 1

There's no error in the compiler log.
Any ideas? Thanks! (You can probably try it out still at https://fpc.godbolt.org/beta if that helps)

ok I fixed some of the config issues in 1e066478ee46c1396175f343f9883e0aa9b58e32 and 21b35a1ffd16336c1e43068ad185671815475d05.
Still no ideas on the compiler problem itself. Will wait for your reply on that. Getting there!

It seems I missed the fact that it's using a settings file referencing the needed libraries. I shall see what I can do.

@mattgodbolt it should be resolved with https://github.com/mattgodbolt/compiler-explorer/pull/626 and https://github.com/mattgodbolt/compiler-explorer-image/pull/47

Getting there. Now it compiles....but to assembly:

Er, and by assembly I mean binary...

Yes, hmm, I thought the 101010 button would be on by default, but it's not.
Is there a way to make that happen?
On Sat, Nov 18, 2017 at 5:07 PM, Matt Godbolt<EMAIL_ADDRESS>wrote:

Er, and by assembly I mean binary...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mattgodbolt/compiler-explorer/pull/600#issuecomment-345451926,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbBBgZpBgxuY4poqZk54Faz-L7qyJrGks5s3wCjgaJpZM4QJ7g-
.

If the binary mode needs to be on, I think we need to runtime patch the flags to force it on. The button's state is controlled by the UI: relying on it being set is a little dangerous :)
I presume you need binary mode on to force the code being disassembled? One possibility is to override compiler.compile and force the filter on. Or to rely on the same trick you've got to force execution off in "optionsForFilter" and put filter.binary = true in there.

the filter.binary solution did work well enough, but I made this change
instead so both ways are supported
https://github.com/mattgodbolt/compiler-explorer/pull/628


Add github test workflow

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c5ef3b9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   81.35%
=======================================
  Files           ?        8
  Lines           ?      177
  Branches        ?        0
=======================================
  Hits            ?      144
  Misses          ?       33
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ef3b9...127bc26. Read the comment docs.


Manifest v3: move source to @adobe/helix-sidekick-extension

Only app.js (used by the sidekick bookmarklet) will remain here.

See https://github.com/adobe/helix-sidekick-extension/issues/4#issuecomment-1153226399


NF: Add anaconda_nightly_upload_url

This is a follow up and fixes #46
This PR goal is to allow other Scientific Python projects to use this github action.
Please, let me know what you think, and I will be happy to rename the variables if needed.
Thanks

I'm on a plane and so reviewing on the GitHub mobile app (which isn't the best, sorry) but can you elaborate on why labels are needed now? They shouldn't be AFAIK.

Oh I guess this isn't a change in behavior given the current channel uploads

My bad. Can you document this optional variable though in your example?

Looks good to me; I'll let @matthewfeickert do the final review and merge.

Thanks all! 👍 I'm running in airports so if I have wifi on next flight I'll knock this final look over out and if not then I'll get to it tomorrow afternoon Europe time.

(Sorry, been traveling for work to CERN and so haven't gotten back to reviewing this. Will try this weekend.)

No worries @matthewfeickert , take your times

To help you for the review I use this action here: https://github.com/dipy/dipy/blob/master/.github/workflows/nightly.yml#L136-L156
and an example of the action result: https://github.com/dipy/dipy/actions/runs/7148367041/job/19471063289#step:4:376

ping @matthewfeickert, this would be good to have in sooner rather than later to help various downstream wheel production

ping @matthewfeickert, this would be good to have in sooner rather than later to help various downstream wheel production

Yes, I'm aware but c.f. again https://github.com/scientific-python/upload-nightly-action/issues/50#issuecomment-1872476726 for why I've been preoccupied. I'll have a stable computer and get to this before end of week.

c.f. again https://github.com/scientific-python/upload-nightly-action/issues/50#issuecomment-1872476726 for why I've been preoccupied

Hah, fair enough, sorry for rushing you. I was also traveling, so I didn't really internalize all the comments from the past few weeks.

Hi @matthewfeickert,
Thank you for the review and suggestions!  I will look at it this evening or tomorrow morning and come back to you.
Thanks again

gentle ping @skoudoro, as there aren't many outstanding review points here and I would really like to see this merged in  (I know is unfair to rush, so my apologies, as the PR was on our side for too long, too).

In general, I would urge reviewers who want to see major refactors when a PR is close to its conclusion to push changes (when confident) or make PRs (of they want the contributor to review). This helps to keep things moving, and preserves contributor motivation.

Sorry, I was traveling and then sick. I will get back to it by the end of the week (trying to catch up with everything). Apologize for that

In general, I would urge reviewers who want to see major refactors when a PR is close to its conclusion to push changes (when confident) or make PRs (of they want the contributor to review). This helps to keep things moving, and preserves contributor motivation.

I'm happy to do this (and am agree and tend to do this in places where I'm the primary maintainer and only have bikeshed comments), but feel that overtaking a PR where the contributor said they would come back to address another reviewer's comments can perceived as aggressive rather than helpful and I definitely would like to avoid that.
This PR was stuck on the reviewers' side for long enough that there is nothing to apologize for @skoudoro!

In general, I would urge reviewers who want to see major refactors when a PR is close to its conclusion to push changes (when confident) or make PRs (of they want the contributor to review). This helps to keep things moving, and preserves contributor motivation.

@stefanv I think I share @bsipocz's feelings here, in that I am not a big fan of reviewrs pushing changes to code unless explictly asked to, which is why I always use GitHub's suggest changes tool so that if people agree with them they can incoperate as many as they wish into the PR with a simple button click and don't have to do any additional work themselves.
If pushing changes is preferred here I'm fine with that, and I will just accept my own proposed changes through the UI as a single commit. I'm happy to wait though to let @skoudoro have time to look at the proposed changes later this week.

Using the inline commenting system is indeed friendly in that regard, but when larger pieces of code needs to be re-written it becomes impractical and a PR to the contributor branch does the same.
We should, however, not be shy to help one another shoulder the load; I've never heard of a maintainer complain because other maintainers helped them too much. We all have long TODO lists that will never be completed in this lifetime!

We should, however, not be shy to help one another shoulder the load; I've never heard of a maintainer complain because other maintainers helped them too much.

fair enough, my experience with people being annoyed about PRs being taken over was PRs from generic (scientist or student) contributors rather than PRs from maintainers of other packages

We should, however, not be shy to help one another shoulder the load; I've never heard of a maintainer complain because other maintainers helped them too much. We all have long TODO lists that will never be completed in this lifetime!

Okay, given this I'm going to accept my suggested changes as a single commit. @skoudoro to be explicit here, please take this as just a suggestion and feel free to revert or make any futher changes that you think would improve things. I'm happy to iterate with you further if needed! (though in full disclousure I have a job interview next week that is going to take me offline for most of it :grimacing: ).

Thanks @matthewfeickert, and good luck with the interview!

Test failure :eyes:

ANACONDA_TOKEN is empty , exiting...

Test failure 👀

ANACONDA_TOKEN is empty , exiting...

That's expected. c.f. https://github.com/scientific-python/upload-nightly-action/pull/32#issuecomment-1678400638 for a not great summary, but basically there isn't a great solution at the moment to run the tests on PRs from froks that wouldn't potentially open up a security threat.
I'm not saying it is impossible to fix, but it would require a redesign of the CI.

That makes sense; I run into this all the time.

@skoudoro Can you verify that if you use
jobs:
  steps:
    ...
    - name: Upload wheel
      uses: scientific-python/upload-nightly-action@3eb3a42b50671237cace9be2d18a3e4b3845d3c4f  # currently main
      with:
        artifacts_path: dist
        anaconda_nightly_upload_organization: my-alternative-organization
        anaconda_nightly_upload_token: ${{secrets.UPLOAD_TOKEN}}
        anaconda_nightly_upload_labels: dev

that things work for you to upload to your alternative registry? If so, I'll tag this commit as v0.3.0.

cc @nabobalis if you want to try this out for openastronomy/sunpy

Thank you all for pushing that forward.
@matthewfeickert, I just pushed the changes on https://github.com/dipy/dipy/commit/66d08be02b0abe87b317b03c8977e82c24f284dd. This is running

cc @nabobalis if you want to try this out for openastronomy/sunpy

Let me try.

@skoudoro Can you verify that if you use
jobs:
  steps:
    ...
    - name: Upload wheel
      uses: scientific-python/upload-nightly-action@3eb3a42b50671237cace9be2d18a3e4b3845d3c4f  # currently main
      with:
        artifacts_path: dist
        anaconda_nightly_upload_organization: my-alternative-organization
        anaconda_nightly_upload_token: ${{secrets.UPLOAD_TOKEN}}
        anaconda_nightly_upload_labels: dev

that things work for you to upload to your alternative registry? If so, I'll tag 3eb3a42 as v0.3.0.

ok, it works !  Thanks @matthewfeickert ! Make sure to put the right commit number @nabobalis.

Okay, great as things seem to be working for dipy's uploads

I'll go ahead and make a new tag and release.
Thank you for the PR and for verifying this works, @skoudoro!


Upgrade go version to 1.20.5

@manuelbuil updated to 1.20

@manuelbuil how do we get this merged?.

@manuelbuil how do we get this merged?.

We need somebody else to review. Let me ask around

I'll bring it up in our next sync meeting

We'll prepare a PR for this https://github.com/flannel-io/cni-plugin/issues/43 and then update go.mod and then we will release


Fix example code double-div rendering regression.

In c494ad61ef94b75ade6cb39ec22031df3959c5ea (/cc @garyburd), codeFn was refactored to additionally write
 and
. Most of the instances of {{code ...}} in templates were updated accordingly, but this one was missed.
As a result, after that commit, the example was written with a double-div.
As an example, see https://godoc.org/net/http#example-FileServer.
Before this fix:

// Simple static webserver:
log.Fatal(http.ListenAndServe(":8080", http.FileServer(http.Dir("/usr/share/doc"))))

After this fix:

// Simple static webserver:
log.Fatal(http.ListenAndServe(":8080", http.FileServer(http.Dir("/usr/share/doc"))))

Thanks!

Thank you!


How is the game evaluated?

Hey,
So is the performance of the agent evaluated on the total score of the Agent0 & Agent1 or only the score of Agent1 (which I assumed is the one to be controlled by our algorithm)?
Cos during some test plays I observed that everytime Agent1 makes the final the move to corner the pig, both Agent0 and Agent1 get the 25 big reward; while if it's Agent0 who makes the final move to corner the pig, only Agent0 will get the 25 while Agent1 will not.
Thanks!

Hi @jingweiz - thank you for reporting this! This problem should be fixed in #8. Could you pull these changes and let us know in case you experience any further problems?
Performance is evaluated on the score of agent 1 only.


[Bug]: "spawn Unknown  error" when running "npm run dev" on new app

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Extension
Expected behavior
Running npm run dev should start up a dev server to preview my app
Actual behavior
throws an error which says "Spawn Unkown"
Verbose output
spawn UNKNOWN                                                                                │
│                                                                                │
│  To investigate the issue, examine this stack trace:                                                 │
│    at spawn (node:internal/child_process:413)                                                        │
│    at spawn (node:child_process:757)                                                                 │
│    at baseOpen (open/index.js:224)                                                                   │
│      const subprocess = childProcess.spawn(command, cliArguments, childProcessOptions);              │
│    at async openURL (@shopify/cli-kit/src/public/node/system.ts:30)                                  │
│      await externalOpen.default(url)                                                                 │
│    at async authorize (@shopify/cli-kit/src/private/node/session/authorize.ts:46)                    │
│      await openURL(url)                                                                              │
│    at async executeCompleteFlow (@shopify/cli-kit/src/private/node/session.ts:199)                   │
│      const code = await authorize(scopes)                                                            │
│    at async ensureAuthenticated (@shopify/cli-kit/src/private/node/session.ts:135)                   │
│      newSession = await executeCompleteFlow(applications, fqdn)                                      │
│    at async ensureAuthenticatedPartners (@shopify/cli-kit/src/public/node/session.ts:43)             │
│      const tokens = await ensureAuthenticated({partnersApi: {scopes}}, env, options)                 │
│    at async fetchPartnersSession (@shopify/app/src/cli/services/context/partner-account-info.ts:39)  │
│      const token = await ensureAuthenticatedPartners()                                               │
│    at async prepareForDev (@shopify/app/src/cli/services/dev.ts:77)                                  │
│      const partnersSession = await fetchPartnersSession()

Reproduction steps

Following Shopify's tutorial on setting up a checkout ui extension. Run npm init @shopify/app@latest
cd into app directory
npm run shopify app generate extension
Hit enter. Error is thrown

Operating System
Windows 11
Shopify CLI version (check your project's package.json if you're not sure)
Tried latest & also v3.23.0
Shell
CMD
Node version (run node -v if you're not sure)
v18.16.0
What language and version are you using in your application?
Node 18.16.0

Hi! I'm not able to reproduce with a similar environment, but it looks like it's crashing when trying to open a browser to log in.
Could you try with another shell like Powershell? If it doesn't work, you can also try to set up the environment variable SHOPIFY_CLI_DEVICE_AUTH=1, which will cause the CLI to show a URL to log in, instead of opening the browser.

Hi, yeh I did fix it, its due to anti virus, you need to disable it or use the ubuntu app if you are on windows.

Thanks @arslan308 I fixed the issue. I just set the variable in node environment $env:SHOPIFY_CLI_DEVICE_AUTH=1
and then its working fine


Unable to start longhorn when deploying app

Keep writing:
Deployment is not ready: longhorn-system/longhorn-driver-deployer. 0 out of 1 expected pods are ready
Goes on for a looooong time and ends with:
Error: UPGRADE FAILED: timed out waiting for the condition
Rancher 2.5.5
Longhorn 1.1.0000
helm upgrade --history-max=5 --install=true --namespace=longhorn-system --timeout=10m0s --values=/home/shell/helm/values-longhorn-crd-1.1.000.yaml --version=1.1.000 --wait=true longhorn-crd /home/shell/helm/longhorn-crd-1.1.000.tgz
Tue, Feb 23 2021 4:43:07 pm | checking 8 resources for changes
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "engines.longhorn.io"
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "replicas.longhorn.io"
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "settings.longhorn.io"
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "volumes.longhorn.io"
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "engineimages.longhorn.io"
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "nodes.longhorn.io"
Tue, Feb 23 2021 4:43:07 pm | Looks like there are no changes for CustomResourceDefinition "instancemanagers.longhorn.io"
Tue, Feb 23 2021 4:43:08 pm | Looks like there are no changes for CustomResourceDefinition "sharemanagers.longhorn.io"
Tue, Feb 23 2021 4:43:08 pm | beginning wait for 8 resources with timeout of 10m0s
Tue, Feb 23 2021 4:43:10 pm | Release "longhorn-crd" has been upgraded. Happy Helming!
Tue, Feb 23 2021 4:43:10 pm | NAME: longhorn-crd
Tue, Feb 23 2021 4:43:10 pm | LAST DEPLOYED: Tue Feb 23 15:43:07 2021
Tue, Feb 23 2021 4:43:10 pm | NAMESPACE: longhorn-system
Tue, Feb 23 2021 4:43:10 pm | STATUS: deployed
Tue, Feb 23 2021 4:43:10 pm | REVISION: 3
Tue, Feb 23 2021 4:43:10 pm | TEST SUITE: None
Tue, Feb 23 2021 4:43:10 pm |
Tue, Feb 23 2021 4:43:10 pm | ---------------------------------------------------------------------
Tue, Feb 23 2021 4:43:10 pm | SUCCESS: helm upgrade --history-max=5 --install=true --namespace=longhorn-system --timeout=10m0s --values=/home/shell/helm/values-longhorn-crd-1.1.000.yaml --version=1.1.000 --wait=true longhorn-crd /home/shell/helm/longhorn-crd-1.1.000.tgz
Tue, Feb 23 2021 4:43:10 pm | ---------------------------------------------------------------------
Tue, Feb 23 2021 4:43:10 pm | helm upgrade --history-max=5 --install=true --namespace=longhorn-system --timeout=10m0s --values=/home/shell/helm/values-longhorn-1.1.000.yaml --version=1.1.000 --wait=true longhorn /home/shell/helm/longhorn-1.1.000.tgz
Tue, Feb 23 2021 4:43:10 pm | checking 16 resources for changes
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ServiceAccount "longhorn-service-account"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ConfigMap "longhorn-default-setting"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ConfigMap "longhorn-storageclass"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ClusterRole "longhorn-role"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ClusterRole "longhorn-admin"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ClusterRole "longhorn-edit"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ClusterRole "longhorn-view"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for ClusterRoleBinding "longhorn-bind"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for Role "longhorn-psp-role"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for RoleBinding "longhorn-psp-binding"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for Service "longhorn-backend"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for DaemonSet "longhorn-manager"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for Deployment "longhorn-driver-deployer"
Tue, Feb 23 2021 4:43:10 pm | Looks like there are no changes for Deployment "longhorn-ui"
Tue, Feb 23 2021 4:43:10 pm | beginning wait for 16 resources with timeout of 10m0s
Tue, Feb 23 2021 4:43:12 pm | Deployment is not ready: longhorn-system/longhorn-driver-deployer. 0 out of 1 expected pods are ready
Tue, Feb 23 2021 4:43:14 pm | Deployment is not ready: longhorn-system/longhorn-driver-deployer. 0 out of 1 expected pods are ready
Tue, Feb 23 2021 4:43:16 pm | Deployment is not ready: longhorn-system/longhorn-driver-deployer. 0 out of 1 expected pods are ready
Tue, Feb 23 2021 4:43:18 pm | Deployment is not ready: longhorn-system/longhorn-driver-deployer. 0 out of 1 expected pods are ready
...
...
...
Tue, Feb 23 2021 4:53:10 pm | Deployment is not ready: longhorn-system/longhorn-driver-deployer. 0 out of 1 expected pods are ready
Tue, Feb 23 2021 4:53:10 pm | Error: UPGRADE FAILED: timed out waiting for the condition

This was lost in a non-Zube view within the Dashboard for a while. This doesn't look UI related so passing this on to the main Rancher repo for investigation.


Support adding a custom header of the backend to the response

ie:
X-haproxy-backend: hostname.of.mesos.agent:port_of_app
This would ideally be a global flag for marathon-lb, and would ease troubleshooting in certain instances for http applications. If you like the idea, let me know and I can likely come up with a patch to enable it (disabled by default).

@brndnmtthws or would you prefer I do something kind of like in your blue green deploy branch docs?
It seems like being able to do something like this globally would be more desirable and consistent, but I can see a case for forcing users to add it to their app labels if they want this.

I think in your case, passing your own templates would make the most sense.

Cool, thanks and sorry for the issue spam.

@SEJeff any chance you could share the template for it ?

@scalp42 I'll probably be sending a few PRs down the road to make this a bit nicer, but I needed to change the healthcheck to the more lightweight HEAD requests and did this:
    "labels": {
        "HAPROXY_0_MODE": "http",
        "HAPROXY_GROUP": "external",
        "HAPROXY_0_VHOST": "my-mesos-dns-task-name.mesos",
        "HAPROXY_0_BACKEND_HTTP_HEALTHCHECK_OPTIONS": "  option  httpchk HEAD {healthCheckPath}\n  timeout check {healthCheckTimeoutSeconds}s\n  http-response add-header X-Backend-Name %s\n"
    },

Search this document via <CTRL>-f for:
Please refer to the table below for currently defined variables
This did the trick just fine for me.

Thanks a lot @SEJeff, greatly appreciated.


Add awscli version support for linux. Fixes #9

Also refactored the rspec tests to allow setting attributes per test.

@Crazybus thanks for the PR. I am going to pull it into my fork and update from there. I do not have access to this repository any longer.
https://github.com/nickryand/awscli-cookbook

Great! Since you are the owner of the supermarket cookbook could you update the source to point to your fork? https://supermarket.chef.io/cookbooks/awscli
I'm planning on adding in configuration support too (https://github.com/awslabs/awscli-cookbook/issues/10). Should I still send the pull request here?

Yup I was planning to update it within the next couple of days. I am also moving the python dependency from the python cookbook which is now deprecated over to the poise-python cookbook.
Open the pull requests at my fork since I can merge PR's directly there. I'll merge in this PR by hand and refactor it to work with the poise-python cookbook.

https://github.com/nickryand/awscli-cookbook == 404

This had to go through a name change. A forked version of this cookbook is being maintained at:
https://github.com/nickryand/cloudcli-cookbook

Closing the pull request in favour of Nick's  https://github.com/nickryand/cloudcli-cookbook fork.


Mica is not working properly on Electron v27.0.0

At Electron v27.0.0, after using setMicaEffect(), the background color has changed to pure black.
After testing, it can work normally at Electron v26.3.0.

Thank you. But I haven't seen any new versions on NPM, haven't they been released yet?

yes, sorry I just did that

When I upgraded to version 1.5.2, the Mica effect worked under Electron version 27.0.1, but I noticed some other issues:

When the window loses focus, the Mica effect of the window will be highlighted with a white border, and even if the window regains focus, it will not disappear. Only when the window is minimized or reopened will it return to normal.
The minimized and maximized animation effects of the window have disappeared

https://github.com/GregVido/mica-electron/assets/41540888/1ed57049-bc9d-45cd-bb00-18c30fbd9d5b

I have this same issues


Including Index Options in Schema Read from Server

readSchema and syncSchema calls from the client are currently not setting the index options values retrieved from the server. This causes problems for indices using string keys since the IndexOptions values remain as the default values of false even after syncing the schema with the server. This change reads in the index options retrieved from the server and sets the values in the IndexOptions object of the Index.

Coverage remained the same at 100.0% when pulling 432de6256ba040101f6943462075be08866d2174 on mikejdorm:schema-key-json-fix into a69d42235f74bbe81785f84deeb0bc0b11f8e3e1 on pilosa:master.

Thanks, this looks good!


installation using Python 3.8.3

Hi,
Is is possible to install the software using Python 3.8.3? The computing node I want to use is not yet upgraded to Python 3.9
Thanks!
Pieter
pip install . Defaulting to user installation because normal site-packages is not writeable Processing xxx/xxx/xxx/xxx/tmbed   Installing build dependencies ... done   Getting requirements to build wheel ... done     Preparing wheel metadata ... done ERROR: Package 'tmbed-1.0.0' requires a different Python: 3.8.3 not in '>=3.9,<4.0'

Hi. The requirements are based on the development/test platform that I've used. However, I think that the required packages are also compatible with Python 3.8; in fact, TMbed should also be quite flexible regarding the versions of those packages.
My suggestion would be to install the required packages (whatever is the most recent version supported by Python 3.8) and see if TMbed runs, e.g., by using it as a python module (python -m tmbed).
Required packages: h5py, numpy, sentencepiece, torch, tqdm, transformers, typer


Support type cast or custom scheme

Scheme less is very handy but in some language (for example, PHP) might insert wrong data type as it has weak data type.
For example:
#php -r 'var_dump([["value" => 1], ["value" => "2"], ["value" => 3]]);'
array(3) {
  [0]=>
  array(1) {
    ["value"]=>
    int(1)
  }
  [1]=>
  array(1) {
    ["value"]=>
    string(1) "2"
  }
  [2]=>
  array(1) {
    ["value"]=>
    int(3)
  }
}

If we insert this variables into InfluxDB. and execute select * from mixed_type where value > 1 query. Unfortunately, this result only shows {"value": 3}.
Essentially, just coding carefully solve the problem. but It's hard to find bad data if once inserted wrong one.
to avoid this unwanted behaviour.  adding type cast or custom scheme would be helpful.
References

Hive: type cast
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-TypeConversionFunctions

Treasure Data: custom scheme
http://docs.treasuredata.com/articles/schema#setting-custom-schema

feedback is appreciated.

In 0.9.0 values are type-agnostic until the first value is written, and then all subsequent values must match the type of the first one written.


Escape html in rendered composite answers

What is the context of this PR?
This adds dictionary escaping method that checks composite answer (address) for a question and summary screen. Change is described on this Trello card.
How to review
To recreate the problem use test_address.json and enter HTML in the first line. Check if on schema's confirmation question and summary screen address is escaped.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 HTML in composite answers (S)

Also, tests for the new method should be added to test_answer_store.py.

Added some tests and addressed Andrew's comments.


TrafficLightsPerceptionComponent::Visualize need create debug_vis folder

System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
Apollo installed from (source or binary):
Apollo version (3.5, 5.0, 5.5, 6.0):
Output of apollo.sh config if on master branch:

Steps to reproduce the issue:
  cv::imwrite(absl::StrCat("/apollo/debug_vis/",
                           std::to_string(frame.timestamp), ".jpg"),
              output_image);

Here, it is directly saved to the path, and it is not checked whether the path /apollo/debug_vis/ exists.

fixed in #14656


 error returned repeatedly

When I have the ATTINY connected to the CEC output of an Apple TV, on top of properly reported messages it reports a sequence (typically 3 in a row) of  errors.
This happens upon powering up (I have modified the debug printout a bit, but I think it is clear what the code reports):
Rx-> 45:7d audio status?
<-Tx 5f:72 set audio
Rx-> 4f:90:00 pwr
max E -1
max E -1
max E -1

and upon powering down (sleep mode):
Rx-> 4f:36 all sby
max E -1
max E -1
max E -1

The captured waveform of a single "max error" frame looks like this:

Any ideas what is going on and how to fix this?

This looks to me like an aborted frame: start bit, initiator=0b0100, destination=0b0000, EOM=0 (not end-of-message), ACK=1 (not acknowledged), then free time followed by a new frame.  My best guess is that the initiator is retransmitting the frame after the header block was not acknowledged (probably because there is no device on the bus with address 0).  It's not clear to me from the spec whether or not an initiator should retransmit a frame before it finishes sending it the first time, but I think the behavior on the ATTINY end is correct regardless: move on and start reading the next frame.  Do you see any issues with that?

OK I think I have it. Below several sequences are captured.
[Apple TV startup]
Rx-> 45:7d audio status?
<-Tx 5f:72 set audio
Rx-> 4f:90:00 pwr
max E -1
max E -1
max E -1
max E -1
max E -1

[Volume up/down pressed on the Apple remote]
Rx-> 45:44:41 v up
Rx-> 45:45 rel
Rx-> 45:44:42 v dn
Rx-> 45:45 rel

[Apple TV shutdown - the STANDBY message received properly]
Rx-> 4f:36 all sby
max E -1
max E -1
max E -1
max E -1

[Apple TV startup]
Rx-> 45:7d audio status?
<-Tx 5f:72 set audio
Rx-> 4f:90:00 pwr
max E -1
max E -1
max E -1
max E -1
max E -1

[Apple TV shutdown - no STANDBY message received]
max E -1
max E -1
max E -1

[Apple TV startup]
Rx-> 45:7d audio status?
<-Tx 5f:72 set audio
Rx-> 4f:90:00 pwr
max E -1
max E -1
max E -1
max E -1
max E -1

[Apple TV shutdown - no STANDBY message received]
max E -1
max E -1
max E -1

[Apple TV startup]
Rx-> 45:7d audio status?
<-Tx 5f:72 set audio
Rx-> 4f:90:00 pwr
max E -1
max E -1
max E -1
max E -1

[Volume up/down pressed on the Apple remote]
Rx-> 45:44:41 v up
Rx-> 45:45 rel
Rx-> 45:44:42 v dn
Rx-> 45:45 rel

[Apple TV shutdown - the STANDBY message received properly]
Rx-> 4f:36 all sby
max E -1
max E -1
max E -1

[Apple TV startup]
Rx-> 45:7d audio status?
<-Tx 5f:72 set audio
Rx-> 4f:90:00 pwr
max E -1
max E -1
max E -1
max E -1
max E -1

[Other CEC traffic injected from another device (Raspberry Pi)]
Rx-> 1f:84:30:00:01 addr map
Rx-> 1f:85 sys discovery
Rx-> 4f:82:10:00 otp
Rx-> 14:8c vid?
Rx-> 4f:87:00:10:fa vid
Rx-> 14:9f CEC v?
Rx-> 41:9e:06 CEC v
Rx-> 14:46 osd?
Rx-> 41:47:42:65:64:72:6f:6f:6d osd
Rx-> 14:91 lang?
Rx-> 41:00:91:00 ???
Rx-> 15:8c vid?
<-Tx 5f:87 vid
Rx-> 15:83 phys addr?
<-Tx 5f:84 phys addr
Rx-> 15:9f CEC v?
Rx-> 15:9f CEC v?
Rx-> 15:8f pwr?
<-Tx 51:90 rep pwr
Rx-> 15:46 osd?
<-Tx 51:47 osd
Rx-> 15:91 lang?
Rx-> 15:91 lang?
Rx-> 18:8c vid?
Rx-> 8f:87:00:1a:11 ???
Rx-> 18:83 phys addr?
Rx-> 8f:84:50:00:04 addr map
Rx-> 18:9f CEC v?
Rx-> 81:9e:05 CEC v
Rx-> 18:8f pwr?
Rx-> 81:90:00 pwr
Rx-> 18:46 osd?
Rx-> 81:47:43:68:72:6f:6d:65:63:61:73:74 osd
Rx-> 18:91 lang?
Rx-> 81:00:91:04 abort

[Apple TV shutdown - the STANDBY message received properly]
Rx-> 4f:36 all sby
max E -1
max E -1

What you can see:

If the AppleTV is shut down immediately after the startup (no CEC messages in between), the standby message is not received.
If there is any CEC traffic in-between the startup and the shutdown, the standby message is received properly. This "in-between" traffic can be anything - either generated by the AppleTV or another device.

My hypothesis is the ATTINY code does not recover properly from an aborted message and as a result the next message after the aborted one (the all standby in my case) is dropped (I believe AppleTV is still sending it properly). I do not fully follow what happens in the code after the  error, but it seems it may cause the next message after that to be dropped.

I no longer have these issues. It might have been a hardware issue (no calibrated oscillator?). I have gone through multiple HW revisions on my end and have not seen these errors for a long time now. I think this can be closed.


wezterm: 20230326-111934-3666303c -> 20230408-112425-69ae8472

Description of changes
https://wezfurlong.org/wezterm/changelog.html#20230408-112425-69ae8472

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.


Remove apache

Make sure we don't have apache running which may conflict with our normal operations. OCD run is #32, and already passed 2 Hawkeye setups.

OCD run with the latest code is https://ocd.appscale.com:8080/job/Hawkeye-Eucalyptus/177/

Good work! :)


Manually modifying grid item size causes overlapping items

[X] Bug
[ ] Feature Request
[X] Question

@STRML
I'm currently trying to implement an additional button on each grid item that allows the user to enlarge the item to fill the full width of the dashboard. The code I've written successful enlarges the grid item, but it causes the item to overlap with other existing items (instead of the dashboard automatically rearranging the items like it does when you drag a grid item).
Is there any way to trigger this automatic rearrangement manually from my code? Or to cause the dashboard to detect these kinds of changes besides just looking for dragging events?
Thanks!

+1
I have a similar issue. After programmatically changing a grid item's size, affected neighbor grid items do not adjust position accordingly.

It is not intended or supported to put arbitrary data here. Store a map
elsewhere correlating grid ids with arbitrary data.
On Wed, Apr 17, 2019, 4:36 AM Ran Byron<EMAIL_ADDRESS>wrote:

+1
I have a similar issue. After programmatically changing a grid item's
size, affected neighbor grid items do not adjust position accordingly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/STRML/react-grid-layout/issues/703#issuecomment-483737457,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJFP7-AJCW-Yj4URSnTHjSvpDkPSzwGks5vhfwBgaJpZM4RXF6_
.

It is not intended or supported to put arbitrary data here. Store a map elsewhere correlating grid ids with arbitrary data.

Was this meant for #929?
The request here is that when grid items change width/height via props update, colliding items would be moved away/towards just as does ReactGridLayout.onResize.

Sorry, yes it was.
Open to a PR for this.

I found that this feature is available as long as the layout/s prop is used (not the data-grid attribute option) and updated.
Here's a working demo https://codesandbox.io/s/wyomxmv737

https://codesandbox.io/s/wyomxmv737

Link is busted :-(

Yup, link isnt working, @ranbena

Sorry @pavs94 @brspurri the sandbox seems to no longer exist and is irrecoverable.

Use and update layout/s to modify properties of grid-item，this works


Travis CI

https://issues.apache.org/jira/browse/INFRA-17368

Now working in PRs and master branch. I just raised PR #22 to add the Travis CI badge.


property-naming-strategy (and other jackson configurations) not respected

Expected Behavior
Micronaut Serialization module should respect Jackson property naming strategy settings (from application.yml) when serializing/deserializing POJOs
Actual Behaviour
Micronaut ignores Jackson settings
Steps To Reproduce

create an app with jackson features
mn create-app --build=gradle --jdk=17 --lang=java --test=junit --features=serialization-jackson,jackson-databind com.example.demo
Add a controller with an endpoint that receives a POJO

// HelloController.java
@Controller
public class HelloController {
    @Post("/hello1")
    @Produces(MediaType.APPLICATION_JSON)
    public String index(@Body Hello1Request req) {
        return "Hello1, " + req.firstName();
    }
}

// Hello1Request.java
@Serdeable
public class Hello1Request {
    private final String firstName;

    public Hello1Request(final String firstName) {
        this.firstName = firstName;
    }

    public String firstName() {
        return firstName;
    }
}

Add jackson.property-naming-strategy: SNAKE_CASE to application.yml
Start the app
Send a request using snake case: curl -X POST 'http://localhost:8080/hello1' -H 'Content-Type: application/json' -d '{"first_name": "John"}'
Receive error: {"message":"Bad Request","_links":{"self":[{"href":"/hello1","templated":false}]},"_embedded":{"errors":[{"message":"Failed to convert argument [req] for value [null] due to: Unable to deserialize type [Hello1Request req]: Null argument specified for [firstName]. If this argument is allowed to be null annotate it with @Nullable","path":"/req"}]}}%
Send a request using lower camel case: curl -X POST 'http://localhost:8080/hello1' -H 'Content-Type: application/json' -d '{"firstName": "John"}'
receive OK response: Hello1, John

Environment Information

macOS Monterrey 12.6.6
Java 17
Micronaut 3.10.1

Example Application
No response
Version
3.10.1

you should not use both features serialization-jackson and jackson-databind
With Micronaut Framework 4.0, you must choose which serialization implementation you want..
I don't expect Micronaut Serialisation to use Jackson configuration such as jackson.property-naming-strategy: SNAKE_CASE
You can access the Micronaut Serialization configuration reference and Micronaut Serialization docs.

The issue I reported was for Micronaut 3.10.1 but thanks for your response.
I understand Micronaut Serialization does not have a configuration for naming strategy then

I understand Micronaut Serialization does not have a configuration for naming strategy then

I don't think we do. Do you know @yawkat ?

currently it can be done on an individual type level but not globally no

We have even worse issue with Micronaut Serialization feature. We have JDBI as a ResultSet to POJO mapper and extensively using PG json functions. The problem is databases are usually snake cased, so we are injecting a copy of Jackson ObjectMapper with custom SNAKE_CASE strategy in Micronaut3 microservices.
With Micronaut's ObjectMapper is totally impossible by design (it reads @Serdeable annotation to determine strategy - and we use default for anything except database interaction).
Can we get back the ability to globally override strategy for concrete ObjectMapper instance?


 was there

Hi @swaraj961 - I appreciate you wanted to get involved with contributing to our repo! However, this pull request doesn't meet our bar for really adding value, so I'm tagging it with the invalid label (as it doesn't qualify for the Microsoft hacktober event) and closing it.
Please don't let this discourage you from contributing in the future!


Regarding the version issue

Hi Team
This output plugin is working for Filebeat version 7.8. Is there any other output plugin for current filebeat version or any plan to release new output plugin that will compatible for current filebeat version?
Regards,
Anupreksha Jain

Hi
Yes support current version of filebeat planned in this year.


Question about operation of "--write-auto-sub"

Checklist

[X] I'm asking a question
[X] I've looked through the README and FAQ for similar questions
[X] I've searched the bugtracker for similar questions including closed ones

Question

What should result from the following examples ?

youtube-dl -v --write-auto-sub --write-sub "https://www.youtube.com/watch?v=F5Y7BniaRXg"
youtube-dl -v --write-auto-sub --write-sub --all-subs "https://www.youtube.com/watch?v=F5Y7BniaRXg"

I get the following from both forms:

youtube-dl -v --write-auto-sub --write-sub --all-subs "https://www.youtube.com/watch?v=F5Y7BniaRXg"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--write-auto-sub', u'--write-sub', u'--all-subs', u'https://www.youtube.com/watch?v=F5Y7BniaRXg']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.12.05
[debug] Python version 2.7.16 (CPython) - Darwin-19.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.1-tessus, ffprobe 4.3.1-tessus
[debug] Proxy map: {}
[youtube] F5Y7BniaRXg: Downloading webpage
WARNING: video doesn't have subtitles
[youtube] F5Y7BniaRXg: Looking for automatic captions
WARNING: Couldn't find automatic captions for F5Y7BniaRXg

That result seems correct as using --list-subs also returns a warning that there are no subtitles:

youtube-dl -v --list-subs "https://www.youtube.com/watch?v=F5Y7BniaRXg"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--list-subs', u'https://www.youtube.com/watch?v=F5Y7BniaRXg']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.12.05
[debug] Python version 2.7.16 (CPython) - Darwin-19.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.1-tessus, ffprobe 4.3.1-tessus
[debug] Proxy map: {}
[youtube] F5Y7BniaRXg: Downloading webpage
WARNING: video doesn't have subtitles
[youtube] F5Y7BniaRXg: Looking for automatic captions
WARNING: Couldn't find automatic captions for F5Y7BniaRXg

However, when this form is used, auto generated subtitles ARE downloaded:

youtube-dl -v --write-auto-sub "https://www.youtube.com/watch?v=F5Y7BniaRXg"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--write-auto-sub', u'https://www.youtube.com/watch?v=F5Y7BniaRXg']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.12.02
[debug] Python version 2.7.16 (CPython) - Darwin-19.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.1-tessus, ffprobe 4.3.1-tessus
[debug] Proxy map: {}
[youtube] F5Y7BniaRXg: Downloading webpage
[youtube] F5Y7BniaRXg: Looking for automatic captions
[debug] Default format spec: bestvideo+bestaudio/best
[info] Writing video subtitles to: How to recover data from a hard drive (stuck heads - buzzing, clicking, etc)-F5Y7BniaRXg.en.vtt

Other than testing for a warning, is there a way of finding auto generated subtitles ?
Why does combining --write-auto-sub and --write-sub return the warning that there are no auto generated subtitles when there clearly are ?
Should --list-subs return info on auto generated subtitles ?

An observation:
Your first example outputs:
[debug] youtube-dl version 2020.12.05
Your third example outputs:
[debug] youtube-dl version 2020.12.02
When I try this on my machine, it doesn't work for either example using version 2020.12.05.

Yes, I missed that.  Auto-generated captions don't work for that video in 2020.12.09 either.  Auto-generated captions for that video are visible in my web browser so, it looks like a YTDL bug.

I just tested 2020.12.12 version, auto-generated captions still doesn't work.

youtube-dl --list-subs "https://www.youtube.com/watch?v=F5Y7BniaRXg" -vv
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--list-subs', 'https://www.youtube.com/watch?v=F5Y7BniaRXg', '-vv']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2020.12.12
[debug] Python version 3.8.5 (CPython) - Linux-5.4.0-54-generic-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] F5Y7BniaRXg: Downloading webpage
WARNING: video doesn't have subtitles
[youtube] F5Y7BniaRXg: Looking for automatic captions
WARNING: Couldn't find automatic captions for F5Y7BniaRXg
F5Y7BniaRXg has no automatic captions
F5Y7BniaRXg has no subtitles


Partner APIs for Express Route with fixes

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please add REST spec PR link to the SDK PR
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/2795
@dsgouda : I did generate the code using generate.cmd since my swagger is checked in. Do you see any issues? Will update the package version

Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/2795
@dsgouda : I did generate the code using generate.cmd. Do you see any issues? Will update the package version

@vinayada1  If you generate the code using generate.cmd related information will be logged in a txt file. We can't see that file in this PR.

@dsgouda Added network_resource-manager.txt file. Sorry.....overlooked that this was a modified file not an untracked file. The diff seemed like not related so had skipped it.


Emit an event when nack messages are updated

Nack messages are used in a few scenarios, such as when a document exceeds 10,000 ops since the last summary. This change makes deli emit an event when it updates nack messages. This will let me improve some logging when the client exceeds that limit.
Changes:

Refactor nack message updates to go through a central updateNackMessages method and make that method emit an event when it's called.

This will help with #9949


Refactor inspectAPI and add timeout values

This pull request includes refactoring of the inspectAPI struct and the addition of timeout values for inspect and advance requests. The inspectAPI struct has been updated to use the ServerInterface type. Additionally, the NonodoOpts struct now includes TimeoutInspect and TimeoutAdvance fields, which allow for specifying custom timeout values for inspect and advance requests. This improves the flexibility and control of the application's request handling.

LGTM!


GATK4 run_genomicsdb call to run_gatk should specify which optinal argument to use

Hi,
The run_genomicsdb method in bcbio should specify which optional argument(s) to use for running GATK. Currently the intended memscale parameter get's used as the tmp dir parameter.
java -Dsamjdk.use_async_io_read_samtools=false -Dsamjdk.use_async_io_write_samtools=true -Dsamjdk.use_async_io_write_tribble=false -Dsamjdk.compression_level=1 -Dsnappy.disable=true -Xms454m -Xmx3181m -XX:+UseSerialGC -Djava.io.tmpdir={direction: increase, magnitude: 9.0} -jar /data/run/Projects/test_bcbio_1.0.5a0_gatk4_beta2/bcbio_install/data_dir/anaconda/share/gatk4-4.0b2-0/gatk-package-4.beta.2-local.jar GenomicsDBImport etc ....
This causes GenomicsDBImport step to fail.
_run_genomicsdb_import:
https://github.com/chapmanb/bcbio-nextgen/blob/233c45834006ab955506a30981e943b07c6a665b/bcbio/variation/gatkjoint.py#L46
run_gatk:
https://github.com/chapmanb/bcbio-nextgen/blob/af80cd3166538c04b2b3a02ca4243dc4bef2cf56/bcbio/broad/__init__.py#L315
I am not sure if any of the other optional parameters, like tmp directory are needed and where to get that value from.
Thank you.

Neill;
Sorry about the issue and thanks for the detailed report. This was my mistake in porting this over and should be fixed now in the latest development version. Please let me know if you run into any other issues at all.


Avoiding using deprecated global Mix

I don't have permission to make the change so here is my suggestion:
At webpack.mix.js
    Mix.manifest.refresh = _ => void 0
Change to:
    mix.options({ manifest: false })

Has been changed, thanks for the suggestion!


Help command

Bot should have a dynamic help command with pagination?

This has been fixed here: https://github.com/mkevenaar/CharlieSpring/commit/f022b6290f0a7575b0faaeac8726137674a9e2a9

:tada: This issue has been resolved in version 0.1.0 :tada:


Update chai dependency.

Ooooooo 1000 PR. 🎉

Ey, I planned to do this ;(
I wanted to fix a typo, but now it is not worth it.


Option to configure path of dotnet

Currently I have to work with multiple versions of dotnet (3.1, 5, 6) on Linux and the easiest way to manage (that I now) is to have all the versions not included in my paths and create aliases to each dotnet exec (I have dotnet3, dotnet5, dotnet6)
Would be nice if this tool could pickup the one selected by the project or allow me to select the executable path
Cheers, nice extension

Yes, this is a reasonable request and it will be implemented in terms of #96, so it will reuse the same dotnet CLI used by a solution. Including the ability to change it to anything else.
But ETA at that time :)


remove usage of kwarg that does not exist before python 3.7

Do the logs look OK? I thought the text was required to get the right encoding....

Ahh I see you are now decoding it.

Ahh I see you are now decoding it.

It didn't seem to require that but I put in the decode if the type somehow returns as the docs suggest it ought to

works on arbitrarily chosen python versions 3.5.9, 3.6.8, and 3.7.7


Removing extra guidance for Linux lib rename

Since the fix for the simulator dll name was merged with the cloud simulator feature branch, the guidance on renaming the simulator dll for Linux is no longer needed. See https://github.com/microsoft/qsharp-compiler/pull/1093#discussion_r677814103 for context.

We do have a work around for this now in the main branch, as @swernli points out. However the fact that we still have the runtime library as a .dll in Linux instead of a .so seems inconsistent to me and is something we may want to address at some point.
@swernli Does leaving this section of the readme in as a breadcrumb for that issue make sense, or should there be a more official issue for this? Or should we just go forward with what we have and not worry about the .dll vs .so extension?

@swernli Does leaving this section of the readme in as a breadcrumb for that issue make sense, or should there be a more official issue for this? Or should we just go forward with what we have and not worry about the .dll vs .so extension?

I agree that the inconsistency in naming there is both annoying and problematic. I would prefer to not confuse anyone approaching these instructions for using QIR with unnecessary steps, so I've instead filed https://github.com/microsoft/qsharp-runtime/issues/783 to track the need to fix our weird renaming patterns.


OpenMP backend: compilation failure with zip_iterator and complex<float>

CUDA version: 9.2
Thrust version: 1.9.2 (bundled in CUDA 9.2)
GCC version: 5.4.0
The following code fails to compile for cuda backend, specifically the line "auto zipout_end = ...".
It compiles however if we make any of the following changes:

change TYPE to float
target openmp backend.

#include <thrust/device_vector.h>
#include <thrust/sequence.h>
#include <thrust/copy.h>
#include <thrust/gather.h>
#include <thrust/iterator/counting_iterator.h>
#include <thrust/iterator/zip_iterator.h>
#include <thrust/complex.h>

/* g++ -std=c++11 -I/usr/local/cuda/include -O2 -x c++ -fopenmp -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_OMP -lgomp minimal.cu
 nvcc -std=c++11 --expt-extended-lambda minimal.cu
*/

// typedef float TYPE;
typedef thrust::complex<float> TYPE;

int main()
{
   thrust::device_vector<TYPE> d_vec(10);
   thrust::sequence(d_vec.begin(), d_vec.end());
   thrust::device_vector<TYPE> d_res(10);

   auto pred = [] __host__ __device__ (TYPE val) { return abs(val) > 5; };
   auto cntit_begin = thrust::make_counting_iterator(0);
   auto cntit_end = cntit_begin + 10;

   // generate indices and values in two calls
   thrust::device_vector<int> indices(10);
   auto indices_end = thrust::copy_if(cntit_begin, cntit_end, d_vec.begin(), indices.begin(), pred);
   thrust::gather(indices.begin(), indices_end, d_vec.begin(), d_res.begin());

   // generate indices and values in one call
   auto zipin_begin = thrust::make_zip_iterator(thrust::make_tuple(cntit_begin, d_vec.begin()));
   auto zipin_end = thrust::make_zip_iterator(thrust::make_tuple(cntit_end, d_vec.end()));
   auto zipout_begin = thrust::make_zip_iterator(thrust::make_tuple(indices.begin(), d_res.begin()));
   // the following line fails to compile for combination of cuda backend and complex type
   auto zipout_end = thrust::copy_if(zipin_begin, zipin_end, d_vec.begin(), zipout_begin, pred);
}

Right now we have a testing gap internally - we don't really have test coverage for the OpenMP backend. I'm working on changing that. We do have an open TODO item for repairing support for the OpenMP backend.

Probably related:
The following extremely simple example fails to compile (the corresponding bug prevents building the PETSc library with CUDA 9.2):
#include <thrust/device_vector.h>
#include <thrust/complex.h>

void test_function() {

  thrust::device_vector< thrust::complex<double> > v;
  v.resize(1);

}

@GregDMeyer, that's with the OpenMP backend?

@brycelelbach, the example from @GregDMeyer also fails with the CUDA backend:
$ nvcc -c complex.cu
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/complex/complex.inl(187): error: no instance of overloaded function "thrust::complex<T>::real [with T=double]" matches the argument list
            argument types are: (const thrust::reference<thrust::complex<double>, thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>, thrust::use_default>)
          detected during:
            instantiation of "thrust::complex<T> &thrust::complex<T>::operator=(const R &) [with T=double, R=thrust::reference<thrust::complex<double>, thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>, thrust::use_default>]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/system/detail/sequential/general_copy.h(76): here
            instantiation of "thrust::detail::enable_if<thrust::system::detail::sequential::general_copy_detail::reference_is_assignable<InputIterator, OutputIterator>::value, void>::type thrust::system::detail::sequential::general_copy_detail::iter_assign(OutputIterator, InputIterator) [with OutputIterator=thrust::complex<double> *, InputIterator=thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/system/detail/sequential/general_copy.h(112): here
            instantiation of "OutputIterator thrust::system::detail::sequential::general_copy(InputIterator, InputIterator, OutputIterator) [with InputIterator=thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>, OutputIterator=thrust::complex<double> *]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/system/detail/sequential/copy.inl(74): here
            instantiation of "OutputIterator thrust::system::detail::sequential::copy_detail::copy(InputIterator, InputIterator, OutputIterator, thrust::detail::false_type) [with InputIterator=thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>, OutputIterator=thrust::complex<double> *]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/system/detail/sequential/copy.inl(121): here
            instantiation of "OutputIterator thrust::system::detail::sequential::copy(thrust::system::detail::sequential::execution_policy<DerivedPolicy> &, InputIterator, InputIterator, OutputIterator) [with DerivedPolicy=thrust::detail::seq_t, InputIterator=thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>, OutputIterator=thrust::complex<double> *]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/copy.inl(37): here
            [ 15 instantiation contexts not shown ]
            instantiation of "OutputIt thrust::copy(const thrust::detail::execution_policy_base<DerivedPolicy> &, InputIt, InputIt, OutputIt) [with DerivedPolicy=thrust::cuda_cub::tag, InputIt=thrust::detail::normal_iterator<thrust::pointer<thrust::complex<double>, thrust::cuda_cub::tag, thrust::use_default, thrust::use_default>>, OutputIt=thrust::detail::normal_iterator<thrust::device_ptr<thrust::complex<double>>>]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/overlapped_copy.h(106): here
            instantiation of "RandomAccessIterator2 thrust::detail::dispatch::overlapped_copy(thrust::execution_policy<DerivedPolicy> &, RandomAccessIterator1, RandomAccessIterator1, RandomAccessIterator2) [with DerivedPolicy=thrust::cuda_cub::tag, RandomAccessIterator1=thrust::detail::normal_iterator<thrust::device_ptr<thrust::complex<double>>>, RandomAccessIterator2=thrust::detail::normal_iterator<thrust::device_ptr<thrust::complex<double>>>]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/overlapped_copy.h(126): here
            instantiation of "RandomAccessIterator2 thrust::detail::overlapped_copy(RandomAccessIterator1, RandomAccessIterator1, RandomAccessIterator2) [with RandomAccessIterator1=thrust::detail::normal_iterator<thrust::device_ptr<thrust::complex<double>>>, RandomAccessIterator2=thrust::detail::normal_iterator<thrust::device_ptr<thrust::complex<double>>>]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/vector_base.inl(546): here
            instantiation of "thrust::detail::vector_base<T, Alloc>::iterator thrust::detail::vector_base<T, Alloc>::erase(thrust::detail::vector_base<T, Alloc>::iterator, thrust::detail::vector_base<T, Alloc>::iterator) [with T=thrust::complex<double>, Alloc=thrust::device_malloc_allocator<thrust::complex<double>>]"
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/vector_base.inl(257): here
            instantiation of "void thrust::detail::vector_base<T, Alloc>::resize(thrust::detail::vector_base<T, Alloc>::size_type) [with T=thrust::complex<double>, Alloc=thrust::device_malloc_allocator<thrust::complex<double>>]"
complex.cu(7): here

1 error detected in the compilation of "/tmp/tmpxft_000051e5_00000000-6_complex.cpp1.ii".

Thanks @FilipeMaia!
@brycelelbach I didn't try with the openMP backend, only with CUDA. But if you look at the original question--it's actually referencing the CUDA backend (though a bit ambiguous):

The following code fails to compile for cuda backend

Yes it's the cuda backend for which I had an issue.
I didn't realise that it had been misunderstood that I had an issue with the openmp backend.

Here's another, hopefully simpler, function reproducing the same problem:
#include <thrust/device_ptr.h>
#include <thrust/complex.h>

void test_function() {
  thrust::complex<double> a;
  thrust::device_ptr<thrust::complex<double> > p;
  a = *p;
}

$ nvcc -c complex3.cu
/usr/local/cuda-9.2/bin/../targets/x86_64-linux/include/thrust/detail/complex/complex.inl(187): error: no instance of overloaded function "thrust::complex<T>::real [with T=double]" matches the argument list
            argument types are: (const thrust::device_reference<thrust::complex<double>>)
          detected during instantiation of "thrust::complex<T> &thrust::complex<T>::operator=(const R &) [with T=double, R=thrust::device_reference<thrust::complex<double>>]"
complex3.cu(7): here

1 error detected in the compilation of "/tmp/tmpxft_000044a6_00000000-6_complex3.cpp1.ii".

I would have expected thrust::reference<T> or thrust::device_reference<T> to have a conversion-to-T operator that would handle this case. Doesn't it? I don't know why thrust::complex would cause problems.

Maybe the issue is that thrust::complex<T>::operator=(const R&) is a better match than the conversion operator. std::complex does not have a templated operator=. This could be the issue.

I think @jaredhoberock is right. Removing thrust::complex<T>::operator=(const R&) fixes the problem.

GH #928 / NVBug 2341455 is probably a duplicate of this.

@pijyoi Can you please check if what you are trying to do works on the version of Thrust shipped with CUDA 10.0?

@griwes I have just downloaded CUDA 10.0 and the code snippet included in this issue compiles successfully.

Fixed as of CUDA 10.0

I suggest you make a comment pointing to this issue instead of just wrapping the relevant code in #if 0 #endif, as it's not entirely obvious what's the problem just by looking at it.


Correct test descriptions for fuzzing

Description
Fuzzing test descriptions should be easily understood by user.
Text "mutated from 0" is a bit confusing because users know about fuzzing mechanisms very rarely.
Need to consider a better way to inform the user why the particular value is used.
Expected behavior
Remove unneeded information from test description - it is required for the test run report and thus should be easily read.
Environment
IntelliJ IDEA 2022.1.4
JDK 8 / 11
Potential alternatives
Probably add information that the value is random to the Java doc.
Context
For example:
utbot-sample/src/main/java/org/utbot/examples/recursion/Recursion.java
methods: factorial, fib
    @DisplayName("fib: n = 1024 (mutated from 0)")

    @DisplayName("factorial: n = 134217728 (mutated from 0) -> throw StackOverflowError")

@amandelpie @Markoutte @onewhl
Could you please consider whether this change is reasonable?

I really like that @Markoutte added information about real values, it's very useful!
And I agree with @alisevych  - "mutated from" could make a user feel confused. In general, users might be not familiar with fuzzing/symbolic execution terms, so let's skip this information.

Probably I could move this information to the javadoc a little bit later.
I have a question: is it a new behavior added some days ago or old? I didn't faced with this example yet

@amandelpie it's there since #713. I wanted to show that some values were somehow (randomly at the moment) generated from another values. Now, numbers and strings are mutated. Also, mutation mechanism works for regexes, but it just regenerates values from a regex pattern.

@Markoutte looks like I need to pass it to you


Operation names that are "Not currently used" need clarification

In the Notes column for "Activities audited by Power BI", please clarify "Not currently used" by replacing it with either "No longer used" or "Reserved for future use", as appropriate in each case.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0e8bce0-95c1-07f7-d3a3-a1c22bd21f29
Version Independent ID: dddd1e30-4a88-1293-1264-3214cc4b6dc8
Content: Using auditing within your organization - Power BI
Content Source: powerbi-docs/service-admin-auditing.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Thanks for your comment, @TimCurwick. We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

This is all the information we currently have about the state of the audit events. At this point, we recommend using only those not marked "Not currently used". We'll update the table if we get more information.


Download Mondo and import owl into neo4j

Hi to everyone,
My name is Jordi Valls, and my question is about download mondo...
I click the following links that in github are available;
http://purl.obolibrary.org/obo/mondo.obo
http://purl.obolibrary.org/obo/mondo.json
http://purl.obolibrary.org/obo/mondo.owl
But unfortunately nothing happens...
The same from the last release:
https://github.com/monarch-initiative/mondo/releases/tag/v2021-06-01
So my question is about if I require to fill some requirement to use mondo or something happens with the links...
I just can download the mondo.json, .owl and .obo from this link:
http://obofoundry.org/ontology/mondo.html
Finally just I want to know if the formats of owl or json are ready to upload into neo4j platform, or I need to do some changes, because I try to upload the mondo.owl but seems that doesnt work properly.
Thanks for your time,
Jordi

Hi @Jordi-Valls,
This may be an issue with Chrome blocking downloads from an http URL. Can you try copying and pasting the links into a new browser and see if that works?
Thanks!
Nicole

https://purl.obolibrary.org/obo/mondo.obo

If you go to the last release and scroll down, you can download everything by clicking on the files! At least I can?

Hi @matentzn its true I can download the files from the last relase :D thanks. Besides Is also true Nicole, if I use firefox I can download all files, maybe is something of my chrome browser, my apologise.
Finally, just in case, if you want to use the mondo.owl in neo4j, you have to use the following command to import the file in this platform:
CALL n10s.onto.import.fetch("file:///path/mondo.owl", "RDF/XML")
THanks for your help!

I think this can be closed, please reopen if there are any other questions. thanks!


Implement CH4 Intro

Pretty straightforward, we should create intro pages for Chapter 4
Link to Figma

I can do this as well as the outro page for this chapter.

Completed


Add CONTRIBUTING.md file

Provide instructions on how developers can contribute to MathBeast. Include the following:

What libraries does MathBeast use?
What code conventions should be used for html, css and javascript?
Explain code review workflow
How does CSS code get compiled?
How to set up gulp?

Additionally, provide link to CONTRIBUTING.md in README.md

@mmenavas Your instructions within the CONTRIBUTING.md are clear and well-laid out. I got up and running in a couple minutes!


ntfy user commands don't work if auth_file is used in config instead of auth-file

Essentially what the title says.
Deployment / Version used
podman run -d -v ./server.yml:/etc/ntfy/server.yml:ro -p 80:80 --name=ntfy docker.io/binwiederhier/ntfy:v1.27.2@sha256:19eeaec60fda9dfd4757f79610494f5ec78ece274c995f032edc68238720e0a2 serve

Reproduction

specify auth_file in server.yml e.g. auth_file: "/var/lib/ntfy/auth.db"
start container (see above)
exec into container e.g. podman exec -it ntfy /bin/sh
execute ntfy user command and observe output:

$ ntfy user add myuser mytopic rw
option auth-file not set; auth is unconfigured for this server

Once I switch from auth_file to auth-file in the server.yml everything works. This contradicts the statement at the top of the server.yml

Good catch. This is just an oversight. Fixed in https://github.com/binwiederhier/ntfy/commit/30c8d6b02b6b12f3f2d0f372485a5c7a8d08be62, which will be a while since I just released yesterday.
Thank you for reporting and the detailed report!

Thanks for fixing this so quickly!
I'm totally fine waiting for the next release, the workaround is easy enough :D


Correct App link

Correct App link
https://cdn.keralarescue.in/app/keralarescuecamp.apk

Is there any direct playstore link?

no

shall I update the link ?

yes


Unsuperivsed Clustering Analysis

Since there is no ground truth for API risk assessment, we should use clustering analysis to check for the vanity of risk labels.

The unsupervised clustering has been provided to the partner for further analysis. Once they provide feedback in terms of validity of risk labels based on the unsupervised clusters, the features in supervised models can be adjusted accordingly.


syntax:fix(wordlist): Fixed whitespace in "LFI-gracefulsecurity-windo…

…ws.txt"
space > newline

name: 'Pull request'
about: 'Create a pull request to improve SecLists'
title: '[Pull request]: '
labels: 'enhancement'
assignees: ''

Describe the added commits

Purpose of pull request

Source

Additional context

Good catch @ola456 !


[Feature]: Let us config which fs should be used for jest

🚀 Feature Proposal
Currently my app will output some files to memfs and I need to require a file from there. In order to do this, I have to use fs-monkey to patchFs and patchRequire.
BTW, I only need to patch the 3 basic fs methods in order to get require to respect memfs. They are statsSync, realpathSync and readFileSync.
All behaviours are good until my end-to-end test. As jest has its own resolver and use graceful-fs, I am unable to tell jest to use my patched version fs to respect the files in memfs
I went through the history about jest monkey patching fs. Is it possible to let us pass our fs object for jest to use.
// jest.config.js

module.exports = {
  ...
  fs: (jestFs) => {
    // consumer has to return fs-like object
    return jestFs // default case. this should be handled on jest side without explicitly specifying it
    // or
    let myFs = unionFs([jestFs, memfs])
    return myFs
  }
  ...
}

Motivation
It enables consumers to use their Fs to test their code.
Example
No response
Pitch
Because Jest is not using node fs module

Happy to take a PR, but I'm not sure how clean it'd be. most every single module in the monorepo would have to care about it and have it in their API


⚠ Bofrost.es has degraded performance

In e5f82f2, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1623 ms

Resolved: Bofrost.es performance has improved in b33e563 after 6 minutes.


jsx-no-leaked-render silent error reporting for empty string react >=18

resolves #3479

Duplicate of #3488; let's keep both open, though, to keep them in sync.

We can close this one @ljharb right?


Added MD5 sums for all int8 official models.

This PR adds an md5 hash to all of the official models. This hash will be used to check consistency between github repos, as these models will end up in multiple places.

Per our email thread I also need to add MD5s for the fp32 tflite models as well. @colbybanbury I'll wrap thse up today.

@petertorelli Since mine was the only folder where models were hidden in a deep directory structure, I've now added them in a better location with better naming. md5 files are already included for these
https://github.com/mlcommons/tiny/pull/71


[INLONG][feature][DataProxy] add multi-pulsar cluster config demo

add multi-pulsar cluster config demo config
Fixes #1938

Codecov Report

Merging #1940 (45fdd03) into master (fccece5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1940      +/-   ##
============================================
- Coverage     12.28%   12.28%   -0.01%
+ Complexity     1159     1157       -2
============================================
  Files           413      413
  Lines         35225    35225
  Branches       5542     5542
============================================
- Hits           4329     4327       -2
  Misses        30127    30127
- Partials        769      771       +2

Impacted Files
Coverage Δ

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
45.31% <0.00%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccece5...45fdd03. Read the comment docs.


Consolidated api second attempt

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Add a TL;DR when description is extra long (helps content team)
Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

PR fixes following issue(s)
Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features

Introduced a new API for consolidated page data fetching.
Added a new feature flag for enabling consolidated page load fetch.

Improvements

Improved app loading performance by using consolidated data fetching.
Enhanced Cypress tests with updated wait commands and response handling.

Refactor

Refactored AppRouter to use hooks and functional components.
Updated various reducers, actions, and sagas for new loading state management.

Tests

Adjusted existing Cypress tests to align with the new consolidated data fetching process.

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview skip-tests=true

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>


Table View reload related issue

It seems that there is a problem expanding children in swift 2.2.
Probably it's relevant to ++ symbols.
At expandItemAtIndex function i replaced
let insertPos = index + 2 (instead of 1)
let indexPaths = (0..<currentSubItems.count).map { _ in NSIndexPath(forRow: insertPos, inSection: 0) } (removed ++ symbols)
I'm getting the below exception.
'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 0.  The number of rows contained in an existing section after the update (26) must be equal to the number of rows contained in that section before the update (22), plus or minus the number of rows inserted or deleted from that section (1 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out).'

In my case, this solution really helped me.
let insertPos = index + 1
let indexPaths = (0..<currentSubItems.count).map { idx in NSIndexPath(forRow: idx + insertPos, inSection: 0) }

@support3ds Yes you're right I missed the ++ symbol  deprecated in Swift 2.2, I have update the project to fix it, thanks for the observation, be careful idx always go from [0, currentSubItems.count], it's better to fix it inside the closure like this:
 // position to start to insert rows.
 var insertPos = index + 1

 let indexPaths = (0..<currentSubItems.count).map { _ -> NSIndexPath in
        let indexPath = NSIndexPath(forRow: insertPos, inSection: 0)
        insertPos += 1
        return indexPath
 }

As the closure capture values, it could be used here.


download results button state is broken

When downloading the results, the button stays on "please wait" after the download was completed.
Original issue by @bmesuere on Mon Oct 28 2013 at 11:21.
Closed by @bmesuere on Thu Nov 21 2013 at 18:20.

http://stackoverflow.com/questions/19727151/retrieve-the-status-of-a-form-submission-from-javascript
Original comment by @bmesuere on Fri Nov 01 2013 at 14:03.


chore(main): release 10.0.2

:robot: I have created a release beep boop
10.0.2 (2024-11-21)
Bug Fixes

tools: #467 reading of files on disk (034ed9e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v10.0.2
:sunflower:


Figure out how the kanban board works

Here's a shortcut for the board: https://github.com/AureumChaos/LEAP/projects/1
it's kinda weird that you can create more than one board per github project.  That's a different model from gitlab, which only allows for a single kanban board; moreover, gitlab boards piggy-back on their issue tracking system, whereas github keeps the issues separate from project boards.  Interesting.

I guess having more than one board gives us more options, although I doubt
we'll use more than one anytime soon.
Effective Python doesn't seem to have much to say about modules, but
reading the Cookbook gave me a solution to a problem that was giving me all
sorts of grief, so that's good.
Jeff
On Fri, Oct 12, 2018 at 9:53 AM Mark Coletti<EMAIL_ADDRESS>wrote:

Here's a shortcut for the board:
https://github.com/AureumChaos/LEAP/projects/1
it's kinda weird that you can create more than one board per github
project. That's a different model from gitlab, which only allows for a
single kanban board; moreover, gitlab boards piggy-back on their issue
tracking system, whereas github keeps the issues separate from project
boards. Interesting.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AureumChaos/LEAP/issues/1#issuecomment-429333197, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AI_P8b2c4MN9jtRqkwaR__Ylc1emotayks5ukJ7BgaJpZM4XYaUa
.

On Fri, Oct 12, 2018 at 10:32 AM Jeff Bassett<EMAIL_ADDRESS>wrote:

I guess having more than one board gives us more options, although I doubt
we'll use more than one anytime soon.

True.  I can easily envision multiple projects sharing the same github, so
it's nice that that flexibility exists.  I still find gitlab's solution of
piggy-backing kanban functionality on top of the issue tracking system
simpler and a little more elegant.  If more than one project shares a
single gitlab repository, you can always use labels to differentiate
tasks.  Admittedly, this is moot since we're using github, and we'll only
be using the one project board, anyhoo.  I'm still enjoying comparing the
two different git web facades.

Effective Python doesn't seem to have much to say about modules, but
reading the Cookbook gave me a solution to a problem that was giving me all
sorts of grief, so that's good.

What was the problem giving you grief?
Meanwhile, I've pushed Functional Programming in Python on my "to read"
list since it's short, and has relevant material that may "prime the pump"
for reading the appropriate parts of Effective Python and the Python
Cookbook. (I can pass along the softcopy if you need it.)
I tell ya, I'm really excited about these new python features such that I'm
very confident that a much leaner and meaner LEAP design is possible.
Moreover, we'll be doing things that no other python-based EC library is
doing as many of the competitors were written with 2.x in mind, or are
otherwise barely cognizant of the python 3 feature set.
Speaking of which, here's the github for inspyred:
https://github.com/aarongarrett/inspyred .  I'd be curious to learn your
opinion of it.  Again, he gets his, um, "inspiration" from Ken's book, so
there's that.
-- Mark


Hello, it seems that when I switch to the awesome styler theme, the context menus are unaffected.

Info:

OS: Mac 14.4.1
Logseq ver: 0.10.9
Plugin ver:
[ ] ⚠ Do i have issue with DISABLED my custom.css?
[ ] ⚠ Do i have the same on default theme? any of the preset custom themes like "nord"

Description:
A clear and concise description of what the bug is...... When I change the theme the context menus stay the same default color from the basic Logseq theme.
To Reproduce:
...
change themes and open the context menu (right click)
Expected behavior:
...
Screenshots
If applicable, add screenshots to help explain your problem.
https://is.gd/HjdQaN
Attach files
Add (via drag-n-drop) .zip with .md files (if it needs) to help with bugfixind
Thank you.

Likely related issues: #89 #104 #106 #110
This only happens on Linux and MacOS for whatever reason. It works fine on my Windows work laptop. Many elements do not get themed, like some context menus, the calendar widget created by Banners+Block Calendar, tags, and internal links. No matter what theme is chosen, these elements seem to retain Solarized Dark coloring.


Add three new classes mentioned in issue #65, #66 and #67

Added three new major classes 'dietary_role' #65, 'nutritional_functional_attribute' #66 and 'dietary_material_physical_attribute' #67.

The new changes are ok and ready to be merged.

@LilyAndres looks OK for the most part the only thing I'd wanted to have added for this release is to (re)assert that concentration of is subclass to PATOphysical object quality. Perhaps on the next release.
The other thing that's unclear to me is exactly what nutritional functional attribute is going to be and where it should be rooted, but we'll get some clarity on that once we have some subclasses for it.
Thanks for making a release!


Update weight algorithm on nodes

Update the weights based on prior success/failure at selecting correct value. Updates down and up.

This needs to update down and up. Also needs tests for weight updates.


Request: add Bing

We have Ecosia and Brave, but not Bing? I anticipate more users using Bing since they're slowly launching their AI.

Hi, sorry for the late response.
You are right, it would be nice to support Bing.
I start looking at it and there is an issue: On desktop, Bing is statically replacing the real URL with a click tracking link.
To block bad results, we need to use this filter: bing.com###b_results cite:has-text("qastack.fr"):upward(.b_algo).
This filter uses has-text() and I don't think it will have great performance. Anyone has a better idea?

Heya @quenhus, I looked into it and could not find a better way to implement in with uBO. That's why we'll be removing Bing support from letsblock.it instead of changing it to has-text().
We should redirect people to https://github.com/iorate/ublacklist instead, that can run this filtering more efficiently, by amortizing the URL extraction cost over the whole website list, instead of repeatedly doing it.
You could consider publishing the dataset as an ublacklist subscription [see documentation].

Hi,
Thanks a lot @xvello. Indeed, I recommend uBlacklist to remove bad domains from Bing results.
All my filters are already fully compatible with uBlacklist. I recommend to activate the option "Add rules blocking whole sites by default" to block all subdomains.
Links for uBlacklist subscription:

github_copycats
wikipedia_copycats
stackoverflow_copycats
npm_copycats
seo_spam


add health checks to the frontend

Related Issue or Background Info
Poking around in Azure and was setting up availability
Wanted to add a health check for the frontend
Changes Proposed

add /health/ping/ to verify that the app built and some level of routing is working
add /health/commit/ to display the current commit

This seems like it works from the browser, but not from curl right?

This seems like it works from the browser, but not from curl right?

This is a great point. curl will return a 200 but html response will be the same for all pages. You won't be able to get the commit hash from CURL.
Let me fix that

fix curl issue by creating a txt file served at https://demo.simplereport.org/app/static/commit.txt

Looks good to me! Once this lands, we can make some changes to the Azure health checks to setup a regular ping!


convert to use tokio 0.1

All the tests pass! 🎉 (at least locally -- let's see what CI says)
Spend this morning rebasing due to 0.12.x moving so fast!
Fixes #1443

Woo! Nice! (And sorry about 0.12.x, I had been rebasing master onto it for a while, assuming most people weren't actually depending on its history 😭 ).

No worries, I was just surprised by how quickly it had moved since I started a couple of days ago :)
One thing to note here is that I've tried to keep the API mostly the same (biggest exception being Server::run). It sounded like it would be a good idea to postpone improving the API later after the "raw" tokio integration landed. Let me know if you feel different!

The hanging test is a weird one, it works on my machine (OS X), so I can't reproduce at the moment. I'll try to rent an AWS instance later to try and reproduce on Linux.

I'll try to rent an AWS instance later to try and reproduce on Linux.

Don't bother! I can debug it myself.

Thanks, much appreciated!
In other news, my tokio PR to split off tokio-tcp (https://github.com/tokio-rs/tokio/pull/224) was merged, so we can hopefully drop the direct dependency on tokio soon-ish.

For the hanging test, it's a combination of mutexes in the mock duplex code, and using the ThreadPool executor. The hang went away when I made sure that the task.notify() and the read or write happened without releasing the lock. But the test fails in an error since the tasks are on separate threads, but with only 1 core and mutexes, the code can't happen in the order that is being tested.
The test is specifically designed to be a series of events we can control, because its testing those series of events. I suspect that switching to the tokio's current_thread executor for that test will fix it.

Hmm, so the issue with current_thread is that it's not Send nor Sync, making it unsuitable for a custom executor.
The only way I can think of is to make it optional for Client to be Send, which would probably require tracking that as type state, e.g. Client<IsSend> vs Client<IsNotSend>.
Maybe there is another way to fix the tests so they could run on a multi-threaded executor?

Okay, so I think I fixed the initial problem by using a thread pool of size 1 as an executor. There are some other failures now on Travis that I still can't reproduce locally :/

I'll look into that test failure. Besides that, the benches don't compile XD.

So the failing keepalive client test is because of tasks being on separate threads, but with only 1 CPU, the order isn't preserved. Well, on one hand, it's good to find poorly written tests that break on multithreaded!
The test itself is ensuring that after we get a response back, a second request to same host should reuse the existing connection. However, knowing that the connection can be reused requires the Dispatch task to do some housekeeping after submitting the response back to the FutureResponse task. So, by the time the main thread has the response and starts a new request, the Dispatch task on the other thread hasn't had a chance to cleanup state and set itself ready for a new request, so it isn't back in the client's pool.
As a hack, we could just sleep the main thread for a few milliseconds, allowing the dispatch task to clean up...
Perhaps in a separate issue, the design of that can be changed, since changing this test definitely means that users may see on occasion requests not reusing a connection it could have.

Thanks for providing more info on that test! I thought I fixed that particular test earlier by introducing exactly the sort of thread::sleep that you suggested.
The latest Travis run showed two other tests failing instead: one with a ‚resource temporarily not available‘ error, and the other one (a dispatch test) timing out.
I‘ll try to fix the benches later!

Yay! CI is green! I'll see about merging this ... probably tomorrow, its getting late x_x

@seanmonstar Nice! I pulled your changes into this branch, just in case you had any other feedback you wanted to see addressed before merging.
AppVeyor builds seem to be failing both on this as well as your new-tokio branch, could that be related to our changes?

The issue on Windows was that we needed to call bind on the TcpBuilder before connect. All good now. I also loosened the requirement of Entity, such that the trait itself doesn't require Send, only when used in Client and Server and thus interacts with an Executor. That way, if people want to work with non-Send things, they still can, using hyper::{client, server}::conn.
I merged those changes into your commit, and merged it into 0.12.x here: https://github.com/hyperium/hyper/commit/603c3e4d2c6ebb3d495a85c4d9a8b36583eff3fc
Thank you sooo much!


DATA

https://www.c64-wiki.com/index.php/DATA
It seems like DATA is a way of storing a list of options for a variable and then each time READ is called it takes the next option in the list and assigns the named variable that value.

I've come up with a solution. It can be done using a list. DATA appends its values to the end, READ pops the first value in the list and sets its variable to that value.
There will need to be a step before running the program where all the DATA lines are read in otherwise it will have to search during execution and it will be terrible so this is the best solution.

Added


LUIS: Intents are limite to only 20 ?

Using LUIS as a NLP for our Bot it seems the intents are limited to 20. It's very few for a bot ...
I know we can provide multiple LUIS Id (but I assume it makes multiple HTTP Request ?)
How bot creator handle that ? Is it a technical limit ?

https://docs.botframework.com/en-us/technical-faq/#how-can-i-use-more-than-the-maximum-number-of-luis-intents
Feel free to ask more questions.

Yes in a Nutshell Dialog send an HTTP request for each model.
My question is more why only 20 / model ?

This limit is set due to performance reasons. But relaxing it is one of the top priorities on our roadmap, stay tuned :)

Is there an easy way to add models more programmatically? besides just stacking up [LuisModel] annotations?

You can use the constructor that takes a number of ILuisService:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Dialogs/LuisDialog.cs#L146
There's no requirement to use the LuisModelAttribute on the class - you can construct a LuisService from the LuisModelAttribute and then pass that ILuisService to the constructor.
If you're using autofac or equivalent, you should be able to resolve all ILuisService implementations from the container.

@willportnoy Would it be possible to refactor LuisModelAttribute into a new ILuisModel interface and have the LuisService constructor take that as a parameter instead? I feel like that would be more scalable and would help for projects like ours that load these values from a config.
I can look into a PR for this if there's interest :)

@cglong LuisModelAttribute is just the POCO container for the configuration - as in those items, you can instantiate the LuisService with LuisModelAttribute instances that you obtain from whatever source you like (e.g. your DI container).
I'm not adverse to the interface, if you feel inheriting from attribute makes the LuisModelAttribute too heavy.

@cglong thank you for the pull request - we've merged it, so I'm going to close this issue.  Feel free to open a new issue for further discussion.

@CarolHanna It seems the limit has been raised, I currently have 23 intents. But what exactly is the new maximum? I can't find anything in the docs.

@mikob any update on the maximum?

@rnjailamba I don't see it documented on https://www.luis.ai/Help - if you open a top-level issue, we can ask the appropriate people to respond.

Hey!, check this out https://docs.microsoft.com/en-in/azure/cognitive-services/luis/luis-boundaries
The limit for intents was raised from 80 to 500 that is a massive improvement hurray! 🥇
Please check the mention link for the limits on other things as well such as entities, I recommend to go with a single LUIS app and a single LuisDialog instead of choosing a top level (RootDialog) and multiple child level dialogs or the factory pattern for finding the best fit intent method from a number of LuisDialogs until unless you are about/near to reach the limit, when you are about to reach the limit only then think of the design changes, don't overcomplicate from the beginning itself and try to focus on the development, that's what I would suggest :)
Happy coding!