Vrouter fixes pylint

In my dreams, all Python code pass through pylint and must validate before a merge.
This merge request is becoming quite big, maybe too much; I'd like to have the owners opinion.
It follow the previous pull requests:

#1575

PCextreme/cloudstack/pull/2

#1547

kudos for all the hard work! Most of this should've been done a long time ago as pylint is one of the first firewalls of code quality ensurance.
Side notes:

no fan of %s syntax; recommend further refactoring to employ .format() which should make the code a lot more elegant.
Strings oughta be single-quoted unless double quotes are necessary

e.g.:
-    self.fw.append(
-        ["nat", "",
-         "-I PREROUTING -i ppp+ -m tcp --dport 53 -j DNAT --to-destination %s" %
-         local_ip
-         ]
-    )
+    self.fw.append([
+        'nat', '',
+        '-I PREROUTING -i ppp+ -m tcp --dport 53 -j DNAT --to-destination {}'.format(
+            local_ip
+        )])

Hi @The-Loeki, and thank you for your prompt comment!
For your side notes:

this is mostly a preference, I don't care what you use but here are my argument for the %s:

more portable than the .format() (Python 2.4 → Python 3)
coherent with logging methods; ie: logging.debug('foo {}', 'bar') = TypeError, the correct syntax is logging.debug('foo %s', 'bar')

I also prefer single quotes, especially because double quotes are never "nessary" (in Python single and double are equivalent)

I didn't want to change "too much" (well, I think my patch is already too much; we should focus on documentation after that); if I did replace all double quote with single, for example, I would break git blame way too much for my taste.
But I'm totally willing to put some more work for conformity, if there is a will for it upstream ;^)

Hi :) sorry I was unable to process your request to merge your PR with mine, as you can probably tell by now this would've oversized & muddied both PR's ;)
Depending on the uptake of the CS team here I'm quite willing to help you with it, because as I mentioned IMHO this should've been done from the start on.
So the .format() syntax is less compatible as you mention. It is however only incompatible with long-deprecated Python versions and CS SysVM's are compatible so that's not really an issue.
While of course it is a matter of personal taste, the official message from Python pplz however is that .format() is intended to replace the %s formatting: https://docs.python.org/2/library/stdtypes.html#str.format , which is why I and the other OSS projects I work on prefer it.
The logging one is an excellent remark though, wading through the docs I notice that they've added the .format() syntax as per 3.2: https://docs.python.org/3/howto/logging-cookbook.html#use-of-alternative-formatting-styles
I'm not sure from the top of my head which version the SysVM's are using, but if it's not Py3 it oughta be (here comes the next big-ass PR ;) )

@romain-dartigues can you rebase against latest master and push -f?

OK, will get back on it during the week.

Done.
Le me know what you think about it (I don't think Jenkins failed because of my edits?).

@romain-dartigues can you fix the conflicts thanks

Thanks @romain-dartigues for your PR, I've included similar changes in PR #2211 and added pylint/pep checks to Travis. Due to duplicate nature of work and that this PR has not received much activity in last 1+ year I'll close this. Many thanks again for your hard work and initiative.


Implement Base Serializer

Provide implementation for stubbed base serializer functions.

How are we handling documentation here? Public APIs should be documented well in the code. In terms of the private functions, are there comments we can bring from another language implementation?
For example, I was unclear what the tq function did without reading the code. I'd prefer getting a handle on documentation where it makes sense first.

Is there anything that we can unit test at this point?

Is there anything that we can unit test at this point?

I think we should make sure we have enough implementation to be able to write meaningful  unit tests and start adding unit tests.

How are we handling documentation here? Public APIs should be documented well in the code. In terms of the private functions, are there comments we can bring from another language implementation?
For example, I was unclear what the tq function did without reading the code. I'd prefer getting a handle on documentation where it makes sense first.

The logic (including comments) you see here is all from the dot-net implementation. I can take a look at node and python and see if there are useful comments I can borrow over here.

Is there anything that we can unit test at this point?

This base serializer is essentially an abstract class that will be implemented by scalar serializer and struct serializer. I expect unit tests to be added once those are implemented.


bundle lock --add-platform is recommended, but fails with error

Complete repro Gemfile:
source 'https://rubygems.org'

group :debug do
  gem "ruby-debug", :platform => "jruby"
  gem "byebug", :platform => "mri"
end

Pretty reasonable, platform-appropriate debuggers, right?
Running in jruby <IP_ADDRESS>, with bundler 1.16.3.
$ bundle install
The dependency byebug (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for java but the dependency is only for ruby. To add those platforms to the bundle, run `bundle lock --add-platform ruby`.
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Using bundler 1.16.3
Using columnize 0.9.0
Using linecache 1.3.1 (java)
Using ruby-debug-base 0.10.6 (java)
Using ruby-debug 0.10.6
Bundle complete! 2 Gemfile dependencies, 5 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

Okay, it's complaining that I have an MRI-specific gem in there but am on JRuby... not totally sure why it's complaining, this seems to suggest that platform-specific deps will always result in this complaint/warning, since the only point of them is to be sometimes not installed?
But okay, it's suggesting something I should do. bundle lock --add-platform ruby  Okay, let's try.
$ bundle lock --add-platform ruby
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Bundler could not find compatible versions for gem "ruby-debug-base":
  In snapshot (Gemfile.lock):
    ruby-debug-base (= 0.10.6)

  In Gemfile:
    ruby-debug java was resolved to 0.10.6, which depends on
      ruby-debug-base (~> <IP_ADDRESS>)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

I have no idea what this means or what I'm supposed to do about it. Is it a bug that this error message is happening at all?  I think so maybe?  It's like... you can't do bundle lock --add-platform ruby if you are in JRuby and have some JRuby-specific gems... but that seems to make bundle lock --add-platform kind of not so useful, if that's what's going on?  I don't entirely understand what bundle lock --add-platform is supposed to do though.
Running bundle update doesn't do anything useful, just repeats the same warning message from the original bundle install above.

This looks like a bug, thanks for the Gemfile that reproduces it!

So looking into this, it looks like the issue is that https://rubygems.org/gems/ruby-debug/versions/0.10.6 is a "ruby" platform gem, but its dependency
https://rubygems.org/gems/ruby-debug-base only has a "java" platform version 0.10.6. This causes issues with resolution, since bundler does not use the platform option in the Gemfile when reading in a lockfile, only the platform of the gem in the lockfile. And since Bundler sees a ruby platform ruby-debug, it thinks it needs to resolve ruby-debug (and its dependencies) for the ruby platform.

@segiddins is there any actions we can do to resolve this problem?

Maybe? Nothing simple tho, it would require a rethink of Bundlers approach to platsfoems and resolution

Hmm. I'm confused about if --add-platform will always result in this error, or just under certain cirucmstances?  Does --add-platform work at all?
When bundler says:

Bundler is installing for java but the dependency is only for ruby. To add those platforms to the bundle, run bundle lock --add-platform ruby.

Will this advice ever work?  In what circumstances is it intended? In what circumstances does it work?  (Did it used to work more than it does now, is it a regression?)

Note that you get this warning on rails new with rails 5.2.
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x86-mswin32 x64-mingw32 java`

However the recommended bundle lock command does work in this case.

Does --add-platform work at all

It certainly does work in the majority of situations it just doesnt work in this particular one due to a ruby platform gem that can't actually be installed on the ruby platform

Is the problem is that ruby-debug has buggy dependencies of some kind?

Yeah, sort of. It's just that it says it should be installable on any Ruby, but in fact its dependencies will only ever resolve for JRuby


play-services-ads:18.1.0 Breaking on Android 4

The version 18.1.0 of play-services-ads is breaking badly on android 4.
Here's a sample fatal error log
E/AndroidRuntime: FATAL EXCEPTION: main
    java.lang.VerifyError: c/d/b/a/g/a/FJ
        at c.d.b.a.g.a.KJ.f(com.google.android.gms:play-services-ads@@18.1.0:2)
        at c.d.b.a.g.a.Sm.a(com.google.android.gms:play-services-ads@@18.1.0:2)
        at c.d.b.a.g.a.bD.a(com.google.android.gms:play-services-ads@@18.1.0:31)
        at c.d.b.a.g.a.NY.a(com.google.android.gms:play-services-ads-lite@@18.1.0:23)

Hi, thanks for your query.
For support debugging your apps, can we request that you make a request on our support forum at https://groups.google.com/forum/#!categories/google-admob-ads-sdk/android - they will be able to help debug your issue with you efficiently.
Generally these issues are specifically for issues with the sample apps only, as more in depth support for your specific issues is handled by our support team on the forum.
When posting to the forum, please also provide specific details including any errors being seen and code showing how to reproduce the problem.
If you have a specific issue with a sample app, please provide details including which sample app and specific steps to reproduce the issue.


Programming exercises: Fix edge case when generating ProgrammingExerciseGitDiffReports

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added @PreAuthorize and checked the course groups for all new REST Calls (security).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

[x] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[x] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

A follow-up to #4732.
In rare cases it is possible that when creating an exercise Artemis tries to generate two reports at the same time for the new exercise. This would lead to both reports being saved and would then cause exceptions when trying to retrieve the report, as it is supposed to be a OneToOne relationship.
To prevent this I used a synchronized block.
However, the value this block would synchronize on was the programming exercise itself, which is not always the same. I realized on Hibernates caching system here, which apparently does not behave consistently.
Description

After talking with Stephan I removed both the synchronized block and the creation of the git-diff report when the exercise is created. This fixes the issue in most cases unless someone manages to commit to both repositories within one second. As this edge case is highly unlikely I chose to ignore it, as a fix for this would be to complicated for such a small issue.
I also added a statement to the getFullReport method to generate the git-diff report if it does not exist yet. This also means that you can now see the report for exercises that were created before the feature was introduced.
Steps for Testing

Prerequisites:

1 Instructor

Log in to Artemis
Create a new programming exercise
Click on the show diff button
The git diff report should not exist
Wait for the builds to finish
Click on the show diff button
The git diff report should exist

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

In case we absolutely want to have the diff for the newly created programming exercises (especially in the context of imports, it would make sense), a workaround for this could be to generate the initial diff directly during the creation/import of the programming exercises.

This would not work, as there are no Submission objects directly after creating an exercise. They are created when the VCS finishes, so I put the method call there.

We would then not generate the diff for the template which would be ok, because the exercise will be adapted with new commits anyway.

I did this now, as I agree that it does not make sense to create a git-diff report for the template exercise, that will be always changed.
The underlying issue still exists though, when someone manages to commit to both repositories within one second. I know that this is unlikely to happen, but I would highly appreciate it if you could tell me how to properly fix this.

I think you can directly create the initial programming submissions when creating / importing the programming exercises. This is better than creating them subsequently when the result is created. Then, you can also create the diff correctly once, which would be good for the import use case.
Regarding the simultaneous pushes in the template and solution repos. This is quite unlikely and we could ignore it. If you want to fix it, I see the following options.
You add a database unique constraint that only one diff per exercise can exist at the same time. Then, one of them would fail in the database, however not necessarily the second (correct) one. It might help to sync the deletion of the old and the creation of the new git-diff in a write transaction, but I'm not sure if this works easily. You need to be careful with transactions.
Ideally the transaction only covers a small part of the code (the database write operations, i.e. deletion and creation of data). git operations, in particular pulling the changes should be done before the transaction to make sure it is only open for the minimal necessary time. Otherwise there might again be overlaps with different nodes.

I think you can directly create the initial programming submissions when creating / importing the programming exercises. This is better than creating them subsequently when the result is created. Then, you can also create the diff correctly once, which would be good for the import use case.

This would also be my preferred method, but this change could have unforeseen consequences when creating or importing exercises. This is something I want to avoid, especially in a bugfix PR.
I have now solved the missing git-diff report by generating it (if it is missing) when requesting the report on the client.

Regarding the simultaneous pushes in the template and solution repos. This is quite unlikely and we could ignore it. If you want to fix it, I see the following options.

In that case, I would ignore it, as fixing this would be too complicated to be justified.

Ok sounds good for this PR.
Can you create the two submission on exercise creation/import in a follow up? I would prefer this, because at the moment, the submissions are created subsequently when the result is received which is not a good solution.

Is this related to the internal server errors:
org.springframework.dao.IncorrectResultSizeDataAccessException: query did not return a unique result: 2; nested exception is javax.persistence.NonUniqueResultException: query did not return a unique result: 2
        at org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:385)
        at org.springframework.orm.jpa.vendor.HibernateJpaDialect.translateExceptionIfPossible(HibernateJpaDialect.java:235)
        at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.translateExceptionIfPossible(AbstractEntityManagerFactoryBean.java:551)
        at org.springframework.dao.support.ChainedPersistenceExceptionTranslator.translateExceptionIfPossible(ChainedPersistenceExceptionTranslator.java:61)
        at org.springframework.dao.support.DataAccessUtils.translateIfNecessary(DataAccessUtils.java:242)
        at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:152)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.data.jpa.repository.support.CrudMethodMetadataPostProcessor$CrudMethodMetadataPopulatingMethodInterceptor.invoke(CrudMethodMetadataPostProcessor.java:145)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at jdk.proxy2/jdk.proxy2.$Proxy307.findByProgrammingExerciseId(Unknown Source)
        at de.tum.in.www1.artemis.web.rest.hestia.ProgrammingExerciseGitDiffReportResource.gitDiffReport(ProgrammingExerciseGitDiffReportResource.java:57)
        at de.tum.in.www1.artemis.web.rest.hestia.ProgrammingExerciseGitDiffReportResource$$FastClassBySpringCGLIB$$f85a6573.invoke(<generated>)
        at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)

They occur if I simply create a new Programming Task :)

Yes it is. The error can be ignored unless you want to use the new feature.


Can the slider be made to free scroll?

The are a multitude of paging options, but I can't see if it's possible to configure the slider it a free scroll mode (in other words turn off paging). Is it possible in it's current form?

nope, not yet.


how to get the very proxy I am using?

I am building my own proxy pool with the help of scraproxy.
But I need to take anti-blacklisting into account.
How I get proxy worked in Playwright?
        // 浏览器实例
        const browser = await playwright[randomBrowser].launch({
            proxy: {
                server: 'http://localhost:8888',
            },
        });

It seems that scraproxy rotate IP for me, but I need to remove blackedlisted ip.
So how can I get the exactly proxy ip I am using?
Please help.
Thanks.

Hi @cnscorpions,
it's probably a bit late but it might help others.
The proxyname is in the response headers x-cache-proxyname.
So when you catch the proxy and stop it with a post request
POST http://localhost:8889/api/instances/stop
{
  "name": "<name of the proxy>"
}

Hope it helps


Tweak recorded data graph color

Revert color of y-line to be green as it is in the prototype version
Before

After

Oops!


Add return values to GLFW set callback functions

The GLFW backend for ImGui sets input callbacks which get discarded when subsequent calls are made to window.set*Callback functions. Adding the return values to these functions allows the caller to handle cases where the callbacks have already been set, without the need to reimplement the ImGui backend input handling.

Thanks!


fix: Add missing private dns zones to applicable policy assignment and module

Overview/Summary
This pull request includes significant updates to the infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep file and related documentation. The main changes involve adding a new parameter for the location of Private DNS Zones, updating the list of Private DNS Zones, and modifying policy assignment parameters.
Key Changes:
Parameter Additions:

Added parPrivateDnsZonesLocation parameter to specify the location of Private DNS Zones.

Variable Updates:

Introduced varGeoCodes mapping for various geographic codes and varSelectedGeoCode to select the appropriate code based on the location parameter.

Private DNS Zones List:

Updated the varPrivateDnsZonesFinalResourceIds to include new Private DNS Zones and removed some existing ones.

Policy Assignment Parameters:

Modified the modPolicyAssignmentConnDeployPrivateDnsZones module to reflect the updated list of Private DNS Zones in the policy assignment parameters.

Documentation:

Updated the generateddocs/alzDefaultPolicyAssignments.bicep.md file to include the new parPrivateDnsZonesLocation parameter.

Related Issues/Work Items
Fixes #897
This PR fixes/adds/changes/removes

Adds all missing dns zones from policy set definition file

Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[ ] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues
[ ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[ ] Updated one or more of the following tests (if required)

Unit
Linting
E2E (End-To-End)
ValidateAzCloud (Base validation in Azure Cloud)
ValidateMcCloud (Base validation in Azure China Cloud)

[ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)


Retrieve init container logs from the kubernetes pods

folded this into https://github.com/dremio/dremio-diagnostic-collector/issues/6


chore: install pg_graphql extension

To remain dormant for now.

I've updated the steps to instead emulate the steps taken in the Dockerfile. One additional step is to run /sbin/ldconfig -v to update the links and cache for the shared libraries, in particular, /usr/local/lib/libgraphqlparser.so. Beforehand, the following error was returned upon executing create extension if not exists pg_graphql cascade;:

ERROR:  could not load library "/usr/lib/postgresql/lib/pg_graphql.so": libgraphqlparser.so: cannot open shared object file: No such file or directory


os.path.realpath's strict arguments only in 3.10

With debian bookworm already supporting 3.11, i think its safe to require 3.10 as a minimum python version.  There is a 3.10 backport for debian bullseye: https://community.home-assistant.io/t/home-assistant-core-python-3-10-backport-for-debian-11-bullseye/528439


Rename model to controller

I would like to propose renaming the "model" stuff to "controller". The reason for this is because if you look at config/fixtures/model.js, it's not loading the Sails models but instead loading the Sails controllers.
"Model" is a confusing and inaccurate name for this.

I also noticed the hook is comparing the Model (controllers) count to the count of sails.model: https://github.com/tjwebb/sails-permissions/blob/v1.2.1/api/hooks/sails-permissions.js#L37
If we have models with no controller it won't match up.  Also may want the fixtures to do some cleanup if models no longer exist (also throwing off the count).

I misread this code, it looks like it is in fact storing the model information and not the controller information, but it's confusing since the way this is written, there must be a controller for the model for the model record to get created and if there is no model record for the model/controller, there's no way to map the actions to permissions.
There are probably some other issues around this, but for now the notion of renaming "model" to "controller" is not really appropriate.


Import Excel with Color Cells and Render in ag-grid

I've an excel spread sheet (xlsx) with some data values and colors on it. My project need to import that excel sheet (exactly with all its cell background color and data) and show it in data grid (currently using ag-grid).
After I've done some research, I can get the styles of the Array by using 's' values. But 's' value is only available in worksheet object, and when i convert the worksheet into JSON by using "sheet_to_json", i couldn't get the 's' value anymore.
Is there anyway to get that 's' value or, is there any suggestion to show that style into ag-grid?
sorry, I'm just just a beginner and question may be dumb.
Thank you.

We offer this in the Pro compendium.  Since companies have paid for the features already, it would be unfair to them if we turned around and made it available as open source.  We have a longer comment in a gist.

can you share the code

how to uploaded data bind to grid. please share the sample code

https://next.plnkr.co/edit/?p=preview&utm_source=legacy&utm_medium=worker&utm_campaign=next&preview
On Mon, Dec 9, 2019 at 6:24 PM sureshbabu99<EMAIL_ADDRESS>wrote:

how to uploaded data bind to grid. please share the sample code
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SheetJS/sheetjs/issues/1104?email_source=notifications&email_token=AN4IBVD6J3N5CXZG4KFBJ5LQXY5XHA5CNFSM4E7L2EJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJCFQQ#issuecomment-563225282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN4IBVBADEHYVCPK5XA7LOLQXY5XHANCNFSM4E7L2EJA
.


fix(f8-analytics): removes unneeded jobs for vscode extension

removes unneeded jobs for vscode extension

Removes build master for VSCode analytics extension

[test]

[test]

[test]


fix session.workstation when passing only domain

This fixes:
C:/Users/MattWrock/AppData/Local/chefdk/gem/ruby/2.1.0/gems/rubyntlm-0.5.2/lib/net/ntlm/encode_util.rb:42:in `encode_utf16le': undefined method `encoding' for nil:NilClass (NoMethodError)

When passing in a :domain option

the ruby 1.9.3 travis job is failing but its unclear why. There is no log.

pinging @zenchild or @sneal feel free to add me to this repo/rubygem and I can merge/release if you like.

Looks good @mwrock. I also added you to the rubyntlm team so go ahead and merge.

awesome @zenchild . do you have rights to add me to rubygems? (matt@mattwrock,com) or can you release if possible?

I pushed it up, but I also added you as an owner.

thanks so much!


build: install library headers

To let 3rd party code to link and and build against libcamera-apps we also have to provide the header files.
Install the library headers into the system as well.
Credit to Jasem Mutlaq who is the original author of this patch.

Thanks, this is ready to merge now!


Canadian National Calendar

Hello from Canada!
Thanks for starting this project!
I'd like to help by providing the Canadian national calendar. I've attached a json in English. I did not include the common or the readings yet but I will update it later to include those properties. I was focusing on getting the feasts to at least show up in the calendar on the correct days first.
CANADA.json
Of course, in Canada we also have a French missal. It has all the same feasts on the same days so it is just a matter of including the translation. I have the French missal at my office so I can do that. Would I use the json file: nations/Americas/fr_CA.json to create this? I assume each object just needs to have a tag matching it to the Canadian English calendar and the name property with the French name for the fest. Is that correct? Or do I need to include the action property in metadata for each object in fr_CA.json ?
For reference, the Canadian Conference of Catholic Bishops have posted our calendar online in both English and French. The Links below will take you directly to the PDFs.
English: (https://www.cccb.ca/wp-content/uploads/2017/09/nationallitcalender2016_01_27.pdf)
French: (https://www.cecc.ca/wp-content/uploads/2017/11/cal_lit_approuve2016_01_27-3.pdf)

Thanks a lot for this contribution! I'll try to get it integrated as soon as I can. The format has changed slightly in a newer version of the API that I've been working on, thanks to contributions from some fellow Catholic developers from the Open Source Catholic network, but I can take care of updating the format (basically all of the JSON keys are now lowercase and snake_case, to make it easier for developers).
I haven't yet implemented multiple languages for National Calendars, but I foresaw that this would come up, and I have created an issue for this #150 . So with this contribution, I guess it will be the perfect opportunity to get this worked out in the upcoming release of v4 of the API!

The wider region celebration of the Immaculate Conception will be taken care of by the wider_region data that is already defined for the Americas, so it can be removed from this JSON file, and any translations taken care of in weblate (I'll have to create a translation component for this)

If I understand correctly, comparing to the provided national calendars, Saints Joachim and Anne are celebrated as a Feast only in the dioceses of the Province of Quebec, and not all throughout Canada, so I'll put that aside for now and we can define it in a local diocesan calendar.
        {
            "festivity": {
                "month": 7,
                "day": 26,
                "event_key": "StsJoachimAnne",
                "name": "Saint Anne, Patron of the Province of Quebec and Saint Joachim, Parents of the Blessed Virgin Mary",
                "grade": 4,
                "color": [
                    "white"
                ]
            },
            "metadata": {
                "action": "setProperty",
                "since_year": 1876
            }
        }

fixed Saint André Grasset => Blessed André Grasset

fixed StPiusV from createNew to moveFestivity, because it already exists in the General Roman Calendar on April 30th. So moving it to May 1st makes sense seeing there is StMariedelIncarnation that is created on April 30th.

refactored StsJeanBrebeuf from createNew to moveFestivity and then setProperty->grade to a value of 4

There were a few blockers for fully implementing the national calendar for Canada, which actually brought to life a couple bugs in the API other than become the opportunity to implement some long awaited enhancements:

issue #150 (fixed in PR #267)
issue #271 (fixed in PRs #272 and #275)
issue #273 (fixed in PR #274)

These have now been fixed, so the national calendar for Canada in English should now be working on the development branch.
Only thing missing now is to complete the French translation for Canada.

French should now be implemented, thanks to the contributions from Fr. Chris Sherren:

PR #270
PR #276


Fixing api for how transforms are accessed through Node2D and CanvasItem

This PR fixes some API strangeness that falls under how transforms are addressed in CanvasItem and Node2D classes (with side considerations for the Control class).
The first function is get_relative_transform_to_parent() in Node2D.  This function actually takes one input parameter (a target node), and traverses up the scene tree multiplying transforms until it hits the target node.  This is clearly a relative to ancestor function and I renamed as so.
Likewise, similar to get_global_transform() (which is in CanvasItem), get_relative_transform_to_ancestor() should be in CanvasItem NOT Node2D.  It only reads get_transform(), which is available in CanvasItem as pure-virtual function.  This function should be accessable to all CanvasItems, not just a Node2D.
All three transform getters and setters are now available at the CanvasItem level, however the set_* functions are not registered at this level.  This is because Control, (which extends CanvasItem), does not support setting a transform using these APIS.  Control can not support this due to not storing an actual transform matrix, (include pivot as well as rts), so there is inrormation loss on a transform setter.  Therefore these functions are only registered in Node2D.
This correctly sets up CanvasItem to correctly be inherited by new classes (other modules may have a class that extends CanvasItem).
Note** this is an API breaking change, as 'get_relative_transform_to_parent' has been renamed to 'get_relative_transform_to_ancestor'.  The function however is still available in Node2D.  Should be tracked in https://github.com/godotengine/godot/issues/16863

Sorry @reduz but I need a clarification something in this PR as well, and with your response I may need to fix a few more things.
Please can you clarify the intention of below in canvas_item.cpp:
Transform2D CanvasItem::get_global_transform() const {

This function traverses up the scene tree to find the global transform of a node.  However, if it finds 'non' CanvasItem node it stops.  Why?  Why not continue on with the grandparent?  That way sticking a generic 'Node' (or any other node that doesn't inherit from CanvasItem) in between CanvasItems nodes in the scene tree doesn't break the local to global transform and vice versa?

Please don't merge until after discussion with reduz.  If this is not intentional deisng, I will amend this PR to fix these traversals.

I honestly dont even understand why this function exists, just request both global transforms and invert the ancestor, it will be much faster than any of this. Its probably added for ease of use, but it does not even warrant doing all the changes proposed in this PR.

@reduz can you comment on my second comment?  Global transforms break whenever a non canvasitem node is in the traversal path.
Regarding this PR, this is about refactoring CanvasItem to be more entendable, not just that particular function, which I renamed and included because it was wrong.  This is a based on a use-case I have right now.
If i can't get a refactor and clean up merged upstream, I'm forces to put the EXACT same code that is in Node2D in my class in my module that extends CanvasItem, that is going to suck.  All a CanvasItem should know how to do, is get and set their transforms.  If they implement that, they all the other recursive funcs that use that implementation for free, OOP for the win right?
If i can't move the setX to CanvasItem, I'm literally going to have just copy and paste the 'set_global_transform()' function from Node2D to my new node?  The only thing i should have to implement is the set_transform(), I shouldn't have to re-implement set_global_transform with the exact same code copied from Node2D, for no other reason that we can't do a refactor properly.  The PR really isn't doing much TBH

@jordo To clarify your use case: what is there in Node2D that you don't need in your own class? I.e. why do you want to extend CanvasItem instead of Node2D, if you want your node to behave like a Node2D?

@akien-mga @reduz My use case is I'm extending CanvasItem (My new class in module).  I'm not extending extending Node2D because to be frank, it's confusing for users to access properties that I don't want them accessing because it breaks things in un-intuitive ways.  (Scale in in-tree nodes, when related to syncing tree nodes with a physics engine).  I don't want all the stuff that Node2D exposes (set_scale/get_scale).  IF I do that, the first questions I will get about my module from users will be why things don't work when I zoom in and out of a physics node, or in a container node that contains physics nodes.  I want to explicitly disallow users from shooting themselves in the foot.  I don't want to have to rely on documentation to tell users don't do this, I just don't want to allow them to do things wrong in the first place.
Likewise the second question in this PR is about where actually is the global transform?  The global transform stops at the first non CanvasItem node?  Why?  My current two modules I'm working on (Network module and Physics module) combined together need global transforms to work properly when combined together.  Why do transforms (a visual rendering thing) break when encountering a non CanvasItem node in the traversal path?  ( I can't put my controller or game logic nodes in these paths, and it's having ramifications for how I'm building my other module ).  Can I provide a simple video if that would help to explain this?  It would honestly be easier than here perhaps?
Bur here's something to consider, and I'm just pointing out that obviously at some point someone added 'get_relative_transform_to_parent()' because it's in the codebase, and it's used.  Look at the cast in the traversal in the implementation of that function (it's a cast to Node2D NOT CanvasItem).  That means this function works for Node2D traversals, but NOT canvasitem traversals (Controls).  But the fact that I just caught that now, shows how awkward these traversals are already.  If you remove get_relative_transform_to_parent() you probably are going to end up breaking something else in the engine right now that is relying on that functionality.

Look, there should be a base class in 2D that is consistent for doing in-tree global transformations recursively.  (Clearly it's canvas item.  It holds the get_transform() function that is used to implement the recursive global xform function).  And canvas item is whats casted to when asking a node for their global 2d transform.  Except, as I just noticed in 'get_relative_transform_to_parent()' it only works on a Node2D cast (which is most likely broken in subtle ways for users right now).
Look at the 3D path for this.  It's clean.  Everything is is Node3D.  get_xform, set_xform, get_global, set_global.  All clean and nicely accessible from the base class.

I will also add a change to get_global_transform()/set_global_transform() change in another PR, and correct the 3D path on that one as well since I think my first question in this PR is somewhat unrelated to the CanvasItem refactor.

Global transforms break whenever a non canvasitem node is in the traversal path.

@jordo that is completely intended, just dont do it

@reduz So just to confirm, it is then BY DESIGN that godot does this:
https://youtu.be/WwOaTPljKzw
over this:
https://youtu.be/ala39TYA3h0
And that is not open to change?

Maybe this is a documentation problem? Traversal paths are only for contiguous parent-children relationships. If something unrelated is in the middle, they break and start over.

Why though?  I know that's the way it currently is, I'm struggling to figure out why.  And also why the resistance to change when I believe it's clearly a better experience and more flexible.

@jordo Yes, this is by design and its not open to change. The reason is that there are many types of nodes where this relationship cant be continued anyway, like viewport, canvas, canvaslayer, window, or even controls with a toplevel flag, etc. Having to start adding exceptions on what can be continued and what cant is ugly, so as a rule you can only inherit transform on parent-child relationships.

@reduz all that I changed is a get_parent() canvas item with a get_ancestor() canvas item.  Its halts at all the same places wrt canvas, viewports, and everything else.  it 'just works'.  But OK, if this is a design decision, but it's quite limiting for my use case and I believe confusing to new users.

In the event where you really want something like this, you can use the RemoteTransform 2D/3D nodes.

Unfortunately I can't  :(

Sorry, this is not going to change. As I mentioned, current rule requires no exceptions so its preferred over the proposed one.
Your use case seems quite rare, so doing a workaround is not a problem. If there is some extension or feature that will make it easier thats another issue.

huh, OK.  Well after spending a day in cavas_item it's really not an exception.  The class already has a bunch of edge cases whether things are drawn in cavas_layer, viewport, or direct parent.  Its not complicated to traverse for an ancestor canvasitem.
I think the more intuitive the workflow in the engine the better.

Keep in mind that, for users, keeping nodes of the same type chained up has never really been a problem and this rule is generally well understood, so finding that there are use cases where this breaks is rare.

I definitely think people who have been in the engine for many years just give this no thought because 'thats the way it works' and what they're used to.
I'm relative new user (3 months), and experienced game dev.  I haven't encountered any other engine who's scene tree works the godot's does in this regard.

I suppose you can close this PR, I'll probably maintain a separate branch with this functionality as I mentioned it's a blocker with how I'm building another module.  And in general a little wonky to me.  all good

Don't close this just yet, get_relative_transform_to_parent is still badly named at the very least, could be moved to CanvasItem, and/or could be removed as @reduz suggested. We can update the PR so that it only changes get_relative_transform_to_parent.

If there is anymore interest in the specific use case for fixing this as well, some discussion here:  https://github.com/briansemrau/godot_box2d/issues/22
But for now I'll treat this as unfixable upstream and try and workaround or maintain a soft fork.

I gotta say, the more I think about this the more I'm not sure which side of the fence I'm on about whether Node should break the transform chain... I was of the opinion that the current design in Godot is good, and that adding a Node to intentionally "reset" the global transform mid-tree was a good feature. However, there is a function that allows you to set a Node2D to not inherit the parent transform. Ignoring the (strong) argument about this breaking compat and well known Godot behavior, shouldn't that setting be the intended way to break parent transform relationships, rather than adding a superfluous Node in the hierarchy?

I mean.  If you spend a few hours in canvas_item.cpp and really understand how the class works, you'll realize that to implement this functionality you really only have to change CanvasItem::get_parent_item() to something like CanvasItem::get_ancestor_item().  All the same checks for adding canvas_items to the internally maintained children_items list still work, and all the checks for whether the item is registered in the RenderingServer properly all still workout (canvas_layer, viewports, or canvasitem parent (or proposed ancestor) node).
It's also evident the class could use a refactor and little cleanup.  Lots of places using get_parent_item() correctly, other places just get_parent() and casting.
But maybe some consideration to the front facing api would be help 'global_transforms' are definitely not the 'global' transform.  In my example in the video, the Sprite2D under the Controller Node in the scene tree's 'global' transform is actually it's local one...  Quite confusing.
At any rate, the decision is just stay with the status quo, which is fine.  👍

@briansemrau I like the example of Viewport that reduz gave, so I'll elaborate of why Viewport must necessarily do this:
Viewport has to stop the transform chain otherwise things break. Here is a scene where each of the sprites has a position of (32, 32), the child of Viewport has icon.png, and the other has a ViewportTexture:

If we set the position of the root Node2D to (32, 0), this happens:

If Node2D's transform applied to the child of the Viewport, this would happen:

The logic is that: If not all Nodes can keep the transform chain, then Node can't do it.

@aaronfranke viewports still stop the chain as before.

My second comment in this thread specifically asks that, because I think that is what should happen.  And is still what happens in my proposed solution.
Or, if the intention is to stop at the traversal at a Viewport
Viewports are special for a whole bunch of reasons, and they are already treated as special cases in cavasitem itself.

Anyways, I think we can leave it at that no?  I've outlined my use-case, and the expected functionality in the PR.
If this won't get upstreamed because A), the functionality is not desired and B) the implementation would add significant complexity, then that's fine.  I just don't happen to agree.  With either.  Life moves on :)


Fix -rev, -www and -WWW modes to also allow OCSP-stapled responses.

Also allow OCSP-stapled responses for ctx2 (untested).

done, thanks!


[Feat] Added Daily Command & Prettified

Added Daily Command
24 hour cooldown property added in UserDatabase.

Roadmap:

[ ] Add Daily Streaks,
[ ] Improve UserDatabase structure for future use of timestamps (weekly, monthly, yearly) etc.

All good, all done!


added toggling

resolve #18
I didn't add a binding as I am too lazy to think of a good binding.
Using this right now and it appears to work quite well so I am submitting it here, very much in favor of consensual lsp otherwise its really bad for things like c# Func / Actions as params eg () => { ... it keeps showing up here... }
I am new to the nvim plugin stuff so I may have messed up the docs

Excellent! Thanks for this @Polynominal. I'll have a good look over this asap.

Just had a run through with this code, and checked it over. I have a couple of points:

I like the 'enabled' option. Maybe calling it something like 'enable_auto_trigger' to reflect the fact that what it's really doing is preventing the triggers_chars from being the thing that causes the signature popup to appear
I don't think this completely solves #18 because whilst this allows toggling the signature popup ON, when 'enabled' is false, it doesn't allow the signature_window to then be removed again using a toggle switch. Also, when 'enabled' is true, it still doesn't allow toggling the popup when in insert mode, via some key-binding. I think this was the main issue in #18 .

Also, I happened to be doing a bit of work to re-factor the code base to make it more OOP based, and tidy some things I wasn't happy with. If you were happy to resolve the conflicts and rework the PR a bit with the suggestions above in mind, that would be great! You might find it easier using the new OOP style.

I didn't add any key binds as I use which-key where I define all my keybinds, I don't have a personal use case for it so I'd be glad if someone else contributed.
In this PR there are 2 ways in which the display appears

When the 'enabled' bool is true and  you start typing within the signature
You manually request it with the vim command, even if 'enable' is set to false

I approve of the name change. I should clarify that what this pr means by 'enable' is if the window will appear when you are typing, it does not represent the state of the actual display, I made that decision so the plugin is more versatile.
Additionally, it allows the display to be shown on manual request only by the user, I make the assumption that if a user requests the display, any existing 'enabled' settings are to be ignored as the user has clearly displayed their intent.
Therefore enabling the 'display only when I tell you to' behavior.
I do save the window handle as part of lsp-overloads, such that if you toggle it, any existing window will be removed
  if (not M.enabled and M.open_fwin) then
    vim.api.nvim_win_close(m.open_fwin)
    M.open_fwin = nil
  end

I think there is some confusion regarding the window not disappearing, it will only disappear if the 'enable' is set to false and its already open, in some cases a toggle might not work as expected such as when enabled is set to false, the display is manually triggered and user toggles again thereby enable goes to true instead of false.
What are you thoughts on something like this?
M.visible = function()
    return M.open_fwin ~= nil
end
M.hide = function()
  if (M.visible()) then
     vim.api.nvim_win_close(M.open_fwin)
  end
end

Note that hiding has no impact on the 'enabled' state, such that the signature window will appear again as you start typing.
Thanks for the feedback,
I'd be happy to make the changes you suggested, but I would appreciate it if you could introduce the keybinds, if you cannot do that then I can look into it. It's technically feasible I am just lazy as I don't want to read source code for which key to figure it out considering I will have no benefit from it and will have to strip that functionality out for my own use case.

I submitted changes regarding 1)
mainly splitting Automatic display toggles and the actual Display toggle.
Such that we have
:LspOverloadsSignature
:LspOverloadsSignatureAutoToggle
:LspOverloadsSignatureDisplayToggle

The actual part about closing the window was bugged as it wouldn't pick up the fwin handle, now its fixed so it should work as intended.

Hi @Polynominal - Sorry it's taken so long for me to get back to this! It's been a busy couple months for me!
I've taken some of your ideas and tailored them to fit the new OO model of the signature. It works pretty well now I think.
I simplified the commands a bit so there are only two now. One to manually trigger the popup, and one to toggle the auto-display setting. I've also fixed an issue with keybind conflicts, so any conflicting keybindings are automatically reset back to the users originals when the signature popup is closed. Should help with some other annoyances, and allows the open and close keybindings to be the same, acting as a toggle.
The README hopefully explains this all clearly.
Thanks again for the contribution!


Not work with csurf middleware

Environment
Linux
Nuxt 3
Reproduction
One problem remains. In example I removed many code and not seen that it not work with csurf middleware too.
Updated example - https://github.com/n4an/nuxt-error-7  (problem /server/middleware/csurf.middleware.ts).
Describe the bug
When add csurf middleware

FetchError: 403  (/api/list)

Additional context
No response
Logs
No response

and also old issue (in previous reproduction it was eliminanted but in my project it persist)

_rawValue: FetchError: request to http://localhost:3000/api/products failed, reason: connect ECONNREFUSED <IP_ADDRESS>:3000 ()

...


Svg selector starting with  tag failed validation

In an attempt to fix the “transcribed by undefined” bug, I updated the code to query for Web Annotations format, but I'm getting "Invalid Annotation" error in the console in the new Annotorious:
https://clone.davidrumsey.com/luna/servlet/detail/RUMSEY~8~1~289733~90061509:-HALF,-HALF---DOME,-DOME-?annotIds=246987452%2C246987458&theme=earth
but it works in the legacy Annotorious:
https://clone.davidrumsey.com/luna/servlet/detail/RUMSEY~8~1~289733~90061509:-HALF,-HALF---DOME,-DOME-?annotIds=246987452%2C246987458&theme=modern
Apparently, in the file: svgSelector.ts, it didn't like svg selector to start with  tag.

Hi @dwong2006,
fixed! The issue was the single quote in the SVG code. (The parser expected a double quote. I changed the RegEx that does the parsing. It now supports both quote types.)
Patched Annotorious base files (annotorious-openseadragon.js  and annotorious-openseadragon.js.map) are already in the example folder - uploaded them just now.
Cheers,
Rainer


Example of using Spark State globalDataBase subscribe method

I am unable to figure out how to use the Spark-State subscribe method, particularly on the right path to use.
For example, I got an error of "The path is wrong. Path should point to Map!" when I tried the following
`const State = require('spark-state')
const Multipeer = require('Multipeer')
const Participants = require('Participants')
export const D = require('Diagnostics')
;(async function () {
// Initializes a new global database
const globalDatabase = await State.createGlobalDatabase('database')
// Sets new key-value pairs
globalDatabase.set('companyA/personA', 100)
globalDatabase.set('companyB/personB', 0)
globalDatabase.subscribe(() => {
D.log('callback')
}, 'companyA/personA')
// Applies the changes as one transcation
globalDatabase.transact(() => {
globalDatabase.set('companyA/personA', 50)
globalDatabase.set('companyB/personB', 50)
})
})()`
Can I have an example how it should be used?

Managed to figure it out, just gonna leave it here for anyone's future reference
 globalDatabase.subscribe(() => {       D.log('callback')     }, globalDatabase.companyA)

Managed to figure it out, just gonna leave it here for anyone's future reference
globalDatabase.subscribe(() => { D.log('callback') }, globalDatabase.companyA)


Missing crosswalks in LTN "crossing" feature

Hi,
Let's take this itinerary: https://brouter.de/brouter-web/#map=17/48.38830/-4.48477/cyclosm&lonlats=-4.481242,48.386468;-4.486091,48.388378&profile=hiking-mountain
This path crosses two crosswalks:

https://www.openstreetmap.org/node/9290639027
https://www.openstreetmap.org/node/4353761357

Unfortunately they don't show up in:

Even after re-importing fresh OSM data.
Note that those are only 2 examples, but there are more missing crosswalks on the transit roads.
What I don't get is that for example a crosswalk with similar properties does show up fine: https://www.openstreetmap.org/node/4353761353
Thanks!

Thanks for reporting and sorry for the delay! I think I'm not going to do further work on the crossing mode in the LTN tool. Instead, I've started a fresh project to just focus on crossings and how much people have to detour when walking. Please try out https://dabreegster.github.io/severance_snape and feel free to file any bugs at https://github.com/dabreegster/severance_snape/issues/


daemon: initialize datapath before compiling sockops programs

When egress gateway is enabled, we define the ENABLE_EGRESS_GATEWAY macro in the datapath, which in lib/common.h causes HAVE_ENCAP to be defined as well:
#if defined(ENCAP_IFINDEX) || defined(ENABLE_EGRESS_GATEWAY)
#define HAVE_ENCAP
//..
#endif

This doesn't work with sockops enabled, as bpf_sockops.c ends up including lib/overloadable_skb.h with HAVE_ENCAP defined and ENCAP_IFINDEX not defined.
This happens since in the daemon we currently:

create the node_config.h header file with createNodeConfigHeaderfile()
invoke the logic to compile the sockops programs with the sockops.Sockmap*() methods
initialize the datapath with Datapath().Loader().Reinitialize(), which is responsible among other things of invoking bpf/init.sh, which in turn is responsible for populating node_config.h with a few missing constants, one of which is ENCAP_IFINDEX

To fix this, simply invoke Datapath().Loader().Reinitialize() before compiling the sockops programs, in order to properly populate node_config.h
Fixes: #24090

/test

/test


Queries reg. to upgrading from version 5.3.0 to latest version 5.5.2 of the company communicator

Hello team
Our tenant is currently using CC version 5.3.0, however we wanted to update to the more recent version, 5.5.2.
These are the general procedures that we followed after going through the migration guide, which we were able to view inside.
i) Get the latest version (5.5.2) of the Solution folder from GitHub. - We have it downloaded already.
ii) Bring the current.Azure Functions and App Service's Net version  to .NET 6.0 LTS
iii) Select Function runtime settings by clicking on *-prep-function, then Configuration.
Choose ~4 as the runtime version. Select for *-function and *-data-function in a similar manner.
Since steps number ii) and number iii) have already been finished during 5.3.0 migration, we currently have a .Net version  to .NET 6.0 LTS of Azure Functions and App Service that supports function runtime settings to 4.
Does this mean we have to repeat these steps? or not necessary. Also can you share the required steps only for migrating to new version 5.5.2?
After you confirm the aforementioned inquiries, we will contact you regarding the remaining migration-related inquiries.  Please find below screenshot for your reference.

Hi @SachinWandale111 ,
Thanks for raising the query. Since you are on v5.3. Follow the below steps

Perform migration of classic application insights to workspace application insights. Here is the link. Choose any of the two approaches which ever you feel comfortable.
Skip the first step in upgrading from v5.x to latest as it is already completed.
Go to Step 2-Validate and update app config settings and sync to the latest code. Check whichever parameter is missing in app service configuration, add them
You might have observed 401 in the logs coming constantly, to overcome this issue we have introduced a permanent fix. Please follow this link

Hello Sai
I appreciate your quick reply. We have finished "Step-2 Validate and update the config settings and sync to the latest code" and inserted all necessary details during the 5.3.0 version upgrade. The actions listed below are already in place as mentioned on GitHub version upgrade guide.
What are the last few steps we should think about taking to upgrade from version 5.3.0 to the most recent version 5.5.2?
Please clarify if we also need to upload the users and author manifest files to Teams Admin Center as well.

@SachinWandale111 ,

After v5.3 there are some new features which got introduced like schedule send, Delete the sent messages etc., so there are new parameters added to configuration of app service. Below is the reference showing the parameters.

If these parameters are not added, add them and perform SYNC in the deployment center.

Please clarify if we also need to upload the users and author manifest files to Teams Admin Center as well.
No need to re-upload the manifest files again.

After the above steps are completed, try opening the teams on browser and access the application.

Hi @gsv022,
Thanks for your clarification. We have few more quires listed below.
i) What actions must be considered if the requester wants to modify the application name for the user and author?
ii) Does the manifest file need to be reuploaded again for the same?
iii) Is it possible to obtain/download the current user and author application manifest file? If so, could you please share the instructions?
iv) If not is there any way to check the all existing values inside to user and author menifest file as currently we are using 5.3.0 version?
for example: author application
name": {
"short": "",
"full": "",
"botId"
"validDomains"
"webApplicationInfo"
"id": "",
"resource": "api://<<->>"

Hello @gsv022 ,
Could kindly update us on above query asap please?

Hi @SachinWandale111 ,
i) What actions must be considered if the requester wants to modify the application name for the user and author?
To update name of CC

Login to Azure Portal with Global Admin Credentials (portal.azure.com)

Go to Resource Groups and Under your subscription select the resource group where the app is deployed.

Click on Azure Bot(user) --> under settings click bot profile-->Change display name as per the organizational need.

And update the names in the manifest files for user. Re-upload the manifest file again. Here is the place for reference.

Is there a way I can change this when I don't have the original manifest files.
Please download the manifest from code here and update the user manifest as per the  6th-step of deployment guide

The above procedure is applicable for both author and user app.

Note:-
There might be chance that desktop app will get cached. However, it can be validated by checking in the browser version of the app.

ii) Does the manifest file need to be reuploaded again for the same?
Yes
iii) Is it possible to obtain/download the current user and author application manifest file? If so, could you please share the instructions?
No, it is not possible. If current manifest files are not available, then please download the manifest from code here and update the user/author manifest as per the  6th-step of deployment guide
iv) If not is there any way to check the all existing values inside to user and author manifest file as currently we are using 5.3.0 version?
Three parameters are required for manifest files.
appdomain- <>.azurefd.net.
Author Bot Id - Author(application/client id)
User Bot Id - User(application/client id)
All the three parameters can be obtained at one place. Here is the navigation
Go to Azure portal-->Select Resource Group--> In the LHS, under settings, choose deployments--> Select the latest by date microsoft.template(failed/succeeded)-->In the LHS, open inputs-->Base Resource Name, Author Id, User Id can be found here.

Hi @gsv022 ,
Thanks for clarification, regarding to step iv) you mentioned only below three details required in manifest file.
a) Appdomain
b) Authot Bot ID
c) user bot ID
But when we downloaded the manifest file for author its asking for below details as well. Kindly confirm what values we need to enter there as well? For any further additional queries we will get in touch with you.

Hello @gsv022,
Could kindly assist on above query quickly as soon as possible please? We are awaiting your response.

@SachinWandale111 ,

But when we downloaded the manifest file for author its asking for below details as well. Kindly confirm what values we need to enter there as well?
For author manifest file we need to enter author bot id inside to "webApplicationInfo"?
Yes

ii) If our user and author name is same (common) inside to teams app store, then how do we identify between them which one applications is really user and which is author?
Author manifest and user manifest can be bifurcated by Support Files present within manifest files. If it is true, then it is a author manifest otherwise user manifest

From the user perspective, please name it with accordingly in the 8 line of manifest file before uploading it.
iii) We also tried to upload the Manifest files for both application (user and author) from Team Admin Center but we are encountered an error, "There's no manifest file in your app package. Check the app package and try again."
As we checked manifest file already present in both user and author zip files. Refer below screenshots. Kindly advise.
Before uploading to teams admin center- validate the manifest file using this link- App Validator

Hi @gsv022,
i) I appreciate the update. We are running into the following problem when we attempt to upload the manifest files for both users and authors using the App Validator link. Is there any way we could have a quick conversation to talk about this error? If at all possible, kindly inform us. What is the next course of action for this specific problem, "Provided add-in package was not understood. Please, make sure that the file being submitted is a valid Office add-in package". Below screenshot is for your reference.

ii) If our user and author name is same (common) inside to teams app store, then how do we identify between them which one applications is really user and which is author?
Author manifest and user manifest can be bifurcated by Support Files present within manifest files. If it is true, then it is a author manifest otherwise user manifest
image ==> Is it possible to verify the user and author app in teams app store or TAC without checking manifest file, if so kindly confirm.
iii) Also regarding to query we asked "i) What actions must be considered if the requester wants to modify the application name for the user and author?
We are interesting while changing names for user and author application, so in teams app store end user can easily identify between user ad author application. hence we requested to share the steps.
For example for user app "Company Communicator -Users"
For author app we need "Company Communicator -Authors"

Hello @gsv022
Could kindly assist on above query quickly as soon as possible please? We are awaiting your response.

Please share the zipped manifest files of both author and user

Hi @gsv022 ,
Kindly find the needed zipped files for the author and user applications. Please respond as soon as you can, as this is causing our version upgrade to the most recent version—5.5.2—to be delayed. Please let us know if additional details required.
company-communicator-users.zip
company-communicator-authors.zip

Hi @gsv022,
Due to some Company policy restrictions, we couldn't be able to upload the manifest file here.
Instead, could you kindly able to help us why this error coming? As other customers also might raise case for the similar issue earlier. What are the steps we need to perform to resolve this issue? Also, we can't provide you the client details which are available inside to users and author manifest file.
Also, could you kindly confirm on below parameters which requires to update in manifest file.
i) "configurationUrl": "https://<>/configtab"
For example: our default domain name is "xyz.azurewebsites.net" then the configurationUrl would be like below?
"https://xyz.azurewebsites.ne/configtab" or it need to take from Front Door and CDN profile, for example if the Front end door for our application is hosted on, "https://xyz.azurefd.net" then configurationUrl would be like below?
"https:///xyz.azurefd.net/configtab"
ii) Also specify below details.
validDomains": [
"<>" =======> Please refer point number (i) and confirm to us
],
"webApplicationInfo": {
"id": "<>", ========> We need to use user bot id (Client/application id) for user application and author bot id (Client/application id) for author app, please confirm.
iii) Also please confirm, "manifestVersion": should be updated as  "1.5" or recent one which is 1.17 in user and author application manifest file?
"resource": "api://<>"
Please confirm as soon as possible please due this our version upgradation is getting delayed.

Hi @gsv022,
Thanks for confirming. Can you kindly confirm on below two queries one more time.
i) Where we can cross verify the below URL's are correct one? Do we able to verify it from TAC or Azure portal?
"websiteUrl": "<>",
"privacyUrl": "<>",
"termsOfUseUrl": "<>"
ii) Also where to verify the app domain name which we are using right now is correct one?
Do we able to verify it from Azure portal? and how, please share the details steps in azure.
iii) Is there is any way we can setup call to discuss this?

Hi @SachinWandale111 ,
i) Where we can cross verify the below URL's are correct one? Do we able to verify it from TAC or Azure portal?
"websiteUrl": "<>",
"privacyUrl": "<>",
"termsOfUseUrl": "<>"
These will be URL's of your organization where you can grab those and paste it in the above places.
ii) Also where to verify the app domain name which we are using right now is correct one?
Do we able to verify it from Azure portal? and how, please share the details steps in azure.
This can be cross verified from App service- configuration part. Here is the reference.

Please let us know if any queries are there

Hi @gsv022 ,
Thank you for providing the information. We will review it and let you know if we have any more questions.
Please be sure to highlight and disclose all the necessary information that has to be added to the users' and authors' manifest files.
Additionally, kindly share the format with all necessary details. As we are unable to share the Manifest file due to some security concern.
Please provide any template for a manifest file as an additional example.

It is clearly mentioned in the deployment guide on what needs to be updated within manifest file. Moreover I think I have responded to the queries related to manifest files in the above conversation. Please let me know if you have any blockers on manifest files

Hi @gsv022
We have made all the necessary adjustments to our users' and authors' manifest files in accordance with the deployment guide, however when we attempt to upload the two manifest files (user's and authors) into TAC, an error message appears.
Error from teams admin center => "We can't read the manifest file. Try again later."
Therefore, it would be very appreciated if you could provide all the information that has to be added to the manifest file once, and if that's feasible, you could also provide the manifest file template for reference. Our version upgrade is being delayed as a result of this.

Hi @SachinWandale111 ,
Actually in version upgrade, no need of re-uploading the manifest file because the id's and app domain in the manifest files won't change. Please make sure that after upgrading app is up and running or not.

Hi @gsv022,
As discussed earlier you already confirmed we need to upload the new manifest file for user as well as author application as requester want to modify the existing name of the user and author application in teams app store. Please see below screenshot for the same.
However when we attempt to upload the two manifest files (user's and authors) into TAC, an error message appears.
Error from teams admin center => "We can't read the manifest file. Try again later." Hence we deleted the existing user and author apps from teams admin center and tried to upload it again but still we are getting same error.
Therefore, it would be very appreciated if you could provide all the information that has to be added to the manifest file once, and if that's feasible, you could also provide the manifest file template for reference. Our version upgrade is being delayed as a result of this.

Hi @SachinWandale111 ,
If you are facing issues with manifest files, please share them. We will check it
As I mentioned earlier, please share the manifest files we will verify it.

Hi @gsv022
Kindly confirm, The data (manifest files for users and authors) which are you requested is it covered under NDA with Microsoft? as we already inform you earlier we are unable to share the Manifest files due to some security concern. Thanks

Please share your mail id so that we can discuss the issue internally

Hi @gsv022,
Could you kindly confirm, once we share the mail ID with you, are you going to share meeting invite to discuss this issue internally or you are going to share any steps over email for further instructions? Thanks

Hi @gsv022,
Can you kindly confirm on above ask please? Thanks

@SachinWandale111, We will check the issue w.r.t manifest file that you are encountering. May be you can share the manifest files over the personal chat once you share the id and also  if required we can get into call for further troubleshooting

Hi @gsv022,
We will update you on this. Thanks

@SachinWandale111 ,Please keep us posted

Sure. We are discussing on it internally.

Hi @gsv022
We are still discussing on it internally. Once we have an update will notify you. Thanks

@SachinWandale111 , Please feel free to log a new issue if you have any, even this ticket is closed.

Hi @gsv022,
Kindly keep this case open as we are discussing this internally and taking necessarily approvals for sharing manifest files. Thanks

Any update here?

Hi @gsv022 ,
We are still checking the necessary approval for uploading manifest file on GitHub portal. We will update you soon once we received any updates. Thanks

Hi @gsv022,
We are still checking the necessary approval for uploading manifest file on GitHub portal. We will update you soon once we received any updates. Please keep this keep open. Thanks

Hi @gsv022,
Please find attached manifest files for both user and author application.
Also please note that in both users and authors manifest files, I have removed the below confidential data:
i) App ID or Bot ID "<>", for user bot and author bot
ii) <>"  removed from user and author manifest.
iii) "configurationUrl" removed from author manifest.
company-communicator-users.zip
company-communicator-authors.zip


Hint text showing letters which need to be placed to match previous clues

When you have a longer word, sometimes it's hard to remember which yellow letters you still have to place in the word. The game interface could show for example that an E needs to go in one of the boxes which has not been eliminated yet as a possibility for the E.
This could dynamically update so after you enter an E it would no longer suggest that it needs to go into the other boxes.

This is handled by the smart keyboard now. It indicates which letters still need to be placed.


Import Fill Layers with simple color as Solid Colors and delete empty…

Hi,
I've changed a bit the importing part for Photoshop. This version will import Fill Layers with simple color as Solid Colors and will delete empty layers and folders.
The empty layers are exported for channels not used in the substance layer so maybe there is no need for them in the .psd file.
I'm sure this functions will be obsolete once the scripting API will be updated to go deeper in the layer like listing the channels used or the effects with all the options.
Maybe someone will find this usefull.
Thank you.
Cristian

Hi,
Thank you for your pull request with these nice features!
As you said, more we expose data in scripting API, more we will be able to export an accurate project without the need to use tricks.
In any case, this is a useful proposition and we will take a look ASAP as we don't know when this information will be available in the API.
Jérémy

Hi Jérémy,
I'm glad that you find this usefull, I can't wait to see the API go deeper :)
Anyway you guys are doing a great job, Painter is becoming such a great product.
Congrats
Thank you.
Cristian


MGMT-14329 - Unhelpful popover for NTP “Synced” status

https://issues.redhat.com/browse/MGMT-14329
Before:

After:

Looking great!
/approve


x/tools/gopls: unsupported version 0 of Verneed record

What version of Go are you using (go version)?

$ go version
go version go1.15.3 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/xx/.cache/go-build"
GOENV="/home/xx/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE="git.xxx.com"
GOMODCACHE="/home/xxx/go/pkg/mod"
GONOPROXY="git.xxx.com,xx.com"
GONOSUMDB="git.xxx.com,xx.com"
GOOS="linux"
GOPATH="/home/xxx/go:/mnt/e/go"
GOPRIVATE="git.xxx.com,xxx.com"
GOPROXY="https://goproxy.io"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build685780456=/tmp/go-build -gno-record-gcc-switches"

What did you do?
gopls can not work after I updating.
run gopls:
gopls: error while loading shared libraries: gopls: unsupported version 0 of Verneed record

What did you expect to see?
What did you see instead?

Hi, how did you install and update gopls? Did you use go get, or something else? If you installed from the command line, which command exactly did you execute?


Return to base environment with conda deactivate
Create new project with cookiecutter https://github.com/drivendata/cookiecutter-data-science
Execute make data
Confirm success with

make test_environment
python3 test_environment.py
Development environment passes all tests!

Execute jupyter lab
In Jupyter Lab, navigate to myproject>notebooks
From jupyter lab launcher create a new notebook using the conda environment yourenvname
Execute first cell with

# OPTIONAL: Load the "autoreload" extension so that code can change
%load_ext autoreload

# OPTIONAL: always reload modules so that as you change code in src, it gets loaded
%autoreload 2

from src.data import make_dataset

Error
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-f47036c946b3> in <module>
      5 get_ipython().run_line_magic('autoreload', '2')
      6
----> 7 from src.data import make_dataset

ModuleNotFoundError: No module named 'src'

The error does not occur when using a python3 notebook instead of a notebook with the environment kernel.
It appears that the project package is not recognized by the notebook because it is not installed in the environment kernel.
I saw the recommendation to install jupyter in the environment, but that seems to be contrary to the design of jupyter lab/notebook and environments. One wants to have one jupyter install in the base environment so one can traverse all projects but still isolate notebooks within kernels.
This issue plus the conversations on #164 #118 #83  suggest that environments are a source of confusion and complexity. It would be nice if there were a way to let the user choose the package manager then reference environment stuff encapsulated by package manager. That would make the maintenance problem easier rather than either trying to do complex conditional logic in the makefile or forcing the user to debug incorrect assumptions about their starting environment.
In the meantime, perhaps someone could suggest a command to import src into an existing environment.

Thanks for the thoughtful overview, @jraviotta!
The real problem with this particular issue is that you never do something like pip install -e . in the local directory to make src available. This currently happens in requirements.txt when that is used, but not in environments where you only use conda. This will change with #162 where we take advantage of the updates to conda that let us install packages with pip.
The jupyter kernel issue is basically not related because if the package was installed in the kernel environment, that workflow should be supported.
I think that what is in #162 should support this workflow when it is ready

@pjbull I agree with your assessment. I took a look at the feature branch for #162 and also agree that the local module should be available using the new workflow. I really like the modifications. It should make maintaining the current features easier, and also smooth the addition of new ones.
I'm not going to try to rebase #170 on top of the new branch because the new branch achieves the same objective in a different way. I'll see if there is anything on that checklist I can help to move forward.

So ... what would be the "upgrade path" for somebody with an old conda environment based project in this case? I feel like I have tried every possible combination and still can't use the local files in the jupyter notebooks.

@fhaust What do your directory structure and pip freeze look like?
pip install -e . should work in a conda environment without any changes. If your project was created before March 2018, you may be missing setup.py. You would need to copy this setup.py to the project root and fill in the variables manually.
If you are using environment.yml you can add the following to the file:
name: ....
channels:
 - channel
dependencies:
 - conda_package
 - pip:     # these two lines are
   - -e .   # what you need in environment.yml

So ... what would be the "upgrade path" for somebody with an old conda environment based project in this case? I feel like I have tried every possible combination and still can't use the local files in the jupyter notebooks.

I create a conda base environment as described here. Then I install conda environments for each project. and include an  environement.yml with the following plus any other packages.
channels:
  - conda-forge
  - defaults
dependencies:
  - ipykernel
  - setuptools
  - wheel
  - pip
  - pip:
     - -e .

That installs the local code into the new environment and provides a kernel for the environment in the jupyter notebook.

@pjbull
So I do have the setup.py ... that apparently was already a thing when I created the project.
I had a environment.yml that contains the pip and -e . lines. I put them in there by hand this morning, do I have to reload it somehow?
Thing is my environment.yml wasn't called like that in the beginning, I think I created it manually and called it after the folder the project resides in, but I just renamed it and it still doesn't recognize the local folders.
What changed is that now which python and which jupyter point back to the global installation of those, does that still pose a problem?

Have you read the docs on creating and managing conda environments? If not, that's the best place to start:
https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html
Once you have a conda environment activated, you can use the following to update it with that latest like so:
conda env update --file environment.yml

I tried the env update before and just repeated it to no avail. It reported some inconsistencies, but I don't think that should be a problem?
I probably should mention that I have to specify the current conda executable via CONDA_EXE for a while now. No idea if that is a problem?

I've tried reinstalling conda (there was indeed a problem with my installation), created a new environment and reinstalled the local package. But Jupyter does not recognize it.
Let's try the other way around, can you point me to a branch and/or commit of this project that should work with conda environments?

All of the branches/commits including the current one will work with conda environments. Again, this isn't a CCDS issue since we don't do anything special with conda environments (or any environment for that matter).
Run which jupyter at your terminal. I suspect you are running the root environment jupyter in conda rather than in your conda environment. If the result of that does not have the environment name, you should:
(1) Activate the conda environment if it is not activated
(2) Run pip install jupyter or conda install jupyter inside the environment.
(3) Run which jupyter to ensure you are using the version in the environment
Now when you run jupyter you should be able to load the package that is installed in that environment. This is a byproduct of how conda sets up environments and Jupyter kernels and not a cookiecutter issue.
In exchange for the support on this issue, would you submit a PR adding a note to the docs that explains confirming that your running version of Jupyter and your local install of the package are in the same environment? Just a couple of lines at the end of this section will help other people who encounter this issue.

I basically gave up on this ...
But after just reinstalling Jupyter Lab I now get the option to chose a Python [conda env:.conda-xxx] kernel, no idea what changed but with that kernel I can now include the local folders. :man_shrugging:

Another option is to specify PYTHONPATH before launching jupyter . For my own convenience I added a new make target into Makefile:
## Run Jupyter
jupyter:
	PYTHONPATH=$(pwd)/src jupyter notebook --ip=<IP_ADDRESS>

This is more preferred for me since I am using docker for my projects.

I always use this snippet in order to enable relative imports to my notebooks:
import os
import sys
module_path = os.path.abspath(os.path.join('..'))
if module_path not in sys.path:
    sys.path.append(module_path)```

This makes sure that any relative import works just fine. hope this helps.

@pjbull attempting to run notebooks from the notebooks folder still results in a "ModuleNotFoundError". Interestingly, opening up python from Anaconda prompt does allow an import from the main package folder, and from inside the notebooks folder...
What procedure of commands after running cookiecutter https://github.com/drivendata/cookiecutter-data-science (plus the automatic inputs) followed by pip install -e . from the parent directory is required to be able to import scripts from the src directory from inside the notebooks directory? (trying to avoid the appending to my path)

Yep, that should work and is baked into the default template already.


Auto set Camera parameters for shaders

if they inherit from Camera.xksl

@tebjan What was the idea here? After a quick search I couldn't find any Camera.sdsl

that is a stride shader... if the user inherits from that shader, the current camera parameters should be set automatically.
it has these inputs:
// Copyright (c) Stride contributors (https://stride3d.net) and Silicon Studio Corp. (https://www.siliconstudio.co.jp)
// Distributed under the MIT license. See the LICENSE.md file in the project root for more information.
shader Camera
{
    cbuffer PerView {
        // Camera Z NearClipPlane value.
        stage float NearClipPlane = 1.0f;
        // Camera Z FarClipPlane value.
        stage float FarClipPlane = 100.0f;
        // Z Retro projection factor used retro project a non-linear 1/z depth in the range [0.0 - 1.0] to a linear-depth in view space.
        // Remarks: ZInViewSpace = ZProjection.y / (depth - ZProjection.x)
        stage float2 ZProjection;

        // Camera View size
        stage float2 ViewSize;
        // Camera aspect ratio.
        stage float AspectRatio;
    };
};


Installed Chatterbot But Can Not Find On My Server

Hello,
I have installed chatterbot using your instructions and CMD says it has been installed correctly. How I am not sure how to run this and can not find it on my server?
Cheers.

Hey @mcsteel88, can you tell me what exactly you cant find over the server?

Well basically I jut want to be able to run the program so need to find
where it has been installed on my VPS server. I can not find any
installation file.
On Fri, Nov 19, 2021 at 3:24 AM Vaibhav Singh @.***>
wrote:

Hey @mcsteel88 https://github.com/mcsteel88, can you tell me what
exactly you cant find over the server?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/itsvaibhav01/Omegle-Chatbot/issues/2#issuecomment-972912058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWPV6HCSLPMGB3C5KSD5EOTUMUEABANCNFSM5IDCTJWQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


fixed typo in custom parameters example

$hash is an undefined variable and produces an error.
Changed $hash to $id, like in the first example, to fix the problem.

LGTM :+1:

Good catch, thank you.


add genlims ops method for querying for a field among sample ancestors

Method/function genlims.search_ancestors() will start on the specified sample (given sample ID) and continue looking back through parent samples the specified field is found, then return that value (or None, if the field isn't found).

Coverage increased (+0.1%) to 80.286% when pulling f1b6cf6594b34bfcb091b7864338cf721b6fcc44 on query-ancestors into 9db1313b7a8f802fc38b84dacd18ecf8db9df83b on master.


 5.        ],
       [ 0.78648496,  5.1       ],
       [ 0.94745888,  5.3       ],
       [ 0.97076437,  5.5       ]])

    def transform(self, X):
        """Apply dimensionality reduction to X.

        X is projected on the first principal components previously extracted
        from a training set.

        Parameters
        ----------
        X : array-like, shape (n_samples, n_features)
            New data, where n_samples is the number of samples
            and n_features is the number of features.

        Returns
        -------
        X_new : array-like, shape (n_samples, n_components)

        Examples
        --------

        >>> import numpy as np
        >>> from sklearn.decomposition import IncrementalPCA
        >>> X = np.array([[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]])
        >>> ipca = IncrementalPCA(n_components=2, batch_size=3)
        >>> ipca.fit(X)
        IncrementalPCA(batch_size=3, copy=True, n_components=2, whiten=False)
        >>> ipca.transform(X) # doctest: +SKIP
        """
        check_is_fitted(self, ['mean_', 'components_'], all_or_any=all)

        X = check_array(X)
        if self.mean_ is not None:
>           X = X - self.mean_
E           ValueError: operands could not be broadcast together with shapes (51,2) (4,)

/opt/conda/envs/dask-ml-test/lib/python3.6/site-packages/sklearn/decomposition/base.py:130: ValueError
--------------------------- Captured stderr teardown ---------------------------

I just submitted a PR https://github.com/scikit-learn/scikit-learn/pull/12659 to address the issue with test_pipeline_feature_union.

Thanks.


Support Pipes

[Details]
As an user I would like to have the concept of Pipes. Pipes can be useful to transform parameters from a request (query, route params) or even a body request from something like a POST request. The concept behind a pipe is to bind the parameter to the pipe, and the pipe will be processed before the request reaches the HTTP Handler, when the request reaches the HTTP handler, the pipe has transformed x param into a new value.

Close in #154


Multi-line named parameters are not formatted correctly.

This is a regression from mdr/scalariform:
foo(
  alpha = "foo",
  beta = bar match {
    case _ => "bar"
  },
  gamma = false)

is incorrectly formatted as:
foo(
  alpha = "foo",
  beta = bar match {
  case _ => "bar"
},
  gamma = false)

This seems to be the case regardless of whether IndentWithTabs is true.

Turns out there is already a ticket for this: https://github.com/daniel-trinh/scalariform/issues/85


Fix the return code of rsa support functions

Not sure what the intention is here. The original idea was to indicate an error. So the code was returning 0 (false) to indicate failure, and 1 (true) to indicate success. With these changes it now always returns 0.


Add timestamp to EventPayload

I want to merge this change because EventPayload model needs timestamp to prevent it from being deleted immediately after creation

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-5077 Add timestamp to EventPayload


Invisible files not work

Condition:

This directory is collapse.
This directory includes some files or directories should be matched.

Example:

Reason:

Invisible files(files in collapse directory) are not exist in tree-view dom tree.
Now, tree-view-search-bar matches the files by css.

Finally:
If you have any idea or advice about this problem, welcome to discuss here.

Thanks for advice.
If types . first, it only recognizes this expression for searching some files.
I will consider this case in next version.
Probably, improve the algorithm and let it more smart.


Fix(Native): Fix https://github.com/alibaba/AndFix/issues/273

Bugfix

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Update the build instructions to use Go 1.9.2

Mattermost now strongly recommends using Go 1.9.2—and warns if the 1.9.0 version is used.
Update the docs to reflect this.

Thanks for the PR @kemenaran :) We'll get this through the review process soonest...

@ccbrown why not.
That said the main goal of this PR was to fix the instructions for the minimal Go required version (as defined by pre-check.sh). It can also wait for the release of Go 1.9.4 though (especially if the platform plans to make this new version mandatory soon).

We won't be making 1.9.4 mandatory. 1.9.2 is only mandatory because it includes fixes that Mattermost simply won't function securely or properly without. To my knowledge, that won't be true of 1.9.4, but we'll want developers / build machines to be using it for their own security. If we're going to walk people through Go installation, let's try to keep them secure instead of instructing them to install a vulnerable toolchain. :)

Go 1.9.4 is released. Build machines are now using it and so should devs.
I've gone ahead and updated your PR. Thanks for the contribution! :D

@ccbrown thanks!


[Feature idea] Zeroconf/auto detection feature

I've found that "https://app.divoom-gz.com/Device/ReturnSameLANDevice" returns the list of all the Pixoo 64 devices on the same network. Maybe there's something we could do with it? It would be cool to allow the HA "found device on the network" thingy, but I'm really not sure if it could work, as I believe that they use mDNS detection, which isn't used with the pixoo.

I have an idea for this. Instead of using the real zeroconf way, maybe we could add a step before what we have now when adding a new device that could contain the detected devices (with also an option for a manual IP input)


Anonymous>Landing Page> Staging Environment > Matched Skills section is displayed twice

Describe the bug
As an anonymous user (not authenticated)  you have the matched skills is duplicated twice, the first occurrence should be removed
To Reproduce
Steps to reproduce the behavior:

Go to 'https://devalopers.herokuapp.com/..'
Scroll down to 'Most Searched Skills'
Scroll down more you find another  'Most Searched Skills' section

Expected behavior
Most Searched Skills should occur once

@mirnaitani6 so which section has to be removed? The top or bottom one?

@mirnaitani6 so which section has to be removed? The top or bottom one?

Kindly remove top


Messed up lock file formatting when using CRLF EOL

After the first run of npx -y update-browserslist-db@latest in our project, it messed up package-lock.json formatting, see:
This is on my colleague's PC (windows, I believe)

This is on my PC (Ubuntu, WSL2):

This is my output:

After that, I changed nothing re-running the command worked just fine. Can't reproduce anymore.

Here's a reproduction:
const DEFAULT_INDENT = "  ";
const INDENT_REGEXP = /^(\s+)[^\s]/m;

function detectIndent(text) {
  try {
    return INDENT_REGEXP.exec(text)[1] || DEFAULT_INDENT;
  } catch (e) {
    /* c8 ignore next 2 */
    return DEFAULT_INDENT;
  }
}

const text = `{\r\n  \"name\": \"my-project\",\r\n`;

console.log(JSON.stringify(detectIndent(text)));

will print "\n  "
As you can see, it includes \n into the detected indentation.

My colleague and I would like to take on this issue if that's ok


Non reproductive compilation

  <xs:element name="score-timewise" block="extension substitution" final="#all">
...
               <xs:element name="measure" maxOccurs="unbounded">
                   <xs:complexType>

translates to
// A_score_timewise Named source within outer element "score-timewise"
type A_score_timewise struct {
...

	// generated from anonymous type within outer element "measure" of type A_measure.
	Measure []*A_measure `xml:"measure,omitempty"`
}

// A_measure Named source within outer element "measure"
type A_measure struct {
	Name string `xml:"-"`

necessity to sort between elements that have the same name
	elems := GetGongstrucsSorted[*Element](stage)
	slices.SortFunc(elems,
		func(a, b *Element) int {
			return cmp.Compare(a.GetOrder(), b.GetOrder())
		})
	for _, x := range elems {


Dragging often doesn't catch, needs to be more consistent

It sort of works now... But not consistently.
It seems to work better when I move stuff to the right, less likely when I try to do it to the left. But it's difficult either way.
A bit lengthy gif to demonstrate:

I think I found the cause of this issue. It was impossible to move the first or last item around... v0.0.7 published. Please let me know if it works.

Not published yet?
It's still on 0.0.6, even in your repo.

Ooops, forgot to publish... Should be up now.

Yup, that part works now. Thanks.
But...
https://github.com/olmokramer/atom-move-status-items/issues/4


feature: Pill V3

The type of this PR is: Feature

This PR resolves [CX-1695]
Description
This PR adds the new V3 Pill and uses them depending on the current theme.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Add V3 Pill component (behind feature flag) - rajsam003

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Add V3 Pill component (behind feature flag) - rajsam003)

  Generated by :no_entry_sign: dangerJS against 398f5f56f5f66d731155306dee7adef64a37fd12

Agree with @olerichter00! after that lets merge it!

#squashOnGreen