Bold text background does not align correctly

The further away from the corner that the text was aligned to, the more offset the background text is from the foretext.
The first image is fine, that is how it is supposed to look.
The second image has a noticeable unaligned effect, caused by being spaced out slightly by the large icon.
The third image is an example of a severe unalignment, when the text is nearly at the center of the screen.

What version of the mod?

Can you test it with just those two mods and forge?

I just tried it, running nothing but Forge, Lunatrius Core, and IGI. No difference, still causes the glitch.

Could you paste your XML config? The shadows seem to work just fine.

Judging by that, I assume that you are positioning the commands <lines at "top[left/center/right]"> to position the text? I believe that explains why you do not have the issue. As seen by the images I posted above, that cannot always be the case. I placed an item icon before the text, which may be cause for the desynchronization. Try adding a few spaces (maybe six to eight) before the text, like so:

        $Lsample text

Here is the file I use.
InGameInfo.xml.txt

Also, on a wholly unrelated note, how do I use the  function?

Ok, managed to reproduce the issue, will check if this is a vanilla or Forge bug. the same code worked in previous versions of Minecraft.
What function?

It's a vanilla bug. This will be tricky to fix on my side (if possible at all).

The shadow renders properly, but you're not resetting the bold style, so the foreground text gets rendered with the bold style still applied, making all the spaces wider.
You can fix this by resetting the style on the end of the line by using $r.

These appear to be the documentation on the ICON function, but I cannot figure out how to use it to create an actual icon on screen. The instructions in the chart were unclear.

I am not sure which end the bug is on, but I know that bspkrs' mods, ArmorStatus, was able to display the information without issue:

Note that the info displayed is nearly identical to the other image, but does not have the offset shadow despite being in the near exact same position.
On another unrelated note, is there a way for me to shift text or images up or down by half a line? Note how in the image that the icon is halfway between the name, and the durability menu would have been underneath it had it existed. On the three images at the top, the icon is on the same line as the image, so the durability menu would have been offset slightly. Just a minor aesthetic thing.

Also, the snowman head image is not bold by command choice, but because that is the default text in its actual name on the server that I took the image.

Text can't be offset vertically within a lines block other than adding empty lines to offset text by the amount of empty lines.
Where exactly does the snowman head come from? Is it an item in the inventory, the world or just a static image? There are specific tags for the first two options (search for equipped / mouseover in the tag list). The third option does indeed require the use of the icon function.
<!-- A simple example of a static dirt block image -->
<icon>
    <str>minecraft:dirt</str>
    <num>0</num>
</icon>

Also as you probably noticed, the format for the icon function is rather complex, which is why I haven't added it to the in-game documentation yet. I need a simpler representation.

Despite the issue being caused by failing to add $r to the end, the item's name itself is in bold, rather than causing the bold effect via a command. The item in question is a helmet-slot item, on the Mineplex server.
`
helmetlargeicon
{helmetname}$r

        <op>
            <str>le</str>
            <pct>
                <var>helmetdamageleft</var>
                <var>helmetmaxdamage</var>
            </pct>
            <num>10</num>
            <num>25</num>
            <num>40</num>
			<num>60</num>
			<num>80</num>
			<num>100</num>
            <str>$4</str>
            <str>$c</str>
            <str>$6</str>
            <str>$e</str>
			<str>$a</str>
			<str>$2</str>
        </op>
        <max>
            <var>helmetdamageleft</var>
            <num>0.5</num>
            <str>    {helmetdamageleft}/{helmetmaxdamage}</str>
            <str/>
        </max>
        <str> </str>
    </line>`

Also, thanks for the icon example!

Mineplex should properly name that item in that case.
Metadata 0 is the default for all items and it should work without issues. To modify the size of the icon you'll have to replace the metadata parameter with extra information. The additional arguments required are listed here and are prefixed with final int.
The first 4 arguments control how the icon will be displayed, the next 6 arguments are only used in combination with a spritesheet (if you'll supply an item name you can ignore there).
<icon>
    <str>minecraft:dirt</str>
    <num>0</num> <!-- displayX -->
    <num>-4</num> <!-- displayY -->
    <num>16</num> <!-- displayWidth -->
    <num>16</num> <!-- displayHeight -->
</icon>

This is what happened when I used the code pasted above... Am I doing something wrong?

I didn't check if it still worked. Looks like you have to use the file name directly instead of the item's name.

Can confirm it works. Thanks! However, it does not seem to render blocks correctly, for obvious reasons. Any way to fix that? Render blocks with custom size display?

Also, how do I use the if, and, not, or tags?

not negates the single parameter
if check the first parameter, if it's true it returns the second parameter, otherwise the third (or a blank string if it's not specified)
and/or check if all/one of the parameters are true

A few short examples:
<if>
  <var>slimechunk</var>
  <str>Slimes!</str>
  <str></str>
</if>

<if>
  <not>
    <var>slimechunk</var>
  </not>
  <str>Not Slimes!</str>
  <str></str>
</if>

<and>
  <var>slimechunk</var>
  <var>wet</var>
  <var>burning</var>
</and>

<or>
  <var>slimechunk</var>
  <var>wet</var>
  <var>burning</var>
</or>


Show initial DisplayDate panel with focused endDate Button

Hi,
Is there any config to make the Calendar get that expectation?
In some situations, user wants to change the endDate without touching the startDate

Hi @fantasia949, if you upgrade alpha5 you can set initialFocusedRange={[0,1]}. 0 for range index, 1 for endDate.


Chronograf Alert Count

Chronograf is not reflecting the correct alert count for Kapacitor TICK scripts loaded from the command line.  It seems that Chronograf is only counting alerts that were created through the UI.

@dishmael I think this may be intended behavior. Could you repost this issue in https://community.influxdata.com/ until we can establish that there is actually an issue?

I did raise that as an issue on InfluxData's community and they said to raise it as a bug here.
How could that be "intended behavior"?  Chronograf should be showing the count for alerts that were created in the UI as well as from the command like via Kapacitor.  This seems like a bug to me.

@dishmael I've responded on community.


Add 'Change Kubernetes context' menu

I did nothing, just took the backend of https://github.com/nsriram/KubeSwitch (MIT license) and plug it in our tray.
It works great and only require a YAML parser (not oc bin).
I tried to be explicit with the copyright for the files coming from KubeSwitch. Let me know how I can improve that!

How is this used after choosing a context? oc from the command line works out of the box with the chosen context? Or does this also give some integration in UIs ?

I had the same initial reaction as Christophe where I was trying to figure out how this would take effect or if I had a terminal window open whether it would switch. I really like it though, it's much quicker to see the current context, see the other options, or switch it than any other way to do those things.
Since this is useful for easily checking the current context, IMHO the word 'changed' should be removed to make that more natural.

I changed the wording to "Kubernetes context". Check the new screenshot in PR description :)


[WIP] Add coverage to internal/blueprints

I will be adding more commits to this PR. I'll be happy for any comments. This will fix https://github.com/osbuild/osbuild-composer/issues/362 once ready to merge.

The added test looks good (just some white-space error). I think @ondrejbudai wrote the original tests for blueprints, would you like to have a look at that change?

@atodorov Alright, it's ready now. Thanks for the review. I wanted to cover customizations.go as a part of this but I can always make another PR.


[WIP] (not ready) AFE framework

VarianceThreshold passing, need to rework the tests/code for SelectPercentile, SelectKBest.
need a plan for https://github.com/onnx/onnx/blob/master/docs/Operators-ml.md#ai.onnx.ml.ArrayFeatureExtractor, which might be blocking #197
Closes #134

Codecov Report

Merging #198 into master will decrease coverage by 0.46%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   94.06%   93.60%   -0.47%
==========================================
  Files          32       34       +2
  Lines        1803     1844      +41
  Branches      322      325       +3
==========================================
+ Hits         1696     1726      +30
- Misses         56       65       +9
- Partials       51       53       +2

Flag
Coverage Δ

#unittests
93.60% <74.41%> (-0.47%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...operator_converters/skl_array_feature_extractor.py
65.21% <65.21%> (ø)

...erters/_array_feature_extractor_implementations.py
82.35% <82.35%> (ø)

hummingbird/ml/operator_converters/__init__.py
100.00% <100.00%> (ø)

hummingbird/ml/supported.py
88.88% <100.00%> (+0.17%)
:arrow_up:

...rd/ml/operator_converters/_tree_implementations.py
98.07% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b23a2...c7b57c6. Read the comment docs.


Problems don't clear when closing and reopening file.

Related issues
https://github.com/microsoft/vscode/issues/52348
https://github.com/microsoft/vscode/issues/53944
https://github.com/Microsoft/vscode/issues/52348

VSCode Version: Version 1.35.1 (1.35.1)
OS Version: MacOS 10.14.5 (18F203) Mojave

Steps to Reproduce:

Have a problem with the code.
Change git branches so the working directory has correct, problem-free code.
Problems still exist but the file is updated. Close file.
Reopen file, problems don't clear.

This is for JavaScript or TypeScript, correct? Can you please provide specific repo steps for this issue. Depending on how large the branch change is, it may take a moment for the problems to be updated but they should eventually be updated for all js/ts files open in VS Code


Renaming folder

Renaming folder resulted to the following error while running application on a development local server:
"Error: EPERM: operation not permitted, rename"

/needsMoreInfo including platform, version etc.

Also are you using WSL?


Bug in slider.

Pictures are not clear enough and the size is also too large that looks quite strange.

Please assign me this issue.

@tjanhvi this issue is already open.


Followup on Gallery submission

Hello @Wit4r7,
Seems you might’ve missed the request for changes necessary for inclusion in the Gallery, so commenting here as an alternative channel.
Have a nice weekend.

Thanks for the reminder. I updated the workflow.


Signin page responsive issue

Design Link: https://www.figma.com/file/5aY5dYCAvYyqRvEvaoXXNP/Common?node-id=26450%3A354534&t=pFUaE6mGl3AHJAkn-1


Chinese Font Support

Hi,
How to create chinese font map file?

Unfortunately, gofpdf doesn't support Chinese fonts. See Don't support Chinese, Korean and Japanese fonts ? for more details.
I hope this feature can be included someday.


Improve protocol link handling around windowId=_blank support

Protocol links can use windowId=_blank to indicate that they want a fresh window to be handled in. This works fine in most cases except when VS Code is not running. In that case, we first restore the previous session only then to open another empty window to handle the protocol link in. A better solution is to open an empty window right from the beginning and then handle the link in there.
The code that deals with protocol links is incredibly complex and spaghetti.  Will try to cleanup the existing implementation but will resort to explanatory comments in most cases where cleanup is not helping reduce complexity.
Refs: https://github.com/github/codespaces/issues/9792

Good to go for a review.


Vue is not defined (dev + build)

Hello, I have a issue that looks similar to #8 but which also happens during the dev process and with another library.
One year ago I have made a panel field plugin which uses some of the components provided by vue-grid-layout. At that time I did the plugin compilation with Parcel 1 and it worked, but now Parcel 1 seems to be obsolete and I cannot make it work with Parcel 2.
So I thought I could use Kirbyup to do it as it seems to be simpler, but I am struggling to make it work either.
There is a Vue is not defined error which is thrown in the browser console during dev or after a build process.
Like for Sylvain, the error is related to the following line from the compiled js file :
(...) window.panel.plugin("samrm/dda-mosaic",{fields:{mosaic:_n},blocks:{mosaic:ri}})})(Vue);
It seems Vue is imported somewhere inside vue-grid-layout which breaks the process, but I don't think any call to Vue.extend is in use here.
Any idea on how to handle this issue? Does it make sense to try to adapt the patch you provided to Sylvain (which seems to be designed specially for the build process)?
Thanks!

If I may add : vue-grid-layout 2.4.0 is installed as a dependency and the GridLayout and GridItem components are imported from vue-grid-layout inside a wrapper component which is used for the panel field.

Seems like the vue-grid-layout library imports Vue to use it as an EventBus. Since Vue is imported in the library, kirbyup will externalize it.
A cleaner solution would be to use a library like mitt for the EventBus, instead of initializing Vue. The latter one was/is common in Vue 2 contexts. Vue 3 dropped this feature.
Nevertheless, a fix would require changes to the vue-grid-layout. You could duplicate the components of the library and replace the EventBus with another library.

Nevertheless, a fix would require changes to the vue-grid-layout. You could duplicate the components of the library and replace the EventBus with another library.

Indeed, thank you for the advice! I imported a custom version of the library, using mitt as eventBus and it works well.

I don't know how Parcel handled this behavior. Maybe it bundled Vue itself into the Panel build? How big was your bundle?

The previous build with Parcel v1 was 230kb, now with kirbyup and without the Vue import it weights 131kb!
Thank you again for your help!

I appreciate you took the time to refactor the library. Occasionally I give tips on how to implement something in an issue, which then doesn't happen because of the effort involved for the person asking. Glad to know that the effort for myself writing the answer was worth it!

FWIW, I've raised the core issue – Kirby exposing the Vue constructor only via use so plugins can't target it – in https://github.com/getkirby/kirby/issues/4735. Aside from the occasional compat issues we have like this one or https://github.com/johannschopplich/kirbyup/issues/8, the way Vue is provided right now also completely prohibits using Vue 2.7 functionality like dynamic CSS variables or setup functions :(

Great! Thank you so much for raising that discussion up!


MicrosoftTeams Powershell 2.3.1 errors using Connect-MicrosoftTeams to create session

Since the cutover to using the new connection method, the Teams cmdlets have been unreliable. The past two days I can't connect at all and I'm getting the following errors on an up-to-date Win10 machine running PS version 5.1.19041.906, and MicrosoftTeams version 2.3.1.
PS C:\users\jmcarthur> Get-CsOnlineUser $upn
Get-CsOnlineSession : Connecting to remote server api.interfaces.records.teams.microsoft.com failed with the following error message : The connection to the specified remote host
was refused. Verify that the WS-Management service is running on the remote host and configured to listen for requests on the correct port and HTTP URL. For more information, see
the about_Remote_Troubleshooting Help topic.
At C:\Program Files\WindowsPowerShell\Modules\MicrosoftTeams\2.3.1\net472\SfBORemotePowershellModule.psm1:63 char:22
+     $remoteSession = & (Get-CsOnlineSessionCommand)
+                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-CsOnlineSession], PSRemotingTransportException
    + FullyQualifiedErrorId : PSRemotingTransportException,Microsoft.Teams.ConfigApi.Cmdlets.GetCsOnlineSession

Invoke-Command : Cannot validate argument on parameter 'Session'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
At C:\Program Files\WindowsPowerShell\Modules\MicrosoftTeams\2.3.1\net472\SfBORemotePowershellModule.psm1:9490 char:38
+ ...    -Session (Get-PSImplicitRemotingSession -CommandName 'Get-CsOnline ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Invoke-Command], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.PowerShell.Commands.InvokeCommandCommand

Reinstalling the module has fixed this for now, but as mentioned, some days the module works and others it does not.

Hello @jmcarthurcorr Jared, how are you? hope you are doing great.
Here, we are limited to documentation fixes, if you experience issues as you described, the best would be to open a support ticket directly from your tenant.
Hope this information helps you.

@get-itips Thank you very much for the contribution and sharing this explanation. @jmcarthurcorr Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


edwardgeorge/jq-action@main generates deprecation warnings

https://github.com/cloudposse/github-action-docker-build-push/blob/f1139911cacb0c4e6a2a79ae5c215684e87fd8fb/action.yml#L144
The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
The following actions uses node12 which is deprecated and will be forced to run on node16: edwardgeorge/jq-action@main. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Seems this action is quite old

This was resolved with https://github.com/cloudposse/github-action-docker-build-push/pull/59
https://github.com/cloudposse/github-action-jq/blob/c3a312ac606d8588cc9c34597234ddfc7a7129b8/package.json#L21
https://github.com/cloudposse/github-action-jq/blob/c3a312ac606d8588cc9c34597234ddfc7a7129b8/action.yml#L26


move UNKNOWN to not be last

we create-user with the lowest permission by default, which relies on our permissions list being ordered
default=[p.name for p in Permission][-1]'
moving UNKNOWN to the top of the list so that SERVICE is the "lowest" permission

Not a huge fan of having to keep enum values ordered. Why not just changing the default of create-user to Permission.SERVICE.name?

presumably in case we add a lower permission? i dont have strong preference between this and hardcoding SERVICE


Cloud Error Reporting Exception Filter for ASP.NET MVC Applications.

The current exception logger only works for Web Api Applications.

@csells FYI

I'm at NDC today/tomorrow; will look on Friday unless @evildour has approved it before then :)


split Fuzzy zkapp tests into two: quick and long

Split Fuzzy Zkapp tests into two tests:

Quick on PR (5minutes)
Longer on stable (20 minutes)

I also refactored zkapp dhall Jobs and introduced common Command which then is used depending on context

!ci-build-me

!ci-nightly-me

!ci-build-me test is green on the first try!

!ci-build-me

!ci-build-me

No longer needed since we retired fuzzy tests


Dose the random variables have pdf?

Dose the random variables have pdf? For example, a=gaussian(), a.pdf(0) == 1

No sorry, pdf is not implemented


Update Ansible installation instructions

As Ansible 2.0 has been released for a long time, there is no obvious reason not to use a pip-installed Ansible. This also simplifies the installation instructions.

Reckon it's worth suggesting shade if this is used with OpenStack?

@manics: pushed

Apart from one comment looks good to me

@manics: done, the scripted part is unnecessary indeed as one should activate the virtual environment and has been removed.

:+1:


Docker-Machine - VM created in Virtualbox with Azure driver - internal failure while setting the bit

The VM created fine. I can ssh into the VM. I can run basic docker commands such as info, run, images etc.
When I execute the following command: docker run -itd -P tutum/hello-world I'm getting the following error.
docker: Error response from daemon: internal failure while setting the bit: open /var/lib/docker/network/files/local-kv.db: no such file or directory.

& here too :D Sir @nathanleclaire

This seems to be duplicate of https://github.com/docker/machine/issues/3240

Sorry Nathan for the duplication!


Services: list, call, response

An example implementation of calling ROS 2 services from a bridge can be found here: https://github.com/v-kiniv/rws/blob/main/src/client_handler.cpp#L406-L450. The method is straightforward, most of the work is in JSON<->CDR serde. We can avoid this by using our client binary serialization already used for topic publishing.

Based on the ROS 2 notes above, I think the bridge protocol for services could roughly look like this:

op: advertiseService // server -> client
op: unadvertiseService // server -> client
op: callService // client -> server
op: serviceAcknowledgement // server -> client
op: serviceResponse // server -> client

op: serviceAcknowledgement // server -> client

What is this for? Acknowledging a client's service call request?

Let's drop serviceAcknowledgement, but send an error back if the service is not running or there's another failure to initiate the service call.


Api 3017 add document strategies to client credential flow

Patient Id (launch) and Hashed access token will be saved to new ClientCredentials table if there is a launch parameter.
New values must be added to the config files:
"dynamo_client_credentials_table": "ClientCredentials",
"hmac_secret": "secret"

RegressionTests_Testing_API-3017.docx

I am still not yet sure if this isn't an issue with my configuration. But this is from a fresh start.
{
  "service": "oauth-proxy",
  "code": "ERR_INVALID_ARG_TYPE",
  "level": "error",
  "message": "Could not update the access token token in DynamoDBThe \"key\" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined",
  "stack": "TypeError [ERR_INVALID_ARG_TYPE]: The \"key\" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined\n    at prepareSecretKey (internal/crypto/keys.js:322:11)\n    at new Hmac (internal/crypto/hash.js:113:9)\n    at Object.createHmac (crypto.js:147:10)\n    at SaveDocumentLaunchStrategy.hashString [as hashingFunction] (/home/node/utils.js:77:23)\n    at SaveDocumentLaunchStrategy.saveDocumentToDynamo (/home/node/oauthHandlers/tokenHandlerStrategyClasses/saveDocumentStrategies/saveDocumentLaunchStrategy.js:13:32)\n    at TokenHandlerClient.handleToken (/home/node/oauthHandlers/tokenHandlerStrategyClasses/tokenHandlerClient.js:41:47)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process
/task_queues.js:97:5)\n    at async Object.tokenHandler (/home/node/oauthHandlers/tokenHandler.js:43:21)\n    at async /home/node/index.js:378:7",
  "time": "2020-11-10T01:34:18.224Z"
}

I am still not yet sure if this isn't an issue with my configuration. But this is from a fresh start.
{
  "service": "oauth-proxy",
  "code": "ERR_INVALID_ARG_TYPE",
  "level": "error",
  "message": "Could not update the access token token in DynamoDBThe \"key\" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined",
  "stack": "TypeError [ERR_INVALID_ARG_TYPE]: The \"key\" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined\n    at prepareSecretKey (internal/crypto/keys.js:322:11)\n    at new Hmac (internal/crypto/hash.js:113:9)\n    at Object.createHmac (crypto.js:147:10)\n    at SaveDocumentLaunchStrategy.hashString [as hashingFunction] (/home/node/utils.js:77:23)\n    at SaveDocumentLaunchStrategy.saveDocumentToDynamo (/home/node/oauthHandlers/tokenHandlerStrategyClasses/saveDocumentStrategies/saveDocumentLaunchStrategy.js:13:32)\n    at TokenHandlerClient.handleToken (/home/node/oauthHandlers/tokenHandlerStrategyClasses/tokenHandlerClient.js:41:47)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process
/task_queues.js:97:5)\n    at async Object.tokenHandler (/home/node/oauthHandlers/tokenHandler.js:43:21)\n    at async /home/node/index.js:378:7",
  "time": "2020-11-10T01:34:18.224Z"
}

It was an issue with my config. Happy path works for me now.

For the client credentials route I still get the following after introspection.
{   "active": true,   "scope": "launch/patient",   "exp":<PHONE_NUMBER>,   "iat":<PHONE_NUMBER>, ...  }


Some macros are redefined

For example: ZSTD_STATIC_LINKING_ONLY.
Ideally no macros would be redefined as that's a compiler warning.

The code is compiled with -Wmacro-redefined,
and it never triggers any warning.
I suspect that's because, if such a case happen,
macros are just re-defined to exact same values,
which seems good enough to not trigger any warning.
In which case do you see any warning ?

I pass in -DZSTD_STATIC_LINKING_ONLY to be sure to get correct signatures.
My build log:
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/common/zstd_common.o ext/zstd/lib/common/zstd_common.c
ext/zstd/lib/common/zstd_common.c:38:0: warning: "ZSTD_STATIC_LINKING_ONLY" redefined
 #define ZSTD_STATIC_LINKING_ONLY

<command-line>:0:0: note: this is the location of the previous definition
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/common/fse_decompress.o ext/zstd/lib/common/fse_decompress.c
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/common/xxhash.o ext/zstd/lib/common/xxhash.c
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/common/entropy_common.o ext/zstd/lib/common/entropy_common.c
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/compress/fse_compress.o ext/zstd/lib/compress/fse_compress.c
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/compress/zstd_compress.o ext/zstd/lib/compress/zstd_compress.c
In file included from ext/zstd/lib/compress/zstd_compress.c:62:0:
ext/zstd/lib/common/zstd_internal.h:40:0: warning: "ZSTD_STATIC_LINKING_ONLY" redefined
 #define ZSTD_STATIC_LINKING_ONLY

<command-line>:0:0: note: this is the location of the previous definition
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/compress/huf_compress.o ext/zstd/lib/compress/huf_compress.c
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/compress/zbuff_compress.o ext/zstd/lib/compress/zbuff_compress.c
In file included from ext/zstd/lib/compress/zbuff_compress.c:38:0:
ext/zstd/lib/common/zstd_internal.h:40:0: warning: "ZSTD_STATIC_LINKING_ONLY" redefined
 #define ZSTD_STATIC_LINKING_ONLY

<command-line>:0:0: note: this is the location of the previous definition
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/decompress/zbuff_decompress.o ext/zstd/lib/decompress/zbuff_decompress.c
In file included from ext/zstd/lib/decompress/zbuff_decompress.c:38:0:
ext/zstd/lib/common/zstd_internal.h:40:0: warning: "ZSTD_STATIC_LINKING_ONLY" redefined
 #define ZSTD_STATIC_LINKING_ONLY

<command-line>:0:0: note: this is the location of the previous definition
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/decompress/zstd_decompress.o ext/zstd/lib/decompress/zstd_decompress.c
In file included from ext/zstd/lib/decompress/zstd_decompress.c:65:0:
ext/zstd/lib/common/zstd_internal.h:40:0: warning: "ZSTD_STATIC_LINKING_ONLY" redefined
 #define ZSTD_STATIC_LINKING_ONLY

<command-line>:0:0: note: this is the location of the previous definition
gcc -O3 -fomit-frame-pointer -std=c11 -pipe  -Iext/zstd/lib -Iext/zstd/lib/common -DZSTD_STATIC_LINKING_ONLY -c -oout/build/zstd/obj/decompress/huf_decompress.o ext/zstd/lib/decompress/huf_decompress.c

OK
It seems that, when using -DZSTD_STATIC_LINKING_ONLY, compiler automatically defines it to 1, which is different from empty. Hence the redefinition warnings.
One would need to do -DZSTD_STATIC_LINKING_ONLY= to define it to empty, resulting in the same definition as in the file, and as a consequence no warning.
But the most important point is probably : why do you have to do this ?
ZSTD_STATIC_LINKING_ONLY is supposed to be a protection macro, defined just before zstd.h to enable experimental functions.
Defining it at project level defeats the protection, and forcefully brings the definition into internal sections of the library which were never supposed to receive one.
I may be missing some context element to understand why you need to do that.

Okay, thanks for the explanation and your time


some ops not work.

For example, graph.shape:
const tf = require('../../');
const graph = tf.graph();
const session = tf.session();

const input = tf.tensor([[1, 2, 3], [4, 5, 6]], tf.dtype.int32, [2, 3]);
const shape = graph.shape(input);

2017-08-02 21:53:07.141389: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:07.141973: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:07.141979: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:07.141984: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
[1]    27975 segmentation fault  node test/ops/nn.test.js

2017-08-02 21:53:09.626448: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:09.627109: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:09.627115: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:09.627119: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
node(27999,0x7fff720ef000) malloc: *** mach_vm_map(size=17042544937633144832) failed (error code=3)
*** error: can't allocate region
*** set a breakpoint in malloc_error_break to debug
libc++abi.dylib: terminating with uncaught exception of type std::bad_alloc: std::bad_alloc
[1]    27999 abort      node test/ops/nn.test.js

2017-08-02 21:53:10.690841: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:10.691403: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:10.691409: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-02 21:53:10.691414: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
/Users/eric/work/github/tensorflow-nodejs.bk/lib/graph.js:140
      op.finish();
         ^

Error
    at Error (native)
    at Graph.createOperationFromBuilder [as shape] (/Users/eric/work/github/tensorflow-nodejs.bk/lib/graph.js:140:10)
    at Object.<anonymous> (/Users/eric/work/github/tensorflow-nodejs.bk/test/ops/nn.test.js:8:21)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:389:7)

some errors above.

Got the following error from gdb/lldb:
* thread #1: tid = 0xe373d, 0x0000000106e73cb1 libtensorflow.so`tensorflow::NodeBuilder::NodeOut::NodeOut(tensorflow::Node*, int) + 33, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x98)
  * frame #0: 0x0000000106e73cb1 libtensorflow.so`tensorflow::NodeBuilder::NodeOut::NodeOut(tensorflow::Node*, int) + 33
    frame #1: 0x0000000106e74e8d libtensorflow.so`void std::__1::vector<tensorflow::NodeBuilder::NodeOut, std::__1::allocator<tensorflow::NodeBuilder::NodeOut> >::__emplace_back_slow_path<tensorflow::Node* const&, int const&>(tensorflow::Node* const&&&, int const&&&) + 253
    frame #2: 0x0000000106e7420b libtensorflow.so`tensorflow::NodeBuilder::Input(tensorflow::Node*, int) + 91
    frame #3: 0x00000001022302a4 tensorflow.node`TensorflowNode::Operation::AddInput(info=0x00007fff5fbfe118) + 250 at operation.cc:245 [opt]
    frame #4: 0x000000010222c67c tensorflow.node`Nan::imp::FunctionCallbackWrapper(info=0x00007fff5fbfe190) + 137 at nan_callbacks_12_inl.h:174 [opt]
    frame #5: 0x000000010017b0c2 node`v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) + 466
    frame #6: 0x00000001001e6eef node`v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) + 911
    frame #7: 0x00000001001e6449 node`v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) + 281

Ah, this is because the all ops only can accept the Operation as its inputs except for graph.constant, passing a Tensor causes this problem @zihan-git

BTW, may I ask you to fix this problem by checking the type of input and make always be an operation for ops like the following?
if (input instanceof tensorflow.Tensor) {
  input = this.constant(input);
}


Generic dataset module and specific s3_datasets module - part 2 (implement db models/repos and enums)

Feature or Bugfix

Refactoring

Detail
⚠ This PR should be merged after #1250.
As explained in the design for #1123 we are trying to implement a generic datasets_base module that can be used by any type of datasets in a generic way.
This PR:

Creates the skeleton of the datasets_base module consisting of 3 packages: db, api, services. And adds the __init__ file.
Adds the dependency of s3_datasets to datasets_base in the __init__ file of the s3_datasets module
Moves datasets_enums to datasets_base
Adds a generic Dataset model in datasets_base that is used in s3_datasets to build the S3Dataset model using inheritance in sqlalchemy
Fixes all the usages of Dataset vs S3Dataset
Moves DatasetLock model to dataset_base db models
Split the DatasetRepository into an S3 dedicated S3DatasetRepository and 2 repositories in datasets_base DatasetRepository and DatasetListRepository

The commits follow more or less an order, so I recommend following the commits to review the PR. Some names are not the best ones at the moment, but I did not want to pollute this PR with more renaming
In follow-up PRs:

permissions split (or no split)
datasets_base services
datasets_base API
frontend

Relates

#1123
#955

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing this PR, I will break it into smaller PRs


Refactored send() and added String support to API

Default value for last argument to send()
Safer handling of maximum message buffer length
Support for String use in API

Nice!!


Rails & govuk-frontend updgrades

Context
A bunch of dependabot PRs needed a bit of finessing.
Changes proposed in this pull request
Upgrade:

rails
govuk-frontend
govuk_design_system_formbuilder

Guidance to review
Quite a lot of changes here including some visual differences, most notably the casing of the tag component.
Checklist

[x] Attach to Trello card
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally

 Upgrade rails, govuk-frontend, govuk-components


[9.x] Model::whereRelation ignores the callback function or does it wrong

Eloquent
$userSQL = User::whereRelation(
    "posts",
    function($query) {
        // THIS
        $query->selectRaw("id")->limit(1)->where("public", true);
    }
)->toSql();

Query
$dbSQL = DB::table("users")->whereExists(
    function ($builder) {
        // relations simulation
        $builder->from("posts")->addSelect(['*'])->whereColumn(
            'users.id', '=', 'posts.user_id'
        );
        // THIS
        $builder->selectRaw("id")->limit(1)->where("public", true);
    }
)->toSql();

Eloquent output
select *
from "users"
where exists (
   select *
   from "posts"
   where "users"."id" = "posts"."user_id" and ("public" = ?)
)

Query output
select *
from "users"
where exists (
   select *, id
   from "posts"
   where "users"."id" = "posts"."user_id" and "public" = ? limit 1
)

The reason is not known to me. But the error is generated only from the model.
Once you study the question, everything becomes easy.
The problem is in this piece of code.
QueriesRelationships::whereRelation
    public function whereRelation($relation, $column, $operator = null, $value = null)
    {
        return $this->whereHas($relation, function ($query) use ($column, $operator, $value) {
            $query->where($column, $operator, $value);
        });
    }

QueriesRelationships::orWhereRelation
    public function orWhereRelation($relation, $column, $operator = null, $value = null)
    {
        return $this->orWhereHas($relation, function ($query) use ($column, $operator, $value) {
            $query->where($column, $operator, $value);
        });
    }

I realized that it works like levels. But at the last level, it cannot pass parameters such as "Limit" "Select" and so on. since it is only responsible for "where". After that, all parameters except "where" are excluded and we get an error.

I agree I could have used a different method. For example "whereHas" instead of "whereRelation".

As I understand it, the last one who changed this code was Italo DarkGhostHunter.
Pull Request [8.x] Adds a simple where helper for querying relations #38499

(checking...)

Well, it's expected:

Add a basic where clause to a relationship query.

I don't remember why I didn't do that in the first place, I think it was because the callback was already handled by Eloquent where() and it doesn't replaces whereHas(), which is a convenience method for has() with a callback where you have more control.

Well, it's expected:

Add a basic where clause to a relationship query.

I don't remember why I didn't do that in the first place, I think it was because the callback was already handled by Eloquent where() and it doesn't replaces whereHas(), which is a convenience method for has() with a callback where you have more control.

I'm sorry I commented on you. I thought you should see.

@GrahamCampbell "Changed name" Thanks for correcting me!

We don't document using these methods this way.

@taylorotwell I did an analogy.
where(callback)
...
has('relation', '>=', 1, "and", callback)
whereHas('relation', callback)
whereRelation() // no callback function
doesntHave('relation', operator, callback)
whereDoesntHave('relation', callback)
whereHasMorph('relation', [], callback)
whereDoesntHaveMorph('relation', [], callback)
I agree it's not in the documentation.
But as I understood by researching other methods, it is always possible to specify a callback function.
Also, not everything is described in the documentation.
Example 1 (method has)
There is no information that the 4th argument is a callback.
Example 2 (method doesntHave)
There is no information that the 3th argument is a callback.
In the last pull request you told me.
"All changes should follow the Laravel approach."
I believe that the current change does not violate the Laravel approach.
The developer who implemented this method said. DarkGhostHunter: I don't remember why I didn't do that in the first place, I think it was because the callback was already handled by Eloquent where() and it doesn't replaces whereHas(), which is a convenience method for has() with a callback where you have more control.
I don't know why you think the current addition is wrong.
I followed the Laravel approach.
This is not a critical addition.
You or I can add information to the documentation.
Tell me how it would be better. I'll fix it.

@taylorotwell I think we're talking about a supplement. I'm not sure if this is a mistake. But many expect a different result using this method.

please show this


Update index and code lesson intro

WIP - since red CI bugs me :rofl:
Closes #53

@willingc I just opened #57. This should make CI totally happy. I'm sorry ! I didn't realize you were working on this too. it's just related to the targets that I setup!

@lwasser No worries. I'll rebase on top of your merged PR to see if there are any differences.

haha i am so sorry for adding red checks into the mix in the 11th hour

OK. Verified no stray commits and will close.


Workaround bug in older tensorflow versions.

Will wait for Scott to test before merging.

Scott tested this and it worked.

Scott tested this and it worked.


text_layer_builder: set .textLayer to display:none in @media print mode.

Sort-of hacky fix for #5831.
Boy, this brings back the memories, doesn't it? :smile:

/botio-linux preview

Aw, it doesn't work. :cry: I wonder what's going on here then...? Why does the text encoding suddenly change on the 8th page.


Feature Request: Use a Secret for HEC Token

This is a two-part feature request related to the security of the HEC Token:

The token should be stored in a secret. It can be mounted from the StatefulSet as an environment variable by simply referencing the secret.
Allow referencing your own secret. Storing the token using plain-text in values.yaml and then committing it to a git repository has potential security implications.

If I am overlooking something or there is an obvious work-around, then feel free to share that information and close this issue.
Thanks!

Agree will look at this post 2.0

@kurtismullins
Work around would be using CI/CD pipeline with the secret as a variable in the pipeline. This way when its deployed the text is replaced, sanitary git repo and yet its auto included in the CD pipeline.

@satellite-no
This may be a valid work-around for some environments, agreed. Thank you for that suggestion!
Unfortunately, we don't have a good place in our pipeline to inject a token from a vault. Even if we did, I would feel much more comfortable storing this token as a Kubernetes Secret than as plain-text within a ConfigMap.

:tada: This issue has been resolved in version 2.35.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error loading if cassette counter is reset

If you click "Replace Cassette" in the app, the timeLeftText variable won't be available until another test is performed, and the integration won't load.  Perhaps a conditional check can be put in to continue loading if it isn't available:
2024-05-29 10:13:18.261 INFO (SyncWorker_1) [custom_components.waterguru.waterguru] Fetching data from WaterGuru API...
2024-05-29 10:13:26.302 ERROR (MainThread) [custom_components.waterguru] Unexpected error fetching waterguru data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 315, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 271, in _async_update_data
    return await self.update_method()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/waterguru/__init__.py", line 39, in _update_method
    return await hass.async_add_executor_job(waterguru.get)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/waterguru/waterguru.py", line 77, in get
    return {waterBodyData['waterBodyId']: WaterGuruDevice(waterBodyData) for waterBodyData in data['waterBodies']}
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/waterguru/waterguru.py", line 98, in __init__
    if "days" in r['timeLeftText']:
                 ~^^^^^^^^^^^^^^^^
KeyError: 'timeLeftText'

This is what the API returns when the cassette is at 100%   (button has been pushed in app)

I noticed that missing data for a while and wondered why.
What i am seeing in HA is the same number displayed in the app without the units.  When I first replaced the cartridge the number was 2 and the unit was months.  The next day it was 8 and weeks.
If the units -- days, weeks, or months is not available in the API, perhaps you could include pctLeft as an attribute.  I know that when I load a new cartridge it is good for 60 days.  With pctLeft, I could calculate the correct number of days.
Anything you can do to resolve this will be greatly appreciated.
Thanks for your help.

Thanks for the report. This is fixed in the latest code. Note that you may have to reload the integration to get the Cassette Days Remaining sensor to work after the first test, but at least it won't fail to setup now.


CI: external-tests (95-test_external_krb5.t) fail for each PR

Any chance to get this fixed soon?

Ok

Ok

There is some work in progress in https://github.com/openssl/openssl/pull/14872

@DDvO the #14872 now finally resolves this.


Clean up old iptables (pre-ip-per-service) legacy

LGTM
Can be merged by oncall during merge hours.


Tasks 1400-1425: Assigning categories, domains and addressing feedback

categoires and domains are ready to be merged @danyaljj

We can merge this PR @danyaljj  if you are happy with feedback addressing.


Improve code coverage

Resolves #461

Update npm test-related libraries, and settings
Update contributors.spec.js to passing
Increase test coverage for:

Link
loading Search Tips
resetting in middle of Tag Generator.

Refactored:

renamed data-cy=generateButton to generate-button, added add-tags-button and reset-form-button
refactored Links without destinations in Refine Results to use buttons per https://material-ui.com/components/links/#accessibility

Ran ESLint / Prettier
Excluded Landing page

After this, code coverage is once again over the target value of 90%. See the report at https://cti-code-coverage-report.netlify.app/
Overall coverage is 90.6% but that is still down from 91.9% a few weeks ago. We have many new functions (we've gone from 169 functions to 234 functions in the last month). We need to create even more code coverage, but this PR is a good start!

#524 was replacement for this PR.


Make polyfill optional in 6to5/register

I am using latest unstable Node.js (v0.11.14), which has a native WeakMap implementation, (and some other ES6 features built-in) but polyfill that is included automatically (core.js) replaces that implementation with its own. It would be very good to make polyfill optional.

What do you mean? The polyfill is optional?

I don't believe there's a way to run 6to5-node without also loading the polyfill.
6to5-node should probably accept the same arguments as 6to5 itself.
6to5-node --whitelist arrowFunctions

though my above suggestion does pollute the "it's just node" flags on 6to5-node. Reading config from .6to5rc file ala https://github.com/6to5/6to5/issues/351 would get around that

There's no way to do this without breaking backwards compatibility unless I add an environment variable or some other way to tell 6to5/register to not include the polyfill.

@sebmck I mean, it would be awesome to have an option, whether to include a polyfill or not. I opened this issue, because of that - https://github.com/zloirock/core-js/issues/8.
P.S. @timoxley has also suggested a great improvement.

Except the polyfill is required in order for everything to work. 6to5 uses Array.from for example in quite a few transformers and it's not supported in even the latest unstable node.
$ node -v
v0.11.14
$ node --harmony
> Array.from
undefined

This will cause many things to fall flat on their face and you'd have to use some sort of polyfill one way or another.

6to5/register is supposed to replicate an entire ES6 environment which is why the polyfill is required in the first place. I'm open to adding an option to make it optional but with the current implementation there's no way to without breaking backwards compatibility. To me it seems like the real solution is for core-js to not override defaults.
/cc @zloirock

To me it seems like the real solution is for core-js to not override defaults. exactly, I opened an issue on core-js repository mentioning that. But until then, a simple option (like polyfill: false) would solve this problem. And as for functions that 6to5 needs, I think the right thing would be to copy implementations of functions you need, like Array.from and not force loading a polyfill, which replaces native implementation (no idea why would some library do that, I assume it's just a bug).

The polyfill is required on require("6to5/register"); which makes it impossible to disable by invoking the exported config function.

Alright, we'll wait for core-js to fix this issue then.

core-js actually tests the current environment for full spec-compliance of a feature as it's existence doesn't guarantee it's correctness.
$ node --harmony
> require("core-js");
...
> WeakMap.prototype.get + ""
'function get() { [native code] }'

Looks like it just overrides the WeakMap constructor and retains it's prototype.

Try:
var map = new WeakMap;
map.set('invalid_key', 123);

Error will be thrown and in the stack trace you'll see that it points to core-js/shim.

$ node --harmony
> require("core-js");
> WeakMap.prototype.set + ""
'function (a, b){\r\n        var result = method.call(this, a === 0 ? 0 : a, b);\r\n        return chain ? this : result;\r\n      }'
> var map = new WeakMap;
undefined
> map.set('invalid_key', 123);
TypeError: Invalid value used as weak map key
    at WeakMap.set (native)

It wraps the native method for correctness.

Oooh damn, it's my fault, sorry Sebastian.  Thank you for explaining this and thank you for 6to5!

@vdemedes It's all good! Better to be safe then sorry. I didn't realise how intricately core-js checks were, awesome work @zloirock.

Core.js uses native WeakMap, if it exists, just fixes constructor for init from iterable and .set for chaining.
var a = {}, b = {};

new WeakMap([[a, 1], [b, 2]]).has(a);     // => false
new WeakMap().set(a, 1).set(b, 2).has(a); // TypeError: Cannot call method 'set' of undefined

require('core-js'); // WeakMap still returns native weakmap

new WeakMap([[a, 1], [b, 2]]).has(a);     // => true
new WeakMap().set(a, 1).set(b, 2).has(a); // => true

About "intricately core-js checks" - this wrap uses also for fix converting negative-zero-key to positive zero for Map and Set.
I can add the option to not fix buggy implementations, but don't think it is necessary.


@conda-forge-admin,please add bot automerge

As per title.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/dimcli-feedstock#3.


Generate library based on public googleapi protos

blocked by #8<EMAIL_ADDRESS>

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           4      4
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bca4b...7dc1848. Read the comment docs.


How To Use?

I downloaded this file to update my small resource pack I'm making, but i have no idea how to use this. I saw something about putting a line in the command prompt, but I'm having trouble understanding if input directory is like the actual directory of the file? I have also tried putting the file in the resource pack and making a .bat file with the line meant for the command prompt (java -jar ResourcePackConverter.jar) but I'm still having problems. Sorry if this isn't the place to post this, or I'm wasting your time. I was just hoping I could save some time!

i put the file and bat file in the same directory and ran it but it only converted the assets, hmm.

nevermind i waited loner and it worked, if the pack works ill close this issue

it works now but there's a new issue, ill create a new issue for this and close this one


Questions about Loss

Hi, Thank you for your fantastic project.
I'm a little confused about gap loss or triplet loss.
before_clamp_loss = loss_anc_pos - loss_anc_neg + self.triplet_loss_gamma

We know that both loss_anc_pos and loss_anc_neg are in a -log manifold, but the triplet_loss_gamma is a constant. When the score is low, the difference between positive loss and negative loss will become large, which may causes the triplet_loss_gamma to not work well.
There is an example:

the positive score is 0.1, the negative score is 0.01, and  triplet_loss_gamma is set to 1. their loss equals -log(0.1) - (-log(0.01))+1=2.3-4.6+1<0
The loss will be ignored, but the negative score is only 0.09 worse than positive score.
The above is my confusion.

Hi，
Actually, if you double check the code, both gap loss and triplet loss are not in a log manifold, as the scores have been pre-processed by exp().
Similar operation can also be observed in circle loss using logsumexp().
The problem you describe is one that we need to avoid when designing a loss.
------------------ 原始邮件 ------------------
发件人:                                                                                "chenghao-shi/MDGAT-matcher"                                                                                @.>;
发送时间: 2022年4月25日(星期一) 下午4:23
@.>;
@.***>;
主题: [chenghao-shi/MDGAT-matcher] Questions about Loss (Issue #7)
Hi, Thank you for your fantastic project.
I'm a little confused about gap loss or triplet loss.
before_clamp_loss = loss_anc_pos - loss_anc_neg + self.triplet_loss_gamma
We know that both loss_anc_pos and loss_anc_neg are in a -log manifold, but the triplet_loss_gamma is a constant. When the score is low, the difference between positive loss and negative loss will become large, which may causes the triplet_loss_gamma to not work well.
There is an example:
the positive score is 0.1, the negative score is 0.01, and  triplet_loss_gamma is set to 1. their loss equals -log(0.1) - (-log(0.01))+1=2.3-4.6+1<0
The loss will be ignored, but the negative score is only 0.09 worse than positive score.
The above is my confusion.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Your answer solved my question. Thanks a lot!


issue with trying to get it working on lambda

Hello,
love this project as their isnt a alternative for git for python on lambdas.
subprocess.call(["pip","install","lambda-git"]) this is used to install the module but when i try to import afterwards i get this error.
"errorMessage": "[Errno 2] No such file or directory: '/var/task/vendor/git-2.4.3.tar'"
am i missing something ?

@ashleybeshir thanks for opening an issue. are you trying to run that subprocess.call(["pip","install","lambda-git"]) in your lambda? can you give me more context?
i suggest you use something like http://apex.run or https://serverless.com you should have your dependencies as part of your lambda and not installing them at runtime

Hi ered93,
I am trying to use your module and I am getting the same error. I used pip install to install dependencies in a folder together with my own code, zipped the folder, and uploaded it to Lambda, like I always do.
[Errno 2] No such file or directory: '/var/task/vendor/git-2.4.3.tar'

@mrthefastfender can you share your lambda code?
i'm using it with Apex and it works. unfortunately loading dependencies in lambda is a bit tricky due to the restricted permissions.
If you @mrthefastfender and @ashleybeshir could share a bit more info i could try to debug it.
if you could share a zip file of the lambda throwing that error i could check why is throwing that error

The problem was, that the git binary was not included in the folder. I found a different solution using boto3 since I was trying to use CodeCommit.

I'm going to close this issue as i'm unable to reproduce the error. Once I have clear steps i can follow i'll reopen it.
@ashleybeshir how can you run subprocess.call(["pip","install","lambda-git"]) when AWS Lambda doesn't let you call pip? 😕

@ashleybeshir I just resolved the same issue. As mrthefastfender pointed out, the vendor folder isn't included in the pip install. I downloaded the git-2.4.3.tar file directly and included it in my lambda package. https://github.com/eredi93/lambda-git/blob/master/vendor/git-2.4.3.tar.
@eredi93 can you update the Python package so that when we run pip install lambda-git, it will include the vendor folder with required binary? Thanks.

thanks @arsalazarjr !! i found the issue.
https://github.com/eredi93/lambda-git/blob/f897734919330c518f43713fef6196c625f85960/setup.py#L27
find_packages only returns git and tests
jacopo@moka:~/src/lambda-git|master
⇒  python
Python 2.7.15 (default, Jun 17 2018, 12:46:58)
[GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from setuptools import find_packages
>>> find_packages()
['tests', 'git']
>>>

i'll update it now

I just published a new version of the package


Add the possibility to disable unloading of event handlers onUnmount

Adds parameter object with property disableUnloadingEventHandlers to useFind to disable automatic unloading of feathers service event listeners on component unmount.
This makes it possible to change the component and keep the event listeners attached and therefore enable the use of singleton patterns to load data.

@anbraten I don't think we need it in our project. But adding it for consistency  and future proofing would not hurt.

@anbraten I don't think we need it in our project. But adding it for consistency and future proofing would not hurt.

@raphaelschwinger Do you plan to add it to this PR or do you want to rename it and open a new one for useGet

@raphaelschwinger Do you plan to add it to this PR or do you want to rename it and open a new one for useGet

I will add it to this one ☝

@anbraten @lukashass do we have to bump the version number?

@anbraten @lukashass do we have to bump the version number?

Yes, but we will release in a separate PR.


ESP8266 cannot use 'AT+HTTPCLIENT' command to send https request

================================SEND HTTPS REQUEST ===================================

Transceiver.send_command('AT+HTTPCLIENT=2,0,"https://httpbin.org/get","httpbin.org","/get",2')
exec AT+HTTPCLIENT=2,0,"https://httpbin.org/get","httpbin.org","/get",2 response: AT+HTTPCLIENT=2,0,"https://httpbin.org/get","httpbin.org","/get",2

ets Jan  8 2013,rst cause:4, boot mode:(3,7)
wdt reset
load 0x40100000, len 6960, room 16
tail 0
chksum 0xa5
load 0x3ffe8008, len 24, room 8
tail 0
chksum 0x2c
load 0x3ffe8020, len 3196, room 8
tail 4
chksum 0xb8
csum 0xb8
ready
(False, 'AT+HTTPCLIENT=2,0,"https://httpbin.org/get","httpbin.org","/get",2\r\n\r\n ets Jan  8 2013,rst cause:4, boot mode:(3,7)\r\n\r\nwdt reset\r\nload 0x40100000, len 6960, room 16 \r\ntail 0\r\nchksum 0xa5\r\nload 0x3ffe8008, len 24, room 8 \r\ntail 0\r\nchksum 0x2c\r\nload 0x3ffe8020, len 3196, room 8 \r\ntail 4\r\nchksum 0xb8\r\ncsum 0xb8\r\n\r\nready\r\n')
================================SEND HTTPS REQUEST ===================================
================================SEND HTTP REQUEST ===================================

Transceiver.send_command('AT+HTTPCLIENT=2,0,"http://httpbin.org/get","httpbin.org","/get",1')
exec AT+HTTPCLIENT=2,0,"http://httpbin.org/get","httpbin.org","/get",1 response: WIFI CONNECTED
WIFI GOT IP
AT+HTTPCLIENT=2,0,"http://httpbin.org/get","httpbin.org","/get",1
+HTTPCLIENT:282,{
"args": {},
"headers": {
"Content-Length": "0",
"Content-Type": "application/x-www-form-urlencoded",
"Host": "httpbin.org",
"User-Agent": "ESP32 HTTP Client/1.0",
"X-Amzn-Trace-Id": "Root=1-62a52431-5db81a105463d9a02a4b1388"
},
"origin": "116.22.
+HTTPCLIENT:45,1.230",
"url": "http://httpbin.org/get"
}

OK
(True, 'WIFI CONNECTED\r\nWIFI GOT IP\r\nAT+HTTPCLIENT=2,0,"http://httpbin.org/get","httpbin.org","/get",1\r\n+HTTPCLIENT:282,{\n  "args": {}, \n  "headers": {\n    "Content-Length": "0", \n    "Content-Type": "application/x-www-form-urlencoded", \n    "Host": "httpbin.org", \n    "User-Agent": "ESP32 HTTP Client/1.0", \n    "X-Amzn-Trace-Id": "Root=1-62a52431-5db81a105463d9a02a4b1388"\n  }, \n  "origin": "116.22.\r\n+HTTPCLIENT:45,1.230", \n  "url": "http://httpbin.org/get"\n}\n\r\n\r\nOK\r\n')

================================SEND HTTP REQUEST ===================================

For ESP8266 series of devices, if the URL is HTTPS type or <transport_type> parameter is 2, you need to enlarge at_process_task stack size to more than 4096 by configuring ./build.py menuconfig -> Component config -> AT -> The stack size of the AT process task, otherwise ESP8266 will restart due to insufficient stack.
See AT+HTTPCLIENT notes for more details.

We assume this worked for you, and will close it. If that's not the case, please open another github issue.


Error on binding installation in Windows

Hello, I want to report a bug.
In 9.2 latest release, after brand new installation, I try to install my first binding. But there was error on the WebUI:
-Binding is not installed
And this is error in console:
File "c:\users****\lollms\lollms-webui\lollms_core\lollms\server\endpoints\lollms_binding_infos.py", line 129, in install_binding
sanitize_path_from_endpoint(path)
^^^^
NameError: name 'path' is not defined

this was fixed


adds websocket server, static http server capabilities

Hmm yes I, a completely different person, have reviewed this code very thoroughly and A+ job.


osgi is broken on latest release (1.10.1)

OSGI is broken on the latest release. Seems the export package versioning is wrong (1.9.2.SNAPSHOT) in the manifest:
Manifest-Version: 1.0
Bundle-Description: jsoup HTML parser
Bundle-License: https://jsoup.org/license
Bundle-SymbolicName: org.jsoup
Built-By: jhy
Bnd-LastModified:<PHONE_NUMBER>812
Bundle-ManifestVersion: 2
Bundle-DocURL: https://jsoup.org/
Bundle-Vendor: Jonathan Hedley
Import-Package: javax.net.ssl,javax.xml.parsers,javax.xml.transform,ja
vax.xml.transform.dom,javax.xml.transform.stream,org.jsoup;version="[
1.9,2)",org.jsoup.helper;version="[1.9,2)",org.jsoup.nodes;version="[
1.9,2)",org.jsoup.parser;version="[1.9,2)",org.jsoup.safety;version="
[1.9,2)",org.jsoup.select;version="[1.9,2)",org.w3c.dom
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.5))"
Tool: Bnd-<IP_ADDRESS>605172007
Originally-Created-By: 1.8.0_65 (Oracle Corporation)
Export-Package: org.jsoup;version="1.9.2.SNAPSHOT";uses:="org.jsoup.no
des,org.jsoup.parser,org.jsoup.safety",org.jsoup.examples;version="1.
9.2.SNAPSHOT";uses:="org.jsoup.nodes",org.jsoup.helper;version="1.9.2
.SNAPSHOT";uses:="javax.xml.parsers,org.jsoup,org.jsoup.nodes,org.jso
up.parser,org.jsoup.select,org.w3c.dom",org.jsoup.nodes;version="1.9.
2.SNAPSHOT";uses:="org.jsoup,org.jsoup.parser,org.jsoup.select",org.j
soup.parser;version="1.9.2.SNAPSHOT";uses:="org.jsoup.nodes",org.jsou
p.safety;version="1.9.2.SNAPSHOT";uses:="org.jsoup.nodes",org.jsoup.s
elect;version="1.9.2.SNAPSHOT";uses:="org.jsoup.nodes"
Bundle-Name: jsoup
Bundle-Version: 1.10.1
Created-By: Apache Maven Bundle Plugin
Build-Jdk: 1.8.0_91

Thanks for the report. That's really strange. I wonder if it's from upgrading all the build plugins recently. Looks like it didn't clean, or sourced from the wrong dir or something.

Can you check 1.10.2? Looks right to me now.

Sorry for the delayed response here. The warning email disappeared amongst heaps of github warnings.
Can confirm that this OSGi is properly working again as of version 1.10.2 :+1:

That's great, thanks for confirming.


[WIP][redesign] Initial class design for sensor api

Motivation and Context
As per the discussion I had with Mandeep, we need to first built a public exposing Sensor API for ease of using the sensors. This is first WIP step towards that.
How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #409 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   55.96%   55.96%
=======================================
  Files         171      171
  Lines        7950     7950
  Branches       84       84
=======================================
  Hits         4449     4449
  Misses       3501     3501

Flag
Coverage Δ

#CPP
52.35% <ø> (ø)
:arrow_up:

#JavaScript
10% <ø> (ø)
:arrow_up:

#Python
77.42% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998f3f7...9210636. Read the comment docs.

One use case the sensor redesign does not address is that it's currently impossible to access the object categories within the SemanticSensor or related sensors itself. Since currently the renderer only draws object ids, this means one has to iterate through object ids to access them and impossible to do that within the getObservation method. This makes extending or creating new types of sensors difficult. (For instance, if I want a sensor that only returns the object class id instead of the object instance id or a sensor which swaps the object instance/object class ids).
Being able to access the object categories or other scene/sim properties from within sensor types that may need them in the future would be a useful feature to consider when considering the redesign. It may also help create sensors that are stateful for when they are needed in the future.

@apsdehal : The current shape of the code looks great!
It is a high impact project. Hope we can continue it when you are available. How do you think?
Also add @mosra  into the reviewer list.

Closing this stale PR.


Parse Performace Question is better many tables or many registers

Hi guys, I am using parse for my backend app. So i have almost 50k of registers to save on parser and i will expect more 100k. I can split this data in many tables as i want. like  Profile table with 150k of registers or ProfileCompany1 ... ProfileCompanyN. So for performace with one is the best?

We have 2 millions installations objects, properly indexed, you don't need to create additional tables.


Return references from map_ref ?

Hi, thank you for making this crate.
I'd find it very useful to return refernces from map_ref, like this:
struct Bar {
    inner: u32,
}

#[derive(EnumPtr)]
#[repr(C, usize)]
enum Foo {
    A(Box<Bar>),
    B(Box<u64>),
}

let boxed = Foo::A(Box::new(Bar { inner: 1u32 }));
let compact_box: Compact<Foo> = boxed.into();

let reference = compact_box.map_ref(|foo| match foo {
    Foo::A(a) => &a.inner,
    Foo::B(_) => todo!(),
});

assert_eq!(*reference, 1u32);

I don't know if this is possible to achieve without UB, but it would be nice for sure.

I'm afraid this is a bit hard. When you hold a Compact<Foo>, there is no Foo in the memory, but only its compact form. So to borrow a Foo out from it, we have to create a temporary Foo. The reference you want to return comes from that temporary object. That's why I implemented map_ref rather than as_ref, I need to make sure that there's somewhere to store it (on the stack) and mem::forget this object afterward (otherwise boxed objects will be dropped).
For this problem, I have some ideas:

Generate a proxy struct that represents a reference to Foo and return it. For example, enum FooRef { A(&Box<Bar>), B(&Box<u64>) } + fn as_ref(&self) -> FooRef.
Directly borrow it from the compact form. Probably take_ref!(compact_box, Foo::A). I haven't come up with a clear implementation.

What do you think?

Sadly, it seems to me that there's no feasible solution to this.
One thing I tried is creating references to inner and transmuting them to the lifetime of Compact.
Miri with Stacked Borrows complains about this. Interestingly, it doesn't seem to be UB with Tree Borrows for the test case I tried.
But there's no way of creating a safe interface for this even if it somehow wasn't UB.

But there's no way of creating a safe interface for this even if it somehow wasn't UB.

Maybe we can implement something like RefCells's Ref as well as RefMut.
struct Ref<'a, T> {
	inner: ManuallyDrop<T>
	marker: PhantomData<&'a T>
}

impl<T: Deref> Deref for Ref<'_, T> {
	type Target = <T as Deref>::Target;

	fn deref(&self) -> &T {
        self.inner.deref()
    }
}

And then generate:
#[repr(C, usize)]
enum FooRef {
    A(Ref<Box<Bar>>),
    B(Ref<Box<u64>>),
}

Thinking a while...

I tried to implement the FooRef solution. It was much more complex than I thought and I decided to give up this route.
However, the take_ref! solution might work. Here's a small example that passes MIRI under both stacked borrows and tree borrows.
use enum_ptr::{Compact, EnumPtr};

// used to specify lifetime
unsafe fn take_ref_helper<'a, T, U>(
    compact: &'a Compact<T>,
    f: impl FnOnce(&T) -> Option<&'a U>,
) -> Option<&'a U>
where
    T: From<Compact<T>>,
    Compact<T>: From<T>,
{
    compact.map_ref(f)
}

macro_rules! take_ref {
    ($compact:expr, $($variant:tt)*) => {
        unsafe {
            take_ref_helper($compact, |extracted| match extracted {
                $($variant)*(inner) => Some(&*(::std::ops::Deref::deref(inner) as *const _)),
                _ => None,
            })
        }
    };
}

#[test]
fn main() {
    #[derive(Debug, EnumPtr)]
    #[repr(C, usize)]
    enum Foo<'a> {
        A(&'a i32),
        B(Box<i64>),
    }

    let compact_foo = Compact::from(Foo::A(&42));
    dbg!(take_ref!(&compact_foo, Foo::A));
    dbg!(take_ref!(&compact_foo, Foo::B));
}

One drawback of this solution is that it cannot handle named variants. But I have already decided to remove named variant support since 0.2.0. So it's not a big problem.
Another drawback is that this API is troublesome when you deal with multiple branches at once. I'm still searching for a better solution.
I won't put this API into my crate any time soon. I need more time to think.

I'm sorry to find that take_ref! has some issues as well. First of all, Deref doesn't actually offer all the guarantees we need. For example, ManuallyDrop<T> can deref to &T, which points to its own memory, although ManuallyDrop<T> cannot be used in EnumPtr. Secondly, it doesn't work for Option<Box<T>>, for which we usually want an Option<&T>. This problem is way harder than I thought.

Finally, I made it.
I released a beta version, check it out. https://crates.io/crates/enum-ptr/0.2.0-beta.0


MSBot: Deploying C# sample 12.nlp-with-luis fails

Tool
Name: MSBot
Version: 4.0.2.-108
OS: Windows 10
Describe the bug
A clear and concise description of what the bug is.
To Reproduce

Download the sample.

Run the following command:
msbot clone services --folder deploymentScripts\msbotClone --location "westus" --proj-file "LuisBot.csproj" --name "AzLuisBotKI02"  --verbose

The following error message appears:
missing --luisAuthoringKey argument

Expected behavior
The service should be provisioned using the bot.recipe file.
msbot clone services command should provision a new LUIS service on behalf of the user.
This was working a couple of days ago and now that luisAuthoringKey is required, it fails.
[bug]

this is by design, no?  you can't provision LUIS resources unless you specify an authoring key

This is by design, you have to provide the luisAuthoringKey to create luis resources.
I could clean up the error, and say "This recipe requires a luisAuthoringKey to provision LUIS resources"

So, if I am deploying a sample with LUIS, I have to provide luisAuhtoringKey, which means that I have to have a LUIS app in the luis.ai portal? Is that the behavior we want for samples? The behavior earlier was much simplers as I didn't have to do anything and the sample got deployed. It was much simlper, IMHO.

I have no idea what you are talking about.  You have ALWAYS needed to provide a LuisAuthoringKey, this has not changed since we first created the tools.

You don’t need a LUIS app. But like azure where you need an account and a subscription you need a LUIS account and an authoring key.
This has always been the case.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Tom Laird-McConnell<EMAIL_ADDRESS>Sent: Saturday, December 8, 2018 5:36:20 PM
To: Microsoft/botbuilder-tools
Cc: Scott Gellock; Comment
Subject: Re: [Microsoft/botbuilder-tools] MSBot: Deploying C# sample 12.nlp-with-luis fails (#849)
I have no idea what you are talking about. You have ALWAYS needed to provide a LuisAuthoringKey, this has not changed since we first created the tools.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fbotbuilder-tools%2Fissues%2F849%23issuecomment-445503329&data=02|01|scott.gellock%40microsoft.com|4b7b19cfbeb9427d44cf08d65d76b8fd|72f988bf86f141af91ab2d7cd011db47|1|0|636799161828080620&sdata=mm2bDarC9FHOWlyNNzo90pBT14yJzqzRLbHMtcfYfAs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAsxd3z7oujMXJXVu6nMiQr31uh9LXUnks5u3GkUgaJpZM4ZJ3aY&data=02|01|scott.gellock%40microsoft.com|4b7b19cfbeb9427d44cf08d65d76b8fd|72f988bf86f141af91ab2d7cd011db47|1|0|636799161828080620&sdata=Ll10mNJPyOmI6q5oYF0f4CK85Muo%2Fs2WPdCpL29i8bk%3D&reserved=0.

Closing the issue.


Prevent Duplicate File Transactions in File Manager DocType

Issue: Duplication of File Entries in File Manager
We have identified a functional issue within our document management process. When users attach a file to any DocType using the 'Attachments' section and select a file from the library, the system creates a new file transaction for the already existing file in the database. This behavior leads to unnecessary duplication of file entries, as observed in the File Manager DocType at the ../app/file path.
Steps to Reproduce

Go to any DocType and click on 'Attachments'.
In the modal, select 'Library' and choose an existing file (e.g., 'iPhone_15_Plus_Pink_2-square_medium.jpg').
Click 'Upload'.
Navigate to the File Manager DocType at ../app/file.
Observe multiple entries for the same file, indicating duplication.

Expected Behavior
The system should reference the existing file in the database without creating a new file transaction when the same file is uploaded to a DocType.
Goals

To eliminate the duplication of file transactions within the File Manager.
To ensure efficient and accurate file management within the system.

Action Items

Investigate the logic that triggers the creation of a new file transaction upon file selection from the library.
Modify the system to reference the existing file entry instead of creating a duplicate.
Implement checks to prevent duplication if the file already exists in the database.
Test the attachment functionality to confirm that duplicate transactions are no longer created.

Importance
Addressing this issue is critical for maintaining a clean and efficient file management system, preventing data redundancy, and optimizing database storage.
Request for Resolution
Please prioritize the investigation and resolution of this issue to enhance our document management practices and uphold the integrity of our data management system.
Thank you for your prompt attention to this matter and your dedication to continuous system improvement.
Suggestion
I set in customize on File Name field to be Unique as image to prevent User to upload same file name in the ERP
http://beta.zaviago.com/app/file

*Must delete all duplicate file name before setting
Checked

If upload same file name will get alert message:

@chomchuen can you continue this tasks with @umer2001


serialize to and from bytebufer

As per jackson json serialization/desrialization library best practices guideline:

when deserializing json it is better to do deserialization directly form byte[]
when serializing to json, it is better to serialize to OutputStream

The purpose of this PR is to set the foundation of the following:

on the write path change serialization to directly serialize to ByteBuffer (prior to this PR serialization was happening in two steps from POJO -> String and from String -> byte[])
on the read path change deserialization to directly read from byte[].

I am planning to do more cleanup on read/write handling and byte[]/ByteBuffer handling after this PR.
More PRs coming to fully move to new model in other places.

This will sets us up right design/architecture wise. Thanks @moderakh.

QQ: from when string intermediate materialization present?

In reply to: 582319430 [](ancestors = 582319430)

static String toJsonString(Object cosmosItem, ObjectMapper objectMapper) {

Who are the consumers? Isn;t it best to remove it?

Refers to: sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosItemProperties.java:79 in 46618b6. [](commit_id = 46618b6382c1dc71a851eaf802b613f051239eb6, deletion_comment = False)

/azp run java - cosmos - ci

/azp run java - cosmos - ci

/azp run java - cosmos - tests

/azp run java - cosmos - ci

/azp run java - cosmos - tests

/azp run java - cosmos - ci

QQ: from when string intermediate materialization present?
@kirankumarkolli
on the readpath: there won't be any materialization to string. deserialization to user type happen directly from byte[]
on writepath: there won't be any intermediate string. we directly serialize user custom type to bytebuf

static String toJsonString(Object cosmosItem, ObjectMapper objectMapper) {

Who are the consumers? Isn;t it best to remove it?
Refers to: sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosItemProperties.java:79 in 46618b6. [](commit_id = 46618b6, deletion_comment = False)

that's not used and removed.


Is there any way to know for which word the text was censored?

I was making a discord bot so I'm using this for looking bad words in the chat but I don't know for which word the bot marked the text inappropriate.

These isn't currently a way to check which words were censored. I'm marking this as a feature request.


remove accessibilityStates validAttributes config from ReactNativeViewViewConfig.js

Summary
this little PR remove accesibilityStates config in validAttributes, like comment says it can be removed after next release.
Changelog
Javascript
Test Plan

reference for more information on why it can be removed: https://github.com/facebook/react-native/pull/26168

reference for more information on why it can be removed: #26168

thank you @Naturalclar!

@

@cpojer could you review this PR?

@Young could you review this PR?

@yungsters could you review this PR?


Remove [include_]system_hdf5_netcdf

This PR removes the deprecated include_system_hdf5_netcdf and system_hdf5_netcdf from Spack files and machine config files.

Checklist

[x] Testing comment in the PR documents testing used to verify the changes

I don't think we need any testing other than CI for now.

@xylar Fixed those docs :)

@xylar now it should be fixed... sorry about that.


MySQL Dependency

Greetings
I'm quite new to Swift and I'm slowly learning how stuff works.
I was following the tutorials on https://www.kitura.io/docs/getting-started/hello-world.html and I encountered some issues when I got to the Databases section.
In short, the difficulty was that the project could not build after I added the SwiftKueryMySQL dependency. Eventually I figured out that the reason for this is because I do not have MySQL installed on my computer. This is intentional. I prefer to run things like databases in docker containers rather than having them installed on the host.
So is there a way to proceed without having to install MySQL locally?

@bgmike If you want to run your MySQL instance in a container you can do so and simply update the MySQL Connections with the necessary network address etc....
If you want to use the plugin to develop locally you will need to install the mysqlclient library and pkg-config. Without these your application will not be able to build or link properly.
You could use a container for development and edit the source within it remotely. I haven't ever tried this but it should work fine.

Hello,
it is very time-robbing to create a first kueryMySQL project. Please add an installation guide for a normal scenario;)
This is what I mean: In normal cases I like to have a separate DB server and I want to have my system as clean as possible. Therefor I installed my MySQL database from the Oracle download. With this I could find the include and lib directories which are necessary for using Kuery. Instead of installing them in a /usr/local whatever directory on my development machine I add those directories to my project in XCode.

The next step was to find out how to include that in the XCode compile process. So you have to add the following entries in the Build settings:
$SRCROOT/MySQL/include in Header Search Paths
$SRCROOT/MySQL/lib in Library Search Paths
The next step is to include the kuery into the package: I use these entries in the dependencies, so I don't need to download them manually and they are in my project:
.package(url: "https://github.com/IBM-Swift/Kitura", from: "2.7.1"),
.package(url: "https://github.com/IBM-Swift/HeliumLogger.git", .upToNextMajor(from: "1.8.1")),
.package(url: "https://github.com/IBM-Swift/Swift-Kuery.git", .upToNextMajor(from: "3.0.1")),
.package(url: "https://github.com/IBM-Swift/SwiftKueryMySQL", .upToNextMajor(from: "2.0.2"))
Now I ran into last two problems which I wasn't able to fix.

I got a compiler error that mysqlclient can't be find. Here is the first question. What is the different of installing mysql with Homebrew and from Oracle? I think somewhere must the mysqlclient be definied but I wasn't able to find an information about that.
The second problem is "dyld: Library not loaded: libssl.1.0.0.dylib" in XCode while the run on console works the run with XCode doesn't. What must be done to fix that?

It would be great to get solutions for the problems.
Thank

@cflexible, Do you have the libmysqlclient libraries on your machine? When installed via brew they will be automatically symlinked from /usr/local/lib.
If the libraries are present you will need to set the header and library search paths in Xcode. If you look in the root of the SwiftKueryMySQL source tree you will find a file named Config.xcconfig. This file can be used to generate and Xcode project with the correct build settings for a system configured according to the Readme. You can edit the paths in this file to suit your needs and use it to generate your Xcode project using swift package generate-xcodeproj --xcconfig-overrides Config.xcconfig.
The second error suggests that you do not have openssl installed or configured correctly. Could you check to see if you have installed openssl? (brew list will show you all installed formula if you use homebrew).

Closing on the assumption that @kilnerm's response above helped you resolve the problem, however please re-open if you are still having trouble, or reach out on Slack.


Moved configuration to shared

I removed the Test.Common project and moved that to the empty shared project. The class contains paths to the data and the model once we start incorporating it into the CI/CD pipeline, so thought it made more sense to keep in the shared project as both the TrainConsole app and the ModelTests project will share it.

@luisquintanilla just a minor clean-up of the starting state for phase 7


⚠ Bofrost.at has degraded performance

In 6222c1f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2443 ms

Resolved: Bofrost.at performance has improved in ba2e4bb after 24 minutes.


Re-organize modules in ballerinax/salesforce package

Description
Note:  The improvements required are known and are tracked here: https://github.com/ballerina-platform/ballerina-library/issues/6697 and will be a future enhancement.
Note:  A minor version bump.
Fixes: https://github.com/ballerina-platform/ballerina-library/issues/6691
Modules

[x] bulkv1
[x] bulkv2
[x] apex
[x] soap
[x] Deprecate bulkv2 APIs in default package
[x] Deprecate apex APIs in default package
[x] Clean up new modules
[x] Apex API docs
[x] Bulkv2 API docs

@ayeshLK and all Just FYI before you guys review all the code. This is just moving around existing code. We need to move everything for update 10 as this a minor bump. We have used the same client in the default package. https://github.com/ballerina-platform/module-ballerinax-salesforce/blob/e9bc4ee3f5be51532da97bdd20f9ed958d689d11/ballerina/client.bal#L39. Tests are also the existing tests, which are just being moved from default package to modules.
We have no intention in improving the existing code quality in this effort, this will just be a move. All the errors and improvements required are known and tracked here https://github.com/ballerina-platform/ballerina-library/issues/6697 and I will take a look at all this at once in a separate PR, as there is a lot. Please keep reviewing I will add some of the changes to this issue.


[chatdown] Last generated message concatenates "\n"

Describe the bug
Chatdown 1.0.2 adds a "\n" to the last message from a .chat file
To Reproduce
Steps to reproduce the behavior:
Using the following test.chat file
bot=Bot
user=User

user:hello
bot:please add an attachment.

Run chatdown .\test.chat > .\test.transcript
The generated file test.transcript
[
  {
    "conversation": {
      "id": "1"
    },
    "id": "7da3a06b-cc85-4a94-950e-e956603d142e",
    "recipient": {
      "id": "ed753a1d-c715-3d24-98c6-07ba93f3aeca",
      "name": "Bot",
      "role": "bot"
    },
    "from": {
      "id": "cebda01d-1522-322f-a799-300cbbbea85b",
      "name": "User",
      "role": "user"
    },
    "text": "hello",
    "timestamp": "2018-05-17T15:36:52.000Z",
    "type": "message",
    "channelId": "chatdown"
  },
  {
    "conversation": {
      "id": "1"
    },
    "id": "72b74bf2-2752-4c8a-b84a-030f70e959a6",
    "recipient": {
      "id": "cebda01d-1522-322f-a799-300cbbbea85b",
      "name": "User",
      "role": "user"
    },
    "from": {
      "id": "ed753a1d-c715-3d24-98c6-07ba93f3aeca",
      "name": "Bot",
      "role": "bot"
    },
    "text": "please add an attachment.\n",
    "timestamp": "2018-05-17T15:36:54.000Z",
    "type": "message",
    "channelId": "chatdown"
  }
]

The last message adds a "\n" -> "text": "please add an attachment.\n",
Expected behavior
The last message with the .chat text -> "text": "please add an attachment.",

this has been fixed


SSO Override - Duplicate IP (Old 61)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:09
When overriding an account, admins are asked for the secondary password of the user due to the duplicate IP rules.

In gitlab by @A-Lawrence on Aug 31, 2015, 01:15
No longer required due issue #488534 (195).
ALawrence66 - 2014-12-31T18:27:32.360027+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:15
Issue seems to be occuring again. When user's have been overriden, the checkpoint appears on sub-system logins only.
ALawrence66 - 2014-01-02T15:07:20.530597+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:15
Finally resolves the IP checkpoint issue.  Resolves #488533 (61).
ÔåÆ <>
ALawrence66 - 2013-10-30T00:17:04.804565+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:15
Users were previously unable to override an account due the IP restrictions and associated checkpoiint - this commit addresses that.  Resolves issue #488533 (61).
ÔåÆ <>
ALawrence66 - 2013-10-30T00:09:24.923713+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:15
Users were previously unable to override an account due the IP restrictions and associated checkpoiint - this commit addresses that.  Resolves issue #488533 (61).
ÔåÆ <<cset 934c9249936b>>
ALawrence66 - 2013-10-30T00:09:24.880425+00:00


[BUG] - Calendar

NextUI Version
2.0.6 next-ui-org/date-picker
Describe the bug
When the locale is ar-SA, the calendar system that shows up is hijri which is islamic-umalqura but it switches on selecting month and year (in the showMonthAndYearPickers) to gregorian calendar system.
Your Example Website or App
https://github.com/Sammy-coding/calendar
Steps to Reproduce the Bug or Issue
click on the showMonthAndYearPickers
Observe the year and month before selection
then
Select month
Select Year
The month and year changes
Expected behavior
As a user, i am expecting that the calendar system stays hijri which is islamic-umalqura but it changes back to gregorian.

Screenshots or Videos
No response
Operating System Version
macOS
Browser
Chrome

Please follow the guide to setup NextUIProvider
https://nextui.org/docs/guide/installation#provider-setup-1

Even after using the nextuiprovider, the issue still persist. The calendar still switches after selecting the year. It switches from the hijri calendar system to gregorian. It doesn't stay at hijri month and year.

Hi @wingkwong Is there a fix for this issue

@Sammy-coding I'm working on it.


really cool _ issue with html

Thank you for this nice text effect. There is an issue when the content contains some html (an anchor for instance). It seems to process it as text, thus "hanging" weirdly until all the html code has been parsed.

Hi !
Thanks for your issue and for using my plugin !
I see what you mean and I noticed this glitch already. But it's tricky to "catch" html tags and re-render them as long as the string is rendered letter by letter.
That would be a great challenge to code a renderer for that case.. Maybe several instances launched one by one on the text content of html nodes found inside the wrapper.
I'll think about it..

I started to explore the problem, and I think you could detect html when you create the array via split('');
Here is how it is done in typed.js : https://github.com/mattboldt/typed.js/blob/master/js/typed.js#L179

Thanks, your example is working here too :) #https://github.com/Nyl000/NylAutoWriter/commit/834adb6a83f23014dcca631637c246116d4f89bb


Fixed typo in GitHub repository hyperlink under https://www.aim42.org/contribute

The GitHub repo cannot be opened from https://www.aim42.org/contribute because a "[" is in front of the "http://".

thanx :-)


Does not work with latest sdl2 and glium

Looks like the versions are hardcoded in the cargo file. Updating them seems to triggers errors from some sdl2 API changes such as SdlResult no longer existing.

Correct me if I'm mistaken, but this issue should probably be reopened again.


added refresh token support

[x] added /refresh endpoint that allows to refresh tokens without the need for user to retype login/password
[x] swagger will use xml comments to generate api doc

[x] added examples over /register, /login, /refresh

[x] introduced concept of "devices" so that tokens will be valid only on the device that actually issued them

[x] added Device to register and login request dtos

[x] added base classes for dtos/exceptions that share the same resultsn

Once merged, I will take some time to refactor identity module as it is becoming very complex. Please focus on functionality for now when reviewing, I'll restyle it when merged.


Fix TF windows bazel tests.

Ignore errors in shutil.rmtree until we figure out why rmtree fails.
Do not run neon_depthwise_conv_op, as we already omit linking in
the op.

The rmtree fails because the SummaryWriterCache keeps open file handles around which causes Windows to disallow removing the directory.
Look at estimator_test: test_train_save_copy_reload for an example of how to fix.
@ispirmustafa should we call SummaryWriterCache.clear() after each train()/eval() call? There's little we gain from this cache between invocations.

we need to keep cache for some edge cases. For example let's say there are two threads one for training and one for evaluation.

But that doesn't prevent us from clearing the cache, right? All that would
do is force us to reopen the writer, which is a performance hit but should
otherwise be harmless.

http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/10/consoleFull
Looks like adding ignore_errors=True didn't fix the shutil.rmtree error.

I can try, but for the said edge cases, multiple threads can also be causing the failures to remove files.

Running windows presubmits here:
http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/11/

Well that didn't work -- There shouldn't be multiple thread unless several methods inside DNNRegressorEvaluateTest run in multiple threads, and even then, the directory is unique to that test case.

It did not work because there were >1 shutil.rmtree calls, I now updated them all.
Trying again.
http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/12/

Looks like some machines had some missing libraries?
http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/13/
Retrying tests.

There were some new tests added to this file.
Also modified them, and rerunning tests:
http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/14/

OK, now I got all the tests. Looks like while I was fixing testcases, more cases were added to dnn_test.
http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/16/console


Lagged scrolling

Issue Type
Bug
Description
There is huge lagg when i scroll with touchpad. Only in visual studio code.