sign_and_send_pubkey

Not sure what happened, but I when I try to SSH into FreeBSD, macOS, Ubuntu, or Debian, I get sign_and_send_pubkey: signing failed: communication with agent failed and prompted for my password. I can see my keys in --list-keys, and have checked that they're in the authorized_keys files on all hosts.

I totally miss this issue, you still with this happening? if yes i will tell you how to log some info so i can know why that is happening. maybe a crash sekey.

So I got this issue to come back again. Sorry, I didn't get a notification that you replied. However this time I can give you some more information. This time it broke immediately after an automatic/security update. I tried to generate a new key and added it to a host, tried to SSH in, and it gave me the same error twice before prompting for my password. My email is rudi at nightmare dot haus if you need more logging information and I don't reply here :)

I did brew cask reinstall, however my old keys survived that, and I still got an error when trying to use them.

I will create a new version today with a debub parameter and send you the
link, try to check on the ssh -v and send me the log of what is saying when
the ssh is contacting sekey.
On Thu, May 10, 2018 at 16:27 Gregory Rudolph<EMAIL_ADDRESS>wrote:

I did brew cask reinstall, however my old keys survived that, and I still
got an error when trying to use them.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ntrippar/sekey/issues/17#issuecomment-388175252, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAqM32jMve8irSJr1BBTu2LjdCUR766Nks5txKKqgaJpZM4SaIDS
.

zero:~ gregory$ ssh -v vandort OpenSSH_7.6p1, LibreSSL 2.6.2 debug1: Reading configuration data /Users/gregory/.ssh/config debug1: /Users/gregory/.ssh/config line 1: Applying options for * debug1: /Users/gregory/.ssh/config line 8: Applying options for vandort debug1: Reading configuration data /etc/ssh/ssh_config debug1: /etc/ssh/ssh_config line 48: Applying options for * debug1: Connecting to <IP_ADDRESS> port 22. debug1: Connection established. debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_rsa type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_rsa-cert type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_dsa type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_dsa-cert type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_ecdsa type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_ecdsa-cert type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_ed25519 type -1 debug1: key_load_public: No such file or directory debug1: identity file /Users/gregory/.ssh/id_ed25519-cert type -1 debug1: Local version string SSH-2.0-OpenSSH_7.6 debug1: Remote protocol version 2.0, remote software version OpenSSH_7.4p1 Debian-10+deb9u3 debug1: match: OpenSSH_7.4p1 Debian-10+deb9u3 pat OpenSSH* compat 0x04000000 debug1: Authenticating to <IP_ADDRESS>:22 as 'gregory' debug1: SSH2_MSG_KEXINIT sent debug1: SSH2_MSG_KEXINIT received debug1: kex: algorithm: curve25519-sha256 debug1: kex: host key algorithm: ecdsa-sha2-nistp256 debug1: kex: server->client cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none debug1: kex: client->server cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none debug1: expecting SSH2_MSG_KEX_ECDH_REPLY debug1: Server host key: ecdsa-sha2-nistp256 SHA256:NzImIK3P7qOqoPnqbphPAOMQzIfO9iI2BUYlVQ6iRcf debug1: Host '<IP_ADDRESS>' is known and matches the ECDSA host key. debug1: Found key in /Users/gregory/.ssh/known_hosts:78 debug1: rekey after 134217728 blocks debug1: SSH2_MSG_NEWKEYS sent debug1: expecting SSH2_MSG_NEWKEYS debug1: SSH2_MSG_NEWKEYS received debug1: rekey after 134217728 blocks debug1: SSH2_MSG_EXT_INFO received debug1: kex_input_ext_info: server-sig-algs=<ssh-ed25519,ssh-rsa,ssh-dss,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521> debug1: SSH2_MSG_SERVICE_ACCEPT received debug1: Authentications that can continue: publickey,password debug1: Next authentication method: publickey debug1: Offering public key: ECDSA SHA256:9kxH8H8CvplSM5no ecdsa-sha2-nistp256 debug1: Authentications that can continue: publickey,password debug1: Offering public key: ECDSA SHA256:rus4lg5ZCeCsE ecdsa-sha2-nistp256 debug1: Server accepts key: pkalg ecdsa-sha2-nistp256 blen 104 sign_and_send_pubkey: signing failed: communication with agent failed debug1: Trying private key: /Users/gregory/.ssh/id_rsa debug1: Authentications that can continue: publickey,password debug1: Trying private key: /Users/gregory/.ssh/id_dsa debug1: Trying private key: /Users/gregory/.ssh/id_ecdsa debug1: Trying private key: /Users/gregory/.ssh/id_ed25519 debug1: Next authentication method: password

Wow that looks terrible

Ok, seems that is a problem with the comunication with the agent, can you check this two things.

check that the sekey agent is running

ps -ax|grep sekey

it should appear /Applications/SeKey.app/Contents/MacOS/sekey --daemon

check the env

env|grep SSH_AUTH_SOCK

here should be SSH_AUTH_SOCK=/Users/{user}/.sekey/ssh-agent.ssh
check those both stuff, also sorry about the delay to build the verbose version of sekey, I will build today and also push some other updates.

754 ??         0:00.95 /Applications/SeKey.app/Contents/MacOS/sekey --daemon for ps, and
SSH_AUTH_SOCK=/Users/gregory/.sekey/ssh-agent.ssh for env

Same issue. Installed via homebrew, process running and env var is set. Is there a debug version available? or does the daemon have logs that might help debug further?

@ntrippar did you get to contact @jtescher ? If not, I am experiencing the same issue, so if you still need that information, please contact me.

@spitfire Yes i contacted with him, but in his case he already fixed. please contact me at my ntrippar at gmail.com or if you want via twitter pm so i can help you fix it, (really want to close this ticket but untill i dont have a solution that really works i cant)

Hi there.  I'm experiencing a similar issue after my machine was re-imaged by Apple support:
machine:~ user$ RUST_LOG=debug /Applications/SeKey.app/Contents/MacOS/sekey --daemon
Pipe deleted
binding to /Users/user/.sekey/ssh-agent.ssh
DEBUG:ssh_agent::agent: handling new connection
DEBUG:ssh_agent::protocol: reading request
DEBUG:ssh_agent::agent: request: RequestIdentities
DEBUG:ssh_agent::agent: handler: Identities([Identity { key_blob: [snip], key_comment: "ecdsa-sha2-nistp256" }, Identity { key_blob: [snip], key_comment: "ecdsa-sha2-nistp256" }])
DEBUG:ssh_agent::protocol: reading request
DEBUG:ssh_agent::agent: request: SignRequest { pubkey_blob: [snip], data: [snip], flags: 0 }
DEBUG:ssh_agent::agent: handler: Error { details: "Error trying to sign data" }
Installed via brew cask, originally, and restored my time machine backup when I received the repaired machine.  I reinstalled via brew cask to see if that fixes it and it did not.  Keys are still listed when I do a list-keys.

As far as ssh itself:
debug1: Offering public key: ecdsa-sha2-nistp256 ECDSA SHA256:snip agent
debug1: Server accepts key: ecdsa-sha2-nistp256 ECDSA SHA256:snip agent
sign_and_send_pubkey: signing failed: communication with agent failed
Also, I can successfully export the public key and it matches what I already had in my backup.

I found the issue here, and i will resolve and push the code with the new agent.
So when we are creating the private key we use kSecAttrAccessibleWhenUnlockedThisDeviceOnly
this mean
This is recommended for items that need to be accessible only while the application is in the foreground. Items with this attribute do not migrate to a new device. Thus, after restoring from a backup of a different device, these items will not be present.

https://developer.apple.com/documentation/security/ksecattraccessiblewhenunlockedthisdeviceonly?language=objc
also from the ios security guide
The class kSecAttrAccessibleWhenPasscodeSetThisDeviceOnly
behaves the same as kSecAttrAccessibleWhenUnlocked; however, it is
available only when the device is configured with a passcode. This class
exists only in the system keybag; they:
• Don’t sync to iCloud Keychain
• Aren’t backed up
• Aren’t included in escrow keybags.
If the passcode is removed or reset, the items are rendered useless by
discarding the class keys.

so the main issue is I also saved the public key on the keychain (this is wrong), I should only keep the references (SecRef) for the privates one and if the user want to list I list the references and generate the public in the moment the user want to export
I will fix this and also add a note to the README

@ntrippar what's the status on this now? I'm running into this now, same issue. Server accepts the public key, but sekey fails to sign, same error as above.

The private key not being exportable and thus restorable on a machine reinstall is the expected behavior. You should have procedures in place how to replace "lost" SSH keys and apply it when re-imaging a device. As the public key is stored as "plaintext" data in the keychain, it gets re-initiated, but the private key is lost forever (by design).

I've done no reinstall, the key is available in sekey --list-keys and I can export the public key

I am having this issue now too. It happens once after seemingly a few hours and then it works fine again.


Convert tests to Mocha with Should, and Blanket for coverage

Note that the test count dropped from 37 to 31, but I removed some duplicates.
Still need to set up coveralls.io stuff - oh, and don't merge me yet; I'm just here testing the testing.

...I just realized I can sign up for Travis-CI and include my own repos, so I don't need to flood your inboxes with junk related to my testing. :P
I'll be back with a working PR for your review.


Database for Authentication

We're going to at least need a database for authentication by the 3/21 Demo

http://<IP_ADDRESS>:8000/admin/
when run the server opens this link will guide to the Django administration, which can see/modify all the user data or models
For the admin staff account, log in to the administration:
email<EMAIL_ADDRESS>username: managers
password: backend123

To show new models in Django administration, need to modify admin.py to register new models.


Incorrect parentheses

Synopsis:
The misplaced opening parentethesis on these lines convert logical boolean association to attempted function calls -- as these are variable values, and not functions, the functions calls cause errors
Details:
I'm using helm 3.2.4
$ helm version
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.3"}

On straight checkout of repo, I try to template the server/ manifests but I get errors:
$ helm template foo server/
Error: template: server/templates/web-secrets.yaml:2:11: executing "server/templates/web-secrets.yaml" at <(.Values.admin.password) .Values.admin.token>: can't give argument to non-function .Values.admin.password

$ helm template foo server/ --set imageCredentials.username=foo --set imageCredentials.password=foo
Error: template: server/templates/db-pvc.yaml:1:12: executing "server/templates/db-pvc.yaml" at <(not .Values.db.external.enabled) .Values.db.persistence.enabled>: can't give argument to non-function not .Values.db.external.enabled

With these changes, the templates are now interpolated:
$ helm template foo server/ --set imageCredentials.username=foo --set imageCredentials.password=foo
---
# Source: server/templates/rbac.yaml
apiVersion: policy/v1beta1
< ...elided... >

@niso120b can this fix be merged to the 5.0 branch?

@niso120b can this fix be merged to the 5.0 branch?

Seconding this.  Chart doesn't install for 5.0 because of this issue.


Ambient mode should match "Desktop resolution" not "Active resolution"

Describe the bug
As title
In ambient mode, light zones can follow screen's color & lightness. However, sometimes resolutions of screenshots does not always match user's resolution, leading to "offsets" between keyboard light & screen zones. A technology named "Virtual super resolution" is available, and in this mode there're two resolutions: "Desktop resolution" (Logical) and "Active resolution" (Physical)
This app use "Physical resolution" but in fact there should be a map between "Physical" and "Logical" resolutions.
To Reproduce
Steps to reproduce the behavior:

Set multiple ambient zones between "keyboard" and "screen"
Set a higher resolution than physical (more different, more offsets)

Expected behavior
Keybaord lights should follow screen exactly.
Screenshots
My 4 zone keyboard doesn't have accurate bug representation on phone recording
System (please complete the following information):

Model: Alienware m15 R6
Model details: 4 zone RGB
OS: Windows 11 RP 22H2

Additional context
Nope

It's not this.
I use data directly from active GPU screen buffer via DirectX.
So, it always reflects current screen (not desktop) resolution. Desktop one can vary for multi-screens, but i have a switch to select one of them.
What CAN be broken - i monitor screen configuration changes and adopt buffer to it. Here can be a bug (mine or Windows) after resolution change. I'll check.
PS: Then this happened, try to push "Reset" button at Ambient tab. Did it help?

Yes, it was a bug, but the source is different.
Windows report virtual resolution (divided by scale level) for non-DPI-Aware apps, even from DirectX!
Quite strange, but easy to fix.

Try this one - alienfx-gui.zip
Warning: It can provide incorrect app UI scaling then moving app window between different scale monitors! Can you check this?

Hmm maybe yes?
Plus, the ambient effect seems not watching monitor change

I see it a bit unstable now.
I can share debug version with data trace, but you will need to have dbgview.
For now, just restart app (it's a result of how i fight incorrect window scaling).

Try this one - alienfx-gui.zip
This should always get resolution correctly.... Hope i not broke multi-monitor resolution, i can't check it now.


[Bug]: opensearch-build is failing to build windows artifact on main

Describe the bug
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch-dashboards/detail/distribution-build-opensearch-dashboards/7146/pipeline/76
windows build is failing and the flow won't update index until all the flows pass, the index now always points to a staled main build artifact.
To reproduce
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch-dashboards/detail/distribution-build-opensearch-dashboards/7146/pipeline/76
Expected behavior
The build should success.
Screenshots

Host / Environment
windows
Additional context
No response
Relevant log output
info [  opensearch-dashboards  ] Cleaning npm from node

   â”‚ debg Deleting patterns: [

   â”‚        'C:/Users/ContainerAdministrator/tmpte2i8pc2/OpenSearch-Dashboards/build/opensearch-dashboards-3.0.0-windows-x64/node/**/node_modules',

   â”‚        'C:/Users/ContainerAdministrator/tmpte2i8pc2/OpenSearch-Dashboards/build/opensearch-dashboards-3.0.0-windows-x64/node/**/npm*',

   â”‚        'C:/Users/ContainerAdministrator/tmpte2i8pc2/OpenSearch-Dashboards/build/opensearch-dashboards-3.0.0-windows-x64/node/**/npx*',

   â”‚        'C:/Users/ContainerAdministrator/tmpte2i8pc2/OpenSearch-Dashboards/build/opensearch-dashboards-3.0.0-windows-x64/node/**/corepack*',

   â”‚        'C:/Users/ContainerAdministrator/tmpte2i8pc2/OpenSearch-Dashboards/build/opensearch-dashboards-3.0.0-windows-x64/node/**/nodevars*'

   â”‚      ]

   â”‚ERROR failure 1 sec

   â”‚ERROR Error: EPERM: operation not permitted, rmdir 'C:\Users\ContainerAdministrator\tmpte2i8pc2\OpenSearch-Dashboards\build\opensearch-dashboards-3.0.0-windows-x64\node\node_modules\npm\node_modules\node-gyp\node_modules\readable-stream'

Done in 370.19s.

+ mkdir -p builds/dist

+ ARTIFACT_BUILD_NAME=opensearch-dashboards-3.0.0-windows-x64.zip

+ ARTIFACT_TARGET_NAME=opensearch-dashboards-min-3.0.0-windows-x64.zip

+ cp target/opensearch-dashboards-3.0.0-windows-x64.zip builds/dist/opensearch-dashboards-min-3.0.0-windows-x64.zip

cp: cannot stat 'target/opensearch-dashboards-3.0.0-windows-x64.zip': No such file or directory

thanks for opening a bug on this issue, @SuZhou-Joe
Looks like we may need to update the clean up pattern here https://github.com/opensearch-project/OpenSearch-Dashboards/blob/b5d39b6e651ecf6c32fc87d6f8f893a86d48e3f2/src/dev/build/tasks/nodejs/clean_node_builds_task.ts#L40-L44,
Maybe to make it like 'node/**/node_modules/**' instead?
Looping in @peterzhuamazon to comment further,, thanks

thanks for opening a bug on this issue, @SuZhou-Joe Looks like we may need to update the clean up pattern here https://github.com/opensearch-project/OpenSearch-Dashboards/blob/b5d39b6e651ecf6c32fc87d6f8f893a86d48e3f2/src/dev/build/tasks/nodejs/clean_node_builds_task.ts#L40-L44, Maybe make it like 'node/**/node_modules/**' instead? Looping in @peterzhuamazon to comment further,, thanks

This is a flaky failure for a while, which I have not seen in previous releases until 2.12.
We need OSD core team to help with this.
The path does not have more than 260 chars, and it is within a location that should be able to get removed.
The call is trying to use rm rmdir which is alias to Remove-Item on Windows, and seems like it is trying to use force already with recursive, and the user should be the ContainerAdministrator which is default to the Windows container.

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/b5d39b6e651ecf6c32fc87d6f8f893a86d48e3f2/src/dev/build/lib/fs.ts#L104-L123

Need @AMoo-Miki to help checking the issue here if possible.
Thanks.

@AMoo-Miki  @ashwin-pc Can you please provide your inputs here?

Hello, @AMoo-Miki and @ashwin-pc, your comments would be greatly appreciated! Thank you in advance!

Close as it is running fine in production now.
Feel free to reopen on this.
Thanks.


Bond.IO.Unsafe.InputStream will fail if the underlying stream Read returns fewer than the expected number of bytes

The implementation of InputStream calls Stream.Read and assumes that if it requests n bytes, Stream.Read will always read n bytes or indicate a failure/end of stream. It does not account for Stream.Read successfully returning fewer than the requested bytes, but not yet having reached end of stream. Stream.Read is permitted to return a non-zero number of bytes smaller than the requested count.

Is there any update on this? We ran into this exact issue. In our case we work around it using an EagerStream that tries to read the requested number of bytes and only returns fewer, if the end of stream has been reached.
But ideally, Bond shouldn't make that assumption.


Update node-upgrade-github-actions.md

Correction of a missing option in Github workflow.
If --yes is not present, workflow will stop waiting a user input

@squasta : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#sign-off


How do I download and run this ?

OkDownload Version
v1.0.2-SNAPSHOT
Problem Describe
I occur some problem, I also search on issues and wiki, I even checked the source code, but it can't help, so my real problem is:...
Log
There is the whole log from LogCat when I occur the problem(I know we can use this tool to let log more readable):

???


Fix diagrams 5, 6, 7, and 8 in direct-routing-media-optimization.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9107.

Docs Build status updates of commit ceeb685:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/direct-routing-media-optimization.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7c27929:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/direct-routing-media-optimization.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 454fdb8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/direct-routing-media-optimization.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


provide/empty seals and storage drawers

Hi, so was gonna make a golem storage system using the storage drawers mod with its controller, the store seal works on the controller, wanted to put provide seals on the drawers themselves for item retrieval and they wont attach.  With an empty seal on an actually additions crate for dumping stuff in for the golem to sort through.
The provide seal and the empty seal also doesnt attach to the actually additions small storage crates, but the storage seal will.

What version of TC are you using?

1.12.2-6.1.BETA13
I think, going off the twitch information


Support setting "-C linker=" for rustc

Some cross compilation tools have prefixes in their name and path, for example the armel linker on Debian is /usr/bin/arm-linux-gnueabi-gcc. Cross compile targets would need a way to specify -C linker for rustc in the manifest.

For anyone else who doesn't read the documentation properly, the target.$triple.linker settings goes in .cargo/config not in Cargo.toml. If you put it in Cargo.toml it will be silently ignored.
eg:
[target.arm-unknown-linux-gnueabi]
linker = "/usr/bin/arm-linux-gnueabi-gcc"

If you put it in Cargo.toml it will be silently ignored.

Isn't that rather error prone?

How do I find my target triple?

@rightfold if you run rustc -vV it'll tell you the default target that you compile for (under host), otherwise you're passing --target in which case that's the target triple.

Thanks! 😃
Sent from my iPhone.

Op 12 feb. 2017 om 06:26 heeft Alex Crichton<EMAIL_ADDRESS>het volgende geschreven:
@rightfold if you run rustc -vV it'll tell you the default target that you compile for (under host), otherwise you're passing --target in which case that's the target triple.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Is there any way to set the linker via an environment variable or cargo parameter rather than a config file?

@alexcrichton what environment variable would I use to set the linker for target.x86_64-pc-windows-gnu and target.i686-pc-windows-gnu?

Or just in general can I set the linker for the current cargo build (any target)?

@jeroen you'd use CARGO_TARGET_I686_PC_WINDOWS_GNU_LINKER

Thanks @alexcrichton! Now I am stuck on one final issue:
We use a version of mingw-builds that was compiled with --static-gcc. Therefore our toolchain does not contain a copy of libgcc_eh.a, instead those objects are available from libgcc.a.
Currently when I try to build imageoptim-sys the linker fails because it can't find libgcc_eh.a. I think that is because this flag is hardcoded in rust. Is there some way I can tell rust that my linker wants to be linked with -lgcc instead of -lgcc_eh?
The cmake folks have a similar topic about not linking to libgcc_eh directly.

@jeroen ah unforutnately you can't change that right now, so the only recourse would be to write a wrapper script that translates -lgcc_eh to -lgcc, it's not great :(

For anyone who stumbles into this thread looking for an answer that doesn't involve .cargo/config, you can set the linker as a parameter of your cargo command like this:
RUSTFLAGS="-C linker=/path/to/linker" cargo run ...

@jeroen ah unforutnately you can't change that right now, so the only recourse would be to write a wrapper script that translates -lgcc_eh to -lgcc, it's not great :(

See https://github.com/rust-lang/rust/issues/29527


ReferenceError - login is not defined

If I run this cell:
# @name login
POST {{apiUrlAuth}}/accounts/login
Content-Type: application/json
cache-control: no-cache
{
	email: "{{email}}",
	password: "{{password}}"
}

I got a result.
But if I add this next cell
@accessToken = {{login.tokens.accessToken}}

I got the error even if I ran only the first one: "ReferenceError - login is not defined"
Tested in VSCode
Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043
and in insiders
Version: 1.58.0-insider (user setup)
Commit: bfac07cd0e374c433c2c06d6999dabf9cf9d5d29
Date: 2021-06-28T05:14:44.463Z
Electron: 12.0.12
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19043

It's not a bug. It's a misunderstanding that @ref is mandatory.

It would be helpful to have the whole file.
@Ref is mandatory because I can't tell if variables are not set from NodeJS scripts and therefore I currently decided not to resolve them automatically. But it is a good idea for improvement (Anweber/httpyac#43)

Using @ref is not a problem for me. So it's not a bug.
And it's really a good point as we can @ref variables coming from @import files.


Request update vendor (github.com/docker/docker/pkg/system)

The type of the "s.Rdev" is 32bit on mip64el, and it cannot convert 'uint32' to 'uint64' implicitly with programming in GO language. As shown in the PR #3838 .
I found that the latest version of github.com/docker/docker/pkg/system pacakage source has fixed this problem. So, I request update vendor (github.com/docker/docker/pkg/system).

This would have to start with a change to the CRI vendoring as the dependencies are from the CRI plugin:
./vendor/github.com/containerd/cri/pkg/server/sandbox_remove.go:23:     "github.com/docker/docker/pkg/system"
./vendor/github.com/containerd/cri/pkg/server/restart.go:33:    "github.com/docker/docker/pkg/system"
./vendor/github.com/containerd/cri/pkg/server/container_remove.go:23:   "github.com/docker/docker/pkg/system"

We can't change vendor.conf in containerd until that is first done in the CRI plugin and verified that moving up is possible. We can't change just the one file as that is part of the entire docker/docker vendoring being done.

I found that the docker/docker vendor in the moby project has fixed the problem #3838 , so I request to update the vendor.
And the problem has existed for a long time, I highly recommend to update the vendor docker/docker.
Thank you.

@XiaodongLoong I've opened containerd/cri#1341 to start the process.

OK, Thanks.


Code generated by UI recorder does not compile in player

Code generated by UI recorder does not compile in player. The code generated by recorder makes extensive use of desktopSession.FindElementByAbsoluteXPath() method which is not provide by the methods available in the player, eg OpenQA.Selenium.Appium.Windows.WindowsDriver()/WindowsElement(). Should this work?

Hi @eric-gilbertson,
UI Recorder code was intended to be used in conjunction with the UI Recorder template. You can paste this snippet into your source to enable it.


Add initial web server

What would you like to be added:
Add initial API web server and test infrastructure for it.
Why is this needed:
This is a core component for glvd

This has been done in #2


Scroll of the Hero of Cinder City

Artifact PR checklist:

[x] New artifact package
[x] Config in artifacts package
[x] Run pipeline with added config (generates .generated.json files)
[x] Artifact key
[x] Shortcuts for artifact key
[x] Add artifact package to imports
[x] 2pc
[x] 4pc
[x] Update documentation

pull the latest commit from main, there's the old nightsoul implementation

I've done this.


Close DB in Agent tests

The DB wasn't being closed in most of the tests in agent/db_test.go, causing an error when removing the data directory.
Fixes #9621

I've been able to squash most of the errors but there are still two remaining.

cc @rfratto for awareness

pushed another fix attempt

I attempted another fix and rebased and removed the build flags introduced in https://github.com/prometheus/prometheus/pull/9645

Is it the same recipe  that needs to be applied to Prometheus' wal_test.go?

@roidelapluie not sure I understand what you mean

@roidelapluie not sure I understand what you mean

tsdb/wal_test.go is also excluded in windows.

@roidelapluie not sure I understand what you mean

tsdb/wal_test.go is also excluded in windows.

Ah okay, I was looking at tsdb/wal/wal_test.go :P. Yeah possible that it is the same thing, but would leave that out of this PR for now. Agent is based on tsdb/wal/wal.go and not tsdb/wal.go. The latter seems to contain some WAL repair for ealier 2.x versions.

@codesome thanks for picking this up! I've been a bit busy lately.


Loosen dependencies

Hi,
The dependencies on activerecord and activemodel are hard set at 4.1.6, can this be loosened at all?

+1

Im trying to use tinybucket with rails 4.2.5 and Im getting the error Bundler could not find compatible versions for gem "activemodel"

Oh, Sorry my late response.
PR #56 will merged soon and I'll release next version.


Make a Visual studio code extension

Request
I highly suggest making a vs code extension

Did you check?


Add secret rotation tool

This migrates the contents of the rotation tool from azure-ask-build-tool's master branch as of commit 9a18fc with the following changes:

Directory.Build.props imports repo root Directory.Build.props
proj files no longer set properties made redundant by Directory.Build.props
cli configured to pack as a tool
documentation added to docs folder
json schema added to Configuration project
planned implementation removed from Readme

Maybe you could link from the PR description the the PR review we did on the internal repo?

Overriding check enforcer as there's no validation pipeline

/check-enforcer override


Trending dev

Could you please follow the normal workflow and not merge unreviewed code. Thank you very much.

But the two branches were my own develop branches. I wanted to test two different ways. And then decided on one of them and wanted to merge it with the other one. Don’t see the problem. Thank you very much.

4 dec. 2019 kl. 16:41 skrev Kenny Billiau<EMAIL_ADDRESS>Could you please follow the normal workflow and not merge unreviewed code. Thank you very much.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/Clinical-Genomics/genotype/pull/30?email_source=notifications&email_token=AAJ65XIQJPYMP2XY353JC43QW7FSLA5CNFSM4JVKLWU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5OEIA#issuecomment-561701408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ65XPHLV5XWKYODQ2ZNMDQW7FSLANCNFSM4JVKLWUQ.

Alright. All clear then :)


ADDS are not in a preview anymore

https://azure.microsoft.com/en-us/updates/azure-ad-domain-services-azure-portal-ga/ On all screenshots we have a post-fix "preview" that can frustrate people not familiar with adds and prevent them from using adds, because "preview" it usually means "not production ready"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b52da54f-9843-a479-820b-b45dc7f13e66
Version Independent ID: 219a1942-2fe8-d01a-65f6-0e30ab381dae
Content: Azure Active Directory Domain Services: Getting Started
Content Source: articles/active-directory-domain-services/active-directory-ds-getting-started-admingroup.md
Service: active-directory-ds
GitHub Login: @mahesh-unnikrishnan
Microsoft Alias: maheshu

@SychevIgor Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

There are no screenshots on the page https://azure.microsoft.com/en-us/updates/azure-ad-domain-services-azure-portal-ga/

@mahesh-unnikrishnan problem is in an article "Content Source: articles/active-directory-domain-services/active-directory-ds-getting-started-admingroup.md" this link is  a proof that UX already in GA

Resolved. #please-close

@SychevIgor We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Update Composer dependencies (2024-01-07-00-17)

Visual regression test passed!
View the visual regression test report


add kernarg test

Closing all existing pull requests that do not target the develop branch. In case this pull request is still valid, please rebase your changes against develop branch and resubmit.


Requirements.txt

I'm having trouble installing everything. Using setup.py installs tf2.0, which gives me several errors when I run dlib_tests. Can the authors please share a requirements.txt file / fix the setup.py file?

We will fix the setup.py file in an upcoming release. In the meantime, you could try to downgrade tensorflow and tensorflow-probability to an older version, which should restore functionality.

noted!


Add placeholder in show_tokens in shot_profiles

Support placeholders in show_tokens in shot_profiles. It should behave like show_player.

https://groups.google.com/forum/m/#!topic/mpf-users/Zb2csoZXtYs

fix in #1414


Show active nav class for "children" of custom menu links

Ref #48
On this line the equality check against path is ==. Is it possible to change that to item.link_url in request.path? Maybe there is a place to add an option so that it isn't forced, but I'm not sure where that would live.
Happy to make a PR if I can get some feedback about this request.
My use-case is that I have some pages that are non-Wagtail/data-driven, including our user directory. We don't want to make Wagtail pages for profiles, but we want to have them under the url /people/{user}. I added /people/ to wagtailmenus and that works fine, but doesn't show active class for the user URL.

Hi @inostia,
This is an interesting use case, so thank you for raising. The 'active' class in wagtailmenus is taken to mean "You are on this page", so the equality test you mentioned above is valid I think, and needs to stay as it is. However, there is another 'active' class in wagtailmenus that is used to indicate that a page is 'an ancestor of the active page', which I think sounds like a better fit for this situation.
The simplest implementation I can think of would be to change the following code:
if apply_active_classes and item.link_url == request_path:
    setattr(item, 'active_class', app_settings.ACTIVE_CLASS)

To:
if apply_active_classes:
    if item.link_url == request_path:
        setattr(item, 'active_class', app_settings.ACTIVE_CLASS)
    elif app_settings.CUSTOM_URL_ANCESTOR_HIGHLIGHTING and request_path.startswith(item.link_url):
        setattr(item, 'active_class', app_settings.ACTIVE_ANCESTOR_CLASS)

And add a new setting (False by default) to allow developers to turn the behaviour on when needed.

Great @ababic that approach makes perfect sense. I did not even consider using the ancestor class.
I think I'll be able to use some hours at my org this week to get this in, as it's a bit of a blocker for us. I'll reach out with any questions.

Thinking about it, it'd probably be more suitable to use urlparse to extract the path from item.link_url to use in both of these checks (which would work even when item.link_url included query params or a fragment identifier). We can probably also safely apply active classes for 'relative urls' (where netloc is blank).
if apply_active_classes:
    if apps_settings.CUSTOM_URL_SMART_ACTIVE_CLASSES:
        # new behaviour
        parsed_url = urlparse(item.link_url)
        if not parsed_url.netlock:
            if request_path == parsed_url.path:
                setattr(item, 'active_class', app_settings.ACTIVE_CLASS)
            elif request_path.startswith(parsed_url.path):
                setattr(item, 'active_class', app_settings.ACTIVE_ANCESTOR_CLASS)
    elif item.link_url ==  request_path:
        # previous behaviour
        setattr(item, 'active_class', app_settings.ACTIVE_CLASS)

I like the use of urlparse. But I can't imagine a scenario in which a person wouldn't want query params/fragment identifiers from being excluded from the match? Also I don't know why it's necessary to check for netloc if the user would presumably be on a different domain after clicking the link.
My thinking is for the requested feature, it'd be better to target specifically the case where someone wants to highlight ancestors for custom links, rather than wrapping it under "smart" active classes. That's why I like the setting CUSTOM_URL_ANCESTOR_HIGHLIGHTING.
Maybe something like:
from urllib.parse import urlparse
...
if apply_active_classes:
    parsed_url = urlparse(item.link_url)
    if app_settings.CUSTOM_URL_ANCESTOR_HIGHLIGHTING and request_path.startswith(parsed_url.path):
        setattr(item, 'active_class', app_settings.ACTIVE_ANCESTOR_CLASS)
    elif parsed_url.path == request_path:
        setattr(item, 'active_class', app_settings.ACTIVE_CLASS)

Hi @inostia,
Sorry, yes. I'm attempting to solve a limitation of the current functionality while we're here, and not explaining myself very well. I'm thinking some examples might help.

item.link_url is '/contact-us/#form' and request_path is 'contact-us/#somewhere-else'
item.link_url is '/contact-us/#form' and request_path is 'contact-us/'
item.link_url is /contact-us/?something=one and request_path is 'contact-us/?something=two'
item.link_url is /contact-us/?something=one and request_path is 'contact-us/'

If all of these cases, if these were links to pages (with the GET params and fragment identifiers added via item.url_append), the active_class would always be app_settings.ACTIVE_CLASS, because the urls do go to the same page. But currently, none of the above combinations would result in an app_settings.ACTIVE_CLASS - hence why I'd like move to if parsed_url.path == request_path - I feel like these results should be consistent whether the urls link to pages or custom URLS.
But, this is a change in behaviour - and something that might not be backwards compatible, depending on how wagtailmenus is being used... this is why I introduced the apps_settings.CUSTOM_URL_SMART_ACTIVE_CLASSES setting: to allow developers to opt-in to the new functionality if they choose to, but otherwise keep the behaviour the same (by only calling urlparse when apps_settings.CUSTOM_URL_SMART_ACTIVE_CLASSES is True, I'm also avoiding any performance overhead of calling it when it's not needed - however small that overhead might be).
I added the if not parsed_url.netloc: condition originally for the sake of improved efficiency (checking that a string is/isn't blank is faster than doing a string comparison). Since we get this value for free by calling urlparse we might as well make use of it, as it would help us avoid unnecessary string comparisons. But, there's actually actually a logical benefit to it, now that I think about it. Take the following cases for example:

item.link_url is 'https://website.com/contact-us/' and request_path is /contact-us/
item.link_url is 'https://website.com/contact-us/' and request_path is /contact-us/offices/

Without the netloc condition, 5 would result in app_settings.ACTIVE_CLASS being applied, and 6 would result in app_settings.ACTIVE_ANCESTOR_CLASS - neither of which would I class as desired behaviour.

Rather than adjust this code in-place, I would suggest adding a get_active_class_for_request() method to AbstractMenuItem to handle this particular bit of logic. It'll be much easier to test that way. I would also suggest adding tests for all of the above cases, to be sure it behaves as intended.

Hi @inostia. If you'd like a quick fix for this (it'll be approximately 4 weeks until version 2.8 is released), it might be worth experimenting with the menus-modify-primed-menu-items hook in your project.

Thanks @ababic . Actually I have a working implementation with tests passing! I'll be making a PR soon.

@ababic It's going to be difficult to work out the cases you've mentioned 1 and 2 because the hash fragment does not get sent to the server, and so is unavailable in the HttpRequest object. We can get the query params for 3 and 4 and compare those, but not the hashes as far as I can tell.
I'll make the PR as is and if there's any way you can think to compare hashes I'm happy to look deeper into it. I'm hesitant to implement the query params check as it would be inconsistent with handling of hash fragments.

Hi @inostia. Thanks for your efforts so far. I think what we're really looking to test is that in each case, the method always takes the path from the supplied request (which will always be void of query params or fragments) and compares it to parsed_url.path to get a result. It sounds like there's not much value in testing both 1 and 2, but I think 2 is worthwhile. The value in testing both 3 and 4 is perhaps questionable too,  but simulating at least one request with query params I think would be worthwhile.

Thanks @ababic. You can find the relevant tests here. I think this is what you mean. Please look over the PR.

Fixed in #221


CLOUD-56731 use ambari password as default service password

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2668/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/159/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2669/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/160/


#38 Retry if failed

#38
Sometime the conversion might take longer than usual. So, I set the retry so application can retry itself if something is wrong for maximum 3 times and 30 seconds delay.
I believe we don't have to change anything in the plugin since if it's successful we're going to post it back to the webhook anyway?
@mpatek What do you think?

@mpatek #reviewmerge please?


[Question]

I'm creating an API gateway using fastAPI for some microservices, which in I authenticate user via Azure AD via this library. So I'm trying to take out the user info from the request object (request.state.user) and inject my own token in it to later pass to other microservices. I can't do this in middleware, cause user info is getting added after it.
But I tried creating an decorator:
from functools import wraps

def token_injector(function):
    @wraps(function)
    def wrap_function(*args, **kwargs):
        user: User = kwargs['request'].state.user
        new_token = generate_token(user)
        kwargs["new_token"] = new_token # or kwargs['request']["new_token"] = new_token
        return function(*args, **kwargs)
    return wrap_function

and for this approach, I'm getting these errors:
ValueError: [TypeError("'coroutine' object is not iterable"), TypeError('vars() argument must have dict attribute')]
and
TypeError: 'Request' object does not support item assignment
Can you please guide me how did you inject user in request.state, so I can do the same?

Ok I got a solution, and I've posted in stackoverflow. But I'm leaving this open to see if there's any better solution for this. If not you can close this question. Thanks.

Hi! Thank you for following up letting me know it's been resolved.
There are a few questions here, so I'll try to answer them as best as I can.  Let me know if anything is unclear.
First off, I agree with the approach you've landed on. Chaining dependencies is the way to make sure something is "in the right order". It is also the approach I've described in the docs here. It's also deomonstrated in the demo project, in this view, using this dependency.
The user model is defined here, and is created here.
I would recommend you to not "get rid of" the User object, but maybe create your own user model and append to it. Here's an example:
from pydantic import Field
from fastapi_azure_auth.user import User
from typing import Optional

class CustomUser(User):
    new_token: Optional[str] = Field(default=None)

and then in your own dependency do this:
from fastapi import Depends
from fastapi_azure_auth.auth import InvalidAuth
from fastapi_azure_auth.user import User

async def new_user(user: User = Depends(azure_scheme)) -> None:
    new_token = 'ey....'
    new_user = CustomUser(**user.dict() | {'new_token': new_token})

I hope this code runs (I haven't been able to test it), but if not, let me know and I'll write a real example for you tomorrow.

That was a great advise and explanations. I moved the dependency part to a higher api_router and now it works for all the APIs. Thank you! This answer is gonna help me through the whole project in the future. I really appreciate it.

I’m happy to hear that 😊 Best of luck!

Just one small thing need to change in your answer. I had to change the dependency like this for it to work:
async def new_user(request: Request) -> None:
    new_token = 'ey....'
    new_user = CustomUser(**request.state.user.dict() | {'new_token': new_token})
    request.state.user = new_user

Ah, yes, I forgot about that part of the question 👍


possible python error at "Correcting umis" step

Hello, I have data from TotalSeqA. I received FASTQ files that were obtained with cellranger mkfastq, and concatenated all the R1 and R2 files into one to run Cite-seq-Count:
cat ADT1_S1_L00*_R1_001.fastq.gz HTO1_S1_L00*_R1_001.fastq.gz > ADT_HTO_1_S1_R1_001.fastq.gz
cat ADT1_S1_L00*_R2_001.fastq.gz HTO1_S1_L00*_R2_001.fastq.gz > ADT_HTO_1_S1_R2_001.fastq.gz

As you can see, I have ADTs and HTOs separated, and 2 lanes per sample.
I installed CITE-seq-Count within a conda environment using pip-install, using
conda config --set pip_interop_enabled True
pip install CITE-seq-Count==1.4.3

I get the error at the "Correcting umis" step (see attached log file). The error message is not very specific, so I don't really know how to troubleshoot. Can you help me out? Attached is also the tags.csv (I loaded a .txt, but i ran the .csv)
tags.txt
cite-seq-count.log
Versions:
conda version : 4.7.12
python version : 3.7.4.final.0
Linux/4.4.0-127-generic ubuntu/16.04.6 glibc/2.23

Hello @sorjuela,
this is kind of concerning as I remember fixing this bug a while ago.
I don't have much time to work on it these days so it might take a while to figure out what's happening as it's also the first time I see it creep up.
Just to be sure, could you run CITE-seq-Count --version for me please.

Hi @Hoohm, yes output is CITE-seq-Count v1.4.3

Hello, I have exactly the same error.
I get the error after "Correcting umis" :
File "/sandbox/users/egaschet/miniconda3/envs/mynewenv/lib/python3.8/site-packages/cite_seq_count/processing.py", line 229, in correct_umis
for TAG in final_results[cell_barcode]:
RuntimeError: dictionary keys changed during iteration
@sorjuela did you find out what the problem was ?

nope, was hoping the author would give me some suggestions/alternatives on how to continue. I'm not using CITE-seq-Count for the moment.

Hello @sorjuela and @EnoraBioinfo I'm sorry for the long waiting time. I'm swamped and only working on CITE-seq-Count on the weekends when I don't have other projects to do.
I want to try and debug this.
Do you have any duplicated tags in your tags.csv files?

Hi @Hoohm, no worries. I don't see any duplicates in mine. You can find my tags file in my first comment above.

I don't see any duplicated tags either :
TGTCTTTCCTGCCAG,antihuman_H7
CTCCTCTGCAATTAC,antihuman_H8
TAACGACCAGCCATA,antihuman_H12
AAATCTCTCAGGCTC,antihuman_H13
CTGTATGTCCGATTG,antihuman_H14
TAAGATTCAGAGCGA,antihuman_H15

I'm having a hard time recreating the error.
Would it be possible to send me some data?

Best case scenario would a small subset that still crashes. You can use the -n option to try it out.

Do you guys provide a whitelist when you run CSC?

Hi @Hoohm sorry for the delay. I can send you some data privately, i will send it to your gmail if that works for you. About the whitelist I'm not providing it, I thought the tags.csv would be enough?

also, I uploaded the log file in my first comment, so you can see how I'm running the software.

@sorjuela by email would be perfect yes.
I was asking about the whitelist because I was suspecting some issues with missing barcodes that would be added and could be responsible for the bug.
As you mentioned, the call is in the log and since you did not provide a whitelist, this is not the problem.
If you send the data, I can run and debug it very easily. That would be amazing.

Ok, I sent you a link to download the files.

Hi all,
have you by chance already found a solution for this? Unfortunately, I stumbled across the same error as mentioned above. Any advice on how to handle this would be great!

Hello @ligrob
This is an old bug. We fixed it by using the latest release, 1.4.3.

Yeah unfortunately I'm also still getting this problem even when running 1.4.3 :(
log-events-viewer-result.txt

Are you using this locally on a clean install?
If you are, would it be possible to send me a sample on which it crashes so that I can try it as well?

@Hoohm what is your email so I can send a reproducible example? I am having the same issue running version=1.4.3. I am currently running with --no_umi_correction to see if that prevents the issue, but that solution is less than ideal. Thanks!

@codymowery check out https://github.com/Hoohm/CITE-seq-Count/issues/125
try running with python 3.7

Looks like that did the trick. Thanks @robinfchan!

@robinfchan  Thanks Robinchan, py37 is working but py38 will produce the bug.

It should be fixed in 1.4.4 that just came out


Error using or configuring APOC in GithubAction

Guidelines
Error trying to install neo4j:4.4.9 and using APOC plugin in gitaction
To help us understand your issue, please specify important details, primarily:

When I test my pull request in github the following tests show me the next error message in django

neo4j.exceptions.CypherSyntaxError: {code: Neo.ClientError.Statement.SyntaxError} {message: Unknown function 'apoc.convert.toJson'

And I build image like and next lines configure the environment for test with python and django correctly, it wants to reproduce my docker-compose file but i had the same error when I try to run all unit tests cases:

jobs:
  test:
    runs-on: ubuntu-latest
    services: # Service containers to run with `test`
      # Label used to access the service container
      neo4j:
        # Docker Hub image
        image: neo4j:4.4.9
        # Provide the password for neo4j
        env:
          NEO4J_AUTH: "neo4j/neo4j_password"
          NEO4J_dbms_connector_bolt_enabled: "true"
          NEO4J_dbms_connector_bolt_advertised__address: localhost:7687
          NEO4JLABS_PLUGINS: "['apoc']"
        ports:
          - 7687:7687

Is missing something in my configuration or I'm losing something for configuration?

@AdrianPardo99 I think it's due to the quoting you have around NEO4JLABS_PLUGINS: "['apoc']"
The value "['apoc']" is piped straight into jq to interpret what plugins have been requested. So testing your NEO4JLABS_PLUGINS value...
echo "['apoc']" | jq
parse error: Invalid numeric literal at line 1, column 8

so that error message, or something similar, probably shows up somewhere in your docker logs. If I swap over the quote type, then it works:
echo '["apoc"]' | jq
[
  "apoc"
]

The documentation could possibly be clearer, but there are at least some examples to copy:
https://neo4j.com/docs/operations-manual/current/docker/operations/#docker-neo4j-plugins


[ALLUXIO-3063] [WIP] Ufs sync debug

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17933/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17953/
Test PASSed.


[CMake] Install SwiftShims when not building stdlib and building tools

Some swift tools will rely on the shims to work properly, but currently they are
only installed if we build the swift stdlib. Like Reflection, we build it if we
are building the tools even if we aren't building the stdlib.
cc @compnerd @drodriguez @gottesmm @Rostepher

@swift-ci please smoke test and merge

@xiaobai This is not enough information in the PR? What tools rely on this?

@gottesmm the swift compiler depends on this.  Without this, if you build just the toolchain without the standard library, you will not be able to compile code with that compiler since the resource directory will be missing.

@Rostepher was also working on something like this. I'll ping him.

@swift-ci please smoke test Linux platform

Some thoughts:

swiftReflection is only included so we an build it for the host side. That is a red-herring.
I would like to get Rostephers opinion.

Please give more context in the PR/etc.

Could we gate this for toolchain builds perhaps?

@gottesmm: The swift compiler, a swift tool, depends on the clang resource directory. If you don't build the standard library, the compiler can't fully function because it will be missing a clang resource directory.

swiftReflection is only included so we an build it for the host side. That is a red-herring.

Just as swiftReflection is needed for the host side, the clang resource dir is also needed.
@Rostepher: Do you mean only do this if you are building a complete toolchain? What would that entail?

Would it be good if maybe the clang header copy/symlink pieces of the shims get moved out into something in the compiler CMake files?

@Rostepher - btw, the final installation is still controlled by the SWIFT_INSTALL_COMPONENTS

@compnerd As long as the actual installation for the shims remains under the stdlib component then I think we're fine. It seems this change is really to just force any build that does not build the stdlib to install the shims in the build resource directory, not in the final installation/toolchain?

Right, this change only forces the "build" (aka, we create the symlink during the build).  However, the installation is controlled by the -DSWIFT_INSTALL_COMPONENTS.

@swift-ci please build toolchain

macOS Toolchain
Download Toolchain
Git Sha - 651885ae82ca419021f9718d5c3f8bfe1003fa34
Install command
tar -zxf  swift-PR-25641-320-osx.tar.gz --directory ~/

Okay, verified that this does not actually change any of the install behaviours.  @xiaobai, I think that the thing here was that the title is somewhat misleading.  It should be something more along the lines of "permit installation of the shims when not building the stdlib/sdk overlay".  I think that the actual problem is valid.  This doesn't impact anything in terms of installation, just enables that the component is available without the SDK Overlay or standard library being built.  So, this satisfies @Rostepher's concerns.

Apologies for the confusion. I could have done a much better job here, and intend to do better in the future. Thank you for your reviews!


Apply default collation on tables as per documentation (new #1165)

Closed and re-opened from #1165 as I put new commits into my own master branch - use this one instead please
As per the documentation on environment configuration, there should be an option named collation. This configuration option doesn't do anything when you set it.
This change will set the default collation of newly created tables in this order:

The collation option provided in the array of options
The collation option provided in the environment configuration
utf8_general_ci

Any chance this gets merged?

Codecov Report

Merging #1169 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1169      +/-   ##
==========================================
+ Coverage   72.19%   72.24%   +0.05%
==========================================
  Files          35       35
  Lines        5549     5553       +4
==========================================
+ Hits         4006     4012       +6
+ Misses       1543     1541       -2

Impacted Files
Coverage Δ

src/Phinx/Db/Adapter/MysqlAdapter.php
98.13% <100%> (+0.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e1888...0ab243d. Read the comment docs.

Any news on getting this merged?

What if we remove the hardcoded default settings instead? I think we should not overwrite default settings on the database.

@chinpei215 - I totally agree that Phinx setting its own default to override the DB's default is a bit odd. But would that be considered backwards incompatible? Phinx has always been doing it, I think if we changed it now that would break a lot of setups if people relied on that default collation.

@nebez Fair points. OK, I will confirm your patch on my local  environment, as I have a little concern about charset/collation mismatch between database settings and configurations (I may be wrong though). And if there are no problems, I will also approve your pull request.

@nebez Personally, I would like to remove the default entirely. I think it would confuse users. And if someone wants some default collation and/or engine, I think they should change DEFAULT CHARACTER SET on the database, and/or the default_storage_engine variable. But yes, probably we would need to communicate with others.

OK. First I thought we should merge not only collation, but also charset. But now I know the option is not used when creating tables. CHARACTER SET seems to be determined by collation:
https://github.com/cakephp/phinx/blob/d84a6c7f4e6919614023b8d17a01992a125a3aae/src/Phinx/Db/Adapter/MysqlAdapter.php#L242-L246
So there is no need to merge the option at this point. If no one argues, I will merge this PR.

Sounds good @chinpei215 - thanks for taking this on!

Merged. Thank you for your contribution.


Update path representation throughout code base

Currently we represent paths using pure string. e.g. foo/bar/ rather than using utility functions of os.path. This constraints the use scope of tower cli (e.g. Windows users cannot use tower cli while they surely can use Tower via browser).
This issue can be expanded as a thorough cross-platform compatibility audit.

Closing this ticket because tower-cli is currently so UNIX-specific that updating path representation alone won't be any helpful. I would prefer tracking every aspect, including path representation, later on when we actually put cross-platform compatibility on to agenda.


Copy (ctrl+c. ctrl+shift+c) does not work in Vim or ignored (windows 11)

Steps to reproduce

choco install vim
open file with vim
select text and try to copy (ctrl+c. ctrl+shift+c)
try to past (ctrl-v)

Expected behaviour
Copied text is past
Actual: old clipboard is used and just copied is ignored, also seems like old clipboard is corrupted when pasted
Version of Vim
v9.1.466
Environment
windows 11
tested on: PowerShell 7, PowerShell 5, git-bash 2.45.2, nushell  0.94.1 (same behavior)
Logs and stack traces
Screenshots

If you want typical Windows shortcuts, you need to explicitly source $VIMRUNTIME/mswin.vim. I would however rather recomment to learn Vim shortcuts instead. See :h mswin.vim
Closing as not a bug. Please ask user questions at appropriat forums instead.


Ruby rewrite: Jewler to create a gem layout

This issue is to track rewriting gitlab-mirrors in ruby instead of bash.  This way we get unit testing fun but still have the ability to subshell using back ticks if that's required.

19:25 < cosman2001> sag47, gitlab_mirrors would be simpler if it was a ruby CLI since it would have a single interface.
19:26 < sag47> cosman2001: Yeah, I've been looking for an excuse to flex my ruby muscles.  I recently learned it and have been wanting to come up with a good project with it.
19:26 < sag47> It's basically bash on steroids and more.
19:26 < sag47> I like that it supports back ticks.
19:27 < sag47> Perhaps I'll figure out how to make gitlab-mirrors a gem.
19:27 < sag47> That's all future looking :)
19:28 < cosman2001> sag47, use jewler to auto create the gem layout and get to work.  There are some good CLI gems that would help built an interface.
19:28 < sag47> cosman2001: Thanks for the advice, I'll start the project management on GitHub and add that as a ticket.

That's the nutshell from #gitlab on IRC freenode.

I think the best approach here to to use the below gem to interface with.  This dependency would be similar to python-gitlab3.  But the gem below looks way better.
I would be willing to start this gem/rewrite for you but I won't be able to maintain it since I have committed to so many projects already.  If you want create a new repo and give me permission to push and I'll get you started.
https://github.com/NARKOZ/gitlab

@logicminds Rather than that let's create a branch dedicated to the ruby rewrite.  In that branch you can manipulate any files you want.  I've added you as a contributor.

I think it should just be a new repo.  That way you can have a fresh start.  Additionally if someone still wants the bash/python version its still intact.

@logicminds Please keep in mind that I adhere to the git flow workflow with this project.  That means that master is production ready merges only.

Well for the bash/python implementation there's the prior versions that have been tagged (v0.1 through v0.5).  So they can check out any of those versions and get the old implementation.  Patches can still be made to those older versions if necessary.
I'd rather not fragment the project and just convert it into a gem.

I don't think it would fragment the project.  One is a ruby gem and the other is a set up scripts.  Personally these are two different things that just take a similar approach  Honestly, its best to have a new repo that way the gem version can match against the repo version.  This is huge change and anybody using the current implementation would want to know.  Maintaining each code base independently will may it simplier in the long run. The project should be called ruby-gitlab_mirrors

Fair enough, I've created https://github.com/samrocketman/gitlab-mirrors.rb
I've added you as a collaborator so you have RW access to it.

@logicminds since we can depend on rubygems.org for hosting stable versions I think it's okay to let master branch be bleeding edge development.  Only published gems are the stable releases (with tags denoting which version is which).

Sorry to nag.  But this isn’t the “ruby standard”.  It should be ruby-gitlab_mirrors.   You Can you change to ruby-gitlab-mirrors too if you prefer.
I follow gitflow so regarding the comment above thats my normal workflow anyways.

Not nagging; I renamed the project to ruby-gitlab-mirrors.  Is there a good place I can refer to look up ruby best practices or good conventions in ruby?

Since, I haven't really made any progress here and I'm probably not going to in the near future due to other interests... I'm going to abandon the thought of rewriting this in ruby.


[FEATURE]: postgres: deferrable constraints

Describe what you want
https://www.postgresql.org/docs/16/sql-createtable.html#SQL-CREATETABLE-PARMS-DEFERRABLE
I'm looking for something along the lines of:
export const foo = pgTable("foo",
  {
    name: text("name").notNull(),
  },
  (foo) => ({
    uniqueName: unique("name_unique", {deferrable: true, initially: "immediate"}).on(foo.name),
  }),
) satisfies PgTable;

Also, currently drizzle-kit generate:pg is generating a new migration to DROP the CONSTRAINTs and re-CREATE them without the DEFERRABLE in case they are actually marked as deferrable in the DB.

Would this feature include DEFERRABLE on ALL constraints?  I'm especially looking for deferrable foreign key constraints.

Bumping this issue, this is achievable in the schema instead of manually editing the generated SQL files

Bumping, same issue here.

Bump, just ran into this a problem with this.

Bumping, same issue here.


Partial fix for debug source lookup - still broken for srcs in jars

@plaird this fixes source lookup if you breakpoint in a diff java project from the one that you are actually debugging (==launching). We still need to fix source lookup for jars (if you breakpoint in code coming from a Nexus jar) - what did you have to get that to work for regular "open type in jar" functionality?

The original issue with source jars was that the aspect was writing the json with source jar attribute with one name, and the java code that was reading the json was looking for another name. I didn't trace what side broke, but the fix was to standardize the name.


fix wrong link.

fix #954

Thanks for this PR! This appears to be a dupe of #987, so I think this can be closed.


NSX: Add more unit tests

Description
This PR...

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 8152

@blueorangutan package

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8159


refactor: use v8::OneByteConst

Closes https://github.com/denoland/deno_core/issues/527
Not sure I'm happy with having v8_static_strings::new_from_static_str. Maybe all op declarations
should provide their names as v8::OneByteConst. Also v8_static_strings should be renamed to
v8_const_strings?

Maybe all op declarations should provide their names as v8::OneByteConst

I think that's a good idea. It's a const function, so it's effectively free for us to just generate name_v8 next to name.

Maybe all op declarations should provide their names as v8::OneByteConst

I think that's a good idea. It's a const function, so it's effectively free for us to just generate name_v8 next to name.

Argh.... upon further inspection it seems to be impossible right now as v8::OneByteConst doesn't implement Clone nor Copy. Maybe it's something that could be implemented in rusty_v8?

Not sure I'm happy with having v8_static_strings::new_from_static_str

Actually, we can probably just add a deref to &'static str for &'static OneByteConst, which would allow us to store &'static OneByteConst on ops and ExtensionFileSource...

Looks like

Argh.... upon further inspection it seems to be impossible right now as v8::OneByteConst doesn't implement Clone nor Copy. Maybe it's something that could be implemented in rusty_v8?

That should be OK for now as &'static OneByteConst is Copy + Clone.

We'll do the necessary changes in a follow up PR.


xgb.plot.shap using shap_contrib values fails

When calling xgb.plot.shap using data calculated with a previous run of xgb.plot.shap in this way:
 xgb.plot.shap(shap_contrib = prev$shap_contrib, data = prev$data)
.. I get "shap_contrib is not compatible with the provided data".
When looking at the code, I get the impression that there is an error in line 123.  Should this:
       (!is.matrix(shap_contrib) || nrow(shap_contrib) != nrow(data) || ncol(shap_contrib) != ncol(data)+1))
..not really be this:
           (!is.matrix(shap_contrib) || nrow(shap_contrib) != nrow(data) || ncol(shap_contrib) != ncol(data)))
i.e. without the "+1" at the end? If I remove it, the function works for me.

@avanwouwe Please provide your XGBoost version and a reproducible script.


power: stm32l5: support of the Low Power sleep mode

With this patch, the low power mode on stm32L5 is enabling the Low Power Timer to measure the sleep time duration and wakeup from sleep mode on this LP timer expiration.
The SLEEP modes (corresponding to STM32 stop 0,1,2 modes) are supported on this device.
When low power is enabled on the system and when going to sleep, the lptim counts and wakes up the kernel though its interrupt routine.
The soc policy decides to go to sleep, if compatible with its residency when calling the sys_pm_policy_next_state for a nb of kernel ticks.
Each boards defconfig should set CONFIG_CLOCK_STM32_MSI_PLL_MODE=y
This PR is requires the support of the LPTimer on stm32l5  #32999
Note that DEEP_SLEEP modes are not enabled yet, as LPTIM cannot run during stm32 standby or shutdown modes.
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

Rebasing with the definition of the CORTEX_M_SYSTICK
LPTIM source clock are set to LSE

At this time, only stm32l562e_dk board has low power sleep modes in the stm32l5xx soc serie.

rebase , fixing conflicts with stm32l562e_dk.dts

adding a commit to enable the MSI auto-calibration on the disco board

moving power state definition to boards/arm/stm32l562e_dk/stm32l562e_dk_common.dtsi
adding the lptim1 and low power modes to the boards/arm/stm32l562e_dk_ns
change the substate-id range from 1-3 as described in the include/power/power_state.h
this is changing the range in pm_power_state_set() of the soc/arm/st_stm32/stm32l5/power.c

rebase

rebase
add the CONFIG_CLOCK_STM32_LSE  in the board def_config to enable the CONFIG_CLOCK_STM32_MSI_PLL_MODE without warning (as the CLOCK_STM32_MSI_PLL_MODE depends on the CLOCK_STM32_LSE through the Kconfig.stm32l4_l5_wb_wl)


Add monster name formatting

Add a name sanitisation function which converts the monster names from their direct string to either a capitalized  version, or split up as in the case of "Water Devil". A switch statement is probably overkill, just leaving it open in case they add some more monsters down the line

Thanks!


vendor/autoload.php is missing from sources?

I'm trying to use this package without composer's assistance.
Should I "require" each and every file separately?
Also, when doing that, the code complains that GuzzleHttp is missing - is this a separate package I should download and require?
thanks in advance,
Nimrod.

Did you find the file? im missing it aswell :-(

No, I ended up communicating with API.AI directly, which turned out to be an easy thing.
I'm using wordpress which has a really good http calls class

if this is any help:
$headers = ["Authorization" => "Bearer ".get_option("aisupport_token"),
"Content-Type" => "application/json; charset=utf-8"];
$data = [
"query" => $question,
"v" => "20170519", //current date of development
"lang" => "en",
"sessionId" => $_SESSION["aisupport_session"]
];
$result = wp_remote_post("https://api.api.ai/v1/query",
[
'headers'   => $headers,
'body'      => json_encode($data)
]);
return $result["body"];

vendor/autoload.php is generated by composer, no composer means no autoload.
You need to come up with your own solution for loading this library if you don't use composer.


View Controller size class is unspecified when loaded through test

I'm trying to write some view controller tests that differ in behavior between iPhone and iPad in a universal app. When running the tests, the horizontal size class returned is always UIUserInterfaceSizeClassUnspecified. With XCTest, it returns the correct size class depending on whether I run it on an iPhone or an iPad.

Hey Randall, I'm sorry you're having this issues.
 Do you have a spec suite that runs your tests in a separate application, or are you using a test bundle?
My expectation is that this should work with Cedar when running in a test bundle. In that case, your real application starts up in the simulator, and there is a real window backing it.
If your tests are setup as a stand-alone spec suite, I imagine you may have to do some additional setup to make this work. You may need to create a UIWindow and set your view controller as the root view controller on it.

@blladnar did that help? Still having issues? If you have a small reproducible test case, I'd love to dig into this more.
I've definitely encountered this in the past using Cedar and found it difficult to work around, but possible with enough work. Would love to help you out if I can.


Update design of web receiver to support secondary feed

@drew-usds to design, then @mry-usds to build

Per discussion, I think there was interest in a tabbed format.
I personally think this is a lot like Gmail. There is primary inbox that the user will use 95% of the time, and secondary inbox that users will use 5% of time.

But - flip side, there may be some cause to have a single table that's filterable (checkboxes, etc.)

Also would work. I think the default view should not show data outside the primary feed, though that should be filterable and perhaps down the line, on by default through some type of settings

From: Matt Young @.>
Sent: Monday, June 7, 2021 4:49 PM
To: CDCgov/prime-data-hub @.>
Cc: Liu, James (CDC/OCOO/OD) @.>; Author @.>
Subject: Re: [CDCgov/prime-data-hub] Update design of web receiver to support secondary feed (#1247)
But - flip side, there may be some cause to have a single table that's filterable (checkboxes, etc.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/prime-data-hub/issues/1247#issuecomment-856333603, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ2FEW3X6M3AX26QLI3QWOTTRVLG7ANCNFSM46ISKDHQ.

Duplicate of OTC front end. Re-look at designs when we launch data volume.


fixed #241 Improve the UI of the Navbar

Fixes:  #241

The changes I made include:

Making the navbar background transparent to make it look good
Aligning nav items properly using Flexbox
Adding JavaScript to change the navbar color while scrolling
Additionally, I:
Set the hero image height to 100vh for a full-screen.
Adjusted the button size for better UI

@Aradhya-005 Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Automatically install browser integration for Linux

Currently the linux implementation for Live Share requires that a user manually run a command to enable browser integration. This extra step is not ideal but is required since the Electron host for VS Code any attempt to run a command via sudo and admin privileges are required. (See here for details.)

This feature request is tracking additional research into alternate methods for installing browser integration as a natural part of the Live Share extension install process.

This should now be available in v0.3.392/v.0.393.


fix: remove the use of the classic git buildpack

Since the addition of the extra step in this pipeline the git buildpack seems to be ignored. In addition the default behaviour for the release step in a jenkins-x pipeline is to tag the repository with the next version.

/lgtm

/test all

/retest

/retest

/retest

/retest

/retest

/test all

/retest


Adding new VIP Swap APIs to support extension resource design

This PR contains a new api defined using the Extension Resource design to support VIP Swap for CSES.
Design spec - https://microsoft-my.sharepoint.com/:w:/p/shnaya/EWAKJ-O2JOtMtz3jQNM68wEBWiOvlrjh_oJoVtY_rD2wSw?e=9SzBOf
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[x ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@shnaya434 , can you fix lintDiff error which has one new error introduced by this PR?

@shnaya434 , can you fix lintDiff error which has one new error introduced by this PR?

@MikhailTryakhov Can you please have a look?

/azp run

@shnaya434 , can you fix lintDiff error which has one new error introduced by this PR?

@MikhailTryakhov Can you please have a look?

@raych1  The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateLinkServices/{serviceName}/privateLinkResources was not implemented in earlier versions also.

approved LintDiff , as it's known diff issue


[ci] Change to cache build dependencies

This commit updates the CI to cache build dependencies (llvm,
nvidia toolchain, and pybind11) to speed up build process.
In order to do this, we need to expose the versions of nvidia
toolchain and pybind11 needed like llvm.

Triggered CI for you!

Thanks @jlebar! :D I'm expecting some push buttons on this one given needing to iterating on it a bit. But don't need to review until it's tested working.


[ABI] [stdlib] Remove magnitude-based overload of abs(_:).

The standard library has two versions of the abs(_:) function:
func abs<T : SignedNumeric>(_ x: T) -> T where T.Magnitude == T
func abs<T : SignedNumeric & Comparable>(_ x: T) -> T

The first is more specialized than the second because T.Magnitude is
known to conform to Comparable. Indeed, it’s a more specialized
implementation that returns magnitude.
However, this overload behaves oddly: in the expression abs(-8), the type
checker will pick the first overload because it is more specialized. That’s
a general guiding principle for overloading: pick the most specialized
overload that works.
However, to select that overload, it needs to pick a type for the literal
“8” for which that overload works, and it chooses Double. The “obvious”
answer, Int, doesn’t work because Int.Magnitude == UInt.
There is a conflict between the two rules, here: we prefer more-specialized
overloads (but we’ll fall back to less-specialized if those don’t work) and we prefer to use Int for integer literals (but we’ll fall back to Double if it doesn’t work). We have a few options from a type-checker
perspective:

Consider the more-specialized-function rule to be more important
Consider the integer-literals-prefer-Int rule to be more important
Call the result ambiguous and make the user annotate it

The type checker currently does #1, although at some point in the past it
did #2. Moving forward, #1 is a better choice because it prunes the number
of overloads that need to be considered: if the more-specialized overload
succeeds its type-check, the others need not be considered. It’s also
easier to reason about than the literal-scoring approach, because there can
be a direct definition for “more specialized than” that can be reasoned
about.
I think we should dodge the issue by removing the more-specialized version
of abs(_:). Its use of magnitude seems unlikely to provide a
significant performance benefit, and the presence of overloading either
forces us to consider both overloads always (which is bad for type checker
performance) or accept the regression that abs(-8) is Double. Better
to eliminate the overloading and, if needed in the future, find a better
way to introduce the more-specialized implementation without it being a
separate signature.
Fixes rdar://problem/42345366.

@swift-ci please benchmark

@swift-ci please smoke test

Potentially controversial standard library change here ;). Let's see if it affects benchmarks at all.

ArrayOfPOD
777
859
+10.6%
0.90x

Improvement

SortStringsUnicode
5180
4820
-6.9%
1.07x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------

It's not only there for a performance benefit; the SignedNumeric & Comparable implementation is incorrect for types conforming FloatingPoint (it does the wrong thing by failing to negate -0 and nans with the sign bit set).
We can probably address this by adding a FloatingPoint overload.

In a generic context, we won't get the magnitude-based implementation regardless, and overloading on FloatingPoint will introduce the same problems as the existing overload.

For example, this does the wrong thing (prints -0.0) in Swift 4.2:
func test<T: SignedNumeric & Comparable>(_ x: T) {
  print(abs(x))
}

test(-0.0)

Hey @stephentyrone , I'd love your thoughts on the evil trick in https://github.com/apple/swift/pull/21037/commits/ab755770799f39055b066adc7829b0dd57de5f65

@swift-ci please test

@swift-ci please benchmark

@swift-ci please benchmark

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 85d488d461dd7611b4cb70e8a371134d1fcd16c3

Build comment file:
Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

Walsh.o
8420
7628
-9.4%
1.10x

Integrate.o
2520
2456
-2.5%
1.03x

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

Walsh.o
6020
5900
-2.0%
1.02x

Integrate.o
2502
2454
-1.9%
1.02x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

Integrate
1509
2059
+36.4%
0.73x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------

Hey @stephentyrone , I'd love your thoughts on the evil trick in ab75577

LGTM.

There's a few things about this function that kind of stink, but your changes aren't making it any worse. We should take this as-is, but I may poke at it some more and send you another follow-on PR.

(Also, please clone this for 5.0 when you have a chance.)

Okay!


rename variables when datadrive is mounted

Other scripts source blitz.datadrive.sh status and expect the renamed variables.

Variable 'datadisk' is also used in other scripts. So blitz.datadrive.sh status has to return both.


envoy: Update envoy 1.28.x to v1.28.5

This is mainly to pick up the below CVE fix from the upstream.
Related CVE: https://github.com/envoyproxy/envoy/security/advisories/GHSA-fp35-g349-h66f
Relates: https://github.com/cilium/proxy/pull/819
Relates: https://github.com/envoyproxy/envoy/releases/tag/v1.28.5

/test

/test-backport-1.13

/test-1.23-4.19


Permission issue running dbt code using production schema in QA cluster

Description/Context

As data analysts, we would like to run dbt code on the dev_qa target but use the production schema because QA data is often not useful

database: ol_data_lake_qa
schema: ol_warehouse_production_dev
host: mitol-ol-data-lake-qa-0.trino.galaxy.starburst.io

This is the error I got when running dbt code against dev_qa
  TrinoExternalError(type=EXTERNAL, name=HIVE_METASTORE_ERROR, message="User: arn:aws:sts::610119931565:assumed-role/data-lake-query-engine-role-qa/trino-session is not authorized to perform: glue:CreateDatabase on resource: arn:aws:glue:us-east-1:610119931565:database/ol_warehouse_production_rlougee_staging because no identity-based policy allows the glue:CreateDatabase action (Service: AWSGlue; Status Code: 400; Error Code: AccessDeniedException; Request ID: ee46b622-8933-492b-b914-c0b358b6b3c8; Proxy: null)", query_id=20230809_185544_08799_3cv42)
Expected Behavior

Run dbt code against dev_qa using schema ol_warehouse_production_dev successfully

@blarghmatey FYI, this is the issue we talked about.

@blarghmatey @rachellougee has this been fixed?

This can be closed. We can now use dev_production to create separate dev schema in production database as oppose to dev_qa


Improve API for .execute() all nodes

Problem
Currently, the primary way to use Driver.execute() is to pass a list of node names (str). It's useful to get all existing nodes for various reasons:

iterative development
debugging
create data quality check
write tests
But managing a list of strings is likely to be incomplete, is typo-provide, and can't provide IDE support

Current solution
Use Driver.list_available_variables() to get node names programmatically, filter them to exclude config nodes, and pass them to Driver.execute().
Given "getting all dataflow nodes" is likely the most common usage, it's odd to receive a list and systematically have to do list comprehension over it. I always forget the API to filter out config nodes.
Issues:

it doesn't tell you that you need to filter out config nodes, and it's API could make it easier
it's hard to find
the "variable" terminology is outdated and the documentation should be updated

Potential solution

Update docstring to use "node" terminology
create a new method .available_nodes() and issue deprecation warning for direct .list_available_variables() calls
have a separate getter for .config()

Hmm, config nodes shouldn't be in list_available_variables... The fact that they show up is a bit of a hack, no?

Looking at git blame and going off memory, .list_available_variables() used the Variable construct. Now, the driver module defines Variable = graph_types.HamiltonNode to standardize the API and deprecate Variable. One would expect to receive nodes from HamiltonGraph.nodes, but this wasn't associated with changes to .list_available_variables() which uses the FunctionGraph through self.graph.

Looking at git blame and going off memory, .list_available_variables() used the Variable construct. Now, the driver module defines Variable = graph_types.HamiltonNode to standardize the API and deprecate Variable. One would expect to receive nodes from HamiltonGraph.nodes, but this wasn't associated with changes to .list_available_variables() which uses the FunctionGraph through self.graph.
The current
def list_available_variables(self, *, tag_filter=None) -> List[Variable]:
        all_nodes = self.graph.get_nodes()
        if tag_filter:
            valid_filter_values = all(
                map(
                    lambda x: isinstance(x, str)
                    or (isinstance(x, list) and len(x) != 0)
                    or x is None,
                    tag_filter.values(),
                )
            )
            if not valid_filter_values:
                raise ValueError("All tag query values must be a string or list of strings")
            results = []
            for n in all_nodes:
                if node.matches_query(n.tags, tag_filter):
                    results.append(Variable.from_node(n))
        else:
            results = [Variable.from_node(n) for n in all_nodes]
        return results

should become
def list_available_nodes(self, *, tag_filter=None) -> List[HamiltonNode]:
     g = graph_types.HamiltonGraph.from_graph(self.graph)
     all_nodes = g.nodes

     # reimplement node filter

     filtered_nodes = ...
     return filtered_nodes

Sure, happy with the new name. What I'm saying is that having config nodes even show up at all is weird, we should filter by default (and figure out why they're included at all...).

config is a place to put invariant inputs as well; config can be a runtime input as well. It's always been that way.

config is a place to put invariant inputs as well; i.e. "config", the dictionary passed in for it, can be a runtime input. It's always been that way.

Yes, but that doesn't mean we should represent it as a node, and definitely shouldn't include jt with list_available_vars

config is a place to put invariant inputs as well; i.e. "config", the dictionary passed in for it, can be a runtime input. It's always been that way.

Yes, but that doesn't mean we should represent it as a node, and definitely shouldn't include jt with list_available_vars

It is and has always been a node in the graph. It's clearly marked that it doesn't come from a function. You can request it as an output.

Sure, happy with the new name. What I'm saying is that having config nodes even show up at all is weird, we should filter by default (and figure out why they're included at all...).

I agree with you.  What got even more confusing is the recent overwrite of Variable by HamiltonNode type, but configs values are never converted to HamiltonNode elsewhere in the code (i.e., they're not in HamiltonGraph)

It is and has always been a node in the graph. It's clearly marked that it doesn't come from a function. You can request it as an output.

I know config can be used as "input values that are constant for the lifetime of a Driver", but I think it makes more confusing. It's much easier to explain config as "the thing that define the shape of the DAG but doesn't interact with values"
Driver/Builder defines the DAG, execute/materialize define execution values
I'm always surprised when reading it in examples or documentation, such as the numpy one
    dr = driver.Driver(
        {
            "input_file_name": "air-quality-data.csv",
            "after_lock_date": "2020-03-24T00",
            "before_lock_date": "2020-03-21T00",
        },
        analysis_flow,
        adapter=adapter,
    )

    output = ["t_value", "p_value", "before_sample", "after_sample"]
    # dr.visualize_execution(output, './my_file.dot', {})
    result = dr.execute(output)

For file paths and dates, I can intuitively make sense of them being "used as input", but for an int or string, I would just have to guess if it triggers a @config.when

Config becomes nodes in the graph -- and you have always been able to request config/inputs as outputs.

Nonetheless, this is related to the recent visualization PR I merged. Config nodes were only displayed in .display_all_functions() because they wouldn't be part of the execution path otherwise (even if they influenced the path of which node was executed).
With this viz PR, the above numpy example would show input_file_name, after_lock_date, and before_lock_date on the display whether or not their values are read.


executing the api service enpoint.py from terminal gives an import error

Use case while executing poetry run python3.12 ./api/endpoint.py you get the error below
poetry run python3.12 api/endpoint.py
Traceback (most recent call last):
File "/Users/roland/code/NurB/Nur/api/endpoint.py", line 7, in
from credentials import oai_api_key
ModuleNotFoundError: No module named 'credentials'
ls -al /Users/roland/code/NurB/Nur/ | credentials
zsh: command not found: credentials
ls -al /Users/roland/code/NurB/Nur/ | grep credentials
-rw-r--r--   1 roland  staff    1763 16 Feb 09:42 credentials.py
-rw-r--r--   1 roland  staff     357 17 Feb 22:27 credentials_example.py

I executed this command to be able to execute the module from the terminal without pycharm
export PYTHONPATH="/Users/roland/code/NurB/Nur:$PYTHONPATH"
This is more of a workaround I hope to find a solution for it once and for all.


Bad layout for images in diff view

Issue Type: Bug
Repro

In a git repo
Edit an image
Try viewing the diff

Bug
The webview for the image preview can be poorly laid out (or hidden entirely)
VS Code version: Code - Insiders 1.45.0-insider (fd5d9a30259bb2bebab3e62dfd8315c2e1b27744, 2020-05-04T09:21:17.770Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (0.34GB free)

Process Argv
-psn_0_41998347

Screen Reader
no

VM
11%

This was caused by ea07e9bbdc598480dadfd1297e9e817e40802bce
@sbatten (not sure if you are the correct owner) For May, I suggest we investigate why the .layout call has bogus dimensions. That would let me remove the workaround I added in ea07e9bbdc598480dadfd1297e9e817e40802bce
For April, I'll add a ugly workaround that should be safer

Merged fix into 1.45
Checked better fix into master with f761228


bhop

can you add bhop to the cheat

can you add bhop to the cheat

bhop is really easy to make google  it

can you help me

Added.


Google audit - vulnerability detected

bootstrap 3.3.7
I need to improve my score and security, through google audit, I verified that the library is vulnerable, according to the attached image and I can not migrate to version 4.0.0

It's a known issue, wait for #27288 .