The template function 'reference' is not expected at this location.

Bicep version
Bicep CLI version 0.3.1
Describe the bug
I receive the error "The template function 'reference' is not expected at this location." when expecting it to not error out. See below for more details.
To Reproduce
Run the following commands using the files defined below:
bicep build root-template.bicep
az deployment group create --name test1 --resource-group <your-resouce-group-name> --template-file ".\root-template.json"

Comment/uncomment the code towards the bottom of the root-template.bicep file to use the code that will work vs the code that doesn't but is expected to.
// root-template.bicep

resource applicationInsights 'Microsoft.Insights/components@2018-05-01-preview' = {
  name: 'someAppInsightsName'
  location: 'East Us'
  kind: 'web'
  properties: {
    Application_Type: 'web'
  }
}

resource appServicePlan 'Microsoft.Web/serverfarms@2018-02-01' = {
    name: 'someName'
    location: 'East Us'
    kind: 'functionapp'
    sku: {
      name: 'Y1'
      size: 'Y1'
      family: 'Y'
      capacity: 0
      tier: 'Dynamic'
    }
    properties: {
      perSiteScaling: false
      maximumElasticWorkerCount: 1
      isSpot: false
      reserved: false
      isXenon: false
      hyperV: false
      targetWorkerCount: 0
      targetWorkerSizeId: 0
    }
}

var mainAppSettings = [
  {
    name: 'APPINSIGHTS_INSTRUMENTATIONKEY'
    value: reference(resourceId('Microsoft.Insights/components', applicationInsights.name), '2018-05-01-preview').instrumentationKey
  }
  {
    name: 'APPLICATIONINSIGHTS_CONNECTION_STRING'
    value: 'InstrumentationKey=${reference(resourceId('Microsoft.Insights/components', applicationInsights.name), '2018-05-01-preview').instrumentationKey}'
  }
]

var functionAppNames = [
  'someFunctionAppName'
]

// this next block works

module functionApps './bicep-templates/function-app.template.bicep' = [for i in range(0, length(functionAppNames)): {
  name: functionAppNames[i]
  params:{
    name: functionAppNames[i]
    location: 'East Us'
    serverFarmId: appServicePlan.id
    appSettings: mainAppSettings
  }
  dependsOn:[
    appServicePlan
    applicationInsights
  ]
}]

// vs this next block doesn't work (comment out the above block when uncommenting out the below block)

// var functionOptions = [
//   {
//     name: functionAppNames[0]
//     settings: mainAppSettings
//   }
// ]

// module functionApps './bicep-templates/function-app.template.bicep' = [for functionOption in functionOptions: {
//   name: functionOption.name
//   params:{
//     name: functionOption.name
//     location: 'East Us'
//     serverFarmId: appServicePlan.id
//     appSettings: functionOption.settings
//   }
//     dependsOn:[
//       appServicePlan
//       applicationInsights
//     ]
// }]

//function-app.template.bicep

param name string
param location string
param serverFarmId string
param appSettings array

resource functionApp 'Microsoft.Web/sites@2018-11-01' = {
  name: name
  location: location
  kind: 'functionapp'
  properties: {
    enabled: true
    serverFarmId: serverFarmId
    reserved: false
    isXenon: false
    hyperV: false
    scmSiteAlsoStopped: false
    clientAffinityEnabled: true
    clientCertEnabled: false
    hostNamesDisabled: false
    containerSize: 1536
    dailyMemoryTimeQuota: 0
    httpsOnly: false
    redundancyMode: 'None'
    siteConfig: {
      appSettings: appSettings
    }
  }
}

output id string = functionApp.id
output name string = functionApp.name

//root-template.parameters.baseline.json

{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
  "contentVersion": "<IP_ADDRESS>"
}

Additional context
The main thing to look at is the mainAppSettings and how it is being used.
Tried to boil this down to the basics to easily reproduce.  Let me know if a loom or anything else would be helpful.

You can't use the reference function in ARM variable declarations
See here for an explanation

Hi,
Thanks for the response.
If i follow your link I see this:
[image: image.png]
I understand if in the ARM output it is doing that, but wouldn't that be a
bug considering ^^?
Thanks,
Ryan Willmore
On Thu, Mar 18, 2021 at 2:46 AM Steve Webster @.***>
wrote:

You can't use the reference function in ARM variable declarations
See here
https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-variables?tabs=json#define-variable
for an explanation
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Azure/bicep/issues/1917#issuecomment-801742363, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHPZDPNY5ZSQNRGN2QLYH3TEG4UVANCNFSM4ZLNU3FQ
.

You are getting the error because the array functionOptions that you are using for the loop is using the reference() function which is not allowed. We happen to be missing it in our type system because you are using the reference() function directly, which we do not recommend. You can (and should) change your mainAppSetings var to the following and then we will catch the error:
var mainAppSettings = [
  {
    name: 'APPINSIGHTS_INSTRUMENTATIONKEY'
    value: applicationInsights.properties.InstrumentationKey
  }
  {
    name: 'APPLICATIONINSIGHTS_CONNECTION_STRING'
    value: 'InstrumentationKey=${applicationInsights.properties.InstrumentationKey}'
  }
]

This then correctly catches the error:

Is there an alternative you can use for the loop array that does not depend on a runtime property?

Thanks for the response. Here's how I was able to get things working before I opened this issue:

I was hoping to not have to maintain relationships between resources via ordering in their own arrays by grouping the related resources/values together in an array of wrapper objects and then iterating over that array.  Seems as though I'll have to stick with the former though.
Thanks again!

Closing and tracking with #1988


Install all dependencies at once

Fixes #2728
It still needs a test but I'm not 100% sure where I'd put the test for this. I'm thinking an integration test but then we'll need a flag or env var of some kind to say "install dependencies even if they're installed" and "don't install — just log".
Do you have a better idea @JeffreyWay ?

Converting this to a draft. I have some in progress ideas for cleanups / refactoring and I think I can land a very, very small portion of that which would make the approach for this less iffy.

Converting this to a draft. I have some in progress ideas for cleanups / refactoring and I think I can land a very, very small portion of that which would make the approach for this less iffy.


Does it work for the description of an issue?

Does it work for the description of an issue?
For notes/comments it works, what about the description of an issue?

Yes, https://github.com/arkhitech/redmine_mentions/pull/11/files


Project state

Hello,
the ideas you describe in the Readme are just brilliant ! Ember really needs to implement the concepts that Redux brought to the community, but ember-redux forces us, Ember developpers, to embrace the whole Redux way of coding (a LOT of boilerplate code !). Personally, I came to Ember just because of that : focus on app functionality with the least amount of boilerplate code.
Ember-zen is what we need ;-)
What is the project state ? Is it useable ?
Thanks ;-)

Thx for the feedback, it's really motivating!
Not usable, I've just started working on it. Experimenting with API design, trying it out in a pet project.
Do you wanna contribute?

I'd be glad to help, though I don't know how ;-)
Perhaps you should create a RFC and draw some attention from ember-redux authors ? After all, we share the same goal : bring Redux principles to Ember. And there shouldn't be a unique way to achieve this ;-)

I'd be glad to help, though I don't know how ;-)

We'll figure something out! I'll keep you in touch and share my progress, we'll see where it goes.

Perhaps you should create a RFC

Great idea, though I'd like to do some experimenting before formalizing the API: trying things out and seeing what's best rather than settling on a hypothetical solution.

draw some attention from ember-redux authors

I don't want to draw too much attention before I have a functioning implementation. Some people might dislike my idea because it's still raw, some may like the idea and make their independent implementation... I don't mind competition, I just want a headstart so that my personal effort is not wasted.

After all, we share the same goal : bring Redux principles to Ember

Actually, there's much more similarity with mobx-state-tree than Redux. Ember kinda has MobX built in already, so ember-zen is to Ember what mobx-state-tree is to MobX.
Actually, mobx-state-tree has much more to offer, e. g. static types, ember-zen isn't going to offer that. But core principles are the same. When I watched the official talk on mobx-state-tree, I was astonished how similar my ember-zen ideas are to theirs. Though implementation details are totally different, goals and values are the same.

Thanks for those clarifications !
I had heard of MobX but not specifically mobx-state-tree... Indeed its concept looks so close to yours !
Feel free to me keep in touch of the development of ember-zen ;-)

What I would like to discus is ways of mitigating the loss of Ember Data. ED has a lot of good stuff: network layer; serialization layer; querying; optional background fetches; dirty states with rollbacks and shadowing; relationships with auto bookkeeping, foreign key configuration, inverses, polymorphism; transforms...
Going Redux/Zen means losing all those conveniences. There of course are unopinionated libraries that can fill some of the gaps, but it means lots of glue code and no integrated experience.
How can we address that?

When searching about ember and redux, some time ago I stumbled upon this addon.

Ok, so here are some thoughts.

In order to update the store, you run the dispatch method on the zen service with the following arguments:

node that you would like to update, or path to it (in which case the node must be a (sub)property on the service)
message, will be used in logs, should describe what you're doing shortly and meaningfully
a callback, inside which you're allowed to mutate the node or its child nodes

There are convenience methods:

dispatchAction: instead of the callback, you pass an action name. Action is a method on the node, similar to component actions. Uses action name as message.
dispatchSet: similar to Ember.set, you pass a key and a value, the service assigns the value to the key on the node.
dispatchSetProperties: similar to Ember.setProperties, you pass a hash of key-value pairs.

There should be corresponding template helpers. My prototype works like this:

{{action (dispatch-action) node actionName arg1 arg2}}
{{action (dispatch-set) node message key value}}
{{action (dispatch-set-properties) node message hash}}

There's also a zen.dispatchPromise method. It is a Zen equivalent of Ember.PromiseProxyMixin. You give it a name and a callback that should return a promise. The method will set the properties ${name}IsPending, ${name}IsFulfilled, ${name}IsSettled, ${name}IsRejected, ${name}Response and ${name}Error on the node.

All of those dispatch* methods are also available on nodes.

Problems with the above:

Sometimes you want to pass a message with dispatch-action. Sometimes you don't want to pass a message with dispatch-set. Making the message a required param is bulky. Making a message optional is tricky (what would the template action look like?).

A very common use case is to group multiple dispatches in a single method. The problem is that you can't call a method from a template. And if you make the method an action on a node, then you can call it, but it will also be logged by Zen. And current implementation first runs the action and then logs the result. This means that whan an action calls more actions, first the child actions will be logged and the parent action will come last, which makes little sense.

dispatchPromise is awesome, but it requires the developer to declare all those attributes on the node by hand, which is tedious. One vector for solving this could be defining them dynamically in node's init, but that means more magic and less clarity. It's called Zen because it should give you sense of full control, not frustration.

Conceptual problems:

Integration with ember-concurrency. I was going to offer some decorators for developers to be able to leverage e-c tasks in Zen nodes. But I've quickly realized this is gonna be problematic.
The problem is that e-c's mission is to remove intermediate "occasional" state, while Zen's mission is to religiously maintain every single bit of state. This is a contradiction. Even though e-c developers are surprisingly open to suggestions, I can hardly imagine e-c delegating its state to Zen.

Same with many other addons and even Ember's own features:

ember-simple-auth. Though here I was able to workaround the issue. My authenticator updates the session node every time it changes, so all other parts of the app read session from the node while e-s-a itself reads from its internal state.

Query params. The problem is that a query param is a property on a controller and there is no DDAU approach to update it. I. e. you can't define an action which would be invoked every time there's an attempt to update a query param.
I've resolved this issue with an observer that dispatches an update from query param on controller to its counterpart in a Zen node. But ran into another issue. As the observer won't trigger unless you consume its property, you have to do it in init. But then the observer isthere is first run with a default value of a QP and then run again with a value from the URL. And there's no Controller.didReceiveQueryParams hook similar to Component.didReceiveAttrs!
I've noticed that QPs are already resolved when controller passes the ball to the template. So I created a trigger helper that calls an action on the controller when rendered. I've called the action didReceiveQueryParams and use it instead of init to trigger the observer.
This is all very complicated, and I struggle to find a way to make it easy to use.

Without a state inspeciton and time-travelling GUI, Zen's usefulness is limited. Creating own GUI is an enormous task.
I wish EmberInspector allowed addons to add custom panels, but I highly doubt that's even theoretically possible.
We could integrate with ReduxDevTools, but I haven't found a guide on how their integration API works, and the API docs are hard to understand. Need help from someone who's faimilar with how ReduxDevTools integrates.

@Moxide So far you're the only one I can discus such matters with. What do you think?

Idea: allow node attributes to be aliases. This should resolve the problem with query params, ember-simple-auth and maybe ember-concurrency.
But it would require the developer to wrap changes of aliased properties in actions, e. g.:
// app/pods/index/controller.js

export Ember.Controller.extend({
  queryParams: ['sort'],
  sort: 'price:asc',

  actions: {
    changeSorting (field, order) {
      const sort = `${field}:${order}`

      this
        .get('zen')
        .dispatch('state.pods.index', () => {
          this.setProperties({sort})
        })
    },
  },
})

// app/pods/index/node.js

export Node.extend({
  indexController: Ember.inject.controller('index'),

  attrNames: ['sort'],
  sort: Ember.computed.alias('indexController.sort'),
})


Transition entrance ignores z-index

🐛 Bug Report
It seems like entrance animations with the useTransition hook ignores z-indexes.
To Reproduce
Add a fade in/out transition to an element with a z-index.
Expected behavior
The z-index value should be respected during the entrance and exit animations. But it seems to be ignored during the fade in (entrance). Once it's fully faded in, then it's respected.
Link to repro
https://codesandbox.io/s/react-spring-z-index-67gd9
Environment

react-spring v9.0.0-beta.34 (also tested on v8.0.27)
react v16.12.0

I'm just getting started with react-spring so it's quite possible I'm just missing something obvious here.

Was able to reproduce without react-spring. Seems it's just an oddity with z-index context stacking that I wasn't aware of. Closing!


Any Progress

Hi, did you manage to get this working? Am also looking for a MAUI intercom binding so any feedback/tips would be great! thank you

No, I haven't had time to get this to work yet.

ah ok. thanks for letting me know. Do you know how much work would be required? Am happy to help although I've never created a native binding for xamarin or MAUI


Automatically set relation when creating with BelongsTo fieldtype

From now on, whenever you create a new related record using the 'Create & Link Item' button on the BelongsTo fieldtype, the relation will automatically be set on that new record.
Closes #112.
Video
https://www.loom.com/share/757e6330b1274ff8a492169048dbcd0e

@duncanmcclean It would be really cool if this was the case with the HasMany field as well!

@duncanmcclean It would be really cool if this was the case with the HasMany field as well!

I thought that would have already been the case. Feel free to open a feature request if it's not.


Update documentation

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #38   +/-   ##
======================================
  Coverage    7.16%   7.16%
======================================
  Files          42      42
  Lines         544     544
  Branches       47      47
======================================
  Hits           39      39
  Misses        462     462
  Partials       43      43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5536913...230d7da. Read the comment docs.


Bump minor version due to LRO changes

I really should've bumped the minor version in my previous pull request.

Ah, can you cancel/unpublish the publish job started by the previous PR?

Yeah. I'll unpublish it.

Unpublished.


Zoom Web Client Override Chrome extension

Adds the Zoom Web Client Override Chrome extension for Chrome OS devices.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


build(client-tree): generate legacy API report

tree has no direct /legacy exports but does provide SharedTree to fluid-framework.
Setup a non-production legacy "roll up" file. Generate legacy API report and perform linting like packages with /legacy but using the faux "roll ups".
Additionally remove api-extractor tsconfig override that no longer appears to be required.

I'm not sure I understand the motivation for this. If tree doesn't have any legacy exports (by definition, since it's new as of 2.0), why do we want to add a legacy report for it? Or is the idea that it will be removed once we reclaim the @alpha tag?

I'm not sure I understand the motivation for this. If tree doesn't have any legacy exports (by definition, since it's new as of 2.0), why do we want to add a legacy report for it? Or is the idea that it will be removed once we reclaim the @alpha tag?

I thought I understood, but think I misinterpreted fluid-framework use. I think now the solution would be to retag SharedTree as @internal. @CraigMacomber, any reason not to? Here are all known relevant parts:
https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/src/treeFactory.ts line 56:
/**
 * SharedTree is a hierarchical data structure for collaboratively editing strongly typed JSON-like trees
 * of objects, arrays, and other data types.
 * @alpha
 */
export const SharedTree = configuredSharedTree({});

https://github.com/microsoft/FluidFramework/blob/main/packages/framework/fluid-framework/src/index.ts line 74:
import { SharedTree as OriginalSharedTree } from "@fluidframework/tree/internal";

/**
 * A hierarchical data structure for collaboratively editing strongly typed JSON-like trees
 * of objects, arrays, and other data types.
 * @privateRemarks
 * Here we reexport SharedTree, but with the `@alpha` types (`ISharedObjectKind`) removed, just keeping the `SharedObjectKind`.
 * Doing this requires creating this new typed export rather than relying on a reexport directly from the tree package.
 * The tree package itself does not do this because it's API needs to be usable from the encapsulated API which requires `ISharedObjectKind`.
 * This package however is not intended for use by users of the encapsulated API, and therefor it can discard that interface.
 * @public
 */
export const SharedTree: SharedObjectKind<ITree> = OriginalSharedTree;

Better change :) #21647


install ssdcaffe error

i  install ssdcaffe ,but carried out command   roslaunch cv_tracker ssd.launch   prompt the following error
ERROR: cannot launch node of type [cv_tracker/ssd_unc]: can't locate node [ssd_unc] in package [cv_tracker]

You have to locate "ssdcaffe" directory in your home directory.
Please check below. https://github.com/CPFL/Autoware/blob/master/ros/src/computing/perception/detection/packages/cv_tracker/nodes/ssd/README.md


is this client still receiving updates?

I am planning to use centrifugo as a service for a new channel layer, adding onto django channels. I would like to know if this project still receives updates so that I can rely on it.
Thanks a lot!

@aryan340 hello, yes - this is still an actual and maintained repo, just no issues and API changes for a long time.

Please share if you will be able to make Centrifugo a channels layer, this would be really interesting.

Sure! There's already a redis channel layer shipped by django, but group sending is slow- there is an active issue regarding that and it is yet to be solved.
As centrifugo scales, it would be a great service for a channel layer. I'll let you know when I start implementing.

@FZambia but there is an issue.
In order to support centrifugo as a service we need server-side subscriptions to effectively subscribe clients from the backend. However, according to the documentation, this feature is only supported by the js client.

any plans on implementing this soon?

No, there are no plans to implement this since Centrifugo has no such API.

sorry for the miscommunication, I get it now.

@aryan340 feel free to reach out in our community channels if you have more questions, as I said integration with Django channels would be super interesting. Though Centrifugo itself was designed to work well with frameworks like Django out of the box - so in general you can use Django with Centrifugo without implementing channel layer (i.e. not using Django Channels at all).

Great! Thanks a lot! I just realized that.
Closing this. 👍


Outdated documentation

The most recent build for Read the Docs was over a year ago.

Read the docs build is going to take some time, I might need to contact @Shizmob to get access to its configuration.

@Shizmob would it be possible to gain access to RTD's documentation so i can bring that up to date?
If not, would it be possible for you to manually trigger a build?

Just added you. 👍

thanks. 👍
Build succeeded successfully, and I can confirm the recent documentation additions are now visible.
At this point the documentation is up-to-date so I will close this ticket now.


complete crate self and super in use stmt

fixed #387

LGTM! The only software engineering bit left is to extract this logic into a separate complete_use_tree_keyword function, so that complete_expr_keyword indeed continues to work for expressions only :)
complete_use_tree_keyword should be explicitelly called in the main completion function in the parent module.

r=me with a separate function extracted
@bors delegate+

@matklad like this?

@gfreezy almost: let's keep the function in the complete_keyword module. See how complete_snippet also defines two completion functions

r=me

bors r+
Sorry, looks like the initial typo in delegate request prevented bors from noticing delegation =/

Thanks!


build: add prettier lint script

Closes #197

Since there are no tests in this repo, shall we simply run the lint script in a new test workflow?


Consider adding heapstring characteristic?

Summary
Thought this was a stackstring fail but it seems to be a heapstring? not sure if this is prevalent enough but feature extraction could be nice.
Ref: 0d37ad7dcfd65456d7079793b2fe3f737ceccfbecc88e69f6528d1d3922b0b88@40B4EA
.text:000000000040B4E5                 mov     edi, offset ssl_x ; filename
.text:000000000040B4EA                 mov     cs:ssl_x, 2Fh ; '/'
.text:000000000040B4F1                 mov     cs:ssl_x+1, 75h ; 'u'
.text:000000000040B4F8                 mov     cs:ssl_x+2, 73h ; 's'
.text:000000000040B4FF                 mov     cs:ssl_x+3, 72h ; 'r'
.text:000000000040B506                 mov     cs:ssl_x+4, 2Fh ; '/'
.text:000000000040B50D                 mov     cs:ssl_x+5, 73h ; 's'
.text:000000000040B514                 mov     cs:ssl_x+6, 68h ; 'h'
.text:000000000040B51B                 mov     cs:ssl_x+7, 61h ; 'a'
.text:000000000040B522                 mov     cs:ssl_x+8, 72h ; 'r'
.text:000000000040B529                 mov     cs:ssl_x+9, 65h ; 'e'

nice catch - I wonder if we should consider rebranding characteristic: stack string as something like characteristic: dynamic string or characteristic: obfuscated string:
pros:

cover more cases, like this, or .NET obfuscated strings

cons:

overloading the meaning may cause confusion (potentially not specific enough)
rules must be updated

import floss


fix: Teleporting max and lower amounts dont work

PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #8614
[x] Closes #8733

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI;

https://github.com/kodadot/nft-gallery/assets/44554284/62eb0d3d-51a0-44ae-ab63-e6d09510ba8b
https://github.com/kodadot/nft-gallery/assets/44554284/e21ce272-dbc2-4583-87de-e5c7549209a8
Copilot Summary
copilot:summary
copilot:poem

@hassnian
#8740 changes quite a bit in teleport, buffer fee among others
i think this PR is redundant already

@daiagi can you link https://github.com/kodadot/nft-gallery/issues/8614 to your pr , so also that one get's closed


Document setup

Hi,
I’m looking for a game-agnostic JS lobby server component, so this looks good. I’m missing a bit of information, though, e.g. how the components interact, what APIs are provided, and maybe a link to a running application using it. Also, I see mentions of Chrome – is this cross-browser or Chrome only?
Thanks,
Joachim

Seems the owner didn't read this.

I realize this is quite late, but the latest version of this library is not at all Chrome specific as the peer connections use WebRTC DataChannels which can connect between Chrome, Firefox and Safari.

This might be helpful for WebRTC DataChannels: https://github.com/blockspacer/webrtc-datachannels


admin rpc server.

linked accounts w/ rpc api.
other stuff.

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Codecov Report

Merging #22 (a00067e) into master (d7b79c1) will increase coverage by 0.39%.
The diff coverage is 86.40%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   84.77%   85.17%   +0.39%
==========================================
  Files         162      166       +4
  Lines        5459     5707     +248
==========================================
+ Hits         4628     4861     +233
- Misses        514      516       +2
- Partials      317      330      +13

Impacted Files
Coverage Δ

config/defaults.go
100.00% <ø> (ø)

config/signup.go
100.00% <ø> (ø)

core/audit/account.go
100.00% <ø> (ø)

core/validate/recaptcha.go
81.25% <ø> (ø)

core/webhooks/request.go
50.00% <ø> (ø)

hosts/rest/request.go
80.73% <ø> (ø)

hosts/rest/router.go
77.50% <ø> (ø)

hosts/rpc/middleware.go
59.09% <ø> (ø)

hosts/rpc/request.go
55.93% <ø> (ø)

models/auditlog/auditlog.go
100.00% <ø> (ø)

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b79c1...a00067e. Read the comment docs.


Feat/code analysis

Seems like the frontend analysis isn't working properly, but I want to see if merging to master will fix this

Coverage remained the same at 6.527% when pulling af152df04ffaf2ce15cf1353d7bf008a8bbb3b79 on feat/code-analysis into 36ffb665c061b284d95727ea554e9d9a15ae68a6 on master.

 Task 13: Add Code Coverage and Analysis to Pipeline


JSqlParser api keyword setting whitelist

How to set a whitelist for keywords

Greetings,
Keywords are statically defined as Tokens within the Grammar and there is no support for white-listening certain keywords.

Closed, since no further questions asked.


odb: typemap dbTechLayerCutSpacingTableDefRule::LOOKUP_STRATEGY

Signed-off-by: osamahammad21<EMAIL_ADDRESS>

@arlpetergadfort is this the API you want?

I think. I won't have a chance to check if I can get the correct value from the table, but it will make it easier to test


[MPG][.Net] Unexpected diff for MgmtReferenceTypes test project

Planning to remove the logic of MgmtReferenceType in generator.
Then add the missing attributes, inherit types in the custom code.


Enable the stats stub page

This turns on the stats stub page in NGINX.
To test locally:

docker stop via3_nginx-proxy_1; docker rm via3_nginx-proxy_1; make services;
Go to: http://localhost:9083/_stats
You should see something like:

Active connections: 1
server accepts handled requests
 2 2 7
Reading: 0 Writing: 1 Waiting: 0

Ok, after a chat with @robertknight there are more concerns about the maintainability of the password than there are about people seeing our NGINX stats. So we're just going to scrap the protection entirely. This also gets me closer to finding out if this works. We can come back and harden it once we have a known good version.
Also as we have /_status end-points on other products it's probably good to not get confused by giving this a similar name, so we're going to move this to '/_stats'

Ok, this "works" but is quite funny in QA, as the results are cached by Cloudflare, making them totally useless from outside of EB. As we only need it to work inside.


NonNullable should return {}

TypeScript Version:  3.7.x-dev.201xxxxx

Search Terms: NonNullable NonNullable<unknown> NonNullable<any>
Rationale
The definition of NonNullable is "Exclude null and undefined from T". It does this, literally, but I think it should also exclude null and undefined from any and unknown, which in this case would be {}, since all types but null and undefined are assignable to {}.
Proposal type
type NonNullable<T> = unknown extends T ? {} : T extends null | undefined ? never : T;

Demo:
type Test = NonNullable<unknown>; // {}
type Test2 = NonNullable<any>; // {}
type Test3 = NonNullable<string | undefined>; // string

Problem Code
type Test = NonNullable<unknown>;

Expected behavior: should evaluate to {}
Actual behavior: evaluates to unknown
Playground Link
Related Issues:  n/a

This would be a fairly disruptive breaking change and there isn't any practical upside demonstrated here.


build: Generate SBOM during image release

This reverts commit b7cd73e8201358a95104bad5d50b50391e8f6401.
SBOM was a focus of some of the problems around the upgrade to docker
buildx v0.10 which introduces various build failures across the Cilium
CI. It was reverted to try to get CI back in a stable state. This was
unsuccessful because the root cause was not related to these workflow
changes, rather these steps add a downstream consumer of the docker
images and the docker image format changed. While reverting these steps
did prevent them from breaking CI, there were other parts of CI that
also still broke due to the image format change. Given that these CI
steps were running successfully for the better part of the last week
already and they weren't the root cause of the recent CI instability, I
think it makes sense to restore this feature into CI.
Reverts: https://github.com/cilium/cilium/pull/23204

This failed with the image sha not being passed to the signing step:
https://github.com/cilium/cilium/actions/runs/3971027337/jobs/6807456125#step:16:19
Run cosign sign quay.io/cilium/docker-plugin-ci@
  cosign sign quay.io/cilium/docker-plugin-ci@
  cosign sign quay.io/cilium/docker-plugin-ci@
  cosign sign quay.io/cilium/docker-plugin-ci@
  shell: /usr/bin/bash -e {0}
  env:
    QUAY_ORGANIZATION: cilium
    QUAY_ORGANIZATION_DEV: cilium
    MSYS: winsymlinks:nativestrict
    COSIGN_EXPERIMENTAL: true
Generating ephemeral keys...
Retrieving signed certificate...

        Note that there may be personally identifiable information associated with this signed artifact.
        This may include the email address associated with the account with which you authenticate.
        This information will be used for signing this artifact and will be stored in public transparency logs and cannot be removed later.
Successfully verified SCT...
Error: signing [quay.io/cilium/docker-plugin-ci@]: parsing reference: could not parse reference: quay.io/cilium/docker-plugin-ci@
main.go:6[2](https://github.com/cilium/cilium/actions/runs/3971027337/jobs/6807456125#step:16:2): error during command execution: signing [quay.io/cilium/docker-plugin-ci@]: parsing reference: could not parse reference: quay.io/cilium/docker-plugin-ci@
Error: Process completed with exit code 1.

Merging since this PR was verified with the test commit 1dd46665933175fb4d4a0719e3b4f5e6476cb8d0
COSIGN_EXPERIMENTAL=1 cosign verify --certificate-github-workflow-repository cilium/cilium --certificate-oidc-issuer https://token.actions.githubusercontent.com --attachment sbom  quay.io/cilium/docker-plugin-ci:1dd46665933175fb4d4a0719e3b4f5e6476cb8d0 | jq


Show card colors on cards the same way we show deck colors on homepage

We show a picture of the card on the card page so it's redundant there.
On /cards/ it would look something like this:

/cards/ is very heavy. I think maybe this is more page weight than it brings value.


Add support for specifying a route label for validation routes in the context of router sharding

What would you like to be added:
I would like to be able to set a route label to be used by validation routes in order for them to be exposed on a publicly accessible router.
Why is this needed:
In the context of router sharding I did not manage to make openshift-acme work.
I have multiple routers set up in my OKD 3.11 cluster. Some are accessible from the Internet, others are restricted to specific internal networks. I use route labels to select which route is exposed on which router, hence providing some kind of access control at the route level. My default router is not exposed to the internet, to prevent users from unknowingly exposing their deployments to the outside world.
Contrarily to what is stated in #69 the new ACME v2 implementation does not seem to make validation routes inherit their labels from the route labels. And anyway I'm not sure that's what I would like it to do, since my route might be exposed on a private router.
Ideally, I should be able to set a label for the validation route to be exposed on a public router while the route it validates is exposed on a private router.
Or maybe I missed something?
Thanks a lot for your help !
@tnozicka

Contrarily to what is stated in #69 the new ACME v2 implementation does not seem to make validation routes inherit their labels from the route labels.

Can you make sure you're running the latest code? It should be there:
https://github.com/tnozicka/openshift-acme/blob/63cf912/pkg/controller/route/route.go#L707

And anyway I'm not sure that's what I would like it to do, since my route might be exposed on a private router.

If your route is exposed on private router and not reachable from the internet, what good would signing a certificate for public hostname do for a route exposed only privately?

Ideally, I should be able to set a label for the validation route to be exposed on a public router while the route it validates is exposed on a private router.

Maybe I am not seeing the use case. Would you have a concrete example of what you are trying to achieve?

Contrarily to what is stated in #69 the new ACME v2 implementation does not seem to make validation routes inherit their labels from the route labels.

Can you make sure you're running the latest code? It should be there:
https://github.com/tnozicka/openshift-acme/blob/63cf912/pkg/controller/route/route.go#L707

I completely reinstalled openshift-acme from scratch so I guess so but I'll double check.

And anyway I'm not sure that's what I would like it to do, since my route might be exposed on a private router.

If your route is exposed on private router and not reachable from the internet, what good would signing a certificate for public hostname do for a route exposed only privately?

Ideally, I should be able to set a label for the validation route to be exposed on a public router while the route it validates is exposed on a private router.

Maybe I am not seeing the use case. Would you have a concrete example of what you are trying to achieve?

Sorry if I'm being unclear.
What I'd like to achieve is to be able to provide applications in a restricted context (company intranet, VPN accessible network, etc) with a valid letsencrypt certificate so that users don't need to accept security exceptions or get warnings in their browsers when accessing these applications.
For this, I could also used company generated or purchased certificates but:

They can be expensive
They are not automatically provisioned

Thanks for reaching back to me anyway :)

Hmm, I am not sure if you can split the same domain between different routers.
You'd have to have a public domain even for internal services and have DNS return different IP (the internal router) for request from local network to reach the internal router on the same public domain that is signed by let's encrypt.
Wouldn't using haproxy.router.openshift.io/ip_whitelist be easier?

Yes that complicates things quite a bit. :)
I'm in the process of adding some kind of ACL at the cluster loadbalancer level (native Openshift HAProxy) to see if I can catch the HTTP-01 challenges (with the /.well-known/acme-challenge bit at this level and route them to the router exposing the challenge routes.
Otherwise a solution would be to resort to DNS-01 challenge but that's not supported yet by openshift-acme as I understood and I'm not even sure our internal DNS management service exposes a compatible API to process that kind of requests either...

Would using haproxy.router.openshift.io/ip_whitelist be easier?

Did not manage to make this work :/


Manually-created Artifacts >90% Ready for Review

Unfortunately, I've run out of time and haven't yet been able to address all of the feedback on my VnV Plan. I will continue to do so tomorrow. However, I wanted to submit my work thus far as promised.
I've switched to working on the bmBndngNoFunctions branch, where I have posted the:

SRS
VnV Plan
Reflection
Program Solution Prototype
Drasil-encoded SRS and 'stable' documentation

Thank you @balacij.  I'll review soon.


All WSL commands hang (including wsl --shutdown) but WSL is constantly using 30-40% CPU #8529 - No action from Microsoft for over a year

Windows Version
Microsoft Windows [Version 10.0.22621.160]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps
This mostly seems to be happening when the device wakes from sleep - after a system restart, I can access the WSL distro as expected

Start a WSL distro (Ubuntu 20.04)
See it hang
Try to do a wsl --shutdown
See that hang as well
Google for a solution
Notice the bug report #8529
Add a comment in the report about also being affected by exactly the same issue, not being able to use the various workarounds suggested by elevating to local admin due to the company (10.000+ employees) policies

Expected Behavior
Microsoft to confirm the bug being reproduced, to be fixed and subsequently released to the public
Actual Behavior
Microsoft doesn't respond or fix the issue despite another 100+ people interacting with the bug report for the last 13+ months.
Diagnostic Logs
No response

Thank you for reporting this @flundstrom2. Unfortunately we have not been able to reproduce the issue.
Do you have repro instructions or logs ?
/logs

See #8529 for all information required. Please keep the progress of the work in that ticket. I've copied a log packet from one of the 100 authors here:
WslLogs-2023-07-27_15-38-22.zip

Looks like some folks are able to reproduce the issue. ref. https://github.com/microsoft/WSL/issues/8529#issuecomment-1685262617. The same applies to me.

It happens not only after hibernation, but after hibernation you get it 100%


remove types package

fixes https://github.com/edgedb/edgedb-go/issues/57
fixes https://github.com/edgedb/edgedb-go/issues/25

Based on https://github.com/edgedb/edgedb-go/pull/62. WIP until upstream branch is merged.

Based on https://github.com/edgedb/edgedb-go/pull/62. WIP until upstream branch is merged.


Debugger not working for bare mips target.

Describe the bug
In ghidra 10, I haven't been able to successfully use the debugger meaningfully while targeting a raw MIPS CPU (PlayStation 1)
To Reproduce

Download a self-contained version of PCSX-Redux.
In ghidra, load openbios.elf that's provided with the Windows version of PCSX-Redux.
In PCSX-Redux, go to Emulator->Settings, Disable the Dynarec CPU, and activate the Debugger, as well as the GDB server. Set the "BIOS" image file to the corresponding openbios.bin from the same folder you got openbios.elf, and proceed to hard reset the emulator:

Use ghidra's debugger tool to connect to gdb-over-gdap, and the binary /usr/bin/gdb-multiarch (often present in many Linux distributions).
In the Debugger's "Interpreter" window, type target remote localhost:3333 to connect to the gdb server.
--> Only "step in" works. No breakpoint can be placed, registers view won't work.

Expected behavior
We should be able to see registers, place breakpoints, and trace through code generally.
Screenshots
Here, you can see that, despite placing a breakpoint at bfc00164, no breakpoint is listed on the left "Objects" panel. You can also see that no register is being listed in the right "Registers" panel.

Environment (please complete the following information):

OS: Ubuntu 21.04
Java Version: 15.0.3
Ghidra Version: 10.0
Ghidra Origin: official ghidra website

Additional context
PCSX-Redux has a special option that can dump the gdb protocol in the logs. It's clearly visible there that ghidra isn't even trying to set any sort of breakpoint command. On the other hand, registers are clearly being pulled from the emulator to gdb/ghidra. There is also a window that lists the available breakpoints set by gdb, and none were set.

There are some warning / errors in ghidra, but I have no clue whatsoever what they mean or how they came to be, as it's fairly opaque in its interaction with gdb here.
Note that I am the author of PCSX-Redux, and I can make any sort of change I want to the gdb server in order to help ghidra work it out. It has been reported to me that IDA is perfectly able to connect to it and will happily trace / place breakpoints, and gdb-multiarch itself is perfectly happy to drive it too.

from release notes
Debugging user-mode Windows applications on x64 hosts via dbgeng.dll/WinDbg (including 32-bit x86 applications via WoW64)
Debugging user-mode Linux applications on amd64/x86_64 hosts via GDB (including 32-bit i686/x86 applications)

from release notes
Debugging user-mode Windows applications on x64 hosts via dbgeng.dll/WinDbg (including 32-bit x86 applications via WoW64)
Debugging user-mode Linux applications on amd64/x86_64 hosts via GDB (including 32-bit i686/x86 applications)

Except this seems to be working with Game Boy Advance using bare-ARM at the moment? https://wrongbaud.github.io/posts/ghidra-debugger/
This doesn't seem very consistent overall.

Would it be linked to https://github.com/NationalSecurityAgency/ghidra/issues/3071 ?

from release notes
Debugging user-mode Windows applications on x64 hosts via dbgeng.dll/WinDbg (including 32-bit x86 applications via WoW64)
Debugging user-mode Linux applications on amd64/x86_64 hosts via GDB (including 32-bit i686/x86 applications)

Except this seems to be working with Game Boy Advance using bare-ARM at the moment? https://wrongbaud.github.io/posts/ghidra-debugger/
This doesn't seem very consistent overall.

LOL  - if you're expecting consistency from gdb, you need to spend more time looking at its internals!   We're working toward presenting a consistent interface to the user, but honestly gdb is less an API than a general set of guidelines that each project may or may not choose to follow.  As the author of PCSX-Redux, am sure you've had some exposure to this.
Also, per @mumbel's comment, for the moment we're really only trying to support local user-mode Linux and Windows applications.  That said, if you're willing to work with us, we'd like to take a stab at fixing whatever issues you're hitting up against.
So, first off, #3071, yes.  Also, #3161, #3153, #3102, #3074, #2974, #2908, #2859, and the entire Discussion entitled "Connect to luma3ds..." are probably relevant.  Sorry, a lot of reading.
Might help us first, though, to diagnose your specific problem.  So, judging from the screenshots you sent, the trace is not active.  All of the window except the Objects view and the Interpreter are driven by the trace.  So, if the trace isn't working, you'll see mostly empty windows.  As mentioned in some of the other posts, e.g. #3161 and #3071, and as you correctly surmised, the typical root cause for the trace not working is lack of support for "info proc mappings".  Does this work from the Interpreter for you?  If not, you'll need to modify the define_info_proc_mappings script and run it from the Interpreter.  (Yes, this is a crappy solution - we're working on it.)
Am a bit surprised that you're not seeing the breakpoints you set in the Objects tree.  Try selecting the root of the tree and hitting "Refresh".  It may be that the requests are timing out and leaving you with empty nodes, a problem we've seen with slower connections.
I realize @wrongbaud's post probably set your expectations a bit high.  He deserves some serious credit for the time he put into that blog entry.  He worked through some very rough bits with almost nothing to go on int terms of documentation.
Keep us posted, and let's see what we can do!
Best,
D

Oh, hey, just realized something else - you set the breakpoint on the static listing, yes?   That breakpoint is a proper gdb logical breakpoint in the sense that it’s set and stored with the program, but the breakpoint only gets set on the target when the static image is mapped to memory.  This is consistent with the other problems you are seeing, i.e. caused by the lack of a trace.  Try setting the breakpoint in the Interpreter window - my guess is it will appear in the Objects view.  If so, we can concentrate on getting the trace running.  With luck, the breakpoint issue will resolve with it.

from release notes
Debugging user-mode Windows applications on x64 hosts via dbgeng.dll/WinDbg (including 32-bit x86 applications via WoW64)
Debugging user-mode Linux applications on amd64/x86_64 hosts via GDB (including 32-bit i686/x86 applications)

Except this seems to be working with Game Boy Advance using bare-ARM at the moment? https://wrongbaud.github.io/posts/ghidra-debugger/
This doesn't seem very consistent overall.

Hey guys, just wanted to clarify a few things about that post.
There were major inconsistencies across GDB versions and emulator versions, meaning that only subsets of certain features would work based on which combination of these two things I was using.  For example - some versions of of GDB would provide register information and not be able to set breakpoints, and other versions would do the opposite. There is a small table at the end of the post under "Extra Information / Notes" that explains this.
Note that I don't think any of these things were Ghidra related - but more a byproduct of the GDB stub that was in use by the emulator itself.

LOL - if you're expecting consistency from gdb, you need to spend more time looking at its internals! We're working toward presenting a consistent interface to the user, but honestly gdb is less an API than a general set of guidelines that each project may or may not choose to follow. As the author of PCSX-Redux, am sure you've had some exposure to this.

This pretty much sums it up :)

Thanks a lot for the pointers, this gives me starting points to look at. I'll keep you updated.


Add Future.Guarded constructor

There has always been some confusion surrounding the fact that the following code:
Future(rej => setInterval(rej, 100, 'hello')).fork(console.log, console.log)

...Will log "hello" to the console continuously. This is especially concerning when wrapping an event-emitter-based API in a Future, because the API might just decide to emit the event multiple times. Now there is emitter.once(), but that doesn't help in cases where one event calls the reject-continuation, and another event calls the resolve-continuation:
Future((rej, res) => {
  emitter.once('error', rej).once('done', res);
})

When the Future above is forked, it could happen that both continuations are called, and this is in the case where the developer took care to use once.

One could argue that this behavior is similar to how plain old callbacks work, but there's a reason callbacks are so often associated with hell.
The Guarded constructor introduced in this pull-request simply "guards" the continuations for you. Meaning no more continuation will be called after the first has. The goal here is to supply this as an alternative so to not make a breaking change. If the alternative turns out to be practical and has no disadvantages I would like to change the standard Future constructor to adopt this new behavior for a 2.0.0 release.
This new behavior does affect performance. The Guarded constructor is twice as slow as the Future constructor (but still 10 times as fast as the Promise constructor). The good news is that internal performance will not be affected. Internal functions don't build on top of the constructor which is exposed to users, but rather a much lighter one which does not have to catch user-land mistakes. So the only time performance will be affected is when the users themselves use the constructor, which I believe is quite rare, and even more rare in hot paths.

[Current coverage][cc-pull] is 100%

Merging [#17][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #17   diff @@
===================================
  Files           1     1
  Lines         444   457    +13
  Methods       131   135     +4
  Messages        0     0
  Branches      123   125     +2
===================================
+ Hits          444   457    +13
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [e79701b...053a37e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Avaq/Fluture/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Avaq/Fluture/compare/e79701b775488f9a64a90d79ec65a5a2bb259377...053a37e689e933dbe6c968fb2487d1bd2b715f4d?src=pr
[cc-pull]: https://codecov.io/gh/Avaq/Fluture/pull/17?src=pr

This seems useful. :)


OpenCL error -13 on Ubuntu 14.04 and beignet

Used current clBLAS as the provided .so leads to many linker errors. darknet_cl compiles now but executing
build/darknet_cl detect cfg/yolo.cfg yolo.weights data/dog.jpg
leads to some warnings and -13:
31 detection
mask_scale: Using default '1.000000'
Beignet: "unable to find good values for local_work_size[i], please provide\n" " local_work_size[] explicitly, you can find good values with\n" " trial-and-error method."
Loading weights from yolo.weights...Done!
im2col_kernels.cl build log:
stringInput.cl:36:18: warning: '/*' within block comment
activation_kernels.cl build log:
stringInput.cl:21:12: warning: double precision constant requires cl_khr_fp64, casting to single precision
opencl execution error, code -13 -13
terminate called after throwing an instance of 'std::runtime_error'
what():  OpenCL error, code: -13
[1]    9856 abort (core dumped)  build/darknet_cl detect cfg/yolo.cfg yolo.weights data/dog.jpg

Hi @OliverUrbann
Error code -13 means CL_MISALIGNED_SUB_BUFFER_OFFSET, means when you create a sub buffer from a GPU buffer, there is limitations on the offset alignment. This is hardware limitations and depending on GPU vendor. Currently I have no good way to resolve this issue as it will increase the complexity for the data layout on memory. Anyway, I only met such problem when using OpenCL running on CPU.
Best Regards!

I tried it on a Atom J1900 with z3700 GPU in an embedded system. We cannot use other GPUs so the OpenCL port would be a great way to execute YOLO on that system. Anyway, thx for the explanation.

@ganyc717  I managed to compile and run darkness_cl on AMD Radeon GPU by adding some memory alignment codes but getting wrong detection result compared with CPU version. I hope you to explain design of CLArray. Can you leave some notes for it? To  my understanding, it seems like making slices of given  large continuous memory block. If we can focus on continuity, how about using SVM(Shared Virtual Memory) from OpenC L2.0?

Hi @mhahn0106
CLArray is a ugly design as I have no idea to random access to the cl_mem buffer in CL 1.2. I am not quite familiar with OpenCL 2.0 new APIs.  Thank you for your idea, I will check the spec and follow your idea later.
Best Regards!

That's great, thx a lot for your efforts.
However:
-- Looking for CL_VERSION_2_1 - not found
-- Looking for CL_VERSION_2_0
-- Looking for CL_VERSION_2_0 - found
-- Found OpenCL: /usr/lib/x86_64-linux-gnu/libOpenCL.so (found version "2.0")
So I have OpenCL 2.0. And get:
gemm.cpp:(.text+0x77f): Nicht definierter Verweis auf clEnqueueSVMMap' gemm.cpp:(.text+0x7c4): Nicht definierter Verweis auf clEnqueueSVMMap'
gemm.cpp:(.text+0x808): Nicht definierter Verweis auf clEnqueueSVMMap' gemm.cpp:(.text+0x9d9): Nicht definierter Verweis auf clEnqueueSVMUnmap'
gemm.cpp:(.text+0x9fd): Nicht definierter Verweis auf clEnqueueSVMUnmap' gemm.cpp:(.text+0xa21): Nicht definierter Verweis auf clEnqueueSVMUnmap'
It's german for undefined reference to. Maybe some libs missing in the make file?

@ganyc717
"CL_MISALIGNED_SUB_BUFFER_OFFSET, means when you create a sub buffer from a GPU buffer, there is limitations on the offset alignment."
Can you explain what this means to me in more detail. What do you mean by limitations of offset alignment. Can you provide a simple example?

@soulslicer
You have a cl_mem buffer, and wanna to create a sub buffer on it, but it does not mean an arbitrary offset is acceptable. You can refer to https://www.khronos.org/registry/OpenCL/sdk/1.1/docs/man/xhtml/clCreateSubBuffer.html

@ganyc717
Thx a lot for your work.
I run branch Master on Win10 with a AMD GPU, and i recieved a error -13.
then，i run on branch: test-enable-shared-virtual-memory, i recieved error -14 in   void fill_gpu(int N, float ALPHA, CLArray X, int INCX)
So what should I do next?

Thx a lot.
Looking forward to your improvement.

i too am getting error -13 has there been a fix yet?
i did get this one to compile, but its an old build
https://github.com/myestro/darknet
`im2col_kernels.cl build log:
/tmp/OCL2394T5.cl:36:18: warning: '/*' within block comment
//*data_col_ptr = data_im_ptr[ii * width + jj];
^
1 warning generated.
opencl execution error, code -13 -13
terminate called after throwing an instance of 'std::runtime_error'
what():  OpenCL error, code: -13
`


No way for a user to up/down vote on questions and answers

It seems that there is no way for a user to up/down vote on questions and answers as the rewardPrivielege() cannot be called in any path to update user's comment_everywhere_Priv, voteDownPriv and voteUpPriv for a new user，even though that the user may have enough reputation.

Hi, I totally forget about this issue. I think I implemented a function to upvote/downvote on questions and answers, no?


fix: region sku consts undefined

这个 PR 实现什么功能/修复什么问题:
修复 sku 依赖的常量没定义
是否需要 backport 到之前的 release 分支:

NONE
/cc @yousong

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0fc7eae). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master    #439   +/-   ##
========================================
  Coverage          ?   7.75%
========================================
  Files             ?     320
  Lines             ?   51133
  Branches          ?       0
========================================
  Hits              ?    3964
  Misses            ?   46796
  Partials          ?     373

Flag
Coverage Δ

#aFlag
7.75% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/skus.go
1.55% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc7eae...9f6398e. Read the comment docs.

/cherrypick release/2.8.0

/approve
/lgtm


Module-level DontTouchAnnotation

Type of issue: feature request
What is the use case for changing the behavior?
Impact: API addition (no impact on existing code)
Development Phase: proposal
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. Stack Overflow, gitter, etc)
I don't think it'll be hard to implement, but it will be extremely useful when we write custom transforms.

I think this makes sense. The reason I haven't yet is I wasn't sure exactly what the semantics should be so I punted on it 😇
Should marking a Module as "don't touch" mean:

Treat all outputs as circuit sinks
Treat all ports as circuit sinks
Perform no optimizations* at all on the Module

*What counts as an optimization?
I think DCE, CSE, and ConstProp are obviously optimizations, but what about ReplaceTruncatingArithmetic (probably) and FlattenRegUpdate (probably not)?

What's the current donttouch scope? I just assumed DCE, CSE, and ConstProp.

Currently, "don't touch" means treat a given signal as a sink of the circuit, thus logic and state elements that feed into the signal will also not be removed, but it provides no guarantee on anything driven by the "don't touched" signal.
If we were only to treat ports of a don't touched module as circuit sinks, that wouldn't prevent internal signals from being optimized. I'm thinking the most natural behavior would to just not optimize anything within the module.
This does leave a follow on question though, what happens if you have a module marked dont touch (so that no optimizations will be run), but it's also not actually used in the overall circuit. Should we still be able to delete the instantiation of the module? This relates to BlackBoxes as well where the current behavior is that the BlackBox instantiation is not deleted even though it is unused. For a BlackBox (and it's instantiation) to be removable by DCE, it has to be marked as optimizable.

My expectation is:

Do not optimize/delete any signals in the modules
Do not optimize/delete any instances and the port connections to the module, whether or nor it is used. I believe, in general, we mark a module "donttouch" as we expect it will be used in the circuit.

I specifically want module-level donttouch due to 2. Otherwise, it'll be very tedious to do 2.


Mac OS update (via brew) does not update to 1.9.0

I think the brew mechanism is not up to date :-(

@marcelloh brew repository has been moved to https://gitea.com/gitea/homebrew-gitea


mtvec's BASE field clarification

The "Machine Trap-Vector Base-Address Register" subsection states that:

the BASE field needs to be (at least) 4 bytes aligned
in direct mode, the pc is set to BASE
in vectored mode, the pc is set to BASE+4*cause

However:
2: isn't the pc set to (BASE << 2) in direct mode
3: and to (BASE << 2)+4*cause in vectored mode
1: and thus 4 byte minimum alignment is always guaranteed?
Maybe I'm just pedantic, but I checked it in hardware to be sure which way it is really implemented.

The spec clearly shows that BASE[XLEN-1:2] is present in the upper XLEN-2 bits of the mtvec register.


Version 1.4.1

Changed

update min ansible version to 2.8
changelog to your own file
travis file has been updated
Documentation has been improved
change var users_host_vars to users_list_host
change var users_group_vars to users_list_group

Added

molecule testing

@FreeMinded Please reviewers


Audit changes needed in 3.2 for job resources

Audit against OPTIONS return of Tower 3.2 and make up any missing fields
for resources job_template, job, workflow and ad_hoc_command.
Signed-off-by: Aaron Tan<EMAIL_ADDRESS>

Coverage increased (+0.02%) to 91.145% when pulling 2cb3141691ccffbb9b973198ad73237380e65e09 on jangsutsr:3_2_job_res_audit into 97f3225f2f0e5e919e6dfa6a6e89b8a55068a048 on ansible:master.


gulp serve - not work with node 12.21

Hi, @waldekmastykarz
i have problem with last tag. Maybe you have a solution.
You have recently updated the version of the image with the node. From 10.22 to 12.21 (commit). With this version the command gulp serve not work. Error:  ReferenceError: primordials is not defined. If i take your image with tag 1.11.0, then everything works as it should.
On the ms docs site they write that the node version should be 10.

The latest docker image is based on SPFx v1.12 which has some known errors. It's recommended to use SPFx v1.11 until SPFx v1.12.1 is released.


Improving typing of xr.Dataset.__getitem__

First, I'd like the thank the xarray dev's for adding type hints to this library, not many libraries have this feature!
That said, the indexing notation of xr.Dataset does not currently play well wit mypy since it returns a Union type. This results in a lot of mypy errors like this:
workflows/fine_res_budget/budget/budgets.py:284: error: Argument 6 to "compute_recoarsened_budget_field" has incompatible type "Union[DataArray, Dataset]"; expected "DataArray"
workflows/fine_res_budget/budget/budgets.py:285: error: Argument 1 to "storage" has incompatible type "Union[DataArray, Dataset]"; expected "DataArray"
workflows/fine_res_budget/budget/budgets.py:286: error: Argument "unresolved_flux" to "compute_recoarsened_budget_field" has incompatible type "Union[DataArray, Dataset]"; expected "DataArray"
workflows/fine_res_budget/budget/budgets.py:287: error: Argument "saturation_adjustment" to "compute_recoarsened_budget_field" has incompatible type "Union[DataArray, Dataset]"; expected "DataArray"

MCVE Code Sample

def func(ds: xr.Dataset):
    pass

dataset: xr.Dataset = ...

# error:
# this line will give type error because mypy doesn't know
# if ds[['a', 'b]] is Dataset or a DataArray
func(ds[['a', 'b']])

Expected Output
Mypy should be able to infer that ds[['a', b']] is a Dataset, and that ds['a'] is a DataArray.
Problem Description
This requires any routine with type hints that consume an output of xr.Dataset.__getitem__ to require a Union[DataArray, Dataset] even if it really intends to  be used with either DataArray or DataArray. Because ds[something] is a ubiquitous syntax,  this behavior accounts for approximately 50% of mypy errors in my xarray heavy code.
Versions
Output of xr.show_versions()
In [1]: import xarray as xr
xr.
In [2]: xr.show_versions()
INSTALLED VERSIONS
commit: None
python: 3.7.7 (default, May  7 2020, 21:25:33)
[GCC 7.3.0]
python-bits: 64
OS: Linux
OS-release: 5.3.0-1020-gcp
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: C.UTF-8
LOCALE: en_US.UTF-8
libhdf5: 1.10.4
libnetcdf: 4.7.3
xarray: 0.15.1
pandas: 1.0.1
numpy: 1.18.1
scipy: 1.4.1
netCDF4: 1.5.3
pydap: None
h5netcdf: 0.8.0
h5py: 2.10.0
Nio: None
zarr: 2.4.0
cftime: 1.1.2
nc_time_axis: 1.2.0
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: None
dask: 2.17.2
distributed: 2.17.0
matplotlib: 3.1.3
cartopy: 0.17.0
seaborn: 0.10.1
numbagg: None
setuptools: 46.4.0.post20200518
pip: 20.0.2
conda: 4.8.3
pytest: 5.4.2
IPython: 7.13.0
sphinx: None

Potential solution
I think we can fix this with typing.overload. I am not too familiar with that librariy, but I think something like the following might work:
from typing import overload

class Dataset
    @overload
    def __getitem__(self, key: Hashable) -> DataArray: ...

     @overload
    def __getitem__(self, key: List[Hashable]) -> "Dataset": ...

     # actual implementation
    def __getitem__

Here is an examle of this:
https://github.com/pydata/xarray/blob/c07160dd2d627a021e58515cbd7753c11fb56d94/xarray/core/weighted.py#L71
the noqa comments may not be necessary any more, depending on the version of flake8/ pyflakes that is used (https://github.com/PyCQA/pyflakes/issues/320)

overload was added in Python 3.5. Is this okay with xarray's backwards compatibility? It would be pretty easy to write a mock overload that does nothing if not.


Pipeline and stages logic

As part of the initial PR, adding the basic logic for building pipelines: Pipeline class, Stage class and @stage decorator, along with auxiliary classes.

Forgot to clarify that the code in this PR won't run in isolation from the rest of the codebase in the initial PR. This is just an attempt to split the PR for easier review. Otherwise it would be painful to merge. Let me know if it's okay.

We should chat about Python 3.10 (maybe at the stand-up / data meeting)
Happy to chat, alternatively can add __future__ imports
I think the order of declarations within the pipeline file needs to be reworked
Changed the order as you suggested
It would be good to add the pre-commit hooks to this repo - saw a few black formatting and trailing whitespaces complaints from VSCode.
Added the hooks. I disable black as most of its features are covered by PyCharm. Happy to run the entire code through black once all the PRs are in. Re whitespaces - I disabled that hook, hope it's okay.

Forgot to clarify that the code in this PR won't run in isolation from the rest of the codebase in the initial PR. This is just an attempt to split the PR for easier review. Otherwise it would be painful to merge. Let me know if it's okay.

I think that's fine, as it'll really help to break down the individual reviews to manageable sizes without incurring a lot of overhead to make each PR work on its own.


In ScrollView the bottom QuickReturn target doesn't disappear

In the ScrollView option, only the top QuickReturn target appears and disappears. The bottom QuickReturn target stays as it is.

The solution to this is to add to add to file ScrollViewQuickReturnAttacher.java in function addTargetView the line:
scrollView.setOnScrollListener(onScrollListener);
and to comment out in ScrollViewScrollTarget.java in the constructor ScrollViewScrollTarget the line-
//scrollView.setOnScrollListener(this);
Then the bottom QuickReturn target appears and disappears.
This is because in upon scrolling onScrollChanged is triggered in ObservableScrollView.java. This way control is passed to CompositeOnScrollListener.java/onScrollChanged which iterates through the top and bottom QuickReturnTarget's and makes them disappear and reappear respectively. Previously, from ObservableScrollView.java controll was being passed directly on ScrollViewScrollTarget.java's onScrollChanged which was being called just once on the top QuickReturnTargetView

fixed. thanks!


Add BasicObject .create_from_style() function

Draw.io allows users to see the style attribute for any shape. This should be an option for parse any style attribute string into its component properties and generate a Draw.pyo BasicObject with those properties.

Implemented.


Script run is terminated: illegal hardware instruction

Describe the bug
Similar to #425 getting the following error:
❯ node script.js
zsh: illegal hardware instruction  node script.js

To Reproduce
Steps to reproduce the behavior:

On Node v14.17.6 install danfojs-node
Read a CSV file
Try to print headers or do any other operation with the data
See the error

Expected behavior
No error but CSV data is read and printed to my terminal.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS Monterey v12.2 (M1)
Node: v14.17.6

Smartphone (please complete the following information):
N/A
Additional context
N/A

Describe the bug
Similar to #425 getting the following error:
❯ node script.js
zsh: illegal hardware instruction  node script.js

To Reproduce
Steps to reproduce the behavior:

On Node v14.17.6 install danfojs-node
Read a CSV file
Try to print headers or do any other operation with the data
See the error

Expected behavior
No error but CSV data is read and printed to my terminal.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS Monterey v12.2 (M1)
Node: v14.17.6

Smartphone (please complete the following information):
N/A
Additional context
N/A

Upgrading to Node v16 and above fixes this issue. I think this is because of Tensorflowjs M1 support.


Perform Spell Check

Perform Spell Check on comments, doc strings and log messages.
Correct grammatical errors in the above mentioned fields

Actual Result: Spellings and grammatical errors have been checked and corrected.
Expected Result: Same as the actual result.
Reproducibility: Can be used in this code furthermore as required.

All right @nlsdfnbch, thanks for describing my errors,
I'll revert those unwanted changes and make a separate PR on it.

I mistakenly didn't realise that I was working on main branch to fix the errors instead of the release branch, in the new PR, it's on release branch.


Do not register irrelevant  operational ports

Hi,
I need not to register some operational ports which are used for inter communication between cluster nodes.
In my case I want to run 5 Riak nodes. While I need just 3 ports for accessing service behind a LB, each node requires many ports (recommended ~2000 in riak docs) to intercommunicate.
Is there any way to define intercommunication ports not to be registered or remove them?
Thanks.

Perhaps setting an environment variable to define ports which are not to be registered.
For example:
docker run --name registrator-etcd --hostname %H \
-v /var/run/docker.sock:/tmp/docker.sock \
--env "REGISTRATOR_EXCLUDE_PORTS=10000,15000:16000" \
gliderlabs/registrator:latest etcd://${COREOS_PRIVATE_IPV4}:4001/services

It would be great if I can define a comma seperated (or anything suitable) list of ports and port ranges as in example REGISTRATOR_EXCLUDE_PORTS=10000,15000:16000
Thanks

You can set the environment variable SERVICE_<PORT>_IGNORE=true to exclude the operational ports.

Thanks @voidengineer. I'll try it.
I have ~2000 ports that I want to ignore. Is something like SERVICE_<PORT_RANGE>_IGNORE=true OK?

2000 ports on a single container? Or 2000 ports across containers ... it
should be fine.
On Mon, Jun 29, 2015 at 3:09 PM, Ali Riza Keles<EMAIL_ADDRESS>wrote:

Thanks @voidengineer https://github.com/voidengineer. I'll try it.
I have ~2000 ports that I want to ignore. Is something like
SERVICE_<PORT_RANGE>_IGNORE=true OK?
—
Reply to this email directly or view it on GitHub
https://github.com/gliderlabs/registrator/issues/198#issuecomment-116824567
.

--
Jeff Lindsay
http://progrium.com

@progrium, in each container I need to open same port range  e.g 11000 - 12999 for  intercommunication between nodes.  SERVICE_<PORT>_IGNORE=true is just for single port. So in this way docker command seems like that:
docker run -d --name my_container \
-p 8087:8087 \                                  # service port
-p 11000-12999:11000-12999  \                   # operational port range
-e SERVICE_11000_IGNORE=true \
-e SERVICE_11001_IGNORE=true \
-e SERVICE_11002_IGNORE=true \
....
....
....
-e SERVICE_12999_IGNORE=true \
alirizakeles/riak

It is more than 2000 lines of code. If I'd be able to use port range, it'd be simple and easy. I mean something like that:
docker run -d --name my_container \
-p 8087:8087 \                                  # service port
-p 11000-12999:11000-12999  \                   # operational port range
-e SERVICE_11000-12999_IGNORE=true \            # ignore port range
alirizakeles/riak

Thanks.

Why are that many ports necessary?
On Mon, Jun 29, 2015 at 11:19 PM, Ali Riza Keles<EMAIL_ADDRESS>wrote:

@progrium https://github.com/progrium, in each container I need to open
same port range e.g 11000 - 12999 for intercommunication between nodes.
SERVICE__IGNORE=true is just for single port. So in this way docker
command seems like that:
docker run -d --name my_container
-p 8087:8087 \                                  # service port
-p 11000-12999:11000-12999  \                   # operational port range
-e SERVICE_11000_IGNORE=true
-e SERVICE_11001_IGNORE=true
-e SERVICE_11002_IGNORE=true
....
....
....
-e SERVICE_12999_IGNORE=true
alirizakeles/riak
It is more than 2000 lines of code. If I'd be able to use port range, it'd
be simple and easy. I mean something like that:
docker run -d --name my_container
-p 8087:8087 \                                  # service port
-p 11000-12999:11000-12999  \                   # operational port range
-e SERVICE_11000-12999_IGNORE=true \            # ignore port range
alirizakeles/riak
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/gliderlabs/registrator/issues/198#issuecomment-116949008
.

--
Jeff Lindsay
http://progrium.com

Riak nodes need that ports:
http://docs.basho.com/riak/latest/ops/advanced/security/#Inter-node-Communication
Every node is a container on different machine of a coreos cluster. I have to forward this traffic from hosts to riak containers.

That's rough. I suppose if Docker supports publishing ranges, Registrator should at least support ignoring ranges.

It takes for a long time (~1 minutes) starting a container with a huge port range. I stared journalctl logs while container was starting and saw that each port was processed separately. After it started, there was a rule per port in iptables. I do not know why Docker inserted a new rule per each port, but a port range rule. It seems weird.
Eventually, it works. I agree with you that Registrator should support ignoring port ranges.

i need exactly same functionality for our own app cluster.
so +1

This will be tracked with this issue: https://github.com/gliderlabs/registrator/issues/183


cluster logging doesnt dynamically update when cluster settings are changed

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

have a host with a custom docker root (rancher wont detect its custom)
enable logging for the cluster
update the cluster to have the correct docker root
logging is still broken

Expected Result:
logger and fluentd should dynamically be updated if there are any cluster changes.

This was seen in v2.1.x and possibly related to the following:
https://github.com/rancher/rancher/issues/21112
https://github.com/rancher/rancher/pull/27585

The variable "fluentd.cluster.dockerRoot " value is hardcoded and needs to make it configurable.

With logging v2 introduced in rancher 2.5, logging configuration was moved to custom resources monitored by an operator.  All changes are monitored and dynamically applied.


Sluggish on Chromium-based browser (when immediately switching to another tab after opening a new tab)

Hi,
I have been experiencing this issue for a long time when using yabai.
The thing is: in Chrome, open a new tab by clicking the "+" button and then immediately click the tab next to it on its left. There is a significant delay to switch to that tab (around 1~2 seconds). Also, similarly, after I open a new tab, I immediately click the "x" button of the tab next to it instead of the tab itself, this tab will be closed after 1~2 seconds.
However, if I stop the yabai service (by running brew services stop yabai), the issue I described above is gone and the smooth is back.
Except for Chrome, I have tried other Chromium-based browsers such as Brave, and all of them have the same issue. I also tried Firefox and Safari but both of them performed very well as normal.
I don't know how to investigate the source of this issue. Please do me a favor. Thank you very much.
yabai version: the latest
macOS: 10.15.3 (the latest)

So this appears to be happening because Chrome sends a ton of window title changed notification, which causes yabai to trigger a status bar update, which is a bit of an expensive operation:
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042
EVENT_HANDLER_WINDOW_TITLE_CHANGED: Google Chrome 5042

After disabling the status bar I could no longer reproduce this issue.

I mostly use Safari. Sometimes I'll use Chrome, but I interact mostly using keyboard shortcuts (for creating, closing and moving between tabs), so I don't really experience this slowdown.

Got it. Thank you.

Think I found a way to solve this issue (ref #376). Please try the latest master.

@koekeishiya Bingo!! It seems this issue is totally solved. I tested using Chrome and other Chromium-based browsers (Brave and Chromium). All of them were very smooth when I tried to reproduce this issue. Not sluggish at all when I open a new tab and immediately try to close a previous tab. Good job!
Thank you so much for your effort and make our life easier. :P


fix: Remove redundant line in .clang-format

Used to be no problem, but after a recent VSCode update, this seems to have been causing errors when asking VSCode to format. No idea why this recently became problematic.

The ci.yml for the clang-format test says:
container: aswf/ci-osl:2022-clang12

I'm not sure why you would get any different results if also using clang12. I, too, have had (minor) differences in the local formatting versus on GHA. I'm not sure why, but it's usually just a couple lines that I can easily fix up by hand to get it to pass on CI.
I think even if we got it to 100% match clang12, say, there would still be the issue of some developers using different versions of clang on their end, so I think we'll always be in the situation where people just have to deal with the occasional difference between their local clang-format and the CI one.
Aside: I didn't realize it was so long since I updated the clang-format test that it's using clang 12. Should I bump it up to a more recent version?

Aside: I didn't realize it was so long since I updated the clang-format test that it's using clang 12. Should I bump it up to a more recent version?

Ah, no strong opinion on that.  If this is a good opportunity to align with versions used by other ASWF projects then maybe? OSL seems to use 14, MaterialX looks like 15? Personally I'll have easy access to both 12 and 15 :)

Ha! That was news to me (as the person who set up the tests) that the clang-format checks for OIIO and OSL were using different versions!
The versions of clang (and llvm, for OSL) that we support is actually a range, and we try to make sure the build CI covers as much of the range as is practical. But we pick a specific one for the clang-format test (because there's no point checking clang-format for several different versions). It makes sense to me that we should periodically update that so that we're always doing clang-format with whatever is the most recent clang version that we are regularly testing.


Help to configure custom screenshot location for Pretty face report

I see the Screenshot location in HTML report always looks for src = \images - instead i want to change this to custom location within my project, can someone help me to achieve this ?

Hi @melvinpradep , the images are placed inside that folder to ensure:

the report is portable (you could zip it up and send it to a friend)
only the content for that explicit test run is stored/shared/loaded

When you take a screenshot and call the embed command, 2 images are made. One image is stored in whatever location you give to save_screenshot, and the other is stored in the /images dir of the report. I usually delete the un-embeded screenshot file and ONLY keep the images which live in the report folder.
The report would become brittle if you moved the images outside the report directory, I do not recommend it. However, if you want to experiment start with the following code block in html.rb
      def embed_image(src, label)
        @report.current_scenario.image << src.split(separator).last
        @report.current_scenario.image_label << label
        @report.current_scenario.image_id << "img_#{@img_id}"
        @img_id += 1
        filename = "#{File.dirname(@path)}#{separator}images"
        FileUtils.cp src, filename
      end


Unable keep toggle columns in result table

Describe the bug
The toggled columns and customizzation of fields in result table, does not kept after logout.
I am forced to customize at each login ...
Expected behavior
The customization of the columns in the results table is kept until a new modification.
Thanks

So the columns are tied to the session so if you logout it nukes the session data. I'd either not logout or change the session lifetime in your .env to something longer. It's in minutes fyi.

@alexjustesen
SESSION_LIFETIME=120 is it in minutes?
Is there a way to have the session duration infinite?
Thank you

To my knowledge there is no way to set it as infinite but you could just put a big number in there

@alexjustesen
is the value in minutes? Right?

Yeah it is

i set
-e SESSION_LIFETIME=525600
it's been a year, let's hope it's enough... :-)

To my knowledge there is no way to set it as infinite but you could just put a big number in there

could the DB be used to save session data? does filament support this?

To my knowledge there is no way to set it as infinite but you could just put a big number in there

could the DB be used to save session data? does filament support this?

already does, session driver default is database

I remember in the movie War Games that to force Joshua to play by himself the number of players had to be set to zero. Does that work with session to make it infinite? :)

Unfortunately no, but you can set it to a year and if you login from time to time it'll reset the time.


Added missing code example in the RM command reference

Added missing code example for command to delete all stopped containers
Fixes #11527
Signed-off-by: Natalie Parker<EMAIL_ADDRESS>

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:nparker94/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

LGTM

LGTM

Thanks!


Can't select an entity on setup

After installing the solution I want to create a new "D CRM EG Configuration" record. But the field "Display grid on entity" does not give any enities to select. I am on the latest Dynamics 365 version. What am I doing wrong? Thanks in advance!
Kr,
Jeroen

I had the same issue with CRM Online; be sure you download and import the latest version <IP_ADDRESS> and you are signed into CRM with admin privileges.

That was it, thanks!


Fix for the relationships for tables in different schemas

Fixes: https://github.com/platformatic/platformatic/issues/453

Some coverage is missing


Console error when navigating in the integrated superset mode

Console error are visible in the console when we show dashboard
How to reproduce the bug

Go to your embedded dashboard
See error in ocnsole

Expected results
No error
Actual results
error on the call of tab_id api
Screenshots

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


The public release of datasets?

Hello, I read in your paper that you plan to release the dataset, but I haven't been able to find it. Has the dataset been made available? Thank you for your work, and I look forward to your response.

Hello, do you have the dataset? I would appreciate it if you could share the dataset with me.

Hello, do you have the dataset? I would appreciate it if you could share the dataset with me.

I’m sorry, but unfortunately, I do not have access to the dataset either.


Design changes: swap label for icons on the notice component

📇 User story
To maintain alignment with Canada.ca on a widely used and high impact component, the decision was made to switch from label only to using icons without labels for the notice type.
✅ Definition of Done / Outcomes
Notice component of all types are updated in Figma to use icons (from GCDS icons) instead of labels
📜 Acceptance criteria
Add here the list of assumed steps that will be needed to complete the task

[ ] Update EN Figma component and poster
[ ] Update FR Figma component and poster
[ ] Update component archive and decision record

📝 More info
https://docs.google.com/document/d/1V-cdbeSFPsyj7qj3fumj3RoK9MKIGJ6psd-KyRXfmYg/edit
. 🚫 Out of scope
Publishing of the Notice component will be done in tandem with the code PR

So work is done but we wont update the Figma poster until dev is done so we have consistency. Though the requirement doc with related decisions can be updated @realdylanzheng

@realdylanzheng Where can we see the updated design?

https://www.figma.com/design/Uq2iUvQPdgYwcQFh0xFzhH/Notice?node-id=23721-2461


Issue when using Committee.teach(X) on a learner initialized without data

Hello,
When trying to implement a cold-start query strategy for my AL application I encoutered a bug with the Committee class.
A minimum example to show this working for an ActiveLearner and not for a Committee is:
import numpy as np
from sklearn.svm import SVC
from modAL.uncertainty import uncertainty_sampling
from modAL.disagreement import vote_entropy_sampling
from modAL.models import ActiveLearner, Committee

# Create data
X = np.array([[0, 0],
              [0, 1],
              [1, 0],
              [1, 1]])

y = np.array([1, 1, 0 ,0])

X_teach = X[:3]
y_teach = y[:3]

X_query = X[3].reshape((-1, 2))
y_query = y[3]

# ActiveLearner
svm = SVC(probability=True)
learner = ActiveLearner(svm, uncertainty_sampling)

learner.teach(X_teach, y_teach)

query_idx, query_inst = learner.query(X_query)

print('Index %d, Coordinates %s' % (query_idx, query_inst))

# Committee
estimators = [SVC(probability=True) for _ in range(20)]
learner_list = [ActiveLearner(estimator, uncertainty_sampling) for estimator in estimators]
committee = Committee(learner_list, vote_entropy_sampling)

committee.teach(X_teach, y_teach)

query_idx, query_inst = committee.query(X_query)

print('Index %d, Coordinates %s' % (query_idx, query_inst))

Gives output:

Index 0, Coordinates [[1 1]]
Traceback (most recent call last):
File "c:/Users/OskarLiew/Documents/Tests/modAL test/modAL_issue.py", line 38, in
query_idx, query_inst = committee.query(X_query)
File "C:\Users\OskarLiew\Documents\Tests\modAL test\env\lib\site-packages\modAL\models\base.py", line 319, in query
query_result = self.query_strategy(self, *query_args, **query_kwargs)
File "C:\Users\OskarLiew\Documents\Tests\modAL test\env\lib\site-packages\modAL\disagreement.py", line 124, in vote_entropy_sampling
disagreement = vote_entropy(committee, X, **disagreement_measure_kwargs)
File "C:\Users\OskarLiew\Documents\Tests\modAL test\env\lib\site-packages\modAL\disagreement.py", line 37, in vote_entropy
p_vote = np.zeros(shape=(X.shape[0], len(committee.classes_)))
TypeError: object of type 'NoneType' has no len()

The problem is that when updating the training data in BaseCommittee.teach() , Committee._set_classes() is run before the models have been trained, which results in a list of trained estimators, but Committee.classes_ is still None.
I could fix this by moving Committee._set_classes() from Committee._add_training_data() to a new function Committee.teach() where it is run after the data has been added and the models trained. ~I will create a pull request soon, so you can look at this~.
Edit: This fix has already been implemented

I saw that this issue was fixed in the source code. In the same way as I did, no less. I have version 0.3.5 of modAL that was installed via pip version 20.2.2 and python version 3.7.
Is it possible to upload this fix to pip?

Hi! Sorry for the issue, I haven't made a new release a long time ago :( I have created the release 0.3.6 with all the fixes since the previous release. It should be available in PyPI now. I'll close the issue, but feel free to open it up if there is something wrong in 0.3.6!

Hello, me again.
Stumbled upon this issue again, but this time with the fit function. The problem is still that committee.classes_ doesn't get initialized unless the committee is itself initialized with data of all classes. This time I didn't find the fix in the code, so I will send a pull request shortly.


Need search feature

So when conducting a search feature introduced? This is very important.

I do not plan introducing it, but you may try and send pull request.

@ahmerafzal1 i would look at opensource OCR and add this to the app your trying to build so then you can search via OCR since the pdf your app is viewing is a bitmap and it wont be simple to build your own search facility.

@1stmetro yeah I know, when you get OCR please share with me. Thanks in advance

I was tempted to play with this one, shouldn't be too difficult to add but its the zoomTo that might be harder to sort although its probably just a case of using the location their code returns and match the location on a zoomto and then draw a circle around the location rather than highlight as it would be easier.
https://github.com/tesseract-ocr/tesseract

Using OCR for such task is madness. Pdfium has methods for getting text from pages

Ah sorry been to busy to investigate pdfium but now you have said that it will point people towards this issue and hopefully aim towards sorting a solution.

pdfium should have this function, the problem is to implement it for android.  I remember the old app "google pdf viewer" which however was based on pdfium and had this function
I did some research and found some libraries that have implemented the search, but I don't know if they work, they should be tested.
It would take someone to test them and maybe fork and keep an updated fork.
Test them and let me know if they work in any way
https://github.com/gulshan98185/AndroidPdfViewer
https://github.com/beeline09/AdvancedPdfView
https://github.com/beeline09/android-support-pdfium
https://github.com/benjinus/android-support-pdfium


fix!: Include SlackMessageSender in SlackMessageEventEdited

Closes #229
This pull request proposes to use SlackMessageSender instead of only SlackUserId in SlackMessageEventEdited struct. This also changes user field to optional and supports bot_id.

[!Warning]
BREAKING CHANGE: SlackMessageEventEdited::user is moved to sender.user and now it is optional.

Thanks, I'm going to merge this and yank the previous version since it is broken.


Gatekeeper addon e2e tests

What this PR does / why we need it

Contains  e2e tests for Gatekeeper addon along with few helper methods. All below mentioned steps are automated.

Step-1 tanzu package install gatekeeper.tce.vmware.com
Step-2  kubectl apply -f  ${TCE-REPO-DIR}addons/packages/gatekeeper/test/e2e/fixtures/constraint-template.yaml/constraint-template.yaml
Step-3 Check required CRDs after applying the Step-2 file.  kubectl get crds | grep -i k8srequiredlabels
Step-4    kubectl apply -f ${TCE-REPO-DIR}addons/packages/gatekeeper/test/e2e/fixtures/constraint.yaml
Step-5  kubectl create ns test  User cannot create a namespace without owner (The actual use case)
Step-6  `` kubectl apply -f ${TCE-REPO-DIR}addons/packages/gatekeeper/test/e2e/fixtures/test-namespace.yaml```
- After applying the Step-6 file , name space should be created as the namespace will be created with owner name.

Which issue(s) this PR fixes

Fixes: # 1061
Describe testing done for PR

Tests done on Standalone cluster using ginkgo and go test
Special notes for your reviewer

N/A
Does this PR introduce a user-facing change?

N/A

:wave: -- hello, we've decided to close stale PRs, but do acknowledge that this is something we may want to get in eventually. We noticed it currently exists in your fork. If you'd like to re-open a PR with updated E2E tests, we'd love to take a look at them!


ReadNext not rendering

I've got multiple posts but ReadNext is still not working. Any advice?

Ah, I got it. Need to add a key within the md file.
readNext: "/url"


CR should be escaped when displaying difference.

When displaying difference, CR(\r) in String should be escaped.
foo_spec.rb:
describe 'foo' do
  it 'bar' do
    expect(["ABC\r\n1234567890"]).to eq ["abc\r\n1234567890"]
  end
end

Run rpsec:
% rspec foo_spec.rb
F

Failures:

  1) foo bar
     Failure/Error: expect(["ABC\r\n1234567890"]).to eq ["abc\r\n1234567890"]

       expected: ["abc\r\n1234567890"]
            got: ["ABC\r\n1234567890"]

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
\n1234567890
\n1234567890

     # ./foo_spec.rb:3:in `block (2 levels) in <top (required)>'

Finished in 0.00843 seconds (files took 0.06066 seconds to load)
1 example, 1 failure

rspec shows "\n1234567890". but it should be "abc\r\n1234567890" and "ABC\r\n1234567890".

Hi, this needs a spec, and personally I'd prefer it be done via regular expression to avoid extra instantiations etc. e.g. gsub(/([\r\n])/, "\/1"))

Superseeded by #378


Check token has expires_in attribute

Related https://github.com/googleapis/google-api-php-client/issues/2217

CLA signed

This check may affect code paths that were previously unaffected by this error, therefore causing a backwards-compatibility issue. I suggest adding an isset before line 574 instead:
if (!isset($this->token['expires_in'])) {
    // if the token does not have an "expires_in", then it's considered expired
    return true;
}

return ($created + ($this->token['expires_in'] - 30)) < time();

@bshaffer, agree with you. Added new changes to PR


Word lookup feature

I have been working on a word lookup feature where the user simply selects a word (or term) they want to find the meaning of and presses a shortcut key to bring up its meaning within the viewer itself.

I have already implemented a test version of which a screenshot of a sample result is attached. Any possibility this feature could be incorporated into pdf.js?

While you may implement something like this in a custom deployment of the PDF.js viewer, I don't think this is something we'd want in the main repo for two reasons. First of all that information isn't present in the PDF file itself, and secondly getting it would thus require looking it up at a remote server (which we have no control over). The point of PDF.js is that all of its JavaScript runs in the browser, without the need for external resources in this way.
Closing as answered.

Feel free to add your project to https://github.com/mozilla/pdf.js/wiki/Gallery-of-user-projects-and-modifications once it's finished though so it can serve as inspiration for other users.

@timvandermeij I have finished the project. How can it be added to the Wiki?

There is an Edit button at the top right of the page. If it does not work, you can also add the link here and we'll add it for you.

This is the my fork of the project https://github.com/samurdhilbk/pdf.js. I haven't done it as a separate project since everything except the word lookup feature is the same as pdf.js.

Thank you! I have updated the page to add your link and remove dead links.


remove Thread.sleep from tests

unsurprisingly, they are flakey :D

done (as far as i had an idea, how)