Fix if no env

If the .env file is not setup the isServerInfo is false here meaning we will not have MoralisProvider setup.
However, QuickStart page is using useMoralis() that results in the following error:

This change removes the dependency from QuickStart. However, that meant not using isInchDex variable that was dependent on it.
It is probably ok quick fix but might need a better long-term fix.
@Y0moo could you please check this more, you have probably way better context than me on this one :)

Thank you @pschoffer! The problem with .env was fixed on the latest version


fix(debug): Removing leftover debugging console.log

:tada: This PR is included in version 1.5.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enable Skill Controller to allow for different adapter types (i.e. Alexa or Google adapters)

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
When hitting a bot through Google or Alexa devices, via their respective adapters from bot.builder.community, you are able to hit the bot itself but not any connected skills. I believe the issue is due to the fact that the _handler in skillController.cs is set to type SkillHandler which in turn only has an assumed adapter for type BotAdapter.
Describe the solution you'd like
Perhaps skillhandler could use a different adapter depending on the channelId of the incoming activity. So if the incoming activity has a channelId of "google" then it uses a GoogleAdapter rather then the default Botadapter. Im not sure how this would work with dependency injection as we would want to avoid expecting multiple adapter types in the skillHandler constructor for bots that dont use other adapters.
Describe alternatives you've considered
I started investigating changes that could be made in the google and alexa adapters so that an SDK change would not be needed but it seems it does make the most sense to make the change on the SDK.
[enhancement]

Thanks @pavolum - we have some discussions on-going surrounding the ability to use multiple adapters together with skills, as well as an affinity issue when using Alexa / Google (which work on a request / response pattern) with a scaled out app service - so the response from a skill won't necessarily hit the same instance that the original request from Alexa / Google came into.

@garypretty Great! Thanks for the update and the tip. Keep me posted on whatever you all conclude. Once we are able to link up multiple adapters to a VA then I will create a sample and documentation in regards to Google/Alexa intergration into VAs with corresponding documentation on best practices (conditional response logic based on provider in .lg files, etc.).

@pavolum We have been looking into this but we are currently not sure if this makes R10.  If we don't get time to address this within R10, as an interim, we think we can have the adapters enable the expectReplies flag on (already used by Google / Alexa due to them always expecting an immediate response). This would essentially wait for the turn to finish and send all messages back through the source adapter. So, whilst you would lose the ability to have interstitial messages (e.g. "please wait a moment while I check that"), this would effectively ensure adapters / skills function together, until R11 when we get a more permanent solution in which does not require expectReplies.
Would that work for you?
cc @carlosscastro FYI

Per conversation with @gabog , this is being removed from R11.

Closing due to inactivity.


unit tests

Due to changes in the project structure, resubmit the previous three tests.

由于长时间未满足条件，暂时关闭 PR


Need to list all shopcarts of a customer

As a User
I need to see all the shopcarts of a particular customer
So that I can see the shopcarts and their items
Details and Assumptions

Each customer will have only one shopcart, so this will return a collection having one item
REST API endpoint: GET /shopcarts/<customer_id>
JSON format of response:

 [
  {
    "customer_id": 123,
    "items": [
    {
      "id": 2,
      "product_id": 17,
      "quantities": 1
    },
    {
      "id": 1,
      "product_id": 24,
      "quantities": 3
    }
  }
]

Acceptance Criteria
Given customer-id
When API is called
Then it should return the collection of shopcarts of a customer (which will be of length 1)

response would look like this:
{
    "customer_id": 123,
    "shopcarts": [
        {
            "items": [
                {
                    "item_id": 17,
                    "quantity": 1
                },
                {
                    "item_id": 24,
                    "quantity": 3
                }
            ]
        }
    ]
}


Delete OData Entities with the SAP Cloud SDK's Virtual Data Model

Tutorial URL: https://developers.sap.com/tutorials/cloudsdk-js-vdm-delete.html
Please specify the step you are referring to Step 3: Test yourself

What is the code are you expecting here !??!

@iMilazzo as for your other tickets, we will take care of it. Thank you for reporting this.

Tutorial has been changed to Text exactly matches with ID.


[ci] DO NOT MERGE and other premerge checks

A few people (mostly me, but still) like to use comments of the form "DO NOT MERGE" and "DO NOT SUBMIT" to indicate that a change should not be merged. This is primarily useful for marking a pending change as a "draft" at code locations that are still unresolved in some manner.
I think it would be useful to have a CI job that looks for this line in added lines and slams the breaks if it finds any. Better yet, it might be useful to have this job do a more general "if this regex was added, or removed, in such and such file, slam the breaks". You could also imagine novel uses, like guarding against variants of printf debugging.
What do folks think of this idea?

@imphil what do you think?

Hm, I did comment a couple days ago, but apparently this comment never got submitted or disappeared... So let's try again.
GitHub has a feature which allows you to mark PRs as draft. This is probably what you're looking for.
If you prefer you can also use textual markers like DO NOT MERGE. I don't see the need to enforce this in CI: it's the job of the committers and reviewers to take care of that and not merge things which clearly are not intended for it.

it's the job of the committers and reviewers to take care of that and not merge things which clearly are not intended for it.

I'm not sure I agree with this, insofar that we should have as many things enforced by the computer as possible. Humans make mistakes, computers generally don't.

That's why the draft functionality exists and prevents merging. How does that not work for you?

Not really, no. I'm interested in marking parts of the change as being incomplete or unresolved, without having to fuss around with keeping the PR description in sync.

I'm not sure we're talking about the same thing. The draft feature, as described in https://github.blog/2019-02-14-introducing-draft-pull-requests/, allows you to mark a whole PR as draft. There's no modification of the description or the commits needed.
A PR is always merged as a whole, so if any change is incomplete or a draft, then the whole PR is in that status.

AFAIK there is also a "WIP" blocker app that blocks when your PR has "WIP" in the title:
https://github.com/wip/app
Maybe that could be useful...

@mcy: Is this still worth tracking? We seem to be using draft PRs happily and I don't think anyone has merged a "DO NOT MERGE" commit in the two years I've been on the project.
Personally, I think it looks like our social conventions (committers are expected to know what they are doing) are working just fine.

@moidx WDYT about this one?


Moved yAxis to separate component

Relates to #337
I imagine there will be conflicts between this and #601, I look forward to the rebase!

:+1:


how can i use this progame in two computer?

I'm trying to broadcast in two computer now.
how can i use this program when i stream?

As far as i know, the program wasn't made for this purpose. (Single PC with League of Legends, League Broadcaster and OBS running).
I did find a turnaround tho for this on a remote production I had to do a few weeks ago by using the "Preview Projector" function of OBS to preview on another screen the game and the League Broadcast overlay, then "Screen Sharing" this screen to the PC that broadcast (with PARSEC for example). It wasn't perfect but for a remote production i made the job. For a Dual PC Stream setup, you could just capture the screen with the preview. (Running OBS on the Gaming PC to have a preview of the overlay, without streaming, and cature this on the second PC and use OBS on this one to stream the result.)


Enhance Deployement Environment Step

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

@codeKraken19 please review.


[1 week] Example textual and video documentation on how to use the system. One for admins, one for every day users.

These videos and documentation will just be used as an experiment for when we do it properly, closer to when the general staff members can start using the system.

1 week is a very generous time frame by the way, it might take me that long to get all the alpha systems covered, but it's unlikely..


0.40.0-rc1

Contains #1911 and #1909.

Current coverage is 65.46% (diff: 100%)

Merging #1912 into develop will increase coverage by 0.01%

@@            develop      #1912   diff @@
==========================================
  Files           698        698
  Lines         49745      49745
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          32560      32568     +8
+ Misses        17185      17177     -8
  Partials          0          0

Powered by Codecov. Last update 8f24802...9e960ff


cannot open CarlaUE4 project with UE4 4.24.3

I downloaded the carla 0.9.9 for windows. The binaries run perfectly, nothing weird happened. But when I want to open the CarlaUE4.uproject under CarlaUE4, it says the CarlaUE4 and Carla are missing or built with a different engine version. That I have to re-build them
I had this problem when trying to build Carla as well, I can build it. But cannot open the UE4 project.
What seems to be wrong?

Same here, couldn't solve the issue, building Carla from source solved the issue for me.

@dingkailv you can't build any version of CARLA with any version of UE4. Each version of CARLA is designed for a specific version of UE4.


⚠ Bofrost.de has degraded performance

In 9fa6ced, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1029 ms

Resolved: Bofrost.de performance has improved in 4c5ada8 after 36 minutes.


More control/options over refreshing the glslCanvas

This PR introduces  refreshing of the canvas when saving a document.
It also gives adds some more options to enable/disable when the document is refreshed.
I'm not sure about adding these files under the out/* folder as I've never really worked with vscode extensions.

@jonathansty Thank you! nice addon


Could Kubegres supports additional volumes with shared PVC?

We have a service that adds cert files to a mount path, how can we mount the same path to Postgres pod using Kubegres.

Hello.
Thank you for your feature suggestion. It is a good idea.
I added it in the backlog of Kubegres. I will use this issue when committing and releasing it.

Hi,
I forgot to mention it earlier, You can specify the field "storageClassName" in your Kubegres YAML and set the name of the storage class of your choice.
Please see an example here:
https://www.kubegres.io/doc/properties-explained.html
Please let me know if that helps?

Closing this issue. Please re-open it if my answer didn't work for you.


Device Tracker not Working correctly on Asus Merlin with Mesh network

Hi,
I am trying to use this custom integration because the officional one crasches my AX88U router with the SSH login issue. I already tried with HTTPS and HTTP and my phones never change from home to not_home status when i disable the wifi. Tried to change the time setting from 180seconds to another value and the phones are always in home status.
Am i doing something wrong in the configurations? Do i need to change any setting in the router?
My system is 1 AX88U main router(asus merlin firmware) and 3 XT8 units.
Can i provide any log to help me out?
Thank you

Did you remove the native integration before configure this one? Can you download integration diagnostic and attach it here?

Sure. I have removed the other tracked devices and only have my phone and the 3 XT8. Even if i disable the phone wifi the "last_activity" still updates the time.
config_entry-asuswrt_custom-09b7328cb26871a38473af3375b6db61.json.txt

This is really strange. I have a AX86U with merlin 388.1 and everything works properly. By the way I just updated to 388.1 a couple of hours ago, so give me a couple of days just to be sure that the issue is not in new firmware.

Now it is working as intended with https. Thank you. I will close the issue,


⚠ ClamAV has degraded performance

In 1995fc3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 102 ms

Resolved: ClamAV performance has improved in 87fe126.


Fixing UnlockMessage, RenewQueueLock and RenewSubscriptionLock operat…

…ions by passing 0 in POST, PUT requesets, to work around the issue of Jersey client not passing Content-Length header for requests with empty body.

Hi @yvgopal, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (viyarr). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


[Cleanup] Dropped old build.yml

@ganeshgore  Need to add the same benchmarks to the task runs so that we have good coverage.
https://github.com/lnis-uofu/SOFA/blob/35628dbefb4172381556ced5276781b7ac824041/SCRIPT/skywater_openfpga_task/k4_N8_reset_softadder_caravel_cc_customhd_12x12/generate_bitstream/config/task_template.conf#L31-L39

Yes I am going to add these benchmark in my task.conf file


Decentralised reputation systems and social networks

Grant Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[x] A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledged the Terms and Conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
[x] The initial PR contains only one commit (squash if needed before submitting your PR).
[x] The grant will only be announced once the first milestone has been accepted.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Noc2  Thank you for your reply.

In socircles, I combined several centrality values to select "famous" people. We will implement community elections in the next milestone, which will be decentralised and secure. In socircles, only 20 users out of 100,000 were selected and the system already works well. That means that on average 5,000 users oversee a famous people, which is safe. But elections need to be secure in combination with reputation to ensure that an attacker without a reputation, cannot attack the election. However at the moment we do not have a reputation. Also to take into account options such as MACI or privacy computing, which I note some teams in the ecology are already working on. Given the above points, I think it would be better to implement it in the next milestone.

TIR is really difficult to compute on-chain. But it is much easier to compute off-chain. Users updating the results to the chain will get a percentage of the user's social currency as a fee.

Thanks for sharing.

Hi @Noc2  thanks for your great effort! As you said, we have plans to provide a client for TIR. But we are not ready yet. For now we are only verifying it on-chain.

@DarkingLee ping.

@alxs Delivery this week.


Record the maximum amount of time spent stepping the engine in each log interval

Example log message:
INFO 12-27 16:44:53 llm_engine.py:676] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 0.0 tokens/s, Max iteration time: 0.219 seconds, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.0%, CPU KV cache usage: 0.0%

and gauge:
gauge_max_step_time_since_log = Gauge(
    "vllm:max_step_time_since_log_s",
    "Longest time to step a batch in seconds.")

@pathorn Nick's idea was to do a rolling accumulator (old * coef + new), on the step time, for each step. This way we capture more data.
Also I think it is enough to measure the _run_workers(_async)? method, because that is the actual model, and we want to know when the batch size gets too big.

I extended VLLM's logging to use a 30 second window for averaging, but it updates the prometheus data every 5 seconds... This way we don't lose data points.
I also changed it to exclude the oldest data point rather than the newest to account for the fencepost when averaging... that way it will be more up to date if we have a slow tick.


New state in production (Colorado) - Update Application and Static Site

Background
The state listing and map displayed on the SimpleReport.gov static site need to be updated to reflect the the changes to Colorado status to "Available." (in production)
Action requested
Updates are needed in the following areas:

Update SVG map on the static site home page
Update the “Where does SimpleReport work” page on the static site (removing from “coming soon” and moving to “live”, or just adding to “coming soon” if brand new.)
Updating the internal “Source of Truth” Google Doc
Updating the live Jurisdictions list in the GitHub repo: https://github.com/CDCgov/prime-simplereport/blob/main/frontend/src/config/constants.ts

Acceptance Criteria
STATIC SITE | MAP
The map image (sr-map.svg) appearing on the SimpleReport.gov home page should display the Colorado in the darker blue color to indicate that is is now "Available." (officially in production)
STATIC SITE | STATE LISTING
The "Where does SimpleReport work" page should now include Colorado in the list of states where SimpleReport is live.
SOURCE OF TRUTH (Internal) | GOOGLE DOC
Update the Google Doc https://docs.google.com/document/d/1U_ksGy8q7x_gihlECNecCr3yNKdwGKFeu2OP-qGxaQo/edit#heading=h.6tlu9zg4isot
GITHUB REPO
Update the liveJurisdictions list in the GitHub repo: https://github.com/CDCgov/prime-simplereport/blob/main/frontend/src/config/constants.ts
Additional context
You can view the current map here: https://www.simplereport.gov/assets/img/sr-map.svg

Migration only, not a new STLT. Ticket no longer needed.


Feat: Removed sql-ts

queries are built manually by the keyv-sql package instead of depending on external packages
Signed-off-by: Jytesh<EMAIL_ADDRESS>Fixes #2, Fixes https://github.com/lukechilds/keyv-sql/issues/26
sql-ts is not compatible with node v10.

I was thinking we can add all even versions from 10 - 15 ( including 15 )

Since we shouldn't drop support for 10 just yet

Aight 12 sounds good.

12, 14 and 15 to be tested then?

yes!

awesome 🎉


rpc+lnd: add new sub RPC server, Router service

In this PR, we implement the full RouterServer as specified by the
newly added sub-service as defined in router.proto. This new sub-server
has its own macaroon state (but overlapping permissions which can be
combined with the current admin.macaroon), and gives users a simplified
interface for a gRPC service that is able to simply send payment.
NOTE: The only new functionality in this PR are the last 3 commits, which show how one can add a new sub-server given the existing scaffolding.
Depends on #2081.

Is this also the venue where we are going to stage #1662?

Abstract this conditional or making the macaroons? Making the macaroons is
something each sub server will need to do. However, the set of perms they
add will likely be diff and also they may eventually create multiple
macaroons.
On Fri, Nov 2, 2018, 4:20 PM Conner Fromknecht<EMAIL_ADDRESS>wrote:

@cfromknecht commented on this pull request.
In lnrpc/routerpc/router_server.go
https://github.com/lightningnetwork/lnd/pull/2083#discussion_r230531911:

if atomic.AddInt32(&s.started, 1) != 1 {

return nil

}

return nil
+}

+// Stop signals any active goroutines for a graceful closure.
+//
+// NOTE: This is part of the lnrpc.SubServer interface.
+func (s *Server) Stop() error {

if atomic.AddInt32(&s.shutdown, 1) != 1 {

return nil

}

close(s.quit)

similar comment here wrt removing quit, started, and stopped
In lnrpc/routerpc/router_server.go
https://github.com/lightningnetwork/lnd/pull/2083#discussion_r230532100:

+// we're unable to create it, then an error will be returned. We also return
+// the set of permissions that we require as a server. At the time of writing
+// of this documentation, this is the same macaroon as as the admin macaroon.
+func New(cfg *Config) (*Server, lnrpc.MacaroonPerms, error) {

// If the path of the router macaroon wasn't generated, then we'll
// assume that it's found at the default network directory.
if cfg.RouterMacPath == "" {

cfg.RouterMacPath = filepath.Join(

	cfg.NetworkDir, DefaultRouterMacFilename,

)

}

// Now that we know the full path of the router macaroon, we can check
// to see if we need to create it or not.
macFilePath := cfg.RouterMacPath
if !fileExists(macFilePath) && cfg.MacService != nil {

would be great if this logic were abstracted in lnrpc, so we don't have
to reimplement it with each new subserver. i imagine all subservers we add
will have to use macaroons anyway
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lightningnetwork/lnd/pull/2083#pullrequestreview-171300542,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA87LkP1-aDsV2UhgtWNxshzj40svupIks5urNNNgaJpZM4X0sir
.

Pushed up a new rebased version, also added a new call to obtain a routing fee quote for a (dest, amt) pair.

General question: where is this requirement coming from?

Part of the sub-server architecture that enables things like managing a cluster of lnd nodes with one primarily sending payments (due to better graph placement and liquidity) and for example a set of other nodes (even may not be fully fledged lnd nodes) which handle on-chain actions. By abstracting behavior at the service level, we gain a greater degree of flexibility and are able to implement things like rolling restarts and also ensure we have service level redundancy.

By abstracting behavior at the service level, we gain a greater degree of flexibility and are able to implement things like rolling restarts and also ensure we have service level redundancy.

Yes, this part I understand. My question was about why it needs to be a 'simplified' interface? Or do you mean with simplified the isolation of several calls in the sub server rather than simplify the calls themselves?

Simplified w.r.t isolation! A side effect of the sub-server system it that it forces us to not just pile new things (like extensive business logic outside of marshaling) into the rpcserver.go file.

Rebased on top of the latest master.

Comments addressed, PTAL @halseth

Latest instance returns fee quotes in msat.

Needs rebase.


Research FAQ bot for discord

Problem
Many questions are repeated by the general public in various discord channels. Why create bespoke answers when we can not do that?
Current State

Member/Prospective member of the community will pose a question to our team. e.g. "Why is the dispute window 7 days?"
Member of community responds with answer.
Repeat without any knowledge of previous interaction

Solution
A robot friend who can take care of this.
It should do the following things:
Upon addition to FAQ:

Monitor discord for mentions of a handle like "@domoarigato".
Clip the conversation around the mention to capture the original question along with permalinks.
File a PR of above contents against an FAQ (To be created) repo.

Upon a repeated question posed by community:

A mention that will tell the bot to post a link to the FAQ into the current channel.

Potential Problems

This isn't an entirely automatic process requiring humans to review generated PRs
Multiple PRs might be filed for same question in several channels

Improvements

Automate answering of questions. This might require Sentiment analysis but we might be able to get away with keyword matching
Provide a format to community member who answer many questions to simplify formatting concerns

https://discordbots.org/bot/441430430403526657


Responsive charts

Hi,
I am having trouble trying to resize charts on window resize:
angular.element($window).bind('resize', function(){
$scope.width = $window.innerWidth;
$log.log('new windows size ' + $scope.width);
var list = dc.chartRegistry.list();
for (var i in list){
var chartS = list[i];
if (typeof chartS.rescale === 'function'){
chartS.width($window.innerWidth);
chartS.rescale();
chartS.redraw();
}
}
});
This seems to be only rescaling the data displayed, but not the axis (both on line chart and range-bar chart).
Is there a proper way to do this?

This looks like it's more properly a dc.js question rather than angular-dc. I'd check the changelog and make sure that you have a recent enough dc.js since these features are fairly new.
https://github.com/dc-js/dc.js/blob/master/Changelog.md
Looks like the changes you need are in beta 15 and beta 19.

Hi,
Indeed, it is resolved by updating to 2.0.0 beta 27
Thank for your quick reply

@aferre how did you do the responsiveness? my svg stays the same...

Hi,
For now (i am doing a POC) i do it dirty style:
angular.element($window).bind('resize', function() {
        $scope.width = $window.innerWidth;
        $log.log('new windows size ' + $scope.width);

        var list = dc.chartRegistry.list();
        for (var i in list) {
            var chartS = list[i];
            if (typeof chartS.rescale === 'function') {
                chartS.width($window.innerWidth);
                chartS.rescale();
                chartS.redraw();
            }
        }
        $scope.$digest();
    });

It seems to do the trick (tere are a few missing pieces like legend resizing for isntance)

hi
you can use:
`
    var list = dc.chartRegistry.list(1);
    //var list = dc.chartRegistry.list( chart group );

`


reduce test stage dependency with ReferenceTests

As @mgautam98 is going to improve this package with AbstractArray{<:Colorant} support ( #13 ) , I'm doing some preparation work now. This one is for the test, and I'll open a PR for CI later.
I'm still resistant to the usage of VisualRegressionTests for two reasons:

Even if it's a test-only dependency, VisualRegressionTests is still very large a dependency with Plots and Gtk.
The reference file can be very fragile because the output depends on how backends (Gtk) draw the figure. The failure in https://travis-ci.org/github/JuliaImages/ImageInpainting.jl/builds/647806320 is one such case. On the other hand, ReferenceTests only depends on image IO backend, which is quite faithful and reliable.

@juliohm Are you okay with this change?

Thank you Jonny for suggesting ReferenceTests.jl again. I'll check the PR
tomorrow morning but I agree that visual regression tested is too complex
and unreliable.
On Thu, Jul 2, 2020, 01:22 Johnny Chen<EMAIL_ADDRESS>wrote:

As @mgautam98 https://github.com/mgautam98 is going to improve this
package with AbstractArray{<:Colorant} support ( #13
https://github.com/JuliaImages/ImageInpainting.jl/issues/13 ) , I'm
doing some preparation work now. This one is for the test, and I'll open a
PR for CI later.
I'm still resistant to the usage of VisualRegressionTests for two reasons:

Even if it's a test-only dependency, VisualRegressionTests is still
very large a dependency with Plots and Gtk.
The reference file can be very fragile because the output depends on
how backends (Gtk) draw the figure. The failure in
https://travis-ci.org/github/JuliaImages/ImageInpainting.jl/builds/647806320
is one such case. On the other hand, ReferenceTests only depends on image
IO backend, which is quite faithful and reliable.

@juliohm https://github.com/juliohm Are you okay with this change?
You can view, comment on, or merge this pull request online at:
https://github.com/JuliaImages/ImageInpainting.jl/pull/14
Commit Summary

reduce test stage dependency with ReferenceTests

File Changes

M Project.toml
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-910a7b3ca0075d545dcec45cb7335ca9
(19)
M test/criminisi.jl
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-9da901d4e1c971ae6b42ee56bd46c661
(16)
D test/data/Blobs.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-0fdb16a597b3c228d969da74f6a4c204
(0)
D test/data/Cross.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-9d3689ab17772c47fbe1bfff3a77ce96
(0)
D test/data/Diagonal.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-04224ecbb684cfc1ee271f32fcbebd0a
(0)
D test/data/LightHouse.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-8b596d9cdd8d529569fddbca5f1add4b
(0)
A test/data/criminisi/Blobs.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-49b7e35074662a0eceff32721f6b2498
(0)
A test/data/criminisi/Cross.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-37e5705bc346d083dbebeb5d5f9620d5
(0)
A test/data/criminisi/Diagonal.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-54853acb7bafb021615781a9d71b659c
(0)
A test/data/criminisi/LightHouse.png
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-dac47da390746b06151c83c93bf4c6d5
(0)
M test/runtests.jl
https://github.com/JuliaImages/ImageInpainting.jl/pull/14/files#diff-fce720c43af3c52c862fd7451c7374b8
(28)

Patch Links:

https://github.com/JuliaImages/ImageInpainting.jl/pull/14.patch
https://github.com/JuliaImages/ImageInpainting.jl/pull/14.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuliaImages/ImageInpainting.jl/pull/14, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZQW3KA5JBNRVKCSMNNBJLRZQDPRANCNFSM4OOP3VQQ
.

It doesn't look good to me that the behavior is platform dependent. I'll investigate how it happens later today.

Please go ahead and merge. The only missing feature of VisualRegressionTests.jl that I find really useful is the GUI that pops up when tests fail. It makes it easy to quickly update test data. However, I agree that the updates occur too often due to other noises related to GTK, etc.

The only missing feature of VisualRegressionTests.jl that I find really useful is the GUI that pops up when tests fail.

Yes, currently it displays images using ImageInTerminal, which sometimes doesn't give a clear view. There's a pending PR in ReferenceTests that renders images using ImageShow: https://github.com/JuliaTesting/ReferenceTests.jl/pull/41.
That PR is pending because some mock tests are needed to detect any possible regressions. I plan to update that PR this month and then I believe you'd be satisfied.

Oh that is really nice. In that case I will try to get rid of VisualRegressionTests.jl in other packages as well in the future.

Did you finish this PR @johnnychen94 ? Please feel free to merge if it is ready. That should indeed help the other PRs being written.

Not yet, the CI error is concerning and I'm not sure what's the issue here. It would be great if you can have a look at it since you're more familiar with the algorithm.
I'm updating ReferenceTests these days.

Of course, thank you for the heads up. Will try to take a look during the day.

Is it my impression or the Gray.(out) is lowering the resolution of the image?

I think it is just the image size when I plot with heatmap(out) versus visualize the real size with Gray.(out) in Juno, but just wanted to confirm. Apparently the results are making sense on this branch, but for some reason the tests with the Gray images are failing. Should we just save the *.txt of the images instead of converting back to Gray?

Also, is this information relevant? Should we set the number of CPU cores to 1 to get reproducible reference tests?

I just ran into a similar case that reference tests are broken when ColorVectorSpace is imported via ImageCore; part of the reason is the codes are not written generically to handle Array{<:Number} and Array{Gray} consistently.
Will try to fix it when I get some more time.

@johnnychen94 did you succeed in the ReferenceTests.jl side?

Not yet.
Unfortunately, I was quite busy this summer to continue this because of a series of day-to-day seminars. There're some unidentified bugs about its faithfully and my very limited time was spent on adding more test cases
If you have any plans on this package, please do it, I can just rebase on whatever you've done when I finally get here.

Solved in #22


Remove hardcoding of kymata-toolbox directory in submit_gridsearch.sh

@caiw  tried to fix it with
# This gets the directory of the toolbox, assuming that *this file you're reading right now* is in the root directory of
# the toolbox
TOOLBOX_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

but we get this
'/usr/bin/bash: line 1: cd: /var/spool/slurm/job3347806: No such file or directory'

So I put it back to hardcoded. It must be that the SLURM thinks it is in '/var/spool/slurm/job3347806' when it runs...

Fixed by #418


limited functionality on Ubuntu 14.04

Just recently began using this plugin with Hyper 1.0.0 and Hyper 1.0.1, and encountered an error (running Ubuntu 14.04). In particular, a sort of statusline appears (basically, just a lightly colored area at the bottom of the Hyper window), but the appropriate icons fail to display entirely. Based on a cursory look, it doesn't seem like any related issues have been reported.

Mind sharing a screen? ✌

Any errors in the console?

Not as far as I can tell. Only thing I can think of might be interference from some other plug-in. I've included the contents of my hyper.js in case it might be helpful below:
module.exports = {
  config: {
    // default font size in pixels for all tabs
    fontSize: 13,

    // font family with optional fallbacks
    fontFamily: 'Menlo, "DejaVu Sans Mono", "Lucida Console", monospace',

    // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk)
    cursorColor: 'rgba(248,28,229,0.8)',

    // `BEAM` for |, `UNDERLINE` for _, `BLOCK` for █
    cursorShape: 'BLOCK',

    // color of the text
    foregroundColor: '#fff',

    // terminal background color
    backgroundColor: '#000',

    // border color (window, tabs)
    borderColor: '#333',

    // custom css to embed in the main window
    css: '',

    // custom css to embed in the terminal window
    termCSS: '',

    // set to `true` if you're using a Linux set up
    // that doesn't shows native menus
    // default: `false` on Linux, `true` on Windows (ignored on macOS)
    showHamburgerMenu: true,

    // set to `false` to hide the minimize, maximize and close buttons
    // set to `'left'` if you want them on the left, like in Ubuntu
    // default: `true` on windows and Linux (ignored on macOS)
    showWindowControls: '',

    // custom padding (css format, i.e.: `top right bottom left`)
    padding: '12px 14px',

    // the full list. if you're going to provide the full color palette,
    // including the 6 x 6 color cubes and the grayscale map, just provide
    // an array here instead of a color map object
    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
    },

    // the shell to run when spawning a new session (i.e. /usr/local/bin/fish)
    // if left empty, your system's login shell will be used by default
    shell: 'bash',

    // for setting shell arguments (i.e. using interactive shellArgs: ['-i'])
    // by default ['--login'] will be used
    shellArgs: ['--login'],

    // for environment variables
    env: {},

    // set to false for no bell
    bell: 'SOUND',

    // if true, selected text will automatically be copied to the clipboard
    copyOnSelect: false,

    // URL to custom bell
    // bellSoundURL: 'http://example.com/bell.mp3',

    // settings for hyperlinks plugin
    hyperlinks: {
      defaultBrowser: false
    },

    // settings for statusline plugin
    hyperStatusLine: {
      footerTransparent: false
      //dirtyColor: 'pink'
    }

    // for advanced config flags please refer to https://hyper.is/#cfg
  },

  // a list of plugins to fetch and install from npm
  // format: [@org/]project[#version]
  // examples:
  //   `hyperpower`
  //   `@company/project`
  //   `project#1.0.1`
  plugins: [
    "hypercwd",
    "hyperlinks",
    "hyper-blink",
    "hyperterm-paste",
    "hyperterm-cursor",
    "hyper-statusline",
    "hyperterm-bold-tab",
    //"hyper-chesterish", // Chesterish theme
    "hyper-snazzy" // Snazzy theme
  ],
  // in development, you can create a directory under
  // `~/.hyper_plugins/local/` and include it here
  // to load it and avoid it being `npm install`ed
  localPlugins: []
};

Does hypercwd work fine for you? Because it's relying on a similar method to fetch cwd.

Aw, interesting -- hypercwd also appears to be broken...seems this issue is due to some change in Hyper as of 1.0.0

@nhejazi first, please check lsof is installed.
if you run the command from your terminal (not hyper) what's the output?
lsof -p ${pid} | grep cwd | tr -s ' ' | cut -d ' ' -f9-
(replace the ${pid} with your terminal pid)
If it takes a while try this:
lsof -n -p ${pid} | grep cwd | tr -s ' ' | cut -d ' ' -f9-
@henrikdahl I have experienced some issues on MacOS with my plugin that I fixed by adding the -n parameter to lsof command. Sometimes it took around 30secs to get a response from lsof while adding the -n went down to 8ms
my $0.02!
Max

@elmasse, thanks for pointing out lsof (didn't have it installed before). The output of using lsof in the way you specified is an error, which I've included below (note that this is with the use of sudo):
lsof: WARNING: can't stat() ext4 file system /mnt/stateful_partition
      Output information may be incomplete.
lsof: WARNING: can't stat() ext4 file system /usr/share/oem
      Output information may be incomplete.
lsof: WARNING: can't stat() ext4 file system /mnt/stateful_partition/encrypted
      Output information may be incomplete.
lsof: WARNING: can't stat() ext4 file system /home/chronos
      Output information may be incomplete.
lsof: WARNING: can't stat() debugfs file system /run/debugfs_gpu
      Output information may be incomplete.
lsof: WARNING: can't stat() squashfs file system /opt/google/containers/android/rootfs/root
      Output information may be incomplete.
lsof: WARNING: can't stat() squashfs file system /opt/google/containers/android/rootfs/root/vendor
      Output information may be incomplete.
lsof: WARNING: can't stat() squashfs file system /opt/google/containers/arc-downloads-filesystem/mountpoints/container-root
      Output information may be incomplete.
lsof: WARNING: can't stat() squashfs file system /opt/google/containers/arc-removable-media/mountpoints/container-root
      Output information may be incomplete.
lsof: WARNING: can't stat() squashfs file system /opt/google/containers/arc-sdcard/mountpoints/container-root
      Output information may be incomplete.
lsof: WARNING: can't stat() squashfs file system /opt/google/containers/arc-obb-mounter/mountpoints/container-root
      Output information may be incomplete.
lsof: WARNING: can't stat() ecryptfs file system /home/.shadow/bac160ce84f196dada0c0688dd5c6a3d71e3b9e3/mount
      Output information may be incomplete.
lsof: WARNING: can't stat() ecryptfs file system /home/chronos/user
      Output information may be incomplete.
lsof: WARNING: can't stat() ecryptfs file system /home/user/bac160ce84f196dada0c0688dd5c6a3d71e3b9e3
      Output information may be incomplete.
lsof: WARNING: can't stat() ecryptfs file system /home/chronos/u-bac160ce84f196dada0c0688dd5c6a3d71e3b9e3
      Output information may be incomplete.
lsof: WARNING: can't stat() ecryptfs file system /home/root/bac160ce84f196dada0c0688dd5c6a3d71e3b9e3
      Output information may be incomplete.
lsof: WARNING: can't stat() tmpfs file system /run/crw
      Output information may be incomplete.

@henrikdahl, installing lsof restores most functionality to both hypercwd and hyper-statusline, though there are still some remaining issues with the Git status bar. Everything relating to the working directory is fully functional. Does any of this help in isolating what the remaining problem might be?

@elmasse Thanks for pointing that out. I'll look into it 👍
@nhejazi Try to update to latest version of statusline and it should restore the git icons ✌

@henrikdahl Confirming that everything works as expected now. Thanks for the help!


Add focus within ts type definition

This PR adds the missing type definition files for FocusWithin component.

@balazsmatepetro did you figure out the bundling problem?

@balazsmatepetro did you figure out the bundling problem?

I had a look at on it, as I've seen the type definitions are included in the bundle, but it might worth converting the whole component into TypeScript.

I think it's worth converting it to TS. Want to give it a try?

Sure!


Odd javascript formatting

VSCode Version: 1.8.1
OS Version: Windows 10

Steps to Reproduce:
Auto formatting (alt-shift-f)
returnspromise()
.then(()=>{

})

Produces:
returnspromise()
    .then(() => {

    })

Expected:
returnspromise()
.then(()=>{

})

The point is that I'd like to format other parts of the code while my . calls indentation remains the same. How would I go about configuring this? If it's possible

This is the expected formatting. Since indenting method chains like this is the common style for js, we do not have a formatting option for disabling the indent.
I suggest looking to see any extensions offer the type of formatting control you are after.


[Bug] Education Category, summary text box not auto-sizing. Create Button missing

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Cloud (https://rxresu.me)
Current Behavior
When you try to add something in the Education Category, when you paste something into the Summary Box, it does not auto-size and the Create button disappears. You can't scroll in this window

Expected Behavior
The summary box autosizes and you can press the button.
Steps To Reproduce
Go to Education Category
Paste something into the Summary Box
Create button missing.
What browsers are you seeing the problem on?
Chrome
What template are you using?
None
Anything else?
No response

I want to try this issue #2098


Git URLs no longer supported in requires?

Somewhere between versions 2.15.1 and 3.0, rwt stopped supporting (specifically, it appears to flat-out ignore) package specifiers of the form<EMAIL_ADDRESS>in __requires__ lists, though it continues to support them in requirements.txt files.  I see no mention of this change in CHANGES.rst; was it intentional?  If not, could we have the old behavior back?

Here's what changed.

The changelog suggests in 2.16 that #18 changed the meaning of __requires__.

Sorry for the inconvenience.
It was an unintentional limitation to constrain the meaning of __requires__. The intention was actually to expand the meaning of it.
And now it seems we've run up against a fundamental difference in the definition of requirements between pip and pkg_resources.
Best I can understand, pkg_resources expects the __requires__ to be package requirement specifications and not dependency links. Indeed, pkg_resources would fail similarly:
$ cat > script.py
__requires__ = 'https://github.com/jaraco/rwt',
import pkg_resources
$ python script.py
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/requirements.py", line 90, in __init__
    req = REQUIREMENT.parseString(requirement_string)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1617, in parseString
    raise exc
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1607, in parseString
    loc, tokens = self._parse( instring, 0 )
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1379, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 3376, in parseImpl
    loc, exprtokens = e._parse( instring, loc, doActions )
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 1383, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/pyparsing.py", line 3164, in parseImpl
    raise ParseException(instring, loc, self.errmsg, self)
pkg_resources._vendor.pyparsing.ParseException: Expected stringEnd (at char 5), (line:1, col:6)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3015, in __init__
    super(Requirement, self).__init__(requirement_string)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/_vendor/packaging/requirements.py", line 94, in __init__
    requirement_string[e.loc:e.loc + 8]))
pkg_resources.extern.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at "'://githu'"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "script.py", line 2, in <module>
    import pkg_resources
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3161, in <module>
    @_call_aside
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3145, in _call_aside
    f(*args, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3174, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 666, in _build_master
    ws.require(__requires__)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 984, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 826, in resolve
    requirements = list(requirements)[::-1]
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3008, in parse_requirements
    yield Requirement(line)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3017, in __init__
    raise RequirementParseError(str(e))
pkg_resources.RequirementParseError: Invalid requirement, parse error at "'://githu'"

My instinct is the best thing to do here is to retain the constraint (to be consistent with pkg_resources, the defacto standard bearer for __requires__) and for projects that need full URLs to specify dependencies, they should use requirements.txt.
Depending on how well that approach satisfies the use case, or rather to the extent that it doesn't, I'd be open to rwt supporting another variable such as __requirements__ that's explicitly meant to be used for pip-based requirements declarations. Based on this comment, I'd want to be sure to get an endorsement from @dstufft (and probably others) before creating a new standard.
I'd also be open to expanding the meaning of __requires__, but that change would need to happen within the larger context of setuptools and pkg_resources.
@jwodder Can you share more about the impact of this change on your use-case and which of these three approaches above would best suit your expectation?
In the meantime, I'll update the changelog to reflect the broader impact of this change.

I don't think something like<EMAIL_ADDRESS>should be supported: instead the format should be the same as for dependency_links; e.g<EMAIL_ADDRESS>Because ideally I think using rwt -- script.py should work the same as python script.py if all the requirements are already available (this currently fails because pip is called with no requirement).
Tentative patch:
 rwt/scripts.py | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git i/rwt/scripts.py w/rwt/scripts.py
index 115e00c..335eff8 100644
--- i/rwt/scripts.py
+++ w/rwt/scripts.py
@@ -18,9 +18,12 @@ if sys.version_info < (3,):

 class Dependencies(list):
 	index_url = None
+	dependency_links = []

 	def params(self):
 		prefix = ['--index-url', self.index_url] if self.index_url else []
+		for link in self.dependency_links:
+			prefix.extend(['--find-links', link])
 		return prefix + self

@@ -73,6 +76,12 @@ class DepsReader:
 			deps.index_url = self._read('__index_url__')
 		except Exception:
 			pass
+		try:
+			raw_links = self._read('__dependency_links__')
+		except Exception:
+			pass
+		else:
+			deps.dependency_links = list(pkg_resources.yield_lines(raw_links))
 		return deps

 	def _read(self, var_name):

Just to be clear, example use case with the patch above:
__requires__ = '''
foo==0.42
'''

__dependency_links__ = '''
<EMAIL_ADDRESS>'''

[...]

I like that idea. It follows patterns already in place for things like __index_url__ and honors the shared interfaces of pkg_resources and pip.

if all the requirements are already available, [rwt] currently fails because pip is called with no requirement

It shouldn't fail, but it'll log a warning:
$ rwt -- -c "print('hello world')"
You must give at least one requirement to install (see "pip help install")
hello world

PR here: #24.

It shouldn't fail, but it'll log a warning:

You're right. IMHO, it would be better if pip was not called if all requirements are already satisfied.

Huge thanks @benoit-pierre. Released as 3.1.
@jwodder Do let us know if this approach doesn't satisfy your needs.


Small improvements for Jellyfin and Plex post-process scripts

I had some small issues with the existing post-process scripts after discovering them in https://github.com/mdhiggins/sickbeard_mp4_automator/issues/1564. Changing them slightly makes them work perfectly. Perhaps you could consider applying those changes. Thank you in advance!
Changes for Jellyfin are basically a slightly updated URL following the API documentation and correcting the method from GET to POST, and removing the JSON output because Jellyfin does not return a JSON for the request, rather just a simple code and text.
diff jellyfin.py ../setup/post_process/jellyfin.py

9c9
<     url = "https://jellyfin.tld:8096/Library/Refresh"
---
>     url = "https://jellyfin.tld/library/refresh"
16c16
<         r = requests.post(url, headers=headers)
---
>         r = requests.get(url, headers=headers)
18c18
<         print(r.text)
---
>         print(r.json())

Changes for Plex are an updated API access method and renaming the variable SERVERNAME to FRIENDLY_NAME to distinguish it clearly from the PLEX_URL we need for API access:
diff plex.py ../setup/post_process/plex.py

4d3
< import plexapi
8,11c7,9
< PASSWORD = ""
< FRIENDLY_NAME = "MY-MEDIA-SERVER"
< PLEX_URL = "http://plex.tld:32400/"
< PLEX_TOKEN = ""
---
> TOKEN = ""
> SERVERNAME = ""
>
15,16c13,15
<     plex = PlexServer(PLEX_URL, PLEX_TOKEN)
<     sectionType = "show" if os.environ.get("SMA_SEASON") or os.environ.get("SMA_EPISODE") else "movie"
---
>     account = MyPlexAccount(username=USERNAME, token=TOKEN)
>     plex: PlexServer = account.resource(SERVERNAME).connect()
>     sectionType = "show" if os.env.get("SMA_SEASON") or os.env.get("SMA_EPISODE") else "movie"
19c18
<             print("Updating section %s on server %s" % (section.title, FRIENDLY_NAME))
---
>             print("Updating section %s on server %s" % (section.title, SERVERNAME))

If you wanted to submit a pull request with these changes I'd be happy to take a look and merge
These are really just very basic sample scripts to help show how the environment variables can work etc (especially for Plex since the script has full Plex integration built in already) but definitely want them to be functional samples

ced493e63fcc32f353e76d9d8fe14398eb703770


Update issue templates

I added a couple of suggestions to help make it more specific to the Obsidian Linter plugin, but keep in mind that there are missing ending backticks for code blocks (it seems nesting code blocks in a suggestion does not fare well for Github). Feel free to let me know what you think.

I agree with all of your suggestions. You can clone this branch and upload your own PR.

I agree with all of your suggestions. You can clone this branch and upload your own PR.

Sounds good. I'll see about getting that done today then.


Add support for SQLite3 wrapper library.

This is Issue 325 moved from a Google Code project.
Added on 2014-02-02T05:21:12.000Z by<EMAIL_ADDRESS>Please review that bug for more context and additional comments, but update this bug.
Original labels: Type-Enhancement, Priority-Medium

+1

Any news on this? I've heard that the inbox project has used shared data between Android and iOS. Has that been shared?

No, Inbox isn't open-sourced, so only our cross-platform strategy using
Java with the GWT and j2objc transpilers has been publicly shared.
On Sat, May 9, 2015 at 6:33 AM chemjournal<EMAIL_ADDRESS>wrote:

Any news on this? I've heard that the inbox project has used shared data
between Android and iOS. Has that been shared?
—
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/325#issuecomment-100484785.

Hi guys,
I have good news for you. We in SKOUMAL studio are working on clone of Sugar ORM (https://github.com/satyan/sugar) called joogar (not published on GitHub yet). It is based on Android SQLite API and low-lewel iOS SQLite3 library. More than 90% of code is pure Java shared on both platforms.
ORM is opt-in choise, you can stay with plain SQL if you want. Unfortunately joogar is still in its pre-alpha stage, even if we currently use it in one of our projects. It is still missing documentation, examples, transaction support, etc.
If you are interested to give it a try or contribute, please ping me on<EMAIL_ADDRESS>I'll let you know when we'll be ready for public alpha testing.

@gingo that seems like great news!! We're still early in our product lifecycle and I'll send you an email when I can try it out and contribute. By when are you expecting a public alpha rollout? Great work!

@chemjournal I'm worried it could take few month to public alpha. We are busy as hell on other projects :-)

@gingo let us know when you publish the alpha, I'd love to help you test it
out
On Tue, May 12, 2015 at 2:53 PM Salman Khan<EMAIL_ADDRESS>wrote:

On Tue, May 12, 2015 at 2:35 PM gingo<EMAIL_ADDRESS>wrote:

@chemjournal https://github.com/chemjournal I'm worried it could take
few month to public alpha. We are busy as hell on other projects :-)
—
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/325#issuecomment-101232661.

+1

How about providing support for sqlite4java out of the box?

I've created the following implementation to make it possible to use SQLite in conjunction with j2objc
https://github.com/vkmsua/sqlighter-4-j2objc .

@vkmsua looks good. A little bit more documentation would help.

This looks great, Vlad! May I add it to our list of open-source libraries
http://j2objc.org/docs/Projects-that-use-J2ObjC.html#open-source-projects?
On Wed, Aug 26, 2015 at 1:41 AM Michael Gorski<EMAIL_ADDRESS>wrote:

@vkmsua https://github.com/vkmsua looks good. A little bit more
documentation would help.
—
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/325#issuecomment-134899529.

@ confile I have made some updates to the documentation, with more to come.

Tom, yes, please. I'd be happy for the project to be on the list.

Added sqlighter to list of j2objc open-source libraries.

Thanks for your contributions!

@vals-productions Lib looks great it would be awesome to have a doc like this: https://github.com/stephencelis/SQLite.swift/blob/master/Documentation/Index.md#sqliteswift-documentation
Where Select, Insert, Delete, Update, Create, etc. are explained with an example.

@confile Right now the doc has "Going By Example" provision with select, insert, update, delete and create examples for a particular data sample. I can extend it with more wording and explanations.
https://github.com/vals-productions/sqlighter#going-by-example

@vals-productions Are you plan to actively maintain and develop this lib?

@confile Yes.

For those who are interested, yet another option to consider: I've recently pushed an experimental branch for j2objc support to Yahoo's SquiDB library (branch found here).
SquiDB was designed as a wrapper around the Android SQLite APIs and provides higher-level DAO functions and utilities for database I/O and constructing queries. This branch refactors the library to remove incidental Android dependencies from the core functionality and adds support for working with j2objc. Low-level SQLite access on iOS is accomplished via a fork/port of the android.database.sqlite package that removes OS-specific dependencies (e.g. Parcelable and ContentValues, neither of which are essential to SquiDB) and re-implements the native components like SQLiteConnection and CursorWindow in Objective-C rather than C++ (see the squidb-ios project).
Because it's a straightforward port of the android.database.sqlite package, SQLite access should have nearly identical behavior characteristics on both platforms, and a large subset of the Android SQLiteDatabase APIs are available via a common ISQLiteDatabase interface. Adapter classes are included in the squidb-android and squidb-ios models to facilitate plugging in the SQLite APIs appropriate to either platform -- in your application code, you interact only with a SquidDatabase instance that wraps these lower level APIs.
The branch is definitely still experimental -- we need to test more thoroughly for any memory leaks on iOS, it is not yet being used in any production app, etc. -- but the full unit test suite is passing on both platforms. Apologies that this branch is not yet very well documented, but those interested should be able to get a good idea of how the pieces fit together by examining the squidb-tests and squidb-ios-tests projects, and we'll add more documentation in the coming days. We're intending to continue developing this going forward and would welcome community feedback!

Nice! Let us know when you believe the major bugs are shaken out, and we'll
add it to the list of J2ObjC apps and projects page.
On Thu, Oct 22, 2015 at 3:09 PM Sam Bosley<EMAIL_ADDRESS>wrote:

For those who are interested, yet another option to consider: I've
recently pushed an experimental branch for j2objc support to Yahoo's SquiDB
library (branch found here
https://github.com/yahoo/squidb/tree/ios_bindings_v2).
SquiDB was designed as a wrapper around the Android SQLite APIs and
provides higher-level DAO functions and utilities for database I/O and
constructing queries. This branch refactors the library to remove
incidental Android dependencies from the core functionality and adds
support for working with j2objc. Low-level SQLite access on iOS is
accomplished via a fork/port of the android.database.sqlite package that
removes OS-specific dependencies (e.g. Parcelable and ContentValues,
neither of which are essential to SquiDB) and re-implements the native
components like SQLiteConnection and CursorWindow in Objective-C rather
than C++ (see the squidb-ios project).
Because it's a straightforward port of the android.database.sqlite
package, SQLite access should have nearly identical behavior
characteristics on both platforms, and a large subset of the Android
SQLiteDatabase APIs are available via a common ISQLiteDatabase interface.
Adapter classes are included in the squidb-android and squidb-ios models
to facilitate plugging in the SQLite APIs appropriate to either platform --
in your application code, you interact only with a SquidDatabase instance
that wraps these lower level APIs.
The branch is definitely still experimental -- we need to test more
thoroughly for any memory leaks on iOS, it is not yet being used in any
production app, etc. -- but the full unit test suite is passing on both
platforms. Apologies that this branch is not yet very well documented, but
those interested should be able to get a good idea of how the pieces fit
together by examining the squidb-tests and squidb-ios-tests projects, and
we'll add more documentation in the coming days. We're intending to
continue developing this going forward and would welcome community feedback!
—
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/325#issuecomment-150369932.

@sbosley: do any Yahoo apps use SquiDB? Just interested, not trying to get any proprietary info. :-)

@tomball yep! Android-only at the moment, but a few production apps have components using SquiDB, including the new Mail app and our SmartContacts app.

@sabosley Let me know when the iOS versions of those app are accepted by
the App Store if you'd like them added to the J2ObjC apps page
http://j2objc.org/docs/Projects-that-use-J2ObjC.html, or if you just want
congratulations. :-)
On Fri, Oct 23, 2015 at 8:36 AM Sam Bosley<EMAIL_ADDRESS>wrote:

@tomball https://github.com/tomball yep! Android-only at the moment,
but a few production apps have components using SquiDB, including the new
Mail app and our SmartContacts app.
—
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/325#issuecomment-150610303.

@tomball @chemjournal @confile finally joogar is on GitHub:
https://github.com/skoumalcz/joogar
We use it in this app (approved by Apple without any complains):
https://itunes.apple.com/us/app/prague-minos-guide/id427496512?mt=8

What's the update on this

@ribads , speaking of SQLite, SQLighter referenced in this thread will work
http://j2objc.org/docs/Projects-that-use-J2ObjC.html
https://github.com/vals-productions/sqlighter

@jdkoren Thank you for sharing this!   Are these artifacts you mention available on github now?   I'd like to try an experimental project that uses SquiDB on Sqlite, cross compiling on android & iOS.

@formvoltron the SquiDB 3.0 source code was merged into the master branch a few days ago. We haven't published jars for android development to jcenter() yet, but we intend to do so within the next couple of days. For iOS, the current solution is just to use j2objc to build from source, so if you want to clone the source and simply build the project directly on both platforms, you can definitely do that. You can let us know on that repo if you encounter any issues. Happy hacking!

my code is in java and i m run this code in xcode using j2objc and trying to connect with database but
driver error come. so how to solve it and error is in xcode-----
---Get Connection   jdbcCorejdbcCore----<SrcSagSQLiteCore: 0x60800005d220>
java.lang.ClassNotFoundException: SQLite.JDBCDriver
at 0x000000010c067fea java.lang.ClassNotFoundException.() + 22
at 0x000000010c171af6 java.lang.Class.forName_() + 930
at 0x000000010c030663 src.sag.SQLiteCore.loadDriver() + 35
at 0x000000010c03014d src.sag.SQLiteCore.getConnection() + 205
at 0x000000010c014854 src.sag.SqliteDemo.getTestConnectionTestWay2() + 644
at 0x000000010c011222 ViewController.createDatabase() + 514
at 0x000000010c010fd2 ViewController.viewDidLoad() + 98
at 0x000000010c8e3c99 UIViewController.loadViewIfRequired() + 1258
at 0x000000010c8e40cc UIViewController.view() + 27
at 0x000000010c7adc51 UIWindow.addRootViewControllerViewIfPossible() + 71
at 0x000000010c7ae3a2 UIWindow._setHidden:forced:() + 293
at 0x000000010c7c1cb5 UIWindow.makeKeyAndVisible() + 42
at 0x000000010c73ac89 UIApplication._callInitializationDelegatesForMainScene:transitionContext:() + 4818
at 0x000000010c740de9 UIApplication._run() + 1731
at 0x000000010c73df69 UIApplication.workspaceDidEndTransaction:() + 188
at 0x000000010fe0559c FBSSerialQueue._performNext() + 189
at 0x000000010fe05925 FBSSerialQueue._performNextFromRunLoopSource() + 45
at 0x000000010c73c7e6 UIApplication._run() + 434

SquiDB seems to be abandoned by Yahoo, last commit Jan 29, 2018,
https://github.com/yahoo/squidb/issues/290
there are however maintained forks, we are trying that with the most recent commit
https://github.com/mobilemindtec/squidb


fix next_page_url generation & run mix format

The URL builder initially has full url and when called with next_page_url(), it was generating something like this: https://api.twilio.comhttps://api.twilio.com/....
I think it makes sense to use next_page_url/1 with meta["next_page_uri"]
If merged, this closes #88
Also ran mix format on failing files on travis ci

Thanks! :star: :star:


[LW-8649] Adds data url for connect source in csp

Checklist

[x] JIRA - LW-8649
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Adds data URL for connect source in CSP
Testing
Get the branch, run yarn cleanup && yarn install move to apps/browser... run yarn dev load unpacked extension. It should now work.
Screenshots
N/A

Allure report
allure-report-publisher generated test report!

smokeTests: ❌ test report for a5470341

passed
failed
skipped
flaky
total
result

Total
30
2
0
0
32
❌

Nice work tracking this down @VanessaPC. It would be good to add some detail to the commit message, as this is lacking context on why the change is needed.

Addressed -> 4f2a60ddb9e8966d0df95684502c256ee0554d66  I also updated the ticket for further details.


Feature request: Support to show line Numbers of code

show line Numbers

代码显示行号

Read doc and demo first.
https://tianqi.name/jekyll-TeXt-theme/post/2016/06/16/code-blocks.html#line-numbers


Add material property to ProtoRamp

Closes #12

Hi, thanks for your contribution, only checking this now, but Proto Ramp is already a descendant of GeometryInstance3D, which has material override. So adding another property only to set the material on Proto Ramp is unnecessary, as you could do it already. Also, next time, a little description about your contribution would be nice, to see what exactly changed, not just the issue it would close.

Hi, thanks for your contribution, only checking this now, but Proto Ramp is already a descendant of GeometryInstance3D, which has material override. So adding another property only to set the material on Proto Ramp is unnecessary, as you could do it already. Also, next time, a little description about your contribution would be nice, to see what exactly changed, not just the issue it would close.

Although not setting contribution guidelines are kind of my bad to be honest, don't take it out on yourself, thanks for your help.

No worries! Sorry, I was in hurry that day, my bad.
I know there was a way to set materials, but it was different from all other CSG nodes (that's why I mentioned the "API" of the other CSGs, where it's possible to set a materia override AND a material) and sometimes it glitched badly with Combiners and complex operation stacks with different materials (and that makes the proposal a must, in my use case. Without it some of my buildings and props lose materials or behave strangely.
But feel free to close everything! It's a small code edit and I can keep it in my end.
Thanks again!

@HLCaptain and here are the evidences that this fixes what is reported in the issue:
BEFORE: check https://github.com/HLCaptain/proto-shape/issues/12#issuecomment-1957590617
AFTER ( this PR, 21/02/2024 )

The proposed changes fix the UX incoherency.
AFTER ( this PR, 21/02/2024, using the proposed Material property )

The proposed changes fix the behaviour, AND it still works when using the override in the CSGCombiner parent node.


grafana-agent charm based on Noble

Enhancement Proposal
We need grafana-agent charm based on Noble.

Any news on this one? It'll be needed for us as part of deploying the new version of the NTP charm (with NTS).

Sounds like you've been involved with 24.04 for other things.
Do you happen to have an example for how other charms transitioned to the new charmcraft.yaml single-base syntax?
We could release manually a one-off, but just wondering if someone already solved this.

The NTP charm is new, and only supports one series (noble), so I don't have experience with that aspect unfortunately. I've asked the question here.


Add deny-missing-docs macro

What type of PR is this?
/kind documentation
What this PR does / why we need it:
To keep the documentation quality on a high level for the future.
Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

/lgtm


3 channel data

Fixed bugs for compatibility with 3 channel data
dataset2.p (converted cifar-10 (without lables))

@goodboyanush can you please review this pull request.

Removed extra comments.
Please check and let me know is something needs to be further removed.

Removed extra comments.
Please check and let me know is something needs to be further removed.

Cool.. Will check

@panwarnaveen9 I have reviewed the new code. you can go ahead and merged it


chore: Loggers

Summary
What:
FileLogger and ConsoleLogger from deno-drash should be migrated to this repo.
Why:
This is to prep for the larger Dexter initiative next year.
Acceptance Criteria

[ ] Migrate FileLogger and ConsoleLogger
[ ] When merged, fix references to LoggerService (https://github.com/search?q=org%3Adrashland+loggerservice&type=code)

We could probably close this right @saragee3 @crookse ?:) woop woop (a late "woop woop" :P)

WOOP WOOP


Need api docs for v1.15

It seems like you took down the v1.1-1.16 documentation as it is no longer available here. My company is still using v1.15 and needs access to the docs. Can you please put these docs onto the website? Or is there a way/place I can download a copy? Thank you.

I'm not a member of the k8s org, but you could try web.archive.org for a
snapshot of the deprecated docs (see
http://web.archive.org/web/20201028193319/https://v1-15.docs.kubernetes.io/docs/home/)
while you wait for a response.
On Fri, Apr 23, 2021, 5:43 PM Donovan Lowkeen @.***>
wrote:

It seems like you took down the v1.1-1.16 documentation as it is no longer
available here https://kubernetes.io/docs/home/supported-doc-versions/.
My company is still using v1.15 and needs access to the docs. Can you
please put these docs onto the website? Or is there a way/place I can
download a copy? Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/27697, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHH4EFXG7EGGHFNJ2HURHALTKHSXVANCNFSM43PL4SNQ
.

Another option is to try the following command docker run -p 8000:8000 quay.io/tengqm/kab and then open http://localhost:8000 for browsing. The KAB (Kubernetes API Browser) has APIs spanning 1.13 to 1.21. It has more accurate type descriptions and easy to use UI. For a background on the tool, check https://github.com/tengqm/kab.


Error downloading from RTÉ Player

It seems to stall at this:

Can you check the log and paste the contents here? Options > Log > View Log
Have you tried downloading it with the original command line tool youtube-dl and looking for error messages on the console?

Just to report the error if it's any use:
### C:\WINDOWS\system32>youtube-dl https://www.rte.ie/player/ie/show/stutterer-30003890/10536757/
[generic] 10536757: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 10536757: Downloading webpage
[generic] 10536757: Extracting information
ERROR: Unsupported URL: https://www.rte.ie/player/ie/show/stutterer-30003890/10536757/

@JohnRuddy rte.ie is not supported by youtube-dl: https://rg3.github.io/youtube-dl/supportedsites.html
It has already been reported here https://github.com/rg3/youtube-dl/issues/8525. I think you can subscribe to that issue and close the one we're on.

@seamus911 Please close this issue.


esp-rfid v2

I think it's time to release a V2 for esp-rfid :)
We need a V2 as there are a few breaking changes on the MQTT interface, but I think it's much better now.
Apart from that, the update from V1 should just work, the old configuration will work on the V2 and the new stuff should default to settings that should keep the old configuration working. If anyone has problems upgrading let me know!
I have updated all the documentation and apart from a merge with stable and a changelog update we should be ready!!
@omersiar let me know what you think :)

This is huge 🥳 and puts a great milestone to the project thanks to all efforts you put into this,  much appreciated.

Thank you @omersiar!
Meanwhile I've deployed it on our system at the local Fablab and found a little bug about the old config compatibility :)
If you can approve again would be nice :)
I'll leave the PR open for a couple weeks just in case I find anything else or if anyone testing finds any issue. Thank you Omer!!

Today is the day of v2!


Use logging in clickhouse-local. Use config options in command line in clickhouse-client

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Improvement

Short description (up to few sentences):
Support  section in clickhouse-local config file.
Allow redefine config from command line in client as in server: clickhouse-local -- --tcp_port=9001

But it doesn't work for clickhouse-local. The only thing I needed:
milovidov@milovidov-Pro-P30:~/work/ClickHouse$ clickhouse-local --query "SELECT count() FROM remote('<IP_ADDRESS>', system.one)"
Not found: tcp_port
milovidov@milovidov-Pro-P30:~/work/ClickHouse$ clickhouse-local --query "SELECT count() FROM remote('<IP_ADDRESS>', system.one)" -- --tcp_port=9000
Not found: tcp_port


Add note in doc and API comment that rowCount should be odd

When the rowCount is even, then the middle two rows are highlighted. Odd count gives correct behavior

Hi, you are right. I realized before. Comment could be useful too. I will add next release. Actually row count must be get only odd paramenters but i couldn't find any function about this like IntRange. Any idea?

You could maybe do something like
val rowCount = if (listPickerContent.size % 2 == 0) listPickerContent.size + 1 else listPickerContent.size


Unable to access due to Access Denied error

Hello,
I've deployed IBeam on a server using Docker and this YouTube tutorial: https://www.youtube.com/watch?v=J2F6PrPUG6w; however, no matter what I try, I can't access it. I'm getting Access Denied.
I tried to troubleshoot it using the Troubleshooting section by adding my IP to the allow: list but no luck. I even tried to make it available to all IP by allowing *.*.*.*. Not sure if this can work, but in any case, it didn't. Here is my conf.yaml file:
ip2loc: "US"
proxyRemoteSsl: true
proxyRemoteHost: "https://api.ibkr.com"
listenPort: 5000
listenSsl: true
svcEnvironment: "v1"
sslCert: "vertx.jks"
sslPwd: "mywebapi"
authDelay: 3000
portalBaseURL: ""
serverOptions:
    blockedThreadCheckInterval: 1000000
    eventLoopPoolSize: 20
    workerPoolSize: 20
    maxWorkerExecuteTime: 100
    internalBlockingPoolSize: 20
cors:
    origin.allowed: "*"
    allowCredentials: false
webApps:
    - name: "demo"
      index: "index.html"
ips:
  allow:
    - 192.*
    - 131.216.*
    - <IP_ADDRESS>
    - <IP_ADDRESS>
    - 172.17.0.*
    - <IP_ADDRESS>
  deny:
    - 212.90.324.10

Any help with the problem will be greatly appreciated!

Hey @freggy145 - thanks for reporting your issue 👍
Please note that the tutorial you listed is unfortunately wrong in some areas, I don't recommend following it.
Could I ask you to paste the output of IBeam when you start it?

Hey @Voyz
Thanks for getting back to me!
Here it the output:
root@localhost:~# docker run -v /root/inputs:/srv/inputs --env-file env.list -p 5000:5000 voyz/ibeam
2022-08-08 14:09:26,905|I| ############ Starting IBeam version 0.4.0 ############
2022-08-08 14:09:26,914|I| Gateway not found, starting new one...
2022-08-08 14:09:26,915|I| Note that the Gateway log below may display "Open https://localhost:5000 to login" - ignore this command.
running
 runtime path : root:dist/ibgroup.web.core.iblink.router.clientportal.gw.jar:build/lib/runtime/*
 verticle     :
2022-08-08 14:09:27,925|I| Gateway started with pid: 12
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by io.netty.util.internal.ReflectionUtil (file:/srv/clientportal.gw/build/lib/runtime/netty-common-4.1.15.Final.jar) to constructor java.nio.DirectByteBuffer(long,int)
WARNING: Please consider reporting this to the maintainers of io.netty.util.internal.ReflectionUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
 -> mount demo on /demo
Java Version: 11.0.12
****************************************************
version: ed4af2592e9dd4a784d5403843bd18292fd441ea Fri, 9 Nov 2018 13:23:18 -0500
****************************************************
This is a Beta release of the Client Portal Gateway
for any issues, please contact<EMAIL_ADDRESS>and include a copy of your logs
****************************************************
https://www.interactivebrokers.com/api/doc.html
****************************************************
Open https://localhost:5000 to login
App demo is available after you login under: https://localhost:5000/demo/
2022-08-08 14:09:34,711|I| No active sessions, logging in...
2022-08-08 14:09:50,351|I| Authentication process succeeded
2022-08-08 14:09:53,492|I| Gateway running and authenticated.
2022-08-08 14:09:53,562|I| Starting maintenance with interval 60 seconds

I cannot see the message confirming that the custom conf.yaml is being used: 'Custom conf.yaml found and will be used by the Gateway'. I'm guessing you're not providing it correctly through the Inputs Directory. Have a look here: https://github.com/Voyz/ibeam/wiki/Inputs-And-Outputs#-inputs-directory

Ah, I managed to figure out the issue. It was a simple typo :(
I will close the ticket now. Thanks for the support!

Glad to hear @freggy145 well done figuring it out 😊

I have this same problem after using succesfully for 1 month straight. I run it with docker-compose and no custom yaml or anything. I don't understand how to get rid of the Access Denied error which I get now when I try access https://localhost:6600/v1/api/one/user. Env file only has my IB username and pass.
version: "3.4"
networks:
  options:
    name: options
services:
  ibeam:
    image: voyz/ibeam
    container_name: ibeam
    env_file:
      - ./envs/agent/ib.env
    environment:
      - IBEAM_PAGE_LOAD_TIMEOUT=60000
    ports:
      - 6600:5000
      - 6601:5001
    network_mode: bridge # Required due to clientportal.gw IP whitelist
    restart: 'no' # Prevents IBEAM_MAX_FAILED_AUTH from being exceeded
    stdin_open: true # docker run -i
    tty: true        # docker run -t
    healthcheck:
        test: ["CMD", "curl", "-X GET", "https://localhost:5000/v1/api/one/user", "-k"]
        interval: 20s
        timeout: 10s
        start_period: 30s
        retries: 100
    networks:
      - options


nms doubts for centerpoint two stage

Hi, Tianwei, sorry to bother you again. I tried to implement the two stage method on OpenPcdet. I have two questions.
First, why you didn't use the max pooling but the nms gpu for first stage post processing?
As mentioned in CenterNet paper. One of the main advantage of CenterNet is to left out the computational nms process.
But when I check your cfgs, you use nms-gpu instead. I wonder what is your consideration about this?
  "The peak keypoint extraction serves as a sufficient NMS alternative and can be implemented efficiently on device using a 3 × 3 max pooling operation."

  "nms=dict(
          use_rotate_nms=True,
          use_multi_class_nms=False,
          nms_pre_max_size=4096,
          nms_post_max_size=500,
          nms_iou_threshold=0.7,
      )"

Second, why no nms is needed for second stage post processing?
"# currently don't need nms
pred_dict = {
'box3d_lidar': box_preds,
'scores': scores,
'label_preds': labels,
"metadata": batch_dict["metadata"][index]
}
"
Thanks in advance!

First, why you didn't use the max pooling but the nms gpu for first stage post processing?

We can't use max pooling as the object size in 3d is relatively small and only occupy one or two voxel in the final feature map. Maxpooling will suppress objects in a crowd.

No nms in second stage

In early experiments, this one doesn't improve performance so I leave it out

Thank you for your info!


Make "make variables" config attributes for overridable flags

With the support of "make variables" comes the possibility for the
user to override them.  However, we need to make a difference between
defaults that we use (and that should be overridable by the user) and
flags that are crucial for building OpenSSL (should not be
overridable).
Typically, overridable flags are those setting optimization levels,
warnings levels, that kind of thing, while non-overridable flags are,
for example, macros that indicate aspects of how the config target
should be treated, such as L_ENDIAN and B_ENDIAN.
We do that differentiation by allowing upper case attributes in the
config targets, named exactly like the "make variables" we support,
and reserving the lower case attributes for non-overridable project
flags.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

CIs are super-angry :-)

CIs are super-angry :-)

Yup.  I expected no less, but perhaps not like this...

Travis is happy now, always something :-)

I'd guess appveyor is upset about lack of LEAN_AND_MEAN thing...

I'd guess appveyor is upset about lack of LEAN_AND_MEAN thing...

Hmmm?  I thought I restore that.  Will check

I'd guess appveyor is upset about lack of LEAN_AND_MEAN thing...

Hmmm?  I thought I restore that.  Will check

Ah, I know why, there are things lacking in windows-makefile.tmpl, still...  I'm actually going through the build files right now and filling in things I see missing...

I get following on for VC-WIN64A:
CFLAGS=-W3 -wd4090 -nologo
CNF_CFLAGS=-Gs0 -GF -Gy /MD /O2

/O2 belongs in CFLAGS.

Fixed

version -f output lost a bunch of flags, basically those that now listed in CNF_CPPFLAGS and CNF_CFLAGS.

BTW, here are couple of corner cases. What this flag separation is about? Among other things[?] it's about facilitating automated package builds, right? What's so special about them? They kind of like specifying distro-specific CFLAGS, right? So that it's not impossible to imagine that Configure and make receive same CFLAGS.
Corner case 1. env CFLAGS=-foo-bar ./config -extra-flag followed by env CFLAGS=-foo-bar make -e or make CFLAGS=-foo-bar. -extra-flag gets combined with -foo-bar in Makefile, but is not used during compilation. env CFLAGS=-foo-bar make, i.e. without -e, uses both flags.
Corner case 2. ./config -extra-flag CFLAGS=-foo-bar. -extra-flag does not appear in CFLAGS in Makefile (well, I suppose this is kind of expected), but[!] it gets merged into CXXFLAGS. [Yes, in 1st case -extra-flag is added to CXXFLAGS too.]
Presumably one can argue that it's wrong to expect that -extra-flag passed on command line plays well with CFLAGS. I mean one ought to choose only one at a time. But this raises question of conveying the message to user. A note in a README? But there is also kind usability issue. Maybe it wouldn't be inappropriate to terminate configuration process if user passes -extra-flag and either of recognized variables. i.e. to actually force user to choose...

Among other things[?] it's about facilitating automated package builds, right?

Quite frankly, it's to appease all those who claim (quite correctly, I've found) that the GNU way is near universal, at least in the Unix flavor of things.  I didn't actively think of automated package builds, but it's a good thing they can benefit too...

Corner case 1. env CFLAGS=-foo-bar ./config -extra-flag followed by env CFLAGS=-foo-bar make -e or make CFLAGS=-foo-bar. -extra-flag gets combined with -foo-bar in Makefile, but is not used during compilation. env CFLAGS=-foo-bar make, i.e. without -e, uses both flags.

I'm not sure I understand...  when I do env CFLAGS=-foo-bar ../master/config -extra-flag, I get this in the resulting Makefile:
CFLAGS=-foo-bar -extra-flag -Wa,--noexecstack

Then when you give a new CFLAGS with the make run (i.e. make CFLAGS=-foo-bar), that new CFLAGS value replaces the one in Makefile.  I don't understand how -extra-flag gets combined in...
make will of course not make the environment priority over the variables on Makefile.  I'm not sure how that's an issue.

Corner case 2. ./config -extra-flag CFLAGS=-foo-bar. -extra-flag does not appear in CFLAGS in Makefile (well, I suppose this is kind of expected), but[!] it gets merged into CXXFLAGS. [Yes, in 1st case -extra-flag is added to CXXFLAGS too.]

So yes, when Configure finds a flag it doesn't know, it will append it internally to the values known as CFLAGS and CXXFLAGS.  But, when it encounters a "make variable" assignment, that variable gets reset to the new value, all previously collected values (such as random flags on the command line) are thrown away.  On the other hand, with ./config CFLAGS=-foo-bar -extra-flag, you will end up with this in Makefile:
CFLAGS=-foo-bar -extra-flag -Wa,--noexecstack
CXXFLAGS=-Wall -O3 -extra-flag -Wa,--noexecstack

(note that -Wa,--noexecstack is passed on the command line to Configure by config)

version -f output lost a bunch of flags, basically those that now listed in CNF_CPPFLAGS and CNF_CFLAGS.

Fixed...  I hope.

I did a semantic change just now.  In Configurations/shared-info.pl and Configure, dso_* got changed to module_*.
The reason for this is that the dso_ attributes had different semantics depending on the platform flavor we run on.  On Windows and VMS, dso_lflags was used instead of lib_lflags, while on Unix, dso_lflags was used in addition to lib_lflags, much like shared_ldflag was for shared libraries.
So module_cflags et al are introduced as additional flags to build DSOs, in the same way as how shared_cflag et al are used.
This shouldn't disrupt anything, because the dso_ prefix was practically only used on native Windows and VMS, and shared-info.pl is introduced in master, so this is all news for 1.1.1 anyway.

I'm not sure how that's an issue.

It's confusing and error-prone. Imagine you have a package script that passes extra arguments to config[ure], and did it for years. And now it also picks CFLAGS from environment.

-Wa,--noexecstack

It should really be detected in ./Configure and go to CNF_CFLAGS.
OK, let me put it as not a question, but suggestion. And suggestion is to refuse to mix the two by failing Configure with corresponding error message.

I'm not sure how that's an issue.

It's confusing and error-prone. Imagine you have a package script that passes extra arguments to config[ure], and did it for years. And now it also picks CFLAGS from environment.

Good point...  and that brings us to this:

OK, let me put it as not a question, but suggestion. And suggestion is to refuse to mix the two by failing Configure with corresponding error message.

I agree, that seems to be the safest path.

-Wa,--noexecstack

It should really be detected in ./Configure and go to CNF_CFLAGS.

Errrr...  so if I do ./config -DFOO, Configure will get these options: -DFOO -Wa,--noexecstack
How is Configure going to know which one is my user input (goes to CFLAGS) and which one is generated from config (and could be argued should go to CNF_CFLAGS)?
Personally, I think config has no business generating flags like this, those should be moved elsewhere...  or we should accept that they are going to be treated the same way as any other user generated flag.

I agree, that seems to be the safest path.

But before that, we need to resolve the issue with things passed from config

Personally, I think config has no business generating flags like this,

Well, I also something wish that one could just do things without taking all the factors and circumstances into consideration. But we are just not that lucky :-)

those should be moved elsewhere... or we should accept that they are going to be treated the same way as any other user generated flag.

Or they could be conveyed to Configure in such a way that will make it accept them as non-overridable. I also wish we could just skip it, but it might be inappropriate, not at this point. As for -Wa,--nonexecstack, it's kind of a security option, and it's argued that Configure is more appropriate place to detect it, because it covers cross-compile scenarios. It's argued that it's too easy to miss...

Well, I've got an idea, coming up soon in a new commit here

There...

So we kind of agreed that Configure should reject attempts to pass additional flags in case any of recognized "make variables" are set/passed, forcing user to make the choice among the two. Remaining question is here and now or later.

Remaining question is here and now or later.

For clarity, I prefer to make that a separate PR

What does "UNFINISHED" in last commit mean? That more commits are still to come?

... actually, mind you, the behavior with mixed compiler options and variable assignments is documented.  Read INSTALL

What does "UNFINISHED" in last commit mean? That more commits are still to come?

Ah, yes!  Thanks for the reminder.  I need to finish documenting, that's what it means.

... actually, mind you, the behavior with mixed compiler options and variable assignments is documented

The fact the we have this request does mean that outcome is not quite right, and it needs re-thinking. And documentation should naturally be part of this rethinking. Well, I probably wouldn't find mixing additional flags and "make variables" inappropriate if latter were not picked from environment at config time, e.g. as env CFLAGS=-foo-bar ./config -bar-foo. In other words as long as picking environment is an option, I'd feel strong about prohibit mixing. Well, one can argue in favour of not looking at environment variables if user passes any additional flags... Either way there should be something that makes it less error-prone... It's just that prohibiting mixing is easiest to explain, and would probably be easy for user to accept.

one can argue in favour of not looking at environment variables if user passes any additional flags...

Actually on second thought this might be as sensible. I mean instead of prohibiting mixing, one can disregard environment variables if any tool-chain flags are passed at config command line. This will ensure "backward compatibility". Mixing stuff on command line still doesn't feel quite right, but I suppose some would appreciate it...

Actually on second thought this might be as sensible. I mean instead of prohibiting mixing, one can disregard environment variables if any tool-chain flags are passed at config command line. This will ensure "backward compatibility". Mixing stuff on command line still doesn't feel quite right, but I suppose some would appreciate it...

No, because that would mean that these two lines would produce different results:
env CFLAGS=-foo ./config -bar

env ./config CFLAGS=-foo -bar

That would be utterly inappropriate and would be quite a surprise.

No

Then prohibition it is.

Thank you!
Merged. 48dcca265c9cb0c26459240ab1858577dacf9e67 to b92013602b6666314ad200d48e10a1aaa2c5b2fa

what you're saying is that if you use nmake, you can only use it with VC.

Trick question ... I'm not exactly saying that if you use nmake, you can only use it with VC, but rather that there is nothing else you can use it with. This is just a de-facto statement.

Well, on closer look it wouldn't be wrong to say that if you use windows-makefile.tmpl, you can only use it with VC. Because there is VC-specific command sequence, one that generates dependency list with /Zs /showIncludes output being piped to perl script that expects quite specific format. Original side note closed with "one can probably argue that we could just as well call it vc-makefile.tmpl". I'd say that one can still do that... And it's still a side note :-) :-) :-)

You do know that all you're doing is to tempt me into coming up with new config attributes, right?  ;-)

Maybe this is good enough for now, and we should focus on other PR reviews?


repokitteh: Add /coverage command

Similar to how repokitteh works for docs currently, this PR will print the coverage link if either the title of the Pr starts with coverage:  or if a comment has a line starting /coverage
Signed-off-by: Ryan Northey<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/rk-bless

/coverage

cc @tyxia

/retest

/assign @tyxia

@lizan this is over to you for final pass

@htuch i think this one is pretty useful, and not likely to break anything, if you get a moment to review

Yeah, this is great. Out of curiosity, why not unconditionally have RK write the coverage link? It's pretty useful during any review and might make it generally lower activation energy to have folks take a quick peak.

why not unconditionally have RK write the coverage link?

it would generate too much noise - also the same for docs etc - its not always relevant i think

i think the command is useful because it draws attention to it
that said - every build creates docs, outputs coverage, etc - im wondering again about my original plan with docs which was to put a link the ci box (at the bottom of pr - eg with test results)

Yeah, can a link in the CI box work in GH as an action?

i think it can be triggered by anything with gh creds


The line number of the code is incorrect while panic

The following program sample.go triggers a panic:
package main

import "fmt"

func testPanic2() {
	var m []int
	m[0] = 1
}

func testPanic() {
	testPanic2()
}

func main() {
	fmt.Println("hello")
	fmt.Println("hello")
	fmt.Println("hello")
	testPanic()
}

Expected result:
$ go run ./sample.go
hello
hello
hello
7:6: panic
11:2: panic
18:2: panic
Exit:  reflect: slice index out of range

Got:
$ yaegi ./sample.go
hello
hello
hello
6:6: panic
11:2: panic
15:2: panic
Exit:  reflect: slice index out of range

At first I thought it was just an off by one error, but it's more annoying than that. The error line is on the problematic node, in this case the node for "n". And instead of being on the problematic operation on this node, it is on the line where this node is declared.


Added review modal to review block

This was left out in a previous rebase.

#2961  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite