Built out tweet_lookup endpoint options

Addressing some of  #28.
I am sure that the code could be refactored b/c it's fairly repetitive but I figured we could start with this.
The tests are not 100% comprehensive, however, I designed them to match the usage example for fields and expansions provided on Twitter's site.

For some reason, this branch had conflicts with master. To prevent the conflict from escalating, I just resolved the conflicts.
I'm also going to merge this PR for now and I'll propose something I have in mind for the expansions and fields.

For some reason, this branch had conflicts with master. To prevent the conflict from escalating, I just resolved the conflicts.
I'm also going to merge this PR for now and I'll propose something I have in mind for the expansions and fields.

BTW, merging the master back to your work branches every time before you start working on new features can help avoiding conflicts.

BTW, merging the master back to your work branches every time before you start working on new features can help avoiding conflicts.


Refactor Storybook theme to use 3.0.0 tokens

The BCDS_theme added in #298 references design tokens from v2.0.1. These references need to be checked and updated to use v3.0.0rc1 tokens.

Changes ready to implement, blocked by #313


OneHotEncoder

This adds a OneHotEncoder for encoding categorical data.
Differences from scikit-learn:

Uses categorical information from pandas (like our labelencoder)
OneHotEncoder(sparse=True).transform(dask_array) returns a dask array, rather than a sparse matrix. Each block of the dask array is a sparse matrix.

I've documented these differences in preprocessing.rst.
Currently, this doesn't handle unknown (previously unseen) values in the .transform, though I've just had an idea how to do it...

Did you look at argwhere in Dask Array?

I might move quickly on this and merge it without giving others time to properly review. It's a large change, but I'd like to immediately follow things up with ColumnTransformer, and then actually try it out on the criteo dataset.

The coverage check failed because the runner reporting the coverage (py36) skips those tests, as they require scikit-learn dev.


Yarn 2.6.0

YARN-1905: TestProcfsBasedProcessTree must only run on Linux.
Minor change in a test. Applied manually

Can one of the admins verify this patch?


Increment versions for networkfunction releases

Increment package versions for networkfunction releases

API change check
API changes are not detected in this pull request.


Service Bus for Windows Server 1.1 Support

This is just a thought that I had, but it should be possible to add support for Service Bus for Windows Server reasonably simply as the API is advertised as being compatible with Azure Service Bus, so hopefully most of the work is done.
https://www.nuget.org/packages/ServiceBus.v1_1/
Not too sure if there is a clever way to reuse code between the two implementations if they are compatible. Maybe a multi targeting style project setup?
Since dropping the support of MSMQ, this might give a good alternative for those that want to use service bus in house and not prepared to install RabbitMQ, and can be setup in windows desktops almost as easily as MSMQ was.

Would the transport actually have to change to work with Service Bus for Windows?

Hey @petedavis
it will work but you need to create Shared Access Signature Token for your namespace (https://msdn.microsoft.com/en-us/library/dn440944.aspx) and then when initializing the MT bus create a SASTokenProvider
//Trust all SSL certificates :DEVELOPMENT ONLY!!!!
System.Net.ServicePointManager.ServerCertificateValidationCallback = ((sender, certificate, chain, sslPolicyErrors) => true);

var bc = Bus.Factory.CreateUsingAzureServiceBus(cfg => {
    var host = cfg.Host(new Uri("sb://<HOST>/<NAMESPACE>"), h => {
        var stsUris = new List < Uri > () {
            new Uri("https://<STSENDPOINT.Host>:9355/<NAMESPACE>")
        };
        h.OperationTimeout = new TimeSpan(0, 0, 15);
        h.TokenProvider = TokenProvider.CreateSharedAccessSignatureTokenProvider("myrule", "IUAxMjM0NTY3ODkwMTIzNDU2Nzg5MDEyMzQ1Njc4OTA=");
    });

    cfg.ReceiveEndpoint(host, "SampleMessageQueueMT", c => {
        c.Consumer(() => new SampleMessageConsumer());
    });
});

bc.Start();

Okay so I added support for a connection string, instead of requiring the SAS token. It will be in .16 - should resolve this issue.

Not sure if it will work then since Masstransit transport should use the sw4w library instead of the windows azure SB library

Currently the APIs are compatible. Historically they have changed at a different rate and they could become incompatible again in the future. A specific version for windows could be implemented when that time occurs, but right now  that would just add more code to maintain?

Has anyone tested the latest using the connection string approach? Or does anyone have a Service Bus for Windows I can connect to for testing?

I havent tested it yet. I will have to reinstall Service Bus for Windows, which is not an ideal experience.

Has anyone got this to work?  I am using Service Bus for Windows Server 1.1 but would like to use a popular, standard framework like MT.  In my opinion, SBWS 1.1 is one of the easiest installation experiences out there.

If I had a connect string to a SBWS instance, I would be happy to test it and fix any issues. The connection string method of configuration should work for using SBWS, I just need to verify with a working SBWS cluster.

Or even a working VMware image, I could use that to test as well. Something...

SBWS is easy to install on a workstation.  All you need for a working SBWS instance is a Windows 7 or above machine and a working SQL 2012+ Express or above instance (local or not).  Use Web Platform Installer searching on Service Bus 1.1.  There are 2 entries for Windows Azure Pack (1 security update).  After, execute the Service Bus configuration to create the databases and services and default Namespace.  Get the SB connect string from PowerShell (Get-SBAuthorizationRule -NamespaceName). You can use Service Bus Explorer 2.1 or create some Queue or Topics from powershell or C#.
You can't use the current Azure SDK for this.  The API has changed.  That is why we have to use Service Bus Explorer 2.1.  There is an active NuGet client package at:https://www.nuget.org/packages/ServiceBus.v1_1/.
The other requirement for a client is the certificate installation for SSL.  If installing on a workstation this is handled automatically.
.NET 4.6 breaks SBWS 1.1.  The KB is here https://www.microsoft.com/en-us/download/details.aspx?id=49496 . The new Azure Service Fabric also breaks SBWS.
To me this is easy since I have performed the process many times.  If I had VMWare I would create you an image.  I have not attempted anything virtual on Windows 10 at all.

Thanks for that. Explains why I cannot get it to work.

I did not state clearly that the KB does actually repair SBWS.  KB3086798 - Update for Service Bus Server 1.1  https://www.microsoft.com/en-us/download/details.aspx?id=49496

@jeffreywstevens Any chance you can create a VM in Azure using a trial subscription and let me give it a whack?

I have plenty of Azure credit.  I created a VM and installed Service Bus 1.1.  Once I get it configured and working for external connections I will supply you with the connect string and certificate.  MyEmail is<EMAIL_ADDRESS> Hopefully I wont get spammed for this message.

I've had a chat with someone responsible for SBWS at Microsoft, and their suggestion was that we split support for SBWS from ASB. While it might be similar, we are just likely to see more feature divergence over time.

Are they completely separate assemblies to communicate with Azure and Windows Service Bus? I get the point, but would hate to maintain yet another transport for a 5% variance.

The on premise Azure Pack SBWS uses the same SDKs and assemblies fixed at specific versions for compatibility.  It will not change until they drop a new version which may happen with the Azure Stack.  The Azure Service Bus drops new versions and features at a more aggressive cadence.

I have an Azure VM with Service Bus 1.1 remotely accessible if you are still interested.  I will need to send you a cert and a connect string.

Very, please send the credentials to me and I'll work on making MT work with WSB.
Send them to chris at phatboyg dot com and I'll try to get it done before the end of the week!

@phatboyg Have you managed to make it work?

There is a branch I'm working on that adds support for SBWS, I'm just having difficulty getting it tested due to connectivity issues to an SBWS machine running in Azure. I had to set it aside for a bit, but I plan to return to it and get it sorted out.
https://github.com/phatboyg/MassTransit/tree/sbws

@phatboyg I have tried transport for SBWS, it does not work. Do you have any plan to work on it? Thanks.

So the buzz is that SBWS isn't long for this world, not sure this is worth taking any further.

I am very interested in the buzz since I have SBWS installed and in use on premise.  I need to formulate migration plans on Azure Stack or just in Azure depending on the timeline.  I am still running AppFabric which has also reached end of life.

Well, I think the lack of updates and the shift in direction for service bus in Azure (well, not a shift, but more of a refinement) is a good hint that we won't be seeing a whole lot of new development in this area. Just speculation, though.

You are correct there will not be any future development but it appears it is supported.  After I posted I found some information direct from Clemens Vasters and a presentation on the future direction. [https://www.biztalk360.com/integrate-2016-resources/service-bus-roadmap-whats-next ]
[http://stackoverflow.com/questions/35401858/is-service-bus-for-windows-server-dead]
Going forward on premise will be Azure Stack whenever that is released and it won't be free.

Just to close this out: https://azure.microsoft.com/en-us/blog/collaboration-and-federation-azure-service-bus-messaging-on-premises-futures/

Thank you very much for the prompt instantaneous posting.  My company has to make some decisions based on this information.


Minimap dissapears when using references popup supplied by referencesCodeLens.enabled = true

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

ng-template
Angular
0.1.3

Angular2
johnpapa
2.3.3

JavaScriptSnippets
xabikos
1.4.0

Steps to Reproduce:

Enable codelens in Preferences -> Settings:  "typescript.referencesCodeLens.enabled": true
The reference count will appear above methods and classes, click the gray x references link above the method/class, to see where it is referenced from.
Click above the popup that shows the references.
The minimap on the right will now be made into a normal vertical scrollbar.

A reboot of VSCode will show the minimap again instead of the vertical scrollbar, but only until the references popup is used again.

Duplicate of #28093


add environment variables

Codecov Report

Merging #280 into master will decrease coverage by 0.10%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   86.42%   86.32%   -0.11%
==========================================
  Files          50       50
  Lines        3094     3100       +6
==========================================
+ Hits         2674     2676       +2
- Misses        292      296       +4
  Partials      128      128

Impacted Files
Coverage Δ

config/profile.go
81.81% <42.85%> (-1.61%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0113181...8711b61. Read the comment docs.

codecove下降是因为没有刷新，新代码已经覆盖到了新增的语句


BitStamp returns BTC_USD pair ticker info for nonexisting currency pairs

Hello, I have tried to query a ticker from BitStamp and when I set a currency pair for example as BTC_CZK,  it returns  BTC_USD value. This is a very dangerous bug.
I have not tried this behaviour on all exchanges, only on  BitStamp

Good catch. I'll look into it.

I pushed a fix for this that does an assert.


Add playwright tests for signing in

Please add playwright tests for signing in
reference https://playwright.dev/docs/writing-tests for help

lgtm

lgtm


Fix AutoSizeColumn

Fixes #77 and part of #74.
The existing AutoSizeColumn unit tests pass now and the new calculations seem to be working great.
Unfortunately, when I reference NPOI indirectly from a net461 ASP.NET project some of the columns are sized slightly smaller than the content. While debugging I determined it's because Graphics.MeasureString returns a different value in this context. I'm not sure why. My first thought was the method returns a different value in System.Drawing than System.Drawing.Common, but that doesn't explain why the sizing works fine from the unit test project which is also net461. I think System.Drawing.Common just delegates to GDI+ like System.Drawing does anyway.
I can't spend much more time looking into it, so thoughts and additional testing are welcome. Otherwise, I think it works well enough to merge considering the current version doesn't auto-size at all.

Hello, thanks for your PR, AutoSizeColumn is a bug in the migration process. It is not an easy task to completely solve this problem. Anyway, thank you very much for your work. :)

I'll release a new version tomorrow

My first thought was the method returns a different value in System.Drawing than System.Drawing.Common

I discovered that this is true. It showed up in my project because NPOI was first referenced from a netstandard2.0 library and that library referenced by net461 (NPOI -> netstandard -> net461). All that to say, my fixes work nearly perfect for NPOI net461 but are slightly off in NPOI netstandard2.0. I'll see if I'm able to submit another fix for netstandard at a later time.


Callback URL textbox is enabled for any grant type

Description
Hi Team,
We can enter a callback URL in the Dev Portal even when only the client credentials grant type is enabled. While this does not cause any functional issues, we believe it to be a UI issue.
Steps to Reproduce

Start the APIM Manager server
Log into Dev Portal
Go to Applications -> Production Keys and uncheck all the grant types except the "Client Credentials"
Can observe that the "Callback URL" is enabled and can insert a value
Insert a value and click "Generate Keys"
Can observe that the callback URL is successfully saved

Affected Component
APIM
Version
3.1.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Closing this issue as the fix is already available in public.


tn-522 TNUSA - OR, FL, NY missing from state drop-down list

whoops @ivan-c  I need to fix a state...


Manage the list of users in a user group

As a manager or team lead
I want to be able to easily and independently update my team's staff names when there's been a staffing change
so that I can keep the names within user groups current

Assumptions & Scope
What are the assumptions for this story?
What is IN scope?
What is NOT in scope?

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

This is not needed for Release 2.1 (Pilot Launch) as our team has the ability to make these changes for MVP. However, @lmullane learned that Karim (Service BC) has built a way for users to manage their own groups so there may be some things we can reuse or iterate from


Performance

Is there any bench-marking done on these libraries like play-pac4j (scala), pac4j-ldap, pac4j-openidconnect ? or performance testing.

Please ask your questions on the mailing list.


Unexpected token ? in JSON at position 7

What day am I already fighting, and I can not understand why this module does not start…
The command in package.json is like this:
"html-check": "node-w3c-validator -i src/**/*.html -f lint -b 500"

It gives an error like this when running the command:
$ npm run html-check
><EMAIL_ADDRESS>html-check
> node-w3c-validator -i src/**/*.html -f lint -b 500
✖ An error occurred while processing validator execution!
Unexpected token � in JSON at position 7

I read the last issues there, one of the answers says that if there are special characters in the file name, then there may be errors.
I checked both with and without them, it still does not work.

@SineYlo try increase -b  to 1024 or 2048

@yunusga
Unfortunately, it didn't help.
I even deleted all the other html files and left only index.html in the src folder.
As a result, I used the following command:
"html-check": "node-w3c-validator -i src/index.html -f lint -b 2048"

The error is always the same ...

@SineYlo show your index.html, node and node-w3c-validator versions

@yunusga
Should I insert all the html code from the template here? He's just not small.
node — v16.13.0
node-w3c-validator — 2.0.1

@SineYlo
Super strange, i have same configuration and get √ node-w3c-validator - no errors.
Show full system path to tested files
Did you install the "Java"?

@yunusga
Whoa. I certainly did not notice this ...
Now I'll try to install it!
If everything goes well, I will close the issue.

@SineYlo
If the problem was in Java, do not close the issue. I will make a PR with an output message about the need to install Java

@yunusga
Indeed, when Java put everything worked :D
Of course, putting Java for the sake of one module is certainly strange, but oh well
Probably, it will not be possible to do this module without it

@SineYlo Job done https://github.com/dutchenkoOleg/node-w3c-validator/pull/19, waiting for approval.

@yunusga @SineYlo - thanks for your collaboration!
PR is merged and new version is published on NPM


fairseq/clib/libbleu/libbleu.cpp:10:10: fatal error: 'array' file not found

I have successfully installed pytorch 0.4.0. on mac.

import torch
print(torch.version)
0.4.0a0+0b17f4b

But I got an error when I type "python setup.py build". How to fix it?
running build
running build_py
running build_ext
building 'fairseq.libbleu' extension
gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/Users/q/anaconda/envs/python36/include -arch x86_64 -I/Users/q/anaconda/envs/python36/include -arch x86_64 -I/Users/q/anaconda/envs/python36/include/python3.6m -c fairseq/clib/libbleu/libbleu.cpp -o build/temp.macosx-10.7-x86_64-3.6/fairseq/clib/libbleu/libbleu.o -std=c++11
fairseq/clib/libbleu/libbleu.cpp:10:10: fatal error: 'array' file not found
#include
^
1 error generated.
error: command 'gcc' failed with exit status 1

Fixed. Added '-mmacosx-version-min=10.11' to extra_compile_args in setup.py.
extra_compile_args=['-std=c++11', '-mmacosx-version-min=10.11'],

Still encountered error on my mac
changing `libbleu.cppp'
#include <array> =>  #include <tr1/array> fixed it for me

This happened for me when running pip install fairseq on my Mac. I ran export CFLAGS='-stdlib=libc++ and then pip install fairseq completed successfully.


Changing color of SolidColorBrush don't cause a rerender

Describe the bug
When i change Color property of SolidColorBrush in resources it doesn't cause a rerender. It works in 11-preview*, but doesn't work in rc1-1
To Reproduce
Steps to reproduce the behavior:

App.axaml:

<Application.Resources>
    <SolidColorBrush x:Key="MyBrush" Color="Aqua"></SolidColorBrush>
</Application.Resources>

Window:

<StackPanel>
  <TextBlock Foreground="{DynamicResource MyBrush}">TEST TEXT</TextBlock>
  <Button Foreground="{DynamicResource MyBrush}" Click="Button_OnClick">CHANGE COLOR</Button>
  <Button Foreground="{DynamicResource MyBrush}">DUMMY</Button>
</StackPanel>

Code behind:

private void Button_OnClick(object? sender, RoutedEventArgs e) {
    var solidColorBrush = App.Current.Resources["MyBrush"] as SolidColorBrush;
    var random = new Random();
    solidColorBrush.Color = Color.FromRgb((byte)random.Next(0, 255), (byte)random.Next(0, 255), (byte)random.Next(0, 255));
}

Desktop (please complete the following information):

Version: 11.0.0-rc1.1

Fast repro (also contains my other code, don't mind):
AvaloniaApplication1.zip

Probably related (or duplicated) to #11036.

Yes, i think it related to your issue, @danipen
But i facing this issue only for rc1-1, not for preview*. I should check it again.

if you change the code like this
        private void Button_OnClick(object? sender, RoutedEventArgs e)
        {
            var random = new Random();
            App.Current!.Resources["MyBrush"] = new SolidColorBrush()
            {
                Color = Color.FromRgb((byte)random.Next(0, 255), (byte)random.Next(0, 255), (byte)random.Next(0, 255))
            };
        }

works.

I think it's more related to this https://github.com/AvaloniaUI/Avalonia/issues/11640 one and was already fixed in master.

@maxkatz6 I've tried the 11.0.999-cibuild0036218-beta and its partially fixed. But, for example, button foreground still doesn't get an update:

Seems like this issue strikes back in https://github.com/AvaloniaCommunity/Material.Avalonia/issues/262
Update for Avalonia 11.0.0: still reproduceable as in my last comment. Here is an updated code: AvaloniaApplication1.zip
But i figured out some interesting details, if we put a control with a explicit binding after the button, button color changing start working.
<StackPanel>
  <Button Foreground="{DynamicResource MyBrush}" Click="Button_OnClick">CHANGE COLOR</Button>
  <Button Foreground="{DynamicResource MyBrush}">DUMMY</Button>
  <TextBlock Foreground="{DynamicResource MyBrush}">TEST TEXT</TextBlock>
</StackPanel>

But, if we put another button in the end 😆, it doesn't work:
<StackPanel>
  <Button Foreground="{DynamicResource MyBrush}" Click="Button_OnClick">CHANGE COLOR</Button>
  <Button Foreground="{DynamicResource MyBrush}">DUMMY</Button>
  <TextBlock Foreground="{DynamicResource MyBrush}">TEST TEXT</TextBlock>
  <Button Foreground="{DynamicResource MyBrush}">DUMMY</Button>
</StackPanel>

@kekekeks, @maxkatz6 i think what it's something compositor related, do you think?

Also, non of this were updated in previewer, may be this  info will help:


Create an lint rule to warn deprecated component usage

To increase the adoption of our accessible/improved components, we want to add a lint rule that warns consumers if they stay using the deprecated version of the components.
We want to move away from
import { Tooltip } from '@primer/react/deprecated'

to
import { Tooltip } from '@primer/react/experimental'

Closing this in favor of https://github.com/primer/eslint-plugin-primer-react/issues/114


feat: make contact us page accessible ✨

Description

As part of our commitment to inclusivity and ensuring equal access to our website's services, we need to address the accessibility concerns related to our "Contact Us" form. Currently, the form may present challenges to users with disabilities, hindering their ability to reach out and engage with us effectively.

Key Points to Address

Keyboard Navigation: The form should be operable using keyboard inputs alone, without relying on mouse interaction. This is essential for individuals who navigate the web using assistive technologies.

Screen Readers Compatibility: The form elements and associated feedback messages need to be appropriately labeled and structured, ensuring compatibility with screen readers. Proper semantic markup will enhance the understanding of the form's purpose and improve the overall user experience.

Contrast and Visual Cues: Evaluate the form's color contrast to ensure readability for users with low vision or color blindness. Additionally, consider providing visual cues for form validation errors, alerts, and success messages.

Focus Indicators: Implement clear focus indicators to indicate the active form element. This is crucial for users who rely on focus indicators to navigate through web pages.

Responsive Design: Confirm that the form is responsive and adapts well to different screen sizes and devices, including mobile phones and tablets.

Validation and Error Handling: Enhance form validation to provide meaningful and descriptive error messages, guiding users on how to correct their input when errors occur.

Alternative Contact Options: In conjunction with the form, consider providing alternative contact methods, such as a dedicated email address or phone number, for users who may encounter difficulties with the form.

Expected Outcome

By addressing the above points, we aim to make our "Contact Us" form more inclusive and accessible to all users, regardless of their abilities or disabilities. This will not only align with web accessibility standards but also demonstrate our commitment to providing an inclusive experience for everyone using our Food Recipes Website.

Hey there @Anupkjha2601 👋🏻
Please make sure to assign this issue to me to make the work done!
Thank you.

Hey there @Anupkjha2601 👋🏻
Please make sure to assign this issue to me to make the work done!
Thank you.


C# GetCameraIntrinsics | Return wrong value to console

Hello,
in line 33 and 34 is the wrong property retuned to console, I think.
33 Console.WriteLine("    P1 = " + intrinsics.Distortion.K1.ToString());
34 Console.WriteLine("    P2 = " + intrinsics.Distortion.K2.ToString());

Fixed, see https://github.com/zivid/zivid-csharp-samples/blob/master/source/Camera/InfoUtilOther/GetCameraIntrinsics/GetCameraIntrinsics.cs


[Tests] Implement stress testing and benchmarking

Stress tests need to be designed at unit test level and at network tests level.  Stress testing must happen along two dimensions: intensity and duration.  The aim is deliberately to expose and map out the breaking points of the stack.

ensure that, as a good open source project, we are publishing these results.

this issue is largely finalized with the work against caliper and our internal stress tests. although we are blocked by the implementation of a hyperledger CI system for operating stress networks I think we should close this issue for now.
see: https://lists.hyperledger.org/g/tsc/topic/30876684 for future work.


SEO warning, because of  tag linking to an image instead of website

Hi and thank you so much for the awesome plugin!
Yesterday we received a warning from SEM rush, that  tags that are linking to an image will be interpreted as poor architecture by search engines. We never had this issue before, but i think this could be possibly connected to latest google algorithm update?! I don't really know, but I'll post the exact warning in the end of this post. The warning has been submitted by SEM Rush. Would it be possible, to put the image source into an attribute like data-src="/path/to/src.jpg" and the href="#" ? It seems to be an issue and maybe it's worth thinking about it. This issue is totally new for me as well and I really think it has to do somthing with the google update, since I have been using your plugin for 1-2 years, but this is the first time, we receive the warning. Please let me know what you think about this. Thank you so much and have a great day!
The warning by SEM Rush:
We detected that some links to resources are formatted with  HTML element. An  tag with a href attribute is used to link to other webpages and must only contain a page URL. Search engines will crawl your site from page to page by following these HTML page links. When following a page link that contains a resource, for example, an image, the returned page will not contain anything except an image. This may confuse search engines and will indicate that your site has poor architecture.

If SEM rush confuses image links in the  tag, use the rel = 'nofollow' attribute. This will show the search engine that this link should be ignored.GooglesBlog:

rel="nofollow": Use this attribute for cases where you want to link to a page but don’t want to imply any type of endorsement, including passing along ranking credit to another page

We ran into the same warning from SEM Rush and the nofollow attribute did not work. Would love any input as we'd really like to keep using this plugin. Thanks so much!

We ran into the same warning from SEM Rush and the nofollow attribute did not work. Would love any input as we'd really like to keep using this plugin. Thanks so much!

Do u solved this issue?

We ran into the same warning from SEM Rush and the nofollow attribute did not work. Would love any input as we'd really like to keep using this plugin. Thanks so much!

Do u solved this issue?

No, we are still having the same problem. Not a huge deal but would be interested in finding a fix.

I am having the same issue and can confirm that adding rel="nofollow" does not fix the issue in semrush. Might have to move to a different lightbox library.

Linking to an image is not poor architecture - it is a fallback to images without or with disabled JavaScript.
Completely best-practice across the web.

Linking to an image is not poor architecture - it is a fallback to images without or with disabled JavaScript.
Completely best-practice across the web.

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
Falai24, @sc0ttj, @zevaverbach, @DiSTaRUS, @yuqirose, @JustGreg, @ajitsinghkaler, @craiem, @onemouth, @rrkandala, @rjcoelho, @Band1to, @fabiofederici, @dagaa, @Madril, @lukehedger, @narze, @bylatt, @phntm7, @Zowie


Dockerfile: bump node, cli and etcher versions

Can't build the old ones anymore due to a dependency that wasn't tagged
to a specific version.
Change-type: patch
Signed-off-by: Zubair Lutfullah Kakakhel<EMAIL_ADDRESS>

Does this repo rely on using the command-line mode feature of Etcher? That was removed from Etcher quite a while ago... ping @thundron


electron-forge init ef-app fails

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
electron-forge init ef-app fails with the error: Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
An unhandled error has occurred inside Forge:
Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
Error: Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
    at C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\dist\util\install-dependencies.js:55:13
    at Generator.throw (<anonymous>)
    at Generator.tryCatcher (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\util.js:16:23)
    at PromiseSpawn._promiseRejected (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\generators.js:107:10)
    at Promise._settlePromise (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\promise.js:576:26)
    at Promise._settlePromise0 (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\promise.js:614:10)
    at Promise._settlePromises (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\promise.js:689:18)
    at Async._drainQueue (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\async.js:133:16)
    at Async._drainQueues (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\async.js:143:10)
    at Immediate.Async.drainQueues (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\async.js:17:14)
    at runCallback (timers.js:800:20)
    at tryOnImmediate (timers.js:762:5)
    at processImmediate [as _immediateCallback] (timers.js:733:5)

What command line arguments are you passing?
 electron-forge init ef-app

What does your config.forge data in package.json look like?
config.forge JSON was not generated

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.
 electron-forge init ef-app

Thanks for filing an issue! In order to help you with your problem, we're going to need more information about it. In particular:

Please run SET DEBUG=electron-forge in your command prompt (or the equivalent if you're using Powershell), re-run electron-forge init ef-app, and paste the output here.
What version of NPM are you using?

I am using npm version '5.6.0', node version 'v9.3.0'
Please note the line ‼ You are using Yarn, but not a known good version. which indicate something went awry as I am not using yarn here
The output of electron-forge init ef-app-debug follows below
H:\work\learning\electron
λ electron-forge init ef-app-debug
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
‼ You are using Yarn, but not a known good version.
The known versions that work with Electron Forge are: 0.23.3 || 0.24.6 || >= 1.0.0
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle

An unhandled error has occurred inside Forge:
Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
Error: Failed to install modules: ["babel-preset-env","babel-preset-react","babel-plugin-transform-async-to-generator","electron-forge"]

With output: Exited with status 1
    at C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\dist\util\install-dependencies.js:55:13
    at Generator.throw (<anonymous>)
    at Generator.tryCatcher (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\util.js:16:23)
    at PromiseSpawn._promiseRejected (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\generators.js:107:10)
    at Promise._settlePromise (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\promise.js:576:26)
    at Promise._settlePromise0 (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\promise.js:614:10)
    at Promise._settlePromises (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\promise.js:689:18)
    at Async._drainQueue (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\async.js:133:16)
    at Async._drainQueues (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\async.js:143:10)
    at Immediate.Async.drainQueues [as _onImmediate] (C:\Users\nik\AppData\Roaming\npm\node_modules\electron-forge\node_modules\bluebird\js\release\async.js:17:14)
    at runCallback (timers.js:773:18)
    at tryOnImmediate (timers.js:734:5)
    at processImmediate [as _immediateCallback] (timers.js:711:5)

As I am running pretty standard node environment on a Windows 10 machine, I would appreciate to know why is this most basic action failing - it may indicate that something is off on my machine.

There is no need to check that - I have both npm and yarn installed globally:
H:\work
λ yarn --version
0.16.1

Could this be the reason for my crash? I would think that electron-forge, being able to use either one, should not be confused if it finds both 😄?
electron-forge "philosophy" and worklow is brilliant, so I would gladly sacrify yarn if that is the price of using electron-forge (at least until you fix it's "confusioin")

Electron Forge prefers Yarn if it finds both Yarn and NPM on your system. You should either upgrade yarn to a known good version (0.16.1 is quite old anyway), remove yarn so that it uses NPM by default, or (globally) set the environment variable NODE_INSTALLER to npm.

@malept your instructions above are confirmed as a solution for my issue. As I have a few reasons for having to use npm in other projects, I took the simplest path, by removing yarn.
H:\work\learning\electron
λ electron-forge init ef-app
√ Checking your system
√ Initializing Project Directory
√ Initializing Git Repository
√ Copying Starter Files
√ Initializing NPM Module
√ Installing NPM Dependencies

H:\work\learning\electron
λ cd ef-app

H:\work\learning\electron\ef-app (master<EMAIL_ADDRESS>λ npm start

><EMAIL_ADDRESS>start H:\work\learning\electron\ef-app
> electron-forge start

√ Checking your system
√ Locating Application
√ Preparing native dependencies
√ Launching Application

Warning, the following targets are using a decimal version:

  electron: 1.8

We recommend using a string for minor/patch versions to avoid numbers like 6.10
getting parsed as 6.1, which can lead to unexpected behavior.

A few comments:

This gave me a boost to go ahead with my plan to create the aurelia template for electron forge
It would be really nice if you could show the (physical) time spent on building the app - I have a super fast SSD drive and it seemed that the  Installing NPM Dependencies phase took a long time.

Thanks for your immediate attention and help with this issue. We hope to pay you back by popularizing your tool in Aurelia Community

Please feel free to close this issue, hopefully with the fix for more robust handling of the decision for npm / yarn use, including the checking for minimally capable versions of both.


Fix ill-formatted YAML

Oh whoops, didn't notice this when I opened #36. 🤦♂
Do you mind adding the default updates from my PR and I'll close it?

I took Patrick's instead, it was easier :)


Push Notification not able to receive in Kill State

Hi,
you did excellent work of custom notification in android, it is awesome.
"react-native": "0.49.3",
"react-native-fcm": "^10.0.3",
this is my payload from POSTMAN
{
"to":mytoken,
"content_available": true,
"data": {
"custom_notification": {
"body": "Hello urvesh how r you",
"title": "This is notification",
"priority":"high",
"icon":"icon",
"lights": true,
"show_in_foreground": true
}
}
}
and status of my response
{
"multicast_id":<PHONE_NUMBER>991249446,
"success": 1,
"failure": 0,
"canonical_ids": 0,
"results": [
{
"message_id": "0:1509883929709513%d8a65b43f9fd7ecd"
}
]
}
everything work as expected, but i didn't receive notification when app is in kill state
I have used this
// FCM.on(FCMEvent.Notification,async (notif)=>{
................................................
// });
FCM.getInitialNotification().then(notif=>{
................................
});
Kindly please suggest

you mean notification doesn't show up?

yes
On 05-Nov-2017 8:10 PM, "Libin Lu"<EMAIL_ADDRESS>wrote:

you mean notification doesn't show up?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/evollu/react-native-fcm/issues/635#issuecomment-341977998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZa2E1VeEbQaI3wpvtSSSDS65OjYiwbQks5szcjzgaJpZM4QSXEt
.

have no clue here. can you reproduce on emulator?

hi,
I m using actual device, what should i reproduce?
On 06-Nov-2017 8:03 PM, "Libin Lu"<EMAIL_ADDRESS>wrote:

have no clue here. can you reproduce on emulator?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/evollu/react-native-fcm/issues/635#issuecomment-342165894,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZa2E7yWbCrDUGOugE7WgSFcO9bg6lNpks5szxiggaJpZM4QSXEt
.

run the app in an emulator. it can receive notifications.
If it works, then it has to do something with the phone you are using. What brand are you using?

Coolpad note5 and i will try on other devices which i have along with
emulator and let you know.
thank you for help
On 06-Nov-2017 11:30 PM, "Libin Lu"<EMAIL_ADDRESS>wrote:

run the app in an emulator. it can receive notifications.
If it works, then it has to do something with the phone you are using.
What brand are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/evollu/react-native-fcm/issues/635#issuecomment-342232599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZa2E24Tac3yU6yLpNX7x0_eo1RWeQIqks5sz0kzgaJpZM4QSXEt
.

Yes you are right. Some phone does not receive notifications and some does but why may I know the reason?

thks
On 07-Nov-2017 8:21 PM, "Libin Lu"<EMAIL_ADDRESS>wrote:
some manufacture with custom android system will have notification
permissions. check that
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/evollu/react-native-fcm/issues/635#issuecomment-342506067,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZa2E29Y_821NrzVHnbICTcmLXMfKhP2ks5s0G6OgaJpZM4QSXEt
.


Pipeline parameters aren't saving when changed

Describe the bug
In Pipeline settings, parameter JSON isn't saved (only in the client-side/local state)
To Reproduce
Steps to reproduce the behavior:

Go to any pipeline
Click on "settings"
Scroll down to "Pipeline Parameters"
Make change
Hit "Save"
Refresh

Expected behavior
Parameters should save when changed.
Screenshots
N/A
Environment

OS: [e.g. macOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Environment: [e.g. development, production, cloud]
Logs: [what do you see after running ./orchest status --ext?]# Result

Additional context
Fix coming shortly.

Good find 👍🏻


Create dallas file

Just wanted to create the first file and learn to do this via command line.

Hoping to review how to add this to the main branch.


API returns invalid JSON if count is large enough

BUG
Current Behavior

When testing signing up for as many campaigns possible in iOS app, discovered that if the count is large enough on the GET Signups index -- we get a 200 response back but with invalid JSON data. In this example, our returned response breaks in the middle of a campaign's reportback_info.copy:

https://northstar.dosomething.org/v1/signups?user=56eab76e469c6444628b60f2&count=150

Desired Behavior

Not entirely sure what the best fix here, but valid JSON

Why This Matters
This is definitely an edge case for now, but may bite us as our users signup and reportback for multiple campaigns/runs as we focus on increasing impact.  We're currently querying for 200 signups in iOS as a hack until we add paginated API requests when displaying a User's Profile.
I'd imagine (but haven't tested) that this is an issue across all Phoenix API endpoints, not just Signups. We could ballpark a max count to request, but in theory, if it's just truncating the response after some number of bytes, as @DFurnes wondered in #api Slack, we could inspect the size of our response before returning --  and instead return an error object.

Interestingly, I'm not getting this issue when making the same request against Phoenix on my local so it might be hard to debug exactly what's going wrong with this on production.
It does return a whopping 115kb of JSON though, which seems pretty outrageous. I think a good solution would be to cap the count parameter to a reasonable limit (say, 50?) and then have clients request additional pages of results when needed.


Add Contributor Guidelines

Is your feature request related to a problem? Please describe.
As a developer, it will be useful to know how to contribute to this repository.
Describe the solution you'd like
A detailed and maintained Contributor Guideline doc
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

    - [ ] Describe how data will be organized (by acquisition machine)
    - [ ] Drop test coverage down to 80%
    - [ ] Unit tests organization
    - [ ] If aind-data-schema needs to be upgraded for your package, open another ticket (dedicated engineer will do it)
    - [ ] How to organize and make a feature request


Create dependabot.yml

Dependabot creates pull requests to keep your dependencies secure and up-to-date.

I'm going to skip on this for now.


Add metric snapshot support

so that metrics on some important days can be kept for further comparison

[ ]  an API to create a snapshot on a given day
[ ] frontend page to support showing and comparing the metrics with the snaphost

provided by #695 in another way


Weblogic Docker Container exits due to Domain Write Error

Hello Weblogic Docker Team,
I am trying to run the Weblogic Downloaded 12213 domain Container in a RHEL platform (via vargrant) on my mac from the link below
https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain
After I execute the command
docker run -d --name wlsadmin --hostname wlsadmin -p 9001:9001 --env-file ./container-scripts/domain.properties -e ADMIN_PASSWORD=***** -v $PWD:/u01/oracle/user_projects 12213domain:users
Domain Home is:  /u01/oracle/user_projects/domains/base_domain
Domain Name is:  base_domain
----> 'weblogic' admin password: netcrkD0cker!
Initializing WebLogic Scripting Tool (WLST) ...
Welcome to WebLogic Server Administration Scripting Shell
Type help() for help on available commands
domain_name     : [base_domain]
admin name      : [AdminServer]
admin_port      : [9001]
cluster_name    : [DockerCluster]
domain_path     : [/u01/oracle/user_projects/domains/base_domain]
production_mode : [dev]
com.oracle.cie.domain.script.ScriptException: 60308: Domain location not writable.
60308: The domain location does not have write permission.
60308: Correct permissions or select different domain location.
at com.oracle.cie.domain.script.ScriptExecutor.writeDomain(ScriptExecutor.java:2035)
I get the following error and the container simply exits. I have verified the write permissions on the directory specified in the -v value AND also the GID and UI which matched with the container's Oracle User ID/GID of 1000.
Please let me know what should be done and I am stuck here for last three days and it has become a showstopper for my work.
I appreciate your help.
Thanks
Chad

Hi Weblogic Docker Team,
I'm encountering the same host permission issue on AWS cloud. AWS host image is built with default user ID (ec2-user) gid=1000(ec2-user) groups=1000.  Creating oracle ID on host with different UID/GID doesn't solve container permissions problem, nor does setting 777 directory permissions or ownership to oracle user. Also tried setting SELinux mode to 'permissive' without success. Do you have any suggestions on a workaround?
Thanks
Bob

That's weird, because the oracle user has the same UID/GID inside the container:
# id oracle
uid=1000(oracle) gid=1000(oracle) groups=1000(oracle)

This should work without any issue if the ec2-user has the same uid/gid.

I changed host directory owner to ec2-user(1000) and it works now. I got hung up thinking the UID/GID had to be oracle(1000):oracle(1000) on the host. Thanks for pulling me out of my rut.
Bob

You're welcome. For others watching: as long as the uid/gid are the same, the actual username on host/container don't have to match. They're purely for readability purposes.


refactor: use AlertDialog instead of BasicAlertDialog

#138  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 17, 8:36 PM PST: A user merged this pull request with Graphite.


use quickcheck_derive

I recently rewrote it so it can derive Arbitrary for enums. No shrinking yet, but this may come in a future version.

This is an interesting idea but would need to be done in terms of the arbitrary crate, at least with the current approach.

Fine with me.


Organization user creation should skip email domain whitelisting

Steps to Reproduce

Set a whitelisted email domain at organization settings page.
Try to create a user with a different email domain, at that organization, with the owner.

Current Result

Email validation error.

Expected result

User is created (we should trust the owner for creation, validation is meant for signup).

Acceptance OK! Moving to Release :)


aws_kinesisanalytics_flink: Unable to create PropertyGroups in Python

Unable to create PropertyGroups to pass to the the Flink Application in Python.
Reproduction Steps
Following the examples in the overview, I would expect something like the following to work:
Using keyword args:
        application = kaf.Application(
            self,
            "FlinkApplication",
            code=kaf.ApplicationCode.from_asset(config.asset_path),
            runtime=kaf.Runtime.FLINK_1_11,
            application_name=f"{construct_id}BeamApplication",
            auto_scaling_enabled=True,
            checkpointing_enabled=True,
            property_groups=kaf.PropertyGroups(
                FlinkApplicationProperties={
                    "input_stream_name": "my-input-kinesis-stream",
                    "output_stream_name": "my-output-kinesis-stream"
                }
            ),
        )

Or, perhaps a single dict:
            property_groups=kaf.PropertyGroups(
                {
                    "FlinkApplicationProperties": {
                        "input_stream_name": "my-input-kinesis-stream",
                        "output_stream_name": "my-output-kinesis-stream",
                    }
                }
            ),

What did you expect to happen?
Able to build PropertyGroups to pass to the Flink application.
What actually happened?
Using keyword args gives the error: TypeError: __init__() got an unexpected keyword argument 'FlinkApplicationProperties'
Using a single dict gives the error: TypeError: __init__() takes 1 positional argument but 2 were given
Environment

CDK CLI Version  : 1.94.1
Framework Version:
Node.js Version: v14.15.4
OS               : MacOS
Language (Version): Python 3.8.6

Other
Looking at the code for PropertyGroups, the constructor signature would seem to be unable to support any arguments at all:
class PropertyGroups:
    def __init__(self) -> None:
        '''(experimental) Interface for building AWS::KinesisAnalyticsV2::Application PropertyGroup configuration.

        :stability: experimental
        '''
        self._values: typing.Dict[str, typing.Any] = {}

Similarly, the Java PropertyGroup.Builder seems to be "empty", having no methods other than build().
I wonder if things are only really working for TypeScript (the language of the example).

This is :bug: Bug Report

jsii no longer supports index signatures, which means that types like
export interface PropertyGroups {
  readonly [propertyId: string]: { [mapKey: string]: string };
}

will cause lead to a compilation error, unless annotated with @jsii ignore.
To keep backward compatibility, all such types in the CDK have been annotated this way and the properties that had such types were adapted accordingly. In this particular case, as was suggested above, the type became:
interface ApplicationProps {
  ...
  readonly propertyGroups?: { readonly [propertyId: string]: { [mapKey: string]: string } };
  ...
}


Fix a race condition on reconciler finalizer removal

Previously, the reconciler is responsible for removing the reconciler finalizer from the RSync object, but if the reconciler fails to update RSync to remove the finalizer (e.g. the reconciler is deleted or the reconciler doesn't have permissions to update RSync), RSync would stuck in deletion forever.
This commit updates the reconciler-manager to remove the reconciler finalizer to unblock RSync deletion if RSync's Namespace is terminating. A side-effect of this update is that managed resouces couldn't be deleted even though the deletion propagation is set to Foreground, but since the reconciler couldn't function, managed resources couldn't be deleted anyway.
b/332940374

/hold
I need to think about this carefully and I don't really have time today.
I think there's some problems with deletion ordering that might crop up in this situation. My general suggestion would be for users not to delete namespaces with RootSyncs in them before carefully deleting the RootSync, but I understand that might be counter intuitive or surprising since everyone takes namespace garbage collection for granted.
A potentially better solution might be to add webhook that blocks namespace deletion when a RepoSync is present. Or perhaps a finalizer on the Namespace that executes before the namespace garbage collector.

After digging into this a bit more my concern is this:
Removing the finalizer on the RepoSync when its parent Namespace is being deleted DOES solve the case where deletion ordering is unimportant.
The problem with this solution is that it prevents the reconciler from even attempting to solve the harder problem where deletion ordering IS important.
Additionally, in both cases, the ResourceGroup inventory is left behind.
My counter-proposal would be to only remove the finalizer if there aren't any explicit dependencies defines in the resources being managed by the RepoSync reconciler.
To do that, the reconciler itself would need to stay in charge of removing the RSync finalizer, because only the reconciler has access to the state of the objects without having to query them all. Plus, having only one code path in charge of a specific update is a good idea anyway to avoid race conditions and simplify debugging. Since the reconciler already deletes its RSync's finalizer, we could just skip the Destroy call all together and let the namespace garbage collector handle it.
This proposal has one notable downside: The reconciler deployment needs a RoleBinding to have permission to remove the RepoSync finalizer, and that RoleBinding is also deleted by the namespace garbage collector. To avoid this I have two ideas:

Add a webhook (or a new endpoint on the admission-controller) to block deletion of the RoleBinding until after the reconciler Deployment is NotFound.
Add a finalizer to the RoleBinding until after the reconciler Deployment is NotFound.

Both of these options have pros and cons, but the webhook could be more generally useful. For example:

A webhook could block deletion of Namespaces if they contain any objects with incoming dependencies, allowing the RepoSync reconciler to delete package contents in the right order first.
A webhook could block deletion of any object with an incoming dependency, enforcing deletion ordering more widely.

In the case of namespace garbage collection, temporary deletion errors are ok, because it will just keep retrying, giving the RepoSync reconciler a chance to do it's work.
In the case where the RepoSync reconciler needs an additional user-managed RoleBinding to manage other resource types, the user could add a dependency on the RepoSync to make it depend on their RoleBinding. This way, the user's RoleBinding would also be protected the same way the default RoleBinding is protected by the webhook.

Removing the finalizer on the RepoSync when its parent Namespace is being deleted DOES solve the case where deletion ordering is unimportant.

That is the intent of this fix.

The problem with this solution is that it prevents the reconciler from even attempting to solve the harder problem where deletion ordering IS important.

It might be helpful to clarify that depends-on and deletion order shouldn't be treated as identical concepts. If deletion ordering IS important, users should leverage custom finalizers on their resources. An example is CR depends on CRD, but the deletion of CRD should not be blocked by CR.

Additionally, in both cases, the ResourceGroup inventory is left behind.

This is not correct. ResourceGroup is in the same namespace as the RepoSync. It would be deleted as well.

In the case of namespace garbage collection, temporary deletion errors are ok, because it will just keep retrying, giving the RepoSync reconciler a chance to do it's work.

In this case, no deletion ordering is guaranteed.

In the case where the RepoSync reconciler needs an additional user-managed RoleBinding to manage other resource types, the user could add a dependency on the RepoSync to make it depend on their RoleBinding. This way, the user's RoleBinding would also be protected the same way the default RoleBinding is protected by the webhook.

It is also not guaranteed that RoleBinding and RepoSync are managed in the same repo, and I don't think Config Sync supports external dependency.

ResourceGroup is in the same namespace as the RepoSync. It would be deleted as well.

I stand corrected. You're right, only the RootSync ResourceGroups are in the config-management-system.
In that case, the RepoSync & ResourceGroup being deleted at approximately the same time by the namespace garbage collector is probably good enough.
However, the other related problem is that the UI & CLI will show the RepoSync/package as deleted, but the package contents may not have all been fully deleted if they're blocked by a finalizer. So the user won't be able to use the Console Package UI or nomos status to watch the status of those objects if they have finalizers.

It might be helpful to clarify that depends-on and deletion order shouldn't be treated as identical concepts.

Yes. The primary issue here is with explicit dependencies, with the depends-on annotation, not implicit dependencies, like namespaces and CRDs.

In this case, no deletion ordering is guaranteed.

The namespace garbage collector doesn't ensure dependency deletion ordering, but we do with RSync uninstall (with the deletion-propagation annotation). In this case the two policies conflict and we lose. But it doesn't have to be that way. Just because it is this way doesn't mean it should be or that users want it this way. We can make it better!

It is also not guaranteed that RoleBinding and RepoSync are managed in the same repo, and I don't think Config Sync supports external dependency.

I'm not implying they would be or need to be. My proposal is that the webhook detect depends-on annotations and protect the dependency from deletion, even if the object wasn't synced by Config Sync. That way the reconciler-manager can add one on the reconciler Deployment -> default RoleBinding and the user can add one for RepoSync -> user RoleBinding.
In the future, we might want to figure out how to allow multiple clients to manage separate depends-on annotations on the same object to define different dependencies, but for this use case we don't need that yet.

Hi everyone!  Sorry for chiming in on this when I have not been involved in much of the technical reasoning.  We have an upcoming code freeze and therefore need to evaluate some of these decision in the light that we have deadlines pending.
Question:

Do we have ready alternatives to this?
The UX of namespace being deleted and removing all resources out of order could lead to issues, is this a risk we can take on right now and think about it later?
Is this change irreversible?  Meaning will customers take dependency on this behavior and then we are locked into this choice?

If the answers are:

We don't have alternatives at hand.
The risk is small (meaning someone who was relying on Deployment A to be deleted before Deployment B, and are upset that this is happening when namespace is deleted).
We can improve the behavior later.

I suggest merging this in and using the few days we have before the code freeze for additional testing.  It doesn't seem like we want to ship the bug that we currently have "RSync would stuck in deletion forever."

I don't really understand why y'all are in a hurry to get this half-fix in with side effects, for an issue that's existed for years, right before a code freeze, but I agree that the side effect is less bad than the current behavior.
I don't think this will be un-reversable. It's just more tech debt that will have to be reverted if we decide to later apply the more complete solution.
Anyway, I'll make another review pass today.

A few comments:

Deletion ordering is orthogonal to RSync garbage collection, because deletion can be performed by other controllers/users in the cluster, and it could happen before the RSync is being deleted. Reconciler can make sure it deletes things in order, but it can't stop others from deleting things out of order.
Apply ordering (depends-on) doesn't necessary imply deletion ordering. An example is that you want to apply CRD before applying CR, but we don't necessary want to block CRD from being deleted just because CR hasn't been deleted.
When a Namespace is being terminated, Namespace controller already handles resource deletion of everything managed by the RepoSync. It's safe and easier for reconcilers to let Namespace controller handle garbage collection.

/lgtm
I suspect we'll eventually need to revert this later when we add a more general solution that works for deletion dependencies and RootSyncs, but for now it seems like an improvement for RepoSyncs at least.
I left some minor comments, but overall it LGTM.
I would also suggest including the NamespaceTerminating part of https://github.com/GoogleContainerTools/kpt-config-sync/pull/1194 in this PR, so that they can be pulled out together, if necessary, since they cause the same side effect. But it's not necessarily a blocker.
Feel free to remove the hold when the comments are addressed.

/unhold
#1194 is related, but a different issue. It shouldn't block this.

/lgtm


Getting Typescript Error

I am getting this error:
Uncaught (in promise) TypeError: Spread syntax requires ...iterable[Symbol.iterator] to be a function
I attached our implementation along with where in the JS it is breaking
This seemed to have started without any code changes and the version of googlemutant also wasn't changed (2.0.0)
Edit: This error is also on the sample project

Having same issue

Having same issue

Managed to solve it by adding styles: [] in options


Implement MotionRuntime.interactions() API

Summary: Fetches interactions asociated with a givent target.
Fixes https://github.com/material-motion/material-motion-android/issues/74
Tags: #material_motion

New runtime.interactions(view, Draggable.class) API as discussed in Discord.


Intellij - Autosuggestion not working without explicit @effect-ts/system install

In Intellij Idea  typescript only detects the direct exports from @effect-ts/core/effect, not the re-exported modules from @effect-ts/system (See below)
Without explicit install only direct exports are found:

With explicit install, re-exports from system are found:

Debug:

The dependency @effect-ts/system is  indeed installed
Autosuggestion works fine in vs code
I haven't had this problem with any other package but effect-ts relies heavily on re-exports
Deps: @effect-ts/core (latest)  typescript (4.5.2)

Possible Solutions
Simply add the package as an explicit installation in the Readme "How to install" section.
Drawbacks:

Freezes the dependency on system which could hurt later if you plan on changing how things work
Won't hurt anyone but this is solving a few people's problem by making everybody "pay"
Advantages:
Won't hurt anybody 🤷♂

I haven't been able to solve the issue any other way (editor config) for now.
If this works for you the PR #1004 is already opened :)

I ran across this problem as well today. I have created a bug report with intellij, as this is not a problem with effect, but rather of the ide: https://youtrack.jetbrains.com/issue/WEB-62911/Imports-from-subdependency-not-resolved-autosuggest-not-working


Optimisations for /v3/roles API calls

This PR optimizes the speed of requests to /v3/roles by:

Removing unnecessary checks when creating space roles, reducing the number of expensive DB queries.
Avoiding a number of expensive DB queries that were run on all create calls by where a user guid was provided, which were aimed at determining whether the assignee user was in the same org as the user trying to assign them a role.
Retrieving the org_guid used in destroying a role more efficiently, by joining two tables rather than running separate queries.

The second commit (ed19bdbe) ends an inconsistency whereby org managers received a 201 if they assigned an org role to an unaffiliated user by providing that user's username, but a 422 CF-UnprocessableEntity if they tried to do the same by providing the user's guid. See an example below of the previous behaviour (now corrected).
Org manager setting an org role on a user outside the organizaition when providing the user's guid:
$ cf curl -X POST /v3/roles -d '{
>       "type": "organization_auditor",
>       "relationships": {
>         "user": {
>           "data": {
>             "guid": "6823285a-51d3-47de-989b-51d6b9bd834f"
>           }
>         },
>         "organization": {
>           "data": {
>             "guid": "550d3635-3ae8-481e-ad2a-c150ec45d910"
>           }
>         }
>       }
>     }'
{
  "errors": [
    {
      "detail": "Invalid user. Ensure that the user exists and you have access to it.",
      "title": "CF-UnprocessableEntity",
      "code": 10008
    }
  ]
}

Org manager setting the same org role on the same user, still outside their org, by providing their username:
$ cf curl -X POST /v3/roles -d '{
>       "type": "organization_auditor",
>       "relationships": {
>         "user": {
>           "data": {
>             "username": "lame"
>           }
>         },
>         "organization": {
>           "data": {
>             "guid": "550d3635-3ae8-481e-ad2a-c150ec45d910"
>           }
>         }
>       }
>     }'
{
  "guid": "277ff39c-d8ac-4c1e-a118-32cee054e882",
  "created_at": "2022-09-15T13:54:32Z",
  "updated_at": "2022-09-15T13:54:32Z",
  "type": "organization_auditor",
  "relationships": {
    "user": {
      "data": {
        "guid": "6823285a-51d3-47de-989b-51d6b9bd834f"
      }
    },
    "organization": {
      "data": {
        "guid": "550d3635-3ae8-481e-ad2a-c150ec45d910"
      }
    },
    "space": {
      "data": null
    }
  },
  "links": {
    "self": {
      "href": "https://api.cf.azure-dev24.azure.cfp.sapcloud.io/v3/roles/277ff39c-d8ac-4c1e-a118-32cee054e882"
    },
    "user": {
      "href": "https://api.cf.azure-dev24.azure.cfp.sapcloud.io/v3/users/6823285a-51d3-47de-989b-51d6b9bd834f"
    },
    "organization": {
      "href": "https://api.cf.azure-dev24.azure.cfp.sapcloud.io/v3/organizations/550d3635-3ae8-481e-ad2a-c150ec45d910"
    }
  }
}

[X] I have reviewed the contributing guide

[X] I have viewed, signed, and submitted the Contributor License Agreement

[X] I have made this pull request to the main branch

[X] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

based on this comment from the initial implementation of the 'assign by username' story
 If an org manager tries to add an org role to an unaffiliated user by guid I think either of the following is fine:

1. They get a 422 and "Invalid user..." error
1. The requests succeeds and the role is created
I would go with whichever is easier for y'all. It should be basically impossible for an Org Manager to discover an unaffiliated user guid by themselves, so this case should be very rare.

I think it's fine to open up the user guid as choice for adding users outside the org.


Attempted fix to humanoid gifs in the docs

Codecov Report

Merging #73 (633e323) into main (28faa4f) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   26.32%   26.32%
=======================================
  Files          22       22
  Lines        5021     5021
=======================================
  Hits         1322     1322
  Misses       3699     3699


Hangs on the second question.

When running
yo ng2-alfresco-app
it asks "How would you describe the app? (Alfresco Angular 2 Application Example)"
and no matter what I do I can't get past this step.
DEBUG=yeoman:generator yo ng2-alfresco-app ? What's the name of your App? test   yeoman:generator Running default +1s Your generator must be inside a folder named test I'll automatically create this folder.   yeoman:generator Running askFor +5ms ? How would you describe the app? (Alfresco Angular 2DEBUG=yeoman:generator yo ng2-alfresco-app  Application Example)
Using:
node: 8.1.0
npm:5.0.3
yo: 1.8.5 (tried 2.0.0 with the same issues)

@magp3 can you try to use node 7?


Support for Visual Studio Build Tools?

Is it planned to support the Visual Studio Build Tools as well?
This would allow us to automatically keep our Build Servers (with only Build Tools installed) updated when running vs update via a Scheduled Task.

Very good question. Could you point us to some info on how automated installation of that SKU can be done?
Thanks!

I would say some information could be derived from the Chocolatey package which allows installation of the Visual Studio Build Tools as well:
https://github.com/jberezanski/ChocolateyPackages/tree/master/visualstudio2019buildtools
Respectively the VS Installation Module which provides helpers for that task:
https://github.com/jberezanski/ChocolateyPackages/tree/master/chocolatey-visualstudio.extension/extensions

ok, found what I was looking for:
https://github.com/jberezanski/ChocolateyPackages/blob/master/visualstudio2019buildtools/tools/ChocolateyInstall.ps1#L4

https://aka.ms/vs/16/release/vs_buildtools.exe

Installing it seems like it would be relatively easy to do (maybe vs install build?). But investigating how to do the updating seems more involved.
If you could come up with a PR, I'd be glad to review and merge it.
Thanks!

@kzu I created a PR for it. Please let me know if something else needs to be changed. ;)


[Tutorials] Update the SDG tutorial and expose the inference endpoint

Description
This PR ensures that users can run the PEFT SDG tutorial using arbitrary API endpoints by exposing the URL that is used for synthetic data generation.
Checklist

[X] I am familiar with the Contributing Guide.
[X] New or Existing tests cover these changes.
[X] The documentation is up to date with these changes.

Also fixed the DCO check. Looks like I forgot the -sS flag when committing.


chore/schema improvements

chore(schema): schema improvements
chore(schema): revert $schema back to 2020-12

@mason-org/triage notify(Reason::NewPullRequest)
This comment ensures a notification is delivered to maintainers.
 🤖 This is an automated comment.    📖 Source code


Corporate Console - Add Company Notification

Corporate Console - Company Search - Add Notification
This feature adds additional user feedback once the user adds a company.
Background
The current implementation does not provide guidance or steps on how to proceed after the user adds a new company.  The redesigned UI will include the updated user experience which shows a pop-up dialog indicating:
Success!
Your company  is added to EasyCLA!
As the individual who created the company, other company CCLA managers and signatories may request to join this company.  Please respond to these requests by following the links in the notification emails.
User Story
As a CCLA Signatory:

I need to know what my responsibilities are as a CCLA Signatory so that I approve access to the company for others in a timely manner.
I need to know what the next step is after I have the access I need for my company within EasyCLA so that I can sign for my projects quickly and easily

Tasks

Update UX to include a confirmation dialog box

Acceptance Criteria

UX provides the above features and works as advertised
Project manager review and sign-off
Demonstrate the set of capabilities to the product team while the code is
running in the STAGING environment.

References
Corporate Console - Join or Add Company - https://confluence.linuxfoundation.org/pages/viewpage.action?pageId=28484537#PRD-EasyCLAv1Performance&UIUpdates-CorporateConsole.1
Related
Frontend search/add company issue: https://github.com/communitybridge/easycla/issues/158

This issue is duplicated by #361 and #362 . Hence closing


Fix throwing out bug (#1)

This commit fixes the throwing out issue (#1) I made about a week ago. This might be out of line with some of the rest of the code which uses UInt instead of Floats, but for some reason, this works. I didn't do much testing as to why this works and UInt doesn't. This issue is pretty annoying as the UI doesn't correctly recognise that you've thrown out just that one item.
If you don't want to merge this because it uses Float instead of UInt, let me know and I will probably look into it further.

Turns out my fix didn't work, so I'll try and get it fixed again

Okay, this should now hopefully be fixed. I forgot to add a float on the net function on the serverside so the client would update but the server would not

I'll just close this since each time I think it's done I'm just experiencing the fact it's still not fixed with my own edits.


mission-center: 0.4.5 -> 0.5.1

Description of changes
Changelog: https://gitlab.com/mission-center-devs/mission-center/-/releases/v0.5.1
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GaetanLepage do you think it would be possible to see with upstream if we can change their systemd detection? Right now the feature of seeing systemd services doesn't work on NixOS, as they use /lib/systemd/systemd to see if the current system is running systemd.

Yes, that would be nice indeed. Could you please open an issue on their GitLab for this ?

@GaetanLepage done in https://gitlab.com/mission-center-devs/mission-center/-/issues/224


metrics add bvar for load stream and file writer count (#36300)

Add following bvar:

load_stream_count
load_stream_writer_count
load_stream_file_writer_count

run buildall


[CARBONDATA-3863], after using index service clean the temp data

Why is this PR needed?
each query that use index server will create a folder under /tmp/indexservertmp. but when query finished the folder will not be delete. therefore as the number of queries increases, the folders in /tmp/indexservertmp will increased. then will get the directory item limit.
What changes were proposed in this PR?
after query finished delete the folder that created.
clean the /tmp/indexservertmp after index server restart.
run a thread that will delete the folder in /tmp/indexservertmp that has existed for more than 3 hours.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3441/

@MarvinLitt , please add proper description as to why this PR is needed and what changes are proposed

@MarvinLitt , please add proper description as to why this PR is needed and what changes are proposed

done

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1757/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3499/

retest this please

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1767/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3509/

@kunal642 @vikramahuja1001  please check this pr

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3703/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1964/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3710/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1971/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3752/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2011/

LGTM


elasticsearch 7.8.0 or newer

Hello,
I try to import the geonames from the tar.gz into Elasticsearch 7.8.0 but this seems to fail. My question is, is it possible to support new elasticsearch versions or a more generic data format for importing?
Thanks

It's certainly possible! The code for building the ES index with geonames lives here: https://github.com/openeventdata/es-geonames. I've pinned the Elasticsearch version to 5.5.2 because the API changes slightly after that, but I would welcome a PR to bring it up to a recent version of ES!

It's certainly possible! The code for building the ES index with geonames lives here: https://github.com/openeventdata/es-geonames. I've pinned the Elasticsearch version to 5.5.2 because the API changes slightly after that, but I would welcome a PR to bring it up to a recent version of ES!

For me two question are interesting:

why did you use ES, because the index structure depends on a web application with a REST API http://www.geonames.org/export/web-services.html so I can query the REST API direct without hosting elastic search. IMHO it could be nice to put a datasource for solving the geo name references and two implementions ES or REST API
A more flexible data structure would be nice, because If I would like to search for historic names, based on this another storage system like Postgresql / PostGIS or MongoDB can be used

For me two question are interesting:

why did you use ES, because the index structure depends on a web application with a REST API http://www.geonames.org/export/web-services.html so I can query the REST API direct without hosting elastic search. IMHO it could be nice to put a datasource for solving the geo name references and two implementions ES or REST API
A more flexible data structure would be nice, because If I would like to search for historic names, based on this another storage system like Postgresql / PostGIS or MongoDB can be used

I use ES because I wanted fuzzy matching, which is especially important for transliterated placenames, and because an early deployment of Mordecai used several workers that shared a single ES node. I don't want functionality to call Geonames directly because I don't want to put bandwidth costs on them.
I think historical queries would be really cool and I think you could build something like that in Postgres, Mongo, or ES.

I use ES because I wanted fuzzy matching, which is especially important for transliterated placenames, and because an early deployment of Mordecai used several workers that shared a single ES node. I don't want functionality to call Geonames directly because I don't want to put bandwidth costs on them.
I think historical queries would be really cool and I think you could build something like that in Postgres, Mongo, or ES.

historic data would be quite nice


<Input> should allow null for @value

app/components/setup-manual.hbs:9:10 - error TS2322: Type 'string | null' is not assignable to type 'string | undefined'.
  Type 'null' is not assignable to type 'string | undefined'.

9         @value={{this.appName}}

      <Input
        @value={{this.appName}}
      />

Is it documented anywhere that <Input> accepts null as a value?

It seems to work, but maybe it's bad that we're doing it :)

Docs don't say anything about allowed values at all except to imply that at least a string is acceptable. https://api.emberjs.com/ember/release/classes/Ember.Templates.components/methods/Input?anchor=Input

In theory @value can take any value and will just do a string coercion on it. However, I see the value in limiting it to string since @value is two-way and any returned value will be a string.


Reconsider readoly list in ViewList<T, K>

Readonly removed, but add the Refresh feature that #19 mentions


Add Amplitudes and PulseParametrizations

This implements non-trivial control amplitudes such as LockedAmplitude, ShapedAmplitude, ParametrizedAmplitude. The latter allows for a more general implementation of pulse parametrization, e.g. SquareParametrization, TanhParametrization, TanhSqParametrization, LogisticParametrization, LogisticSqParametrization. These have been brought over from the Krotov package. However, the concept is now rephrased from ϵ(u(t) to a(ϵ(t). Thus, the fields of PulseParametrization have changed names accordingly.

This should enable pulse parametrization in GRAPE (not tested)


Paper Issue

Hello,
I realized that in the section 4.1 of the paper you wrote:
We used the Universal Dependencies Treebank UD v2.1 (Nivre et al., 2017) for our experiments.
We picked four low-resource/high-resource language pairs, each from a different family:
Danish/Swedish (DA/SV), Russian/Bulgarian (RU/BG), Finnish/Hungarian (FI/HU),
Span- ish/Portuguese (ES/PT). Picking languages from different families
would ensure that we obtain results that are on average consistent across languages.

However, as far as I understand from tables and the code, it should be:
...picked four high-resource/low-resource language pairs,...

or more clearly:
...picked four source/target language pairs,...

isn't it ?

any comment? @chaitanyamalaviya


Pull value from input to use in s-vars

Loving Spring, it's proving to be a powerful addition for not only functionality but also time saving!
Is it possible to grab a value from an input to hand off to s-vars and s-push-url–something like the below.
<input class="border-2 border-gray-mid bg-white h-10 px-5 pr-16 rounded-lg text-sm focus:outline-none w-full" type="search" name="f_search" placeholder="Search">
<button
    sprig
    s-vars="f_keyterms:[name=f_search]"
    s-push-url="?f_keyterms=[name=f_search]"
>
    Search
</button>

Examples on htmx utilise hx-post, but I don't want to be making a post request. In my use-case I am building out a stack of filters, like so:
{% set f_dates = craft.app.request.getParam('f_dates') ?? null %}
{% set f_keyterms = craft.app.request.getParam('f_keyterms') ?? null %}

{% for date in dates %}
    <span
        sprig
        s-vars="f_dates:'{{ f_dates }},{{ date }}',f_keyterms:'{{ f_keyterms }}'"
        s-push-url="?f_dates={{ f_dates }},{{ date }}&f_keyterms={{ f_keyterms }}"
    >
        {{ date }}
    </span>
{% endfor %}

<input type="search" name="f_search" placeholder="Search">
<button
    sprig
    s-vars="f_dates:'{{ f_dates }}',f_keyterms:[name=f_search]"
    s-push-url="?f_dates={{ f_dates }}&f_keyterms=[name=f_search]"
>
    Search
</button>

So you can build up a list of various filters–and I want to be able to pass the value of the input into the list of filters, too
Thanks!

I'd recommend reading about how component variables work in Sprig work if you haven't already.
Instead of:
{% set f_keyterms = craft.app.request.getParam('f_keyterms') ?? null %}

You can write:
{% set f_keyterms = f_keyterms ?? null %}

And if you want the value of the input field to be assigned to the variable f_keyterms then I would suggest you simply rename the input field, as that will become available as a variable when the component is refreshed:
<input type="search" name="f_keyterms" placeholder="Search">
```.

Cool, thanks Ben. The below is sending the value of the field to s-vars and is available on the parent template, but how can I get it into s-push-url too, so the URL can be shared or other filters can be chained?
<input type="search" name="f_keyterms" placeholder="Search">
<button
    sprig
    s-vars="f_keyterms:'{{ f_keyterms }}"
    s-push-url="?f_keyterms={{ f_keyterms }}"
>
    Search
</button>

When I commit a search, the URL gets updated to whats-on?f_dates=&f_keyterms=, but the f_keyterms variable is available and loads correctly

However if I then select a different filter, the URL gets updated to whats-on?f_dates=01.01.2020&f_keyterms=12345, but the variable stops being available on the template

If I reload the page with the URL params intact then both of the filters show correctly.

The input field is what is holding and sending the value of f_keyterms, not the s-vars attribute.
Given your markup, I'm not sure whether you can use s-push-url to dynamically push a value into the URL from another element. You may want to read up on hx-push-url and you could ask in the htmx discord server, but you may find yourself having to use htmx events to achieve this. Check out the example at https://putyourlightson.com/sprig-cookbook#refreshing-components

FYI a new sprig.pushUrl function has been added in 1.1.0.
{% do sprig.pushUrl('?page=' ~ page) %}


Update shared responsibility

Some PaaS services are incorporating with network for example Azure App Service Environment (dedicated virtual network), or Azure Storage and Azure SQL Database (service endpoint to control inbound).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e97e5ffd-b094-f193-058b-03647ece4bb8
Version Independent ID: 81fca061-3a10-f425-1ab0-d52c21f37f4d
Content: Security best practices for IaaS workloads in Azure
Content Source: articles/security/azure-security-iaas.md
Service: security
GitHub Login: @barclayn
Microsoft Alias: barclayn

@thuansoldier Thanks for the feedback! We are currently investigating and will update you shortly.

@thuansoldier Is there a specific section of the documentation that you are referring to? I need some additional information to understand the issue. Thank you, Mike

Thank you. I am back in the office and I will look into getting this updated.

This was updated via https://github.com/MicrosoftDocs/azure-docs-pr/pull/39215

#please-close


Allow one timestamp per request

Closes gh-123

@aendrew Please, have a quick review of this PR.

@AurelioDeRosa LGTM — am guessing this is because the cache buster was adding itself multiple times?
:+1: :ship: :shipit:  Merge at will!

Exactly


[ZEPPELIN-6089][INFRA][FOLLOWUP] Consider multiple digits when comparing version numbers

What is this PR for?
This PR fixes some issues in the dev/merge_zeppelin_pr.py to make it smarter in suggesting "backport branch" and "fixed versions".

improve the x.y.z version comparing
For versions: ["0.9.1", "0.10.1", "0.11.3", "0.12.0"]
Previously, it was a simple string comparison, so the desc sorted result is ["0.9.1", "0.12.0", "0.11.3", "0.10.1"]; this PR changes it by interpreting each x, y, z as an int value and comparing sequence, thus the desc sorted result is ["0.12.0", "0.11.3", "0.10.1", "0.9.1"]

improve the branch-x.y branch comparing
similar to 1, branch-0.10 is higher than branch-0.9

dedup found_versions
before
Enter comma-separated fix version(s) [0.12.0,0.12.0]:

after
Enter comma-separated fix version(s) [0.12.0]:

What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6089
How should this be tested?
Manually tested by using the updated script to merge three PRs.
Screenshots (if appropriate)
Questions:

Does the license files need to update? No.
Is there breaking changes for older versions? No.
Does this needs documentation? No.

cc @jongyoul, the script is borrowed from spark, so far, all spark versions x.y.z match \d.\d.\d so issues 1 and 2 do not affect spark. issue 3 should affect spark too.


Updating ARTRealtimeChannel’s options doesn’t update the options of its ARTRestChannelInternal

When calling -[ARTRealtimeChannel setOptions:callback:], the passed options are not used to update the options of this instance’s REST channel. This means that, for example, if we update the realtime channel’s cipher options, these options will not be used to decrypt messages subsequently fetches using the -history:* methods.
I think this is something we missed when doing #1207.
This is causing https://github.com/ably/ably-flutter/issues/296.
┆Issue is synchronized with this Jira Uncategorised by Unito

I guess the spec (RTL16, Realtime Channel#setOptions) does not explicitly state that the client library should also synchronise this across to the REST side. 🤔
There is, of course, the equivalent method for REST specified by RSL7. And I note that in the IDL there is an obscure note against RestChannel#setOptions:

asynchronous return value for compatibility with RealtimeChannel#setOptions; not required for REST-only libraries

I think there may be room for a spec improvement once this bug has been fixed.

I think that the fact that the realtime class wraps an instance of the REST class is kind of an implementation detail; I don't think that the spec makes this explicit. So I suppose there's no reason to expect it to mention it. Perhaps the spec should however be explicit that the history calls need to make sure they respect cypher params that were passed to the top-level channel (be it realtime or REST). (Perhaps it already is, I've only scanned.)

FYI, @paddybyers @SimonWoolf - in case you have any thoughts and/or historical context to share around this. Thanks.

I think that the fact that the realtime class wraps an instance of the REST class is kind of an implementation detail

Yeah, the libs I'm more familiar with don't do this, they have a realtime channel subclass the rest channel. The idea that the spec should state that "the client library should also synchronise this across to the REST side" seems weird to me -- as far as the spec is concerned a channel is a single entity, if a lib wants to implement that with multiple different objects that's fine, but it's then its responsibility to not let that affect user-visible behaviour


Translations update from Hosted Weblate

Translations update from Hosted Weblate for Autohide Battery<EMAIL_ADDRESS>Current translation status:

@yakushabb thank you!


[Bug]: Captcha service AZcaptcha not correct request

Version of the software
0.1.26
Operating system
Windows 10
Browser / Native
91
What happened?
A bug happened!
Not send request to AZcaptcha.com website. all request send to 2captcha.
Relevant LoliCode if needed
No response

OB uses the CaptchaSharp library to solve captchas so you should open the issue on the other repository, thank you
https://github.com/openbullet/CaptchaSharp
In addition, I have no api key to test this. Since you seem to be using the official AZCaptcha account, please send me a temporary key via email at ruri (at) openbullet [dot] dev so that I can properly debug the issue, thank you!

Please try api key nwytblzqfzhfnd346wkjvrxx2m8c9gyp

@AZcaptcha I fixed the issue, the fix will be in the next version of OB2


corrupt jarfile

anytime i try to run a build of nekodetector i get this error

Error: Invalid or corrupt jarfile NekoDetector.jar

running the tagged release with java 17 on arch linux

never mind an old github action build was the broken one, i had never deleted it


feat: add :panda_face:

Hello!
I pretty need more friends so that's why I'm opening this PR :v:
Resolve #1

Your pull request needs further work because of the following reason(s):

Your file does not clearly show a link to your github profile.

Once you have resolved the issues, comment on this request to be re-judged
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

03d693530649562d68af33aeb99cec1a71f3e8ce

This PR has been idle for more than 24 hours, and will now be closed. Feel free to re-open.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

0e0bc09dbaff1cc3f1b2bb893ba31beea87416c7


Rename Investigator methods

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a17eb22) to head (2e3ae36).

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #13   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        25        25
===========================================
  Files              4         4
  Lines             87        87
===========================================
  Hits              87        87

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Prevent AGIMUS From Responding To Stuff Like "nice bottle"

It's been funny, but this often just causes confusion and derails a conversation so I think it's time to add terminators for the bot autoresponse to condemnation/praise.

Would be nice if we also accepted it with spaces on either side, so that sentences like "He's a bad bot, but we still like him" will fire even without a period of EOL


CSS fixes and improvements

docs are about to be migrated to gh-pages and the css/layout (jekyll) will be fully exposed
quick list of improvements:

[ ] link visibility
[ ] code blocks could use definition, perhaps a thin outline (like discourse/slack)
[ ] table formatting is totally messed up

vertical spacing is also taller than expected, which MacDown presents a bit cleaner. FAQ, for example:

vs.

this screenshot also shows a nice rendering of a code block


Training an encoder using pretrained StyleGAN

Hi,
I wanted to ask if there are any pretrained models linked with this repository that do not include the encoder. The one linked with the repository readme ("styleganinv_face_256.pkl") has an encoder as well and when I use it for the train_encoder,py script, it unpacks 4 values (E, G, D, Gs) whereas in the code (training_loop_encoder.py - line 122), it expects 3 values (G,D,Gs). I fixed it by changing training_loop_encoder.py - line 122
from:
G, D, Gs = misc.load_pkl(decoder_pkl.decoder_pkl)
to:
_, G, D, Gs = misc.load_pkl(decoder_pkl.decoder_pkl)
However, I am not sure if there are other models available that fit with the original code. I would appreciate any comments regarding this. Thank you.

The "styleganinv_face_256.pkl" file contains the encoder we have already trained. If you want a model with three values (G, D, Gs), you could train it yourself following the instruction in README.md.

Thank you.


d3act is incompatible with React 0.14.0-rc1

Currently it's not possible to use d3act, it fails as follows:
Uncaught Error: Invariant Violation: Chart.render():
A valid ReactComponent must be returned.
You may have returned undefined, an array or some other invalid object.

We are definitely not returning undefined or an array, so for whatever reason it looks like an invalid object is returned from Chart.

Supported as of v1.0.0.