type checking after instainceOf condition is working incorrectly

this example works great
function test(value: string[]| string){
	var result: string;
	if (value instanceof Array){
		result = value.join('');
	}
}

but this
interface IFoo {
	value: string[] | string;
}

function bar(options: IFoo) {
	var result: string;
	if (options.value instanceof Array) {
		result = options.value.join('')
	}
}

property join does not exists on type string[] | string
i think i'ts compiler mistake

I maybe wrong, but I don't think the type narrowing will work on complex types like that, I would suspect because it would over complicate what the compiler would have to keep track of, duplicating the complex type and then narrowing the one element of the type...  In order to get it to work, you should try something like:
interface Foo {
  value: string[] | string;
}

function bar(options: Foo) {
  let result: string;
  const value = options.value;
  if (value instanceof Array) {
    result = options.value.join('');
  }
}

@kitsonk , thank you for your answer!
I agree that, this checking is more harder, but i think it's more usefull for developers.
In your solution you added const value only for force compiler to check. I think it's not good idea

looks like a duplicate of #4297


Update sbt-scalajs, scalajs-compiler to 1.3.1

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler

from 0.6.33 to 1.3.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-major

Superseded by #104.


Eradicate Compiler Warnings

Remove all the compiler warnings, by fixing the underlying problems.
Hi together,
my compiler (make release=1) at Raspian (ARM) produced this warnings. Is this possibly relevant for you? Or is it not important?

source/OSSupport/IsThread.cpp: In constructor ‘cIsThread::cIsThread(const AString&)’:
source/OSSupport/IsThread.cpp:56:15: warning: converting to non-pointer type ‘pthread_t {aka long unsigned int}’ from NULL [-Wconversion-null]
source/OSSupport/IsThread.cpp: In member function ‘void cIsThread::Stop()’:
source/OSSupport/IsThread.cpp:114:18: warning: NULL used in arithmetic [-Wpointer-arith]
source/OSSupport/IsThread.cpp: In member function ‘bool cIsThread::Wait()’:
source/OSSupport/IsThread.cpp:128:18: warning: NULL used in arithmetic [-Wpointer-arith]
source/OSSupport/IsThread.cpp:148:14: warning: converting to non-pointer type ‘pthread_t {aka long unsigned int}’ from NULL [-Wconversion-null]
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-tautological-compare" [enabled by default]

I don't think this issue qualifies as "easy", since quite often the warnings have a rather twisted reason and fixing them takes a lot of thought about the possible corner cases.

Close?
This is a recurring issue not a one-time fix.

#2070 adds some significant changes to how -Werror is handled in the builds system, which prevents warnings from being reintroduced into fixed files. So it will be a one-time fix.

We now have a lot of low hanging fruit. Particularly -Wshadows, -Wold-style-cast, -Wmissing-prototypes and -Wmissing-variable-declarations.

I guess I will claim ownership of this one since I started working on reducing warning messages.

I think this can be considered complete, with #3346 merged.


feat: visibility for impl functions

Description
Problem
Part of #4515
Summary
After searching for a while I found that to make this work we only needed to change one line 😊
Additional Context
I didn't include tests for now, but I'll add them later because we first need to figure out which impl functions should be marked as pub or pub(crate) in the stdlib. I'm not familiar with the stdlib though I probably can't do it. That said, if you open the standard library with a nargo compiled from this PR you already get some warnings, so those functions should at least not be private.
Documentation
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

turbofish_numeric_generic_nested_call is failing so it seems like private impl functions cannot be called from the same module (i.e. the functions are private to within the impl rather than to the module in which the impl sits)

Ah, right. I just bumped into this while trying to add some visibilities. It seems that also U128::method fails if you are inside U128, but it doesn't fail if you do Self::method 🤔 I'll take a look 😄

Done! All tests pass now. I think there are still some fns that could be made pub.

I think I got it now! 😄

I noticed that visibility isn't checked for the new TypePath, which is something like Field::from_le_bytes where what's before :: isn't a Path but a Type. That requires different code to do it so I'd prefer to do it in a separate PR.

Yeah, there's a good amount of stuff broken with type aliases due to this, a lot of issues related to type aliases stem from this https://github.com/noir-lang/noir/issues/4469

I see.
Well, this is ready for review in case you want to take a look at it.


Progress bar

Please review as per story #46
Screenshots here:

A single progress bar design should be sufficient.  (Alpha colour)
I'm not too keen on the 3d effect, the rest of the design in Nebula is flat so we should keep that consistency - can be achieved by dead stops between the colours.
We also won't need a label for the progress bar.  Consumers can add labels to the outside themselves if necessary.  Also would be good to see how it looks with a less intense colour variation i.e. rather than colour alpha and white try colour -alpha and lighten($color-alpha, 15%) for example.

Have updated as per comments above, screenshots here:


Fixed tests.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Of course the composer.json we will adjust it once merge https://github.com/yiisoft/db/pull/240


Switch to structured cucumber configuration

Better that trying to tie a command line together.

Hey @benallard - I like this proposal, thanks! Could you maintain the comments in the code listing, though?
Also, to stop the commit message linter complaining, could you please follow the conventional commits format? For example:
docs(website): switch to structured cucumber configuration

Thanks!

I addressed the comments, but the linter is still not happy.

Hi @benallard,
seems rules are strict 😏
https://github.com/serenity-js/serenity-js/actions/runs/8753240513

Guess, the first letter should not be a capital letter.


Zendesk reference

https://github.com/fivetran/dbt_stripe/blob/0fca4f35a333187953443f03bdcf323c1dc77ecf/dbt_project.yml#L17-L30
Could this be correct referencing zendesk inside dbt_stripe repo?

Hi @dimoschi thanks for opening this issue!
You are correct, that is incorrect zendesk referencing and must be changed to stripe. I will open a PR to fix this today. Thanks!

Hi @dimoschi, thank you again for catching this issue!
I have since been able to merge the PR mentioned above and cut the new v0.4.1 release for the Stripe package which includes the updates. The release should be live on the dbt hub come Monday.
I will close the Issue as we have been able to implement the quick bug fix. Please feel free to reach back out if you have any further questions.

Thank you for the immediate response.


Add private endpoints to websockets

Futures websocket cannot accept api and secret key so cannot subscribe to private data as user info

https://github.com/Binance-docs/binance-futures-connector-python/blob/main/examples/websocket/futures/user_data.py
Please check this example for how to subscribe user data stream.


Return single item after deleting single item

Same as https://github.com/Vincit/objection.js/issues/423, but for delete:
// expected
const user = await User.query().where('id', id).first()
const deletedUser = await user.$query().delete().returning('*')

// current
const deletedUser = await user.$query().delete().first().returning('*')

Currently, this returns an array, even if I use first in the first query. It would be great to return a single item when first was used.

I'd merge a PR for this.

@koskimas sure, I can give it a shot next week.


refactor(logger): add abilit to desable logger based on a flag “isEna…

…bled”

Can you please review this PR, I've updated it

@re2005
Thanks for the update. I like the pull request for the isEnabled flag. The file with examples I don't really understand. I pushed some updates that you have to merge with pull request. Could you please create a new pull request with :

The code for the isEnabled flag.
Valid commit messages ( correct english ).


Fix plugin script classes defined even if inactive.

Currently, script classes will always be registered no matter where they are defined in a project. This change correctly filters out scripts from being registered if they are in a plugin's subdirectory and if that plugin is inactive.

Related: https://github.com/godotengine/godot/pull/31401#issuecomment-522271899

This effectively implements that comment @aaronfranke. It's the EditorFileSystem changes that filter plugin-based script classes out of the registration process (which is what everything else, including CreateDialog, bases its script class awareness off of).

Could be a starting point for https://github.com/godotengine/godot/issues/19178#issuecomment-471099148 ?

Thanks!

@willnationsdev This PR prevented VisualShaderNodeCustom's to be loaded from addon subdirs. Can you make a fix PR ?

@Chaosus I'm confused. Do they use the script class system? And shouldn't they be blocked from being used anyway unless their relevant addon has been enabled?

They are not connected to plugin system but registered through class_names.

@Chaosus So, what would be the best fix for this then? Should I just add an exception to a specific type of resource?

I dont know - they are used standart *.gd extension so need to check if they are derived from VisualShaderNodeCustom anyways.

@Chaosus Ahh, ok. So it could be any type of script, so long as the base native class is VisualShaderNodeCustom.

Yeah

@akien-mga I would just revert this commit for now. I'm trying to break down a good "fix" for this, except that you either do or don't want an addons script classes to be registered by Godot. And if the addon doesn't provide a plugin, then there is no interface in the ProjectSettings by which to mark the addon as active/inactive (because it marks plugins, not addons).
Better to let them all through for now until we update the GUI to be able to toggle script classes contained in addons that don't have plugins.

Might also make sense to put these kids of changes on the 4.0 milestone and do them alongside an overhaul to the addon system as discussed in https://github.com/godotengine/godot-proposals/issues/22

Alright, reverted as discussed above.


Fix non updating behaviour when editing VSCode

Looks like the @tracked property of card is was not being updated
This handles the case where a person edits the monaco editor on the LHS and the CardEditor (isolated, edit) will update.

Probably a nicer way to do e17c11e. That was the main reason why the indexer was not updating
What I want to check is how to update the catalog entry UI in the bottom rhs

This branhc is outdated. Will start working on it now

Closing this https://github.com/cardstack/boxel/pull/520. VSCode changes are hitting the indexer. Other changes included in https://github.com/cardstack/boxel/pull/520

Closing this https://github.com/cardstack/boxel/pull/520. VSCode changes are hitting the indexer. Other changes included in https://github.com/cardstack/boxel/pull/520


chore: Add handling to delete all v1beta1/NodeClaim on node termination

Fixes #N/A
Description
This PR adds the removal of the v1beta1/NodeClaims that are associated with any given v1.Node provider ID. This change is another one of the changes on the path to fully migrating the repository over to the new v1beta1 APIs.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 24 (75.0%)  changed or added relevant lines in 2 files are covered.
8 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.09%) to 80.344%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/termination/controller.go
8
14
57.14%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/nodeclaim.go
2
88.17%

pkg/controllers/provisioning/scheduling/topology.go
2
86.49%

pkg/controllers/provisioning/scheduling/topologygroup.go
2
96.75%

pkg/scheduling/requirements.go
2
97.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
8543

Relevant Lines:
10633

💛  - Coveralls


Email to Submitter if resource is denied

Add toggle to be able to choose to send/not send email (as with approved email)

Inserted text doesn't work (text written in flow and updated on record doesn't appear in email)

Email updated and ready to go!


Panic on DotnetCommand.Exec

This block does not check if the returned callbackFunc is nil.
https://github.com/jfrog/jfrog-cli-core/blob/670986eb89356adb1613216bb4348d39f479f52c/artifactory/commands/dotnet/dotnetcommand.go#L120-L122

Hi @kriive
Thanks for reporting this issue.
Our apologies for the inconvenience caused by this.
This PR should fix it.
I will update this thread once the next release will be out.


fix: Add optional peer dependency for @xstate/fsm in @xstate/react

Strict package managers (like yarn v2 or pnpm) don't you require/import stuff unspecified in deps/peerDeps - all your dependencies have to be explicitly defined.
This change can result in false positive peer dep warnings during installations done by older package managers (or ones that just don't implement optional peer deps), but if we want to keep both of those in a single package (@xstate/react) then this is very much needed.
Not sure about all package managers, but yarn supports optional peer deps for quite some time (but maybe just a few months? not sure, would have to be tracked if this has been added this year or sometime before that) and npm has added this very recently.

Would this break installations for those users who don't have @xstate/fsm installed?

Would this break installations for those users who don't have @xstate/fsm installed?

No, with package managers not aware of optional peer dependencies this would just result in a "false positive" warning printed to the console.

@Andarist But now @xstate/fsm is marked as a peerDependency which will cause warnings.

Yes - when using package managers not aware of optional peer dependencies (current npm & yarn are aware of them so there wouldnt be any warnings), this is what I have called "false positive" warnings.
Without this optional peerDep we are breaking strict package managers though (like yarn pnp & pnpm) so definitely something that should be fixed. It's not the only way to fix this problem though - we could just not use a single package (@xstate/react) for both libraries (xstate & @xstate/fsm), this would mean though that we'd have to figure out a name for the other package, document this etc.
After looking at this once more I have realized that xstate should actually be an optional peerDep as well - after all for @xstate/fsm users there should be no requirement of installing main xstate package.

@davidkpiano do you agree with this one as being the final solution for this problem?

@Andarist Yes, that sounds good.


Licensing Confusion (as usual)

The below does not seem accurate-please confirm:
A working Azure AD tenant with at least an Azure AD free or trial license enabled. In the Free tier, SSPR only works for cloud users in Azure AD.
For later tutorials in this series, you'll need an Azure AD Premium P1 or trial license for on-premises password writeback.
If needed, create an Azure account for free.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cacc043b-aeec-5deb-e60f-b11e6381b0ba
Version Independent ID: aa2be87c-296f-b3ff-9549-4407c46746d4
Content: Enable Azure Active Directory self-service password reset
Content Source: articles/active-directory/authentication/tutorial-enable-sspr.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@Weychris
Thanks for your feedback! We will investigate and update as appropriate.

@Weychris Sorry for delay. I hear you about licensing confusion but in this case I don't see an error. Can you clarify what part seems wrong? Pricing info at https://www.microsoft.com/en-us/security/business/identity-access-management/azure-ad-pricing says cloud users have SSPR in Free tier.

#please-close


Feature request: timeout on full request completion

A simple way to place a timeout on the entire request duration would be very useful. I see this was discussed previously but workarounds involved using additional libraries, signals, etc.
Can this not be fixed by simply modifying Response.iter_content() and checking the time after each chunk is read, raising an exception after some "complete_timeout" is surpassed?
I've used a function like  this to do something similar by hijacking the stream parameter but it would be nice if this could be built right into Session and/or Response.
from time import time
import requests

class CompleteTimeout(requests.exceptions.Timeout):
    pass

def request_with_complete_timeout(method, url, complete_timeout, **kwargs):
    """
    Call requests.request() but raise an Exception if the total time exceeds
    complete_timeout seconds.
    """
    kwargs['timeout'] = complete_timeout
    kwargs['stream'] = True
    timeout_time = time() + complete_timeout
    response = requests.request(method, url, **kwargs)
    content_barr = bytearray()
    for chnk in response.iter_content():
        if time() > timeout_time:
            raise CompleteTimeout(
                "Request exceeded complete timeout of {} seconds: {}"
                .format(complete_timeout, url))
        content_barr.extend(chnk)
    response._content = bytes(content_barr)
    return response

Can this not be fixed by simply modifying Response.iter_content() and checking the time after each chunk is read, raising an exception after some "complete_timeout" is surpassed?

Not really. This won't prevent iter_content potentially blocking well past any such timeout, because the socket reads may take a very long time, as may the buffering until the iter_content read size. This also ignores all problems with such a timeout while reading the response.
Ultimately this is a problem of library structure: the way we use the underlying libraries makes expressing his semantic very difficult. We acknowledge it's a problem and hope to remove httplib in order to take steps towards fixing it. However, until that time we're stuck with the semantic we have now.

Thank you. I figured it would have been already added if it were as simple as what I had suggested.


hitbox integration

Guys, I cannot for the life of me figure out how to get the actual stream URL from the hitbox API. Anyone else care to take a look?


Add icon creator to custimization tab in properties

What's the Problem?

This feature could be created as a proper separate app, and I surely can understand that.
That's why I suggest for a start that it may only be optional, for the ones who would like to customize their personal folders.
Since Windows 11 icons have been created, no proper folder customizer has been released. 😒

Here are the 2 little apps I found so far, which have some good "methods", but still not the expected result :
Solution/Idea
#1 App Example :
I came across very interesting little app, but which is unfortunately too limited. Though, the ideas are there. It lucks adding your own logo (transparent PNG) upon folders (with precise resizing and position of course), instead of just a "cheap" set. You can import a W11 folder but cannot tweak its colors, but you can on their own templates and import personal picture to fill them with, which is pretty good.
Alternatives
#2 App Example :
I discovered another interesting Tweaker (for W10 though, and in french) which "tries" a little better to do the job. (The creator said in the forum that this extension is minute and took him a couple of days to make, mixing FolderPaint & ImageMagick- pity he didn't developed it a bit more, but it's just for showing the example).
It is using W11 icons, and there is a choice with many colors, nice little set of logos but still no personal ones you can integrate.

Both of these apps provide an optional right clic option, and also surely make the folder icons >portable< (generates a "desktop.ini" file associated with its "*.ico" hidden file, both in same folder).

Priorities
As an innovating (and best -even not pefect yet) File Explorer, "Files v2" could also integrate an updater (automatic or not /to set), some extensions /addons (like has web browsers) such as a "right click customizer" or other tweaks, in addition to the one I suggested here.
"Files v2" would also be as innovating, with proving that this "AddOn app" I suggested, by finally being the 1st decent folder customizer provider, as neither Microsoft nor thirds have been able to make. I guess copyrights protect owners (Microsoft) from illegal merchandising, but as long as it's free and for personal use, things seems to be ok.
I'm sure it will be something pretty commun in the near future, but the first "easy tweaking" and quality app needs to be experimented a bit before being validated. But when it will be the case, I guess it won't take that long before everybody loves it. 😉
Files Version
<IP_ADDRESS>_Test
Windows Version
Windows 10 LTSC 1809 - (& soon LTSC 21H2)
Comments
Custom folder example (Brave Browser) :

Merging with #6871

Hi,
Careful, this request has got nothing to do with "patching" themes.
It's an Icon creator "option" for individual folders.
Thank you.

@TizianoMad once the icon is created, we would have to modify the system dlls to replace the default icon. There are other ways to do it, but they are a bit complicated and out of scope for what we plan to work on in terms of customization. It's probably better for something like this to be its own app.

@yaichenbaum, thank for your answer.
No, it is not the case !  As I said, it's not a "patcher" modifying DLLs in the system.
It is just applying a "desktop.ini" file with the icon created in the same folder, to make it portable as well, as I described in the post.
Pity if this app can't be an exclusive addon for "Files", as customization and design are the novolties of your app.
Maybe if you know graphic designer programmers you could submit this idea to, I'm sure they will say it will be the kind of app many people need, we just need a good one. Who will be first ? 🤔

@TizianoMad I think I misunderstood, you're just looking for an icon creator that will set individual icons normally? It's an innovative idea but it's still a bit out of scope for Files, even so I'll reopen the issue as a discussion to see how many users are interested.

You got it. I recon you have a lot of work dealing with all prior aspects of your app.
If you take the time to read my intro, I precisely explain it would be optional as an "extension" app.
(means won't be part of the properties unless it is voluntarily added, but you got the right idea now).
I was suggesting integrating such a new proper app as extension (it's just an idea for the future, priority for the main app of course), because it is available nowhere. I just would hope "Files" could offer such a nice feature in the future.

(other subject : in the settings, I would love to "tic" what I want in context menu)

Thank you for considering the idea.

There is better options for making custom icons like Gimp and Photoshop for this.

There is better options for making custom icons like Gimp and Photoshop for this.

Hi,
These are real picture editors, I'm talking about a very small specially preconfigured extension-app for W11 icons, as you can see in # 2 App example.

But why don't you read icons from Registry? I usually modify all the Windows icons importing a .reg like the following:
Windows Registry Editor Version 5.00
; Enable System Icons
[HKEY_CLASSES_ROOT\batfile\DefaultIcon]
@="F:\Icone Sistema\EXE File.ico,0"
...
[HKEY_CLASSES_ROOT\xmlfile\DefaultIcon]
@="F:\Icone Sistema\INF File.ico,0"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons]
"3"="F:\Icone Sistema\Closed Folder.ico,0"
"8"="F:\Icone Sistema\Hard Drive.ico,0"
"107"="F:\Icone Sistema\Hard Drive.ico,0"
"59"="F:\Icone Sistema\DVD RAM.ico,0"
"7"="F:\Icone Sistema\USB Drive.ico,0"
"12"="F:\Icone Sistema\Ram Drive.ico,0"
"29"="F:\Icone Sistema\Shortcut.ico,0"
"0"="F:\Icone Sistema\Generic File.ico,0"
"1"="F:\Icone Sistema\Generic File.ico,0"
"2"="F:\Icone Sistema\EXE File.ico,0"
"4"="F:\Icone Sistema\Closed Folder.ico,0"
I see that my icons are loaded by Files, but immediately substituted by default icons, for example the yellow folder icon.

Only the folders with desktop.ini inside remain modified.
Why!?

The Registry doesn't contain the icons. Those registry changes are just changing the icon path for certain references witch files should read if they get applies in file explorer since files reads from them.

We don't have plans to implement this feature.


Replace blacklist by skiplist

cc @padenot

Coverage remained the same at 30.834% when pulling 0549aa4e741ae3bb295f83560c9fa074502770d7 on calixteman:skiplist into ca252047373c8e9a5a0433e2fb4acc49e6542b15 on mozilla:master.


Doesn't work with fzf.vim

Using fzf.vim add let g:fzf_layout = { 'down': '40%' } to make the search box not show in a floating window & the content will still move upwards when opened

Sorry for the late response. I installed fzf.vim but could not reproduce, is the issue for you?

Closing due to inactivity.

Sorry about not replying timely - I figured out why it was not reproducible - I have this line in my init.vim
set so=999            " set cursor to always be in the center

Any number larger than 1/2 the number of rows of the terminal causes it to stop working, so set so=30 works fine & keeps the cursor in the center of the screen


Add brew deps --skip-installed arg

This PR adds a flag to the brew deps cmd to mirror the --installed flag inversely

The motivation of this small change is to be able to filter only "new" dependencies during the installation for formulae. Currently, there is no way to achieve this… Using the missing cmd is very helpful but is not recursive and will only report direct dependencies. (brew deps --direct --skip-installed is the equivalent) With this flag in deps there is also interop with graph/tree outputs.

Due to the "strict handling of CLI args" (#10880) DependenciesHelpers module being shared between deps and uses, it was necessary to define the flag in both modules to prevent the exception in args::method_missing from being raised. I elected to allow uses to share --skip-installed since it works without any changes and makes sense… But, it could be hidden (like the --all flag is) too, just the same- if someone thinks that would be better.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

I briefly considered it but couldn't see any good reason to but many good reasons to improve deps

code for resolving dependency trees is already in deps.rb, so porting that over to the missing cmd would mean refactoring (into, I imagine, dependencies_helpers)
I agree that there is a redundancy
which begs the question: 'what does missing do, now, that deps cannot?'
It's a nice alias… 🤷♀
the missing cmd -aside from refactorings- hasn't been changed in 11+ years since its inception. And it is like a dozen LOC.
I think that not unlike the obsolete brew deps-tree cmd (which was changed to an arg, -tree), the missing module is extremely specific in purpose and so will probably only ever have a single specific value. I.e., there's only so much functionality one can dream up that the missing module would ever have, no?

Thanks so much for your first contribution!  You rock, @binury!


feat: Install ROS on the OT-2's system (customizable Ubuntu system image)

Overview
I hope to use ROS to control the protocol with more advanced input. For instance, I use a camera to read the color. Depending on the color value, OT-2 performs different mixing protocols. If ROS can be installed, it would be much easier to achieve this. However, the OS on OT-2 is a Buildroot Linux which lacks the capability to customize it with a native compiler and is also not supported by the ROS team. I wonder if you can provide an option to customize a Ubuntu Linux image to OT-2's needs. For example, provide an install-ot2-requirements.sh and we install whatever we want in the system while it will automatically work with the OT-2 app.

I also require some sort of linux package install manager: apt-get, apt-install. This is a serious limitation for advantaged usage.


docs: switch to ellipsis (“…” instead of “...”)

Signed-off-by: Jens Oliver Meiert<EMAIL_ADDRESS>

I prefer to have "..." in the source since it's easier to type (and read, in monospace fonts), but it can be transformed to an ellipsis in the build step. See #52
Thanks!


Add documentation for oneofs

Carl, do you want to manually enter this one?
Ready for Google won't work.

Manually pulled in
https://github.com/qitab/cl-protobufs/pull/117


Removing and re-adding Navigation and NavigationAgent to SceneTree inconsistent behavior

Godot version
3.5.rc3
System information
Windows 10
Issue description
When removing and re-adding a Navigation and a NavigationAgent node to the SceneTree they appear to randomly stop working. The randomness comes from the inconsistence between the different setups of the NavigationAgent.
Problem cases
avoidance_enabled is false
When _enter_tree is called on the NavigationAgent, calling  set_navigation again will be enough to let calls to methods such as  get_next_location or is_target_reached to work.
avoidance_enabled is true
When the NavigationAgent uses avoidance, it is not enough to call set_navigation when entering tree again. The Navigation node itself must be readied again by calling request_ready before it is re-added to the tree. If both request_ready on the Navigation node and set_navigation on NavigationAgent are called than the agent will work as expected.
Workaround
Add a call to request_ready on Navigation in _exit_tree , call set_navigation on NavigationAgent's in _enter_tree after the first time the navigation is setup by keeping references to the Navigation node. This provides a consistent behavior across all agents.
Expected behavior
Manipulating Navigation related nodes in the SceneTree should not require manually keeping track of the state.
At the very least the request_ready call on the Navigation should not be necessary, I don't think any other built-in node requires "manual resetting" of it's state when exiting/entering the tree. If the set_navigation is required it should be documented in the NavigationAgent class.
Everything works as expected in Godot 4 Alpha 10. This issue is not present. Calling request_ready is unnecessary and the set_navigation call doesn't exist.
Steps to reproduce
Run the sample project, press the Remove/Add button to move the Navigation and NavigationAgent nodes from the scene tree, use the various checkbox to toggle what methods get called and if the NavigationAgent has avoidance enabled.

Minimal reproduction project
navagent_reparent_repro.zip
navagent_reparent_repro_godot4.zip

In the 3.x build, only NavigationAgent.set_navigation needs to be called, Navigation.request_ready is not necessary in any case.

Note that the test project for 3.5 had the agent placed at the wrong position.
It must be below the navigation node or else it will register to the default world navigation map which causes the agent to break cause this map is empty and has no navigation mesh.

Fixed by #62117.

@akien-mga @smix8 I've tested the latest build. I have found a combination of methods that work great, but the API is now confusing. Please correct me if I misunderstood something, because I would really like to document this properly.
With the new navigation system, engine users have two choices:
Legacy
Use the Navigation node, with multiple child NavigationMeshInstance to describe the navigation polygons. This creates a new map in the NavigationServer, so agents need to be told about it.
The NavigationAgent must either be a child of the Navigation node, or set_navigation or set_navigation_map must be called in e.g. _ready.
Here is where the confusing API comes into play.
When calling set_navigation and passing in the Navigation node, it is a requirement to call set_navigation any time the agent exits/enters the SceneTree.
However, if calling NavigationAgent.set_navigation_map instead, the agent behaves as expected, and there is no need to call NavigationAgent.set_navigation_map on tree entry again.
I understand that the set_navigation call is kept around for API compatibility reasons, but shouldn't it then just act as an alias:
NavigationAgent.set_navigation(nav_node) -> NavigationAgent.set_navigation_map(nav_node.get_rid()) to insure consistent behavior across method calls.
Godot 4
Place NavigationMeshInstance nodes directly into the tree, without a parent Navigation node. This will create regions inside the global map.
NavigationAgent will default to the global map when not told about a separate Navigation node or a custom map RID. This means the agent is very flexible when entering/exiting the tree.

@TheOrioli
When NavigationAgent enters the tree again calling set_navigation() manually is only a requirement if you do not place the agent below the navigation node. This was actually the case in your 3.5 test project as the agent was child of the "NodeToRemove" node and not the Navigation node.
Godot 4.0 and 3.5 navigation work the same now but 3.5 has some old stuff kept around for compatibility with existing scenes.
What is shared with both version is that every world resource creates a default navigation map and every navigation related node like regions and agents join this map if not told otherwise. NavigationAgent.set_navigation_map() can be used to override the default map for both future pathfinding queries of the NavigationAgent node as well as avoidance rvo_agent on the NavigationServer in one go.
That said Godot 3.5 has still the old Navigation and Navigation2D nodes around that are kept for scene compatibility with old 3.x version. These nodes create a new navigation map, something that can only be done with the NavigationServer API directly in Godot 4.0. When a navigation related node is placed below such node it will join the navigation map of the navigation node and not the default map. The functions NavigationAgent.set_navigation() and NavigationAgent.set_navigation_node() are old and exclusive to 3.x because of the Navigation/Navigation2D nodes and backward compatibility. Might mark them and the entire nodes as depr soon. For Godot 3.5 I would advice to not use the old Navigation/Navigation2D nodes and the old functions at all anymore and move to the new Godot 4.0 navigation way.

@smix8 Amazing, thank you. I'll poke around the docs on Monday and try to update them with this information to make it clearer for devs.
Final question, some useful methods require a map RID to work, e.g. NavigationServer.map_get_closest_point It seems like the best way to get the RID for the default map right now is to call the NavigationAgent.get_navigation_map for an agent you know is part of the default map or by using a NavigationMeshInstance.get_region followed by NavigationServer.region_get_map
Is there another way to get the default/world map RID?

@TheOrioli
The default navigation maps are part of the World2D or World3D resources of the viewport(s).
The default 2D navigation map can be optained from any Node2D inheriting node with get_world_2d().get_navigation_map().
The default 3D navigation map can be optained from any Node3D inheriting node with get_world_3d().get_navigation_map().


Remote ssh forwarding fails [ssh: rejected: administratively prohibited]

Really awesome tool, been using it for a while, recently I've noticed a problem: didn't need that feature for quite a while, last time I used it was February-March 2023 I believe and -R worked as expected. However, I updated since then and when I tried to forward port, I get the following message when trying to connect to a forwarded port curl http://localhost:[PORT]:
WARNING: Server requests forwarding for unknown listen_port 1329
Did a little research with baked/non-baked home address and both on linux and windows RSSH clients all the same, here's the log output from client:
2023/09/19 20:24:12 Connecting to  <IP_ADDRESS>:443
2023/09/19 20:24:13 Successfully connnected <IP_ADDRESS>:443
2023/09/19 20:27:37 [client] INFO global.go:118 RegisterChannelCallbacks() : Handling channel: jump
2023/09/19 20:27:39 [<IP_ADDRESS>:443] INFO jumphost.go:52 func1() : New SSH connection, version SSH-2.0-OpenSSH_8.9p1 Ubuntu-3ubuntu0.3
2023/09/19 20:27:39 [<IP_ADDRESS>:443] INFO global.go:118 RegisterChannelCallbacks() : Handling channel: session
2023/09/19 20:27:39 Started listening on:  <IP_ADDRESS>:15151
2023/09/19 20:27:40 [<IP_ADDRESS>:443] INFO session.go:57 Session() : Session got request: "pty-req"
2023/09/19 20:27:40 [<IP_ADDRESS>:443] INFO session.go:57 Session() : Session got request: "env"
2023/09/19 20:27:40 [<IP_ADDRESS>:443] WARNING session.go:150 Session() : Got an unknown request env
2023/09/19 20:27:40 [<IP_ADDRESS>:443] INFO session.go:57 Session() : Session got request: "env"
2023/09/19 20:27:40 [<IP_ADDRESS>:443] WARNING session.go:150 Session() : Got an unknown request env
2023/09/19 20:27:40 [<IP_ADDRESS>:443] INFO session.go:57 Session() : Session got request: "shell"
2023/09/19 20:27:40 [<IP_ADDRESS>:443] INFO shell_windows.go:132 runWithConpty() : New process with pid 19588 spawned
2023/09/19 20:27:48 Accepted new connection:  <IP_ADDRESS>:1329
2023/09/19 20:27:48 Opening forwarded-tcpip channel to server failed:  ssh: rejected: administratively prohibited (open failed)
2023/09/19 20:29:27 Server disconnected unexpectedly: connection terminated
2023/09/19 20:29:27 [client] ERROR jumphost.go:97 func1() : Channel call back error: connection terminated
2023/09/19 20:29:27 Stopped listening on:  localhost 15151
2023/09/19 20:29:27 [<IP_ADDRESS>:443] INFO session.go:120 Session() : Session disconnected
2023/09/19 20:29:37 Connecting to  <IP_ADDRESS>:443
2023/09/19 20:29:38 Successfully connnected <IP_ADDRESS>:443

So it fails due to Opening forwarded-tcpip channel to server failed:  ssh: rejected: administratively prohibited (open failed)
Just in case, OpenSSH client versions that I used with -R option are:
OpenSSH_8.9p1 Ubuntu-3ubuntu0.3, OpenSSL 3.0.2 15 Mar 2022
OpenSSH_9.2p1 Debian-2, OpenSSL 3.0.10 1 Aug 2023
OpenSSH_for_Windows_8.1p1, LibreSSL 3.0.2

Doesn't seem to be an issue with opening ports on remote client since when I use ligolo-ng to forward remote ports it works as expected, also tested on different setups, looks like an RSSH bug to me

Howdy.
Can you also give me the ssh command you used to get this error?
Definitely off that the server connection is dying for the client.
Could you give me server logs for this?

What a speed, yeah, sure
I've tried ssh -R 15151:<IP_ADDRESS>:15151 -J ..., also tried on <IP_ADDRESS>, then in the terminal window I just accessed port 15151 with curl http://<IP_ADDRESS>:15151
Those are server logs since the moment of client connection till the error
2023/09/19 17:17:26 Loading files from /opt/reverse_ssh/bin
2023/09/19 17:17:26 Version:  v2.2.2
2023/09/19 17:17:26 Listening on <IP_ADDRESS>:2222
2023/09/19 17:17:26 Loading private key from: /opt/reverse_ssh/bin/id_ed25519
2023/09/19 17:17:26 Server key fingerprint:  a2d4576a4bb4e44f19fe6bb4759ddb2dea8be739f736ea0e332d61a592a47217
2023/09/19 17:17:26 Loading authorized keys from: /opt/reverse_ssh/bin/authorized_keys
2023/09/19 17:17:26 Was unable to read webhooks configuration file
2023/09/19 17:17:26 Started Web Server
2023/09/19 17:17:34 [<IP_ADDRESS>:31393] INFO sshd.go:360 acceptConn() : New controllable connection with id 2d630cbd1396f24816d0d5d7be858ab5b1176099
2023/09/19 17:18:04 [[::1]:35466] INFO sshd.go:324 acceptConn() : New User SSH connection, version SSH-2.0-OpenSSH_8.9p1 Ubuntu-3ubuntu0.3
2023/09/19 17:18:04 [[::1]:35466] INFO global.go:118 RegisterChannelCallbacks() : Handling channel: direct-tcpip

Regarding the dying server connection, I think that's probably bc I forcefully closed open RSSH terminal session bc it hangs my terminal after the WARNING: Server requests forwarding for unknown listen_port, but I believe it's just terminal window issue

Cool I can replicate this. Not sure how its broken yet.

Is it global or happens only on specific OpenSSH client versions? I've searched yesterday and found kinda similar issue with remote forwarding, for the guy there it was broken on 7.9 or smth like that but on 5.5 it worked as expected, didn't test lower client versions tho' and it was about normal ssh server, not RSSH. Maybe there are minor changes in OpenSSH forwarding logic

Actually, I may have to take that replication back. Turns out I've found another weirdness when you dont define localhost as <IP_ADDRESS> on a machine it can cause failure to open.

Ah no I can, its just a little different then I first thought

I've tried ssh -R with [PORT]:[localhost/<IP_ADDRESS>/<IP_ADDRESS>/other interface IP]:[PORT], didn't work for all cases, the last server log is for ssh -R 15151:<IP_ADDRESS>:15151

Ah cool I've fixed it. Give me one moment and I'll do a release

All done!


Date 'format' is not respected on 'Update'.

I use widget in my _form.php that is used both by create and update actions:
        <?= $form->field($model, 'publication_date')->widget(
            DatePicker::className(), [
                'language' => 'ru',
                'clientOptions' => [
                    'autoclose' => true,
                    'format' => 'dd.mm.yyyy',
                    'todayBtn' => true,
                    'pickerPosition' => 'top-left'
                ]
        ]);?>

When I select desired date in create view, everything is fine:

But when I go to 'update' view I see that required field is rendered like this:

So, no format is respected during rendering the field.
Any ways to fix?

@Real-Gecko have you tried providing the same format on server and client? Otherwise, I highly recommend that you modify the value of the attribute prior placing it on the widget. Maybe on


Handle Unicode correctly

charCodeAt(0) is insufficient to correctly convert all Unicode to binary.
Find a reliable sufficient way to convert all Unicode to binary and implement.

This is not even a part of dosyrng. Closing.


Documentation Standards in phpDocumentor 3

Important: this item should be developed against the develop branch and not the master branch; the develop branch contains all parts needed for phpDocumentor 3 where master does not.

The basic idea behind this feature is that we want to be able to check a codebase that has been parsed by the phpDocumentor Reflection package against a Documentation Standard, and receive a list of violations of that Standard so that developers can ensure consistency in their project and make sure their documentation is in order.
The Reflection package of phpDocumentor will analyse the source code of an entire project and create an object graph representing all elements of that project including their associated Documentation (using DocBlocks).
This object graph starts with a phpDocumentor\Reflection\Project object, which in turn consists of a series of objects representing Files and in those files is a tree of elements in those files.
This feature should accept any element in that tree (project, file, class, etc) and recursively check those elements against a Documentation Standard. A Documentation Standard will contains a series of rules and settings for those rules; if an element is applicable for a rule, such as a check on @return on a Method, but fails the rules business logic then a Violation should be emitted.
After one or more elements are checked should we have a list of violations of which we know at least:

Which element the violation happened on, identified by their FQSEN
What the severity of the violation is
A code identifying the rule
A (configurable) message

Acceptance Criteria

[ ] It should be possible to define Documentation Standards that consist of a series of preconfigured rules
[ ] It should be possible to extend or import Documentation Standards in a Documentation Standard and disable one or more rules, or adjust one or more parameters of rules
[ ] Each rule should represent a single violation of the Documentation Standards, see below for an initial list of rules
[ ] Every rule may have a severity associated with it, this represents if the rule is an error, warning or notice.
[ ] The default severity of a Rule may be overridden
[ ] Every rule has a default message associated with it
[ ] The default message of a rule may be overridden
[ ] A rule can be limited to a specific set of Elements. For example: checks on the @return tag are only allowed for functions and methods
[ ] After the verification is completed a list of violations should be returned with at least
[ ] Test covered

Technical Guidelines

The description of this item states that we want to check Reflected information; this is true for this specific item but we will want to re-use this component to verify all documentation interpreted by phpDocumentor; this might be a design consideration.
This item relies on functionality of the Reflection component that is being developed on its develop branch and differs from the last tagged release. For example: with the new Reflection Component you have a DocBlock object associated with elements supporting a DocBlock, previously the DocBlock properties were integrated into the Element.
Part of the challenge of this item is that development on the Reflection component is not complete yet; you will probably (partially) rely on mocks to test this feature.
Rules and Rulesets should match the style or intent of PHP_CodeSniffer so we can reuse its XML configuration format
Based on, at least basic, DDD concepts
Should be able to pass a Project or individual element to be checked
If an element is checked that contains other children that can be checked, it should recursively verify every element
If needed, a CommandBus is allowed but the Tactician package should be used because we are going to use that in other parts of the application as well

Rules

Files should have a summary (may be a specific one, should be configurable)
Files should have a description (may be a specific one, should be configurable)
Files should have [configurable] tag(s); for example: copyright, author, etc
All classes should have a Summary
All methods should have a Summary
The typehint of a method or function should match that of the @param property in the DocBlock; if the Typehint and @param type are both an FQSEN then we should accept it since the Typehint may describe an interface and the DocBlock a concrete instance
All methods should have [configurable] tags; for example: return tags on methods

More rules will be added before the start of the event or after the event if this item is still under development

Closing the 3.0 tickets, will reconsider them after our re-alignment


App crashes when clearing the Date field while adding a Payment

@Ovifer13

It also crash when you edit a Project


Temporarily removes huge uploads to see if 408s on publish persist

:ship: :it:

emoji lover!

merging as JDK8 passed. killing other jobs


Theme being reset to default when opening Dialog component

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

I set up a simple theme with ThemeProvider to define custom primary color
Checkboxes with primary color appear correct in the component tree
When a Dialog component opens, the checkbox has wrong default color in both dialog and even in the underlying form, where it was correct before.

Expected Behavior 🤔

I would expect the correct color of Checkbox defined by theme being forwarded.

Steps to Reproduce 🕹

https://codesandbox.io/s/material-demo-lzxu0?file=/demo.js
Create ThemeProvider setting primary color to red
Create MuiThemeProvider to be able to use Dialog (material-ui 0.20.2) with primary color blue
There is a Checkbox in main tree which has proper red color
Open the dialog, the Checkbox color changes to purple (default theme) in both main tree and dialog. Theme seems to be reset.

Context 🔦

In our project we use the latest release of material-ui in combination with old material-ui 0.20.2 components. I am thankful everything else is working nicely using two version of your library
Normally it seems there is no conflict in using two versions and theme, only the Dialog somehow resets the theme from context.

Your Environment 🌎
    "@material-ui/core": "4.9.11",
    "@material-ui/icons": "4.9.1",
    "@material-ui/lab": "4.0.0-alpha.50",
    "material-ui": "0.20.2",
    "react": "16.8.6",
    "react-dom": "16.8.6",

There's definitely something wrong. Opening a dialog shouldn't mount duplicate checkbox <style> elements.

Legacy context api

Did you manage to fix the issue @peterbartos @oliviertassinari ? I have a similar problem.
I created a custom a custom component that I am using in another project.
It uses a material-UI dialog.
When I open it in my project, the theme resets

@tran-simon This is unrelated, I'm resolving.

I'm having an issue with this, using purely the latest v4 components.
When I add a dialog to the DOM using render from 'react-dom' my custom theme is overwritten. This doesn't happen when dynamically adding a Typography component for example.
I made a codeSandbox, click the button and you'll see the dialog shows and the theme default button text changes from pink to blue.
https://codesandbox.io/s/material-theme-bug-cqjcl?file=/index.js


Add support for the LPC54102 series

This commit adds the YAML file generated by the great target-gen-tool provided in this repository (using the following command):
$ target-gen arm -f LPC54102 probe-rs/targets

This is a sub-series of the LPC54xxx microcontrollers: the datasheet groups the LPC54102 chips of this commit together with the LPC54101- chips, which are different as they don't have a secondary Cortex-M0+- core. Therefore they have a different CMSIS-pack and should be in a separate file.

Thanks! Have you by chance verified whether the flash algos actually work? I have a slight worry that we may connect to the M0+ core by default, and if the algos are written for M4 there might be problems. You can also constrain the algorithms to the M4 core, but currently I'd recommend just commenting out the M0+ cores.

I currently just start to develop a new application, so I just start to do something with the new chip, but:
It looks like you're right:
$ cargo flash --chip LPC54102J512BD64
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s
    Flashing /home/jfrimmel/git/testapp/target/thumbv7em-none-eabihf/debug/testapp
      Erasing ✔ [00:00:00] [########################################] 32.00 KiB/32.00 KiB @ 132.88 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [###########################################] 5.00 KiB/5.00 KiB @ 10.06 KiB/s (eta 0s )    Finished in 0.794s
 WARN probe_rs::architecture::arm::core::armv6m: Expected core to be halted, but core is running

Notice the armv6m in the warning message. If i comment out the Cortex-M0+ core as you suggested, the warning disappears.
$ cargo flash --chip LPC54102J512BD64
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Flashing /home/jfrimmel/git/testapp/target/thumbv7em-none-eabihf/debug/testapp
      Erasing ✔ [00:00:00] [########################################] 32.00 KiB/32.00 KiB @ 121.12 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [############################################] 5.00 KiB/5.00 KiB @ 9.06 KiB/s (eta 0s )    Finished in 0.873s

Thus a general question arises: how does probe-rs deal with multi-core-chips (running from the same flash/RAM).

Thus a general question arises: how does probe-rs deal with multi-core-chips (running from the same flash/RAM)?

The important bits right now are that the default core is the first that is defined in the target YAML, so switching their order might work. All cores are accessable with Session::core(), and calling that will attach to the specified core for a short while. That being said, not much in the CLI tooling actually does anything with multiple cores, and IIRC neither does the VSCode debugger.

Would you like to:

switch the cores
comment out the Cortex-M0
remove the Cortex-M0 entirely
close this PR as rather there is no target than a half-baked one?

I'm in favor of one of the first two, though.

I'm perfectly happy with switching the order of the cores. Limited support is better than no support :)

Oh, no... I did some testing locally and even with  the cores changed, the "wrong" core is used:
$ cargo embed
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s
      Config default
      Target /home/jfrimmel/git/testapp/target/thumbv7em-none-eabihf/debug/testapp
      Erasing ✔ [00:00:00] [########################################] 32.00 KiB/32.00 KiB @ 133.49 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [###########################################] 5.00 KiB/5.00 KiB @ 10.10 KiB/s (eta 0s )    Finished in 0.791s
 WARN probe_rs::util::rtt: No RTT header info was present in the ELF file. Does your firmware run RTT?
        Done processing config default
 WARN probe_rs::architecture::arm::core::armv6m: Expected core to be halted, but core is running

As you can see, there is the armv6m again...

Oh, no... I did some testing locally and even with  the cores changed, the "wrong" core is used:
$ cargo flash --chip LPC54102J512BD64
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
    Flashing /home/jfrimmel/git/testapp/target/thumbv7em-none-eabihf/debug/testapp
      Erasing ✔ [00:00:00] [########################################] 32.00 KiB/32.00 KiB @ 133.45 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [###########################################] 5.00 KiB/5.00 KiB @ 10.11 KiB/s (eta 0s )    Finished in 0.791s
 WARN probe_rs::architecture::arm::core::armv6m: Expected core to be halted, but core is running

As you can see, there is the armv6m again...
Therefore I'll go one and comment out the Cortex-M0+.
(sorry for the noise)

I'm not sure if that warning is too important here. It might be that the M0+ needs some special attention and we'll need to add a custom debug sequence for these chips, but also warnings aren't errors. As long as the flash algo runs on the main core, and things seem to work (i.e. for example probe-rs run or cargo embed can show RTT output), it should be okay. cargo flash isn't the best tool to test this because it disconnects after flashing and we can't see what happens in the longer term. That being said, if that warning is spammed multiple times a second, it's probably a different story 😅
Multi-core chips are slightly tricky because halting/resuming them is completely implementation-specific. Multi-architecture may or may not throw one more wrench into the story.

Okay, here is a minimal application with RTT output:
#[cortex_m_rt::entry]
fn main() -> ! {
    rtt_target::rtt_init_print!();
    rtt_target::debug_rprintln!("Hello, world!");

    cortex_m_semihosting::debug::exit(cortex_m_semihosting::debug::EXIT_SUCCESS);
    loop {
        unsafe { core::arch::asm!("wfe") };
    }
}

I've done two tests:

Test
RTT Output?
Application Exit?

with changed order (first Cortex-M4, then Cortex-M0+)
yes
no

with Cortex-M0+ commented out
yes
yes

So I would deduce, that we do need to comment out the Cortex-M0+ core, as at least some tools will pick the wrong core.


suggestion

point.stroke
in the class line series ,it should add PointStrokeProperty to easy to change point's style ,and it can distinguish the stroke from lineSeries .I think that  it is more easy to design for us.

@endeep: This is available through mapping although no way, that I have found, to directly set these values. This would be a good feature to have.
Example:


Add support for MSVCs dodgy complex implementation

Fixes #5512.
I've deliberately not enabled it by default - users still have to manually enable ccomplex to get it, but it hopefully should work

@lysnikolaou could you check that this solves the problem in PR numpy/numpy#24085? One way to do that, if you can't do it locally, would be to override the cython version in the relevant CI with
pip install pip git+https://github.com/da-woods/cython.git@msvc_complex

Thanks! FWIW, I think this is the right direction.

No worries. it might be worth waiting for the CI to finish before you waste time testing it. It wrote this PR it on Linux so I haven't even tested it locally.

So it looks a bit fiddlier still, because they also don't implement any of the arithmetic operators. So practically the only things I think we can use is their struct, and the rest we have to use the existing Cython-generated fallbacks

@mattip having given this a go on an actual Windows PC I think the my conclusion is "sorry - I can't get this to work".
Even something as simple as implementing __Pyx_CREAL doesn't work for me. It needs a different function name for every type (allegedly there's type generic macros available but they don't work for me either). I came up with a hacky workaround for that. But then I hit the problem none of the arithmetic operators compile. Making them compile looks like a substantial refactoring I think.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_af56543b-dc7c-4a6f-9931-f25134a8b8f8/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_af56543b-dc7c-4a6f-9931-f25134a8b8f8.git

Docs Build status updates of commit 7dee5d9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-12-15-05-58-24 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-12-15-05-58-24

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Cannot find text.pdf file

I am getting an intermittent error message when watching a directory that the x_text.pdf file cannot be found.
When the error is thrown, the current/running thread appears to complete and make the OCR'ed version (best I can tell, it comes out okay), so I'm not sure why the error is thrown.
The observer dies, however, and so any other queued files are dropped.
ERROR: Cannot find specified pdf file ./x_text.pdf
Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/root/anaconda2/lib/python2.7/threading.py", line 801, in __bootstrap_inner
  File "/root/anaconda2/lib/python2.7/site-packages/watchdog/observers/api.py", line 200, in run
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'Empty'

A couple of additional notes:

The PDFs in question are large (125+ pages), so I don't know if that would be part of the issue?

Best I can tell, the error is not thrown uniformly (it does not always fail on the same file, or after the same number of files, etc), and I cannot replicate the problem when I explicitly/individually call the same files that fail when watching (ie, calling pypdfocr ./x.pdf instead of pypdfocr -w ./folder/).

I have the same problem. Its quite simple, the x_text.pdf file is generated by pypdfocr as a intermidiate file. The problem is, it is generated inside the watch folder and the watcher does try to work on each pdf file. After finishing the x.pdf file it has the x_text.pdf file at his queues and tries to do his work on it. But the x_text.pdf is deleted (because it was only a intermidiate file). The error itself doesnt harm but i think there should be a filter at the watcher.

Any update on how to fix this? I keep running into the same issue.


Add the basic structure for src/

This is a draft PR so far...

@aghorianducalis Great. I'd love to hear your higher-level goal here. I can't really tell what you are trying to achieve without delving deeper into the code.


Fix for #58: Store RetryAfter for subsequent requests

I think @garimakhulbe was making this change as part of a larger PR, but I'm sending this so that I can vendor it now for the PR I'm preparing for Kubernetes. This change saves me upwards of a minute or two whenever provisioning external load balancers for Kubernetes Services. I've been running this code for a while as-is; works as intended.

(addresses #58)

LGTM

Thanks @colemickens


--logQueries creates empty queries-bg-?.smt2 files

[hritcu@detained metatheory]$ ../../bin/fstar.exe  tinyfstar-new.fst --logQueries
Verified module: Prims
Verified module: Classical
Verified module: FunctionalExtensionality
Verified module: TinyFStarNew
All verification conditions discharged successfully
[hritcu@detained metatheory]$ ls -al | grep queries
-rw-r--r-- 1 hritcu hritcu 709993 May 27 16:32 queries-bg-0.smt2
-rw-r--r-- 1 hritcu hritcu      0 May 27 16:32 queries-bg-1.smt2
-rw-r--r-- 1 hritcu hritcu      0 May 27 16:32 queries-bg-2.smt2
-rw-r--r-- 1 hritcu hritcu      0 May 27 16:33 queries-bg-3.smt2

3 of the 4 created files are empty in this case. The only one that's not empty seems to correspond to Prims.

Seems to be yet another strange consequence of #246: command line arguments being discarded when processing everything but the first file, in the presence of build-config


Unhandled exception: PathNotFoundException: Directory listing failed

:information_source: Info
Version: ^3.16.4
:speech_balloon: Description
PathNotFoundException: Directory listing failed, path = 'C:\Users\xxx\Desktop\xxx\packages\xxx\build\windows\runner\Release\Images*' (OS Error: The system cannot find the path specified.
, errno = 3)
**Enter a description of your problem here.
Got this error when I set logo_path with relative file path.
:scroll: Pubspec.yaml
msix_config:
display_name: hello
publisher_display_name: myapp
identity_name: app.myapp.app
languages: en-us
enable_at_startup: true
capabilities: "internetClient"
logo_path: ./resources/icons/logo.png
app_installer:
automatic_background_task: true
show_prompt: true
output_name: xenmusic_installer

I get this error too, even if I make the path absolute.

@xenSlayer did you manage to fix this somehow?

no not really.

I have the same issue

here is an example


some folders are not removed from K9 after a refresh folder list action

hi all
firstly, i have searched for "folders not removed". I've looked at both open and closed issues and can't seem to find anything that matches my problem. This of course makes me wonder if it's something specific to me.
Describe the bug
when i've renamed a folder in gmail, i would expect the k9 refresh folder list action to:
a) produce the newly named folder
b) remove the old / missing folder
As per your FAQ here https://k9mail.app/documentation/faq.html#anchor16
However, I've got K9 folders that no longer exist in the browser gmail experience (because i've renamed them), yet they are still visible in K9.
Refresh Folder List does not remove them.
To Reproduce
i can only partially reproduce it now :(
I've literally just tested with a new folder in browser gmail (no emails in test folder), just so as to not waste your time.

I refreshed the k9 folder list. New folder appeared.
i then renamed in gmail (browser) and k9 folder refreshing changed the folder name. The previous folder name no longer exists in K9.
As a final test, i deleted the gmail folder ("remove label" command) and K9 folder refreshed. Folder disappears.

I retested the above with an email in it (admittedly a draft email).

Test folder with emails in it appears in K9.
Renamed test folder with email in it appears in K9.
Old test folder with email disappears from K9.
Removing test folder from gmail removes from K9 after folder refresh.

However, i DO have existing K9 folders which don't exist on gmail any more, yet i can't delete them from K9 because there's no delete function and refresh folder list doesn't remove them.

Although there were no emails showing the redundant K9 folders, i tried "clear local messages", in case there was some data marked against them. This didn't help.
I've got 8 folders in K9 like this, which don't exist on gmail.
I did think about the possibility of compacting the account but i think that functionality has been removed.

Expected behaviour
all folders that no longer exist in gmail should get removed by K9's refresh folder list action.
Additional context
using K9 v5.806 on Samsung S8 with official OTA android release 9 i.e. pie
Am using IMAP for gmail to K9 operations.
Logs
didn't attach any as i get no errors
debug log attached for "Refresh Folder List" action on my the account in question.
k9-log.txt
regards,
Gary

Please record a debug log while refreshing the folder list. See https://github.com/k9mail/k-9/wiki/LoggingErrors
This will log the client-server communication so we can see what data Gmail is delivering to the app.

Please record a debug log while refreshing the folder list. See https://github.com/k9mail/k-9/wiki/LoggingErrors
This will log the client-server communication so we can see what data Gmail is delivering to the app.

tyvm
presumably i attach the log to my opening thread?

presumably i attach the log to my opening thread?

Please create a new comment when attaching the log. This will trigger a notification email.

presumably i attach the log to my opening thread?

Please create a new comment when attaching the log. This will trigger a notification email.

tyvm. done.

logs for Refresh Folder List action (as suggested by cketti)
k9-log.txt

The log indicates that some folders have been removed locally. Could it be possible that the folder list in the UI is just not updated? Can you test creating/removing a folder on the server, refreshing the folder list, killing the app, then checking if the local folder list properly reflects the server state when the app is restarted?


Prefix Docker images with service-catalog-

To avoid collisions with other images that the users can have in their
registries the images generated by "service-catalog" will be prefixed with
service-catalog-.
The prefix isn't configurable but it could be easily changed in the Makefile.
Closes #331

Rather than apply this prefix over and over in so many places, I think it might be cleaner to create new variables for each component name and just apply the prefix in those few places.

@krancour is the suggestion for USER-BROKER-IMAGE-NAME or some such that resolves one time to $(IMAGES_PREFIX)user-broker? I could go that way or the other way of some Make function that gets reused for each image. I also see much duplication in the makefile.

@MHBauer, either is probably fine. There's clearly a smell here that's always been here. I just becomes more noticable when one needs to rip through the Makefile and add the same prefix in dozens of places.

I am not sure that adding the prefix as a var to the helm templates would be a good idea since we don't want to provide configuration just now & it will clearly make the templates a little bit more complicated.
However, I am all in for the change in the Makefile. Do you want it to be part of this PR or in a new one?

I do not have any opinion on helm template changes.
LGTM as is. I see nothing obviously wrong. We need to take a spin through the whole makefile at some point to factor out the common patterns. Not high priority.
If you do want to change the makefile, change it now.

@agonzalezro:

I am not sure that adding the prefix as a var to the helm templates would be a good idea ...

I am strictly talking about the Makefile. The Helm chart needs a ton of other cleanup and I'm already tasked with that, so it's not even a consideration here.

Sorry @krancour, since I was changing four templates here as well I thought that you were talking about both 😄

See https://github.com/kubernetes-incubator/service-catalog/pull/529#discussion_r105745994  I'd prefer if we used registry namespaces instead of long prefixes on our names.

@krancour but at that point aren't you already, in essence, creating your own repo name? Meaning you could add svc-cat or service-catalog in front of the name if you want as you retag it. Any script you're using to pull from own repo is aleady customized to begin with.
The "stutter" really bugs me  :-)
Perhaps your default idea will do it.....need to ponder that one more.

@duglin

but at that point aren't you already, in essence, creating your own repo name? Meaning you could add svc-cat or service-catalog in front of the name if you want as you retag it.

Sorry. I'm not quite understanding what you're trying to say.
I don't feel like I did a good job of articulating what I was trying to say before. Here's a simplified scenario:
I work on two projects that both produce an apiserver image. I want to push both to my krancour namespace on Dockerhub. If I don't want to make a total mess out of krancour/apiserver by pushing both of these two unrelated images to that common location, the most reasonable way for me to disambiguate is to put a prefix after the namespace, but before the proper image name. I end up with krancour/x-apiserver and krancour/y-apiserver.
This PR just bakes support for that sort of proactive disambiuation right into our process. Honestly--I will use this.
If we make this optional to set and use a default prefix of "", then people who need to both with this can and everyone else can carry on as they currently are... and the official images names will be stutter-free.

yea and I'm ok with that - as long as the default is ""

@agonzalezro this PR was closed by https://github.com/kubernetes-incubator/service-catalog/pull/529, but #529 didn't add a prefix to the image names. I chose to close this PR from that one because there was a lot of overlap between the two, and I wanted to get that change in before this registry prefix change. Also, @krancour and I discussed a different direction to accomplish what you did in this PR. He will ping you from his forthcoming PR.
Sorry for the confusion here!

@agonzalezro Thank you for creating issue #331 and for tackling a first version of a solution. We may not have used your PR, but thank you for the effort you have shown!

@agonzalezro check out https://github.com/kubernetes-incubator/service-catalog/pull/537 for a replacement to this

No worries folks, I like the solution implemented in #537 :) Keep up the good job!


Fixed to support custom SignalHandlerResponse when using SignalBus directly

Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] No compiler errors or warnings

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Issue Number

Issue Number: #149
Create or search an issue here: Extenject/Issues
What is the current behavior?

Erroneously replaces identifier with the signal handler response

What is the new behavior?

Uses the given signal handler response

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

On which Unity version has this been tested?

[ ] 2020.4 LTS
[ ] 2020.3
[ ] 2020.2
[ ] 2020.1
[ ] 2019.4 LTS
[x] 2019.3
[ ] 2019.2
[ ] 2019.1
[ ] 2018.4 LTS

Scripting backend:

[x] Mono
[ ] IL2CPP

Note: Every pull request is tested on the Continuous Integration (CI) system to confirm that it works in Unity.
Ideally, the pull request will pass ("be green"). This means that all tests pass and there are no errors. However, it is not uncommon for the CI infrastructure itself to fail on specific platforms or for so-called "flaky" tests to fail ("be red").  Each CI failure must be manually inspected to determine the cause.
CI starts automatically when you open a pull request, but only Releasers/Collaborators can restart a CI run. If you believe CI is giving a false negative, ask a Releaser to restart the tests.

Thanks


Nav Bar buttons not working

Hey i noticed that the navbar buttons don't function as required.
I would like to fix this issue and redirect to the meaningful location.
I would like to work under hacktoberfest 2024 and gssoc extd.
Thank you

@soham0005 please assign this to me under gssoc-extended and with levels.


Add parameters component

🎉 New feature
Replaces https://github.com/ignitionrobotics/ign-gazebo/pull/1280.
Summary

Adds an implementation of a parameter registry, which allows through services to:

Declare a parameter.
Get the value of a parameter.
Set the value of a parameter.
List all parameters.

The same operations can be done directly locally, using the parameters registry API.
There's also a parameters client implementation, which is just a wrapper on top of sending requests to the services.
TODO:

[ ] Add tests!!!
[ ] Open PR in ignition gazebo using this!!!

Test it

TODO
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

I will open a PR targetting ignition-transport11 instead.


Major performance and battery life issues with 2.3.0-beta1

Describe the bug
Using 2.3.0-beta 1 and a Dashbaord using popups, my device gets very warm and drains battery life when using the new bubble-card-based Dashboard.
To Reproduce
Simply use the Dashboard that is driven by bubble cards.
Expected behavior
The device to perform as well as non-bubble-card dashboards.
Informations (please complete the following information):

OS: Android
Browser/App: HA Companion App
Bubble Card version: 2.3.0-beta1
Home Assistant version:2024.9.2

Additional context
I have only begun using bubble card starting with 2.3.0-beta 1, so I cannot determine if this just started or has always been the case.  My device is a Samsung S23.
Thank you! 🍻

Hi, there is a known performance issue in the editor that I need to fix, but beside that I have a very complex full Bubble Card dashboard that runs perfectly on an old iPad.
Can you take a look at your browser console on your computer to see if there is some errors?

I did have a few errors in the console from old cards I had installed.  Removed those and have not seen any performance improvements.  Interestingly, I cannot get the blur to disable at all, regardless of choosing to hide backdrop, blur to 0, etc.  Trying to see if removing the blur would help.

You need to disable it on your first pop-up, then you need to refresh your page.

Ahh, OK, that worked!  Performance does seem to have improved with no blur and no bg, will continue to test.

Hi, I've worked on this issue in the new beta, can you tell me if it's better now?
https://github.com/Clooos/Bubble-Card/releases/tag/v2.3.0-beta.2

Unfortuantely, the high GPU and stuttering still exists on beta 2.
Here is a CPU/GPU graph while using my dashboard.  On a dashboard that includes a bubble card popup, by GPU hovers around 15% even when no popup is enabled.  When I do pop up a bubble card, even when it isn't animating (which you can see in the thermostat popup), my GPU spikes to 50%+
Dashboards that don't have popups fall to <= 5% GPU usage even when navigating in/out of them.
https://github.com/user-attachments/assets/30c59b59-d4f7-4ca3-8c96-2e6a3dca52ed

Thank you for the detailed feedback! Bubble Card use some advanced CSS styling, like the blurred background that you can see behind of the pop-ups, I've seen that you have disabled the backdrop blur, this is a good start. But have you tried to set the pop-up blur to 0 in the editor?
I will also take a look to understand why there is a spike when no pop-ups are shown.

Yep!  The popup blur is set to 0 for all popups in the editor.

Thanks for the details, I will take a look 👌

You're a champion, thank you!

One more thing, can you check your browser console to see if there is errors? I don't think so but just to be sure.

Just wanted to let you know that beta4 seems to have resolved my stuttering and performance drops with bubble card!  Thank you!

You can't imagine how happy I'm to read that!


Online discoverDomain does not model SAFRemoteContext properly

Hello,
I have discovered a SOA/BPM <IP_ADDRESS> domain by using WDT 1.9.8 and then after creating the domain I have found this issue with SAF while a BPM server was starting.

<The JMS store-and-forward (SAF) forwarder failed to connect to the remote destination "null/jms/ExamRemoteInfoQueue", because of j
avax.naming.NameNotFoundException: Unable to resolve 'jms.ExamRemoteInfoQueue'. Resolved 'jms'; remaining name 'ExamRemoteInfoQueue'
at webExamRemotec.jndi.internal.BasicNamingNode.newNameNotFoundException(BasicNamingNode.java:1292)
at webExamRemotec.jndi.internal.BasicNamingNode.lookupHere(BasicNamingNode.java:354)

I have checked the model and I have found the SAFImportedDestinations is missing a reference to SAFRemoteContext. Below you can see an example of a proper model I extracted by using the previous version of WDT. Just to be clear, my current model is missing the element in yelow.

I will fix the model manually and I will test it again.
Best regards,
TAM

After fixing the model manually the issue has been solved. However, it would be goo if extractDomain online could do it automatically

hi textanalytiicsman -
I'm able to reproduce this with online discover.
It appears to be related to issue #826 .
Attributes that reference other MBeans are not being discovered correctly.

Thanks a lot.


Minor Improvement:

Redundant 'if' statement
Add final
Fix JavDoc

Coverage decreased (-0.1%) to 84.33% when pulling 5181c9986dbd9c91a6de8d5065dd3ec49a179d7b on arturobernalg:feature/minor_improvement into 8c0d75ea88dd498ce3b33a2f95576dc06ad11461 on apache:master.


Use default system path

The path attribute of the Exec resource is too tight to find some
required tools on centos6 (e.g. 'test' is in /usr/bin, 'alternatives' is
in '/usr/sbin'). Therefore we set the path to the standard system path
which should enable required tools to be found.

Thanks @lseek


Allow level one sections in the abstract

They are optional, and used to structure the summary.

For example: https://www.scielosp.org/article/bwho/2015.v93n12/826-833/en/

Another example, from PLOS: http://journals.plos.org/plosone/article/file?id=10.1371/journal.pone.0190482&type=manuscript

Dup of #945.


Allow external members

Hello,
This pull request follows the fact, unless I am mistaken, that there is no option to add external members.
I wish this change does not impact other users.
But, I have to underline that this change implies having two more files when calling the module:
credentials.json - contains service account key
providers.json - allow to use googleworkspace provider
What do you think about it ?
Best regards,
Thanks
code template:
credentials.json:
{
"type": "service_account",
"project_id": "XXXXX",
"private_key_id": "private_key_id",
"private_key": "private_key",
"client_email"<EMAIL_ADDRESS>"client_id": "client_id",
"auth_uri": "https://accounts.google.com/o/oauth2/auth",
"token_uri": "https://oauth2.googleapis.com/token",
"auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
"client_x509_cert_url": "client_x509_cert_url"
}
providers.json:
provider "googleworkspace" {   credentials             = "./PATH/TO/KEY_FILE.json"   customer_id             = var.customer_id   impersonated_user_email = var.sa_name }

We definitely should not make downloading a service account key mandatory to use the module.

See if making the resource optional/conditional can avoid that requirement.
If not, we probably shouldn't include this.


Deployment of the ARM template will fail

#Deployment of the ARM template will fail with "Resource not found error"
Please update this page because the provided template will fail. It will throw a "resource not found" error during deployment because of how the reference to the managed identity is specified. Find the resolution in another docs.microsoft.com article (see below).
Reference: https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/error-not-found

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7feaa3d0-7233-a3cb-cb9b-a9a55b1f0d7a
Version Independent ID: f41f9d51-52f8-1f45-1043-1344a3b74458
Content: Use Key Vault references - Azure App Service
Content Source: articles/app-service/app-service-key-vault-references.md
Service: app-service
GitHub Login: @mattchenderson
Microsoft Alias: mahender

@pxmonti Thanks for the feedback. We're investigating this and will get back to you shortly.

@pxmonti Thanks for bringing this to our attention. I have submitted a PR to fix the issue that's in review.

@pxmonti Thanks again for catching that error in the docs! I have submitted a PR to fix the issue, the change is merged internally and will go-live in the public docs shortly.

You're most welcome!


dart2js_api_test started failing after IDL roll

Reproduction: python tools/test.py -mrelease --checked -t60 --use-sdk --reset-browser-configuration dart2js/analyze_api_test
Output:
sdk/lib/html/dart2js/html_dart2js.dart:34526:1:
Warning: 'TextTrackList' doesn't implement 'abstract TextTrack [](int a) inherited from List<TextTrack>' declared in 'List<TextTrack>'.
Try adding an implementation of '[]' or declaring 'TextTrackList' to be 'abstract'.
class TextTrackList extends EventTarget
^^^^^
sdk/lib/core/list.dart:162:3:
Info: The method '[]' is declared here in class 'List'.
  E operator [](int index);
  ^^^^^^^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:34459:1:
Warning: 'TextTrackCueList' doesn't implement 'abstract TextTrackCue [](int a) inherited from List<TextTrackCue>' declared in 'List<TextTrackCue>'.
Try adding an implementation of '[]' or declaring 'TextTrackCueList' to be 'abstract'.
class TextTrackCueList extends Interceptor
^^^^^
sdk/lib/core/list.dart:162:3:
Info: The method '[]' is declared here in class 'List'.
  E operator [](int index);
  ^^^^^^^^^^^^^^^^^^^^^^^^
sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:931:3:
Warning: The type '(num) -> Future' of method 'suspend' declared in 'OfflineAudioContext' is not a subtype of the overridden method type '() -> Future' inherited from 'AudioContext'.
  Future suspend(num suspendTime) native;
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:379:3:
Info: This is the overridden method 'suspend' declared in class 'AudioContext'.
  Future suspend() native;
  ^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41478:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == null;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41514:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == _namespace;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:22126:22:
Warning: The getter '_keyCode' is not defined for the class 'KeyboardEvent'.
  int get keyCode => _keyCode;
                     ^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:22129:23:
Warning: The getter '_charCode' is not defined for the class 'KeyboardEvent'.
  int get charCode => _charCode;
                      ^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:44611:9:
Warning: The getter 'keyLocation' is not defined for the class 'KeyboardEvent'.
    if (event.keyLocation == 3) {
        ^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:46116:26:
Warning: The getter 'keyLocation' is not defined for the class 'KeyboardEvent'.
  int get keyLocation => _parent.keyLocation;
                         ^^^^^^^^^^^^^^^^^^^
----------------------------------------------------------------
Unexpected messages:
----------------------------------------------------------------
sdk/lib/html/dart2js/html_dart2js.dart:34526:1:
Warning: 'TextTrackList' doesn't implement 'abstract TextTrack [](int a) inherited from List<TextTrack>' declared in 'List<TextTrack>'.
Try adding an implementation of '[]' or declaring 'TextTrackList' to be 'abstract'.
class TextTrackList extends EventTarget
^^^^^
sdk/lib/core/list.dart:162:3:
Info: The method '[]' is declared here in class 'List'.
  E operator [](int index);
  ^^^^^^^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:34459:1:
Warning: 'TextTrackCueList' doesn't implement 'abstract TextTrackCue [](int a) inherited from List<TextTrackCue>' declared in 'List<TextTrackCue>'.
Try adding an implementation of '[]' or declaring 'TextTrackCueList' to be 'abstract'.
class TextTrackCueList extends Interceptor
^^^^^
sdk/lib/core/list.dart:162:3:
Info: The method '[]' is declared here in class 'List'.
  E operator [](int index);
  ^^^^^^^^^^^^^^^^^^^^^^^^
sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:931:3:
Warning: The type '(num) -> Future' of method 'suspend' declared in 'OfflineAudioContext' is not a subtype of the overridden method type '() -> Future' inherited from 'AudioContext'.
  Future suspend(num suspendTime) native;
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:379:3:
Info: This is the overridden method 'suspend' declared in class 'AudioContext'.
  Future suspend() native;
  ^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41478:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == null;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41514:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == _namespace;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:22126:22:
Warning: The getter '_keyCode' is not defined for the class 'KeyboardEvent'.
  int get keyCode => _keyCode;
                     ^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:22129:23:
Warning: The getter '_charCode' is not defined for the class 'KeyboardEvent'.
  int get charCode => _charCode;
                      ^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:44611:9:
Warning: The getter 'keyLocation' is not defined for the class 'KeyboardEvent'.
    if (event.keyLocation == 3) {
        ^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:46116:26:
Warning: The getter 'keyLocation' is not defined for the class 'KeyboardEvent'.
  int get keyLocation => _parent.keyLocation;
                         ^^^^^^^^^^^^^^^^^^^```

These have all been fixed.


Allow controller hook methods to return an error response

It makes sense in the controller to use something like the creating() hook to abort with a JSON API error. There are two approaches that could be used:

Allow the hook method to return a response, i.e. to do return $this->reply()->errors()
Add an abort() method that throws a JsonApiException: this would need to support passing a string key that can be resolved as an error key from the errors repository.

If (2) the abort method could be added to the reply trait helper.

An additional option is to add JSON API versions of Laravel's abort, abort_if and abort_unless helpers. I.e. jsonapi_abort etc.

An example of why this is needed is in this question:
https://github.com/cloudcreativity/laravel-json-api/issues/152

The abort helpers are definitely a good idea, but do still need to support the controller hooks returning responses. For example, we have a case where we need to return 202 Accepted for an update request. Throwing an exception with abort seems overkill. The other option is to overload the doUpdate method, but it's a lot of code just to return a different response:
    protected function doUpdate(
        StoreInterface $store,
        $record,
        ResourceObjectInterface $resource,
        EncodingParametersInterface $parameters
    ) {
        parent::doUpdate($store, $record, $resource, $parameters);

        return $this->reply()->meta([
            'accepted-at' => Carbon::now()->toW3cString()
        ], 202);
    }

This would be neater:
    protected function updated()
    {
        return $this->reply()->meta([
            'accepted-at' => Carbon::now()->toW3cString()
        ], 202);
    }

Decided to not add the abort helpers for the moment. Returning a response from a controller hook is now fully supported, and that meets the immediate requirement for the moment.


Feature: Enable Machine Authentication to access Graph API Mutations

Issue #, if available:
Closes: #33
Description of changes:
This PR implements the following:

A script to automate the creation of the needed resources to enable machine authentication on the Cognito User pool:

Resource Server with a custom scope of admin
User Pool Client with client secret generation enabled along with the other needed items for machine auth flows and assigned the api/admin custom scope.

Adds and auth rule on each mutation which currently allows full access to members of the admin group that grants the same level of access to machine authentication which uses the api/admin custom scope.

I have tested these in or TEAM test environment and validated that I am able to perform the following:

Use the client_id and client_secret to obtain a token using the cognito user pool token endpoint.
Use this token to perform all queries.
Use this token to perform mutations on the Settings, Approvers, and Eligibility types.

This work will further enable a terraform provider I have been writing for managing AWS TEAM. As this is my first contribution, please let me know if there is anything I am missing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brittandeyoung  thanks for leading on this. I would review and merge once tested

@brittandeyoung thanks for leading on this. I would review and merge once tested

@tawoyinfa For clarification.
I have this currently deployed to my testing environment and it is behaving as expected.

@brittandeyoung  I am doing some internal testing. Thanks again for this

@brittandeyoung  tested and works well. Feature has now been merged. Thanks again for putting in the work

Hey @tawoyinfa , I see a placeholder for the tf code but this issue should probably be reopened for visibility, so that you don't get duplicate requests. Thanks!


Update parent-pom, run with Java 8 not 5, ci build

jboss-parent from 165 to 39
rm maven-enforcer-plugin with
requireMavenVersion >2.2.0
requireJavaVersion 1.5.0
rm java5 surefire test
fix checkstyle in code and xml
add dependabot
add ci build

the CI-run-result:
https://github.com/stbischof/descriptors/actions/runs/9253381979/job/25452935504
@petrberan please review and merge

Don't think we we'll proceed with this PR for Master branch, see https://github.com/shrinkwrap/descriptors/issues/115


Set load metadata operation asynchronous

Ⅰ. Describe what this PR does
Set load metadata operation asynchronous
For AlluxioEngine, PrepareUFS() now includes the two following steps:

Mount UFS
start a goroutine to sync metadata

In Sync() of the Alluxio Engine, the goroutine started at step 2 will be periodically checked until it completes.
The full metadata sync process includes the following 3 steps:

Load metadata(alluxio fs loadMetadata -R /)
Get total size of the UFS(alluxio fs count /)
Set UfsTotal in related Dataset resource object

As to cache status query, cachedPercentage will not be computed until UfsTotal has been set, while cached and cache capacity will update every several seconds no matter what value UfsTotal is.
Ⅱ. Does this pull request fix one issue?

Fixes #29
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Create Dataset with large amount of files and Runtime, here is an example:
apiVersion: data.fluid.io/v1alpha1
kind: Dataset
metadata:
  name: insightface
spec:
  mounts:
  - mountPoint: local:///insightface
    name: insightface
  nodeAffinity:
    required:
      nodeSelectorTerms:
        - matchExpressions:
            - key: aliyun.accelerator/nvidia_name
              operator: In
              values:
                - Tesla-V100-SXM2-16GB
---
apiVersion: data.fluid.io/v1alpha1
kind: AlluxioRuntime
metadata:
  name: insightface
spec:
  replicas: 1
  data:
    replicas: 1
  tieredstore:
    levels:
      - mediumtype: MEM
        path: /alluxio/ram
        quota: 200Gi
        high: "0.99"
        low: "0.8"
  master:
    jvmOptions:
      - " -Xmx16G "
      - " -Xms16G "

It takes about 50min to load all metadata and get total size of the UFS.
Ⅴ. Special notes for reviews
TODO(Things not done in this PR):

Asynchronous operations can be optimized
Provide an option for user to enable/disable automatic UFS initialization when preparing UFS

TODOs may be done in future PRs.

@xieydd here is the design docs: https://github.com/fluid-cloudnative/community/blob/master/proposals/controller/v0.3.0_metadata_init.md

Codecov Report

Merging #225 into master will decrease coverage by 0.60%.
The diff coverage is 0.98%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   18.82%   18.22%   -0.61%
==========================================
  Files          47       49       +2
  Lines        2003     2113     +110
==========================================
+ Hits          377      385       +8
- Misses       1587     1688     +101
- Partials       39       40       +1

Impacted Files
Coverage Δ

pkg/ddc/alluxio/cache.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/engine.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/metadata.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/ufs.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/ufs_internal.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/utils.go
48.00% <ø> (+16.96%)
:arrow_up:

pkg/ddc/base/setup.go
36.92% <0.00%> (-0.58%)
:arrow_down:

pkg/ddc/alluxio/operations/base.go
53.22% <3.84%> (-8.27%)
:arrow_down:

pkg/ddc/base/syncs.go
36.84% <33.33%> (-0.66%)
:arrow_down:

pkg/ddc/alluxio/create_volume.go
0.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be59e0e...574b3fe. Read the comment docs.

/lgtm
/approve


pre-commit hook invalid value

Using pre-commit hook generates the following error:
databooks................................................................Failed
- hook id: databooks
- exit code: 2

Usage: databooks meta [OPTIONS] PATHS...

Error: Invalid value: No prefix nor suffix were passed. Please specify `--overwrite` or `-w` to overwrite files.

this is the .pre-commit-config.yaml
repos:
-   repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.1.0
    hooks:
    -   id: trailing-whitespace
    -   id: end-of-file-fixer
    -   id: check-yaml
    -   id: check-added-large-files
-   repo: https://github.com/psf/black
    rev: 22.1.0
    hooks:
    -   id: black-jupyter
        language_version: python3.9
-   repo: https://github.com/datarootsio/databooks
    rev: 0.1.15
    hooks:
    -   id: databooks

As of now, you need to pass in the --check argument in pre-commit
repos:
-   repo: https://github.com/datarootsio/databooks
    rev: 0.1.15
    hooks:
    -   id: databooks
        args: ["--overwrite"]

Check out docs for more info! 🚀


Adapt compile_visit() to handle new Qualtrics & NR Limits

Audiogram NR Limits:
https://docs.google.com/spreadsheets/d/1FSpYrLNURykoDLl8o3680qPla7as94uO1xTv0eG83a8/edit#gid=0

@hausersn1 do you think you can get the identifiers for the audiograms (e.g. 'DD450', 'BC81') that correspond to a given transducer? Then a few lines in `parseAudiogram' need to be changed. I've tagged you in those lines.
To keep things flexible for the data analyzer:

Titan Reflexes now output as strings (so NR and CNT results are readable as such)
AC/BC outputs the max levels for all frequencies of the chosen transducer in the metadata. It specifically does not ONLY output values at the tested frequencies in case R/L have differently tested frequencies.

Once the lines in parseAudiogram are changed, code is tested, should be good for a PR.