Error: Couldn't launch the stream

Was working before but i was getting InsecurePlatformWarning so i updated python to 2.7.10 and reinstalled livestreamer and now i get this error every time. Using the macx64 version

Launching livestreamer manually via terminal works.

Hm, strange. I don't know why this is happening.
Seems like something is causing this JS-Promise chain to be rejected without any error output. It could be this method here, since everything else should return an error message.
Would you please be so kind and debug the application for me and then see where this error is coming from? Just go through the chain step by step and see what is happening.
You can find all the necessary NW.js informations in CONTRIBUTING.md

Hello. I can second that. Also using Mac64 version, also was getting the same error, also updated python and also having the same error now.
I would like to debug the app for you, but I have no idea how to do it. I am very casual user.

What is the output of livestreamer --version --no-version-check ?

It says: livestreamer 1.12.2

hmm, this is weird. I did the grunt dev and ran nw.js from build/tmp folder. But now when i run the nw.js for debugging, it runs smoothly without any problems. Same error in main application.

Okay, that's weird... Thanks for taking the time finding a fix :+1:
The main problem with OSX apps on Yosemite is, that you're unable to read the user's $PATH from within the application, so searching for livestreamer in all these paths is impossible. See the fix of #55: the solution was adding a fallback path (/usr/local/bin/livestreamer) hardcoded into the app. That's why it was working from the shell, because it was looking for livestreamer in a different location.

Sorry, so how will I make it work?

In the settings tab in the app just add this line, "/Library/Frameworks/Python.framework/Versions/2.7/bin/livestreamer" Change 2.7 with ur python version. use the command "which python" in terminal to find ur default version.

Thank you and thanks for this amazing app. Everything works now.

On 27 May 2015, at 12:51 am, Varun<EMAIL_ADDRESS>wrote:
In the settings tab in the app just add this line, "/Library/Frameworks/Python.framework/Versions/2.7/bin/livestreamer" Change 2.7 with ur python version. use the command "which python" in terminal to find ur default version.
https://cloud.githubusercontent.com/assets/6782462/7825216/82eb8786-044d-11e5-9d6e-b5683ba94289.png
—
Reply to this email directly or view it on GitHub https://github.com/bastimeyer/livestreamer-twitch-gui/issues/99#issuecomment-105691043.

I've added /Library/Frameworks/Python.framework/Versions/Current/bin to the livestreamer OSX fallback paths...
thanks, @Blackrame


Suggestion: Add a "back" button

If possible, it would be nice to have the option to just click "back", instead of opening the history window.

I suppose it may be worth noting that I don't seem to be able to get back to the main page from the big talents list without refreshing the page. So even if a back button would break character creation, that seems like a place that could use it.

You can click on the STA logo at the top of the page to return to the main page.


[dependencies] Replace xattr with builtin os.setxattr

Use stdlib xattr support instead of the external dependency
Closes #8193
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at ef690c7
Summary
🗑🐧🏷

Simplify and improve xattr metadata writing on Linux. Remove xattr and pyxattr dependencies and use os.setxattr instead. Update README.md and docstrings accordingly.

No more xattr, no more pyxattr
We don't need them to write our metadata
We use os.setxattr to set our flags
We are the masters of the extended attributes

Walkthrough

Simplify and improve the writing of xattr metadata on Linux by using the built-in os.setxattr function (link, link, link)
Update the docstring of the XAttrMetadataPP class to reflect the new assumption of xattr support on Linux (link)
Remove the mention of xattr, pyxattr and setfattr from the README.md file, as they are no longer required dependencies (link)

I would add a test if feasible

Especially for Darwin, BSD: https://github.com/yt-dlp/yt-dlp/issues/8193#issuecomment-1734589913

Honestly not sure how we can test this effectively. If you have ideas feel free to suggest

Hmm, was having a think about tests. One could possibly do some unit tests on write_xattr. However I ran into a problem where I wanted to create a tempfile to write the xattrs to but the temp file fs doesn't support xattrs.
    @unittest.skipUnless(callable(getattr(os, 'setxattr', None)), 'setxattr not available')
    def test_write_xattr_os_xattr(self):
        with mock.patch('os.setxattr', wraps=os.setxattr) as mock_setxattr:
            with tempfile.NamedTemporaryFile(delete=False) as temp_file:
                attr_name = 'user.dublincore.title'
                attr_value = b'testvalue'

                try:
                    write_xattr(temp_file.name, attr_name, attr_value)
                    mock_setxattr.assert_called_once()
                    retrieved_value = os.getxattr(temp_file.name, attr_name)
                    self.assertEqual(retrieved_value, attr_value)
                finally:
                    os.remove(temp_file.name)


fix evaluating template strings from info.plist

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
Reported by @brentvatne

Project: https://github.com/brentvatne/runverter-cloud
How
evaluateTemplateString didn't always receive the correct type of the vars argument.
It was sometimes a plain object (it has .hasOwnProperty) and sometimes a class object (without .hasOwnProperty).
Solution: convert the argument to plain object.
Test Plan
Tested with https://github.com/brentvatne/runverter-cloud

/changelog-entry bug-fix Fix reading app version and app build version of iOS projects.


Test Azure Generator Plugin with MgmtTypespec

Library name
N/A
Please describe the feature.
Eventually, Azure Generator Plugin will be able to generate .NET SDK correctly with MgmtTypeSpec.
Investigate the feature gaps and blockers during the test.

Pending on https://github.com/microsoft/typespec/issues/4326


Added V8 of the Sprig Case

Added yet another iteration of my Sprig Case

Thank you for your contributions.  Let's resume this in a couple of months.


Create Controller for Root Object

Issue description
See: https://github.com/microstream-one/microstream/blob/master/storage/rest/service-sparkjava/src/main/resources/doc.json#L4-L28

Closed via https://github.com/micronaut-projects/micronaut-microstream/pull/40


containers: add support for interface "io.edgehog.devicemanager.apps.CreateNetworkRequest"

ref: #614
interface: https://github.com/edgehog-device-manager/edgehog-astarte-interfaces/pull/64/files#diff-258da14d2e6216489be718c3d8fbde8dad6760a84465ac05c76945a3dea12970

closed by #690


Requires a replot to show parallel route lines

It should show them in parallel when plotted but they overlap until you do a replot.

fixed


DRILL-5761: Disable Lilith ClassicMultiplexSocketAppender by default

LGTM. +1

I have some concern about this PR.
AFASIK, some of Drill developers use Lilith to debug issues when running individual unit testcases.  If remove it,  does it mean people has to manually reverse this PR, in order to get log in  Lilith?
If you shutdown Lilith application while running unit test suite, does it hang as well?

Unit tests hang when Lilith application is not running, but when ClassicMultiplexSocketAppender in logback.xml is defined and used in the loggers.

@vvysotskyi is it possible to change the port number for Lilith to avoid the conflict?

@priteshm, as I have mentioned in the Jira DRILL-5761, port in Lilith UI cannot be changed (https://github.com/huxi/lilith/issues/10).

Per this hive doc, seems it's possible to change hiveserver2 port #.
Can you try to change hivesever2# if the other one is hardcoded?

https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2

Yes, we can change hiveserver2 port #, but I think that it would be better to disable Lilith by default since hiveserver2 port number may be used in the configs of other applications and it would be cumbersome to change all that configs.

We have run unit in our test clusters and I never hear that people complained that unit tests failed due to Lilith.

I have implemented the proposal of @vrozov to conditionally enable Lilith appender. I have used ThresholdFilter in Lilith appender, so it was not needed to change all places where it is used.
An example of how to enable Lilith was added to the Jira description.
@jinfengni, @vrozov could you please take a look?

The proposal from @vrozov makes sense to me. As long as Lilith is not completely disabled, I'm fine with it.

Holding of on the merge waiting for review by @vrozov.

@paul-rogers, @vrozov, thanks for the review. Squashed commits and rebased onto master.


Pure json response from jsonSerialize

Fixes #547

@zek Could you include a test for this? One that failed in the situation before your change, and now works with your change.

One that failed in the situation before your change, and now works with your change.
I am not familiar with testing. I don't know how can I test "before your change" part but I added second part.

This PR actually is not critical but before this PR jsonSerialize function returns currency object.
array(2) { ["amount"]=> string(3) "100" ["currency"]=> object(Money\Currency)#738 (1) { ["code":"Money\Currency":private]=> string(3) "EUR" } }

I believe we must return
array(2) { ["amount"]=> string(3) "300" ["currency"]=> string(3) "EUR" }

Thanks, look good to me. @sagikazarmark What do you think?

Thanks @zek!

@zek @frederikbosch Thank you very much, guys! ☺


webpackChunkName bug

Do you want to request a feature or report a bug?
this is a bug for magic comment

What is the current behavior?
chunkFilename is wrong
If the current behavior is a bug, please provide the steps to reproduce.
webpack.conf.js
...
output: {
        path: path.resolve('./dest/'),
        filename: '[name].js',
        chunkFilename: 'chunk-[name].js'
    },
module: {
        rules: [
            {
                test: /\.js$/,
                loader: 'babel-loader',
                exclude: /node_modules/,
                include: path.resolve('./src/abc') // if './bcd' || './xxx', it will be ok
            }
        ]
    }
...

project structure
|--src
    |--abc
        |--async.js
        |--entry.js

entry.js
import(/* webpackChunkName: "async" */ './async');

if webpack.conf.js  module.rules.include the same as project structure， chunkFimename will be wrong,
otherwise it will be ok

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
os: win7
nodejs: 4.3.0
webpack: 2.6.1 || 3.0.0

I found the cause of the problem ：）

@lemonleon Will you please detail what the cause and solution to the problem were?

Hi @atodd, this problem is caused by the configuration of the .babelrc.
When you set "comments": false in .babelrc, will cause what I said above. And if you not set it, the problem won't happen.

Thanks @lemonleon!  I never would have found that.

Am I doing something wrong here?
webpack.conf.js
output: {
    path: path.resolve(__dirname, 'dist'),
    filename: 'bundles/[name].[hash].js',
    publicPath: '/',
    chunkFilename: "[name].js"
  }

routes.js (angularjs)
{
      state: 'account.**',
      url: '/account',
      lazyLoad: ($transition$) => {
        let $ocLazyLoad = $transition$.injector().get('$ocLazyLoad');
        return import(/* webpackChunkName: "account" */ '../modules/account/account.module.js').then(loadedModule => $ocLazyLoad.load(loadedModule.ACCOUNT_MODULE))
      }
    }

And I'm getting:


Add basic CSS and a navbar

I used Skeletron to build a basic interface in order to work properly. Just wanted to do it. I'm kinda tired of maths.

Thanks man <3
I'm going to riff on what you did !


Helpful commands

Hi, maybe it's good idea add helpful commands like:
ImportFromBackUp
ExportToBackUp
CleanTableData
CreateTablesFromClassAnnotation
What do you think ?

backup and/or restoration of DynamoDB is actually very tricky and is only directly supported in AWS' console (and they only support full non-incremental backup).
create table command is already supported by  odm:schema-tool:create, we also have update & drop commands as well.
cleaning table data is not that straight forward however. I suggest you simply drop&create the table again from command line. If within the code, you can get the repository and call removeAll()

I got it, thx


Atom update to 1.9 Restart and Install (with admin privileges) does not work

Prerequisites

[x] Can you reproduce the problem in safe mode?
[ ] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
I am having the same problem described in the two threads mentioned below, but I have admin rights. Also, there is no "Restart and install" button anywhere on the 'About' page.
https://github.com/atom/atom/issues/12072
https://github.com/atom/atom/issues/2860
Here's the console (the shipit lines repeat continually):
8/3/16 10:57:25.452 AM Atom[81604]: Download completed to: file:///Users/name/Library/Application%20Support/com.github.atom.ShipIt/update.H8PaFW2/atom-mac.zip
8/3/16 10:57:27.071 AM com.apple.xpc.launchd[1]: (com.github.atom.ShipIt[82050]) Service exited with abnormal code: 1
8/3/16 10:57:27.071 AM com.apple.xpc.launchd[1]: (com.github.atom.ShipIt) Service only ran for 0 seconds. Pushing respawn out by 2 seconds.
8/3/16 10:57:29.091 AM com.apple.xpc.launchd[1]: (com.github.atom.ShipIt[82052]) Service exited with abnormal code: 1
8/3/16 10:57:29.091 AM com.apple.xpc.launchd[1]: (com.github.atom.ShipIt) Service only ran for 0 seconds. Pushing respawn out by 2 seconds.

And the shipit stderr output in Users/name/Library/Application%20Support/com.github.atom.ShipIt:
2016-08-03 11:08:11.385 ShipIt[82643:1574792] ShipIt quitting
2016-08-03 11:08:13.409 ShipIt[82644:1574817] Installation error: Error Domain=SQRLShipItRequestErrorDomain Code=2 "Could not read update request" UserInfo={NSLocalizedDescription=Could not read update request, NSUnderlyingError=0x7faea9f00a10 {Error Domain=NSCocoaErrorDomain Code=260 "The file “ShipItState.plist” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/var/root/Library/Application Support/com.github.atom.ShipIt/ShipItState.plist, NSUnderlyingError=0x7faea9f00210 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}}}

But ShipItState.plist exists in the same folder.
Steps to Reproduce

Open up atom 1.8, which opens a new atom helper install dialog.
Enter password into the dialog and click 'OK'.
Go to Atom > Restart and Install.

Expected behavior: [What you expected to happen]
Atom closes, updates, and restarts into 1.9.
Actual behavior: [What actually happened]
Atom closes, does not restart, and has not changed from 1.8 upon re-opening.
Versions
OSX 10.11.4
$ atom --version
Atom    : 1.8.0
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

The 'Atom' application in the update folder works--can I just move it over?

I just ran the update.
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1```

First update apparently failed. Downloaded, but restart never happened.

Started again using `atom -f -w`.
Downloaded, updated, restarted.

You can check the log files to see if there's something useful in there.
`/Users/name/Library/Application Support/com.github.atom.ShipIt`

I cleared out my log files so I can't tell why it went wrong the first time.

MAC OSX 10.11.6
$ atom -f -w
[10330:0819/003548:WARNING:resource_bundle.cc(311)] locale_file_path.empty() for locale English
2016-08-19 00:35:48.684 Atom[10330:14471228] App load time: 352ms
[10330:0819/003549:INFO:CONSOLE(52)] "Window load time: 271ms", source: file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js (52)
[10330:0819/003550:INFO:CONSOLE(0)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)
2016-08-19 00:35:57.213 Atom[10330:14471366] Download completed to: file:///Users/owl/Library/Application%20Support/com.github.atom.ShipIt/update.kKKNl4r/atom-mac.zip

I switched to other system user two months ago, maybe this is the reason of the issue, I click "Restart and install" button, Atom closes and never opens again. When i open Atom manually i see the same version number as before updating. I tried to change owner and permissions of package contents in "Applications" folder, i deleted "~/.atom". Nothing helps.

  And as much as that claim that it has been fixed is backed up, I still have to end up manually downloading and copying over.

Here are my results when Atom (1.10.2) tries to update:
2016-10-17 13:12:40.785 ShipIt[42401:55939] Installation error: Error Domain=SQRLShipItRequestErrorDomain Code=2 "Could not read update request" UserInfo={NSLocalizedDescription=Could not read update request, NSUnderlyingError=0x7fd828d00ab0 {Error Domain=NSCocoaErrorDomain Code=260 "The file “ShipItState.plist” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/var/root/Library/Application Support/com.github.atom.ShipIt/ShipItState.plist, NSUnderlyingError=0x7fd828d00930 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}}}
2016-10-17 13:12:40.786 ShipIt[42401:55939] ShipIt quitting

Now if I check the contents in my user directory, we can see the update and related files have been downloaded there.
$ cat /Users/revolver/Library/Application\ Support/com.github.atom.ShipIt/
ShipItState.plist  ShipIt_stderr.log  ShipIt_stdout.log  update.p5eC1Vi/
So now the question is, why the hell is the update looking in the /var/root directory and not where it actually downloaded the update files???

So I cp'ed the ShipItState.plist from my ~/Library/Application\ Support/com.github.atom.ShipIt/ folder to /var/root/Library/Application\ Support/com.github.atom.ShipIt
Then I clicked Restart & Install Update and here are the resulting logs:
2016-10-17 13:29:16.013 ShipIt[54105:76856] ShipIt quitting
2016-10-17 13:29:24.649 ShipIt[54114:77108] Beginning installation
2016-10-17 13:29:34.398 ShipIt[54114:77110] Moved bundle from file:///Applications/Atom.app to file:///var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/com.github.atom.ShipIt.qua6xfv6/Atom.app
2016-10-17 13:29:34.398 ShipIt[54114:77110] Moved bundle from file:///var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/com.github.atom.ShipIt.EVwrr2U4/Atom.app to file:///Applications/Atom.app
2016-10-17 13:29:35.275 ShipIt[54114:77110] Couldn't remove owned bundle at location file:///var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/com.github.atom.ShipIt.EVwrr2U4/Atom.app, error NSError { domain: NSCocoaErrorDomain, code: 4, description: "“Atom.app” couldn’t be removed.", failureReason: "The file doesn’t exist.", underlying error: NSError { domain: NSPOSIXErrorDomain, code: 2, description: "The operation couldn’t be completed. No such file or directory" }, userInfo: {
    NSFilePath = "/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/com.github.atom.ShipIt.EVwrr2U4/Atom.app";
    NSUserStringVariant =     (
        Remove
    );
} }
2016-10-17 13:29:36.043 ShipIt[54114:77110] Installation completed successfully
2016-10-17 13:29:36.045 ShipIt[54114:77110] ShipIt quitting

So it was able to copy in the new binary for the update.  But it seems like the updater wants to always search /var/root instead of ~/ like it really should.  Please fix...

I am having this exact same problem:

updates are downloading to my user's App Support folder
updater is looking for it in the root user's App Support folder

This still doesn't seem to work in normal user accounts, or even Administrator accounts.
But here is the workaround - enable logging in as the root user, and update atom once you've done that.
It may take a minute or so after Atom has closed, but eventually it should start up again.
If you're into keeping proper security precautions your dev environment is under a standard user and will have to go through the above to update Atom.


Unable to bind an event on a combobox

I'm not sure if this is a bug or user error.  This is on the master branch.
# example.py
from guietta import Gui, CB

def change(gui, value):
    print(value)

gui = Gui(
    [CB("op", ["a", "b", "c"])]
)

gui.events([change])
gui.run()

Errors with
Traceback (most recent call last):
  File "/nix/store/qkci2s9sqjdbr3dlzvlnv7xywma2s296-python3-3.7.6-env/lib/python3.7/site-packages/guietta/guietta.py", line 1387, in _connect
    signal = getattr(widget, signal_name)
AttributeError: 'ContextQComboBox' object has no attribute 'textActivated'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "guietta-example.py", line 9, in <module>
    gui.events([change])
  File "/nix/store/qkci2s9sqjdbr3dlzvlnv7xywma2s296-python3-3.7.6-env/lib/python3.7/site-packages/guietta/guietta.py", line 1631, in events
    _connect(self, item, signal_name, slot)
  File "/nix/store/qkci2s9sqjdbr3dlzvlnv7xywma2s296-python3-3.7.6-env/lib/python3.7/site-packages/guietta/guietta.py", line 1390, in _connect
    (signal_name, str(widget.__class__))) from e
ValueError: No signal textActivated found for widget <class 'guietta.guietta.ContextQComboBox'>

I think the issue may be that this signal was added in Qt 5.14, whereas I have Qt 5.12.
It appears perfectly fixed to my eye by mucking with the default signals to use currentTextChanged
from PySide2.QtWidgets import QComboBox
guietta._default_signals[QComboBox] = 'currentTextChanged'

You are right, I changed the default signal. I didn't notice that this signal was so new.


jarek/8196: add an example of executing shell commands

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Synchronization - Clean subpass dependency init

Fix incorrect subpass dependency initialization -- addressing validation issue.

@reduz  -- I noticed one of my changes was disabled... then I noticed it was my fault...

Thanks!

@akien-mga @reduz -- the honors are still about even.  Fixing that bug exposed a critical issue in my next major update... so godot continues to be a great test case for me.


Incorrect y_min and y_max acceptance criteria for MixtureDensityEstimator.pdf

Problem
The current implementation in line 175-176 will break if y_min = 0 or y_max = 0 supplied by the programmer, since if 0 will always evaluate to if False.
https://github.com/koaning/scikit-mdn/blob/e471b056439c17d179ed11522c4a26d9b33f4ed2/skmdn/__init__.py#L175-L176
Solution
Will create a PR to address this as instructed by probabl's YouTube admin.

Closing due to merger.


Is there a way to fix this avoiding serde?

Hi people! Thanks for your amazing work! I'm new to Rust and I'm using serde only to do this easy thing. I think I can use nanoserde instead but I don't know how.
I'm using serde like this:
use serde::Deserialize;

#[derive(Deserialize, Clone)]
pub struct Player {
    pub team: Team,
}

#[derive(Deserialize, Clone)]
pub struct Team {
    pub id: String,
    // others here
}

// ...

if api_call.status().is_success() {
    match serde_json::from_slice::<Player>(
        &hyper::body::to_bytes(api_call.into_body()).await.unwrap(),
    ) {
        Ok(player) => {
            // use player.team here

            // do something else
        }
        Err(err) => {
            eprintln!("{err}");
        }
    }
}

I tried with:
match nanoserde::DeBin::de_bin::<Player>(
   &hyper::body::to_bytes(api_call.into_body()).await.unwrap(),
) {
  // ...
}

with no luck: it doesn't like the generics.
And tried this too:
let player: Player = nanoserde::DeBin::deserialize_bin(
  &hyper::body::to_bytes(api_call.into_body()).await.unwrap(),
).unwrap();

but this doesn't work, error:
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Bin deserialize error at:8 wanted:1 bytes but max size is 1161', src\cli.rs:85:10

What does this mean?
Is there a way to fix this?

Instead of
use serde::Deserialize;

#[derive(Deserialize, Clone)]
pub struct Player {
    pub team: Team,
}
...

you need to use the appropriate nanoserde type. Something like
use nanoserde::{DeBin, SerBin};

#[derive(DeBin, SerBin, Clone)]
pub struct Player {
   pub team: Team,
}
...

Thank you. Of course I changed it.

This exact scenario (deserialization of nested structs) is tested extensively already, so I'm not sure how to help with this beyond what I suggested before. You might consider binding the hyper::body::to_bytes(api_call.into_body()).await.unwrap() to a temporary variable to confirm the values look ok, but without a repro I can run there's not much else I can do here. Hope you've been able to solve this.

On second thought, after reading through it again, it looks the endpoint may still have been giving json, and you've attempted to deserialize it as binary.

#[derive(DeJson,, Clone)]
pub struct Player {
   pub team: Team,
}

with
match nanoserde::DeJson::deserialize_json::<Player>(
   &hyper::body::to_bytes(api_call.into_body()).await.unwrap(),
) {
  // ...
}

might give you what you needed.


Typofix #76: Removed the old text from the django-tenants-schema …

Here is the typofix for issue: https://github.com/tomturner/django-tenants/issues/76

Thanks


Update with desired object in APIUpdatingApplicator

Description of your changes

This modifies the behavior of the APIUpdatingApplicator to update with
the desired object by setting its resource version to that of the
current. This ensures that a successful update will result in the object
being modified to match the desired by default. Consumers of this
Applicator no longer are required to pass in an UpdateFn to avoid no-op
updates.
Signed-off-by: hasheddan<EMAIL_ADDRESS>Fixes #191
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the RBAC permissions in clusterrole.yaml to include any new types.

@negz you indicated on #191 that you were fine with this approach, but could you give a drive by approval just to confirm you are aware of this API change?


Entering deadlock when parsing prescriptions

I have tested some basic code from the tutorial with the MIMIC-4 dataset. But the process hanged. I press ctrl-C to exit the program and it gives the following call stacks. Seems like parallel_apply get into a deadlock or something else when parsing prescriptions.
reproducing code
import logging
from pyhealth.datasets import MIMIC4Dataset

logger = logging.getLogger("pyhealth")
logger.setLevel(logging.DEBUG)

dataset = MIMIC4Dataset(
    "/home/featurize/data/mimic-iv-2.2/hosp",
    tables=["diagnoses_icd", "procedures_icd", "prescriptions", "labevents"],
    code_mapping={"NDC": ("ATC", {"target_kwargs": {"level": 3}})},
)

Callstacks after ctrl-C
Loaded NDC->ATC mapping from /home/featurize/.cache/pyhealth/medcode/NDC_to_ATC.pkl
Loaded NDC code from /home/featurize/.cache/pyhealth/medcode/NDC.pkl
Loaded ATC code from /home/featurize/.cache/pyhealth/medcode/ATC.pkl
Processing MIMIC4Dataset base dataset...
INFO: Pandarallel will run on 6 workers.
INFO: Pandarallel will use Memory file system to transfer data between the main process and workers.
finish basic patient information parsing : 80.05470561981201s
finish parsing diagnoses_icd :<PHONE_NUMBER>1007996s
finish parsing procedures_icd : 57.97325396537781s

^CTraceback (most recent call last):
  File "main.py", line 7, in <module>
    dataset = MIMIC4Dataset(
  File "/home/featurize/work/PyHealth/pyhealth/datasets/base_ehr_dataset.py", line 130, in __init__
    patients = self.parse_tables()
  File "/home/featurize/work/PyHealth/pyhealth/datasets/base_ehr_dataset.py", line 190, in parse_tables
    patients = getattr(self, f"parse_{table.lower()}")(patients)
  File "/home/featurize/work/PyHealth/pyhealth/datasets/mimic4.py", line 307, in parse_prescriptions
    group_df = group_df.parallel_apply(
  File "/environment/miniconda3/envs/py38/lib/python3.8/site-packages/pandarallel/core.py", line 307, in closure
Process ForkPoolWorker-28:
Process ForkPoolWorker-31:
Process ForkPoolWorker-30:
Process ForkPoolWorker-32:
Process ForkPoolWorker-33:
Process ForkPoolWorker-29:
    message: Tuple[int, WorkerStatus, Any] = master_workers_queue.get()
  File "<string>", line 2, in get
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/managers.py", line 835, in _callmethod
Traceback (most recent call last):
Traceback (most recent call last):
Traceback (most recent call last):
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/pool.py", line 114, in worker
    task = get()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/pool.py", line 114, in worker
    task = get()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/pool.py", line 114, in worker
    task = get()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/queues.py", line 355, in get
    with self._rlock:
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/queues.py", line 356, in get
    res = self._reader.recv_bytes()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/queues.py", line 355, in get
    with self._rlock:
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/synchronize.py", line 95, in __enter__
    return self._semlock.__enter__()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/connection.py", line 216, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/synchronize.py", line 95, in __enter__
    return self._semlock.__enter__()
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/connection.py", line 414, in _recv_bytes
    buf = self._recv(4)
  File "/environment/miniconda3/envs/py38/lib/python3.8/multiprocessing/connection.py", line 379, in _recv
    chunk = read(handle, remaining)
KeyboardInterrupt
KeyboardInterrupt
KeyboardInterrupt

I changed the parallel_apply to normal apply and everything went well.

sounds good, it might be the issue in the new pandas version then... But the MIMIC-IV data is large and parallel_apply might be necessary to accelerate the process. I will dig into it.

which version of pandas do you use?

pandas==1.5.3
pandarallel==1.6.5

actually, I think it's an issue of pandarallel, I think we can close the issue here. Shall we close this issue?

What version of pandarallel is needed?


Only load batches that can be rendered

Closing as this was fixed in v2.3.x (using commit: https://github.com/RicoNijeboer/laravel-to-swagger/commit/a85cc1fb166ed7d6d040447e489c225eb0a35984)


correct floats to float

The entire grid system (mixins and predefined classes), which switch from floats to display: flex;.

may be floats is right.if so,ignore this please

It's right.


Can't get plugin to work

Thank you for a very needed plugin!
Unfortunately, I can't get the plugin to work. I have added folders to scan and folders to ignore in the settings. Created a page with a dataview query and then used cmd+p and used the serializer-plugin but nothing happens.
Tell me if you need some more details.

Hello,
Let's try and fix that. Can you share the text of the note where you have added the query?
Also, could you:

Hit CTRL + SHIFT + I to open the developer tools
Run the command again
Share the output (if any) in the console?

This might help understanding what's going wrong.

When you say you have "created a page with a dataview query", did you create it as documented (iow, with the <!-- QueryToSerialize:  html comments)? When the plugin functions correctly, you do not have to cmd+p to kick off the serialization, it happens automatically (I believe whenever Obsidian writes the file to disk).

Yes, it's automatic when you modify a file that is part of the folders to scan and note in the ignore list.
Could you create/share a sample vault reproducing this issue?

Sorry, my fault! I didn't see the link to the documentation under Readme. So I didn't know about the HTML code that's needed. Sorry again, and consider this issue closed. :)

Great 👍


Build break by missing file or directory react/jsx-runtime?inside-island

What version of HonoX are you using?
0.1.14
What steps can reproduce the bug?

use React renderer
have some inside islands
run build

vite.config.js
import pages from '@hono/vite-cloudflare-pages'
import honox from 'honox/vite'
import client from 'honox/vite/client'
import { defineConfig } from 'vite'

export default defineConfig(({ mode }) => {
	if (mode === 'client') {
		return {
			build: {
				rollupOptions: {
					input: ['./app/client.ts', './app/style.css'],
					output: {
						entryFileNames: 'static/client.js',
						chunkFileNames: 'static/assets/[name]-[hash].js',
						assetFileNames: 'static/assets/[name].[ext]',
					},
				},
				emptyOutDir: false,
			},
			plugins: [client()],
		}
	} else {
		return {
			ssr: {
				external: ['react', 'react-dom'],
			},
			plugins: [honox(), pages()],
		}
	}
})

What is the expected behavior?
Build application without error.
What do you see instead?
error during build:
Error: [vite:load-fallback] Could not load react/jsx-runtime?inside-island (imported by app/islands/episode-list.tsx): ENOENT: no such file or directory, open 'react/jsx-runtime?inside-island'

Additional information
No response

Hi @jonasnobile
This is fixed with the new version 0.1.15. Try it!
And if you want to build React, you have to specify jsxImportSource like the following:

export default defineConfig(({ mode }) => {
  if (mode === 'client') {
    return {
      // ...
      plugins: [
        client({
          jsxImportSource: 'react', // <--- Add
        }),
      ],
    }
  } else {
    return {
      ssr: {
        external: ['react', 'react-dom'],
      },
      plugins: [honox(), pages()],
    }
  }
})


Entities with long lineage lists cause 414 errors in rest.li

Describe the bug
When an entity attempts to fetch its lineage, datahub-frontend issues a batch-get call to gms with each entity urn in the url.  If the entity has too many downstream or upstream dependencies, this URI can exceed rest.li's limit.
There is a way to send batch gets to rest.li via post:
https://linkedin.github.io/rest.li/Send-Rest_li-Request-Query-In-Request-Body
However, this does not seem to be supported by the generated rest.li client. We have opened an issue on rest.li's github to resolve this: https://github.com/linkedin/rest.li/issues/603
To Reproduce
Steps to reproduce the behavior:

Create an entity with 100+ downstream dependencies
Attempt to view that entity in the react app

Expected behavior
This should load as expected

Fixed by #2462


Prepare for 0.1.0 release

Automate the generation of the release artifacts. This has been started, PR will hopefully come up shortly. (To be honest, I feel a bit distracted right now and it's hard to focus on spare-time programming projects. :ukraine:, you have my full support. :grimacing:)

One thing not yet fixed is the naming of the artifacts. Right now they get names like perlang-0.1.0-dev.227-linux-x64.tar.gz. It should be 0.1.0, without any suffix or anything. The same goes with the version reported by perlang -V.
(How can we do this, i.e. distinguish between a tagged and an untagged commit?)

Write (or generate) some release notes. Note: should we keep these in the repository, somewhere under docs? :thinking: Perhaps docs/release-notes/index.md. Need to think about this part since it'll be reflect in the URI. Some examples seen on the web:

Sequel: https://github.com/jeremyevans/sequel/blob/master/CHANGELOG: The easiest way to handle it do it like this: keep it in a single file, in the repo, where a new entry is just generated for each release. Harder to automate with https://github.com/softprops/action-gh-release that way, though.
Ruby: The Ruby project seems to create a news blog post for each release: https://www.ruby-lang.org/en/news/2022/02/18/ruby-3-1-1-released/
Postgres JDBC: This is a pretty nice example, where the file is readable in rendered form in GitHub (and perhaps elsewhere?): https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md

I think we'll live with not automating this part fully for now. It's not the end of the world if this part of the process is manual.

We have to think how it should work, though. What if... it would be something like this:

I create a git tag each time I want to make a release, v0.1.0 or similar. Preferably a GPG-signed tag to enhance security a bit.
The GitHub Actions workflow detects this tag (v*) and creates the release. However, the release is still created as a draft.
Hmm, thinking loudly as a I type here. It would surely be nice to fully automate it after all. Perhaps we'll need to go with an approach like this:

Create the release notes as separate files, under docs/, release-notes/ or whatever.
Add a make target which concatenates them into a combined CHANGELOG.md or similar.
We can then get the best of all worlds: fully automated releases and a readable full changelog in the repo. Perhaps this will be one of the better approaches.

This has been completed in its entirety, and v0.1.0 has been released. Closing issue. :tada:


Add a custom -f option to read a m3u8 playlist from a file if a .m3u8 playlist file is available

Is your feature request related to a problem? Please describe.
Addition of a -f option will allow users to read the m3u8 playlist from a file if a file is available, this will allow users to pass in the file path if the playlist has already been downloaded.
Describe the solution you'd like
We can add a cli option -f that on invokation will look like m3u8-dl -f <relative/absolute path-of-playlist> this would allow users to read the playlist from a file, all other functionality will work AS-IS.
Additional context
The python library m3u8 maybe used to accomplish this task https://pypi.org/project/m3u8/

Can I take this issue?

I think it would be better if we just check is it URL or file path. If its file path, then just open it.

Yeah feel free to pick it up @lcd1232

I think it would be better if we just check is it URL or file path. If its file path, then just open it.

Sounds good.


How do I install a library with multiple specific modules?

For example, when I try to install PCL with vcpkg , the command "vcpkg search pcl" shows that there are
pcl                      1.12.0#2         Point Cloud Library (PCL) is open source library for 2D/3D image and point...
pcl[apps]                                 Build application examples/samples that show how PCL works
pcl[cuda]                                 CUDA support for PCL
pcl[examples]                             Build PCL examples
pcl[libusb]                               Build USB RGBD-Camera drivers
pcl[opengl]                               OpenGL support for PCL
pcl[openni2]                              OpenNI2 support for PCL
pcl[pcap]                                 PCAP support for PCL
pcl[qt]                                   Qt support for PCL
pcl[simulation]                           Build Point Cloud Library Simulation
pcl[tools]                                Build PCL utilities
pcl[visualization]                        Build visualization
pcl[vtk]
So, if I want to install modules [cuda] and [visualization] at the same time, how can I realize that?

These are "features", and you want to do vcpkg install pcl[cuda,visualization].

I am so grateful for your help and patience!

@Philip035 Is your problem solved? :)

@Philip035 Is your problem solved? :)

Of course, I will close this issue  :)


Add planar horizontal viz

This PR ports the plot_horiz_field function from compass/ocean/tests/isomip_plus/viz/__init__.py into a shared viz folder. There are relatively minor changes related to this being used outside plot_horiz_series and making the figure size match the domain aspect ratio. To demonstrate its functionality, it is added to the initial_state step of the baroclinic_channel test case.
Two functions are also needed:

_remove_boundary_edges_from_mask makes sure that the periodic edges are not included (those polygons would span from one edge of the periodic domain to the other and obscure the other polygons)
_compute_cell_patches is a direct port from compass/ocean/tests/isomip_plus/viz/__init__.py
_compute_edge_patches is a new function analogous to _compute_cell_patches

Checklist

[X] Developer's Guide has been updated
[ ] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
[X] Documentation has been built locally and changes look as expected
[X] Testing comment in the PR documents testing used to verify the changes

Testing
I have run the initial_state step of the baroclinic_channel test case on compy.

@xylar I added some text to the developer's guide. I'm not sure whether/how to update the api though when the function is located in polaris/viz/__init__.py. It doesn't appear to recognize polaris.viz as a module

Great!  The API needs to be added in an appropriate spot (maybe alphabetically somehow) here https://github.com/E3SM-Project/polaris/blob/main/docs/developers_guide/api.md

I should go after validate and before yaml here:
https://github.com/E3SM-Project/polaris/blob/main/docs/developers_guide/api.md?plain=1#L328-L355
Maybe you can fix the second validate, which should be yaml while you're there?

@xylar Now that the docs are done it is ready to be merged, unless you have more feedback.

@cbegeman, I missed this in my review but it looks like the 2 images you refer to in the docs didn't actually get added.  Could you make a quick PR to add them when you get a chance?

Never mind, I just added them in #38.  I used the 2 images above.  I hope that's what you had in mind.


gedit GUI window will NOT open and prints error messages.

Environment
Windows build number: Microsoft Windows [Version 10.0.22000.258]
Your Distribution version: Ubuntu 20.04
Your WSLg version: 1.0.26

Edition	Windows 11 Home Single Language
Version	21H2
Installed on	14-10-2021
OS build	22000.258
Experience	Windows Feature Experience Pack 1000.22000.258.0

Steps to reproduce
WSLg support is added by running wsl --update. System restart is done after the update.

Launch a wsl instance in Windows Terminal
Run gedit

WSL logs:
pulseaudio.log
weston.log
versions.txt
dmesg_20211014.txt
Expected behavior
gedit application will open with GUI window.
Actual behavior
gedit GUI window will not open and prints error messages.
(gedit:25): Gdk-CRITICAL **: 18:48:09.600: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.667: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.667: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.795: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.795: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.795: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.795: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.796: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.882: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_seat_get_pointer: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_device_get_window_at_position_double: assertion 'GDK_IS_DEVICE (device)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

(gedit:25): Gdk-CRITICAL **: 18:48:09.957: gdk_seat_get_keyboard: assertion 'GDK_IS_SEAT (seat)' failed

stderr.log
Using wsl.exe from cmd.exe also shows the same error messages.


Preparing Configuration files for Azure Dev Spaces - reinitialization of configuration

The very first time you are able to open the VS Code command palette and go to:
Azure Dev Spaces: Prepare Configuration files for Azure Dev Space - it prompts the user for the inputs and configures it correctly.
Issue/Problem Now when I want to point to another dev space of another cluster, and want to run this configuration setter once again, it does not prompt for any input. It always defaults to "recently used" - with the result I am unable to use VS Code to point to another dev space.

@kprpg Prepare Configuration files for Azure Dev Space step only adds the docker file, helm chart(s) and azds yaml configuration file, which you can also generate by running azds prep command.
To point to a different controller or space you can use the CLI and run az aks use-dev-spaces command. Alternatively you can also run azds controller select and azds space select commands to do the same.


Invisible Armor Stands from 1.12

Hello, we are on 1.14.4 now and started fresh with ShopChests however it seems some shops are still floating around from when we used the plugin in 1.12 with no way to remove them. Any suggestions much appreciated, thanks!

I have the same problem using Spigot 1.12.2
When I start the server I get this error:
[16:19:08 WARN]: [ShopChest] Plugin ShopChest v1.12.2 generated an exception while executing task 43
java.lang.NullPointerException: null
at de.epiceric.shopchest.utils.UpdateChecker.check(UpdateChecker.java:43) ~[?:?]
at de.epiceric.shopchest.ShopChest$4.run(ShopChest.java:321) ~[?:?]
at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:76) ~[spigot-1.12.2.jar:git-Spigot-dcd1643-e60fc34]
at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [spigot-1.12.2.jar:git-Spigot-dcd1643-e60fc34]
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_241]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_241]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_241]


Can't use commands to rotate special entities as the tp command expects zenith:movable

I'm working on a datapack to add some functionality and I need to use tp commands on a marker entity.
I'm using the following command to rotate a marker:
/execute as @e[tag=hexi_portal,limit=1] at @e[tag=hexi_portal,limit=1] run tp @s ~ ~ ~ ~1 ~
I get this error within the unexpected error message tooltip:
class_6335['Marker'/11, l='ServerLevel[Datapack Testing]', x=-62.50, y=117.50, z=301.50] provides no component of type zenith:movable
This obviously causes the entity to not rotate but otherwise allows the mcfunction script to continue running, if I disable Zenith the marker rotates as expected which I'm using to spawn particles in its' facing direction.
I've tried adding the zenith:movable nbt data entry within cardinal_components like how it appears on most mobs but this doesn't help.

this also happens when just trying to teleport all items to myself, i think its just something with the tp command and the @e target option, i get the same error in the tooltip

Nothing to do with @e, it will work fine if you use that to select mobs.
Items is surprising though, I thought that worked fine when I tried it but it's been a while.

yeah it doesnt seem to work for me on the latest ver


Only install backports.cached-property if Python < 3.8

Update backports.cached-property dependency to only install when Python < 3.8.
Description

Added the Python version restriction to pyproject.toml.
Update poetry.lock
Update code to use functools.cached_property when Python >= 3.8.

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR
Closes #2108
Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Let me know if I need to update documentation or any additional steps.

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to ljnsn for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥


[ENH] Show Specialisation rather than the Talents on the Template Menu

sorry i found out that the Talents: in the sequence menu is empty right now
sins we can add what spec the macro is for in the main manu of the macro can you make it that the Talents: becose for spec: and then the spec we specify ?

as you can see on the screenshot the Talents: is empty on retail sins we have the string there now
if you change that to Spec and then te spec that is used in the macro

then we can easy see for what spec the macro is

ok so what you are asking is to show the Spec rather than the talents on the Template menu?

yes

This will be in the next release.


Extend L.Class.include to allow references to previously defined methods

When writing plugins, I've run into the problem of modifying the behaviour of a class by having a method run the previously defined method.
So far I've been using the pattern from leaflet.activearea.js, but that involves creating global variables instead of anonymous closures.
The usual way to work with L.Class.extend is to call previousclassname.prototype.methodname.call(params). I would like to use a similar pattern when using L.Class.include (as shown in debug/tests/include-previous.html in this PR).

Hmm, why not just save variables in a local closure? I don't think this is much more complicated than the example in the PR:
(function () {
    var oldGetTileUrl = L.TileLayer.prototype.getTileUrl;

    L.TileLayer.include({
        getTileUrl: function (coords) {
            var url = oldGetTileUrl.call(this, coords);
            ...
        }
    });
})();

Hm, I didn't think about that. The good news is that I can cancel this PR, the bad news is that I need to update several of my plugins :-)


crc status -o json doesn't answer json

General information

OS: Linux

CRC version
master
Steps to reproduce
$ crc status -o json
Machine 'crc' does not exist. Use 'crc start' to create it

$ crc console -o json
{
  "success": false,
  "error": "Machine 'crc' does not exist. Use 'crc start' to create it"
}

First command should answers json like the second.

I would call this a high priority issue

I would call this a high priority issue


resources/images: Create padding filter

This addresses the primary use case described in https://github.com/gohugoio/hugo/issues/11599.

Can also combine with the .Colors method...
{{ with resources.Get "images/c.jpg" }}
  {{ with .Filter (images.Padding "20" (index .Colors 2)) }}
    <img src="{{ .RelPermalink }}" width="{{ .Width }}" height="{{ .Height }}" alt="">
  {{ end }}
{{ end }}


Base of Interests page

Add buttons with independent click events to indicate when interests are selected on screen. Load them with places of interest.

LGTM.


detection of divided words at end of line

As it's seen below, when a document has a divided word (in this case, 'premiums'), the output word should be joined.
paragraph example:

markdown result:
The owner makes payments, known as premi- ums
expected result:
The owner makes payments, known as premiums
sample pdf:
354-143_pdf.pdf

this feature would open a new door (semantic knowledge) that we don't want to go thought for now


Update README.md

Hey, the current readme file is very plain and unappealing, I would like to improve its UI and make it attractive.

@adithyapaib I have fixed this issue, kindly check my PR #53

Sure go ahead


Add a button to filter cards based on format in card search

Hello, I would like to suggest adding a way to do card search based on format (Startup, Standard, etc). If I want to search for Startup cards, currently the only way is to use e:sg|su21|ur|df in the advanced card search. However, this is very clunky.
Something similar to what was done for decklist search would be great!

I really like this.


Concern Regarding CMAEntry Serialization During Entry Creation

Dear Contentful Community,
I'd like to bring to your attention an issue I've encountered while utilizing the Java SDK's CMAEntry feature, specifically regarding its support for metadata and tags. It appears that when attempting to create a CMAEntry with populated tags, the metadata property is being overlooked during serialization of the request. Consequently, any content already populated with metadata, such as tags, is being ignored and not created with the specified metadata.
While I acknowledge that this may be an oversight in a recently implemented feature, I wanted to confirm if this is indeed the case. My experience with Contentful is somewhat limited, so I may be mistaken. However, after testing with Curl and .js SDKs, I've found that this issue does not persist, likely due to differences in implementation.
To address this issue, I have forked the project and made modifications to the EntrySerializer class to ensure that the metadata field is properly serialized. Upon testing, it appears that this solution resolves the problem.
Given that we heavily rely on this feature in our workflows, we would greatly appreciate it if this enhancement could be integrated into Contentful. I have already reached out via the Discord channel regarding this matter, but have not yet received any responses.
Thank you for your attention to this matter. We look forward to your response and a potential resolution.

Hi @rafalniski,
Despite my attempt to initiate a discussion on Discord, I haven't received any responses or feedback yet. If possible, I would appreciate any feedback or insights that could help resolve this issue.

Hey @Xchg0x5f375d,
would you be able to create PR with your forked branch so that I can take a look at the changes?

Hey @Xchg0x5f375d,
would you be able to create PR with your forked branch so that I can take a look at the changes?

Thanks for the reply, appreciated. I've created a PR so we can now discuss the changes.

@Xchg0x5f375d This one is released in v.3.4.11


Attempting to JIT compile method '(wrapper native-to-managed) Grpc.Core.Internal.NativeMetadataCredentialsPlugin:NativeMetadataInterceptorHandler (intptr,intptr,intptr,intptr,intptr,int)' while running in aot-only mode

What version of gRPC and what language are you using?
I'm using Grpc Version 1.19.0
What operating system (Linux, Windows,...) and version?
I'm building it on Mac OS 10.14.3 with Visual Studio 7.8.2 (Build 1)
What runtime / compiler are you using (e.g. python version or version of gcc)
I'm using Xcode 10.1
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/c++/4.2.1
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
What did you expect to see?
As it is running fine on the simulator, it should work with iPhone device too.
What did you see instead?
I'm getting the exception while create the DB using var db = DatastoreDb.Create(projectId)
Here is the exception:
{System.ExecutionEngineException: Attempting to JIT compile method '(wrapper native-to-managed) Grpc.Core.Internal.NativeMetadataCredentialsPlugin:NativeMetadataInterceptorHandler (intptr,intptr,intptr,intptr,intptr,int)' while running in aot-only mode. See https://docs.microsoft.com/xamarin/ios/internals/limitations for more information.
at (wrapper managed-to-native) System.Object.__icall_wrapper_mono_delegate_to_ftnptr(object)
at (wrapper managed-to-native) Grpc.Core.Internal.NativeMethods+DllImportsFromStaticLib.grpcsharp_metadata_credentials_create_from_plugin(Grpc.Core.Internal.NativeMetadataInterceptor)
at Grpc.Core.Internal.NativeMetadataCredentialsPlugin..ctor (Grpc.Core.AsyncAuthInterceptor interceptor) [0x0003b] in T:\src\github\grpc\src\csharp\Grpc.Core\Internal\NativeMetadataCredentialsPlugin.cs:47
at Grpc.Core.MetadataCredentials.ToNativeCredentials () [0x00000] in T:\src\github\grpc\src\csharp\Grpc.Core\CallCredentials.cs:80
at Grpc.Core.CompositeChannelCredentials.CreateNativeCredentials () [0x00000] in T:\src\github\grpc\src\csharp\Grpc.Core\ChannelCredentials.cs:202
at Grpc.Core.ChannelCredentials.<.ctor>b__2_0 () [0x00000] in T:\src\github\grpc\src\csharp\Grpc.Core\ChannelCredentials.cs:45
at System.Lazy1[T].CreateValue () [0x00081] in <2b439461a53d406abf16d6e5e34ece7f>:0  at System.Lazy1[T].LazyInitValue () [0x00080] in <2b439461a53d406abf16d6e5e34ece7f>:0
at System.Lazy1[T].get_Value () [0x0003a] in <2b439461a53d406abf16d6e5e34ece7f>:0  at Grpc.Core.ChannelCredentials.GetNativeCredentials () [0x00000] in T:\src\github\grpc\src\csharp\Grpc.Core\ChannelCredentials.cs:80  at Grpc.Core.Channel..ctor (System.String target, Grpc.Core.ChannelCredentials credentials, System.Collections.Generic.IEnumerable1[T] options) [0x0007e] in T:\src\github\grpc\src\csharp\Grpc.Core\Channel.cs:77
at Grpc.Core.Channel..ctor (System.String host, System.Int32 port, Grpc.Core.ChannelCredentials credentials, System.Collections.Generic.IEnumerable`1[T] options) [0x00000] in T:\src\github\grpc\src\csharp\Grpc.Core\Channel.cs:109
at Google.Api.Gax.Grpc.ChannelPool.GetChannel (Google.Api.Gax.Grpc.ServiceEndpoint endpoint, Grpc.Core.ChannelCredentials credentials) [0x0003a] in C:\Users\skeet\Test\Projects\gax-dotnet\releasebuild\Google.Api.Gax.Grpc\ChannelPool.cs:127
at Google.Api.Gax.Grpc.ChannelPool.GetChannel (Google.Api.Gax.Grpc.ServiceEndpoint endpoint) [0x0001d] in C:\Users\skeet\Test\Projects\gax-dotnet\releasebuild\Google.Api.Gax.Grpc\ChannelPool.cs:93
at Google.Cloud.Datastore.V1.DatastoreClient.Create (Google.Api.Gax.Grpc.ServiceEndpoint endpoint, Google.Cloud.Datastore.V1.DatastoreSettings settings) [0x00000] in C:\Users\jon\Test\Projects\google-cloud-dotnet\releasebuild\apis\Google.Cloud.Datastore.V1\Google.Cloud.Datastore.V1\DatastoreClient.cs:399
at Google.Cloud.Datastore.V1.DatastoreDb.Create (System.String projectId, System.String namespaceId, Google.Cloud.Datastore.V1.DatastoreClient client) [0x00000] in C:\Users\jon\Test\Projects\google-cloud-dotnet\releasebuild\apis\Google.Cloud.Datastore.V1\Google.Cloud.Datastore.V1\DatastoreDb.cs:84
at Kudos.ViewController.SaveToDB () [0x0000c] in /Users/sandeepmahajan/Documents/Projects/sury-kudos/SuryKudos/SuryKudos/ViewController.cs:75 }

See #18178, #17587, and #17051

This is a duplicate of #18178.


Graphical error in char sheets

It seemst there is a graphic problem with the char sheets. Regardless of browser there are black blocks in the ability boxes which partly block the focusses.
I run a Foundry V11 server.

Is this still an issue on V12?


Improve container image publish speed by building on platform specific hardware

On Hold
https://github.com/actions/runner-images/issues/8439#issuecomment-1755601587

Might I make a suggestion? Feel free to use FlyCI's M1 and M2 runners. Our runners are on average 2x faster and 2x cheaper than GitHub's AND we have a free tier for OSS projects (see below).
Install Instructrions
Easily replace your M1 runners:
jobs:
 ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m1
   steps:
   - name: 👀 Checkout repo
     uses: actions/checkout@v4

Or try the M2 runners:
jobs:
  ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m2
    steps:
      - name: 👀 Checkout repo
        uses: actions/checkout@v4

Pricing

Processor
vCPU
RAM (GB)
Storage
Label
Price on FlyCI
Price on GitHub

M1
4
7
28 GB
flyci-macos-large-latest-m1
$0.06
-

M1
8
14
28 GB
flyci-macos-xlarge-latest-m1
$0.12
$0.16

M2
4
7
28 GB
flyci-macos-large-latest-m2
$0.08
-

M2
8
14
28 GB
flyci-macos-xlarge-latest-m2
$0.16
-

500 mins/month Free for Public Repos
If your repo is public, then FlyCI offers 500 mins/month of free M1 runner usage with the flyci-macos-large-latest-m1 runner.
Best Regards,
Kiril Gantchev
CEO and co-founder of FlyCI


Skips test builds and run on beta deploys #trivial

This PR skips running tests (and building for the purposes of running tests) on CI if the branch is beta. We ignore any test failures on this branch anyway, so the tests are just taking up time.
@javamonn I meant do pair on this but it kind of folded naturally into some release automation work I'm doing. I've assigned you to the PR, let me know if you'd like to pair on the review.

Dunno why this is failing, I'll take a look.


Update JDK License link.

High-level description
We ship JDK 8 and were pointing to Java 6 License.

@mesosphere-mergebot label ship-it

These were fixes to license text. Applying ship-it label seemed OK.
I think, the mergebot should insist that ship-it should be applied by an owner other than the PR creator.

@mesosphere-mergebot bump-ee


Header, navbar, and admin sidebar refactoring

References

Fixes #2656
Fixes #2368
Fixes #2699
Fixes #2178

Description
Purpose of this PR:

change the structure of the header and the navbar in order to:

make customisation easier
improve responsivity
improve accessibility

remove unnecessary styling from shared components in order to make customisation easier
fix admin sidebar issues

sidebar width must be the same when vertical scrollbar is present

improve overall accessibility of:

main navbar
menubar (login, language switch, ...)
admin sidebar

decouple sidebar and header/navbar styling
decouple custom and DSpace theme styling
make color customisation easier

List of changes

Menu items (*-menu-item components)

minor changes have been made in order to better handle their styling from their parent components

Header and navbar

the content of header, navbar, and header-navbar-wrapper has been rearranged

the navbar component only contains the main menu
the <nav> tag now contains navigation links only, as required by semantic HTML specification

Accessibility

ARIA attributes and roles have been improved according to specification

Sidebar

the way collapsing work has been changed in order to solve issues with vertical scrolling
other changes were required in order to decouple sidebar and navbar styling

Theming

SCSS variables have been reorganised and unnecessary variables have been removed
new SCSS variables have been added in order to make color customisation easier

host-window service

some utility functions for responsivity have been added

Other changes

some unecessary code has been removed

Accessibility
In order to test overall accessibility I used this Chrome extension that provides a visual representation of how screen readers render the page:
https://chromewebstore.google.com/detail/aria-devtools/dneemiigcbbgbdjlcdjjnianlikimpck
This is how the current layout is rendered:
admin sidebar
header
And this is how it is rendered with this PR:

I also checked for errors with this Chrome extensions and there are none:
https://chromewebstore.google.com/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh
Note that menu and menuitem are now being used, and dropdown menus are better handled.
Instruction for reviewers

Check that both dspace and custom theme work fine in both mobile and desktop mode
Check that CSS variables such as theme colors work fine
Check that header, navbar, and sidebar are fully accessible

Future improvements
These components still require some changes, for which I'm going to open a new issue:

user-menu component

should only contain a list of menu items
toggler button is used in desktop mode only, and it should be moved to the parent component
the outer wrapper should be moved to the parent components as well
menu items should be  elements in order to improve the collapsible navbar
it should be made more accessible through ARIA attributes
Bootstrap classes should be removed as their properties are being overridden

dropdown menus

they should be made more accessible through ARIA attributes
Bootstrap classes should be removed as their properties are being overridden

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@davide-negretti : Even though this is still a "Draft", I gave this a very brief test just now in production mode (yarn build:prod; yarn serve:ssr), just to see how it's working.  The basics seem to work.
However, when I login, I receive a number of server-side rendering (SSR) errors which imply that SSR isn't working anymore:
ERROR RuntimeError: NG03402
    at triggerTransitionsFailed (C:\dspace-angular\dist\server\main.js:7:4969532)
    at TransitionAnimationEngine.reportError (C:\dspace-angular\dist\server\main.js:7:5048893)
    at TransitionAnimationEngine._flushAnimations (C:\dspace-angular\dist\server\main.js:7:5053458)
    at TransitionAnimationEngine.flush (C:\dspace-angular\dist\server\main.js:7:5048266)
    at InjectableAnimationEngine.flush (C:\dspace-angular\dist\server\main.js:7:5069338)
    at C:\dspace-angular\dist\server\main.js:7:5605397
    at _ZoneDelegate.invoke (C:\dspace-angular\dist\server\main.js:7:2179478)
    at Zone2.run (C:\dspace-angular\dist\server\main.js:7:2172289)
    at NgZone2.runOutsideAngular (C:\dspace-angular\dist\server\main.js:7:3215596)
    at AnimationRendererFactory.end (C:\dspace-angular\dist\server\main.js:7:5605336) {
  code: 3402
}
Error in server-side rendering (SSR)
Error details :  RuntimeError: NG03402
    at triggerTransitionsFailed (C:\dspace-angular\dist\server\main.js:7:4969532)
    at TransitionAnimationEngine.reportError (C:\dspace-angular\dist\server\main.js:7:5048893)
    at TransitionAnimationEngine._flushAnimations (C:\dspace-angular\dist\server\main.js:7:5053458)
    at TransitionAnimationEngine.flush (C:\dspace-angular\dist\server\main.js:7:5048266)
    at InjectableAnimationEngine.flush (C:\dspace-angular\dist\server\main.js:7:5069338)
    at InjectableAnimationEngine.ngOnDestroy (C:\dspace-angular\dist\server\main.js:7:5609542)
    at R3Injector.destroy (C:\dspace-angular\dist\server\main.js:7:2954388)
    at NgModuleRef.destroy (C:\dspace-angular\dist\server\main.js:7:3139781)
    at C:\dspace-angular\dist\server\main.js:7:3229024
    at Array.forEach (<anonymous>) {
  code: 3402
}
Falling back to serving direct client-side rendering (CSR).

@tdonohue this is now complete and can be tested. This PR is going to conflict with #2704, however I already handled all ARIA attributes

Please note that I squashed some commits and force-pushed this branch

@tdonohue the behavior of the sidebar when you open any submenu (causing the vertical scrollbar to appear) is intentional. Previously the vertical scrollbar caused the sidebar to become larger and sometimes it was covering the page content, although it's only 20 px larger. Now the width of the sidebar don't change anymore but after many attempts I found that the best way to keep the width constant (and the template code simple) was to slightly shift the menu items on the left, however this should not cause any issues as I reserved the needed space on the left.
I though I had already solved the SSR issue, which seemed to be caused by a wildcard, I will check it again.
I will also check for the other layout issues, they are not intentional and I can fix them.

@tdonohue the e2e test collection-statistics.cy.ts is failing on main branch as well

It throwns an error because it cannot find the "Statistics" navbar item at /statistics/collections/282164f5-d325-4740-8dd1-fa4d6d3e7200, and it is also missing on demo environment

@davide-negretti : It's passing for me in my local environment on main and also passing in the last build of main (as of yesterday) in GItHub CI: https://github.com/DSpace/dspace-angular/actions/runs/7211583776
I will note though that there are some e2e tests which have random failures like this.  The various statistics e2e tests are all ones that I've seen have random failures (even in GitHub CI).   So, it is possible that these e2e failures are random in this PR... if you cannot find any other cause.  But, my suspicion is that the SSR errors may be having a side-effect of making these statistics pages fail more frequently.   So, if the SSR errors are fixed, it's possible these e2e failures will go away.  If they don't, I can see if I can dig deeper as to what the failure may be.

@tdonohue I fixed the issues with the animation in SSR. However the e2e tests keep failing on both this branch and main branch when I run them locally, and if I check the behaviour of the demo environment it does not match the expectations either:

@tdonohue all tests are now passing

@tdonohue many conflicts were detected on this PR two days ago, as other PRs that fix some existing issues I also fixed have been recently merged. I merged main branch into my branch and in this way may changes in these PRs went lost. I'm trying to track these changes but I won't be able to keep many of them because they affect code I have refactored.
Also, now many e2e tests are failing, I'm trying to find the cause and I will update this PR as soon as possible.

@davide-negretti : My apologies.  I'm trying to get Accessibility fixes merged as soon as I can, and it seems that I didn't realize merging #2711 or #2587 (those are the two accessibility PRs merged in the last few days) would negatively impact this one.
If you can get this updated one last time, I'll put it as "high priority" on my list to get merged.  Again, apologies...it can be difficult to tell which PRs will impact others prior to merging.

@tdonohue no problem, I just wanted to warn you about this problem in the case there were other pending PRs that affect the header and sidebar. I'm currently trying to fix e2e tests, there is one that is ramdomly failing due to timeout:

@davide-negretti : Don't worry as much about random-ish failures.  If they are truly random, then we can get this to pass & then fix the random failures in a future PR.  So, just concentrate on fixing the e2e tests that fail all the time.  Chances are they should all be something small like an Accessibility failure, or maybe you removed an HTML tag or attribute which the e2e test was depending on.

@tdonohue I fixed the issue with expandable sections and I disabled the faulty test

When you open a menu option and that causes a scrollbar to appear, the current sidebar on sandbox.dspace.org gets wider to account for this. In this PR all options jump to the left when the scrollbar appears.

@artlowel this is a design choice I explained here:
https://github.com/DSpace/dspace-angular/pull/2676#issuecomment-1856601385
If it is not good I can revert it

@davide-negretti I'm sorry, I missed that comment. This occurs only in pinned mode I assume? Perhaps we can fix that by giving the sidebar 20px of (extra) margin-right when there's no scrollbar, and removing that when there is. That way the sidebar's width stays consistent, but to the user it will look like the scrollbar is added on the outside

@artlowel I already considered adding a left margin or padding, but we cannot add it directly to the inner-wrapper of the root component otherwise there would be a gap between full width elements (like the header) and the sidebar. The only solution would be to add an internal left padding to each direct child of the inner-wrapper, which may be an issue with more complex layouts. The best solution in my opinion would be to add an internal right padding to the sidebar, but I haven't been able to do that without breaking it.

@artlowel @tdonohue I completed all the changes that I marked as resolved, I'll wait for clarifications for the remaining ones

Merge conflicts solved

@tdonohue the issue with the logout button is caused by the Bootstrap sr-only class, whose implementation is quite a workaround
This happens when the header runs out of horizontal space
The current behaviour of the header is this:

With my refactoring logo and buttons remain on the same line. I suggest to keep it in this way, and to hide the logo below 360px (or to replace it with a small fa-house icon):

This in my opinion looks better, and it also fixes the issue with sr-only
I could

@artlowel

for the navbar issue I can use an attribute selector [dsNavbarSection] so that the <ul> will have only direct <li dsNavbarSection> descendants
I will make the header height variable on mobile screens
I will fix merge conflicts and the login dropdown issue

@artlowel

I replaced all  and  with  in navbar and sidebar
I made the header height variable on mobile screens. I did not fix the issue with sr-only, however this only occurs when the screen width is below 270px
I restored the behaviour of links in the user dropdown menu

@davide-negretti: I think it would be best to remove the changes you made regarding to the <ul>/<li> structure replacement to nested <div>s, because this is not good for accessibility. Instead you could just replace this ng-container with an li and replace this <li> & this <li> with a <div>.

@alexandrevryghem I already added to every menu the menubar, menu and menuitem ARIA roles, which are more appropriate - from the accessibility point of view - than unordered lists, which uses the list and listitem roles.
I carefully tested the page with a screen reader, which previously recognised the menus as generic lists with N items, and now correctly recognises them as navigation bars.
I also inspected the page with ARIA DevTools chrome extension. This is the current situation on demo.dspace.org:

And this is with the correct roles:

@artlowel I restored the spacing between items

@davide-negretti : As I worried, this was unable to be ported automatically to 7.x.  If you feel this work could be ported to 7.x, then I'd appreciate it if you could find time to create a version of this PR against the dspace-7_x branch.  If you feel this work is not easily possible to port to 7.x, then we can keep this as an 8.0-only accessibility fix.
Please let me know what approach you feel is best.

@tdonohue I'm going to try to port it manually, I'll let youknow if the merge conflicts can be easily handled

@tdonohue

I opened the PR for the porting: #2858
I made a minor fix for this PR (already included in the porting PR): #2859


Does a image build can be seen as 'fresh'?

I have the situation that i have a docker image i want to build.
This image gets used by several jobs.
I know that the image pull once will not be performed if the image is already present. Therefore dependent jobs will only be called if their own sources/artifact configures dictates it.
However when i am building the image via context/dockerfile the dependency tree of those jobs that might not run because of their sources/artifacts are run every time.
This might be by design because no job does know about any previously not met dependency. But still: is there any way for me to mark the image as "don't rebuild this all the time"?

It does.


Adding more log messages and try catch checks

Adding in a bunch of log messages and try catch blocks.
This should make the backends behaviour more understandable when checking the logs

Hi, thanks for the PR. I think logging everything could result in an excess of unwanted messages, potentially obscuring actual errors. I'm currently working on the 1.0.0 release, which already includes a revised logging system. Additionally, all other logs will be saved to a log file managed by the new logger in the 1.0.0 release.

Trying out Perplexica right now. It's running via the docker setup, but there is almost no logging, either through docker logs or through app.log inside the backend container. I would like to see how it is working, like in the screenshot above. Is there a setting / log file I'm missing?


Add option --only-headers to support passing of header structs only.

This option allows users to pass only header structs in a p4 file instead of a fully compiling p4 source code. The header structs are appended to a template p4 file to produce a p4c compilable code. Since the template does not contain any parser logic, no bindings will be generated in the output files.

Can you put the auto-completion part in a separate pull request, so that it becomes a separate commit.


Permission error for getting token

i have error when worker node try to join master node:
[kubelet] Downloading configuration for the kubelet from the "kubelet-config-1.12" ConfigMap in the kube-system namespace
configmaps "kubelet-config-1.12" is forbidden: User "system:bootstrap:2vhny5" cannot get configmaps in the namespace "kube-system"

Any idea?

try many times with fresh installation.
no succeed.
I really sure that this is a BUG :(.

kubelet-config-1.12

that looks bit fishy. :)
Which version of pharos is this on?
We don't support 1.12 yet, sure there's no kube 1.12 components in the system from any previous trials or something?

I use latest version, 2.0.0
even i reinstall the OS and again errors happened.
the full log is:
==> Join nodes @ 31
    [31] Joining host to the master ...
    [31] got error (Pharos::SSH::RemoteCommand::ExecError): SSH exec failed with code 1: sudo kubeadm join localhost:6443 --token w9a6lu.jr95dhqmqjxr29wh --discovery-token-ca-cert-hash sha256:08f74292297d40340f29f0a98310c3b88c67b4321f07a9aa86c6ff9028123d86 --node-name 31 --ignore-preflight-errors DirAvailable--etc-kubernetes-manifests --ignore-preflight-errors SystemVerification
[preflight] running pre-flight checks
	[WARNING DirAvailable--etc-kubernetes-manifests]: /etc/kubernetes/manifests is not empty
	[WARNING RequiredIPVSKernelModulesAvailable]: the IPVS proxier will not be used, because the following required kernel modules are not loaded: [ip_vs_rr ip_vs_wrr ip_vs_sh ip_vs] or no builtin kernel ipvs support: map[ip_vs_sh:{} nf_conntrack_ipv4:{} ip_vs:{} ip_vs_rr:{} ip_vs_wrr:{}]
you can solve this problem with following methods:
 1. Run 'modprobe -- ' to load missing kernel modules;
2. Provide the missing builtin kernel ipvs support

I1108 15:06:02.972045     514 kernel_validator.go:81] Validating kernel version
I1108 15:06:02.972259     514 kernel_validator.go:96] Validating kernel config
	[WARNING SystemVerification]: docker version is greater than the most recently validated version. Docker version: 17.12.1-ce. Max validated version: 17.03
[discovery] Trying to connect to API Server "localhost:6443"
[discovery] Created cluster-info discovery client, requesting info from "https://localhost:6443"
[discovery] Failed to connect to API Server "localhost:6443": token id "w9a6lu" is invalid for this cluster or it has expired. Use "kubeadm token create" on the master node to creating a new valid token
[discovery] Trying to connect to API Server "localhost:6443"
[discovery] Created cluster-info discovery client, requesting info from "https://localhost:6443"
[discovery] Failed to connect to API Server "localhost:6443": token id "w9a6lu" is invalid for this cluster or it has expired. Use "kubeadm token create" on the master node to creating a new valid token
[discovery] Trying to connect to API Server "localhost:6443"
[discovery] Created cluster-info discovery client, requesting info from "https://localhost:6443"
[discovery] Failed to connect to API Server "localhost:6443": token id "w9a6lu" is invalid for this cluster or it has expired. Use "kubeadm token create" on the master node to creating a new valid token
[discovery] Trying to connect to API Server "localhost:6443"
[discovery] Created cluster-info discovery client, requesting info from "https://localhost:6443"
[discovery] Failed to connect to API Server "localhost:6443": token id "w9a6lu" is invalid for this cluster or it has expired. Use "kubeadm token create" on the master node to creating a new valid token
[discovery] Trying to connect to API Server "localhost:6443"
[discovery] Created cluster-info discovery client, requesting info from "https://localhost:6443"
[discovery] Failed to connect to API Server "localhost:6443": token id "w9a6lu" is invalid for this cluster or it has expired. Use "kubeadm token create" on the master node to creating a new valid token
[discovery] Trying to connect to API Server "localhost:6443"
[discovery] Created cluster-info discovery client, requesting info from "https://localhost:6443"
[discovery] Requesting info from "https://localhost:6443" again to validate TLS against the pinned public key
[discovery] Cluster info signature and contents are valid and TLS certificate validates against pinned roots, will use API Server "localhost:6443"
[discovery] Successfully established connection with API Server "localhost:6443"
[kubelet] Downloading configuration for the kubelet from the "kubelet-config-1.12" ConfigMap in the kube-system namespace
configmaps "kubelet-config-1.12" is forbidden: User "system:bootstrap:w9a6lu" cannot get configmaps in the namespace "kube-system"
    [31] retrying after 1 seconds ...

Could you check kubeadm version on the node. 1.11.4 kubeadm should not try to locate 1.12 config.
Does this happen on all nodes?
What OS & OS version on the nodes?

Same problem: here
I think it might be a kubelet version mismatch.
kubeadm is 1.11.4 on both master and worker but the kubelet is 1.12.2

How kubelet got into that version? Pharos should really pin it to correct version. What OS does the nodes have?

@saeidakbari What OS did the problematic node have? We need to know to be able to bake in logic that would detect this situation and fail more "safely".

I use Ubuntu 18.04.1 LTS.

Thanks.


The referenced page 'xyz' is not a part

we have page as below in extension 1.0

converted as extension 2.0

Getting error as page is not a part.

But the page Job Ledger Entries is not a PageType = CardPart/ListPart. Why do you wan't to use it as a part?

This is an undocumented scenario and it has been allowed by cside but it was never intended to be used. The client is not tested for this scenario so it has previously been more like "a bug that is a feature". This is considered an anti pattern.
I have turned the error into a warning for the future update so you will be able to use it for some time but please refactor this code as we will eventually stop supporting this.


Synchronous fetch

It seems my issue is similar to https://github.com/Haneke/HanekeSwift/issues/168
But is there a way to fetch data in Synchronous way. (it doesn't have to be image/images but some small data like state.)(of course I can group or use semaphore but it's too much )

It is total nonsense that caching library does not support synchronous calls. I wish I had never used this library, authors are ignoring this for a long time now. It is very nice that they are enforcing asynchronous calls because , but there are situations where you simply must use synchronous calls. Even GCD can't be used, because their completion blocks are called on main thread.

Hi @tankista - can you help me understand in what situation you would want a blocking, synchronous call?  I'm not sure I understand ..   cheers!

I am using image browser library that allow me to use custom caching and because I am using HanekeSwift to cache images, I wanted to provide it. However, their protocol supports synchronous method:
func imageForKey(_ key: String) -> UIImage?

I have no other option but to load image synchronously. I tried to use GCD and dispatch groups, but Haneke is calling completion blocks on main thread which are already blocked by dispatch group so it always timeouts. Solution, where I could provide my own dispatch queue would be sufficient as I would be able to make the call synchronous manually. See
https://github.com/Haneke/HanekeSwift/pull/396

Hmm, it does seem pretty unusual that that library has only synchronous loading!!
Thanks for the explanation. I don't really know what the solution would be there.  Cheers

@smhk well not everything is perfect on this world, and solution is mentioned in my comment above.


whitelist() should be  merged whitelistMultiple()

there is no point in having 2 (it is also confusing  since whitelistMultiple() is public with no modifiers and  accessibility is enforced by calling whitelist() internally.

for( uint16 i = 0; i < _address.length; i++ )  better to use uint256 instead of uint16.

Additionally,  whitelistMultiple(address[] memory _address, bool _approve) can either approve or reject but not have a mixed list since _approve is not a list.

merging makes sense. please make a PR.
I think only approving to rejecting is fine, mixed would make it more complicated also from a dev perspective. Its easier to call the function with a set of approved and then a set of rejected.

Addressed in #33.


Align SparkStatementEvent to KyuubiOperationEvent

Why are the changes needed?

Align SparkStatementEvent to KyuubiOperationEvent
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1601 (090dee8) into master (152e394) will decrease coverage by 0.02%.
The diff coverage is 87.71%.

@@             Coverage Diff              @@
##             master    #1601      +/-   ##
============================================
- Coverage     58.25%   58.23%   -0.03%
  Complexity      164      164
============================================
  Files           258      258
  Lines         12798    12800       +2
  Branches       1608     1607       -1
============================================
- Hits           7456     7454       -2
- Misses         4712     4715       +3
- Partials        630      631       +1

Impacted Files
Coverage Δ

...kyuubi/engine/flink/operation/FlinkOperation.scala
42.62% <0.00%> (ø)

...rc/main/scala/org/apache/spark/ui/EnginePage.scala
80.06% <84.61%> (ø)

...uubi/engine/spark/events/SparkOperationEvent.scala
88.88% <88.88%> (ø)

...kyuubi/engine/spark/events/EngineEventsStore.scala
86.66% <100.00%> (-10.00%)
:arrow_down:

...uubi/engine/spark/operation/ExecuteStatement.scala
83.87% <100.00%> (-2.21%)
:arrow_down:

...kyuubi/engine/spark/operation/SparkOperation.scala
82.92% <100.00%> (ø)

...g/apache/spark/kyuubi/SparkSQLEngineListener.scala
88.13% <100.00%> (ø)

...rg/apache/kyuubi/operation/AbstractOperation.scala
69.49% <100.00%> (ø)

...rg/apache/kyuubi/events/KyuubiOperationEvent.scala
96.77% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152e394...090dee8. Read the comment docs.

cc @ulysses-you

thanks, merging to master


Extra portdir support

Adding the ability to specify an extra portdir_overlay directory into a CoreOS build. This will be useful functionality for all the people who want to build otherwise vanilla CoreOS images, but with additional software for whatever they are trying to do. There is an associated pull request on the chromite repo. coreos/chromite#18

@marineam the repos.conf file offers a possible rewrite, but it does require a slightly more 'major' change than the simple addition of new functionality I have here, and I'm not sure how the team might feel about it.
By specifying a location for 'repo configuration files' we can modify the pipeline so that when it populates the repos.conf/coreos.conf it also symlinks any files matching whatever_we_call_the_repo_conf_dir/*/*.conf into /etc/portage/repos.conf/ which would provide everything these two pull requests do, and probably more.
What do you think?

That sounds fine to me.

@marineam I'm a little stuck on the appropriate location in the work dir.
src/third_party seems to only contain repos directly, so having a folder inside there that contains multiple git repositories seems like it could be confusing. however I'm not sure if creating a folder such as src/repo_configs makes much sense either.
Got any thoughts on this matter?

It could also be located in the top level of the repo root instead of under src/ use a top level local/ or config/ directory. There are other configuration bits that currently scattered around the SDK such as /etc/shared_user_passwd.txt and src/scripts/.default_board. This new location could become the recommended place for that sort of stuff in the future.

@marineam a top level config dir sounds pretty hard to argue against. Thanks for the suggestion.  It shouldn't take too long to refactor if you want to check out how the logic looks.

New PR Created.


Returns wrong color format

Upgrading to 1.6.2, color picker returns wrong color format.
For example, this :
<pick-colors v-model:value="colorA" format="rgb" />
The picker returns hsl color format.
It works fine in 1.6.1

Hello, thank you for your reminder.
I have fixed it in 1.6.3
I will also use test cases to avoid this from happening in the future


Add OCaml support

Basic support for OCaml through ocaml interpreter.
Tested on NixOS.

Based on previous PR for Zig.

Thanks for the contribution! It will be released soon

Great :) Thanks!


CP: Run docs publish on all branches. (#112909)

CP: c99780dea8409d5d9550ae80e52706cda8e730e1
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

LGTM
This PR is auto approved by fluttergithubbot, do we need an issue or is this expected?

This is expected is a cherry-pick to a release candidate branch.


Added Issue Template and Pull Request template

Fixes: #20
Added Issue Template and Pull Request template, PR with reference to

Please review and merge the PR.

OK, making the necessary changes

Kindly review the newly made changes.

@deytulsi18 Have a look at the new requested changes if you haven't already

Due to inactivity, this PR is closed. Also, I no longer need any template for this repo!


Add self-update support to CLI

http://moquet.net/blog/distributing-php-cli/

Reference: 01612360c09b2e0652d9877a73b75c5c60627bd4


[Enhancement] Serializer / Deserializer (AASX) should have some warning handler (instead of just logging)

This may not just apply to AASXSerializer / AASXDeserializer but to others as well (which should share a common interface).
Also, this may have some impact on all sorts of classes, e.g. ReflectionHelper.
IS:
ReflectionHelper et al issue logger WARN
Sould:
Caller should be able to pass some optional lambda (e.g. a consumer for warnings), to catch warnings programmatically.
Example output from (modified) routine similar to org.eclipse.digitaltwin.aas4j.v3.dataformat.aasx.serialization.AASXSerializerTest, but with 1.0.0-milestone-03 (main branch does not produce the first two warnings, and the last warning is due to the modification of our test).
[main] WARN org.eclipse.digitaltwin.aas4j.v3.dataformat.core.util.ReflectionHelper - could not auto-resolve target class for mixin 'DataSpecificationPhysicalUnitMixin'
[main] WARN org.eclipse.digitaltwin.aas4j.v3.dataformat.core.util.ReflectionHelper - could not auto-resolve target class for mixin 'LangStringMixin'
[main] WARN org.eclipse.digitaltwin.aas4j.v3.dataformat.aasx.AASXSerializer - Could not add File '/aasx/OperatingManual.pdf'. It was not contained in given InMemoryFiles.

Thanks for pointing this out! We will have a look at it.


v7.1.2 is not distributed as a phar

Deployer version: 7.1.2
Deployment OS: n/a

v7.1.2 has a composer.json with a requires section and dep file missing from the root folder.

Looks like the release GitHub action is broken. Will try to do a couple of different releases to debug.

Should be fixed: https://github.com/deployphp/deployer/tree/v7.1.3
Don’t know what was the problem. Just recreating a new release fixed the issue.