HDDS-9643.Remove some redundant comments in CommandDispatcher

What changes were proposed in this pull request?
There are some redundant comments in CommandDispatcher, and the purpose of this PR is to delete them.
Details: HDDS-9643
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9643
How was this patch tested?
This PR is mainly related to documentation and does not require too much testing.

Thanks @jianghuazhu for the patch.  Please note that each of these trivial fixes in javadoc, if submitted as separate PR, requires two rounds of complete CI workflow (one for PR, one for merge).  Please try to collect a small batch of these fixes in each PR to reduce overhead.

Thanks @adoroszlai  for the comments and suggestions.


added chat format in num_token_consumed_from_request

Added chat format support

Thanks for the contribution - really appreciate. Taken care of by PR #244 (https://github.com/openai/openai-cookbook/pull/244), so I will close this.


all the latest redirect links are not pointing to the right location

These links here:
https://github.com/Mashape/kong#documentation
kinda 404

Fixed with a8d2920be1d4a6b334e71362e7e19b3213238852. Give it some time so GH pages can propagate the changes.


Add facebook compatibility

Add a command that allows users to share their recipes on social media

Resolved in #60 #73 #74


add release-future branch and delete release-cd branch

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Specify your PR reviewers:

/cc @gyliu513 @horis233
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

https://github.ibm.com/IBMPrivateCloud/roadmap/issues/47644


Stops extension host on VS Code

Type: Bug
I just open VS Code and Extension Host stops by no apparent reason
Extension version: 1.0.22
VS Code version: Code 1.86.0 (05047486b6df5eb8d44b2ecd70ea3bdf775fd937, 2024-01-31T10:28:19.990Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 5600H with Radeon Graphics          (12 x 3294)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.36GB (2.99GB free)

Process Argv
--crash-reporter-id af9a6951-d12d-4cd9-89f6-b562c288bfb2

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
0bi6i642:30951795
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
dsvsc019bcf:30953938
3ef8e399:30949928
bg6jg535:30956215

Can confirm, just finished running Bisect to find it

I think this could be related to https://github.com/MicrosoftDocs/intellicode/issues/550#issuecomment-2035719195.
If this is still happening can you please collect the TS server log by following these instructions? Does uninstalling/disabling IntelliCode fix the issue?

Just tried the TS server thing, apparently the bug was fixed. Would need further confirmation from @Zamna but for now it looks like the issue can be closed soon


Use context for metrics on how long it takes a message to get through pipeline

Equivalent to this https://github.com/justeat/JustSaying/blob/322a3439aff8a649f882e7058a7b26808387ba72/src/JustSaying/Messaging/MessageProcessingStrategies/Throttled.cs#L115
We have this extension https://github.com/justeat/JustSaying/blob/1c3f53c3152141704cf76a97e95956bc5b3ec455/src/JustSaying/Messaging/Monitoring/MonitorExtensions.cs#L5
which is called here https://github.com/gkinsman/JustSaying/blob/a8f5a2d0c9988f58a137f536abe85a63d0ba37f0/src/JustSaying/Messaging/Channels/Receive/MessageReceiveBuffer.cs#L78
But it's not quite the same, because the previous one is a message has timed out and been chucked, whereas ours identifies any messages that have been held waiting to get into the multiplexer
We discussed that it might be good to use the context to send metrics for various parts of the pipeline, to track each message

I think this better addressed by the OpenTelemetry work in https://github.com/justeat/JustSaying/issues/874. Will close for now, but please reopen if you disagree!


Implement Dereferencing for the secondary resource

Dereferencing for the primary resource is already implemented. For this issue we want to have Implemented dereferencing for the secondary resource as described in doc:
https://w3c-ccg.github.io/did-resolution/#dereferencing-algorithm-secondary
Links for context
https://w3c-ccg.github.io/did-resolution/

I suggest to start with service and relativeRef.
Hey @Tweeddalex,  re-read the spec. Formed a clearer opinion.
As I see myself dereferencing these resources:
DID Doc:
{
	"@context": "https://www.w3.org/ns/did/v1",
	"id": "did:example:123456789abcdefghi",
	"verificationMethod": [{
		"id": "did:example:123456789abcdefghi#message_key",
		"type": "Ed25519VerificationKey2018",
		"controller": "did:example:123456789abcdefghi",
		"publicKeyBase58": "H3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV"
	}],
	"service": [{
		"id": "did:example:123456789abcdefghi#message",
		"type": "MessagingService",
		"serviceEndpoint": "https://example1.com"
	}, {
		"id": "did:example:123456789abcdefghi#my_message",
		"type": "MessagingService",
		"serviceEndpoint": "https://example2.com"
	}]
}

service - get SeviceEndpoint by id. The value of this query should be exactly the same with a fragment id.
Example 1 - get clean endpoint
Input DID URL: did:example:123456789abcdefghi?service=message
Output contentStream: { "https://example1.com" }
Example 2 - not found
Input DID URL: did:example:123456789abcdefghi?service=mess
Output contentStream: {}, error - notFound
Example 3 - hash simbol
Input DID URL: did:example:123456789abcdefghi?service=message#flag
Output contentStream: { "https://example1.com#flag" }
Note: don't process flag like a DID fragment id, just add to ServiceEndpoint
Example 4 - relativeRef
Input DID URL: did:example:123456789abcdefghi?service=message&relativeRef=%2Fsome%2Fpath%3Fsome_query
Output contentStream: { "https://example1.com/some/path?some_query" }
Note:
relativeRef is a parameter name,
%2Fsome%2Fpath%3Fsome_query is a value. After URL decoding, the value is /some/path?some_query
It means that for getting this output we need

Resolve DID did:example:123456789abcdefghi - get DID doc
Get Service Endpoint by id message.  Result  - ServiceEndpoint URL https://example1.com. Like in Example 1
Add the encoded value of relativeRef to the URL from the previous step. https://example1.com + /some/path?some_query

Example 5 - relativeRef + hash simbol
Input DID URL: did:example:123456789abcdefghi?service=message&relativeRef=%2Fsome%2Fpath%3Fsome_query#flag
Output contentStream: { "https://example1.com/some/path?some_query#flag" }
Note: the same steps with Example 4 +
4. just add  #flag to ServiceEndpoint.
Example 6 - primary resource without service
Input DID URL: did:example:123456789abcdefghi?#messege
Output contentStream:
{
		"id": "did:example:123456789abcdefghi#message",
		"type": "MessagingService",
		"serviceEndpoint": "https://example1.com"
}

Note: here we process a value after # because after processing the previous part we have a full DID Doc (primary resource), not just SeviceEndpoint string like in the previous examples
Example 7 - representationNotSupported
Input DID URL: did:example:123456789abcdefghi?relativeRef=%2Fsome%2Fpath%3Fsome_query
Output contentStream: { };  error - representationNotSupported
@Tweeddalex @ankurdotb Could you please approve this approach. If you agree, @IlAganin will start to implement this.
СС: @anikitinDSR

@filipdjokic after the release lets align on how you can pick this up


TOA Zebak

The Zebak room in TOA has a black floor.. When i disable 117 HD and turn on GPU it fixes it..
Its purely only this room its happening in, today is the only day its done it. Was fine yesterday

Thanks this is known and we are looking into it

This should be fixed now if you restart RuneLite or update the plugin through the plugin hub panel.


Add TODO List with Vue

There is already a TODO List app built with vanilla js.
Would like to add a Vue version to showcase the differences for newcomers.
Please assign to me and add the corresponding labels.

@JCarlosR can you try with another tech stack

@JCarlosR can you try with another tech stack

Oh, I believe Vue has a good learning curve, but which one would you like? Maybe React or Svelte?

The project already exist, Do not be demotivated and raise a new issue.


Compiler hangs

The following program causes the compiler to hang:
case class Segment(interps: Map[String, Double])
case class Sentence(segments: List[Segment])

BinaryPickleArray(Array()).unpickle[Map[String, List[Sentence]]]

See https://github.com/tindzk/pickling-test for a small sbt project.
There is also a sbt warning which I don't understand:
[warn] Binary version (0.9.2-SNAPSHOT) for dependency org.scala-lang#scala-pickling_2.11;0.9.2-SNAPSHOT
[warn]  in pickling-test#pickling-test_2.11;0.1-SNAPSHOT differs from Scala binary version in project (2.11).

And me (albeit without the sbt warning)

I can't reproduce the compiler hanging using Pickler 0.10.0.
scala-pickling> console
[info] Starting scala interpreter...
[info]
Welcome to Scala version 2.11.4 (Java HotSpot(TM) 64-Bit Server VM, Java 1.7.0_51).
Type in expressions to have them evaluated.
Type :help for more information.

scala> import scala.pickling._, Defaults._, binary._
import scala.pickling._
import Defaults._
import binary._

scala> case class Segment(interps: Map[String, Double])
defined class Segment

scala> case class Sentence(segments: List[Segment])
defined class Sentence

scala> val pkl = Map.empty[String, List[Sentence]].pickle
warning: there was one deprecation warning; re-run with -deprecation for details
pkl: scala.pickling.binary.pickleFormat.PickleType = BinaryPickle([0,0,0,-120,115,99,97,108,97,46,99,111,108,108,101,99,116,105,111,110,46,105,109,109,117,116,97,98,108,101,46,77,97,112,91,106,97,118,97,46,108,97,110,103,46,83,116,114,105,110,103,44,115,99,97,108,97,46,99,111,108,108,101,99,116,105,111,110,46,105,109,109,117,116,97,98,108,101,46,76,105,115,116,91,36,108,105,110,101,49,50,46,36,114,101,97,100,46,36,105,119,46,36,105,119,46,36,105,119,46,36,105,119,46,36,105,119,46,36,105,119,46,36,105,119,46,36,105,119,46,83,101,110,116,101,110,99,101,93,93,0,0,0,0])

scala> pkl.unpickle[Map[String, List[Sentence]]]
warning: there was one deprecation warning; re-run with -deprecation for details
res0: Map[String,List[Sentence]] = Map()

The sbt warning issue is #142, which used happen because Pickling used to be published using org.scala-lang organization and sbt warns when it suspects Scala compiler and library versions do not match up. That's also now fixed in 0.10.0.


Run "clear" on background thread

Hi, @idomizrachi thank you for the contribution! Is there a specific reason you need to run it on a background thread? If the operation is taking a while, we would probably need to also add a notification for the user to know that the clean is complete.

When I have large amount of projects in the Derived Data folder the UI freeze for a few seconds

Ah, I see. Thanks!


[OIS] Make init ZCL Data Model and start server common

Move init ZCL Data Model and start server to openiotsdk-app target.
Implement openiotsdk_chip_run() and openiotsdk_chip_shutdown().
Add chip_add_data_model() cmake function to add a specified data model to the target.
Apply changes in lock-app example.
These changes improve adding new OIS examples. ZCL Data Model initialization and starting server can be shared by using openiotsdk-app target.

@pan- @chrisswinchatt-arm Any comments? Can we merge this?


[Datalake] Create a list_paths() method in DataLakeDirectoryClient

Add support for listing paths in a given datalake directory.

I think this code should work
from azure.storage.blob import BlockBlobService

blob_service = BlockBlobService(account_name='your_account_name', account_key='your_account_key')

blobs = []
marker = None
while True:
    batch = blob_service.list_blobs('rawdata', marker=marker)
    blobs.extend(batch)
    if not batch.next_marker:
        break
    marker = batch.next_marker
for blob in blobs:
    print(blob.name)

The only prerequisite is that you need to import azure.storage.
In the Clusters window, click 'Install-New' -> PyPI > package = 'azure.storage'.
Finally, click 'Install'.


⚠ Bofrost.at has degraded performance

In 25abf2c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1796 ms

Resolved: Bofrost.at performance has improved in a65b627 after 9 minutes.


Add basic support for keys

Add minimal support for keys; this is needed for IPNS support.

BTW, You may dislike the API I added: I wanted to have optional parameters with default values, and for that, I had to place them last, after the return value. This is obviously ugly.  Another alternative would be to pass in a json holding everything as a single input, but this also seems .. pointlessly ugly. Beats me,  Suggest something better, I'll code it up.

Hi,
I removed the optional-ness from key_type and key_size and also changed the type of the latter from std::string to size_t. See commits 80b1fb7 and 87a6cce.
Thanks!


Internal Server Error

Receiving internal server errors all over the website today, just tried to link my github profile to FCC profile and got one.
http://www.freecodecamp.com/link/github

this was a side-effect of the intermittent down time yesterday and should be resolved!


chore(package): remove "request" dependency

The "request" dependency pulls in a whole bunch of modules that aren't
need by observable-event-source.

Thanks for the PR, I agree that any time you can keep functionality and eliminate unneeded dependencies is a win. Can you please add a circleci.yml file so the CI tests pass? https://circleci.com/docs/language-nodejs

@jden rebased this commit off of master

published in v1.0.1


How to achieve geospatial

In mongoose you can do this for a schema attribute:
geo: {
        type: [Number],
        index: '2d'
}

How do you achieve geo queries with dynamoose.
Awesome library by the way.

First, sorry for not replying earlier.  I somehow overlooked this issue.
I don't know much about mongoDB geo queries, but you may be able to accomplish the same thing with DynamoDB maps.


Add unconditional hiding of minimap

@Amaz1 Hello.

Thank you very much! https://github.com/Amaz1/hide_minimap/commit/07d164f8ce7ac3abe2510017a508fbacb97cb9de
Thanks @SmallJoker for pointing that issue out, I fixed it in another commit https://github.com/Amaz1/hide_minimap/commit/9cf58c8be25be980bc4ba1aa34c61b2398288264


InlineBlockBox Component

The proposed <InlineBlockBox /> component is a type of<Box /> component with inline-block display.

I would opt to simplify the name to InlineBlock, a la https://github.com/smyte/jsxstyle
An alternative would be a display prop on the Box component, but think the readability of a separate component would be better

Are we using this a lot?

Closing as this original idea is no longer in scope.


[enchancement] Common CI script

We need a common CI script to run all the CI tests, so that if there is minor change or a new check is added/removed, we do not need to update all the repositories with the minor change.
Read more: https://github.com/openwisp/openwisp-utils/pull/37#issuecomment-461733269

Are these all the scripts that should be run?

checkcommit
runcheckendline
runcheckmigration
runflake8
runisort

However, some of these checks don't apply to all of the repositories, how would you solve that?
For example, runcheckmigration wouldn't really apply in openwisp-website, but checkcommit and runcheckendline should still be run.

@dwang I am thinking command line variable, by default, all tasks will run,
However, if i want to avoid runcheckmigration, i can simply do --no-runcheckmigration to avoid running that script, what do you think about this? :smile:

Sounds good to me!

@atb00ker this sounds great! are you working on this one?

No. I am currently not working on it. :smile:

okay I am working on it now

@atb00ker in which order should the scripts run?
I see checkcommit and runcheckendline should run on every repo.
So I am going to take a maximum of 3 arguments

Tests are not dependant on each other so the order doesn't matter.
You can checkout the .travis.yml file in each repository to checkout what tests are running on that specific repository.
Checkout the same for the following repositories:
- django-ipam
- openwisp-ipam
- django-freeradius
- openwisp-freeradius
- openwisp-users
- openwisp-utils
- openwisp-config
- openwisp-controller
- django-loci
- django-netjsonconfig
- django-x509

@atb00ker I see that the .travis.yml file in each repository is divided in 3 parts

before_install: here ./runflake8 , ./runisort , ./runcheckmigration etc are called
install: here are all install commands...
script: checkcommit runs here and reposoitory specific test i.e jshint, ./runtest , coverage etc are called.

Also there are different commands in each .travis.yml to install openwisp-utils

pip install openwisp-utils[qa]>=0.2.1 in openwisp-config
pip install https://github.com/openwisp/openwisp-utils/tarball/master in OpenWISP-website
pip install https://github.com/openwisp/openwisp-utils/tarball/master#egg=openwisp_utils --upgrade in openwisp-users
pip install -U https://github.com/openwisp/openwisp-utils/tarball/master in django-freeradius
pip install --user https://github.com/openwisp/openwisp-utils/tarball/master in ansible-openwisp

some have the line in requirements-test.txt also a copy of test files present in the repository I am thinking to include the install command for openwisp-utils
few concerns:

Will it be okay to run the test in script section only? and not before_install (see https://github.com/openwisp/django-ipam/blob/master/.travis.yml)
I take the arguments as --no testname1 testname2 testname2 ..... is it fine?

please let me know your views on this :)

@ankit-kumar-dwivedi do not run "before_install" scripts in the "scripts" section. Here's I'm trying to explain why (correction appreciated) -
Running some scripts maybe needed to run the main scripts correctly.
& If any "before_script" or "after_script" fails, it doesn't affects the overall build "status".

"For example, runcheckmigration wouldn't really apply in openwisp-website, but checkcommit and runcheckendline should still be run."
I think we need add variable for exclude repository. @dwang

Yes, CI tests can run after other tests as well, so as long as it works, i don't see a problem. :smile:
Yep, looks Good. If something is ready, can you please make a [Work in progress] pull request so that we can have a look while you are working on it?
Thanks. :smile:

Closed by #45


posts endpoint

Handler

[x] list all posts
[x] get post by id
[x] create new post
[x] update one post
[x] delete one post

Unit tests

[x] list all posts
[x] get post by id
[x] create new post
[x] update one post
[x] delete one post

Swagger documentation

[x] list all posts
[x] get post by id
[x] create new post
[x] update one post
[x] delete one post

#20

will close after merge


Public key and authentication

When validating a signature of a license where should I be storing the public key AND how do I know that the public key is even the one I published?
For example if I distribute my public key in my assembly as a string what prevents someone from just creating their own key pair, generating their own license, creating a signature for it and then replacing my public key in my assembly with their public key?
I think there needs to be some method for ensuring that the public key is authentic. e.g. the one I published.

 You simply can’t.
Here is a nice article on why it does not make sense to worry about:
http://blogs.balsamiq.com/product/2008/10/19/my-views-on-software-piracy/
And here about obfuscation:
http://stackoverflow.com/questions/506282/protect-net-code-from-reverse-engineering
If you still want to check if your assembly was compromised, sign it and add the signature as “AdditionalAttribute” to the license and validate it.
You can also validate the public key via web request to your website, but even this can be cracked with DNS spoofing, etc. Or the attacker simply deactivate your license check at all.
If you’ve further questions i’m happy to invite you to discuss this in here.
Kind regards,
Daniel

I am not meaning to be too critical and I appreciate your points. I'm on board with you as far as thinking that it's pointless to try and fight piracy. However, I believe this is way too easy. Any numbskull could follow the quickstart wiki you have and start printing licenses for all software that uses your library without any customization. At the very least, there should be some suggestion about remotely validating the license file. This way you're not handing the keys to the kingdom entirely to the client side unchecked.


tower-cli returns no hosts for groups with sub-groups

I have a bit of a head-scratcher here: We have a dynamic inventory based on EC2, which is working great. Inside this inventory we have both auto-generated groups (e.g. tag_env_production) and easier to read groups for "human" consumption (e.g: production, which includes the tag_role_app and tag_role_jobs groups, to represent every host that runs on the production environment).
On Tower itself, everything works as expected:

Looking at a group, regardless of whether it's auto-generated (tag_env_production) or manual (production) works fine. I can go into the hosts tab and see which hosts belong to the groups.
Running jobs against specific groups (again – regardless of how they were generated) also works fine. We deploy to production by running a deployment playbook against our production group, for example.

But on tower-cli, some things don't work as expected. Here's what I'm seeing:
Listing all known groups on an inventory works well:
➜ ~ tower-cli group list -i 7
=== ========================= =========
id            name            inventory
=== ========================= =========
300 app                               7
311 badhombre                         7
269 ec2                               7
302 elasticsearch                     7
301 jobs                              7
271 keys                              7
270 key_union                         7
298 production                        7
299 staging                           7
278 tag_datadog                       7
279 tag_datadog_monitored             7
280 tag_env                           7
281 tag_env_production                7
282 tag_env_staging                   7
283 tag_infra                         7
309 tag_infra_v4                      7
(...)

If I try to get the host list for an auto-generated group like tag_env_production (id 281), everything works as expected:
➜ ~ tower-cli host list --group 281
*** DETAILS: Getting records. *************************************************
GET <OUR URL>
Params: {'groups__in': 281, 'page': 1}

== ============== ========= =======
id      name      inventory enabled
== ============== ========= =======
54 <IP_ADDRESS>         7    true
55 <IP_ADDRESS>            7    true
56 <IP_ADDRESS>           7    true
== ============== ========= =======

But if I try with a group like production (with children tag_env_production), I get:
➜ ~ tower-cli host list --group 298 -v
*** DETAILS: Getting records. *************************************************
GET <OUR URL>
Params: {'groups__in': 298, 'page': 1}

No records found.

But if I go to the API browser on Tower itself (https://<OUR URL>/api/v2/groups/298/all_hosts/), though, and hit the page for that group, I can actually see the hosts correctly. It's just tower-cli that queries a different endpoint which returns nothing.
Am I doing something wrong? Is there a tower-cli command that exposes all_hosts that I am not seeing? Or is this functionality simply not implemented yet?
Thanks for your help! 👋

Is there a tower-cli command that exposes all_hosts that I am not seeing? Or is this functionality simply not implemented yet?

I believe it's the latter.


ci: Remove unsupported versions from GKE and AKS

This commit updates the list of tested kubernetes versions on GKE and AKS, removing versions that are no longer supported. AKS version 1.25 hit EOL on Jan 14, 2024; GKE version 1.24 hit EOL on Oct 31, 2023.
Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

/test


WEBSITE_USE_ZIP vs WEBSITE_RUN_FROM_PACKAGE

https://github.com/projectkudu/kudu/wiki/Configurable-settings mentions WEBSITE_USE_ZIP, but https://github.com/Azure/app-service-announcements/issues/84 mentions WEBSITE_RUN_FROM_PACKAGE (which is the new name for WEBSITE_RUN_FROM_ZIP). Is WEBSITE_USE_ZIP a typo, or is it an old name (out of date docs), or is it a separate variable, if so what is the difference?

Yep, that was an even earlier name, sorry. I just updated the wiki.


Serialize enums as maps by default

This matches other serde formats.
Directly set options on Serializer.
Remove rarely used to_* methods.
Closes #85

Search results reveal that to_vec, to_writer and to_vec_packed are primarily used. Other methods such as to_vec_sd are only rarely needed. Therefore users should directly call the Serializer in this case.

Regarding #117, I felt that a config struct without accessors may hinder future extensibility and a separate builder was too much complexity.
It is now possible in theory so change the options in the middle of serialization and shoot yourself in the foot but this requires some effort on the users side.

Yeah, I think just having setters on Serializer/Deserializer for options makes sense.


Update sbt-wartremover, wartremover to 3.1.1

About this PR
📦 Updates

org.wartremover:sbt-wartremover
org.wartremover:wartremover

from 3.1.0 to 3.1.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.wartremover" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.wartremover" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #228.


Update newtonschulz5 to modern method, update interfaces & default params

Updated to the most recent version, inner mult in bf16 before being casted back, default iters are @ 5 now (should be good enough for most cases).

lgtm


docs: add missing typed_config for tls_inspector

Commit Message: docs: add missing typed_config for tls_inspector
Additional Description: Without typed_config, the following error is returned: "Didn't find a registered implementation for 'envoy.filters.listener.tls_inspector' with type URL: ''
Risk Level: none
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

would you be willing to shift the configs here into a literalinclude

Sure, I will try.

heres the PR im working on related to this https://github.com/envoyproxy/envoy/pull/32050
its slow going as - but if i am close to finishing ill land this first and incorporate the change

heres the PR im working on related to this #32050
its slow going as - but if i am close to finishing ill land this first and incorporate the change

Maybe I missed this, but I don't see the same file (docs/root/faq/configuration/sni.rst) being updated in #32050.
IMHO we can probably merge this PR, and later the work in #32050 will either update this file or not. That said, you have more expertise and knowledge related to this, so leaving it up to you.

my auto response to any prs with fixes of this kind is to ask to fix it properly
this is quite frequent - hence my pr to try and head off the issue
agree we might as well land this fix for now tho


Suggested packages

eg. https://github.com/roots/bedrock/pull/150
https://github.com/roots/wp-stage-switcher

this is going to be in docs


[Report] Ambiguous error sent to report owners if selenium times out when taking a screenshot

In https://github.com/apache/superset/blob/2263a76f4d97ef4f3d93e4b45a31e8c3e522e589/superset/utils/webdriver.py#L140, if it times out when taking a screenshot, TimeoutException is swallowed and it will be treated as a generic error in https://github.com/apache/superset/blob/master/superset/reports/commands/execute.py#L233.
From users' perspective, they will see an error on the execution log but there is no error message.
Previously there was a line img=element.screenshot_as_png inside the TimeoutException handling logic https://github.com/apache/superset/blob/00ca21e0161e55e9f4275cd1f59ac85df02851d3/superset/utils/webdriver.py#L144. However, doing it this way could end up with showing users errors that are not related with TimeoutException. For example, if it times out on this line, it ends up with error "trying to access a variable before initialization". Line 144 could also end up with a StaleElemenetReferenceException if it times out at a later point, and because the error is thrown inside the except block, the StaleElementReferenceException won't be caught and will eventually be surfaced to report owners.
How to reproduce the bug

Change all timeout values to a very low number to make it easier to time out when taking screenshots https://github.com/apache/superset/blob/edce57904728156312b795923019a1520147d045/superset/config.py#L587-L596
Create any alert or report
Wait for it to time out
Open execution log and observe the incorrect error message. Meanwhile, on the server side, a timeout exception should be logged for the same alert or report.

Expected results
Either show a partial screenshot (components timed out are not shown properly) or show a timeout error message to users.
Actual results
Shows a ReportScheduleScreenshotFailedError error to users without saying why exactly it fails
Screenshots
N/A
Environment
(please complete the following information):

browser type and version: not browser specific
superset version: latest master branch
python version: 3.8
node.js version: N/A
any feature flags active: ALERT_REPORTS = True

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@zhaorui2022 I'm tempted to close this as stale (we're cleaning up the backlog) but I'm curious if this is still an issue in 3.x. We can keep it open if it's still a problem.

Closing as stale, but happen to reopen if this is still an issue in 4.x.


[NLU-4132] Refactoring: Part II - Simplifying configuration classes and improving code formatting

This pull request introduces a set of updates focused on making the configuration classes easier to manage and improving code quality with the help of some development tools.
Changes

Simplified the structure of certain configuration classes to make it easier to create configurations for new languages. Previously, the base configuration classes used Abstract Base Classes (ABCs) with abstract getter methods. However, this design resulted in bloated code as all properties had to be implemented in child classes, even when unnecessary. To address this, the ABC approach has been replaced with a simpler inheritance model, reducing duplication and overall lines of code.
Added configurations for the following dev tools:

ruff - an extremely fast Python linter.
pyupgrade - a tool to automatically upgrade syntax for newer versions of Python.
isort - a formatter for import statements.
black - a code formatter for ensuring code conformity to stylistic guidelines.

Added a pre-commit configuration that automatically runs these dev tools before commits, to ensure code quality and consistency throughout the project.
Ran ruff, isort, and black on the codebase to fix formatting issues and linting errors.

Pipeline run - https://jenkins.ininica.com/job/NLU/job/Recognizers-Text/489/ ✅

Pipeline run - https://jenkins.ininica.com/job/NLU/job/Recognizers-Text/490/


Give each Perlin a separate prng source.

Note: It'd be nice to take a Source instead of an int64 as the seed, but that would require changing the signature of NewPerlin() (breaking API change) which idk if you want to do.

Thanks for the PR @jpouellet I agree that passing rand.Source is better. To preserve the backwards compatibility a new "constructor" can be added accepting rand.Source as last parameter. Not the clearest idea but it may work.

LGTM :+1:


Handle WSL case with "parallel: true" and "maxConcurrentCallsPerWorker"

For users on WSL, webpack uglify hangs when parallel: true, much like #118. As mentioned there, eventually it's still Windows behind the scenes.
The fix for windows was done in #173 and includes some hints how to implement the check it for WSL.
> os.platform()
'linux'
> os.release()
'4.4.0-43-Microsoft'

See: https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/173/commits/80d3706ea8e4079eb8dffaeda0b3ec759f77f947 for the Windows fix commit.
I thought I'd open an issue for independent WSL discussion and documentation.

@TiemenSch it is always hangs? How fast way to reproduce this problem, maybe need fix something in node-farm

I came across this webpack issue when trying to build an extension for JupyterLab. https://github.com/jupyterlab/jupyterlab/issues/4276
There, all WSL users cannot use the parallel option for production builds. Turning it off at least got me to the finish line.
My latest comment in that thread describes how I came here.
It shows great similarity to the issue that was solved with the platform specific patch for Windows.
I would be very interested to check if applying a similar one liner to https://github.com/webpack-contrib/uglifyjs-webpack-plugin/commit/80d3706ea8e4079eb8dffaeda0b3ec759f77f947 to handle the WSL case. Where I imagine the process.platform === 'win32' would have to be changed to something along the lines of process.platform === 'linux' && process.release === '*Microsoft'.
Please note that I have little JS knowledge, so this may be full of syntactical errors..

@TiemenSch very interesting, can you modify code inside package:
const workerOptions = process.platform === 'win32' || os.release.includes('Microsoft') ? { maxConcurrentWorkers: this.maxConcurrentWorkers, maxConcurrentCallsPerWorker: 1 } : { maxConcurrentWorkers: this.maxConcurrentWorkers };

And check again on hangs.
Also can you post here process.platform value on WSL?

> process.platform
'linux'
> process.release
{ name: 'node',
  lts: 'Argon',
  sourceUrl: 'https://nodejs.org/download/release/v4.2.6/node-v4.2.6.tar.gz',
  headersUrl: 'https://nodejs.org/download/release/v4.2.6/node-v4.2.6-headers.tar.gz' }
> os.release()
'4.4.0-17134-Microsoft'
> os.platform()
'linux'

Ah, I think I spotted a little mistake in your line. It should at least be os.release().includes('Microsoft'). Will try that now.

Hmm, no luck so far. I even tried removing the guard altogether by replacing with:
const workerOptions = { maxConcurrentWorkers: this.maxConcurrentWorkers, maxConcurrentCallsPerWorker: 1 };

Any ideas how I could make a console.log() to the terminal while running the webpack?

How would I make a minimal repo, where all you run is webpack --config webpack.prod.config.js?
The one included in Jupyterlab is
var UglifyJSPlugin = require('uglifyjs-webpack-plugin');
var merge = require('webpack-merge');
var webpack = require('webpack');
var common = require('./webpack.config');

module.exports = merge(common, {
  devtool: 'source-map',
  plugins: [
    new UglifyJSPlugin({
      sourceMap: true,
      parallel: true,
      uglifyOptions: {
        beautify: false,
        ecma: 6,
        mangle: true,
        compress: false,
        comments: false,
      }
    }),
    new webpack.DefinePlugin({
      'process.env.NODE_ENV': JSON.stringify('production')
    })
  ]
});

But I think it would be better to steer clear of going too deep into the Jupyter side of things.
If you would like to debug the exact situation on WSL, you could run the following using conda python:
conda create -c conda-forge -n monaco jupyterlab nodejs
conda activate monaco
git clone https://github.com/jupyterlab/jupyterlab-monaco.git
cd jupyterlab-monaco
npm install
npm run build
jupyter labextension link . --dev

@TiemenSch thanks try to find time on this today :+1:

@TiemenSch Sorry, i can't reproduce problem using you steps (i am on linux). I also testing this on windows and all works fine. I don't know how i can setup WSL and not familiar with him. Can you provide more information or maybe you found solution?

@TiemenSch friendly ping

Hi! Installing WSL isn't too hard, luckily :). https://docs.microsoft.com/en-us/windows/wsl/install-win10
Then you'll have an Ubuntu shell up and running in no-time

I haven't found a solution as of yet, by the way! I tried checking if something as simple as the line endings matter, since I cloned the repo on Windows and WSL mimics Linux, but to no avail.

Feel free to investigate this, i don't have many time right now on testing this on WSL, sorry

No worries! I'll keep stabbing at it from time to time. Pretty crammed as well ;)

I'm running into the same problem on Windows 10/WSL, setting parallel to false or setting maxConcurrentWorkers to 1 solves the problem but setting maxConcurrentCallsPerWorker to 1 seems to change nothing at all.
My proposal would be to change this line to something like:
const workerOptions = ((maxConcurrentWorkers) => {
  if ( process.platform === 'win32' ) {
    return {
      maxConcurrentWorkers: maxConcurrentWorkers,
      maxConcurrentCallsPerWorker: 1
    }
  }

  if ( process.platform === 'linux' && os.release().includes('Microsoft') ) {
    return {
      maxConcurrentWorkers: 1
    }
  }

  return {
    maxConcurrentWorkers: maxConcurrentWorkers
  }
})(this.maxConcurrentWorkers);

This solution will slow the uglifying down by quite a bit but in my opinion it's better that it not working at all.
@evilebottnawi, what are your thoughts on this?

@TiemenSch can you try solution above? If it is solve problem, feel free to send PR :+1:

@evilebottnawi, any chance we could merge this sooner? I'm in dire need of this fix as well as I don't want to add a workaround to tens of project for just a few days/weeks until this gets released.

What are the implications of setting to just 1 worker? Seems rather similar to a non-parallel setup (which is probably why it works). But it's a workaround and not a solution I believe. If @cascornelissen got it working, I've got no objections to merging it as a workaround for now, but it doesn't solve the issue.

@evilebottnawi, should I submit a PR containing this workaround?

@cascornelissen i think better send PR to docs about this is feature doesn't support on WLS, with recommendation disable option

https://github.com/Microsoft/WSL/issues/2613
This issue is listed up here.

Problem still exists?

Yes, it is.
Microsoft version 10.0.17134.285
 "uglifyjs-webpack-plugin": "^2.0.1",

Guys i try to reproducible problem but i can't, maybe can create really minimum reproducible test repo with really minimum setup?

Fixed https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/403


Building tdweb

Hello!
It's not an issue but I was able to build the tdweb using the latest version of emsdk by upgrading the webpack to latest version.  Please input your review.
Following changes I made in installation process
./emsdk install latest && ./emsdk activate latest && source emsdk_env.sh

Following changes in the code base:
build-tdlib.sh
cmake --build build/asmjs --target td_asmjs || exit 1 //removed this line

package.json file
"devDependencies": {
   // other dependencies
    "@babel/plugin-transform-optional-chaining": "^7.24.5",
    "webpack": "^5.91.0",
    "webpack-cli": "^5.1.4",
},
"dependencies": {
    //other dependencies
    "path-browserify": "^1.0.1",
    "uuid": "^3.3.2",
    "ws": "^8.17.0"
},
  "babel": {
    "presets": [
      "@babel/env"
    ],
    "plugins": [
      "@babel/syntax-dynamic-import",
      "@babel/transform-runtime",
      "@babel/plugin-transform-optional-chaining" //added this
    ]
  },

webpack.config.js
const path = require("path");
const CleanWebpackPlugin = require("clean-webpack-plugin");

module.exports = {
  stats: {
    children: true, //added this to get detail error (optional)
  },
  externals: {
    ws: "ws", //added this
  },
  resolve: {
    fallback: {
      dgram: false, // Instead of 'empty', use false to provide nothing.
      fs: false, // Provide a mock if necessary, or false to provide nothing.
      net: false, // Provide a mock if necessary, or false to provide nothing.
      tls: false, // Provide a mock if necessary, or false to provide nothing.
      crypto: false, // Provide a polyfill or mock.
      child_process: false, // Provide a mock if necessary, or false to provide nothing.
      path: require.resolve("path-browserify"),
    },
  },
  entry: ["./src/index.js"],
  output: {
    filename: "tdweb.js",
    path: path.resolve(__dirname, "dist"),
    library: "tdweb",
    libraryTarget: "umd",
    umdNamedDefine: true,
    globalObject: "this",
  },
  devServer: {
    contentBase: "./dist",
  },
  plugins: [
    // new HtmlWebpackPlugin(),
    new CleanWebpackPlugin({}),
    //, new UglifyJSPlugin()
  ],
  optimization: {
    minimize: false, // <---- disables uglify.
  },
  module: {
    noParse: /td_asmjs\.js$/,
    rules: [
      {
        test: /\.(js|jsx)$/,
        exclude: /prebuilt/,
        enforce: "pre",
        include: [path.resolve(__dirname, "src")],
        use: [
          {
            loader: require.resolve("eslint-loader"),
          },
        ],
      },
      {
        test: /worker\.(js|jsx)$/,
        include: [path.resolve(__dirname, "src")],
        use: [
          {
            loader: require.resolve("worker-loader"),
          },
        ],
      },
      {
        test: /\.(js|jsx)$/,
        exclude: /prebuilt/,
        include: [path.resolve(__dirname, "src")],
        use: [
          {
            loader: require.resolve("babel-loader"),
          },
        ],
      },
      {
        test: /\.(wasm|mem)$/,
        include: [path.resolve(__dirname, "src")],
        type: "javascript/auto",
        use: [
          {
            loader: require.resolve("file-loader"),
          },
        ],
      },
    ],
  },
  node: {}, //removed this
  performance: {
    maxAssetSize: 30000000,
  },
};

Since latest version of emsdk doesn't generate .mem file, I removed the related code from worker.js file
worker.js
//import td_asmjs_mem_release from './prebuilt/release/td_asmjs.js.mem';  //removed this liine

// rest of the code

async function loadTdlibAsmjs(onFS) {} //removed the implementation of asm.js

// rest of the code

Since latest version of emsdk doesn't generate .mem file

It wasn't generated, because you removed building of the target td_asmjs.
Newer EMSDK versions wasn't tested, but they may work. If build succeeds, then it is likely that tdweb will work.


Configure cmake and more

Changelist:

Update main with documentation and examples
configure files using cmake

e.g. automatically add version to doxygen, main and README

Adjust config for logging (different format, errors in seperate file..)
Add documentation to CMakeLists.txt
Add custom targets to CMake for astyle and doxygen
Add .json and .bat samples
Update README.md
Add workflows for building and analyzing

Quality gate not passing... Kriege es nicht hin src/include/config.hpp zu excluden


cf-gitbot crosslinking issues to pivotal tracker is broken for this project (and other projects?)

I create an issue on github and cf-gitbot 'helpfully' creates an issue in the 'secret' pivotal tracker.
While I can navigate to the issue and see it... it is otherwise totally 'read only'.
I can't comment on it or subscribe to get notified of issue activity.
So how am going to follow up when someone asks a question?

Not sure what happened to the original tracker story - I created a chore to investigate why this isn't working right -- https://www.pivotaltracker.com/story/show/90416534

@kdvolder we spoke with the maintainers of the cf-gitbot, and learned it does not support cross-posting comments between tracker and github, it simply labels the tracker issue with 'new-activity' when new comments are posted on github.  i would also like to have this functionality, but, this is what we'll have to live with
closing this issue.

Hi @kdvolder,
@davidwadden is correct, but I just wanted to explain/expand a little bit: The primary place that Pivotal uses to orchestrate with the community is here, on GitHub. Internally, we use Tracker to organize and manage our work load. We provide visibility into those trackers for public projects so that people can see where and when the effort has been prioritized.
Tracker's not meant to be a part of the communication mechanism, we'll always conduct our conversations here on GitHub. Since our developers organize their lives out of Tracker, the cf-bots troll GitHub and mark up existing stories with 'new-activity' to alert the PMs and Devs that there are new updates on GitHub to review. Sometimes we don't get a response for days or weeks. The 'new-activity' flag helps ensure we don't lose track of these.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.


Analysis: Thread1.1 9.2.17-Orphaned End Device

This case requires two sniffers to listen on different channels. Originally I set the channel to 12 and 13, the traffic looks normal as expected with PR #869 . However, Harness reports it as failure. The result as below:
ED_9_2_17_Channel_12_13.zip
From pcap and putty log, we can see all packets that Harness would verify are existing. I guess that fail may be due to it must operate on channel 18 (according to test plan, it specifies that Leader_2 needs to run on channel 18). Hence, I re-run this case on channel 12 and 18. But on channel 12 and 18, the device's behavior seems not be normal.
ED_9_2_17_Channel_12_18.zip
I also attach the putty log that connecting with TI CC2538 board which enables logging. So that we can see the traffic exchanges. When operating on channel 12 and 18, end device on channel 12 will send out MLE Announce on channel 18 after it loses the connectivity with its parent. Leader on channel 18 will also response and send MLE Announce on channel 12. But end device seems not receive this announce message, that cause reattach fails.
Then I change to channel 12 and 16, the same issue occurs.
ED_9_2_17_Channel_12_16.zip
But when I verify with posix nodes, everything goes well and reattach successes. @jwhui Could you please help take a look at this? Thanks much.

I'm not exactly sure what the issue is here.  This may be due to a channel configuration issue in the CC2538 radio driver.  The current driver does not disable the receiver before configuring the channel.  I just submitted #873 to address this issue.  Let me know if this helps.

@jwhui Thanks much for addressing this issue, PR #873 works well. I verify this with Harness and simulate manually, both traffic looks normal as expected.
ED_9_2_17.zip
However, test case 9.2.17 is designed incompatible with Spec(should delay 8 hours and then new panid will take effect).I have filed a JIRA TSTBED-25 to have a confirm with GRL.


eslint github action with inline PR annotations

Related Issue
Supports #10
What does this PR do?
Runs eslint as an action on the PR, and leaves comments inline with errors.

We'll may want to remove eslint from the yarn test if we follow this approach, will speed up builds.
What gif most accurately describes how I feel towards this PR?

Seems to be working.


Revert injection's changes does not revert project.pbxproj

The GCC_SYMBOLS_PRIVATE_EXTERN entries added to project.pbxproj by patchProject.pl are not removed by revertProject.pl.

Hi Tony, This is true. Injection has never reverted this particular change which is required for Injection. It should only affect Debug builds.

Thanks for responding, John.  Feel free to close - just noticed while experimenting and thought I would report in case it was an unknown issue that you wanted to address.
Thanks for sharing this magical project.

Always happy to see someones awake out there!  Closing..


Navbar Links ul watch bad in mobile

Hi,
I have added icons in my navbar. But in mobile those watch with margin:0. because the current code is:
// Navbar Links
ul {
margin: 0;
I resoved it this way:
nav ul  {
// disable margin: 0 in materializecss
@media #{$small-and-down} {
}
@media #{$medium-only} {
    margin: 0;
}
@media #{$large-and-up} {
    margin: 0;
}

}

Please provide a way to reproduce it.
Closed due inactivity, feel free to reopen it if it is still necessary.


Can't use as favicon

Would love to be able to use the icons as favicons, at the moment is not possible (or I am doing it wrong).
I tested it like this
{% load icon %}

<!DOCTYPE html>
<html lang="en">

  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="shortcut icon" href="{% icon 'lock' %}">
  </head>

</html>

Based on the usual way of doing it with static
{% load static %}

<!DOCTYPE html>
<html lang="en">

  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="shortcut icon" href="{% static 'img/favicon.svg' %}">
  </head>

</html>

{% static 'img/favicon.svg' %} populates the link to the svg file where is {% icon 'lock' %} renders the svg file content. Those are two different things.


Release 0.8.0

@rultor release it; tag is 0.8.0.

@rultor release it; tag is 0.8.0.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; tag is 0.8.0.

@rafamizes Done! FYI, the full log is here (took me 2min)


Several QoL (Quality of Life) Improvement Requests

Summary
First off, amazing app. Just downloaded it to supplement other streaming apps that I have and it's very nice. Some qol feature requests that I was thinking about:

Resuming a video with different language/subtitle/provider/quality will retain previous values that were set. (i.e. setting subtitles for an anime, then backing out, then using the resume feature that's built in will retain the previous values set)
Mark episodes as "watched" so that when returning to a specific show/season you do not need to scroll through ALL episodes (most needed for Aniwatch since episodes are all under 1 season)
Not sure if this is a bug or Feature, but as indicated above some shows only display 1 season and all episodes are listed in it, specifically noticed this in Aniwatch shows.
Ability to "clear" something from the Home page where it shows you progress of watched, just in case you start something and don't want to finish
Ability to favorite a show so we can go back to specific shows instead of needing to search again
4k? Not sure if this is a limitation of the app or a limitation of the providers, but just wanted to ask since I don't see anything listed in the issues tab.

These are just some that I've thought of based on first impressions. I can try to think of more and add to this as an edit or as another comment, but let me know if this is not the right way to request these. Thanks again!
Please confirm the following

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Great thank you for your message! Don't hesitate if you have other improvements.

Resuming a video with different language/subtitle/provider/quality will retain previous values that were set. (i.e. setting subtitles for an anime, then backing out, then using the resume feature that's built in will retain the previous values set)

Will do 🚀

Mark episodes as "watched" so that when returning to a specific show/season you do not need to scroll through ALL episodes (most needed for Aniwatch since episodes are all under 1 season)

Will do 🚀

Not sure if this is a bug or Feature, but as indicated above some shows only display 1 season and all episodes are listed in it, specifically noticed this in Aniwatch shows.

This is normal because the Aniwatch website has not implemented seasons, they have all the episodes in one place at the same time (but on a website it's more easy to navigate). Maybe I'll try to separate them like 1-100, 101-200 but it's more complicated than it seems.

Ability to "clear" something from the Home page where it shows you progress of watched, just in case you start something and don't want to finish

Will do 🚀

Ability to favorite a show so we can go back to specific shows instead of needing to search again

Will do 🚀

4k? Not sure if this is a limitation of the app or a limitation of the providers, but just wanted to ask since I don't see anything listed in the issues tab.

Impossible for now because my app just retrieve movies/TV shows from streaming websites, if those websites don't have 2K or 4K available then I can't have them either.

For the issue of episodes, I was thinking of scrolling directly to last watched episodes or hiding watched episodes.
But changing the carousel to a list could also be a thing.

For the issue of episodes, I was thinking of scrolling directly to last watched episodes or hiding watched episodes. But changing the carousel to a list could also be a thing.

Skipping to last watched episode seems like the best option, I don't think hiding them is a good idea cause alot of people rewatch the same shows. Like the office, or friends etc. carousel is usually better for navigation on Android tv, unless you did something like Netflix? :o

For the issue of episodes, I was thinking of scrolling directly to last watched episodes or hiding watched episodes. But changing the carousel to a list could also be a thing.

Skipping to last watched episode seems like the best option, I don't think hiding them is a good idea cause alot of people rewatch the same shows. Like the office, or friends etc. carousel is usually better for navigation on Android tv, unless you did something like Netflix? :o

If I implement the hiding option, there would be a way to hide or show watched episodes, but for now I'm focalised on skipping them.
Also could you describe how it is on Netflix? I don't have Netflix myself

Skipping to last watched episode seems like the best option, I don't think hiding them is a good idea cause alot of people rewatch the same shows. Like the office, or friends etc. carousel is usually better for navigation on Android tv, unless you did something like Netflix? :o

If I implement the hiding option, there would be a way to hide or show watched episodes, but for now I'm focalised on skipping them.
Also could you describe how it is on Netflix? I don't have Netflix myself

Netflix does what you mentioned, skip to the end. That works too if it's easier than a toggle for hiding watched. The other app i mentioned does a hide which is fine. Either way I think as long as there's a way to bulk mark as watched (for instance "Mark all previous as watched" so you can do a bunch at once

Skipping to last watched episode seems like the best option, I don't think hiding them is a good idea cause alot of people rewatch the same shows. Like the office, or friends etc. carousel is usually better for navigation on Android tv, unless you did something like Netflix? :o

If I implement the hiding option, there would be a way to hide or show watched episodes, but for now I'm focalised on skipping them. Also could you describe how it is on Netflix? I don't have Netflix myself

Makes sense.
Here is the title page: https://imgur.com/a/amAGy2t
And here is if you click to see more episodes:
https://imgur.com/a/0hzKbgZ

Resuming a video with different language/subtitle/provider/quality will retain previous values that were set. (i.e. setting subtitles for an anime, then backing out, then using the resume feature that's built in will retain the previous values set)
Mark episodes as "watched" so that when returning to a specific show/season you do not need to scroll through ALL episodes (most needed for Aniwatch since episodes are all under 1 season)
Ability to favorite a show so we can go back to specific shows instead of needing to search again

Available on Release 1.5.0

Ability to "clear" something from the Home page where it shows you progress of watched, just in case you start something and don't want to finish

Available on Release 1.5.0
You can remove a show in the "Continue watching" row by doing a long click on it.

Thanks for the updates. I do see the favorites and clear. Is there a way to mark a certain number of episodes watched, for instance I'm already halfway done with a show and want it to skip ahead.
Also side note, trying to watch episodes on Aniwatch and getting bad-base64 error.

Thanks for the updates. I do see the favorites and clear. Is there a way to mark a certain number of episodes watched, for instance I'm already halfway done with a show and want it to skip ahead.

Unfortunately, that feature isn't available yet.
However, for now, you can mark your previous episode as watched, by doing that the app will know your current episode.
For example, if you're at episode 50, you can watch episode 49, skip to the end to mark it as watched, then the app will propose you to watch episode 50 and scroll directly to it.

Also side note, trying to watch episodes on Aniwatch and getting bad-base64 error.

Okay, I'll look into it. Maybe try again in a few hours; it might resolve itself.


Choice of build tools

I will try implementing some type of automated build tool for Jenkins to run on feature/automated-testing. Currently I have heard the best reviews for cmake, so I will use that for now. I am interested to hear everyone's opinions on the matter.
This list gives a good run down on many different options.

I think this can be closed for now. The current Makefile-based system seems to be working well for the scope of the project. Feel free to re-open if anyone disagrees :)

agreed!


up/down arrow in integrated terminal prints escape sequence

Issue Type: Bug
Press up arrow or down arrow keys while the focus is in the Integrated Terminal. Instead of cycling next/previous commands, it prints ^[[A or ^[[B to the terminal.
I am using VSCode on macOS 10.13.6
VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:36:32.643Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2900)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (8.85GB free)

Process Argv
--crash-reporter-id 816f329a-629d-4df9-ad82-46e1b2aaceb3

Screen Reader
no

VM
0%

Extensions (18)

Extension
Author (truncated)
Version

vscode-openapi
42C
4.5.0

vscode-apollo
apo
1.18.8

cmake-format
che
0.6.11

path-intellisense
chr
2.3.0

svg
joc
1.4.5

vscode-styled-components
jpo
1.5.2

openapi-lint
mer
1.2.0

csharp
ms-
1.23.11

vscode-ros
ms-
0.6.7

python
ms-
2021.4.765268190

jupyter
ms-
2021.5.745244803

remote-ssh
ms-
0.65.4

remote-ssh-edit
ms-
0.65.4

cpptools
ms-
1.3.1

vscode-typescript-tslint-plugin
ms-
1.3.3

vscode-yaml
red
0.18.0

mdx
sil
0.1.0

remote-x11-ssh
spa
1.5.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt678:30270856
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvspyt639:30291489
pythontb:30283811
vspre833cf:30267465
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30276952
pythondataviewer:30285071
vscus158cf:30286554
vscgsv2:30294352

When I went to provide additional information for this issue, I found a suggestion to enable "escape sequence logging". This is a debugging option for the terminal. Turns out it was actually enabled, that's why this was going on:
https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging
If you stumble on this issue when looking for a solution, hit F1 ("fn" key on newer Macs displays function keys in the touchbar) and type "Terminal: enable escape sequence logging". That will toggle it.

This keeps happening to me. It would be great if this wasn't so easy to do by hitting the wrong keys.


docs fix on contributing link and menu bar shortcut

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @louis-csm for your time and the solution you are suggesting.
Unfortunately, this solution does not completely resolve the issue as it does not work on GitHub. There is a discrepancy between how GitHub and mkdocs render emojis with markdown.
Closing for now, until a solution is found.


Unable to find page in Confluence SaaS

I've used Mark for a Confluence server hosted on-prem but I'm trying to set it up for Confluence SaaS. Is this possible? What does a typical .config/mark look like for Confluence SaaS? Is the base url everything before /wiki/?
Assuming the base url and space Id is as follows:
{base_url}/wiki/spaces/{spaceId}
https://instance.atlassian.net/wiki/spaces/~123456123
2022-03-09 15:06:50 [FATAL] unable to resolve page location
                            └─ can't create ancestry tree:
                               └─ can't find root page for space "**REDACTED**"
                                  └─ no such space

Hi, the base url should not contain /spaces/ path, you specify path with SPACE directive in the document itself. Try just https://instance.atlassian.net/wiki/ instead

I've added /wiki/ to the base url and another error showed up. I'm trying to figure out my username as it doesn't appear to be my email. I've tried using the id found in my profile url but same error. Could there be another id or username?
https://instance.atlassian.net/wiki/people/5d71708366fb
2022-03-09 22:24:35 [FATAL] unable to resolve page location
                            └─ error while finding page "Mark Atlassian Confluence"
                               └─ Confluence API returned unexpected status: 401 (Unauthorized)

You probably forgot to use your unique api key instead of password
On Thu, 10 Mar 2022 at 11:29, Kory Sansom @.***> wrote:

I've added /wiki/ to the base url and another error showed up. I'm trying
to figure out my username as it doesn't appear to be my email. I've tried
using the id found in my profile url but same error. Could there be another
id or username?
https://instance.atlassian.net/wiki/people/5d71708366fb
2022-03-09 22:24:35 [FATAL] unable to resolve page location
                        └─ error while finding page "Mark Atlassian Confluence"

                           └─ Confluence API returned unexpected status: 401 (Unauthorized)

—
Reply to this email directly, view it on GitHub
https://github.com/kovetskiy/mark/issues/166#issuecomment-1063679534,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAN7ZH7EVO5RDZZU5E3Z33U7GCEPANCNFSM5QK3NJHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

That was it. Thank you!


Special variables doesn't work

May be I'm doing something wrong, but all other variables works just fine. And only special does nothing

Have Same Problem:
Example:

Could there be a conflict with other Plugins?
My Plugins right now (Desktop App Windows)

Calendar
CodeMirror 6 snippets
CodeMirror Line Numbers
CodeMirror Options
CodePerfect
Conflict Resolution
Email Note
Favorites
Folding in Code Mirror Editor
Font Size Shortcut
Hotfolder
Inline tags
Kanban
Markdown Prettier
Menu items, Shortcuts, Toolbar icons
MultiMarkdown Table Tools
Note list sidebar toggle buttons
Persistent Editor Layout
Plugin Bundle
Quick Links
Rich Markdown
Spoilers
Table Formatter Plugin
Tagging
Templates
Text Colorize
Whitespacer
Backup

Can you post an example.


Terminal produces repeated information when resizing

VSCode Version: 1.21.1
OS Version: Windows 10/7
Terminal Type: PS/cmd

Steps to Reproduce:

open terminal and drag side bar as small as possible.

input a long string.

drag side bar to right.

Does this issue occur when all extensions are disabled?: Yes

Duplicate https://github.com/Microsoft/vscode/issues/26375


Update Rec Room

Game Title
Rec Room
Status of the Anti-Cheat
🕧 Planned
Tinkering Steps
This was said by a Staff Member named Star Centurion. He also said that the game is switching EAC versions, and that it's gonna be before early 2024. Photo was sent to a thread by a Community Mod Manager.
Proof of Mention
https://cdn.discordapp.com/attachments/1020390284552589342/1167984082542678146/IMG_7827.png?ex=65501cf1&is=653da7f1&hm=862b136a65b84202a3e7e7e0d6bda227e8410538c7a19b87d267c7d15a7506dd&

Appears that the game is working and running as of 2024, so I'll be moving it straight to the Running status instead.


transport: pool, replace random and next with least busy connection

Relates to https://github.com/scylladb/gocql/pull/86

Note the Waiting func from https://github.com/mmatczuk/scylla-go-driver/pull/139/commits/10bbfff16f631d732cee1c12627833b32228047e


Docs: add Azure ADLS Gen2 support for Unity Catalog Export

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(cap-config-writer): update cds plugin ui5

TBI - Update cds-plugin-ui5 version #2053
There is a fix introduced in the latest cds-plugin-ui5: "^0.9" for the CAP Kyma build compatibility.

Doesn't this need to be updated?
https://github.com/SAP/open-ux-tools/blob/e39dc02d9561f974d11ad7fcb424e708e7cc0d7f/packages/cap-config-writer/src/cap-config/package-json.ts#L6

Yes, thank you!

Thank you All


feat: make EmitFuncContext::iw_context pub

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.84%. Comparing base (e2624b5) to head (aad2dbc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   82.84%   82.84%
=======================================
  Files          16       16
  Lines        2221     2221
  Branches     2221     2221
=======================================
  Hits         1840     1840
  Misses        246      246
  Partials      135      135

Flag
Coverage Δ

rust
82.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] ModuleNotFoundError: No module named '_ctypes'

Prerequisites

[X] I have read the documentation.
[X] I have checked other issues for similar problems.

Backend
Local
Interface Used
CLI
CLI Command
conda create -n autotrain python=3.10
conda activate autotrain
pip install autotrain-advanced
conda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch -c nvidia
conda install -c "nvidia/label/cuda-12.1.0" cuda-nvcc
Once done, you can start the application using:
autotrain app --port 8080 --host <IP_ADDRESS>
UI Screenshots & Parameters
No response
Error Logs
(autotrain) dell@dell-Latitude-E7470:~/projects/ai$ autotrain app --port 8080 --host <IP_ADDRESS>
Traceback (most recent call last):
File "/home/dell/.pyenv/versions/3.9.7/bin/autotrain", line 5, in
from autotrain.cli.autotrain import main
File "/home/dell/.pyenv/versions/3.9.7/lib/python3.9/site-packages/autotrain/init.py", line 28, in
import torch._dynamo
File "/home/dell/.pyenv/versions/3.9.7/lib/python3.9/site-packages/torch/init.py", line 17, in
import ctypes
File "/home/dell/.pyenv/versions/3.9.7/lib/python3.9/ctypes/init.py", line 8, in
from _ctypes import Union, Structure, Array
ModuleNotFoundError: No module named '_ctypes'
Additional Information
I haven't clone this repo. it's not needed right?

does this work: https://stackoverflow.com/questions/27022373/python3-importerror-no-module-named-ctypes-when-using-value-from-module-mul ?


selector not generated for Deployment when upgrade extensions/v1beta1 to apps/v1

background
we have a old version(extensions/v1beta1) of configuration for Deployment that didn't set selector field, this has been running in k8s 1.14. While migrating to k8s 1.16, we found extensions/v1beta1 has deprecated. for the new version 'apps/v1', the selector field is now a required field according to schema. than i use this plugin to upgrade configuration in cluster
issue
although we have the apiVersion upgraded, but the selector field is not generated, and cause some issues to do further helm upgrade
Any thoughts, ideas will be appreciated!

@isaactl If you update the chart to contain the selector, does it then work when you do an upgrade? If not what is the error output?

hi @hickeyma yes, in that case, i can do the upgrade without an issue.
my scenario is fetch the manifest from k8s and do the upgrade based on that manifest(for example, update the image field only). since the selector is missing, the update manifest become invalid. i've tried kubectl convert, it does generate the selector.  i can certainly add this field by myself, just wondering if mapkubeapis can also support this? thanks!

@isaactl It is good that you are able to progress and not blocked.

i can certainly add this field by myself, just wondering if mapkubeapis can also support this?

It is a good point that you raise. I would however prefer keeping the plugin to do the sole job of updating release APIs. I want to avoid introducing additional capabilities as there are numerous other updates that could be added like status etc. The problem with this is that the code base would balloon and a limit would be found on what could be supported or not. The plugin should be simple.

@hickeyma i understand keep this plugin simple is important, so i'll close this issue. thanks for the reply!


Help: empty conda env folder

Hi everyone, I am new to using Snakemake with the single-cell pipeline, which creates the work environment using the yaml files. And run the snakemake --use-conda --cores 100 --conda-frontend mamba and it did ceate an conda env folder in .snakemake, but it was empty. Does anyone know what happened here?
$tree .snakemake/conda
.snakemake/conda
├── 2302e8a2b24957448bdd9a074a70606c
│   └── env_setup_start
├── 2302e8a2b24957448bdd9a074a70606c.yaml
├── 4138873ee150fa652aa292eb478f8587
│   ├── env_setup_done
│   └── env_setup_start
├── 4138873ee150fa652aa292eb478f8587.yaml
├── af96026330a10a8a6c5149fc72afc917
│   ├── env_setup_done
│   └── env_setup_start
├── af96026330a10a8a6c5149fc72afc917.yaml
├── f692e1767dd3079f910a2a94deffb51d
│   ├── env_setup_done
│   └── env_setup_start
└── f692e1767dd3079f910a2a94deffb51d.yaml

4 directories, 11 files

You could delete the empty conda environment folders, and try creating them again with the --conda-create-envs-only and --verbose options to see the error messages from Conda.

You could delete the empty conda environment folders, and try creating them again with the --conda-create-envs-only and --verbose options to see the error messages from Conda.

Thank you @kbseah ! I have solved this problem by building the singularity image first instead of using conda.


calculate nCr under some mod in dart

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
implement Binary Exponent calculation in Dart
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
closes #5792

https://replit.com/@AshutoshKhandua/PrettySelfishDividend


Allow joining lines without spaces

An option to concatenate lines without a space in between would be useful for generating names from prefix and suffix tables.
For example, I have a table of 100 goblin name prefixes like these:
Ark
Az
Balg
Zib

And another table of 100 goblin name suffixes:
sog
shuk
gad

When those tables are rolled as a pair, I currently get names like  "Ark sog" and "Az gad". I then have to manually remove the spaces. It would be nice if they weren't there in the first place.
Bonus: An option to auto-capitalize the first letter of the text would help with names, too, because then I would need only a single table of lower-case syllables instead of separate prefix and suffix tables.

Unfortunately, I won't be able to support either of these features without majorly extending this module. It is impossible to enter a space as a text line in a table, because Foundry automatically trims out the space to be an empty value. So, without adding the space automatically, there would be no way for users who needed that space to add one in.
Similarly, adding options like that would need a major extension to tables generally, and cross-compatibility with those extensions with BetterTables.


'nuxt build' failed on Netlify but work on local

Version
v2.13.0
Steps to reproduce

What is expected ?
Build should work, this the package.json build script (name: generate):
generate: npm run build && npm run export && npm run build:netlify-functions
nuxt.config.js: mode: "universal", target: "static"
What is actually happening?
Build failed with error:
8:19:16 AM: ┌─────────────────────────────┐
8:19:16 AM: │   "build.command" failed    │
8:19:16 AM: └─────────────────────────────┘
8:19:16 AM:
8:19:16 AM:   Error message
8:19:16 AM:   Command failed with exit code 1: npm run generate
8:19:16 AM:
8:19:16 AM:   Error location
8:19:16 AM:   In build.command from netlify.toml:
8:19:16 AM:   npm run generate

This bug report is available on Nuxt community (#c10816)

Hello @ballonura, do you have the same issue when using the command line npm run build && npm run export and defining target: 'static' in the config file?

Yes, my settings:
mode: "universal"
target: "static"
Thx.

Problem solved: Netlify using old node version 8.x.x.

Problem solved: Netlify using old node version 8.x.x.

You can set the node version via your netlify.toml btw 😋
Closing here 👍


Added: Issue Template for bug report and feature requests

fixes: #56
Added issue template for raising bug and feature requests.

Thank you for your first contribution @Abhijay007. Would you like to pick up another bug?

@sharmaaditya570191 thanks for inviting me to the community !! yes, I would like to work on other bugs too.
I will soon raise a issue regarding the PR template.


Folder where the message was delivered

Get-MessageTraceDetail | Where {$_.Event -eq "Deliver"} returns "The message was successfully delivered." as a value for the "Detail" attribute. But this doesn't state to which folder the message was delivered. Is it right to assume that this value say the message was delivered to Inbox? If I sent a spam message it says "The message was delivered to the Junk Email folder". Please confirm this in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 690f2980-4a4e-7efd-fe5e-29c551c02e6f
Version Independent ID: 4ab7a6db-db36-c736-6ce5-2f0e74b0cf6a
Content: Get-MessageTraceDetail (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Get-MessageTraceDetail.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@badsector-82, I don't think the level of detail extends to specific folders within the mailbox. For example, spam messages are first delivered to the Inbox, and then moved into the Junk Email folder by the hidden Inbox rule named Junk E-mail Rule (as long as the rule is enabled).
You can also configure Inbox rules to move messages with certain characteristic to a designated folder, or even delete the message. But even then, the message is delivered to the Inbox before being moved or deleted.
So, yeah, I would say "The message was successfully delivered" means the message was delivered to the Inbox. What happens after that, message trace can't tell. If you would like a definitive answer, I would suggest opening a support case.

@badsector-82 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


JitsiMeetEventListener() is not working when end room by clear all screen.

Actual behavior: When I end call by clear call screen, JitsiMeetEventListener() is not working.
Expected behavior: When I end call by clear call screen, JitsiMeetEventListener() should working.
https://github.com/jitsi/jitsi-meet-flutter-sdk/assets/65479486/22f698d9-7ba4-474f-845f-b49ae345cec4

Not sure I understand. You are swiping out the JitsiMeetActivity, right? There is very little time to do anything wheen the activity is destrooyed. What do you exppect it to happen?

Want to detect when I leave conference room. if end by bottom(icon end on UI), then I can use readyToClose() event.

Want to detect when I leave conference room. if end by bottom(icon end on UI), then I can use readyToClose() event.

Yes, that is correct. But if you swipe the activity out there is no way for the meeting to tell you. You'll need to listen to activity lifecycle events.


[NSE-855] allocate large block of memory for all reducer

What changes were proposed in this pull request?
allocate a large block of buffer, then slice for each reducer and each column. Arrow still doesn't support 2M alignment, so large page isn't enabled.
How was this patch tested?

If /sys/kernel/mm/transparent_hugepage/enabled is set to alwasy, THP can allocate huge page automatically for the buffer, both page fault and DTLB misses will decrease.
But Please note to page fault, most time is spending to allocate physical memory and free page caches, the PR may allocate more memory so page fault may takes more time actually.


Color impairment only works in modern browsers

Expected
Demos to show components with non-standard colours.

Result
Demos show standard colours.

(Screenshot: Safari 11.0.2, also seen on iOS.11)

I suggest to add a note rather than building a thing that does this. The gain here is not large enough to warrent us to build a package that parses css and turns each color.

We are trying to show a message however there are some issues with that. The reason this happens in safari is because it supports css filter but not svg filters. One work around would be checking if we support svg filters and hiding and showing the sections.
This currently works in older browsers:
https://github.com/govau/GOLD/blob/master/src/assets/css/a11y/a11y.css#L55

Yeah we may need to add a note that says webkit safari does not support this feature and sad face emoji

Happy to do that ^ sounds like a quick win in the meantime!

These examples seem to work in safari, I am going to investigate deeper into why these work and ours do not:
https://css-tricks.com/color-filters-can-turn-your-gray-skies-blue/

This is a bug in safari causing this issue:
https://github.com/alex-page/bug-safari-svg

@alex-page can you make sure you report this upstream: https://github.com/LukyVj/accecss

Yes will do


opacity issues when Text is laid over SliderIOS

Hi,
I'm currently developing a custom component inspired by iOS' slide to unlock functionality (the module is named react-native-slider-button). However, when the Text component is laid over the slider there is an issue with the Text's opacity causing the opacity to look less bright. If I turn the SliderIOS' opacity to 1.0 the Text becomes invisible. When I hide the slider by setting its opacity to 0 the text uses as demanded.
This behaviour can be tested by using the following sample project.
The opacity definition is located in the following file: node_modules/react-native-slider-button/SliderButtonStyleConstant.js. Being capable to have opacity of both the slider and the label (at the "top" of the animation of course) is my goal.
This problem might be related to the issue 2148.
I appreciate any help. Thanks in advance!

@agentS - @ide's solution in https://github.com/facebook/react-native/issues/2148#issuecomment-135950957 should work for you here :smile: - let me know if not in Slack (@brentvatne)


Reformatted quotes in 0115

The use of code blocks for quotes was confusing, especially given that the quotes were so long in this proposal, so I applied block-quote formatting. I also pushed the quoted code into those block-quotes to make it clear that they're still part of the quote and moved an "author's note" after a code example that directly followed the text explaining it.

Yeah, this looks clearer to me. Thanks!


Log "Watching..."

It would be nice to have a line of output saying "Watching..." when watching the file system.  Its a little hard to know that webpack is doing the right thing without this logging.

True...

The related PR was merged so I'm closing this issue.


import SVG directly as a React Component

希望能像cra一样 既提供导出svg资源，又支持导出组件
import { ReactComponent as Logo } from "logo.svg"
import logo from "logo.svg"

This is React specific and can be only be done via plugins.

See https://www.npmjs.com/package/vite-plugin-react-svg

@svgr/rollup resolved that

@Chastrlove Can you share your config here. I am trying to add:
{
  ...svgr({
    memo: true,
    icon: true,
    svgoConfig: {
      removeViewBox: false
    }
  }),
  enforce: 'pre',
}

as plugin, but this isn't working. It still imports .svg as a file.

@phoenisx Just add this to svg.d.ts and add it to include array in tsconfig.json and you get proper TS support
declare module "*.svg" {
	import * as React from "react";

	export const ReactComponent: React.FunctionComponent<
		React.SVGProps<SVGSVGElement> & { title?: string }
	>;
}

Is there any way to disable the use of the existing SVG transformer? Sure, this works as a workaround, but it leaves a lot to be desired. First, the SVG assets are still copied to the output. Second, the default export cannot be overwritten, leaving needless use of named imports instead.
The typing can be solved by not specifying client.d.ts in tsconfig and providing a type of your own, such as mentioned previously, but there's no way to achieve proper support for SVGs in React even with plugins for as long as there is a hard coded transformer already present.

@AlexGustafsson Please open a new issue for that 👍


Separate Out Node Feature Discovery

This is installed by the NVIDIA AMD operators, but it's a common Kubernetes project, so we should manage this separately which allows centralized configuration, especially to do with scheduling tolerations so we can schedule it on a control-plane node and allow scale from zero.

Additional benefit: in a mixed vendor cluster these two aren't fighting over management in order to determine where to run the device drivers based on hardware.


[feature request] tab auto complete branch name

would be nice to have tab auto completion for branch name.

It is already supported on bash and zsh, what shell are you using?

Note that completion files are under the extra directory, and you have to install them yourself. Neither python setup.py install (install legit) nor legit --install (install git aliases) will install them.


Remove only affected parameters

Sometimes utm_* parameters  aren't placed at the end. This would solve this issue by replacing only single utm parameters.

Sorry I never reviewed this. I've rewrote the extension and it now only removes utm parameters. Thanks for your contribution though.


How can I change button style (color, variant)

How can I change button style when add new, edit or delete event

You can use customViewer and write your own from scratch. search for customViewer in the ReadMe


Google Maps Script doesnt render Maps

🐛 The bug
I've followed the instructions to install Nuxt Scripts here https://scripts.nuxt.com/docs/getting-started/installation
Afterwards I followed the instructions to install Google Maps Script in my vue app.
<script setup>
const isLoaded = ref(false);
const center = ref();
const maps = ref();

const query = ref({
  lat: -37.7995487,
  lng:<PHONE_NUMBER>,
});

const markers = ref([]);

let increment = 1;
function addMarker() {
  // push to markers, we want to add a marker from the center but randomize the position by a bit
  const _center = center.value || query.value;
  // lat and lng may be a function
  const _lat = typeof _center.lat === "function" ? _center.lat() : _center.lat;
  const _lng = typeof _center.lng === "function" ? _center.lng() : _center.lng;
  const lat = (1000 * _lat + increment) / 1000;
  const lng = (1000 * _lng + increment) / 1000;
  increment += 1;

  markers.value.push(`${lat},${lng}`);
}

function removeMarkers() {
  markers.value = [];
  increment = 1;
}
function handleReady({ map }) {
  center.value = map.value.getCenter();
  map.value.addListener("center_changed", () => {
    center.value = map.value.getCenter();
  });
  isLoaded.value = true;
}
</script>
<template>
  <ScriptGoogleMaps
    ref="maps"
    api-key="AIzaSyAizkRBWxmQGYXOIUD3QtxrcEr63EKyxe4"
    class="group"
    above-the-fold
  />
</template>

I ran yarn dev
The http server starts http://localhost:3000. When opening in the browser it shows the map but it is blank/gray. I don't see any JS errors/logs or errors/logs in the nuxt server.
I confirmed that my API key has permissions to use the required APIs.
🛠 To reproduce
https://stackblitz.com/edit/nuxt-starter-pkwfkx?file=README.md
🌈 Expected behavior
Maps should appear
ℹ Additional context

Hi, as far as I can tell this is because you haven't given the map anywhere to open on, you must either have a top-level center or configure the mapOptions.
See https://stackblitz.com/edit/nuxt-starter-uz9rzi?file=pages%2Findex.vue
I've updated the docs to hopefully make this clearer.


Fix "events" on ds-calendar-app

Also ensure change triggers AFTER schedules are modified and calendar is updated.

Added 3 "global" events:

event-remove
event-update
event-create


Some text is not displayed in pdf.js, but display in foxit or chrome viewer

Some text of specified PDF is not displayed in pdf.js, but display in foxit or chrome embeded viewer.
display_bug.pdf
Configuration:

Google chrome 85.0.4183.102
PDF.js 2.6.347

Steps to reproduce the problem:

Open attached PDF in pdf.js web viewer

This PDF seems to load fine for me.  see screenshot:
const pdfjsVersion = '2.7.90';
const pdfjsBuild = '6728c8fa6';

@amit777 Where i can find 2.7.90 version?

See this version in web viewer source, bug still reproduced.
My operation system: windows 10