[BUG] 'pub' is not recognized as an internal or external command

Describe the bug
First time I've tried fvm, but pretty sure this isn't supposed to happen:
❯ fvm use 1.22.0-1.0.pre
Project now uses Flutter: 1.22.0-1.0.pre
Unhandled exception:
Exception: Sorry could not link C:\Users\Kent\fvm\versions\1.22.0-1.0.pre
#0      createLink (package:fvm/utils/helpers.dart:43:5)
#1      updateFlutterSdkBinLink (package:fvm/utils/project_config.dart:29:3)
#2      setAsProjectVersion (package:fvm/utils/project_config.dart:23:3)
#3      UseCommand.run (package:fvm/commands/use.dart:77:7)
<asynchronous suspension>
#4      CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#5      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#6      new Future.sync (dart:async/future.dart:223:31)
#7      CommandRunner.run (package:args/command_runner.dart:112:14)
#8      fvmRunner (package:fvm/fvm.dart:27:23)
#9      main (file:///C:/Users/Kent/AppData/Roaming/Pub/Cache/hosted/pub.dartlang.org/fvm-1.2.3/bin/main.dart:4:9)
#10     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
'pub' is not recognized as an internal or external command,
operable program or batch file.

To Reproduce
Steps to reproduce the behavior:

fvm install 1.22.0-1.0.pre
cd a_flutter_project
fvm use 1.22.0-1.0.pre

Expected behavior
fvm use should work as advertised.
Desktop (please complete the following information):

OS: Windows 10
FVM 1.2.3

@kentcb could you provide which version of dart you are running?

same error
λ fvm use stable --global
The global Flutter version is now stable
Make sure sure to add C:\Users\Avell\fvm\default\bin to your PATH environment variable
Unhandled exception:
Exception: Sorry could not link C:\Users\Avell\fvm\versions\stable
#0      createLink (package:fvm/utils/helpers.dart:43:5)
#1      setAsGlobalVersion (package:fvm/flutter/flutter_tools.dart:145:3)
#2      UseCommand.run (package:fvm/commands/use.dart:74:7)
<asynchronous suspension>
#3      CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#4      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#5      new Future.sync (dart:async/future.dart:223:31)
#6      CommandRunner.run (package:args/command_runner.dart:112:14)
#7      fvmRunner (package:fvm/fvm.dart:27:23)
#8      main (file:///C:/Users/Avell/AppData/Roaming/Pub/Cache/hosted/pub.dartlang.org/fvm-1.2.3/bin/main.dart:4:9)
#9      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

@toshiossada Could you send me the logs when you sun with the --verbose flag?

I solved runing as administrato

@kentcb Could you confirm that running as an administrator solves it for you?

Will be closing this issue as part of a better documentation guide for running on windows on #119


Add http1.0 support to gateway

Description:

Add HTTP/1.0 support to gateway configuration generation

Related issues:

Fixes #13085

:thinking: :bug: You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Demonsthere
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @Demonsthere. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I signed it!

st

Hello,
I was able to verify it by creating my own pilot docker image, and exposing an nginx deployment though the ingress-gateway:
 curl -iv -0 -H "Host:test.foo" http://test.foo:31380
* Rebuilt URL to: http://test.foo:31380/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to test.foo (<IP_ADDRESS>) port 31380 (#0)
> GET / HTTP/1.0
> Host:test.foo
> User-Agent: curl/7.54.0
> Accept: */*
>
* HTTP 1.0, assume close after body
< HTTP/1.0 200 OK
HTTP/1.0 200 OK
< server: istio-envoy
server: istio-envoy
< date: Mon, 03 Jun 2019 09:19:08 GMT
date: Mon, 03 Jun 2019 09:19:08 GMT
< content-type: text/html
content-type: text/html
< content-length: 612
content-length: 612
< last-modified: Tue, 23 Dec 2014 16:25:09 GMT
last-modified: Tue, 23 Dec 2014 16:25:09 GMT
< etag: "54999765-264"
etag: "54999765-264"
< accept-ranges: bytes
accept-ranges: bytes
< x-envoy-upstream-service-time: 0
x-envoy-upstream-service-time: 0
< connection: close
connection: close

<
<!DOCTYPE html>

<title>Welcome to nginx!</title>

Welcome to nginx!

If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.

For online documentation and support please refer to
nginx.org.

Commercial support is available at
nginx.com.

Thank you for using nginx.

* Closing connection 0

HTTP1.0 is active and working. If there need to be some test added, I might need some guidance where what to add :)

/assign @costinm

/ok-to-test

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
f1a8cf40851a0398e68b52a2daa2d360093ccc14
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
f1a8cf40851a0398e68b52a2daa2d360093ccc14
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
f1a8cf40851a0398e68b52a2daa2d360093ccc14
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a7d146c18d6df7314b28567146ff6076a5b3f186
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Demonsthere: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a7d146c18d6df7314b28567146ff6076a5b3f186
link
/test e2e-simpleTests-master

prow/integ-mixer-k8s-presubmit-tests.sh
a7d146c18d6df7314b28567146ff6076a5b3f186
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Look forward to merge ASAP.

@Demonsthere: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
a7d146c18d6df7314b28567146ff6076a5b3f186
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
08caf60ff1535a9f5ff6f2c5593f0189e4469c4f
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
fbbf763a9ba8f4a22a7e3e9870e60a7aaaf8f23c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hi, could someone take a look on the e2e-simpleTests-master? It is failing, but I don't think it is related to my changes @howardjohn

/test e2e-simpleTests-master

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
fbbf763a9ba8f4a22a7e3e9870e60a7aaaf8f23c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@Demonsthere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
fbbf763a9ba8f4a22a7e3e9870e60a7aaaf8f23c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn  @costinm Any more suggestions, or could we merge this?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Demonsthere, howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn thanks for the support! Any chance this will be added to 1.2?

It will be nice if merged in current 1.1.*.

@Demonsthere so the procedure is PR's should go to master and then get tagged with the action/merge-to-release-branch tag.  A bot will open a new PR to the current release branch automatically once the one to master merges.  There were some conflicts so I created a cherry-pick PR here: https://github.com/istio/istio/pull/15062

@GregHanson any chance you could cherry-pick this to 1.1 as well?   I promise I won't ask for HTTP/0.9 support :)

@GregHanson nevermind, I'll take care of the cherry pick


Build failure: gimp-with-plugins

Steps To Reproduce
Steps to reproduce the behavior:

build gimp-with-plugins

Build log
building the system configuration...
error: builder for '/nix/store/3rzl6mwdk8w06pivfabzk8hkv4l666lq-gimp-plugin-gap-2.6.0.drv' failed with exit code 2;
       last 10 log lines:
       > ./libavcodec/bitstream.h:65: Error: operand type mismatch for `shr'
       > ./libavcodec/bitstream.h:65: Error: operand type mismatch for `shr'
       > ./libavcodec/bitstream.h:65: Error: operand type mismatch for `shr'
       > make[3]: *** [common.mak:25: libavformat/adtsenc.o] Error 1
       > make[3]: Leaving directory '/build/gimp-gap-2.6.0/extern_libs/ffmpeg'
       > make[2]: *** [Makefile:440: /build/gimp-gap-2.6.0/extern_libs/ffmpeg/libavformat/libavformat.a] Error 2
       > make[2]: Leaving directory '/build/gimp-gap-2.6.0/extern_libs'
       > make[1]: *** [Makefile:331: all-recursive] Error 1
       > make[1]: Leaving directory '/build/gimp-gap-2.6.0'
       > make: *** [Makefile:270: all] Error 2
       For full logs, run 'nix log /nix/store/3rzl6mwdk8w06pivfabzk8hkv4l666lq-gimp-plugin-gap-2.6.0.drv'.
error: 1 dependencies of derivation '/nix/store/3hzlr2rk68ljsdb9whbhl0m09fc62dgy-gimp-with-plugins-2.10.36.drv' failed to build

Additional context
Looks like there was a patch already for this mentioned here on the Arch forums available at https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/effadce6c756247ea8bae32dc13bb3e6f464f0eb.
Notify maintainers
@jtojnar
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
# nix-shell -p nix-info --run "nix-info -m"
these 5 paths will be fetched (0.68 MiB download, 9.97 MiB unpacked):
  /nix/store/8ja6nib32kv3h9z6jwlh95b5ayma7wfx-file-5.45
  /nix/store/zwkzkw313x6vmd9683h11rqaawyysz1s-gnu-config-2023-09-19
  /nix/store/w0q0c4jham4h0cbvi3ygydl6hrcmzn6x-gnumake-4.4.1
  /nix/store/3qnm3nwjajgqa771dmi2dnwxrw0kzq5m-stdenv-linux
  /nix/store/hcrhrs1mmm2q5a3rzd6xwypqgkpm13vx-update-autotools-gnu-config-scripts-hook
copying path '/nix/store/zwkzkw313x6vmd9683h11rqaawyysz1s-gnu-config-2023-09-19' from 'https://cache.nixos.org'...
copying path '/nix/store/8ja6nib32kv3h9z6jwlh95b5ayma7wfx-file-5.45' from 'https://cache.nixos.org'...
copying path '/nix/store/w0q0c4jham4h0cbvi3ygydl6hrcmzn6x-gnumake-4.4.1' from 'https://cache.nixos.org'...
copying path '/nix/store/hcrhrs1mmm2q5a3rzd6xwypqgkpm13vx-update-autotools-gnu-config-scripts-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/3qnm3nwjajgqa771dmi2dnwxrw0kzq5m-stdenv-linux' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.7.7, NixOS, 24.05 (Uakari), 24.05.20240306.9df3e30`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/gig8j85kj7ybjy3ksn6k3aich8j2k59y-source`

Add a :+1: reaction to issues you find important.

Yuck, we should not allow vendoring ffmpeg. We should probably --disable-libavformat like Fedora was doing.
Or maybe just remove gap since it is dead upstream and will likely break with upcoming GIMP 3.

Looks like #294707 might be related...

Duplicate of #294707


Crash when Android-specific classes are used as top-level val

We are trying to use ComposablePreviewScanner with Paparazzi.
We have some components that use Android-specific classes in it, and the scanner crashes when scanning these classes.
Example 1
private val SomePath = android.graphics.Path().apply { ... }

The scanner crashes with
java.lang.UnsatisfiedLinkError: 'long android.graphics.Path.nInit()'
	at android.graphics.Path.nInit(Native Method)
	at android.graphics.Path.<init>(Path.java:51)
	at mypackage.SomeComponentKt.<clinit>

Example 2
private val Typeface = android.graphics.Typeface.create("sans-serif-medium", Typeface.NORMAL)

The scanner crashes with
java.lang.NullPointerException: Cannot invoke "java.util.Map.get(Object)" because "android.graphics.Typeface.sSystemFontMap" is null
	at android.graphics.Typeface.getSystemDefaultTypeface(Typeface.java:1216)
	at android.graphics.Typeface.create_Original(Typeface.java:899)
	at android.graphics.Typeface_Delegate.create(Typeface_Delegate.java:109)
	at android.graphics.Typeface.create(Typeface.java:899)
	at mypackage.SomeComponentKt.<clinit>

After Paparazzi is initialized (when using Paparazzi as the test rule), the crash doesn't happen, but the preview list need to be generated before the test rule kicks in.
We can use something like lazy as a workaround, but I'm wondering if there's some other way that doesn't require code change.

I believe it might work without changing those global vals if you use a ParameterizedRunner instead of the TestParameterInjector.
That is explained in the Roborazzi section. The setup the same, but use ParameterizedTestRunner instead of RobolectricParameterizedTest.
So only the test code would need changes
I’ll give it a try tonight and report back

I believe it might work without changing those global vals if you use ParameterizedRunner instead of the TestParameterInjector.
How to set it up is explained in the Roborazzi section. The setup the same, but use ParameterizedTestRunner instead of RobolectricParameterizedTest.
So only the test code would need changes
I’ll give it a try tonight and report back

Looks like using Parameterized instead of TestParameterInjector makes no difference.
The issue seems to be related to the way Paparazzi download android resources, which seems to interfere somehow with ComposablePreviewScanner, so my best bet is that you'll have to resort to one of the approaches I mentioned previously

@mxalbert1996
After checking ComposablePreviewScanner code I’ve understood where the problem lies (has to do with Class.forName()) and I have a couple of ideas on how to solve it without you needing to change the problematic vals that access android classes.
I’ll try to publish a new version ComposablePreviewScanner 0.3.1 with a fix for this issue next week

@mxalbert1996 should be fixed in 0.3.2 😊


Rate limiting

Coverage remained the same at 37.839% when pulling 751146c62f7a76b00a7a2c3479ee77710729e557 on subhajitdatta:rate_limiting into a7bfc680855db2714b4119fcad8ce08bfe73ea39 on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling e9f3f1337b74a4d37560e27e03f932543504f14c on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling e9f3f1337b74a4d37560e27e03f932543504f14c on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling e9f3f1337b74a4d37560e27e03f932543504f14c on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling e9f3f1337b74a4d37560e27e03f932543504f14c on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 6cdb54024ac416ca515648486417e1d29d7ef5fc on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 6cdb54024ac416ca515648486417e1d29d7ef5fc on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling a9a5b6f25e08c3e841dacd2f9b6512adc5de9e9d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling a9a5b6f25e08c3e841dacd2f9b6512adc5de9e9d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling a9a5b6f25e08c3e841dacd2f9b6512adc5de9e9d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling a9a5b6f25e08c3e841dacd2f9b6512adc5de9e9d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 831422a5a0ee1f0efb9540ea07a6fc107fb028fe on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 0dd11b8da195543e207382a9ec71a6cd535d4685 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 0dd11b8da195543e207382a9ec71a6cd535d4685 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling c6b3dcbce379b49f134d667c583d0648acb4b4b4 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 867a988e70d9ac4dc34b1eaf0f9dd63e0583a10b on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 867a988e70d9ac4dc34b1eaf0f9dd63e0583a10b on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 867a988e70d9ac4dc34b1eaf0f9dd63e0583a10b on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 867a988e70d9ac4dc34b1eaf0f9dd63e0583a10b on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 8be88f3479bcfd549f4857162606da44e5272596 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 8be88f3479bcfd549f4857162606da44e5272596 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 8be88f3479bcfd549f4857162606da44e5272596 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 8be88f3479bcfd549f4857162606da44e5272596 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 6e5f63bdb73322e4ffb53da1b1feab48b42b1c43 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling f706ffe29da9537f3f3c4afff6a9ce1feac662b1 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 9d88be37bcd8862b0d06cac2f8f3e37811250bfc on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 9d88be37bcd8862b0d06cac2f8f3e37811250bfc on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 167122fb7d971aea2cfc7734865c9d5f9c86612d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 167122fb7d971aea2cfc7734865c9d5f9c86612d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 167122fb7d971aea2cfc7734865c9d5f9c86612d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 167122fb7d971aea2cfc7734865c9d5f9c86612d on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 60b86b98a2b636800a24e71692418310144eee84 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 60b86b98a2b636800a24e71692418310144eee84 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.7%) to 39.737% when pulling 60b86b98a2b636800a24e71692418310144eee84 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling 9926a8501228164c313db5666f99a81173837765 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling 9926a8501228164c313db5666f99a81173837765 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling 9926a8501228164c313db5666f99a81173837765 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.788% when pulling 9926a8501228164c313db5666f99a81173837765 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.767% when pulling cc3f07b4b4e8cc558b2bfefd179f0a4d226dc59b on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-0.6%) to 39.767% when pulling cc3f07b4b4e8cc558b2bfefd179f0a4d226dc59b on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling 24f3bc63f1a0adb6fe14e2b6220956b627fe732e on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.09%) to 39.301% when pulling e111d75094caf1a8d574ebba8c7873b34cfd703f on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.09%) to 39.301% when pulling e111d75094caf1a8d574ebba8c7873b34cfd703f on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.09%) to 39.301% when pulling e111d75094caf1a8d574ebba8c7873b34cfd703f on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.09%) to 39.301% when pulling 6cff79a2c4c9c2f5f349abff812c23cdff7d26c1 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.09%) to 39.301% when pulling 6cff79a2c4c9c2f5f349abff812c23cdff7d26c1 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling d391d3f8ed32c09ef143a436c2e5fc9c2c0cd460 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling e160e5a2f03a2fdd1f44318de1c8f1e7cbc6dc28 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling fbdfc455376c561c0d90cace24fbe049901b70e9 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling a91506c627e0d38842fa158d1aa94318d8a688bf on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling a91506c627e0d38842fa158d1aa94318d8a688bf on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling c1ed670a065058e8a8958eca24e243576a5229e5 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling c1ed670a065058e8a8958eca24e243576a5229e5 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling 364813f0e6b33701c079be1c1d6d691e3886227a on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling 42c44ede6e3ff3a809f9fc4693739c520a7bc48e on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.1%) to 39.251% when pulling 42c44ede6e3ff3a809f9fc4693739c520a7bc48e on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.2%) to 39.193% when pulling 1e2a9152c08a6cae9216315994ae932ecef5d011 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.2%) to 39.193% when pulling 1e2a9152c08a6cae9216315994ae932ecef5d011 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.2%) to 39.143% when pulling 5a0ae7525b7ff9e76e67e36416c6f10cc93303f4 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.2%) to 39.143% when pulling 0b3d3b57aadfb087f3b70a6e12920ae03011c6b9 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.2%) to 39.143% when pulling 0b3d3b57aadfb087f3b70a6e12920ae03011c6b9 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-1.2%) to 39.143% when pulling 0b3d3b57aadfb087f3b70a6e12920ae03011c6b9 on subhajitdatta:rate_limiting into f358178073352bfc63606dc22b66e859860e7cdc on jabong:master.

Coverage decreased (-26.3%) to 14.139% when pulling 69de238edea7d962d4b41ba36dce56340d6b1a37 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-26.3%) to 14.135% when pulling eace83ec529d5d734d90cb01fbfab66502cf46d7 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-26.3%) to 14.135% when pulling c0c1ea5b9c9de3ecbff44c8ce542dfbb9aa65cd8 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-1.5%) to 38.932% when pulling 5fe22c012a1d6a8c97ecefd2b1bb7069c1a40696 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-1.5%) to 38.932% when pulling 28a4bafa491d2a2a71181eebcb81e888b4156686 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-24.4%) to 15.948% when pulling bd178d705e04849aeb28efb79ef7dde33ce8f669 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-24.4%) to 15.948% when pulling bd178d705e04849aeb28efb79ef7dde33ce8f669 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.2%) to 40.572% when pulling 38f51d16f7adeb5fe93869d132271864d8dce620 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.5%) to 40.863% when pulling c44f5588c738c29edffb60dd55186bdad95c033b on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.5%) to 40.863% when pulling c44f5588c738c29edffb60dd55186bdad95c033b on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.5%) to 40.863% when pulling c44f5588c738c29edffb60dd55186bdad95c033b on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 031822e50f39f9ff786e9645a4f946e193cd4682 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 031822e50f39f9ff786e9645a4f946e193cd4682 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 85316c5f53758b194d98b7735dfc7c6353747e05 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 85316c5f53758b194d98b7735dfc7c6353747e05 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 85316c5f53758b194d98b7735dfc7c6353747e05 on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-24.4%) to 15.948% when pulling 5307151d49199eefe114f6311095dc602dc21d9b on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 7b47da902ab4854d328ea0dd449b1b5d644b411a on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.3%) to 40.717% when pulling 833bf0d528222fb77352d149213716b4d60a3bff on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-24.7%) to 15.655% when pulling f03a963f89a17754e3a08bcad980311215e8980d on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-24.7%) to 15.655% when pulling f03a963f89a17754e3a08bcad980311215e8980d on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-8.1%) to 32.285% when pulling 79e658e13840c1e0a4e65d63913a8f40d5c0f8ed on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-8.1%) to 32.285% when pulling 79e658e13840c1e0a4e65d63913a8f40d5c0f8ed on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-8.1%) to 32.285% when pulling 79e658e13840c1e0a4e65d63913a8f40d5c0f8ed on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage decreased (-8.1%) to 32.285% when pulling 79e658e13840c1e0a4e65d63913a8f40d5c0f8ed on subhajitdatta:rate_limiting into 93dd8fd4872bc700c123ab329c6b322b8cf41e0b on jabong:master.

Coverage increased (+0.8%) to 32.259% when pulling b40441df34190feeafb1d7700ae3991a4c4fd7b1 on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+0.8%) to 32.259% when pulling b40441df34190feeafb1d7700ae3991a4c4fd7b1 on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+0.8%) to 32.259% when pulling b40441df34190feeafb1d7700ae3991a4c4fd7b1 on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+0.8%) to 32.259% when pulling b40441df34190feeafb1d7700ae3991a4c4fd7b1 on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+0.9%) to 32.297% when pulling fc7dc5be76224bdb1a1c7dadee04af7b34d7f980 on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+0.8%) to 32.259% when pulling 92b7c1721de02a4a0d0ce8f2f29883901c7ec8bb on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+0.8%) to 32.259% when pulling 92b7c1721de02a4a0d0ce8f2f29883901c7ec8bb on subhajitdatta:rate_limiting into 77659e2de99ca43eb130563be5c3499e20d4e1c4 on jabong:master.

Coverage increased (+1.2%) to 49.05% when pulling 5864f1deb471305fcd1c2b3cb90cb6bd141ef28b on subhajitdatta:rate_limiting into fee16ff6985a3b28f5bd0b5ba94940f1b79d9aba on jabong:master.

Coverage increased (+1.2%) to 49.05% when pulling 5864f1deb471305fcd1c2b3cb90cb6bd141ef28b on subhajitdatta:rate_limiting into fee16ff6985a3b28f5bd0b5ba94940f1b79d9aba on jabong:master.

Coverage increased (+1.2%) to 49.05% when pulling ee4ec6c73379183b85d5bbd8886338ecd45ea565 on subhajitdatta:rate_limiting into fee16ff6985a3b28f5bd0b5ba94940f1b79d9aba on jabong:master.

Coverage increased (+1.2%) to 49.05% when pulling ee4ec6c73379183b85d5bbd8886338ecd45ea565 on subhajitdatta:rate_limiting into fee16ff6985a3b28f5bd0b5ba94940f1b79d9aba on jabong:master.


Adding signatures to the transaction incorrectly updates the signed date

Description
If I click to add signatures, then click cancel, it goes back to history, but the signed date updates to now.
Steps to reproduce
The signed date should not update to now after cancelling.
Additional context
No response
Hedera network
other
Version
v0.10.2
Operating system
No response

not reproducible


Replace external media player with go native version

This PR will replace the external media player "mplayer" that is used to play downloaded tts files with a go native player. This has two advantages:

Easy setup. Just two additional go packages are needed instead of having to setup the media player and add it to the path var.
Reduced latency. Audio files will play with no noticeable delay as no external program need to be executed before the playback starts.

Hi! Thank you for PR. I'm pushed the handler pattern for audio player interface. Please look it and send a new pull request with this solution.
Thank you very much.

Solved at other PR:
https://github.com/hegedustibor/htgo-tts/pull/11
Thank you!


Add support for String Accessors to the C++ engine builder

Add support for String Accessors to the C++ engine builder
Introduces a C++ StringAccessor interface and method to convert to an envoy_string_accessor.
Minor cleanup of key_value_store handling in engine_builder.cc
Part of: #2498
Risk Level: Low
Testing: New unit tests
Docs Changes: N/A
Release Notes: Updated version_history.rst

/assign @alyssawilk

/assign @Augustyniak


BZ-63139: endless loop in apr_crypto_openssl.dll

See https://bz.apache.org/bugzilla/show_bug.cgi?id=63139
When building Subversion with apr-util 1.6.1 and OpenSSL 1.1.1a on Windows the crypto-test.exe test ends in an endless loop.
Cause: OPENSSL_malloc_init() is called without preceding SSL_library_init();
Analysis of the bug: https://github.com/nono303/win-svn/issues/3
Comparable report for Serf in the OpenSSL issues:
https://github.com/openssl/openssl/issues/2865

@wrowe Can you take a look at this PR?

Or at the bugzilla report


Chronograf: Set Template variables from the URL

https://github.com/influxdata/chronograf/issues/2934
integration tests with more details: https://github.com/influxdata/chronograf/issues/3779

Can set from the URL:

Template variables
Time ranges (upper and lower)
Zoomed time ranges (upper and lower)


Refactor accessibility providers into better separated model

Description of the new feature/enhancement
ScreenInfoUiaProvider and UiaTextRange are in a shared namespace now. PR #2083 did a bit of hacking to get them to work in Windows Terminal. One big example of this is making the HWND optional.
The CORRECT approach should be to do some kind of inheritance model where the ConHost accessibility model uses an HWND and the Windows Terminal accessibility model uses its new method.
For the HWND issue specifically, it might be worth doing this alongside #2103

Another one:
WindowUiaProviderBase pUiaParent shouldn't be nullable in ScreenInfoUiaProvider


IRR/XIRR functions?

Describe the problem to be solved
I just discovered grist, and it looks absolutely amazing -- kudos to all of you for such a fantastic tool.
While trying to find use cases for it in my personal life, one gap I found was the lack of IRR/XIRR (internal rate of return) functions.  Not sure if this would be something that is easy or hard or even possible, but thought I'd mention it.
Thanks again for a very nice and easy to use product.
Describe the solution you would like
The IRR and XIRR functions in XLS or LibreOffice take a column of numbers (at least one positive and one negative, the others can be whichever) and an equal sized column of dates, and computes a "rate of return".  I apologise I'm not that familiar with the exact formula used behind the scenes of these functions.
Edited to add: LibreOffice (and Excel I assume) have a lot more financial functions.  IRR/XIRR happen to be the only ones I care about, but there may be others that are important in general.

I'd say this relates to #35 (Support data science libraries). If that were available, numpy contains the irr function, and there are other libraries that may offer more, e.g. pyxirr.

thanks, though these functions are more properly "financial" functions -- but maybe that's just semantics.


conhost.exe --headless doesn't exit with the child process's exit code.

Windows Terminal version
1.19.10821.0
Windows build number
10.0.22621.3447
Other Software
No response
Steps to reproduce

From a command prompt, run start /wait conhost.exe --headless powershell.exe -Command "exit 1" or start /wait conhost.exe --headless cmd.exe /c "exit 1"
Check the resulting exit code with echo %errorlevel%.

Without routing the above through conhost.exe --headless, %errorlevel% contains the process's exit code as expected.
Expected Behavior
C:\Users\mjr40>start /wait conhost.exe --headless cmd.exe /c "exit 15"
C:\Users\mjr40>echo %errorlevel%
15
C:\Users\mjr40>
Actual Behavior
C:\Users\mjr40>start /wait conhost.exe --headless cmd.exe /c "exit 15"
C:\Users\mjr40>echo %errorlevel%
0
C:\Users\mjr40>

Nope, it doesn't. --headless is only there to support ConPty. I don't think conhost powershell -Command "exit 1" would set %errorlevel% either.

Is there any reason why it couldn't though? I don't know if I'm looking in the right spot, but on this line is where the lpProcessInformation pointer is passed through: https://github.com/microsoft/terminal/blob/a5835b01b1607bfac1141f0cd4ce9839f260a91f/src/tools/vtpipeterm/VtConsole.cpp#L311
Wouldn't it just be a matter of adding the following (or something similar) after it?
DWORD exitcode = 0;
WaitForSingleObject(_piPty.hProcess, INFINITE);
bool result = GetExitCodeProcess(_piPty.hProcess, &exitCode);

Is there any reason why it couldn't though

That's complicated. Technically, multiple command-line apps can all attach to the same console. And they can do so in a way that's not necessarily a "tree" of processes. There could be multiple top-level things attached to the console. In that case, who's exit code should be returned? If the first thing you spawned exits, but there's still something else attached to the console, should we exit with the first process's exit code (terminating the other process when the console goes away)?

Maybe we should take a step back here - what are you trying to accomplish? conhost --headless is barely documented. It's almost certainly not what you want to use, for whatever you're trying to accomplish.

That's complicated. Technically, multiple command-line apps can all attach to the same console. And they can do so in a way that's not necessarily a "tree" of processes. There could be multiple top-level things attached to the console. In that case, who's exit code should be returned? If the first thing you spawned exits, but there's still something else attached to the console, should we exit with the first process's exit code (terminating the other process when the console goes away)?
That's all valid information. I must admit I don't have a deep understanding about how the console host works. I guess if it was viable then it'd have been implemented.

Maybe we should take a step back here - what are you trying to accomplish? conhost --headless is barely documented. It's almost certainly not what you want to use, for whatever you're trying to accomplish.
I have a number of scripted applications within Microsoft Intune that execute within the user's context. Tickets get raised frequently regarding the console window blips that occur from this and I'm wanting to mask out the window from appearing entirely, but its crucial I get the exit code returned so Intune can pick it up.

People have done this via vbscript in the past, but that's deprecated and on the way out. I was hoping conhost.exe --headless would be a digitally signed, valid way to achieve my requirements without having to compile my own executable to hide the console window.

People have done this via vbscript in the past, but that's deprecated and on the way out. I was hoping conhost.exe --headless would be a digitally signed, valid way to achieve my requirements without having to compile my own executable to hide the console window.

Can you use another scripting language that has signed executables, such as Python? For example: pyw -c "import sys, subprocess; sys.exit(subprocess.run('cmd /c \"exit 15\"', creationflags =subprocess.CREATE_NO_WINDOW).returncode)". "pyw.exe" is the launcher to execute non-console "pythonw.exe", which by default will be the highest version installed, regardless of PATH. It proxies the exit code of the launched "pythonw.exe" process, which in this case proxies the exit code of the process spawned via subprocess.run().
Note, however, that if either "pythonw.exe" or "pyw.exe" is forcibly terminated or crashes, the exit code will be unrelated to the command that's executed via subprocess.run(). The same would apply to any launcher because launchers on Windows have to spawn a child process. That's because the Windows API doesn't support an operation like POSIX exec(), which replaces the current process image.

That's complicated. Technically, multiple command-line apps can all attach to the same console. And they can do so in a way that's not necessarily a "tree" of processes. There could be multiple top-level things attached to the console. In that case, who's exit code should be returned? If the first thing you spawned exits, but there's still something else attached to the console, should we exit with the first process's exit code (terminating the other process when the console goes away)?

If a classic console session has a window, the window pretends to be owned by the lead attached process (it's really owned by "conhost.exe"), which is at the head of the queue of attached processes. If that process exits, the next process in the list is promoted as the reported owner, according to the order of the result from GetConsoleProcessList(&list, count). The ID of the process that effectively owns the console window is returned by GetWindowThreadProcessId(GetConsoleWindow(), &processId). With a handle for this process, one can wait for it to exit and get the exit code via GetExitCodeProcess(hProcess, &exitCode).
For reasonable consistency, if "conhost.exe" proxies an exit code (and that's a big if), I'd expect it to be that of the last reported owner of the console window. Normally that would be the last process attached to the console before it was destroyed. However, if the console session is forcibly ended by closing the window, I'd expect it to use the exit code of the process that was the effective owner of the console window at closing time. I'd expect a --headless session to be consistent with this, with regard to the order of the result from GetConsoleProcessList(&list, count).

Can you use another scripting language that has signed executables, such as Python? For example: pyw -c "import sys, subprocess; sys.exit(subprocess.run('cmd /c "exit 15"', creationflags =subprocess.CREATE_NO_WINDOW).returncode)". "pyw.exe" is the launcher to execute non-console "pythonw.exe", which by default will be the highest version installed, regardless of PATH. It proxies the exit code of the launched "pythonw.exe" process, which in this case proxies the exit code of the process spawned via subprocess.run().

Note, however, that if either "pythonw.exe" or "pyw.exe" is forcibly terminated or crashes, the exit code will be unrelated to the command that's executed via subprocess.run(). The same would apply to any launcher because launchers on Windows have to spawn a child process. That's because the Windows API doesn't support an operation like POSIX exec(), which replaces the current process image.

I could certainly do that and that approach is something I hadn't considered, however it does introduce a dependency into my system that I'd rather avoid if possible. I thought I'd broach the topic here, not with any particular expectations but rather just to see if its within the realm of possibility.
I'm led to believe this PR might help with this problem in the future though? https://github.com/microsoft/terminal/pull/7337. It's cross-referenced on an ongoing PowerShell issue here: https://github.com/PowerShell/PowerShell/issues/3028,

Yes, thanks to #7337 in the upcoming Windows versions later this year, PowerShell will be able to completely prevent a window from being created.

Sounds like this will be my best bet, but I'll investigate that Python option also. Thank for to everyone who took the time to respond to this request, it's been much appreciated!


LibPD on macOS for Unity!

This is the only libPD setup for Unity that I've had work on mac OS. I just setup a simple hello world system using all of the sends and am so excited for what can be done with this!
Thank you for the excellent write-up and releasing this!

Thanks!!!!


Editing cells directly

Is there a way to make it possible to edit a cell directly using flask-admin?  I'm looking for something like this.  Thanks!

class MyModelView(BaseModelView):
    column_editable_list = ('name', 'last_name')

and then, name and last_name will be text fields editable in the list view

thanks!


Clean up evaluated.rs with macros

@KyGost Wooow, this is really great, you even merged AstValue functions!

rebased

Hmmm... Not sure how I feel about the way I've done CAST stuffs


trace: Document relation to golang.org/x/net/trace

Since golang.org/x/net/trace is an existing mechanism which users from other cloud platforms might already know and use, it seems useful to establish or at least document any intended or existing relationship.
The following questions should be answered:

How do I send my traces from golang.org/x/net/trace to cloud.google.com/go/trace?
If the above isn't possible: Given I did use  golang.org/x/net/trace in my application, how do I convert my code? (example needed)
Can I use both mechanisms in the same program? Do they interfere somehow?

I think we also need to answer a more fundamental question: Why don't the trace package export an x/net/trace.Trace implementation given that x/net/trace is widely used?

This package has been obsoleted by  go.opencensus.io/trace.


Easy way to turn Error::NotFound into an Option

Wishlist item.
In my Rust code I very often find myself doing:
fn get_thing() -> Result<Option<Thing>> {
    let res = thing.filter(something)
        .select(stuff)
        .load::<Thing>(connection)?;
    match res {
       Ok(thing) => Ok(Some(thing)),
       Err(diesel::result::Error::NotFound) => Ok(None),
       Err(e) => Err(e)
}

This tends to happen when the absence of a Thing is perfectly valid, and we should just, say, create a new Thing from defaults, or do nothing, or even just report a different sort of error (which might be recoverable) than, say, a DatabaseError or DeserializationError (which probably isn't).
Is this common enough for anyone else that it's worth making a shortcut combinator?  I'll happily make a PR for it.

You can call .optional(). We call this out in the documentation of every method that can return NotFound (which is basically just .get_result and .first

My mistake for not seeing it then, thanks!


Ability to enter a players' claim while being banned.

When using the /sit command from Gsit next to a claim while being banned from the claim, and standing back up. There is a chance that you will be inside the claim, even though you're banned. Once you're in there isn't any check anymore, so you can just do whatever you fancy.
Besides the above problem, it's also possible to break Minecarts inside a claim where you don't have trust. It looks like the Minecarts bypass all 'Allowed Operations'.

Could you attach a video to demonstrate your first issue, making sure you have been banned from the claim?
Please create a separate issue for your second, unrelated issue.

Please have a look at this video;
It took a couple of tries, but the user 'Pink_Punda' has been banned from Elinaatjes claim but still was able to enter.
It seems to be working when crouching really close to the claims' edge and than sitting, it will put the player inside the claim.


Script after caching becomes broken

I used a new minifier (esbuild) instead of a tercer and encountered an unusual bug in production. Unfortunately I don't have an exact replay script, but here is the data I got while debugging.
The terser generates the following code with brackets:
(0).toFixed(n)

This code always works well.
Esbild generates the following code with space:
0 .toFixed(n)

He also works well.
However, it is in production that the page starts to crash after the page refresh (after the script is cached by the workbox). As I was able to figure out, the contents of the script before getting into the cache and after the workbox gets it from the cache differ by a couple of bytes. After research, I realized that in the script that pulls out the workbox, the line above turns into
0.toFixed(n)

which causes the script to crash (the removed space makes the code broken).
This looks like a code-breaking minification that no one has done. But I could not find who is responsible for it. I would be grateful for any advice.

Hi there,
Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:

For PRs, we closed everything that doesn't target the current v7 branch.
For Issues, we closed everything that was created before 2024.

Thanks, and we hope for your understanding!
The Workbox team


objdump: use -arch-name instead of -triple

infer the arch-name from the output of rustc --print cfg is more robust than
just using the target name for the -triple flag.
fixes #17
r? @rust-embedded/tools (anyone)
cc @danc86

ping @ryankurte @therealprof anyone of you up for reviewing this?

bors r=therealprof


Change SigningRequest.csr to a property

Instead of it being a text shown, provide a download link that serves the text in a file with the correct mime type

[ ] Change SigningRequest.csr to a property, that way there's no issues with keeping values in sync. We haven't released a version with the csr field, so changing the existing should be fine
[ ] Replace the field on the SigningRequest change form with a link to the download_csr action. That action should be a GET request.

This should be enough:
@property
def csr(self) -> CSR:
    return generate_csr(
        key_pem=self.private_key,
        common_name=self.common_name,
        organization_name=self.organization_name,
        locality=self.locality_name,
        state_or_province=self.state_or_province_name,
        country=self.country_name,
    )

Some things that will require attention:

Downloading CSRs in bulk via the admin action (in a ZIP file) is nice, however if it's too much work to update, removing it in favour of downloading them one-by-one is fine. I don't expect people to create 10 CSRs at once and drop them with their CA.
CSR download link, yes, but permission checks are crucial here - the download link should only be visible (and accessible) if you have change permissions on the signing request model.


Can we simplify time-based transitions?

Hi: I love your library and have a project that needs to instantiate multiple, independent state machines. For code cleanliness and to avoid global variables, I tried to subclass YA_FSM to encapsulate the shared settings, a la
class PulsarStateMachine : public YA_FSM {public: int pulsarTimeout = 100; ...}
and then I have a PulsarStateMachine::Setup() function that defines the states, actions, and transitions.
However, I'm getting stuck following your timed transition pattern from within that Setup() function, because the lambda doesn't know how to find the CurrentState()->timeout. Your recommended pattern is:
this->AddTransition(ON_STATE, OFF_STATE,  [](){return stateMachine.CurrentState()->timeout;} );
...but I'm wondering whether we could simplify by adding something to YA_FSM::Update() that directly checks _currentState->timeout; Is there a reason you implemented with lambdas that I'm overlooking or could we add an AddTimedTransition(FROM_STATE, TO_STATE) function and skip the complexity of lambdas and function pointers?
Thank you for humoring me, and apologies if I'm missing something subtle for why you designed it this way. I'm not super familiar with lambda syntax and after a day of fighting with various captures and compiler warnings, wondered if this might be a simpler solution.

P.S. Here's the line where I get compiler errors (https://github.com/mrisher/alien_escape/blob/refactor-pulsarFSM/src/matrixPulsarFsm.cpp#L13)
/home/mrisher/src/alien_escape/src/matrixPulsarFsm.cpp: In lambda function:
matrixPulsarFsm.cpp:13:63: error: 'this' was not captured for this lambda function
                                 { return YA_FSM::CurrentState()->timeout; });
                                                               ^
matrixPulsarFsm.cpp:13:63: error: cannot call member function 'FSM_State* YA_FSM::CurrentState()' without object
/home/mrisher/src/alien_escape/src/matrixPulsarFsm.cpp: In member function 'void MatrixPulsarFSM::Setup()':
/home/mrisher/src/alien_escape/src/matrixPulsarFsm.cpp:13:76: warning: invalid user-defined conversion from 'MatrixPulsarFSM::Setup()::<lambda()>' to 'condition_cb {aka bool (*)()}' [-fpermissive]
                                 { return YA_FSM::CurrentState()->timeout; });
                                                                            ^
/home/mrisher/src/alien_escape/src/matrixPulsarFsm.cpp:12:43: note: candidate is: MatrixPulsarFSM::Setup()::<lambda()>::operator void (*)()() const <near match>
   AddTransition(PULSAR_ON, PULSAR_OFF, []()
                                           ^
/home/mrisher/src/alien_escape/src/matrixPulsarFsm.cpp:12:43: note:   no known conversion from 'void (*)()' to 'condition_cb {aka bool (*)()}'
In file included from /home/mrisher/src/alien_escape/src/matrixPulsarFsm.h:4:0,
                 from /home/mrisher/src/alien_escape/src/matrixPulsarFsm.cpp:1:
/home/mrisher/src/libraries/YA_FSM/src/YA_FSM.h:73:11: note:   initializing argument 3 of 'uint8_t YA_FSM::AddTransition(uint8_t, uint8_t, condition_cb)'
  uint8_t  AddTransition(uint8_t inputState, uint8_t outputState, condition_cb condition);
           ^~~~~~~~~~~~~

Created a pull request: https://github.com/cotestatnt/YA_FSM/pull/5 #5

Hi @mrisher
I'm sorry for late reply, I was on vacation last week.
I am glad you are satisfied with this library, I have developed it mainly for my benefit and for this reason it is unfortunately not very well documented.
Regarding your request, it actually makes sense that if I define a maximum timeout time for the state, this then automatically go to the next one (according to the defined transitions) without the need to add a callback function or a dedicated variable.
However, I am not entirely convinced of the way in which you have implemented the functionality because I do not think there was a need to add dedicated property and method to the YA_FSM class.

I could simply check whether the time has expired

That's more or less what I did in the wokwi example I linked you to.
If a trigger variable or callback function is not defined, the transition will be triggered on timeout, but this condition is the "weakest" because it is evaluated first.
By default, now both the callback pointer and the variable pointer are == nullptr so, when they are assigned, the local _trigger bool variable will be overwritten regardless of the timeout state.
     bool _trigger = false;

     // If a max time was defined check if current state is on timeout
     if (_currentState->maxTime) {
       _currentState->timeout = millis() - _currentState->enterTime > _currentState->maxTime;
       // Trigger transition on timeout
       if (_currentState->timeout)
         _trigger = true;
     }

     // Trigger transition on callback function result if defined
     if (actualtr->Condition != nullptr)
       _trigger = actualtr->Condition();

     // Trigger transition on bool variable value == true
     if (actualtr->ConditionVar != nullptr)
       _trigger =  *(actualtr->ConditionVar);

Thinking about it better, maybe it would be the case that instead the timeout is a priority by putting the relative if statement as last position...
I'm not sure about it: after all, if I decide that a state must last for a maximum of XXX milliseconds, what is the point of binding the transition to an external condition if it arrives late?

state must last for a maximum of XXX milliseconds, what is the point of
binding the transition to an external condition
Agreed, that's how I was interpreting "Maximum" as well, so then the
sequence you have here makes sense to me (but if timeout sets
_trigger=true then we'd skip the condition checks). In pseudocode because
I'm on email

if (maxTime is set && timeout has occurred) then trigger;
else if (Condition callback returns true) then trigger;
else if (ConditionVar is true) then trigger;
/* else don't trigger */
I hadn't noticed the Wokwi link you shared, thank you for pointing it out.

Message ID: @.***>

I've updated the library as you suggest (if, else if). I'm going to close this issue if you agree.

Awesome, thanks! Really appreciate your work here.
On Wed, Aug 10, 2022, 6:55 AM Tolentino Cotesta @.***>
wrote:

Closed #4 https://github.com/cotestatnt/YA_FSM/issues/4 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/cotestatnt/YA_FSM/issues/4#event-7164094840, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABVHNULDE6QSRR3KIYHNR3VYOYELANCNFSM54GDZLMA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Getting images using id

Hi, I really like your project, and I'm using it to make a discord bot. And I noticed that on Max parks there is also an image (wow) but I noticed that image is following a weird structure:
image
https://avatars.worldcubeassociation.org/uploads/user/avatar/2012PARK03/1631071192.jpg
and I don't understand why there is<PHONE_NUMBER> at the end and i think you may know. I think it can be countered in the order the image is  uploaded. But I don't know how to get that with a code. And do you know?
Thanks

I think this is a randomly genereted id, but will need to check to be sure

ok, but are you 100% sure, because i looked at some profiles and they tend to be 15xxx or 16xxx ? and any idea how to extract them?

so i figured out a solution to use bs4 and scrape site and just ping me if you want code


feat(cors): Add a plugin to handle to handle CORS related requests

What this PR does / why we need it:
Add a plugin to handle to handle CORS(Cross-Origin Resource Sharing) related requests(via simple encapsulation of this go package https://github.com/rs/cors). All its Supported Options as follow:

set AllowedOrigins: a list of origins a cross-domain request can be executed from(for example the domain which hosts front-end pages is different from the back-end domain)
set AllowedMethods: A list of methods the client is allowed to use with cross-domain requests(for example: GET, POST, PATCH, DELETE)
set AllowOriginFunc func (origin string) bool: A custom function to validate the origin
set AllowOriginRequestFunc func (r *http.Request origin string) bool: A custom function to validate the origin
set AllowedHeaders []string: A list of non simple headers the client is allowed to use with cross-domain requests.
set ExposedHeaders []string: Indicates which headers are safe to expose to the API of a CORS API specification
set AllowCredentials bool: Indicates whether the request can include user credentials like cookies, HTTP authentication or client side SSL certificates.
MaxAge int: Indicates how long (in seconds) the results of a preflight request can be cached.
OptionsPassthrough bool: Instructs preflight to let other potential next handlers to process the OPTIONS method. Turn this on if your application handles OPTIONS.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @iawia002

Since the cors exposes some function fields to public, However due to we cannot add function as command flag, So we need to skip those function fields when nirvana is  calling the register fields methods registerFields.

related code
https://github.com/caicloud/nirvana/blob/98146ec4aa3cdbada6878d1f560494d15b4c8bf6/config/config.go#L333-L492
Code freeze questions

What causes this PR to not be merged before code freeze?
Why this PR is absolutely necessary for this version? Paste a screenshot of smoke testing docs if you could.

Error: Access to fetch at 'http://localhost:8080/apis/v1/messages?count=10' from origin 'http://localhost:8081' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

What's the effects after merging it?

support cross-domain request

add a kind field to struct configField
https://github.com/caicloud/nirvana/blob/98146ec4aa3cdbada6878d1f560494d15b4c8bf6/config/config.go#L154-L162

Is there anyway we can skip this to not affect the overall process?
Without this new field(kind), Is there a way to detect a pointer is function or not during registerFields?

Release note:

Introduce a new dependency https://github.com/rs/cors) into go.mod
Implement  implementing [http://www.w3.org/TR/cors/](Cross Origin Resource Sharing W3 specification) for Nirvana.

NONE

I think it would be more appropriate for us to make this a middleware, it would be simpler and easier to use (e.g. we can configure different rules on different API groups).

I think it would be more appropriate for us to make this a middleware, it would be simpler and easier to use (e.g. we can configure different rules on different API groups).

I think it would be more appropriate for us to make this a middleware, it would be simpler and easier to use (e.g. we can configure different rules on different API groups).

Okay. This plugin was defined to apply CORS policy to the root path.
I respect your approach very much. During the transition period, I temporarily use this PR in my projects.

I think it would be more appropriate for us to make this a middleware, it would be simpler and easier to use (e.g. we can configure different rules on different API groups).

Okay. This plugin was defined to apply CORS policy to the root path.
I respect your approach very much. During the transition period, I temporarily use this PR in my projects.


NEWS: add v3.0.7

/cc @heyitsanthony @xiang90
Anything else to backport?
##### Bug fixes

- [GH6253](https://github.com/coreos/etcd/pull/6253): discovery: reject IP address records in SRVGetCluster
- [GH6267](https://github.com/coreos/etcd/pull/6267): wal: fix CRC corruption on writes following write tears
- [GH6309](https://github.com/coreos/etcd/pull/6309): etcdserver: allow zero kv index for cluster upgrade
- [GH6310](https://github.com/coreos/etcd/pull/6310): wal: use page buffered writer for writing records

#6284 and #6269?

Ok just backported.

lgtm

@heyitsanthony Let's do release this afternoon. Hopefully we can include patches for quote-parsing bug in etcdctl.


Fix for "thrift used for two different module paths" issue.

This seems to have resolved the build issue. Fingers crossed it corrects CI as well.

Thanks, LGTM.


Minor fix to ensure virtual angles are returned in correct shape

Reference Issues/PRs

What does this implement/fix? Explain your changes
What testing did you do to verify the changes in this PR?
Pull Request Checklist

[ ] Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
[ ] Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
[ ] Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
[ ] Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
[ ] Checked for style issues by running black . and isort .

Codecov Report
Patch coverage: 39.95% and project coverage change: +3.66 :tada:

Comparison is base (8123f42) 40.27% compared to head (6c48878) 43.93%.

:exclamation: Current head 6c48878 differs from pull request most recent head fc7657e. Consider uploading reports for the commit fc7657e to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   40.27%   43.93%   +3.66%
==========================================
  Files          48      113      +65
  Lines        2811     7788    +4977
==========================================
+ Hits         1132     3422    +2290
- Misses       1679     4366    +2687

Impacted Files
Coverage Δ

graphein/ml/datasets/foldcomp_dataset.py
0.00% <0.00%> (ø)

graphein/ml/diffusion.py
0.00% <0.00%> (ø)

graphein/ml/metrics/__init__.py
0.00% <0.00%> (ø)

graphein/ml/metrics/gdt.py
0.00% <0.00%> (ø)

graphein/ml/metrics/tm_score.py
0.00% <0.00%> (ø)

graphein/ppi/graph_metadata.py
0.00% <0.00%> (ø)

graphein/ppi/visualisation.py
0.00% <0.00%> (ø)

graphein/protein/analysis.py
0.00% <0.00%> (ø)

graphein/protein/features/utils.py
27.77% <0.00%> (ø)

graphein/protein/folding_utils.py
0.00% <0.00%> (ø)

... and 95 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Rename ir_pb2 to ir_data

The IR classes are no longer based on a protobuf implementation. This makes that clear by migrating to a more neutral ir_data name. This will also help avoid tripping up static analysis that looks for protobuf-like things.
Part of #118.

FYI @robrussell


Problems with cheerio dependency version

We have detected that in some cases, the library reach a loop because css-select. This issue is already resolved on css-select. I suppose that if the library reference is update to take version 1.0 of cheerio the problem would be resolved.

Sorry for delay, this should be fixed in version 3.0.1
https://www.npmjs.com/package/url-metadata
Feel free to reopen if you need a backport to version 2.x.x.


Issue in downloading stock market data using yfinance

Hi All - I'm using the below code to pull the daily OHLCV data, but encountered the following ERROR. Any idea about the issue?
CODE:
stocks = ["TVSMOTOR.BO","SUNPHARMA.BO","KOTAKBANK.BO","RELIANCE.BO"]
year = 1
import datetime as dt
import yfinance as yf
import pandas as pd
start = dt.datetime.today()-dt.timedelta(365*year)
end = dt.datetime.today()
ohlcv_data = {}
for ticker in stocks:
print("Downloading for "+ticker)
ohlcv_data[ticker] = yf.download(ticker,start,end)
ERROR:
Downloading for TVSMOTOR.BO
Exception in thread Thread-8:
Traceback (most recent call last):
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connection.py", line 159, in _new_conn
conn = connection.create_connection(
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\util\connection.py", line 84, in create_connection
raise err
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\util\connection.py", line 74, in create_connection
sock.connect(sa)
TimeoutError: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connectionpool.py", line 670, in urlopen
httplib_response = self._make_request(
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connectionpool.py", line 381, in _make_request
self._validate_conn(conn)
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connectionpool.py", line 976, in _validate_conn
conn.connect()
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connection.py", line 308, in connect
conn = self._new_conn()
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connection.py", line 171, in _new_conn
raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPSConnection object at 0x0000016C0983C250>: Failed to establish a new connection: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Sougata\anaconda3\lib\site-packages\requests\adapters.py", line 439, in send
resp = conn.urlopen(
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\connectionpool.py", line 724, in urlopen
retries = retries.increment(
File "C:\Users\Sougata\anaconda3\lib\site-packages\urllib3\util\retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='query1.finance.yahoo.com', port=443): Max retries exceeded with url: /v8/finance/chart/TVSMOTOR.BO?period1=1589025263&period2=1620561263&interval=1d&includePrePost=False&events=div%2Csplits (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x0000016C0983C250>: Failed to establish a new connection: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Sougata\anaconda3\lib\threading.py", line 932, in _bootstrap_inner
self.run()
File "C:\Users\Sougata\anaconda3\lib\threading.py", line 870, in run
self._target(*self._args, **self.kwargs)
File "C:\Users\Sougata\anaconda3\lib\site-packages\multitasking_init.py", line 102, in _run_via_pool
return callee(*args, **kwargs)
File "C:\Users\Sougata\anaconda3\lib\site-packages\yfinance\multi.py", line 166, in _download_one_threaded
data = _download_one(ticker, start, end, auto_adjust, back_adjust,
File "C:\Users\Sougata\anaconda3\lib\site-packages\yfinance\multi.py", line 178, in _download_one
return Ticker(ticker).history(period=period, interval=interval,
File "C:\Users\Sougata\anaconda3\lib\site-packages\yfinance\base.py", line 151, in history
data = _requests.get(url=url, params=params, proxies=proxy)
File "C:\Users\Sougata\anaconda3\lib\site-packages\requests\api.py", line 76, in get
return request('get', url, params=params, **kwargs)
File "C:\Users\Sougata\anaconda3\lib\site-packages\requests\api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Users\Sougata\anaconda3\lib\site-packages\requests\sessions.py", line 530, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\Sougata\anaconda3\lib\site-packages\requests\sessions.py", line 643, in send
r = adapter.send(request, **kwargs)
File "C:\Users\Sougata\anaconda3\lib\site-packages\requests\adapters.py", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='query1.finance.yahoo.com', port=443): Max retries exceeded with url: /v8/finance/chart/TVSMOTOR.BO?period1=1589025263&period2=1620561263&interval=1d&includePrePost=False&events=div%2Csplits (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x0000016C0983C250>: Failed to establish a new connection: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond'))
Traceback (most recent call last):
File "", line 10, in
ohlcv_data[ticker] = yf.download(ticker,start,end)

I am having the same issue.  yf.Ticker() works, but not yf.download.  What's this about limiting the request rate with sleep?

If you are downloading lot of stocks in the loop then at the end of each loop put time.sleep(seconds) so the loop stops a little bit before downloading next stock


Toolbar design improvements

As the top toolbar gets crowded, I would take to take some time to improve the experience of it. Currently,

Too many items in the design view.
Discoverability issues have been brought up.

Marc has been working on this and will share his proposal today 6/25

Attached is the design for the toolbar in the Authoring canvas. We'll be applying a similar approach to the other pages.
https://www.figma.com/file/LlTlh5vXwq91zjGnFtrUUR6l/Composer-master-design-spec-UI-library?node-id=2968%3A27100


as-8080 and as-z80: document labels, variables, constants and macros inside if statement

What happens to label/variables/constant/macro inside if statement if it evaluates to false? Are the names taken in the environment? Example:
if 0
  label1: stax b
endif
label1: hlt

The if statement is evaluated to false. Is definition of label1 below allowed?

Current behavior: it is not possible. It yells an error:
if 0
  label1: stax b
endif
label1: hlt

results in:
Compiling started...
[Info   ] Intel 8080 Assembler, version 0.40
[Error  ] Compilation error: Label already defined: LABEL1
Compiling has finished.

I think the if statement is useful when a code parts can be eliminated or pulled-in if certain condition is met (e.g. useful for padding or based on feature inclusion/exclusion). In that cases we should make sure the code is compatible when pulled in. So in my opinion label redefinitions should not be allowed, just as it is not allowed now.


WIP: operations: preprocessing: Add new image preprocessing operations plugin

Also Fixes: #638

Looking great. Let me know when you're ready for review. (Sorry I still haven't been able to get that video chopped up, working on it at the moment)


Daikin climate resets temperature

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.65.3
Python release (python3 --version):
3.6.1
Component/platform:
climate.daikin
Description of problem:
Trying to set temperature to 28C. Then i turn it on on a mode (eg: heat), then try to change another parameter like fan speed, Temperature resets to 22C
Expected:
Temperature should not be randomly switched
Problem-relevant configuration.yaml entries and steps to reproduce:
climate:
  - platform: daikin
    host: <IP_ADDRESS>

set temperature to 28C
turn on heat
change fan speed
temperature resets

Traceback (if applicable):

Additional info:

Yes It also resets the mode to "auto" when you turn it off. Which is even bigger problem for me, since wife uses Official Daikin app, and then we get mode conflicts.

Hi, this is still an issue.

Yep still doesn't work as expected :(

Yes, I still have the same issue and I'm running the 0.70.1 version.

this is still an issue, problem is in the pydaikin library homeassistant uses. It needs to have all values passed in or it resets them to auto/22C, specifically the lines:
        if 'mode' in settings:
            # we are using an extra mode "off" to power off the unit
            if settings['mode'] == 'off':
                pow = '0'
                mode = human_to_daikin('mode', 'auto')

and
        if not temp.isdigit():
            temp = '22'

in appliance.py
I am going to fix it myself and report my findings. Also I've made it compatible with wifi controllers model BRP069B, which I have.
Does anyone know where the updated pydaikin repo is? I can't find it

https://bitbucket.org/mustang51/pydaikin but the owner responds very hard

Well that was much quicker than I thought.
To get it working with B model wifi controllers apply this diff to appliance.py
12d11
<                   , 'aircon/get_timer'
15d13
<                   , 'aircon/get_program'
20d17
<                   , 'aircon/get_scdltimer'

To fix the 22 degrees temperature change, apply this one too
202c199
<             temp = '22'
---
>             temp = self.get_resource('aircon/get_control_info')["stemp"]

@rofrantz I've seen that link. I'll try to send a PR and see what happens

I GOT THIS
When the object is created it finds and saves locally all of its parameters as self.values[foo], but never updates them on its own, nor saves them when calling .set() so if you call it without specifying all variables it will reset the other ones to what it read at initialization time
This diff will save the variables locally when you send a new command, but won't get the correct state if you change the aircon settings with your remote:
I have forked pydaikin on my account, get the fixed code on https://github.com/icovada/pydaikin/blob/master/pydaikin/appliance.py.
Fixes @Notrial 's problem too. No more setting on "auto" when it's turned off!

Great news @icovada . Finally someone is back on this :)

Anyone knows if I can use the new appliance.py on Hass.io somehow?

@icovada any response from the original developer? Is there a chance this will see an official release?
I can't get it to work with Hass.io :(

Good news guys, I've finally managed to get this working on Hass.io. I will upload a set of files that you have to unpack at the root of your custom_components folder in Hass.io.
All works as expected now :)
daikin.zip

Yes it works now! Thanks @Notrial !! Now it would be great include the fix in the official Hassio Release!

@Notrial Just to confirm; within your .zip did you change any other file than pydaikin appliance.py?

If I remember correctly both daikin.py in the root and in the climate folder were changed.

I'm trying to get my Daikin heatpump to work properly and this is the final step! I have just implemented the fix here in order to have hot and heat named correctly so that Home on iOS works properly.
However I also want to implement this fix for the degrees, and looking at the daikin.zip file it would overwrite the file I have just added in order to sort the hot and heat naming!
Has anybody successfully fixed both and if so what are the steps? If not, some direction would be really appreciated and then I can have a go.

Well, can't you merge the files yourself?

@icovada I can have a go but I'm not a coder and don't know what I would be breaking! Also didn't want to re-invent the wheel if it had already been done, as both fixes seem logical to implement together to make the Daikin devices work "properly". Will post back if I am successful.

@Notrial I have tried your zip and unfortunately it did not work for me - using a Daiken FTXS50LVMA. I installed all the files as instructed (removing my existing daikin.py which fixed hot/heat in in Home on iOS).
In my logs I get:
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/service.py", line 224, in _handle_service_platform_call
    await getattr(entity, func)(**data)
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/climate/daikin.py", line 232, in set_operation_mode
    self.set({ATTR_OPERATION_MODE: operation_mode})
  File "/config/custom_components/climate/daikin.py", line 184, in set
    self._api.device.set(values)
  File "/config/custom_components/pydaikin/appliance.py", line 165, in set
    fan   = current_val['f_rate']
KeyError: 'f_rate'

I'm not sure where to from here, would appreciate any advice or suggestions? My guess is that either 1/ I have done something wrong! or 2/ my device doesn't support f_rate but then I don't know why it would work before with the installed Daikin plugin.

Seems like your device does not support f_rate.
It worked before because the old code had an issue, which I fixed, where it didn't actually re-read the values from your aircon unit and would just keep using the defaults it had inside unless you set them when calling the program, which made it unusable with Home Assistant (which only sends one parameter per request, so if you changed fan speed and then fan direction it would set fan speed back to auto)

Hi @icovada I've done some more reading and experimenting and you are correct, my device does not support f_rate. This was a very interesting thread - many people also do not support f_rate - seems mainly Asia and Australasia.
I'm hoping there is a way to get the 22deg bug fixed without f_rate, but it looks outside of my ability. For me, I have never had fan speed or direction control so your use case is not relevant. For me, I just want to be able to choose a mode and set a temperature - and not have it default to 22deg!
Thanks for your work though.

Thanks for your quick response and changes. I did a quick test by replacing appliance.py in the zip file from @Notrial and get the following error:
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/service.py", line 224, in _handle_service_platform_call
    await getattr(entity, func)(**data)
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/climate/daikin.py", line 232, in set_operation_mode
    self.set({ATTR_OPERATION_MODE: operation_mode})
  File "/config/custom_components/climate/daikin.py", line 184, in set
    self._api.device.set(values)
  File "/config/custom_components/pydaikin/appliance.py", line 168, in set
    dir   = current_val['f_dir']
KeyError: 'f_dir'

At a guess my machine doesn't support f_dir? If so, is it possible to do a quick patch to ignore that as well?!
I did a check by going to http://[local_ip]/aircon/get_control_info and this is what I got ret=OK,pow=0,mode=7,adv=,stemp=22.0,shum=0,dt1=22.0,dt2=M,dt3=22.0,dt4=22.0,dt5=22.0,dt7=22.0,dh1=0,dh2=50,dh3=0,dh4=0,dh5=0,dh7=0,dhh=50,b_mode=7,b_stemp=22.0,b_shum=0,alert=255

Pffffft.
Try now

I made another minor fix after the “hot/heat” one, it regards speed and swing mode. You can find it at https://github.com/home-assistant/home-assistant/pull/18013
As soon as I can I will have a look at the latest post of this thread an try to merge everything together.

As soon as I can I will have a look at the latest post of this thread an try to merge everything together.

@rofrantz: When did the temperature set to 22 start to appear when changing modes? I thought that we kept state for the settings and just modified the "changes" but after reviewing the codes it does not seem so..

Since day 1 @fredrike because its inside daikin. What I mean is that the device has different temperature settings for each mode(hot, cold, etc).
This means that in order to fix it we need to fix it we need to take that into account.
To make my point take this sample response from Daikin:
ret=OK,pow=0,mode=7,adv=,stemp=22.0,shum=0,dt1=22.0,dt2=M,dt3=22.0,dt4=22.0,dt5=22.0,dt7=22.0,dh1=0,dh2=50,dh3=0,dh4=0,dh5=0,dh7=0,dhh=50,b_mode=7,b_stemp=22.0,b_shum=0,alert=255.
Dt1...dt7 represent the values for each mode.
PS: sorry i've let u guys down with the Daikin HA integration but i'm quite busy. Hope the above helps

Thank you for your response!
@icovada Is your changes incorporated into the discussion on bitbucket: https://bitbucket.org/mustang51/pydaikin/issues/4 ?
Let's hope that we can get Yari Adan to fix the issues in the backing library and just make a version bump on the module here.

I just read the entire conversation, but I need some clarification: did @Notrial managed to fix the 22 degrees issue on July 12th? Did he make modifications only on the .py files in HomeAssistant, or also in the pypy library?
I asked this just to better understand the actual situation, so I can focus on try fixes from someone else, or try to fix this on my own.

I did't fix it personally, I just found a way that it can be implemented in Hass.io as a custom component. @icovada fixed the original .py.

@MatteGary It seems like this version is fixing the 22 deg issue: https://github.com/icovada/pydaikin/blob/master/pydaikin/appliance.py
We "just" need to get it added to the original repo on bitbucket.

I've submitted two pull-request to the original repo on bitbucket now: https://bitbucket.org/mustang51/pydaikin/pull-requests/
Let's hope they get merged and that a new version can be pushed to pypi.

Had some trouble that I couldn't set f_rate and f_dir due to the fact that there where some parameters missing in the fan section. Looks like my controller (BRP069A45) only accepts queries with all parameters (pow, mode, temp, hum, fan, dir) being sent. Anyone who experienced the same?
    if "fan" in locals():
        _LOGGER.warning("Daikin supports fan.")
        self.values['f_rate'] = fan
        self.values['f_dir'] = dir
        self.values['en_hol'] = hol

        # Some custom logging.
        _LOGGER.warning("Daikin requested f_rate %s", fan)
        _LOGGER.warning("Daikin requested f_dir %s", dir)
        query_c = 'aircon/set_control_info?'
        query_c += ('pow=%s&mode=%s&stemp=%s&shum=%s&f_rate=%s&f_dir=%s'
                % (pow, mode, temp, hum, fan, dir))

        query_h = 'common/set_holiday?'
        query_h += ('en_hol=%s' % hol)

    else:
      _LOGGER.warning("Daikin doesn't support fan.")
      query_c = 'aircon/set_control_info?'
      query_c += ('pow=%s&mode=%s&stemp=%s&shum=%s'
              % (pow, mode, temp, hum))

`

@driesken I think that every daikin model need all the parameters set in the API call, but this should be managed by the python library... or not?

@MatteGary: the code I posted is just a little modification I've made to appliance.py. If a daikin supports fan (which in my case it does), it looks like the query_c variable is overwritten after the if-statement before the actual request is made (thus resulting in too few parameters)?
I'm setting climate.daikinap from within an automation.

Have a look at my pull request on bit bucket there is a fix for the wrong indentation issue..

The indentation is indeed fixed but the last query_c variable still overwrites the query_c that is constructed in the if "fan" in locals(): section (and thus sending to few parameters)?

@fredrike The indentation is indeed fixed but the last query_c variable still overwrites the query_c that is constructed in the if "fan" in locals(): section (and thus sending to few parameters)?

Yes! And as you can see is that fixed in my version too (it would be good if we could consolidate our changes).

@fredrike Sorry, looked over that pull request on my mobile. Thanks, keep up the good work!

I've submitted two pull-request to the original repo on bitbucket now: https://bitbucket.org/mustang51/pydaikin/pull-requests/
Let's hope they get merged and that a new version can be pushed to pypi.

Looks like the bitbucket updated about an hour ago. Would this be picked up by HA automatically?

@driesken, No but I'm on it :)

Can anyone describe the idea with en_hol how is it supposed to work?
Does Home Assistant have support for holiday mode?

@driesken,@charlietomo please verify that #18415 works for you with devices that does not support fan settings.

@fredrike Seems to be working! Thanks
Strange fact is that my automation to state "off" doesn't work any longer (however it did before). I can turn it off by clicking the climate entity however... Don't known if it's related.
    - service: climate.set_operation_mode       data_template:         entity_id: climate.daikinap70053         operation_mode: >           {% if is_state('input_select.ac_operation_mode', 'Cool') %}             cool           {% elif is_state('input_select.ac_operation_mode', 'Heat') %}             heat           {% elif is_state('input_select.ac_operation_mode', 'Autom') %}             auto           {% elif is_state('input_select.ac_operation_mode', 'Dry') %}             dry           {% elif is_state('input_select.ac_operation_mode', 'Fan') %}             fan_only           {% else %}             off           {% endif %}

Ok, I've made some more updates in the pydaikin library.
The new changes will set the temperature and humidity to the last setting for that mode. I.e. say that you have 22° for hot and 24° for cold, when you switch from hot to cold the temperature will be set to 24° too. (This is how the Daikin devices and applications works).
The issue is when controlling from the climate component in Home Assistant, then the temperature will change when you change mode (as you are only able to change one parameter at time there).


When writing file the date cell text(w) changed to epoch(v)

Hi, When i am reading file i have cell values like :
A34: { t: 'n', v: 42626, w: '9/13/16' },
and after some edition to workbook when i write back to  file it convert cell  like
A34: { t: 'n', v: 42626, w: '42626' },
The cell.w get replaced with cell.v , why?
I want back cell values like same as when reading after write.
Please help thanks.

When you read a file, it doesn't store the cell formats by default.  You have to set the option cellNF:true in the read call.  For example, in nodejs using XLSX.readFile:
var wb = XLSX.readFile(name_of_file, {cellNF:true});

Every cell will have a z field with the number format, and then you will see saving the file works.


Retained message is not sent for Subscribe to existing topic

Environment
EMQ Broker v2.1.2
Description
This relates to issue 352 (https://github.com/emqtt/emqttd/issues/352). It appears this issue is present again in v2.1.2.
If an MQTT Client Subscribes to a Topic (for which a subscription already exists in the Broker), then the Broker does not send the last Retained message for that topic.
According to MQTT-3.8.4-3, "If a Server receives a SUBSCRIBE Packet containing a Topic Filter that is identical to an existing Subscription’s Topic Filter then it MUST completely replace that existing Subscription with a new Subscription. The Topic Filter in the new Subscription will be identical to that in the previous Subscription, although its maximum QoS value could be different. Any existing retained messages matching the Topic Filter MUST be re-sent, but the flow of publications MUST NOT be interrupted"
The existing retained messages matching the Topic Filter are not being sent.
The workaround for me is to Unsubscribe from the topic before Subscribing. This effectively gets the last Retained message for that topic.
Output from Python program to recreate issue:
$ python test_subscribe_and_retained_msgs.py
testClientJDH
testClientJDH Connected with result code 0

Subscribe to topic: zm-waterlevel/testJDH
Success
Rx Water Level?

Unsubscribe first
Subscribe to topic: zm-waterlevel/testJDH
Success
Rx Water Level?
zm-waterlevel/testJDH 123

Subscribe to topic: zm-waterlevel/testJDH
Success
Rx Water Level?

Unsubscribe first
Subscribe to topic: zm-waterlevel/testJDH
Success
Rx Water Level?
zm-waterlevel/testJDH 123

@jhor511 Has fixed and released at v2.3.0

@jhor511 I close the issue first. Please install the v2.3.0 and verify it.


Update README.md

When looking for elmajs on google I could only find https://elmadev.github.io/elmajs/ so it was a bit difficult to find a link to the actual repository. So I suggest making the repo easily findable.

Sounds like a good idea. Though I'm unsure if this PR will build the docs as it does not increase the version.