MRG+2: Revise install docs

This is the first in a series of PRs to improve the documentation.  This PR targets the installation/setup docs.  Highlights:

converts the Install landing page to a full TOC of all the install pages

adds a "before you install" page to guide new users about which tools they need and an overview of what each tool does.

adds a dedicated page on freesurfer installation.

adds "next" links to the bottom of the main installation pages.  (for now I've avoided trying to hack the sphinx-bootstrap theme to generate these automatically, like the sphinx-readthedocs theme does, but I'm open to that possibility if there's general support for it.)

attempts to avoid "MNE" in favor of explicit reference to "MNE-C", "MNE-python", or "the MNE MATLAB toolbox".  When reference to all tools in general is needed, I use "the MNE suite of software tools" or similar.

re-orders advanced_setup page topics to follow what I'm guessing is most -> least frequently used topics (i.e., puts ipython/jupyter first).

describes miniconda alongside anaconda as a valid setup option.

overhauls the MNE-C install instructions (tightens up some parts, omits others, adds info about missing libxp6 and gfortran).

a few of minor changes outside the "installation/setup" docs that I noticed along the way:

index.rst: closing tag now matches opening tag
documentation.rst: reflow the source text
contributing.rst: make title more consistent with install pages.

cc #5883 (although this PR doesn't overlap with #5883 much, subsequent ones likely will).

artifacts: https://11145-1301584-gh.circle-artifacts.com/0/dev/getting_started.html

artifacts: https://11150-1301584-gh.circle-artifacts.com/0/dev/getting_started.html

@choldgraf you might be interested in the restructuring elements here

just a quick nitpick. Please write Python with a capital P

@agramfort do you want capital P also in "MNE-python"?  Or just for "Python" by itself?

Both

oops, should have googled [skip travis] and [skip appveyor] before pushing...

latest artifacts: https://11164-1301584-gh.circle-artifacts.com/0/dev/getting_started.html

latest artifacts: https://11166-1301584-gh.circle-artifacts.com/0/dev/getting_started.html
@larsoner I think I've addressed all your requests / suggestions, but happy to wait for feedback from @choldgraf or others.

this looks great. If I would make one tiny comment it's that it is not obvious how arrive at Getting Started when you land on documentation page.
what came out of our latest (aborted) doc sprint is that the top content in https://11166-1301584-gh.circle-artifacts.com/0/dev/documentation.html lacks clear visual highlights to say where to start, ie what is important what is not. I would try to limit the number of links, make the getting started link support obvious. What should be there for me is:
Getting started
Frequency asked questions
Getting help section
How to "Cite MNE"
What's new
could this also be part of the PR?

@agramfort  This PR only tries to deal with pages that fall under the "Install" link in the website header.  I agree that the Documentation landing page needs work.  My plan was to do that in a subsequent PR --- mostly because I think it will be a lot more work than the Install pages, and may take a couple iterations to get it right and make everyone happy.
That said, maybe on the Install landing page, the "getting started" heading text is misleading?  Would it be better to say "Installation - overview" or something like that?

ok fair enough to postpone this to the next PR.
I don't know exactly how to do it but seeing new users last week made me
realise it's not easy to know where to click first....

@agramfort @larsoner not sure what's causing the circleci failure (make html_dev-noplot succeeds locally)... it looks like a Qt problem, possibly a Qt version conflict (?).  I've pushed another commit to trigger rebuild, but if the problem doesn't fix itself I may need help tracking down what is wrong with the CircleCI recipe.

You need to rebase, it has been fixed in master but CircleCI does not build a merged version (anymore -- it used to, but our code stopped doing the merge properly at some point).

@larsoner @agramfort rebase and force-pushed worked.  Ready for merge.

thanks a lot @drammock !

I got late to the party. But this looks great, thx @drammock

@drammock what version of macOS did you use to test MNE-C and XQuartz?

@kambysese I don't have a Mac, that bit of info came from @larsoner.
On February 15, 2019 5:15:57 PM AKST, Kambiz Tavabi<EMAIL_ADDRESS>wrote:

@drammock what version of macOS did you use to test MNE-C and XQuartz?

@ktavabi those instructions worked for me on 10.13, but appear not to on Mojave (10.14).

I will check later on if I can try the the install instructions at,
https://mne-tools.github.io/dev/install_mne_c.html
on a 10.14 system.  I think I have 10.14 installed on an external
drive (which I do not have in front of me right now).

@drammock I just encountered this issue with matplotlib:3.0.2 {backend=MacOSX}

ImportError: Python is not installed as a framework. The Mac OS X backend will not be able to function correctly if Python is not installed as a framework. See the Python documentation for more information on installing Python as a framework on Mac OS X. Please either reinstall Python as a framework, or try one of the other backends. If you are using (Ana)Conda please install python.app and replace the use of 'python' with 'pythonw'. See 'Working with Matplotlib on OSX' in the Matplotlib FAQ for more information.

The fix is documented here. Maybe worth mentioning in the docs if still relevant.


Use common-utils 1.1 branch for OpenSearch 1.1

Description
Change to use the 1.1 branch of Common Utils in the 1.1 manifest file.
Issues Resolved
https://github.com/opensearch-project/common-utils/issues/64
PR (https://github.com/opensearch-project/common-utils/pull/65) with all the commits cherry picked from the main branch. We can keep this PR as an artifact.
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

PR Merged: https://github.com/opensearch-project/common-utils/pull/67

@VachaShah Can you also provide me with more context on the failure so that I can double check if the failure is addressed by this https://github.com/opensearch-project/common-utils/pull/67 PR.

@aditjind I think #410 was the issue. May be @peternied can elaborate?

I've updated the repro steps on https://github.com/opensearch-project/opensearch-build/issues/410, copied the reproduction steps into this PR for validation

To Reproduce

Flush maven local with rm -rf ~/.m2/
./bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --component common-utils --snapshot
ls .m2/repository/org/opensearch/common-utils/
Verify that the directory that is created is named X.X.X.X-SNAPSHOT and not X.X.X.X

I'd like to wait for #386 to get merged too so we can verify that this properly fails rn.

@aditjind could you please rebase this?

@aditjind could you please rebase this?

Well, CI did catch a bug!
https://github.com/opensearch-project/common-utils/pull/69 should fix it

I re-ran the checks after https://github.com/opensearch-project/common-utils/pull/69 and we're good to go.


_CONF_FORCE_HTTPS could not force from HTTP to HTTPS

Hi guys,
I installed this lib, but when I use SSL for my REDMINE and change option _CONF_FORCE_HTTPS to "true" then AJAX could not force to HTTPS.
Image for this problem: https://imgur.com/Tjj4uv0
Please fix this issue. Thank you for your hard-working.

Hello @tqvinh0510
Thank you for your message. Unfortunately this kind of issue is probably a misconfiguration of the server and the http to https redirection and even if the plugin call the URL with an https link, your server redirect it to an insecure version of the page.
You can inspect your network activity when you edit a field ( https://developers.google.com/web/tools/chrome-devtools/network ) to check how your server redirects requests.
You can also check this issue https://github.com/Ilogeek/redmine_issue_dynamic_edit/issues/35


Error: Cannot find module 'vue-template-compiler'

Laravel Mix Version: 4.0.14 (npm list --depth=0)
Node Version (node -v): v14.19.3
NPM Version (npm -v):  8.11.0
OS:   Windows 10 Pro

"laravel-mix": "^4.0.14",
Description:
Please guide me to fix this issue?

Can you provide your webpack.mix.js file?
webpack.mix.txt

My side I fixed the issue, After Install below Package, Please anyone explian Why we need to use this one. My front end is React, But I Install Vue template complier ?? may I know why?
    "resolve-url-loader": "^2.3.1",
    "vue-template-compiler": "^2.7.0"

And the
SET NODE_OPTIONS=--openssl-legacy-provider &&


Remove horizontal scroll

fixes #140
This PR removes the horizontal scroll bar form the home page.

We need horizontal scroll buddy! The website is supposed to have horizontal scroll
Read the README.md

I was assigned so I removed it @vansh-codes
issue #154

Sorry I misunderstood as you want to redesign the scrollbar
Can you please share the video proof of how it looks now after removing the horizontal scrollbar

https://github.com/user-attachments/assets/f781b580-b8b4-4d3e-94f8-c5cd3d24b8ec
Hey @vansh-codes here it is!

ok works! 👍


If same layer is used as both addressee and selection layer, PN is selecting adjacent additional features outside of the aoi

Repro steps:

Click Add to create a new notification list
Click Next and click Sketch
Select a drawing tool and draw an aoi
Notice that additional features are being selected that are outside of the aoi boundaries

@aparveen  We do query based on the geometry. Same query for sketch geom, search geom, buffer geom, and result features from use layer features geom. I could switch to use OIDs only when the addressee and use layer features layer are the same...otherwise it wouldn't make sense as we need the geom comparison.

We do query based on the geometry. Same query for sketch geom, search geom, buffer geom, and result features from use layer features geom. I could switch to use OIDs only when the addressee and use layer features layer are the same...otherwise it wouldn't make sense as we need the geom comparison.

Sounds good me.

Looking good @jmhauck


Postman import/export with inherit auth

Currently if inherit auth is enabled, auth info is added to all requests.
Now that extend request is available, leveraging this help better manage requests

landed in 0.0.34


accelerometer not working in arcade shields for micro:bit

Describe the bug
Using Newbit Arcade Shield from KittenBot, the code cannot read the accelerometer of micro:bit.
To Reproduce
Steps to reproduce the behavior:

Go to https://arcade.makecode.com/S44073-94641-17368-75132
Choose NRF52833
Download the code to micro:bit with the arcade shield
See error

Expected behavior
The player can control the plane by tilting the micro:bit
Desktop (please complete the following information):

OS: Windows10
Browser: Chrome
Version: arcade version:  1.13.26, Microsoft MakeCode version:  9.1.3, codal-nrf52833-dk runtime version:  v2.0.2

@DoraLC  is this still an issue?

We need to add bunch of C++ to the micro:bit built mkcd to do this. Will need engineering work.


Custom BattleState Copier

Wrote a method to perform the full deep-copy of the BattleState, instead of utilizing the standard pickle deepcopy.
Testing: I performed multiple runs of the full test suite (including test_complex_case_does_not_timeout) comparing pickle vs the custom. Also ran that test case by itself with both methods. Ended up setting up pycharm to run single test cases.
Single test case: 7.7 seconds approx vs 3.7 seconds.
All test casess: 8.3 vs 4.2 seconds

@Typhi  assigning you for doing the game comparisons (if you have time), as I wont' get to them til this weekend.

Also, it seems our current test coverage does indeed cover your changes here, but more is always welcome - so if you have any tests you'd like to add on your new functionality that would be great!

Maybe a test checking if there's a difference in the result between pickle_deepcopy and battlestate_deepcopy could be a useful reminder for when someone's adding new functionality to battle_state 🤔

Yah, that's a good point for a test case to verify that the custom copier provides the exact same output as a pickle deep copy. Think I found a way to do it, but not fully sure. Will verify and hopefully add to suport future battle-state modification.
Rebound, here we come. 😃

@Typhi assigning you for doing the game comparisons (if you have time), as I wont' get to them til this weekend.

I recorded two runs on my heartslayer branch with a Watcher strat.
One without the copy changes, one with the copy changes.
Results here:

20% increase of speed for hardish fights, not that much increase before that, makes sense to me. We're often bottlenecked by animation speed in the game itself.
It'll be a bigger increase on e.g. shiv decks I assume.

@sdas337  So I did run into one bug with it:
I was testing a combination of this change, along with the DFS/BFS pop vs pop(0) on a large stack of silent games, and number 21 crashed with an index not found error.
It could be that this is due to some different logic for BFS that I need to dive into, but it also may be something we've missed in this change and not found yet.
I'll look into it more to see if I can find where the problem is coming from and if it is related to this PR or not. Unfortunately I won't have capacity for that til the weekend though, so we're still gonna take a bit more time on this PR.

@Typhi assigning you for doing the game comparisons (if you have time), as I wont' get to them til this weekend.

I recorded two runs on my heartslayer branch with a Watcher strat.
One without the copy changes, one with the copy changes.
Results here:

(Note: there's some off by 1-2 second errors introduced by my manual measuring)
20% increase of speed for biggish fights and not that much increase before that, makes sense to me. We're often bottlenecked by animation speed in the game itself.

That makes sense because there's also a big portion of time which goes to simply communicating / game speed animation. That'd drag it down towards 20%.

It'll be a bigger increase on e.g. shiv decks I assume.
From what I observed, there was NO difference in the in-battle actions taken! 🎉

Glad to hear that

Also, it seems our current test coverage does indeed cover your changes here, but more is always welcome - so if you have any tests you'd like to add on your new functionality that would be great!

Maybe a test checking if there's a difference in the result between pickle_deepcopy and battlestate_deepcopy could be a useful reminder for when someone's adding new functionality to battle_state 🤔

Only solution I see to perform the verify the full deep copy is doing it manually. .dict only checks the content of one layer being identical. It just defaults to checking same memory address afterwards.
That'd be a test that'd have to be constantly kept update to date, similar to the actual copy method. Don't think it helps.

Awesome, thanks! I think we're still going to wait until Logan has had a chance to verify the issue he ran into, sorry for the delay.

No reproduction for now from @xaved88 , rest looks good, thank you again!

Wooh


Can use VCS

I use VCS to run this testbench.
I use command : make  , in directory "rggen-sample-testbench-master/sim/apb/verilog"
But I have error as following:
make sim_vcs TEST=ral_hw_reset_test
make[1]: Entering directory '/home/jamesning/work/reggen/rggen-sample-testbench-master/sim/apb/verilog'
[ -f simv ] || make compile_vcs
make[2]: Entering directory '/home/jamesning/work/reggen/rggen-sample-testbench-master/sim/apb/verilog'
vlogan -full64 -sverilog -timescale=1ns/1ps -ntb_opts uvm-1.2 -l vlogan_uvm.log
Warning-[MXIR-W] VCS-MX build is required
Please make sure that vlogan is from the intended build.
                     Chronologic VCS (TM)
   Version O-2018.09-SP2_Full64 -- Thu Aug 24 13:32:38 2023
           Copyright (c) 1991-2018 by Synopsys Inc.
                     ALL RIGHTS RESERVED

This program is proprietary and confidential information of Synopsys Inc.
and may be used and disclosed only as authorized in a license agreement
controlling such use and disclosure.
Error-[ILWOR] Incorrect Logical Worklib or Reflib
The incorrect logical lib is "work".
Please check your Synopsys setup file.
CPU time: .110 seconds to compile
make[2]: *** [/home/jamesning/work/reggen/rggen-sample-testbench-master/sim/vcs.mk:69: compile_vcs] Error 255
make[2]: Leaving directory '/home/jamesning/work/reggen/rggen-sample-testbench-master/sim/apb/verilog'
make[1]: *** [/home/jamesning/work/reggen/rggen-sample-testbench-master/sim/vcs.mk:64: sim_vcs] Error 2
make[1]: Leaving directory '/home/jamesning/work/reggen/rggen-sample-testbench-master/sim/apb/verilog'
make: *** [makefile:32: ral_hw_reset_test] Error 2
Would you please help me to fix the bug?

I also use VCS but I've never seen such error.
I think you need to check your environment according to this message.
Error-[ILWOR] Incorrect Logical Worklib or Reflib
The incorrect logical lib is "work".
Please check your Synopsys setup file.


if you are running your app on       a physical device or emulator, you must exchange your [MaterialApp]  for a [GetMaterialApp] but GetMaterialApp if exist

ATTENTION: DO NOT USE THIS FIELD TO ASK SUPPORT QUESTIONS. USE THE PLATFORM CHANNELS FOR THIS.
Fill in the template. Issues that do not respect the model will be closed.
Describe the bug
You are trying to use contextless navigation without
a GetMaterialApp or Get.key.
If you are testing your app, you can use:
[Get.testMode = true], or if you are running your app on
a physical device or emulator, you must exchange your [MaterialApp]
for a [GetMaterialApp].
**Reproduction code
Get.toNamed("/configuracion");
example:

Future<void> main() async {
  // WidgetsFlutterBinding.ensureInitialized();
  await GetStorage.init();
  SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);
  runApp(TendaGo());
}

class TendaGo extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    Get.put(GlobalController());
    return GetMaterialApp(
      initialRoute: '/splash',
      translations: Messages(),
      locale: Get.deviceLocale,
      fallbackLocale: Locale('en'),
      localizationsDelegates: [
        GlobalMaterialLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalCupertinoLocalizations.delegate,
      ],
      supportedLocales: [
        const Locale('es', 'ES'), // Arabic, no country code
      ],
      theme: ThemeData(
          primaryIconTheme: IconThemeData(
        color: Colors.white,
      )),
      debugShowCheckedModeBanner: false,
      title: 'Tenda Go',
      home: SplashPage(),
      initialBinding: SplashBinding(),
      getPages: AppPages.pages,
    );
  }
}

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Flutter Version:
Enter the version of the Flutter you are using
Getx Version:
^4.6.1
Describe on which device you found the bug:
ex: All
Minimal reproduce code
Provide a minimum reproduction code for the problem

Maybe you are calling the navigator before the GetMaterialApp is attached.
Would you be calling Get.toNamed("/configuracion"); in onInit or class constructor?

Maybe you are calling the navigator before the GetMaterialApp is attached. Would you be calling Get.toNamed("/configuracion"); in onInit or class constructor?

Get.toNamed("/configuracion");  is called in onPress in a button but don't work

Maybe you are calling the navigator before the GetMaterialApp is attached. Would you be calling Get.toNamed("/configuracion"); in onInit or class constructor?

I think the problem is probably that you are trying to navigate with contextless. If you are trying to move from the splashscreen controller to the HomePage (for example), you can wrap Get.to() inside a Future, and this will automatically make it time for GetMaterialApp to be loaded. This worked for me.


APPS: Explore how to use refresh token

Description
Currently, when the login token expires we direct user to the login page again for the login. Instead, we have a refresh token that we might be able to use to keep the user logged in.
Why
Improves user friendliness
Closing Criteria

[ ] Use refresh token to keep the user logged in

Currently, our Solid servers do not return with a refresh token. This might have to do something with the server configuration.
Needs further research.

Solid discussion forum post: https://forum.solidproject.org/t/getting-a-refresh-token-from-css/7310/5
According to the response I received, this might be related to the server configuration side rather than OIDC flow of authentication. This needs further exploration.

Dawei notes Anushka found there is a Simple solution to getting the REFRESH token.
This task is to now use that to refresh the auth.


Project setup

Hi,
I'm trying to follow the project setup instructions.
When I run the grunt testem:run:unit task I get.
'atal error: spawn phantomjs ENOENT'
Now I read here that socket.io or something requires python < 3, so I have installed that and I am able to call python in my console, so it's in my path. I'm also able to call phantomjs and get a commandshell, so that should also be properly installed and in my path.
Any clues to what I might be doing wrong? It's really frustrating getting stuck in the first project setup chapter :)
Thanks,
/David

Ah I  figured it out.
When installing with phantomjs with npm, the issue occurs.
Solution was to uninstall phantomjs again, and install it from their website, then it worked!


Updating Changelog for @azure/cosmos v4.0.0

Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
Describe the problem that is addressed by this PR
Updating Changelog for @azure/cosmos v4.0.0
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


fix envoy-traffic-director config for xDS v3

It would be nice having a few lines in the README explaining the intended use, I could never wrap my head around this. :)

Ludo, I'll have an end-to-end example using this, and that will have a good description :). But on another PR. :D


sst.aws.ApiGatewayV1: fix issue with linking certain SST components to route handlers

Fix for https://github.com/sst/ion/issues/918.

we have a fix in v3.0.99 - turns out was a simpler problem


JavaScript Refactoring - Rename Identifier, Wrap selection, Convert to arrow function, Create Getters & Setters

This PR implements "rename" functionality in JS mode to enable intelligent rename feature by using Tern's scope analysis and inference functions. Renaming across multiple files has been intentionally blocked for the time being as we are not analyzing all the JS files in current project root right now.
The rename function works by selecting a variable def/ref or placing cursor in and using Ctrl+R.
This code is written by @swmitra and already reviewed by @petetnt (PR 13047)
I just restructured this code and created new extension called JavascriptCodeRefactoring.
Known issues:-
In a particular case Tern inference engine is picking up wrong hit. For example :-
function fn1(error) {
    error.a = "abc";
    var a = "test";
    console.log(a);
}

If we try to rename a in line 3 or 4 , Tern picks up fake ref from line 2 as well.
#Issue reported in tern 950, 951
951 is already fixed.
Wrap Selection in Try Catch/Condition

Select code/Just put cursor anywhere
Edit -> wrap in try catch/condition Or find this in submenu
If you just placed cursor it will find surrounding statements around cursor position
else if you selected code then it will check weather these are statements or not
If statements -> It will wrap that code in TryCatch/Condition
else error (Please select valid statements)

AppInit.appReady(function () {             brackets.test.doneLoading = true;         });
Select whole code or just place cursor on 3rd line it will wrap whole code in try catch block/Condition block
try {             AppInit.appReady(function () {                 brackets.test.doneLoading = true;             });         } catch (e) {             console.log(e.message);         }
Put selection on 2nd line and do wrap in try catch/condition it will wrap that line only.
Know Issue:- Some time indention goes wrong in case of wrap in condition
Convert to arrow function

Put cursor anywhere in anonymous function and click convert to arrow function
If one param structure will be param => {statements}
If zero or more than one param (param1, param2) => {statements}
In case of one statement, it will remove "{, }" and ";"as well

Create Setters and Getters for given property

Put cursor on property
Create getter/setter
get getTest() { return this.test; }, set setTest(val) { this.test = val; }

Please review @nethip @boopeshmahendran @petetnt @swmitra @ficristo @saurabh95

Is it OK to squash all of your commits into one single commit?

@navch  All error popup strings need to go into Strings.js file. Please make this change. Also consider re-wording those strings.

Thanks @nethip for reviewing this. I addressed all review comments.

Thanks @petetnt for reviewing this. I addressed all review comments.


Blocks API Endpoint should show all blocks found

I suggest blocks endpoint should show all blocks found including pending blocks with the confirmation count. I just mined two blocks half hour ago. the endpoint still show no blocks. But when I use the DashCore Windows Wallet. It can show two pending transactions are coming. Dash Explorer also can show the blocks.

Confirmation count is currently not stored in the database and can thus not be returned - for now.


Use for_each instead of count when count value is length of input variable

Currently, using count will cause a tear down and recreate if the list is preprended to or reordered.
Using for_each will remove the downtime associated with this.
E.g. https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/modules/iam-assumable-role-with-saml/main.tf#L44-L47

This is still an issue.
There may be an opportunity to use the 1.1.0 moved syntax as well here.

This is still an issue.


Bug Report - App gets Crash while searching the location !!!

Description
When users perform multiple rapid taps on the search bar in the app, it causes the app to crash. The issue occurs specifically when searching for locations, such as "IV George Avenue, Paris, France," and is triggered by aggressive interaction with the search function. This issue results in errors related to the GooglePlaceAutocomplete.js file. Specifically, it returns the error "Request has not been opened" and occasionally throws a "Cannot read property 'length' of undefined" error.
Reproduction

Open the app.
Navigate to the search bar.
Tap on the search bar repeatedly and rapidly (multiple times in quick succession).
Enter a location such as "IV George Avenue, Paris, France" and initiate the search.
Observe that the app crashes after several rapid taps.
Observe that the app crashes, and check the error messages:

Request has not been opened" at GooglePlaceAutocomplete.js (line: 339, 501, 570)
Cannot read property 'length' of undefined" (error may vary)

**Example of Code. **

Click to expand!
  <GooglePlacesAutocomplete
ref={ref}
disableScroll
query={{
  key: "MY_API_KEY",
  language: "en",
}}
minLength={2}
listViewDisplayed="auto"
fetchDetails={true}
enableHighAccuracyLocation
onPress={async (data, details = null) => {
  const loc = details?.geometry?.location;
  if (!loc) {
    return;
  }
  console.log(details);
}}
styles={{
  textInputContainer: {
    flexDirection: "row",
    borderWidth: 1,
    borderRadius: 16,
    marginBottom: 5,
  },
  textInput: {
    borderRadius: 16,
    fontSize: 16,
  },
  row: {
    gap: 16,
    height: 45,
    marginVertical: 1,
    borderRadius: 16,
    paddingHorizontal: 10,
  },
}}
textInputProps={{
  onBlur: (e) => {
    e.preventDefault();
    e.stopPropagation();
  },
  onPressIn: () => {
    setState({
      item_selected: false,
    });
  },
}}
keepResultsAfterBlur
nearbyPlacesAPI="GooglePlacesSearch"
GooglePlacesDetailsQuery={{
  fields: "formatted_address,geometry",
}}
keyboardShouldPersistTaps="handled"
debounce={300}// debounce the requests in ms. Set to 0 to remove debounce. By default 0ms.
/>

Additional context

Library Version: ^2.5.6

React Native Version: 0.73.6

[Yes] iOS

[Yes] Android

** ERROR SCREENSHOT **

+1

+1

+1 also facing the same issue...
@Hassaan0 did you find any solution for it ??

+1 also facing the same issue... @Hassaan0 did you find any solution for it ??

I implemented a temporary workaround to prevent the app from crashing, though I acknowledge it's not an ideal or permanent solution.
To do this, navigate to the file: node_modules/react-native-google-places-autocomplete/GooglePlacesAutocomplete.js. Locate the request.send() function and enclose it within a try-catch block.
Please note that if you ever delete the node_modules directory, you'll need to repeat this step, which can be quite inconvenient.


Look into and deal with CVE-2017-1000364 & CVE-2017-1000366

http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000364 & http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-1000366
for buildroot - https://git.busybox.net/buildroot/commit/?id=d29c7196bf5e610123dcc697197d4013d5869f68

[ ] kernel patch for guard page size - or 4.9.34 has the 1M guard size change (and is out in 12 hours)
[ ] add BR2_SSP_ALL=y and BR2_TOOLCHAIN_BUILDROOT_GLIBC=y to amd64
[ ] add BR2_SSP_ALL=y and BR2_TOOLCHAIN_BUILDROOT_GLIBC=y to arm
[ ] add BR2_SSP_ALL=y and BR2_TOOLCHAIN_BUILDROOT_GLIBC=y to arm64
[ ] watch for SSP fix for gcc
[ ] see if adding SSP slows things down noticably

so far, SSP is not feeling noticeably slower

please try https://github.com/rancher/os/releases/tag/v1.0.3-rc1

released in https://github.com/rancher/os/releases/tag/v1.0.3


[AIRFLOW-1635]: Allow creating GCP connection without requiring a JSON file

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issue and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Adds a new field to the Connections screen for GCP connections, allowing the user to provide key credentials as JSON data, rather than a JSON file. This allows creating or managing GCP connections without requiring access to the Airflow server and worker(s).

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

The changes are small enhancements to existing code that does not have tests. It only affects GCP connections, which is "contrib" code.
Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2634 into v1-8-test will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           v1-8-test   #2634      +/-   ##
============================================
- Coverage      68.64%   68.6%   -0.04%
============================================
  Files            140     140
  Lines          10809   10809
============================================
- Hits            7420    7416       -4
- Misses          3389    3393       +4

Impacted Files
Coverage Δ

airflow/www/views.py
68.72% <ø> (ø)
:arrow_up:

airflow/jobs.py
74.74% <0%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6069075...c71a56c. Read the comment docs.

I noticed that other passwords in the Airflow GUI are displayed using circles (the typical way passwords are "displayed" in a GUI). I will look into doing that, since it helps keep secret credentials secret. :-)

@jgao54: I renamed the field as you suggested. Also, the JSON field uses PasswordField now, which avoids exposing the credentials when someone goes back to edit the connection.

LGTM!
Merged

@criccomini this does not seem to be merged? Is it in master and in v1-9-test? There is also a big red X?

Something really weird happened. The JIRA does show that it was merged:
https://issues.apache.org/jira/browse/AIRFLOW-1635
But it's saying refs/heads/v1-8-test. Sigh.
As far as big red 'x', all tests are successful on this PR.

The dev/airflow-pr merge tool seems to be somehow merging it into v1-8-test. I have to figure out what's going on here.

Ah! The PR is set to point to v1-8-test. It should point to master.
@barrywhart can you please change this PR to point to master?

Changing to "master" is causing merge conflicts which I don't know how to resolve. I'm working on a new PR against master.

@barrywhart can you close this please? We can't do that efficiently.

Sure! I should've noticed and done this already...


Fixed FG/BG color for Teatimer

Thanks - g.reset() might be a quicker way of doing this (like the 0.02 update I did). I've put a fix in to the main Espruino firmware as well, so in cutting edge builds (or 2v15 when released) this should get fixed anyway


hotfix: fix circular dependency issue

Currently we have an issue with a circular dependency inside the configuration code,
where we cannot include util code that imports from ilabclient in the utils module.
The reason why this happens is ilabclient also imports from configuration. But if we
have code which is technically a util, we cannot move it there for this reason.
Signed-off-by: Oleg S<EMAIL_ADDRESS>

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

This PR is more-or-less just a temporary fix. The better solution which I've outlined in https://github.com/instructlab/instructlab/issues/2009  will be to move all of the default values to exist in a separate file.


chore: Use literal providers and remove hard peerDependency on Angular 2

Note that while this PR removes the peerDependency on Angular 2, upstream dependency @ngrx/core still needs it for the time being.

LGTM 👍

@robwormald I noticed in angular/vladivostok you moved the provider factories out of the provider definitions. Is this required to make to the provide statements offline compiler friendly? If so I'll send over another PR to make that change.

Dependency on Angular 2 has been removed from @ngrx/core. After this is published to npm, it should be easier to use ngrx/store in non-Angular 2 projects.

Nice! Now the integration with Angular 1 via ng-metadata will be a no brainier. 👍


test: integration for netlify-edge

made it so we first bundle everything needed for the edge function. This way we can test the local versions and no need to rely on a CDN. Now we can simply just tests the integration.
closes https://github.com/dotansimha/graphql-yoga/issues/1515

As far as I know, Edge uses Deno. Maybe we should use pulumi to deploy it via Netlify Edge. @dotansimha any ideas?

As far as I know, Edge uses Deno. Maybe we should use pulumi to deploy it via Netlify Edge. @dotansimha any ideas?

yes that is separate issue https://github.com/dotansimha/graphql-yoga/issues/1127 and I was exploring netlfiy api to make it happen


Unable to open a terminal with cmd.exe in an extension with vscode.window.createTerminal

Issue Type: Bug
My extension opens a terminal to run a specific command.
Openning the terminal is not a problem, however, specifying the terminal path is.
I am working on Windows, but my default terminal is git bash. As a consequence, results of path.join, which contain single backslashes (windows...), used in the command, does not work with git bash.
I want to make sure the windows cmd.exe terminal is used to avoid this problem (all users are on windows, this is not problematic).
The documentation says that we can specify a terminal path. I tried to provide the path of cmd.exe obtained from process.env.COMSPEC, without success:
console.log(process.env.COMSPEC)
const terminal = vscode.window.createTerminal(
    name = "Create Projet", shellPath = process.env.COMSPEC)

Throws:

C:\Windows\system32\cmd.exe
ReferenceError: shellPath
is not defined 	at
c:\Users\user\Documents\template-python-cli\vscode\project\out\extension.js:58:55
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async l._executeContributedCommand
(c:\Users\user\AppData\Local\Programs\Microsoft VS
Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:94:111644)

But as the log above says, the value exists.
How can I tell the extension to open cmd.exe with createTerminal ?
VS Code version: Code 1.61.2 (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T14:57:20.575Z)
OS version: Windows_NT x64 10.0.18363
Restricted Mode: No
Extensions (24)

Extension
Author (truncated)
Version

vscode-sql-formatter
adp
1.4.4

vscode-code-review
d-k
1.29.1

gitlens
eam
11.6.1

LogFileHighlighter
emi
2.13.0

todo-tree
Gru
0.0.214

output-colorizer
IBM
0.1.2

restructuredtext
lex
166.0.0

vscode-JS-CSS-HTML-formatter
lon
0.2.3

AWK
lug
0.0.2

csvtomarkdown
mar
0.0.1

git-graph
mhu
1.30.0

vscode-docker
ms-
1.17.0

python
ms-
2021.9.1246542782

vscode-pylance
ms-
2021.9.3

powershell
ms-
2021.9.0

gradle-language
nac
0.2.3

autodocstring
njp
0.5.4

csv-to-table
php
1.3.0

java
red
0.82.0

bash-debug
rog
0.3.9

scala
sca
0.5.4

html-preview-vscode
tht
0.2.5

markdown-pdf
yza
1.4.4

markdown-all-in-one
yzh
3.4.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30384386
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30382698
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis300:30386381
vsaa593:30376534
vssld246cf:30386378

Nevermind, unfortunately too used to the way named parameters work in Python.
Anyway, solution is:
const terminal = vscode.window.createTerminal("Create Projet",
                    process.env.COMSPEC)


update go version

Signed-off-by: Axit Patel<EMAIL_ADDRESS>This PR fixes #341
Update go version in ci.yml file
Signed commits

[x] Yes, I signed my commits.

Please do have a look @cpepper96

CC: @DelusionalOptimist @leecalcote


[FLINK-30702] Introduce ElasticDialect

https://issues.apache.org/jira/browse/FLINK-30702

@grzegorz8 Do you want to rebase and update the PR?

@grzegorz8 Do you want to rebase and update the PR?

Yes, I'll try to rebase it next week.

@grzegorz8 Do you want to rebase and update the PR?

@MartijnVisser It was easier to create a new PR than rebasing it: https://github.com/apache/flink-connector-jdbc/pull/67


Missing documentation for TargetPath metadata.

This page does not cover the pretty important TargetPath metadata. It should specify on which items it's applicable on, and how it's interpreted. For example it's definately applicable to Content items and it acts as a relative path to the output directory where the content item is copied to.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97e663f7-3bac-61af-28bb-f0e471dcdca6
Version Independent ID: 97985f56-e0ac-a03d-f651-b86cc2b85804
Content: Common MSBuild Project Items - Visual Studio
Content Source: docs/msbuild/common-msbuild-project-items.md
Product: visual-studio-windows
Technology: msbuild
GitHub Login: @ghogen
Microsoft Alias: ghogen

@cdmihai -- Mihai, thank you for your feedback.  Please consider these resources:

Visual Studio on Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@ghogen -- Gordon, please look into this issue.

I would like to understand the use of this metadata. For example, does it apply to all items? I know it is used as part of CopyToOutoutDirectory, and that only certain item types are eligible for such copies. Does this mean the TargetPath metadata (not property) is only applicable to copyable item types? Does it apply to items of type Folder or EmbeddedResource, for example?

This is a useful bit of metadata that should be documented.

AFAIK the TargetPath is a variable generated when processing items. Are you sure this setting is what you think it is? I've used LinkBase to specify the root folder in the output folder to which an item is copied, and used Link to specify the full path to the output file.
https://stackoverflow.com/a/47738053

Agree it should be documented!


Check bundle integrity more in depth

Verify all files are present
Verify the size of the image disk
Verify version of the bundle

The version check is particularly interesting when we look at upgrade. Currently we exit if the bundle is different but we could ask the user to whether continue or delete the VM if the version is still supported.

Windows CI was complaining. Fixing it hopefully!


Stop creating issues.
If you want to reply, do so here: https://github.com/lucko/LuckPerms/issues/739


Missing link to difficult to find "Microsoft Windows SDK documentation"

"For more information about opportunistic locks and about the FSCTL_REQUEST_OPLOCK control code, see the Microsoft Windows SDK documentation."
A hyperlink here might be useful since putting FSCTL_REQUEST_OPLOCK or "Microsoft Windows SDK documentation" into the search bar doesn't produce anything

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 215a96fa-bb05-5ab7-962f-168b7db624be
Version Independent ID: 45efd2a5-e340-f008-8590-86fec2ec81a7
Content: FSCTL_REQUEST_OPLOCK control code
Content Source: windows-driver-docs-pr/ifs/fsctl-request-oplock.md
Product: windows-hardware
GitHub Login: @tedhudek
Microsoft Alias: windowsdriverdev

Thanks for pointing this out, @rodwiddowson. I changed the paragraph to:
For more information about opportunistic locks, see Opportunistic Locks in the Windows Desktop documentation. For more information about user mode OPLOCK controls, see File Management Control Codes in the Windows Desktop documentation.


Account Balance query failing

Description
Account balance query failing in 2.12.1 when it was working in 2.11.0
Steps to reproduce
Do a account balance query:
this.unauthClient = Client.forNetwork(network_env as any);

const account_id = AccountId.fromString(acc_id);

        const query = new AccountBalanceQuery()
            .setAccountId(account_id);

        const account_balance = await query.execute(this.unauthClient);

This code does not work in the latest update, no mention of account balance query changing in the release notes
Additional context
No response
Hedera network
testnet
Version
2.12.1
Operating system
No response

Can you post the error? I'm not able to reproduce any error at the moment. I've tried updating our examples/ to use v2.12.1 and ran our get-account-balance.js example.

Not sure if this is related, but while I was working on other things I found out WebChannel was broken. Fixed: https://github.com/hashgraph/hedera-sdk-js/commit/50dad309e413e69b8fa24170c55bf812f04caed4


404 GET /static/plotly.js?v=

I use jupyter + plotly_express by remote machine.
Sometimes( refresh the page ) the plotly  display nothing. I cannot reproduce the situation always. I notice the log as follow:
[W 15:15:22.465 NotebookApp] 404 GET /static/plotly.js?v=2019xx (xx.xx.xx.xx) 2.51ms referer=http://xx.xx.xx.xx:.ipynb
My solution now is to restart the kernel. Is there any bug in plotly or plotly_express

It's not clear where this issue is coming from or how to fix it unfortunately. I've seen it crop up occasionally.

Any help you could provide in replicating it would be much appreciated :)

I am sorry I cannot replicate it.

Hi,
I have the same error right now, after some time of inactivity, when I returned the plots don't display anymore and I get

404 GET /static/plotly.js?v=

in the log.

Hi!
I seem to have the same issue. In my case, the error tend to pop out when I use a function which plots a graph within a widgets.interactive_output() function.
Example:
import plotly.graph_objects as go
import numpy as np
import ipywidgets as widgets
def plotgraph(a):
x = np.arange(10)
fig = go.Figure(data=go.Scatter(x=x, y=x**a))
fig.show()

a = widgets.BoundedIntText(
value=2,
min=1,
max=10,
step=1,
description='$a$'
)
out = widgets.interactive_output(plotgraph, {'a' : a})
display(out)
a.value=1
I am using:
Jupyter-notebook: 6.0.1
Python: 3.7
Plotly: 4.5.4

Our Troubleshooting guide here https://plotly.com/python/troubleshooting/ is the best place to get help figuring out this kind of thing.


[TASK] Introduce staticcheck to the PR check

I ran the static checker staticcheck (https://staticcheck.dev/docs/running-staticcheck/cli/) and it found more issues in various other places of the code.
Do we perhaps want to clean up our code base as a whole and run that checker against it as part of the CI pipeline?

Originally posted by @m-ildefons in https://github.com/longhorn/longhorn/issues/7009#issuecomment-1842975365
Introduce staticcheck to scripts/validate in all CI-enabled repos, so it will be validated during PR check.

Close it because the go validation is already introduced by @FrankYang0529.
Feel free to reopen it if needed. Thank you.


Fix / remove client_sdk auto-publishing in CI

This: https://github.com/MinaProtocol/mina/blob/develop/buildkite/src/Jobs/Release/ClientSdk.dhall#L32
will probably will start failing as soon as https://github.com/MinaProtocol/mina/pull/10405 gets merged


[Text Analytics] bump version number to 5.0.0

Closing this in favor of #10302 .

The hotfix branch has been released, now this can be merged to master.

@deyaaeldeen Can you provide a link to the PR that made changes to the hotfix branch?

@deyaaeldeen Can you provide a link to the PR that made changes to the hotfix branch?

here: https://github.com/Azure/azure-sdk-for-js/pull/10297#issuecomment-664647278.


[NoTicket] Avatar Creator Reload Fixes

Changes
Updated

ReadyPlayerMeFrame.js

Fixed bug that prevented the RPM Avatar Creator from being launched multiple times by forcing the iframe to reload when hidden (in a cross-browser stable way)
Replaced 'none' assignment with call to hideRPM to enforce reload in all cases

WebHelper.jslib

Replaced 'block' and 'none' assignments with calls to the functions 'showRpm' and 'hideRpm' to reduce duplication, enforce the reload fix in RPMFrame, and remove the need to recompile the lib when testing functionality changes

ISSUE:

Press "Create Avatar"
Either create/select an avatar or just press Hide to return to the previous page
Press "Create Avatar" again, the creator will open again but it will go directly to a "Loading" screen that never resolves

How to Test

Same as above, but on the second attempt the avatar creator will load instead of stalling

Thanks for taking the time to me a PR @kent-sole will check it out shortly.


STARTUP

Which OS are you using?
Linux
Expected Behaviour
STARTUP
[2023-03-06 22:39:35] |   DEBUG   |     Filesystem     | Created directory at "/home/z/.config/Code/User/globalStorage/sumneko.lua/addonManager"
[2023-03-06 22:39:35] |   ERROR   |         Git        | Failed to checkout repo!
[2023-03-06 22:39:35] |   ERROR   |         Git        | error: pathspec 'main' did not match any file(s) known to git.
Actual Behaviour
...
I also see the following error:
[2023-03-06 22:39:35] |   ERROR   |         Git        | error: pathspec 'main' did not match any file(s) known to git.

Reproduction steps

Go to '...'
Click '...'
See error '...'

Additional Notes
No response
Log
No response

I believe this has been fixed by 5a23814108a594b15c44fb6e961ba7a0c15ce70c. If you can confirm by installing one of the vsix files from the latest action run, it would be greatly appreciated 🙂. Otherwise, there should be a release soon that will contain the fix.

thx for your reply, problem fixed.@carsakiller


Implement Timecycle lighting for viewer

Implements https://github.com/PrismarineJS/prismarine-web-client/pull/315 by @kf106 into the viewer instead of web client. Looks like it got closed before being merged, and there was talk of moving it to the viewer anyway on that PR.
First actual contribution to the project, so let me know if there's any kind of formatting or requested changes for code structure.

I've added some improvements while testing this to make the code a little easier to understand, as well as to better follow the minecraft vanilla timecycle. The directional light in vanilla doesn't move around, but I decided to keep this as it at least adds a nice touch to the viewer.
I noticed a few errors in the 1.8.8 - 1.10 tests with entity names, so fixed a broad range by ensuring the entity name is lowercased. Not a huge improvement to anyone on current versions, but actually uses entity models correctly for most entities on lower versions now instead of pink boxes.
Some improvements could be made there to fix more such as entityhorse and ozelot which are both not in entities.json since they're wrong for latter versions.
Workflows seem to be broken, but works fine when I test locally with npm run test so 🤷

can you fix CI ?

I fixed the ci

My main concern here is I think mineflayer should be controlling the time cycle, so it should be the one sending the event telling the viewer to update its time.


Install C++ client headers

Changes look good. We must enhance the current L0_client_tar test to actually compile the small client example. This would help in catching other issues. Do you want me to take look?

Changes look good. We must enhance the current L0_client_tar test to actually compile the small client example. This would help in catching other issues. Do you want me to take a look?

No, it is not a priority right now.


Handle async functions while providing thunk-like functionality

First off, really love this package. I've been using it on all my redux projects for years.
I do have a feature request though. Now that async / await is more popular, and while it technically is already supported via IIFE:
{
  payload: (async function () { ... })()
}

It would be cool if this package just supported the promise attribute being a function, and if the result of that function was a promise (i.e has typeof then === 'function'), treat that as the regular promise payload.
And as a bonus, dispatch and getState could be supplied from the store, so what was:
function myAction () {
  return (dispatch, getState) => {
    return dispatch({
      type: 'MY_ACTION',
      payload: {
        promise: (async function () {
          const result = await someApiCall()
          dispatch(someOtherAction())

          return result
        })()
      }
    })
  }
}

could become:
function myAction () {
  return {
    type: 'MY_ACTION',
    payload: {
      async promise (dispatch, getState) {
        const result = await someApiCall()
        dispatch(someOtherAction())

        return result
      }
    }
  }
}

This is released as<EMAIL_ADDRESS>on npm.


Update Collection-of-Custom-Formats-for-Radarr.md

Add link to Single Layer DV, revise Single Layer DV format (revised by @TRaSH-)

I Had my email client setup wrong so didn't get a notification for this,
sorry for this fail on my side.
I think you messaged me in Discord and it should be already added to the Guide and also updated it.
Let me know if it's okay now else you can open a new issue.
Thnx


Question: UWP WinUI2 and Webview2 Fixed distribution on Windows Team (Surface Hub)

I am having trouble finding if it is possible to do this.
I have a UWP WinUI2 app that uses WebView2 and I need the app to work in Windows Teams (a version of windows that  Surface Hub devices have) but on these devices the WebView2 Runtime cannot be installed because only the microsoft store can install apps.
I would like to be able to include the WebView2 runtime binaries inside my application so that an external installation is not necessary. The problem is that most of the documentation or guides are for WPF applications and the process is different is not clear. For example, points 3, 4 and 5 of the "Details about the Fixed Version runtime distribution mode" in this documentation https://docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution aren't clear enough.

Yes, that is my understanding.

if that's the case it sounds like this should work if they can install the webview2 runtime, but how do they install the runtime in these devices? maybe a question for @champnic

@alexispolakMURAL https://github.com/MicrosoftEdge/WebView2Feedback/issues/1851

I end up doing what @nickprotop suggested and got the WinUI2 app running with WebView2 Fixed Runtime but got a lot of errors with some .dll files when I uploaded the app to the store.


adapt texts in share.html

e.g. the subject for the email is still "stoppen wir das überwachungspaket", and other passages still refer to überwachungspaket, too.

Siehe https://github.com/c3wien/Poke-That-Gmeind/issues/10#issuecomment-1116469406


Understanding and Implementing Passwordless SSH

Article checklist
Formatting and structure checks

[X] Have you used the correct folder and file structure? - see Contribution Guidelines

[X] Is your article properly formatted in Markdown? - see Github Markdown guide

[X] Have you used our preferred heading structure? - H3 (###) and up

[X] Does your article follow any of the suggested structure formats? - see example formats

[X] Is your article over 750 words? - Tool: Wordcounter.net

[X] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[X] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[X] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[X] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[X] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[X] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[X] Have you checked your article for readability? - Tool: Hemmingway
[X] Have you added sources for quotes and images that aren't yours?

Technical checks

[X] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[X] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[X] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes
This closes #6276

@lin-chez Please remove the authors index.md file. I'm not sure why you included it

Hello @Bayler! The authors index.md file was automatically included in my commits since I had a merge conflict.

Hello @Bayler! The authors index.md file was automatically included in my commits since I had a merge conflict.

You need to remove it.

@Bayler I have removed the file.

@Bayler I have removed the file.

It seems like that file is still causing conflicts. If you can't resolve that conflict, it'll cause merging issues in the future. If you can't solve it, create a new PR in a new branch and make sure to only upload the required files.

@lin-chez It seems like that file is still causing conflicts. If you can't resolve that conflict, it'll cause merging issues in the future. If you can't solve it, create a new PR in a new branch and make sure to only upload the required files.


Use starknet_in_rust TransactionalState

Instead of manually handling commit/rollback functionality, with version 3febaf6 of starknet_in_rust, there is a functionality for transactional state. Shall devnet-rs rely on it.

#193 fix it


Integrate name property of an address

Add Name interface and class
Rename files behind Order and Address (interfaces and classes): Make first letter lower case.
Update address related GraphQL query to include name
Add two fields to the form for adding a new address in the SelectOrAddNewAddressCard component
Adjust colum width of input fields of aforementioned form
Add utility rule isNonEmptyString to rules.ts

Gropius Issue.
Definition Of Done

[ ] Requirements of the issue are met
[ ] Code has been reviewed
[ ] Code is documented

Okay, right now, there are two issues:

In the commit message, the statement Rename files behind Order and Address (interfaces and classes): Make first letter lower case. is wrong; I only renamed the Address related files.
The renaming was not committed somehow.


Address possible LNWv2 issue in ovsp4rt

This CL addresses an apparent bug in PR https://github.com/ipdk-io/networking-recipe/pull/425.
The following unconditional change was made to common code as part of the LNWv3 implementation:

Looking at the changes that were made in this function:

For V2, it used to set the action to L2_FWD_TX_TABLE_ACTION_L2_FWD. It is now setting it to L2_FWD_RX_TABLE_ACTION_L2_FWD.
For V2, it used to set the parameter value to learn_info.src_port. It not sets it to learn_info.rx_src_port, a value that did not exist in the original V2 code.

This means it's setting a different action and port number than it used to set. While this may be correct for the V3 P4 program, I don't see how it can be the correct behavior for the unmodified V2 program.


Improve prepare_body performance

When performing a SigV4 calculation we access the AWSRequest.body property many times which can potentially be expensive depending on the type of body being sent. This removes multiple calls to the body property to avoid calculating it many times, as the value doesn't change within the signer.
This also removes an additional call to prepare_body that is no longer needed after some refactoring to how the body property works. The request is prepared in the AWSPreparedRequest constructor now meaning that calculating the prepare_body again is no longer needed.
Combined this reduces the number of times we prepare the body from 9 to 2, once when we calculate the signature and once when we actually send it. There's more profiling information in the linked issues.
Closes: #1478
Fixes: #1561

Codecov Report

Merging #1566 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #1566   +/-   ##
========================================
  Coverage    91.92%   91.92%
========================================
  Files           50       50
  Lines         9035     9035
========================================
  Hits          8305     8305
  Misses         730      730

Impacted Files
Coverage Δ

botocore/awsrequest.py
99.29% <ø> (-0.01%)
:arrow_down:

botocore/auth.py
98.33% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcad476...2f0fb0d. Read the comment docs.

@jamesls

I think caching the body property of the AWSPreparedRequest makes sense, and we more or less do that now. However, this is the AWSRequest class and I don't think caching it makes sense as the underlying data that produces the body could change. I agree the burden to known if a property is expensive to compute or not isn't optimal, but I don't think we can change that at this point.

This is the potentially expensive part. For the query serializers we ultimately produce a dict(str, str) that is later turned into bytes when preparing the request. I think ideally we would actually just have the query serializers produce the bytes directly rather than relying on request preparation to do this conversion. This way we treat the query format much more like json or xml. However, that's a much larger refactoring.

In my testing, I couldn't reproduce individual prepare_body calls taking more than half a second for 8MB body when run locally, but on lambda I was able to reproduce the prepare_body results in #1561.
So I decided to do some digging into what was actually taking so long in the urlencode and found that this line is the culprit. For some reason the join takes significantly longer on lambda than it does when ran locally. As pointed out in #1561, this scales with the memory setting in lambda.
For anyone curious, this is the lambda function I used to test:
import time
import contextlib

@contextlib.contextmanager
def measure_time(msg):
    start_perf = time.perf_counter()
    start_proc = time.process_time()
    try:
        yield
    finally:
        end_perf = time.perf_counter()
        end_proc = time.process_time()
        print(msg, 'perf', end_perf - start_perf)
        print(msg, 'proc', end_proc - start_proc)

def run_test(event, context):
    with measure_time('join'):
        body = ''.join(byte for byte in ('A' * 8 * 1024 * 1024))

if __name__ == '__main__':
    run_test({}, {})

After a rebase this is now just the original commit in #1478


Drop Do

And release v0.9.0 after that get merged.

Codecov Report

Merging #36 (7c30bef) into main (e0b9131) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   98.00%   97.98%   -0.03%
==========================================
  Files           4        4
  Lines         251      248       -3
==========================================
- Hits          246      243       -3
  Misses          4        4
  Partials        1        1

Impacted Files
Coverage Δ

acmd.go
98.55% <ø> (-0.03%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update importSanity test with some changes:

Add wait time before getting total count to make this number loaded.
Add a before hook to check exist of metadata.db file to avoid useless
metadata.db generated by new dqlite3.database command.

I am merging this after discussing it with @henrywang. We will open another card to track updates to the wait condition to make the test more robust.


_emberAwesomeMacros.string.trim is not a function

Hey there - thanks for the addon! I'm using the latest tagged version, but it looks like the trim function is still not available yet. Edit: tried master - same issue. If I switch trim to any other string function it works (e.g. dasherize).

I've just run some test with<EMAIL_ADDRESS>&<EMAIL_ADDRESS>and trim work as expected for me.
Can you double check your ember-awesome-macros version? (I can reproduce your issue with version 0.40.0)
What's your ember version?

I import trim like this
import { trim } from 'ember-awesome-macros/string';

I think I found the problem. One of our addons had ember-awesome-macros as a dependency ^.0.41.0. Our app had the devDependency *^.0.41.0. I am not sure if it's ember's fault or yarn's, but everything worked when we upgraded the addon's version.

I asked about this in the ember help channel and it seems to just be ember-cli quirk where ember-cli can't really make a good decision about which dependency should win. But it's almost 100% not an ember-awesome-macros issue.


Broken with latest Bootstrap

When running the examples with latest Bootstrap (with required popper.js), I get the following in Chrome:
Uncaught TypeError: m.getPosition is not a function
at HTMLButtonElement.m (knockstrap.min.js:2)
at HTMLButtonElement.dispatch (jquery.min.js:2)
at HTMLButtonElement.y.handle (jquery.min.js:2)
at Object.trigger (jquery.min.js:2)
at HTMLButtonElement. (jquery.min.js:2)
at Function.each (jquery.min.js:2)
at w.fn.init.each (jquery.min.js:2)
at w.fn.init.trigger (jquery.min.js:2)
at p.I.show (tooltip.js:285)
at p.I._enter (tooltip.js:548)

Can you confirm this, please? versions of jquery, bootstrap, knockout?
http://jsfiddle.net/raguchi/koqvj4un/
seems to work, although there's some markup changes between Boostrap 3/4 that should be taking into account.

Knockstrap 1.4.0
Boostrap 4.1.2
jQuery 3.3.1
knockout-3.5.0rc

same error for me.

Knockstrap 1.4.0
Boostrap 4.2.1
jQuery 3.3.1
knockout-3.4.2

Thanks for the feedback, but I have no plans to upgrade this library for Bootsrtrap 4. You may try to use KnockstrapPlus, as far as I can see it's upgraded exactly for Bootstrap 4.


Enable PostGIS on RDS

Follow https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.PostgreSQL.CommonDBATasks.PostGIS.html
Goal is to support search by locality within postgres, not adding an external service to search.

Enabled on the api-dev DB:
$ psql --host=$DATABASE_HOST --username=openmeet --password api-dev
Password:
psql (14.13 (Ubuntu 14.13-0ubuntu<IP_ADDRESS>), server 16.4)
WARNING: psql major version 14, server major version 16.
         Some psql features might not work.
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, bits: 256, compression: off)
Type "help" for help.

api-dev=> SELECT address, streetname, streettypeabbrev, zip
 FROM normalize_address('1 Devonshire Place, Boston, MA 02109') AS na;
 address | streetname | streettypeabbrev |  zip
---------+------------+------------------+-------
       1 | Devonshire | Pl               | 02109
(1 row)

Will leave open to do the same on prod after testing


Register with general registry

@JuliaRegistrator register

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/33727
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 93d623e2730244cd057039a8f78ee62a17f7b6f4
git push origin v0.1.0

@JuliaRegistrator register

Error while trying to register: Error in (Julia)Project.toml: Package 'CodeInfoTools' with UUID: bc773b8a-8374-437a-b9f2-0e9785855863 not found in registry or stdlib

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/33976
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 8b7082dce87dcec46f04172d01ccd64fbd19058d
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/33976
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" abb8423d88abfe9b08ba5bcc2f4753823d852d82
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/33976
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 50a6bf7b34185bf9b7b759647d2030f5d2e151a3
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/33976
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 34c134b0ed404d2222816ed8d01ad3198b6471d7
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/33976
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 9e84a6a0eee476ef19de54f926023c7a2b054a76
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/34144
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.1 -m "<description of version>" 0a7728b355874afa53db150d08cde01fb3612296
git push origin v0.2.1

@JuliaRegistrator

An unexpected error occurred during registration.

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/34190
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.2 -m "<description of version>" 7b7f31ab6f6fdcff89608c1db688efc646a9469a
git push origin v0.2.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/34203
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.3 -m "<description of version>" f304f2d2dbf642236728d62d2c9a7f33b54aa076
git push origin v0.2.3

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/34423
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.4 -m "<description of version>" bb6b6a5e0b515f150de7bad4063d1267ff7894fb
git push origin v0.2.4

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/35656
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.5 -m "<description of version>" f8daa93249c558c46c96c194b247b183d4d05c77
git push origin v0.2.5

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/35665
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.6 -m "<description of version>" 2f4cb8c64746eb6d4c9e92a6091a87fc7db4e859
git push origin v0.2.6

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/35806
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.7 -m "<description of version>" 5407acf4a34959edfb97d05c97172e735066a693
git push origin v0.2.7

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/35866
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.8 -m "<description of version>" ca7398eb88b9a6edf8a2a4ff25845eb13b9f2606
git push origin v0.2.8

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/35870
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.9 -m "<description of version>" bb386db4b1354dd8db5bc21c78a79479fce1e744
git push origin v0.2.9

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/35988
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" 21bbac127a26df3a0db931fead7d5ad33441d7c2
git push origin v0.3.0


🐞 Node.JS : Directory.withNewFile escape error

What is the issue?
It seems that the contents arguments of the Directory.withNewFile is not properly escaped
Log output
Syntax Error GraphQL request (2:14762) Expected Name, found : [...]
Steps to reproduce
   const stringWithQuotes = "This string has quotes \""
   const newFile = await client
       .container()
       .directory("/")
       .withNewFile("myfile", stringWithQuotes)
       .file("myfile").id()

Dagger version
dagger node 0.1.1
OS version
Linux 5.15

I believe this has been fixed in 0.2.0. @slumbering ?

New issue opened: #4130
cc @aluzzardi


useEffectAlways does not always run

In the following example based on the counter example:
module ReactExample where

import Prelude
import Data.Maybe (Maybe(..))
import Effect (Effect)
import Effect.Console as Console
import Effect.Exception (throw)
import React.Basic.DOM (render)
import React.Basic.DOM as R
import React.Basic.Events (handler_)
import React.Basic.Hooks (Component, component, fragment, useEffect, useEffectAlways, useState, (/\))
import React.Basic.Hooks as React
import Web.DOM.NonElementParentNode (getElementById)
import Web.HTML (window)
import Web.HTML.HTMLDocument (toNonElementParentNode)
import Web.HTML.Window (document)

mkExample :: Component Unit
mkExample = do
  component "Counter" \_ -> React.do
    counter /\ setCounter <- useState 0
    useEffect counter $ Console.log ("useEffect " <> show counter) *> pure mempty
    useEffectAlways $ Console.log ("useEffectAlways " <> show counter) *> pure mempty
    pure
      $ fragment
          [ R.button
              { onClick: handler_ $ setCounter (_ + 1)
              , children: [ R.text $ "Increment: " <> show counter ]
              }
          ]

main :: Effect Unit
main = do
  container <- getElementById "container" =<< (map toNonElementParentNode $ document =<< window)
  case container of
    Nothing -> throw "Container element not found."
    Just c -> do
      ex <- mkExample
      render (ex unit) c

Hitting the increment button runs the useEffect hook but does not run the useEffectAlways hook. I expected the -Always hook to run at least as often as any sibling effect hook, but it appears this is not the case. Could you help me understand why?
Thanks for an awesome library 🙏 !

Oh interesting.. I'll have to look into it. Thanks for reporting!


Update angular-chosen.js

the "timer" should be visible to line 150

Hi @yzhou88, thank you for your PR. I believe you are right.
Would you be able to implement using the src/chosen.coffee instead or the dist/chosen.js which is the compiled version?
Thanks

Fixed in 19a1ecfd2f23cddb4bb0e1cf61e283717ce9241a


update existing hero banner

for the hero banner that says: AUTOMATE OPS FOR SPRING CLOUD ON CLOUD FOUNDRY
could you update the URL to point to this article?
https://content.pivotal.io/blog/building-spring-microservices-with-cloud-foundrys-new-container-networking-stack

I can work on it.

Fixed by #698


BlobServiceClient is undefined

Using in Azure function written in JavaScript, with following dependencies:
{
  "name": "AzFunc",
  "version": "1.0.0",
  "description": "",
  "scripts": {
    "test": "echo \"No tests yet...\""
  },
  "dependencies": {
    "@azure/identity": "^1.0.0-preview.5",
    "@azure/storage-blob": "^10.5.0"
  },
  "devDependencies": {}
}

Following import statement does not import BlobServceClient:
```

const {
Aborter,
BlobURL,
BlockBlobURL,
ContainerURL,
ServiceURL,
StorageURL,
SharedKeyCredential,
AnonymousCredential,
TokenCredential,
BlobServiceClient
} = require("@azure/storage-blob")

After statement above executes, BlobServiceClient does not exist (unlike others):

typeof (BlobServiceClient)
"undefined"
typeof (ServiceURL)
"function"

Hey @leonbrag,
BlobServiceClient is present in version 12 and not in version 10.
Classes like BlobURL and BlockBlobURL are from version 10. You can refer to the changelog document to see the differences between v10 and v12.
Most recent release of v10 (10.5.0) - NPM LINK
Samples for v10 - Link
Most recent release of v12 (12.0.0-preview.4) - NPM LINK
Samples for v12 - Link
Version 12 is still in preview, I would encourage you to go through the links, readme and the samples provided to get started with the Azure Storage Blob SDK.

Thank you. Is there a sample showing how to use Managed Service Identity token to access blob storage (or tables)?

@azure/identity library should be capable of doing this.
@daviwil Can you help show the usage of Managed Service Identity token to access azure storage?
/cc - @jeremymeng

Got MSI working, but there a bug: https://github.com/Azure/azure-sdk-for-js/issues/5539


Clean up generation of builder-based convenience initializers

Based on #464 (but in a separate PR for easier reviewability).
This branch implements the proposed ideas from this thread, replacing the various explicit ...DeclConvenienceInitializers with improved gyb-generation of initializers that:

automatically generates initializers for ...Blocks too (previously only direct syntax collections were possible)
only generates builder parameters for a handful of block-like structures, in an effort to clean up and to e.g. make trailing closures more ergonomic in these APIs

currently this includes CodeBlock, MemberDeclBlock, CodeBlockItemList, MemberDeclList and PatternBindingList, but the list is easy to extend as needed

aims to make as many explicitly declared convenience initializers as possible redundant

cc @ahoppen

@swift-ci please test

I have rebased the PR on main and addressed your remarks, so the PR should be ready for a second round of review

Could you please keep using Result Builders for collections of elements with trailing commas? Otherwise #454 won't make much sense

Sure! I think result builders absolutely make sense for things like collection literals where the trailing closure syntax looks nice too. The main goal here is to reduce the number of builders that prevent us from having nice trailing-closure APIs (like modifier/attribute lists etc.), but more use cases remain to be investigated.

@swift-ci Please test

@swift-ci please test

@swift-ci please test

More of a general question: Could we put the trailing comma insertion logic into the XyzList initializers (in BuildableCollectionNodes) themselves instead of the builders? That would allow us to share the logic and remove this inconsistency between the use of builders and arrays, decoupling it from the decision which nodes are best expressed as builders. (I haven't dug too deep into this yet, so maybe this isn't really feasible after all)

Could we put the trailing comma insertion logic into the XyzList initializers (in BuildableCollectionNodes) themselves instead of the builders?

We can, but this logic is explicitly placed into Result Builders to allow to define trailing commas manually through list initializers (some context could be found here). Otherwise it's going to be no way to define trivia (for example line break) for trailing comma.

@evnik I disagree that syntax nodes should be initializable by result builders purely because of the fact that they have the trailing comma trait, but I agree that some of the types you mentioned should be initializable by result builders. My take on result builders is that we should reserve those for the main bodies of nodes. The collections that we allow to be initialized by result builders are usually the last nodes in the syntax node anyway (modulo some trailing closing token). Most importantly, we want to try and only have a single result builder in the initializers because the multiple result builder syntax didn’t improve legibility.
I put in some case-by-case comments for these nodes. @fwcd If you agree, could you adjust the list accordingly before we merge this PR?

Could we put the trailing comma insertion logic into the XyzList initializers (in BuildableCollectionNodes) themselves instead of the builders?

We can, but this logic is explicitly placed into Result Builders to allow to define trailing commas manually through list initializers (some context could be found here). Otherwise it's going to be no way to define trivia (for example line break) for trailing comma.

What do you think about transparently inserting the trailing comma before the trailing trivia of the node’s last token (i.e. drop the trailing trivia of the last token in the node and make it the trailing comma’s trailing trivia)? I think that would cover 95% of all cases and if you wanted to add trivia before the comma, you can always specify the comma yourself.

@swift-ci Please test

Just raised #472, which fixes overwriting of existing trailing commas. Not sure if with that we are fine to move the logic into list initializers.

Thanks. That PR looks good. What I thought was that the following code (basically the test case in your PR just with the newline attached to the integer literal and without the explicit comma) generates the same output as in your PR.
    let buildable = VariableDecl(letOrVarKeyword: .let, bindings: [
       PatternBinding(pattern: "a", initializer: InitializerClause(value: ArrayExpr(elementsBuilder: {
       PatternBinding(pattern: "a", initializer: InitializerClause(value: ArrayExpr(
         leftSquare: .`leftSquareBracket`.withTrailingTrivia(.newlines(1)),
         elementsBuilder: {
         for i in 1...3 {
           ArrayElement(expression: "\(i)", trailingComma: .comma)
           ArrayElement(expression: IntegerLiteralExpr(i).withTrailingTrivia(.newlines(1)))
         }
       })))
     ])

My idea would be that your code takes the trailing trivia of the last token in the element, removes it and attaches it to the newly inserted comma.

Another thought I have is we might wrap result builder not related to main body into another type, so it's possible to use trailing closure for both of them.

This would require us to re-architect the way the syntax tree is layed out and I don’t think it’s worth doing that just for the SwiftSyntaxBuilder API.

My idea would be that your code takes the trailing trivia of the last token in the element, removes it and attaches it to the newly inserted comma.

That looks interesting, but won't it be surprising? Is there a way to attach the trivia to the element itself?

I think it’s no less surprising than the fact that the result builder inserts the comma. And if you accept the fact that it inserts the comma, I think inserting it before the trailing trivia makes sense.
Trivia can only be attached to tokens, so no.

Another thought I have is we might wrap result builder not related to main body into another type, so it's possible to use trailing closure for both of them.

This would require us to re-architect the way the syntax tree is layed out and I don’t think it’s worth doing that just for the SwiftSyntaxBuilder API.

My thought was to put those wrapper types out of syntax tree, using the fact the argument should conform to the ExpressibleAsXyzElementList protocol

Ah, makes sense. I’m still not sure if it solves that many real-world use cases though to warrant the additional complexity.
Out of curiosity, are you interested in using SwiftSyntaxBuilder for some application/library you are working on?

Out of curiosity, are you interested in using SwiftSyntaxBuilder for some application/library you are working on?

Yes, currently it's in stealth mode, I'll make sure to update Examples/README.md after making it public


Alphabet file does not seem to be used in Google Colab

Hi,
Great project ! I post my comment here as an issue instead of there as a comment because it deals with the Colab training page specifically.
So on the Colab training page, I followed the instructions regarding the alphabet file, and I created a "French.txt" file in Voice-Cloning/alphabets folder based on German.txt alphabet. The alphabet is found  because it is selected in the drop-down list but then I get the "Invalid characters in text" error even though the characters listed in the error are present in "French.txt" alphabet file.
To make the training work I had to clone this repo, modify DEFAULT_ALPHABET in training's __init__ module (code changes made directly in Colab were not taken into account). Consequently it seems that the custom made alphabet file is not used or I made something wrong.

Good spot, I'll get that fixed now

That should be fixed now, please reopen if not.
(P.S. You can download alphabet files from https://coqui.ai/ rather than creating yourself)

I'll check it out thanks for the fix! Regarding alphabet file, Coqui adds also very weird characters like ("ờ‐―₽→∆ɔɛ") so I don't feel so confident using them (I don't know if these added chars will bloat the memory consumption). Anyway thanks for the tip.


When changing IV length invalidate previously set IV

And do the same for key length changes in case of variable key length ciphers.

This is alternative to #22507 and it should fix #22469 too.

This will not merge to 3.1 and 3.0 cleanly. I'll prepare a backport after this is merged.

This pull request is ready to merge

Merged to the master and 3.2 branches. I'll prepare 3.1 PR shortly. Thank you for the reviews.


Integrating The Facebook Sharing SDK

puiblish_actions permission is deprecated by fb and they have introduced new style of sharing app using Facebook Sharing SDK.
Would you please upgrade this fantastic library
Or at least upgrade facebook sdk version to 4.33 so that we can implement sharing after logging using this library

I will look into it. Cannot tell when yet.

Thank you

Since sharing is not required by my apps I do not plan on adding this feature by my self. Facebook SDK is now set to 4,5) Which currently converts to 4.38.1


net: update hardcoded nodes

contrib/seeds/generate-seeds.py is used to convert nodes_*.txt in a header file (the hex format you are seeing)


Fix bug where setCookie completionHandler is never called

Fixes #3457

Hi @Titozzz  @jamonholmgren
This PR is important for us. The cookies are not synchronized on iOS. Do you think you can check it?

News?

None yet. Is there any active contributor ?


Collective monitors

Description

Made changes to tracker.py to allow using ONE_TURN_EBE flag is collective trackers. This is done by passing a monitor instance to the non-collective tracker parts in the collective tracker. In the case of a regular TBT monitor, the monitor instance is not passed to the tracker parts.
Checklist
Mandatory:

[x] I have added tests to cover my changes
[x] All the tests are passing, including my new ones
[x] I described my changes in this PR description

Optional:

[x ] The code I wrote follows good style practices (see PEP 8 and PEP 20).
[ ] I have updated the docs in relation to my changes, if applicable
[ ] I have tested also GPU contexts

That's great, thanks a lot!


Is this being actively maintained?

Hi -- is this repository being actively maintained? I'd love to submit a bug report for a longstanding issue we're seeing with token refreshes failing (or a PR with a fix) but I'll hold off until I get confirmation that it's gonna have eyes and minds on it.

Signs say No.


docs: Add Bottlerocket example

PR o'clock
Description
There were a couple of PRs requesting changes to the module to run AWS Bottlerocket based nodes. (for example #840)
I got Bottlerocket up and running without any changes to the module so wanted to document it and possibly prevent
other PRs from trying to introduce changes that could be easily avoided.
Checklist

[ ] CI tests are passing
[ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

@Andrey9kin thanks for working on this. Can you please rebase your branch from master ?

@barryib rebased + fixed comments.. Thanks for looking into it!

Thanks @Andrey9kin for your contribution.

@barryib my pleasure. hope it will be useful for the community!


[review] don't refer to transaction_safe as a C++17 feature

from http://lists.boost.org/Archives/boost/2017/04/234173.php

fixed


Grouped conv data_format bug and efficiency issue

Bug:
Line 79 of tensorpack/models/conv2d.py
    channel_axis = 3 if data_format == 'NHWC' else 1

'NHWC' is assuming the data_format is of the tf.nn version. Instead, since you changed to tf.layers style of data_format, it should be 'channels_last'.

PS. An efficiency issue on group conv2d implementation / (Maybe a feature request?):
It seems that tensorflow dev is in the process of implementing group conv using cuda/cudnn native
https://github.com/tensorflow/tensorflow/issues/3332
https://github.com/tensorflow/tensorflow/pull/10482
However, before they eventually make it happen, implementing group conv with a for-loop is less efficient than using depthwise_conv plus some transpose/reshape/sum.
There are probably few people using group conv with tensorpack so that the bug above is not exposed, but if you would like to improve the speed of running things like ResNeXt, you might want to try this.

I realized that in the group conv case, you are assuming the data_format is of the tf.nn 'NHWC' style consistently. However, the interface can still be more clear, since now you need to change the data_format input based on split=1 or split>1.

It's an implementation detail that is not visible to users at all. An user can use either NCHW or channels_first.

Unless a user read the implementation, he will get the wrong operations if they give 'channels_last'.
Furthermore, since you changed shape4d and other argtools to take only 'channels_first/last' as well, NCHW will be incorrect for those argtools functions. Finally, 'channels_last/first' are not acceptable input for tf.nn.conv and tf.nn.bias_add.
So split > 1 with channel_last will not run, but with NHWC, you will get a wrong operation due to shape4d.


Collapse emulateTransitionEnd parameter should be configurable via options

We should be able to easily configure the value of emulateTransitionEnd speed via options, like: data-emulate-speed="200"
<button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-emulate-speed="200" data-target="#navbar-collapse-search">Search</button>

@elisechant I don't get what the use case is for using a value different from the transition duration in the CSS.

I dont think we want to add this as a data attribute - customization of this value is already possible in css

what is the purpose of the method in that case?

http://blog.alexmaccaw.com/css-transitions

alex explains it at the end of the article

See also https://code.google.com/p/chromium/issues/detail?id=437860


Getting an httpz BodyTooBig error prevents <IP_ADDRESS>:8080 from loading

Run jetzig server
Upload a large enough file to get a BodyTooBig error from httpz
<IP_ADDRESS>:8080 never loads, even after stopping and rerunning jetzig server

My code:
pub fn post(request: *jetzig.Request) !jetzig.View {
    const Scrobble = struct {
        track: []u8,
        artist: []u8,
        album: []u8,
        date: i64,
    };

    const lastfm = struct {
        username: []u8,
        scrobbles: []Scrobble,
    };

    var root = try request.data(.object);

    if (try request.file("upload")) |file| {
        const parsed = try std.json.parseFromSlice(lastfm, request.allocator, file.content, .{});

        const history = parsed.value;

        for (history.scrobbles) |scrobble| {
            const song_hash: u64 = std.hash.Fnv1a_64.hash(scrobble.track) % 99999989;
            std.debug.print("{d}\n", .{song_hash});

        }
    }

    return request.render(.created);
}

Example file:
lastfmstats-VAOTM(1).json
For what it's worth, I've set pub const max_bytes_request_body: usize = std.math.pow(usize, 2, 32); in main.zig, which may not be the corresponding configuration value, but I wasn't really expecting a BodyTooBig error after setting that.

@mitteneer Really sorry it took so long to get to this - the max_bytes_request_body const was actually unused - I never migrated it across when we switched from std.http.Server to http.zig.
I've fixed it in this PR: https://github.com/jetzig-framework/jetzig/pull/130
I tested locally by submitting a gigantic blog post, got a failure, then modified that setting then was able to submit the post without issue so I think it should solve your issue.
Let me know how it goes !

@bobf Thank you! Not sure if it's related, but I'm getting a Connection Reset error when I run jetzig server now, and nothing comes up in the terminal. If I run zig build run I get a slightly more specific, but not particularly helpful error
error: the following command terminated unexpectedly:
/home/swebb/Source/zuletzt/zig-out/bin/zuletzt
Build Summary: 14/16 steps succeeded; 1 failed
run transitive failure
└─ run zuletzt failure
error: the following build command failed with exit code 1:
/home/swebb/Source/zuletzt/.zig-cache/o/9ac3f4ffa6b6b093c4228b1db1e7b2f5/build /home/swebb/.zvm/master/zig /home/swebb/.zvm/master/lib /home/swebb/Source/zuletzt /home/swebb/Source/zuletzt/.zig-cache /home/swebb/.cache/zig --seed 0xc47b5fb2 -Z316080db31fa7fde run

I did do some editing prior to testing, but I don't know what I might have done to cause an error so esoteric

try deleting your zig cache and rebuilding maybe?

@z1fire No change, deleted both ~/.cache/zig/ and zuletzt/.zig-cache/

@mitteneer what kinds of changes did you do before testing

I rolled back my database tables, changed a table, migrated/reflected, and made some edits to a job. You can see the code here

And it worked before those changes?

I didn't immediately test the new version of jetzig, but it was working previous to the edits I made, which I know doesn't help much unfortunately, except to say that it worked previously.

@mitteneer I see in the testing branch you importing static and zmd but I don't see them in either the build.zig or the zon file.

@mitteneer This seems to be because you've set the maximum request body size to 2**32, which is 4.3G. Jetzig's backend (http.zig) is pre-allocating space for that request body size for each worker thread, so it's trying to allocate CPU count x 4.3G. On my machine that's around 34G.
Probably your process is getting killed by your operating system. Try setting the maximum body size to something a bit smaller. If you actually do need 4.3G let me know and I'll have a think about how we might be able to support that.
I set the value to 2**24 which is around 16M:
    pub const max_bytes_request_body: usize = std.math.pow(usize, 2, 24);

Server loads fine and I'm able to load it in my browser without issues.

Ah, okay. I had it at 2**32 originally to test max_bytes_request_body and forgot to switch it back. It works now, thanks for all the help!

@mitteneer No problem ! :+1:


EntitySqlHelper

GetFromReader  Unable to cast object of type 'System.Guid' to type 'System.String   Guid Primary key

Your field is string while it should be of type GUID

uniqueidentifier  sql server  type,field  StringField  GuidField  All tried    This is the wrong