🐛 [firebase_crashlytics] IOS crash when app start

Bug report
Describe the bug
After integrating firebase_crashlytics and running it on the IOS device, the startup crashed. I just added firebase_crashlytics without adding any other code. After I remove firebase_crashlytics everything works fine, I wonder what's happening here, and the crash caused by this issue doesn't have any logs, happens even before runApp.
I know this is not an effective way to find the problem, but there is really no crash information that can help me.
If more information is needed, I'm happy to provide it
Steps to reproduce
Steps to reproduce the behavior:

add firebase_crashlytics: ^3.3.2
run release for ios device
app startup crashes (flash)

Expected behavior
shouldn't crash
Sample project
Providing a minimal example project which demonstrates the bug in isolation from your main App greatly enhances the chance of a timely fix.
Please link to the public repository URL.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 3.10.2, on macOS 13.4 22F66 darwin-arm64, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[!] Android Studio
    ✗ Unable to find bundled Java version.
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.78.2)
[✓] Connected device (5 available)
[✓] Network resources

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 3.0.2
Flutter SDK 3.10.2
music 1.0.0+1

dependencies:
- cached_network_image 3.2.3 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- cookie_jar 4.0.2 [universal_io]
- crypto 3.0.3 [typed_data]
- cupertino_icons 1.0.5
- device_info 2.0.3 [flutter device_info_platform_interface]
- dio 5.1.2 [http_parser meta path]
- dio_cookie_manager 3.0.0 [cookie_jar dio]
- file 6.1.4 [meta path]
- firebase_analytics 10.4.2 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 2.13.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_messaging 14.6.2 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_easyloading 3.0.5 [flutter flutter_spinkit]
- flutter_layout_grid 2.0.3 [flutter collection meta quiver]
- flutter_local_notifications 14.1.0 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters clock collection js material_color_utilities meta path vector_math]
- flutter_native_splash 2.3.0 [args flutter flutter_web_plugins js html image meta path universal_io xml yaml]
- flutter_rating_bar 4.0.1 [flutter]
- flutter_screenutil 5.8.2 [flutter]
- flutter_swiper_plus 2.0.4 [vector_math flutter]
- fluttertoast 8.2.2 [flutter flutter_web_plugins]
- get 4.6.5 [flutter]
- get_storage 2.1.1 [flutter get path_provider]
- google_sign_in 6.1.1 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web]
- image_picker 0.8.7+5 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- json_annotation 4.8.1 [meta]
- loading_animations 2.2.0 [flutter]
- logger 1.3.0
- nanoid 1.0.0
- package_info 2.0.2 [flutter]
- package_info_plus 3.1.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32]
- palette_generator 0.3.3+2 [collection flutter path]
- path 1.8.3
- path_provider 2.0.15 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- permission_handler 10.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- pretty_dio_logger 1.3.1 [dio]
- pull_to_refresh 2.0.0 [flutter]
- sentry 7.6.2 [http meta stack_trace uuid]
- share 2.0.4 [meta mime flutter]
- share_plus 7.0.1 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32]
- shared_preferences 2.1.1 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- sign_in_with_apple 4.3.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web]
- sqflite 2.2.8+4 [flutter sqflite_common path]
- uni_links 0.5.1 [flutter uni_links_platform_interface uni_links_web]
- url_launcher 6.1.11 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- visibility_detector 0.4.0+2 [flutter]
- webview_flutter 4.2.1 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- youtube_explode_dart 1.12.4 [collection freezed_annotation html http http_parser json_annotation meta xml]
- youtube_player_iframe 4.0.4 [flutter meta webview_flutter webview_flutter_android webview_flutter_wkwebview url_launcher youtube_player_iframe_web]

dev dependencies:
- build_runner 2.4.4 [analyzer args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml]
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]
- json_serializable 6.7.0 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper]

transitive dependencies:
- _fe_analyzer_shared 61.0.0 [meta]
- _flutterfire_internals 1.3.2 [collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer 5.13.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- archive 3.3.7 [crypto path pointycastle]
- args 2.4.1
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.4.0 [analyzer async convert crypto glob logging meta package_config path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 4.0.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.2.0 [analyzer async build collection crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.9 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta package_config path pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.6.0 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 2.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.2 [flutter flutter_cache_manager cached_network_image_platform_interface]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- cli_util 0.4.0 [meta path]
- clock 1.1.1
- code_builder 4.4.0 [built_collection built_value collection matcher meta]
- collection 1.17.1
- convert 3.1.1 [typed_data]
- cross_file 0.3.3+4 [js meta]
- csslib 0.17.3 [source_span]
- dart_style 2.3.1 [analyzer args path pub_semver source_span]
- dbus 0.7.8 [args ffi meta xml]
- device_info_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- fake_async 1.3.1 [clock collection]
- ffi 2.0.2
- firebase_analytics_platform_interface 3.6.2 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.4+2 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_core_platform_interface 4.8.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.5.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_messaging_platform_interface 4.5.2 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.5.2 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- fixnum 1.1.0
- flutter_blurhash 0.7.0 [flutter]
- flutter_local_notifications_linux 4.0.0+1 [dbus ffi flutter flutter_local_notifications_platform_interface path xdg_directories]
- flutter_local_notifications_platform_interface 7.0.0+1 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 2.0.15 [flutter]
- flutter_spinkit 5.2.0 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- freezed_annotation 2.2.0 [collection json_annotation meta]
- frontend_server_client 3.2.0 [async path]
- glob 2.1.2 [async collection file path string_scanner]
- google_identity_services_web 0.2.1 [js meta]
- google_sign_in_android 6.1.14 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.6.2 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.4.0 [flutter plugin_platform_interface quiver]
- google_sign_in_web 0.12.0 [flutter flutter_web_plugins google_identity_services_web google_sign_in_platform_interface http js]
- graphs 2.3.1 [collection]
- html 0.15.3 [csslib source_span]
- http 0.13.6 [async http_parser meta]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.0.17 [archive meta xml]
- image_picker_android 0.8.6+16 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.12 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.7+4 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.6.3 [cross_file flutter http plugin_platform_interface]
- intl 0.18.0 [clock meta path]
- io 1.0.4 [meta path string_scanner]
- js 0.6.7 [meta]
- lints 2.1.0
- logging 1.2.0
- matcher 0.12.15 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.2.0
- meta 1.9.1
- mime 1.0.4
- octo_image 1.0.2 [flutter flutter_blurhash]
- package_config 2.1.0 [path]
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- path_provider_android 2.0.27 [flutter path_provider_platform_interface]
- path_provider_foundation 2.2.3 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.11 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.0.6 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.6 [ffi flutter path path_provider_platform_interface win32]
- pedantic 1.11.1
- permission_handler_android 10.2.1 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.8 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface]
- petitparser 5.4.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.1.4 [meta]
- pointycastle 3.7.3 [collection convert js]
- pool 1.5.1 [async stack_trace]
- process 4.2.4 [file path platform]
- pub_semver 2.1.4 [collection meta]
- pubspec_parse 1.2.3 [checked_yaml collection json_annotation pub_semver yaml]
- quiver 3.2.1 [matcher]
- rxdart 0.27.7
- share_plus_platform_interface 3.2.1 [cross_file flutter meta mime plugin_platform_interface path_provider uuid]
- shared_preferences_android 2.1.4 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.2.2 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.2.0 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.2.0 [flutter plugin_platform_interface]
- shared_preferences_web 2.1.0 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.2.0 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.4.1 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.4 [shelf stream_channel web_socket_channel]
- sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta]
- sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js]
- sky_engine 0.0.99
- source_gen 1.3.2 [analyzer async build dart_style glob path source_span yaml]
- source_helper 1.3.3 [analyzer collection source_gen]
- source_span 1.9.1 [collection path term_glyph]
- sqflite_common 2.4.5 [synchronized path meta]
- stack_trace 1.11.0 [path]
- stream_channel 2.1.1 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- synchronized 3.1.0
- term_glyph 1.2.1
- test_api 0.5.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.9.2 [path]
- timing 1.0.1 [json_annotation]
- typed_data 1.3.2 [collection]
- uni_links_platform_interface 1.0.0 [flutter plugin_platform_interface]
- uni_links_web 0.1.0 [flutter flutter_web_plugins uni_links_platform_interface]
- universal_io 2.2.0 [collection meta typed_data]
- url_launcher_android 6.0.34 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.1.4 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.5 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.5 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.1.2 [flutter plugin_platform_interface]
- url_launcher_web 2.0.17 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.6 [flutter url_launcher_platform_interface]
- uuid 3.0.7 [crypto]
- vector_math 2.1.4
- watcher 1.1.0 [async path]
- web_socket_channel 2.4.0 [async crypto stream_channel]
- webview_flutter_android 3.7.1 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 2.3.1 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 3.4.4 [flutter path webview_flutter_platform_interface]
- win32 4.1.4 [ffi]
- xdg_directories 1.0.0 [meta path process]
- xml 6.3.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]
- youtube_player_iframe_web 2.0.2 [flutter flutter_web_plugins webview_flutter_platform_interface]

Hi @zzh3321, please provide a complete minimal reproducible code sample along with steps to reproduce so that we can investigate this issue. Please also provide the crash log.
Thank you

@danagbemava-nc Hi,I feel it should be a device compatibility issue (or xcode), here is the minimal reproducible code:

new flutter project
add firebase_crashlytics: ^3.3.2
flutter pub get
run project on my iphone 8 plus(version 13.6.1)
app crash

console print:
Launching lib/main.dart on iPhone in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: 8J9VKW4EK3
Running pod install...
Running Xcode build...
Xcode build done.                                           24.3s
Installing and launching...
(lldb) Assertion failed: (gotLocation), function applyFixupsToImage_block_invoke_3, file /Library/Caches/com.apple.xbs/Sources/dyld/dyld-750.4.2/dyld3/Loading.cpp, line 779.
dyld: Assertion failed: (gotLocation), function applyFixupsToImage_block_invoke_3, file /Library/Caches/com.apple.xbs/Sources/dyld/dyld-750.4.2/dyld3/Loading.cpp, line 779.

- thread #1, stop reason = signal SIGABRT

    frame #0: 0x0000000104e18f68 dyld`__abort_with_payload + 8

dyld`:

->  0x104e18f68 <+8>:  b.lo   0x104e18f84               ; <+36>

  0x104e18f6c <+12>: stp    x29, x30, [sp, #-0x10]!

  0x104e18f70 <+16>: mov    x29, sp

  0x104e18f74 <+20>: bl     0x104e17550               ; cerror_nocancel

Target 0: (Runner) stopped.

Error launching application on iPhone.

remove firebase_crashlytics and everything is ok.

I think I found the problem, it's a problem with xcode 14.3, after upgrading to 14.3.1 this problem doesn't appear anymore.
https://developer.apple.com/forums/thread/727680
https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3_1-release-notes

Thanks for the update.
Closing this as this was fixed by an xcode update.


Add more tests for pkg/chrootarchive

Fixes issue #11601
Signed-off-by: Yestin Sun<EMAIL_ADDRESS>

ping @unclejack

LGTM

LGTM


IOT Edge Blob Storage setup

Hi,
i am following the below link to setup blob-storage connectivity from our edge device
https://docs.microsoft.com/en-us/azure/iot-edge/how-to-deploy-blob?view=iotedge-2020-11
I see that the blob storage container is running and also when i inspect the container it is associated to the volume (I am using the docker Volume i created for this)
Is it a feasibility that i can connect to this local storage account from Azure Storage Explorer? I tried and this doesnt seem to work. Unlike the example i am running docker in Ubuntu 18.0.4 and when i try to connect i get the below error
Connection string : DefaultEndpointsProtocol=http;BlobEndpoint=http://device.domain.com:11002/accountname;AccountName=accountname;AccountKey=accountkey
Error message in brief is as below:
etails:
{
"name": "RestError",
"message": "The value for one of the HTTP headers is not in the correct format.\nRequestId:d6a5e046-e4ab-4476-85c1-bb05d246656d\nTime:2021-01-11T16:24:17.8097750Z",
"__zone_symbol__error": {
"originalStack": "Error: The value for one of the HTTP headers is not in the correct

Duplicate of https://github.com/MicrosoftDocs/azure-docs/issues/68717.

Duplicate of https://github.com/MicrosoftDocs/azure-docs/issues/68717.


[ENG-1369][ENG-1368][ENG-1367] Sloan Icons Omnibus

Purpose
Since the Sloan icons PRs have been mostly aproved individually but will conflict if merged one-by-one I've created this PR to combine and standardize the code into one consistent PR.
Changes

adds new data/prereg/coi based fields to the preprint model
adds new data/prereg/coi update methods to the preprint model
adds new data/prereg/coi fields to serialize with customization that validates for switch activeness.
add new tests for all icons.

QA Notes
There is a small migration, but no user facing changes at this point. Dev test only.
Documentation
A lot of docstrings, but noting user facing
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-1367
https://openscience.atlassian.net/browse/ENG-1368
https://openscience.atlassian.net/browse/ENG-1369

merged into https://github.com/CenterForOpenScience/osf.io/pull/9291


New Azure Resource Manager (ARM) Extension doesn't work for new document

On Mac OS X El Capitan, I tried to author a new JSON document, using the new ARM extension for Visual Studio Code. I'm not getting Intellisense suggestions for Azure Resource Manager resources.
I'm assuming that the $schema property is required, but I'm not getting any assistance for how to add the schema version, or which schema versions are valid.

Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell
https://trevorsullivan.net
https://twitter.com/pcgeek86

yes, there needs to be a schema file association. Either using $schema, in the settings, or by an extension.
https://code.visualstudio.com/docs/languages/json#_json-schemas-settings for more information and examples.
You are saying that you are using the ARM extension. If there's a clear association of file name to schema, then they should declare that association in their extension. Is 'VirtualNetwork.json' a file name you picked or is it a default name? If it's a default name I'd move the issue to the ARM extension team.
We have no code assist for $schema. That's a good idea, but there's an open number of schemas around, so in the end you as the user will have know the schema URL to validate against,

@aeschli Yeah, I would assign this over to that team. VirtualNetwork.json is a file name that I chose. How would the file name matter though? An ARM JSON template file can have any file name, as long as it ends with the .json file extension.
My recommendation here is that the ARM VSCode Extension team adds support for completing the $schema property.

But we can not associate all JSON files with the ARM schema by default. There's plenty of other json files around which are not ARM configuration files.
I'll change this issue as a request to provide code assist for $schema then,

@aeschli I understand that you can't assume ARM by default, given that JSON is generic. I don't know exactly what the right solution is, but having nothing certainly isn't one. :smile:


Target to use about 25MB for the new layered txpool by default

PR description
Reduce the default memory usage of the txpool, to limit the added amount of memory used by Besu.
There 2 memory limited layers, ready and sparse, so to target 25MB we set the limit for a layer to 12.5MB

waiting for more metrics before merging

Reckon this warrants a changelog entry?

Existing changelog entry about the layered txpool, updated


for deep learning, change how we save models

tensor flow has a .save() that we will have to use most likely.
we may then have to do our own custom load function as well...

got this figured out in keras branch


Release/r7

[x] Scala Core: bump to 0.2.0 (#292)

[x] Schema DDL: bump to 0.6.0 (#293)

[x] igluctl: bump to 0.3.0 (#294)

[x] igluctl: bump Schema DDL to 0.6.0 (#295)

[x] Schema DDL: bump iglu-core-json4s to 0.2.0 (#297)

[x] Scala Repo Server: bump Scala to 2.10.6 (#289)

[x] Scala Core: downgrade json4s to 3.2.11 (#268)

[x] Common: bump OracleJDK to 8 in .travis.yml (#281)

[x] igluctl: bump AWS SDK to 1.11.228 (#279)

[x] Documentation: Fix broken link on client configuration page (#277)

[x] Scala Core: bump sbt-bintray to 0.5.1 (#285)

[x] Common: add Ruby client (#230)

[x] Scala Core: add json4s to test scope (#236)

[x] igluctl: fix incorrect generation of Redshift and JSON Path filenames (#271)

[x] Scala Core: add Scala 2.12 support (#276)

[x] Scala Core: bump SBT to 1.0.3 (#180)

[x] Schema DDL: generate fixed length for 'email' fields (#257)

[x] Schema DDL: add support for 'date' format (#256)

[x] Common: update READMEs markdown in according with CommonMark (#267)

[x] Schema DDL: add Scala 2.12 support (#288)

[x] igluctl: switch to Scala 2.12 (#287)

[x] Schema DDL: add check that root of JSON Schema has type object (#224)

[x] Schema DDL: add linter for optional fields (#252)

[x] igluctl: add lint check of unknown formats (#227)

[x] igluctl: add support for Java 9 (#300)

[x] Schema DDL: add linter for upper maxLength (#220)

[x] (waiting from Anton) Scala Core: make proper use of implicits (#275)

[x] Bump version in README

[x] Add CHANGELOG

[ ] Blog post

Hey @oguzhanunlu, unfortunately we already released Penny Black as R3. If you're still looking for something Turkey-related, you can check out this list: https://en.wikipedia.org/wiki/Postage_stamps_and_postal_history_of_Turkey

Oh, I didn't notice that. Thanks @chuwy ! Then let it be Adrianople.

Hey @oguzhanunlu, could you give me some insights on how to read above check-list? Do you add unchecked items when you pushed a relevant commit into branch?
Those are of course for you, but it would be useful for me if I'll be able to interpret them correctly.

Hey @oguzhanunlu, please have a look at this one and please, do following:

Implement it and put somewhere in the root of your branch
create and implement similar ones for Igluctl (0.3.0) and Schema DDL (0.7.0?)
create bumps for inner dependencies, like igluctl: bump Schema DDL to 0.7.0 and push these bumps
when you're done with above, please do publishLocal for libraries and +test (note +) - it'll test apps across all versions.

Above makes our R7 release to contain not just 3rd-party, but also our own fresh libs. Right now we're just doing separate releases, which is almost useless.
Unrelated: please rename all tickets like Schema DDL: Add Scala 2.12 support to Schema DDL: add Scala 2.12 support (lowercase in second part). Sorry for bike-shedding, but we want our changelog to be consistent.

@chuwy For first question, yes, I follow that. I was working on #265 today and will look at #292 after handling #287 . Will update commit messages as well.

Hey @oguzhanunlu, I see you're doing good progress on Iglu-refreshment. Let me know what do you think about adding #147 and #167 to scope of this release. I have several reasons to propose that:

This will unblock some work related to #263 in other libraries and these particular issues (#147 and #167) do not look experimental or hard to implement. At the same time now I'm quite confident this is the right way to go
It doesn't feel right to release next non-patch version of core library with such minor changes as we currently have
If we'll implement this - we'll be able to start using Iglu Core more actively as it'll include quite solid ground for versioning

Please let me know of what impact it will have for R7 ETA.

Thanks @chuwy, I think it's definitely worth adding both issues to this release, especially due to your 2nd reason. Considering that I need some explore time with each issue, I hope to finish implementations of remaining issues by middle of next week after which we'd start QA. Maybe I can work on these two during QA of existing issues? (Note that my estimate is really rough, I'll be in constant touch.)

 Iglu R7 Adrianople

Hey @oguzhanunlu, sorry, but I cannot find a postage stamp called "Adrianople". Could you please point me to it?

@chuwy I just used postage stamp at the top right corner of wikipedia page you suggested.

Hm. I don't think this is stamp's given name.

Alright, let's change it to Asik Veysel. I found postage stamps of him over the internet, for example here, currently top-left one. @chuwy Do you think this is fine?

Hey @alexanderdean, can you advice how to proceed here? Seems we cannot find famous Turkish stamps with given name (such as Penny Plack or Scinde Dawk). Can we count stamp with Adrianople as postage stamp "Adrianople"?

In that case, let's just go with a famous stamp from this page:
https://en.wikipedia.org/wiki/List_of_postage_stamps
e.g. Treskilling Yellow

Hey @oguzhanunlu, please address few mentioned above issues (including "Treskilling Yellow") and publish rc2 - I'll do another very quick pass and probably we're good for release.

Did I miss the blog post?

No @alexanderdean , I was making new modifications on it and opening PR in a few minutes.

Hey @oguzhanunlu. I just finished QA for a local snapshot of Iglu and everything looks good! Great work.
We're waiting for CI/CD fix (please add all your changes atop of Prepared for release commit) and blog post from me.


Rename group everywhere

I think there was a previous attempt, but not all places were done?
Anyhow, the correct group name is:
https://groups.google.com/g/validatedpatterns
Closes #346

This is an automated message:
You can preview this docs PR at http://357.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.


Create mosaic-testing module

[x] CHANGELOG.md's "Unreleased" section has been updated, if applicable.

I really want to land this, but I want to play around with the API locally first. I just haven't had a lot of free time lately. I will try to get to it some day this week, hopefully tomorrow.
I think we can avoid exposing internal API for this by making the base testing API a little more generic. This would allow the normal testing API to still provide consuming of the rendered output, but the commonTest of the runtime could still consume the internal nodes.

Just a rebase so I can start looking locally. I'm off for two weeks after tomorrow, so hoping to get some movement here.
At the very least, the test API needs changed to track the changes in Redwood and #507 where we get rid of the channel and capture changes after a call to sendFrame.


added linear axis samples to vuepress

Forgot to ran linter, has some issues will fix first

Lint error is fixed, noticed I also didnt ran linter on my area samples but you fixed those errors, thanks for that


Collection class constructors (implications of only allowing no-arg ctor's)

FireORM requires that my collection class's constructor have no parameters, so I can't pass in the data needed to initialize the class.  This means that I have to add the 'undefined' type to all my class attributes, and initialize them after the class has been created, otherwise TS will complain (assuming TS strict mode).
But 'undefined' is an invalid value in the datastore.  If an entity doesn't have a value for an attribute it needs to set it to null, not undefined, so I have to add null as a valid type for each non-mandatory attribute too.
But even then, those attributes get written to the DS (with value 'null') so the potential to save storage by omitting unused values is lost.
Have I got this right?
If I do, here are some thoughts/suggestions... would it be possible for

Fireorm to allow constructor parameters?  (The parameters would be undefined when the constructor is invoked by fireform and the constructor implementation would have to handle that.)

for undefined values to not be written to the datastore (rather than causing an error).  BTW, the error message I got for this was very informative - thanks!.

Thanks for the suggestions!
I wasn't aware about this. I'm aware that parameterless constructors are required so fireorm can initialize the instance for you but I didn't know that you couldn't declare your own constructor with parameters (although you have to keep the parameterless one for fireorm).

Yes, javascript doesn't allow overloading for function/method/constructor parameters.  And I believe that having one signature with no parameters and one with, would still be considered overloading.
Perhaps the loose nature of both the type system and the parameter system makes it impossible.
Anyway, thanks for consider my feedback.  I don't mind whether you close this issue or keep it open.

@GitTom As a workaround, I would suggest adding a manufacture method to your collection classes that returns a new instance (or existing instance) of your class.

@GitTom , it's possible to have several definitions, something like this:
class Foo {
  id: string = null;
  name: string;
  age: number;

  constructor();
  constructor(name: string);
  constructor(age: number);

  constructor(nameOrAge?:string|number) {
    //
  }
}

@skalashnyk Interesting.  I guess that is a Typescript attempt to work around the limitation.   Seems a bit awkward though, and I prefer not to stray that far from JS when I write TS.

@skalashnyk Interesting. I guess that is a Typescript attempt to work around the limitation. Seems a bit awkward though, and I prefer not to stray that far from JS when I write TS.

As I know, it's an only way, how to overload function/method in typescript and many vendors implement their libraries this way...
For example, class-transformer that fireorm use to serialize:
/**
 * Converts plain (literal) object to class (constructor) object. Also works with arrays.
 */
export function plainToClass<T, V>(cls: ClassType<T>, plain: V[], options?: ClassTransformOptions): T[];
export function plainToClass<T, V>(cls: ClassType<T>, plain: V, options?: ClassTransformOptions): T;
export function plainToClass<T, V>(cls: ClassType<T>, plain: V|V[], options?: ClassTransformOptions): T|T[] {
    return classTransformer.plainToClass(cls, plain as any, options);
}

https://github.com/typestack/class-transformer/blob/develop/src/index.ts#L31


Add vignette html

Knitted new html vignette

Pull Request Test Coverage Report for Build 593

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.571%

Totals

Change from base Build 591:
0.0%

Covered Lines:
2503

Relevant Lines:
2619

💛  - Coveralls


fix(diff): update for breaking change on nightly

https://github.com/neovim/neovim/pull/28101 renamed nvim__buf_redraw_range to nvim__redraw.

[x] I have read CONTRIBUTING.md
[x] I have read CODE_OF_CONDUCT.md

Thanks for the PR!
Just noticed it couple of minutes ago :) In current form it will break earlier Neovim versions (as seen in CI). I would rather have a separate helper for the whole buffer (which is the only way it is used in 'mini.diff' right now) which uses the new vim.api.nvim__redraw() if it is present.

Pulled out into a redraw_buffer helper. Let me know if any other changes are needed.

Pulled out into a redraw_buffer helper. Let me know if any other changes are needed.

Only style nit picking which I won't bother you with and will do myself. Thanks for the quick reaction!


floating point days in durations are trouble

I'm seeing some surprising behavior adding/subtracting a partial-day duration to a moment:
var moment = require('moment');
var now = new moment();
var halfday = moment.duration(1/2, 'd');
var fullday = moment.duration(1, 'd');
var day_ago = now.clone().subtract(fullday);
var halfday_ago = now.clone().subtract(halfday);
var otherhalf_ago = now.clone().subtract(halfday.as('ms'));
if (day_ago.isSame(halfday_ago)) { console.log("surprise!"); }
if (!halfday_ago.isSame(otherhalf_ago)) { console.log("surprise!"); }

examining the actual dates, subtracting halfday subtracts a full day (and adding halfday adds nothing).
doing the computation with halfday.as('ms') produces the correct result. The momentjs code is pretty
opaque in this regard, is this expected behavior?

Yeah, floating point days aren't really supported there. The background here is that we need to set the date directly, as opposed to to boiling down to MS and adding them. Specifically, if you add a day across a DST barrier, you want the time to stay the same, even if it's actually 23 or 25 hours later. So what the code actually does is something like this:
m.set('date', m.date() + howMuchYouAdded);

You can see it here.
So that doesn't really work with partial days, e.g.
moment().set('date', 3.5); //=> three days in the future, same clock time

Just ends up translating to:
> d = new Date()
Fri May 01 2015 21:11:44 GMT-0400 (EDT)
> d.setDate(3.5)
1430701904662
> d
Sun May 03 2015 21:11:44 GMT-0400 (EDT)

So it's very different from converting to millis and adding to the current number of millis, and with good reason. But with fractional dates it sure is confusing. One fix would be to break up day durations into whole and fractional parts, add the whole number as we do now, convert the fractional remainder to ms, and then tack that on top. Would need to do that with sizes other days, too, I guess? What do you think, @ichernev?

I see. I missed that days also have some "calendarness" to them like months. Your fractional suggestion does allow the integer part of day to do that job, and is my local workaround.

hi
Related Problem. I think the results here should be always 2:
moment.duration().add(1.1,'days').hours()
0
moment.duration().add( (moment.duration().add(1.1,'days').asHours()) ,"hours").hours()
2

I'm going to close this issue as it's old, and I don't think it's a road we should go down. Ultimately, there is no conversion between date math and time math, and I don't think we should try to make one. Other date and time libraries don't do it.
A while ago we did clean up the rounding so that it always goes towards zero, making adding negative 1.5 and subtracting 1.5 behave the same. I think that's as good as this is going to get.

Related documentation: http://momentjs.com/guides/#/lib-concepts/date-time-math/


how to create a feature expression which include a condition?

❓ Questions and Help
We sincerely suggest you to carefully read the documentation of our library as well as the official paper. After that, if you still feel puzzled, please describe the question clearly under this issue.
I want to create a feature based on a condition ,e.g. 1 if $a>0 & $b>0 else 0. Sorry I searched but did not find a clue...
I intent to create a custom handler.
thank you!

可以直接调用
from qlib.data.ops import *
Operators.if(condition, feature_left, feature_right)

Hope this example will be helpful
https://qlib.readthedocs.io/en/latest/start/getdata.html#api


[SR-6420] Ensure that the pthread_key is initialised once

@swift-ci please test

How are we calling _CFTSDInitialize more than once in the first place?

The table is a thread-local, so it is called once per thread. If you submit many async dispatch blocks that trigger a CF code path, this table gets assigned as a thread local per dispatch worker thread.

Need to check under the load test that found this problem that it resolves the issue. Please hold off merging until then.

If we're calling __CFInitialize more than once we have serious problems. That is once per process start.

And that is the only place we call the _CFTSDInitialize function...

You’ll note that there is a call to this inside the same file on line 666 which is the one causing the duplicate calls.

You're right; that's different than the Darwin Foundation.
I think the right solution here is actually just to delete the call from CFPlatform.c.

That is unless somehow this call happens before __CFInitialize, but I hope not. That's supposed to be first.

Will have a look next week to see why the call is there. It may have been added because the CFInitialize wasn’t being called first, and so this was added as a workaround. Or it may be unnecessary. We have a test case that can verify either solution so will get to that on Monday.

@parkera the change (adding the initialize) was dropped into a mega-drop in a455cde38e06052385560d0a7c5aeb5a4991f844 by @phausler last year. Given that this patch allows the call to happen at most once per process, I'm going to merge this as is, and then maybe @phausler knows why the call to adding the initialize was required subsequently.

@swift-ci please test and merge

I'm not happy at all about merging this without getting to the root cause.


Generation problem of polymorphic type marshalling

Problem
Some mgmt SDK generation code cannot pass build with marshalling or unmarshalling problem. The possible cause might be polymorphic type mixing up.
RP influenced
consumption
Error
.\zz_generated_models.go:3787:35: r.ResourceAttributes.marshalInternal undefined (type ResourceAttributes has no field or method marshalInternal)
Swagger

https://github.com/Azure/azure-rest-api-specs/blob/3865f04d22e82db481be0727b406021d29cd2b70/specification/consumption/resource-manager/readme.md

datamigration
Error
.\zz_generated_models.go:6141:71: too many arguments in call to m.MigrationValidationDatabaseLevelResult.marshalInternal
have (string)
want ()
.\zz_generated_models.go:6413:58: too many arguments in call to m.MigrationValidationResult.marshalInternal
have (string)
want ()
Swagger

https://github.com/Azure/azure-rest-api-specs/blob/3865f04d22e82db481be0727b406021d29cd2b70/specification/datamigration/resource-manager/readme.md

machinelearningservices
Error
.\zz_generated_models.go:106:60: too many arguments in call to a.AksComputeSecretsProperties.marshalInternal
have (ComputeType)
want ()
.\zz_generated_models.go:1089:67: too many arguments in call to d.DatabricksComputeSecretsProperties.marshalInternal
have (ComputeType)
want ()
.\zz_generated_models.go:1509:49: too many arguments in call to k.KubernetesSchema.marshalInternal
have (ComputeType)
want ()
Swagger

https://github.com/Azure/azure-rest-api-specs/blob/3865f04d22e82db481be0727b406021d29cd2b70/specification/machinelearningservices/resource-manager/readme.md

Possible dupe of https://github.com/Azure/autorest.go/issues/652

This is similar to #652 in that there are multiple parents.  However in this case neither of the parent types are discriminators.


bip62 low S

Return low S as per https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#low-s-values-in-signatures

Since BIP66 activated over the weekend, any transaction containing BER-encoded signatures will not be accepted by the Bitcoin network. Roughly half of the signatures generated by PyBitcoinTools will be deemed invalid without this PR.

Yep, I've run into the issue several times already.
I've submitted this PR which signs with low s and also implements is_bip66

Testing fails if the ecdsa_raw_sign changes s to low s. Instead I've implemented der_encode_sig to check for:

BIP66
Low s

@vbuterin Is it best to implement the code at this PR while also fixing ecdsa_raw_sign to return low s?


Add TAB path autocomplete for ng generate command

🚀 Feature request
Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

Please, add path autocomplete possibility for ng g command.
Now, I need to check that the path is correct manualy:
ng g c /pages/main-page/components/smth

or run two commands:
cd /src/app/pages/main-page/components/

ng g c smth

Describe the solution you'd like
I'd like to be able to use TAB autocomplete on ng g ...
Describe alternatives you've considered

cd to navigate to target directory (TAB autocomplete works here)
ng g ... to generate smth.

Duplicate of #11043


Onboard Registry Viewer to registry.devfile.io

/kind user-story
Which area this user story is related to?

/area registry
User Story
The registry viewer would need to be hosted at registry.devfile.io. Since the index endpoint is served at registry.devfile.io as well, we should serve the website when default html is requested, and the index json when json contents are requested
The registry viewer website could also be hosted on the same container running the index server devfile-index-base, since it is light weight and we want to reduce the cost of maintaining two containers and can hold the logic for serving the appropriate content.
Acceptance Criteria

[ ] It should serve the appropriate content requested, html vs json
[ ] Ensure the registry library/tool providers is working as expected, as registry.devfile.io is expected to host the viewer
[ ] Tekton pipelines and route definitions for staging/prod may need to be updated if its exposed on a new port

Post:

[ ]  It should trigger the registry-support push next image workflow via a DISPATCH event (perhaps with a workflow on a new release)

Related Issue: https://github.com/devfile/api/issues/527

Added new/updated requirements in the feature description

Summary:
/   redirects depending on the content header; JSON to /index and HTML to /viewer
/devfiles will remain unchanged
/viewer will host the registry-viewer
Base image needs to be ubi rather than any docker image because of SRE requirement(should not be on dockerhub), may use https://catalog.redhat.com/software/containers/ubi8/nodejs-14-minimal/6065b8e1b92fbda3a4c65d91?container-tabs=overview.
Port can be anything other than 8080 as the index server is hosted on it(NextJS defaults to 3000). We can use the NextJS Dockerfile as a guide to define our Dockerfile - https://nextjs.org/docs/deployment. This should reside in https://github.com/devfile/registry-support/blob/main/index/server/Dockerfile. (NOTE: All the static pages to reside on the Node server)
Make sure to start the server via the entrypoint https://github.com/devfile/registry-support/blob/main/index/server/entrypoint.sh


Falco builder vsyscall disabled

I noticed that when running the falco-builder image falcosecurity/falco-builder on newer kernels, on most commands (including the entrypoint and the build toolchain) the process exits giving a segmentation fault with status code 139.
➜  falco git:(dev) ✗ docker run -it  falcosecurity/falco-builder sh
➜  falco git:(dev) ✗ echo $?
139

I digged a bit more and noticed that even if I build the image on the current machine I get the same at some point in the build.
Sending build context to Docker daemon  4.608kB
Step 1/12 : FROM centos:6
 ---> d0957ffdf8a2
Step 2/12 : ENV FALCO_VERSION 0.1.1dev
 ---> Using cache
 ---> b5c70e6108a8
Step 3/12 : ENV BUILD_TYPE Release
 ---> Using cache
 ---> 156d5ff10493
Step 4/12 : ENV BUILD_DRIVER OFF
 ---> Using cache
 ---> 9c5ccb69b67b
Step 5/12 : ENV BUILD_BPF OFF
 ---> Using cache
 ---> 675a4f4adf6d
Step 6/12 : ENV BUILD_WARNINGS_AS_ERRORS ON
 ---> Using cache
 ---> be4d470af988
Step 7/12 : ENV MAKE_JOBS 4
 ---> Using cache
 ---> f98af294d477
Step 8/12 : RUN curl -o /etc/yum.repos.d/devtools-2.repo https://people.centos.org/tru/devtools-2/devtools-2.repo &&     rpm -i http://mirror.pnl.gov/epel/6/i386/epel-release-6-8.noarch.
rpm &&     sed -e 's,$basearch,i386,' -e 's,$releasever\],$releasever-i686\],' /etc/yum.repos.d/devtools-2.repo > /etc/yum.repos.d/devtools-2-i686.repo &&     yum -y install         crea
terepo         devtoolset-2-toolchain         dpkg         dpkg-devel         expect         gcc         gcc-c++         git         glibc-static       libcurl-devel         make      cu
rl      libcurl-devel   zlib-devel         pkg-config         rpm-build         unzip         wget         tar         autoconf         automake         libtool &&     yum -y install
     glibc-devel.i686         devtoolset-2-libstdc++-devel.i686         devtoolset-2-elfutils-libelf-devel &&     yum clean all
 ---> Running in e79ceb7576b5
The command '/bin/sh -c curl -o /etc/yum.repos.d/devtools-2.repo https://people.centos.org/tru/devtools-2/devtools-2.repo &&     rpm -i http://mirror.pnl.gov/epel/6/i386/epel-release-6-8
.noarch.rpm &&     sed -e 's,$basearch,i386,' -e 's,$releasever\],$releasever-i686\],' /etc/yum.repos.d/devtools-2.repo > /etc/yum.repos.d/devtools-2-i686.repo &&     yum -y install
    createrepo         devtoolset-2-toolchain         dpkg         dpkg-devel         expect         gcc         gcc-c++         git         glibc-static       libcurl-devel         make
        curl    libcurl-devel   zlib-devel         pkg-config         rpm-build         unzip         wget         tar         autoconf         automake         libtool &&     yum -y ins
tall         glibc-devel.i686         devtoolset-2-libstdc++-devel.i686         devtoolset-2-elfutils-libelf-devel &&     yum clean all' returned a non-zero code: 139

Then I saw that the centos:6 was a problem in fact:
➜  falco git:(dev) ✗ docker run -it  centos:6 sh
➜  falco git:(dev) ✗ echo $?
139

Now, that was cool because that kind of page fault always intrigue me!
On this machine I have coredumpctl, so I used it to attach a gdb to the dump of my page fault.
coredumpctl gdb bash

This is what I got
Hint: You are currently not seeing messages from other users and the system.
      Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
      Pass -q to turn off this notice.
           PID: 5525 (bash)
           UID: 1000 (vagrant)
           GID: 1000 (vagrant)
        Signal: 11 (SEGV)
     Timestamp: Sat 2019-05-25 00:20:33 UTC (23h ago)
  Command Line: bash
    Executable: /bin/bash
 Control Group: /system.slice/docker.service
          Unit: docker.service
         Slice: system.slice
       Boot ID: 8610d4c29c0d45a3937600372e0c1576
    Machine ID: 7d3dea95900241d6b41d6808620ecc3e
      Hostname: l13o1
       Storage: /var/lib/systemd/coredump/core.bash.1000.8610d4c29c0d45a3937600372e0c1576.5525.1558743633000000.lz4
       Message: Process 5525 (bash) of user 1000 dumped core.

                Stack trace of thread 1:
                #0  0xffffffffff600400 n/a (n/a)

GNU gdb (GDB) 8.2.1
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /bin/bash...(no debugging symbols found)...done.
[New LWP 1]
Core was generated by `bash'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0xffffffffff600400 in ?? ()

Oh, that missing area seems what I was looking for...
I don't have it in my maps area...
cat /proc/self/maps
558cf2333000-558cf2335000 r--p 00000000 00:15 14789                      /usr/bin/cat
558cf2335000-558cf2339000 r-xp 00002000 00:15 14789                      /usr/bin/cat
558cf2339000-558cf233b000 r--p 00006000 00:15 14789                      /usr/bin/cat
558cf233c000-558cf233d000 r--p 00008000 00:15 14789                      /usr/bin/cat
558cf233d000-558cf233e000 rw-p 00009000 00:15 14789                      /usr/bin/cat
558cf3539000-558cf355a000 rw-p 00000000 00:00 0                          [heap]
7f02d9e41000-7f02d9e63000 rw-p 00000000 00:00 0
7f02d9e63000-7f02da148000 r--p 00000000 00:15 47942                      /usr/lib/locale/locale-archive
7f02da148000-7f02da16a000 r--p 00000000 00:15 47233                      /usr/lib/libc-2.29.so
7f02da16a000-7f02da2b6000 r-xp 00022000 00:15 47233                      /usr/lib/libc-2.29.so
7f02da2b6000-7f02da302000 r--p 0016e000 00:15 47233                      /usr/lib/libc-2.29.so
7f02da302000-7f02da303000 ---p 001ba000 00:15 47233                      /usr/lib/libc-2.29.so
7f02da303000-7f02da307000 r--p 001ba000 00:15 47233                      /usr/lib/libc-2.29.so
7f02da307000-7f02da309000 rw-p 001be000 00:15 47233                      /usr/lib/libc-2.29.so
7f02da309000-7f02da30f000 rw-p 00000000 00:00 0
7f02da31e000-7f02da320000 r--p 00000000 00:15 47222                      /usr/lib/ld-2.29.so
7f02da320000-7f02da33f000 r-xp 00002000 00:15 47222                      /usr/lib/ld-2.29.so
7f02da33f000-7f02da347000 r--p 00021000 00:15 47222                      /usr/lib/ld-2.29.so
7f02da348000-7f02da349000 r--p 00029000 00:15 47222                      /usr/lib/ld-2.29.so
7f02da349000-7f02da34a000 rw-p 0002a000 00:15 47222                      /usr/lib/ld-2.29.so
7f02da34a000-7f02da34b000 rw-p 00000000 00:00 0
7ffda11fb000-7ffda121c000 rw-p 00000000 00:00 0                          [stack]
7ffda12c9000-7ffda12cc000 r--p 00000000 00:00 0                          [vvar]
7ffda12cc000-7ffda12cd000 r-xp 00000000 00:00 0                          [vdso]

At this point, I didn't know that the area was referring to vsyscall yet, so as first thing I tried searching it around and I found as first result an article from @gianlucaborello  here (lol it's so cool when you find things from your colleagues frist) explaining exactly the same thing!
So, to confirm all that, as last thing I tried to enable emulated vsyscall on the machine:
cat /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-linux root=UUID=06b4f944-44b6-43d6-b0ab-52041c83026b rw vsyscall=emulate quiet

After doing that the container worked just fine.
Conclusions
Should we get rid of centos:6 for the builder? This is an issue for multiple issues:

Soon, our current or future CI provider might upgrade to a newer kernel without vsyscalls
New contributors that don't use the cmake toolchain but rather prefer the builder will not be able to make it work on newer kernels

More info
Kernel version:
Linux l13o1 5.0.13-arch1-1-ARCH #1 SMP PREEMPT Sun May 5 18:05:41 UTC 2019 x86_64 GNU/Linux

/kind feature


Add support for dot in patch part and major.minor version only

Add support for "." in patch and major.minor version only.
For example: 1.0, 3.4.5.Final, 4.2.5.RELEASE

Hi @k-bx,
I created the PR to support "." in patch and version with major.minor only
For example: 1.0, 3.4.5.Final (hibernate library), 4.2.5.RELEASE (Spring framework)
Could you please help review and consider to merge this upstream?
Thanks,
Minh Tran

@minhkiller thanks for the work, but unfortunately I think I can't merge this. Semver clearly states that PATCH version is an integer, and only allows hyphen to follow it.
I suggest either adding some pre-filtering function which would transform hibernate and sprint-like version into a form which is a valid semver and use this library on top, or to write a complete parser, whatever fits your use-case best.
Thank you for the effort anyways!

@k-bx Thanks for your response.
Can you accept a lenient mode for the parser? Certainly I'm happy with rejecting shitty version strings by default

@minhkiller actually, yeah, why not. Please make a separate function parse_lanient or similar name and make a clear documentation for it, I see no problem having it in-place.

Cool thanks @k-bx. I will update the PR


Feature/zipkin prometheus working

Proposal

Add Zipkin with Opentelemetry
Add Prometheus

Links

https://opentelemetry.io/docs/instrumentation/rust/
https://crates.io/crates/opentelemetry-zipkin
https://crates.io/crates/prometheus

Codecov Report

Merging #25 (437045d) into main (897c359) will decrease coverage by 3.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   83.91%   79.94%   -3.98%
==========================================
  Files          43       45       +2
  Lines        1026     1077      +51
==========================================
  Hits          861      861
- Misses        165      216      +51

Impacted Files
Coverage Δ

src/config/env_var.rs
84.00% <0.00%> (-16.00%)
:arrow_down:

src/config/prometheus.rs
0.00% <0.00%> (ø)

src/config/zipkin.rs
0.00% <0.00%> (ø)

src/presentation/http/mod.rs
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Simplify now URL

You can use now alias illustrated-algorithms-xxxxzzz.now.sh illustrated-algorithms.now.sh in order to provide a simpler and canonical URL. Note that would need to do that for each time you now deploy, or you can add it to your now configuration (not really sure though).

Done. Cant believe I didn't realize this was possible. Thanks!


ResearchContextPage: llm_name

kernel-planckster sends to the UI, for a given user (user_id):

research_context_id
research_context_title
research_context_description
llm_name

Check if we want to show this, then tell @hersh if we do

@harsh010102 @iamMihirT  In the end we won't provide llm_name in this feature. So it'll just be:
research_context_id
research_context_title
research_context_description


Better support for smaller chips, and a bugfix when converting float->str

This one makes it possible to compile spi.cpp on targets which have fewer SPI busses than the original chip. For example, UC3C2512C only has one SPI port.
There was also a bug in the float/double to string conversion on numbers between -0.0 and -0.999999. After the value was split into its integral- and fractional components the integral component was converted to an integer and written as text to the buffer. When the integral part was -0.0 the sign was discarded. I found no clean way of dealing with this as -0 doesn't seem to exist on integers as far as I could see.
Sorry for the tab/spaces mess. I tried my best to keep it to tabs only.

Could you document these changes in README too?:)

Done :)

This example fails to compile: https://github.com/aery32/aery32/blob/master/examples/spi.cpp
I thought that AVR32_NUM_SPI is part of the Atmel header files. Did you define it somewhere else by yourself?

Hmmmm, the correct define seems to be AVR32_SPI_NUM. Let me do some digging to see where I got my define from, but it's definitely incorrect. Can you change it to AVR32_SPI_NUM?


Add File picker component to Blueprint

I have a blueprint that I use to view npz files that I log. I have a function to create the blueprint, one to load the npz file and one to log the data from the npz file to the blueprint. Currently I call the script with the path of the npz file I wish to view. I usually have folders of npz  files and would like to be able to quickly switch between them. Is there a way to have a component for entering a file path/drag and dropping a file and have it update the blueprint? Essentially there would be a callback on the file picker that calls my pipeline to load, and log to the blue print.

It sounds like you're looking for an external data-loader? See also this page about sharing blueprints, that'll probably come in handy.
I think this answers your question, feel free to re-open otherwise.


False positive with class attribute string value and docstring

Thank you for building this plugin! It's saved me from several bugs :tada:
I found what I believe to be a false positive when a class attribute has a string value and a docstring:
Version
I cloned the repository as of 7db5b51bb5a28586a47c39ca4184d459b29e620a, followed the pipenv instructions, and added a new tests/run_flake8/attribute_docstring.py file.
Input
class Class:
    attribute = "value"
    """docstring"""

Actual
./attribute_docstring.py:2:24: NIC002 Implicitly concatenated str literals over multiple lines

Expected
I'd expect no issues to be reported because "value" and """docstring""" are not concatenated:
Python 3.12.6 (main, Sep  6 2024, 19:03:47) [Clang 15.0.0 (clang-15<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> class Class:
...     attribute = "value"
...     """docstring"""
...
>>> Class.attribute
'value'

Unfortunately I'm insufficiently familiar with the Python language standard to point to language that specifies the behavior I'm observing, and my Googling found documentation that doesn't mention attribute docstrings as an exception.

Thanks for reporting the issue!

I've upgraded the dependency and was able to remove the temporary # noqa: NIC002. Thanks for fixing!


[WIP] Added a build badge to the README and also renamed it from .txt to .rst

Overview
This PR adds a build badge to the README in order to show off our CI state. It also renames the file from README.txt to README.rst, which seems more explicit.
Related Issue / Discussion
See #512
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
[x] I have already previously agreed to the pycsw Contributions and Licensing Guidelines

Renaming readme.txt caused a break in the setup.py for GeoNode recently.

ok, setup.py was covered.
Thanks.

@ricardogsilva can you fix/rebase the merge conflicts here? I will merge thereafter.

Yes, I'll fix the conflicts and then we can merge

@tomkralidis
I've fixed the conflict. Shoudl be good to merge, pending your review.

@ricardogsilva can you fix/rebase? Looks like some earlier commits are being pushed again.

grrr, there's something with this git rebase workflow that fights with my brain all the time.
yeah I'll fix it later then,, sorry for the noise

Here's what usually works for me (untested) assuming you keep a backup of this branch on disk while fixing.
git checkout 502-add-a-build-badge-to-the-readme
git remote add upstream https://github.com/geopython/pycsw.git
git fetch upstream
git reset --hard upstream/master
# now you are at parity with upstream master
# rename/add badge to README.rst, make changes to MANIFEST.in and setup.py
git commit -m 'your-commit-message'
git push -f origin 502-add-a-build-badge-to-the-readme

@tomkralidis thanks for the tip on cleaning up the commit history. Worked like a charm!
This is ready for review again

thanks @ricardogsilva!


[TF 2.0.0rc0] Error when using cuDNN GRU

Upgrading from pip package tensorflow-gpu==2.0.0-beta1 to tensorflow-gpu=2.0.0-rc0 the cuDNN GRU op no longer seems to work:
import tensorflow as tf

print(tf.__version__)

print(tf.keras.layers.GRU(10)(tf.random.uniform((1,1,1))))

Gives expected output for beta1:
2.0.0-beta1
tf.Tensor(
[[ 0.14719923 -0.10625355 -0.01931523 -0.01283051 -0.11508528 -0.05038062
  -0.04895313 -0.03125525  0.12742375 -0.06588683]], shape=(1, 10), dtype=float32)

versus this for rc0
2.0.0-rc0
---------------------------------------------------------------------------
UnknownError                              Traceback (most recent call last)
<ipython-input-1-5455006264d0> in <module>
      3 print(tf.__version__)
      4
----> 5 print(tf.keras.layers.GRU(10)(tf.random.uniform((1,1,1))))

~/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/layers/recurrent.py in __call__(self, inputs, initial_state, constants, **kwargs)
    621
    622     if initial_state is None and constants is None:
--> 623       return super(RNN, self).__call__(inputs, **kwargs)
    624
    625     # If any of `initial_state` or `constants` are specified and are Keras

~/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/engine/base_layer.py in __call__(self, inputs, *args, **kwargs)
    849           with base_layer_utils.autocast_context_manager(
    850               self._compute_dtype):
--> 851             outputs = self.call(cast_inputs, *args, **kwargs)
    852           self._handle_activity_regularization(inputs, outputs)
    853           self._set_mask_metadata(inputs, outputs, input_masks)

~/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/layers/recurrent_v2.py in call(self, inputs, mask, training, initial_state)
    342     else:
    343       last_output, outputs, runtime, states = self._defun_gru_call(
--> 344           inputs, initial_state, training, mask)
    345
    346     if self.stateful:

~/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/layers/recurrent_v2.py in _defun_gru_call(self, inputs, initial_state, training, mask)
    396       # Under eager context, check the device placement and prefer the
    397       if can_use_gpu:
--> 398         last_output, outputs, new_h, runtime = cudnn_gru(**cudnn_gru_kwargs)
    399       else:
    400         last_output, outputs, new_h, runtime = standard_gru(**normal_gru_kwargs)

~/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/layers/recurrent_v2.py in cudnn_gru(inputs, init_h, kernel, recurrent_kernel, bias, mask, time_major, go_backwards)
    536     outputs, h, _, _ = gen_cudnn_rnn_ops.cudnn_rnn(
    537         inputs, input_h=init_h, input_c=0, params=params, is_training=True,
--> 538         rnn_mode='gru')
    539
    540   last_output = outputs[-1]

~/.local/lib/python3.6/site-packages/tensorflow_core/python/ops/gen_cudnn_rnn_ops.py in cudnn_rnn(input, input_h, input_c, params, rnn_mode, input_mode, direction, dropout, seed, seed2, is_training, name)
    107             input_mode=input_mode, direction=direction, dropout=dropout,
    108             seed=seed, seed2=seed2, is_training=is_training, name=name,
--> 109             ctx=_ctx)
    110       except _core._SymbolicException:
    111         pass  # Add nodes to the TensorFlow graph.

~/.local/lib/python3.6/site-packages/tensorflow_core/python/ops/gen_cudnn_rnn_ops.py in cudnn_rnn_eager_fallback(input, input_h, input_c, params, rnn_mode, input_mode, direction, dropout, seed, seed2, is_training, name, ctx)
    196   "is_training", is_training)
    197   _result = _execute.execute(b"CudnnRNN", 4, inputs=_inputs_flat,
--> 198                              attrs=_attrs, ctx=_ctx, name=name)
    199   _execute.record_gradient(
    200       "CudnnRNN", _inputs_flat, _attrs, _result, name)

~/.local/lib/python3.6/site-packages/tensorflow_core/python/eager/execute.py in quick_execute(op_name, num_outputs, inputs, attrs, ctx, name)
     65     else:
     66       message = e.message
---> 67     six.raise_from(core._status_to_exception(e.code, message), None)
     68   except TypeError as e:
     69     keras_symbolic_tensors = [

~/.local/lib/python3.6/site-packages/six.py in raise_from(value, from_value)

UnknownError: Fail to find the dnn implementation. [Op:CudnnRNN]

Thanks for looking into this!
The CUDNN available from apt specified in the tensorflow install guide ( https://www.tensorflow.org/install/gpu#ubuntu_1604_cuda_10 ) gave this error. Manually downloading a (newer) .deb file from nvidia seemed to solve the issue for me as well.
Not sure if the issue is due to apt and a messy setup or if rc0 is not compatible with <IP_ADDRESS>-1.
Problem solved for me anyhow.


Add auto merge

@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/castepxbin-feedstock#2.


    docs: troubleshooting issues with self-signed SSL certs

New updates on head repo.
https://github.com/vitejs/vite/commit/20593197e88ab59d7c0aec18fd76e08dd155906f

対応します


Feature/particle system

First iteration of the particle system, this represents a usable version but with very basic features

This needs to be merged after the bilboards right?

This needs to be merged after the bilboards right?

@baransrc I believe @alvaro-soppelsa included the functionality of that one into this


Deleted tag? "Unknown revision v1.7.8"

Hello,
Has the tag v1.7.8 been created and then deleted?!
I've got several projects using the version v1.7.8 after having upgraded all my modules and my builds are now broken with go1.12 because the v1.7.8 has vanished... However it's working with go1.13 (I use both) because the version v1.7.8 is available on the default Go Module Mirror (https://proxy.golang.org/). For more information about Module downloading and verification in go1.13, please read https://tip.golang.org/cmd/go/#hdr-Module_downloading_and_verification.
The versions list is available on the default proxy: https://proxy.golang.org/github.com/influxdata/influxdb/@v/list
My guess is the v1.7.8 has existed before but has been deleted after being cached by the proxy.golang.org. So the proxy.golang.org is continuing to serve that version...
Should I considered that version as broken?

Hi @plo- and thanks for the report.
We have pushed tag v1.7.8 to mark the release. We investigated GitHub logs, but unfortunately those did not provide any information on how or when this tag may have been removed.


[Work in progress]Add official support to kill on slow handshake

@dpwspoon I looked into how to implement this feature for the http layer. I tried to follow the example from the WsnAcceptor, where a wsLocalAddress is created in the getWsLocalAddress(line 899).
I tried to implement this in the HttpAcceptor, firstly in the addBridgeFilters method from the bridgeHandler, but the session object from there doesn't seem to be of the proper type to get the local address as a ResourceAddress object.
The doSessionOpened method (line 300), from the httpResourcesHandler seemed to have the same session type as in the WsnAcceptor. I placed a breakpoint in that method, but it doesn't seem to stop there when loading the demo page.
What is the best approach to implement this for the http level?

@mgherghe I didn't get a chance to look into the code, I'll double check the design tomorrow but it seems like the right start.  All sessions in the Gateway should be IOSessionEx, and it should be safe to caste to that (put an assert on it to double check though).
I believe the HttpResourceHandler (again haven't looked at the code yet) is for what we use to call "http resources", which are dynamic resources that get served, I think things like the session path on the upstream and downstream URLs of WSE...  And thus it probably would not get called when doing a directory service request.

@mgherghe For http, one way to solve it would be to add 2 filters in the HttpAcceptor.addBridgeFilters; one to start the timeout, and one after the codec/decoder filter that cancels the timeout.  The HttpAcceptor appears to be a singleton.  In the bindInternal method of the acceptor you will have the HttpResourceAddress with the handshake timeout, and the transportAddress that it binds to.  I would imagine that the transportAddress of the incoming session would be available to bindInternal.  Thus, by keeping a mapping of the transportAddress Addresses to timeouts you should be able to look up timeout in the addBridgeFilters method.

@dpwspoon I pushed my latest changes based on your suggestions for http. Which would be the best k3po scenario to test this ?

I would think the minimal requirements would be a http slow handshake where the timeout kicks in.  And a case where it doesn't kick in.  You will probably need to write the slow handshake timeout one in tcp, as there is not a way to partially send the request headers.  For the case that it doesn't kick in we should make sure that the request headers are received then it is done, but the content can be incomplete (double check that this is what was agreed on in the spec)...

@dpwspoon I added a robot script to test the http handshake timeout filter. If I look in the Eclipse
log after running the test, I can see that the http filter is activated and closes the session as expected, but the test throws an InterruptedException. I tried putting a try catch in the unit test but it doesn't seem to catch the exception and finish the test properly. Also, after running this test, the k3po robot gets stuck if I try to rerun the test, so it needs to be restarted (probably why many of the tests from the Travis build failed).
What would be the best approach to fix this ?
Attaching also the k3po log for this test.
Also, I changed the way to shut down the ScheduledExecutorService from using shutdown() to shutdownNow() method, since the first one took longer to terminate and the task still executed even when it was not supposed to. This change caused the TcpHandshakeTimeoutIT.serverCloseAfterOpenWithNoData to fail. I looked into the k3po script for this test and it seems that it awaits for a notification from a barrier before closing the connection. With the previous approach, this probably happened after reaching the tcp.idle.timeout value, but now this is not the case. Should this test still be kept in the TcpHandshakeTimeoutIT?

@dpwspoon I added a robot script to test the http handshake timeout filter. If I look in the Eclipse
log after running the test, I can see that the http filter is activated and closes the session as expected, but the test throws an InterruptedException. I tried putting a try catch in the unit test but it doesn't seem to catch the exception and finish the test properly. Also, after running this test, the k3po robot gets stuck if I try to rerun the test, so it needs to be restarted (probably why many of the tests from the Travis build failed).
What would be the best approach to fix this ?
Attaching also the k3po log for this test.

I see several ways the test can race given the way it is written.  Try thinking about the state machine when drafting the tests where both the server under test and robot are two threads.  If there is ever a state where they both will give an action to the other side at the same time then there is a race and you will see failures.  I've added comments to where the more obvious races are.  We can have a call to cover this if that would help?

Also, I changed the way to shut down the ScheduledExecutorService from using shutdown() to shutdownNow() method, since the first one took longer to terminate and the task still executed even when it was not supposed to. This change caused the TcpHandshakeTimeoutIT.serverCloseAfterOpenWithNoData to fail. I looked into the k3po script for this test and it seems that it awaits for a notification from a barrier before closing the connection. With the previous approach, this probably happened after reaching the tcp.idle.timeout value, but now this is not the case. Should this test still be kept in the TcpHandshakeTimeoutIT?

I don't understand how the change to shutdownNow caused this test to fail.  This is the one test testing the functionality of the handshake time out so it definitely needs to pass.  I don't see anything that seems to be wrong with the tests as it is written (perhaps I am mistaken).  Does the shutdownNow get called when you run this test (I would think that it shouldn't be as the test is not supposed to send any data)?  or is the test sporadically failing?  Either our implementation here is wrong, or our test is wrong

It looks like the presence of the barrier is throwing an exception, as the gateway is closing the connection prior to the barrier being triggered.
From: https://github.com/k3po/k3po/wiki/Scripting-Language

Require that the barrier named “” have been notified before the next input event in the script occurs (normally read). If that event occurs before the barrier has been notified this will result in a script failure.

I don't think you need a barrier at all.  The script could be as simple as
connect tcp://localhost:8001
connected

write "GET /clientaccesspolicy.xml HTTP/1.1\r\n"
closed

And if the server does not close the connection then the closed event will not be hit.

I changed the k3po script as per your suggestion and now the tests pass. I tried adding
read "HTTP1/1 408 at the end of the k3po script, but the gateway doesn't send this, so the test failed in that case.
I was looking into how to implement this feature for the ws layer. I noticed that the WsnAcceptor contains several BridgeHandlers and it is unclear to me where the filters to start and stop the timer for the ws handshake timeout should be added.

@dpwspoon I pushed my changes for the wsn layer.
I added the filters in the doUpgrade() method of the wsnHttpRFC6455BridgeHandler.
I am not sure if the way the k3po script is written is the proper way to test if a slow wsn connection will be killed, since the test currently fails.
Your feedback would be helpful.

If you think of wsn, the handshake is really just at the http layer, so I would expect in the code that the future is being completed nearly instantaneously? So there probably isn't much to do...
For wse, again it is http.
For these two, we should consider propagating the ws handshake timeout to http if it isn't set... Thought? Ping @robinzimmermann
For wsx the handshake is the second request response, see:
https://github.com/k3po/k3po/blob/develop/specification/httpx/image00.png
Also, take a look at TLS :-).

For these two, we should consider propagating the ws handshake timeout to http if it isn't set...

In the requirements document, it is stated that all the layers should have a default value. This would mean that there isn't a case where the http isn't set.

@dpwspoon While trying to start the gateway locally, I noticed that I get a NPE when trying to connect to the configured echo service.

2016-06-14 14:28:52,200 [New I/O worker #1] INFO  [tcp#1 0:0:0:0:0:0:0:1:53661] EXCEPTION: java.lang.NullPointerException
java.lang.NullPointerException
at org.kaazing.gateway.transport.http.HttpAcceptor.addBridgeFilters(HttpAcceptor.java:549)

After debugging, I saw that when starting the gateway, the value for the transportAddress in HttpAcceptor is [tcp://[0:0:0:0:0:0:0:1]:8000 (tcp://localhost:8000) http/1.1]
as opposed to the value existing in the map, which is
[tcp://<IP_ADDRESS>:8000 (tcp://localhost:8000) http/1.1]
[tcp://[0:0:0:0:0:0:0:1]:8000 (tcp://localhost:8000) http/1.1].
I could not figure out why this value is different when starting the gateway, but it works fine with the existing k3po scripts. Your feedback would be helpful.

It is likely that k3po is not using the ipv6 address to connect, perhaps your test is.   I'm not sure why the address is different.  Perhaps the LocalAddress is not being correctly converted to a ResourceAddress...?  Maybe at the tcp layer it might be better to deal with InetAddresses as the key to the map anyways because there is that inherit casting... (try using externalURI)

@dpwspoon The value with both ipv4 and ipv6 is from when the k3po script is run.
I am getting the transportAddress with ResourceAddress transportAddress = LOCAL_ADDRESS.get(session);
However, when I am trying to connect to a service after starting the gateway, this value seems to be the alternate value from the addresses used in the bindInternal method, that are kept in the map.
When running a test with a k3po script, the value for the transportAddress is not the alternate..
One option to not get a NPE when trying to connect to the gateway would be to keep the alternate value in the map and also use it when trying to add the filters, but I am not sure this is the best approach.
I looked into using the externalUri, but if I have several accepts with just different paths, they would have the same value for the externalUri.
I also ran the HttpHandshakeTimeoutIT.httpHandshakeTimeoutKillsSlowSession test in debug mode in its current format, and even though the test passes, it does not add any handshake filters (not the TCP one, neither the http ones). When it had a barrier in the k3po script, it added the filters properly.

if I have several accepts with just different paths, they would have the same value for the externalUri.

There is no such thing as paths at tcp level, so I think this should be ok... There is only ip and port.  Did you mean different domain names?  If so, the domain names resolving to different IP addresses should be ok
I'm also ok with you populating the map with all the alternates,  that would work as well

I also ran the HttpHandshakeTimeoutIT.httpHandshakeTimeoutKillsSlowSession test in debug mode in its current format, and even though the test passes, it does not add any handshake filters (not the TCP one, neither the http ones). When it had a barrier in the k3po script, it added the filters properly.

I'm not sure how that could happen?    Did you wire shark it, if there is no response from HTTP then the filter must of kicked in.  If it didn't can you debug the path it went down to see why it didn't kick in?

Relevant quote from the conversation with David on Slack:

The idea with the conflict resolution was that at configuration time/startup you know what values were user set, but you don’t have a way to retain that information through the resource address to where they are actually being used in the transports.  To get around this, you could convey the information of whether they were user set or not by defaulting the values until latter in the process when the transport is being setup, and instead keeping them as null if they are explicitly set in the config .
Also, I would suggest we initially introduce this as a Feature switch in the first iterations,  See the EarlyAccessFeatures classes Chris as added.

I did some more debugging with the WsnHandshakeTimeoutIT, set a conditional breakpoint in HttpAcceptor, line 280, with the condition:
address.getExternalURI().equals("http://localhost:8001/").
I am attaching a print screen with the comparison between the stack traces for the resource address with the value:
[http://localhost:8001/ (http://localhost:8001/) ws/rfc6455]  [tcp://<IP_ADDRESS>:8001 (tcp://localhost:8001) http/1.1]  [tcp://[0:0:0:0:0:0:0:1]:8001 (tcp://localhost:8001) http/1.1]
In the case from the left, the handshake.timeout value is correctly set to 6000 millis but in the case from the right it is overridden with the default value of 10000.
It is not clear to me why this happens.
I am assuming that if I configure the default value as you suggested above, this would not be a problem anymore. I will do this now, but I wanted to understand why the value is being changed.
Any information on this would be most useful.

Take a look at the call stack, and set an expression for address.getOption(HANDSHAKE_TIMEOUT).longValue().  You can see that the 10 is being set when ws is binding http which is binging ws which is binding http.  This is the WSX case and the values for ws are perhaps not getting passed between layers.
I'm not sure if the alternates will work for this case or not, or if the resources addresses with the comparators will work in the map.

@dpwspoon I committed my changes with the conflict resolution for the http layer.
For the moment, I ignored the WsnHandshakeTimeoutIT test, since if I use the test.wsn.handshake.timeout as it is now, the test fails (attaching log).
If I remove the line with 'closed' from the k3po script, the test passes, but it throws some exceptions and the sessions are not closed by the handshake filters. Attaching log.
What would be the best approach to fix this ?

I don't see any byte traffic on the wireshark going, nor in the gateway log.  It's interesting that the following is in the log
1092 transport.http.accept [New I/O worker #1] TRACE accept  - Setting handshake timeout of 6000 milliseconds on http session (#00000001: kaazing niosocketchannel, server, /<IP_ADDRESS>:54644 => /<IP_ADDRESS>:8001)

What I think is happening is 1) that you don't have an write close in the http script.  This is the equivilant to a flush.  So the http headers never make it on the wire.  2) Because http is the only thing bound on the server socket we can route it immediately to the http layer, that is printing the log message above, I suspect if an ambiguous protocol (perhaps another http binding, but for sure TLS) was bound on the same tls port, then the empty tcp connection would not get routed to the http layer and this log message would not appear.  3) The TCP connection is then closed by the http layers timeout, and the script returns saying it never really completed the writes.
I would suggest a fix would be to write the request in tcp robot script.
Also, a positive test to show that it doesn't kick in when websocket handshake completed should be added ;-)

If I remove the line with 'closed' from the k3po script, the test passes, but it throws some exceptions and the sessions are not closed by the handshake filters. Attaching log.

When I remove the closed the test passes.  Because the test passes the log is not written to the console.  How did you get the log?
Also, what you are seeing in the log doesn't match up with what I'm seeing on the wire from wire shark as there isn't a 404 so something odd it going on here.  Hopefully the above response is helpful enough.

@dpwspoon
As per your suggestion, I changed the robot script to connect to TCP and this fixed the problem.

When I remove the closed the test passes. Because the test passes the log is not written to the console. How did you get the log?

For testing purposes, I modified the MethodExecutionTrace.succeeded() method and added the line: MemoryAppender.printAllMessages();
but I did not commit this change.

@dpwspoon I had a question regarding your suggestion to initially introduce this as a Feature switch. The filters for killing the slow session handshakes are added on several layers and in different methods that are called several times throughout the functioning of the gateway. One approach would be to check if the feature is enabled within each layer, but that would imply too many checks per layer. Do you have any suggestion for a better approach ?

Does a handshake Timeout of 0 mean there is no timeout value (I assume we need something like this).  If this is not in the requirements doc we should add it.  If this is the case one option would be to set all the values to 0 at start up (See Accept / Connect Options Context).  Another option would be to do it at each layer where the filter gets added.

@dpwspoon I implemented this as an Early Access feature and pushed my changes. I also solved some merging conflicts with the gateway's develop branch.
I also added the filters for closing slow wsx handshakes. I saw that the WsxExtensionsNegotiationIT uses the should.negotiate.extensions.in.wrapped.request script to test the wsx handshake. I think I should use a similar approach, but I'm not sure exactly what the http request that is wrapped in a ws frame should look like.

This spec describes httpx and has examples of how httpx looks.  httpx is wsx essentially, and shows the wrapped response


Feature Request: Expansion Panel

Specification given here:
https://material.google.com/components/expansion-panels.html#
Continued from https://github.com/mseemann/angular2-mdl/issues/116

@mseemann Can I claim this one? I'd like to work on this one.

Yes. Please!

@abdulqadir93 thx a lot! the package is now released and the demo is available. If you have update for your component please create a pr and increase the version number in the package.json file.

@abdulqadir93 I have updated the master to be compatible with angular4. It looks ok but it seems the auto height calculation for the expansion panel is no longer working. can you take a look what's wrong there? thx a lot!

@abdulqadir93 it would also be great if you could checkout this https://github.com/mseemann/angular2-mdl-ext/issues/483 issue.


CVSS3 errors in integration test logs

uwsgi_1              | [14/May/2021 08:34:51] ERROR [dojo.models:2126] Can't compute cvssv3 score for finding id 5. Invalid cvssv3 vector found: 'CVSS:3.0/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:HCVSS:3.0/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H'. Exception: Malformed CVSS3 field "A:HCVSS:3.0"

Could indicate some problems, does the UI accept invalid entries?

the validation of this attribute is a mess.
the regex is wrong if you take a look a the model attribute.
which parser was used for this data?

it's entered into the UI during integration tests

ok.
I remember the JS part on this field was modified not long ago.
I guess it's this part:
        # cvssv3
        driver.find_element_by_id("id_cvssv3").send_keys("CVSS:3.0/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H")


Maximum Projections

Add full maximumprojection option and think about using single button instead of several buttons. Also think of µm or z-slices

This is basically done, but maybe (similar to bounding box and the other symbols on the left) the max. projection could also use a tooltip that shows (+- X slices or full stack).


Authentication, status, and secrets spec definitions are reviewed

Please review the following, with the goal of identifying anything that could be defined more clearly or organized better. We already have automation to verify the technical details of the spec; we mainly want to ensure the human-readable parts make sense and that there is nothing surprising / nothing that stands out as odd or missing in the spec definition.
In openapi.yml:

Review the tags and how the paths are organized by tag to make sure the groupings are sensible in openapi.yml
Review the ref names for the paths in openapi.yml to make sure the referenced component path makes sense for each endpoint
Review the schemas in openapi.yml to make sure their definitions are correct and the descriptions are clear
Review the responses in openapi.yml - are there any missing that you are surprised are not there?

In each of the files authentication.yml, status.yml, and secrets.yml:

Review the summary and description for each path to make sure the descriptions are clear and correct
Review the operationId for each path to ensure it makes sense - these will become client methods
Review the parameters for each path - is anything surprising?
Review the responses for each path - is anything surprising?
Do you know of any recent changes to the endpoints in this file that should be reflected in the spec but aren’t yet?

Please open up a PR for any minor tweaks you’d like to propose, but otherwise feel free to list suggested changes as a comment in this issue.

@izgeri not really sure what this is - https://github.com/cyberark/conjur-openapi-spec/blob/main/spec/openapi.yml#L135. is this the response for the inject client cert or just an example? if it's the response for the inject cert request then a better text will be "The certificate injection request was accepted.". But i must say that i don't really understand how to review this file.

here you say ... the authenticated user lacks the required privileges to enumerate this resource .... in this case won't we respond with 403?

what's the difference between Authenticate and AuthenticateService?
Also - we have some response code that are not documented:

403: The user is not authorized to authenticate with the given authenticator
504: The OAuth provider discovery reached a timeout (relevant for OIDC, GCP and Azure)
502: The OAuth provider discovery failed or the provider's certificate fetch failed (relevant for OIDC, GCP and Azure)
503: Concurrency limit reached while the server tried to retrieve OAuth provider certificates (relevant for OIDC, GCP and Azure)

@orenbm I have a PR to change Authenticate to be just the default authenticator (no service_id) and AuthenticateService to be the custom authenticators that use this route
I'm not sure this is the right approach - I agree these two routes seem duplicated.
If it would help to have a short call next week to look at the spec together, we'd be very happy to do that - I want to make sure you are able to give good feedback and that you'll know how to work with this file in the future!


chore(replica_stat_rpc): update protobuf

bors merge

bors try

bors cancel

bors merge

bors merge

bors merge

bors merge

bors merge


Include newest DIA-NN version (1.9.2)

Description of feature
Apologies if I'm directing my query to the wrong place, but I was wondering whether there is any plan to allow the newest version of DIA-NN (1.9.2) in the DIA pipeline as I understand currently 1.8.1 and the beta of 1.9.1 are available:
diann_version = '1.8.1'  // Possible versions are '1.8.1', '1.9.beta.1'
I know 1.9.2 came out quite recently, so I don't mean to push :)
I think QuantMS could save us an awful lot of work, so thanks a lot!

Thanks, @lcynwoods currently, we can't distribute the diann 1.9.2 docker or singularity. We are trying to figure it out what will be the best way to include it. Meaning, that we will need to provide not only the version by also the path to the singularity or docker container.
In addition, 1.9.2 will not be able to be tested in the CI/CD because we can not make public a docker or singularity container. We will try to look for a solution and go back to you.

Thanks a lot!

@daichengxin @jpfeuffer :
We can support the 1.9.beta.1 and 1.9.2 differently than we are doing now. Instead of providing us with the container docker or singularity. In these cases, the user has to give the image for the workflow to run. It could be as a parameter or in a config file. What do you think, have you seen this before in nf-core?

Yes. Config file only please.
Introduce label for all processes that use DIANN.
Then the config will just be
withLabel "DIANN" {
process{
container=your own stuff
}
}

Fantastic. Got it similar to this PR: https://github.com/bigbio/quantms/pulls for OpenMS nightly updates.

I will use this issue to trace some of the issues realted with movement to 1.9.2 DIANN. The current method:
  diann   --f RD139_Narrow_UPS1_0_1fmol_inj1.mzML --f RD139_Narrow_UPS1_0_1fmol_inj2.mzML --f RD139_Narrow_UPS1_0_25fmol_inj1.mzML --f RD139_Narrow_UPS1_0_25fmol_inj2.mzML \
          --lib report-lib.predicted.speclib \
          --threads 4 \
          --out-lib empirical_library.tsv \
          --verbose 3 \
          --rt-profiling \
          --temp ./quant/ \
          --use-quant \
          --quick-mass-acc --individual-mass-acc \
          --individual-windows \
          --gen-spec-lib \
           \
          2>&1 | tee assemble_empirical_library.log

When running diann 1.9.2 the library file is not available. Error:
Missing output file(s) `empirical_library.tsv` expected by process `NFCORE_QUANTMS:QUANTMS:DIA:ASSEMBLE_EMPIRICAL_LIBRARY (PXD026600.sdrf)`

I check all the files in that folder and it looks like the output now is different:
drwxr-xr-x 3 root root     4096 Nov 18 18:34 .
drwxr-xr-x 3 root root       44 Nov 18 18:34 ..
-rw-r--r-- 1 root root     4205 Nov 18 18:34 assemble_empirical_library.log
-rw-r--r-- 1 root root        0 Nov 18 18:34 .command.begin
-rw-r--r-- 1 root root        0 Nov 18 18:34 .command.err
-rw-r--r-- 1 root root     5109 Nov 18 18:34 .command.log
-rw-r--r-- 1 root root     5109 Nov 18 18:34 .command.out
-rw-r--r-- 1 root root    11981 Nov 18 18:34 .command.run
-rw-r--r-- 1 root root     1225 Nov 18 18:34 .command.sh
-rw-r--r-- 1 root root      272 Nov 18 18:34 .command.trace
-rw-r--r-- 1 root root  1247671 Nov 18 18:34 empirical_library.parquet
-rw-r--r-- 1 root root        1 Nov 18 18:34 .exitcode
drwxr-xr-x 2 root root      204 Nov 18 18:34 quant
lrwxrwxrwx 1 root root       92 Nov 18 18:34 RD139_Narrow_UPS1_0_1fmol_inj1.mzML -> /srv/data/quantms/work/07/ed17bc07f791e76712d5747a350021/RD139_Narrow_UPS1_0_1fmol_inj1.mzML
lrwxrwxrwx 1 root root       92 Nov 18 18:34 RD139_Narrow_UPS1_0_1fmol_inj2.mzML -> /srv/data/quantms/work/31/992e894d7fa5a9584bddb586b29fdd/RD139_Narrow_UPS1_0_1fmol_inj2.mzML
lrwxrwxrwx 1 root root       93 Nov 18 18:34 RD139_Narrow_UPS1_0_25fmol_inj1.mzML -> /srv/data/quantms/work/79/caba07cdf080e9f2c2d05ff183079b/RD139_Narrow_UPS1_0_25fmol_inj1.mzML
lrwxrwxrwx 1 root root       93 Nov 18 18:34 RD139_Narrow_UPS1_0_25fmol_inj2.mzML -> /srv/data/quantms/work/04/5c99f3e7ad745debbef99a2db1b120/RD139_Narrow_UPS1_0_25fmol_inj2.mzML
lrwxrwxrwx 1 root root       85 Nov 18 18:34 report-lib.predicted.speclib -> /srv/data/quantms/work/15/03d5c8f3ce22114046054fb1eda1f0/report-lib.predicted.speclib
-rw-r--r-- 1 root root     3139 Nov 18 18:34 report.log.txt
-rw-r--r-- 1 root root  2641195 Nov 18 18:34 report.parquet
-rw-r--r-- 1 root root     1038 Nov 18 18:34 report.stats.tsv
-rw-r--r-- 1 root root 16698391 Nov 18 18:34 report.tsv
-rw-r--r-- 1 root root       75 Nov 18 18:34 versions.yml

Is the output of diann --out-lib always parquet now, even if the file provided is tsv: empirical_library.tsv


Time Out (break from whatsapp)

As a user, I would like to take time off from interacting with Whatsapp Web, without closing or hiding the browser window. The reason for not closing the window is I want quick access to whatsapp, especially when I put my phone in airplane mode.
How to activate
Click on Zen Menu --> Time Out
What happens
The entire content of the Whatsapp window disappears. No conversations list, no current conversation, no zen menu.
Instead, you see a calm high res image of a beach, and a countdown timer.
The countdown timer starts at 30:00 (minutes) and counts down towards zero.
There is a small button titled "Snooze (30m)", that simply adds 30 minutes to the current timer.
There is a small button titled "End break", that ends the break completely and returns to normal whatsapp.
When the timer reaches 0, the break ends as well.

How to activate
42.1 Click on Zen Menu --> Time Out
What happens
42.2 The entire content of the Whatsapp window disappears. No conversations list, no current conversation, no zen menu.
42.3 Instead, you see a calm high res image of a beach
42.4 Countdown timer.
42.5 The countdown timer starts at 30:00 (minutes) and counts down towards zero.
There is a small button titled "Snooze (30m)", that simply adds 30 minutes to the current timer.

42.6 There is a small button titled "End break", that ends the break completely and returns to normal whatsapp.

42.3 Should the background of the 'Time Out' window be animated or is a static picture enough?

42.6 If you clicked on background that’s makes same as “End Break” button?

42.1 When ‘Time Out’ is activated all sounds on Tab muted?

@FrenkiBeggins  answers:

42.3 Should the background of the 'Time Out' window be animated or is a static picture enough? static

42.6 If you clicked on background that’s makes same as “End Break” button? No. That does nothing

42.1 When ‘Time Out’ is activated all sounds on Tab muted? Yes

42.7 Okay. But.. If “Smart Mute” is ON and voice message DOES NOT play, then should we mute all sounds? if smart mute is on it should stay on , I won't play and voice message so no problem.


make sudo handling optional

Handling the sudo rules in this module may conflict with whatever people using this module use to handle sudo on their end. We should make sudo rule handling optional, though the default should be to keep current behavior.
This sort of references #205

closed by #250