Adds tap-to-dismiss per toaster.

I want to resolve #223
This gives the ability to do something like this:
toaster.pop({
            type: 'info',
            title: 'What\'s the call status?',
            timeout: 0,
            tapToDismiss: false,
            body: 'call-toaster-directive',
            bodyOutputType: 'directive',
            directiveData: {
                employee: employee
            },
            onHideCallback: function () {
                $scope.loadCalls();
            }
        });

Which by passing a tapToDismiss in the object sent to the toaster's pop method, you can set a Tap to dismiss on a per toaster basis.

Coverage remained the same at 100.0% when pulling 50fa0ab140a4b660f1cac7fcc37d9a39846e84ba on kagawish:master into 60081f374b42506c9af0eb5d35613bc83509ae6a on jirikavi:master.

Ok, thank you for your comments, I will look into it and try to fix the issues asap :+1:

@kagawish, it would be really great if you could fix the issues so that this feature gets merged into the repo. It's realy an important and useful one.

@Maximaximum I shall do it next weekend then :)

@kagawish, did you have any prgress here? :)

@Maximaximum I went ahead and made this change and it is included in npm release 2.1.0.  I forgot to tag this conversation, which is why you were not aware.  That said, https://github.com/jirikavi/AngularJS-Toaster/issues/223 is now closed which is the parent issue for this pull request.

@Stabzs, yes indeed the feature now works! Thank you. @kagawish sorry for disturbing, please igonre this.
@Stabzs, could you please also create a github release? I'm using bower as a package manager, so currently I'm just using the latest repository codebase version, not a release one.

@Maximaximum fair enough :).  It has been created as release 2.1.0: https://github.com/jirikavi/AngularJS-Toaster/releases/tag/2.1.0

@Stabzs Thanks a lot for your work!

@Stabzs Thank you very much and sorry for not being able to do it. Again thank you :)


Nightly K8s Matrix CI 2024-06-17: Failed

action url: https://github.com/spidernet-io/spiderpool/actions/runs/9542978269

debug


Add conf.json wiki page

Include what each exec order does.  Policies for rolling deploy and what not (we'll decide on this part later)

Could I get direction on how to use the conf.json? I have henchman and modules built. Looking to use this for a simple deployment soon.

There is a default config.json loaded by default.  Are you using modules you built yourself?

No just copying the built modules to a different directory for use in our company deployment repos. I get the errors ERRO[0000] Error Validating Modules Dir                  error=stat modules: no such file or directory mod path=modules. Really just need to know what the syntax is for setting the module path.


Improve model

Improve model (specially names) to avoid ambiguous names (like domain)

Mode changed, the webservice domain is now called realm


vscode can not respond to keyboard

when open two or more vscode apps, vscode can not respond to keyboard strikes.
it happens also when only one vscode is running.

Can you give some more details about exactly what you see? A screen recording might help


Make Vitest stubEnv() work with SvelkeKit $env/dynamic/public|private

Describe the problem
As developer I want to stub dynamic env-variables in my Vitest tests, so I can test the app with different env-settings.
https://vitest.dev/api/vi.html#vi-stubenv
Example
.env
FOO=bar

src/lib/config.ts
import { env } from '$env/dynamic/private';

export function getConfig() {
	return env.FOO;
}

src/lib/config.test.ts
import { vi, describe, it, expect } from 'vitest';
import { getConfig } from './config';

describe('getConfig test', () => {
	it('it gets config', () => {
		vi.stubEnv('FOO', 'stub');

		console.debug(process.env.FOO);
		const config = getConfig();

		expect(config).toBe('stub');

		vi.unstubAllEnvs();
	});
}

This example is currently not working.
Describe the proposed solution
Currently env-values are copied when the server starts:
https://github.com/sveltejs/kit/blob/9f0617cab5fcdbe2df33c7103ad873d4d318bfc7/packages/kit/src/runtime/server/index.js#L31-L32
Because of this, changing process.env-variables after the server has started will not change the env-values used in the SvelteKit app.
Instead of copying env-values, they could be retrieved via proxy (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy) directly from process.env.
The proxy can then decide if the env-variable should be available (public vs. private).
Alternatives considered
Maybe it is possible to stub env-variables before the server starts.
Importance
would make my life easier
Additional Information
No response

I've been trying to figure out how to use stubEnv with my sveltekit app to no avail. I'd love for this feature to be made available 🙏🏻

This would be a very useful feature indeed!


DASHBUILDE-64, DASHBUILDE-73, DASHBUILDE-111

Hi @dgutierr Here is the ELS 2.x upgade and some bug fixings. Thanks!

DASHBUILDE-64: ElasticSearch upgrade to version 2.1.2.
DASHBUILDE-73: Some ELS tests fails on MAC.
DASHBUILDE-111: Some ELS tests fails on different time zones.

Hi @dgutierr please NOT merge yet please, found an issue running the webapp. Will provide a new commit when fixed.

I didn't get your latest comments and merged into master.
@romartin Can you push the PR again with the fix you mention and the tweak suggested by Petr?

Hi @psiroky , refactor done, you're right I didn't realize sorry. Added new commit ae9ab670317bd1ffe6d88b43749faa5556fdaaba
@dgutierr can you please review and merge this one? If so, this PR can be closed. Thanks guys!

+1

Merged.


Keyplane change need one more tap to proceed

Looks like typing on the simulator, on the very fresh simulator (iOS11) pause on keyplane change due to one more element to tap to proceed (see screenshot). This screenshot was taken when I tap some letters and tried to type the first number.
https://github.com/google/EarlGrey/blob/master/EarlGrey/Core/GREYKeyboard.m#L228

Xcode: Version 9.0 (9A235)
Simulator: iPad Pro (2nd generation)

If anyone knows of a magical environment variable or define that disables tutorials in iOS, that would be the place for it. Otherwise we could open a DTS to ask, or just (worst case) check for that state specifically.
Digging into UIKit, -[UIGestureKeyboardIntroduction showGestureKeyboardIntroduction] is responsible for this UI, so likely we can also swizzle it away.
It seems to be called by -[UIKeyboardLayoutStar showGestureKeyboardIntroductionIfNeeded]
There's also [UIKeyboardLayoutStar shouldShowGestureKeyboardIntroduction]
This checks if the bundle ID is com.apple.purplebuddy and prevents showing in that case... but that's really not an option (also, wth?)
It also queries the UIKeyboardPreferencesController, but seems a bit tricky to store that:
  if ( objc_msgSend(*(void **)((char *)&self->super.super._safeAreaInsets.var3 + 1), "keyboardAppearance", v2) == &stru_68.segname[7] )
    return 0;
  v3 = +[UIKeyboardPreferencesController sharedPreferencesController](
         &OBJC_CLASS___UIKeyboardPreferencesController,
         "sharedPreferencesController");
  v4 = objc_msgSend(v3, "preferencesActions");
  if ( !(unsigned __int8)objc_msgSend(v4, "boolForPreferenceKey:", UIKBInputGesturesEnabled[0]) )
    return 0;

I'd just swizzle -[UIKeyboardLayoutStar showGestureKeyboardIntroductionIfNeeded] to fix it.

maybe this is the setting
[[TIPreferencesControllerClient sharedPreferencesController] _configureKey:@"DidShowGestureKeyboardIntroduction" <EMAIL_ADDRESS>defaultValue:@(NO)];

Filed Radar http://openradar.appspot.com/34634970 - dupes welcome.

Thanks for bringing this up @krzyzanowskim. We could also add that as part of EarlGrey's Automation Setup where we disable amongst other things, Predictive Text and AutoComplete.


Add basic UI

In this milestone, I performed the following requirements 👩💻:

Create a class App that has the following methods:

List all books.
List all people.
Create a person (teacher or student, not a plain Person).
Create a book.
Create a rental.
List all rentals for a given person's id.

Create a method called main to:

Present the user with a list of options to perform.
Lets users choose an option.
If needed, ask for parameters for the option.
Have a way to quit the app.

Thanks @1GORDON . I have made the changes.


Look into removing RGB vipc streams

Debayer straight into yuv, use opengl shader in ui to convert to rgb. Should save some GPU memory bandwidth.

The thumbnails are now created using the YUV stream (thanks to @deanlee!), so all that's left is using the YUV stream in the UI.

UI already  uses the YUV buffer. #24452 will debayer straight into YUV.


More data in lists

When watching a list, i would be happy if i could see my score in "completed", "in progress" and "on hold" lists but in "planned" to see the general score.

As of release 2.1, you can see detailed general information in the "Details" tab when you view a title.


Where is the pdf file generated by the execution option --pdf

I cannot find the CSFG pdf file generated by the script. Sorry of this is a silly question but I looked everywhere. Where is it supposed to be? Thanks!

It's found on the pdf-generator branch. Seems like the --pdf option has made it's way into the README, I'll remove this as PDF isn't available yet.


Upgrade to React 16.

Coverage remained the same at 58.354% when pulling f6a87ba60389607a1fd301173a8e0dbe67775ca7 on upgrade-react-16 into 96b25424defffd9703854f422583b63f1170ed3d on master.


Simple Chat: Server-Side "Never Logged into this device before" message retrieval

Make sure that when a user logs into a new device, they are able to make sure that all previous chat windows are accessible.

Completed by Mai


ConfigurationExtension does not actually build a list of validators associated with a model.

If I understand your code correctly, one of the purposes of the ValidationConfigurationFluentValidationExtensions is to determine ALL the types of validators that associated with particular entity Type.  You are storing the associated Validator Types in a List but from what I can tell, your code will only identify one Validator Type, the one associated with the entity model itself, but none of the validators that might be associated with the entity model's properties.
I think that you have to walk the object graph to get all the validators involved.

The validation profile for the class is supposed to create a rule for the member telling FluentValidation to use a specific validator.
Please correct me if I am wrong, but I believe that's how it works.


Typescript type checks passing a callback with non-optional parameter for optional one, but throws error at runtime

TypeScript Version:  2.4.1
Code
function f(callback: (a: string, b?: string) => void) {
    callback("a", undefined);
}

f((a: string, b: string) => {
    console.log(a.length, b.length);
});

Expected behavior:
Compile error with when compiled with the strict flag.
(a: string, b: string) => void is not a subtype of (a: string, b?: string) => void as string is not a supertype of string | undefined, I expected a compile error.
Actual behavior:
Compiles, but throws error at runtime
console.log(a.length, b.length);
                       ^

TypeError: Cannot read property 'length' of undefined
    at /Users/Ali/test.js:11:28
    at f (/Users/Ali/test.js:3:5)
    at Object.<anonymous> (/Users/Ali/test.js:10:1)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:389:7)

When you include the type annotations, TypeScript evaluates the assignability of the parameter types.  string is a subtype string | undefined, therefore b is assignable to b.  If you omit the parameter type annotations, type inference works and the last example errors as expected with strictNullCheck:
function f(callback: (a: string, b?: string) => void) {
    callback("a", undefined);
}

const cb = (a: string, b: string) => {
    console.log(a.length, b.length);
}

f(cb);

f((a, b) => {
    console.log(a.length, b.length);
});

I'm new to TypeScript, but I expected that when determining if a function is a substitute for another one, its parameters should be more general (contra-variant on input parameters and co-variant on the output). Why TypeScript does not adhere to this rule?

TypeScript contravariance and covariance of arguments is likely the biggest issue with TypeScript that doesn't have a clean solution.  There are several issues open for this and the conversations is rather extensive and exhaustive.  Needless to say, it isn't like other type systems.
The FAQ does a decent job of covering off how the type system behaves.  This sort of falls under Why are functions with fewer parameters assignable to functions that take more parameters.
I will admit I only have semi-good grasp of covariance/contravariance.  I am sure some of the core team though can explain it better than I and why it is the way it is.

Following on from @kitsonk - The part of the FAQ which explains this behaviour is why-are-function-parameters-bivariant

Thanks for providing the link to the FAQ.
I'm not quite sure if I follow the reasoning why function parameter checks are bivariant. This leads to unexpected behavior for function substitution, even for the ones that do not take polymorphic generic types.
Arrays are a problem in every language, it is a pain to make them invariant, but making them covariant make the type system unsound. How about separating typing rules for function substitution and function calls?

keep arrays covariant for function calls and assignement. So Dog[] can be passed to f(animals: Animal[])

make function types contravariant on their input parameters and co-variant on the return types. I'm not sure how it will play out with array types, but making them contra-variant in the following example makes sense.

f((animals: Animal[]) => {

});

function f(g: (dogs: Dog[]) => void) {}

Thanks for the link to the FAQ. I was a bit confused, I guess structural typing adds another level of complexity.
For return values of functions, do you consider them only co-variance. Is it true?

@afroozeh correct. Return values are treated as co-variant.
interface Pet {
    feed(): void;
}

interface Cat extends Pet {
    purr(): void;
}

declare function getPet(): Pet;
declare function getCat(): Cat;

const p : Pet       = getCat(); // type 'Cat' is assignable to type 'Pet'
const gC: () => Pet = getCat;   // type '() => Cat' is assignable to type '() => Pet'

const c : Cat       = getPet(); // ERROR: Type 'Pet' is not assignable to type 'Cat'
const gp: () => Cat = getPet;   // ERROR: Type '() => Pet' is not assignable to type '() => Cat'

@afroozeh I stand for your point. And @kitsonk , I think the issue here has nothing to with the length of the parameters, but with the type of the parameters. I will show you how the tsc confuses itself when it comes function type assignments.
First, let's see when it does the right thing:
// the wrapper function ensures tsc doesn't infer the real type of strOrUndefined beforehand.
function wrapper(strOnly: string, strOrUndefined: string | undefined) {
    strOnly = strOrUndefined; // error, because undefined is not assignable to string
    strOrUndefined = strOnly; // fine, because string is subtype of string | undefined
}

But there is a way to trick the compiler failing to detect the error of strOnly = strOrUndefined;. But the compiler should not fall for the trick:
// the wrapper function ensures tsc doesn't infer the real type of strOrUndefined beforehand.
function wrapper(strOnly: string, strOrUndefined: string | undefined) {
    // strOnly = strOrUndefined; // error, because undefined is not assignable to string
    const func1 = function (str: string): void {
        strOnly = str;// NO ERROR! but str actualy points to strOrUndefined!
    }
    const func2: (str: string | undefined) => void = func1;

    func2(strOrUndefined);// what actually got executed is func1(strOrUndefined);
}

Obviously, there is a problem here. And the problem lies on const func2: (str: string | undefined) => void = func1;. How come?
When we assign (str: string) => void type to (str: string | undefined) => void type, it seems we are assigning string type to string | undefined, but it is not the case at all. We are doing the opposite, we are assigning string | undefined type to string type! This is why things go wrong.
Why are we doing the opposite by this manner? Because when it comes functions, the real assignment doesn't take place until the functions get executed. Let's see what really happened when func2 got executed. func2 got the parameter of string | undefined type BUT used it as string type, as the parameter of func1's type! This is equal to assign string | undefined to string. This is the real problem.


PageSpeed URL control interactions don't merge properly

In one level of .htaccess specify ModPagespeedDisallow * and in a higher level specify ModPagespeedAllow *example.com*, example.com will still be shown as disallowed.

If I understand your description, this is working as intended.
E.g.
htdocs/foo/.htaccess :         ModPagespeedAllow example.com
htdocs/foo/bar/.htaccess :   ModPagespeedDisallow *
Any time a file in foo/bar/ is referenced, the Disallow * will override the .htaccess in foo/

@jmarantz no, the opposite, the disallow in the root, and then the allow in
/foo/.htaccess
On Apr 26, 2016 11:44 AM, "Joshua Marantz"<EMAIL_ADDRESS>wrote:

If I understand your description, this is working as intended.
E.g.
htdocs/foo/.htaccess : ModPagespeedAllow example.com
http://example.com
htdocs/foo/bar/.htaccess : ModPagespeedDisallow *
Any time a file in foo/bar/ is referenced, the Disallow * will override
the .htaccess in foo/
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/pagespeed/mod_pagespeed/issues/1294#issuecomment-214784962

@jmarantz I'm having trouble understanding 	07c1fcc: is it that you thought this might have been a bug in MergeOptions, and you created a unit test to elicit the bug, but the unit test passed?

Reproduced:
mod_pagespeed_test/
  issue1294/
    .htaccess: ModPagespeedDisallow *
    subdir/
      .htaccess: ModPagespeedAllow *foo*
      foo.js: document.write("hello ");
      bar.js: document.write("world");
      index.html: <script src=foo.js></script><script src=bar.js></script>

When reversing the two .htaccess files we still don't see foo.js get rewritten, so it's not just handling them backwards or something.

I cannot reproduce this using what Josh checked in above; "ModPagespeedAllow purple" still works just fine. If I comment out the entire Allow in the override dir, the test fails.

The test @hillsp was referring to as "what Josh checked in above" was https://github.com/pagespeed/mod_pagespeed/commit/4d3acd9cd3c5b9a573da9b0627da6475d3feb97b plus https://github.com/pagespeed/mod_pagespeed/commit/6b0cd0c3aae30a7cd733d7e0196446e52944bd8c

Hypothesis is that .htaccess merging works correctly in the ipro flow but not the html flow.

Turns out that this is a problem with FastWildcardGroup and isn't related to the merging at all. @jmaessen has a fix.


Make Trello's oauth integration work like the rest

Riight now it has it's own flow that is much harder to do/understand

marking low bc im taking trello out of the catalog for now


Conflict with preciousstone

Hey!
I have a small problem and I want to know if it can be fixed.
At the moment my pc cannot attack a player if it is under the protection of preciousstone.
I would like to know if something can be done to attack players even if the protection is anti-pvp

This is in the readme under the common issues section https://github.com/mcmonkeyprojects/Sentinel#common-issues


Visualize pathways

Added UpSet plot to compare shared pathways between clusters
Added ways to retrieve shared pathway name and Reactome ID between clusters

You can see here the color used now. I've tried to match it with Reactome color. However, if you prefer another color as default, I can change to any one of these .

This is great. Thanks for putting it together. Go ahead and merge.
All the best,
_Nasim

On Aug 3, 2021, at 5:28 PM, Meirelles_JL @.***> wrote:

You can see here the color used now. I've tried to match it with Reactome color. However, if you prefer another color as default, I can change to any one of these .
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Suggestions for a Code of Conduct

It's been brought to my attention we haven't formalized a code of conduct for our community. I'd love to do so and get feedback along the way.

KDE code of conduct is not bad, and it's CC.

I'd also recommend reference to anti-harassment policies: http://geekfeminism.wikia.com/wiki/Conference_anti-harassment/Policy

+1 to the geekfeminism policy examples.

"Booth staff (including volunteers) should not use sexualized clothing/uniforms/costumes, or otherwise create a sexualized [sic] environment."
Regardless of the underlying sociopolitical context, after decades of unshakable hindquarters upon chair placement this can only be a good thing for all concerned. Basho, keeping it classy ™.

FYI to @danieldreier & @binarytemple about the PR: #56

Now that @laurenrother has commented on #56, I feel good about moving it forward. Just an FYI to this thread.

It is done :+1:


annotation reader (s1_annotation.py) - initial implementation

This PR implements the reader for Calibration Annotation Data Set (CADS), and Noise Annotation Data Set (NADS), which was related to the issue #27. This work is in context of implementing thermal noise correction. The structure of CADS and NADS are very similar, so their readers shares similar procedure to read. Therefore the readers are implemented together in s1_annotation.py
Few examples of the usage are as below:
import s1_annotation
cads=calibration('/Users/USER_NAME/DATA/COMPASS/S1B_IW_SLC__1SDV_20210112T014942_20210112T015009_025115_02FD69_DDC9.zip',polarization='VV',subswath=2)
nads=noise('/Users/USER_NAME/DATA/COMPASS/SAFE/S1B_IW_SLC__1SDV_20210112T014942_20210112T015009_025115_02FD69_DDC9',polarization='VV',subswath=1) #can assign a SAFE directory

cads.IPF_version #'003.31' for example. Also works for nads
cads.list_gamma

nads.rg_list_NoiseRangeLut #Range noise vector
nads.az_line #Range noise vector
nads.az_noiseAzimuthLut #Azinuth noise vector

Notes:

in s1_annotation.noise, the attribues related to range noise vector has prefix rg, and the ones about the azimuth noise vector has az
The information on the annotation are parsed on-the-fly.

Thank you all for valuable feedback. I revised the code as much as I could based on the comments posted here. One last thing I would like to discuss is what data type would be the best for Sentinel1BurstSlc.ipf_version. Please see the the comments below for the detail.
https://github.com/opera-adt/s1-reader/pull/48#discussion_r927925747
I am inclined to packaging.version.Version. for the version information (and accept the suggestion by @LiangJYu ), but any comments and suggestion are appreciated.

Thanks @LiangJYu @gshiroma for the wonderful suggestions and information to improve the code. I think the code is ready to review.

Thank you all for the inputs for this PR. I've updated the branch to date to test it before merging it into the main repo. Looks like pytest in CircieCI is failing, with the error summary below:

=============================================== short test summary info ===============================================
ERROR tests/test_bursts.py::test_burst - KeyError: "There is no item named 'manifest.safe' in the archive"
ERROR tests/test_orbit.py::test_orbit_datetime - KeyError: "There is no item named 'manifest.safe' in the archive"
ERROR tests/test_reader.py::test_burst_from_zip - KeyError: "There is no item named 'manifest.safe' in the archive"

I've taken a look at the test data .../tests/data/S1A_IW_SLC__1SDV_20200511T135117_20200511T135144_032518_03C421_7768.zip, and found that the file manifest.safe is missing in the .zip file.
This PR includes updates on s1_reader.py that reads IPF version from the manifest.safe file. I wonder if someone can commit a new .zip file for the test data that has the file.

I also forgot to ask you to please resolve the codacy issues.
Nevermind. I just noticed you did that yesterday. Thanks!

Thank you all for the inputs for this PR. I've updated the branch to date to test it before merging it into the main repo. Looks like pytest in CircieCI is failing, with the error summary below:

=============================================== short test summary info ===============================================
ERROR tests/test_bursts.py::test_burst - KeyError: "There is no item named 'manifest.safe' in the archive"
ERROR tests/test_orbit.py::test_orbit_datetime - KeyError: "There is no item named 'manifest.safe' in the archive"
ERROR tests/test_reader.py::test_burst_from_zip - KeyError: "There is no item named 'manifest.safe' in the archive"

I've taken a look at the test data .../tests/data/S1A_IW_SLC__1SDV_20200511T135117_20200511T135144_032518_03C421_7768.zip, and found that the file manifest.safe is missing in the .zip file. This PR includes updates on s1_reader.py that reads IPF version from the manifest.safe file. I wonder if someone can commit a new .zip file for the test data that has the file.

I'm working this and will submit a PR to this branch sometime today.

The scope of the fix grew being adding manifest.safe so I issued a new PR to main instead of to your PR. See #58

The scope of the fix grew being adding manifest.safe so I issued a new PR to main instead of to your PR. See #58

Also left a commend on the PR #58, but confirmed that CircleCI passed. Thank you for the update on the unit test!


Rebase on mono/mono-addins main branch

They did a partial swap to .net standard 2.0 in the main repo so this is probably the most easy way to get .net standard into this.
This breaks DotDevelop build but the error can be fixed by updating System.Collections.Immutable to version 6.0.0 in MonoDevelop.AspNetCore so this should not be an issue

@Molytho This is really useful work!  It's always a problem to keep up with ongoing developments in submodules, and from what I've seen recently (Issue 205, 206), it looks as if mono-addins should (soon) work with net6/netstandard2.0.  These issues are still being worked on, so it may be worth waiting to see how they get resolved before updating the dotdevelop/mono-addins fork.  However, you have checked that it's straightforward to fix the dotdevelop build once mono-addins have been updated, which is great.
I'm also wondering if, instead of rebasing the 3 commits that @lytico has added to the current detached HEAD (@7ac9608) it may be more transparent to change the commit used for the submodule to that of the latest mono/mono-addins one, and then create a branch (eg dotdevelop) just for these 3 commits.  That would save adding the 156 commits from the mono repo to the forked one, which would now have just the 3 new ones.  It still means that the fork has to be updated in synchronism with a dotdevelop PR, but the history should be more obvious, I think
wdyt?

@Molytho  The issue that I mentioned above has now been resolved, so it would be good to update your PR to that latest commit and get it merged.
Thinking again about my last comment, which I initially thought might seem to be a clearer approach,  I'm now thinking that this would be re-writing the commit history, and although it might effectively end up at the same point, would not be an 'approved' thing to do!  I don't have a lot of experience in this area, so I'm happy to be advised by you.
It will still be necessary to coordinate the update of this submodule with changing System.Collections.Immutable to version 6.0.0 in MonoDevelop.AspNetCore that you mention.  Are you able to try out the combination of the 2 changes in advance, somehow?  Again, I'd be grateful for any advice on getting this right!

Update is done and tested. Still builds and works fine after the update in AspNetCore.

I don't think there would be an issue merging this, it's mostly a rebase on the original branch, which was released. As for the 3 added commits, it looks like they are going in the right direction.
I would advise to also create a develop branch on this repo, so the main dotdevelop dev branch could use the develop branches of it's submodules to test things before everything is released. Ideally, I would even opt to have those submodules be references via nuget packages, because that makes it easier to select a distinct version.
But for the time being, I would merge this. great work @Molytho!

@gluckez Would you base the develop branch at the current detached HEAD position - @7ac96087d7 - where the dotdevelop_gtksharp branch is based (fortunately there is no develop branch in the upstream  repo)?

@hwthomas I would base it on master, after this pr is merged. or maybe even better, use this repo as a testing branch before requesting a merge upstream. it seems like that one is still being maintained anyway, so why not use it instead of having our own version. but that's just my opinion.

@gluckez  I'll merge this PR, and then create a develop branch in this fork of mono-addins.
Should updating  System.Collections.Immutable to version 6.0.0 in MonoDevelop.AspNetCore.csproj  need a separate PR in the dotdevelop repo, or could this just be a "Fix Build" commit in the code?

I think this is because the submodule in dotdevelop still references the old commit. We have to update it with "git submodule update --remote main/external/mono-addins" followed by a commit. I will open an according PR later.

@Molytho : Yes, I think that's it.  I'm away until the weekend, but will try again then.

@Molytho : I'd done the  git submodule update --remote main/external/mono-addins bit, but forgot the commit afterwards, so my 'fresh clone' was using the old submodule content.  Thanks for pointing this out so clearly! - and thanks for doing the PR in dotdevelop as well  I'll close this PR now.


Made Avalonia MapControl's Map property DirectProperty

Made Avalonia MapControl's Map property direct, because it doesn't need styling and thus we can remove necessity to access it in UI thread only.
Using StyledProperty, as it was made in previous PR requires access to Map property through UI thread and it was not really good idea.
DirectProperty, on the other hand, allows us to use existing Map property without any modifications.
(More details can be found here)
Removed databinding from sample, because it needs a little bit more advanced DI to use (currently we assign DataContext after construction, but constructor needs ViewModel's Map property to initialize)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Konst Kolesnichenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow joining multiple channels with one instance

I see lots of use cases that involve being able to communicate in multiple channels with one Bot Instance, for example for long-term data analysis of chats in specific channels.
I can provide a PR if you like.

Hi @anXieTyPB,
I remember originally thinking about this idea, but not deciding on it for some issue I can't seem to remember, regardless though this would be a cool optional feature. I don't have enough time to work on this project at the moment, so if you'd like to do a PR that would be great! 👍
I imagine the syntax as the following:
const Bot = new TwitchBot({
  username: 'Kappa_Bot',
  oauth: 'oauth:dwiaj91j1KKona9j9d1420',
  channels: [
    'twitch',
    'kappa',
    'lirik'
  ]
})

Perhaps a hard cap on the multiple connection instances (no. of channels connected per IRC instance) as well (e.g. 5-10?), but I'll leave that up to you 😄

Can you give permission to push a new branch?

It would be easier if you could fork the repository, make your changes in a new branch, then do a pull request 👍

Pull request merged: https://github.com/kritzware/twitch-bot/commit/4c81915717a719325f7faa3f32c356d2ac8dc174


cygstart equivalent

With Cygwin, cygstart wraps the ShellExecuteW function
https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shellexecutew
cmd.exe has similar option with start and PowerShell with Start-Process
it seems WSL has no such option

$ cat << EOF > wslstart
#!/usr/bin/env sh
cmd.exe /c start \$@
EOF
$ chmod 755 ./wslstart
$ ./wslstart https://github.com/microsoft/WSL/issues/4287

@therealkenc no, thats not a good idea as it fails with space or ampersand:
http://example.com?aa bb&cc

Alright.
cat << EOF > wslstart
#/usr/bin/env sh
powershell.exe -command \& {Start-Process \'\`echo \$@\`\'}
EOF
$ chmod 755 ./wslstart
$ ./wslstart 'http://example.com?aa bb&cc'

Although that URI mostly has what is coming. Ref #3832 (message) with open LZ #2835.

$ ./wslstart iexplore 'http://example.com?aa bb&cc'

Start-Process method can not use any arguments. And -ArgumentList doesn't match the shell's idiom.
After all it is better to use cmd.exe /c start?
cmd.exe /c start '' "$@"

I was hoping you'd show.

And -ArgumentList doesn't match the shell's idiom.

Maybe...
#/usr/bin/env sh
al=$(echo "${@:2}" | tr ' ' ,)
if [ $al ]
then
  powershell.exe -command \& {Start-Process \'$(echo $1)\' -ArgumentList $al}
else
  powershell.exe -command \& {Start-Process \'$(echo $1)\'}
fi

After all it is better to use cmd.exe /c start?

Yeah. Probably after all....
#/usr/bin/env sh
cmd.exe /c start '' "${@//&/^&}"

PS: I take back that there's no use case for Linux-native Chrome/Firefox on WSL. Its so all the bash and python scripts in the wild that call xdg-open(1) work out of the box......

Is this really what you all are suggesting? A hacky shell script? A standalone tool would be better, like cygstart. that way dont have to worry about any drama with cmd.exe or powershell issues.
i was hoping WSL offered something like open or xdg-open, but failing that i found this workaround:
rundll32 url,OpenURL "http://example.com?aa bb&cc"

Is this really what you all are suggesting? A hacky shell script?

Your hacky script only launches URLs.
#/usr/bin/env sh
rundll32.exe url,OpenURL "$@"

Which wasn't your OP ask. Your OP ask was for ShellExecute(). So, yes.

@therealkenc did you actually test that? or are you just assuming after reading the function name?
Works for me with files and URLs

or are you just assuming after reading the function name?

No; I need not assume anything. Because I know what ShellExecuteW() does. And way rundll32 takes parameters.

@therealkenc perhaps you should actually test it before talking further
it works with URLs and local files

it works with URLs and local files

Yes. Yes it does. Never said it didn't work with both files and URLs. Never even implied otherwise. What I said was I know what ShellExecuteW() does. And that I know why rundll32 takes parameters.
But happy you found an answer to your question either way.

Your hacky script only launches URLs.

I am confused because previously you said this:

C:\Windows\System32\url.dll will eat path strings and does not insists on the file: prefix. But you already know that, as does everyone less confused. At any rate, happy to hear you found a solution to your use case. Even happier that 0xbadfca11 stepped up with a solution to pushing WSL interop args into start, since it has been a common question and now there is a good answer.

will eat path strings and does not insists on the file: prefix. But you already
know that, as does everyone less confused

i am flattered - but maybe i am not that smart
as i dont know what "eat path strings" mean
thank you sir

as i dont know what "eat path strings" mean

Apologies for being terse. That on me. url.dll is not strict about URL syntax. It will parse (eat) the path component string of a file: scheme without the prefix. It's all good.

restoring deleted message:

Apologies for being terse. That on me. url.dll is not strict about URL
syntax. It will parse (eat) the path component string of a file: scheme
without the prefix. It's all good.
https://user-images.githubusercontent.com/7049700/60896072-8b370900-a21a-11e9-91d5-9ad74e9c4900.png

i guess i am a dummy, as I am still not understanding
do you have some example path that gets mangled by url.dll? i know my
workaround is not ideal, but i havent seen any parsing issues myself yet like
i experienced with cmd start.


Updated articles - organization

It would be helpful if the listing of updated articles was grouped/sorted/categorized to make it easier to look for articles of interest. The current presentation is quite random which makes it hard to find updated articles that are relevant to our interests.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0dd7bc22-da10-1d3b-ba22-7d5e374be441
Version Independent ID: 9f466c91-adc7-0489-5b1e-17633d27c98c
Content: What's New in Azure Architecture Center - Azure Architecture Center
Content Source: docs/changelog.md
Service: architecture-center
GitHub Login: @alexhart11
Microsoft Alias: pnp

@DeanGross Thanks for your feedback. We will review and update as appropriate.

Thank you for your feedback.  We have created internal ticket 37544 to track and investigate this issue.

#please-close

why was this closed without any action or explanation? my comment is still applicable


add field city

Coverage remained the same at 63.503% when pulling 52673a05d95e4e5d3a3aea6de6336092b6bb9e41 on indriHutabalian:dev into 4c4f384642938c8c83c717dd815bfa68642f90c2 on danliris:dev.

Coverage remained the same at 63.503% when pulling 5c9ad251905c3bb511669213c14b599a44660c3b on indriHutabalian:dev into 4c4f384642938c8c83c717dd815bfa68642f90c2 on danliris:dev.


Deconstructable trait

This is an example implementation of how the destructors could be turned into a trait, as mentioned in #4
While possible, I'm not sure if this is useful, or has any added benefits on top of #5
Any feedback is appreciated.

Hm, interesting. Thought I agree it might not actually be useful for real-world purposes. 😅

Cool I was about to do this! :+1:
I would make WriteOnlyCommand: Deconstructible to enforce its implementation.
Of course drivers should implement it too. We could technically enforce drivers to be Deconstructible by somehow binding DI functionality to a deconstructible caller but it seems overkill.

@bugadani I don't think this provides any benefit over a good old custom release function which we've added in the just released 0.4.0 version so I'm going to close this now.


Prioritize hypervisor.uri configuration

Description
The KVM Agent has the hypervisor.uri configuration to define the connection with Libvirt; however, this property is ignored and a hardcoded value is used in many parts of the code.
This PR intends to prioritize the hypervisor.uri property in Libvirt connections and use the hypervisor default URI only when this configuration is not defined.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[X] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
I followed the same steps from How did you try to break this feature... and verified that the host was only using the URI defined in the hypervisor.uri property.
How did you try to break this feature and the system with this change?

Add the hypervisor.uri property to a host's agent.properties, hypervisor.uri=qemu:///session for example;
Check the agent logs;
Although the hypervisor.uri property is defined, the agent is still using the hypervisor default URI in many connections;

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7807

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8384)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8254-t8384-kvm-centos7.zip
Smoke tests completed. 118 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@DaanHoogland @weizhouapache do we need third-party testing for this one?

in principle I'd say we always do, but I'm sensitive to arguments why we wouldn't. I think we can only decide on this based on the code and available automatic tests though, never relying on the author. I would appreciate it if you didn't trust my PRs in that respect either.

@DaanHoogland @weizhouapache do we need third-party testing for this one?

Yes @GutoVeronezi
Would you like to test it?

@DaanHoogland @weizhouapache do we need third-party testing for this one?

Yes @GutoVeronezi Would you like to test it?

I can put it on my tasks for the next week.

@DaanHoogland @weizhouapache do we need third-party testing for this one?

Yes @GutoVeronezi Would you like to test it?

I can put it on my tasks for the next week.

cool, thanks @GutoVeronezi
assigned to you then

Hello guys
I did some basic tests with the feature:

without the configuration, the Agent took the default URI; with that, I successfully created a VM, migrated it, and scaled it;
[...]
2023-12-06 19:32:19,539 DEBUG [agent.properties.AgentPropertiesFileHandler] (agentRequest-Handler-2:null) (logid:7626c82c) Property [hypervisor.uri] has empty or null value. Using default value [null].
2023-12-06 19:32:19,539 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-2:null) (logid:7626c82c) Looking for libvirtd connection at: qemu:///system
[...]
2023-12-06 19:32:19,566 DEBUG [resource.wrapper.LibvirtStartCommandWrapper] (agentRequest-Handler-2:null) (logid:7626c82c) starting i-2-9-VM: <domain type='kvm'>
[...]
2023-12-06 19:32:20,961 DEBUG [cloud.agent.Agent] (agentRequest-Handler-2:null) (logid:7626c82c) Seq 4-6525434385083138169:  { Ans: , MgmtId:<PHONE_NUMBER>86676, via: 4, Ver: v1, Flags: 10, [{"com.cloud.agent.api.StartAnswer":{"vm":{"id":"9","name":"i-2-9-VM","state":"Starting","type":"User","cpus":"2","minSpeed":"1560","maxSpeed":"1560","minRam":"(1.00 GB)<PHONE_NUMBER>","maxRam":"(4.00 GB)<PHONE_NUMBER>","arch":"x86_64","os":"Other (64-bit)","platformEmulator":"Other","bootArgs":"","enableHA":"false","limitCpuUse":"false","enableDynamicallyScaleVm":"
[...]

with the configuration, the Agent took the URI I set; with that, I successfully created a VM, migrated it, and scaled it;
[...]
2023-12-06 19:37:23,206 DEBUG [agent.properties.AgentPropertiesFileHandler] (agentRequest-Handler-5:null) (logid:951c7230) Property [hypervisor.uri] was altered. Now using the value [qemu+tcp://<IP_ADDRESS>/system].
2023-12-06 19:37:23,206 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-5:null) (logid:951c7230) Looking for libvirtd connection at: qemu+tcp://<IP_ADDRESS>/system
[...]
2023-12-06 19:37:23,248 DEBUG [resource.wrapper.LibvirtStartCommandWrapper] (agentRequest-Handler-5:null) (logid:951c7230) starting i-2-9-VM: <domain type='kvm'>
[...]
2023-12-06 19:37:24,280 DEBUG [cloud.agent.Agent] (agentRequest-Handler-5:null) (logid:951c7230) Seq 4-5190117095567785998:  { Ans: , MgmtId:<PHONE_NUMBER>86676, via: 4, Ver: v1, Flags: 10, [{"com.cloud.agent.api.StartAnswer":{"vm":{"id":"9","name":"i-2-9-VM","state":"Starting","type":"User","cpus":"2","minSpeed":"1560","maxSpeed":"1560","minRam":"(1.00 GB)<PHONE_NUMBER>","maxRam":"(4.00 GB)<PHONE_NUMBER>","arch":"x86_64","os":"Other (64-bit)","platformEmulator":"Other","bootArgs":"","enableHA":"false","limitCpuUse":"false","enableDynamicallyScaleVm":"

Merging this one based on the approvals and tests results.


Improve code formatting settings Part 2

First part of a story has covered preparation for code formatting settings including plugin configuration to support auto-format code to match google standard.
https://github.com/eclipse-tractusx/item-relationship-service/issues/319
Second part of a story is to format old code base to match current format and change config of maven-checkstyle-plugin to match new format.
After code is formatted this should be changed in checkstyle.xml file:
<module name="Indentation">
            <property name="basicOffset" value="2"/>
            <property name="braceAdjustment" value="0"/>
            <property name="caseIndent" value="2"/>
            <property name="throwsIndent" value="2"/>
            <property name="lineWrappingIndentation" value="2"/>
            <property name="arrayInitIndent" value="2"/>
        </module>

After this change maven build will fail on validate goal if code does not follow google standard.
Also update from @dsmf - please also update PMD rule to match max length of a comment size:

Acceptance Criteria

Old code is formatted to match google java code standard
checkstyle.xml is adapted to new format so any violation of it's rules will result in failed build
update pmd rules to match new code formatting settings

PMD comment maxLineLength was already set to 120 in https://github.com/catenax-ng/tx-item-relationship-service/commit/d87d6aa04ed255c4ac30cec56c56db4407e87073


Enable Envoy sidecars graceful shutdown

Adds the annotation required to all Pods using Envoy sidecars so graceful shutdown of the Envoy server is enabled.
/kind feature
/priority important-soon
/assign

/lgtm

/approve


Add changelog entry for List.filled growable fix

And sort the libraries while you're at it :smile:
https://github.com/dart-lang/sdk/commit/ed0b187d583493432b10aaaac2844f05f4bcce3e
https://codereview.chromium.org/1440663003/

Looks like this was added.


fix: init publicPath to undefined

What kind of change does this PR introduce?

bugfix
Did you add tests for your changes?
If relevant, did you update the README?
Summary
Initializing publicPath to false was preventing the new option from being used with webpack-config-validator

See comment in #145
Does this PR introduce a breaking change?

No
Other information
Fixes #158

It already has two to cover the feature in question, just changing how we init publicPath because of the issue mentioned in the PR that broke it.

Ok, cool. JS. 👍

Any news regarding this bug?

@d3viant0ne  @bebraw Is there anything left to do here/blocking this ? :)

@michael-ciniawsky Not that I know of.

Please semver patch someone when time :)


Module Not Found

I've got this problem when integrate my client to Next JS
`Module not found: Can't resolve 'timers/promises'
https://nextjs.org/docs/messages/module-not-found`

After seeing this...
https://github.com/nodejs/node/issues/39407
I realized in documentation that
This module is built for Node.js and does not currently work in browsers.
But as we know, Next JS provide server rendering. Can this be a solution to use this/your OCPP module?

Maybe its too late if i asking this, but can i build EV Charger simulator (web based) using your module?

But as we know, Next JS provide server rendering. Can this be a solution to use this/your OCPP module?

I am not familiar with Next JS so I cannot assist you with this. The module was not designed to be compatible with Next JS.

Maybe its too late if i asking this, but can i build EV Charger simulator (web based) using your module?

No. You'd need to run the simulator using Node.js and then serve up an interface to control the simulator using an (non-OCPP) API - perhaps also using Websockets if you want real-time communications.

Thanks for your help. Its answering my confusion. Really appreciate for this module😃


[SITE] Label change - "Blocked" status

Please change the label from "Blocked" to "Blocked for Relabelling".

the rest of buttons were not implemented


Fix ResultSet type(FINERACT-995)

FINERACT-995

@vorburger, are you OK with this?
Can't tell for sure if it will fix our problem.
cc: @awasum @ptuomola

@xurror Unfortunately I doubt this will work: MySQL Connector does not support scrollable cursors, so setting ResultSet.TYPE_SCROLL_INSENSITIVE should have no impact.
From MySQLConnector documentation:
MySQL does not support SQL cursors, and the JDBC driver does not emulate them, so setCursorName() has no effect.
I think we need to look at the job that fails and see what could lead to this... and why does Spring throw a TransientDataAccessException - some concurrency issue? Underlying data was modified by another job at the same time?

@xurror @vorburger - I think I found the line that causes it - added the relevant code in JIRA as a comment

@xurror would you be willing to retract this PR in favour of new @ptuomola #1024 ? (And can / would you like to help to co-review that new PR? Please don't merge before we have input from several people.)

No problem


Input errors not show

Hi, first thanks for you respository.
I would like to know why the errors in the entries are not seen in AdminLTE3, I have an example in AdminLTE2 and if they are.

have you check the rules() of model

Yes, in my example I see the error but not with the color red

I'm sorry.
The error was in my _form.php.
It is required to use use yii\bootstrap4\ActiveForm;


common: remove unused GetImageIDs()

This patch removes apps.GetImageIds() method as it has no callers anymore.
This helper was added to pass list of image ids to the state0, but now we
pass list of apps in a pod instead.
Last user of the GetImageIDs() was removed in the 227fe3cc2 commit
(  Move pod registration from stage1 to stage0. by @eyakubovich ) and it is
not used anywhere anymore.
So we can remove it.

Good catch!

ok to test


defaultCountry: "auto" - Failed to load resource

I'm getting the following error when defaultCountry is set to auto
Failed to load resource: the server responded with a status of 401 (Unauthorized)
https://ipinfo.io/?callback=jQuery111208047956700902432_1433756422803&_=1433756422804 Failed to load resource: the server responded with a status of 401 (Unauthorized)
It seems to do with the IP look up and when I go to url I get
SSL access is restricted to paid plans. See http://ipinfo.io/pricing for more details, or contact us via http://ipinfo.io/contact

Hi there.
What version of the plugin are you using?
Are you using the geoIpLookup option?
Finally, the problem is in the error msg - you are hitting the https
version of ipinfo, which you have to pay for.
I'm getting the following error when defaultCountry is set to auto
Failed to load resource: the server responded with a status of 401
(Unauthorized)
https://ipinfo.io/?callback=jQuery111208047956700902432_1433756422803&_=1433756422804
Failed to load resource: the server responded with a status of 401
(Unauthorized)
It seems to do with the IP look up and when I go to url I get
SSL access is restricted to paid plans. See http://ipinfo.io/pricing for
more details, or contact us via http://ipinfo.io/contact
—
Reply to this email directly or view it on GitHub
https://github.com/Bluefieldscom/intl-tel-input/issues/231.

I'mn using International Telephone Input v5.0.1 for the intlTelInput.min.js not seeing a version number just  Protocol Buffer 2 Copyright 2008 Google Inc.
Are you using the geoIpLookup option? -- My understanding is if it's set to auto then it uses the geoIPLookup
Might be a good idea to have some kind of fallback or default setting

If you're using v5 you wont need to use the getIpLookup option - the ip lookup is hardcoded to use a service called ipinfo.io. If you update to v6, you can completely customise how that works.
I'm guessing your website uses HTTPS (which is why the ipinfo.io call defaults to HTTPS), and if you want to use ipinfo with HTTPS you will have to pay, or maybe if you update the plugin to v6 you can find another service you can use that doesn't charge for HTTPS access, but that's outside the scope of this plugin.
I'm going to close this issue for now, but let me know if you have any other questions.

How customisable is it, like can I specify http://ipinfo.io that easily. Has anyone tried this?

You have complete control over the request as you code it yourself using the geoIpLookup function - see the readme.

Ok, but in the source code is there still a var ipinfoURL = "//ipinfo.io"; that defaults to https on production? Curretly, I am specifying http://ipinfo.io in the geoIpLookup method in Version 5.1.6 and it still reverts to using HTTPS via var ipinfoURL = "//ipinfo.io";. Thanks for your replies.

Thanks @jackocnr, fantastic stuff. That update to the source coed really opens up the possibilities.


"Do not reference mscorlib.dll" as an option does not exist

In VS2017, there is no option "do not reference mscorlib.dll" in the advanced dialog as described on this page - https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/nostdlib-compiler-option

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8bdeb7a8-8d77-961f-ce9f-e755fdcf8613
Version Independent ID: 5e7fcc43-1513-7bd3-50cf-87ae435ee062
Content: -nostdlib (C# Compiler Options)
Content Source: docs/csharp/language-reference/compiler-options/nostdlib-compiler-option.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks, @mattcowen. I've added clarification language to the article, as you can only set this option in Visual Studio 2015 and earlier versions. You can see the change in the PR link above.


Authentication Issues with JFrog Container Registry as Fallback for Cloudflare Serverless Registry

Description:
We are currently using JFrog Container Registry license 7.59.12 rev 75912900 as a fallback source for our serverless registry setup.
Issue:
When we disable authentication on JCR, the fallback mechanism works flawlessly. However, once authentication is enabled, we encounter persistent 401 Unauthorized errors, regardless of whether we use a password or a token for authentication.
Code Snippet:
const params = new URLSearchParams({
  service: ctx.service,
  // explicitly include that we don't want an offline_token.
  scope: `repository:${this.url.pathname.slice(1)}/image:pull,push`,
  client_id: "r2registry",
  grant_type: "password",
  username: this.configuration.username,
  password: this.password(),
});

let res = await fetch(ctx.realm, {
  headers: {
    "Content-Type": "application/x-www-form-urlencoded",
    "User-Agent": "Docker-Client/24.0.5 (linux)",
  },
  method: "POST",
  body: params.toString(),
});

Additional Information:
The same authentication logic works seamlessly with Google Container Registry (GCR) and Docker Hub.
We've ensured that the username and password/token are correctly configured and tested them separately with direct API calls.
Why does this code result in a 401 error with JFrog Container Registry, while it functions correctly with GCR and Docker Hub? Could there be specific configurations or headers required by JCR that we might be missing?
Any insights or suggestions would be greatly appreciated. Thank you!

Hello! Thank you for your issue. I will take a look, it wouldn't surprise me if there is an edge-case with our authentication here. Can you confirm if you're using the Cloud/local version?

@gabivlj Hi! Initially, we were using the local version, but then we switched to the cloud version because we were concerned there might be a bug in the local version. However, both versions are exhibiting the same behavior.

Can you show the fallback configuration?

Hello, I fixed the issue. Let me know if this PR works for you: https://github.com/cloudflare/serverless-registry/pull/55
Please, also make sure that the "registry" property includes your namespace in the path as well (only the url doesn't work).

@gabivlj
Thank you so much for your effort in addressing the issue. Unfortunately, the problem still persists. Below is the execution process I followed and the configuration file I am using:
root@athena:~/serverless-registry# docker login r2-registry-production.motofans.workers.dev
Authenticating with existing credentials...
WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credential-stores

Login Succeeded
root@athena:~/serverless-registry# docker login motofans.jfrog.io
Username: cftest
Password:
WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credential-stores

Login Succeeded
root@athena:~/serverless-registry# docker pull motofans.jfrog.io/cftest-docker/netshoot:latest

latest: Pulling from cftest-docker/netshoot
Digest: sha256:33aa60bf25237c743c553ddd9b4c9cd0dd209117876a3b9c4324ef5ffbc78ad5
Status: Downloaded newer image for motofans.jfrog.io/cftest-docker/netshoot:latest
motofans.jfrog.io/cftest-docker/netshoot:latest
root@athena:~/serverless-registry#
root@athena:~/serverless-registry# cat wrangler.toml
name = "r2-registry"

workers_dev = true
main = "./index.ts"
compatibility_date = "2022-04-18"
compatibility_flags = ["streams_enable_constructors"]

[env.production]
r2_buckets = [
  { binding = "REGISTRY", bucket_name = "r2-registry" }
]

[env.production.vars]
REGISTRIES_JSON = "[{ \"registry\": \"https://motofans.jfrog.io\", \"password_env\": \"REGISTRY_TOKEN\", \"username\": \"cftest\" }]"
root@athena:~/serverless-registry# npx wrangler secret put REGISTRY_TOKEN --env production

 ⛅ wrangler 3.78.7 (update available 3.78.10)
--------------------------------------------------------

✔ Enter a secret value: … *************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
🌀 Creating the secret for the Worker "r2-registry-production"
✨ Success! Uploaded secret REGISTRY_TOKEN
root@athena:~/serverless-registry# docker pull r2-registry-production.motofans.workers.dev/cftest-docker/netshoot
Using default tag: latest
Error response from daemon: manifest for r2-registry-production.motofans.workers.dev/cftest-docker/netshoot:latest not found: manifest unknown: manifest unknown

I've also included the server-side error logs that were generated during the process:
  "logs": [
    {
      "message": [
        "Error doing get manifest with cftest-docker/netshoot and latest: error Error: unexpected 401 from https://motofans.jfrog.io when Oauth authenticating: \r\n<title>401 Authorization Required</title>\r\n\r\n
401 Authorization Required
\r\n
nginx\r\n\r\n\r\n: undefined: Error: unexpected 401 from https://motofans.jfrog.io when Oauth authenticating: \r\n<title>401 Authorization Required</title>\r\n\r\n
401 Authorization Required
\r\n
nginx\r\n\r\n\r\n\n    at RegistryHTTPClient.authenticateBearer (index.js:4409:13)\n    at async RegistryHTTPClient.authenticate (index.js:4363:16)\n    at async RegistryHTTPClient.getManifest (index.js:4483:19)\n    at async index.js:4732:22\n    at async fetch (index.js:10:27)\n    at async Object.fetch (index.js:10:27)\n    at async Object.fetch (index.js:6065:19)"
      ],
      "level": "error",
      "timestamp":<PHONE_NUMBER>403
    }
  ],

I hope this information helps in identifying the issue. Please let me know if there's anything else you need from my side.
Thank you once again for your assistance!

Thank you so much for your effort in addressing the issue. It seems that the problem has been resolved in the cloud version, but unfortunately, it still persists in the self-hosted version. Initially, the verification seemed to succeed, but subsequent operations failed. Below is the execution process I followed:
[在这里粘贴你的执行过程]
Additionally, here is the configuration file I am using:
name = "r2-registry"
workers_dev = true
main = "./index.ts"
compatibility_date = "2022-04-18"
compatibility_flags = ["streams_enable_constructors"]
[env.production]
r2_buckets = [
{ binding = "REGISTRY", bucket_name = "r2-registry" }
]
[env.production.vars]
REGISTRIES_JSON = "[{ "registry": "https://jcr-example.motofans.club", "password_env": "REGISTRY_TOKEN", "username": "cftest" }]"
I've also included the server-side error logs that were generated during the process:
  "logs": [
    {
      "message": [
        "https://jcr-example.motofan.club",
        "Oauth 404/401/405... Falling back to simple token authentication, see https://distribution.github.io/distribution/spec/auth/token"
      ],
      "level": "debug",
      "timestamp":<PHONE_NUMBER>424
    },
    {
      "message": [
        "sending authentication parameters:",
        "https://jcr-example.motofan.club:443/artifactory/api/docker/null/v2/token?service=jcr-example.motofan.club%3A443&scope=repository%3A%2Fimage%3Apull%2Cpush&client_id=r2registry&grant_type=password"
      ],
      "level": "log",
      "timestamp":<PHONE_NUMBER>424
    },
    {
      "message": [
        "Authenticated with registry https://jcr-example.motofan.club successfully, got token that expires in undefined seconds"
      ],
      "level": "debug",
      "timestamp":<PHONE_NUMBER>141
    },
    {
      "message": [
        "https://jcr-example.motofan.club:443/v2//based/1panel/kubepi/manifests/v1.7.0",
        "->",
        403,
        "getting manifest:",
        ""
      ],
      "level": "warn",
      "timestamp":<PHONE_NUMBER>875
    }
  ],

I hope this information helps in identifying the issue. Please let me know if there's anything else you need from my side.
Thank you once again for your assistance!

@anonsaber thank you for confirming the cloud version works! I am a bit confused on how to setup the host version. Could you add a simple setup guide for the host version that I can follow to repro locally?

@gabivlj OK, I will share a docker-compose YAML file next week.

Oops, closed without meaning to (I think after merge it closed the issue). @anonsaber, sorry!

@gabivlj  Oops, it was my issue.
I tried again, I discovered that my local version is working now. Due to time constraints, I forgot that I had issued a short-term test token.
Thank you for your help; everything is working fine now.

Just for testing purposes, you can start an instance with an embedded database using the following docker-compose.yaml:
version: '3.8'

services:
  artifactory-jcr:
    image: jcr.motofans.club/releases-docker.jfrog.io/jfrog/artifactory-jcr:7.90.1
    container_name: artifactory-jcr
    network_mode: host
    environment:
      - JF_ROUTER_ENTRYPOINTS_EXTERNALPORT=8082
    volumes:
      - /ares-data/jfrog/artifactory/var:/var/opt/jfrog/artifactory
      - /etc/localtime:/etc/localtime:ro
    restart: always
    ulimits:
      nproc: 65535
      nofile:
        soft: 32000
        hard: 40000

And for the server configuration, use the following Nginx configuration:
server {
    listen 443 ssl;

    server_name jcr-example.motofans.club;
    if ($http_x_forwarded_proto = '') {
        set $http_x_forwarded_proto  $scheme;
    }

    ## Application specific logs
    access_log /var/log/nginx/jcr-example.motofans.club-access.log;
    error_log /var/log/nginx/jcr-example.motofans.club-error.log;

    rewrite ^/$ /ui/ redirect;
    rewrite ^/ui$ /ui/ redirect;
    chunked_transfer_encoding on;
    client_max_body_size 0;
    location / {
    proxy_read_timeout  2400s;
    proxy_pass_header   Server;
    proxy_cookie_path   ~*^/.* /;
    proxy_buffer_size 128k;
    proxy_buffers 40 128k;
    proxy_busy_buffers_size 128k;
    proxy_pass          http://<IP_ADDRESS>:8082;
    proxy_set_header    X-JFrog-Override-Base-Url $http_x_forwarded_proto://$host:$server_port;
    proxy_set_header    X-Forwarded-Port  $server_port;
    proxy_set_header    X-Forwarded-Proto $http_x_forwarded_proto;
    proxy_set_header    Host              $http_host;
    proxy_set_header    X-Forwarded-For   $proxy_add_x_forwarded_for;
    add_header X-Content-Type-Options "nosniff" always;
    add_header Strict-Transport-Security always;

        location ~ ^/artifactory/ {
            proxy_pass    http://<IP_ADDRESS>:8181;
        }
    }
}

server {
    listen 80;
    if ($host = jcr-example.motofans.club) {
        return 301 https://$host$request_uri;
    }
    server_name jcr-example.motofans.club;
    return 404;
}

This configuration will help you set up the server with the specified settings.


Item overflow error fix

Second part to #114 and also a fix to http://forum.terasology.org/threads/crash-related-to-full-inventory.1643/
If somehow the player got an item that spanned to the 5th page of the inventory, quit the game, and then tried to play again, then an assertion error was thrown because of the 5th page.
I removed that assertion error, and verified that the game can start now. It is not possible to pick up an item that would add another entry to the 5th page (so you can pick up ammo and buy repair kits, if they stack with existing items), and after the player sells the excess items, he/she can pick up items normally.

Hooray Jenkins reported success with all tests good!


FeedAHelp: Update the logo with correct one

with the following

Task at hand:

[ ] Update the logo
[ ] Update the favicon as following


PyscfCalculation: Add support to localize orbitals

The parameters input now accepts the localize_orbitals key. It accepts a dictionary where the method key is required. It should define one of the orbital localization schemes as implemented in PySCF. If defined, the plugin will localize the orbitals and override the molecular orbital coefficients matrix mean_field_run.mo_coeff.

I don't think water is a good test case for this. Because it is a small molecule to begin with, it is difficult to see if the orbitals are localized vs transformed. A better test would be butadiene or another extended pi system. Also, try ibo instead of nao.

Ok, I can run that example tomorrow. But we are not verifying the scientific accuracy of the method here, are we? We are not checking that PySCF computes the right results. As I understood it, the check was merely to verify that the inputs to localize orbitals provided to the plugin were properly propagated and picked up by PySCF. That seems to have been the case as the orbital clearly changed. Or do you have a reason to doubt that based on the provided images? I could also attach the log files, not sure if PySCF explicitly states when the orbitals are localized. In the end, the docs of PySCF are quite straightforward on how to enable LO (https://pyscf.org/user/lo.html), it is just adding a single additional call, which is what the plugin does.

I specifically wanted to be sure that the orbitals are stored correctly since the coefficient matrix isn't symmetric.

Fair enough. Here are the results for butadiene 10th orbital with the ibo localization method

Non-localized
Localized

Looks great!!! Thanks Seb!


Implement ImageCompressLossLess typehint annotation

Annotation already existing in: PropertyTypeHintAnnotation.kt (already there, needs to be uncommented.
Add typehint and typelimiting support in PropertyHintTypeMapper.kt

Closing in favor of #155


NX 13+ removes projects from nx.json. Workspace-lint introduces it and causes errors

With the later NX versions, the workspace-lint command causes issues due to it adding projects back to nx.json.
The problematic code is linked below.
https://github.com/nxpm/stack/blob/7a131f7db3c9dd01199181aae70d7ec1d4876609/packages/cli/src/lib/commands/workspace-lint.ts?_pjax=%23js-repo-pjax-container%2C div[itemtype%3D"http%3A%2F%2Fschema.org%2FSoftwareSourceCode"] main%2C [data-pjax-container]#L33
my suggestion is to wrap the projects property in an iif statement.
....(file?.projects ? { projects: sortItems(file?.projects) } : {})

As well as the same for packageJson and compiler options
...(file?.compilerOptions
      ? {
          compilerOptions: {
            ...file?.compilerOptions,
            paths: sortItems(file?.compilerOptions?.paths)
          }
        }
      : {})

...(file?.scripts ? { scripts: sortItems(file?.scripts) } : {})

That way, if the property doesn't exist, it won't add it back in.

Hi @kpaxton , thanks for creating this issue. I think Nx 13 does most of this out of the box these days, so your suggestion makes sense. In fact, I might get rid of it all together and just format the scripts object in package.json.
I'm happy to review a PR if you're interested in contributing!

@beeman PR created to remove the unecessary sorts.

Awesome @kpaxton - I will merge and publish later this week 🙏

@kpaxton this is not merged, thanks for your contribution!
I released it under version 5.0.0-beta.17


Added .gitignore file so as to play nicely as a git submodule.

When using vundle as a submodule in my .vim git repo, git status always complains about the untracked files in .vim/bundle/vundle, which turn out to be in doc/tags. Adding the generated help tags to .gitignore should prevent this.

Thank you @bengl! )


Add hardware and Software versioning

You should be able to tell what version the hardware is as well as the SW. Different HW configurations/versions may have different performance characteristics or issues

Added new fields in status for hardware and software versions.


[WIP] Migrate pydantic to v2

Pull Request summary:
Migrate from pydantic v1 to v2
Description of changes:
Checklist:

[ ] Make sure to run pre-commit before committing changes
[ ] Make sure all checks have passed
[ ] PR description is clear and comprehensive
[ ] Mentioned the issue that this PR solves (if applicable)
[ ] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/468


pull request for e2e test at 01/15/2017 01:56:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added Merge, Bubble, Quick Sort in java

Sir/Maam can you merge this pr with hacktoberfest-accepted


Fixed error during startup due to CS locale file

Thanks, I have fixed this on Crowdin.
It is high time that I wrote a script to fix Crowdin's idiotic INI formatting so this doesn't keep happening.


Missing AddScoped from refactored MyConfigServiceCollectionExtensions

In the Combining service collection section of the Configuration in ASP.NET Core page, the refactored code calls an AddMyDependencyGroup extension method that isn't defined in the MyConfigServiceCollectionExtensions class.
I think this is an omission, and that the MyConfigServiceCollectionExtensions class should have an extension method called AddMyDependencyGroup which calls AddScoped for the IMyDependency and IMyDependency2 dependencies. E.g.
using ConfigSample.Options;
using Microsoft.Extensions.Configuration;

namespace Microsoft.Extensions.DependencyInjection
{
    public static class MyConfigServiceCollectionExtensions
    {
        public static IServiceCollection AddConfig(
             this IServiceCollection services, IConfiguration config)
        {
            services.Configure<PositionOptions>(
                config.GetSection(PositionOptions.Position));
            services.Configure<ColorOptions>(
                config.GetSection(ColorOptions.Color));

            return services;
        }

+       public static IServiceCollection AddMyDependencyGroup(
+            this IServiceCollection services)
+       {
+
+           services.AddScoped<IMyDependency, MyDependency>();
+           services.AddScoped<IMyDependency2, MyDependency2>();
+
+           return services;
+       }
    }
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

I've come accross more examples of this code, e.g. in the Dependency injection in ASP.NET Core section, am I just misunderstanding some magic? I can't see how AddMyDependencyGroup is defined, but the note on the page says "Each services.Add{GROUP_NAME} extension method adds and potentially configures services.", so is there some dynamic magic that knows to add and configure the MyDependency interfaces and classes? How is it doing this? How about MyDependency2? Maybe I'm missing a piece that connects the dots? I shall read more and inspect the sample code more throughly.

I think I see, the copy says "The remaining services are registered in a similar class", so is it assumed that the reader would need to create this class? That makes sense, and is what I have put together in my code snippet. In my opinion, the docuemtation could be tightened up here.

@AnturGyffrous  take a look at https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/fundamentals/configuration/index/samples/6.x
Multiple places in the doc say the sample download


Havardpe/simplify fnet

@vekterli please review
...more cleaning coming soon...

:+1: less code == more good!


provide current working-directory to b700ish_patches.scd

Signed-off-by: Michael Zacherl<EMAIL_ADDRESS>

This change to how b700ish_patches.scd is loaded got rid of the "ERROR: Message 'at' not understood." that I was getting when trying to execute the b700ish.scd file.


Vendor neutrality when it comes to tools

The current version of the concise guide lists:

“Monitor known vulnerabilities in your software’s direct & indirect dependencies. E.g., use GitHub dependabot & GitLab dependency scanning. Quickly update vulnerable dependencies.”

I'd like to suggest that this needs to be more vendor neutral, either by removing references to specific dependency tracking tools entirely or by listing more tools…?

I don't really agree with his, we need some applicable examples of tools that are free and easy to use for developers.
As Github and Gitlab are the most common used code repository platforms used for hosting open source software I think referring to these 2 examples is perfectly ok in this situation.


Rely on automatic versioning by the Flex Plugins CLI

Summary
For our use case as a template, managing the plugin version within the repo is complicated without any real gain. Normally, versioning should occur as part of a release process, but as a template repo, we do not have releases--essentially, each merged PR is a release.
The CI scripts included in this repo use the Flex Plugins CLI to deploy and release the plugins. This CLI has the ability to auto-increment the version based on what is currently deployed. By removing the --version param from the deploy script, the CLI will auto-increment the patch version (0.0.1, 0.0.2, etc), regardless of the version in package.json.
Checklist

[x] Tested changes end to end
[ ] Added PR Label "ready-for-review"
[ ] Requested one or more reviewers for the PR

It works! https://github.com/twilio-professional-services/flex-project-template/actions/runs/4694228928/jobs/8322176223


Bump SHARK-TestSuite commit to include "keep going" change.

This bumps to https://github.com/nod-ai/SHARK-TestSuite/commit/e67779cee2a3878c2ba9ede50f2121cf21c1e99c.

Previously, if compilation unexpectedly succeeded, a test case would immediately XPASS. The process would then be to remove the test from expected_compile_failures, run the test suite again, then possibly add the test case back to expected_run_failures if the run fails.
Now, if compilation unexpectedly succeeds, the 'run' test phase will be attempted, so we can directly move the test from one XFAIL list to the other, or at least know more confidently that the test is now fully passing.

(Updating XFAIL lists could still be further automated, but this is an incremental step in the right direction)

Ping? I'm starting to stack PRs and this would help.

Do we now want to update ref to include sdxl models or should we wait until we also add in benchmarking in next couple hours?

We can do that separately (yay auto-merge). That may need some adjustments to the pytest calls, so we only run new tests (and download files for them) where we want to. In particular I'm hesitant to take a 8 minute+ download for SDXL source files, so we may want to first get runners configured with cached files or carve out a postsubmit-only build until then.


Add enable_model_summary flag and deprecate weights_summary

What does this PR do?

Fixes #9043
Adds enable_model_summary flag to match enable_progress_bar flag being added here: https://github.com/PyTorchLightning/pytorch-lightning/pull/9664/
This PR also deprecates the Trainer weights_summary flag and property which dictated the mode for display. Users are expected to customize this with the callback. This deprecation was required because we needed to support arbitrary module depths for summarization (int) while the current mode only supported a few fixed modes ("top" vs "full"). This customization is much easier with the ModelSummary callbacks @kaushikb11  introduced.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Do we need the enable_ prefix? I think model_summary is straightforward as it is a boolean flag.

This also came up in these places:
https://github.com/PyTorchLightning/pytorch-lightning/pull/9616#issuecomment-924387620
https://github.com/PyTorchLightning/pytorch-lightning/pull/9664#issuecomment-927314218
https://github.com/PyTorchLightning/pytorch-lightning/pull/9754#issuecomment-930257778
Options so far:

Use enable_ as a prefix

Pros:

consistent naming sceheme: users can scan through the trainer flags and see what features are enabled by default by the Trainer
enable_ as a a prefix indicates these are booleans

Cons:

More verbose

Directly use the name. e.g. model_summary, progress_bar, checkpointing

Pros:

Less verbose

Cons:

May have confusion with the callback implementation (e.g. model_summary as a flag: does it take the ModelSummary callback? or a boolean? would trainer.model_summary be the callback instance, or the boolean flag passed into the trainer?

Other options?

@PyTorchLightning/core-contributors

I am strongly in favor of option 1. Another reason is for consistency, i.e. consider these Trainer arguments:

profiler of type BaseProfiler
accelerator of type Accelerator
logger of type LightningLoggerBase

if I were reading these arguments and then saw one named model_summary I would assume it to be an instance of a class as well.
IMO boolean arguments should be named with a verb as a prefix, such as enable_progress_bar, reload_dataloaders_every_epoch, terminate_on_nan, move_metrics_to_cpu

Question: under what circumstances would users want to disable the model summary? Is it critical we have this flag?

under what circumstances would users want to disable the model summary? Is it critical we have this flag?

Maybe the summary is not correct for your model, maybe you are calling fit multiple times and you don't want it to appear repeatedly...

@williamFalcon makes sense, I agree user experience is very important and didn’t mean to suggest otherwise!


Select face cards based on targeted skill

Can we have a feature such that if a Servant gets a buff, their face cards will be prioritized? Also, is it possible to use skills only based on the face cards that we see? For example, use NP gain skill only if that Servant's Arts/Quick card appears, then proceed to use that Arts/Quick card. Otherwise, do not use NP gain skill.

No sorry, that's too difficult to implement. You would have a library of buff icons to check for and also if all of your servants have buffs, it won't help you. For example, if you use Charisma or Waver's attack buff.


Use the existing CloudTrail

CloudTrail is setup by default to capture the IAM events (New IAM user/role). This request is to allow to use the existing the CloudTrail without the creation of new CloudTrail.

Fixed in https://github.com/aws-samples/scp-alternative-solution/pull/7


Forecast data

This looks promising, thanks!  From the code it appears to be fetching observations data.  Are there any plans to add functionality to access forecast data too?

Dear @drmrbrewer,
thanks for writing in.

Are there any plans to add functionality to access forecast data too?

Sure! We will try to further improve this piece of software infrastructure- and feature-wise and will be happy to get support for doing so.
Luftdatenpumpe is kind of the reference here what we would like to achieve in the long run, while definitively adding more DWD-specific things.
With kind regards,
Andreas.

Hi Andreas... OK, great!  Exciting times ahead...

Are there any concrete plans for including forecast data? I'm not a weather scientist, but from the technical point the dwd forecast data is available as a XML file (KML) for every station. What do You think?

Dear @onlygecko,
while supporting more things from DWD is still on our wishlist, we haven't been able to make more concrete plans about this. However, contributions are always welcome!
With kind regards,
Andreas.

Dear @drmrbrewer and @onlygecko,
we just found out that https://github.com/jlewis91/dwdbulk by @jlewis91 (thanks!) already supports acquisition of forecast data from DWD.
While it would be cool to merge functionalities of both projects as outlined within #22, the dwdbulk implementation might make you happy already.
With kind regards,
Andreas.

Dear @drmrbrewer and @onlygecko,
as Wetterdienst will be the designated successor library for dwdweather2, it makes sense to add respective features there. In order to track this, I've recently created https://github.com/earthobservations/wetterdienst/issues/70, so I am deliberately closing the issue here.
With kind regards,
Andreas.


Update quick-create-portal.md

Grammar fix

@cseas : Thanks for your contribution! The author, @cynthn, has been notified to review your proposed change.

#sign-off


Help track down a possible NSOperation bug

Help requested:
Please try running the code below.

NOTE: Running this in a Playground is not recommended.
It will run much faster if you compile it into a simple / empty Mac app.

import Foundation

func debugPrint(operation: Operation, indentLevel: Int = 0) {
    let linePrefix = String(repeating: "\t", count: indentLevel)
    print("\(linePrefix) isReady: \(operation.isReady)")
    print("\(linePrefix) isExecuting: \(operation.isExecuting)")
    print("\(linePrefix) isFinished: \(operation.isFinished)")
    print("\(linePrefix) dependencies: (\(operation.dependencies.count))")
    for (idx, dependency) in operation.dependencies.enumerated() {
        print("\(String(repeating: "\t", count: indentLevel + 1)) \(idx): \(dependency)")
        debugPrint(operation: dependency, indentLevel: indentLevel + 2)
    }
}

func test(batches: Int = 100, batchTimeout: TimeInterval = 30.0) {
    struct WaitTimeout: Error { }
    do {
        try (0..<batches).forEach { batch in
            try autoreleasepool {
                let batchStart = CFAbsoluteTimeGetCurrent()
                let queue = OperationQueue()

                // A group that tracks when Op1 operations have executed
                let group = DispatchGroup()

                (0..<100_000).forEach { i in
                    group.enter()

                    // Create two operations
                    let op1 = BlockOperation { group.leave() }
                    op1.name = "Op1 \(i)"

                    let dependency = BlockOperation { }
                    dependency.name = "Dependency \(i)"

                    op1.addDependency(dependency)

                    // Add the dependency to the queue, then the first operation
                    queue.addOperation(dependency)
                    queue.addOperation(op1)
                }
                let waitResult = group.wait(timeout: .now() + batchTimeout)
                guard waitResult == .success else {
                    print("Batch \(batch): Timeout (\(batchTimeout) seconds)")
                    print("\t \(queue.operationCount) operations are still in the queue:")
                    for (idx, operation) in queue.operations.enumerated() {
                        print("\t \(idx): \(operation)")
                        debugPrint(operation: operation, indentLevel: 2)
                    }
                    throw WaitTimeout() // stop looping after a timeout occurs
                }
                let batchDuration = CFAbsoluteTimeGetCurrent() - batchStart
                print("Batch \(batch): All operations executed in batch (in \(String(format: "%.2f", batchDuration)) seconds)")
            }
        }
    }
    catch { }
}

// run test
test()

(Please note - you may get many batches that succeed before one fails. Also, you might have to adjust the timeout passed to the test() function depending on your computer's performance.)
Here's output from one example run in which it failed on Batch 17:
Batch 0: All operations executed in batch (in 10.27 seconds)
Batch 1: All operations executed in batch (in 10.14 seconds)
Batch 2: All operations executed in batch (in 10.11 seconds)
Batch 3: All operations executed in batch (in 10.29 seconds)
Batch 4: All operations executed in batch (in 10.40 seconds)
Batch 5: All operations executed in batch (in 10.32 seconds)
Batch 6: All operations executed in batch (in 10.13 seconds)
Batch 7: All operations executed in batch (in 10.23 seconds)
Batch 8: All operations executed in batch (in 10.26 seconds)
Batch 9: All operations executed in batch (in 10.07 seconds)
Batch 10: All operations executed in batch (in 10.14 seconds)
Batch 11: All operations executed in batch (in 9.93 seconds)
Batch 12: All operations executed in batch (in 9.32 seconds)
Batch 13: All operations executed in batch (in 9.18 seconds)
Batch 14: All operations executed in batch (in 9.20 seconds)
Batch 15: All operations executed in batch (in 9.24 seconds)
Batch 16: All operations executed in batch (in 9.58 seconds)
Batch 17: Timeout (30.0 seconds)
	 1 operations are still in the queue:
	 0: <NSBlockOperation: 0x60000005f440>{name = 'Op1 55057'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x60000005f3e0>{name = 'Dependency 55057'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)

Notice that the "stuck" Operation is ready (and its dependency is also ready), but it never executes. That's what I'm looking for. (Or the absence thereof.)
If posting, please include:

The output produced by the code.
The version of Xcode & Swift used to compile the code. (ex. Xcode 8.3.3 (Build 8E3004b))
The OS name and version used to run the code. (ex. macOS 10.12.5)
The device model identifier (ex. MacBookPro14,3)
The number of CPU cores (if a Mac)

Batch 0: Timeout (30.0 seconds)
	 2 operations are still in the queue:
	 0: <NSBlockOperation: 0x106b0f430>{name = 'Op1 8082'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x106b0d0f0>{name = 'Dependency 8082'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)
	 1: <NSBlockOperation: 0x1097a6820>{name = 'Op1 80109'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x10978d9c0>{name = 'Dependency 80109'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)

Xcode 9b3, Swift 4
High Sierra dp3
iMac 18,3
4/8 cores/threads

Batch 0: All operations executed in batch (in 1.54 seconds)
Batch 1: Timeout (30.0 seconds)
	 3 operations are still in the queue:
	 0: <NSBlockOperation: 0x109466c70>{name = 'Op1 51177'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x1094611d0>{name = 'Dependency 51177'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)
	 1: <NSBlockOperation: 0x10633eb70>{name = 'Op1 58270'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x10634e8d0>{name = 'Dependency 58270'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)
	 2: <NSBlockOperation: 0x106854d10>{name = 'Op1 65057'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x106872e70>{name = 'Dependency 65057'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)

Same setup, but with WMO turned on.

Batch 1: Timeout (30.0 seconds)
	 2 operations are still in the queue:
	 0: <NSBlockOperation: 0x1021e0ba0>{name = 'Op1 11591'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x1021d3c40>{name = 'Dependency 11591'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)
	 1: <NSBlockOperation: 0x109cb5350>{name = 'Op1 50895'}
		 isReady: true
		 isExecuting: false
		 isFinished: false
		 dependencies: (1)
			 0: <NSBlockOperation: 0x109cb7620>{name = 'Dependency 50895'}
				 isReady: true
				 isExecuting: false
				 isFinished: true
				 dependencies: (0)

Same setup, no optimization, Swift 3.2 mode.

Thanks @jshier 👍

Thanks @jshier!
At this point, it looks like there may be a race condition in Foundation itself surrounding how the NSOperation(Queue) internals handle an Operation's isReady changing to true while that Operation is being added to the queue. (At least that's the speculation at the moment.)

No - closing this now.


Next

Add createForm function, this function creates a form and return a custom hook to manage the form.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Disable date  on month is not correct

Disable date month is +1
Example I set disable date on 2019-12-1 but pickadate is show disable date on 2020-1-1
i try to see in example code is same.
Sorry I'm not good at English

Hi @puwadon-book,
This is how Date in JavaScript works, the month is zero-indexed.
See the note at the top of https://amsul.ca/pickadate.js/date/

https://codepen.io/DanielRuf/pen/povgKvN?editors=1111


Mini

Breaking away from the ipython/scipystack image for a bit more flexibility.
Also using Anaconda in the Python image so we can entertain bringing in Anaconda environments as layers.

On image size, this is the current size (with an ubuntu base image):
REPOSITORY              TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
rgbkrk/runner-py2       latest              60a395097e82        23 minutes ago      399 MB

If I install the full Anaconda suite (scipystack + way more):
rgbkrk/runner-py2       full                13f5fc5ff98b        2 minutes ago       2.027 GB

That's smaller than the jupyter/demo image too.

:metal: not bad at all.


Add documentation for extension CastorGUI

You forgot to update https://github.com/BabylonJS/Documentation/blob/master/data/statics.json#L431

oops, it's done


Camera manager should not take pictures at night

We should integrate with the light sensor to detect when it's too dark to take a photo

Can I just add the light sensor to the _CameraPollWorker class? Are there any issues with the light sensor being read too frequently?

Yeah that should work. I don't think there's much of a cost to reading the light sensor a lot.


Monitor publish tasks sub task and remove automatic job publishing targets

When adding/removing targets, it triggers a new job to publish the
targets.
This subtask could fail for some reason, and we don't monitor it.
This commit adds the monitoring for this task and will give details
to the user once it fails the parent task (add/remove targets).
Closes #190
The monitoring is done in the _update_task as part of checks.
As discussed in issue https://github.com/vmware/repository-service-tuf-worker/issues/175, we removed the automatic job that
publishes targets every minute.
The publish targets are done to persist in the RSTUF Worker backend
storage of the updated metadata with the new targets.

We will give full control over the failure to add/remove targets
to the user. They can decide to reprocess the entire flow (add/remove
targets), or they can trigger publish targets.
The automatic job publishes targets creates confusion when and who
publishes the targets if the automatic job wins in the race condition
with add/remove targets.
For the feature load/import data it can slow down the process and
it would require an way to disable the automatic jobs during this
process, adding a lot of confusion.

Requires #194 for the Lint issue in the checks.

You can rebase this pr and get the fix from https://github.com/vmware/repository-service-tuf-worker/pull/194 as it's merged.

@MVrachev, Rebased.


JP8 -> JP2 (IDFGH-2184)

@motla Sorry for the delayed reply. Finally, your commit has been merged into master. You contribution is very much appreciated. Thank you!


Trying to build docker container

Hi, sorry if it is not related directly to flute, but would appricate if you could help.
I am trying to build docker image on top of vllm docker image with following:
# Use vllm/vllm-openai:latest as the base image
FROM vllm/vllm-openai:latest

# Install flute-kernel using pip with cache optimization
RUN --mount=type=cache,target=/root/.cache/pip \
    python3 -m pip install flute-kernel --no-cache-dir

# Set the entrypoint to use the specified command
ENTRYPOINT ["python3", "-m", "flute.integrations.vllm vllm.entrypoints.openai.api_server"]

but I am getting following error when I run docker buildx build --platform linux/amd64 -t flute:latest -f Dockerfile .:
 > [stage-0 2/2] RUN --mount=type=cache,target=/root/.cache/pip     python3 -m pip install flute-kernel --no-cache-dir:
0.957 ERROR: Could not find a version that satisfies the requirement flute-kernel (from versions: none)
1.346
1.346 [notice] A new release of pip is available: 24.2 -> 24.3.1
1.346 [notice] To update, run: python3 -m pip install --upgrade pip
1.347 ERROR: No matching distribution found for flute-kernel
------
Dockerfile:5
--------------------
   4 |     # Install flute-kernel using pip with cache optimization
   5 | >>> RUN --mount=type=cache,target=/root/.cache/pip \
   6 | >>>     python3 -m pip install flute-kernel --no-cache-dir
   7 |

do you know the reason ?

This happens when the system you are using is not supported. The current release of FLUTE supports following settings:
https://github.com/HanGuo97/flute/blob/6806c1bf0e52f104103fa02563f2f34c0e11bdc1/.github/workflows/wheels.yaml#L16-L21


the .exe file isent showing up in the assest

what do you mean?

please provide more context since I don't have any clue what you mean...

Question makes no sense && no response so closing issue. Amethyst is not an active project anymore


fix: doc bug (maybe)?

The example etags bce6bf66aeb76c7040fdd5f4eccb78e6 and 8165449fc15bbf43d3b674595cbcc406, when concatenated and md5-hashed do not equal the documented value of f77dc0eecdebcd774a2a22cb393ad2ff.  I believe the correct example should be 158668b0d382a2d588dd141dafb5ec6f instead.
But, I may be misunderstanding the instructions.
Context: https://community.cloudflare.com/t/documentation-bug-with-r2-multipart-upload-md5-example/530466/4

Hi @barabo, thanks so much for your contributions! I'm going to close this PR out in favor of PR https://github.com/cloudflare/cloudflare-docs/pull/9797 which now better clarifies how multipart ETags are calculated. As always though, if you find something else, contributions are always welcome and appreciated. 😀