active_record_pg multiverse suite fails when ran with parallelism

Our GitHub Actions based CI system explicitly disables parallelism via the SERIALIZE environment variable, but elsewhere all of our unit and integration tests are expected to be able to operate in parallel.
At least with Ruby 3.0 and 3.1 and potentially with other Rubies, the active_record_pg multiverse suite will frequently fail when ran with parallelism (the default). For me, at least 1 out of every 3 runs will fail. Setting SERIALIZE=1 eliminates the problem.
We should get that suite working with parallelism.

Findings:

There is a single failing Minitest test is involved, which is test_metrics_for_calculation_methods defined in test/multiverse/suites/active_record_pg/active_record_test.rb
The problem will only occur when Rails versions < 7 are tested, given that test_metrics_for_calculation_methods only layers in a count with the assertion if ActiveRecord is below version 7.0
The failing test is only attempted against Postgres, but a very similar test of the same name defined by test/multiverse/suites/active_record/active_record_test.rb tests MySQL in conjunction with ActiveRecord v3+ and performs the same assertion of expecting there to be 5 SELECT statements, so this appears to be a Postgres only issue.
From examining the extra recorded SELECT statements that cause the test to fail, they all take place before the test's own database activity and they all appear to be related to Postgres' schema cache and TypeMap.
The sometimes unexpected nature of these extra queries firing is an ongoing issue of discussion within the Rails community. See Rails PR 44478 for example.

Now that we have identified the root cause of the test failures, we have two different routes available to tackle it.

If we feel that the agent should not record these schema cache queries as counting towards the monitored app's query count, we can update the agent to stop doing so.
If we wish to continue to count schema queries as monitored app queries, we'll have to refactor the assertion helper to support something like ">= 5" instead of simply "5" for the query count assertion, or do an even bigger testing overhaul to explicitly exclude queries that schema cache related.

I'll look at both approaches to give us some options.

duplicate of #969


Change Password - Error message not displayed in red for incorrect new password

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app and login
Navigate to settings by clicking on the user avatar over LHN
Click on change password
Enter correct old password
Enter password not meeting the requirement for new password

Expected Result:
Error message displayed in red
Actual Result:
No error message displayed and only message displayed in black about password requirement
Workaround:
None needed, visual issue.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.92-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
View all open jobs on GitHub

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I had worked on the confirm password error message on this page. I would propose a very small fix here,
We should retain the prompt and only change the color of the message when the password doesn't match the requirement. So basically remove this.state.isPasswordRequirementsVisible and change the block to the following:
{(
      <Text style={[styles.textLabelSupporting, styles.mt1, this.isValidPassword() && styles.formError]}>
          {this.props.translate('passwordPage.newPasswordPrompt')}
      </Text>
  )}

Here is my suggestion. We need to start validating (i.e. 1 capital letter, 1 lowercase letter, 1 number) new password as soon as some character entered. So as soon as start entering character in new password field, it will show message in red color due to password not match with rule initially. Now user go on typing new password and as soon as it become valid, the message shows in normal color.
So based on my thinking I will suggest to add condition at line 150 (within PasswordPage.js file), So overall behaviour remain same and it will just show message in red color whenever new password input value is not valid.
Code Before Update:
https://github.com/Expensify/App/blob/c2f83f3249e9b07cad15ca403bf19ef37e7b7aee/src/pages/settings/PasswordPage.js#L149-L153
Code After Update ( condition added at line 150):
{this.state.isPasswordRequirementsVisible && (
    <Text style={[styles.textLabelSupporting, styles.mt1, (this.state.newPassword && !this.isValidPassword()) && styles.formError]}>
        {this.props.translate('passwordPage.newPasswordPrompt')}
    </Text>
)}

Below is the screen recording how its looks once the suggested solution implemented.
https://user-images.githubusercontent.com/7823358/132018151-743d282c-9139-40aa-893b-64e11301656f.mov
I understand that External label not set with this issue. So at present consider this as my suggestion. I hope it will be helpful to someone who handle it internally. If this issue considered as external and my solution accepted then kindly invite me on Upwork once project posted.  Thanks.

@isagoico was there a slack thread for this one? I didn't see one but just double-checking so I can have all the context

@Jag96 This was raised as part of our internal QA that's why there's no slack thread linked in this one.

Issue reproducible during KI retests

@Jag96 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

I think for this one we should keep the same convention from https://github.com/Expensify/App/pull/5093, where:

Initially, the passwordPage.newPasswordPrompt message shows with grey text, even when the user hasn't typed anything
When the user starts typing, the passwordPage.newPasswordPrompt message shows w/ formError styles
Once the requirements are met, the passwordPage.newPasswordPrompt message shows w/ grey text again, even when the user goes to the next field

So the message will always be shown if that makes sense. @mananjadhav @PrashantMangukiya can you post updated proposals to match that convention?

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Jag96 If you see my proposal https://github.com/Expensify/App/issues/4995#issuecomment-911916821 it does exactly the same.
I proposed two changes in the code:

Remove this.state.isPasswordRequirementsVisible check so that the hint is always visible
Add !this.isValidPassword() && styles.formError in styles so that formError style is shown when the password is invalid.

I hope it matches with what you mentioned above.

@mananjadhav it looks like your proposal results in the initial state of the message being shown w/ formError, rather than it starting off grey and only showing w/ formError once the user starts typing:

You're right @Jag96.
Updated Proposal
Extending the proposal in the comment (https://github.com/Expensify/App/issues/4995#issuecomment-911916821), I'll update the check for the form style with the following:
<Text style={[styles.textLabelSupporting, styles.mt1, this.state.newPassword && !this.isValidPassword() && styles.formError]}>
    {this.props.translate('passwordPage.newPasswordPrompt')}
                            </Text>

We would still remove the isPasswordRequirementsVisible as it won't be used.
and we can move this.state.newPassword && !this.isValidPassword() check into a function say isInvalidPassword or showFormError.
Does that make sense?

@mananjadhav that sounds good to me, I like the improvement of moving the state check into a new isInvalidPassword function! @puneetlath can you please hire @mananjadhav for this job once you create the Upwork post? @mananjadhav feel free to get started on a PR once you've been hired in Upwork.

Hi @Jag96 and @puneetlath  I already suggested this condition from beginning that  shows code as under,  As you can see within https://github.com/Expensify/App/issues/4995#issuecomment-912573194
{this.state.isPasswordRequirementsVisible && (
    <Text style={[styles.textLabelSupporting, styles.mt1, (this.state.newPassword && !this.isValidPassword()) && styles.formError]}>
        {this.props.translate('passwordPage.newPasswordPrompt')}
    </Text>
)}

Should I submit updated proposal from my side based on the suggested steps mentioned in https://github.com/Expensify/App/issues/4995#issuecomment-914647313 ?  If already decided to go within other proposal then it is ok.
Please let me know should I put the updated proposal from my side now?

@PrashantMangukiya your initial proposal did have that included, but it was also hiding the message after the user went to the confirm field. Both initial proposals didn't match the behavior posted in this comment (because the ideal behavior wasn't listed initially), so in this case, I gave the job to @mananjadhav since he posted his initial proposal first and his updated proposal met the requirements.

Hi @Jag96 Thanks for the updates. Its ok no problem. I will not submit updated proposal now. @mananjadhav congrats..

@puneetlath can you please hire @mananjadhav for this job once you create the Upwork post?

Done!

Issue reproducible during KI retests.

Hi @mananjadhav, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

Issue reproducible during KI retests.

I'll have my changes pushed by tomorrow.

Issue reproducible during KI retests.

@mananjadhav how's this going?

@puneetlath PR is updated here, I'll update the screenshots in a few hours.

Issue reproducible during KI retests

Ok great, so it sounds like we want this then:

Only show one error at a time under the New Password field.  If the new password is the same as the old password, only show that error. If the new pw is different but the criteria is wrong for the new password field, only show the criteria error.
If an error is showing under the New Password field, don't show the hint. If there are no New Password field errors, show the hint.
If the new pw is different and the criteria is right but the new password doesn't match the confirm password, show the passwords don't match error under the Confirm New Password field.

Does this sound good @marcaaron @megankelso?

remove the hint and show the New password must be different than your old password error message instead

Yep this is where we landed in the doc too IIRC to follow the material design guideline

@marcaaron  @Jag96  Should I update the PR with the above-mentioned changes then?

@mananjadhav yes, sounds like we're all in agreement so lets update the PR with the changes mentioned in https://github.com/Expensify/App/issues/4995#issuecomment-955078045.

Issue reproducible during KI retests.

@mananjadhav @Jag96 how's this going?

PR is on the finish line. Hopefully it should get merged today.

Issue not reproducible during KI retests. (First week)

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.16-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/5130

If no regressions arise, payment will be issued on 2021-12-06. :confetti_ball:

Issue not reproducible during KI retests. (Second week)

Paid along along with n6 hold bonus. Thanks @mananjadhav!

@puneetlath I received $250 for PR and $250 for n6-hold. But I guess I am eligible for company-offsite hold bonus as well.
Also while this PR was done for a specific requirement, we also updated the form validation styles and @Jag96  mentioned here https://github.com/Expensify/App/pull/5130#issuecomment-917251774 if I take it up, there'll be additional bonus, so that should be an additional $250. @Jag96 Can you please help here?

@puneetlath @mananjadhav is right, we should also pay out another $250 for the company-offsite hold and then an additional $250 for the updated scope of work agreed upon in https://github.com/Expensify/App/pull/5130#issuecomment-917251774. So a total of $500 additional.

Got it, no problem! @mananjadhav I've sent you an offer through Upwork for the additional $500.

Thanks @puneetlath, applied.
Thanks @Jag96


Request for Assistance: Installing "megaind" with PySide6 in a Virtual Environment

I'm currently working on integrating the "megaind" library with PySide6, and PySide6 necessitates the use of a virtual environment. Nevertheless, I've run into challenges while attempting to install the "megaind" library within the virtual environment. Despite trying several approaches, I haven't been able to make it work successfully. Do you have any suggestions on how to achieve this? Additionally, I'm curious about why the "megaind" project isn't available on PyPI. Having it on PyPI would simplify the installation process by allowing us to use 'pip install'.
Many thanks and kind regards,
Andries

We will try to publish it on PyPi and let you know.
I have no experience with virtual environments but normally if you go to the megaind-rpi/python/ folder and run "pip install ." is working, or you can use "python -m pip install ."
Alex.

Just for your reference, I installed Qt using the instructions from this link: Qt for Python Quick Start.
Currently, I have a folder where I've installed 'megaind-rpi' and followed the instructions provided in the readme file, which worked perfectly fine except when I activated the virtual environment (venv).
To resolve this issue, I navigated to the './megaind-rpi/python' directory and attempted to install it using either 'pip install .' or 'python -m pip install .'. However, I encountered the 'legacy-install-failure' error. To work around this, I used the '--break-system-packages' flag.
Interestingly, when I remain in the 'megaind-rpi/python' directory, I can use the library without any issues (when i go to the program it doesn't_. However, 'pip list' indicates that it is not installed within the virtual environment.

Hi,
We just published the library on the PyPI you can use "pip install megaind" to install it.

"I just gave it a try, and it worked flawlessly. Afterward, I simply had to run 'pip install smbus' since that library wasn't initially installed in the environment. Nevertheless, I greatly appreciate your assistance – you're a hero!

I am glad you made it, please give us a review on Sequent Microsystems  if you appreciate our products.
Thank you.


Implement table diff test

Implement a test enabling user to perform a diff. check between two tables tables/columns.

fails if diff.
succeeded if no diff

user add business rules or test cases to screen for Data in Column A based on the value in Column B
user add a business rules to compare the value in a column against the values in reference tables

Will be part of Collate offering


Cannot sync settings since 2 weeks

Settings do not sync any more, can you help me please?
🌴 Visual Studio Code Version : 1.36.0
🌴 Code Settings Sync Version : 3.3.1
🌴 Standard or Insiders : standard
🌴 Portable or Installed : installed
🌴 OSS or Official Build : official
🌴 Operating System : windows
🌴 Occurs On: Upload (maybe Download but I don't want to try / fear of loosing my actual settings)
🌴 Proxy Enabled: [ Yes / No ]
🌴 Gist Id: 1b8b7717469c2648bacb57a1498dd84e
📺 Console Error Log

@inwardmovement Can you try this build? https://cdn.discordapp.com/attachments/549007146868539408/597761688443289610/code-settings-sync-3.4.0.vsix
Instructions: https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix

@inwardmovement
Can you check on the upcoming build by @arnohovhannisyan
If still doesnt work for you than i would suggest you to share your entire User folder in compressed file( removing private settings)

🎉 Yay! Thanks! I was running into the same error and this build is working for me.

It seems ok with 3.4.0, thanks!
Can I get rid of the .vsix and will the extension sync back with future updates?

v3.4.0 is in testing phase, will be released in a week or two.


Add GraphML export.

I had issues with the GML export and unicode characters. This branch adds GraphML export, which seems not to suffer from these problems.

Hey @frederik-elwert, thanks for this!
I wonder, though, if it would be better to fix the issue with the numpy types when we actually set the values on the network, instead of on export. Putting that step in the base class could cause problems down the line if we add a new subclass of Graph that doesn't add weights to the edges.
Could we just cast to float in the Skimmer#build() method, and then let the write_graphml method pass the graph directly to nx.readwrite.graphml.write_graphml without any modifications?

Thanks for the feedback, @davidmcclure! I guess you are right. I wanted to mess as little as possible with the rest of the code, but if you don’t mind having floats early on, I’ll re-implement it that way.

Great, thanks so much @frederik-elwert! I'm going to try to do a bit of work on Textplot this weekend - want to wrap it up as a little CLI app with Click, and publish it as a pip package.


run_from_project_root = False is not running from cell root

I have this rule:
def _elm_test_impl(ctx: "context") -> [[DefaultInfo.type, ExternalRunnerTestInfo.type]]:
    command = [
        "elm-test", # TODO put in toolchain or params
        cmd_args(ctx.attrs._elm_toolchain.get(ElmToolchainInfo).elm, format="--compiler={}"),
        cmd_args(str(ctx.attrs.fuzz), format="--fuzz={}"),
    ]

    if ctx.attrs.seed:
        command.append(cmd_args(ctx.attrs.seed, format="--seed={}"))

    command.extend(ctx.attrs.test_srcs)

    return [
        DefaultInfo(),
        ExternalRunnerTestInfo(
            type = "elm_test",
            command = command,
            run_from_project_root = False,
        ),
    ]

elm_test = rule(
    impl = _elm_test_impl,
    attrs = {
        "test_srcs": attrs.list(attrs.source()),
        "fuzz": attrs.int(default=100),
        "seed": attrs.option(attrs.string(), default=None),
        "_elm_toolchain": attrs.toolchain_dep(
            default = "toolchains//:elm",
            providers = [ElmToolchainInfo],
        )
    },
)

When I define some non-project-root target with this rule (in this case available at //component-catalog:elm_test) the executor runs from the project root still, despite having run_from_project_root = False.
I have some memory that an earlier version of buck2 would change working directory for tests, and the docs seem to suggest that will happen too. Is that right or have I misunderstood something?
Version:
buck2 f8ff2901f86e397cb82f2052815889d3 <local>

Is it possible that you're confusing cells and packages here? The target name you're sharing doesn't have a cell, so that leads me to suspect you may not be using cells at all, in which case project root and cell root are the same thing.
To be very clear,  component-catalog is not a cell, it's a package.

mmhmm! Ok then, so is there a way to get this to change directory? I thought it was working when I did an earlier prototype but similar code is not working now. 🤔

Ok then, so is there a way to get this to change directory

You can't run tests from their package, no

Ok. Just out of curiosity, why is that? It’s the same for build scripts and it’s meant doing a lot of extra work in Elm scripts specifically because the compiler assumes you’re running from the package root.On May 19, 2023, at 6:36 AM, Thomas Orozco @.***> wrote:
Ok then, so is there a way to get this to change directory
You can't run tests from their package, no
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Just out of curiosity, why is that?

I think the answer is primarily "because it's not implemented", but generally I think we try to avoid having too many ways of doing things. Running from the cell root was a concession because that's how Buck1 works, but all the actions Buck2 executes run from the project root.
We should probably make running from the project root & using relative paths the default in the OSS build.

It’s the same for build scripts and it’s meant doing a lot of extra work in Elm scripts specifically because the compiler assumes you’re running from the package root

I'm really sorry, but i have no idea what you mean here

Well, you said that component-catalog is a package, right? It happens to be an Elm app. The Elm compiler must be run from the directory containing its config file (elm.json.) Because of that, I have a Python script that takes all the arguments for the compiler and then changes directory and does a little more setup just before execution. It looks like it’ll be the same for the test script because of the same issue!

Right, I think the immediate answer here is that we've not needed that and it's pretty easy to workaround, so we never added it.
(I don't feel super strongly about whether or not that should exist, personally)


Fix code block rendering.

Fixed the issue that was caused by missing CSS styles. I tested this with both light and dark themes, everything works correctly.

This PR fixes #130647

Thanks but this has been superseded by #136693 which also adds syntax highlighting. Test it out in insiders and feel free to submit another PR if the new styling doesn't seem correct


"Hilișeu-Horia", "Corjăuți" and "Hilișeu-Cloșca" are listed in the drop-down menu

Description:
"Hilișeu-Horia", "Corjăuți" and "Hilișeu-Cloșca" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Corjăuți" in the search bar.

Expected results
The location is listed in the drop-down menu as "Corjăuți, Botoșani (Hilișeu-Horia)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Hilișeu-Cloșca" in the search bar.

Expected results
The location is listed in the drop-down menu as "Hilișeu-Cloșca, Botoșani (Hilișeu-Horia)".


Move templates to target net8.0

add loc comments to ensure 'net8.0' doesn't become 'Net8.0', '.Net 8.0', ...
bump template precedence and identity values

/ping reviewers


tests/rgw: add --connect-timeout 5 to radosgw cmd

If the radosgw daemons aren't up and running correctly (like not registered
in the servicemap or the OSD are down) then the radosgw-admin will hang
forever.
Jenkins will kill the jobs after 3h but we don't want to wait until this global
timeout.
Adding the --connect-timeout 5 to the radosgw-admin commands (which is already
present on other radosgw-admin calls) allows the job to fail earlier.
Signed-off-by: Dimitri Savineau<EMAIL_ADDRESS>

jenkins test centos-non_container-all_daemons

jenkins test centos-non_container-collocation

jenkins test centos-non_container-all_in_one

jenkins test centos-non_container-all_daemons

jenkins test centos-non_container-all_in_one

jenkins test centos-non_container-collocation


Database re-creation

Now this shall be a database-specific feature, so we'll need different implementations for different drivers. Anyway, a method to delete and create the selected database would be very useful.

The option needs to be disabled when the project is in read-only mode


(Staging) Tunein skill issues

these work:
list most popular radio stations
list local radio stations
list best radio stations
but i can't figure out any way to get a radio station to stream.
entering this as a placeholder -- will circle with Giovanni and get direction and retest.

I think playing radio only works on local Almond at the moment, because it relies on direct audio output. I haven't tested the skill yet though, Jake is still working on it.


Better handling of map draggability in Select mode

See the last heading of https://github.com/JamesLMilner/terra-draw/issues/37 for further details. Essentially we could be a little bit smarter about when we choose to disable dragging. At the moment we just blanket block draggability when a geometry is selected. We could look into seeing if it is actually possible to see if we could make this only happens when we try to perform specific drag based actions (drag, drag coordinate, rotate, scale etc).

This is improved in<EMAIL_ADDRESS>🎉


About kitti eigen split

Hi there, thank you for your amazing work!
I noticed that in the paper, you mentioned the eigensplit you had used. However, I never found any eigen train split file like other projects.
And you said to use prepare_KITTI_DP to get the kitti data but never said how to get gt (for depth annotated data, we had gt, but eigen split != annotated one)

To be specific, there had said the difference between annotated depth and the projective point depth.

And actually, I found no where to get the gt depth of the eigen train split, which is necessary for training :(

Eigen train split is a widely used train split on Kitti dataset by many papers. And actually, you may have to check previous papers for Eigen's paper and split by yourself.
Regards

Thank you for your reply!
Yes, I know that the Eigen train split is a traditional split, but how to get the gt_depth which is training necessary? Did you do it as monodepth2??


Child model search reproduction based on P100

Hi, thanks very much for your work.
I use following code to reproduce results on P100,  but the result is inconsistent with the paper report.
python -u ./search.py

--train_percent=80
--bcfw_steps=10000
--initial-checkpoint=<A path to the one-shot model's weights>
--inference_time_limit 25 #ms
results:
25 ms constraints->searched model test:actual latency 62.48ms （paper report: 27ms）
acc(76.364/93.018) flops(467M) params(6.849M)
I'm very confused. Could you help me?

@Tiantian-Han, I am also facing similar issue. I reran the search command and I am getting 72 msec (Not sure though). I created new issue of you want to look at what command I used ?

@soyebn I think that I have found and solved this problem. You can check line 434, line 440 and line 866.  LUT file is measured in seconds, line 434 should be formulated in Milliseconds according to paper.  Latency is computed in seconds in line 866.  Latency constraints=25 ms is unreasonable.  Latency constraints consistent with the LUT should be given.  That is to say, we need to ensure the consistency of the units in the entire project.

Hi @Tiantian-Han, I think what you are saying makes sense. There is some inconsistency in the assumed latency unit in the code. I think most of the latency search code uses msec as unit but the predicted latency computed in extract_expected_latency(), using LUT, returns latency in second. So I made the following change after line #429 in search.py. I assume line #434 and #440 expect latency in msec.
    list_alphas, fixed_latency = extract_structure_param_list(model, file_name=args.lut_filename,
                                                          batch_size=args.lut_measure_batch_size,
                                                          repeat_measure=args.repeat_measure,
                                                          target_device=args.target_device)
    _convert_sec_to_ms = True
    unit_scale = 1000.0 if convert_sec_to_ms else 1.0
    fixed_latency = fixed_latency * unit_scale_

I reran the search command with the above change but I still didn't get close to target latency. This is what I got,
Latency_predicted=0.06463486208752146, latency_measured=0.04632913827896118, diff=-0.018305723808560284
Do you think some more changes needed? If you were able to fix this then can you pls share your code changes?
Thanks. This was nice discussion.

Hi @soyebn,  you check again if the units of "list_alphas" and "fixed_latency"  in search.py are the same. I guess that you only modify "fixed_latency" to be in milliseconds. However, line 429 in search.py --> line 255 in nas/nas_utils/general_purpose.py --> line 226~236 in nas/nas_utils/general_purpose.py  --> line 244 in nas/nas_utils/general_purpose.py show that "list_alphas" contains latency values in seconds.
 list_betas.append(entry)
 list_betas += alpha_entries

dict_latency = compute_latency(model, list_betas, file_name=file_name, batch_size=batch_size,
                               repeat_measure=repeat_measure, target_device=target_device)
fixed_latency = dict_latency['general']
for entry in list_betas:
    if isinstance(entry, dict) and 'alpha_entries' in entry.keys():
        alpha_entries = entry['alpha_entries']
        for alpha_entry in alpha_entries:
            alpha_entry['latency'] = torch.tensor([dict_latency[s][1] for s in alpha_entry['submodules']])

return list_betas, fixed_latency

In my code, I use the unit "milliseconds" for all latency values.
e.g. @inference_time_limit=27
Latency_predicted=26.91327567897737, latency_measured=27.861732769012452, diff=0.948457090035081

Hi @Tiantian-Han, You indeed got very close to target latency. Is it possible for you to share your code changes with me? Looks like you have already done it carefully so it can save some time for me.


Not able to inject $attrs module in controller

I'm submitting a ...

[x ] bug report
[ ] feature request
[ ] other (Please do not submit support requests here (see above))

Current behavior:
$attrs is giving me injection error
Expected / new behavior:
Minimal reproduction of the problem with instructions:
Angular version: 1.6.4
Browser: [all]
Anything else:
I'm new to ng. Trying to get my hands on a custom project where I'm also using angular material library also. I have a controller which is working fine:
myApp.controller(myApp.baseController', ['$scope',
                                            //'$attrs',
                                            '$mdDialog',
                                            'getData',
                                            'postData',
                                            function(
                                            $scope,
                                            //$attrs,
                                            $mdDialog,
                                            getData,
                                            postData)

As soon as I add $attrs I'm getting this error in console:
Error: [$injector:unpr] http://errors.angularjs.org/1.6.4/$injector/unpr?p0=%24attrsProvider <- %24attrs <- myApp.baseController.
I tried googling but so far out of luck.
Let me explain you why I need $attrs module. Actually I'm trying to get rid of specifying formName when using ng-messages directive. I did using a hack which you can see here:
https://stackoverflow.com/questions/45015174/ng-messages-without-form-name
Although it's working as expected but is it the right way to do it ? or a custom directive would be the correct solution?  I don't know if there are any disadvantages of using the hack I implemented. You can see $attrs is working there but when I'm using it I'm getting injection error posted above. The reason to get the current scope's name which is a form. Is there any other way to get the scope's name in controller then I won't be needing $attrs module.
Cheers

Works for me: http://plnkr.co/edit/coleI77TUDDKLCAmsFea
$attrs etc are services / providers btw, not modules.


Linux bundle build needs to be migrated to ubuntu-latest

🧰 Task
We are currently building our Linux bundle on ubuntu-16.04. It looks like that image is deprecated which is causing our builds to fail, see e.g.:
https://github.com/napari/napari/actions/runs/988280586
The message suggests switching to ubuntu-latest. I presume though that we are using 16.04 to ensure compatibility, in which case, maybe we switch to 18.04?

This will happen on September 20th, so I am happy to give a try. I think @ziyangczi was working on this too. Should we coordinate?


A way to treat non-Success responses as Warnings

Use case(s)
When a proxied request fails (eg, returns an internal server error), I would like to see this in my logs as a warning or error.
Description
To reduce noise I only log warnings and above.
When the forwarded request fails (eg, anything but 2XX level http codes), I would like to have an easy way to log it without having to drop my log level to info or create custom Logging filter. Currently it seems to log any response, regardless of the response code, at the info level.
Alternatives
Could potentially use NLog filtering to log the messages I'm interested in:
<logger name="System.Net.Http.HttpClient.ProxyKitClient.*" minlevel="Info" writeTo="database">
  <filters>
    <when condition="ends-with('${message}','- OK') or not contains('${message}', 'End Processing')" action="Ignore" />
  </filters>
</logger>

You can add your own logging by doing something like this:
var response= await context
    .ForwardTo(_forwardTo)
    .AddXForwardedHeaders()
    .Send();

if(response.IsSuccessStatusCode)
{
	...log here...
}

return response;


[Active learning] Look at Class-agnostic counting method

more info: https://arxiv.org/abs/1811.00472
Repo to look at: https://github.com/erikalu/class-agnostic-counting

Stale


Release 0.54.1

target release date is the end of March 2023

With #4340 closed, if all of tonight's "test against main" tests pass across our various projects, I'll do a release tomorrow, April 12, 2023.

release is underway


fix: add 'linux' in the filename

Fixes #45

Hi @hervelemeur. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @ankitm123


add DNS record type documentation according to user stories

this task involves actually adding to the documentation page of our netml fork.
specifically detailing the following requested details from the user stories:

its name
a description of what it is
a description of what values it could possible be
information on the type of the column
why it is present
external references providing more detail on the concept the column is trying to represent
limitations or caveats of its use

this will involve detailing why we only include one at a time, referencing the IANA mapping between integer and record name. https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml
as well as RFC's for allowing / not allowing multiple records in one packet:
(see qdcount in section 4.1.1 and referenced to in 4.1.2 of RFC1035 https://www.rfc-editor.org/rfc/rfc1035#section-4.1.1)
However, in practice these aren’t supported by actual nameservers:
https://stackoverflow.com/questions/4082081/requesting-a-and-aaaa-records-in-single-dns-query/4083071#4083071
https://serverfault.com/questions/742785/multi-query-multiple-dns-record-types-at-once

after finishing #7 , we can now do this issue!


Integration tests

Add integration tests with swagger-tools. Also add swagger version and info hash to APISpec, since both are required for a valid API specification.

Cool! :octopus:


Adways service support

Topic
Current video player supports Adways service to add interactive content to course video. This is achieved by storing Adways interactive content ID in video xblock and by loading a specific JS library.
Before migrating fun-mooc.fr website to Marsha we'll have to decide how this support should continue.
https://github.com/openfun/libcast-xblock/blob/10cbe572d854d9903d03f6318cbe5203854eb606/libcast_xblock/public/js/videofront.js#L4

@rmoch good point!
Would be nice to find a solution that is not specific to Adways.

In #600 we introduce a plugin mechanism allowing to load third party plugins without modifying marsha source code.
This issue can be closed.


Hide till CSS is ready?

Not sure if this will work...
Check to see if we can set a class to "Hide" till the full CSS is ready to see if the "flicker" can be avoided

Did as best can be done...


[graph] Analyze barriers between dispatches to estimate HIP graph benefits

Compile unet and ratio between barrier and dispatches.

This is done--we roughly have 90% of launches with following barriers. So the model gives us parallelism itself.


Ignore npm notice New major version of npm available! 9.8.0 -> 10....

RuntimeError: MJML stderr is not empty: mjml-migrate is deprecated and will be removed in mjml 5
This should probably be a warning instead.

This issue is not related to django-mjml. Try to check your mjml-code and be sure you use new tags. Also you can use older version of mjml if you prefer using old mjml-tags.


Fix for the content dialog overlay corner radius.

Description
Removed the corner radius from the root layout grid from the content dialog.
Motivation and Context
The corner radius is making the overlay background corner rounded and causing weird effect on Windows 10, since it does not have rounded windows.
Closes #5301
How Has This Been Tested?
Tested using the MUXControlTestApp, the changes can be seen in the screenshots below.
Screenshots:
Before:

After:

/azp run


chore() include package-lock.json

Fixes https://github.com/simplesvg/tools/issues/4

Fixes https://github.com/simplesvg/tools/issues/6

I don't see point in including it.
File is specific to your installation only, containing information about packages npm has installed on your system. Since repository doesn't contain node_modules, information in package-lock.json is completely irrelevant to repository. package.json already contains information about required modules.

Actually you are right. Sorry. package-lock is intended to be included in repository and it is ignored when publishing package. Issue where package-lock would override package.json data has been fixed a while ago.


Promise polyfill and async/await transpliation make it hard to debug

Description:
During debugging, stack traces of code that contains Promises doesn't supply data about code executed before promise resolution.
That is because currently have two mechanisms in place:

Promises are polyfilled using promise
async/await is transpiled using regenerator.

We can get a pretty stack trace if we manage to turn off the Promise polyfill and regenerator transpliations.

Promise polyfill can be removed on both iOS (Supported from iOS 10 which is React Native's new minimum & Android (JSCore & Hermes on Android support native Promises). Should be tested thoroughly to make sure the native implementations work as expected and are stable.

Regenerator (async await) can't be removed yet (as Hermes doesn't support it and iOS minimum is iOS 12), but maybe we can supply an easy option to turn it off (using some flag in metro?)

React Native version:
0.61
Steps To Reproduce

Create a react-native project
Write code with async/await or Promises
Debug
Put a breakpoint after promise resolution (inside .then() callback or after await
Look at the stack trace

Expected Results
See the full stack trace including code that ran before the Promise was initiaited, as is supported in Chrome DevTools.
Snack, code example, screenshot, or link to a repository:
How the stack trace looks currently (bad):

How the stack trace looks with native Promise & async/await (good):

Code taken from open source project react-native-demo

During my testing I found some specific calls to NativeModules (such as FileReaderModule.readAsText and Networking.addListener) fail on the native side due to a mismatch in arguments.
This happens only after disabling regenerator-transform (using native Promise works fine).
I'm investigating it now (suggestions for possible causes are welcome!)

Not stale.
This is still an ongoing issue: not just within the context of debugging, but also performance/bundle size. On newer iOS/Android versions these transforms are unnecessary.

(using native Promise works fine)

@EdenGottlieb could you please share how did you manage to disable React Native's Promise polyfill?

(using native Promise works fine)

@EdenGottlieb could you please share how did you manage to disable React Native's Promise polyfill?

Sure.
This was a long time ago, so I can't recall it perfectly, and it may not work on recent versions, so take this with a pinch of salt.
It worked in a "hello world" app but didn't do so well in a full fledged app.
For using native Promise:
node_modules/react-native/Libraries/Core/InitializeCore.js:
Comment out this line:
require('./polyfillPromise');
For native async-await (this one caused me most of the problems):

node_modules/react-native/Libraries/Core/InitializeCore.js:
Comment out this line:
require('./setUpRegeneratorRuntime');
node_modules/metro-react-native-babel-preset/src/configs/main.js:
From the defaultPlugins array, remove the entry with  @babel/plugin-transform-regenerator (should look something like  [require("@babel/plugin-transform-regenerator")])

Good luck!


core: move to sdbus-cpp2

Needs testing
@fufexan ci

Things like lock_cmd, before_sleep_cmd and after_sleep_cmd dont seem to work anymore. Probably caused by these error messages which are printed:
...
[LOG] wayland done, registering dbus
[WARN] Couldn't connect to logind service ([org.freedesktop.DBus.Error.ServiceUnknown] The name is not activatable)
[LOG] Using dbus path
[WARN] Couldn't retrieve current systemd inhibits ([org.freedesktop.DBus.Error.ServiceUnknown] The name is not activatable)
[TRACE] [core] got poll event
...

main (for reference):
...
[LOG] wayland done, registering dbus
[LOG] Using dbus path /org/freedesktop/login1/session/_33
[TRACE] [core] got poll event
...

Otherwise listeners and their inhibition seems to work (tested with wayland idle inhibitor)

@VirtCode try now

The connection seems to do something now:
[LOG] wayland done, registering dbus
[LOG] Using dbus path /org/freedesktop/login1/session/_33

However, the before_sleep commands etc. are still not working. Also, the normal listener don't seem to work anymore. It's odd that there are no longer any [TRACE] [core] got poll event printed.

piss of shit, I'll fix it later, not at pc rn

@andresilva you committed that feature, any ideas?

thanks bae

yeah, also saw this yesterday and tried to patch it out locally, but it doesn't fix the issue. Can still reproduce it on 0.1.4.
For me it looks like the second callback (UnInhibit) just never gets called.

open a new issue


Laravel 5.4 Shift

This pull request includes the changes for upgrading to Laravel 5.4. Feel free to commit any additional changes to the shift-3314 branch.
Before merging, you should:

Checkout the shift-3314 branch
Review all pull request comments for additional changes
Run composer update (if the pre-commands fail, add --no-scripts)
Thoroughly test your application

If you would like more help with your upgrade, check out the human services from Laravel Shift. And if you want to level-up your Git skills, check out Getting Git.

ℹ Laravel 5.4 added new middleware to handle whitespace in request data. This may affect the data your application received. Read this post on Laravel News for more detail to see if you need to modify your application.

❌ Shift could not upgrade the following project files since they differed from the default Laravel version. You will need to compare these project files against the default Laravel 5.4 versions and merge any changes:

[ ] resources/assets/js/bootstrap.js

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.4 configuration files and merge any changes:

[ ] config/cache.php
[ ] config/database.php
[ ] config/session.php

❌ Support for later, send, and queue on the Mail facade has changed in Laravel 5.4. You should update your project to use Mailables.
Shift found potential uses of these methods in:

[ ] app/Console/Commands/TestSmtpCredentials.php
[ ] app/Http/Controllers/AuthenticationController.php

❌ The container's make method no longer accepts a second parameter in Laravel 5.4. This typically indicates a code smell and you should construct the object in another way.
Found potential uses of the second parameter in:

[ ] app/Http/Controllers/BillingController.php
[ ] app/Http/Controllers/ContractController.php

❌ Shift detected the Forms and HTML package by the Laravel Collective. The recommended version is 5.4.* for Laravel 5.4. You should review your laravelcollective/html dependency to ensure it is compatible. Review the Installation Docs for more details.

❌ In Laravel 5.4, the trans function signature changed. It no longer accepts the $domain argument.
Shift found potential uses of trans() in:

[ ] app/Http/Controllers/TicketController.php
[ ] app/Http/Controllers/AuthenticationController.php
[ ] app/Http/Controllers/ProfileController.php
[ ] app/Http/Controllers/BillingController.php
[ ] app/Http/Controllers/DataUsageController.php
[ ] app/Http/Controllers/PayPalController.php
[ ] app/Http/Middleware/PortalAuth.php
[ ] app/Http/Middleware/ContractMiddleware.php
[ ] app/Http/Middleware/DataUsageMiddleware.php
[ ] app/Http/Middleware/AuthMiddleware.php
[ ] app/Http/Middleware/TicketMiddleware.php
[ ] app/Exceptions/Handler.php
[ ] app/Services/FormattingService.php
[ ] resources/views/pages/contracts/index.blade.php
[ ] resources/views/pages/root/create.blade.php
[ ] resources/views/pages/root/index.blade.php
[ ] resources/views/pages/root/new_password.blade.php
[ ] resources/views/pages/root/register.blade.php
[ ] resources/views/pages/root/reset.blade.php
[ ] resources/views/pages/tickets/create.blade.php
[ ] resources/views/pages/tickets/show.blade.php
[ ] resources/views/pages/tickets/index.blade.php
[ ] resources/views/pages/billing/create_payment_method.blade.php
[ ] resources/views/pages/billing/payment_success.blade.php
[ ] resources/views/pages/billing/index.blade.php
[ ] resources/views/pages/billing/make_payment.blade.php
[ ] resources/views/pages/paypal/cancel.blade.php
[ ] resources/views/pages/paypal/error.blade.php
[ ] resources/views/pages/paypal/success.blade.php
[ ] resources/views/pages/data_usage/purchase_top_off.blade.php
[ ] resources/views/pages/data_usage/index.blade.php
[ ] resources/views/pages/data_usage/add_top_off.blade.php
[ ] resources/views/pages/profile/show.blade.php
[ ] resources/views/layouts/partials/nav.blade.php

ℹ Laravel 5.4 no longer includes the ability to customize the PDO "fetch style". Now PDO::FETCH_OBJ is always used. If you need to customize the fetch style, check the Database section of the Upgrade Guide for more details.

ℹ In Laravel 5.4, the date cast creates a Carbon object which calls startOfDay. If you need to preserve the time portion of the date, you should use the datetime cast or convert your column to a datetime. Review the documentation on Attribute Casting for more details.

⚠ Per the Upgrade Guide, you should run php artisan view:clear and php artisan route:clear after upgrading all packages to flush the view and route cache.

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.

ℹ If you are running MySQL prior to version 5.7.7, you may receive a specified key was too long error. You can either upgrade your MySQL or review this post for code to resolve this issue.


Custom prefix feature doesn't work

Whenever I run this command:
concurrently "docker-compose up" "nodemon src/"

I get a basic output with the process default index

But if I specify a custom prefix like in this line of README.md, I got no prefix at all, even the process index disappears.
So after running this command:
concurrently --prefix "{time}-{pid}" "docker-compose up" "nodemon src/"

I get this output as I described

I'm using Node v8.11.3 on Linux Debian.
I don't know if this is a bug or I'm doing something wrong?

@gustavohenke if it's a bug as you labeled this issue; why did you close it?

Oh. thanks @gustavohenke

v3.6.1 published to npm with the fix.


dead link in page

dead link under "OpenEvent Fails in a Non-Administrator Account"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98e9ef9d-c821-66a5-add5-ca2889a4b299
Version Independent ID: 23767e29-a42c-3703-24a0-ce8d6c354d22
Content: IoCreateNotificationEvent function (wdm.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdm/nf-wdm-iocreatenotificationevent.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Thanks for the report.  I had a look around and could not find the target article, so I removed the link.
The update should be live within an hour.


Should be using host not build for our packages

(with conda-build 3)

Will be covered by https://github.com/pyviz/pyctdev/pull/6


Fixed map showing Technion parking areas

A static map (which will have dynamic areas - the colors of the parking areas) that shows the entire Technion and its parking areas.

I think it better to have one person and only one for this issue

@ortroyaner -  Please set a milestone to this issue.

Not relevant to this version of the project, has been closed.


Upgrade Linux Kernel for flatcar-3602 from 5.15.117 to 5.15.118

Subject says it all.

See instead https://github.com/flatcar/scripts/pull/954


[Storage] [DataMovement] [Files] Fixed share file container listing when directory is listed on download

The share file listing was returning a directory however we weren't checking to make sure that we can skip over those.
No need to update change log since the feature has not been released yet

/azp run net - storage - tests

API change check
API changes are not detected in this pull request.

/check-enforcer override


Use cherow instead of acorn

Cherow is a new and very fast Javascript parser.
Use it in @cush/buble, @cush/nebu, and @cush/butternut.
And use it for parsing dependencies.

The uglify-js plugin can use the Cherow AST, too! Awesome. :)
https://github.com/mishoo/UglifyJS2#estree--spidermonkey-ast


Add lint check

Current dependencies on/for this PR:

main

PR #75   👈

This comment was auto-generated by Graphite.


Enterprise UI can't start due to React Markdown styled component

Enterprise UI can't start due to this error:

Following the trace leads to the styled component Editor which is created with the import of React Markdown in /Policies/Utils/PolicyUtils - changing the import to simply 'react-markdown' and removing the .min portion fixes the issue, but I want to make sure that the styled component still works.
@AsmaaNabilBakr

Fixed in above issue - closing


Improve Step 3 in MacOS instructions

I can see MacOS users getting lost here in Step 3 here : https://highdimensionaleconlab.github.io/VarianceComponentsHDFE.jl/dev/#MacOS.
Is there a way to add bin to PATH without manually editing .bash_profile. If there's no other way then we should provide some steps on how to open and edit that.

I don't use OSX.

I see. I'll investigate further on this.


storage - implement SetBlobProperties API

see https://msdn.microsoft.com/en-us/library/azure/ee691966.aspx
some blobs need these to be useful. for example Content-Type for various media files must be set for clients (including browsers) to treat them correctly.

@kenegozi want to contribute? Shouldn't be that hard.

@ahmetalpbalkan why is BlobProperties.LastModified a string and not a time.Time?

@kenegozi good question, I don't remember to be honest. Might be a mistake. Looks like Go supports RFC1123 just fine, so we can change.

hmm there is no apparent way for xml unmarshal to deal with non rfc3339 dates.
It is easy peasy when working with headers, it's just that pesky ListBlobs operation that makes this a no-go.
For now I'll keep dates as strings, and will come up with another solution for dates throughout the package separately.

Way I fixed that in my own application:

Functionality already added.


Look into Jupyter Scheduler for possible integration into Nebari

Context
https://blog.jupyter.org/introducing-jupyter-scheduler-f9e82676c388
Value and/or benefit
Allow users to schedule notebooks in a Jupyter native way
Anything else?
No response

I have been looking into what it would take to integrate Jupyter-Scheduler into Nebari, specifically integrating Argo-Workflows.
Jupyter-Scheduler enables users to extend their ExecutionManager class which we can take advantage of to submit a workflow running the notebook.
This would require a small new package, perhaps called argo-workflow-executor (or similar) that exposes an ArgoWorkflowExecutor class. To submit workflows, we can use Hera-Workflows (the python client for Argo-Workflow).
This new Executor class can then be pulled into the jupyter_server_config.py as follows:
from argo_workflow_executer import ArgoWorkflowExecutor

c = get_config()

c.Scheduler.execution_manager_class=ArgoWorkflowExecutor

The workflow admission controller work Adam has been working on (https://github.com/nebari-dev/nebari/pull/1741) is a perfect complement to this solution as it will ensure that the user's conda environments and home directory are copied over to the workflow specs.

This is tangentially related, but it would be awesome to get the necessary Argo env vars set up by the Kubespawner when the user pod spins up - https://github.com/nebari-dev/nebari-docs/issues/278#issuecomment-1546817482 - it'd make the user experience that much better.

As I've worked on integrating Jupyter-Scheduler into Nebari, I found it to be a little more challenging than originally envisioned. This is due to two or three main factors:

It took me a while to recognize that our version of JupyterHub (1.5) spawns the user's server (ie JupyterLab) using jupyterhub-singleuser as opposed to jupyter server; this resulted in the Jupyter-Scheduler not being recognized as a valid extension, similar to this issue. It's my understanding that later versions of JupyterHub use jupyter server so in the meantime, we will need to make the following modifications for this extension to work:

We will need to set the following environment variable (through KubeSpawner):
JUPYTERHUB_SINGLEUSER_APP = jupyter_server.serverapp.ServerApp
We will need to rename jupyter_notebook_config.py to jupyter_server_config.py.

The more complicated reason why integrating Jupyter-Scheduler into Nebari is tricky has to do with the fact that Jupyter-Scheduler is a JupyterLab extension that runs on each user's JupyterLab pod and it has no awareness of JupyterHub/Argo-Workflows, etc. This means jobs will only run when the user's JupyterLab pod is running which defeats the purpose of integrating such an extension.

I believe I am able to get around this by submitting "scheduled jobs" as Cron Workflows but this required deeper modifications than I initially anticipated.

The last reason this is more complicated has to do with how Argo-specific environment variables (ie. ARGO_TOKEN, etc) need to be set. Initially, I thought they could be set in the user's running JupyterLab pod. Unfortunately, they will need to be set on the pod prior to launching JupyterLab (and Jupyter-Scheduler).

I'm still working on how to most effectively accomplish this. My first thought is to include another initContainer that will pull these environment variables in but where these env vars come from, I still need to investigate.

We can add the Argo service account ARGO_TOKEN secret an environment variable on a per user basis (admin, developer, or viewer). This will require some modifications to the Nebari-Workflow-Controller (see PR for those updates).


rocblas installation fails during Tensile run with os.fork(): OSError: [Errno 12] Cannot allocate memory

Please have a look at spack/spack/issues/26400

#1440 should help with limiting the amount of memory Tensile uses, although I don't think rocBLAS is making use of the changes yet.

In a future releases of rocBLAS https://github.com/ROCmSoftwarePlatform/rocBLAS/commit/0ffee0626bf987bae6b81183a5c61569a489537a  there is a new install.sh argument  -j  to be used by make/ninja for parallel build control and will be passed down to Tensile build.   It will just set the cmake argument exposed in the PR mentioned by Ben.


Ensure open() idempotency in track 2 service bus handlers.

Ensure that open() leaves handlers in a sane state even on failure, and that recovery can happen properly.
Adds tests to validate this.

/azp run python - servicebus - tests


Add data/data_template/title to alert component

Description:
**Pull request in home-assistant.io with documentation (if applicable): TBD
Example entry for configuration.yaml (if applicable):
# Example configuration.yaml entry
alert:
  garage_door:
    name: Garage is open
    entity_id: input_boolean.garage_door
    state: 'on'   # Optional, 'on' is the default value
    repeat:
      - 15
      - 30
      - 60
    can_acknowledge: True  # Optional, default is True
    skip_first: True  # Optional, false is the default
    title: 'Garage'
    data:
      data:
        inline_keyboard:
          - 'Close garage:/close_garage, Acknowledge:/garage_acknowledge'
    notifiers:
      - frank_telegram

Checklist:

[X] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

Hi @syphernl,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

The tox tests are failing, not sure why though. Any pointers?

https://travis-ci.org/home-assistant/home-assistant/jobs/443714441#L1098 - you added extra arguments to the init function, the tests will need to be updated to include those.

Is this PR clashing with https://github.com/home-assistant/home-assistant/pull/17516?

It did. Pr should be rebased

I would decouple the extended template handling from the changes to the alert component, as this would be helpful for other templates as well.

PR is ready for review

Any chance this getting into 0.84?


How to add custom response properties?

Hi,
Would like to know how to add custom top level properties? Did not see at the docs how to do it.

@ChaosPower By default, you can't, because i use the  DataArraySerializer.
If you want to change the output format, you have to change the serializer. To do that, you have to create your own service provider. You can see the service provider of this package  for more details.

@maximebeaudoin thanks! That hint will do. I'm trying to follow  google's JSON style guide.


Test Issue for Automated Script

This is a test issue created by an automated script.

This is a test comment added by an automated script.


naming conventions with union types throwing a SchemaException

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I've added a naming convention into my GraphQL schema that converts object fields into snakecase, after doing so my union types are throwing a SchemaException that fields are not being implemented. It looks as though these fields are being checked without respecting any naming conventions that are being applied, so it's unable to find the implemented fields.
Steps to reproduce

create a naming convention that is going to change member object types
create a union type and and implementing type
create a query using the union type
run the application and any fields the naming convention transforms will create a SchemaException that the fields are not being implemented

Relevant log output
1. The field `createdAtUtc` must be implement by object type `File`. (HotChocolate.Types.ObjectType<Giantnodes.Dashboard.Api.FileSystem.Types.FileSystemFileNode>)
2. The field `modifiedAtUtc` must be implement by object type `File`. (HotChocolate.Types.ObjectType<Giantnodes.Dashboard.Api.FileSystem.Types.FileSystemFileNode>)
3. The field `createdAtUtc` must be implement by object type `Directory`. (HotChocolate.Types.ObjectType<Giantnodes.Dashboard.Api.FileSystem.Types.FileSystemDirectoryNode>)
4. The field `modifiedAtUtc` must be implement by object type `Directory`. (HotChocolate.Types.ObjectType<Giantnodes.Dashboard.Api.FileSystem.Types.FileSystemDirectoryNode>)

Additional Context?
Naming Convention:
public class SnakeCaseNamingConventions : DefaultNamingConventions
{
    public override NameString GetMemberName(MemberInfo member, MemberKind kind)
    {
        if (kind == MemberKind.ObjectField)
        {
            var pattern = new Regex(@"[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+");
            return string.Join("_", pattern.Matches(member.Name)).ToLower();
        }

        return base.GetMemberName(member, kind);
    }
}

Union Type Interface:
public interface IFileSystemNode
{
    string Path { get; set; }
    string Name { get; set; }
    long Length { get; set; }
    DateTime CreatedAtUtc { get; set; }
    DateTime ModifiedAtUtc { get; set; }
}

Implementing Type:
[GraphQLName("File")]
public record FileSystemFileNode : IFileSystemNode
{
    public string Path { get; set; } = null!;
    public string Name { get; set; } = null!;
    public long Length { get; set; }
    public bool IsReadOnly { get; set; }
    public string? DirectoryName { get; set; }
    public DateTime CreatedAtUtc { get; set; }
    public DateTime ModifiedAtUtc { get; set; }
}

Query:
public async Task<IEnumerable<IFileSystemNode>> DirectoryContents(
    [Service] IMapper mapper,
    [Service] IRequestClient<GetDirectoryContentsQuery> client,
    GetDirectoryContentsQuery command,
    CancellationToken cancellation
)
{
   .... omitted for brevity
}

Product
Hot Chocolate
Version
12.10.0

Can you upload a simple project showing this error?

@michaelstaib I've created a simple project of the issue here https://github.com/PHILLIPS71/hot-chocolate-5124

Awesome ... thanks for that, I will have a look.

There is a small issue in your naming convention.
public override NameString GetMemberName(MemberInfo member, MemberKind kind)
        {
            if (kind is MemberKind.ObjectField or MemberKind.InterfaceField or MemberKind.InputObjectField)
            {
                Console.WriteLine(kind);

                var pattern = new Regex(@"[A-Z]{2,}(?=[A-Z][a-z]+[0-9]*|\b)|[A-Z]?[a-z]+[0-9]*|[A-Z]|[0-9]+");
                return string.Join("_", pattern.Matches(member.Name)).ToLower();
            }

            return base.GetMemberName(member, kind);
        }

After fixing that it works.

However ... there is also a small bug that I have found, interface fields are internally handled as InputObjectFields which is wrong. The fix for this is coming with the next patch release.
The code posted above will work with both versions.

Please provide feedback if this works now for you.
I will leave this issue open until the PR is merged.

The fix is now integrated into:
https://github.com/ChilliCream/hotchocolate/releases/tag/12.11.1

The amended code snippet above works like a charm!


Text input: display is cut on RTL character sets

Describe the bug
When typing a new post or reply in right-to-left character sets, the right edge (read: the beginning of each line) is cut, the character is not fully displayed
To Reproduce
Steps to reproduce the behavior:

Open a new post (or reply)
Using RTL character set (e.g. Hebrew, Arabic), type in text
The right edge of the text is cut.

Expected behavior
The entire character should appear.
Screenshots

Details

Platform: Android
Platform version: 13
App version: 1.47.0 (34)

@ansh this seems similar to the images overflowing so assigning this to you as well, might be a similar issue at play

Hi @pfrazee, I see that #1323 is closed. This bug still happens (v1.51)

Reporting on this bug, this keeps happening with this post with mixed arabic and latin letters:
string "OKX" cut on the left side on post text

Same string "OKX" also cut on the left side even on link embeds.


RIFE 4.9 support

Could you add support for RIFE model 4.9?

This slowly feels like quantity over quality at this point, since a new model gets released like weekly. I will wait for a while.

I agree  4.10 is out now too


Reparse version 3

@aolieman Your changes can be seen here. I pulled them manually and merged them with the other changes into the develop branch.
This is a continuation of #4


Fix libffi: make universal binary for OS X only

Without this fix, building libffi from source fails on Linux with an error message: "Error: Non-Apple GCC can't build universal binaries"

This issue should be resolved by disabling the ENV.universal_binary function:
https://github.com/Linuxbrew/linuxbrew/blob/master/Library/Homebrew/extend/ENV/std.rb#L296
Add return unless OS.mac?

return unless OS.mac? stops compilation on Linux at all.

Sorry, I wasn't clear. Add return unless OS.mac? to the function ENV.universal_binary in std.rb.

Thanks! I've added the proposed change to std.rb and updated my request.

Please squash all the commits to a single commit and change the commit log message to "Disable ENV.universal_binary for Linuxbrew".

Updated my request as requested :)

Thanks for your contribution, Maxim.


Protect membership member keys concurrent access

What changed?
Adding read lock for member keys

Why?
There was a race condition when Lookup is called during periodic member Refresh

How did you test it?
Wrote a separate test case to be checked with -race flag

Potential risks

Release notes

Documentation Changes

Not directly related to your current changes, but can members, err := r.peerProvider.GetMembers(r.service) in refresh be time consuming?
Maybe it is better to call it before taking the write lock?

Not directly related to your current changes, but can members, err := r.peerProvider.GetMembers(r.service) in refresh be time consuming? Maybe it is better to call it before taking the write lock?

Good call. If peer provider is not keeping members in-memory and is doing network call, this might be a problem. Will address this in a separate PR

Pull Request Test Coverage Report for Build fc25e9cf-13e7-4a24-93d8-51251568d5de

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.05%) to 56.913%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
2
88.6%

service/matching/matcher.go
2
91.46%

Totals

Change from base Build e6b57bb5-3b13-4a15-931a-61d00c39ca06:
0.05%

Covered Lines:
83035

Relevant Lines:
145898

💛  - Coveralls


Config time_period value (e.g. 12:34) parsing inconsistencies

Home Assistant release with the issue: 0.96.5
Last working Home Assistant release (if known): -
Description of problem:
Config values using the config_validation.py type time_period get interpreted in inconsistent ways. I stumbled upon this while configuring the deutsche_bahn component which has an offset time_period property - but this is a general problem with configuration values of time_period type. See below.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
offset1: "12:34:56" # -> HH:MM:SS
offset2:  12:34:56  # -> HH:MM:SS
offset3: "12:34"    # -> HH:MM
offset4:  12:34     # ->    MM:SS

Additional information:
This is a result of pyyaml/YAML1.1 being used when loading the configuration yaml. Ruamel/YAML1.2 would interpret example offset4 the same way as offset3 is interpreted, which would solve the inconsistency issue.
Reason: YAML1.1 supports sexagesimals which YAML1.2 no longer does - this solves the issue. I tried with ruamel instead of yaml and got the expected consistent results.
I guess there could be reasons for YAML1.1 being used here instead of YAML1.2, so maybe this has to be this way :)

I just got an answer on discord that this would be a major breaking change.. so I guess this won't happen o.o


Test network throttling

Hi, is there a way to confirm that the network is being throttled? I run throttle --up 10000 --down 30000 --rtt 80 --log and then to test it a run networkQuality but I'm not seeing the throttled numbers:
==== SUMMARY ====
Upload capacity: 39.047 Mbps
Download capacity: 758.893 Mbps
Upload flows: 20
Download flows: 16
Responsiveness: Medium (661 RPM)
Is that expected?
Thanks,
Ryan.

Hi @mint3000 it seems networkQuality do not care about the setup, I get the same as you. I usually use it with Browsertime/sitespeed.io but else you can just try your browser and test with 3g or something.


External Service (API) Helper

[ ] Helper class to connect to external service via REST API
[ ] Use config helper to get service details: https://github.com/devlinjunker/template.node.hapi/blob/master/conf/config.yaml#L41

weather?
connect to github via public api? (retrieve issues/prs?)

[ ] GET/POST/PUT/DELETE requests
[ ] Trace log the request and responses
[ ] performance logging?

Later:

oauth/google drive
private config file containing any hidden/secret keys (or just env.properties -- added to .gitignore)

Extends OpenAPI generated classes?


Line 729 Syntax error

At the end of install after copying the config and wallpaper, I’m getting ./install-hyprland-v3: line 729: syntax error near unexpected token `(‘
Then it exits the install.

Reviewed previous issue, my apologies.


Features/django2

I've tried to make it compatible with django 2, I've added the on_delete for the ForeignKey and changed the url using django.urls.
Let me know if it's okay, I haven't tested it yet, just checked that django 2 doesn't show any error or warn

Thanks, I will have a look at it ...

thank you, but it is no longer needed, the current code is now compatible


Rendering issues on macOS Catalina

Short info header:

GFX version: 0.3.1
OS: macOS Catalina
GPU: Intel UHD Graphics 630 1536 MB

I'm seeing this with a project I'm working on via Amethyst. The window will open to a black screen that doesn't update unless I resize the window, then it seems to work okay. Meanwhile, [WARN][gfx_backend_metal::window] No frame is available repeats ad nauseam.

[[package]]
name = "gfx-backend-metal"
version = "0.3.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "arrayvec 0.4.12 (registry+https://github.com/rust-lang/crates.io-index)",
 "bitflags 1.2.1 (registry+https://github.com/rust-lang/crates.io-index)",
 "block 0.1.6 (registry+https://github.com/rust-lang/crates.io-index)",
 "cocoa 0.19.1 (registry+https://github.com/rust-lang/crates.io-index)",
 "copyless 0.1.4 (registry+https://github.com/rust-lang/crates.io-index)",
 "core-graphics 0.17.3 (registry+https://github.com/rust-lang/crates.io-index)",
 "foreign-types 0.3.2 (registry+https://github.com/rust-lang/crates.io-index)",
 "gfx-hal 0.3.1 (registry+https://github.com/rust-lang/crates.io-index)",
 "log 0.4.8 (registry+https://github.com/rust-lang/crates.io-index)",
 "metal 0.16.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "objc 0.2.7 (registry+https://github.com/rust-lang/crates.io-index)",
 "parking_lot 0.9.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "range-alloc 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "raw-window-handle 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)",
 "smallvec 0.6.13 (registry+https://github.com/rust-lang/crates.io-index)",
 "spirv_cross 0.15.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "storage-map 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "winit 0.19.5 (registry+https://github.com/rust-lang/crates.io-index)",
]

Thank you for filing! Do you see this happening on the colour-uniform example?

(marking as medium priority because I hope Amethyst can use the new swapchain model (that our quad example shows) instead of the old one)

Hey again! I actually do not see this issue occurring on the colour-uniform example. Guessing that implies an issue on the Amethyst side. I also noticed that the version of gfx-hal and the Metal backend (guessing others as well) is about a half year behind.


[Help] How to use it?

Hi,
I'm using Linux server, which directory should I put this binary in?

@FengLing02
Hi!
I added the installation guide https://github.com/miscord-dev/palog#usage
Check it and give me a feedback!
palog only depends on RCON, so you can put the binary anywhere.

If you still have concerns, create a new issue.


to fix trivia in version checking

@pmorie as far as I understand this is needed to have something working

Sorry, realized afterwards code is vendored. This https://github.com/openshift/build-machinery-go/pull/15 is (hopefully) better off


"Cancel" may have an effect on further upload processes

Testserver: qa edmond/upverse
Browser: ff
OS: Windows/Linux
Version: 03.04.2024
User: admin/user
Actions:
select data set -> "files" -> select min. 250 files -> "upload" -> "cancel" during the late stage of the upload process
upload list is cleared -> "files" -> select files -> "upload"
Observation:
-> Upload is not possible, the upload hangs at the first position. To be able to upload again, Upverse has to be closed.

Expected result: "Cancel" has no effect on further upload processes

If not reproducible then seems to be fixed.

Bug fixed in previous release.

Version: v1.3.0 (https://github.com/MPDL/upverse/commit/116eb01a4cb54889b7f22c8697c19968929f4eb3)
OS: Linux
Testserver: QA.edmond
Testdate: 03.09.2024
User: User
Test result: If the Upload is canceled after all Files are marked as uploaded, but before the "Upload report" is displayed, the described observation occurs: The Upload of files is then no longer possible (until restarting upverse)


Errors on compiling scripts for Android build

Unity 2019.3.3
When compiling scripts for Android build, 3 errors occurred:
Assets\LiteNetLibTransport\LiteNetLibTransport.cs(242,30): error CS0508: 'LiteNetLibTransport.ClientSend(int, ArraySegment)': return type must be 'void' to match overridden member 'Transport.ClientSend(int, ArraySegment)'
Assets\LiteNetLibTransport\LiteNetLibTransport.cs(321,30): error CS0115: 'LiteNetLibTransport.ServerSend(List, int, ArraySegment)': no suitable method found to override
Assets\LiteNetLibTransport\LiteNetLibTransport.cs(11,18): error CS0534: 'LiteNetLibTransport' does not implement inherited abstract member 'Transport.ServerSend(int, int, ArraySegment)'
Steps:

import Noble Free Connect from AssetStore;
import Mirror from AssetStore;
import Mirror Noble Connect package from Noble folder;
import LiteNetLibTransport package from Releases (latest is v0.7.1 for now);
open Noble Connect / Mirror / Examples / NetworkManager / Example Mirror;
add LiteNetLibTransport to Example Noble Network Manager;
open Build Settings, switch to Android.

It seems to be caused by #if MIRROR_26_0_OR_NEWER preprocessor directive.
When compiling for Windows, the statement is true, and there are no compilator errors.
When compiling for Android, the statement is false, and it chooses the alternative code which causes compilator errors.

It seems to be caused by #if MIRROR_26_0_OR_NEWER preprocessor directive.
When compiling for Windows, the statement is true, and there are no compilator errors.
When compiling for Android, the statement is false, and it chooses the alternative code which causes compilator errors.

Mirror should automatically add MIRROR_26_0_OR_NEWER as a preprocessor directive to all build types.
You might be able to select android as the target platform then manually add the define to the list in the player settings

Mirror should automatically add MIRROR_26_0_OR_NEWER as a preprocessor directive to all build types.
You might be able to select android as the target platform then manually add the define to the list in the player settings


background color queries are being printed out

reproducible: run ./examples/pty and ssh into it.
you'll see:
^[]11;rgb:1a1a/1b1b/2626^G^[[?1;2;4cHello, world!

this started on v1.4.3

i suspect https://github.com/charmbracelet/wish/commit/94788c7671da71a83e52872a24efa3507a4b46ec

confirmed 🤔
only happens when requesting a PTY though 🤔


They looked like multiple steps.

Just to make it a little clearer.

What about:
Option 1: Using antigen
Option 2: Using oh-my-zsh
Option 3: Using zplug

Could we give it a try?

how about
### Install using <method>

Yeah, much better.

@Indyandie Are you up to implement the format you described above? Let me know :)

@desyncr okay we should be all good now 👍🏾👍🏾


Collection ABCs not used on Python 2.7

On Python 2.7 there is no collections.abc module, instead the collection base types are available directly in the collections module
The current code says:
try:
    from collections.abc import Mapping, Iterable
except ImportError:
    Mapping = dict
    Iterable = (tuple, list)

I recommend putting from collections import Iterable, Mapping as the except case, possibly still including the fallback for even earlier Pythons but possibly not as this totally changes how the library works rather unexpectedly. At the very least, a warning should happen when this fallback mode is used.

Great catch. I will update it to change it to from collections import Iterable, Mapping as suggested.
There are other new factors in 3.x that break anything below 2.7 anyways.

Fixed in 3.1 https://github.com/cdgriffith/Box/commit/252e2f574213708cbbcd42bdec442434384127fe


ImmutableJS

Since the last discussion (#46), I've read a lot and worked on a project with ImmutableJS. Last time I did not know about the performance benefits with shouldComponentUpdate. These are significant, because Immutable state equality operations (i.e. checking if the state of a component changed) are much faster.
I'm now reconsidering, and think using ImmutableJS by default is a good idea. With the new application structure (#27) this boilerplate is ready to scale, and ImmutableJS should not be missing in any big react app.
For small applications it's not entirely necessary, but the syntactic sugar for reducer is a side-benefit that small apps also experience.
I'd love a PR implementing ImmutableJS and the PropTypes!

Note: If you submit a PR, please do it against the v3.0.0 branch of this repo!

Done by #131!


Add Go Docker updates for boring/FIPS branches

Add "BranchSuffix" to the Go Docker versions.json format to add "-fips" into the generated tags. Change the update generation code to detect when a build came from a boring/FIPS branch and update the correct versions.json entry with the new build.
I moved buildmodel.parseVersion to buildassets.ParseVersion so I could use it in buildassets (without causing a circular reference).

The versions.json configuration is being added by: https://github.com/microsoft/go-images/pull/49.

FYI: Go uses https://pkg.go.dev/golang.org/x/mod/semver to parse semantic version strings. Importing it is probably an overkill, but it is a good reference point and its test-suite is also something we would bring.

Interesting... it seems like it doesn't have a way to get patch version? (Or MajorMinorPatch?) Otherwise I'd go ahead and import it. I poked through the test cases and didn't see anything that seems too useful for our func. (But we aren't trying to parse build parts, or canonicalize.)


Missing "ignore" entry in bower.json

When including ngAudio from bower, the following warning is thrown:
bower ngAudio#~1.6.2              invalid-meta angular-audio is missing "ignore" entry in bower.json
While this obviously doesn't break anything, it'd be easy to include an empty ignore entry to avoid the warning being thrown. Should only take a minute to fix it!

Looks good. You are clear to submit a PR

fixed


Release v0.3.1

This is a draft of changelog for the v0.3.1 release.
Here you can find all related translations changes: v0.3.0...main.

⚠ Do not merge this pull request manually ⚠
You should approve this pull request instead. After approving, I will automatically update it (release date needs to be adjusted), merge, and tag a new release. You can read more about the process on forum.

Show release notes preview
v0.3.1

Updated translations for extensions:

the-turk/flarum-miserable-users

All changes: v0.3.0...v0.3.1.

Success! Now you can announce new release on forum:
## Version [`v0.3.1`](https://github.com/flarum-lang/tamil/releases/tag/v0.3.1)

**Updated translations for extensions**:

* [`the-turk/flarum-miserable-users`](https://github.com/the-turk/flarum-miserable-users)

All changes: [v0.3.0...v0.3.1](https://github.com/flarum-lang/tamil/compare/v0.3.0...v0.3.1).

In order to update run these commands:

```console
composer update flarum-lang/tamil
php flarum cache:clear
```


Where is the code/model?

Hi guys,
any update on the code/model?

Thank you for your interest! It's released now ; )


Feature/generate model and factory automatically on resource command

Description
This PR closes https://github.com/filamentphp/filament/issues/11089
This feature creates automatically model and factory when passing --model AND/OR --factory argument to make:filament-resource command

[ ] Code style has been fixed by running the composer cs command.
[ ] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

Thanks! Please refactor this into separate flags --model and --factory though, and put them BEFORE --force

Done!

Thanks, also added migration support


Both generate.concurrency as generate.interval are flawed

Version
v2.2.0
Reproduction link
https://pimlie.github.io/nuxt-generate-benchmarks/
Steps to reproduce
See the repro link for all the numbers.
What is expected ?
See below
What is actually happening?
See below
Additional comments?
As these changes could be quite challenging, I though it would better to first make a Bug Report so we can discuss my benchmark results before I make a PR with the accepted proposal.
The current generate.concurrency and generate.interval implementations are both flawed. I have created some benchmarks which shows the behaviour and tested different new implementations.
With regards to concurrency, the main reason this is almost never noticed is because the default value is high and the flawed implementation is only noticeable when you set a low value or with really specific workload patterns. The current implementation is not really concurrent, its more batch'ed. A concurrent implementation means there are always [num] running jobs, but currently if you have a concurrency of 10 of which 1 page takes 1 sec to render and the other 9 takes 1ms, you still have to wait until that one page has finished. This isnt a problem if that page is fully blocking but when its waiting for something (eg an API request) you could have generated other pages in the mean time.
With regards to interval, the current implementation has no protection against differences in page workloads. Eg when you first have a long blocking page to render (which duration exceeds the set interval value) then when Node's event loop becomes available again (with the current implementation) the wait time for the next queued page (or pages) has immediately elapsed which could trigger multiple API requests within the same time block.
If you check the concurrency method benchmarks you can see the results for different proposals. These benchmarks were all done with interval = 0, some are also not full featured but were added to compare overhead of (a part of) the implementation.
If you have a different proposal I am happy to add it. The used implementations can be viewed here. Based on these results it looked to me that waitthrottled would be the best implementation.
Please also check the interval throttling benchmark, this is a comparison between how API calls are 'throttled' currently and with the proposed implementation. The benchmark was run with a special prepared workload to trigger the flaw in the old implementation.
The number shown on top of the bars is the the count of interval blocks in which more than two pages where generated. Maybe a bit cryptic, but when you set an interval you expect that within that interval only 1 page renders (due to measurement errors this could sometimes be 2, so therefor its >2). Ideally this should be 0 of course.
--edit--
#1 and #2 for the concurrency method benchmark just means I did two runs of the benchmark

This bug report is available on Nuxt community (#c7978)

Should be enchanced with the workers to handle concurrency inside the renderer.
We talked with @pi0 about this, and will handle a flag in the ssrContext directly instead of process.static.

Thanks for your great efforts @pimlie into documenting this issue; it must've taken you a great time to prepare all this.
I wish I understood your benchmarks better, they'll need a bit more description IMO.
I'm also interested about proper concurrency/interval set ups, for maximum performance.
I experienced a gain, going from deploy time between 2-3000 seconds to around 600 seconds, after I lowered concurrency from the default 250 value, to 50.

We've implemented a better algorithm upstream in Nuxt 3/Nitro. This should be resolved in the edge channel, or in the next release.
Let me know if not and I'll reopen.


SGMM2 Model in PyKaldi

I have trained an Urdu ASR system in Kaldi for mono, tri1, tri3 and SGMM2 and want to use it in Pykaldi for ASR however I couldnt find much support for this.
I have all the relative files for these models, HCLG.fst, words.txt and final.mdl but the Pykaldi systems is better for nnet3 etc.
Is there a project example of SGMM2 models being used in Pykaldi that would be very helpful.

From where have you got HCLG.fst, words.txt and final.mdl files?  I need these files. Can you help me?


Clarifications in usage

Clarified usage of docker ps to avoid confusion
Changed conflict message to be consistent with docker usage (delete vs remove)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:gs11/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Where are we on this? I agree that the current 'ps' text is sufficient.  The s/delete/remove/ is ok I guess, but we need this to be rebased, signed and squashed.

I'm still quite new to Git but is seems I only signed off on one of the commits. This commit should be excluded...agree on your comments here.
I'll work out how to sign the valid commit and exclude the other from the PR.
Thanks
I'll work out how to sign the valid commit and exclude the other from the PR.
Thanks

@gs11 Feel free to follow our contributors guide: https://docs.docker.com/project/set-up-git/
And if you have any questions or issues, just hop on IRC #docker-dev and someone will answer you :)
For this time, I suggest you do this:
$ cd /path/to/docker/
$ git checkout master
$ git status # to make sure you don't have any code changes you wouldn't want to lose
$ git fetch https://github.com/docker/docker
$ git reset --hard FETCH_HEAD
$ # change 'delete' to 'remove' in daemon/daemon.go
$ git add daemon/daemon.go
$ git commit -s -m 'Clarify error message when container name is already in use'
$ git push -f

@tiborvass et al. Thanks a lot and sorry about the delay. Vacation without access to computer in combination with my lack of experience with GIT caused this delay.
I followed your instructions and I hope the changes should be in order now...otherwise let me know.

LGTM

LGTM, thanks @gs11 !


Implement aggregation mechanism

@iksaif: I did something wrong, I'm sorry. So I'm creating this new PR.

This change is

Coverage decreased (-0.04%) to 94.027% when pulling 776cbf5e332d1802b47abaed0c2520137db68203 on natbraun:master into 10affeca04a45d4544c05b3af9a96fcd165c67d6 on criteo:master.

Coverage decreased (-0.04%) to 94.027% when pulling 76fbec3fdcaedd34a9fef674cd07be7e83a93c70 on natbraun:master into 10affeca04a45d4544c05b3af9a96fcd165c67d6 on criteo:master.

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

biggraphite/drivers/aggregate.py, line 1 [r2] (raw file):

#!/usr/bin/env python

could this be in downsampling.py ?

biggraphite/drivers/aggregate.py, line 72 [r2] (raw file):

                old_count = current_point[1]
                aggregated_value = self._aggregator.merge(old_value, old_count, value)
                res[-1] = (current_point[0], current_point[1] + 1, aggregated_value)

Will this really work if there are multiple points for the current epoch ?

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 7 unresolved discussions.

biggraphite/drivers/aggregate.py, line 54 [r2] (raw file):

        Returns:
          Iterable of (timestamp, count, value).

Please use (timestamp, value, count, self.precision)

biggraphite/drivers/aggregate.py, line 68 [r2] (raw file):

                res[0] = (epoch, 1, value)
            elif current_epoch == epoch:
                # point is in current epoch => aggregate

add a comment to explain what you're doing here

biggraphite/drivers/aggregate.py, line 72 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> Will this really work if there are multiple points for the current epoch ?

yes it does

biggraphite/drivers/aggregate.py, line 103 [r2] (raw file):

    __slots__ = (
        "_stage",

stages

biggraphite/drivers/aggregate.py, line 124 [r2] (raw file):

        Returns:
          Iterable of iterables of (timestamp, value).

Return (timestamp, value, count, step)

biggraphite/drivers/aggregate.py, line 140 [r2] (raw file):

        Returns:
          Iterable of iterables of (timestamp, value).

same

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 7 unresolved discussions.

biggraphite/drivers/aggregate.py, line 1 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> could this be in downsampling.py ?

Done

biggraphite/drivers/aggregate.py, line 54 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> Please use (timestamp, value, count, self.precision)

Done.

biggraphite/drivers/aggregate.py, line 68 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> add a comment to explain what you're doing here

Done.

biggraphite/drivers/aggregate.py, line 72 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> yes it does

Done.

biggraphite/drivers/aggregate.py, line 103 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> stages

Done.

biggraphite/drivers/aggregate.py, line 124 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> Return (timestamp, value, count, step)

Done.

biggraphite/drivers/aggregate.py, line 140 [r2] (raw file):
Previously, iksaif (Corentin Chary) wrote…
> same

Done.

Comments from Reviewable

Coverage decreased (-0.05%) to 94.015% when pulling 69ab3c688fc2873b79c0eff0f77da5a22215eac1 on natbraun:master into 10affeca04a45d4544c05b3af9a96fcd165c67d6 on criteo:master.

Reviewed 2 of 4 files at r3.
Review status: all files reviewed at latest revision, 7 unresolved discussions.

Comments from Reviewable


Window switcher should indicate the currently active window in the list

Testing #12522
In the case below an indicator, e.g, trailing 'dot' would have helped me to see which window is the active one.

@heycalmdown would you like to provide this in a new PR?

Okay, good point.

which way?

I like this one.


remove m68k from cross-compiles CI

m68k isn't on our platform list (neither primary, secondary, community or unadopted).  Given that we are more frequently running into CI issues in which that build fails due to GOT table exhaustion.  We could expand the GOT table with -xgot on the command line, but since we don't even list this platform anywhere on our platform page:
https://www.openssl.org/policies/general-supplemental/platforms.html
It seems like it might be better to just remove it and save a few cpu cycles in CI

IMO we should not remove this CI build as it uses the linux-latomic target which we have and we do not test it otherwise. It is IMO a good idea to exercise our code on more exotic architectures even if we do not officially support them.

@nhorman Do you have a view on what Tomáš has said? There is definitely an argument in favour of exercising code that is generally supported even if the platform it's used by isn't

@tom-cosgrove-arm yeah, I'm totally fine with at the very least holding off on this for a while, only suggested removing it because we don't actually support the 68k arch in our platform list, and it was giving us CI issues.  since expanding the got is easy, that probably makes more sense, just want to be cognizant of  spending time fixing CI for platforms we don't anticipate supporting.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

This build has picked up coding errors in the past.  I'd suggest adding the -xgot option rather than removing it.
It's also very likely that some comsumers have embedded platforms that rely on this working.

OTC: We want to keep this CI build for now.


Error while firing this command

getting this error while firing upgrade-assistant analyze command

Starting with v0.5, the analyze command was removed.
Note: technically, it wasn't removed so much as the entire program was rewritten from scratch and the analyze command hasn't been implemented (yet?).

This is a duplicate of issue https://github.com/dotnet/upgrade-assistant/issues/1491 and issue https://github.com/dotnet/upgrade-assistant/issues/1497


Feature: add button to aggregate

Creating a unidirectional link between two counters, one would get a button to add its value to the other's existing value, and resetting itself.

I think that's a bit out of scope. Sorry.

for anyone looking for such an app:
Track & Graph
https://f-droid.org/app/com.samco.trackandgraph
https://github.com/SamAmco/track-and-graph


HTML escape

Escape utilities for HTML contents and attributes
HTML escape utilities
Based on OWASP research and OWASP ESAPI code
See:
https://www.owasp.org
https://www.owasp.org/index.php/Cross-site_Scripting_(XSS)
https://www.owasp.org/index.php/XSS_(Cross_Site_Scripting)_Prevention_Cheat_Sheet
https://www.owasp.org/index.php/ESAPI
https://github.com/ESAPI/esapi-java-legacy
Ref: https://github.com/lotus/helpers/pull/7

Changes Unknown when pulling 84e3bae5a828e57c1f1142a8b9509c57d2dc748f on html-escape into ** on master**.

Changes Unknown when pulling cace05a76894020855fd18f5959bb15264582308 on html-escape into ** on master**.

Looks great, and easy enough to follow...

:+1: @jodosha I learn a lot reading your code ;) and tomorrow I'll see the references posted above.

Changes Unknown when pulling f5fc4ccf6172b48723be2676f6e3ed21e8aa1259 on html-escape into ** on master**.

Changes Unknown when pulling bc940ba56450534b1a33bacb1509ad6f7e1c7b6d on html-escape into ** on master**.

Changes Unknown when pulling d9225cb23726c23de0c93edf3b8703e83eafb64f on html-escape into ** on master**.

Coverage increased (+0.97%) to 98.87% when pulling abc12624491e649e6cc66c42fb3c30b90c11c79d on html-escape into<PHONE_NUMBER>ebde6e75dda4d421dae50193179bf2 on master.

Coverage increased (+0.89%) to 98.8% when pulling 0e99a90dc8d26fd321bca7f315959a1a74bf19fe on html-escape into<PHONE_NUMBER>ebde6e75dda4d421dae50193179bf2 on master.

Coverage increased (+1.97%) to 99.87% when pulling e99473d49f1af4a0169183c208b2288101be6671 on html-escape into<PHONE_NUMBER>ebde6e75dda4d421dae50193179bf2 on master.


Docs reference wildly out of data android-maps-utils version

The first step in the landing page docs instruct the user to add the android-maps-utils dependency like so:
dependencies {
    implementation 'com.google.maps.android:android-maps-utils:2.3.0'

}

The current release version is 3.4.0, though. The referenced version was broken in a few ways and caused some frustrating debugging until I spotted the error :)

Our current release workflow misses the devsite branch where this snippet lives. Will revise.


[Other] Documentation Updates

Overview
We need to update the documentation prior to DEFCON31 presentation. This will ensure that users have a good initial impression if docs are clear and straightforward. For now, doc updates should be made within the Wiki.
We can adjust docs or migrate them elsewhere at a later time.

✅ This has been completed via https://github.com/elastic/SWAT/pull/69
Closing.


Remove "fdk-aac"

Companion to https://github.com/arduino/library-registry/pull/4922

Closing as duplicate of https://github.com/arduino/library-registry/pull/4928