Sticky scroll for editor won't zoom with Ctrl+Mouse Wheel if activated

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.86.2
OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

Scroll in editor to someplace where sticky scroll is activated (pinned function definition appears);
Zoom with Ctrl+Mouse wheel.
The text in editor zooms while sticky scroll part doesn't.

Zoom in:

Zoom out:

Seems that it had been fixed in later versions 🤔
Closing this issue.


Output changes when inference trained PEFT model, what's missing?

I can save models from specific checkpoint following the discussion in #273. Thank you for the help!
For inference, I created an inference.py file in which I have
peft_directory = ... # /path/to/checkpoint/adapter_model

peft_config = PeftConfig.from_pretrained(peft_directory)
model = LlamaForSequenceClassification.from_pretrained(peft_config.base_model_name_or_path)
model = PeftModel.from_pretrained(model, model_id=peft_directory)
model.eval()

text = "this is a test"
inputs = tokenizer(text, truncation=True, padding="max_length", max_length=max_sql_len, return_tensors="pt")

logits = model(**inputs).logits

However, the values of logits still change every time I run the cmd of python inference.py with the same input.
Can anyone provide more information for the next step of debugging? Thanks!

not related to peft, closing


Issue credits to Evan

Issue 2000 credits to @gnomevan.

 Follow up
On Friday, 22-Mar-24 01:58:52 UTC by Gov4Git dev
Issued 2000 credits to member @gnomevan.


feature request: build both sim and ios

And this open source? I'd love to contribute

@chml Hi! No, I'm not ready now.
But I'm going to open source in the future.

I decided to close this issue because the main goal of 🏈 Rugby is optimization.
If we build both SDKs, it will take 2x longer. But you need only one at the present time.
You can switch between SDKs faster enough and all cache will be saved for each SDKs appropriately.
@chml Sorry, I'm not going to add this feature in nearest future.

@chml #84


How do i change the Swipe left and right methods?

Hey there,
I would like to change the swipe left and right problems and also i would like to address the issue that its rendering the previous dates and then its rendering the correct dates.
The swipe left and right i want it to fit to how we are usual here in Israel, Swipe left its advance through dates and swipe right its go back to previous dates
I am attaching a video:
Video

Hi @Osher671279 , I can't see the video, but I think I understand the issue, it's like rtl mode. Let me try to implement it.

Okay bro in waiting

Hi @Osher671279 , I can't see the video, but I think I understand the issue, it's like rtl mode. Let me try to implement it.

Hey Bro
Any update? May i kindly ask you to try implement this ASAP? its top priority for my project

Hi @Osher671279
I think this should not be hard to implement, but it should be done after PR #51 is merged, as it changes some important internal scrolling logic.
I can try to implement this next week :slightly_smiling_face:

I am attaching a video:

By the way, I get a video-not-found here :slightly_frowning_face:

@Osher671279 is something like this what you need? (disregarding the flicker)

#52 adds this functionality: set the rightToLeft prop to true

Wow thanks i wil check this out


Documented search paths for PowerToys Run

The program plugin of PowerToys Run previously had no documentation of where it looks for programs to suggest. These changes document the 4 specific directories that the plugin looks into, and why some programs might not show up in the search results.

@kotauskas : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mattwojo
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@crutkas Look ok to you?

We'd have to review the source code at this point to verify this is "true".
Also this implies some stuff that isn't totally true from how it is implemented.  We use an API to detect packaged apps installed (Larger scope than just UWP) so the statement about stuff being discoverable isn't totally true.

@kotauskas - Thank you for the contribution!
Just talked it over and determined that this is a bit more detail than seems necessary to include in the docs. I'm going to close this PR for now, but the contribution will remain in our PR history and if there is more interest, confusion, or issues filed relating to search paths for Run, we can re-open.
Thanks again for taking the time to write this up.

@mattwojo : Thanks for your contribution! The author(s) have been notified to review your proposed change.


vuex-router-sync peer dependency issues

Started getting the following peer dependency warning after upgrading from 0.9.0 to 0.16.1.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

After installing each version it seems this issues was introduced in version 0.12.0 due to vue-play, see https://github.com/SSENSE/vue-carousel/pull/266/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R40.
So I assume this issue may actually lay with vue-play but as I still get confused with peer dependencies it would be great to get your thoughts on this? Should I open an issue with vue-play?
In the meantime we will stick with version 0.11.0, currently we have:
"vue-router": "^3.0.2",
"vuex": "^3.0.1",

Hey @samit4me, yeah these are just NPM warnings from mismatched sub-dependency versions, and probably out of our control to fix. It shouldn't cause any performance issues, and v0.16.0 is stable to use. However, if you do notice performance problems on v0.16.0, feel free to open an issue!
In terms of the warnings, we'll try to resolve in v1.0 but these sort of things are usually dependant on external factors. I'll close this for now, but will flag a reference question - you summed it up well and we get these kinds of questions a lot :octocat:


Move JkJavaBuild stuff to an api package

There should exists a API class as JkJavaProject that has all methods to build java project (compile, test, unitTest, ...).
DotClasspath Generator and ImlGenerator should also move to API.

Move artifactProvider to java project maker


No "DynamoDB.h" file found

When I tried to run the code, it has issue: No "DynamoDB.h" file found.
It happened in code "DDBDetailViewController.m". The code tried to import "DynamoDB.h" file. But it failed to find it.
Where could we find the "DynamoDB.h" file?

Starting with 2.1.0, you need to import like the following:
#import <AWSDynamoDB/AWSDynamoDB.h>

See this blog post for more details.


Prefer the setpoint for each mode for the sp range

If a system has both heat and cool modes, the max coolpoint and the min heatpoint aren't accurate, so instead use the min coolpoint and the max heatpoint
In my system, the max coolpoint is 99F and the min heatpoint is 40F, which causes incorrect results from the current simple min/max() function calls when comparing against the max heatpoint of 80F and the min coolpoint of 60F.

There is a similar set of code in the api - lennox_zone - that is used to validate the setpoint inputs. The API code likely has a similar issue.  As I was adding setpoint unit tests, I only tested the happy path and did not implement tests for the input validation.   We may need the logic that you updated down there also, if so perhaps we move this logic into the API.
https://github.com/PeteRager/lennoxs30api/blob/9e2ac169c051bfea9e144720853985c0d18d4927/lennoxs30api/s30api_async.py#L1390


Incorrect exports specified in package.json

Discussed in https://github.com/phosphor-icons/react/discussions/95

Originally posted by diegolauar April 23, 2024
If you get this error: Failed to resolve entry for package "@phosphor-icons/react". The package may have incorrect main/module/exports specified in its package.json.
Try install: npm install phosphor-react
Use:  import { . . . } from "phosphor-react"

@diegolauar can you provide some details:

@phosphor-icons/react version
Project type (pure React, Next, Astro, etc.) and version
Build tooling (vite, turbo, etc.) and version
Node version
Any supporting details that can help reproduce the error

I'm having a similar issue. I'm using the vite esm and typescript template to build a pure react app. Here's my environment:
@phosphor-icons/react: 2.1.7
react: 18.3.3
vite: 5.3.5
typescript: 5.5.4
node.js: 18.20.4
TypeScript complains if moduleResolution is set to "bundle" as the default vite template does, so I've changed it to NodeNext. This allows the app to build properly and vite can run it. Unfortunately when I add @phosphor-icons/react to the project, I'm unable to import any components from @phosphor-icons/react directly:
import { FolderOpen, PlusSquare } from '@phosphor-icons/react';

This results in the following typescript error:
❯ yarn build
src/App.tsx:1:10 - error TS2305: Module '"@phosphor-icons/react"' has no exported member 'FolderOpen'.

1 import { FolderOpen, PlusSquare } from '@phosphor-icons/react';

However, if I use the fully qualified exports, everything works fine:
// This works fine
import { FolderOpen } from '@phosphor-icons/react/FolderOpen';
import { PlusSquare } from '@phosphor-icons/react/PlusSquare';

Any thoughts?


query_devices() hangs on Mac

Required Info

Camera Model
D415, D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
MacOS 10.13.4

Platform
PC

SDK Version
2.11.1, 2.12.0

Language
C++

Issue Description
I'm seeing various types of crashes & hangs on Mac. Occasionally pipeline.start() after having previously stopped will crash, but the most reproducible issue is that context.query_devices() will hang. This usually happens if it's called after pipeline.stop(), which is sometimes solved by sleeping for 1sec first after stopping the pipeline. In addition, plugging in a camera will sometimes cause the Viewer app to freeze. In other cases, the Viewer app will never get past the loading screen, instead staying on that screen with the "RealSense device detected" text flashing indefinitely. When I look at where it's paused, it's the same place in both my app and the Viewer, which is somewhere in libuvc when trying to access rs2::devices returned from query_devices(). Note that the call to query_devices() returns -- it looks like it's when accessing the items inside the rs2::device_list that causes the issue.
Edit: another thing to point out: if the pipeline is started & data is currently streaming, query_devices() also hangs, pretty much every time.
Here are some screenshots of the stack trace in both my app and the RS Viewer.

[Realsense Customer Engineering Team Comment]
hi @mattfelsen,
issue seems same to #1855, thank you for detail,  we are looking into this issue.

[Realsense Customer Engineering Team Comment]
hi @mattfelsen,
pull request 2022 should fix this issue, please let me know how it works, thanks.


circle_plotter.java:232: error: cannot find symbol

Hi, I was compile the code downloaded from MCScanX home page. But it failed in making the programs under 'downstream_analyses' directory. Here is the message:

javac -g circle_plotter.java
circle_plotter.java:232: error: cannot find symbol
Cubic xSpline = new Cubic(Cubic.BEZIER, GX);
^
symbol:   class Cubic
location: class circle_plotter
circle_plotter.java:232: error: cannot find symbol
Cubic xSpline = new Cubic(Cubic.BEZIER, GX);
^
symbol:   class Cubic
location: class circle_plotter
circle_plotter.java:232: error: cannot find symbol
Cubic xSpline = new Cubic(Cubic.BEZIER, GX);
^
symbol:   variable Cubic
location: class circle_plotter
circle_plotter.java:233: error: cannot find symbol
Cubic ySpline = new Cubic(Cubic.BEZIER, GY);
^
symbol:   class Cubic
location: class circle_plotter
circle_plotter.java:233: error: cannot find symbol
Cubic ySpline = new Cubic(Cubic.BEZIER, GY);
^
symbol:   class Cubic
location: class circle_plotter
circle_plotter.java:233: error: cannot find symbol
Cubic ySpline = new Cubic(Cubic.BEZIER, GY);
^
symbol:   variable Cubic
location: class circle_plotter
6 errors
make: *** [circle_plotter.class] Error 1

Could you help to solve this?
Thank you very much!
Best,
ZC

I have the same issue

And I also got the same issue.

Same problem.
(-_-メ)
Did you find a solution?

I also have this issue.
Could you help to solve this? thanks

Has anyone figured this out?

I have installed java-jdk8 but I still have this issue.

Same here. I tried to install MCScanX in a new conda environment (conda create -n genespace orthofinder java-jdk==8.0.112) and got the same error.

Is there someone make it? Please give me your advice


bug: Tabs content under tabs

Type: bug
Platform: android 4.2 browser
Hi,
I've a problem with the content of a tab, i've use this codePen(http://codepen.io/calendee/pen/JdtuG?editors=101) for made my tabs and it's the same code but when i try this on my app my text is under the tab...
http://img11.hostingpics.net/pics/284422templatestabstabhostshtmlwwwBrackets.jpg
If anyone have a idea!
Thank's

The code you are referencing in the pen is really old, 0.9.27. Ionic is on 1.0.1 now, please update your codepen accordingly.
https://github.com/driftyco/ionic/blob/master/CHANGELOG.md


docs(go) rework go guide

Looks like the 2.1.0 branch was created a few days before some other Go PDK doc changes were merged in - this PR is missing content added with https://github.com/Kong/docs.konghq.com/pull/1890.

Looks like the 2.1.0 branch was created a few days before some other Go PDK doc changes were merged in - this PR is missing content added with #1890.

Just rebased the release branch onto master, and this branch onto the release branch. I added back the one section with content that is still applicable with our new recommended way of building/using Go plugins.


Adding Changes Requested label.

Automatically add changes requested label to the PRs on which reviewer requested the changes. Also add Under Review label to the issues related to that PRs.

@shubhigupta991 Can I look into it?


Wasm: Implement checked behaviors.

Based on #4993 but otherwise ready to review. The first commit belonging to this PR is "Wasm: Implement checked asInstanceOfs.".

This is still based on #4993 but otherwise it's now ready for review.

Rebased.

Rebased on top of the non-nullable reference types.


build(web): Add fixed version of Sentry vite plugin

Title
Fixes https://github.com/getsentry/sentry-javascript-bundler-plugins/issues/239

fyi i merged this w/ rebase (github didnt seem to figure it out)


Speed up CI: only reset fixture repositories when they have been changed

This PR creates a watcher that will watch the setting.RepoRootPath for changes during the integration test, and only if there is changes will the repo fixtures be recreated.
This should save substantial time when running CI.
This PR could be further improved by only resetting the repos that need to be reset but that would be a lot more complicated.

Does that really save time? Both successfull builds took a similar time then builds without this change.

Codecov Report

Merging #23018 (48f2533) into main (c8093a1) will increase coverage by 0.13%.
The diff coverage is 55.29%.

:exclamation: Current head 48f2533 differs from pull request most recent head 7512b87. Consider uploading reports for the commit 7512b87 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main   #23018      +/-   ##
==========================================
+ Coverage   47.29%   47.43%   +0.13%
==========================================
  Files        1113     1140      +27
  Lines      150159   150783     +624
==========================================
+ Hits        71023    71527     +504
- Misses      70700    70790      +90
- Partials     8436     8466      +30

Impacted Files
Coverage Δ

cmd/admin.go
0.00% <ø> (ø)

cmd/admin_user_change_password.go
0.00% <0.00%> (ø)

cmd/admin_user_create.go
0.00% <0.00%> (ø)

cmd/admin_user_delete.go
0.00% <0.00%> (ø)

cmd/admin_user_generate_access_token.go
0.00% <0.00%> (ø)

cmd/admin_user_list.go
0.00% <0.00%> (ø)

cmd/admin_user_must_change_password.go
0.00% <0.00%> (ø)

cmd/cmd.go
40.00% <0.00%> (-0.75%)
:arrow_down:

cmd/convert.go
0.00% <0.00%> (ø)

cmd/doctor.go
0.00% <0.00%> (ø)

... and 241 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Does that really save time? Both successfull builds took a similar time then builds without this change.

I have the same question. Is it really worth to make it that complex? How much time would be saved?

It's difficult to assess the speed improvement over a few runs as the improvement will be most apparent when there is IO bound related slowness - this will be dependent on the load on the CI server.
In general testing I've definitely noticed that there can be a lot of time between tests - and part of that I assumed was due to this copying but it's perhaps its a smaller proportion than I was expecting and the problem is elsewhere?  Certainly most tests do not need the LFS data copied every time and most don't need the repos reset either - this PR will be saving some time but it appears not much.
One of the slow downs with MSSQL related tests is likely something to do with the way DB fixtures are loaded/reloaded and I would not be surprised if there was a way to improve that.

I'm not sure how "Have the repo fixtures changed? If so reset them" is particularly complicated. Yes it's more complicated than deleting and recopying them every time - but it's not particularly complicated.
A more complicated improvement would be to only copy across the repos that have actually changed. We'd have to assess whether that is worth it. I suspect not given the majority of tests do not need the repos copying.

I guess I'll have to add timers to see if this is really worth doing and get some numbers on how much of an improvement this causes and where the delays truly are. I wonder if trace annotations might be helpful.

OK adding some specific timing information this saves just about half of the time taken within prepareTestEnv over the course of the CI suite on my very fast laptop.
That sounds impressive but it's saving 15s of 31s that call takes on my computer. I think it's possibly still worth doing but it's not necessarily impressive.

I wanted to suggest using nested transactions.
Then I googled, and apparently that's not possible cross-platform.
If it had worked, it would allow us to wrap our tests in a parent transaction, and simply rollback the parent transaction after every transaction…
That way, we would only need to populate the db once, and subsequently no changes could be made between tests.
But unfortunately that's not feasible for Gitea as it isn't locked into a single database…

however my laptop takes around 6 minutes to run the test suite.

I think maybe it's worth to upgrade these CI servers first. The question is that why the CI servers run so slowly? Use faster SSD? Use in-memory file system?
Spending more money on hardware sometimes is better than spending a lot of work time - time is precious. More complicated, more time has been spent, more time (in the future) is needed.

I'm telling you that this improves test-sqlite times by 15s over a 6min run on my computer.
That is 4% decrease in CI time for me for just doing a little less work during set-up.
That's a significant decrease in CI time for me personally AND I am running on a very fast laptop with an SSD.

My experience of resolving problems is: clarify the problems first.

What's the problem? The CI time is too long.
What causes that long time?

Is it that long everywhere? No, local tests are fast. (maybe 20min vs 6min?)
Is there any bottleneck on CI server? CPU? Memory? Disk? No proof yet.
Is some code the bottleneck? Maybe, not sure (no proof yet). This PR improves 4%

I think the second question is not clear at the moment. Even if some fine tunes on the CI server could make the test-sqlite finish in 15min, that's 25% improvement, far more than 4%.
I am not saying this PR is not good, but I just want to clarify the problem first.

This PR: test-mysql8: 27:10 (it doesn't seem to be a noticeable improvement comparing to old PRs)
Latest PR: testing-mysql8: 14:55
I think other improvements really do better than the this PR's 4% improvement.
So I think this PR could be closed.


Install tools for monorepo

https://github.com/kitsuyui/react-playground/commit/fb27cd7b63c16f35b08737dbed47246259019556


[dolphinscheduler-1197][docs]wrong spell in lock implementation flow chart

i fixed the bug issue  #1197 , fixed the wrong spell in the image

+1

document pr please submit official website project: https://github.com/apache/incubator-dolphinscheduler-website, thx!


Update timeout for .github/workflows/build_and_test.yml

This is an automated pull request to update default timeouts for all jobs in .github/workflows/build_and_test.yml that do not currently contain a default timeout property.
Please review these changes closely to ensure that all jobs have sufficient time to run. If a job needs more time, please add a timeout property to that job to override the organization default.
Additionally, please be attentive to unintended changes to the workflow YAML file, as the parser is not perfect.
Lastly, note that it is up to the reviewer to merge this pull request and delete the PR branch once they are satisfied with the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing in favor of https://github.com/Kong/kong/pull/12566.


Conversation Expiration

Hi everyone,
more than a problem I'm looking for a guide. I'm trying to set conversation timeout limit so after some time of user no activity, bot will behave like new conversation.
I created CosmosDB along with other Azure apps while publishing my bot (using Composer desktop 1.4) and I set my container
TTL = 30 seconds.
Now I'm a bit lost. Is there any other configuration required?
Thank you.

@KyonCode, could you elaborate more on what channels are you using?

Hi @anusharavindrar,
I'm using MS Teams and Web Chat.
What I want to achieve is when I leave conversation in the middle of Dialog, bot will automatically close whole conversation let's say after 10 minutes and behave like new (user) conversation after submitting new response. Not sure if this is something I can configure in Composer or in Azure...
Thank you

@KyonCode, if you are using Web Chat, then you could have the Web Chat send an event to the bot and the bot can respond by asking the user if they are still there as specified in this solution.  If a user does not respond after a certain period of time, then the bot can restart a conversation from the beginning. This documentation describes two ways ( user interaction expiration and storage expiration) to expire a conversation.

I am using bot composer but unable to conversation timeout limit please anyone help with the examples


namespace Dingo\Api\Exception not work in laravel 5.8

laravel-framework file
namespace Illuminate\Contracts\Debug
has upgrade ,
this interface add this function
    public function shouldReport(Exception $e);
but This interface is not implemented
please check and fix it.
thx.

Here are the relevant areas from Laravels upgrade guide.
https://laravel.com/docs/5.8/upgrade#exception-handling

This error is only the first in a number of them that we'll experience using Laravel 5.8.
I've updated the PR to address all the errors - however, even with those, this isn't fixing the builds since the tests require Lumen and Lumen hasn't been released for 5.8 yet.

Resolved, I will tag this as 2.1

update the package version (Y)

@SOSTheBlack ? Do you want to elaborate what you mean there?

@specialtactics
Add this in your composer.json file
"require": {
"php": ">=7.1.3",
"dingo/api": "^2.1",
...

@SOSTheBlack Are you saying you are having issues still? If so, please post your complete composer.json file, because I cannot reproduce.

@specialtactics
This is the error message I receive when I run composer update:
PHP Fatal error:  Class App\Exceptions\Api\Handler contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Contracts\Debug\ExceptionHandler::shouldReport) in /Users/dev/Web/laravel58/app/Exceptions/Api/Handler.php on line 33
In Handler.php line 33:
Class App\Exceptions\Api\Handler contains 1 abstract method and must theref
ore be declared abstract or implement the remaining methods (Illuminate\Con
tracts\Debug\ExceptionHandler::shouldReport)
Here is my composer.json:
{
"name": "My Test API",
"description": "Starter Boiler Plate",
"keywords": ["REST API", "laravel"],
"license": "MIT",
"type": "project",
"require": {
"php": ">=7.1.3",
"laravel/framework": "^5.8",
"dingo/api": "^2.1",
"tymon/jwt-auth": "^0.5",
"stevenmaguire/laravel-middleware-csp": "^0.1.1",
"prettus/laravel-validation": "^1.1",
"illuminate/support": "^5.3",
"darkaonline/l5-swagger": "^5.8"
},
"require-dev": {
"fzaninotto/faker": "^1.4",
"mockery/mockery": "^0.9",
"symfony/css-selector": "^3.1",
"symfony/dom-crawler": "^3.1",
"barryvdh/laravel-debugbar": "^3.2"
},
"autoload": {
"classmap": [
"database",
"app/Models/User",
"app/Models/Locality",
"app/Models/Contents",
"app/Models/System",
"app/Models/Notifications",
"app/Facades",
"app/Repository",
"app/Services"
],
"psr-4": {
"App\": "app/"
}
},
"autoload-dev": {
"classmap": [
"tests/TestCase.php"
]
},
"scripts": {
"post-root-package-install": [
"php -r "file_exists('.env') || copy('.env.example', '.env');""
],
"post-create-project-cmd": [
"php artisan key:generate"
],
"post-install-cmd": [
"Illuminate\Foundation\ComposerScripts::postInstall",
"php artisan optimize"
],
"post-update-cmd": [
"Illuminate\Foundation\ComposerScripts::postUpdate",
"php artisan optimize"
]
},
"config": {
"preferred-install": "dist"
}
}

@soumyaRauth that composer file works fine for me.
Also, the file "App\Exceptions\Api\Handler" is actually inside of your own application - not dingo or any other package, so I suspect the problem lies in your own code.


Roctracer hip frontend

ROCM device tracer iplementation

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@eshcherb since this PR depends on changes to HIP and HCC to function properly. please help specify them here. also i'd like to ask you to help change the CI script for TensorFlow so this PR can be tested with modified HIP / HCC, as well as ROCm GPU tracer. Please refer to #105 for examples.


extends option not working as intended for single file components

Version
2.4.2
Reproduction link
https://github.com/raahede/vue-extends-test
Steps to reproduce
Create new single file component that extends another single file component using the ´extends´ option
What is expected?
The component is extended
What is actually happening?
Nothing appears from the original component

It's possible to use the ´extends´ option on .js files like using mixins, but not on .vue files.

D'oh!
Thanks @LinusBorg, I'm just going to go bury myself now 😄


Don't wrap Views in custom objects

Right now, views are wrapped in custom classes, which makes certain things harder, such as parent / sibling tracking!
Either use Views directly, or change implementation to rely on {N} view's information!

Refactored in e9dee08


Use requirements.txt for python dependencies

When trying to build the engine locally, it's unclear which version of SCons should be used. Typically, python projects should list their dependencies in a requirements.txt file, and both the CI system and developers should install dependencies from said file.

We don't really enforce which version you should be using. You are expected to read the documentation that explains which dependencies you need to install for your platform and toolchain. But versions are only a suggestion, with some minimum requirements being listed.

There is no need to specify a version, what CI uses is not related to what the official build server uses, and what developers use on their end is up to them, within the supported range. There is no hard requirement, and having a file would be misleading compared to the documentation that covers this with more information and detail.
SCons is not the only thing you need to have installed (and most of other dependencies are not related to Python whatsoever), so you are expected to go through the docs to familiarize yourself with the project. We don't expect people to just install Python dependencies and start building.
I know that this may not be expected for an environment with managed packages, but this is indeed not a Python project. We just use a Python-based tool. And that tool can be any number of versions within the supported range, same as other parts of your toolchain.


ES6 import mediaelement player

Hi! Could you please explain, may I import mediaelementPlayer without jQuery?

Let me work to fix something so I can document how to use this properly. I'll keep you posted

@ron666, ok, thank you

@dmitrylebedev Please read the documentation about Usage to learn how to import the package; in your case I'd use the second option. Let me know if that works for you. Thanks

The problem for me is, that if you only use ES6 import you cannot expose jQuery as window.$ before importing mediaelement. Instead you currently have to something like:
import $ from 'jquery';

// expose jQuery for mediaelement
window.$ = $;
require('mediaelement/all');

This does not work, because of how ES6-imports work:
import $ from 'jquery';
window.$ = $; // will be executed after the imports so …
import 'mediaelement/all'; // … medialement does not have "access" to the $ from above

This would be the desired option:
import 'mediaelement/all';

which then should require/import jQuery itself.

Let me test that particular scenario because I thought that the jQuery plugin needed to expose the $ variable that way in order to work with the plugin (or any other). I'll keep you posted

@dmitrylebedev OK after some research and test the only thing I can say is that I cannot include jQuery inside of the bundle since it changes constantly and it will turn the bundle really big. What I found is that in order to make jQuery to work with import you need to create a jquery-global and then use it in your own script (http://stackoverflow.com/questions/35358625/jquery-is-not-defined-when-use-es6-import).
jquery-global.js
import jquery from 'jquery';
window.jQuery = jquery;
window.$ = jquery;

Then you can do:
'use strict';

import './jquery-global';
import 'mediaelement/all';

I can add this in the documentation; just let me know if it works for you that way

If no other comments on this I'll close this ticket tomorrow


Cannot retrieve data from firebase

Hi,
I tried to follow the instructions but I failed.
When I tried to log value from firebase like this:
af.database.object('shared/1').subscribe(item => console.log(item));
it worked.
But if I would like to do something like this:
console.log(af.database.object('shared/1'));
I got something like this: FirebaseObjectObservable {_isScalar: false, _ref: U}
Can anyone please tell me what I have done wrong? Thank you.
Tao

My fault. Should add the async pipe.

Hi @funnytao ! Sorry I'm not trying to reopen the issue, but I have the same problem, where and how did you use  the async pipe?


[UI framework components] passing Astro content via slot

New or updated content

Adding a section in UI Framework Components page explicitly saying

you CAN'T import an Astro component inside another framework component
but you CAN pass an Astro component's static content as children, via a slot

Still working on the wording, but want to get the concept included on this page

LGTM, nice work @sarah11918! 🙌


Workspace doesn't work along aside PhpMyAdmin by default

Description:
Workspace uses port 8080, which is used by multiple other services. This should be mentioned in the docs if not have the defaults fixed.
Workspace is a generic service that seems like it's default should play well with others, other services like ADMINER and PhpMyAdmin I wouldn't expect to use side by side, so I don't see an issue there.
Defaults in env-example that use 8080:
WORKSPACE_VUE_CLI_SERVE_HOST_PORT=8080
ADM_PORT=8080
PMA_PORT=8080
TOMCAT_HOST_HTTP_PORT=8080

Expected Behavior:
% docker-compose up -d workspace phpmyadmin
Creating network "laradock_frontend" with driver "bridge"
Creating network "laradock_backend" with driver "bridge"
Creating network "laradock_default" with the default driver
Creating laradock_workspace_1        ... done
Creating laradock_mysql_1 ... done
Creating laradock_phpmyadmin_1 ... done
%

Actual Behavior:
% docker-compose up -d phpmyadmin workspace
Creating network "laradock_frontend" with driver "bridge"
Creating network "laradock_backend" with driver "bridge"
Creating network "laradock_default" with the default driver
Creating laradock_docker-in-docker_1 ... done
Creating laradock_mysql_1            ... done
Creating laradock_workspace_1        ...
Creating laradock_phpmyadmin_1       ...
Creating laradock_phpmyadmin_1       ... error

Creating laradock_workspace_1        ... done
9f0a91a7760344add118e31b7153e98b86b15d86d8b60203a4df9f42d5f269): Bind for <IP_ADDRESS>:8080 failed: port is already allocated

ERROR: for phpmyadmin  Cannot start service phpmyadmin: driver failed programming external connectivity on endpoint laradock_phpmyadmin_1 (2c9f0a91a7760344add118e31b7153e98b86b15d86d8b60203a4df9f42d5f269): Bind for <IP_ADDRESS>:8080 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.
%

Context information:
Output of git rev-parse HEAD
% git rev-parse HEAD
123e52e563fb507a7089952ff227df4c5e0daee6
%

Output of docker version
% docker version
Client: Docker Engine - Community
 Version:           19.03.8
 API version:       1.40
 Go version:        go1.12.17
 Git commit:        afacb8b
 Built:             Wed Mar 11 01:21:11 2020
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.8
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.17
  Git commit:       afacb8b
  Built:            Wed Mar 11 01:29:16 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.2.13
  GitCommit:        7ad184331fa3e55e52b890ea95e65ba581ae3429
 runc:
  Version:          1.0.0-rc10
  GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683
%

Output of docker-compose version
% docker-compose version
docker-compose version 1.25.4, build 8d51620a
docker-py version: 4.1.0
CPython version: 3.7.5
OpenSSL version: OpenSSL 1.1.1d  10 Sep 2019
%

System info: Mac, Windows or Linux. Include which disto/version
macOS Catalina Version 10.15.3
Hardware identifier: MacBookPro16,1

Steps to reproduce the issue:

mkdir pmaissue
cd pmaissue
mkdir public
echo "<?php phpinfo(); ?>" > public/index.php
git clone https://github.com/laradock/laradock.git
cp laradock/env-example laradock/.env
cd laradock
docker-compose up -d phpmyadmin

Stacktrace & Additional info:
Creating laradock_phpmyadmin_1       ... error

Creating laradock_workspace_1        ... done
9f0a91a7760344add118e31b7153e98b86b15d86d8b60203a4df9f42d5f269): Bind for <IP_ADDRESS>:8080 failed: port is already allocated

ERROR: for phpmyadmin  Cannot start service phpmyadmin: driver failed programming external connectivity on endpoint laradock_phpmyadmin_1 (2c9f0a91a7760344add118e31b7153e98b86b15d86d8b60203a4df9f42d5f269): Bind for <IP_ADDRESS>:8080 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.

Avoid port conflicts you can edit .ent
ADM_PORT=8081
PMA_PORT=8081

Avoid port conflicts you can edit .ent
ADM_PORT=8081
PMA_PORT=8081

I am completely new to docker, just wanted to quickly get up and running with laravel development. Alas, I've been fighting with these port conflicts. Where is this .ent file?

Still an issue for multiple people.
@bestlong is there a determination of if this is a Won't Do or a Feature Request? (I noticed you removed the Bug tag)

@fuel-wlightning
Ref #2634

I've confirmed that PR #2634 resolved this issue. Thank you! Sorry for the delay in vetting this fix.


Test (Cypress GitHub Backend): Introduce an option to record cypress tests data and run tests using recorded data by default

GitHub actions version of this PR

Follow up on the GraphQL PR, specifically this comment.
The main purpose of this PR it to allow running Cypress GitHub backend tests using mock/recorded data.
I've looked into several solutions:

http://www.mock-server.com/ - A proxy server to record traffic and match requests.
https://github.com/Netflix/pollyjs - A framework that uses stubbing to record and playback requests (supports browsers and node) - enabling it broke Cypress completely for some reason.
https://github.com/nock/nock - Similar to Polly.JS, but only works for node (overrides http.request and http.ClientRequest).
http://www.wheresrhys.co.uk/fetch-mock/ Similar to Nock, but works with fetch.
Cypress built in mocking solution - Only works with XMLHttpRequests. There are some workarounds for supporting fetch, but another main issue is that you can only match by URL and method (no post data) making it unusable for most use cases. Again there are some workarounds here and here but they seem overly complex.

The method I'm using is described in the Readme:
For recording - set up Cypress with a proxy (http://www.mock-server.com/), sanitize and transform the recorded data to an easier to process format.
For playback - Cypress exposes a sinon instance so I'm using that to stub window.fetch and match requests.
Several problems I experienced in matching requests:

Requests are sent with a ts parameter to bust browser caching. This is solved by using pattern matching on the URL.
Creating posts uses the current date by default, which changes the content of some post requests.
I initially solved it by entering a fixed date into the date field, but this wasn't good enough as slugs are formatted with the current date regardless of the post date.
Cypress has a clock function that mocks the Date object, but it created another issue as some of the UI fields are de-bounced, thus ignoring value changes unless the the clock is advanced.
The solution was to advanced the clock after updating posts just enough to trigger the de-bounced input field, while still keeping the slug generation consistent. We could also consider generating the slug based on the post date (if it has such a field).
A specific open authoring test can return entry to draft and delete it was passing on Chrome but failing on Electron consistently (same behavior for REST and GraphQL). This revealed another race condition: When moving an entry from In Review to Draft while in open authoring mode, the PR that was created on the origin repo is closed (the forked repo branch is not deleted). One can click "Delete new entry" before the change status operation completes (moving from In Review to Draft), thus introducing the race. This doesn't have a negative effect on human users, but since the test validate toasts messages in order, it fails.
Cypress doesn't clear indexedDB between tests. This has to be done manually.

Refactoring:

Moved the tests utility methods into relevant files to keep plugin/index.js clean.

Bug fixes:

Remove redundant call to new Date().
Add null check before calling this.api.reset.
Fix the race condition described above.

CI improvements:

Run specs in parallel. This is done by splitting the CI process into 2 parts (build and e2e tests). Very similar to the azure pipeline original change described here, only without yarn caching as it is not supported yet.

@erquhart If you look at the latest run you can see the tests are passing, but it looks like GitHub actions are not overriding old statuses, just adding new ones...

Ah I was trying to understand what I was looking at, strange. Actions workflows is in beta, though, so I suppose some bugs are to be expected.


Implemented GoogleMaps API to get nearby gyms and plot on map

Get user's location from their phone and convert to coordinates
Use those coordinates to place a marker on their current location within the map
Make a call using those coordinates to find nearby gyms in a 5km radius
Color coordinate the markers for the gyms found with red for current user's location, green for open, pinkish/red for closed, yellow for unsure if open or closed.

(Sidenote: I had to turn it into a gif because it said the video was too large)

You can use pixelcloud to upload videos if you don't want to covert it to gif https://www.internalfb.com/intern/px

Wondering did you include GymMapsActivity in your PR?

That's really weird. It didn't include it for some reason. It was part of the commit though I believe. I'll check on that


Npe2 fix precommit

precommit wasn't getting applied bc the logic around the if statement wasn't quite right.
This also fixes a typo in the setup.cfg

auto-formatter for markdown?

I will do my best :) did that affect this pr?

auto-formatter for markdown?

I will do my best :) did that affect this pr?

ah, it did when I reviewed it!  It had ~250 lines changed... now it's down to 5, so maybe there was a merge in the meantime?

maybe there was a merge in the meantime

there was not, but looking at it, it looks like I screwed up the upstream merge.


Disassembly fixes and prettier formatting.

Fix errors, use more standard disassembly formats.
Show destination register value and effective address in disassembly.
Align operands column.
Use more compact output for all this to fit reasonably.
Various other errors and omissions remain to be fixed
(fence operands; showing shorter versions of instructions; etc).
This was a minimum set of fixes to help debugging.

Sorry for the delay, I'll try to do a code review and start the merge in the next few days.

closed in commit 0e70dfb14fabeaf7f96573444be9a4c8d7554d5c


emoji-picker-element v2

Breaking changes we may want to make in v2:

[ ] drop support for emojibase-data v5
[ ] migrate to emojibase-data v7 format (annotation -> label, emoticon can be an array)
[ ] drop support for trimEmojiData()
[ ] drop support for browsers that don't have ResizeObserver (there's fewer and fewer all the time)
[ ] drop support for Svelte <v3.33.0 (for emoji-picker-element/svelte)
[ ] drop support for the :focus-visible polyfill (caniuse)
[ ] rename data-source (?) (unfortunately, I remembered only after shipping it that data-* attributes have a special semantics, e.g. element.dataset)

On second thought, I'm not sure how we can "drop" support for emojibase-data. I suppose by removing it from the README? But that seems a bit harsh and unnecessary.

Well now that emojibase-data v7 is out, it's a bit clearer what we can do to drop support for the v5 format: https://github.com/nolanlawson/emoji-picker-element-data/pull/3


Ensure that Span Data Conventions is up to date

With EAP coming up, we need to ensure we correctly expose any fields in span data as one of the goals is to ensure that they are properly searchable. Having this list up to date means we can make sure that if any requires special handling on in the search, we can handle it properly.
We'll need the full name of the attribute, and the type to do this.

Tracking this with https://github.com/getsentry/sentry-conventions/issues/12
Made some progress here: https://github.com/getsentry/sentry-conventions/tree/main/model/trace


Enable Github discussions

Help us help you
None yet.
Is your feature request related to a problem?
Not with Tink itself.
Describe the solution you'd like
Enable Github discussions for the project.
Describe alternatives you've considered
Posting a question / request for help as an issue as many others have done.
Additional context
Enabling discussions could provide a kind of FAQ. Right now the issues seems to have a lot of questions that would be better off in the discussions. When an issue is closed its less likely that someone will find the information contained there.

We are going to archive this repo in this quarter as we split this repo into multiple more focused ones. We will consider enabling discussions in the new setting.
See https://github.com/tink-crypto/tink/issues/730


Rework overlay schedule to not use a map

Currently the overlay schedule is set to use a Map of slots, which is pretty large for a full mainnet epoch. We can actually write it very easily to do without, by calculating some simple modular arithmetic. This works provided d*f * slots per epoch is an integer, so we should additionally check protocol updates for this property.

Making it a function instead of a Map is of course still the ideal solution, but in the meantime, executing the following idea by @edsko and me might already be a big improvement:
The size of an epoch is 10 * k / f, which is 432,000 slots for mainnnet.
If our understanding is correct, then:

10 * k * d slots in the overlay schedule are ActiveSlot.
10 * k * f * (1 - f) slots in the overlay schedule are NonActiveSlot
10 * k * (1 - d) slots are not in the overlay schedule and can be used for Praos

For k = 2160, f = 0.05, and different values of d:

d
ActiveSlot
NonActiveSlot
Praos
Slots

1.0
21,600
410,400
0
432,000

0.9
19,440
410,400
2,160
432,000

0.5
10,800
410,400
10,800
432,000

0.1
2,160
410,400
19,440
432,000

0.0
0
410,400
21,600
432,000

So the current implementation of the OverlaySchedule stores the sum of the 2nd (ActiveSlot) and 3rd (NonActiveSlot) in a Map.
What if instead of storing the NonActiveSlots in the map, the Praos slots are stored? So instead of storing 410,400 times NonActiveSlot, store 0-21,600 PraosSlots. This means that the size of the map will be 21,600 at all times instead of 410,400-432,000 (depending on d).

Note: since we store the OverlaySchedule in the ledger snapshots on disk, this change will break binary compatibility of the snapshots, rebuilding one one from genesis.. Consensus will already break compatibility in the next release, it would be great if this change could be done in the same release, requiring us to break compatibility (and inconveniencing wallet users and stake pool operators) once instead of twice.

the arithmetic works out like this:
letting
isOBFT      ::
  Slot      ->  -- starting slot
  Rational  ->  -- decentralization parameter
  Slot      ->  -- slot to check
  Bool
isOBFT firstSlotNo dval slot = ceiling (s*dval) < ceiling ((s+1)*dval)
  where
    s = fromInteger $ slot - firstSlotNo

and
classifyOBFT ::
  Slot     ->  -- starting slot
  [a]      ->  -- genesis Nodes
  Rational ->  -- decentralization parameter
  Rational ->  -- active slot coefficent
  Slot     ->  -- obft slot to classify
  Maybe a      -- Nothing represents a silent slot, Just i means it is the i-th genesis node's turn
classifyOBFT firstSlotNo gkeys dval ascValue slot =
  if isActive
    then
      let genesisIdx = (position `div` ascInv) `mod` (fromIntegral $ length gkeys) in
        gkeys `getAtIndex` genesisIdx
    else Nothing
    where
      position = ceiling(fromInteger (slot - firstSlotNo) * dval)
      isActive = position `mod` ascInv == 0
      getAtIndex ls i = if i < length ls then Just (ls !! i) else Nothing
      ascInv = floor (1/ascValue)

Then the overlay schedule that is current in master can be alternatively computed as:
simplified firstSlotNo gkeys dval ascValue slotsPerEpoch = Map.fromList $
  [ (s, classifyOBFT firstSlotNo gkeys dval ascValue s)
    | s <-[0 ..(slotsPerEpoch-1)], isOBFT firstSlotNo dval s ]

What we can then do is completely remove the overlay schedule, and replace any lookup in it with the two functions isOBFT and classifyOBFT. We can do this in both the formal spec and the real implementation.


Refreshing the gallery or deep-linking in JQuery Mobile does not work.

If you navigate directly to the gallery page in the demo:
http://www.photoswipe.com/latest/examples/04-jquery-mobile.html#Gallery2
You will notice that when you click an image it does not open in the gallery.
This is a real problem if the gallery is the first page in your mobile app.
I just tested in Chrome and FireFox. I think the problem is because pageshow is not firing. Is there another event we can use?
Thanks

I have this problem too with dynamically added images.


Installed bash using brew not sourcing system wide /etc/bash.bashrc

Please fill out the issue checklist below and provide all the requested information.

[ ] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Linuxbrew/homebrew-core: https://github.com/Linuxbrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[ ] ran brew doctor, fixed all issues and can still reproduce the problem?
[ ] ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

What you were trying to do (and why)
I installed another bash shell by brew install bash
What happened (include command output)
It was running fine actually, the problem is it didn't source the /etc/bash.bashrc
Step-by-step reproduction instructions (by running brew commands)
Install bash using brew install bash
change default shell chsh /home/linuxbrew/.linuxbrew/bin/bash
restart terminal.

Add source /etc/bash.bashrc to your local ~/.bashrc.


Clarify some code

Without this patch, one might be confused by the meaning of
restart, and why we are doing actions twice.
This patch makes it clear that the method used to evaluate
if zypper should run twice is in fact dependent of zypper itself
and it's return code (not on some kind of obscure code output).
It should be easier to follow/review with this kind of wording.
It also removes useless methods, to be more succint.

Acceptance test failure fix: https://github.com/SUSE/skuba/pull/1066

LGTM

Rebased.

The problem in update acceptance should be fixed with https://github.com/SUSE/skuba/pull/1169 when the CI is back green.

Overall LGTM, but please take a look at the test that is failing. I suspect it might not be related with this change, but I'm not 100% sure about that

Rebased.


How to save the intermediate process images when generating images？

When running generate.py, it gives the final generated images.  And I want to get the result in every iteration, how to modify the code? Any help?

When running generate.py, it gives the final generated images. And I want to get the result in every iteration, how to modify the code? Any help?

@HuitMahoon  did you find a solution for it?


Use 24 hours or am / pm

It would be nice if we could set a boolean so the format of the hours could be on 24 hours or AM/PM

I've created a PR for this
This PR will use the devices default time format rather than a hard coded one.

Resolve in PR #10


Change depreciated unknown escapes in subrip.py for compatibility with python 3.7

Fixes https://github.com/tkarabela/pysubs2/issues/23
See https://docs.python.org/3.7/library/re.html#re.sub

Changed in version 3.7: Unknown escapes in repl consisting of '' and an ASCII letter now are errors.

I would really enjoy this change because pytest is collecting a bunch of warnings from this.

@sbstp Just to be clear (since "deprecated" may be ambiguous), this isn't just a warning but an error in python 3.7. Python 3.7 was released in June 27, 2018 and is even shipping in Debian buster, which will be "stable" soon. So it would be nice if @tkarabela could merge this so subrip works for users on python3.7.

Thanks!

I still have a warning when using the library:
.venv/lib/python3.6/site-packages/pysubs2/mpl2.py:12
  /home/simon/projects/pymero/.venv/lib/python3.6/site-packages/pysubs2/mpl2.py:12: DeprecationWarning: Flags not at the start of the expression '^(?um)\\[(-?\\d+)\\]\\[(' (truncated)
    MPL2_FORMAT = re.compile(r"^(?um)\[(-?\d+)\]\[(-?\d+)\](.*)")

Though I'm not sure if this one will break in Python 3.7


WIR/IR merge part 2: more IR factories, update tutorial

Type of change: API addition, documentation
API impact: API addition
Backend code-generation impact: None
Desired merge strategy: Rebase
I added some extra factories to plain IR nodes so that they have as many factory options as the old WIR factories. This makes it a little easier and more compelling to use them.
I also updated the tutorial to reflect the lack of IR/WIR distinction.
Contributor Checklist

[x] Did you add Scaladoc to every public function/method?
[x] Did you update the FIRRTL spec to include every new feature/behavior?
[] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[] Did you add text to be included in the Release Notes for this change?

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

My plan is that the upcoming "part 3" of this process will be changing the entire codebase to stop using WRef, WDefInstance, WSubIndex, WSubField, and WSubAccess`. I have a script to do this automatically and reliably, including some scalafix, but I imagine it's best to sneak that change in at the very end of the 1.4.0 merge window, since it will probably break a lot of backports.


gulp-sass discards changes from earlier in the pipeline when generating source maps

I believe there's a serious flaw in this plugin with the logic around file.sourceMap and opts.sourceComments. It results in node-sass attemping to re-read the file from disk, which discards changes from earlier in the gulp pipeline, and if an earlier change is a rename (e.g. with gulp-rename) it results in node-sass attemping to read a file which either doesn't exist or is the wrong file. Here are a couple of simple examples:
Given:
Gulp 3.8.10, gulp-sass 1.2.4, Ubuntu 12.
var
  gulp = require('gulp'),
  sourcemaps = require('gulp-sourcemaps'),
  rename = require('gulp-rename'),
  sass = require('gulp-sass'),
  through = require('through2');

This (rename):
gulp.task('default', function () {
  return gulp.src('./src/x.scss')
    .pipe(rename('y.scss'))
    .pipe(sourcemaps.init())
      .pipe(sass())
    .pipe(sourcemaps.write())
    .pipe(gulp.dest('./dist'));
});

Results in:
stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
Error: Error: File to read not found or unreadable: src/y.scss

And here is an example with a simple plugin that changes file contents (prepends a comment):
var prefix = function () {
  var prefix = new Buffer("\n/* Added dynamically */\n", 'utf-8');

  return through.obj(function (file, enc, cb) {
    file.contents = Buffer.concat([prefix, file.contents]);
    this.push(file);
    cb();
  })
};

gulp.task('default', function () {
  return gulp.src('./src/x.scss')
    .pipe(prefix())
    .pipe(sourcemaps.init())
      .pipe(sass())
    .pipe(sourcemaps.write())
    .pipe(gulp.dest('./dist'));
});

This results in the changes from the prefix plugin being discarded.
This means that the changes proposed in Consistent file handling #66 should not be accepted -- things need to go the other way.
If we're on the same page about this, I may work on a pull request.

@dlmanning @Keats So I've tracked down this problem. We're passing the file name to node-sass for libsass to compile instead of passing along the data stream and we should probably be passing along the data stream. The problem, however, with passing along the data stream is that we then need to pass along all of the includePaths for that file which would require us (or node-sass, or libsass if we can convince either of them) to build a graph the includePaths.
@jmm, your rename problem can be resolved by renaming it after compiling your file. The prefix problem persists until we determine what we're going to do about the data issue

@Snugug

your rename problem can be resolved by renaming it after compiling your file

That example is just to illustrate one of the failure modes. But, doing the rename after isn't equivalent, because then the original name winds up in the sources array of the source map.

@jmm Understood, see the rest of my comment about the underlying issue.

@Snugug Yup, I read it all, but even the rename case isn't fully solved until the underlying issue is corrected.

Right, I'm looking into a solution now.

Great, thanks!

@jmm Give this a test:
npm install snugug/gulp-sass#2.x-filedata --save-dev

I think I've fixed this to work as you're expecting. The two examples you've provided now work.

Thanks @Snugug. I tried it and it does indeed work as it should now for the the test cases I posted.


chore: release main

:robot: I have created a release beep boop
package-c: 4.6.0
4.6.0 (2023-09-06)
Features

add new feature (c6398d3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hung-cybo/demo-monorepo-release-please/releases/tag/package-c%404.6.0 :sunflower:


Add auction pallet unit tests

Thanks Mike for the PR, we have upgraded the Auction pallet and the unit tests seems to be outdated.


Makefile: Minor readability update of the image, demo name parsing

@bart0sh @mythi
Thanks, both options are good. Picked the one without pipe.


Allow resize -s to take a string size rather than ID

While writing a bash completion script for Tugboat I discovered that using tugboat resize droplet -s 1GB fails as it expects the ID of the size from tugboat sizes
I'm not sure if the --size flag is any different but I think it would make more sense for both to support the string representation of the size.
In terms of the bash completio it makes a lot more sense since you cannot display the Human readable string representation to the user but actually submit the ID to the command.

Closed by #161 (New API uses string slugs)


Add automation for meetups, add the 2nd meeetup

This change introduces adds an automation which generates the list of
meetups and meeetup pages from the info provided in data.json file. It
also adds an info about the meetup on January 2022.
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

Looks awesome!


initial setup done

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

this was a draft closing this since this is not right one


TensorFlow.js Double includes

Should TensorFlow.js be a peer dependency?  I'm having some issues trying to include Danfo.js and when I'm in Node, I get errors when I try to bring tf.
I have similar issues when I try to bring it in on observablehq

My guess is that you might need the TF version to be a peer dependency.  If that's a no-go, then you'll need to expose your included version of TFJS with something like cosnt tf = dfd.tfjs

Yes, thanks for noticing this, we do need to add TFJS as a peer dependency.

let me know if you'd like me to do this PR.  I'd be happy to help.

Fixed in #71


Revert "Exit with non-zero when we fail to fetch cache"

This reverts commit 7e3ffb6627ecbc9d52ac94b0033ebd3bc8c52d46.

Closing because it has to be merged against production branch


fix: better error handling when installing packages

Changes error handling to either re-throw the original message, or throw a new error using the old error as context.
GH Issue: https://github.com/forcedotcom/cli/issues/2882
@W-15832085@

QA NOTES
Install key not passed

🟢 Before: The subscriber package version 04tAAAAAAAAAAAAAAA is invalid, no subscriber package version record found.
🟢 After: Please provide installationkey when querying against SubscriberPackageVersion that is protected by installationkey

Install key incorrect

🟢 Before: The subscriber package version 04tAAAAAAAAAAAAAAA is invalid, no subscriber package version record found.
🟢 After: Invalid InstallationKey for SubscriberPackageVersion

Error message is more clear when using publish-wait

Install key not passed (with --publish-wait)

🟢 Before:

Error (1): The subscriber package version is not fully available.

Try this:

Please provide installationkey when querying against SubscriberPackageVersion that is protected by installationkey

🟢 After: Please provide installationkey when querying against SubscriberPackageVersion that is protected by installationkey

Install key incorrect (with --publish-wait)

🟢 Before:

Error (1): The subscriber package version is not fully available.

Try this:

Invalid InstallationKey for SubscriberPackageVersion

🟢 After: Invalid InstallationKey for SubscriberPackageVersion


Add nagulvali555

LGMT 🚀 Your PR is ready to get merged, permissive community members will merge it after reviewing it soon 🚀


SNZB-01 Wireless Button battery level

I seem to be able to fetch the "battery_level" attribute for all of my battery powered sonoff devices, except for the SNZB-01.. is this a hardware limitation, or an issue with this integration?

I think this is a bug. Because I can see battery level here:
https://github.com/AlexxIT/SonoffLAN/issues/223#issuecomment-699874934
Will check it.

I've noticed the other devices I have now seem to use ''battery_level' instead of 'battery'.

My wireless buttons have now started showing battery level.. out of nowhere.. very odd.

Probably fixed in latest master-version


Invalid license digest with multiple RSA service providers

Today I encountered, that as I loaded a certain library (i.e. icepdf), suddenly my otherwise valid license was no longer recognized as properly signed. As I dug through the code, the issue appears to be originating from the bouncy castle library, which is included and loaded by icepdf.
In particular, the issue encounters, because in the License class on line 140, the following function call
final var cipher = Cipher.getInstance(key.getAlgorithm());
Does no longer return the "SunJCE: Cipher.RSA -> com.sun.crypto.provider.RSACipher" but instead, the "BC: Cipher.RSA -> org.bouncycastle.jcajce.provider.asymmetric.rsa.CipherSpi$NoPadding" Cipher.
The latter decrypts the signature in a substantially different way as the first, native Cipher implementation as it "padds" the decrypted digest to 255 bytes.
At this point, I'm not quite sure how to fix this issue, but a reasonable approach would be to enforce the selection of Sun's Cipher.RSA, no matter which other crypto libraries are loaded.
Cheers
Maurice

After further research, according to [this] (https://stackoverflow.com/a/32033937) StackOverflow thread, it is bad practice to instantiate a Cipher by using Cipher.getInstance("RSA") (which is currently done), as this is no fully qualified cypher string.
Instead, it is recommended to use a cipher string defined in the official [Java Docs] (https://docs.oracle.com/javase/10/docs/api/index.html?javax/crypto/Cipher.html).
I tested the fully qualified cipher string "RSA/ECB/PKCS1Padding" and the result, although the security provider is still bouncy castle, does not include the padding shown above.
In the end, iI think this melts down to the fact, that instead of using the algorithm, retrieved by the public key, a static cipher qualifier should be used. However, as I don't know the code thoroughly, this may limit any flexibility for using other asymmetric encryption algorithms.
Except from that, a solution could also be to not compare the digest and the decrypted signature 1:1 but instead to "search" the digest in the decrypted signature. This way, as long as the result of the decryption contains the digest somewhere, the license will be marked as signed.

Could you help me disclosing which version of License3j is this ticket related to?

I’m using License 3j Version 3.0.1

I had some time to read your ticket in detail and I feel like I understand the issue.
First and foremost: I do not agree with the quick fix you propose. It would be a workaround for one situation and does not solve the problem.
The problem itself is that the algorithm specification is not fully qualified and thus leaves room for the actual implementation to execute it at its discretionary decision. That way the BC implementation that was on the classpath in your test implemented the decoding differently than the standard implementation.
License3j DOES NOT USE any algorithm specification in its core. It is only the REPL application that uses RSA as a default value for the algorithm specification string. It seems that this default is not the best choice and I will change it to RSA/ECB/PKCS1Padding in the next release that will already feature the REPL application as a separate JAR.
Thanks for the ticket and the analysis, I have learned a lot from your ticket.

I tried it (no BC on the classpath):
[WARNING] No console in the system
License3j REPL application
CDW is C:\Users\Peter_Verhas\Dropbox\github\License3jRepl\.
type 'help' for help
Startup file .license3j was not found.
L3j> $ help gen
generateKeys [algorithm=RSA/ECB/PKCS1Padding] [size=2048] [format=BINARY*|BASE64] public=xxx private=xxx
Generate public and private keys and save them into files.
You can specify the algorithm, key size and the format. The defaults are RSA, 2048 and BINARY.
You should specify the file names using the parameters 'public' and 'private'.
The keys remain in the memory and can be used to sign and verify license.

No license in memory
No keys in memory.
L3j> $ gen algorithm=RSA/ECB/PKCS1Padding public=pub.key private=priv.key
[ERROR] Algorithm RSA/ECB/PKCS1Padding is not handled by current version of this application.
L3j> $
L3j> $

OK.
Now I understand. The key generation is RSA but using it has to define the other parameters.
I will have a look at how to incorporate that into the code.

Thank you for digging into this! Glad I could support the project. I'm looking forward to the next release. Keep up the good work!

I created a fix that you can see on the master branch version 3.1.0-SNAPSHOT.
With this modification when you generate the key only the algorithm is taken into account from the transformation specification string but the whole string is stored in the keys when they are converted to byte array and saved to file. When signing and verifying is executed this string is used.


Release to production (prod-stable)

LGTM

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


File browser not getting refreshed after aggregation creation

There seems to be a regression issue where a line of code was changed to reference a previously deleted function (https://github.com/hydroshare/hydroshare/blob/develop/theme/static/js/hs_file_browser.js#L2225). This error is preventing the file browser to refresh after creating an aggregation from an existing file.
The file seems to have been reverted after July 13th, but none of the commits that day show this change. https://github.com/hydroshare/hydroshare/commits/develop/theme/static/js/hs_file_browser.js
Anyways, I will be adding this line back to fix this bug. How this file got reverted is a mystery that will haunt me for a while.

Fix has been merged to develop and will be deployed in next release.


World Access Owner - Give players the right to grant access to specific worlds.

I have several words on my server that can only be accessed by a specific group of people (private worlds).  Rather than giving the world owner admin (which would allow them to invite users to any group), i would prefer that the world owners could create their own access groups and invite users to their group to access the world.
Can you add this sort of functionality?
P.S. The way im doing it now, world owners tell me who should have access. But this is slow since they have to wait until i add those users before they can access the world.

Unless MV implements custom storing to which player have access to which world, I don't think it's possible with MV. I think with now more advance permission plugin like luckperms you should be able to fine-tune the adding of rank and permissions. https://github.com/lucko/LuckPerms/wiki/Argument-based-command-permissions


Add mechanism to log method, db calls and service call times

Description:
Add method level time logs to apim packages such as org.wso2.carbon.apimgt.gateway, org.wso2.carbon.apimgt.keymgt and org.wso2.carbon.apimgt.impl, in order to improve the overall observability of the product. Also add logs to track external calls such as database calls and service calls done by the APIM.
Suggested Labels:

Suggested Assignees:

Affected Product Version: 2.1.0, 2.5.0, 2.6.0
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues: https://github.com/wso2/product-apim/issues/3844

This issue is resolved


Existing on-conflict statements get overridden by PostgreSQL on-conflict compiler

If we craft a specific SQL statement with an on-conflict clause, it is overwritten by our custom SQL compiler.
We need to

[ ] Pass through existing ON CONFLICT statements by default
[x] Consider adding a restrict or fail mode that does nothing on conflict
[x] Consider eventually making this 'no-op' the default

A 'restrict' mode exists and it seems to be the default...


Dojo Survey (Multiple Choice - UI rendering issues)

Bug description
The multiple-choice selection in the Defectdojo Survey doesn't display the UI in the intended way.
The UI needs to be fixed to allow Multile-choice to be better visible
Steps to reproduce
Steps to reproduce the behavior:

Go to 'Create survey with Multiple-choices'
Send Survey 'via link, with the new survey just created'
Scroll down to 'Multiple choice question in the survey and you'll see the UI doesn't handle it properly.'
See error

Expected behavior
The UI should handle Multiple Choices and render them properly.
Deployment method (select with an X)

[ ] Kubernetes
[ ] Docker
[x] setup.bash / legacy-setup.bash

Environment information

Ubuntu 18.04
DefectDojo 1.6.0

Screenshots (optional)

I think we will have to wait until #2334 is merged to fix this.

Thanks @JoseRoman


Setctty set but Ctty not valid in child with Go +be08e10b3b

Steps to reproduce:
go version
go run .

-- go.mod --
module mod.com

go 1.15

require (
        github.com/creack/pty v1.1.9
        golang.org/x/sys v0.0.0-20200501145240-bc7a7d42d5c3 // indirect
)
-- main.go --
package main

import (
        "io"
        "io/ioutil"
        "os/exec"

        "github.com/creack/pty"
)

func main() {
        cmd := exec.Command("vim")
        thepty, err := pty.Start(cmd)
        if err != nil {
                panic(err)
        }
        io.Copy(ioutil.Discard, thepty)
}

What did you expect to see?
No panic
What did you see instead?
Panic:
panic: fork/exec /home/myitcv/dev/vim/src/vim: Setctty set but Ctty not valid in child

goroutine 1 [running]:
main.main()
        $WORK/main.go:15 +0xd5
exit status 2

Bisected to this change: https://go-review.googlesource.com/c/go/+/231638/
FYI @ianlancetaylor @neild @mvdan

Previous discussion in https://github.com/golang/go/issues/29458

reproduced. Investigating.

Note copied from golang/go#29458:
If tty is going to be open in the child process, then it must have a file descriptor in the child process. When using os/exec.Cmd as the creack/pty code does, tty must be in Stdin or Stdout or Stderr or ExtraFiles. If it isn't in any of those, then it will be closed when the child process runs. If it is in one of those, that gives you the file descriptor number that you should use in Ctty.
Right now the creack code is setting Ctty to the parent's file descriptor number. That is working (assuming that it is working) by accident. The correct fix is to ensure that tty is passed to the child somewhere, and set Ctty to the appropriate descriptor number. If it is possible for all of Stdin, Stdout, Stderr to be set, the simplest approach would be to always add tty to ExtraFiles, and set Ctty to 3. That will work for old versions of Go and also for the upcoming 1.15 release.


Does read_with only take idempotent operations?

I was reading the implementation behind read_with and I was wondering - wouldn't the loop in the method potentially cause the op, such as l.accept() to be called multiple times? Are all methods fed to read_with meant to be idempotent?
    /// # Examples
    ///
    /// ```no_run
    /// use async_io::Async;
    /// use std::net::TcpListener;
    ///
    /// # futures_lite::future::block_on(async {
    /// let listener = Async::<TcpListener>::bind(([127, 0, 0, 1], 0))?;
    ///
    /// // Accept a new client asynchronously.
    /// let (stream, addr) = listener.read_with(|l| l.accept()).await?;
    /// # std::io::Result::Ok(()) });
    /// ```
    pub async fn read_with<R>(&self, op: impl FnMut(&T) -> io::Result<R>) -> io::Result<R> {
        let mut op = op;
        loop {
            match op(self.get_ref()) {
                Err(err) if err.kind() == io::ErrorKind::WouldBlock => {}
                res => return res,
            }
            optimistic(self.readable()).await?;
        }
    }

I do notice that methods like accept, when set to nonblocking won't wait for a new TCP connection to be established:
#[test]
fn test_accept() {
    let l = std::net::TcpListener::bind("<IP_ADDRESS>:8080").unwrap();
    l.set_nonblocking(true).unwrap();

    loop {
        let res = l.accept();
        match res {
            Ok(_) => break,
            Err(_) => {}
        }
    }
    println!("Finished");
}

Yes, read_with only takes idempotent operations, as stateful operations need additional support to work well with async.

Got it, thanks!


Flow is unsound. Unable to differentiate between arrow functions and class constructors.

const functionNotClass = (input) => true;
(functionNotClass: Class<any>); // no errors from Flow
const gonnaTrustFlow = new functionNotClass()
// runtime Uncaught TypeError: functionNotClass is not a constructor

class ClassNotFunction extends Error {}
(ClassNotFunction: () => Error); // no errors from Flow
const gonnaTrustFlowAgain : Error = ClassNotFunction()
// runtime Uncaught TypeError: Class constructor ClassNotFunction cannot be invoked without 'new'

Try flow

This is fixed a while ago.


TRY003 should not apply to NotImplementedError

My understanding of the rationale according to https://beta.ruff.rs/docs/rules/raise-vanilla-args/ it's to prevent overloading exceptions to be used broadly, with the specifics of the exceptions being defined by the string passed to them.
In general, I agree with this, but for NotImplementedError, do we really want to encourage people subclassing it for every feature that they haven't built yet?  I find the to be self-explanatory and not need a mesage.

I am, here is an example:

But, just confirming -- that example doesn't trigger TRY003, since you're assigning to a msg variable, right?
https://play.ruff.rs/730cceb0-7578-4140-b09e-b52fed77e965

@charliermarsh that is correct, but that probably could be considered a bug / limitation, as the string being defined in a variable outside of the raise statement has nothing to do with "long exception messages that are not defined in the exception class itself."


TypeError: add_weight() got multiple values for argument 'name'

When I execute run_hun.py, it throws following error:
2020-11-04 16:53:37.555288: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'cudart64_101.dll'; dlerror: cudart64_101.dll not found
2020-11-04 16:53:37.555502: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
C:\Users\Rahman\PycharmProjects\hierarchialAttention\venv\lib\site-packages\pandas\core\generic.py:5168: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead

See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
  self[name] = value
Total 74128 unique tokens.
Shape of data tensor: (124989, 4, 150)
Shape of labels tensor: (124989, 30)
Number of positive and negative reviews in traing and validation set
['ARTS', 'ARTS & CULTURE', 'BLACK VOICES', 'BUSINESS', 'COLLEGE', 'COMEDY', 'CRIME', 'EDUCATION', 'ENTERTAINMENT', 'FIFTY', 'GOOD NEWS', 'GREEN', 'HEALTHY LIVING', 'IMPACT', 'LATINO VOICES', 'MEDIA', 'PARENTS', 'POLITICS', 'QUEER VOICES', 'RELIGION', 'SCIENCE', 'SPORTS', 'STYLE', 'TASTE', 'TECH', 'TRAVEL', 'WEIRD NEWS', 'WOMEN', 'WORLD NEWS', 'WORLDPOST']
[1228, 1073, 3121, 3402, 932, 3207, 2317, 792, 11426, 1122, 1141, 2102, 5352, 2052, 929, 2246, 3132, 26136, 3991, 2069, 1097, 3295, 1797, 1693, 985, 1727, 2108, 2780, 1747, 4993]
[281, 266, 737, 852, 212, 764, 576, 212, 2831, 279, 257, 520, 1342, 550, 200, 569, 823, 6603, 1004, 487, 284, 872, 457, 403, 246, 418, 562, 710, 430, 1250]
Total absent words are 17810 which is 24.03 % of total words
2020-11-04 16:54:21.322906: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'nvcuda.dll'; dlerror: nvcuda.dll not found
2020-11-04 16:54:21.323104: W tensorflow/stream_executor/cuda/cuda_driver.cc:312] failed call to cuInit: UNKNOWN ERROR (303)
2020-11-04 16:54:21.326789: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:169] retrieving CUDA diagnostic information for host: DESKTOP-MMSO9D8
2020-11-04 16:54:21.327043: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:176] hostname: DESKTOP-MMSO9D8
2020-11-04 16:54:21.336196: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x179cfa0ad80 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-11-04 16:54:21.336432: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
Traceback (most recent call last):
  File "C:/Users/Rahman/PycharmProjects/hierarchialAttention/run_han.py", line 42, in <module>
    main()
  File "C:/Users/Rahman/PycharmProjects/hierarchialAttention/run_han.py", line 28, in main
    max_senten_len=150, max_senten_num=4, embedding_size=100, validation_split=0.2, verbose=1)
  File "C:\Users\Rahman\PycharmProjects\hierarchialAttention\HAN.py", line 74, in __init__
    self.set_model()
  File "C:\Users\Rahman\PycharmProjects\hierarchialAttention\HAN.py", line 241, in set_model
    word_att = AttentionWithContext()(word_dense)
  File "C:\Users\Rahman\PycharmProjects\hierarchialAttention\venv\lib\site-packages\tensorflow\python\keras\engine\base_layer.py", line 926, in __call__
    input_list)
  File "C:\Users\Rahman\PycharmProjects\hierarchialAttention\venv\lib\site-packages\tensorflow\python\keras\engine\base_layer.py", line 1098, in _functional_construction_call
    self._maybe_build(inputs)
  File "C:\Users\Rahman\PycharmProjects\hierarchialAttention\venv\lib\site-packages\tensorflow\python\keras\engine\base_layer.py", line 2643, in _maybe_build
    self.build(input_shapes)  # pylint:disable=not-callable
  File "C:\Users\Rahman\PycharmProjects\hierarchialAttention\attention_with_context.py", line 72, in build
    constraint=self.W_constraint)
TypeError: add_weight() got multiple values for argument 'name'

I had the same issue as well!

same issue! :(