Fixed connect not loading drives outside date range

Fixes #520. This is not the most robust solution, but it works. The problem is caused by the fact that once a date range is selected, around LIMIT_INCREMENT routes in that date range only would be loaded initially. If the link for a drive outside that range is then loaded, the route data hasn't loaded yet and will never be unless the UI is scrolled and an update is triggered.
The fix currently implemented is to check the URL at startup, and if a drive URL is found, just load all the drives with no limit. This will ensure that the route data for the selected drive is loaded as well. Not the most cleanest solution, but works. I couldn't find a more straightforward fix to this.

Loading all routes isn't an appropriate solution, we should go and check how this used to work and replicate that. Was it an API query using the time ranges? Perhaps we can just query w/ the route name

Loading all routes isn't an appropriate solution (speed), we should go and check how this used to work and replicate that. Was it an API query using the time ranges? Perhaps we can just query w/ the route name

We used to have the time range in the URL. We'll have to update the endpoint to also take a route name I guess.

Yeah that makes the most sense.

https://github.com/commaai/comma-api/blob/d23b152ea64bfcd0de0937d2d525d556870820b6/src/drives.js#L17

Yes, I'll fix it. Just working on something else rn, please keep this PR open

With this, I'm getting a CORS error. Can't seem to get around it. Any idea why?

I also tried with a plain JS fetch() without using the client JS library. Doesn't seem to work either, throws the same error.  I'm sure it's something I'm doing wrong because this same endpoint is used in the new connect. But I can't figure it out.

This issue has been fixed. for some reason, none of the CF pages related to my PR's are updating on subsequent commits. So, the URL related to this PR is outdated. However, the issue has been solved and the drives are loading.

This still doesn't work properly... It never recovers from this state:

Have a PR to properly fix this: https://github.com/commaai/connect/pull/544

i can't see the issue. seems fine for me
https://github.com/user-attachments/assets/d7e0eb1f-9476-4c7c-81e7-c297d3237f28

Try loading a route outside the first 10 that load by default, you may need to zoom in

Very strange, I can reproduce it locally with pnpm start but not the deployed preview. Maybe something different in how it's run in production

seems like it works now 😅
are you going to merge this or do you want me to clean up anything more?


PDF operators for the random samplers, and also the Dirichlet

Description
This PR replaces https://github.com/apache/incubator-mxnet/pull/14579; when I retargeted that from 1.3.x to master, the Jenkins CI build got confused somehow, and refuses to start new test runs (though the Travis build was fine).  All the comments from the review of that PR should be addressed in this changeset.
This PR adds operators for computing the densities of samples drawn from any of the various distributions defined in operator/random, as well as their gradients, plus also the Dirichlet even though we don't yet have a sampler for it.  There are lots of changes to test_random.py to test each PDF alongside its distribution; aside from that, the patch should be entirely stand-alone.  See pdf_op.cc for more-detailed description strings.
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Thanks for migrating your PR from v1.3.x branch to master.
@mxnet-label-bot Add [pr-awaiting-review, operator]

The Python3 TensorRT GPU test failed: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14617/1/pipeline
That failure doesn't look related to the PR; first make warns that "TensorRT not enabled by default.  Please set the MXNET_USE_TENSORRT environment variable to 1 or call mx.contrib.tensorrt.set_use_tensorrt(True) to enable."  Then a bit later, Cuda initialization fails with error 35.  I made a trivial change to rerun the tests, and the same thing happened again (along with a numeric differentiation failure that I'll investigate).  Is that test known to be flaky?

The Python3 TensorRT GPU test failed: ...

It looks like lots of other PRs are failing the same way, e.g. http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14393/3/pipeline/, http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14614/4/pipeline/, http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14476/24/pipeline/274, http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14639/1/pipeline/, http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-14614/3/pipeline/

The build checks all pass now.  What's the next step to get this merged?

@apeforest @eric-haibin-lin could you help review? thanks!

Would be really good if we can get this in. There are multiple teams that I know that will benefit from it. It also addresses most requested features from #12932.

Apologies for the delay and thanks for this contribution. It is plenty useful.
I have put in a few comments but the PR looks good to me for most part. I have marked some of the committers to review/merge this PR.
@eric-haibin-lin @szha @reminisce @haojin2 can you please take a look.

Seems pretty sparse on the documentation front.

The customer-facing docs in pdf_op.cc, do you mean, or internally?

Seems pretty sparse on the documentation front.

The customer-facing docs in pdf_op.cc, do you mean, or internally?

I missed that for some reason on my first pass. No, that all looks good, actually. Sorry about the confusion.

commenting to reopen, I was trying to debug a mysterious linker failure in unix-gpu, which does not occur in mainline but which nevertheless seems to exist independent of any of these changes.

@samskalicky @apeforest for review

LGTM

This also has not checked the grad_req=kAddTo case. Let's revise it later @haojin2

Curious to know if pdf operators aren't supposed to have NDArray API? Currently they're only in Symbol API right? @sxjscience @david-seiler
Thanks.


snd: 17.8 -> 18.1

Semi-automatic update. These checks were performed:

built on NixOS
ran /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1/bin/snd --help got 0 exit code
ran /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1/bin/snd --version and found version 18.1
ran /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1/bin/snd --help and found version 18.1
found 18.1 with grep in /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1
found 18.1 in filename of file in /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1

cc "@fuuzetsu"

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘snd-18.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/audio/snd/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1
shrinking /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1/bin/snd
gzipping man pages under /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1/bin
patching script interpreter paths in /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1
checking for references to /tmp/nix-build-snd-18.1.drv-0 in /nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1...
/nix/store/h2s0m8v39bj1z84habnkrxidkip0vmbr-snd-18.1

Failure on aarch64-linux (full log)
Partial log (click to expand)
make[1]: Entering directory '/build/gsl-2.4/matrix'
make  test test_static
make[2]: Entering directory '/build/gsl-2.4/matrix'
gcc -DHAVE_CONFIG_H -I. -I..  -I..   -g -O2 -c test.c
/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash ../libtool  --tag=CC   --mode=link gcc  -g -O2   -o test test.o libgslmatrix.la ../vector/libgslvector.la ../block/libgslblock.la ../ieee-utils/libgslieeeutils.la  ../err/libgslerr.la ../test/libgsltest.la ../sys/libgslsys.la ../utils/libutils.la -lm
libtool: link: gcc -g -O2 -o test test.o  ./.libs/libgslmatrix.a ../vector/.libs/libgslvector.a ../block/.libs/libgslblock.a ../ieee-utils/.libs/libgslieeeutils.a ../err/.libs/libgslerr.a ../test/.libs/libgsltest.a ../sys/.libs/libgslsys.a ../utils/.libs/libutils.a -lm
gcc -DHAVE_CONFIG_H -I. -I..  -I..   -g -O2 -c test_static.c
building of '/nix/store/vphhsb14n5nq6kbyihcz8xf93y0sgnzz-gsl-2.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/6n4gxmyw87ni2ghwlrpmgdfz49l7rq4q-snd-18.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6n4gxmyw87ni2ghwlrpmgdfz49l7rq4q-snd-18.1.drv' failed


WFLY-16434 ArtifactFactoryService class should invoke AbstractArtifac…

…tFactory.findBeans() directly
https://issues.redhat.com/browse/WFLY-16434

Need to rebase and refresh once WFLY-16931 Drop source transformation for batch-jberet subsystem #16041
is merged.

Thanks @chengfang


Argument Error

@client.spot(@place_id) throws a argument error for some of the place ids

Mind adding an example of a place id that throws an argument error?

I believe I'm seeing the same error after upgrading to v0.34.0 as I did not encounter an error on v0.33.0.
The exact error I get is:
ArgumentError: wrong number of arguments (given 6, expected 7)
The backtrace is:
google_places-0.34.0/lib/google_places/review.rb:6:in `initialize'
google_places-0.34.0/lib/google_places/spot.rb:464:in `new'
google_places-0.34.0/lib/google_places/spot.rb:464:in `block in reviews_component'
google_places-0.34.0/lib/google_places/spot.rb:463:in `map'
google_places-0.34.0/lib/google_places/spot.rb:463:in `reviews_component'
google_places-0.34.0/lib/google_places/spot.rb:440:in `initialize'
google_places-0.34.0/lib/google_places/spot.rb:258:in `new'
google_places-0.34.0/lib/google_places/spot.rb:258:in `find'
google_places-0.34.0/lib/google_places/client.rb:117:in `spot'

My calling code is:
GooglePlaces::Client.new("<MY-API-KEY>").spot("<THE-ID>")

Here's where I can't make sense of it. Line 6 of the Review class when viewing the v0.34.0 tag on GitHub is not the definition of the initialize method and clearly only expected 6 arguments, not 7 as the error suggests:
https://github.com/qpowell/google_places/blob/0.34.0/lib/google_places/review.rb#L6
If I download the gem directly from RubyGems.org (https://rubygems.org/downloads/google_places-0.34.0.gem) and extract the gem archive then the inner data archive and view the Review class, I see the following definition:
module GooglePlaces
  class Review
    attr_accessor :rating, :type, :author_name, :author_url, :text, :time,
                  :profile_photo_url

    def initialize(rating, type, author_name, author_url, text, time, profile_photo_url)
      @rating            = rating
      @type              = type
      @author_name       = author_name
      @author_url        = author_url
      @text              = text
      @time              = time
      @profile_photo_url = profile_photo_url
    end
  end
end

Notice the extra profile_photo_url argument which is not included at the GitHub tag. It seems the Review class included in the gem archive is not the same Review class included in the git repo, hence the error.
Could it be that when building the gem archive, a change to the Review class was either included by accident, or forgot to be committed/pushed to GitHub?

 Will build 0.34.1 and push now.

Fixed and pushed now - apologies for this

Terrific, that fixed it. Thanks for the quick turnaround.


Feature request:  Show time that a cell was executed at and execution duration in notebooks

Azure Data Studio Version:

Steps to Reproduce:
Run a cell that takes awhile.  Get coffee, come back.  Cool, it's done! How long did it actually take to run though?
Run a cell.  Get coffee, come back.  What time did I run that cell at again?

Very useful. However, there should also be a way to turn them off.

This is definitely something that would be beneficial for me/my use case.
The datetime of a given cell executing within a SQL Notebook (in my case) would allow me to use notebooks as a work confirmation tool working through a notebook with multiple cells. This means that we can use a notebook as a means of saying "Look, this is what the query came back with yesterday", or "Look, this is what I ran last night to resolve the problems on replication on PROD".

The tool does a nice job of showing the execution time on each cell.  Sure would be nice to configure the workbook to included a UTC date timestamp on every cell execution.
Really would help when sharing a workbook with other engineers, so they can see when the data was extracted.  Especially useful when query Azure Logs, since many queries typically use where clause with  relative date-time, e.g.
"Where TimeGenerated > ago(1h)"
Yes, the results are there, but because the timestamp is missing, we have no clue what ago(1h) was.

This one has been requested a while ago and it's time to get it of the backlog and into development. Shouldn't be that hard?


Preserving old versions when increasing PHP version requirement

Could you please consider preserving an older version that would run on PHP 5.6? If another dev joins our project, he won't be able to run composer install to fetch Symplify/ControllerAutowire.
Also, it seems I can no longer use composer for anything because it dies with
  Problem 1
    - symplify/controller-autowire dev-master requires php ^7.1 -> your PHP version (5.6.25) does not satisfy that requirement.
    - symplify/controller-autowire dev-master requires php ^7.1 -> your PHP version (5.6.25) does not satisfy that requirement.
    - Installation request for symplify/controller-autowire dev-master -> satisfiable by symplify/controller-autowire[dev-master].

I can neither add new packages nor update existing ones. That's a major bummer.

Here's the version I have, by the way.
    "require": {
        "php": "~5.6|~7.0",

symplify-php5.6.zip

Supporting older PHP version shown as destructive for current ones for my packages. But it might just by my approach to it. It can be subjective
But if you really need this, I'm open to give you access for the repository to maintain an older version.

Ping?

Thank you for your offer but I can't donate any more time.

Ok. Closing for now. Let me know if anything changes.


Component only updated by dash callbacks when we click them

In demo page's SourceViewer demo, we can see that the component is updated every time the slider is dragged:

However, the same demo in Dash doesn't automatically update the component when the callback is fired by the slider; instead, you have to click on the canvas:

Any idea why this might happen?

Yes we need to trigger a render. I've already done the change earlier this morning on the react library. But I will need the update code to change another state on the view.

Yes we need to trigger a render. I've already done the change earlier this morning on the react library. But I will need the update code to change another state on the view.

Sure! Which update code would it be?

Sure! Which update code would it be?

I was retrying to do that,

@app.callback(
    Output("vtk-view", "triggerRender"),
    [],
)
def render():
    render_count += 1
    return render_count

@app.callback(
    Output("vtk-algorithm", "state"),
    [Input("slider-resolution", "value"), Input("capping-checklist", "value")],
)
def update_cone(slider_val, checked_values):
    render()
    return {"resolution": slider_val, "capping": "capping" in checked_values}

I was retrying to do that,

@app.callback(
    Output("vtk-view", "triggerRender"),
    [],
)
def render():
    render_count += 1
    return render_count

@app.callback(
    Output("vtk-algorithm", "state"),
    [Input("slider-resolution", "value"), Input("capping-checklist", "value")],
)
def update_cone(slider_val, checked_values):
    render()
    return {"resolution": slider_val, "capping": "capping" in checked_values}

def render():
    render_count += 1
    return render_count

@app.callback(
    [Output("vtk-algorithm", "state"), Output("vtk-view", "triggerRender")],
    [Input("slider-resolution", "value"), Input("capping-checklist", "value")],
)
def update_cone(slider_val, checked_values):
    render()
    return [ {"resolution": slider_val, "capping": "capping" in checked_values}, update]

def render():
    render_count += 1
    return render_count

@app.callback(
    [Output("vtk-algorithm", "state"), Output("vtk-view", "triggerRender")],
    [Input("slider-resolution", "value"), Input("capping-checklist", "value")],
)
def update_cone(slider_val, checked_values):
    render()
    return [ {"resolution": slider_val, "capping": "capping" in checked_values}, update]

@app.callback(
  Output(...),
  [Input('my-slider'...)],
  [State('graph', 'data')]
)
def update_cone(slider_value, my_data):
  ...
  return ...

If graph is updated, the callback will be triggered. but if slider is updated, callback will be triggered.

@app.callback(
  Output(...),
  [Input('my-slider'...)],
  [State('graph', 'data')]
)
def update_cone(slider_value, my_data):
  ...
  return ...

If graph is updated, the callback will be triggered. but if slider is updated, callback will be triggered.

@jourdain Just sharing in case you are not aware: I tried running usage-pyvista-terrain-following-mesh and the triggerRender doesn't seem to work.

@jourdain Just sharing in case you are not aware: I tried running usage-pyvista-terrain-following-mesh and the triggerRender doesn't seem to work.

need to re-run npm i

need to re-run npm i

Ok it works. thanks!

Ok it works. thanks!


Unable to use Kubernetes ingress records in 1.3.0 without additional config

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
I updated one of our clusters to 1.3.0 (using Helm). We enabled k8s Ingress resources with the ingress controller.
After upgrading to 1.3.0, however, they all stopped working. Once I added ingressClass and ingressControllerMode to the Mesh config in the istio configmap, they started working again.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[X] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
According to https://github.com/istio/istio/blob/1.3.0/galley/pkg/config/meshcfg/defaults.go#L26, the default values for ingressClass is istio and the istioControllerMode is STRICT.
Therefore, I shouldn't have had to update the mesh config in the istio configmap in order to use the Kubernetes Ingress resources - especially since these values cannot be set in the Helm chart today.
Steps to reproduce the bug

Install Istio with k8sIngress.enabled set to true
Create an Ingress resource with the kubernetes.io/ingress.class: istio annotation

Observe that the navigating to that domain returns a 404.

Add ingressClass: istio and ingressControllerMode: STRICT to the istio configmap, under mesh

Restart galley and observe that (after a minute or two) the ingress will now work.
Version (include the output of istioctl version --remote and kubectl version)
❯ istioctl version --remote
client version: 1.3.0
control plane version: 1.3.0

❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.2", GitCommit:"f6278300bebbb750328ac16ee6dd3aa7d3549568", GitTreeState:"clean", BuildDate:"2019-08-05T09:15:22Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Helm
Environment where bug was observed (cloud vendor, OS, etc)
Azure AKS-Engine cluster
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

@ozevren do we need to add the default overrides linked above to https://github.com/istio/istio/blob/a19791b326977f47f17412211c09c03e2eecae12/galley/pkg/meshconfig/cache.go#L60 as well?
ref #16270

It looks like the defaults that Galley obtained from Pilot has diverged in https://github.com/istio/istio/pull/12120 (first trace of it I could find). Galley has been operating with those defaults for a long time, so it's been its behavior for better or worse. I think introducing it back is the right thing to do.


Different help results for plugins -h vs plugins --help

Summary
When executing sfdx plugins command with the help flag, the output differs depending on whether I use the short flag -h vs the long flag --help.
Steps To Reproduce:
sfdx plugins -h

Expected result
The output produced by plugins -h should be the same as plugins --help, I should not be surprised by different results for using the short flag vs long flag.
sfdx plugins --help
list installed plugins

USAGE
  $ sfdx plugins

OPTIONS
  --core  show core plugins

EXAMPLE
  $ sfdx plugins

COMMANDS
  plugins:generate   create a new sfdx-cli plugin
  plugins:install    installs a plugin into the CLI
  plugins:link       links a plugin into the CLI for development
  plugins:uninstall  removes a plugin from the CLI
  plugins:update     update installed plugins

TOPICS
  Run help for each topic below to view subcommands

  plugins:trust  pack an npm package and produce a tgz file along with a corresponding digital signature

Actual result
Displays a short version of the help, without the COMMANDS and TOPICS sections
sfdx plugins -h
list installed plugins

USAGE
  $ sfdx plugins

OPTIONS
  --core  show core plugins

EXAMPLE
  $ sfdx plugins

Additional information
sfdx --version
sfdx-cli/7.3.0-94ecf2d5ee linux-x64 node-v10.15.3

sfdx plugins --core
@oclif/plugin-commands 1.2.2 (core)
@oclif/plugin-help 2.1.6 (core)
@oclif/plugin-not-found 1.2.2 (core)
@oclif/plugin-plugins 1.7.8 (core)
@oclif/plugin-update 1.3.9 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.0.2 (core)
analytics 1.1.2 (core)
generator 1.1.0 (core)
salesforcedx 45.10.1 (core)
├─ force-language-services 45.10.0 (core)
└─ salesforce-alm 45.13.0 (core)

sfdx-cli 7.3.0 (core)

OS: Ubuntu 18.04.2 LTS

Thank you for the feedback, we have this on our backlog to fix. I'll close this bug once it is done

This has since been fixed.


Add animated plots for StaticGeodesicsPlotter.

Fixes parts of #36

@shreyasbapat
Demo:

Now that #157 has finally been merged, this PR can be completed. I will resolve the conflicts and push the changes shortly.

Correct! I very much look forward to this!

Hello @Varunvaruns9! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/einsteinpy/plotting/geodesics_static.py:

Line 174:1: W293 blank line contains whitespace

@shreyasbapat Done :)

This will now need some significant change and a rebase :)

This one has been fixed.


Adding source manipulation feature for Camgear Class and Bug Fixes.

Brief Summary:
This pull request adds source manipulation feature for Camgear Class similar to PiGear Class. It supports various tweak parameters and attributes available with OpenCV's VideoCapture class. These parameters can be applied to stream when it's being initiated through **options parameter of CamGear Class.
Key Features:

[x] Implemented easy Source Manuplation in  CamGear
[x] Fixed Major Bugs
[x] Improved Error Handling
[x] Fixed Readme Context
[x] Added additional flags for Camgear class for time delay and logging
[ ] Robustly Tested

Example:
The **option sets all properties supported by OpenCV's VideoCapture Class to the input video stream. These attribute provides the flexibity to manuplate input webcam video stream directly. Parameters can be passed using this **option, allows you to pass keyworded variable length of arguments to CamGear Class as follows:
options = {"CAP_PROP_FRAME_WIDTH":320, "CAP_PROP_FRAME_HEIGHT":240, "CAP_PROP_FRAME_FPS":20} # define tweak parameters

All supported parameters are listed here.
and then can be assigned to stream(on the go) as follows
stream = CamGear(source=1, time_delay=2, logging=True, **options).start() # To open video stream on first index(i.e. 0) device

Important Notes:
Remember, Not all parameters are supported by all cameras which is one of the most troublesome part of the OpenCV library. Each camera type, from android cameras to USB cameras to professional ones offer a different interface to modify its parameters. Therefore there are many branches in OpenCV code to support as many of them, but of course not all possible devices are covered and thereby works.
To check parameter values supported by your webcam, you can hook your camera to your Linux machine and use command v4l2-ctl -d 0 --list-formats-ext (where 0 is index of given camera) to list the supported video parameters and their values.
Solves :
#2

@pshinza Hello,
Kindly test Camgear_experimental Branch as follows:
  sudo pip uninstall vigear
  git clone https://github.com/abhiTronix/vidgear.git
  cd vidgear
  git checkout Camgear_experimental
  sudo pip install .

and check parameter values supported by your webcam, you can hook your camera to your Linux machine and use command v4l2-ctl -d 0 --list-formats-ext (where 0 is index of given camera) to list the supported video parameters and their values. And if 1920x1080 is supported then, Test this algorithm:
# import libraries
from vidgear.gears import CamGear
import cv2

options = {"CAP_PROP_FRAME_WIDTH ":1920, "CAP_PROP_FRAME_HEIGHT":1080} # define tweak parameters

stream = CamGear(source=0, time_delay=2, logging=True, **options).start() # To open video stream on first index(i.e. 0) device

# infinite loop
while True:

	frame = stream.read()
	# read frames

	# check if frame is None
	if frame is None:
		#if True break the infinite loop
		break

	# do something with frame here

	cv2.imshow("Output Frame", frame)
	# Show output window

	key = cv2.waitKey(1) & 0xFF
	# check for 'q' key-press
	if key == ord("q"):
		#if 'q' key-pressed break out
		break

cv2.destroyAllWindows()
# close output window

stream.stop()

Then revert. I'm waiting for your response.


Cool stuff man, does it support low profile kailh keyswitch?

Thank you! Yes it support.
But, keep in mind that spacing between switches is 19.1mm this is MX spacing. This is suitable for most keycaps (lowprofile too). But, if you are going to use MBK keycaps (17.5x16.5mm), then there will be an increased gap between them.
I have a plan make new pcb with spacing for MBK keycaps, but now don't have time for that.


Isolate @nestjs/testing dependency

This PR:
(This is heavily inspired by https://github.com/safe-global/safe-gelato-relay-service/pull/99, thanks to @fmrsabino)

Extracts TestAppProvider to a different file (under src/tests)
This change removes the direct reference from app.provider.ts (used in production code) to @nestjs/testing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 17 (64.71%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 92.174%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/contracts/tests/get-contract.e2e-spec.ts
0
1
0.0%

src/routes/data-decode/tests/data-decode.e2e-spec.ts
0
1
0.0%

src/routes/health/tests/get-health.e2e-spec.ts
0
1
0.0%

src/routes/safe-apps/tests/get-safe-apps.e2e-spec.ts
0
1
0.0%

src/tests/test-app.provider.ts
9
11
81.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4209

Relevant Lines:
4461

💛  - Coveralls


ValueError: Calling Model.fit in graph mode is not supported when the Model instance was constructed with eager mode enabled. Please construct your Model instance in graph mode or call Model.fit with eager mode enabled.

System information

Windows 10
TensorFlow version 2.4.1
Keras 2.4.1
Python version: 3.7
CUDA/cuDNN version: v11.2/11.2
GPU model and memory: MSI geforce rtx 3060 12GB

Describe the current behavior
The program fails to start.
Describe the expected behavior
It should work.
Standalone code to reproduce the issue
I have deep Q learning class:
class DQNAgent:
    def __init__(self):
        self.model = self.create_model()
        self.target_model = self.create_model()
        self.target_model.set_weights(self.model.get_weights())

        self.replay_memory = deque(maxlen=REPLAY_MEMORY_SIZE)

        self.tensorboard = ModifiedTensorBoard(log_dir=f"logs/{MODEL_NAME}-{int(time.time())}")

        self.target_update_counter = 0
        self.graph = tf.compat.v1.get_default_graph()

        self.terminate = False
        self.last_log_episode = 0
        self.training_initialized = False

    def create_model(self):
        base_model = Xception(weights=None, include_top=False, input_shape=(IM_HEIGHT, IM_WIDTH, 3))

        x = base_model.output
        x = GlobalAveragePooling2D()(x)

        predictions = Dense(3, activation='linear')(x)
        model = Model(inputs=base_model.input, outputs=predictions)
        model.compile(loss='mse', optimizer=Adam(lr=0.001), metrics=['accuracy'])
        return model

    def update_replay_memory(self, transition):
        # transition = (current_state, action, reward, new_state, done)
        self.replay_memory.append(transition)

    def train(self):
        if len(self.replay_memory) < MIN_REPLAY_MEMORY_SIZE:
            return

        minibatch = random.sample(self.replay_memory, MINIBATCH_SIZE)

        current_states = np.array([transition[0] for transition in minibatch])/255
        with self.graph.as_default():
            current_qs_list = self.model.predict(current_states, PREDICTION_BATCH_SIZE)

        new_current_states = np.array([transition[3] for transition in minibatch]) / 255
        with self.graph.as_default():
            future_qs_list = self.target_model.predict(new_current_states, PREDICTION_BATCH_SIZE)

        X = []
        y = []

        # we want to update q table only when there exists a future state. If a car crashed just save the last q values
        for index, (current_state, action, reward, new_state, done) in enumerate(minibatch):
            if not done:
                max_future_q = np.max(future_qs_list[index])
                new_q = reward + DISCOUNT * max_future_q
            else:
                new_q = reward

            current_qs = current_qs_list[index]
            current_qs[action] = new_q

            X.append(current_state)
            y.append(current_qs)

        log_this_step = False
        if self.tensorboard.step > self.last_logged_episode:
            log_this_step = True
            self.last_logged_episode = self.tensorboard.step

        with self.graph.as_default():
            self.model.fit(np.array(X)/255, np.array(y), batch_size=TRAINING_BATCH_SIZE, verbose=0, shuffle=False, callbacks=[self.tensorboard] if log_this_step else None)

        if log_this_step:
            self.target_update_counter += 1

        if self.target_update_counter > UPDATE_TARGET_EVERY:
            self.target_model.set_weights(self.model.get_weights())
            self.target_update_counter = 0

    def get_qs(self, state):
        return self.model.predict(np.array(state).reshape(-1, *state.shape)/255)[0]

    def train_in_loop(self):
        X = np.random.uniform(size=(1, IM_HEIGHT, IM_WIDTH, 3)).astype(np.float32)
        y = np.random.uniform(size=(1, 3)).astype(np.float32)

        with self.graph.as_default():
            self.model.fit(X, y, verbose=False, batch_size=1)

        self.training_initialized = True

        while True:
            if self.terminate:
                return
            self.train()
            time.sleep(0.01)

When I run the program:
2021-03-21 18:50:05.877519: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
Using TensorFlow backend.
WARNING:tensorflow:From C:/Users/Michał/Desktop/Magisterka/Project/Carla_0.9.11_env/sentex_carla/sentex_full_tut.py:291: The name tf.keras.backend.set_session is deprecated. Please use tf.compat.v1.keras.backend.set_session instead.

2021-03-21 18:50:07.803967: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-03-21 18:50:07.806461: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library nvcuda.dll
2021-03-21 18:50:07.827618: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1720] Found device 0 with properties:
pciBusID: 0000:01:00.0 name: GeForce RTX 3060 computeCapability: 8.6
coreClock: 1.837GHz coreCount: 28 deviceMemorySize: 12.00GiB deviceMemoryBandwidth: 335.32GiB/s
2021-03-21 18:50:07.827846: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2021-03-21 18:50:07.834034: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2021-03-21 18:50:07.834164: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2021-03-21 18:50:07.837381: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2021-03-21 18:50:07.838887: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2021-03-21 18:50:07.843668: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2021-03-21 18:50:07.846965: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2021-03-21 18:50:07.848560: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2021-03-21 18:50:07.848732: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1862] Adding visible gpu devices: 0
2021-03-21 18:50:08.633848: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1261] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-03-21 18:50:08.634021: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1267]      0
2021-03-21 18:50:08.634128: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1280] 0:   N
2021-03-21 18:50:08.634412: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1406] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 4915 MB memory) -> physical GPU (device: 0, name: GeForce RTX 3060, pci bus id: 0000:01:00.0, compute capability: 8.6)
2021-03-21 18:50:08.635416: I tensorflow/compiler/jit/xla_gpu_device.cc:99] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-03-21 18:50:08.660884: I tensorflow/compiler/jit/xla_cpu_device.cc:41] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-03-21 18:50:08.661049: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1720] Found device 0 with properties:
pciBusID: 0000:01:00.0 name: GeForce RTX 3060 computeCapability: 8.6
coreClock: 1.837GHz coreCount: 28 deviceMemorySize: 12.00GiB deviceMemoryBandwidth: 335.32GiB/s
2021-03-21 18:50:08.661286: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2021-03-21 18:50:08.661415: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2021-03-21 18:50:08.661545: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2021-03-21 18:50:08.661688: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2021-03-21 18:50:08.662177: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2021-03-21 18:50:08.662341: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2021-03-21 18:50:08.662515: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2021-03-21 18:50:08.662726: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2021-03-21 18:50:08.663120: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1862] Adding visible gpu devices: 0
2021-03-21 18:50:08.663570: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1720] Found device 0 with properties:
pciBusID: 0000:01:00.0 name: GeForce RTX 3060 computeCapability: 8.6
coreClock: 1.837GHz coreCount: 28 deviceMemorySize: 12.00GiB deviceMemoryBandwidth: 335.32GiB/s
2021-03-21 18:50:08.663900: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2021-03-21 18:50:08.664065: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2021-03-21 18:50:08.664222: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2021-03-21 18:50:08.664385: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2021-03-21 18:50:08.664546: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2021-03-21 18:50:08.664710: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2021-03-21 18:50:08.664866: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2021-03-21 18:50:08.665026: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2021-03-21 18:50:08.665225: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1862] Adding visible gpu devices: 0
2021-03-21 18:50:08.665395: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1261] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-03-21 18:50:08.665567: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1267]      0
2021-03-21 18:50:08.665683: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1280] 0:   N
2021-03-21 18:50:08.665901: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1406] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 4915 MB memory) -> physical GPU (device: 0, name: GeForce RTX 3060, pci bus id: 0000:01:00.0, compute capability: 8.6)
2021-03-21 18:50:08.666224: I tensorflow/compiler/jit/xla_gpu_device.cc:99] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-03-21 18:50:10.410494: I tensorflow/core/profiler/lib/profiler_session.cc:136] Profiler session initializing.
2021-03-21 18:50:10.410594: I tensorflow/core/profiler/lib/profiler_session.cc:155] Profiler session started.
2021-03-21 18:50:10.410692: I tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1365] Profiler found 1 GPUs
2021-03-21 18:50:10.411657: W tensorflow/stream_executor/platform/default/dso_loader.cc:60] Could not load dynamic library 'cupti64_110.dll'; dlerror: cupti64_110.dll not found
2021-03-21 18:50:10.412499: W tensorflow/stream_executor/platform/default/dso_loader.cc:60] Could not load dynamic library 'cupti.dll'; dlerror: cupti.dll not found
2021-03-21 18:50:10.412642: E tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1415] function cupti_interface_->Subscribe( &subscriber_, (CUpti_CallbackFunc)ApiCallback, this)failed with error CUPTI could not be loaded or symbol could not be found.
2021-03-21 18:50:10.412928: I tensorflow/core/profiler/lib/profiler_session.cc:172] Profiler session tear down.
2021-03-21 18:50:10.413062: E tensorflow/core/profiler/internal/gpu/cupti_tracer.cc:1496] function cupti_interface_->Finalize()failed with error CUPTI could not be loaded or symbol could not be found.
Exception in thread Thread-1:
Traceback (most recent call last):
  File "C:\Users\Michał\AppData\Local\Programs\Python\Python37\lib\threading.py", line 926, in _bootstrap_inner
    self.run()
  File "C:\Users\Michał\AppData\Local\Programs\Python\Python37\lib\threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "C:/Users/Michał/Desktop/Magisterka/Project/Carla_0.9.11_env/sentex_carla/sentex_full_tut.py", line 268, in train_in_loop
    self.model.fit(X, y, verbose=False, batch_size=1)
  File "C:\Users\Michał\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\engine\training.py", line 1031, in fit
    version_utils.disallow_legacy_graph('Model', 'fit')
  File "C:\Users\Michał\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\utils\version_utils.py", line 122, in disallow_legacy_graph
    raise ValueError(error_msg)
ValueError: Calling `Model.fit` in graph mode is not supported when the `Model` instance was constructed with eager mode enabled. Please construct your `Model` instance in graph mode or call `Model.fit` with eager mode enabled.

I have tried adding to model.compile an argument: , run_eagerly equals: True, None, False - the result was still the same.
The whole code is here: https://pastebin.pl/view/10e9e350
Due to the fact that I am working with the Carla environment, it will be hard to reproduce exactly my setup.
The code is from: sentex
For him that code worked perfectly. I guess that he was using a significantly older version of TensorFlow., so the error is most likely because I am using 2.4.1 version of TF.

@Michal-Kolomanski
I ran the code shared by you and do not see any error as reported, please refer to  the gist here.

@Michal-Kolomanski
I ran the code shared by you and do not see any error as reported, please refer to the gist here.

I prepared a notebook with exactly the same error: colab.

@Michal-Kolomanski
I ran the colab but face a different error, please find the gist here.

@Michal-Kolomanski
I ran the colab but face a different error, please find the gist here.

Please install:
!pip install tensorflow==2.4.1
!pip install keras==2.4.1
It should solve your problem.

I am able to replicate the issue on tf 2.3,2.4 and nightly, please find the gist here

@Michal-Kolomanski I have looked at your code. There is a mix of graph mode and eager mode (and by default TF2.x is eager). Error is mainly due to mix of both modes. We don't support debugging of long code. I think this is more suited for Stackoveflow as there is a larger community who support this kind of questions.
GitHub is mainly for bugs and performance related issues. Thanks!

@Michal-Kolomanski I have looked at your code. There is a mix of graph mode and eager mode (and by default TF2.x is eager). Error is mainly due to mix of both modes. We don't support debugging of long code. I think this is more suited for Stackoveflow as there is a larger community who support this kind of questions.
GitHub is mainly for bugs and performance related issues. Thanks!

Now I am 100% sure that the issue is due to using a newer version of TF. Thank you for the response.


sourcemap contains js files

Hey, I'm using this together with your jsx-ts-loader plugin.
Also I need sourcemaps, and I used to use the 'sourceRoot' in the sourcemap file before.
I just read here how I can do that with webpack, and it's working, but now I see the content of my sourcefiles are actually the compiled js, not typescript. Any idea what I'm doing wrong or if this is a bug?
Here's my setup:
// webpack.config.js
var webpack = require('webpack');

module.exports = {
    entry: './init.ts',
    output: {
        filename: '../builds/html.bundle.js'
    },
    resolve: {
        extensions: ['', '.ts', '.webpack.js', '.web.js', '.js']
    },
    module: {
        loaders: [
            { test: /\.ts$/, loader: 'ts-loader!ts-jsx-loader' }
        ]
    },
    /*devtool: 'source-map',*/
    plugins: [
        new webpack.SourceMapDevToolPlugin(
            '[file].map', null,
            "../src/modules/html/[resource-path]", "../src/modules/html/[resource-path]")
    ]
};

and the abbriviated sourcemap file:
  "sources": [
    "../src/modules/html/webpack/bootstrap 1c9252c83a8886ca73cb",
    "../src/modules/html/./init.ts",
    "../src/modules/html/./src/UnsortedList.ts"
  ],
  "names": [],
  "mappings": ";AAAA;AACA;;AAEA;[...]ACA",
  "file": "../_builds/dacore.html.bundle.js",
  "sourcesContent": [
    "[..webpacksourcehere..]**/",
    "[..not_a_class_file...]",
    "[..here comes output from the TS compiler! --->] var  __extends = this.__extends || function (d, b) {\r\n    for (var p [.....]**/"
  ],
  "sourceRoot": ""

Make sure you've set sourceMap to true in your tsconfig.json file. If that still doesn't work I'll see if I can duplicate.
On a side note, just before you posted this I reached out to you on twitter. Wondering about your thoughts on feature parity between this and other TS loaders.

I did test this and it works fine as long as you have specified a tsconfig.json file and turned sourcemaps on.
I'm going to close since I don't believe there is an issue but if you still have problems feel free to reopen.

hey, sorry for the late reply. I had never heard of tsconfig.json yet, it works now. tnx!

Will this also work if the ts configuration is inside the webpack configuration?
 ...
 module: {
      loaders: [
           // all files with a `.ts` or `.tsx` extension will be handled by `ts-loader`
          { test: /\.tsx?$/, loader: 'ts-loader' }
          ]
    },
    ts: {
        // configures the ts compiler:
        "compilerOptions": {
            "target": "es5",
            "sourceMap": true,
            "jsx": "react",
            "experimentalDecorators": true
         },
         "exclude": [
             "node_modules" // add other exclusions for the ts compiler.
            ]
         },...


[New Feat] No Change Comment

Snapshot diff report

File name
Image

There is no screenshot change exist in this pull request !

There is no screenshot change exist in this pull request !

There is no screenshot change exist in this pull request !

Snapshot diff report
There is no screenshot change exist in this pull request !


The right part of the settings editor is always opened scrolled all the way down

cmd+,
The right side of the settings editor is scrolled all the way down, regardless of the previous scroll position
I think it doesn't always happen but I get into a state where it happens consistently

Fixed at some point


Create Apply as a mentor view

Is your feature request related to a problem? Please describe.

Need to develop the "apply as a mentor view" on the admin dashboard.

Describe the solution you'd like

Create a dummy UI adhering to the given view on the admin wireframes.

Additional context

This is the view that needs to be developed, a dummy form would suffice.
For additional details, please follow this link to the wireframes thread.

@Gimhan-minion can i take this one?

@MilePaor Yeah if you can submit it before October 20th it's fine. :+1:

Hi @MilePaor Actually we've changed the wireframes now. This isn't the requirement at the moment. I couldn't update the issue and sorry for that. I've already created the new one. But you can contribute to more issues on our repository.
(Join the discussion for more information):hugs:
SEF Hive:- https://sef.discourse.group/


Fix links from groupby.py.

"See Also" links from groupby.py are broken.

Codecov Report

Merging #486 into master will decrease coverage by 17.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #486       +/-   ##
===========================================
- Coverage   93.61%   75.95%   -17.66%
===========================================
  Files          28       28
  Lines        3756     3756
===========================================
- Hits         3516     2853      -663
- Misses        240      903      +663

Impacted Files
Coverage Δ

databricks/koalas/groupby.py
71.56% <ø> (-26.48%)
:arrow_down:

databricks/koalas/plot.py
22.4% <0%> (-71.37%)
:arrow_down:

databricks/koalas/testing/utils.py
28.93% <0%> (-48.43%)
:arrow_down:

databricks/koalas/strings.py
52.94% <0%> (-43.14%)
:arrow_down:

databricks/koalas/exceptions.py
44.44% <0%> (-36.12%)
:arrow_down:

databricks/koalas/missing/__init__.py
69.23% <0%> (-30.77%)
:arrow_down:

databricks/koalas/indexes.py
61.29% <0%> (-29.04%)
:arrow_down:

databricks/koalas/namespace.py
62.44% <0%> (-27.43%)
:arrow_down:

databricks/koalas/datetimes.py
72.46% <0%> (-20.29%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e286b79...21d0600. Read the comment docs.


works in Jupyter Notebook but not in Jupyter Lab

OS: Arch Linux
Julia version 1.7.0
Jupyter Lab version 3.2.4
I've added the IJulia package in Julia as usual.
Running jupyter notebook from the terminal, choosing the Julia kernel, and doing stuff works totally fine.
Running jupyter lab from the terminal, choosing the Julia kernel, it says "connecting" for a while and then "unknown". Trying to run something in a cell does nothing. If I try restarting the kernel it just hangs on "restarting".
Python and SageMath work fine in Jupyter Lab, it's just Julia that's failing.
If there's a log or error message somewhere that I should post then tell me how and I'll do it.

What's your jupyter_server version? For me, yesterday's 1.13 release of jupyter_server broke the IJulia kernels. Rolling back to jupyter_server 1.12.1 fixed the problem. Perhaps caused by https://github.com/jupyter-server/jupyter_server/pull/628?

Yeah it's 1.13. Looks like the issue has been raised here https://github.com/jupyter-server/jupyter_server/issues/633.

This has now been fixed with jupyter-server 1.13.1.


Document How to Report Conformance Test Results

What would you like to be added:
A standard process for reporting conformance results, similar to what already exists for upstream Kubernetes https://github.com/cncf/k8s-conformance. After chatting with @hh about how this works in upstream, there are a few details that may need some tweaking for our use cases (please correct me if I misunderstood something).

Upstream conformance is all or nothing, they don't have the same concept of conformance profiles
Upstream conformance is per minor version, at least initially we may want to track conformance per patch version

As a general note, each upstream conformance report includes:

A product.yaml file that describes the implementation, and version of the implementation that was used (example)
A readme that provides a step by step process describing how conformance tests were run to get the passing result (example)
A test log that shows conformance tests passing (example)

In addition to the above, we'll likely want some ability to describe partial conformance, or at a minimum, to indicate the extended features that conformance tests pass for with the specified implementation.
This may eventually transition to CNCF control, but it likely makes sense to start this structure in this repo.
Why this is needed:
As we get an increasing number of implementations of this API, it is more important than ever to ensure that each provides a consistent experience. In the future we'll likely want to translate the reports here into an easy to read format on https://gateway-api.sigs.k8s.io/implementations/.

/help

/assign

/cc

/unassign

/remove-lifecycle stale

#1709 is now covering the scope of this issue and adding reporting of conformance test results.


Stop using sha256sums.txt and sha256sums.txt.asc

Mike Perry has told me that Tor Browser is phasing out the use of sha256sums.txt in favor of signing individual binaries.
Right now torbrowser-launcher downloads sha256sums.txt and sha256sums.txt.asc and verifies it, and then calculates the sha256sum of the binary in order to verify that there wasn't an attack during the download.
We need to change it so that it just downloads the binary (e.g. tor-browser-linux32-4.5_en-US.tar.xz) and its signature (e.g. tor-browser-linux32-4.5_en-US.tar.xz.asc) and verifies that directly.

Is there any upstream ticket about this?
This is bad. Breaks Tor Browser downloaders and worsens security.
sha256sum helped to authenticate filenames... Because...
GPG signatures do not authenticate filenames:
https://trac.torproject.org/projects/tor/ticket/2340

Mike wrote:

We recently started signing our windows exes using a digicert
authenticode token in TBB since 4.5a4. When we released 4.5-stable, we
noticed there was still some confusion in our Windows users who are
still using sha256sums.txt to verify their packages. Because the
sha256sums.txt file contains the build result exe sha256sums, and not
the sha256sums of the exes after signing them with our token, users were
confused by the resulting sha256sum mismatch.
We had attempted to update our signature verification documentation to
describe this
(https://www.torproject.org/docs/verifying-signatures.html.en#BuildVerification)
but it seems that people are just assuming that things still work the
old way.
This has led us to decide to rename the sha256sums.txt file and
associated detached signatures to something like
'sha256sums-presigned-build.txt' in the hopes that it will clue people
in to the fact that the sha256sums in it may not match what they just
downloaded. Here's our ticket where we brainstormed some ideas before
arriving at that one:
https://trac.torproject.org/projects/tor/ticket/15864

I don't think this was a necessary / good change. sha256sums.txt and
sha256sums.txt.asc were not actually deprecated. Now with direct
verification only, it got actually less secure. (See my "gpg does not
verify file names' argument above.)

I know that the sha256sums.txt.asc isn't deprecated yet, but it seems wise to heed Mike's advice here so everyone doesn't get false positive MITM warnings one day.
Downgrade attackers are mitigated here because TBL detects the version that's installed before running it. If it detects an earlier version installed, it will just try to update again: https://github.com/micahflee/torbrowser-launcher/blob/master/torbrowser_launcher/launcher.py#L160
It's also somewhat mitigated by the fact that Tor Browser auto-updates itself. So I agree it's not ideal, but it seems better than risking everything breaking in the future.


mat-datepicker

Bug, feature request, or proposal:
feature
What is the expected behavior?
I want to handle each and every event i.e. clicking on the datepicker's month selection and selecting a month should triggering an event like (change) or (click)
What is the current behavior?
Event that gets fired is after i select the day and i have a whole project running on ng --version @1.7.4 so i cannot upgrade it to @6.0.0 because for this version we can use (yearSelected) or (monthSelected) output bindings
What are the steps to reproduce?
Normal date picker with startView="year"

What is the use-case or motivation for changing an existing behavior?
I wanted a month and year only date-picker [NOTE: Cannot upgrade ng to latest version 6.0.0, using 1.7.4]
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5
CLI = 1.7.4
Material = 5.2.4
OS = Linux, UBUNTU 16.04
TypeScript = 2.8.1
Is there anything else we should know?
Cannot upgrade to angular 6.0.0 because my whole project has been setup in angular 5 CLI version = 1.7.4

Yeah i checked and Angular version: 5.2.9

Angular and all its official packages follow semvar so new features are only added to major releases. I doubt they will backpatch this feature for you so your best bet is to upgrade your cli version.

Can't you use ng update @angular/cli? This should create a new Angular CLI config file with all of your config options.

New features are only added in new minors / majors and aren't backported unless there's a major browser change or security fix necessary.
Updating from 5 to 6 shouldn't be huge undertaking, check out https://update.angular.io/


the pretrained model is an invalid file

TypeError: invalid file: PosixPath('checkpoint_49.pth.tar')
how to solve this problem?

Would you mind to provide more information?

snapshot = torch.load(snapshot,map_location='cpu')
I try load the pretrained model downloaded from the google cloud you provided ,but it does not work

Would you mind to provide how do you place the snapshot file and provide a link to this code"snapshot = torch.load(snapshot,map_location='cpu')"?

I run the san_eval.py on CPU,  I modified the
snapshot = torch.load(snapshot)
to
snapshot = torch.load(snapshot,map_location='cpu')

Did you exactly run "python san_eval.py --image ./cache_data/cache/test_1.jpg --model ./snapshots/SAN_300W_GTB_itn_cpm_3_50_sigma4_128x128x8/checkpoint_49.pth.tar --face 819.27 432.15 971.70 575.87 --save_path temp_1.png"?

yes , I  put the args into the argparse.ArgumentParser

I just add the CPU support for san_eval.py, and tried, but I did not find your issues.
Please make sure "checkpoint_49.pth.tar" is at snapshots/SAN_300W_GTB_itn_cpm_3_50_sigma4_128x128x8

I just replace the san_eval.py you modified ,it still does not work ,the problem is all the same

Can you just share a screenshot of your error?

It might be caused by the PyThon version. I use Python 3.6 to save the model, but you are using Python 3.5. I also have this problem sometimes when load a model saved in different Python version. Would you mind to try Python 3.6?

tks, I have run it on Python3.6 and it really works.


XP-248 - Use structlog for logging

References
Resolves XP-248
Summary
Replaces current logging mechanism with structlog

@tanertopal Please use full github template for every pull request.

Closing as the branch name ist not accepted. Will open another PR.


Limit search results to 500

When trying to use the search box, there was a significant delay between each char typed for the first couple of chars. Analyzing the time spent in Safari showed that when I typed 's' which had 3256 matches, 98% of the time was spent in style processing, i.e. rendering all of the results in the search results box. The only way to improve this is to reduce the number of entries we ever try to add.
Setting maxResults to 500 makes the search responsive and still delivers more results than is useful.

Originally, I limited search results to 20, but there were complaints about
not seeing the rest. 500 is an order greater, so perhaps is a better idea.
50 would be quicker.
Another approach is to start filtering after a small number of characters,
eg 2. This will also reduce filtered candidates.
Before making the change I just want to document the reason 'unlimited' was
chosen
On Mon, 4 Dec 2023, 17:09 Donald Hunter, @.***> wrote:

When trying to use the search box, there was a significant delay between
each char typed for the first couple of chars. Analyzing the time spent in
Safari showed that when I typed 's' which had 3256 matches, 98% of the time
was spent in style processing, i.e. rendering all of the results in the
search results box. The only way to improve this is to reduce the number of
entries we ever try to add.
Setting maxResults to 500 makes the search responsive and still delivers
more results than is useful.
You can view, comment on, or merge this pull request online at:
https://github.com/Raku/doc-website/pull/323
Commit Summary

cd0dcde
https://github.com/Raku/doc-website/pull/323/commits/cd0dcde00ef66c68498c39007fceb4bf0dada313
Limit search results to 500

File Changes
(1 file https://github.com/Raku/doc-website/pull/323/files)

M Website/plugins/options-search/options-search.js
https://github.com/Raku/doc-website/pull/323/files#diff-8393dc27cf07fe854afd4bd261cf1aef4c20dde41d21544c776bdbb750b924fd
(4)

Patch Links:

https://github.com/Raku/doc-website/pull/323.patch
https://github.com/Raku/doc-website/pull/323.diff

—
Reply to this email directly, view it on GitHub
https://github.com/Raku/doc-website/pull/323, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACYZHFJGGV2D56QS5TWQO3YHX7VVAVCNFSM6AAAAABAGKGUR2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDIMZTGQ3TMNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Agree there's no right answer for where to truncate results and maybe 50 to 100 is a reasonable limit that is responsive. I picked 500 because it was responsive enough while also high enough it's not going to cut out anything but heading and index matches. Maybe just need to inform the user when the results are truncated.
I thought about setting threshold: 2 but it's legitimate to want to search for single character things like operators. e.g. + which has 41 matches.

More complex would be to combine the chars and only send a request after an idle time after typing (picking that threshold is probably even more finicky)

Yes, I also thought about this - the only problem is that it's also not trivial to make that look clever, rather than "why is it doing nothing for (e.g) 2 seconds"... perhaps it would require a little animation or something... but then we aren't much like frontend guys.

More complex would be to combine the chars and only send a request after an idle time after typing (picking that threshold is probably even more finicky)

Yes, I also thought about this - the only problem is that it's also not trivial to make that look clever, rather than "why is it doing nothing for (e.g) 2 seconds"... perhaps it would require a little animation or something... but then we aren't much like frontend guys.

I don't think an idle timer would help since the browser freeze will still happen while it renders the v large result set. It might interrupt the typing less often but the stall would still happen and interrupt whatever you try to do.

don't think an idle timer would help since the browser freeze will still happen while it renders the v large result set. It might interrupt the typing less often but the stall would still happen and interrupt whatever you try to do.

I think it is okay if the browser freezes while searching, IF the search is about something you actually want. If you want to search for the letter a, let it freeze really. The idle is to avoid always searching for partial input that has much more results than what one actually wanted to search for.

Is there a reason why limiting the number of search results is a bad idea (irrespective of other ideas that could also be nice)?
If not, can we then just use for the simple solution for now?

Lets go with the simpler solution for the time being.


Feature Request: Add ability to share entire folders with others

To be specific, I'm requesting the ability to share an entire folder and all files contained within with others. This would be useful if, for example, a team wants to work on multiple different files within the same repo.

Thanks for the feedback! Closing as a duplicate of #211 and if you're interested, the team is working on a RFC (#231) that will allow participants to navigate among all the tabs a host has opened. If you have suggestions or comments, please do not hesitate to share them in that RFC. 🙇

It's also worth noting that we definitely want to do this, but it's non-trivial. Tons of functionality assumes that files are local, but to support this we'll need to fetch files via RPC. We've decided to focus on the easier to implement features first that provide more value, but I totally get that it would be better to have full access to the host's project folders.


about setting weights for M_{ii} based on descriptor similarity

Hello there,
Many thanks for open-soure this very nice work. I really enjoy reading your papers.
I am wondering whether the current version of CLIPPER in this repository supports setting weights for M_{ii} based on descriptor similarity instead of setting as "1". I try to simply add such weights (range: [0,1]) by the following code (but it works pretty bad, resulting in many repeated items in the clique):

void CLIPPER::scorePairwiseConsistency_withweight(const invariants::Data& D1,const invariants::Data& D2,const std::vector<double>& weights, const Association& A)
{
  if (A.size() == 0) A_ = utils::createAllToAll(D1.cols(), D2.cols());
  else A_ = A;

  const size_t m = A_.rows();

  Eigen::MatrixXd M = Eigen::MatrixXd::Zero(m, m);

  #pragma omp parallel for shared(A_, D1, D2, M_, C_) if(parallelize_)
  for (size_t k=0; k<m*(m-1)/2; ++k) {
    size_t i, j; std::tie(i, j) = utils::k2ij(k, m);

    if (A_(i,0) == A_(j,0) || A_(i,1) == A_(j,1)) {
      // violates distinctness constraint
      continue;
    }

  //
  // Evaluate the consistency of geometric invariants associated with ei, ej
  //

  // points to extract invariant from in D1
  const auto& d1i = D1.col(A_(i,0));
  const auto& d1j = D1.col(A_(j,0));

  // points to extract invariant from in D2
  const auto& d2i = D2.col(A_(i,1));
  const auto& d2j = D2.col(A_(j,1));

  const double scr = (*invariant_)(d1i, d1j, d2i, d2j);
  if (scr > params_.affinityeps) { // does not violate inconsistency constraint
    M(i,j) = scr;
  }
  }

  //**************** for diagonal weights
  for (int i = 0; i < weights.size(); ++i)
  {
    M(i,i) = weights[i];
    // std::cout<<"weights["<<i<<"] = "<<weights[i]<<std::endl;
  }
 //****************

  // Identity on diagonal is taken care of implicitly in findDenseClique()
  // M += Eigen::MatrixXd::Identity(m, m);

  M_ = M.sparseView();

  C_ = M_;
  C_.coeffs() = 1;
}

int main(int argc, char **argv){
  clipper::invariants::EuclideanDistancePtr invariant =
            std::make_shared<clipper::invariants::EuclideanDistance>(iparams);

  clipper::Params params;
  clipper::CLIPPER clipper(invariant, params);

  //
  // Identify data association
  //

  clipper::Association A = clipper::Association(association_num, 2);
  for (int i = 0; i < association_num; i++) {
    A(i, 0) = i;
    A(i, 1) = i;
  }

  //get model, data, weights
  ...

 clipper.scorePairwiseConsistency_withweight(model, data,weights, A);

  // find the densest clique of the previously constructed consistency graph
  clipper.solve();
}

Could you please give me some suggestions about how to correctly set weights for diagonal weights? Considering such diagonal weights are quite different from non-diagonal weights (EuclideanDistance based in CLIPPER), do we need to scale the diagonal weights to handel such difference?
Thanks and regards,
weixin

hi @Weixin-Ma , thanks for the kind words and your interest in our work.
Currently, the code assumes the diagonal of M is all ones. This was done for efficiency reasons in https://github.com/mit-acl/clipper/pull/5.
In your code you have removed that assumption in the creation of the affinity matrix, but not in the optimization. Check out the changes to findDesnseClique in this commit https://github.com/mit-acl/clipper/pull/5/commits/a899d44a76e101d7b4908ee25a5b445048b8f165#. For example
Eigen::VectorXd u = M * u0;

was changed to
Eigen::VectorXd u = M_.selfadjointView<Eigen::Upper>() * u0 + u0;

where the + u0 was added bc we implicitly assume M should have ones on the diagonal, but the actual implementation of M has zeros on the diagonal.
The other changes in that function have a similar assumption and would need to be changed to support an arbitrary diagonal.
I know @mbpeterson70 has also been interested in encoding self-similarity along the diagonal

HI @plusk01, many thanks for your suggestions.
I tested the old version of clipper before changes added in commit a899d44. It works, while the speed is much slower as you mentionded.
I also interestingly found that such weights seems have limited influence to the final clique. I tired cosine similarity, normalized cosine similarity (among all the diagonal), all 0, all 0.2, all 0.5, and all 1. The clique results are highly consistent, only few associations(1 - 2) among results are different (in my case, missing). Could you please share some insights about the possible reasons according to your experience?
Thanks and regards,
weixin

Hi @Weixin-Ma, it sounds like you're running into something similar to what some of my recent work has found as well. The issue is that if you look at the numerator of the maximum clique optimization (u.T @ M @ u), the diagonal elements actually have a very limited impact on the selected associations. In fact, the impact diminishes as the number of selected inlier associations increases since if you expand the optimization you get: (u_i^2 * m_ii for each inlier i) + (u_i * u_j * m_ij for each inlier i and j, i != j). If there are more than just a few inliers, m_ii plays a very limited role.
We found that taking the weighted geometric mean of the pairwise association similarity score with each point-to-point similarity scores produces much better results. So if you have an association a and b we set each element of the affinity matrix M to (pairwise_affinity_score(a, b)^w * point_similarity_score(a) * point_similarity_score(b))^(1/(w+2))).
Our recent RSS workshop paper goes into more detail and we are planning on releasing code in a couple weeks for this as well!

Hi @mbpeterson70, many thanks for your nice and detailed explanation. I also enjoy reading your RSS workshop paper, which gives me many new insights. Look forward to the future released code.
Hi @plusk01, many thanks again for your quick reply.

@Weixin-Ma thanks a lot! I'll be sure to update this issue when the code is released!


Add virtual network to Terraform configuration

Terraform config set up for eventhub; adding private links to storage accounts. Can't create the event subscription between storage account and event hub; getting a key error. Digging into that error but still making progress.

Related issue:#204


avoid writing jshint ignore in blueprint tests if jshint is not detected

Addresses #117.
This will only output the following line if ember-cli-jshint is detected in the project's add on packages.
/* jshint expr:true */

thanks! 👍


In the image viewer, images should fill to the window's size regardless of image size.

Currently large images will scale down to the window size.  There should be an option for this.

Indeed, this makes sense.
I'll add a checkbox to do this in the options (disabled by default) in the next version.


Improved Tab Accessibility

Fix for #1098
=======
Tabs will now read out two separate times using a screen reader (NVDA):

Tab itself => 'Welcome Tab Button'
Tab close icon => 'Close Welcome Tab Button'

Also significantly refactored the markup for <MDI/> <MultiTabs/> & <TabbedDocument/>
Removed /ui/shell/multiTabs and moved all contents to /ui/shell/mdi/...

Pull Request Test Coverage Report for Build 1469

51 of 58 (87.93%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 56.768%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/app/client/src/ui/shell/mdi/tabBar/tabBarContainer.ts
7
9
77.78%

packages/app/client/src/ui/shell/mdi/tabBar/tabBar.tsx
29
34
85.29%

Totals

Change from base Build 1461:
0.4%

Covered Lines:
4654

Relevant Lines:
7402

💛  - Coveralls


Fix dictation dance in vscode

Fixes bug with dictation dance in VSCode where empty selection caused copy to get whole line and mess things up
Note: implemented in pairing session with @rntz

Might be helpful to note that this also effects several other editors including at least Sublime Text/Merge.
I just ran into the problem with https://github.com/knausj85/knausj_talon/blob/main/text/text_navigation.py today as I had forgotten to turn this off in Sublime Merge — probably worth a bug report if not fixed in this PR.

@nriley this PR didn't fix anything about text_navigation.py so feel free to submit that as a separate issue.

Thanks, filed #917.


Groovy Support

From @soljin on June 29, 2016 21:43
Add groovy because it's great.
Copied from original issue: Microsoft/monaco-languages#4

@jrieken https://github.com/brijeshb42/monaco-ace-tokenizer

If someone doesn't want to use monaco-ace-tokenizer, there is my version of Groovy definition for monaco (it's not perfect though, but it works), any suggestions to make it better are welcome,  https://gist.github.com/Ruminat/42364312e90ba5d71875697ede66990e

Closing since @Ruminat provided a solution.
Will reopen if someone comes up with a PR.


Link to combined TEPs not working

The link to the TEP on the GALK1 target profile page does not work. Currently the links to the TEPs are built on the front-end using teps-service.js, which just uses the gene symbols. This link does not work because the TEP is designed for two targets (GALT and GALK1) instead of a single one and the url is a combination of both names: https://www.thesgc.org/tep/galt-galk1.
Interestingly, the link from the GALT target profile works because the SGC have a redirect for https://www.thesgc.org/tep/galt.
The problem will be more severe for a new TEP that targets KALRN and RAC1 given that the url is https://www.thesgc.org/tep/kalrnrac1 and neither https://www.thesgc.org/tep/kalrn nor https://www.thesgc.org/tep/rac1 works.
One solution for this issue is to explicitly add the urls to teps-service.js. In the interim, @MichaelaEBI has contacted the SGC to see if they could create redirects for the urls that don't work.

The links that should be used for each TEP are the following:

Target
URL
Same as generated by FE?

KALRN
https://www.thesgc.org/tep/kalrnrac1
No

RAC1
https://www.thesgc.org/tep/kalrnrac1
No

ALAS2
https://www.thesgc.org/tep/alas2
Yes

KEAP1
https://www.thesgc.org/tep/keap1
Yes

KLHL20
https://www.thesgc.org/tep/klhl20
Yes

ANO10
https://www.thesgc.org/tep/ano10
Yes

GALT
https://www.thesgc.org/tep/galt-galk1
No, but https://www.thesgc.org/tep/galt works

GALK1
https://www.thesgc.org/tep/galt-galk1
No

MLLT1
https://www.thesgc.org/tep/mllt1
Yes

HCN4
https://www.thesgc.org/tep/hcn4
Yes

NUDT7
https://www.thesgc.org/tep/nudt7
Yes

PARP14
https://www.thesgc.org/tep/parp14
Yes

RIPK2
https://www.thesgc.org/tep/ripk2
Yes

HAO1
https://www.thesgc.org/tep/hao1
Yes

FAM83B
https://www.thesgc.org/tep/fam83b
Yes

LIMK1
https://www.thesgc.org/tep/limk1
Yes

DCLRE1A
https://www.thesgc.org/tep/dclre1a
Yes

DPAGT1
https://www.thesgc.org/tep/dpagt1
Yes

AASS
https://www.thesgc.org/tep/aass
Yes

WNK3
https://www.thesgc.org/tep/wnk3
Yes

HDAC6
https://www.thesgc.org/tep/hdac6
Yes

KDM3B
https://www.thesgc.org/tep/kdm3b
Yes

KDM4D
https://www.thesgc.org/tep/kdm4d
Yes

PHIP
https://www.thesgc.org/tep/phip
Yes

RECQL5
https://www.thesgc.org/tep/recql5
Yes

SETDB1
https://www.thesgc.org/tep/setdb1
Yes

CDK12
https://www.thesgc.org/tep/cdk12
Yes

Thank you @AsierGonzalez. I'll add those links in - pretty straightforward.

SGC has been contacted to see whether they can implement consistent redirection from links with single gene symbols for the two TEPs with 2 proteins.

Thanks @MichaelaEBI! Beyond the possible redirection for TEPs with 2 proteins, we also need to account for the ANO10 issue - the actual link is https://www.thesgc.org/tep/tmem16k as the link to https://www.thesgc.org/tep/ano10 does not work.
Thus, to ensure the appropriate link is available to our users, I have added all links to the TEPs file and will update #458 with a link for @LucaFumis to use in the 19.09 release.

Well spotted @andrewhercules, I missed the issue with ANO10!

FYI, SGC have set up redirects so that the original issue here is solved:

https://www.thesgc.org/tep/galt, https://www.thesgc.org/tep/galk1 and https://www.thesgc.org/tep/galt-galk1 redirect to https://www.thesgc.org/tep/galtgalk1

https://www.thesgc.org/tep/kalrn and https://www.thesgc.org/tep/rac1 redirect to https://www.thesgc.org/tep/kalrnrac1

That's great - thanks for following up @AsierGonzalez! 👍
For the 19.09 release, I have created a new teps-service.js file for @LucaFumis to use and in the file, we also store the link for each TEP.
ENSG00000094631: {
  id: 'ENSG00000094631',
  symbol: 'HDAC6',
  link: 'https://www.thesgc.org/tep/hdac6'
}

No problem, credit to @MichaelaEBI, who had the idea an contacted SGC. I just convey the message :)


Alert users who are beyond a threshold for localStorage usage

Basically if they're nearing the 10MB limit users need to be warned.

Released in v9.3.


Remove logos from landing page

Make sure logos from EPA, NIST, DHS are not in the landing page.

note that when testing this you will need to manually go to https://pass/app/welcome as nothing links to it any more


rte: add PSU commands and documentation

Somehow fixes: https://github.com/Dasharo/osfv-scripts/issues/69

I think in the end we do not need that much logic in this CLI tool, but
the PSU control was definitely missing. We provide a single interface
to control the PSU, no matter what power control (relay, Sonoff) is in
place.

It has been added and exposed to the OSFV via RF libs. The CLI tool
should not know much about the firmware behavior, such as whether
the DUT will power on when PSU is enabled, or not. This is often
configurable, even at runtime, and should be handled in test environment
instead. In many cases, the CLI tool may even ope

Added extra check to warn that the PSU is OFF when we try to use power button, as that was a common mistake:
osfv_cli rte --rte_ip <IP_ADDRESS> pwr on
DUT model retrieved from snipeit: MSI PRO Z690-A DDR5
Using rte command is invasive action, checking first if the device is not used...
Asset 45 is already checked out by you
Power supply state: OFF !
If you wanted to power on the DUT, you need to enable power supply first ("pwr psu on"), pushing the power button is not enough!
Powering on...
Since the asset 45 has been checkout manually by you prior running this script, it will NOT be checked in automatically. Please return the device when work is finished.

I am not sure if full automation instead would be desired here.


Please give us the remaining basic containers

We are container-poor.  This is problematic.  Please give us the remaining basic containers.
They should be easily pulled from the host implementation's c++ stl

We need queue, deque, pqueue, and some or another tree.
Arguably you can skip lists on homebrew implementations but standardization is useful.  Anyone arguing for homebrew implementations of trees as nested containers is missing the point.

It would be nice to have linked and doubly linked list.  These actually can be reasonably implemented as homebrew, but native ones would be ridic faster, and having a shared api would be nice

It would be nice to have multiset and multimap.  It is reasonable to fake these with a set-of-arrays and so on, so, this isn't critical.  It would be a performace benefit at large, though, and probably a defect reduction.

It would be interesting to have trie, but this is probably overboard.  This is properly userland-implementable.  The only reason or interest here would be to have a shared/unified API, but for trie it's not entirely clear that's actually needed or warranted.

It's not obvious to me that it would be a good thing to add all of these. For example, most people can use arrays instead of linked lists and have that be quite performant, since engines have put a huge amount of work into optimizing arrays. And then they don't have to think all the time about which to use. Can you say more about why it makes sense for each of these to be built in?

Can you say more about why it makes sense for each of these to be built in?

negative arrays
faster arrays

I'm 100% on board with this. Every hobby project I write I end up implementing several extra container classes; Counter and DefaultMap (defaultdict in Python) in particular are common ones for me.
Stacks can be done trivially and efficiently with arrays, but queues, dequeues, and pqueues are all relatively bad with plain arrays; good implementations exist but are non-trivial to write. (If you're doing a significant amount of .insert() or .splice() to insert/delete from the front of an array, you're gonna be paying for it...).
The DOM is reinventing multimaps in several places (URLSearchParams, CSSStylePropertyMap, etc), and having a canonical version in JS would be great. At minimum, the usage of them in core platform APIs suggests that they'd be useful to expose for author usage as well.

Maybe add a constructor for iterable array-like instances?

@Mouvedia see https://github.com/keithamus/proposal-array-last for "negative arrays"

@Mouvedia let's discuss that on that proposal's repo then :-)

@ljharb sadly, I know already that it's impossible using Array.
cf keithamus/proposal-array-last#1

I like negative array index calls, but they're a pretty separate issue than this.  I'd like them to not bury this in the discussion please 😄

I really wish you'd stop closing my tickets, dan


UX issues on form submission page

Issue Summary
On a form with more than just a few fields, It is unclear on the form submission page that there is further data to scroll to on the right hand side. This is because the left-right scroll bar is only available at the bottom of the page rather than at the bottom of your screen. Screenshot one below demonstrates the form submission screen (submissions blanked out for privacy reasons).
This means that if you want to view the first form submission in full, to view the fields that are off-screen you need to scroll down to the bottom, then scroll to the right, then scroll back up!
There are also some issue with the appearance of the scroll bar - the placement of "Page 1 of 3" makes it look like a pager rather than a scroll bar. This issue may be alleviated if the scroll bar is fixed at the bottom of a users screen rather than at the bottom of the page, but should be considered when the user is at the bottom of the screen. Screenshot 2, attached, demonstrated this.
Technical details

Wagtail version: 1.6.2.

I got this problem.Here we can create button on table head row to scroll the table horizontally like this.

can i pick up this issue ??

Yep. But remember that the delete button shows in the header also when you select a response.
Please be sure to review the latest code though, the main branch looks different.
Finally, I think we could get far by putting the subtitle span in a new line. I think in general that should be outside the h1 element in the header but that will be a global change.


Use xpdf to parse PDFs

Xpdf parses PDF content better then PDFBox or other parsers (at least in my experience). Might be nice to add this as an option.

Have you experienced PDF parsing issues with HTTP Collector 2.1.0?
Lots of testing was done on PDFs in that version.  The PDFBox library was upgraded to 2.0.0, a version still in development but already significantly better than their previous version.  Also, custom code was added to enhance the PDF parsing to also include XFA (dynamic forms) and support for embedded JBIG2 and jpeg2000 images.  It has also been tested to work fine with OCR of embedded images of supported formats.
If you experience PDF parsing issues, please report them here and we'll certainly consider an alternative parser if we can't provide easy fixes.

Last extensive test was a few years ago, so maybe PDFbox has caught up in the mean time. If I run into issues I will report them in the importer issue tracker.

Thanks!


Login and NormalizedUserName

When registering a new user (test@here.com), I get the following saved into the [dbo].[AspNetUsers] table:

Email
NormalizedEmail
NormalizedUserName
UserName

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

However, I thought that the username was not very user friendly in my layout and wanted to change it to something like:

Email
NormalizedEmail
NormalizedUserName
UserName

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>John Smith

On the other hand, I found that by using the ResetPassword in the Account controller or the ChangePassword method in the Manage controller, the NormalizedUserName was overwritten by the UserName to get something like that:

Email
NormalizedEmail
NormalizedUserName
UserName

<EMAIL_ADDRESS><EMAIL_ADDRESS>JOHN SMITH
John Smith

Having something like that prevents me to login now as it is using the NormalizedUserName to get identified which is not an email anymore...
Several questions:
Why, when I reset or change my password, my NormalizedUserName gets overwritten?
Why do we use the NormalizedUserName to get logged? It doesn't make sense to me as we provide an email in the interface, it should be using the NormalizedEmail instead.
It would be great to make the distinction between user name for display purposes and user email for identification purpose.
Thank you for your help
Sylvain
ASP.Net Core 1.1

The normalized pieces are for fast lookup, you're confusing email and username, they're different. User Name is the identification field for logging in. Email is there for password resets, password confirmations in our templates.
If you want a display name then you'll need to add it to your model for identity.


add basic UI

Create an app.rb file that will serve as your console app entry-point. It should have methods that do the following:

List all books
List all people
Create a person (teacher or student, not a plain Person).
Create a book
Create a rental
List all rentals for a given person's id.

In a main.rb  define the entry point, this will be a method called main

Present the user with a list of options to perform
Lets users choose an option.
If needed, ask for parameters for the option
Have a way to quit the app.

Your console app should behave in the same way as in the example.

@AmaduKamara, thanks for the review.


[* DateTimeV2] Fix date range (without year) is processed as a single Date with Year (#2850)

Fix to issue #2850 in NL|EN|FR|DE|IT|PT|ES
Test cases added to DateTimeModels.

could you please merge this

@aitelint Can you resolve these conflicts? Thanks.

@aitelint Can you resolve these conflicts? Thanks.

conflicts solved


Display file permissions as octal number in bosh-agent logs

In this PR, I suggest a proper way to output permissions for files that are created by the bosh-agent.
Indeed, those are currently displayed as decimal number, which doesn't make sense because such permissions are typically octal numbers.
Cheers

Thanks! Merged to develop (instead of master) via https://github.com/cloudfoundry/bosh-utils/commit/5da154ebbd4eed939daf23ad49da40048ac7f7d0.


[WIP] Get the thing to run on Windows

Just in case we want to get this running on Windows someday I'm putting together this WIP with the needed changes, along with the collective knowledge that Martin H and I have managed to cobble together.
General Advice
At each step of the way when installing software, please make sure that your PATH has been modified to include the directory to necessary executables, e.g. C:\Ruby\bin;C:\Program Files\PostgreSQL\10\bin; and so on, and that your shell has picked up the changes (probably by creating a new shell afterwards).
ManageIQ changes:

Cannot deal with the ovirt gem because they're doing strange things with C extensions. So we skip it for now.
Will have to assume user has bundler already installed because of a shell quoting issue. Shouldn't be an issue in practice, for local development anyway. Just gem install bundler first.
Seems to require the tzinfo-data gem on Windows, so I added that to the Gemfile.
Minor modification to the manageiq_plugin method to handle the :platform option.

After you've cloned the manageiq repo and applied the changes here, you'll need to create .bat files for everything under the bin directory, one for each executable.

Install bundler

gem install bundler

Install chocolatey:

https://chocolatey.org/install
Then install some packages:
choco install git
choco install cmake
choco install nodejs-lts
choco install python2.7

You could also install ruby and the ruby2.devkit packages via chocolatey if you prefer. Just make sure you've got Ruby 2.5+ and the proper toolkit.
GIT
I ran into an issue with filenames being too long on Windows 7. I don't think you'll hit the issue on Windows 10, but if you get an error about filenames being too long when you (eventually) run bundle install, you'll need to do this:
git config --system core.longpaths true
Install PostgreSQL
In theory you can install PostgreSQL via chocolatey, but it failed for me, so I just used an installer:
https://www.enterprisedb.com/downloads/postgres-postgresql-downloads
Afterwards run this from the shell:
psql -U postgres -c "CREATE ROLE root SUPERUSER LOGIN PASSWORD 'smartvm'"
I installed version 10.8 without issue. Just keep in mind that if you set a postgresql password you'll need to edit config/database.yml and add the password there.
Install Memcached
http://downloads.northscale.com/memcached-win64-1.4.4-14.zip
Unpack the thing somewhere, then run this:
c:/path/to/memcached  -d install
Edit the registry via regedit and look for HKEY_LOCAL_MACHINE/SYSTEM/CurrentControlSet/Services/memcached
Change the ImagePath to “C:/path/to/memcached” -d runservice -m 512
c:/path/to/memcached -d start, or just use the Windows services GUI.
NPM
This is where the fun starts. You'll need to install the windows build tools (large) and do some configuration:
npm install --global --production windows-build-tools --vs2015
npm config set msvs_version 2015 –global
npm config set python python2.7

I also had to do this, but am not entirely sure why:
npm install express
npm init -y

Now install the remaining necessary npm modules for ManageIQ:
npm install -g yarn
npm install -g gulp-cli
npm install -g webpack

THE ACID TEST
Finally, run bin\setup and see it works. If it does, then run bundle exec rails s and try to visit http://localhost:3000.

@himdel Anything I missed?

@djberg96 perfect :) Couple of details..
I think the python setting should be global too...
-npm config set msvs_version 2015 –global
-npm config set python python2.7
+npm config set msvs_version 2015 --global
+npm config set python python2.7 --global

Installing yarn via npm install -g yarn still works but is marked as deprecated, https://yarnpkg.com/en/docs/install#windows-stable seems to recommend choco install yarn.
gulp-cli used to be needed for service ui but is not anymore.
And webpack should not be needed globally (unless you had to change that yarn run webpack in bin/webpack to use a global webpack instance?)
-npm install -g yarn
-npm install -g gulp-cli
-npm install -g webpack
+choco install yarn

As for express and npm init -y, no idea.. there shouldn't be a package.json in manageiq/, not sure why it would be needed on windows.
One more thing.. didn't you mention having to create .bat files even in the UI gem, for bin/webpack?

Oh, and mklink /d for spec/manageiq?

@himdel Updated, thanks!

I can get fs-ext to build after switching to msvs_version 2017. However, now node-gyp configure build the current error is:
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v141 (Platform Toolset = 'v141') cannot be found. To build using the v141 build tools, please install v141 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C: \Users\Daniel Berger\Dev\manageiq-ui-classic\build\binding.vcxproj]
I've tried uninstalling and reinstalling some things, but no luck yet.

Since we're going to be integrating more tightly with systemd, this seems like a lost cause. Oh, well, it was a fun experiment.


Create Admin User Failure

Hello
I tried to create a new admin user by Installation page http://localhost/account/setup  but account doesn't created, and l can login to dashboard.
I use docker compose docker-compose-noproxy.yml, Version: 1.2.1
Thanks...

Thanks. I tested it. THe password requirements are not met and it is not shown properly. I will fix that. Use a special character and uppercase character.


Property author and persistent

I want to alert you on some mistake.
The docs is related about "author is not supported on chrome.", but when I read the Chrome documentation, https://developer.chrome.com/extensions/manifest, it is written "optional property".
The second mistake is about the "persistent" property. This property is supported. There is the migration guide here : https://developer.chrome.com/extensions/background_migration.
Thanks for the complete documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e3b58b7-2f4f-603b-eb83-2f54291cc589
Version Independent ID: 4bc2670d-bb5a-260d-b0d6-7979a3c0bc65
Content: Extensions - Supported manifest keys - Microsoft Edge Development
Content Source: microsoft-edge/extensions/api-support/supported-manifest-keys.md
Service: unspecified
Product: microsoft-edge
GitHub Login: @abbycar
Microsoft Alias: abigailc

Hi @deather - thanks for reaching out! I've updated the page to remove the "Not supported in Chrome." line from the author row.
For persistent, the existing remark does not indicate that it is not supported in Chrome - just that it is a required field in Microsoft Edge. I don't believe there is a mistake there.


Crash setting loadCoreRecipes to false

Issue Description:
Setting the mod to not load the core recipes causes a crash
What happens:
Game dies
What you expected to happen:
Game lives
Steps to reproduce:

Edit the EnderIO.cfg and set B:loadCoreRecipes=false
Launch Game
...

Affected Versions (Do not use "latest"):

EnderIO: 5.0.29
EnderCore: 0.5.35
Minecraft: 1.12.2
Forge: 2739

Your most recent log file where the issue was present:
https://gist.github.com/tgstyle/8907715a715d08e5ae03a212efc5d9f6

Yeah I figured that after I reported this. However for testing I moved in the default xml files, and it breaks because it is not loading the alias file. How can we use aliases? Does it load a specific file first?

The core files are loaded in a specific order, when using the same file sin the user folder, the loading order is random. We recently fixed the loading to load aliases from all files before the recipes (mostly to allow user files to override the core aliases), that fixes this issue, too.
Expect a new release with this feature some time in the next week.

Awesome, Thanks!


JayHorn crashes on dirs that contain non-class-files

such as .java files

Merged with #62 and fixed.


chance evidence for TMMs

Anything with manual assertion  each annotation should be applied manually.
Here, I think we should use
match to sequence model evidence
https://docs.google.com/document/d/1Fj1BZ4ixwVmA3aYkeoFpVWpkZGmpMQDuJnw7Ki-tuZc/edit

No problem.  I've made that change for tonight's load.  I'll check in the morning and close this issue then.


refactor reconcileBroker

moving the client setup to the scope in which it is used cleans up
the scoping and provides a view of three main blocks.

1 Whether to do anything at all
2 Add or Update
3 Finalizers and deletion

tiny refactor, just move the if statement up and re-indent/gofmt.