"Maximum call stack size exceeded." w/ ember && ember-data 2.11 beta

There are quite a few test failures with ember and ember-data beta. They all seem to be max call stack issues. I'll investigate in the next few weeks as I have time, but feel free to weigh in if anyone has thoughts.
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27
    lookupSerializer@http://localhost:7357/assets/vendor.js:84257:32
    serializerFor@http://localhost:7357/assets/vendor.js:94432:37
    ....
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27
    lookupSerializer@http://localhost:7357/assets/vendor.js:84257:32
    serializerFor@http://localhost:7357/assets/vendor.js:94432:37
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27
    lookupSerializer@http://localhost:7357/assets/vendor.js:84257:32
    serializerFor@http://localhost:7357/assets/vendor.js:94432:37
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27
    http://localhost:7357/assets/tests.js:3853:34
    runTest@http://localhost:7357/assets/test-support.js:3255:32
    run@http://localhost:7357/assets/test-support.js:3240:11
    http://localhost:7357/assets/test-support.js:3382:14
    process@http://localhost:7357/assets/test-support.js:3041:24
    begin@http://localhost:7357/assets/test-support.js:3023:9
    http://localhost:7357/assets/test-support.js:3083:9
message: >
    Died on test #1 http://localhost:7357/assets/tests.js:3849:19
    exports@http://localhost:7357/assets/vendor.js:132:37
    requireModule@http://localhost:7357/assets/vendor.js:32:25
    require@http://localhost:7357/assets/test-support.js:7085:14
    loadModules@http://localhost:7357/assets/test-support.js:7077:21
    load@http://localhost:7357/assets/test-support.js:7107:33
    http://localhost:7357/assets/test-support.js:6990:22: Maximum call stack size exceeded.
Log: |

    ....
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27
    lookupSerializer@http://localhost:7357/assets/vendor.js:84257:32
    serializerFor@http://localhost:7357/assets/vendor.js:94432:37
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27
    lookupSerializer@http://localhost:7357/assets/vendor.js:84257:32
    serializerFor@http://localhost:7357/assets/vendor.js:94432:37
    superWrapper@http://localhost:7357/assets/vendor.js:50272:27

Looks like a really tight cycle at the very least.

So this guy is definitely the culprit: https://github.com/emberjs/data/commit/36bc08ab942d0a4113178f1c131c9e7024f0c995 . I've got some cycles to spend right now, I'll get this fixed up. I believe @runspired also has coming changes for ember-data, I'll see if I can investigate them and figure out what the impact is for this addon. Stay tuned.

@workmanw still supports, but the fallback logic moved into the cache (which already was a thing)

@runspired the problem is that previously this addon could provide it's own fallback because ContainerInstanceCache.get would accept that as a third argument. Unfortunately that is no longer the case. As you mentioned, the fallback handling now completely resides inside the cache. And because it's an ES6 class, AFAIK, we are unable to monkey patch this.
Do you have any thoughts on a modification that could be made to allow a fallback to be passed in to get as third argument once again.

I'd originally left the fallback logic outside of the cache but @igorT and I didn't like that this made the cache and the store need to be bound tightly together.  Can you point me to what this fallback is / does?

@workmanw looking through this library's code, I dont see anywhere you make calls into adapterFor.

:( I'm sorry I said adapter ... I meant to say serializer.  See here: https://github.com/lytics/ember-data-model-fragments/blob/master/addon/ext.js#L96-L102
You can see in that case the store is being monkey patched to enable Fragments to have their own default serializer. The design is that just as the store proper has it's own "application serializer" for models, fragments too can have a default fragment serializer. It's my impression that many apps, mine included, just use the "application serializer" as their default fragment serializer, but I definitely can't say that is definitive.

It is likely that you can monkey patch this method:
https://github.com/emberjs/data/blob/36bc08ab942d0a4113178f1c131c9e7024f0c995/addon/-private/system/store/container-instance-cache.js#L64-L75
However I'm in favor of there being a public API for the fallbacks. If you'd open up an issue and are willing to work on an RFC I think this is something we can add and get in before beta goes to stable.

@runspired I think monkey patching _fallbacksFor could be problematic because you don't really know what type if the preferredKey is for a fragment or standard model at that point.
It sounds like you're suggesting a public API for all of ember-data to provide a public mechanism for fallback types. Is that right? Or were you suggesting a public mechanism just for the ContainerInstanceCache it's self? The reason I ask is one is definitely significantly more work than the other.

@workmanw I think the existing monkey patch you have could be ported fairly seamlessly.
let instanceCache = store._instanceCache;
let _super = instanceCache.prototype._fallbacksFor;
instanceCache.prototype._fallbacksFor = function _monkeyPatchedFallbacksFor(namespace, preferredKey) {
  if (namespace === 'serializer') {
    let model = this._store._modelFor(preferredKey);

    if (model && Fragment.detect(model)) {
      return [
        '-fragment',
        '-default'
      ];
    }
  }

   return _super(namespace, preferredKey);
};

It sounds like you're suggesting a public API for all of ember-data to provide a public mechanism for fallback types

This is correct.

@runspired D'oh! That would totally work. I just got it in my head it needed to be an argument. Thanks a lot for the back and forth here.

Although the more I think about it, we kinda want to disallow or discourage customization of the fallbacks ...

Honestly, I have to agree as well. I think it would be hard to explain the need for this outside the context of fragments or some other similar addon.
In the year or so that I've been helping out with this addon I've tried to come up with ways to simplify the relationship, even if just for cognitive reasons. It's super tough because ember-data doesn't want to, and shouldn't have to, keep it's private APIs stable. On the other side, enough people use the addon, that value has clearly demonstrated. I think one of the brittle aspects of this addon is that we end up monkey patching things. If there was a more clean way to extend the store and the model classes, and those classes offered delegate like hooks (e.g. changedAttributes) it could be an improvement. But that's just kind of a brain dump.
Anyways, thanks again!

I'm seeing this issue on the following versions:
    "ember-source": "~3.7.3",
    "ember-data": "~3.7.0",
    "ember-data-model-fragments": "^4.0.0",

Here's our log test log: https://circleci.com/gh/NYCPlanning/ceqr-app/1765


Working behind proxy

Is your feature request related to a problem? Please describe.
We need our continuous integration to upload the openapi yaml to the Redocly API registry, but we always get time out, we think the reason for this timeout is that we are behind an enterprise proxy.
FetchError: request to https://api.redoc.ly/registry failed, reason: connect ETIMEDOUT <IP_ADDRESS>:44     at ClientRequest.<anonymous> (C:\ (...) \AppData\Roaming\npm\node_modules\@redocly\openapi-cli\node_modules\node-fetch\lib\index.js:1491:11)     at ClientRequest.emit (node:events:390:28)     at TLSSocket.socketErrorListener (node:_http_client:447:9)     at TLSSocket.emit (node:events:390:28)     at emitErrorNT (node:internal/streams/destroy:157:8)     at emitErrorCloseNT (node:internal/streams/destroy:122:3)     at processTicksAndRejections (node:internal/process/task_queues:83:21) {   type: 'system',   errno: 'ETIMEDOUT',   code: 'ETIMEDOUT' }
Authorization failed. Please check if you entered a valid API key.
Describe the solution you'd like
We would like openapi cli working behind a proxy server.
Describe alternatives you've considered
We did a quick modification to your code in registry-api.ts to handle the proxy connection:
const HttpsProxyAgent = require('https-proxy-agent');
private async request(path = '', options: RequestInit = {}, region?: Region) {
    const headers = Object.assign({}, options.headers || {}, { 'x-redocly-cli-version': version });
    if (!headers.hasOwnProperty('authorization')) { throw new Error('Unauthorized'); }
const proxyAgent = new HttpsProxyAgent('XXX:XXX/');
    const response = await fetch(`${this.getBaseUrl(region)}${path}`,  Object.assign({}, options, { headers }, { agent: proxyAgent}) );
    if (response.status === 401) { throw new Error('Unauthorized'); }
    if (response.status === 404) {
      const body: RegistryApiTypes.NotFoundProblemResponse = await response.json();
      throw new Error(body.code);
    }
    return response;
  }

(see: https://www.scrapingbee.com/blog/proxy-node-fetch/)
This seems to work for the login command but still timesout for the push command:
FetchError: request to (...) host failed, reason: connect ETIMEDOUT <IP_ADDRESS>:443     at ClientRequest.<anonymous> ( (...) \openapi-cli\node_modules\node-fetch\lib\index.js:1491:11)     at ClientRequest.emit (node:events:390:28)     at ClientRequest.emit (node:domain:475:12)     at TLSSocket.socketErrorListener (node:_http_client:447:9)     at TLSSocket.emit (node:events:390:28)     at TLSSocket.emit (node:domain:475:12)     at emitErrorNT (node:internal/streams/destroy:157:8)     at emitErrorCloseNT (node:internal/streams/destroy:122:3)     at processTicksAndRejections (node:internal/process/task_queues:83:21) {   type: 'system',   errno: 'ETIMEDOUT',   code: 'ETIMEDOUT' }
Additional context
I don't know if it matters but we do have an enterprise license for Redocly.

Hi @joaonlopes,
Thank your for the feature request. Could you also shoot an email to<EMAIL_ADDRESS>so we can track and prioritize it appropriately.

It's done.
Thank you

Hello,
just an update on this. I managed to successfully push the files after modifying your code in push.ts.
const HttpsProxyAgent = require('https-proxy-agent');
function uploadFileToS3(url: string, filePathOrBuffer: string | Buffer) {
  const fileSizeInBytes =
    typeof filePathOrBuffer === 'string'
      ? fs.statSync(filePathOrBuffer).size
      : filePathOrBuffer.byteLength;
  let readStream =
    typeof filePathOrBuffer === 'string' ? fs.createReadStream(filePathOrBuffer) : filePathOrBuffer;

	const proxyAgent = new HttpsProxyAgent('XXX:XXX/');

  return fetch(url, {
	agent: proxyAgent,
    method: 'PUT',
    headers: {
      'Content-Length': fileSizeInBytes.toString(),
    },
    body: readStream,
  });
}

Hope this helps.
Thank you

Thanks @joaonlopes! This definitely helps!

Thanks @joaonlopes, I'll prepare the pull request.

Hi @joaonlopes,
We introduced the changes in openapi-cli version 1.0.0-beta.81 but have to revert them in 1.0.0-beta.82 due to related issues.
We will come back to this enhancement later. Meanwhile, please use your local fix. Sorry for the inconvenience.

Hello @tatomyr,
thank you very much for the notice. For us version 1.0.0-beta.81 works fine.
The commands preview-docs, linter and push are working fine so we can use that for the time being.

Sure @joaonlopes,
Thanks for the update. Glad to hear it works for you.
Do you use the REDOCLY_PROXY env variable for working out your proxy? Just curious if it works for you as we expected.

We just use the REDOCLY_PROXY environment variable and it works fine.

Can we add a note on what the related issues were that caused this to be reverted? The extra information will help us to implement.

Here is the corresponding issue: https://github.com/Redocly/redocly-cli/issues/555

Hello everyone,
thank you very much for the support you provided for this issue. We are still using beta 81 as part of our deployment, because that version works behind the proxy.
Since you decided to rollback, do you plan on implementing/fixing this? Is it ok to continue to work with beta 81?
Thank you very much
Joao

We plan to fix it. We were trying to remember what was the issue that made us rollback.
We'll be updating any progress here.
It's okay to use 81 for now.

Tangentially related: https://github.com/Redocly/redocly-cli/issues/1146.
It would be good to check it when resolving the current one.

Hello everyone,
we are stuck in version 1.0.0-beta.81 and this is starting to cause issues on our side.
For example when using AllOf we are getting a all bunch of validation warnings that don't appear in the latest version:
  _Example value must conform to the schema: `Person` property must NOT have additional properties `DeliveryProof`._

Our problem is that we are working behind a proxy. Is there a workaround for when we want to publish the documentation and we are behind a proxy? I can't believe we are the only users in this situation.
Thanks

I created a fork (_https://github.com/joaonlopes/redocly-cli-behind-proxy_) with my hack to enable using the CLI behind a proxy. If somebody is having the same difficulties as I do you can use it. It's very rough solution but it works.
The principle is: install a recent version of the redocly cli and replace with the modified versions of registry-api.ts and push.ts

Hi @joaonlopes! Sorry, I somehow missed your messages.
We're going to make some changes related to that part of the functionality, and I'd like to incorporate your changes as well. Not sure how this will go though 😅

We had to revert the fix unfortunately as it was causing major issues in our other projects.
We will merge it again soon.


About Sample template

Dear Sir
Sample template suggestions for issue - 4
(https://github.com/cnrture/QuickProjectWizard/issues/4#issuecomment-2329687901)
Is it possible to use your project https://github.com/cnrture/HarryPotter-ComposeMultiplatform
As a base template?
In addition, can the ktor part be switched to ktorfit (https://foso.github.io/Ktorfit/)? Developers who have used Retrofit in the past can quickly get started.
And HarryPotter-ComposeMultiplatform also contains a good nav package (voyager)
Perhaps you can also add precompose
This allows developers to share viewmodels in compose and xml
THX

Hi, I'm currently working on a CMP template, but it won't include Voyager or Precompose. It will be with Android ViewModel and Navigation structure as in this project: https://github.com/cnrture/Valorant-App-Compose-Multiplatform. Because both of them have support now.

Hi, I'm currently working on a CMP template, but it won't include Voyager or Precompose. It will be with Android ViewModel and Navigation structure as in this project: https://github.com/cnrture/Valorant-App-Compose-Multiplatform. Because both of them have support now. I will also look into Ktorfit, thanks 🙏

Hello
Good to hear about the CMP template part
I went to see the project you mentioned Valorant-App-Compose-Multiplatform(
https://github.com/cnrture/Valorant-App-Compose-Multiplatform)
There are a few problems I encountered before
I don’t know if you have encountered it there
See BuildKonfig(https://github.com/yshrsmz/BuildKonfig)
I myself encountered the problem of using
buildConfigField(Type.BOOLEAN, "DEBUG", false.toString())
Will cause iOS with cocoapods compilation to fail
Then
Compose-Multiplatform-Wizard part of terrakok
It is recommended instead
gmazzo's gradle-buildconfig-plugin(
https://github.com/gmazzo/gradle-buildconfig-plugin)
Then for the Navigation part, you use jetbrains' navigation (modified from AndroidX Jetpack)
I may not be able to use this lib very well.
Because I just "added" to the common section
not actually used
Just let my test project "unusable" in the desktop section
Display on macOS
"WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES"
Show on Windows
"Exception in thread "main" java.lang.UnsatisfiedLinkError: 'long org.jetbrains.skia.paragraph.TypefaceFontProviderWithFallbackKt"
I don’t know if you have encountered
Thanks


Preview: The arrows are displayed incorrectly when applying the default size and ACS style

Steps to Reproduce

Add to Canvas arrows Equilibrium Arrows
open Settings
click on button ACS style
click on Apply button

Actual behavior

Expected behavior

Add Arrow Both Ends Filled Triangle Tool
Actual behavior

Expected behavior

Environment

https://nightly.test.lifescience.opensource.epam.com/KetcherDemoSA/5153-change-the-default-size-of-a-plus-and-the-arrows/index.html
Indigo Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0
Ketcher Version 2.25.0-rc.2 Build at 2024-09-20; 12:43:12
MacOs

Issues found while testing https://github.com/epam/ketcher/issues/5153

Verified on https://nightly.test.lifescience.opensource.epam.com/KetcherDemoSA/5153-change-the-default-size-of-a-plus-and-the-arrows/index.html
Ketcher branch 5153-change-the-default-size-of-a-plus-and-the-arrows
Ketcher Version 2.25.0-rc.2 Build at 2024-09-27; 09:11:38
Indigo Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0

Verified
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)


more topics may incorrectly fail to appear when viewing a recently subscribed stream

As reported in chat.zulip.org, we can sometimes incorrectly fail to display "more topics" for streams that the user was recently subscribed to, when viewing such a stream.
The cause is that the logic in for the left sidebar determines whether to show that using stream_topic_history.is_complete_for_stream_id which does the following:
export function all_topics_in_cache(sub: StreamSubscription): boolean {
    // Checks whether this browser's cache of contiguous messages
    // (used to locally render narrows) in all_messages_data has all
    // messages from a given stream, and thus all historical topics
    // for it.  Because all_messages_data is a range, we just need to
    // compare it to the range of history on the stream.

    // If the cache isn't initialized, it's a clear false.
    if (all_messages_data === undefined || all_messages_data.empty()) {
        return false;
    }

    // If the cache doesn't have the latest messages, we can't be sure
    // we have all topics.
    if (!all_messages_data.fetch_status.has_found_newest()) {
        return false;
    }

    if (sub.first_message_id === null) {
        // If the stream has no message history, we have it all
        // vacuously.  This should be a very rare condition, since
        // stream creation sends a message.
        return true;
    }

    // Now, we can just compare the first cached message to the first
    // message ID in the stream; if it's older, we're good, otherwise,
    // we might be missing the oldest topics in this stream in our
    // cache.
    const first_cached_message = all_messages_data.first();
    return first_cached_message.id <= sub.first_message_id;
}

Critically, that last check is only a valid way to determine whether we've seen all the messages in the target stream if we've been continuously subscribed (and thus all messages in that stream should be in all_messages_data).
I'm actually not sure that there is an easy way to do the calculation correctly, in that we don't actually store a per-user numerical value corresponding to the first message sent to the stream after the current user was last (re)subscribed to the stream... but the correct comparison would involve some sort of value along those lines, with that last check instead reading:
    return first_cached_message.id <= sub.first_message_id && always_subscribed;

I worry a bit that such a correct calculation might be more or less practically useless -- only users who were subscribed to the stream at the moment it was created would pass that test. So it's possible the right approach is to instead  abandon some of this logic, and just fetch full topic history, if we haven't already, in situations where we would not be displaying a full set of topics. That query should be cheap in the event that the stream only has <=7 total topics and thus we'd need to ask the question...
This bug is unrelated to #28877 but in the same code path, so it may make sense to work on these together.

@zulipbot claim

Hello! I would like to contribute to this issue, I know it doesn't have the label "help wanted" but would like to give it a try. Or is it too advanced for the first issue?


feat: add support for JSON with comments turbo.json file

Allow the turbo.json file to contain comments
Makes it easier to explain the pipeline when they are quite large :)
So that future @weyert and his colleagues know what's going on!
Fixes #644

@gsoltis I am not sure why the benchmark build step is failing

Any more changes needed to get it merged? @jaredpalmer @gsoltis


Remove source target ellipsoid ids from transform v2

Modified model to remove sourceEllipsoidId and targetEllipsoidId. These could be specified in the sourceEllipsoid and targetEllipsoid definitions provided. The previous model was copied from the previous Geodetic Datum model which made an indirect reference to an ellipsoid. In the case of a geodetic transform such indirection was unrequired an the sourceEllipsoid and targetEllipsoid contained the definition data required (polar and equatorial radiuses).
Note that since JSON def of transforms are not stored anywhere(yet) these changes do not not break any backward compatibility.

You need to run extract-api.

Ran it. There are no API changes. This pull request only removes two members of an internal class

@pmconne Can we move this one forward. You requested I extract API but there was no API changes to commit. (API changes will be in the upcoming promotion to public of the whole thing)


Support html and epub annotations

Hi @aidenlx
Thanks for your super work on this project.
I don't know if I've missed something in the configuration, but I can't get annotations for html and epub pages, which are now annotatable with the latest version 7 of Zotero. Is this already implemented?

It hasn't been tested yet. If Zotero treat all attachment with annotation the same way, it might only need small adjustment to support. Anyway, stay tuned!

supported in v1.1.1


Fix socket timeouts during local debugging

I was running into a problem where sam local invoke --debug-port 9222 myFunction or sam local start-api --debug-port 9222 would crash with a socket.timeout about 60 seconds after attaching to the debug session if there was no log output from the container.
This PR works around the problem by ignoring socket.timeout in the docker attach code and is essential to make debugging via debug port usable – at least on macOS.
Description of changes:
When attaching to a docker container socket.timeout is now ignored so that the attach loop keeps running during remote debug sessions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The patch was tested locally with SAM CLI, version 0.3.0 on macOS 10.13.4 (17E202) with Python 2.7.15 from homebrew.

Thanks for the change @felixbuenemann. The problem statement definitely makes sense but I don't know ignoring timeout will fix the problem. If the underlying socket timed out, wouldn't you need to re-connect somehow?

Ideally, you would set the Timeout value when creating Docker client to be something large - ~10mins is sufficient?
Turns out we create the Docker client three places (only one is actually necessary) - https://github.com/awslabs/aws-sam-cli/search?q=from_env&unscoped_q=from_env. We should refactor this to create the Docker client only in invoke_context.py and pass to container_manager.py which will pass to downstream class. When creating the client using docker.from_env() you should set the timeout to be something large when debugging is enabled. If _debug_port is set, then you can assume that debugging is enabled.
Do you think you can make this change?

Thanks for the change @felixbuenemann. The problem statement definitely makes sense but I don't know ignoring timeout will fix the problem. If the underlying socket timed out, wouldn't you need to re-connect somehow?

The statement is inside a while True endless loop, so it will simply keep trying until the docker daemon responds. This worked fine for me.
I'm not sure how a 10 minute timeout will help, because a debugging session could also take an hour, son any arbitrary value would likely be wrong.

Btw. instead of recovering from socket timeouts (which are how long we wait on blocking operations, not network errors), we could also call socket.settimeout(None) before entering the while loop.

I've been getting a time out error when running my Lambda, but it goes away if I add a console.log
Manually added this patch on my machine, and it fixes the issue!
Here is the error thrown when running....
Traceback (most recent call last):   File "/usr/local/bin/sam", line 11, in <module>     sys.exit(cli())   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__     return self.main(*args, **kwargs)   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 697, in main     rv = self.invoke(ctx)   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke     return callback(*args, **kwargs)   File "/usr/local/lib/python2.7/site-packages/click/decorators.py", line 64, in new_func     return ctx.invoke(f, obj, *args[1:], **kwargs)   File "/usr/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke     return callback(*args, **kwargs)   File "/usr/local/lib/python2.7/site-packages/samcli/commands/local/invoke/cli.py", line 44, in cli     docker_network, log_file, skip_pull_image, profile)  # pragma: no cover   File "/usr/local/lib/python2.7/site-packages/samcli/commands/local/invoke/cli.py", line 76, in do_cli     stderr=context.stderr)   File "/usr/local/lib/python2.7/site-packages/samcli/commands/local/lib/local_lambda.py", line 80, in invoke     stdout=stdout, stderr=stderr)   File "/usr/local/lib/python2.7/site-packages/samcli/local/lambdafn/runtime.py", line 98, in invoke     container.wait_for_logs(stdout=stdout, stderr=stderr)   File "/usr/local/lib/python2.7/site-packages/samcli/local/docker/container.py", line 187, in wait_for_logs     self._write_container_output(logs_itr, stdout=stdout, stderr=stderr)   File "/usr/local/lib/python2.7/site-packages/samcli/local/docker/container.py", line 206, in _write_container_output     for frame_type, data in output_itr:   File "/usr/local/lib/python2.7/site-packages/samcli/local/docker/attach_api.py", line 98, in _read_socket     payload_type, payload_size = _read_header(socket)   File "/usr/local/lib/python2.7/site-packages/samcli/local/docker/attach_api.py", line 170, in _read_header     data = read_exactly(socket, 8)   File "/usr/local/lib/python2.7/site-packages/docker/utils/socket.py", line 44, in read_exactly     next_data = read(socket, n - len(data))   File "/usr/local/lib/python2.7/site-packages/docker/utils/socket.py", line 30, in read     return socket.recv(n) socket.timeout: timed out

@oniice Yeah, that's a good point. The container could simply not be writing to stdout or stderr since it's busy and not logging anything, so making the timeout dependent on wether debug_port ist set as sugggested by @sanathkr is a bad idea.
@oniice This patch should fix your problem as well.

I looked at the py-docker codebase and it looks like docker.from_env(timeout=None) should work. Then again the current solution localizes the fix to only the problematic region instead of setting a higher timeout everywhere.
So while setting the timeout through docker.from_env() would decouple us from the internal implementation, it would mean we would have a higher timeout on all api calls. Since the current code already highjacks the socket from the docker client through private methods, it is already very tightly coupled to the implementation.
@sanathkr Let me know what you think!

@oniice Could you please reformat your backtrace to use triple-backticks (fenced code block) instead of single-backticks so it becomes more readable?

I see the same issue for long-running lambdas that don't output any log messages, my backtrace is the same as @oniice and manually applying this patch fixes it.

Sorry for the late reply. Thanks for clarifying. Timeout actually does not close the socket but simply reports that no new data is available. It makes sense to swallow the timeout then and keep polling.
Also, from other reports, I understand that this can happen even in non-debugging case when your function runs for several minutes without printing anything to the console. Without this patch, such invocations will timeout & fail.
As much as I don't like the unbounded infinite loop, there is value in doing it. This is especially okay for a CLI tool which isn't used in a production environment.
Can we just add a logging.debug to the except timeout block, so we can have visibility into timeout issues for future debugging.

@sanathkr Can we just add a LOG.debug to the except timeout block, so we can have visibility into timeout issues for future debugging.

I've added a LOG.debug call in e2a96f5e691d6932f14fab5c09023b83d76bf08f.

@felixbuenemann Thanks for keeping with this! Congrats on the first PR :)


Add Fagernaes2022

Pull Request
This PR is for a

[x] New Publication(s)
[ ] Correction

For the following list(s):

[ ] ancientmetagenome-environmental (README, ask @thedir-team-dirt for advice)
[x] ancientmetagenome-hostassociated (README, ask @thedir-team-bugparty for advice)
[ ] ancientsinglegenome-hostassociated (README, ask @thedir-team-pathopeeps for advice)

New Publication
Publication Information
This pull request is to add samples from the following publication(s): https://doi.org/10.1093/femsmc/xtac006
This is to close #837
Checklist

[x] Publication is published (preprints currently not accepted)?
[x] Checked the publication is not already in the database?
[x] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
[x] Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
[x] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
[x] Changelog is updated to include the publication under 'Added'?
[x] Pull request has passed validation checks (see automated comment from github-bot)?
[x] Review requested from corresponding team (see list of lists above for each team)?
[x] (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here:

If you do not know how to check errors in failed validation checks, expand here

Correction
This PR is for

[ ] ancientmetagenome-hostassociated
[ ] ancientsinglegenome-hostassociated
[ ] ancientmetagenome-environmental

Reference
This pull request is to correct samples from the following publication(s):
This is to close
Description
The issue is:

Checklist

[ ] Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[ ] Changelog is updated to include the publication under 'Changed'?
[ ] Pull request has passed validation checks (see automated comment from github-bot)?
[ ] Review requested from corresponding team (see list of lists above for each team)?

Correct! From here: https://www.protocols.io/view/illumina-double-stranded-dna-dual-indexing-for-anc-4r3l287x3l1y/v2


StitchingBuilder

Builder Support
For the stitched schema we should provide a builder class that makes it easy to create the stitched layer.
StichingBuilder.New()
    .AddRemoteSchema(foo)
    .AddExtensionFromFile("Extensions.graphql")
    .AddConflictResolver(types => new ConflictResolution(false))
    .AddFieldSelector((type, field) => false)
    .RenameField("schemaName", new FieldReference("Type", "field"), "newFieldName")
    .Merge();

how its work?

The stitching builder is still in progress ... we plan to release it at the end of next week.

The stitching builder is now implemented and included with 0.8.0-preview.3


soundSprite Not Properly Loading In

I am trying to load in an audioSprite as a JSON in the current version of createjs/soundjs. I am not sure if this is supported but let explain what happens.
var assetsPath = "./AUDIO/";
var audio = [
	{src: "CASSIDY/CASSIDY.json" + _localCache.getExtraCacheVersion(), data:{type:"tlk"}},
];

createjs.Sound.registerPlugins([createjs.WebAudioPlugin]);
createjs.Sound.alternateExtensions = ["wav", "mp3"];
createjs.Sound.addEventListener("fileload", createjs.proxy(soundLoaded, this));
createjs.Sound.registerSounds(audio, assetsPath);

Using the code above loads in the WAV audio file and appears to actually apply the id to the file but when I go to play the audio it says the audio was never loaded in and tried to load it again at the wrong directory.
A quick fix would be load the JSON in on another loadQue then pushing it into the sound que.

This is my temporary fix, overridden some functions and added a new:
createjs.Sound.registerSounds = function (sounds, basePath) { 	console.log("AUDIO HI"); 	var returnValues = []; 	if (sounds.path) { 		if (!basePath) { 			basePath = sounds.path; 		} else { 			basePath = basePath + sounds.path; 		} 		sounds = sounds.manifest; 		// TODO document this feature 	} 	for (var i = 0, l = sounds.length; i < l; i++) { 		if(sounds[i].data.isAudioSprite === true){ 			console.log(sounds[i]); 			var _idFromSrc = sounds[i].src.split("/");			 			var _loadItem = {id:(_idFromSrc[1].split(".")[0] + "-JSON"), type:"json", src:(basePath + sounds[i].src)}; 			var _queue = new createjs.LoadQueue(); 			_queue.on("complete", createjs.Sound.parseLoadedAudioSprite, null, true, {loadQue: _queue, id: _loadItem.id, src: (basePath + sounds[i].src)}); 			_queue.loadFile(_loadItem);								 		}else returnValues[i] = createjs.Sound.registerSound(sounds[i].src, sounds[i].id, sounds[i].data, basePath, sounds[i].defaultPlayProps); 	} 	console.log(returnValues); 	return returnValues; }; createjs.Sound.parseLoadedAudioSprite = function (e, payload) { 	let _json = payload.loadQue.getResult(payload.id); 	let _temp = { 		src:payload.src,  		data: _json.data 	}; 	createjs.Sound.registerSound(_temp.src, payload.id.split("-")[0], _temp.data, null, null); };
I don't think it's a good one because it could break people's loading schemes.


Heatmap JS Library Analyse + Prototyp

see b6def05d0efd919b30de214c2e1a415c560f03ad

The heatmap makes no sense for group data. So we decided to visualize the data filling NYCs boroughs  with different gradients.
The easiest way to do this, is Google Fusion Tables:
https://www.google.com/fusiontables/DataSource?docid=1Y4xrfRIo4wghNc2MG9wjs1h8G6VKh3jHvW4Rfxbb


bump version

Bump version of schema-visualization extension

@lozn00  Like this, add it to those json-files and send a PR


Failure while resolving dependencies for Python SDK in poetry based projects

We are observing dependency resolution issues with poetry for Python SDK. To reproduce, create a new empty directory, add the below bare minimum pyproject.toml and run

pip install poetry
poetry install   This step will try to resolve the dependencies for Python SDK pyproject.toml dependencies and it either fails or halts.

pyproject.toml
[tool.poetry]
name = "astrosdktest"
version = "0.0.1"
description = "Test generating poetry lock for Python SDK"
authors = []

[tool.poetry.dependencies]
python = ">=3.8,<3.11"
astro-sdk-python = {extras = ["all"], version = ">=1.3.1,<1.5"}
apache-airflow = ">2.1"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

Closing this as we no longer have a poetry project (previously, we had SQL CLI) here.


Can I work while it's checking the file?

It's a bit annoying when I have to wait few seconds while it's checking a large file

Use ALE instead of syntastic.

pretty cool, thank you


Adapted HypervisorUtilsTest to no longer give false positives

@bhaisaab, this is the PR for the test adaptation discussed in PR#1142

Great thanks, LGTM.
cc @remibergsma  - let's merge this, just so to have less Travis failures? (possibly also merge on 4.6?)

@nlivens @bhaisaab If you guys want this in 4.6 as well (which seems like a good idea) please open a PR against 4.6. That will then be forward merged to master.

Good idea. @nlivens please open the same patch/PR again 4.6 branch, thanks.

LGTM, I hit the unit test failure today with Jenkins while building master branch (4.7) and @nlivens 's fix worked for me :)
cc @DaanHoogland @remibergsma pl do merge this


delete swag cli section

Describe the PR
ref https://github.com/swaggo/swag/pull/325#issuecomment-474801302

@easonlin404 plz review.

Codecov Report

Merging #330 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage      87%   86.99%   -0.02%
==========================================
  Files           7        7
  Lines        1277     1276       -1
==========================================
- Hits         1111     1110       -1
  Misses        103      103
  Partials       63       63

Impacted Files
Coverage Δ

gen/gen.go
67.44% <0%> (-0.74%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9161028...be6bdb8. Read the comment docs.

Change every time you change?

OK. I understand.
https://github.com/swaggo/swag/pull/331#issuecomment-475111610
I will request add README from next PR to creator.


Adding SSSP 1.3.0 support

I still need to confirm some detail of the SSSP archive.

What are the changes in SSSP v1.3?

From v1.2 -> v1.3, the pseudopotentials of elements At, Fr, Ra are added from PSlibrary. The pseudopotential of actinides are added from dataset of https://www.uni-marburg.de/de/fb15/arbeitsgruppen/anorganische_chemie/ag-kraus/forschung/paw_datasets_for_the_actinoids. Both efficiency and precision having those pseudos added. Thus I think you are right, it is good to keep the default unchanged.

But I am confusing on this https://github.com/aiidateam/aiida-pseudo/blob/b331959263efe42bd32f6639464057eb26f8db0f/src/aiida_pseudo/cli/install.py#L112
How this link know which is the latest archive and will find version.yml from there?

But I am confusing on this
https://github.com/aiidateam/aiida-pseudo/blob/b331959263efe42bd32f6639464057eb26f8db0f/src/aiida_pseudo/cli/install.py#L112
How this link know which is the latest archive and will find version.yml from there?

The link is permanent, and the file versions.yaml is updated when a new SSSP version is made available. It is just mapping the minor version to the latest patch. It currently contains:
---
# This maps each minor version to the latest patch version
# corresponding to that minor version
'1.0': '1.0'
'1.1': '1.1.2'
'1.2': '1.2.1'
'1.3': '1.3.0'

It is just used to go from 1.3 to 1.3.0 in this case.

It is ready to review, I revert the change of setting default version to latest one and add a comment on the template url.

@unkcpz does the SSSP keep a CHANGELOG somewhere? I would like to reference to it to give a summary to users of what changed.

@unkcpz does the SSSP keep a CHANGELOG somewhere? I would like to reference to it to give a summary to users of what changed.

Yes it is in https://archive.materialscloud.org/record/file?filename=CHANGELOG.txt&record_id=1732


Update page section for "Azure Bot" as "bot channels registration" has deprecated.

Could you please update the content page section for "Azure Bot" as "bot channels registration" has deprecated.
Section link:
https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/authentication/add-authentication?tabs=dotnet%2Cdotnet-sample#create-the-bot-channels-registration

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63519845-323f-be8f-ce15-d7f39e46b5a7
Version Independent ID: 70952f91-56e9-ff08-59f6-e237d4aaeca9
Content: Add authentication to your Teams bot - Teams
Content Source: msteams-platform/bots/how-to/authentication/add-authentication.md
Product: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@surbhigupta12 - Please help us here to update the contents.

Looks like this issue is a duplicate of below:
https://github.com/MicrosoftDocs/msteams-docs/issues/5039


Related Guides font is too small

https://material-dot-web-central.appspot.com/web/showcase/spotlight/hummingbirdlibrary

Yep - and also lost the line breaks.


Special characters not read due to encoding

So the symbols like degree Celsius are not getting encoded properly. The degree symbol is getting converted to either ? or 'i'¿1/2
Current Dxf :  $DWGCODEPAGE is ANSI_1252
When I read dxf in Vs Code with UTF-8 -> The string is TEMPERATURE\P�C
But with Windows 1252 it is -> TEMPERATURE\P°C
I tried this solution [(https://stackoverflow.com/questions/37870084/net-core-doesnt-know-about-windows-1252-how-to-fix)]
But it still didn't work. Can you just point me in the direction on how I can solve this?
I can't share the file

I cannot reproduce your problem with the little information you have given and I do not see an issue with this matter. My only suggestion is to use only DXF version AutoCad2007 ("AC1021") and upwards.

I solved this by enforcing the encoding on the input stream to netdxf
Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
encoding = Encoding.GetEncoding(1252);


add Ruby 3 to CI matrix; make it primary; patch bug in Prawn; use it for releases

what?

@slonopotamus I have absolutely no idea why this is failing on Ruby 3. I can run the tests fine on Ruby 3 on my own machine and even in a Docker container using the Ruby installed by ruby-setup.

@eregon Any idea why this might be failing on Ruby 3? Ruby 2.7 works just fine in GitHub Actions, and I can run the tests on my own machine. But it cannot seem to find core gems in GitHub Actions on Ruby 3.

Mmh, rexml is a bundled gem according to https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ (it was stdlib before).
That means, if you use Bundler, you need to depend on it explicitly for Ruby 3+.

Mmh, rexml is a bundled gem according to https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ (it was stdlib before).
That means, if you use Bundler, you need to depend on it explicitly for Ruby 3+.

@erebor Aha! I did not make that connection. Thanks for the insight! I'll try to add it as a direct dependency and see how it goes.

@erebor Aha! I did not make that connection. Thanks for the insight! I'll try to add it as a direct dependency and see how it goes.

It looks like that worked!
(I still don't quite understand why this is necessary, but we'll cross the bridge we have to cross if users still have issues).

It looks like that worked!
(I still don't quite understand why this is necessary, but we'll cross the bridge we have to cross if users still have issues).


refactor logs for easy removal

https://github.com/halfnelson/svelte-native/blob/0af94fac6ea18f54f93ab299d0b512f91d722569/src/dom/svelte/SvelteNativeDocument.ts#L17
I now we already that discussion and you wanted to write it your way. But now i am asking for another reason. In production you can / should remove all console logs to make your app thinner and faster.
In N (and i am starting to do that all over) we can apply a rule un production to easily remove logs.
The idea is to look for
if (Trace.isEnabled()) {
...
}

and replace Trace.isEnabled() by false so that terser can remove the whole if code.
In the case of svelte native it wont remove the log line because of the way you write your logs.
I know this is not the way you wanted it but i am asking if you would agree to move to a more "common N" way so that the minify rule for logs could also be applied to 'svelte-native` code.

svelte-native isn't very large and doesn't contain main log lines so I am not sure it is worth the effort and lower DX

@halfnelson in a sense i agree with you. On the other hand every little step added makes a big step at the end. Getting the smallest possible vendor.js is i think a global goal in the N community. I am willing to create a PR if you are interested.
The only really difference will be core readability


Validate username and sub fields from token

@humaton Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-40


Boolean option for non-detachable objects

There should be a boolean option which defines whether an object is detachable or not.
I created a sword example and sometimes the sword was taken out of my hands for some reason. I found out that there is some detach parameter which seems to be physics based and depending on at which force another object collides with the object the player is holding.
In my case the player should never lost his sword, no matter how big the force is that collides with the sword.

Try using the "Child of controller" grab attach mechanic, afaik that's exactly what it's for.

Yes, that worked. Thanks!

There is also another thing that you can't currently do.
The ability to never drop an object even if you press the grab button (which goes well with your auto grab on start issue).
I need to make some changes to allow for this, but I think it's worthwhile that you start a game with an object and you never can let it go.

Brookhaven Experiment has that. You start with a flashlight and a gun which you can never drop.

I may take a look at this today along with the auto spawn an item into your hand (as they go together)


Improve GenericType resolution specificity

Please see #903 for more details surround this fix.

Probably good enough fix for the purpose


Bump target version to dotnet 8

It has been suggested to bump the target to the newest version of dotnet.

If we do not need the features of the newer dotnet versions, targetting netstandard2.0 might be a better choice, as that is also compatible with .Net Framework.


[SPARK-47617][SQL] Add TPC-DS testing infrastructure for collations

What changes were proposed in this pull request?

We can utilize TPC-DS testing infrastructure already present in Spark. The idea is to vary TPC-DS table string columns by adding multiple collations with different ordering rules and case sensitivity, producing new tables. These tables should yield the same results against predefined TPC-DS queries for certain batches of collations. For example, when comparing query runs on table where columns are first collated as UTF8_BINARY and then as UTF8_BINARY_LCASE, we should be getting same results after converting to lowercase.
Introduce new query suite which tests the described behavior with available collations (utf8_binary and unicode) combined with case conversions (lowercase, uppercase, randomized case for fuzzy testing).
Why are the changes needed?

Improve collations testing coverage.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added TPC-DS collations query suite.
Was this patch authored or co-authored using generative AI tooling?

No.

Collation team, please review @dbatomic, @stefankandic, @uros-db, @mihailom-db, @stevomitric.

@nikolamand-db could we also run this test on delta in runtime?

thanks, merging to master!


API Calls to Perplexica Hang Without Response When Using Docker Setup

I recently started using Perplexica with the Docker configuration as outlined in the documentation. However, when triggering API calls via the API testing platform (APIdog), the platform continuously loads without providing any response.
Here are the details of my setup:

OS: Ubuntu 22.04
RAM: 16 GB
CPU: Intel i5 13th Gen (1335U) 12-core
GPU: None

Perplexica is running within a Docker instance, and the UI is accessible at localhost:3000, as expected. I am using the Ollama model with the following configuration:

Chat Model: llama3:latest
Embedding Model: nomic-embeded-text:latest

Has anyone encountered this issue or knows a solution? Any help would be appreciated!

What is your request body?

There isn't any response being generated

I hope this would help. If any other data related to this issue is needed, feel free to ask

What are the logs?

Did you mean the docker logs ?

I have restarted the docker backend service and these are the recent logs
yarn run v1.22.22
$ npm run db:push && node dist/app.js

><EMAIL_ADDRESS>db:push
> drizzle-kit push sqlite

drizzle-kit: v0.22.7
drizzle-orm: v0.31.2

No config path provided, using default path
Reading config file '/home/perplexica/drizzle.config.ts'
[⣷] Pulling schema from database...
[✓] Pulling schema from database...

[i] No changes detected
info: WebSocket server started on port 3001
info: Server is running on port 3001
error: Error at generating documents from links: Invalid URL
error: Unhandled Rejection at: [object Promise], reason: TypeError: Cannot read properties of undefined (reading 'map')

What are the logs?

yarn run v1.22.22
$ npm run db:push && node dist/app.js

><EMAIL_ADDRESS>db:push
> drizzle-kit push sqlite

drizzle-kit: v0.22.7
drizzle-orm: v0.31.2

No config path provided, using default path
Reading config file '/home/perplexica/drizzle.config.ts'
[⣷] Pulling schema from database...
[✓] Pulling schema from database...

[i] No changes detected
info: WebSocket server started on port 3001
info: Server is running on port 3001
error: Error at generating documents from links: Invalid URL
error: Unhandled Rejection at: [object Promise], reason: TypeError: Cannot read properties of undefined (reading 'map')

Can you follow the update guide and update Perplexica to the latest version, I published a fix for this issue a while ago. How to update: https://github.com/ItzCrazyKns/Perplexica/blob/master/docs/installation/UPDATING.md

Hi @ItzCrazyKns , The issue still persists in my machine. Still I am not being able to access the API services. Theses are the current logs that I have obtained after rebuilding the docker image
sudo docker logs 23ae11348065
yarn run v1.22.22
$ npm run db:push && node dist/app.js

><EMAIL_ADDRESS>db:push
> drizzle-kit push sqlite

drizzle-kit: v0.22.7
drizzle-orm: v0.31.2

No config path provided, using default path
Reading config file '/home/perplexica/drizzle.config.ts'
[⣷] Pulling schema from database...
[✓] Pulling schema from database...

[i] No changes detected
info: WebSocket server started on port 3001
info: Server is running on port 3001
error: Error at generating documents from links: Invalid URL
yarn run v1.22.22
$ npm run db:push && node dist/app.js

><EMAIL_ADDRESS>db:push
> drizzle-kit push sqlite

drizzle-kit: v0.22.7
drizzle-orm: v0.31.2

No config path provided, using default path
Reading config file '/home/perplexica/drizzle.config.ts'
[⣷] Pulling schema from database...
[✓] Pulling schema from database...

[i] No changes detected
info: WebSocket server started on port 3001
info: Server is running on port 3001
error: Error at generating documents from links: Invalid URL
```

There is no response obtaining in the API testing applications (APIdog). Are there any solution to this issue or is it being occurred from my end due to any wrong configuration that I have provided ?

Hi @ItzCrazyKns , The issue still persists in my machine. Still I am not being able to access the API services. Theses are the current logs that I have obtained after rebuilding the docker image
sudo docker logs 23ae11348065
yarn run v1.22.22
$ npm run db:push && node dist/app.js

><EMAIL_ADDRESS>db:push
> drizzle-kit push sqlite

drizzle-kit: v0.22.7
drizzle-orm: v0.31.2

No config path provided, using default path
Reading config file '/home/perplexica/drizzle.config.ts'
[⣷] Pulling schema from database...
[✓] Pulling schema from database...

[i] No changes detected
info: WebSocket server started on port 3001
info: Server is running on port 3001
error: Error at generating documents from links: Invalid URL
yarn run v1.22.22
$ npm run db:push && node dist/app.js

><EMAIL_ADDRESS>db:push
> drizzle-kit push sqlite

drizzle-kit: v0.22.7
drizzle-orm: v0.31.2

No config path provided, using default path
Reading config file '/home/perplexica/drizzle.config.ts'
[⣷] Pulling schema from database...
[✓] Pulling schema from database...

[i] No changes detected
info: WebSocket server started on port 3001
info: Server is running on port 3001
error: Error at generating documents from links: Invalid URL

There is no response obtaining in the API testing applications (APIdog). Are there any solution to this issue or is it being occurred from my end due to any wrong configuration that I have provided ?

What LLM are you using?

I am currently using llama3:latest model in Ollama on my local machine


Overloading operators

I made some operator overloading like using + (to add items intuitively). Would this be interested? Of course for more custom case(need more than 1 argument, you would see go back to the add_item()

Closing this since we have a PR now.


Spitting out many "Failed to convert selection" messages on linux

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.19.1
Platform
Linux
OS Version
No response
Architecture
x64
Build Number
No response
Regression From
No response
Bug Description
Storage Explorer spits numerous messages with "Failed to convert selection".
Steps to Reproduce

Open Storage Explorer
Select and copy some text in a text editor
Monitor the terminal for opened Storage Explorer

Actual Experience
Keep spitting error with "Failed to convert selection"
Expected Experience
No error being printed.
Additional Context
The error is about not being able to convert contents in the system selection to a list of files, which is very common and expected. We should be swallowing that error instead of showing it.

This is already merged as a part of the clipboard fix in 1.20.0.


[Feature request] git sparseCheckout support

Thanks for providing such an awesome service/project! I really love your simple UI design!
As the main maintainer of a super huge/fat project - @cdnjs, I'm wondering if you would like to support git sparseCheckout. By default, git will checkout all the files from the repository to the filesystem, by sparseCheckout, we can decide to checkout partial of the files, so this will help decrease the number of files git will checkout, which will totally save both disk sapce, cpu time, build time!
There is only a small different steps between git clone and git, but would help a lot for a huge repo :smile:
Reference:

https://git-scm.com/docs/git-read-tree

https://github.com/cdnjs/cdnjs/blob/master/documents/sparseCheckout.md

[x] I have searched for existing issues

[x] I have discussed the issue with the community at https://gitter.im/drone/drone

moved to https://github.com/drone-plugins/drone-git/issues/37


Support numbered markdown lists with repeated numbers

1. Item
1. Item
1. Item

Is currently reformatted as:
1. Item
2. Item
3. Item

However, both render the same (see the source of this):

Item
Item
Item

The form that repeats the same number can be more preferable, as it's easier to see what changed in diffs and add/remove items without modifying every other list item after it.
Could a new setting be added to prefer this form, or maintain the numbering (if it's consistent)?

@jakebailey thanks! It's a good idea and I see prettier does it too.
This automatically happens now if you have a list where the first two items start with 1 and is released in 0.9.1

Thank you!


make test more explicit

A more explicit expected that ensures stability across processes (and indeed even across Go versions). See https://github.com/klothoplatform/klotho/pull/528.
Standard checks

Unit tests: got 'em
Docs: n/a
Backwards compatibility: no issues

(This is the same as #530, just with the right GH account this time)


Possible constants hinting

I thought about implementing of showing possible constants for magic numbers and strings. I will not mention strings below, as I think the principles for numbers and strings are similar. Below I will describe possible interface implementation and some thougts about probability of constants hinting.
Below is the example of an interface implementation for console output:
--------------------------------------------------------------------------------

src/SomeTestFile.php:34. Magic number: 1121
Possible constants:
	SomeTestFile::SOME_NUMBER
  > 34|         if (($x == 1121) || ($x == 2351)) {

src/SomeTestFile.php:34. Magic number: 2351
Possible constants:
	SomeTestFile::SOME_OTHER_NUMBER
  > 34|         if (($x == 1121) || ($x == 2351)) {

--------------------------------------------------------------------------------

Constant hinting:
I was thinking about this idea for some time, and found out that all the use-cases of magic numbers can be divided into two big groups:

There are constants for some of the magic numbers, but we don't use them for some reason(e.g. we don't know about their existence or we refactor legacy code after constants appearance)
There are no constants in our project at all, so we use magic numbers
First group can be covered easily by indexing all project constants(and, maybe, PHP constants) and comparing each new found constant with indexed list. All matching constants will be shown as possible constants.
I didn't find good implementation ideas for the second group as we cannot predict what meaning a number has and whether two equal numbers have equal meaning or not.

This description does not covers some interesting topics like constant order in hints, number of constants shown in hints etc. But I think they can be specified later.

@Asera thank for suggestion :)
To be honest I was thinking about this feature from beginning. With many things I agree. About 1 group:
And what do you think about constants that are not in you project but they are as your dependency(in your vendor).
About second one yes it is practically impossible. But I think there are numbers where we could probable hint. For example: 404 -> HTTP_NOT_FOUND, 200 -> HTTP_OK and all other http response codes. Or 3306 -> MYSQL_PORT and so on.

First group
I think all the constants that can be extracted from user source files including vendor folder must be indexed.
Also PHP itself has some constants and I saw some cases when magic numbers were PHP predefined constants.
Second group
We could make hints for common and widespread numbers. I was thinking about custom user dictionary for magic numbers, but i found it useless as all the constants are already included in project files. And if user needs dictionary he can define constants in his project, this will be the best solution.

I dont think so that vendor should be included. Firstly it would increase analysis time dramatically. Secondly it is very hard to determine is the constant was found in direct dependency.

#49


Correct time displayed in notification

self.spotify.currentTrack.duration is in milliseconds, thus the notification is using the incorrect unit.

anybody who can merge this?

Thanks a lot, guys! I will merge this in a couple of days.


Wrong description of Wordle Clone

What happened?
The description of the Wordle Game Clone is wrong . It is about wikipedia and not wordle.

How can we reproduce this bug?
Change the description.
Desktop Information (Optional)
No response
Urgency (Optional)
No response

/assign


Updated to work with Python3

Changed to Python3
-() added to print statements

_pickle used instead of cPickle

I ran a 1000 step run and the results were the same.

I doubt you want this and the change is trivial.  I was messing around and thought I would open the pull request for fun.  Thank you for the nice documentation.  I found your model on reddit and wanted to give it a try locally.

LGTM


[SPARK-14346][SQL] Show Create Table (Native)

This is a rebased version of #12132 and #12406
What changes were proposed in this pull request?
Allow users to issue "SHOW CREATE TABLE" command natively in SparkSQL.
-- For tables that are created by Hive, this command will display the DDL in hive syntax. If the syntax includes CLUSTERED BY, SKEWED BY or STORED BY clause, there will be a warning message saying that this DDL is not supported in SparkSQL native DDL yet.
-- For tables that are created by datasource DDL, such as "CREATE TABLE... USING ... OPTIONS (...)", it will show the DDL in this syntax.
-- For tables that are created by dataframe API, such as "df.write.partitionBy(...).saveAsTable(...)", currently the command will display DDL with the syntax "CREATE TABLE.. USING...OPTIONS(...)". However, this syntax lose the partitioning information. It is proposed to display create table in the dataframe API format, such as <DataFarme>.write.partitionBy("a").bucketBy("c").format("parquet").saveAsTable("T1")
How was this patch tested?
Unit tests are created.

Can one of the admins verify this patch?

@yhuai @andrewor14 Thanks!

test this please

Test build #56899 has started for PR 12579 at commit 13e9775.

Test build #56899 has finished for PR 12579 at commit 13e9775.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56899/
Test FAILed.

Build finished. Test FAILed.

@liancheng Thanks for triggering the test! I am looking into the test failure.

retest this please

@yhuai @liancheng , I see PR #12734 takes care of the PARTITIONED BY and CLUSTERED BY (with SORTED BY) clause for CTAS syntax, but not for non-CTAS syntax.  Now I need to change my PR to adapt to this change, which means that the generated DDL will be something like create table t1 (c1 int, ...) using .. options (..) partitioned by (..) clustered by (...) sorted by (...) in ... buckets. But there won't be a "select clause" following it since we do not have the original query. But such generated query will not run because #12734 does not support it.  Can we add a fake select clause with a warning message?
Also DataFrameWriter.saveAsTable case is like CTAS. Can we then generate the DDL as a regular CTAS syntax? This will change my current implementation in this PR.
Please advice, thanks a lot!

Can one of the admins verify this patch?

@xwu0226 I think this is superseded by https://github.com/apache/spark/pull/12781 ?

@srowen Yes, for datasource table. This PR also includes the work for hive syntax DDL too. I see #12781 mentions that there will be followup PR taking care of the hive syntax DDL. So I wondering whether I should continue on this PR. I can close this one if there is no need. Thanks!

Hey @xwu0226, sorry that I didn't explain why I opened another PR for the same issue, was in code rush for 2.0...
So one of the considerations for all the native DDL commands is that we don't want these DDL commands to rely on Hive anymore. This is because we'd like to remove Hive dependency from Spark SQL core and gradually make Hive a separate data source in the future. This means, we shouldn't add new code in places like HiveClientImpl. These new DDL command should be implemented upon interfaces like CatalogTable.
One apparent problem of this approach is that, current Spark SQL interfaces don't capture all semantics of Hive. For example, some table metadata like skew spec is not covered in CatalogTable yet. Our general strategies are:

For easy ones, like "owner" and "compressed" in #12844, we may just add them to the interface and leverage them.
For features that are not supported in Spark SQL, for example, skew spec, we can simply ignore them for now, since Spark can't handle them anyway.

There will be a follow-up of #12781 to add support for Hive tables. After offline discussion with @yhuai, we decided to add a flag in CatalogTable to indicate that whether there unrecognized metadata provided by the underlying external catalog, but not translated and included in CatalogTable. In this way, when applying SHOW CREATE TABLE to tables containing such metadata, this flag can be set to true, and we can simply refuse to output anything by checking this flag. This makes sense because even if you add things like skew spec in the result of SHOW CREATE TABLE, Spark can't handle the generated DDL statement

@liancheng Thank you for the detail explanation!! Yeah. if the goal is to make sure Spark SQL can handle the generated DDL, then, we need to miss some hive features for now. I will close this PR.


Add support for background images on the cover page.

I implemented this feature in commit be52c88c08763fc8648ea425b01c94746443bdc6. One can insert a background image (PDF, PNG or JPG) with the variable titlepage-background.


Curriculum update needed on DOM_manipulation_and_events.md

The Odin's file, DOM_manipulation_and_events.md is updated. Please update the Kampus' file, checkout file here DOM_manipulation_and_events.md
Latest commits:

Merge pull request #26989 from Mclilzee/remove-words-foundations (additions: 4, deletions: 4) on Jan 12 2024, 13:18 UTC

New commits have been made to the Odin's file. Please update the Kampus' file.
Latest commits:

Update link fragments (additions: 1, deletions: 1) on Feb 8 2024, 13:00 UTC
update dom heading (additions: 1, deletions: 1) on Feb 6 2024, 02:24 UTC
resolve lint error (additions: 1, deletions: 1) on Feb 3 2024, 17:00 UTC
remove blannk lines (additions: 0, deletions: 3) on Feb 3 2024, 16:32 UTC
remove hard tabs (additions: 1, deletions: 1) on Feb 3 2024, 16:28 UTC
add blank line after heading (additions: 1, deletions: 0) on Feb 3 2024, 16:15 UTC
resolve md lints (additions: 3, deletions: 0) on Feb 3 2024, 16:09 UTC
Remove extra spaces (additions: 0, deletions: 3) on Feb 3 2024, 15:33 UTC
Add Lazy numbering in lists (additions: 2, deletions: 2) on Feb 3 2024, 15:21 UTC
update nested lists (additions: 3, deletions: 3) on Feb 3 2024, 15:21 UTC
update single spaces (additions: 6, deletions: 6) on Feb 3 2024, 15:19 UTC

New commits have been made to the Odin's file. Please update the Kampus' file.
Latest commits:

Replaced 4th line (cssText) for kebab case rules) (#27497) (additions: 1, deletions: 1) on Feb 28 2024, 20:34 UTC

New commits have been made to the Odin's file. Please update the Kampus' file.
Latest commits:

Update DOM_manipulation_and_events.md (additions: 11, deletions: 1) on Mar 20 2024, 22:45 UTC


fix(tray): Support clients with different depths

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other: Replace this with a description of the type of this PR

Description
XCB_BACK_PIXMAP_PARENT_RELATIVE requires that the client has the same
depth as the tray window.
There was an issue with dropbox having a depth of 32 and the tray window
having a depth of 24 that caused the configuration of the icon to fail.
It would then be displayed outside of the bar because the catch block
was not hit (different exception).
We now just don't configure XCB_CW_BACK_PIXMAP. This seems to work and
is also what stalonetray does.
This does not fix the issue with dropbox having an arbitrary background.
I also noticed that these are the same symptoms as #1679, so I think that should be fixed now as well (though I can't confirm because the issue no longer occurs because of a new synology drive version)
Related Issues & Documents
Fixes #2430
Fixes #1679
Documentation (check all applicable)

[ ] This PR requires changes to the Wiki documentation (describe the changes)
[ ] This PR requires changes to the documentation inside the git repo (please add them to the PR).
[x] Does not require documentation changes

As I confirmed on my issue, this PR fixes the problem.

This also fixes the issue for me, thanks!

Great. Thanks for confirming :)
Will try to put out a patch release on the weekend.


have m.program.gps[x].result be able to print a table

this could make debugging a lot more user friendly

@bqpd, should we give SolutionArray an init, such that it's possible to do
print SolutionArray(m.program.gps[i].result).table()

Ooh yes we should

ok that sounds straightforward, let's gitrdone

unit test for initializing a SolutionArray this way

Reopening due to #921


Build fails in 2.1.4

Build fails
Build fails with the following message:
Failed to minify the code from this file:
./node_modules/react-trello/dist/dnd/Container.js:22
Steps To Reproduce
Steps to reproduce the behavior:

yarn add react-trello
yarn build

Expected behavior
Build without errors.

This was coming from "react-scripts-platformsh".
It seems like it using react-scripts version < 2.0.0., which caused the build to fail.
Read more here: http://bit.ly/2tRViJ9

I have the same issue. but I am using react-app-rewired. pls tell any idea to solve this issue.

react-app-rewired build

Creating an optimized production build...
Failed to compile.
Failed to minify the code from this file:
    ./node_modules/react-trello/dist/dnd/Container.js:22

Read more here: http://bit.ly/2tRViJ9
npm ERR! code ELIFECYCLE
npm ERR! errno 1


Add a workflows document

I went through all the use cases identified, and summarized them into 5 different auth related workflows that when performed, meet all the use cases. I wrote those up with some structure here, along with a space for linking to documentation (or we could just write those in here as subheadings in future PRs) for how either of the solutions under consideration (KeyCloak and Custos/veda-auth-central) would accomplish these workflows.
I think next step is to spend 1 week reviewing and editing these, and once we are comfortable, merge this and start filling out the implementation sections.
Ref https://github.com/NASA-IMPACT/veda-auth-central/issues/119

Things missing:

A place to record effort of ongoing maintenance
Review language in particular on Workflow 4 (roles / capabilities / scopes)

I'll work on workflow 5 today, and i'm hoping we can get this merged before thursday

Merging per last auth meeting, + confirmation on slack from @eroma2014!
I've removed workflow 5 from here, and will open a new PR with it.


Add optional default value to language lang.Translate

This is a common, or at least useful, construct:
{{ or (T "word") "default" }}

Meaning, lookup the translation for "word", and if there isn't one, use "default" instead.This works great, but when you run hugo --printI18nWarnings you get:
WARN  i18n|MISSING_TRANSLATION|en|word
WARN  i18n|MISSING_TRANSLATION|de|word

In the construct above, we don't care that a translation does not exist... we've already handled that with a default value.
The current signature is:
lang.Translate KEY [CONTEXT]

Wondering about something like...
lang.Translate KEY [CONTEXT] [DEFAULT]

That's a bit wonky, because (theoretically) someone might want to pass a string as CONTEXT, though usually CONTEXT will be float, integer, or map. We could take the risk:

If there are three args the last is the default.
If there are two args, and the second is a string, it's the default. Although unlikely, this could break some sites, but I have no data to backup the risk estimate.

We can get the desired behavior by (a) mounting i18n to data and (b) creating a partial that uses site.Data to check for key existence before calling lang.Translate. But the translation call isn't nearly as elegant as {{ T "word" "default" }} or {{ T "word" 42 "default" }}.
If we do this, both of the following should ignore cases where a default value is specified:

--printI18nWarnings (must have)
 enableMissingTranslationPlaceholders = true (nice to have)

As already mentioned in the discourse:

That feature would be great!
I recently removed those warnings from my theme by a not very elegant workaround adding 6 lines of code for each occurance :frowning:

I can not say anything about the impact to other users but it would at least solve my hassle.

In the construct above, we don't care that a translation does not exist...

That's a little bit of a bold statement. I think I would still care.

--printI18nWarnings (must have)

If we the new "default" thing suppressed these warnings, there's no way for me as a Norwegian theme user using a theme created by a Japanes theme author to know that there's untranslated "default" Japanese text in my UI.
If your theme has 20 translation IDs, how hard is it to put these into YAML/TOML compared to putting them directly into the template?
As an added foot note here, there maybe improvement potential here in the way we handle fallback translations (e.g. pick Swedish if Norwegian translation is missing).

The use case that triggered this proposal is quite narrow: translating the text that appears when rendering a menu entry. There are several valid ways to translate this depending on how the menu entry is defined (automatically, in front matter, or in site config):

The name property
The page's linkTitle
The page's title
Using the i18n function with the menu entry's name, identifier, or keyName as the lookup key

I simply wanted a way to say: if there's a translation in the i18n table, use that instead. And do it without falling back to the default content language, and without triggering a warning.
Closing this in favor of lang.HasTranslation as proposed in https://github.com/gohugoio/hugo/issues/10538 and implement in https://github.com/gohugoio/hugo/pull/10539.


MountVolume.NewMounter initialization failed for volume "secrets-store-inline" : volume mode "Ephemeral" not supported by driver secrets-store.csi.k8s.io (no CSIDriver object)

E1214 22:27:31.518630       1 mic.go:1111] failed to update user-assigned identities on node aks-agentpool-33013998-vmss (add [1], del [0], update[0]), error: failed to update identities for aks-agentpool-33013998-vmss in MC_rg-demo5678_aks-demo5678_eastus, error: compute.VirtualMachineScaleSetsClient#Update: Failure sending request: StatusCode=0 -- Original Error: Code="LinkedAuthorizationFailed" Message="The client 'c8dc49d9-3825-4590-898b-d8fc990790fa' with object id 'c8dc49d9-3825-4590-898b-d8fc990790fa' has permission to perform action 'Microsoft.Compute/virtualMachineScaleSets/write' on scope '/subscriptions/12ca88bc-83a0-4a0e-afc2-58453a285523/resourceGroups/MC_rg-demo5678_aks-demo5678_eastus/providers/Microsoft.Compute/virtualMachineScaleSets/aks-agentpool-33013998-vmss'; however, it does not have permission to perform action 'Microsoft.ManagedIdentity/userAssignedIdentities/assign/action' on the linked scope(s) '/subscriptions/12ca88bc-83a0-4a0e-afc2-58453a285523/resourcegroups/rg-demo5678/providers/microsoft.managedidentity/userassignedidentities/identity-aks-kv' or the linked scope(s) are invalid."
E1214 22:27:31.625347       1 mic.go:1129] failed to apply binding default/identity-aks-kv-binding node aks-agentpool-33013998-vmss000000 for pod default/nginx-secrets-store-5bcf78868f-kjbds, error: failed to update identities for aks-agentpool-33013998-vmss in MC_rg-demo5678_aks-demo5678_eastus, error: compute.VirtualMachineScaleSetsClient#Update: Failure sending request: StatusCode=0 -- Original Error: Code="LinkedAuthorizationFailed" Message="The client 'c8dc49d9-3825-4590-898b-d8fc990790fa' with object id 'c8dc49d9-3825-4590-898b-d8fc990790fa' has permission to perform action 'Microsoft.Compute/virtualMachineScaleSets/write' on scope '/subscriptions/12ca88bc-83a0-4a0e-afc2-58453a285523/resourceGroups/MC_rg-demo5678_aks-demo5678_eastus/providers/Microsoft.Compute/virtualMachineScaleSets/aks-agentpool-33013998-vmss'; however, it does not have permission to perform action 'Microsoft.ManagedIdentity/userAssignedIdentities/assign/action' on the linked scope(s) '/subscriptions/12ca88bc-83a0-4a0e-afc2-58453a285523/resourcegroups/rg-demo5678/providers/microsoft.managedidentity/userassignedidentities/identity-aks-kv' or the linked scope(s) are invalid."

Hello 👋🏻  From the error message you posted this looks like insufficient permissions when using aad-pod-identity. Please refer to https://azure.github.io/aad-pod-identity/docs/getting-started/role-assignment/ for required role assignments. Also, checkout the aad-pod-identity troubleshooting which has the topic: https://azure.github.io/aad-pod-identity/docs/troubleshooting/#linkedauthorizationfailed

Thanks so much now it's working properly.

Thanks for confirming! Closing this issue now. Feel free to reopen if you've any questions.

Hi Aramase,
This is SecretProviderClass
apiVersion: secrets-store.csi.x-k8s.io/v1alpha1
kind: SecretProviderClass
metadata:
name: secret-provider-kv
namespace: default
spec:
provider: azure
secretObjects:
- data:
- key: RABBITMQPASSWORD
objectName: RABBITMQPASSWORD
secretName: akvsecrets
type: Opaque
parameters:
usePodIdentity: "true"
useVMManagedIdentity: "false"
userAssignedIdentityID: ""
keyvaultName: $keyVaultName
cloudName: AzurePublicCloud
objects:  |
array:
- |
objectName: RABBITMQPASSWORD
objectType: secret
objectVersion: ""
objectAlias: RABBITMQPASSWORD
resourceGroup: $resourceGroupName
subscriptionId: $subscriptionId
tenantId: $tenantId

This is deployment file
apiVersion: apps/v1
kind: Deployment
metadata:
name: wordpress-blog
spec:
replicas: 1
selector:
matchLabels:
app: wordpress-blog
template:
metadata:
labels:
app: wordpress-blog
aadpodidbinding: azure-kv
spec:
containers:
- name: wordpress-blog
image: wordpress:4.8-apache
ports:
- containerPort: 80
env:
- name: WORDPRESS_DB_HOST
value: "demoaks.mysql.database.azure.com" #Update here
- name: WORDPRESS_DB_PASSWORD
valueFrom:
secretKeyRef:
name: akvsecrets
key: RABBITMQPASSWORD
- name: WORDPRESS_DB_NAME
value: "demo"
- name: WORDPRESS_DB_USER
value: "azuredatabase@demoanalytics123"  #Update here
volumeMounts:
- name: secrets-store-inline
mountPath: "/mnt/secrets-store"
readOnly: true
volumes:
- name: secrets-store-inline
csi:
driver: secrets-store.csi.k8s.io
readOnly: true
volumeAttributes:
secretProviderClass: secret-provider-kv
affinity:
podAntiAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: "app"
operator: In
values:
- wordpress-blog
topologyKey: "kubernetes.io/hostname"
apiVersion: v1
kind: Service
metadata:
name: php-svc
spec:
type: LoadBalancer
ports:
- port: 80
selector:
app: wordpress-blog
When i deploy this this deployment.yaml file its showing
this error :  WORDPRESS_DB_PASSWORD:  <set to the key 'DatabasePassword' in secret 'akvsecrets'>  Optional: false
Error: secret "akvsecrets" not found
But CSI Volume mounted successfully :  Mounts:
/mnt/secrets-store from secrets-store-inline (ro)
/var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-mnm4r (ro)
Can you please let me know how to declare a variable using ENV


Create a health check.

Create a health check that could restar the application in case it goes down.
Awesome project!

You can use the uptime kuma service. And set up notifications in the messenger

@Yurgeman Thanks for suggesting it! I've being using Uptime Kuma which is an incredible one, but I want to restart automatically my application pod if my health check receives something wrong. e.g. Expose /health endpoint in my container and make Coolify call it each 10 seconds. If it receives something different from 200, then restart the pod. I don't know if Coolify has something to integrate with Kuma, would be awesome as well.

Ditto on this one.
I think this could easily be solved once the Kubernetes destination is implemented since that has health checks baked in.

It is available in v4.
I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


[SOLVED] TypeError [ERR_INVALID_ARG_TYPE]

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined at validateString (internal/validators.js:125:11) at Object.join (path.js:1147:7)

SOLVED (if anyone is searching) that upgrading "react-scripts" from "3.3.0" to "^3.4.0"
ref: https://github.com/facebook/create-react-app/issues/8499#issuecomment-588597645

Hi @styk-tv ,
Thanks for reporting this issue.
As per your ref, It seems to be more related to create-react-app than to react-keycloak so I'm going to close this issue.
Thanks again.

@panz3r posted here because none of the examples worked until i fixed above.

@styk-tv , I see, thanks.
You are right about that, I'm working on the update of the various dependencies of the project but it's taking some time.
Thanks again.


add performance test baselines for iPhone 5s & iPad Mini 2

These are now connected to CI so they need performance baselines. /cc @tgoyne

@tgoyne


python310Packages.karton-core: 5.0.1 -> 5.1.0

Description of changes
Version bump
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 232283 run on x86_64-linux 1

12 packages failed to build:

python310Packages.karton-autoit-ripper
python310Packages.karton-autoit-ripper.dist
python310Packages.karton-classifier
python310Packages.karton-classifier.dist
python310Packages.karton-config-extractor
python310Packages.karton-config-extractor.dist
python311Packages.karton-autoit-ripper
python311Packages.karton-autoit-ripper.dist
python311Packages.karton-classifier
python311Packages.karton-classifier.dist
python311Packages.karton-config-extractor
python311Packages.karton-config-extractor.dist

20 packages built:

python310Packages.karton-asciimagic
python310Packages.karton-asciimagic.dist
python310Packages.karton-core
python310Packages.karton-core.dist
python310Packages.karton-dashboard
python310Packages.karton-dashboard.dist
python310Packages.karton-mwdb-reporter
python310Packages.karton-mwdb-reporter.dist
python310Packages.karton-yaramatcher
python310Packages.karton-yaramatcher.dist
python311Packages.karton-asciimagic
python311Packages.karton-asciimagic.dist
python311Packages.karton-core
python311Packages.karton-core.dist
python311Packages.karton-dashboard
python311Packages.karton-dashboard.dist
python311Packages.karton-mwdb-reporter
python311Packages.karton-mwdb-reporter.dist
python311Packages.karton-yaramatcher
python311Packages.karton-yaramatcher.dist

5.2.0 is on master.


FLINK-31888: Introduce interfaces and utils for loading and executing enrichers

https://issues.apache.org/jira/browse/FLINK-31888
Introduce new Config and interfaces for FailureEnricher / Context as well as FailureEnrichersUtils to set the ground work for the upcoming issues. This PR also adds some tests to verify plugin functionality.
This doesn't affect any existing code path.

@dmvk / @akalash  can you please take a look?

The commit message should follow standard formatting:
[FLINK-XXX][component] ....
This means that the current message
FLINK-31888: Introduce interfaces and utils for loading and executing enrichers

Should become
[FLINK-31888] Introduce interfaces and utils for loading and executing enrichers

Thanks for the comments @dmvk ! Please take another look when you have a moment :)

@flinkbot run azure


speak() method not working on iOS

The "MobileAccessibility.speak()" method does not appear to be doing anything. The actual method call does take place, but it does not seem to fire anything on the iOS side. Works fine on Android.

I can't seem to replicate this in my test application. Could you provide any additional context? Is VoiceOver running on the iOS device. With VoiceOver running on the device, when debugging in Safari, you should be able to enter MobileAccessibility.speak("Hello world") in the console and hear "Hello world" spoken by VoiceOver on the device.

The VoiceOver is indeed running. If I run MobileAccessibility.speak('Hello world') the method fires (as in, it's not breaking), but the VoiceOver does not react to that, so I'm assuming it's something to do with the bridge between Cordova and native, but currently that's just a guess.

Here's a link to the demo app that I'm using to test: https://github.com/majornista/phonegap-mobile-accessibility-test.

I have a similar problem. Is there any way to fix this? (running on android...)


Qtip scrolls with page scroll in Chrome

In Chrome, the combination of overflow:auto/scroll and position:relative/absolute on the body results in qtip scrolling with the page, becoming detached from its target element. It works fine in Firefox and IE.
This jsfiddle example is fixed by removing either the position or the overflow property: http://jsfiddle.net/bQ6Fv/1/

I am experiencing the same issue. What is the solution / work-around?

Yep, same problem here :weary:. The problem is I need overflow: auto to avoid margin collapse.

I just realised that this also happens in Firefox and Safari. :weary:
Isn't anyone else annoyed by this??

Hi!
I just discovered that by commenting https://github.com/qTip2/qTip2/blob/master/src/core/position.js#L221 and https://github.com/qTip2/qTip2/blob/master/src/core/position.js#L222
the issue is fixed.
@Craga89 what is the scroll function in resposition.offset for??
	function scroll(e, i) {
		pos.left += i * e.scrollLeft();
		pos.top += i * e.scrollTop();
	}

Created a provisional fix to this problem here https://github.com/Snesi/qTip2.git.
But I'm not going to create a pull request until I fully understand the problem.

@Craga89 If I have time during the weekend I'll try to fix this issue and make a pull request. But I'm starting to think that my problem may be an isolated thing. I don't know if other people have the same bug, because my qtips scroll in all Browsers, and even with the "fix" I proposed, the qtips are still scrolling in iOS.

Seeing the same issue here.

This still seems to be a problem - I created a JSFiddle ( https://jsfiddle.net/davosmith/4t9r7oxj/ ) before I realised others had already reported this.
I'd suggest either the code that sets: scrolled = $(parent) needs to ignore 'body' tags, or the code below it that checks to see if scrolled[0] !== ownerDocument[0] should also check that this isn't the 'body' tag.

This is still happening for me. I just grabbed v3.0.3


Add Spectrogram BSD to LBtoL0 and test

Codecov Report

Merging #83 (7941d32) into master (53277a5) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7941d32 differs from pull request most recent head 44f514a. Consider uploading reports for the commit 44f514a to get more accurate results

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   79.28%   79.28%
=======================================
  Files          44       44
  Lines        2868     2868
=======================================
  Hits         2274     2274
  Misses        594      594

Impacted Files
Coverage Δ

stixcore/products/common.py
84.61% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53277a5...44f514a. Read the comment docs.


Bugfix/attribute text grammar

We can resolve this by making singular or plural. I don't have an opinion there, as long as it's consistent

I'm not an "authorized user", so I can't merge it
My überadmin rights were recently pulled when I complained about getting Security emails


Rename data-model to wherehows-data-model.

Coverage remained the same at 0.0% when pulling 07d2e07d27fd7caaf917be90b3df45d748270ffc on mars-lan:rename2 into 5db8a3d7a9f1d3b19423c294aaeb87593f2e6bc8 on linkedin:linkedin.


Accessing an enum property

Version
3.0.0
Expected behaviour
Access an enum property.
Actual behaviour
I have to do the following: MyEnum.meta.map.PROPERTY
Steps to reproduce

Create an enum.
Access any of it's properties.

This is a complete noob question, but shouldn't enum provide a way to query its values instead of accessing meta.map? Just like a plain freezed object.

For consistency, all runtime type introspection infos are stored in a meta object:
refinement
const MyRefinement = t.refinement(t.String, mypredicate)

// meta object
{
  kind: 'subtype',
  type: t.String,
  predicate: mypredicate
}

list
const MyList = t.list(t.String)

// meta object
{
  kind: 'list',
  type: t.String
}

enums
const MyEnum = t.enums(map)

// meta object
{
  kind: 'enums',
  map: map
}

etc...
Is there a particular reason you want to access the enum values by writing MyEnum.PROPERTY instead of MyEnum.meta.map.PROPERTY (besides being shorter)?

Nope, I just thought that it would be nice to access it in a more shorter way :stuck_out_tongue_winking_eye:

I'm not reopening this, but another reason is that flow can autocomplete the object properties when simply freezing an Object.


Add unit test for Addressable client

cc @tsconn23
claim it~

https://github.com/edgexfoundry/edgex-go/pull/240#issuecomment-390415608


What is the price or rate limiting of the batch processing api?

Closing this because it's superseded by this issue.


Set z order of web view with the preference ZOrderOnTop.

Allow setting the web view zOrderOnTop from config.xml.
This is useful when using this plugin together with plugins like https://github.com/mapsplugin/cordova-plugin-googlemaps which require the crosswalk web view to be drawn on top of them.

thanks for the patch. could you please remove the .gitignore part from it, as it's unrelated to the rest?

Done.

I agree. I was guiding my self according to BackgroundColor. Maybe its better to set a final string and make it more like xwalkUserAgent?

Yes, thanks


Create signup and login route with JWT

Description
Created 4 route

/auth/register
/auth/login
/auth/logout
/users/self

with  JWT authentication token  as a response while login

You have API contract???

You have API contract???

No will have to create


Use a persistent shell instead of spawning new commands

I was working on adding the ability to call zsh functions when I noticed that each time a command is run a new process is created rather than sending text to additional shell.
One of the functions I use all the time is autojump. But unfortunately it isn't much use in black screen because spinning up a new zsh instance and changing directories there doesn't really help. I also noticed this current design prevents settings variables and using them in later commands.
I'm just getting familiar with the code base and so I may be misunderstanding. I'm also sure that there is a good reason for the current way it is done. But just wanted to get discussion started around the topic.
Again, love the idea and seems so far to be a really well made project.

@jimmyhmiller, are you aware that Black Screen uses its own shell? If so, I'm not sure what would you do with ZSH functions.

I wasn't aware of that. I was looking at the project as more just a modern interface into existing shells. But I guess I misunderstood.


#934 Fixed test failures on SM

This change is

PR is added to the queue for testing as 1. task. (b662592)

Hi @artemjackson, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Fail) 84097932 build is completed (b662592)
See https://github.com/ThaliTester/TestResults/tree/84097932b662592__934_Fixed_test_failures_on_SM_artemjackson/ for the logs

PR is added to the queue for testing as 1. task. (74644d3)

Test (Fail) 84097932 build is completed (74644d3)
See https://github.com/ThaliTester/TestResults/tree/8409793274644d3__934_Fixed_test_failures_on_SM_artemjackson/ for the logs

It seems that the issue #987 does not relate to current implementation of thali test runner. Closed.


ReferenceEquals always returns false for struct comparison

Type of issue
Other (describe below)
Description
The article attributes the fact that ReferenceEquals=false to the fact that a structure was copied, however it's not true - it will always return false, even in both examples (in which clearly no copy is involved); so it shouldn't be attributed to the fact of copying, but rather due to boxing ;)
public struct A
{
}

public class Assertions
{
	internal static A A1 = new A();

	public void Y()
	{
		Console.WriteLine(object.ReferenceEquals(A1, A1));
		Lol(ref A1);
	}

	private void Lol(ref A a)
	{
		Console.WriteLine(object.ReferenceEquals(A1, a));
	}
}

Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/statements-expressions-operators/how-to-test-for-reference-equality-identity
Content source URL
https://github.com/dotnet/docs/blob/main/docs/csharp/programming-guide/statements-expressions-operators/how-to-test-for-reference-equality-identity.md
Document Version Independent Id
b8e7e74e-d529-2397-a121-2cb7618a6cac
Article author
@BillWagner
Metadata

ID: abfb3769-16f2-70c8-8b66-5fa0a11354c0
Service: dotnet-csharp
Sub-service: fundamentals

Hi @marchewek
I'll put this in the backlog so that we clarify the language. You're correct, but so is the current text. A boxing conversion does copy the struct (§10.2.9).

Boxing a value of a non-nullable-value-type consists of allocating an object instance and copying the value into that instance.

Yes, boxing conversions are involved. Yes, the struct is copied.

Yes, I know that structs are copied; it's just that ReferenceEquals returns false for a completely different reason. It would also return false for a single structure used as its parameters twice:
var x = new MyStruct();
object.ReferenceEquals(x, x); // returns false as well

so someone could be misled by the current statement; the "the structures are copied therefore ReferenceEquals returns false" implies that "well, so if they weren't copied, it would return true, right?"; nope, it wouldn't, because the parameters are boxed and two different objects are being reference-equal-ed.
If the example's aim is to prove that these are separate copies, then maybe it after the assignment, the first variable could be changed and the example could show that the second variable remains unchanged.


current_temperature reported as NULL

Home Assistant version
2021.2.3
SmartIR version
1.16.1
SmartIR configuration

- platform: smartir
  name: AC
  unique_id: ac
  device_code: 1341
  controller_data: remote.rm_pro_remote
  temperature_sensor: sensor.small_room_temperature
  humidity_sensor: sensor.small_room_humidity
  # power_sensor: binary_sensor.ac_power

Describe the bug
current_temperature reported as null
Debug log
hvac_modes: off, cool, heat
min_temp: 18
max_temp: 32
target_temp_step: 1
fan_modes: low, med, high
current_temperature: null
temperature: 22
fan_mode: low
last_on_operation: heat
device_code: 1341
manufacturer: Tadiran
supported_models: TAC490
supported_controller: Broadlink
commands_encoding: Base64
friendly_name: AC
supported_features: 9

Found the reason, the temperature_sensor should be sensor.small_room_temperature_temperature