Proper Overscan Support For Arnold

We need to update the documentation in include/GafferScene/Private/IECoreScenePreview/Renderer.h, to replace cropWindow with renderRegion. This might be a good spot to also document our intention to move it to use the gaffer window convention soon.

Closing this one, since I already merged it manually in b19e89cd18cbf02328524a93d98afddde7872a29.


TypeScript error in Custom client example

I'm getting a TypeScript error when I use this code from https://nuxt-open-fetch.vercel.app/advanced/custom-client in a new Nuxt project:
export default defineNuxtPlugin({
  enforce: "pre", // clients will be ready to use by other plugins, Pinia stores etc.
  setup() {
    const clients = useRuntimeConfig().public.openFetch;
    const localFetch = useRequestFetch();

    return {
      provide: Object.entries(clients).reduce(
        (acc, [name, options]) => ({
          ...acc,
          [name]: createOpenFetch(options, localFetch)

          // or add the logging:

          // [name]: createOpenFetch(localOptions => ({
          //   ...options,
          //   ...localOptions,
          //   onRequest(ctx) {
          //     console.log('My logging', ctx.request)
          //     return localOptions?.onRequest?.(ctx)
          //   }
          // }), localFetch)
        }),
        {}
      )
    };
  }
});

The error appears on the localFetch parameter to the createOpenFetch call. The error is:
Expected 1 arguments, but got 2

Reading through the page linked above I got two questions:

Is there a way to set headers on the outgoing request, for example a Authorization header?
Under what general circumstances would one need to disable the Nitro plugin and provide a custom fetch client?

Can't reproduce

I'm getting a TypeScript error when I use this code from https://nuxt-open-fetch.vercel.app/advanced/custom-client in a new Nuxt project:
export default defineNuxtPlugin({
  enforce: "pre", // clients will be ready to use by other plugins, Pinia stores etc.
  setup() {
    const clients = useRuntimeConfig().public.openFetch;
    const localFetch = useRequestFetch();

    return {
      provide: Object.entries(clients).reduce(
        (acc, [name, options]) => ({
          ...acc,
          [name]: createOpenFetch(options, localFetch)

          // or add the logging:

          // [name]: createOpenFetch(localOptions => ({
          //   ...options,
          //   ...localOptions,
          //   onRequest(ctx) {
          //     console.log('My logging', ctx.request)
          //     return localOptions?.onRequest?.(ctx)
          //   }
          // }), localFetch)
        }),
        {}
      )
    };
  }
});

The error appears on the localFetch parameter to the createOpenFetch call. The error is:
Expected 1 arguments, but got 2

Can't reproduce, please try to provide reproduction next time using Stackblitz/Codesandbox or Github repo.
I suspect you have old module version installed, try to upgrade.

Under what general circumstances would one need to disable the Nitro plugin and provide a custom fetch client?
Related to #43.

Please, check the docs here 🙂  - https://nuxt-open-fetch.vercel.app/advanced/custom-client.
Also, I activated the Discussions, you can ask any question there 💪


Abstraction for LAST_INSERT_ID() and similar functions

Are there plans to implement an abstraction for the last insert id feature? In mysql it looks like LAST_INSERT_ID() and in sqlite3 it looks like LAST_INSERT_ROWID(). I have not looked up the syntax for other databases.

Also, I wanted to thank the maintainers for this great project. It solved so many problems I was facing in my development/production environments and with the various nodejs orms.
Thanks so much guys for an awesome project :smile:

Nevermind, solving this should not be the responsibility of this library because it depends on what columns do and do not exist.


Callout Icon Dark Mode Color Issue

When using any dark theme, and using the pf2-compendium.css file, the symbol used for Reaction does not change to red like the other action symbols do.
Having a look at the css code, I found that on line 153, there's a missing space between the last of the svg data and the fill color data.
Manually adding the line in on my own CSS file allowed the symbol to switch to red on the theme entering dark mode.

Oh whoops. I'll get that fixed today :)


Welding tweaks

About the PR

Why / Balance

🐛, there was a discord issue on this but it's gone now.
Technical details

Fixes shards being weldable with an unlit welder.
Moved and renable WelderRefinableComponent and RefinableSystem
Minor cleanup of datafields, access and indentation

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Shouldn't be
Changelog

:cl:

fix: Glass shards are no longer weldable with an unlit welder.

shouldn't the welder code be checking for fuel regardless of if there is any cost to refine? Like if there's 0 fuel then won't it run out while refining?

I think it's a problem with the SharedToolSystem in this case
var doAfterArgs = new DoAfterArgs(EntityManager, user, delay / toolComponent.SpeedModifier, toolEvent, tool, target: target, used: tool)
 {
     BreakOnDamage = true,
     BreakOnMove = true,
     BreakOnWeightlessMove = false,
     NeedHand = tool != user,
     AttemptFrequency = fuel > 0 ? AttemptFrequency.EveryTick : AttemptFrequency.Never
 };

Since it's 0, it never raises an event.

SharedToolSystem.CanStartToolUse should still be checking that. Probably should be under ToolUseAttemptEvent.

Changed it so fuel is passed into ToolUseAttemptEvent, and that SharedToolSystem.Welder uses that event for its OnWelderToolUseAttempt. This fixes it and still makes it work for other things (construction, borg welding), with the small cavet that the pop-up messages don't seem to appear? This happens with the borg and glass shards.

Disregard the previous attempt, it broke things. Simplified it into simply adding a check in CanStartToolUse for the component and outting and checking that for AttemptFrequency as suggested.

Alright did some (major) changes but this works crisp now


New Relic Keys

This PR adds one new regex (with a test) plus two tests for existing regexes (per #150)
Happy Hacktoberfest!

Thanks for the tests too :D


Add concurrency limit to deploy job to avoid need to fail simultaneous deploys

What
Limit the number of deploy jobs that can be run at the same time using the concurrency key.
Why
Currently our deploy job cancels any other running deploys before proceeding with deploying its own branch. This works, but does mean that deploys that are cancelled will appear to fail, which is perhaps less than ideal. We could use the recently added concurrency feature to instead cause deploys to be queued up, without interrupting each other.
Other things to consider
We should be careful about where we place the concurrency limit, we want to avoid introducing race conditions that might result in the older PR being deployed after the newer PR. For instance, if the test job for the newer PR takes longer than the test job for the older PR, this could happen (I think). However, we probably also want to avoid putting uneccessary concurrency limits on PR checks, as this will make development slower.
Who needs to work on this
Developer
Who needs to review this
Developer, Tech lead?
Done when

[ ] Merging two PRs one after another rapidly does not result in a deploy failing
[ ] PRs are deployed in a correct order, every time

I tested this by triggering a manual deploy while another deploy workflow was running the build and test phase; I saw that the new deploy was pending and had the message 'This workflow is waiting on Deploy to complete before running'.
I tested this twice.

I'm not sure how to test whether this method ensures correct ordering, so I've removed that requirement.


DO-494: Refactor Azure to use resource groups

Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #889 (34bbf87) into testnet (54e9f6c) will decrease coverage by 1.85%.
The diff coverage is 82.73%.

:exclamation: Current head 34bbf87 differs from pull request most recent head dfdbf09. Consider uploading reports for the commit dfdbf09 to get more accurate results

@@             Coverage Diff             @@
##           testnet     #889      +/-   ##
===========================================
- Coverage    79.97%   78.12%   -1.85%
===========================================
  Files           50       68      +18
  Lines        10056    10766     +710
===========================================
+ Hits          8042     8411     +369
- Misses        2014     2355     +341

Impacted Files
Coverage Δ

node/src/benchmarking.rs
0.00% <0.00%> (ø)

node/src/chain_spec.rs
0.00% <0.00%> (ø)

node/src/cli.rs
35.71% <0.00%> (+1.16%)
:arrow_up:

node/src/command.rs
0.00% <0.00%> (ø)

node/src/main.rs
16.66% <ø> (ø)

node/src/rpc.rs
0.00% <0.00%> (ø)

node/src/service.rs
0.00% <0.00%> (ø)

node/src/service/nonce_monitor.rs
0.00% <0.00%> (ø)

pallets/creditcoin/src/migrations/mod.rs
0.00% <0.00%> (ø)

pallets/creditcoin/src/ocw.rs
96.00% <ø> (-0.50%)
:arrow_down:

... and 89 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Running benchmarks for regular commit - https://github.com/gluwa/creditcoin/actions/runs/3952834632/jobs/6768400236 - PASS
All jobs skipped, no failure for Auto-update weights commit - https://github.com/gluwa/creditcoin/actions/runs/3953050499/jobs/6768869236
This is now ready for review.


Add option to reset Expensify password from new bank account setup pane

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log into new.expensify.com and navigate to profile icon > Payments > Add Payment Method
Click Bank Account
Log into any bank account via Plaid
Select bank account from dropdown menu to see Enter Expensify password field appear. This is where we want to add the new option to reset password.

Desired Result:
On the page where Enter Expensify password appears, add an option to reset the Expensify password. It should appear as a blue hyperlink which says Forgot? Get a magic sign-in link!.
Actual Result:
Currently there is no option to reset password on that page (described in Step 4).
Workaround:
unknown
Platform:

Where is this issue occurring?

All

Version Number: v1.1.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/188564
Issue reported by: Internal
Slack conversation: https://expensify.slack.com/archives/C01966DBVLL/p1639082498315100?thread_ts=1638979187.291600&cid=C01966DBVLL
View all open jobs on GitHub

Posted to Upwork: https://www.upwork.com/jobs/~01087482f69cffd1bb

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@stephanieelliott Proposal
I would add this code bit for adding the link of resetting and magic link-
                    <View style={[styles.changeExpensifyLoginLinkContainer]}>                         <TouchableOpacity                             style={[styles.mt2]}                             onPress={Session.resetPassword}                             underlayColor={themeColors.componentBG}                         >                             <ExpensifyText style={[styles.link]}>                                 {this.props.translate('passwordForm.forgot')}                             </ExpensifyText>                         </TouchableOpacity>                     </View>
The component where this code needs to be added - src/components/AddPlaidBankAccount.js

In order to show you the working demo of the same, I would be needing test bank accounts if there is any/ or if there is some other way to get to that state.

@stephanieelliott What should happen when the user clicks that link?

Proposal
I've got a question on the feedback loop/navigation cycle after the link. But some pieces I've added in the proposal.

I will add a link that will be clickable

<TouchableOpacity
    style={[styles.mt2]}
    onPress={this.resetPassword}
    underlayColor={themeColors.componentBG}
>
    <ExpensifyText style={[styles.link]}>
        {this.props.translate('passwordForm.forgot')}
    </ExpensifyText>
</TouchableOpacity>

Add a function resetPassword which will internally call Session.resetPassword

    function resetPassword() {
       Session.resetPassword();

       // We will need to add feedback as well
    }

There needs to be a feedback too. In the Login section it redirects to the magic link page. I don't think that's the expected behavior here. We have a few options of showing the feedback:
a. Show a growl message in the AddPlaidBankAccount component.
b. Add an ExpensifyText component with the feedback message
c. Add the growl message in the Session.resetPassword function

What I am not sure about is once the user clicks, what happens to the current page. If go to the email and then click on the magic link to reset the password, will the user be redirected to the AddPlaidBankAccount page?

Sorry for the delay here in reviewing proposals. I am waiting for an answer to https://github.com/Expensify/App/issues/6877#issuecomment-999730666.

This is still being discussed in the Slack here. Based on where the discussion is now, this job is likely to change so let's hold off on any more proposals for now.

An update, the conversation is still active on slack.

Discussion still ongoing. A few different proposals at play, summarized here.

Sorry for the delay y'all. Since the main use case will be people on web mobile and web desktop, I think we should focus on those (at least to start).  I also think we should focus on using our existing tools and flows vs creating something new.
For both mobile and desktop web:

User forgets password while on the Bank Account screen
User clicks Magic link to get new password
Growl is surfaced to user letting them know the email/text has been send and that the user needs to click the link to reset their pass
User clicks magic link and is directed to the setpassword page.
User creates new password, clicks "Set password" then is redirected to where they previously left off at the bank account dropdown menu.
User either needs to enter pass again or not since they just created a new one the step before (unsure of this)

If the user has another tab opened on mobile or desktop web, they'll either be auto-signed in once the new password is created, they'll need to refresh to be signed in or they'll need to enter their new pass.  For mobile web, my guess is they won't ever specifically go back to the earlier open tab because they'll be able to complete the action they need to in their current tab.

Thanks, @mallenexpensify Open to proposals...based on the above requirements.

Doubled price to $500 and created new job, old one had expired https://www.upwork.com/jobs/~0152b68b2bb7a2e6df

My proposal here covers the requirement https://github.com/Expensify/App/issues/6877#issuecomment-999732939
@parasharrajat Can help me confirm if I am missing anything.
Need clarifications on:

then is redirected to where they previously left off at the bank account dropdown menu. (@AndrewGable confirmed this is possible - internal link)

Is this available by default or the current proposal needs to add it?

If the user has another tab opened on desktop web they'll be auto-signed in once the new password is created

We're saying the setpassword screen opens fine even if I am already logged in? Because if I do a password reset now? and I go to an existing tab, it redirects me to the homepage.
Or we're saying we need to update SetPassword page to allow opening even if I am already signedin?

Is this available by default or the current proposal needs to add it?

I can only think one way. use a redirect param in the magic link which we can use to redirect the user to the same page where the user clicked forgot pass.

Or we're saying we need to update SetPassword page to allow opening even if I am already signedin?

I think yes otherwise redirection will not work. Magin link will not open if a user is a login. You will have to copy that screen from Public routes to AuthScreens and then open that page over RHN. Maybe add a new route added for this if needed. Apart from it Create a new page that wraps PasswordForm without sign-in page layout.

use a redirect param in the magic link

I agree, that's the standard clean way. Will have to test on native once. But my question was is it available at the moment? Didn't understand when we say Possible means exists or doable.

Magic link will not open if a user is a login

Thanks for clarifying. I'll update the proposal to add these details.

Didn't understand when we say Possible means exist or doable.
No idea, better to ping on the same slack thread.

Is this available by default or the current proposal needs to add it?

@AndrewGable , can you help shine some light on "redirected to where they previously left off at the bank account dropdown menu" part from here?

If the user has another tab opened on desktop web they'll be auto-signed in once the new password is created

For the proposal for this issue, this isn't part of the deliverable or consideration.  I was just pointing out there wasn't a downside with the existing tab because it'll remain signed in.
Hope that helps ¯_(ツ)_/¯

I don't think redirecting to the bank account dropdown menu is possible, but I do not know if it's currently implemented or not.

Hey @thesahindia are you still working updating your proposal, or is it ready for @parasharrajat to review?
I think Manan is working on this
cc: @mananjadhav

Oops, sorry @thesahindia!
Hey @mananjadhav are you still working updating your proposal, or have you updated it and it is ready for review?

Sounds like @mananjadhav may not be working on this proposal anymore. Raised price $1000
https://www.upwork.com/jobs/~0152b68b2bb7a2e6df

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

I'm about to go OOO, so reapplied the label to assign this to another CM team member (thanks @puneetlath!)

@joekaufmanexpensify @kevinksullivan what should the UX be here after someone clicks that "reset password" link?

@mallenexpensify outlined the next steps for this change well here. So once the user clicks the password link, we'll want to:

Show a growl indicating that the reset link has been sent.
User clicks password reset link and is directed to change their password on setPassword page.
User sets new password and is directed back to where they were in the bank account set up flow (if possible).
User enters new password to complete bank account set up flow.

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

User sets new password and is directed back to where they were in the bank account set up flow (if possible).

@chiragsalian I think this part will need to be internal right?
Anyways, @mallenexpensify I'm about to head out on my two-month sabbatical, so handing this off to you in case it does remain External. Thanks!

Ah i guess we did get a bit sidetracked in this issue. I agree with @mallenexpensify that if we allowed validateCode to be entered manually then we should propose it as a new feature so for now let's not consider it. I like the steps proposed but how about we keep it simpler and not include step 3, only because atm we don't do more complex redirects in newDot (like redirecting to specific page once setPassword is complete). Its definitely possible but i'm not sure if its worth the gain here.
So how about we just do,

Show password forgot message and link.
If user clicks it we trigger API command ResetPassword  just the same way as the login page and show the user a message to check their email for the magic link.
Once user clicks on the link they go to password rest page on the SetPassword page.
Once the new password is entered they are just logged into the app and can go to the bank account flow to resume.

All of the above can be handled externally.
If we would like the link to allow them to reset password and have it go to a specific page then i think its best to create a follow-up issue since its mostly internal and at this time it might be best on slack if a link with complex redirecting is better or if we should allow the user to manually enter a validateCode. I think i vote the latter because even with a more complex link it opens a new tab with a new page (SetPassword), while i think its a better user experience to continue from the page they are in (like bankAccount login, enter validate code and continue).
If others agree i think we should update the desired result section of the OP so that contributors can share their proposal. Also not sure why this is daily, bumping it down to weekly (Feel free to update if anyone disagrees).

Sounds approachable to me @chiragsalian.

Thanks @chiragsalian !  I just doubled the price to $2000.  With your steps listed above, hopefully we'll be able to get this fixed and put it to bed soon.

I had posted a proposal here https://github.com/Expensify/App/issues/6877#issuecomment-999732939 which covered almost everything that is expected. I had one question on if there's any feedback/growl to be shown when the user clicks.

Proposal
We can add the code written below inside AddPersonalBankAccountPage to show the option to reset the link
<View style={[styles.changeExpensifyLoginLinkContainer]}>
                    <TouchableOpacity
                        style={[styles.mt2]}
                        onPress={resetPassword}
                    >
                        <Text style={[styles.link]}>
                            {props.translate('passwordForm.forgot')}
                        </Text>
                    </TouchableOpacity>
                </View>

We can use a state isValidationLinkFormVisible here when the user taps on forgot option we will call Session.resetPassword and will make the isValidationLinkFormVisible true and when isValidationLinkFormVisible is true will show the ResendValidationForm  component, we currently use this for forgot password option. This way we won't need to show a growl as we trying to not use the growl as much as we can.

Based on the new requirements, @mananjadhav 's proposal looks better.
But I have one question from all the contributors. I don't think that the app takes the user to the Setpassword page when the user is logined into the app.
So after step 3, how will you handle that?

But I have one question from all the contributors. I don't think that the app takes the user to the Setpassword page when the user is logined into the app.

We discussed somewhere in the comments but here are two options:

We copy the same route in AuthScreens as well (not recommended as the layout will be SigninPageLayout)
We create a new route with a new component, that is docked on the right modal and uses NewPasswordForm component. We could even move the code to common component for SetPasswordPage and AuthSetPasswordPage

@chiragsalian What are you thoughts on this :arrow_up: ?

I don't think that the app takes the user to the Setpassword page when the user is logined into the app.

Uff, good point. I like manana's suggested option 2, but yeah like manan said, at this point, we've to create a new route and component. Also, a bit of backend code to send a different route when the user is logged in. Hmm at this point I guess I'm wondering why not create a new component to accept validate code and no new route so the user will get the email to enter validateCode and then just continue where they left off. I guess both feel like new features to me and I'm not sure which one is the best.
I do like the route idea more but I feel like the pain point is I believe the link cannot directly open in the desktop app and if a user clicks on it will instead open a browser tab to continue their session there even if there is a desktop app open correct? I feel that's not an ideal user experience. Anyway curious to know if you guys have any thoughts on this?
Also @mallenexpensify, I was just curious about the ROI of this task. I'm mostly wondering if we feel like it's really worth it at this time because once logged in in oldDot we never really show forgot password anywhere unless I'm mistaken. Can you let me know if I'm mistaken or regardless of oldDot if we feel like this is a valuable flow for newDot? If it's valuable, it looks like the feature to enter your password is new and there are different flows (we would need a list of all the places this is there) where we have it so we might want to consider a more permanent solution.

Hmm at this point I guess I'm wondering why not create a new component to accept validate code and no new route so the user will get the email to enter validateCode and then just continue where they left off.

I feel like this is the best thing to do. In both approaches, we need backend changes so I think this one is better to do. If we are planning to add forgot password link in multiple places then it makes sense.

Took the discussion to slack.

Not doubling, lot of discussion in link above

@chiragsalian is keeping the convo alive! Waiting til we have a clear path before moving forward

@chiragsalian , if/when you're back from OOO, can you provide and update plz?

Yes, sry for the delay, the slack discussion resulted in a couple of thought but unfortunately no consensus. Discussed 1:1 with Matt about next steps yesterday. I feel its best to post in whats-next so that we can have more eyes on this to reach a decision.
Before i post though i've asked bondy if he's free in the next few days to discuss the vulnerability report he received to determine how valuable the issue is at this time. Removing label external until we can figure out next steps.

Discussed with @bondydaa, he mentions the original issue is not valid anymore and said that we moved authToken cookies to secure, http-only cookies so in theory an attacker shouldn't be able to get an authToken via an XSS exploit anymore.
Closing issue for now. Bondy mentioned he'll talk to cole to figure out the next PEN testing and if the results show this feature is still needed then we'll decide the next steps here.

Checking internally about potential compensation for this issue since work/research/reviews have been done
https://expensify.slack.com/archives/C02NK2DQWUX/p1649707752228549

@parasharrajat does $500 seem fair for your C+ contributions on this issue the past few months?

Yeah, that would be fine. Thanks.

Can you accept the offer here Rajat https://www.upwork.com/jobs/~0152b68b2bb7a2e6df
and post a comment when you have?

I just accepted it.

Paid Rajat!


RBAC SSO enabled argo can read secret

Summary
What happened/what you expected to happen?
I have argo installed (3.1.8, via helm) with RBAC SSO enabled. I want to have 2 User-Groups (ServiceAccounts):
sd

user who can only handle the basics
admin-user who can also read argo-server-sso-Secret which contains ClientID and ClientSecret for OIDC

Every logged in user should be in group 'user', only those in OIDC-group 'ADMIN' should be in 'admin-user'.
Therefore I configured the following:
### User
apiVersion: v1
kind: ServiceAccount
metadata:
  name: user
  namespace: argo
  annotations:
    # always true, if user is logged in
    workflows.argoproj.io/rbac-rule: "1 < 2"
    workflows.argoproj.io/rbac-rule-precedence: "0"

### Admin
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: admin-user
  namespace: argo
  annotations:
    # only true, if user is in group 'ADMIN'
    workflows.argoproj.io/rbac-rule: "'/ADMIN' in groups"
    workflows.argoproj.io/rbac-rule-precedence: "1"

Once I'm logged in as user (as printed in User Info), I expected the following workflow to fail:
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: print-secret
  namespace: argo
spec:
  entrypoint: print-secret
  templates:
    - name: print-secret
      container:
        name: main
        image: 'alpine'
        command:
          - sh
          - '-c'
        args:
          - ' echo $CLIENT_SECRET; '
        env:
          - name: CLIENT_SECRET
            valueFrom:
              secretKeyRef:
                name: argo-server-sso
                key: clientSecret

However it did print the secret.
Diagnostics
$ kubectl auth can-i --list --as=system:serviceaccount:argo:user -n argo

Resources                                       Non-Resource URLs                     Resource Names   Verbs
*.*                                             []                                    []               [*]
                                                [*]                                   []               [*]
cronworkflows.argoproj.io                       []                                    []               [create get list watch update patch delete]
eventsources.argoproj.io                        []                                    []               [create get list watch update patch delete]
sensors.argoproj.io                             []                                    []               [create get list watch update patch delete]
workfloweventbindings.argoproj.io               []                                    []               [create get list watch update patch delete]
workflows.argoproj.io                           []                                    []               [create get list watch update patch delete]
workflowtemplates.argoproj.io                   []                                    []               [create get list watch update patch delete]
selfsubjectaccessreviews.authorization.k8s.io   []                                    []               [create]
selfsubjectrulesreviews.authorization.k8s.io    []                                    []               [create]
pods/exec                                       []                                    []               [get list watch delete]
pods/log                                        []                                    []               [get list watch delete]
pods                                            []                                    []               [get list watch delete]
serviceaccounts                                 []                                    []               [get list]
secrets                                         []                                    [sso]            [get update create]
events                                          []                                    []               [get watch list create patch]
configmaps                                      []                                    []               [get watch list]
                                                [/.well-known/openid-configuration]   []               [get]
                                                [/api/*]                              []               [get]
                                                [/api]                                []               [get]
                                                [/apis/*]                             []               [get]
                                                [/apis]                               []               [get]
                                                [/healthz]                            []               [get]
                                                [/healthz]                            []               [get]
                                                [/livez]                              []               [get]
                                                [/livez]                              []               [get]
                                                [/openapi/*]                          []               [get]
                                                [/openapi]                            []               [get]
                                                [/openid/v1/jwks]                     []               [get]
                                                [/readyz]                             []               [get]
                                                [/readyz]                             []               [get]
                                                [/version/]                           []               [get]
                                                [/version/]                           []               [get]
                                                [/version]                            []               [get]
                                                [/version]                            []               [get]

What Kubernetes provider are you using?
What version of Argo Workflows are you running?
3.1.8
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
k8sapi
Did this work in a previous version? I.e. is it a regression?
installed on clean cluster

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

The workflow will pass if the pod's service account has permission to read secrets, which is must have. Looking at the workflows, you did not specify the service account, so it will use the default service account.
kubectl auth can-i --list --as=system:serviceaccount:argo:default -n argo

The SSO setting are irrelevant to this.

However default does not seem to have permissions to read secrets:
$ kubectl auth can-i --list --as=system:serviceaccount:argo:default -n argo
Resources                                       Non-Resource URLs                     Resource Names   Verbs
*.*                                             []                                    []               [*]
                                                [*]                                   []               [*]
selfsubjectaccessreviews.authorization.k8s.io   []                                    []               [create]
selfsubjectrulesreviews.authorization.k8s.io    []                                    []               [create]
                                                [/.well-known/openid-configuration]   []               [get]
                                                [/api/*]                              []               [get]
                                                [/api]                                []               [get]
                                                [/apis/*]                             []               [get]
                                                [/apis]                               []               [get]
                                                [/healthz]                            []               [get]
                                                [/healthz]                            []               [get]
                                                [/livez]                              []               [get]
                                                [/livez]                              []               [get]
                                                [/openapi/*]                          []               [get]
                                                [/openapi]                            []               [get]
                                                [/openid/v1/jwks]                     []               [get]
                                                [/readyz]                             []               [get]
                                                [/readyz]                             []               [get]
                                                [/version/]                           []               [get]
                                                [/version/]                           []               [get]
                                                [/version]                            []               [get]
                                                [/version]                            []               [get]

There are no rolebindings for default:
$ kubectl get rolebinding -n argo -o json | jq -r '.items[] | select(.subjects[] | [.kind, .name] == ["ServiceAccount","default"]) | .metadata.name'

secrets                                         []                                    [sso]            [get update create]

Looks like it has all permissions on all objects to me? Aside - do not run the server (or anything else) as the default service account.

This permission is only on secret named 'sso'...


[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\3ggw-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\kjlt-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\sblc-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\ovzn-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\bkiw-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\ksrt-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\mdpx-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\sowh-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\1ldd-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\pr3i-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\g03l-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\pdoy-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\hc5q-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\x35c-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\u2r3-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\dgq4-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\052u-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\4gzg-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\h3uy-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\xmob-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\hles-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\gloe-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\azxb-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\1han-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\3b4y-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\2yt0-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\mlrz-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\zqfv-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\fswn-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\c2uo-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\ytwk-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\ab1v-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\me5u-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\u334-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\3l4r-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\ybjo-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\euc1-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\nczm-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\noff-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\jff4-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\phyp-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\h4g4-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\na2y-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\50xj-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\piuo-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\weg3-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\jlap-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\11ii-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\05lc-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\1agd-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\4vfh-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\siqq-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\yxh3-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\qcgx-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\pq14-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\tblx-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\0xuq-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\52rs-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\n254-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\r0mo-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\rjj3-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\j0z4-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\ckhi-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/openpublishtest/docs, working directory: W:\jn1t-s, target branch: master, target branch commit: 779081b220e78579e0f21279ac7bc87cf89f9833, source branch: master-sync-work, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix cacheCleanUp in s3Cache script

@djspiewak and @alissapajer, since cacheCleanUp won't run in this PR, maybe we  can just go ahead and merge?

@nicflores the only reason I'd hold back on merging until the build is green is to make sure that PR cache cleanup still works.


[FEATURE] Onboard notifications sanity tests

New plugin
https://github.com/opensearch-project/notifications/tree/main/dashboards-notifications

Shall we add 2.0.0 label for this issue?


FLIN-169 Optimization of docker image

Describe your changes
The issue was that when making a change in the java code and running
docker compose up -d --build

Would rerun mvn clean package and install all the dependencies again. On my computer this took about 1 minute.
To fix this I added an extra step in Dockerfile.flink which installs the dependencies:
RUN mvn -B dependency:resolve-plugins dependency:resolve clean package

Docker then caches this, so if we make no changes to the pom.xml files the dependencies will not be installed again. This halfed the time it took to rebuild the project for me. If you are on a slower internet the effects will be even better.
However, there were also inefficiencies in the flink_start.sh files. (Running code that does not have to be run more than once if the topics are created...).
I added code to optimize this file.
This makes the build process much more effective
Github issue this pull requests addresses
Closes issue FLIN-169
Checklist before requesting a review

[X] I have performed a self-review of my code
[X] I have updated/created the corresponding documentation

love you @VegSja now takes 5.858 on my machine <3
Does this fix also the problems wrt running on WLS? I would start merging this anyway...


Meeting area

Proposal Title
Meeting area
Context and Problem Statement
Need a virtual world to meet.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
Need to be in VR more.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
Hub world with a glass whiteboard to do meetings with some private alcoves.
If this enhancement will not be used often, can it be worked around with a few lines of script?
Core
Positive Consequences
No response
Negative Consequences
No response
Is there a reason why this should be core and done by us?
I know how this worlds
References
No response
Derivative License
Copyright (c) 2020-2021 V-Sekai contributors.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

8535a28d85ae113c6a1a7e8e89ff4486799587f9


Exception while reading from Swagger URL

I'm trying to parse an OPEN API URL and getting an error in the following line
OpenAPI openAPI = new OpenAPIV3Parser().read("https://petstore3.swagger.io/api/v3/openapi.json");
the exception is
org.springframework.web.util.NestedServletException: Handler dispatch failed; nested exception is java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/JsonFactoryBuilder
Dependency added is
<dependency> <groupId>io.swagger.parser.v3</groupId> <artifactId>swagger-parser-v3</artifactId> <version>2.0.19</version>

Hi, I haven't been able to reproduce this issue, please send us a PR with a test showing the issue, so we can work on it, thanks!


ESlint error

ESlint doesn't works properly

Should be proper documentation for it, also should be configurable


Wrong loss calculation with multi-output models when using model.fit.

System information

Have I written custom code: Yes, though the code sample below is adapted from an official tensorflow tutorial with minimal changes.
OS Platform and Distribution: Ubuntu 18.04
TensorFlow installed from: official pip package, version 2.1.0
Python version: 3.6.9
CUDA/cuDNN version: CUDA 10.1, GTX 1070

Describe the current behavior
Consider the following mnist example
import numpy as np
import tensorflow as tf

inputs = tf.keras.Input(shape=(784,), name='digits')
x = tf.keras.layers.Dense(64, activation='relu', name='dense_1')(inputs)
x = tf.keras.layers.Dense(64, activation='relu', name='dense_2')(x)
outputs = tf.keras.layers.Dense(10, name='predictions', activation='softmax')(x)
model = tf.keras.Model(inputs=inputs, outputs=outputs)

model.compile(
    optimizer=tf.keras.optimizers.SGD(),
    loss={"predictions": tf.keras.losses.SparseCategoricalCrossentropy()},
    metrics=[tf.keras.metrics.SparseCategoricalAccuracy(name="accuracy")],
)

(x_train, y_train), (x_test, y_test) = tf.keras.datasets.mnist.load_data()
x_train = x_train.reshape(60000, 784).astype('float32') / 255
x_test = x_test.reshape(10000, 784).astype('float32') / 255
y_train = y_train.astype('float32')
y_test = y_test.astype('float32')

x_val = x_train[-10000:]
y_val = y_train[-10000:]
x_train = x_train[:-10000]
y_train = y_train[:-10000]

train_dataset = tf.data.Dataset.from_tensor_slices((x_train, y_train))
train_dataset = train_dataset.shuffle(buffer_size=1024).repeat().batch(64)

val_dataset = tf.data.Dataset.from_tensor_slices((x_val, y_val))
val_dataset = val_dataset.batch(64, drop_remainder=True)

test_dataset = tf.data.Dataset.from_tensor_slices((x_test, y_test))
test_dataset = test_dataset.batch(64)

model.fit(train_dataset, epochs=3, steps_per_epoch=1000, validation_data=val_dataset)

The output is
Epoch 1/3
1000/1000 [==============================] - 4s 4ms/step - loss: 0.9192 - accuracy: 0.7615 - val_loss: 0.4060 - val_accuracy: 0.8914
Epoch 2/3
1000/1000 [==============================] - 3s 3ms/step - loss: 0.3786 - accuracy: 0.8939 - val_loss: 0.3147 - val_accuracy: 0.9127
Epoch 3/3
1000/1000 [==============================] - 3s 3ms/step - loss: 0.3211 - accuracy: 0.9080 - val_loss: 0.2796 - val_accuracy: 0.9196

This works just fine as the loss decreases and the accuracy increases.
However, if I simply add another dummy output to the model, the training will become erroneous. Let's just change the model definition line to model = tf.keras.Model(inputs=inputs, outputs=[x, outputs])
Now the output is:
WARNING:tensorflow:Output dense_2 missing from loss dictionary. We assume this was done on purpose. The fit and evaluate APIs will not be expecting any data to be passed to dense_2.
Epoch 1/3
WARNING:tensorflow:Gradients do not exist for variables ['predictions/kernel:0', 'predictions/bias:0'] when minimizing the loss.
WARNING:tensorflow:Gradients do not exist for variables ['predictions/kernel:0', 'predictions/bias:0'] when minimizing the loss.
1000/1000 [==============================] - 4s 4ms/step - loss: 5.7781 - predictions_loss: 5.7781 - predictions_accuracy: 0.1048 - val_loss: 5.5196 - val_predictions_loss: 5.5196 - val_predictions_accuracy: 0.1243
Epoch 2/3
1000/1000 [==============================] - 4s 4ms/step - loss: 5.3866 - predictions_loss: 5.3866 - predictions_accuracy: 0.1202 - val_loss: 5.2255 - val_predictions_loss: 5.2255 - val_predictions_accuracy: 0.0967
Epoch 3/3
1000/1000 [==============================] - 4s 4ms/step - loss: 5.1167 - predictions_loss: 5.1167 - predictions_accuracy: 0.0996 - val_loss: 5.1479 - val_predictions_loss: 5.1479 - val_predictions_accuracy: 0.0992

Basically the network is not trained at all because as the warning says: Gradients do not exist for variables ['predictions/kernel:0', 'predictions/bias:0'] when minimizing the loss.
Describe the expected behavior
The expect behavior is that by adding additional outputs to the model should not affect the training process in anyway. Note that in model.compile, I specified the loss function using a dictionary, so I don't need to modify the rest of the code after adding a dummy output.

Update
I just found out that, if you alter the order of the outputs by doing model = tf.keras.Model(inputs=inputs, outputs=[outputs, x]), they the script works as expected. This means the first loss object you give will always be associated with the first output.
I would say this is still a bug because the purpose of passing a dictionary to loss is to make everything explicit, so I don't have to worry about the order. This should work like python kwargs.

@Hongtao-Niro,
I was able to reproduce the error with TF 2.1. However, the issue seems to be fixed in TF-nightly. Please find the gist of it here. Thanks!

Thanks!


Kconfig:Add an option to disable compilation of floating point

Summary
Add an option to disable compilation of floating point
Impact
libs/libc
Testing
qmue with mps3an547
some platform can't use float

[Experimental Bot, please feedback here]
This Pull Request appears incomplete based on the provided NuttX requirements.
Here's why and what's missing:

Summary:

Missing:

WHY is this change necessary? What are the benefits of disabling floating-point compilation? (e.g., reduced code size, targeting platforms without FPU support).
HOW exactly does the change work? What mechanism is used to disable floating-point? (e.g., compiler flag, configuration option)

Impact:

Incomplete:

Impact on user:  While stating "some platforms can't use float" hints at the reason, you need to be explicit. Will users need to change their code if they rely on floating-point operations? How will this affect existing applications?
Impact on build: How does this change the build process? Is there a new configuration option?
Impact on hardware: Be specific about which architectures/boards are affected.
Impact on documentation: If this introduces a new option, documentation MUST be updated. State that you've done so or that it's needed.

Unclear/Missing:

Impact on security: Are there any potential security implications of disabling floating-point? (e.g., related to numerical stability or calculations).
Impact on compatibility:  Will this break compatibility with any existing code or libraries that rely on floating-point?

Testing:

Insufficient:

Build Host(s): Provide details about your build host operating system, CPU architecture, and compiler version.
Target(s):  "qemu with mps3an547" is not enough. Specify the QEMU version, the exact MPS3 board configuration being emulated, and any relevant details about the simulated environment.
Testing logs:  You need to provide actual testing logs (both before and after the change).  These logs should demonstrate that the change works as intended and doesn't introduce regressions.

To improve this PR:

Expand on the Summary:  Clearly articulate the motivation, benefits, and technical implementation of the change.
Complete the Impact assessment:  Address all points, being specific and detailed about the consequences of this change.
Provide comprehensive Testing information: Include specific details about your build and target environments, and most importantly, include actual testing logs that validate your changes.


chore(main): release 1.14.3

:robot: I have created a release beep boop
1.14.3 (2024-06-09)
🐛 Bug Fixes

configure release please (dccc287)
disable release tags (e15a978)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/AlbertHernandez/typescript-library-template/releases/tag/v1.14.3 :sunflower:


[DO NOT MERGE] Run tests against latest Conda (4.5)

There haven't been any commits here since April 2017, so the last time tests were run was against conda 4.3.16. Conda 4.4 seems to have broken things (see #73, #79), so this PR is here just to capture that in testing.

Hmm... the tests still pass because Travis seems to be using a cached copy of the installer at https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh
When I download that URL on my machine I get 4.5.1 (which I would expect to fail), but Travis-CI reports a conda version of 4.3.16 during testing. I'll open an issue to request an update of testing.

OK! With that change to .travis.yml, this PR is now testing against conda 4.5.4 (according to conda info during the Travis run), and the tests are still passing. (Including npm tests that apparently look for conda GUI elements in rendered notebooks).
This means that the testing environment is not capturing the breakage reported at #73,  or jupyterlab/jupyterlab/issues/4598. I'm somewhat stumped; @benbovy any insight?

I think this is because of this: https://github.com/Anaconda-Platform/nb_conda_kernels/blob/f7b468090fc2f7fbf1dd56fe875f3e5c28051aa9/.travis.yml#L31
The conda executable is still found. I guess tests will not pass if for example you replace this line by
. $HOME/miniconda/etc/profile.d/conda.sh

You probably have to also replace source activate nb_conda_kernels by conda activate nb_conda_kernels.
In #73 I probably should update travis config and add a regression test...

That's certainly it, I'll try it out in this PR (unfortunately that's the only way I know of to run tests).

Hooray, the tests failed 😄!  (For the right reason--notebook couldn't start)
From Travis log line 1641 https://travis-ci.org/Anaconda-Platform/nb_conda_kernels/jobs/383914096:
Timeout for http://localhost:8888/a@b/
Is the notebook server running?

PS: I think I found another reference to the conda executable, in nb_conda/handlers.py:211
cmdline = 'conda search --json'.split()
If you can take a look at that one too that'd be great, if not I'll file an issue over there somewhere.

Coverage remained the same at 47.985% when pulling af560d68e250230c3b1ca11587460335e07eacf0 on tjd2002:empty-run-tests into f7b468090fc2f7fbf1dd56fe875f3e5c28051aa9 on Anaconda-Platform:master.

Coverage remained the same at 47.985% when pulling af560d68e250230c3b1ca11587460335e07eacf0 on tjd2002:empty-run-tests into f7b468090fc2f7fbf1dd56fe875f3e5c28051aa9 on Anaconda-Platform:master.

Coverage remained the same at 47.985% when pulling af560d68e250230c3b1ca11587460335e07eacf0 on tjd2002:empty-run-tests into f7b468090fc2f7fbf1dd56fe875f3e5c28051aa9 on Anaconda-Platform:master.

Yes, because conda 4.5 no longer puts conda in the PATH, nb_conda_kernels has to jump through some hoops in order to determine how to call conda info --json. I'm addressing these issues in #80 (among other things). Note that you have to be extra careful to get this right if nb_conda_kernels is installed in an environment other than base.
But note that I am not an official contributor to the package (though I know the people who are ;-)) so I can't say for sure that my work will get in there. We might want to break that out separately.

If you're working on this, I would recommend building a basic conda recipe into the repository itself. At the very least, this repo needs to own and control the post-link and pre-unlink scripts that are now found here instead.

[Apologies for the PR spam just now.] It seems like these issues cut across all the conda notebook extensions--It would be good to open an issue to discuss how all of them should deal with the transition to 4.4+ (including testing and backwards-compatibility). Perhaps the best place to do that is at the Anaconda-Platform/anaconda-nb-extensions meta-package repo?

Further discussion at Anaconda-Platform/anaconda-nb-extensions#168


Adding parametric model and training scripts

I just added my pit.py and test_pit.py modules to your pull request.

Looks good to me. Merging.