NIAP APE_REQ.2-7 Assessment of HCD cPP

As part of NIAP’s review process of the HCD cPP, we performed an evaluation of the APE work units and identified several needing correction. Please see the following comments:
APE_REQ.2-7, The evaluator shall examine the statement of security requirements to determine that all selection operations are performed correctly. --
General inconsistency with regards to whether or not "selection:" prompt is bolded
The following are examples of incorrect conventions for selections; there are other instances throughout the document.
FAU_GEN.1.1, b. - "not specified" should be in square brackets and not bold as it is a completed selection
FAU_STG.1.2 - "prevent" is a completed selection and should be in square brackets rather than bolded
FCS_CKM.4.1 - All bullets should be italicized as they are operations that need to be completed by the author
FCS_CKM.4.1 - 'no standard' does not need a selection prompt because the PP author has filled out the selection in a way that the ST author has no choice to make
FCS_CKM.1.1/SKG - close bracket is italicized
FCS_COP.1.1/DataEncryption - All selection text should be italcized as they are operations that need to be completed by the author
FCS_COP.1.1/SigGen - All selection text should be italicized as they are operations that need to be completed by the author
FCS_COP.1.1/Hash - refined selection is not italicized
FCS_RBG_EXT.1.2 - selection text not italidized in all cases
FIA_PMG_EXT.1.1 - selection text not italicized in all cases
FTP_ITC.1.2 'the TSF, or the authorized IT entities' is a completed seleciton and should be unitalics and in brackets
FTP_TRP.1.1/NonAdmin - "remote" and "disclosure and detection of modification of the communicated data" should be in square brackets and italicized; they are completed selections by the author

Observation/comment on the following NIAP comments:

FTP_ITC.1.2 'the TSF, or the authorized IT entities' is a completed selection and should be unitalics and in brackets.

According to section 5.1. “Conventions” in the HCD cPP, for FTP_ITC.1.2:
a) The words “the TSF” is a completed selection and should be in [square brackets] and not bolded.
b) “or the authorized IT entities” is not the same as “another trusted IT product” in CC Part 2, where the original selection is modified. Therefore, it is considered as a refinement and should remain to be bold.

FTP_TRP.1.1/NonAdmin - "remote" and "disclosure and detection of modification of the communicated data" should be in square brackets and italicized; they are completed selections by the author.

According to section 5.1. “Conventions” in the HCD cPP, for FTP_TRP.1.1/NonAdmin:
a) “remote” is a completed selection and should be in [square brackets].
b) “disclosure” is a completed selection and should be in [square brackets].
c) “and detection of modification of the communicated data” is completion of assignment and should be in [Bold text within square brackets]

This issue is addressed by the following TD:

HCD0002

The TD above is located at the following location:

https://github.com/HCD-iTC/HCD-iTC-Template/tree/Working/TD


Training using Python API

Hi everybody,
I need to train an image generation model using a Python script similar to this tutorial from the MMSegmentation library. I tried to replicate that example using the code in the train.py file, but it fails when trying to run the train_model function with following error: 'MMDataParallel' object has no attribute 'reducer'.
At issue #26, the devs recommend executing dist_train.sh instead of train.py file, but this solution uses a bash command, and I need to use only Python code.
Is there a way to train an MMGeneration model using just a Python script? Besides, it would be awesome to have a tutorial example on Google Colaboratory like the one from the MMSegmentation library.
Many thanks.

This url is a Google Colab tutorial for MMGeneration and we will merge these to our repo later.
To train model with python API, you can use the following code:
import torch
from mmcv import Config
from mmgen.core.ddp_wrapper import DistributedDataParallelWrapper
from mmgen.core.optimizer import build_optimizers
from mmgen.models import build_model
from mmgen.datasets import build_dataloader, build_dataset

import os
import torch
import torch.distributed as dist

def setup(rank, world_size):
    os.environ['MASTER_ADDR'] = 'localhost'
    os.environ['MASTER_PORT'] = '12355'

    # initialize the process group
    dist.init_process_group("gloo", rank=rank, world_size=world_size)

def cleanup():
    dist.destroy_process_group()

def main():
    config_path = ('./configs/sagan/sagan_32_wReLUinplace_'
                   'lr-2e-4_ndisc5_cifar10_b64x1.py')

    cfg = Config.fromfile(config_path)
    model = build_model(
        cfg.model, train_cfg=cfg.train_cfg, test_cfg=cfg.test_cfg)
    find_unused_parameters = cfg.get('find_unused_parameters', False)
    # for static training
    optimizer = build_optimizers(model, cfg.optimizer)

    model_ddp = DistributedDataParallelWrapper(
        model.cuda(),
        device_ids=[torch.cuda.current_device()],
        broadcast_buffers=False,
        find_unused_parameters=find_unused_parameters)

    datasets = [build_dataset(cfg.data.train)]
    loader_cfg = dict(
        samples_per_gpu=cfg.data.samples_per_gpu,
        workers_per_gpu=cfg.data.workers_per_gpu,
        # cfg.gpus will be ignored if distributed
        num_gpus=1,
        dist=True,
        persistent_workers=cfg.data.get('persistent_workers', False),
        seed=42)
    train_loader_cfg = {**loader_cfg, **cfg.data.get('train_dataloader', {})}
    data_loaders = [
        build_dataloader(ds, **train_loader_cfg) for ds in datasets
    ]
    train_loader = data_loaders[0]

    for idx, data_batch in enumerate(train_loader):
        outputs = model_ddp.train_step(data_batch, optimizer)
        if idx == 5:
            break

if __name__ == '__main__':
    setup(0, 1)
    main()
    cleanup()

Hi @LeoXing1996, thanks for the quick answer!
I tried your solution but it seems that the model artifacts (checkpoint and logs files) are not automatically saved at the cfg.work_dir directory. I would like to train the model as follows:
import wget
import torch
import mlflow
import os.path as osp
import mmcv
from mmcv import Config
from mmgen import __version__
from mmgen.apis import train_model
from mmgen.datasets import build_dataset
from mmgen.models import build_model

# Dir paths
dataset_dir = '/content/dataset'
work_dir = '/content/work_dir'
ckpt_path = '/content/checkpoint'

# Update configuration file
config_file = '/mmgen/configs/styleganv2/stylegan2_c2_lsun-car_384x512_b4x8.py'
cfg = Config.fromfile(config_file)
cfg.log_config.hooks = [dict(type='TextLoggerHook', by_epoch=False),
                        dict(type='MlflowLoggerHook', log_model=False)]
aug_kwargs = dict(xflip=1, rotate90=1, xint=1, scale=1, rotate=1, aniso=1,
                  xfrac=1, brightness=1, contrast=1, lumaflip=1, hue=1,
                  saturation=1) # BGC augmentation pipeline
cfg.model.discriminator = dict(type='ADAStyleGAN2Discriminator',
                               in_size=512,
                               data_aug=dict(type='ADAAug',
                                             aug_pipeline=aug_kwargs,
                                             ada_kimg=100))
cfg.data.train.dataset.imgs_root = dataset_dir
cfg.data.val.imgs_root = dataset_dir
cfg.work_dir = work_dir
cfg.gpu_id = 0
cfg.gpu_ids = range(1)
cfg.seed = 2021
if torch.cuda.is_available():
    cfg.device = 'cuda:0'
else:
    cfg.device = 'cpu'

# Download a pre-trained model
mmcv.mkdir_or_exist(osp.abspath(ckpt_path))
checkpoint_url = 'https://download.openmmlab.com/mmgen/stylegan2/official_weights/stylegan2-car-config-f-official_20210327_172340-8cfe053c.pth'
cfg.load_from = wget.download(checkpoint_url, out=ckpt_path)

# Build the model
model = build_model(cfg.model, train_cfg=cfg.train_cfg, test_cfg=cfg.test_cfg)

# Build the dataset
datasets = [build_dataset(cfg.data.train)]

# Create work_dir
mmcv.mkdir_or_exist(osp.abspath(cfg.work_dir))

# Train the model ('MMDataParallel' object has no attribute 'reducer')
train_model(model, datasets, cfg, distributed=False, validate=False, meta=dict())

Could you please show me how to get the mentioned artifacts (saved at cfg.work_dir) using the Python API?

You should add CheckpointHook and work_dirs in cfg at the start of your code.
checkpoint_config = dict(interval=5000, by_epoch=False, max_keep_ckpts=10)
cfg.checkpoint_config = checkpoint_config

cfg.work_dir = 'my-work-space'

Thanks for replying!


mockRestore doesn't restore spied on properties to their original values

Describe the bug
When using vi.spyOn() to create function mocks, the spy.mockRestore(), vi.mockRestoreAllMocks() doesn't actually restore the original descriptor of the spied-on object. This can lead to tests being written without ensuring that a method was already mocked, and deviates from Jest's equivalent behavior.
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-csdybj?file=test%2Fbasic.test.ts
test('should restore a spy', () => {
  const originalImpl = instance.fn1;
  const spy = vi.spyOn(instance, 'fn1');
  instance.fn1();
  spy.mockRestore();
  expect(instance.fn1).toEqual(originalImpl); // fails
});

test('should fail because it doesn\'t set up a spy', () => {
  instance.fn1();
  expect(instance.fn1).toHaveBeenCalledOnce(); // doesn't throw
});

System Info
System:
    OS: macOS 12.6.3
    CPU: (10) arm64 Apple M1 Pro
    Memory: 88.91 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.19.1 - ~/.local/share/homebrew/bin/node
    Yarn: 3.4.1 - ~/.local/share/homebrew/bin/yarn
    npm: 8.19.3 - ~/.local/share/homebrew/bin/npm
  Browsers:
    Firefox: 102.2.0
    Safari: 16.3

envinfo doesn't seem to work with my project's setup (Yarn 3 monorepo), here are my vitest versions:
    "vite": "^4.2.1",
    "vitest": "^0.29.8"

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is technically intended behavior. I am not sure if it's the right behavior, but removing a spy breaks module mocking as far as I remember. If someone has time to investigate the consequences of this change, be my guest.

vi.restoreAllMocks docs says

Will call .mockRestore() on all spies. This will clear mock history and reset its implementation to the original one.

For me, it doesn't sound correct - spies aren't reset to the original state, they preserve the mocked one (which is not expected).


development: /s/name/pname&version/

Motivation for this change
#103997
continuation of #126894
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

is this preferred to be merged into master? or any package, that should get separated?

is this preferred to be merged into master? or any package, that should get separated?

I only asked to target staging with this one bcause of the mass rebuild. We do not want to rebuild 5001+ packages when merging into master.

i know, that this has many rebuilds, but is there anything more to do?

@Stunkymonkey  / @SuperSandro2000 I wonder if either of you tried to build the changes from fetchurl to fetchFromGitHub? AT least two packages changed in this way don't build anymore (eventlog, tidyp) and I see others that maybe need testing or reverting also.

Going to take a look at the ones where the fetcher changed.


Unsupported operand types: string * int

I am using Laravel 10 version or Gemini 1.0 version but getting this error.
 public function index()
    {
        $result = Gemini::geminiPro()->generateContent('Hello');

        $result->text();
    }

Hello @tarun-pixeleyez,
Can you share the full error log?

Hii @aydinfatih
I just recieved Unsupported operand types: string * int error, when i run my index method.

When I try the same code, no error occurs. If you can share the trace logs here. We can catch something from these logs.

I am closing this issue as there is no reply. You can add a reply if the problem persists.

+1

use Gemini\Data\Blob;
use Gemini\Enums\MimeType;
use Gemini\Laravel\Facades\Gemini;
use Illuminate\Http\Request;

        $result = Gemini::geminiProVision()
            ->generateContent([
                'What is this picture?',
                new Blob(
                    mimeType: MimeType::IMAGE_JPEG,
                    data: base64_encode(
                        file_get_contents('https://storage.googleapis.com/generativeai-downloads/images/scones.jpg')
                    )
                ),
            ]);

        $result->text();

Found the solution. When the following variables are empty in the .env file it crash
#GEMINI_BASE_URL=
#GEMINI_REQUEST_TIMEOUT=
I commented them out and it's working. Hope it helps


clictune.com bypass not working

Link
https://www.dlink2.net/ix7b
Version
Manifest-v3
What browser(s) are you seeing the problem on?
Chrome browsers (includes brave, edge, opera, etc)
What platform are you seeing the problem on?
Computer (Windows, Linux, MacOS)
Anything else?
No response

Still able to reproduce.

it was fixed in #1169 sk you'll have to wait for the ext to be updated in the store or you can grab the chromium package from the latest pr and load it unpacked (and don't forget to ONLY have ONE FastForward installed)

Thanks for the reply! Then I assume this issue can be closed.

of course! if you want to, go ahead and close it

Well, I'm not the author of this issue. I'm but merely a subscriber XD.

it was fixed in #1169 so you'll have to wait for the ext to be updated in the store or you can grab the chromium package from the latest pr and load it unpacked (and don't forget to ONLY have ONE FastForward installed)

alright!


remove Project Template Permissions inhibition

Description
This PR removes the inhibition for projects to update template permissions.

Fixes: #7350

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 9942

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland I tested the below scenario in an env with a Simulator zone:

Create a normal user
Create a project
Create a template with admin account in a project
Share the template with the normal user

Now the normal user doesn't have access to the project.

Toggling the Projects button, I can see the template.

I couldn't deploy a VM via UI because I couldn't see the template while launching the VM.

I am not sure if this is intended or if this is another bug or an enhancement?

@DaanHoogland I tested the below scenario in an env with a Simulator zone:
1. Create a normal user

2. Create a project

3. Create a template with admin account in a project

4. Share the template with the normal user

...

I am not sure if this is intended or if this is another bug or an enhancement?

as discussed I think the deplpoy wizard can not handle the truth. I'll have a look. thanks @vishesh92

@vishesh92 , seemed trivial. I have now added the projectid=-1 parameter to the api call in the deploy wizard. Can you re-test/-check/-view?

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10036

@DaanHoogland Tested now. Able to launch a VM using the shared template.

Hi all, on my dev. environments I don't work with projects (and I'm not very familiar with this option). I don't see any available templates when using the deploy VM wizard because of the projectid=-1 in the API call. Should this be handled in the backend?

Hi all, on my dev. environments I don't work with projects (and I'm not very familiar with this option). I don't see any available templates when using the deploy VM wizard because of the projectid=-1 in the API call. Should this be handled in the backend?

No @slavkap I think another parameter needs to be set as well, or the the parameter needs to be optional (as in list templates)

@slavkap @DaanHoogland I have created a PR to fix this issue here: https://github.com/apache/cloudstack/pull/9196


chore: 이미지 컴포넌트 props에 onLoad 콜백을 추가합니다

onLoad를 추가했습니다

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.592%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4125

Relevant Lines:
5174

💛  - Coveralls


null out _unsubscribe after unsubscription

Description:
null out the unsubscribe callback after unsubscribing.
The any is kind of ugly but that is also how it's assigned in the constructor.
Related issue (if exists): Fixes #5464

Okay this seems to break tests, don't know enough to proceed. I'd appreciate if a maintainer could look at this bug 🙇

Could you add a test to show/prove that multiple unsubscribe calls are okay and that overwriting the _unsubscribe method in Subscriber with null - which is what this change will end up doing - behaves as expected?

Okay this seems to break tests, don't know enough to proceed. I'd appreciate if a maintainer could look at this bug.

It's likely related to my previous comment. I'll have a look at it. Thanks for the PR and the bug report.

@benlesh would you mind giving this a review when you have the chance? 🙌

@benlesh I've requested your review on this. It's a small change to Subscription to ensure that the reference to the teardown passed to the ctor is released/nulled upon unsubscription.
Felix's explanation for this is here. Given that the subscription implementation goes to so much effort to remove closed subscriptions, this kinda makes sense, to me.
FWIW, various attempts at implementing this change ran into the inheritance weirdness/abuse that you mentioned, recently. There is a comment regarding this where _unsubscribe is nulled.
Also, the tests that are added in this PR don't fail without the PR's change to the Subscription class. They were added when I was trying to figure out why nulling _unsubscribe was effecting failures in other tests. I couldn't see specific tests for unsubscribe idempotency, so I figured remain in the PR for inclusion in the test suite.


auto add support to newest Xcode

modify downloaded plug-in info.plist to make plug-in auto support
newest Xcode that alcatraz supported

Hi @nealsun, thanks for your PR!
Rewriting plugins UUID's is something that has been discussed a few times before, there has even been a PR that added it at some point.
However, we feel that doing this kind of defeats the point of having these UUID's in the first place. It is up to plugin maintainers to make sure that their app works on the latest version of Xcode and update their UUID's accordingly.
I do still think we should show/warn users that a plugin isn't compatible with their current Xcode version.


--trace-level option doesn't seem to work

Specifying --trace-level 255 has no effect, neither before or after the subcommand (login). Only the TRACE_LEVEL environment variable seems make a difference:
$ epinio --trace-level 255 login -u admin -p password --trust-ca https://epinio.<IP_ADDRESS>.sslip.io

🚢  Login to your Epinio cluster [https://epinio.<IP_ADDRESS>.sslip.io]

✔  Trusting certificate...

✔  Login successful

$ epinio login -u admin -p password --trust-ca --trace-level 255 https://epinio.<IP_ADDRESS>.sslip.io

🚢  Login to your Epinio cluster [https://epinio.<IP_ADDRESS>.sslip.io]
[...]

$ TRACE_LEVEL=255 epinio login -u admin -p password --trust-ca https://epinio.<IP_ADDRESS>.sslip.io
2022/06/22 09:16:11 Settings-0xc000185130: "level"=4 "msg"="Loading" "from"="/Users/jan/.config/epinio/settings.yaml"
2022/06/22 09:16:11 Settings-0xc000185130: "level"=4 "msg"="Loaded" "value"="namespace=(workspace), user=(admin), pass=(password), api=(https://epinio.<IP_ADDRESS>.sslip.io), wss=(wss://epinio.<IP_ADDRESS>.sslip.io), color=(true), appchart=(), @(/Users/jan/.config/epinio/settings.yaml)"
[...]

That's why I filed #1580 because I thought --trace-level did not produce additional output, so setting DEBUG=true must have made the difference. But I guess I must have set both variables mentioned in the issue template, and it was TRACE_LEVEL that did it.

Thanks @jandubois , I will try it tomorrow. in my personal backlog I would like to refactor how we read and bind flags.
Maybe this could be an opportunity to do that. 😄

I confirm the behaviour.
Places using TRACE_LEVEL and trace-level are:
./.github/ISSUE_TEMPLATE/bug_report.md:44:export TRACE_LEVEL=255

./helm-charts/chart/epinio/templates/server.yaml:279:            - name: TRACE_LEVEL

./internal/cli/usercmd/push.go:53:	details := log.V(1) // NOTE: Increment of level, not absolute. Visible via TRACE_LEVEL=2

./helpers/tracelog/logger.go:2:// This logger will not print anything, unless TRACE_LEVEL is at least 1
./helpers/tracelog/logger.go:18:// TraceLevel returns the trace-level argument
./helpers/tracelog/logger.go:20:	return viper.GetInt("trace-level")
./helpers/tracelog/logger.go:30:	// trace-level 0 prints nothing, well technically it would print NewLogger().V(-1)
./helpers/tracelog/logger.go:31:	pf.IntP("trace-level", "", 0, "Only print trace messages at or above this level (0 to 255, default 0, print nothing)")
./helpers/tracelog/logger.go:32:	viper.BindPFlag("trace-level", pf.Lookup("trace-level"))
./helpers/tracelog/logger.go:33:	argToEnv["trace-level"] = "TRACE_LEVEL"

The logger.go is the most central here I believe.

In contrast, --timeout=multiplier and EPINIO_TIMEOUT_MULTIPLIER work as expected. I.e. both forms of setting the value do work. The code looks identical to trace setup, except for the names, of course.

Ditto verbosity ...
An ordering issue maybe ?
Could the code query for the trace level before the command line is parsed ?
And for the other options it is queried after ?

Yes, very much looks like that.
https://github.com/epinio/epinio/blob/ba5c7457505c0a46e9b11c0a6f786a5603e3ff3f/internal/cli/root.go#L41-L42

Lets see if cobra has a hook to run code after the command line is parsed, and before the Run function of the found command is invoked.

That works.

Yes, that is the func that we need to use. The refactor that I wanted to do was about having a Config struct that will be binded to the variables. I read this blog post few weeks ago https://carolynvanslyck.com/blog/2020/08/sting-of-the-viper/ and she was showing a way to bind everything correctly: https://carolynvanslyck.com/blog/2020/08/sting-of-the-viper/
I was trying to play a bit with it to try a clean implementation (https://github.com/enrichman/epinio-client-go/tree/main/internal/cli/cmd), but since we are handling lot of things in the init() funcs then it's a "big" refactor.


Add github action for writing to IPFS

On push, for the master, RFC, and Accepted branches.
As you can see in the image this was uploaded to IPFS on push to master:
Upload to IPFS finished successfully QmbZHKiorNSnFmj2s9rNNLnPqiW4Ed6EF46JcS4EZjBMzP

Here's a link - the image is below.

LGTM! Thank you for doing the hard work @paytonrules


Inherit from ShippingCalculator and use correct shipping method name

These adjustments fixed the shipping calculator not showing up when creating a new shipping method for me. Changes were following the guide at http://guides.spreecommerce.com/developer/calculators.html

Sorry, one year later. I haven't tested it, but the specs are green. And it definitely looks like in the guide :) Even though I'm having a hard time figuring out which version the guide refers to. I guess 2ish? 3ish?
@davekiss Do you still feel like merging this in?
@JDutil Is this something for the 2-4-stable branch you've been working on, too? I'm not actively using spree right now so I have a hard time keeping all the threads together. But I'll do my best to keep this gem alive.

@halo I'm no longer working on projects using this extension either, but I think it's still pretty important to the community in general. The changes here do look correct though. I'm hesitant to want to merge this into older stable branches though at this point if it's been working just fine as is. Perhaps just merge this to master and/or 3-0-stable.
Also we could transfer this repo over to spree-contrib to solicit more help maintaining this there.

@JDutil Sounds like a plan! It's hard to give my baby away, but I'd totally do it if you think it would be beneficial for the community. Babies have to grow up ;) Do I just transfer it? Would you go ahead and catch it? Or maybe you want to fork it and I would empty it and point to spree-contrib in the readme? Don't know what's best. You tell me.
@jspizziri Would you be willing to double-check if it works with Spree 3.0 as intended? If nothing obvious breaks, I think we can go ahead and merge this into 3-0-stable (and master).

@halo you'll still be added to it, but it'll be easier for others to also commit if that okay with you.  If you add me as having admin access to this repo I can transfer it.

@JDutil I'm pretty sure there is no shared admin access for personal repos. I will simply transfer it to spree-contrib now trusting that you'll find it safe and sound on the other side ;)

Well look at that. It said

You don't have admin rights to spree-contrib

when I tried to transfer it.

Haha, so I tried to push it to you.

JDutil/spree_digital already exists

:)

I sent you an invite to spree_digital admin team for spree-contrib maybe once you accept that it will let you.

@JDutil Awesome! Thank you. Github even put a redirect in place from the old location, so I don't have to think about that.
If you feel like it, you may take me off the admin team again, since I won't be adding much at the moment. But it's fine if you leave me in there, too. It would be my honor to just stick around until I may bring in something useful ;)

Well I believe your only admin for repos I assign to the team and ones you transfer.

I've just updated the team back to just write access that way if we want to add more committers I don't need to create yet another team.

Perfect. This scales, too ;)

@halo sorry for the delay on this. I tested it in my 3.0 installation and didn't see any problems. For what its worth however, without this PR I'm still able to see the Digital Delivery Calculator upon creating a new Shipping Method

@halo, are we going to get this merged in?

@jspizziri Yes, but not in the suggested 2-2-stable branch. I'd like this in master and 3-0-stable. Haven't had the time to create the pull request myself. I would merge it right away. Or, rather cherry-pick because I think there is a merge conflict.

Do you want me to create a PR for master?

That would be lovely :)

Merged into master via https://github.com/spree-contrib/spree_digital/pull/86


Deploy OneNote addin for organization

OneNote add-in does not seem to be able to be uploaded via admin center or integrated apps for the organization
Your Environment

Platform [PC desktop, Mac, iOS, Office on the web]: Office on Web
Host [Excel, Word, PowerPoint, etc.]: OneNote
Office version number: 16.0.15325.41001
Operating System: Windows
Browser (if using Office on the web): Edge

Expected behavior
Being able to deploy and publish OneNote Add-in using Microsoft 365 admin center.
Current behavior
Cannot deploy the OneNote add-in for the organization
Steps to reproduce
Try to upload a manifest for OneNote add-in

When we try to upload the add-in from admin center we get no error, but the add-in is not uploaded. We noticed the following tooltip

When we try from integrated apps we get the following error (different guid each time) and from the network we receive the following response for the manifest: UnableToUploadAddInsForBlockedApps

We also tried with admin account to upload the manifest from the My organization tab, but this did not make the add-in available for the rest of the users

Attached the manifest with the image and end point URL's removed.
manifest-staging-onenote-ticket.txt
Context

The manifest is valid since it is tested using the validation tool
We need the add-in deployed for the organization and this is our only option as per article: https://docs.microsoft.com/en-us/office/dev/add-ins/publish/publish. This is the link from OneNote add-in documentation as well: https://docs.microsoft.com/en-us/office/dev/add-ins/onenote/

Any update?


Improvements before release

I would refactor the following things before releasing the library:

Inject a function into the middleware so the amount in sats can be determined dynamically. This can allow a $ 1 amount based on the BTC price, or you can have custom amounts per route.
the NewGinLSATMiddleware function should accept the config and return the middleware object, so you can initialize it in one function call.
I don't know how useful the Response function is that is currently part of the middleware struct. If there is no reason why a user of the library should want it to be something custom, we should initialize it always with the same function, and it shouldn't be part of the input params of the NewGinLSATMiddleware function.

Another thing that I think would be useful is to make a http request in case of an LNURL client being created, and check if you get the expected response (status code and response body), and return an error if you don't.

Closed by #13


fixed-make-install-dependences

I tried to build connectal from source on ubuntu 15.04 but it failed.
Replacing libgmp3c2 by libgmpxx4ldbl fixed the issue.

We need to be careful about backward compatibility, there needs to be a check on the version of ubuntu to install the correct package.

@jameyhicks

I replace previous change by creating a link for libgmp.so.3 as your suggestion. The code check whether libgmp.so.3 exists. If not, create a link libgmp.so -> libgmp.so.3

This patch does not install libgmp10.

how about ln -sf /usr/lib/x86_64-linux-gnu/libgmp.so /usr/lib/x86_64-linux-gnu/libgmp.so.3

Thank you, Han. I've included libgmp10 package.

Thanks for submitting this pull request!


feat(AgmFusionTablesLayer) Fusion Tables Layer

Adds support fusion tables through angular-google-maps.
Additions
Added a new agm-fusion-tables-layer directive that accepts fusion tables layer config.
Usage
import { Component } from '@angular/core';

@Component({
  selector: 'app-component',
  template: `
    <agm-map>
        <agm-fusion-tables-layer [options]="options"></agm-fusion-tables-layer>
    </agm-map>
  `,
})
export class MyComponent {
  options = {
    query: {
      select: 'location',
      from: '1xWyeuAhIFK_aED1ikkQEGmR8mINSCJO9Vq-BPQ',
    },
    heatmap: { enabled: true },
  };
}

Renders the following

Ticket
Closes #1452

Is there any reason this won't be merged into develop? This looks like a great addition.

Agreed! +10 for merging this, please 👍

@SebastianM could I get a review on this?

Fusion tables were deprecated, so either way it's not going in


Enforce vineyard version to find_package.

What do these changes do?
Currently graphscope requires vineyard>=0.1.3. Otherwise there would be compliation error. This PR enforce the version constraint.
Related issue number

Fixes alibaba/libvineyard#106

Codecov Report

Merging #39 (82ec944) into main (dd2a58a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   77.26%   77.26%
=======================================
  Files          48       48
  Lines        4336     4336
=======================================
  Hits         3350     3350
  Misses        986      986

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2a58a...82ec944. Read the comment docs.


Missing options from Prettier Miscellaneous

Added the following options in the extension configuration :

bracesSpacing
breakProperty
arrowParens
arrayExpand
flattenTernaries
breakBeforeElse
groupFirstArg
noSpaceEmptyFn

@passionkind Any chance this can get pulled in and the extension updated on the marketplace?  Was looking to use breakBeforeElse.

@remimarsal Do you not also need to update dependencies in package.json to "prettier-miscellaneous": "^1.4.2"?

@langdonx I guess Bastian is bit busy at the moment. I didn't want to wait so I ended up building the extension myself with a version bump on prettier-miscellaneous to 1.4.2.  You can find it here.

@remimarsal Awesome!  The name is perfect.
I can't get a few of the new options to work (specifying them in settings.json): ("prettier.bracesSpacing": false, "prettier.breakBeforeElse": true).  Other new ones, like prettier.arrowParens work fine.
Do you want to open up Issues on your fork?


Add Synapse Workspace module

Purpose
Add Synapse Workspace module
Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? N/A
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Vimukthi Perera seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Merge pull request for implementation of issue 52

Do I need to do it and make a new pull request? I'm not sure what the process is here for denied pull requests. Feels like maybe we should close this one, I'll fix it and push a new change to my clone, then issue a brand new pull request that includes those changes?

Oh hang on:

You can add more commits to this pull request by pushing to the master branch on nbarnwell/GiveCRM

So I can just fix, push, and those changes will automatically be present. Righto, I'll do that then...


Issue using /homeother command

/homeother requires the solstice.command.homeother permission node (or OP level 2), can you check you have it granted?

/homeother requires the solstice.command.homeother permission node (or OP level 2), can you check you have it granted?

Im pretty sure I got it as im opped and have granted myself every permission using luckperms *

Can you run /lp verbose on, then run the command /homeother and send the output here?
You can turn off the log spam by running /lp verbose off.

Make sure you have exactly solstice.command.homeother, this is the permission for the command /homeother.

nope

Found the issue, expect an update in the next 10 minutes

thanks

Update published.


Add Libraries.io SourceRank badge

Libraries.io provides a ScoreRank based on existense of metainfo (readme, license), number of dependants and subscribers etc.
Documentation: https://libraries.io/api#project-sourcerank
Note that the docs are outdated, the request actualy outputs detailed JSON, not just one number, they have to be summed up:
{"basic_info_present":1,"repository_present":1,"readme_present":1,"license_present":1,"versions_present":1,"follows_semver":0,"recent_release":1,"not_brand_new":1,"one_point_oh":1,"dependent_projects":10,"dependent_repositories":6,"stars":4,"contributors":1,"subscribers":1,"all_prereleases":0,"any_outdated_dependencies":-1,"is_deprecated":0,"is_unmaintained":0,"is_removed":0}

A badge like sourcerank : sum would be nice.

Hi @Athari . Good suggestion. I know Libraries.io are currently looking at reviewing the way that SourceRank is calculated (see https://github.com/librariesio/libraries.io/issues/1916 ). If anyone is interested in working on this, it might be sensible to put this on hold until SourceRank 2.0 is launched. It would be a shame to put time into this and then have to rewrite it in the near future because the API has changed.


letterSpacing (and kerning) making text go off-centred

I'm trying to space out my text a bit because it looks a little crunched when tying to render it in a circular arc shape. However, it seems that any calculations regarding the origin point to start drawing text is computed without taking letterSpacing or kerning into account.
For example, here is my component:
import React from 'react';
import Svg, { Circle, Defs, G, Path, Text, TextPath } from 'react-native-svg';

const Medallion = props => {
  const upperArc  = 'M-40.97502384803651,-1.4308810757150652A41,41,0,0,1,40.97502384803651,-1.4308810757150694A41,41,0,0,0,-40.97502384803651,-1.4308810757150652Z'
  const upperPath = 'M-40.97502384803651,-1.4308810757150652A41,41,0,0,1,40.97502384803651,-1.4308810757150694';

  const lowerArc  = 'M-48.97015053189642,1.7100751104568743A49,49,0,0,0,48.97015037316634,1.7100796558864861A49,49,0,0,1,-48.97015053189642,1.7100751104568743Z';
  const lowerPath = 'M-48.97015053189642,1.7100751104568743A49,49,0,0,0,48.97015037316634,1.7100796558864861';

  return (
    <Svg width={114} height={114}>
      <Defs>
        <Path id="upperPath" d={upperPath} />
        <Path id="lowerPath" d={lowerPath} />
      </Defs>
      <Circle cx={57} cy={57} r={57} fill="blue" />
      <Text
        x={57}
        y={57 + 10}
        textAnchor="middle"
        fill="white"
        fontWeight="bold"
        fontSize={10}
        letterSpacing="2"
      >
        This is a test
      </Text>
      <G x={57} y={57}>
        <Path d={upperArc} stroke="pink" />
        <Path d={lowerArc} stroke="pink" />
        <Text fill="white" stroke="white" fontSize={12} textAnchor="middle">
          <TextPath href="#upperPath" startOffset="50%">
            No letterSpacing
          </TextPath>
        </Text>
        <Text
          fill="white"
          stroke="white"
          fontSize={12}
          textAnchor="middle"
          letterSpacing="2"
        >
          <TextPath href="#lowerPath" startOffset="50%">
            This is a test
          </TextPath>
        </Text>
      </G>
    </Svg>
  );
};

export default Medallion;

I draw upperArc and lowerArc paths so that you can see the path I'm using to draw my text. I've removed the inner arc (equal to outer arc) to actually draw the text so that I don't get wrap around. This is the result:

You can see from the output that the text drawn with Text in the middle of the circle is off-centred as well as the text on the lower arc. Both of these have letterSpacing="2" (which, if I remove, would make the text centred again).
I've tried something similar with JS + D3 + SVG in a browser environment and it works as expected, staying centred. Any idea what is going on here and how I can work around it?

@msand Hello, any ideas when it can be fixed? Found this problem in my app, so it's critical issue now... Thanks

Not sure. Do you have time to work on it?

@msand Sorry I don't have native platform languages skills to fix this issue

The text rendering should be split into several passes per Text element root / anchored subtree. First to do bidi transformations and other text-shaping to find the glyphs, advances and positions + rotations. Allowing to get the sums of advances per text chunk, to shift the first character of the anchored chunks by half the extent of all the anchored text in the subtree. And another to actually render the glyphs in their positions, or along textPath defined curves.

I think i've fixed this now. Can you try with the text-anchor-subtree-calculation branch? https://github.com/react-native-community/react-native-svg/tree/text-anchor-subtree-calculation

@msand Sure, will check in few hours

@msand Checked, it works fine for my case! Text alignment works perfectly on iOS/Android, checked with  + few  inside with letterSpacing + textAnchor="middle"

@msand Hello, do you know when this bug fix can be added to master + new package version published? It's a bit urgent for my project :) Thank you

You can use the git uri for now. In practice nothing changes except a single line in your package.json, this library has no build process, as you probably noticed from it already working for you when you verified the fix. A new version will come in due time. Putting it to npm just changes from where you fetch the bytes. And who tracks what how.

@msand Hello,I used a link as npm dependency from github to use your latest fix for text alignment/kerning with letter spacing. Just noticed that we have incorrect behaviout for text with textAnchor="middle" after these fixes. Not aligned text is rendered like textAnchor="start", it is shifted to initial position even if we have textAnchor="middle" for it. Thanks

@oleksandr-dziuban Can you provide a reproduction?

@msand Hello, if I set to any text justa textAnchor="middle" - I see that text is shifted right. Also TSpans are aligned to left side, instead of middle alignment

@msand From v.9.2.4
Top text is single line with textAnchor="middle"
Main text is multiline with textAnchor="middle" with TSpans

@oleksandr-dziuban Could you provide a reproduction?

@msand This code is under NDA, but I will prepare a clean app maybe. It should be just a  with textAnchor="middle" and x, y coords

Yeah a minimal reproduction would be great. The smaller the better.

@msand Hello, sorry for the delay, I prepared minimal reproduction. The problem exists on Android platform, iOS looks fine. So when we use textAnchor='middle' and/or  letterSpacing='<<more than 1>>' on Android whole multiline text is shifted right. Issue is only applicable for multiline text with TSpans.
On version 9.2.4 everything is OK (before your text position recalculation updates), on latest 9.3.5 issue is present on Android platform.
I have:
react-native: 0.57.7
react-native-svg: 9.3.5
MacOS: 10.14.3
Xcode: 10.1
To reproduce it use:
import React, { Component } from 'react';
import Svg, { Image, G, Text, TSpan }  from 'react-native-svg';

class App extends Component {
  render() {
    return (
      <Svg width='300' height='300' style={{ borderWidth: 2, margin: 10 }}>
        <G>
          <Text x='100' y='60' textAnchor='middle' letterSpacing='10'>
            <TSpan dy='20'>Test multiline</TSpan>
            <TSpan dy='20'>text. Test text</TSpan>
          </Text>
        </G>
      </Svg>
    )
  }
}

@oleksandr-dziuban Can you try with the develop branch? I think I've fixed it there

@oleksandr-dziuban Can you try with the develop branch? I think I've fixed it there

@msand Sure, will do, thanks

@msand I have double checked with latest develop branch, issues with multiline text are not resolved:
I have found 2 issues on both iOS/Android:

Multiline text is shifted to the left side when we use textAnchor
If we set textAnchor="start/middle/end" multiline text has shifted to the left side according anchor value, but all lines are still aligned  "start" even when "middle" or "end" activated. Looks like alignment is ignored.

Let's check 1st case:
If you use this React Native code:
import React  from 'react';
import Svg, { G, Text, TSpan, Rect }  from 'react-native-svg';

const App = () => (
    <Svg width='300' height='300' style={{ margin: 10 }}>
      <G>
        <Rect x='0' y='20' width="300" height="300" stroke="green" stroke-width="6" fill="yellow" />
        <Text x='350' y='60' textAnchor='middle' letterSpacing='6' width={300} height={300}>
          <TSpan>Test multiline.</TSpan>
          <TSpan x='350' dy='20'>New line 1.</TSpan>
          <TSpan x='350' dy='20'>Another new line 2.</TSpan>
        </Text>
      </G>
    </Svg>
);

We can see this:

With the same WEB SVG code:
<svg xmlns="http://www.w3.org/2000/svg" width="300" height="300" version="1.1">
   <g>
      <rect x='0' y='20' width="300" height="300" stroke="green" stroke-width="6" fill="yellow" />
      <text x='150' y='60' text-anchor='middle' letter-spacing='2' width='300' height='300'>
        <tspan>Test multiline.</tspan>
        <tspan x='150' dy='20'>New line 1.</tspan>
        <tspan x='150' dy='20'>Another new line 2.</tspan>
      </text>
    </g>
</svg>

We can see correct position:

ISSUE: We can see that in react-native apps multiline text is shifted to left too much.
Let's check 2nd case:
If you use this React Native code:
import React  from 'react';
import Svg, { G, Text, TSpan, Rect }  from 'react-native-svg';

const App = () => (
    <Svg width='600' height='300' style={{ margin: 10 }}>
      <Rect x='0' y='20' width="600" height="300" stroke="green" stroke-width="6" fill="yellow" />
      <G>
        <Text x='350' y='60' textAnchor='start' letterSpacing='1' width={600} height={300}>
          <TSpan>Test multiline #1.</TSpan>
          <TSpan x='350' dy='20'>New line 1.</TSpan>
          <TSpan x='350' dy='20'>Another new line 2.</TSpan>
        </Text>
      </G>
      <G>
        <Text x='350' y='150' textAnchor='middle' letterSpacing='1' width={600} height={300}>
          <TSpan>Test multiline #2.</TSpan>
          <TSpan x='350' dy='20'>New line 1.</TSpan>
          <TSpan x='350' dy='20'>Another new line 2.</TSpan>
        </Text>
      </G>
      <G>
        <Text x='350' y='240' textAnchor='end' letterSpacing='1' width={600} height={300}>
          <TSpan>Test multiline #3.</TSpan>
          <TSpan x='350' dy='20'>New line 1.</TSpan>
          <TSpan x='350' dy='20'>Another new line 2.</TSpan>
        </Text>
      </G>
    </Svg>
);

We can see this:

With the same WEB SVG code (just changed x coordinate because of 1st issue):
<svg xmlns="http://www.w3.org/2000/svg" width="600" height="300" version="1.1">
   <rect x='0' y='20' width="600" height="300" stroke="green" stroke-width="6" fill="yellow" />
   <g>
      <text x='350' y='60' text-anchor='start' letter-spacing='1' width='600' height='300'>
        <tspan>Test multiline #1.</tspan>
        <tspan x='350' dy='20'>New line 1.</tspan>
        <tspan x='350' dy='20'>Another new line 2.</tspan>
      </text>
    </g>
    <g>
      <text x='350' y='150' text-anchor='middle' letter-spacing='1' width='600' height='300'>
        <tspan>Test multiline #1.</tspan>
        <tspan x='350' dy='20'>New line 1.</tspan>
        <tspan x='350' dy='20'>Another new line 2.</tspan>
      </text>
    </g>
    <g>
      <text x='350' y='240' text-anchor='end' letter-spacing='1' width='600' height='300'>
        <tspan>Test multiline #1.</tspan>
        <tspan x='350' dy='20'>New line 1.</tspan>
        <tspan x='350' dy='20'>Another new line 2.</tspan>
      </text>
    </g>
</svg>

We can see correct alignment and shift:

ISSUE: We can see that in react-native apps the lines in multiline text are not aligned according textAnchor value.
@msand Could you please check these 2 issues when you time? Our project is really blocked now with these text issues. Thank you very much.
Should I create a separate issue?

@oleksandr-dziuban Can you use separate text elements instead of tspans inside a text to work around the issue for now? Essentially the code for finding the text-chunk for anchoring and calculating the shift is buggy. Ideally we would implement the svg 2.0 text layout algorithm: https://www.w3.org/TR/SVG/text.html#TextLayoutAlgorithm
But, already calculating the anchored chunks correctly and finding the left-(top-) most and right-(bottom-) most extents of the typographic characters within the anchored chunk would fix this.

@msand I will try, just I need to rewrote a lot of app logic and components, I have a deep React components tree.
Oh, regarding SVG 2.0, it will be very large trouble fo us :) Because we support only SVG 1.1 style accros whole product. We have shared rendering code between a few projects (WEB, Native, etc.) so everywhere we have 1.1 style.
If I understand correctly SVG 2.0 has different attributes, behaviour, etc. ?

It deprecates a few things, but we would probably aim for svg 1.1 compatibility as far as possible as well. Mostly it clarifies the spec, defines previously undefined behavior, add some more attributes, values, allows attributes to be set using styles, etc. We already have support for several things from the svg 2.0 spec, and the text layout rendering is better defined there than in the 1.1 spec.
I'll try a small change, it might cover most of your needs for now, while still not being fully spec conformant.

@msand Great, thank you a lot! Maybe it will be possible to fix quickly, what I need, just to align lines correctly with textAnchor="midle/end" as in 9.2.4 and get rid of unnecessary bug shift to the left. If 2nd is impossible I'll add a workaround on my side (playing with x coord). So main issue is alignment is nor applied to lines. Thank you

@oleksandr-dziuban Can you try with the latest commit from the develop branch?

@oleksandr-dziuban Can you try with the latest commit from the develop branch?

@msand Sure, will do

@msand I don't know how you do that, but both issues are resolved!!! Multiline text works as expected! Great job 👍

Well, if you look at https://github.com/react-native-community/react-native-svg/commit/70ac80b297b0d39cad1e2f78f07429fbdc3258e8
You can see:
https://github.com/react-native-community/react-native-svg/blob/70ac80b297b0d39cad1e2f78f07429fbdc3258e8/ios/Text/RNSVGText.m#L258-L275
Where I added the disjunction with
node.positionX != nil

To the predicate which finds the element, from which it calculates the extent of the text.
This will work incorrectly for any tspan with several values in the x attribute, or for any tspan which doesn't have any x attribute, while some sibling element does. The correct algorithm would find each range of i..j in all the text of the text element, for which the anchor should adjust the initial/final text position, and find the extent for each of those ranges.

@msand But even with current fix it looks much better. I think we can publish patch version for now, because minimum feature is working

Published v9.2.6 now

Thank you


How to implement authentication/login/signup procedures?

There have been other questions like this in the past and as far as I understood, there will be an implementation soon. So I have the following questions:

Is there already something working, but undocumented for basic login/signup procedures?
Do you know about tutorials or snippets on which I can take examples?

Login/signup is outside of ng-admin' scope. You'll have to implement that on your own.
An example for the login is Poster's Galore Login, that you can test online at http://marmelab.com/ng-admin-demo/login.html.
As for what to do after login, it depends on the API security. If your API requires a specific header with a token that you got during login, then a Restangular Request Interceptor is the way to go.
Also, please read the FAQ.
https://marmelab.gitbooks.io/ng-admin/content/doc/FAQ.html#my-api-requires-authentication-how-can-i-set-it-up


Editor table revamp.

Fixes #1159

Description
Checklist

[ ] I have made corresponding changes to the documentation.
[ ] I have updated the types definition of modified exports.
[ ] I have verified the functionality in some of the neeto web-apps.
[ ] I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers

@AbhayVAshokan This feature requires new icons which will be worked on by Avinash in this ticket.

@praveen-murali-ind  _a please review.


Ignore images within 'do not render' class

resolves the conflicts in #29

there is no test, so the build fails, but it's still ok. We are fixing the build here https://github.com/hexojs/hexo-theme-landscape/pull/182


Update docs for consents

Updates the documentation based on our recent changes for the consents project.
Will mark as WIP while we get the final issues finished.

@pbanaszkiewicz ready for review!


unable to access 'https://github.com/Homebrew/brew/'

I am trying to install Homebrew using the install/curl command on https://brew.sh/ When I first ran it, it was able to download and install several things, but not brew. Now when I run the install command it results in:
xxxx:~ xxxxx$ /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
==> This script will install:
/usr/local/bin/brew
/usr/local/share/doc/homebrew
/usr/local/share/man/man1/brew.1
/usr/local/share/zsh/site-functions/_brew
/usr/local/etc/bash_completion.d/brew
/usr/local/Homebrew

Press RETURN to continue or any other key to abort
==> Downloading and installing Homebrew...
fatal: unable to access 'https://github.com/Homebrew/brew/': Received HTTP code 407 from proxy after CONNECT
Failed during: git fetch origin master:refs/remotes/origin/master --tags --force --depth=1

This is on my work computer, however, I have GitHub configured for both personal and enterprise and am able to clone public GitHub.com repos. Any thoughts on why I am receiving the fatal connection issue?
Thank you for any assistance!!

This seems to be an issue with your work proxy. You need to configure curl and git (and perhaps your work proxy) to allow it to connect. There's nothing we can do to help here.
Also, please always fill out the issue template (as it tells you to do).


Increase gRPC client timeout to 60 seconds

This works around some issues that we're seeing in hosted implementations which cause API calls to be cancelled prematurely. Proxies are subtracting time from the deadlines that we send and cancelling if the remaining time is less than some threshold. Specifically, we see our 20s timeout become 10s, and then with a fraction of a second removed during processing, the operation is canceled because the hosting platform requires 10s minimums. This seems like a bug in the hosting configuration, so we might revisit this when that's better understood.
See also: https://github.com/googleapis/gapic-generator-go/issues/1206

@theganyo #901 awaits!


Download Subtitle from video

Hi.
Could you implement a function to download the video subtitle?
Or to change the size of the subtitle of the video itself without uploading it.
But if its not possible to change the size of the subtitle in the video, let us download the official SRT from Crunchyroll so we can upload using the extension and then change the size.
Im watching Attack on Titan on Crunchroll and it does have the subtitle in my language but i cant find a way to download the srt subtitle...
It would be nice to download the subtitle from the video so i can upload via Jimaku Player...

I don't think it'd be possible to provide a way to download the subtitles from Crunchyroll. The location their subtitles are downloaded from is a really long random looking URL (you can find it in your browser's dev tools network tab) and I'm not sure how to figure out what that URL is.
For technical reasons I don't think it'd be very easy to change the size of the built-in subtitles effectively.
Best of luck finding an alternative solution!


Client can specify what parallelism they can specify for their jobs, and compare outputs

[ ] Or, I want to wait until N compute nodes have run it, want to see a summary
[ ] Deliverable: client can specify to run each job N times and the CLI displays the progress and compare the hashes of the outputs

Client can specify parallelism = 1 initially, and then as a surprise ask for more copies of the job to be done (it rolls a dice and 1% of the time asks for verification - that way the compute nodes are kept on their toes)

2nd parallelism request needs to go to another node
Compute nodes need to notice other compute nodes starting work and avoid starting jobs that have been started elsewhere (via libp2p)

Demo of this should include a malicious node which does zero work, we should be able to detect it.

We can emulate the single-threadedness of the EVM scheduler initially by having job start requests go via requester (client) via libp2p.

Protocol for job starting
C -> S1,S2,S3: RequestJob(job) # please run this job
S1 -> C: RequestJob(jobId) # I would like to run this job
S2-> C: RequestJob(jobId) # I would like to run this job
S3 -> C: RequestJob(jobId) # I would like to run this job
C -> S1: AcceptJobRequest(jobId) # sure go for it
C -> S2: DenyJobRequest(jobId) # no I am controlling concurrency for this job
C -> S3: DenyJobRequest(jobId) # no I am controlling concurrency for this job
S1 -> C: SubmitResult(jobId, resultId, resultPointer) # here i did the work
```
at this point C can either accept the work naively or decide (roll a dice 3% of the time) to test the veracity of the result, depending on confidence flag
```
C -> S1,S2,S3: UpdateJob(job, concurrency=3) # i am testing you
S1 -> C: RequestJob(jobId) # I would like to run this job
S2-> C: RequestJob(jobId) # I would like to run this job
S3 -> C: RequestJob(jobId) # I would like to run this job
C -> S1: DenyJobRequest(jobId) # you already ran this job, not letting you get extra credit for free
C -> S2: AcceptJobRequest(jobId) # sure go for it
C -> S3: AcceptJobRequest(jobId) # sure go for it
S2 -> C: SubmitResult(jobId, resultId, resultPointer) # here i did the work
S3 -> C: SubmitResult(jobId, resultId, resultPointer) # here i did the work
```
at this point the client can compare traces and try to root out bad actors, in the future this can feed into a reputation system. for now we should be able to demo getting reliable results even in the presence of 1/3 of the nodes submitting bad results. i.e. we can have a bad actor and still get reliable results.

In the future, C can also be clever about letting different servers run certain jobs in order to ensure that a mix of servers get tested (although this is out of scope for now)

## Protocol

* SubmitJob(spec JobSpec)
  * Executed by the client (Connie) requesting the work, puts the job into a mempool of work that is available to be done
* RequestJob(jobId) -> resultId
  * Executed by the compute node (Prue) when they want to start working on a job
* ApproveJobRequest(jobId)
  * Executed by the client (Connie) to tell Prue they are good to start. Enables coordination to avoid excess job starting, also allows client to be selective about reputation
* DenyJobRequest(jobId)
  * Executed by the client (Connie) to tell Prue they shouldn't try to run this job
* UpdateJob(jobId, spec JobSpec)
  * Update a job field for example updating concurrency
* SubmitResult(jobId, resultId, resultPointer)
  * Executed by the compute node when they have partially or fully completed a job and have some results (and possibly evidence of computation)
  * Includes a result pointer which points to where the results are written to a storage implementation (e.g. IPFS)
* ApproveResult(jobId, resultId)
  * Executed by the client when they are satisfied with the outcome of a job (e.g they have completed some verification of a job)
* RejectResult(jobId, resultId)
  * Executed by the client when they believe a job has been executed incorrectly

Should also think about how we can stream rewards during partial job execution since payment for jobs will be per minute and it would be nice if the verification could run continuously and not necessarily just at the end.


[Notification] background & dropshadow error

Problems:

Tinted notification backgrounds are not working on G10 themes
Missing drop shadow

Tinted notification backgrounds are not working on G10 themes

Relevant discussion:

Missing drop shadow

has there been a resolution on which background colors to use for the g10 theme? also is there a box shadow mixin that we want to reuse for the notifications or are we creating a new one? I'm assuming the shadow will only apply to toast notifications and not inline notifications as well

All notifications are changing to high contrast moments on every theme to solve these issues.^

We still need the drop shadow though.

alright I can address the drop shadow in https://github.com/carbon-design-system/carbon-components/pull/2367 as well

Resolved!


Sharepoint connectors with  from: drive:*/root and from: group:*/root give permission errors.

Describe the bug
For sharepoint datasets, when using the root directory of a group or drive is provided, an error occurs getting entries.
To Reproduce
datasets:
 - from: sharepoint:group:my_group/root
 - from: sharepoint:drive:my_drive/root

NOTE: does not occur for from: sharepoint:me/root

Looking at endpoint, we are sending correct  API call to Microsoft Graph:

/v1.0/groups/{group-id}/drive/root/children
/v1.0/drives/{drive-id}/root/children

Likely an undocumented permissions problem.

Not an issue with from: sharepoint:site:*

For a given group e.g. /v1.0/groups/3350aa8f-abcd-ijkl-efgh-884d675a8cb1/drive/root/children, the associated value.parentRefence.driveId returned via Microsoft Graph Explorer, also gets an error (e.g. using sharepoint:driveId:b!fABCDEFG0UZ5cQEka05SYNQv_WLES4LuSY9Iht1wzmfS8-qGwmnpxVSKnKZn22O0/root).


Configuration management

While we can set sane defaults, there are many settings that may need to be tweaked based on someone's use-case.  Users currently have the ability to manage their Stolon configuration at runtime via stolonctl, but it's probably not obvious how to do to this.  That being said, we should work to provide better documentation on how to do this or work to streamline the re-configuration process via flyctl.

https://github.com/superfly/flyctl/pull/798


[Bug]

The IR compiler accepts the following invalid program (notice the vec_push_back is missing an argument):
main() {
    let i: u64;
    let v: vector<u64>;

label entry:
    i = 0;
label loop_start:
    jump_if_false (copy(i) < 1000) loop_end;

    v = vec_pack_0<u64>();
    _ = vec_len<u64>(&v);
    vec_push_back<u64>(0);
    _ = vec_imm_borrow<u64>(&v, 0);
    vec_swap<u64>(&mut v, 0, 0);
    _ = vec_pop_back<u64>(&mut v);
    vec_unpack_0<u64>(move(v));

    i = move(i) + 1;
    jump loop_start;
label loop_end:
    return;
}

This results in a NEGATIVE_STACK_SIZE_WITHIN_BLOCK error but it really should have been caught in an earlier stage.

This is the purpose of the IR, to let you test these items. So it is not a bug, it is a feature :)


Add HTTP match and rewrite to Canary service spec

Add Istio HTTPMatchRequest and HTTPRewrite  to Canary CRD.
apiVersion: flagger.app/v1alpha3
kind: Canary
metadata:
  name: podinfo
spec:
  service:
    port: 9898
    match:
      - uri:
          prefix: /podinfo/
    rewrite:
      uri: /
.........

Test image: quay.io/stefanprodan/flagger:http-match-56cb888
Fix: #50

Codecov Report

Merging #55 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   56.69%   56.76%   +0.06%
==========================================
  Files           9        9
  Lines        1344     1346       +2
==========================================
+ Hits          762      764       +2
  Misses        448      448
  Partials      134      134

Impacted Files
Coverage Δ

pkg/controller/router.go
85.09% <100%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c835892...56cb888. Read the comment docs.


chore(release): bump version to 3.5.0 as part of the 3.4 Feature Freeze

chore(scripts) restore release-lib.sh
release: 3.5.0

Summary

Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference

Fix #[issue number]

Are there any other related changes that should go in the same PR? I'm seeing that similar commits in the past (e.g. 91ebcbaf7) also updated the changelog.

@flrgh thank you. There's a step called

Add new (empty) “Unreleased” section on master
But that happens later on the release right now (essentially on release day). For now that is not needed.


fix(indexedDb): force version bump to cleanup database

:tada: This PR is included in version 1.0.0-alpha.62 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bl 729 ds update matcher algorithm updated

Description
Updated matcher algorithm to account for is_active, accepting_new_mentees, and validate_status == 'approved". These changes will allow for the DB to be sorted to the specific requirements wanted with each field.
Jira Ticket
BL-729
Type of Change

[X] New feature

Checklist

[x] My code follows PEP8 style guide
[x] I have removed unnecessary print statements from my code
[x] I have made corresponding changes to the documentation if necessary
[x] My changes generate no errors
[x] No commented-out code
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Going to re-push from another local to prevent merge conflicts shortly


soft-breaks in copy

Hi!
If a text is longer than the whole line, terminus will automatically add a soft-break (Here's a screenshot of it https://sc.florian.pw/rIu7.png).
The problem is: It will also copy those soft-breaks, but it shouldn't do so, as they don't really exist in the program output.

I don't know that there's going to be any easy path to fixing this.
Terminus seems to use hterm.copySelectionToClipboard() to handle the actual copy. [source]
Looking into that, it looks like they just use document.execCommand('copy') [source]
Which bring this all down to a matter of how that execCommand('copy') is implemented.
https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand
At best, it's an hterm issue, at worst, it would be considered a webkit "issue". Ultimately, I doubt either would do anything about it (especially the latter).

Was these ever a fix for this?  Still annoying.


Multiple Controllers

The following fails to load in the proper order on an intermittent basis.
angular.module('articles',[]);
angular.module('articles').controller('ArticlesController', ['$scope',...
angular.module('articles').controller('ModalCtrl', function ($scope,...

When failing, several grunt-test mocks report that ArticlesController is not a function.
I'm not familiar enough with the client plumbing, but I've read that for loading app.js should be after AngularJS but before any controllers / services / etc...otherwise angular won't be able to initialize your controllers.
For now, I'm using this in the ArticlesController:
var modalInstance = $modal.open({
                templateUrl: 'modules/articles/views/edit-xxx.client.view.html',
                controller:function ($scope, $modalInstance, xxx){...},...

Please use code blocks when inserting code.

Should I resubmit?

Just edit your posts above with code blocks.

@cliffeby Do you have your function defined in your array like so:
angular.module('articles').controller('ArticlesController', ['$scope', function($scope){...}]);

@cliffeby Is this still an issue?

@cliffeby I'm closing this issue, however, feel free to reopen if it's still an issue.


PelletTop working with one exception

Hello,
I'm using your great HA integration with a PelletTop 15kW biomass boiler and it is working!
I can see all expected sensor values:

To Reproduce
But I have an issue in the log file.
The home assistant log file (/config/home-assistant.log) is showing the following error every 30 seconds:
2024-01-02 16:03:32.383 ERROR (SyncWorker_5) [root] Modbus read error at address=33412: Exception Response(131, 3, IllegalAddress)
2024-01-02 16:03:32.383 ERROR (SyncWorker_5) [root] Failed to read holding registers of BiomassBoiler

I assume that the address 33412 is not implemented for this PelletTop or maybe only for my configuration.
Can you provide a patch that will skip the reading of this address. I have tried to find it myself but failed -:(
Desktop (please complete the following information):

Home assistant version: 2023.12.4
Solarfocus custom component version ???
Solarfocus firmware version 23.060

Additional context
This is how my configuration looks like

Thank you for your support!

Further investigations show ing the following messages in the HA Core logs:
`Logger: root
Source: /usr/local/lib/python3.11/site-packages/pysolarfocus/components/base/component.py:161
First occurred: 16:57:21 (1 occurrences)
Last logged: 16:57:21

Failed to read holding registers of BiomassBoiler`

`Logger: root
Source: /usr/local/lib/python3.11/site-packages/pysolarfocus/modbus_wrapper.py:65
First occurred: 16:57:21 (1 occurrences)
Last logged: 16:57:21

Modbus read error at address=33412: Exception Response(131, 3, IllegalAddress)`

Thanks for reporting - it's actually an issue with in the pysolarfocus library (https://github.com/LavermanJJ/pysolarfocus/blob/bed920b275c473c340b45c4c40431d2d0337921b/pysolarfocus/components/biomass_boiler.py#L26) ... The log-wood is not supported by PelletTop ... for obvious reasons. 😉 I'll created a corresponding issue. https://github.com/LavermanJJ/pysolarfocus/issues/31

Hi Leuchtentrager,
thank you for your screenshot.. same experience here... Pellettop Light here.
Question regarding and issue i have - i made a separate bug report...
I have noticed that your door contact shows "Closed", does your door contact ever change to "Open"? Mine shows alwas open and never changes to "closed". Any input appreciated... (also see my bug report about the door contact withi more details).

Hi,
I have a question as I have a Pellettop 25 and have recently come across the integration in HA. Is it possible to integrate the pellet top because it is not offered in the selection. Am I right in assuming that I then have to select the Ecotop?
Thank you for your answer.

@SasBen82 have you been successful in using the integration? If so, which option did you select? Thanks for your feedback!

Hello,
sorry but until now I‘m not able to run the integration successfuly.
I will try it until the next few weeks.
Von: Jeroen Laverman @.>
Gesendet: Freitag, 1. November 2024 15:08
An: LavermanJJ/home-assistant-solarfocus @.>
Cc: SasBen82 @.>; Mention @.>
Betreff: Re: [LavermanJJ/home-assistant-solarfocus] PelletTop working with one exception (Issue #88)
@SasBen82 https://github.com/SasBen82  have you been successful in using the integration? If so, which option did you select? Thanks for your feedback!
—
Reply to this email directly, view it on GitHub https://github.com/LavermanJJ/home-assistant-solarfocus/issues/88#issuecomment-2451933653 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BL7UU2LT5TBB5TYKWF26EB3Z6ODMLAVCNFSM6AAAAABPYIC6H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRHEZTGNRVGM .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/BL7UU2JOSW5IFX2R3L53AE3Z6ODMLA5CNFSM6AAAAABPYIC6H6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUSEWE5K.gif Message ID: @.*** @.***> >

Hi SasBen82,
The correct name for my device is "Pellet elegance 15kW" (not PelletTop). I don't know if this makes a big difference.
I have used the EcoTop integration which works for me. I think more important is the used control unit which is 'eco manager 7" ' in my case.
After service and maintenance last week I have problems with some of the sensors:

The outdoor temperature sensor and the Boiler state are only updating once after a restart of the integration. After this the value is stuck.
I have now controller API version V24.040 which might be the reason ? I will do some more investigation and may open a extra ticket.


fix: SfCheckbox cursor on checkbox input behaviour fixed

Related issue
https://github.com/DivanteLtd/storefront-ui/issues/1142
Closes #1142
Scope of work
add z-index to hide input and position relative to parent to keep input inside
Checklist

[x] No commented blocks of code left
[ ] Run tests and docs
[x] Self code-reviewed

I added z-index to hide input but I am not sure if it is good solution, so please take a look.

@AdamPawlinski how about give the input cursor: pointer ?  z-index can mess the position of the other elements on the page.

@AdamPawlinski @martaradziszewska  IMO the best way is adding for input 1p for width and height. @AdamPawlinski please check SfRadio too. You can add position: relative for &__container and test is everything working OK

inoput changed to 1px and moved outside. SfRadio also fixed


feat(adapters): Adding Huggingface adapter

Description
New adapter for the HuggingFace serverless inference API. It is somewhat OpenAI API-compatible, but not fully.
Related Issue(s)
related: https://github.com/olimorris/codecompanion.nvim/discussions/517#discussioncomment-11517785
Thank you
Checklist

[x] I've read the CONTRIBUTING guidelines and have adhered to them in this PR
[x] I've updated the README and ran the make docs command

Thanks so much for this. I've added a couple of comments.
Also, can we reuse the OpenAI adapter for the handlers? Like what I've done with copilot and openai_compatible adapters? It may prevent us requiring an additional test and will make the adapter logic that much easier.

can we reuse the OpenAI adapter for the handlers?

Sure, I actually started with that approach following the xAI adapter, but for some reason, it didn’t work. I might have had something else interfering with the code at the time. Now, everything runs using the OpenAI adapter.

One more thing: I resolved the conversations for the two reviews. I’m not sure if that’s the correct approach or if it’s something you’re supposed do the resolve conversation. Apologies if I overstepped, I don’t have much experience with PRs.

Looks fantastic, thank you. Feel free to drop the test as we have it all covered with the OpenAI one.

done, tests dropped.

Thanks so much for this. Feels great to have this in CodeCompanion finally.


Dark Mode is not working as intended

The bg color of program container is white even i dark mode .

it works well in mobile phone. but the problem is in desktop


failed to find a model provider for model [gpt-4o]

Hi:
I am a newbie. I installed GPTScript on Ubuntu.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.2 LTS
Release:	22.04
Codename:	jammy

When I run the following command:
gptscript github.com/gptscript-ai/cli-demo

I get the following error:
failed to find a model provider for model [gpt-4o]

I must be doing something really wrong, but I don't have a clue. Help?

Turns out I had to buy some capacity on OpenAI

There is no such thing as a free lunch!

Hey @reselbob , how to downgrade this to gpt-3.5 ?


Softlock on Crescent Island without Currents

Take the raft to Crescent, use the Echoes portal. The vanilla return portal only responds to currents in rando.

For reference, entrance rando has a echoes portal on the same spot in the present
db 00,d9,00,18,d7 # portal on SW crescent island
That fixes the immediate problem. Does nothing for the Dimitri problem though.


--no-binarry appears to be unsupported

Using uv 0.1.23.
I have this requirements file (hereby named test.in):
--no-binary=psycopg2
psycopg2

Using pip-compile test.in produces this:
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
#    pip-compile test.in
#
--no-binary psycopg2

psycopg2==2.9.9
    # via -r test.in

However, using uv pip compile test.in just errors with:
error: Unexpected '-', expected '-c', '-e', '-r' or the start of a requirement at test.in:1:1

Thanks, this is a duplicate of https://github.com/astral-sh/uv/issues/1461. We support --no-binary on the command-line, but not in a requirements file.


Modify gke/grpc-bookstore.yaml to use GKE ingress for container native load balancing.

Modify gke/grpc-bookstore.yaml to use GKE ingress for container native load balancing.
These sample code is being used by https://cloud.google.com/endpoints/docs/grpc/get-started-kubernetes-engine-espv2. Changes in this PR include:

TLS secret is attached to both ingress and ESPv2.
Service type is changed from "LoadBalancer" to "ClusterIP" because
ingress will start manage the external load balancer.

There are also a few Google internal docs changes pending:

Users will create an IP alias enabled cluster in creating a container cluster section.
Users will configure TLS because container native LB uses HTTP2 and TLS is a must to have.

@nareddyt @qiwzhang @TAOXUY PTAL.

Makes sense. I just changed it to 443.

Thank you @nareddyt @TAOXUY . I'll try to submit this together with the internal doc change diff.


remove deprecation warning about frame_src

frame-src was un-deprecated: https://w3c.github.io/webappsec-csp/#changes-from-level-2
Therefore I think this warning should be removed.
All PRs:

[ ✔  ] Has tests
[n/a?] Documentation updated

Thanks @bobjflong! I agree with @eugeneius on the assertion.
Should we add a warning deprecating child-src? I'm a little foggy on the details but I think encouraging the use of frame-src and worker-src over child-src (which envelops frame/worker) is the direction the spec is going.

Should we add a warning deprecating child-src?

☝ wouldn't block shipping this, but this did prompt the conversation.

There is no need to set both as the code prefers one, falls back to the other, and warns if the values do not match. Which setting it prefers should be swapped as well.

Thanks, would it be possible to get a new version with these changes? Or maybe some advice on when a new version might be made available?

@bobjflong release in 3.6.3


How to use Github Actions instead of Travis

Hello, I am new to github and tf.js
I forked this repo and am trying to use Github Actions instead of Travis since Travis-CI has changed, but the pages is perpetually loading the models - see https://xiaolangkong.github.io/arbitrary-image-stylization-tfjs/
Please help.

Hi, just add dist/bundle.js into project, bundle.js you can find in sources of Demo site.


Cmake cli output filename option

This PR adds an option to change the default output filename. When the -DBUILD_CLI=ON, the default output filename will be set as out.STEP

LGTM - there are probably a few ways to accomplish this, but if this works it's fine.


fix issue where database name was not completed when creating alias

The database name wasn't completed in the CREATE ALIAS foo FOR DATABASE statement as it was caught in the logic for not suggesting old names when creating new ones. I'm uncertain if there's a more sustainable way to catch this without updating the grammar

Looking nice! Do we want a changeset for this?


Application.current.Exit() freezes on Mac OSX.

I have a button that can close the app, it uses Application.Current.Exit(). The app is freezing (spinning colorwheel) when this is called on Mac OSX. The user must then force quit. Is this still the recommended way of quitting an app?
The last time I'm 100% sure it was working was before 0.7.0.

@danwalmsley is the still an issue?

It'd now be (with v11) and works as expected.
 if (Application.Current.ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop)
{
    desktop.TryShutdown();
}


Explicitly mention the install command requires Kubernetes version

Installing a custom version of kubectl with curl requires users to provide the Kubernetes version in the curl command. Since this document page is in the context of kubectl, there's a chance users might use the kubectl version. Update the doc to explicitly mention the command requires the Kubernetes version.

@chetan-rns thanks for the PR! I'm not against this merging but I do feel like it's more accurate as-is. The version originally is referring to the version of kubectl and kubectl matches Kubernetes (implied version).
I wouldn't mind having another person weigh in though...

Thanks @jimangel. The curl command wasn't working due to a different error on my side. Will be closing this


Remove setup steps unnecessary when travis runs on darwin

Many of the setup/dev programs installed are not used because no testing
is executed on GOOS=darwin builds. Makes sense to remove them and make
darwin runs much shorter.
Signed-off-by: Phil Estes<EMAIL_ADDRESS>

LGTM

LGTM


FW query: query one sub-address in parallel

Puts first subaddress in with parallel addrs:
[[('toyota', 1968, None), ('toyota', 1937, None), ('toyota', 1953, None), ('toyota', 2016, None), ('toyota', 1872, 15), ('toyota', 2018, None), ('toyota', 2002, None), ('toyota', 1920, None), ('toyota', 1924, None), ('toyota', 1793, None), ('toyota', 2017, None), ('toyota', 1984, None), ('toyota', 1988, None), ('toyota', 1792, None), ('toyota', 2001, None)], [('toyota', 1872, 109)], [('toyota', 1872, 44)], [('toyota', 1872, 95)], [('toyota', 1872, 199)]]
Saves 0.3 seconds for Toyota and worst-case, 0.1 seconds for most other cars.

[ ] should de-duplicate this code first

@gregjhogan besides the clean up I want to do (remove duplicate logic), do you know of any potential issues with querying one subaddress with the rest of the non-subaddressed addresses? Was it done out of caution that another address was the same as the subaddressed one, or unintentionally?


New touch command "Start from newest"

What do you think about a new feature to restart the slideshow by a new touch command. So you can quickly see if new photos have arrived in your absence. Provided of course that the photos are sorted by Creation Date.

I don't think this is very useful for most users, since the frame is not accessible directly. At least I built three of them and distributed them among my family.
Hence, I came up with another solution, which I want to create a PR for, when I find the time. Until now, it is just quick and dirty without config parameter or so..
In bot.js, in the function of this.bot.on(['photo, 'video', 'document'], ..., I check for the extension of the arrived file. If it is not one of the known formats (mp4, gif, png, jpg), I let the bot send a reply that the format is not supported. In case of the known formats, it replies with an emoji (" :+1: :movie_camera: " for Video, " :+1: :camera_flash: " for images). I find this very handy, since I get a direct reply on my sent image within telegram without doing anything.
You can find it in my fork. Let me know what you think about this approach

I think you got me wrong. I gave my grandma a TeleFrame. Now she's out all day while I send her new pictures. When she comes home in the evening she would like to see if new pictures arrived and jump directly to the new pictures instead of waiting until they are shown in the slideshow.

Indeed, I got you wrong. Now I like your idea :)

We can implement that. But I would need a suitable CSS class definition from the pool of fontawesome for the symbol in the touchbar

What do you think of these for one or more new photos arrived since last touch on symbole?
https://fontawesome.com/icons?d=gallery&q=photo

It's fine for me.


Link to One Pager is broken

The link on the README to the one pager is broken. Somebody moved it into the trash

fixed - thanks for flagging


Targeted gene set models

We have a gene set derived from the Nanostring nCounter PanCancer IO 360™ Panel. It's possible to download the gene list of this panel from here.
The question here is: can we use this targeted gene panel to build a model? How well does a random gene set of the same size do (negative control)?

Experimental design:

Run models with targeted Nanostring gene set using same train/test allocations as baseline models
Run models with random gene sets (same size as Nanostring gene set) using same train/test allocation as baseline models

Repeat this 10x

Visualization:

Two panels, one for targeted gene set, one for random gene sets
For each train/test allocation, define delta-kappa = (Targeted or Random kappa) - (Full model kappa)

Is delta kappa close to zero for targeted gene set? Is delta kappa greater (more negative(?)) for random gene sets?
@jaclyn-taroni 👋


Push images to ghcr

Current dependencies on/for this PR:

main

PR #1   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 8, 3:43 PM: @AngelOnFira started a stack merge that includes this pull request via Graphite.


Cherrypick bt tester fixes

Cherry-picked the bt tester changes that will fix host qualification tests.

Closing the PR as upmerge is just started including changes on this PR


⚠ Bofrost.de has degraded performance

In 17e4c63, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 807 ms

Resolved: Bofrost.de performance has improved in 1b36757 after 9 minutes.


The script stopped working :  KeyError: 'data'

Thank you for the tool.
Seems like there has been some change in the API from Hackerone, causing the script to crash.

Hope you can take a look at it.

New api was rolled out :(

I think I fixed it: https://github.com/defparam/h1passets/pull/9

Thanks! I made a small change to the query. One of the keys is no longer used and wasn't used in my script anyway. Try it out now should be fixed


Variable substitution doesn't work in exec commands

One use case for this tool is to be able to run a one off command referencing the variables.
cf-vault exec test -v -- curl -sv -H "X-Auth-Key: $CLOUDFLARE_API_KEY" https://api.cloudflare.com/...

However, the variable substitution is attempting to happen before the new process is spawned resulting in the value being empty and the resulting command being:
curl -sv -H X-Auth-Key:  https://api.cloudflare.com/...

confirmed this has been fixed somewhere between opening this and 0.0.8. the following now works
cf-vault exec [profile-name] -- echo $CLOUDFLARE_API_TOKEN


[BUG] StartProviderAck does not include provider_ref

Describe the bug
When starting a provider via the command interface, the resulting Ack does not include the provider reference and is instead blank.
To Reproduce
Steps to reproduce the behavior:

Launch a wasmcloud host (using wash up is a simple option)
Run ctl start provider wasmcloud.azurecr.io/httpserver:0.11.1 -o json
Examine provider_ref field

Expected behavior
Similar to actor_ref which is included in the ack here, similar logic should be added to the start_provider logic further down in the handlers file.
**Environment (please complete the following information) **

OS: [e.g. Linux, MacOS, Windows]: MacOS
Architecture: [e.g. x86_64, arm64]: x86_64
Shell [e.g. bash, zsh, powershell]: zsh
wasmcloud version [e.g. 0.15.0]: 0.15.1

Just as long as we know that we can't include information that requires the entity to have been started, since the ack for the provider start is returned prior to the provider being loaded/started (e.g. we can't include its public key)

Yeah it looks like the provider_ref is available as part of the command (as it's what information we need to try to start a provider) so we'd just be returning that


CI/CD pipeline using CodePipeline

CI/CD pipeline for Chatbot using CodePipeline

Working now using lambda-maven-plugin after the following issues are fixed:

https://github.com/SeanRoy/lambda-maven-plugin/issues/73
https://github.com/SeanRoy/lambda-maven-plugin/issues/72


Thread unsafe processing in ProtocolCodecFilter during wseb realignment

https://github.com/kaazing/tickets/issues/450
ProtocolDecoderOutput#flush() is being called from two threads during realignment

The thread does the decoding and calls flush()
Session is realigned during flush (as it call messageReceived on the upper layer)
REGISTER_EVENT is sent by setIoAlignment, and that calls flush again

So, synchronizing the access to flush(). Also, old thread doesn't continue
processing the decoding and allows new thread to take over decoding/processing

Looks great, @jitsni, including the break-early logic to let the initial thread unwind quickly during realignment. 😄


Remove all sections when removing manual

Rummager defaults to returning 10 results if a count isn't specified, so the
rake task to remove a manual and all its sections was only removing up to 10
sections and leaving the rest. The largest manuals we know of have less than
3000 sections, so a limit of 5000 should always be large enough.
Also withdraw the manual after its sections, so that if the script exits early for some reason it won't error on a second run.

Looks good to me :+1:


UNTESTED GRAPHICS APIS

  Description: Testing of all APIs is not complete.  See
               http://nuttx.sourceforge.net/NXGraphicsSubsystem.html#testcoverage
  Status:      Open
  Priority:    Medium

Link seems broken.
Is the referred information available to be posted here?

@fjpanag it should be this one: https://cwiki.apache.org/confluence/display/NUTTX/NX+Graphics+Subsystem#testcoverage


[BUG] Mods menu doesnt work

Describe the bug
The mods menu will not respond to the ESC key, causing it to never close. You need to restart your game to close it which is a problem.
To Reproduce
Steps to reproduce the behavior:

Go to the Main Menu
Click on Mods
Press ESC/Escape key
You can never leave

Expected behavior
What is expected to happen is the mods menu disappearing as soon as you press the ESC key, and sending you back to where you entered it, for example, the Main Menu
Additional context
The additional context is that ill fix it after 3.0.0b1 comes out. this is lower proirity to me, unless fin fixes it.

there is no way
did i just find the problem

@ThatFinnDev did you make sure SR2EInputManager.Update() was being called because it wasnt

bro


Use conditional with handlebars

Is it possible to test {{value}} in template handlebars to do conditional color rendering ?
Thanks

Hi @toog,
To do that, this what I do :

I add a computed column (say col1) with a formula to generate green ou red, upon previous columns.
Ex: col0 > 0 ? "green" : "red"
I add another computed (say col2) column with this template :
{{value}}

Hi @Fabien
Thanks a lot i’ll try rapidly this ..

I close the issue, given that question is answered.


@1.6.0 - puppeteer update, devdeps updates

close #217

Coverage decreased (-0.0%) to 99.242% when pulling 430de070a020bfb7e73fbeca91fde4eefc8154f3 on rc-1.6.0 into be4dea4bba78fc20c4ecfd0fb869b7b2ced7521e on master.


add ESLint

add linting using the Airbnb approach for enhancement and sleekness of code

@sego90 Great job! This all looks wonderful!


abnormal acetylcholine level

abnormal acetylcholine level (a child abnormal hormone level MP:0003953 and abnormal neurotransmitter level MP:0002204)
DEF: anomaly in the amount of acetylcholine, an ester of acetic acid and choline; acetylcholine is a major neurotransmitter and neuromodulator both in the central and peripheral nervous systems; it also acts as a paracrine signal in various non-neural tissues
SYN: abnormal Ach level
SOURCE: GO:0008291, CHEBI:15355
increased acetylcholine level
DEF: greater than the normal amount of acetylcholine, an ester of acetic acid and choline; acetylcholine is a major neurotransmitter and neuromodulator both in the central and peripheral nervous systems; it also acts as a paracrine signal in various non-neural tissues
SYN: increased Ach level

Added new terms:
abnormal acetylcholine level MP:0030675
increased acetylcholine level MP:0030676


external_table column_type uses default even if other precision is specified

Terraform CLI and Provider Versions
Terraform v1.6.1
Provider version 0.82.0
Terraform Configuration
resource "snowflake_external_table" "external_table" {
  provider     = snowflake.sys_admin
  database     = var.target_database_name
  schema       = var.target_schema_name
  name         = var.external_table_name
  comment      = var.description
  file_format  = var.file_format
  location     =<EMAIL_ADDRESS>  pattern      = var.pattern
  partition_by = var.partition_by

  dynamic "column" {
    for_each = var.columns
    content {
      name = column.value.name
      type = column.value.type
      as   = "(${column.value.as}::${column.value.type})"
    }
  }
  auto_refresh = var.auto_refresh
}

Expected Behavior
Expected the external_table column to be cast as the type described in 'type'.
{
name = "RECAPTCHA_ASSESSMENT_SCORE"
type = "NUMBER(2, 2)"
as   = "GET($1, 'recaptcha_assessment_score')"
}
should become: RECAPTCHA_ASSESSMENT_SCORE NUMBER(2, 2) AS (TO_NUMBER(GET($1, 'recaptcha_assessment_score'), 2, 2))
Actual Behavior
It seems as though the precision specification is being ignored or replaced with the type default for the column type casting but not for the read expression type:
RECAPTCHA_ASSESSMENT_SCORE NUMBER(38,0) AS (TO_NUMBER(GET($1, 'recaptcha_assessment_score'), 2, 2))
We saw similar issues occur when type is:
VARCHAR(1000); It was changed to BOUNCE_REASON VARCHAR(16777216) AS (CAST(GET($1, 'bounce_reason') AS VARCHAR(1000)))
NUMBER(9,2); TRANSACTION_AMOUNT NUMBER(38,0) AS (TO_NUMBER(GET(VALUE, 'c10'), 9, 2))
Steps to Reproduce

terraform apply

How much impact is this issue causing?
High
Logs
No response
Additional Information
The file_formats for each of these occurrences varied between CSV, Custom JSON_GZIP, AVRO
It only seems to be an issue when we are not using the default precision for the type cast.

Hey @justin-ramirez-gametime
I'll take a look at it as soon as possible (probably this or next week).
Thank you for reporting an issue.

Hey @justin-ramirez-gametime
Could you check if the issue persists in the latest version of the provider?


Move menu button to right on mobile

work in progress
Trello card
Relocate menu button on mobile
Context
On mobile, the menu button currently uses quite a lot of screen space
Changes proposed in this pull request
Move the menu button to the top right on mobile
Guidance to review
Please review on mobile/tablet/desktop in portrait and landscape orientations

A couple of initial comments from me @martyn-w - although I think that you really need proper design input before making any changes based on my thoughts!
1) Menu needs extending
On mobile, it looks odd that the dropdown menu only takes up half the screen width?

2) Logo
I think the logo has now moved too far away from the brand logo - the text remains the same size but takes up proportionally more space in the coloured background. There is a bigger issue around the logo re matching it to brand guidelines, but I think the issue is exacerbated here @martyn-w

3) Button position
The button feels very close to the edge at certain widths (this is iPhone 12 in the emulator) @martyn-w

Closing for now until we have a new resizable logo image


Problems with large image

Hi,
I need crop the image to size 1024px x 1024px.
Is possible made this cut with a box of 400px X 400px?
I need of a small box but the image size final in 1024px.
Thanks

Of course. The cropper support this by default. For example:
$('img').cropper({
  aspectRatio: 1, // 1024 / 1024
  ready: function () {
    // Get a 1024px x 1024px cropped canvas
    var croppedCanvas = $(this).cropper('getCroppedCanvas', {
      width: 1024,
      height: 1024,
    });

    // Get a 1024px x 1024px cropped JPEG image
    var croppedImage = croppedCanvas.toDataURL('image/jpeg');
  }
})


Issue/page view

Description
Cleanup of the paging and filtering

In its current state, this duplicates quite a bit, this is on purpose, to get maximal decoupling.
Are there sufficient docs?
Should I push this forward further?  (i.e. apply it more widely)
Which is version should this go into?

Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[ ] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Pull request rejected by merge tool. The tests for this branch did not succeed.

Processing this pull request

Pull request rejected by merge tool. The tests for this branch did not succeed.

Processing this pull request

Failed to merge changes into iso5 due to merge conflict. Please open a pull request for these branches separately by cherry-picking the commit that was made on the branch master (git cherry-pick 514c39c3dc0bc3b51790d60f526cbdf13789f7f7).

Merged into branches master in 514c39c3dc0bc3b51790d60f526cbdf13789f7f7

Not closing this pull request due to previously commented issues for some of the destination branches. Please open a separate pull request for those branches by cherry-picking the relevant commit. You can safely close this pull request and delete the source branch.

This branch was not deleted as it seems to still be in use.

taken over by #5078