Feature/refine type sys

Codecov Report

Merging #3 (390c7b7) into master (39375e0) will increase coverage by 4.63%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   87.86%   92.50%   +4.63%
==========================================
  Files           4        4
  Lines         206      200       -6
  Branches       38       36       -2
==========================================
+ Hits          181      185       +4
+ Misses         17        8       -9
+ Partials        8        7       -1

Flag
Coverage Δ

unittests
92.50% <95.83%> (+4.63%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/index.ts
93.97% <0.00%> (ø)

src/colors.ts
97.14% <100.00%> (+17.59%)
:arrow_up:

src/utils.ts
87.83% <100.00%> (+3.77%)
:arrow_up:

src/variables.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39375e0...390c7b7. Read the comment docs.

Updated the type system
Removed unused code
Refactored the checkRange function
Increased code coverage


Allow custom styling of row action buttons

This change allows users to set custom CSS classes for row action buttons. We use it here to add color classes to buttons.

Also added a small fix for multi-select dropdowns so they look right.

Hey @zilti what's up with this one? I never got a reply to my comment. If you no longer want to submit this then close it, otherwise I'd appreciate the patch

Closing due to inactivity.


Cannot print serial ports on Windows 10

Maybe I'm doing something wrong, but I could not make the example to work on Windows 10.
Here is the reproduction of the error:

╰─❯ deno upgrade

Looking up latest version
Found latest version 1.34.1
Downloading https://github.com/denoland/deno/releases/download/v1.34.1/deno-x86_64-pc-windows-msvc.zip
Deno is upgrading to version 1.34.1
Upgraded successfully
Release notes: https://github.com/denoland/deno/releases/tag/v1.34.1
Blog post: https://deno.com/blog/v1.34

╰─❯ git clone https://github.com/DjDeveloperr/deno_serial.git

Cloning into 'deno_serial'...
remote: Enumerating objects: 77, done.
remote: Counting objects: 100% (77/77), done.
remote: Compressing objects: 100% (59/59), done.
Receiving objects:  58% (45/77)used 60 (delta 13), pack-reused 0
Receiving objects: 100% (77/77), 29.87 KiB | 2.99 MiB/s, done.
Resolving deltas: 100% (23/23), done.

╰─❯ cd .\deno_serial\examples\

╰─❯ deno run .\print_ports.ts

error: Uncaught TypeError: Deno.dlopen is not a function
export default Deno.dlopen("/System/Library/Frameworks/IOKit.framework/IOKit", {
                    ^
    at file:///C:/TEMP/deno_study/deno_serial/src/darwin/iokit.ts:5:21

╰─❯ deno --version

deno 1.34.1 (release, x86_64-pc-windows-msvc)
v8 <IP_ADDRESS>
typescript 5.0.4

╰─❯ $PSVersionTable.OS

Microsoft Windows 10.0.19045

PS:  I apologize. for not answering your former ask for PR, I did not saw your message. My fault.
related #2

Sorry, I pushed some unfinished macOS platform code which is causing this error. I'll update it after work today.

I have some equipment here to connect on the serial, so we can perform an field test on the lib.

I've cleaned up some unfinished stuff. Windows backend should work now.

Not working yet, but the error message changed which is good.
╰─❯ deno run --unstable --allow-ffi print_ports.ts
error: Uncaught TypeError: Cannot convert object to primitive value
    return Number(Deno.UnsafePointer.of(v));
           ^
    at Number (<anonymous>)
    at Module.toPointer (https://raw.githubusercontent.com/DjDeveloperr/deno_win32/18563d7/util.ts:7:12)
    at Module.SetupDiClassGuidsFromNameA (https://win32.deno.dev/18563d7/Devices.DeviceAndDriverInstallation:17811:102)
    at SetupDiClassGuidsFromNameA (file:///C:/TEMP/deno_study/deno_serial/src/windows/enumerate.ts:74:21)
    at getPortsWin (file:///C:/TEMP/deno_study/deno_serial/src/windows/enumerate.ts:118:19)
    at getPorts (file:///C:/TEMP/deno_study/deno_serial/src/serial_port.ts:7:12)
    at file:///C:/TEMP/deno_study/deno_serial/examples/print_ports.ts:3:15

Oh right, I need to update the Windows API bindings - seems like a Deno FFI update broke them

I've updated win32 version, try now!

Not yet, but less errors than before.
╰─❯ deno run --unstable --allow-ffi print_ports.ts

error: Uncaught TypeError: Cannot convert object to primitive value
    unwrap(Number(devInfoList));
           ^
    at Number (<anonymous>)
    at getPortsWin (file:///C:/TEMP/deno_study/deno_serial/src/windows/enumerate.ts:126:12)
    at getPorts (file:///C:/TEMP/deno_study/deno_serial/src/serial_port.ts:7:12)
    at file:///C:/TEMP/deno_study/deno_serial/examples/print_ports.ts:3:15

Pushed a fix again

I have 3 serial ports currently. I can see them through the windows device manager app.
But the lib cannot identify it.
╰─❯ deno run --unstable --allow-ffi print_ports.ts
No serial ports found.

Do you have a windows machine ?

I only recently switched to a Mac, but I can test on my old Windows machine later.
Today I also explored using the Rust crate tokio-serial for implementing Web Serial API in Deno itself, and it works pretty flawlessly. Trying to implement Serial API only using system libraries via FFI is getting unnecessarily complicated because of the less control over threading in non-blocking calls and some other factors.
The best option seems to be implementing it in Rust and exposing a higher-level interface to Deno via FFI, or simply just implementing this API (since it is a web standard) and PR'ing it to Deno, which honestly sounds great. I'll give it some more time and finish my implementation to integrate Web Serial API into Deno!

related https://github.com/denoland/deno/issues/9710


Add settings (to UI)

I see settings in the /lib/ file, but there's no UI to edit them.

@JonathanWolfe, thanks for your report! Should be fixed in next patch update


$state.go('^') should transition to first non-abstract parent state

Whereas $state.transitionTo('^') should stay as it is (throws an exception).
Naive implementation is very easy:
$state.go = function go(to, params, options) {
      // special case
      if(to==='^'){
        to = $state.$current;
        do{
          to = to.parent;
        }while(to.abstract)
      }
      return this.transitionTo(to, params, extend({ inherit: true, relative: $state.$current }, options));
    };

But wouldn't that be somehow inconsistent with the rest ?

+1

+1

+1

+1

Closing this really old issue.
I don't think we should change the semantics of what "^" means (parent state).
The closest navigable parent can be found at
$uiRouter.globals.$current.parent.navigable


UnicodeNormalization.UChar:generateUData () is too complex

Hello,
I'm using this Nuget Package (V1.0.3) in a PCL with Xamarin.Forms application (Thanks for your work).
But on both Android and iOS application, when I call "text.Normalize(NormalizationForm.FormD)" there is an exception :
UnicodeNormalization.UChar:generateUData () is too complex
I roll back to the V1.0.1 version of the package, and no problem...

Interesting. I changed how the normalization data is stored in memory,
thinking it would be better, but turns out it didn't work for Xamarin.
Thanks for the notice.
On Tue, Jun 28, 2016 at 7:12 AM, Jérôme Liger<EMAIL_ADDRESS>wrote:

Hello,
I'm using this Nuget Package (V1.0.3) in a PCL with Xamarin.Forms
application (Thanks for your work).
But on both Android and iOS application, when I call
"text.Normalize(NormalizationForm.FormD)" there is an exception :
UnicodeNormalization.UChar:generateUData () is too complex
I roll back to the V1.0.1 version of the package, and no problem...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Turo-NET/UnicodeNormalization/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe/AAvRr5WpldCr_9JjXOCDMSDc-I9Os-Dcks5qQQ-egaJpZM4JACKy
.

--
—Arturo Torres Sánchez

Sorry it took so long. It's already fixed in version 1.0.4, along with Unicode 9.0.


mx:Alert Prevents Module From Loading in IE

The main app:
<?xml version="1.0" encoding="utf-8"?>
<mx:Application xmlns:mx="library://ns.apache.org/royale/mx" xmlns:fx="http://ns.adobe.com/mxml/2009"
		   applicationComplete="init()">
	<fx:Script>
		<![CDATA[
			private function init():void
			{
				ml.url = "Test1.swf";
			}
		]]>
	</fx:Script>
	<mx:VBox width="600" height="600">
		<mx:ModuleLoader id="ml"/>
	</mx:VBox>
</mx:Application>

Test1.mxml :
<?xml version="1.0" encoding="utf-8"?>
<mx:Module xmlns:mx="library://ns.apache.org/royale/mx"
	xmlns:fx="http://ns.adobe.com/mxml/2009" width="500" height="500">

<fx:Script>	<![CDATA[
	import mx.controls.Alert; // delete this line to see module in IE
]]></fx:Script>
<mx:Label text="hello from module"/>
</mx:Module>

Removing the import means module is loaded, leaving it means it hangs.
I'm running this in debug mode.

It's a mystery to me why dialogPolyfill.as is even referenced here. The only places I see dialogPolyfill referenced are in Jewel Alert and in mdl Dialog. Where is mx Alert getting this?

Good question.  Sometimes there are clues in the _deps.js and other .js files.  Search for polyfill and see how it gets referenced.

It was bugging me so I looked.  The compiler is not being smart about grabbing inject_html from externs.  It does not check whether an extern is actually used or not.
Still, though, we want to fix the pattern in case someone does use inject_html, so my suggesting to eliminate inject_html and replace with inject_js still seems like a good idea.

Fixed with 14322f1


Latest update breaks round avatar icons in friends

The latest update steam update has made the Steam Friends icons completely broken.

Mocha Theme

Known bug, been trying to fix for a while but its spaghetti

understandable


Using er patcher with other launch properties

I really want to use er-patcher with another launch properties and mods for Steam Deck
Currently using:
echo "%command%" | sed 's/start_protected_game/eldenring/' | WINEDLLOVERRIDES="dinput8.dll=n,b" sh
How would I combine it with er patcher ultrawide only? Tried after | but did not work
Thanks

this sed 's/start_protected_game/eldenring/' can be disabled since er-patcher already disables EAC
so it should look like this
python er-patcher -- env WINEDLLOVERRIDES="dinput8.dll=n,b" %command%

do you know how I could launch this with Gamescope for HDR?
python er-patcher -u -- env
ENABLE_GAMESCOPE_WSI=1 DXVK_HDR=1 gamescope -W 3440 -H 1440 -f -r 165 --hdr-enabled %command%


recorder tests fail with latest superagent

By running
$ node tests/test_recorder.js

I get 4 failing tests, all due to diffing deepEquals on objects given by superagent.
I'm removing test_recorder.js for now from test.js, but this needs to be fixed soon.

Ok, I'll look into this.

@ierceg thanks.
Just so you know, I think it's a side effect of updating the version of superagent.

Yep, figured as much. It now correctly reports 405 so I fixed the tests.


The webapp should show a graphical representation of the programs and activities

Description
Once the work for issue #415 is complete, we should create a very basic view of the programs and activities returned from the API request as a stepping stone to having the calendar in place.
Details and resources
This does not need to be fancy. It should just show the formatted details of the default program and its activities (with time in the browser's time zone, not UTC). This is a necessary prerequisite for showing the data in the calendar.
Checklist

[x] This issue is linked to the appropriate project.
[x] This issue has appropriate labels.

Update for today: team has completed work on this ticket, but that work cannot be merged until the work from ticket #415 is merged.


[ENHANCEMENT] Keep installation options for future versions

Please confirm these before moving forward

[X] I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This improvements refers to an existing feature. If you want to suggest a new feature, please use this template
[X] This improvements is not a bug. If you want to report a bug, please use this template

Describe the improvement
The update installation, found under "Package details" when in the "Discover Packages" or "Software Updates" tab, currently reset for every update. I believe they should instead be saved for future versions of the same package. Of course this does not apply to the option "Version to install", but to me it seems likely that users who install a package with any of the other options selected once will likely want to do so for the next updates as well.
Describe how this improvement could help users.
This improvement would help users because then they will not have to select these options again for every update.

#1291 seems similar, but it was more referencing that the install options cannot be found in the "Installed Packages" tab.

They require the same implementation, so I will close this issue as duplicate


python311Packages.qcodes: 0.40.0 -> 0.41.1

Changelog: https://github.com/QCoDeS/Qcodes/releases/tag/v0.41.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 265467 run on x86_64-linux 1

16 packages built:

python310Packages.cf-xarray
python310Packages.cf-xarray.dist
python310Packages.qcodes
python310Packages.qcodes-contrib-drivers
python310Packages.qcodes-contrib-drivers.dist
python310Packages.qcodes-loop
python310Packages.qcodes-loop.dist
python310Packages.qcodes.dist
python311Packages.cf-xarray
python311Packages.cf-xarray.dist
python311Packages.qcodes
python311Packages.qcodes-contrib-drivers
python311Packages.qcodes-contrib-drivers.dist
python311Packages.qcodes-loop
python311Packages.qcodes-loop.dist
python311Packages.qcodes.dist


Failing tests in IE 10 because pbf calls the undefined method ArrayBuffer.isView

On IE 10 (Windows 7) the following tests fail:

ol.featureloader

ol.featureloader.tile

sets features on the tile and updates proj units

ol.format.MVT

#readFeatures

uses ol.render.Feature as feature class by default
parses only specified layers
parses geometries correctly
parses id property

All with a TypeError: `Object doesn't support property or method 'isView'.
This comes from ol3/build/ol.ext/pbf.js, Line 106, which reads:
this.buf = ArrayBuffer.isView(buf) ? buf : new Uint8Array(buf || 0);

Even though IE 10 has ArrayBuffer (see MDN), it lacks the static method ArrayBuffer.isView(arg) (see MDN)
polyfill.io doesn't have a polyfill for this method, but one can implement one for our test suite. PR to come.

@marcjansen see #5991

Ahh missed that. I was about to submit a PR with our own polyfill, like below:
/*global window*/
/**
 * This is a polyfill for the static method `isView` of `ArrayBuffer`, which is
 * e.g. missing in IE 10.
 *
 * @fileoverview
 */
(function(win) {
  if (!('ArrayBuffer' in win)) {
    // no ArrayBuffer, no polyfill
    return;
  }
  if ('isView' in win.ArrayBuffer) {
    // already defined, done
    return;
  }
  var nonViewToStrings = [
    '[object Array]',
    '[object Object]',
    '[object ArrayBuffer]'
  ];
  var isViewToStrings = [
    // The TypedArray types
    '[object Int8Array]',
    '[object Uint8Array]',
    '[object Uint8ClampedArray]',
    '[object Int16Array]',
    '[object Uint16Array]',
    '[object Int32Array]',
    '[object Uint32Array]',
    '[object Float32Array]',
    '[object Float64Array]',
    // The DataView type
    '[object DataView]'
  ];

  /**
   * Returns `true` if `arg` is one of the ArrayBuffer views, such as [typed array
   * objects](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray)
   * or a [DataView](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView);
   * `false` otherwise.
   *
   * See also the [MDN-documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView)
   *
   * @param {Object|undefined} arg The argument to check.
   * @return {boolean} Whether `arg` is either an ArrayBuffer view or a
   *     DataView.
   */
  var isView = function(arg) {
    if (arg === undefined) {
      return false;
    }
    var argStr = Object.prototype.toString.call(arg);
    if (nonViewToStrings.indexOf(argStr) !== -1) {
      return false;
    }
    if (isViewToStrings.indexOf(argStr) !== -1) {
      return true;
    }
    // false for everything else
    return false;
  };
  // Set it on ArrayBuffer
  win.ArrayBuffer.isView = isView;
})(window);

What do we prefer?

I prefer the solution in #5991.


Android 11 Cannot launch camera, photo library

In android 11 don't work photo library and camera.
Did somebody fix it? Thanks.

Try to add queries it worked in my case. https://github.com/react-native-image-picker/react-native-image-picker/issues/1393#issuecomment-713299590

Try to add queries it worked in my case. #1393 (comment)

Thanks for your answer. I have tried to add <queries> between <intent-filter>, but got the error  unexpected element <queries> when run-android. In which place of manifest did you add <queries>?

Try to add queries it worked in my case. #1393 (comment)

Thanks, that's work!

Thanks, Man! It worked.

Try to add queries it worked in my case. #1393 (comment)

Can you be more specific just got to know about this library and I am facing the same issue.


File renaming: Focus jumping in Icon/Details view

Description
When renaming a file in Detail view, after renaming the focus jumps to the column header (Name). If I switch to small/medium/large Icon view (no idea how it is called in English), the focus jumps to the first file or folder in the location.
Steps To Reproduce

Switch to Details view.
Rename a file.
Focus jumps to column header ('Name').
Switch to small/medium/large Icons view.
Rename a file.
Focus jumps to first item inside the current location.

Expected behavior
Files keeps focus on renamed item after renaming instead of jumping.
Files Version
<IP_ADDRESS> (Store version)
Windows Version
Windows 11 (22000.466)
Relevant Assets/Logs
none

Edited, as I saw crashes when renaming files in Grid/Tiles view has already been reported.

Is this still an issue in v2.4?

It is kind of fixed in v 2.3 (my Store won't download the new 2.4 update). The focus jumps quickly to the header atop the columns, then jumps back quickly to the file edited.


capa is not able to analyze compiled openSLL

Description
capa fails to detect ELF in the following compiled openSSL binary (64 bits ELF): https://www.virustotal.com/gui/file/d51ba239292fc90f8aff5941157d6ebc8c4ad18e1d40540ee789bf07bdf151d0
Removing the exclusion of OS.SYSV in detect_elf_os() fixes the issue.
Steps to Reproduce
capa d51ba239292fc90f8aff5941157d6ebc8c4ad18e1d40540ee789bf07bdf151d0

Expected behavior:
capa analyzes the ELF sample.
Actual behavior:
Capa complains the OS is not supported.
Versions
current master,  standalone tool

I've inspected the referenced file to try to determine how we can auto-detect that it targets Linux. I wasn't able to find any headers/metadata/etc. that specify Linux is the OS. There is an embedded function that shows the version information and references "linux", but I don't think this is something we can feasibly reason about:

There are various dependencies:

libdl, libpthread, and libc are all pretty standard, cross-platform libraries. however, the version references indicate the ABI/symbol version that's needed (ref) and are restricted to glibc. According to the glibc readme, this C library only targets GNU platforms, which are Linux and Hurd (uncommon in practice).
I wonder if its safe to assume glibc dependency -> Linux when we have no other hints?

here's what VT says:

TRiD just barely says Linux. magic doesn't specify, just SYSV. DIE calls out the glibc dependency, but doesn't tie that to linux.

and this 32-bit ELF that i really can't tell, but suspect might be Hurd.

i will propose the following extension to the ELF OS detection algorithm:
if there is GLIBC symbol versioning:
  if arch != 32-bit x86: Linux
  if dynamic section references `libmachuser.so`: Hurd
  if dynamic section references `libhurduser.so`: Hurd
  if linker contains `ld-linux`: Linux
  if linker contains `/ld.so`: Hurd
  else: unknown


[FIX] dropdown misplacement after scrolling

This PR is an extension of https://github.com/facebook/lexical/pull/5290 and is related to the issue
Before

After adding extensive content to the editor, I inserted a table. However, the dropdown for Table Action doesn't appear at all. Upon inspecting the console, it was evident that the dropdown, located at the bottom of the page, fails to display.
https://github.com/facebook/lexical/assets/70982342/4e2168c8-a862-451b-a7ce-8ef478f05390

After

Modifying the dropdown CSS and adjusting the top position of the TableActionMenuPlugin dropdown resolved the issue.
https://github.com/facebook/lexical/assets/70982342/64a1134d-db77-44b1-b62f-4c1a57b78537

I will close this since I have another PR regarding this


feat(nuxt): support separate server tsconfig

🔗 Linked issue
resolves https://github.com/nuxt/nuxt/issues/13920
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Based on the following upstream work in Nitro, https://github.com/unjs/nitro/pull/1021, https://github.com/unjs/nitro/pull/1041 and https://github.com/unjs/nitro/pull/1146, This adds the option of adding an additional ~/server/tsconfig.json with the following content:
{
  "extends": "../.nuxt/tsconfig.server.json"
}

This will prevent Vue-only auto-imports from being visible within Nitro server routes (so, for example, useNuxtApp or useCookie will be marked as undefined).
There is a current limitation in that Nitro auto-imports are still globally visible within the Vue part of the app, which currently seems to be necessary in order for $fetch type inference to work. (Ideas welcome on this!)
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Would it be easier if we have a separation with app/ and server/ directory or it won't change anything?

Would it be easier if we have a separation with app/ and server/ directory or it won't change anything?

Finally with new structure exactly it would probably be much better to also have app specific config IMO that isolates nuxt auto imports within the dir (local modules for example should not see them in auto complete list...)

Separating app/ and server/ with the current implementation wouldn't make any difference as the issue is that we need the nitro auto-imports within scope of the Vue app in order for type inference to work. My current best hope is that I can set up a TS partition setup (which would be aided by app/server separation).

The current limitation is that the IDE will correctly show errors but running vue-tsc doesn't test the separate server directory - its tests are being run solely in the root directory.
I still think this is worth merging, and we can iterate for a better way for users to typecheck their server code separately.


HiveOS wrong report

(2024/Apr/14)(21:05:17)(i) - GPU[0] AMD Radeon RX Vega 56
(2024/Apr/14)(21:05:17)(i) - GPU[1] AMD Radeon RX 570
(2024/Apr/14)(21:05:17)(i) - GPU[2] AMD Radeon RX 470
(2024/Apr/14)(21:05:17)(i) - GPU[3] AMD Radeon RX 470
(2024/Apr/14)(21:05:17)(i) - GPU[4] NVIDIA GeForce RTX 3070
(2024/Apr/14)(21:05:17)(i) - GPU[5] NVIDIA GeForce GTX 1060 6GB

(2024/Apr/14)(21:14:07) - ========================== HASHRATE ===========================
(2024/Apr/14)(21:14:07) - | DeviceID | Algorithm | Pool              | Hashrate | Shares |
(2024/Apr/14)(21:14:07) - | 0        | kawpow    | clore.2miners.com | 18.88MH  | 1/0/1  |
(2024/Apr/14)(21:14:07) - | 1        | kawpow    | clore.2miners.com | 7.04MH   | 0/0/0  |
(2024/Apr/14)(21:14:07) - | 2        | kawpow    | clore.2miners.com | 6.40MH   | 0/0/0  |
(2024/Apr/14)(21:14:07) - | 3        | kawpow    | clore.2miners.com | 6.39MH   | 0/1/1  |
(2024/Apr/14)(21:14:07) - | 4        | kawpow    | clore.2miners.com | 25.51MH  | 3/0/3  |
(2024/Apr/14)(21:14:07) - | 5        | kawpow    | clore.2miners.com | 6.10MH   | 1/0/1  |
(2024/Apr/14)(21:14:07) - ================================================================

GPU 3 Radeon RX Vega 56 report 1 share invalid.
Log show GPU 3 -> AMD Radeon RX 470 create share invalid not Radeon RX Vega 56.
Radeon RX Vega 56 shoud be -> GPU 0
AMD Radeon RX 470 -> GPU 3
Looking API
./h-stats.sh
stats => {"hs":[18866417,7041255,6523043,6514064,25538822,5983662],"hs_units":"hs","temp":[0,0,0,0,0,0],"fan":[0,0,0,0,0,0],"uptime":0,"ver":"0.2","ar":[0,0,0,1,0,0],"algo":"kawpow","bus_numbers":[12,9,8,6,7,13]}
total_hash => {"total_hash_rate":70467263}
khs => 70467263

"ar":[0,0,0,1,0,0] index 4 have 1 invalide share. the order of GPUs is different between luminousminer and hiveos.
https://github.com/minershive/hiveos-linux/blob/master/hive/miners/custom/README.md#h-statssh
"ar": [123, 3], //Optional: acceped, rejected shares
API report wrong values

fixed by : https://github.com/luminousmining/miner/pull/47


Custom import generator

Functional imports when using multiple collections is fiddly and messy because you end up with loads of imports to manage in every source file, and you have to use aliasing a lot to account for commonalities among function names (e.g. freeze, get, etc.). I've discovered that a good pattern is to create an internal collections script that imports all of the required functions and exports them as unified collection types/namespaces. It's better for this to be done by the consuming application, because you lose the ability to tree-shake unused imports, so you want to make sure you only expose the methods you're actually using.
In the docs area, I want a page that lets you select all the collections and methods you want, then automatically generates a script with all of imports and exports ready to go.
Example script that would be generated:
export {batch, isMutable, isImmutable} from '@collectable/core';

import {
  List as _List,
  fromArray as list_fromArray,
  size as list_size,
  get as list_get,
  iterate as list_iterate,
  skip as list_skip,
  take as list_take,
} from '@collectable/list';

export type List<T> = _List<T>;
export namespace List {
  export const fromArray = list_fromArray;
  export const size = list_size;
  export const get = list_get;
  export const iterate = list_iterate;
  export const skip = list_skip;
  export const take = list_take;
}

import {
  Map as _Map,
  empty as map_empty,
  entries as map_entries,
  keys as map_keys,
  get as map_get,
  set as map_set,
  thaw as map_thaw,
  isFrozen as map_isFrozen,
  update as map_update,
} from '@collectable/map';

export type Map<K, V> = _Map<K, V>;
export namespace Map {
  export const empty = map_empty;
  export const entries = map_entries;
  export const keys = map_keys;
  export const get = map_get;
  export const set = map_set;
  export const thaw = map_thaw;
  export const isFrozen = map_isFrozen;
  export const update = map_update;
}

import {
  SortedMap as _SortedMap,
  SortedMapEntry,
  empty as smap_empty,
  get as smap_get,
  set as smap_set,
  thaw as smap_thaw,
  isFrozen as smap_isFrozen,
  update as smap_update,
} from '@collectable/sorted-map';

export type SortedMap<K, V> = _SortedMap<K, V>;
export namespace SortedMap {
  export const empty = smap_empty;
  export const get = smap_get;
  export const set = smap_set;
  export const thaw = smap_thaw;
  export const isFrozen = smap_isFrozen;
  export const update = smap_update;

  export function KeyComparator(a: SortedMapEntry<any, any, any>, b: SortedMapEntry<any, any, any>): number {
    return a.key - b.key;
  }
}

import {
  Set as _Set,
  empty as set_empty,
  add as set_add,
  remove as set_remove,
  values as set_values,
  isEmpty as set_isEmpty,
} from '@collectable/set';

export type Set<T> = _Set<T>;
export namespace Set {
  export const empty = set_empty;
  export const add = set_add;
  export const remove = set_remove;
  export const values = set_values;
  export const isEmpty = set_isEmpty;
}

import {
  SortedSet as _SortedSet,
  empty as sset_empty,
  add as sset_add,
  remove as sset_remove,
} from '@collectable/sorted-set';

export type SortedSet<T> = _SortedSet<T>;
export namespace SortedSet {
  export const empty = sset_empty;
  export const add = sset_add;
  export const remove = sset_remove;
}

Couldn't you also just do
import * as List from '@collectable/list'
Import * as Map from '@collectable/map'

export { List, Map }

I'm pretty sure that rollup and webpack2 would still tree-shaking that (?)

Yeah definitely, it's more about this:
import {get as mapGet, set as mapSet, ......................................} from '@collectable/map';
import {get as listGet, set as listSet, ......................................} from '@collectable/list';
// and way more imports here

vs
import {Map, List} from './collections';

let list: List<string>, Map<number, string>;
// ...
list = List.empty<string>();
let list2 = List.append('a');
map = Map.fromArray([[0, 'a']]);
let map2 = Map.set(0, 'b');

The latter is much easier to manage, it doesn't suffer from having to constantly organise your imports as your code evolves to use or not use a given named import, and you still get tree-shaking, because even though you've bundled a bunch of functions into a singular export, you still have control over what your application uses, without dragging in extraneous stuff that will bloat your bundle with redundant code.


Unexpected page router navigate in Mozilla

If there any German, Japanese etc. and any symbols like these in the url, getHash method returns incorrect result because of wrong encoding of this symbols in the Firefox browser, see window.location.href. And because of this navigate method is triggered.
Navigate method is triggered because we have different urls in checkUrl function in the
var current = this.getFragment(); and in  this.fragment values.
Example in Mozilla:
Result wich is returned by getFragment function:
https://example.com/example?filterBy_city=大阪%2C富山%2C岡山
this.fragment value:
https://example.com/example?filterBy_city=大阪%2C富山%2C岡山
Example in Chrome
Result wich is returned by getFragment function:
https://example.com/example?filterBy_city=大阪%2C富山%2C岡山
this.fragment value:
https://example.com/example?filterBy_city=大阪%2C富山%2C岡山
I find the solution for it using decodeFragment in the getHash method:

Would it be safely to do it this way?

See previous tickets: I believe there was a bug in certain versions of Firefox that made this impossible to work around in Backbone itself.
Do you have a specific change you'd like to propose here?

Hello, I have encountered this same issue while developing for my company and I have investigated it thoroughly. (I have also seen some previous tickets about this.)
Here's my conclusion on this issue:
I believe that the root of the problem is located in these lines of code within the navigate function:

There is no point in decoding the fragment for matching, because this._updateHash() is setting the hash as encoded (as it should), and this.fragment should match parity by being set as encoded as well. However, currently this.fragment is being set as decoded instead, so checkUrl will always trigger a loadUrl for any url with special characters.
The solution is to simply not decode the fragment.
If this solution is chosen, then getPath, getHash, or getFragment should NOT be doing any decoding. All fragment matching should be done using encoded format. If fragment matching is done in a decoded format, it would not be compatible with Firefox.
Let me know what you guys think! If it sounds good, I'll make a PR.

@Daniel-Alonso-Exabeam I realize this reply is rather late, but you are welcome to submit a PR.


Image show as a heat map ... rainbow colors ...

Hi, @praydog . First thank you for you excelent job and for let as use it open.
I am trying to lanch in VR RE7. With OpenVR it only appers in PC. With OpenXR all is correct, except that all 3D environment is like I was in a heat map, rainbow colors everywhere. My glases are Quest2. My GPU AMD 6700 XT 12GB
Any configuration that can I check?
Thanks in advance

https://github.com/praydog/REFramework/issues/307

Thanks @Buzbee . You gave me the solution. My problem was solved by closing Virtual Desktop server in the PC


TypeError: value.indexOf is not a function when using a gradient for strokeStyle

Hi,
I have an error when I want to use a gradient for a line strokeStyle:
"TypeError: value.indexOf is not a function"
I tried to use a gradient for fillStyle and it works perfectly.
I made a JSFiddle:
http://jsfiddle.net/5bbn59rs/4/
Thanks in advance

Looks like width and height was not defined when you created a new C2S. If you open up dev tools on jsFiddle they'll show you the js errors. http://jsfiddle.net/5bbn59rs/5/

any update for this issue?

Am also getting this error with constructor call new Context({ document, width: 1920, height: 1080 })

So, in my case the problem is with Line 383:
if ((style.svgAttr === "stroke" || style.svgAttr === "fill") && value.indexOf && value.ind
     exOf("rgba") !== -1) {

It appears that the logic doesn't expect to have to handle a CanvasGradient object as a value of fill, which is rather standard. This line should check that it's not dealing with a string first by testing for indexOf existence first.

It's expecting a C2S CanvasGradient not a HTMLCanvasElement CanvasGradient. If you create your gradient using ctx.createLinearGradient or ctx.createRadialGradient method on the C2S instance you should not run into the issue.

unrelated to original issue perhaps, but I ran into this same error message when I was passing an object to the fillStyle (object was a Color object from https://www.npmjs.com/package/color)
the HTML5 canvas API presumably stringifies this Color object automatically, but it caused a crash in canvas2svg (solution: just stringify manually before setting ctx.fillStyle)


Add a test for naming, and name stripping

This is to address #633. It is not closing that issue, but it is a start.
Also, this exposes something that I think is a problem: the naming strategy seems pretty broken to me. I think names/options are pretty ill-specified. For instance, looking up options is done in the platforms. Scalding takes the first name that matches:
https://github.com/twitter/summingbird/blob/develop/summingbird-scalding/src/main/scala/com/twitter/summingbird/scalding/ScaldingPlatform.scala#L274
which, does not really make sense if two names match due to a fan-out situation.
The solution I would propose is this:

move the option resolving code to a common location and don't repeat that code on the platforms.
we only return the first name node we can reach on each branch. So, you can only have more than one name if there is a fan-out and you are named on each branch.
Each option has a rule for how to combine if a node has more than one name (fanout) and each of those names has an option set.
default only comes into play if there is no name set.

here is the storm code for getting options:
https://github.com/twitter/summingbird/blob/develop/summingbird-storm/src/main/scala/com/twitter/summingbird/storm/StormPlatform.scala#L129

added #636

If it is too dangerous to change how options work for fear that we will break jobs, we should write very clear rules and a lot of tests for those rules, and link that documentation to def name in Producer.scala

I'm getting a ton of diffs from scalariform, for some reason. I would have assumed we already hit all these files, but maybe not.

Scalding takes the first name which specifies the option right? not the first name? What occurs in a branch scenario is a bit ill defined, but other than that i think the naming at the moment is reasonably well defined isn't it? -- maybe not the best naming strategy but it is at least defined pretty clearly.
Changing the options so only one name could effect a given node would be a large change, also its not clear to me how that would always work. Since users can name a given node more than once, but moreso, if i go .map.name.map.name how does that get resolved? since we will collapse both map's into one physical block of code. But the user doesn't control how we collapse them

It seems the logic is the same in the code for both storm and scalding, isn't it?
Yes, I agree that changing the options is probably a non-starter. And I guess the naming is understandable, though fan-out is ill-defined. You can always side-step that by naming a node before a fanout.
The strange thing is that adding a option below will override the defaults for all nodes above it. That could be a little weird, but I guess people aren't too upset with it.
So, I would backstep: let's refactor to share more code (as this does) and add more tests (which this does) to be clearer about how functionality is working.

Yes i think the logic is the same, or in at least its goal is the same on both platforms. Agree totally about consolidating the options handling and adding the extra tests as you've done here.
Changing the options handling seems like a bit of a non-starter I agree, though fundamentally I wonder if this winds up being very limiting in how one could do graph re-writing. For future generations of this sort of tech probably need to consider how options should be done instead.

Regarding the scala formatting, are you getting it up from sbt or somewhere else? If i manually modify the scalding platform file and re-run it it puts it back to how it is on develop now. (looking at the whitespace changes on the getCommutativity method)

Yeah, I'll check. Maybe I have some global plugin or something.

@ianoc somehow it seems having one of:
addSbtPlugin("org.ensime" % "ensime-sbt" % "0.1.7")

addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.7.5")

in my ~/.sbt/0.13/plugins/plugins.sbt file was resetting the scalariform options.

Interesting, i have the dependency graph one in mine too, so i'd guess its the ensime one.
Looks like it depends on scalaireform @ https://github.com/ensime/ensime-sbt/blob/master/build.sbt#L25 (looks separate to that project just using it, they have it in their project/plugins too for that purpose). odd

had a minor comment about documenting a return. Once thats fixed looks good to me, merge when green

man our storm tests are flakey.

I wonder if we are scooping up OOM errors into trys or futures somehow, and this is making some tests look flakey that are actually OOM errors on travis (at least some of the failures here were OOM, but the tests reported failed not due to exceptions).


Swap to tableView

Swap out the stackview for the cards to a tableview and cells

I chose not to do tableView since that requires that i redo most of my code, and when i could simply have a scrollView and the stackView inside of that it just looked like a better way to do it.


docs: added deployment info

Deployment info

Lina

parameter
value

code_hash
0x9f3aeaf2fc439549cbc870c653374943af96a0658bd6b51be8d8983183e6f52f

hash_type
type

tx_hash
0xaa8ab7e97ed6a268be5d7e26d63d115fa77230e51ae437fc532988dd0c3ce10a

index
0x1

dep_type
code

Aggron

parameter
value

code_hash
0x79f90bb5e892d80dd213439eeab551120eb417678824f282b4ffb5f21bad2e1e

hash_type
type

tx_hash
0x9154df4f7336402114d04495175b37390ce86a4906d2d4001cf02c3e6d97f39c

index
0x0

dep_type
code

The deployment is not part of spec but I think we can keep this information here.

Godwoken testnet_v1.0 is using this deployment.

https://github.com/nervosnetwork/godwoken-info/blob/main/testnet_v1/scripts-deploy-result.json#L122-L131

Which git commit to this deployed omni lock?

Godwoken testnet_v1.0 is using this deployment.

https://github.com/nervosnetwork/godwoken-info/blob/main/testnet_v1/scripts-deploy-result.json#L122-L131

Which git commit to this deployed omni lock?

this PR describes how the script is reproduced, and we have deployed 09f37ee to Lina


Feature package ga docs

Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.11

/lgtm

/lgtm


attempt to subtract with overflow bug for WitnessGenerator

Problem:
When start the witness generator the first time,it will cause an overflow bug.Because the verified block is 0 and NUMBER_OF_STORED_ACCOUNT_TREE_CACHE is 300 while BlockNumber is unsigned type, block - NUMBER_OF_STORED_ACCOUNT_TREE_CACHE will get an negative num.The code is located on function store_account_tree_cache in file database.rs.
connection
            .chain()
            .block_schema()
            .remove_old_account_tree_cache(block - NUMBER_OF_STORED_ACCOUNT_TREE_CACHE)
            .await?;

CodeBase:
branch: master
commit: f958bd54000c5203ed54b55dee073d5b03f192be
Call Stack:
thread 'prover_server_pool' panicked at 'attempt to subtract with overflow', core/lib/basic_types/src/lib.rs:27:1
stack backtrace:
0: rust_begin_unwind
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:498:5
1: core::panicking::panic_fmt
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:116:14
2: core::panicking::panic
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:48:5
3: <zksync_basic_types::BlockNumber as core::ops::arith::Sub>::sub
at ./core/lib/basic_types/src/macros.rs:56:22
4: <zksync_witness_generator::database::Database as zksync_witness_generator::database_interface::DatabaseInterface>::store_account_tree_cache::{{closure}}
at ./core/bin/zksync_witness_generator/src/database.rs:268:44
5: <core::future::from_generator::GenFuture as core::future::future::Future>::poll
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/future/mod.rs:84:19
6: <core::pin::Pin as core::future::future::Future>::poll
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/future/future.rs:123:9
7: zksync_witness_generator::witness_generator::WitnessGenerator::load_account_tree::{{closure}}
at ./core/bin/zksync_witness_generator/src/witness_generator.rs:162:22
8: <core::future::from_generator::GenFuture as core::future::future::Future>::poll
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/future/mod.rs:84:19
9: zksync_witness_generator::witness_generator::WitnessGenerator::prepare_witness_and_save_it::{{closure}}
at ./core/bin/zksync_witness_generator/src/witness_generator.rs:217:86
10: <core::future::from_generator::GenFuture as core::future::future::Future>::poll
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/future/mod.rs:84:19
11: zksync_witness_generator::witness_generator::WitnessGenerator::maintain::{{closure}}
at ./core/bin/zksync_witness_generator/src/witness_generator.rs:274:74
12: <core::future::from_generator::GenFuture as core::future::future::Future>::poll
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/future/mod.rs:84:19
13: zksync_witness_generator::witness_generator::WitnessGenerator::start::{{closure}}::{{closure}}
at ./core/bin/zksync_witness_generator/src/witness_generator.rs:67:36
14: <core::future::from_generator::GenFuture as core::future::future::Future>::poll
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/future/mod.rs:84:19
15: tokio::park::thread::CachedParkThread::block_on::{{closure}}
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/park/thread.rs:263:54
16: tokio::coop::with_budget::{{closure}}
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/coop.rs:106:9
17: std::thread::local::LocalKey::try_with
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/thread/local.rs:412:16
18: std::thread::local::LocalKey::with
at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/thread/local.rs:388:9
19: tokio::coop::with_budget
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/coop.rs:99:5
20: tokio::coop::budget
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/coop.rs:76:5
21: tokio::park::thread::CachedParkThread::block_on
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/park/thread.rs:263:31
22: tokio::runtime::enter::Enter::block_on
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/runtime/enter.rs:151:13
23: tokio::runtime::thread_pool::ThreadPool::block_on
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/runtime/thread_pool/mod.rs:77:9
24: tokio::runtime::Runtime::block_on
at /Users/bj89200ml/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.13.0/src/runtime/mod.rs:463:43
25: zksync_witness_generator::witness_generator::WitnessGenerator::start::{{closure}}
at ./core/bin/zksync_witness_generator/src/witness_generator.rs:66:17
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

It should check current block and NUMBER_OF_STORED_ACCOUNT_TREE_CACHE before remove old account tree cache.

Let me see if I can find out more for you.

Let me see if I can find out more for you.

Thanks and wait for your help.


A label of a checkbox for "idle time" option seems to be inaccurate

Prerequisites

[x] I'm using latest version: v 1.0.0
[x] I've checked Known issues
[x] I've checked Open issues

Description
As far as I understand, v. 1.0.0 changed a wording for one of the options, while related functionality did not changed fundamentally.
In 0.21.1 it was: "Monitor system idle time for natural breaks."
In 1.0.0: "Monitor system idle time (countdown is paused if system is idle)."
A default behaviour from docs:

"Stretchly is monitoring your idle time, so when you are idle for 5 minutes, breaks will be reset until you return."

Also this period can be tweaked if you are a contributor:

"In the preferences file, set naturalBreaksInactivityResetTime to your preferred value (in milliseconds greater than than 20000ms). This is an idle time length, after which Stretchly timers will be cleared and will stay at 0 until the user resumes activity."

Previously it defaulted to the (shortest?) break period, but that are nuances.
If these quotes fully describe how the option works, then the checkbox description should not use words "countdown is paused if system is idle", because it can be understood as "a timer is frozen", and it is not the case. For example, the option can be described as: "timers are reset if system was idle".

Yeah, in Stretchly's language paused = reset (pretty much).
How about "Monitor system idle time (breaks are paused if system is idle)."
And use term "pausing breaks" elsewhere. We don't use term "timers" a lot and now it seems to me that it confusing things as it's rather technical/code term.

How about "Monitor system idle time (breaks are paused if system is idle)."
I think it is better. As a variant - theoretically it can be just "Pause breaks if system is idle", without "Monitor system idle time".


compute shader supported

compute shader supported

Nice. Thank you.
It seems that the backends for metal/OpenGL is not ready yet.
I will test the d3d version and get back to you

oh yes, but I can't manage to run the opengl version on windows(sorry that I can only have a PC), neither do metal.

I'm trying to merge your code and also do some minor tweaks and clean it up.
the main problem is that sokol_gfx.h is reformatted and the diff is completely messed up (I should have probably turned clang-format off for these files).  could you undo formatting the file and just integrate the changes you have made ?

never mind, I'll try to clean it up myself

#7


Installers in workspaces do not seem to work correctly

When using an installer a in workspace with multiple binary crates, generating an installer does... weird things
Mostly this is due to all generated artifacts having name installer.sh
Locally, the installer.sh is overridden by one of the apps, creating an installer for just one of them
In github actions it results in 404: Not Found with one of the installers uploaded. I guess this is HTTP speak for "already exists"?
A simple solution would be to add an app name prefix to the generated installer if multiple installers are built. Probably links in release description will have to be adjusted too...

Oh yes, great point! Do you have a specific multi-binary workspace you can share? I've been waiting for someone with that kind of setup to chime in so I know what behaviours they want (see also #69).

Sure! https://github.com/DCNick3/shin
It has a CLI tool and a game. I probably want them to have different installers, as the audiences are different.
I can imagine wanting to have one installer for multiple binaries though

working on a more holistic fix to this in #111


Elect Project DRI for documentation of Wallet

Responsibilities:

Filling out templates for the project
Ensuring the docs are ready for handoff to DevRel
Working with DevRel on maintenance for new developments
Maintenance of docs to sure they're up to date

This is very outdated, closing.


Removed unused variable in server-rendering test

I removed unused variable.
Thank you.

Thanks, but we may adjust this test to check the layout later. Plus, keep it around doesn't hurt anything.


Fix Atlassian provider

Now using the correct endpoint to exchange the authorization code.
Closes #1352

Thanks!


Tensorflow embedding sensitivity Part2

Hey,
I created now carefully my dataset and balanced it.
I thought words which are not trained have no weight on classification?
But I found, that like:
amount money
is corectly classified (word amount is not part of training data! Money is though)
But
money
gets a different Intent!
Although it should be same since amount was not learned.
My config:

language: "de"

pipeline:
- name: "tokenizer_whitespace"
- name: "ner_crf"
- name: "intent_featurizer_count_vectors"
- name: "intent_classifier_tensorflow_embedding"
  intent_tokenization_flag: true
  intent_split_symbol: "_"

interesting observation, would it be possible for you to share the training data, so I could reproduce it locally. I tried it on my dataset and I get precisely the same results for similar case

interesting observation

I feel I do many interesting observations everytime. :smile: ;)
Normally this should not the case since the word has no weight?
So, if there would be somehow some imbalance this should even not matter?
How would I give you the data privately?

you can send the data to<EMAIL_ADDRESS>

what is this address? Have you created it for me?
What about my other questions above?;)

this is the contact email address for general inquires, you can send the data privately there.
Regarding you other questions:
As I said, I check it locally with our datasets, and the algorithm gives precisely the same results with and without additional unseen words. So they indeed have no weights. I think there is some other issue in your case.
please check forum.rasa.com there is a thread for ideas, etc

So they indeed have no weights.

So, there might be a bug, otherwise the intent shouldn't change even if I would have imbalances?

Not that I aware of. Unfortunately, I cannot debug it, until you provide the script to reproduce it.

No I found an imbalance and removed it such that I have roughly 30 examples for 4 intents now. No this issues is removed?! So it seems there is a bug. Maybe this should investigated more carefully. Do whitespaces palay a role for intents? Maybe it was so overfitting in my case that this one whitespace did the thing...

If you send us the scripts to reproduce the issue, we can investigate it further.

what about this "token_pattern": r'(?u)\b\w\w+\b',?

Please see sklearn's documentation for this: http://scikit-learn.org/stable/modules/generated/sklearn.feature_extraction.text.CountVectorizer.html
token_pattern : string
Regular expression denoting what constitutes a “token”, only used if analyzer == 'word'. The default regexp select tokens of 2 or more alphanumeric characters (punctuation is completely ignored and always treated as a token separator).

Since you diagnosed the problem: https://github.com/RasaHQ/rasa_nlu/issues/1319. I'll close this issue.

Yeahh but you overwrote token_pattern...with this regex...What is the meaning of this regex?
Did I find the solution in #1319?

this regex is default sklearn's regex for token_pattern which picks the words of 2 or more characters and ignores punctuation and whitespaces. For regex documentation please refer to: https://docs.python.org/3.6/library/re.html


Playlist not populating if ending on a /

If the command line string ends on a / character, the playlist is not populated as expected.
Example
Executing
artist TWRP/

does nothing while
artist TWRP

works as expected.

Fixed in  f9c5682


Send the user back where they came after FxA login

Put the current URL in state or the user's session before redirecting to FxA so we can send them back there instead of to the homepage after.

We should probably put something in request.session instead of putting it in the state. There will be a lot of churn on this so it's probably best to keep state more stable.


Fill documentation page and update exports.

Fill documentation page with information and examples
Shorten information in the README
Add brightness_temperature function to convert from radiances to T_b
Make the functions used to extent the package for internal formats public.
Rename functions like _standard_attrib to default_attrib since they are public
Export other helper functions used in examples.

Hi Simon, very nice work! I added some comments, but they deal exclusively with typos :) Merry Christmas and enjoy your break!

@wilzewski
I have now fixed all the comments and also change from "wave number" to "wavenumber" everywhere. Merry Christmas.


Avoid t2b/b2t between vnode and get FSM

This is a port of Krestenkrab's PR :
https://github.com/basho/riak_kv/pull/83
Avoids doing a binary to term on an object that is sent from a vnode to
the get FSM requesting it. This means that the FSM will have to do it on
that side, but it avoids the implicit term_to_binary/binary_to_term when
the object is sent through disterl.  Some tests using a memory backend
on OSX show a decent improvement (~5% in throughput and more in
latency).
The get_fsm fake vnode had to be updated to support the get binary
request.

Can one of the admins verify this patch?


can not connect

elseif self.status==STATUS.CONNECTING then
     local res = sock:receive("*l")

when I call :
 local client = require("websocket").new("<IP_ADDRESS>", 9951)
while true do
    love.update()
end

receive nothing, res is nil. how to resolve it?

That's weird. Thanks for your feedback. But I'm on vacation now. I'll check it 2 days later.
BTW, which language/library is your websocket server written in?

您的邮件已收到，我会尽快查看并回复。。。


Properly untar upterm

Got this error when trying this GH Action out: https://github.com/owenthereal/upterm/runs/1946829318?check_suite_focus=true. Fix it by downloading upterm bins to /tmp and install from there.
BTW, great job of building this GH Action. I will try to make upterm better for use cases like this 😄

We can't access the shared logs from https://github.com/owenthereal/upterm/runs/1946829318?check_suite_focus=true anymore

The logs for this run have expired and are no longer available.

but the I've read the pr. curl -s is for silent, then tar command will now extract to /tmp which makes sense and the install command is now used to put /tmp/upterm at /usr/local/bin/ which also seem to make sense. 👍

I'm sorry I missed this PR. Thanks for the PR and great work @owenthereal , merging.


Check why Travis does not report commit status

@henrikbjorn can you please check this? I can't see the registered hooks.
(Scrutinizer also does not report status upon PRs, nor uses the uploaded code coverage reports)

@henrikbjorn can I ask more access to the org? I would like to setup subtree splitting and travis

Ping @henrikbjorn

Ping @henrikbjorn

Hey. Sorry i must have missed this issue. It seems that i have to make you an Owner in order to give you more access. What access are you missing?

I would like to enable subtreesplit.com and scrutinizer integration for the drivers repo and probably readd travis integration, because commit status is not reported.

It seems subtree split was under some requested thing. I approved it. I can remove travis if you want to readd it. I might need to give up on my control gene :)

Not relevant anymore: switched to GitHub Actions.


Vectorized the Interface Algorithm (EME)

Not ready for merge yet - still working out the kinks and using to better debug Floris' issue

Closing this PR to first remove the large files from old commits and then I will reopen and finish testing before merging


Adds validation APIs needed for downstream SDKs

This PR pulls in the latest updates on the go-sqlparser, and includes:

Better and more complete tests
Better support for typescript and full type checking for all js code
More consistent admin and eslint configs
New functions for

validatingTableName
validateStatement
updateTableNames (needed for ENS support)
getUniqueTableNames

More consistent and helpful error messages
Updates to normalize for more consistent results
Canonical tableName checking
Deprecating configuration for statement size checks (just use the defaults)
Deprecate the structureHash function (no longer needed)

The quality of the Go code is also improved in general, and uses more conventions from go-tableland and go-sqlparser. Test coverage has also gone up significantly (though this is slightly hard to measure due to the WASM code).

I'm putting this back into draft for today because I have to change the approach slightly.


Bug: Pinned folders disappear unexplained

Description
When I'm working with Files, the pinned folders disappear unexplained and I need to close forcedly with task manager or new method for developers 'end task', I don't know hos to reproduce this bug.
this error makes it seem as if I have no anchored element, is more, disappears the arrow to show/hide the list items once restart with the task manager reappears
Steps To Reproduce
before to reload the "files app"

after reload with task manager:

Files Version
<IP_ADDRESS>
Windows Version
24H2 COMPILATION 26100.1591
User ID
f3a85879-45a6-4b6d-935a-2b3e42c591a1
Log File
debug.log

Thanks for the feedback, We're tracking this in #15410. Please use the workaround there, you can check there or click subscribe in the right sidebar for updates.


Android: no background service after I kill the foreground app

I'm doing some experiments with this plugin. As far as I can see, when I kill the foreground app, also the background service is killed.
I can't see any more logs in adb logcat, neither beep or other sound notifications are produced anymore (I'm running the plugin with the boolean  debug at true).
Any idea??

Show me your config

Here is my config (with just an extra line, for de device uuid).
var dev_uuid = $cordovaDevice.getUUID();
var bg_geoloc_opt = {
url: 'http://demochat.europeconsulting.it/savebgposition',
params: {
dev_uuid: dev_uuid
},
debug: true
}
What I am seeing, now, is that the plugin looks working correctly with another device (with Android 4.1.2), but it still is not working with the main device (wich is 4.4.2). In the main device I also turned off de developer mode (in order to avoid some wrong config) without results.
I suppose there could be some issues based on Android version, don't you think?

If you're basically letting the plugin apply default config, what's the
plugin reporting for config in adb logcat?  I don't recall what the plugin
uses as defaults.
Why are you stuck on such old Android versions?  Thé latest version for 4.4
is 4.4.4.
On Wednesday, July 22, 2015, gereko3d<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Here is my config (with just an extra line, for de device uuid).
var dev_uuid = $cordovaDevice.getUUID();
var bg_geoloc_opt = {
url: 'http://demochat.europeconsulting.it/savebgposition',
params: {
dev_uuid: dev_uuid
},
debug: true
}
What I am seeing, now, is that the plugin looks working correctly with
another device (with Android 4.1.2), but it still is not working with the
main device (wich is 4.4.2). In the main device I also turned off de
developer mode (in order to avoid some wrong config) without results.
I suppose there could be some issues based on Android version, don't you
think?
—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-123693427
.

--
Snet from Gmail Mobile

As far as I can see in your Java code, those should be the default values:
private String stationaryRadius = "30";
private String desiredAccuracy = "100";
private String distanceFilter = "30";
private String locationTimeout = "60";
private String isDebugging = "false";
private String notificationTitle = "Background tracking";
private String notificationText = "ENABLED";
private String stopOnTerminate = "false";

About the Android version of my testing device... the producer (Wiko Mobile) haven't released any other updates (so far). And I don't desire/time to spend for any home-made/self-made upgrade...

I'have gone a little bit deeper on this issue.
As I said, the plugin is correctly working on an old 4.1.2 device.
I found that this is a known bug, which was introduced in 4.4.1 and affects 4.4.2 too.
You can find more informations here.
The author of the post also suggested a solution (well, more of a workaorund). As far as I can see in your code (as I said I'm definitively not a Java expert), it seems like you are doing something similar, using the system AlarmManager...
I also tried a little change on your code, trying to comment this.stopSelf(); in onTaskRemoved method. The method, now, apper:
@TargetApi(Build.VERSION_CODES.ICE_CREAM_SANDWICH)
@Override
public void onTaskRemoved(Intent rootIntent) {
    // this.stopSelf();
    super.onTaskRemoved(rootIntent);
}

In this way the service is not killed anymore when I close/kill the application process.
But... It still is not working: I mean, the service is running, but no data are posted to my endpoint (nor can I hear any sound or see any Toast notification, using the debug mode).
At this point, do you have any suggestions? Thanks.

Try installing the premium sample app from Google Play Store in your
problem devices.
As I said, the plugin is correctly working on an old 4.1.2 device.
I found that this is a known bug, which was introduced in 4.4.1 and
affects 4.4.2 too.
You can find more informations here
http://www.androidpolice.com/2014/03/07/bug-watch-stopping-apps-on-android-4-4-2-can-silently-kill-related-background-services-a-fix-is-on-the-way/
.
The author of the post also suggested a solution (well, more of a
workaorund). As far as I can see in your code (as I said I'm
definitively not a Java expert), it seems like you are doing something
similar, using the system AlarmManager...
I also tried a little change on your code, trying to comment
this.stopSelf(); in onTaskRemoved method. The method, now, apper:
@TargetApi(Build.VERSION_CODES.ICE_CREAM_SANDWICH)
@Overridepublic void onTaskRemoved(Intent rootIntent) {
// this.stopSelf();
super.onTaskRemoved(rootIntent);
}
In this way the service is not killed anymore when I close/kill the
application process.
But... It still is not working: I mean, the service is running, but no
data are posted to my endpoint (nor can I hear any sound or see any Toast
notification, using the debug mode).
At this point, do you have any suggestions? Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-124059375
.

--
Snet from Gmail Mobile

Downloaded and tried.
Is the same: as I kill the process, the service is killed too...

Upgrade Android.
Is the same: as I kill the process, the service is killed too...
—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-124067858
.

--
Snet from Gmail Mobile

@gereko3d I noticed that too.. when i kill my app in foreground the service is killed too..
Although the plugin is working fine on my android(lolipop version)...
Maybe your distance configuration is too big and the service is not detecting your movement.
When i was testing i used this configuration to debug:
...
desiredAccuracy: 5,
stationaryRadius: 10,
distanceFilter: 10,
...
In wich file have you did this modification in onTaskRemoved method?
(sorry, my english is not so good ;x)

Directly in the source code (src/android/LocationUpdateService.java).
You have to rebuild it. The easiest way I found for this kind of experimentations:

Remove your cordova plugin (cordova plugin rm org.transistorsoft.cordova.background-geolocation)
Clone the repository in a separate folder (i.e. in a subfolder or your home) using git clone https://github.com/christocracy/cordova-plugin-background-geolocation.git /path/to/yourfolder
Modify the Java source code
Add back the plugin from your folder (cordova plugin add /path/to/yourfolder)

I don't know if there are easiest way to achieve the same goal.
For what concerning the config: as I said the same app (an the background geolocation) is perfectly working on another device, with an older version of Android. I also noticed (as I said in a precedent comment) that killing a spawned service by killing the foreground app is a known bug introduced with 4.4.0... So, I don't think it's a problem with the javascript config of the plugin...

@gereko3d  Thanks for the explaining! I'll try it.
About the bug, i didnt know that... are u sure is it because of the version ? maybe its because of your device.
thanks \o

Let's have a look here: http://www.androidpolice.com/2014/03/07/bug-watch-stopping-apps-on-android-4-4-2-can-silently-kill-related-background-services-a-fix-is-on-the-way/

I'll read! ;]  Thanks!
And the modification in java method also worked!
Another problem...In my device when service is starded a notification shows up and i cant swipe it off! Do you have this same problem?
I wish i could disable this notification, because is boring you know?
\o

Happy ti know I helped you.
For what concerning the notification, I don't think it could be swiped.
On 27 Jul 2015 19:47, "Lucas Almeida"<EMAIL_ADDRESS>wrote:

I'll read! ;] Thanks!
And the modification in java method also worked!
Another problem...In my device when service is starded a notification
shows up and i cant swipe it off! Do you have this same problem?
I wish i could disable this notification, because is boring you know?
\o
—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-125284910
.

You cannot disable the notification due to the nature of the Android
service.
The premium version does not have this notification, however.
On Monday, July 27, 2015, gereko3d<EMAIL_ADDRESS>wrote:

Happy ti know I helped you.
For what concerning the notification, I don't think it could be swiped.
On 27 Jul 2015 19:47, "Lucas Almeida"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

I'll read! ;] Thanks!
And the modification in java method also worked!
Another problem...In my device when service is starded a notification
shows up and i cant swipe it off! Do you have this same problem?
I wish i could disable this notification, because is boring you know?
\o
—
Reply to this email directly or view it on GitHub
<
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-125284910
.

—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-125285601
.

--
Snet from Gmail Mobile

Hey @christocracy !
Are u sure it cant be disabled? So how apps like Swarm does it?
Thanks ;]

This is my plugin.  I made it.  I'm telling you the free version use a type
of service which requires a notification message.  The premium version uses
a different device mechanism.  This cannot be changed
On Monday, July 27, 2015, Lucas Almeida<EMAIL_ADDRESS>wrote:

Hey @christocracy https://github.com/christocracy !
Are u sure it cant be disabled? So how apps like Swarm does it?
Thanks ;]
—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/217#issuecomment-125351631
.

--
Snet from Gmail Mobile


CLEANUP - Differentiate method with more descriptive name

The StatementModifier mixin logic predates the addition of a line_count method added to AST::Node's public API. When I noticed this, I thought perhaps the mixin method could be deleted, and attempted to swap it out.  However, the mixin line_count(node) method does not actually calculate all the lines of a node.  It calculates all the lines of a node that have content. It subtracts empty lines from the count it returns.
This tiny tweak makes this difference more obvious.
This change does highlight a smell in StatementModifier though.  All three of these methods operate solely on a node. Following good OO principles means these methods are not the concern of StatementModifier, but the responsibility of AST::Node.
Based on feedback, we could move them.
This:
module StatementModifier
  def content_line_count(node)
    node.source.lines.grep(/\S/).size
  end

  def empty_body?(body)
    !body || body_length(body).zero?
  end

  def body_length(body)
    body.source_range ? body.source_range.size : 0
  end
end

could be refactored to:
class Node < Parser::AST::Node
  def content_line_count
    source.lines.grep(/\S/).size
  end

  def empty?
    length.zero?
  end

  def length
    source_range ? source_range.size : 0
  end
end

[x] Wrote good commit messages.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

This change does highlight a smell in StatementModifier though. All three of these methods operate solely on a node. Following good OO principles means these methods are not the concern of StatementModifier, but the responsibility of AST::Node.

Yeah, this makes sense.
I'd probably name this method nonempty_lines_count or something like this, though. content is not a term that comes to mind when I think about source code.

Using #length and #empty? directly on Node is going to conflate two different ideas. The node data structure often contains nested nodes. The #length and #empty? here actually apply to the node's source code string. It will also conflict with the CollectionNode extension. 🙂
Perhaps #source_length and something else would be better?

That sounds great. Thank you for the note!
Perhaps #source_length & #empty_source??


comparing values when firing "watch"

Version
2.3.3
Reproduction link
https://jsfiddle.net/os7r6kay/11/
Steps to reproduce
hi
i'm new to vue framework. i've been using it for a week or so. this is using the latest vue, 2.3.
I came about this problem when starting from https://vuejs.org/v2/examples/select2.html, and trying to implement "multiple" support.
I then removed select2 from the equation to simplify the "bug".
See the normal/simple select in the following:
https://jsfiddle.net/f4a8fdju/3/
It works as expected and everything is fine
See the following multiple select example:
https://jsfiddle.net/os7r6kay/11/
I have placed a counter to prevent the browser from hitting a javascript lock. If you uncomment the "return" in the change function, it will work because it breaks the infinite recursion. Alternatively, another solution is to uncomment the JSON stringify compares.
I am sure there is a lot more at play here that I am not aware of, being a vue noob. I suspect the issue here is that the watch event is only firing if the value changes. And when the value is an array, if you do ['hello'] == ['hello'], the result will be false, so it's hitting endless recursion between the change event firing and the value watcher.
If this is indeed the case, I don't know enough about vue to know if that, perhaps, the watch should perhaps make use of JSON.stringify() or something to compare the values when using the watch? Perhaps doing this would break other things?
I understand that the endless recursion is the fault of the script, in that it's firing change and then the watch is picking it up. My thought is that perhaps watch should be able to handle arrays (and maybe objects?) and not fire when they match.
Have mercy on me,
A vue noob
What is expected?
endless recursion would not happen
What is actually happening?
endless recursion

i love vue

For what it's worth I wrote a workaround for this in a StackOverflowquestion today. I'm not sure changing the way properties work for arrays/objects is a viable solution for all cases.

Ya, I agree, not sure it's "worth" it either. I just thought it interested that the watch does not fire if the watched variable is "set", but to the same value. Was just curious if someone with more vue experience thought that perhaps the watch should use a more loose comparison for arrays/objects.

Is this a VueJS bug?

The watcher checks whether it should fire using a strict equal === - changing this behavior would be breaking and unlikely to happen.
IMO it's the component's responsibility to avoid this infinite loop - also I think the more appropriate place to check shallow equality is inside your watcher callback.


fix(mapper): export attribute type

Coverage increased (+0.01%) to 76.86% when pulling dc60bbbfc94bfa206cf3814c1b214ded37667676 on export-attribute-types into a001980a3c4dbe5024a6e0cb6692eee1ec388353 on master.

:tada: This PR is included in version 3.0.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


TEIIDTOOLS-737 simplifying and refactoring endpoints

This focuses only on endpoints - there are no changes to rest entity field names.
There are now three top level end points: virtualizations (was workspace/dataservices), metadata, and editors (was service/userProfile/viewEditorState)
Changes:

Combined the publishing service into the data virtualization service, so instead of being under the metadata end point they are now under virtualizations
Removed the name from the path of create data virtualization - instead of POST virtualizations/name, use just POST virtualizations
Removed the view validation end point as it's been combined with save
view listings are now at GET virtualizations/{name}/views - and is consistent with the single view / validation GET virtualizations/{name}/views/{name} in that they both now return a ViewListing.
Removed service/about
komodoSourceName is now teiidSourceName

Also do we want to leave the app version at v1?

Also do we want to leave the app version at v1?

I don't have a strong preference, we could probably leave it at v1 until we are production.
Minor issue, I noticed that {{teiidSourceName}} have double braces on the swagger page.  I should have the UI side changes ready to PR Monday...

Corrected the placeholder.


Extend Segment Membership to Include Snapshot Information

What are the schemas that are affected by the issue
Segment Membership
What are examples of products that are impacted by the issue
Segment Membership object should include the list of (possibly named) snapshots the profile is a member of. In addition to segments (latest snapshot) the profile is a member of.
Contact<EMAIL_ADDRESS>

@prabhum2 can you help me implement a PR for this?

Can you give me example of how you change the definition of the current field

Not sure which field I should be modifying, but the use case I would like to enable is as follows:
A segment named "People in CA" is evaluated on a regular basis. Meaning the audience in that segment updates regularly. I would like to create a snapshot of that segment on May 1, 2019 and name it "People in CA. Spring 2019 Campaign". This snapshot should be saved alongside the original segment along with its name. I will then be creating more snapshots for each season. The basic requirement would be something similar to:
{
  segments: [
    name,
    id,
    snapshots: [
      id: String,
      name: String,
      created: DateTime,
    ]
  ]
}


filter-plugin: Inner Txn support.

Summary

Generator switched to use SignedTxnWithAD instead of SignedTxnInBlock.
Split out a matches function from SearchAndFilter to avoid duplicate code for operation types (any/all/none).
Rename Search to Match for lowest level expressions.
Rename FilterType to Type.
Remove Filter from the Filter constants, it is in their type.
There is one remaining search function in the Searcher type. It now has an option to recursively search inner transactions for a match.

Test Plan
New unit test.
Updated benchmarks.

Benchmark results
BenchmarkProcess/inner_txn_count_0
BenchmarkProcess/inner_txn_count_0-8         	 1274750	       920.6 ns/op
BenchmarkProcess/inner_txn_count_10
BenchmarkProcess/inner_txn_count_10-8        	  219909	      5759 ns/op
BenchmarkProcess/inner_txn_count_100
BenchmarkProcess/inner_txn_count_100-8       	   25620	     48310 ns/op


LogPlugin silently overwrites the panic hook in WASM

The LogPlugin silently overwrites the panic handler on WASM. This means if you attempt to set your own panic handler, or use something like https://github.com/vectorgameexperts/web_panic_report, you have to overwrite it on Startup (thus, your panic handler can't be added until Startup)
Problematic code:
https://github.com/bevyengine/bevy/blob/5d0ff60a6bbfa54b68287c2cadb14a7c0328afb6/crates/bevy_log/src/lib.rs#L206-L212
This should not be considered acceptable default behavior.
3 options here, open to discussion.

(1) Provide a hook to the LogPlugin
(2) Take it out (my preferred answer - Logging really has nothing to do with panicking.)
(3) Consume the previous hook and wrap it, e.g.
https://github.com/bevyengine/bevy/blob/5d0ff60a6bbfa54b68287c2cadb14a7c0328afb6/crates/bevy_log/src/lib.rs#L136-L140

Why was this added in the first place? Can you check through the git history and link the PR?

Why was this added in the first place? Can you check through the git history and link the PR?

I believe it was added as a default to give WASM users the stack trace in their console, instead of the cryptic Unreachable error.
It's been untouched since the original LogPlugin PR, 4 years ago, by @cart

I think the reason it has gone unnoticed for so long is probably that it's uncommon and fairly technical to implement your own WASM panic handler. @Vrixyz and I just made the web_panic_report crate yesterday and we found no similar crates.
I would love to hear @cart 's original intention with this - and whether we can remove it. Should this logic be a separate PanicHandlerPlugin in the DefaultPlugins instead?

Thanks for the detective work! Splitting this out so it can be disabled or overwritten seems like a sensible direction to me. No strong feelings on the exact architecture though.

I think the reason it has gone unnoticed for so long is probably that it's uncommon and fairly technical to implement your own WASM panic handler. Vrixyz and I just made the web_panic_report crate yesterday and we found no similar crates.

This is probably the case. According to console_error_panic_handler's README, the alternative is an opaque error message that is borderline unusable to figure out what caused a panic.

Thanks for the detective work! Splitting this out so it can be disabled or overwritten seems like a sensible direction to me. No strong feelings on the exact architecture though.

Went ahead with the separate plugin strategy outlined above. PR #12557


New Term - materialDatedRelationship

New term

Submitter: Laura Brenskelle
Justification (why is this term necessary?): See https://github.com/tdwg/chrono/issues/20.
Proponents (at least two independent parties who need this term): Public review.

Proposed attributes of the new term:

Organized in Class: ChronometricAge
Term name (in lowerCamelCase): materialDatedRelationship
Definition of the term: The relationship of the materialDated to the subject of the ChronometricAge record, from which the ChronometricAge of the subject is inferred.
Usage comments (recommendations regarding content, etc.): Recommended best practice is to use a controlled vocabulary.
Examples: sameAs (cases where the subject material was completely destructively subsampled to get the ChronometricAge), subsampleOf (cases where part of the original specimen was extracted as the material used to determine the ChronometricAge), inContextWith (cases where the ChronometricAge is inferred from materialDated, such as sediments or cultural objects, in related temporal context), stratigraphicallyCorrelatedWith (cases where the ChronometricAge is inferred from materialDated in a stratigraphically correlated context).
Refines (identifier of the broader term this term refines, if applicable):
Replaces (identifier of the existing term that would be deprecated and replaced by this term, if applicable):
ABCD 2.06 (XPATH of the equivalent term in ABCD or EFG, if applicable):

Consider adding an additional example value:  "stratigraphicallyCorrelatedWith" (cases where the Chronometric Age is inferred from materialDated in a stratigraphically correlated context).  Or something along that line that allows the distinction between a dated sample from the immediate context of an excavation/borehole/outcrop/etc. and a dated sample from the same horizon in a different excavation/borehole/outcrop/etc, that is placed in the same horizon by stratigraphic correlation.

Consider adding an additional example value:  "stratigraphicallyCorrelatedWith" (cases where the Chronometric Age is inferred from materialDated in a stratigraphically correlated context).  Or something along that line that allows the distinction between a dated sample from the immediate context of an excavation/borehole/outcrop/etc. and a dated sample from the same horizon in a different excavation/borehole/outcrop/etc, that is placed in the same horizon by stratigraphic correlation.

Added the recommended additional example in the term change proposal above.

Added the recommended additional example in the term change proposal above.

New term included in all documents as of commit 33a132982e5f6d83dd368b822b3766d23ff00a2b.

Passed public comment.

Ratified! Closing.


SparseKerasTensor loses shape after casting

Please go to TF Forum for help and support:
https://discuss.tensorflow.org/tag/keras
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Multiple, checked on Linux Ubuntu 18.04.6 LTS and MacOS 12.2.1 (21D62)
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): Multiple, checked on 2.5, 2.6 and v2.8.0-rc1-32-g3f878cff5b6 2.8.0
Python version: Multiple, checked on 3.6.9 and 3.8.2
Bazel version (if compiling from source): NA
GPU model and memory: NA
Exact command to reproduce: tf.cast(tf.keras.Input(3, 3, sparse=True, dtype=tf.bool), tf.int32).shape

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the problem.
Describe the problem clearly here. Be sure to convey here why it's a bug in Keras or why the requested feature is needed.
Describe the current behavior.
The problem is the shape of the symbolic sparse tensor is lost and set to None after casting.
>>> a.shape
TensorShape([3, 3])
>>> b.shape
TensorShape([None, None])

Describe the expected behavior.
The shape should be preserved after casting.
Contributing.

Do you want to contribute a PR? (yes/no): no
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue.
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
a = tf.keras.Input(3, 3, dtype=tf.bool, sparse=True)
b = tf.cast(a, dtype=tf.int32)
assert a.shape == b.shape, \
    f"a.shape ({a.shape} is different from b.shape ({b.shape}))"

Colab link
Source code / logs.
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
NA

Possible solution:
Replace x.dense_shape with x.get_shape() in tensorflow.python.ops.maths_ops::cast:
x = sparse_tensor.SparseTensor(x.indices, values_cast, x.dense_shape)

would be replaced with:
x = sparse_tensor.SparseTensor(x.indices, values_cast, x.get_shape())

@chunduriv ,
I was able to reproduce the issue in tf v2.7, v2.8 and nightly.Please find the gist of it here.


Error: Plugin did not respond

When I'm trying to launch multiple similar it always seems to throw an error about the plugin not responding
│ Error: Plugin did not respond
│
│   with multipass_instance.swarm-manager,
│   on main.tf line 14, in resource "multipass_instance" "swarm-manager":
│   14: resource "multipass_instance" "swarm-manager" {
│
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ApplyResourceChange
│ call. The plugin logs may contain more details.

I'm using in on Windows 11 with multipass 1.9.1+win and terraform v1.2.
logs.txt
4

main.tf.txt

@Crush-Steelpunch Thanks for posting the first bug report!
I've tried to reproduce the error you got, and from what I can gather, one possibility is that the cloud-init file does not exist.
This should produce a nice error message in the provider, but I haven't gotten around to doing that yet.
When running the same parameters on the command line, I got:
error: No such file: (and then the file name in the parameter)
Could you please verify that the cloud init file name and path is correct?

Also, please not that the name is "swarm-worker" in both your examples, which will not work, as the instance name must be unique with multipass. This should also produce a nice error message in a future version. :-)

Thank you. It looks like one of the issues was related to this https://github.com/canonical/multipass/issues/885 and upgrading to 1.10 has stopped that. The error output is much improved and the "plugin did not respond" issues have also gone away. I'm still getting issues on create but I don't think they are related to this issue or the multipass plugin.

Nice! Thanks for getting back to me on this.


[Bug] Redirect url api is not used

Issue Description
As currently the redirect API is not used instead router. push is used so we need to change this behaviour and use redirection API for URL tracking.
Expected Behavior
Use redirect API for redirection
Current Behavior
redirection API is not used
Screenshots

Reproducibility

[ ] This issue is reproducible
[ ] This issue is not reproducible

Severity/Priority

[ ] Critical
[ ] High
[ ] Medium
[ ] Low

Additional Information

Checklist

[ ] I have read and followed the project's code of conduct.
[ ] I have searched for similar issues before creating this one.
[ ] I have provided all the necessary information to understand and reproduce the issue.
[ ] I am willing to contribute to the resolution of this issue.

This is fixed


log: fix log level parsing to allow all zap levels

Description of the change:
Delegate string parsing to zap, allowing any zap-supported level (for both --zap-level and --zap-stacktrace-level)
Motivation for the change:
The --zap-stacktrace-level option (#2319) is currently not working for any level > error as the parsing will not allow it.
I also think it's cleaner to delegate this level parsing to zap itself, it allows anything supported upstream.

It shows great. It is just missing to add a fragment. See: https://github.com/operator-framework/operator-sdk/blob/master/changelog/fragments/00-template.yaml
It is used for we create the CHANGELOG for the releases.

I looked around for a new place but did not check the fragments folder. Thank you!

At one point, we made a decision to explicitly only support the set of zap log levels that overlap with supported logr.Logger levels.
I think there are cases where using levels that logr.Logger does not support can result in panics, but I'm not sure if that situation has changed since we looked at this.

/hold

Here's the original thread with the decision-making: https://github.com/operator-framework/operator-sdk/pull/873#discussion_r249344051

Here's the original thread with the decision-making: #873 (comment)

I more or less got the issue, seems to be a touchy issue, thanks for pointing out. I can use the new code only for zap-stacktrace-level, that should be safe.

@vboulineau can you describe what you're trying to accomplish? I may be misunderstanding something, but since logr specifically forbids logging with negative numbers, there's no supported way to log at any level beyond error in the direction of panic with logr.Logger.
What would be gained by allowing --zap-stacktrace-level to handle those decreasing verbosity levels, other than entirely disabling stacktraces?
I do wonder if it is even possible to disable stacktraces with the current flag value constraints. If that's ultimately what you're going for, perhaps we should add a new supported disabled value for the --zap-stacktrace-level flag.

Also FWIW, we've been working to upstream the logging flags into controller-runtime, and deprecate the SDK's zap flag support as part of our work to transition to Kubebuilder's project layouts.
In fact, it appears that controller-runtime may already have support for these levels.

The original idea from #2319 was to allow disabling stack traces entirely, but as you suggested, it was better to keep stack traces for panic/fatal levels.
However, now it seems unlikely that users generate these logs (though it's still possible using .V(-3) as it goes to zapr which will convert it to 3 == panic).
I've tested upstream implementation in our operator and it works fine (already available in 0.17), so if you believe that's they way forward I can close that PR.

@vboulineau If you've got things working upstream, I think that's the best way forward. I was actually looking a little closer at that implementation though, and I think there's a bug in controller-runtime.
The -zap-log-level help text says "Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity" but the implementation aligns the flag values directly with the zap levels and numbering scheme.
There's a similar discrepancy with the -zap-stacktrace-level flag.
In SDK, we designed the level flags to align with the logr levels, not the zap levels, because it is  more intuitive to use --zap-log-level=3 to line up with log.V(3), at least in our opinion.
It also looks like it isn't currently possible to enable log levels with verbosity at log.V(2) and higher.
If these bugs in controller-runtime were fixed such that the implementation aligned with the help text, would that break your use-case and operator again?

Indeed you're right, upstream is buggy, running this code:
	for i := -3; i <= 10; i++ {
		log.V(i).Info("### TEST LOGLEVEL V", "lvl", i)
	}

With --zap-log-level=debug:
2020-05-19T10:52:02.840+0200	DPANIC	cmd	### TEST LOGLEVEL V	{"lvl": -3}
2020-05-19T10:52:02.840+0200	ERROR	cmd	### TEST LOGLEVEL V	{"lvl": -2}
2020-05-19T10:52:02.840+0200	WARN	cmd	### TEST LOGLEVEL V	{"lvl": -1}
2020-05-19T10:52:02.840+0200	INFO	cmd	### TEST LOGLEVEL V	{"lvl": 0}
2020-05-19T10:52:02.840+0200	DEBUG	cmd	### TEST LOGLEVEL V	{"lvl": 1}

With --zap-log-level=3:
2020-05-19T10:52:21.213+0200	DPANIC	cmd	### TEST LOGLEVEL V	{"lvl": -3}
2020-05-19T10:52:21.213+0200	ERROR	cmd	### TEST LOGLEVEL V	{"lvl": -2}
2020-05-19T10:52:21.213+0200	WARN	cmd	### TEST LOGLEVEL V	{"lvl": -1}
2020-05-19T10:52:21.213+0200	INFO	cmd	### TEST LOGLEVEL V	{"lvl": 0}

Which is indeed problematic for logging with several debug levels.
I believe, fixing this would bring us back to the same state this PR aimed to solve, except if log-level and stacktrace-level have different allowed values.
Really the only feature we'd like to keep is remove stacktraces on "error" loglevel, we'd be happy with any solution that provides that.
I think two options are possible here:

I change this PR to only add a "panic" level to stacktrace, keep everything else as-is, should cover all use cases until controller-runtime is fixed and this package deprecated on your side.

Keep operator-sdk as-is until controller-runtime is fixed and this package deprecated on your side, meanwhile users need to wait for disable stacktrace or migrate to controller-runtime (loosing V(3+) for some time).

I believe first option is a bit better, but not a strong opinion, both makes sense. WDYT?

@vboulineau Option 1 sounds good to me.

@vboulineau Option 1 sounds good to me.

Implemented!

Fixed nits and rebased but CI is still failing on doc part, it does not seem related to this PR?

@vboulineau Can you rebase to the latest master? I think the issue you're running into has been fixed.

/hold cancel

@vboulineau Sorry about this but I think we're now running into another separate CI error that will hopefully be fixed by #3158
Might have to rebase one more time after that merges.

Hi @vboulineau,
The issue faced in the CI here was fixed in #3158. Could you please rebased it with the master for the pr pass in the CI and allow us to merge it?

Hi @vboulineau,
The issue faced in the CI here was fixed in #3158. Could you please rebased it with the master for the pr pass in the CI and allow us to merge it?

Thank you, CI is green now!


YUPPI is not listed as a NANOGrav backend

Title says it all. Need to add YUPPI as a NANOGrav backend, starting at the 15 yr dataset.

Solution in MR  #292

Also VEGAS and whatever the CHIME backend is called...

Should we close this, or can we get those backend names in?

whoops, this was addressed long ago. closing now (though we might need to revisit once VEGAS data starts coming in).


[BUG] Order lines hide/view options do not work

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
The hide/view options for hiding or displaying order lines do not work on the order confirmation
https://github.com/user-attachments/assets/1e4158e9-c235-4c73-9950-8c78754fe16b
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- OS:
- Node:
- pnpm:

Anything else?
No response

You can find the PR here

completed via #1317


Drag on body should not take effect when I'm trying to scroll the content up from standstill

See in the video that the modal is dragged down when I'm trying to scroll the content up from standstill.
Using official example. @Temzasse Please have a look. Appreciate that ❤
https://github.com/Temzasse/react-modal-sheet/assets/45784210/d73dcc66-8c3d-4374-9a20-93a67fe05258

Duplicate of https://github.com/Temzasse/react-modal-sheet/issues/122.
Unfortunately scrolling in conjunction with dragging is kindah an unsolved problem on the web 😿
If you have any suggestion for solving this problem that would be welcome 🙏🏻


[linq2db] AseDataReader returns decimal? type from GetFieldType(i)

Query
SELECT TOP 1
	Convert(Decimal(29,10), @value1) as [c1]
FROM
	[LinqDataTypes] [t1]

parameter type is Decimal with value 6579.64648m
Native provider returns decimal type, managed provider returns decimal? type.
It is funny that it was discovered only becase we had bug in our code that didn't allowed us to process Nullable types properly in some cases.
linq2db test: ConvertTests.ConvertFromOneToAnother.LinqService

Btw, fix in linq2db reduce number of test failed tests to 136 from 365 (I will retest fix for this issue without linq2db fix applied to be sure it was fixed)

I cannot find it right now, but I suspect this method should allways return unwrapped type

Yes, so it looks like the reference driver responds with the field's type, rather than the value's type. Kind of makes sense, considering the method is called GetFieldType, not GetValueType

Fixed!