The type of rawSourceMap is string，But the type defined by the code is object

https://github.com/storybookjs/addon-coverage/blob/aacb3fb382c368675a6015a446b9caa3b8cf5f09/src/loader/webpack5-istanbul-loader.ts#L28

Causes downstream code to report errors

My configuration is：
// .storybook/main.js

/* eslint-disable storybook/no-uninstalled-addons */
/** @type { import('@storybook/vue-webpack5').StorybookConfig } */
import cssConfig from '../build/css.config.json';

const config = {
  stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'],
  addons: [
    '@storybook/addon-links', // https://storybook.js.org/addons/@storybook/addon-links/
    '@storybook/addon-essentials',
    '@storybook/addon-interactions',
    '@storybook/addon-docs',
    {
      name: '@storybook/addon-styling-webpack',
      options: {
        rules: [{
          test: /\.((c|sa|sc)ss)$/i,
          use: [
            'style-loader',
            ...cssConfig,
          ],
        }],
      },
    },
    '@storybook/addon-coverage',
  ],
  framework: {
    name: '@storybook/vue-webpack5',
    options: { builder: { useSWC: true } },
  },
  docs: {
    autodocs: true,
  },
};
export default config;

// devDependencies

    "@storybook/addon-coverage": "^1.0.0",
    "@storybook/addon-essentials": "^7.6.2",
    "@storybook/addon-interactions": "^7.6.2",
    "@storybook/addon-links": "^7.6.2",
    "@storybook/addon-styling-webpack": "^0.0.5",
    "@storybook/blocks": "^7.6.2",
    "@storybook/test": "^7.6.2",
    "@storybook/test-runner": "^0.16.0",
    "@storybook/vue": "^7.6.2",
    "@storybook/vue-webpack5": "^7.6.2",
    "storybook": "^7.6.2",

https://github.com/storybookjs/storybook/pull/24805?ref=storybookblog.ghost.io
Problems caused after useSWC is turned on

I am also encountering this same issue using Storybook v8.0.5.  @yannbf or @jonniebigodes any insight here?

Hey @dbudwin please let us know whether v1.0.3v1.0.3 fixed your issues!

@yannbf I no longer get that error; however, I can't see my test coverage.  When it's done running this is all I see.  The .nyc_output directory gets deleted for some reason when it finishes running.

@yannbf thanks so much--works like a charm now!


Add Win10 support

runs ok in my computer

Wall paper will be centered
auto dependency pypiwin32 if windows detected


port improved model visible check

Ported from this commit to the GPU plugin. I also made a small readability refactor that get's the model and does the null check sooner.

Tacking a second commit onto this that reduces the allocations while writing to the buffers in SceneUploader.pushFace. Seems to help a lot with the stability at higher FPS.


Fix Intro to Kino link

There's a missing [ in the markdown.
I'd like the opportunity to say that this project is amazing and the learn section is awesome! 🙇

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Update to the Google Beta Provider v2.2.0

This pull request supersedes #106, which was difficult to rebase, and upgrades to the latest v2.2.0 of the beta provider now we are ready to make breaking changes.
From upstream, a list of breaking changes (some of which may need addressing in examples, pending the result of CI):

bigtable: google_bigtable_instance zone field is no longer inferred from the provider.
bigtable: google_bigtable_table now reads family from the table's column family in Cloud Bigtable instead of creating a new column family
bigtable: google_bigtable_instance.cluster.num_nodes will fail at plan time if DEVELOPMENT instances have num_nodes = "0" set explicitly. If it has been set, unset the field.
cloudbuild: google_cloudbuild_trigger.build.step.args is now a list instead of space separated strings.
cloudfunctions: google_cloudfunctions_function.retry_on_failure has been removed. Use event_trigger.failure_policy.retry instead.
cloudfunctions: google_cloudfunctions_function.trigger_bucket and google_cloudfunctions_function.trigger_topic have been removed. Use event trigger instead.
composer: google_composer_environment.node_config.zone is now Required.
compute: google_compute_instance, google_compute_instance_from_template metadata field is now authoritative and will remove values not explicitly set in config.
compute: google_compute_region_instance_group_manager field update_strategy is now deprecated in the beta provider only. It will only function in the google provider,
compute: google_compute_global_forwarding_rule field labels is now removed
compute: google_compute_project_metadata resource is now authoritative and will remove values not explicitly set in config.
compute: google_compute_url_map resource is now authoritative and will remove values not explicitly set in config.
compute: google_compute_snapshot.snapshot_encryption_key_raw, google_compute_snapshot.snapshot_encryption_key_sha256, google_compute_snapshot.source_disk_encryption_key_raw, google_compute_snapshot.source_disk_encryption_key_sha256 fields are now removed. Use google_compute_snapshot.snapshot_encryption_key.0.raw_key, google_compute_snapshot.snapshot_encryption_key.0.sha256, google_compute_snapshot.source_disk_encryption_key.0.raw_key, google_compute_snapshot.source_disk_encryption_key.0.sha256 instead.
compute: google_compute_instance_group_manager is no longer imported by the provider-level region. Set the appropriate provider-level zone instead.
compute: google_compute_region_instance_group_manager.update_strategy in the google-beta provider has been removed.
compute: google_compute_instance, google_compute_instance_template, google_compute_instance_from_template have had the network_interface.address field removed.
compute: google_compute_instance has had the network_interface.access_config.assigned_nat_ip field removed
compute: google_compute_disk is no longer imported by the provider-level region. Set the appropriate provider-level zone instead.
compute: google_compute_router_nat.subnetwork.source_ip_ranges_to_nat is now Required inside subnetwork blocks.
compute: google_compute_ssl_certificate's private_key field is no longer stored in state in cleartext; it is now SHA256 encoded.
container: google_container_cluster fields (private_cluster, master_ipv4_cidr_block) are removed. Use private_cluster_config and private_cluster_config.master_ipv4_cidr_block instead.
container: google_container_node_pool's name_prefix field has been restored and is no longer deprecated.
sql: google_sql_database_instance resource is now authoritative and will remove values not explicitly set in config.
endpoints: google_endpoints_service.protoc_output was removed. Use google_endpoints_service.protoc_output_base64 instead.
resourcemanager: google_project_iam_policy is now authoritative and will remove values not explicitly set in config. Several fields were removed that made it authoritative: authoritative, restore_policy, and disable_project. This resource is very dangerous! Ensure you are not using the removed fields (authoritative, restore_policy, disable_project).
resourcemanager: Datasource google_service_account_key.service_account_id has been removed. Use the name field instead.
resourcemanager: google_project.app_engine has been removed. Use the google_app_engine_application resource instead.
resourcemanager: google_organization_custom_role.deleted is now an output-only attribute.
resourcemanager: google_project_custom_role.deleted is now an output-only attribute.
serviceusage: google_project_service will now error instead of silently disabling dependent services if disable_dependent_services is unset.
storage: google_storage_object_acl.role_entity is now authoritative and will remove values not explicitly set in config. Use google_storage_object_access_control for fine-grained management.
storage: google_storage_default_object_acl.role_entity is now authoritative and will remove values not explicitly set in config.
iam: google_*_iam_binding Change all IAM bindings to be authoritative

Fixes #57.

I've run all of the examples in pulumi/examples with this upgraded version of the provider, and all seems well - I think we are good to release a v0.18.0 here.

Is this supposed to be working already ? I've updated the package using npm but when I try to create a private DNS ManagedZone on Google Cloud Platform, I get this:
error: gcp:dns/managedZone:ManagedZone resource 'typhon' has a problem: : invalid or unknown key: visibility
error: gcp:dns/managedZone:ManagedZone resource 'typhon' has a problem: : invalid or unknown key: private_visibility_config


Comprehensive carry-over of Neo4j Security Guide to advisor rules

Take Neo4j internal "Neo4j Security Configuration Guide" and carry over most of the implementable rules into advisor recommendations.

https://support.neo4j.com/hc/en-us/articles/360007286634-Neo4j-Security-Configuration-Guide


Treat spanIds as strings to avoid integer overflow

@ofrobots PTAL.

LGTM if e2e tests pass (i.e. we have verified that the trace API accepts these).


isVerbose has no effect

isVerbose does not display a more verbose output.
I hoped that we would see something like the test suite filenames which are processed, or the describe and it texts.
My config file is:
exports.config = {
		seleniumAddress: 'http://localhost:4444/wd/hub',
		baseUrl: 'http://localhost:8080',
		framework: 'jasmine2',
		jasmineNodeOpts: {
			// If true, print colors to the terminal.
			showColors: true,
			isVerbose: true
		},
		params: testing_params,
		specs: ['test/e2e/stories/*.story.js'],
		onPrepare: function() {
			global.browser2 =  browser.forkNewDriverInstance();
		}

Output with isVerbose: false:
protractor prot.js --specs test/e2e/stories/test.story.js
Using the selenium server at http://localhost:4444/wd/hub
[launcher] Running 1 instances of WebDriver
Started

.

1 spec, 0 failures
Finished in 4.616 seconds
[launcher] 0 instance(s) of WebDriver still running
[launcher] chrome #1 passed

Output with isVerbose: true:
protractor prot.js --specs test/e2e/stories/test.story.js
Using the selenium server at http://localhost:4444/wd/hub
[launcher] Running 1 instances of WebDriver
Started

.

1 spec, 0 failures
Finished in 4.207 seconds
[launcher] 0 instance(s) of WebDriver still running
[launcher] chrome #1 passed

System OS X, Protractor Version 1.6.1
Thx.

isVerbose is not a jasmine2 feature as we're using https://github.com/jasmine/jasmine-npm directly now

Closing as answered.

@hankduan, @juliemr can you give a clue how to activate a more verbose output with protractor and Jasmine 2 or give a best practice?
Our experience is that just "F"'s in a row of "." are not very useful in production environments with dozens of suites when you have to figure out in which test case the failure occurred.

What does your output look like? Jasmine should already point you to 1) which spec failed 2) error message and 3) stack trace
i.e.:
$ node lib/cli.js spec/hankConf.js --suite=hank
Using the selenium server at http://localhost:4444/wd/hub
[launcher] Running 1 instances of WebDriver
Started
F.

Failures:
1) test do authenticated tests authenticated test 1
  Message:
    Expected true to be false.
  Stack:
    Error: Failed expectation
        at Env.<anonymous> (/workspace/protractor/spec/hank_spec.js:7:20)
        at /workspace/protractor/node_modules/jasminewd2/index.js:95:14
        at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/workspace/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
        at [object Object].webdriver.promise.ControlFlow.runEventLoop_ (/workspace/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1518:8)
        at [object Object].wrapper [as _onTimeout] (timers.js:252:14)
        at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

2 specs, 1 failure
Finished in 0.09 seconds
[launcher] 0 instance(s) of WebDriver still running
[launcher] chrome #1 failed 1 test(s)
[launcher] overall: 1 failed spec(s)
[launcher] Process exited with error code 1

Unfortunately not in all cases. E.g. when an element can't be found because it is not visible, there is no spec file mentioned where this happened.
[...]
2) Projects List Site changes url to project single
  Message:
    Failed: element not visible
      (Session info: chrome=40.0.2214.111)
      (Driver info: chromedriver=2.13.307650 (feffe1dd547ee7b5c16d38784cd0cd679dfd7850),platform=Mac OS X 10.9.5 x86_64) (WARNING: The server did not provide any stacktrace information)
    Command duration or timeout: 15 milliseconds
    Build info: version: '2.44.0', revision: '76d78cf', time: '2014-10-23 20:02:37'
    System info: host: 'karin.office.cnc', ip: '<IP_ADDRESS>', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.9.5', java.version: '1.7.0_45'
    Session ID: d9b5991356abecf991317557cbd9162b
    Driver info: org.openqa.selenium.chrome.ChromeDriver
    Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=chrome, chrome={userDataDir=/var/folders/wx/qt_77kv53270dwfh0s15vbg40000gn/T/.org.chromium.Chromium.6YxstT}, rotatable=false, locationContextEnabled=true, mobileEmulationEnabled=false, version=40.0.2214.111, takesHeapSnapshot=true, cssSelectorsEnabled=true, databaseEnabled=false, handlesAlerts=true, browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
  Stack:
    Error: Failed: element not visible
      (Session info: chrome=40.0.2214.111)
      (Driver info: chromedriver=2.13.307650 (feffe1dd547ee7b5c16d38784cd0cd679dfd7850),platform=Mac OS X 10.9.5 x86_64) (WARNING: The server did not provide any stacktrace information)
    Command duration or timeout: 15 milliseconds
    Build info: version: '2.44.0', revision: '76d78cf', time: '2014-10-23 20:02:37'
    System info: host: 'karin.office.cnc', ip: '<IP_ADDRESS>', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.9.5', java.version: '1.7.0_45'
    Session ID: d9b5991356abecf991317557cbd9162b
    Driver info: org.openqa.selenium.chrome.ChromeDriver
    Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=chrome, chrome={userDataDir=/var/folders/wx/qt_77kv53270dwfh0s15vbg40000gn/T/.org.chromium.Chromium.6YxstT}, rotatable=false, locationContextEnabled=true, mobileEmulationEnabled=false, version=40.0.2214.111, takesHeapSnapshot=true, cssSelectorsEnabled=true, databaseEnabled=false, handlesAlerts=true, browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
        at /usr/local/lib/node_modules/protractor/node_modules/jasminewd2/index.js:104:16
        at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1582:15
        at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
        at notify (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:465:12)

3) Projects Single Site Enter 3 Questions and delete one
  Message:
[...]

Thanks for the clarification. I haven't tried to reproduce yet, but if that's the case it's a bug. Jasmine should report the stack trace under 'non-verbose' mode for these errors.

Fixed here: https://github.com/angular/protractor/pull/1795
background:
related: https://github.com/jasmine/jasmine/issues/734
The code for protractor is already in place, and we were waiting for jasmine to release the new version to support this. For now, you can just apply the change to your machine (i.e. npm install jasmine 2.2.1) and it should automagically work.

@ceelian I was looking for the same verbose configuration option after updating protractor to use jasmine2.  My protractor suite is large and takes 5+ minutes to run.  With the default simpler test reporting in jasmine2, I am not able to kill the suite after an early failure and see the failure details - I have to wait until protractor completes.  This is not ideal for my team's workflow.  I started using the following reporter for jasmine2 that gives the verbose test feedback I was looking for:

@quarklemotion Thanks for that suggestion. It's much nicer output than stock jasmine2. Also, seems to actually have colors!

We've upgraded Jasmine to 2.3 in the latest version of Protractor, so this should be fixed now.

I'm running protractor#2.1.0 and jasmine-core#2.3.4 and am isVerbose still has no effect.

I think the idea isn't to introduce isVerbose. Protractor is using jasmine as is, and there is no isVerbose option. When Julie mentioned this being fixed, she is referring to the fact that the stack did not show properly before. @cboden What are you trying to get out of isVerbose that jasmine/protractor isn't providing you?

I was looking for details on which tests were being run. I've implemented @quarklemotion's solution since; it's giving me what I was looking for.

Same as @cboden and @quarklemotion, I was able to take advantage of much more verbose output by configuring protractor with the following onPrepare() in config.js:
  onPrepare: function() {
    var SpecReporter = require('jasmine-spec-reporter');
    jasmine.getEnv().addReporter(new SpecReporter({displayStacktrace: true}));
  }

Thanks to https://github.com/bcaudan/jasmine-spec-reporter/blob/master/docs/protractor-configuration.md#protractor-configuration

Thanks @quarklemotion, your solution helped me as well

Thanks @quarklemotion , the solution you provided worked me me too. Apart from normal verbose feature it has other cool options like prefixing with symbol, ability to customize reporting output.
Appreciate for pointing to the module.

Works for me too. thanks, @quarklemotion.


Fix upload paths for imagebuilder targets

/hold
Putting OS images into OS-based folders.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/unhold


update package.json

在执行npm install提示：
$ npm install
npm WARN deprecated<EMAIL_ADDRESS>Switch to the `bfj` package for fixes and new features!
npm WARN deprecated<EMAIL_ADDRESS>CircularJSON is in maintenance only, flatted is its successor.

><EMAIL_ADDRESS>install /Users/baoguoxiao/code/web/vue-admin-template/node_modules/fsevents
> node install

node-pre-gyp WARN Using request for node-pre-gyp https download
[fsevents] Success: "/Users/baoguoxiao/code/web/vue-admin-template/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node" is installed via remote

><EMAIL_ADDRESS>install /Users/baoguoxiao/code/web/vue-admin-template/node_modules/node-sass
> node scripts/install.js

Cached binary found at /Users/baoguoxiao/.npm/node-sass/4.11.0/darwin-x64-64_binding.node

><EMAIL_ADDRESS>postinstall /Users/baoguoxiao/code/web/vue-admin-template/node_modules/node-sass
> node scripts/build.js

Binary found at /Users/baoguoxiao/code/web/vue-admin-template/node_modules/node-sass/vendor/darwin-x64-64/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>No repository field.

added 1454 packages from 802 contributors and audited 15766 packages in 108.802s
found 2 moderate severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

执行npm audit fix后发现svgo的版本更新了，所以提交pr更新版本

这个提示和 svgo 有什么关系么？


🌐 Add Spanish translation of Advanced User Guide - Events

Hi there :handshake: !
This pull request include the Spanish translation of advanced/events.md
This pull request continues with the Spanish translation of #1218
I would apreciate it very much if someone can check and review the translation.

This was covered in another PR, so I'll close this one now, thanks for the effort! :cake: :coffee:


Rename Host to HostClusterContext for join.

Fixed https://github.com/kubernetes-sigs/federation-v2/issues/165
/cc @font @marun

Ugh, seeing transient travis build failures due to running both e2e and integration.
@gyliu513 I'll allow this.  However, the code is alpha quality, intended to lay down enough functionality for users to provide substantive feedback.  I would like to avoid filing issues for every single corner we've cut in the process.  I would rather see trivial refactors and renames such as this one incorporated into more substantive work to minimize the overhead involved.

/lgtm

/approved

/approve

I would rather see trivial refactors and renames such as this one incorporated into more substantive work to minimize the overhead involved.

@marun so you mean that we want to combine such fix when doing some other function level change?

@gyliu513 Correct.  Much of the code quality has not been exhaustively reviewed and lacks comprehensive test coverage, in keeping with work whose primary purpose is to validate assumptions about user requirements.  As such, I think minor refactoring and stabilization efforts are of a lower priority to work driven by user requirements.


1.7.6 reports incorrect version

Describe the bug
ttyd -v reports version 0.0.0-unknown making it impossible to use with https://github.com/charmbracelet/vhs, as VHS checks the ttyd version number before it runs.
To Reproduce
$ brew install ttyd
$ ttyd -v
ttyd version 0.0.0-unknown

Environment:

OS: macOS 14.2.1

It should work if you install it with brew install ttyd --HEAD.
The version info is fetched from git tag in 1.7.6 release, homebrew uses source archive which is not a git repo, so no version info will be detected..

Thanks for quick reply. Confirming, installing with --HEAD solves the problem.

Sorry for the confusion, I've released 1.7.7 to revert the static version in source archive.
The release action now checks the version bump, it will fail if I forget to bump version in CMakeLists.txt.

Fantastic! Thank you!


Hi, after entering the personal access token it doesn’t happen anything.. can you please help me with that

That's the last step where I am struck
How do I resolve it

Any inputs here? Please


Fix patch() so that the root is patched instead of recreated

Previously, patch(element, vnode) would create a new element every time
for the top-level element, unless the top-level vnode had no id and
className. This is because emptyNodeAt() would create a vnode with sel
equal to the element's tagName, NOT including id and className.
This seems to be just a small fix, however this fix was crucial to get
Web Components (custom elements) working with Cycle.js, because the
custom element's "create" callback was being called infinitely and
recursively, because snabbdom was creating the top-level element every
time, even if the sel of oldVNode and vnode were supposed to be the
same.

LGTM :+1:

This would potentially fix #158

Thank you for the PR. To me this seems clearly better. I'd say the old behavior was pretty much a bug.

I've just released 0.5.3 with this patch. Thanks again. I'm sorry for the trouble caused but it never occurred to me how

Thanks for merging 👍 the synergy between our communities is good


refactor: rename node_package to link_node_package

and node_modules() macro to link_node_packages() as this is more accurate and is future proof for linking Plug'n'Play which doesn't have a node_modules folder

This was meant to be a draft still as its based off of https://github.com/aspect-build/rules_js/pull/48. Going to land that first and then rebase.

looks like a stack on #48 - I'll review after the rebase


Subgraphs can fail due to rate limiting on eth_getLogs

As seen in this log:

This is a duplicate.


Improved Dutch translations

@NekoJonez can you take a look?

I will tomorrow. My internet is being annoying right now. Tomorrow at work break I will.
Now did a very quick look and this looks decent.

@Klocman Looking perfect! I'll go through them too.


[FEATURE REQUEST] Remove custom fields if rr write logs from workers

Is your feature request related to a problem? Please describe.
We need to log from php side and now with RR2 logs sended to php://stderr looks like
php-rr_1  | 2021-03-20T18:18:51.961Z    DEBUG   server  server/plugin.go:240    {"message":"custom message"}

Settings for logs in rr config file
logs:
  mode: development
  encoding: console
  output: stdout
  err_output: stdout

Describe the solution you'd like
Clean log from php side
{"message":"custom message"}

if encoding: console and for mode development, production

Discussed with @wolfy-j :

Add new mode - clean
Update rendering

Hello @48d90782 , I have the same need, I was thinking about making the PR for this. Are you ok with that ?
In the plugin logger/config.go BuildLogger() I thought about adding something like this:
	case "clean": 		zCfg = zap.Config{ // add clean config here 		}
What do you think ?

Hey @bricelalu, yeah sure. PRs are always very very welcome 👍🏻
Yes, you can start from zap.Config. Also, keep in mind, that all logs from the worker are coming from here: https://github.com/spiral/roadrunner/blob/master/pkg/worker/worker.go#L220
And grabbed here: https://github.com/spiral/roadrunner/blob/master/plugins/server/plugin.go#L240
You can start with creating a new channel - clean -> https://github.com/spiral/roadrunner/blob/master/plugins/logger/plugin.go#L60

The goal of this issue is to have withing the clean channel a raw output to the stderr (or stdout, but specified in the config).

Hey @48d90782 ,
If I understand correctly we have a 1:1 relationship between plugins and loggers. One plugin can have his logger configured separately, the channel's name corresponding to the name of the plugin.
But if I create a clean channel, I should also create a clean plugin no ? Maybe I missed something.

Ok, let me explain :)
We have a BuildLogger method with the switch over the config mode. https://github.com/spiral/roadrunner/blob/master/plugins/logger/plugin.go#L60
In this switch, you have production, debug and etc... modes for the log. I expect to have another one logger mode - clean which will return a configuration that will not touch the user message.
Named logger will be constructed here: https://github.com/spiral/roadrunner/blob/master/plugins/logger/plugin.go#L60. cfg here is the current configuration for the channel for the particular plugin.
For example, imagine we have the following config:
# Logging settings (docs: https://roadrunner.dev/docs/beep-beep-logging)
logs:
  mode: development
  level: debug
  encoding: console
  output: stderr
  err_output: stderr
  channels:
    http:
      mode: development
      level: panic
      encoding: console
      output: stdout
      err_output: stderr
    server:
      mode: production
      level: info
      encoding: json
      output: stdout
      err_output: stdout
    rpc:
      mode: production
      level: debug
      encoding: console
      output: stderr
      err_output: stdout

For the http, server and rpc plugins we would have a channels here: https://github.com/spiral/roadrunner/blob/master/plugins/logger/plugin.go#L61
For other plugins, we won't have channels but will have a general config
logs:
  mode: development
  level: debug
  encoding: console
  output: stderr
  err_output: stderr

and since other plugins have no channels, logger for these plugins will be constructed here: https://github.com/spiral/roadrunner/blob/master/plugins/logger/plugin.go#L69


Error in dropzone.js when upload file

While trying to upload a file with +9MB using admin interface, I encounter this error in both Chrome and Firefox
I'm using this versions:

Django==1.9.8
django-filer==1.2.4

This project is on Heroku environment.
Below the error message from browser's console.
--
Chrome 52.0.2743.82 (64-bit)
POST https://myproject-staging-pr-8.herokuapp.com/admin/filer/clipboard/operations/upload/no_folder/ 503 (Service Unavailable)      dropzone.min.js:77
    c.submitRequest @ dropzone.min.js:77
    c.uploadFiles @ dropzone.min.js:77
    c.processFiles @ dropzone.min.js:70
    c.processFile @ dropzone.min.js:70
    c.processQueue @ dropzone.min.js:70
    (anonymous function) @ dropzone.min.js:65
                                                                                dropzone.init.js:38

TypeError: Cannot read property 'API' of undefined(…)

--
Firefox 47.0.1
TypeError: window.parent.CMS is undefined
Stack trace:
showError@https://myproject-staging-pr-8.herokuapp.com/static/filer/js/addons/dropzone.init.js:34:13
createDropzone/<.error@https://myproject-staging-pr-8.herokuapp.com/static/filer/js/addons/dropzone.init.js:121:17
u</e.prototype.emit@https://myproject-staging-pr-8.herokuapp.com/static/filer/js/libs/dropzone.min.js:29:155
k</c.prototype._errorProcessing@https://myproject-staging-pr-8.herokuapp.com/static/filer/js/libs/dropzone.min.js:78:23
k</c.prototype.uploadFiles/f</<@https://myproject-staging-pr-8.herokuapp.com/static/filer/js/libs/dropzone.min.js:73:127
k</c.prototype.uploadFiles/p.onload</<@https://myproject-staging-pr-8.herokuapp.com/static/filer/js/libs/dropzone.min.js:75:22

The reason this is happening is because there is no CMS object inside of the admin.
The code currently logs the error that happened instead of logging (or alerting) the error response from the server, which in your case seems to be some 503 error


Backport load-balancer client changes to Greenwich

Backport https://github.com/spring-cloud/spring-cloud-commons/pull/584 and https://github.com/spring-cloud/spring-cloud-commons/pull/590 to Greenwich.

Done.


Short solution needed: "How to rotate text" (python-pillow)

Please help us write most modern and shortest code solution for this issue:
How to rotate text (technology: python-pillow)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to rotate text


Support for variable and constant exports for packages in the compiler

Given the following foo:
package foo

const Const = 42

// NewBar return an integer \o/
func NewBar() int {
        return 10
}

This test should work:
func TestImportConst(t *testing.T) {
       src := `
               package importconst

               import "github.com/nspcc-dev/neo-go/pkg/compiler/testdata/foo"

               func Main() int {
                       return foo.Const
               }
       `
       eval(t, src, big.NewInt(42))
}

But it doesn't and it also fails if we're to change foo to export a variable. It's a bit complicated to fix because traverseGlobals is assumed to be called once as it emits an INITSSLOT opcode and convertGlobals shouldn't ignore constants for subpackages. ast.SelectorExpr handling at line 808 of codegen.go also should be made aware of package-level constants and variables.
It's also somewhat related to #1150 as at the moment these variables/constants would end up in the same namespace.

Somewhat depends on #1228 , where Main func is no longer special.


Support more FA icons in cod-icon

Is your feature request related to a problem? Please describe.
I'm trying to create a drupal content type that allows editors to select the type of icon they want to display in a button. However, our current <cod-icon/> custom element only supports a limited set of icons, and the <cod-button/> component does not support children element (e.g. something like <cod-button ...> <svg ...></svg></cod-button>).
This prevents us from having content editors use the Font Awesome Drupal field to select an FA icon because it may not be supported by the design system (i.e. an editor may select fa-chevron-right but <cod-icon data-icon="fa-chevron-right" is not supported) and embedding the icon as a child of <cod-button> will be ignored.
Describe the solution you'd like
Add additional SVG paths to the design system to support FA icons currently used on detroitmi.gov. If people want to use the design system in Drupal and include an icon in a content type, they should use a custom field list with only the supported icon types in the list (instead of using the 'Font Awesome Icon' field type).
This approach could also make sites using the design system more performance by reducing reliance on external FA libraries. Expand for details:

This would eventually allow a Drupal install to remove the 'Font Awesome Icon' module entirely if they chose to. Without additional configuration, Font Awesome resources can block rendering up to ~1s depending on the connection. Example of FA render blocking with detroitmi.gov:

Describe alternatives you've considered
Alternatives:

Support children elements in cod-button. E.g. support <cod-button ...> <svg ...></svg></cod-button>.

Pros: makes it easier to customize the button for users.
Cons: Allows the design system to be misused (e.g. not styling an icon in the button correctly). The button should be left as a leaf component and not have children provided to it for this reason.

Include the FA library in the design system dependencies. Then allow users to pass any FA shortnames (e.g. fa-chevron-right).

Pros: Easy support for all FA icons. Compatible with other FA libraries / frameworks like Drupal 'Font Awesome Icon' module.
Cons: Increases size and dependencies of design system package. The FA library can be out of sync with external FA libraries/frameworks like Drupal 'Font Awesome Icon' causing some icon names in one framework to be undefined in another.

@jedgar1mx please have a look and let me know if you agree with the suggested approach here (instead of alternatives) before I code this up. This blocks CityOfDetroit/detroitmi/issues/1096.


Allow configuration of btrfs with want_rootfs=btrfs

There is a new requirement for Cloud7 to enable btrfs by default.
Let's add it as an option until subvolume handling has been implemented.

+0.5 we could also do it more generic, by using a want_rootfs=btrfs (e.g. some people were talking about XFS as the recommended alternative to btrfs)
with the default value being empty that leaves crowbar's default.

+1

@bmwiedemann thats an interesting thought.

merged with a small docker change.

caf1555ac225950bfb2e1693876600af6a756904


XML Template Update

Add possibility to update xml templates. Via some rector processor.
-<controller>Sulu\Bundle\ArticleBundle\Controller\WebsiteArticleController:indexAction</controller>
+<controller>Sulu\Bundle\ArticleBundle\Controller\WebsiteArticleController::indexAction</controller>

@alexander-schranz I think that can be accomplished with a custom FileProcessor for xml files.
Have a look at: https://github.com/sabbelasichon/typo3-rector/blob/main/src/FileProcessor/FlexForms/FlexFormsProcessor.php

@sabbelasichon thx for the response and your insights how you handle this in Typo3. Looks like this is just a file visitor then?
Do you know if there is there any AST based fileprocessor for yaml, xml already available?

If I understand rector 0.18 release correctly non PHP Files rectors are not longer supported know: https://getrector.com/blog/rector-018-refocus-on-php.

@alexander-schranz I am a bit late in responding. Sorry for that. We are currently developing a new tool to handle changes of non php files (https://github.com/andreaswolf/fractor). It is still under active development but we are expecting to have something ready end of June.


Make deletion protection consistent across all modules

This PR exposes the deletion_protection attributed in GKE clusters introduced in version 5 of the provider.

Checklist

I applicable, I acknowledge that I have:

[x] Read the contributing guide
[x] Ran terraform fmt on all modified files
[x] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

@lcaggio this mostly affects the data blueprints. Can you take a look and make sure I'm not breaking anything?


IDisposable and UsingFactoryMethod

Consider:
public class ServiceInstaller : IWindsorInstaller
    {
        public void Install(IWindsorContainer container, IConfigurationStore store)
        {
            container.Register(
                Component.For<ISomeConnectionService>()
                    .ImplementedBy<SomeConnectionService>()
                    .LifestyleTransient()
                    .IsDefault());

            container.Register(
                Component.For<FailoverDatabaseConnectionExecutor>()
                .ImplementedBy<FailoverDatabaseConnectionExecutor>()
                .LifestyleTransient());

            container.Register(Component.For<IDatabaseConnectionExecutor>()
                .UsingFactoryMethod(CreateDatabaseConnectionExecutor)
                .LifestyleTransient()
                .IsDefault());
        }

        private static IDatabaseConnectionExecutor CreateDatabaseConnectionExecutor(IKernel kernel)
        {
            return kernel.Resolve<FailoverDatabaseConnectionExecutor>();
        }
    }

    public interface IDatabaseConnectionExecutor
    {
    }

    public class SomeConnectionService : ISomeConnectionService, System.IDisposable
    {
        public SomeConnectionService()
        {

        }

        public void Dispose()
        {
        }
    }

    public interface ISomeConnectionService
    {
    }

    public class FailoverDatabaseConnectionExecutor : IDatabaseConnectionExecutor
    {
        private readonly ISomeConnectionService _someConnectionService;

        public FailoverDatabaseConnectionExecutor(ISomeConnectionService someConnectionService)
        {
            _someConnectionService = someConnectionService;
        }
    }

When attempting to inject ISomeConnectionService i receive the following error:

Instance FailoverDatabaseConnectionExecutor of component Late bound IDatabaseConnectionExecutor is already being tracked. The factory method providing instances of the component is reusing instances, but the lifestyle of the component is Transient which requires new instance each time. In most cases it is advised for the factory method not to be handling reuse of the instances, but to chose a lifestyle that does that appropriately. Alternatively, if you do not wish for Windsor to track the objects coming from the factory change your regustration to '.UsingFactoryMethod(yourFactory, managedExternally: true)'

If i remove IDisposable from SomeConnectionService then i don't receive the error any more. Is this by design? Is it not possible to have an object implementing IDisposable in the dependency chain in conjunction with .UsingFactoryMethod? As a side note there is also a spelling mistake "regustration" in the message.

I can't think of why this is occurring, I suspect because a dependency has a decommission concern (i.e. IDisposable) during the resolve it gets tracked, and then a second time for the factory. I assume setting managedExternally: true also resolves the problem, disabling the tracking the second time.
Can you debug Windsor to determine why it is attempting to track the component a second time (and throwing). We can go from there to determine a way forward.
P.S. fixed that spelling mistake in 61807e48ce3b6d06862eddcad2663b967f3e2287, thanks.

@aaron-hammond - Please see https://github.com/castleproject/Windsor/pull/334/commits/710e85cdb66c949e3400b16211cfbe0af2d86908
This test is passing for me

I am going to close this issue out as I think it might be a misconfigured container. Please feel free to continue the discussion here and if we do turn up anything we can always open the issue again.

Sorry just double checked and I was resolving the wrong thing.

I changed the test case this and it is still passing:
[Test]
public void Can_resolve_service_using_factory_that_implements_disposable()
{
	var a = Container.Resolve<ISomeConnectionService>();
	Assert.That(a, Is.Not.Null);

	var b = Container.Resolve<FailoverDatabaseConnectionExecutor>();
	Assert.That(b, Is.Not.Null);
}

@fir3pho3nixx Seeing as you've closed this, can you explain to me what the issue is then and how i can avoid it? I've been looking into this myself and still can't figure out what i want to achieve?

@aaron-hammond - If you post a full repro on Github using the latest version of Castle, I might be able to help you spot where you have gone wrong ...

@fir3pho3nixx Sure i can do that, i think the issue isn't in doing Container.Resolve<FailoverDatabaseConnectionExecutor>();  It's when you inject and attempt to resolve the the factory. var c = container.Resolve<IDatabaseConnectionExecutor>(); should give you the error.

The actual error I've tracked down to Castle.MicroKernel.Releasers.LifecycledComponentsReleasePolicy initially the FailoverDatabaseConnectionExecutor is tracked and added to instance2Burden.
public virtual void Track(object instance, Burden burden) 		{ 			if (burden.RequiresPolicyRelease == false) 			{ 				var lifestyle = ((object)burden.Model.CustomLifestyle) ?? burden.Model.LifestyleType; 				throw new ArgumentException( 					string.Format( 						"Release policy was asked to track object '{0}', but its burden has 'RequiresPolicyRelease' set to false. If object is to be tracked the flag must be true. This is likely a bug in the lifetime manager '{1}'.", 						instance, lifestyle)); 			} 			try 			{ 				using (@lock.ForWriting()) 				{ 					instance2Burden.Add(instance, burden); 				} 			} 			catch (ArgumentNullException) 			{ 				//eventually we should probably throw something more useful here too 				throw; 			} 			catch (ArgumentException) 			{ 				throw HelpfulExceptionsUtil.TrackInstanceCalledMultipleTimes(instance, burden); 			} 			burden.Released += OnInstanceReleased; 			perfCounter.IncrementTrackedInstancesCount(); 		}
When an attempt is then made to register the factory; the track method in Castle.MicroKernel.Lifestyle.AbstractLifestyleManager is hit and the value of RequiresPolicyRelease is set to true.
protected virtual void Track(Burden burden, IReleasePolicy releasePolicy) 		{ 			if (burden.RequiresPolicyRelease) 			{ 				releasePolicy.Track(burden.Instance, burden); 			} 		}
I think this is due to the fact that it has child components that are implementing IDisposable. When the track method in the LifecycledComponentsReleasePolicy is called again the key for FailoverDatabaseConnectionExecutor has already been used in the dictionary by the initial registration and it generates a duplicate key error.
@jonorossi asked me to figure out why it was being added and tracked a second time but i ran out of time last night and haven't had a chance to update.

After checking this out I have managed to replicate the issue. Apologies for closing prematurely.

@fir3pho3nixx no problem mate.
The issue, i think, boils down to the dictionary in Castle.MicroKernel.Releasers.LifecycledComponentsReleasePolicy :
private readonly Dictionary<object, Burden> instance2Burden =
			new Dictionary<object, Burden>(ReferenceEqualityComparer<object>.Instance);

having a key set to the resolved type FailoverDatabaseConnectionExecutor from the registration:
            container.Register(
                Component.For<FailoverDatabaseConnectionExecutor>()
                    .ImplementedBy<FailoverDatabaseConnectionExecutor>()
                    .LifestyleTransient());

and then also setting the key to FailoverDatabaseConnectionExecutor when it attempts to track the factory registered by:
           container.Register(
                Component.For<IDatabaseConnectionExecutor>()
                .UsingFactoryMethod(kernel => kernel.Resolve<IMyFactory>().Create())
                .LifestyleTransient()
                .IsDefault());

They both get to that tracked point by having child dependencies that rely on IDisposable. The reasons for that i'm unsure of as this is the first time i've looked under the hood so to speak..

@aaron-hammond - you are right.
From what I can see, the TransientLifestyleManager is asking the LifecycledComponentsReleasePolicy to track the FailoverDatabaseConnectionExecutor twice. I think this is happen because of the following resolution cycle:
Resolve calls LifecycledComponentsReleasePolicy.Track()
Resolve calls LifecycledComponentsReleasePolicy.Track()
Resolve calls LifecycledComponentsReleasePolicy.Track() <- This fails because at the very end because it cannot add the same instance for FailoverDatabaseConnectionExecutor twice to the burden tracking in LifecycledComponentsReleasePolicy.
This is a tricky one. I will keep looking.

@fir3pho3nixx - agreed, i'm seeing the same. Becomes a bit of a rabbit hole for me after that but if i get a bit more time i'll have a dig at this too.


patch over sdds dependency

Temporary work around hopefully until sdds import in Sirepo's opal template is dealt with.

OPAL sdds dependency was resolved in Sirepo.
Stephen was using the temporary patch but has been switched back to using develop.


i18n: Translations update from Weblate

Translations update from Weblate for Northstar/FlightCore.
Current translation status:

Given that these translations seem to have been done using an auto-translation tool like Google Translate, I'm rejecting them and will be resetting them on weblate.


[core] Filesystem catalog supports setting case-sensitive option.

Purpose

Filesystem catalog supports setting case-sensitive option.

Tests

API and Format

Documentation

Thanks @zhuangchong , left comment about public method in Catalog.

Thanks @zhuangchong , left comment about public method in Catalog.

Thanks @JingsongLi ,  done.


Feat: ORV2-1865 Feature Flag Support

Description

Added support for a read-only GET /feature-flags API call

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Vehicles
Dops
TPS-Migration

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are promoted to:

Merge Workflow

Still cleaning up tests, just wanted to run this past everyone as a first review

Closing the PR to free up resource. To be reopened when ready.


Capitalize 'either' first letter

- What I did
Capitalize 'either' first letter to 'Either'

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:Jin10Dong/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Capitalize 'either' first letter to 'Either'

@Jin10Dong can you squash your commits, and make sure the commit is signed-off properly?

@thaJeztah I have re-committed with signed-off property, please check again. Thanks a lot.

@Jin10Dong looks like there's still three commits in this PR; can you try rebasing, and squashing your commits? See https://docs.docker.com/opensource/workflow/work-issue/#/pull-and-rebase-frequently for some hints on how to do that

@thaJeztah I have committed again yesterday, please check it. Thanks.

@Jin10Dong there's still 4 commits in this PR, can you please check?

Looks like something went wrong when rebasing. To make things easier it's best to create a branch for your PR instead of making changes directly on master; I suggest reading the contributors guide, which explains this in more detail.
I'll close this PR, because it's not in a mergeable state, and it's only a minor fix


add Linting for the project - consistency

Updated also the read me to include the end point for fixer io and also adding robocop


REST api documentation

i'd like to make a web client for kapacitord in order to make managing alerts a little easier, but i can't find any docs for the REST api. even an autogenerated list of all handlers and their roles would be helpful.

@arussellsaw ATM the REST API is not documented since it is subject to change. Once its been stable for a release or so we will lock it down and document it. For now your best reference is here https://github.com/influxdata/kapacitor/blob/master/cmd/kapacitor/main.go
Sorry for not having anything better but docs are coming...

@nathanielc  is there any authentication built in ?
I see

auth-enabled = false
in the config. I tried to change false to true, but it seems nothing changed.

@earthnut Not yet, but soon :)

Closing. See https://github.com/influxdata/docs.influxdata.com/pull/426


Links target blank

All links in the footer must have target blank to keep music playing
(allways keep user on the app 😉)

Thanks for reporting this. Definitely should have been the case :)


migration-reset ordering

running php artisan moudle:migrate-reset starts from older to newer when the correct scenarion is from newer migrations to older ones.
also running php artisan module:migrate should respect the ordering set in module.json ,because some modules might have primary keys pointing to others.

Fixed in https://github.com/caffeinated/modules/commit/255a63b18c2a2d5522937014d5ea32954ef4002a and https://github.com/caffeinated/modules/commit/1d370ab368f87258840b587852b94b42a60a4838. The package will now only take enabled modules into consideration when running these commands as well (rather than ALL modules, regardless if they were set to enabled or disabled).


Consistent file naming convention

Is your feature request related to a problem? Please describe.
Not having a consistent naming convention cause problems different issues.

Different conventions used by different team members.
Difficult to quickly find a particular file
Sometimes difficulty relating context of piece of code with other

Some examples are:
camelCase
https://github.com/ChainSafe/lodestar/blob/unstable/packages/beacon-node/src/chain/blocks/importBlock.ts
https://github.com/ChainSafe/lodestar/blobunstable/packages/reqresp/src/encoders/requestDecode.ts
CapitalCase
https://github.com/ChainSafe/lodestar/blob/unstable/packages/reqresp/src/ReqResp.ts
https://github.com/ChainSafe/lodestar/blob/unstable/packages/beacon-node/src/chain/clock/LocalClock.ts
Describe the solution you'd like
I would like to recommend to have consistent naming convention which follow these rules.

We should strictly use snake_case for file names
If file exports one class, the file name should be the class name in snake_case
If file exports multiple classes then we should split it to different files.
If file exports multiple functions, then we should have a generic name in snake_case
All tests files should have name related to top level describe in snake_case.
All directories should follow snake_case names.

Describe alternatives you've considered
Other approach was to follow camelCase which is already followed on most of the files. The problems with that approach are following:

Windows OS does have case-insensitive file system. So having camelCase reduces our target community for contribution and can cause unseen problem on Windows OS.
Same applies to Mac OS which is more widely used development platform.
camelCase does not have better readability and also does not match the export names that we have in CapitalCase.

Additional context
IN many different softwares, there is a known set of observations and errors that caused due to not handling the proper case sensitive file names. Please check the list in following link.
https://cwe.mitre.org/data/definitions/178.html
https://cwe.mitre.org/data/definitions/19.html

All directories should follow snake_case names.

For directories, I think it is better to use hyphens (hyphen-case) as this matches the naming convention of github projects which are just folders when cloned.
Also I think general naming convention for npm packages is to use hyphens, should probably make sure folder names correspond to package names (without @lodestar/ prefix).
Making files and folders distinguishable based on their naming convention might also provide more clarity.

Understand the sentiment of wanting consistency, but imo this isn't a particularly urgent, important, or impactful decision.
Not sure about yall, but there's no workflow I do that interacts with file names in any way.
I'm doing a project-wide search, or navigating to symbol references or definitions.
If I need an import, the IDE writes the import statement for me, filepath and all.
If I need to test a specific "file", I'm just using mocha --grep to filter.
With that in mind, I'd prefer less invasive solutions, either leave as is, or keep camel case and apply it more consistently.

I have very limited knowledge on this topic so I consulted chatGPT to help me figure out if there were any real distinct advantages/disadvantages outside of personal preferences. I think the most important thing also is that we all adhere to one standard going forward so we can get consistency across everything we do. The only reason why I weakly favour camelCase is to maintain conventions based on the ecosystem we're developing for and the types of developers we work with/develop for around JS/TS. Plus, if I'm correct we're already doing camelCase for most things. And because outside of "consistency" for developer UX, I'd prefer that we spend less resources migrating to something else if it's only for the addressed concerns above which isn't a critical type problem to address IMO.

Windows OS does have case-insensitive file system. So having camelCase reduces our target community for contribution and can cause unseen problem on Windows OS.

I'm not particularly concerned about this problem only because the Windows dev community is small and most people utilizing Ethereum protocol software at this point are not using the software on Windows based systems. It's a small amount and I believe Windows also has a Linux subsystem now for those users - which I'm not sure if it helps alleviate those concerns at this point.

Same applies to Mac OS which is more widely used development platform.

I believe that macOS can be tweaked to be case-sensitive or not. Which is something the developer can customize for themselves if they're running into case sensitivity issues that bug them.

camelCase does not have better readability and also does not match the export names that we have in CapitalCase.

I think there is an argument to made that snake_case is easier to read because of the underscores, but I can't say that it would make our lives that much better than actually coming to an agreement on convention, whether it's camelCase or something else.
This is coming from someone that doesn't look at the codebase as often as you guys though, so really, as long as we can agree to one standard, I'm good with it.

Based on team discussion we decided to move with camelCase for now.

We made a decision on this, closing unless there are objections.


Hot data storage

This pull request has a feature of "Hot data cache" - another whisper storage to keep metrics with short retention time so serve regular monitoring requests. This Hot data location can be put on a in-memory file system so all requests will be served much faster.
Use case: we have a lot of dashboards with time window from -2 hours till now and reading from the regular HDD is slow and expensive. As an alternative we will use this feature. Web app can also read from both of the locations and choose hot data location if it can provide enough data.
Hot data cache has own aggregation and storage schemas setup. My assumption was that storage schema for the hot cache should be a maximum frequency but for few hours only.

This is a really cool feature and you've put a lot of work into it, but I do worry about such an intrusive change with no tests.
Also, can a similar thing not be done with ramfs and dm-cache? Having used dm-cache for production workloads with ssds acting as caches for SATA drives I know it works super well. You'll need a newer distro like CentOS7 or RHEL7 however.
I'm just worried that if this feature can be done with a newer distro with no code changes that is a much better overall solution. Take a look at:
blog.kylemanna.com/linux/2013/06/30/ssd-caching-using-dmcache-tutorial/

At the risk of sounding negative, I'm not crazy about this change. Clearly you put a lot of effort into this and I applaud you for that, but it seems as though your time (and company's money) would've been far better invested in upgrading to SSDs.
From a technical perspective, there's a lot of code (and configuration) duplication, leading to unnecessary complexity. Not to mention you're basically adding more psuedo-cache for a time-series format (Whisper) that's eventually going to be superseded by Ceres, Cyanite, InfluxDB, etc.
In an ideal world this "hot data storage" would be added as a pluggable storage backend instead, although I haven't looked closely enough at your patch to realize how feasible this would be.

Thanks for that fast feedback. I'll check dm-cache, probably this tool may help. Servers with all SSDs isn't an option yet.
I added tests into a graphite-web project to test this feature a little. I did my the best to test carbon also, but I smashed my head trying to understand how to test all of the processors, plugins, writers, etc. I will write these test if you can help a little with advises which way to go.
Do you have any guidelines about implementation of the Hot storage as a pluggable backend?
Thanks

http://graphite.readthedocs.org/en/latest/storage-backends.html

Thanks for the link. I read about pluggable backend, but my feature is a different thing: it doesn't replace a backend, but enhance it. I would say this hot-data feature should work on top of the pluggable backends: it should be possible to use non-whisper backend to store that hot data.
Probably there should be a section in the config for the backend setup with some kind of connection string, like: whisper:///opt/graphite/storage/whisper and something different for other kinds of the storage. So there will be 2 parameters: BACKEND_CONNECTION_STRING and HOT_DATA_BACKEND_CONNECTION_STRING or something like that.

It seems to me that the desired functionality would be better implemented within Carbon's native caching layer, i.e. the cache would support some sort of TTL feature wherein it continues to retain metrics in-memory even after they've been flushed to disk.

Internal cache was one of the options. But webapp reads files first and only after that cache. So this need to be changed. E.g. webapp should do all queries through the cache only and never touch files directly. Also this solution will cause more changes in the carbon-cache to implement TTL, reuse current retention policies definition logic, etc.
I decided to do it as simple as possible.


fixed 'Unable to resolve AccessibilityInfo' #3

moved react and react-native from dependencies to peerDependencies to avoid version collision with the package user's own copy of dependencies

?


NY state covid testing data pull

WIP, but welcoming feedback. Looking for feedback about what is needed to get this from development and into production. Copied / pasted config parsing from backend repo. Am doing some likely unnecessary stuff with creating a S3 bucket. For the moment, running node stats.js will dump the required data into S3.
Please see: https://s3.console.aws.amazon.com/s3/object/nystate-test-bucket/stats-by-date.json?region=eu-west-1&tab=overview
and: https://s3.console.aws.amazon.com/s3/object/nystate-test-bucket/stats-by-county.json?region=eu-west-1&tab=overview
and please provide feedback on structure of data.
Looking for feedback as it regards the following question: do we match the shape of the NYS data or do we try to closely match the shape of data from the Ireland app (see HSEIreland repo stats file)

@mikegwhit
For benefit of those that can not access the bucket - can you paste snippets in here to review?

@mikegwhit
For benefit of those that can not access the bucket - can you paste snippets in here to review?

Updated with links in the PR description.


Get license for grlc

get license for grlc
Current disclaimer
"Queries behind this API do not have a license. You may not be allowed to use them."

Bruce fixed this.


Add failover IP script for edge-router worker nodes

Problem
How to achieve true HA without the help of a cloud LoadBalancer?
Solution
There are not many solutions, the best we have in Hetzner is probably the Failover IP.
All we need for this to work would be the following:

tagging edge nodes role=edge-router
deploy a pod that would watch the health / readiness of these nodes
switch automatically the IP to another heatlhy node in case of unhealthy

How to achieve true HA without the help of a cloud LoadBalancer?

by using nginx ingress controller. When deployed as a DaemonSet it runs on all (specified) nodes. These you can put as multiple A-Records to a single Domain and you will get basic load balancing
If you want to use kubernetes LoadBalancer feature coupled with Hetzner Failover IP, you should implement the CloudProvider interface from Kubernetes. In other words: to build an integration. The cloud provider would then listen to kubernetes events, such as pending LB services, and add Floating IPs to any healthy node (you don't need extra pods for the health watch, as k8s has its health info already in the api server).
Anyways, this is far out of the scope by this tool. I think the hetzner cloud controller manager is a better place for that, as it already implements cloud provider for different tasks

Thanks for the answer.
AFAIK, A-records load balancing is not working in browser, see this answer
But I think you are right to say that the cloud controller manager should be the place to implement this feature.

the answer is from 12 and since then it looks like changed a bit (check the comments of your link)
"not working" is a discussable statement. It's more accurate to say that this way of load balancing gives nearly zero control, how the balancing is happening or decide based on real loads of the nodes.
In fact, every time you do a hostname resolve, independent from which tool you do, you will get all IPs in random order. So if 100 browsers ask a domain with 3 IPs, they will be spread quite even over these IPs.
Just to comment that :smile:

Ok, I wanted to know for sure:
host -a ghost.indie.host
Trying "ghost.indie.host"
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 43494
;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;ghost.indie.host.		IN	ANY

;; ANSWER SECTION:
ghost.indie.host.	1798	IN	A	<IP_ADDRESS>
ghost.indie.host.	1798	IN	A	<IP_ADDRESS>

Received 66 bytes from <IP_ADDRESS>#53 in 44 ms

Test it from your browser :)
https://ghost.indie.host

closing in favor of https://github.com/hetznercloud/hcloud-cloud-controller-manager/issues/6 then.

Yes, external DNS is also a good idea, but, not perfect.
Some DNS server will cache the answer for 48h..

Failover IP management implemented in https://github.com/cit-consulting/hetzner-failoverip-controller .


Create post-release.yml

In order to allow executing the post-release workflow from GitHub, a new post-release action is created here.
MOB-1791

!merge


dredd mutates constant expression used as template argument

Applying dredd to
template<typename T, int N>
class auto_vec {};

void foo() {
    const int alloc_count = 42;
    auto_vec<int, alloc_count> a;
}

results in compilation error
error: non-type template argument is not a constant expression
    auto_vec<int, alloc_count> a;
                  ^~~~~~~~~~~

due to the mutation
const int alloc_count = __dredd_replace_expr_int_constant(42, 0);

I guess we will need something similar to what we have for rewriting array size expressions. Could you have a go at this?


Update README.md

Fixed indentation and spacing inconsistencies. There are still many left, but I don't have time to correct them. The sloppiness of the README file also raises some question marks about the whole project for me too.

Thanks for refining the README file.


Resize Checkbox through width and height not working

I am trying to resize the checkbox but it is not working passing width and height properties.
There is a sample of code:
          <CheckBox   disabled={false}   value={useTerms}   tintColor={colors.gray300}   onCheckColor={colors.background.primary}   onTintColor={colors.background.highlight}   tintColors={{true: colors.background.highlight, false: colors.gray300}}   onValueChange={setUseTerms}   onFillColor={colors.background.highlight}   boxType='square'   style={{ width: 32, height: 32 }} />
When I pass the props seems the library resizes a parent view but the inner component which apparently representes the checkbox is overlapping the parent width/height.
Library Version: 0.5.8
RN Version: 0.64.0

After a deep diving in the library code I found the problem. It is not possible to use tintColor, tintColors and style properties (at least for iOS, I didn't test for Android). The style prop is ignored

@fernandosolivas from what I see in my tests (I haven't checked the source code):

iOS: the resizing happens only after a full build and install
Android: it looks like only the outer container for the checkbox is actually resized through style prop

ReactNative = 0.64.2
Checkbox = 0.5.8

height & width not working when boxType={'square'}

height & width not working when boxType={'square'}

Seems to work. I am using square boxType and width and height properties are working.. In my case they don't work only when I use the property tintColor and tintColors together.

This worked for me, custom checkbox and resize with style prop:
export default ({  value = true, disabled = false, onChange, style = {}, ...rest }) => (
<CheckBox
disabled={disabled}
value={value}
onValueChange={onChange}
style={{ width: 18, height: 18, padding: 2 }}
boxType={'circle'}
lineWidth={2}
tintColor={getColor('radioBorder')}
onCheckColor={getColor('radioBorder')}
onFillColor={getColor('green')}
onTintColor={getColor('radioBorder')}
animationDuration={1}
onAnimationType={'bounce'}
offAnimationType={'stroke'}
/>

);

have you checked this comment?

https://github.com/react-native-checkbox/react-native-checkbox/issues/83#issuecomment-781366643

I don't know why this was labeled as solved. I still get this issue

same problem

I don't know why this was labeled as solved. I still get this issue, even after disabling fast refresh
 (the black background is not a part of the checkbox. The grey part is)

same problem

Same issue how can we remove extra padding?

Same issue here...

Same as @fernandosolivas, I've found the easiest way for the style property to actually work is to not use tintColor for iOS. @nicholaslee119 This is still an issue.
version 0.5.16
Code for style that works:
<CheckBox   boxType="square"   onCheckColor={'black'}   onTintColor="transparent"   animationDuration={0.2}   style={styles.checkBox} />
Code for style that doesn't work:
<CheckBox   boxType="square"   onCheckColor={'black'}   tintColor={grey}   onTintColor="transparent"   animationDuration={0.2}   style={styles.checkBox} />

The default check box come with an extra padding
      <CheckBox
            style={{backgroundColor:'red',margin:0,padding:0, }}
            disabled={false}
            value={toggleCheckBox}
            onValueChange={onValueChange}
        />

I try many different style but still can't remove the padding

it seems this library doesn't work properly at all on Android


[EXP] ARROW-5052: [C++] Add IncompleteDictionaryType

This allows passing information about a dictionary type with known index type and value type, but unknown dictionary values.

Not entirely sure yet this will be useful, so perhaps we shouldn't merge for now.

I'm trying to understand how the IPC layer works wrt/ dictionaries. If we add an optional integer id to IncompleteDictionaryType to refer to the id of the forthcoming dictionary array, perhaps it can allow ipc::ReadSchema(const Message& message, ...) to parse dictionary types and return them as incomplete? (right now, it would probably error out as it uses an empty dictionary memo)

Codecov Report

Merging #4067 into master will increase coverage by 0.82%.
The diff coverage is 90.55%.

@@            Coverage Diff             @@
##           master    #4067      +/-   ##
==========================================
+ Coverage   87.82%   88.65%   +0.82%
==========================================
  Files         739      604     -135
  Lines       90879    81451    -9428
  Branches     1252        0    -1252
==========================================
- Hits        79817    72209    -7608
+ Misses      10941     9242    -1699
+ Partials      121        0     -121

Impacted Files
Coverage Δ

cpp/src/arrow/type_traits.h
92.95% <ø> (ø)
:arrow_up:

cpp/src/arrow/visitor.h
50% <ø> (ø)
:arrow_up:

cpp/src/arrow/ipc/json-internal.cc
93.28% <0%> (+0.21%)
:arrow_up:

cpp/src/arrow/python/numpy_to_arrow.cc
95.41% <0%> (+0.81%)
:arrow_up:

cpp/src/arrow/python/arrow_to_pandas.cc
91.37% <0%> (+0.18%)
:arrow_up:

cpp/src/gandiva/expression_registry.cc
81.9% <0%> (ø)
:arrow_up:

cpp/src/arrow/visitor.cc
0% <0%> (ø)
:arrow_up:

cpp/src/arrow/type-test.cc
99.26% <100%> (+0.14%)
:arrow_up:

cpp/src/arrow/ipc/read-write-test.cc
99.82% <100%> (ø)
:arrow_up:

cpp/src/arrow/array-dict-test.cc
100% <100%> (ø)
:arrow_up:

... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e21ae...5e33de1. Read the comment docs.

Some of this has been split and refactored into #4113, so this PR will have to be updated.

I have an alternative proposal about handling schemas before the dictionary is known, that also addresses the problem of changing dictionaries. I'll write an e-mail to the mailing list to discuss tomorrow (April 22)

Closing in favor of ARROW-3144 solution


Separate out TG Model Perf Tests into Separate Jobs

With Resnet perf tests added in this PR: https://github.com/tenstorrent/tt-metal/pull/13561, we've bumped the timeout for TG Model Perf tests to 90 minutes. We should separate the tests out into different suites, based on the model type. T3K model perf tests can be used as a reference.

@afuller-TT
tagging you for reference here.
Could be to-do for you


Cannot upgrade from 0.0.6 to 0.0.7 because ServiceAccount does not have RBAC policy rules

Hi Andrew,
Thank you very much for your help earlier in troubleshooting my problems with this.  However, we are now experiencing a problem during the automatic upgrade from 0.0.6 to 0.0.7.
oc get csv yields
NAME                                           DISPLAY                          VERSION                 REPLACES                                       PHASE
group-sync-operator.v0.0.6                     Group Sync Operator              0.0.6                                                                  Replacing
group-sync-operator.v0.0.7                     Group Sync Operator              0.0.7           group-sync-operator.v0.0.6            Pending
When issuing the command
**oc describe csv group-sync-operator.v0.0.7 **
we receive the following error:
Requirement Status:
Group:    apiextensions.k8s.io
Kind:     CustomResourceDefinition
Message:  CRD is present and Established condition is true
Name:     groupsyncs.redhatcop.redhat.io
Status:   Present
Uuid:     aba35d5c-3d49-4f2d-8bac-433b3e238ace
Version:  v1beta1
Dependents:
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  namespaced rule:{"verbs":["get","list","watch","create","update","patch","delete"],"apiGroups":[""],"resources":["configmaps"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  namespaced rule:{"verbs":["get","update","patch"],"apiGroups":[""],"resources":["configmaps/status"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  namespaced rule:{"verbs":["create","patch"],"apiGroups":[""],"resources":["events"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  cluster rule:{"verbs":["get","list","watch"],"apiGroups":[""],"resources":["secrets"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  cluster rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["redhatcop.redhat.io"],"resources":["groupsyncs"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  cluster rule:{"verbs":["get","patch","update"],"apiGroups":["redhatcop.redhat.io"],"resources":["groupsyncs/status"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  cluster rule:{"verbs":["create","delete","get","list","patch","update","watch"],"apiGroups":["user.openshift.io"],"resources":["groups"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  cluster rule:{"verbs":["create"],"apiGroups":["authentication.k8s.io"],"resources":["tokenreviews"]}
Status:   NotSatisfied
Version:  v1beta1
Group:    rbac.authorization.k8s.io
Kind:     PolicyRule
Message:  cluster rule:{"verbs":["create"],"apiGroups":["authorization.k8s.io"],"resources":["subjectaccessreviews"]}
Status:   NotSatisfied
Version:  v1beta1
Group:
Kind:       ServiceAccount
Message:    Policy rule not satisfied for service account
Name:       default
Status:     PresentNotSatisfied
Version:    v1
Events:
Can you suggest a possible resolution to this?
Thank you very much,
Michael

Hi @MichaelGoldsbie
This appears to be related to the migration to Operator SDK 1.0 where a dedicated SA is no longer being used to run the operator. New installations of the operator have worked without issue. If you delete the GroupConfig custom resource and uninstall the operator, you should be able to install the updated version and then reapply the GroupConfig. Since the operator does not set the ownerReferences field of the group, existing synchronized groups will not be affected as maintenance to the operator is performed.

closing due to age


Fast Exit scenario

Description

Add Fast Exit scenario.
Based on CrossActorFlow, I add a parameter called "clear_lane". If it's true, then the scenario will clear the Background Activity on the lane where the actor flow starts.
An AtomicBehavior called RemoveLane is added to background_manager.py. The clear_lane action will be executed in _update_parameters method in background_activity.py.
A route file, FastExit.xml, is uploaded to examples.
Fixes #
Where has this been tested?

Platform(s): Ubuntu 20.04
Python version(s): 3.7
**Unreal Engine version(s):4.26
CARLA version: leaderboard-2.0 branch

Possible Drawbacks

Didn't test with other scenarios, don't know whether it is compatible with others.

This change is

I'd recommend adding the FastExit.xml into a new folder, as this is just a temporary route created to test the scenario. We can place all the testing rotues there, and once the Leaderboard 2.0 is finished, remove the folder.
Additionally, don't overwrite the CrossActorFlow scenario. By doing so, this new fast exit scenario is forced to have the clear_lane argument, which in reality it is part of the scenario behavior, as without it, the scenario breaks.
Some comments about the implementations:

The way this lane removal works is by checking the road_lane_key, which is only available when the BA works in road mode (active when there are no junctions in front of the ego). Is this a known limitation?
Your example shows the actor flow starting right at the side of the ego. This is due to start_actor_flow parameter and can be easily changed, but it is very ugly to allow the ego to see spawning vehicles. They should be spawned some distance being it

New updates:

Put route file in /srunner/routes folder.
The ActorFlow starts far behind the EGO.
Create a new scenario in actor_flow.py called CleanCrossActorFlow. It's almost the same as CrossActorFlow.
It is. It works when BA is working and there're data in _road_dict object.

The way this lane removal works is by checking the road_lane_key, which is only available when the BA works in road mode (active when there are no junctions in front of the ego). Is this a known limitation?


Why no mobile popup for Google Map iFrame?

Hi there, we are using your popup along with Google Maps API. This works great on desktop and larger devices, however on mobile we are noticing inconsistent touch ability.
We also noticed that the popups on the main documentation site for Google Maps / Vimeo / YouTube are all disabled for mobile devices. Is there a specific reason for this?
Is there a work around to making the touches consistent and forcing them to affect the iFrame only while its activated?

you have
$('.popup-youtube, .popup-vimeo, .popup-gmaps').magnificPopup({
disableOn: 700,
type: 'iframe',
mainClass: 'mfp-fade',
removalDelay: 160,
preloader: false,
	fixedContentPos: false
});

disableOn
If window width is less than the number in this option lightbox will not be opened and the default behavior of the element will be triggered. Set to 0 to disable behavior. Option works only when you initialize Magnific Popup from DOM element.


[React] mountComponent absorbing all errors

When I have an error in my component (e.g. using styles= instead of style=). The exception handler in mountComponent is catching it and not displaying any error messages.  It would be preferable to at least print the error to the console.  Relevant lines below:
ReactCompositeComponent.js[225:238]
    try {
      if (inst.componentWillMount) {
        inst.componentWillMount();
        // When mounting, calls to `setState` by `componentWillMount` will set
        // `this._pendingStateQueue` without triggering a re-render.
        if (this._pendingStateQueue) {
          inst.state = this._processPendingState(inst.props, inst.context);
        }
      }

      renderedElement = this._renderValidatedComponent();
    } finally {
      ReactLifeCycle.currentlyMountingInstance = previouslyMounting;
    }

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

When using the try { ... } finally { ... } construct, the exception won't be caught actually, just the finally block will be executed, to allow for cleanup. If you're not seeing your exception being reported, it must be caught elsewhere.


Fix typo in sandbox build config

Summary: There was a typo in the config name.
Relevant Issues: #709
Type of change: /kind test-infra
Test Plan: bazel test //...

Going to force merge this since the build is broken


Some fixes for macOS build and optimising memory copies.

Adding "reserve" function to storage to allow for constructing an uninitialised-memory HDC which can later be filled by passing to an external function - needed for efficiently reading NetCDF data. Replacing vector with unique_ptr to avoid unnecessary memory sets.

Good idea.
I have run tests through IPP gitlab CI (until we have github actions working) and found some (mostly thirdparty) problems:

build with focal HDF5 fails due to this bug
bionic GCC 7.3 does not cope with -O3 flag - when using MDBM backend, it segfauls here probably due to the buffer length, which had then 32 bytes (without) header
-Werror makes xenial GCC 5.4 angry with:
thirdparty/jsoncpp/jsoncpp.cpp:2393:51: error: unused parameter ‘other’ [-Werror=unused-parameter] - I have also tried to update jsoncpp to the lates version, but it did not help.

The entire pipeline passes with those fixes, so we can probably merge this, if you agree.
I can look into these bugs in more detail later, but I don't have much time for that now.


Company filter only returns 25 job search results

I tried the company filter. It works well for the most part, but there seems to be an issue with the program - It only returns the first 25 jobs while there are hundreds on the website. I added something like "start=50" to the URL but it came back with the same results.

Hi there,
are you running anonymous or authenticated?
Mind that for both modes, you have to find a slow_mo value which doesn't cause your application to receive 429 Too many requests from the server. That will likely cause failure of jobs loading and pagination.
For anonymous mode, I suggest a slow_mo value no less than 1.3 while for authenticated session a value of at least 0.4 (it largely depends on Linkedin rate-limiting settings for the time being).
This is my attempt in anonymous mode:
scraper = LinkedinScraper(
    headless=False,
    max_workers=1,
    slow_mo=1.4,
)

query = Query(
    options=QueryOptions(
        locations=['Worldwide'],
        limit=500,
        filters=QueryFilters(
            company_jobs_url='https://www.linkedin.com/jobs/search/?f_C=25170579&geoId=92000000'
        )
    )
)

This is the code for authenticated mode:
scraper = LinkedinScraper(
    headless=False,
    max_workers=1,
    slow_mo=0.4,
)

query = Query(
    options=QueryOptions(
        locations=['Worldwide'],
        limit=500,
        filters=QueryFilters(
            company_jobs_url='https://www.linkedin.com/jobs/search/?f_C=25170579&geoId=92000000'
        )
    )
)

Let me know if this solves your issue. Cheers!

Before the 'Found 25 jobs' line it says 'starting pagination loop'. Check if it actually prints out more than 25 jobs. I get the same messages, and happily get more than 25 jobs.

Ok! So is your issue solved?

Hi!
In my case, when I do searchs by company with your code, I don't understand the reason why the connexion is only in anonymous mode...


CAMEL-13853: AvailablePortFinder now delegates the port selection to OS

CI: https://builds.apache.org/job/Camel/job/CAMEL-13853/10/

Looks good, no errors.


[draco] Patch for regex failure in cmake

Is your feature request related to a problem? Please describe.
When I was installing Ogre it failed due to draco erroring out during its cmake installation.
The underlying error was this line in cmake/draco_install.cmake
list(TRANSFORM draco_api_includes REPLACE "${draco_src_root}/" "")
where draco_src_root included a . in its version name 1.5.3-22404bd0ba.clean
it failed because that parameter is parsed as a regex string, as shown here under TRANSFORM REPLACE
https://cmake.org/cmake/help/latest/command/list.html#transform
Proposed solution
diff --git a/cmake/draco_install.cmake b/cmake/draco_install.cmake
index e15a054..e13961b 100644
--- a/cmake/draco_install.cmake
+++ b/cmake/draco_install.cmake
@@ -38,7 +38,8 @@ macro(draco_setup_install_target)

   # Strip $draco_src_root from the file paths: we need to install relative to
   # $include_directory.
-  list(TRANSFORM draco_api_includes REPLACE "${draco_src_root}/" "")
+  string(REGEX REPLACE "([][+.*()^])" "\\\\\\1" draco_src_root_regexed "${draco_src_root}/")
+  list(TRANSFORM draco_api_includes REPLACE "${draco_src_root_regexed}" "")

   foreach(draco_api_include ${draco_api_includes})
     get_filename_component(file_directory ${draco_api_include} DIRECTORY)

This is the patch I wrote to have it work on my end and the solution would be to include it.
Describe alternatives you've considered
An alternative would be to get draco to fix their cmake and make sure draco_src_root is a valid regex string.

The underlying error was this line in cmake/draco_install.cmake
list(TRANSFORM draco_api_includes REPLACE "${draco_src_root}/" "")
where draco_src_root included a . in its version name 1.5.3-22404bd0ba.clean
it failed because that parameter is parsed as a regex string

I don't think the . is the problem. It will match a dot. Usually it is a + as in D:/C++/vcpkg. Then the workaround is to chose a different dir for vcpkg.

This issue hasn’t been updated for a long time; if it is still an issue, please reopen this issue.


Update top-level README.md for Update 8

DONE IN THIS PR:
Edit top-level README.md to use Update 8 in visible text and links of Overview and SDK Maven repo sections.
TO DO:

Lines 39, 42: Does team want to change text in Run samples through the sample viewer section so it says ArcGIS_Runtime_Sample_Viewer_Android_1008.apk, instead of ArcGIS_Runtime_Sample_Viewer_Android_1007.apk? If you decide on Update 8, make sure you upload that version to Google Play Store.
Line38: Change the URL for on ArcGIS Online link so it points to Update 7 or Update 8 version of viewer, as appropriate?  Currently, URL points to the Update 4 item in the arcgisruntime.maps.arcgis.com org:
[on ArcGIS Online](https://arcgisruntime.maps.arcgis.com/home/item.html?id=6a214d1f4a374a9a873891707c0411ec) .

Note: I could not find any version of viewer later than version 6 in the arcgisruntime.maps.arcigs.com org: https://arcgisruntime.maps.arcgis.com/home/item.html?id=99ba5b13cfba41ec8bf246e1093156f1

@TADraeseke If you already have this under control, please just close this PR. I poked around but could not find an existing PR or issue addressing these problems.


Add Whitelabel Index Page

Created /Classroom/Basics/Whitelabel/index.html

This overview page contains links to all of SendGrid's whitelabel documentation

Hello @eschallock,Thank you for the PR! We will be reviewing this PR soon, in the mean                                              time, if you have not, please be sure to                                                                                sign our CLA so that we can merge your changes. Thanks again!                                             Team DX

Hello @eschallock,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team DX


New CMD

Added a Command called Eval, (I hope you know what it is lol) It's pretty simple and you can let more than one person use it! You Don't need to merge this but it would be cool :3

oops you might need to install some packages I prob should have added those sorry!

Thanks for the suggestion but I am not interested because it can be dangerous.


Get URL's matching 3XX,5XX

How can I filter the URL's matching 3XX or/and 5XX criteria?
For instance, I can see 404 URL's:

I see this in the documentation: $ awk '$9~/500/' access.log | goaccess -
But, is it a way for having it grouped in reports?
Thanks in advance!

Very close to what you have there:
# tail -f -n +0 access.log | awk '$9~/3[0-9]{2}|5[0-9]{2}/' | goaccess -o out.html -

Please note that assumes $9 is your status code field (Combined format), else you can always find it using:
# tail -10 access.log | awk '{print $9}'

Closing this. Feel free to reopen it if needed.


Resource group lock prevents node instances from being redeployed/reimaged

Describe the bug
After reimaging an instance it can't start with this error in log:
2024-11-27 13:58:14: Updating IP address for node-2
ERROR: (ScopeLocked) The scope '/subscriptions/<subscrID>/resourceGroups/rg-graphdb-preprod/providers/Microsoft.Network/pri
vateDnsZones/graphdb-preprod.dns.zone/A/node-2' cannot perform delete operation because following scope(s) are locked: '/subscriptions/<subscrID>/resourceGroups/rg-graphdb-preprod'. Please remove the lock and try again.
Code: ScopeLocked
Message: The scope '/subscriptions/<subscrID>/resourceGroups/rg-graphdb-preprod/providers/Microsoft.Network/privateDnsZones
/graphdb-preprod.dns.zone/A/node-2' cannot perform delete operation because following scope(s) are locked: '/subscriptions/<subscrID>/resourceGroups/rg-graphdb-preprod'. Please remove the lock and try again.
ERROR: (BadRequest) The list of record sets of type 'A' may not contain multiple entries with the same 'ipv4Address'.
Code: BadRequest
Message: The list of record sets of type 'A' may not contain multiple entries with the same 'ipv4Address'.

Possibly, it could happen after setting TF variable:
graphdb_java_options = "-Dgraphdb.page.cache.size=5G"
To Reproduce
After deployment try to reimage any instance from VMSS.
// paste code snippets here

Expected behavior
An instance is redeploying successfully
Nice to have

[ ] Terminal output
[ ] Screenshots
[ ] OS and Terraform versions

Additional context
Add any other context about the problem here.

Hello, @templier2!
Thanks for raising the bug.
I want to inform you that we are working on a fix, regarding this issue.
While you are waiting, you can change the lock_resources variable to false, in order to temporary fix the issue.
Best Regards,
Simeon Zhekov
Ontotext AD
DevOps Engineer

Hello, @templier2 bug has been fixed and it will be released with v1.5.0 of the module.
We will close the issue now.
Best Regards,
Simeon Zhekov
DevOps Engineer
Ontotext AD


Invalid dynamic for_each value for launch templates

Description
Hello 😄
I faced this error when upgrading to v15.1.0
│ Error: Invalid dynamic for_each value
│
│   on .terraform/modules/tests-eks/workers_launch_template.tf line 415, in resource "aws_launch_template" "workers_launch_template":
│  415:     for_each = lookup(var.worker_groups_launch_template[count.index], "additional_ebs_volumes", local.workers_group_defaults["additional_ebs_volumes"])
│     ├────────────────
│     │ count.index is 0
│     │ local.workers_group_defaults["additional_ebs_volumes"] is empty tuple
│     │ var.worker_groups_launch_template is tuple with 1 element
│
│ Cannot use a tuple value in for_each. An iterable collection is required.

Versions

Terraform: 0.15.1

Provider(s):

+ provider registry.terraform.io/hashicorp/aws v3.37.0
+ provider registry.terraform.io/hashicorp/helm v2.1.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.1.0
+ provider registry.terraform.io/hashicorp/kubernetes-alpha v0.3.2
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/null v3.1.0
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0

Module:  terraform-aws-modules/eks/aws

Reproduction

Steps to reproduce the behavior:

configure/upgrade a cluster using both worker_groups and worker_groups_launch_template
set

  workers_group_defaults = {
    root_volume_type = "gp2"
  }

to fix the "gp3" errormentioned in #1205

run a terraform plan to see the upgrade plan
error is thrown

Code Snippet to Reproduce

module "tests-eks" {
  source = "terraform-aws-modules/eks/aws"
  version = "15.1.0"
  cluster_name = local.eks_cluster_name
  cluster_version = local.cluster-version
  subnets = concat(module.eks-vpc.public_subnets, module.eks-vpc.private_subnets)
  vpc_id = module.eks-vpc.vpc_id
  enable_irsa = true
  write_kubeconfig = false

  map_users = concat(local.cluster-users, [
    local.github])

  workers_group_defaults = {
    root_volume_type = "gp2"
  }

  worker_groups = [
     {
      name = "kube-core"
      instance_type = "t3.large"
      asg_max_size = 6
      asg_desired_capacity = 3
      asg_min_size = 2
      autoscaling_enabled = true
      kubelet_extra_args = join(" ", [
        "--node-labels=node.kubernetes.io/lifecycle=core",
        "--register-with-taints=${local.taints.core.key}=${local.taints.core.value}:${local.taints.core.effect}"
      ])
      subnets = ...
    }]

   worker_groups_launch_template = [
    {
      name = "app"
      instance_type = "c5.2xlarge"
      asg_max_size = 100
      asg_desired_capacity = 0
      asg_min_size = 0
      key_name = aws_key_pair.ssh.id
      autoscaling_enabled = true
      public_ip = true
      kubelet_extra_args = join(" ", [
        "--node-labels=node.kubernetes.io/lifecycle=spot",
        "--system-reserved=memory=500Mi,ephemeral-storage=2Gi"
      ])
       subnets = ...

Expected behavior
The plan should execute successfully.
Actual behavior
The error above is reported.
Tried inspecting the module with TF_LOG=DEBUG but didn't find any useful hints.
Additional context
Faced during an upgrade of the module from the latest 13.x version.
Same error with Terraform 0.15.0.

Ran into the same issue when trying an upgrade to TF 0.15.3 (from 0.14) today. Diving into the error and looking around has led to a lot of confusion.
The format for additional_ebs_volumes given here is a list of maps. But looking at one of the several places this value is used (either via a default or a value passed as one of the worker group configs) it is passed into a for each.
The docs for for_each specify it must take either a map or set of strings.
Except, for_each inside of a dynamic seems to be treated specially according the the docs for dynamic. Importantly, it states that for_each accepts "any collection or structural value".
At least at the moment this feels to me like a regression in terraform itself (which is treating the 'special' for_each inside dynamic as a normal one), but I haven't had time to try and pin it down further yet.

Hi,
Same issue, proposed workaround does not work for me.
Thanks,

Working from my thoughts about the two scopes of for_each above, spent some time today trying to replicate the issue at the terraform level with the goal to get something that would be reportable as a bug to the TF repo directly. First I tried using aws_s3_bucket resources (since its doesn't rely on anything existing, and using the lifecycle rules blocks as a dynamic target), but I wasn't able to reproduce the error. I then tried by taking the aws_launch_template from this module and stripping anyway as much unrelated to the ebs configurations as I could, but I still can't seem to replicate that way either.
Perhaps someone else will have more luck isolating? I still don't think its an issue with this module due to the nature of the error and it only presenting on a TF upgrade, but it doesn't seem my idea above was correct.

@mmcguinn thanks for checking it out, I will try to replicate the error.
I saw there is a new version of the module: 16.0.0, I just updated my code to it, but this error still persists.

Can we close this ? Since it sounds like it's fixed in terraform core ?

I didn't test it with the provided combination but given other have succeeded I can close 😄


fix default artifacts to exclude ios and android

Description
We should not default to all artifacts for arbitrary flutter commands.
cc @Hixie

I guess the next step is being more fine-grained about the individual artifacts?

I guess the next step is being more fine-grained about the individual artifacts?

Yes, we can break up most of the platform artifacts down by mode. There's no clear path to moving things like the gradle wrapper or material fonts out of universal, but these are also fairly small in terms of download size.


cleanup and json schema validation removal

json schema validation has been removed since we can still get the validation from database when executing an query with invalid data or format
custom formats for types need to be explicitly checked in respective places where used

functions to enable and assist multi tenancy have been added
partial fix for running knex cli through npm scripts stuck issue
added a timezone json to json folder in case needed


Underscore Header Bad Request

Please provide us with the following information:

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When I request my container app with the header
Sfdc_stack_depth: 1
Then the container app responds "Bad Request" but I confirm the request is not reached my runtime.
When I request without Sfdc_stack_depth, then the request is reached my runtime.
https://stackoverflow.com/questions/47005217/enable-underscores-in-headers-on-azure-ingress
I can't customize the setting in azure container app.
Steps to reproduct

POST request with Sfdc_stack_depth

$ curl https://sleekflow-apigw-app4811ecf6.delightfulwave-63e42554.eastasia.azurecontainerapps.io/v1/healthz && echo
{"crm-hub":{"content":"HEALTH"},"salesforce-integrator":{"content":"HEALTH"}}
$ curl --header "Sfdc_stack_depth: 123" https://sleekflow-apigw-app4811ecf6.delightfulwave-63e42554.eastasia.azurecontainerapps.io/v1/healthz && echo
curl: (92) HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)

I'm also running into this problem and it is currently blocking me from moving to Container Apps. If anyone can find a work-around that would be amazing!

Update: Something that worked for me was to use DAPR for the HTTP calls instead of the ingress endpoint. Unfortunately that doesn't solve the problem if you need to access the app outside of the container apps environment.

 The front door acts a an apigw to change the underscore header to a normal header, or simply remove the underscroe header if you don't need to read it.

Same on my case, I do have this problem, I'm currently deploying a normal next.js app, this app though is doing some request using the following headers:
__rsc__: 1
__next_router_state_tree__": ["",{"children":["",{}]},null,null,true]

the request is not reaching the runtime, and these headers are needed since not include them produced different result than including them.

@ahmelsayed this one can probably be closed as well