Support multiple major.minor versions

We should allow folder structures like this:
/jquery
  index.d.ts
  tsconfig.json
  jquery-tests.ts
  /v2
    index.d.ts
    tsconfig.json
    jquery-v2-tests.ts
  /v3.1
    index.d.ts
    tsconfig.json
    jquery-v3.1-tests.ts

This should parse the major and optional minor version number from the folder name and generate versioned packages published under the same name as the parent folder.

This come up in a Gitter chat, but instead of putting meaning onto the directory it might be useful to use a meaningless folder structure and embed the version meaning in package.json. For instance, to support multiple TypeScript versions as well. To keep it simpler, I'd suggest always nesting or always having it flat - so either multiple versions or not, and not a mix, as mixing it will make it very tricky to keep track of in the case where you're writing .d.ts files for nested files.
So, in this case:
/jquery
  index.d.ts
  tsconfig.json
  jquery-tests.ts

Or:
/jquery
  /v2
    index.d.ts
    tsconfig.json
    jquery-tests.ts
  /v3.1
    index.d.ts
    tsconfig.json
    jquery-tests.ts

Where v2 and v3.1 are not used for the version but are instead only semantic. The actual version is stored in package.json so it could also have a typescriptVersion and other matrix-release related properties.

@RyanCavanaugh , @andy-ms :  is there significance to the "v" prefix (or any other special patterns?).
I.e., suppose I want to have a regular version as well as a beta version.  In our case, we already have an @types/office-js package published, and we want to continue to have that work as is; but at the same time, we also want to have an easy beta version.  What would your recommendation be?  Is it possible to have both a @types/office-js and @types/office-js@beta, and if so, what should the directory structure look like?
Thanks!

v is simply ignored
There isn't any support for tagged releases right now. I suppose we could add support for version numbers like 2.4-beta and there shouldn't be any problems from that. Thoughts @andy-ms ?

@RyanCavanaugh , could you help me understand what you're proposing?  Is it that I would have both a 1.1 folder and a 1.1-beta folder?  But could we still make the default one ("latest" from an NPM perspective) be the 1.1 one?  (or actually, if you're thinking of having a hyphen denote the tag -- should it be 1.1-latest, and would it then "just work"?)
Thanks!

(@RyanCavanaugh , please see the comment above -- and note that I edited it since I first saw it, so please look at it on GitHub rather than in your email)

Tags and versions are independent. The @latest tag would point to the non -beta version in this proposal. It's fairly difficult in NPM to install a -foo-suffixed version (you would have to explicitly say npm install<EMAIL_ADDRESS>so there wouldn't be a danger of someone accidently getting it instead of the 1.1 version.

So what would my folder structure and usage look like?
For folder structure, would I put 1.1 and 1.1-beta side-by-side as siblings (and no files at the root), like @blakeembrey had mentioned in an earlier ocmment?
/office-js
    /v1.1
        index.d.ts
        tsconfig.json
        office-js-tests.ts
    /v1.1-beta
        index.d.ts
        tsconfig.json
        office-js-tests.ts

And then the tool would look through, and create two package.json-s:  one that has a version 1.1.X, and another that's 1.1.X-beta.0, publishing the latter with a beta tag?  But how would the tool know which one is my default/latest -- i.e., what if I also had a v2.0 folder, how would it choose?
And then for usage, for the default, a developer would just do:
npm install --save-dev @types/office-js

And for beta:
npm install --save-dev @types/office-js@beta

correct?

I think the compelling reason is... well, to make it easy to try out beta :-).  From the standpoint of how the tool would run its publishing automation, I think all it would need to do differently is add a --tag beta to the publish command:  npm publish --tag beta.
At least for Office.js, we have an evergreen CDN (https://appsforoffice.microsoft.com/lib/beta/hosted/office.js) where the JS files are hosted, so version numbers don't mean much -- no one would know that they need to do<EMAIL_ADDRESS>because the 1.1.314 number wouldn't really exist anywhere.  Whereas having the simple instructions of "to use Office.js with TypeScript, do an npm install of @types/office-js (appending @beta to the beta version)" seems like a very straightforward way of having folks try out the APIs.  And it should't make it any harder on the tool, as far as I can tell...
Having the tag also makes it easy to view (& copy-paste) the latest file via unpkg.com:
// for the "release" version:
<EMAIL_ADDRESS>
// for the beta version:
https://unpkg.com/<EMAIL_ADDRESS>

It all sounds doable, but this thing publishes thousands of packages and adding code to handle a single thing isn't a totally great trade-off. Since you're internal anyway we can just give you publish rights to @types/office-js and you can push whatever version under whatever tags you want; nothing should actually break the types-publisher as it's fairly resilient to extant conditions of the package. Thoughts?


CollaborativeProgramming is not OpenSource

Description of the issue
CollaborativeProgramming is a subclass of OpenSource right now.
It's more likely a process or activity or sth like that.
And needs a def.
Ideas of solution
Workflow checklist

[x] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have an annotation
[x] classes should arise from concepts rather than from words
[x] class or property names should follow the UpperCamelCase

proposal:

CollaborativeProgramming as process
def: "CollaborativeProgramming is the process of two or more people programming together on one computer.

Class Process seems right.
Collaborative programming does not necessarily take place on 1 computer, does it? Take github for example. @Ludee you are an expert in collaborative working I guess. Do you have a good def?

I also don't think it is necessarily happening on one machine - each participator could to so on his/her own machine checking code in and out using version control and following a standard protocol for dealing with changes (as here on github for OEP for example). The latter may not be a necessary condition for collaborative programming I think, but highly recommended.
How about: CollaborativeProgramming is the process of two or more people working on program code together (according to a specified routine).

How about: CollaborativeProgramming is the process of two or more people working on program code together (according to a specified routine).

maybe add the "same time" component?
CollaborativeProgramming is the process of two or more people working on program code together at the same time (according to a specified routine).

maybe add the "same time" component?

I like the idea - I think that it does not need to be exactly the same time though. So we could collaboratively develop code over the whole time-span it needs for the code to be done, but this does not entail that we work in parallel at the exact same time.?

I'm not sure if there's a uniform opinion of what collaborative programming is and I can't find definitions etc on the internet.
So maybe we can delete that term and use others with more concrete definitions like 'pair programming' instead?
Why do we need that class anyway?

I am ok with deletion.

I would be ok with deletion also, but:

Why do we need that class anyway?

I think we want to show that the development of energy system models can happen in a collaborative manner by developing code together, not necessarily via pair-programming but as a joint effort.
Maybe @Ludee  should get us up to speed with how to deal with this?

so we leave it out vor now and decide how to deal with it in the next milestone when we maybe have more infos and a stronger focus on oeo-model?

we also need cooperative programming (from #197), is this the same as collaborative programming?

The results so far:

Collaborative Programming is the process of two or more people working on program code together at the same time (according to a specified routine).
It is not clear what Collaborative Programming is exactly. Possible solutions: Find experts, define more concrete classes (i.e. pair programming), delete (for now, collaborative programming is deleted)
Cooperative Programming is needed for the fact sheets

As far as I can tell, both cooperative and collaborative programming are not widely used and clearly defined terms. I found this definition for collaborative programming:

two programmers are working jointly on the same algorithm and code source

This definition is in line with our suggestion. Also, I don't see a huge difference between cooperative and collaborative programming, so I would suggest to include a class cooperative programming with def Cooperative Programming is the process of two or more people working on program code together at the same time (according to a specified routine). and alternative term collaborative programming. That would cover the factsheet and provide an superclass for concepts such as pair programming, if we decide to include them later.

I would suggest to include a class cooperative programming with def Cooperative Programming is the process of two or more people working on program code together at the same time (according to a specified routine). and alternative term collaborative programming. That would cover the factsheet and provide an superclass for concepts such as pair programming, if we decide to include them later.

I like this proposal.


Temporary fix to include php and .net images

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing for now as it's unclear as to what this is solving. Reopen if you disagree.


Fix default of wrapFieldDefinitions

See issue: https://github.com/dotansimha/graphql-code-generator/issues/6993

Thanks @dchenk !


how to stand for es6

import React ,{ Component, PropTypes}from 'react'
import { connect } from 'react-redux'
import { bindActionCreators } from 'redux';
import template from './Home.rt';
//import LinkedStateMixin from 'react-addons-linked-state-mixin';
import linkState from 'react-link-state';
import mixin from 'es6-react-mixins';
/**

mixins: [LinkedStateMixin],

*/
class Home extends Component {
constructor(props,context){
super(props,context);
this.state={
"name":"ling"
}
}
render() {
return template();
}
}
export default Home;
then .rt:

hahahhhhhhh====>{this.state.name}

it's error,can't done

I got the answers:
render() {
return template.apply(this);
}
=*=

better is:
import template from './Home.rt';
class Home extends Component { ... }
Home.prototype.render = template;

Is this project forked and maintained anywhere?

no there is no "official" fork that I know. But in my nippur72/react-templates I have merged the PR that here are waiting to be reviewed.


Ability to use project name as Application name

Would it be possible to use the Project name instead of IDE name as Application name?

This is not possible. The application name is the one provided in the discord developer portal and cannot be changed elsewhere.

Ah, that is unfortunate. So you have a several pre-defined applications in discord side named "PyCharm", "PyCharm Community", etc. And to be able to change it, one may need to register as a developer in discord, and create/update/change that name there. Am I correct?

Ah, that is unfortunate. So you have a several pre-defined applications in discord side named "PyCharm", "PyCharm Community", etc. And to be able to change it, one may need to register as a developer in discord, and create/update/change that name there. Am I correct?

Exactly!

Ok. Thanks for quick responce!


Fix image override for jobs

Cherry pick https://github.com/knative-sandbox/operator/pull/81
Release Note

Fixed image override for Knative Eventing 0.14 upgrade job

/retest

/retest

@houshengbo
Prow says
2020/05/08 09:06:42 Error creating license classifier: cannot register licenses from archive: open /home/prow/go/src/knative.dev/test-infra/vendor/github.com/google/licenseclassifier/licenses/forbidden_licenses.db: no such file or directory\u0026#xA;

I see https://github.com/knative/test-infra/pull/1865 and https://github.com/knative/test-infra/pull/1989 and I think we didn't get the change because https://github.com/knative/eventing-operator/pull/208 was closed.

@aliok Let's only backport to the release-0.14 branch for patch release, since we will no longer maintain the separate operators.

/close


Updating the runner in the daily e2e workflow

Updating the runner in the daily e2e workflow to ubuntu.
Resolves: MWPW-156128

Test URLs:

Before: https://main--bacom--adobecom.hlx.live/?martech=off
After: https://daily-runner--bacom--adobecom.hlx.live/?martech=off

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.95%. Comparing base (ad40e43) to head (27c3028).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #236   +/-   ##
=======================================
  Coverage   95.95%   95.95%
=======================================
  Files          11       11
  Lines        1088     1088
=======================================
  Hits         1044     1044
  Misses         44       44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix endpointslice deletion bug

fixes https://github.com/istio/istio/issues/33672
this fix makes sure that the cache is not wiped when a single delete is called.
cc @howardjohn

@adiprerepa: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4723208bbaacb5ff7291d8f62764c037cac16827
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adiprerepa: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
675f40cffcf3d6114cc4e8d713a81a28fa5abeed
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #33753

In response to a cherrypick label: new pull request created: #33754


Modify .dockerignore to optimize Docker image build

To optimize the Docker image build and ensure unnecessary files are not included, it is important to add a .dockerignore file to the repository.

Hi @Gabrielfernandes7 is there a large file that is unnecessarily being sent to the build context? If so feel free to create a PR that prunes it!


output-all fails when one of the modules on the root dir doesn't have outputs

When terragrunt output-all runs on a root dir, and one of the sourced modules has no outputs it fails the whole thing.
I propose a config parameter: --terragrunt-ignore-output-errors (similar to --terragrunt-ignore-dependency-errors)
For now the only workaround was to create a dummy output on the modules that don't any:
output "dummy" {
  value = ""
}

Ah, seems like a good addition. PRs welcome!


DEPS.xwalk: Roll libpxc (5ac4620 -> 568e4ec).

568e4ec Merge pull request #4 from huningxin/wm6
ba5eb7d Upgrade to <IP_ADDRESS>28
31feceb Merge pull request #3 from halton/gn
fb93d61 Add BUILD.gn
BUG=XWALK-6227

@rakuco , PTAL. Thanks!

lgtm


Generated types file is invalid

When I run supabase gen types typescript the types file that is generated is invalid. There are plenty of duplicate fields:
Error: Duplicate identifier 'exception_unknown_field'.
Error: Duplicate identifier 'comment'.
etc...

I'm seeing this on the Functions property which does not seem to account for overloading


Issue with google authentication

RN Version:
react-native-cli: 2.0.1
react-native: 0.44.0

My Code:
import google from 'react-native-simple-auth';
and
<Button
    onPress={() => google({
        appId: '8939<not sure if I should post this data here>.apps.googleusercontent.com',
        callback: 'com.googleusercontent.apps.8939<not sure if I should post this data here>2r:/oauth2redirect',
      }).then((info) => {
        console.log(info.user);
      }).catch((error) => {
        // error.code
        // error.description
      })
    }
    title={'authenticate'}
 />

Installation:

yarn add react-native-simple-auth
adding iOS URL scheme to URL Types (1) in Xcode.

Error:

Other information:
I am currently just interested in IOS

when I imported it, I needed:
import {google} from 'react-native-simple-auth';
not
import google from 'react-native-simple-auth';
because I am importing an object.


Remove home link disable on panic popover

I presume this change was made a while ago when the panic button was on top of Desmos' home link. I was checking the git history of this line, and it seems the last change was about a year ago in May, so I think it lines up. Either way the purpose of this change is because currently the link is unclickable until the popover is open, but then it is blocked, so it renders the home link unusable.

The benefit to being to lazy to fix the replacement error is that you figure out problems with the panic handling :).
Pretty sure the integration test errors are just because shift-enter-newline is broken, so I'll just override and merge this in now.


Remove ConfigureGlobalOptions or SetApplicationName from DataProtectionConfigurationExtensions

There are 3 ways right now to set the application name.
services.AddDataProtection(options => options.ApplicationDiscriminator = "name");
services.AddDataProtection().SetApplicationName("name");
services.AddDataProtection().ConfigureGlobalOptions(options => options.ApplicationDiscriminator = "name")

We could get rid of the two last ones or just keep one of the two for non DI enabled scenarios. (A non DI enabled scenario would look like this)
DataProtectionProvider.Create(directory, builder => { builder.SetApplicationName("name")}) or
DataProtectionProvider.Create(
    directory,
    builder => {
        builder.ConfigureGlobalOptions(options => options.ApplicationDiscriminator = "name")
    })

If we want to get rid of both methods, on a non DI scneario, the user only needs to write
DataProtectionProvider.Create(
    directory,
    builder => {
        builder.Services.Configure<DataProtectionGlobalOptions>(options => options.ApplicationDiscriminator = "name")
    })

builder.Services.Configure(options => options.ApplicationDiscriminator = "name")
In my opinion this is not crazy and we can just get rid of those two methods.

Seems reasonable to me.  @Eilon @rynowak @lodejard Thoughts on this one?

cough
I strongly suggest there is a way to set the application name globally that is easy to discover. Neither of the fixes look easy.

@blowdart do you have a recommendation?

Well right now, if you read the documentation you'll see there's a 4th way, we say
services.AddDataProtection();
services.ConfigureDataProtection(configure =>
{
    configure.SetApplicationName("my application");
});

That was easy, but I presume it doesn't stay in step with the new config madness and the equivalent is
services.AddDataProtection().SetApplicationName("name");

?

@blowdart Yes, that's an option, but in that case, what would be the benefit of having an overload with options? The only thing you can configure there is the application name.
I consider more discoverable the options overload due to the fact that is the only thing you can configure in the global options object. SetApplicationName gets buried with the rest of configuration methods. That said, I don't see any reason for application name to hold that distinctive status (being part of options vs being a method on the builder like the rest). If we keep the method (SetApplicationName) would we consider removing the global options overload? If we add more things to the global options in the future, would we create an extension method for each detail we would like to configure there? Should other configurable elements that aren't part of the global options object be part of it?
I think that keeping things simple (in the options object) puts us in a better position moving forward. If it's a piece of data we want to configure, it should be part of the options object and configured in the initial lambda, '''options => options.Property = value''' if it requires adding extra services it should be a method on the builder. Services that require access to the configuration data should ask for the configuration object through DI. Thoughts? @lodejard @eilon

It's optional to configure. I presume the autogeneration pieces won't change?
(You will of course be submitting a PR to the docs right?)

@blowdart Yes, I will fix the docs for everything and make you and @danroth27 happy :smile:

What we decided is to keep SetApplicationName and remove ConfigureGlobalServices

@javiercn can you mark this issue as Done, plus post a announcement regarding this?

@javiercn I can't seem to get SetApplicationName. This no longer seems to work ...
services.AddDataProtection(configure =>
{
    configure.SetApplicationName("app_name");
});

... and I've tried several other approaches, e.g. ...
services.AddDataProtection().SetApplicationName("app_name");

without luck. How are we doing this now?
I'm on CI nightly with latest dotnet cli ...

Microsoft.AspNetCore.DataProtection/1.0.0-rc2-20270

Hi, sorry for the delay. Here is the announcement post that describes the changes. https://github.com/aspnet/Announcements/issues/159

Both options are valid for configuring the application discriminator. In general, functionality from DataProtectionConfiguration has moved to extension methods on IDataProtectionBuilder as we do elsewere in the framework. So the pattern now is
services
    .AddDataProtection()
    .SetApplicationName("...")
    .AddKeyManagementOptions(...)

Let me know if you have any further issue.

@javiercn
I tried ...
services.AddDataProtection().SetApplicationName("my_app");

... and receive ...
c:\my_app\Program.cs(99,50): error CS1061: 'IDataProtectionBuilder' does not
contain a definition for 'SetApplicationName' and no extension method
'SetApplicationName' accepting a first argument of type 'IDataProtectionBuilder'
could be found (are you missing a using directive or an assembly reference?)

It seems to be happy with ...
services.AddDataProtection(options => options.ApplicationDiscriminator = "my_app");

... so I'm on an old package?
"Microsoft.AspNetCore.DataProtection/1.0.0-rc2-20270"

https://github.com/aspnet/DataProtection/blob/dev/src/Microsoft.AspNetCore.DataProtection/DataProtectionBuilderExtensions.cs#L35
Both changes went in at the same time. Maybe you are missing an using?
I've checked my nuget package cache and 1.0.0-rc2-20269 contains the changes. You can search for DataProtectionBuilderExtensions on the assembly to be sure.
Let me know if you still run into issues.

@javiercn ok ... I'll see where I've gone wrong. Thanks.

@GuardRex I'm facing same issue, did you found the reason why the following didn't work?
services.AddDataProtection().SetApplicationName("my_app");

I did get it working, but I don't exactly recall what did the trick. As @javiercn said, I think I was missing a using ... maybe it was just using Microsoft.AspNetCore.DataProtection;.


Moving write length to functions

Adding functions that OnSerializeSafely can use to write length of message

maybe we can find a better name for the functions?
it wouldn't be obvious what they do if you look at it from the outside.
also, should we really move them into reader/writer? they are only used in 1 place.

maybe we can find a better name for the functions?
it wouldn't be obvious what they do if you look at it from the outside.
also, should we really move them into reader/writer? they are only used in 1 place.

Looking at this again now, we probably dont need to move this code.
Unless someone think of anywhere else we are likely to use this in the future ?

let's reconsider if we ever need it in more than one place :)


Fix TestPipelineBuildLifecycle & fix race in PutFile

Fix #5345
Summary: TestPipelineBuildLifecycleGo (and ...Python, etc) were flaking due to an encoutering a race in PutFile. The race is this: putFile reads its incoming stream of PutFileRequests using forEachPutFile, and forEachPutFile spawns a goroutine for each new file in the incoming stream. When multiple independent files are being written, e.g. /a, /b, ..., forEachPutFile spawns a concurrent goroutine to write each of them. This works well and gives us good throughput, as forEachPutFile can read data from the incoming stream while child goroutines are waiting for object storage to finish writing.
However, when conflicting operations are sent in the same stream, e.g. Delete(/) -> Put(/src.go) as in TestPipelineBuildLifecycle*, the Go scheduler might choose to run eg.Go(Put(/src.go)) first, even though it was spawned second, causing /src.go to be written and then immediately deleted by Delete(/).
This PR attempts to fix the issue by introducing a new class, pathlock, that blocks forEachPutFile from running a new operation as long as a conflicting operation (on a parent or child path) is already in progress. Basically, forEachPutFile would call start("/") and that would block start("/src.go") from running (becuase /src.go is a child of /) until finish("/") is called. (Likewise, if the operations were deliberately performed in the reverse order, start("/src.go") would block start("/") until finish("/src.go") is called)
A simpler solution might be to remove all concurrency from forEachPutFile, but my understanding is that that would unacceptably hurt PutFile throughput. Given that constraint, I tried to keep this simple by only allowing pathlock.start() to block a single goroutine at a time (so it works for forEachPutFile but not much else, and stays in the pfs/server package). A comment in pathlock.go elaborates on this constraint.
A few other changes also made in this PR:

make lint was failing silently (which @nitinjainsj found) in CI due to a prior change I made. This PR should fix it
PutFile now writes Debug-level logs at both the start and end of writing/deleting a file within the stream (and the logs are changed to look more like our regular GRPC logs)

My only concern is that it is not obvious that each start corresponds to a finish in forEachPutFile if that could be refactored to use a switch for the various operations and have one start and one finish above and below that would be better. We will probably revisit this code for StorageV2, so if there's no clear path to make that change now, then I say okay to merge as is.

I see your point—my feeling is that this would be a fairly significant rewrite of forEachPutFile, so my instinct is to do that separately, but I definitely think it's warranted. If I see a good way to rewrite that, I'll go for it (I think it'll be similar to some of the merging code, in that we'll need some helpers for the different PutFile branches—URL, object storage, etc—and the ability to peek ahead into the stream to decide which one to use)


'cannot resolve' errors for imports in WebStorm

I'm submitting a ...
[X ] question about the decisions made in the repository

What is the current behavior?

I just cloned the Angular 2 Webpack Starter, and tried it in WebStorm 11.
It mostly works, but WebStorm complains and underlines some module import names.
The reason is the Angular 2 Webpack Starter imports directories, not file names.
e.g. import {Home} from './home', instead of import {Home} from './home/index'
My question is:

Is the import of directories a standard TypeScript feature?
If not, why is it implemented in this otherwise excellent repo, as it is sure to trigger validation errors in IDEs like WebStorm?
If the import of directories is standard TypeScript, please advise, so I can report this issue to the WebStorm team.

What is the expected behavior?

this repo to keep to standard TypeScript features;
WebStorm IDE to be aware of all standard TypeScript features;

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

I posted about this in SO:
http://stackoverflow.com/questions/36665683/angular-2-webpack-starter-gives-cannot-resolve-errors-for-imports/36667004#36667004

On how TypeScript resolves modules:
"
An import statement like import { b } from "./moduleB" in /root/src/moduleA.ts would result in attempting the following locations for locating "./moduleB":

/root/src/moduleB.ts
/root/src/moduleB.ts
/root/src/moduleB.tsx
/root/src/moduleB.d.ts
/root/src/moduleB/package.json (if it specifies a "typings" property)
/root/src/moduleB/index.ts
/root/src/moduleB/index.tsx
/root/src/moduleB/index.d.ts
"

http://www.typescriptlang.org/docs/handbook/module-resolution.html
So it seems it is a standard TypeScript feature, dating from TypeScript 1.6, to look resolve to ./module/index.ts when ./module is imported.
It seems that Angular 2 Webpack Starter was using correctly a standard TypeScript feature, which would mean that WebStorm 11 has no cause for complaining.
I will then ask the WebStorm team how to solve this issue...


Prettier + CI

This PR

makes prettier run as part of eslint. IMO simplifies the workflow a bit, as there is only one lint target.
besides we now run linting on CI
uses yarn instead of npm on travis

Looks good, thanks!


parens for LONG_LONG_INT in cmake

when this is defined as "", cmake bails with an error about arguments in
if

Coverage remained the same at 90.178% when pulling 2af820fb9914318942433a6a5a1dda1c03b57fdd on quiet:master into bc5741fb1ac730ead24e9bd08977fc6c248e04b0 on akheron:master.

Merged, thanks!


Templates contain duplicate on_put() blocks

See this Developer List thread by James Hannon. Templates contain duplicate on_put() blocks! The second one can just be deleted, you'll see it's a partial.

Released 0.4 with this fixed in the templates.


Add multiple "few unique characters" reasons based on the number of unique characters

Currently, the "few unique characters" reason is triggered in essentially the same way if a post has just two unique characters or as many as 15. This degrades the validity of this reason as a determinant of spam and hurts autoflagging accuracy.
I would suggest splitting this reason up into several separate reasons, like "5/10/15 or fewer unique characters in title/question/answer". We could go so far as to have individual reasons for each number of unique characters, though this would probably add a significant amount of complexity and would be computationally expensive.
This chat conversation provides some context behind this issue.

Could you point to posts where this makes a difference? Does it really make a difference for proper spam (not rude/abusive/vandalism)?

After all, vandalism is only a side-effect of our spam searching and not the focus of our organisation.

I guess there is little interest in this feature.
Closing.


Launcher requires admin privileges to run

When I download and install Decentraland from the official decentraland.org website, its desktop icon indicates that it requires elevation to run:

Indeed, when I run it, I'm asked for admin privileges.

This is beyond unacceptable. It is awful user experience, it means non-admin users cannot run the game, and it means an attacker could take over the computer through Decentraland.


Update About Us and Image format

Pull Request Test Coverage Report for Build 1294

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.497%

Totals

Change from base Build 1292:
0.0%

Covered Lines:
2438

Relevant Lines:
2694

💛  - Coveralls


Add the finalized key stories text to the figure #202

Mobile (my phone)

Desktop

Talked to @lindsaycarr and we discussed trying to just split the figure in half and stacking the two on mobile.  I think its a huge improvement compared to what it was in the readability department.

Marty came and showed me how it looks on his phone right now and text size feels fine to me. I wish I could pinch and zoom on just that single fig (like zooming into the whole webpage) but we disabled that so that people couldn't do it on the main fig.

Per our group Slack convo, Marty is gonna try to squeeze up the font size on mobile a little more, putting in effort within reason given the approaching deadline.
I really like the overall look of the desktop pie map! Information rich, colorful, and nice placement and shaping of the text blocks.

Larger font for the mobile figures and I evened up the split in the country to avoid the size difference shrinking the text on either figure.


Enable stop orders on spot markets

The Chore
Core are attempting to fix the stop orders on spot markets.
Once this is done we need to make sure they work.
Tasks

[x] Enable stop orders on spot markers
[ ] Give the option to do post only
[x] Remove the option to do reduce only (as there is never a "position" to reduce)

Additional details / background info

Post only are available only for limit orders that are not FoK and IoC. Stop orders can be only Fok or IoC. Post only is not possible with stop order.


Move org.nlp4l.core package codes in nlp4l to org.nlp4l.lucene in framework

Moved org.nlp4l.core package codes (except CSVImporter.scala) in the nlp4l  repojitory to org.nlp4l.lucene in framework repository.
org.nlp4l.core package in nlp4l still exists, and those will be deprecated.

I found that you used org/nlp4l/lucene/ directory for apps but org/nlp4l/framework/lucene/ was used for tests. Can you make correction? And also, can you change copyright header from 2015 RONDHUIT Co.,LTD. to 2016 org.NLP4L.
Thanks!

Sorry, I have fixed test src package to org.nlp4l.lucene.
Also, I have changed copyright to 2016 org.NLP4L.


"Password to begin exam" option

Allow the exam author to set a password which must be entered on the front page before the exam can start.

Duplicate of #487


[WIP][KYUUBI #1225] Add kyuubi-extension-spark-3-2 module

Why are the changes needed?

see https://github.com/apache/incubator-kyuubi/issues/1225
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1226 (15f15f6) into master (556b5ad) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1226   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         156     156
  Lines        5985    5985
  Branches      636     636
======================================
  Misses       5985    5985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556b5ad...15f15f6. Read the comment docs.

cc @cfmcgrady @i7xh @zhang1002 @yaooqinn @pan3793 @turboFei , since it's a big change for spark extension module.

I propose to simplify maven profiles in this way.

keep spark-3.0, spark-3.1, spark-3.1
when spark-3.1 is active, enable kyuubi-extension-spark-common module and kyuubi-extension-spark-3-1 module
do same thing when spark-3.2 is active

Then we can remove profiles kyuubi-extension-spark-3-1 and kyuubi-extension-spark-3-2, and not required to overwrite spark.version in sub modules. @ulysses-you @yaooqinn WDYT?


Curseforge API impacts

A summarizing issue to list the potential impacts for this modpack by the upcoming Curseforge API.
Notable points:

As a default, the toggle [to allow accessing a CF project with the API] will be on for existing projects, and off for new ones.
Edit: I've heard that all new projects must now explicitly select whether they do or do not want to allow external downloads. Still, same caveats apply if disallowed.

Translation: new mods added to the pack may not be downloadable by non-CurseForge launchers, that could cause fragmentation
Solution: FO will keep it enabled and suggest mod authors to do the same

Downloading a modpack through a 3rd party service using the API will download only the enabled mods [or dependency mods].

Translation: modpack may lack some mods when downloaded via a non-Curseforge Launcher
Solutions:

For MultiMC: make sure to download from FO's CurseForge listing, not from its built-in feature
Download the missing mods manually
Switch to CurseForge, MultiMC or vanilla launcher

Legacy API is deprecated on February 9th of May

Translation: outdated non-CurseForge launchers will break, but I expect the ones I recommend to update in time
Solution: use Curseforge Launcher, MultiMC or vanilla launcher if the others do break

Curseforge linux support should come out before the old API is killed off. [source: CurseForge discord moderator] Edit: not exactly, but it is still coming soon

Translation: Linux users can also use CurseForge Launcher, which means better experience for them, supporting me and the mods
Also do vote for this survey!

CF API postponed to April
Linux CF client soon, but WoW only at first
You can now install individual mods to a CF profile via the install button on the site (presumably you still need to enable content management toggle first, haven't tested)
https://mailchi.mp/overwolf/whats-new-with-overwolf-curseforge-february22

hopefully, the end of this month [there is info regarding the migration]

wolfgang, a Overwolf dev (via)

Hmm we are in May but the old API is still working

9th of May

wolfgang

API deprecated on 9th of May
New website planned, with better navigation and search. Will be a separate beta portal at first, then merged into main.
Linux client will be out for WoW in May, Minecraft and others to follow later.

https://us15.campaign-archive.com/?u=5542885c5f38ae9a4108ab154&id=feacea0385

CF postponed it to May 16th
Linux client out for WoW

https://medium.com/overwolf/delay-in-the-old-api-deprecation-and-linux-client-launch-f424cbc4235c

packwiz-installer will be updated in due course to support these changes, though I cannot guarantee this will be finished before the old API is disabled.
Existing modpacks, with the download URLs already stored, will not be affected unless you wish to update or install new mods from CurseForge.

https://discord.com/channels/754677731702341672/782268590182498315/972537733157376051 (via https://discord.gg/DcSkRF4)
So basically current MMC (au) and Modrinth won't break and the dev is working to update the former to CF API. Modrinth will not be able to get updated via CF soon though, might figure out alternatives.

https://medium.com/overwolf/the-curseforge-official-api-is-now-live-d314606355c2
TL;DR:

New API released
There is a Overwolf-free alpha version of CF Launcher for Windows, currently WoW-only

Current status:

packwiz is not yet updated, though working on it
GDLauncher kills your entire instances when you update lmao (https://github.com/gorilla-devs/GDLauncher/issues/1288)
MultiMC's Curseforge support is 🦀 (https://github.com/MultiMC/Launcher/commit/0a827ba70e6ef20187f8507a536d54a8441020dc)
Modrinth's Curseforge support is iffy at best

Good times. /s

ATLauncher currently has a workaround to this, they will open the mod download in your browser, and then automatically  move it from your downloads folder to your mods folder (still a little buggy)
This works about 95% of the time

Update summary:

packwiz is fixed a long time ago
Modrinth no longer supports CF URLs #63
GDLauncher finally fixed the downloads
MultiMC doesn't intend to readd CF any time soon (https://github.com/MultiMC/Launcher/issues/4762#issuecomment-1152912827) though I don't really care for it anyway, haha
PolyMC, however, has decent CF support

Overall currently only one opted out mod is Entity Culling

Wanted to add that it's available on modrinth though, so it's not a big issue for most third party launchers

A month later, still only Entity Culling is opted out and no other timely issues exist anymore. Packwiz downloads it from Modrinth and GDLauncher downloads it via the embedded browser, so I'd say I can finally close this issue.


Document setting custom username with acct: u-url in representative h-card

Requested in #3, implemented in #27, @aciccarello nudged me today in https://chat.indieweb.org/dev/2022-11-10#t1668107750599800. Definitely deserves to be added to the docs!
(Fwiw, I checked the logs, looks like no one's used this feature in the last 2 months. Maybe they will if we document it!)

Merged into #295


Clean up access control capabilities APIs

Flesh out the capabilities API.
E.g. probably useful to be able to get number of entries of a given fabric, max possible entries for a given fabric, etc.
This may be affected generally by #14449

Also once this spec change lands, will need to expose some of this info in the cluster.
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5070

Regarding landed spec change
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5070
a cluster change has landed to expose those attributes, in PR #17294
However the assumption (fine for now) is that a particular implementation is used. When these capabilities APIs are available, that cluster attribute implementation needs to use those APIs.


ACCOUNT NOTIFICATIONS not saved on profile

on the user profile page, when I change notification options at the bottom and click save, they are not saved.

I believe this is a dupe of #1237

@dvoet a fix for #1237 was just released, are you able to reproduce this issue?


server/sandbox: fix path to pause rootfs

I flaky tested https://github.com/kubernetes-incubator/ocid/pull/45 (I forgot I already had a rootfs there and it wasn't failing when I merged that PR).
After rm -rf /var/lib/ocid however I got an error in ocid when starting the pod sandbox container.
This fixed it, my bad.
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

@mrunalp PTAL

Hmm, let me test it out.

@runcom This doesn't work for me while master does :/ Could you retest?

@runcom This doesn't work for me while master does :/ Could you retest?

right, nevermind then, my setup was probably busted then - master works fine for me as well


[dart2js] Runtime error when calling null.runtimeType

Calling null.runtimeType produces a runtime error on dart2js
Deobfuscated error and stack:
TypeError: C.JSNull_methods.get$runtimeType is not a function

In Dart class Null has runtimeType getter

Can you give more details how to reproduce the error?
I see:
$ dart2js 42512.dart
Compiled 8,027,548 characters Dart to 95,425 characters JavaScript in 0.67 seconds
$ d8 out.js
Null
Null

42512.dart:
main() {
  print(null.runtimeType);
  print(null.runtimeType);
}

out.js:
    main: function() {
      P.print(C.JSNull_methods.get$runtimeType(null));
      P.print(C.JSNull_methods.get$runtimeType(null));
    }
...
  J.JSNull.prototype = {
    toString$0: function(receiver) {
      return "null";
    },
    get$runtimeType: function(receiver) {
      return C.Type_Null_Yyn;
    }
  };
...
    C.JSNull_methods = J.JSNull.prototype;
...
    C.Type_Null_Yyn = H.typeLiteral("Null");

@rakudrama here is the test that fails https://github.com/dart-lang/co19/blob/master/Language/Overview/runtime_type_t02.dart
Tryjob output can be found here

/=====================================================================================================================================\
| dart2js-hostasserts-strong-linux-x64-chrome:co19/Language/Overview/runtime_type_t02 is new and failed (RuntimeError, expected Pass) |
\=====================================================================================================================================/

--- Command "dart2js" (took 03.000456s):
DART_CONFIGURATION=ReleaseX64 sdk/bin/dart2js_developer --enable-experiment=non-nullable --enable-experiment=non-nullable --test-mode --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/co19/src/Language/Overview/runtime_type_t02.dart --sound-null-safety --libraries-spec=sdk/lib/libraries.json --platform-binaries=out/ReleaseX64/ --out=/b/s/w/ir/out/ReleaseX64/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js

exit code:
0

stdout:
Compiled 8,056,394 characters Dart to 94,129 characters JavaScript in 3.45 seconds
Dart file /b/s/w/ir/tests/co19/src/Language/Overview/runtime_type_t02.dart compiled to JavaScript: out/ReleaseX64/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js

--- Command "chrome" (took 125ms):
/b/s/w/ir/tools/sdks/dart-sdk/bin/dart pkg/test_runner/bin/launch_browser.dart chrome http://<IP_ADDRESS>:33907/root_build/generated_tests/dart2js-chrome/tests_co19_src_Language_Overview_runtime_type_t02/test.html?crossOriginPort=35341

Runtime error:
TypeError: C.JSNull_methods.get$runtimeType is not a function
TypeError: C.JSNull_methods.get$runtimeType is not a function
    at main (http://<IP_ADDRESS>:33907/root_build/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js:2204:24)
    at dartMainRunner (http://<IP_ADDRESS>:33907/root_dart/pkg/test_runner/lib/src/test_controller.js:315:5)
    at http://<IP_ADDRESS>:33907/root_build/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js:2538:7
    at http://<IP_ADDRESS>:33907/root_build/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js:2524:7
    at dartProgram (http://<IP_ADDRESS>:33907/root_build/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js:2535:5)
    at http://<IP_ADDRESS>:33907/root_build/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js:2542:3

Deobfuscated error and stack:
TypeError: C.JSNull_methods.get$runtimeType is not a function
TypeError: C.JSNull_methods.get$runtimeType is not a function
    at main           ../../../../../tests/co19/src/Language/Overview/runtime_type_t02.dart 18:24
    at dartMainRunner pkg/test_runner/lib/src/test_controller.js 315:5
    at <fn>           out/ReleaseX64/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js 2538:7
    at <fn>           out/ReleaseX64/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js 2524:7
    at dartProgram    out/ReleaseX64/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js 2535:5
    at <fn>           out/ReleaseX64/generated_compilations/dart2js/tests_co19_src_Language_Overview_runtime_type_t02/runtime_type_t02.js 2542:3

exit code:
0

--- To debug locally, run:
/b/s/w/ir/tools/sdks/dart-sdk/bin/dart /b/s/w/ir/pkg/test_runner/bin/http_server.dart -p 33907 -c 35341 --network <IP_ADDRESS> --build-directory=/b/s/w/ir/out/ReleaseX64/ --runtime=chrome --packages=/b/s/w/ir/.packages

--- Re-run this test:
python tools/test.py -n dart2js-hostasserts-strong-linux-x64-chrome --dart2js-batch co19/Language/Overview/runtime_type_t02

Possibly related to #42219?

The test now passes.


objective function

Hi  Florian Hase,
I have read this paper.  You have been mention many objective function in the Supplementary Information, such as Dejong, Camel, Branin.  I could not find objective function in the code.
Could you tell me how can I find it. Many thanks!!
Best wishes

Hi @Yuanpengli,
thank you for your message. Indeed, some of the benchmark functions which are reported in the paper have not made it to the repository, for which I would like to apologize. I just uploaded python implementations of all 15 benchmark functions. You can find them in benchmark_functions.py in examples. Please let me know if this answers your question, and if the file lists all the functions you were looking for.


[BUG]: [Print Case is not Working]

Describe the bug
Print Case is not Working
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi @maruthiPhanendra , issue is resolved please find the reference
https://jam.dev/c/fb4b8cba-dfcc-4198-80ad-b23885cdc62f

Tested in UAT Env, working as expected.
Attaching jam video for reference: https://jam.dev/c/b995c7b6-9f2a-4e36-abfc-41f05e30bcf3


zIndex of overlapping nodes

Is it possible to adjust the zindex of overlapped nodes?

Unfortunately no, but you're not the first one to request this. Feel free to like or even join the discussion at #635.


Add the RNG Seeds

Actually maybe these should be set in a configuration file somewhere? @briandersn @guschmue

Its being parsed so we could:
https://github.com/mlperf/inference/blob/master/loadgen/test_settings_internal.cc#L440

I think I create a PR for the config parser to allow wildcards for the scenario (we only allow wildcards for the model today) so the config file needs only 4 lines. Very small change.
We need that anyway for the # of content items for perf mode (fyi @psyhtest ).
Should be getting to this over the weekend.
If we allow this for 0.5 is a different issue.

Its being parsed

I'll check that it parses hexadecimal constants...

to allow wildcards for the scenario (we only allow wildcards for the model today) so the config file needs only 4 lines.

You mean 3 lines (once for each variable in @tjablin's PR)?

Converting to decimal:
$ printf "qsl_rng_seed==0x%x==%llu\n"<PHONE_NUMBER>612453542 0x2b7e151628aed2a6
qsl_rng_seed==0x2b7e151628aed2a6==3133965575612453542

$ printf "sample_index_rng_seed==0x%x==%llu\n"<PHONE_NUMBER>3807303 0x093c467e37db0c7
sample_index_rng_seed==0x93c467e37db0c7==41592772053807303

$ printf "schedule_rng_seed==0x%x==%llu\n"<PHONE_NUMBER>038561421 0x3243f6a8885a308d
schedule_rng_seed==0x3243f6a8885a308d==3622009729038561421

OK, this:
--- a/program/image-classification-tflite-loadgen/user.conf
+++ b/program/image-classification-tflite-loadgen/user.conf
@@ -3,6 +3,9 @@
 # Model maybe '*' as wildcard. In that case the value applies to all models.
 # All times are in milli seconds

+*.SingleStream.qsl_rng_seed =<PHONE_NUMBER>612453542
+*.SingleStream.sample_index_rng_seed =<PHONE_NUMBER>3807303
+*.SingleStream.schedule_rng_seed =<PHONE_NUMBER>038561421
 *.SingleStream.target_latency = 10
 *.SingleStream.target_latency_percentile = 90
 *.SingleStream.min_duration = 60000
@@ -13,6 +16,9 @@ ssd-mobilenet.SingleStream.performance_sample_count_override = 256
 ssd-resnet34.SingleStream.performance_sample_count_override = 64
 gnmt.SingleStream.performance_sample_count_override = 3903900

+*.MultiStream.qsl_rng_seed =<PHONE_NUMBER>612453542
+*.MultiStream.sample_index_rng_seed =<PHONE_NUMBER>3807303
+*.MultiStream.schedule_rng_seed =<PHONE_NUMBER>038561421
 *.MultiStream.target_qps = 20
 *.MultiStream.target_latency_percentile = 99
 *.MultiStream.samples_per_query = 4
@@ -32,6 +38,9 @@ ssd-mobilenet.MultiStream.performance_sample_count_override = 256
 ssd-resnet34.MultiStream.performance_sample_count_override = 64
 gnmt.MultiStream.performance_sample_count_override = 3903900

+*.Server.qsl_rng_seed =<PHONE_NUMBER>612453542
+*.Server.sample_index_rng_seed =<PHONE_NUMBER>3807303
+*.Server.schedule_rng_seed =<PHONE_NUMBER>038561421
 *.Server.target_qps = 1.0
 *.Server.target_latency = 10
 *.Server.target_latency_percentile = 99
@@ -49,6 +58,9 @@ ssd-mobilenet.Server.performance_sample_count_override = 256
 ssd-resnet34.Server.performance_sample_count_override = 64
 gnmt.Server.performance_sample_count_override = 3903900

+*.Offline.qsl_rng_seed =<PHONE_NUMBER>612453542
+*.Offline.sample_index_rng_seed =<PHONE_NUMBER>3807303
+*.Offline.schedule_rng_seed =<PHONE_NUMBER>038561421
 *.Offline.target_qps = 1.0
 *.Offline.target_latency_percentile = 90
 *.Offline.min_duration = 60000

seems to work:
$ grep rng_seed output/tf-cpu/mobilenet/mlperf_log_detail.txt
"pid": 26017, "tid": 26017, "ts": 15333ns : qsl_rng_seed :<PHONE_NUMBER>612453542
"pid": 26017, "tid": 26017, "ts": 15333ns : sample_index_rng_seed :<PHONE_NUMBER>3807303
"pid": 26017, "tid": 26017, "ts": 15333ns : schedule_rng_seed :<PHONE_NUMBER>038561421
"pid": 26017, "tid": 26017, "ts": 15333ns : accuracy_log_rng_seed : 0
"pid": 26017, "tid": 26017, "ts": 15920ns : qsl_rng_seed :<PHONE_NUMBER>612453542
"pid": 26017, "tid": 26017, "ts": 15920ns : sample_index_rng_seed :<PHONE_NUMBER>3807303
"pid": 26017, "tid": 26017, "ts": 15920ns : schedule_rng_seed :<PHONE_NUMBER>038561421
"pid": 26017, "tid": 26017, "ts": 15920ns : accuracy_log_rng_seed : 0

(each modified seed appears once for Requested Settings and once for Effective Settings).

cool, @tjablin want this in mlperf.conf ?

Yes, these should go in mlperf.conf

Spoke too soon: the seeds do not appear to be set correctly on a 32-bit system.

Well caught! Unfortunately, it's just the one I need, so I need to re-run all performance experiments (again).


feat(rendering): Expose createElement

This PR exposes createElement and Fragment from Preact.
Summary
We want to remove the complexity of using JSX for our users using plain Javascript. In order to do that in a unify way accross our librairies, we are doing a similar work to the one done on Autocomplete.js.
This PR will be followed by another one that we allow HTML templating.

@SophieManley03 For the two suggestions I made you'll need to add imports from Renderer (that's why the type checking is failing). Unfortunately GitHub wouldn't let me suggest at the top of the file 😔

Thank you Sarah, just did 👌


Add static grid gutters #8508

Add static (unresponsive) grid gutters
See: https://github.com/zurb/foundation-sites/issues/8508
Use: .gutter-{size} class on a row
Example:

...

...

  ...

Standardize grid gutters functions, mixins and arguments.
Adds/Removes:

Add @function grid-column-gutter( {breakpoint} ): Get a gutter size for a given breakpoint.
Add @mixin grid-column-size( {px or breakpoint} ): Set the gutters on a column.
Depreciate @mixin grid-column-uncollapse. Use grid-column-gutter instead.
Use these new features in all (flex-)grid mixin & functions. Use @function grid-column-gutter instead of modifying $grid-column-gutter to support its possible single value.

Other changes:

Argument naming: use $gutter for a single size, and $gutters for a size map.
Fix $gutter (now $gutters) argument descriptions.

Required for the previous feature.
Anyway, all the "groups of properties" of a component (i.e. size, align, color, or specific behavior like collapse, expand...) should have their own @mixin, to allow a component customization in responsive/semantic cases

@ncoden I like the direction this is going. You should be aware though that $grid-column-gutter currently supports setting it to a single (scalar) value as well as the responsive approach... I think this would break in that case.  Probably in that situation these should just degenerate to the same gutter, yes?

@kball Ah, right! This'll need to account for if you're not using responsive gutters (e.g. $grid-column-gutter is a single value).

:+1: hum. Actually, if $grid-column-gutter is a single value, it is transformed to a (small: $value) map.
So it would generate a useless .gutter-small class.

It's dirty because we're assuming there is always a smallest breakpoint called "small".
So I purpose to not modify $grid-column-gutter, and create:
@function grid-column-gutter( $breakpoint )

that return the gutter if it is a single value, or the gutter for a given breakpoint if it is a map.

You can use nth(map-keys($breakpoints),1) to get the smallest (zero) "breakpoint."

You can use nth(map-keys($breakpoints),1) to get the smallest (zero) "breakpoint."
Can there be no breakpoint ? Does the "zero breakpoint" always exists and be zero ?

I also see a problem with grid-column-uncollapse:
@mixin grid-column-uncollapse($gutter: $grid-column-gutter) { ... }

$grid-column-gutter is always a map, and is used as padding. We must remove this bugged default value`
So $grid-column-uncollapse is an alias of $grid-column-gutter
And $grid-column-collapse is an alias of $grid-column-gutter(0)
So it would be better to only have:

@include grid-column-gutter( {size_in_px} );
@include grid-column-gutter( {breakpoint} ); // "small", "medium"...

And maybe
@include grid-column-gutter( collapse ); // alias for 0

CSS classes keep unchanged

@ncoden Yeah. A zero breakpoint is required as the first key/value of the $breakpoints map.
But the error is misleading.
This:
@error 'Your smallest breakpoint (defined in $breakpoints) must be set to "0".';

Should probably be:
@error 'The first key in the $breakpoints map must have a value of "0".';

And a note should also be added to the docs page.

BTW, since #8318 is merged you can use $-zf-zero-breakpoint to get the smallest breakpoint.

@andycochran @DaSchTour @kball Ok, I will add theses changes.

I done these changes, and standardize/factorized all the gutter functions/mixins/uses. See all the changes in this PR description.
I have two questions:

Should I update the documentation ? (docs/pages/grid.md)
Should I keep @mixin grid-column-uncollapse deleted, or would it be better to depreciate it (redirection to @mixin grid-column-size and throw a warning) ?

@ncoden I prefer depreciations than outright deletions, so that sounds like a good step.  Updating the documentation would be great.  @andycochran can you try this out and see if the code changes are good to merge?

@ncoden looks like this branch has gotten stale and needs some conflicts resolved before it can be merged.  @andycochran can you give this trial run?

Ah sorry, i forgot this PR ;)
I rebase it...

@kball @andycochran  It's rebased (and fixed). :)

@andycochran @brettsmason @JeremyEnglert as our scss expert yetinauts, does this seem ready to you?


Error during build "Could not find android.jar for API level"

When building, typically for the first time, you may get the following:
Xamarin.Android.Tooling.targets(100, 5): [XA5207] Could not find android.jar for API level 33. This means the Android SDK platform for API level 33 is not installed. Either install it in the Android SDK Manager (Tools > Android > Android SDK Manager...), or change the Xamarin.Android project to target an API version that is installed. (C:\Users\natha\AppData\Local\Android\Sdk\platforms\android-33\android.jar missing.)
This indicates that the compiler is attempting to target a version of the Android SDK/API that does not exist.

The version required by the compiler must be installed.
This can be achieved by going itno Tools > Android > SDK Components and selecting the required version number. In the screenshot, this is v33, as reported in the error:

Click Save to commence the download.


Change teams?

Raising a discussion about the team sizes.
Currently its:

<100kb - Green
<250kb - Orange
<512kb - Blue

Wondering if it's worth changing it to:

<128kb - Green
<256kb - Orange
<512kb - Blue

@kmutahar @lrmikestone thoughts?

I think it's a valid change. It has minimal impact as there's only 10 sites currently in Orange that would move to Green, and only a single site in Blue that would move to Orange as a result. The new values satisfy my nerd side, but it's worth saying that even though 512kb.club is about sites that maintain a small footprint, it's not necessarily about nerdy things. Non-nerds might find the original values more appropriate, but I don't know if they're represented in numbers high enough for it to matter.

I really like the idea even if people are non-technical it all divisible by 2 so its really nice
On another note, I have been looking at a way (Still testing) on having just one file and using if conditions to have it sort. what do you think.
Also as I have just push away for Jekyll to sort the list should we change the file to be in alphabetical order. I belive this would make it easer for future maintenance

I'm not against moving to one file. Not sure how easy that would be with all three being separate billeted lists, all with a different CSS class for the colours.
If you can work out a way of doing it though, it would certainly be easier.
I think alphabetical works.
Will let you finish the bits you're doing, then we can flip it to the new sizes then. 👍

Sounds great, the only problem is GTmetric and their limits, if only there was a CLI that can provide the size

Yeah, I'm not sure if one of the other tools provides an API to do this kinda thing. I imagine there would be a charge for it though.
Doing a valid response check would also be cool, so we can remove and sites that are down. Once to explore, I think.

This could work for the check...
https://www.darklaunch.com/count-size-of-page-in-bytes-using-curl.html

Sorry for bumping in here but it's an interesting discussion as I saw your curl idea ( and as I was also confused of which uncompressed value you where after when I submitted my site recently ).
I was under the impression that we're after the overall size of a page (including assets etc) not just the /.
As an example the curl you mentioned would work correctly:
This would return 22.904kb .
curl --silent "https://xkon.dev" | wc --bytes | awk '{ byte =$1 /1000; print byte " kb" }'
But it only takes under account the returned html essentially not "everything" that the page would load.
According to GTMetrix (setting as an example my page as well) while / is actually ~22.4kb uncompressed the overall page (due to some images) is 60.8kb, which was the value that I submitted.
So I'm confused now of what the Club  is after in reality and if it needs to be more clear on the instruction of submitting a site.
The instructions refer to "Get the UNCOMPRESSED size of your website's homepage", homepage can mean with every asset included as well or just the / which is a totally different number :) .

@mrxkon please don't be sorry, the conversation is good. What we ask for is the complete webpage size, so all assets. I hadn't tested the curl command yet, so wasn't sure if it would work. Clearly it wouldn't.  So thanks for testing that for us. 😊
I think we do need a method of regularly testing if a site is a) up and b) the size. I just don't know how best to do that yet.

I have a question about the current size and the teams for #390
Green
>= 0 and <= 100
Orange
> 100 and  <= 250
Blue
> 250 and <= 512

or should it be
Green
>= 0 and < 100
Orange
>= 100 and  < 250
Blue
>= 250 and <= 512

it's the sites that are on the border where should they be located?

I think it should be (and this is just my thought) is it's exactly 100kb, then it's green team. If it's 100.1, then it's orange.

If you let me chime in, as a person whose website is just a bit under 100kb and is planning only to grow (since it's a one long list of all my 132 blog posts), I'm all in favour of increasing the limit to get into the green team :)
On a serious note, regarding periodically checking sizes of all sites: have you considered using webdriver?
In my testing I noticed that numbers shown on gtmetrix.com (total size of all requests) matches what I see in Chrome DevTools (and, indeed, they say they use Chrome).
It looks like it might be possible to drive Chrome using WebDriver and monitor data received over the network:
https://chromedevtools.github.io/devtools-protocol/1-2/Network/#event-dataReceived
Does anyone see why it might be a bad idea to have a local instance of Chrome slowly crawling list of all websites, recording their sizes? If none else wants, I can try to make such script in my spare time.

@Lex-2008 we haven't found anything that's accurate like GTmetrix. I will check out Webdrive.
If you do have an idea how it can be implemented let us know. It would be nice to have a script that one can use every once in a while to test the sites.

+1 to @kmutahar comment above. A script would be really nice!

Based on a gist by @rengler33, here's a script which does that:
page_size.py.gz
It requires Chrome, chromedriver in your path, and python selenium installed either via pip or your OS package manager.
You can start it from command-line an pass it URLs as arguments, like this:
$ python page_size.py https://512kb.club/ http://alexey.shpakovsky.ru https://www.yeetpc.com/

It will open the browser, load each page into it, and print back size of each page, like this:
$ python page_size.py https://512kb.club/ http://alexey.shpakovsky.ru https://www.yeetpc.com/
https://512kb.club/: 69736 bytes = 68.1 kb
http://alexey.shpakovsky.ru: 90267 bytes = 88.2 kb
https://www.yeetpc.com/: 530334 bytes = 517.9 kb

What do you think about it? Numbers look pretty close to those reported by GTmetrix. I'm planning to expand it to read list of sites from the _data/sites.yml file and save new numbers into it.

Updated version of the script above:
script.py.gz
To update sites.yml file while keeping its format it now also uses "ruamel.yaml" Python library available via pip or a package manager of choice.
It reads a range of sites from sites.yml file, loads each of them updating the sites.yml file, printing old and new size, and "notable changes" section at the end when a page size changed by 10% or more, site "team" changed, or site grew too big to be included to 512kb.club, like this:
_data$ time python script.py sites.yml 60-70
cyberarm.dev: 10.7kb to 11.4kb
cycloneblaze.net: 41.9kb to 43.9kb
dafne.cc: 16.5kb to 17.8kb
danielcuttridge.com: 26.1kb to 20.5kb
dariusz.wieckiewicz.org: 257.5kb to 502.1kb
davidrutland.com: 164.0kb to 167.3kb
decentnet.github.io: 31.2kb
degruchy.org: 3.2kb to 1147.1kb
dejalavidavolar.org: 96.1kb to 119.4kb
dev-nonsense.com: 5.5kb

*** NOTABLE CHANGES ***:

danielcuttridge.com: big size change: from 26.1kb to 20.5kb, recheck: <https://gtmetrix.com/?url=https://danielcuttridge.com/>
dariusz.wieckiewicz.org: big size change: from 257.5kb to 502.1kb, recheck: <https://gtmetrix.com/?url=https://dariusz.wieckiewicz.org/>
degruchy.org: site is too big for 512kb.club: 1147.1kb, recheck: <https://gtmetrix.com/?url=https://degruchy.org/>
dejalavidavolar.org: team changed: from green to orange (119.4kb), recheck: <https://gtmetrix.com/?url=https://dejalavidavolar.org/>

real    0m49.205s
user    0m11.359s
sys     0m3.661s

As you see, on average it takes about 5 seconds to get a size of one site, so about half an hour to process all 300 links in sites.yml file (not counting time of manually checking results and contacting site owners)
I'm trying to make numbers produced by this script to be as close as possible to what GTmetrix shows, and so far faced two issues:

blog.larsgerber.ch uses "Roboto Mono" font, which is installed on GTmetrix machines (so they don't download it), but not on mine; and even after I install it, Chrome says it's available but still downloads it anew, thus inflating pagesize number.
canistop.net has a "link rel="preload" tag for metadata.json, and later does "fetch" this file with javascript. And for some reason, on my machine Chrome downloads this file twice, while on GTmetrix they download it only once - thus, again, different pagesize number.

Any thoughts, opinions about this? I think we can either just exclude such problematic sites from this script, or give them some "discount" when size is calculated by this script, in order to match the GTmetrix value.
Also, it looks like GTmetrix has a free API for 16 sites a day, so it's possible to make a different script which will update sites.yml file in batches of 16 sites a day :)
What do you think?


Workflow too large to offload

Summary
When running large workflows via the http rest api or the CLI, I have been unable to submit jobs with the following error
ERRO[0170] Create request is failed. Error: Request entity too large: limit is 3145728
ERRO[0170] finished unary call with code Unknown         error="Request entity too large: limit is 3145728" grpc.code=Unknown grpc.method=CreateWorkflow grpc.service=workflow.WorkflowService grpc.start_time="2020-09-17T12:27:16-07:00" grpc.time_ms=63461.7 span.kind=server system=grpc

I have also received this error
ERRO[1991] Create request is failed. Error: etcdserver: request is too large
ERRO[1991] finished unary call with code Unknown         error="etcdserver: request is too large" grpc.code=Unknown grpc.method=CreateWorkflow grpc.service=workflow.WorkflowService grpc.start_time="2020-09-17T16:59:42-07:00" grpc.time_ms=16243.304 span.kind=server system=grpc

An large example workflow that causes this error is attached
test_workflow.yaml.zip
Based upon this link: https://argoproj.github.io/argo/offloading-large-workflows/, I set  nodeStatusOffLoad: true within my config map.
A few questions:

Are we able to use the nodeStatusOffLoad feature via the rest api?
Is there a way we can package the example workflow more efficiently?
Thanks for the help!

Diagnostics
What version of Argo Workflows are you running?
bash-3.2$ argo version
argo: latest+ed79a54.dirty
  BuildDate: 2020-09-14T17:46:17Z
  GitCommit: ed79a5401162db7a3060111aff1b0fae5e8c2117
  GitTreeState: dirty
  GitTag: v2.10.2
  GoVersion: go1.15.2
  Compiler: gc
  Platform: darwin/amd64

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Node offload status is not an API feature. Instead it is a configuration item that requires SQL database to connect to.
As we have had very few issues with this feature, I suspect this is set-up related.
Can you please check the workflow controller logs for errors?

Submission of large workflows should be done using env ARGO_SERVER=your-server argo submit

Workflow Controller Logs and Argo Server Logs copied below. It seems that after the workflow is rejected from Argo-server, nothing is logged in the workflow controller.
bash-3.2$ tail argo_server.logs
time="2020-09-18T16:15:32Z" level=info msg="Alloc=7795 TotalAlloc=1185383 Sys=70592 NumGC=399 Goroutines=65"
time="2020-09-18T16:20:32Z" level=info msg="Alloc=9093 TotalAlloc=1192491 Sys=70592 NumGC=401 Goroutines=65"
time="2020-09-18T16:25:32Z" level=info msg="Alloc=7577 TotalAlloc=1199624 Sys=70592 NumGC=404 Goroutines=65"
time="2020-09-18T16:30:32Z" level=info msg="Alloc=8887 TotalAlloc=1206775 Sys=70592 NumGC=406 Goroutines=65"
time="2020-09-18T16:35:32Z" level=info msg="Alloc=7388 TotalAlloc=1213959 Sys=70592 NumGC=409 Goroutines=65"
time="2020-09-18T16:37:41Z" level=error msg="Create request is failed. Error: etcdserver: request is too large"
time="2020-09-18T16:37:41Z" level=error msg="finished unary call with code Unknown" error="etcdserver: request is too large" grpc.code=Unknown grpc.method=CreateWorkflow grpc.service=workflow.WorkflowService grpc.start_time="2020-09-18T16:37:26Z" grpc.time_ms=15324.664 span.kind=server system=grpc
time="2020-09-18T16:40:32Z" level=info msg="Alloc=10901 TotalAlloc=8336429 Sys=139682 NumGC=650 Goroutines=65"
time="2020-09-18T16:43:54Z" level=error msg="Create request is failed. Error: etcdserver: request is too large"
time="2020-09-18T16:43:54Z" level=error msg="finished unary call with code Unknown" error="etcdserver: request is too large" grpc.code=Unknown grpc.method=CreateWorkflow grpc.service=workflow.WorkflowService grpc.start_time="2020-09-18T16:43:39Z" grpc.time_ms=15027.986 span.kind=server system=grpc
bash-3.2$ tail workflow_controller.logs
time="2020-09-18T16:28:11Z" level=info msg="Zero old offloads, nothing to do"
time="2020-09-18T16:33:11Z" level=info msg="Alloc=85477 TotalAlloc=8687190 Sys=894974 NumGC=428 Goroutines=156"
time="2020-09-18T16:33:11Z" level=info msg="Performing periodic workflow GC"
time="2020-09-18T16:33:11Z" level=info msg="Zero old offloads, nothing to do"
time="2020-09-18T16:38:11Z" level=info msg="Alloc=691959 TotalAlloc=9469131 Sys=894974 NumGC=432 Goroutines=156"
time="2020-09-18T16:38:11Z" level=info msg="Performing periodic workflow GC"
time="2020-09-18T16:38:11Z" level=info msg="Zero old offloads, nothing to do"
time="2020-09-18T16:43:11Z" level=info msg="Alloc=85525 TotalAlloc=9469295 Sys=894974 NumGC=435 Goroutines=156"
time="2020-09-18T16:43:11Z" level=info msg="Performing periodic workflow GC"
time="2020-09-18T16:43:11Z" level=info msg="Zero old offloads, nothing to do"

My current setup uses the Argo installation from the setup-guide with a built in postgres database: https://raw.githubusercontent.com/argoproj/argo/stable/manifests/quick-start-postgres.yaml. To automate my workflows, I have a separate service that calls the argo-server api endpoint to automate job-submission.
So if I understand correctly, with this setup there is no option to use the node offload status since it is only available on the CLI?  Do you have a recommendation on how to workflow with large workflows (~10,000+ Nodes) via the API?
Thanks for the help!

Can we check the size of your workflow before it is submitted? Can you kubectl apply it?

One of the workflows I am running has a size YAML file size of 2.7MB.
I get the following error when submitting through kubectl
bash-3.2$ kubectl -n dev create -f workflow.yaml
Error from server: error when creating "workflow.yaml": etcdserver: request is too large

One of the workflows I am running has a size YAML file size of 2.7MB.

This is a fundamental limitation of etcd resource objects. The limit is 1MB. Unfortunately, your only recourse is to split your workflow into multiple workflows.

One of the workflows I am running has a size YAML file size of 2.7MB.

This is a fundamental limitation of etcd resource objects. The limit is 1MB. Unfortunately, your only recourse is to split your workflow into multiple workflows.

To split the workflow into multiple workflows, would something like this https://argoproj.github.io/argo/workflow-of-workflows/ work  (as was referenced in this other issue https://github.com/argoproj/argo/issues/3738)?
Is there any existing tooling that can take a large workflow and dynamically generate a workflow of workflows? Can this be built into Argo? I believe that would allow Argo to run arbitrarily large workflows?

To split the workflow into multiple workflows,

Correct.

Is there any existing tooling that can take a large workflow and dynamically generate a workflow of workflows

No, sorry.

#7121 is a feature request for supporting even larger Workflows and there is a suggestion for tooling to auto-split a large Workflow into multiple Workflows-of-Workflows


Color font support?

I use Crowbar a lot to debug FRB American Cursive+Print…
This image of the nonsense string "Ö́̆ḧ" helped me track down what I need to do about stroke numbers being sucked in by the gravity of bases and not adhering to that of marks:
Ö́̆ḧ

The answer is—more careful use of mark filtering sets, for the curious. Not what this issue is about for sure. :)

How would color glyphs interact with the colors that Crowbar sets?

Good question. I guess it'd need to use a semi-opaque bounding box.


Keywords

If these keywords are suitable, I would like to contribute to the project further.

👍

Seeing this branch is pretty out of date, please re-submit the PR when the changes are made. Thanks.


Provide a working end2end configuration

Hi,
I've been looking at this for a few hours and find the idea very interesting but I'm unable to figure out how to get and end2end flow working (at least with my use-case which is based on nginx).
Would you mind sharing your configuration, event traefik based, to ease re-use ?
Thank you :-)

I'll give it a try and add a docker-compose based example folder to project 👍

Sorry it took so much time, but I was able to come up with an example proposal: https://github.com/wasilak/elastauth/tree/example/example
There are surely some descriptions missing, but it is a start, I did not wanted to keep you waiting longer ;)


Icons not displaying

Is there a way to change the icons? Some aren't displaying because my main font is FiraCode NerdFont

already ok, please try again


Replace Ironic stub images with Ironic built from RDO

Currently ironic and baremetal-* images are not being synced into 4.x imagestream in origin - https://github.com/openshift/release/blob/master/core-services/release-controller/_releases/release-ocp-4.4-ci.json#L25-L32. These might have been built using OSP repos, so we can't use these in OKD.
Operators should use RDO repos to build openstack-related and promote these images to origin namespace (perhaps from metal3 builds?)
The following images need to be reviewed:

[x] baremetal-machine-controllers
https://github.com/openshift/cluster-api-provider-baremetal/blob/master/Dockerfile. @dhellmann @hardys
[x] baremetal-operator
https://github.com/openshift/baremetal-operator/blob/master/Dockerfile @honza @stbenjam
[ ] ironic
https://github.com/openshift/ironic-image/blob/master/Dockerfile.ocp @derekhiggins @dtantsur
Needs OKD promotion rule
[ ] ironic-inspector
https://github.com/openshift/ironic-inspector-image/blob/master/Dockerfile.ocp @elfosardo @stbenjam
[ ] ironic-ipa-downloader
https://github.com/openshift/ironic-ipa-downloader/blob/master/Dockerfile.ocp @derekhiggins @elfosardo
[x] ironic-machine-os-downloader
https://github.com/openshift/ironic-rhcos-downloader/blob/master/Dockerfile.ocp @hardys @elfosardo
[x] ironic-static-ip-manager
https://github.com/openshift/ironic-static-ip-manager/blob/master/Dockerfile.ocp @elfosardo @russellb
[ ] any other image built with OSP repos and synced to origin

Can we just use the metal3 upstream images? They rely on RDO already.

That would be perfect. Does our CI build those too?

That would be perfect. Does our CI build those too?
EDIT: I don't think it does, so ideally we'd use the same code as in OCP but built using a different openstack repo

The images in the https://quay.io/organization/metal3-io org are built by quay.io when changes merge into the GitHub repos under https://github.com/metal3-io/.
The quay version of the cluster-api-provider-baremetal image hasn't been rebuilt since March 23 because that component is now only used by OpenShift, so we use an internal build for that image.

The images in the quay.io/organization/metal3-io org are built by quay.io when changes merge into the GitHub repos under @metal3-io.

That's not suitable for OKD. Our release model is the same as OCP - image gets built on CI, but being promoted to origin namespace.
Could metal3.io folks help me with the following:

review dockerfiles from the description. If these are using RHOSP Ironic we should create Dockerfile.okd which uses Ironic RDO (same for any other non-community component there).
once all the repos have OKD-compatible dockerfile I can create PRs to release to build OKD images and promote them to origin namespace - I'm going to need /lgtm there

I found upstream counterparts inside metal3-io quay repository for most of these images, except :

baremetal-machine-controllers : the upstream repo it was forked from has been archived and a new upstream repo was created called cluster-api-provider-metal3
ironic-static-ip-manager has an upstream image but no upstream repo and hasn't been updated in a long time
ironic-machine-os-downloader

Is someone working on building RDO based images, maybe we can reuse the existing ones from metal3 and rebuild the rest.

Seems ironic-static-ip-manager and ironic-machine-os-downloader are not using RHOSP content, so we can start syncing them (although I'd like a confirmation from Metal3 folks anyway).

baremetal-machine-controllers : the upstream repo it was forked from has been archived and a new upstream repo was created called cluster-api-provider-metal3

The upstream version is not compatible with OpenShift because it uses a newer version of the Machine API than OpenShift does. I would expect the same to apply to OKD. The openshift/cluster-api-provider-baremetal repository holds the version of that controller used in OpenShift.

Seems ironic-static-ip-manager and ironic-machine-os-downloader are not using RHOSP content, so we can start syncing them (although I'd like a confirmation from Metal3 folks anyway).

That's correct, both of those images are just wrappers for scripts related to how we deploy ironic/metal3 in OpenShift, but with no dependency on RHOSP content.
Then we can work on adding the necesary Dockerfile.okd for remaining repos, which should be very similar to the upstream metal3-io Dockerfiles which consume RDO content.

I found upstream counterparts inside metal3-io quay repository for most of these images, except :
* ironic-static-ip-manager has an upstream image but no upstream repo and hasn't been updated in a long time

https://github.com/metal3-io/static-ip-manager-image is the upstream repo but as you say it hasn't been updated in some time, because the metal3 community have moved to a different model for IP management.
Probably for OKD we should just rebuild https://github.com/openshift/ironic-static-ip-manager and we can discuss upstream if it makes sense to retire the repo mentioned above.

* ironic-machine-os-downloader

This is a downstream-only image, since it's related to preparing the RHCOS/FCOS image for deployment in the OpenShift deployment of metal3
Upstream an image URL is just provided directly (we can't do this downstream because the OS images are gz/xz compressed, which Ironic doesn't yet handle ref https://storyboard.openstack.org/#!/story/2006936)

https://github.com/openshift/ironic-image/pull/123
https://github.com/openshift/ironic-ipa-downloader/pull/56

https://github.com/openshift/release/pull/16377 to sync baremetal-machine-controllers and baremetal-operator

https://github.com/openshift/release/pull/16379 to run OKD-specific build on Ironic image

/remove-lifecycle stale
/lifecycle frozen


[Addition] Guns in Minecraft

Checklist

[X] I've checked that my mod suggestion hasn't already been added to one of the lists.
[X] I've checked the latest issues to make sure that this mod hasn't already been suggested.

What is your mod's name?
Guns
What is your mod's main version?
1.8.X or earlier
What is your mod's other versions?
No response
What is your mod's type?
Preformance
What side dose your mod need to run on?

Some people may like guns in Minecraft
(OPTIONAL) Give some extra information about the mod.
No response

This issue is invalid, you have linked to a Mojang repo and not a mod. This type of mod is also not relevant to our list here at TUL

Oh, Okay.


Scoped CSS for Color highlighting

This pull request reference this #231. This is an improvement from #231 due to feedback given by @lb-

The changes made scopes the css additions.
Makes use of color variables from scss/_variable.css
Cleans up the css to look more better.
It should be noted the usage of dl.class > dt and dl.class :not(.field-list) >dt.  The first handles color highlighting for classes; the latter handles for methods. Check comments below for screenshots on this

You may need to have a bit of a read of the Sass language to help you get this one a bit closer to ready.
https://sass-lang.com/

Hi @lb- I didn't notice your comment earlier. But I followed the error from the failed CI tests. I have made the updates to correct the errors.

Oh, let me see to this

Actually, I made the changes, working with the Sphinx documentation. Perhaps, a video would help you understand what is going on here.

So the first >dt handles color highlighting for the classes. While the not field-list, handles for methods

ok sounds good - maybe update the description with a bit of context as to why you did this with some screenshots, it will help when reviewing.

Notice in the screenshot that the dl.class :not(.field-list) > dt only works for the methods

Notice dl.class > dt only works for the classes

Then, to confirm, I ticked out all the css that applies to the method.

On the need to add display: table,here is the class Page with display set to table.

Here is it without a table display

border-top applies to the classes; border-left applies to the methods. This is done in accordance to what is in the readthedocs theme

Yeah, I think you are right on the fact that the border-top doesn't show with the dark theme enabled. I think that because the border-top color is almost the same color and shade with the background when dark theme is enabled.

Hey @Temidayo32 just a heads up you may need to rebase this on main as we have made a few changes.
Let us know if you are still keen on pursuing this fix.

@Temidayo32  I will close this for now, feel free to re-open or raise a new PR on main if you are keen on doing this later.


Improve types

This removes the use of URL, meaning the dom lib isn't needed by downstream libraries.
(This is branched off #406)

:tada: This PR is included in version 4.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update build_ngx_pagespeed_from_source.html

Simplify a bit the manual compilation by avoiding temporary files and guessing some filenames.
Note: Currently it still contains a lot of legacy code. I suggest to have the build instruction under source control. This would not only be expected, it'd also avoid having this script remain backward compatible.
See also https://github.com/wernight/docker-alpine-nginx-pagespeed/issues/5

It's true that html/doc/ is under source control. I think I was looking at an older version. Maybe just have an INSTALL at the root pointing to html/doc/ directory (not the URL).
Supposing that the current html/doc/ only needs to be valid for the current commit, then why not remote a lot in html/doc/build_ngx_pagespeed_from_source.html?
Things that I'd remove: (see PR)


Add new team member as contributor

We now have @christiancasey officially as part of the project team. @Jomula, can you advise on getting him added to this repo? Thanks!

Invited him as admin!

Got the invite. I’m still getting setup here and I don’t have a computer in front of me right now, but I’ll put on my todo list to accept the invite as soon as I can. Thank you both for your help,ChristianAm 10.12.2024 um 08:48 schrieb Jonas Müller-Laackman @.***>:
Closed #567 as completed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


fix: update outdated links in openrpc schema and code

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[x] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
I've found some of the links in the code comments and openrpc schema not working, so I updated them to work with current
documentation.
What is the new behavior?

Links are working properly and referencing corresponding problematic.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

This change is

@dan-starkware is there anything from my side that needs to be done?

@dan-starkware @yair-starkware is there anything from my side that needs to be done?


Feature: Draggable edge

Feature request: https://github.com/wbkd/react-flow/issues/549
Description:
This feature allows users to press at either end of the edge and drag to the target node to update the connection of edge.
The developer could use onEdgeUpdate to handle this event.
I've made an example:
https://github.com/zcmgyu/react-flow/blob/bd63a0131ace6a626f0e88ba3e62ac677cd990ca/example/src/DraggableEdge/index.js

Hey @zcmgyu
thanks for your work here! I am waiting for the feedback from #543.

I started to work on this PR on the feat/dragedge branch.

When is it going to master?

I've reviewed your work in feat/dragedge. Need to pass onEdgeUpdate to EdgeComponent to it work as expected.
Hope you merge it asap.
// react-flow/src/container/EdgeRenderer/index.tsx

<EdgeComponent
      ...
      onEdgeUpdate={props.onEdgeUpdate}
    />

@moklick One more thing, after dragging the edge to the new position, all old props of the old edge were not passed to the new edge at all
// wrapEdge.tsx
        const onConnect = (connection: Connection) => {
          if (onEdgeUpdate) {
            const edgeElement: Edge = {
              ...props,
              id,
              source,
              target,
              sourceHandle: sourceHandleId,
              targetHandle: targetHandleId,
              type,
            };

            onEdgeUpdate(edgeElement, connection);
          }
        };

Hey @zcmgyu
we will continue here #726


Fix bits.h when compiled by MSVC after including  (#4836)

This is a cherry-pick of #4836 for release-6.17.0.
This fixes builds on 32-bit Windows in google3 after cl/291012718, which added #include <ciso646> to absl/base/options.h.
This has no effect on any Apple platform so it doesn't warrant a respin of any iOS release candidates.

Why the cherry-pick if it's not needed for release candidates?  Why isn't GHA green?

We copybara release branches into google3 and cherry-picking this ensures that we won't forget this change on our next copybara.

The xcodebuild targets are failing because of this:
[!] CocoaPods could not find compatible versions for pod "Firebase/CoreOnly":
  In Podfile:
    Firebase/CoreOnly (= 6.17.0)

... which doesn't make much sense because the Firebase pod on this branch clearly has that version. I'm investigating.

Approving, since the Podfile tests never have worked on the release branch prior to release.


Update Jastow and Undertow.js

Windows Build 3599 outcome was FAILURE using a merge of e89a23e8ae3b7ce0447e9aede144c28cd0d2f11c
Summary: Tests failed: 1 (1 new), passed: 3191, ignored: 370 Build time: 00:54:47
Failed tests
org.jboss.as.test.integration.domain.mixed.eap640.MixedDomain640TestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:442)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:244)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:105)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.start(MixedDomainTestSupport.java:76)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:78)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:57)
	at org.jboss.as.test.integration.domain.mixed.eap640.MixedDomain640TestSuite.initializeDomain(MixedDomain640TestSuite.java:44)
------- Stdout: -------
00:55:14,145 INFO  [org.jboss.modules] (main) JBoss Modules version 1.4.4.Final
00:55:14,321 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
[Host Controller] 00:55:14,764 INFO  [org.jboss.modules] (main) JBoss Modules version 1.4.4.Final
[Host Controller] 00:55:14,970 INFO  [org.jboss.msc] (main) JBoss MSC version 1.2.6.Final
[Host Controller] 00:55:15,023 INFO  [org.jboss.as] (MSC service thread 1-7) WFLYSRV0049: WildFly Full 10.0.0.CR4-SNAPSHOT (WildFly Core 2.0.0.CR7) starting
[Host Controller] 00:55:15,660 INFO  [org.xnio] (MSC service thread 1-5) XNIO version 3.3.2.Final
[Host Controller] 00:55:15,661 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1)
[Host Controller] 00:55:15,667 INFO  [org.xnio.nio] (MSC service thread 1-5) XNIO NIO Implementation Version 3.3.2.Final
[Host Controller] 00:55:15,704 INFO  [org.jboss.remoting] (MSC service thread 1-5) JBoss Remoting version 4.0.14.Final
[Host Controller] 00:55:15,726 INFO  [org.jboss.as.remoting] (MSC service thread 1-2) WFLYRMT0001: Listening on [::1]:9999
[Host Controller] 00:55:16,888 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://[::1]:9990/management
[Host Controller] 00:55:16,888 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0054: Admin console is not enabled
[Host Controller] 00:55:16,888 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 10.0.0.CR4-SNAPSHOT (WildFly Core 2.0.0.CR7) (Host Controller) started in 2461ms - Started 43 of 46 services (13 services are lazy, passive or on-demand)
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] HostController started in 3118 ms
[Host Controller] 00:55:18,064 WARN  [org.jboss.as.messaging] (management-handler-thread - 1) WFLYMSG0071: There is no resource matching the expiry-address jms.queue.ExpiryQueue for the address-settings #, expired messages from destinations matching this address-setting will be lost!
[Host Controller] 00:55:18,064 WARN  [org.jboss.as.messaging] (management-handler-thread - 1) WFLYMSG0072: There is no resource matching the dead-letter-address jms.queue.DLQ for the address-settings #, undelivered messages from destinations matching this address-setting will be lost!
[Host Controller] 00:55:18,792 INFO  [org.jboss.as.controller.management-deprecated] (management-handler-thread - 1) WFLYCTL0028: Attribute 'default-stack' in the resource at address '/' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
[Host Controller] 00:55:19,187 INFO  [org.jboss.as.controller.management-deprecated] (management-handler-thread - 2) WFLYCTL0028: Attribute 'stack' in the resource at address '/' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
[Host Controller] 00:55:19,260 INFO  [org.jboss.as] (MSC service thread 1-6) WFLYSRV0050: WildFly Full 10.0.0.CR4-SNAPSHOT (WildFly Core 2.0.0.CR7) stopped in 17ms
[Host Controller] 00:55:19,261 INFO  [org.jboss.as] (MSC service thread 1-6) WFLYSRV0049: WildFly Full 10.0.0.CR4-SNAPSHOT (WildFly Core 2.0.0.CR7) starting
[Host Controller] 00:55:19,277 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1)
[Host Controller] 00:55:19,304 INFO  [org.jboss.as.remoting] (MSC service thread 1-7) WFLYRMT0001: Listening on [::1]:9999
[Host Controller] 00:55:19,388 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'default-stack' in the resource at address '/profile=full-ha/subsystem=jgroups' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
[Host Controller] 00:55:19,487 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0023: Starting server server-one
00:55:19,497 INFO  [org.jboss.as.process.Server:server-one.status] (ProcessController-threads - 3) WFLYPC0018: Starting process 'Server:server-one'
[Server:server-one] 00:55:19,981 INFO  [org.jboss.modules] (main) JBoss Modules version 1.4.4.Final
[Server:server-one] 00:55:20,207 INFO  [org.jboss.msc] (main) JBoss MSC version 1.2.6.Final
[Server:server-one] 00:55:20,342 INFO  [org.jboss.as] (MSC service thread 1-6) WFLYSRV0049: WildFly Full 10.0.0.CR4-SNAPSHOT (WildFly Core 2.0.0.CR7) starting
[Server:server-one] 00:55:20,455 INFO  [org.xnio] (MSC service thread 1-3) XNIO version 3.3.2.Final
[Server:server-one] 00:55:20,463 INFO  [org.xnio.nio] (MSC service thread 1-3) XNIO NIO Implementation Version 3.3.2.Final
[Server:server-one] 00:55:20,497 INFO  [org.jboss.remoting] (MSC service thread 1-3) JBoss Remoting version 4.0.14.Final
[Host Controller] 00:55:21,053 INFO  [org.jboss.as.host.controller] (Remoting "master:MANAGEMENT" task-12) WFLYHC0021: Server [Server:server-one] connected using connection [Channel ID 0c423c22 (inbound) of Remoting connection 01e74720 to /0:0:0:0:0:0:0:1:50990]
[Host Controller] 00:55:21,066 ERROR [org.jboss.as.controller.management-operation] (server-registration-threads - 1) WFLYCTL0013: Operation ("describe") failed - address: ([
[Host Controller]     ("profile" => "full-ha"),
[Host Controller]     ("subsystem" => "web")
[Host Controller] ]) - failure description: "WFLYCTL0309: Legacy extension 'org.jboss.as.web' is not supported on servers running this version. The extension is only supported for use by hosts running a previous release in a mixed-version managed domain"
[Host Controller] 00:55:21,067 ERROR [org.jboss.as.controller.management-operation] (server-registration-threads - 1) WFLYCTL0013: Operation ("register-server") failed - address: ([]): java.lang.RuntimeException: WFLYHC0056: Failed to retrieve profile operations from domain controller
[Host Controller] 	at org.jboss.as.host.controller.DomainModelControllerService.getProfileOperations(DomainModelControllerService.java:448)
[Host Controller] 	at org.jboss.as.host.controller.ManagedServerOperationsFactory.addSubsystems(ManagedServerOperationsFactory.java:729)
[Host Controller] 	at org.jboss.as.host.controller.ManagedServerOperationsFactory.getBootUpdates(ManagedServerOperationsFactory.java:244)
[Host Controller] 	at org.jboss.as.host.controller.ManagedServerOperationsFactory.createBootUpdates(ManagedServerOperationsFactory.java:175)
[Host Controller] 	at org.jboss.as.host.controller.mgmt.ServerToHostProtocolHandler$ServerRegistrationStepHandler.execute(ServerToHostProtocolHandler.java:221)

retest this please