npm run build is failing "This is most likely a problem with the readium-js-viewer package"

I am trying to follow the steps in the documentation to get readium-js-viewer
When calling
npm run build
I am gettint the following
`<EMAIL_ADDRESS>prebuild C:\Users\nwf\readium-js-viewer

npm run clean

<EMAIL_ADDRESS>clean C:\Users\nwf\readium-js-viewer
node --version && npm --version && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/rimraf/bin.js build-output && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/rimraf/bin.js "api-docs/*" && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/rimraf/bin.js dist

v4.4.3
2.15.1

<EMAIL_ADDRESS>build C:\Users\nwf\readium-js-viewer
npm run build:scripts

<EMAIL_ADDRESS>prebuild:scripts C:\Users\nwf\readium-js-viewer
npm run genPluginsConfig

<EMAIL_ADDRESS>genPluginsConfig C:\Users\nwf\readium-js-viewer
cd readium-js/readium-shared-js/ && node readium-cfi-js/readium-build-tools/pluginsConfigMaker.js && cd ../..

========>
========> Plugins bootstrap ...
========>
process.env.npm_package_config_RJS_PLUGINS_OVERRIDE:
undefined
process.env[RJS_PLUGINS_OVERRIDE]:
undefined
Default plugins:  []
No plugin entries to override.
Plugins to load:  []
Generated plugin config files:
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\RequireJS_config_plugins.js
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\RequireJS_config_plugins_multiple-bundles.js
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\RequireJS_config_plugins_single-bundle.js
========> End of plugins bootstrap.

<EMAIL_ADDRESS>build:scripts C:\Users\nwf\readium-js-viewer
npm run versioning && npm run build:scripts:multiple && npm run build:scripts:single && npm run build:scripts:single:LITE && npm run build:scripts:single:CHROMEAPP --readium-js-viewer:RJS_UGLY=no && npm run build:scripts:single:CHROMEAPPWORKER --readium-js-viewer:RJS_UGLY=no

<EMAIL_ADDRESS>preversioning C:\Users\nwf\readium-js-viewer
node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd.js build-output

<EMAIL_ADDRESS>versioning C:\Users\nwf\readium-js-viewer
node build-config/versioning.js build-output/version.json

versionsMaker.js arguments:
[ 'build-output/version.json' ]
C:\Users\nwf\readium-js-viewer

Versioning: C:\Users\nwf\readium-js-viewer
Version: 0.22.3
Chrome version: 2.22.3
SHA: c733337e43467e0b7713f66ab4ff64726e1f0ae4
Clean: true
Tag: 0.22.3-1-gc733337
Branch: master

Versioning: C:\Users\nwf\readium-js-viewer\readium-js
Version: 0.22.3
SHA: 0ca9cd93d6b6c8b4fee010d3b671516f88a014ce
Clean: true
Tag: 0.22.3-0-g0ca9cd9
fs.js:549
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^

Error: ENOENT: no such file or directory, open 'C:\Users\nwf\readium-js-viewer\readium-js\C:\Users\nwf\readium-js-viewer.git\modules\readium-js\HEAD'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at eval (eval at  (C:\Users\nwf\readium-js-viewer\build-config\versioning.js:24:45), :157:58)
at ChildProcess.exithandler (child_process.js:204:7)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at maybeClose (internal/child_process.js:827:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "versioning"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>versioning: node build-config/versioning.js build-output/version.json
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>versioning script 'node build-config/versioning.js build-output/version.json'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build-config/versioning.js build-output/version.json
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR!  Exit status 1
npm ERR!
npm ERR!  This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR!  You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "build"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: npm run build:scripts
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'npm run build:scripts'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build:scripts
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
`

Could you please try to run the command 'git checkout develop' in every repository (assuming you initialized the submodules as per the README.md instructions), then 'npm run prepare' in the top-level folder (readium-js-viewer), then 'npm run dist+sourcemap'.
Let me know how it goes. Thanks!

Plugins to load:  [ 'highlights' ]
Generated plugin config files:
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\RequireJS_config_plugins.js
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\RequireJS_config_plugins_multiple-bundles.js
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\RequireJS_config_plugins_single-bundle.js
========> End of plugins bootstrap.

<EMAIL_ADDRESS>build:scripts C:\Users\nwf\readium-js-viewer
npm run versioning && npm run build:scripts:multiple && npm run build:scripts:single && npm run build:scripts:single:LITE && npm run build:scripts:single:CHROMEAPP --readium-js-viewer:RJS_UGLY=no && npm run build:scripts:single:CHROMEAPPWORKER --readium-js-viewer:RJS_UGLY=no

<EMAIL_ADDRESS>preversioning C:\Users\nwf\readium-js-viewer
node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd.js build-output

<EMAIL_ADDRESS>versioning C:\Users\nwf\readium-js-viewer
node build-config/versioning.js build-output/version.json

versionsMaker.js arguments:
[ 'build-output/version.json' ]
C:\Users\nwf\readium-js-viewer

Versioning: C:\Users\nwf\readium-js-viewer
Version: 0.23.0-alpha
Chrome version: 2.23.0-alpha
SHA: b55246040dc3ecaa9a8aa374e08fcae29a00f471
Clean: true
Tag: 0.23.0-alpha-0-gb552460
Branch: develop

Versioning: C:\Users\nwf\readium-js-viewer\readium-js
Version: 0.23.0-alpha
SHA: 665bdf0d90d5e0ae209b81eaa264293056cbf028
Clean: true
Tag: 0.22.3-79-g665bdf0
fs.js:549
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^

Error: ENOENT: no such file or directory, open 'C:\Users\nwf\readium-js-viewer\readium-js\C:\Users\nwf\readium-js-viewer.git\modules\readium-js\HEAD'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at eval (eval at  (C:\Users\nwf\readium-js-viewer\build-config\versioning.js:24:45), :157:58)
at ChildProcess.exithandler (child_process.js:204:7)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at maybeClose (internal/child_process.js:827:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "versioning"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>versioning: node build-config/versioning.js build-output/version.json
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>versioning script 'node build-config/versioning.js build-output/version.json'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build-config/versioning.js build-output/version.json
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR!  Exit status 1
npm ERR!
npm ERR!  This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR!  You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "build"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: npm run build:scripts
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'npm run build:scripts'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build:scripts
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "dist"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>predist: npm run build && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd.js dist
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>predist script 'npm run build && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd.js dist'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd.js dist
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dist+sourcemap script 'npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
`

Hello, thank you for trying again.
I am on Windows 10, with the same NodeJS / NPM versions, using a similar C:/Users/ path as you...but I am unable to reproduce this problem! :(
What's your git --version ? Mine is "2.8.1.windows.1".

I am on windows 7.For version i got the same
git version 2.8.1.windows.1
I did run clone at the beginning from master branch.Could this be the problem?
git clone --recursive -b master
How can i remove all and retry again with develop branch from beginning?

You don't need to re-clone.
Plugins to load:  [ 'highlights' ]
Generated plugin config files:
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\Require                                                                                JS_config_plugins.js
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\Require                                                                                JS_config_plugins_multiple-bundles.js
C:\Users\nwf\readium-js-viewer\readium-js\readium-shared-js\build-config\Require                                                                                JS_config_plugins_single-bundle.js
========> End of plugins bootstrap.

<EMAIL_ADDRESS>build:scripts C:\Users\nwf\readium-js-viewer
npm run versioning && npm run build:scripts:multiple && npm run build:scripts:                                                                                single && npm run build:scripts:single:LITE && npm run build:scripts:single:CHRO                                                                                MEAPP --readium-js-viewer:RJS_UGLY=no && npm run build:scripts:single:CHROMEAPPW                                                                                ORKER --readium-js-viewer:RJS_UGLY=no

<EMAIL_ADDRESS>preversioning C:\Users\nwf\readium-js-viewer
node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd                                                                                .js build-output

<EMAIL_ADDRESS>versioning C:\Users\nwf\readium-js-viewer
node build-config/versioning.js build-output/version.json

versionsMaker.js arguments:
[ 'build-output/version.json' ]
C:\Users\nwf\readium-js-viewer

Versioning: C:\Users\nwf\readium-js-viewer
Version: 0.23.0-alpha
Chrome version: 2.23.0-alpha
SHA: b55246040dc3ecaa9a8aa374e08fcae29a00f471
Clean: true
Tag: 0.23.0-alpha-0-gb552460
Branch: develop

Versioning: C:\Users\nwf\readium-js-viewer\readium-js
Version: 0.23.0-alpha
SHA: 665bdf0d90d5e0ae209b81eaa264293056cbf028
Clean: true
Tag: 0.22.3-79-g665bdf0
fs.js:549
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^

Error: ENOENT: no such file or directory, open 'C:\Users\nwf\readium-js-viewer\r                                                                                eadium-js\C:\Users\nwf\readium-js-viewer.git\modules\readium-js\HEAD'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at eval (eval at  (C:\Users\nwf\readium-js-viewer\build-config\ve                                                                                rsioning.js:24:45), :157:58)
at ChildProcess.exithandler (child_process.js:204:7)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at maybeClose (internal/child_process.js:827:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\                                                                                node_modules\npm\bin\npm-cli.js" "run" "versioning"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>versioning: node build-config/versionin                                                                                g.js build-output/version.json
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>versioning script 'node bu                                                                                ild-config/versioning.js build-output/version.json'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build-config/versioning.js build-output/version.json
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR!  Exit status 1
npm ERR!
npm ERR!  This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run versioning && npm run build:scripts:multiple && npm run bui                                                                                ld:scripts:single && npm run build:scripts:single:LITE && npm run build:scripts:                                                                                single:CHROMEAPP --readium-js-viewer:RJS_UGLY=no && npm run build:scripts:single                                                                                :CHROMEAPPWORKER --readium-js-viewer:RJS_UGLY=no
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\                                                                                node_modules\npm\bin\npm-cli.js" "run" "build"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: npm run build:scripts
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'npm run buil                                                                                d:scripts'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build:scripts
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\                                                                                node_modules\npm\bin\npm-cli.js" "run" "dist"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>predist: npm run build && node ./readiu                                                                                m-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bin/cmd.js dist
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>predist script 'npm run bu                                                                                ild && node ./readium-js/readium-shared-js/readium-cfi-js/node_modules/mkdirp/bi                                                                                n/cmd.js dist'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build && node ./readium-js/readium-shared-js/readium-cfi-js                                                                                /node_modules/mkdirp/bin/cmd.js dist
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\                                                                                node_modules\npm\bin\npm-cli.js" "run" "dist+sourcemap"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>dist+sourcemap: npm run dist && npm run                                                                                deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:source                                                                                map && npm run deploy:chromeApp:copy:sourcemap
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dist+sourcemap script 'npm                                                                                run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudRe                                                                                aderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap'.
npm ERR! This is most likely a problem with the readium-js-viewer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm ru                                                                                n deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcem                                                                                ap
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs readium-js-viewer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls readium-js-viewer
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\nwf\readium-js-viewer\npm-debug.log
The error is showing Error: ENOENT: no such file or directory, open 'C:\Users\nwf\readium-js-viewer\r                                                                                eadium-js\C:\Users\nwf\readium-js-viewer.git\modules\readium-js\HEAD'
`
as if it is referring to incorrect path. The file does exist under  C:\Users\nwf\readium-js-viewer.git\modules\readium-js\HEAD but why is it adding to it this part at the beginning 'C:\Users\nwf\readium-js-viewer\r                                                                                eadium-js'
This is the content of npm-debug.log in case it helps
0 info it worked if it ends with ok 1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe', 1 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js', 1 verbose cli   'run', 1 verbose cli   'dist+sourcemap' ] 2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'predist+sourcemap', 'dist+sourcemap', 'postdist+sourcemap' ] 5 info predist+sourcemap<EMAIL_ADDRESS>6 info dist+sourcemap<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true 8 info<EMAIL_ADDRESS>Failed to exec dist+sourcemap script 9 verbose stack Error<EMAIL_ADDRESS>dist+sourcemap: npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap9 verbose stack Exit status 1 9 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:217:16) 9 verbose stack     at emitTwo (events.js:87:13) 9 verbose stack     at EventEmitter.emit (events.js:172:7) 9 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:24:14) 9 verbose stack     at emitTwo (events.js:87:13) 9 verbose stack     at ChildProcess.emit (events.js:172:7) 9 verbose stack     at maybeClose (internal/child_process.js:827:16) 9 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5) 10 verbose pkgid<EMAIL_ADDRESS>11 verbose cwd C:\Users\nwf\readium-js-viewer 12 error Windows_NT 6.1.7601 13 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "dist+sourcemap" 14 error node v4.4.3 15 error npm  v2.15.1 16 error code ELIFECYCLE 17 error<EMAIL_ADDRESS>dist+sourcemap:npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap17 error Exit status 1 18 error Failed at the<EMAIL_ADDRESS>dist+sourcemap script 'npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap'. 18 error This is most likely a problem with the readium-js-viewer package, 18 error not with npm itself. 18 error Tell the author that this fails on your system: 18 error     npm run dist && npm run deploy:cloudReader:copy:sourcemap && npm run deploy:cloudReaderLite:copy:sourcemap && npm run deploy:chromeApp:copy:sourcemap 18 error You can get information on how to open an issue for this project with: 18 error     npm bugs readium-js-viewer 18 error Or if that isn't available, you can get their info via: 18 error 18 error     npm owner ls readium-js-viewer 18 error There is likely additional logging output above. 19 verbose exit [ 1, true ]

I am now able to reproduce this bug, from my fresh fork! (my working source tree works fine)
I am investigating...

Fixed here:
https://github.com/readium/readium-cfi-js/commit/bb13853a2f359d446d8ffb571ea90bc22087e6ae


Add defmt support and highlight crate features in docs.rs

This adds support for defmt via the defmt feature flag. This mainly brings defmt to the error types, but also adds it to Orientation.
To improve documentation, I added a rustdoc conditional feature for highlighting gated feature. All of the defmt::Format implementations could have been simply derived with a cfg_attr, but it doesn't work smoothly with the #[cfg_attr(docsrs, doc(...))] annotation.
To test documentation, you can run:
RUSTDOCFLAGS='--cfg docsrs' cargo +nightly doc --open --all-features

It should render like this:

Since you're using micromath, I added a PR for defmt support there as well (https://github.com/tarcieri/micromath/pull/108). If that happens, I'll come back and forward the feature.


Batch by dimension in Sfx handler

This PR adds the ability to,

Batch metrics by a dimension name at the handler level. Currently implemented for Sfx handler
For each batch, define it's own auth token and use the same when emitting metrics to the providers endpoint

I also wanted to add @kokje to the reviewers list, but the interface doesn't seem to like the username...


Fixfor #1444

Fixes  #1444
This image will be licensed under Attribution-ShareAlike 4.0 was too sensitive.
Now the link is attached to only the specific word like Attribution-ShareAlike 4.0.
Device: Xiaomi Redmi Note 4
Android version: 7.0

Codecov Report

Merging #1447 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1447      +/-   ##
=========================================
+ Coverage     3.3%    3.3%   +<.01%
=========================================
  Files         128     128
  Lines        6839    6834       -5
  Branches      669     669
=========================================
  Hits          226     226
+ Misses       6598    6593       -5
  Partials       15      15

Impacted Files
Coverage Δ

.../free/nrw/commons/upload/SingleUploadFragment.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b012ce4...5c5c83b. Read the comment docs.

Sir, I have made the changes that you have mentioned

Thanks @gupta1anubhav


FYSA: my edits.

any high-level thoughts etc?

A couple of high-level thoughts, related to the introduction:

I thought that some concepts might need to be introduced earlier. In particular, Docker plays a really important role in all this, so it might be worth mentioning up-front in the introduction. This is actually a more compelling use-case (IMHO) than many other use-cases that researchers use Docker for (e.g., as a tool to reproduce specific analysis).

Relatedly, the introduction feels a bit short at the moment, and we might want to make a bit more of a case for why the paper fits into the particular context of this conference.

These are good points - re: the docker stuff, I wasn't sure what kind of audience we'd have (e.g., if everybody would already be seasoned docker veteran).

Even for the seasoned readers (maybe even more for them!) we want to let
them know that Docker is going to be a key player in the drama about to
unfold (would even consider adding that into the title!)
On Fri, Mar 3, 2017 at 5:30 PM, Chris Holdgraf<EMAIL_ADDRESS>wrote:

These are good points - re: the docker stuff, I wasn't sure what kind of
audience we'd have (e.g., if everybody would already be seasoned docker
veteran).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/choldgraf/paper-pearc_2017/pull/5#issuecomment-284115015,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHPNujtpanTT7CXO2yixAwnTD2mizdbks5riL6hgaJpZM4MS1sC
.

Feel free to edit the title, I like your idea and think it's more specific to the topic


PropertyNamingPolicy doesn't work on Insert and Update

My SerilizationOptions setting is showed below.
            options.SerializationOptions = new Microsoft.Azure.CosmosRepository.Options.RepositorySerializationOptions
            {
                IgnoreNullValues = true,
                PropertyNamingPolicy = Microsoft.Azure.Cosmos.CosmosPropertyNamingPolicy.Default,
                Indented = true,
            };

I can sucessfully select values but when I try to update or insert new ones, they are updated in Cosmos db with CamelCase naming settings.
I cannot select these newly inserted values too because of My NamingPolicy is "Default".
I even tried to use JsonProperty but it didn't worked either.

I've fixed the solution by adding naming properties on appsettings.json.
services.AddCosmosRepository specified properties didn't worked.

Could you please share the exact code that didn't work versus the code that does?

        services.AddCosmosRepository(options =>
        {
            options.CosmosConnectionString = this.configuration.GetValue<string>("CosmosConnectionString");
            options.DatabaseId = "Master1";
            options.ContainerPerItemType = true;
            options.OptimizeBandwidth = true;
            options.SerializationOptions = new Microsoft.Azure.CosmosRepository.Options.RepositorySerializationOptions
            {
                IgnoreNullValues = true,
                PropertyNamingPolicy = Microsoft.Azure.Cosmos.CosmosPropertyNamingPolicy.Default,
                Indented = true,
            };
        });

I've transferred this tp appsettings.json like this;
"RepositoryOptions": {
"CosmosConnectionString": "***",
"DatabaseId": "Master1",
"ContainerPerItemType": true,
"OptimizeBandwidth": true,
"SerializationOptions": {
"IgnoreNullValues": true,
"PropertyNamingPolicy": "Default",
"Intented": true
}
},

        services.AddCosmosRepository(options =>
        {
            options.CosmosConnectionString = this.configuration.GetValue<string>("CosmosConnectionString");
            options.DatabaseId = "Master1";
            options.ContainerPerItemType = true;
            options.OptimizeBandwidth = true;
            options.SerializationOptions = new Microsoft.Azure.CosmosRepository.Options.RepositorySerializationOptions
            {
                IgnoreNullValues = true,
                PropertyNamingPolicy = Microsoft.Azure.Cosmos.CosmosPropertyNamingPolicy.Default,
                Indented = true,
            };
        });

I've transferred this tp appsettings.json like this;
"RepositoryOptions": {
"CosmosConnectionString": "***",
"DatabaseId": "Master1",
"ContainerPerItemType": true,
"OptimizeBandwidth": true,
"SerializationOptions": {
"IgnoreNullValues": true,
"PropertyNamingPolicy": "Default",
"Intented": true
}
},

Hi there I do not think you can apply config on the serialisation options in that way I think these need to come via code.

Hey @hidim any update on this was it still a problem or can we close this issue?

@mumby0168 haven't tested AddCosmosRepository options but appsettings.json configuration resolved my problem. I think we can close this issue.


Add support to pipSize

Sorry for the messy commit history

Coverage decreased (-0.6%) to 57.554% when pulling ea49b78ddb622d5539a2f86a45eedfd75268225f on qingweibinary:master into 1ef54b5b0049ad718e3a18b2b5274d5c91473d4c on binary-com:master.

Coverage decreased (-0.9%) to 57.246% when pulling 2c7bc9d995a363dfea486cab32f89f182355ad51 on qingweibinary:master into 1ef54b5b0049ad718e3a18b2b5274d5c91473d4c on binary-com:master.

I'll fix the test, a minute

Seems it's not build fail, why coverall fail? because of percentage dropped?


Browse the archive by date?

One of the ways I used the WordPress blog was to find what changed in the early days of the site. For instance, I could find the blog post that described the changes to reputation payouts for questions and know more or less when that changed. But I also used it to find things the other way around. If I see something strange in the data at a particular time, I can often solve the mystery by searching for posts that month. The new blog doesn't seem to have that functionality. Would it be possible to implement some way to browse around a particular date?

I see - do you usually do this by year then month? Or just emulate what's currently on WordPress?

Either way is fine. I do like the simplicity of the current archive.
Searching by date would be even better, I think. But it doesn't seem like that would need to be a first release feature or even necessarily worth a lot of time implementing.

Okay, going to put this in as something we want to implement, but probably not a blocker for first release. I can see a path to doing this, it's just a bit more than trivial.

This can likely be re-visited now that I've done all the pagination in Ruby in PR #118 (the only way you can do it really) which means we can generate anything. If you sketch out an archive format, generating it should be much closer to trivial now - happy to help.


chore(main): release 0.1.0

:robot: I have created a release beep boop
0.1.0 (2024-09-26)
Features

added "created" field to output + removed "type" from data classes repr (1e06d6d)
added auto binary upload to release (376e1c1)
added bin build and gh action (88cd0df)
added CLI prompts and arg parsing (fcc0702)
added linter / formatter (72251b9)
added POST.md (331928f)
added README file + started on prompting (11afd72)
added release-please (2d1af16)
added setup.py (0312ada)
added tests (1a85d2a)
added unit tests (3afcbd7)
added whitelisting (9eee8ad)
initial commit (ead9d50)
more error handling (2adfb01)
removed root folder to further simplify output (de0aacb)
simplified bookmark repo interface (9839ba9)
updated README (2724be4)

Bug Fixes

linting warnings (5e6930c)
pipeline build bugs (54e52c3)
release type (1a97e27)
typo (93d1439)
updated README and makefile (21d4780)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/nico-i/bkmks/releases/tag/v0.1.0 :sunflower:


Announce .local domains via mDNS

I'm running rap + rancher on my homeserver, but I don't want to make every web application accessible from the outside via a FQDN. An example: I'm running a ympd instance to controll my Music Player Daemon. Since the music is only played at home, I don't want to have a publicly available URL, e.g. ympd.example.com, to access the web interface, because I'd then have to e.g. password protect it to prevent missuse. Instead, I'd like to make use of .local in order to get a local domain in my LAN, e.g. ympd.local, which would then automatically be resolved to the local LAN IP of the nginx proxy, which itself proxies the request to the host in my cluster running the ympd instance.
From a configuration perspective, I imagine one could just use the rap.host label and set it to ympd.local, which would then configure the nginx proxy to forward any connections to ympd.local to the rancher host running the ympd instance.
The way I understand it, rap would just have to add an avahi daemon plus some more advance parsing of the rap.host variable to its container being able to broadcast several .local domains. In some cases one might even define publicly available domains in addition to local domains, i.e. to circumvent password protection for local access from within the LAN, e.g. via rap.host=ympd.example.com,ympd.local, but that would just be a nice-to-have.
Is something like this possible/planned?

I just found this project. Maybe this could be integrated.


Configurable max_msg_size

Upper layer can pass in
params.max_message_size_
to specified the max message size the GRPC server will accept.
UT with params.max_message_size_ set to 65MB and SEND_DATA up to 64MB which is our target max_blob_size.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.20%. Comparing base (009f47c) to head (6d1d313).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   71.36%   74.20%   +2.84%
==========================================
  Files          21       20       -1
  Lines         887      853      -34
  Branches      103       98       -5
==========================================
  Hits          633      633
+ Misses        189      155      -34
  Partials       65       65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[security] Fix exposed push tokens through gh workflow_run

Pretty much implements https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
tldr:

one workflow (without access to repo secrets) builds docs
another workflow (with access to repo secrets through wokflow_run) uploads/pushes the docs to the hub

todos (in order):

[ ] revert 7935dc2f6b0771f897cbdfaf0667cb579fa0c43d
[ ] merge this PR
[ ] add github secret to hf organization and/or individual repos if necessary
[ ] update doc-build github actions of all repositories that are using doc-builder (ex: https://github.com/huggingface/transformers/pull/24013)

I am very uneducated in secuitry issues but what prevents the malicious user to rewrite those new workflows and get access to the secret token?

I am very uneducated in secuitry issues but what prevents the malicious user to rewrite those new workflows and get access to the secret token?

Secrets are never passed to workflows run from forks.
The workflow that uploads the docs here: https://github.com/huggingface/accelerate-wip/blob/main/.github/workflows/upload_pr_documentation.yml
It's only run from the main branch, and https://github.com/huggingface/doc-builder/pull/379/files#diff-f05826b801b9407ec985196b30fc45b111e09b5d98ee8670333493868e2b8dad  it only downloads & reuploads an artifact


State of the branches

@vijayee Could you tell me what is the state of https://github.com/vijayee/js-ipfs-merkle-dag/branches and what do they have? Thank you

FixDagServiceAndBatches should be closed and merged. Traversals I'm still working on. Traversals has DFS and BFS but needs modification to be able to perform operations on node data in pre and post orders. Technically this may not be needed considering its an iterator that passes out the data to be used as one sees fit but the go implementation has this capability. I dunno nothin' bout those other batches


"The null object does not have a method '_badUpgrade'." in 1.0.0.rc-5

Since the update I repeatedly get

Uncaught Unhandled exception:
The null object does not have a method '_badUpgrade'.

NoSuchMethodError: method not found: '_badUpgrade'
Receiver: null
Arguments: []
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
#2      _createCustomUpgrader (dart:html:1237)
#3      _VMElementUpgrader.upgrade (dart:html:47395)
#4      registerDartType.upgradeElement (package:web_components/interop.dart:38:45)
#5      JsObject._callMethod (dart:js:1124)
#6      JsNative.callMethod (dart:js:1136)
#7      Blink_JsNative_DomException.callMethod (dart:blink:17259)
#8      BlinkDocument.createElement_Callback_1 (dart:_blink:3330)
#9      Document.createElement (dart:html:11031)
#10     _ElementFactoryProvider.createElement_tag (dart:html:16361)
#11     Element.Element.tag (dart:html:13878)
#12     AllDemos._loadDemo (http://localhost:63342/polymer_elements_demos/web/all_demos.dart:284:22)
#13     AllDemos.selectedItemChanged (http://localhost:63342/polymer_elements_demos/web/all_demos.dart:277:9)
#14     Function._apply (dart:core-patch/function_patch.dart:7)
#15     Function.apply (dart:core-patch/function_patch.dart:28)
#16     _InstanceMirrorImpl.invoke (package:reflectable/src/reflectable_transformer_based.dart:164:23)
#17     _setupReflectableMethods.. (package:polymer/src/common/polymer_descriptor.dart:162:31)
(anonymous function)
newCallback
(anonymous function)
(anonymous function)
Polymer.Base.extend._observerEffect
(anonymous function)
Polymer.Bind._modelApi._effectEffects

Dart VM version: 1.13.0-edge.05ad578b77d074bf620227bcf5a3e5f53c28cc32 (Fri Oct 30 14:53:19 2015) on "linux_x64"

I could narrow down a bit. It seems I only get this exception for some Google API components in
https://github.com/bwu-dart/polymer_elements_demos/tree/update_2015-11-01
when I load web/index.html and select one of the following demos:

firebase-element-demo
google-analytics-demo
google-apis-demo
google-calendar-demo
google-signin-demo

I run into this _badUpgrade today when an event handler Listen('theme-changed') myHandler(_, __){ throw 'xxx'; } failed with an exception.

This is definitely a weird one, looks like it happens when you create a new element dynamically in code and then the upgrader fails.

It doesn't fail on the initial creation either, just subsequent ones?

cc @terrylucas since this looks like its happening inside the vm upgrader

So really what is happening here is an error is being thrown during the construction of the element, and the error is just being hidden by the separate error in dartium.
I tracked it down to a bad splices change notification, which has a null indexSplices property. I can't actually repro this outside of these couple elements, definitely going to need further investigation.

bleeding edge in Dartium has the fix to return the real error.

@zoechi can you confirm that this is now giving you a better error at least?

Yup, proper stacktrace :+1:

Ok, I am going to close this one then, and you can open a new issue for the actual error? Or maybe link it here if already filed :)

I also see that exception in stable <IP_ADDRESS> dartium. Any advice how to make it work?


HistoricalRecords' iterator fails when used with 'excluded_fields' and 'inherit=True'

While working with django-simple-history, I came across few interesting enhancements/features/bugs which i'm listing down below -

How to exclude fields in abstract inheritance?
class RowInformation(models.Model):
   is_active = models.BooleanField(default=True)
   created_at = models.DateTimeField(auto_add_now=True)
   ...

class Wallet(RowInformation):
   manufacturer = models.ForeignKey(Manufacturer, on_delete=models.PROTECT)
   total_spent = models.FloatField(default=0)
   ...

How to exclude fields in multitable inheritance?
class RowInformation(models.Model):
   is_active = models.BooleanField(default=True)
   created_at = models.DateTimeField(auto_add_now=True)
   ...

class Transactions(models.Model):
   amount = models.FloatField()
   mode = models.ChatField(max_length=3, choices=VALID_MODES)
   ...
   history = HistoricalRecords(inherit=True, excluded_fields=['is_active'])

class Sales(Transactions, RowInformation):
   vehicle = models.ForeignKey(VehicleInformation, on_delete=models.PROTECT)
   timestamp = models.DateTimeField()
   ...

When I'm adding fields to excluded_fields to any models for example Transactions, it still gets tracked into TransactionsHistoricalRecords models. Checked the database for same and database doesn't have those fields but while performing histories = Sales.objects.first().history.all(), it fetches excluded fields in histories as well.

Now coming to the real issue from which all these things came up -
I've a model structure as follows
 class RowInformation(models.Model):
    is_active = models.BooleanField(default=True)
    created_at = models.DateTimeField(auto_add_now=True)
    ...

 class Wallet(RowInformation):
    manufacturer = models.ForeignKey(Manufacturer, on_delete=models.PROTECT)
    total_spent = models.FloatField(default=0)
    ...

 class Transactions(RowInformation):
    wallet = models.ForeignKey(Wallet, on_delete=models.PROTECT)
    amount = models.FloatField()
    mode = models.ChatField(max_length=3, choices=VALID_MODES)
    ...
    history = HistoricalRecords(inherit=True, excluded_fields=['is_active'])

 class Sales(Transactions, RowInformation):
    vehicle = models.ForeignKey(VehicleInformation, on_delete=models.PROTECT)
    timestamp = models.DateTimeField()
    ...

When I execute  histories = Sales.objects.first().history.all(), throws an error saying Wallet matching query does not exist or invalid literal for int() with base 10: '<text in field>'.
Checked the above for values in queryset where I noticed -

histories.first().__dict__ has all the values as expected but when i use self.__dict__ in model's def __str__(self), the values have interchanged.

Please refer to the repo for detailed insight on models and database.
Public repo to play around with
Forked a existing public repo - https://github.com/codingforentrepreneurs/Try-Django

https://github.com/sunit-poddar/sample-django-project

Project structure
I've added a EER diagram for whole project. Although please notice the structure of following mentioned models -

RowInformation
Person
Wallet
Transactions
Sales
Expenditures
Manufacturer
VehicleInformation

EER link - https://raw.githubusercontent.com/sunit-poddar/sample-django-project/master/src/try-django-eer-001.png
To Reproduce in the repo

Clone the repo - https://github.com/sunit-poddar/Try-Django.git

Database is already present for your ease of use.

Install requirements
Run python manage.py shell
Import models and run -

sales = Sales.obects.first()
sales.history.all()

See error

Environment:

OS: Ubuntu 18.04
Django Simple History Version: 2.3.0
Django Version: 2.1
Python version: 3.5.4
Database Version: SQLite

Thanks for the detailed description here. Going to play around with it this week and get back to you.

@rossmechanic Were you able to reproduce the error?

Hi @sunit-poddar, I was able to reproduce the error. The error you're getting had to do with referencing a ForeignKey from a historical object (where the foreign keys are stored as ints to prevent cascading deletes and constraints). If you change the definition of __str__ on the Sales model so that it no longer references self.wallet, you won't get the error anymore. So I don't think it has anything to do with excluded fields.
In fact, the error only occurs when you try to print out the string representation of the object (because of that lack of an explicit foreign key on the history object). If you store that history query in a variable, you can then access it and play with it without any errors (unless you print out the string representation)

@rossmechanic Were you able to reproduce the error?


CallComposite getting role from Calling SDK

What

This PR changes the role from the CallComposite to roleHint. The roleHint will determine the role before the call because it will be passed to the PermissionProvider.
When a Rooms call starts, the CallComposite will obtain the role from the CallingSDK and use it for the PermissionProvder
Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Pro the move to roleHint 👍
Best in a separate PR but want to check, is the plan to keep it as a Composite property or move to an adapter contructor property?

Pro the move to roleHint 👍 Best in a separate PR but want to check, is the plan to keep it as a Composite property or move to an adapter contructor property?

Yes, I put it in a separate PR here https://github.com/Azure/communication-ui-library/pull/2482 :)


Add embed/dembed widget posibility

Add possibility to embed and deembed (detach) Node widget from scene. From popup menu on right button click you can select embedding state. When the widget is detached you can change it size and if you embed again the Node resized to new size.

Please see https://github.com/paceholder/nodeeditor/pull/374 @samiavasil. It might be prudent to build your changes on top of that PR once it's merged.


[Snyk] Security upgrade nuxt from 2.13.3 to 3.0.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
yarn.lock

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Improper Control of Dynamically-Managed Code Resources SNYK-JS-EJS-6689533
No
No Known Exploit

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-LODASH-1018905
Yes
Proof of Concept

681/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.2
Command Injection SNYK-JS-LODASH-1040724
Yes
Proof of Concept

731/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 8.2
Prototype Pollution SNYK-JS-LODASH-567746
Yes
Proof of Concept

686/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.3
Prototype Pollution SNYK-JS-LODASH-608086
Yes
Proof of Concept

768/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5
Prototype Pollution SNYK-JS-LODASH-6139239
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Improper Control of Dynamically-Managed Code Resources
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Command Injection
🦉 More lessons are available in Snyk Learn

👷 Deploy Preview for benevolent-blini-5169f6 processing.

Name
Link

🔨 Latest commit
2b27d919d654f3f4de5ffbdaa00fba6ac3b4f8bb

🔍 Latest deploy log
https://app.netlify.com/sites/benevolent-blini-5169f6/deploys/662ff10cf0abb70008fa00ab


Add callout to Statutory Sick Pay calculator start page

As requested: https://govuk.zendesk.com/agent/tickets/3955481

Screenshot of Heroku app ☝


feat(CloudFront): Include missing fields

Description
Include the following missing fields using the create_distribution API:

DefaultCacheBehaviour.FieldLevelEncryptionId
DefaultCacheBehaviour.RealtimeLogConfigArn
Logging

Enabled
IncludeCookies
Bucket
Prefix

WebACLId

Codecov Report

Merging #5659 (a732d92) into master (3a66ef5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5659      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%
==========================================
  Files         742      743       +1
  Lines       72746    72727      -19
==========================================
- Hits        69985    69964      -21
- Misses       2761     2763       +2

Flag
Coverage Δ

servertests
36.89% <11.11%> (-0.05%)
:arrow_down:

unittests
96.14% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/cloudfront/models.py
98.26% <100.00%> (+0.03%)
:arrow_up:

moto/core/base_backend.py
93.37% <0.00%> (-6.63%)
:arrow_down:

moto/meteringmarketplace/models.py
85.39% <0.00%> (-0.17%)
:arrow_down:

moto/polly/models.py
91.37% <0.00%> (-0.15%)
:arrow_down:

moto/glacier/models.py
82.57% <0.00%> (-0.14%)
:arrow_down:

moto/elasticbeanstalk/models.py
91.46% <0.00%> (-0.11%)
:arrow_down:

moto/resourcegroups/models.py
77.97% <0.00%> (-0.10%)
:arrow_down:

moto/xray/models.py
88.31% <0.00%> (-0.08%)
:arrow_down:

moto/athena/models.py
93.39% <0.00%> (-0.07%)
:arrow_down:

moto/resourcegroupstaggingapi/models.py
83.43% <0.00%> (-0.05%)
:arrow_down:

... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


TypeScript error

node_modules/pony-cause/index.d.ts:5:5 - error TS2416: Property 'cause' in type 'ErrorWithCause<T>' is not assignable to the same property in base type 'Error'.
  Type 'T' is not assignable to type 'Error | undefined'.
    Type 'T' is not assignable to type 'Error'.

5     cause: T;
      ~~~~~

Found 1 error in node_modules/pony-cause/index.d.ts:

We're running into the same issue. Any plans to look into this?

Updating the constraint for the Error generic parameter for cause like this fixes it:
ErrorWithCause<T extends Error | undefined = undefined>

Relates to https://github.com/microsoft/TypeScript/issues/48098, and as @ljharb said in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/59354#issuecomment-1073070185:

the bug is in the base error cause types

And https://github.com/microsoft/TypeScript/issues/45167#issuecomment-1073077140 is still open for this very reason.
I note that there's also another incorrect Error related type in TS, that the type of .stack while being optional is not explicitly allowed to be undefined: https://github.com/microsoft/TypeScript/issues/45748
So: We have to fix this in TS.
In the meanwhile: You can downgrade to an older version of TS, like eg. TS 4.5, to avoid this error.

Would by the way love a PR with a test case that reproduces this, so that we can more easily verify that its working again 👍

Doing some more pinning down on when this was introduced:

This is caused by "lib": ["es2022"] or more specifically the es2022.error lib. esnext will include es2022 on TS 4.6 and later.
No es2022 stuff is documented in the online lib documentation, but in the TS 4.6.4 CLI it is documented:

Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'es2018', 'es2019', 'es2020', 'es2021', 'es2022', 'esnext', 'dom', 'dom.iterable', 'webworker', 'webworker.importscripts', 'webworker.iterable', 'scripthost', 'es2015.core', 'es2015.collection', 'es2015.generator', 'es2015.iterable', 'es2015.promise', 'es2015.proxy', 'es2015.reflect', 'es2015.symbol', 'es2015.symbol.wellknown', 'es2016.array.include', 'es2017.object', 'es2017.sharedmemory', 'es2017.string', 'es2017.intl', 'es2017.typedarrays', 'es2018.asyncgenerator', 'es2018.asynciterable', 'es2018.intl', 'es2018.promise', 'es2018.regexp', 'es2019.array', 'es2019.object', 'es2019.string', 'es2019.symbol', 'es2020.bigint', 'es2020.promise', 'es2020.sharedmemory', 'es2020.string', 'es2020.symbol.wellknown', 'es2020.intl', 'es2021.promise', 'es2021.string', 'es2021.weakref', 'es2021.intl', 'es2022.array', 'es2022.error', 'es2022.object', 'es2022.string', 'esnext.array', 'esnext.symbol', 'esnext.asynciterable', 'esnext.intl', 'esnext.bigint', 'esnext.string', 'esnext.promise', 'esnext.weakref'.
The online lib documentation do state the very true:
This list may be out of date

lib will default to the value of target, so if target is es2022 or esnext on TS 4.6 or later then it will include the troublesome new Error definition. And the online target documentation does indeed document es2022

So, conclusion: You can also avoid this issue by setting lib implicitly through target´ or explicitly to something that doesn't include es2022.error`

I have now merged #36 which added tests that reproduces this very fact.

The mentioned PR has now been merged into TS: https://github.com/microsoft/TypeScript/pull/49639
Not sure in what release it's going to appear. I hope it's going to be in at least TS 4.8

#41 proves that current upcoming TS does indeed solve this issue.

Published 2.1.0 that contains a fix for TS 4.6 and TS 4.7, as those two versions likely never will be fixed by TS

Thanks to everyone in the thread for the help! And an extra shoutout to @RossComputerGuy for the patch 🚀
@voxpelli not sure if you're familiar with umzug, but I started a discussion over there for them to add your patch  🙂

@SpencerKaiser Thanks for bringing it to mine and their attention 🙏 I replied in that thread asking if they would want me to backport the fix to 1.x

TS 4.8 is now released. If you update to that one then everything will work as it should thanks to the corrected lib.d.ts: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#lib-d-ts-updates


workaround for mixed string/posixpath error

Reference Issues or PRs
Fixes #1914

What does this implement/fix?
Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

Technically fixes the issue, but more of a workaround

@iameskild @costrouc This draft has my working fixes for a couple of other issues as well, #1919 and #1916 so far.


Added a better counter for asynchronous refreshes and only refresh af…

…ter a cycle through the tree if one is required
I added "refreshedCount" to properly count changed IDs since the internCount sometimes gets reset to 0 for random reasons.  Also, after we go through the tree once, only refresh the BOM if the needsRefresh is still set so we don't refresh for no reason.

Coverage decreased (-0.003%) to 0.555% when pulling 182a393668d7c9ebf7455c4e4d740dc1ad93d9d3 on rkosinski941:patch-1 into 0ccf29b054e41519d156a1ae770de2c3afcb2e7f on blackducksoftware:master.


Remove struct member offset monotonicity check

Fixes #1822

Remove check that struct member offsets must be monotonic
All environments match Vulkan behaviour now
updated offending tests

Rebased, squashed and committed as cb0f1f565b29a38f0be313207165d873808c014a


container 2 hours behind

this seems to be a very old issue.
do not know if this is realted to docker or setting a TZ environment in the docker file
is there a way to set the timezone for this container or perhaps copy it from the system.
it is using UTC while i am in CEST(europe)

I've tested setting the timezone via the TZ variable and it seems to work. Could you try it for your container?

Also, I just added a manual timezone support and pushed it to the develop branch: https://github.com/marcoraddatz/homebridge-docker/tree/develop#homebridge_timezone Thanks for reporting!

i tried that but did not work
do i need to use another vaiable?

Yes, it should be the timezone: F.e. TZ=Europe/Berlin
Alternatively you can use the develop branch and set the HOMEBRIDGE_TIMEZONE.

tried it, still not working.
to be sure we are talking about the same thing.
at the entry millieu i add the variabel TZ=Europe/Berlin
i check the time which is displayed in the log when the container starts up. this time is 2hours behind.
i also read that mapping /etc/localtime to /etc/localtime works but it does not.
i can not map /etc so i copied local time to /docker and mapped that file to /etc/localtime. still not working

Yes, we're talking about the same thing. I set up my container with  docker run -e TZ=Europe/Berlin xxxx and it all loaded. The feature I added yesterday (and which is only available in the develop branch so far) modifies the etc/localtime, as you said: https://github.com/marcoraddatz/homebridge-docker/blob/develop/image/run.sh#L57

ok so maybee the TZ variable only gets accepted through the commandline and not the gui. (will test)
how can i get that latest branch image?(github is a mystery to me)

tried commandline: not working. still 2 hours behind

Pretty strange. However: You can also get the latest version via Docker Hub, simply select "develop" from the list of available downloads: https://raw.githubusercontent.com/marcoraddatz/homebridge-docker/master/doc/docker-1.png

well, downloaded new image, build new container, added new variable but still 2 hours behind.
hopefully the variable setting is wrong otherwise i am out of luck

Sorry for the confusion: The HOMEBRIDGE_TIMEZONE must be set in the .env file, which is in the samples folder and must be placed next to the config.json. https://github.com/marcoraddatz/homebridge-docker/tree/develop#env-options

Ahh. ok now i know what to do but i still get the error .env not found
there is a .env file in the docker/homebridge directory. the same directory as al the other config files

don't ask why but somehow the .env file got found.
still 2 hours behind while i pulled the latest development version
i will give up on this since this is taking up  alot of time

Can absolutely understand that. Will test that on other machines! Thanks for your efforts!

I just tested this option and works as supposed. (Docker is one hour behind, but the container sets the correct date).


Model partition status report as an operation on the state store interface

Background
We'd like to make some changes to how compactions work to avoid the need for separate splitting compactions:

https://github.com/gchq/sleeper/issues/966

Description
We'd like to define a new method signature for the state store which can handle producing a partition status report as a single operation. We want this to make it easier and clearer to see what needs to change to remove splitting compactions.
Analysis
We can update tests to assert on the partition status report, rather than using current methods to list partitions.
We may want to split out a separate issue to integrate this new interface into the client module.
We may want to update the DynamoDB implementation to use the new model, or we could delegate to the existing methods and map to the new model.

Closing as this is not needed for now.


Doc: update README.md

since jobs module was changed a lot
Click Here to see the page.
Waiting for @Echoring to fill up

↑Done.

↑Done.

cc @Una-p @Jaehyuk-Lee
Just let you know that README.md was updated, so Korean version should be updated too.

cc @Una-p @Jaehyuk-Lee
Just let you know that README.md was updated, so Korean version should be updated too.


Installing s3 with bart on Centos 7

installing bart requires duplicity.  I came across a bug which appears to have been resolved in the latest release of duplicity.
symptoms: not backing up to the s3 bucket.
after upgrade to duplicity 0.7.03
backup completes to s3 as expected.
although you get
BackendException:
BackendException:
BackendException:
BackendException:
BackendException:
BackendException:
2015-06-09-22:23:27 - [BART-Loglevel4] Running command - /usr/bin/duplicity remove-all-but-n-full 6 -v4 --log-file=/opt/alfresco/scripts/alfresco-bart-2015-06-09.log --force s3+http://s3bucketname/files
BackendException:
ERROR 23 BackendException
. BackendException:

reported this back to bart team, and think we are clear of this now since os updates, closing.


chore: integration tests in pipeline (#100)

Description
Run integration tests in the CI pipeline for PRs and dev deployment on master.

Related issues

Closes #100

Checklist

[ ] PR title follows Conventional Commits guidelines
[ ] All relevant PR sections are populated, irrelevant ones are removed

Otherwise, LGTM! (stupid question: did you try to make the integration tests fail to make sure that the pipeline also fails?)

Not in this project, this is tested in the rasa_integration_tests's own unit tests.


.gitignore pattern is not interpreted correctly

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
The .gitignore pattern **/foo is not interpreted by fzf correctly. For example, in this repo https://github.com/zed-industries/zed, .gitignore has this line: **/target. However if I to ctrl + t and run the fzf from the master branch (1833670), the target directory is indexed.
Relevant git documentation says: (https://git-scm.com/docs/gitignore#_pattern_format) (emphasis mine)

Two consecutive asterisks ("**") in patterns matched against full pathname may have special meaning:
A leading "**" followed by a slash means match in all directories. For example, "**/foo" matches file or directory "foo" anywhere, the same as pattern "foo". "**/foo/bar" matches file or directory "bar" anywhere that is directly under directory "foo".

fzf does not interpret **/foo the same way as foo.

fzf doesn't know anything about .gitignore. If you want CTRL-T binding to respect .gitignore files, you need to install an external program such as fd or rg that understands them and set FZF_CTRL_T_COMMAND.
See https://github.com/junegunn/fzf?tab=readme-ov-file#respecting-gitignore


Updated the middleware to better support multiple mock swagger files

This is a replacement pull request for #28 removing unneeded files

how would one use this?

@bobrafie this change enables the call to
middleware(filename, app, function (err, middleware) {...});
to work when called multiple times with different file names.

Here's an example of how to use it with multiple swagger files:
const myDB = new MemoryDataStore()

swaggerExpressMiddleware('swagger1.yaml', app, function(err, middleware1) {
  swaggerExpressMiddleware('swagger2.yaml', app, function(err, middleware2) {
    myDB.save(Resource.parse(mockData1), Resource.parse(mockData2), function() {
      app.use(
        middleware1.metadata(),
        middleware1.files(),
        middleware1.parseRequest(),
        middleware1.CORS(),
        middleware1.validateRequest(),
        middleware1.mock(myDB), // Use custom data store that is pre-populated with mock data
        middleware2.metadata(),
        middleware2.files(),
        middleware2.parseRequest(),
        middleware2.CORS(),
        middleware2.validateRequest(),
        middleware2.mock(myDB) // Use custom data store that is pre-populated with mock data
      )
    })

    app.use(
      bodyParser.json(), // for parsing application/json
      bodyParser.urlencoded({ extended: true }) // for parsing application/x-www-form-urlencoded
    )
  })
})

Has this been resolved?

Can this be resolved? Hitting the same issue.

I don't think this PR can be merged as-is anymore, because a lot of the code has changed since then.  But if someone wants to rebase this and/or submit a new PR based on the current HEAD, that would be great.

@JamesMessinger  submitted PR#153 based on the current HEAD. Could you please merge?


Docs | howto-controlling-conversation-flow.md

Can we rename this to something that relates more to 'Condition' so that it maps to the "Condition' Action item in the + menu?
(note: the option in the + menu used to be called 'flow')
https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/howto-controlling-conversation-flow.md

When naming topics, we follow the scenario instead of the actual screen. So, in this case, it is about controlling conversation flow, but there are specific steps showing how one can do that in the "How-To" topic.


[AUTOPATCHER] Patches CVE-2021-4166 for vim

        Patches CVE-2021-4166 for vim.
        This patch and PR was automatically generated and needs human verification before merging.

PR failing to apply patch due to conflicts.
Bumped up version to address this CVE.
PR for reference: https://github.com/microsoft/CBL-Mariner/pull/1855


Improve footer light blue 1

Current Footer Status

Need to make like this as given in figma design

Please assign this to me


Stack Nav inside Tab nav initially renders with the stack on top already?

I've got a Tab Navigator for my main app navigation, I want one tab of my app (lets call it Page A) to let me open a modal tab. I've done it but for some reason whenever my app starts (it starts on that tab intentionally - Page A), I get a render of Page A with a back button in the header to Page A..
So the app starts, I've got Page A open and I have to close it to get back to the same page.
Has this happened before for anyone?

Can you share some code? Preferably a small example on Snack

I was seeing this as well. It seems to be related to connecting the application to a redux store. https://snack.expo.io/B10b-k5Pb

Playing with the example some more, changing this:
// Redux config
const initialState = AppNavigator.router.getStateForAction(
  AppNavigator.router.getActionForPathAndParams('StackOne')
);

to this:
// Redux config
const initialState = AppNavigator.router.getStateForAction(
  { type: 'VOID' }
);

seemed to work, although I'm not 100% sure why. The first method is also the recommended method in the documentation here: https://reactnavigation.org/docs/guides/redux.

I'll give it a try and see if it works - thanks!

Pinging OP @chrisgreg  since this issue has not been active for a while, and it's related to an old version of the lib.
Please let me know if you want this to remain open; if I get no answer in the next 7 days I will close it.

Hi there @chrisgreg ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.


Allow the shell interpreter to be configured

Currently the agent guesses the shell based on your operating system, either /bin/bash on nix or cmd on windows.
This allows for the shell used for interpreting $BUILDKITE_COMMAND to be configured.
IMO eventually we should default to /bin/sh, but for backwards compat, we will go with /bin/bash.
This controversially also ditches the behaviour where we write a shellscript for each command to be executed.

would switching to /bin/sh be worth considering as part of the 3.0 breaking changes,or will you bum that to a future release?

@dch the issue is that lots of folks tend to use bash semantics without realising it in their command steps (for better or worse).
We'll talk it over. Let's see if I can get this PR right first :)

In terms of directly invoking the commands vs writing a tmp script file, this was my pros/cons list:
PROS

Radically simpler, less moving parts
No dependency on the local filesystem, which makes things much simpler for environments like docker
Plays well with switching your shell to something else, for instance Powershell on Windows

CONS

Length limits for how long a set of commands can be, e.g ARG_MAX
If folks have shebangs at the start of their "slab of commands", it just won't work
We need to pass the -e to bash to provide the same semantics as we previously had
Maybe it looks a bit less tidy at a process-level view?
Users might need to understand shells a bit better?

If folks have shebangs at the start of their "slab of commands", it just won't work

This seems like a pretty major con? As in, some people stuff will just stop working?

Maybe it looks a bit less tidy at a process-level view?

Can you paste a screenshot of the before/after? Part of the bootstrap magic is how awesome the output looks - I wouldn't really want to compromise on that.

No dependency on the local filesystem, which makes things much simpler for environments like docker

How so? I thought your "executor" thingy would have solved that bit? And the "local executor" we have no just needs file system access?

Oh, scratch the shebang one off the list:
bash -c '#!/bin/bash
echo hello world'
hello world

Can you paste a screenshot of the before/after? Part of the bootstrap magic is how awesome the output looks - I wouldn't really want to compromise on that.

@keithpitt I meant how the ps -auxxx would look on the host running the agent. The bootstrap output ends up with considerably less cruft in it after this (which I will now add to PROS).

How so? I thought your "executor" thingy would have solved that bit? And the "local executor" we have now just needs file system access?

Nope, it would be an annoying and manual process for all pluggable executors. Each one would have to have it's own set of techniques for getting the temporary script over.

There are some kinks to work out 🤔

I'm torn on echoing each line. Feels?

I think I prefer keeping it minimal and just showing the shell command and the output. It lets the output speak for itself.

I'm not particularly tied to the approach of how to run commands (writing the script I mean). If there are more pros than cons then I'm totally fine with it.
Does this approach allow us to run slightly complex pipelines like this?
steps:
  - command: <
      #!/bin/bash
      echo "The \$BUILDKITE_RETRY_COUNT value is $BUILDKITE_RETRY_COUNT"
      if [[ "$BUILDKITE_RETRY_COUNT" == "0" ]]; then
        echo "Gonna fail 👎"
        exit 1
      elif [[ "$BUILDKITE_RETRY_COUNT" == "1" ]]; then
        echo "Gonna fail 👎 1 last time"
        exit 2
      else
        echo "Horray! It works! 👍"
        exit 0
      fi

Hrm...just thinking about it more...if I do a export FOO=bar in a command, will that environment variable be available in a post-command hook/plugin? I think that's why I did the script writing in the first place (so there's a place to capture that stuff).

Hrm...just thinking about it more...if I do a export FOO=bar in a command, will that environment variable be available in a post-command hook/plugin?

Hmmm... no, I don't think so. Did we ever support that?

The command you posted would run fine! The #!/bin/bash is ignored though.

Hmmm... no, I don't think so. Did we ever support that?

We didn't, I'm remembering lies. I think we supported it in the pure bootstrap.sh version of the file, but not in the improved Golang version. Do you think we should support it? (knowing that it kinda makes your proposed change not possible).
I kinda would expect any exports to carry across, but there are many caveats to it working (just like now with hooks).
Whatta ya rekon?

ends up around 128k characters

I think that's totally fine. Anything longer and you can just put in a script.

I think we supported it in the pure bootstrap.sh version of the file, but not in the improved Golang version.

Nah, that was where I looked first. I couldn't find any prior art for normal commands. If you have a command hook, it will do the env dance, but not a non-hook command.
The thing that weirds me out about passing env is that for lots of folks it's unexpected (me included), because it's not how shells work. Subshells get a copy of env, but they can't influence shells that the parent process subsequently creates.
My take would be to not add magic env passing to the command, unless there is prior art in the 2.x series. I'd love to see that env passing mechanism be more explicit via something like buildkite-agent env set LLAMAS "always".

Thanks @keithpitt! I'm sure we'll run into reasons why it's a bad idea, but for the moment I think it's a good simplification!


message_list: Add buttons for different actions.

Fixes #30405
Fixes #18728
Updated this based on discussion in https://chat.zulip.org/#narrow/stream/101-design/topic/Add.20navigation.20buttons.20below.20messages.20.2330405

I didn't spend a lot of time trying to find edge cases since we are still in the trial phase, so think of it this PR as prototype worth deploying to test out the feature.

Nice! I wonder if a shorter tooltip delay would be better, since the buttons are unlabeled now (maybe LONG rather than EXTRA_LONG).

It's definitely much more subtle than the previous version. I'd like to see this on CZO!

Updated to move navigation buttons to the right.

Deploying back on chat.zulip.org again.

Pushed to resolve conflicts.

Pushed mainly to just resolve conflicts. Didn't address any feedback in the design thread yet since the discussion didn't seem to have reached a conclusion.


NSNet 2 baseline ONNX model with 512-size STFT and 32ms window

Hello,
In the paper describing the NSNet 2 baseline, you use an STFT of size 512 with a 32ms square-root Hann window, but in the provided nsnet2 baseline model under NSNet2-baseline, you use a size 320 STFT with a 20ms window. Is there a link where I can find the pretrained ONNX model for the 512-size STFT with 32ms window? I'm working on hardware-accelerating NSNet 2 inference using Spatial, and the FFT algorithm I'm using is the efficient Cooley-Tukey algorithm which requires power-of-2 inputs. Right now I need to pad the input audio frame of size 320 by zeros to reach size 512, after which I discard redundant/useless information from the output frame DFT to get a 161-size feature vector to feed into the provided model (after computing the log-power spectrum). This wastes computation, so having access to the 512-size STFT model would be very helpful.
I can't train it myself because I don't have the compute resources or even the storage to store the training data available at the moment.

@hashemelezabi I'll check if we have that model laying around and if we can share it. Stay tuned :)

@hashemelezabi check if the new 48khz model uploaded recently works better for your needs.