Seeing white screen after leaving desktop app on standby for a while

https://mattermost.atlassian.net/browse/MM-14166
Reported by customers, this issue is for tracking. QA has a related ticket to investigate: https://mattermost.atlassian.net/browse/MM-10408. Might be network related.

I get it several times a day - I don't seem get it on Linux - error logs come up with this a lot:
Application: Mattermost 4.1.1
Platform: Windows_NT 6.1.7601 x64
Error: webContents 'crashed' event has been emitted
at WebContents.mainWindow.webContents.on (C:\Users\d2\AppData\Local\mattermost\app-4.1.1\resources\app.asar\main_bundle.js:6159:11)
at emitTwo (events.js:130:20)
at WebContents.emit (events.js:213:7)
Toggling GPU acceleration didn't seem to do anything.

So I can't get to the Javascript console (CTRL SHIFT I) - it just turns the white screen to black. The logs (USER\AppData\Roaming\Mattermost\uncaughtException-*) just repeat the message from the last post over and over.

@colchuck - Thank you for additional information - a few more questions: does this happen randomly or are there any specific repro steps to take? Is it temporary and do any steps help resolve the issue (e.g. refreshing the app)?

It happens randomly - particularly when it hasn't been touched in a while - the only thing I can do is restart the App - going View->reload flashes the Mattermost splash logo and then goes back to blank. Closing the window but keeping it in the tray doesn't work - it just comes back blank - you have to completely exit out. I have 3 x64 Windows 7 machines - two with the exact same hardware and one with older hardware. All run as unprivileged users within a domain and all experience the same issue. For whatever reason, the older machine crashes maybe a couple time a week. The two newer ones that get much more use actually crash maybe 4 times a day. I have a fourth machine with older hardware and the same software that hasn't crashed at all.

@yuya-oc FYI ^ - reporter has error logs here: https://github.com/mattermost/desktop/issues/794#issuecomment-393919550 and toggling GPU setting didn't help.
Is there any other additional information we could help gather to investigate this?

The log Error: webContents 'crashed' event has been emitted was made by our event handler. So actually a process had been dead by some reason. To notice this via a dialog, we had added the event handler. But this prevents other behavior even if the internal chromium has countermeasure against to this kind of problem.
Now I worry about that we should not handle the crashed event. The test build which doesn't use the handler is below.
https://circleci.com/gh/yuya-oc/desktop/909#artifacts
If this doesn't make sense, we might need deep debugging of electron.

Any updates on this issue? Been driving me crazy for last two versions and makes me reboot mattermost on a daily basis.

Yeah, I never got anywhere with it - my (newer) suspicion was that it was something to do with it being run as an unprivileged user - I installed it as a user on 3 Windows 7 Pro/X64 (domain environment) machines and all 3 ended up crashing randomly. The one machine that was an administrator didn't seem to have any issues - but it's also running virtualized... so that doesn't exactly narrow down possibilities. I was never able to pull anything valuable from the logs... I assumed it was an electron problem and it was a "just me" thing.

Just some random ideas: What GPU? Does your display go into power save/turn off after being idle for a while?

I have seen a similar behaviour on my Linux Box (openSUSE 42.3) w/ KDE 3.5 as well. I am running my Linux with a Nvidia GT 610 and two attached displays configured using Nvidia's technique to have one screen with 3840x1080 pixels.
Behaviour:
Whenever Mattermost (official 4.1.2 release) had been idle for some time and I receive an incoming message the following happens:

I get a blank (black) screen and the app is not even responding to "Quit"
After approx. a minute or two the client recovers and shows the normal screen and can be used as if nothing had happened

The same version of mattermost-desktop on my mac book connected to the same private mattermost server does not expose this behaviour.
I have now turned off GPU acceleration to try figuring out any relations there.

I'd like to propose you target this issue for the 4.3.0 milestone. We've been waiting a while for the many great fixes already incorporated into 4.2.0 and a Priority 2 issue such as this one shouldn't delay the 4.2.0 release (IMO).

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14166

Is this still happening for folks in v4.2.0?

Closing this as we cannot reproduce this anymore. Please report back if you still see this issue on v4.2.0.

Still seeing the issue in Version 4.2.1 (<IP_ADDRESS>)
Mac version 10.13.3 (High Sierra)
The issue happened at least 7 times within an hour and the issue happens to everyone in our team at the same time. Tried disabling the GPU acceleration and still didn't help.
The mac book was not in standby mode and it happened while replying to the message.

Hi @rakgenius, do you see any log or Console errors?

I have attached the screenshot.

I have attached the screenshot.

@rakgenius What Mattermost server version are you on?

@amyblais Sorry for the late response.. Im using the version Version 4.2.1 (<IP_ADDRESS>)

@rakgenius You can find out your server version from Mattermost > Main Menu > About Mattermost.

Hello,
For information, I have the same problem with Desktop App version 4.3.1 (server version is  "Mattermost Édition Team 5.16.3).
The log is:

Application: Mattermost 4.3.1
Platform: Windows_NT 10.0.17763 x64
Error: webContents 'crashed' event has been emitted
at WebContents.handleMainWindowWebContentsCrashed (C:\Users\userName\AppData\Local\Programs\mattermost-desktop\resources\app.asar\main_bundle.js:887:9)
at WebContents.emit (events.js:194:13)

I noticed that simply maximize the window resolves the problem (the blank screen is replaced by the expected content).
Regards,
Laurent

Same issue here, white screen after upgrading Windows desktop clients from 4.2.x to 4.3.1.

Only occurs when upgrading, not on clean installs of 4.3.1.
Deleting appdata\local\mattermost solves the problem
Deleting the 3 cache folders in appdata\local\mattermost doesn't solve the problem
Resizing the window or exiting, then opening Mattermost again fixes the problem
Closing the window, then opening the window from the tray icon doesn't fix the problem
Disabling GPU acceleration makes no difference
Only happens when users first login, happens every time
Console doesn't list any errors

Same issue. Had 4.2.1 for a very long time and no problem at all. Upgraded to 4.3.1 and after a restart of the PC I now have a white screen.

Same issue. Had 4.2.1 for a very long time and no problem at all. Upgraded to 4.3.1 and after a restart of the PC I now have a white screen.
Maximizing the window solves the problem.

I can't believe that actually worked for me. Many thanks.

Should be fixed in v4.3.2, are we okay to close this issue? cc// @amyblais

Closing as per above.

@amyblais I was running v5.0.2 with no issues on my Windows 10 machine. Just upgraded to Windows 11. When I open MM, it initially shows the normal display with all of our teams and channels, but the entire screen goes white as soon as I move my mouse cursor. Have tried every troubleshooting step that I can think of and the same thing keeps happening. Not really sure what to do at this point - like so many others, I basically can't work without MM. Any help would be greatly appreciated.

@kipjunes Would you be open to creating a new issue with details at https://github.com/mattermost/desktop/issues?

Sure thing @amyblais will do so now


Minor Tweaks to eslint-config-leankit based previous implementation

Minor Tweaks to eslint-config-leankit based on lessons learned when integrating the rules into nonstop-index-ui
Turned off the following rules

react/jsx-handler-names - it turns out this is problematic when using lux actions directly
no-extra-parens - make this a trial rule as grouping can help make code clearer and it can conflict with the react/wrap-multilines rule making an override necessary
react/jsx-boolean-value - it is redundant to enforce this rule
no-param-reassign - this is done frequently and the fix bloats the code
no-eq-null - this edgecase is infrequent and != null to indicate null and undefined is nice
newline-after-var - this is done frequently and feels very nit picky

Update the following rules

react/sort-comp - swap getActions/getActionGroup and stores
react/jsx-quotes is deprecated and should use jsx-quotes instead

Turn all warnings into errors
Warnings should just be considered as errors.

no-console
react/sort-comp

There are 4 remaining TRIAL rules
These rules are marked as // TRIAL in this repo and it is up to the consumer to turn these rules on and experiment with their options. If we come to an agreement on these rules then they'll be turned on in a future update.

complexity
arrow-body-style
no-negated-condition
no-extra-parens

@elijahmanor I think no-console needs to be kept as a warning, or else our projects won't build when we intentionally add debug console statements. Is there another workaround I am not thinking about here?


CLI arguments are not passed along when loading config from file

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
CLI arguments are not passed along when loading config from file:
loadFromFile accepts a second argument argv:
https://github.com/facebook/jest/blob/master/packages/jest-config/src/loadFromFile.js#L17
which is not passed when executing loadFromFile:
https://github.com/facebook/jest/blob/master/packages/jest-config/src/index.js#L37
What is the expected behavior?
Whether loading config from file, object or package, CLI arguments should always be passed along:

https://github.com/facebook/jest/blob/master/packages/jest-config/src/index.js#L43
https://github.com/facebook/jest/blob/master/packages/jest-config/src/index.js#L47

Thank you, nice catch!
@cpojer do you think we we need a test for that, or maybe it will be sufficient to add typings to loadFromFile and make second argument mandatory?

Let's move the discussion to related PR


Cannot resolve 'file' or 'directory' in Gulp

I was wondering why it can not resolve file and directory when i add the js entries in the config.json
it does not resolve any js file in the js-lib folder
"js-lib": ["./**/*.js"] or
"js-lib": ["./js-lib/*.js"]

Se example
"js": {
"src": "javascripts",
"dest": "javascripts",
"extractSharedJs": true,
"entries": {
"app": ["./app.js"],
"page": ["./page.js"],
"site": ["./site.js"],
"views": ["./views.js"],
"js-lib": ["./**/*.js"]
},
"extensions": ["js"]
},
It is probably more a question than an issue
I have noticed that there is not a gulp build js in the gulp starter, but we have the css though.
Thanks for the massive work

I don't think you can use glob patterns there... they have to be explicit paths. http://webpack.github.io/docs/configuration.html#entry
the webpackWatch and webpackProduction tasks are what get used for building JS.


[Excel] (Custom functions) Link fix

Docs Build status updates of commit 8d82375:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 53ea98b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-architecture.md
:white_check_mark:Succeeded

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded

docs/excel/custom-functions-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-save-state.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Improved code to add support to select facility location during receiving(#28zt2u3)

Related Issues

Closes #
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

Closing because this work is done in following PR: https://github.com/hotwax/receiving/pull/89


(tensorflow) C:\Users\Anurag sharma\Desktop\project\subclass_classifier\labelImg>pyrcc5 -o resources.py resources.qrc 'C:/Users/Anurag' is not recognized as an internal or external command, operable program or batch file.

OS: Windows 10
PyQt version: 5

I got the same issue. May be its because our system username contain spaces in it
(testgpu) C:\Users\DANIA NIAZI\labelImg-master>pyrcc5 -o "resources.py" "resources.qrc"
'C:/Users/DANIA' is not recognized as an internal or external command,
operable program or batch file.

the problem is probably the space in your user folder


Updating Summary.md with proper links

Going through some of the docs, I noticed that the links were out of date and I would receive a 404.
This PR hopefully adjusts the docs to proper pointers / markdown files.

Thanks for the PR. I'll review as soon as I can.

I navigated the entire documentation and I didn't not get any 404s, but I did find some issues and missing documentation I'll add in a separate PR.


fix oracle ep regex parsing error

#3073

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.neo.chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Explain the difference between sequential method calls.

[ ] Place it in the FAQ.

Superseded by #627


Instruction on how to deploy to disconnected CF

Added instructions on how to deploy to an Cloud Foundry which has no internet access.
cc @pmilewsk

Hi, Ruben. Sorry for the long delay. I made some suggestion how to improve the readme. Before I'm able to merge that you should also rebase (with squash) the branch with master and bump up the version in package.json file. Or I can do that for you, just let me know, please. Thanks for your contribution.


Fixing dragging related issue

Description
Fixing dragging issue reported in https://github.com/rethinkdb/rethinkdb-desktop/issues/46
Issue
With a PR about an improvement in electron, accidentally they introduced a side effect: if the title bar is set to hidden or hiddenInset, the window can not be moved anymore. The workaround is suggested on electrons own GitHub repo (listed below) with the more detailed description of the issue (below as well).
Resources
Recommendation of electron how to mitigate this problem.
Known issue by electron about devtools and draggable window: https://github.com/electron/electron/issues/3647

Sorry for not providing more details for the first time. I was so happy that fixed this issue :smile:

@sagivf can I merge this?

@gabor-boros Sorry for the delay, Works well on my machine - go ahead and merge


Add pyproject.toml to Python.gitignore

Pull Request
Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New

[ ] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[X] Template - Update existing .gitignore template

Details
Add pyproject.toml to Python.gitignore

heya! as a pythonista, this feels weird. pyproject.toml is not meant to be in .gitignore. it's like Cargo.toml.


Fixes #80

self.view.file_name() contains backslash on Windows instead of forwardslash
I guess everyone on windows should be having this issue?

Thank you!


Tracing : tracing/tracer value is  in KV storage

Do you want to request a feature or report a bug?
Bug
What did you do?
Activated the tracing for containous/traefik:experimental.
Config stored in KV.
What did you expect to see?
Traefik up & running, sending trace.
What did you see instead?
Traefik not running.
In KV storage : traefik/tracing/tracer value is <nil>
Output of traefik version: (What version of Traefik are you using?)

Traefik container (containous/traefik:experimental) running in rancher using metadata and consul storage.
--accessLog,--api,--api.statistics,--api.statistics.recenterrors=10,--consul,--consul.endpoint=consul:8500,--consul.prefix=traefik,--defaultentrypoints=http,https,--entrypoints=Name:http Address::80,--entrypoints=Name:https Address::443 TLS,--loglevel=ERROR,--ping,--rancher,--rancher.exposedbydefault=false,--rancher.metadata=true,--traefiklog,--tracing,--tracing.backend=jaeger,--tracing.jaeger,--tracing.jaeger.localagenthostport=jaeger:6832,--tracing.jaeger.samplingserverurl=http://jaeger:5778/sampling

If applicable, please paste the log output in debug mode (--debug switch)
time="2018-02-22T14:01:27Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 349.052216ms"
time="2018-02-22T14:01:27Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 639.063674ms"
time="2018-02-22T14:01:28Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 1.125138197s"
time="2018-02-22T14:01:30Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 1.545748625s"
time="2018-02-22T14:01:32Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 2.024578743s"
time="2018-02-22T14:01:34Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 3.779199929s"
time="2018-02-22T14:01:38Z" level=error msg="Load config error: 1 error(s) decoding:\n\n* 'Tracing.Tracer' expected type 'opentracing.Tracer', got 'string', retrying in 6.3740884s"

More informations : If I delete the key traefik/tracing/tracer in KV, traefiks runs and displays
2018/02/22 14:01:13 logger.go:48: Reporting span 2c9c22a5e997734c:2c9c22a5e997734c:0:1
2018/02/22 14:01:14 logger.go:48: Reporting span 2af3d03023026aba:5334884f105b59:2b2d3efcde01e718:1
2018/02/22 14:01:14 logger.go:48: Reporting span 2af3d03023026aba:2b2d3efcde01e718:2af3d03023026aba:1
2018/02/22 14:01:14 logger.go:48: Reporting span 2af3d03023026aba:2af3d03023026aba:0:1

But no traces are sent


fix(explore): Chart save modal displays error instead of failing silently

SUMMARY
When user tried to save a chart and a request executed by SaveModal chart failed, the modal would just close and there would be no indication that an error occurred. That might lead the user to think that their chart was successfully saved even though it wasn't.
This PR fixes that behaviour by not closing the modal and displaying an alert with error message within it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/15073128/197514948-a996021b-bd5d-4939-aee5-c9f23c34b2d6.mov
After:
https://user-images.githubusercontent.com/15073128/197514625-2667b4fe-519b-4313-be65-58e00a31c66f.mov
TESTING INSTRUCTIONS

Open the chart save modal
Turn off the Internet (to trigger an error)
Click save button
See that the error is displayed and the modal doesn't close

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

CC @codyml

/testenv up

Hey @kgabryje I think I am noticing a weird behaviour when saving the chart as a new one. After saving the chart shows the empty state.
https://user-images.githubusercontent.com/60598000/197768634-56288be1-d1d8-40c4-80c7-6eb7d5f57c27.mp4

@geido @codyml Thank you for your feedback and testing! I fixed the issue with chart disappearing after saving.
The problem was a race condition between re-hydrating explore after saving and triggering query. Because of some strange flows in the code, delaying closing the save modal was causing the query to be triggered before Explore was rehydrated. The result was that the query was updating the previous chart (previous slice_id), instead of the freshly created one.
I fixed this issue by moving the logic responsible for detecting saving from URL (we were reading saveaction search parameter in the URL to decide if query needs to be triggered) to Redux (which is now being set by hydrateExplore, so now the correct order of actions is ensured).
https://user-images.githubusercontent.com/15073128/197980861-9190ccc0-9dfe-4a71-9778-ba481d75fc9c.mov

I think the loading indicator is still left-justified

Oops, I didn't notice your first comment. Fixed 🙂

I noticed that the overwrite/saveas toggle is now sticky on the same chart, so if you open a chart that you don't have permission to overwrite and save it as a new chart, the next time you go to save it'll still be on Save As, whereas previously I think it would always default to Overwrite if you had permissions.  Do we want to maintain that previous behavior?

Well spotted! 🙏 Fixed

/testenv up


md5: remove fallback implementation

it is also possible to use Apple CommonCrypto MD5 if openssl is missing:
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/CC_MD5.3cc.html

Had the same idea but it looks like CC_MD5 is deprecated https://developer.apple.com/forums/thread/119872 with iOS 13 and macOS 10.15


online demo is not work

yes，one month ago is ok  ，now i watch it is not work  too

@liqiushui @YuWeigang
Hello, it work normally, now.   Due to the launch of our new services, our online demo may gradually be phased out.


Using SSL

Has anyone managed to get a java etcd client to use SSL, and if so, how?
I have generated self-signed certificates (ca, server, and client) that work fine with etcdctl (with etcd3) but cannot get it to work with netty-tcnative from java. I always get the following:
io.netty.handler.ssl.OpenSslEngine - SSL_read failed: OpenSSL error: error:10000412:SSL routines:OPENSSL_internal:SSLV3_ALERT_BAD_CERTIFICATE

This was happening with netty-tcnative-boringssl-static 1.1.33.Fork23. Once I switched to netty-tcnative-boringssl-static 1.1.33.Fork19 the problem disappeared.

Hello,
How did you setup jetcd with SSL? I can't find anything in the javadoc of the project nor on it's online documentation.
I need to do client-auth with TLS certificates. I know how to build a properly configured netty channel but I can't find how to pass it to jetcd.
If you have some time to recall how you did it, it would be wonderful!

@lburgazzoli do you want to help with this issue?

As far as I know as today jetcd forces plain text in managed channel creation so to properly support ssl the client builder should allow to pass a SslContext.
@eho-eho do you mind sharing the instructions to set up etcd/etcdctl with ssl so I can try to work on it ?

It has been a while since I looked at this. Also, I am not working on that project and have no access to the source code, so everything I write here is from memory.
Re setting up etcd/etcdctl:
For setting up etcd/etcdctl follow instructions on etcd documentation site. Instructions for etcd2 should suffice if there are none for etcd3.
Re ssl and jetcd:
I have not used jetcd with ssl. I wrote my own client following instructions on grpc's site. The only gotcha was to use the version and the fork of netty-tcnative that the version of grpc I was using is tested with. For that I had to look at the grpc source.
That's all I remember. Hope this is helpful.

@eho-eho Hello, have you succed in  used jetcd whit ssl?

@yangliucheng  have you succeed in used jetcd with ssl

 etcdctl --cacert /etc/etcd/ssl/etcd-ca.pem --cert /etc/etcd/ssl/etcd.pem --key /etc/etcd/ssl/etcd-key.pem get /hello  is ok
only pkcs8 in jetcd-0.0.2
openssl pkcs8 -topk8 -nocrypt -in etcd-key.pem -out pkcs8-key.pem
File cert = new File("E:\\softwarelocation\\code\\IdeaProjects\\etcdstudy\\src\\main\\java\\v3api\\etcd.pem");
 File pkcs8Key = new File("E:\\softwarelocation\\code\\IdeaProjects\\etcdstudy\\src\\main\\java\\v3api\\pkcs8-key.pem");
Client client = Client.builder()
                .endpoints("https://<IP_ADDRESS>:2379")
                .sslContext(GrpcSslContexts.forClient()
                        .trustManager(cert)
                        .keyManager(cert, pkcs8Key)
                        .build())
                .build();

CompletableFuture<GetResponse> getResponseCompletableFuture = kvClient.get(ByteSequence.fromString(key));
        GetResponse getResponse = getResponseCompletableFuture.get();
        List<KeyValue> kvs = getResponse.getKvs();
        for (KeyValue kv : kvs) {
            System.out.println("key=" + kv.getKey().toStringUtf8());
            System.out.println("value=" + kv.getValue().toStringUtf8());
        }

 //etcd V3 api
    compile group: 'io.netty', name: 'netty-handler', version: '4.1.27.Final'
    compile group: 'io.grpc', name: 'grpc-all', version: '1.15.1'
    compile group: 'io.netty', name: 'netty-tcnative-boringssl-static', version: '2.0.12.Final'
    compile group: 'com.coreos', name: 'jetcd-core', version: '0.0.2'

public class AppTest {
    @Test
    public void testThis() throws ExecutionException, InterruptedException, SSLException {
        Client client = Client.builder().endpoints("https://hostn:2379")
                              .user(ByteSequence.from("bob".getBytes()))
                              .password(ByteSequence.from("sekrit".getBytes()))
                              .authority("sp-etcd01") // Must be a SAN in server cert if hostn is not in cert
                              .sslContext(GrpcSslContexts.forClient().trustManager(new File("certs.pem")).build())
                              .build();
        KV kvClient = client.getKVClient();

        ByteSequence key = ByteSequence.from("/com/acme/static/foo".getBytes());
        CompletableFuture<GetResponse> getFuture = kvClient.get(key);
        GetResponse response = getFuture.get();

        System.out.printf("foo=%s\n", new String(response.getKvs().get(0).getValue().getBytes()));
    }
}

The POM
    <dependencies>
        <dependency>
            <groupId>io.etcd</groupId>
            <artifactId>jetcd-core</artifactId>
            <version>0.5.3</version>
        </dependency>
        <dependency>
            <groupId>io.netty</groupId>
            <artifactId>netty-tcnative-boringssl-static</artifactId>
            <version>2.0.28.Final</version>
            <scope>runtime</scope>
        </dependency>
        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <version>4.12</version>
            <scope>test</scope>
        </dependency>
    </dependencies>


⚠ SceneTime has degraded performance

In 3e25ae7, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1675 ms

Resolved: SceneTime performance has improved in 55a8468 after 11 minutes.


Some functional keys are not passed to the guest systems

Some functional keys are not passed to the guest systems. For example, KolibriOS uses:
WIN key to open the "Start Menu". When this key is pressed right now, the "Start Menu" opens in the host system (Windows)
F5 key to copy files from one folder to another in the file managers. When this key is pressed right now, browser just reloads the page
ALT+TAB to switch between opened windows. When this key is pressed right now, it switches between windows in the host system.
All this happens even in "Full Screen" mode. I suggest that those keys are either passed to guest system (at least in Full Screen" mode it makes sense), or they are added to the buttons above the guest (similar to "Send CTRL+ALT+DEL" that is there now).

I'll send F5 to the emulator and block page refresh for now, unless someone complains.

Thank you very much - I really appreciate that! I don't think many people will complain, since they always can use "Reset" button which essentially does the same as pressing F5.

I have tested your changes right now on your website:Disabling F5 key works great (behaves as expected)
WIN key now opens the "Start Menu" in the emulator, but it still opens the "Start Menu" in the host system (Windows) at the same time. So unfortunately it's still unusable (as host system "Start Menu" hides the emulator screen).
ALT+TAB works strange. It seems that pressing "Send ALT+TAB" button only sends the button press, but doesn't send button release. So the emulator thinks that ALT+TAB combination was never released.
Hope this test report is helpful for you!

It doesn't seem to be possible to block the Start Menu in Windows – there's nothing I can do (except adding another button for it).
A release code is sent for alt-tab. Possibly there needs to be a delay between the keydown and keyup.

Regarding ALT+TAB - I have 0 knowledge in JS, but I have taken a look at your code:
ps2.kbd_send_code(0x38); // alt
ps2.kbd_send_code(0x0F); // tab
ps2.kbd_send_code(0x38 | 0x80);
ps2.kbd_send_code(0x0F | 0x80);
There could be a few reasons why that code doesn't work:You send 2 scancodes (one for ALT, second for TAB). Some websites (although not all) mention that ALT+TAB pressed together has a single special scancode (different from scancodes for ALT or TAB pressed separately): 0xA5: http://www.freepascal.org/docs-html/rtl/keyboard/kbdscancode.html
If websites mentioned in (1) are wrong, then the order for key_up should be reversed: first release TAB and then release ALT (like you do yourself when you work).

The link in (1) is a different kind of scancode, I guess used in Pascal. For the record, PS2 scancodes can be found here: http://stanislavs.org/helppc/make_codes.html
(2) is makes sense, I'll change it to work that way.

I have retested ALT+TAB again in KolibriOS, and it's working fine now, thank you!


Malformed waypoints for agents using Mission and EndlessMission in Argoverse maps

After PR #1923, some waypoints appear malformed in Argoverse maps.
Waypoints appear malformed differently in agents using "Mission" compared to agents using "EndlessMission". Preferably, agents using "Mission" and "EndlessMission" should generate waypoints in the same manner, with the exception of agents using "EndlessMission" should get all legal waypoints at each time point whereas agents using "Mission" should only get the waypoints leading to the goal at each time point.
A sequence of images showing malformed (i) social agent waypoints using "Mission" and (ii) ego agent waypoints using "EndlessMission", is shown below in Argoverse map c624608b-fd20-43c9-bc2c-c4181ce9dafa.

Social agent waypoints in the current lane stops abruptly and does not branch to the south, but ego agent waypoints does branch to the south.

Social agent waypoints depict a wierd shape like "7" in the intersection.

Ego agent waypoints pointing straight ahead in the current lane disappears and instead waypoints pointing to a left-turn appears. This happens for exactly one time step, after which the left-turn waypoints disappears and the waypoints pointing straight ahead reappears. Two consecutive images are shown below depicting this phenomenon. The embedded rgb images, in each image below, show three consecutive time points.

For the first issue of the social agent with a Mission, the waypoints/route generation are actually "correct", but they look a bit strange because of the road structure. See the below image:

Road 1 branches off into roads 2 & 3, which each connect into road 4, which has 2 lanes. The route planner has to pick a single path, so goes with road 2. It then generates waypoints on road 4 connecting to the correct exit lane to reach the goal in the southbound road. The "7" shape is a consequence of driving straight through the intersection instead of following the waypoints to the south.
The key thing here is that waypoints for missions are tied to a path of roads leading from the start to the end, so you should not expect it to generate waypoints for all possible paths (like the ego here). If you want to constrain the path to use certain roads, you can add via points.
We could think about supporting multiple routes in the pathfinder, but that would be another issue.

Everything remains the same and up to date with the current master branch. The only exception being the contents of the file smarts/core/argoverse_map.py was reverted to that prior to PR #1923. We then get the following which is what one would normally expect. The result appears to be different after PR #1923.

Yes, this is because previously road 4 would be split up into 2 separate roads. This constrains the route to be made up of 1-lane roads, which looks more "correct" in this case, but is just a result of less options for the path. The change is necessary to correctly infer roads of multiple lanes. Routefinding and traffic flows would not behave correctly without it. If you need the route to take that specific path, you can use via points in the mission.


pip install fails on NVIDIA XAVIER

ath.hpp:47:12: fatal error: x86intrin.h: No such file or directory
#include <x86intrin.h>
^~~~~~~~~~~~~
compilation terminated.
error: command 'aarch64-linux-gnu-gcc' failed with exit status 1
ERROR: Failed building wheel for segmentation

Hi @pdavis39, thanks for the report.
I was able to recreate the problem on an rpi and am working on a solution.
M


Node approval process design

Gaia Lite trusts block headers if 2/3 of the signatures stay the same. The headers get updated when a user uses Gaia Lite. The headers might run out of sync when a user is a long time not using Gaia Lite/Voyager. We need to design a process how:

a user declares an initial trusted block header
a user sets (automatically or manually) a new trusted block header if the signature diff is over 1/3

We had a long conversation about this in a UI/UX meeting.  I proposed that Voyager query, e.g., 100 nodes and if it gets back consistent block headers from a certain threshold, e.g. 80%, then it trust the headers.  IIRC @jbibla and @nylira liked the idea.

@NodeGuy yep!
this would be better than requiring the user to find a validator hash and enter it into the modal.

Is this a duplicate of #1036?

i think so


Static fields

The Java source is

while the generated Objective C code is

I downloaded "j2objc-1.0.1.zip" today and it appears that the file "J2ObjC_common.h" does not contain the "J2OBJC_STATIC_FIELD_GETTER" micro (setter as well) while the old "j2objc-<IP_ADDRESS>.1.zip" did. Any reason why it was removed?

What is the resolution to fix this issue?

The generated Objective-C code in this issue likely was generated with an older version of j2objc and compiled against a newer runtime library. J2ObjC generation is designed to be a part of the build process and translated code must always be generated with the same version as the runtime it's being compiled against.

OK I thought I had changed this but I would not be surprised if I missed
something. Will check again this evening
On Wed, 18 May 2016 at 14:40 Keith Stanger<EMAIL_ADDRESS>wrote:

The generated Objective-C code in this issue likely was generated with an
older version of j2objc and compiled against a newer runtime library.
J2ObjC generation is designed to be a part of the build process and
translated code must always be generated with the same version as the
runtime it's being compiled against.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/713#issuecomment-220013688

Found it - I hadn't updated what J2Objc build was on my path. Thanks for
the pointer and thanks for the tool!
On Wed, 18 May 2016 at 14:56 Alex Curran<EMAIL_ADDRESS>wrote:

OK I thought I had changed this but I would not be surprised if I missed
something. Will check again this evening
On Wed, 18 May 2016 at 14:40 Keith Stanger<EMAIL_ADDRESS>wrote:

The generated Objective-C code in this issue likely was generated with an
older version of j2objc and compiled against a newer runtime library.
J2ObjC generation is designed to be a part of the build process and
translated code must always be generated with the same version as the
runtime it's being compiled against.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/google/j2objc/issues/713#issuecomment-220013688


SeqChunker error

Hi @thackl,
I'm encountering an issue very similar to #5 where proovread is unable to locate SeqChunker-perl.
However, after recreating the symlink as well as using the quick and dirty workaround of directly copying SeqChunker-perl to proovread/bin/ it still isn't able to locate it and I don't know what working directory its attempting to call it from. Maybe this stems from the readlink command instead? Here's the repeated error message:
readlink: illegal option -- f
usage: readlink [-n] [file ...]
Can't open perl script "./SeqChunker-perl": No such file or directory

Finally resulting in:
12:30:13] No sequences found matching given filter criteria
Use of uninitialized value $c in ord at /Users/Connor/bin/proovread/bin/../lib//Fastq/Parser.pm line 355.
Use of uninitialized value $c in string eq at /Users/Connor/bin/proovread/bin/../lib//Fastq/Parser.pm line 359.
[16-02-26 12:30:13] [siamaera] Input neither FASTA nor FASTQ

This is a different computer than what I was running in a previous issue, running Mac10.6.8 and perl version 5.18. Let me know if you need any more information.
Thanks for your help.

Hi,
you are probably right with the readlink problem. I am not that familiar with MacOS, I assigned the issue to my colleague Frank -  he fixed the Mac related issue last time.
Cheers
Thomas

I am sorry, not to response earlier. Indeed it is a problem with readlink. The Linux version of readlink supports the parameter -f while the MacOS/BSD readlink does not. I created and preapred a fix for that issue, which should be integrated into the next proovread release.

The new version 0.4 of SeqChunker is supporting MacOSX, therefore this should resolve that issue. @thackl needs to approve the pull request, afterwards version 2.12.13 of proovread should work on Macs. @cmorganl are you able to run a test on your sequence data after the merge into our master branch? Just make sure you are using at least version 2.12.13 of proovread.
Let me know, if that solves your problem.
Best,
Frank

Hi @greatfireball, I'm still experiencing an issue running Mac 10.6.8. The initial error has been fixed but another has cropped up. Here is the stdout:
/Users/Connor/bin/proovread/bin/SeqChunker --chunk-number 100000 --chunk-step 2\
0 --chunks-per-step 8 --first-chunk 1 /Volumes/CAPTAIN/Hallam_projects/MAP_proj\
ects/RawData/Sakinaw_Lake/Sakinaw_Lake_Illumina_120m.fastq | /Users/Connor/bin/\
proovread/bin/../util/bwa/bwa-proovread mem -b 50 -l 250 -Y  -L 30,30 -a  -E 4,\
3 -r 1 -A 5 -T 2.5 -O 2,1 -t 8 -w 40 -W 20 -y 20 -B 10 -D 0 -k 12 SakinawLake_1\
20mMay2011_allD/read-long/SakinawLake_120mMay2011_allD.masked.fa /dev/fd/0 2>Sa\
kinawLake_120mMay2011_allD/bwa-sr-1/SakinawLake_120mMay2011_allD_bwa.log | /Use\
rs/Connor/bin/samtools-1.1/samtools view -@ 8 -bS /dev/fd/0 >SakinawLake_120mMa\
y2011_allD/bwa-sr-1/SakinawLake_120mMay2011_allD_tmp.bam
#------------------------------------------------------------------------------#
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
/Users/Connor/bin/proovread/bin/SeqChunker: line 17: : No such file or directory
/Users/Connor/bin/proovread/bin/SeqChunker: line 23: : No such file or directory
cat: : No such file or directory
/Users/Connor/bin/proovread/bin/../util/SeqChunker/bin/SeqChunker
rm: : No such file or directory
FILE should be located at '/Users/Connor/bin/proovread/bin/../util/SeqChunker/bin/SeqChunker'

SakinawLake_120mMay2011_allD/bwa-sr-1/SakinawLake_120mMay2011_allD_bwa.log contains the two lines:
[M::bwa_idx_load_from_disk] read 0 ALT contigs
[M::main_mem] read 533334 sequences (80000100 bp)...

Let me know if you need futher information.

hiii
when i'm trying to split my data(1.5gb)  and  it is showing that,
SeqChunker -s 1G -o mapped.reds.pac.fa mapped.reds.pac-subreads.fq
SeqChunker: command not found
Need help. i'm using ubuntu 14.04

Try to call SeqChunker with its complete path /path/to/SeqChunker -s 1G .... Does that work?

No...!! Showing like
FILE should be located at '/home/Documents/Tools_NGS/proovread/bin/../util/SeqChunker/bin/SeqChunker'

Does the SeqChunker file exist at the location it says above?

yes. It is there. but the folder shows a lock image.

Hm, no idea what the lock means. The "File should ..." message itself is not an error, just a log message. Here is how things look like when I run SeqChunker
~/software/proovread/util/SeqChunker/bin/SeqChunker -n 2 foo.fa
FILE should be located at '/home/thackl/software/proovread/util/SeqChunker/bin/SeqChunker'
Reading foo.fa
>seq-shit
ATTAGTCTCACAATATTCGATAGTTTAAGTAGGACAGTAGCTGCAGAGAGGACCCAGCTATCGATTTTGCGACGAGAGCC
TCGCCGTGGTATTGCTTCTGAAAGGGGGTAGGGTTCCCATATGTTAACTGCAAAGGCAACTAACCTTGGGTCAATCCTCT
CTCTGAATCCGCATATAATAGAACCCCAAATTGTTTGAATTTTAGGTGGTCGGCAACCCCGCTACACTAATATGACATCA
...

Have you tried it with a fasta/fastq file?

I tried with fastq file about size of 1.7 gb. Then i skipped the seqchunker step and run proovread directly.
But, it also stopped after few hours and showing like,

[Tue Apr  2 04:16:36 2019] bam2cns unexpectedly returned
Exited at 'main'
'/home/Documents/Tools_NGS/proovread/bin/proovread', line 1636
Last call 'main::correct_sr_mt'
'/home/Documents/Tools_NGS/proovread/bin/proovread', line 868

Command used is given below..
**> /home/Documents/Tools_NGS/proovread/bin/proovread
-l pacbio.fa -s /media/TOSHIBAEXT/illumina/R1.fastq -s /media/TOSHIBAEXT/illumina/R2.fastq -t 20 --overwrite -p pacbio_corrected

**
Could you please have look into this issue.Thank you.

OK, this won't work because proovread also uses SeqChunker internally. However, I don't think that the error you got from bam2cns is even related to this. To really be able to help you I need some more information. How did you install proovread in the first place, did you just copy and paste from the install instructions? Did you move the folder with the files afterwards? And could you attach the complete log output of the crashed run? And lastly, have you tried to run proovreads example dataset cd proovread; make sample?

I've installed from the root by using 'sudo' command and didn't move any files from the proovread folder.Also used 'make sample' command.but,it ran smoothly without showing any error messages.Please find the attached log file.Thank you.

home@home-Lenovo-H30-50:~/Documents/Tools_NGS/proovread$ /home/Documents/Tools_NGS/proovread/bin/proovread -l chloro.pacbio.fa -s /media/TOSHIBAEXT/chloroplast_reads/illumina/R1.fastq -s /media/TOSHIBAEXT/chloroplast_reads/illumina/R2.fastq -t 40 --overwrite -p pacbio_proovread
[Tue Apr  2 15:01:23 2019] Running proovread-2.14.1 under Perl 5.18.2
[Tue Apr  2 15:01:23 2019] Reading core config
[Tue Apr  2 15:01:23 2019] Reading command line options
[Tue Apr  2 15:01:23 2019] Logging parameter to pacbio_proovread/pacbio_proovre ad.parameter.log
[Tue Apr  2 15:01:23 2019] Checking short read files

R1.fastq
Detected FASTQ format
Estimated short read length: 150 +-0
Etimated short read quality offset: 33
Estimating approximate number of short reads: 5.09M
R2.fastq
Detected FASTQ format
Estimated short read length: 150 +-0
Etimated short read quality offset: 33
Estimating approximate number of short reads: 5.09M
[Tue Apr  2 15:02:29 2019] Checking required binaries
[ok] samtools-1.7    /usr/local/bin
[ok] bwa-proovread   /home/Documents/Tools_NGS/proovread/bin/../util
/bwa
[ok] blastn-2.7.0    /usr/local/bin
[Tue Apr  2 15:02:29 2019] Running mode: sr
[Tue Apr  2 15:02:29 2019] Preparing long reads
Skipped 2454 stubby reads with length <300
#------------------------------------------------------------------------------#
perl -I/home/Documents/Tools_NGS/proovread/bin/../lib/ /home/Doc
uments/Tools_NGS/proovread/bin/SeqFilter --fasta --in pacbio_proovread/read-
long/pacbio_proovread.fq --line-width 80 --lower-case --out pacbio_proovread/re
ad-long/pacbio_proovread.masked.fa --phred-offset 33
[15:03:19] /home/Documents/Tools_NGS/proovread/bin/SeqFilter-1.06
[15:03:19] --in: pacbio_proovread/read-long/pacbio_proovread.fq
[15:03:19] Detected FASTQ format, phred-offset 33
2.27G [=========================================================>] TTS 00:00:15
#------------------------------------------------------------------------------#
[15:03:34] Input
[15:03:34] Sequences           132092 #
[15:03:34] Total<PHONE_NUMBER> bp
[15:03:34] Longest              47305 bp
[15:03:34] Shortest               300 bp
[15:03:34] N50                  12828 bp
[15:03:34] N90                   4862 bp
#------------------------------------------------------------------------------#
[15:03:34] Filtered
[15:03:34] Sequences           132092 #
[15:03:34] Total<PHONE_NUMBER> bp
[15:03:34] Longest              47305 bp
[15:03:34] Shortest               300 bp
[15:03:34] N50                  12828 bp
[15:03:34] N90                   4862 bp
#------------------------------------------------------------------------------#
#------------------------------------------------------------------------------#
#------------------------------------------------------------------------------#
perl -I/home/Documents/Tools_NGS/proovread/bin/../lib/ /home/Doc
uments/Tools_NGS/proovread/bin/ccseq --bwa-path /home/Documents/Too
ls_NGS/proovread/bin/../util/bwa/ --threads 40 --pre pacbio_proovread/ccs-1 <pa
cbio_proovread/read-long/pacbio_proovread.fq | tee pacbio_proovread/ccs-1/pacbi
o_proovread.fq | perl -I/home/Documents/Tools_NGS/proovread/bin/../lib
/ /home/Documents/Tools_NGS/proovread/bin/SeqFilter --line-width 80 --
phred-offset 33 --phred-mask 20,41,120,195,60,0.7 --fasta --out pacbio_proovrea
d/ccs-1/pacbio_proovread.masked.fa --base-content N --tsv - --quiet
[19-04-02 15:03:35] [ccseq] Reading STDIN
[19-04-02 22:21:36] [ccseq] Processed 132101 subreads from 109127 reads
[19-04-02 22:21:36] [ccseq]   18678 consensus + 90449 bypassed single subreads
#------------------------------------------------------------------------------#
[Tue Apr  2 22:21:53 2019] Running task bwa-sr-1
[Tue Apr  2 22:21:53 2019] Indexing Long reads
#------------------------------------------------------------------------------#
/home/Documents/Tools_NGS/proovread/bin/../util/bwa/bwa-proovread inde
x pacbio_proovread/ccs-1/pacbio_proovread.masked.fa pacbio_proovread/ccs-1/pacb
io_proovread.masked.fa 2>pacbio_proovread/bwa-sr-1/pacbio_proovread_bwa.log
#------------------------------------------------------------------------------#
[Tue Apr  2 22:35:09 2019] Mapping reads /media/TOSHIBAEXT/chloroplast_re ads/illumina/R1.fastq /media/TOSHIBAEXT/chloroplast_reads/illum ina/R2.fastq
#------------------------------------------------------------------------------#
/home/Documents/Tools_NGS/proovread/bin/SeqChunker --chunk-number 1000
--chunk-step 20 --chunks-per-step 6 --first-chunk 1 /media/TOSHIBAEXT/ch
loroplast_reads/illumina/R1.fastq /media/TOSHIBAEXT/chloroplas
t_reads/illumina/R2.fastq | /home/Documents/Tools_NGS/proov
read/bin/../util/bwa/bwa-proovread mem -b 20 -l 300 -W 20 -L 30,30 -O 2,1 -T 2.
5 -k 12 -D 0 -Y  -a  -E 4,3 -A 5 -B 11 -r 1 -t 40 -y 20 -w 40 pacbio_proovread/
ccs-1/pacbio_proovread.masked.fa /dev/fd/0 2>pacbio_proovread/bwa-sr-1/pacbio_p
roovread_bwa.log | samtools view -@ 40 -bS /dev/fd/0 >pacbio_proovread/bwa-sr-1
/pacbio_proovread_tmp.bam
#------------------------------------------------------------------------------#
/home/Documents/Tools_NGS/proovread/bin/../util/SeqChunker/bin/SeqChunker
FILE should be located at '/home/Documents/Tools_NGS/proovread/bin/../util/SeqChunker/bin/SeqChunker'
Reading /media/TOSHIBAEXT/chloroplast_reads/illumina/R1.fastq
Reading /media/TOSHIBAEXT/chloroplast_reads/illumina/R2.fastq
Killed
[Tue Apr  2 23:22:52 2019] Sorting BAM pacbio_proovread/bwa-sr-1/pacbio_proovre ad.bam
#------------------------------------------------------------------------------#
samtools sort -m 2G -@ 21 -T pacbio_proovread/bwa-sr-1/pacbio_proovread_tmp -o
pacbio_proovread/bwa-sr-1/pacbio_proovread.bam pacbio_proovread/bwa-sr-1/pacbio
_proovread_tmp.bam
#------------------------------------------------------------------------------#
samtools sort: couldn't allocate memory for bam_mem
#------------------------------------------------------------------------------#
samtools sort failed: 256
Exited at 'main'
'/home/Documents/Tools_NGS/proovread/bin/proovread', line 1343
Last call 'main::create_sorted_bam'
'/home/Documents/Tools_NGS/proovread/bin/proovread', line 865

Ah, ok, that helps. Your actual problem is not coming from proovread. Have a look at the last command in the log to samtools sort. It failed with a out of memory issue. It is trying to allocate 2GB. How much memory does you computer have?
The 2GB are currently hard coded, you could change them by opening the proovread file in an editor and change line 1338 samtools sort -m <max-ram>G. However, if you really have less than 2GB of RAM, I can't promise that proovread won't run out of memory eventually...

my system has 16 gb of ram size,but still facing the same issue.

OK, that is odd. Can you try and just run that samtools line directly?
 samtools sort -m 2G -@ 21 -T pacbio_proovread/bwa-sr-1/pacbio_proovread_tmp -o
pacbio_proovread/bwa-sr-1/pacbio_proovread.bam pacbio_proovread/bwa-sr-1/pacbio
_proovread_tmp.bam

Hm, thinking about it, it probably means that other things on your system (including proovread) are taking up most of the RAM. Can you monitor the RAM consumption while running proovread?


Allow additional security groups to be included in worker launch configurations

PR o'clock
Description
xref: #47
Proposed approach to address #47.  Allow security groups to be included to all worker groups via optional worker_additional_security_group_ids and/or specified for a specific worker group via optional additional_security_group_ids in worker config map.
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
[x] Tests for the changes have been added and passing (for bug fixes/features)
[x] Test results are pasted in this PR (in lieu of CI)
[x] Docs have been updated using terraform-docs per README.md instructions
[x] I've added my change to CHANGELOG.md
[x] Any breaking changes are highlighted above

@max-rocket-internet your requested change has been made.  Tests passing.

@max-rocket-internet I added the fix to address #116 to this PR as well.

@max-rocket-internet I could really use the above PR included in the next release as I require this ability to use the module in production.  Is there anything I can do to help get this PR merged.  Thanks in advance.

Looks good. Thanks for the effort, to both you and @hobbsh.
In our environment this will enable us to remove some external aws_security_group_rule resources 🎉


Error telling me to delete settings.json file

Target will find an xbox series x but does not add it to cart and says "Retrying submit order until success"

Any help on resolving this error?

bump

This is theoretically fixed in the develop branch. I've only had once instance get to a checkout while I was asleep but CC company denied charge so unable to confirm 100%.


Any suggestions for extracting embeddings for sequences with > 1024 residues?

Could I split the sequence into 1024 length chunks, run each separately with the BOS and EOS tokens occurring in the first and last chunks, concatenate the resulting embeddings, then take the average?
Seems like since during training the model used random crops of >1024 length sequences, this should work, but want to make sure.
Also, some warning that your sequence is too long might be helpful, since as of now trying to embed a larger than 1024 length sequence while running on gpu results in the unhelpful "device-side assert triggered" CUDA runtime error.

Yes, during the training process we cropped sequences >1024 sequences, so taking crops is a sensible choice. We haven't experimented with concatenating or averaging the resulting embeddings, but there are a number of things you could try. For example, assuming the sequence is of length 3072, you could:

split into 3 chunks of length 1024 and concenate
split into 2048 chunks (start position = 0, 1, 2, ..., 2048) and average appropriately
split into chunks of different lengths
many other possibilities...
It's possible that these will all perform similarly, but as this is still an open research question, we would be eager to hear what you find.

Yes, during the training process we cropped sequences >1024 sequences, so taking crops is a sensible choice. We haven't experimented with concatenating or averaging the resulting embeddings, but there are a number of things you could try. For example, assuming the sequence is of length 3072, you could:

split into 3 chunks of length 1024 and concenate
split into 2048 chunks (start position = 0, 1, 2, ..., 2048) and average appropriately
split into chunks of different lengths
many other possibilities...
It's possible that these will all perform similarly, but as this is still an open research question, we would be eager to hear what you find.


Handle OTEL resource attributes

Problem
Relates to https://docs.google.com/document/d/1epvoO_R7JhmHYsII-GJ6Yw99Ky91dKOqOtZGqX7Bk0g/edit#heading=h.4lju4hrri2ch Resource Attributes and their mapping section.
This issue is intended as an umbrella issue to address the various problems that come from supporting natively OTEL resource attributes. There are two cases that we want to support:

Application pushing metrics through the OTEL Collector.
Application instrumented with OTEL SDK exposing metrics through /metrics and Prometheus scraping them.

We want both cases to be handled equally so that the ingestion method is not part of the problem.
Proposal
The OTEL spec says that everything that is a resource attribute goes into target_info. One potential solution today is that Prometheus copy these attributes into series labels.
One way to do this is by setting up a config that specifies which attributes need to be mapped as labels. This config can be used for the both usecases that we have to support.

To make sure I understand this correctly,

Application instrumented with OTEL SDK exposing metrics through /metrics and Prometheus scraping them.
This line means that app instrumented with OTEL SDK which use prometheus exporter and export the metric with /metrics path, then let prometheus scrape it, right?

@jesusvazquez

I suggest we provide different ways of configuring the mapped resource's attributes
For Application pushing metrics through the OTEL Collector
We support users to configure by prometheus config file, we add a new config section called otlp and add a config item called mapped_resource_attributes, for example
global:
  ...
scrape_configs
  ...
otlp:
  mapped_resource_attributes: ["service.instance.id", "service.version"]

For Application instrumented with OTEL SDK exposing metrics through /metrics and Prometheus scraping them
We could add a new function to prometheus exporter package `` called WithMappedResourceAttributes , which support user configure the mapped resource attributes by modifying the code, for example
func main()

	reader, _ = prometheus.New(prometheus.WithMappedResourceAttributes([]string{"service.instance.id"}))

	provider := metricsdk.NewMeterProvider(metricsdk.WithReader(reader))
	meter := provider.Meter("github.com/open-telemetry/opentelemetry-go/example/prometheus")

	testInt64Counter, err := meter.Int64Counter("test_int64_counter", metricapi.WithDescription("the counter of http requests"))
	if err != nil {
		log.Panicf("new test_int64_counter failed: %v", err)
	}
}

The benefit we get from this design is that, we could simplify the implementation into just support adding configured resource attributes to other metrics when converting the metric from otlp format to prometheus format, which is easy to implement in both case.
For prometheus server, we could just modify the function
https://github.com/prometheus/prometheus/blob/ffa74eb12db3d46c98033cea42cfdb347e7d1e75/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go#L28
For golang prometheus exporter package, we could just modify the function
https://github.com/open-telemetry/opentelemetry-go/blob/8a923d0c7a7bc67bf4a209826065be0375d0b3de/exporters/prometheus/exporter.go#L146
I also write a simple implementation in my fork
https://github.com/open-telemetry/opentelemetry-go/commit/0fe1edd323ac4ee8d87402d452c6c2d6e602a5d5
Whereas, we could also support the secondary case by modifying the prometheus server, we should add a configuration item in scrape_config
job_name: test
scrape_interval: 30s
otlp:
  mapped_resource_attributes: ["service.instance.id"]

but I think this configuration is more difficult to implement for now.
@jesusvazquez @gouthamve looking forward for your comments!

Hello @fatsheep9146
Thanks for being so proactive and having a deep look into this.
You're definitely after something here. During the last prometheus dev summit we commented this topic and we discusses two approaches.
One is definitely what you are describing here or what we call do mapping on ingestion by copying labels. The other approach was to be smart during query time so we could join otel series with target_info data somehow without the user actually having to write the join.
The benefits of the former is that its relatively simple to implement but you also need to implement but if tomorrow you modify the config you create new series.
The benefit of the later is that you have al labels available without creating more series but its harder to implement and perhaps maintain.
I know that @gouthamve is putting some thought on this topic lately but he is on an offsite this week, we'd have to wait for him until next week.

It seems that by adding DisableTargetInfo: false
here: https://github.com/prometheus/prometheus/blob/7153f61790bef8b320be664e16b107a30e34c8ae/storage/remote/write_handler.go#L211
It's already supported... Why not add a simple option to start ?

Hello @gillg I believe these are two different things? One is what to do with resource attributes coming from otel metrics which is still WIP in the doc above and another is the configuration option highlighted in your comment which adds suffixes to metrics. OpenMetrics specifies that metric unit needs to be added to the metric name as a suffix, this is why that configuration is set.
There is a lot of conversation going around metric names and what the default behavior should be. The most updated doc is https://docs.google.com/document/d/16Wo-QHZLcKO0uFx97HPUJ-ZMFXSPviQ7Oc4-bShgcto/edit#heading=h.gc25lho2rm57


[release-1.25] Update to v1.25.16

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change

Further Comments

Why did you drop the go version update in the end?

@manuelbuil version v1.25 in upstream is not using go 1.20.11, I got an error in drone due the go dump

@manuelbuil version v1.25 in upstream is not using go 1.20.11, I got an error in drone due the go dump

Aaaah ok! I thought that all "maintained" upstream kubernetes versions used the same go version

I thought that all "maintained" upstream kubernetes versions used the same go version

Same, that is a bit unexpected, but I guess since the branch is technically EOL they are backporting only the bare minimum of change for the CVE.


change VmContainer's stdio's protocal and send tty into hyperstart

VmContainer.Tty: allocate tty or not
VmContainer.Stdio: Stdio sequence number
VmContainer.Stderr: Stderr sequence number if stderr is not share with
stdout (currently used when VmContainer.Tty is false)
Signed-off-by: Lai Jiangshan<EMAIL_ADDRESS>

restarted the test, and passed now.


Testing, please ignore. (hwepoh)

Bug bounty test - please ignore.... Please DO NOT APPROVE THIS! (hwepoh)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.nunezalmorado seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Added support package for Oscar

I' adding this package because after a very hard week work i got update the entire package for a usable software.
Also i want you or whatever other people help me to finish his features and improve it because i can't do it alone(it could begins solving type erros and documentation missings).
Thank you very much.

These should be added to the "community maintained packages" section that appears below this one, rather than the "stable and ready for use" section. Please amend and then we'll merge.

Ok, i will see it.

@solarissmoke I can't find these section.

Thank you!


follow web depreciations, remove unclear configuration examples and outdated default documentation

Description

follow web depreciations
remove unclear configuration examples
remove outdated default documentation

Related Issue

Fixes https://github.com/owncloud/ocis-charts/issues/726

Motivation and Context
keep web config up to date
How Has This Been Tested?

running the development deployment example with following changes:

diff --git a/deployments/development-install/helmfile.yaml b/deployments/development-install/helmfile.yaml
index 6edf79a..3b31d26 100644
--- a/deployments/development-install/helmfile.yaml
+++ b/deployments/development-install/helmfile.yaml
@@ -67,3 +67,8 @@ releases:
           web:
             persistence:
               enabled: true
+            config:
+              feedbackLink:
+                enabled: true
+                href: https://google.de
+                description: Lorem Ipsum Foo Bar

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[x] Documentation generated (make docs) and committed
[ ] Documentation ticket raised:
[ ] Documentation PR created:

@d7oc I also removed the application section, because according to @kulmann it was replaced by https://github.com/owncloud/web-extensions/releases/tag/external-sites-v0.1.0 and must also be removed from the oCIS config options


Enable check enforcer for mixed github actions + azure pipelines CI

Requires https://github.com/Azure/azure-sdk-actions/pull/7 to merge first (currently reverted), which adds support for workflow_run action types and enforcing multiple check suites
This updates the check enforcer github action to run on completion of other github actions, namely template-ci, cli-ci and vscode-ci (by default, events from github actions do not trigger other github actions to prevent loops).
With this update, we will be able to de-commission check enforcer v1. Once it goes in, we will need to update the branch protection settings to require https://aka.ms/azsdk/checkenforcer and remove the check-enforcer github app from this repository.
I think these changes are pretty well tested, but regardless should be monitored for a while after they go in.

/check-enforcer override

/check-enforcer override


fix: Make Wolfi build again.

Wolfi build fails since 2 days due to a libcap version confilict originating from chainguard. distrobox init needs libcap -> every chainguard image building on wolfi-base is affected when trying to use it with distrobox.
ERROR: unable to select packages:
  libcap-2.68-r0:
    conflicts: libcap-2.69-r1
               libcap-2.69-r1[so:libcap.so.2=2]
    satisfies: world[libcap]
               iputils-20231222-r0[so:libcap.so.2]
               libcap-2.69-r1[so:libpsx.so.2]
  libcap-2.69-r1:
    conflicts: libcap-2.68-r0
               libcap-2.68-r0[so:libcap.so.2=2]
    satisfies: world[libcap]
               iputils-20231222-r0[so:libcap.so.2]

Temporary fix: Pin libcap=2.68-r0 until this is sorted out upstream.

I'm getting this error now, took a stab at it here, still investigating but just putting it on the radar since we moved the toolboxes:
https://github.com/ublue-os/toolboxes/pull/8

I think we still need to be pinned to 2.68.
https://github.com/wolfi-dev/os/issues/11139 indicates that 2.69 was pulled.


chore: bdd-spring-1578505377 to 0.0.1

chore: Promote bdd-spring-1578505377 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Support for accessing embedded .NET resources within Qml.

https://wiki.qt.io/QtResources
We'd have to pinvoke the data into a special C struct that Qt can use to register it as a resource that can be loaded in Qml (whether it's other Qml files, or images, etc).

Here is how to get a raw pointer to the embedded resource for usage in Qt: https://stackoverflow.com/questions/51406733/net-embedded-resource-getting-an-intptr-to-the-raw-memory-location-for-use-in/51407990#51407990

While true, having to copy the resource data in-memory and keep it around (because it needs to be in the RCC format apparently) seems wasteful.
Here's what I'll actually attempt for my project:

Somehow integrate RCC as a MSBuild task
Embed the resulting .rcc file into the .NET DLL
PInvoke QResource::registerResource with the raw data (which was produced by RCC and is embedded in the .NET DLL)

The pointer to the embedded resource is a static non-changing pointer. I believe it's in memory at all times, the moment the .NET dll is loaded.
I do like your idea though, the more we can set on top of traditional/supported APIs, the better, and manually building that struct sounds problematic.

The challenge of making this developer-friendly will most likely be providing a NuGet package that has:

The required MSBuild targets (I think this is already nicely supported in the .NET Core/.csproj world, but not sure about traditional .NET framework)
A prefferrably statically built rcc.exe for the major platforms (Linux, Mac, Windows). 32 vs 64-bit might not matter, since it's never packaged with the app itself
Care must be taken to build it with ZStd compression support (this is not trivial to do on Windows)

I might look into this soon.

Are you using unmanaged hosting or unmanaged hosting?

I am using managed hosting with some extra custom native glue.


No icon for FR

Hi,
I think FR flag is missing.
I try with  but I just get litteraly "FR".
Thanks

Fixed in v2.0.4

Thanks :)


Json safe

added JsonSafe helper type
added the prototypes.typingsFormat.jsonSafe option
for v3/v4 fixtures output, set this option to true

should close #605
cc @turadg

Looks like it does the job, but the option could be more clear. JsonSafe is a utility type, but doesn't really express the intent for the person setting the option.
Consider, prototypes.typingsFormat.returnKnown. That contracts with the unknown` default.
Though if it were me I'd always return the typed value and not have an option. I can't think of why anyone would prefer to get unknown to the true value. It also shouldn't be considered a breaking change since the change improves accuracy. (i.e. any type check that breaks with this is revealing a bug)

great feedback @turadg
The reason we use options (for any feature) is so developers that upgrade can choose to have few code changes as possible since a large amount of code is generated.
I would suggest we do two phases. One smaller release (patch) with the option defaulting to unknown, and then a minor release to make it the default to have types


Missing textures in Rayman 3

Some objects are untextured or textured incorrectly. It doesn't appear to be caused by CopyRects missing transfers from MANAGED to DEFAULT in this case.
WineD3D also doesn't render things correctly, but it does appear to get some textures right. I'll have to try it on Nvidia to see if ANV isn't at fault here.
I've tried to capture a trace but it crashed before reaching the main menu. Doesn't appear to be entirely empty however, so hopefully it does contain something relevant.
Software information
Rayman 3 (GOG)
System information

GPU: Intel Xe (TigerLake GT2)
Driver: ANV/23.0.99
Wine version: 7.22 Staging
DXVK version: d0f5903

Apitrace file(s)
Rayman3.trace.tar.xz
Log files

d3d8.log: Rayman3_d3d8.log
d3d9.log: Rayman3_d3d9.log

P.S.: Gave it a go on Nvidia, and can confirm it's not an ANV problem. Same missing textures/see-through surfaces show up here as well, including with WineD3D.

Yeah here shows similar error with UHD 630 GT2

Apparently the missing textures are a known problem with the game and there is an unofficial mod that fixes it: https://raymanpc.com/forum/viewtopic.php?f=13&t=12854
The mod ships its own d3d8.dll - not sure what that does, but it does look like it brings back some of the textures (some character textures still look wrong with d8vk though).
I'll attempt to grab a trace with the mod applied, perhaps that will shed some light into what's going on.

The good news is that I got a d3d9 trace of the mod by using d3d8to9 + d8vk: Rayman3.mod.trace.tar.xz
The bad news is that the mod absolutely kills performance to a level that the game simply becomes unplayable in WineD3D. I'm not entirely sure why, but it seems to force CS syncs in certain places.
By the looks of it though, and considering that WineD3D is also broken without the mod, the game is clearly doing something wrong and will need some sort of workaround to render everything correctly. Might be a tough one to fix.

I've looked into this a bit more closely, and it seems like Rayman 3 with Better Rayman works well with d8vk already.

I don't think we should spend more time backporting whatever Better Rayman is doing, since the original version of the game most likely relied on some driver hacks to render properly. WineD3D also needs Better Rayman to render correctly, and according to some posts I've read so do some native drivers.

No sadly in my case with intel graphics still have troubles

Maybe can upload some logs and maybe a trace

It works on Intel as well, I have checked, but you need both d3d8.dlls. To be more exact:

the d3d8.dll from Better Rayman next to the game exe
the d8vk d3d8.dll in system32/syswow64, where it is normally installed in Wine
a Wine override for d3d8.dll with "n,b"

No in my case stay without change

Maybe can stay related to mesa drivers if you have xe igp based is diferent compared igp before xe

Here is my d3d8.ini config file. I have not changed anything in the game folder outside of installing the game and then the Better Rayman mod. If you are using the same with latest d8vk (from main branch) there's no reason for it not to work outside of it being misconfigured:
;; Config file for DirectX DLL Wrapper
[General]
LoadCustomDllPath        = BetterRayman3.dll

[Compatibility]
D3d8to9                  = 0
DdrawCompat              = 0
ForceTermination         = 0
SingleProcAffinity       = 0

[Window]
FullScreen               = 0
WaitForWindowChanges     = 0

Here is my d3d8.ini config file. I have not changed anything in the game folder outside of installing the game (GOG version) and then the Better Rayman 3 mod. If you are using the same with latest d8vk (from main branch) there's no reason for it not to work outside of it being misconfigured:
;; Config file for DirectX DLL Wrapper
[General]
LoadCustomDllPath        = BetterRayman3.dll

[Compatibility]
D3d8to9                  = 0
DdrawCompat              = 0
ForceTermination         = 0
SingleProcAffinity       = 0

[Window]
FullScreen               = 0
WaitForWindowChanges     = 0

In my case appear same, however for now with d3d8to9 work

Seems like Better Rayman is either using d3d8to9 or dxwrapper to apply this fix: https://github.com/crosire/d3d8to9/blob/2b25f270c4119437e80e52f41d0dc30236c62865/source/d3d8to9_vertex_buffer.cpp#L88
If I replicate this behavior, it does indeed seem to fix the issue, so I am guessing this is also inline with what native was doing, at least in the Windows XP era, because the game doesn't run into this issue on an age-accurate system.

For a BetterRayman3, it is probably better to use files from ray3fix https://gamebanana.com/mods/492495
This avoids dxwrapper's d3d8 loading BR, here is winmm.dll as a loader to scripts/BetterRayman3.asi and dinput8, optionally probably you want dsound, maybe yes, maybe dont... and DGVoodoo2 files you can delete.
In ubi,ini select a resolution you want, your desktop res i guess, etc...
As for a bug, seems like you can just add d3d9.allowDiscard = False as a workaround.

d3d9.allowDiscard was removed in dxvk 2.3

Hm, then i have no idea how this started working... i played with older drivers a bit selected this... and somehow it started working even on more recent, weird... :D

As for a bug, seems like you can just add d3d9.allowDiscard = False as a workaround.

That option has been removed some time ago, just like Blisto mentioned. I've fixed the problem with: https://github.com/doitsujin/dxvk/pull/4143 , which won't penalize applications that don't depend on this d3d8 buffer discard quirk. And we haven't seen anything besides Rayman 3 abusing this behavior so far.

I have fixed the base game without any mods or patches.
For which base version? 1.0, 1.0.2, GoGs, retail anniversary... i heard that there are many versions differences :D
Who will play original version when it fluctuates FPS in half all the time?
If not synced and your screen is at 60Hz, then game runs at 72 fps. Further if yours screen is at 75Hz then game runs at 90 fps, etc... and then goes in half to 36 or 45, etc... because of this you want to mod it anyway, regardless if you want to run wide or original 4:3.

For which base version? 1.0, 1.0.2, GoGs, retail anniversary...

Whatever GOG has. But I think it would fix original retail copies also.

Who will play original version when it fluctuates FPS in half all the time?

Disabling direct buffer mapping actually helps a lot in this regard (part of my PR). The game still drops to half the framerate at times, but a lot less frequently. It's the best I could do for people who may not be aware Better Rayman exists.

If not synced and your screen is at 60Hz, then game runs at 72 fps. Further if yours screen is at 75Hz then game runs at 90 fps, etc...

No, that won't happen with dxvk's new vsync frame limiter. You can see in the logs that it's properly preventing the game from overshooting the refresh rate.

For now just to confirm, one needs 100Hz screen so that game run at 120 fps

Fixed in dxvk master (or rather worked around, since the game's behavior is dependent on an odd implementation detail) by https://github.com/doitsujin/dxvk/pull/4143.


[STOCK] [2023-11-16 23:21:36] production.ERROR: Undefined variable $__empty_2

[2023-11-16 23:21:36] production.ERROR: Undefined variable $__empty_2 {"view":{"view":"/Users/jeong-gwang-il/Downloads/SREAL/WEBE/WebErpMesv2/resources/views/products/stocks-index.blade.php","data":{"errors":"
Illuminate\Support\ViewErrorBag {#1713
#bags: []
}

obviously this poses problems if there is no rental stock
@forelse ($StockLocationList as $StockLocation)
                                <option value="{{ $StockLocation->id }}">Stock : {{ $StockLocation->Stocks->code }}| Location : {{ $StockLocation->code }} </option>
                                @endforeach

add @emtpy and translation key

Hi Kevin,
It is amazing!! Really thank you so much for your fixing these issue. I will test it soon.
My company is so small manufactory working only 2 person  so I cannot donate money yet but I wanna help this project if I can help.
I will try to use WebErpMesv2 as operate my small fab so I will ask more help if there is problem.
Everything is working well then, I will try to earn money and help this project.
I worked for Samsung, LG, US company, Japan game company and German software company as a various software engineer for 30 years. I am a only beginner as web developer but have a software skill and good network in Korea, German, US, Please always suggest if there is anything I can help.
Thanks!

@darrelljung111 You're welcome, thank you for your time and the feedback.  If you need help do not hesitate it will be useful for other people or ideas this present to you let's discuss between us.

VAT and your company input problem is solved.
But, I don't know how to solve Stock 500 error issue in stocks-index.blade.php.
Would you explain in detail how I can delete 500 error in Stock?

Hi change doesn't passe the 500 error issue ?

Hi!
500 Error is fixed after I input right side properly. Thank you so much!!
I have a question about logs. Usually, log display the file and line which the error is occurred. But I cannot see the line detail on Laravel.log. How I can unerstand which line is problem?
I cannot find which line is problem with below log.
[2023-11-20 23:48:37] production.ERROR: syntax error, unexpected token "endforeach", expecting "elseif" or "else" or "endif" {"view":{"view":"/Users/jeong-gwang-il/Downloads/SREAL/WEBE/WebErpMesv2/resources/views/products/stocks-index.blade.php","data":{"errors":"
Illuminate\Support\ViewErrorBag {#1713
#bags: []
}

","stocks":"
Illuminate\Database\Eloquent\Collection {#1751
#items: []
#escapeWhenCastingToString: false
}

Hi @darrelljung111
your if condition, or for loop is not closed, so it cannot finish executing the file, something is not logical.
Can you attach your file?
Or use mine:
https://github.com/SMEWebify/WebErpMesv2/blob/WEM-2.0/resources/views/products/stocks-index.blade.php


Track "user-agent" metadata indicating which application scheduled cook jobs

Today, the process of figuring out which applications launched jobs running on cook amounts to pattern matching against the name and/or command.
I would like to enable the application scheduling jobs to be able to provide optional "user-agent" metadata that could be used to analyze the source of requests after the fact.

You should just be able to add this information in a label of the job when you send the job to Cook.  Cook should pass the label or labels through to Mesos.

Yes this could be done with a label but it is probably worth making it first class so that systems that are on top of cook can expect it.
@rustyconover, were you imagining a case where a downstream consumer (mesos executor for example) might want to know the "user agent"?

@wyegelwel Are you thinking we should add a top-level field to the job description (for example, application)? What type of data do we want to know about the application? Maybe name, owner, version as sub-fields within the application map?

Initially I was thinking just {"application" : "spark", ...} though, you are right it might be useful to have other info.
@sgopalan, what do you think?

My initial thoughts were around capturing application and version.  That
would help us to determine 1) the variety of applications launched, and 2)
within one application, what versions are running.
Thanks.
Sri
On Mar 28, 2017 5:42 PM, "wyegelwel"<EMAIL_ADDRESS>wrote:
Initially I was thinking just {"application" : "spark", ...} though, you
are right it might be useful to have other info.
@sgopalan https://github.com/sgopalan, what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twosigma/Cook/issues/192#issuecomment-289913904, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAhxK6isaZjluKteWQsfCgy4TXlmQJFXks5rqX7QgaJpZM4KN8X_
.

Is application owner useful?
{
  ...
  "application": {
    "name": "foo",
    "version": "0.1.0",
    "owner": "dposada"
  }
  ...
}

I think application owner is less useful because depending on when you look
at the data, it will be wrong (e.g owner left the company yesterday).
Instead, I envision this feature being utilized in concert with a different
tracking system that manages the details of the application (owner,
department, company, etc).
Thanks.
Sri
On Mar 28, 2017 5:57 PM, "Daniel Posada"<EMAIL_ADDRESS>wrote:
Is application owner useful?
{
...
"application": {
"name": "foo",
"version": "0.1.0",
"owner": "dposada"
}
...
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twosigma/Cook/issues/192#issuecomment-289917627, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAhxKxqLaljqEzk5uuVzuS8jwSQ5Ez25ks5rqYJSgaJpZM4KN8X_
.

Makes sense. So I propose we add an optional application field to the job description, which is a map with
{
  ...
  "application": {
    "name": "foo",
    "version": "0.1.0"
  }
  ...
}

We can add more fields to the application map later if needed. Thoughts?

Agreed I think that makes sense
On Wed, Mar 29, 2017, 9:47 AM Daniel Posada<EMAIL_ADDRESS>wrote:

Makes sense. So I propose we add an optional application field to the job
description, which is a map with
{
...
"application": {
"name": "foo",
"version": "0.1.0"
}
...
}
We can add more fields to the application map later if needed. Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twosigma/Cook/issues/192#issuecomment-290095138, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABZnHVpkpkzEvPBsAOUHSshf2rJk7GNyks5rqmEIgaJpZM4KN8X_
.

@wyegelwel I assume we want to update the JobClient to allow for specifying the application info as well. I noticed that for the container field, which is similar to application in that it's a sub-map, JobClient simply models it as a JSONObject. Why not model this with a Container class? Or for this change, with an Application class?

Resolved by PR #278


Avoid spurious reconnects

Adds a counter to avoid forcing a reconnect if the connection is back online by the next 2 tries

I've added the basic tests, I'm unsure how to go about replacing the websockets pong response in a fixture to cause it to raise the timeout exception though

I thing you can disable the websocket connection by manually setting state to CLOSING.
This will prevent pongs being sent.


fix: Ensure unique generated locations

Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: To simplify routing, generated locations should be different from defined  http route locations.
Solution:

Updated internal location block prefix to ngf-internal
Blocked http route with ngf-internal as prefix
Updated documentation to communicate the new changes and restricted path prefixes

Testing:

Added unit tests
Did manual testing

curl request with version 2 header returns response from coffee-2
sa.choudhary@JX46X2W221 cafe % curl --resolve cafe.example.com:$GW_PORT:$GW_IP http://cafe.example.com:$GW_PORT/coffee -H "version:v2"
Handling connection for 8080
Server address: <IP_ADDRESS>:8080
Server name: coffee-v2-7d47fc86cb-4mkkf
Date: 04/Jan/2024:23:46:55 +0000
URI: /coffee
Request ID: c71364174305814d8385e33a05575aa9

coffee path prefix starting with ngf-internal is rejected
Matches:
      Path:
        Type:   PathPrefix
        Value:  /ngf-internal-1
    Backend Refs:
      Group:
      Kind:    Service
      Name:    coffee-v2-svc
      Port:    80
      Weight:  1
    Matches:
      Headers:
        Name:   version
        Type:   Exact
        Value:  v2
      Path:
        Type:   PathPrefix
        Value:  /coffee
Status:
  Parents:
    Conditions:
      Last Transition Time:  2024-01-04T23:48:10Z
      Message:               The route is accepted
      Observed Generation:   2
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-01-04T23:48:10Z
      Message:               All references are resolved
      Observed Generation:   2
      Reason:                ResolvedRefs
      Status:                True
      Type:                  ResolvedRefs
      Last Transition Time:  2024-01-04T23:48:10Z
      Message:               Dropped Rule(s): spec.rules[0].matches[0].path.value: Invalid value: "/ngf-internal-1": paths starting with `/ngf-internal` are reserved for internal use. Choose an alternative starting path
      Observed Generation:   2

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #428
Checklist
Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

LGTM on the docs side - since the changes in the PR are primarily code-based I will not make an approval.

@salonichf5 can you update the PR description to reflect the new approach?

@pleshakov Do you think with this change we still need the internal; directive? Is it redundant, or does it still add value?

@sjberman
Is it redundant


Enable identity transform for sizes 16x16 and below

txtype@2018-06-21T09:57:19.682Z -> idtx_max16x16@2018-06-23T00:13:43.743Z

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.7795 |  1.3157 |  1.0336 |   0.7239 | -0.1461 |  0.6128 |    -0.0174

Encoding time (Q80): 32.739 -> 37.841

LGTM. The first patch commit doesn't mention the IDCT enable, which was a bit confusing.

@tdaede I realized that after submitting the PR as well, sorry for the confusion. Squashing the commits would be best.


Setup keep alive connections

Currently, each 3scale admin API call required to setup a new TCP/HTTP connection. For 3scale commands running multiple 3scale API calls, the toolbox spends a lot of time on TCP/HTTP connection setup. Specially true for TLS connections.
With this change, by default, the connection opened by the 3scale toolbox command (if the command requires opening a connection) will be setup to keep alive. Thus, all API calls required for the command will reuse the connection.
If, for whatever reason, the Connection: close behavior is desired, the PR includes a new top level option parameter:
--disable-keep-alive       Disable keep alive HTTP connection mode

Codecov Report

Merging #342 (8979ea7) into main (6886696) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   98.54%   98.54%
=======================================
  Files         337      337
  Lines       16714    16727   +13
=======================================
+ Hits        16470    16483   +13
  Misses        244      244

Impacted Files
Coverage Δ

lib/3scale_toolbox/3scale_client_factory.rb
100.00% <100.00%> (ø)

lib/3scale_toolbox/base_command.rb
93.75% <100.00%> (+0.41%)
:arrow_up:

lib/3scale_toolbox/commands/3scale_command.rb
77.27% <100.00%> (+1.08%)
:arrow_up:

spec/unit/3scale_client_factory_spec.rb
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6886696...8979ea7. Read the comment docs.


How to add scripts in version 0.7.1h

What is your question?
When i downloaded the new version of Psych Engine, was making my mod, but the scripts file didnt exsist anymore, but i wanted to add them, so anyone knows how to add scripts in psych engine 0.7.1h?

Duplicate of #12849

Duplicate of #12849

Already did it thousand of times but didnt work and yes, i work with lua

The scripts folder works the same as it did before 0.7, this is a problem on your end

The scripts folder works the same as it did before 0.7, this is a problem on you
The scripts from the version 0.6.3 work the same way as 0.7.1h?

The scripts folder works the same as it did before 0.7, this is a problem on your end

The scripts from ver. 0.6.3 work the same as 0.7.1h?

You add them like 0.6.3; but your scripts may be using runHaxeCode (cannot be called twice or more) or set/getPropertyFromClass (0.7 organisation)
do luaDebugMode = true to see lua errors

You add them like 0.6.3; but your scripts may be using runHaxeCode (cannot be called twice or more) or set/getPropertyFromClass (0.7 organisation) do luaDebugMode = true to see lua errors

None of the scripts have those commands but they still not working anyway


Repairing artifacts with regression - Using the wrong regression coefficients

Proposed documentation enhancement
In the aforementioned tutorial, under "Subtract the evoked response from the epoch data before regression":
I think that
epochs_clean_sub = model_plain.apply(epochs)
is incorrect, as this applies the regression coefficients from model_plain, which was trained on the default epochs, rather than epochs.subtract_evoked().
I think it should be
epochs_clean_sub = model_sub.apply(epochs)
instead. Otherwise, model_sub appears to be redundant.

Huh, I think you are right @JacPhe . Would you be up for a PR to fix this?
Also just to be safe, CC'ing @wmvanvliet as the author of that tutorial... On line 152 shouldn't model_plan.apply(...) actually be model_sub.apply(...)?
https://github.com/mne-tools/mne-python/blob/a99aa9f798d878ba144b3f6f3127311841d5d2b5/tutorials/preprocessing/35_artifact_correction_regression.py#L143-L154

I've sent a pull request just in case, hopefully that helps!


Port to Vercel

fixes #2

@seveibar Apologies for the additional work, i see it's merged. If you need anything from my end do let me know.


slf4j-parent having multiple vulnerabilities

Hi guys....first of all I want to thank you for this amazing project.
Is there any chance to remove slf4j-parent library from dependencies because that library has multiple vulnerabilities and all security scanning tools are RED because of this? Thanks in advance.
https://mvnrepository.com/artifact/org.slf4j/slf4j-parent/1.7.26

i would not remove it but maybe update it

updated to 1.7.36 in 0.7.6


158 style create campaign page

Added some basic styling to the create campaign page, as per issue #158.

I like the look of the form, but rather than using a modal could we fit it into the same style the previous pages are using? I think that would contribute to a consistent look and feel that eventually we can iterate on to make it closer to the wireframes.

also, I think "Apartment Number" is supposed to be "Number of Apartments" or something like that


Node standard modules

A short section in the documentations about "how to extend tabris with node modules" would help to me.
Most modules, embedded by package.json fail, because they require node standard modules like fs, path, stream, util. But standard modules are not found. And I cannot find out how to use them.
My solution may be to create a new cordova plugin. I have not tested this out.
But I'd rather prefered to use package.json to add functionality.

See #1326 and #1293.  Agreed that more documentation would be useful.

There is an interesting project.
Maybe this can become a solution... or just a source for code
https://github.com/jxcore/jxcore-cordova#goals
From the license
^Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.^


Merge Android jobs into a single multistep job to better amortize setup time

Problem
Android CI uses a total of ~30 minutes CI time, but a lot of this seems to be work that is duplicated across the three Android jobs.
Change overview
Combine the jobs into one job with steps that build the different configurations.
Testing
Checked that the overall job ran in ~15 minutes.
@mspang I'm a little concerned that the builds after the first one are clearly reusing some build artifacts for the "app" builds; the log at https://github.com/bzbarsky-apple/connectedhomeip/runs/3089960361 shows things like:
> Task :app:javaPreCompileRelease UP-TO-DATE
...
> Task :app:testReleaseUnitTest UP-TO-DATE

etc.  Should we instead be deleting something between the steps to ensure more proper "clean" builds, or do we trust whatever build system is involved here enough to assume that it's going to redo whatever work differs between the three configurations correctly?

Problem
Android CI uses a total of ~30 minutes CI time, but a lot of this seems to be work that is duplicated across the three Android jobs.
Change overview
Combine the jobs into one job with steps that build the different configurations.
Testing
Checked that the overall job ran in ~15 minutes.
@mspang I'm a little concerned that the builds after the first one are clearly reusing some build artifacts for the "app" builds; the log at https://github.com/bzbarsky-apple/connectedhomeip/runs/3089960361 shows things like:
> Task :app:javaPreCompileRelease UP-TO-DATE
...
> Task :app:testReleaseUnitTest UP-TO-DATE

etc. Should we instead be deleting something between the steps to ensure more proper "clean" builds, or do we trust whatever build system is involved here enough to assume that it's going to redo whatever work differs between the three configurations correctly?

It doesn't seem surprising to me that java compilation would be considered up to date in followup builds because those steps produce portable bytecode.
While I wouldn't say that I 100% trust it, I don't see an obvious problem here and in fact this likely indicates legitimate savings.

@woody-apple @Damian-Nordic @msandstedt @saurabhst @jepenven-silabs @LuDuda @jmartinez-silabs Take a look please?  Should help a bit with our CI latency.


cloud_firestore 0.14.0

firestore_cache 0.1.1 does not work with cloud_firestore 0.14.0 .

cloud_firestore 0.14.0 introduced a lot of breaking changes. I'm using another package to mock cloud_firestore for testing so I'll have to wait for that package to update before updating firestore_cache.

Waiting for this too.

firestore_cache 0.2.0 has been updated to support cloud_firestore >= 0.14.0


Add Foundation

We only support 721 -> Ether sales, when listed on-chain.
I needed to modify the tests to allow the market contract to escrow after listing.
For the fee recipients, we currently hard code the amount received to 1%. This will change in the future, but for now I updated the test so that the numbers align to the expected 1%.
Let us know if there's anything we might have missed.
Thanks for putting this together! Looking forward to having all the marketplaces included in this report.

The output (excluding unsupported calls)
  [Foundation] (ERC721 -> ETH List-On-Chain) List (direct) -- gas: 74027
  [Foundation] (ERC721 -> ETH List-On-Chain) List -- gas: 93139
  [Foundation] (ERC721 -> ETH List-On-Chain) Fulfill (direct) -- gas: 92295
  [Foundation] (ERC721 -> ETH List-On-Chain) Fulfill -- gas: 111535
  [Foundation] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) List (direct) -- gas: 50227
  [Foundation] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) List -- gas: 69351
  [Foundation] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) Fulfill (direct) -- gas: 102845
  [Foundation] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) Fulfill -- gas: 122337

  [Seaport] (ERC721 -> ETH List-On-Chain) List (direct) -- gas: 36456
  [Seaport] (ERC721 -> ETH List-On-Chain) List -- gas: 60920
  [Seaport] (ERC721 -> ETH List-On-Chain) Fulfill (direct) -- gas: 55524
  [Seaport] (ERC721 -> ETH List-On-Chain) Fulfill -- gas: 77300
  [Seaport] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) List (direct) -- gas: 30665
  [Seaport] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) List -- gas: 56185
  [Seaport] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) Fulfill (direct) -- gas: 85277
  [Seaport] (ERC721 -> ETH One-Fee-Recipient List-On-Chain) Fulfill -- gas: 107597

@0age I fixed the lint issue.
For the test run, It seems that CI is missing env for our run. It works locally
On CI:

Run forge test --fork-url  -vv
error: The argument '--fork-url ' requires a value but none was supplied

Locally:

Running 3 tests for test/GenericMarketplaceTest.t.sol:GenericMarketplaceTest
[PASS] testFoundation() (gas: 18791611)
[PASS] testSeaport() (gas: 35876289)
[PASS] testWyvern() (gas: 41043984)
Test result: ok. 3 passed; 0 failed; finished in 12.64s

@0age I fixed the lint issue.
For the test run, It seems that CI is missing env for our run. It works locally
On CI:

Run forge test --fork-url  -vv
error: The argument '--fork-url ' requires a value but none was supplied

Locally:

Running 3 tests for test/GenericMarketplaceTest.t.sol:GenericMarketplaceTest
[PASS] testFoundation() (gas: 18791611)
[PASS] testSeaport() (gas: 35876289)
[PASS] testWyvern() (gas: 41043984)
Test result: ok. 3 passed; 0 failed; finished in 12.64s

We’re working out the root cause here, seems related to external PRs not having access to CI env vars; believe we have a solution though!