feat: implement the password change feature

closes #773
Implement The Password Change Feature
The change password feature at the settings page, with the front and backend implementaions.
Changes
Changes we added listed below:

add change password route on app.ts to handle the request.
create the controller function changePassword on the userController to handle the request
create changePassword on the user service to verify the password and set the new password
create the user service api changePassword function to send the request from frontend to backend
move and create more changePasswordSchema to validate the data both from frontend and backend
organize the imports in some files.
have some fun 😄

@aosccode

@Tymmmy @rico191013 Can you check how is it ?

I need something like this to appear in the Settings page on a click of a button - Change password:

@Tymmmy I added it, I forgot to uncomment, now can you review it ?

@Tymmmy I added it, I forgot to uncomment, now can you review it ?

@Tymmmy

@Tymmmy I added it, I forgot to uncomment, now can you review it ?

So...please read the requirements, and what I have been writing carefully :D. The screenshot I showed you, I mentioned that was from a previous start of the implementation, that was not finished. You can reuse that, no problem, BUT make sure it is up to date with newer forms, because it is old code, check for example the CreatePaymentPointerDialog.tsx form.
AND as the story mentions:
"On the Settings page add a Change password button.
Onclick the Form for change password appears with a new Save password button."
And as I mentioned above in a few comments: "I need something like this to appear in the Settings page on a click of a button - Change password:"
This means:

User goes to the settings page, sees the normal settings page, and a new button of Change Password
User clicks on the button, the Change password form appears (as it appears right now without a click of a button)
User has the possibility to change password by clicking on Save button
User also has the possibility to hide the Change password form again by clicking on a Cancel button

So, again, please add a button to show hide Change password form in Settings. And right now even if the form appears and I add the input data, nothing happens on form submit. Nothing happens on Change Password click. So please check that also.

Thank you for Contributing to Interledger during Hacktoberfest. If you have any accepted PRs, You can claim your Swag here. Last date to fill up the form is December 10th, 2023. @trupakufi

PR will close, we will revisit the story in another branch


[ Solved ] Running Gradle task 'assembleDebug'

解决以上问题
参考了几个方案没有解决后来看到一个方案很好，适合国内用(Ali Maven repository)
At: {path/to/FlutterSDK}/packages/flutter_tools/gradle/flutter.gradle**
A:
To Modify:
buildscript {
    ext.kotlin_version = '1.3.50'
    repositories {
         //修改这里
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.5.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

Modified:
buildscript {
    ext.kotlin_version = '1.3.50'
    repositories {
        //已修改
        google()
        jcenter()
        //maven { url 'https://maven.aliyun.com/repository/google' }
        maven { url 'https://maven.aliyun.com/repository/jcenter' }
        maven { url 'http://maven.aliyun.com/nexus/content/groups/public' }
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.5.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

B:
To Modify:
private static final String DEFAULT_MAVEN_HOST = "https://storage.googleapis.com/";

Modified:
//private static final String DEFAULT_MAVEN_HOST = "https://storage.googleapis.com/";
private static final String DEFAULT_MAVEN_HOST = "https://storage.flutter-io.cn/download.flutter.io";

At: {path/to/project}/android/build/gradle

Modity Just like A

Then when running flutter build apk, you could see execute time reduced to about 52s in Line Running Gradle task 'assembleDebug', while no additional modifications 142s.

Hi @xjy37
Thanks for this solution, this is specific to [Using Flutter in China](https://flutter.dev/community/china.
You seem to be proposing mirror links  without third party
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Consul Connect communication breakdown between traefik, sidecars, and tcp service

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I boiled down the situation to a simple Nomad job
https://termbin.com/9hf2
From within the multitool container, I can telnet <IP_ADDRESS> 5555 and the echo service works, but connection to the service through traefik doesn't work.
What did you see instead?
telnet <IP_ADDRESS> 5555
No matter what I send it always receives the same 7 bytes: 15 03 01 00 02 02 46
I believe this is a TLS alert message for "certificate not found".
envoy logs from connect-sidecar-echo
[2022-09-17 19:25:24.973][15][debug][filter] [source/common/tcp_proxy/tcp_proxy.cc:198] [C1611] new tcp proxy session
[2022-09-17 19:25:24.973][15][debug][filter] [source/common/tcp_proxy/tcp_proxy.cc:370] [C1611] Creating connection to cluster local_app
[2022-09-17 19:25:24.973][15][debug][misc] [source/common/upstream/cluster_manager_impl.cc:1942] Allocating TCP conn pool
[2022-09-17 19:25:24.973][15][debug][pool] [source/common/conn_pool/conn_pool_base.cc:290] trying to create new connection
[2022-09-17 19:25:24.973][15][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection (connecting=0)
[2022-09-17 19:25:24.973][15][debug][connection] [source/common/network/connection_impl.cc:924] [C1612] connecting to <IP_ADDRESS>:29542
[2022-09-17 19:25:24.973][15][debug][connection] [source/common/network/connection_impl.cc:943] [C1612] connection in progress
[2022-09-17 19:25:24.973][15][debug][conn_handler] [source/server/active_tcp_listener.cc:147] [C1611] new connection from <IP_ADDRESS>:53150
[2022-09-17 19:25:24.974][15][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:228] [C1611] remote address:<IP_ADDRESS>:53150,TLS error: 268435703:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER
[2022-09-17 19:25:24.974][15][debug][connection] [source/common/network/connection_impl.cc:250] [C1611] closing socket: 0
[2022-09-17 19:25:24.974][15][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:228] [C1611] remote address:<IP_ADDRESS>:53150,TLS error: 268435703:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER
[2022-09-17 19:25:24.974][15][debug][pool] [source/common/conn_pool/conn_pool_base.cc:654] cancelling pending stream
[2022-09-17 19:25:24.974][15][debug][connection] [source/common/network/connection_impl.cc:139] [C1612] closing data_to_write=0 type=1
[2022-09-17 19:25:24.974][15][debug][connection] [source/common/network/connection_impl.cc:250] [C1612] closing socket: 1
[2022-09-17 19:25:24.974][15][debug][pool] [source/common/conn_pool/conn_pool_base.cc:483] [C1612] client disconnected, failure reason:
[2022-09-17 19:25:24.974][15][debug][pool] [source/common/conn_pool/conn_pool_base.cc:453] invoking idle callbacks - is_draining_for_deletion_=false
[2022-09-17 19:25:24.974][15][debug][pool] [source/common/conn_pool/conn_pool_base.cc:453] invoking idle callbacks - is_draining_for_deletion_=false
[2022-09-17 19:25:24.974][15][debug][conn_handler] [source/server/active_stream_listener_base.cc:120] [C1611] adding to cleanup list

What version of Traefik are you using?
v2.8.5 (docker)
What is your environment & configuration?
api:
  dashboard: true
  insecure: true
entryPoints:
  http:
    address: ":80"
  tcp:
    address: ":5555"
providers:
  consulCatalog:
    connectAware: true
    connectByDefault: true
    exposedByDefault: false
ping:
  entryPoint: http

Traefik job: https://termbin.com/g2wr.
Also important: Consul ACL is enabled and service-intentions have been made between multitool and echo.
Traefik DEBUG log (these are the only relevant lines I see)
time="2022-09-19T14:59:27Z" level=debug msg="Handling connection from <IP_ADDRESS>:46782 to <IP_ADDRESS>:21425"
time="2022-09-19T14:59:28Z" level=debug msg="Error while terminating connection: close tcp <IP_ADDRESS>:41154-><IP_ADDRESS>:21425: shutdown: transport endpoint is not connected"

Turns out to be a limitation of Traefik at the moment. TCP routers will need to implement ServersTransports and configure Consul certs automatically.
https://github.com/traefik/traefik/issues/7803


fuse.EISDIR not defined

As per the documentation on open(2), they can return EISDIR as a more specific error code when attempting to use this method on a directory.
I could not find an error code matching syscall.EISDIR defined in this package.
You defined ENOTDIR but not this code...
It should be defined.

Please don't open one issue per missing constant -- that's a little bit excessive.


Host rewrite

Since chrisomatic runs inside of the container, it connects to services via hostnames which are valid only inside the docker network. The URLs printed out are also like this. For example, after successfully registering a plugin, chrisomatic prints http://chris:8000/api/v1/ instead of http://localhost:8000/api/v1/.
There should be a way to rewrite these outputs.

Hello @jennydaman  this looks so cool for me and am intrested in giving it a try. can you please throw more light or probably assign it to me.

I'm happy to hear that you like the project!
The proposal is to be able to configure chrisomatic so that the URLs it displays are changed. Maybe we can start by changing the schema of the YAML configuration file chrisomatic.yml to accept something like:

on:
  cube_url: http://chris:8000/api/v1/
  cube_url_extern_host: http://localhost:8000
  chris_store_url: http://chris_store:8010/api/v1/
  chris_superuser:
    username: chris
    password: chris1234

To change the schema, you should first update the documentation here:

https://github.com/FNNDSC/chrisomatic/blob/master/docs/interpretation.adoc
https://github.com/FNNDSC/chrisomatic/blob/master/docs/schema.adoc

Next, you can change the actual code of how the YAML gets deserialized:

https://github.com/FNNDSC/chrisomatic/blob/master/chrisomatic/spec/schema.py
https://github.com/FNNDSC/chrisomatic/blob/fe48c55a01d3ebc985b4fa7af6d4b16d1769bd28/chrisomatic/spec/given.py#L22-L26

Finally, we'll need to figure out how to change what's displayed. This isn't exactly easy to do globally since what's displayed out to the screen are not strings but instead rich objects.

Thank you so much for your directions, will share a pull request once and
done with it.
On Thu, Apr 7, 2022, 10:38 AM Jennings Zhang @.***>
wrote:

I'm happy to hear that you like the project!
The proposal is to be able to configure chrisomatic so that the URLs it
displays are changed. Maybe we can start by changing the schema of the YAML
configuration file chrisomatic.yml to accept something like:
on:
cube_url: http://chris:8000/api/v1/
cube_url_extern_host: http://localhost:8000
chris_store_url: http://chris_store:8010/api/v1/
chris_superuser:
username: chris
password: chris1234
To change the schema, you should first update the documentation here:

https://github.com/FNNDSC/chrisomatic/blob/master/docs/interpretation.adoc

https://github.com/FNNDSC/chrisomatic/blob/master/docs/schema.adoc

Next, you can change the actual code of how the YAML gets deserialized:

https://github.com/FNNDSC/chrisomatic/blob/master/chrisomatic/spec/schema.py
https://github.com/FNNDSC/chrisomatic/blob/fe48c55a01d3ebc985b4fa7af6d4b16d1769bd28/chrisomatic/spec/given.py#L22-L26
Finally, we'll need to figure out how to change what's displayed. This
isn't exactly easy to do globally since what's displayed out to the screen
are not strings but instead rich https://pypi.org/project/rich/ objects.
—
Reply to this email directly, view it on GitHub
https://github.com/FNNDSC/chrisomatic/issues/1#issuecomment-1091200430,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALOKS6DOGH74KCWEAOYTKADVD2GHVANCNFSM5PIVRANA
.
You are receiving this because you were assigned.Message ID:
@.***>


Handle Never properties in Record

https://github.com/pelotom/runtypes/issues/247#issuecomment-831716139:

I thought it could be achieved by this:
Union(Record({ a: Unknown, b: Never }), Record({ a: Never, b: Unknown }))

But it doesn't work. I believe this is a bug (Never property is not working expectedly), and will be fixed soon.

While working on this, I've been also surprised by the fact that TS doesn't handle never properties in the way I expected:
const x: { foo: never } = {};
// Property 'foo' is missing in type '{}' but required in type '{ foo: never; }'.(2741)

Consequently, Never properties in Records do not work expectedly in the static types:
const R = Record({ foo: Never });
type R = Static<typeof R>;
const r: R = {}; // This errors at compile-time anyway, while we can make the validation below passing
expect(R.guard(r)).toBe(true);

I filed an issue upstream https://github.com/microsoft/TypeScript/issues/43954. I'm going to wait until the TS team tells us how never should work, and we would conform to the behavior there.

The question I filed upstream was answered as "Working as Intended", I was just misunderstanding what never is meant to be:

A type with a property of type never has zero legal values; { } is not one of them.

We'd follow this direction, making the behavior of Never like this:
const R = Record({ foo: Never })
type R = Static<typeof R>;
const r: R = {}; // This errors at compile-time expectedly
expect(R.guard(r)).toBe(false); // Always fails

If one wants to assure a property to be absent, optionalization is needed:
const S = Record({ foo: Optional(Never) })
type S = Static<typeof S>;
const s: S = {};
expect(S.guard(s)).toBe(true);

It's been already working, so we don't need to take any particular action about this. Though users have to wait https://github.com/microsoft/TypeScript/pull/43947 to be merged in order to work with static types properly i.e. it incorrectly allows undefined values for now:
const x: S = { foo: undefined }; // No errors without `--strictOptionalProperties`

I had to search for this issue. Perhaps expose a simple wrapper to make this easier to apply in future
export const Missing = Never.optional();


[RFC] Add ADDR_KEEP to keep negative counts

Daniel Hahler wrote:

Add ADDR_KEEP to keep negative counts

Not an obvious name...
Is it not possible to make "count" have this behavior?  Possibly that
cannot be made backwards compatible?  When I try "-5" I get some very
big number, might not be usable currently.
Another name would be "offset".
The change is missing documentation and a test.
--
The most powerful force in the universe is gossip.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


LoRA mutualization: keep base model loaded, load/unload LoRA adapters on the fly

Depends on https://github.com/huggingface/api-inference-community/pull/335

Hey @apolinario :). I set your suggestion to fuse/unfuse lora weights with the main models. I was indeed able to measure an improvement for the inference time (like 30%)
However, the fuse/unfuse was not reentrant, I was not able to load/unload the same adapter several times. I need to investigate more on this first. I suggest we start without the fuse/unfuse and interate to enhance the process
For the record, here is the issue I obtained
Traceback (most recent call last):   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/api_inference_community/routes.py", line 91, in call_pipe     outputs = pipe(inputs, **params)   File "/root/api-inference-community/docker_images/diffusers/app/pipelines/text_to_image.py", line 118, in __call__     self._load_lora_adapter(kwargs)   File "/root/api-inference-community/docker_images/diffusers/app/lora.py", line 67, in _load_lora_adapter     self.ldm.unfuse_lora()   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/diffusers/loaders.py", line 2071, in unfuse_lora     self.unet.unfuse_lora()   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/diffusers/loaders.py", line 646, in unfuse_lora     self.apply(self._unfuse_lora_apply)   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/torch/nn/modules/module.py", line 884, in apply     module.apply(fn)   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/torch/nn/modules/module.py", line 884, in apply     module.apply(fn)   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/torch/nn/modules/module.py", line 884, in apply     module.apply(fn)   [Previous line repeated 2 more times]   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/torch/nn/modules/module.py", line 885, in apply     fn(self)   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/diffusers/loaders.py", line 650, in _unfuse_lora_apply     module._unfuse_lora()   File "/home/drive/venvs/api-inference-community/lib/python3.10/site-packages/diffusers/models/lora.py", line 213, in _unfuse_lora     w_up = self.w_up.to(device=device).float() AttributeError: 'NoneType' object has no attribute 'to'

That's a regression on diffusers side, as it had been fixed before! Let's maybe check if it's a simple hotfix for them? But if not I agree let's release without and add it later!

That's a regression on diffusers side, as it had been fixed before! Let's maybe check if it's a simple hotfix for them? But if not I agree let's release without and add it later!

I confirm the problem is not happening on main, so let's keep the fuse/unfuse optim and change the diffusers lib requirements to point to current main


helm package should produce bitwise-deterministic tar files

We have a CI process for publishing charts where we try to determine if pushed repository needs to have it's charts built and published. We would like to do this with a bitwise comparison of the generated tgz files. This works for charts without dependencies, but it is inconsistent for charts with dependencies.
For the setup (Using v2.8.1):
charts
├── child1
│   └── Chart.yaml
├── child2
│   └── Chart.yaml
├── child3
│   └── Chart.yaml
└── parent
    ├── Chart.yaml
    └── requirements.yaml

With charts:
# child{1..3}/Chart.yaml
name: child{1..3}
version: 1.0.0

# parent/Chart.yaml
name: parent
version: 1.0.0

# parent/requirements.yaml
dependencies:
- name: child1
  repository: file://../child1
  version: "*"
- name: child2
  repository: file://../child2
  version: "*"
- name: child3
  repository: file://../child3
  version: "*"

Running:
# working dir: parent
$ helm dep update
$ for i in {1..1000}; do helm package . && sha256sum parent-1.0.0.tgz && rm parent-1.0.0.tgz; done

produces several (3, after a significant number of iterations) different shas. The shas also appear to be non-uniformly distributed (e.g. 1 sha appears 70% of the time).
My guess is that https://github.com/kubernetes/helm/blob/master/pkg/chartutil/save.go#L160 is iterating over dependencies in a non-deterministic order, thus producing different tar files.

I think this is actually due to gzip. Part of the gzip header has a mod time for whatever is compressed in the file, so by calling helm package multiple times, each one creates their own tarball which is then packaged by gzip and given a unique shasum because the modtime differed.
If you gunzip the .tgz, is the shasum identical between tarballs?

gunziping the tars still produces different tarballs. There still appear to be 3 different shasums.

Following up on my previous comment, you can even reproduce this yourself at home:
><> helm fetch stable/traefik
><> gunzip traefik-1.24.1.tgz
><> helm fetch stable/traefik
><> shasum -a 256 *
a032f1eba2c54b76d8de38d3763bab5ca5a6383af1156f30caf4595adaec67a0  traefik-1.24.1.tar
ebd78bdbbf63f557db8646c6351bfeeac849951334d4cbfc103ecc6bb1b170c5  traefik-1.24.1.tgz

So in this example, I've shown that I've got stable/traefik, both in compressed and decompressed versions from the official stable/traefik chart. If I gzip this up, we should be able to assert that we come up with the same shasum because the contents are the same, right?
Wrongo.
><> gzip traefik-1.24.1.tar
><> shasum -a 256 *
144eaa108aff820dd754e16732bbacd29accb41954d6249b4111623587fae415  traefik-1.24.1.tar.gz
ebd78bdbbf63f557db8646c6351bfeeac849951334d4cbfc103ecc6bb1b170c5  traefik-1.24.1.tgz

But the shasums of both the recently-gzipped tarball and the old shasum are still identical.
><> gunzip traefik-1.24.1.tar.gz
><> mv traefik-1.24.1.tar traefik-1.24.1.tar.1
><> gunzip traefik-1.24.1.tgz
><> mv traefik-1.24.1.tar traefik-1.24.1.tar.2
><> shasum -a 256 *
a032f1eba2c54b76d8de38d3763bab5ca5a6383af1156f30caf4595adaec67a0  traefik-1.24.1.tar.1
a032f1eba2c54b76d8de38d3763bab5ca5a6383af1156f30caf4595adaec67a0  traefik-1.24.1.tar.2

So in other words, if you want a deterministic shasum of the contents of the chart, I'd suggest decompressing the packages first before checking the shasum.
Would that work for you?

The timestamp issue in the default gzip settings appears to be irrelevant since there are only a few unique shas that appear in thousands of tests on helm package (whereas the shas from the gzip example appear to be purely random). It looks like writeToTar in pkg/chartutil/save.go specifies its own header here:  https://github.com/kubernetes/helm/blob/master/pkg/chartutil/save.go#L205.
Perhaps sorting the dependencies in a deterministic manner before serialization is all that is needed, but any help on where to put the sort would be appreciated.
For now a workaround is to do a file diff on the decompressed packages after removing the dependency tars. This won't catch differences in dependencies except version differences (which can happen for local dependencies, e.g.), but will catch most differences until this can be patched.

I was unable to reproduce this behaviour using a stable chart. Can you provide a sample chart that produces this behaviour?
My steps to test this:
$ helm fetch --untar stable/traefik
$ for i in {1..1000}; do helm package traefik/ && mv traefik-1.24.1.tgz traefik-1.24.1.tgz.$i; done
$ shasum -a 256 *.tgz* | awk '{print $1}' | uniq
ebd78bdbbf63f557db8646c6351bfeeac849951334d4cbfc103ecc6bb1b170c5

Every invocation of helm package returned a consistent shasum.
/shrug

https://github.com/cmaher/nondeterministic-charts demonstrates this using Client: &version.Version{SemVer:"v2.8.1", GitCommit:"6af75a8fd72e2aa18a2b278cfe5c7a1c5feca7f2", GitTreeState:"clean"}

I found out a way to reproduce this. One thing that seems to be helpful in reproducing is having more than one dependency in the requirements file. Also, the large the values.yaml file  the easier it is to reproduce as well.
spinnaker is an example stable chart to reproduce:
mkdir pkgs
cd spinnaker
helm dep up
for i in {1..30}; do helm package . && mv spinnaker-0.5.0.tgz ../pkgs/spinnaker-0.5.0.tgz.$i; done
cd ../pkgs
shasum -a 256 *.tgz* | awk '{print $1}' | uniq

/remove-lifecycle rotten

We have been able to reproduce this issue with some of our local charts as well.

The problem definitely manifests itself on macOS. None of the suggestions mentioned in this tread solve the issues. I've created a repo to demonstrate the problem and a workaround: https://github.com/adrian-gierakowski/helm-package-sha-test.

Is this related to dependencies, or is the issue just increasingly more likely to occur the more files a chart contains?

The issue is that the POSIX directory enumeration API does not define a specific order for file names to be returned. There may be a "common" order but since sorting/ordering is not something that can be done generically (it is locale/user specific), the core filesystems are not forced to provide a consistent order. Result orders may depend on available cache entries or order of data returned from elevator algorithms that read from the disk or a number of other out-of-order execution behaviors.

Is there really not a way enforce this order in Go? @Michael-Sinz

You can write your own code to take the enumeration and sort it.  Pick your sort to be consistent across all locales.
Unix/Posix does not push costly operations onto all use cases when most cases do not need that - it assumes that you would compose one operation with another to get the desired result.
__
Michael Sinz C Architect C http://midori/ v C Microsoft

From: Josh Dolitsky<EMAIL_ADDRESS>Sent: Wednesday, May 27, 2020 4:36 PM
To: helm/helm<EMAIL_ADDRESS>Cc: Michael Sinz<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [helm/helm] helm package should produce bitwise-deterministic tar files (#3612)
Is this related to dependencies, or is the issue just increasingly more likely to occur the more files a chart contains?
The issue is that the POSIX directory enumeration API does not define a specific order for file names to be returned. There may be a "common" order but since sorting/ordering is not something that can be done generically (it is locale/user specific), the core filesystems are not forced to provide a consistent order. Result orders may depend on available cache entries or order of data returned from elevator algorithms that read from the disk or a number of other out-of-order execution behaviors.
Is there really not a way enforce this order in Go? @Michael-Sinzhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMichael-Sinz&data=02|01|Michael.Sinz%40microsoft.com|7f787afb198646f162fc08d80296c2ef|72f988bf86f141af91ab2d7cd011db47|1|0|637262193827632571&sdata=5yvN1d7V5r1DYfxWZdVYeawCsSmPCOws73GJ68bY0m8%3D&reserved=0
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhelm%2Fhelm%2Fissues%2F3612%23issuecomment-634999466&data=02|01|Michael.Sinz%40microsoft.com|7f787afb198646f162fc08d80296c2ef|72f988bf86f141af91ab2d7cd011db47|1|0|637262193827632571&sdata=nE1BhhEAVlJaYWnLVFMs3dqW9sd89O%2Bw03m9jZi7IGE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIZINKSLFWKEXWDAUN3OGL3RTWPXJANCNFSM4ETXKHGQ&data=02|01|Michael.Sinz%40microsoft.com|7f787afb198646f162fc08d80296c2ef|72f988bf86f141af91ab2d7cd011db47|1|0|637262193827642528&sdata=9D784OITV0hBpmnLnLvUDIByZo%2FevAgnuYKA%2B5blDh4%3D&reserved=0.

Is there no progress on this issue.  The lack of deterministic output for constant input is a big problem.  It means that helm package is not deterministic and we can not depend on it producing the same results.  Imaging if a compiler could make different code for the same source code from run to run - how would you debug such a program?

Agreed. We've had to make clumsy workarounds to only package the chart if one of the source files changes. One issue is the embedded time stamps.

@Michael-Sinz I have not seen any activity from the community on this bug. Please feel free to work on a fix!

We still would like to have deterministic helm chart building.  The fact that the same helm chart from the same source tree from the same git hash with the same helm version does not produce deterministic hashes is concerning.

Deterministic output is the goal of the Reproducible builds  project.
It has a recommended tar example:
# requires GNU Tar 1.28+
$ tar --sort=name \
      --mtime="@${SOURCE_DATE_EPOCH}" \
      --owner=0 --group=0 --numeric-owner \
      --pax-option=exthdr.name=%d/PaxHeaders/%f,delete=atime,delete=ctime \
      -cf product.tar build

gz seems to produce reproducible output since 2018.
But as helm uses go libs, maybe the fix is around file order:
https://github.com/helm/helm/blob/f41f46c6c6a1fae459b51a110f76d60f33281f74/pkg/chartutil/save.go#L205-L228

Hi, we are really waiting for this issue to be fixed. Since real advantage of using OCI is that we make use of the delta changes in the chart that are only committed to the repository and this saves the space at the repository. We are leveraging this feature in OCI container images a lot. Without this feature, we cannot declare helm OCI support is moved to permanent from experimental.

/cc @jdolitsky @scottrigby

Any updates?

I can reproduce it like this:
$ helm version
version.BuildInfo{Version:"v3.10.0", GitCommit:"ce66412a723e4d89555dc67217607c6579ffcb21", GitTreeState:"clean", GoVersion:"go1.19.1"}
$ helm create foo
Creating foo
$ for i in {1..10}; do helm package foo >/dev/null; md5sum foo-0.1.0.tgz; sleep 0.5; done
39e2b6bff940ed840873926f271d72f8  foo-0.1.0.tgz
f34d771d8039d77c9b76340c7940ab55  foo-0.1.0.tgz
f34d771d8039d77c9b76340c7940ab55  foo-0.1.0.tgz
afe15ee8c34f069e967e88e70c7bbd29  foo-0.1.0.tgz
afe15ee8c34f069e967e88e70c7bbd29  foo-0.1.0.tgz
7c1b20acd7a9a73944af13fec2303cf0  foo-0.1.0.tgz
7c1b20acd7a9a73944af13fec2303cf0  foo-0.1.0.tgz
16cef47516265bed7f8dbd9ef145042c  foo-0.1.0.tgz
16cef47516265bed7f8dbd9ef145042c  foo-0.1.0.tgz
1532cb3b9a5d828e19d74b034caebace  foo-0.1.0.tgz

FWIW the example from reproducible builds worked well for me, but that obviously requires custom scripting, which is not ideal.

Fix for the above has been pending review/merge. Not sure what the blocker is TBH:
https://github.com/helm/helm/pull/10178


API docs missing load_sgraph

One of the 404s from #37 is actually to what looks like a correct URL; it seems the load_sgraph method is missing from the API docs. Should load_sframe be listed here as well?

Looks like these two function calls are missing from the sphinx .rst files


In mathjax, can we write CSS script on any particular mathematical character? Example as sigma and vector and round brackets

In mathjax, can we write CSS script on any particular mathematical character? Example as sigma and vector and round brackets

The html extension gives you access to some HTML features like styles, classes, element ID’s, and clickable links.


test: add missing tests; Prod release

Add tests to improve coverage; Release the package
BREAKING CHANGE: First release

Codecov Report

Merging #21 into master will increase coverage by 2.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   96.25%   98.75%   +2.50%
==========================================
  Files          13       13
  Lines         160      160
==========================================
+ Hits          154      158       +4
+ Misses          6        2       -4

Impacted Files
Coverage Δ

src/html/MediaTags.js
100.00% <0.00%> (+30.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c7040...37907c0. Read the comment docs.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to make sure extension is used

I use PHP 7.4.
My composer requires
"ext-ds": "^1.2",

and also required
"php-ds/php-ds": "^1.2",

To be honest I didn't even know about this polyfill until I have started searching for the possible source of a memleak I am experiencing.
If I follow the symbols in my code
namespace App\Service;
use Ds\Stack;
class MyService {
    public function bla() {
        $stack = new Stack();

It lead me to the polyfill. How can I be sure which code was used, native or polyfill?
Side question: any findings about possible memleaks in Stack?
In a long running process I am pushing and popping doctrine entities in it, and although repeatedly clearing the UnitOfWork, my memory usage goes into gigabytes.
Thanks in advance!

If extension is installed then extension is used. So if you have it in composer.json and didn't use --ignore-platform-reqs you can be sure your code uses the extension. You can also verify it using ReflectionClass - extension classes will have no file.

As for memory leak in Stack, try deleting the extension, forcing the polyfill and see if the leak persists. If it disappears then it suggests a leak in this extension. Also check which version of the extension you're using. There were some fixes in 1.3.

Yes I am using version 1.3.0.
I will try to use it without the extension.

I tried and it's not ds.
Thanks for your quick and helpful support!

you're welcome! good luck with the leak!


[RFC]: add @stdlib/assert/is-same-typed-array-like

Description
This RFC proposes adding a new assertion package to test whether two arguments are both typed-array-like objects and have the same values.
Package: @stdlib/assert/is-same-typed-array-like
Alias: isSameTypedArrayLike
Related Issues
No.
Questions
No.
Other
@stdlib/assert/is-same-array-like provides a reference implementation. One should only need to

update descriptions
use is-typed-array-like
update tests
update examples and documentation

Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

i would like to take this up !

i would like to take this up , working , will pr in 24 -48h

Did you worked on it or else I also would like to take up this issue

Working


Custom Clip in Decoder

Hi,
Is there a way to use a custom clip in the Decoder ? If yes what is the functions/output it should have to make this work ?
Thanks

Anyone ?


Optional/Mandatory attributes in Level Control Cluster

Problem
ZAP is showing wrong mandatoriness on level control cluster.
Change overview
Set optional=false for Conformance M for attributes OnLevel and Options.
Is there an agreed way of setting optional for certain PICS values? Many attributes are marked optional in XML, but are mandatory for e.g. LT/FQ Features.
Testing
No testing: Simple XML change.

I guess it requires a rebase to fix ZAP issues.

@markus-becker-tridonic-com - does this require a zap regen? See errors in tests  and zap.

Yes, zap regen is required. I was submitting this via WebUI from GitHub. Will check out the branch locally and rebase and regen, if the change looks sensible.


Bundle Sorald jar with buildbreaker

To make things a bit easier, we should bundle the latest stable version of Sorald with buildbreaker. This will make testing a whole lot easier, and since buildbreaker is only meant to be a prototype, it's a very reasonable way to speed up the prototyping.

To be clear, I intend to remove the possibility to specify a specific version of Sorald to download. It has the obvious downside of tying buildbreaker into a specific version of Sorald, but it will just make things so much easier during prototyping that it's worth that sacrifice.


Add command environment variables config

I needed the ability to pass through environment variables to refresh, and noticed it was missing from the configuration (there's only command flags at the moment), so I've added it in this PR. Thanks.

Awesome! Thanks!


Cherry-pick command improvement and bump version to v1.0.3

Cherry pick commands improvement from #184 #190
/kind improvement

/lgtm


Redirect user to login route on unauthorized access

The task is to redirect users to log in when they try to visit a protected route without login. This has to be done with the help of next js middleware and token cookies.

Hey can you list protected routes

Hey can you list protected routes

Yah ... I'd like to know which protected routes u're referring to.

Hey can you list protected routes

All routes under:

profile
dashboard
settings
billings-payments
refer-friend

Create a middleware file in the root directory and you need to check for a "token" cookie, if it exists then allow users to go to these routes otherwise redirect them to log in.
only work on the middleware.ts file in the root.
You will need to set your own Firebase project and environment with the template:
//Firebase
NEXT_PUBLIC_FIREBASE_API_KEY =
NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN =
NEXT_PUBLIC_FIREBASE_PROJECT_ID =
NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET =
NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID =
NEXT_PUBLIC_FIREBASE_APP_ID =
NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID =
FIREBASE_SERVICE_ACCOUNT_KEY = Service account json as string, without line breaks

Assign this to me please, I am beginner and interested in open source.

Hey can you list protected routes

All routes under:

profile
dashboard
settings
billings-payments
refer-friend

Create a middleware file in the root directory and you need to check for a "token" cookie, if it exists then allow users to go to these routes otherwise redirect them to log in.
only work on the middleware.ts file in the root.
You will need to set your own Firebase project and environment with the template:
//Firebase NEXT_PUBLIC_FIREBASE_API_KEY = NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN = NEXT_PUBLIC_FIREBASE_PROJECT_ID = NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET = NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID = NEXT_PUBLIC_FIREBASE_APP_ID = NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID =
FIREBASE_SERVICE_ACCOUNT_KEY = Service account json as string, without line breaks

If the user is already logged in then you have to redirect them to the home page if they are visiting the signing page.


[Admin GUI] Duplicate content in the admin settings

Hello, I found a bug in the settings section of the admin GUI.
The steps to reproduce can be found in the following gif :

Go to the "Auth providers" page in the settings section of the admin panel
Enable a sign-in method
Leave the client secret and client id blank
Click "Save changes"
Go to the logs page (or any other page)

It happens when switching from the auth providers page to an other page if an error occured before.
If the user provides valid information afterwards, the bug does not occur.

Thank you. I've submitted a fix in the temporary v0.11.0 branch (filter-enhancements) and it will be available with the next release soon.


HDFS-15329. Provide FileContext based ViewFSOverloadScheme implementation

2225

 Quality gate: Failed
4 Issues

 1 Vulnerabilities
 3 Code issues

Details

 Quality gate: Failed
4 Issues

 1 Vulnerabilities
 3 Code issues

Details


chore(ysugimoto/falco): use tar.gz

I fixed to use compressed files.
ysugimoto/falco has been added tar.gz files since v0.20.2

Thanks!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.160.0


NCCL out of memory on dual 2080ti training

I'm working on training script (https://github.com/rwightman/efficientnet-jax/blob/master/tf_linen_train.py) based on Flax Linen ImageNet example (https://github.com/google/flax/blob/master/linen_examples/imagenet/imagenet_lib.py). It was working great on a system with 2 x Titan RTX. The same setup on 2 x 2080Ti either completely hung (kill required) or crashed with a non specific NCCL error (unhandled system error).
After some debugging, enabling NCCL_DEBUG=INFO, it appears that the NCCL init is hitting an OOM condition. It only logs the OOM as a warning, and eventually propagates as a non-specific error. See log dump below.
I'm running this within a docker container, NGC Tensorflow 2 20.10. It has NCCL 2.7.8 and TF 2.3.1, CUDA 11.1. JAX and FLAX were built / installed from git master as of today. The pip wheel jaxlib cuda11 also had the issue.
Setting env variable XLA_PYTHON_CLIENT_MEM_FRACTION=0.85 fixed the problem on the 2080Ti system. I did not do an exhaustive search. Default is 0.9?
I'm somewhat confused as to why NCCL dumped a 2.7.3 version in the log when the container I'm running (and built jaxlib in) only has a 2.7.8 lib...
Log output
1de1c28a7548:559:653 [1] NCCL INFO Bootstrap : Using [0]eth0:<IP_ADDRESS><0>
1de1c28a7548:559:653 [1] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
1de1c28a7548:559:653 [1] NCCL INFO NET/IB : No device found.
1de1c28a7548:559:653 [1] NCCL INFO NET/Socket : Using [0]eth0:<IP_ADDRESS><0>
1de1c28a7548:559:653 [1] NCCL INFO Using network Socket
NCCL version 2.7.3+cudaCUDA_MAJOR.CUDA_MINOR
1de1c28a7548:559:1475 [0] NCCL INFO Channel 00/04 :    0   1
1de1c28a7548:559:1476 [1] NCCL INFO threadThresholds 8/8/64 | 16/8/64 | 8/8/64
1de1c28a7548:559:1475 [0] NCCL INFO Channel 01/04 :    0   1
1de1c28a7548:559:1476 [1] NCCL INFO Trees [0] -1/-1/-1->1->0|0->1->-1/-1/-1 [1] 0/-1/-1->1->-1|-1->1->0/-1/-1 [2] -1/-1/-1->1->0|0->1->-1/-1/-1 [3] 0/-1/-1->1->-1|-1->1->0/-1/-1
1de1c28a7548:559:1475 [0] NCCL INFO Channel 02/04 :    0   1
1de1c28a7548:559:1475 [0] NCCL INFO Channel 03/04 :    0   1
1de1c28a7548:559:1475 [0] NCCL INFO threadThresholds 8/8/64 | 16/8/64 | 8/8/64
1de1c28a7548:559:1475 [0] NCCL INFO Trees [0] 1/-1/-1->0->-1|-1->0->1/-1/-1 [1] -1/-1/-1->0->1|1->0->-1/-1/-1 [2] 1/-1/-1->0->-1|-1->0->1/-1/-1 [3] -1/-1/-1->0->1|1->0->-1/-1/-1
1de1c28a7548:559:1476 [1] NCCL INFO Channel 00 : 1[2000] -> 0[1000] via P2P/direct pointer
1de1c28a7548:559:1475 [0] NCCL INFO Channel 00 : 0[1000] -> 1[2000] via P2P/direct pointer

1de1c28a7548:559:1475 [0] bazel-out/k8-opt/bin/external/nccl_archive/_virtual_includes/include_hdrs/alloc.h:41 NCCL WARN Cuda failure 'out of memory'
1de1c28a7548:559:1475 [0] NCCL INFO external/nccl_archive/src/transport/p2p.cc:184 -> 1
1de1c28a7548:559:1475 [0] NCCL INFO external/nccl_archive/src/transport.cc:30 -> 1
1de1c28a7548:559:1475 [0] NCCL INFO external/nccl_archive/src/transport.cc:49 -> 1
1de1c28a7548:559:1475 [0] NCCL INFO external/nccl_archive/src/init.cc:771 -> 1
1de1c28a7548:559:1475 [0] NCCL INFO external/nccl_archive/src/init.cc:845 -> 1
1de1c28a7548:559:1475 [0] NCCL INFO external/nccl_archive/src/group.cc:73 -> 1 [Async thread]
1de1c28a7548:559:1476 [1] NCCL INFO Channel 01 : 1[2000] -> 0[1000] via P2P/direct pointer
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying
1de1c28a7548:559:1476 [1] NCCL INFO Call to connect returned Connection refused, retrying

1de1c28a7548:559:1476 [1] bazel-out/k8-opt/bin/external/nccl_archive/_virtual_includes/include_hdrs/socket.h:403 NCCL WARN Connect to <IP_ADDRESS><51505> failed : Connection refused
1de1c28a7548:559:1476 [1] NCCL INFO external/nccl_archive/src/bootstrap.cc:95 -> 2
1de1c28a7548:559:1476 [1] NCCL INFO external/nccl_archive/src/bootstrap.cc:363 -> 2
1de1c28a7548:559:1476 [1] NCCL INFO external/nccl_archive/src/transport.cc:59 -> 2
1de1c28a7548:559:1476 [1] NCCL INFO external/nccl_archive/src/init.cc:771 -> 2
1de1c28a7548:559:1476 [1] NCCL INFO external/nccl_archive/src/init.cc:845 -> 2
1de1c28a7548:559:1476 [1] NCCL INFO external/nccl_archive/src/group.cc:73 -> 2 [Async thread]
2020-11-19 02:22:41.227591: F external/org_tensorflow/tensorflow/compiler/xla/service/gpu/nccl_all_reduce_thunk.cc:265] Non-OK-status: status_ status: Internal: external/org_tensorflow/tensorflow/compiler/xla/service/gpu/nccl_all_reduce_thunk.cc:311: NCCL operation ncclGroupEnd() failed: unhandled system error
Fatal Python error: Aborted

We bundle NCCL with jaxlib, so that's why you see 2.7.3.
I guess there are two things we should do here:
a) we should fail more gracefully on NCCL OOM.
b) we should perhaps lower the default memory fraction.

@hawkinsp the graceful failure / better reporting would definitely save some time arriving at a solution, without the NCCL logging on INFO, the  'unhandled system error' wasn't much to go on.
Othwerise I guess it's a matter of tuning default fractions. Maybe it should vary with total GPU memory, is there any other variable that specifies a min free instead of a fraction? The default fraction was fine with larger memory cards.

@hawkinsp An update on this one. I rebuilt my containers with yesterday's jax/jaxlib master (rest of environment the same) after #5096 was resolved for me. The 2x2080Ti setup worked out of the box without requiring any mem fraction fiddling.

@rwightman can we consider this resolved?

@sudhakarsingh27 yup


Add note for OSX installation

Hi,
Mention that some modules are missing, and provide a link with instruction for recompilation + fix minor typo
Julien

thanks @barajus !


Adapt JU Scraper to scrape ncumul_hosp, ncumul_ICU and deceased

Currently, the JU scraper does only collect confirmed cases. Hospitalized and ICU cases as well as deceased (still empty) would be available as well:
https://www.jura.ch/fr/Autorites/Coronavirus/Accueil/Coronavirus-Informations-officielles-a-la-population-jurassienne.html
https://github.com/openZH/covid_19/blob/master/fallzahlen_kanton_total_csv/COVID19_Fallzahlen_Kanton_JU_total.csv

Related to #237

Looks like duplicate of https://github.com/openZH/covid_19/issues/146


Update uninstall step with DCRA removal text

@EdB-MSFT

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@EdB-MSFT Please let me know if there is anything that needs to be updated here. I have updated the uninstall command with the DCRA deletion too since that was missing in the docs.

#sign-off


View Formatting schema - hideColumnHeaders should be hideListHeader

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
The view formatting schema (https://developer.microsoft.com/json-schemas/sp/view-formatting.schema.json) should have a property called hideListHeader.
Observed Behavior
The view formatting schema has a property called hideColumnHeaders. This property is actually hideListHeader.
hideColumnHeaders

hideListHeadder

Steps to Reproduce
Create a view format and set hideColumnHeaders to true and see nothing happen when applied to a view. Change that to hideListHeader still with a value of true and watch the list header disappear when applied to a view.
Submission Guidelines

All suggestions or bugs are welcome, please let us know what's on your mind.
If you are reporting an issue around any of the documents or articles, please ensure that you have clear > reference on the specific file or URL, which should be fixed.
If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and > #spfx-tooling on (SharePoint StackExchange)[http://sharepoint.stackexchange.com/]. You can also > alternatively submit your question to (SharePoint Developer group)> [https://network.office.com/t5/SharePoint-Developer/bd-p/SharePointDev] at Office Network.
Remember to include sufficient details and context.
If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.

(DELETE THIS PARAGRAPH AFTER READING)

Thanks for your contribution! Sharing is caring.

Thanks for reporting.  We will update the schema soon.  "hideColumnHeader" is what the schema should contain.  "HideListHeader" also works but won't be in the schema.

Schema files have been now updated, which should resolve this issue. Can you @thechriskent confirm that it's the case and we'll close this one. Thx.

Everything looks great, thanks!


Add Support for dangvantuan/sentence-camembert-base: Fixes #137

Onnx file:
notebook: https://colab.research.google.com/drive/1WnpzMumZ8cuwz9_EGFwsQnHHVjzSFre8#scrollTo=W1JLb0pDms2d
Huggingfacehub:
https://huggingface.co/yashvardhan7/fast-sentence-camembert-base/blob/main/fast-sentence-camembert-base.tar.gz

There are too many small mistakes here for me to review.

Please raise a fresh PR when the tests clear on your local
One model at a time

Really sorry but  all the tests have passed on my local machine.This one was just behind those two PRs, I raised this one so that it will save your time in merging all together.


Running on a GPU

It isn't clear whether this can run using a gpu. Tried with the tf-nightly-gpu build and I'm getting an error.
It isn't clear whether its the library or tensorflow itself. The environment is colab.
The error itself is detailed here:
https://github.com/tensorflow/tensorflow/issues/40385

Seems to be somewhere between TF and TF probability. EasyAgents is sitting on top of TF-agents, which in turn sits on TF. So I guess our chances are small to help from the EasyAgets side. Or do you have an suggestions ? In any case, we will try to update the direct dependencies of EasyAgents the next few weeks. So maybe that might then also have a "beneficial" impact.

I know for sure that using tf agents installed by easyagents as a
dependency runs on GPU if there is one. Wouldn't be able to think of any
reason why easyagents itself should interfere.
On Sun, 6 Sep 2020, 20:18 Christian Hidber<EMAIL_ADDRESS>wrote:

Seems to be somewhere between TF and TF probability. EasyAgents is sitting
on top of TF-agents, which in turn sits on TF. So I guess our chances are
small to help from the EasyAgets side. Or do you have an suggestions ? In
any case, we will try to update the direct dependencies of EasyAgents the
next few weeks. So maybe that might then also have a "beneficial" impact.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/christianhidber/easyagents/issues/111#issuecomment-687861002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADAJKL2NSP42QQLQ4UMTXDSEPHBBANCNFSM4QUZSC7A
.

Yeah this is looking more and more like a Tensorflow issue. Tried in Rllib and getting the same thing.


🐞 :  Scroll to top button is getting overlapped

:red_circle: Scroll to top button is getting overlapped :
:red_circle: Bug :
:red_circle: Changes :  i will change the z-index for this section
Screenshots 📷

✅ Details to Include When Taking the Issue:
Name : Hacktoberfest
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.):

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

issue solved


Always pass transform(s) to abstract dataset

Kicked of by @zhiqwang (comment). Now, transforms, transform, and target_transform are passed to VisionDataset.__init__() for all datasets as intended.
@fmassa Should the usage of separate transforms deprecated? I'm asking since SBDataset only has joint transform:
https://github.com/pytorch/vision/blob/8837e0efbe16dc07ccdd4f1d06460643c7b41c50/torchvision/datasets/sbd.py#L52-L57
I'll fix the docstrings afterwards.

Thanks for the PR! I'll have it reviewed tomorrow.
Just to answer your question:

@fmassa Should the usage of separate transforms deprecated? I'm asking since SBDataset only has joint transform:

I think we should still keep the separate transforms for now, as in most cases it's simpler for the user.

I think we should still keep the separate transforms for now, as in most cases it's simpler for the user.

Should I add it to SBDataset?

Codecov Report

Merging #1126 into master will increase coverage by 0.32%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
+ Coverage   64.89%   65.22%   +0.32%
==========================================
  Files          68       68
  Lines        5413     5380      -33
  Branches      835      835
==========================================
- Hits         3513     3509       -4
+ Misses       1643     1615      -28
+ Partials      257      256       -1

Impacted Files
Coverage Δ

torchvision/datasets/phototour.py
24.24% <0%> (+0.24%)
:arrow_up:

torchvision/datasets/fakedata.py
26.92% <0%> (ø)
:arrow_up:

torchvision/datasets/cifar.py
78.16% <100%> (-0.5%)
:arrow_down:

torchvision/datasets/folder.py
82.05% <100%> (-0.45%)
:arrow_down:

torchvision/datasets/mnist.py
50.71% <100%> (-0.47%)
:arrow_down:

torchvision/datasets/svhn.py
66% <100%> (-1.31%)
:arrow_down:

torchvision/datasets/flickr.py
24.67% <50%> (+1.21%)
:arrow_up:

torchvision/datasets/caltech.py
21.59% <50%> (+0.93%)
:arrow_up:

torchvision/datasets/lsun.py
21.59% <50%> (+0.93%)
:arrow_up:

torchvision/datasets/omniglot.py
33.33% <50%> (+1.33%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8837e0e...426ad9d. Read the comment docs.

In the references directory, the dataset of CocoDetection also have this problem:
https://github.com/pytorch/vision/blob/8837e0efbe16dc07ccdd4f1d06460643c7b41c50/references/detection/coco_utils.py#L209
Is it necessary to pass transforms (here is _transforms) to the constructor?

@zhiqwang that is a custom dataset wrapper, and I on purpose not passed it to the constructor because I want the transforms to be applied after modifying the annotations to include the img_id, see https://github.com/pytorch/vision/blob/8837e0efbe16dc07ccdd4f1d06460643c7b41c50/references/detection/coco_utils.py#L216
Ideally I'd remove that and let the image id be returned by the dataloader, but that is currently not possible.
@pmeier

Should I add it to SBDataset?

Sure, why not! But it generally makes more sense to have joint transforms only because it are a segmentation dataset, and if you perform a transformation on the image you generally need to apply the same one to the target.

@fmassa Thanks for your explanation, and it help me understand the detection datasets a lot.


PropTypes error when using code from docs

Bug Report
Steps
The error prop on Form.Input is typed as boolean | undefined, yet this code example, https://react.semantic-ui.com/collections/form/#states-field-error-label, uses an object to display an error.
Expected Result
Use an object to add an error to a field
Actual Result
Warning: Failed prop type: Invalid prop `error` of type `object` supplied to `FormField`, expected `boolean`.
    in FormField (created by FormInput)
    in FormInput (at ContactPage.tsx:40)
    in form (created by Form)
    in Form (at ContactPage.tsx:32)
    in div (created by Container)
    in Container (at ContactPage.tsx:26)
    in ContactPage (created by Context.Consumer)
    in Route (at App.tsx:43)
    in Switch (at App.tsx:37)
    in div (at App.tsx:34)
    in Router (created by BrowserRouter)
    in BrowserRouter (at App.tsx:33)
    in App (at src/index.tsx:9)

Version
0.87.1

This functionality was added in #3603 and was released in 0.87.3:

Thank you


⚠ Bofrost.es has degraded performance

In 3d6203a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1386 ms

Resolved: Bofrost.es performance has improved in 1ec07c1 after 6 minutes.


Demo Link Not Working.

Hi All,
I am trying to check plugin demo link..but it looks demo link is now working.
Thanks,
Sumit

+1

+1

+1

+1

+1


Provide access to SubsystemHandle

I have a use-case where I need to start a bunch of tasks in several loops.
That is very impractical to do with toplevel not providing an interface when it doesn't take ownership.
I think I'd be fine with just subsystem(&self) -> &SubsystemHandle. That seems to be the most flexible for other operations as well.
In addition, it is not possible to start a nested subsystem at top-level, without Send+'static on all used items, because it is again required to have access to the SubsystemHandle for this. If I have e.g. an &mut something to update as I start my nested subsystem, whose output is used to start another system, that won't work.
Again, subsystem(&self) -> &SubsystemHandle solves this.

 Tasks only get cleaned up when the (nested) toplevel gets destroyed, as can be seen by the output at the end of the toplevel. Just so you are aware, but if you are using nested toplevel already, you probably already worked around that issue.
This is a limitation of the current implementation and I am currently playing around with a compete rewrite to solve this... So I apologize.
Apart of that, would you mind sending me a usecase example of how you would use said subsystem() function in your code? Because currently I don't really see how that would work... Yes, Send + Sync is required, but everything you put on a tokio::spawn needs that, so I don't completely understand your usecase. Well technically it only needs Send, it's that the problem? Your variables are not Sync?

I don't fully understand the second half of your problem, though. Why exactly would that not work?

Here is a test that showcases both use-cases:
041f191 (#55)

Sorry about the delay.
How about this?
use tokio::sync::oneshot;
use tokio_graceful_shutdown::*;

#[derive(Debug)]
struct MonitoringRegistry;

struct Tasks {
    monitoring_sender: oneshot::Sender<MonitoringRegistry>,
}

#[async_trait::async_trait]
impl IntoSubsystem<anyhow::Error, anyhow::Error> for Tasks {
    async fn run(self, handle: SubsystemHandle<anyhow::Error>) -> anyhow::Result<()> {
        // Obviously these two things are more complex in reality
        // thing needs &mut monitoring to initialize, and then that needs to be moved
        // to the Monitoring task
        let mut monitoring_registry = MonitoringRegistry;
        fn init_thing(_monitoring_registry: &mut MonitoringRegistry) {}

        let mut tasks = Toplevel::nested(&handle, "Tasks");
        for task in 0..2 {
            let thing_to_work_on = init_thing(&mut monitoring_registry);
            // By the way I would also like to not reallocate that string, although it does not matter
            // too much
            tasks = tasks.start(&format!("Task {task}"), move |subsystem| async move {
                // This simulates normal work with, but obviously it would normally wait on select
                // on `thing` and on_shutdown_requested
                let _thing = thing_to_work_on;
                subsystem.on_shutdown_requested().await;

                // Simulates the time it takes to gracefully shutdown
                println!("Shutting down thing task {task}");
                tokio::time::sleep(std::time::Duration::from_millis(200)).await;
                println!("Shut down task {task}");
                Ok::<(), anyhow::Error>(())
            });
        }

        // Initialization over, propagate the registry to the monitoring task
        self.monitoring_sender.send(monitoring_registry).unwrap();

        tasks = tasks.start("Ctrl+C", |handle| async move {
            tokio::time::sleep(std::time::Duration::from_millis(100)).await;
            println!("Time to shut down!");
            handle.request_shutdown();
            anyhow::Result::<()>::Ok(())
        });

        let res = tasks
            //.catch_signals() - normally we would put that here
            .handle_shutdown_requests(std::time::Duration::from_millis(300))
            .await;
        println!("All thing tasks have shut down, propagating up");
        handle.request_global_shutdown();

        res.map_err(Into::into)
    }
}

/// **This should show:**
///
/// Time to shut down!


[build] Remove unemployed 'skip-{build,test}-*' flags from build-script-impl

These flags have done nothing for awhile, as 26 of 31 have already been moved to build-script. Only the flags related to haiku, maccatalyst, and external-benchmarks are unrecognized by either build script after this removal.
I just checked to see if --skip-build-linux would disable building all products for that platform, as I've been doing manually when cross-compiling the toolchain for Android, and was surprised to find that the flag did nothing in build-script-impl. I investigated further and found that these 30 flags do nothing too, as most of them have been moved to build-script and their functionality removed from the bash script, eg #26495.
The haiku-related functionality has been swept aside over time, while maccatalyst never did anything, maybe because the actual implementation hasn't been open-sourced? I noticed that another flag from that Catalyst pull does nothing, but didn't remove it here.
@gottesmm, all the implementation of --build-external-benchmarks has been moved to build-script and the Python scripts. You could add back a --skip-build-external benchmarks there that actually works, but since the default is to skip it, probably not needed.
@Rostepher, review requested.

@edymtt can probably review this change. I'm no longer working on the Swift project.

@bitjammer, looks like you added a lot of these flags, review requested.

I haven't edited this file since it was reorganized some years ago. I recommend asking @shahmishal if he or someone else can review on this one. Thanks!

@swift-ci smoke test

@swift-ci build toolchain

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 587973fd8b31d86e981401be0a3fcd0698b31f20
Install command
tar zxf  swift-PR-33154-409-ubuntu16.04.tar.gz
More info

macOS Toolchain
Download Toolchain
Git Sha - 587973fd8b31d86e981401be0a3fcd0698b31f20
Install command
tar -zxf  swift-PR-33154-585-osx.tar.gz --directory ~/

@swift-ci please smoke test Linux platform

@buttaface You can remove all of the cmake build benchmark external.

You can remove all of the cmake build benchmark external.

All bash flags in this pull were removed because I could find no trace of them being used in the bash script build-script-impl, ie none are used anywhere or passed to any of the CMake invocations in the script. All usage of these flags has long since been removed, I'm just taking the last step of removing the unused flags.

Ping, ready to go?

Ping @shahmishal, ready to merge, though you may need to rerun the CI with the latest commit from the main branch first.

@swift-ci test and merge


Modify page to allow account addition & switching

This is to address #2.

@fgnass should be ready to merge if you want it in master
Cheers!

Could we merge this? this would be very helpful.


File names with invalid characters

I am trying to download a folder but some file names contained invalid characters (generated sometime probably before upload from the character ü. When I download them, I get the error
Exception in thread Thread-687 (download_file):
Traceback (most recent call last):
  File "C:\\\\threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "C:\\\\threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "C:\\\\mediafire.py", line 270, in download_file
    with open(filename, "wb") as f:
         ^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 22] Invalid argument: 'Fl?gel Variationen op.12.pdf'

When I download the file manually the ? is rendered as �.
Suggested solution: Make it replace invalid characters with something like -.

Hi, can you post the folder link? Thanks


test: simplify the checks (NFC)

Use pointer size to determine 32-bit vs 64-bit and then check appropriately.
Use a shared check to ensure that the same pattern occurs on all targets.  NFC.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test


clair: fix clair config issue (PROJQUAY-3430)

Clair structs can't even serialize and unserialize themselves properly.
If we use its exposed Config struct it uses LogLevel as int but the
application (Clair) needs it to be a string.

LGTM, but I am wondering if we need to drop the clair config struct completely? @hdonnay Would this function be called during a yaml unmarshal? https://github.com/quay/clair/blob/main/config/enums.go#L60 Or do you think there is a better way of generating a clair config from this module?

Gopkg.in/yaml.v2 and gopkg.in/yaml.v3 both use the TextMarshaler interface, so it should round-trip the same way it does with json, e.g.
package config_test

import (
	"encoding/json"
	"fmt"
	"strings"

	"github.com/quay/clair/config"
)

func ExampleMarshal() {
	var cfg config.Config
	var b strings.Builder

	if err := json.NewEncoder(&b).Encode(&cfg); err != nil {
		panic(err)
	}
	fmt.Println(b.String())
	// Output:
	// {"http_listen_addr":"","introspection_addr":"","log_level":"info","indexer":{"scanner":{},"connstring":""},"matcher":{"connstring":"","indexer_addr":"","update_retention":0},"matchers":{"names":null},"updaters":{"filter":""},"notifier":{"connstring":"","indexer_addr":"","matcher_addr":""},"auth":{},"trace":{"name":"","jaeger":{"agent":{"endpoint":""},"collector":{"endpoint":""}}},"metrics":{"prometheus":{},"name":""}}
}

That said, the zero value of a config.Config isn't the defaults, so regardless of whether you populate it and render it or do something else, the code should probably still call Lint.


Error opening GeoTiff raster file

This issue was imported from CodePlex
jirikadlec2 wrote 2011-02-05 at 09:48
I'm trying to open the attached GeoTiff (*.tif) raster file in the DotSpatial DemoMap application. When open the file using the "Add Layer" button, nothing shows on the map.
The problem is in the GdalRasterProvider.Open() method.
The bandtype of my GeoTiff file is identified as: bandtype == ColorInterp.GCI_GrayIndex which makes GDAL think that the file is an image.
In fact, the file is an Int - type raster.
If I remove the bandtype == ColorInterp.CGI_GrayIndex, then my raster is correctly displayed in the map.
However, I'm not quite whether removing the bandtype == ColorInterp.CGI_GrayIndex condition would cause errors when opening other GDAL images or rasters.
Another possible fix is to check the band.GetRasterColorInterpretation() method.
Any suggestions?
jirikadlec2 wrote 2011-02-05 at 18:31
I've fixed this issue for my raster by instructing GdalRasterProvider to open single-band grayscale GeoTiff files as rasters. For any other raster formats, bandtype==ColorInterp.CGI_GrayIndex will still be interpreted as image.
More unit tests for opening various types and sizes of GeoTiff rasters and images are required.
jlkittle wrote 2011-06-16 at 02:56
Mass closing of fixed items.
** Closed by jlkittle 06/15/2011 3:56PM
jlkittle wrote 2011-06-22 at 18:09
we have this issue with a NLCD2001 landcover raster file. it's bandtype is GCI_PaletteIndex.
the call to IsGeoTiffRaster returns false as only bandtype == ColorInterp.GCI_GrayIndex returns true.
vatavian wrote 2011-06-22 at 23:21
A proposed fix for this is pushed into Mercurial at rev 885:
In GdalRasterProvider.Open(string fileName)
remove the section of code testing bandtype and calling IsGeoTiffRaster.
This makes it always try GetBand for single-band GDAL files and if that succeeds, it gets opened as a raster. Since we are in GdalRasterProvider, I think we should go ahead and try to open it as a raster if it can be rather than guess that maybe someone really
wanted an image and refuse to open it as a raster.
I do not think we have a complete plan for when to open as image vs. raster. In MW4 this is handled by a project-level flag rather than trying to determine automatically which files are intended as images vs. grids.
I agree that we need more unit tests that open various GeoTiff files.

Not reproduced.

I switched from VirtualBox to VMware and that seems to solve the issue for me.


Images do not load

Describe the bug
No images from dataset are able to load since the gradio update. All images are 403.
To Reproduce
Steps to reproduce the behavior:

Install and run per normal
Load any dataset that previously worked
No images load, browser console has 403 errors for each dataset image, no output in terminal.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Environment (please complete the following information):

OS: Linux, Ubuntu 20.04
Browser: Firefox 125.0.2 and Chrome 124.0.6367.118
Version of this app: 6192be5 on Python 3.10.14

Additional context
Initially did an upgrade and got this issues. Did a complete fresh install for testing and repo'd the issue there too.

Possible solutions are here

That was exactly it, thanks.
Had checked settings, didn't see anything obvious, but light gray text Gradio uses is quite hard for me to read (that's accessibility issue with Gradio itself, and general all Modern UI design that loves gray on grey for their neglected light themes), so I missed that. Derp.


missing data/resources.json

make resource mentioned in the README fails with the error
$ make resource
deno run --allow-write src/scripts/resource.ts
error: Module not found "file:///tmp/neovimcraft/data/resources.json".
    at file:///tmp/neovimcraft/src/scripts/resource.ts:1:26
make: *** [Makefile:9: resource] Error 1

Looking at https://github.com/neurosnap/neovimcraft/commit/52a33785b73ce89b7a49ba30338a813fb75646e1 maybe this is old doc and should be removed?

I thought I'd add https://github.com/amitds1997/remote-nvim.nvim mannually, but it doesn't seem to be the way to be done either.

It works fine now! I decided to first further test the plugin I wanted to submit before doing it. Thanks for neovimcraft!


Check if it's practical to simplify the query structure with links using links2

The current query structure has multiple stages:

The innermost query fetches all paths in the graph that's being queried. Only the contract IDs are fetched in this step. Some limited OFFSET/LIMIT handling is also done here if required.
These paths are split and deduplicated into individual edges.
The edges are put inside a MATERIALIZED CTE to prevent PG from using some really bad query plans. Unfortunately there's no other way to create an optimization barrier that I know of.
The actual contract data is fetched and the link tree is reconstructed based on the edges stored previously. This step may fetch the same contract multiple times as it builds a tree and not a graph. ORDER BY, OFFSET, and LIMIT are handled here too.

This is the structure I arrived at after a lot of testing with large test DBs. "Obvious" methods like subqueries or lateral joins did significantly worse in the worst case, even if they might have been faster in some easier cases. Unfortunately, this structure also requires complex queries that can be hard to understand and debug. It is designed to "handle" postgres and keep it in the happy path.
Since moving to the links2 table and seeing how it performs compared to the previous table I've wondered if this complexity is still necessary nowadays. This is going to be a tracking issue for benchmarks and redesigns if alternatives shown to be desirable.

[ ] Benchmark and analyze query plans in a database with 10 million contracts for the following basic scenarios:

[ ] Query a must exist link that exists:

[ ] Current

[ ] Query a must exist link that does not exist:

[ ] Current

[ ] Query a may exist link that exists:

[ ] Current

[ ] Query a may exist link that does not exist:

[ ] Current

[ ] Query a must exist link pair where both exists:

[ ] Current

[ ] Query a must exist link pair where one exists:

[ ] Current

[ ] Query a must exist link pair where neither exists:

[ ] Current

For each scenario, test the following variants:

Trivial match: all contracts have their ID specified. The result set is one with one link (if applicable). This is the easiest case and any method that doesn't do well here must be burned with fire.
Sequential: only the root contract has its ID specified. The result set is one with 10k links (if applicable). This case tests for the fairly common case where we query for a specific card and all its links.
Reverse: only the links have their ID specified. The result set is 10k contracts, each with the same single link (if applicable). This case tests for the not-so-common case where we query for all cards that have a specific link. This case can also be particularly hard for methods that hardcode the order of operations, like subqueries.
Aggregate match: no IDs are specified. The result set is 10k contracts, each with 10k links. This case is hard and tests for underspecified queries. Only applicable for the scenarios where the links exist.
Aggregate unmatch: no IDs are specified. The result set is empty. This is the hardest case and will cause plenty of churn but it useful to test how well the query planner works with the query structure in the worst case (I've seen things....). Only applicable for the scenarios where the links exist.

For all queries, contracts have their types and one common and indexed data field specified. Both the root and the links have the same amount of random contracts but different types. The queries must return the the full contract as JSONB to prevent postgres from muddling the results with too much optimization.
While I don't think it's useful to test these right away, the method must be able to skip, limit and order both root cards and links.
For the tests I'll use postgres 13.4 with the default configuration and with the database stored in a ramdisk.

Not going to work on this right away as my queue is already full.
cc @LucianBuzzo @joshbwlng @Hades32 @Page- @thgreasi if you have any ideas or interest in following ^


English language button on Push notifications page broken

Buttons for multilangual text on https://www.inter-actief.utwente.nl/members/push/ are broken. As these fields are required for submit the whole form doesn't work.

Also fails on activity mailings, like e.g. https://www.staging.inter-actief.utwente.nl/activities/6100/mailing/


Beta Plan for Spark-Kubernetes

As per our discussion today, just formalizing the different focus areas and the people associated with each effort.
Code Freeze: May 23
@mccheah @ash211

Submission server
Compatibility testing (with internal applications)
Dynamic executor scaling
Release branch

@ssuchter @varunkatta @kimoonkim

Scale test for large SparkJobs to read/write data to HDFS
Locality optimization (HDFS/Spark)
Executor recovery edge cases - manual tests & possibly automated ones as well
Spark Metrics documentation (with @erikerlandson)

@erikerlandson

Verify working with OpenShift
Tests against reference applications for Spark - investigate if it can be used in integration tests

@foxish

Dynamic Executor Allocation
ThirdPartyResources for SparkJobs
Test plan for beta
Release branch
Rebasing to Spark 2.2.0 and testing

@tnachen

Documentation: "internals" doc to help folks understand how the integration works

Other important unclaimed items:

Custom Executor and Driver Pod YAMLs
Custom images and documentation around that

cc @iyanuobidele
Thanks for taking on TPR support again.

@foxish probably can close this issue now that the release off the 2.2.0 branch is out?


Add 1891/1892/1909 to London

The following locations were added:

1891: Google Street View
1892: Google Street View
1909: Google Street View

@oobrien, thank you for your contribution!
I must say though that I've failed to explain the system I'm currently using with the TODO (https://year-on-facade.uk/stats/?city=TODO) as the list of items I'm aware of, but haven't visited yet. I do have 1891, 1892 and 1909 in it already.
I should probably merge London and TODO to not confuse potential contributors 🤔 + add TODO filter to the map for planning my future journeys. Will do this today.


Revert #1946

Revert #1946 as it breaks the case when a slash is URL-encoded within a segment. See issue #2176
This reverts commit c2d7ae48f836b70b1f9624bcb1c4f0ca18fdd18c, reversing
changes made to 7aabd47614448326ecb3908eec2a6440f36b50b9.

Coverage decreased (-0.001%) to 98.088% when pulling 28e9044dece38350132a86a1b70533eb58567a34 on akrabat:revert-1946 into 30888b9c886360f50e7251ec7ea53d7d1f4b211a on slimphp:3.x.


Add GetBlockByNumber RPC method

Pull Request Test Coverage Report for Build 87

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.487%

Totals

Change from base Build 86:
0.0%

Covered Lines:
833

Relevant Lines:
845

💛  - Coveralls

Hi! Any news about this? Thanks.


Upgrade to libGDX 1.9.12

I've upgrade to new libGDX version and fixed scrolled breaking change.
Regards :)

Thanks! This is a breaking change though. I'll have to release current version before merging this.

Oops didnt check before my own PR. Im not sure about that Spinner change, ill check how it works on a mac.

Would be nice to have this merged asap.

I'll try to do release over the weekend.

Done, released for both versions:

VisUI
LibGDX

1.4.7
1.9.11

1.4.8
1.9.12

1.4.9-SNAPSHOT
1.9.12

I've changed it like in #345. I don't see why spinner should also use amountX.


Alpha » Local Storage Pane

Various TODO items for Tandem MVP launch.
Progress Legend
⬜ - Hasn't started
📝 - In Progress
✅ - Complete
Release Target Legend
🕹 - Alpha
🏁 - Beta
🚀 - Launch
🍿 - Post launch
TODOS (in order of priority)

Release Target
Issue
PR
Feature
Progress

🏁
????
????
each window should contain its own local storage
⬜

Won't implement. Tandem has been scoped down to only support Paperclip.


Upgrade to Scala 3

Upgrade to Scala 3, All the code needs to upgrade to the new syntax and to be tested

The project is still a mix of Scala 3 and Scala 2, because some libraries are still working with Scala 2 (Pekko and Spray). Pekko should move to Scala 3 pretty soon and for JSON we should replace Spray with Grapple


"Failed to add file", "Failed to rename" error messages... but it actually worked

Describe the bug
A "failed..." message pops up when
Add new folder
or Add new file
or Rename file
To Reproduce
Steps to reproduce the behavior:
See screenshots below
Expected behavior
No error messages because adding and renaming seem to have worked! :)
Screenshots
New folder:

Adding file:

Renaming file:

Desktop (please complete the following information):

OS: Ubuntu 18.04 64 bit
Browser Chrome 85
Version http://<IP_ADDRESS>:5001/ipfs/bafybeigkbbjnltbd4ewfj7elajsbnjwinyk6tiilczkqsibf3o7dcr6nn4   revision 637e0f1

Thanks, @sovxx -- we will review in our next weekly triage!

@Sovxx I believe this is fixed in v2.11 which shipped recently  and is available at https://webui.ipfs.io
It  will ship with go-ipfs 0.7 and the next version of ipfs-desktop.


Issue with bootstrap flexbox

I have a bootstrap layout with sidebar, when swiper initialized. layout broke up and slider stretched to the full width.
please check codepen demo-
https://codepen.io/pndtsonu/pen/deLgBa?editors=1010

Can't see any issues in your pen

@nolimits4web Just comment initialization script and you will see the changes in layout.
I have fix this by adding following css.
.swiper-slide{   width: auto !important;   flex-basis: 100%; }

Closing as fixed


add_columns dataset API

We have an add_columns() API for fragments, and a merge() API for dataset. It would be nice to create a add_columns() API for dataset that is similar to the one for fragments.
It would also be very nice to add progress tracking as an option there, since this might be a long operation. For example, users might call this API to add a new embedding column to the dataset.

We would also like to support a compute expression, so users can easily do a cast, for example.
The API could look like:
def add_columns(exprs_or_udf: Dict[str, str] | AddColumnUDF):
    ...

Then users could write expressions:
dataset.add_columns({"bloat16_vec": "cast(vector as array<bfloat16, 512>)"})

Or could specify a UDF using some decorator:
pool = ThreadPoolExecutor(8)

@add_columns_udf(
   reads_columns=['vector'],
   pool=pool,
)
def cast_bfloat16(batch: pa.RecordBatch):
    ...

dataset.add_columns(cast_bfloat16)

The pool parameter is important with UDFs to allow some parallism.

Another requirement: for the UDF, it would be nice to provide some way for the data to be staged so that it can be resumed in case of a crash.


Directives is not work in scope.$evalText?

Hello, I want to make modal window based on twitter bootstrap, current prototype:
var product_template = $.ajax({url: '/static/views/products/quickview.html', async: false}).responseText;
$('#product-details-modal').on('show.bs.modal', function (event) {
    var id = $(event.relatedTarget).data('id');
    var modal = $(this);
    $.get('/p/f/' + id + '/', {}, function (product) {
        var scope = alight.Scope();
        scope.product = product;
        var html = scope.$evalText(product_template);
        modal.html(html);
    });
});

The variables in the template output, but the directive (eg al-if, al-show, al-repeat) do not work. What am i doing wrong?
Example of "/static/views/products/quickview.html"

{{ product.name }}

Hello.
You need to use alight.applyBindings(scope, modal[0]);, it binds scope to the DOM.
Here you can see a few ways to bind.
I've made an example for you.
But I prefer to use it as a separate object, you can call alight.openModal('dialog.html'); from everywhere, example.

Thanks, modal window works very well


Update ARO operator Azure auth scheme to use a DefaultAzureCredential

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-3992
https://issues.redhat.com/browse/ARO-3987
https://issues.redhat.com/browse/ARO-3988

What this PR does / why we need it:
This PR updates the ARO operator to authenticate to Azure using a DefaultAzureCredential, which will work with both a CSP and WI.
To get it working with a CSP, I had to make a few other changes:

Have the ARO operator get the Azure authentication details from Secret values that are put into the Pod via environment variables
Add a CredentialsRequest to the ARO operator deployment, which tells the CCO (cloud credential operator) to create an Azure creds Secret in the ARO operator's namespace
Restart the ARO operator (master only) when customers rotate their CSP credentials (to ensure the new Secret value is read in). The az aro update process will also now verify that the CredentialsRequest mentioned in the bullet above has been reconciled (and thus the Secret has been updated) before doing this restart.

Note that to get the ARO operator working on an ARO WI cluster later on, we'll need a follow-up PR to have the operator Pod 1) use AZURE_FEDERATED_TOKEN_FILE instead of AZURE_CLIENT_SECRET and 2) mount a bound service account token (more info in testing steps below because I had to do it manually; the testing steps could also be a useful reference for the engineer who makes the follow-up PR).
Test plan for issue:
There were a few different things to test:

The new authentication scheme works with a CSP cluster

Tested by provisioning a dev cluster and observing the operator successfully doing stuff to Azure resources in response to changes I was making on the cluster
Will also be covered in E2E

The operator still authenticates to Azure successfully and continues to work after rotating the CSP's client secret via an az aro update --refresh-credentials

I ran an az aro update --refresh-credentials against my dev cluster and observed the ARO operator master Pod get replaced during the Deployment rollout.
I then used the Portal to remove the Microsoft.Storage service endpoint from both cluster subnets.
Then I scaled down one of the worker MachineSets to trigger the subnets controller. The subnets controller added the service endpoint back successfully.

I observed some 401 Azure authentication errors immediately after the new operator master Pod started up. It seems like there is short lag before the correct Secret value makes it into the Pod, but it eventually worked with no intervention (per my test results). Just mentioning here because it was interesting to me.

The new authentication scheme works with a WI (tested on a vanilla OCP WI cluster)

I provisioned a WI cluster using the instructions at [1], but before running ccoctl azure create-all, I copied the ARO operator's CredentialsRequest manifest into the --credentials-request-dir so that ccoctl would create a WI and a Secret manifest for the ARO operator. I also removed this Secret manifest from the install manifest directory before installing the cluster and saved the manifest so I could apply it myself later.
After the cluster finished installing, I added the ARO Cluster CRD to the cluster and created a minimal Cluster CR with just the attributes needed to make the subnets controller work. I included these attributes:

azEnvironment
clusterResourceGroupId
location
operatorFlags (disabled everything except the subnets controller and service endpoint reconciliation)
resourceId (just put any resource ID that has the right subscription; the subnet controller only reads this to get the subscription ID)
serviceSubnets:
storageSuffix
vnetId

I then set up the ARO operator (master only, since only the master Pod makes Azure API calls) on the cluster using the manifests in pkg/operator/deploy and the Secret manifest that I had saved during step 1. I did make a few changes to the Deployment manifest: 1) replaced AZURE_CLIENT_SECRET with AZURE_FEDERATED_TOKEN_FILE and 2) mounted a bound service account token (see [2] for the things to add).

[1] https://github.com/openshift/cloud-credential-operator/blob/master/docs/azure_workload_identity.md
[2] Two things to add in the ARO operator Deployment spec to mount the bound service account token:

Add this to the Pod spec:

volumes:
- name: bound-sa-token
  projected:
  defaultMode: 420
  sources:
  - serviceAccountToken:
      audience: openshift
      expirationSeconds: 3600
      path: token

Add this to the container spec:

volumeMounts:
- mountPath: /var/run/secrets/openshift/serviceaccount
  name: bound-sa-token
  readOnly: true

Is there any documentation that needs to be updated for this PR?
No

/azp run ci


How would you implement GetMany with gate?

In his GopherCon 2018 talk, Bryan C. Mills illustrates the shortcomings (spurious wakeups, specifically) of sync.Cond through a GetMany(n int) []Item method on his queue type.
If you were to add the following method to your queue (still based on your gate abstraction),
func (q *Queue[T]) GetMany(ctx context.Context, n int) ([]T, error)

how would you implement it? This still isn't clear to me.

GetMany requires something more complicated, because you need more than one bit of state. I wouldn't use a gate for a queue which needs to support a GetMany that blocks until the full request size can be satisfied. (I don't think I've ever encountered a case where that's a useful operation, however, as opposed to "get up to N elements, return less if that's all that's available".)
That said, you could do something like this:

the queue includes an internal queue of waiters
the queue's gate condition is set if the queue contains enough elements to satisfy the head of the waiter queue
GetMany is:

lock the gate
if the waiter queue is empty and the request can be satisfied:

take the items
unlock the gate
return

add the current request to the waiter queue
unlock the gate
wait on the gate

if successful: take the items
if unsuccessful: lock the gate

remove the request from the waiter queue
return

Thanks for the thorough explanation! I have no remaining questions.


Fix: redirectTo should be unchanged after state change

Fixes so that redirectTo remains unchanged even after state changed.
How to verify

Checkout this branch and build it $ npm run build-cjs.
Checkout branch reproduce-redirect-to-race-condition of the React example application.
Start the example application ($ npm start) and open http://localhost:3000/ in your browser.
Login with an existing user.
Click logout and verify that you are redirected to http://localhost:3000/goodbye/$USERNAME. Where $USERNAME is the username of your logged in user.

Fixes #102

reproduce-redirect-to-race-condition doesn't seem to be pushed in the sample app?  If I understand the reported problem, the redirectTo value is not being used?  I tried placing this inside and outside of the <HomeRoute>:
<LogoutRoute path='/logout' redirectTo='/login' />

But didn't see any post-logout redirects happen in master or this branch.  Am I understanding the situation correctly?

@robertjd Sorry! As you said. I forgot to push it. But it's pushed now (see https://github.com/stormpath/stormpath-express-react-example/tree/reproduce-redirect-to-race-condition)! And no, the issue is not with the LogoutRoute. It was with the redirectTo state of the LogoutLink-component. But take a look at the branch I pushed and hopefully that should make sense:)

Hey @typerandom , I'm still confused by this one.  If I understand the bug report correctly, then when I try to logout with the reproduce-redirect-to-race-condition branch, I should be redirected to /goodbye/undefind, is that the expected error case?  If so that's not what I'm seeing.  Instead I do get redirected to /goobye/<email>.  This is true with the current version that the sample depends on, and with this branch as a link.

Yeah, I just noticed why! I forgot to remove the <Authenticated> wrapping of the <LoginLink>-tag. That forced it to only be rendered with authenticated state, hence "hiding" the issue. But the test branch has been updated. If you use it with the master React SDK branch, then it should redirect you to /goodbye/, but if you use this branch (fix-redirect-to-race-condition) it should redirect you to /goodbye/<email>.

Ah, I see now.  This does fix the problem, merging.


Example showing how to use secret variables is confusing

[Enter feedback here]
I'm trying to figure out how to correctly define secret variables (from Library groups) and use them in a pipeline. The eamples shown here are too confusung because they include code that does work with code that does not work, all mixed together in the same example. Please consider re-writing and making it clear.
Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Define variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@plastikfan Thanks for your feedback. Could you point to which secret variable examples you are having trouble getting working?

The following quoted from your page:
variables:
 GLOBAL_MYSECRET: $(mySecret) # this will not work because the variable needs to be mapped as env
 GLOBAL_MY_MAPPED_ENV_VAR: foo # this will not work because the variable needs to be mapped as env

steps:

- powershell: |
    # Using an input-macro:
    Write-Host "This works: $(mySecret)"

    # Using the env var directly:
    Write-Host "This does not work: $env:MYSECRET"

    # Using the env var through the variables mapping will not work:
    Write-Host "This does not work either: $env:GLOBAL_MYSECRET"

    # Using the global var mapped in the pipeline. It is not a secret var:
    Write-Host "This works: $env:GLOBAL_MY_MAPPED_ENV_VAR"

    # Using the mapped env var:
    Write-Host "This works: $env:MY_MAPPED_ENV_VAR"    # Recommended

  env:
    MY_MAPPED_ENV_VAR: $(mySecret) # right way to map to an env variable

is too confusing.
Please split this out into a full example with all code the works and an another example with error scenarios. This is just a mess as it stands

Thanks for the feedback. We're planning a more detailed new secret variables article and will include more broken out examples.


fix: Find jsonrpc by header file

It seems like (package-get-descriptor 'jsonrpc) will return the the latest version on ELPA. Use locate-library instead.

This method is more robust, though I submitted an alternative PR that avoids avoidable TOCTOU and adds necessary require 'package.

See my comment https://github.com/copilot-emacs/copilot.el/issues/262#issuecomment-1947302208.

As noted in https://github.com/copilot-emacs/copilot.el/issues/262#issuecomment-1947306345, (require 'package) is still required due to the use of package-get-version. I also suggest when-let and with-current-buffer is cleaner.

Out of curiosity what was the issue with using package-get-version?

I've updated the code. This is much more robust now. :)

Out of curiosity what was the issue with using package-get-version?

Okay, I've done some tests and I think is the bug from Emacs itself. 🤔 At least, package-get-version isn't as robust as package-buffer-info.

I would suggest squashing the commits, as it is very hard to follow with the formatting changes going on and then reverting,
I would avoid using s-replace, that is just waiting to blow up when somebody has their emacs dir in a patch containing .elc. Use these: https://www.gnu.org/software/emacs/manual/html_node/elisp/File-Name-Components.html

FYI, I don't have the push permission so I don't have the control over this.

I would avoid using s-replace, that is just waiting to blow up when somebody has their emacs dir in a patch containing .elc. Use these: https://www.gnu.org/software/emacs/manual/html_node/elisp/File-Name-Components.html
eg (file-name-with-extension (file-name-sans-extension elc) "el")

Updated! 👍

FYI, I don't have the push permission so I don't have the control over this.

Are you speaking about squashing the commits? You can always squash commits on your local repo and force push to your own repo, the PR will update.

There are corners cases where this can still happen, (like not having the .el file or it's compressed to .el.gz).

Yeah, that's why I go for package descriptor as my first attempt. But what makes you think this is a hack? 🤔 And out of curiosity, when will .el.gz happen? At some point, we have to assume users have installed their packages correctly.

However, at the least, if the version check returns nil, probably should assume the dependency is installed.

Thanks for the suggestion. I am keen to keep this PR like this for now because I have another PR in #247, and it will overwrite some of the logic here. Therefore, I will improve this after #247 gets merged.

Yeah, that's why I go for package descriptor as my first attempt. But what makes you think this is a hack? 🤔

Doing a version check using mechanisms outside of a package manager is unfortunately a hack. This is partly due to how packaging in emacs works. It is unfortunately the situation. How this is supposed to work is that copilot.el would be a proper package and dependencies would be handled for it. Failing that, probing for the specific feature in question would be more ideal, though I am aware that takes more effort. I have nearly 400 packages in my setup and I have not seen one resort to package-buffer-info outside of tools like el-get, etc.

And out of curiosity, when will .el.gz happen?

So it is perfectly fine to have your el files compressed, and emacs seemlessly.  https://www.gnu.org/software/emacs/manual/html_node/emacs/Compressed-Files.html
You also don't need to have the el files present.

At some point, we have to assume users have installed their packages correctly.

Exactly, but having compressed sources are compatible with correctly installed packages. So I am saying for features like these in general that are mostly intended as an imperfect fallback, if the check fails, it should soft fail optimistically. So someone that has their sources compressed or some non-typical thing, yeah they are on their own as far as versions, but at least it doesn't just break.

Doing a version check using mechanisms outside of a package manager is unfortunately a hack. This is partly due to how packaging in emacs works. It is unfortunately the situation. How this is supposed to work is that copilot.el would be a proper package and dependencies would be handled for it. Failing that, probing for the specific feature in question (ie trap if the instance creation fails) would be more ideal, though I am aware that takes more effort. I have nearly 400 packages in my setup and I have not seen one resort to package-buffer-info or similar outside of tools like el-get, etc.

Yes, you are right. Any improvements are welcome since I don't have a better solution.

So it is perfectly fine to have your el files compressed, and emacs works seamlessly. https://www.gnu.org/software/emacs/manual/html_node/emacs/Compressed-Files.html
You also don't need to have the el files present.

👍

Exactly, but having compressed sources are compatible with correctly installed packages. So I am saying for features like these in general that are mostly intended as an imperfect fallback, if the check fails, it should soft fail optimistically. So someone that has their sources compressed or some non-typical thing, yeah they are on their own as far as versions, but at least it doesn't just break.

Thanks for the information. It's very helpful. I'll make improvements after other PRs have merged, and feel free to open PRs for this.

Ok, after getting some time to examine the actual problem leading to this I think this can be handled with a trap on invalid-slot-name. PR #264.

I think you have the better solution. Close this one now! :)


Add tests and fix a few whitespace issues

Add full tests for BOOL and ReleaseDC
Fix indentation of constructors and operators
Add newline after attribute list

@AArnott this change doesn't fix all whitespace issues, but it dramatically improves readability relative to the 0.1.506-beta release. 😄