 Per your npmpublish workflow (https://github.com/VenkSociety/Tsuyo/blob/master/.github/workflows/npmpublish.yml#L14), it's still using 12. Therefore, per current compatibility we should at least stick with 12. Unnecessarily limiting the node version may backfire for usability sake. Do you absolutely need something in v14+, necessary enough to warrant an error thrown?

Agreed, this should be a needed change. +14123

👋 @wzhouwzhou  the Dockerfile in the master branch is a tinny bit outdated I would say, and NodeJS version 12 sounds like a perfect middle ground for this application

@felixfong227 agreed! Can we get some input and a merge from @VenkSociety ?


Add asn field to server

This PR is not related to any issue. It adds the ASN field to the server struct, so that users can use asn as a query param to GET servers.

Which Traffic Control components are affected by this PR?

Documentation
Traffic Ops
Traffic Portal

What is the best way to verify this PR?

Run TO and TP locally.
Hit the 4.1 GET /servers route and make sure that the asns field shows up in the response.
Hit the same endpoint and add asn=<> as a query param.
Make sure you see the correct servers in the response.
Make sure the other routes DO NOT return this new field.
Make sure all other CRUD routes for servers work fine.
Test TP to verify that you can show/ hide the new field in servers.
If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

[x] This PR has tests
[x] This PR has documentation
[x] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

The ServerV4 type alias in lib/go-tc/servers.go still says that the latest version of a server is ServerV40. This means that other API endpoints that show servers - e.g. /deliveryservices/{{ID}}/servers/eligible etc. - all now have different representations of a server than /servers. This is, in my opinion, bad. An API object should have exactly one representation.

I've updated the ServerV4 to point to ServerV41 now. However, if you hit the other endpoints, for example, /deliveryservices/{{ID}}/servers/eligible, you'd still get a server representation without the ASN field. That field is only added for the GET routes of /servers. Because there is not 4.1 equivalent route for the other endpoints (for example, /deliveryservices/{{ID}}/servers/eligible), they still return the version 4.0 representation of the server object.

IDK why the go fmt GHA keeps failing. It's checking a piece of code that's not even a part of this PR.

IDK why the go fmt GHA keeps failing. It's checking a piece of code that's not even a part of this PR.

That's because #6960 was erroneously merged with a go fmt failure.

A fix is now open #7038

The ServerV4 type alias in lib/go-tc/servers.go still says that the latest version of a server is ServerV40. This means that other API endpoints that show servers - e.g. /deliveryservices/{{ID}}/servers/eligible etc. - all now have different representations of a server than /servers. This is, in my opinion, bad. An API object should have exactly one representation.

This will be addressed in a follow up PR.


Google like Search Box with Select2

Hi Guys,
Am trying to create live search box like google in my website home page.
After typing i click submit button, then typed value get disappear and it shows required error message.
`

--
  |
  |
  |
`
$(element).select2({
| minimumResultsForSearch: Infinity,
  | maximumSelectionLength: 1,
  | minimumInputLength: 1,
  | tags: true,
  | language: {
  | },
  | ajax: {
  | url: 'URL',
  | dataType: 'json',
  | delay: 250,
  | processResults: function (data) {
  | return {
  | results: data
  | };
  | },
  | cache: true
  | }
  | });

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


Changed uppercase Helpers namespace to lowercase helpers per #2.

Oops, sent to master: will attempt to resend to branch.

Development branch is old compared to master. I am confused how I should contribute. Should I create a new branch specific to my issue ID (#2)?

Hi. The development branch is now even with master. Changes should be pushed to development.
Thanks for contributing.


Issues during upgrade 4.5 to 4.6

Hello,
I tried to update 4.5.0-0.okd-2020-10-15-235428 to 4.6.0-0.okd-2020-11-27-200126.
I had multiple issues due to being behind a proxy.
First I allowed storage.googleapis.com to validate the 4.6 image. Error was: Unable to apply 4.6.0-0.okd-2020-11-27-200126: the image may not be safe to use.
Then I had an issue due to rpm-ostree getting timeout. It was not using the proxy.
I followed https://github.com/coreos/rpm-ostree/issues/762#issuecomment-434256478 to solve it.
Is it possible to manage it via ignition files?
Can we specify a mirror to use instead of trying them all twice (80/443)?
Last issue was gcp rewriting the hostname.
Fix: sudo hostnamectl set-hostname okdmaster1a.example.com

Confirmed 4.5 to 4.6 is a problem with rpm-ostree so workaround required but I guess once your cluster is at 4.6 the fedora repos should be disabled and therefore this wont be a problem going forward

rpm-ostree getting timeout

Which timeout is it? We're disabling all available repos before proceeding to update, as all necessary RPMs are already included in machine-os-content. Please collect a must-gather

My 4.5.0-0.okd-2020-10-15-235428 to 4.6.0-0.okd-2020-11-27-200126 failed with the same issue, I added the dropin to set the proxy environment variables which allowed my upgrade to proceed.
Just poked at one of my masters post upgrade, these repos are still enabled:
sh-5.0# grep enabled=1 /etc/yum.repos.d/*
/etc/yum.repos.d/fedora-cisco-openh264.repo:enabled=1
/etc/yum.repos.d/fedora-updates-archive.repo:enabled=1
/etc/yum.repos.d/fedora-updates.repo:enabled=1
/etc/yum.repos.d/fedora.repo:enabled=1

As per our discussion in https://github.com/openshift/okd/issues/389 this didnt seem to be an issue on a fresh 4.6 UPI install.

Is the 4.5 to 4.6 upgrade really supported ?

Just poked at one of my masters post upgrade, these repos are still enabled:

Right, that seems to be a bug - OKD doesn't need enabled repos when updating, as it ships all RPMs with it. This is resolved during fresh install (we disable all Fedora repos by default), but still open on update - and proxy env is not set there. @thurcombe mind filing a separate bug for that?

First I allowed storage.googleapis.com to validate the 4.6 image. Error was: Unable to apply 4.6.0-0.okd-2020-11-27-200126: the image may not be safe to use.

That's expected - CVO checks image signatures stored on GCS. Seems to be a docs bug

Last issue was gcp rewriting the hostname.
Fix: sudo hostnamectl set-hostname okdmaster1a.example.com

Is the cluster installed on GCP or this service being run mistakenly (#396)?

Is the cluster installed on GCP or this service being run mistakenly (#396)?

Just for info, after our previous discussion re a fresh 4.6 install I noted that gcp hostname was listed as a failed unit in my UPI. I figured it was a non-issue but mentioning it here in case it helps. I'll raise a new defect for the repo problem.

Another issue is MountVolume.SetUp failed for volume "var-lib-tuned-profiles-data" : stat /var/lib/kubelet/pods/687ac4e3-cb54-41d2-a31c-6c7d36d4be74/volumes/kubernetes.io~configmap/var-lib-tuned-profiles-data: no such file or directory
Apparently tuner pods cannot mount their volume configmap after an upgrade.
The configmap is the default one, empty.
Solution is to delete all pods. Then they will be running.

I got the same issues:
NAME                                       VERSION                         AVAILABLE   PROGRESSING   DEGRADED   SINCE
authentication                             4.6.0-0.okd-2020-11-27-200126   False       True          True       3h44m
cloud-credential                           4.6.0-0.okd-2020-11-27-200126   True        False         False      5h37m
cluster-autoscaler                         4.6.0-0.okd-2020-11-27-200126   True        False         False      5h17m
config-operator                            4.6.0-0.okd-2020-11-27-200126   True        False         False      5h17m
console                                    4.6.0-0.okd-2020-11-27-200126   False       False         True       3h41m
csi-snapshot-controller                    4.6.0-0.okd-2020-11-27-200126   True        False         False      92m
dns                                        4.6.0-0.okd-2020-11-27-200126   True        False         False      92m
etcd                                       4.6.0-0.okd-2020-11-27-200126   True        False         False      5h26m
image-registry                             4.6.0-0.okd-2020-11-27-200126   True        False         False      5h19m
ingress                                    4.6.0-0.okd-2020-11-27-200126   True        False         False      60m
insights                                   4.6.0-0.okd-2020-11-27-200126   True        False         False      5h19m
kube-apiserver                             4.6.0-0.okd-2020-11-27-200126   True        False         False      5h25m
kube-controller-manager                    4.6.0-0.okd-2020-11-27-200126   True        False         False      5h24m
kube-scheduler                             4.6.0-0.okd-2020-11-27-200126   True        False         False      5h24m
kube-storage-version-migrator              4.6.0-0.okd-2020-11-27-200126   True        False         False      61m
machine-api                                4.6.0-0.okd-2020-11-27-200126   True        False         False      5h18m
machine-approver                           4.6.0-0.okd-2020-11-27-200126   True        False         False      5h24m
machine-config                             4.6.0-0.okd-2020-11-27-200126   True        False         False      3h12m
marketplace                                4.6.0-0.okd-2020-11-27-200126   True        False         False      91m
monitoring                                 4.6.0-0.okd-2020-11-27-200126   False       False         True       3h40m
network                                    4.6.0-0.okd-2020-11-27-200126   True        False         False      5h28m
node-tuning                                4.6.0-0.okd-2020-11-27-200126   True        False         False      4h25m
openshift-apiserver                        4.6.0-0.okd-2020-11-27-200126   False       False         False      91m
openshift-controller-manager               4.6.0-0.okd-2020-11-27-200126   True        False         False      4h23m
openshift-samples                          4.6.0-0.okd-2020-11-27-200126   True        False         False      4h25m
operator-lifecycle-manager                 4.6.0-0.okd-2020-11-27-200126   True        False         False      5h25m
operator-lifecycle-manager-catalog         4.6.0-0.okd-2020-11-27-200126   True        False         False      5h25m
operator-lifecycle-manager-packageserver   4.6.0-0.okd-2020-11-27-200126   False       True          False      129m
service-ca                                 4.6.0-0.okd-2020-11-27-200126   True        False         False      5h27m
storage                                    4.6.0-0.okd-2020-11-27-200126   True        False         False      4h26m

I got the same issues:
NAME                                       VERSION                         AVAILABLE   PROGRESSING   DEGRADED   SINCE
authentication                             4.6.0-0.okd-2020-11-27-200126   False       True          True       3h44m
cloud-credential                           4.6.0-0.okd-2020-11-27-200126   True        False         False      5h37m
cluster-autoscaler                         4.6.0-0.okd-2020-11-27-200126   True        False         False      5h17m
config-operator                            4.6.0-0.okd-2020-11-27-200126   True        False         False      5h17m
console                                    4.6.0-0.okd-2020-11-27-200126   False       False         True       3h41m
csi-snapshot-controller                    4.6.0-0.okd-2020-11-27-200126   True        False         False      92m
dns                                        4.6.0-0.okd-2020-11-27-200126   True        False         False      92m
etcd                                       4.6.0-0.okd-2020-11-27-200126   True        False         False      5h26m
image-registry                             4.6.0-0.okd-2020-11-27-200126   True        False         False      5h19m
ingress                                    4.6.0-0.okd-2020-11-27-200126   True        False         False      60m
insights                                   4.6.0-0.okd-2020-11-27-200126   True        False         False      5h19m
kube-apiserver                             4.6.0-0.okd-2020-11-27-200126   True        False         False      5h25m
kube-controller-manager                    4.6.0-0.okd-2020-11-27-200126   True        False         False      5h24m
kube-scheduler                             4.6.0-0.okd-2020-11-27-200126   True        False         False      5h24m
kube-storage-version-migrator              4.6.0-0.okd-2020-11-27-200126   True        False         False      61m
machine-api                                4.6.0-0.okd-2020-11-27-200126   True        False         False      5h18m
machine-approver                           4.6.0-0.okd-2020-11-27-200126   True        False         False      5h24m
machine-config                             4.6.0-0.okd-2020-11-27-200126   True        False         False      3h12m
marketplace                                4.6.0-0.okd-2020-11-27-200126   True        False         False      91m
monitoring                                 4.6.0-0.okd-2020-11-27-200126   False       False         True       3h40m
network                                    4.6.0-0.okd-2020-11-27-200126   True        False         False      5h28m
node-tuning                                4.6.0-0.okd-2020-11-27-200126   True        False         False      4h25m
openshift-apiserver                        4.6.0-0.okd-2020-11-27-200126   False       False         False      91m
openshift-controller-manager               4.6.0-0.okd-2020-11-27-200126   True        False         False      4h23m
openshift-samples                          4.6.0-0.okd-2020-11-27-200126   True        False         False      4h25m
operator-lifecycle-manager                 4.6.0-0.okd-2020-11-27-200126   True        False         False      5h25m
operator-lifecycle-manager-catalog         4.6.0-0.okd-2020-11-27-200126   True        False         False      5h25m
operator-lifecycle-manager-packageserver   4.6.0-0.okd-2020-11-27-200126   False       True          False      129m
service-ca                                 4.6.0-0.okd-2020-11-27-200126   True        False         False      5h27m
storage                                    4.6.0-0.okd-2020-11-27-200126   True        False         False      4h26m


Update paused due to failure or early termination of task

Hi,
Description
After 10-15 min of inactivity on a server, when I update a service with this command :
docker service update --image pseudo/image:tag --with-registry-auth service_name --detach=false
I have this error every time:
overall progress: 0 out of 4 tasks
1/4: preparing [=================================>                 ]
2/4:
3/4:
4/4:
service update paused: update paused due to failure or early termination of task usuj4mrmk7x7z2a1vpvob569n

And if I restart the command again, it works ...
And if I leave for 15min and I start again, I have to run again the command twice.
I don't know why and it's very frustrating.
Steps to reproduce the issue :
I'm using private image with a nodejs express server. I'm using 1 docker swarm cluster and 1 node on a different machine.

@MLescaudron this is a Docker Swarm Mode issue, please open it on github.com/moby/moby. This repo is for the older Swarm project.


Invalid use of  in 2.0 form docs

In the docs for 2.0-wip, the form examples show HTML like this:
<form class="horizontal-form">
        <legend>Example form section</legend>
        <fieldset class="control-group">
          Text input

            <input type="text" class="xlarge" name="input01">

        </fieldset>

</form>

However, this is invalid HTML as the  tag cannot appear as a child of  - in HTML4 it should be within a  while in HTML5 it also applies to  and .
It is valid to nest  elements, so it would be possible to add a simple  as the first child of  in the example above to make the markup valid. This also has the advantage of restoring the semantic meaning of fieldset as a way of grouping multiple inputs together.
However, with the current styles doing so causes the vertical margin between the  and the first control group to collapse in Chrome.

I know this isn't valid, but because of the janky behavior in Chrome I'm fine with leaving it for now.

I am experiencing this same issue now on a different project. Is there a work around, or should I just leave it the way it is?

@Astrotheque please use stackoverflow or similar, particularly if your question isn't about bootstrap itself.


LogglyClient configuration and auto added log fields

In order to configure the underlying LogglyClient when you don't have the possibility to (or just don't want to) use xml configuration, I've opened up the sink to use a configuration object if it is provided.
If no object is provided, the current way of reading up the configuration is used.
Furthermore, I wanted to have the control over if I wanted to have the fields "Level", "Message", and "Exception" automatically added to log messages if not already present in the list of Serilog properties.
So again opening up for passing in an object to do that. The change still defaults to how it is now, if no object is provided.

I suppose that is up to you. If you want to have it, I'll pump up the versions.
I've tried to use default parameters, so other users shouldn't be affected if they update, as long as they use the extension method.
I see your concern if somebody is using the constructor directly, e.g. wrapping it in another sink. I'll write a chain with "this". Do you still want the updated versions?

I'd recommend just one change - in the .csproj, update and use the  element and remove the  and  element. The build will define the package version based on the branch (if version prefix is 5.2.0, then the package will be 5.2.0-alphaX in the dev branch, and 5.2.0 once merged into master).

Hadn't seen that one. Updated

I've removed the FileVersion and Version elements from the csproj to prevent locking the version number and accelerate the approval process.


[Testing] Add Flaky label.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
c169bce07e2456549d130396ed5318ac1d8111ca
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-test

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
c169bce07e2456549d130396ed5318ac1d8111ca
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
c169bce07e2456549d130396ed5318ac1d8111ca
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
c169bce07e2456549d130396ed5318ac1d8111ca
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3


Updated TTLs ignored by secret lease renewal logic

vault-sidekick fails to handle the following scenario:
vault-sidekick gets a secret with 'renew=true'.  The secret's lease duration is set to the TTL vault currently has configured for that secret.  At this point everything operates correctly (vault-sidekick will continually renew that secret's lease ahead of its expiration).
However, if vaults TTL is then shortened, the next time the lease is renewed its duration will reflect the shorter TTL.  vault-sidekick will not notice and the secret will expire before the subsequent renewal is attempted.
I believe this is due to the renewal code which updates rn.leaseExpireTime, but not rn.secret.LeaseDuration and that's what's used by the renewal time calculation.
Additionally, the renwal printing code prints rn.secret.LeaseID twice when I believe the second time LeaseDuration is intended.

I've just been caught out by this. I updated to try and benefit from https://github.com/UKHomeOffice/vault-sidekick/issues/91 but have had to roll it back.


Add support for textDocument/inlineValues

Based on the fact that VS Code added it to vscode.languages and not DAP, my understanding is that this is intended to be provided by a language server (which already has access to parsed ASTs).
This is intended to mirror the equivalent VS Code feature:
https://github.com/microsoft/vscode/blob/c980ea2307905fd1efeee38915bf1e5ccdff1754/src/vs/vscode.d.ts#L2677-L2852
The only deliberate difference is removal of the DAP frame ID since it doesn't seem useful to provide to a language server (although if I've misunderstood that, it's easy to add back in).
I did not include a request to go the other way (like codeLens/refresh) because my assumption is that the client would re-request this when the content changes (and values would not change if the file does not), however if that's not true and we should add a server-to-client inlineValues/refresh request, let me know and I'll add.
@dbaeumer

the client would re-request this when the content changes (and values would not change if the file does not)

This might be implied by the above, but changes to one file can affect the inline values in another, so the client needs to do this for all the visible documents.

changes to one file can affect the inline values in another

In that case, I think there should probably be a refresh call (from server->client), the same as CodeLens. If it was intended for the client to request for all visible docs, I'd expect CodeLens would've been the same (and I think it's less clear that this should be done).
I'll add it in - it can always be removed if deemed unncessary.

Yeah, I guess it can work like semantic tokens where the server can ask the client to refresh them.

How is this supposed to fit into the current language server protocol without any concept of application execution lifecycle? Something like "stopped" which is referenced (The document range where execution has stopped.) doesn't exist so far.

How is this supposed to fit into the current language server protocol without any concept of application execution lifecycle? Something like "stopped" which is referenced

My understanding/assumption is that when the editor pauses in the debugger, it would send this request to the language server to get these ranges. With it, it would include the current execution point as an optimisation, since the language server can compute only the ranges up until this point.
note: I'm not proposing anything new here, this is simple adding an existing VS Code API to LSP.

I’m struggling to see what this is for. It seems more targeted at debuggers than language servers. Apologies if I’ve completely missed the point!

I think it is a little confusing because this is a feature for debugging that involves the language server. My understanding is that the goal is to allow the language server (which already has parsed ASTs for a language) to provide regions in a document and their expressions, such that the editors debugger could evaluate those expressions and show inline values as the debugger steps through them.
The original VS Code description is here:
https://github.com/microsoft/vscode/issues/105690
https://code.visualstudio.com/updates/v1_56#_inline-values-by-default-for-some-languages

"With a new debugger extension API, it is now possible for language extensions to provide correct inline value support and we are enabling the Improved inline values feature by default."

So let's say you had the code:
print(foo);

This request allows the language server to return a range around foo that is one of the types described above (text, expression, variable). If it was text then the literal text in the InlineValue would be displayed. If an expression, the editor would evaluate it (via the debug adapter), and if a variable, the editor would look it up from the variables list provided by the debugger.

ok thanks I think I get it. I would suggest including your explanation and example in the protocol docs. I think saying what an API is for is just as important as the actual messages and types.
Regarding the ‘variable’ and ‘expression’ types, IIRC DAP requires a frame ID to make a variables request or evaluate an expression. How is the LSP client (or DAP client) expected to divine this? I guess that’s not LSP scope and DAP client just has to guess (eg use ‘current’).
I’m a little confused about the refresh operation now. If you’re debugging, then either there is some custom ‘edit and continue’ cycle or changes to the code wouldn’t be effective in the debuggee ? What’s the expected real world case for this?

Here are the 2 main stories for inline values: parameter names and debug value. For the 1st one, the range would be the whole parameter and the inline value would be displayed before, for the later one, the range would be an expression, and the value would be displayed after.
I think the specification needs to explicit this before/after decision.
I also am worried about the idea of creating subtypes for values or expressions. What do they do that couldn't be covered with plain text? I'd rather see a generic enough type that can cover the main use-cases and leave door open to build new use-cases with it than a restricted spec focused on very specific use-cases.
IMO, the refresh notification should be titled needsRefresh or invalidate maybe, to highlight the fact that it's actually not doing any refresh.

Fwiw DAP already has the invalidate notification for a couple of things like locals etc

Here are the 2 main stories for inline values: parameter names and debug value

I think Inlay Hints is intended for the first (https://github.com/microsoft/language-server-protocol/issues/956) and this is entirely for debugging. I do think there's a lot of overlap - especially with each one being made fairly generic, but that seems to the the route VS Code has taken (it's already shipped Inline Values and has Inlay Hints as a proposed API) so it makes sense to follow (they have more information on the intended uses than I).

I also am worried about the idea of creating subtypes for values or expressions. What do they do that couldn't be covered with plain text?

Plain text is literals. The others are dynamic values that will be fetched via the debug adapter. Again, this isn't something I've come up with - this is simple a mapping from the VS Code API. Given any LSP implementation would need to map onto available APIs in an editor I don't think it's feasible to really change how this works.

IMO, the refresh notification should be titled needsRefresh or invalidate maybe, to highlight the fact that it's actually not doing any refresh.

I copied the existing CodeLens Refresh request for consistency. It's easily changed, but I don't know if it makes sense to be different to that?

@weinand can you comment on whether inline values will be part of the DAP and why it ended up in the vscode.languages namespace?

Slow response was cause by OOV.

The "inline values" support is new VS Code extension API and not part of the debug adapter protocol (DAP). See https://code.visualstudio.com/updates/v1_54#_inline-value-provider-api
The reason for this not being part of DAP, is the observation that DAP already has already mechanisms for getting the value of variables (e.g. the "evaluate" and "variables" requests). The real problem is on the language side: only the "language" knows, what are the interesting variables and where they are located in the source. A debug adapter neither knows what to show and where the variables are located. It only knows the values.
Having extension API like the InlineValuesProvider makes it possible to access both the language smartness (e.g. LSP) and the debugger (DAP) in one place.

Thanks Andre and thanks for the API pointer. Now that I understand how that works it makes sense to have this in LSP since VS Code will do the handshake with the DAP. I was worried that a LS needs to need to talk to a debugger.

@dbaeumer exactly, by using this approach we want to avoid that LSP or DAP has to know each other.

@DanTup would you be willing to add this to vscode-languageserver-node repository in the way we did before, including the MD you provided here. Although this is already final in VS Code we should add this as proposed to LSP to allow other to give feedback as well.

@dbaeumer yep! Do you have any comments on the other comments/review comments above before I do (for example using a refresh request, etc)?
I'm OOO next week so might not get to this before I return, but I am happy to implement it to see it supported :-) Thanks!

I am not sure if we need a refresh. I am not able to come up with a case where this is necessary since this API is only called while debugging an application.
I think most comments come from the confusion about how this API is supposed to work. It is not meant to provide any real values. They will come from the debugger. It is only used to given the debugger either a name or an expression to evaluate inside the debugged application using DAP protocol.

Yes, from the LSP side a refresh would only makes sense if some of the previously provided names or source ranges or expressions are no longer valid because the user has modified the source or some translation process has changed. But this is a typical hot-code-replacement case where the debugger has to refresh the fetched variables etc. anyway. So I don't think that a "refresh" is needed/useful.

BTW, Java and PowerShell are relying on LSP to implement inline values, because there "language smartness" and "debugger" are basically one thing and thye do not need a neutral protocol for getting data across.
For TS/LS the TS team and @connor4312 are working on a tsserver plugin for providing the inline values information (see https://github.com/microsoft/TypeScript/issues/43449)

Yes, from the LSP side a refresh would only make sense if some of the previously provided names or source ranges or expressions are no longer valid because the user has modified the source or some translation process has changed. But this is a typical hot-code-replacement case where VS Code has to refetch the set of variables and their values anyway.

Is it possible you could be modifying a different file to the one that you're debugging that would change an evaluated expression shown where you are debugging? Or will modifying/saving cause all to be re-evaluated? (If so and all clients are expected to do that, should it be noted in the spec?).
Out of interest, how many ranges is it expected a language might return? For example in the code:
var a = b ? c.d : e.f;

Would it be expected that there is just a, or a, b, c.d and e.f? I can see arguments for both ways (the latter could be very busy if the UI is bad, but it would also be really nice when debugging to see all of those values without having to hover over things).

This was added to the spec in e31b4a251739e39b9c6728717e3fa2c7f3d743b0

Great! Seems like this PR is not required then. Thanks!


Content Exporter : Call to a member function getFileName() on a non-object

https://github.com/concrete5/addon_sample_content_generator/issues/2

I think the solution to #2015 at least partially addresses this issue.

Yes, this happens when you have a block on your site that uses files and that file is either no longer present in the file manager or the block itself has no file bound to that particular parameter.


Subscriptions with multiple groups

** Which Category is your question related to? **
API, GraphQL and @auth directive
** What AWS Services are you utilizing? **
API, Storage, Auth, Hosting
** Provide additional details e.g. code snippets **
I am not sure if this is a bug or If I am doing something wrong, I am probably doing something wrong, so I decided to open this as a question.
This is my current GraphQL Schema:
type Chat
  @model
  @auth(
    rules: [
      { allow: groups, groups: ["admins"] }
      { allow: groups, groups: ["users"], operations: [read] }
    ]
  ) {
  id: ID!
  name: String!
  messages: [Message]
    @connection(name: "ChatMessages", sortField: "createdAt", limit: 100)
  createdAt: AWSDateTime!
}

type Message
  @model
  @auth(
    rules: [
      { allow: owner }
      { allow: groups, groups: ["users"], operations: [read] }
    ]
  ) {
  id: ID!
  text: String
  image: String
  owner: String
  chat: Chat @connection(name: "ChatMessages")
  createdAt: AWSDateTime!
  updatedAt: AWSDateTime!
}

Pretty simple. The issue I am having is that the generated subscription for Messages, onCreateMessage isn't firing for messages that aren't created by the logged in user, even though the user is part of the group users specified in the @auth rules.
I feel like I am doing something wrong, but I can't say. The subscription fires for the current logged user, so it's not something on the client.

Appreciate any kind of help.

Hello @marlonmarcello
Those in the users groups are only allowed to read meaning they are only able to execute get and list operations.
To allow them to subscribe they would need to be tied into the create operation.
...
  @auth(
    rules: [
      { allow: owner }
      { allow: groups, groups: ["users"], operations: [read create] } # to allow oncreate subscriptions
    ]
  ) {
...

If you are looking at only allowing that group to be allowed to subscribe to OnCreateMessage you can add the following change into the schema and change in VTL Template.
type Subscription {
	onCreateMessage(owner: String): Message @aws_subscribe(mutations: ["createMessage"]) @aws_cognito_user_pools
}

Taking the resolver Subscription.onCreateMessge.res.vtl from the build folder and adding it into the resolver folder outside will override it. The addition here is a cognito user group check.
## [Start] Determine request authentication mode **
#if( $util.isNullOrEmpty($authMode) && !$util.isNull($ctx.identity) && !$util.isNull($ctx.identity.sub) && !$util.isNull($ctx.identity.issuer) && !$util.isNull($ctx.identity.username) && !$util.isNull($ctx.identity.claims) && !$util.isNull($ctx.identity.sourceIp) )
  #set( $authMode = "userPools" )
#end
## [End] Determine request authentication mode **
## [Start] Check authMode and execute owner/group checks **
#if( $authMode == "userPools" )
  ## [Start] Static Group Authorization Checks **
  #set($isStaticGroupAuthorized = $util.defaultIfNull(
            $isStaticGroupAuthorized, false))
  ## Authorization rule: { allow: groups, groups: ["users"], groupClaim: "cognito:groups" } **
  #set( $userGroups = $util.defaultIfNull($ctx.identity.claims.get("cognito:groups"), []) )
  #set( $allowedGroups = ["users"] )
  #foreach( $userGroup in $userGroups )
    #if( $allowedGroups.contains($userGroup) )
      #set( $isStaticGroupAuthorized = true )
      #break
    #end
  #end
  ## [End] Static Group Authorization Checks **

## [Start] Owner Authorization Checks **
## the rest of the vtl template ....

This should allow you to let those in the users group see the subscription and not be able to do a mutation.
As a takeaway what we can implement is a listen enum in the operations list. For example what might be best fit here is something like this
 @auth(
    rules: [
      { allow: owner }
       # allows those in user group to do query operations and subscription operations
      { allow: groups, groups: ["users"], operations: [read listen] }
    ]
  )

A listen enum would be beautiful.
How complex do you categorize this update @SwaySway ?

Agreed, a listen enum would resolve a lot of issues I am having developing one of my projects.

I also agree with this, would be very helpful for my messaging app


Rename LICENSE.txt to LICENSE

So GitHub shows it automatically in its License UI.

The reason GitHub's UI doesn't parse it correctly is because of the extra line below the copyright, but thanks for bringing this to our attention.

Actually for my LICENSE, which had no extra text over than the standard one, the only thing holding it back - and which fixed it - was such a naming change.
🙏 Thanks
📱 On the App Store https://apps.apple.com/us/developer/daniel-springer/id1402417666
💻 GitHub https://github.com/DaniSpringer
🔗 LinkedIn https://www.linkedin.com/in/imdanielspringer/

On Nov 6, 2019, at 3:22 PM, Marc Cornellà<EMAIL_ADDRESS>wrote:
The reason GitHub's UI doesn't parse it correctly is because of the extra line below the copyright, but thanks for bringing this to our attention.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/robbyrussell/oh-my-zsh/pull/8361?email_source=notifications&email_token=AES22SM32ZHSAUQPVCRHTUDQSMROVA5CNFSM4JJ353E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDH3NOY#issuecomment-550483643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AES22SKKXPK2UP64YH4JP33QSMROVANCNFSM4JJ353EQ.


New version: jsimlo.tednotepad version 6.3.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Added BYN currency

Added BYN (new denominated belorussian currency).
Added formatting for ru_RU locale
Code formatting and cleanup. (i like clean code)

Regarding the code cleanups:
My own opinion (@limist may disagree) is:

Commits and PRs are much easier to deal with if unrelated changes (like code formatting) are not included in the same commit.

We should agree on things like code style before one person just doing it.

I don't like fixing things that will need fixing again. So things like changing the style of quotes seems pointless to me - it is not part of any standard, just a personal preference, and even if all of the strings were changed, other people will use the other style again, so these will need fixing again. If something is part of an enforced style guide e.g. flake8 will catch it, or at least an agreed on standard, then you can be sure it won't need fixing again.

So, IMO, unrelated and unnecessary style changes don't help this PR.

This PR is now superseded by the commits in PR #85 . The other changes in this PR I'm declining for the reasons given above. Thanks!


[DSS-347] Design Updated: List

Description
Updates List documentation to display additional action items based on design audit.
Screenshots

Docs/Rails
Storybook/React

Testing in sage-lib
Rails/Docs

Navigate to List
Verify new example displays and contains more action items

React/Storybook

Navigate to List
Verify new story displays and contains more action items

Testing in kajabi-products

(LOW) Adds additional action items to List documentation. Documentation only update.

Related
DSS-347

Looks good to me, is there a way to get the ... menu into the storybook example?

@goodwinchris Good call. Added.


Investigate iD deploy using latest code

I tested deployment of the new iD, which is almost ready pending a few minor items, and it looks like we have an issue with how we're deploying.
We have a working iD based on upstream develop here: https://github.com/OpenHistoricalMap/id/tree/staging
I changed our target branch from release to staging here:
https://github.com/OpenHistoricalMap/ohm-website/commit/58fcafceb24426e5a125a540b99a694cf6b47db4
That failed because dist doesn't have any build artifacts:
https://github.com/OpenHistoricalMap/ohm-deploy/actions/runs/3268885714/jobs/5375808680#step:7:4694
/var/lib/gems/2.7.0/gems/vendorer-0.2.0/lib/vendorer.rb:111:in `copy_from_path': 'dist/data' not found in https://github.com/openhistoricalmap/iD (RuntimeError)

At first I thought this was simply because I'd forgotten to run and commit outputs of npm run build, but that's not the case, since those outputs are all git-ignored:
https://github.com/OpenHistoricalMap/iD/blob/staging/.gitignore#L12-L20
that's an improvement, since tracking build artifacts has always been annoying, but if we look at upstream release branch, all those artifacts are still in git:
https://github.com/openstreetmap/iD/tree/release/dist
We have deployed iD updates in the past, but it's been a while... Clearly we're not following the OSM instructions at https://github.com/OpenHistoricalMap/iD/blob/staging/RELEASING.md#update-id
Will need to figure out the best path for us going forward.
Needed for #395

@tomay FYI once DevSeed sorts out #475, we're then going to re-encounter this issue, where it's all that clear how we can deploy our latest iD for testing.
Come to think of it, this is something you could help sort out while we await the login fix -- because right now, we need to see whether we can deploy an iD branch other than release into the Rails app locally for testing. There must be a way, but I ran into troubles as noted in this ticket.
When I looked upstream to how mainline iD is released, things got more complex, and really we're not even talking about a release here, but just the ability to test updates to iD inside the Rails application

It looks like the dist/ artifacts in the release branch were added in this commit. I'm not sure what the process for doing that was, but it is possible to add gitignored files to a commit with git add --force

I wonder if in the Vendorfile we could reference a local copy of the iD we are testing, where we have build artifacts, something like
folder 'iD' do
    from '../ohm-id' do

instead of
folder 'iD' do
    from 'https://github.com/openhistoricalmap/iD', :branch => 'release' do

not sure that's the right syntax, but the idea would be to reference the OHM iD repository one directory up on your local system, instead the remote one checked into GitHub

It looks like the dist/ artifacts in the release branch were added in this commit.

This appears to be part of the release process. I was unaware of this step when suggesting that we upgrade to a release tag. Ideally we’d merge in that commit’s parent commit instead.

After upstream changes broke login function on our local dev environment, we have been struggling mightily to get that working again, as documented at https://github.com/OpenHistoricalMap/ohm-deploy/pull/189. Meanwhile, impatient to get this iD update deployed, I went ahead and :

merged the upstream PR into staging at iD https://github.com/OpenHistoricalMap/iD/commit/05ebef1cd0faba63bc1f7b381f59c99b1f9c358e,
pointed ohm-website:staging at the staging branch of iD, https://github.com/OpenHistoricalMap/ohm-website/commit/58fcafceb24426e5a125a540b99a694cf6b47db4
deployed that to staging.openhistoricalmap.org, https://github.com/OpenHistoricalMap/ohm-deploy/actions/runs/3527261447, in a gamble -- if it worked, we could go ahead and get this deployed.

Alas, it did not work.
New iD is live at staging.openhistoricalmap.org, but the API calls for data are malformed with “undefined” in the middle https://staging.openhistoricalmap.org/undefined/api/0.6/map.json?bbox=-1.4941406249999953,52.92215137976296,-1.4886474609374956,52.92546307943839. When I run iD locally on its own, those same calls look like https://www.openhistoricalmap.org/api/0.6/map.json?bbox=-122.332763671875,47.59875528481802,-122.32727050781249,47.6024592954631 so somehow in the Rails app, something is broken and adding undefined/  to the API url…


Only Full Screen?

How can i add Player view? and player control (half screen like youtube app)
how can i play video in half screen?
how can i add full screen video button? onclick full screen?
So finally it only work full screen?

@naguchennai use inline html5 video and native javascript controls (e.g. play(), etc.)
issue can be closed

if there's a clear reason for needing this in this plugin i'll reopen but this is easily resolved by using html5 inline video. this is a fullscreen video plugin.


Integrating a bot to close stale issues and assign reviewers

Purpose of PR?: This PR aims to integrate a bot to close stale issues and automatically assign reviewers to open PRs
Fixes #1848
Does this PR introduce a breaking change? No
If the changes in this PR are manually verified, list down the scenarios covered::
Testing would require triggering of workflows
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

Please review it and provide feedback, whether it's secured or not. I picked these from other repos @daemon1024 @rootxrishabh @DelusionalOptimist


Initial support for MacOS Monterey using homebrew

@avsm This is relying on the obuilder / ocluster support for running a docker like environment. We are currently using this to submit opam-repo-ci jobs to test macos-homebrew (Monterey). My intention is to add this support into ocaml-ci and move the workarounds in opam-repo-ci back into this repository.
There is a point to be made about no official native docker support on MacOS and this not being usable outside of obuilder. I could move it into another module with clear documentation saying only for obuilder.
Do you think this is being used by outside of our CI use case?
https://github.com/ocurrent/ocluster/pull/193
https://github.com/ocurrent/obuilder/pull/122

Thanks @tmcgilchrist.  On reflection, I don't think it's appropriate to put this into ocaml-dockerfile, as there isn't a macOS port.  It's probably a good idea to expose something slightly higher level for the purposes of OCaml-ci -- you will run across the same problem for a future *BSD support there.  Proposals welcome for what that library might look like: it would be nice to be able to express a CI strategy that is portable across obuilder and Docker and other mechanisms in the future as we develop them.

I agree @avsm. Closing this in favour of an obuilder spec based library.


@JuliaRegistrator register()

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/92220
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" ffbaec0fd1b4783d8286a6ac5c37bbaabdf225b7
git push origin v0.1.0


Directly going to the link on clicking icon in contact page.

Is your feature request related to a problem? Please describe.
On the contacts page, multiple icons are there, but the links just below it.
Describe the solution you'd like
I would like to link the hyperlinks directly to the picture, so when they are clicked on the person is directly directed or taken to mail section.

@padmajabhol can I work on this?

Sounds good but do not remove the links below the icons.

@padmajabhol could you please review my pull request, I have done it as told to do.

Sure!


Users can see all Intercom chats

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1103
Originally created by @bencodezen on 2019-10-07 18:16:35

Investigate why this is

[x]  @dmor final step is to re-test

View 14 previous comments from the original issue on GitLab


[US-14-8] Add locators to existing Page Object

Need for tech decomposition
https://jdi-family.atlassian.net/wiki/spaces/JDN/pages/27852825/US-14-8+Add+locators+to+existing+Page+Object
Design: https://www.figma.com/file/BVIiVfeuQfQuD1fi7HP99K/JDN-(v.2)?node-id=0%3A1

https://github.com/jdi-testing/jdn-ai/issues/183#issuecomment-1029689605


trivial issues on browser url bar

this is more of a improvement, not a serious issue but impact on the user experience a lot,
when I use the browser module, each time I want to search something, I'll tap on the url bar,
and just like the screenshots in below, sometimes it will expand a bit, still ok for me to click on the 'close' icon to clear the url,
but sometimes it won't expand, so I have to scroll to the end to find the 'close' icon,

based on experience on other similar browser app, my suggestion is that it will be better if you  can just clear out the url bar automatically, if user want to copy the url, you can put it in the dotdotdot tray

Thanks, I also have noticed this but not sure what's causing it. I'll assign.
This control doesn't always work as expected - sometimes it expands when you click on it, sometimes it doesn't.
Can you change the following:

Consistently expand the search bar when clicked on.
Ensure the 'x' clear button always appears when you click on the search bar.
If the bar is empty, display a 'paste' button on the end similar to how the address input bar works.

by the way, I noticed another related issue:
when I am at https://kyberswap.com/swap,
the browser tab button stop working, I try to get back to the dapp home page, but no response when I tap on the 'browser'


add String#sub

Like String#gsub, but with single replace semantics
There are a couple of usecases unsolved by String#gsub, but
maybe more common, if you know there's only a single match these
should be a tiny bit more performant

Looks great to me, lots of test cases and good implementation - thanks :+1:
Reading through just noticed one place where I was missing a spec :)

Returns self for the empty? string in sub(hash : Hash(Char, _)) now, thanks for the catch.

:+1:

@jhass I thought so many times of implementing this but was very lazy to do it. I think a bunch of problems in Rosetta Code need this, and of course real programs would need this too.
Thank you so much!!! And thanks for the docs, specs, and existing doc fixes.

Same actually, it was itching me for some time but I never found the motivation until now :D


Ignore *~ in Ruby.gitignore

This pattern is ignored by projects under the Ruby organization, such as Ruby itself and Rake.
Reasons for making this change:
This pattern is used by Ruby completion caches. It appears that, when rake is installed with apt, it includes a completions script that will generate a .rake_tasks~. I initially considered ignoring .rake_tasks~ specifically, but checked the .gitignores of Ruby's organization and saw that *~
was used.
Links to documentation supporting these rule changes:
Honestly, I had a lot of trouble finding something relevant. The closest I found is this obsolete project for rake completions, which states including *~ to ignore .rake_tasks~ files.

Disclaimer
I'm still new to Ruby, so this PR should probably get some feedback from the Ruby community first.
I was surprised to find a .rake_tasks~ file in my repo that was not ignored by the .gitignore created
on project init using GitHub's template gitignore. I made this PR because I thought that this observation
was worth discussion.

16 Kas 2021 Sal, saat 00:24 tarihinde Spenser Black <
@.***> şunu yazdı:

This pattern is ignored by projects under the Ruby organization, such as Ruby
itself
https://github.com/ruby/ruby/blob/f31b7f0522e4abfea61f6a74b859205b2b5f8ade/.gitignore#L29
and Rake
https://github.com/ruby/rake/blob/5c60da8644a9e4f655e819252e3b6ca77f42b7af/.gitignore#L4
.
Reasons for making this change:
This pattern is used by Ruby completion caches. It appears that, when rake
is installed with apt, it includes a completions script that will
generate a .rake_tasks~
https://git.launchpad.net/ubuntu/+source/rake/tree/debian/bash_completion.d/rake.
I initially considered ignoring .rake_tasks~ specifically, but checked
the .gitignores of Ruby's organization and saw that *~
was used.
Links to documentation supporting these rule changes:
Honestly, I had a lot of trouble finding something relevant. The closest I
found is this obsolete project for rake completions
https://github.com/ai/rake-completion#cache, which states including *~
to ignore .rake_tasks~ files.
Disclaimer
I'm still new to Ruby, so this PR should probably get some feedback from
the Ruby community first.
I was surprised to find a .rake_tasks~ file in my repo that was not
ignored by the .gitignore created
on project init using GitHub's template gitignore. I made this PR because
I thought that this observation
was worth discussion.
You can view, comment on, or merge this pull request online at:
https://github.com/github/gitignore/pull/3887
Commit Summary

58753e8
https://github.com/github/gitignore/pull/3887/commits/58753e8eadd032fcdd41963596b35ad010ded6a5
Ignore *~

File Changes
(1 file https://github.com/github/gitignore/pull/3887/files)

M Ruby.gitignore
https://github.com/github/gitignore/pull/3887/files#diff-ec1c1b7788c28fd9a1fd3ef32daf7e1936ee364acf5814e70afdb06f4c6bda4c
(1)

Patch Links:

https://github.com/github/gitignore/pull/3887.patch
https://github.com/github/gitignore/pull/3887.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/gitignore/pull/3887, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARNCYDR3VW3MNSLBJQ6SAM3UMF3ANANCNFSM5ICVVPVQ
.

--
Saim macbook pro jet ten gönderildi

What is used in Ruby and Rake does not seem like a great justification for this. Rails or sinatra do not include this change.
Considering reaching out to the Ruby community for clarification.


Expandable Search

Hi godesign.
Would love to see the Expendable Search material design pattern to be included.

Touching the search icon causes the toolbar to transform, clearing other content and displaying a search text field.
Read more: https://www.google.com/design/spec/patterns/search.html#search-in-app-search
Thanks for all your hard work, nativeDroid2 is the best!

The first version of a search-bar is available now:
http://nd2.godesign.ch/examples/extended/search.html
Autocomplete depends on:
http://jqueryui.com/autocomplete/

Awesome @godesign!
How would you go about implementing this without the auto-complete?
(I'm working with an external search API and can't control it's return values.)
In my case I would need the search bar function but when someone enters text, it should not auto-complete. I just want them to submit the search "form" (so I can get the value) and display the results.
Could you provide a non auto-complete example?
Thanks


Object.freeze

this can be done only in DEV env and disabled in production

This is true indeed @slorber. Related to #118.


Autocomplete: add possibility of adding icons to the option labels.

Is your feature request related to a problem? Please describe.
We have some dropdowns where we use icons in the options, like this (here using a MUI Select):

Describe the solution you'd like
It would be great if its possible to add jsx components to optionlabel instead of just string, or at the very least be able to add an svg or something as an icon in addition to text.

Thanks for requesting this!
We usually just gather up issues related to a component before doing them. We have a couple in the pipeline for Autocomplete, so unsure when we can have a look at this. We'll have a look next time we plan the next batch of Autocomplete issues :)


Add more features to the COLMAP similar to automatic reconstruction

Is your feature request related to a problem? Please describe.
Not a problem, but it could improve the quality of the COLMAP functionality.
Describe the solution you'd like
The ability to have the same parameter suggestions as COLMAP GUI Automatic Reconstruction. For example, we are able to determine the quality of the COLMAP reconstruction (low, medium, high and extreme). It is also possible to add a vocab tree for sequential images to support lots of images. As of now, you can only trigger sequential (but no possibility to add optional vocab tree) or vocab tree (but no sequential).
Describe alternatives you've considered
Using COLMAP directly, but then it does not create the Nerfstudio data that is needed such as transforms.json.
Additional context

Using COLMAP directly, but then it does not create the Nerfstudio data that is needed such as transforms.json.

How to do it with COLMAP reconstruction done directly with COLMAP:

You get trasnforms.json by running ns-process-data with --skip-colmap flat and setting path to your exported colmap model with --colmap-model-path parameter. By doing so you will get your data prepared in nerfstudio format including transoforms.json file.
After in ns-train you can use colmap data loader, instead of default nerfstudio-data


AttributeError: 'MoveToFortWorker' object has no attribute 'position'

Expected Behavior
Actual Behavior
AttributeError: 'MoveToFortWorker' object has no attribute 'position'
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

should have been fixed by #563

Downloaded the latest version, double checked everything but still getting that error.

does the MoveToForkWorker object actually have the position property? if not you are most likely still behind the latest commit.

please check with latest DEV branch and paste git commit if issue persists

no respons


Move some tests to ui_test

I haven't ported all tests yet because

[ ] some tests like test_overlap_alias_not_normalizable are basically revision tests, but we have no way to handle --cfg flags passed to the formality binary yet.
[ ] some tests like test_mirror_normalizes_u32_to_u32 don't just check if a program compiles, but whether a where clause holds/what its outputs are

It works great, and with the control we have over command line flags, we probably resolve all of these issues.
The file extension is a bit annoying because you need to copy paste it and can't type it, but 🤷 it's very cute.
Also featuring: ui_test with progress bars (you can't see it because the tests finish so fast).

does .🔬 work on all OSes ? :)

It works on windows Mac and linux. That's not all, but covers the host distros we can test

Not sure about the microscope file extension, seems like it might be annoying after a while. I wonder about .fy, .fty, or even .formality -- or .👔 ??

Gonna merge for now.


Add note about linker errors for Fedora users

This PR adds a note to the Fedora section of Linux Dependencies on solving linker errors.
Fixes #1815.

bors r+


[BuG] Storage location not preserved on error in new purchases

Summary
On a new purchase, if you select a storage location, but have an error,  the storage location resets to the first one in the list.  Fix it so it remains.
Why?
If this is not noticed,  the purchase will go to the wrong storage location, and the inventory will not be what is expected.  This is bad.
Details
Recreation
Purchases | New Purchase
Fill in partial information -- I added the vendor, selected a storage location that was not the first one, left the prices empty, and added one item. Hit save.
You will see that the storage location is back to the first one ('Bulk Storage Location').
Criteria for completion

[ ] Storage location is preserved on error
[ ] tests to demonstrate this behaviour

@cielf I would like to contribute to this one!


Support OnBoarding - Integration details and Problem/Error classification

If a user runs into an issue with azd and they request help from support how does support determine whether the problem is coming from azd or one or more of the tools azd is using.
General advice:

Errors from tools should provide enough information to help the user
Run again (issue may be transient)
Run again with --debug

For azd we could classify errors:

An error in azd
An error in the "gluing" of tools that azd uses
An error thrown by the tool suggesting that its inputs are invalid and user needs to adjust inputs

We want to have a strategy for annotating errors
In failure cases should we have a "full recording" or "diagnostic log" of some sort... or "run again with --trace output.log".

This is required for CSS Onboarding. Related onboarding work item - https://dev.azure.com/SupportabilityCheckList/Developer Tools/_workitems/edit/121074/
cc: @savannahostrowski

@danieljurek @weikanglim can you work together and come up with some guidance/document on the initial triaging, debugging of errors/logs for the support folks?

@danieljurek has created a document for us to capture the different integration touchpoints, its details, dependencies and error scenarios/classifications. Split them as below for you to go and add to it. Please feel free to add more such focus areas and adjust/swap amongst us.

[ ] Packaging and installation @danieljurek
[ ] Authentication and authorization  @weikanglim
[ ] Telemetry  @weikanglim
[ ] Languages, build tools and frameworks  @weikanglim
[ ] Supported Host targets  @wbreza
[ ] Supported IaC 's @wbreza
[ ] Supported Pipelines  @vhvb1989
[ ] Client Integrations  @vhvb1989

Marking this as complete. Since we now have a doc capturing integration and error classification details captured.


Library plans?

Hey, I love this library and am curious if you're planning on continuing on maintaining it? I see a lot of experimental features and it would be nice if they were flushed out. Just curious as to what the status is, thank you!

Hey @nikkwong - thanks for your question. Yes, I plan to continue developing Pts. The current status is that I'm working on a complementary library to Pts (not yet released). Once that's done, I'm going to update Pts with some new learnings from there.
It's going slower than I'd like, but I hope to pick up speed again soon. Follow my twitter account for updates :)

Gradually picking up this library, so closing this issue :)


Unity Plugin: compiler directive to enable builds and synchronising C# scripts with MuJoCo

Description
Two small additions:

The plugin's Editor scripts were not ignored during build, leading to unresolved references preventing standalone builds. The scripts that prevented the build were wrapped with the following directive:

#if UNITY_EDITOR
//Component Editor Script
#endif

Behaviour is not impacted in the editor, but builds are now successful. Fixes #245.

An event was added to MjScene that allows C# scripts, such as custom controllers and agents to subscribe handlers that are invoked between mj_step1 and mj_step2. This can improve the stability of certain actuator controllers, and can guarantee order of execution instead of relying on separate FixedUpdate()s. If no such handler is subscribed, then mj_step is executed as usual. Pointers to the simulation data for event handlers are included in a custom EventArgs. Related to #233.

I propose an alternative fix to the compiler directives, by configuring the .asmdef in the Editor folder correctly
https://github.com/deepmind/mujoco/pull/303
This avoids having to create a lot of #ifdef directives and keeps the code cleaner overall.

I edited this pull request to only add the events to MjScene that can be used to synchronise behaviour with C# scripts, and removed the edits to the Editor scripts, as I believe #303 handled that part better.

I will submit a separate pull request for the event synchronising functionality from a branch thats more in sync with the deepmind main.


Helmet freezes ElysiaJS

For some time Helmet was preventing Swagger from loading when you visit the /swagger endpoint,
with time a fix was crated where we were suppose to add a directive, then eventually I read that with version 2.0.0 you don't need that fix.
However with my instance of Elysia, /swagger still fails so I maintained the directives fix.
But recently I updated Elysia (v1.1.3) and now it won't run at all, after disabling several plugins I discovered that removing helmet completely - allows Elysia to run.

I will check it out if I find some time :)


vs2022  is supported cuda?

hi，I have successfully compiled this program in VS 2022. I want to know in VS 2022  the Mccl utilizes CUDA resources or not？

No, there is currently no real part of mccl that actually uses cuda yet. So both for windows and linux.
I added it to the setup due to ongoing work.

thanks your reply


ModeratableThing.AuthorName is null when the Thing is of type Post.

https://github.com/CrustyJew/RedditSharp/blob/2.0-.Net-Core/RedditSharp/Things/Post.cs#L37-L41 appears to be the culprit. Removing this and using the inherited version from ModeratableThing should fix this if I'm reading it correctly.

Yeah I believe that's correct. The new is overriding the inheritance.

I see that. Why is it overriding, since it's the same JSON property (author)?

It was probably someone trying to get rid of a compiler warning.. It shouldn't be overridden with new as it is an inherited property.


PHP 7.4: passing ArrayObject to $view->partial() no longer works

Passing an ArrayObject as the $values parameter to the partial view helper no longer works in PHP 7.4 and zend-view 2.11.3.
The issue is that the Partial class internally uses get_object_vars to handle passed objects that don't have a toArray method:
        } elseif (is_object($values)) {
            if (null !== ($objectKey = $this->getObjectKey())) {
                $values = [$objectKey => $values];
            } elseif (method_exists($values, 'toArray')) {
                $values = $values->toArray();
            } else {
                $values = get_object_vars($values);
            }
        }

In PHP < 7.4, this gets you he wrapped array, but in PHP 7.4 get_object_vars now returns only the direct properties of an ArrayObject, not the contents of its wrapped array. Elsewhere in zend-view, like the variable-setting methods of PhpRenderer and ViewModel, objects implementing Traversable and/or ArrayAccess get specially checked for and handled, but not in the partial() helper.
Obviously, not using an ArrayObject eliminates the issue as well. The only reason I'm personally using an ArrayObject as values for the partial in my real-world use is that I'm using the event manager component to allow the values to be filtered, and prepareArgs results in the arguments being stored/retrieved as an ArrayObject. In previous versions I've been able to pass this directly to the partial() helper without issue.
It's possible to treat this as a 7.4 compatibility issue on the application side rather than the framework side, but as the get_object_vars call at issue lives in the framework, I think it's reasonable to consider this a framework issue.
Code to reproduce the issue

$args = new ArrayObject;
$args['key'] = 'value';
echo $this->partial('partial.phtml', $args);

// in partial.phtml

echo $key;

Expected results
Output:
value

Actual results
Notice: Undefined variable: key in partial.phtml

Ref: https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.spl

Thanks, @zerocrates! I am going to release 2.11.4 with the hotfix shortly!


Text formatting in catalog missing (line breaks)

Summary
Text formatting in question catalogs is confusing/missing and gets removed upon export and reimport.
In detail
While working on the RDMO catalog, I wanted to test my changes to the catalog (the xml file itself) and imported them via command line into my local RDMO instance. I managed to get the lists working but I never got the line breaks that I added to the catalog file. Then I started to test a little.
Steps to recreate test
I made a new catalog called "linebreak" in my RDMO instance, with only one question and added the following text as question and help text:
some random text (enter)
some random text (double space)
some random text (dot) .
some random text (slash) /
some random text (backslash) \
some random text (html br)

some random text (xml xA)

some random text (xml xD)
last line

Immediately I looked at the question from the projects point of view and saw this:

Although technically I used the enter button on every line, you can see it didn't do much. Anyway I exported the catalog as xml file to see what the line breaks look line in code so I could use them. The result was:

some random text some random text some random text. some random text/ some random text\ some random text
 some random text
 some random text

Finally i added a second question to the xml file with original text and reimported the catalog to my instance with the following result:

I think it is also important to note that the
-tag makes all the text after it disappear.
Hopefully I didn't miss any obvious hint or rule which would have helped me right from the get go.

I figured out that adding a blank line in between paragraphs to the xml file does indeed show line breaks in the RDMO instance I am working with. However, upon export (to xml) the line breaks get removed again.
Example
first line

second line
third line

in xml produces
first line
second line third line

The RDMO text editor fields do not support rich text or any kind of formating characters. This is an intentional choice to keep things simple and the reason that all these different formatting characters are ignored.
As I see it this is going into the direction of a discussion about changing this behavious and possibly implement some kind of rich text support. We should take the time to discuss and carefully think about it.

I agree, on not supporting rich text. However, don't we have a problem allowing html in rdmo-catalog text?
The current problem is, that blank lines are omitted/deleted in rdmo export as well as content is missing on xml import which destroys all formatting (paragraphs  and enumerations). Was this intentionally introduced as part of the re-factoring of import/export functionality in rdmo v0.11.0
release notes?
For example  rdmo-catalog v0.1.0 provided all this functionality. After the change of the data model in rdmo v.0.11 the functionality seems lost. This is in line with current master rdmo-catalog 74e7350 missing paragraphs and enumeration.

I also agree not to provide rich text formatting, but the basic features, which are already implemented, need to be made obvious and consistent on how to use to the user. This includes:

bold
italic
lists
paragraphs
maybe more

And this is/should be the purpose of this issue as it is crucial for readability of question/help texts.
Still, the above-demonstrated testing revealed other issues that should be acknowledged for. I will list them here but leave it to you on how to approach them i.e. open new issues etc.

formatting when using RDMO editor is inconsistent between question and help text
export

removes parentheses and their content, line breaks and spaces if more than one is present (might be bad for concatenated lists)

import

removes line breaks, spaces
parses HTML in the case of anchor tags  (which is necessary) but breaks in case there is a break tag
, which makes the program ignore everything after it

I reinvestigated the issue. Here is what I found out:
The data are written correctly into the database. Line breaks and everything is there. The same is true for xml files. I exported several projects as xml and reimported these files. The data including line breaks were there.
Where we may have a problem is in rendering the answers. When rendering the view template Django does escape html characters which prevents the browser from rendering them. This is intentional because we do not want everybody to paste html that is treated as such into the webpage. We could simply switch it off but I am not sure if this is a good idea. Maybe there is another solution to render formated. I will investigate.
As said I was not able to reproduce data loss in exported xml files. Maybe I did something wrong. If you could send example files containing the formating that made the issues occur I would have a better chance to dispel eventual misunderstandings.
I tried with the following and they were fine on xml basis.
text (enter)
text (double space)
text  (dot) .
two empty lines

-----
text (slash) /
text (backslash) \
text (html br)

text (xml xA)

text (xml xD)
last line


Remove X-Forwarded-Host header

Carrying over zooniverse/operations#283
Describe your change here.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

I'm confused – is this broken in the current AWS deployment in that case?

I'm pretty sure i reverted it in, https://github.com/zooniverse/operations/pull/337#issue-380814156 and closed it without merge for prod in https://github.com/zooniverse/operations/pull/284
Stupidly i left the current header in there instead of cleaning up, apologies. What is current behaviour is the nginx proxy is setting the response header from the upstream (OMFG) not setting the request header to the upstream, see https://github.com/zooniverse/operations/pull/297

Leave this with me and I'll work on it for the staging API migration

I think this is ready for merge now. @camallen do you agree?


new package: wayland-tracker

What is the status of this PR? I see Travis-CI can no longer merge it automatically? Is it still alive?


Timed out while waiting for handshake

I am getting the following error, please help:
{ Error: Timed out while waiting for handshake at Timeout._onTimeout (node_modules/ssh2/lib/client.js:569:19) at ontimeout (timers.js:386:14) at tryOnTimeout (timers.js:250:5) at Timer.listOnTimeout (timers.js:214:5) level: 'client-timeout' } 'catch error'

issues:  https://github.com/mscdex/ssh2/issues/393


Icons displaying as crossed out box on Android

I'm getting a crossed out box on Android, works on iOS.
'use strict';

var React = require('react-native');
var Icon = require('react-native-vector-icons/Ionicons');

var {
  StyleSheet,
  View,
  Text,
  AppRegistry
} = React;

var Main = React.createClass({
  render() {
    return (

	    <View style={styles.container}>
	    	<Text>Hey</Text>
	    	<Icon name="person" size={45} color="red" />
	    </View>
	)
  }
})

var styles = StyleSheet.create({
	container: {
		flex: 1,
		alignItems: "center",
		justifyContent: "center",
	}
});

AppRegistry.registerComponent('medassist', () => Main);

Here's the path:
android/app/src/main/assets/fonts/Ionicons.ttf

No additional errors, and I've tried deleting the android/app/build folder and re-ran "react-native run-android"
Running on a Mac in Genymotion.

I can't get the IconExplorer example to work either, it has the same box issue.

Ok, got it to work by changing the Fonts folder to lowercase. Might want to change it in the example. I'll keep troubleshooting my own app.

I was running 0.15.0 instead of 0.16.0.

@dangnelson: Thanks for spotting this. I had it changed on my computer but since my file system is case insensitive git didn't see any changes. Had to delete and add it again for changes to take effect.

Add to android/app/build.gradle this line:
apply from: "../../node_modules/react-native-vector-icons/fonts.gradle"
As suggested under Android section in https://github.com/oblador/react-native-vector-icons


Choose once for all which rules to include

I'm using the default laravel preset for multiple projects and almost every time I run composer update for minor releases there are new rules to the preset which in turn makes changes to some files.
I wouldn't call this a breaking change (although it can be - in risky rules e.g. ordered_traits ) but its extremely annoying. I suggest the team sit down and discuss each available rule whether/how it should be implemented into the preset.

You can lock pint to specific version if you want to avoid this, and only bump version every few months.

@crynobone almost every PR is just adding a rule, why not decide once for all which rule to add?

@lazer-hybiz this is exactly the point of this repo. That whenever you update the package you are adopting the current rule set of Laravel. Keeping your code up to date with what we enforce is what this package was intended for. If that’s annoying for you then maybe Pint isn’t for you, sorry.

@driesvints but why not set the rule set of Laravel once for all? why do we need every week a new PR to add a rule?

Because opinions change over time or PHP CS Fixer might come out with rules that'll help us fix styling to our own preferences more.


Question / Request for documentation examples

I am guessing that many, like myself, would like to use esbuild-runner in their Typescript tool chain.
It would be very useful for people who want to try things out to have working examples with different links in the chain other than Jest. For examples might include how to use with:

mocha
node 18's test runner
nyc
c8

I would be more than happy to help with this but my attempts to get it to work with node --test -r esbuild-runner/register have failed...

It turns out that node --test -r esbuild-runner/register works well, but because of the runner execution model it won't find .ts files unless they are added explicitly: node --test -r esbuild-runner/register src/fancy.test.ts.


Possibly wrong collision box for camera_rgb_optical_frame

I simulated Waffle-pi in Gazebo and noticed that there is a collision box defined in front of Waffle-pi:
https://github.com/ROBOTIS-GIT/turtlebot3_simulations/blob/ff1d521a20c67b516b40361463285872ba14f3dd/turtlebot3_gazebo/models/turtlebot3_waffle_pi/model.sdf#L368-L375
Due to this collision box Waffle-pi crashes early to walls. Is this collision box maybe a forgotten artifact from Intelsense camera or is it a feature?

@goekce
Thank you for reporting the issue :+1:
I'll remove this collision box in the next patch.

Closing this issue as the fix has been applied in the recent release.
Thank you.

Closing this issue as the fix has been applied in the recent release.
Thank you.


Broker stop produces a consumer reset

I've been stopping some brokers and found that probably all consumers handled by that broker were reset to a previous position.
This should not be happening as we're mark-deleting 10 times per second.
I've been checking logs but found nothing useful, it would seem that the metadata stored in zookeeper is just old.
Do you know what could be happening @merlimat @rdhabalia ?
Here are the logs for all brokers when the stopped:
broker-logs.txt

I add some more info, I grabbed a random consumer from a random topic which is currently active and find the following cursor info:
cursor info: cursorsLedgerId: 1085466
markDeleteLedgerId: 1009812
markDeleteEntryId: 6153
individualDeletedMessages {
  lowerEndpoint {
    ledgerId: 1009812
    entryId: 6154
  }
  upperEndpoint {
    ledgerId: 1083923
    entryId: 44490
  }
}
individualDeletedMessages {
  lowerEndpoint {
    ledgerId: 1083923
    entryId: 44491
  }
  upperEndpoint {
    ledgerId: 1083923
    entryId: 44495
  }
}

What about this is that ledger 1085466 is closed:
ledgerID: 1085466
BookieMetadataFormatVersion	2
quorumSize: 3
ensembleSize: 3
length: 50
lastEntryId: 0
state: CLOSED
segment {
  ensembleMember: "<IP_ADDRESS>:3181"
  ensembleMember: "<IP_ADDRESS>:3181"
  ensembleMember: "<IP_ADDRESS>:3181"
  firstEntryId: 0
}
segment {
  ensembleMember: "<IP_ADDRESS>:3181"
  ensembleMember: "<IP_ADDRESS>:3181"
  ensembleMember: "<IP_ADDRESS>:3181"
  firstEntryId: 1
}
digestType: CRC32
password: ""
ackQuorumSize: 3

Now, if I get the internal-stats for that topic and consumer I get the following information:
    {
      "markDeletePosition" : "1218534:48417",
      "readPosition" : "1352213:18774",
      "waitingReadOp" : true,
      "pendingReadOps" : 0,
      "messagesConsumedCounter" : 35121719,
      "cursorLedger" : 1085466,
      "cursorLedgerLastEntry" : 0,
      "individuallyDeletedMessages" : "[(1218534:48418‥1333786:41094], (1333786:41095‥1352213:18164], (1352213:18165‥1352213:18248], (1352213:18249‥1352213:18272], (1352213:18273‥1352213:18315], (1352213:18316‥1352213:18336], (1352213:18337‥1352213:18350], (1352213:18351‥1352213:18548], (1352213:18549‥1352213:18593], (1352213:18594‥1352213:18610], (1352213:18611‥1352213:18636], (1352213:18637‥1352213:18760], (1352213:18761‥1352213:18773]]",
      "lastLedgerSwitchTimestamp" : "2017-04-01 06:17:54.742",
      "state" : "NoLedger"
    }

It would seem that the consumer somehow failed to open a new ledger but is never retrying or something of the sort.
What's also strange is that there are no logs of the sort, and it seems that the broker is allowing markDeletes on the consumer but never persisting them.

By the way, @merlimat @rdhabalia is there any other communication channel you handle to contact you more quickly? this is rather critical

@sschepens The NoLedger state is the normal state after the cursor has been recovered, and before any new mark-delete has been issued.
The idea there is to defer the ZK writes for creating a new ledger and updating the cursor z-node until is needed.
In the log that you posted before, can you give the topic/subscription name for which you have added the internal stats?

@merlimat the subscription is 8caa83e304674002a34f441f34f73f63-shipping-feed-orders and the topic is persistent://fury/global/cbead41f2a5849b5a5be64df0f3521d2-orders-orders/cbead41f2a5849b5a5be64df0f3521d2-orders-orders, the information provided is specifically for partition 0 (persistent://fury/global/cbead41f2a5849b5a5be64df0f3521d2-orders-orders/cbead41f2a5849b5a5be64df0f3521d2-orders-orders-partition-0).

@sschepens The NoLedger state is the normal state after the cursor has been recovered, and before any new mark-delete has been issued.

I understand that and I have read the code, but the state is still NoLedger and it has not changed, by the stats-internal it was last changed 11 days ago.

Adding some more info:
That consumer is apparently stuck on message 1218534:48418 and not acknowledging it, though that message was published 2017-04-06 23:00:29.200, so the consumer should have already acknowledged messages between the ledger was last switched and message 1218534:48418.
Also, we have a message expiration of 7 days.

In the log you attached I can only see partition-2 of that topic. Can you reattach the log for partition-0?
Any hints in logs why the TTL is failing to be enforced? There should be a log line printed every ~5min like :
log.info("[{}][{}] Starting message expiry check, ttl= {} seconds", topicName, subName,
                    messageTTLInSeconds);

In addition if the suspicion of the issue is there,  can you enable debug level logs on com.yahoo.pulsar.broker.service.persistent.PersistentMessageExpiryMonitor ?

@merlimat probably partition-0 was not affected when I restarted those brokers, which is why the issue is currently present in it, I will check the stats for partition-2

Any hints in logs why the TTL is failing to be enforced?

The logs are being printend and there doesn't seem to be any failures, it just seems that in that period of time i took the logs there weren't any from PersistentMessageExpiryMonitor.

Over the past 7 days, there seem to have been just a few warning of message expiry fails, for example:
2017-04-06 07:47:41,310 - WARN  - [BookKeeperClientWorker-18-1:PersistentMessageExpiryMonitor$1@106] - [persistent://fury/global/cbead41f2a5849b5a5be64df0f3521d2-orders-orders/cbead41f2a5849b5a5be64df0f3521d2-orders-orders-partition-7][cbead41f2a5849b5a5be64df0f3521d2-orders-buyingflow_notifications] Message expiry failed - mark delete failed
Though none seem to have been from this consumer

@merlimat effectively, partition-2 which was affected by the broker restart was 'fixed' and now contains an Open ledger.
But partition-0 which wasn't affected has the issue of NoLedger state.

So, partition-0 is still running on the "old" broker without restart, correct?
Can you post the logs for that partition?
Also, the info log with the Starting message expiry check ..  message should be printed any way every 5min. Is that happening?

The other question is. Can you try to do the manual expiry operation on that partition/subscription ?
# for 1h expiry:
$ bin/pulsar-admin persistent expire-messages $TOPIC --subscription $MY_SUB --expireTime 3600

And if this fails, it should be printing some error.

So, partition-0 is still running on the "old" broker without restart, correct?

Correct.
Also, the info log with the Starting message expiry check .. message should be printed any way every 5min. Is that happening?
Yes, the logs are being printed and expiry is not failing.
I don't believe expiry is the issue here, when a Cursor is in a NoLedger state and a asyncDelete comes in, it should recreate the ledger, but that's not happening.

I don't believe expiry is the issue here, when a Cursor is in a NoLedger state and a asyncDelete comes in, it should recreate the ledger, but that's not happening.

That's correct and that's irrespective of any throttling, since the 1st request should anyway go through.
Which version of the code the partition-0 broker is using? In the 1.17 code, https://github.com/yahoo/pulsar/blob/f572241537b958a8afda48b8af13ea768a7230f7/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L1494 the async delete should trigger the persistence of mark-delete even if there are unacked messages. Any chance to enable debug logs on ManagedCursorImpl for that broker? Or also a heap-dump might be helpful.
Did you get to see any error line in log like Metadata ledger creation failed ?

close it due to inactivities in this thread. feel free to reopen it if it reoccurs


Support namespace packages under instructlab

The new sdg repository includes a new Python library. The current
consensus on the following issue is that it should be published as a
Python namespace package, instructlab.sdg.
This magic snippet is required to allow this. See the discussion on
the issue for further discussion:
https://github.com/instructlab/sdg/issues/2
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

Timing is perfect! I am just working on making a python package for the schema and will exploit this to use the instructlab.schema package as we currently do using submodules.

One suggests this is not needed, am I missing something?

Both options are valid. PEP 420 namespace packages are the future, but some tooling and our test setup is incompatible with them. For example pylint needs a different configuration to handle them. You can easily reproduce the problem locally by removing src/instructlab/__init__.py and then running tox -e fastlint.
Legacy namespace packages with pkgutil work out of the box.
My recommendation is to use legacy namespace package for now, then refactor and improve after $DEADLINE.

@tiran are the changes included here sufficient to merge?


Unit tests for admission controllers flaky on Travis

Here is a sample of a flake on an admission controller.
--- FAIL: TestWithNoPlanWorksWithSinglePlan (0.00s)
	admission_test.go:212: unexpected error "serviceinstances.servicecatalog.k8s.io \"instance\" is forbidden: no plans found at all for service class \"foo\"" returned from admission handler: list:serviceclasses:, watch:serviceclasses:,
	admission_test.go:216: PlanName was not modified for the default plan

Fix coming the test in question.