Issue5499 Global Transactionals

BLOCKERS - This PR not possible until resolved.
BLOCKING - Users being added to the correct MailChimp accounts: https://github.com/DoSomething/phoenix/issues/5499

[x] user_password transactional, user_language not correct value, see example payload below. Blocked by https://github.com/DoSomething/phoenix/issues/5553
campaign_signup transactional,

[x] user_language not correct value, see example payload below. Blocked by https://github.com/DoSomething/phoenix/issues/5553
[ ] Brazilian user signing up for English campaign should get transactional in English, currently mb-campaign-signup-BR is sent. Blocked by https://github.com/DoSomething/phoenix/issues/5563

campaign_reportback,

[ ] Brazilian user signed up for English campaign should get report back in campaign language - English. Currently language of user location (Brazian) is used to define template name.
[ ] user_language not correct value, see example payload below. Blocked by https://github.com/DoSomething/phoenix/issues/5553

cc: @mikefantini
Fixes #5499 , #5470

Removes user_country from user registrations to allow dosomething_mbp to coordinate value.
Add campaign_language and user_language to campaign signups and report back mbp requests.

To test:
The payload generated by dosomething_mbp to send to RabbitMQ server should look like:

[x] user_register:

Array
(
    [activity] => user_register
    [email] =><EMAIL_ADDRESS>    [uid] => 1705478
    [user_language] => pt-br
    [user_country] => BR
    [merge_vars] => Array
        (
            [MEMBER_COUNT] => 3.5 million
            [FNAME] => Dee Vag Test 27
        )
    [email_template] => mb-user-register-BR
    [mailchimp_list_id] => 66fd18c5a9
    [birthdate] => 929232000
    [subscribed] => 1
    [email_tags] => Array
        (
            [0] => drupal_user_register
        )
    [activity_timestamp] =><PHONE_NUMBER>
    [application_id] => US
)

[ ] user_password:

(
    [activity] => user_password
    [email] =><EMAIL_ADDRESS>    [uid] => 1705478
    [user_language] => pt-br
    [user_country] => BR
    [merge_vars] => Array
        (
            [MEMBER_COUNT] => 3.5 million
            [FNAME] => Dee Vag Test 27
            [RESET_LINK] => http://localhost:8888/br/user/reset/1705478/1445462130/2tUbpFnHSEN6DoMGKLvl73utxEKj7Nzw1YcxIqPpDDY
        )
    [email_template] => mb-user-password-BR
    [email_tags] => Array
        (
            [0] => drupal_user_password
        )
    [activity_timestamp] =><PHONE_NUMBER>
    [application_id] => US
)

[ ] campaign_signup Brazilian user signing up for English campaign should get transactional in English:

(
    [activity] => campaign_signup
    [email] =><EMAIL_ADDRESS>    [uid] => 1705478
    [user_language] => pt-br
    [user_country] => BR
    [merge_vars] => Array
        (
            [MEMBER_COUNT] => 3.5 million
            [FNAME] => Dee Vag Test 27
            [CAMPAIGN_TITLE] => Test Campaign BR
            [CAMPAIGN_LINK] => http://localhost:8888/br/voluntario/test-campaign-br?source=node/1485
            [CALL_TO_ACTION] => This is a test unsponsored campaign.
            [STEP_ONE] => Get your 'Fee!
            [STEP_TWO] => Snap a Pic
            [STEP_THREE] => Submit your photo!
        )
    [email_template] => mb-campaign-signup-BR
    [subscribed] => 1
    [event_id] => 1485
    [email_tags] => Array
        (
            [0] => 1485
            [1] => drupal_campaign_signup
        )
    [activity_timestamp] =><PHONE_NUMBER>
    [application_id] => US
)

[ ] campaign_reportback:

(
    [activity] => campaign_reportback
    [email] =><EMAIL_ADDRESS>    [uid] => 1705481
    [merge_vars] => Array
        (
            [MEMBER_COUNT] => 3.5 million
            [FNAME] => Dee Vag Test 09
            [CAMPAIGN_TITLE] => Video Chat 4 Seniors
            [IMPACT_VERB] => helped
            [IMPACT_NUMBER] => 76
            [IMPACT_NOUN] => people
            [REPORTBACK_IMAGE_MARKUP] =>
        )
    [user_country] => BR
    [user_language] => en
    [email_template] => mb-campaign-reportback-BR
    [event_id] => 1427
    [email_tags] => Array
        (
            [0] => drupal_campaign_reportback
        )
    [activity_timestamp] =><PHONE_NUMBER>
    [application_id] => US
)

Closing as issues have become too complicated for single PR. Moving to various issues / PR.


Distinguish locking failure from other validation error

Is your feature request related to a problem? Please describe.
I want to handle locking failed error explicitly, unlike other reason that will result in a ValidationError to be thrown, locking failure is usually not caused by bug or configuration error.
Describe the solution you'd like
Derive a new type LockingFailedError from ValidationError. Users can handle it by instanceof operator.

Sorry, but I think the case https://github.com/mikro-orm/mikro-orm/commit/b357686a5775e97a0b82eeed59a232302d3b1875#diff-806f6b932f62de2816121040d9a583aaL53 should be a ValidationError. Try to optimistic-locking an entity has no version property is a bug, and will always fail. What users concern about is handling a possible failure path.

I already replied you, it is a validation error, as its a subclass. The code is aligned with how doctrine works, no plans to change that.
https://github.com/doctrine/orm/blob/2.7/lib/Doctrine/ORM/OptimisticLockException.php#L89

What I wanted to handle the case that when multiple processes concurrently modify one entity, resulting in some process failed to commit their modification

it is a validation error, as its a subclass.

Yeah, OptimisticLockError is a subtype of ValidationError, but if OptimisticLockError was designed to denote the case described above, then notVersioned shall put to ValidationError, not OptimisticLockError.
Or we could add another child error class:
// Represents any error relates to optimistic locking error
class OptimisticLockError extends ValidationError {
   static notVersioned() {/*...*/}
}
// Represents the case of concurrent modification conflict
class OptimisticLockFailedError extends OptimisticLockError {
    static lockFailedVersionMismatch() { /*...*/}
    static lockFailed() { /*...*/}
}

Through Doctrine's put all these cases together into one class, I think that is not a good idea.

As I said, this is designed based on doctrine, I have no plans to change it. I really don't see any reason to do so. I do understand what you mean, but I don't see a need to distinguish this.
OptimisticLockError is a runtime error raised when you try to lock and the lock fails. Entity not being versioned is one of the reasons to fail.

I do understand what you mean, but I don't see a need to distinguish this.
It decides whether I should response an HTTP 500 (Bugs) or an HTTP 412 (Failed to update based on the response content of the previous GET request)

Anyway, I can accept it as all notVersioned case could be eliminated by testing


Mod breaks with the new update

Fixing a bug, where the new update will cause the mod to break, when the Bogwitch update is released.
This update introduces a new method "InstantiateAsync" for "UnityEngine.Object", which is returned by InstantiateGameObjectMethod instead of the original function "Instantiate". This ultimately causes some Harmony transpiler patches to fail.
By replacing the "StartsWith" condition inside InstantiateGameObjectMethod with "Equals", this new function is not considered anymore, as an exact match of the name is required.
This should have no effect for people, running an older Valheim version.
The breaking change happened with 0.219.13 (currently on PTB).

Nicely spotted. Thanks!


Update ci for foxy

Codecov Report

:exclamation: No coverage uploaded for pull request base (foxy@9229bce). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             foxy    #153   +/-   ##
======================================
  Coverage        ?   3.59%
======================================
  Files           ?      13
  Lines           ?     947
  Branches        ?     152
======================================
  Hits            ?      34
  Misses          ?     843
  Partials        ?      70

Flag
Coverage Δ

unittests
3.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9229bce...5f57d15. Read the comment docs.

Merging because CI starts to be in a strange state.


Added Python solution for 284. Palindrome Linked List

@Tahanima apu, I submitted the same code and it did not give me a Runtime Error

@Tahanima apu, I submitted the same code and it did not give me a Runtime Error

@JoyKrishan, got it. Your folder naming is incorrect! Please change the folder name.


(Tuya) tira_iwiik_iwwctlrgb-v1.0.2 dump custom profile not working

Hello, after i tried the lightleak app which told me the device is not exploitable i connected one of them via uart and dumped the firmware with the BK7231 Flasher(New one)
As result i got the attached file
iwiik_tria-led-stripe-v1.0.2-BK7231T.bin.zip
When i try to create a custom profile with this dump i get a new folder and in the cli i see that the schema already exists.
Sadly when i copy over the generated profile and try to use it it always aborts with "exploit failed"
May someone look over this and tell me if it is doable to use cloudcutter with this dump?
Edit more info:
the product code is IWWCTLRGB
these are led strip controllers with wifi+ir
they got an BK7231T (https://developer.tuya.com/en/docs/iot/wb3s-module-datasheet?id=K9dx20n6hz5n4)
Thanks in advance.

Which flasher did you use? I see that the produced dump is "swapped" i.e. bootloader is at the end of flash. This is not the issue in your case, but I wonder if you just used an older version of the flasher (in which case you should update) or the flasher is still producing incorrect dumps.

Hello there, i used this one "https://github.com/openshwprojects/BK7231GUIFlashTool/releases/tag/v1.0.7"

Added as IWIIK IWWCTLRGB RGBCT LED Light Strip


exchanged arguments.callee with recursive call for strict compliance

using this in a react project and it throws an error for arguments.callee since its deprecated. Please review. Thank you.

Hi @McKean,
Thanks for your PR, that's great! :+1:
I merged into the dev branch for now (https://github.com/VincentGarreau/particles.js/pull/66), i'll merged into the master soon (for the 2.0.1 version).

Is this merged to master?


add SendServiceUnavailable response

Description
SendServiceUnavailable response is to be used in aggregator
Adds CODEOWNERS
Fixes #53 #55
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
Unit tests (no changes in the code)

Testing steps
make test

@natiiix Just wanted that easy automatic review from the codeowners, since we're the only contributors so far. like you said, anyone can make PRs for that if necessary


Make python script generates json files from TSV spreadsheet

See https://github.com/BD2KGenomics/dcc-storage-schemas/pull/9

Chris has finished this... but you need to adapt the merge process to use his output.  See the pull request I mention above, I started this work for you.


This is not An issue , but i like some help

I become from java and php, and have this amazing solution. but i have two diferente session from sending and receiving messages. i'm still learning Go. is there a way to reuse the wac connection for do both thing, sending and receiving?
thanks.
Victor

There is no reason to have two sessions to send and receive...

This is two-way communication why do you need two sessions?
Do you want to receive from one line and send by another?

I think you can close this issue e request some help on PM messages

It's problematic to have two (or more) simultaneous sessions for the same ID. The web.whatsapp protocol expects only one session at a time. The webapp notifies you if you're running multiple sessions (and prevents you from doing so) for a reason.

Done, learning more GOLANG !!!!!!!


[HOPS-1620][HOPS-1619]

Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPS-1619
https://hopshadoop.atlassian.net/browse/HOPS-1620

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Can one of the admins verify this patch?


Ionic 2.0.0 RC.0, getting started, tabs sample app

Hi
Very basic. I'm trying out the release candidate, with the sample tabs app.
ionic serve -p $PORT --nolivereload
And I get these errors:
[19:49:15]  src/app/app.component.ts(1,27): error TS2307: Cannot find module '@angular/core'.
[19:49:15]  src/app/app.module.ts(1,26): error TS2307: Cannot find module '@angular/core'.
[19:49:15]  src/app/main.dev.ts(1,40): error TS2307: Cannot find module '@angular/platform-browser-dynamic'.
[19:49:15]  src/pages/about/about.ts(1,27): error TS2307: Cannot find module '@angular/core'.
[19:49:15]  src/pages/contact/contact.ts(1,27): error TS2307: Cannot find module '@angular/core'.
[19:49:15]  src/pages/home/home.ts(1,27): error TS2307: Cannot find module '@angular/core'.
[19:49:15]  src/pages/tabs/tabs.ts(1,27): error TS2307: Cannot find module '@angular/core'.

Should I assume that the tabs sample app has not been updated yet?
Thanks
Tom

It has been.  Let me take a quick look. I validated yesterday evening.
Thanks,
Dan

I just did this without any issues:
ionic start myApp -v2
ionic serve

Can you try npm install on your machine in your project folder?  I'll reopen if needed.
Thanks,
Dan

i just did
ionic start io -v2
ionic serve

and
`[23:13:29]  src/app/app.component.ts(1,27): error TS2307: Cannot find module '@a
ngular/core'.
[23:13:29]  src/app/app.module.ts(1,26): error TS2307: Cannot find module '@angu
lar/core'.
src/app/main.dev.ts(1,40): error TS2307: Cannot find module '@angular/platform-b
rowser-dynamic'.
src/pages/about/about.ts(1,27): error TS2307: Cannot find module '@angular/core'
.
src/pages/contact/contact.ts(1,27): error TS2307: Cannot find module '@angular/c
ore'.
src/pages/home/home.ts(1,27): error TS2307: Cannot find module '@angular/core'.
src/pages/tabs/tabs.ts(1,27): error TS2307: Cannot find module '@angular/core'.
[23:13:29]  typescript compiler ready in 4.49 s
[23:13:29]  bundle dev started ...
[23:13:29]  Error: Could not resolve '@angular/platform-browser-dynamic' from D:
\dl\io.tmp\app\main.dev.js
at Error (native)
at D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugin-node-
resolve\dist\rollup-plugin-node-resolve.cjs.js:78:21
at D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugin-node-
resolve\node_modules\browser-resolve\index.js:265:24
at D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugin-node-
resolve\node_modules\resolve\lib\async.js:46:14
at process (D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plu
gin-node-resolve\node_modules\resolve\lib\async.js:173:43)
at ondir (D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugi
n-node-resolve\node_modules\resolve\lib\async.js:188:17)
at load (D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugin
-node-resolve\node_modules\resolve\lib\async.js:69:43)
at onex (D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugin
-node-resolve\node_modules\resolve\lib\async.js:92:31)
at D:\dl\io\node_modules@ionic\app-scripts\node_modules\rollup-plugin-node-
resolve\node_modules\resolve\lib\async.js:22:47
at FSReqWrap.oncomplete (fs.js:82:15)
[23:13:29]  sass started ...
[23:13:29]  sass failed:  Cannot generate Sass files without first bundling Java
Script files in order to know all used modules. Please build JS files first.
[23:13:29]  build dev failed:  Build failed`

As I'm on cloud9. New blank workspace, then
npm install -g ionic cordova
I was doing this:
ionic start myApp tabs -v2
then:
ionic serve -p $PORT --nolivereload
Not sure if that's any different. But I thought I'd pass it on.
Thanks

Can you take the arguments off of ionic serve? I'm not sure if they'll work anymore to be honest. Hmm, it should be able to find those things.

I can't sadly, it's a cloud9 quirk

my node_modules only consists these and npm install does nothing.

Ahhh, are you using npm 2?
npm --version

We require npm 3.
That is most likely why you're seeing this issue.
Thanks,
Dan

hmm yes..
npm 2.15.9
maybe this should be included also for steps to upgrade?

Good idea, I will add it now. Thanks!
Thanks,
Dan

Yes that was it for me too. Thanks both of you.

Thanks!

@danbucholtz Thanks!
This is a problem often ignored by developers. Best in documentation.

@danbucholtz  I also got the same error on ionic serve
Your system information:

Cordova CLI: 6.3.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-rc.0
Ionic CLI Version: 2.1.0-beta.3
Ionic App Lib Version: 2.1.0-beta.1
OS: Distributor ID:	LinuxMint Description:	Linux Mint 17.3 Rosa
Node Version: v6.7.0

arvin@arvin-Inspiron-3543 ~/mobile/gumanaka $ npm --version
3.10.8

```
![node_modules](https://cloud.githubusercontent.com/assets/11252974/18958796/74700f8e-8696-11e6-9cc6-73aa3c4257bd.png)

@arkeds,
Can you try updating to npm 3.x? Can you run npm --version and make sure it's 3.x?
Thanks,
Dan

@danbucholtz  npm is 3.10.8
arvin@arvin-Inspiron-3543 ~ $ npm --version
3.10.8
`
```

Can you run npm install again? I don't see the angular modules installed.  npm 3 installs modules in a flat hierarchy, which we need.
Thanks,
Dan

@danbucholtz  I've tried that, install and update. I've searched for the @angular/core files and it somehow located in ionic-angular/node_modules directory.

So I copy and pasted it to the main node_modules directory and the errors are gone, now I'm just seeing a blank page on the browser.

Yep, ionic-angular install @angular/xyz.  It really seems like you're running npm 2.x.
Thanks,
Dan

@danbucholtz  but the npm version is showing 3.10.8.  I've run npm install npm -g multiple times.

I've made the mistake of running it in the wrong directory sometimes?


Uncaught exception (file "lwt_unix.cppo.ml", line 244, characters 14-31)

Found on Windows 10, Flow 0.62, run through WebStorm - also see WS ticket https://youtrack.jetbrains.com/issue/WEB-30395
C:\Tools\flow.exe server C:/Users/mha/OneDrive/Projects/one
[info] argv=C:\Users\mha\OneDrive\Tools\flow.exe server C:/Users/mha/OneDrive/Projects/one
[info] Creating a new Flow server
[error] Closing connection 'server #1' due to uncaught exception in read loop: Unix.Unix_error(Unix.EPIPE, "read", "")
[error] backtrace:
[error] Raised by primitive operation at file "lwt_unix.cppo.ml", line 244, characters 14-31
[error]
[error] Flow server (pid 368) exited with code Dfind_died (99)
[info] Creating a new Flow server
[error] Closing connection 'server #2' due to uncaught exception in read loop: Unix.Unix_error(Unix.EPIPE, "read", "")
[error] backtrace:
[error] Raised by primitive operation at file "lwt_unix.cppo.ml", line 244, characters 14-31
[error]
[error] Flow server (pid 660) exited with code Unknown_error (110)
[info] Monitor is exiting (Dying along with server)
[info] Broadcasting to threads and waiting 1 second for them to exit

Key lines:
...uncaught exception in read loop
...
Raised by primitive operation at file "lwt_unix.cppo.ml", line 244, characters 14-31

Still the same messages - Flow 0.65              (ping)

same here

same with PhpStorm 2017.3.4 and Flow 0.65:

Build #PS-173.4548.32, built on January 30, 2018
JRE: 1.8.0_152-release-1024-b11 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.13.3

Same with latest Flow 0.66

Error still occurs

Same here

Same here. flow 0.67.1
MacOS X 10.13.3
WebStorm 2018.1 EAP and 2017.3.5

flow 0.68 same thing

@lll000111 According to above comments, "Windows support" label should be removed. (Crashes on Mac as well)

@levenleven I didn't do it! I have no labeling rights.

flow 0.68 same here

@gabelevi As most flow issues this one just closed without resolution. Open another one and it will be closed the same way in a few months. How does this affect user experience? - flow fails to start.

I'm having the same issue suddenly, launching flow directly from command-line (Windows 7 Enterprise, flow-bin v0.67.1). Weirdly enough it started exhibiting after I've spend quite a bit of time updating to the latest flow-bin throughout our whole codebase.

So ... found the real culprit in my case by running flow check, which prints out the full stack trace directly. Turns out Flow was crashing when trying to parse node_modules/module-deps/test/invalid_pkg/package.json, because it contains just a string, not an object. Adding .*/node_modules/module-deps/.* to [ignore] in .flowconfig fixed the problem.

@hon2a can you file a new issue specifically about the crash parsing JSON? thanks :)

@mroch Sure thing!


Keras 2.2.4 doens't accept pathlib.Path when saving models, but older versions did.

I recently updated keras to 2.2.4 and now when I create a model and use model.save with a pathlib object, I get the following error.

TypeError: Required Group, str or dict. Received: <class 'pathlib.PosixPath'>.

Is this new behavior the expected behavior, or should a pathlib.Path be acceptable? I reinstalled keras version using pip install keras==2.2.x, and both 2.2.3 and 2.2.4 are broken but 2.2.2 worked as expected.
System information

OS Platform and Distribution : Centos 7
TensorFlow backend (yes / no):  yes
TensorFlow version:  1.13.1
Keras version:  2.2.4
Python version:  3.4.9
CUDA/cuDNN version: 9.1
GPU model and memory: nvidia cards 2080 or 1080ti

Code to reproduce the issue
from keras.layers import Input, Dense
from keras.models import Model
import pathlib

inputs = Input(shape=(784,))
x = Dense(64, activation='relu')(inputs)
x = Dense(64, activation='relu')(x)
predictions = Dense(10, activation='softmax')(x)
model = Model(inputs=inputs, outputs=predictions)
model.save(pathlib.Path("junk.h5"))
#model.save(str(pathlib.Path("junk.h5"))) works though.

@odinsbane i think model.save requires filepath as a string in 2.2.2, 2.2.3 and 2.2.4. There could be some changes in dtype of output of pathlib.Path.  you can use model.save(str(pathlib.Path("junk.h5"))) for all the three keras versions without any issue. thanks!

Closing due to lack of recent activity. Please update the issue when new information becomes available, and we will open a new issue. Thanks!

I am travelling, but you misread what I wrote. It used to work, says it
should work in the API, and now it doesn't work. Possibly update the api.
thank you
mbs
On Wed, 8 May 2019, 8:28 pm Vishnuvardhan Janapati, <
<EMAIL_ADDRESS>wrote:

Closed #12754 https://github.com/keras-team/keras/issues/12754.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras/issues/12754#event-2328392609, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2NNEMMDAIKJY36WNUPNJ3PUMZVTANCNFSM4HIV5TQQ
.

@odinsbane I can understand your question. My answer is this is not related to keras. It is related to Pathlib library.
In Keras 2.2.2, 2.2.3 and 2.2.4, model.save expects a string input as follows
model.save('my_model.h5')
When we use Pathlib library with Keras 2.2.3 and 2.2.4 as
model.save(pathlib.Path("my_model.h5"))
it throws an error as TypeError: Required Group, str or dict. Received: <class 'pathlib.PosixPath'> which means that when we use Pathlib with Keras 2.2.3 and 2.2.4, the output of pathlib.path is not a string. Please let me know if I miss anything. thanks!

Thank you for your response. I think I misread the documentation and
actually I should just stick to using strings instead of Paths.

which means that when we use Pathlib with Keras 2.2.3 and 2.2.4, the
output of pathlib.path is not a string.

Of course pathlib.Path is not a string it is a Path. That was supported up
until 2.2.2, and broken as of 2.2.3. After re-reading the documentation, I
think I missunderstodd.
filepath: String, path to a ...
I thought that meant String, or a path object but it makes more sense that
it means the path is a string. I was further confused by the fact the code
includes a condition for checking if the object is a pathlib.Path.
https://github.com/keras-team/keras/blob/master/keras/utils/io_utils.py#L206
So it is a bit ambiguous as to whether a pathlib.Path will be supported or
not. As you say though, I will just stick to using a string.
Cheers
Matt
On Thu, May 9, 2019 at 12:27 AM Vishnuvardhan Janapati <
<EMAIL_ADDRESS>wrote:

@odinsbane https://github.com/odinsbane I can understand your question.
My answer is this is not related to keras. It is related to Pathlib library.
In Keras 2.2.2, 2.2.3 and 2.2.4, model.save
https://keras.io/getting-started/faq/#how-can-i-save-a-keras-model
expects a string input as follows
model.save('my_model.h5')
When we use Pathlib library with Keras 2.2.3 and 2.2.4 as
model.save(pathlib.Path("my_model.h5"))
it throws an error as TypeError: Required Group, str or dict. Received:
<class 'pathlib.PosixPath'> which means that when we use Pathlib with
Keras 2.2.3 and 2.2.4, the output of pathlib.path is not a string. Please
let me know if I miss anything. thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keras-team/keras/issues/12754#issuecomment-490687121,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2NNELVQH4X6ZPSG6D6TY3PUNOVFANCNFSM4HIV5TQQ
.

@jvishnuvardhan why wouldn't you wrap filepath in self.filepath = str(filepath) in the package implementation but rather insist on passing a string as input? With py3, pathlib becomes the recommended way of path handling and so it is a plus for packages that support this simple functional flawlessly.
Now image a user who made a script to train 100500 epochs and then keras failed to save the model just because it does not support Path objects.
-_-

Moreover, model.load_weights() is also not wrapped in str(). Same issues as mentioned on this thread while loading the weights into a model.
Can the API be changed to include support for Pathlib objects? @jvishnuvardhan


Enable write in option for case notes

Business Context:
I want to enable case note actions on the case details page to be added manually, similar to what we enabled on https://github.com/PublicDataWorks/complaint-manager/issues/272 and https://github.com/PublicDataWorks/complaint-manager/issues/291 (for both NOIPM AND Hawaii)
As an NOIPM and Hawaii employee
I want to be able to add new case note actions when adding a case note
So that I don't have to do a workaround when there's no existing action I want to add that isn't on the list
In Scope

Update handler to accept actions that weren't already created (by allowing to write in an action and linking it to a case note).
Change "Action Taken" dropdown on the CaseNoteDialog into a CreatableDropdown that lets users add new ones.
Do not store the manually created action taken. Do store the manually created action taken.
Ensure that "Add Case Note" is logged the audit export

Out of Scope

Update the current list of case actions to remove NOIPM specific actions (this will be generalized later on).

Open Questions
Mockups

Acceptance Criteria

Scenario:
Given I am adding a case note to a case
When I select an action
Then I can select an action from the drop down OR add a new action by writing them in

Scenario:
Given I am editing a case note on a case
When I select an action
Then I can select an action from the drop down OR add a new action by writing them in

Checklist (should be reviewed before grooming as the BA or Pair are writing the card—NOT reviewed for the first time at grooming)

[ ] Ensure to include all necessary mockups to this card.
[ ] Discuss what success/failure user feedback messages would be present, if any occur (front end/back end).
[ ] Discuss Feature Flag: Where could a development flag go to flag off incomplete work? Do we want to keep the flag long-term?
[ ] If this card is part of a sequence of cards, discuss if this card should be blocked until the testing of previous cards in the sequence have been finished.
[ ] Have we added edge cases as ACs that we're considered from a QA perspective
[ ] Should the new functionalities be offered only to users with certain permissions?
[ ] How should this functionality differ between different orgs, and if it does differ, what is the hinge point we should use for that functionality?

Notes:

CaseTagDialog should be one example where this sort of thing is already set up

we did code review on February 12 2024

Verified write-in option for case notes is working as expected.
NO Staging
https://github.com/PublicDataWorks/complaint-manager/assets/134408135/e480a33d-c201-4908-b2a9-19a281b4c639
Hawaii Staging
https://github.com/PublicDataWorks/complaint-manager/assets/134408135/90f081d9-d152-4723-9fff-9cfe6fc10360


Adds an <a> tag.

Does what it says on the tin. ^^
Closes #6.
(*also, was made on a branch off from my internal branch for PR #18, because I'm not actually that bright, apparently. As that one is going in, maybe this is ok? If not, I can rebase this against main-line)
From the commit message:
|     Implemented as a subclass of ComponentTagElement.
|
|     Overrides setContent() to set it's Component text to:
|     - have text be the use supplied text between  and ,
|     - have hoverEvent show the href attributes value,
|     - have clickEvent use open_url on href attribute.
|
|     Adds parseURL() to ElementParsingUtils.
|     - has no default parameter, but is @Nullable:
|             - lets java.net.URL do the work of validating the user supplied href,
|             - were just going to use URL.toString() anyhow, cause that's what ultimately is needed by MC.
|
|     Of course, adds addSerializer("a", LinkTagElement::new); in DefaultTagProvider

OK, yeah, having all the other commits in here looks silly. Will rebase after dinner.


refactor(storagenode): simplify unary RPC logging

Current dependencies on/for this PR:

main

PR #409

PR #411

PR #412

PR #413   👈

PR #410

This comment was auto-generated by Graphite.

Codecov Report

:exclamation: No coverage uploaded for pull request base (remove_backup_from_append_request@b1e0982). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@                         Coverage Diff                          @@
##             remove_backup_from_append_request     #413   +/-   ##
====================================================================
  Coverage                                     ?   63.26%
====================================================================
  Files                                        ?      131
  Lines                                        ?    17815
  Branches                                     ?        0
====================================================================
  Hits                                         ?    11271
  Misses                                       ?     5989
  Partials                                     ?      555

Impacted Files
Coverage Δ

internal/storagenode/storagenode.go
73.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@ijsong started a stack merge that includes this pull request via Graphite.

@ijsong merged this pull request with Graphite.


Misalignment between GitHub and PyPi releases?

As per subject line, I'm trying to understand why the latest release on GitHub is 0.10.3 however, on PyPi it's 0.10.8 at time of writing.
It seems like this should be aligned but maybe there is something I am not taking into consideration...

The github release process is not automated currently. PyPi has the correct version and you can see it reflected here in the pyproject.toml
Automating it is a valid todo, but it could also be deferred if I put a disclaimer in the docs that pypi is the source of truth. I'll take a look tomorrow.

This is done now via set up of a github actions release flow.


Update convenience constructor (NutrientPhytoplanktonZooplanktonDetritus and LOBSTER) docstrings

Realised they don't include info about how to use scale_negatives etc.
Also fixes #151

actually this PR bumps a patch release so #171 is rendered redundant!


Autoscroll descriptors list only when scrollbar is down

There’s a thing with the Descriptor list menu. When it’s long, then a scrollbar shows up. When you select a Desc in the top position of the list, it scrolls the menu to the bottom of it.

Will be shipped in next version


New package: ScalarRadau v0.2.0

Registering package: ScalarRadau
Repository: https://github.com/wordsworthgroup/ScalarRadau.jl
Created by: @wordsworthgroup
Version: v0.2.0
Commit: 7eb078b65ec8f146098254638bacef414ee97271
Reviewed by: @wordsworthgroup
Reference: https://github.com/wordsworthgroup/ScalarRadau.jl/commit/7eb078b65ec8f146098254638bacef414ee97271#commitcomment-50034410

@wordsworthgroup please see the message above.  Once you fix the automerge issues you can register again the new revision without changing the version number and this pull request will be automatically updated.
[noblock]


Frontend packages standardization

          Frontend packages standardization

Code quality

[ ] Use eslint and prettier configuration from wheel. Make sure that lint-staged is correctly configured to cover all files in the package during commit.
[x] Use zustand for state management. Remove the use of contexts.

Dead code removal

[x] #603
[x] #604
[x] #605

Dependency management

[x] Move dependencies to devDependencies this will speed up package installation time. We don't need dependencies as we are serving bundles. Try to move packages to peerDependencies if the package exists on host project too. Refer: neetoui, neeto-commons-frontend
[x] #606

General enhancements

[x] Clean up documentation & include exported functions, development & release instructions.
[ ] #607
[x] Have a mechanism to test changes without depending on a host project and yalc: example: neeto-team-members-frontend
[x] Have type declaration for all exports: example: neetoui

Building & releasing

[x] Standardize release process: release on merge. Example: neetoui
[x] Use rollup for bundling
[x] Export ESM bundles

Originally posted by @Amaljith-K in https://github.com/bigbinary/neeto-engineering-web/issues/282#issuecomment-1415911052

@gaagul _a please go through the checklist and mark the ones that are already complete. Please raise issues to track the remaining work.
epic _t

@AbhayVAshokan _a Are we using eslint and prettier config from wheel?
I have created issues for rest of the remaining work in the checklist.

Please refer to the eslint folder and prettierrc file https://github.com/bigbinary/neeto-commons-frontend/tree/main/configs. The configs are now served from neeto-commons-frontend. The changes in the eslint/helpers.js file needs to stay as it is due to the difference in folder structure between a neeto product and a nano.
Yes please add nv2 tags to the created issues.

@gaagul _a

@gaagul could you please tell me when this will be finished?

@gaagul could you please tell me when this will be finished?

I will finish it by today itself.

@AbhayVAshokan All the checklist have been completed, Can we close this issue now ?

Great. Closing as completed.


Hidden Brain (podcast)'s RSS feed is empty

Steps to reproduce

Subscribe to this URL
2. https://feeds.simplecast.com/kwWc0lhf
3. alternatively, get the URL from https://hiddenbrain.org/

When I paste the same URL in the browser or in NetNewsWire (another RSS reader), I get content

Hi @Fullchee,
Does this happen on commafeed.com or your own instance?

Marking as closed! I can't seem to reproduce this anymore!


[draft] remove mold for faster sccache

Testing the difference in CI build time with and without mold because of sccache issues 1755.
To compare with previous CI run: https://github.com/Trow-Registry/trow/actions/runs/6603241796/job/17936138280

previous run with mold + sccache: 1m49s
no mold run 1: 3m2s
no mold run 2: 2m2s
Quick conclusion: mold is doing it's job, https://github.com/mozilla/sccache/issues/1755 doesn't apply here


Using a library that uses Nullish Coalescing operator (??) breaks Storybook build

Storybook doesn't work when we add a library (in this case, react-facade) that uses the Nullish Coalescing operator ?? added in TypeScript 3.7.
Here's a screenshot of the error:

Here's a fix: specify a loader on webpack config:
module.exports = async ({ config, mode }) => {
  config.module.rules.push({
    test: /\.(mjs|jsx?)$/,
    loader: 'esbuild-loader'
  });

  return config;
};

We chose esbuild-loader which is faster than babel-loader but either one works.


la-go-live

Docs Build status updates of commit 1009ed7:
:clock10: Pending: waiting for processors (31 builds ahead of you)
:warning: Docs Build is busy, currently there are 31 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 1009ed7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/NewappAddmenudropdown.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/checklist-app-template-compose-view.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/AppStudio.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Bots.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Finishedhelloworld.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/HelloWorldappdetails.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Importinganapp.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Importinganapp2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/InstalledAppStudio.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/InstallingAppStudio.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/InstallingHelloWorld.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Messagingextensions.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/PersonalTab.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Setupbot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/TeamTab.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/Testanddistribute.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/get-started/app-studio-finished-app.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-import.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-imported-app.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-bots-setup-dialog.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-bots.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-mess-ext.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-p-tabs-dialog.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-tabs.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-test-dialog.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor-test.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-manifest-editor.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio-store.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/app-studio.png
:white_check_mark:Succeeded

msteams-platform/assets/images/get-started/searchforAppStudio.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/poll-app-template-compose-view.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/store-upload-a-custom-app2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/survey-app-template-compose-view.gif
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/add-power-virtual-agents-bot-to-teams.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
:white_check_mark:Succeeded
View

msteams-platform/build-your-first-app/build-first-app-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/apps-package.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/deploy-and-publish/apps-upload.md
:white_check_mark:Succeeded
View

msteams-platform/feedback.md
:white_check_mark:Succeeded
View

msteams-platform/includes/get-started/get-started-use-app-studio.md
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Swiper skips a slide when roundLengths is true

Consider this example:
https://codepen.io/anon/pen/rdXdNb
When we swipe right to the end and then swipe left the second page is skipped and we reach the beginning. The problem persists only when roundLengths is true and there is only one slide at the last page.
Can you give us a hint what might be wrong?

Hi @myonov , I checked your example. That is really interesting bug. I am doing some research for this now, but I recommend u should also raise this issue to Swiper.


support configuration

Signed-off-by: Jiangnan Jia<EMAIL_ADDRESS>
Describe what this PR does / why we need it
Add configuration support
Does this pull request fix one issue?

Fixed #18
Describe how you did it

add API-style in NewControlPlane for other control-plane to integrate
Add Priority of loading config: NewControlPlane Options > SystemEnv > YamlFile > Default
by this Priority order makes the unique value, when config-items were provided by several way,
If start OpenSergo directly, can also provide config-items by command args, which will adapt to NewControlPlane Options.

Describe how to verify it

exec ./main -h to get command args helps
add different values in command args, SystemEnv, yaml file

# command args : -p means give a port -c means the path of config
./main -p 8080 -c /opensergo.yaml

# SystemEnv: /etc/profile
OPENSERGO_ENDPOINT_PORT=8081

# /opensergo.yaml    filePath which was given by command above
endpointPort: 8082

Special notes for reviews

cc @123liuziming @panxiaojun233


AudioSession.diff

Hi AudioSession.diff is not working please fix it

Jockey's issues page is not for development questions. Please refrain from asking any more specific development questions here such as this, #116, #134, and #137. Questions about design decisions or anything in Jockey's existing codebase are okay, though.


what is color space and reference level of RGB camera?  bt.601, bt.709, bt.2020, ...?

The colorspace and reference levels (aka range aka swing) of the RBG camera data is missing in all known documentation. The colorspace and its reference white/black must be known and consistently used by Microsoft and developers so that conversions between colorspaces and formats are accurate. Without clarity, errors and color shifts easily occur in core Kinect DK and in customer code. (FYI, I found and assisted Microsoft to fix colorspace code in the Kinect v2 SDK)
Repo

Look in your SDK docs, Azure guides, 3rd party articles, or the customer-facing OV12A10 product datasheet.
Do a internet search for "Azure Kinect colorspace"

Actual
I do not see it in your SDK docs, Azure guides, 3rd party articles, or even the customer-facing OV12A10 product datasheet.
Expected
Somewhere to be listed, for example

RGB camera colorspace:  BT.709 full-range (0->255)

That was only an example and not the actual.
By knowing this, a developer can take, for example, the YUY2 frames and convert them using custom code into a wide variety of output formats using well-known transformation formula.
This colorspace topic has been well explored by the Kinectv2 team and the XBox team.

I have suspicions...that something isn't correct in the DK.
Please reference https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/95f1d95f1f335b57a350a80a3a62e98e1ee4258d/tools/k4aviewer/k4acolorimageconverter.cpp#L104
That line of code is calling libyuv::YUY2ToARGB()
It appears that the DK uses the submodule https://chromium.googlesource.com/libyuv/libyuv
and the code in that submodule for that function is here https://chromium.googlesource.com/libyuv/libyuv/+/refs/heads/master/source/convert_argb.cc#2121
and that library code calls on line 2179...
YUY2ToARGBRow(src_yuy2, dst_argb, &kYuvI601Constants, width);

That requires that the camera data coming from the KfA camera must be BT.601 and a yet-undetermined range. (I would have to further dig into code to see what range it is).
Given that the RGB camera in KfA was made in 2019 and it has more than HD resolution, it is very unlikely the camera delivers BT.601 data. This then suggests that non-BT.601 data is being manipulated/converted using BT.601 algorithms. This leads to inaccurate color shifts.
And still the range is unknown.

@diablodale thank you for reporting this. We are requesting this information from the HW team and will get back to you once we confirmed it.

@diablodale we just get back the confirmation from the color camera hardware team, they confirm the color space conversion standard is BT.601 for this color camera. Therefore, the current k4aviewer is doing the right thing, and we will add this information to the documentation location https://docs.microsoft.com/en-us/azure/Kinect-dk/hardware-specification.

That is surprising and a step backward as HD cameras and modern video pipelines use bt.709 or newer.
Please note...the Kinect v2 sensor...was full-range YCbCr BT.709.
Technically, it is possible the hardware team designed the hardware and firmware to be BT.601. But it is very very odd. And outdated.
Please do update the documentation as you write and also put if it is full-range or studio-range. Listing only BT.601 is not enough.

Based on what we heard from the hardware and firmware team, it should be: BT.601 full-range. We will update the documentation. Thank you for the feedback

We have updated the documentation with adding this information https://docs.microsoft.com/en-us/azure/Kinect-dk/hardware-specification


Strange shell name @ screenfetch 👀

AT FIRST I WAS LIKE BUT THEN I WAS LIKE

BUT THEN I

😂

Probably this program determines $SHELL in some non-standard way. I'll close this issue as it doesn't affect any real use-cases.


Lean option

Hi, is there any way to use lean method in the query?

Hey @AlbertoJALJ,
The lean option is already done by default if the query is not an aggregate (as you can see inside the code).
For now, there is no option to disable it, but I can add this option asap.
Thanks

Thanks!


Enhancement Request: Unsharp mask filter

Would you consider adding Unsharp mask filter?  Here is another project that has it, but would prefer it to be added to ImageProcessor for consistency and flow.
http://kaliko.com/image-library/source-code/
Thanks,

You mean for the new Core library? I probably won't be adding any new features to the Framework library.
Should be pretty easy to do. It's essentially blurring a copy and applying the following formula.
https://en.wikipedia.org/wiki/Unsharp_masking#Digital_unsharp_masking

Yea, I saw that after I posted to see if I could do something similar with what you already have.  I was looking at the source for both the libraries, and the kaliko library uses gaussianblur.  At first I was thinking to try something similar to Original + ( Original - Blur) * Amount, but didn't really know where the "Amount" would be applied.  Then I figured that since GaussianSharpen already has similar parameters to the kaliko library, I would try that.  I am able to get a similar effect with radius to 2, sigma 1, threshold 1.  Though it looks a bit too sharp, it may work out.  I am trying to write a program that is similar to Gimps plugin - David's Batch Processor https://sourceforge.net/projects/gimpdbpplugin/, and get similar effect.  The plugin doesn't do recursive folder search though, and I have about 7,000 pngs to modify.  I also want my app to compress the images, which it looks like you have Quantization built in.  I will play around with it more, but image manipulation isn't my strength and don't know the ImageProcessor library that well so I may have more questions.   Thanks for your time!


See total budget an item is contributing with

Screenshot

Checklist

[x] Feature developed
[x] Create new page with a title corresponding to the item details user clicked on the budget grid
[x] The new page route should be dynamic with item ID in it
[x] Display subtitle under title as a percentage with red minus sign showing outflow, green plus sign for inflow
[x] Draw a pie chart showing how much of the entire budget this item is contributing with
[x] No other items from the budget should be on that pie chart
[x] Put a back button to return back to the previous route
[x] Make the view mobile and desktop compatible
[x] Feature developed
[x] Created/updated unit tests
[x] Comments in code
[x] Documentation written

Coverage decreased (-2.5%) to 75.419% when pulling 117b882f86857df70d2f14b5f5a89fa7c54fe2dd on yomolify:master into 7cada79709a3c2ddfffda4204b34da2cb98a89ed on ModusCreateOrg:master.


search is not being done recursively if some results are found in the top level directory...it searches recursively if nothing is found on top level deirectory

I tried to go through the existing issue but didn't helped.
Thanks
Sahil

If i enable the "match case" property...search seems to be recursive by seeing the number of results, but ignore case property is surely have some issue.
Thanks

Can you check out this troubleshooting wiki to see if anything helps? https://github.com/Microsoft/vscode/wiki/Search-Issues
Also, can you give some more details about exactly what you are trying and what you see?


App Gateway Path-based Rule Redirect with Default Backend and Default HTTP Settings

This is autogenerated. Please review and update as needed.
Describe the bug
I am attempting to create a path-based rule with a url-path-map that has a default backend and http settings, but has a specific path redirect rule.  This is not possible from az cli.  When looking at the arm json, I should be able to specify the DefaultBackendAddressPool and DefaultHTTPSettings on the url-path-map, and then specify a RedirectConfiguration on a url-path-map-rule.  However, any combination of attempting to build this configuration within the available cli commands throws an error that it's not possible.
Command Name
az network application-gateway url-path-map update
Errors:
BadRequestError: UrlPathMap /subscriptions/<sub>/resourceGroups/<rg>/providers/Microsoft.Network/applicationGateways/<appGw>/urlPathMaps/<url-path-map> cannot specify DefaultBackendAddressPool when RedirectConfiguration is specified.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.
Create a url-path-map with the following information:

az network application-gateway url-path-map create --name {} --rule-name {} --paths {} --redirect-config {} --resource-group {} --gateway-name {}

This command sets a default redirect config.  It is not possible to add --default-address-pool or --default-http-settings when you specify --redirect-config.
Attempting to update it, does not work:

az network application-gateway url-path-map update --name {} --default-address-pool {} --default-http-settings {} --resource-group {} --gateway-name {}

Expected Behavior
You should be able to specify a DefaultBackendAddressPool and DefaultHTTPSettings in addition to a url-path-map-rule with redirect configuration from az cli - ideally from one create command if you only have one url-path-map-rule to create.
For example, the following command should work which send all requests by default to the backend with the http settings, except for those specified by the path rule, which are redirected.  This is possible from the UI, and is valid arm json.
az network application-gateway url-path-map create --name {} --rule-name {} --default-address-pool {} --default-http-settings {} --paths {} --redirect-config {} --resource-group {} --gateway-name {}
Environment Summary
Linux-4.19.128-microsoft-standard-x86_64-with-debian-bullseye-sid
Python 3.6.10
Installer: DEB

azure-cli 2.15.1 and 2.16.0

Additional Context

network

FYI, it appears to be an issue specifically with the --default flags for backend pool and http settings vs. non-default flags.  However, the --default-rewrite-rule-set and --rewrite-rule-set works as expected.

This restriction comes from the service API.


Indenting on

It would be nice if, after pressing <CR> and getting the list item written, pressing <Tab> just after that could indent the item.
This is an example:
Before     Input     After
----------------------------
- Item               - Item
- |        <Tab>         - |

thanks! also doing the opposite with <S-Tab> would be awesome

I just tried it and it works a little bit weird.
With this text and the cursor (the | character) on the second item
- Some item
- |

after pressing <Tab> the result is
- Some item
       |

with the item disappearing altogether and with 7 spaces indentation.
The expected behaviour should be (supposing that the user has shiftwidth=4)
- Some item
    - |

Ahahaha, no problem, I adamantly use tabs too in structured programming languages, but in things like Haskell, Erlang, LaTeX and Markdown I use spaces since the code tends to focus on beauty more than structure

Actually, I realized that a lot of users (me included) set the indentation in after/ftplugin, so on load I don't think the plugin could know the indentation each user uses. One workaround could be add a setup field for indentation style

What do you mean by setup field? My current idea is just to take it from expandtab and tabstop

That could be possible, but I'm not sure if the plugin would be able to get the user indentation level if it's set in after/ftplugin.
If that wasn't possible, then a solution could be add a parameter to the plugin with something like
use {
  'gaoDean/autolist.nvim',
  config = function () require 'autolist'.setup {
    style = 'spaces',
    depth = 2
  } end
}

Try first if it's possible to fetch the options defined by the user in after/ftplugin, if that's not possible then you can use that alternative.
Most users set the indentation on that directory because, since it gets executed after plugin initialization, it won't be modified

Sorry I haven’t fixed this, I’m currently busy working on another project right now. I’ll get back to you in a week or so.

@gaoDean no problem, there's no rush :wink:

@ignamartinoli alright, hopefully it works this time...

Hmm, I think this broke something for me:
E5108: Error executing lua ...te/pack/packer/start/autolist.nvim/lua/autolist/auto.lua:136: attempt to index field 'cmd' (a function value)
stack traceback:
        ...te/pack/packer/start/autolist.nvim/lua/autolist/auto.lua:136: in function 'indent'
        [string ":lua"]:1: in main chunk

It's working almost perfectly.
After using <Tab>, is added one space before the cursor and one after the cursor, like this:
-·Some·item¶
····-··|·¶

This should be the result:
-·Some·item¶
····-·|¶

It's almost done :D
space: ·
eol: ¶

Does this happen with c-t? Also, how did you fix the error from before? I'll test with expandtab once i get home.

@ignamartinoli Ok don't worry about answering the above questions, but it should work now for expandtab, at least for me.

@joeyschoblaska Perhaps try the newest version, see if that fixes things. If not, post the conditions/environment that made the issue happen here, also the version of neovim, Thanks.

@gaoDean you're gonna hate me hehe.
The space before the cursor is fixed, now there's only a trailing space inserted after the cursor that shouldn't be there:
-·Some·item¶
····-·|·¶
       ^

@joeyschoblaska Ohh, thanks for telling me. I should put that in the readme, but I'll test out feedkeys later, do you know if thats more supported in older versions?

I believe you can just use the original vim.cmd syntax:
vim.cmd.normal{"i" .. ctrl_t .. " ", bang = true}
-- becomes:
vim.cmd("normal! i" .. ctrl_t .. " ")

@joeyschoblaska @ignamartinoli okok all should be fixed, used nvim_feedkeys so lower versions of nvim should be supported, and the trailing space should be abolished...

Works great! Thanks for fixing this, and thanks for the great plugin :)

@gaoDean thanks! It works perfectly now
Congrats for the new feature and thanks for the awesome plugin :D


maven: 3.9.6 -> 3.9.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/maven/versions.
meta.description for maven is: Build automation tool (used primarily for Java projects)
meta.homepage for maven is: https://maven.apache.org/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.9.7 in filename of file in /nix/store/zglwhsmycivvh4wnxzhd5j49vw3i7lj1-apache-maven-3.9.7

Rebuild report (if merged into master) (click to expand)

39 total rebuild path(s)

39 package rebuild(s)

First fifty rebuilds by attrpath

apgdiff
bytecode-viewer
certificate-ripper
commafeed
cryptomator
digital
forge-mtg
gephi
global-platform-pro
h2
java-language-server
jd-cli
jetbrains.idea-community
jetbrains.idea-community-bin
jetbrains.idea-community-src
jetbrains.idea-ultimate
jetbrains.pycharm-community
jetbrains.pycharm-community-src
jnr-posix
jugglinglab
kotlin-interactive-shell
kotlin-language-server
ktfmt
lemminx
mariadb-connector-java
maven
maven3
microsoft-identity-broker
ns-usbloader
openrefine
quark-goldleaf
runelite
s3proxy
scenebuilder
schemaspy
slipstream
sonarlint-ls
tabula-java

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zglwhsmycivvh4wnxzhd5j49vw3i7lj1-apache-maven-3.9.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A maven https://github.com/r-ryantm/nixpkgs/archive/95c91915410c9391e03821634a5b459b8c8f15da.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/95c91915410c9391e03821634a5b459b8c8f15da#maven

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zglwhsmycivvh4wnxzhd5j49vw3i7lj1-apache-maven-3.9.7
ls -la /nix/store/zglwhsmycivvh4wnxzhd5j49vw3i7lj1-apache-maven-3.9.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 120m and timed out

Maintainer pings
cc @cko for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/maven/versions.
meta.description for maven is: Build automation tool (used primarily for Java projects)
meta.homepage for maven is: https://maven.apache.org/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.9.8 in filename of file in /nix/store/kvizw5wpdn8a267zl6gfcqjard9xqqnv-apache-maven-3.9.8

Rebuild report (if merged into master) (click to expand)

42 total rebuild path(s)

42 package rebuild(s)

First fifty rebuilds by attrpath

apgdiff
bytecode-viewer
certificate-ripper
commafeed
cryptomator
digital
forge-mtg
gephi
global-platform-pro
gol
h2
java-language-server
jd-cli
jetbrains.idea-community
jetbrains.idea-community-bin
jetbrains.idea-community-src
jetbrains.idea-ultimate
jetbrains.pycharm-community
jetbrains.pycharm-community-src
jnr-posix
joularjx
jugglinglab
kotlin-interactive-shell
kotlin-language-server
ktfmt
lemminx
mariadb-connector-java
maven
maven3
microsoft-identity-broker
ns-usbloader
openrefine
protege
quark-goldleaf
runelite
s3proxy
scenebuilder
schemaspy
slipstream
sonarlint-ls
tabula-java

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kvizw5wpdn8a267zl6gfcqjard9xqqnv-apache-maven-3.9.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A maven https://github.com/r-ryantm/nixpkgs/archive/7a918173802ce3df245d01e3011994e2403798e4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7a918173802ce3df245d01e3011994e2403798e4#maven

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kvizw5wpdn8a267zl6gfcqjard9xqqnv-apache-maven-3.9.8
ls -la /nix/store/kvizw5wpdn8a267zl6gfcqjard9xqqnv-apache-maven-3.9.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

13 packages failed to build:

commafeed
global-platform-pro
gol
h2
h2.doc
jd-cli
jetbrains.idea-community (jetbrains.idea-community-src)
jetbrains.pycharm-community (jetbrains.pycharm-community-src)
kotlin-interactive-shell
openrefine
runelite
slipstream
tabula-java

26 packages built:

apgdiff
bytecode-viewer
certificate-ripper
cryptomator
digital
forge-mtg
gephi
java-language-server
jetbrains.idea-community-bin
jetbrains.idea-ultimate
jnr-posix
joularjx
jugglinglab
kotlin-language-server
ktfmt
lemminx
mariadb-connector-java
maven
microsoft-identity-broker
ns-usbloader
protege
quark-goldleaf
s3proxy
scenebuilder
schemaspy
sonarlint-ls

Maintainer pings
cc @cko for testing.


missing directories should be cause for alarm

Describe the bug
bandit does not consider missing items to be a problem. That means that renaming a directory without adjusting the CI-scripts will take it off the radar with zero complaint. It will even "fix" all of your old security problems.
To Reproduce
tell bandit to scan a directory which does not exist.
bandit fnord
and it will tell you that everything is okay (exit-code 0).
while there is a mention of the problem, it is no cause for alarm:
Files skipped (1):
        fnord (No such file or directory)
...
 echo $?
0

Expected behavior
The test should fail with a non-zero exit-code. That will fail the CI and cause humans to look at the problem. Misconfigurations will be caught and corrected.
Bandit version

bandit 1.6.2
  python version = 3.6.9 (default, Nov  7 2019, 10:44:02) [GCC 8.3.0]

Additional context
Thanks for bandit :)

I agree, this should fail CI. Thanks for the issue @FreifunkerEZ


HIVE-24636: Memory leak due LogFactory retaining ClassLoaders

What changes were proposed in this pull request?
When a class loader is being closed, it should also be released from the org.apache.commons.logging.LogFactory#factories, where it is being used as a key.
Why are the changes needed?
Current implementation has a slow but steady memory leak.
Does this PR introduce any user-facing change?
No
How was this patch tested?

closing due to CI issues, will open completely new PR

closing due to CI issues, will open completely new PR


Restructure the project

Related to #537.
I propose the following structure:
github.com/limetext/
	lime-backend/
		lib/ - currently backend/
		packages/ - submodule of lime-packages
		tasks/ - submodule of lime-tasks
	lime-qml/
		main/ - currently frontend/qml/
		packages/ - submodule of lime-packages
		tasks/ - submodule of lime-tasks
	lime-html/
		main/ - currently frontend/html/
		packages/ - submodule of lime-packages
		tasks/ - submodule of lime-tasks
	lime-termbox/
		main/ - currently frontend/termbox/
		packages/ - submodule of lime-packages
		tasks/ - submodule of lime-tasks
	lime-packages/ - currently packages/
	lime-tasks/ - currently tasks/
	lime/ - left as an archive

We should also try to preserve history using git subtree or git filter-branch for proper attribution and change history.
I'll do the work to make this happen, but is this a good structure to go with?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12073228-restructure-the-project?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).

why we need lime-packages in backend?
IMHO we can remove the main folder in frontends, lib in backend and just start the code in root folder
not completely related to this but I think its better use make file to for building testing and etc

We currently need the packages in the the backend for the tests.
I put the subfolders in so you can run go test github.com/limetext/lime-backend/lib/... without hitting errors due to there being other files in the root that aren't being tested (e.g. GoSublime). Try running go test github.com/limetext/lime/... to see what I mean.

I see, but there are just few tests relying on them and they should use testdata folder imo also this removes the go test github.com/limetext/lime-backend/lib/... problem for backend repo at least.

You also get errors like this:
tasks/build/gen_loaders.go:24: main redeclared in this block
	previous declaration at tasks/build/fix.go:68
tasks/build/gen_python_api.go:394: main redeclared in this block
	previous declaration at tasks/build/gen_loaders.go:24

At least if we have a subdirectory, we're able to later include files that might be problematic in the root, without having to move everything around. There's also an neatness to having a relatively empty root directory, IMO.

Having said that, I'm not strongly swayed against having it in the root if we can avoid import, build and testing issues.

I had some time, so I did the work to split out the projects as I described above. I didn't bother preserving the commit history, since it would have been a lot of hard work for little gain (as long as this project remains around).

History would be nice, but I'm ok with referencing the fork-point in the commit message as was done. History could be added in the future if anyone is feeling masochistic enough (IIRC I hacked it for the limetext/text repo via filter-branch and lots of trial'n'error), or if someone happens to be a git expert and knows of a simple and straight-forward way to do it.

I started trying to filter out the history, but realised that it would be
unreliable due to files moving around, and I couldn't work out how to
follow moves sensibly. Google didn't reveal any nice way of doing it,
either.
On Sun, 26 Apr 2015 14:53 Fredrik Ehnbom<EMAIL_ADDRESS>wrote:

History would be nice, but I'm ok with referencing the fork-point in the
commit message as was done. History could be added in the future if anyone
is feeling masochistic enough (IIRC I hacked it for the limetext/text repo
via filter-branch and lots of trial'n'error), or if someone happens to be a
git expert and knows of a simple and straight-forward way to do it.
—
Reply to this email directly or view it on GitHub
https://github.com/limetext/lime/issues/546#issuecomment-96382601.

FWIW I tried to get history working and re-pushed the lime-backend repo (twice...). Github still doesn't follow renames, but for example git log --follow lib/view.go does so atleast we have that now

Nice.


KafkaSource is overriding my original kafka message cloud event type

Describe the bug
A clear and concise description of what the bug is.
I have messages in kafka following cloud event spec. Following is the original header values in topic:
ce_datacontenttype: application/json, ce_entityType: TENANT_ENTITY, ce_group: d008cc77-c3b0-4a94-8e6e-b5649ca7e8d7, ce_id: 98a9f24e-d36b-449f-96a8-6ab675e613b4, ce_source: mdm-instance-payload-out, ce_specversion: 1.0, ce_subject: instance-payload-message, ce_tenant: d008cc77-c3b0-4a94-8e6e-b5649ca7e8d7, ce_time: 2023-01-19T22:30:24.860213GMT, ce_type: Credentialing.WorkFlow.CREATE, content-type: application/json
But when I got message in my function, it throws error like below:
2023-01-20 00:34:07,645 ERROR [io.qua.funqy] (executor-thread-0) Couldn't map CloudEvent type: 'dev.knative.kafka.event' to a function.
Looks like kafka source is overriding my original ce-type to be dev.knative.kafka.event.  This behaviour also cause my broker and trigger filtering function not working.
Expected behavior
A clear and concise description of what you expected to happen.
The original cloud event attributes should be used for calling function.
To Reproduce
Steps to reproduce the behavior.
Knative release version
Additional context
Add any other context about the problem here such as proposed priority

Thanks for reporting @xqianwang, would you mind sharing how did you install KafkaSource? there are multiple implementations of the KafkaSource API, so knowing which one you're using might help identifying the problem

Hi @pierDipi ,  thank you for replying me.
`apiVersion: sources.knative.dev/v1beta1
kind: KafkaSource
metadata:
name: instance-payload-source
spec:
consumerGroup: event-processor-group
bootstrapServers:

xx-public.xxxxx.xxxxxx.xxx.kafka.us-east-1.amazonaws.com:9196
xx-public.xxxxx.xxxxxx.xxx.kafka.us-east-1.amazonaws.com:9196
xx-public.xxxxx.xxxxxx.xxx.kafka.us-east-1.amazonaws.com:9196
topics:
demo
sink:
ref:
apiVersion: eventing.knative.dev/v1
kind: Broker
name: kafka-broker
net:
sasl:
enable: true
user:
secretKeyRef:
name: secret
key: user
password:
secretKeyRef:
name: secret
key: password
type:
secretKeyRef:
name: secret
key: sasl.mechanism
tls:
enable: true
`
This is how I created it.

Would you mind sharing how did you send records to Kafka and how it looks like?

Please check the attached pic for kafka record.

And I send Kafka message using Quarkus smallrye kafka cloudevent extention https://quarkus.io/blog/kafka-cloud-events/

@xqianwang, I think the problem is that the record is not a properly formatted CloudEvent, because, for example, the 2 time value: 2023-01-19T22:30:24.860213GMT or 2023-01-23T12:23:11.65224America/Toronto are not following https://www.rfc-editor.org/rfc/rfc3339 since the spec requires that RFC (https://github.com/cloudevents/spec/blob/main/cloudevents/spec.md#type-system) for timestamps

would mind sharing Quarkus code you used to create the CloudEvent, in particular, the time part?

FYI @cescoffier

I would be surprised that the connector does not do the right thing for dates. If that's the case, please open an issue on Smallrye reactive messaging.

Actually it's my code that generate the date which is not following the proper format. I will change the code and see if it will fix the issue that I saw. Thank you!

@cescoffier  Actually I think the connector does not do right thing for ZonedDateTime
This is how I generate kafka message:
OutgoingCloudEventMetadataBuilder builder = OutgoingCloudEventMetadata.builder()
                .withId(id)
                .withType(type)
                .withSource(URI.create(DEFAULT_PAYLOAD_SOURCE))
                .withSubject(DEFAULT_PAYLOAD_SUBJECT)
                .withTimestamp(ZonedDateTime.now())
                .withDataContentType(MediaType.APPLICATION_JSON);
        if (instance.getGroupId() != null) {
            builder.withExtension(GROUP_ATTRIBUTE, instance.getGroupId().toString());
        }
        if (instance.getTenantId() != null) {
            builder.withExtension(TENANT_ATTRIBUTE, instance.getTenantId().toString());
        }
        if (context != null && !Strings.isNullOrEmpty(context.get(ENTITY_TYPE_ATTRIBUTE))) {
            builder.withExtension(ENTITY_TYPE_ATTRIBUTE, context.get(ENTITY_TYPE_ATTRIBUTE));
        }
        return Message.of(payload).addMetadata(builder.build());

Please open an issue on Smallrye reactive messaging with a reproducer. We
will have a look.
On Tue 24 Jan 2023 at 22:08, Xueqian Wang @.***> wrote:

@cescoffier https://github.com/cescoffier Actually I think the
connector does not do right thing for ZonedDateTime
This is how I generate kafka message:
OutgoingCloudEventMetadataBuilder builder = OutgoingCloudEventMetadata.builder()
.withId(id)
.withType(type)
.withSource(URI.create(DEFAULT_PAYLOAD_SOURCE))
.withSubject(DEFAULT_PAYLOAD_SUBJECT)
.withTimestamp(ZonedDateTime.now())
.withDataContentType(MediaType.APPLICATION_JSON);
if (instance.getGroupId() != null) {
builder.withExtension(GROUP_ATTRIBUTE, instance.getGroupId().toString());
}
if (instance.getTenantId() != null) {
builder.withExtension(TENANT_ATTRIBUTE, instance.getTenantId().toString());
}
if (context != null && !Strings.isNullOrEmpty(context.get(ENTITY_TYPE_ATTRIBUTE))) {
builder.withExtension(ENTITY_TYPE_ATTRIBUTE, context.get(ENTITY_TYPE_ATTRIBUTE));
}
return Message.of(payload).addMetadata(builder.build());
—
Reply to this email directly, view it on GitHub
https://github.com/knative-sandbox/eventing-kafka/issues/1285#issuecomment-1402667024,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADCG7OQYZ7OOTENH7L77Y3WUBAEVANCNFSM6AAAAAAUA76U7U
.
You are receiving this because you were mentioned.Message ID:
@.***>

@xqianwang I'm closing this issue, it'd be great if you can provide a link to the Smallrye issue for other users running in the same issue


Standardization semicolon after comment bug

The current standardized asm file has a bug where the semicolon is after the comment (comments start with a # in GAS).
There are two possible fixes.

Put the semicolon directly after the instruction so.
mov 0x2fd9(%rip) , %rax # __gmon_start__@Base ;
be
Entirely remove the optional semicolon from standardization all together.

Sorry I typoed and pressed Enter :face_with_head_bandage: .
Here is the full issue:
The current standardized asm file has a bug where the semicolon is after the comment (comments start with a # in GAS).
There are two possible fixes.

Put the semicolon directly after the instruction so.
mov 0x2fd9(%rip) , %rax # gmon_start@Base ;
becomes:
mov 0x2fd9(%rip) , %rax ; # gmon_start@Base
Entirely remove the optional semicolon from standardization all together.


Fail tests on runtime exceptions

This PR resolves #1314.
Potential breaking change for tests
From now on the BlackBox tests are gonna be failed if some signal handler failed in the background. Such a change is desired while it eliminates potential untested erroneous flows.
FailedHandlerGuard
The new FailedHandlerGuard is responsible for tracking HandlerFailedUnexpectedly events and fail the tests as soon as such an event occurs. The guard can be configured to tolerate such handler failures and simply log the failure over failing a test.
The BBC users can use tolerateFailures method to configure the guard accordingly and fall back to the previous behavior.

@alexander-yevsyukov @dmdashenkov PTAL.

@alexander-yevsyukov PTAL again.

@yuri-sergiichuk, LGTM as long as build passes.


Add package-lock.json

This is an artefact of npm 5+, which is an equivalent of the Gemfile.lock in Ruby-land, in that it captures the exact versions (with a version number and a hash for integrity checking) of all
sub-dependencies.
It’s recommended that this is checked in to source control, so that you can be sure that the exact same dependencies are used by all users (e.g. developers, continuous integration servers, staging, production, etc).
See http://blog.npmjs.org/post/161081169345/v500 for details.

@tvararu I just noticed that https://github.com/alphagov/govuk_elements has a yarn.lock, suggesting that it’s using yarn rather than npm for dependency management. I don't think there’s much of a difference now (since npm 5+ added its own lockfile format with integrity hash), but perhaps it’s worth being consistent? I think Yarn is marginally faster still, but I guess npm has the advantage of being the default.

Hi @frankieroberto @tvararu, govuk-elements is only using Yarn in attempt to speed up builds using Travis CI. We've been using a package-lock.json file for govuk-frontend (which will replace govuk-elements in the future). I'd be inclined to stick with npm, I'll raise an issue to replace the Yarn lockfile with npm's package-lock.json file for govuk-elements, I agree they should be consistent.

@gemmaleigh cool – I think you should see similar build speeds if you switch Travis to use npm5 instead of yarn.
I'm still getting my head around the dependencies between elements, toolkit and templates, which has confused me no end, so it's good to hear about govuk-frontend. Hopefully that'll help!

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this.


Upgrade cs2-lib

The newer version of cs2-lib had a lot of refactoring and changes for stickers & patches. This PR contains the code changes for supporting it.

Hello! I have question how can i integrated with cs2 server ?

Hello! I have question how can i integrated with cs2 server ?

Not really the place to have this conversation, but look at my other repos and the API documentation.

also did you try any server ?

also did you try any server ?

Please use the "Discussions" tab if you have any questions related to the app, but we assume you have some technical knowledge if you are asking questions, so don't expect an answer for stuff unrelated to the project.


Port Param has no Effect

Hi,
I'm running vulcand outside a container and maybe this bug has not been reported yet.
The -port= param does not have any effect.
If I start vulcand with it, it will still listen on port 8181 (ipv4) and  8182 (ipv6).
thanks

Works for me!
I've compiled vulcand from latest commit, run like so:
 ./vulcand -port=8000 -etcd=http://<IP_ADDRESS>:4001

I can see it is listening on the specified port:
$ netstat -anp
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:37006       xxx.xxx.xxx.176:4001     ESTABLISHED 10/vulcand
tcp        0      0 <IP_ADDRESS>:43728       <IP_ADDRESS>:4001        ESTABLISHED 10/vulcand
tcp        0      0 :::8182                 :::*                    LISTEN      10/vulcand
tcp        0      0 :::8000                 :::*                    LISTEN      10/vulcand

What version of Vulcand are you using, and what are your exact command line arguments?

Hi thanks!
I'm using the latest release v0.8.0-beta.2.
The commandline is:
./vulcand -interface=xxx -etcd=http://<IP_ADDRESS>:2379 http://<IP_ADDRESS>:2379 -port=80 --logSeverity=INFO
--> works not!
Now I found out, it works when moving the port=xxx param more to the bginning:
./vulcand -interface=xxx -port=80 -etcd=http://<IP_ADDRESS>:2379 http://<IP_ADDRESS>:2379  --logSeverity=INFO
--> works!
So obviously a problem with command line parsing.

Ah, that explains it. The way you are defining etcd is messing up the command-line arguments. AFAIK any argument that has multiple values must be either listed multiple times e.g.:
-etcd=http://<IP_ADDRESS>:2379 -etcd=http://<IP_ADDRESS>:2379

or once, with multiple values separated by a comma:
-etcd=http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379

Because you are using a space, the command arguments are getting messed up, causing -port not to be read properly.

Yea, tat's it :) Just verified it. To make things celarer, let's address this

the comma seperated variant does not work

Sorry, you are right - looks like only the first way is valid.


Change the colour of the button

Checked other resources

[x] added a very descriptive title to this issue.
[x] searched the greatbuilder documentation with the integrated search.
[x] used the GitHub search to find a similar question and didn't find it.

Issue Image (if any)

Description
Change the colour of the button to make it more visible
System Info
Windows 11
npm 10.2.3
node 20.10.0
Related Component

[ ] Deployment
[x] Nextjs
[ ] LLMs
[ ] Langchain
[ ] Rust
[ ] Python

Pr #15 resolved it.


more inlining of delegates

Cool stuff.
Still I can't help but wonder - why const? Mutable will do just fine b/c in D mutable == thread-local so we can be relatively certain that whatever was initialized recently and never written to can be copy-propagated and inlined. In C++ that wouldn't work because there might be some other references to that object.

Also - would it make sense to factor out data-flow primitives or is it too early for that?

I plan to enhance onlyOneAssign() to check for the cases listed in the comment for it. That'll do most of what data flow analysis would. const is done first because it doesn't need data flow analysis to prove single assignment.

Auto-merge toggled on

Nitpick: Tabs in tests.


Feat move testing

:tada: This PR is included in version 8.0.0-beta.5 :tada:
The release is available on:

v8.0.0-beta.5
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 8.0.0 :tada:
The release is available on:

v8.0.0
GitHub release

Your semantic-release bot :package::rocket:


auto deploy docs

Specific Demand
Deploying docs (both docs.rs and our guide/book) is really tedious right now. I would love to have some CI/CD setup that builds docs when the docs folder changes and then deploys a new version to our docsite repo.
We could then save a history of docs for each version of Dioxus (IE docs for 0.1.6, 0.1.7, 0.1.8, 0.2.0) as well as always have the most recent nightly version of the docs up to date.

so we cannot deploy all archived version document?

I propose to create a new documentation repo in dioxuslabs. There would be these branches:

master: we push all new docs
next: here we sync with master when we feel it is ok (we select next branch and then click on fetch upstream)
all historic branches we shouldn't update (except we forgot something) like v0.1.6, v0.1.7, v0.1.8 or v0.2.0

We would do like this:
#  when new release has been published
git branch v0.2.0
git checkout v0.2.0
git rebase v0.2.0 next # here we have v0.2.0 == next

It would look like: master >> next >> new release version branch

I propose to create a new documentation repo in dioxuslabs. There would be these branches:

master: we push all new docs
next: here we sync with master when we feel it is ok (we select next branch and then click on fetch upstream)
all historic branches we shouldn't update (except we forgot something) like v0.1.6, v0.1.7, v0.1.8 or v0.2.0

We would do like this:
#  when new release has been published, like v0.2.0 for instance
git branch v0.2.0
git checkout v0.2.0
git rebase v0.2.0 next # here we have v0.2.0 == next

It would look like: master > next > new release version branch when published

I think this is a great way to proceed!
I've made the documentation repo and opened it up for editing.
https://github.com/DioxusLabs/docs

Docs are autodeploying to the doc site repo now! We just need hooks for releases and this should be finished.


Notification Reply without bringing app to foreground

Is it possible to keep app in background after a user reply via notification?
Edit:
I'm trying to create chat app like whatsapp where user can reply from notification. It would be good to handle that reply in background.
Also, How to handle that notification reply?

Unfortunately is not possible, because flutter works mainly over dart, and to deal with this reply in background you need to handle it and do everything in native layer.
Also, on iOS background process are very limited. Even creating a method similar to firebase's onBackgroundHandle method, i cannot ensure its execution all the times.

Interesting.   It worked for me on my galaxy s10 but haven't checked an
iPhone or other android devices yet.  I will try to record from my device.
Not testing on a simulator or emulator.
On Fri, May 28, 2021, 6:11 PM rafaelsetragni @.***>
wrote:

Unfortunately is not possible, because flutter works mainly over dart, and
to deal with this reply in background you need to handle it and do
everything in native layer.
Also, on iOS background process are very limited. Even creating a method
similar to firebase's onBackgroundHandle method, i cannot ensure its
execution all the times.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rafaelsetragni/awesome_notifications/issues/171#issuecomment-850699491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACLYRRS2XAXGE66RS4HONGTTQAIJNANCNFSM445W4SIQ
.

Unfortunately is not possible, because flutter works mainly over dart, and to deal with this reply in background you need to handle it and do everything in native layer.
Also, on iOS background process are very limited. Even creating a method similar to firebase's onBackgroundHandle method, i cannot ensure its execution all the times.

Doesn't flutter support background processes now? It would be nice if we could pass a callback function to be executed when the user interacts with the notification and run that code on background instead of bringing the app to foreground just to perform "simple" actions.

Local Notifications  used to be able to handle this, so I'm guessing it's still possible?  Am trying to see what I can learn about how it's done, but I'm no expert in Swift/Android background processes.

Im working on it right now on Notification's isolates git branch.

Hi! Sorry for taking so long to respond to your issue on GitHub. I was focused on releasing the new 0.7.0 version of awesome_notifications and awesome_notifications_fcm and i didn't had time enough to do both. But now I can answer all your questions.
So now i'm asking you to recreate this topic using the new issue template. There's a lot of missing informations that i need to understand your problem, and all the instructions are already in the new issue template. Also, remember to check beforehand if your issue was posted by another user.
So I will automatically close all previous issues so far.
Sorry for the inconvenience and i will be waiting for your new issue request.
Thank you so much for your support!


Added support for publishing NS records + official test vector 2 compliance

Added support for publishing NS records and fixed bugs to achieve official test vector 2 compliance.
Removed kid in DNS records according to DID DHT spec update.
Minor renaming.
QoL - Updated CODEOWNERS to further increase review efficiency.
QoL - Added HTML code coverage output for immediate coverage feedback.

Codecov Report
Attention: Patch coverage is 95.38462% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.83%. Comparing base (1d59f71) to head (5a034c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   90.81%   90.83%   +0.01%
==========================================
  Files         116      116
  Lines       29442    29478      +36
  Branches     2156     2159       +3
==========================================
+ Hits        26739    26776      +37
+ Misses       2668     2667       -1
  Partials       35       35

Components
Coverage Δ

agent
79.90% <ø> (ø)

api
97.92% <ø> (ø)

common
98.68% <ø> (ø)

credentials
95.26% <ø> (ø)

crypto
93.81% <ø> (ø)

dids
97.69% <95.38%> (+0.03%)
:arrow_up:

identity-agent
96.70% <ø> (ø)

crypto-aws-kms
100.00% <ø> (ø)

proxy-agent
96.70% <ø> (ø)

user-agent
96.70% <ø> (ø)


Do filtering and pagination of domains on dashboard server-side.

Like #206, loading and rendering the full list of domains takes quite some time when you have a lot of them. I've changed the code to do the filtering and pagination server-side (leveraging DataTables ajax data source), which works a lot smoother.

Nice feature! Merged into my fork, based on official repo latest code, but I'm getting some errors:
dnsadmin_1  | [2017-09-04 12:33:07,525] ERROR in app: Exception on /dashboard-domains [GET]
pdnsadmin_1  | Traceback (most recent call last):
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
pdnsadmin_1  |     response = self.full_dispatch_request()
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
pdnsadmin_1  |     rv = self.handle_user_exception(e)
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
pdnsadmin_1  |     reraise(exc_type, exc_value, tb)
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
pdnsadmin_1  |     rv = self.dispatch_request()
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
pdnsadmin_1  |     return self.view_functions[rule.endpoint](**req.view_args)
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask_login/utils.py", line 228, in decorated_view
pdnsadmin_1  |     return func(*args, **kwargs)
pdnsadmin_1  |   File "/opt/pdnsadmin/app/views.py", line 297, in dashboard_domains
pdnsadmin_1  |     template = app.jinja_env.get_template("dashboard_domain.html")
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/jinja2/environment.py", line 830, in get_template
pdnsadmin_1  |     return self._load_template(name, self.make_globals(globals))
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/jinja2/environment.py", line 804, in _load_template
pdnsadmin_1  |     template = self.loader.load(self, name, globals)
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/jinja2/loaders.py", line 113, in load
pdnsadmin_1  |     source, filename, uptodate = self.get_source(environment, name)
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/templating.py", line 57, in get_source
pdnsadmin_1  |     return self._get_source_fast(environment, template)
pdnsadmin_1  |   File "/opt/pdnsadmin/flask/local/lib/python2.7/site-packages/flask/templating.py", line 85, in _get_source_fast
pdnsadmin_1  |     raise TemplateNotFound(template)
pdnsadmin_1  | TemplateNotFound: dashboard_domain.html

And an additional error dialog:
DataTables warning: table id=tbl_domain_list - Ajax error. For more information about this error, please see http://datatables.net/tn/7

Am I doing anything wrong?

Hmm, looks like I forgot to add the dashboard_domain.html template...

Thanks so much, my PdnsAdmin is now much faster!

This seems to be better solution than #206. I merged it to developement branch. Waiting to merge to master after refactoring the code.
Thanks for your contribution!

wouldn't a good solution to this problem be to dump the full list of domains from the dashboard and instead have a domain search box in there instead, that'll then make one request to the pdns api on input and return results based on the search criteria to select from - possibly returning just one zone result if the full domain is typed (more if they match the search string, ie TLD not input). Then have the full list of domains as either an option or a new menu item?


feat: add multi resolver to connectivity test for both tcp and dns

This model can be used to plug in other kinds of resolvers in the future including geneva based ones.

@fortuna is there anything else in this PR that needs to be done?

Obsoleted by https://github.com/Jigsaw-Code/outline-sdk/pull/141 and upcoming PRs based on https://github.com/Jigsaw-Code/outline-sdk/tree/fortuna-dns.


Support FLOAT32 type in Spanner

Adds support for the newly added FLOAT32 type in Google Cloud Spanner.
Since FLOAT was already mapped to FLOAT64, this change modifies the existing mapping to FLOAT -> FLOAT32 instead.
Addresses #30700.
Please ignore the commit bumping the BOM version to 26.36.0. This is already being done as part of #30868

assign set of reviewers
(The single failure is due to a socket timeout, which seems flaky as it wasn't there in the previous run; I'll anyway rerun the tests by rebasing on HEAD)

LGTM


Turning off tamper alert using TTLock.setLockConfig -> TTLockConfig.tamperAlert doesn't work

Hello @ttlock Team,
We're facing following issue on TTLock.setLockConfig

Sequence of operations:

Firstly, I called TTLock.setLockConfig. This gave success callback

TTLock.setLockConfig(TTLockConfig.tamperAlert, false, lockData, () {
  _showSuccessAndDismiss("Success");
}, (errorCode, errorMsg) {
  _showErrorAndDismiss(errorCode, errorMsg);
});

Then, called TTLock.getLockConfig. Success Callback returned tamperAlert is still ON. Also on Lock Tamper Alert still ON (After trying 5 consecutive invalid passcodes on lock)

TTLock.getLockConfig(TTLockConfig.tamperAlert, lockData, (isOn) {
  _showSuccessAndDismiss("SwitchOn: $isOn");
}, (errorCode, errorMsg) {
  _showErrorAndDismiss(errorCode, errorMsg);
});

Similar behaviour with TTLockConfig.resetButton

Hello,
Can anyone point me to the documentation for how following TTlockConfigs work?

TTLockConfig.freeze
TTLockConfig.passcodeVisible
TTLockConfig.privacyLock

I've checked on https://open.ttlock.com/doc/
But was not able to find
Thanks in advance!

Thank you for your feedback.We have fixed this bug and will release a new version in a few days.

Hello @ttlock,
After trying the fix from commit update ttlock.dart, the above problem is solved but the tamper Alert on the Lock remains unaffected.
For Eg. if I turn off tamper Alert using TTLock.setLockConfig and get the tamper Alert state using TTLock.getLockConfig, the tamper Alert state shows OFF.
But on Lock it remains ON. (i.e if I try to enter invalid passcode 5 times tamper Alert is still triggered)

Hello @ttlock team,
We have been facing the above issue even after upgrading to ttlock_flutter: ^0.0.8

TamperAlert is only for force destroy lock.It doesn't matter with the  warning tone.


Syntax highlighting

Looks broken again

The Jekyll site needs to be built locally to get highlighting working. If this gets tedious I should look into gist embedding

The Jekyll site needs to be built locally to get highlighting working. If this gets tedious I should look into gist embedding.


DO NOT MERGE - POC/playwright

POC
The goal of this work is to set up playwright with our monorepo and play around with it, so we can determine if creating an indexedDb plugin for it would be helpful.
DO NOT MERGE

The follow-up work is tracked in #150


Save settings for each “toy”

Is your feature request related to a problem? Please describe.
Some of the tools have some options on the top. I would like it if there were a way to save settings for each tool. For example, I would always want to set the JSON formatter to use 4 spaces, but the default is 2 and it is not saved when I restart the app.
Describe the solution you'd like
I am thinking there could be a Set defaults button below the configuration.
Describe alternatives you've considered
Alternatively, you could just save the configuration automatically, but this could be annoying if you usually use one setting but need another just once.
Additional context

Low quality mockup

Hello,
The set button is definitely a good idea. Thank you for the request. We would need to find the best place for it.
For the the save auto, it could be annoying if for a specific case you need to adjust the settings of a toy. Maybe we can look to add a section or button in the app settings to save all the "toys" settings at the same time.

I'm wondering: how often does a user need to change the settings, and how often does a user would like to keep them the way they are after restarting the app?
While I don't have data to answer these questions, I'm thinking that in a first implementation, just persisting the settings the way they are when closing the app is probably enough.
Thoughts?

Thanks again @BreeceW for your suggestion :) I've been with the alternative solution for now. It will be part of the next release.