Issue: docker-compose error for freecodecamp service

Describe the bug
docker-compose not working for the web app
To Reproduce
Run docker-compose run --rm freecodecamp npm run only-once
Expected behavior
Container to be created for freecodecamp_freecodecamp_1
Screenshots

The docker setup is outdated with the recent changes towards making the repo a mono repo. Pull request welcome.

@mmeyers00 @ahmadabdolsaheb, did that merge fix this? If so, we can close this.

Nope. As I mentioned in the PR, its unrelated to this.

We have a docker installation guide that is now quite stable. Closing.


Find the bug that causes a non-symmetrical result after iterating

[x] Verify that it does not lie in the geometrical definition of the corner_points, aerodnamic_centers, chords or any of that sort
[x] Check filament geometry
[x] Check more code things?
[x] Compare to a similar case in the original code?

Added a check symmetry function


Figma URL

It is always saying a invalid URL even I just paste a URL from my figma file

Same issue here, was just questioning my sanity and dissecting the cli.py from the library installation dir itself to make sure it wasn't me. The problem seems to be the regex here:
 match = re.search(r'https://www.figma.com/file/([0-9A-Za-z]+)', args.file_url)
Not a single Share link from anywhere within Figma's web app includes a /file/ directory in the URL path. I even tried sharing the whole Team and tried Dev Mode, republishing, moved the file, left it Untitled and outside my Project folder, tried the links from Drafts, published to Community then tried the three ways to share it, and several other jackass ideas in order to get a link with /file/ in the URL. No dice.
Maybe Figma just changed their link sharing schema? Certainly this project has been working until now, right? If I could get it to at least parse my input and run for debugging I'd link that, but here's the stdout Traceback at least (personal non-essential data removed obviously):
Traceback (most recent call last):   File "/tkdesigner", line 8, in <module>     sys.exit(main())              ^^^^^^   File "<wooptywooowoo>.../tkdesigner/lib/python3.12/site-packages/tkdesigner/cli.py", line 51, in main     raise ValueError("Invalid file URL.") ValueError: Invalid file URL.


transactionSignRaw doesn't work (Emergency Look Please)

I'm working on  offline-signing (raw signing): Steps I did are like below, but I could not send a transaction. Please help. It is emergency.
URL: https://api.node.glif.io
I have a token from lotus deamon

const message = {
"Version": 0,
"To": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"From": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"Nonce": 0,
"Value": "100000",
"GasPrice": "190464106",
"GasLimit": 25000,
"Method": 0,
"GasPremium": '1',
"GasFeeCap": '190464106',
"Params": ""
};
1- const cbor = await signer.transactionSerialize(message);
2- const message = await signer.transactionParse(cbor, false);
3- let signature =  signer.transactionSignRaw(message, privatekey.toString('hex'));
4- signature = Buffer.from(signature)
5- let message_digest1 = getDigest(Buffer.from(cbor, 'hex'));
6- const bufer =Buffer.from(publickey, 'hex')
7- const unit8arrayformatofpublickey = new Uint8Array(bufer);
8- const value = secp256k1.ecdsaVerify(signature.slice(0, -1), message_digest1, unit8arrayformatofpublickey)
9- const hexSignature = signature.toString('hex');
10- const signedMessage = {
Message: message,
Signature: {
Data: hexSignature.toString("base64"),
Type: 1,
}
};
11- let response = await axios.post(URL, {
"jsonrpc": "2.0",
"method": "Filecoin.MpoolPush",
"id": 1,
"params": [signedMessage]
}, { headers }).catch((e: any) => { console.error(e.message) });
The error is
(node:18116) UnhandledPromiseRejectionWarning: Error: No to address provided
    at Object.typeCheck (C:\Users\user\Desktop\server\src\utils.ts:7:28)
    at txCreate (C:\Users\user\Desktop\server\src\server.ts:78:5)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at main (C:\Users\user\Desktop\server\src\server.ts:124:3)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:18116) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:18116) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Request failed with status code 503
(node:18116) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'data' of undefined
    at txCreate (C:\Users\user\Desktop\server\src\server.ts:120:44)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at main (C:\Users\user\Desktop\server\src\server.ts:124:3)
(node:18116) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)

Try using transactionSignLotus instead (see https://github.com/Zondax/filecoin-signing-tools/blob/master/docs/wasm_api.md#transactionsignlotus-support-lotus-schema).
And I don't think your signature is base64 encoded if I am not mistaken lotus only accept base64.

My requironment is: Sign a message with some parameters offline. For doing
this I need to use transactionSignRaw, I need to serialize  my message.
Something goes bad so I can not send a transaction.
On Tue, Aug 17, 2021 at 6:25 AM Lola Dam @.***> wrote:

Try using transactionSignLotus instead (see
https://github.com/Zondax/filecoin-signing-tools/blob/master/docs/wasm_api.md#transactionsignlotus-support-lotus-schema
).
And I don't think your signature is base64 encoded if I am not mistaken
lotus only accept base64.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Zondax/filecoin-signing-tools/issues/405#issuecomment-900297011,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHTYPJWLF4WVQ4OW2K4XYVTT5JPOPANCNFSM5CJKD7GQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

transactionSignLotus it is an offline function. It just format the response in a proper json so it can be send to a Lotus node directly.
Also your encoding of the signature looks incorrect. You should try using transactionSignLotus and compare against you current result. You will see the difference.

So how can I solve this problem?
How can I encode in the correct format?
Please give me the solution. Suppose there is a message that should be
encoded, which steps and methods should be there?
Thank you
On Wed, Aug 18, 2021 at 5:16 AM Lola Dam @.***> wrote:

transactionSignLotus it is an offline function. It just format the
response in a proper json so it can be send to a Lotus node directly.
Also your encoding of the signature looks incorrect. You should try using
transactionSignLotus and compare against you current result. You will see
the difference.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Zondax/filecoin-signing-tools/issues/405#issuecomment-901064098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHTYPJTWIS6BMBVKPZVXQ3TT5OQBFANCNFSM5CJKD7GQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

It should be encoded in base64 and your private key too.
const message = {
"Version": 0,
"To": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"From": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"Nonce": 0,
"Value": "100000",
"GasPrice": "190464106",
"GasLimit": 25000,
"Method": 0,
"GasPremium": '1',
"GasFeeCap": '190464106',
"Params": ""
};

const cbor = await signer.transactionSerialize(message);
const message = await signer.transactionParse(cbor, false);
// Your private key should base64 encoded
let signature = signer.transactionSignRaw(message, privatekey.toString('base64'));
signature = Buffer.from(signature)
let message_digest1 = getDigest(Buffer.from(cbor, 'hex'));
const bufer = Buffer.from(publickey, 'hex')
const unit8arrayformatofpublickey = new Uint8Array(bufer);
const value = secp256k1.ecdsaVerify(signature.slice(0, -1), message_digest1, unit8arrayformatofpublickey)
// Your signed message `Data` field should be base64 encode (in your screenshot it is a hex string).
const signedMessage = {
Message: message,
Signature: {
Data: signature.toString("base64"),
Type: 1,
}
};
let response = await axios.post(URL, {
"jsonrpc": "2.0",
"method": "Filecoin.MpoolPush",
"id": 1,
"params": [signedMessage]
}, { headers }).catch((e: any) => { console.error(e.message) });

Please note that I haven't tested the code. I let you do it.
You can also try using transactionSignLotus it is offline and will fill your requirements. Just so you can compare the result and help you debug.
const message = {
"Version": 0,
"To": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"From": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"Nonce": 0,
"Value": "100000",
"GasPrice": "190464106",
"GasLimit": 25000,
"Method": 0,
"GasPremium": '1',
"GasFeeCap": '190464106',
"Params": ""
};

// It is an offline function.
let signedMessage = signer.transactionSignLotus(message, privatekey.toString('base64'));
console.log(signedMessage)

let response = await axios.post(URL, {
"jsonrpc": "2.0",
"method": "Filecoin.MpoolPush",
"id": 1,
"params": [signedMessage]
}, { headers }).catch((e: any) => { console.error(e.message) });

It is odd, please take a look at the code below: It is very simple but
didn't create a transaction and transfer money. I don't know what I can do.
I put in a lot of effort and spent much time, but without any result. My
manager is angry with me. Please run this code and let me know what is
wrong. I can not find it. You are familiar with this library. Thank you
"use strict";
import 'reflect-metadata';
const signer = @./filecoin-signing-tools');
const FilecoinRPC = @./filecoin-signing-tools/utils');
const axios = require('axios');
const bip32 = require('bip32');
import { Message } from @./filecoin-message';
const BigNumber = require('bignumber.js');
const fromString = require('uint8arrays/from-string');
const factory = @./filecoin-address') ;
const secp256k1 = require('secp256k1');
import { method } from 'lodash';
const BN = require('bn.js');
const URL = "https://api.node.glif.io";
const token =
'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJBbGxvdyI6WyJyZWFkIiwid3JpdGUiLCJzaWduIiwiYWRtaW4iXX0.f_asUQSSSHlMgM51IOGLSX0bZwo_s8434jvdRs_4GV0'
;
const headers = { 'Authorization': Bearer ${token} }
async function main() {
const message = {
"From": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a",
"GasLimit": 283763,
"GasPremium": "56676",
"GasFeeCap": "65789",
"Method": 0,
"Nonce": 9,
"Params": "",
"To": "f1susdjal2rogayvfr6m7wypfhawcmuc3ny7v7osi",
"Value": "100000"
}
const MASTER_KEY =

"a71da0d73c04775f8431f8f89d7d68874ae8a2e0461e13e8ed050d90f0479354";
let MASTER_NODE = bip32.fromBase58(MASTER_KEY);
const example_key = MASTER_NODE.derivePath("m/44'/461'/0'/0/0");
const privatekey_base64 = 'px2g1zwEd1+EMfj4nX1oh0roouBGHhPo7QUNkPBHk1Q='
;
const signed_tx = signer.transactionSign(message, );
console.log(signed_tx);
let response = await axios.post(URL, {
    jsonrpc: '2.0',
    method: 'Filecoin.MpoolPush',
    id: 1,
    params: [signed_tx],
  }, { headers }).catch((e: any) => { console.error(e.message) });

console.log('resoponse', response);

let cid = await response.data.result;
console.log('cid', cid);

response = await axios.post(URL, {
  jsonrpc: '2.0',
  method: 'Filecoin.StateWaitMsg',
  id: 1,
  params: [cid, null],
}, { headers }).catch((e: any) => { console.error(e.message) });

console.log('state', response)

}
main()
On Wed, Aug 18, 2021 at 4:03 PM Lola Dam @.***> wrote:

It should be encoded in base64 and your private key too.
const message = {"Version": 0,"To": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a","From": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a","Nonce": 0,"Value": "100000","GasPrice": "190464106","GasLimit": 25000,"Method": 0,"GasPremium": '1',"GasFeeCap": '190464106',"Params": ""};
const cbor = await signer.transactionSerialize(message);const message = await signer.transactionParse(cbor, false);// Your private key should base64 encodedlet signature = signer.transactionSignRaw(message, privatekey.toString('base64'));signature = Buffer.from(signature)let message_digest1 = getDigest(Buffer.from(cbor, 'hex'));const bufer = Buffer.from(publickey, 'hex')const unit8arrayformatofpublickey = new Uint8Array(bufer);const value = secp256k1.ecdsaVerify(signature.slice(0, -1), message_digest1, unit8arrayformatofpublickey)// Your signed message Data field should be base64 encode (in your screenshot it is a hex string).const signedMessage = {Message: message,Signature: {Data: signature.toString("base64"),Type: 1,}};let response = await axios.post(URL, {"jsonrpc": "2.0","method": "Filecoin.MpoolPush","id": 1,"params": [signedMessage]}, { headers }).catch((e: any) => { console.error(e.message) });
Please note that I haven't tested the code. I let you do it.
You can also try using transactionSignLotus it is offline and will fill
your requirements. Just so you can compare the result and help you debug.
const message = {"Version": 0,"To": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a","From": "f1nfem4vordv7eamgidfgagzo6j6z32nrfoufxx5a","Nonce": 0,"Value": "100000","GasPrice": "190464106","GasLimit": 25000,"Method": 0,"GasPremium": '1',"GasFeeCap": '190464106',"Params": ""};
// It is an offline function.let signedMessage = signer.transactionSignLotus(message, privatekey.toString('base64'));console.log(signedMessage)
let response = await axios.post(URL, {"jsonrpc": "2.0","method": "Filecoin.MpoolPush","id": 1,"params": [signedMessage]}, { headers }).catch((e: any) => { console.error(e.message) });
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Zondax/filecoin-signing-tools/issues/405#issuecomment-901484292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHTYPJXJE2HCTI6IPUSHG4DT5Q33XANCNFSM5CJKD7GQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Test Patch uses assert_not_called()

Describe the bug
django__django-15252 have assert_not_called() on a method. Solutions are possible even when calling that.
Suggestions:
The line should be removed from the test patch.
Steps/Code to Reproduce

Expected Results

Actual Results

System Information
No response

SWE-bench's collection process does not involve modifying the original patch or test_patch.


Add a new Community Addon to addon-gallery

Issue: #4832
What I did
At @igor-dv's suggestion I added a link and description for a solution to #4832, in the addon-gallery; Community Addon section.
How to test

Is this testable with Jest or Chromatic screenshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
Yes, but just the page that I updated.

Thanks @shilman + @igor-dv


winston for logging with wrapper exported

required nodemon and winston in package.json (nodemon was missing
add       "secure":false flag in client server config(required for local dev @rnprince lmk if this should stay or not)
added log folder and excluded from git contents
winston wrapper in services folder with timestamp stack, and error message
example usage in auth service.

Description

This was to address issue #39, adding server logging to file.
Related Issue
#39
Motivation and Context
Issue #39
How Has This Been Tested?
tested locally

Example output:
{ level: 'error',   message: 'Error creating user',   timestamp: '2018-12-18T18:07:22.550Z',   [Symbol(level)]: 'error',   [Symbol(splat)]:    [ Error: data and salt arguments required          at Object.hash (/Users/krysttian/dev/lobbster/node_modules/bcrypt/bcrypt.js:138:17)          at /Users/krysttian/dev/lobbster/node_modules/bcrypt/promises.js:29:12          at new Promise (<anonymous>)          at Object.module.exports.promise (/Users/krysttian/dev/lobbster/node_modules/bcrypt/promises.js:20:12)          at Object.hash (/Users/krysttian/dev/lobbster/node_modules/bcrypt/bcrypt.js:134:25)          at hash (/Users/krysttian/dev/lobbster/services/bcrypt.js:3:45)          at app.post (/Users/krysttian/dev/lobbster/routes/authorization.js:23:34)          at Layer.handle [as handle_request] (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/layer.js:95:5)          at next (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/route.js:137:13)          at Route.dispatch (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/route.js:112:3)          at Layer.handle [as handle_request] (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/layer.js:95:5)          at /Users/krysttian/dev/lobbster/node_modules/express/lib/router/index.js:281:22          at Function.process_params (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/index.js:335:12)          at next (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/index.js:275:10)          at SessionStrategy.strategy.pass (/Users/krysttian/dev/lobbster/node_modules/passport/lib/middleware/authenticate.js:338:9)          at SessionStrategy.authenticate (/Users/krysttian/dev/lobbster/node_modules/passport/lib/strategies/session.js:75:10) ] } { level: 'error',   message: 'Error creating user',   timestamp: '2018-12-18T18:07:25.834Z',   [Symbol(level)]: 'error',   [Symbol(splat)]:    [ Error: data and salt arguments required          at Object.hash (/Users/krysttian/dev/lobbster/node_modules/bcrypt/bcrypt.js:138:17)          at /Users/krysttian/dev/lobbster/node_modules/bcrypt/promises.js:29:12          at new Promise (<anonymous>)          at Object.module.exports.promise (/Users/krysttian/dev/lobbster/node_modules/bcrypt/promises.js:20:12)          at Object.hash (/Users/krysttian/dev/lobbster/node_modules/bcrypt/bcrypt.js:134:25)          at hash (/Users/krysttian/dev/lobbster/services/bcrypt.js:3:45)          at app.post (/Users/krysttian/dev/lobbster/routes/authorization.js:23:34)          at Layer.handle [as handle_request] (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/layer.js:95:5)          at next (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/route.js:137:13)          at Route.dispatch (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/route.js:112:3)          at Layer.handle [as handle_request] (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/layer.js:95:5)          at /Users/krysttian/dev/lobbster/node_modules/express/lib/router/index.js:281:22          at Function.process_params (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/index.js:335:12)          at next (/Users/krysttian/dev/lobbster/node_modules/express/lib/router/index.js:275:10)          at SessionStrategy.strategy.pass (/Users/krysttian/dev/lobbster/node_modules/passport/lib/middleware/authenticate.js:338:9)          at SessionStrategy.authenticate (/Users/krysttian/dev/lobbster/node_modules/passport/lib/strategies/session.js:75:10) ] }

Hey, great work on this. I just have two things that should be addressed before merging.
I noticed that the logging happens only if I've already created a /logs directory. Two solutions would be to add a step to the readme's Getting Started section, or to have a non-.gitignored .gitkeep file inside the directory. I'm open to other ideas if you have something else in mind.
Also, could you please go over the code with eslint so it's a closer match to the eslint configuration? (I need to update the readme to add a heads-up about this.) The project isn't totally consistent about this yet, and it's fine if some of the code doesn't match up. I'd just like it to conform enough that it helps catch any bugs that get picked up as atypical coding style.
Thanks!


fix: Fix main READMEwith correct hyperlinks to SonarCloud

:tada: This PR is included in version 1.8.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.8.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.8.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added documentation

@josevalim I have added documentation using ExDoc. Please let me know what all changes you think are required before I merge this.
Next I will clean up the README.

Thanks @anshuman23! I have added some comments, some are aesthetic ones, but generally this looks great!

Don't forget to add doc/ to `.gitignore and remove the files from the commit before merging. :)


Support equirectangular sensor with metashape

fixes https://github.com/nerfstudio-project/nerfstudio/issues/1634 (see sample runs in that issue)
The COLMAP logic had to be changed slightly, as mentioned here: https://github.com/nerfstudio-project/nerfstudio/issues/1634#issuecomment-1529152231 : after computing the planar projections, the ns-process-data scripts now set the camera type to perspective (which makes sense, since all the rest of the processing is on perspective cameras).

Should I run black, which would change many more lines than what I touched?

Run ns-dev-test, make sure to install the correct packages with pip install -e .[dev]


Consider using Steque to implement immutable.Queue

See discussions at #88 and #341.

Assigning to backlog to reconsider for 2.14


SETH_CNN.pt Not Available

Hi, thank you for your great work! But there is a problem that it seems that the weight from https://rostlab.org/~deepppi/SETH_CNN.pt is no longer available now. Can you provide the weight you downloaded? Thanks again.

I've asked the SETH team for it and  they put the weight in the CNN folder in their github page https://github.com/DagmarIlz/SETH. Thanks anyway.

Sorry but it seems that all weights under the link https://rostlab.org/~deepppi/ are not available. Could you please provide the weights or new available download links?


[package:js] @JS() Mixins can no longer be used with other @JS() classes since Dart SDK 2.12.0+

@JS() annotated mixins (or classes used as mixins) can no longer be used together with other @JS() classes since Dart >= 2.12.0-stable  (I'm testing with the Stable channel builds for Linux from https://dart.dev/get-dart/archive).
Consider the following example:
// pubspec.yaml
name: demo
version: 1.0.0
description: @JS() Mixins

environment:
  sdk: '>=2.7.0 <3.0.0'

dependencies:
  js: ^0.6.2

dev_dependencies:
  build_runner: ^1.10.0
  build_web_compilers: ^2.9.0

// web/main.dart
@JS()
library main;

import 'package:js/js.dart';

@JS()
@anonymous
mixin DemoMixin {
  external bool demo();
}

@JS()
@anonymous
class DemoClass with DemoMixin {
}

void main() {}

The above fails with the following error:
[SEVERE] build_web_compilers:entrypoint on web/main.dart (cached): AssetNotFoundException: demo|web/main.unsound.ddc.js.metadata

[SEVERE] build_web_compilers:ddc on web/main.ddc.module (cached): Error compiling dartdevc module:demo|web/main.unsound.ddc.js

web/main.dart:15:7: Error: JS interop class 'DemoClass' cannot extend Dart class 'Object with DemoMixin'.
Try removing the JS interop annotation or adding it to the parent class.
class DemoClass with DemoMixin {
      ^

Everything compiles OK and without errors when using Dart <= 2.10.5-stable.
After some digging through the commits history, It seems that the change was introduced with commit https://github.com/dart-lang/sdk/commit/ed009afc4cb6ac6f3a088895ad1de5b8554026d8 but as far as I understand it is intended to prevent extending JS interop classes with plain Dart classes (and the opposite - extending plain Dart classes with JS interop ones). Also note that the test case from the above commit doesn't take mixins in consideration.
Am I missing something? Is this an intended behavior?

Thanks for filing! Since mixin classes are generated, this makes sense, as the generated classes aren't annotated, and therefore our static checker will signal an error.
This could be resolved in the checker itself, but this opens up the question about whether we should allow mixins with package:js in general and support them. In the past, we've decided against it, as there are other issues around it, and we've (as you noted) excluded it from our analysis. However, it might be useful to make a concrete decision here and plan accordingly i.e. if we want to not support it, disallow it, and if we do want to support it, add testing to make sure it works. I'm not sure if the web compilers handle all the mixin cases correctly today, unfortunately, so I think this might be on the back-burner.
cc @sigmundch @rileyporter , do we have any thoughts on what we want to do with mixins?

Since we are headed towards static js-interop in the near future, it may be worth deciding first what we want to do in that context and then circle back to the non-static case.
For static interop, the value of allowing @JS mixins is pretty minimal since it is no different than using an interface with static extension methods. For example, this could work:
@JS() @staticInterop
class A {}

@JS() @staticInterop
mixin M{}

extension Me on M {
  external bool foo;
}

@JS() @staticInterop
class B extends A with M {
  factory B()...
}

but, the same will hold after s/mixin/class/ and s/with/implements/.
Once we have views/extension-types I can see us trying to move further away from modeling js-interop types as Dart classes. I sense mixins will not come into play at that point, so disallowing mixins would be aligned with that future.
I currently have a small leaning towards disallowing it. Allowing it would be a small leap from our current implementation, but the use cases are rare and disallowing it would prevent breaking changes down the line when we migrate towards static interop everywhere.
Thoughts?

The work needed for that example might be simple enough (e.g. just make sure we walk up the mixin hierarchy in the checks) - I think the rest should come for free. I can see some value in defining mixins, but I also think they generally provide a lower benefit in the interop case compared to their non-interop use case, as we usually have external methods.
The extension types case is interesting - from a language feature POV, can they extend multiple other extension types, essentially replicating mixin functionality? If this is true and there is some value in allowing static interop mixins, I think supporting that would be easier and would keep it aligned with the future extension types model. If it is not true, I think it makes less sense to do so as the migration story would be even harder then. The non-static interop case is an unknown to me: it might not work in some cases on one or more of the compilers and I'm not sure if they're tested. Planning work there could be a bigger effort than we currently expect, so I'm also leaning towards disallowing it in that case.
At any rate, it might be worth having a separate error mentioning mixins aren't allowed in all or some use cases. The above error is unfortunate and unclear. Before that error, mixins were possibly being used because they worked in some cases and we didn't communicate that we didn't support them.

I have done a very large amount of work with Dart's JS interop and pushed it to its limits many times. I have started investigating the new @staticInterop extension types and as awesome as it is, I do think that static interop mixins would be an absolutely amazing feature to support officially. Because, although you can get inheritance via extension types it can be a bit more complicated to control, simply because of extensions scoping and lack of explicit verbosity. The advantages that static interop mixins offer seem perfectly poised for JS types.

I have done a very large amount of work with Dart's JS interop and pushed it to its limits many times. I have started investigating the new @staticInterop extension types and as awesome as it is, I do think that static interop mixins would be an absolutely amazing feature to support officially. Because, although you can get inheritance via extension types it can be a bit more complicated to control, simply because of extensions scoping and lack of explicit verbosity. The advantages that static interop mixins offer seem perfectly poised for JS types.

For what it's worth, @staticInterop is a prototype before we get inline classes (formerly known as extension types or views). Now that we have an inline class prototype and the language is working to evolve it into a fully-fledged feature, I'm less in favor of expanding @staticInterop features (but we still want to resolve bugs!), and focusing on inline classes instead if inline classes come with the feature in question.
That being said, I do agree that the abilities mixins provide are useful for static interop, as it's desirable to be able to mix a set of grouped interop members in. With inline classes, you can do the following:

Have non-static external members within the inline class instead of in an extension.
Implement other inline classes. This is in effect mixing in the members of the other inline class.

Because members are within the inline class and not in an extension, scoping shouldn't be an issue, as the members are attached to the type. I'm not entirely sure what you're referring to with "lack of explicit verbosity". Is this referring to naming the mixin?

I was just introduced to the proposal of inline classes today right as you replied. It does sound quite exciting so I agree with your stance. Thanks for the reply!


translation broken on fail whale page

en-us.yaml not loading on fail whale page

to reproduce

Add github auth
logout after successful auth
use the following url https://localhost:8000/login?code=a51bb551882d85f7&state=bar

Version - master 8/9
Verified fixed


Fix: Loading Spinner

Loading Spinner is taking whole screen and is also not suiting with the theme

i can fix this. Just tell me what type of loader you want.
Can you assign this issue to me ?

You  can add a clip loader or fade loader etc.
Go ahead i've assigned.


Notification system

two supported groups of notification:
info and error
Uses the same html template as the former error-notification

Good to go


Ignore minimised windows

It would be nice if there was a feature to ignore minimised windows from switching. The behaviour of whether or not to ignore minimised windows could be controlled by a tickbox in the settings menu.

I really like AltBacktick! I previously used Easy Windows Switcher but I found it could not switch windows if those windows had been minimized. I think Easy Windows Switcher is more suitable for you currently. Of course your proposal is really nice.

+1,in mac it works as @Vitaly-S-Pavlenko said,minimized windows were ignored,it would be nice to add a toggle option.
I tried Easy Windows Switch @HangX-Ma ,it works the same as AltBacktick，it could swtich windows had beem minimized too.

+1,in mac it works as @Vitaly-S-Pavlenko said,minimized windows were ignored,it would be nice to add a toggle option.
I tried Easy Windows Switch @HangX-Ma ,it does not work on my PC ,win11.

Added in 1.4.0 - it's disabled by default, you have to enable it (see the readme):
[behavior]
ignore_minimized_windows=true


fix the children query

Hopefully fixes the children query and adds tests!

@brookeangel Can you give me some more context on what this fixes? what was broken?

Oops, sorry for the very late response!
Currently, Query.children returns a parent element as well as its children if the parent element matches the selectors. This PR should make it such that only the children elements are returned (though @rtfeldman has some suggested changes that have not yet been added - WIP) & make sure that we are testing for the right thing.
The old tests for Query.children do not test for this.
Here is the sample html being tested:
sampleHtml : Html msg
sampleHtml =
    section [ Attr.class "root" ]
        [ div [ Attr.class "container" ]
            [ header [ Attr.class "funky themed", Attr.id "heading" ]
                [ a [ href "http://elm-lang.org" ] [ Html.text "home" ]
                , a [ href "http://elm-lang.org/examples" ] [ Html.text "examples" ]
                , a [ href "http://elm-lang.org/docs" ] [ Html.text "docs" ]
                ]
            , section [ Attr.class "funky themed", Attr.id "section" ]
                [ ul [ Attr.class "some-list" ]
                    [ li [ Attr.class "list-item themed" ] [ Html.text "first item" ]
                    , li [ Attr.class "list-item themed" ] [ Html.text "second item" ]
                    , li [ Attr.class "list-item themed selected" ] [ Html.text "third item" ]
                    , li [ Attr.class "list-item themed" ] [ Html.text "fourth item" ]
                    ]
                ]
            , section []
                [ div [ Attr.class "nested-div" ] [ Html.text "boring section" ] ]
            , footer [] [ Html.text "this is the footer" ]
            ]
        ]

Here is the current testChildren function and what it misses:
 test "sees the root has one child" <|
        \() ->
             output
                   |> Query.children []
                   |> Query.count (Expect.equal 1)

Want: we want to make sure that there is one child node, and that it is the div
Actual: Query.children actually returns the section which is our root, so the count is 1, but it isn't the child
            test "sees it's a <header id='heading'>" <|
                \() ->
                    output
                        |> Query.children []
                        |> Query.each (Query.has [ tag "header", id "heading" ])

Want: We probably want to check that the child of the root is the div.container
Actual: we are checking that the child is a header#header... this passes because Query.has will check all the descendants for a header.
The new tests should check for these cases & fail with the current code. And then the new Query.children should fix it!


Cannot checkout change

Hi,
I just tried configuring this plugin. I can see all changes listed, but when I try to check out a change, the username is capitalized while it should be lowercase entirely. Any pointers on why this is happening? My global .gitconfig looks like this:
...
[user]
email =<EMAIL_ADDRESS>name = daan
...
In the log files I see this:
GET request to "https://xxx.com/gerrit/a/changes/I498b470c964a07d57a2fc1323d3371189d29bf74/detail/"
Tried to run "git-review -d "I25aa723800470aaf42340968774235af454b02e2"", but failed
Stdout: ssh://Daan@xxx.com:29418/labonlineApp did not work. Description<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Could not connect to gerrit.
Enter your gerrit username:
Stderr:
Error: Command failed: git-review -d "I25aa723800470aaf42340968774235af454b02e2"
I know this probably has nothing to do with the plugin, but I'm hoping you could point me in the right direction.
Thank you in advance!
Daan

Gerrit uses SSH to connect to the server and do its checkouts. So it's using your device's username (probably Daan) to connect since that's what SSH defaults to. The Gerrit CLI does not use your git username at all. You'll want to ensure that using ssh {your_gerrit_server_url} connects succesfully (check out the "SSH Keys" setting in your gerrit settings). After that it should work.
Some tips:

You can just run git-review -d {change_number} in the terminal by itself to test it out. That's a bit easier to debug than viewing the extension's logs.
You can create a custom Host in your .ssh/config to "rewrite" your username (see here)

Thank you! However, I'm afraid I still don't understand entirely. If I use the command ssh -vv -p 29418 xxx.com, I am succesfully authenticated. If I then for example do git-review -d 5161, I get the following:
ssh://Daan@xxx.com:29418/repo did not work. Description<EMAIL_ADDRESS>Permission denied (publickey).
Also, I tried rewriting my username but that is seemingly ignored.

How do you normally use Gerrit? Are you able to check out or push patches at all? Maybe good to check out a Gerrit tutorial or getting started guide. I do have some experience setting Gerrit up but this is more of a gerrit-related question than a vscode-gerrit-related question so obviously I'm not as much of an expert :)


Build failure: nvidia-x11

Steps To Reproduce
Steps to reproduce the behavior:
hardware.nvidia.package = config.boot.kernelPackages.nvidiaPackages.legacy_470;
boot.supportedFilesystems = [ "bcachefs" ];

Build log
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:579:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   579 |         NV_MEMDBG_ADD(ptr, size);
nvidia-x>       |                                 ^
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_vmap':
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:666:51: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   666 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
nvidia-x>       |                                                   ^
nvidia-x> In file included from /build/NVIDIA-Linux-x86_64-470.256.02/kernel/nvidia/os-registry.c:14:
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_vmalloc':
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:521:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   521 |         NV_MEMDBG_ADD(ptr, size);
nvidia-x>       |                                 ^
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_ioremap':
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:535:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   535 |         NV_MEMDBG_ADD(ptr, size);
nvidia-x>       |                                 ^
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_ioremap_cache':
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:549:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   549 |         NV_MEMDBG_ADD(ptr, size);
nvidia-x>       |                                 ^
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_ioremap_wc':
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:579:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   579 |         NV_MEMDBG_ADD(ptr, size);
nvidia-x>       |                                 ^
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_vmap':
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h:666:51: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
nvidia-x>   666 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
nvidia-x>       |                                                   ^
nvidia-x> In file included from /build/NVIDIA-Linux-x86_64-470.256.02/kernel/nvidia/os-usermap.c:14:
nvidia-x> /build/NVIDIA-Linux-x86_64-470.256.02/kernel/common/inc/nv-linux.h: In function 'nv_vmalloc':

Notify maintainers

@Kiskae
@edwtjo
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
» nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.43, NixOS, 24.11 (Vicuna), 24.11.20240728.52ec9ac`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.23.3`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/bcghcr9qwqmanpds017w75mcqda4fgab-source`

Add a :+1: reaction to issues you find important.

Got this slightly different error log building a custom open version of 550.78 for 6.10.3 :
      package = config.boot.kernelPackages.nvidiaPackages.mkDriver {
        version = "550.78";
        sha256_64bit = "sha256-NAcENFJ+ydV1SD5/EcoHjkZ+c/be/FQ2bs+9z+Sjv3M=";
        sha256_aarch64 = "sha256-2POG5RWT2H7Rhs0YNfTGHO64Q8u5lJD9l/sQCGVb+AA=";
        openSha256 = "sha256-cF9omNvfHx6gHUj2u99k6OXrHGJRpDQDcBG3jryf41Y=";
        settingsSha256 = "sha256-lZiNZw4dJw4DI/6CI0h0AHbreLm825jlufuK9EB08iw=";
        persistencedSha256 = "sha256-qDGBAcZEN/ueHqWO2Y6UhhXJiW5625Kzo1m/oJhvbj4=";
      };

building '/nix/store/64bl14bm8p49kjxai7j2w6zc9pr6mpck-nvidia-x11-550.78-6.10.3.drv'...
error: builder for '/nix/store/64bl14bm8p49kjxai7j2w6zc9pr6mpck-nvidia-x11-550.78-6.10.3.drv' failed with exit code 2;
       last 10 log lines:
       > /build/NVIDIA-Linux-x86_64-550.78/kernel/common/inc/nv-linux.h: In function 'nv_vmap':
       > /build/NVIDIA-Linux-x86_64-550.78/kernel/common/inc/nv-linux.h:674:51: warning: suggest braces around empty body in an 'if' statement [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wempty-body-Wempty-body8;;]
       >   674 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
       >       |                                                   ^
       > make[3]: *** [/nix/store/n8p31hdqnjcvry0h4i09y6zdif43bb6d-linux-6.10.3-dev/lib/modules/6.10.3/source/Makefile:1934: /build/NVIDIA-Linux-x86_64-550.78/kernel] Error 2
       > make[2]: *** [/nix/store/n8p31hdqnjcvry0h4i09y6zdif43bb6d-linux-6.10.3-dev/lib/modules/6.10.3/source/Makefile:240: __sub-make] Error 2
       > make[2]: Leaving directory '/nix/store/n8p31hdqnjcvry0h4i09y6zdif43bb6d-linux-6.10.3-dev/lib/modules/6.10.3/build'
       > make[1]: *** [Makefile:240: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/n8p31hdqnjcvry0h4i09y6zdif43bb6d-linux-6.10.3-dev/lib/modules/6.10.3/source'
       > make: *** [Makefile:85: modules] Error 2
       For full logs, run 'nix log /nix/store/64bl14bm8p49kjxai7j2w6zc9pr6mpck-nvidia-x11-550.78-6.10.3.drv'.
error: 1 dependencies of derivation '/nix/store/xw89rw8wh4d1sj0jvafcqaqqlkn4w80g-etc.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-nvidia-open-6.10.3-550.78.drv-0/build/source/kernel-open': Directory not empty
error: 1 dependencies of derivation '/nix/store/5hx50j8qmw6kv54s4d8a9yzgif862r15-firmware.drv' failed to build
error: 1 dependencies of derivation '/nix/store/2hwsn481y1gk69zbhyy2fihi0xls81wl-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/hz6n2a0zxp8kmb0pla2g1876qdjlbcf7-nixos-system-nixos-24.05.20240804.8b5b672.drv' failed to build

System (used to work well for 6.9.12):
 - system: `"x86_64-linux"`
 - host os: `Linux 6.9.12, NixOS, 24.05 (Uakari), 24.05.20240804.8b5b672`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `"home-manager-23.11.tar.gz, nixos-23.11, nixos-unstable"`
 - nixpkgs: `/nix/store/l0992b1shksi7k8w1x6wzi61zbs48vck-source`

@Kiskae I'll stick to 6.9 for now, because I'm tied to that particular Nvidia driver version, which was the last one that doesn't give me flickering with sway (at least I hope that'll be fixed in the next release).

since im using a legacy driver package, i assume that can't be updated, right ?

since im using a legacy driver package, i assume that can't be updated, right ?

At the moment 470.256.02 is the latest release for the 470xx branch.
According to nvidia the kepler GPUs are still supported until the end of september, so there might be a last official 470.xx release, but after that we'll need to use community-sourced patches to maintain support.

Critical security updates will be available on systems utilizing desktop Kepler-series GPUs through September 2024.

thanks for the info

The relevant nvidia issue is NVIDIA/open-gpu-kernel-modules#642.

just bumping this thread to show that it is affecting me as well
2024/08/13 06:07:41 akmodsbuild: /tmp/akmodsbuild.9MgXSEUM/BUILD/nvidia-470xx-kmod-470.256.02/_kmod_build_6.10.3-100.fc39.x86_64/common/inc/nv-linux.h:666:51: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
2024/08/13 06:07:41 akmodsbuild:   666 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
2024/08/13 06:07:41 akmodsbuild:       |                                                   ^
2024/08/13 06:07:41 akmodsbuild: make[2]: *** [/usr/src/kernels/6.10.3-100.fc39.x86_64/Makefile:1946: /tmp/akmodsbuild.9MgXSEUM/BUILD/nvidia-470xx-kmod-470.256.02/_kmod_build_6.10.3-100.fc39.x86_64] Error 2
2024/08/13 06:07:41 akmodsbuild: make[1]: *** [Makefile:252: __sub-make] Error 2
2024/08/13 06:07:41 akmodsbuild: make[1]: Leaving directory '/usr/src/kernels/6.10.3-100.fc39.x86_64'
2024/08/13 06:07:41 akmodsbuild: make: *** [Makefile:80: modules] Error 2
2024/08/13 06:07:41 akmodsbuild: error: Bad exit status from /var/tmp/rpm-tmp.WvPRig (%build)
2024/08/13 06:07:41 akmodsbuild:
2024/08/13 06:07:41 akmodsbuild: RPM build errors:
2024/08/13 06:07:41 akmodsbuild:     Bad exit status from /var/tmp/rpm-tmp.WvPRig (%build)
2024/08/13 06:07:41 akmodsbuild:
2024/08/13 06:07:41 akmods: Building rpms failed; see /var/cache/akmods/nvidia-470xx/470.256.02-1-for-6.10.3-100.fc39.x86_64.failed.log for details

Friendly bump 🙏🏻

@matteo-pacini ... Recent builds have resumed normal function on my machine.  I don't have the kernel version or almond versions handy as I type this .

@metalflow considering your logs indicates you were building RPMs, I think you might be commenting on the wrong repository/issue.
Regardless it is likely that your distribution has patched 470xx to support 6.10 which we can look at including in our builds.

@metalflow In my case, here's the failure for nvidia-x11-550.78-6.10.5 - tested right now:
error: builder for '/nix/store/cyf8z12ndy7glm548sbackbbfjglfgdr-nvidia-x11-550.78-6.10.5.drv' failed with exit code 2;
       last 10 log lines:
       >       |     ^~~~~~~~~~~~~~
       > /build/NVIDIA-Linux-x86_64-550.78/kernel/nvidia-uvm/uvm_tools.c:2947:6: warning: no previous prototype for 'uvm_tools_exit' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wmissing-prototypes-Wmissing-prototypes8;;]
       >  2947 | void uvm_tools_exit(void)
       >       |      ^~~~~~~~~~~~~~
       > make[3]: *** [/nix/store/3250aqigq71xg3jl7j7f9x7w8nfy2vmi-linux-6.10.5-dev/lib/modules/6.10.5/source/Makefile:1934: /build/NVIDIA-Linux-x86_64-550.78/kernel] Error 2
       > make[2]: *** [/nix/store/3250aqigq71xg3jl7j7f9x7w8nfy2vmi-linux-6.10.5-dev/lib/modules/6.10.5/source/Makefile:240: __sub-make] Error 2
       > make[2]: Leaving directory '/nix/store/3250aqigq71xg3jl7j7f9x7w8nfy2vmi-linux-6.10.5-dev/lib/modules/6.10.5/build'
       > make[1]: *** [Makefile:240: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/3250aqigq71xg3jl7j7f9x7w8nfy2vmi-linux-6.10.5-dev/lib/modules/6.10.5/source'
       > make: *** [Makefile:85: modules] Error 2

Config bits:

https://github.com/matteo-pacini/nixos-configs/blob/master/hosts/Nexus/default.nix#L13 (Kernel )
https://github.com/matteo-pacini/nixos-configs/blob/master/hosts/Nexus/gpu.nix (GPU)
https://github.com/matteo-pacini/nixos-configs/blob/master/hosts/Nexus/hardware.nix#L22-L23 (initrd modules)

According to nvidia forum, this patch can help to fix build failure on 6.10 kernels with 470 driver.

I am unable to update my flake because of nvidia-x11 failing, even if I try what was specified in the discourse: https://discourse.nixos.org/t/builder-for-nvidia-x11-550-78-6-10-drv-failed-with-exit-code-2/49360/32

@PassiveLemon I managed to update with declaring the version 555.58.02 package as variable and using it for both boot.extraModulePackages and hardware.nvidia.package (with linuxPackages_latest kernel). What error do you get?

Ugh... I had a pkgs.linuxKernel.packages.linux_zen.nvidia_x11 left over in my config which would fail, which led to me thinking the workaround didn't work. Removed that and I am able to build with 555.58.02...

For me I needed to delete this line kernelPackages = pkgs.linuxPackages_latest;


Exception: (detect) glXGetCurrentContext: cannot detect OpenGL context

It is just a script to open the viewer without any object inside but it doesn't seem to open openGL context:
➜  aitviewer git:(main) ✗ python test.py
libGL error: MESA-LOADER: failed to open iris (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri)
libGL error: failed to load driver: iris
libGL error: MESA-LOADER: failed to open iris (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri)
libGL error: failed to load driver: iris
libGL error: MESA-LOADER: failed to open swrast (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri)
libGL error: failed to load driver: swrast
Traceback (most recent call last):
  File "test.py", line 5, in <module>
    v = Viewer()
  File "/home/zfan/aitviewer/aitviewer/viewer.py", line 139, in __init__
    self.window = base_window_cls(
  File "/home/zfan/aitviewer/aitviewer/utils/pyqt5_window.py", line 107, in __init__
    self.init_mgl_context()
  File "/home/zfan/anaconda3/envs/instant/lib/python3.8/site-packages/moderngl_window/context/base/window.py", line 170, in init_mgl_context
    self._ctx = moderngl.create_context(require=self.gl_version_code)
  File "/home/zfan/anaconda3/envs/instant/lib/python3.8/site-packages/moderngl/context.py", line 2004, in create_context
    ctx.mglo, ctx.version_code = mgl.create_context(glversion=require, mode=mode, **settings)
  File "/home/zfan/anaconda3/envs/instant/lib/python3.8/site-packages/glcontext/__init__.py", line 90, in create
    return x11.create_context(**kwargs)
Exception: (detect) glXGetCurrentContext: cannot detect OpenGL context

The package was installed within conda. Somehow a conda environment with Python 3.8 has this issue while Python 3.7 does not.
So the solution was to install Python 3.7 environment instead.


Reviva breaks RPM persistence

When reviva is installed, my cockpits forget what pages are selected on each MFD after scene changes or save/load operations.  This does not occur when reviva is not installed.
Repro:

create a vessel containing the mk1 lander can
in the vab, set it to use the RPM IVA
launch the craft
Change one of the MFDs to something non-default
hit F5 to create a quicksave
hold F9 to load the quicksave
Look at the MFD again

If Reviva is installed, all MFDs will start on the default home page.  When reviva is not installed, they remember what page they were set to.  The persistence information is stored in the RasterPropMonitorComputer partmodule, which I'm pretty sure Reviva is destroying and re-creating.  It makes sense to do this if the IVA is changing, but this needs to be avoided if the IVA is the same as the one that is being loaded.
EDIT: correction, the persistence is stored in the vesselcomputer...so not entirely sure how this gets populated back into the MFDs.

I'm going to rebuild the way RPM does variable persistence because it's pretty gnarly, so don't bother spending any time on this...

Well, I changed RPM to use OnLoad properly and the persistence still breaks with reviva.


implement Multiplexer by storing the bookkeeping info in meta

saving small data in a blob's meta info is faster than storing in the blob itself.

done


Support reading h265 with Webrtc

Describe the feature
Todo:

[x] add support for h265 into webrtc_conn
[ ] or realtime transcode from h265 to h264 for playng video over webrtc

You answer in issue 1438, but i can't understand why? in logs of server i have:

closed (the stream doesn't contain any supported codec (which are currently VP9, VP8, H264, Opus, G722, G711))

I tested safari, chrome, firefox on my mac and doesn't work webrtc h265.
many cameras broadcast only in h265 (all my cameras broadcast only in h265), I can only watch them via rtsp, this is not very convenient and webrtc can come to the rescue.
many cameras broadcast only in h265 (all my cameras broadcast only in h265), I can only watch them via rtsp, this is not very convenient and webrtc can come to the rescue.
in addition, the output you describe is not acceptable, because it creates a large load on the CPU, especially if there are 500 streams on the server, and also increases the already large delay and the video is essentially not real-time

I repeat: it's not a server limitation, it's a browser limitation. All browsers except Safari don't support H265 through WebRTC. I can't do anything about it.
The server is not able to stream H265 through WebRTC and there's no need to develop the feature for the reason explained above.

As I wrote above, this does not work in safari either.  I'm developing my smartphone app for ios and android, how can I use rtsp-simple-server to display video via webrtc?  Or maybe you can do real-time transcoding?

For the third time: H265 inside WebRTC is currently supported by Safari only, therefore server support inside rtsp-simple-server has not been developed because there are currently not enough reasons to do it.
You can transcode from H265 to H264 at any moment by using FFmpeg, as described in the README:
https://github.com/aler9/rtsp-simple-server#remuxing-re-encoding-compression

The problem is that you're combining two separate problems.
Problem #1: Not fully understanding the actual problem: You're sourcing at H.265 but you need to broadcast at H.264 -- two separate things.
Problem #2: You're trying to shove H.265 straight away down to the browser and are expecting it to "work" because we're using WebRTC (the all-being illusive answer to all streaming questions 🔨 ).
As @aler9 indicated, he is correct here.
You have three options:

Inject a transcode in your pipeline to make the in become the out you need.
Don't put all your eggs in one basket with WeRTC (it solve one problem) by breaking out streams based on requirements (i.e.: H.264? Go to town over WebRTC. H.265? Use an HLS approach with small segments).
Add in the missing parts around https://github.com/bluenviron/mediamtx/blob/main/internal/core/rtmp_source.go#L127 to kick off the process 🤌 and submit a pr.

I've had to overcome this very issue, several times and at scle. It's not pretty but given the needs of the many over the few this will be the status quo for a while unless you submit that PR @pikachu937 ;)

Streaming H265 with WebRTC is now supported with #4003


Can't see default button in image type control

Issue description:
I tried to use image for logo in my theme with default option set to "get_template_directory_uri().'/images/logo@2x.png'," but i can't see default button after removing
log image
Version used: 3.0.44
(Did you try using the develop branch from GitHub? There's a chance your issue has already been addressed there)
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
$controls[] = array(
    'type'     => 'image',
    'settings'  => 'bt_retina_logo',
    'label'    => esc_html__( 'Retina Logo', 'the-next-blog' ),
    'description' => esc_html__('Retina Ready Image logo. It should be 2x size of normal logo. For example 200x60px logo will displays at 100x30px', 'the-next-blog' ),
    'section'  => 'logo_favicon',
    'default'  =><EMAIL_ADDRESS>    'priority' => 2,
);

Hello and thank you for reporting this issue.
We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.
If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.
Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.
Thank you for your understanding.
Best,
David


Allow context manager

I'd like to use a with block:
from airtable import Airtable
from pandas import DataFrame

with Airtable("base_id", "table_name") as airtable:
    records = airtable.get_all()
df = DataFrame.from_records(r["fields"] for r in records)

I created minimal __enter__() and __exit()__ methods. Let me know if you need anything else.

Curious, what's the advantage of using a context manager here vs the code below?
AFAIX Context manager are using for managing actions that need to be taken before/after, eg. closing a file after opening
In this case the Airtable class has no persistent connection and nothing that needs to be done before/after making the call
Ie, this code should have the same effect:
from airtable import Airtable
from pandas import DataFrame

airtable = Airtable("base_id", "table_name"):
records = airtable.get_all()
df = DataFrame.from_records(r["fields"] for r in records)


Add a license

Hi @Heath123,
I'd like to use rust-casio-docker as a reference to build for another target, arc-elf32.
However, without a license I can't use this repository.

Hello, I’m not sure if build steps would be copyrightable anyway but just in case I’ve applied the CC0 license to make it effectively public domain. Keep in mind that this project isn’t finished and it stopped building for me at some point which I haven’t fixed yet, but I hope this is still useful.


CI for SYCL

Minor fix in CMake file, adding CheckCXXCompilerFlag.

Update examples used for smoke tests to take precision, as in BLAS++. This is needed because our Intel GPU does only single precision.

Add CI builds for Intel GPUs using SYCL.

For Intel, looks like 1 issue in unit tests, 1 known bug in Cholesky QR, 1 accuracy bug in eig hb2st, 1 assertion bug in eig stedc (divide and conquer).
Unit tests:
1 unit tests FAILED: test_Tile

Regular tests:
6 routines FAILED: gels, heev, heev, hb2st, stedc, hegv

Smoke tests:
2 routines FAILED: ./ex11_hermitian_eig, ./ex12_generalized_hermitian_eig

Cholesky QR — known issue
    s  scalpk    task    auto  cholqr   1   1   1  notrans     300     300      10    64  32    1    1   1   4   8.41e-05         NA   4.60e-08   0.000993        39.173            NA            NA  FAILED
    s  scalpk    task    auto  cholqr   1   1   1  notrans     300     300      10   100  32    1    1   1   4   7.72e-05         NA   7.08e-08   0.000893        43.556            NA            NA  FAILED
% 2 tests FAILED: gels

heev: single works, single-complex all fails (see hb2st below)
    c  scalpk    task   qr   1  novec   lower     100    64  32    1    1   1   4   3.31e-01         NA         NA    0.00118      0.000552  FAILED
    c  scalpk    task   qr   1  novec   lower     100   100  32    1    1   1   4   2.39e-01         NA         NA   0.000464      0.000290  FAILED
    c  scalpk    task   qr   1  novec   lower     200    64  32    1    1   1   4   3.71e-01         NA         NA    0.00395       0.00225  FAILED
    c  scalpk    task   qr   1  novec   lower     200   100  32    1    1   1   4   2.80e-01         NA         NA    0.00353       0.00218  FAILED
    c  scalpk    task   qr   1  novec   lower     300    64  32    1    1   1   4   3.77e-01         NA         NA    0.00732       0.00560  FAILED
    c  scalpk    task   qr   1  novec   lower     300   100  32    1    1   1   4   2.67e-01         NA         NA    0.00866       0.00586  FAILED
    c  scalpk    task   qr   1  novec   lower     400    64  32    1    1   1   4   3.23e-01         NA         NA     0.0125        0.0116  FAILED
    c  scalpk    task   qr   1  novec   lower     400   100  32    1    1   1   4   2.85e-01         NA         NA     0.0146        0.0122  FAILED
    c  scalpk    task   qr   1  novec   lower     500    64  32    1    1   1   4   3.85e-01         NA         NA     0.0181        0.0206  FAILED
    c  scalpk    task   qr   1  novec   lower     500   100  32    1    1   1   4   3.47e-01         NA         NA     0.0214        0.0218  FAILED
% 10 tests FAILED: heev

stedc has assertion failure:
tester: src/stedc_solve.cc:120: void slate::stedc_solve(std::vector<real_t> &, std::vector<real_t> &, Matrix<real_t> &, Matrix<real_t> &, Matrix<real_t> &, const Options &) [real_t = double]: Assertion `Qii.mb() == ib' failed.

heev with vectors has same assertion failure from stedc, looks like in single-complex:
tester: src/stedc_solve.cc:120: void slate::stedc_solve(std::vector<real_t> &, std::vector<real_t> &, Matrix<real_t> &, Matrix<real_t> &, Matrix<real_t> &, const Options &) [real_t = float]: Assertion `Qii.mb() == ib' failed.

hb2st fails for single-complex:
    c   lower     100    64    1    1   5.01e-01   1.98e-07   0.000826            NA            NA            NA  FAILED
    c   lower     100   100    1    1   6.23e-01   1.43e-07   0.000408            NA            NA            NA  FAILED
    c   lower     200    64    1    1   4.47e-01   4.05e-07    0.00312            NA            NA            NA  FAILED
    c   lower     200   100    1    1   4.99e-01   5.52e-07    0.00296            NA            NA            NA  FAILED
    c   lower     300    64    1    1   4.38e-01   2.22e-07    0.00585            NA            NA            NA  FAILED
    c   lower     300   100    1    1   4.40e-01   6.61e-07    0.00738            NA            NA            NA  FAILED
    c   lower     400    64    1    1   4.17e-01   1.91e-07     0.0101            NA            NA            NA  FAILED
    c   lower     400   100    1    1   4.53e-01   3.96e-07     0.0132            NA            NA            NA  FAILED
    c   lower     500    64    1    1   4.22e-01   3.41e-07     0.0146            NA            NA            NA  FAILED
    c   lower     500   100    1    1   4.57e-01   5.13e-07     0.0182            NA            NA            NA  FAILED
 % 10 tests FAILED: hb2st

hegv has same assertion failure:
tester: src/stedc_solve.cc:120: void slate::stedc_solve(std::vector<real_t> &, std::vector<real_t> &, Matrix<real_t> &, Matrix<real_t> &, Matrix<real_t> &, const Options &) [real_t = float]: Assertion `Qii.mb() == ib' failed.

I will close by PR that included the fix for check_cxx_compiler_flag.
Do you need anything for me on implementing the CI for sycl?

I think we're okay with the CI for Intel. I just copied what you had setup for BLAS++.

OK, I have to wait for this to be merged before I can continue testing of the sycl backend in the slate spack package.

The nvidia driver support in the docker containers has been fixed, so I'm triggering the CI checks to run again.


Toggle staging and production server api

Details

This PR tries to fix the toggle button on staging environment to select either staging (default) or production api server. This will help us catch bugs on server api before, we deploy that to production.
Note: This PR is not testable locally.
Fixed Issues

$ https://github.com/Expensify/App/issues/10163
Test (Web & Desktop)

Open app on web
Go to Settings -> Preference
Verify that Use staging server switch in on by default
Open dev tool
Go to Network tab.
Focus on app and send some message.
Verify that the request in Fetch/XHR is of staging server https://staging.expensify.com or https://staging-secure.expensify.com.
Focus on app and toggle the switch Use staging server (it should be off)
Send some message and verify that Fetch/XHR is of production server (without staging prefixes) https://www.expensify.com or https://secure.expensify.com.

[x] Verify that no errors appear in the JS console

Tests (excluding Web & Desktop)

Open app on web
Go to Settings -> Preference
Verify that Use staging server switch in on by default
Verify that you can toggle the switch

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps (Web & Desktop)

Open app on web
Go to Settings -> Preference
Verify that Use staging server switch in on by default
Open dev tool
Go to Network tab.
Focus on app and send some message.
Verify that the request in Fetch/XHR is of staging server https://staging.expensify.com or https://staging-secure.expensify.com.
Focus on app and toggle the switch Use staging server (it should be off)
Send some message and verify that Fetch/XHR is of production server (without staging prefixes) https://www.expensify.com or https://secure.expensify.com.

[x] Verify that no errors appear in the JS console

QA Steps (excluding Web & Desktop)

Open app on web
Go to Settings -> Preference
Verify that Use staging server switch in on by default
Verify that you can toggle the switch

[x] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/77761491/188264047-a980f6a3-b108-4fed-894d-ebbde9e9bff3.mp4
Mobile Web

https://user-images.githubusercontent.com/77761491/188264040-642936bd-7d5f-4172-be5f-df994b9b3b82.mp4
Desktop

https://user-images.githubusercontent.com/77761491/188365690-6710b543-6c7b-44f0-8d6f-5c69976e9958.mp4
iOS

https://user-images.githubusercontent.com/77761491/188264016-d9c9bc7d-e02b-4f8c-9a42-746db3ecb3e7.mp4
Android

https://user-images.githubusercontent.com/77761491/188263941-87bfe360-aca3-4476-8af6-ffb3c4261f4f.mp4

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the `### Fixed Issues` section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the `Tests` section
[x] I verified the steps for Staging and/or Production testing are in the `QA steps` section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all `src/languages/*` files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in `STYLE.md`) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a `/** comment above it */`
[x] Any functional components have the `displayName` property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to `this` properly so there are no scoping issues (i.e. for `onClick={this.submit}` the method `this.submit` should be bound to `this` in the constructor)
[x] Any internal methods bound to `this` are necessary to be bound (i.e. avoid `this.submit = this.submit.bind(this);` if `this.submit` is never passed to a component event handler like `onClick`)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. `StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG`)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

😓 that was hard

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


[FEATURE] Add vGPU support for multi-accelerators

Is your feature request related to a problem? Please describe.
Add vGPU support for different accelerators(e.g., GPU, NPU, TPU) to maximize the device usage while providing consistent UX.
Describe the solution you'd like
Integrate solutions like https://project-hami.io/ and volcano scheduler.
Describe alternatives you've considered

Additional context

Added https://github.com/llmos-ai/llmos-gpu-stack

Verified and passed using v0.2.0-rc5:
LLMOS GPU Stack

[x] The llmos-gpu-stack is enabled by default, and all components are running correctly.

vGPU Support

[x] Create a Notebook or Model Service with vGPU enabled:

In the Resources tab, select Nvidia GPU as the accelerator and check the Enable vGPU option. Set the vGPU memory and cores as needed, e.g., 4096 for vGPU memory.

Click Create and wait for the workload to become ready.
Once the workload is ready, click on Execute Shell and run nvidia-smi to verify the GPU resource allocation and confirm the memory size is correct.


Lab 5 Question

I am a little confused on this lab. Although I was able to compile the CBL0007J file with no errors, I still don't understand why the original source code would not be able to compile without errors. The only thing I did to get a no-error compile was remove the END-IF terminator at the end of the paragraph in question. That being said, documentation says that IF statements are explicitly terminated by using END-IF. What am I missing here?
Many thanks.

Explicit means being verbose about something. Implicit means omitting something because that something is expected or obvious.
If you notice, there is an implicit termination
       IS-STATE-VIRGINIA.
           IF USA-STATE = 'Virginia' THEN
              ADD 1 TO VIRGINIA-CLIENTS. <---- here, the period
           END-IF.

But, the compiler doesn't know what you want to achieve. For the compiler the implicit termination is enough, so it complains that the it END-IF is not necessary.
There are two ways of resolving that compiler error:

You decide to use the implicit terminator (period is a sentence terminator that implicitly terminates IF
You decide to use the explicit terminator (END-IF, so you should remove the period at the end of previous line). END-IF  is an explicit terminator, but it is only valid with a period END-IF.

Ah...Totally missed the period sign. That's exactly what I needed to know. Thanks!

@pineconeman09 - My advice, get rid of ALL unnecessary periods.  They are just not necessary any more.  And, more good advice for those starting out:

There should only be 2 periods per paragraph, 1 at the end of the paragraph name, and 1 on a blank line of its own at the end of the paragraph.
Always use GOBACK instead of STOP-RUN.
No need to use PERFORM THRU or EXIT paragraphs.
No need to use GOTOs.  Use an IF statement and CONTINUE to check the (88-level) value of LASTREC to conditionally execute the PERFORM.  Or, since you will only use 1 period within a paragraph, NEXT SENTENCE will take you to the end of the paragraph.
A READ or WRITE paragraph should be limited to just a READ of a file or WRITE of a record. Optionally, one group MOVE statement.  The purpose of this type of paragraph is to be versatile enough to be able to perform it multiple times from different parts/areas of your program.
Never use NOT or only in very obvious, simple usage.


Modal Popup Position Error

I'm submitting a ...

[x] bug report

[ ] feature

[ ] question about the decisions made in the repository

[ ] question about how to use this project

Summary

When user is logged out and try to log in via the kit on mobile, its modal's position is off

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

@jeesunikim is there a public preview with that one? I need to see how the kit is attaching the modal to the DOM in order to be able to fix it

@earrietadev here you go http://laboratory-pr1080.previews.kube001.services.stellar-ops.com/

@jeesunikim the new version v1.2.3 should fix this issue, let me know if is ok now

works great. thanks


SOLR-15973: Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

Fixed in 0b18725ea29185c6af981943ab1471624f71b260

@thelabdude this doesn't apply to branch_8_11 at least not in the current form. The TestSchemaDesignerConfigSetHelper#testDownloadAndZip issue was only introduced on main. The ConfigSetsHandler is pretty different on branch_8_11 so not sure the same change is needed.


light-client: Replace Io with async variant

Individual commits are significant please review accordingly.
Closes #953
Supersedes #965

[x] Referenced an issue explaining the need for the change
[x] Updated all relevant documentation in docs
[x] Updated all code comments where relevant
[ ] Wrote tests
[x] Added entry in .changelog/

:<

Welcome back @xla :slightly_smiling_face:
CI was failing and there were multiple conflicts - please address those and I'll review.

@thanethomson  Can we re-open this and bring it across the finish line for the next major version of tendermint-rs (or the one after that)? Happy to help with that :)

I'd be happy to reopen this, and @romac some help here would be greatly appreciated :slightly_smiling_face:

@romac @thanethomson Updated and fixed.

Any ideas why the kvstore integration test keeps hanging and timing out?

Any ideas why the kvstore integration test keeps hanging and timing out?

Addressed. You can't just go a little bit async and even worse trying to mix sync and async. The issue was that I naively was hoping to leave the supervisor handle untouched, but the crossbeam implementation when blocking on recv starves the current thread and therefore has a good chance of locking the async runtime.
@thanethomson The model based test fail for nightly, but I can't figure out why, any ideas?

The model based test fail for nightly, but I can't figure out why, any ideas?

Took another look through your code now and I can't see anything obvious contributing to the MBT failures, which means I'll need to spend a little more time digging. Will get back to you ASAP.

I re-ran the nightly coverage test here and it passed, so it was nondeterministic :nauseated_face: Hopefully #1121 fixes that.

I re-ran the nightly coverage test here and it passed, so it was nondeterministic 🤢 Hopefully #1121 fixes that.

Great, thanks for looking into it. Will resolve the conflicts.


[WIP] Add metrics for rules per template variety to Mixer

PoC PR for adding metrics to enable detection of policy/telemetry rules via Mixer metrics.
Meant solely to facilitate discussion of options around policy enablement.
Example output:
# HELP mixer_dispatcher_rules_per_variety_total Number Mixer rules by template variety type
# TYPE mixer_dispatcher_rules_per_variety_total gauge
mixer_dispatcher_rules_per_variety_total{variety="TEMPLATE_VARIETY_CHECK"} 2
mixer_dispatcher_rules_per_variety_total{variety="TEMPLATE_VARIETY_QUOTA"} 1
mixer_dispatcher_rules_per_variety_total{variety="TEMPLATE_VARIETY_REPORT"} 2

/hold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fe9278d8abf5f0769aa0b9f91a2f4e62040516d2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fe9278d8abf5f0769aa0b9f91a2f4e62040516d2
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
fe9278d8abf5f0769aa0b9f91a2f4e62040516d2
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fe9278d8abf5f0769aa0b9f91a2f4e62040516d2
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
fe9278d8abf5f0769aa0b9f91a2f4e62040516d2
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
fe9278d8abf5f0769aa0b9f91a2f4e62040516d2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Problem: catkin is a required build dependency

Solution: make it optional
Background: I'm building control software for a scientific instrument and I wanted to use your serial library. It's compiled inside a Docker using a Fedora base image. I tried to dnf install catkin and I couldn't get cmake to find catkin after messing around with ros' environment scripts and such. And catkin is completely irrelevant to what I'm doing, so I just made it an optional build dependency (on by default).

Closing this PR because I just saw that #111 and #123 already have better solutions for this problem and it seems you're not convinced to make catkin optional yet.
However, I would strongly advise this, as many others like me have found it frustrating having to install catkin to use this wonderful library :)


Upload failed on 3E5 data points

Is one of the format rules that the dataset needs to have fewer rows than a certain threshold, or is this 3E5 dummy_input dataset improperly formatted?

could you attach the csv that fails?

there isn't any row restriction

I changed the extension to .txt so that GitHub would accept it
dummy-input-length-3e+05.txt


Image Cropping

PLIP (Plone Improvement Proposal)

Responsible Persons
Proposer:
Seconder:
Abstract

Motivation

Assumptions

Proposal & Implementation

Deliverables

Risks

Participants

Maybe relevant: https://github.com/mbarde/volto-image-crop-widget


Local monaco editor

By default, the monaco-react package utilizes CDN to download the Monaco Editor files. This PR adds a loader as advised in the package docs to be able to use an editor locally without internet access.
Resolves #109

@trean, the autocomplete feature is not working as expected.

Those icons are not loading properly!

@kartik-gupta-ij Can not reproduce. Could you please give steps to reproduce this problem?

@trean, the autocomplete feature is not working as expected.

Thanks for the check, fixed.

Those icons are not loading properly!

@kartik-gupta-ij Can not reproduce. Could you please give steps to reproduce this problem?

It's fixed, there was some issue with the node module


Error "Resource 'azurerm_lb.vault_access' not found for variable 'azurerm_lb.vault_access.id'" when setting up Vault without load balancer

I'm trying to deploy Vault cluster with load balancer turned OFF. So I changed associate_public_ip_address_load_balancer to false (at https://github.com/hashicorp/terraform-azurerm-vault/blob/master/main.tf#L109).
When I run terraform apply I got an error
* module.vault_servers.azurerm_lb_probe.vault_probe: 1 error(s) occurred:
* module.vault_servers.azurerm_lb_probe.vault_probe: Resource 'azurerm_lb.vault_access' not found for variable 'azurerm_lb.vault_access.id'

Here is the fix for the issue ^


Update Scala and sbt versions

Coverage remained the same at 46.513% when pulling d482cbab7ff85de4af7d5429caf9abf088618d23 on sbtVersion into d732fb04f4f0386e07f3af1170bc8b10831f853e on master.


Unbind dropdown bound events on clean

Fixes #491, by overriding clean to unbind the event bindings done on none-view elements in the constructor.

@javisantana @xavijam can you review, please?

:jp: finally taking care of the bug, thanks!


Wrong displayed number of stored items

Issue description:
In the modpack that I am playing (Dungeons Dragons and Space Shuttles) I am having a problem with my RefinedStorage system, namely that the number to indicate the amount of a certain Item is way higher than the ammount that is actually stored.
What happens:
Sometimes a certain Item (like 64 redstone) when deposited in the rs system will at some point in time show that there are 200 redstone in the system, I can only remove 64 of it (the items that are really there) but after that it still shows that there are 136 Redstone in the system. This has happenen to multiple items in my rs system now, and it seems to occur randomly (does not need to be 64), increased the displayed number of items by a random value (or at least it seems like that) and once occured it stays in the system permanently (At least to my current knowledge).
What you expected to happen:
For this not to occur.
Steps to reproduce:
1.Put some items in system
2.wait for random chance
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>38
Refined Storage: 1.6.15
Modpack Version (Just in case) : 5.5a

Does this issue occur on a server? [yes/no]
yes, it occurs on a self hosted server with 2 (3max) persons online

Do you happen to have that redstone stored via external storage?

No, there is no external storage connected, only one importer for inferium (from mystical aggriculture). It is also not only happening with redstone but with allmost every item in the system, even ones I only have one of. Also the number it displays seems to be somewhat related to the original itemcount (when I put in 1 it will, if the bug occurs jump to 193, and when I take the real item out it will still show 192 items but I cant take any of them). The issue also occurs on a new independant refinedstorage system with only one grid, drive and controller next to each other. Taking a disk from the old system to the new test one still shows a wrong number on most items even if they arent in the system anymore. So far reconnecting the drives, rebuilding the controller and so forth did not fix this issue, but so far none of the "real" items have dissappeared or any new appeared (Only fake ones that I cant take out of the system)

Closing this, as the issue has been resolved. There were some disks with identical ids in the network probably either due to jei or by duplicating drives in creative with disks inside them (ctrl+middle mouse button). It would probably be possible to refuse working when there are 2 disks with the same id in the system, or delete (or change the id) of all but one if them. Why the nonexistant items didn't vanish from the system even after the original (real) items were removed is probably due to a logic/timing issue.


upload config file for data retention

Type of PR

Code changes
CI-CD changes

Purpose
Data Retention - add configuration file as part of the deployment steps
Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[x] No PII in logs
[ ] Made corresponding changes to the documentation

Validation steps

run the deploy.sh script and verify that the configuration file has been uploaded

Issues Closed or Referenced

Closes #581

because the pipeline will read with the M

The code is working well, beyond the comments I left there is one thing missing - probably you need to allow the MSI to read the config container and file, because the pipeline will read with the MSI. The MSI name is available as the WS name during the deployment, is just a matter of add it to the container and file (probably you will need to use the ACL CLI that we were discussing on the stand-up. Let me know if you have questions! And thank YOU!

There is already a role assignment as Storage Contributor to the Synapse worskpace MSI for the storage account where the config container lives, that should be enough I guess unless you want something else? note that you as a user won't have access to the container if that was your concern, in that case I can grant read access but I guess it would be better if end users don't have access to the config so we remove the possibility that they would not tamper with data lake ACLs?


Does logo only support .png format?

It seems that it is not working with .svg file.

Never mind. I modified the code in the Plugin.js to make it work with .svg files. It worked fine after the modification.

#43 implements support for any image (svg, png, etc.) as a logo.