Set apparmor annotation in PSPs

Why is this PR needed?
Apparmor profiles are currently not set in PSPs
Fixes bsc#114297
Anything else a reviewer needs to know?

To test using a different profile with the privileged PSP, I've created a profile on the node localhost/xtest-lcavajani and added this to a Deployment:
      annotations:
        container.apparmor.security.beta.kubernetes.io/nginx: localhost/xtest-lcavajani

When using a serviceAccount which is not allowed to use suse:caasp:psp:privileged, the pods are forbidden to start:

Error creating: pods "nginx-deployment-7dc89f955b-" is forbidden: unable to validate against any pod security policy: [pod.metadata.annotations[container.apparmor.security.beta.kubernetes.io/nginx]: Forbidden: localhost/xtest-lcavajani is not an allowed profile. Allowed values: "runtime/default"]

When using a serviceAccount which is allowed to use suse:caasp:psp:privileged, the pods start correctly with the following annotations:

  annotations:
    container.apparmor.security.beta.kubernetes.io/nginx: localhost/xtest-lcavajani
    kubernetes.io/psp: suse.caasp.psp.privileged
    seccomp.security.alpha.kubernetes.io/pod: runtime/default

and the correct apparmor profile is apply on the processes
3 processes are in enforce mode.
   /usr/sbin/nginx (10545) xtest-lcavajani
   /usr/sbin/nginx (10566) xtest-lcavajani
   /usr/sbin/nginx (10591) xtest-lcavajani
0 processes are in complain mode.
0 processes are unconfined but have a profile defined.

Signed-off-by: lcavajani<EMAIL_ADDRESS>

I forgot to add them when I enabled apparmor, I was sure they were already there...

@lcavajani If possible, add a document on explaining default runtime/default AppArmor rule, what it's allowed and denied.


Issue: Integration tests failing due to connection...

Description:
When attempting to run integration tests using the provided command, the tests fail with a connection error. The integration tests utilize ClickHouse for database operations, and the error indicates a failure to connect to localhost:9000. However, it is observed that accessing http://localhost:9000/ directly works as expected, indicating that the port is accessible.
Archive.zip
Steps to Reproduce:

extract content of Archive.zip to a folder with name FOLDERNAME
open terminal in FOLDERNAME
run "docker compose build"
run "docker compose up"
open docker exec of FOLDERNAME-airflow-webserver-1
run "python3 -m unittest discover -t tests -s unit" => works
run "docker run -p 9000:9000 --ulimit nofile=262144:262144 -it clickhouse/clickhouse-server" in normal terminal
run "PYTHONPATH=src AIRFLOW_CONN_CLICKHOUSE_DEFAULT=clickhouse://localhost python3 -m unittest discover -t tests -s integration" in docker exec

Actual Behavior:
Integration tests fail with the following error message:
[2024-02-09T18:20:29.196+0000] {base.py:83} INFO - Using connection ID 'clickhouse_default' for task execution.
[2024-02-09T18:20:29.197+0000] {clickhouse.py:79} INFO - SELECT sum(value) * %(multiplier)s AS output FROM ext with {'multiplier': 2}
[2024-02-09T18:20:29.201+0000] {connection.py:407} WARNING - Failed to connect to localhost:9000
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 395, in connect
return self._init_connection(host, port)
File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 325, in _init_connection
self.socket = self._create_socket(host, port)
File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 297, in _create_socket
raise err
File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 288, in _create_socket
sock.connect(sa)
OSError: [Errno 99] Cannot assign requested address
Environment:
Operating System: macOS Sonoma Version 14.3.1
Python Version: 3.8
ClickHouse Version: latest
Airflow Version: 2.8.1
This adjustment will ensure consistency and reliability in running integration tests against ClickHouse databases.

also tried ClickHouse Version
ClickHouse client version <IP_ADDRESS> (official build).
Connecting to localhost:9000 as user default.
Connected to ClickHouse server version 23.12.4.
Actual Behavior: Then:
(airflow)python3 -m unittest discover -t tests -s unit
.[2024-02-10T01:01:58.905+0000] {crypto.py:82} WARNING - empty cryptography key - values will not be stored encrypted.
[2024-02-10T01:01:58.906+0000] {clickhouse.py:79} INFO - SELECT 1 with [('test-param', 1)]
[2024-02-10T01:01:58.906+0000] {clickhouse.py:79} INFO - SELECT 2 with [('test-param', 1)]
.[2024-02-10T01:01:58.908+0000] {clickhouse.py:79} INFO - SELECT 1
............/opt/airflow/tests/unit/sensors/test_clickhouse.py:82 DeprecationWarning: Please use assertRaisesRegex instead.
...
----------------------------------------------------------------------
Ran 17 tests in 0.208s

OK
(airflow)PYTHONPATH=src AIRFLOW_CONN_CLICKHOUSE_DEFAULT=clickhouse://localhost python3 -m unittest discover -t tests -s integration
[2024-02-10T01:02:12.432+0000] {base.py:83} INFO - Using connection ID 'clickhouse_default' for task execution.
[2024-02-10T01:02:12.433+0000] {clickhouse.py:79} INFO - SELECT sum(value) * %(multiplier)s AS output FROM ext with {'multiplier': 2}
[2024-02-10T01:02:12.434+0000] {connection.py:407} WARNING - Failed to connect to localhost:9000
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 395, in connect
    return self._init_connection(host, port)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 325, in _init_connection
    self.socket = self._create_socket(host, port)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 297, in _create_socket
    raise err
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 288, in _create_socket
    sock.connect(sa)
OSError: [Errno 99] Cannot assign requested address
E[2024-02-10T01:02:12.436+0000] {base.py:83} INFO - Using connection ID 'clickhouse_default' for task execution.
[2024-02-10T01:02:12.436+0000] {sql.py:450} INFO - Running statement:
                SELECT number * %(multiplier)s AS output
                FROM system.numbers
                LIMIT 1 OFFSET 1
            , parameters: {'multiplier': 2}
[2024-02-10T01:02:12.436+0000] {connection.py:407} WARNING - Failed to connect to localhost:9000
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 395, in connect
    return self._init_connection(host, port)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 325, in _init_connection
    self.socket = self._create_socket(host, port)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 297, in _create_socket
    raise err
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 288, in _create_socket
    sock.connect(sa)
OSError: [Errno 99] Cannot assign requested address
E
======================================================================
ERROR: test_execute (integration.hooks.test_clickhouse.ClickHouseHookTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/airflow/tests/integration/hooks/test_clickhouse.py", line 8, in test_execute
    return_value = ClickHouseHook().execute(
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow_clickhouse_plugin/hooks/clickhouse.py", line 80, in execute
    last_result = conn.execute(
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/client.py", line 361, in execute
    with self.disconnect_on_error(query, settings):
  File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/client.py", line 305, in disconnect_on_error
    self.establish_connection(settings)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/client.py", line 292, in establish_connection
    self.connection.force_connect()
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 254, in force_connect
    self.connect()
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 416, in connect
    raise err
clickhouse_driver.errors.NetworkError: Code: 210. Cannot assign requested address (localhost:9000)

======================================================================
ERROR: test_get_records (integration.hooks.test_clickhouse_dbapi.ClickHouseDbApiHookTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/dbapi/cursor.py", line 111, in execute
    response = execute(
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/client.py", line 361, in execute
    with self.disconnect_on_error(query, settings):
  File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/client.py", line 305, in disconnect_on_error
    self.establish_connection(settings)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/client.py", line 292, in establish_connection
    self.connection.force_connect()
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 254, in force_connect
    self.connect()
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/connection.py", line 416, in connect
    raise err
clickhouse_driver.errors.NetworkError: Code: 210. Cannot assign requested address (localhost:9000)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/airflow/tests/integration/hooks/test_clickhouse_dbapi.py", line 8, in test_get_records
    records = ClickHouseDbApiHook().get_records(
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/providers/common/sql/hooks/sql.py", line 261, in get_records
    return self.run(sql=sql, parameters=parameters, handler=fetch_all_handler)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/providers/common/sql/hooks/sql.py", line 398, in run
    self._run_command(cur, sql_statement, parameters)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/providers/common/sql/hooks/sql.py", line 453, in _run_command
    cur.execute(sql_statement, parameters)
  File "/home/airflow/.local/lib/python3.8/site-packages/clickhouse_driver/dbapi/cursor.py", line 117, in execute
    raise OperationalError(orig)
clickhouse_driver.dbapi.errors.OperationalError: Code: 210. Cannot assign requested address (localhost:9000)

----------------------------------------------------------------------
Ran 2 tests in 0.317s

FAILED (errors=2)

a simple python env with clickhouse-driver works just fine. see https://github.com/mymarilyn/clickhouse-driver/issues/415

use 'clickhouse://localhost:9000'


Incomplete analysis on contact sample

Description
Mythril returns a false negative for a contract sample that contains an Ether withdrawal flaw. The reason appears to be that symbolic execution does not complete. With max-transaction-count set to 5, execution finishes very quickly achieves only 72.52% coverage.
Code:
contract Mapping {
    struct Participant {
        uint total_paid;
        uint payout;
    }

    mapping(address => Participant) participants;

    function deposit(address beneficiary) public payable {
        var b = participants[beneficiary];
        b.total_paid += msg.value;
        b.payout += msg.value / 2;
    }

    function remove(uint amount, address beneficiary) public {
        var b = participants[beneficiary];
        require(b.payout > 0);
        require(b.total_paid > 0);
        b.payout -= amount;
    }

    function withdraw() public {
        var p = participants[msg.sender];
        require(p.payout > 1 ether);
        msg.sender.transfer(p.payout);
        p.payout = 0;
    }

}

How to Reproduce
$ myth -mether_thief --strategy bfs -t4 -x mapping.sol -v1
root[18309] INFO Using INFURA for RPC queries
root[18309] INFO LASER EVM initialized with dynamic loader: <mythril.support.loader.DynLoader object at 0x10ee8dd30>
root[18309] INFO Found 0 detection modules
root[18309] INFO Starting contract creation transaction
root[18309] INFO Finished contract creation, found 1 open states
root[18309] INFO Starting message call transaction, iteration: 0
root[18309] INFO Number of new instructions covered in tx 0: 256
root[18309] INFO Starting message call transaction, iteration: 1
root[18309] INFO Number of new instructions covered in tx 1: 0
root[18309] INFO Starting message call transaction, iteration: 2
root[18309] INFO Number of new instructions covered in tx 2: 0
root[18309] INFO Starting message call transaction, iteration: 3
root[18309] INFO Number of new instructions covered in tx 3: 0
root[18309] INFO Finished symbolic execution
root[18309] INFO 83 nodes, 82 edges, 1055 total states
root[18309] INFO Achieved 72.52% coverage for code:<PHONE_NUMBER>60043610610057576000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff1680633ccfd60b1461005c5780639dfa4e9414610073578063f340fa01146100c0575b600080fd5b34801561006857600080fd5b506100716100f6565b005b34801561007f57600080fd5b506100be60048036038101908080359060200190929190803573ffffffffffffffffffffffffffffffffffffffff1690602001909291905050506101aa565b005b6100f4600480360381019080803573ffffffffffffffffffffffffffffffffffffffff169060200190929190505050610229565b005b60008060003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000209050670de0b6b3a7640000816001015411151561015257600080fd5b3373ffffffffffffffffffffffffffffffffffffffff166108fc82600101549081150290604051600060405180830381858888f1935050505015801561019c573d6000803e3d6000fd5b506000816001018190555050565b60008060008373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000209050600081600101541115156101ff57600080fd5b6000816000015411151561021257600080fd5b828160010160008282540392505081905550505050565b60008060008373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001908152602001600020905034816000016000828254019250508190555060023481151561028957fe5b04816001016000828254019250508190555050505600a165627a7a72305820066ff86ae6ea2df89af55ca8464d90d499c8d6907839150738ecbf1ca0f2817d0029
root[18309] INFO Starting analysis
root[18309] INFO Found 1 detection modules
root[18309] INFO Executing Ether Thief
The analysis was completed successfully. No issues were detected.

Expected behavior
An Ether withdrawal issue should be reported in the function withdraw().
Environment

Mythril version: develop
Solidity compiler and version: 0.4.24+commit.e67f0147.Darwin.appleclang
Python version: 3.6.4
OS and Version: Mac OS Mojave

This might be because of the way the storage is handled currently.
in tx 1 to deposit:
consider F() to do all the address mapping.
storage[F(caller1)] = msg.value
in tx2 it will be
require(storage[F(caller2)] > 0) and here F(caller2) is considered as a different key in the map than F(caller1) so storage[F(caller2)] returns 0.


kconfig: use SOL_PLATFORM_LINUX to check if it's linux

Dorileo, please check if it's the expected behaviour.
Instead of using SYSTEMD || MICROLINUX, or even SOCKET_LINUX
Using such approaches were leaving dummy without many stuff,
including tools.
Signed-off-by: Bruno Dilly<EMAIL_ADDRESS>

merged, thanks


Fix parse error when a comment was inside a string

When parsing "/* hey */" a comment was seen just after the first ".
So the goal here is to fix that.

I wonder if it'd be better to add exceptions to extras.
For example:
extras_exception: [$.comment, [$.string, ...]] to say "don't check for comment when in the string state"
I think it'd be a more useful feature than this patch :)
@maxbrunsfeld Wdyt ?

Or another possibility would be to be able to get the current state from the scanner and if state == string_literal then return false when in the block_comment stuff.

Yeah, you can do that. You can allow the external scanner to check for the validity of a (non-external) token by adding that token to the externals list. So in this case, you could do this:
externals: $ => [
  // existing externals ...
  $.escape_sequence
]

Then, in the external scanner you can do this:
enum TokenType {
  // existing external tokens ...

  ESCAPE_SEQUENCE,
};

bool tree_sitter_rust_external_scanner_scan(void *payload, TSLexer *lexer,
const bool *valid_symbols) {

  // other scanner code ...

  // do not parse comments inside of strings
  if (!valid_symbols[ESCAPE_SEQUENCE]) {
    if (lexer->lookahead == '/') {
      // scan comment ...
    }
  }
}

@maxbrunsfeld thx it's working well.

Thanks!


Typo in common/multiprocessing_utils.py line 156

Hi,
there's an error in file common/multiprocessing_utils.py in line 156, obviously you wanted to type mp.cpu_count() instead of np.cpu_count(). I found it when trying your notebook accumulated_local_effect_tutorial.ipynb.
Many thanks for the upgrade. By the way, the version number of the PyPi packet is incorrectly set to 0.0.5.
Regards,
Jörg.

Thanks for the catch! I've fixed the typo. and where is the version number set to 0.0.5?

After installing via PyPi, i.e.,
python3 -m pip install scikit-explain

the version number is set wrong in skexplain/__init__.py: __version__ = '0.0.5'
It seems, the error is in in the git repo in skexplain/__init__.py.
Regards,
Jörg.

I've updated that the version number in that file.


fix PUKs to be also available in v2 form

cc: @zapu

Looks like it fixes id issue with test user. Thanks!


when change the width for table head,can not copy the value in all page

element ui
when use the el-table and sortablejs ,when draged the width of the table header(th),can not copy the value of all page

I also encountered this problem.

when draged the width of the table header(th), In addition to it, I can not drag other th

请问解决了吗


Meeting Notes: Week11 Meeting15

To Do

Take notes during the meeting.
Create the wiki page .
Add links to Sidebar and Homepage.

Deadline
12.05.2022 17.00

I wrote the notes of our 15th meeting and added to our Wiki Home page and to the sidebar.


Resizing LV2 in Carla doesn't change the canvas size

I've tested the plug-in in Carla today and resizing does't seem to work.
I can resize the window, but the plug-in still redraws only the same area of it, leaving the rest with garbage.

Carla is not letting the plugin know about the resize.
puglReshape not called, but working in Jalv
@falkTX, perhaps you have an idea of why that is?

Interestingly Wolf Spectrum does resize correctly in Carla (it does not in Ardour though).

Right thats' because Patrick cheated it, he implements his custom resize handle.
This issue is with WM-managed resizing.

I think this is an issue with LV2 in general. I don't know about VST3, but LV2 plug-ins have issues with resizing all the time.
Maybe we're lacking some standardized way of communicating this?

Highly doubtful, I'll dig in Carla later to check what really happens

Ok it comes down to this, an unimplemented in DPF
return 1; // This needs more testing
For reference https://github.com/DISTRHO/DPF/blob/89cbdbba5320c8f8822885b510307bef0c7a428f/distrho/src/DistrhoUILV2.cpp#L509-L510

resizing has been a problematic thing in dpf (partially because of pugl)
I am reworking the dgl/graphics stuff in dpf right now, which should fix this situation but will take some time until it is complete.
You can follow the (re)work at https://github.com/DISTRHO/DPF/commits/pugl-upstream-v2
But not much to see at this point.

Is this still an issue ?


Sorting on one property and displaying another feels hacky.

If I want to sort on a person's name but show a composite output of their other attributes, am I forced to select the desired sort value with the accessor and dig the person out of the row object?
Example of my column config object:
accessor: 'person.name',
render: ({ row: { person: { age, gender, name } } }) => (

{name}

{age}

{gender}

)

This works just fine but feels a little hacky. If there is a cleaner way to do this I'm all ears, I have only just picked up this library this week.
Maybe a sortValue attribute would allow the differentiation between the accessor choosing the value for the cell to render and the value that is passed into the sorting algorithm.
It might look something like this and would possibly be more easily understood:
accessor: 'person',
sortValue: 'name',
render: ({ value: { age, gender, name } }) => (

{name}

{age}

{gender}

)

Many many thanks for all the awesome work here! 😄

First off, thanks for using React Table!
Great to see it help people.
The api decisions your referring to were carefully made when I initially built the component and actually help to solve the scenario you are describing.  It happens very frequently.
When using string accessors, it may feel like more work to get at your values, and it very well may be.
To alleviate this, you can use functions for just about anything (including accessors), so you could easily factor out any repetition of nested paths if you feel it gets too monotonous:
const fromPerson = prop => row => row.person[prop]
// ...
const columnDef = {
  accessor: fromPerson('name')
  ...
}

The goal of the component api is make as little assumptions as necessary to allow for greater customization and a wide range of use. Although what your suggesting would absolutely be more a shorter path for your situation, it would limit others who rely on the more flexible api.


add vendored pkgs, for faster brew install and docker build

Issues

Changelog
Ran go mod vendor and added vendor/

[X] List your changes here
[ ] Make a changie entry, N/A no real change to code

Tophatting

This is madness


-3T flag option

recon-all for freesurfer has a -3T flag (https://surfer.nmr.mgh.harvard.edu/fswiki/OtherUsefulFlags) that you can pass to the command. It enables freesurfer to do intensity corrections that create more accurate segmentations for 3T scans.
I've added the option to pass in [--3T {true, false}] to the docker image (default is true). If true, recon-all will run with the -3T flag added to the command.

Brilliant idea. -3T is now conditionally added to input_args

Thank you for your contribution!


'subl' alias for Sublime Text doesn't open the file or folder specified

The alias for subl in osx.aliases.bash:
alias subl='open -a Sublime\ Text --args'

doesn't open the file or folder specified when used from terminal using Sublime Text 3.
Removing --args seems to do the trick, though it might make more sense to point to /Applications/Sublime Text.app/Contents/SharedSupport/bin/subl
Happy to make a PR with the change if the issue is widespread and people think it's worthwhile

Can't comment, since I'm not using Sublime...
Is the args parameter something that was used in Sublime Text 2? Not sure how widely used each version is and whether it makes sense to include a check for the version before defining the alias.
Happy to discuss...

the --args option is part of Darwin's open and is in fact the issue here.
calling open -a "Sublime Text" my_directory opens my_directory in Sublime as it is supposed to.

Thanks - PR welcome.

Tiny PR is up

Closed in #904


Edit: Fuse East

Channel ID (required)
FuseEast.us
Channel Name
Backstage
Alternative Names (optional)
No response
Network
No response
Owners
No response
Country
US
Subdivision
No response
City
No response
Broadcast Area
No response
Languages
eng
Categories
No response
NSFW
No response
Launched
No response
Closed
No response
Replaced By
Backstage.us
Website
https://www.fuse.tv/v/fuse-backstage/a4068154335cc15ab055a34979c5e1c4
Logo
https://image.xumo.com/v1/channels/channel/99991303/600x337.jpg?type=channelTile
Notes
No response

Backstage added in https://github.com/iptv-org/database/commit/dc7c36cfef479d41d1ec8b4afbdc94bdb5c9a730
To fix the description of a particular stream you need to change it tvg-id to Backstage.us:
https://github.com/iptv-org/iptv/blob/master/streams/us_xumo.m3u#L66-L67


Flutter web

Hello ,
How do you use it on flutter web . Dart io neither path is available on flutter web .
Could you help please ?

Yep, currently the upload depends on filePath and MultipartFile.fromFile(filePath) which depends on dart:io... I have to improve that to support uploading from bytes.

How much time would you need to implement it as my customer asking for this solution , i can tip you if necessary .
Regards,

Done, in this commit a139f67 I added support for uploading a file as byte array... I also changed some things in the uploadFile(...) function params so a breaking was necessary... I currently pushed a v2.0.0+5 to pub.dev


File log plugin log file location

Reading http://getkong.org/plugins/file-log/ I couldn't find the path of the "Kong Log File".
Also shouldn't this be configurable? I didn't find anything in the kong.yml that is not inside the nginx block, which does have an enabled access log, so kong is always writing to a log file at  /usr/local/kong/logs/access.log even without this plugin enabled.

From my searches, the log will simply be your_nginx_working_directory/logs/error.log since the plugin only logs stuff using nginx's ngx.log method.

It should probably be made note of on the plugins page.

Closed: http://getkong.org/plugins/file-log/


End-to-end test of notifications

test: When an administrator creates a notification using using the admin interface, a notification is sent to all the subscriptions
setup:

a user with a subscription (fake subscription data)
an admin (superuser staff member is fine)

test:

configure django_q to be in synchronous mode
mock webpush url

create a subscription using admin interface
check that the webpush URL was called

One option: mock http server
subscription localhost:1234, Djang admin -> Django Q -HTTP-> Push service http://localhost:1234
was localhost:1234 called?
Other option: mock pywebpush


zpool cache not respected by opnsense

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at  https://github.com/opnsense/src/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/src/issues?q=is%3Aissue

Describe the bug
zpools other than zroot present in zpool cache (/etc/zfs/zpool.cache or /boot/zfs/zpool.cache) are not imported at boot time in OPNsense 24.1.9.
To Reproduce
Steps to reproduce the behavior:

Access command line of device and get a root shell.
Create a new zpool.
Export the zpool (zpool export )
Import the zpool (zpool import )
Verify the zpool exists in zpool cache (zdb -U /etc/zfs/zpool.cache)
Reboot the system.
When the system is back up, access the command line and check if the new zpool was imported (zpool list).  Notice only zroot exists.

Expected behavior
Upon reboot, the newly created zpool was imported.
Describe alternatives you considered
It is possible to manually import the zpool using zpool import after the reboot, but this doesn't really scale.
I was able to get the pool to import as expected by adding zfs_enable="YES" to /etc/rc.conf which allowed /etc/rc.d/zfs to start at boot per expectations.  I notice opnsense sets this variable in /usr/local/etc/rc.loader.d/20-zfs, perhaps this variable isn't making it to freebsd's rc.d?
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.1.9

The code you may want to improve is this:
https://github.com/opnsense/core/blob/0f73da02ad205aba1be2d7928c72fb8805b34eb4/src/etc/rc#L153-L160
Do not confuse _load with _enable vars. we don’t use the RC subsystems that much as they tend to interfere.

Adding -c CACHE_FILE to the referenced zpool import and removing changes to /etc/rc.conf fixes my issue.  However, I'm fairly certain that adding additional pools worked in a previous release of OPNSense with no changes.
The behavior of  zpool import -a changed when OpenZFS was adopted in FreeBSD 13.  In prior releases, -a would default to searching for pools in /dev:
https://github.com/freebsd/freebsd-src/blob/b5ad6b488d9e62d820fe90fdce4aee4f4d3d7162/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c#L2634
This changes in OpenZFS, used in 13+, the environment variable ZPOOL_IMPORT_PATH is used as the search path:
https://github.com/freebsd/freebsd-src/blob/5fe9c9de03ef3191d216964bc4d8e427d5ed5720/sys/contrib/openzfs/cmd/zpool/zpool_main.c#L3492

Thanks for looking into this. Feel free to provide a PR, but I won't be able to review and commit in the next two weeks.

(I'd say that ZPOOL_IMPORT_PATH might be the better path forward as I've avoided -c in the past for portability.)

I'll open a PR to fix this this evening.  I can work around this issue for now, so no rush on the review.

I will propose a change that imports pools from zpool cache at boot (just like vanilla FreeBSD) rather than allowing the implementation of zpool import to dictate what's imported.
Pros of using zpool cache

It's explicit, fstab like behavior.
Consistency across reboots, the system boots with the same pools it had at shutdown.
Prevents importing potentially problematic pools that are connected to the system, but have never been successfully imported.
On appliances, may help deter/prevent tampering with root fs.

Cons of using zpool cache

The existence and purpose of zpool cache does not appear to be widely known or extensively documented.  This may surprise some people.
Boot behavior is changing.  The end user may see a change in available pools after booting this release (easily resolved by importing missing pools and exporting those that shouldn't be there).
The cache file should be present in every existing install.  If, for any reason, the cache file is missing, the system will not boot properly.
The path of the cachefile could change in future FreeBSD/OpenZFS releases (which would require a fix to rc).

Experiment is 701dff45b2f, likely in 24.7.2.

Adding here for reference - this did not go particularly well for some users (as in - unbootable box due to kernel panic) and I'm wondering in which other corner cases this will rear its ugly head.
https://forum.opnsense.org/index.php?topic=42373.msg209269#msg209269
https://forum.opnsense.org/index.php?topic=42387.msg209391#msg209391

I'm not sure about the second one. I'm happy to debug this. Though the peripheral nature of leading into panics is a bit astonishing. I still don't know why zpool-import -a doesn't consider looking for devices to be part of "-a". That seems like a harmful oversight.

Well,  guess I'm out of this race. In hunt for the most vintage HW, I found this Fujitsu server but that one has ATI ES1000 32MB RAM PCI on board and no AGP slot. 😢 😭
And yeah, I'm also absolutely puzzled as what does zpool import have to do with AGP graphics.

It’s a working theory. I don’t mind reverting if necessary but we also need to reproduce this remotely without fatalities. In theory we can install the 24.7.1 debug kernel in a working 24.7.1 and then do a tainted zpool import to get a vmcore….

Meh, OK - the AGP theory is apparently confirmed. Even set hint.agp.0.disabled=1 in loader prompt got some people back into bootable system 1, 2)

Good idea with the device hints helping people to overcome this manually.


Update VS for Mac product feedback DevCommunity ID

Maybe their is a reason to keep it general?

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mac/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

This might be the correct URL since it's for the VS for Mac topics. @asb3993 and @jdanyow can you comment on this please?

I'm happy to change this to a more specific area. I think it makes more sense!


Canonical way of updating a Vertex via case class

While there is an easy way to add vertices based on case classes (via +[CC]), a simple, "canonical"  method of persisting vertex changes via the same route seems to be absent - since addVertex is intended solely for addition.
A quick & dirty solution can be something like the following (pseudocode) :
val savedCc: CC = graph.+[CC](newCc)

val modifiedCc: CC = modify(savedCc) //where modify changes some fields
val m = implicitly[Marshallable[CC]]

for(
    vertex <- graph.V(savedCc.id.get).headOption;
    (k, v) <- m.fromCC(modifiedCc).valueMap
) {
   vertex.property(k, v)
}

However, this is hardly ideal.
Is there a better way to do perform a "case-classed" update in gremlin-scala (if so, it should probably be more documented)? If not, do you consider this kind of functionality worth adding to the API?

Interesting point. No, there's currently no better way, but it might make sense to add it, e.g. as a separate method graph.update(Id, CC), and the implementation would be similar to what you've provided there.
The downside is obviously that we don't really know which fields were actually updated and have to update all of them, but in sake of simplicity that would be fine IMO. Thoughts? Would you like to draft a PR?

Thanks for the reply. Regarding the downside, well, since we're already extracting the existing node, we might be tempted to e.g. compare on equality, but I don't really see the point of this, so I agree just changing everything would be fine.
I'll gladly cook up a PR (probably early next week). I'm still on the fence whether this should be a method of ScalaGraph or e.g. ScalaVertex, I'll play around and see how it works.

I'm still somewhat unsatisfied with the solution I've provided. It's fine for scenarios where you are syncing your DB with some other data source (and hence already have a CC instance on hand), but it's clunky when you wish to simply modify a vertex.
So, I'd like to additionally introduce something like this:
def updateAs[CC](f: CC => CC): Vertex
(the name could also be simply update)
One could argue that's it duplicates the functionality of setProperty, but transformation of case classes is so idiomatic in the Scala ecosystem I'd say a method like the above will add value.
What do you think?

I'm still somewhat unsatisfied with the solution I've provided. It's fine for scenarios where you are syncing your DB with some other data source (and hence already have a CC instance on hand), but it's clunky when you wish to simply modify a vertex.
So, I'd like to additionally introduce something like this:
def updateAs[CC](f: CC => CC): Vertex
(the name could also be simply update)
One could argue that's it duplicates the functionality of setProperty, but transformation of case classes is so idiomatic in the Scala ecosystem I'd say a method like the above will add value.
@mpollmeier: what do you think?

That's a great idea, I like it!

I've just offered you collaborator access for this repo as well :)

@mpollmeier : excellent, glad you like it!
Re collab - thanks, appreciate it very much :). Any guidelines on collaboration , or should I just commit to master/feature branches at own discretion?

Also, I'll expand this issue to include edges as well, since otherwise there'd be divergent APIs for basically the same functionality.

sounds great.
Re collaboration: I should have clarified beforehand: please never commit to master directly, unless it's something trivial (e.g. 46f4711 was fine). Always push a feature branch and open a PR so others have a chance to look. All commits you added look fine, i.e. PR is approved retrospectively :)

Arghh, got a little ahead of myself, haven't I? Sorry! Glad to hear present changes are OKd.


Add PHPStan

Add PHPStan
Closes: #1930
Fixes will be added with another PR to keep everything simple as possible.

Codecov Report

Merging #2253 (350d4d0) into master (e16794d) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 350d4d0 differs from pull request most recent head 5094a11. Consider uploading reports for the commit 5094a11 to get more accurate results

@@            Coverage Diff            @@
##             master    #2253   +/-   ##
=========================================
  Coverage     87.12%   87.12%
  Complexity      670      670
=========================================
  Files            33       33
  Lines          1584     1584
=========================================
  Hits           1380     1380
  Misses          204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16794d...5094a11. Read the comment docs.

Resolve conflicts, please


operators [N] gitops-primer (0.0.1)

Updates to existing Operators

[X ] Did you create a ci.yaml file according to the update instructions?
[X ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[X ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[X ] Have you tested an update to your Operator when deployed via OLM?
[X ] Is your submission signed?

/CC @jmontleon

/LGTM

/merge possible


Raw input disabled is not working properly

Describe the bug
Raw input disabled is not working properly
To Reproduce
Steps to reproduce the behavior:

To make the api request by using POST methods via RAW INPUT.
Checking the POST api results, it should works as expected.
Now disable the RAW INPUT and will make the GET Request.
Still RAW INPUTS are passing in GET methods and even if RAW INPUTS disabled also.
Please fix this issue.

Expected behavior
If RAW INPUTS is disabled, it should not pass in API request
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [Ubuntu16.04]
Browser [Chrome]
Version []

Still RAW INPUTS are passing in GET methods and even if RAW INPUTS disabled also.
Please fix this issue.

I couldn't reproduce this issue. GET doesn't pass raw payload in request.

@liyasthomas can you tried the above reproduce steps.
It is simple ,
you add some raw data in POST method and just on/off the raw input after that you will change method as GET method, now you will check above request parmas.

That's a feature. Actually when you disable the raw input or changed to any other method, payload is stored to the app's state so it could be used next time.
Think of this as: You send a POST request with some payload and have to check it's GET response. So you switched to GET and send another request. Now, if we clear the POST payload, you've to again type in all payload again since it's not in app's memory. This is why payload is preserved for using next time.
Don't worry GET request won't send payload. It's just save in your localStorage.


Cassandra 15665 trunk 15666

Circle-CI

rebased and applied review feedback. CI Running: https://circleci.com/workflow-run/947320b4-3c52-4113-91ab-36d622a45e23


train coed

first of all thanks for your implementation.
I want to train from scratch octconv.
So could you share train code?

refer to https://github.com/d-li14/mobilenetv2.pytorch/blob/master/imagenet.py


Alpha fade in/out different in 2.2.3 from 2.1

I am using tween.js from sole to animate.  I animate the creation of sprites with a fade in, alpha running from [0..1] using the tween update function.  In pixi 2.1 the fade in is smooth but in 2.2.3, I get a series of blinks and then it looks as if there is a fade out.  x, y transition is smooth like in 2.1.
Am I doing something wrong here?  I am using a DisplayObjectContainer.  Interestingly, the blinking behavior on the fade transition was something I saw in 2.1 when I tried to use a SpriteBatch.  Now it looks like DisplayObjectContainers also have the same behavior in 2.2.3.

I suspect the tween.update isn't running in sync with the renderer. Incidentally why are you using tween.js? Given that Phaser has a tween manager built-in that is tween.js!

I'm just using pixi.js, not Phaser.  Don't need input for this particular
application, just a renderer.
tween based alpha fades worked with Pixi 2.1 and not at 2.2.3.  Tween is
using RAF to run the tweening engine.  Is that incorrect?
On Wed, Jan 21, 2015 at 10:05 PM, Richard Davey<EMAIL_ADDRESS>wrote:

I suspect the tween.update isn't running in sync with the renderer.
Incidentally why are you using tween.js? Given that Phaser has a tween
manager built-in that is tween.js!
—
Reply to this email directly or view it on GitHub
https://github.com/photonstorm/phaser/issues/1554#issuecomment-70975745.

If you're just using Pixi then report this in the Pixi repo.


mp4 with video

some mp4 link come with video ,
can you plz add the ability to the user that he can watch the video ,
it will be very powerfull

Video is outside the scope of this project.


[Designer] Adaptive Card Auto Scroll in Teams

Hi guys,
When a user clicks on an action.showcard , it outputs more options below in the Teams chat. However, upon click, a user would need to scroll down to see the other options. Can we set this to auto scroll?
Similar issue seen in a different host app here
https://github.com/microsoft/BotFramework-WebChat/issues/470

This issue has been copied over to Microsoft Teams repo here: https://github.com/MicrosoftDocs/msteams-docs/issues/8247


[ML] Add a pylint pre-commit check

Description
This PR adds a pylint step to the azure-ai-ml pre-commit config, to enable faster feedback of pylint issues. It tries to ensure that the version of pylint and azure-pylint-guidelines-checker matches the one used in our CI (this needs to be manually synced).
This pre-commit step does not replace or otherwise supersede our CI.
Background
This implementation is based on instructions on pylint's documentation: https://pylint.readthedocs.io/en/latest/user_guide/installation/pre-commit-integration.html
This was re-written as an inline python script, to ensure that the correct version of pylint and azure-pylint-guidelines-checker are installed.
This would ideally be replaced with an invocation of tox (e.g. tox -e pylint) once:

The pylint tox environment accepts positional arguments
The usability improvements described in this issue are addressed

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


Enable the status subresource.

This fixes #32.
Signed-off-by: James Peach<EMAIL_ADDRESS>

@jpeach I'd like to bump my kubebuilder to v0.3.0 and test before tagging this PR. Otherwise, feel free to remove the kubebuilder bump and resubmit.

@jpeach I'd like to bump my kubebuilder to v0.3.0 and test before tagging this PR. Otherwise, feel free to remove the kubebuilder bump and resubmit.

I removed the kubebuilder version.


feat: destroy, unmount

When the animation-mounted component is destroyed, the corresponding variables such as parents, mutations, resize, and timers are not cleared, which will cause memory leaks. Therefore, add a destroy method to autoAnimate, which is called when the component is destroyed. Memory leak related information is as follows:

Memory keeps rising as page routing switches

@pyongchen did you want to make the changes shown in the review?


Show bank value for tag tabs

Hi, now since the new tags system have been released, i would hear if it would be possible to show the bank value of the specific new "tagstabs" - and if it is possible for the tabs to collapse so it would look like a normal bank tab?

No and no, it is search and not tabs


AMP on centos/redhat

We should support amp on rhel OS family.
Biggest issue right now is node_exporter service , which mounts root fs inside of container.
And that brings fs namespace leakage. https://github.com/moby/moby/issues/34198
We should introduce flag for amp CLI to disable root FS volume mounting in node_exporter.
Also amp agent should detect centos/redhat OS in docker info and disable root FS mounting too.
Only newest RedHat 7.4 kernel with kernel setting works for now
echo 1 > /proc/sys/fs/may_detach_mounts

CentOS 7.4 to be releases soon and tested.
So we choose to disable root FS mounting and tolerate loss of disk usage metrics in monitoring for now.
CLI flag should have priority versus amp agent detection mechanism.

the situation looks better since 17.09, the may_detach_mounts setting is enabled by Docker: https://github.com/moby/moby/pull/34886


Issue in Generating release notes

I'm trying to generate the release notes using a release. I created a new release pipeline.
I have not created any tags in the work items. I committed the code to master branch adding a workitem. but not file is generated. and I tried to create a branch from master and created a pull request to master branch with adding workitem. but file was not generated.
my template is like this:
#Release notes for release $defname
Release Number  : $($testreleasenotes.name)
Release completed $("{0:dd/MM/yy HH:mm:ss}" -f [datetime]$testreleasenotes.modifiedOn)
Associated work items
@@WILOOP@@

${widetail.fields['System.WorkItemType']} #${widetail.id} Assigned by: ${widetail.fields['System.AssignedTo']} - ${widetail.fields['System.Title']}
@@WILOOP@@

please help me to resolve the issue

The screenshot of the log says it has generated a file, with no associate WI/CS/Builds, but it should at least have a header with the release details.
A few things

Set a variable system.debug=true this will provide more detailed logs for my task and any other
Check the log for the copy task to make sure it is finding copying you file to thelocation you expect
Given the working folder is d:\a\_work\r1 am I right in assuming this is a Microsoft hosted agent? If so why are you copying the release notes file to the agent C: drive, when you have no access to this.?  You need to copy the file to a location off the agent e.g. send an email, upload to a WIKI etc.
An alternative is to try on a private agent, you will have access to the generate file without an upload

Let me know how it goes

Thanks for the reply.
My requirement is
every developer is working in their own feature/dev branch and send the pull request to release branch for that month ex: rel2020.05. But they are not used to associate the work item to the pull request or their development branch, when they send the pull request. they miss it. So at the end of every month, I want to merge release branch to master and give the release to customer. When I give the release to customer I want to prepare the release note. That should include all completed work items  that developers work for that month. but please keep in mind, I have no commits or PRs asscociated with work items. I manually copying all wok items to atlassian wiki/confluence page. I want to automate this process.
You think header should print. but where should I add the reference for "testreleasenotes" in $testreleasenotes.name? Is that inbuilt name or a tag or anything else? I have not added that(testreleasenotes) to any where as a reference.
My expectation of copy task is to copy the file from $(System.DefaultWorkingDirectory)/ReleaseNotes.md to my local c drive, to make sure the file is generated with data.please suggest me once the file is generated with data, how can I see the data.
copy file log is [2020-05-15T16:19:39.3713748Z found 0 files]. but no different
I added variable and trigger the release

I don't think these tasks work the way you think.
My release notes tasks uses the Azure DevOps api to find work items and commits associated with a build and hence a release. If your developers don't make work item associations with their commits you are not going to get any auto generated notes.
I don't think it cannot replace a manual process where you copy from jira. You need to get the developers to associate work items. So an Azure Devops  usage change for your team
As to copying files to your local disk, the copy task only copies between locations on the build host. It could only copy a location on your local disk if the agents is running on your local PC

Thank you for your reply. I associated some wok items with commits and pull requests to make this work done. Even those work items, I could not generate the release notes, what's wrong with it? Please help me on creating release notes with your release notes behavior. Please verify my release artifacts and properties.and how I see the results or the file from my local machine without sending email?

I have had another look at the screenshot of the non-debug log you sent  and notice that it says the artifact type [Git].
So am I right in assuming that the only artifact your release is associated with a a Git repo?
If so this task will not do what you require. It can only generate release notes based on an Azure DevOps Pipeline builds (either UI or YAML based) being run. This is because you have to run a build to get the basic data required. This task looks for changes in associated commits and work items BETWEEN BUILDS, in exactly the same way as the Azure DevOps UI. So if the Azure DevOps release UI shows no associations neither will my task.
Bottom line is it can get no commit or WI details if associated only with a Git or TFVC repo.

Hello, @rfennell I'm facing a similar problem.
I understand your point about we need related WI to generate a Release Notes.
But in my case, I have several artifacts, and some of them don't have this association. I'm trying to generate  HTML but it prints a lot of 'None' in the body:

I'm trying to find a way to skip the loop when it's empty, maybe it can be an option, but if you have some idea to solve this I'll appreciate it.

@wesleycamargo with the legacy template you can't skip rows in the loop. However in the advanced option you can alter the text for empty rows from 'none' to something else including an empty string, do nothing is printed.
You have more options if you use the newer handlebars based templates as this allows if statement to be put inside the loops to give more control

@rfennell I followed your suggestion to change 'None' for empty text and it works fine.
Thank you and congratulations on this excellent task!

As per my standard practice I am closing this issue as I have heard nothing for a while. If this issue remains a problem please do not hesitate to re-open it


SILCloner and SILInliner rewrite.

This can only be reviewed by first reading the new version of
SILCloner.h, SILInliner.h as a whole, along with the SILInlineCloner
class definition in SILInliner.cpp. The diff points out the code that
needs review but can't meaningfully be reviewed by itself.
This is not a from-scratch rewrite. I attempted to make minimal
changes to most existing SILCloner clients/subclasses--they can be
cleaned up separately. Note that I did need to rewrite SILInliner in
this PR because it so deeply violated SILCloner encapsulation.
This is a large PR, but it was already extracted from a much broader
set of changes and I don't see a meaningful way to further subdivide it.

Mostly functionally neutral:

may fix latent bugs.
may reduce useless basic blocks after inlining.

This rewrite encapsulates the cloner's internal state, providing a
clean API for the CRTP subclasses. The subclasses are rewritten to use
the exposed API and extension points. This makes it much easier to
understand, work with, and extend SIL cloners, which are central to
many optimization passes. Basic SIL invariants are now clearly
expressed and enforced. There is no longer a intricate dance between
multiple levels of subclasses operating on underlying low-level data
structures. All of the logic needed to keep the original SIL in a
consistent state is contained within the SILCloner itself. Subclasses
only need to be responsible for their own modifications.
The immediate motiviation is to make CFG updates self-contained so
that SIL remains in a valid state. This will allow the removal of
critical edge splitting hacks and will allow general SIL utilities to
take advantage of the fact that we don't allow critical edges.
This rewrite establishes a simple principal that should be followed
everywhere: aside from the primitive mutation APIs on SIL data types,
each SIL utility is responsibile for leaving SIL in a valid state and
the logic for doing so should exist in one central location.
This includes, for example:

Generating a valid CFG, splitting edges if needed.
Returning a valid instruction iterator if any instructions are removed.
Updating dominance.
Updating SSA (block arguments).

(Dominance info and SSA properties are fundamental to SIL verification).
LoopInfo is also somewhat fundamental to SIL, and should generally be
updated, but it isn't required.
This also fixes some latent bugs related to iterator invalidation in
recursivelyDeleteTriviallyDeadInstructions and SILInliner. Note that
the SILModule deletion callback should be avoided. It can be useful as
a simple cache invalidation mechanism, but it is otherwise bug prone,
too limited to be very useful, and basically bad design. Utilities
that mutate should return a valid instruction iterator and provide
their own deletion callbacks.

More lines were added in this PR as a result of many more comments,
wrapper APIs, and boilerplate from moving SILInlineCloner into a .cpp
file (there's less header code now). The implementation
complexity is reduced though, as seen in SILInliner.h:
https://github.com/apple/swift/pull/19786/files#diff-6d61a780d665cd7f48ea545e72acd155L39
And in various SILCLoner extensions:
https://github.com/apple/swift/pull/19786/files#diff-30c46611e101cad3560c1db8ef4820faL776
https://github.com/apple/swift/pull/19786/files#diff-1e2e4ad366d990a0934bd3d8dc405983L1558
https://github.com/apple/swift/pull/19786/files#diff-1e2e4ad366d990a0934bd3d8dc405983L1593
https://github.com/apple/swift/pull/19786/files#diff-1e2e4ad366d990a0934bd3d8dc405983L1770
https://github.com/apple/swift/pull/19786/files#diff-21f77672a667d0107c40f530af4d4860L70

@swift-ci test.

@swift-ci test source compatibility.

@swift-ci benchmark.

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayAppendAsciiSubstring
28165
30592
+8.6%
0.92x

Improvement

Array2D
7505
6908
-8.0%
1.09x

MapReduce
397
368
-7.3%
1.08x

MapReduceAnyCollection
398
369
-7.3%
1.08x (?)

How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

FYI the debug source compatibility failure in ‘fluent’ is a known declaration checker but not related to this PR

@swift-ci test.

@swift-ci test.


check edit rights in controller and template

@OskarStark this code is only valid if working with Sonata Admin

yes, but you extend this class ```use Sonata\AdminBundle\Controller\CRUDController;````
so i'd say this is a SonataAdmin Bundle, isn't it?

and you used this:
$id     = $this->get('request')->get($this->admin->getIdParameter());

my bad then, I have done this a long time ago and did not remember I was extending the SonataAdmin controller.
Let's keep it as it is then.

and thanks for all the changes

that is open source :smile:
like your bundle, and it works great with sonata


help: Update suggested text for linking to Zulip.

Current: https://github.com/alya/zulip/pull/new/linking
Updated:

Merged, thanks @alya!


[BUG] Failed to populate metadata on 72 samples. Use dataset.exists("metadata", False) to retrieve them

Does anyone know why I faced this error: [BUG] Failed to populate metadata on 72 samples. Use dataset.exists("metadata", False) to retrieve them while calculating evaluate_detections?
Computing metadata...
100% |█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 72/72 [791.6ms elapsed, 0s remaining, 91.0 samples/s]
Failed to populate metadata on 72 samples. Use dataset.exists("metadata", False) to retrieve them
{
'samples_count': 72,
'samples_bytes': 510162,
'samples_size': '498.2KB',
'media_bytes': 0,
'media_size': '0.0B',
'total_bytes': 510162,
'total_size': '498.2KB',
}
Failed to populate metadata on 72 samples. Use dataset.exists("metadata", False) to retrieve them
Threshold: 0.5
Evaluating detections...
100% |█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 72/72 [1.8s elapsed, 0s remaining, 40.7 samples/s]
precision    recall  f1-score   support
 flashed       0.00      1.00      0.00         1

contaminated       0.00      1.00      0.00         1
micro avg       0.00      1.00      0.00         2
macro avg       0.00      1.00      0.00         2
weighted avg       0.00      1.00      0.00         2

Another question is that this problem also causes 0 in precision.

Have you inspected view = dataset.exists("metadata", False) to see what the problem is? For example, the image paths could be nonexistent.
This error is coming from dataset.compute_metadata(), which is internally used to populate things like image dimensions, which are necessary for certain evaluation computations. You could try directly running that a second time to see if those images are still unable to be processed.

Yeah, the image paths do not exist but that should not be affecting the evaluation computations right? As it only needs bboxes from ground-truth and prediction.

The evaluation protocols need information about absolute image dimensions for certain things. The labels themselves are stored in FO as relative values, so the metadata field either needs to be prepopulated with ImageMetadata instances, or the images need to exist on disk so that dataset.compute_metadata() can populate this data on-the-fly.

@brimoor  So what you meant is that image paths are a prerequisite to calculating precision|recall|f1 correctly?

Actually I'm confused. What code are you running exactly? This works perfectly fine with non-existent filepaths:
import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart")

dataset.set_values("filepath", ["bad.jpg"] * len(dataset))

results = dataset.evaluate_detections(
    "predictions",
    gt_field="ground_truth",
    eval_key="eval",
    compute_mAP=True,
)

Hi,
It is true that the code can be run with non-existent filepaths. But during its running, there is an warning/error saying Failed to populate metadata on 72 samples. Use dataset.exists("metadata", False) to retrieve them. And the calculated metric results are not correct, precision/recall/f1. I am not sure it is because of the warning/error above or something else that causes the problem.


add ukrainian greeting

@arrterian this PR is quite old and seems to have gotten messed up, but the goal, i.e. 'add ukrainian greeting' is a really good one IMO, so how about you close this and open a new one?  That's much more likely to get merged when @ostera (🔔🔔) gets around to it ;)

@bl-ue done in #170

Perfect.  Now just close this one.


Use the YNAB component to hide the help button

Github Issue (if applicable): #1264
Explanation of Bugfix/Feature/Modification:
The #hs-beacon now has a hard coded display: block on the element. We could use !important but I opted to just swap to use JS for this feature since it should be more fail-proof. Also we'll now always generate the hide/show help button based off the state of the HS-beacon. Before, we'd show the text based of the state of the world but we would only do what local storage said we should.

I am still experiencing this problem.

@woodnboats This fix has not yet made it to the live version of the extension.

Thanks, Josh. Sorry to be impatient.
Kirk
On Wed, Apr 11, 2018 at 1:44 PM, Josh Madewell<EMAIL_ADDRESS>wrote:

@woodnboats https://github.com/woodnboats This fix has not yet made it
to the live version of the extension.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1265#issuecomment-380572940,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfNLAmDzhK0KTO5n3hEM2zGhVnzuAdo7ks5tnl0TgaJpZM4TKRtz
.

@woodnboats This should be fixed now in our latest release!

That did it.
Thanks for your continuing good work.
Kirk
On Fri, Apr 13, 2018 at 10:25 AM, Josh Madewell<EMAIL_ADDRESS>wrote:

@woodnboats https://github.com/woodnboats This should be fixed now in
our latest release!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1265#issuecomment-381188902,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfNLAne5-GJJxGKhjeUlyrE1tyuX3Vmdks5toNGIgaJpZM4TKRtz
.


An error occurred while installing saxon-xslt (0.7.2), and Bundler cannot continue

I am working on an open source project (https://github.com/archivesspace/archivesspace) that is used by folks on both linux and windows machines and have been trying to build releases on a windows machine. Apparently, even though I have installed the saxon-xslt gem on the machine, with I run my bundler, it can’t be found. We have recently upgraded to JRuby 9.x and I was wondering, since you are not testing JRuby 9 with travis, that there might be some sort of an issue there.
I am using ant and bundler to install all the required gems but am getting these error messages:
[java] Installing saxon-xslt 0.7.2
[java]
[java] Errno::ESRCH: No such process - No message available
 [java] An error occurred while installing saxon-xslt (0.7.2), and Bundler cannot
 [java] continue.
 [java] Make sure that `gem install saxon-xslt -v '0.7.2'` succeeds before bundling.

However, I know I have saxon-xslt installed:
$ gem list
did_you_mean (default: 1.0.1)
jar-dependencies (default: 0.3.10)
jruby-openssl (default: 0.9.20 java)
jruby-readline (default: 1.1.1 java)
jruby-win32ole (0.8.5)
json (default: 1.8.3 java)
minitest (default: 5.4.1)
net-telnet (default: 0.1.1)
power_assert (default: 0.2.3)
psych (default: 2.2.4 java)
rake (default: 10.4.2)
rdoc (default: 4.2.0)
saxon-xslt (0.7.2 java)
test-unit (default: 3.1.1)
Any help would be greatly appreciated!

I'm trying to understand how your project actually deals with gems. I can see references to Bundler and a Gemfile in the startup scripts, and in the Ant build.xml but it's not clear from your output which part of the build task is failing. There are several Gemfiles in different bits of your project, but only the one in /backend has any reference to saxon-xslt. If I look at output from your Travis builds I can see it being installed there
(https://travis-ci.org/archivesspace/archivesspace/jobs/304037916#L1965)
I'm a complete ignoramus about Ant, unfortunately, but from reading the invocation instructions inside your startup scripts I can see several references to overriding $GEM_HOME, which makes me think that your locally-installed gems might be ignored in favour of whatever gets installed by your build process.
I'll set up a Windows VM and see if I get the same results I'll start by trying the instructions at http://archivesspace.github.io/archivesspace/user/archivesspace-build-system/

@fidothe I am new to Ant as well, but I see what you mean about the gem-home being overwritten. I have been wanted to dig into our build process for a while. This seems like an excellent opportunity to do just that. I don't have this problem when building on a mac - so hopefully that is a clue to point me in the correct direction.

I had a similar issue with my install. This issue maybe a little old, but comes up first on the search result. So I am posting my solution here.
Error:
[java] An error occurred while installing saxon-xslt (0.8.0), and Bundler cannot
[java] continue.

Cause:
Mine turned out be an issue with the character limit for fully qualified path of a file in Windows. Windows restricts it to 260 characters.
In saxon-xslt gem, there is an YML file that is 7 or 8 directories deep. So the fully qualified path for that particular file ended up being over the limit.
The offending file:
C:\Users\XXXXXX\development\aspace\archivesspace\build\gems\gems\saxon-xslt-0.8.0-java\spec\fixtures\cassettes\Saxon_SourceHelper\returning_a_StreamSource\StreamSource_systemId\for_inputs_where_we_can_infer_the_path_or_URI\is_set_to_an_open-uri_d_URI_s_URI.yml
Solution:
So I moved my archivesspace directory to root of C: driv., and the bundler process succeeded.

Ah, that's fascinating. Not least because those fixtures are supposed to be excluded from the gem package. I'll fix that and let's see if that fixes these install problems

@lmcglohon @cdesai-qi i've cut new releases <IP_ADDRESS> and <IP_ADDRESS> that don't have those super-long paths in the .gem anymore. Can you try building on windows again and see if that's fixed?

My test install of ArchivesSpace on Windows now completes successfully, whereas before it didn't. I'm going to call this one fixed.

Thanks again @cdesai-qi - i'd have been chasing my tail on this for months without your help!

Hey @fidothe! Sorry for the late response.  I did test <IP_ADDRESS> a few days ago. I did not see any issues related to filepath in Windows.  Thank you for putting out a new release.


Refactor: simplify config arg attributes for keep_unsnapshoted_log

Changelog
Refactor: simplify config arg attributes for keep_unsnapshoted_log

This change is

@ClSlaid

Looks good to me, but document comments should be slightly changed.
"set this flag to true" -> "apply this flag".


Confusing language in "Background on the problem environment"

In this bullet/paragraph:

IT administrators are more willing to run their own internal authentication and authorization servers, but want to use off the shelf software and want the option to outsource these services. They are more likely to separate authentication from authorization than end user systems. Authentication issues are closely related to HR activities like hiring and firing. Authorization issues are related to patient and work assignments. These are controlled by different parts of the organization and have different process dependencies.

... I have bolded the sentence "They are more likely to separate authentication from authorization than end user systems" to show it in context.
Should this sentence be "They are more likely to separate authentication from authorization for (or with) end user systems"?
If not, please explain what this sentence is intended to convey, and I'll help clarify the wording.

I took this sentence from the working versions when I started to work on IUA. I'm also not happy with the statements at all. Maybe we can remove it? This should be discussed in the meeting this week.

I'll remove the bullet point, since it is not clear what the statement actually means.


Add remember me checkbox to the login page!!!

Description ->
The remember checkbox is added to the login page which accepts cookies for up to 30 days and remembers the username for this amount of time. Once the checkbox is checked the username details will be saved and the user will be logged in even if the website is reopened. The credentials are not be mentioned again n again.

How Has This Been Tested?
By closing the browser and reopening it and still the user is logged in. On the website the inspect option shows that the cookie saves the username only when the checkbox is checked.

Screenshots :)
When the chechbox is not checked!

When the checkbox is checked!

Type of Change

[ ] Bug fix
[true] New feature
[ ] Code style update
[ ] Breaking change
[ ] Documentation update

Resolve the conflicts and send a video for this. I wanna see how it functions

Any updates ?

Closing as no updates


feat(quick-links): Add POC LinkTree/Bitly template for showing quick links

Issue
Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-821
Description
New

This PR adds a new template and blocks for showcasing quick links.
This is a POC (proof of concept) to quickly leverage Franklin as a means to create helpful links pages that can be used by marketers in conference/event booths. Allowing customers/users to quickly scan the QR code to access helpful links within their mobile devices.
NOTE: The design of this template is not finalized. I just put together a layout in code to showcase what the different products will look like in their own branding color and pattern.

Design Specs

Figma Link - No design specs

Micromedex - Quick Links

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/quick-links/micromedex
After (Changes from this PR): https://feat-quicklinks-poc--merative2--proeung.hlx.page/quick-links/micromedex

Health Insights - Quick Links

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/quick-links/health-insights
After (Changes from this PR): https://feat-quicklinks-poc--merative2--proeung.hlx.page/quick-links/health-insights

Testing Instruction

Visit the preview links above and ensure that the CTA test links are functioning correctly.

@aavilamer I just followed up with Erin Fortuna and Caroline Muse to see if there are any upcoming events this template will be good to test out.
In the meantime, I'm going to merge the changes in this PR so that this feature is available for production usage and avoid code merge conflicts. If there are additional changes such as updating the footer patterns, etc. I'll open up a follow-up PR.


Cannot install local version

Command
build
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
After a clean install of the forked repo, the clean install is ok (with yarn command). Then the build is ok... I suppose (it doesn't prompt me any error with the yarn build --local command). But then, when I try to install this local version on a new Angular project (with npm install -D ../angular-cli/dist/*.tgz command), it prompts me this error:

And then, if I edit the packages/angular/pwa/package.json file and change "@angular/cli": "^16.0.0 || ^16.1.0-next.0" to "@angular/cli": "^16.0.0", the local build is OK, but when I try the local build installation again on the angular project:

Something's wrong but dunno what it is... It must be pretty easy make a local build with my changes, what I'm doing wrong?
Angular project package.json, just in case:
{
  "name": "angular-test",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "watch": "ng build --watch --configuration development",
    "test": "ng test"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^16.0.0",
    "@angular/common": "^16.0.0",
    "@angular/compiler": "^16.0.0",
    "@angular/core": "^16.0.0",
    "@angular/forms": "^16.0.0",
    "@angular/platform-browser": "^16.0.0",
    "@angular/platform-browser-dynamic": "^16.0.0",
    "@angular/router": "^16.0.0",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.13.0"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^16.0.0",
    "@angular/cli": "~16.0.0",
    "@angular/compiler-cli": "^16.0.0",
    "@types/jasmine": "~4.3.0",
    "jasmine-core": "~4.6.0",
    "karma": "~6.4.0",
    "karma-chrome-launcher": "~3.2.0",
    "karma-coverage": "~2.2.0",
    "karma-jasmine": "~5.1.0",
    "karma-jasmine-html-reporter": "~2.0.0",
    "typescript": "~5.0.2"
  }
}

Regards for the help!

No response

You will have to use --force when installing using NPM, as the local packages have version 0.0.0 which does not satisfy the peer dependency versions that are included in the package.json file of the locally built packages.

What result does npm install -D ../angular-cli/dist/*.tgz have in the package.json? The error shows a path starting with C:\c\users, which incorrectly duplicates the drive letter.
From within the Angular CLI repo directory, you can link the locally built packages into another package using ng-dev:
yarn ng-dev misc build-and-link ../other-project-root

Keep in mind though that this is using Yarn, not NPM.

There is no changes on package.json after npm install -D ../angular-cli/dist/*.tgz (because of the error I suppose). If I try the yarn ng-dev misc build-and-link ../other-project-root, the pacakges links correctly, but when I try to a ng serve:

I see another related issue , and tried:
node --preserve-symlinks node_modules/.bin/ng s
set BAZEL_TARGET="1" && node --preserve-symlinks "node_modules/.bin/ng" s
set BAZEL_TARGET="1" && node --preserve-symlinks<EMAIL_ADDRESS>s
But nothing works...


add blue and red Swordsmachine variants

red when named agony, blue when named tundra

actually, let's go full on and make them behave like in the original (heal each other)


'float' object cannot be interpreted as an integer [BUG]

To Reproduce
python tools/vqgan/inference.py -i "test.wav"

Can you attach the full traceback?

I have no idea, please double check dependency version, or check docker container.

我跟你一樣是報這個錯，可以嘗試改一下這個參數
trainer.precision=bf16-mixed
我是改完之後就正常了

Fixed


fix: Errors in allOf behaviour

I discovered some issues with the handling of allOf, this should fix them!

Fixing the e2e errors now...

@dbanty ready for review now, it would be great if we can get this in the next release!

I think merging #361 made main conflict with your branch 😬 sorry about that. Please pull in the changes and resolve the conflicts when you get a chance.

Ok this is much simpler now! That previous PR fixed a lot of my issues, and I decided not to bother with full-on merging of allOf schemas because it's a bit of an edge case. However I've kept the old branch in case we ever want to resurrect it.
I might have another PR for you later this week to fix an issue with multipart introduced by another recent PR... might be good to get them both in the next release if possible.
PS Thanks for this library, it's lovely :)

@dbanty Now rebased


Component not rendering at all

The following code is not rendering anything at all
<DraggableFlatList             data={['a', 'b', 'c']}             renderItem={({ item }) => (               <Text>{item}</Text>             )}             keyExtractor={item => item}             scrollPercent={5}           />

@computerjazz

I have the same issue over here, It renders a blank screen

Hey I figured it out, after giving the DraggableFlatList a fixed height everything is rendering fine.

I am facing the same issue. Everything renders fine when I use FlatList but the moment I replace FlatList with DraggableFlatList, it shows a blank screen. Even tried setting the height as mentioned by @cjinghong but no use.

I think if DraggableFlatList is wrapped in a View, that View needs specific dimensions (height/width) or flex:1 in it's style. At least that's what worked for me when nothing rendered.


Test integration of GitHub Actions from Chip's branch since I'm being blocked from committing

No longer needed since I was able to get past the Capital One environment to push my GitHub actions work


Translation: string templating, plurals and so on

Hello,
I've see a bunch of examples where a sentence is split into smaller parts and there is some dynamic value in between.
An example of this are time_ strings. I assume this ends up as 2 [hours][s] 5 [minutes][s] [ago]. For Bulgarian, the ago should be in front while the words for hours and minutes have different endings for their plural form. Needless to say, this will be a problem in other languages.
One way to do it would be to have a string for plural and one for singular and finally a template {hours} {minutes} {seconds} ago. Or you could have a template for all possible combination. Valve does that sometimes. There are lots of other examples where a sentence is split up and would make translation difficult to impossible.

Yeah, I was worried about this.  We can put template strings in the string file perhaps, or bring in a library like https://github.com/yahoo/react-intl

I can't offer any suggestion as I'm not familiar with React and it's ecosystem. I imagine there would be a library that solves the problem elegantly.

Does "${Dire Mid Ranged} ${Barracks}" exhibit this same problem?
If it does, I suppose the solution would be to have a separate string defined for barracks and tower

Those combinations can be problematic depending on language. It makes sense to do programmatically in order to reuse stuff, but problematic. Valve simply adds a string-token for each permutation. There is also a lot of duplication for some same thing used in different places. I think that makes sense, because it forces programmers to write simple code, and then any translation details can be solved by just changing the tokens.


Need a new version to adapt to assemblyscript 0.20

Feel free to open a PR.  I currently don't have the time to update it.  I think visitor-as is the first place to start.


Overhaul: Notes + Docs

@JoelHobson

Looks good!

Awesome, thanks!
On 12/12/2017 02:12, Joel Hobson wrote:

Merged #84 https://github.com/JoelHobson/MIDI.jl/pull/84.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JoelHobson/MIDI.jl/pull/84#event-1382639923, or
mute the thread
https://github.com/notifications/unsubscribe-auth/ASwgYe3hztZiPeDiTOdX2m2LObkqGRCxks5s_dMFgaJpZM4Q8uRr.


[PHPStanRules] Fixes #2548 Add CheckOptionArgumentCommandRule

All checks have passed 🎉 @TomasVotruba it is ready for review.

All checks have passed 🎉 @TomasVotruba I think it is ready.

Thank you :+1:


[Feature]: Support Github Packages as a registry

Hi there! Would be awesome if this tool could support Github's package registry (https://npm.pkg.github.com). Here's the error we're getting when using that as a registry:
> audit-ci --moderate --pass-enoaudit

audit-ci version: 3.0.0
RETRY-RETRY
RETRY-RETRY
code ECONNRESET: request to https://npm.pkg.github.com/SOMEORG/-/npm/v1/security/audits failed, reason: socket hang up
Exiting...

Hi @ashwinv11,
I haven't tried the GitHub registry. Can you try using the existing --registry flag? Note that yarn doesn't support using a different registry.
CC: #47

Closing due to inactivity

would love this as well


Fixes #13142 - PKCS7 certificates list is an implicit SET OF not SEQU…

RFC2315 states that the list of certificates in PKCS7 signed data objects is an implicit SET OF not SEQUENCE OF as is currently in the codebase. Because of this signatures generated by openssl fail to validate on Microsoft's new stricter DER parser in wintrust.dll.

This would be elligible for CLA: trivial. If you agree please amend the commit message so that it contains CLA: trivial on a separate line.

Apparently we have a test that expects the incorrect output. That needs to be fixed. Does this change have potential of breaking some interoperability if some other software expects the other output?

Re breaking software expecting the other output, the only visible difference visible would be that certificates weren't written in the order they were added to the pkcs7 object. The only thing one could imagine is that someone writes an application to read pkcs7 written by openssl, that is expecting the first certificate to be the signing certificate. Such an application written in openssl would be looking at the first cert in p7->d.sign->cert, rather than using PKCS7_get0_signers or PKCS7_cert_from_signer_info.

The order of certificates written to a PKCS7 file is now likely to be different.  That should be noted in a clear spot, including a HISTORY section of the manpage.

@levitte Although the change looks small, won't this will create issues for existing data.
Should it now need to try both forms when decoding?

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@fishsoupisgood I'm not really sure what difference this PR makes in terms of encoding and how it can fix your problem.
Have you actually tested if this fixes your problem with the wintrust.dll parser?
The reason is that this is implicitly tagged sequence so the type is not part of encoding. I actually took a time to generate signed data so you can compare the results below:
Before the patch: https://bit.ly/39d95km
After the patch: https://bit.ly/2JcRHRV
Basically you won't see any difference because the type is not encoded (just the tag is encoded) so it doesn't really matter if it is specified as a sequence or set. The only difference is that the certs will be in correct order from the OpenSSL point of view. I think this is done on purpose to keep order of certificates when re-encoding which is done in the similar way in PKCS7_SIGNER_INFO: https://github.com/openssl/openssl/blob/2d4022603a0f09d802bf5cc5f04a08b6880bbfa2/crypto/pkcs7/pk7_asn1.c#L143-L148
Hence I don't think this is a bug and there's anything to fix.

The issue is very real, perhaps I can suggest you look at the example code which reproduces the issue in the linked bug report?
https://github.com/openssl/openssl/issues/13142

Ah ok I haven't seen the linked bug. It validates the order so this makes sense. If that's the case, it might need to also change the auth_attr (authenticatedAttributes) that can be set using PKCS7_set_signed_attributes. I would guess that if their order is not alphabetical, it will fail as well, right?
I think I can at least answer the question that @slontis asked. As it's implicitly tagged and both SET OF and SEQUENCE OF are consctructed, then there shouldn't be any difference for decoding. At least that's how I understand it - haven't tried it. :)

The commit message should be reformatted like this:
PKCS7 certificates list is an implicit SET OF not SEQUENCE OF

Fixes #13142

CLA: trivial

Github isn't very good at picking up hints from the commit subject line, which is why the links between issue and PR aren't visible in a github supported way.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

Please rebase and reformat the commit message as @levitte stated above.

Please rebase and reformat the commit message as @levitte stated above.

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 92 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

Please rebase and reformat the commit message as @levitte stated above.

Since it's a trivial reformatting of the commit message, I edited it as requested and rebased the pull request branch.

The CI failure is relevant!

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR has been closed.  It was waiting for the creator to make requested changes but it has not been updated for 90 days.


Adding/removing/changing infix declarations should be signalled by diff, as MAJOR change

For example, assume that in the core package's Basics.elm the line
infixr 0 <|

were replaced by
infixl 0 <|

At current, elm-package diff would ignore that change. But it should actually be considered a MAJOR change under semantic versioning, because it amounts to changing the type of expressions. For example, a client of core may contain an expression like f <| g <| x. Whether or not this expression is well-typed (given some specific f, g, x) and which type it has (say, if f, g, x are unconstrained and one simply uses type inference) will change between having infixr or infixl for <|. So ignoring that change when computing the diff for core breaks the guarantees expected from semantic versioning in a big way.

The new implementation checks for that here, so it will count as a major change. The diffs also show the associativity and precedence as well, so you can see the change even though the name and type stays the same.


CloseButton doesnt work while using menuConstraints

Hello,
first I would say thank you for creating this widget, it helps a lot for me.
I want to ask after I add menuConstraints, the close button under the list doesn't work. how can I solve this problem thank you :D

Hi @andrehaliim ,
You’re welcome for the plugin. Glad to know this is useful.
Thanks for reporting your issue.
I just tried from my mobile browser the “Single menu” example on https://searchchoices.jod.li which has the menuConstraints set and the close button works for me. It closes the menu.
Is there something specific to your situation? Are you customizing the close button? Is there a done button set? Are you on web/iOS/Android or anything else?
Cheers.

oh no my bad I post this issue in search_choices, my problem was in Searchable Dropdown.
I was using that plugin for my android apps in flutter, and it doesn't work
this is my code:
`Container(
color: Colors.white,
margin: EdgeInsets.symmetric(horizontal: 20.0, vertical: 10.0),
child: Container(
child: Padding(
padding:EdgeInsets.only(left: 2, bottom: 5, top: 5, right: 1),
child: SearchableDropdown(
isExpanded: true,
icon: Icon(Icons.keyboard_arrow_down),
hint: Text(
hint,
style: const TextStyle(color: Colors.black),
),
style: TextStyle(
color: Colors.black,
fontFamily: Constants().FONT_LATO_REGULAR),
underline: Container(
height: 0,
),
onChanged: (PurchaserVO newValue) {
setState(() {
_configVO.selectedPurchaser = newValue;
_configVO.vehicleFilterStock.idPurchaser =
newValue.purchaserId;
_configVO.vehicleFilterStock.namePurchaser =
newValue.purchaserName;
widget.notifyParent();
});
},
value: _configVO.selectedPurchaser,
items: purchaserList.map((PurchaserVO purchaserVO) {
return new DropdownMenuItem(
child: Text(
purchaserVO.purchaserName,
),
value: purchaserVO,
);
}).toList(),
dialogBox: false,
menuConstraints: BoxConstraints.tight(Size.fromHeight(350)),),
),
        ),
      );`

is there anything wrong?

No worries @andrehaliim ,
At first sight, your code looks good. It shouldn’t cause the issue you are witnessing. I will try to have a look at it as soon as I get to a computer. In the meanwhile, it would be interesting to know whether this issue also occurs with the search_choices plugin.

Hi @andrehaliim ,
I just tried the following adapted code with the latest version of the searchable_dropdown plugin and the close button closes the menu as expected on Android:
SearchableDropdown<ExampleNumber>(
        isExpanded: true,
        icon: Icon(Icons.keyboard_arrow_down),
        hint: Text(
          "hint",
          style: const TextStyle(color: Colors.black),
        ),
        style: TextStyle(
            color: Colors.black,
            fontFamily: "roboto"),
        underline: Container(
          height: 0,
        ),
        onChanged: (ExampleNumber newValue) {
          setState(() {
//            _configVO.selectedPurchaser = newValue;
//            _configVO.vehicleFilterStock.idPurchaser =
//                newValue.purchaserId;
//            _configVO.vehicleFilterStock.namePurchaser =
//                newValue.purchaserName;
//            widget.notifyParent();
            selectedNumber=newValue;
          });
        },
//        value: _configVO.selectedPurchaser,
      value:selectedNumber,
        items:ExampleNumber.list.map((exNum) {
          return (DropdownMenuItem(
              child: Text(exNum.numberString), value: exNum));
        }).toList(),
//        items: purchaserList.map((ExampleNumber purchaserVO) {
//          return new DropdownMenuItem<ExampleNumber>(
//            child: Text(
//              purchaserVO.purchaserName,
//            ),
//            value: purchaserVO,
//          );
//        }).toList(),
        dialogBox: false,
        menuConstraints: BoxConstraints.tight(Size.fromHeight(350)),)

Here is the output of my flutter doctor command:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 2.1.0-13.0.pre.27, on Linux, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 4.0)
[✓] Connected device (3 available)

• No issues found!

Either the environment is different or the surrounding Widgets or the objects in use or the platform (Android version 7.0 in my case).

Hello @andrehaliim ,
Did you find the root cause of your issue?
Is there something I can do to help?

Closing for inactivity. Feel free to reopen if needed.


Pr fix various reposition bugs in navigator module

This pr fixes the following three issues when repositioning in navigator:

if the "go to" location sent by QGC was outside a geofenced area and the geofence failsafe was set to HOLD then the drone would just exit the geofence and reach destination
if the "go to" location sent by QGC was inside a geofenced area, the geofence failsafe was set to HOLD and the path to get to destination went outside the geofence, the drone would just go out of the geofence and then enter again to reach destination
after an auto takeoff from QGC then user could not perform an altitude change because the current waypoint was still set to Nan for lat and lon after a takeoff. To make it work the user would have to repeat the change altitude action twice

These three issues where fixed by the following changes:

reject a "go to" location outside a geofenced area before we even start to execute it
reposition to the current location if during the "go to" we exit the geofence
fix the if statement so if lat and lon are Nan we take the current global position and still change the altitude

Can anyone comment on testing here?


data-vv-as only updates when input value changes

Versions

vee-validate: 2.0.9
vue: 2.1.10

Describe the bug
I'm building a multi-language application with vue-i18n. If I change the language both in vue-i18n and vee-validate, every message changes to the selected language's text, but not the messages associated to the data-vv-as attribute. However, if I click on the input box, and edit the text it refreshed automatically.
It has been fixed last year but seems like the issue still occurs.
I'm having the exact same issue as brunen9 had last year.
Expected behavior
validateAll() should update the data-vv-as attribute's value.
<input type="text" class="form-control" name="username" v-validate="'required|alpha_num|min:4|max:16|unique_username'" :class="{'input': true, 'is-invalid': errors.has('username') }" v-model="loginData.username" :placeholder="showPlaceholder('username')" :data-vv-as="$t('register.formData.username')">

I have the same issue and my users really don't like it. This issue results in combination with i18n into a "mixed validation error text" if the language changes while showing a validation error text.

They are not exactly the same issue, although it is a similar behavior. data-vv-as is not reactive because its an HTML5 data-* attribute.
for reference here is a reproduction of the issue:
https://codesandbox.io/s/4j12p5or7w
The issue here, since the data-vv-as is not reactive and cannot be reactive. You should follow the documented tip to provide the field names in the dictionary instead. And since you are using i18n you already do but you should place them under ${locale}.validation.attributes. Here is an example for it:
https://codesandbox.io/s/72lk73wx3x
This example integrates i18n with vee-validate allowing you to manage any localization specific tasks from i18n instead of managing for both.

@logaretm Thanks! 👍

@logaretm Hi, what if I have really big forms containing multiple fields, I feel that having to add every form name (which all have custom messages) to the dictionary is a bit overkill.
Plus, field names repeat from form to form but their description is not the same...
Is there another way to tell Vee-Validate to re-render asap the data-vv-as?

You can always re-validate the fields and it should display the correct messages. or you could loop over the errors inside the errorBag manually and call regenerate if it exists.
this.errors.items.forEach(e => {
  if (e.regenerate) {
    e.regenerate();
  }
});

@logaretm The regenerate method doesn't seem to work as it only put the same message with the wrong locale for the data-vv-as..
As for the re-validation, is it possible po re-validate only the fields that have errors instead of the whole form?

I also tried:
this.$validator.validateAll(null, null, true);
for a silent validation, but still doesn't retranslate the data-vv-as value...

All right, found that the function regenerate of the error actually doesn't set the message back. So I ended up with this code which updates the error message based on the newly translated data-vv-as:
this.verrors.items.forEach(e => {    if (e.regenerate) {      e.msg = error.regenerate();    }  });


Fix for panic in Mahjongg #88

It looks like a bad interaction between the malloc pool and the image pool
when allocating images.  I've removed the image pool& it works.
Can someone check this out - it works, but I'm a bit twitchy I've missed
something. c.f. memimagemove

I'm not sure, specially of replacing poolalloc for malloc. Poolalloc must be fixed if it's wrong, but it's a good work. Qmalloc was fixed months ago, we should have it always aligned with libc/port/malloc.c if we change anything in it. Anyway, pool mess in qmalloc kernel was included when I brought back screen and vga in September. Originally wasn't there. Surely my mistake, but for an arcane reason I can't remember, I found some undefined things that required including pool mess in it (I remember a talk with Ron about this) that originally was in old alloc.c. I'm not sure if it was due to some sources now removed or changed. So removing it now couldn't be wrong at all, now it seems as it was before September 2nd.
Look at: Original qmalloc.c

SGTM

If this works for you go for it.

LGTM


OCPBUGS-2822: UPSTREAM: : Fix GOARCH in OpenShift build

Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP.
In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.
@openshift/storage

/jira refresh
:crossed_fingers:


NPE while starting the app

@sivaram636  test issue check this out

i thinks its a one liner fix ....just change this ....XXXXX

fixed

checking slack integrations


Add list template

https://developers.facebook.com/docs/messenger-platform/send-api-reference/list-template

Hi, anyone working on this or can I take this up?


MSSQL add unit test

MSSQL add unit test

Codecov Report

Merging #1834 (26d4602) into master (a73769e) will decrease coverage by 0.04%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##           master    #1834      +/-   ##
==========================================
- Coverage   73.53%   73.48%   -0.05%
==========================================
  Files         495      495
  Lines       44310    44328      +18
==========================================
- Hits        32582    32574       -8
- Misses       9772     9793      +21
- Partials     1956     1961       +5

Flag
Coverage Δ

go-1.15
?

go-1.16
73.48% <70.27%> (-0.01%)
:arrow_down:

go-1.17
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

os/gcmd/gcmd_command.go
100.00% <ø> (ø)

os/gcmd/gcmd_command_object.go
51.41% <0.00%> (-0.99%)
:arrow_down:

protocol/goai/goai.go
82.47% <ø> (ø)

protocol/goai/goai_xextensions.go
100.00% <ø> (ø)

os/gcmd/gcmd_parser.go
92.90% <72.22%> (-2.59%)
:arrow_down:

os/gcmd/gcmd_command_run.go
61.48% <100.00%> (+2.86%)
:arrow_up:

protocol/goai/goai_parameter_ref.go
80.70% <100.00%> (+0.34%)
:arrow_up:

protocol/goai/goai_shema.go
72.99% <100.00%> (ø)

os/gfsnotify/gfsnotify_watcher_loop.go
78.15% <0.00%> (-5.05%)
:arrow_down:

net/gtcp/gtcp_pool.go
34.09% <0.00%> (-4.55%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ad294...26d4602. Read the comment docs.

改完了