gitea dump suddenly stops working: Failed to dump database: no such column: is_restricted

Gitea version (or commit ref): v1.12.1
Git version: 2.17.1
Operating system: Ubuntu 18.04 LTS
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Description
I use the command gitea dump -c /etc/gitea/app.ini as the git user for creating backups. It has always worked fine. It has already worked with the currently installed version of gitea.
Apparently with no external issues, the command now gives:
git@vps:~$ gitea dump -c /etc/gitea/app.ini
2020/07/07 19:30:46 ...dules/setting/git.go:93:newGit() [I] Git Version: 2.17.1
2020/07/07 19:30:46 ...dules/setting/log.go:233:newLogService() [I] Gitea v1.12.1 built with GNU Make 4.1, go1.14.4 : bindata, sqlite, sqlite_unlock_notify
Failed to dump database: no such column: is_restricted

It does not stop right away. It seemingly goes through a lot of files when running with the -V option. A dump is produced but it is 22 bytes long (100MB usually).
https://github.com/go-gitea/gitea/issues/10207 seems related but I am running the correct binary (the versions from the GUI and from gitea --version match). Restarting the service or even the whole machine does nothing at all. The dump always fails the same way.

I find in /var/lib/gitea/log/gitea.log:
2020/07/07 19:52:17 ...m.io/xorm/core/db.go:154:QueryContext() [I] [SQL] SELECT `id`, `lower_name`, `nam
e`, `full_name`, `email`, `keep_email_private`, `email_notifications_preference`, `passwd`, `passwd_hash
_algo`, `must_change_password`, `login_type`, `login_source`, `login_name`, `type`, `location`, `website
`, `rands`, `salt`, `language`, `description`, `created_unix`, `updated_unix`, `last_login_unix`, `last_
repo_visibility`, `max_repo_creation`, `is_active`, `is_admin`, `is_restricted`, `allow_git_hook`, `allo
w_import_local`, `allow_create_organization`, `prohibit_login`, `avatar`, `avatar_email`, `use_custom_av
atar`, `num_followers`, `num_following`, `num_stars`, `num_repos`, `num_teams`, `num_members`, `visibility`, `repo_admin_change_team_access`, `diff_view_style`, `theme` FROM `user` [] - 2.134588ms
2020/07/07 19:52:17 cmd/dump.go:64:fatal() [F] Failed to dump database: no such column: is_restricted

Which is not much more information about the problem.

For context, I always update gitea by downloading the binary from the github releases. I've kept up to date with whatever the latest release was for some time now. Is my database too old? Why doesn't it have the is_restricted column?

Are you trying to run gitea dump before you've migrated the database to the latest version?
You should run gitea dump with the old version of gitea, not the new.

Or let gitea do the migration first

Ok I did try to dump without migrating first. It has worked by chance for a year and a half and every version of gitea. I don't understand whether the migration happened automatically? (I just stopped gitea, switched the binaries and restarted everytime)
Migrating with the newest binary, and then dumping fixes the problem:
As user git:
gitea migrate -c /etc/gitea/app.ini
gitea dump -c /etc/gitea/app.ini

I'll just add the migration command to my (hacky) update script. Thanks for the answer!

you probably want to dump before updating the version of gitea - that way if there is a problem with migration you still have the previous DB to return to.


Upgrade to Laravel 5.5 and fix bug …

Hello,
Looks like a simple upgrade from Laravel 5.4 to 5.5 is possible. I have checked for all the breaking changes described in the upgrade notes and found none. The application runs fine on my local machine.
Bug fix is one previously described https://github.com/anindya-dhruba/laravel-vue-spa/issues/3
Didn't want to make significant changes to readme.md, so limited to changing Laravel version number.
This is my first pull request, so apologies if I've done it wrong!

Thank you very much @tristansnowsill for making the pull request. I am in a vacation right now and will be back soon. I will merge it to master once I am back and the update works fine as well.
Thanks again for the hard work. Really appreciate it. ☺

It really wasn't hard work fortunately. I have noticed that the homepage still says Laravel 5.4. D'oh! Hopefully this is something that doesn't require a separate pull request :)


Entrust MigrationCommand is broken with laravel new update

it fails to create migration files. Laravel new update uses different auth config options.

I have added a fix , if anyone is getting error when creating migration file
Class name must be a valid object or a string

Works for me :+1:
But maybe you fix the typo in your code before posting a PR defaultGaurd to `defaultGuard :)

ah sorry, I will fix it and push it again

Actually you should do this in lines 88 and 89:
$userModel = $UserClass['model'];
$usersTable = (new $userModel())->getTable();

I am using this with Laravel 5.2 - I still get this error?

also seeing this error 5.2.10

@vijaythecoder can you please submit the PR for this? thanks.

@andrewmclagan
https://github.com/Zizaco/entrust/pull/482

For entrust 5.2 replace
$usersTable  = Config::get('auth.providers.users.table');
$userModel   = Config::get('auth.providers.users.model')
by
$usersTable  = Config::get('auth.table');
$userModel   = Config::get('auth.model');
inside vendor\Zizaco\Entrust\MigrationCommand

@gnabino1 I just did a pull and had this issue:
[Symfony\Component\Debug\Exception\FatalErrorException]     Class name must be a valid object or a string
Your solution was helpful!

In Laravel 5.3 I had to change these settings BACK to auth.providers.users.* to get this to work.


move distance functions into verify module

This would be good for seperation of concerns.

Closed with PR - https://github.com/serengil/deepface/pull/999


Matching multiple old values to current ISIC/ISCO value

The function in international_codes.R does generally produce satisfactory results. However, there's a conceptual issue with the R code that arises where multiple ISIC or ISCO codes from a previous year's schema match to a current year's code. Here's an example table:
Table 1

This year's code
Description
Old Version 0.1 Codes

1234
A description
0001, 0002, 0003

This would be great, except the PDF actually has these values in separate rows, with empty info in other cells, like below:
Table 2

This year's code
Description
Old Version 0.1 Codes

1234
A description
0001

0002

0003

The human is able to tell that the values in empty cells belong to the most recent non-empty cells, but this is very diffcult for the computer where relational data is lost. read_pdf() function does actually read all "old" values, but the problem is that the end up in separate rows (which is exactly how the appear in the raw PDF). In a sense, the function works too well, because now we have empty rows with no idea really where they go -- they're just sort of lost in the massive tibble that gets imported.
I'm posting the issue here for brainstorming and problem-solving -- we need to figure out a way to keep all old values associated with the new value.

This issue has been resolved since we determined that cleaning the Old version codes column is not necessary


CHANGELOG

Hello Ken,
You can add the Changelog file please ;o)
Thank you for good job,
John.

@Gouigouix, https://github.com/kenwheeler/slick/releases should give you the info you need. :)

That's what I was looking for.
Thank you.


reproduce numbers in paper

Hi, Thanks for sharing great work!
I found that model trained on 'm4c_processed' data using the command in READMD.md does not match the numbers in the paper. It also looks similar for the 'dynvideo_male' case too.
Can you share us that what config options were used for training? (such as 'batch_size', 'lpips_start_iter', 'pose_op_start_iter', etc)
Best regards

Hi, we also optimize the test sequence to get refined poses for testing before training the model.

And I would be very grateful if you would publish checkpoints for the other three people from SnapshotPeople in the table


Docs: Whats-New: What's new page contents not loading when using local env setup

Setup

Rancher version: v2.7.2
Dashboard version: v2.7.2
Browser type & version: Any

Describe the bug
What's new page contents not loading when using local env setup. User lands on blank page.
To Reproduce

create instance of Rancher Dashboard locally (https://localhost:8011)
login to Rancher UI as an admin/standard user
go to What's new page by clicking
"What's new in 2.7" link (or go directly to https://localhost:8011/docs/whats-new)
note page is blank

Result
What's new page contents not loading when using local env setup.
Expected Result
What's new page contents load when using local env setup.
Screenshots

Additional context
The page loads fine when using remote env setup.
Passes: https://yonasb.qa.rancher.space/dashboard/docs/whats-new
Fails: https://localhost:8011/docs/whats-new

This might be a localhost only issue, but we should validate before the release. It might be the nuxt removal has broken this feature

Fix Verified -
What's new page contents load in local and non-local setups.


[TEST] Increasing PanTest, KitchenTest, PanIT, KitchenIT

Expanding unit tests for PanTest, KitchenTest, PanIT, KitchenIT, testing the exitStatus returned within org.pentaho.di.core.Result

further tests will be done, testing further data returned within org.pentaho.di.core.Result

PanCommandExecutor / KitchenCommandExecutor now return org.pentaho.di.core.Result obj instead of the exitStatus int primitive value
exitStatus int primitive value is found in result.getExitStatus()
checkstyle fixes

single-line imports instead of *
deleted unused imports
checkstyle issues

To test Pan / Kitchen

mvn clean verify -Dtest=PanTest -DrunITs -Dit.test=PanIT
mvn clean verify -Dtest=KitchenTest -DrunITs -Dit.test=KitchenIT

To be merged alongside https://github.com/pentaho/pentaho-ee/pull/1414
@pentaho/rogueone please review

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/it/java/org/pentaho/di/kitchen/KitchenIT.java
  engine/src/it/java/org/pentaho/di/pan/PanIT.java
  engine/src/main/java/org/pentaho/di/base/AbstractBaseCommandExecutor.java
  engine/src/main/java/org/pentaho/di/kitchen/Kitchen.java
  engine/src/main/java/org/pentaho/di/kitchen/KitchenCommandExecutor.java
  engine/src/main/java/org/pentaho/di/pan/Pan.java
  engine/src/main/java/org/pentaho/di/pan/PanCommandExecutor.java
  engine/src/test/java/org/pentaho/di/kitchen/KitchenTest.java
  engine/src/test/java/org/pentaho/di/pan/PanTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.kitchen.Kitchen

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.pan.Pan

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.pan.PanCommandExecutor

Instruction Change: -0.8% :small_red_triangle_down:
Line Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -3% :small_red_triangle_down:
Complexity Change: -3.2% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -3.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:


Fixed typo which prevents the auto detection of certain wired adapters

Since restructuring the code on Apr 14, 2023, there seems to be a small typo in BlueRetro/main/wired/detect.c which prevents the auto detection of certain HW1 wired adapters. The buggy line 34 currently looks like this:
if (io & BIT(detect_pin[i] - 32)) {
In my opinion this should be
if (io & BIT(detect_pin[i] < 32 ? detect_pin[i] : detect_pin[i] - 32)) {
or much simpler
if (io & BIT(detect_pin[i] & 31)) {

Great catch!
Thank a lot!!


Dropdown: support .dropdown-item wrapped in <li> tags

Fully closes https://github.com/twbs/bootstrap/issues/33625 (follow up to https://github.com/twbs/bootstrap/pull/33626)
This adds support for .dropdown-items to be wrapped in <li> tags which is the HTML structure that the docs currently recommend.
It'd be great to backport this fix to BS4 as well since that suffers from the same problem, which is a pretty unfortunate change from BS3 (which required <a> tags to be wrapped in <li>)

@cpsievert feel free to backport it to the v4-dev after this one lands :)

@cpsievert  please rebase your branch

Yup, definitely split the changes into separate PRs so that we can track any breakage :)

@alpadev you want to apply your optimization patch here? Or do you plan to make a PR after this one has landed?

@XhmikosR as you prefer. I was thinking to do this after, so we're unlikely to introduce more bugs before stable.

Alright yeah let's do it separately to be safe
On Tue, Apr 20, 2021, 16:16 alpadev @.***> wrote:

@XhmikosR https://github.com/XhmikosR as you prefer. I was thinking to
do this after, so we're unlikely to introduce more bugs before stable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/pull/33634#issuecomment-823265248, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACVLNI625VTCI6QODOYDN3TJV5CBANCNFSM426KH6AQ
.


Support Linux ARM64

Summary
Attempting to add Linux ARM64 support, similar to: https://github.com/mike-engel/jwt-cli/pull/351/
Preflight checklist

[ ] Code formatted rustfmt ($ cargo fmt)
[ ] Code linter check with clippy ($ cargo clippy)
[ ] Relevant tests added
[ ] Any new documentation added

Hi @hrishikesh-k sorry for the silence. I finally am getting some time here, but noticed this PR was closed. Was that on purpose?

Sorry, I deleted the repo during my cleanup of old repos. Here's a new PR: https://github.com/mike-engel/jwt-cli/pull/370


sqlite-jdbc-<IP_ADDRESS>.jar can't support mip64 system

Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is java.sql.SQLException: Error opening connection] with root cause
java.lang.Exception: No native library found for os.name=Linux, os.arch=mips64el, paths=[/usr/java/packages/lib/mips64el:/lib:/usr/lib]
at org.sqlite.SQLiteJDBCLoader.loadSQLiteNativeLibrary(SQLiteJDBCLoader.java:389)

dup of #624. Compile yourself.


Inform the server when a player leaves the game

Going out of the lobby page, and then pressing back causes the server to throw an exception.
We need to inform the server that somebody has left the lobby

Of left the game for that matter

A couple of notes:

Special Case Host leaves lobby
-Player Leaves Lobby vs Player Leaves Ongoing Game

Suggestion for you;  have a time_since_last_request dict in the server. Have a thread checking this dict every second or something? And update the times whenever a player sends a request
Not 100% that this will work, looking up intervals in python as we speak

http://stackoverflow.com/a/3393759

Also try looking up the onbeforeunload event
https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload

Just to remind myself; edit lobby.js to allow only the host to click the button


AttributeError: type object 'libcamera._libcamera.ColorSpace' has no attribute 'Jpeg'

AttributeError: type object 'libcamera._libcamera.ColorSpace' has no attribute 'Jpeg'

example: raw.py
same error

i am getting the same error also
pi@pi:~ $ python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import picamera2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/dist-packages/picamera2/__init__.py", line 5, in <module>
    from .picamera2 import Picamera2, Preview
  File "/usr/local/lib/python3.9/dist-packages/picamera2/picamera2.py", line 42, in <module>
    class Picamera2:
  File "/usr/local/lib/python3.9/dist-packages/picamera2/picamera2.py", line 400, in Picamera2
    def create_preview_configuration(self, main={}, lores=None, raw=None, transform=libcamera.Transform(), colour_space=libcamera.ColorSpace.Jpeg(), buffer_count=4, controls={}, display="main", encode="main"):
AttributeError: type object 'libcamera._libcamera.ColorSpace' has no attribute 'Jpeg'

Hi, yes I'm afraid the libcamera API has been updated and the latest version of Picamera2 matches it. Run
sudo apt update
sudo apt upgrade

to fix the problem.

I have did that, and libcamera is upgraded.
according to this issue: https://github.com/raspberrypi/picamera2/issues/295#issuecomment-1234291659
But still having the same error

Ah, sorry, my mistake. If Picamera2 is looking for a symbol ColorSpace.Jpeg() then it's Picamera2 that is out-of-date, not libcamera. The latest version that matches the updated libcamera is 0.3.3. - what does pip3 show picamera2 report?
Note that you can now also use sudo apt install -y python3-picamera2. This will probably be a better way to install Picamera2 in future because sudo apt upgrade will update everything so that the versions should stay compatible.

pi@allskyLA:~ $ pip3 show picamera2
Name: picamera2
Version: 0.2.3
Summary: The libcamera-based Python interface to Raspberry Pi cameras, based on the original Picamera library
Home-page: https://github.com/RaspberryPi/picamera2
Author: Raspberry Pi & Raspberry Pi Foundation
Author-email<EMAIL_ADDRESS>License: BSD 2-Clause License
Location: /home/pi/.local/lib/python3.9/site-packages
Requires: numpy, PiDNG, piexif, pillow, pyopengl, PyQt5, python-prctl, simplejpeg, v4l2-python3
Required-by:

Yes, for the latest version of libcamera you need to be on Picamera2 0.3.3. As I said, the following is probably recommended now:
sudo apt update
sudo apt upgrade
sudo apt install -y python3-picamera2

error remains :/
pi@allskyLA:~ $ sudo apt install -y python3-picamera2
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
python3-picamera2 is already the newest version (0.3.3-1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
pi@allskyLA:~ $ pip3 show picamera2
Name: picamera2
Version: 0.2.3
Summary: The libcamera-based Python interface to Raspberry Pi cameras, based on the original Picamera library
Home-page: https://github.com/RaspberryPi/picamera2
Author: Raspberry Pi & Raspberry Pi Foundation
Author-email<EMAIL_ADDRESS>License: BSD 2-Clause License
Location: /home/pi/.local/lib/python3.9/site-packages
Requires: numpy, PiDNG, piexif, pillow, pyopengl, PyQt5, python-prctl, simplejpeg, v4l2-python3
Required-by:
pi@allskyLA:~ $

@Bra1nsen you must uninstall the pip3 package
pip3 uninstall picamera2

or
sudo pip3 uninstall picamera2

then reinstall using:
sudo apt install -y python3-picamera2

pip show output
pi@pi:~ $ pip3 show picamera2
Name: picamera2
Version: 0.3.3
Summary: The libcamera-based Python interface to Raspberry Pi cameras, based on the original Picamera library
Home-page: https://github.com/RaspberryPi/picamera2
Author: Raspberry Pi & Raspberry Pi Foundation
Author-email<EMAIL_ADDRESS>License: BSD 2-Clause License
Location: /usr/lib/python3/dist-packages
Requires:
Required-by:

nice thanks =)!


chore: runtime init default values

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

chore: runtime init default values

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 61.931%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/native/loader.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
3252

Relevant Lines:
5251

💛  - Coveralls


Construction stages can't be added to load combination

Expected
Construction stages should be possible to add to a load combination:

Bug

[ ] Struxml model that has load combination with construction stage can't be deserialized.
[ ] Can't create a load combination with construction stage case (cs_case). (C# and Grasshopper)

@andosca @Marco-Pellegrino This is required for a project. Can you please help me with this fix?
Or if you want, I could do it if you allow me to do a hot fix and you create a new release for me :)

@xRadne
I am currently focus on other tasks and it would be great if you can fix it if it is super urgent.
Do you also need to share the .dll with the clients? is this the reason to have a new release?

Implemented the following types for load combinations. In C#
https://github.com/strusoft/femdesign-api/blob/4ef9111c8db6a10ac5641ad1b1bd69beafa309f7/FemDesign.Core/Loads/LoadCombination.cs#L20-L32

@xRadne looks like the issue has been solved :).

Actually, only fixed C#. Did not get the time to fix Grasshopper components as well

As discussed with @andosca, I will do a refactor of the LoadCombinations. Mainly to create a better ux in grasshopper.
To do:

[ ] LoadCombination.Deconstruct should output LoadCase, Stage objects
[ ] LoadCombination.Deconstruct add parameter LoadCase type [Load case, Stage, Special load case]
[ ] Make old Deconstruct component obsolete
[ ] Make old Construct component obsolete
[ ] Deepclone, GetLoadCombination()
[ ] Value list auto-update. On the input parameter LoadCase
[ ] Update LoadCombination.Construct LoadCase parameter description.

Moving loads increases the complexity even further


Fix invisible image

Hi!
I create this new PR because, I see that for pictures that are not displayed in the DOMTree, the polyfill doesn't work correctly and so when I display for the first time the picture, it's not correctly configured until I resize the screen.
Feel free to improve this part, I think we can do it better.
Thank you.

Hey hey! Quick question - what's the specific use-case for non-visible elements? I can think of 2 off the top of my head (lazy-loading and carousels) - but I'm not totally convinced that the polyfill should be opinionated enough to handle those cases out of the box.
Rather than the polyfill listening for or polling for a visibility change (which can get extremely expensive, esp. in the case of lazy-loading galleries for example), I would rather see the responsbility of polyfilling images that change visibility be on the developer rather than on the polyfill.
See https://github.com/constancecchen/object-fit-polyfill/issues/21#issuecomment-293693668 for what I think is a much more performant solution - image libs that affect visibility should fire events (most carousel libs do every time a slide changes, for example), and devs should hook onto those events for polyfilling.

Fix for img element in picturre element:
picture {       width  : 100%;       height : 100%;       display: flex; }


Ability to limit zooming

Implement the following params:
minDelta={0.05}
maxDelta={2}
as outlined in https://facebook.github.io/react-native/docs/mapview.html

maximum for sure !

Agreed. This should be implemented. Unfortunately it might have to be for ios only though :/

Do we really need a native implementation for this?
How about maintaining the maxDelta in as props and as soon as user changes the delta more than that.. the map animates and snap backs to the maximum its allowed to.

@ahmed1490 the problem is the native side is often the side that is responding to zoom changes, which is required to stay that way in order to keep the map performant.

will android be supported?

maxZoomLevel/minZoomLevel exist now https://github.com/react-community/react-native-maps/blob/master/docs/mapview.md
We're trying to cleanup the repo, so please comment/mention me if this is still an issue. Thank you.


Wellness of the artists in the society

**Learning about different artists, their history and their wellness and how they were recognized in the society. **


Error while getting WiFi Network information (SSID) plugin

Hi Team,
Thank you for your great plugin. I have tried to use this plugin but got struck with a minor glitch, would you be able to help me out. I posted it at stack but no one replied so thought of putting it here,
Here is the link to the problem at stack:
http://stackoverflow.com/questions/32629233/error-while-getting-wifi-network-information-ssid-in-phonegap-app-using-com-py?noredirect=1#comment53172329_32629233

It's hard to say. I don't see anything wrong with the code being used. It sounds like you might be missing the ios code being called for the plugin.
Did you run phonegap plugin install https://github.com/parsonsmatt/WifiWizard.git to install?

Yes I did, try that. Also,  I am using it only for android at the moment.
My guess is it has some issue with version. I will perform further search and update you back.
I went through your code and everything seems fine to me.
Thanks a lot for the reply.

No problem. I just tested your code on my setup and it works fine on android. Sounds like you are on the right track with the version issue. Let me know if anything comes up. Thanks.

What platform are you trying to run your code on?

Hi,
Sorry for the delayed response. phonegap version update has caused a bit of problem. I fixed it.
Set my phonegap version to 3.7 and updated source to npm. Added below line in config.xml

placed below line in config :
<gap:plugin name="com.pylonproducts.wifiwizard" version="0.1.0" />
I am testing it on device Android.
I copied the js file from github latest version.
I tried using isWifiEnabled and that returns me the same error .
Incorrect action parameter
I believe the java file must be latest on in version 0.1.0 (I tried without version as well, and got the same error.)
I am using phonegap build, is there a possibility that there is something wrong at the build side, may be it's not working only when built from there ?
I did not try from local however till now. Even if I did, I still am dependent on phonegap build for my final apk at the moment.
Thanks again for your support !!!

Hi Again,
I downloaded the apk from phonegap build and I opened apk using apktool
Under the created apk folder, under below location
smali\com\pylonproducts\wifiwizard\ there was a file called WifiWizard.smali
I don't know much about it but I guess it does not have the variables getCurrentSSID or isWifiEnabled.
couldnt attach the file, but I guess you can try the same process and get the smali.
Thank You.

Based on the above WifiWizard.smali generated, I tried list listNetworks call, and it worked perfectly fine.
Below are first few lines of code of WifiWizard.smali
.class public Lcom/pylonproducts/wifiwizard/WifiWizard;
.super Lorg/apache/cordova/CordovaPlugin;
.source "WifiWizard.java"
static fields
.field private static final ADD_NETWORK:Ljava/lang/String; = "addNetwork"
.field private static final CONNECT_NETWORK:Ljava/lang/String; = "connectNetwork"
.field private static final DISCONNECT_NETWORK:Ljava/lang/String; = "disconnectNetwork"
.field private static final LIST_NETWORKS:Ljava/lang/String; = "listNetworks"
.field private static final REMOVE_NETWORK:Ljava/lang/String; = "removeNetwork"
.field private static final TAG:Ljava/lang/String; = "WifiWizard"
Thank You

Issue resolved,
source needed to be updated to npm and only then version 0.2.9 would work.
otherwise I was using 0.1.0
sample below
<gap:plugin name="com.pylonproducts.wifiwizard" source="npm" version="0.2.9"/>

Thank you for your support  !!!

Glad you got this figured out. As always, if you run into any other
problems let us know. Thanks.
On Oct 5, 2015 4:01 PM, "algae514"<EMAIL_ADDRESS>wrote:

Closed #42 https://github.com/parsonsmatt/WifiWizard/issues/42.
—
Reply to this email directly or view it on GitHub
https://github.com/parsonsmatt/WifiWizard/issues/42#event-427379613.


One more argument for using the package

When using the webform one will need to verify one's email address once per browser session whereas with the package it's once per email address and computer (well until you erase validated_emails.csv).

You can use gh auth to avoid that.

I used gh auth, closed Firefox, and was no longer authenticated when I re opened firefox, but it is true that gh auth takes little time.


Structure names glyphVariationData and tupleVariationHead should have initial caps

The general convention in the spec is for structure names to be PascalCase. To be consistent, instances of "glyphVariationData" and "tupleVariationHeader" should have initial caps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 446bcdab-0883-6d30-b5ed-0d04262ff820
Version Independent ID: cdf10ecc-926a-a992-fb71-67213ea8113f
Content: gvar — Glyph Variations Table (OpenType 1.8.4) - Typography
Content Source: typographydocs/opentype/spec/gvar.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

Addressed in OpenType 1.9. Closing.


Support for Speech API

With the Speech API released, I thought creating an issue to track its support in gcloud would be a good idea.

@findchris For sure! Thanks for opening it! I'll create a speech label right now.

The google-cloud-speech gem is now available!


KAFKA-16314: Introducing the AbortableTransactionException

As a part of KIP-890, we are introducing a new class of Exceptions which when encountered shall lead to Aborting the ongoing Transaction. The following PR introduces the same with client side handling and server side changes.

On client Side, the code attempts to handle the exception as an Abortable error and ensure that it doesn't take the producer to a fatal state. For each of the Transactional APIs, we have added the appropriate handling. For the produce request, we have verified that the exception transitions the state to Aborted.
On the server side, we have bumped the ProduceRequest, ProduceResponse, TxnOffestCommitRequest and TxnOffsetCommitResponse Version. The appropriate handling on the server side has been added to ensure that the new error case is sent back only for the new clients. The older clients will continue to get the old Invalid_txn_state exception to maintain backward compatibility.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I took a quick skim of the tests -- just wanted to confirm we have a test for the old produce request + invalid txn state returned?

I took a quick skim of the tests -- just wanted to confirm we have a test for the old produce request + invalid txn state returned?

@jolshan , if you have a look at core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala file, there is a test added around lines 381-390 wherein based on the Produce Request Version, we are testing if the returned error is Invalid_txn_state or AbortableTransactionsException

I was thinking about this change and am wondering if we should bump all the transactional APIs to make it clear this error can be returned. Let me get back to you @sjhajharia -- I will consult some others.

@jolshan, I updated the PR addressing the comments you left. I have renamed the enum to ApiVersionErrorMapper. Please do let me know if that looks better.
I will also wait for your confirmation on whether we need any changes in the exception naming and if all the Transactional APIs need to be bumped.
Thanks

Hey @sjhajharia thanks for the updates. I think ApiVersionErrorMapper is also a bit tricky since the addPartitions change will not be related to errors at all. That's why I was thinking of something a bit more generic. "Operation" was probably the right direction rather than "errors". Sorry this part is a bit nuanced. Maybe something like "supportedOperation" and the comment could be something like the supported operation based on the client's request API version?
And yes, I think we should bump all the API versions to support this new error. I can update the KIP.

On that note @jolshan , do we any more open questions to address or we are good to go with this PR? Or are we in flux for this?

Thank you @jolshan for the review.
I have updated the test mentioned. Hopefully it gets into trunk soon.


German Translation of Gender

As
organizer
I want to see
the gender of the applicants in my language (German)
in order to
provide a consistent look

is already fixed


iOS 14 equal width equal height issue

If I have 2 text fields with equal width and equal height next to each other on ios14 the viewcontroller hangs on push

this happens only on some devices iphone 8 plus etc.

If anyone is facing this issue, this is the solution (provided by apple)
-(void)drawRect:(CGRect)rect {
CGRect currentFrame = self.frame;
if (fabs(CGRectGetWidth(currentFrame) - CGRectGetWidth(rect)) > 0.001 || fabs(CGRectGetHeight(currentFrame) - CGRectGetHeight(rect)) > 0.001) {
[self updateTextField:CGRectMake(CGRectGetMinX(currentFrame), CGRectGetMinY(currentFrame), CGRectGetWidth(rect), CGRectGetHeight(rect))];
}
}


Fixed OpenNI2 registration bug:  It was always off, even after changing the property value

Comment: The propValue < 1.0? is unnecessary since in order to enter to the if, propValue has to be less than 1.0.

ok, let's put it in. :+1:


Updating About page and adding About link to navigation bar

This PR adds a link to the About page to the navigation bar and expands the text on that page, using copy provided by @mfldavidson. This PR aims to resolve issues #86 and #138.
The headers on the About page are currently using h2 tags with class=header. This option seemed preferable since the h1 tag with class=subheader previously in use was resulting in rather large headers in bold red. I'd be happy to change or modify this; I'm not sure what's in use around the site. Other suggested changes to the text formatting are welcome.
The About page does not appear to require authentication to visit, if navigated to directly. This seems to be in line with the future approach suggested in issue #86, where we might want to redirect unauthenticated users to the page.

Thank you Sam. Very minor change to request, sorry about this I'm only realizing it given your notes and seeing the changes. Could we keep "About Student Explorer" as h1, then the text below it is just body with no H2 in between, then the other headers in the section are h2? Does that make sense?

As in, on line 5, just change h2 to h1, that's the only change

Below the hr tag I would actually like to add a little more, I'm sorry for the change. Should I put this in the issue or just here? Or I can add it after we merge, that would be fine.

@mfldavidson, feel free to describe/provide what you want added as a comment here or on issue #86.

@mfldavidson, I believe I've made the changes you asked for. Let me know if there are other things you'd like to adjust; I'm fine iterating on this until we're happy with it.

Ok I've reviewed the code and all looks good to me, BUT my one question is, why in the screenshot is the background of the headers blue?


feat(carousel): add model binding support to slide

Add support for binding slide model to slide

This resolves #4201.

Tests? The doc is a bit simple. I would like an example of it working and a test is a good candidate for the example.


Mac Not Loading

Description
After downloading tmodloader and starting terraria, the Re-Logic screen shows up and fades to black, then the spinning beachball on the cursor comes up and the game doesn't load/is frozen indefinitely until I force quit it.
Steps to Reproduce

Download and install tmodloader using the .jar (or manually, I've tried both)
Try to start terraria

Expected behavior

Terraria should start normally
Actual behavior

Terraria doesn't load after the Re-Logic screen
Reproduction frequency

100%
Versions

tModloader v<IP_ADDRESS>-v0.10
Mods

none
Additional Information

I have tried reinstalling terraria multiple times by deleting all terraria files, I know I'm installing it correctly, and it doesn't seem like others have this problem. also, it looks like there is exe files in the folder I download for tmodlader, but Mac can't run .exe files? you probably know what you're doing just thought it was weird

After playing around wit this today I was able to get i to work. I held down the option key and clicked on the Terraria icon and it opened with no issue.

Oh so holding down the option key made it work? How weird! I’ll definetely try that once I’m back on my laptop tomorrow and reply back to this thread, thanks!

Well using the option key worked for about two days, I'm back to a black screen again.

We are aware, we just still have no answers. None of us use Mac so we're reliant on Mac users with some debugging skills to debug this sort of thing. Running the game from the command line might shed some light on things, but I don't know the command to do that on Mac.

Yeah, unfortunately there's no OSX developer on the team. Mac support is predominantly just linux support with the occasional tweak. Very sorry that we can't do anything about it at the moment.

Maybe one of us can virtualboot OSX and dev on there :P

Happening here also, OS X 12 (Sierra)
Console is reporting this before black screen / beachball:

default	13:02:30.595813 -0400	Terraria.bin.osx	WARNING: The Gestalt selector gestaltSystemVersion is returning 10.9.6 instead of 10.12.6. This is not a bug in Gestalt -- it is a documented limitation. Use NSProcessInfo's operatingSystemVersion property to get correct system version number.
Call location:
default	13:02:30.595938 -0400	Terraria.bin.osx	0   CarbonCore                          0x00007fff7b86f1b1 ___Gestalt_SystemVersion_block_invoke + 121
default	13:02:30.595959 -0400	Terraria.bin.osx	1   libdispatch.dylib                   0x00007fff900bd8fc _dispatch_client_callout + 8
default	13:02:30.595976 -0400	Terraria.bin.osx	2   libdispatch.dylib                   0x00007fff900bd8b9 dispatch_once_f + 38
default	13:02:30.595992 -0400	Terraria.bin.osx	3   CarbonCore                          0x00007fff7b7fd292 _Gestalt_SystemVersion + 976
default	13:02:30.596008 -0400	Terraria.bin.osx	4   CarbonCore                          0x00007fff7b7fcaad Gestalt + 139
default	13:02:30.596023 -0400	Terraria.bin.osx	5   libmojoshader.dylib                 0x000000012522c978 load_extensions + 1800
default	13:02:30.596039 -0400	Terraria.bin.osx	6   libmojoshader.dylib                 0x000000012522c1b7 MOJOSHADER_glAvailableProfiles + 151
default	13:02:31.535143 -0400	configd	LINKLOCAL en5: publish success
default	13:02:31.583314 -0400	WindowServer	UI updates were forcibly disabled by application "" for over 1.00 seconds. Server has re-enabled them.
default	13:02:38.029519 -0400	WindowServer	UI updates were finally reenabled by application "" after 7.45 seconds [0.13fps] (server forcibly re-enabled them after 1.00 seconds [1.00fps])
default	13:02:38.107785 -0400	opendirectoryd	Client: , UID: 0, EUID: 0, GID: 0, EGID: 0
default	13:02:38.137340 -0400	opendirectoryd	Client: , UID: 501, EUID: 501, GID: 20, EGID: 20
default	13:02:38.233934 -0400	taskgated	MacOS error: -67062
default	13:02:38.260105 -0400	opendirectoryd	Client: , UID: 501, EUID: 501, GID: 20, EGID: 20
default	13:02:38.278329 -0400	Steam Helper	[0929/130238.277856:WARNING:crash_reporting.cc(254)] Failed to set crash key: UserID with value: 0
default	13:02:38.278437 -0400	Steam Helper	[0929/130238.278408:WARNING:crash_reporting.cc(254)] Failed to set crash key: BuildID with value:<PHONE_NUMBER>
default	13:02:38.278477 -0400	Steam Helper	[0929/130238.278458:WARNING:crash_reporting.cc(254)] Failed to set crash key: SteamUniverse with value: Public
default	13:02:38.278512 -0400	Steam Helper	[0929/130238.278495:WARNING:crash_reporting.cc(254)] Failed to set crash key: Version with value:<PHONE_NUMBER>
default	13:02:38.278544 -0400	Steam Helper	[0929/130238.278528:WARNING:crash_reporting.cc(254)] Failed to set crash key: ProductName with value: cefwebhelper
default	13:02:38.278576 -0400	Steam Helper	[0929/130238.278560:WARNING:crash_reporting.cc(254)] Failed to set crash key: Vendor with value: Valve
default	13:02:38.324708 -0400	Steam Helper	Failed to look up the port for "com.apple.windowserver.active" (1100)
default	13:02:43.699579 -0400	gamed	GKClientProxy: clientForBundleID:
default	13:02:43.699724 -0400	gamed	GKClientProxy: updateIfRecentlyInstalled
default	13:02:43.700267 -0400	gamed	GKClientProxy: clientForBundleID:
default	13:02:43.700289 -0400	gamed	GKClientProxy: updateIfRecentlyInstalled

although some of those between the terraria.osx.bin and Steam Helper may be unrelated

Not sure if this will help, but if I totally reinstall Terraria and tmodloader, I do not hang on the black screen after the Re-Logic logo the first time I open Terraria.  Once I quit and start again that it will consistently hang on the black screen every other time I load the game.
My console output is as follows after which it will hang until I kill the process:

AL lib: (WW) GetProcPath: Failed to readlink /proc/self/file: No such file or directory
AL lib: (WW) alc_initconfig: Failed to initialize backend "jack"
Setting breakpad minidump AppID = 105600
Steam_SetMinidumpSteamID:  Caching Steam ID:<PHONE_NUMBER>9036587 [API loaded no]
IGLDevice: OpenGLDevice
OpenGL Device: NVIDIA GeForce GT 750M OpenGL Engine
OpenGL Driver: 2.1 NVIDIA-12.0.19 3<IP_ADDRESS>.10.103
OpenGL Vendor: NVIDIA Corporation
MojoShader Profile: glsl120
Resolution changed to: 1920x1200.

Thank you so much!

From: Chicken-Bones<EMAIL_ADDRESS>Sent: Thursday, November 29, 2018 10:24:16 PM
To: blushiemagic/tModLoader
Cc: ClawsForHands; Author
Subject: Re: [blushiemagic/tModLoader] Mac Not Loading (#400)
See #237https://github.com/blushiemagic/tModLoader/issues/237 for updates
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/blushiemagic/tModLoader/issues/400#issuecomment-443078181, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoM2kHWJIuNmRXURtBW2orYek2jrpRlSks5u0KTggaJpZM4Vw7l_.


Pagination with $resources (or any $promise) does not work properly.

Hello,
problem:
I found that if I use the pagination setting as total-items a value that is retrieved from the api with $resources (then also via $http) it breaks the pagination (it always return to first page) since the $watch on the totalItems is fired twice.
Ex:
I've a controller that performs a call to get the courses
   var fetchPage = function () {
      $scope.courses = gcResourceCourses.query({
        idClub: $stateParams.id,
        page: ($scope.currentPage - 1),
        size: $scope.itemsPerPage
      });
    };
$scope.$watch('currentPage', fetchPage);

the api returns:
{
"total":23,
"results":[...]
}

i set the pagination as this.
 <pagination class="pagination-sm"
                  ng-model="currentPage"
                  total-items="courses.total"
                  boundary-links="false"
                  items-per-page="itemsPerPage">
      </pagination>

so if i click on a button of the pagination (let's say 3) the watch is fired an the fetch page fetches page 3, now: the value is not yet set since the call is async. this means that the page is rendered with empty result, and then the total-items is set with a null value. This triggers the pagination watch on that value that set the currentPage to 1 resulting in having the pagination always set to 1.
solution:
(not sure it's correct but i guess so)
change the pagination.js here or here adding a control that checks that the value of $scope.totalItems is a number and not undefined (it should be undefined i guess)
I'm posting this because i may know how to code but I'm not much into submitting contribution and I don't want to break things

This is tricky - I believe there is another issue asking for the same feature.
The difficult part is that what should happen with the display if the total items value is missing? I think this needs some thought as to what is the best way to approach this.

upvote, totalPages should not be set to 1 if totalItems is undefined.

This should be fixed by 30099a0cd080936b22027d37c52b3b32f1fb3ad7.


Fix example that showed a number for workflow_dispatch

Why:
Closes https://github.com/github/docs/issues/24070
Fixes a small error in an input context example, where the input for a workflow_dispatch event was defined with a number type. This is allowed for reusable workflows (the workflow_call event) for that context, but not for workflow_dispatch events.
Preview: https://docs-24217-c252cd.preview.ghdocs.com/en/actions/learn-github-actions/contexts#example-usage-of-the-inputs-context-in-a-manually-triggered-workflow

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Why:
Closes #24070
Fixes a small error in an input context example, where the input for a workflow_dispatch event was defined with a number type. This is allowed for reusable workflows (the workflow_call event) for that context, but not for workflow_dispatch events.
Preview: https://docs-24217-c252cd.preview.ghdocs.com/en/actions/learn-github-actions/contexts#example-usage-of-the-inputs-context-in-a-manually-triggered-workflow
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:

[x]  I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x]  For content changes, I have completed the self-review checklist.

👋 @lucascosti triaging this! ✨ ⚡


Implement 'typeof' type query operator

This PR also does some renaming of functions in infer_type_ann.rs and updates their signatures to require a mutable Context.

Codecov Report

Merging #281 (031bcec) into main (16139a8) will decrease coverage by 0.00%.
The diff coverage is 96.64%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   90.16%   90.16%   -0.01%
==========================================
  Files          32       32
  Lines        4635     4655      +20
==========================================
+ Hits         4179     4197      +18
- Misses        456      458       +2

Impacted Files
Coverage Δ

crates/crochet_infer/src/infer_fn_param.rs
83.83% <ø> (ø)

crates/crochet_infer/src/infer_pattern.rs
88.23% <ø> (ø)

crates/crochet_infer/src/lib.rs
99.01% <96.34%> (+0.01%)
:arrow_up:

crates/crochet_infer/src/infer.rs
97.67% <100.00%> (ø)

crates/crochet_infer/src/infer_type_ann.rs
98.52% <100.00%> (ø)

crates/crochet_parser/src/lib.rs
96.35% <100.00%> (+0.03%)
:arrow_up:

crates/crochet_types/src/type.rs
82.85% <0.00%> (-5.72%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


LR bug for resumed training?

Hi, I used 'resume-from' flag for a interrupted training process.
I noticed that the learning rate is from the initial learning rate, it did not inherit the previous learning rate.

Please provide more details about your problem.
From my experience, resume-from would help you start from the last epoch before your training procedure gets interrupted. Maybe what you mean is that it does not continue from the last iteration/step before the interruption?

I am wrong, the learning rate was inherited from the last checkpoint.
This is no problem, thanks for the reply!
So the question is closed.


migrate to black

migrate to use black as opinionated auto formater
add .git-blame-ignore-revs
fix docs compatibilty problem with Sphinx>=5.0.0
move check_manifest configuration to setup.cfg.
global: clean test infrastructure

I need some help here. i figured out that the change from flask-login 0.4.1 to 0.6.1 is the problem. in particular version 0.5.0 of flask-login has implemented the change that now leads to the error. this PR is the problem.
do we have such a function that is necessary there?

bug fixed


cfgen: improve assert msg at pool drives check

Currently, the assert msg looks like this:
File "/opt/seagate/cortx/hare/bin/../bin/cfgen", line 1094, in pool_drives
  assert len(targets) == 1  # guaranteed by validate_pools_desc()
AssertionError

which gives no clue about what's wrong with the pool configuration.
Solution: improve assert msg so it looks like this:
File "/opt/seagate/cortx/hare/bin/../bin/cfgen", line 1096, in pool_drives
  else 'is preset at more than one node')
AssertionError: /dev/disk/by-id/wwn-0x5000c500301706db has wrong node: sage-tier2-2

cc @vvv

cc @vvv

I simplified the assert msg after the above comments. It's still useful and definitely better than nothing.

I simplified the assert msg after the above comments. It's still useful and definitely better than nothing.


fix(NavLink): Fixed navlink active state.

Fixing NavLink state per recommendation in #361 .  Seems to work for the example - @GregoryHamel thoughts on this?

@GregoryHamel Good call - that will be massively helpful with backward compatibility.  I implemented this suggestion (which required passing a prop all throughout our Navigation hierarchy).  Let me know your thoughts on the updates 👍

:tada: This PR is included in version 1.27.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Thanks for the fix!


Docs: Datepicker scroll

Docs say: 'Infinite scrolling through calendar months'
But there is nothing scrollable in the example.
Is this something that must be configured or not implemented?

The infinite scrolling isn't supported at the moment, but is one of the planned features.


Compatibility with Autofac v6

v6 Compatibility and version dependency checks ahead of release.

Doesn't look like this was ever released; does this repo need to be closed because it's been superseded by the generic host support in Autofac.Extensiosn.DependencyInjection?

The original intent was to make things more fluent, so instead of...
Host
  .CreateDefaultBuilder(args)
  .UseServiceProviderFactory(new AutofacServiceProviderFactory(b =>
    {
      b.RegisterType<T>();
    }));

...it could read just a tad nicer...
Host
  .CreateDefaultBuilder(args)
  .UseAutofac(b =>
    {
      b.RegisterType<T>();
    });

It wasn't included in Autofac.Extensions.DependencyInjection because we didn't want to tie that to the host builder; but, then, it's only three extension methods and doesn't add a whole lot. There wasn't clarity on whether we'd need more of these to help in complex situations.
I'm guessing not, though. And the cost/benefit of maintaining a package for three extension methods isn't great, so I don't know that we'd ever release it.
Yeah, we could probably, at a minimum, just close/lock/archive the repo. Might be worth keeping around for a bit just to see if .NET 5+ introduces complexity down the road?

That's fine, we can leave it for now; I just won't bother updating it for v6.


maestral activity crashes app on MacOS

Describe the bug
When running maestral activity in the Terminal, the app crashes (Traceback see below).
To Reproduce
Run maestral activity.
Does not depend on whether the app (GUI) is running or not.
Expected behaviour
Not crashing (I don't actually know what is supposed to happen, I was just poking at the CLI to get to know it).
System:

Maestral version: 1.5.2 (both deamon and GUI)
Python version: 3.9.10 (or at least that's what python3 --version outputs. Don't know if maestral uses this as opposed to other installations)
OS: MacOS 12.1 (Monterey) on M1 Pro

Additional context
Traceback (most recent call last):
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/runpy.py", line 196, in _run_module_as_main
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/runpy.py", line 86, in _run_code
  File "Contents/Resources/app/maestral_cocoa/__main__.py", line 41, in <module>
  File "Contents/Resources/app/maestral_cocoa/__main__.py", line 36, in freeze_support_cli
  File "Contents/Resources/app_packages/click/core.py", line 1128, in __call__
  File "Contents/Resources/app_packages/click/core.py", line 1053, in main
  File "Contents/Resources/app_packages/click/core.py", line 1659, in invoke
  File "Contents/Resources/app_packages/click/core.py", line 1395, in invoke
  File "Contents/Resources/app_packages/click/core.py", line 754, in invoke
  File "Contents/Resources/app_packages/maestral/cli.py", line 227, in wrapper
  File "Contents/Resources/app_packages/maestral/cli.py", line 1007, in activity
  File "Contents/Resources/Support/Python/Resources/lib/python3.10/curses/__init__.py", line 13, in <module>
ImportError: dlopen(/Applications/Maestral.app/Contents/Resources/Support/Python/Resources/lib/python3.10/lib-dynload/_curses.cpython-310-darwin.so, 0x0002): Library not loaded: /Library/Frameworks/Python.framework/Versions/3.10/lib/libncursesw.5.dylib
  Referenced from: /Applications/Maestral.app/Contents/Resources/Support/Python/Resources/lib/python3.10/lib-dynload/_curses.cpython-310-darwin.so
  Reason: tried: '/Library/Frameworks/Python.framework/Versions/3.10/lib/libncursesw.5.dylib' (no such file), '/usr/lib/libncursesw.5.dylib' (no such file)

Oh, this seems to be a duplicate for #589 and #533. Feel free to close this if no longer needed.

Indeed, a duplicate of #533. Will be fixed in the next release.


Undefined Location null error when querying

I've looked through other issues but can't find a solution. When I am making a query with my client, i get an error where all data is null
To Reproduce
Steps to reproduce the behavior:
// globals.dart
GraphQLClient client;

// main.dart
void main() async {
  ...
  HttpLink link = HttpLink(uri: "http://<IP_ADDRESS>:8000/graphql");
  client = GraphQLClient(
    cache: InMemoryCache(),
    link: link,
  );
  runApp(AppComponent(store: store));
}

I am using Flutter BLoC so i am calling the query in my BLoC method
loadEvents() async {
    try {
      QueryResult data = await client
          .query(QueryOptions(document: getPosts));
      print(data.data);
    } catch (e) {
      print(e);
    }
  }

const getPosts = '''
      query {
        event(id:5) {
            title
            description
            user {
              profile {
                forename
              }
            }
        }
      }
      ''';

I have tried both with and without ValueNotifier and with and without wrapping MaterialApp in a GraphQLProvider. same result
Expected behavior
I expect it to work? and produce the results from my graphql endpoint. i used PHPs GraphQL Playground with the exact same query and it pulled results... not sure what im doing wrong
Screenshots

Desktop (please complete the following information):

OS: Ubuntu
Version 18.04

Smartphone (please complete the following information):

Device: OnePlus One
OS: Android Pie
Version: 9.0

Additional context
I am using this in conjunction with the BLoC pattern. so I dont want to make requests withing my UI widgets.

See if the result hasErrors or is loading

Never mind.
A simple fact of knowing that localhost on my Android device does not mean my PC

#186 is similar


Auto field should be default hidden, not just jumped over

Current coverage is 100.00%

Merging #4 into master will not affect coverage as of 58635ea

@@            master      #4   diff @@
======================================
  Files            2       2
  Stmts          473     477     +4
  Branches         0       0
  Methods          0       0
======================================
+ Hit            473     477     +4
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 58635ea

Powered by Codecov. Updated on successful CI builds.

This will come as a part of another change..


Performance on MountainCar

Does anyone train the model on MountainCar-v0? I can only obtain the minimum reward -200. I tried both smaller sigma and larger sigma but none of both worked.

Hi, I also could not get the algorithm to work on MountainCar -- I would be interested if anyone could get it to work

With OpenAI's distributed ES, it appears that people have been able to get MountainCar working, but not ContinuousMountainCar: https://github.com/openai/evolution-strategies-starter/issues/9

For anyone interested: the main difference between OpenAI's code and mine seems to be the batch size. OpenAI collects a large number of samples (several thousand) before taking a gradient step, and this seems to be necessary for even mildly difficult problems.


Elaborate on timing issues in dmetro documentation

Motivations from this issue from Sporth.
dmetro has a few shortcomings which should be specified in the documentation.
Mainly, the things I wish to bring up:

sample accuracy vs sample precision (and how the latter is more important in this context)
why dmetro adds one sample to the duration in the seconds to sample conversion

Fixed in d7629c4


Theme-controlled color scheme switch

Description of the new feature/enhancement
It would be nice to be able to specify two schemes per profile; one for light mode and one for dark. I imagine that would be especially useful with "requestedTheme": "system".
Proposed technical implementation details (optional)
Could be implemented in the form of:
"colorScheme": {
      "light": "BlulocoLight",
      "dark": "BlulocoDark"
}

or:
"colorSchemeLight": "BlulocoLight",
"colorSchemeDark": "BlulocoDark"

I like the idea. It might make sense to instead of colorSchemeLight and colorSchemeDark preserve the existing colorScheme attribute and add an alternateScheme attribute which could be switchable to. Otherwise, an additional attribute would be required to specify which theme mode to startup with.
Alternatively, this feature could be implemented by making the color schemes themselves have dual palettes: one for light and one for dark. So you could assign to a profile a scheme, like Campbell, and have a hotkey to switch between light and dark palette.

I like the object idea since it doesn't use any other new name and instead uses current one. I'll elaborate on this bit
In vscode it was implemented as a 2 additional keys: preferredDarkColorTheme and preferredLightColorTheme. colorScheme key remain unchanged and the way it works, when vscode switches to appropriate theme, it changes the value of colorScheme in user settings (therefore updating the application visuals). This mechanism probably has something to do with the fact that vscode can't update settings in runtime without updating the file (https://github.com/microsoft/vscode/issues/43226), but I digress. I'm using a dotfiles repo on multiple workstations and automatic system theme switching (based on time of the day). And I'm constantly stumbling across situations when settings.json was updated remotely (by some meaningful stuff) and locally (colorScheme) which makes me do stash then pull again, then stash pop. It's also breaks automatic pull on dotfiles repo.
Of course it doesn't concern terminal since it doesn't update its settings in runtime when profiles.json is updated, but I still find it neat having string literal or object as config).
Having additional keys also increases ambiguity of (what will be selected?)
"colorSchemeLight": "BlulocoLight",
"colorSchemeDark": "BlulocoDark",
"colorScheme": "Campbell"

Adding alternateColorScheme is ambiguous in a sense that it's not clear what is dark and what is light, so I don't think it should be pursued

I like the object idea since it doesn't use any other new name and instead uses current one. I'll elaborate on this bit
In vscode it was implemented as a 2 additional keys: preferredDarkColorTheme and preferredLightColorTheme. colorScheme key remain unchanged and the way it works, when vscode switches to appropriate theme, it changes the value of colorScheme in user settings (therefore updating the application visuals). This mechanism probably has something to do with the fact that vscode can't update settings in runtime without updating the file (https://github.com/microsoft/vscode/issues/43226), but I digress. I'm using a dotfiles repo on multiple workstations and automatic system theme switching (based on time of the day). And I'm constantly stumbling across situations when settings.json was updated remotely (by some meaningful stuff) and locally (colorScheme) which makes me do stash then pull again, then stash pop. It's also breaks automatic pull on dotfiles repo.
Of course it doesn't concern terminal since it doesn't update its settings in runtime when profiles.json is updated, but I still find it neat having string literal or object as config).
Having additional keys also increases ambiguity of (what will be selected?)
"colorSchemeLight": "BlulocoLight",
"colorSchemeDark": "BlulocoDark",
"colorScheme": "Campbell"

Adding alternateColorScheme is ambiguous in a sense that it's not clear what is dark and what is light, so I don't think it should be pursued

Alternatively, this feature could be implemented by making the color schemes themselves have dual palettes: one for light and one for dark. So you could assign to a profile a scheme, like Campbell, and have a hotkey to switch between light and dark palette.

Unless someone builds a custom tuned color schema, this doesn't sound right to me. People's perception of light vs dark best colors might differ substantially (mine do), so IMHO making it a specific choice in the schema object makes sense.
I'm unsure of how Windows Terminal config schema backward compatibility is treated, but my suggestions would then be:
If it's OK to change the schema for an existing key:
"colorScheme": {    "light": "Foo Light",    "dark": "Foo Dark" }
And if it's not really OK to change the key type, then I'd introduce a new keyword (colorSchemes?) and deprecate the old one, maybe migrating the user configs on the fly with a new build version.

Any progress on this?

Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?

That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread ☺

Workaround:
I have an AutoHotKey script that I run at sun-up and sun-down that changes the themes for programs that don't change automatically like GitKraken and KeyWeb. Windows Terminal thankfully automatically changes if you change its settings file, so this Powershell script does what I want:
$from = $args[0]
$to   = $args[1]

$settingsPath = $env:LocalAppData + "\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json";
# https://stackoverflow.com/a/30893960
$content = [System.IO.File]::ReadAllText($settingsPath).Replace(
    "`"colorScheme`": `"" + $from + "`",",
    "`"colorScheme`": `"" + $to   + "`",");
[System.IO.File]::WriteAllText($settingsPath, $content);

It's blunt and fragile - you could probably improve it by using JQ or actually parsing the JSON. But I'm lazy and this simple string replace works. I didn't use AHK's string replace because that language gives me conniptions. I'm not sure my $settingsPath works for anyone else - find yours by hitting ctrl+shift+comma in WT.
I have the following function in AHK to make running Powershell scripts easier:
; https://www.autohotkey.com/boards/viewtopic.php?p=224271#p224271
PowerShell(Script, WorkingDir := "", Options := "", Params := "-ExecutionPolicy Bypass") {
    Run % "PowerShell.exe " . Params . " -Command &{" . Script . "}", % WorkingDir == "" ? A_ScriptDir : WorkingDir, % Options
}

Finally, with the following, I can hit ctrl+alt+win+PageDown to go to light mode, and PageUp for dark mode.
^#!PgDn::
PowerShell("./wt-theme-switch.ps1 'One Half Light' 'Campbell'")
Return

^#!PgUp::
PowerShell("./wt-theme-switch.ps1 'Campbell' 'One Half Light'")
Return

This assumes the powershell script is called ./wt-theme-switch.ps1 and it lives in the same directory as your AHK script.

I need to ~steal~ borrow this to add to my systray app which does the flippity on dark/light on command (for when I decide that I should work outside for a while to provide this meat suit with vitamin d). Good Jeorb!

@dharmaturtle, awesome! Just created a Windows schedule based on your powershell, so the theme auto update a 7AM and 7PM
https://gist.github.com/biutas/2a6132170f81319a282c7135abb3dce9

Added a specification file for this feature request.
https://github.com/microsoft/terminal/commit/f637d156023187e9fa4893d3a77a1328f58973ba

This is now the only app I use that doesn't match theme up with Windows light/dark mode (VS Code recently added it). So I'm slightly eager to hear when this feature is shipped 👍

For those who are using Auto Dark Mode: you can use its newly added script execution feature to automatically execute a script like the suggested above. I am successfully using it to automatically switch the colour scheme when my Windows 11 Dark Mode is toggled. It's still rather hacky, but better than the AHK method suggested, in my opinion.

I had trouble getting the powershell script to work with Auto Dark Mode, so I wrote a new (slightly more powerful) script in node. For anyone interested here is the script:
const { readFileSync, writeFileSync } = require("fs");
const { join } = require("path");

// color scheme configurations
// The dark scheme will be swapped with the light scheme and vice versa
const colorSchemes = [
  { dark: "Campbell", light: "Campbell Powershell" },
  { dark: "One Half Dark", light: "One Half Light" },
  { dark: "Solarized Dark", light: "Solarized Light" },
  { dark: "Tango Dark", light: "Tango Light" },
];

// parse argument to determine which mode to switch to
const modeArg = process.argv[2];
if (modeArg !== "-dark" && modeArg !== "-light") {
  console.error(`Invalid Argument. Argument must be '-dark' or '-light'. Received '${modeArg}'`);
  process.exit(-1);
}
const isDarkMode = modeArg === "-dark" ? true : false;

// read Windows Terminal config
const pathToWinTermConfig = join(
  process.env.LocalAppData,
  "/Packages/Microsoft.WindowsTerminal_8wekyb3d8bbwe/LocalState/settings.json"
);
const configFileContents = readFileSync(pathToWinTermConfig).toString("utf-8");
const config = JSON.parse(configFileContents);

// update Windows Terminal config
config.profiles.list.forEach((profile) => {
  const color = colorSchemes.find((c) => profile.colorScheme === c[isDarkMode ? "light" : "dark"]);
  if (color) profile.colorScheme = color[isDarkMode ? "dark" : "light"];
});

// write Windows Terminal config changes to file system
writeFileSync(pathToWinTermConfig, JSON.stringify(config, null, 2));

Below is the Auto Dark Mode script config. The Auto Dark Mode script file should be located in C:\Users\<username>\AppData\Roaming\AutoDarkMode.
Note: I saved the node script in the root of my C drive and named it toggle-win-term-color.js
Enabled: true
Component:
  TimeoutMillis: 10000
  Scripts:
    - Name: WindowsTerminal
      Command: node
      ArgsLight: [C:\toggle-win-term-color.js, -light]
      ArgsDark: [C:\toggle-win-term-color.js, -dark]
      AllowedSources: [Any]

Just to help clarify: a spec was accepted in #12613. We probably won't have time to get to this one soon, but I don't think it'd be a terribly difficult change to make. I'd be happy to give pointers if anyone's interested in contributing the code ☺

Hey All, attached is a draft PR of the work done now and the code cleaned up a bit. Right now there is two big bugs that are holding me back from doing the PR.  https://github.com/microsoft/terminal/pull/14064
First is there is no current way to trigger a settings refresh when OS Theme switches. Any advice on how to trigger an event when the OS Theme switches would be useful. WM_THEMECHANGED does not seem to be working in the message handler.
Second, the profile appearance control preview does not update to the "selected" choice for color scheme. I am still trying to debug this a bit, but any suggestions are accepted. I think this is because the preview pulls directly from the profile.defaultappearance, but we never offically save the defaultappearance "ColorSchemeName" because the user hasnt pressed save yet. So some future research will be needed to discover how to force this up.
There is future work needed with the GUI, but will not be apart of this PR as @carlos-zamora mentioned this would need some design considerations from the team.
For now, you can pull the branch and set the dark and light color schemes under the profile though and play around with it.
Can accept either single string or object.
example:
"colorScheme" : "One Half Dark"
or
"colorScheme":
{
"dark": "One Half Dark",
"light": "One Half Light"
},

Ill be traveling (Sep 23 2022) and will pick up work and considerations / conversations (Sep 24 2022)

Hey everybody. We've got a bit of a quandry here, that #14046 helped draw attention to.
Do folks want the scheme to sync to the Terminal's theme, or the OS's theme? These each come with pro's and cons.
For clarity, the Terminal theme is the window's applicationTheme, which controls the appearance of almost all controls in the app - the command palette, the tabs, the menus, etc. In 1.16, there are also Theme objects for more customization, but ultimately we're interested in the window.applicationTheme property (which is just theme before 1.16).

The Scheme is the colors of the box of text itself. Importantly, this controls the main background of the window.

OS theme:

If the user is automatically changing the OS theme based off time of day, the Terminal can automatically pick up on that
If the user is changing the terminal theme frequently, between light and dark themes, the scheme of the terminal won't reflect this. The user would need to change schemes to match.

Terminal theme:

If the user wants the scheme to match the OS theme, they need to set applicationTheme to system.
The default theme for the Terminal on 1.16 sets applicationTheme to dark, so users would necessarily need to also change the terminal theme if they want to use this feature.

It's a little wacky to get a dark titlebar, with OS theme set to light, and applicationTheme set to system:

We're kinda at an impasse here, and want to know what folks think. I suspect most people who are looking for this feature want the scheme to match the OS theme, always, regardless of terminal theme. But I don't want to make assumptions! Maybe folks are using a tool to swap the Terminal theme based on time of day instead!
There's also a mind to have the Terminal's theme match the OS theme with a similar syntax (draft spec), but I don't think that actually helps any of our problems here.

If the user is automatically changing the OS theme based off time of day, the Terminal can automatically pick up on that

This is all I care about. I'm not a friend of dark mode at day at all. And vice versa. It hurts my eyes.

If the user is automatically changing the OS theme based off time of day, the Terminal can automatically pick up on that

This is all I care about. I'm not a friend of dark mode at day at all. And vice versa. It hurts my eyes.

Same thing, I use a script to change the OS theme and some applications that don't have an option to follow it.
Just one addition: I would also like the option to change the scheme based on the OS theme but I am not sure if that should be the default or if there's enough info to have matching dark and light themes without user input. I think someone above mentioned VSCode having an explicit setting for dark and light schemes.

To me the most complete solution would look like this:

Application theme lets me choose light, dark, or system. This controls the "chrome" of the app (title bar, tabs, menus)
Scheme lets me choose two schemes: one for dark and one for light. Then, however I change the application theme (directly in Terminal settings, or by changing my system theme) I get a scheme that works for me. I can even set both schemes to be the same if I don't want them to change depending on app theme.

This would be my ideal behavior:

OS switches to dark mode (either due to time of day, or user has explicitly switched system theme)

Terminal theme (i.e. title bar, controls, menus, etc) switches to match
Terminal scheme switches to some custom scheme which I have explicitly designated as my "dark mode scheme", e.g. `

OS switches to light mode

Terminal theme switches to light
Terminal scheme switches to my custom "light mode scheme"

real quick clarity:

The difference between Theme and Scheme is very important here, lets try to not mix them up

Wow overwhelming initial feedback seems like folks want theme AND scheme to match the OS theme. That kinda sounds like an endorsement for "the scheme matches the Terminal's theme", and anyone who wants this feature manually changes their Terminal theme to system (which will mean the Terminal's UI and the color scheme will both reflect the OS theme).
Right?

will mean the Terminal's UI and the color scheme will both reflect the OS theme

@zadjii-msft well, yes and no. We want to be able to manually specify a scheme for each theme. That could mean a light scheme with a dark theme, or the more usual dark on dark and light on light. Being able to set a scheme per theme is the important bit IMO

Rough proposal: two new config properties: colorSchemeLight and colorSchemeDark. To preserve previous behavior, if the original colorScheme is explicitly set, then it is always used, regardless of the current theme. But if colorScheme is not set, and both colorSchemeLight/Dark are set, then we activate the "auto switching" behavior

@zadjii-msft I like the interpretation you just posted. It's the most straightforward / expected default behavior. However, are you sure you are linking to the correct PR?

SURE DIDN'T. Fatfingered that one. The correct PR is #14064.

For those who don't understand how to use new functionality:

edit "Terminal" settings manually(1.19.10573.0 GUI has no such option yet) in settings.json(how to find/open it)
at the "profiles"-> "defaults" section set desired schema for each theme:

"profiles":
{
     "defaults":
     {
          "colorScheme":
          {
               "light": "One Half Light",
               "dark": "Campbell"
          }
     },

This is great! But it would be better if the option was present in the UI


Adding aws_networkmanager_core_network_policy_attachment resource and base_policy attribute

Moving to version 2.x.x of the module. Things added:

Resource aws_networkmanager_core_network_policy_attachment added, to remove circular dependency when adding attachment IDs in the policy document definition.
base_policy attribute added.


New App Submission

App Logo (Required)

App Details (Required)
Type: Dapp
Name: ChangeNow
Homepage Url: https://changenow.io
Chains supported: ETH
App Url (Required - at least one)
Browser Url:
iOS Url: https://apps.apple.com/us/app/id1518003605
Android Url: https://play.google.com/store/apps/details?id=io.changenow.changenow
Mac Url:
Windows Url:
Linux Url:
Mobile Linking (Optional)
Deep Link: changenow://
Universal Link:
Desktop Linking (Optional)
Deep Link:
Universal Link:
Metadata (Optional)
Short Name: ChangeNow
Primary Color:
Secondary Color:

Added on commit c9187cf75bdc2f82df52786680c1fccab2a1e58f


fix error message in Utils.preAllocateFileIfNeeded

Output the error string which is the underlying string of InputStream instead of the string InputStream#hashCode

Codecov Report

Merging #691 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #691      +/-   ##
============================================
- Coverage      63.7%   63.69%   -0.02%
+ Complexity     3650     3646       -4
============================================
  Files           326      326
  Lines         24893    24894       +1
  Branches       3122     3122
============================================
- Hits          15859    15856       -3
- Misses         8164     8167       +3
- Partials        870      871       +1

Impacted Files
Coverage Δ
Complexity Δ

...ls/src/main/java/com.github.ambry.utils/Utils.java
69.4% <0%> (-0.32%)
67 <0> (ø)

...in/java/com.github.ambry.clustermap/Partition.java
82.43% <0%> (-4.06%)
23% <0%> (-1%)

...c/main/java/com.github.ambry.network/Selector.java
78.48% <0%> (-3.59%)
44% <0%> (-1%)

....github.ambry.clustermap/StaticClusterManager.java
75.11% <0%> (-1.85%)
77% <0%> (-1%)

...ain/java/com.github.ambry.router/PutOperation.java
89.9% <0%> (-0.23%)
69% <0%> (-1%)

.../main/java/com.github.ambry.store/HardDeleter.java
81.93% <0%> (ø)
42% <0%> (ø)
:arrow_down:

...in/java/com.github.ambry.store/BlobStoreStats.java
85.61% <0%> (+0.47%)
93% <0%> (ø)
:arrow_down:

...b.ambry.network/BlockingChannelConnectionPool.java
66.22% <0%> (+2.19%)
8% <0%> (ø)
:arrow_down:

...github.ambry.rest/AsyncRequestResponseHandler.java
90.81% <0%> (+2.29%)
23% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6d5d2...fc980a0. Read the comment docs.


Add diagnostics around the completion of downloads

To help with debugging the issue where files are not getting deleted

re-triggering CI before merging


Add and expand the JSON examples

I've been toying a bit with the new JSONB format and was struggling a bit to find some complete working examples. So in this PR:

Updates the existing example for the database/sql driver to use JSONB and also show how to retrieve and unmarshal a JSON column in a Go struct.
Adds an example on how to do the same with the lowlevel package, but instead using BindJSON() on statements and ColumnJSON() on query.

This is probably a good idea. I actually tried to convince the SQLite folks to add something similar to their docs:
https://sqlite.org/forum/forumpost/d0cec8d2b722af67
I'm not sure if dropping the "pure" JSON examples is a good idea, or if we should have both…

Then again, maybe twice the examples is just noise.

Mmm yeah, I was wondering about that. My thinking was mostly that JSONB should probably be what people (want to) use going forwards and it took me a second to realise I had to wrap them in jsonb() on insertion.

What do you think about the comments though? On both examples, if you agree.

Sounds good, I'll make the changes.


Update HubSpot docs for new privateAppToken auth

Proposed changes
We must update how customers authenticate with HubSpot due to them deprecating new API key generation. We are rolling out support for this tomorrow morning (Wed Aug 10) and need to update our docs accordingly. We also updated settings descriptions so would need a make catalog run. It's fine if we need to wait until Thurs Aug 11 to go out if we don't want to do a separate deploy.
Merge timing

ASAP once approved

Related issues (optional)
JIRA: https://segment.atlassian.net/browse/HGI-29

Thanks for approving @markzegarelli @stayseesong! Can we merge this in so it is deployed in tomorrow's release?


rolling replace of k8s nodes causes "No Cluster Leader"

Sometimes I have to use Kops to do a rolling replace of the current nodes and this requires moving the consul cluster master nodes to new k8s nodes. Every time this is performed I have to manually reconnect the consul master nodes. Does anyone know of a way to have the consul nodes reconnect after they move k8s nodes? This also happens with k8s node taints.

You need to keep the consensus. If you got 3 consul nodes, you need at least 2 working.
Ensure that you move the consul nodes never breaking this.

@santinoncs i dont believe that is the answer, since all k8s nodes will be replaced every consul server pod will be shutdown and moved which means the preStop action is getting called which calls consul leave. When the new instance of the consul server is brought back up there is no mechanism to have it automatically rejoin the cluster.

Yes, you need a rejoin mechanism. This is the one I am using
      - name: "{{ template "name" . }}"
        image: "{{.Values.Image}}:{{.Values.ImageTag}}"
        imagePullPolicy: "{{.Values.ImagePullPolicy}}"
        args:
        - "agent"
        - "-server"
        - "-client"
        - "<IP_ADDRESS>"
        - "-recursor"
        - "<IP_ADDRESS>"
        - "-bootstrap-expect"
        - "3"
        - "-retry-join"
        - "traefik-consul"
        - "-ui"```

This is an extract of my statefulset manifest

@santinoncs thanks for your help, i was able to remove the need for the k8s job by placing the retry-join in the statefulset like below
          args:
            - "agent"
            - "-advertise=$(POD_IP)"
            - "-bind=<IP_ADDRESS>"
            - "-bootstrap-expect=3"
            - "-client=<IP_ADDRESS>"
            - "-config-file=/etc/consul/consul.json"
            - "-datacenter=dc1"
            - "-data-dir=/var/lib/consul"
            - "-domain=cluster.local"
            - "-encrypt=$(GOSSIP_ENCRYPTION_KEY)"
            - "-server"
            - "-ui"
            - "-disable-host-node-id"
            - "-retry-join=consul.$(NAMESPACE).svc.cluster.local"

@nmnellis Could you share your yamls please? We are facing similar issues when GKE autoscales the cluster. Thanks!

@SukantGujar
apiVersion: apps/v1beta1
kind: StatefulSet
metadata:
  name: consul
spec:
  serviceName: consul
  replicas: 5
  template:
    metadata:
      labels:
        app: consul
    spec:
      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - weight: 100
            podAffinityTerm:
              labelSelector:
                matchExpressions:
                - key: "app"
                  operator: In
                  values:
                  - consul
              topologyKey: "kubernetes.io/hostname"
      nodeSelector:
        node.type: generic
      terminationGracePeriodSeconds: 10
      securityContext:
        fsGroup: 1000
      containers:
        - name: consul
          image: "consul:0.8.1"
          env:
            - name: POD_IP
              valueFrom:
                fieldRef:
                  fieldPath: status.podIP
            - name: GOSSIP_ENCRYPTION_KEY
              valueFrom:
                secretKeyRef:
                  name: consul
                  key: gossip-encryption-key
            - name: NAMESPACE
              valueFrom:
                fieldRef:
                  fieldPath: metadata.namespace
          args:
            - "agent"
            - "-advertise=$(POD_IP)"
            - "-bind=<IP_ADDRESS>"
            - "-bootstrap-expect=5"
            - "-client=<IP_ADDRESS>"
            - "-config-file=/etc/consul/server.json"
            - "-datacenter=dc1"
            - "-data-dir=/var/lib/consul"
            - "-domain=cluster.local"
            - "-encrypt=$(GOSSIP_ENCRYPTION_KEY)"
            - "-server"
            - "-ui"
            - "-disable-host-node-id"
            - "-retry-join=consul.$(NAMESPACE).svc.cluster.local"
          volumeMounts:
            - name: data
              mountPath: /var/lib/consul
            - name: config
              mountPath: /etc/consul
            - name: tls
              mountPath: /etc/tls
          lifecycle:
            preStop:
              exec:
                command:
                - /bin/sh
                - -c
                - consul leave
          ports:
            - containerPort: 8500
              name: ui-port
            - containerPort: 8400
              name: alt-port
            - containerPort: 53
              name: udp-port
            - containerPort: 8443
              name: https-port
            - containerPort: 8080
              name: http-port
            - containerPort: 8301
              name: serflan
            - containerPort: 8302
              name: serfwan
            - containerPort: 8600
              name: consuldns
            - containerPort: 8300
              name: server
      volumes:
        - name: config
          configMap:
            name: consul
        - name: tls
          secret:
            secretName: consul
  volumeClaimTemplates:
    - metadata:
        name: data
        annotations:
          volume.beta.kubernetes.io/storage-class: default
      spec:
        accessModes:
          - ReadWriteOnce
        resources:
          requests:
            storage: 10Gi

Thanks @nmnellis!

I tried this today at my end. The initial deployment worked flawlessly without the need for the join job! Then I deleted the statefulset and recreated it. This time the pods still failed to join, as Kubernetes provisions them with a different internal IP. Any tips?

In the statefulset I use this arguments in the image consul ( 0.7.5 )
        args:         - "agent"         - "-server"         - "-client"         - "<IP_ADDRESS>"         - "-recursor"         - "<IP_ADDRESS>"         - "-bootstrap-expect"         - "3"         - "-retry-join"         - "traefik-consul"         - "-ui"

Thanks @santinoncs. Could you please explain what exactly these settings do? The problem I am facing is that the older cluster has different internal IPs for the consul pods. These RAFT information stored in PV contains those IPs. Now if the pods all go down and get back up, they have different set of IPs and then rejoining fails because the leader cannot be elected anymore.

I am using consul cluster as a backend service of traefik reverse proxy.
And I am using this approach.
https://blog.osones.com/en/kubernetes-traefik-and-lets-encrypt-at-scale.html
When rejoining, you should use a service ( round robin/cluterip: none ) in my case: "traefik-consul"
And the data stored in the PVs may be is not right anymore. So, you must ensure that the consensus is not broken. And how to do that?
If you got a 3 nodes cluster, you should never got less than 2 alive. If so, you will lose consensus and the consul cluster.

Thanks! Sadly, for us minimal pod survvial is unavoidable when GKE is scaling up the k8s cluster nodes (Autoscaling alpha feature). This causes the currently available clusters to shutdown. I guess the only way out is manual revival. Actually we are using Consul as a config manager which serves mostly read-only config, so we don't need even two pods. But I haven't had success even with a single pod revival.

Problem we succesfully bypass was the drain/upgrade gke version. With the PodDisruptionBudget and drain, we manage to not lose the consensus. Always got 2 nodes minimum alive.
But I didnt try yet the autoscaling feature.

Thank, will try experimenting with the disruption budget as well.


Fix bit shift direction in init

Bit shift direction in AccInit fix

This pull request has been refused, the Contribution License Agreement must be signed.


Proper logging setup

We should provide proper logging configuration in settings.py. See https://docs.djangoproject.com/en/3.1/topics/logging/#configuring-logging

The AdminEmailHandler is currently working fine, meaning we are notified about all ERROR messages. We could enable logging of INFO or WARNING messages to the console and let uWSGI log them to its logfile (as in https://stackoverflow.com/questions/46747036/which-django-python-handler-class-will-pass-logs-to-the-uwsgi-logger). Currently there isn't really a need for that.


Broken HDR

With this tweak the HDR output is broken.

Nothing that STALKER2Tweak does should affect HDR. Are you making sure you're running in borderless mode? (HDR won't work without borderless in this game)

Sorry, i don´t know why, but this issue is gone.


Global search bar

Handles https://github.com/oceanprotocol/market/issues/665
Highly WIP. Functionality is sort of there.
What search pattern should we follow?
A. Easier way, like amazon

B. More design work (on mobile)

Bonus feature : search should trigger on 'enter'

B would be so nice but that's a lot to refactor I guess. So from behavior standpoint would go with A, but visually combine the two where the search field starts collapsed as search icon button only, and as viewport gets bigger search field can become more visible like Rarible does. On mobile the search field upon interaction can still take over the whole bar on top of other elements, but then searching still only happens when user hits enter.
But then we need to make sure when user arrives on search page that searchbar is open by default

I think you managed to design a more complicated way 😆. Ok i'll try to get in in a place where just UI changes are needed

draft 1 fullscreen

Some more work needed on the button and behaviour

Needs more testing.

There are bugs when searching by owner or tags (when you click on owner or tag in asset details) that will be fixed once we merge main in the multinetwork branch.

The styling is good. Only one small thing I would suggest is there should be more padding on the right of the History link.
So it changes from this:

To this:

It terms of the search functionality, I'm noticing a couple issues which I thought we had solved in: https://github.com/oceanprotocol/market/pull/641

The results don't include a partial match. For example, if you search "data union" you'll find that "dataunion.app" doesn't appear in the results
Searching with a trailing space effects the search results.

@jamiehewitt15 search fixed were not merged, so basically this is the old search with multiple bugs. Those will be merged in the multinetwork branch.
I'll add some padding where you suggested

Main is now merged.

The results don't include a partial match. For example, if you search "data union" you'll find that "dataunion.app" doesn't appear in the results

This was not fixed, requires more work, it's a bit more complicated.

Removed comments, should be ok now

Looks good, I have approved