KNOX-1826 - Replace zip4j with ShrinkWrap

What changes were proposed in this pull request?
Replace zip4j dependency with ShrinkWrap
How was this patch tested?
mvn -T1C verify -Ppackage,release
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  16:21 min (Wall Clock)
[INFO] Finished at: 2019-03-14T11:38:15-04:00
[INFO] ------------------------------------------------------------------------

Need to run some manual checks to deploy applications that are packaged as wars but changes look reasonable.

Manually checked that extracted application is the same with Knox 1.2.0 and after this patch.

Download sample war: https://tomcat.apache.org/tomcat-8.5-doc/appdev/sample/
Create applications directory with sample war

# ls -lR data/applications/sample/
total 8
drwxr-xr-x  3 krisden  staff    96 Mar 14 12:30 app
-rw-r--r--  1 krisden  staff  1913 Mar 14 12:28 service.xml

data/applications/sample//app:
total 16
-rw-r--r--@ 1 krisden  staff  4606 Mar 14 12:18 sample.war

Ensure there is a topology with:

<application>
  <name>sample</name>
</application>


Cant exclude XP-gain channels

There is a command that shows what channels are excluded from gaining xp with the new xp system, but there is not a way to add a channel to that list as of now?

.xpex channel #channelname

thank you for that. This is not in the command documents page though^^


Allow for modifying inner-builds packages from outer-build

This issue is primarily a response to the issue of vulnerable packages being brought in as part of WorkerExtensions.csproj. Today there is no convenient way to manually update these vulnerable packages from the outer-build. This issue is to track an enhancement that will allow for modification from the outer build.
Goals

Provide a mechanism for extensions, or end users, to directly modify the package references used by WorkerExtensions.csproj

The intent is for extensions to be able to address transitive dependency CVE's from the WebJobs extension they rely on.

NEEDS FURTHER CONSIDERATION: Have this MSBuild-based approach be an alternative to the extension assembly attribute used today

There is loss of context when shifting from an attribute to the msbuild item: we need to identify which of these items we add to extension.json. Additionally, today we default to including an extension only if a trigger or binding from it is actually used.

Non Goals

Deprecate extension assembly attribute.

We will continue to support this, but we will most likely shim these assembly attributes to MSBuild items added from this work.

Preliminary Design
We will introduce a new MSBuild item group which can be used to add or update packages on the inner build.
<Project>

  <ItemGroup>
    <FunctionsExtensionsPackageReference Include="System.Net.Http" Version="4.3.4" />
  <ItemGroup>

</Project>

The above will add an explicit <PackageReference Include="System.Net.Http" Version="4.3.4" /> to the WorkerExtensions.csproj.

We discussed this and have decided not to proceed with this design for the time being. We will instead improve our validation to ensure we are keeping extension packages up to date.
#2237

We are reconsidering this feature

It is critical for our team to have a way to add or update packages on the inner build. We have critical CVE items against our team that we cannot resolve because of the WorkerExtension.csproj inner build.
Could we please get an update on this feature?

Another issue was opened recently that talks to the need for this feature.
#2593

Currently dealing with 3 dependencies that are referenced from generated WorkerExtensions.csproj project that are vulnerable, while I can't override package versions to resolve the issues from my own function project:

System.Text.Json (4.7.2)
Azure.Identity (1.10.2)
Microsoft.Identity.Client (4.54.1)

I have issues with the same dependencies In the same project.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Max @.>
Sent: Tuesday, July 16, 2024 7:44:42 AM
To: Azure/azure-functions-dotnet-worker @.>
Cc: Jose Sosa @.>; Comment @.>
Subject: Re: [Azure/azure-functions-dotnet-worker] Allow for modifying inner-builds packages from outer-build (Issue #2221)
Currently dealing with 3 dependencies that are referenced from generated WorkerExtensions.csproj project that are vulnerable, while I can't override package versions to resolve the issues from my own function project:

System.Text.Json (4.7.2)
Azure.Identity (1.10.2)
Microsoft.Identity.Client (4.54.1)

—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-functions-dotnet-worker/issues/2221#issuecomment-2230686196, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDMAHFYF7R3EHYSSX3T37LTZMUBSVAVCNFSM6AAAAABCA5MUJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGY4DMMJZGY.
You are receiving this because you commented.Message ID: @.***>

There was a #2604 but it has been deleted.
In addition to the ones mentioned by @MaxMommersteeg, the SignalR integration pulls in System.IdentityModel.Tokens.Jwt and Microsoft.IdentityModel.JsonWebTokens, both of which are affected by CVE-2024-21319

We have currently 3 dependencies that are referenced from generated WorkerExtensions.csproj project that are vulnerable, we can't override package versions to resolve the issues. We have created a new issues last week, however it was deleted: https://github.com/Azure/azure-functions-dotnet-worker/issues/2793. Please, prioritize this since we have 3 very critical Component Governance alerts. We will appreciate any advise on how to solve de dependencies vulnerability on WorkerExtensions.csproj project.


Scholarships

Changed link label per Farrah request.
Updated Scholarship emails per Mike request.
Avoids known problems with Salesforce's test system.

I'm happy to review and merge this myself if Thad says it's alright, but wasn't certain whether we had a guideline of a second pair of eyes before merging to master.


[bug] yarn start react template

Describe the bug
yarn run v1.22.10
$ cross-env BROWSER=none react-scripts start
/Users/davirain/davirain/hello-world/node_modules/@babel/template/lib/options.js:55
  if (syntacticPlaceholders

SyntaxError: Unexpected end of input
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1026:15)
    at Module._compile (node:internal/modules/cjs/loader:1061:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/davirain/davirain/hello-world/node_modules/@babel/template/lib/builder.js:8:16)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)

Node.js v17.6.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Reproduction

select react template
yarn start

Expected behavior
No response
Platform and versions
Operating System - Mac OS, version 12.0.1 X64

Node.js environment
  Node.js - 17.6.0
  @tauri-apps/cli - 1.0.0-rc.5
  @tauri-apps/api - 1.0.0-rc.1

Global packages
  npm - 8.5.1
  pnpm - Not installed
  yarn - 1.22.10

Rust environment
  rustup - 1.24.3
  rustc - 1.61.0-nightly
  cargo - 1.61.0-nightly
  toolchain - nightly-aarch64-apple-darwin

App directory structure
/node_modules
/public
/src-tauri
/.git
/src

App
  tauri - 1.0.0-rc.3
  tauri-build - 1.0.0-rc.3
  tao - 0.6.3
  wry - 0.13.3
  build-type - bundle
  CSP - unset
  distDir - ../build
  devPath - http://localhost:3000/
  framework - React

Stack trace
No response
Additional context
No response

Did this error happen after it was generated with create-tauri-app? It looks like the error happens when you attempt to start it up after it was generated. Does the error go away if you remove (your node_modules) and try reinstalling?

Did this error happen after it was generated with create-tauri-app? It looks like the error happens when you attempt to start it up after it was generated. Does the error go away if you remove (your node_modules) and try reinstalling?

ye, just remove 'node_modules' also have problem

do you still encounter this issue when creating new apps?


Can Parser Elf File

i want to get Variable and address,type from elf,and add to a2l file.

this is a ELFParser,but not support DWARF4:https://github.com/csholmq/ElfParser

If you need DWARF4 support for the ELF Parser I would guess that you create an issue over there instead.
What exactly is your concern with my A2LParser?

i want to Modify Measurement 's address from ELF File


Enable configurable root URL paths

Allow this app's URLConf to be parented in more places than just /account/.
Description

This PR removes the /account/ prefix from this app's URLConf, allowing developers to choose for themselves what URL prefixes they would like.
To ensure backwards compatibility, I adjusted the root URLConfs in the tests project and the example project to still use the /account/ prefix. Furthermore, I also adjusted the documentation to instruct users to do the same:
...
urls = [
    path('account/', include('user_sessions.urls', namespace='user_sessions')),
]

Advanced users should hopefully understand that they can adjust that prefix to whatever they'd like, and beginner users will simply mirror the documentation and continue with the previous behavior.
Motivation and Context

The previously behavior isn't necessarily congruous with django-allauth, which uses /accounts/, and other users might want different prefixes altogether.
Closes #43 and #47.
How Has This Been Tested?

I updated the URLConf in the tests project and relied on GHA tests.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes. - N/A
[ ] All new and existing tests passed.

Assuming that tests for Python 3.7+Django 3.2 pass (currently running), test results for this branch have not changed from test results for master.

Needs rebase


How to get checkbox value in "onChecked" callback

I would like to retrieve the value of checked checkbox when the "onChecked" callback invoked. However it seems impossible because there is no parameters provided in the callback and the "this" refer to the root object instead of context. is there any way to locate the triggered checkbox inside the callback?

https://jsfiddle.net/km4vqq7j/

this inside onChecked is the radio input.
https://jsfiddle.net/hw3kuc4r/


Updating the existing annotation

I have created an xml for annotating the image using the following command,
imglab -c mydataset.xml ./
After annotating the images, I have added a few more images to the dataset. How do I update the "mydataset.xml" with the newly added images without having to remove the existing annotations?

Checkout imglab -h.
I would create a new dataset with all the new images with the command you listed above, and then merge both datasets with imglab --add mydataset1.xml mydataset2.xml. But again, check the help (and backup everything before!)


Refactor Preview: Line/Column numbers shown on Edits

Hi Team,
At the moment the edits in Refactor Preview panel are only grouped by file. Assuming that there would be multiple changes on lines/ columns that are not far apart it might be helpful to provide a hint to the user, about the start line/column number of an edit.
It also removes the need for clicking on each edit to understand which one exactly it is, when user is just scrolling through the editor & not interacting directly with the panel.

This hint should be shown for both the left & right side respectively. (Although there is a possibility that in bigger edits the right side position would not be easily visible. In that case anyhow the left hand side is helpful at least)
This display of line/column numbers should be bound to a user setting, so the user can enable/disable this behavior.

Additional Infos:

VS Code Version: 1.73.0
OS Version: CromeOS 104.0.5112.83

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


I have 2 problems. Please help.

when using "shortcutIconAsset: ShortcutIconAsset.androidAsset", it doesn't show icons in version mode, just a black square (maybe it doesn't do the same for every icon, I don't know).

When I use a shortcut while the app is open in the background, instead of picking up where it left off, it restarts and performs the action of the shortcut

I also had problem #2

me too


iOS: In full screen mode, tapping on the story content hides the feed bar

The feed bar should stay visible. While we're here, it would also be nice if the feed bar could stay pinned to the top but then scroll with the story content when dragged down. Similar to how the story traversal buttons are pinned to the bottom but then scroll with the story content when dragged up. So yes, this issue is a two-fer.

I will be making changes to the implementation of the fullscreen feature as part of the big Catalyst-related project, so unless this is really bothersome, I'd prefer to defer this until after that.

Sounds good to me, we can close this issue then.

Old issue, no longer applicable.


Refactor cosmos public API surface to reuse other public APIs

This issue is to refactor the cosmos public API surface.
Coming from discussion on this PR : https://github.com/Azure/azure-sdk-for-java/pull/12867#discussion_r452563451
Add null check for request options : https://github.com/Azure/azure-sdk-for-java/pull/12867/files#r453084111
Check null pointers upfront on public surface for options.
Always pass nested / non-nested values to context object, so as to make it mandatory for new APIs. more info here : https://github.com/Azure/azure-sdk-for-java/pull/12867#discussion_r452567872

@simplynaveen20  - can you please provide an update on this issue ?
If there is nothing more to be done here, please close it.


Build third-party service mojoms in service-specific repos

We are temporarily putting mojoms for third-party services in the main engine repo. Right now, when engine releases come out, the firebase-dart project needs to be updated to ensure that the mojoms and implementations stay in sync. I put instructions about this into https://github.com/flutter/engine/wiki/Release-process. We should be building self-contained jars + Dart wrappers that aren’t tied to a specific version of flutter_engine, but rather to a specific version of the third-party service. To do this we should have infrastructure for putting the mojoms and Dart wrappers in the same repo on GitHub and having travis build that builds the binary artifacts and uploads them to the cloud.
cc @abarth

Presumably this is no longer an issue now that we're deprecating mojo-based plugins?

Agree


Image viz test

What does this PR do?
Unxfails an ImageVisualizer test and adds a test to make sure that ImageVisualizer + W&B doesn't cause problems.
What issue(s) does this change relate to?
Fixes CO-1181
Tests for the fix to the bug in CO-1169
Before submitting

[x] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[x] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[x] Did you update any related docs and document your change?
[x] Did you update any related tests and add any new tests related to your change? (see testing)
[x] Did you run the tests locally to make sure they pass?
[x] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eracah sure, I'll put a tensorboard test on the backlog


#76 database

Now with DB backend and REST endpoint to fetch violations and to check and comment them.

Coverage decreased (-4.53%) to 19.77% when pulling 7dcdd2331085936984c29d5c792d9ab72260d71c on #76-database into bce05543f06749ef7d43a7683461ee25400eecba on master.

Coverage decreased (-4.53%) to 19.77% when pulling 12f9ebcd73e1e432195a9d2cb812ddbd29fd8cf9 on #76-database into bce05543f06749ef7d43a7683461ee25400eecba on master.


Providing both xctestrun-path and test-bundle-path param is extraneous

Bluepill needs either xctestrun-path or test-bundle-path param, but not both. We need to error out if both are provided to avoid confusion.

@ravimandala  any updates?


fix: dont mess up EXCLUDED_ARCHS[sdk=iphonesimulator*] after pod install

Summary
https://github.com/facebook/react-native/issues/31118
When running pod install on an M1 machine, the xcodeproj file is messed up and while it works for M1 machines, it doesn't on other non-M1 machines, and also doesn't work on ci, since usually they don't use M1s.
This change makes sure that it will not mess with the xcodeproj file.
some real world usage:

https://github.com/artsy/eigen/blob/main/patches/react-native%2B0.66.5.patch#L150-L154
https://github.com/artsy/eigen/blob/main/HACKS.md#react-native-patch-package-excluded_archs-part-only

Changelog

Test Plan

You can try to run pod install on an m1 and a non-m1, and see that the EXCLUDED_ARCHS[sdk=iphonesimulator*] don't change.

woops. i think i had it flipped. nvm.


Trim trailing newlines

fix regression for https://github.com/excalidraw/excalidraw/pull/454 introduced in https://github.com/excalidraw/excalidraw/pull/947 (by trimming trailing newlines which have no usefulness and mess up bounding box height calculation, and they're also added on FF by default for multiline texts)
also I'm trimming whitespace-only texts which would result in invisible text elements

Bad commit tree. will Fix.

One approval down, so I'l merge this to fix the user-facing issues. If we want to tweak this later, we'll make another PR.

The firefox thing is something different: it tends to insert trailing newline even when the contenteditable didn't contain it (or maybe it does in FF, dunno -- the key thing is: user didn't insert the newline). This may affect other non-chromium browsers, too.
That said, what do you feel is a use case for retaining leading/trailing newlines? When is it ever a useful thing?

My general stance with text inputs is to never mess with the content. If the person entered some weird things, just render them as is instead of trying to mess with it. There are so many ways this can backfire.
In this particular example, if someone added empty new lines but it looks the way they want, then when they "commit", it should stay as is and not move. I've used this many times in powerpoint for example to align stuff.

I generally agree with you, and I'm aware you expressed this in your PR, which is why I went with minimal necessary solution → trimming only \n, not spaces.
But I still believe in our case specific case, it doesn't really hurt.
Anyway, if we wanted to not trim newlines, I think we'd have to migrate from contenteditable to textarea (if at all possible), because contenteditable has a lackluster cross-browser support.
Consider this:

in chrome, typing aaa{Enter}bbb results in:
aaa
bbb

in firefox, typing aaa{Enter}bbb results in:

aaa

bbb

in chrome, typing aaa{Shift+Enter}bbb results in:
aaa
bbb

in firefox, typing aaa{Shift+Enter}bbb results in:
aaa
bbb

in chrome with plaintext-only (which we're currently using for browsers that support it, which is currently chromium-only), typing aaa{Enter}bbb or aaa{Shift+enter}bbb results in:
aaa\nbbb

(newline char, not
)

From the above, it follows that there's no way to figure out what trailing newline was indented by the user. We could maybe intercept the keydown and rewrite how contenteditable handles newlines...

Yeah, contentEditable is annoying. I'm fine with the current behavior if it means we don't have to deal with all the crazyness.


mev-boost: init at 1.6

Description of changes
MEV-Boost is middleware that allows Ethereum validators to access the block-building market.
See project github here.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266712 run on aarch64-darwin 1

1 package built:

mev-boost


C# mapping is not required

Currently the csharp is mapped to cs and the plugin tries to load prismjs/components/prism-cs.js. However, prism.js has it as prismjs/components/prism-csharp.js.
Suggestion is to revert the mapping (cs->csharp) or remove the mapping.

I think your suggestions are reasonable and would be considered a fix  but I wonder why the mapping from csharp => cs was created to begin with?   Maybe this has always been a bug but I'm not sure.
Let me do some quick investigation first before fixing the mapping.

I know that cs is the valid shortcut for csharp so I assume the mapping was intended to be there but got reversed and never worker.

That is what i'm concluding as well.  I'll submit a fix by reversing the mapping.

@alexeyzimarev I published the fix to NPM.  Please try now.

Yeah, thanks, it works fine 👍


SAK-40085 - Loss of information when a student add content in student…

… page

Reverting a lot of change, the easiest fix seems to be to just ensure the studentPageGroupMembers never returns a null value.


🚀 Feature: OpenTelemetry Metrics

Which component is this feature for?
All Packages
🔖 Feature description
Some values, like token usage, are better reported (also) as otel metrics. We should update all instrumentations to send metrics as well as traces.
🎤 Why is this feature needed ?
More ways to use the outputted data. Observability platforms can use metrics to set alerts on or to create dashboards.
✌ How do you aim to achieve this?
This needs to be researched and defined. Please consult on slack before starting to work on this.
🔄 Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
None

@quest-bot stash 300

@quest-bot embark

@quest-bot embark

@quest-bot embark

some upstream progress on metric definition https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-metrics.md @naghost-dev if it helps your work in progress

hello, looking for metrics, is this available?

Supported on some instrumentations, we're adding more everyday - specifically langchain isn't supported yet unfortunately.

@quest-bot embark


doc: application: coccinelle: Add information about coccinelle list

Add link to coccinelle mailing list info and archives.
Signed-off-by: Himanshu Jha<EMAIL_ADDRESS>

Codecov Report

Merging #11456 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11456   +/-   ##
=======================================
  Coverage   48.38%   48.38%
=======================================
  Files         265      265
  Lines       42193    42193
  Branches    10137    10137
=======================================
  Hits        20413    20413
  Misses      17703    17703
  Partials     4077     4077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b010cd7...efdb6e8. Read the comment docs.


feature(manager): added the use the agent's check-location command

@ShlomiBalalis any reason this is still in draft ?

@ShlomiBalalis can you fix the pre-commit issue ?


Rewrite 917 pinctl

The current implementation has several pitfall:

It is not possible to define several pins and extra values are ignored without warnings
There is no comprehensive list of possible pinmux configurations

Done with commit d3d7179


User Defined Extension Groups/Sets to Easily Enable, Disable, and Uninstall Extensions

I would like to be able to assign extensions on my installation of VSCode to a group that I label, and on a per-workspace basis, enable and disable extensions by group using the right mouse button or the command bar.

/duplicate


[App Services]:Import App Service Certificates into a Web App using the Azure CLI

Is your feature request related to a problem? Please describe.
We're using App Service Certificates rather than PFX files imported into Certificates in the Key vault. The problem is the key vault "certificate" created during the enrollment process goes into the Secrets category in the Key Vault. Consequently, the az webapp config ssl import command doesn't find the certificate in the key vault.
Describe the solution you'd like
I'd like the ssl import command to also check the secrets category in the keyvault if the certificate by the name provided cannot be found. I know, I know, the actual root cause here is the App Service Certificate creation process using the wrong key vault category! But, we can import App Service Certificates into an App Service via the Web UI, so it's be great to be able to do it in the Azure CLI too.
Describe alternatives you've considered
We have to export the app service certificate to PFX, then import it into the key vault again, this time to the Certificate type. sigh
Additional context
We have to do the PFX import every year. What a BORE.

webapp

@ThejaChoudary - try to repro the issue.

@tsgenge APP service certificates do use KV - however you cannot use the Import app service certificate command for App service certificates - we will have separate commands for those in the future. Thanks!

We don't have an ETA on supporting this - we will add a milestone when we have a timeline to share.

@singlessis is working currently on this

@panchagnula @singlessis  any updates on this one?

@panchagnula @singlessis any updates on this one?

Still in PR @btardif!


unable to open more than one programs at the same time

when you're opening something like osu!lazer, fluXis would refuse to open and vise versa (it report STATUS_SUCCESS after closed)
for some reason, you can open Vigette and osu!lazer (or fluXis) just fine, probably because it(Vigette) is using the old version of the framework
you can watch an example video here:
https://streamable.com/yxxxtb
tested using:
osu!lazer 2023.1231.0
fluXis Hotfix v2024.1.1
environment:
windows 11 enterprise insider preview build 26020
r5 6600h
rtx 3050ti

probably because it(Vigette) is using the old version of the framework

No. Root cause will be in here: https://github.com/TeamFluXis/fluXis/blob/5890fbe6487e3323c379a83454f935d5a0f4f346/fluXis.Desktop/Program.cs#L25-L45
fluxis instance thinks the previously opened osu! instance is the primary instance of itself rather than a completely different framework app.
The ipc port probably needs to be configurable per framework app:
https://github.com/ppy/osu-framework/blob/master/osu.Framework/Platform/DesktopGameHost.cs#L18


[BUG] Scaling of time axes on bar charts

See this example.
Expected behaviour
The first data label is the same time as options.scales.xAxes[0].time.min, so the first bar should be at the very left side of the chart (the axis itself is drawn correctly with the tick mark at this point).
Current behaviour
There is a wide gap (approx. 1/4 of the width of the chart) between the tick denoting midnight, 24 July 2017, and the bar with that label.  Note that the width of this gap depends on how much of the x-axis domain the labels on the data fill; if you extend the dataset in the example so that it covers the whole of the domain set by min and max, the gap is barely noticeable.
Possible Solution
I don't know of any.
Steps to Reproduce (for bugs)
See the pen linked above.
Context
I'm trying to plot a timeseries and for obscure reasons, the field I'm doing it in normally uses bars to represent them, not line charts.  I'm trying to present a week of data at a time, with the scale of the X axis remaining the same even if I only have a few hours of data for that week.
Environment

Chart.js version: 2.6.0
Browser name and version: Chrome 59.0.3071.86 (Official Build) (64-bit) on Ubuntu 17.04
Link to your project: Nothing online as yet.

This should be fixed already in master. @simonbrunel and @benmccann have the details

I don't totally understand what you're saying you expect to have happen. However, there was a recently introduced mode:series in the time scale in master that you'll probably want to use if you're trying to plot a time series chart. Can you try it and see if it fixes your problem?

@tomkcook is https://codepen.io/anon/pen/RZNvqJ better?
I think that's a dup of #4562

@simonbrunel I guess it's better, but still not right.  Perhaps this demonstrates the problem more clearly: https://codepen.io/tomkcook/pen/KvpwWZ.  All the labels are times on 24 August, but the bars clearly spill over into 25 August.
@benmccann I don't think 'mode:series' helps.  I definitely want a linear x axis.

SUMMARY:
Looks like 2 problems.  1 is different time zones for the data labels and the ticks.  The other is where the position of the bar is relative to the time axis.
I reproduced the starting PEN example as a jsfiddle to play with.  It seems that if/when the xAxes is specified as time type for a bar chart, the relationship between the data point labels and time is rather vague.  Starting from the clone, I adjusted the first label date.  2017,7,23,0 shows just fine, but still well past were the time axis says the 24th should be.  In fact it looks right at the end of the tick text for the 24th.  Changing the date to 2017,7,22,23 causes the time axes tick to rotate about 45°, the first tick is still the 24th, and the bar is still visible after the 24th.  The earliest time still visible is 2017,7,22,21.  20 hours looks to be right on the vertical axis.
Changing the last label instead, going from 2017,7,26,0 to 1 hour later adds a tick label and grid line for Aug 26, that is well before final bar.  Going from 2017,7,28,0 to 1 hour later, and  2017,7,30,0 to 1 hour later, adds a tick label and grid line for Aug 28 and Aug 30.  Again well offset from the actual bar.  The latest label where the bar is still visible is 2017,7,30,7, which is almost on the Aug 31 (final) grid line.  Changing only the final date label does not cause the ticks to rotate.
Going a different way, I changed the original chartjs version to a build of f16d8a3 that I was using for something else.  That started with ticks every 2 days from Aug 24, ending with Sep, due to the code changes for major/minor time ticks.  Adjusting the dates for the first and last labels again, the earliest I could still visually see, was 2017,7,23,6.  The latest, 2017,7,31,4.  Which correspond close to the start and end grid lines.  No tick rotation jumps with any of that.  With this version, these settings, I am seeing about an 18 to 20 hour offset between the tick labels and the time axes ticks.  That changes when I set the unit to hour, and reduce the time maximum.
Changing , or removing the barThickness did not seem to adjust the position of the bars, though it did only add to one (the lower) side.  It looks like the origin (placement) point for a bar is at the far (higher) end, but the label point is at the start.  Removing the barThickness setting, to let chartjs pick a default, got the start of the first bar a lot closer to the Aug 24 tick label and y axis.  Now (with the f16d8a3 build), 2017,7,23,19 looks to touch the Y axis.
I don't know if this is involved, but my time zone is GMT-0600.  Could part of the problem be date to text to date conversions, mixed with time zones?  Hover is explicitly showing me times in GMT-0600 corresponding to the data labels.  IE Hover for the second bar shows
Thu Aug 24 01:00:00 GMT-0600 (MDT) # of Votes: 200
I can not directly see what time zone is in use for the ticks, but the test above with no barThickness looks VERY close to a 6 hour offset.

FYI I am in the UK, so my current timezone is BST (UTC+1).

Maybe I was not explicit enough.  IF the local (browser) time zone is a factor (not just the time zone set for the web server), then what each of us see for a single live fiddle (or other) could be different.  I was explicitly taking advantage of that for one set of charts I worked on, to show the tooltip times in the users own timezone, while storing all the data in GMT.
Someone in a different timezone might, or might not, be able to replicate what I did, using the same numbers (date/times) I used.  If the same results are seen everywhere, then the local time zone can be crossed off as a likely source of the issue seen.


Error Reporting: Docs for HTTPContext incorrect

The documentation for error_reporting.client.HTTPContext gives the wrong parameter names.
>>> from google.cloud import error_reporting
>>> client = error_reporting.Client()
>>> user =<EMAIL_ADDRESS>>>> http_context = HTTPContext(method='GET', url='/', userAgent='test agent',
...                            referrer='example.com', responseStatusCode=500,
...                            remote_ip='<IP_ADDRESS>')
>>> try:
>>>     raise NameError
>>> except Exception:
>>>     client.report_exception(http_context=http_context, user=user))

Reading the code, it's clear that the camel-cased names are internally used to match expected JSON keys for the underlying API call, but the actual parameter names are properly snake-cased. Oddly, the docs do show the correct parameter name for remote_ip, but not user_agent or response_status_code.
I couldn't figure out which file to edit to fix, otherwise I would have just submitted a PR.

Can do, thanks.

@foresmac Thanks for the report!


CSHARP-2877: Default BsonSerializationArgs sometimes has null NominalType.

Evergreen:
https://evergreen.mongodb.com/version/5df7e0623627e013bd03f0aa

Squashed, rebased and merged.


Build the SDK from source code on Windows with CMake

Required Info

Camera Model
{ D435i }

Firmware Version
( <IP_ADDRESS> )

Operating System & Version
{ Win 10 }

Kernel Version (Linux Only)

Platform
PC

SDK Version
{ v2.47.0 }

Language
{ C++ }

Segment

Issue Description
I need to connect to the camera over network. I build the SDK from source code on Windows with CMake. It works fine over Ethernet. But it doesn't work over USB. The realsense-viewer.exe built from the SDK also does not recognize the camera. The Intel.RealSense.Viewer.exe downloaded from the official website can recognize the camera.

I run the example rs-hello-realsense. Then came the error. Do I need to configure something else?

Hi @guotonglucky  Please try building the SDK without FORCE_RSUSB_BACKEND set to true.  This flag behaves differently on Windows from how it behaves on Linux.  On Linux it enables the kernel to be bypassed.  On Windows it causes the SDK's default backend to be changed from Microsoft Media Foundation to a WinUSB rewrite of the UVC protocol, and the flag is set to false (unticked) in the Windows source code build instructions.

If the camera still does not work with USB afterwards then you could try a workaround.  After the SDK is built, find its folder on your computer.  When the SDK is built using the Intel.RealSense.SDK-WIN10 installer file then it is located at C:\Program Files (x86)\Intel RealSense SDK 2.0\tools so I recommend looking for it there first.
After renaming the Intel RealSense SDK 2.0 folder, run the Intel.RealSense.SDK-WIN10 installer file for SDK 2.47.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.47.0
This will install the non-networked version of the SDK at C:\Program Files (x86)\Intel RealSense SDK 2.0\tools
You may then be able to use the SDK at the renamed source code folder for network access and the non-networked SDK for everything else.

The first method works. Set FORCE_RSUSB_BACKEND to false. Thanks

You are very welcome.  I'm pleased that I could help!

Hi @guotonglucky  Do you require further assistance with this case, please?  Thanks!

No, thanks.

Thanks very much @guotonglucky for the update!


Keyboard event listeners (keyboardDidHide) are not working properly for Android with notch

Description
Since updating to the latest react native version (0.68.0) keyboard event listeners are not working as expected for some android devices with notch (in my case Pixel 3 XL).
The problem seems to be on the keyboardDidHide event, which is not fired at all when the keyboard is dismissed.
I have the following listeners in my code. The problem is that keyboardDidShow event is called evey time the keyboard is dismissed, instead of the keyboardDidHide event. The problem occurs only on devices with notch, same code on another devices ( Pixel 3a XL for example ) is working as expected.
  useEffect(() => {
    const keyboardDidShowListener = Keyboard.addListener(
      'keyboardDidShow',
      () => {
        console.log('keyboardDidShow');
      },
    );
    const keyboardDidHideListener = Keyboard.addListener(
      'keyboardDidHide',
      () => {
        console.log('keyboardDidHide');
      },
    );

    return () => {
      keyboardDidHideListener?.remove();
      keyboardDidShowListener?.remove();
    };
  }, []);

Another usefull information that might help is that on the 0.66.0 version, the listeners are working as expected on all devices.
Version
0.68.0
Output of npx react-native info
System:
OS: macOS 11.1
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 369.17 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.10.0 - /usr/local/bin/node
Yarn: 1.22.15 - /usr/local/bin/yarn
npm: 7.24.2 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8193401
Xcode: 12.3/12C33 - /usr/bin/xcodebuild
Languages:
Java: 11.0.14 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.66.0 => 0.66.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

Run a project with react-native:0.68.0 and with a TextInput component displayed
Add event listeners for keyboardDidHide and keyboardDidShow on the component
Notice how only keyboardDidShow is fired

Snack, code example, screenshot, or link to a repository
No response

Maybe reason is react-native-extra-dimensions-android package https://github.com/facebook/react-native/issues/33056#issuecomment-1074791894

Indeed, the issue was because of the react-native-extra-dimensions-android library, removing this from the project is fixing all the keyboard events issues. Thank you @galkinsden

hi @galkinsden, any solutions for the Keyboard Listener if I keep using this lib: react-native-extra-dimensions-android? Thanks

What about experimenting same problem but not having react-native-extra-dimensions-android in my project???


Fix typo

@burmecia I see some comments you made on previous patches and will know to PR develop branch next time.

Thanks, Georgiy.
I've now changed workflow to use best best practice for GitHub, master
branch will be served as the active development branch. You can still use
previous approach to directly pull request on master branch.
On Sat, Dec 9, 2017 at 9:50 AM, Georgiy Slobodenyuk <
<EMAIL_ADDRESS>wrote:

@burmecia https://github.com/burmecia I see some comments you made on
previous patches and will know to PR develop branch next time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zboxfs/zbox/pull/11#issuecomment-350391915, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ASaXVBWinoKhjh8u9XuJKmAQQI6-k-Y8ks5s-b02gaJpZM4Q7XfC
.


DynamicScene (de)serialization to postcard and bincode fails for some components.

Bevy version
0.9.0
What you did
According to the changelog, Bevy 0.9.0 should now support the (de)serialization of the DynamicScene with postcard and bincode. #6140 was merged and includes tests for both bincode and postcard, which do work for me.
However, when I try to (de)serialize to binary in practice, bevy fails. When deserializing SpotLightBundle and CameraBundle, for example, bincode fails with no field at index 0 on struct bevy_render::primitives::Frustum. For the PointLightBundle it's no field at index 0 on struct bevy_render::primitives::CubemapFrusta. There could be other examples too.
What surprised me the most is the behaviour of a seemingly innocent empty entity marker:
#[derive(Component, Serialize, Deserialize, Reflect, Default)]
#[reflect(Component)]
struct Marker;

It seems to work at first, but if I call app.register_type::<Marker>(), it gives an error on deserialization. When transferring data over the network, I register the incoming types on the client side, so it is important for me that it works.
(De)serializing into ron works as expected.
What went wrong
what were you expecting?
I expect the (de)serialization to work identically well whether I serialize to ron, or to binary formats. I also expect the component to (de)serialize regardless of whether it was registered manually or automatically.
I would also like the postcard to give more informative errors. As you can see from the error output provided below, they are very generic and unhepful.
Additional information
Here is an example that tests different entities (de)serialization into ron, postcard and bincode: https://pastebin.com/wxGvE9ke
Due to the issue #6573, I am using the unmerged PR #6580 to avoid failing on deserializing GlobalTransform.
Update: The actual error happens during deserialization, so made some edits to avoid confusion. However, I am not sure whether the actual issue is due to incorrect serialization or deserialization or both.
Output
Test #0: Automatically registered marker
        ron       : OK
        bincode   : OK
        postcard  : OK
Test #1: Pre-registered marker
        ron       : OK
        bincode   : Error! no field at index 0 on struct test_postcard_roundtrip::RegisteredMarker
        postcard  : Error! Serde Deserialization Error
Test #2: PbrBundle
        ron       : OK
        bincode   : OK
        postcard  : OK
Test #3: Spot Light
        ron       : OK
        bincode   : Error! no field at index 0 on struct bevy_render::primitives::Frustum
        postcard  : Error! Serde Deserialization Error
Test #4: Point Light
        ron       : OK
        bincode   : Error! no field at index 0 on struct bevy_render::primitives::CubemapFrusta
        postcard  : Error! Serde Deserialization Error
Test #5: Camera
        ron       : OK
        bincode   : Error! no field at index 0 on struct bevy_render::primitives::Frustum
        postcard  : Error! Serde Deserialization Error

Hm, looks like the deserializer is not properly accounting for structs with zero reflectable fields, including unit structs and structs where all fields are ignored (e.g. Frustum and CubemapFrusta).
Will look into this. Thank you for such a detailed writeup, this is very helpful!

@sQu1rr could you run your tests using the changes made in #6722 and verify it resolves this issue?

I am now getting a seemingly unrelated error
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Message("no registration found for dynamic type with name bevy_render::view::visibility::ComputedVisibilityFlags")', src/main.rs:78:58
n

Looks like it is about the changes in: https://github.com/bevyengine/bevy/pull/6305
Not sure how I can work around it to test

I am now getting a seemingly unrelated error
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Message("no registration found for dynamic type with name bevy_render::view::visibility::ComputedVisibilityFlags")', src/main.rs:78:58
n

Looks like it is about the changes in: #6305 Not sure how I can work around it to test

Sounds like it just needs to be registered in bevy_render. Can you try registering it manually temporarily? I'll put up a PR (or issue) for the registration.

ComputedVisibilityFlags is not public, so I cannot access it at the moment

ComputedVisibilityFlags is not public, so I cannot access it at the moment

Could you register it directly in the source of bevy_render just for testing purposes?

I can confirm that pub ComputedVisibilityFlags + registration + #6580 together with #6722 fix all issues for me (https://github.com/sQu1rr/bevy/tree/testing-dynamicscene-reflect). I tested it on the minimal example I provided, and also in my networking code, where I discovered the issue in the first place. It works like a charm so far with both bincode and postcard.
Would be very useful to fix the postcard errors though, as new issues may appear in the future, and they are quite unhelpful.

I can confirm that pub ComputedVisibilityFlags + registration + #6580 together with #6722 fix all issues for me (https://github.com/sQu1rr/bevy/tree/testing-dynamicscene-reflect). I tested it on the minimal example I provided, and also in my networking code, where I discovered the issue in the first place. It works like a charm so far with both bincode and postcard.

Awesome! Glad to hear that, I'll work on getting the registration fixes underway.

Would be very useful to fix the postcard errors though, as new issues may appear in the future, and they are quite unhelpful.

I agree. I'm not sure why the error gets replaced when deserializing with postcard. But that might be an upstream issue rather than something Bevy is doing wrong (I think). Maybe consider making an issue on the postcard repo?

For reference, I just registered the missing bevy_render types in this PR.


feat: add job type and parent job fields to allocation metadata

Hi @mr-karan,
First, thanks for taking the time to build this! I've found it to be quite useful.
I run a lot of batch jobs via Nomad and the logging sinks tend to lose the context of the job their in. Nomad batch jobs all have a parent job. This PR adds the JobType and ParentJob labels which will allow us to properly configure downstream sinks for batch jobs.

Added JobType and ParentJob fields to the AllocMeta struct in app.go
Added the job_type and parent_job_name fields to the vector.toml.tmpl file

This is super useful, thanks a lot. Give me some time to locally test it and get back!


Use go 1.17 to build release assets

For some reason, I forgot to use the setup-go action for that workflow
when I added it, which means that we have been using the default Go
version provided by the Github runners since the beginning. The default
Go version is currently 1.15, which is not maintained.
We now use the setup-go action to use the same Go version as all other
workflows (1.17).
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

Thanks @liu4480 for reporting this issue

/skip-all

Codecov Report

Merging #3007 (7e7a10f) into main (ca264d3) will decrease coverage by 20.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3007       +/-   ##
===========================================
- Coverage   61.06%   40.16%   -20.90%
===========================================
  Files         289      166      -123
  Lines       24548    20710     -3838
===========================================
- Hits        14991     8319     -6672
- Misses       7938    11578     +3640
+ Partials     1619      813      -806

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.16% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


New number range for UAE Etisalat +97154xxxxxxx

We've seen reports of a new number range being provisioned to UAE Etisalat +97154xxxxxxx:

http://www.emirates247.com/news/emirates/cost-of-054-4000000-uae-mobile-number-2016-04-21-1.627992
http://gntech.ae/news/etisalat-launched-054-mobile-code-anyone-fancy-054-4000000/
http://www.emaratalyoum.com/business/local/2016-04-22-1.890326
http://www.albayan.ae/economy/local-market/2016-04-22-1.2623437

It looks like the the new range isn't supported yet in libphonenumber. Any help adding support for the new range would be appreciated. Thanks!
Jordan

@jordan-goodall
Thanks for providing all the details we need! We've accepted this issue and
will fix this in an upcoming release.
Please note that you have submitted this information with the knowledge that we
may use, modify, reproduce, publicly display, and distribute the information in
accordance with our open source policies. Please let us know if you did not
intend to submit the information for such use.

Fixed in Release 7.4.2
Demo: http://libphonenumber.appspot.com/phonenumberparser?number=541234567&country=AE


JSON Feed version 1.0 author field cause AttributeError

feed url: https://hnrss.org/newest.jsonfeed
feed content: newest.txt
  File "/Users/kk/.pyenv/versions/rssant377/lib/python3.7/site-packages/atoma/json_feed.py", line 201, in parse_json_feed
    items=_get_items(root)
  File "/Users/kk/.pyenv/versions/rssant377/lib/python3.7/site-packages/atoma/json_feed.py", line 74, in _get_items
    rv.append(_get_item(item))
  File "/Users/kk/.pyenv/versions/rssant377/lib/python3.7/site-packages/atoma/json_feed.py", line 92, in _get_item
    author=_get_author(item_dict),
  File "/Users/kk/.pyenv/versions/rssant377/lib/python3.7/site-packages/atoma/json_feed.py", line 137, in _get_author
    name=_get_text(author_dict, 'name'),
  File "/Users/kk/.pyenv/versions/rssant377/lib/python3.7/site-packages/atoma/json_feed.py", line 173, in _get_text
    rv = root.get(name)
AttributeError: 'str' object has no attribute 'get'

Expect to compatible with 1.0 author field, although it's deprecated.
https://jsonfeed.org/version/1.1

Deprecated items remain valid forever, but you should move to the new fields when you can. A feed using fields from JSON Feed 1.0 is still a valid feed for version 1.1 and future versions of JSON Feed.

And thank you for the handy library! I'm also glad to create PR to fix it if you don't have time, just tell me go ahead.

Hi, it doesn't seem to be a problem of JSON Feed 1.0 vs 1.1, but rather the fact that the feed you linked uses author as a string when it should be an object:
For JSON Feed v1.0:
{
    "author": {
        "name": "Brent Simmons",
        "url": "http://example.org/",
        "avatar": "https://example.org/avatar.png"
    }
}

For JSON Feed v1.1:
{
    "authors": [{
        "name": "Brent Simmons",
        "url": "http://example.org/",
        "avatar": "https://example.org/avatar.png"
    }]
}

Dealing with malformed feeds is always a balancing act. Here I would say that hnrss.org should fix their feed instead of dealing with the mistake in Atoma.

I filled an issue: https://github.com/hnrss/hnrss/issues/43

Got it, thank you!


Quick Start Guide

Description
As a technical editor, I'd like to use existing docs to create a quick start guide, in order to allow any user to get started with cobalt.
Acceptance Criteria
Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

[ ] Should use content from the Adpat Document
[ ] Should use content from the Single Region Readme
[ ] Should "feel" like a lab not documentation.

Also, here are a few points that need to be addressed:

No persona / or the persona is Everyone.
See stub file for this story: docs/2_QUICK_START_GUIDE.md

Resources
Epic #347
Tasks
Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic.
Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)
Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)
Assignee should break down work into tasks here

Quick start guide passively links to the az-hello-word CIT: #227 [Doc] az-hello-world template needs documentation (prev. azure-simple-hw)


Changes related to MeiliSearch v0.21.0

This issue gathers the changes related to the v0.21.0 of MeiliSearch that will impact the integrations
Ranaming of buildDate into commitDate
Related to https://github.com/meilisearch/transplant/issues/138.
Will impact all the SDKs implementing the method for /version route.
New update status value
Related to https://github.com/meilisearch/transplant/issues/107.
The new status for an update are:

enqueued: the update is enqueued and will start to be processed soon
processing: the update is processing.
processed: the update is processed and it succeeded.
failed: A failure occurred during when processing.

Will impact all the SDKs:

About the update status is the status is declared as an enum
The waitForPendingUpdate method

The waitForPendingUpdate must now check if the status of the update is different from enqueued or processing, not only enqueued.
New ranking rules
Related to https://github.com/meilisearch/transplant/issues/85
Will impact some tests in some SDKs
Will also impact docs-scraper
Phrase search
Related to https://github.com/meilisearch/transplant/issues/198
The SDK should test the phrase search, I mean the SDK can handle " in the q parameter, like:
{
  "q": "coco \"harry\""
}

⚠ No need to check the relevancy, only the " can be handled.
Filterable attributes
Related to https://github.com/meilisearch/transplant/issues/187
attributesForFaceting is renamed into filterableAttributes.
⚠ This impacts SDKs but also back-end integrations in the READMEs/Wikis and even in the codebases.
⚠ Some key in code-samples.yml will change! Don't forget to update the keys!
Filtering
Related to https://github.com/meilisearch/transplant/issues/81 and https://github.com/meilisearch/transplant/issues/140
⚠ This impacts SDKs but also a lot instant-meilisearch!

filters is renamed into filter
facetFilters is removed
filter can accept both syntaxes: array of string and string -> the tests should check both syntaxes are handled
The users need to pass the attributes they want to filter on into filterableAttributes -> it might impact the instant-meilisearch README?
You can now filter/facet on numbers -> it means new components are now compatible with instant-meilisearch!

New fields in dumps routes
Related to https://github.com/meilisearch/transplant/issues/20

2 fields have been added when calling the GET /dumps/:uid/status route: startedAt and finishedAt
ex:

curl -X GET 'http://localhost:7700/dumps/20210601-144339391/status'

{
    "uid": "20210601-144339391",
    "status": "done",
    "startedAt": "2021-06-01T14:43:39.392327Z",
    "finishedAt": "2021-06-01T14:43:43.793802Z"
}

1 new field has been added when calling the POST /dumps route: startedAt
ex:

curl -X POST 'http://localhost:7700/dumps'

{
    "uid": "20210601-144339391",
    "status": "in_progress",
    "startedAt": "2021-06-01T14:43:39.392327Z"
}

Impacts SDKs and tests.
Rename fieldsDistribution into fieldDistribution
Related to: https://github.com/meilisearch/transplant/issues/188
Rename fieldsDistribution into fieldDistribution.
Impacts SDKs and tests.
Stop-words and synonyms accept null
Related to https://github.com/meilisearch/transplant/issues/217
The user can pass the null value when updating the settings (using POST). This resets the setting to its default value.
In MeilISearch v0.20 this behavior is possible for all the settings except the synonyms and the stop-words. The v0.21.0 should make all the settings consistent by allowing the null value when updating.
Impacts SDK tests -> we should add tests to check we can pass a null value when updating the synonyms and the stop-words. The tests for the other settings (when passing a null value`) are already done thanks to @alallema!
0 value are not present in facetsDistribution
Related to https://github.com/meilisearch/transplant/issues/234
This might impact SDK tests
exhaustiveFacetsCount always returns false
Related to https://github.com/meilisearch/transplant/issues/236
This might impact SDK tests
TODO
SDKs:

[ ] meilisearch-dart
[ ] meilisearch-dotnet
[ ] meilisearch-go
[ ] meilisearch-java
[ ] meilisearch-js
[ ] meilisearch-php
[ ] meilisearch-python
[ ] meilisearch-ruby
[ ] meilisearch-rust
[ ] meilisearch-swift

Front-end:

[ ] instant-meilisearch

Back-end:

[ ] meilisearch-rails
[ ] meilisearch-symfony

Misc:

[ ] docs-scraper

🔥🔥🔥 Don't forget the code-samples and the READMEs 🔥🔥🔥

There are additionnal breaking changes that are due to either fixes or undefined behavior becoming defined:

attributesToRetrieve does not apply on _formatted anymore https://github.com/meilisearch/MeiliSearch/issues/1491
Unexpected behavior when no valid inferable primary key is provided https://github.com/meilisearch/MeiliSearch/issues/1487

Some error codes have been added or removed and impact SDK's listing all error codes:

invalid_facet removed
missing_header removed
search_error removed
bad_parameter removed

Impacted SDK's:

meilisearch-rust

The complete list of code-samples that must be updated are here.
@guimachiavelli
Code samples
Update .code-samples.meilisearch.yaml in Curl, Golang, JavaScript, PHP, Python, Ruby, Rust, and Swift repos

attributesForFaceting changed to filterableAttributes

faceted_search_update_settings_1
faceted_search_walkthrough_attributes_for_faceting_1 -> faceted_search_walkthrough_filterable_attributes_1
get_attributes_for_faceting_1 -> get_filterable_attributes_1
update_attributes_for_faceting_1 -> update_filterable_attributes_1
reset_attributes_for_faceting_1 -> reset_filterable_attributes_1

filters changed to filter

filtering_guide_1, filtering_guide_2, filtering_guide_3, filtering_guide_4
search_parameter_guide_filter_1, search_parameter_guide_filter_2
search_guide_2
search_parameter_guide_matches_1--example changed

facetFilters changed to filter

faceted_search_facet_filters_1 -> faceted_search_filter_1
faceted_search_walkthrough_facet_filters_1 -> faceted_search_walkthrough_filter_1

wordsPosition removed and words switched with typo

update_ranking_rules_1
settings_guide_ranking_rules_1
update_settings_1

@bidoubiwa the JS SDK will be impacted by this breaking change you found out 😇
https://github.com/meilisearch/MeiliSearch/issues/1489

Absolutely! The tests are commented out until a decision is taken

Done! Well done everyone! 😄


Create wasmio-kubeconeu-preview.md

Show preview cross-post
Feature or Problem

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

need to add image


end_of_line doesn't work

How to reproduce:

Netbeans 8.2 (PHP) or 9 - Windows 10
editorconfig-netbeans v0.10.4
Source file have "CR" ending line
.editorconfig

root = true

[*]
end_of_line = crlf
insert_final_newline = true
charset = utf-8

Current result:
Ending line is not modified to the requested value
Expected result:
"CR" ending line become "CRLF" (or "LF")
Log:
INFO [com.welovecoding.nbeditorconfig.processor.EditorConfigProcessor]: "end_of_line": CRLF (C:/Users/Myst/Documents/NetBeansProjects/bifrost/application/views/admin/common_header.php)
INFO [com.welovecoding.nbeditorconfig.processor.operation.LineEndingOperation]: ¬ Changed line endings

I'm using Netbeans 8.2 on Windows 10.
It is not just end_of_line doesn't work but many properties doesn't work.
# top-most EditorConfig file
root = true

# Matches multiple files with brace expansion notation
[*.{css,htm,html,js,json,md,php}]
charset = utf-8
end_of_line=crlf
insert_final_newline = true
trim_trailing_whitespace = true
indent_style = space
indent_size = 4

From my config: end_of_line, insert_final_newline, trim_trailing_whitespace are not working.
Other than this, I'm not sure because my Netbeans settings is already did that.


error when installing

The CI builds are now failing with the following error when installing:
(node:4787) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'state' of undefined

Seemed a fluke


Some dependency packages on nps-utils contain vulnerabilities

nps version: 5.11.2
node version: 18.16.0
npm version: 9.5.1

The command executed:
npm install

The output:
trim-newlines  <3.0.1
Severity: high
Uncontrolled Resource Consumption in trim-newlines - https://github.com/advisories/GHSA-7p7h-4mm5-852v
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/trim-newlines
  meow  3.4.0 - 5.0.0
  Depends on vulnerable versions of trim-newlines
  node_modules/meow
    cpy  4.0.0 - 4.0.1
    Depends on vulnerable versions of meow
    node_modules/cpy
      cpy-cli  <=3.1.0
      Depends on vulnerable versions of meow
      node_modules/cpy-cli
        nps-utils  >=1.1.0
        Depends on vulnerable versions of cpy-cli
        node_modules/nps-utils

Problem description:
After running npm install some dependency packages contain vulnerabilities
Suggested solution:
Update the vulnerability packages to latest version

Weird, but I don't get this audit report - mine is found 0 vulnerabilities with  5.11.2. I also tried npm audit afterwards, still 0.


want to change the UI of login page

login page ui is not good, i want to change it
@tushargupta1504 plz assign me this issue

@tushargupta1504  i can work on this issue
please assing it to me


Umlaute in variable names

Java allows all unicode-letters in variable names, not only latin letters. Is there a chance to include these characters in the identifier regex?
Otherwise, this is how valid java code would look like:

My current approach is to copy-paste the grammar and change it from
https://github.com/lezer-parser/java/blob/14901c5f4aead1cdd28d2d05007f130b055f5ab6/src/java.grammar#L712-L714
to
  identifier { $[a-z_$äöü] $[a-zA-Z0-9_$äöüÄÖÜß]* }

  capitalIdentifier { $[A-ZÄÖÜ] $[a-zA-Z0-9_$äöüÄÖÜß]* }

Attached patch should help with this.

Thank you, it's working now!


Dynamically remove the need for version numbers in the code

That would mean that coders wouldn't have to update all the code whenever a version number changed (that kind of move could be an epic pain).
The idea would be to use 'interpolation.js' to strip the version number. This is the summation of the discussion of the idea:

New people looking at the code might say to themselves, 'Wait, the version numbers are gone. Something must be wrong. I'll add them back in again,' or be otherwise uncertain enough to use version numbers when they shouldn't. We've seen similar behavior before. We decided part of the problem with that is that the change is almost invisible - both names make sense on their own and there's no way to track down exactly what's going on. There's nothing to search for in the code.
Another option is to just strip the numbers off, ending up with something like foo_v. That was rejected because of the same basic reasons.
The option we liked best was to strip the version number off, but add something at the start - i_foo for 'interpolated' or s_foo for snippet. That's still mysterious, but clearly weird and intentional, as well as easy to search for.

So option number 3 is the plan!

If someone else is really excited to take this on, let me know and I'll back off.

Oh, that conversation involved @ethanbb , @pporfilio , @dylanesque , and maybe another person? I feel like there might have been another person.

Y'know what, I don't remember who was in on the convo at all. Maybe @justinqtaylor? I have no idea. What's important is that I respect you all equally.


lstm time series forecasting python tensorflow

LSTM for Time Series Forecasting using TensorFlow
Time series forecasting is a powerful method for predicting future values based on historical data. Long Short-Term Memory (LSTM) networks, a type of recurrent neural network (RNN), are especially effective in capturing temporal dependencies in sequential data. TensorFlow provides an excellent framework for implementing LSTM models.
Understanding LSTM in Time Series Forecasting
LSTM networks address the vanishing gradient problem often encountered in traditional RNNs. They use gates (input, forget, and output) to control the flow of information, ensuring long-term dependencies are retained. This makes them highly suitable for tasks like stock price prediction, weather forecasting, and energy consumption analysis.
Steps to Build an LSTM Model

Data Preparation: Start by collecting and preprocessing the time series data. Normalize the data to bring values within a specific range, and split it into training and testing sets. Convert the data into a supervised learning format using sliding windows.

Define the LSTM Model: Use TensorFlow to create an LSTM model. A simple architecture can include an LSTM layer followed by dense layers for output.

Compile the Model: Choose a loss function, such as Mean Squared Error (MSE), and an optimizer like Adam for training the model.

Train the Model: Fit the model on the training data and validate it using the testing set.

Evaluate and Forecast: Measure the model’s performance using metrics like RMSE. Use the trained model to predict future values.

Sample Python Code
import numpy as np
import tensorflow as tf
from tensorflow.keras.models import Sequential
from tensorflow.keras.layers import LSTM, Dense

# Sample data (replace with actual time series data)
data = np.sin(np.linspace(0, 100, 500))
sequence_length = 10
X, y = [], []

# Prepare data
for i in range(len(data) - sequence_length):
    X.append(data[i:i+sequence_length])
    y.append(data[i+sequence_length])
X, y = np.array(X), np.array(y)

# Reshape for LSTM input
X = X.reshape((X.shape[0], X.shape[1], 1))

# Build the LSTM model
model = Sequential([
    LSTM(50, activation='relu', input_shape=(sequence_length, 1)),
    Dense(1)
])
model.compile(optimizer='adam', loss='mse')

# Train the model
model.fit(X, y, epochs=50, batch_size=32, verbose=0)

# Forecast
predictions = model.predict(X[:5])
print(predictions)

Best Practices

Use techniques like early stopping to avoid overfitting.
Experiment with hyperparameters like the number of LSTM units and learning rate.
Perform feature engineering to enhance the model’s input data.

LSTM-based time series forecasting offers robust solutions for various industries, and TensorFlow simplifies its implementation. Combining clean data and fine-tuned models can yield accurate and reliable forecasts.

@snake-plant-care-indoors,
I tried to execute the mentioned code and observed that it was executed without any issues/error. Kindly find the gist of it here and also have a look at this official document for the time series forecasting using tensorflow.
https://www.tensorflow.org/tutorials/structured_data/time_series
Thank you!


table  page change

When the form encounters page change,Repeat header on new page

Is this a bug?


Reverse 2878

A workaround for https://github.com/dask/dask/issues/2823 was added in https://github.com/SciTools/iris/pull/2878. The dask issue is fixed in the latest release, so this PR reverts the changes.
N.B. There is a test which will fail on master now that the Dask issue is fixed, so this needs resolving ASAP.

the way the code was before the original change

Ah, thanks.  Stupidly, I hadn't thought to compare with the pre-change code.
That's all good, then.


mgmt/mcumgr/lib: Fix incorrect ssize used for unsigned values

The commit fixes OS mgmt taskstat command using ssize_t for
stack parameters that are unsigned, and then encoding them
with CBOR encoder functions dedicated to unsigned integers.
Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

Closing as with conversion to zcbor this already has been fixed.


handle manifest builds w/ package.json references

This change copies the local package.json file to the packagebuild directory, and does so because that file might be modified during the manifest build to reference dependency modules that are satisfied using references from the manifest file.
For example, the dependency of
git+https://github.com/RackHD/on-core.git

might be changed to:
on-core": "/emc/zuhnd/test-manifest-build/builddir/onrack-test/on-core"

during the build process, and then npm will use the version of on-core that's been checked out as per the detailed build manifest.
This change also ensures that errors in the build process are propagated upward (via set -e) so that failures in the ./HWIMO-BUILD process will be noticed upstream.

@RackHD/corecommitters

👍


Pushing an array to an array shows each element in the array as children, but it is inserted and fetched as expected

Laravel-mongodb Version: 3.9.0
PHP Version: 8.0.17
Database Driver & Version:

Description:
Steps to reproduce

Push to an array
Return the parent entity as json response
See the items pushed are shown as each pushed.
Do a GET for that entity, the item is shown as expected.

Expected behaviour
It should be consistent between the after-update and the re-fetch
Actual behaviour
The output is different from the fetch (and how it looks in the DB) from the after-update state
Example:
public function addProduct(ProductAddRequest $request, $purchaseRequestId): Response|JsonResponse
    {
        /** @var PurchaseRequest|null $purchaseRequest */
        $purchaseRequest = PurchaseRequest::find($purchaseRequestId);

        if (!$purchaseRequest) {
            return new Response("", HttpCodes::NOT_FOUND);
        }

        $product = new Product(
            $request->request->get('currency'),
            $request->request->get('unit_cost'),
            $request->request->get('product_id'),
            $request->request->get('quantity'),
        );

        $purchaseRequest->push('products', $product->toArray());   // <---------- here

        return new JsonResponse($purchaseRequest);
    }

output when adding an item:
{
    "id": "62862f04375eed096c6abc32",
    "products": [
            "id": "628667dccee1aa7afe760d24",
            "currency": "MXN",
            "unit_cost": 15999,
            "product_id": 1,
            "quantity": 1,
            "metadata": []
    ]
}

output when fetching the same item
{
    "id": "62862f04375eed096c6abc32",
    "products": [
        {
            "id": "628667dccee1aa7afe760d24",
            "currency": "MXN",
            "unit_cost": 15999,
            "product_id": 1,
            "quantity": 1,
            "metadata": []
        },
   ]
}

Note: It can be fixed by wrapping the array into a new array. Then it inserts as before, and also shows correctly in the current loaded entity.

The behavior of the push method is quite correct. It pushes an array of values to the given key. if you want to push an array, you must wrap your array with an array. So the push method pushes your array as a value.

Good point. Wrapping a single element is done with Arr::wrap, but not when passing an array.
In fact, it could be detected if a list is passed. But this is problematic if they want to work with numerical field names.
https://github.com/mongodb/laravel-mongodb/blob/1c2d1fe29a53278ec34a50c1a289b5e3a8f1a838/src/Eloquent/Model.php#L470
Let’s fix the documentation. You can also add a preview of the stored document before and after to make things explicit, I find that the difference between push and pull is not obvious when looking at these examples.

Okay then, I will open a PR later to update the docs.

But this is problematic if they want to work with numerical field names.

@GromNaN: Not just numerical field names. There are valid use cases for storing an array of arrays (referring to actual BSON arrays, not PHP HashTables). To that end, a more self-documenting method name might be pushValues where it's clear the arguments are a list of values to be pushed. Not sure if there's still an opportunity to do that, though, since this method has existed for some time.


Inline Google Fonts, improve body font

Remove a third party ping and improve performance, through the magic of webfont-dl.
For reference: https://github.com/18F/18f.gsa.gov/pull/805

Oh, this also makes a font change to the main body! It moves the site from Times New Roman for body text to Average. Previously, only the headlines were Average.
Before:

After:

Mmmmm ok.

I'll take that as a go.

Yeah and actually following that "mmmm":
https://github.com/if-then-fund/if.then.fund/commit/7bf3efa241524c519b48e034850d7dc4f9c2ad89


Opcua-improvements

Signed-off-by: reubenmiller<EMAIL_ADDRESS>Proposed changes
opcua-solution

rename .env file to env.template and instruct the user to copy the template to produce the .env file. The .env file is then ignored by git to prevent credentials from accidentally being commited to the repo
support setting the tedge version via the .env file via the TEDGE_VERSION variable
use a docker data volume instead of mounting a local folder. This makes it more compatible across different OS's

Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New example (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I have added necessary documentation (if appropriate)

Done!


Proposal: apply transformations to returned object(s)

Still fleshing the idea out but wanted to note in case there was interest. It'd be handy for our use case to be able to apply transformations to returned object(s). Often times the data we have stored is not necessarily the data we want to display so we often wind up running the same transformations after fetch.
A few examples:

Our users always have a first_name and a last_name. Sometimes they also have a display_name. We always want the display_name to take precendence and run a transformation on retrieved data to do so.

We use Firebase timestamps which are really handy on the server and really not-so-handy on the client since they always need to be coerced with at least .toDate()

Currency formatting always winds up with something like .toLocaleString() or something. I can't even remember off the top of my head and would need to look into our codebase for how we typically format.

Suggested enhacnement
Provide a transformations property in options that all data is run through. A transformation could either be added to an object or overwrite a property of an incoming object.
For example, let's say my source object is a user:
{
  first_name: 'John',
  last_name: 'Smith',
  created_at: firebase.firestore.Timestamp
}

With transformations:
const [user, userLoading, userError] = useDocumentData(
  myCollectionRef.users('1234')
, {
  transformations: {
    display_name: (data) => {
      return data.display_name
        ? data.display_name
        : `${data.first_name} ${data.last_name}`
    },
    created_at: (data) => {
      return data.created_at.toDate().toDateString();
    }
  }
})

Expected output from console.log(user):
{
  first_name: 'John',
  last_name: 'Smith',
  display_name: 'John Smith',
  created_at: 'Wed Dec 18 2019',
}

I could see this coming in handy for us since we could store a handful of "schema" transformations and add to them with spread syntax. eg.
{
  transformations: {
    randomOneOffProp: (data) => data.field.toLowercase(),
    ...commonPeopleTransformsFromFile,
  }
}

Ideally the same could be applied to collection data

@imjared you can write your own hook for that functionality and keep it out of this library.
I think it separate more the responsibilities since firebase does not provide those transformations and this lib seems very 1-1 to firebase.

point taken, luciano. since requesting this feature i've found that firestore provides DataConverters which probably meet my need


Add nm_bool to dia_init and add sptype switch to sparse_to_nmatrix and typo fix

@prasunanand I've changed some elements arrays' data types to void*, so that any type can be assigned to it. This will prevent the nesting of dtpe and sptype switch statements.
Also, I think we can take out some common code in nm_sparse_to_nmatrix and nm_sparse_to_array to a separate function. This will reduce code repetition. What do you think?

@prasunanand void* as function parameter did not work. I found 2 possible solutions to this. One is using an enum structure for types. Second is to make the function as a macro and pass the type.

Please write code and explain in this thread.

keep it on hold, currently.

Part of https://github.com/SciRuby/numruby/pull/21. Closing this one.


AutoCastDistributedVariable deepcopy bug

Issue Type
Bug
Source
source
Tensorflow Version
2.11
Custom Code
Yes
OS Platform and Distribution
Ubuntu 20.4
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Running copy.deepcopy on AutoCastDistributedVariable will result in error.

In __deepcopy__ method inside DistributedVariable type(self) is used. Thus, copied_variable will be initialized from AutoCastVariable. However, for this class strategy argument is missing.

AutoCastDistributedVariable should implement its own __init__.

Standalone code to reproduce the issue
from keras.mixed_precision.autocast_variable import create_autocast_variable
import tensorflow as tf
import copy

strategy = tf.distribute.MirroredStrategy()
with strategy.scope():
    distributed_var = tf.Variable([])
autocast_distributed_var = create_autocast_variable(distributed_var)
copied_variable = copy.deepcopy(autocast_distributed_var)

Relevant log output
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/distribute/values.py", line 553, in __deepcopy__
    copied_variable = type(self)(
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/util/traceback_utils.py", line 153, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/ops/variables.py", line 273, in __call__
    return super(VariableMetaclass, cls).__call__(*args, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'strategy'

@sushreebarsa
I was able to reproduce the issue on colab using TF v2.11. Please find the gist here for reference.
Thank you!

@sushreebarsa
any updates on this?

Hi @macsmy,
I could able to replicate the reported behaviour as per gist-2.11v. I even checked with older versions of TF like 2.9 and 2.7v  found same error.Could you confirm whether this feature available before?
Please refer the comment here related to deep copy of optimizer though. Please go through the issue and check whether it has any relevance to your issue.
If possible could you exactly point the issue where you believe that the problem exists? Also if you have any plan to raise a PR please feel free to do. Thanks!


Dropped local registry tests

Describe the bug
Local registry tests were dropped form CRI
To Reproduce
skopeo package isn't available in Ubuntu 20+, so any environment Ubuntu20+ should be able to reproduce the issue
Expected behavior
A clear and concise description of what you expected to happen.

skopeo package isn't available in Ubuntu 20+

Skopeo package is available starting from Ubuntu 20.10^1.
AFAIC, we need to update the vHive profile on CloudLab to use Ubuntu 20.10 if we want to run tests manually or if we want base CI runner images on it.

@CuriousGeorgiy it would be unreasonable to support an unstable version of Ubuntu. We can upgrade to Ubuntu 22 after we finish the ongoing upgrades.


Fix the potential resource leak from NettyServer

Release the ByteBuf immediately after reading the bytes
Change RequestHandler.processRequest() to directly take byte[] instead of the ByteBuf
Fix the resource leak issue when RequestHandler.processRequest() throws Exception

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@625482a). Click here to learn what that means.
The diff coverage is 85.71%.

@@            Coverage Diff            @@
##             master    #4440   +/-   ##
=========================================
  Coverage          ?   65.47%
  Complexity        ?       20
=========================================
  Files             ?     1076
  Lines             ?    55895
  Branches          ?     7975
=========================================
  Hits              ?    36600
  Misses            ?    16667
  Partials          ?     2628

Impacted Files
Coverage Δ
Complexity Δ

.../pinot/server/request/ScheduledRequestHandler.java
84% <100%> (ø)
0 <0> (?)

.../org/apache/pinot/transport/netty/NettyServer.java
80.61% <84.21%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625482a...a0198a1. Read the comment docs.


Do not rebuild on static file changes

Currently, at each push, all of the packages specified in the requirements are reinstalled and then the whole application is redeployed.
Since gunicorn is used, if the changes are in static files like HTML, CSS or JS, we can just reload the server rather than reinstalling all the packages.

Thank you for opening an issue! This looks like a duplicate of #909, which has a fix going out this week. Please track the progress of the fix #925 and let me know after a new release has been tagged if you're still seeing this behavior 👍


Component to create: personacard

Official link to component description & demo: http://dev.office.com/fabric/components/personacard
Screenshot of web analytics for the original http://officeuifabric.com site by @andrewconnell. Use this to see what are the most popular components: http://imgur.com/gallery/buUcyQv

Let me get this one as well ;) Yet I think it'll take couple more hours than label ;)

Sounds good!

Main specs:
<uif-persona-card uif-style="round" uif-presence="available" uif-size="xlarge"
uif-primary-text="Alton Lafferty" uif-secondary-text="Interior Designer, Contoso"
uif-tertiary-text="Office: 7/1234" uif-optional-text="Available - Video capable">
	<uif-persona-card-action uif-type="chat">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Lync:</uif-persona-card-detail-label> Start Lync call
		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-type="phone">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Personal:</uif-persona-card-detail-label><PHONE_NUMBER>
		</uif-persona-card-detail-line>
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Work:</uif-persona-card-detail-label><PHONE_NUMBER>
		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-type="video">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Skype:</uif-persona-card-detail-label> Start Skype call
		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-type="mail">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Personal:</uif-persona-card-detail-label> <a class="ms-Link" href="mailto:alton.lafferty<EMAIL_ADDRESS>		</uif-persona-card-detail-line>
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Work:</uif-persona-card-detail-label> <a class="ms-Link" href="mailto:alton.lafferty<EMAIL_ADDRESS>		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-type="org">

	</uif-persona-card-action>
	<uif-persona-card-action uif-type="overflow">
		View profile on Delve
	</uif-persona-card-action>
</uif-persona-card>

Above is supposed to render persona card as in PersonaCard example.
Attributes for uif-persona-card:

uif-style - round, square. Defaults to round. Same as in uif-persona.
uif-presence - available, away, blocked, busy, dnd, offline. Defaults to offline. Same as in uif-persona.
uif-size - xsmall, small, medium, large, xlarge. Defaults to medium. Similar to uif-persona, but tiny is not a valid size for persona-card
uif-image-url - picture URL, if not set show default persona image. Same as in uif-persona.
uif-primary-text, uif-secondary-text, uif-tertiary-text, uif-optional-text - optional attributes (similar to uif-persona)

uif-persona-card-detail-line:
In details section, each line is wrapped with a div element with specific CSS. This directive is supposed to provide this wrapping experience.
Attributes:

uif-type - chat, phone, video, mail, org, overflow. This is required attribute. Each action type can be added/used only once per persona-card instance.

uif-persona-card-detail-label:
In detail lines, users might like to provide labels for their content. Those labels in Fabric are span elements with specific CSS. This directive is supposed to provide this wrapping experience.
Discussion points:

above spec assumes that there will be limited action types to choose from. Yet on persona card, action is basically an icon and arbitrary HTML content that will be transcluded. My question is - shall we limit the actions or give users flexibility to define their owns, by providing the icon type they would like to use?

Feedback appreciated.

I'd say don't limit it. Just accept any. But, may be reanme it to uif-icon instead of uif-type?

It seems like we use two different approaches for the primary, secondary, tertiary and optional text: in persona and personacard we define them as attributes while in the list we defined them as elements (https://github.com/ngOfficeUIFabric/ng-officeuifabric/issues/24). It would be better if we used the same approach across all directives.
I agree with @rolandoldengarm that actions shouldn't be an enum but we should support any icon instead. That would give us more flexibility in the end.
One thing that's confusing is how the orgchart has been implemented in Office UI Fabric. It has a specific orgchart class that defines its positioning on the card (top right corner). The question is whether orgchart is a fixed component or whether we want to be able to put other actions there as well meaning that we would need a way to distinguish between regular actions and the top-right-corner action.
For the actions links in the detail line: shouldn't we use uif-link (#23) for this instead?

Ad. 1) I'm flexible here, and can go both ways. Let's see in which direction this goes.
Ad. 2) I think I could introduce another parameter to uif-persona-card-action directive, called e.g. uif-placeholder - regular, topright, overflow, introduce uif-icon as a substitute uif-type
Ad. 3) I just copied over what is in their example, you will be free to use whatever you like as it will be transcluded.

:+1:

Referring to 1) I prefer elements over attributes so I'd change it in this spec to match what #24 does.
Referring to 2) I like your @jjczopek suggestions / proposals for the
Referring to 3) I agree with @waldekmastykarz we should use our own link directive here within the detail.

Revised spec:
<uif-persona-card uif-style="round" uif-presence="available" uif-size="xlarge">
	<uif-persona-card-primary-text>Alton Lafferty</uif-persona-card-primary-text>
	<uif-persona-card-secondary-text>Interior Designer, Contoso</uif-persona-card-secondary-text>
	<uif-persona-card-tertiary-text>Office: 7/1234</uif-persona-card-tertiary-text>
	<uif-persona-card-optional-text>Available - Video capable</uif-persona-card-optional-text>
	<uif-persona-card-action uif-icon="chat" uif-placeholder="regular">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Lync:</uif-persona-card-detail-label> <uif-link ng-href="#">Start Lync call</uif-link>
		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-icon="phone" uif-placeholder="regular">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Personal:</uif-persona-card-detail-label><PHONE_NUMBER>
		</uif-persona-card-detail-line>
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Work:</uif-persona-card-detail-label><PHONE_NUMBER>
		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-icon="video" uif-placeholder="regular">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Skype:</uif-persona-card-detail-label> <uif-link ng-href="#">Start Skype call</uif-link>
		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-icon="mail" uif-placeholder="regular">
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Personal:</uif-persona-card-detail-label> <uif-link ng-href="mailto:alton.lafferty<EMAIL_ADDRESS>		</uif-persona-card-detail-line>
		<uif-persona-card-detail-line>
			<uif-persona-card-detail-label>Work:</uif-persona-card-detail-label> <uif-link  ng-href="mailto:alton.lafferty<EMAIL_ADDRESS>		</uif-persona-card-detail-line>
	</uif-persona-card-action>
	<uif-persona-card-action uif-icon="org" uif-placeholder="topright">

	</uif-persona-card-action>
	<uif-persona-card-action uif-placeholder="overflow">
		View profile on Delve
	</uif-persona-card-action>
</uif-persona-card>

uif-persona-card-detail-line:
In details section, each line is wrapped with a div element with specific CSS. This directive is supposed to provide this wrapping experience.
Attributes:

uif-placeholder - regular, topright, overflow. Determines in which part of the persona-card action should be added.
uif-icon - All available icons are valid. This is required attribute for regular and topright placeholders, optional for overflow placeholder.

LGTM

Task list, for progress monitoring:

[ ] uif-persona-card-detail-label directive
[ ] uif-persona-card-detail-line directive
[ ] uif-persona-card-primary-text directive
[ ] uif-persona-card-secondary-text directive
[ ] uif-persona-card-tertiary-text directive
[ ] uif-persona-card-optional-text directive
[ ] uif-persona-card directive

[ ] uif-persona-card controller
[ ] registering actions on callout automatically

[ ] uif-persona-card-action directive

Oh dear, I think it's finished. Need to write the doc, polish the demo and will be good to go (I think).

Good stuff @jjczopek  :+1:


Update messaging-policies-in-teams.md

Add another related topic and added reference to owners and members in the introduction to help indicate role difference

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LolaJacobsen PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Uncaught TypeError: Cannot call a class as a function

Hello @cvaize,
Make sure your function S_CHECKOUT_ADDRESS() returns element selector as shown below.
selector: () => {
  return document.querySelector("#autoComplete");
},

Check your function and let me know.
Good day! :)

@TarekRaafat Thanks, I already used another library, hope this issue will help other people!