test regression in 1.9.1

Hi, I've been trying to update the distro package to 1.9.1 and noticed a test regression which passed fine in 1.9.0
lua: 5.4.0
Running files in tests
Running tests/test-__vector.lua
Running tests/test-app.lua
Running tests/test-array2d.lua
Running tests/test-class.lua
Running tests/test-class2.lua
Running tests/test-class3.lua
Running tests/test-class4.lua
Running tests/test-compat.lua
Running tests/test-comprehension.lua
DONE
Running tests/test-config.lua
Running tests/test-data.lua
Running tests/test-data2.lua
Running tests/test-date.lua
lua5.4 -e 'package.path=[[lua/?.lua;lua/?/init.lua;]]..package.path'	lua5.4
Running tests/test-date2.lua
Running tests/test-dir.lua
Running tests/test-func.lua
Running tests/test-import_into.lua
Lua 5.4
Lua 5.4
Running tests/test-lapp.lua
Running tests/test-lexer.lua
Running tests/test-list.lua
Running tests/test-list2.lua
Running tests/test-map.lua
Running tests/test-multimap.lua
Running tests/test-orderedmap.lua
Running tests/test-path.lua
Running tests/test-pretty-number.lua
Running tests/test-pretty.lua
Running tests/test-seq.lua
Running tests/test-set.lua
Running tests/test-sip.lua
Running tests/test-strict.lua
Running tests/test-stringio.lua
Running tests/test-stringx.lua
Running tests/test-stringx2.lua
Running tests/test-tablex.lua
Running tests/test-tablex2.lua
permutations	5040
DONE
Running tests/test-tablex3.lua
Running tests/test-template.lua
template: success
Running tests/test-text.lua
Running tests/test-text2.lua
Running tests/test-types.lua
Running tests/test-url.lua
Running tests/test-utils.lua
warning: 'math.type' will not override existing symbol
Running tests/test-utils2.lua
Running tests/test-utils3.lua
Lua 5.4.0  Copyright (C) 1994-2020 Lua.org, PUC-Rio
sh: most-likely-nonexistent-command: command not found
Running tests/test-xml.lua
<hello><tag my_attribute='my_value'>dolly</tag></hello>
<hello><tag my_attribute='my_value'>dolly</tag></hello>
Running files in examples
Running examples/seesubst.lua
([see pl.bonzo.dog](pl.bonzo.html#dog))
remember about [see pl.bonzo](pl.bonzo.html#dog)

Running examples/sipscan.lua
SYNC%s*%[([+%-%d]%d*)%]%s*([+%-%d]%d*)%s+([+%-%d]%d*)	table: 0x5619d555a430	table: 0x5619d555a470
547	0
555	0
563	0
571	0
580	-1
587	0
Running examples/symbols.lua
Running examples/test-cmp.lua
true
true
Running examples/test-listcallbacks.lua
hello
yay
Running examples/test-pretty.lua
{
  "one",
  "two",
  "three",
  {
    1,
    2,
    3
  },
  ["&"] = true,
  _fred = {
    true,
    true
  },
  alpha = 1,
  beta = 2,
  gamma = 3,
  s = [[hello dolly
you're so fine
]],
  [0] = false
}
Running examples/test-symbols.lua
+ 	2 * x ^ 1 + 0
- 	2 * x
+ 	3 * 2
- 	6 * x
+ 	2 * x ^ 1 + 2 * 3
- 	2 * x + 6 * x ^ 2
+ 	2 * x ^ 1 + 2 * a
- 	6 * a + 2 * x
+ 	2 * a
- 	6 * a
+ 	1 * x + x * 1
- 	x ^ 2 * 3
Running examples/testclone.lua
---
true
/build/penlight/src/Penlight-1.9.1/examples/testclone.lua	/build/penlight/src/Penlight-1.9.1/copy/of/examples/examples/testclone.lua<PHONE_NUMBER><PHONE_NUMBER>
lua5.4: examples/testclone.lua:38: assertion failed!
stack traceback:
	[C]: in function 'assert'
	examples/testclone.lua:38: in main chunk
	[C]: in ?
Running examples/testclone.lua failed with code 1

I can confirm this error cropped up between 1.9.0 and 1.9.1. However it is in an example, not in a true regression test. If I'm reading things rightly you are running lua run.lua as part of the Arch PKGBUILD's check() function; I think you need to run lua run.lua tests instead. I assume from the error above you already corrected the fact that (as of the 1.9.0 package in Arch) all split packages for different Lua versions were being tested with Lua 5.3.
Running just the regression suite and not the examples is probably sufficient for distro packaging purposes, and I hope that allows you to get Arch updated (yes it was me whining about Penlight not being updated for a year, and that was before I was a collaborator here).
However the issue report is still valid.

Our own CI test suit should probably have caught this and did not. We should run both the regression tests & in a separate job build the examples as well.

The actual error bisects to 27ea5a2 and since examples/tescclone.lua uses pl.dir that makes sense. Perhaps @hishamhm you can review that change.

Yeah that has been corrected and it runs it for all lua variants now. For now it was on purpose, I thought running more (like examples) is better, but im fine just running the tests itself for now.
Is the behavior change in pl.dir that lead to breaking an example fine for penlight downstream consumption in a point release without expecting breakage?

@anthraxx The behavior change in #191 looks like an actual bug, I contributed #350 to fix it.


⚠ Bofrost.fr has degraded performance

In 643c608, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1505 ms

Resolved: Bofrost.fr performance has improved in e97f88a after 8 minutes.


Switches (TVs) not working anymore but did work last week - no changes to config

Describe The Bug:
2 of 3 Samsung TVs not responding when they had worked after install
To Reproduce:
Just use Siri or Home App or Homebridge UI to turn on TVs and then nothing happens
Expected behavior:
Use Home App or Siri to turn on TVs that previously responded to the plugin
Logs:
[10/03/2023, 12:56:50] [Smartthings Plug (IK)] Received setSwitchState(true) event for Basement Gaming TV - Samsung Q60 Series (65)
[10/03/2023, 12:56:50] [Smartthings Plug (IK)] on failed for Basement Gaming TV - Samsung Q60 Series (65): AxiosError: Request failed with status code 409
[10/03/2023, 12:56:50] [Smartthings Plug (IK)] Command failed for Basement Gaming TV - Samsung Q60 Series (65)
[10/03/2023, 13:11:47] [Smartthings Plug (IK)] Received response from webhook {"timeout":true,"events":[]}
[10/03/2023, 13:11:47] [Smartthings Plug (IK)] Posting request to web hook
Plugin Config:
        {
            "name": "Smartthings Plug (IK)",
            "BaseURL": "https://api.smartthings.com/v1",
            "AccessToken": "XXX",
            "WebhookToken": "XXX",
            "GarageDoorMaxPoll": 0,
            "PollLocksSeconds": 0,
            "PollDoorsSeconds": 0,
            "PollSensorsSeconds": 5,
            "PollSwitchesAndLightsSeconds": 15,
            "IgnoreLocations": [
                "Ignored Room",
                "My location 2"
            ],
            "IgnoreDevices": [
                "XXX",
                "XXX",
                "XXX"
            ],
            "platform": "HomeBridgeSmartThings"
        }

Screenshots:

Environment:

Plugin - v1.5.1:
Node - v1.6.0:
Homebridge - v16.16.0:
NPM - 8.11.0:
OS - DietPi:

It indicates that SmartThings says that turning it on would conflict with the devices current state.
This isn’t something I can fix with the plugin as it is doing what it is being told which is set the switch state to “on”.
Try restarting homebridge or maybe even your hub.
Also try controlling the device with the SmartThigns app and see what happens there.

On Mar 10, 2023, at 1:10 PM, Grady Houston @.***> wrote:
Describe The Bug:
2 of 3 Samsung TVs not responding when they had worked after install
To Reproduce:
Just use Siri or Home App or Homebridge UI to turn on TVs and then nothing happens
Expected behavior:
Use Home App or Siri to turn on TVs that previously responded to the plugin
Logs:
[10/03/2023, 12:56:50] [Smartthings Plug (IK)] Received setSwitchState(true) event for Basement Gaming TV - Samsung Q60 Series (65)
[10/03/2023, 12:56:50] [Smartthings Plug (IK)] on failed for Basement Gaming TV - Samsung Q60 Series (65): AxiosError: Request failed with status code 409
[10/03/2023, 12:56:50] [Smartthings Plug (IK)] Command failed for Basement Gaming TV - Samsung Q60 Series (65)
Not sure what status code 409 means.
Plugin Config:
    {
        "name": "Smartthings Plug (IK)",
        "BaseURL": "https://api.smartthings.com/v1",
        "AccessToken": "XXX",
        "WebhookToken": "XXX",
        "GarageDoorMaxPoll": 0,
        "PollLocksSeconds": 0,
        "PollDoorsSeconds": 0,
        "PollSensorsSeconds": 5,
        "PollSwitchesAndLightsSeconds": 15,
        "IgnoreLocations": [
            "Ignored Room",
            "My location 2"
        ],
        "IgnoreDevices": [
            "XXX",
            "XXX",
            "XXX"
        ],
        "platform": "HomeBridgeSmartThings"
    }

Screenshots:
Environment:
Plugin - v1.5.1:
Node - v1.6.0:
Homebridge - v16.16.0:
NPM - 8.11.0:
OS - DietPi:
—
Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/issues/148, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55ERAPF4Z365TD2YSS5DW3NVCBANCNFSM6AAAAAAVWZCON4.
You are receiving this because you are subscribed to this thread.

Ah, I see. Weird issue on my end. Sorry about that. I thought I had checked everything before coming here.


All nodes should transition to Follower if term > currentTerm

From the raft paper:
• If RPC request or response contains term T > currentTerm:
set currentTerm = T, convert to follower (§5.1)
I don't believe this is implemented in any of the akka-raft states.

This issue subsumes https://github.com/ktoso/akka-raft/issues/46


Enhancement: Is it possible to reduce the wifi traffic of the plugin using any parameters?

You said this one was addressed in #32  right @kpsuperplane? Sorry just checking what you can close out for house keeping!

Yup! Thanks Mitch :)


Feature request: allow passing a context.Context as part of a transaction

Summary
WithErrorCallback() callback should have access to a context related to the processed query in order to allow logging to be associated with the originating query.
This can be implemented without breaking existing code by adding an option to associate a context to a transaction (by default http.Request.Context() should be used) and add the ability to fetch said context in [types](https://pkg.go.dev/github.com/corazawaf/coraza/v3@v3.0.4/types).[MatchedRule](https://pkg.go.dev/github.com/corazawaf/coraza/v3@v3.0.4/types#MatchedRule).
Basic example
github.com/corazawaf/coraza/v3/http should set the context. It can be used like this:
func logWafError(error types.MatchedRule) {
        slog.Log(error.Context(), slogLevel(error.Rule().Severity()), error.ErrorLog(), ...)
}

Motivation
Go has implemented context.Context for some time and this is available as part of http.Request among other things. It can be used to pass various information and the new log/slog also has ability to accept contexts. It would be great for me to associate coraza logs with the original request, and the context would make that possible.

This seems reasonable to me, I would add NewTransactionContext to follow the standard naming convention, and http middleware could probably pass the request context by default

I have a few thoughts on this:
I wonder @MagicalTux if you are using the http middleware provided by coraza. If not, you can call the tx.MatchedRules right before closing the transaction, if yes we have been talking with some folks here to add hooks on the middleware at the beginning and at the end of the request to be able to perform and action based on the transaction and I think you could accomplish this.
My main doubt around using a single context in a transaction is that

It is unclear what happens on context cancellation or a context deadline.
Transaction holding a context just for passing to the error callback feels weird since we don't use it anywhere else but agree accesing the context somehow is a legit case.
I always thought that context could play a role on the request/response processing e.g. tx.ProcessRequestBody where it makes sense to pass a deadline, how would this play with a context per transaction?

@jcchavezs
I do use the provided http middleware (http.WrapHandler) as it was easier. I guess I could just copy the code and directly do all the steps to get things working but hooks would work too I guess.
Still having the ability to pass context would be useful since contexts aren't only about deadlines or cancellation, but also passing various kind of information. Cancel/deadlines can be ignored for the context of things such as logging (log/slog) and such.
Another advantage is that http.Request which the middleware takes in already has a context, which means the existing implementation can automatically fetch the context from there. Actually if just the request was exposed in the log side it could be used to fetch the context (solve my issue) and can also provide a lot of useful information for logging.
Right now the only things the logging callback has access to is types.MatchedRule which contains some information about the request (URI(), etc). Anything would be helpful, a custom map, a context.Context or the http.Request object would do.

Hi Coraza team - just an upvote on this proposal. Previously I experimented with earlier versions of the WAF and didn't get on to well but v3 seems a big step forward nice work!
We're using the coraza provided middleware within our own existing proxy Go reverse proxy - there's a fair amount of logic and complexity in the WrapHandler method and I didn't want to have to copy and maintain this separately. The middleware worked pretty seamlessly but the major usability/integration issue we have is not having access to the context in the error call back function. We decorate the incoming request context with correlation IDs and other information  then output structured/JSON logs. Log analysis is largely done by filtering on these structured fields. If we can get the context into the error call back function we could properly integrate the Coraza output into our logs.
I really don't want to have to copy and paste the WrapHandler code ... although I see this look like what had to be done for the Caddy plugin: https://github.com/corazawaf/coraza-caddy/blob/main/http.go

Started this PR https://github.com/corazawaf/coraza/pull/962

Can we close this? as this is already implemented as experimental

Closing.


inline popover that hides on drag

Description
Render inline popover that hides when datepicker is being dragged
Fixes #612
Type of change

Bug fix

How Has This Been Tested?

manually try dragging the datepicker widget

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@rishabhsaxena Minor: Please use the exact text Fixes #<issueNumber> in order to link to the issue that this PR resolves. Unfortunately, simply mentioning the issue in the description doesn't get Github to link the PR  & issue to each other.
I've edited your description for this PR. But please keep this in mind for future PRs.

Closing this since not using a portal might result in the picker getting clipped


adding additional or exteral assets while using injectManifest strategy

Is there any way to add additional assets other than generated from vite build, when using inject manifest strategy. I tried using includeAssets option but it didn't worked for me.

I managed to solve my problem using:
injectManifest: {    additionalManifestEntries: [{ url: "my-assets", revision: Date.now() }] },
Is this valid?


Numerical Exif Metadata support for Image Dashboards

This PR adds support for numerical exif metadata for all image dashboards.
Description

Checklist

[x] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #2358 (32259bc) into main (7900db3) will decrease coverage by 15.97%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #2358       +/-   ##
===========================================
- Coverage   92.40%   76.44%   -15.97%
===========================================
  Files         108       14       -94
  Lines        5415     1312     -4103
===========================================
- Hits         5004     1003     -4001
+ Misses        411      309      -102

Flag
Coverage Δ

unittests
76.44% <100.00%> (-15.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...n/responsibleai_vision/utils/feature_extractors.py
94.11% <100.00%> (ø)

..._vision/responsibleai_vision/utils/image_reader.py
78.57% <100.00%> (ø)

... and 120 files with indirect coverage changes


chore(ci): move papyrus_common dep to root toml

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#269  👈
#268
#267
#266
#265
#264
#263
#262
#261
#260
#259
#258
#257
#256
#255
main-v0.13.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on  Graphite


Adapt iso20022ReportReference

New iso20022ReportReference properties (schemaVersion, dateFrom, dateTo) are added. The added properties are optional.

Please remove element "conditionList" from properties in endpoint response. This element does not exist in bLink specification and has no additional value from my perspective. The element was added with the initial merge with the ISO20022 endpoints.

Element "conditonList" removed from properties in endpoint response and pull request updated.


Typst.ts for Angular

[x] Init Angular Library
[x] import @myriaddreamin/typst.ts
[x] A customized demo for typst.angular
[x] Publish to npm

done by https://github.com/Myriad-Dreamin/typst.ts/commit/e13800757608a2b14afaddf7312eb0528471da02


[SUPPORT] Issue running docker demo on mac arm with Hudi 0.15. Disconnected while requesting ApiVersion

Describe the problem you faced
Issue running docker demo on mac arm with Hudi 0.15. Disconnected while requesting ApiVersion
albert@Alberts-MBP hudi % cat docker/demo/data/batch_1.json | kcat -b kafkabroker -t stock_ticks -P
%6|1724702716.408|FAIL|rdkafka#producer-1| [thrd:kafkabroker:9092/bootstrap]: kafkabroker:9092/bootstrap: Disconnected while requesting ApiVersion: might be caused by incorrect security.protocol configuration (connecting to a SSL listener?) or broker version is < 0.10 (see api.version.request) (after 0ms in state APIVERSION_QUERY)

To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/apache/hudi.git
git checkout release-0.15.0
mvn clean package -Pintegration-tests -DskipTests
./setup_demo.sh --mac-aarch64

Expected behavior
Follow https://hudi.apache.org/docs/docker_demo/ and expect all the steps to work.
Environment Description

Hudi version : 0.15

Spark version :

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) : yes

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

Upgraded the kafka container image to use [2.13-2.8.1](https://hub.docker.com/layers/wurstmeister/kafka/2.13-2.8.1/images/sha256-1e05be28055c8c3527ba4f892b5574411ee713899d1181d43dfdbc4dffcf78df?context=explore)


Numeric database names

CI database module doesn't properly escape numeric database names. For example, "SHOW TABLES FROM 1984 "becomes "SHOW TABLES FROM 1984" which fails in MySQL.

See an StackOverflow answer here regarding database names not existing of soley digits unless escaped. https://stackoverflow.com/a/25595372
I know it's not best practice, but in my usage, I have no control of database names - I just need to be able to connect to them.

Duplicate of #3877.


Fixes BatchSync when EL offline [WIP]

PR Description
When BatchSync is trying to import batch and BatchImport unables to verify it because it contains ExecutionPayload and Execution Client is offline, BatchSync is paused for 5 seconds to retry the same action afterwards. Before PR BatchSync marked batches as invalid and penalized peers in the same case.
I called event BatchImportResult.SERVICE_OFFLINE because I'm not sure we should disclose EL on this level, though logs are not a part of code and could be helpful for users, so I mentioned it there.
I don't like the way I did logging in Web3JExecutionEngineClient but I want good UX for users who looks at node after 2 hours of stall. I discarded EVENT_LOG in BatchSync option, where similar message repeats,  because during normal block-by-block sync BatchSync is not used and EL could gone offline too. Any advices how could I make this better are appreciated.
Also I'm not sure peers are not penalized during normal sync at the head of the chain when importing fresh blocks. My home chain have not synchronized yet, will check tomorrow and update.
Fixed Issue(s)

Fixes #4877
Documentation

[ ] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[ ] I thought about adding a changelog entry, and added one if I deemed necessary.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

My sync is over and I see no penalization for peers on normal sync while EL is offline, so we don't need to make additional PR

My fault. It's not dropping peers because of exception. I've created #4936


@DebugLog works only in Activity type classes

I was able to add it to my project and it seems to work only on methods that are part of the Activity.
It doesn't work on my objects nor Adapters nor on anything else.
What I am doing wrong?
Thanks.

@davideas It doesn't work in Services either?

It work fine in Services


Zod => JSONSchema compilation produces infinitely recursive schemas when using transforms

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug
When using a zodFunction with a zod schema that has multiple references to an object with a transformed property, the produced JSON schema is infinitely recursive and invalid. It causes the OpenAI API to 500 when requested.
I believe both of these conditions are necessary to trigger the bug:

the schema contains an object with one property that has a .transform attached to it
the schema contains references to that object more than once, so the JSONSchema transformer has to pop it out into the definitions

The produced JSONSchema ends up looking like this:
{
  "definitions": {
     "test_properties_first_properties_baz": {
       "$ref": "#/definitions/test_properties_first_properties_baz",
     }
   }
}

which is self-referential and broken, sad.
To Reproduce
Here's a test that reproduces the error:
// use ajv to validate that the produced json schema is valid
import Ajv from "ajv";
const ajv = new Ajv();

  test("unchanged schemas with referenced inner pieces produce valid JSON schemas", () => {
    const Inner = z.object({
      baz: z.boolean().transform((v) => v ?? true),
    });

    const Outer = z.object({
      first: Inner,
      second: Inner,
    });

    const jsonSchema = zodFunction({ name: "test", parameters: Outer }).function.parameters;

    expect(jsonSchema).toBeDefined();
    expect(jsonSchema).toMatchSnapshot();

    ajv.compile(jsonSchema as any);
  });

Code snippets
Here's what the problematic compiled JSONSchema looks like:
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "additionalProperties": false,
  "definitions": {
    "test": {
      "additionalProperties": false,
      "properties": {
        "first": {
          "additionalProperties": false,
          "properties": {
            "baz": {
              "type": "boolean",
            },
          },
          "required": [
            "baz",
          ],
          "type": "object",
        },
        "second": {
          "$ref": "#/definitions/test_properties_first",
        },
      },
      "required": [
        "first",
        "second",
      ],
      "type": "object",
    },
    "test_properties_first": {
      "additionalProperties": false,
      "properties": {
        "baz": {
          "$ref": "#/definitions/test_properties_first_properties_baz",
        },
      },
      "required": [
        "baz",
      ],
      "type": "object",
    },
    "test_properties_first_properties_baz": {
      "$ref": "#/definitions/test_properties_first_properties_baz",
    },
  },
  "properties": {
    "first": {
      "additionalProperties": false,
      "properties": {
        "baz": {
          "type": "boolean",
        },
      },
      "required": [
        "baz",
      ],
      "type": "object",
    },
    "second": {
      "$ref": "#/definitions/test_properties_first",
    },
  },
  "required": [
    "first",
    "second",
  ],
  "type": "object",
}

OS
macOS
Node version
node v22.2.0
Library version
openai v4.56.0

ping @RobertCraigie sorry to bother just want to make sure you saw this as it seems up your alley!

This will be fixed in the next release! :) https://github.com/openai/openai-node/pull/1066

Bless your beautiful heart thank you!


Make notification icon optional

Description:
Title, body, and icon should all be optional. Setting no icon currently results in broken notifications such as:

This PR fixes that by making the icon optional.

@Jacalz The code contribution note mentions targeting the next branch, but there does not seem to be a next branch in the repo yet. Might be leftover from rymdport's code contribution note?

@Jacalz The code contribution note mentions targeting the next branch, but there does not seem to be a next branch in the repo yet. Might be leftover from rymdport's code contribution note?

Yeah, sorry. That's just a copy-paste issue. I'll get that fixed up.

Feel free to shout if you need any more features, find more bugs etc. I'm happy to help :)


How to use ComboBox with Tree instead of List

I'm building a financial app with which transactions can be labelled with categories. Categories are however organised like a tree. eg. Expenses->Utilities>Gas-Water-Electricity, or Assets->Banks->Business>Bank Xyz
Ideally I would like to choose a category like choosing an entry from a ComboBox, but instead of a list being displayed, a tree should be displayed.
Any idea how I could replace the List used by ComboBox with a Tree?
I've tried to understand the implementation of the ComboBox, but my skills don't seem to be up to the task...

I've created a tree popup using overlay on top of a button.


[Traefik Plugin Catalog] Plugin Analyzer has detected a problem.

The plugin was not imported into Traefik Plugin Catalog.
Cause:
failed to get the latest tag: invalid tag: v.1.0.5 (this tag must be removed, see https://semver.org)

Traefik Plugin Analyzer will restart when you will close this issue.
If you believe there is a problem with the Analyzer or this issue is the result of a false positive, please contact us.

Fixed


RegisterLogCallback is obsolete in Unity 5

RegisterLogCallback, used in bugsnag SDK, is obsolete. Unity asks to use logMessageReceived event instead:
UnityEngine.Application.RegisterLogCallback(UnityEngine.Application.LogCallback)' is obsolete:Application.RegisterLogCallback is deprecated. Use Application.logMessageReceived instead.'

Thank you for the report, @golergka. Working on a patch now.


move and edit sterol_regulatory_element

As part of this ticket: https://github.com/The-Sequence-Ontology/SO-Ontologies/issues/591
sterol_regulatory_element SO:0001861
Parent term name and accession
promoter_element SO:0001659 REMOVE this term
Suggested new parent term name and accession
TF_binding_site SO_0000235
DNA_motif SO_0000713
response_element SO_0002205
** revise definition to:**
A 10-bp element bound by sterol regulatory element binding proteins (SREBPs), found in RNA polymerase II transcriptional cis-regulatory regions of genes involved in sterol metabolism. Many variants of the sequence ATCACCCCAC function as SREs.
Reason for the change
The SRE is not only present in the promoter region (where the promoter is defined as binding the transcription machinery - SRE is bound by dbTFs that are not part of the transcription machinery as defined by GO).
In addition it might be good to refine the definition of the E-box to cover E-box related motifs, especially as the sequence in the current definition is very loose: Consensus sequence is AWCAGCTGWT.
Note that wikipedia states: https://en.wikipedia.org/wiki/Sterol_regulatory_element-binding_protein: Sterol regulatory element  sequence TCACNCCAC.PMID: 2298751
PMID: 26321664: states: Here we performed a detailed promoter/enhancer analysis of human ELOVL5 gene, and identified two new SREBP binding sites, one in the 10 kb upstream region and one in the exon 1.
Add Relevant Publications
PMID: 26321664 - SRE in enhancer
add synonyms:
SRE
sterol regulatory element
@colinlog @pgaudet

sorry wrong github


[SMALLFIX] Removed explicit argument type in BufferedBlockInStreamIntegrationTest

Removed an explicit argument type in the BufferedBlockInStreamIntegrationTest class.

+1 LGTM

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10096/
Test PASSed.


Missing JSX

Just leaving this here, if someone stumbles upon the same issue..
I got the error message, that JSX namespace is not found.
the solution to this issue is as follows:
npm install --save-dev @types/react

Hello @johannesschobel Thanks for reporting this issue! It has been resolved.


functional-tester: kill leader returns different hash

2016-04-28 05:17:08.889242 I | etcd-tester: [round#4686 case#3] start failure kill leader member
2016-04-28 05:17:08.889285 I | etcd-tester: [round#4686 case#3] start injecting failure...
2016-04-28 05:17:08.919163 I | etcd-tester: [round#4686 case#3] injected failure
2016-04-28 05:17:08.919202 I | etcd-tester: [round#4686 case#3] start recovering failure...
2016-04-28 05:17:11.204553 I | etcd-tester: [round#4686 case#3] recovered failure
2016-04-28 05:17:11.204587 I | etcd-tester: [round#4686 case#3] canceling the stressers...
2016-04-28 05:17:11.206395 I | etcd-tester: [round#4686 case#3] canceled stressers
2016-04-28 05:17:11.206410 I | etcd-tester: [round#4686 case#3] checking current revisions...
2016-04-28 05:17:12.377582 I | etcd-tester: [round#4686 case#3] all members are consistent with current revisions [revisions: map[<IP_ADDRESS>:2379:2417063585 <IP_ADDRESS>:2379:2417063585 <IP_ADDRESS>:2379:2417063585]]
2016-04-28 05:17:12.377629 I | etcd-tester: [round#4686 case#3] checking current storage hashes...
2016-04-28 05:17:12.377646 I | etcd-tester: [round#4686 case#3] checking current storage hashes failed [hashes: map[<IP_ADDRESS>:2379:1719633027 <IP_ADDRESS>:2379:1280481596 <IP_ADDRESS>:2379:1719633027]]
2016-04-28 05:17:12.377676 I | etcd-tester: [round#4686 case#3] cleaning up...

more logs coming...

Let's finish the analysis offline first. Or the issues might become messy.

Sure. Will figure out what happen first.

2016-04-28 05:17:08.889242 I | etcd-tester: [round#4686 case#3] start failure kill leader member
2016-04-28 05:17:08.889285 I | etcd-tester: [round#4686 case#3] start injecting failure...
2016-04-28 05:17:08.919163 I | etcd-tester: [round#4686 case#3] injected failure
2016-04-28 05:17:08.919202 I | etcd-tester: [round#4686 case#3] start recovering failure...
2016-04-28 05:17:11.204553 I | etcd-tester: [round#4686 case#3] recovered failure
2016-04-28 05:17:11.204587 I | etcd-tester: [round#4686 case#3] canceling the stressers...
2016-04-28 05:17:11.206395 I | etcd-tester: [round#4686 case#3] canceled stressers
2016-04-28 05:17:11.206410 I | etcd-tester: [round#4686 case#3] checking current revisions...
2016-04-28 05:17:12.377582 I | etcd-tester: [round#4686 case#3] all members are consistent with current revisions [revisions: map[<IP_ADDRESS>:2379:2417063585 <IP_ADDRESS>:2379:2417063585 <IP_ADDRESS>:2379:2417063585]]
2016-04-28 05:17:12.377629 I | etcd-tester: [round#4686 case#3] checking current storage hashes...
2016-04-28 05:17:12.377646 I | etcd-tester: [round#4686 case#3] checking current storage hashes failed [hashes: map[<IP_ADDRESS>:2379:1719633027 <IP_ADDRESS>:2379:1280481596 <IP_ADDRESS>:2379:1719633027]]
2016-04-28 05:17:12.377676 I | etcd-tester: [round#4686 case#3] cleaning up...

So different hash values are:
AGENT1 <IP_ADDRESS>:2379:1719633027
AGENT2 <IP_ADDRESS>:2379:1719633027
AGENT3 <IP_ADDRESS>:2379:1280481596

If read just the snapshot status, we can see the final hash values are equivalent.
# AGENT1
Total Size:       211 MB
Current Revision:<PHONE_NUMBER>
Consistent Index:<PHONE_NUMBER>
Total Key:        461845
Hash:<PHONE_NUMBER> (667F8483)

# AGENT2
Total Size:       211 MB
Current Revision:<PHONE_NUMBER>
Consistent Index:<PHONE_NUMBER>
Total Key:        461845
Hash:<PHONE_NUMBER> (667F8483)

# AGENT3
Total Size:       211 MB
Current Revision:<PHONE_NUMBER>
Consistent Index:<PHONE_NUMBER>
Total Key:        461845
Hash:<PHONE_NUMBER> (667F8483)

Then where<PHONE_NUMBER> of AGENT3 does this come from?
I found it here at revision<PHONE_NUMBER> (136 revisions behind).
# AGENT3
Total Size:       211 MB
Current Revision:<PHONE_NUMBER>
Consistent Index:<PHONE_NUMBER>
Total Key:        461709
Hash:<PHONE_NUMBER> (4C52993C)

Which means data were consistent, but AGENT3 was just falling behind.

We killed the leader (AGENT2) at 2016-04-28 05:17:08.889285.
AGENT1 became the new leader at 2016-04-28 05:17:10.974413.
We recovered it at 2016-04-28 05:17:11.204553.
We canceled stressers at 2016-04-28 05:17:11.206395.
We got hash, revisions at 2016-04-28 05:17:11.206410.

This means we had only 2m between recovery and hash check, and AGEN3 was
never a leader BEFORE(AGENT2) and AFTER(AGENT1) failure injection.
We might have to wait more like we do https://github.com/coreos/etcd/pull/5164/files.
# AGENT1
05:17:09.857965 I | raft: AGENT1 is starting a new election at term 34183
05:17:09.858036 I | raft: AGENT1 became candidate at term 34184
05:17:09.858046 I | raft: AGENT1 received vote from AGENT1 at term 34184
05:17:09.858058 I | raft: AGENT1 [logterm: 34183, index:<PHONE_NUMBER>] sent vote request to AGENT2 at term 34184
05:17:09.858074 I | raft: AGENT1 [logterm: 34183, index:<PHONE_NUMBER>] sent vote request to AGENT3 at term 34184
05:17:09.858086 I | raft: raft.node: AGENT1 lost leader AGENT2 at term 34184
05:17:09.859340 E | rafthttp: failed to write AGENT2 on stream Message (write tcp <IP_ADDRESS>:2380-><IP_ADDRESS>:58872: write: broken pipe)
05:17:09.859357 I | rafthttp: the connection with AGENT2 became inactive
05:17:09.861089 I | raft: AGENT1 received vote from AGENT3 at term 34184
05:17:09.861117 I | raft: AGENT1 [quorum:2] has received 2 votes and 0 vote rejections
05:17:09.861155 I | raft: AGENT1 became leader at term 34184
05:17:09.861195 I | raft: raft.node: AGENT1 elected leader AGENT1 at term 34184

# AGENT2
2016-04-28 05:17:08.940383 I | etcdmain: etcd Version: 2.3.0+git
2016-04-28 05:17:08.940428 I | etcdmain: Git SHA: Not provided (use ./build instead of go build)
2016-04-28 05:17:08.940435 I | etcdmain: Go Version: go1.6.2
2016-04-28 05:17:08.940441 I | etcdmain: Go OS/Arch: linux/amd64
2016-04-28 05:17:08.940451 I | etcdmain: setting maximum number of CPUs to 4, total number of available CPUs is 4
2016-04-28 05:17:08.940484 N | etcdmain: the server is already initialized as member before, starting as etcd member...
2016-04-28 05:17:08.940549 I | etcdmain: listening for peers on http://<IP_ADDRESS>:2380
2016-04-28 05:17:08.940577 I | etcdmain: listening for client requests on <IP_ADDRESS>:2379
2016-04-28 05:17:08.955503 W | snap: skipped unexpected non snapshot file<PHONE_NUMBER>05aea6.snap.db
2016-04-28 05:17:08.955525 W | snap: skipped unexpected non snapshot file<PHONE_NUMBER>3851a8.snap.db
2016-04-28 05:17:08.974341 I | etcdserver: recovered store from snapshot at index<PHONE_NUMBER>
2016-04-28 05:17:08.974369 I | etcdserver: name = etcd-1
2016-04-28 05:17:08.974379 I | etcdserver: data dir = agent.etcd
2016-04-28 05:17:08.974391 I | etcdserver: member dir = agent.etcd/member
2016-04-28 05:17:08.974403 I | etcdserver: heartbeat = 100ms
2016-04-28 05:17:08.974425 I | etcdserver: election = 1000ms
2016-04-28 05:17:08.974440 I | etcdserver: snapshot count = 10000
2016-04-28 05:17:08.974455 I | etcdserver: advertise client URLs = http://<IP_ADDRESS>:2379
2016-04-28 05:17:09.212260 I | etcdserver: restarting member AGENT2 in cluster e5a1de03b0c74677 at commit index<PHONE_NUMBER>
2016-04-28 05:17:09.213874 I | raft: AGENT2 became follower at term 34183
2016-04-28 05:17:09.213901 I | raft: newRaft AGENT2 [peers: [AGENT1,AGENT2,AGENT3], term: 34183, commit:<PHONE_NUMBER>, applied:<PHONE_NUMBER>, lastindex:<PHONE_NUMBER>, lastterm: 34183]
2016-04-28 05:17:09.230969 I | membership: added member AGENT1 [http://<IP_ADDRESS>:2380] to cluster e5a1de03b0c74677 from store
2016-04-28 05:17:09.231007 I | membership: added member AGENT2 [http://<IP_ADDRESS>:2380] to cluster e5a1de03b0c74677 from store
2016-04-28 05:17:09.231020 I | membership: added member AGENT3 [http://<IP_ADDRESS>:2380] to cluster e5a1de03b0c74677 from store
2016-04-28 05:17:09.231034 I | membership: set the cluster version to 2.3 from store
2016-04-28 05:17:09.240583 I | storage: restore compact to<PHONE_NUMBER>
2016-04-28 05:17:10.971354 I | etcdserver: starting server... [version: 2.3.0+git, cluster version: 2.3]
2016-04-28 05:17:10.972042 E | etcdmain: failed to notify systemd for readiness: No socket
2016-04-28 05:17:10.972059 E | etcdmain: forgot to set Type=notify in systemd service file?
2016-04-28 05:17:10.972140 I | v2http: enabled capabilities for version 2.3.0
2016-04-28 05:17:10.972201 I | fileutil: purged file agent.etcd/member/snap/0000000000008583-00000000901b6b19.snap successfully
2016-04-28 05:17:10.972345 I | fileutil: purged file agent.etcd/member/snap/0000000000008583-00000000901b94ca.snap successfully
2016-04-28 05:17:10.972479 I | fileutil: purged file agent.etcd/member/snap/0000000000008583-00000000901bbbdd.snap successfully
2016-04-28 05:17:10.972541 I | rafthttp: the connection with AGENT1 became active
2016-04-28 05:17:10.972675 N | etcdmain: serving insecure client requests on <IP_ADDRESS>:2379, this is strongly discouraged!
2016-04-28 05:17:10.973479 I | rafthttp: the connection with AGENT3 became active
2016-04-28 05:17:10.974109 I | raft: AGENT2 [term: 34183] received a MsgHeartbeat message with higher term from AGENT1 [term: 34184]
2016-04-28 05:17:10.974383 I | raft: AGENT2 became follower at term 34184
2016-04-28 05:17:10.974413 I | raft: raft.node: AGENT2 elected leader AGENT1 at term 34184
2016-04-28 05:17:11.088522 I | etcdserver: start to snapshot (applied:<PHONE_NUMBER>, lastsnap:<PHONE_NUMBER>)
2016-04-28 05:17:11.105573 I | etcdserver: saved snapshot at index<PHONE_NUMBER>
2016-04-28 05:17:11.106008 I | etcdserver: compacted raft log at<PHONE_NUMBER>
2016-04-28 05:17:11.174427 I | etcdserver: published {Name:etcd-1 ClientURLs:[http://<IP_ADDRESS>:2379]} to cluster e5a1de03b0c74677

# AGENT3
05:17:08.899181 E | rafthttp: failed to write AGENT2 on stream Message (write tcp <IP_ADDRESS>:2380-><IP_ADDRESS>:57783: write: broken pipe)
05:17:08.899212 I | rafthttp: the connection with AGENT2 became inactive
05:17:09.859943 I | raft: AGENT3 [term: 34183] received a MsgVote message with higher term from AGENT1 [term: 34184]
05:17:09.859999 I | raft: AGENT3 became follower at term 34184
05:17:09.860023 I | raft: AGENT3 [logterm: 34183, index:<PHONE_NUMBER>, vote: 0] voted for AGENT1 [logterm: 34183, index:<PHONE_NUMBER>] at term 34184
05:17:09.860042 I | raft: raft.node: AGENT3 lost leader AGENT2 at term 34184
05:17:09.861755 I | raft: raft.node: AGENT3 elected leader AGENT1 at term 34184
05:17:10.974645 I | rafthttp: the connection with AGENT2 became active

Solution
We've decided to make Hash API more atomic with revisions, so that functional-tester can retry with more accurate revisions (https://github.com/coreos/etcd/pull/5248).


Use abi.encode for fixed-size values

📚 Context
There are places in our code base that use abi.encodePacked for fixed-size values.
This is not necessary, as abi.encode works just like abi.encodePacked for those values.
Plus, abi.encode is shorter.
✔ Solution
Replace abi.encodePacked with abi.encode in those cases.

To be exact, by "fixed size" you mean the fixed 32-byte size. Otherwise, for example, uint64 is fixed size. But abi.encode packs it to 32 bytes while abi.encodePacked doesn't

To be exact, by "fixed size" you mean the fixed 32-byte size. Otherwise, for example, uint64 is fixed size. But abi.encode packs it to 32 bytes while abi.encodePacked doesn't

Ouch, you're right!


BZ1271534: drools-compiler fails to report error for invalid rule with field binding

See https://bugzilla.redhat.com/show_bug.cgi?id=1271534

Reproduced and fixed by https://github.com/droolsjbpm/drools/commit/ce7e91825e64b49b74b5d3db3b9df960bd4e4439


chore: purge usecase interactor

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-2 of 5 (60.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 81.95%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/clinical/presentation/config.go
2
4
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
6824

Relevant Lines:
8327

💛  - Coveralls


Is there a way to wrap long labels ?

Axis labels?

Yes. For ex:
var data = [{
    label: 'somethingA',
    values: [{x: 'SomethingVeryVeryVeryLongA', y: 10}, {x: 'SomethingVeryVeryVeryLongA, y: 4}, {x: 'SomethingVeryVeryVeryLongA', y: 3}]}];

Adding CSS for class x-axis or y-axis and class tick.
https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow
I know this is a very old question. Just adding for completeness.


Updates to README files

Added link from main MOD page to MOD40, began updates for MOD40 content

@neilpeterson @lbugnion or whoever has access, can you please merge when possible?


Improved login session check response time

-updated login session check response time

https://github.com/bcgov/myhealthBC-android/pull/202 has been raised for this fix


guarding against regressions

The hope is that demes is widely-used.  If so, we need to be careful about introducing regressions.  R allows "reverse dependency checking", which takes ages but is common practice for widely-used tools like Rcpp: https://rdrr.io/cran/devtools/man/revdep.html.
AFAIK, Python doesn't support this, in part because PyPi is not considered the one true source of packages.
We could use GitHub actions to check commits against a set of tools, though.
We can be semi-accommodating.  For example:

If a Python tool provides a binary Linux wheel OR compiles quickly (like moments)
AND it provides a tests/test_demes_stuff.py that is compatible with pytest

Then we should be able to have a set of Ubuntu actions that test each tool in a virtualenv, which is presumably needed to guard against inter-package dependency conflicts stemming from requirements.txt files being all over the place.

Good idea.

Good idea.

Forces me to get fwdpy11 wheels auto-deployed upon release now!


Error: Failed to download resource "fontconfig"

Seems I'm unable to install Cairo. This is what I get:
julia> Pkg.add("Cairo")
INFO: Installing Cairo v0.2.28
INFO: Building Homebrew
remote: Counting objects: 6, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 6 (delta 5), reused 3 (delta 2), pack-reused 0
Unpacking objects: 100% (6/6), done.
From https://github.com/Homebrew/homebrew
b9a2b3e..9953017  master     -> origin/master
HEAD is now at 9953017 rocket: migrating to boneyard
HEAD is now at 5c6fc7f Merge branch 'staging'
INFO: Building Cairo
==> Installing cairo from staticfloat/homebrew-juliadeps
==> Installing dependencies for staticfloat/juliadeps/cairo: staticfloat/juliadeps/fon
==> Installing staticfloat/juliadeps/cairo dependency: staticfloat/juliadeps/fontconfi
==> Downloading https://homebrew.bintray.com/bottles-staticfloat/homebrew-juliadeps/fontconfi
curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "fontconfig"
Download failed: https://homebrew.bintray.com/bottles-staticfloat/homebrew-juliadeps/fontconfig-2.11.1.mavericks.bottle.3.tar.gz
Warning: Bottle installation failed: building from source.
Error: /home/roger/.julia/v0.3/Homebrew/deps/usr/opt/pkg-config not present or broken
Please reinstall staticfloat/juliadeps/pkg-config. Sorry :(
======================================[ ERROR: Cairo ]=======================================
failed process: Process(/home/roger/.julia/v0.3/Homebrew/deps/usr/bin/brew install --force-bottle staticfloat/juliadeps/cairo, ProcessExited(1)) [1]
while loading /home/roger/.julia/v0.3/Cairo/deps/build.jl, in expression starting on line 144
=============================================================================================
======================================[ BUILD ERRORS ]=======================================
WARNING: Cairo had build errors.

packages with build errors remain installed in /home/roger/.julia/v0.3
build the package(s) and all dependencies with Pkg.build("Cairo")
build a single package by running its deps/build.jl script

=============================================================================================
INFO: Package database updated
julia> versioninfo()
Julia Version 0.3.10
Commit c8ceeef* (2015-06-24 13:54 UTC)
Platform Info:
System: Darwin (x86_64-apple-darwin13.4.0)
CPU: Intel(R) Xeon(R) CPU           X5650  @ 2.67GHz
WORD_SIZE: 64
BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Nehalem)
LAPACK: libopenblas
LIBM: libopenlibm
LLVM: libLLVM-3.3

Hello @grero, could you please Pkg.update() and try again?

Closing this due to inactivity. If you still have questions, please comment here or open a new issue.

Hey,
Sorry for not getting back to you on this. I did manage to install Cairo after doing Pkg.update(), so thanks for that!


Update auditable-logging-app constitution

The banking-app-sample will have its own constitution. Update the auditable-logging-app sample to follow the same pattern

Also the same update as https://github.com/microsoft/ccf-app-samples/pull/71 should be made


Setup Project to Run Entirely In Docker

Fixes #117. Currently, only the Cassandra database is run in a Docker container. This PR configures the project to run entirely in Docker containers - including the skilldirectory executable. This is needed in preparation for running the project in a dev environment.
Note that once the containers are launched by ./make, the Cassandra container's ports are exposed on host-container:9042, and the API is exposed on host-container:8080 (unless the setup is changed so the containers are launch in another container, host-container is localhost).
THIS PR SHOULD NOT BE MERGED INTO MASTER UNTIL CHECKLIST IS COMPLETE

[x] Create Docker container to run SkillDirectory executable.
[x] Setup networking between Cassandra and SkillDirectory containers.
[x] Change networking between containers to not use hardcoded, dynamic IP. Instead, figure out how to get IP on startup, or set the IP to be static.
[x] Update make file to launch both containers, and change the flag setup to work with containers.

This PR should be ready to merge now 👍


No way to access instance from samples anymore

With #910 some public members were moved to private and can now only be accessed via functions, e.g. has_device() instead of device.
But it looks like there is no way to access the instance anymore. There is no has_instance(), but I need to access it for my shader debug printf sample like this:
	if (instance)
	{
		vkDestroyDebugUtilsMessengerEXT(instance->get_handle(), debug_utils_messenger, nullptr);
	}

So right now I'm stuck and can't continue working on this sample 😟

As this is blocking me with #945 I'll try to fix in in that PR.


proposal: Go 2: reform the variable redeclaration syntax to avoid some confusions and inconveniences

(The following content is a rewritten and an improvement version of this comment)
Abstract
This proposal tries to avoid some problems caused by short variable declarations (a.k.a., variable redeclarations), by introducing a scope viewer identifier concept and using labels as scope viewer identifiers.
Background
We all know that, although short variable declarations (x, y := a, b) do solve some problems, they also brings some new ones. The new problems include:

break the one way to do a specified thing principle in Go. We all know that short declarations overlap too much with standard declarations in functionalities.
short declarations brings some confusions to Go programmers, in particular to new gophers.

It is not very clear to get which identifiers are new declared and which are redeclared at the first glance.
Almost every gophers ever dropped in the famous variable shadowing trap caused by using short declarations. A real world example: https://github.com/Azure/go-ntlmssp/pull/24, and an older issue.
Not all L-values suitable to act as target values are allowed to show up as the target values in short declarations. https://github.com/golang/go/issues/30318. (Another similar one.)
The original intention of short variable declarations is to make code less verbose. However, it makes code more verbose in several scenarios.

Proposal
Proposal part 1: scope viewers
The proposal proposes that we can re-use labels as scope viewer identifiers. The following code shows what are scope viewer identifiers:
func f() {
	var a = 1
x:
	{
	y:
		var a = 2
	z:
		{
			var a = 3

			// x:a <=> y:a
			println(x:a, y:a, z:a, a) // 1 1 2 3
		}
	}
}

Proposal part 2: syntax sugars
There are two sugars for the scope:identifier notation.

:identifier (without the scope prefix), means the innermost declared identifier (it is equivalent to *&identifier).
::identifier, means the package-level declared identifier.

(Digression 1: is it good to view package import names as scope viewer identifiers? So that we can use aPkg::ExportIdentifier to use exported resources.)
(Digression 2: the proposal may also discard the above described scope viewer concept and only contain the following content, by replacing :identifier with *&identifier and using *&identifier as redeclared items.)
Proposal part 3: avoid using short declarations by using scope viewer identifiers
The proposal proposes that we can relax the restriction of the left items in standard variable declarations. Now all left items must be pure identifiers. We can relax the rules as selectors, dereferences, element indexing, and the above mentioned scope:identifier forms are allowed to show up as target values in the left items of a standard variable declaration, as long as there is at least one pure identifier in the left items as well. When the declaration is executed at run time, the new variables represented by pure identifiers are initialized, others are re-assigned with new values. The following is an example without using labels:
 type T struct {
        i *int
        s []int
 }
 var t T
 var p = new(int)

 func bar() {
       // "err" is new declared, others are not.
       var *p, t.i, t.s[1], :p, err = 1, p, 2, t.i, errors.New("bar")
       // *:p is not valid. In other words, :id must show up independently.
       ...
 }

Another more common use case:
    package bar

    func foo() {
       var x, err = f()
       ...
       // Here "err" means the "err" declared above.
       var y, z, :err = g()
s:
       ...
       {
           // The "err" also means the "err" declared above.
           var w, :err = h()
           ...
           // This "err" is a new declared one.
           var m, n, err = k()
           ...

           {
           	// This "err" means the first error declared above.
           	var p, q, s:err = l()
           	...
           }
       }
    }

The := redeclaration syntax should be kept ONLY in the simple statements in control flows, just for aesthetics reason. In other words, ... := ... is totally a shorthand of var ... = ... in the simple statements in control flows.
    if a, b := c, d; a {
    }
    //<=>
    if var a, b = c, d; a { // some ugly
    }
    // However, personally, I also think the ugly version is acceptable.

Rationale
Please see the above backgroud part.
Compatibility
The idea should be Go 1 compatible. What I mean here is the above proposed new redeclaration syntax may coexist with the current standard and short variable declarations.
It is easy to let go fix translate short variable declarations into the above proposed new syntax form. The short declarations in the simple statements in control flows don't need to be translated.
If it needs, the current short declaration uses can be removed eventually.
Implementation
Compiler parsers should consider the new syntax form.
One new statement might need to be added to go/ast standard package.

Aha, I suddenly realized that scope:id might cause some difficulties in parsing container indexing and re-slicing uses. So there are two ways to avoid this:

only allow scope:id to show up as the target items in variable declarations.
use *&id to represent a re-declared target item.

For language change proposals, please fill out the template at https://go.googlesource.com/proposal/+/refs/heads/master/go2-language-changes.md .
When you are done, please reply to the issue with @gopherbot please remove label WaitingForInfo.
Thanks!

Er, I tried to search this template before posting the proposal, but I only found this one instead.
OK, the following uses the new template form:
================================================================
Would you consider yourself a novice, intermediate, or experienced Go programmer?
Experienced (at least in grammar, ;D)
What other languages do you have experience with?
C, C++, AS3
Would this change make Go easier or harder to learn, and why?
Easier. At least less confusions for new gophers, and it removes some inconveniences in Go programming.
Has this idea, or one like it, been proposed before?
There are some similar ones, but none of them proposes to retire short variable declarations
(the current variable redeclaration syntax). This one suggests to retire short variable declaration syntax.
(I decided to remove the scope viewer concept from this proposal.)
Who does this proposal help, and why?
It removes some confusions for new gophers, and it removes some inconveniences in Go programming.
What is the proposed change?
The proposal proposes to retire short variable declarations
(the current variable re-declaration syntax).
Precisely, it proposes the following line
a, b := ... // a is new declared and b is re-declared.

can be expressed as a less confused way:
var a, :b = ...

And it recommends the following code
x, y := ... // x and y are both new declared

should be written as (already supported now):
var x, y = ...

for better readability.
The third, for continence, it also proposes that legal L-values in general assignments
can also show up as the left items in variable declarations/specifications.
For example:
var aPkg.Exported, aValue.Property, *ptr, contianer[k], :reDeclared, newDeclared = ...

Please note, there is an alternative form for :identifier: *&identifier.

The benefit of *&identifier is we don't need to invent a new expression form. It is supported now!
The drawback of *&identifier is it is some verbose.

Is this change backward compatible?
Yes (for what I can tell now). Here what I mean is this proposal doesn't require to retire short variable declarations immediately. Short variable declarations may be retired eventually.
Show example code before and after the change.
An example (in a survey, 21 of 35 participants think the following program prints 6,
which is really the expected result, however the actual result is 4):
package main

func f(n int) (r int) {
  a, r := n-1, n+1
  if a+a == r {
    c, r := n, n*n
    r = r-c
  }
  return r
}

func main() {
  println(f(3))
}

The correct version:
package main

func f(n int) (r int) {
  a, r := n-1, n+1 // might be also a function call
  if a+a == r {
    var c int // If the the type of c declared is in another package, we must import the pacakge.
    c, r = n, n*n
    r = r-c
  }
  return r
}

func main() {
  println(f(3))
}

After the change (It is less confused and still avoids verboseness):
package main

func f(n int) (r int) {
  a, r := n-1, n+1
  if a+a == r {
    var c, :r = n, n*n
    r = r-c
  }
  return r
}

func main() {
  println(f(3))
}

What is the cost of this proposal? (Every language change has a cost).
How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?
Many, but the impact is expected to be smaller than introducing type aliases, and it is easy to update these tools.
What is the compile time cost?
Very small.
What is the run time cost?
None.
How would the language spec change?
Add a new variable declaration+assignment hybrid statement.
VarDecl     = "var" ( VarSpec | "(" { VarSpec ";" } ")" ) .
VarSpec     = ExpressionList "=" ExpressionList .

Each left-hand side operand must be addressable, a map index expression,
or (for = assignments only) the blank identifier. Operands may be parenthesized.
In particular, there must at least one left-hand side operand is a pure identifier.

Orthogonality: how does this change interact or overlap with existing features?
It avoids one variable declaration form.
Is the goal of this change a performance improvement?
No.
Does this affect error handling?
No.
Is this about generics?
Not.

@gopherbot please remove label WaitingForInfo.

The proposal described in the template (https://github.com/golang/go/issues/38388#issuecomment-614073531) seems significantly different from the proposal described in the original post on this issue.  For example, there are no scope viewers in the template discussion.  What is the actual proposal here?  Thanks.
The idea of annotating the variables that should be newly declared in a := statement has been raised before, in #377.

There is a problem in the form scope:id from the original post, when the form shows up in re-slice and element indexing expressions, so I removed it from the new template version. OK, I decided to add it back with a new form scope'id, so that it can show up in re-slice and element indexing expressions.

The idea of annotating the variables that should be newly declared in a := statement has been raised before, in #377.

This is half true. None of the ideas in https://github.com/golang/go/issues/377 propose to retire the current re-declaration syntax form.

Removing a widely used feature like redeclarations on := will be so far in the future that there is little point in discussing it.  We can discuss adding some new feature.  If over time that feature replaces redeclarations, then years from now we can remove redeclarations.
go fix is not a panacea here, because go fix can't fix all the existing documentation and written examples and blog posts.

The
var scope'redeclared, 'redeclared, newDeclared = ...

form can coexist with the current redeclarations.

go fix can't fix all the existing documentation and written examples and blog posts.

Yes, this is true. It has happened for "named type" definition and the behavior of fmt.Print(aMap). It is really hard to totally avoid such situations.

Sorry, we're still not clear on what the actual proposal is here.  It's hard to track the changes in this issue.
In
:p, err := F()

is p a new identifier?  Or is :p a reference to an identifier in an enclosing scope, where that identifier must exist?
Are scoped variable references still required by this proposal?  Can this proposal be described in just a few succinct lines?
Thanks.

@ianlancetaylor
The :id notation has been changed to 'id. The reason is 'id may show up in slice and index expressions, but :id may not. Sorry, the change might not show up in the mail list.
Here, I summarize the proposal simply. The proposal suggests three changes to Go.
1.
Recommend to replace the current re-declaration syntax form
newdeclared, redeclared := ...

with a clearer form.
var newDeclared, 'reDeclared := ...

The new clearer form shows which identifiers are re-declared clearly.
2.
Support "variable declaration + assignment" hybrid statement, as long as there is at least one pure identifier target item. For example,
var aPkg.Exp, aValue.Sel, *ptr, contianer[k], 'reDeclared, newDeclared = ...

3.
Use labels as scope viewers. An example:
func f() {
	var a = 1
x:
	{
	y:
		var a = 2
	z:
		{
			var a = 3

			// x'a <=> y'a
			println(x'a, y'a, z'a, a) // 1 1 2 3
		}
	}
}

Some ideas in this proposal have been mentioned in other issue threads, but this one differs from them by recommending to retire the current re-declaration syntax form.

I'm sorry, I just mis-wrote
var newDeclared, 'reDeclared = ...

as
var newDeclared, 'reDeclared := ...

Thanks.  Your change 1 and 2 from https://github.com/golang/go/issues/38388#issuecomment-624695578 seem to be adequately covered by #377.
I'm not clear on when change 3 would be useful.  If you want to refer to a variable in an outer scope, don't shadow it.  It seems to me that it is rather confusing to shadow a variable from an outer scope if you then need to refer to it.  Introducing a way to get around that shadowing seems like adding complexity to avoid a complex situation, when there is already an easy way to simplify the situation instead by renaming the variable.

https://github.com/golang/go/issues/377 doesn't cover the change 2, https://github.com/golang/go/issues/30318 does.
Without considering the change 3, this proposal can be viewed as a merge of https://github.com/golang/go/issues/377 and https://github.com/golang/go/issues/30318. And this proposal differs from them by recommending to retire the current re-declaration syntax form.

As I mentioned above, though, we really can't remove the current re-declaration syntax.  So the best we could do to "retire" it would be to advise people writing new code to use a different form.

So the best we could do to "retire" it would be to advise people writing new code to use a different form.

Sorry for my bad description. In fact, this is exactly the way that this current proposal suggests.

As discussed above, parts of this are covered by #377.  The idea of referencing variables in different labeled scopes is new, but does not seem like a feature that is essential to the language.  People can instead rename variables.  Also, emoji voting for this proposal is negative.
For those reasons, this proposal is itself a likely decline.  We can pursue further discussions on #377.  Leaving open for four weeks for final comments.

The other two issues don't pursue retiring the := token.
But ok, it is not bad to discuss this in the other issues.

No change in consensus.  Closing.


when running "sh make.sh" in windows I get this error

error D8021
error: command 'C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX86\x64\cl.exe' failed with exit code 2
Is FaceBoxesV2 compatible with windows or am I doing something wrong?.
Thanks in advance.

I repared this error by changing "extra_compile_args=["-Wno-cpp", "-Wno-unused-function"]" to "extra_compile_args={'gcc': ['/Qstd=c99']}". However, other errors came.
All seems to work nice in ubuntu.

Indeed. The code was only tested under Ubuntu. For Windows, you may replace the NMS module with a pytorch implementation, which does not require compilation.

Thanks, you replied too fast. I just found a way to get this working on windows here: https://github.com/rbgirshick/py-faster-rcnn/issues/36?ref=https://githubhelp.com
All I have done is:

In build.py I uncommented the line 46 and commented the line 47.
Before calling to make.sh I changed the line 25 of cpu_nms.pyx to:
 cdef np.ndarray[np.int_t, ndim=1] order = scores.argsort()[::-1].astype('int32')

I hope somebody can help this.
Also I found some deprecations in functions.py in lines 185 and 190.  I repaired them using torch.div and rounding_mode='floor' instead of //.
Have a nice day.

Nice. Good to know. Your information would be helpful to others. Thank you.

Thanks, you replied too fast. I just found a way to get this working on windows here: https://github.com/rbgirshick/py-faster-rcnn/issues/36?ref=https://githubhelp.com
All I have done is:

In build.py I uncommented the line 46 and commented the line 47.
Before calling to make.sh I changed the line 25 of cpu_nms.pyx to:
 cdef np.ndarray[np.int_t, ndim=1] order = scores.argsort()[::-1].astype('int32')

I hope somebody can help this.
Also I found some deprecations in functions.py in lines 185 and 190. I repaired them using torch.div and rounding_mode='floor' instead of //.
Have a nice day.

Thank you so much, was running into this same issue myself.


[Fix #7108] Change autocorrection of StderrPuts to Kernel.warn

This fixes #7108.

This cop is based on the Ruby Style Guide.
https://github.com/rubocop-hq/ruby-style-guide#warn
The Ruby Style Guide may have to be updated first. I think this change is appropriate if accepted there.

Yeah, I agree with @koic. We have to keep in mind it's extremely uncommon to see Kernel methods be called with the module prefix, mostly because it's generally a bad practice to define methods that hide them (we might even have some cop for that or at least we planned to add one).

That makes sense. This seemed like an easy enough fix so I didn't fully think of the implication of adding Kernel. What are your thoughts on this being a configuration option?

#7810 proposes detecting overrides of Kernel methods. However, I'd argue that certain Kernel methods are regularly overridden (e.g. puts and print are in fact convenience methods to stdout, but are a common part of the API for any IO-like object).
Rather, if we were able to to detect an override of Kernel, then this cop should check if warn is overridden in scope and then replace with Kernel.warn (and otherwise continue replacing with warn).
As it stands right now, this cop is unsafe and can introduce stack overflows. Test case:
class Foo
  def warn(message)
    $stderr.puts "\e[33m#{message}\e[0m"
  end
end


port fix for #19035

This PR fixes #19035
original PR: https://github.com/microsoft/azuredatastudio/pull/19053

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.278%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27598

Relevant Lines:
61018

💛  - Coveralls


Roll engine 8b2d80f83351..7df8b7af7341 (1 commits)

https://github.com/flutter/engine/compare/8b2d80f83351...7df8b7af7341
git log 8b2d80f8335144d182d045c3f852bb177b78f482..7df8b7af7341e2c2537d1050467b38736cfbcace --no-merges --oneline
7df8b7af7 Roll src/third_party/dart 832668ff6c..6c3a91f281 (2 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


unsubscribe pulsar consumer before closing

That way it won't produce "Consumer is already closed" exception in the receive
flow which end up as Operator called default onErrorDropped - org.apache.pulsar.client.api.PulsarClientException$AlreadyClosedException: Consumer is already closed
in the logs. That happens cause first general flow cancelled, while receive is still there. So when receive flow is cancelled, consumer is already closed.
Forcing client to unsubscribe will ensure receive flow wouldn't be there at the moment of the general flow cancellation.
This change could be considered as cosmetic, so its hard to test without massive code. But could be reproduced with the client disconnection in the logs relatively easy.

Not sure test fails are related to the change, but as anyway pulsar plugin doesn't work as intended, better just to rewrite


Added playsound admin logging

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable

Implements basic logging into the playsound module. Simple things like: adding playsound, editing playsound (without/with link) and removing playsound. I decided not to complicate it too much and risk flooding logs by someone adjusting the volume/cooldown, etc.
Fixes #1381

I went ahead and complicated your edit entry so the changed values are listed;


volumes

im using nginx with dockergen but im having issues
when u have volumes_from: nginx, and the volumes on nginx works with the following
volumes;
  - /etc/nginx/conf.d

but doesn't work with
volumes:

"./config/nginx.conf.d/sandbox.conf:/etc/nginx/conf.d/sandbox.conf

i also change the last line of command in dockergen to sandbox.conf as well
but i get like
2019/08/23 22:59:00 Unable to create dest file /etc/nginx/conf.d/sandbox.conf: rename /etc/nginx/conf.d/docker-gen685763114 /etc/nginx/conf.d/sandbox.conf: device or resource busy

i'm closing this, i figure this out already. misconfigured.


Migrate Web Analytics prototype to PDS Cloud

💡 Description

Migrate the deployed https://github.com/NASA-PDS/web-analytics, Athena, and Quicksight instances from @kaipak's group's AWS to PDS
Sub-tasks to be identified by @jimmie

📆 May status: In progress. Delayed 1 sprint. No impact anticipated.

📆 July status: delayed on additional sprint. This is a non-critical task and can be completed anytime during this or next build.

📆 August status: expected to be done by end of sprint, 9/8

Should have this stood up to the point of being able to query from Athena but am waiting on permissions (as usual). Further discussion will be necessary regarding Quicksight since it requires additional AWS subscriptions.

:calendar: Sept Status: No impact on build. Moving to B13.1 work effort

:calendar: December status: Pushed out 1 more sprint. no affect on B13.1 delivery.

📆 January status: Delayed several sprints to deal with registry issues. No impact on delivery. Not required for B13.1

:calendar: March status: Deferred to B14.0 due to some SA acces issues. No impact on delivery. This is in work and part of "beta" efforts

📆 April status: Migration and improvement of dashboards ongoing. Scope increase to include data sync scripts. Beta task. No impact on build.

📆 May status: Migration completed. Working on new infra, cron jobs, and improved reporting. New tasks to come


Issue 17

Coverage decreased (-0.8%) to 95.294% when pulling 596de9054cee8247154a8192bbe19d4fc8628d95 on issue-17 into 5a07fc8771b58be1ce26fed8b928794288825b7e on master.


syntax highlightning

Hi, since Medium now supports syntax highlighting, would it be possible to add an update so that code blocks are inserted in such a way that they get this highlighting by default? Currently I have to copy/delete/reinsert each code block to get syntax highlighting.

Hi,
I haven't seen this yet - I'll look into it in the coming week and get back to you.
If it's quick i'll get it implemented right away, if not then i'll come back with what I find anyway.
Thanks for using the package!
Mark

Btw - are you using the 'gist' feature?
If not then that likely solves your issue at least for now by creating nicely formatted code blocks using gist - info on how to set up here:
https://github.com/dexplo/jupyter_to_medium#create--save-your-github-pat-only-required-for-gist-integration

Just had a quick look - here is the release notes they had:
https://blog.medium.com/code-blocks-with-syntax-highlighting-53343df53c4f
It looks like they don't yet support markdown style language declaration like:
"``` python
import numpy as np
x = np.arange(0, 100)

If they do that then we can support it by adding that to the code snippets when we upload the articles - otherwise without the medium api being enhanced we can't submit the syntax highlighted codeblocks.

For now, I think your best bet is either to continue to manually copy and paste (smaller number of code blocks) or use the gist feature we have that will automatically create and embed gists in your article.

Mark


Where is the source code ???????

Where is the source code ???????

no one can prove what you are doing in the back with all that kind of user data ...
no one can take part in development ...
Why there is no source?
Couldnt find it with google ....


Add documentation for adding new crawlers

@jdemaeyer @ThorbenJensen @tomsrocket Since all of you now have implemented a scraper, who wants to take this?

@ubergesundheit , i am not super familiar with scrapy, so maybe someone else would like to take this?


Add instruction to add disableStaticImages: true

This documents the fix to #251 (I'm not sure if that's enough to close the issue). Someone who knows more about the issue should word this more concretely with more information if required. So consider this as "draft".
I just wanted to get this in readme because I myself spent way too long trying to fix it, apparently initially it didn't even show any errors it's only when I tried it on a fresh create-next-app project it showed this error and then I landed on the issue page.
Thanks a lot for this plugin, I like it a lot especially more than next/image because this is more primitive and I'm in control of things!

Just stumbled upon this problem.
Could you please merge the fix?:)


Failure to deploy while following tutorial instructions.

Context

Expected Behavior
Successful deployment.
Actual Behavior
Failed deployment with following traceback.
Oh no! An error occurred! :(

==============

Traceback (most recent call last):
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/zappa/cli.py", line 2610, in handle
    sys.exit(cli.handle())
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/zappa/cli.py", line 505, in handle
    self.dispatch_command(self.command, stage)
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/zappa/cli.py", line 539, in dispatch_command
    self.deploy(self.vargs['zip'])
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/zappa/cli.py", line 769, in deploy
    self.lambda_arn = self.zappa.create_lambda_function(**kwargs)
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/zappa/core.py", line 1048, in create_lambda_function
    response = self.lambda_client.create_function(**kwargs)
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/botocore/client.py", line 312, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "~/.virtualenvs/zappademo/lib/python2.7/site-packages/botocore/client.py", line 605, in _make_api_call
    raise error_class(parsed_response, operation_name)
ClientError: An error occurred (SubscriptionRequiredException) when calling the CreateFunction operation: The AWS Access Key Id needs a subscription for the service

==============

Possible Fix

Steps to Reproduce

django-admin startproject zappademo
cd zappademo
mkvirtualenv zappademo
pip install django zappa
zappa init # accept all defaults
zappa deploy dev

Your Environment

Zappa version used: 0.45.1
Operating System and Python version: macOS 10.12.6
The output of pip freeze:

argcomplete==1.9.2
base58==0.2.4
boto3==1.4.7
botocore==1.7.39
certifi==2017.11.5
chardet==3.0.4
click==6.7
Django==1.11.7
docutils==0.14
durationpy==0.5
future==0.16.0
futures==3.1.1
hjson==3.0.1
idna==2.6
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.19.0
placebo==0.8.1
python-dateutil==2.6.1
python-slugify==1.2.4
pytz==2017.3
PyYAML==3.12
requests==2.18.4
s3transfer==0.1.11
six==1.11.0
toml==0.9.3
tqdm==4.19.1
troposphere==2.0.2
Unidecode==0.4.21
urllib3==1.22
Werkzeug==0.12
wsgi-request-logger==0.4.6
zappa==0.45.1

Link to your project (optional):
Your zappa_settings.json:

{
    "dev": {
        "aws_region": "ap-southeast-2",
        "django_settings": "zappademo.settings",
        "profile_name": "default",
        "project_name": "zappademo",
        "runtime": "python2.7",
        "s3_bucket": "zappa-wcdm8o6hz"
    }
}

Seems to have been related to my billing details; updating my credit card resolved the issue and I was able to upload the bundle.

it is normal that i have the same message, but i can update in a machine with a key an api, but using the same credentials in another machine gave me that message "The AWS Access Key Id needs a subscription for the service" ?


exceptions get wrapped in CompletionException

I don't like this CompletionException thing at all, but I guess there's no way to avoid it when using CompletionStages.
But I guess they're also leaking into our Mutiny API. We should try to prevent that.

Digging through our stack traces is actually pretty painful. We need to figure out how to improve this.

I investigated this and there doesn't seem to be a problem (anymore?).


In-depth guide improvments

on the donejs in-depth guide some hyperlinks point to the canjs version 2 website
https://donejs.com/place-my-order.html#switch-between-components

To learn more about routing visit the CanJS guide on Application State and Routing.
...then progressively loads the component with can-import and initializes it.

yesh, we should either remove that line or link to an updated version of that sort of guide.

Hey guys, I have the links that need to be fixed. I would like to get some help with setting up on fixing these errors.

hey @CleverOscar you can make PR against https://github.com/donejs/donejs/blob/master/docs/guides/place-my-order.md

@pYr0x I made the PR, hopefully, you can help me out.

Was this ever resolved?

Where's the PR


[Bug]: Type definitions exported by @jest/test-result refer to dev dependency

Version
29.7.0
Steps to reproduce

npm i<EMAIL_ADDRESS>Import from package directly or indirectly in a typescript file e.g. echo "import * as testResult from '@jest/test-result';" > index.ts
Attempt to compile npx tsc index.ts

https://stackblitz.com/edit/node-my9zod?file=index.ts,package.json,package-lock.json
(Real use case) https://stackblitz.com/edit/node-ru6fy9?file=index.ts,package.json
Expected behavior
No Typescript compilation errors
Actual behavior
Typescript error thrown
node_modules/@jest/test-result/build/index.d.ts:14:27 - error TS2307: Cannot find module 'jest-resolve' or its corresponding type declarations.

14 import type Resolver from 'jest-resolve';
                             ~~~~~~~~~~~~~~

Found 1 error in ../../node_modules/.pnpm/@jest+test-result@29.7.0/node_modules/@jest/test-result/build/index.d.ts:14

Additional context
The type declarations of https://www.npmjs.com/package/@jest/test-result import from 'jest-resolve' despite it only being depended on as a dev dependency.
Environment
System:
    OS: Linux 5.0 undefined
    CPU: (6) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm

Happy to take a PR for this 👍

Is it possible to prevent this issue from becoming stale?
I haven't had a chance to look at resolving but it still remains an issue.


Interaction of exact types with optional fields and spreads

I've discovered the following behaviour in flow:
https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVAXAngBwKZgCyWAKrgQLxgDeAPqmI1HHAPwBcYAdgK4C2AIzwAnADQNGAgIbCOYAM4ZhASy4BzUWFS0AvgG50UHlwDGGZXC5goymBhEAxFgAoMnYmXwBKd6XI0JZSgwVwA6ZjgwCmiwAEYAJgBmLwDGRhNLRRoIzVC84TxFHSiwDAM0sAKMHmErAsVysB0JKpqrMtRm1CNTc0trW3thJzh4119PPB8iP3xUsCCQjHCWKJiE5Pn0zIxsllz8woxiqg6K1tqwAHkBACs8M1CpeXllNS5nah1NeowvRuajAu7QMXR6ZgsVhsdkcLES4xmk2mHn81ECwTCETWVA2KTRFQyXCy1ByYDyoV+J1KjSBeGql2o5MpAJadLa1M6QA
Basically, given
type MyType = {|
   foo?: number,
   bar?: string,
|};

Why does
function filterFoo3(t: MyType): MyType {
  if (t.foo === 123) {
    const {foo, ...rest} = t;
    return {...rest};
  }
  return t;
}

typecheck, while both
function filterFoo(t: MyType): MyType {
  if (t.foo === 123) {
    const {foo, ...rest} = t;
    return rest;
  }
  return t;
}

and
function filterFoo2(t: MyType): MyType {
  if (t.foo === 123) {
    const {foo, ...rest} = t;
    return Object.assign({}, rest);
  }
  return t;
}

fail to type check?

Maybe related to #5548

Ah, yes, that looks very alike!


2D array inside function ( SystemVerilog only ? )

I am not sure this is legal in verilog but i will try :
function f(input i);
reg [1:0] mem0 [1:0];
f = 1'd0;
endfunction
module m(in,out);
input in;
output out;
assign out = f(in);
endmodule
i am getting the following error :
ERROR: Local declaration in unnamed block at <> is an unsupported SystemVerilog feature!
should we address a function as a module or as a block in the definition of "unnamed block" ?
Thanks

Thanks for reporting this. Fixed in commit 2d32c6c.


Bug #108: Version Id is not correctly set

Fixes #108

LGTM for the bug I noticed in #108 , I'm just not sure that's the reason @OzBob raised the issue in the first place.


Running Catalyst / OnServer: Error 1 / OnLocalPC: Warning&Error1 🤔🤔

Hello Sir! 🙂
Just testing and understanding around better the tech.
On this repo:
https://github.com/decentraland/catalyst

PROBLEM:
I have tried to run it on myserver Ubuntu 20.4 and on my LocalPC Windows 10, and am getting this results:
SERVER: Ubuntu 20.4
cd /var/www/catalyst
yarn install
yarn build // error 1

yarn test // error 1

LOCAL PC: Windows 10
yarn install
yarn build // No license field?

yarn test // error 1

QUESTION:
Any hint on what is the problem?
Is it important the "No license field"? If so, were do i find it?
Thanks! 😎🙏

Please try again with the latest version and if the issue persists then please open another ticket. thanks!


registry.terraform.io/providers/kenzo0107/sendgrid/latest remains at 1.0.0

GitHub Actions releases have been released as 1.0.0, 1.0.1, 1.0.2, and 1.0.3. https://registry.terraform.io/providers/kenzo0107/sendgrid/latest remains at 1.0.0.
I contacted support regarding the above and currently waiting for a reply.
https://support.hashicorp.com/hc/en-us/requests/141906

Fix by Hashicorp Terraform Registry Support


What is the planned relationship between MinimumScene and TransportSceneManager?

I noticed that MinimumScene has the following, but then I came across TransportSceneManager which seems to manage the same set of topics and service. Is the plan that this functionality will be removed from MinimumScene and TransportSceneManager should be used going forward or is there another intended purpose of TransportSceneManager?
    /// \brief Scene service. If not empty, a request will be made to get the
    /// scene information using this service and the renderer will populate the
    /// scene based on the response data
    public: std::string sceneService;

    /// \brief Scene pose topic. If not empty, a node will subcribe to this
    /// topic to get pose updates of objects in the scene
    public: std::string poseTopic;

    /// \brief Ign-transport deletion topic name
    public: std::string deletionTopic;

    /// \brief Ign-transport scene topic name
    /// New scene messages will be published to this topic when an entities are
    /// added
    public: std::string sceneTopic;

I think these methods and attributes are there for some historical reason. Because are not used at all. I created a PR to remove then

Thank you for the support.


Failures when build boost with MSVC+ /permissive-

Boost test ‘test_json_parser’ in libs\property_tree\test failed with error C2589 C2760 when build with /permissive- in windows, this is source issue looks involved by https://github.com/boostorg/format/commit/bc53dbbaa235031954a854f87cdf04e1103e2a6d#diff-67bfd7972eb56b5161d31780dbaa62a2
The source includes windows.h which defines the macro 'min' and 'max'. It need define ‘NOMINMAX’ before include ‘windows.h‘.
Environment: windows server 2016 + Visual studio 2017 update2 + Boost( master branch with latest revision ‘b30e350’)
Failures like:
test_json_parser.cpp
Info: Boost.Config is older than your compiler version - probably nothing bad will happen - but you may wish to look for an update Boost version.  Define BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE to suppress this message.
.\boost/format/feed_args.hpp(205): warning C4003: not enough actual parameters for macro 'max'
.\boost/format/feed_args.hpp(250): warning C4003: not enough actual parameters for macro 'max'
.\boost/format/feed_args.hpp(205): error C2589: '(': illegal token on right side of '::'
.\boost/format/feed_args.hpp(205): error C2760: syntax error: unexpected token '(', expected ')'

Resolved on October 24:
https://github.com/boostorg/format/commit/ef8ce677b0716f882221d0f2de2d56c14937ca9c#diff-3e58adef3e949129f16441f608d7817f

master has been refreshed with the fix - closing

Thank you for these quickly fix!


shaka-packager: 2.6.1 -> 3.0.4

Description of changes

Thanks to shaka-packager now using CMake as build system, we can replace the current use of upstream binaries with a from-source build. The changelogs since v2.6.1 can be found here:

https://github.com/shaka-project/shaka-packager/releases/tag/v3.0.0
https://github.com/shaka-project/shaka-packager/releases/tag/v3.0.1
https://github.com/shaka-project/shaka-packager/releases/tag/v3.0.2
https://github.com/shaka-project/shaka-packager/releases/tag/v3.0.3
https://github.com/shaka-project/shaka-packager/releases/tag/v3.0.4

As so far shaka-packager did not have an assigned nixpkgs maintainer, I added myself.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3753

Needing apple_sdk newer than current version for x86_64-darwin?

Needing apple_sdk newer than current version for x86_64-darwin?

Testing x86_64-darwin right now and will report back :)

Result of nixpkgs-review pr 301846 run on aarch64-darwin 1

1 package built:

shaka-packager

Result of nixpkgs-review pr 301846 run on x86_64-darwin 1

1 package built:

shaka-packager

Result of nixpkgs-review pr 301846 run on aarch64-linux 1

1 package failed to build:

shaka-packager

Result of nixpkgs-review pr 301846 run on x86_64-linux 1

1 package built:

shaka-packager

Result of nixpkgs-review pr 301846 run on aarch64-linux 1

1 package built:

shaka-packager

Added some more comments to explain why the patches are necessary and what they do.

Moved to pkgs/by-name to allow future updates using the nixpkgs-merge-bot

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4538

Result of nixpkgs-review pr 301846 run on x86_64-linux 1

3 packages built:

libwebm
libwebm.dev
shaka-packager

@SuperSandro2000 Is there anything else from your side? (if you currently don't have time for reviews don't worry, mainly asking because your change request has been resolved but is still blocking)


[Bug]: No models when browsing on Firefox & logged in

What happened?
I log in through my Google account. When I am l logged into my account, all models disappear. I have checked my filter settings and this is not the issue. In my settings I have all content toggled on. This is persistent on all pages, from the front page to my faves to my download history, even to my hidden models. I can't even see the categories.
However, if I log in on Edge everything functions as it should but I'm pretty loathe to use Edge.

Steps to reproduce the problem
Unfortunately I'm not sure how to properly reproduce the problem. All I can say is that if I log into my account on Firefox it doesn't work.
What should have happened?
I should have seen models.
What platforms do you use to access the site?
Windows
What browsers do you use to access the site?
Mozilla Firefox, Microsoft Edge
Additional information, context and logs
No response

Sorry for the delayed reply, I thought I had notifications turned on for this thread but I didn't.
I do have some hidden tags and users, yes, but nothing shows up even if I set the view to "show everything", and once again everything works on Edge.
Further info--

Site loads fine while logged in on Firefox on my netbook and tablet, just not my PC. However I can't really download on either of them, and I only do work on my PC.
I am using an ad blocker (UBlock Origin) but turning it off doesn't change anything; furthermore it's fine with it on my netbook.

I attached screenshots of Network and Console on both Firefox and Edge, clearly labelled.

Oddly, while seeing if I could diagnose anything else myself, I found while logged in, my userpage is a 404, but once again only on Firefox. I saved a model's URL, logged in, and tried to go to it and it was a 404 as well when logged in. Neither page 404'd when logged out.

Based on your shared screenshots, seems like firefox is stripping out the referrer header from your request. If the referrer doesn't match in our servers then we block the request hence why you're getting a 401 Unauthorized http error. Please check your browser settings or disable any other extensions that might be removing the referrer from the request

I disabled all my extensions, and also tried running in safe mode, and it still isn't working, I'm afraid. I haven't done anything in the settings that would have changed this nor do I know what indeed would. If you can provide me any more guidance I am happy to try.

I currently have zero extensions installed. I temporarily uninstalled them all to aid in debugging.

On the 401 errors, there IS no referer listed. The information is the same as in your screenshot, just minus the referer, and that I'm using the Windows version of Firefox.

This error is in the response windows: json	Object { message: "Please use the public API instead: https://github.com/civitai/civitai/wiki/REST-API-Reference", code: -32001, data: {…} }
I checked the various 401 errors and they all read the same, though some had the error only once.

It might be that you changed your browser settings at some point to prevent sending the referrer. Please check this link for more information how to enable it back https://privacyinternational.org/guide-step/4148/change-http-referer-settings-firefox. Also if you need info about what each of the parameters do check this out https://wiki.mozilla.org/Security/Referrer. Hope this helps!

So I am aware of the config deep settings but I swear I never touched them here and I didn't think to check them until you said-- however, they were all at default values so I don't know still.
So in frustration I just refreshed firefox to default through the troubleshoot menu. I was trying to avoid doing that because I didn't want to set up my browser again but I'd already uninstalled all my extentionsions SOOO. But, that did the trick and it works now so yeah obviously it was something in my settings but hell if I know what.
Thanks so much for troubleshooting this with me, sorry for the bother. Hopefully if anyone else has this issue though this'll help them.


[mixcloud] Fix extraction of URL and like-count

When I went to download Mixcloud songs, youtube-dl tried with a .mp3 URL first, then only m4a (which works once it finds a server from stream1 to stream30). This doesn't seem like a valid strategy anymore. From when I've seen in the Chrome console, only .m4a are streamed now.
So I updated the way URLs are extracted from the current DOM structure (like_count as well) and removed the .mp3 => .m4a fallback, now .m4a only.
Also, trying stream1..30 was slow. I made it so it tries the preview's server first (like stream18), then further and further out: stream19, 17, 20, 16, 21, ...
Needs testing, but should be stable from my tests.

It doesn't work for our test urls (http://www.mixcloud.com/dholbach/cryptkeeper/ and http://www.mixcloud.com/gillespeterson/caribou-7-inch-vinyl-mix-chat/)

I have cherry picked the fix for the like count in fa8ce2690447fa06a10398efd5b6dfa96c2ed1b4 and the change in the server order in aae53774f247edcca7671434c16f7931d5c7b9da.
If you have a way for detecting if the track is available in m4a or mp3, we'd review it.
Thanks!

@jaimeMF OK, thanks for your comments, I had never coded in Python before, that was very helpful! Don't yet know what's the deal with mp3 vs m4a though.