watchdog

My crashed after a couple of days. I did install manually using stretch and they say that the PI watchdog is not enabled by default.
There are lots of manuals around that describe how to set up the WD so that it triggers if a file (e.g. log) has not changed for some time.
Question: which file should I set the trigger to if I wanted to monitor the correct operation of the CCU ?
Is piVCCU using / activating the WD?

That may work. I found a means to create a file using the CCU, however, this file would exist in the lxc container and is not visible for the watchdog daemon. I tried all day to expose a directory from the container, e.g.
https://gist.github.com/julianlam/07abef272136ea14a627
...but the file structure does not match. Can you give directions on how to manipulate a file with a ccu program that is actually accessible for other processes on the pi ?

The folder /usr/local on the CCU is mapped to the folder /var/lib/piVCCU/userfs out of the box and should work for this.
The folder /tmp and /var of the CCU is a tempfs which resides inside the CCU container only. You should not map that to a permanent filesystem to avoid sd card damages due to the excesive write access.
To use custom mount points, you need to edit the file /etc/piVCCU/lxc.config


Snapping window to left side of right screen loses part of first character column

Environment
Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.6.2951.0

Display setup:
Left: Surface Book 1, 3000x2000 @ 200%
Right: Ultrawide, 3440x1440 @ 100%

Steps to reproduce

Launch Terminal, move to right display
Maximize on right display with Win+Up
Set to left half of right display with Win+Left

Expected behavior
The Terminal window should be completely contained within the left half of the right display.
Actual behavior
The Terminal window will have the left-most chrome border and some of the console output on the left screen.
A screenshot of this is tough, but notice that the border is overlapping the adjacent scroll bar that is maximized on the left display here.

Workaround hack
Once the window is consuming half the screen, you can send it to the other displays left half with Win+Shift+Left/+Right. Then, sending it back to the original, right display with Win+Shift+Left/+Right will cause it to fit where expected.
Here is that same section of adjacent windows after the workaround, showing no overlap on the scrollbar.

This looks like a /dupe of #3394. A bunch of stuff related to the border and the pixel counts around the edge was fixed there. If this still happens against master or against v0.7 when it comes out, please reactivate then.


Style: add git hooks for prettier and linter

Create a commit/push pipeline that assures the code meets the style standards

closed in #2


ci: Add timeouts and fail handling on some hanging actions

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

cc @alyssawilk im thinking we can do something similar on the mobile jobs that are hanging on fail

cool! that worked
#15 [linux/arm64 binary 3/3] ADD linux/arm64/release.tar.zst /usr/local/bin/
ERROR: failed to receive status: rpc error: code = Canceled desc = context canceled
Docker build timed out ...
trying again ...
#1 [internal] booting buildkit
#1 starting container buildx_buildkit_multi-builder0
#1 starting container buildx_buildkit_multi-builder0 0.6s done
#1 DONE 0.6s

wohoo!


Stock span problem shifted to stack section

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description

#1600 was merged
New stack section created later
Problem shifted to stack section

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1600

Please note that either of PR #1711 or #1601 will have merge conflict when the other is merged is first. It would be resolved by me by simply editing the readme


IT-2011: Remove amiId for runner

Attempting to resolve manager not connecting to runner. We added this to the original script, pulling back to docker-machine can pick the AMI itself.

Looks good to me!


Get rid of Format model

On today's meeting with @martinbilek  and @whit we agreed that it will be nice to get rid of photo format altogether and switch to Django settings-based formats. There nothing really useful about the way photo formats are defined as it's usually done only once during the site lifecycle - at the time the site is built.
By using settings-based formats, we will save some DB queries and it will be much simpler to manage the list of formats.

I am strongly against this for several reasons:

we use the format ID everywhere and across sites, how do you synchronize settings for multiple projects?
I really don't want designers in my settings.py or anywhere near python but I really don't want them to bother me to create a Format for them either
how do you then make sure you can share images across sites?
if you want to define them once in code, use fixtures and you lose nothing from the functionality.

how about we just cache all the formats in memory? Do something like Format.objects.get_for_name() which would have similar caching logic as Django ContentType's get_for_id(). I wanted to do that anyways. Also note that when you use cached template loader all the {% img %} tags will load their format on compile time so the Format is cached in memory even now for majority of use cases.

I am closing this. I can see why somebody would want a simpler way of creating thumbnails and am not against that at all, but if we decide we want anything like that, let's built it next to the existing solution which actually works very well for a lot of use cases.


Desktop_Viewer send inputs

Desktop Viewer needs to send inputs: keyboard + mouse inputs
This should convert to native input commands on the receiving side.

In Progress

Completed as part of https://github.com/smasherprog/Remote_Access_Library/pull/33


Add changelog for the new, not-yet-released version

@tokou fyi: the changelog test if failing

@tokou Ah, it's failing because I retroactively changed the changelog for v1.38.1. So it's all fine.

I don't like that changelog must now be written in a quite rigid way, to make sure it displays correctly in the CLI.
I believe a link to the latest version should suffice.

I don't like that changelog must now be written in a quite rigid way, to make sure it displays correctly in the CLI.

@bartekpacia I back tested it with a lot of the older versions and it still shows something decent
Basically, it takes only the first level bullet points and ignores anything else, and changelog will always have those (and they're the most meaningful info)

Yeah, I thought about this more and I agree with you.


Remove SGID.WATER.Floodplains from SGID

Summary

Internal Dataset Name: SGID.WATER.Floodplains
External Dataset Name: opensgid.water.floodplains
ArcGIS Online Url: https://utah.maps.arcgis.com/home/item.html?id=fc6745b0508a4b1aa0a39084511bf100

The UDEM Risk MAP Program Manager has requested we remove the layer from the SGID as updates are pushed out by FEMA irregularly and they would like us to point people straight to the authoritative steward's resources.
Migration Guide
A short summary of how users affected by this deprecation can modify their workflows and projects to continue to get similar or improved functionality
There are services and downloads available from the federal steward FEMA that will always be the most current.
https://hazards.fema.gov/gis/nfhl/rest/services/public/NFHL/MapServer
https://hazards.fema.gov/femaportal/NFHL/searchResulthttps:/hazards.fema.gov/femaportal/NFHL/searchRes11ult
Action items

Assign a person who should complete the task by replacing name with their github @name.
Check [x] the box when the task is completed and add the date of completion.
~Strike~ out all items that do not apply.

Soft Delete
The purpose of the soft delete is to ensure that all of our users and applications have gracefully migrated off of the dataset. Soft deletes will remain in effect for 14 days. During this time, we will have the ability to restore the dataset to its original SGID offering(s). After these 14 days, the item is then ready for a hard delete.
Note: If this dataset is being replaced, then wait until the new data is publicly available before completing these steps:

[x] Append "(Mature Support)" to the end of the item title in the SGID.META.AGOLItems table (@rkelson, completed: 2023/03/23)
[x] Remove all tags other than "Deprecated" in the SDE metadata (@rkelson, completed: 2023/03/23)
[x] Add note to SDE description noting when layer will be deleted and any replacement layer (@rkelson, completed: 2023/03/27)
-~[x] Update the SGID Index row as deprecated by pasting the related Porter issue URL in the Deprecated field (@rkelson, completed: 2023/03/27)~
[x] Change Authoritative field to d in SGID.META.AGOLItems to automatically set the Deprecated AGOL flag. Allow the d to persist through one run of Auditor - currently, Auditor runs daily at 5:00am (@rkelson, completed: 2023/03/27)

After at least one successful run of Auditor:

[x] Remove the row from the SGID.META.AGOLItems table. This will trigger the removal of this item in Open SGID (@rkelson, completed: 2023/03/28)
[x] Unshare the item from its SGID group, which will remove it from Open Data (@jacobdadams, completed: 2023/03/28)

Hard Delete
Hard deletes are final. It is recommended to complete the soft delete process before moving on to these steps. If you decide to skip the soft delete, note that you will need to incorporate some of those steps here.

[x] Manually remove data from the Internal SGID (@rkelson, completed: 2023/04/18)

Deprecated database layers can be backup up on Google Drive > AGRC Share > Team Projects > SGID > [deprecated layers]

[ ] Remove ArcGIS Online item: (@jacobdadams, completed: 2023/00/00)

Manually delete the AGOL item
-OR-
Unshare by changing the AGOL_ITEM_ID field in SGID.META.AGOLItems to something other than an Item ID and manaually changing the sharing settings (remove the item from all SGID groups, remove Public sharing),
-OR-
~Shelve the data by copying the row from SGID.META.AGOLItems to the AGOLItems_shelved table in AGOL and changing the AGOL_ITEM_ID field in SGID.META.AGOLItems to shelved or some other note.~
Deprecated AGOL items can be backup on Google Drive > AGRC Share > Team Projects > SGID > deprecated layers.

[ ] Remove Farm from AGOL connection (@jacobdadams, completed: 2023/00/00)
[x] Update relevant gis.utah.gov data pages (@rkelson, completed: 2023/03/23)
~[x] Add this porter url to the Deprecated field of the Stewardship record (@rkelson, completed: 2023/03/27)~
[x] Update SGID.META.AGOLItems table (@rkelson, completed: 2023/03/28)

~cut and paste row to AGOLItems_shelved table if shelving (see below)~
~set the AGOL_ITEM_ID field to hosted by <agency> for Farm from AGOL~
set the AGOL_ITEM_ID field to exclude from AGOL to not publish to ArcGIS Online

~[ ] Delete Google Drive data (name, completed: 2023/00/00)~
[ ] Remove row from SGID.META.ChangeDetection (@stdavis, completed: 2023/00/00)
[ ] Remove data from forklift hashing and receiving (@stdavis, completed: 2023/00/00)
[ ] Remove row from data/hashed/changedetection.gdb/TableHashes (@stdavis, completed: 2023/00/00)

:robot: Automation validation

Assign yourself or someone to check the item by replacing name with their github @name.
Check [x] the box and add the date of verification 2020/01/01 when the task is verified.
~Strike~ out all items that do not apply.

[x] Remove data from Open SGID (@steveoh on 2023/04/03)
[x] sgid-index (@steveoh on 2023/04/10)
[ ] Auditor sets appropriate shelved/static/Deprecated information (@jacobdadams on 2023/00/00)

Are there service dependencies

[ ] Are clients querying this data with the WebAPI?
[x] Notify Josh Nielson (josh.nielson at motorolasolutions.com) if the data is in the Next-Generation 911 Motorola Aware Map? (@eneemann on 2023/00/00)
[x] Does any other application depend on this data?

Notification

[x] Twitter (@steveoh)

Group Task Assignments

Check [x] the box when you have assigned all the tasks relevant to your group.

[x] Data Team (@gregbunce)
[x] Dev Team (@steveoh)
[x] Cadastre Team (@rkelson)

The sgid index appears to have the wrong endpoint url. It looks to still be going to our open data. I would expect it to go to fema's arcgis server

This would be the stewardship tasks. The sgid index task is a validation and what I did above.

conductor results for tasks - 229

check
status

@rkelson has completed 7 out of 10 tasks
:no_entry:

@jacobdadams has completed 1 out of 4 tasks
:no_entry:

@stdavis has completed 0 out of 2 tasks
:no_entry:

@steveoh has completed 3 out of 4 tasks
:no_entry:

eneemann has completed 1 out of 1 tasks
:+1:

gregbunce has completed 1 out of 1 tasks
:+1:

conductor results for WATER.Floodplains

check
status

internal sgid
:no_entry:

meta table
:+1:

stewardship

- deprecation issue link
:no_entry:

conductor results for tasks - 229

check
status

rkelson has completed 9 out of 9 tasks
:+1:

@jacobdadams has completed 1 out of 4 tasks
:no_entry:

@stdavis has completed 0 out of 3 tasks
:no_entry:

steveoh has completed 4 out of 4 tasks
:+1:

eneemann has completed 1 out of 1 tasks
:+1:

gregbunce has completed 1 out of 1 tasks
:+1:

conductor results for WATER.Floodplains

check
status

internal sgid
:+1:

meta table
:+1:

stewardship

- deprecation issue link
:no_entry:

conductor results for WATER.Floodplains

check
status

internal sgid
:+1:

meta table
:+1:

stewardship

- deprecation issue link
:no_entry:


[WIP] test: setup cypress for e2e testing

ntar sekalian aku setup CInya

will squash this mess later, dw about it


document how projects move their repos to group ownership

I've been quite involved in the sous-chefs org, so I know the benefit of community orgs. I'd like to move over

https://github.com/josephholsten/base16-mutt
https://github.com/josephholsten/obsidian-base16 (which needs a complete rework)

It would be useful to know:

what state may a project be in before being adopted
what obligations should then maintainer agree to before moving over the repo
any other concerns

Example: https://github.com/sous-chefs/meta/blob/main/docs/transfering-a-cookbook.md

This is something we've had in mind for a whole but haven't made an official decision.
It's also tracked in https://github.com/tinted-theming/home/issues/1, so maybe it would make sense to move this to a comment over there instead.

Thanks for raising these - I'm closing this in favor of #84, where we're collecting all remaining project management related questions.


Feature Request: Add Real Time Price Feed To Maker Market

When you buy Maker you know you are getting the market price because Maker is only sold on Maker Market. But because the other tokens are sold on centralized exchanges, and because the centralized exchanges still have all the liquidity, you don't know if you are getting the market price when you are buying them on Maker Market. Obviously the solution is to open Kraken or Poloniex, or some other exchange, to find the current price. However, the user experience would be better, if there was a live price feed from kraken or polo showing the current prices on Maker Market.

We are currently not thinking about to show price-feeds from centralised exchanges.


css not working properly (UnoCSS/Storyblok)

UnoCSS version
^0.60.0
Describe the bug
I get css value from input field of storyblok but it's not working properly. When I comment out the CSS code, it works fine, but when I remove the comment, it doesn't work.
Thank you in advanced.
Reproduction
Storyblok:

Working:

Not working:

Repo:
https://stackblitz.com/edit/nuxt-3-quickstart-demo-q2gaf3?file=storyblok%2FHero%2FHome.vue
System Info
"nuxt": "^3.11.2",
"@unocss/eslint-config": "^0.60.0",
"@unocss/nuxt": "^0.60.0",
"@storyblok/nuxt": "^6.0.10"
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Because my-16 is not in the template, it seems to be added by storyblok


Hungarian (UTF16) language

Love this app, it helped much with my f21 pro.
I couldn't find a way to add Hungarian dictionary with ö,ő,ó,í,ü,ű,ú.
Please help me with adding the language, or helping me to do so
Thanks!

I believe Hungarian fits completely in UTF-8, while UTF-16 is for East Asian languages, so I am not sure why you mentioned it.
Either way, adding it is certainly possible. I'll try to release it in one of the upcoming versions.

Hi! I might be wrong, but Í, Ű, Ő are UTF16. If You plan to add Hungarian, I can provide dictionaries.

I might be wrong, but Í, Ű, Ő are UTF16

They fit in UTF-8, too. Don't worry about it.

If You plan to add Hungarian, I can provide dictionaries.

That would be great. I am going to use the Android OSP dictionary as a base, but I can see it contains only 66000 words. Knowing that Hungarian has a lot of grammatical cases, 66k is definitely not enough for providing good predictions.


GPT-AZURE: Internal Error

Hello,
Thank you for the great tool!
I checked it out with the gpt-openai mode and it worked well for me.
I then wanted to use it with gpt-azure and kept getting "ERROR: Internal Error" for anything I submit.
I checked this with Mac Ventura 13.5.1 Docker and colima, with GCP docker, with amd and arm processors, and with full and slim images. I also checked building the images locally. The creds were verified with a simple curl/python to be working fine and getting a response.
Is this a known issue under work?
Thanks in advance

Yeah, the same. Do you use azure gpt-35-turbo model? It seems there is an issue with 0630 preview api version associated with function calling feature.

I checked for both this and gpt-4. Both gave the same issue. My model versions in Azure are 0613.

I checked for both this and gpt-4. Both gave the same issue. My model versions in Azure are 0613.

Mine is 0613 too, sorry for the typo. I don't have gpt-4 access yet, since you tried gpt-4, the issue is not related to the function calling feature then.

Hi, thank you very much for the reported issue. I unfortunately don't have access to function calling on Azure, so I couldn't try it out and just had ro rely on their documentation. Since you have access to the 0613 models, you should have however, so that's very helpful.
Do you see further infos in the console? The container should output the error which caused the internal error.
If not, since you said, you also built the container yourself, would you consider changing the code and doing so again? Specifially, in https://github.com/silvanmelchior/IncognitoPilot/blob/main/services/main_llm.py#L50, could you remove the 5-lines if-else and just write error = str(e) instead? Then in the UI you should get more information of what is going on (which per default is hidden for security reasons, except if the underlying model chooses to show an error to the user with LLMException)

I just found out that I just need to move my subscription, then I also have access to the 0613 models. So I can debug it myself as well, once I find the time

Should be fixed in 2.0.2 (release on the way)

Thanks for making the changes!
I built the merged code with Colima (I needed to make a change and add a slash to the Dockerfile ->"COPY docker/start* ./ ").
Then the first message and answer worked but when asking it to write a file it hung.
.
Then reset the session and tried again. I then got the error:
"Error: The server had an error while processing your request. Sorry about that! You can retry your request, or contact us through an Azure support request at: https://go.microsoft.com/fwlink/?linkid=2213926 if the error persists. (Please include the request ID 68d03f53-d51f-4f58-8947-f6959e69126d in your message.) { "error": { "message": "The server had an error while processing your request. Sorry about that! You can retry your request, or contact us through an Azure support request at: https://go.microsoft.com/fwlink/?linkid=2213926 if the error persists. (Please include the request ID 68d03f53-d51f-4f58-8947-f6959e69126d in your message.)", "type": "server_error", "param": null, "code": null } } 500 {'error': {'message': 'The server had an error while processing your request. Sorry about that! You can retry your request, or contact us through an Azure support request at: https://go.microsoft.com/fwlink/?linkid=2213926 if the error persists. (Please include the request ID 68d03f53-d51f-4f58-8947-f6959e69126d in your message.)', 'type': 'server_error', 'param': None, 'code': None}} {'Content-Length': '412', 'Content-Type': 'application/json', 'access-control-allow-origin': '*', 'apim-request-id': '90264018-b837-44a6-8559-cd4619642cde', 'x-content-type-options': 'nosniff', 'openai-processing-ms': '30022.9978', 'x-ms-region': 'East US 2', 'x-request-id': '68d03f53-d51f-4f58-8947-f6959e69126d', 'ms-azureml-model-error-reason': 'model_error', 'ms-azureml-model-error-statuscode': '500', 'x-ms-client-request-id': '90264018-b837-44a6-8559-cd4619642cde', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains; preload', 'Date': 'Wed, 23 Aug 2023 15:30:02 GMT'}"
If I tried a few times to discuss with it prior to asking for a file write up it worked.
Docker logs:
docker logs 45245d2e6a74
INFO:     Started server process [15]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8080 (Press CTRL+C to quit)
INFO:     Started server process [11]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8081 (Press CTRL+C to quit)
INFO:     ('<IP_ADDRESS>', 56820) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection open
INFO:     connection closed
INFO:     ('<IP_ADDRESS>', 40578) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection open
INFO:     connection closed
INFO:     ('<IP_ADDRESS>', 51036) - "WebSocket /api/interpreter/run" [accepted]
INFO:     connection open
INFO:     ('<IP_ADDRESS>', 39872) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection open
2023/08/23 15:23:37 [error] 14#14: *20 upstream timed out (110: Connection timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET /api/llm/chat HTTP/1.1", upstream: "http://<IP_ADDRESS>:8081/api/llm/chat", host: "localhost:3040"
2023/08/23 15:24:37 [error] 14#14: *20 upstream timed out (110: Connection timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET /api/llm/chat HTTP/1.1", upstream: "http://<IP_ADDRESS>:8081/api/llm/chat", host: "localhost:3040"
INFO:     connection closed
INFO:     ('<IP_ADDRESS>', 37682) - "WebSocket /api/llm/chat" [accepted]
INFO:     ('<IP_ADDRESS>', 56820) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection closed
INFO:     connection closed
INFO:     ('<IP_ADDRESS>', 49324) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection open
INFO:     connection closed
INFO:     ('<IP_ADDRESS>', 42766) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection open
INFO:     connection closed
INFO:     ('<IP_ADDRESS>', 46684) - "WebSocket /api/llm/chat" [accepted]
INFO:     connection open
INFO:     connection closed

It might have been an API long latency - like reaching the max number of requests per minute. Later runs worked ok.
Thanks!

@silvanmelchior great work,mine's working well now. Thank you! btw, would you mind adding a history chat feature? Since there might be multiple projects ruuning at the same time.

I asked for the same :)
I added my ask to the history feature that is the list from @silvanmelchior .

Yes, please see issue #10.
At the moment, it's not highest priority however, I want to invest in improving the current state first (e.g. in terms of security, like #14), before adding new features.


Styles not applying when installing 'leaflet-fullscreen' as a package

When I'm adding the plugin using yarn the script works but the styles aren't applied. When loading via CDN or dropping the files directly in my app all is good.
Other leaflet plugins such as leaflet-draw work ok.

Hi @gitjul. The CSS is provided here. You'll need to consult the documentation for the tools you're using (e.g. webpack) to determine how to include that in your application.

@jfirebaugh Hi! I noticed that file and I was expecting it to be loaded. But now I noticed that it wasn't set up in my project and all the leaflet styles are actually linked (from a cdn) in a separate file. I'll look into setting up css loading using webpack. So thanks!
Btw, what do you mean by "these two rules" in the part below?
/* Do not combine these two rules; IE will break. */
.leaflet-container:-webkit-full-screen {
  width:100%!important;
  height:100%!important;
  }
.leaflet-container.leaflet-fullscreen-on {
  width:100%!important;
  height:100%!important;
  }

Also, sorry but where is the .svg file used? I don't see any relevant rule in the styles, was this an improvement you were planning?

Btw, what do you mean by "these two rules" in the part below?

It refers to the .leaflet-container:-webkit-full-screen and .leaflet-container.leaflet-fullscreen-on rules. They can't be combined as .leaflet-container:-webkit-full-screen, .leaflet-container.leaflet-fullscreen-on.
I believe the svg file is the original source for the png. It's included in case somebody wants to modify the icons in the future, but not used at runtime.


Added a feature to switch API service providers, enabling users to ea…

…sily toggle between providers as needed.
Added a feature to switch API service providers to the project. Introduced an input field for API providers in the settings interface and included the OPENAI_URL parameter in the config file.

Hi, if someone switches the OpenAI API URL to something else like vLLM or any other service that follows OpenAI's API format, he won't be able to select the right model because they're fitted in for OpenAI use case, I am working on adding support for custom openai endpoints that would allow them to choose custom OpenAI models.

Actually, what I mean is some other intermediary OpenAI API service providers. Apart from the service address, the models and interfaces they offer are exactly the same as those provided by OpenAI. At least, this is very useful for me because I am Chinese. Of course, your decision to close the merger must have your own considerations. Thank you for your response.


Add ISM and Alerting

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
Add ISM and Alerting
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2973 (9e8937d) into main (f3c1c4d) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
- Coverage   93.17%   92.87%   -0.31%
==========================================
  Files         167      167
  Lines        4602     4602
==========================================
- Hits         4288     4274      -14
- Misses        314      328      +14

Impacted Files
Coverage Δ

src/system/temporary_directory.py
64.44% <0.00%> (-28.89%)
:arrow_down:

src/system/os.py
94.73% <0.00%> (-5.27%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat(#50): Improvements of diagnostics during schema configuration

Codecov Report

Merging #53 (1083384) into develop (e864e05) will decrease coverage by 4.23%.
The diff coverage is 62.66%.

@@             Coverage Diff             @@
##           develop      #53      +/-   ##
===========================================
- Coverage    83.05%   78.81%   -4.24%
===========================================
  Files          247      260      +13
  Lines        15231    18553    +3322
  Branches      1139     1199      +60
===========================================
+ Hits         12650    14623    +1973
- Misses        2322     3660    +1338
- Partials       259      270      +11

Impacted Files
Coverage Δ

.../Fields/ExpressionFields/FieldContextExpression.cs
83.87% <0.00%> (-3.23%)
:arrow_down:

src/Epam.GraphQL/Loaders/EpamGraphQLExtensions.cs
12.50% <ø> (ø)

...Loader/Implementations/InlineObjectFieldBuilder.cs
6.46% <4.59%> (-4.12%)
:arrow_down:

...ns/Fields/ChildFields/ConnectionLoaderFieldBase.cs
86.95% <14.28%> (-13.05%)
:arrow_down:

src/Epam.GraphQL/Diagnostics/GenericPrinter.cs
14.28% <14.28%> (ø)

src/Epam.GraphQL/Diagnostics/ArrayPrinter.cs
15.38% <15.38%> (ø)

...lders/Loader/Implementations/LoaderFieldBuilder.cs
28.87% <29.03%> (+1.18%)
:arrow_up:

...mentations/Fields/ChildFields/InlineLoaderField.cs
30.55% <33.33%> (+0.25%)
:arrow_up:

...Epam.GraphQL/Diagnostics/ConfigurationException.cs
33.33% <33.33%> (ø)

...ementations/Descriptors/NullGraphTypeDescriptor.cs
40.00% <40.00%> (ø)

... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e864e05...1083384. Read the comment docs.


Fix for Python 4

What does this implement/fix?

We don't yet know if 3.10 or 4.0 will follow Python 3.9, but whichever it is, it will probably happen in 2020 when Python 3.9 reaches beta.
There's some code which checks the Python major version is exactly 3, similar to this:
if sys.version_info[0] == 3:
    # Python 3+ code
else:
    # Python 2 code

When run on Python 4, it will run the Python 2 code! Instead:
if sys.version_info[0] == 2:
    # Python 2 code
else:
    # Python 3+ code

This PR re-adds PY2 from upstream six.py, and uses that instead of PY3.
Additional information
Found using https://github.com/asottile/flake8-2020:
$ pip install -U flake8-2020
...
$ flake8 --select YTT
./tools/authors.py:29:4: YTT202: `six.PY3` referenced (python4), use `not six.PY2`
./scipy/_lib/six.py:31:7: YTT201: `sys.version_info[0] == 3` referenced (python4), use `>=`

Alternatively, as Python 3.5 is the minimum supported version, how about removing this Python 2 compatibility code?

My vote goes for removing all py2 related stufd for what it's worth.

Are we still bug fixing Python2 from master? If not, then we could remove all those Python 2 antiquities, from __future__ I'm looking at you.

https://docs.scipy.org/doc/scipy/reference/release.1.2.0.html says:

This will be the last SciPy release to support Python 2.7. Consequently, the 1.2.x series will be a long term support (LTS) release; we will backport bug fixes until 1 Jan 2020.

So I guess https://github.com/scipy/scipy/tree/maintenance/1.2.x is the LTS branch and master can be cleaned up?

Sounds sensible, thanks.
I found a couple of other little tweaks to add to this PR, will update it tomorrow.

Done.
The following is False for 4.0-4.4:
if sys.version_info.major >= 3 and sys.version_info.minor >= 5:

Fix:
if sys.version_info >= (3, 5):

Merged, thanks @hugovk


BUG: Array to String conversion when using Requirements::combine_files with path/type arguments

When using Requirements with files whose type needs to be specified manually (eg, their extension is not 'js' or 'css'), the combine_files duplicate check throws a notice because array_intersect casts the array values to string.
Requirements::combine_files('out.min.js', array(
    array('path' => 'themes/mytheme/js/library.js.inc', 'type' => 'js')
);

The example is arbitrary; going by the above I could just rename the file, but in my real-world case I'm dealing with scripts in other languages which are compiled on load. These scripts have suffixes which shouldn't be changed.
// Requirements_Backend::combine_files
public function combine_files($combinedFileName, $files, $media = null) {
    // duplicate check
    foreach($this->combine_files as $_combinedFileName => $_files) {
        $duplicates = array_intersect($_files, $files); // -- HERE --
        if($duplicates && $combinedFileName != $_combinedFileName) {
            user_error("Requirements_Backend::combine_files(): Already included files " . implode(',', $duplicates)
                . " in combined file '{$_combinedFileName}'", E_USER_NOTICE);
            return false;
        }
    }
    ...
}

As array_intersect casts to string, it's casting the input array (and potentially any of these arrays that wind up in combine_files in future checks), causing the warning to be thrown and the comparison fail.

The parseCombinedFile() method addresses this issue.


A BUG of computing F1

Thanks for the code. But I think there are some bugs when computing F1. In your code, the predicted list, take argument extraction for example, is  [(type1, role1, argument1), ...].  However, it does not consider instance_id and different instances may share the same  (type1, role1, argument1), which causes more true predictions. This bug will make the final evaluation metrics higher than normal. Or maybe I misunderstand your code. Wish for your reply.

Hi, Thanks for your attention.
The evaluation code counts true predictions instance by instance, so it is no need to consider instance_id .

I got it. Thank you!


ENH: add input validations and its tests for FITPACK in fitpack2.py

Reference issue
To fix #11581
What does this implement/fix?
fix docstring of RectSphereBivariateSpline and add input validation and its tests.
Because, error message of dfitpack is not useful when an invalid input was entered.

@rgommers Could you help me to review this PR if you have time?

@rgommers Hi. Thank you for your review. I added invalid input check for all functions in fitpack2.py. I think it is ready to review. PTAL.

LGTM now, and the one remaining CI failure is a timeout on ppcle64. So merging. Thanks @AtsushiSakai!

@rgommers Thank you for merging. I'm sorry I didn't answer your question. I'll leave a comment for later reference.

For consistency, I can change the half interval of RectSphereBivariteSpline to closed one. What do you think?

I'm sorry this is wrong, I couldn't change the half interval of RectSphereBivariteSpline to closed one, because FITPACK throw an error for it.  So, I think we have to keep this inconsistency.

I'm sorry this is wrong, I couldn't change the half interval of RectSphereBivariteSpline to closed one, because FITPACK throw an error for it. So, I think we have to keep this inconsistency.

That's not too bad, I think we're fine here. Thanks for pointing this out though!

At the risk of beating a dead horse...
The docstring of RectSphereBivariateSpline still specifies colatitudes u in the closed interval [0, pi] and this is also checked in the code.
The function RectSphereBivariateSpline however should only take colatitutes in the open interval (0, pi) as the underlying Fortran code will fail when the singularities at 0 or pi are included:
spgrid.f: 379:    if(u(1).le.0. .or. u(mu).ge.pi) go to 200.

At the risk of beating a dead horse...
The docstring of RectSphereBivariateSpline still specifies colatitudes u in the closed interval [0, pi] and this is also checked in the code.
The function RectSphereBivariateSpline however should only take colatitutes in the open interval (0, pi) as the underlying Fortran code will fail when the singularities at 0 or pi are included:
spgrid.f: 379:    if(u(1).le.0. .or. u(mu).ge.pi) go to 200.

That does seem to be the case indeed: http://scipy.github.io/devdocs/generated/scipy.interpolate.RectSphereBivariateSpline.html#scipy.interpolate.RectSphereBivariateSpline
@AtsushiSakai would you be able to take another look?

That does seem to be the case indeed: http://scipy.github.io/devdocs/generated/scipy.interpolate.RectSphereBivariateSpline.html#scipy.interpolate.RectSphereBivariateSpline
@AtsushiSakai would you be able to take another look?

@Muthsera Hi. Thank you for your comment. Actually, I don't remember well that I thought the u range needs to be closed. And it seems that the unit-tests does not test boundary conditions. It is not good. It was my fault.
I will try to check these boundary inputs to all functions again. Please give me time.

@Muthsera Hi. Thank you for your comment. Actually, I don't remember well that I thought the u range needs to be closed. And it seems that the unit-tests does not test boundary conditions. It is not good. It was my fault.
I will try to check these boundary inputs to all functions again. Please give me time.

@AtsushiSakai Yeah, it looks like it happened in an editing frenzy together with a lot of other similar changes, where the closed interval is indeed correct (at least according to the corresponding checks in the Fortran code).
If you are too busy in the near future and don't mind, I can also give it a try and create a new pull request.

@AtsushiSakai Yeah, it looks like it happened in an editing frenzy together with a lot of other similar changes, where the closed interval is indeed correct (at least according to the corresponding checks in the Fortran code).
If you are too busy in the near future and don't mind, I can also give it a try and create a new pull request.

I can also give it a try and create a new pull request.
@Muthsera Thank you!!. Yes. Please do it. Maybe it would be better to create an issue to describe the problem. I will help to review it. I applicate your help.

I can also give it a try and create a new pull request.
@Muthsera Thank you!!. Yes. Please do it. Maybe it would be better to create an issue to describe the problem. I will help to review it. I applicate your help.


fix edge pool

make num_nodes explicit for the edge score method. otherwise, it infers the wrong num_nodes when there are singletons.

Thank you!


bundle install doesn't install runtime dependencies from gemspec on JRuby

...And here is why. The story begins innocently in dsl.rb, line 63:
        gem spec.name, :path => path, :glob => glob, :platforms => Bundler::Dependency::REVERSE_PLATFORM_MAP[spec.platform]

Fair enough. We want to install all the runtime dependencies for the gem defined in the gemspec. Rather than adding them all explicitly, we just add a dependency on the gem itself. BUT! Look at the last part of that line...
:platforms => Bundler::Dependency::REVERSE_PLATFORM_MAP[spec.platform]

What will that return if the gem author didn't specify a platform in the gemspec? To answer that, we need to take a detour into Rubygems itself. specification.rb, lines 125-142:
@@default_value = {
    :authors                   => [],
    :autorequire               => nil,
    :bindir                    => 'bin',
    :cert_chain                => [],
    :date                      => TODAY,
    :dependencies              => [],
    :description               => nil,
    :email                     => nil,
    :executables               => [],
    :extensions                => [],
    :extra_rdoc_files          => [],
    :files                     => [],
    :homepage                  => nil,
    :licenses                  => [],
    :metadata                  => {},
    :name                      => nil,
    :platform                  => Gem::Platform::RUBY,

So specifying no platform at all is the same as spec.platform = 'ruby'. And Bundler::Dependency::REVERSE_PLATFORM_MAP['ruby'] is...
[:ruby, :ruby_18, :ruby_19, :ruby_20, :ruby_21, :ruby_22, :ruby_23, :mri, :mri_18, :mri_19, :mri_20, :mri_21, :mri_22, :mri_23, :rbx]

So as far as Bundler is concerned, putting no platform at all in the gemspec is the same as saying "this is only for MRI and RBX"!
I can see three ways to solve this:

Amend CurrentRuby as follows:

  def ruby?
    true
  end

The logic behind this is that saying a gem's platform is "ruby" simply means "this is a pure-Ruby gem, it doesn't have any platform dependencies". So that means the gem should be good on ALL Rubies. Right? Wrong? Maybe?

Special-case 'ruby' in REVERSE_PLATFORM_MAP.

Special-case platform 'ruby' in Dsl#gemspec, so it doesn't add the :platforms => ... option at all when spec.platform is 'ruby'.

Comments please!

I'm not familiar with Bundler code, so I'll skip commenting on the fix you propose. I do want to upvote this issue as it breaks any travis jruby build for pure ruby gems that do not specify a platform by definition. Could you at least please revoke the released gem until this is fixed? All my travis builds are failing right now because of this, unless I start adding the runtime gems to the Gemfile for each gem.

We don't yank gems. In the meantime, you're more than welcome to use 1.10.6. We had over two weeks of prereleases where nobody reported any issues, so be patient as we work to fix this in our spare time.

@segiddins, I'm happy to write and test the fix, but I'd like to hear what you think of the proposed 3 possible approaches above.

We've actually backed out this change on stable already and @indirect is working on a fix as we speak!

@segiddins @indirect thanks for getting on this so quickly! it's awesome that jruby users can rely on bundler to work. this is the first problem I've had in a very long time <3 <3

@segiddins don't get me wrong. I do appreciate the hard work you put into this marvelous gem and I have been relying on it for quite a few years now without a problem. As for using the older version, I'm not sure if we have that option on Travis and I think they skipped the pre-release versions because the problem appeared only a couple of days ago.
To be honest I did panic a bit as I did not have a workaround immediately and failing a build because of bundler obfuscates any issues with the build itself defying the purpose of it all. Since I added the platform line to my gemspecs, I'm as happy as I've ever been ;)
Keep up the good work and thanks for looking at this.

@alexdowad @Kris-LIBIS @jkutner sorry! This was my bad, attempting to fix #4102. I think this will be fixed with my changes in #4166, and I just added a spec to that branch to cover this case as well.


update sofa-common-tools to 1.0.18

Your question
describe your question clearly
Your scenes
describe your use scenes (why need this feature)
Your advice
describe the advice or solution you'd like
Environment

SOFARPC version:
JVM version (e.g. java -version):
OS version (e.g. uname -a):
Maven version:
IDE version:

https://github.com/alipay/sofa-rpc/pull/567


[AVW-2908] Transaction Review Header

Jira ticket: ABW-2908
Description
Show the title in the navigation bar in Transaction Review, when scrolling away the other title.
Notes
We could do the same thing in other places too, like the home screen, it's fairly painless.
How to test

Go to transaction view and scroll down far enough for the main title to disappear.

Video
https://github.com/radixdlt/babylon-wallet-ios/assets/123396602/0bad2d48-0b58-46c7-8386-ddc78e864e75
PR submission checklist

[x] I have tested account to account transfer flow and have confirmed that it works

How does it look for incoming transactions from a dApp? it should be like this

Well it doesn't look like that, I am just using the navigationTitle property. Will try to use a toolbar item instead

Now it looks like that...


Sending Data with send() Method Always Results in 0 Value

When attempting to send data using the send() method from the library, the sent value is always 0, regardless of the input.

@sagumudradi I think I have the same issue, what did you do to fix this?


Consuming input events

This isn't really an issue, more of a question... I was wondering, it is possible to check if any GUI elements from egui consumed an input event? Basically, I want to avoid getting input events in my own entities if the user e.g. clicked on a gui element, so I don't get the mouse events twice. (e.g. in a FPS game if you click the "pause" button, it shouldn't shoot the gun, because the GUI should've already consumed the input event)

Perhaps wants_pointer_input is what you want?

Perhaps wants_pointer_input is what you want?

That did the trick, thanks!


[Update] Use tooltips for more information

Add additional tooltips for some fields to be informative

The Vaadin tooltips have big delay on hovering component


Map out CIF authorization

Describe the task
We need to clearly identify and document who can have access and to what within the CIF app (e.g., operators, consultants, etc).
Acceptance Criteria

[ ] Consolidate existing documents to map this out
[ ] Create an excel sheet with assumptions
[ ] Validate with CIF Ops team
[ ] Validate with CIF Tech team
[ ] Reiterate the document

Additional context

February 2, 2022: DL highlights that to do authorization and authentication correctly, it will take time.

Decision needs to be made about authentication/authorization via BCeID: do we enforce Business bceid? Do we allow basic? Do we give people access to all applications within their organisation?

Does CIF auth need its own epic so we can scope things down into smaller tickets?

Probably, we'll have multiple tickets related to external users permissions

@dleard @pbastia the AC for this ticket is more research based, would either of you want to change it so it reflects some first steps for authorization from dev-end of things?

It would be a better approach to create a user story map first, and then identify user roles/access accordingly. Blocking this ticket and added a ticket (#1540) to do the user story mapping work first.

AC for this card need to be a bit more refined

Low priority for now according to @suhafa during backlog refinement Apr 25. This is solely a design ticket.


#[derive(Debug)] for ConfigRecord and potentially other types

Also deriving PartialEq / Eq for ConfigRecord at least could be useful.

Fixed in bd9eabf


DBZ-1498 Support for precise interval value

https://issues.jboss.org/browse/DBZ-1498
Depends on https://github.com/debezium/postgres-decoderbufs/pull/21

@gunnarmorling

P is the duration designator (referred to as "period"), and is always placed at the beginning of the duration.

P is the duration designator (referred to as "period")

Aaah, of course. Thanks, I really was wondering what it stands for :)

Applied; thanks a lot, @jpechane. I suppose the next CI run may fail until the container image has been re-built.


trim css

currently we are importing the entire materialize CSS library
perhaps we should be using http://www.getmdl.io/started/index.html instead
anyhow we should trim to only the rules we actually use!

fixed in redux version


Potential performance gain

Right now, extensions, shebangs, etc. are assigned to languages, so that the internals roughly mirror the languages file. However, instead of a structure like this:
JSON => ["json"]
JSON with Comments => ["json", "jsonc"]

there might be potential for much better performance with a structure like this:
"json" => [JSON, JSON with Comments]

In other words, make the matcher a key to the language, not the other way around.
Filename patterns will need to be a special case, and continue to be iterated over, but the performance hit shouldn't be too bad since interpreters, extensions, and filenames should be much more commonly used.

In my profile run, when using git as source, only about 23% of the runtime are going into the matcher it seems. 87ms, a considerable fraction, is used to deal with utf8 conversions. If BStr could be used, and with it, [u8], this conversion can possibly be skipped. With gix this is now easy enough if one would stop using Path and rely on BStr (along with / as separator).

This has been effectively addressed by #298


Text Clipping

In some instances on place selection the address is clipped.  Seems to only happen to the numbers in the address.  Any idea where this is coming from? See below for a before and after click/selection event.

i think, before you click something, predictions object get terms of address. final address is formatted address, it's different from prediction address. so if you want manipulate some address for view input box, i think you change formatted address and find data in prediction object.

 It's a common problem with the formatted address of place details not matching the prediction text. If anyone has a suggestion about how to better match the prediction to the address then I'd love to hear it.

I addressed this by mapping "viewValue" in the "format" function to modelValue.name instead of modelValue.formatted_address.

+1
@ankitg06 thanks for the comment - can you reference where in the code you made this update?

Here's the block:
              function format(modelValue) {
                    var viewValue = "";

                    if (isString(modelValue)) {
                        viewValue = modelValue;
                    } else if (isObject(modelValue)) {
                        viewValue = attrs.nameAsViewResult ? modelValue.name : modelValue.formatted_address; // AG: Fix for predictions text not matching result text
                    }

                    return viewValue;
                }


Don't add purge as remote when upgrading

Summary:

I tested without adding any remotes when upgrading, and it seems to be working fine, nothing I saw was affected.
It is based on #242, and it addresses #244.
Test Plan:

Try to upgrade a rn project.

Just tried this locally and looks like we don't need a remote for 3way merging, yay! (confirmed that it worked without a remote with --3way flag and failed without it to make sure falling back actually does something)
Can you rework this PR to only remove the remote, so without changes from #242?

I can rebase.

👍

Thank you!

I'll go fix the conflicts on the other PR.


[Laravel5] deleteSaved throws Illuminate\Container\BindingResolutionException

public  static function tearDownAfterClass()
{
static::$muffin->deleteSaved();
}
Fatal error: Uncaught exception 'Illuminate\Container\BindingResolutionException' with message 'Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable.' in /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 785
Illuminate\Container\BindingResolutionException: Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable. in /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 785
Call Stack:
1.6720   17856736   1. Illuminate\Foundation\Bootstrap\HandleExceptions->handleException() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:0
1.6720   17856784   2. Illuminate\Foundation\Bootstrap\HandleExceptions->getExceptionHandler() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:73
1.6720   17856832   3. Illuminate\Foundation\Application->make() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:151
1.6720   17856968   4. Illuminate\Container\Container->make() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:572
1.6721   17856968   5. Illuminate\Container\Container->build() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Container/Container.php:656
Fatal error: Uncaught exception 'Illuminate\Container\BindingResolutionException' with message 'Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable.' in /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 785
Illuminate\Container\BindingResolutionException: Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable. in /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 785
Call Stack:
1.6827   17881624   1. Illuminate\Foundation\Bootstrap\HandleExceptions->handleShutdown() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:0
1.6891   17915192   2. Illuminate\Foundation\Bootstrap\HandleExceptions->handleException() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:116
1.6891   17915192   3. Illuminate\Foundation\Bootstrap\HandleExceptions->getExceptionHandler() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:73
1.6891   17915240   4. Illuminate\Foundation\Application->make() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:151
1.6891   17915376   5. Illuminate\Container\Container->make() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:572
1.6891   17915376   6. Illuminate\Container\Container->build() /home/vagrant/projects/fry/vendor/laravel/framework/src/Illuminate/Container/Container.php:656
When I comment out the deleteSaved line, no error.

You need to catch the exception. :)

You can inspect the exceptions that were wrapped by it: https://github.com/thephpleague/factory-muffin/blob/master/src/Exceptions/DeletingFailedException.php#L80.

To see what went wrong.

Thank you Graham, I'll troubleshoot and report back in the morning.
On Wed, Feb 4, 2015 at 4:31 PM, Graham Campbell<EMAIL_ADDRESS>wrote:

To see what went wrong.
—
Reply to this email directly or view it on GitHub
https://github.com/thephpleague/factory-muffin/issues/383#issuecomment-72954460
.

Ok, so by placing the call in the static tearDownAfterClass function the IOC container couldn't resolve the configuration when the models were being deleted.  I don't know enough about how that all works to understand why, but moving the $muffin->deleteSaved() call into the tearDown method it worked.

Nice. If you have any other suggestions or questions, feel free to open another issue.
Also, sorry the 3.0 release is so delayed. I haven't had the time to write a proper upgrading guide from 2.1 -> 3.0 yet. As soon as that's done, I'll be cleaning up the usage docs, and releasing.

Just an FYI, it was an order of operations issue dealing with both Factory Muffin and Mockery when using the Laravel Testcase.  Any exceptions that are thrown after tearDown  in Illuminate\Foundation\Testing\TestCase is called (like a Mocking exception or a FM exception when deleting) result in a binding resolution error because the IOC container doesn't have an error handler bound to the error handling contract.   This completely obfuscates what is happening and makes it nearly impossible to troubleshoot, or in the case of a mocking exception, for the testcase to fail as it should.
Putting both Mockery::close() and $fm->deleteSaved()  before the parent::tearDown() in my testcases resolved this issue.
I'm writing this information here for posterity.

@bcdennis This might be useful to note in our docs. Is there any chance you could send a pull request to add it please?


show auth coins status for addresses of a wallet

Enable this feature only when account.chain_type == "goldchain"

For our desktop wallet app purposes we consider 2 cases of a wallet:

all addresses of a wallet are authorized (to be looked up using the feature that will be provided by #206): show a green "authorized label in the wallet card label (in accounts) as well as on the wallet page itself
one or more of a wallet's addresses are not yet authorized (show on the wallet page which wallets are authorized, and which are not, on top of that do not show any authorized label in the card or wallet page)

You can use the following account API functions:
// get status for all (singlesig) addresses of an acocunt,
// probably not so useful for your purposes
account.coin_auth_status_for_account_get

// probably much more useful for you,
// get the auth status for all addresses of that wallet,
// will return as a map: {'0132....': true, '01443...': false, ...}
account.coin_auth_status_for_wallet_get({name: 'foo'})

// get it for just a single address
// (NOTE: will only work for single sig addresses of this account)
account.coin_auth_status_for_address_get('01432....') // returns true or false

I do not see authorized or deauthorized stage on either account or wallet page...

I find the authorized state here, that's already a beginning. However there are some comments I made for it as well.
Please also add authorized state in the badge of a wallet (on account page) as well as on the wallet page itself.


Automatically discover and set the Gateway API version and channel during conformance suite runs

What would you like to be added:
As described in GEP-1709, the conformance report includes the Gateway API version and the Gateway API channel. These two parameters need to be automatically discovered by the suite, instead of being manually set by a user. To do so, the related paragraph of the GEP has to be implemented.
/area conformance

/assign


App Switcher Updates

Feature
App Switcher
App

[X] Admin
[X] Summon
[X] Hub
[ ] Toolbox

Expected Behavior

Core UI should be called "Admin" in the App Switcher drop-down
Items in drop-down should contain icons
Docs link should point to documentation
Drop-downs should be consistent across apps

Actual Behavior

Core UI is called "Core App" in the App Switcher drop-down
There are no icon in the drop-down
Docs link is pointing to Storybook
Admin drop-downs is different than Summon and Hub

Steps to Reproduce
No response
Browser
No response
Screenshots and Context
1

4
Summon

Hub

Admin

It can't atm

If we combine Hub and Admin we may want to remove App Switcher

Something to think about for sure. We will be adding workshop soon, if that helps.

@alexkeating did you make any progress on getting the items in drop-down to contain icons?

Closing as the feature will be removed in: https://github.com/HausDAO/daohaus-monorepo/issues/863


Write a real Visual Studio solution file parser

https://github.com/flutter/flutter/pull/51246 adds code that can modify a .sln file to add/remove plugin project references. That code is fairly ugly though; it does line-by-line regex parsing, with a small amount of manual state tracking to know where it is in the file when necessary.
If we keep that approach to Windows plugin handling, we should look into replacing that with an actual .sln parser that would let us build a structural representation, modify it in a clear declarative way, then write it out again. We'd need to be careful to make sure it would not corrupt/lose parts of the file we don't understand (e.g., we could potentially make it default to processing the contents of project/global sections by just storing each line, and only breaking those down into tokens for the specific sections whose contents we care about and know we can describe).

Hey! can you guide me how to get started with this issue?

This code no longer exists after the transition to CMake.


Neo4jClient - Query did not return the the values in view

I install neo4j and neo4jClient in my MVC Project 4.0. Install example movie database from the guide
:play movies
Establish the connection in Web.Config:
<appSettings>
<add key="ClientDBUrl" value="http://localhost:7474/db/data" />
<add key="ClientDBUser" value="neo4j" />
<add key="ClientDBPassword" value="password" />
</appSettings>

WebApiConfig.cs in App_Start Folder
public class WebApiConfig
{
    public static void Register(HttpConfiguration config)
    {
        config.MapHttpAttributeRoutes();

        config.Formatters.JsonFormatter.SerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();
        config.Formatters.JsonFormatter.SerializerSettings.NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore;

        var appXmlType = config.Formatters.XmlFormatter.SupportedMediaTypes.FirstOrDefault(t => t.MediaType == "application/xml");
        config.Formatters.XmlFormatter.SupportedMediaTypes.Remove(appXmlType);

        //Use an IoC container and register as a Singleton
        var url = ConfigurationManager.AppSettings["ClientDBUrl"];
        var user = ConfigurationManager.AppSettings["ClientDBUser"];
        var password = ConfigurationManager.AppSettings["ClientDBPassword"];
        var client = new GraphClient(new Uri(url), user, password);
        client.Connect();

        GraphClient = client;
    }

    public static IGraphClient GraphClient { get; private set; }
}

Created a Model
 public class Person
{
    public int Id { get; set; }
    public string Name { get; set; }
    public int Age { get; set; }
}

Then I write simple query in controller to exact the data in view
    public ActionResult Index()
    {
        var query = WebApiConfig.GraphClient.Cypher.Match("(p:Person)-[:ACTED_IN]->(m:Movie {title: 'Top Gun'})")
            .Return(p => p.As<Person>()).Results;

        return View(query.ToList());
    }

and in view
@model IEnumerable<Neo4j_TestProject1.Models.Person>

  @foreach (var item in Model) {

        @item.Name

}

But I get the error of "Object Reference Not Set to an Instance" in my query.
Help if anyone has an idea.

I've (hopefully) answered this on StackOverflow so I'll close this, and we'll keep the conversation going on there if needs be!

@cskardon  I have tried what you said but I still got the same error. when I try to debug and through quick watch I saw this error:
    WebApiConfig.GraphClient.Cypher.Match("(person:Person)")
   '((Neo4jClient.ICypherGraphClient)
    (Neo4j_TestApp.App_Start.WebApiConfig.GraphClient))' is null
    Type: Neo4jClient.Cypher.ICypherFluentQuery

Can you share your project with me?

@cskardon https://github.com/Ribzi/Neo4jClient here is the link to the project.

It looks like you never call WebApiConfig.Register?
Sent from my iPhone

On 8 Nov 2017, at 10:11 pm, Ribzi<EMAIL_ADDRESS>wrote:
@cskardon https://github.com/Ribzi/Neo4jClient here is the link to the project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

As @optiks said - you never call WebApiConfig.Register, so your graphclient is never instantiated.
So to get your project to work:

Add (via nuget) Microsoft.AspNet.WebApi.WebHost to your project.
In your global.asax.cs file add: GlobalConfiguration.Configure(WebApiConfig.Register);
Your PersonsController has an issue as you're returning Single() from the query, but your View is expecting an IEnumerable<Person> - so you need to change either the view to just be a Person - or remove the .Single() and just send the Results to the view.


base-images: Bumping node lang versions

Reference: https://github.com/balena-io/contracts/pull/146
Change-type: patch
Signed-off-by: Gareth Davies<EMAIL_ADDRESS>

@balena-ci retest


test

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that a supported site is broken
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Provide a description that is worded well enough to be understood
test
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
test

test


Unlock AWS provider v4. Require minimum 3.75.1.

Description
Bumps aws provider version and adds an upgrade test.

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)
Unlock AWS provider v4. Require minimum 3.75.1. This update includes a few tests that make sure upgrading to this module from the last release is easy. However, you may need to bump your AWS provider version. See the migration guide notes below for more.
Migration Guide
The AWS Provider v4 unlock is a functionally backward compatible update. Modules no longer have the AWS Provider v4 lock. Upgrade tests were run to give reasonable confidence that upgrading to this version of the modules from the last tagged release is backward compatible, requiring no further modifications from you. However, the AWS Provider version must be 3.75.1 or newer, so you may need to run terraform init with the -upgrade flag, which will allow terraform to pull the latest version of the AWS provider, as in terraform init -upgrade.

Upgrade test results for build 306
Modules upgraded from master => feature/awsv4
Terraform upgraded from latest:^1.0 => latest:^1.2
⚠ If resources added/changed, review the plan to ensure backward compatibility.

Example
Modules to upgrade
Plan
Upgraded?
Patched
Upgraded?

join-path
join-path
0, 0, 0
:white_check_mark:

Upgrade test results for build 311
Modules upgraded from master => feature/awsv4
Terraform upgraded from latest:^1.0 => latest:^1.2
⚠ If resources added/changed, review the plan to ensure backward compatibility.

Example
Modules to upgrade
Plan
Upgraded?
Patched
Upgraded?

join-path
join-path
0, 0, 0
:white_check_mark:

Upgrade test results for build 315
Modules upgraded from master => feature/awsv4
Terraform upgraded from latest:^1.0 => latest:^1.2
⚠ If resources added/changed, review the plan to ensure backward compatibility.

Example
Modules to upgrade
Plan
Upgraded?
Patched
Upgraded?

join-path
join-path
0, 0, 0
:white_check_mark:

Upgrade test results for build 321
Modules upgraded from master => feature/awsv4
Terraform upgraded from latest:^1.0 => latest:^1.2
⚠ If resources added/changed, review the plan to ensure backward compatibility.

Example
Modules to upgrade
Plan
Upgraded?
Patched
Upgraded?

join-path
join-path
0, 0, 0
:white_check_mark:

Upgrade test results for build 328
Modules upgraded from master => feature/awsv4
Terraform upgraded from latest:^1.0 => latest:^1.2
⚠ If resources added/changed, review the plan to ensure backward compatibility.

Example
Modules to upgrade
Plan
Upgraded?
Patched
Upgraded?

join-path
instance-typejoin-path
0, 0, 0
:white_check_mark:

instance-type
instance-typejoin-path
0, 0, 0
:white_check_mark:

Super duper thanks for the review!


Add environmental variable support

We provide a config utility in Ignite: https://github.com/infinitered/ignite/blob/master/boilerplate/app/config/config.prod.ts
This is useful. However, most project at some point need to support passing in environmental variables, such as through an .env file.
There are a lot of libraries that support this:

https://github.com/luggit/react-native-config
https://www.npmjs.com/package/react-native-dotenv
https://reactnative.dev/docs/security#storing-sensitive-info

It would be nice to have Ignite support this out of the box. It's a step that I feel needs to happen in most projects, but it's annoying to set up in my opinion.

@mazenchami just did this for Chain React App, perhaps we can have a team discussion on which method we use most often and implement that?

Cookbook recipe has been created!


has method

Hello,
What do you think about adding $pointer->has('/some/path')?

I'm all for it. Do you already have a patch to submit ? If not, I can implement it shortly. Meanwhile, since a get() on a non-existant value throws an exception, you can use that as a workaround.

I don't have a patch yet.  I probably won't have time to work on one today so I think you will get to it first.
I have been using the exception workaround but I would prefer to avoid the try catch block.

What do you think of this commit ?

Looks good. Thanks for the quick response!


feat: update contributing docs

Description:
Starting from a fresh pull, it can be difficult to get up and running. The changes I've proposed here represent findings from digging around the discord channel and a few closed issues.
The only controversial change here may be suggesting RUST_BACKTRACE=0. The contributing docs currently suggest using RUST_BACKTRACE=full, but with that configuration the following tests will fail:"
failures:
    fixture_tests__errors__lints__const_assign__1__input_js
    fixture_tests__errors__lints__duplicate_bindings__const_let__1__input_js
    fixture_tests__errors__lints__duplicate_bindings__import_import__input_js
    fixture_tests__errors__lints__duplicate_exports__1__input_js
    fixture_tests__errors__lints__duplicate_exports__2__input_js

BREAKING CHANGE:

Related issue (if exists):

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@RiESAEX , @kdy1 , @kwonoj  thanks for the feedback. I've updated based on your suggestions.


fix(storage): Distinguish between unssigned_task and tivival_move_task in the metrics report

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In the existing code, if the assignee_context_id is not found, the corresponding task will be reported to the unassigned label, which is confusing.
In this pr, it will distinguish trivival_move_task from unassigned more precisely so that they can be better distinguished in the metrics.

Checklist

[x] I have written necessary rustdoc comments
~- [ ] I have added necessary unit tests and integration tests~
~- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).~
~- [ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer the issue)~
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)


zone shapes not generating

zone shapes not generating also changes made to roaad param is not changing in screen

I can see you are doing the right thing, this may be an issue, would you like to have a google meeting?https://meet.google.com/wgj-euxi-ipx

As we just learned, the Houdini Engine does NOT support "Apprentice License". so I'll close this issue.

Thank you for your help i really mean it i downloaded full version of houdini and now it is working


Not all agents may be coherent

For instance, instruction fetches and page table accesses may involve non-coherent caches and TLBs so there is no eventuality guarantee for such non-coherent agents (except via the relevant fence instructions which are described elsewhere).
(There's a risk that this is a circular definition so maybe "coherent agent" should be defined?)

IF only that definition were that simple. You could also have clusters that
are coherent, but not coherent with others, and a different cache levels.
So, some cluster would be coherent at L1, and would be coherent with a
supercluster at L2, and be coherent with the entiere system at L3, or
something like that.
On Thu, Jun 25, 2020 at 6:05 PM Paul Donahue<EMAIL_ADDRESS>wrote:

For instance, instruction fetches and page table accesses may involve
non-coherent caches and TLBs so there is no eventuality guarantee for such
non-coherent agents (except via the relevant fence instructions which are
described elsewhere).
(There's a risk that this is a circular definition so maybe "coherent
agent" should be defined?)
You can view, comment on, or merge this pull request online at:
https://github.com/riscv/riscv-isa-manual/pull/530
Commit Summary

Not all agents may be coherent (such as instruction caches) so there
is no eventuality guarantee for such non-coherent agents.

File Changes

M src/machine.tex
https://github.com/riscv/riscv-isa-manual/pull/530/files#diff-d193b54fdcfd02782511eb49da522f67
(2)

Patch Links:

https://github.com/riscv/riscv-isa-manual/pull/530.patch
https://github.com/riscv/riscv-isa-manual/pull/530.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/pull/530, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJXAM2OKCN37LU4YYLLRYPX4BANCNFSM4OI4B3VQ
.

That's interesting and presumably legal as long as there's some "other mechanism" to meet the RVWMO Progress Axiom in A.3.4.

Closing in favor of this PR. https://github.com/riscv/riscv-isa-manual/pull/1281


Add support for custom logo in header

Could you resolve the merge conflicts? Other than that it looks good.


fixed selectionStrategy compare function (#4090)

Closes SAP/cloud-sdk-backlog#4090 .
Fixes the issue where selectionStrategy is not correctly compared when imported from different locations.

Thank you for opening the PR @ThomasSwolfs! Unfortunately, the CLA check prevents merging because one of the users you used for commiting can not be matched to a GitHub users. The bottom part of the comment gives instructions on how to fix this:

swolfth seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@mr-flannery I think this will only apply on new commits.. As it was a small change, I just opened a new pull request to keep it simple..
https://github.com/SAP/cloud-sdk-js/pull/4095


label and annotations for service binding secrets

Hi,
I have a use case where I want to replicate service binding secrets created using btp-operator to multiple namespace. I have Kubernetes replicator installed on my cluster which looks for some specific annotations and labels in secret yaml and replicates it across allowed namespaces. So I am just wondering if there is any way I can add custom annotations and labels to secrets created using service bindings using service binding yaml templates.
Thanks,
KP

currently there is no option to add labels on the secret from the binding, it is possible to add a label directly on the secret.
Can you elaborate on the use case? why do you need to replicate the secret?

@kerenlahav Thank you for responding. We have instances such as auditlog which is shared across multiple apps in different namespace and we use Kubernetes replicator to copy secrets from global-secrets namespace to application namespace based on labels. So it is important for us to label the secrets

We are currently considering this feature request.
Update will be provided when relevant

Hi @prasad03kp
Until this feature is evaluated, maybe you can use a new feature that is already included in the latest version - create a binding for an instance from another namespace.
just add 'serviceInstanceNamespace' to the binding's spec and set the relevant namespace. example:
`apiVersion: services.cloud.sap.com/v1
kind: ServiceInstance
metadata:
name: sample-instance-1
namespace: test1
spec:
serviceOfferingName: service-manager
servicePlanName: subaccount-admin
apiVersion: services.cloud.sap.com/v1
kind: ServiceBinding
metadata:
name: sample-binding-1
namespace: test2
spec:
serviceInstanceName: sample-instance-1
serviceInstanceNamespace: test1
`
Thanks,
Keren


Ensure fetch method is always uppercase

Fixes #1100
In 7.3 this was always upper cased but in v8 it is not. This breaks forms that use formmethod on buttons. On chrome and firefox puma returns a 400 but once the method is uppercased it works.
https://github.com/hotwired/turbo/blob/4593d06ce58d17af5b17495ad8524eaa9bc2f5d2/src/http/fetch_request.ts#L143

@afcapel  Are there flaky tests in the suite or are these legit failures?

The autofocus tests are a bit flaky, see https://github.com/hotwired/turbo/issues/1154

On main, locally the loading_test tests is failing for me as well.

I am using this workaround until this PR gets merged.
document.addEventListener("turbo:before-fetch-request", ({ detail: { fetchOptions } }) => {
  fetchOptions.method = fetchOptions.method.toUpperCase()
})

@brunoprietog Finally figured out the issue with tests here. This is ready to go now

Nice! Thanks @npezza93!


Feature Request or missing Documentation?

Hi, thanks for optimize-js. I would like to include it in my webpack workflow. Question:

does a Webpack plugin already exists?
is #7 an issue to create one if it does not already exists?

@neophob Yes it does. https://github.com/vigneshshanmugam/optimize-js-plugin
Haven't tested it in production though.

Thanks, gonna consider this closed since @vigneshshanmugam nailed it. #7 is something that needs to be fixed in core; we need to handle arrays of functions passed as an argument to a function as the same as functions passed as arguments to a function. Probably I didn't discover the Webpack problem because the scripts in my library are built with Browserify or other non-Webpack tools (or output by Webpack as UMD, not quite sure).


UserProfile Page: Render Description

now you can use Markdown to get something like this:

It's called Biography in Settings but internaly named Description everywhere

If this is supposed to mimic GitHub's recent profile README's, I suggest putting it into a box on the right instead of cramming it into that small box.

simpleMDE

Please don't for now. We want to get rid of SimpleMDE, not make it harder to migrate off it.

@silverwind now it only render if Description has text in it

@lunny @a1012112796 hope you dont mind the change after your LGTM?

Please don't for now. We want to get rid of SimpleMDE, not make it harder to migrate off it.

I see, it's reasonable. I think maybe we can add some note messages on the edit box to let users know the user's description support markdown rules.

I guess this is fine for now, our user profile page will need a rework anyways to allow adding one more tab to it (e.g. create a "Overview" tab and move both profile readme and activity to it).

@6543 I think the tests are genuinely failing here and don't just represent intermittent failures.

look's like I'll have to dick into it

Interestint throu that the test fail on points where this PR should NOT produce ANY change ...

☝ thats how bug's are produced - in this case the nil exeption didnt let me sleep - catched it

@lunny you noticed it at the same time :D


Update jsconfig.json

Description of the change:
Reason for the change:
Link to original source:

Closes #

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mrprit why did you remove spaces? I think it worsens readability.

Please check out our open issues for changes that we’re looking for in this repo! We’re adding new ones from easy to difficult every day.


Inserting/importing large rows

See https://forum.cockroachlabs.com/t/very-slow-mysql-import/2152/5?u=knz.
Summary: 100KB/row is on the upper side what CockroachDB can insert with decent performance. Around that size and up may result in bad performance or unexpected blockages. Also, even if you're lucky and there is a happy case for the write path, decoding the large rows upon reading will make read queries subsequently unhappy (both in throughput and memory usage).
cc: @knz

Note that @nvanbenschoten and @jordanlewis have more fine-grained, better informed knowledge/understanding about this than my own.

@mwang1026, can you check this oldish issue and decide if there's still a doc improvement to make?

I think we can punt on this for now -- especially since we don't have concrete guidance on what works better for different sizes and AFAIK we improved insert performance. Closing for now


Support binding std::optional implementation to IReference parameters

Assume I have this IDL:
runtimeclass MyThing {
    Windows.Foundation.IReference<UInt32> GetSize();
}

And my implementation says:
struct MyThing : MyThingT<MyThing> {
    std::optional<uint32_t> m_sizeComputed;
    winrt::Windows::Foundation::IReference<uint32_t> GetSize() {
        if (!m_sizeComputed) {
            return nullptr;
        } else {
            return winrt::box_value(m_sizeComputed.value()).as<winrt::Windows::Foundation<IReference<uint32_t>>>();
    }
}

I'd like this to be easier on the implementation, where instead I can just say:
struct MyThing : MyThingT<MyThing> {
    std::optional<uint32_t> m_sizeComputed;
    const std::optional<uint32_t> GetSize() { return m_sizeComputed; }
}

Is there a way for C++/WinRT's shims to match up IReference<T>-things (properties, returned types, parameters) and auto-convert them to/from std::optional<T>?

Feel free to contribute such a conversion.

This feature is available as of 2.0.210930.8.


iconv(3) should not be called if LANG is not set

Currently src/font.c will call iconv(3) functions if nl_langinfo(CODESET) != "UTF-8".
However if LANG (and LC_CTYPE) is not set calling iconv(3) might cause extra error messages "iconv conversion to UTF-8 failed" if non US-ASCII char is used in title bar.
It would be better to disable iconv calls if LANG is not set.
--- jwm-2.3.4/src/font.c.orig	2015-11-23 05:29:54.000000000 +0900
+++ jwm-2.3.4/src/font.c	2015-12-16 01:14:34.000000000 +0900
@@ -61,7 +61,8 @@
    /* Allocate a conversion descriptor if we're not using UTF-8. */
 #ifdef USE_ICONV
    codeset = nl_langinfo(CODESET);
-   if(strcmp(codeset, UTF8_CODESET)) {
+   if(getenv("LANG") != NULL && getenv("LC_CTYPE") != NULL &&
+      strcmp(codeset, UTF8_CODESET)) {
       toUTF8 = iconv_open(UTF8_CODESET, codeset);
       fromUTF8 = iconv_open(codeset, UTF8_CODESET);
    } else {

I also wonder if jwm should use client's WM_LOCALE_NAME rather than jwm's LANG or LC_CTYPE.

I suspect that JWM should use WM_LOCALE_NAME, but doing so is a slightly larger change.  If there is demand for it I'm certainly willing to support it.
I agree that JWM should not use iconv if LANG is not set.

I think I may leave this as is.  It's not completely clear to me what environment variables JWM should check and it seems like it's not really something JWM should have to worry about anyway.  The warning will happen once and only in debug mode, so it really doesn't hurt anything.

In my case (on NetBSD/i386 7.0),

jwm is started without LANG
firefox is started with LANG=ja_JP.UTF-8
-> firefox uses ja_JP.UTF-8 for titlebar strings, but nl_langinfo(CODESET) in jwm returns "646" so not only the warning but Japanese characters are not printed properly in the window's titlebar.

Thanks.  I'm looking into supporting WM_LOCALE_NAME.

I think the right solution here is to support WM_LOCALE_NAME, but unfortunately, that appears to be somewhat tricky.  I'm going to leave this as is now.  The warning isn't fatal, and I'd rather it complain if there's an iconv conversion issue rather than silently failing (or not even attempting conversion).


Task.mapBoth scaladoc doesn't mention parallel evaluation for sync Task

After #661 Task.mapBoth will force parallel evaluation even for synchronous Task but the change is missing from Scaladoc.

Thanks for the correction @Avasil, but I already added a mention in #670, as I did so in bulk for all the operations modified.


fix: conflicts between rabby and metamask

fix https://github.com/rainbow-me/rainbowkit/issues/1182

This unfortunately doesn't solve the root issue, so will close in favor of #1128. Rabby will still need to adopt this standard.

@DanielSinclair any doc for how window.ethereum.providers work?

You can reference Coinbase Wallet's implementation: https://docs.cloud.coinbase.com/wallet-sdk/docs/injected-provider#multiple-injected-providers
And how Wagmi looks for MetaMask in providers: https://github.com/wagmi-dev/references/blob/54990e8424ca69ec129b8b1528ba235b07fc3e2e/packages/connectors/src/metaMask.ts#L70


Base_bg_color & Base_text_color not workign

This is a repeat of https://github.com/mklef121/react-tailwind-table/issues/8.
Discussions are already on going on #8


Batch update all cards image field - image url should starts with /

Due to the incorrect public_folder configuration on config.yml. Images on EN site couldn't be randerred.
related workaround #177

fixed in #177


Ensure proper handling of RunConfiguration for DevAppserver v1

handle multiple modules

establish rules and handle java8/java7 detection

warning messages for ignored parameters (that are only v2)

Codecov Report

Merging #346 into master will increase coverage by 0.95%.
The diff coverage is 86%.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   59.89%   60.84%   +0.95%
==========================================
  Files          64       64
  Lines        1643     1678      +35
  Branches      250      256       +6
==========================================
+ Hits          984     1021      +37
- Misses        553      554       +1
+ Partials      106      103       -3

Impacted Files
Coverage Δ

...ngine/cloudsdk/internal/args/DevAppServerArgs.java
50% <0%> (-35.72%)
:x:

...ppengine/cloudsdk/CloudSdkAppEngineDevServer1.java
69.47% <95.55%> (+23.31%)
:white_check_mark:

...gle/cloud/tools/appengine/AppEngineDescriptor.java
82.14% <0%> (+3.57%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4d10a...d15991a. Read the comment docs.

Let's talk about how we want to support the clear datastore flag for
devappserverv1 when I get back.
On Tue, Mar 21, 2017 at 12:57 PM, Appu Goundan<EMAIL_ADDRESS>wrote:

@loosebazooka commented on this pull request.
In src/main/java/com/google/cloud/tools/appengine/cloudsdk/
CloudSdkAppEngineDevServer1.java
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/346#discussion_r107259170
:

checkAndWarnIgnored(config.getAppYamls(), "appYamls");

checkAndWarnIgnored(config.getAdminHost(), "adminHost");
checkAndWarnIgnored(config.getAdminPort(), "adminPort");
checkAndWarnIgnored(config.getAuthDomain(), "authDomain");
checkAndWarnIgnored(config.getStoragePath(), "storagePath");
checkAndWarnIgnored(config.getLogLevel(), "logLevel");
checkAndWarnIgnored(config.getMaxModuleInstances(), "maxModuleInstances");
checkAndWarnIgnored(config.getUseMtimeFileWatcher(), "useMtimeFileWatcher");
checkAndWarnIgnored(config.getThreadsafeOverride(), "threadsafeOverride");
checkAndWarnIgnored(config.getPythonStartupScript(), "pythonStartupScript");
checkAndWarnIgnored(config.getPythonStartupArgs(), "pythonStartupArgs");
checkAndWarnIgnored(config.getCustomEntrypoint(), "customEntrypoint");
checkAndWarnIgnored(config.getAllowSkippedFiles(), "allowSkippedFiles");
checkAndWarnIgnored(config.getApiPort(), "apiPort");
checkAndWarnIgnored(config.getAutomaticRestart(), "automaticRestart");
checkAndWarnIgnored(config.getClearDatastore(), "clearDatastore");

Oh right :
jvmFlags = ['-Ddatastore.backing_store="/path/to/datastore/file/location/local_db.bin']
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/346#discussion_r107259170,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HQtXrDputgCy95PSZsFumT_xisR9ks5roCudgaJpZM4MhL0J
.

By the way, with devappserver1, do we also want to add another condition to validateCloudSdkLocation() that probes the location of devappserver1?

DevAppServerMain is in appengine-tools-api.jar, so the current check for the app-engine-java component should suffice.

@loosebazooka
I'd love to merge this today to get a release out that includes this and Joao's JDK fix.

take another look!


Passwords and other secrets should be obfuscated

The CLI captures and holds credentials to assist with automation. The CLI hides user-typed instances of these credentials via utils.prompt but the values are stored in plaintext and displayed when configuration values are listed to screen. This should be remedied by adding minimal obfuscation.

These are obfuscated when displayed by prompt() and when accessed by tapis settings * commands. They are not encrypted on disk, nor are measures in place to redact them from command output display.


invalid syntax

I get this error when trying to run the program.
Traceback (most recent call last):
File "gmad.py", line 55, in
user_input()
File "gmad.py", line 23, in user_input
parent_dir = input("Please enter the directory that your addons are located (/home/user/projects/addons): ")
File "", line 1
/home/mint/.local/share/Steam/steamapps/common/GarrysMod/garrysmod/addons/
^
SyntaxError: invalid syntax

What version of python are you using?


Place comment box above comments

If there are a lot of comments it gets annoying to scroll all the way to the bottom to add your own. It would be nice to be able to place the comment box at the top instead.

Duplicate of https://github.com/giscus/giscus/issues/157

@nschonni I believe the correct link would be https://github.com/utterance/utterances/issues/513 :sweat_smile:


[feature] Added page to show OpenWISP versions #237

Closes #273
Changes

#Please explain changes made in your PR#

Screenshots

#For UI changes, please share a screenshot#

Checklist

[ ] I have read the contributing guidelines.
[ ] I have manually tested the proposed changes.
[ ] I have written new test cases to avoid regressions. (if necessary)
[ ] I have updated the documentation. (e.g. README.rst)
[ ] I have added [change!] to commit title to indicate a backward incompatible change. (if required)
[ ] I have checked the links added / modified in the documentation.

#Closes #(issue-number)#

coverage: 97.974% (-0.2%) from 98.175%
when pulling 4f3672ca94982bf64eaffd1948c779a86aec20a7 on issues/273-openwisp-version
into 746b14618dc1df922224f8cb3f258bc3f788e0e1 on master.


RC dma fix removed

Looks like the NVMe reset sequence fix has solved the NVMe link training issue.

Looks like you accidentally created a pull request for the branch RC_dma_fix_removed while you wanted to create a pull request for the NVMe reset fix (branch RC_NVMe_sideband)


Subtract time from token expiration

I like that this one has tests.  :)

This also looks good to me.

wdyt?

btw, thinking of it, maybe the default value we substract should be 0, no?

Users could set 0 explicitly. I think it depends whether the majority of users would want to set it to zero, or 1 second would be fine in most cases.

btw, thinking of it, maybe the default value we substract should be 0, no?

I think it makes more sense to have the default value set to 1. That way we're preventing the kind of error we had to happen in other situations.


Fixed Array1D constructor missing

The TNT::Array1D(int n,  T *a); constructor takes arguments by non-const reference, but in tnt_sparse_matrix_csr.h it tries to use a member initialisation list of temporary objects, as was happening here:
template <class T>
Sparse_Matrix_CompRow<T>::Sparse_Matrix_CompRow(int M, int N, int nz,
	const T *val, const int *r, const int *c) : val_(nz,val),
		rowptr_(M, r), colind_(nz, c), dim1_(M), dim2_(N) {}   // <--- not allowed!

Temporary objects cannot bind to non-const references. (https://stackoverflow.com/questions/8101489/c-no-matching-constructor-for-initialization-of-compiler-error), and you get this error when trying to compile with clang (I don't know why other compilers don't pick it up?):
/home/dav/Devel/HAIL-CAESAR/include/TNT/tnt_sparse_matrix_csr.h:97:3: error: no matching constructor for initialization of 'Array1D<int>' [clang-diagnostic-error]
                rowptr_(M, r), colind_(nz, c), dim1_(M), dim2_(N) {}
                ^          ~
                           *
include/TNT/tnt_array1d.h:63:11: note: candidate constructor not viable: no known conversion from 'const int *' to 'const int' for 2nd argument; dereference the argument with *
                 Array1D(int n, const T &a);
                 ^
include/TNT/tnt_array1d.h:64:11: note: candidate constructor not viable: 2nd argument ('const int *') would lose const qualifier
                 Array1D(int n,  T *a);

So the solution is just to add another constructor for TNT::Array1D that takes a const reference. I think...
Clang does not complain now.

Closes #3


ToParentBlockJoinQuery work error

Description
`
final Directory dir = newDirectory();
final IndexWriterConfig config = new IndexWriterConfig(new MockAnalyzer(random()));
config.setMergePolicy(NoMergePolicy.INSTANCE);
// we don't want to merge - since we rely on certain segment setup
final IndexWriter w = new IndexWriter(dir, config);
final List<Document> docs = new ArrayList<>();

docs.add(makeJob("java", 2007));
docs.add(makeJob("python", 2010));
docs.add(makeResume("Lisa", "United Kingdom"));
w.addDocuments(docs);

docs.clear();
docs.add(makeJob("ruby", 2005));
docs.add(makeJob("java", 2006));
docs.add(makeResume("Frank", "United States"));
w.addDocuments(docs);

docs.clear();
docs.add(makeJob("ruby", 2005));
docs.add(makeJob("java", 2099));
docs.add(makeResume("Lisa", "United States"));
w.addDocuments(docs);

w.commit();

IndexReader r = DirectoryReader.open(w);
w.close();
IndexSearcher s = newSearcher(r);
BitSetProducer parentsFilter =
    new QueryBitSetProducer(new TermQuery(new Term("name", "Lisa")));
CheckJoinIndex.check(r, parentsFilter);

BooleanQuery.Builder childQuery = new BooleanQuery.Builder();
childQuery.add(new BooleanClause(new TermQuery(new Term("skill", "java")), Occur.MUST));
childQuery.add(new BooleanClause(IntPoint.newRangeQuery("year", 2006, 2011), Occur.MUST));

ToParentBlockJoinQuery childJoinQuery =
    new ToParentBlockJoinQuery(childQuery.build(), parentsFilter, ScoreMode.Avg);

BooleanQuery.Builder fullQuery = new BooleanQuery.Builder();
fullQuery.add(new BooleanClause(childJoinQuery, Occur.MUST));
fullQuery.add(new BooleanClause(new MatchAllDocsQuery(), Occur.MUST));
TopDocs topDocs = s.search(fullQuery.build(), 2);`

In my opinion , the code will return one document (the 3th document ), But actually return two document (the 3th and the 9th document) .so i see the source code , in class ToParentBlockJoinQuery.ParentApproximation.advance() method,
public int advance(int target) throws IOException {       if (target >= parentBits.length()) {         return doc = NO_MORE_DOCS;       }       final int firstChildTarget = target == 0 ? 0 : parentBits.prevSetBit(target - 1) + 1;       int childDoc = childApproximation.docID();       if (childDoc < firstChildTarget) {         childDoc = childApproximation.advance(firstChildTarget);       }       if (childDoc >= parentBits.length() - 1) {         return doc = NO_MORE_DOCS;       }       return doc = parentBits.nextSetBit(childDoc + 1);     }
the parentBits is     0000 ... 100000100
child query match 3th and 5th document , when advance 5th document , this code will consider the 9th document as the parent document of the 5th document, and return the 9th document
is this a bug ? or my question .
Version and environment details
lucene branch_9_0
window 10

Hi, The parents filter should select all parents as its' stated in javadoc. Not the particular one. You can check more examples and explanation in Solr Ref guide

ok，I now it . thanks