Missing Duplicate Run from Triggered Action Menu

Closes #1568
Description
Action menu of Runs triggered page updated with "Stop run" & "Duplicate run" which is same as in Pipeline Run detail page.
@kywalker-rh tagging you for UX review

How Has This Been Tested?

Create workbench and upload a pipeline.
Create run with Run type: Run once immediately after creation
Move back to Runs page, on Triggered tab.
Click on action menu on any row.
New actions added "Stop run", "Duplicate run".
"Stop run" is disabled when pipeline not running.
Click on both actions to run them.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[ ] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

There is no alert that appears after clicking on the "Stop run" action, which could be confusing for users and they may try to click again on it. Would you like me to add an alert popover to provide more clarity? This issue also seems to be present on the Pipeline run details page.

@dpanshug Can you fix the linting issues please?

@dpanshug Can you fix the linting issues please?

Yes, I already did it, pls refresh.

There is no alert that appears after clicking on the "Stop run" action, which could be confusing for users and they may try to click again on it. Would you like me to add an alert popover to provide more clarity? This issue also seems to be present on the Pipeline run details page.

If you have this kind of questions, just ping UX, you can check who here in this case @yannnz

@dpanshug After checking the code, it seems that we don't show a modal in the details page of the run, not sure if intentionally, but it would be safer to ask to @andrewballantyne too

@dpanshug After checking the code, it seems that we don't show a modal in the details page of the run, not sure if intentionally, but it would be safer to ask to @andrewballantyne too.

@lucferbux @dpanshug can one of you post a screenshot and tag Yan for followup. Your PR description lacks any modal images 🤔

For the Kebab options, the only concern are the content. Under the Scheduled runs, we call Duplicate without Run, so I think to follow suit, we can name the two options Duplicate and Stopfor consistency.

The other thing I realized when checking the Implemented UI is that there is a responsive problem of the Triggered Run tag. I didn't see the kebabs when I firstly landed this tab. See the screenshot below. I need to stretch my browser wide enough to realize there are kebabs of the table rows, but then I cannot see the navigation in my screen.

For the notification, what happened after the user clicked Stop? Will we have a modal to ask the user to confirm they are stopping a run? How long does it take to stop a run in general? Will we allow the user to retry a stopped run. We will also need to updat the status icon of a stopped run.
Some screenshots from KBF to explain my questions:

@yannnz Answering your questions.

Yes we can remove run to keep consistency.
I also found this issue, when pipeline name is too long. I will report another issue for it.
Having a model will be good for Stop action, @andrewballantyne wdyt?

@dpanshug https://github.com/opendatahub-io/odh-dashboard/issues/1182 is the issue we had for the table. I found it during development and then couldn't find it after the fact. We should probably reopen that one and detail out any information you have to help narrow the reproduce use-case.

Having a model will be good for Stop action, @andrewballantyne wdyt?

@yannnz @dpanshug Interesting, I guess I never thought about it. Stopping a Pipeline isn't something I'd waste time saying "are you sure?". But also not something I think would be too problematic if it did take a moment. Only downside with the modal is "I want to stop it, but it takes 3 seconds because I need to deal with the modal". We have a stop workbench modal too -- but it has the option to be fully disabled (indefinitely).
Do you feel it's needed right now? Can we swing back and figure out if it's needed / what features are needed? We don't have the functionality today to use a modal afaik.

It brings up the 3rd question I have. Will we allow the user to retry/restart a stopped run?  I don't find it in KBF somehow. I think if we allow the user to restart a stopped run, it will prevent an stop action triggered by accident. Allowing the user to retry the stopped run would be better than a confirmation modal, which the run might already finished when they finished dealing with the modal. WDYT?

@yannnz @dpanshug Interesting, I guess I never thought about it. Stopping a Pipeline isn't something I'd waste time saying "are you sure?". But also not something I think would be too problematic if it did take a moment. Only downside with the modal is "I want to stop it, but it takes 3 seconds because I need to deal with the modal". We have a stop workbench modal too -- but it has the option to be fully disabled (indefinitely).
Do you feel it's needed right now? Can we swing back and figure out if it's needed / what features are needed? We don't have the functionality today to use a modal afaik.

Added #1282 to the PR and assigned you @dpanshug -- you don't need to do anything, both issues are related to the work you are doing here.

Will we allow the user to retry/restart a stopped run?

@yannnz we sorta can -- I imagine code-wise it should be a matter of just running it through the dupe flow. Biggest concern is "what do we call the run?" -- everything else is more-or-less just going to be duplicated.
Essentially though, this is a duplicate flow. There is no way to "restart" a completed or on-going resource -- stopped or not.
So if duplicate is not enough for your desired flow, could you log a feature request asking for a specific "restart" flow. Essentially the biggest code question would be, what do we name it if we don't just push them through the duplicate flow.

Can you squash both the commits? Is this an empty file frontend/src/concepts/pipelines/content/StopPipelineRunModal.tsx? Is this WIP?

That was an error, i've removed the file now.

As discussed with @yannnz, the modal for stopping run will be decided in separate issue. cc @andrewballantyne

@christianvogt  Yes thanks for reminding it. We had discussion above that the terminologies need to be consistent with the table row kebab menu. cc: @dpanshug

@yannnz Answering your questions.

Yes we can remove run to keep consistency.
I also found this issue, when pipeline name is too long. I will report another issue for it.
Having a model will be good for Stop action, @andrewballantyne wdyt?

@dpanshug - As requested, could you make updates to PipelineRunDetailsActions for Stop run and Duplicate run for consistency with the kebab menu actions.
As for the confirmation modal, we can make those changes in a followup PR since the current actions don't currently display any modal. This request also needs to still be confirmed by @andrewballantyne and @yannnz. Therefore I do not want to hold up this PR.

Definitely omit the concern about the stop modal from this PR -- see https://github.com/opendatahub-io/odh-dashboard/issues/1848 for the followup.

@dpanshug - As requested, could you make updates to PipelineRunDetailsActions for Stop run and Duplicate run for consistency with the kebab menu actions.

Changes made :heavy_check_mark: @christianvogt

/lgtm
/approve


Remove unused setup module variable.

Remove unused setup module variable.
closes #6

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Save editor does not account for Girlfriend Flag (Uses wrong S.Link IDs)

Possibly related to #1
The page here here lists a fair number of ?'s and duplicate ID's under the social link identifier section.
The duplicate IDs represent the 'girlfriend flag'.
0B is the ID the editor uses for Chie. However, that is the flag for when she is your girlfriend.
Taken from my normal game, 0C is the default, non-girlfriend chie.
I imagine it is like this for all the other duplicate entries.
Unrelated, but not worth opening another issue about right now, there is an 04 on certain S.Links, such as jester, hierophant, and devil that isn't preserved when writing the save file (even if you didn't modify the social link section)
example line: 09 00 0A 00 00 00 00 00 00 00 00 00 04 00 00 00
After it is saved: 09 00 0A 00 00 00 00 00 00 00 00 00 00 00 00 00

This is related to #1 If you are maxed and/or not on the lovers route and you edit the save even if not touching social links, the editor removes them. Had to do this several times. damn near broke the game for me as it caused my sun link to disappear and i hadnt realized and was not able to activate the march event with sun link. took some fiddling to get an event to work. So this should be somewhere at the top of the list to be fixed.

It may, as the ones that got nuked on me were all potential girlfriend (but werent in my save): Chie, Rise, and Ayane. Aside from Ayane, the others weren't at max level, so them being maxed isn't the problem.
And yeah, was a bit of a pain to fix. Eventually ended up copying out the S.Link section from an old save and modified it to the values I remembered them having.

Would you mind detailing how exactly you managed to revert those values back? I realized these same errors during the bus scene when I couldn't reach Yukiko. Also noticed it changed my relationship statuses with some of them and my expression stat was decreased by one level for some reason when the save before editing was at max.

Get a hex editor. I used HxD. Open the bad save file in it, as well as an old good one.
Scroll down to about line 1970. Thats the social link section. Look on the link I posted in the first post for what those values mean.  (However, the link uses all decimal values, and they should be hexadecimal values. So use an online converter or something to get an idea of the values you'll be needing. For instance, for rank 10, the 10 would be 0A in hexadecimal.)
I just copied that section out of an old good save, into the borked save. Note you need to overwrite the existing section (via the paste overwrite or similar option), otherwise you'll bork your save.
As for the expression thing, I haven't looked into that one, but if you look on that wiki page, you can probably figure it out.

Thanks for the insight, @Kosyne! I'm working on it right now so expect an update within an hour or two.


How do I achieve this using leaflet?

Hi,
I am new to mapBox. I had fixed this using normal mapBox API as in the instructions. But now, I have moved my application to Leaflet. How do I add source and get this fix for disputed boundaries for India? Would be great if you can provide a sample code using leaflet. Thanks.

@planemad, would you be able to help here?

@akbu2498 i'm not completely familiar with leaflet, but its likely that you will not be able to use the Mapbox source as easily with it to get this result.
You can try adding a custom GeoJSON overlay https://leafletjs.com/reference-1.3.0.html#geojson and use this export->GeoJSON for the extra boundaries in your map. You will need to add style properties in leaflet to closely match the basemap style.


[Feature Request] Add bg-white-25 & bg-black-25

Add bg-white-25 & bg-black-25
I think it may be useful to have the background transparency classes such as: bg-white-25, bg-black-25.
Can be used to fade elements onto a background.
Screenshots using the classes on an <input> element in the dashboard example

Thanks, but we'll pass on adding these. 25% feels arbitrary, and it'll open us up to folks asking for more.


Fix #1367: Image picker enhancements

Q
A

Bug fix?
[X]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #1367

What's in this Pull Request?
PR contains changes to the FilePicker control to match OOTB Sharepoint File Picker

Added placeholder to the 'From a link' tab

Updated layout for 'Site' tab

Before:

PR:

@michaelmaillot Thank you for review, I'm working on update for more responsive layout :)

Merged manually, thank you!


Some data in the Concrete3K dataset do not match

Hello author, thank you for providing the project code.
But it can be seen that some images and labels do not match in the dataset downloading from Conrete3K  link, such as 359_10.jpg, 363_35.jpg, 364_28.jpg and so on. Checking the dataset again may be helpful for your model performance.

Thank you very much for the heads up. We are checking the dataset Concrete3k and the data will be updated soon.

Thank you very much for pointing out our mistakes. The revised dataset has been updated. In fact, in the experiment we just ran, we found that the model's results on the revised dataset far exceeded the previous ones. Many thanks again.


feature request to support raw macro or \texttt{} translation in mitex

For example,
#import "@preview/mitex:0.2.1": *
#mitext(`
        The torus geometry paratermized with fluxes $phi_1,phi_2$ can be described with the struct:
        ```julia
        struct Torus_Sample
            L1::Float64
            τ::ComplexF64
            Ns::Int64
            mag_trans_units::Vector{ComplexF64}
            phase_twists_over_2π::Vector{Float64} # fluxes (ϕ1,ϕ2)
        end
        ```
        where we introduce the *minimal* quantized intervals of the sample along two oblique directions $(\delta L_1,\delta L_2)=(\frac{L_1}{N_s},\frac{L_1\tau}{N_s})$, such that each thin rectangular is pierced with just *one* quantum flux
        \begin{equation*}
            \delta L_1\times L_2 = 2\pi\ell^2,\quad \delta L_2\times L_1 = 2\pi\ell^2.
        \end{equation*}
`)

does not render at all.
I encounter this problem because I am transferring my academical notes from markdown (very long and hundreds of huge equations, so rendering slow in markdown) to typst (which is really fast).
Maybe #raw() macro support can be added for pair of `...` and ```...```, which is not the keyword in latex so should work out without any ambiguities.

``` isn't a latex syntax, and we shouldn't consider adding support for this markdown syntax? You might consider using \iftypst.
But the actual problem here is that ``` conflicts with the ` of #mitex(`, which is already a limitation of the typst syntax.

I understand, thx.


🐛 Bug Report: GithubIntegration Doc links to itself

📜 Description
https://backstage.io/docs/reference/integration.githubintegration
This document states that this API is obsolete, and the link in that message takes you to this same page, so I am not sure what the replacement API is.
👍 Expected behavior
Take me to the non obsolete api
👎 Actual Behavior with Screenshots
Just redirects back to the same page you're on.
👟 Reproduction steps
go to:
https://backstage.io/docs/reference/integration.githubintegration
click on the link in the box at the top stating that this API is obsolete.
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Hi @reskin89, can for sure this being confusing. I "think" the issue is casing.
This is the deprecated code:
https://github.com/backstage/backstage/blob/768d2c42166ef85ae6e3a80d278d40d95f464722/packages/integration/src/github/deprecated.ts#L42
And the code that you should be using is here:
https://github.com/backstage/backstage/blob/768d2c42166ef85ae6e3a80d278d40d95f464722/packages/integration/src/github/GithubIntegration.ts#L34
If I remember correctly a few years ago it was agreed to use "Github" with the lower "h" instead of "GitHub". I do not know the reasoning, sorry, maybe it's here: https://github.com/backstage/backstage/pull/14192.
To come full circle the URLs are capturing this issue which can lead to confusion as you have seen. We honestly should probably remove the deprecated code!

Hi @reskin89, the deprecated code has been removed and the docs have also been updated to reflect this 👍

Awesome, thanks @awanlin !


[Docs] adding the program name

Category of documentation update

in this question we can add GSSOC'24 name also
Describe the change you think might work
I shall modify the answer by adding GSSOC'24
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @solanki505


Sorting/Heapsort[C++]

This issue is about Sorting/Heap sort

[x] Issue Title is in the form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

This issue is about [Algo/DS Name](link to resource for the Algo/DS).

[x]  Issue Title is in form Algo/DS Name [Language].

[x]  I searched or browsed the repo’s other issues to ensure this is not a duplicate.

[x]  This Algo/DS is worth adding to this repository.

[x]  Assign this issue to me (I want to work on this).

[x]  I ensure that I am not already assigned to 2 or more issues.

[x]  I will send my PR only after I'm assigned to this issue by any maintainer.

[x]  I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

@iiitv/project-maintainers i would like to work on this issue

@nlok5923 fill the Algo/DS Name [Language] details :)

@nlok5923 fill the Algo/DS Name [Language] details :)

Heap sort[C++]

@yashshah2820 Sir is it fine now do let me know.

link to any resources as mentioned in the issue body

link to any resources as mentioned in the issue body

@yashshah2820 added the resource link.

@nlok5923 go for it 👍


(fix): ExtensionArray + DataArray roundtrip

I drive-by added name to the Series since it wasn't there before.

[x] Closes #9519
[x] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

It appears that this PR may have broken some upstream pandas tests, specifically testing round-trips with various index types:
https://github.com/pandas-dev/pandas/blob/e78ebd3f845c086af1d71c0604701ec49df97228/pandas/tests/generic/test_to_xarray.py#L32
Here's a minimal test case:
import pandas as pd
import numpy as np

cat = pd.Categorical(list("abcd"))
df = pd.DataFrame({"f": cat}, index=cat)
restored = df.to_xarray().to_dataframe()
print(restored.index)  # Index(['a', 'b', 'c', 'd'], dtype='object', name='index')
print(df.index)  # CategoricalIndex(['a', 'b', 'c', 'd'], categories=['a', 'b', 'c', 'd'], ordered=False, dtype='category')

I'm not sure if this is a pandas or xarray issue, but it's one or the other!
(My guess is that most of these tests in pandas should probably live in xarray instead, given that we implement all the conversion logic.)

@shoyer This is probably an "us" issue.  I will look into it.


docs(Playground): fix and improve endpoint list

Docker and Playground fail?

You don't have write permission on it


Support test discovery in sources that are directories

At the moment, test platform only supports discovery of tests present inside test sources that are files. With the change in this PR, it can additionally support discovery of tests present inside test sources that are directories. This helps test adapters for certain languages like python which prefer to discover tests at the granularity of a directory as opposed to individual files.
Python adapter currently supplies test containers that are individual .py files to the VS test explorer. However, when these files are sent to the python test discoverer, the discoverer ignores the individual files and always jumps up to the containing project's directory to discover tests present inside all .py files present under this directory.
Python adapter has some reasons for this behavior (tickets linked below contain more context). However, there doesn't seem to be any significant reason why test platform can't support test discovery at a directory level granularity.
This PR relaxes the requirement that supplied test containers (sources) must always be files. It now also allows test containers that are directories. It also introduces a new [DirectoryBasedDiscoverer] attribute that can be applied on ITestDiscoverers that only care to process sources that are directories (similar to the existing [FileExtension] attribute that can be applied on ITestDiscoverers that only care to process sources that are files with specific extensions).
Related tickets:
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1586970
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1560000

@nohwnd does it work with all the "above" part related to inferring the host?

Thinking about this a bit more:
The reason this capability just (accidentally) works, is because we provide a default runtime environment for non-dll sources. The hidden assumption here is that we will start a testhost.exe to run the adapter, which will then do the work on their own or delegate to additional executable (e.g. xmlTests can be handled in process, but .py tests need to be delegated to python). And we also assume that the provided file type represents only one type of runtime, or that the adapter can detect the correct runtime and start it itself (e.g. .py can be started with python2.exe or python3.exe based on metadata in the file, or if someone would want to implement this for usage with dlls, they would have to multiplex to .NET, .NET Framework, UWP, WinUI and Native).
I guess this brings us back to discussion I think we had in the past: We use the sources to indirectly determine which TestRuntime provider should be used. In runner we check TargetFramework, and if not specified, we auto-detect TargetFramework by looking at the dll metadata. TargetFramework is then used by TestRuntime providers to determine if they can run the workload or not.
So while it is not blocking for this PR, it would be nice to determine a way to provide additional metadata on the source level, for us to skip some of those checks. Especially in cases where VS possibly has all the info already e.g. what dll type this is, what dlls the project references, and if there are any well known adapters among them.

@nohwnd Totally agree that it would be great if source could be an open-ended concept. This could open up other interesting scenarios where the source used need not be present on disk at all (for example, it could be a URL to some online resource which serves the appropriate tests and which the adapter knows to interpret).
I don't think it is bad to have a reasonable default when a target runtime is not specified. But it would certainly be nice if there was a way to provide additional metadata about target runtimes. In cases where adapter knows it will be the same runtime for all sources (like python), perhaps the adapter could specify this declaratively via an attribute. For other cases (especially dll-based) VS could provide info about source-level target runtimes via new API / runsettings. Iirc, VS already provides the TargetFramework, does it not?
Detecting precise adapter references for a project could be done - but this may be a tricky change as it can impact backwards compatibility. Currently VS detects and passes all adapters referenced in the solution regardless of the set of adapters actually referenced by the tests being executed. But changing this would also prevent some redundant sniffs in the adapters - so this would also be nice to optimize down the line. Perhaps VS can have a special mode where projects opt into the new behavior where it would only pass relevant adapters to TP...

Does this even work? @nohwnd
By the way it makes sense that there can be a Python Test Adaptor that works with VS Test as it used JSON based socket protocol. Probably that is part of python SDK that comes with visual studio? Good to know.
When I give directory instead of DLL path, I still get error.
Command:

D:\prototype> "C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\Extensions\TestPlatform\vstest.console.exe" Smpl.Calc.Lib.UT.NuTest\bin\Debug\net8.0\

Error:

Microsoft (R) Test Execution Command Line Tool Version 17.10.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.
The test source file "D:\prototype\Smpl.Calc.Lib.UT.NuTest\bin\Debug\net8.0" provided was not found.

Yes the python adapter can be installed with VS.


Missing images from /image/

Errno 2] No such file or directory: '/home/discord/decksite/decksite/./images/words-of-waste.jpg'

Reported on decksite by logged_out```
--------------------------------------------------------------------------------
Request Method: GET
Path: /image/Words of Waste/?
Cookies: {}
Endpoint: image
View Args: {'c': 'Words of Waste'}
Person: logged_out
Referrer: None
Request Data: {}
Host: pennydreadfulmagic.com
Accept-Encoding: gzip
Cf-Ipcountry: US
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
Cf-Ray: 4547b1f128cc797f-SEA
X-Forwarded-Proto: https
Cf-Visitor: {"scheme":"https"}
User-Agent: github-camo (65c9ebe0)
Accept: /
Accept-Language: en-US,en;q=0.5
Via: HTTP/1.1 github-camo (65c9ebe0)
Cf-Connecting-Ip: <IP_ADDRESS>
X-Forwarded-Host: pennydreadfulmagic.com
X-Forwarded-Server: pennydreadfulmagic.com
Connection: Keep-Alive

--------------------------------------------------------------------------------
FileNotFoundError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2309, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/main.py", line 372, in image
return send_file(path)
File "/home/discord/.local/lib/python3.6/site-packages/flask/helpers.py", line 588, in send_file
file = open(filename, 'rb')

There are a bunch of these. As we call acceptable_file before returning it will take some investigation.

The path here is /home/discord/decksite/decksite/./images/words-of-waste.jpg which has "decksite" one too many times. Y tho?

That is an actual filepath ('decksite' contains a full checkout of the repo and one of the top-level directories is called decksite). But that's not where the (working) words-of-waste.jpg image is.

This is kind of weird. (From prod REPL.)
>>> from decksite import APP
>>> with APP.app_context():
...     send_file(path)
...
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
  File "/home/discord/.local/lib/python3.6/site-packages/flask/helpers.py", line 588, in send_file
    file = open(filename, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '/home/discord/decksite/decksite/./images/words-of-waste.jpg'
>>> open(path, 'rb')
<_io.BufferedReader name='./images/words-of-waste.jpg'>

open does the right thing in a REPL when called directly but not when called via send_file. The "current directory" is wrong in the send_file version. But some of our send_file calls do the right thing otherwise the endpoint wouldn't be working at all.

Actually I think maybe every image IS broken rn. I can no longer get the prod version to give me an image for anything.

So, I think I have it, store saves them (and declares them send-able) relative to monolith root because it's a monolith thing.
send_file then tries to send from a decksite-relative root because it's decksite/flask-specific and that's the mismatch.
Fix is probably to make an absolute path immediately prior to passing into send_file?

a33df74a.


Manage Subscriptions

From release plan spreadsheet
Estimate from release plan: 13 hours
Expressing interest: none

Create a service to retrieve, add, remove subscriptions on REST
Add the ability to subscribe/unsubscribe on the collection page itself
show an overview of active subscriptions on the profile page with the ability to remove them

we want to note that the subscription functionality have been extended and implemented in DSpace-CRIS 7.
If what we have done in DSpace-CRIS is of interest of the DSpace community and can be accepted as is eventually disabling part of the feature that cannot be immediately ported we are available to make a more accurate estimation for the porting work.
We can anticipate that it should took not less than 24 hours on the Angular side.
The feature has been improved on this aspects:

it is possible to subscribe also community and item
subscriptions have a type: content (default of dspace) or statistics
frequency of notification can be defined by the user (daily, weekly, monthly)


portico: Add export advertisement to FAQ.

Making a user docs page for this ended up being a bit complicated, since e.g. you'll want them to figure out their realm_id or subdomain, deactivate their realm before the export, there are a bunch of caveats (like bots), etc.

OK, merged.  Do you have a draft of the user docs page somewhere?  I don't think figuring out a subdomain is hard; it's going to be '' for almost every case, and I think given how often people will actually need to do this, a pretty basic explanation should be good enough...  I'd be happy to spend 10 minutes trying to get it mergable.


Move view filters to a dedicated file.

The views.py is becoming a mess.

@vkaracic I have your branch deployed in my test environment, please tell how to test this?
Should I wait for conflicts to be resolved and then re deploy to test?

Sorry, I'm unable to continue this PR
On Fri, Aug 17, 2018, 20:26 sourceflakes<EMAIL_ADDRESS>wrote:

@vkaracic https://github.com/vkaracic I have your branch deployed in my
test environment, please tell how to test this?
Should I wait for conflicts to be resolved and then re deploy to test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IEEEKeralaSection/rescuekerala/pull/425#issuecomment-413950850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACrZHAsId6M_JYFdAzdsqTEtPoJAHcgWks5uRwrMgaJpZM4WB9k6
.


Copy & Paste support for Simple Browser

It's not possible to copy from or paste to the integrated Simple Browser.
This feature might be very simple to implement and would bring a lot of benefit with it.

I'll try to fix this

What do you mean by integrated Simple Browser? Do you mean customized webview?

The thing that comes up when I press F1 and type "Simple"

The thing that comes up when I press F1 and type "Simple"

Just on my side, I can copy from & paste to the website opened by Simple Browser command. (with version 1.78) Can you give us a sample url which is not functioning as expected?

My side can also copy, need an example of the bad case

I was trying to have "https://doc.sccode.org/" ope alongside with my code.

I was trying to have "https://doc.sccode.org/" ope alongside with my code.

thanks, I'll try to fix it

@gogobd @mjbvz  It seems that this problem was caused by the iframe. We cannot listen to events inside the iframe. It seems that this is currently an unsolvable problem?

I wonder where the event would get lost, it copy & paste from a separate browser works fine.

I can provide an additional example that just lead to this thread:
https://tldp.org/HOWTO/NCURSES-Programming-HOWTO/init.html

@gogobd @mjbvz It seems that this problem was caused by the iframe. We cannot listen to events inside the iframe. It seems that this is currently an unsolvable problem TAT?

So maybe related to #182642

I wonder why this isn't handled by the "outside" OS

This is happening on my Mac.
To reproduce:

Command Palette > Simple Browser > Show > https://example.org

Highlight the text "Example Domain"

Attempt to copy it

Right click

Expected - Show a context menu with "Copy" item
Actual — Nothing happens

Press Cmd+C

Expected — The text is copied
Actual — Nothing happens

Menu bar > Edit > Copy

Expected — The text is copied
Actual — Nothing happens, although the menu item not disabled.

Version: 1.81.1 (Universal)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:20:33.924Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

Thanks for confirming!

From further testing, it appears that Simple Browser running inside VS Code for the Web does not suffer from this problem (I can copy text from the page inside the Simple Browser just fine).
Therefore, this issue seems to only affect Electron-based builds.

I tried again with VSC (macOS)
Version: 1.83.0
Commit: e7e037083ff4455cf320e344325dacb480062c3c
Date: 2023-10-03T16:13:10.518Z (1 wk ago)
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0
and the Problem still exists...

Any news on this?

Has there been any progress?

Also facing this issue, bumping for exposure. I have to inspect the html to copy

I am also facing the same issue
not working with https://mantine.dev

I just tried this again after quite some time and the issue is still there. Now I have Version: 1.87.2 (Universal) Commit: 863d2581ecda6849923a2118d93a088b0745d9d6

I'm particularly interested in being able t copy from https://doc.sccode.org/ and that still doesn't work.

I poked around a little in the code for for this one.
graph TD
vscode --> c[overlay webview container] --> i2[webview iframe/index.html] --> i3[viewer iframe] --> i4[content iframe - different origin]
i3 -- click --> ch[click handler] -- did-context-menu postmessage --> i2

The iframe that loads the Simple Browser (the "content iframe" above) is literally three iframes deep in the stack. Context menus work in ordinary webviews (two iframes deep) because of an event handler that generates window messages, like this one:
https://github.com/posit-dev/positron/blob/48277102f7592c9b5a31ff3050dc88e808b63887/src/vs/workbench/contrib/webview/browser/pre/index.html#L1160-L1164
However, the content iframe (where the Simple Browser loads URLs) doesn't have event handlers attached. This isn't an oversight; it's a result of security policy. You can't listen in on events generated from frames with a different origin.
So there's probably not going to be a simple fix here. One approach would be to put some sort of event-absorbing glass over the webview so we can intercept events before they reach it. Another would be to add in a proxy layer that injects key/mouse event handlers into the HTML that's loaded in the Simple Browser, such that those events get forwarded out as window messages that can be handled in the same way as they are one layer up.

you can try this code in your iframe
document.addEventListener('keydown', function (event) {
        if ((event.metaKey || event.ctrlKey) && event.key === 'v') {
          document.execCommand('paste');
        }
      });


Decimal Support

Main change is checked in; we now have individual bugs to followup on remaining work.


Corrected a typo in README.md

Changed the "Live link" from https://abdullahch-anime-tracker-app.netlify.app/ to https://abdullahch-anime-tracker.netlify.app/

Thanks !


Link to CU protocol incorrect

New link location:
http://slotbaer.de/carrera-digital-124-132/9-cu-daten-protokoll.html
Thanks for the good work !!
Niels

Thanks!

Fixed.

Hi Thomas,
I got some of your examples working and can successfully read items from
the track on the arduino nano.
I don't understand yet why not all examples work but I'll let you know
after further debugging.
I was wondering how to send control packets to the cu.
When i read
http://slotbaer.de/carrera-digital-124-132/9-cu-daten-protokoll.html
I see that there should be a possibility but I am unsure how to drive the
line down from the arduino.
Did you already experiment with writing commands to the cars or cu from the
arduino ?
Practical ideas:

set speed of all the cars identical before starting
stop the track when a number of laps is achieved
record a round and relay it to a smarter ghost car which slows down and
accelerates for corners
sky is the limit ;-)

Vielen Dank,
Niels Sterrenburg
Op wo 9 dec. 2020 09:10 schreef Thomas Kemmer<EMAIL_ADDRESS>
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tkem/CarreraDigitalControlUnit/issues/8#issuecomment-741607707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASBSHPN2RS5AXJEVCQTS273ST4WH3ANCNFSM4USUJF3A
.


Windows store banner

Goes with https://github.com/Microsoft/pxt-adafruit/pull/483
TODO:

[x] Replace "get" icon with shopping bag icon
[x] Only show banner periodically
[x] Check for Internet connection when showing banner
[x] Add telemetry

Possibly also a merge conflict at some point.

@pelikhan @microsoftsam Ping for review of new code

@pelikhan @microsoftsam Ping for another review.  @pelikhan all initialization and display logic is now handled by the banner component; this should address your previous comments.


FluentIcon sometimes fails to render

🐛 Bug Report
We had the following scenario:

A virtualized FluentDataGrid with a column containing a FluentIcon in every row.
Icons were missing in some rows.

I think the problem is with the following code. If the icon content has changed, StateHasChanged() is called to force a re-render. However, since _shouldRender is not set to true, rendering is skipped.
    protected override async Task OnAfterRenderAsync(bool firstRender)
    {
        if (!_iconChanged)
        {
            return;
        }

        _iconChanged = false;
        var iconContent = await GetIconContentAsync();

        if (_previousIconContent != iconContent)
        {
            _svg = iconContent;
            _previousIconContent = iconContent;
            _size = Convert.ToInt32(Size);
            // I think `_shouldRender = true;` is needed here
            StateHasChanged();
        }
    }

We worked around the problem by deriving from FluentIcon and overriding ShouldRender() to always return true.

I'm adding the _shouldRender=true for v2.4.3 (should be out later today)


[ASK] Whether to drop support for Python 3.6

Description

As said at Release Python 3.6, Python 3.6 has now reached end-of-life.  I wonder if we should drop the support for Python 3.6 in the near future?
Other Comments
See also:

Status of Python branches
Time to Say Goodbye: Python 3.6 Is End-of-Life

As of March 8, 2022:

Let's see what it will be in 1 month, 2 months, 6 months.

April 8, 2022:

As of https://endoflife.date/python, Python 3.6 had already reached EOL 9 months before.

Right now we are not testing on 3.6, I think still most of the code works, but not 100% sure

As of Oct 2022

We discussed this point.
The approach we considered is, right now we are not getting problems with 3.6, and it is used by 40%, so we can keep it for now. If we start getting dependency issues, then we can reconsider removing 3.6.
@simonzhaoms do you like this approach, or do you think we should change it?

@miguelgfierro  Yeah, let's keep it for now.


chore: add dependabot and actions

semantic linting action
bump and release

Description of changes:
added linting, bump and release, and dependabot version checking of packages.

I have been contemplating on whether we could do anything better with e2e tests that would give us more confidence in version bumps compared to just running the unit tests. but that is TBD.

also we should probably block merging this PR until after we have the NPM registry token figured out.

I think we could split this in to two PRs:

Dependabot and Backstage upgrades, which don't need to rely only on automated tests right now we can manually test if needed
NPM release, which can be blocked until we can publish to NPM

I think we should start to get the plugin up-to-date with the latest dependencies now rather than wait for when we can release it. Otherwise we're just accumulating debt. We might as well exercise the automation we can until then.

good idea, will split the PR into two.

FWIW: wrt the version bump workflow, my expectation for the Proton plugin is that very few people are working off of the main branch, and it may be broken from time to time (for example, if a version bump breaks things!).  But personally, I'd rather automate most version bumps and then go manually fix things if that breaks anything.  I haven't figured out how to automate e2e/integration tests (agree it would be ideal), so that's why the release workflow requires acknowledgement of running e2e tests manually ahead of a release.

The pattern I've seen used in some Backstage repositories is to maintain an actual instance of the Backstage application:
https://github.com/RoadieHQ/roadie-backstage-plugins
Use Cypress to express test scenarios:
https://github.com/RoadieHQ/roadie-backstage-plugins/tree/main/packages/app/cypress/integration
Then invoke this through Actions:
https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/.github/workflows/e2e-tests.yml
I don't really want to have to do the first part, but I haven't been able to think of a great way to programmatically patch all the appropriate screens in a fresh Backstage app instance.

yeah i was thinking along those lines too.
It will be a pain to maintain an active backstage deployment but maybe worth the effort if we streamline an e2e testing strategy across all the plugins we want to maintain?

That seems to be somewhat what Roadie is doing.  They at least have a common Backstage app with all their plugins installed that is presumably used for testing: https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/packages/app/src/components/catalog/EntityPage.tsx#L53-L105


Snap package support (Feature/Enhancement)

I was thinking the setup and install process for Ubuntu and other Linux distros could be improved by having a Snap package version. If it's not a priority would you mind if I implemented the snap?
Creating a Snap
Create snaps from your preferred programming language.
Linux distros with Snap support

I'll close this issue and make a pull request.


Feature request: Ability to ignore/exclude files

In some cases I would like to disable to auto-sorting for some files, preferably by adding a comment at the top of the file to disable sorting. This is mostly for files with only imports and comments explaining what each do, e.g. the polyfill.ts file for Angular (see snippet below).
/**
 * This file includes polyfills needed by Angular and is loaded before the app.
 * You can add your own extra polyfills to this file.
 *
 * This file is divided into 2 sections:
 *   1. Browser polyfills. These are applied before loading ZoneJS and are sorted by browsers.
 *   2. Application imports. Files imported after ZoneJS that should be loaded before your main
 *      file.
 *
 * The current setup is for so-called "evergreen" browsers; the last versions of browsers that
 * automatically update themselves. This includes Safari >= 10, Chrome >= 55 (including Opera),
 * Edge >= 13 on the desktop, and iOS 10 and Chrome on mobile.
 *
 * Learn more in https://angular.io/docs/ts/latest/guide/browser-support.html
 */

/***************************************************************************************************
 * BROWSER POLYFILLS
 */

/** IE9, IE10 and IE11 requires all of the following polyfills. **/
// import 'core-js/es6/symbol';
// import 'core-js/es6/object';
// import 'core-js/es6/function';
// import 'core-js/es6/parse-int';
// import 'core-js/es6/parse-float';
// import 'core-js/es6/number';
// import 'core-js/es6/math';
// import 'core-js/es6/string';
// import 'core-js/es6/date';
// import 'core-js/es6/array';
// import 'core-js/es6/regexp';
// import 'core-js/es6/map';
// import 'core-js/es6/set';

/** IE10 and IE11 requires the following for NgClass support on SVG elements */
// import 'classlist.js';  // Run `npm install --save classlist.js`.

/** IE10 and IE11 requires the following to support `@angular/animation`. */
// import 'web-animations-js';  // Run `npm install --save web-animations-js`.

/** Evergreen browsers require these. **/
import 'core-js/es6/reflect';
import 'core-js/es7/reflect';

/** ALL Firefox browsers require the following to support `@angular/animation`. **/
// import 'web-animations-js';  // Run `npm install --save web-animations-js`.

/***************************************************************************************************
 * Zone JS is required by Angular itself.
 */
import 'zone.js/dist/zone';  // Included with Angular CLI.

/***************************************************************************************************
 * APPLICATION IMPORTS
 */

/**
 * Date, currency, decimal and percent pipes.
 * Needed for: All but Chrome, Firefox, Edge, IE11 and Safari 10
 */
// import 'intl';  // Run `npm install --save intl`.
/**
 * Need to import at least one locale-data with intl.
 */
// import 'intl/locale-data/jsonp/en';

+1. This would be very handy. I love the sort on save, but it causes problems on my app entrypoint file where the import order is important.

It would be really interesting. Is there anyone working on it?

With the release of Typescript 2.8 over a year ago, the ability to organize imports comes bundled with Typescript, in a better implementation than this one made for a hack week. As such, I have no further plans to maintain this project.
If for whatever reason you would like to take ownership of this repository, please let me know.


How to get pagewise results?

Hello team,
Lets assume we have 15 results to display on the slack thread and 5 results for page or click? When we click next results it should display next 5 results...so on.
Could you please route us to the guide on how to achieve them?

@seratch Any help on this?

I may not understand your question yet but you can call https://api.slack.com/methods/conversations.replies with limit/cursor parameters for pagination. If you're building yet another user interface to display messages in a Slack thread, you can use limit=5 and cursor=(response_metadata.next_cursor in the previous page response, none for the first page) for it.

Thanks, @seratch for the response. Please check the screenshot here from the example and let me know,

Assume, Slack message got 15 messages and displaying 5 (1 to 5) messages and when we click "Next 5 Results" it should get the next 5 results (6 to 10) from the buffer or so since we are not maintaining any sessions on the client end.

As I mentioned in the previous comment, you can get the position to fetch next as next_cursor in conversations.replies response. So, you can set the value to the "Next 5 Results" button.

conversations.replies is to get the messages from the thread or so right? But we are looking for posting messages page by page. Is this still apply?

hmm, I'm sorry to say this but I don't understand the question.
As this issue tracker is a place for the Python SDK, would you mind asking this type of questions to our support team and/or the people including me in the Slack Community workspace? It'd be appreciated if you could understand this.

Sure, I will post the question there.
Thanks @seratch

Thanks a lot for your understanding!


Update r.md

Updated r list

@JhayJahswiil  a PR to just clean up whitespace can't be accepted so i will be closing this.


Synthetic events cannot be edited

FloodAdapt version checks

[X] I have checked that this issue has not already been reported.
[X] I have checked that this bug exists on the latest version of FloodAdapt.

Reproducible Example
Create synthetic event and save it. Then edit and try to save it again, it's complaining that no water level was downloaded.
Current behaviour
see above
Desired behaviour
remove check for downloaded water level for synthetic events
Task list
This may already be covered in the hazard refactoring. I am just adding this as an issue so we check for this when the refactoring is merged.
Additional context
No response

check this with refactor

this is fixed in the refactor


Yank DiskArrays 0.4.0

The compat entries about the minimum required Julia version for Diskarrays 0.4.0 were not correct.

The compat entries about the minimum required Julia version for Diskarrays 0.4.0 were not correct.

Can't you fix the compat bounds, if that was the only issue?

We already did for DiskArrays 0.4.1 and later, but this still leaves 0.4.0 registered and would mean the package manager would resolve to this version for users using julia 1.8 or lower, which leads to a broken installation. We want to make sure julia <=1.8 users stick to DiskArray 0.3.x and I don't see a way to achieve this.

I'm still missing what prevents you from fixing the compat bounds in the registry.

I see, you mean like this: #104235


Unresponsive Poolboy

It is possible for Poolboy to get into an unresponsive state where the output of  [{Name, poolboy:status(Name)} || Name <- [request_pool, bucket_list_pool]]. never changes and therefore the pools can never drain.  Restarting Riak CS resolves the issue, but root causality is still unknown.

I will close this issue in the course of repo issue cleanup because
it is inactive for long and not reproducible. Please feel free to reopen if necessary.


need tools to test chaincode for non-determinism

Chaincode must not exhibit non-determinism.  We need tools that help developers catch non-deterministic patterns.
Possible sources of non-determinism, not exhaustive:

goroutines (explicit or implicitly created by libraries)
maps (use a randomized seed for keys, influences map iteration order)
time (duh)
interaction with the world (files, network connections, most other syscalls)
global variables (caching of state, also: singletons in libraries)
reified object addresses (i.e. reflect, printf of references)

Revival of this issue in/related: #1981


Parameter Tuning (Perf & Recall)

I explored NGT with some real dataset (100K 129d normalized vectors, top 100, 10 queries) with default parameters used in Command.cpp as below. I turned on AVX, OpenMP and opt optimization using GCC, but I didn't use NGT_SHARED_MEMORY_ALLOCATOR setting to keep the index in memory.
  NGT::Property prop;
  prop.edgeSizeForCreation = 10;
  prop.edgeSizeForSearch = 40;
  prop.batchSizeForCreation = 200;
  prop.insertionRadiusCoefficient = 1.1;
  prop.truncationThreshold = 0;
  prop.dimension = transDimension;;
  prop.threadPoolSize = 24;
  prop.pathAdjustmentInterval = 0;
  prop.dynamicEdgeSizeBase = 30;
  prop.buildTimeLimit = 0.0;
  prop.distanceType = NGT::Index::Property::DistanceType::DistanceTypeNormalizedCosine;

  NGT::GraphAndTreeIndex index(prop);
  index.append(transData.data(), dataSize);
  index.createIndex(24);

  vector<int64_t> outputIndexes(queryDataSize * k);

  for (size_t i = 0; i < queryDataSize; i++) {
    NGT::Object *query = index.allocateObject(
        transQueryData.data() + i * transDimension, transDimension);

    NGT::SearchContainer sc(*query);
    NGT::ObjectDistances objects;
    sc.setResults(&objects);
    sc.setSize(k);
    sc.setRadius(FLT_MAX);
    sc.setEpsilon(0.1);

    int64_t startTime = getWallTimeMS();
    index.search(sc);
    int64_t endTime = getWallTimeMS();

    LOG(INFO) << " query " << i
      << ": ts = " << endTime - startTime
      << " ms, # of result = " << objects.size();

    for (size_t j = 0; j < objects.size() && j < k; j++) {
      outputIndexes[i * k + j] = objects[j].id - 1;
    }
    index.deleteObject(query);
  }

Here is the test result
query 0: ts = 93 ms, # of result = 100
query 1: ts = 94 ms, # of result = 100
query 2: ts = 0 ms, # of result = 0
query 3: ts = 93 ms, # of result = 100
query 4: ts = 0 ms, # of result = 0
query 5: ts = 86 ms, # of result = 100
query 6: ts = 88 ms, # ofl result = 100
query 7: ts = 90 ms, # of result = 100
query 8: ts = 89 ms, # of result = 100
query 9: ts = 89 ms, # of result = 100

There are several issues in this test:

There is no result for two of ten queries. Did I miss anything in the parameter settings?
We need to create ObjectDistance for every query. Is there a way that we can reuse the objects to avoid allocating memory for wide-range and high-frequency queries?
The latency is high. As a comparison, it took 26ms in total to calculate ten results using CBLAS+OpenMP brute force matrix multiplication. I tried to tune the setEpsilon to be 0.03. It took effect to reduce the latency to half with a sacrifice on recall. However, it is still more than the brutal force on average. Are there other parameters or compilation options that I can try to improve the CPU performance?

Thanks!

There is no result for two of ten queries. Did I miss anything in the parameter settings?

I do not have any idea about that at this moment.
index.search(sc);

Could you exchange the line above for the line below and run again?
index.linearSearch(sc);

linearSearch just executes linear search without the use of the index. If the result is the same as the previous result, it is caused by invalid queries. If not, no result is caused by the index.

Is there a way that we can reuse the objects to avoid allocating memory for wide-range and high-frequency queries?

You can move the line below to the outside of the for statement.
    NGT::ObjectDistances objects;

The line below might be needed within the for statement.
   objects.clear()

Are there other parameters or compilation options that I can try to improve the CPU performance?

You may want to use ONNG as below.
https://github.com/yahoojapan/NGT/tree/master/bin/ngt#onng
You may want to open the index with a read only flag as below to improve the search performance.
https://github.com/yahoojapan/NGT/blob/master/lib/NGT/Command.cpp#L402

Thank you, @masajiro! It is very helpful.

There is no result for two of ten queries. Did I miss anything in the parameter settings?

I do not have any idea about that at this moment.
index.search(sc);

Could you exchange the line above for the line below and run again?
index.linearSearch(sc);

linearSearch just executes linear search without the use of the index. If the result is the same as the previous result, it is caused by invalid queries. If not, no result is caused by the index.

For the first issue, I found it is actually related to invalid query data. Thanks for your suggestions on debugging this situation.

Is there a way that we can reuse the objects to avoid allocating memory for wide-range and high-frequency queries?

You can move the line below to the outside of the for statement.
    NGT::ObjectDistances objects;

The line below might be needed within the for statement.
   objects.clear()

I tried with your suggestions. I noticed that ObjectDistances inherits from vector<ObjectDistance> and clearing the vector incurs additional deallocation cost across all results – it is substantial when we have tens of thousands results. On the other hand, the ObjectDistance seems could be reused given it only includes id and distance pair.
If it is reasonable to you to reuse the ObjectDistance for reducing memory cost, I can help with a pull request along the way.

Are there other parameters or compilation options that I can try to improve the CPU performance?

You may want to use ONNG as below.
https://github.com/yahoojapan/NGT/tree/master/bin/ngt#onng
You may want to open the index with a read only flag as below to improve the search performance.
https://github.com/yahoojapan/NGT/blob/master/lib/NGT/Command.cpp#L402

I will further explore, thanks.
At the same time, I noticed two small issues:

The compiling warning: there are some repetitive declarations for variables that shadow variables in the parent scope. It is triggered some GCC warnings in a verbose mode, and it would be great if we could clear up as well.
I noticed that we use iostream to output log outside of the Command file, and I have not found a flag that we can turn off the logging. It lags the perf and seems distracting. Did I miss anything? Or could we add a flag so that we can disable it when needed?

Did I miss anything? Or could we add a flag so that we can disable it when needed?

There is no flag to turn off the logging. I am going to add a kind of a flag to handle the logging in the near future.

I noticed that we use iostream to output log outside of the Command file, and I have not found a flag that we can turn off the logging. It lags the perf and seems distracting. Did I miss anything? Or could we add a flag so that we can disable it when needed?

I have added arguments to Index and Optimizer to disable the logging.

*The compiling warning: there are some repetitive declarations for variables that shadow variables in the parent scope. It is triggered some GCC warnings in a verbose mode, and it would be great if we could clear up as well.

I removed most of the warnings that I found.


Removed extra RETRY_DELAY definition.

Cleanup.  Related issue, #571
Related issue(s):
Fixes #

@ebadiere please rebase

Not needed.


Allow whitespace in subject name.

Fixes #18

BTW, I don't have commit access so someone has to merge these PRs for me once they are approved or give me access so I can do it myself.

Oops! Just gave you access now.


Introduce unleash-docker as a sperate submodule.

this is related to #135 and will solves #126
Before this can be merged we need to solve:

[ ] run database migrations inside the docker-container.
[ ] figure out a way yo automatically create a new docker-image each time unleash-server is released. This could probably be a publish script or something.

Coverage remained the same at 93.072% when pulling 4041c57c91255fb0ccb3edc0ffb416135bfa730d on docker_as_seperate_module into 87d3e755df89fdaf7d4598060b86afc65358229d on master.

Im starting a lerna branch, could you maybe add this to a folder called packages, so it will play nicely?

yes i can do that =)

Coverage remained the same at 93.072% when pulling d27f1ac093d62302af6a4569c8f5c904a004be53 on docker_as_seperate_module into 87d3e755df89fdaf7d4598060b86afc65358229d on master.

Coverage remained the same at 93.072% when pulling 20f0a20c0002982f7fb35b554d7a2f8f9ace4137 on docker_as_seperate_module into 87d3e755df89fdaf7d4598060b86afc65358229d on master.


Andriod Automation TouchAction issue

Hello guys,
I'm trying to performing TouchActions,
=> this is my code
		String originalContext = appiumDriver.getContext();
		appiumDriver.context("NATIVE_APP");
		Thread.sleep(1500);
		// Perform TouchAction
		new TouchAction(appiumDriver)
		.press(PointOption.point(673, 1526))
		.release()
		.perform();

=> but I got exception
org.openqa.selenium.UnsupportedCommandException: The requested resource could not be found, or a request was received using an HTTP method that is not supported by the mapped resource
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'  and
Failed to initialize Appium session: The requested resource could not be found, or a request was received using an HTTP method that is not supported by the mapped resource
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
System info: host: 'SURESH', ip: '<IP_ADDRESS>', os.name: 'Windows 10', os.arch: 'amd64', os.version: '10.0', java.version: '15'
Driver info: io.appium.java_client.AppiumDriver
Capabilities {appActivity: com.miui.calculator.cal.Cal..., appPackage: com.miui.calculator, autoGrantPermissions: true, automationName: UiAutomator2, databaseEnabled: false, desired: {appActivity: com.miui.calculator.cal.Cal..., appPackage: com.miui.calculator, autoGrantPermissions: true, automationName: UiAutomator2, deviceName: suresh, newCommandTimeout: 60, platformName: android, platformVersion: 12 SKQ1.211019.001, udid: d27d6eef}, deviceApiLevel: 31, deviceManufacturer: Xiaomi, deviceModel: POCO M2 Pro, deviceName: d27d6eef, deviceScreenDensity: 440, deviceScreenSize: 1080x2400, deviceUDID: d27d6eef, javascriptEnabled: true, locationContextEnabled: false, networkConnectionEnabled: true, newCommandTimeout: 60, pixelRatio: 2.75, platform: LINUX, platformName: Android, platformVersion: 12, statBarHeight: 102, takesScreenshot: true, udid: d27d6eef, viewportRect: {height: 2298, left: 0, top: 102, width: 1080}, warnings: {}, webStorageEnabled: false}
Session ID: 96241ffe-ae31-4a06-9655-290718105018
=> can you guide me guys, how to resolve this issue.... i need to enable any option in developer options ?

It was because the class was deprecated and removed from recent UIA2 driver, which is flutter driver uses.
I guess you use Java client, then https://github.com/appium/java-client/blob/master/docs/v7-to-v8-migration-guide.md#touch-actions would help.

It was because the class was deprecated and removed from recent UIA2 driver, which is flutter driver uses.
I guess you use Java client, then https://github.com/appium/java-client/blob/master/docs/v7-to-v8-migration-guide.md#touch-actions would help.

thank you this helps me, can you guide me in android automation how to upload a file? in web automation we use robot class right. but in andriod any class is there?

I'd recommend exploring the java repository's test code, or asking such question in https://discuss.appium.io/ (where is general question forum)


remove pricing from docs

since we now show the pricing table in the platform, we can remove it from the docs, so we don't have duplicated info

note that our website also points to the docs, we'll have to remove that as well: https://github.com/ploomber/ploomber.iol


Update window layout to work on macOS 10.14 (Mojave)

It took me a while to figure out what was going on in the view hierarchy, causing the clock to not get displayed on Mojave. Ideally I'd like to move to an approach that puts the clock in a more standard location in the view hierarchy that would be more robust to OS updates (such as contentView). But after experimenting for a while, I don't have any clear idea of how to do that while maintaining the visual design and behavior.
So instead I was able to adapt the approach for Mojave by simply making the clock view a sibling of the close button.
I also simplified a few lines of code and added comments.

I realize now my description wasn't clear — my intention with this pull request was not to fix all of the bugs when running on Mojave, but rather to fix the specific, major problem that when the app is built using Xcode in Mojave, the timer window is completely blank:

So this pull request is a necessary first step for any further bug fixes or development.

@robinstewart Yes, it's completely broken right now. Do you think you could take a look at it?

@karbassi Yes, this pull request already contains the fix! It just needs to be merged in.
(I changed the way the clock UI is inserted into the window view hierarchy, which will hopefully be more robust to future OS updates as well.)

Works for me. Merging!


correct proton-native import in area.js example

All of the single files reference src/ on purpose so that it is easier to test with the codebase.


Add handling of implementations to forc doc

Currently ImplTraits are commented out and unhandled. I mention in a comment here that we should find a way to link implementations to their respective documents. This may mean either a hacky solution or update the AST to provide the implementations on said types.

Tentatively added to current milestone :)


Move EnvToSyspropMappings.properties to solrj module

I discovered that the properties file EnvToSyspropMappings.properties required by the new EnvUtils (SOLR-15960) was located in core. But since EnvUtils class is in solrj and will fail static init() if the property file is not found (perhaps it should not fail?) then when solrj is used on client side without solr-core, this will cause an exception.
I do not have an app where this actually occurs, but I simulated it by renaming the property file:
java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:209)
	at org.apache.solr.common.util.EnvUtils.<clinit>(EnvUtils.java:51)

This PR simply moves the property file to the solrj module.

I discovered this by chance. Obviously all our solrJ tests run with access to solr-core on classpath?
We should likely have a test with only SolrJ and its dependencies on classpath?

Created SOLR-17188 to track creation of such as new test

Related JIRA just opened: https://issues.apache.org/jira/browse/SOLR-17199


Make logger property public instead of private in BasicTracer class

Reference: https://github.com/open-telemetry/opentelemetry-js/blob/8ea2016bf40024f0cf492d9f7771a3a92009db5f/packages/opentelemetry-basic-tracer/src/BasicTracer.ts#L47
Related to this issue: https://github.com/open-telemetry/opentelemetry-js/issues/193
Logger is private in BasicTracer class and if we make it public we could avoid this issue above. Otherwise, we have to pass logger everywhere because I believe we will have several places like #193 in future.
I would like your feedback on that. Thanks in advance.

Do we expect that end users will want to access it? Or at least are we OK if they do?
If so, I'm fine with making it public.


Update Facebook for iOS SDK to version 14.0

Since the release of the most recent version of the Facebook iOS SDK, it's impossible to track install events for iOS 14 or higher on Facebook's platform.

Please update this ASAP.

I also ask @SotoiGhost and @rmarinho if the project is abandoned, since it's been behind the official SDK for a few months.

#228   https://github.com/xamarin/FacebookComponents/issues/228

I attempted to update this to get events working with iOS 15.5, but I don't really know what I am doing (frankly).
You can find my fork here: https://github.com/kevin-hine-innis/FacebookComponents
My fork will build the nuget packages and samples with the 14.1.0 Facebook SDKs, and everything looks correct to me, but not everything works...
So I can't do a pull request because I can't update the API definitions.
Also I still can't log events on iOS 15.5 but it logs events on iOS 13.7. I have no idea if this is because my Nuget is bad, or because I am not interacting with Facebook correctly (perhaps a combination of both?).
You can see my implementation here: https://github.com/kevin-hine-innis/Xamarin.Facebook.IOS.CoreKit-SDK-14.1.0-Fail
That project already includes the 14.1.0 CoreKit nuget package.
If you know what I am doing wrong, please let me know. Big Thanks!
If you know Objective-C and are interested in helping me / the rest of us, please consider updating the API definitions.
See "Creating Bindings with Objective Sharpie": https://docs.microsoft.com/en-us/xamarin/cross-platform/macios/binding/objective-sharpie/
Maybe @SotoiGhost would be willing to help if he sees enough community effort to update this?
I simply have no experience with the Facebook SDKs and very little experience with Objective-C, so I'm pretty useless here.

I'm also waiting for a new version of the bindings supporting Facebook SDK version 14!!!

This is a critical thing! waiting for an update as well... Is there any ETA?

Any news?

Any updates? 😢

Hi everybody,,, Any news about this update ? I am trying to install 12.2.X version of Xamarin.Faceboo.iOS But I am getting dependency errors... If I install all the dependencies first, I cant install the main library.
I am getting this error:
Severity	Code	Description	Project	File	Line	Suppression State
Error Could not find a part of the path 'C:\Users\marcelo_oliveira\.nuget\packages\xamarin.facebook.sharekit.ios\12.2.0\lib\xamarinios10\Facebook.ShareKit.resources\FBSDKShareKit.xcframework\ios-arm64_i386_x86_64-simulator\FBSDKShareKit.framework\Modules\FBSDKShareKit.swiftmodule\arm64-apple-ios-simulator.swiftdoc'.

Facebook/Meta is forcing us to update our app, to send user informations in a hash format, and to implement a hash logic, I need to reference the class FBSDKAppEvents But up to <IP_ADDRESS> version, this class doesnt exists.
So, If I try to update to 12.2.X, I came into this situation...
Error trying to update library to the last version OR a class missing in the version which I can install without error (<IP_ADDRESS>) !!!
We have an urgent demand to update our app, cause Facebook/Meta is obliging us to hash the user data, before send.
Please, anyone has a position about it ?

I attempted to update this to get events working with iOS 15.5, but I don't really know what I am doing (frankly). You can find my fork here: https://github.com/kevin-hine-innis/FacebookComponents
My fork will build the nuget packages and samples with the 14.1.0 Facebook SDKs, and everything looks correct to me, but not everything works... So I can't do a pull request because I can't update the API definitions. Also I still can't log events on iOS 15.5 but it logs events on iOS 13.7. I have no idea if this is because my Nuget is bad, or because I am not interacting with Facebook correctly (perhaps a combination of both?).
You can see my implementation here: https://github.com/kevin-hine-innis/Xamarin.Facebook.IOS.CoreKit-SDK-14.1.0-Fail That project already includes the 14.1.0 CoreKit nuget package. If you know what I am doing wrong, please let me know. Big Thanks!
If you know Objective-C and are interested in helping me / the rest of us, please consider updating the API definitions. See "Creating Bindings with Objective Sharpie": https://docs.microsoft.com/en-us/xamarin/cross-platform/macios/binding/objective-sharpie/
Maybe @SotoiGhost would be willing to help if he sees enough community effort to update this?
I simply have no experience with the Facebook SDKs and very little experience with Objective-C, so I'm pretty useless here.

Hello @kevin-hine-innis, have you found any alternative?
Or, has anyone had success trying to update the nugget locally?

Hello @kevin-hine-innis, have you found any alternative? Or, has anyone had success trying to update the nugget locally?

I have heard nothing more and I have not had time to revisit this.
My fork does build the packages though, so it might work if you want to try.
I'm like 80% that my build works (plus or minus any broken api definitions). My employer asked me to track installs from facebook campaigns, but I am not sure this works even with the official facebook SDKs (Apple changed the permissions requirements quite a lot).  Eventually it just wasn't worth the time or money and we dropped it. So, I really have no further incentive to test this.
If someone could test my fork on iOS 15+ I would be willing to try updating the API definitions. Then I would feel confident making a pull request, or even releasing an unofficial nuget build.

As long as the pipeline is still private no one will pick up this project to update or fix this.
@SotoiGhost @rmarinho

I'm having problem to use:
`if (Control == null)
{
var fbLoginBtnView = e.NewElement as FacebookLoginButton;
var fbLoginbBtnCtrl = new LoginButton
{
Permissions = fbLoginBtnView.Permissions
};
            fbLoginbBtnCtrl.Completed += AuthCompleted;
            SetNativeControl(fbLoginbBtnCtrl);
        }`

Error CS1061: 'LoginButton' does not contain a definition for 'Completed' and no accessible extension method 'Completed' accepting a first argument of type 'LoginButton' could be found (are you missing a using directive or an assembly reference?) (CS1061)

@dtaylorus Thanks a lot for the tip, since I had the chance to use the code but i didn't work. I would like to know if you can give us more tips to get it work, in my case I made an attempt you can find it here: if you have the chance to look at it would be the best, thanks regards.
https://github.com/Luisalvarenga/FacebookSDKTestXamarin

I created a sample project at https://github.com/hotchaipro/HotChai.Bindings. You will need to following the Getting Started instructions at https://developers.facebook.com/docs/ios/getting-started/ to configure the sample project with a Facebook App ID and client token in order to make the sample work.

@dtaylorus It's interesting that we can actually set and use xcframeworks inside iOS projects, the example you shared works wonderful with all instructions taken but I am concerned that is being set up on net 7.0. Since I am using the old way xamarin.iOS I tried to make it work, but the only problem I encounter is that it crashes on the start up due to a no reference of a instance object, in case you can share more time you could check my example : https://github.com/Luisalvarenga/FacebookSDKTestXamarin-

@Luisalvarenga Yes, you can use xcframeworks without a separate binding project. You're missing the xcframeworks in your linked project, though. You need to add the NativeDependencies folder containing the xcframeworks to your project.
As a side note for how I obtained the binding files, when you build a binding project you can inspect the obj folder to find the actual C# bindings generated by the build process. You can also just copy the disassembled source code by installing an older version of the Nuget and inspecting the assembly since the bindings don't change very often and work just fine with newer frameworks. I simply copied these files into my project so I could use the xcframeworks directly and get the latest native releases. You can still create a separate binding project if you like, but it seems like unnecessary overhead to me. And in my opinion it's much easier to fix up the actual C# binding code if it's generated incorrectly than it is to try to apply XML transforms to the obscure intermediate binding language as recommended in binding projects.
If you can, I do recommend you move to .NET 6+ since a lot of Nuget packages being actively maintained are moving forward and not providing backward compatible Xamarin.iOS versions.
Good luck!

Here's how you can use the latest Facebook SDK for iOS to track installs without having to depend on someone to update this Nuget package:

Download and extract the latest FacebookSDK_Dynamic.xcframework.zip file from https://github.com/facebook/facebook-ios-sdk/releases
Copy the FBSDKCoreKit_Basics.xcframework, FBAEMKit.xcframework, and FBSDKCoreKit.xcframework folders into a new NativeDependencies folder in your project.
Add the following ItemGroup into your csproj file:

<ItemGroup>
	<NativeReference Include="NativeDependencies\FBSDKCoreKit_Basics.xcframework">
		<Kind>Framework</Kind>
		<SmartLink>False</SmartLink>
		<LinkerFlags>-ObjC</LinkerFlags>
	</NativeReference>
	<NativeReference Include="NativeDependencies\FBAEMKit.xcframework">
		<Kind>Framework</Kind>
		<SmartLink>False</SmartLink>
		<LinkerFlags>-ObjC</LinkerFlags>
	</NativeReference>
	<NativeReference Include="NativeDependencies\FBSDKCoreKit.xcframework">
		<Kind>Framework</Kind>
		<SmartLink>False</SmartLink>
		<LinkerFlags>-ObjC</LinkerFlags>
		<WeakFrameworks>Accelerate Accounts Social Security QuartzCore CoreGraphics UIKit Foundation AudioToolbox WebKit</WeakFrameworks>
	</NativeReference>
</ItemGroup>

Add the files FacebookCoreKit.cs and FacebookApiDefinition.cs from https://gist.github.com/dtaylorus/0468be7372ba517db09c1bbfa68a927a
(NOTE: These bindings are updated for .NET 6/7. See the previous revision of the Gist for older Xamarin.iOS project bindings.)
Now you can use the Facebook CoreKit SDK as usual:

Facebook.CoreKit.ApplicationDelegate.InitializeSdk(options);
Facebook.CoreKit.ApplicationDelegate.SharedInstance.FinishedLaunching(application, options);

Thank you for your tips! Since more than two years passed, is there a chance you show us the ApiDefinition classes for other libraries (LoginKit, ShareKit, etc) targeting Xamarin.iOS?


Panic with multiple states

How could I make it so that when "panic" has multiple states the programme would not terminate?

Not quite sure what you mean.
Can you elaborate a bit more on what you mean? Maybe give an example?


DevOps Mutualization SIG Meeting - January 20, 2022

Date
20 JAN 2022 - 12pm ET / 5pm GMT
Untracked attendees

Name
Firm
Comment

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene, roll call, welcome new people
[ ] Display FINOS Antitrust Policy summary slide
[ ] Approve previous meeting minutes
[ ] Announce outcome of vote - Proposed changes to SIG operating model in 2022 - use public Github repos and discussions - vote to open SIG work and initiatives as default taken here (but with the option of private) - https://github.com/finos/devops-mutualization/issues/38#issuecomment-996024508
[ ] FINOS GitProxy update and community Q&A with @grovesy, Project Lead Maintainer from Citi (20 to 25 mins)
[ ] Determine if DevOps Mutualization is a good venue for a Waltz demo as discussed with @davidwatkins73 in https://github.com/finos/waltz/issues/5787
[ ] Question asked on Waltz project meeting : What are the deployment options being used across other banks and projects? cc @davidwatkins73 https://github.com/finos/waltz/issues/5787
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

WebEx info
Webex:
https://finos.webex.com/finos/j.php?MTID=md62056638ba05fbea86b9582df94f807
Dial-in

US +1-415-655-0003 US Toll
UK +44-20319-88141 UK Toll
Access code:<PHONE_NUMBER>

Github Repo: https://github.com/finos/devops-mutualization/
Mailing List: Email<EMAIL_ADDRESS>to subscribe to our mailing list

Hi @ashukla13 and @robbkeayes
I have created the DevOps Mutualization agenda for Thursday 20th January 2022 at 12pm ET / 5pm GMT as @grovesy from Citi would like to update the DevOps Mutualization community on the progress made to GitProxy.
I hope starting to set the agenda this far in advance helps.
Kind regards,
James.

hello!

Hello 👋🏻

Hi

hello !

Hey 👋🏼

Hi

HI everyone

Hi!

Hello, Jane @ FINOS here

Hello from California

Here.


Sc-11107: organization list api implementation & minor fixes

Scope of changes
This add, organization list API implementation in UI and some minor fixes in the collaborator list component
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
[
https://app.shortcut.com/rotational/story/11107/implement-the-organization-list-api-in-ui
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report
Base: 44.61% // Head: 37.96% // Decreases project coverage by -6.65% :warning:

Coverage data is based on head (f026b7c) compared to base (71d4485).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   44.61%   37.96%   -6.66%
==========================================
  Files         667      168     -499
  Lines       24297     2568   -21729
  Branches     1517      667     -850
==========================================
- Hits        10841      975    -9866
+ Misses      12071     1409   -10662
+ Partials     1385      184    -1201

Flag
Coverage Δ

unittests
37.96% <ø> (-6.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

web/gds-user-ui/src/application/routes/routes.ts

...ors/DeleteCollaborator/DeleteCollaboratorModal.tsx

...gds-user-ui/src/components/Collaborators/index.tsx

...github.com/trisacrypto/directory/pkg/bff/server.go

...components/CertificateManagement/StatisticCard.tsx

web/gds-user-ui/src/utils/formate-date.ts

web/gds-user-ui/src/utils/getColorScheme.ts

.../github.com/trisacrypto/directory/pkg/trtl/trtl.go

...thub.com/trisacrypto/directory/pkg/bff/parallel.go

...ser-ui/src/components/NameIdentification/index.tsx

... and 489 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


drivers: adc: stm32g4 also have a shared IRQ for ADC instances

The adc1 & 2 of the stm32g4 devices share the same irq
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>Signed-off-by: Otavio Salvador<EMAIL_ADDRESS>

cc @nandojve @FRASTM


Typechecking fixes - [merged]

In GitLab by @waxlamp on Jun 12, 2020, 17:11
Merges type-fixes -> development

In GitLab by @waxlamp on Jun 12, 2020, 17:12
@Schumann please review.
In particular, please pay special attention to places where I have changed the code (as opposed to simply adding type annotations).
I will call out in comments some spots where I am concerned about the changes I've made.

In GitLab by @waxlamp on Jun 12, 2020, 17:12
marked as a Work In Progress

In GitLab by @waxlamp on Jun 12, 2020, 17:35
unmarked as a Work In Progress

In GitLab by @waxlamp on Jun 12, 2020, 17:36
added 1 commit
52705494 - Run formatter
Compare with previous version

In GitLab by @waxlamp on Jun 12, 2020, 17:36
added 3 commits
52705494...825a95ab - 2 commits from branch developmentf11a0c09 - Merge remote-tracking branch 'origin/development' into type-fixes
Compare with previous version

In GitLab by @waxlamp on Jun 12, 2020, 17:38
Commented on framework/dataset.py line 67
I have a feeling that this function should take a list for extensions, which is then converted to a tuple for purposes of passing to .endswith().

In GitLab by @waxlamp on Jun 12, 2020, 17:39
Commented on framework/dataset.py line 217
These were changed to avoid having to make the type of these values Optional, which causes trouble at their points of use.
The codebase doesn't seem to rely on these values every actually being None.

In GitLab by @waxlamp on Jun 12, 2020, 17:40
Commented on framework/dataset.py line 492
I can't figure out why these lines don't typecheck properly. I suspect it could be because line 494 uses an underscore method (which generally indicates it's not part of the public API).

In GitLab by @waxlamp on Jun 12, 2020, 17:41
Commented on framework/dataset.py line 515
The complex return type on this function indicates that it might be better refactored into simpler pieces, but this does pass typechecking, so no urgency on this.

In GitLab by @waxlamp on Jun 12, 2020, 17:42
Commented on framework/dataset.py line 647
This refactoring simplifies the following code, but also passes typechecking (even though the original should pass, it doesn't, possibly because the syntactic analysis doesn't quite work, and possibly because of the assignment to self.targets[ind] from line 644/658 below).

In GitLab by @waxlamp on Jun 12, 2020, 17:43
Commented on framework/dataset.py line 674
The odd/complex typing of predictions indicates some sort of excess complexity in this function that maybe should be addressed.

In GitLab by @waxlamp on Jun 12, 2020, 17:44
Pipelines are passing in full now!

In GitLab by @Schumann on Jun 17, 2020, 05:29
@cfunk1210 The actual code changes are all in dataset.py. Please take a look.

In GitLab by @Schumann on Jun 17, 2020, 05:32
Overall, It looks good to me. All of the strangeness in dataset.py can be dealt with in the future (At some point, we will need to decide that either dataset needs major work to make it generally useful, or it should be pulled out of the framework into learn only).

In GitLab by @waxlamp on Jun 17, 2020, 10:29
Thanks Eric. I will open a review thread for Chris.

In GitLab by @waxlamp on Jun 17, 2020, 10:30
@cfunk1210 please review
If you can respond to my inline comments in dataset.py, that would be great. Based on your responses, for each comment I'll either open a new issue, address things immediately, or resolve not to worry about it.
If we do spin dataset.py out into Learn, then obviously this would all be moot.

In GitLab by @cfunk1210 on Jun 17, 2020, 11:48
Commented on framework/dataset.py line 67
The length of the Tuple isn't limited.  I would use List[str] to specify this.  I was copying pytorch here for their vision dataset but endswith might work.  Not sure why they didn't use that.

In GitLab by @cfunk1210 on Jun 17, 2020, 11:49
Commented on framework/dataset.py line 217
Have you tested this with using None?  I would be worried about and len(x) == 0 later in the code.

In GitLab by @cfunk1210 on Jun 17, 2020, 11:51
Commented on framework/dataset.py line 515
Why not just use the "Any" type.  Isn't this an instance where being overly verbose would make it less clear?

In GitLab by @cfunk1210 on Jun 17, 2020, 11:54
Commented on framework/dataset.py line 647
The original seems fine to be but this doesn't seem to make much of a change.

In GitLab by @cfunk1210 on Jun 17, 2020, 11:57
Commented on framework/dataset.py line 674
This takes the prediction from the algorithm and uses the dataset to format it correctly.

In GitLab by @cfunk1210 on Jun 17, 2020, 12:00
Commented on framework/dataset.py line 492
Sure,  this is was a slightly modified version of the PyTorch collate_batch function to enable it to handle testing and unlabeled points (where the usual way is to have different datasets for each, but we combined them to make the code simpler.

In GitLab by @waxlamp on Jun 17, 2020, 13:40
Commented on framework/dataset.py line 67
I will make the appropriate update to the code.

In GitLab by @waxlamp on Jun 17, 2020, 13:40
Commented on framework/dataset.py line 217
I have not--as our Learn expert, would you mind running the tests to make sure this will be ok?

In GitLab by @waxlamp on Jun 17, 2020, 13:41
Commented on framework/dataset.py line 492
Ok. I am going to resolve this thread because it's likely fine as-is.

In GitLab by @waxlamp on Jun 17, 2020, 13:43
Commented on framework/dataset.py line 515
The problem with returning Any from a function is that it breaks typechecking for functions calling this one. On the other hand, the very fact that the return type is this complex is a clue that perhaps some refactoring would increase the testability, readability, and general reliability of the code in question.
Your point about verbosity is important, but to replace the verbosity here with Any is essentially sweeping a problem under the rug. We should decide what to do here--leaving it just like this is a perfectly acceptable answer.

In GitLab by @cfunk1210 on Jun 17, 2020, 13:48
Commented on framework/dataset.py line 515
Could we use any and leave a todo/issue on this for future refactoring?

In GitLab by @waxlamp on Jun 17, 2020, 14:01
Commented on framework/dataset.py line 674
Right, but the predictions can either be a tuple of lists, or a list. That seems a bit strange, and maybe there's a way to simplify that.

In GitLab by @waxlamp on Jun 17, 2020, 14:03
Commented on framework/dataset.py line 515
I think we should leave this type annotation as it is and then open that issue.

In GitLab by @waxlamp on Jun 17, 2020, 14:04
Commented on framework/dataset.py line 674
Actually this seems to be linked to the return type of dummy_data() above. I'll open an issue to address both at once, and then resolve these threads.

In GitLab by @waxlamp on Jun 17, 2020, 14:05
created #34 to continue this discussion

In GitLab by @waxlamp on Jun 17, 2020, 14:05
Commented on framework/dataset.py line 67
created #34 to continue this discussion

In GitLab by @waxlamp on Jun 17, 2020, 14:05
Commented on framework/dataset.py line 217
created #34 to continue this discussion

In GitLab by @waxlamp on Jun 17, 2020, 14:05
Commented on framework/dataset.py line 515
created #34 to continue this discussion

In GitLab by @waxlamp on Jun 17, 2020, 14:05
Commented on framework/dataset.py line 674
created #34 to continue this discussion

In GitLab by @waxlamp on Jun 17, 2020, 14:05
resolved all threads

In GitLab by @waxlamp on Jun 17, 2020, 14:05
created #34 to continue this discussion

In GitLab by @waxlamp on Jun 17, 2020, 14:07
I was experimenting with the "resolve these threads by opening a new issue" feature and kind of did it wrong, oops. Sorry about that. Live and learn.
I've unresolved the improperly resolved threads.

In GitLab by @waxlamp on Jun 17, 2020, 14:21
Commented on framework/dataset.py line 67
changed this line in version 4 of the diff

In GitLab by @waxlamp on Jun 17, 2020, 14:21
added 1 commit
0008f373 - Use a list in place of a tuple for file extension checking
Compare with previous version

In GitLab by @waxlamp on Jun 17, 2020, 14:31
@Schumann, can you resolve this thread if you're good to go?

In GitLab by @as6520 on Jul 10, 2020, 09:07
@cfunk1210, @waxlamp is this branch ready to merged or are there still unresolved issues with it?

In GitLab by @cfunk1210 on Jul 10, 2020, 09:20
It hasn't been tested yet

In GitLab by @waxlamp on Jul 10, 2020, 10:29
@cfunk1210, from the open threads, it seems like the ball may be in your court.
Can you test this to make sure it works properly? If so, we should merge and move on, fixing errors as they pop up. There was also talk of moving some of the code under consideration into the Learn repository, which would be a further reason to move quickly on this.
Please let me know what you think, and we can draft a plan to move this forward.

In GitLab by @waxlamp on Jul 17, 2020, 16:23
added 5 commits
0008f373...fc81cc5c - 4 commits from branch development49712d40 - Merge remote-tracking branch 'origin/development' into type-fixes
Compare with previous version

In GitLab by @waxlamp on Jul 17, 2020, 18:24
added 11 commits
49712d40...8bde724e - 10 commits from branch development262fe9de - Merge remote-tracking branch 'origin/development' into type-fixes
Compare with previous version

In GitLab by @waxlamp on Jul 17, 2020, 18:30
added 1 commit
4f44af3d - Fix lint errors
Compare with previous version

In GitLab by @waxlamp on Jul 17, 2020, 18:42
@cfunk1210, if you could greenlight this MR asap, that would be great. Whenever new development happens on other branches, this branch tends to go out of date, so I'd like to merge it asap. It should be low-burden to do so, as we're going to spin the files out into other repos anyway and there any fixes that are required can be made.
Thanks!

In GitLab by @cfunk1210 on Jul 20, 2020, 12:21
Ok, tested it out and worked.  I'm OK-ing the merge.

In GitLab by @waxlamp on Jul 27, 2020, 14:17
mentioned in commit 3bc48c55c6a8988e5a5e1b1034762ddb04c0653f

In GitLab by @waxlamp on Jul 27, 2020, 14:17
merged


resolutionScale related lighting issue

Sandcastle example: sandcastle
Browser: Chrome 78
Operating System: Windows 10 1903
Monitor: 14 inch 3200x1800 250% zoom
Browser Zoom: 100%
Set "viewer.scene.globe.enableLighting = true" can replicate the problem. Happens only when devicePixelRatio not equals 1.
And, images near the pole seem to be strange.

@vinstics this is a known issue. We have a fix for it here: https://github.com/AnalyticalGraphicsInc/cesium/pull/8351
In the mean time you can fix it by setting:
viewer.resolutionScale = 1.0 / window.devicePixelRatio;

This brings the resolutionScale back to the old behavior as of 1.61 (see the explanation of this change here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CHANGES.md#additions-tada-2).

@OmarShehata Thanks a lot. I'll turn off lighting and wait for the fix since I have to render model at native device resolution. By the way how about the image near the pole, is it normal?

@vinstics I believe the poles look like that when the imagery layer does not cover the poles, and so CesiumJS will stretch the pixels to fill the gap.


User's appointments page improvement, please

I want to make appointment page looks responsive like admin one

like admin one, please help
appointment page (user) is not that much good, please help

You can change your css as you want

sir, please help this time, what css styling i need to do,  pleas help


Update global proposal description and fix spec link

Landing this fix; we could change the name of the proposal to globalThis in a follow-on if @ljharb approves.


More clear error reporting iIf port 8080 is blocked

Took me 20min just now to realize why process-compose simply exited with exit code 1 when I try to run my yaml file: port 8080 is already taken on my machine.

Why does it try to bind to this port? Is this configurable?
I had to find out that the log file is in /etc/process-compose-$(whoami).log and that the error is there. Since this is an initialization error, wouldn't it be more user-friendly to display it directly on stderr?

Fixed. Will be part of the next release.

Fixed in v0.81.4


support packageurl-js >= 2.0.0

currently supporting packageurl-js >=0.0.6 <0.0.8 || ^1
goal: have support for ^2 added, while still maintaining support for the other versions that were supported already.

see release notes: https://github.com/npm/normalize-package-data/releases
see changes: https://github.com/package-url/packageurl-js/compare/v1.2.1...v2.0.0

done via  #1142


Pipe: Method to RunAnalysis/RunDesign on the opened model

public void FemDesign.ApplicationConnection.RunAnalysis(Model model, Analysis analysis);

[x] RunAnalysis
[x] RunDesign

@Marco-Pellegrino Should we remove the Design.ApplyChanges? Instead we could send it as a second command to FEM-Design.
The FemDesign.Calculate.Design should only contain the Design settings in my opinion
// FemDesign.Calculate.Design
[XmlIgnore]
public bool ApplyChanges { get; set; } // bool

the ApplyChanges property has been added to have a smoother workflow in Grasshopper.
ApplyChanges should be use only if a Design will be run so I think it is a good idea to keep it where it is and hide the cmdapplydesignchanges to the user.
in my opinion, it can be kept as it is.

I agree we should have ApplyChanges as a boolean somewhere and not a separate command. I was not clear on this.
But I think it makes more sense to have ApplyChanges on the RunDesign method:
C# like this:
femDesign.RunDesign(CmdUserModule.STEELDESIGN, design, applyDesign: true);

And grasshopper like this:


Emit parser type of tupleMeat

I was dealing with this problem https://play.nim-lang.org/#ix=2SpD and IRC community helped me adding the output type to the createParser macro.
  let tName = ident(($name).capitalizeAscii)
  result = quote do:
    type `tName` = `tupleMeat`
    proc `readerName`(`bs`: BitStream): `tupleMeat` =
      `reader`
    proc `writerName`(`bs`: BitStream, `input`: `tupleMeat`) =
      `writer`
    let `name` = (get: `readerName`, put: `writerName`)

It works nicely and only requires parser name to be lowercase, what do you think about adding this to binarylang?

@arkanoid87 thanks for the issue. Not a bad idea but the typeGetter macro has served me well so far. Your idea creates some limitations as you pointed out, for example I always have my parsers capitalized. I think it's an unnecessary breaking change.

I really like typeGetter, it was just undocumented feature! It works perfectly, thanks!

 I didn't realize it's not mentioned in README.md; I'll add it, thanks!


Vulnerability roundup 100: newlib-3.3.0: 1 advisory [9.8]

search, files

[ ] CVE-2021-3420 CVSSv3=9.8 (nixos-20.09, nixos-unstable)

Scanned versions: nixos-20.09: 12d9950bf47; nixos-unstable: 1f77a4c8c74.

NixOS 20.09 is EOL, so this issue isn't actionable anymore (but fixed in unstable #126799).


map[interface{}][]interface{}类型的支持

hessian2需要支持map[interface{}][]interface{}之类的复杂类型

@fangyincheng can u  provided a unit test please？

@wongoo yes, they may be:
doTestRequest(t, PackageRequest, Zero, []interface{}{map[string][]*Case{"key": {{A: "a", B: 3}}}}) doTestResponse(t, PackageResponse, Response_OK, map[string][]*Case{"key": {{A: "a", B: 3}}}, &map[interface{}][]interface{}{})

@fangyincheng  Currently, the supported decoding type of map is map[interface{}]interface{} , even when the type of map value is an array. see the pr https://github.com/dubbogo/hessian2/pull/44.

@wongoo Well, it is OK. I will try it when it is merged.

@fangyincheng it's merged.