Add noise correction to SDXL

Addressing singularities present in noise prediction models during the initial sampling step.

Paper - None that would describe this other than ImagineFlash
Code - NA

Hi, may I ask what the motivation behind this work is? It seems amazing, but I don't understand its impact, does it has any research with its..

Hi @toandd2, I'd suggest reading this https://arxiv.org/pdf/2405.05224 paper to better understand the method, assuming that, from what I think the impact comes from
— is at the initial denoising step if we introduce a bias through the latents, that would directly restrict the latent space (or the direction 🤷♂) the generation can travel through
— and while training, the forward diffusion process makes sure that SNR(T) is 0, so through this we make sure the inference follows that
— this results in more prominent regions through the generations, darker regions are a little more black, more vibrant, also effects like these can be achieved through increasing the guidance scale, but that would result in leaving the training distribution and introduces a lot of artefacts at times IMO
I might be completely wrong through, so a gentle ping to one of the authors from the paper @asanakoy


 Pasting here for posterity, I think this can be closed.

A runtime (noun) is an environment that is required to run programs that are not compiled to machine language.
Run time (noun) is the time during which an application is running.
The adjective "run-time" describes something that is occurring or relevant at run time, as in "a run-time error."

I will have to bookmark this!

If we have entries that say "at runtime" (which we do), I still think those should be fixed - since you wouldn't say "at compiletime". So I think it's worth keeping this issue open. I'll assign it to myself.


feat(ContinuousFunctionalCalculus): Define the real log based on the CFC

This PR defines CFC.log as cfc Real.log, and shows its basic properties, such as the fact that it's the inverse of NormedSpace.exp ℝ. Along the way, we also show that the exponential defined via the CFC is equal to NormedSpace.exp, which is defined via power series.

It's very annoying that aesop won't prove (∀ x ∈ spectrum ℝ a, 0 < x) → ∀ x ∈ spectrum ℝ a, x ≠ 0, but I also don't think we can make ne_of_gt or its synonyms into an aesop lemma (they would match too much, and they are very unsafe). It would be nice if we had some automation to handle this.
It would also be nice to have ways to customize the fun_prop part of cfc_cont_tac after the fact, maybe with some options? We should think about this. Because it would be good to add the necessary details (like the x ≠ 0 bit above), and then set an option to make cfc_cont_tac do what we need it to, without forcing ourselves to manually apply fun_prop with special dischargers.

Yes, we should think about this at some point. I think it's an instance of a much more general problem though: how do we automatize goals like ContinuousOn on an interval? If there are function compositions, we need a way to map the interval through the function composition and to show that some interval is contained in another. I don't think we have any tactic at the moment that can do this well.

bors merge


PartialNTU outlet enthalpy filter fix

ThermofluidStream.HeatExchangers.Internal.PartialNTU filters outlet enthalpy:
  if noEvent(C_A < C_B) then

    ...

    der(h_out_A)*TC = h_in_A - dh_A - h_out_A;
    der(h_out_B)*TC = h_in_B - dh_B - h_out_B;

  else

    ...

    der(h_out_A)*TC = h_in_A - dh_A - h_out_A;
    der(h_out_B)*TC = h_in_B - dh_B - h_out_B;

  end if;

[x]  For Dymola 2024x moving the outlet enthalpy filter equation out of the if clause can have a huge impact on simulation time:

  if noEvent(C_A < C_B) then
    ...
  else
    ...
  end if;
  der(h_out_A)*TC = h_in_A - dh_A - h_out_A;
  der(h_out_B)*TC = h_in_B - dh_B - h_out_B;

[ ] The if clause could be further simplified (move the  heat flow rates q_flowA and q_flowB out of the if clause):

  q_flowA = q_flow;
  q_flowB = -q_flowA;

  if noEvent(inletA.m_flow < m_flow_reg) and noEvent(inletB.m_flow < m_flow_reg) then
      dh_A = 0;
      dh_B = 0;
  else
    if noEvent(C_A < C_B) then
      dh_A = Delta_T_max*cp_A*effectiveness;
      dh_B = (m_flow_B*q_flowB)/(m_flow_B^2 + (m_flow_reg/10)^2);
    else
      dh_B = -Delta_T_max*cp_B*effectiveness;
      dh_A = (m_flow_A*q_flowA)/(m_flow_A^2 + (m_flow_reg/10)^2);
    end if;
  end if;

but for my tests this caused no obvious improvements.
I would personally only apply the first change der(h_out_A)*TC ..., since for me it seems to solve the issue with slow simulation.

Currently it seems like this is not the main issue.


Move edit_handlers imports to within the add method

This allows wagtailadmin to only start pulling in models and contenttypes after Django 1.9 initialisation, avoiding apps not loaded exception

Fixed in 0.3.7.

Thanks man!!


Skip getSemanticModule in fastboot mode

In fastboot mode, Accessing this.element is not allowed in non-interactive environments (such as FastBoot). error is thrown due to the calling of getSemanticScope (since it tries to access the jQuery element) via the getSemanticModule call present in the execute method.
Follow up to #204
Resolves #100

would appreciate this getting merged !

@aaronbhansen

I'm not maintaining this anymore, if one of you would like to be a Maintainer I'll add you as one

Sure. I could help out. Since we actively use this addon in the company I
work at
On Fri, Feb 9, 2018, 2:21 AM Aaron Hansen<EMAIL_ADDRESS>wrote:

I'm not maintaining this anymore, if one of you would like to be a
Maintainer I'll add you as one
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Semantic-Org/Semantic-UI-Ember/pull/209#issuecomment-364244243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACSwFOdF6GwPejarAcSBIyJXVBHPmi2mks5tS14xgaJpZM4Q7aqJ
.

I and @niranjan94 have worked together under @FOSSASIA banner for some OSS projects
At my company @coding-blocks we use Ember for many projects including  https://hack.codingblocks.com and https://codingblocks.online
I would like to help out in maintaining with @niranjan94  this, as I also actively use this package.

I would like to help out in maintaining with @niranjan94 this

Yep. That'd be great .. !

@aaronbhansen / @niranjan94
Could I get collaborator access ?
Also how to get about to making npm releases ? I can do that given access to the npm package.

@aaronbhansen would be able to give you collaborator access @championswimmer
And yes, we need access to publish to npm too. I don't have that yet.

You should already be a collaborator. I can look at adding you to npm later today when I get time

@aaronbhansen
Yep got the collaborator access. Was able to work with @niranjan94 to review and merge a few changes already. Thanks !

@aaronbhansen
My NPM handle is championswimmer (same as my Github handle)

@championswimmer you are added to npm


feat(tonic): introduce async_interceptor

Motivation
See Issue #870.
Tonic server provides interceptor for easy creation of a middleware layer from a closure. This interceptor can inspect and transform the headers and metadata of a request, as well as rejecting it by returning a status.
This PR introduces async_interceptor, a version of interceptor that accepts async functions and closures, allowing for the creation of more powerful middleware without the usual Tower boilerplate.
Solution
The code for interceptor was duplicated and adapted for use with an async interceptor. I was initially hoping to reuse most of the functions which support interceptor, but it would have required heavy modification of those functions and possibly less performant code, so ultimately I decided it was better to leave that code mostly untouched.
I found it challenging to write clean code without using async/await or FutureExt functions like then which chain futures together. As far as I can tell, those features would have required boxing the returned futures, and I'm assuming that we want to keep the futures in the core library on the stack, which this PR manages to do.
I also added some tests and updated the Tower example.
I'm still rather new to Rust (coming from a mostly Java and C++ background), so I'd really appreciate advice on code style. Thanks!

The interop tests for windows-latest failed, looks like the test is just hanging? @LucioFranco maybe just needs to be re-run?

It's a prost-build error:

CMake Error at CMakeLists.txt:24 (project):
The CMAKE_C_COMPILER:
  C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.31.31103/bin/Hostx64/x64/cl.exe

is not a full path to an existing compiler tool.

Probably isn't caused by this PR. I'm assuming it's related to: https://github.com/tokio-rs/prost/pull/620

It passes now, I think it was just flaky or a dependency issue. I merged the latest (unrelated) commit just to re-trigger the tests.

Hi @LucioFranco, this looks like it is complete and checks are passing, can it be merged now?

I will try and give this a review in the coming weeks I have a decent amount of backlog right now.

Hi @LucioFranco , it's been a few months, but you seem to have a lot on your plate, and I understand that this merge request is relatively unimportant. Please let me know if realistically speaking this won't be merged so I can put it in its own crate or something and don't have to rely on a forked version of tonic. Thanks!

At this point I don't have much time for this and in general tonic will be moving to be lighter (will eventually post the roadmap when I finish it lol). So if you can move this to your own crate for now that would probably be the easiest path forward. Sorry for the delay.

At this point I don't have much time for this and in general tonic will be moving to be lighter (will eventually post the roadmap when I finish it lol). So if you can move this to your own crate for now that would probably be the easiest path forward. Sorry for the delay.

Got it, I'll give that a try and post a link here for people who are interested.

Hey Lucio, would you consider a few small function visibility changes if I sent you a new merge request?
Currently async_interceptor relies on a number of non-public functions. I can work around that except for one place: Neither Request::into_http nor Extensions::into_http are public. Either one being public is sufficient. Note that Request::from_http is already public, so it's not too much of a stretch to do the same for into_http.
For proper error handling, we also need  body::boxed to be public because it calls a long chain of non-public functions.
Finally, it would be nice if Request::from_parts, and Request::into_parts were public, but it's not strictly necessary.
Thanks for your time!

Here is the minimal set of changes (3 lines) that I need to make an external async_interceptor crate work:
https://github.com/hyperium/tonic/commit/6af8bde4bb41d3bdd265c8c6a56ad7fdd9302cac
If that is acceptable, I'll open a merge request.

@jdahlq the into_http I think we can merge but the boxed one I believe we shouldn't expose that method maybe but we can expose stuff on Status to let you compose your own body type. That to me feels more flexible and less exposing internals about the body. What do you think?

@LucioFranco yes, I agree it would be a little weird to exposed boxed, especially since it is doing more than just boxing. Are you thinking we could expose Status::from_error? That seems like a reasonable part of the API to me, and it would be sufficient for my purposes.

@jdahlq do you already have a repo with the standalone interceptor?
I'd be interested in helping test it for an auth interceptor.

Hi @kwiesmueller , you can grab the code here: https://github.com/arcanyx-pub/tonic-async-interceptor
It is published as tonic-async-interceptor and currently points to a forked version of tonic, so you can use it in your Cargo.toml like this:
[dependencies]
# ...
tonic = { package = "tonic-arcanyx-fork", version = "0.8.1-alpha.0" }
tonic-async-interceptor = "0.1.0-alpha.0"
# If you use tonic-web, you'll also have to use a forked version:
tonic-web = { package = "tonic-web-arcanyx-fork", version = "0.8.1-alpha.1" }

The forked versions are taken from the most recent commit on hyperium/tonic:master.

@kwiesmueller and all, I have published v0.1.0 of tonic-async-interceptor which uses tonic v0.8.1. Hope it is useful!


Installation fails on Fedora 26

Hello, I'm trying to install polybar on Fedora 26, stable release after a handful of days. I'm not at all experienced to compiling open source software in this manual fashion so bear with me. I'm more than happy to provide further info if necessary.
Do note that I'm using this script: https://gist.github.com/nathanchere/22491daf4f917b100a35e5c284a5fec5/8221d5378c7f92247298817bb5ac4edf3a6487ad
The installation fails with the following error:
HEAD is now at 4e2e2a7... build: Bump version to 3.0.5
** Fetching submodules
** Setting build options
** Include support for "internal/i3" (requires i3) ------------------- [Y/n]:

** Include support for "internal/volume" (requires alsalib) ---------- [Y/n]:

** Include support for "internal/network" (requires wireless_tools) -- [Y/n]:

** Include support for "internal/mpd" (requires libmpdclient) -------- [Y/n]:

** Include support for "internal/github" (requires libcurl) ---------- [Y/n]:

** Build "polybar-msg" used to send ipc messages --------------------- [Y/n]:

** Using compiler: g++/gcc
** Executing cmake command
-- The C compiler identification is GNU 7.1.1
-- The CXX compiler identification is GNU 7.1.1
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/g++
-- Check for working CXX compiler: /usr/bin/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type specified; using RelWithDebInfo
-- Using supported compiler GNU-7.1.1
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.3.7")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Checking for module 'cairo-fc'
--   Found cairo-fc, version 1.14.10
-- Checking for module 'xcb-xkb'
--   Found xcb-xkb, version 1.12
-- Checking for module 'xcb-randr'
--   Found xcb-randr, version 1.12
-- Checking for module 'xcb-randr>=1.12'
--   Found xcb-randr, version 1.12
--  Build:
--    Type: RelWithDebInfo
--    CC: /usr/bin/gcc  -O2 -g -DNDEBUG
--    CXX: /usr/bin/g++  -Wall -Wextra -Werror -O2 -pedantic -pedantic-errors -O2 -g -DNDEBUG
--    LD: /usr/bin/ld
--  Targets:
--    polybar-msg
--    testsuite
--  Module support:
--    alsa
--    curl
--    i3
--    mpd
--    network
--  X extensions:
--    xcb-randr
--    xcb-randr (monitor support)
--    xcb-render
--    xcb-damage
--    xcb-sync
--    xcb-composite
--    xcb-xkb
--    xcb-xrm
-- Font not found: fixed:pixelsize=10
-- Font not found: unifont:fontformat=truetype
-- Font not found: siji:pixelsize=10
-- Checking for module 'xcb-proto'
--   Found xcb-proto, version 1.12
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.13", minimum required is "2.7")
-- XCB[XCB]: Found component XCB
-- Found XCB_XCB: /usr/lib64/libxcb.so
-- XCB[ICCCM]: Found component ICCCM
-- Found XCB_ICCCM: /usr/lib64/libxcb-icccm.so
-- XCB[EWMH]: Found component EWMH
-- Found XCB_EWMH: /usr/lib64/libxcb-ewmh.so
-- XCB[UTIL]: Found component UTIL
-- Found XCB_UTIL: /usr/lib64/libxcb-util.so
-- XCB[IMAGE]: Found component IMAGE
-- Found XCB_IMAGE: /usr/lib64/libxcb-image.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so
-- Searching for xcbgen with python2
-- Found xcbgen in /usr/lib/python2.7/site-packages
-- XCB[RANDR]: Found component RANDR
-- Found XCB_RANDR: /usr/lib64/libxcb-randr.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so;/usr/lib64/libxcb-randr.so
-- XCB[XKB]: Found component XKB
-- Found XCB_XKB: /usr/lib64/libxcb-xkb.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so;/usr/lib64/libxcb-randr.so;/usr/lib64/libxcb-xkb.so
-- xpp: including xcb proto randr.xml
-- xpp: including xcb proto xkb.xml
-- xpp: including xcb proto xproto.xml
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/polybar/build
** Building project
Scanning dependencies of target xpp
[  1%] Linking CXX static library libxpp.a
list: size, ['red', 'green', 'blue']
list: size, ['red', 'green', 'blue']
[  1%] Built target xpp
Scanning dependencies of target polybar
[  3%] Building CXX object bin/CMakeFiles/polybar.dir/cairo/utils.cpp.o
[  4%] Building CXX object bin/CMakeFiles/polybar.dir/components/bar.cpp.o
In file included from /tmp/polybar/lib/xpp/include/xpp/proto/../generic.hpp:11:0,
                 from /tmp/polybar/lib/xpp/include/xpp/proto/x.hpp:9,
                 from /tmp/polybar/lib/xpp/include/xpp/event.hpp:9,
                 from /tmp/polybar/include/x11/types.hpp:3,
                 from /tmp/polybar/include/components/bar.hpp:12,
                 from /tmp/polybar/src/components/bar.cpp:3:
/tmp/polybar/lib/xpp/include/xpp/proto/../generic/reply_iterator.hpp:89:11: error: specialization of ‘template<class Data, class> class xpp::generic::iterator<Connection, Object, xpp::generic::signature<void(XcbIterator*), Next>, xpp::generic::signature<int(const void*), (* & *(int (*)(const void*))SizeOf)>, xpp::generic::signature<XcbIterator(const Reply*), GetIterator> >::get<Data, <template-parameter-1-2> >’ must appear at namespace scope
     class get<xcb_str_t, Dummy>
           ^~~~~~~~~~~~~~~~~~~~~
make[2]: *** [bin/CMakeFiles/polybar.dir/build.make:87: bin/CMakeFiles/polybar.dir/components/bar.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:455: bin/CMakeFiles/polybar.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
** Failed to build project

Hmm seems to be a problem with xpp. Can you clone that project and try to compile it, like this:
git clone --recursive https://github.com/jaagr/xpp
cd xpp
git checkout 61f42bbca835b3cf9968de42fd46ffe404b73dca
mkdir build
cd build
cmake ..
make

What versions do the packages xcb-proto xcb-util-devel xcb-util-wm-devel xcb-util-image-devel have?

Absolutely. Will give feedback asap.

Building xpp was successful:
...
[100%] Built target xpp

Package information:

xcb-proto 1.12-3.fc26
xcb-util-devel 0.4.0-6.fc26
xcb-util-wm-devel 0.4.1-9.fc26
xcb-util-image-devel 0.4.0-5.fc26

I was able to reproduce this on arch. Seems gcc still has problems to compile this. Install clang and try again, it should work now. If it doesn't, remove line 42 from the script you posted

Installation of master on Fedora 26 with Clang was successful. Thanks @patrick96 .
Best of luck finding the issue with gcc/++. :+1:

The GCC issue is tracked in #572


Error 404 Not found: serve@latest

I am trying to install serve globally and am getting an error. Here is the Trace found in the log:
Trace:    Error: https://registry.yarnpkg.com/serve: Not found       at Request.params.callback [as _callback] (/usr/local/Cellar/yarn/1.7.0/libexec/lib/cli.js:65656:18)       at Request.self.callback (/usr/local/Cellar/yarn/1.7.0/libexec/lib/cli.js:134675:22)       at Request.emit (events.js:180:13)       at Request.<anonymous> (/usr/local/Cellar/yarn/1.7.0/libexec/lib/cli.js:135658:10)       at Request.emit (events.js:180:13)       at IncomingMessage.<anonymous> (/usr/local/Cellar/yarn/1.7.0/libexec/lib/cli.js:135578:12)       at Object.onceWrapper (events.js:272:13)       at IncomingMessage.emit (events.js:185:15)       at endReadableNT (_stream_readable.js:1106:12)       at process._tickCallback (internal/process/next_tick.js:178:19)

Having the same issue

I'm also getting this error. Checking the npm status everything looks good so this package must be corrupt.

temp solution is to NPM install directly from git repo
npm install -g git+https://github.com/zeit/serve#6.5.8

or npm --registry http://registry.node-modules.io/ install serve

Seems like an issue with NPM:
▲ ~ curl -I https://registry.npmjs.org/serve
HTTP/1.1 200 OK
...

It's there, but the npm CLI claims it can't find it:
7 http fetch GET 404 https://registry.npmjs.org/serve 253ms

npm view can also find it:
▲ ~ npm view serve dist-tags
{ latest: '7.2.0' }
▲ ~

I'll contact NPM and post updates here.

thanks for the update @matheuss

Hoping this gets resolved soon. Netlify builds will fail as well since they are pulling from npm as well.

@dansaferide How would that temp solution work when serve is a dependency of a package? The package doesn't need serve to update and it is already installed but the package fails to install because of the 404 error.

Unfortunately I haven't hard back from NPM: https://twitter.com/matheusfrndes/status/1002710142868078593
Closing this as the issue is "fixed" now – no more 404s. Thanks for the reports, everyone 🙌


Custom FS freeze operation for live cpds

Description
When a disk is saved-as into the datastore the TM driver issue some KVM/libvirt commands to perform a save copy (blockcp/somfsfreeze)...
This operations are hypervisor specific and the driver needs to expose a modular interface to implement custom fs-freeze/unfreeze operations. Current affected operations are:

ceph/cpds.ssh
qcow2/cpds
qcow2/cpds.ssh
ssh/cpds

Use case
Save disk-saveas operations across hypervisors
Interface Changes
TM driver need to hook on specific KVM/LXC/FC freeze operations
Additional Context

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Consider this together with: #5005


Check for faulty qubits and edges

Summary
Closes #568
Checks if the input circuits use a faulty qubit or edge and raises if they do.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 21 (90.48%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 50.355%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_provider/ibm_backend.py
19
21
90.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
2982

Relevant Lines:
5922

💛  - Coveralls


falco: the --k8s-node cmdline option doesn't do validation and the example helm chart usage is invalid

Describe the bug
Whilst trying to make use of the new --k8s-node parameter, we couldn't understand why our deployment integration-tests were all failing. It turns out that the example usage mentioned in the PR https://github.com/falcosecurity/falco/pull/1671 is invalid. When using environment variables inside of your config they must be specified in a bracketed templating style of $(VARIABLE) and not a standard shell style of $VARIABLE or ${VARIABLE}
How to reproduce it
Deploy falco with the example given from the PR which uses the correct style for KUBERNETES_SERVICE_HOST but not for MY_NODE_NAME:
...
    containers:
        - name: falco
        ...
          args:
            - /usr/bin/falco
            - --cri
            - /run/containerd/containerd.sock
            - -K
            - /var/run/secrets/kubernetes.io/serviceaccount/token
            - -k
            - "https://$(KUBERNETES_SERVICE_HOST)"
            - -pk
            - --k8s-node
            - "${MY_NODE_NAME}"
        env:
        - name: MY_NODE_NAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName
...

As a result Falco ends up passing ${MY_NODE_NAME} [sic] on its field-selector which of course silently doesn't match any available node(s).
Expected behaviour
Ideally falco should fetch the available nodes in the cluster and refuse to startup unless the provided k8s-node option matches one that is available within the cluster. Alternatively it could reject a value that starts with a $ and indicate to the user that they've likely failed to correct pass a substitution variable to falco's cmdline.

Good catch! Thank you for having noticed that :+1:
First, I have immediately fixed the example in https://github.com/falcosecurity/falco/pull/1671 to avoid confusion.
Second, I'm unsure at the moment which is the best way to completely address this issue. Checking if the given node name matches a valid node in the cluster should be feasible in https://github.com/falcosecurity/libs. Anyway, this still does not guarantee that the given node is the current node (a naive user could still pass a valid node name, but of another node, and nobody will notice it :smile_cat: ).
I will think a bit about that. Meanwhile thank you again for raising this issue.

@leogr I guess the other option (assuming the serviceAccount is powerful enough) is for falco to just ask the kube-api "what node am I scheduled on" at startup by doing a GET of the podname (from hostname) across namespaces and checking the pod.Spec.NodeName directly to supply for the filter

@leogr I guess the other option (assuming the serviceAccount is powerful enough) is for falco to just ask the kube-api "what node am I scheduled on" at startup by doing a GET of the podname (from hostname) across namespaces and checking the pod.Spec.NodeName directly to supply for the filter

Although that solution should work in most cases, it's a "node autodetection mechanism" that I tried to avoid when implementing this feature. The reasons are: autodetection might not work in edge cases, and the downward API keeps the implementation really simple (I usually like the easy way :smile_cat: ). Perhaps, your first proposal (just validate that the given node matches one in the cluster) is the best option. Anyway, since we have to implement the validation in libs first, I have opened an issue there: https://github.com/falcosecurity/libs/issues/136.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

I like this solution :point_down:
https://github.com/falcosecurity/libs/pull/157
@dnwe wdyt?

LGTM!

This issue was fixed by https://github.com/falcosecurity/libs/pull/157
/close

@leogr: Closing this issue.

In response to this:

This issue was fixed by https://github.com/falcosecurity/libs/pull/157
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


V1 - Rebranding - Gerrit - When clicked on GetHelp>docs user is redirected docs link and there is no option to navigate back to contributor console

Navigate to Corporate Contributor Console from gerrit
Login
Click GetHelp > Docs
User is redirected to documentation page in same browser tab and there is no option for user to navigate back to Corporate Contributor Console. And when user navigated back in browser, user is redirected SignIn page for Contributor Console
Either docs link should be displayed in new tab or there should be option for user to navigate back to previous page from docs page (tested in incognito mode)

@amolsontakke3576 confirm with @pranab-bajpai that we should open the docs in a new tab.

Verified and doc page opens in new tab.

Closing issue due to lack of activity.


Can't add custom component with a NestedScrollView using Builder.load in NS7

Hey @triniwiz,
I'm upgrading to NS7 and noticed that all of my custom components with NestedScrollView in the UI will not load. I'm using Builder.load but there is no return.
Check out my sample app here. If you remove the NestedScrollView in the custom component the app will function correctly.
https://play.nativescript.org/?template=play-tsc&id=rnQH2l&v=2
Love your plugins,
Thanks

I'm seeing the same thing.  Any guidance @triniwiz ?

Which platform(s)

Both iOS/Android

I'll check that out


[Bug] Failure in CrescendoOrchestrator

Describe the bug
Running a Crescendo attack on a locally running model, I had a failure due to the following exception:
  File "C:\Users\riedgar\source\repos\PyRIT\build\__editable__.pyrit-0.4.1.dev0-py3-none-any\pyrit\orchestrator\crescendo_orchestrator.py", line 158, in apply_crescendo_attack_async
    self._prompt_target_conversation_id = await self._backtrack_memory(
  File "C:\Users\riedgar\source\repos\PyRIT\build\__editable__.pyrit-0.4.1.dev0-py3-none-any\pyrit\orchestrator\crescendo_orchestrator.py", line 319, in _backtrack_memory
    new_conversation_id = self._memory.duplicate_conversation_excluding_last_turn(
  File "C:\Users\riedgar\source\repos\PyRIT\build\__editable__.pyrit-0.4.1.dev0-py3-none-any\pyrit\memory\memory_interface.py", line 259, in duplicate_conversation_excluding_last_turn
    piece.orchestrator_identifier["id"] = new_orchestrator_id
TypeError: 'NoneType' object does not support item assignment

Steps/Code to Reproduce
Not easy to provide (and will have to back out my own retry logic to reproduce).
Expected Results
No exception
Actual Results
Stacktrace shown above
Screenshots
N/A
Versions
Win11
Python 3.10
PyRIT installed via pip install -e .[dev] from repository cloned on 2024-09-04

Attempting to reproduce now - will get back to you on my progress!

Thanks. This isn't blocking right now, mainly because it's not reproducing all of a sudden. I do have some extra logging in my local copy of memory_interface and will share that if I encounter the issue again

Any updates at all? I'm still seeing this a lot. Based on an AzureML run I did over the weekend, the problem is particularly acute when there is a system prompt present.

Tag @nina-msft  @jbolor21

Closing this issue since we've made considerable refactoring changes. If the same or similar happens again please reopen.


Error uploading to Endpoint Manager/Intune

Please provide a brief summary of the bug
Our company uses Microsoft Endpoint Manager for pushing software to our clients' computers. EM allows for direct msi uploads (much easier than .exe installers). There is an error when uploading the installers: The selected app package does not appear to have either a ProductCode or ProductVersion.
This occurs with:

OpenJDK8U-jdk_x64_windows_hotspot_8u345b01.msi
OpenJDK19U-jdk_x64_windows_hotspot_19_36.msi

I've checked the msi files in Orca, ProductVersion and ProductCode do exist. I can test with EM on my end, and I have a support ticket open with Microsoft. Microsoft has consistently told me to contact you for assistance, even though the issue seems to be on their end.
Please provide steps to reproduce where possible
No response
Expected Results
The software should be uploaded to Endpoint Manager
Actual Results

What Java Version are you using?
N/A
What is your operating system and platform?
No response
How did you install Java?
No response
Did it work before?
No

Did you test with other Java versions?
No response
Relevant log output
No response

I've just copied your support email on my ticket with MS support. It's case#32718855 on their system.

@Protinon To do double check - what are the various versions of Windows that this package is being pushed to?  We understand that a 32-bit installer worked and I'm wondering if our 64-bit installer was being accidentally pushed to a 32-bit machine.

The issue is not with pushing software to computers, but uploading them to Endpoint Manager. They install on all machines perfectly fine, but I have no way of mass-pushing Adoptium to client computers if the software will not upload to EM.

Inspecting the MSI more closely we do seem to have the ProductCode set so not sure why else this would fail:

ProductCode = {F4A0EF62-164A-4E05-AC6F-2AE03D8685B7}
Language = 1033
ProductName = Eclipse Temurin JRE with Hotspot 20+18 (arm64)
PackageCode = {77C118E6-B6F6-4717-B298-FB82B8C4C77E}
AssignmentType = 1
PackageName = OpenJDK-jre_aarch64_windows_hotspot_2022-10-12-03-30.msi
InstalledProductName = Eclipse Temurin JRE with Hotspot 20+18 (arm64)
VersionString = <IP_ADDRESS>
ProductIcon = C:\windows\Installer\{F4A0EF62-164A-4E05-AC6F-2AE03D8685B7}\logo.ico
InstallLocation = C:\Program Files (Arm)\Eclipse Adoptium\jre-<IP_ADDRESS>-hotspot\
InstallSource = C:\Users\georg\Downloads\
InstallDate = 20221101
Publisher = Eclipse Adoptium
LocalPackage = C:\windows\Installer\2cc11928.msi
HelpLink = https://github.com/adoptium/adoptium-support/issues/new/choose
URLInfoAbout = https://adoptium.net/support.html
URLUpdateInfo = https://adoptium.net/releases.html

I have to agree with you, the error message shown isnt helpful in the slightest. It may not even be the actual issue.
I've been wrestling with MS support for a month now, but they are convinced the issue lies with Adoptium.
I was hoping by looping you in, they would realize the issue and maybe ask you try some possible solutions. I heard you joined a meeting with MS support, did anything come from that?

@Protinon I assume the End Point Manager is running on a 64-bit host or are you using an Azure hosted End Point Manager?

Forgot to respond to this, we are using Endpoint Manager hosted on Microsoft servers. We've never had issues uploading 32/64bit programs before.

In internal MSFT testing it does seem to be an Adoptium installer only issue, we're diffing that and other installers (from say Azul Zulu or Amazon Corretto).

has there been any progress on this at all?  Trying to deploy to 120+ users consumes a lot of time


Refactor how time types are handled

Assess if any current use within Case is leveraging time:TimestampPrecision (I doubt there is)
If no current use then
2.1. Redefine TimestampPrecision as an open vocab according to the fix in #75
2.2. Modify all timestamp uses within UCO to leverage xsd:dateTime
2.3. Remove time.ttl and all of its content from UCO

All timestamp uses within UCO modified to leverage xsd:dateTime draft complete in turtle-cleanup branch


Improve resilience of network errors

#4/#10 did most of the work here - what remains is primarily ensuring that apps don't hang and these errors actually make it back to the delegate.

With #17, the delegate-based hang shouldn't be possible (though in theory, failing to resolve the continuation could have the same thing). What remains is making sure error codes are reasonable.


test: Add Fedora 33 ostree test back

Fix: #1497
Signed-off-by: Yuxin Sun<EMAIL_ADDRESS>This pull request includes:

[x] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] create a file in news/unreleased directory if this change should be mentioned in the release news
[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Blocked by #1561

Rebased. But some vmware.sh+rhel jobs failed(see https://gitlab.com/osbuild/ci/osbuild-composer/-/jobs/1437164333):
Jul 20 07:57:41 ip-10-30-18-54.us-east-1.aws.redhat.com osbuild-worker[22136]: /usr/libexec/osbuild-composer/osbuild-worker: Post "https://[MASKED]/sdk": dial tcp: lookup [MASKED] on <IP_ADDRESS>:53: no such host
Jul 20 07:57:41 ip-10-30-18-54.us-east-1.aws.redhat.com osbuild-worker[22136]: 2021/07/20 07:57:41 target failed: importing vmdk failed
Jul 20 07:57:42 ip-10-30-18-54.us-east-1.aws.redhat.com osbuild-worker[22136]: 2021/07/20 07:57:42 Job 68cce813-b7ff-4101-9d95-f9601c40520f finished
Jul 20 07:57:42 ip-10-30-18-54.us-east-1.aws.redhat.com osbuild-worker[22136]: Waiting for a new job...
💬 Getting compose log and metadata
/usr/libexec/tests/osbuild-composer/vmware.sh: line 164: 22191 Terminated              sudo journalctl -af -n 1 -u "${WORKER_UNIT}"
Something went wrong with the compose. 😢


feat: templating, fix HTMLFormatter & logging

new feature templating (ABCTemplating, JinjaTemplating), added doc & example
add support env variable LOGGER_LEVEL, default value DEBUG
fix logging.getLogger("telegrinder")
fix HTMLFormatter, fix doc & example
small corrections and improvements

Hello! Thank you for you PR 🙇
I wrote some comments with minor enhancement requests of what you've done


maximum supply

Hi, a quick question. If I want to create in the first part 5000 Nft and then in a second part raise another 5000 in the maximum amount of the contract I can put 5000 and then edit that number to 10,000 or should I write 10,000 at once.

Hi @Angrywolvesdev, this project doesn't support updating the supply after deployment. Leaving that value as dynamic can be seen as a lack of transparency from the users because the collection owner would then be able to change the supply randomly.
That said, there are some possible solutions is you still want to implement it, I probably gave some advice to people asking the same thing so you can try using the search tool in the Issues page. You can also ask on the HashLips' discord server, you might find a dev that can help you.

So what would happen if I put 10,000 but I only have 5,000 images created, because I would like to divide the project into two parts and once the first one is sold, publish the second. in the same contract it is possible?

That's absolutely possible, but you have to customize the project (probably both the contract and DAPP) in order to support this custom behavior. This is not supported out-of-the-box and unfortunately I don't have any ready example on how to do it.


Ran PretrainedModels_TransferLearning end to end with changes.

PretrainedModels_TransferLearning ready for diff and merge

Thanks for the very quick response and addressing the comments.


[OSX] Crashes immediately on running: AttributeError and KeyError

Installation all goes fine on Yosemite but then this happens:
bash-3.2$ pyportify
Traceback (most recent call last):
  File "/usr/local/bin/pyportify", line 9, in <module>
    load_entry_point('pyportify==0.2.9', 'console_scripts', 'pyportify')()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 357, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 2394, in load_entry_point
    return ep.load()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py", line 2108, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/Library/Python/2.7/site-packages/pyportify/server.py", line 5, in <module>
    from pyportify.views import app as application
  File "/Library/Python/2.7/site-packages/pyportify/views.py", line 76, in <module>
    user_scope = UserScope()
  File "/Library/Python/2.7/site-packages/pyportify/views.py", line 31, in __init__
    self.googleapi = Mobileclient()
  File "/Library/Python/2.7/site-packages/pyportify/google.py", line 30, in __init__
    "ca_certs": certifi.old_where(),
AttributeError: 'module' object has no attribute 'old_where'
Exception KeyError: KeyError(4539898928,) in <module 'threading' from '/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.pyc'> ignored

Any suggestions?

I just released a new version.  Would you care to give it a try?  You can download a binary at https://xr6.me/pyportify/pyportify-0.3.0-osx.zip


All Channels, All Messages: "Sorry, my bot code is having an issue." - Exact same code worked 3 days ago.

Bot Info

App ID: 05483456-e1be-45a5-95a1-d87fc89dbeba
SDK Platform: .Net
SDK Version: 3.12
Active Channels: Web Chat, Skype, Slack
Deployment Environment:  Azure Bot Service, Azure App Service
Region: West US

Issue Description
Every message sent results in the correct message being sent back, but then a bot issue (error).  I have checked the solitaire bot : https://bots.botframework.com/bot?id=Solitaire, and it is experiencing the same issue.  I started on 3.9 and upgraded to 3.12 with no improvement.

Code Example
Any
Reproduction Steps

Send any message.

Expected Behavior
The response, without an error, and the ability to accept a new response.
Actual Results
Response, then an error, and resets.

I am also experiencing this exact same issue. Bot worked perfectly fine before the weekend.

I am getting the same issue as well.

me too since yesterday

This error appears to now have moved on to the messages not being sent at all.  The webchat also will either not load or not send.  Skypebot also appears to be offline for the moment, possibly related or not.

@dkershner6 if you type /deleteprofile to your bot what happens when you try to have a conversation afterwards?
@sharontf @KIBASSA  please provide your app IDs

we had a similar issue - moving the bot (session) state to a persistent db seemed to have solved the issue

I'm having similar strange issues in which the bot doesn't seem to update its state anymore. I'm still using the state service. Did something change in the past day?

@Kannaj Correct, the issue was resolved after moving to state to db.
@JasonSowers: In future, can this be handled better like informing via emails?

@sagarpomal @Kannaj I may be misunderstanding, but what do you mean by "moving the bot (session) state to a persistent db"?

This is my bot ID link https://dev.botframework.com/bots?id=emiko  (only on messenger)
What does that mean 'moving to state to db'?

@JasonSowers it now works, even though I didnt change anything at all...

I am still experiencing the issue of "Sorry, my bot code is having an issue". Location: South Central US

If you are having this issue please provide your app ID so we can investigate and track

@JasonSowers App ID: 62a3f1ae-f10a-43f4-ac70-d2c22b3f69a5

App ID:d10755e5-fd3d-4824-8492-3b18a8455af6

A known solution is to implement a custom state store rather than use the default state store details can be found here for c#, and here for node.  We are still actively investigating.

Same here, been happening for 24 hours and still on-going.  Any other examples of a state store using SQL?  I already have a database I can use and don't need to use Azure.
AppID: 386a3c4e-a7df-4ff9-85ff-a0271820d254

There are also samples in this repo https://github.com/Microsoft/BotBuilder-Azure one of them is for AzureSQL.  If you were planning to use an on-premise SQL server it would have to be publically exposed.

@ThisIsColinB : Please refer the comment above by JasonSowers.

I've found this: https://blog.botframework.com/2017/07/26/saving-state-sql-dotnet/ and the sample code here: https://github.com/Microsoft/BotFramework-Samples/tree/master/blog-samples/CSharp/AzureSql-StateClient/Microsoft.Bot.Sample.AzureSql
Obviously not going to put a SQL Server public on the web but would seem easy enough to put a simple Web API in front of it.  Where exactly is the state service called from?  Is it ever called from somewhere other than my own bot code?

Is there any insight as to why the default state store has suddenly stopped working though? I realize you are still investigating, but I am just confused how things went from working perfectly, to not at all with no code change.

@stuprice your bot code would be where it is called from
@ThisIsColinB I do not want to put out bad information so I'm going to wait until we know for sure about the root cause.

@JasonSowers thanks, just needed to clarify that.  So in performance terms it will be better to host the state database close to my bot - in this case it will be just 'next door' :-)

yes, very much so @stuprice

I think this issue is still occurring.  Here is the exception I am seeing with our bots:
App ID: 05c986bf-f0ce-46ae-8397-3c76d1d6b6b3

To reiterate, There is a known solution to fix this issue that involves implementing a state store rather than using the default state service.  The default state service is intended for use in prototyping only.  Any production level bot should already be using an implementation of a state service rather than the default.
For more information
C#
Blog Post With Examples
BotBuilder-Azure Samples C#
Node
Blog Post With Examples
BotBuilder-Azure Samples Node

@JasonSowers - this is good to know.  Maybe I just missed it in the docs or something, but I had no idea.
In any case, to the other neophytes in here, even I was able to implement this in about 10 minutes.  Table storage seems to make the most sense and is easiest IMO.
You just add a few lines of code to global.cs.

@ThisIsColinB your bot appears to be working now, can you confirm?

Hi @JasonSowers,
This is affecting our bot as well; app id: fa6e93fc-6a8a-42b7-a4a6-e72c9508e46c
I understand that your recommendation is to incorporate our own state service. We are looking into it as I type this. Is there something you can do on your end to correct the issue for this bot while we work on switching to our custom state service?
Thank you!

@jeffhee  I was able to go through what seems like the whole process of your bot and got to the dialog below, what is the behavior you are seeing causing concern.  To answer your question we are currently investigating the cause so we do not have a solution other than the one i recommended thus far

Hi Jason,
Thanks. Prior to your response, the bot was consistently retriggering the firstRun intent, which we interpret as being caused by storing the current version number in the default state service.
It does work now.
Thank you

@jeffhee please let us know on this thread if it happens again

@JasonSowers the regular state service is working for me now.  Thanks for you help and info.  I also didn't realise the default state service wasn't for production use so I'm implementing it as we speak.

@JasonSowers Yes my bot seems to be working now. Thanks for the help and information!

@KIBASSA please open a new issue your bot does not seem to be functional still, but from what we can see it is unrelated to this issue.   we see that you have app insights enabled please look there for more information and if possible put your code in a repo or post it in the new issue.

Closing this as all bots affected should be working now please open a new issue if your bot is not working


add dynamicHeaders, closes #151

Description
Allows adding headers in HTTP requests that are not yet available initially (i.e. when defining baseHeaders).
What's included?

new dynamicHeaders?: () => Headers property on RESTService.

Test Steps

[ ] pass in a function creating additional headers
[ ] make your RESTService
[ ] enjoy headers usable for authorization!

Screenshots or link to CodePen/Plunker/JSfiddle
Todo. Are there existing tests/fiddles demoing RestService?

I dunno about Travis's Cannot find module 'buffer-shims', don't recall using anything like that.

Yeah, its a problem with the latest angular-cli https://github.com/angular/angular-cli/issues/3131, adding a fix in our upgrade PR

We will add a live demo later. Ill merge for now.


Unique Task List

Features of this PR

Added a UniqueTaskList analogous to UniquePersonList.

Added functions required by TaskList, to UniqueTaskList

LGTM! We can implement an updated TaskList following this PR


error running .\deploy.ps1 - powershell deployment

we have an azure subscription running on a different tenant that's not the same as where o365
Starting deployment...
Login with with your Azure subscription account. Launching Azure sign-in window...
WARNING: Unable to acquire token for tenant 'dc411c63-1f52-4491-bb51-c4d215a1de23'
WARNING: The default web browser has been opened at https://login.microsoftonline.com/06cf07c8-a863-46bb-afa9-6878b267a932/oauth2/authorize. Please continue the login in the web browser. If no web browser is available or if the web browser fails to open, use device code flow with az login --use-device-code.
hitting the url we get
Request Id: 55cdf2eb-1beb-4bed-8c79-e03d1cc71b00
Correlation Id: 98b31408-0a53-4c02-99e4-c7c99b1d24af
Timestamp: 2021-05-19T05:00:20Z
Message: AADSTS900144: The request body must contain the following parameter: 'client_id'.

Hello @thiagobeier,
We are not able to repro this issue. Can you please confirm few things:

There are two sign-in screen one for Azure Subscription and other Azure Active Directory. Which of the sign-in screen you are facing this issue?
Is it opening any browser for sign-in?
The account you are using for sign-in should have contributor role or higher and should belongs to subscription tenant.
Please check subscription Id, subscription tenant Id is correct.

You cannot sign-in with that URL if you copy and paste manually.
If you are unable to do deployment using PowerShell, I prefer you to follow portal deployment guide.
Please let us know if you are still facing this issues.
Thanks


Crash (panic) on Windows after a while with an "overflow when subtracting durations" error message

On Windows 11, using latest version (0.8.1), and piping some data to csvlens, I get this error after a while (not immediately, mostly on idle):
The error seems to be overflow when subtracting durations
thread 'main' panicked at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce\library\core\src\time.rs:954:31:
overflow when subtracting durations
stack backtrace:
   0:     0x7ff78d708cc9 - <unknown>
   1:     0x7ff78d5c411d - <unknown>
   2:     0x7ff78d705be1 - <unknown>
   3:     0x7ff78d708afa - <unknown>
   4:     0x7ff78d70b3b9 - <unknown>
   5:     0x7ff78d70b075 - <unknown>
   6:     0x7ff78d5f9b45 - <unknown>
   7:     0x7ff78d70b963 - <unknown>
   8:     0x7ff78d70b809 - <unknown>
   9:     0x7ff78d709399 - <unknown>
  10:     0x7ff78d70b482 - <unknown>
  11:     0x7ff78d73eb07 - <unknown>
  12:     0x7ff78d73eac2 - <unknown>
  13:     0x7ff78d5e7f73 - <unknown>
  14:     0x7ff78d5e7eb8 - <unknown>
  ...     14...78 are all the same
  78:     0x7ff78d5e7eb8 - <unknown>
  79:     0x7ff78d5e1076 - <unknown>
  80:     0x7ff78d60454f - <unknown>
  81:     0x7ff78d5fad2c - <unknown>
  82:     0x7ff78d6141b6 - <unknown>
  83:     0x7ff78d61e11c - <unknown>
  84:     0x7ff78d6ffdae - <unknown>
  85:     0x7ff78d60125c - <unknown>
  86:     0x7ff78d71990c - <unknown>
  87:     0x7fff0100257d - BaseThreadInitThunk
  88:     0x7fff01beaa48 - RtlUserThreadStart

The length of the backtrace varies (the number of 0x7ff78d5e7eb8 actually, the rest are the same). This happens both by reading a file from disk, and from piping data.
EDIT: If it helps, OS Version:

OS Name: Microsoft Windows 11 Pro
OS Version: 10.0.22631 N/A Build 22631

Thanks for reporting! I pushed a potential fix to the main branch, but I don't have access to a Windows machine to reproduce or test this. It would be great if you can check if this still occurs in the main branch.

Closing for now, feel free to reopen if the issue persists.

I wasn't even able to reproduce it on the original build, or on an alternate computer :/ - I guess it's something to do with the number of processors.
Let's just assume it's working, those heisenbugs are the worst!


Invalid OTP's error message is not proper while VC activation

Describe the bug
Invalid OTP's error message is not proper while VC activation in both android and ios
To Reproduce

Download a new VC
Open it in detailed view
Click on the activate button and click on "yes, i confirm"
Enter a invalid OTP

Expected behavior
Should prompt an error message as in below screenshot and should allow you to retry for another attempt

Actual behavior
The error message prompted is wrong, and it is not letting to retry
Screenshots
https://user-images.githubusercontent.com/102220709/228553669-881088ab-6371-4d85-bd88-9740e816aa0d.mp4
Add the screenshot of the profile page with commit id

Tested on:
Phone make/model: Google Pixel 6
OS: Android 13
BLE version : 5.2
MOSIP Version : <IP_ADDRESS>
MOSIP server : qa-1201-b2.net
APP link : https://github.com/mosip/inji/actions/runs/4511525622

This bug has been moved to Jira.
Link to Jira bug: https://mosip.atlassian.net/browse/MOSIP-26854

The root cause for this issue is the wallet binding API is returning an generic error instead of specific errors.
RESPONSE FOR INVALID OTP - {"errors": [{"errorCode": "binding_auth_failed", "errorMessage": "binding_auth_failed"}], "id": null, "metadata": null, "response": null, "responsetime": null, "str": null, "version": null}.
This was confirmed by @lsivanand .
The response should contain specific error codes with proper error messages then only we can proceed with fixing this issue. There is a dependency from Mimoto server. Once the issue is fixed from the server side then only we can proceed with this. Hence this is not going in the Hotfix release.

verified as fixed in the build with commit id in the below screenshot.


[BEAM-6772] Change Select semantics to match what a user expects

Details in the JIRA: The current Select transform provides confusing and less-useful semantics. This PR causes the transform to remove extra levels of nesting that are left after a Select.

R: @kanterov

I've started looking, the code makes sense, however, I need more time to think about the idea of automatic unnesting. I'm wondering if we can make it less implicit.
As for me, I would expect the previous behavior, that's how, for instance, Spark data frames work, IIRC.

The new behavior better matches how SQL works (Select a.b return an int if
b is an int. It doesn't return a nested row). However we could also make it
an option on the Select transform so the user can pick which behavior they
want.
On Wed, Mar 13, 2019 at 10:39 AM Gleb Kanterov<EMAIL_ADDRESS>wrote:

I've started looking, the code makes sense, however, I need more time to
think about the idea of automatic unnesting. I'm wondering if we can make
it less implicit.
As for me, I would expect the previous behavior, that's how, for instance,
Spark data frames work, IIRC.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472529785, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1dwShANQpi5Q1EIyg-1oQY1XdHKEks5vWTfMgaJpZM4bh_oa
.

I checked a similar query in BigQuery:
SELECT location FROM UNNEST([
  STRUCT(STRUCT(1.0 as latitude, 2.0 as longtitude) as location, "abc" as userId)
]);

It returns:
[
  {
    "location": {
      "latitude": "1.0",
      "longtitude": "2.0"
    }
  }
]

I understand this PR, it make Beam to return:
[{
  "latitude": "1.0",
  "longtitude": "2.0"
}]

what happens without UNNEST. If you simply do SELECT a.location?
On Wed, Mar 13, 2019 at 10:55 AM Gleb Kanterov<EMAIL_ADDRESS>wrote:

I checked a similar query in BigQuery:
SELECT location FROM UNNEST([
STRUCT(STRUCT(1.0 as latitude, 2.0 as longtitude) as location, "abc" as userId)
]);
It returns:
[
{
"location": {
"latitude": "1.0",
"longtitude": "2.0"
}
}
]
I understand this PR, it make Beam to return:
[{
"latitude": "1.0",
"longtitude": "2.0"
}]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472536279, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1cX8xq_UbvjQFrt1pu75bQm353eBks5vWTuegaJpZM4bh_oa
.

Leaving the nested structure in place seem like it would be surprising to
users. For example:
Event:
location: ROW(Location)
A user would expect to be able to write the following:
pc.apply(ParDo.of(new DoFn....
@ProcessElement
public void process(@FieldAccess("location") Location loc) {
}));
(where Location is a POJO that matches the Location schema). However this
conversion will fail if the select actually returns an extra level of
nesting. In addition they would expect to be able to write:
pc.apply(ParDo.of(new DoFn....
@ProcessElement
public void process(@FieldAccess("location.lat") double lat) {
}));
But again, that will fail if the select leaves extra layers of nesting.
On Wed, Mar 13, 2019 at 10:59 AM Reuven Lax<EMAIL_ADDRESS>wrote:

what happens without UNNEST. If you simply do SELECT a.location?
On Wed, Mar 13, 2019 at 10:55 AM Gleb Kanterov<EMAIL_ADDRESS>wrote:

I checked a similar query in BigQuery:
SELECT location FROM UNNEST([
STRUCT(STRUCT(1.0 as latitude, 2.0 as longtitude) as location, "abc" as userId)
]);
It returns:
[
{
"location": {
"latitude": "1.0",
"longtitude": "2.0"
}
}
]
I understand this PR, it make Beam to return:
[{
"latitude": "1.0",
"longtitude": "2.0"
}]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472536279, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1cX8xq_UbvjQFrt1pu75bQm353eBks5vWTuegaJpZM4bh_oa
.

As I understand it, FieldAccess("location") would work only if we leave an extra layer of nesting.
I did few BigQuery experiments:
CREATE TABLE IF NOT EXISTS test.test (
  userId STRING,
  location STRUCT<latitude FLOAT64, longtitude FLOAT64>
);

INSERT INTO test.test (userId, location) VALUES ("abc", (123.0, 234.0));

SELECT location FROM test.test;
-- Row  location.latitude   location.longtitude
-- 1    123.0               234.0

SELECT location.latitude FROM gleb_test.test;
-- Row latitude
-- 1   123.0

I need to check how FieldAccess works today

But doesn't your BigQuery experiment confirm this behavior? You got back a
Row containing location.latitude and location.longtitude, not a Row of Row.
It does look like BigQuery flattened the filed names though.
On Wed, Mar 13, 2019 at 11:25 AM Gleb Kanterov<EMAIL_ADDRESS>wrote:

As I understand it, FieldAccess("location") would work only if we leave
an extra layer of nesting.

Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472547722, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1Zx9vkVCOc_1nO0c7hker6Ai-JK3ks5vWUKDgaJpZM4bh_oa
.

It created a schema with nested records, to confirm I did an experiment:
CREATE TABLE `test.test_schema` AS
SELECT location FROM test.test;

And I got:
location | RECORD | NULLABLE |
-- | -- | -- | --
location. latitude | FLOAT | NULLABLE |
location. longtitude | FLOAT | NULLABLE

This way it's more visible:
$ bq show --schema test.test_schema | jq
[
  {
    "fields": [
      {
        "type": "FLOAT",
        "name": "latitude"
      },
      {
        "type": "FLOAT",
        "name": "longtitude"
      }
    ],
    "type": "RECORD",
    "name": "location"
  }
]```

+Kenn for comment
This seems very surprising to me, to be honest. It's not what I would
expect. This behavior has some mathematical niceties (e.g. it makes select
distribute across a union of selectors), but seems like it's almost never
what a user actually wants.
In Beam, part of the goal of schemas is to interact seamlessly with user
types (such as Pojos), so users don't have to deal with Row objects (unless
they want to). The above example for ParDo is one (though the
implementation for that is not yet merged). Another examples is that users
might expect to be able to write:
PCollection locations = pc.apply(Select.fieldNames("location"))
.apply(Convert.to(Location.class));
And that will only work if the selected item matches the schema of
Location, not if it's a nested schema.
Maybe for now we should add an option to the Select transform so that the
user can specify which behavior they want?
On Wed, Mar 13, 2019 at 1:28 PM Gleb Kanterov<EMAIL_ADDRESS>wrote:

This way it's more visible:
$ bq show --schema test.test_schema | jq
[
{
"fields": [
{
"type": "FLOAT",
"name": "latitude"
},
{
"type": "FLOAT",
"name": "longtitude"
}
],
"type": "RECORD",
"name": "location"
}
]```
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472592272, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1YZ5-hg8j4BjFSrhQXI3ACpYTImyks5vWV9zgaJpZM4bh_oa
.

I did a similar experiment with Spark:
df = spark.createDataFrame(
    [{"userId":"abc", "location":{"longtitude":1.0,"latitude":2.0}}],
    T.StructType([
        T.StructField("userId", T.StringType()),
        T.StructField("location", T.StructType([
            T.StructField("longtitude", T.DoubleType()),
            T.StructField("latitude", T.DoubleType()),
        ])),
    ])
)

df
> DataFrame[userId: string, location: struct<longtitude:double,latitude:double>]

df.select("location")
> DataFrame[location: struct<longtitude:double,latitude:double>]

df.select("location.latitude")
> DataFrame[latitude: double]

So select(location.latitude) in Spark matches the unnest semantics, but
select(location) does not. So Spark is inconsistent in itself?
On Wed, Mar 13, 2019 at 1:54 PM Gleb Kanterov<EMAIL_ADDRESS>wrote:

I did a similar experiment with Spark:
df = spark.createDataFrame(
[{"userId":"abc", "location":{"longtitude":1.0,"latitude":2.0}}],
T.StructType([
T.StructField("userId", T.StringType()),
T.StructField("location", T.StructType([
T.StructField("longtitude", T.DoubleType()),
T.StructField("latitude", T.DoubleType()),
])),
])
)
df

DataFrame[userId: string, location: structlongtitude:double,latitude:double]

df.select("location")

DataFrame[location: structlongtitude:double,latitude:double]

df.select("location.latitude")

DataFrame[latitude: double]

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472601323, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1b9I4gFnsRpq_v48XBuWOzKWwpUmks5vWWV5gaJpZM4bh_oa
.

As I understand, the approach is to take the last element in the field path, as I see, BigQuery works the same way:
CREATE TABLE `test.test_schema_2` AS
SELECT location.latitude FROM test.test;

$ bq show --schema test.test_schema_2 | jq
[
  {
    "type": "FLOAT",
    "name": "latitude"
  }
]

It seems that Spark allows duplicate column names:
df.select("location.latitude", "location.latitude").printSchema()
root
 |-- latitude: double (nullable = true)
 |-- latitude: double (nullable = true)

And BigQuery doesn't:
Duplicate column names in the result are not supported. Found duplicate(s): latitude

I don't actually see a contradiction here. When you SELECT location or when you df.select("location") the output is a row with a single column containing a location struct. This is because the value of the selected field is a struct and it gets a default name. That's what this is:
[
  {
    "location": {
      "latitude": "1.0",
      "longtitude": "2.0"
    }
  }
]

It isn't maintaining the original structure of the input row, it is a list of rows, and each row has a column you selected, and that column contains a struct.

 It should be one column containing a row with the two fields. Is it just for display purposes?

Ok this makes sense then.
As I see it BigQuery (and Spark) is unnesting just like this PR doees. The
difference is that it then creates a new Row to contain the selected
result.   I would
assume that select("location.*") would return a row containing a latitude
and a longitude.
We could validate this by nesting the location three layers deep. In that
case I suspect BQ would return the same thing it did in the above
experiment, not a three-layered nested row.
On Wed, Mar 13, 2019 at 2:39 PM Gleb Kanterov<EMAIL_ADDRESS>wrote:

As I understand, the approach is to take the last element in the field
path, as I see, BigQuery works the same way:
CREATE TABLE test.test_schema_2 AS
SELECT location.latitude FROM test.test;
$ bq show --schema test.test_schema_2 | jq
[
{
"type": "FLOAT",
"name": "latitude"
}
]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472616525, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1XIPD-j12E_DRmJcDaVECYPizaOcks5vWXAhgaJpZM4bh_oa
.

@kennknowles it isn't flattened, you are right:
SELECT location FROM test.test;

Gives
[
  {
    "fields": [
      {
        "type": "FLOAT",
        "name": "latitude"
      },
      {
        "type": "FLOAT",
        "name": "longtitude"
      }
    ],
    "type": "RECORD",
    "name": "location"
  }
]

Makes sense. I tried and both BigQuery and Spark have consistent behavior for selecting rows nested in rows:
df.printSchema()
root
 |-- userId: string (nullable = true)
 |-- position: struct (nullable = true)
 |    |-- location: struct (nullable = true)
 |    |    |-- longtitude: double (nullable = true)
 |    |    |-- latitude: double (nullable = true)

df.select("position.location").printSchema()
root
 |-- location: struct (nullable = true)
 |    |-- longtitude: double (nullable = true)
 |    |-- latitude: double (nullable = true)

Always adding one extra row around whatever is selected makes sense in
Spark and BQ, because it makes selection consistent between primitive and
nested types. Select must always return a row, so if you select userId, it
returns a Row with a single string field (not a scalar string field). Spark
and BQ have therefore decided to treat nested rows the exact same way: even
though the nested row could be returned directly, it is treated
consistently like primitive types and boxed inside a result row.
On Wed, Mar 13, 2019 at 4:09 PM Gleb Kanterov<EMAIL_ADDRESS>wrote:

Makes sense. I tried and both BigQuery and Spark have consistent behavior
for selecting rows nested in rows:
df.printSchema()
root
|-- userId: string (nullable = true)
|-- position: struct (nullable = true)
|    |-- location: struct (nullable = true)
|    |    |-- longtitude: double (nullable = true)
|    |    |-- latitude: double (nullable = true)
df.select("position.location").printSchema()
root
|-- location: struct (nullable = true)
|    |-- longtitude: double (nullable = true)
|    |-- latitude: double (nullable = true)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-472641498, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1X7rouPUfs4n2cmi2PS6w6iTZj-Uks5vWYVCgaJpZM4bh_oa
.

@kanterov I'm changing the semantics here to always return a new row, matching BigQuery and Spark. Will ping once that's done.

@reuvenlax To avoid miscommunication, I didn't reply anything not because I wasn't certain about the solution or something wasn't clear, but because I didn't have time to continue the review.

@kanterov I've changed the implementation to always wrap the selected output with a Row. This matches what SQL and Spark does, and is also more self-consistent: it means that selecting a nested Row is the same as selecting a nested Integer).
One concern is that users will want to use the Convert function to convert the result to their POJO (e.g. .apply(Select.fieldNames("location")).apply(Convert.to(Location.class)). So I've also modified the Convert transform to allow automatic unboxing of Rows in this case.
I will have push one more commit adding extra test coverage, however the functionality is already pushed.

New unit tests pushed

Sounds good. I will take a look tomorrow

The Spark behavior looks right to me.

@kennknowles I'm not 100% sure whether the better behavior is what Spark is doing or not. @kanterov  do you know what Spark does if you select from an array of an array (without the row in between)?

@kennknowles The Spark behavior might be better because it preserves the resulting structure if more field are added. I mean the following. Consider this schema:
S1:
a: ARRAY[ROW(S2)]
S2:
b: INT32
c: ARRAY[ROW(S3)]
S3:
d: INT32
now if you Select.fieldNames("a.c.d"), with my current PR you will get back { ARRAY[ARRAY[{d: INT32}]] }. This itself is fine, but consider what happens  if you Select.fieldNames("a.c.d", "a.b") with this PR. You will suddenly get back { ARRAY[{ b: INT32, c: ARRAY[{ d: INT32} ]] }. A new row suddenly got inserted because we needed an extra field. If we adopt the Spark approach, then the structure always stays the same, because the row is already there.

@kanterov so far I can't repro this actually. I wrote a test, but it appears to match the Spark behavior. I'll try to exactly copy your example and see what happens

Ok, I was reading the Spark result backwards. Spark is eliding the intermediate Row (just returning [][]) and we are not. The behavior in this PR has the advantage of not suddenly changing when two fields are selected, which is why I chose it.

It's hard to read outputs of Spark vs. Beam, I will try to put it in a better way.
Given an example from @reuvenlax:
S1:
  a: ARRAY[ROW(S2)]

S2:
  b: INT32
  c: ARRAY[ROW(S3)]

S3:
  d: INT32

Outputs are:
|                      | spark                                                | beam                                                    |
|----------------------|------------------------------------------------------|---------------------------------------------------------|
| select("a.c")        | `struct<c:array<array<struct<d:int>>>>`              | `struct<a:array<struct<c:array<struct<d:int>>>>>`       |
| select("a.b")        | `struct<b:array<int>>`                               | `struct<a:array<struct<b:int>>>`                        |
| select("a.c", "a.b") | `struct<c:array<array<struct<d:int>>>,b:array<int>>` | `struct<a:array<struct<b:int,c:array<struct<d:int>>>>>` |

I would try to summarize my understanding of Spark properties:

resulting schema of select(<xs : x>), would always have a field named x, and schema will match the corresponding schema for <xs : x> path in the input schema
if there is select(<path1>, <path2>), resulting schema is union of select(<path1>) and select(<path2>)

I also uploaded the notebook I used for Spark: https://gist.github.com/kanterov/78972d40ebe5b6f5c553b5a018dbb0bf
You can get local Spark instance with Jupyter with:
$ docker run -p8888:8888 -it jupyter/pyspark-notebook

Or using Dataproc

Spark has an implementation of schema prunning, that behaves similar to the code in this PR (preserves schema structure). It was introduced in https://github.com/apache/spark/pull/21320, there is a test suite demonstrating it's behavior https://github.com/apache/spark/pull/21320/files#diff-3131013c95ca682e798070a2d50d6896.
As I understand, it isn't used in user-facing API, only for pushing down projections into Parquet data source.

Oh, I see now. The issue is eliding the array layers actually.

I think the summary by @kanterov is super clear are the right approach, but I don't know if I would call that "union" so much as row building.
For SQL I would state this as SELECT <expr1 : name1>, <expr2, name2> ... each result is a new row containing the columns name1, name2 etc and the type of each column is the type of the expression.
Now for raw Beam if you select just a single column and the type of that column can convert to a Java type, you shoulud be able to convert. Specifically:

row with one int column convertible to int
row with one row column matching a POJO can convert directly

This is a step towards a thing mentioned in the Go SDK coders thread:

row with one bytes column w/ coder metadata equivalent to today's approach of coders

Given that this is mostly an issue eliding nested arrays, I wonder if we
should merge this PR and file a JIRA for the nested array case. We can
discuss the correct behavior on the JIRA. This PR seems more correct than
the old behavior.
On Fri, Mar 22, 2019 at 10:12 AM Kenn Knowles<EMAIL_ADDRESS>wrote:

I think the summary by @kanterov https://github.com/kanterov is super
clear are the right approach, but I don't know if I would call that "union"
so much as row building.
For SQL I would state this as SELECT , <expr2, name2> ...
each result is a new row containing the columns name1, name2 etc and the
type of each column is the type of the expression.
Now for raw Beam if you select just a single column and the type of that
column can convert to a Java type, you shoulud be able to convert.
Specifically:

row with one int column convertible to int
row with one row column matching a POJO can convert directly

This is a step towards a thing mentioned in the Go SDK coders thread:

row with one bytes column w/ coder metadata equivalent to today's
approach of coders

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/8006#issuecomment-475703407, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1QmldObUjrqJDswOV3CXYalW27aCks5vZQ77gaJpZM4bh_oa
.

@kanterov I'm surprised that Spark cannot resolve select("a.c.d"). Is there a reason for that?

@reuvenlax I was surprised to see that Spark didn't resolve select("a.c.d")
Agree that we should keep iterations quick, and given API is heavily experimental we could move forward with increments. I think we did a good analysis, and now the problem better. However, we still don't have a good formalization of desired semantics.
I'm going to revisit the code again, didn't have time to check this today.

@reuvenlax I've tried the following test:
  @Test
  public void testSelectFieldOfRecord() {
    Schema f1 = Schema.builder().addInt64Field("f0").build();
    Schema f2 = Schema.builder().addRowField("f1", f1).build();
    Schema f3 = Schema.builder().addRowField("f2", f2).build();

    Row r1 = Row.withSchema(f1).addValue(42L).build(); // {"f0": 42}
    Row r2 = Row.withSchema(f2).addValue(r1).build();  // {"f1": {"f0": 42}}
    Row r3 = Row.withSchema(f3).addValue(r2).build();  // {"f2": {"f1": {"f0": 42}}}

    FieldAccessDescriptor fieldAccessDescriptor = FieldAccessDescriptor
        .withFieldNames("f2.f1")
        .resolve(f3);

    Schema outputSchema = SelectHelpers.getOutputSchema(f3, fieldAccessDescriptor);

    Row out = SelectHelpers.selectRow(r3, fieldAccessDescriptor, r3.getSchema(), outputSchema);

    assertEquals(outputSchema, f2);
    assertEquals(out, r2);
  }

And it fails with an exception:
ava.lang.IllegalArgumentException: For field name f0 and type INT64 found incorrect class type class org.apache.beam.sdk.values.RowWithStorage
	at org.apache.beam.sdk.values.Row$Builder.verifyPrimitiveType(Row.java:724)
	at org.apache.beam.sdk.values.Row$Builder.verify(Row.java:587)
	at org.apache.beam.sdk.values.Row$Builder.verify(Row.java:571)
	at org.apache.beam.sdk.values.Row$Builder.build(Row.java:748)
	at org.apache.beam.sdk.schemas.utils.SelectHelpers.selectIntoRow(SelectHelpers.java:204)
	at org.apache.beam.sdk.schemas.utils.SelectHelpers.selectRow(SelectHelpers.java:167)

I don't see anything wrong with the test itself.

Good catch on that test. This was a bug in my code. I've fixed that bug and added your test.

@kennknowles and I discussed the array issue. We both think that the best approach is probably to distribute out array selects. However there are other options that should be discussed (e.g. completely unnesting arrays whenever a select happens), so we think this discussion should be brought to the dev list. This PR I believe is generally an improvement, so (assuming other comments are resolved) I think we should merge it and address array select semantics separately.

FYI by "distribute array selects" I mean the following:
if you have { a: {b: int, c: int}[] } and someone select "a.b", "a.c" the result should be {b: int[], c: int[]}. The same should be true if someone selects a.*. However if someone selects just a, you get the original schema back.

I think we can merge and iterate from there, but there are still issues with semantics that can be discussed separately.

@kanterov looking. I suspect my fix to the last issue you found is what caused this use case to break.

@kanterov I believe actually that the bug is in your test.  You have:
Schema outputSchema = SelectHelpers.getOutputSchema(f3, fieldAccessDescriptor);
when it should be
Schema outputSchema = SelectHelpers.getOutputSchema(f4, fieldAccessDescriptor);
When I fix this, the test now passes.

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

@kanterov I went ahead and changed array and map selects to distribute the select. This preserves the invariant that the field name selected is always the one that appears in the resulting schema, and I believe is closer to what Spark does.
I still think we should have a thread on the dev list to discuss the detailed semantics, as we still might want to change them. However I think with this last commit, we are probably closer to where we want to end up.

@kanterov did you have any further comments on this PR?

@reuvenlax sorry for the delay, LGTM 👍 please feel free to merge when you are comfortable with it


Only show gpx/kml download options when there is actually gpx/kml to download

The dropdown menu at the top of every canyon containers options to download gpx/kml data even if the canyon has none.
It would make more sense to only show these options if the canyon does have gpx/kml data to show. This would be inline with how the links beneath the embedded map change if there is/isn't data available.
Menu:

Reported here: https://www.facebook.com/groups/ropewiki/posts/3475210852692231

Fixed


Add data to RestSerialization failures

If Freddy throws an error while trying to parse the JSON response from a service, the error is caught and turned into an error message (see here for example).
Unfortunately, the data itself is not included in the error message. It would often be helpful to include the response data, because it may have important information for the client.
Let's look at adding the data (interpreted as a string) to the error object that is returned.

One possibility would be to change serializationError(_:) to serializationError(_:data:). The function would then interpret the data parameter as a String and include it in the generated NSError.

This should be considered as part of the more general issue #476.


How many marks per table is suggested?

Taken from Yegor Andreenko blog post about primary keys:

Data structure of primary key looks like an array of marks — it’s values of primary key every index_granularity rows.

Then marks are used to skip data blocks, so that queries read much less data from the table.
Let's say I have a table with 1 billion rows. 10 million unique primary keys( 10 million different user_id in the following table).
CREATE TABLE foo(
    user_id UInt64,
    event_date Date,
) ENGINE= MergeTree(event_date, (event_date), ? )

SELECT countDistinct(user_id) FROM foo;
= 10,000,000

In this case having 10 million marks is great since for queries involving primary key will instantly hit relevant data block. So why are we not setting index_granularity to certain value to have 10 million marks? If I have a 1 billion rows table with 10 million unique user_id, I can use 128 as index_granularity since 1B/10M = 100.
My question is,
1- Why is 8192 recommended for index_granularity and lower values are not recommended?
2- How many marks for a table is suggested? Is 10 million to much? If it is, 10M*8 bytes = 80 MB, which is a tiny fraction in server memory.

I think it depends on your data. You're trading off memory that can be otherwise used for page cache. Also the lookup time in the sparse index isn't constant, but log(N) I think, so the bigger the index, the more time it takes to search it. Scanning 8191 unnecessary rows is not that expensive (when reading from disk, you'll have to read a whole block anyway) and the index can fit in memory even for tables with trillions of rows, which makes it a good default value. If you have a table with a known size and an extra memory, feel free to experiment and find out what works best for you.

@ramazanpolat do you have any further questions?


GPL-878-3 - Multiplexing - I need to be able to add samples(requests) to the pool

User story
Multiplexing - I need to be able to add samples(requests) to the pool
Who are the primary contacts for this story
Craig / Iraad
Acceptance criteria
To be considered successful the solution must allow:

[ ] I want to be able to select multiple samples and then magically add them to the pool
[ ] Any selected samples will appear in a separate area on the page
[ ] The sample information will include the sample name and the source
[ ] Show a warning when a sample has been selected more than once

Dependencies
This story is blocked by the following dependencies:

#<issue_no.>
sanger/#<issue_no.>

References
This story has a non-blocking relationship with:

#<issue_no.>
sanger/#<issue_no.>

Additional context
Do they need to be able to sequence a sample multiple times?

Plan of action
[ ] Update selected requests getter
[ ] Update select request mutations
[ ] Clicking wells should generate select request mutations
- Will need to consider component reusability here, so will probably need to bubble up well clicked events
- Should be a toggelable action
[ ] Selected wells should be clearly identified
[ ] Look at list view, list view should generate same events
- May even be possible to bubble up the same event as the plate view.

So with event stuff I'm taking the following approach:

The well component has a standard click event, which gets emitted to the plate. It doesn't attempt to do anything fancier as it felt wrong to start making what is essentially a circle care about the underlying data too much.
The plate in turn emits a clickWell event, with the well id as an argument
It's in PacbioLabwareSelectedList that we begin trying the clicking action to the actual behaviours we want.
But the actual logic will all exist in an action that will call the various mutations (usually just the one)

The current approach isn't great at handling wells with multiple requests, but I don't think that's something we'll actually see. Will be revising this as things go on though


Update build.gradle.kts

Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 97.79%. Remained the same when pulling dc40c465bfa16e835aa2e81e061b6d2d1656447b on update-to-3.2.0-SNAPSHOT into 5346a26eed8052be7de35c17518eb357589f25c6 on main.


External API not accessible by k8s api

I have removed all conditions and directly enabled external.metrics api , after the deployment when I checked from this command at below
kubectl get --raw "/apis/external.metrics.k8s.io/v1beta1"
That is the result :  Error from server (NotFound): the server could not find the requested resource
But this request is returning 200 kubectl get --raw "/apis/external.metrics.k8s.io" . What is the reason of this issue ?

I have rules but now Resource are returning null


Rebase DS Autotuning to DeeperSpeed 2.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 5 committers have signed the CLA.:white_check_mark: dashstander:white_check_mark: MLRichter:white_check_mark: StellaAthena:x: Dashiell Stander:x: Quentin-AnthonyDashiell Stander seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


set the cookie expiration time

Approving:

Cookie expiry time is set to 60 minutes with sliding expiration
Updated startup.cs file with validated antiforgerytoken
Ignore antiforgery token for webhook
Referencing antiforgery token from form element


SAK-30601 - Upgraded basic LTI dashboard

Upgraded basic LTI dashboard
SAK-30601 : v0.1

Replaced "attribution" column (Department) search field by a selector
Some modifications based on comments from pull request

SAK-30601 : v0.2

added search for URL and created_add columns*
added sort by URL*
modified LTI URL link (tool_url)
solved some little bugs

Now Foorm search supports 'and' and 'or' separators, and 'null' and
'date' values

Signed-off-by: Miguel Carro Pellicer<EMAIL_ADDRESS>

There is some original discussion about this on a ticket that was for merge to 11.x #2071

@buckett So do you suggest to wait until the discussion gets concluded? Thanks Matthew!

This doesn't currently merge.

@buckett Rebased.
Travis failed for other reason.

Do you have any general concerns about making this sort of change to the LTI admin tool @csev
I kicked of another build and it passed this time.

This looks like a great fix - several of these things have been on my "to do list" for a while.  Is there a server where I can play with it?  Or is there a git command I can cherry pick it into my own dev instance to play with it?

@csev, yes we have instructions for this @ https://confluence.sakaiproject.org/display/SAKDEV/Git+Setup. Look for the 'Reviewing Pull Requests' section.


Tried To Install It

if (!requireNamespace("remotes", quietly = TRUE))

install.packages("remotes")

remotes::install_github("clemenshug/enrichr.db")
Downloading GitHub repo clemenshug/enrichr.db@master
√  checking for file 'C:\Users\Nathan\AppData\Local\Temp\RtmpiO1CaQ\remotes5f6c4077c70\clemenshug-enrichr.db-8cb1a3d/DESCRIPTION' (464ms)

preparing 'enrichr.db':
√  checking DESCRIPTION meta-information ...
checking for LF line-endings in source and make files and shell scripts
checking for empty or unneeded directories
looking to see if a 'data/datalist' file should be added
building 'enrichr.db_<IP_ADDRESS>00.tar.gz'

Installing package into ‘C:/Users/Nathan/Documents/R/win-library/3.6’
(as ‘lib’ is unspecified)

installing source package 'enrichr.db' ...
** using staged installation
** R
** data
*** moving datasets to lazyload DB
Warning: file 'enrichr_terms.rda' has magic number 'versi'
Use of save versions prior to 2 is deprecated
Error in load(zfile, envir = tmp_env) :
bad restore file magic number (file may be corrupted) -- no data loaded
ERROR: lazydata failed for package 'enrichr.db'
removing 'C:/Users/Nathan/Documents/R/win-library/3.6/enrichr.db'
Error in i.p(...) :
(converted from warning) installation of package ‘C:/Users/Nathan/AppData/Local/Temp/RtmpiO1CaQ/file5f6c8f11b/enrichr.db_<IP_ADDRESS>00.tar.gz’ had non-zero exit status

Thanks Nathan! It looks like Git LFS was required to download the repo correctly. I switched to distributing the package as binary release instead, that should hopefully work easier.


Add HexTile property support

Allow users to define their own properties for HexTiles. To ease use, HexTile supports quick references to and caching of three of the most common property types (int, bool and float).

Update readme to include notes about new dependency on SerializableDictionaryLite
Add IHexTileProperties<T> interface
Add implementations of IHexTileProperties for commonly used types

Add implementations of SerializableDictionaryBase for the same types

Update HexTile with convenience methods to get properties
Add new sample to demonstrate HexTile properties

Test runner fails because this change includes a new dependency on a 3rd party package, and test runner does not support non Unity dependencies in "package mode."
Unit tests passed locally

Close #34


Enhance Footer with Essential Links (Contact, Terms of Service, Privacy Policy)

Description
Currently, our website's footer lacks essential links such as contact information and pages for Terms of Service and Privacy Policy. To improve user experience and ensure compliance, we should add these links to the footer. This enhancement will enhance navigation convenience and provide transparency regarding our policies and contact details.
Tasks

Add a contact information link (email, phone, or contact form).
Include links to the Terms of Service and Privacy Policy pages.
Ensure links are styled and positioned appropriately in the footer.

Expected Outcome
Users will easily find essential information and legal policies, improving trust and accessibility on our website.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100
I think it will make better experience

yes @Rakesh9100 Please assign it to me I want to work on this issue. Also, please add the label GSSOC and the level that you find appropriate for this issue. thank you!

Contact information can be added, but TOS and PP is not required!
Go ahead @lovelymahor


HSEARCH-3343 Upgrade to Hibernate ORM 5.3.6.Final

https://hibernate.atlassian.net//browse/HSEARCH-3343
Just checking if the CI build passes.

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 86.608%

Totals

Change from base Build 4:
1.9%

Covered Lines:
10095

Relevant Lines:
11656

💛  - Coveralls


Network interfaces are missing tags

Please add a network interface tag specificiton to inherit parent tags here
tag_specifications {
         resource_type = "network-interface"
         tags =  var.tags merge with defaults
        }

https://github.com/terraform-aws-modules/terraform-aws-eks/blob/32f70afe602cc96e89f31e3562bf237d80482a4b/workers_launch_template.tf#L255

Thanks for opening this issue. @alexmnyc Can you please open a PR to address this ?

Sure thing

Done https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1362

bump

PR is here https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1362

Hello @barryib , @antonbabenko
Do you have any plans to implement it? It looks like it's already implemented in https://github.com/hashicorp/terraform-provider-aws/pull/20409

Hello @antonbabenko
Please review the PR: https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1563


DO NOT MERGE: Minimal example for representation

Produce a source distribution by:

Clone the repo
Checkout this branch
Delete Git by running rm -rf ./.git

Then test if the no-git version in the shared drive:

installation works with a pared-down version
training and prediction works with the example file

@ziw-liu , I tried doing a fresh installation. I am getting the following error:

(dynaclr) soorya.pradeep@SFO-IT0358 viscy % pip install -e ".[visual,metrics]"
Obtaining file:///Users/soorya.pradeep/Documents/GitHub/Dynaclr/viscy
Installing build dependencies ... done
Checking if build backend supports build_editable ... done
Getting requirements to build editable ... done
Preparing editable metadata (pyproject.toml) ... done
Collecting iohub==0.1.0 (from viscy==0.3.0a1)
Using cached iohub-0.1.0-py3-none-any.whl.metadata (6.5 kB)
INFO: pip is looking at multiple versions of viscy to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement torch>=2.4.1 (from viscy) (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2)
ERROR: No matching distribution found for torch>=2.4.1

@Soorya19Pradeep Seems like you are testing on macOS. Can you share the output of this:
python -c "import torch; print(torch.mps.device_count())"

Can you also test on Linux?

@Soorya19Pradeep also if you are using conda, it's helpful to look at the output of conda info to make sure that arm64 is used instead of x86_64.

@ziw-liu , I tried it on an HPC OnDemand session. It does work there.
conda info does show x86_64.

(dynaclr) soorya.pradeep@SFO-IT0358 viscy % conda info
 active environment : dynaclr
active env location : /opt/miniconda3/envs/dynaclr
        shell level : 2
   user config file : /Users/soorya.pradeep/.condarc

populated config files :
conda version : 4.11.0
conda-build version : not installed
python version : 3.9.19.final.0
virtual packages : __osx=10.16=0
__unix=0=0
__archspec=1=x86_64
base environment : /opt/miniconda3  (writable)
conda av data dir : /opt/miniconda3/etc/conda
conda av metadata url : None
channel URLs : https://repo.anaconda.com/pkgs/main/osx-64
https://repo.anaconda.com/pkgs/main/noarch
https://repo.anaconda.com/pkgs/r/osx-64
https://repo.anaconda.com/pkgs/r/noarch
package cache : /opt/miniconda3/pkgs
/Users/soorya.pradeep/.conda/pkgs
envs directories : /opt/miniconda3/envs
/Users/soorya.pradeep/.conda/envs
platform : osx-64
user-agent : conda/4.11.0 requests/2.27.1 CPython/3.9.19 Darwin/21.5.0 OSX/10.16
UID:GID : 502:20
netrc file : None
offline mode : False


Exception code: C0000005 ACCESS_VIOLATION at 01B2C047

I am running GMS on my server, and the system works fine. But occasionally the server has a hard crash, always related to GMS.
Latest log entry tries to place a unit group at a position outside of the map:
11:08:01 "[GMSCore]   Spwan Infantry Group: No Position Specified or position = [0,0,0]"
11:08:02 Out of path-planning region for O Charlie 3-2:2 at 1.3,0.0, node type Grid
11:08:02 Error O Charlie 3-2:2: Invalid path from [0.00, -1.19, 0.00] to [5.10, 0.09, 23.79].
11:08:03 y (4096) out of range <0, 1024)

Exception code: C0000005 ACCESS_VIOLATION at 01B2C047

GMSCore does throw those errors when running GMS_RC. I believe it is nothing to worroy about. The Access_violation error is not one I have seen. I would be sure that all of your game files are validated and repack any pbo's you are using. Are you seeing AI groups that are not moving? That might be caused by the path-planning faults. The memory error's I do not know the cause of.