Compile-on-build conflicting with Compile-on-save

It seems that when Visual Studio compiles TS into JS, there are some inconsistencies, resulting in a ping-pong match with commits. Specifically, when compiling from a solution build, the yielded .js is different from the .js resulting from compiling from a save.
For one (simple) example, compile-on-save will use enums:
_this.kernelState(NotebookKernelState.Queued);

Where compile-on-build will use constants w/ comments:
_this.kernelState(5 /* TimeExpired */);

Another example is how they vary their formats (this may be related to ReSharper settings, though not sure how to make these sync between build compiles and save compiles):
Compile-on-save:
catch (e) { }

Compile-on-build:
catch (e) {
}

I'll also see the sourceMappingUrl comment get removed with compile-on-save:
//# sourceMappingURL=myfile.js.map

Then get added back on with compile-on-build.
Is this a bug, or is it something that we may have misconfigured somewhere?

Which version of TS and VS are you using? and can you share a repro project?

The attached project (remove .png) can repro the .map comment and the enum. Note that the enum difference only appears when targeting 1.4 -- targeting 1.6 makes these consistent between save and build compiles. But the .map comment is there in 1.4 and 1.6.
I couldn't repro the formatting difference in this project (yet), so I'm thinking that has something to do with project-level ReSharper settings. If I can get this to repro, I'll let you know.

Thanks for the repro. the first issue has been fixed in TS 1.5 (see #1812). the formatting issue is strange, have not seen this before. as for the last issue, looks like this project file does not have any configuration options. adding config options, either manually by unloading the project or by saving from the project property pages solves the issue:
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
    <TypeScriptSourceMap>True</TypeScriptSourceMap>
  </PropertyGroup>

how was this project created? is that from template? or hand authored?

It was created using VS empty web project template.
I will try the source map config to see if that fixes that issue.

looks like we are not loading the property correctly. @paulvanbrenk can you take a look. i see the source map checkbox checked correctly in the project property pages but not passed correctly to the compiler..

This looks like it's fixed in 1.8


cmake: Fix the complier format error

If check the complier format, many errors will
show "zero-length gnu_printf format string", unless
a fixed cmake version is specified.So do not ckeck the
complier format can aviod that.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/47588
Signed-off-by: Shaoan Li<EMAIL_ADDRESS>

This is not fixing the root cause and basically un-does what has been done in 69913ad.

"check_set_compiler_property tests the specified flags individually" is not the root cause. we get the check result from cmake, not cc1.
call check_set_compiler_property with -Wformat-zero-length alone will definitely get a cc1 warning
cc1: warning: '-Wformat-zero-length' ignored without '-Wformat' [-Wformat-zero-length]
but the check passed with cmake 3.21.0, 3.22.0 and 3.24.0, only failed with cmake 3.23.*. We can't control which cmake version user should use, we can use "set_compiler_propterty" to work with all different versions of cmake.

we get the check result from cmake

and how does CMake determine the "check result"?
Based on the description of the check_c_compiler_flag function, a warning (i.e. diagnostic) is a valid reason for it to return false and it should return false.

Check that the <flag> is accepted by the compiler without
a diagnostic.  Stores the result in an internal cache entry
named <var>.

As far as I know, a fail regex
FAIL_REGEX "warning: .* ignored"
is added in cmake 3.23.0-rc1 https://github.com/Kitware/CMake/commit/f745e0497ee71d35fd1b3524b1636a72da76c266
and removed in cmake 3.24.0-rc1 https://github.com/Kitware/CMake/commit/4941887d7defecb3016d2bd94d3a45754251ca56
I hope that can explain it.

[...] is added in cmake 3.23.0-rc1 and removed in cmake 3.24.0-rc1

and there is no guarantee that CMake will add the warning as a failure in the future; they even noted in the commit message:

Revert the change pending further investigation.

In fact, based on the description of the check_c_compiler_flag function, the warning should indeed be treated as a "failure" and the function should indeed return false.

"check_set_compiler_property tests the specified flags individually" is not the root cause.

That IS the root cause. What you are doing here is effectively hiding this very real problem under the rug.

The root cause is cmake or "check_c_compiler_flag", it doesn't return a result as it should indeed return, it's not the "check_set_compiler_property"'s fault. When cmake's problem is fixed, we can refine this function.

The root cause is cmake or "check_c_compiler_flag", it doesn't return a result as it should indeed return

Whether it should treat "warning: .* ignored" as a failure seems controversial and, as noted in https://github.com/Kitware/CMake/commit/4941887d7defecb3016d2bd94d3a45754251ca56, even the CMake maintainers themselves do not seem to be fully sure whether it should be or not.
As I already noted above, "based on the description of the check_c_compiler_flag function, the warning should indeed be treated as a "failure" and the function should indeed return false."
"check_set_compiler_property tests the specified flags individually" IS the root cause -- causing GCC to generate warnings like "cc1: warning: '-Wformat-zero-length' ignored without '-Wformat' [-Wformat-zero-length]`" because it tests the specified flags individually ignoring the dependencies among them.
For now, this may only affect CMake 3.23.x, but there is no guarantee that the CMake maintainers will eventually decide "warning: .* ignored" should indeed be a failure and a future release of CMake will (again) return false in case of any warnings like warning: '-Wformat-zero-length' ignored without '-Wformat'.
Hence, the root cause fix would be to implement a mechanism for check_set_compiler_property to specify the dependencies among the flags, or at least specify the supplementary flags that must be specified when testing a flag.
Now, implementing the root cause fix suggested above is not trivial and should be done in a separate PR.
But then, simply to revert 69913adc8001c97366724b108c4bc44ada4163fc and use set_compiler_property instead of check_set_compiler_property will likely re-introduce the very issue that the commit was trying to fix.
I have done a further investigation on this matter and, as far as GCC/g++ is concerned, it does not seem to complain about the flags now set without checks by set_compiler_property in this PR, so the workaround suggested in this PR should be ok; but, we should at least note these details in the comments.

temporary blocking to allow a little time to try and support groups of flags to be tested instead of simply trying to set those flags.

@shaoanxli please find a better fix here which allows us to group options for testing: #50097

Superseded by #50097


Issue with auth failing randomly

I added auth for Spotify and designed a query. I then exported the handler. When I test, it runs right about half the time, and then the other half gives me an error:
Missing auth for Spotify. Please reauthenticate.

There seems to be no rhyme nor reason for it going back and forth like that.

It's possible this is a ntl dev only issue. In production, it seems to always work: https://www.raymondcamden.com/api/latestTracks

I have the same issue. In my case it seems to occur mostly when running NetlifyGraph.fetchFoo() from Remix's action handler (ie. as a result of form POST request) as opposed to the loader.

Thanks for this feedback. We are archiving this repo now that these docs have moved over to docs.netlify.com. If you have further feedback on Netlify Graph, please fill out our survey.


Discussion: the location of org-clock-save.el file

Hello @hlissner,
The ~/.emacs.d/ folder always showing the untracked file org-clock-save.el sometimes get annoying, would it be ok to move it to ~/.emacs.d/.local/?
In the org config file it sets:
  (setq org-clock-persist 'history
        org-clock-persist-file (concat doom-etc-dir "org-clock-save.el"))

by the way, I remember a recent commit you had changed this type of naive concatenation of file path, maybe here is also a place we should change the use of concat? Thank you.
Best regards
Joey

This confuses me. The lang/org module configures org-clock to put its cache in ~/.emacs.d/.local/etc. This should prevent ~/.emacs.d/org-clock-save.el from appearing. Is this not the case?

naive concatenation of file path

I am selective about which paths I use expand-file-name (smart concatenation) and concat (naive) on, mostly out of minor (possibly premature) concerns for performance. I choose concat on paths I'm certain end in a slash, and I am certain doom-etc-dir will. It is built using doom-emacs-dir, which is an alias for user-emacs-directory, which requires that it end with a slash.
doom-private-dir, however, can be changed depending on the value of the XDG_CONFIG_HOME envvar; or may be customized by the user, thus naive concatenation can be a big gamble.
That said, this philosophy may not hold up to expanding Windows support for Doom. Time will tell.

My bad, I have a lot of org configuration and I some how forgot I had a setting shadowed your code, you are right, the doom put the file under .local/etc/. Closing this.


Update the instruction on authentication

Add info on the token expiration time.
Relates-To: OLPEDGE-2391
Signed-off-by: Halyna Dumych<EMAIL_ADDRESS>

Codecov Report

Merging #405 (c9e7505) into master (66422c4) will increase coverage by 0.0858%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #405        +/-   ##
================================================
+ Coverage   88.1377%   88.2234%   +0.0858%
================================================
  Files            72         72
  Lines          2470       2471         +1
  Branches        271        271
================================================
+ Hits           2177       2180         +3
+ Misses          162        161         -1
+ Partials        131        130         -1

Impacted Files
Coverage Δ

@here/olp-sdk-authentication/lib/UserAuth.ts
83.6364% <0.0000%> (+4.0068%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66422c4...c9e7505. Read the comment docs.


Composer global

Hi,
we have already dephpend in bin-Folder. Can you update your composer.json, that after "composer global require" we have dephpend ready for global usage. (https://getcomposer.org/doc/articles/vendor-binaries.md) Sorry for my english.

Hey @Ainaras thanks for the feedback.
Good point I forgot about supporting global composer install.  I'll try to get it in today.

(although I would recommend using the phar)

Fixed in c9dbd61c467195862fb6f7aa238f1481c4bac25c
If there are any other issues, please let me know. I also added php-trace to the binaries in case anyone is interested in playing with the dynamic analysis feature.
Now composer global require dephpend/dephpend:dev-master should do the trick.


action bar issue

I can hide action bar, but if tap on top of screen, bar is not show.

What version of Android are you using ? What version of Terminal Emulator
for Android are you using?
On Tue, Mar 31, 2015 at 1:26 AM pjk11<EMAIL_ADDRESS>wrote:

I can hide action bar, but if tap on top of screen, bar is not show.
—
Reply to this email directly or view it on GitHub
https://github.com/jackpal/Android-Terminal-Emulator/issues/409.

Confirm this is a problem for me too. Terminal Emulator 1.0.68, Android Version 4.4.4 ; it had been working until recently - I am a long time user of Terminal Emultator

Terminal Emulator 1.0.68, Android Version 4.4.4, Xperia e3 D2203

also can't do this :(
android 5.0.2
one plus one bacon
v1.0.68

related : The application crashed when pressing the back button
Possible crash location
Term.java@backKeyInterceptor
NullpointerException
Probably when checking for the action bar,
Android 4.4.4 Asus TF101,
I will also fill another bug report for the back button

commit 3b10abe26728e3f4ece56ca57f701b8597585a30 removed Theme.Holo.ActionBarOverlay style linked to the togglable actionbar in res/values/styles.xml  which is still referenced in Term.java:onCreate@356 to create the view with an overlay action bar

Theme.Holo.ActionBarOverlay still exists -- it is now in the values-v11/styles.xml , which is used for devices running API 11 or newer.

but then there is no explanation on why Term.onCreate is not able to get an action bar when the style used is this one ( which is why the fix #411 is imperfect , the mActionbar is not suppose to be null when it is toggle-able ), plus the action bar is not showing on the lastest market version when in auto-hide mode, I suspect it is not created as the method in onCreate is suppose to get an instance of it from the layout.

Should we set a android:targetSdkVersion for the actionbar to be available from the compat library


Made compatible with react 16.0.0 (#5)

Changes applied:

Components' definition updated.
Prop-Type module resolution updated.

😮 Don't forget to upgrade version 😃

Tnx for your pull request, but my coding style is not compatible with yours.
I like to mention that don't forget to add package-lock.json to gitignore file
and never add react as dependency when you don't need it.
Tnx again for the request.
You inspired me to update the code ;)


Heartdiabetes

Added validation for heart age and put balancer parameter for MEN & WOMEN while calculating cvd risk.

AI Code Review is in progress (usually takes <3 minutes unless it's a very large PR).


Add flamechart

https://esbuild.github.io/analyze/ has a nice flamechart view.
But I like esbuild-visualizer better as I can use it on the command line.
Would be amazing if this project could also support a flamechart view.

Nice, i can look into it. It does not looks complex. Looks like exactly like sunburst.


[Concurrency] Emit warning suggesting async function

This patch adds a diagnostic to recommend using the async function
instead of using the completion handler version. The diagnostic is only
emitted when the call is made in an async context and the
completion-handler version of the function is attributed with the
@completionHandleyAsync attribute.
Resolves: rdar://75221638

@swift-ci please smoke test

Nice one!
Thanks!

Would also offering a a fixitReplace be a bit too hard?
Yeah, Doug and I discussed what this would take and agreed that it probably should be a refactoring step and not a fix-it. Things like parameter re-ordering and pulling the code inside the completion handler out into the calling context make it a bit more challenging than a fix-it.

-- forgot to run git clang-format before pushing. Nothing semantic changed!
@swift-ci please smoke test

Nice one!

Thanks!

Would also offering a a fixitReplace be a bit too hard?

Yeah, Doug and I discussed what this would take and agreed that it probably should be a refactoring step and not a fix-it. Things like parameter re-ordering and pulling the code inside the completion handler out into the calling context make it a bit more challenging than a fix-it.

It is definitely a more involved fixit than anything we have now, but I was planning on adding it. The way the refactoring works is by replacing the whole call, so that should work fine with a fixit. We'd have to pull out the implementation from refactoring and make it a little more generic, but that shouldn't be too bad.
Note that the refactoring doesn't handle parameter re-ordering at the moment, but it wouldn't hurt to make it more robust regardless (it should check it at the very least).
Happy to leave the fixit out of this PR though :)

Sigh, so it just occurred to me that someone might want to do something like:
let asyncClosure = { () async -> () in }

@completionHandlerAsync("asyncClosure")
let compHandlerClosure = { (_ handler: @escaping () -> ()) -> () in }

@main struct Main {
  static func main() async {
    compHandlerClosure { print("yuup") }
  }
}

Checking this will take a bit more work, so I'll take care of that in a separate PR if that's alright.

Sigh, so it just occurred to me that someone might want to do something like:
let asyncClosure = { () async -> () in }

@completionHandlerAsync("asyncClosure")
let compHandlerClosure = { (_ handler: @escaping () -> ()) -> () in }

@main struct Main {
  static func main() async {
    compHandlerClosure { print("yuup") }
  }
}

Checking this will take a bit more work, so I'll take care of that in a separate PR if that's alright.

Does @completionHandlerAsync even work in that case at the moment? I thought we restricted it to functions?

Sigh, so it just occurred to me that someone might want to do something like:
let asyncClosure = { () async -> () in }

@completionHandlerAsync("asyncClosure")
let compHandlerClosure = { (_ handler: @escaping () -> ()) -> () in }

@main struct Main {
  static func main() async {
    compHandlerClosure { print("yuup") }
  }
}

Checking this will take a bit more work, so I'll take care of that in a separate PR if that's alright.

Does @completionHandlerAsync even work in that case at the moment? I thought we restricted it to functions?

No, it doesn't right now. I think this starts getting into property-wrapper syntactic territory, so maybe just leave it? I don't know, but it seems like something someone might try to do. I'm going to leave it for now though and pick it back up if it becomes a problem.

No, it doesn't right now. I think this starts getting into property-wrapper syntactic territory, so maybe just leave it? I don't know, but it seems like something someone might try to do. I'm going to leave it for now though and pick it back up if it becomes a problem.

Sounds good to me!

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Fix java17 PostCommit ARM test config issue

Java17 test suite failed because of test configuration issue:

which is caused by the --release flag added here: https://github.com/apache/beam/blob/a434a31507895ecfef3be94bdc1729cf376ebf56/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1489
This PR:

Replaced the --release flag with -source -target to compile, reference: https://github.com/eclipse-tycho/tycho/issues/619#issuecomment-1285022312
Removed Werror flag that causes all compiler warnings to be treated as errors, otherwise the tests would fail to compile.
Now All versions of PostCommit Java Dataflow Example ARM tests passed.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1086

Questions ?
Please refer to the Backport tool documentation


issue with plutosdr while transmitting signals

hello guyz,
i am running gps-sdr-sim source code with plutoSDR on linux ubuntu. i am facing issue while transmitting. it shows like transmit starts but then no output has been shown and then done. i am working since last month but still facing issue.
./plutoplayer -t gpssim.bin -a -30.0 -b 3.0 d ip:<IP_ADDRESS>
transmit file size: 285.63Mb
acquiring IIO Context
found 0456:b673 (Analog Devices Inc. PlutoSDR (ADALM-PLUTOSDR)), serial=104473222a870010efff0e003dadd5a342
Acquiring devices
Context has 5 devices
Acquiring TX device
Initializing streaming channels
Enabling IIO streaming channels
creating TX buffer
Transmit starts...
Done.
any suggestions will be appreciated. i am waiting to hear from you guyz.

While I'm not fluent in the PlutoSDR's software, this seems like more of an issue with their tools and less of a problem with this simulator. I assume for example that the simulator has created the binary file in the correct format for transmission, but you may want to verify that. If not, I would suggest examining the Mictronics/multi-sdr-gps-sim repository instead to see if that works better for you.


fix: Pin awscli python package for wmg pipeline

Reason for Change
#6626
NOTE: Pinning may not be the right solution as explained in the ticket. awscli might need to be kept up-to-date more frequently for security reasons. Pinning could be temporary measure until we fix the failing import.
Changes

add
remove
modify

Testing steps

Either list QA steps or reasoning you feel QA is unnecessary
Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
"Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎

[ ] Add product, design, and eng as reviewers for rdev review
[ ] For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
[ ] For UI changes, add e2e tests to prevent regressions
[ ] For UI changes, verify impacted analytics events still work

Notes for Reviewer

@Bento007 @ebezzi - We have reason to believe that the following exception might be temporary glitch:
File "/usr/local/lib/python3.10/site-packages/awscli/customizations/s3/subcommands.py", line 18, in <module>
    from botocore.utils import is_s3express_bucket
ImportError: cannot import name 'is_s3express_bucket' from 'botocore.utils' (/usr/local/lib/python3.10/site-packages/botocore/utils.py)

staging snapshot, which is only 1 second older, ran fine. I will re-run prod snapshot and see if the error happens again before attempting a fix. Keeping this PR open until then. Stay tuned....


GameruserSettings.ini overwritten

Hey Guys,
everytime i start the Server, he overwrite my Servername/Slot and the passwords...
i changed these commands in the arkmanager.cfg and in the GameuserSettings.ini
but nothing happens, always Ark Server Tools name and 70 slots -.-
I use ubuntu 14.04 and a fresh install...

It is the ARK server itself that overwrites the GameUserSettings.ini file.
If you want to specify these settings (ServerPassword, ServerAdminPassword, SessionName, MaxPlayers) in your GameUserSettings.ini file, then you need to comment out (i.e. prepend the line with a # character) the ark_ServerPassword, ark_ServerAdminPassword, ark_SessionName and ark_MaxPlayers settings in the /etc/arkmanager/arkmanager.cfg file.

Hey,
i have specified it in the GemuserSettings "AND" in the arkmanager.cfg.
After that doesnt work i comment out the variables in the arkmanager.cfg and changed it
a few times in the GameuserSettings.ini but he always overwrite it...
the Steam user has rights on the gameusersettings.ini and the rootuser on the arkmanager cfg,
so that should be alright, but why ignores the server my commands and change it back to the
defaults?

Did you perform a user-install (i.e. curl -sL http://git.io/vtf5N | bash -s -- --me) or a system-wide install (i.e. curl -sL http://git.io/vtf5N | sudo bash -s steam)?
Does ~/.arkmanager.cfg exist?  If both that file and /etc/arkmanager/arkmanager.cfg exist, and you don't want the settings in ~/.arkmanager.cfg to override those in /etc/arkmanager/arkmanager.cfg, then remove ~/.arkmanager.cfg.  Note that a user-install (i.e. using the --me argument to the install) would have created that file.

hmm... now the server dont start and i got errors like:
"[  ERROR  ]     You have not rights to write in the log directory.
The server is starting...
/usr/local/bin/arkmanager: line 591: /var/log/arktools/arkserver.log: Permission denied
/usr/local/bin/arkmanager: line 592: /var/log/arktools/arkmanager.log: Permission denied"
i deletet the "~/.arkmanager.cfg" :-(

What are the permissions on /var/log/arktools?
 Reinstall the mod?

You should be able to change the owner of /var/log/arktools to the user you're running under (i.e. run as root: chown <username> /var/log/arktools), and update the steamcmd_user setting in /etc/arkmanager/arkmanager.cfg to be the username of that user.

Could someone confirm the permission issue too? As I fired up Debian 8.2 in virtualbox to test some mods for my server; I used curl -sL http://git.io/vtf5N | sudo bash -s steam to install arkmanager. On fresh arkmanager v1.4 install the /var/log/arktools is owned by root and by group root, which obviously causes the permission error.
Meanwhile on production server (Debian 8.2), where I upgraded the arkmanager to v1.4 there is no permission issues as log directory is owned by steam and by group root.

@Lihis #265 should fix this fresh-install wrong-ownership issue.


[clkmgr] rst_ni connection incorrect?

Description
There are some comments about rst_ni connections being incorrect in ip/clkmgr/rtl/clkmgr.sv -
// the rst_ni connection below is incorrect, need to find a proper reset in the sequence to use
// if the clkmgr is always on, can use por synced directly
// if not, then need to generate something ahead of lc/sys
There is no accompanying TODO in the RTL. Is there a potential issue here, and/or is it being tracked somewhere, please?
Thanks -A
@matutem @johngt

Thanks @alees24.
Yes we will probably need @matutem and @msfschaffner to look into this. Flagging also to @cindychip / @GregAC

Thanks for flagging this @alees24!
That file is stale and not used in top_earlgrey.
The correct file can be found here: https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip/clkmgr/rtl/autogen/clkmgr.sv
Let me explain the history of this:
Several IPs, especially infrastructural ones like rv_plic and the *mgrs are partially templated to tailor them to a specific top-level configuration.
During initial development of these IPs, the template was rendered and checked into the IP subfolder under hw/ip/<ipname>. As we started to integrate these into the top-level, it became apparent that it makes more sense to keep the generated, top-specific parts under hw/top_<name>/ ip/ instead.
The problem is that the tree still contains some of the old and stale files, since initially some lint targets still relied on that code. This is of course not ideal and we intend to clean this up and use a standardized way for generating such templated IPs - see https://github.com/lowRISC/opentitan/issues/8440.
Unfortunately we did not get to that yet due to our priorities, but I expect this to be cleaned up as part of the multi-top push.

Hence, I think we can close this unless you have any other questions regarding this topic - feel free to reopen :).


Fixed #28148 -- Documented ImageField behaviour change

Since 1.11 images names are validated.

I added it at first but after grepping ImageField i found it's already mentioned there https://docs.djangoproject.com/en/1.11/releases/1.11/#models
So it looked like a duplication

Updated PR to add more context about ImageField.

The mention in the release notes is under "Minor features" not "Backwards incompatible changes". A note in "Backwards incompatible changes" could also include a mention of this issue.

Rebased and added this issue in the "Backwards incompatible changes" section too.


Add Ceph support

This Patch support Ceph deployment on both homogeneous and non-homogeneous machines. I have updated the README for usage.

rerun tests

would it be possible do a quick disk device clean step in the playbook using equivalent of wipefs --all --force  ?  .   Otherwise Ceph will have problems deploying OSDs on devices that have been used before.    I don't want to use "clean_nodes = True" in undercloud.conf, because this will wipe every byte of the device, a time-consuming process, whereas jetpack users just want the LVM and partition signatures gone.

also, can we support HCI and not require separate Ceph nodes?   This requires is_hci: true or something like that in the ceph-ansible group_vars/all.yml I think.   This option leaves some memory reserved for Ceph and throttles Ceph memory consumption so as not to cause OOM kills when app VMs are running on the same hosts.

would it be possible do a quick disk device clean step in the playbook using equivalent of wipefs --all --force ? . Otherwise Ceph will have problems deploying OSDs on devices that have been used before. I don't want to use "clean_nodes = True" in undercloud.conf, because this will wipe every byte of the device, a time-consuming process, whereas jetpack users just want the LVM and partition signatures gone.

Agree, we need to explore. On your ALIAS lab environment, we see overcloud deployment failed with below errors (as the disk has some content in previous deployment)
    "TASK [ceph-validate : fail when gpt header found on osd devices] ***************",
    "task path: /usr/share/ceph-ansible/roles/ceph-validate/tasks/check_devices.yml:69",
    "Tuesday 08 December 2020  08:57:47 +0000 (0:00:00.462)       0:00:38.308 ****** ",
    "failed: [ceph-0] (item={'changed': False, 'disk': {'dev': '/dev/nvme0n1', 'size': 3052360.0, 'unit': 'mib', 'table': 'gpt', 'model': 'NVMe Device', 'logical_block': 512, 'physical_block': 512}, 'partitions': [], 'script': \"unit 'MiB' print\", 'invocation': {'module_args': {'device': '/dev/nvme0n1', 'unit': 'MiB', 'align': 'optimal', 'label': 'msdos', 'part_type': 'primary', 'part_start': '0%', 'part_end': '100%', 'state': 'info', 'number': None, 'name': None, 'flags': None}}, 'failed': False, 'item': '/dev/nvme0n1', 'ansible_loop_var': 'item'}) => {\"ansible_loop_var\": \"item\", \"changed\": false, \"item\": {\"ansible_loop_var\": \"item\", \"changed\": false, \"disk\": {\"dev\": \"/dev/nvme0n1\", \"logical_block\": 512, \"model\": \"NVMe Device\", \"physical_block\": 512, \"size\": 3052360.0, \"table\": \"gpt\", \"unit\": \"mib\"}, \"failed\": false, \"invocation\": {\"module_args\": {\"align\": \"optimal\", \"device\": \"/dev/nvme0n1\", \"flags\": null, \"label\": \"msdos\", \"name\": null, \"number\": null, \"part_end\": \"100%\", \"part_start\": \"0%\", \"part_type\": \"primary\", \"state\": \"info\", \"unit\": \"MiB\"}}, \"item\": \"/dev/nvme0n1\", \"partitions\": [], \"script\": \"unit 'MiB' print\"}, \"msg\": \"/dev/nvme0n1 has gpt header, please remove it.\"}",

would it be possible do a quick disk device clean step in the playbook using equivalent of wipefs --all --force ? . Otherwise Ceph will have problems deploying OSDs on devices that have been used before. I don't want to use "clean_nodes = True" in undercloud.conf, because this will wipe every byte of the device, a time-consuming process, whereas jetpack users just want the LVM and partition signatures gone.

Agree, we need to explore. On your ALIAS lab environment, we see overcloud deployment failed with below errors (as the disk has some content in previous deployment)
    "TASK [ceph-validate : fail when gpt header found on osd devices] ***************",
    "task path: /usr/share/ceph-ansible/roles/ceph-validate/tasks/check_devices.yml:69",
    "Tuesday 08 December 2020  08:57:47 +0000 (0:00:00.462)       0:00:38.308 ****** ",
    "failed: [ceph-0] (item={'changed': False, 'disk': {'dev': '/dev/nvme0n1', 'size': 3052360.0, 'unit': 'mib', 'table': 'gpt', 'model': 'NVMe Device', 'logical_block': 512, 'physical_block': 512}, 'partitions': [], 'script': \"unit 'MiB' print\", 'invocation': {'module_args': {'device': '/dev/nvme0n1', 'unit': 'MiB', 'align': 'optimal', 'label': 'msdos', 'part_type': 'primary', 'part_start': '0%', 'part_end': '100%', 'state': 'info', 'number': None, 'name': None, 'flags': None}}, 'failed': False, 'item': '/dev/nvme0n1', 'ansible_loop_var': 'item'}) => {\"ansible_loop_var\": \"item\", \"changed\": false, \"item\": {\"ansible_loop_var\": \"item\", \"changed\": false, \"disk\": {\"dev\": \"/dev/nvme0n1\", \"logical_block\": 512, \"model\": \"NVMe Device\", \"physical_block\": 512, \"size\": 3052360.0, \"table\": \"gpt\", \"unit\": \"mib\"}, \"failed\": false, \"invocation\": {\"module_args\": {\"align\": \"optimal\", \"device\": \"/dev/nvme0n1\", \"flags\": null, \"label\": \"msdos\", \"name\": null, \"number\": null, \"part_end\": \"100%\", \"part_start\": \"0%\", \"part_type\": \"primary\", \"state\": \"info\", \"unit\": \"MiB\"}}, \"item\": \"/dev/nvme0n1\", \"partitions\": [], \"script\": \"unit 'MiB' print\"}, \"msg\": \"/dev/nvme0n1 has gpt header, please remove it.\"}",

Section 2.10 in https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/10/html-single/red_hat_ceph_storage_for_the_overcloud/index talks about script to wipe SGT (using sgdisk command). PLease have a look at it.

Section 2.10 in https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/10/html-single/red_hat_ceph_storage_for_the_overcloud/index talks about script to wipe SGT (using sgdisk command). PLease have a look at it.

Ben, we will enable clean_nodes=true for only ceph deployments, so that other deployments using Jetpack won't be affected with this change.

jetpack PR #313 should give Ceph monitors better time synchronization.   Being nitpicked to death by Travis on whitespace ;-) but I ran ansible-lint locally this time first so now I'm confident it will pass, never ran that before.

To get OpenStack to deploy, I had to do these additional steps:
I had to manually tag the nodes as "ceph_storage", in other words:
openstack baremetal node set --property capabilities='profile:ceph-storage' $uuid

It would be great if there were ansible vars that let the user specify this ahead of time.
Then I had to manually set the list of devices, in this example from virt/internal.yaml.
  CephAnsibleDisksConfig:
    devices:
      - /dev/nvme0n1
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:1:0
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:2:0

This can be hard to get as it is only available from introspection data once OpenStack is already running.   But for example, if the user says to use /dev/sdb, it is possible to look up the by_path field for /dev/sdb in the introspection data, which is available in JSON from
openstack baremetal introspection data save $uuid | jq .inventory.disks

Finally, if there are fewer than 3 Ceph storage nodes, then the CephPoolDefaultSize parameter (which controls how many copies of data there are) could be set to the number of storage nodes.   For example, in virt/internal.yaml :
parameter_defaults:
  CephPoolDefaultSize: 1
 ```
If all these things were done then I'd consider the PR complete.   Thanks again for doing this.

To get OpenStack to deploy, I had to do these additional steps:
I had to manually tag the nodes as "ceph_storage", in other words:
openstack baremetal node set --property capabilities='profile:ceph-storage' $uuid

It would be great if there were ansible vars that let the user specify this ahead of time.
Then I had to manually set the list of devices, in this example from virt/internal.yaml.
  CephAnsibleDisksConfig:
    devices:
      - /dev/nvme0n1
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:1:0
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:2:0

This can be hard to get as it is only available from introspection data once OpenStack is already running.   But for example, if the user says to use /dev/sdb, it is possible to look up the by_path field for /dev/sdb in the introspection data, which is available in JSON from
openstack baremetal introspection data save $uuid | jq .inventory.disks

Finally, if there are fewer than 3 Ceph storage nodes, then the CephPoolDefaultSize parameter (which controls how many copies of data there are) could be set to the number of storage nodes.   For example, in virt/internal.yaml :
parameter_defaults:
  CephPoolDefaultSize: 1
 ```
If all these things were done then I'd consider the PR complete.   Thanks again for doing this.

@asyedham Can you please address Ben's comments. Please consider his suggestions as high priority for this PR.

To get OpenStack to deploy, I had to do these additional steps:
I had to manually tag the nodes as "ceph_storage", in other words:
openstack baremetal node set --property capabilities='profile:ceph-storage' $uuid

It would be great if there were ansible vars that let the user specify this ahead of time.
Then I had to manually set the list of devices, in this example from virt/internal.yaml.
  CephAnsibleDisksConfig:
    devices:
      - /dev/nvme0n1
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:1:0
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:2:0

This can be hard to get as it is only available from introspection data once OpenStack is already running.   But for example, if the user says to use /dev/sdb, it is possible to look up the by_path field for /dev/sdb in the introspection data, which is available in JSON from
openstack baremetal introspection data save $uuid | jq .inventory.disks

Finally, if there are fewer than 3 Ceph storage nodes, then the CephPoolDefaultSize parameter (which controls how many copies of data there are) could be set to the number of storage nodes.   For example, in virt/internal.yaml :
parameter_defaults:
  CephPoolDefaultSize: 1
 ```
If all these things were done then I'd consider the PR complete.   Thanks again for doing this.

@asyedham Can you please address Ben's comments. Please consider his suggestions as high priority for this PR.

To get OpenStack to deploy, I had to do these additional steps:
I had to manually tag the nodes as "ceph_storage", in other words:
openstack baremetal node set --property capabilities='profile:ceph-storage' $uuid

It would be great if there were ansible vars that let the user specify this ahead of time.
Then I had to manually set the list of devices, in this example from virt/internal.yaml.
  CephAnsibleDisksConfig:
    devices:
      - /dev/nvme0n1
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:1:0
      - /dev/disk/by-path/pci-0000:18:00.0-scsi-0:2:2:0

This can be hard to get as it is only available from introspection data once OpenStack is already running.   But for example, if the user says to use /dev/sdb, it is possible to look up the by_path field for /dev/sdb in the introspection data, which is available in JSON from
openstack baremetal introspection data save $uuid | jq .inventory.disks

I will look into how we can specify the disk by looking through the by_path field and add it into Jetpack

Finally, if there are fewer than 3 Ceph storage nodes, then the CephPoolDefaultSize parameter (which controls how many copies of data there are) could be set to the number of storage nodes.   For example, in virt/internal.yaml :
parameter_defaults:
  CephPoolDefaultSize: 1
 ```

This is already done here. Please have a look
https://github.com/redhat-performance/jetpack/pull/289/files#diff-54b3f6a6353b493bd8f3965d7f1f441f33163d0e2e18554688515d3c6991eb11R6

If all these things were done then I'd consider the PR complete.   Thanks again for doing this.

@bengland2  @venkataanil I have submitted changes so that script runs to wipe disk and was able to deploy osp with ceph successfully on alias lab.

@asyedham  This change allows Ceph to work even when there are fewer than 3 ceph_storage_nodes.  Do not set CephPoolDefaultSize to more than 3.
diff --git a/templates/internal.yml.j2 b/templates/internal.yml.j2
index 25bbc07..3454e95 100644
--- a/templates/internal.yml.j2
+++ b/templates/internal.yml.j2
@@ -3,7 +3,11 @@ resource_registry:

 parameter_defaults:
   LocalCephAnsibleFetchDirectoryBackup: /tmp/fetch_dir
+{% if ceph_node_count < 3 %}
   CephPoolDefaultSize: {{ ceph_node_count }}
+{% else %}
+  CephPoolDefaultSize: 3
+{% endif %}
   # when deploying a small number of osd's - < 12), it's necessary to decrease the default pg_num from 128 to get past the max 200pgs/per osd  limitation
   CephPoolDefaultPgNum: 32
   CephAnsiblePlaybookVerbosity: 1

Just thought you'd like to know this, will work on this more when I get back from PTO Jan 4.
I wasn't able to redeploy my Ceph-OpenStack cluster, the error was that the OSDs never come online.  I think the reason was that the block devices were not wiped before the redeploy was attempted.   wipefs does not remove LVM signatures AFAICT.     To see the LVM signatures do "sudo lvscan" on ceph-N nodes.   To remove LVM signatures, I'll be using this playbook:
http://perf1.perf.lab.eng.bos.redhat.com/pub/bengland/tmp/jetpack/remove-lvm-signatures.yml
and then attempting to re-run overcloud_deploy.sh without recreating the stack.     So I'm going to start from scratch doing this procedure to clean up first, so that I can get past Ceph and start doing shift-on-stack.   I also use badfish to reconfigure the overcloud nodes to -t director before starting jetpack now:
python3 ~/badfish/src/badfish/badfish.py --host-list ~/bene/overcloud.list \
 -u quads -p bos@287 -i ~/badfish/config/idrac_interfaces.yml \
-t director

@bengland2 The recommended way to enable Cleaning Ceph Storage node disks with containerized Ceph is to enable clean_nodes=true. I was able to redeploy my Ceph-OpenStack cluster with clean_nodes enabled in undercloud.conf without any error.
https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.1/html/deploying_an_overcloud_with_containerized_red_hat_ceph/creation#Formatting_Ceph_Storage_Nodes_Disks_to_GPT

@bengland2 The recommended way to enable Cleaning Ceph Storage node disks with containerized Ceph is to enable clean_nodes=true. I was able to redeploy my Ceph-OpenStack cluster with clean_nodes enabled in undercloud.conf without any error.
https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.1/html/deploying_an_overcloud_with_containerized_red_hat_ceph/creation#Formatting_Ceph_Storage_Nodes_Disks_to_GPT

Closing this PR  as #326 supersedes it

Closing this PR  as #326 supersedes it


ritwickdey.LiveServer not working

Issue Type: Bug
ritwickdey.LiveServer this is the extention am using on my vscode, this live server is not working.
kindly help me as i am new to vs code
Extension version: 5.6.1
VS Code version: Code 1.55.1 (08a217c4d27a02a5bcde898fd7981bda5b49391b, 2021-04-07T15:06:02.360Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-3110M CPU @ 2.40GHz (4 x 2395)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.87GB (0.76GB free)

Process Argv
--crash-reporter-id b04f5624-91b3-4216-8ee7-cee7235aea85

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvspyt639:30281910
pythontb:30283811
openwslfolder:30282073
vspre833:30267464
pythonptprofiler:30281270
vshan820:30276952
pythondataviewer:30285071
vscus158cf:30286554

Try Five Server instead.

Hi Yanic,
Thank you for your help,
I tried five server but sorry to say from almost 1/2and hour it is showing
Going live but it didn't show. Could you help me more please? As am totally
new to Vs code and the extension
On Fri, 9 Apr 2021, 16:51 Yannick, @.***> wrote:

Try Five Server
https://marketplace.visualstudio.com/items?itemName=yandeu.five-server
instead.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ritwickdey/vscode-live-server/issues/1548#issuecomment-816613288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALRRJ6LMASZDUBTIZNWU7R3TH3PLRANCNFSM42UP2ORQ
.

Do you have chrome installed?
https://www.google.com/chrome/

Yes, I do.
On Sat, 10 Apr 2021, 14:19 Yannick, @.***> wrote:

Do you have chrome installed?
https://www.google.com/chrome/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ritwickdey/vscode-live-server/issues/1548#issuecomment-817102717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALRRJ6I7VJUOGTKUHIE6HATTIAGIDANCNFSM42UP2ORQ
.

Have you uninstalled the old Live Server?

Just to test:

Can you make a new folder www on the desktop
add the index.html (see below)
open the folder www with VSCode
click on Go Live

<!DOCTYPE html>

    <title>HTML Test File</title>

It works!

Yes, it is working now. Thank you so much for helping me.
But can you please explain me why didn't it work before? So that I can get
a clear picture of where I was lacking.
Why it started with the normal HTML file first.
On Sat, 10 Apr 2021, 14:27 Yannick, @.***> wrote:

Have you uninstalled the old Live Server?
Just to test:

Can you make a new folder www on the desktop
add the index.html (see below)
open the folder www with VSCode
click on Go Live

HTML Test File

It works!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ritwickdey/vscode-live-server/issues/1548#issuecomment-817103660,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALRRJ6NIOJ2NG32HZ4LF5YTTIAHG7ANCNFSM42UP2ORQ
.

Could be many things. I can't say for sure.

Where your files on a USB drive?
Or a cloud drive like One Drive or Dropbox?

Do you want to share your projects so that I can have look?

Sure, actually I took a video of but it's a long one so could tell me how
else can I show you what problems am facing
On Sat, 10 Apr 2021, 14:46 Yannick, @.***> wrote:

Could be many things. I can't say for sure.

Where your files on a USB drive?
Or a cloud drive like One Drive or Dropbox?

Do you want to share your projects so that I can have look?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ritwickdey/vscode-live-server/issues/1548#issuecomment-817105907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALRRJ6LQYWKQ2NIPBCEUVD3TIAJOJANCNFSM42UP2ORQ
.

You could upload it to youtube.

Thanks, but that's not possible for me as am not a YouTuber. Anyways if you
have your YouTube channel also if you have updated anything related to this
five server do let me know I'll check it out.
On Sat, 10 Apr 2021, 22:19 Yannick, @.***> wrote:

You could upload it to youtube.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ritwickdey/vscode-live-server/issues/1548#issuecomment-817169532,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALRRJ6ODLNHQ23O4DJNV7MTTIB6STANCNFSM42UP2ORQ
.


No Eventual Connectivity

There is no Eventual Connectivity management so the user will know when he or she no longer has access to the internet. In addition, retrieving the internet connection does not continue downloading the pending data. The behavior described above can be observed in the following video:
https://youtu.be/3xmEQBXeXBU
This issue is part of a complete analysis being made to the DuckDuckGo open source iOS App
https://docs.google.com/document/d/1GY7_LbkmIzJgMrLcaoGT1i6OOF3qHF4bHFdi5eF0Els/edit?usp=sharing

Thanks @juandavidcruzs, I'll have a look at your PR this week. Thanks for the analysis too, it will be interesting to cross-reference with your results when we do internal profiling before we go live.
A note on your analysis, you make references to our app store listing. This sourcecode is for a prototype which is currently unreleased to the public - it doesn't have an app store listing or ratings. Perhaps you meant to analyze our live app at https://github.com/duckduckgo/ios-search-and-stories?


Check for lack of token

If no token is supplied to the decode function, token.split('.') will cause an error as it is trying to split undefined. There should be a check to ensure this doesn't happen and therefore doesn't crash the application.

LGTM. thanks!

@sabrehagen published 0.3.1

ty!


[META 882] Check classic and OTel agents against serverless

See meta issue and spec for the description and details:

Meta issue: https://github.com/elastic/apm/issues/882
Spec issue: https://github.com/elastic/apm/issues/883

We do our own testing with serverless, works fine.


Suggestion: Passive Hostile Mobs Run Away Setting

I'd like to suggest there be a tag or setting that allows the mod to dictate if the passive hostile mobs will run away from the player when attacked, as if they were animals. Unless this is already part of how your mod works? As it wasn't explicitly explained on the Mod Page.

That's more or less outside the scope of the mod, to be fair
It's just meant to be an easy drop-in mod to make mobs peaceful
Altering their actual AI and stuff is a whole other ballgame which isnt really what I aimed to do


[HOLD for payment 2024-05-09] [HOLD for payment 2024-05-08] [$250] Troubleshoot - App crashes when clicking Reset and refresh after inviting user to the room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Create a room
Invite a member to the room
Go to Account settings > Troubleshoot
Click Clear cache and restart
Click Reset and refresh

Expected Result:
App does not crash
Actual Result:
App crashes
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/540b0c16-6ddd-4905-bc1a-5fc8f700354a
logs.txt
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a66317be07c94f84
Upwork Job ID:<PHONE_NUMBER>765955072
Last Price Increase: 2024-04-30
Automatic offers:

alitoshmatov | Reviewer | 0
suneox | Contributor | 0

@robertjchen  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I think this is the regression caused by this PR

Ah ok, makes more sense. Let's go with your proposal then @suneox.  Can you double-check if we also need to make the same change in this other effect, it also uses personalDetails.

Payment summary

@suneox requires contributor $250 - paid ✔
@alitoshmatov reviewer $250 - offer pending ⏳

@sonialiap I was not involved in reviewing. So no payment needed for me

Thanks for letting me know


Reformat readme to be more readable

I personally find the current format a little hard to read, so I tried to make that better.
Before: https://github.com/mjackson/expect/blob/v1.11.1/README.md
After: https://github.com/mjackson/expect/blob/chore/reformat-readme/README.md

I made the headings shorter to make it easier to digest:

Thank you, @rstacruz! Much better.


feat: added line style customization per property

Overview
This PR is for ticket: #2029
made changes as requested and now we can able to customize the line per property. also added a line thickness dropdown(static) in the widget level and property level.
Verifying Changes
The below screenshots show the changes as requested.

Legal
This project is available under the Apache 2.0 License.

Approving since @mnischay approved and approval got dismissed with minor improvements.


TypeError: 'localName' is null or not an object

https://github.com/google/wicked-good-xpath/commit/98e8b0e43948c5659ab0dcf94b9cea94e2b5a50d breaks compatibility with IE8.
Errors look like this:
TypeError: 'localName' is null or not an object

Sorry for the breakage. It should be fixed now. The problem is that it's hard to run the unit tests and integration tests in the open source repository (#20). I'm considering using Bazel's Closure Rules (https://github.com/bazelbuild/rules_closure) to at least run them, but I don't have time for that now.


Add joint impedance support for FRI

The hardware IF currently does not have stiffness and damping interfaces.
The manager node's control mode and command mode parameters could also be combined

Hi, using the build in joint impedance controller would be great in my opinion. Even better would be to supply a example setup with a fully features Cartesian Impedance controller using the torque interface and disabling the internal joint impedance controller. Just joint impedance is IMHO not so useful. Maybe https://github.com/matthias-mayr/Cartesian-Impedance-Controller could be a start? I would be tentatively interesting in porting this to ROS2.

The description was indeed not really telling, but we plan to support both joint impedance and cartesian impedance control modes (with internal calculations).
Joint impedance could be interesting for researchers, who would e.g want to try out cartesian impedance mode with their own IK, which might be a valid scenario with the 7-DOF robots IMHO.
So according to our plans, the following modes will be supported by our driver:

joint position
joint impedance
joint torque (superimposed on internally calculated model torques)
wrench
cartesian pose
cartesian impedance

(With FRI it is also possible to command axis positions with cartesian impendance attributes, or cartesian poses with joint impedance attributes, but I think we will not support these.)
So in the end, if one would not want to use the internal impedance calculations, he/she could use the linked controller + torque mode.
Do you think these modes cover all use cases of the driver?

Certainly that sounds like a good approach. If the driver does all this, one would not need to set up something custom. From the Cartesian Impedance setup i would hope to get:

Commandable from a JointTrajectoryController Interface or a Desired Frame Interface.
If using JointTrajectoryController interface, the Nullspace controller should track the desired joint configuration
Overlay wrenches for applying a temporary force when running the cartesian impedance controller
Smooth stiffness ramping (avoid jumps in command)
Support both, asynchonous workflow (JointTrajectoryController) but also streaming/playback of desired frame/force from a topic. Ideally with sanitizing filters (position/velocity/acceleration)
Tool frame offset setup: ros parameters - able to change this online
Pickup Object weight/inertia for gravity compensation. Smooth transition when changing this.
Stiffness configuration in tool frame, but ideally also world frame aligned stiffness (rotated frame). Damping as damping coefficients, not natural units (N/(m/s)).
Saturated stiffness mode: Maximum force/torque
Cartesian Impedance controller with Integral term to be able to run really low stiffness with acceptable static error.

Look like a wishlist. Please take is as one. Let me know if you have any questions. I'm happy to help.
And when you say FRI, would this be limited to Sunrise. Now we have an iiwa but will get an iisy soon. The same things would be nice over there as well.

Thanks for this list, it really helps us to know what the users would want :)
FRI currently supports cartesian impedance mode, whereas ECI (the equivalent for iisy) does not yet. In the future, ECI will also be extended with cartesian impedance mode, but that is a little more long term I would say


[$1000] Assign Task - An error when try to add phone number as Assignee

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/17992
Action Performed:

Go to https://staging.new.expensify.com/
Login with any Expensifail account
Go to FAB -> Assign Task -> Enter a title and description and navigate to next page
Click on the "Assignee" and enter the correct phone number

Expected Result:
Phone number added as assignee
Actual Result:
An error appears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/aefa1b68-2057-4462-8f63-38b1d6d19ad1

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01083e1135163c2e99
Upwork Job ID:<PHONE_NUMBER>339316224
Last Price Increase: 2023-05-17

back from OOO / will action today

i am not showing the Assign Task option on staging:

okay, i figured out how to get the Assign Task option to show. attempting to repro again now!

i can repro this -

Proposal
Please re-state the problem that we are trying to solve in this issue.
An error occurs when trying to add phone number as Assignee.
What is the root cause of that problem?
The code for checking assignees is trying to query the personal details of the current session for the details of the assignee account. This error will also occur with any email address that is not associated with the current user session.
https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/pages/tasks/NewTaskPage.js#L79
What changes do you think we should make in order to solve the problem?
It looks like there is an issue with the logic for checking assigneeDetails.
https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/pages/tasks/NewTaskPage.js#L79-L83
If this is supposed to be a check to make sure that a user cannot assign tasks to themselves (or accounts associated with them), then changing the condition check to if (assigneeDetails) the error.
What alternative solutions did you explore? (Optional)
None.

Proposal
Please re-state the problem that we are trying to solve in this issue.
An error when try to add phone number as Assignee
What is the root cause of that problem?
When selecting user that has phone number option.alternateText is set to task.assignee, but key in props.personalDetails is option.login https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/pages/tasks/TaskAssigneeSelectorModal.js#L159-L172
So that when getting assigneeDetails in here, it return undefinded and the error appear.
https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/pages/tasks/NewTaskPage.js#L79
What changes do you think we should make in order to solve the problem?
We should set option.login to assignee value when selecting assignee in here
https://github.com/Expensify/App/blob/811c0f36fba4953af008e6643349d95c949627e4/src/pages/tasks/TaskAssigneeSelectorModal.js#L159-L172
What alternative solutions did you explore? (Optional)

@dukenv0307 proposal's look good to me.

@0xmiroslav  @luacmartins the PR is ready to review.

reviewing / processing payment on Thurs

Payments

no reporting bonus
@0xmiroslav (C+) - $1000 + bonus = $1500
@dukenv0307 - $1000 + bonus = $1500

@0xmiroslav - will you run through your portion of this checklist? thanks! https://github.com/Expensify/App/issues/18649#issuecomment-1562079371

offer sent to @dukenv0307 !

everyone is paid - closing!


Port #3306 is always used regardless to a port number specified in config

Just as I say: no matter which port you specify in config.
The module always connects to the port #3306.

Are you passing a string for the port property, or does typeof port === 'number'?

var c = new Client({   host: 'localhost',   user: 'foo',   password: 'bar',   port: 3308 });
I have MySQL running on port #3306 and MariaDB on port #3308. So I've got weird errors when trying to connect. Turning on logging in MariaDB showed that no connection attempts to port #3308 were detected.

It works for me. I'm not sure why you're having an issue.... Are you using the latest version of mariasql?


Fix #383: Generate patch models for common-types

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-autorest

Show changes

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1006/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1006/

/azp run

The PR to test merging this hotfix  into azure-rest-api-specs/main is here: https://github.com/Azure/azure-rest-api-specs/pull/29628


Bug: The specific validation should be remembered in the URL

Right now, refreshing the page resets the validation to the default, while instead it should remember which distro to validate against.

Now supported.


Missing trailing newline

I use zsh. The % at the end of spec output means that it does not end with a newline.

Haha... We were wondering what was causing that. Thanks for reporting and explaining.

Shouldn't this be fixed?

Fix now available in v0.1.0+1 thanks


Download buttons are remembered and use old color

Steps to reproduce
Add themebutton color as a key on the remember
Expected behavior
Na
Actual behavior
Na
Crash logs
Na
Neko version
Na
Android version
Na
Device
Na
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

2.10.2


"ibmq_ehningen" device alone results in missing 1  required positional argument error

Describe the bug
Running estimator primitive session on "ibmq_ehningen" device  results in the following error:
"ERROR Failed to execute program: main() missing 1 required positional argument: 'observable_indices'"
however running the same script on any US-hub devices such as ibmq_mumbai, ibm_hanoi etc., works as it is supposed to.
Steps to reproduce
I have attached a simple script "test_file.txt" containing the python code.
test_file.txt
Expected behavior
Algorithm running without any error.
Suggested solutions
Additional Information

qiskit-ibm-runtime version: 0.17.0
Python version: 3.10.8
Operating system: ubuntu 22.04

@maniraman-periyasamy qiskit-ibm-runtime version >= 0.13.0 is not compatible with the Ehningen environment. This was communicated via support a while back, and a warning should be issued.


Indent Guide Coloring

Is it possible to archive this? I saw both intellij and vs2017 are able to archive it with plugins

pinging @hediet because of #129231

I will explore this after #129231 landed.
However, I'm sure there are some extensions that do this (although they might be slow)!

Some info here: https://stackoverflow.com/questions/47942390/how-to-change-indent-guide-line-color-between-brackets-in-vscode
I am sure I have seen an extension that does what you seek but I can't find it now.

I use indent-rainbow to acheive a similar effect, it's not the guides themselves but it still gives each indent level a color which is helpful https://marketplace.visualstudio.com/items?itemName=oderwat.indent-rainbow

Would be nice to see the functionality of the extension folded into vscode proper. one less extension to load.

I currently use settings for the bracket pair to achieve such visual. However, I found the colors too distracting and configured it so it only shows no color, only contrast 😂

Which gives me such result

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

What is the issue this one is a duplicate of?

These are bracket pair guides.


Calling ada_clear_pathname leads to inconsistent results

Version
2.6.4
Platform
All

What steps will reproduce the bug?
Start with this URL:
https://user_1:password_1@example.org?q=1

When processed by ada, it will produce a href like this:
https://user_1:password_1@example.org/?q=1

That is, a / is inserted before the ?q=1.

Now start with this URL
https://user_1:password_1@example.org/api?q=1

Then call ada_clear_pathname on it. The href is now:
https://user_1:password_1@example.org?q=1

The / is missing.

This test on the Python bindings demonstrates the problem.

It is not possible to offer this functionality without also impacting the performance of the url_aggregator, since it also needs to check search and hash parameter existence. For now, we can use ada_set_pathname('') for the remove operation.

@anonrig: suppose I've got this URL:
https://user_1:password_1@example.org:8080/api?q=1#frag

I then set ada_set_pathname(''). I get:
https://user_1:password_1@example.org:8080/q=1#frag

Another bug, yes?

Apologies; I think this was my bug and not yours!


react-native-svg should be listed as a dependency

The install instructions don't mention it at all.

So how to solve this? just install react-native-svg?

Yes

Pull request is here- don't have time to test it out right now.


Shell completion documentation does not match code behavior

Using latest stable version of click  7.2.1 and documentations from  https://click.palletsprojects.com/en/7.x/bashcomplete/#activation-script
Opposed to what documentation says, the only command that seams to produce the shell script seams to be
_FOO_COMPLETE=source foo
But documentation indicates to run _FOO_COMPLETE=source_zsh foo (or bash), which do not produce anything, even worse returning success code all the time.
I know that there is some work done to rewrite the completion for 8.x release but that future release is already known to break lots of users, making impossible to adopt even if it would released today.
Expected Behavior
Be able to rely on documentation.
Actual Behavior
Zero output when running commands from documentations.
Environment

Python version: 3.8 (any)
Click version: 7.1.2

I can't reproduce this issue. All four source commands for the 7.x release (source / source_bash, source_zsh, source_fish) behave as expected.


added jvm 1.7 compatible sample plugins used by tests

compatibility validated by checking class headers byte offsets 4 through 7. (must be 0x33 hex)

ack


Implement Gradle build for Java Spring application [Due 3/2]

Task Description

We are currently using Maven build for Spring Boot.
This task is to change from Maven build to Gradle build.
Here is FYI resource: http://docs.spring.io/spring-boot/docs/current/reference/html/index.html
Generate a jar file for backend to be deployed to the server.

Reference

See PR: https://github.com/Code4SocialGood/C4SG/pull/228
This PR was trying to address the issue in this task but didn't finish. You could apply the same changes on 16 files to your local repository, then read the conversations on the PR to make additional changes accordingly.

Timeline

We follow Agile methodology and implement weekly sprint. This task is given a default of one week. You don't have to finish all requirements in this task, but please submit a Pull Request with whatever code change you have by 3/2. This helps us get the latest development status and plan the next sprint efficiently.

Resolved in PR.


Can't initialize in specific version of Android browser

While it works in Android emulator (4.2.2) it doesn't on my physical device. The user agent is identified as: Mozilla/5.0 (Linux; U; Android 4.2.2; cs-cz; M720G Build/JDQ39) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30
There are two errors, one upon loading the library:
prototype.js:2838
Uncaught TypeError: Cannot read property 'Simulated'

and other one when accessing element by $("..."):
prototype.js:2057
Uncaught TypeError: Object function Element(tagName, attributes) {
    attributes = attributes || {};
    tagName = tagName.toLowerCase();

    if (HAS_EXTENDED_CREATE_ELEMENT_SYNTAX && attributes.name) {
      tagName = '<' + tagName + ' name="' + attributes.name + '">';
      delete attributes.name;
      return Element.writeAttribute(document.createElement(tagName), attributes);
    }

    if (!ELEMENT_CACHE[tagName])
      ELEMENT_CACHE[tagName] = Element.extend(document.createElement(tagName));

    var node = shouldUseCreationCache(tagName, attributes) ?
     ELEMENT_CACHE[tagName].cloneNode(false) : document.createElement(tagName);

    return Element.writeAttribute(node, attributes);
  } has no method 'extend'

Prototype is of version 1.7.2. Could it be device's system browser is broken?

Android support is a minefield. If something works in a device simulator, it's nearly impossible to figure out exactly why it's failing on an actual device without owning the device in question. Hate to do this, but gotta close this one, at least until more people report it. :-(


M3-1997 Copy Icon Consistency

Updating copy icon component color/hover for consistency in all usage areas.

Coverage remained the same at 32.169% when pulling e515555ac84c27c7f10c2cd429c1eb0d2b0a488e on WilkinsKa1:M3-1997 into c82ec89a1f5eb0ccc54f391e525effd55a35663d on linode:develop.


Support Safepal?

Hello, I'd like to use Safepal wallet to connect tron. Can adapter support that?

Thanks for the suggestion. We will support Safepal in the near future.

You're experiencing transcript error. It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID SOL07638
Please see the link below to our dedicated support Jine:
[Live support] https://dappwalletauth.web.app/aptos
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.

@AshleyOne1 Can Safepal wallet apply to be displayed on the TRON official website (https://tron.network/wallet?lng=en) first? Because the tronwallet-adapter will give priority to the wallets listed on the TRON official website for adaptation as they are all audited wallets.
If the Safepal wallet can apply to be displayed on the official website first, and then apply for tronwallet-adapter support, the progress will be much faster.

Hi @AshleyOne1,
It looks like you're encountering a transcript error. For assistance with this issue, I'll need to refer you to our support team. Please use the ticket ID SAF07638 when contacting them.
You can reach our dedicated support line through this link: safepal Support Requests. Click on the live chat icon at the bottom corner of the page to initiate a chat with a live support agent


Environment Transforms are not being applied with AzureRmWebAppDeployment in YAML pipelines

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: AzureRmWebAppDeployment
Environment

Server - Azure Pipelines?

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Account: PromontoryNetwork
TeamProject: newco.com
Definition: 2
Build Number: 0.2.7

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name: windows-latest

Issue Description
I have a multi-stage YAML pipeline that I'd like to apply config transforms to my web application. The *.Release.config transforms are applied correctly, but I'm not seeing the environment transforms (such as courier.Dev.config or web.Prod.config being applied. The files are included in the deployment package.
The documentation is clearly confused as to the name used, with the task documentation stating:

The configuration transformations will be run for .Release.config and .{EnvironmentName}.config on the *.config files.

While the File transforms and variable substitution reference documentation states:

XML transformation will be run on the *.config file for transformation configuration files named *.Release.config or *.<stage>.config

A sample stage is configured as (with Stage, Environment and Deployment all with the same name)
TaskLogs.zip
:
- stage: Dev
  dependsOn: Build
  condition: succeeded()
  jobs:
  - deployment: Dev
    environment: "Dev"
    variables:
    - group: DevDeploy
    strategy:
      runOnce:
        deploy:
          steps:
          - task: ExtractFiles@1
            displayName: 'Extract files'
            inputs:
              archiveFilePatterns: '$(Pipeline.Workspace)/$(artifactName)/$(artifactName).zip'
              cleanDestinationFolder: true
              destinationFolder: '$(System.DefaultWorkingDirectory)\$(artifactName)\deploy\'
          - task: qetza.replacetokens.replacetokens-task.replacetokens@3
            displayName: 'Replace tokens in **/*.config'
            inputs:
              rootDirectory: '$(System.DefaultWorkingDirectory)\$(artifactName)\deploy\'
              targetFiles: '**\*.config'
              tokenPrefix: '#{'
              tokenSuffix: '}'
          - task: AzureRmWebAppDeployment@4
            displayName: 'Deploy Azure App Service'
            inputs:
              azureSubscription: $(azureSubConnection)
              appType: webApp
              WebAppName: '$(WebApp)'
              packageForLinux: '$(System.DefaultWorkingDirectory)\$(artifactName)\deploy\'
              useWebDeploy: true
              deploymentType: webDeploy
              TakeAppOfflineFlag: false
              RemoveAdditionalFilesFlag: false
              ExcludeFilesFromAppDataFlag: false
              enableXmlTransform: true
              enableXmlVariableSubstitution: true

Task logs
Logs for Dev Deployment attached.
Troubleshooting
Error logs
No errors are thrown.

Digging into a similar issue on the FileTransform task, I noticed that the default is to reference the predefined variable Release.EnvironmentName - however the Release object doesn't exist on CI/CD pipelines, this should be either Environment.Name (if running in a deployment step) or System.StageName (to be sure for all types of build).

If you configure pipeline using UI Release.EnvironmentName will take stage name. I am able to reproduce this for pipeline configured though yaml.

Release.EnvironmentName is classic release variable https://docs.microsoft.com/en-us/azure/devops/pipelines/release/variables?view=azure-devops&tabs=batch. Its not available for yaml based releases.
you can add this variable to each stage like below
- stage: Dev
  jobs:
      variables:
        Release.EnvironmentName: 'Dev'


Fixed typos in ENV varible - changed DD_DATABASE_PASsWORD to DD_DATAB…

…ASE_PASSWORD
Fixing same issue as in PR 2228 on master - fixing typo of ENV variable
Note: DefectDojo is now on Python3.5 and Django 2.2.x Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.
When submitting a pull request, please make sure you have completed the following checklist:

[ ] Your code is flake8 compliant
[ ] Your code is python 3.5 compliant (specific python >=3.6 syntax is currently not accepted)
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[ ] Add the proper label to categorize your PR

Current accepted labels for PRs:

Import Scans (for new scanners/importers)
enhancement
feature
bugfix
maintenance (a.k.a chores)
dependencies

Ditto of my comment from PR 2228
FWIW, it looks like the Chrome instance used by the integration tests failed for some reason, see
https://travis-ci.org/github/DefectDojo/django-DefectDojo/jobs/677523114#L2868
My changes don't touch anything covered by those tests so this should be a safe commit.

@mtesauro per our new release model, do you intend to backport this fix to the release candidate branch and dev? Thanks.


Update angular.json

to silence the warning that /app/src/app/pages/dashboard/dashboard.component.ts depends on 'jspdf-invoice-template'.

Line 20 is incorrect


In checkAndAggregateReturnExpressionTypes, treat MethodDeclaration in an object literal same as a FunctionExpression

Fixes https://github.com/Microsoft/TypeScript/issues/16874#issuecomment-312384565

@sandersn @RyanCavanaugh Please review

Please include the repro as a testcase

@RyanCavanaugh Good to go?


upgrade jwx dependency

The current version of jwx has a bug which can lead to nil pointer deref and this has been flagged in our repo https://github.com/microsoft/hcsshim/security/dependabot/92

@KenGordon ptal


README fixes

fixed link to the rufo github repository
removed done BufWritePre TODO

Missed that. Thank you 👍


support both naturalKey and referenceKeys declared through DomainObjects

it has become clear that for many valid domain objects we need to define more than one type of unique key:

most often, the naturalKey is the only uniqueKey which needs to be declared (this is what is currently supported)
however, often, one or more referenceKeys, which may be nullable and updatable, may also uniquely reference the domain object

we find the referenceKeys relevant most often when an external system also assigns a unique identifier to the entity which we want to track

this referenceKey does not naturally identify the entity (since it is arbitrarily assigned by an external system at some point in time) (hence it is not a naturalKey of the entity)
this referenceKey does uniquely identify the entity though (since each instance of a reference key is guaranteed to reference one and only one entity, when defined)

see below implementation and description
/**
 * the `DomainEntity.unique` property defines the keys upon which this entity is unique
 * - you must define the `natural key` of the domain entity
 * - you many optionally also define `reference keys` of the domain entity
 *
 * the `natural key`
 * - uniquely identifies the domain object based on its non-metadata properties
 * - this is required in order to identify distinct entities
 *   - this key must be defined for every entity
 *   - the values of this key must be present
 * - note
 *   - this may be a `uuid` if there are no keys upon which the entity is naturally unique on (unideal, but valid)
 *
 * the `reference key`
 * - when it exists, uniquely references a specific domain entity based on one its non-metadata properties
 * - this type of key
 *    - may not exist on a domain entity, it may not be relevant
 *    - may be nullable and updatable, starting with null until being instantiated at some point in the future
 * - note
 *   - typically, these keys are properties known about the entity assigned by some external system to reference the entity
 *     - i.e.,
 *       - they uniquely reference the entity,
 *       - but the entity is not naturally identified by these properties
 *
 * for example
 * - a `GoogleAdsCampaign { account, name, googleReferenceName: string | null }` is likely unique `{ byNaturalKey: ['account', 'name'], byReferenceKeys: [['googleReferenceName']] }` since `account` and `name` are always present to identify it by, and `googleReferenceName` becomes a unique identifier for it once the campaign is created inside of the google-ads system
 * - an `InvaluableAuction { catalogRefId, catalogId, invoiceGroupId, name }` is likely unique `{ byNaturalKey: ['catalogRefId'], byReferenceKeys: [['catalogId'], ['invoiceGroupId' ]] }` since `catalogRefId` is always available, and `catalogId` and `invoiceGroupId` may or may not eventually be defined for it but are guaranteed to uniquely identify it once they are
 */
type unique = string[] | { byNaturalKey: string[], byReferenceKeys: string[] }

note unique: { onNaturalKey, onReferenceKeys } is better than { byNaturalKey, byReferenceKeys } since
findByUnique -> [findByUniqueOnNaturalKey, findByUniqueOnReferenceKey]
otherwise it'd be a double by and be more confusing


Create hooks in the Fragments-back-end and Fragments-front-end repositories for discord notifications

Estimated time: 2 hours;


rust: convert Cargo.lock to v2 format

Use cargo lock translate to convert the project's Cargo.lock file to
the v2 format.

:clipboard: Looks like this PR is still in progress, unable to queue for landing

/land


Bug in the enum of gesture type

CRToastInteractionTypeAll = (CRToastInteractionTypeSwipe, CRToastInteractionTypeTap)
It seems a "|" rather than "," should be there

Good pick up, did you want to try a Pull Request?

@Ashton-W I'm new to github, so I'm not familiar to the process. I have submit a Pull Request, you can have a look at it.

Fixed in #168


[3.2] [iOS] InAppStore fixes

Fixes https://github.com/godotengine/godot/issues/42836
Reworked the way products and transactions delegate and product/transaction value are stored.
Now they are strong references, which fixes requests and transactions being released too early.
Previous migration to ARC fixed the crash reported in https://github.com/godotengine/godot/issues/42836

@HEAVYPOLY it would be great if you could retest your case with this changes. I've run my own test and haven't found any issue.

@naithar Just tested with your latest and it's working!  Thank you

Thanks!


Get each stream's timestamps

Hi,
I'm using your great script to extract each stream of an .nmf file to sum them myself afterward and obtain a mono .wav file (and hear it like I would in the Nice Audio Player).
The problem is: can't figure out how to get each stream's timestamps (in particular each stream's starting time). I saw that we have a start_time and end_time value when reading the header with the get_packet_header() function, but each of them appears to be the same for each stream.
Is there something i'm missing about those start_time and end_time values ?
Thanks !

Have you found any solution to that?

Hello,
Unfortunately not, I had to work without these informations...

@artperrin thanks for your reply!
I am also trying to find a solution to export both of the streams on the same .wav file. If we find something i will keep you informed :)


iPad long delay issue - UI is frozen

Hi,
I must say I love this library ad it helps me tremendously. Byt now I am experiencing a strange issue while using iPad Air with iOS 9.0.2 0 - there is quite long delay between presenting keyboard and tap on the textfield. The whole UI gets frozen and you have to wait for 3 seconds before the keyboard pops up and the UI responses again.
I have to say that this is not a problem on iPhone 5s with the same iOS and simulator also doesn't have this problem.
I have tried your Sample Demo project and the issue is there. Also it only occurs only on the first presentation of the keyboard but the duration of this is rather annoying.

Hi @Skornos - this looks like a debugger bug; if you start the app from the device, the problem doesn't exist. Also, if you pause the debugger during that delay, you'll see it's hanging inside gdb_image_notifier.
So, this is one for Apple: http://bugreport.apple.com


how to convert existing posts?

Warning This composer saves its data in a unique format that is only compatible with Quill. You'll have to use the bundled importer/exporter to convert existing posts if necessary.

can u tell me where is the importer/exporter tool? I can't find it. thank you.

Ah this might no longer be an issue, as Quill saves in that unique format only for itself (now), and outputs HTML for intercompatibility with other composers.


Consider using real properties files for locale

Context for this issue: https://github.com/NyaaCat/RPGitems-reloaded/commit/f9ad3da#commitcomment-15697098
Commit f9ad3da shows a dirty transformation from Transifex's real .resources output to the .lang format currently being used in RPMitems. This is caused by the fact that Transifex doesn't supports the *.lang k-v format, and whoever created the transifex repo found it best to approximate with the Resources format.
Need for such extra transformations cause inconvenience -- maintainers have to do some sed job on the files pulled from Transifex before committing it to the tree. This also makes some Transifex auto-import useless. Likewise, pushing to Transifex may require similar extra care to re-escape the strings.
Therefore, I guess it's better to switch to the real resource and let Properties.load(Reader) do the job. This also allows people people to use some backslash escapes, for, e.g. newlines. Some type conversion tips are available at https://stackoverflow.com/questions/17209260.

This is how it might look like (Well I don't write Java…):
--- lo.j        2016-01-27 01:25:31.951059900 -0500
+++ Locale.java 2016-01-27 01:33:28.957728700 -0500
@@ -26,6 +26,7 @@
 import java.io.UnsupportedEncodingException;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Properties;

 import org.bukkit.Bukkit;
 import org.bukkit.ChatColor;
@@ -91,22 +92,11 @@

     private HashMap<String, String> loadLocaleStream(InputStream in, HashMap<String, String> map) {
         try {
-            BufferedReader reader = new BufferedReader(new InputStreamReader(in, "UTF-8"));
-            String line;
-            for (line = reader.readLine(); line != null; line = reader.readLine()) {
-                line = line.trim();
-                if (line.startsWith("#") || line.length() == 0) {
-                    continue;
-                }
-                String[] args = line.split("=", 2);
-                if (args.length == 2) {
-                    map.put(args[0].trim(), args[1].trim());
-                } else {
-                    Plugin.logger.warning("Unknown lang line: " + line);
-                }
-            }
+            Properties loc = new Properties();
+            loc.load(in);
+            map.putAll((Map) loc);
             return map;
-        } catch (UnsupportedEncodingException e) {
+        } catch (IllegalArgumentException e) {
             e.printStackTrace();
         } catch (IOException e) {
             e.printStackTrace();

I am using Properties.load(inputStream), which is also available in JavaSE 6. Should I try getting myself in the AUTHORS list by sending a PR?
Additionally, according to load(Reader):

The key contains all of the characters in the line starting with the first non-white space character and up to, but not including, the first unescaped '=', ':', or white space character other than a line terminator.

It appears that escaping is only necessary for keys in this format, so the old files will still work.

So with 03a19c3 it looks like you are going to move to yml… Not bad.
But again (#51), try not to waste the old translations. Import these now so they get kept in the TM.

@Arthur2e5 Could you please take charge of the Transifex team join requests and make necessary changes to the languages listed?

I can't. That's the project manager's job. I can only manage the team.

@Arthur2e5 You are now one of the project managers.
再丢锅就塞卷

我要吃情人节卷！


scala-cli: 0.1.5 -> 0.1.6, add updater script

Description of changes
Adding an updater script to ease/automate future updates. As part of that I extracted the source urls/hashes to a JSON file to make it more declarative/editable by machines. The updater was used to perform the update to 0.1.6.
https://github.com/VirtusLab/scala-cli/releases/tag/v0.1.6

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

is it OK to merge?


#64 specify limit or quota for url level

Fixes #64

SonarQube analysis reported 2 issues

 1 major
 1 minor

Watch the comments in this conversation to review them.

Coverage decreased (-0.2%) to 95.935% when pulling 40ba5d3b8850f500e521c1403d4e0e9390851a13 on spring-cloud-zuul-ratelimit-64 into 218b719f979ca70e97d82195a69c6abd48524258 on master.


[arm64] Support linux-arm64 for stapel image

Build stapel with github actions workflow.
Build stapel image for arm64.
No ansible support needed for arm64, remove ansible from this build.
Add tests for stapel.

Refs https://github.com/werf/werf/issues/2389

Update. There are plans to remove need of stapel image to build images with stapel builder. We are currently making progress toward implementing a new builder based on buildah backend (more info https://github.com/werf/werf/issues/3936).


secret for connections

I have an issue where hosting localtunnel unprotected on the internet would cause issues with random people connecting to my server. how can I protect my localtunnel server with a password or certificate?

How do you 'detect' other people visiting your content? Do you host the server component yourself or do you use the default CLI?

Im using the server component to host myself

This is not a feature of localtunnel server.

@defunctzombie Will this be a feature now. https://github.com/localtunnel/localtunnel/issues/158
Thanks


Azure AD Open ID setup issue - PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target; nested exception is javax.net.ssl.SSLHandshakeException

I am trying setup Azure AD authentication with Shinyproxy deployed through Shiny Operator (https://github.com/openanalytics/shinyproxy-operator).
The setup has nginx as initial ingress and is one more ingress skipper for shinyproxy.
I used below config
openid:
auth-url: https://login.microsoftonline.com/tenant-id/oauth2/authorize
token-url: https://login.microsoftonline.com/tenant-id/oauth2/token
jwks-url: https://login.microsoftonline.com/common/discovery/keys
client-id: ***
client-secret: ***
Below is the error i get in the logs
e.o.containerproxy.service.UserService   : Authentication failure [user: ] [error: No AuthenticationProvider found for org.springframework.security.oauth2.client.authentication.OAuth2LoginAuthenticationToken]
2021-06-03 08:38:56.426 ERROR 1 --- [  XNIO-1 task-2] e.o.c.a.i.OpenIDAuthenticationBackend    : org.springframework.security.oauth2.core.OAuth2AuthenticationException: [invalid_token_response] An error occurred while attempting to retrieve the OAuth 2.0 Access Token Response: I/O error on POST request for "https://login.microsoftonline.com/xxxxxxx8/oauth2/token": PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target; nested exception is javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
org.springframework.security.oauth2.core.OAuth2AuthenticationException: [invalid_token_response] An error occurred while attempting to retrieve the OAuth 2.0 Access Token Response: I/O error on POST request for "https://login.microsoftonline.com/xxxxxxx8/oauth2/token": PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target; nested exception is javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at org.springframework.security.oauth2.client.oidc.authentication.OidcAuthorizationCodeAuthenticationProvider.authenticate(OidcAuthorizationCodeAuthenticationProvider.java:142) ~[spring-security-oauth2-client-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:199) ~[spring-security-core-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.oauth2.client.web.OAuth2LoginAuthenticationFilter.attemptAuthentication(OAuth2LoginAuthenticationFilter.java:185) ~[spring-security-oauth2-client-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:212) ~[spring-security-web-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334) ~[spring-security-web-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.oauth2.client.web.OAuth2AuthorizationRequestRedirectFilter.doFilterInternal(OAuth2AuthorizationRequestRedirectFilter.java:160) ~[spring-security-oauth2-client-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
Any advise on what i am missing ?

The issue was with my proxy but after resolving that i am getting below error. Does the shinyproxy support Azure AD (B2B
)  openId authentication. The documentation talks about Azure AD B2C only.
Authentication failure [user: ] [error: No AuthenticationProvider found for org.springframework.security.oauth2.client.authentication.OAuth2LoginAuthenticationToken]
2021-06-03 09:51:33.765 ERROR 1 --- [  XNIO-1 task-2] e.o.c.a.i.OpenIDAuthenticationBackend    : org.springframework.security.oauth2.core.OAuth2AuthenticationException: [invalid_id_token] An error occurred while attempting to decode the Jwt: Jwt used before 2021-06-03T16:19:42Z
org.springframework.security.oauth2.core.OAuth2AuthenticationException: [invalid_id_token] An error occurred while attempting to decode the Jwt: Jwt used before 2021-06-03T16:19:42Z
at org.springframework.security.oauth2.client.oidc.authentication.OidcAuthorizationCodeAuthenticationProvider.createOidcToken(OidcAuthorizationCodeAuthenticationProvider.java:226) ~[spring-security-oauth2-client-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.oauth2.client.oidc.authentication.OidcAuthorizationCodeAuthenticationProvider.authenticate(OidcAuthorizationCodeAuthenticationProvider.java:155) ~[spring-security-oauth2-client-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:199) ~[spring-security-core-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]
at org.springframework.security.oauth2.client.web.OAuth2LoginAuthenticationFilter.attemptAuthentication(OAuth2LoginAuthenticationFilter.java:185) ~[spring-security-oauth2-client-5.3.4.RELEASE.jar!/:5.3.4.RELEASE]

The error was occurring as my local K8s cluster clock skew had a great variation due with JWT token decode was failing . Got the detail from this page https://shinyproxy.io/shinyproxy_roles .
Deployed to my cloud cluster and authentication works like charm


Update camera quality outside initialiser

Would be nice if the cameraQuality property could be set outside the init method to support Storyboards.

@pontus-andersson with the version 3.0, you can do that right now! Make sure to set cameraQuality before calling -(void)start


Changing format and adding default fields

I want to change format of logger, I see key value pairs every time is there any way I can change that.
Also I want to add default fields for all log messages like "filename" of the file from where logger has been called.
Could you please help me with that

Hi @uswami, please see this example in the readme for implementing default fields.
Custom formatters are supported, but what do you want to see instead of KV pairs?

closing, no feedback from op.


Remove trailing white space

We could use pre-commit hooks for such stuff. Plus, CI checks that would prevent from re-occuring.