Make sendfile count min of bytes and max sendfile count

There is an issue with sendfile returning EINVAL under linux 5.16 with zfs https://github.com/openzfs/zfs/issues/12971
As part of the diagnostics it was suggested that sendfile count should not be larger that the file to be sent.
It has not fixed the issue with sendfile and 5.16 under zfs but is perhaps more correct than the current code and should not trigger the following case should the kernel maintainers decide to implement this error.
       EOVERFLOW
              count is too large, the operation would result in exceeding the maximum size of either the input file or the output file.

flexo.strace.5.15.txt
flexo.strace.5.16.txt

Thanks! I'm not sure why I originally used MAX_SENDFILE_COUNT even if the file is smaller, but even apart from the behavior in zfs, the code in your PR makes more sense than the original code.


cmd/go: include files and lines in import-cycle errors

The error can be more helpful if it pinpoints the files/lines that cause the cycle.
Example:
$ go build
can't load package: import cycle not allowed
package foo
    imports foo
import cycle not allowed
package foo
    imports foo

That could be anywhere in foo.

I think it's a fine idea, but the cycle can't be anywhere in foo: it has to be an import statement, and import statements have to be near the start of a file.

Yes, but it could be in any file.

Also, I don't understand why it prints the message and cycle twice.

@ianlancetaylor
It be nice to have file:line in the error message.
Instead of
import cycle not allowed
package github.com/pressly/api/cmd/api
       	imports github.com/pressly/api
       	imports github.com/pressly/api/data
       	imports github.com/pressly/api/data/presenter
       	imports github.com/pressly/api/data

I'd propose
import cycle not allowed
package github.com/pressly/api/cmd/api
       	imports github.com/pressly/api
                at github.com/pressly/api/cmd/main.go:12
       	imports github.com/pressly/api/data
                at github.com/pressly/api/api.go:8
       	imports github.com/pressly/api/data/presenter
                at github.com/pressly/api/data/user.go:14
       	imports github.com/pressly/api/data
                at github.com/pressly/api/data/presenter/user.go:6

I can implement this if you guys like the idea.

Sure, though I would keep it on line ("imports github.com/pressly/api at cmd/main.go:12").  It's too late for Go 1.8 but please send a CL for Go 1.9.

No activity. Closing.


[BUG] Issue title...The feature_only parameter cannot be used

Describe the bug
When I used the timm.create_model() I couldn't find the feature_only parameter
To Reproduce
timm:0.9.2
model = timm.create_model("ghostnet_050",pretrained=False)
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [Ubuntu 20.04]
This repository version [e.g. pip 0.9.2]

import timm
import torch
mm = timm.create_model('ghostnet_100', pretrained=True, features_only=True)
oo = mm(torch.randn(2, 3, 224, 224))
for x in oo:
    print(x.shape)

torch.Size([2, 16, 112, 112])
torch.Size([2, 24, 56, 56])
torch.Size([2, 40, 28, 28])
torch.Size([2, 80, 14, 14])

only the 100 model has weights, and features only works well


Support ICGC Storage System on S3/Ceph in Workflows

@jvivian this is a longer term goal, if we go with the ICGC storage system we want to make sure workflow inputs/outputs can use this system.
Assigning to Hannes so he can reassign

Does this belong in https://github.com/BD2KGenomics/core-operations/issues instead?

Nope, this is the correct project, @briandoconnor.

Duplicate of #266


Correction for raw affiliation Department of Biology, University of Victoria and Natural History Section, Royal British Columbia Museum, Victoria, British Columbia, V8W 3N5, Canada, e-mail:

Correction needed for raw affiliation Department of Biology, University of Victoria and Natural History Section, Royal British Columbia Museum, Victoria, British Columbia, V8W 3N5, Canada, e-mail:
raw_affiliation_name: Department of Biology, University of Victoria and Natural History Section, Royal British Columbia Museum, Victoria, British Columbia, V8W 3N5, Canada, e-mail:
new_rors: 00yxpmx15;04s5mat29
previous_rors: 00yxpmx15
works_examples: W2119322598
contact: 2aff9dbe5afe25889e805fc85a6fcc0b:023823ed @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Remove ProblemRef & friends

It's unclear from the creating commit
(b0c1d689f451ae38f29f1f05b9849b4f27bfe917) why this hierarchy was
created, but it seems just unnecessary to me.

Unsure about the MiMa changes for this, so I won't bother.


[Snyk] Fix for 4 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

packages/tools/pie-icons-vue/package.json

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed
With an upgrade:

Severity
Issue
Breaking Change
Exploit Maturity

Regular Expression Denial of Service (ReDoS) SNYK-JS-MARKED-1070800
Yes
No Known Exploit

Regular Expression Denial of Service (ReDoS) SNYK-JS-MARKED-2342073
Yes
Proof of Concept

Regular Expression Denial of Service (ReDoS) SNYK-JS-MARKED-2342082
Yes
Proof of Concept

Regular Expression Denial of Service (ReDoS) SNYK-JS-SEMVER-3247795
Yes
Proof of Concept

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

marked has been updated, and we're not rolling back the icons.


loading meshes

been trying to figure out a way to actually load meshes in the editor view, but the 3d meshes section in settings remain blank. extension isnt warning me that i need to open from "root" (im assuming this means the beamng install directory) so im a little confused on what im supposed to do here

I think it means the root of your project folder. So, for example, you're working on a vehicle named Gavril Grasshopper and want to visualize the parts in VS Code, you'd load the root folder containing the subfolders as a workspace. (CTRL+K CTRL+O by default)
In the example image below, I am opening the t-80 tank mod root folder.

Then, when you select a part from the file tree on the left, the jbeam will be visible in the 3d view

Currently to view them, you must click on the JBeam file's "flexbodies" section with your cursor.


Add eCrystal

In reference to #85.
Most of this is copied from the eRuby files in vim-ruby, but there are so many changes that I wanted to walk through everything I did to make sure that you're okay with it all.

ftdetect
The filetype for any *.ecr files is set to ecrystal, then ecrystal#SetSubtype in autoload is used to determine the subtype. If the filename has two extensions -- like *.html.ecr -- the first is used as the subtype; if the filename is only *.ecr, then html is used by default. The default subtype can be changed with the g:ecrystal_default_subtype variable.
syntax
This is mostly the same as vim-ruby.
ftplugin
This is also mostly copied from vim-ruby. However, I added optional support for auto-pairs: if the user has this plugin loaded, they will be able to use eCrystal tags with it out of the box.
Also, if the user is using vim-endwise, the filetype's original endwise settings will be preserved (vim-ruby doesn't do this).
Finally, if the user is using vim-ragtag, it will be intialized automatically.
indent
I needed helper variables and functions from indent/crystal.vim to make this work, so I moved them to autoload/crystal/indent.vim so that I could use them from the crystal#indent namespace.
According to my tests, my indent function is more accurate than vim-ruby's, but there are a couple of filetypes that it struggles with, such as javascript. This is because the contents of eCrystal tags can cause false positives in the indent functions of some filetypes, which can throw off the indentation; this problem is present in vim-ruby as well. This is something that I may try to improve in the future, but for now, it seems to work well for the most common filetypes like html and yaml.
I added a couple of options to allow users to decide whether they want the indent function to prioritize accuracy or performance in certain cases:
Aligning end tags with corresponding opener tags
In vim-ruby, end tags simply subtract an indent. This works for simple cases like HTML, where indentation only ever changes by one shift at a time, but can be inaccurate in other cases. Consider this YAML with eCrystal tags:
<% 10.times do |i| %>
  profile:
    name: test dummy <%= i %>
    description: |
      This is a test dummy.
<% end %>

In the above example, subtracting one indent isn't enough, so I decided to make end tags align with the nearest tag that starts an indent. This is more accurate and handles more edge cases, but is also slower.
This can be controlled with g:ecrystal_align_end; setting it to 1 enables this method while 0 causes the original (faster, less accurate) method to be used instead. By default, it is enabled for all filetypes except html and xml, where it isn't needed.
Indenting multiline tag bodies
In eRuby and eCrystal, it is most common for tag bodies to be one line:
<% if foo %>
  ...
<% end %>

But it is possible to have multiline tag bodies:
<%
  if foo
%>
  ...
<%
  end
%>

In fact, you can put basically any valid Crystal inside tags:
<% @names.each do |name| %>
  <%=
    # Different greeting based on name
    case name
    when "Alice"
      "Hi"
    when "Bob"
      "Hey"
    else
      "Hello"
    end
  %>
<% end %>

I made it so that Crystal indentation is properly applied to the contents of multiline tags. However, I've never seen anyone actually use multiline tags in either eRuby or eCrystal, so it's possible some people may want to turn this off just to load files a little faster: thus, this is enabled by default and can be disabled with let g:ecrystal_indent_multiline = 0.
Folding
Lastly, I have added the ability to fold blocks between control tags; this can be enabled with let g:ecrystal_fold = 1. For example, the following can be folded:
<% if foo %>
  <p>
    Hello
  </p>
<% end %>

I apologize in advance for having so much code in a single commit.

Thank you. Let me check this weekend

I added some code that should fix #87; just let me know if it should moved to a different PR.

I'm sorry for the delay. I could not take time to review a bit large PR. I'm now looking

Looks good! Thank you for contributing this. I'll merge this after reverting my recent small patches.


Zen Mode Bug

I have used the latest version 2.3.0 and found a problem.

The zen mode/full screen mode hides all UI elements, except it does not hide its scroll bar and windows taskbar.

I apologize if I am being particular.

Sorry about that. My taskbar is always hidden unless hover over it so i forgot about making full screen. Will be fixing in next update.


fix button glitch

Codecov Report
Patch and project coverage have no change.

Comparison is base (d821c6a) 40.68% compared to head (f29af74) 40.68%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   40.68%   40.68%
=======================================
  Files          20       20
  Lines        1433     1433
=======================================
  Hits          583      583
  Misses        784      784
  Partials       66       66

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Guice error running application on generated jar

Hello Jason,
I'm using your library in my project and is working as expected but I have a little problem.
When I try to run my application as a stand-alone jar I'm getting this error.
Exception in thread "main" com.google.inject.CreationException: Unable to create injector, see the following errors:

1) No implementation for java.lang.Integer annotated with @com.github.racc.tscg.TypesafeConfig(value=server.instances) was bound.
  while locating java.lang.Integer annotated with @com.github.racc.tscg.TypesafeConfig(value=server.instances)
    for parameter 2 at com.myapp.infrastructure.conf.ServerConfig.<init>(ServerConfig.java:15)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:29)

2) No implementation for java.lang.Integer annotated with @com.github.racc.tscg.TypesafeConfig(value=server.port) was bound.
  while locating java.lang.Integer annotated with @com.github.racc.tscg.TypesafeConfig(value=server.port)
    for parameter 1 at com.myapp.infrastructure.conf.ServerConfig.<init>(ServerConfig.java:15)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:29)

3) No implementation for java.lang.String annotated with @com.github.racc.tscg.TypesafeConfig(value=amadeus.url) was bound.
  while locating java.lang.String annotated with @com.github.racc.tscg.TypesafeConfig(value=amadeus.url)
    for parameter 1 at com.myapp.infrastructure.conf.AmadeusConfig.<init>(AmadeusConfig.java:13)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:28)

4) No implementation for java.lang.String annotated with @com.github.racc.tscg.TypesafeConfig(value=amadeus.wsdl) was bound.
  while locating java.lang.String annotated with @com.github.racc.tscg.TypesafeConfig(value=amadeus.wsdl)
    for parameter 0 at com.myapp.infrastructure.conf.AmadeusConfig.<init>(AmadeusConfig.java:13)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:28)

5) No implementation for java.lang.String annotated with @com.github.racc.tscg.TypesafeConfig(value=server.host) was bound.
  while locating java.lang.String annotated with @com.github.racc.tscg.TypesafeConfig(value=server.host)
    for parameter 0 at com.myapp.infrastructure.conf.ServerConfig.<init>(ServerConfig.java:15)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:29)

6) No implementation for com.myapp.infrastructure.conf.hystrix.AbstractCommandConfig annotated with @com.github.racc.tscg.TypesafeConfig(value=hystrix.default.command) was bound.
  while locating com.myapp.infrastructure.conf.hystrix.AbstractCommandConfig annotated with @com.github.racc.tscg.TypesafeConfig(value=hystrix.default.command)
    for field at com.myapp.infrastructure.conf.hystrix.DefaultHystrixCommandConfig.commandConfig(DefaultHystrixCommandConfig.java:9)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:32)

7) No implementation for com.myapp.infrastructure.conf.hystrix.AbstractThreadPoolConfig annotated with @com.github.racc.tscg.TypesafeConfig(value=hystrix.default.threadPool) was bound.
  while locating com.myapp.infrastructure.conf.hystrix.AbstractThreadPoolConfig annotated with @com.github.racc.tscg.TypesafeConfig(value=hystrix.default.threadPool)
    for field at com.myapp.infrastructure.conf.hystrix.DefaultHystrixCommandConfig.threadPoolConfig(DefaultHystrixCommandConfig.java:9)
  at com.myapp.infrastructure.CommonModule.configure(CommonModule.java:32)

The extrange thing is that I have not problems when I run my application with gradle using gradle run command.
Here is one example of my configuration classes:
package com.copaair.connectmiles.infrastructure.conf;

import com.github.racc.tscg.TypesafeConfig;
import com.google.inject.Inject;

public class ServerConfig {

    private final String host;
    private final int port;
    private final int instances;

    @Inject
    public ServerConfig(@TypesafeConfig("server.host") String host,
                        @TypesafeConfig("server.port") int port,
                        @TypesafeConfig("server.instances") int instances) {
        this.host = host;
        this.port = port;
        this.instances = instances;
    }

    public String getHost() {
        return host;
    }

    public int getPort() {
        return port;
    }

    public int getInstances() {
        return instances;
    }
}

What am I missing?
Thank you very much!!!

How do you instantiate the TypesafeConfigModule?
Have you tried TypesafeConfigModule.fromConfigWithPackage(config, "com.myapp")?

Yes. As I said, running it with grade works perfectly, but something happens when I build the fat jar using shadowjar. This issue is similar to this one.

Yes I did think that issue was similar. I'll do some testing with the shadowjar plugin and get back to you. At the moment, I've done a test by building a distribution zip using the gradle distZip command (along with the application plugin) and it seems to work ok.

I couldn't replicate the problem, sorry.
I've made a test project here for your reference to try to replicate the issue using shadowjar: https://github.com/racc/typesafeconfig-guice-test
When I run the gradle shadowJar task, and run my Test-all.jar file, it works.

Thank you for your help.
I'll work through this issue later, if I find a solution I'll write you what is happening.
Regards!

Was unable to resolve this issue too. I'll be taking another look soon and will update #2 if I figure it out

@rodricifuentes1 were you able to resolve this?

@fayimora Nope, I didn't have time to keep looking for a solution :(

did you look at my example project?
https://github.com/racc/typesafeconfig-guice-test

@racc
I met the same situation of this issue and I tried https://github.com/racc/typesafeconfig-guice-test.
It works!
But I found if I wrote this way:
`public class Main {
@Inject
private Injectable injectable;
public Main() {
Config config = ConfigFactory.load();
System.out.println(config.getString("test.prop"));
System.out.println(config.getString("test.prop2"));
	Injector injector = Guice.createInjector(TypesafeConfigModule.fromConfig(config));
	injector.injectMembers(this);
	System.out.println(injectable);
}

public static void main(String[] args) {
	Main main = new Main();
}

}`
It will replicate the issue!

The use of the method TypesafeConfigModule.fromConfig(config) is now deprecated as of the latest version (0.0.3).
Using TypesafeConfigModule.fromConfigWithPackage(config, packagePrefix) is now the preferred way of instantiating the TypesafeConfigModule - you should specify a package prefix for classes to scan.


v0.4 integration with SSO

Context
Upgrading Sandbox env to latest release of redbox.
Changes proposed in this pull request

Guidance to review

Relevant links
Things to check

[ ] I have added any new ENV vars in all deployed environments
[ ] I have tested any code added or changed
[ ] I have run integration tests

I have an idea to make this more configurable we should leave the User model as the other model but create our own SSOUser or something. Then in the settings configure line 145 AUTH_USER_MODEL = "redbox_core.User" this will allow us to switch the db model for the user between services. We should make sure when we reference the user's User model it should be via get_user_model https://docs.djangoproject.com/en/5.0/topics/auth/customizing/#referencing-the-user-model

I have an idea to make this more configurable we should leave the User model as the other model but create our own SSOUser or something. Then in the settings configure line 145 AUTH_USER_MODEL = "redbox_core.User" this will allow us to switch the db model for the user between services. We should make sure when we reference the user's User model it should be via get_user_model https://docs.djangoproject.com/en/5.0/topics/auth/customizing/#referencing-the-user-model

@a-gleeson I initially looked at doing this so I didn't affect the original model, but there was a reason I moved away from it again.  I'd have to double check as it was a while ago.  If we use SSOUser as our class, when an object of that is created, even with AUTH_USER_MODEL set to it, won't other functions that call on that object not be able to find it? e.g. Line 196 in models.py (in django_app) user = models.ForeignKey(User, on_delete=models.CASCADE) references the User class.  If that's not present (because it's SSOUser) this won't work?

@a-gleeson  sorry didn't read the link - also should have thought about something like that before.. less haste more speed?

It's an easy miss, I only know from multiple Django projects recently!


Added SecureUrl to FileState to support TLS file downloads.

Fixes #54.

Tests added, made SecureUrl stateless for a couple of reasons:

1: Thread safety: Technically not a serious issue, as pointer stores are guaranteed to be atomic on every processor architecture I can think of, and the overhead of creating a second UriBuilder is so minimal it's not worth thinking much about.
2:  Consistency with the rest of our state architecture. If we were to refactor FileState to be IFileState and MutableFileState, it doesn't make sense to have the getter have any side-effects.

This theoretically reduces performance, but I can't think of a situation where you're gonna be repeatedly calling for the Url of the same file without caching it in another variable somewhere.

Test added.

Perfecto!


Update README.md

asdfasfasf
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

dsfasdfasdfasdfaf

Pull Request Test Coverage Report for Build 6244

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.001%) to 28.035%

Files with Coverage Reduction
New Missed Lines
%

tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java
1
83.33%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java
2
73.74%

Totals

Change from base Build 6240:
0.001%

Covered Lines:
26244

Relevant Lines:
93613

💛  - Coveralls


[BUG] The MatchTag stage in the App automatically removes spaces

Spaces are allowed in a sample or label tag, but when you try to use the MatchTags view stage in the app, any tags written in the list,of,tags automatically have spaces removed. This means it is impossible to filter by a tag using this stage. You have to use the sidebar to filter by that specific tag.

fix is merged to develop. safe to close this?


seperate compact counters lockdown and closing states

Compact counters on function body is locked when JIT started and then we should never  change it afterward (unless redefer and unlock first)
however when function body cleanup we do cleanup the counters, at that time we unlock and then lock the counters, in between this, there might be JIT thread accessing the counters hence we Assert that counters should be in locked state.
seperating lockdown and closing state to avoid this racing condition

replace with a new one targeting release/1.10


Notifications for multisig incept, rotate and interact.

This PR includes:

Notifications for multisig incept, rotate and interact.

Notifications for delegation incept, rotate and multisig delegate incept and rotate.

Delegate query race condition fix.

Signed-off-by: pfeairheller<EMAIL_ADDRESS>

Codecov Report

Merging #153 (a85381b) into master (b595724) will increase coverage by 0.28%.
The diff coverage is 83.82%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   87.35%   87.63%   +0.28%
==========================================
  Files         144      145       +1
  Lines       32706    33250     +544
==========================================
+ Hits        28569    29139     +570
+ Misses       4137     4111      -26

Impacted Files
Coverage Δ

src/keri/app/booting.py
29.53% <0.00%> (-0.41%)
:arrow_down:

src/keri/app/cli/commands/agent/demo.py
50.00% <0.00%> (+2.94%)
:arrow_up:

src/keri/app/cli/commands/delegate/confirm.py
21.64% <0.00%> (-0.23%)
:arrow_down:

src/keri/app/directing.py
83.92% <ø> (ø)

src/keri/peer/exchanging.py
66.66% <0.00%> (+5.19%)
:arrow_up:

src/keri/app/cli/common/displaying.py
8.95% <4.34%> (-2.41%)
:arrow_down:

src/keri/app/forwarding.py
85.83% <21.42%> (-8.67%)
:arrow_down:

src/keri/core/parsing.py
77.75% <33.33%> (+0.15%)
:arrow_up:

src/keri/app/habbing.py
82.39% <40.00%> (-0.40%)
:arrow_down:

src/keri/app/cli/commands/kevers.py
42.50% <42.50%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b595724...a85381b. Read the comment docs.


Cilium 1.14.0-snapshot.3 treats external IPs as internal

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
In 1.13 and 1.14.0-snapshot.2 Cilium (looking via hubble ui) treated <IP_ADDRESS>/16 network hosts as an external network, which is right. But since 1.14.0-snapshot.3 it treats it as internal Kubernetes, so network policies don't work and block traffic.
Cilium Version
1.14.0-snapshot.3
Kernel Version
Linux 6.2.0-20-generic #20-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr  6 07:48:48 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
k3s 1.26.5
Sysdump
unable to upload due to 31MB file size
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Problem is gone after complete cilium and its CRD removal (maybe this is not needed) and reinstalling with helm values:
ipam:
  operator:
    clusterPoolIPv4PodCIDRList:
    - <IP_ADDRESS>/16

nah... now it treats internal 10.42.* services as external

more observations:
we have got a network disaster in our infra, so for some reason I did restart 2/3 of cilium agents on 2/3 nodes. And then hubble started to show part of the traffic to external IPs as internal, another part as external.


Update broken link to parameter details readme.md

current link has been broken (404).

Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes

Replace me
Replace me
Replace me

Breaking Changes

Replace me
Replace me

Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[x] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues
[x] (AVD LZA Team Only) Associated it with relevant ADO Items
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@cpinotossi thanks for reporting the issue, the parameters markdown description files were just updated, please check again.
Dismissing this PW, since the change is no longer needed.
@moisesjgomez


[Java][DateTime] Enable and fix 'DateTimeModelExtendedTypes' tests

Proposed Changes
Enable 8 skipped DateTimeModelExtendedTypes tests in Java
Testing

Merged with MS Master.


Optional fields default to none

To the repo maintainers: this can be closed, this is only an improvement that will be included as part of https://github.com/1Password/typeshare/pull/169

@amandayu1 It does look like #169 will include these changes. Do you object to me closing this PR as @hculea suggested?

@savannidgerinel - for more context around this - this is not an open-source contribution, as Amanda was an intern with the Programmatic Interfaces team in the summer term. This was part of the team's sprint, and this work was eventually included in the other PR that I referenced.
Also, since her internship ended, I believe Amanda no longer has access on the fork that contains this PR's source branch (which is under my namespace), so I think this should be safe to close 😄


Documentation regarding helm 3.7 is incorrect

Describe the bug
The installation docs prescribe using a version of helm greater than or equal to 3.7 due to a breaking change introduced in helm 3.7.
This appears to be incorrect and should instead say use a version of helm less than 3.7?
Steps to reproduce
Using helm 3.7
$ helm version
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}
$ export HELM_EXPERIMENTAL_OCI=1 ; helm pull oci://public.ecr.aws/aws-controllers-k8s/s3-chart --version v0.0.4 -d s3-chart
Error: manifest does not contain minimum number of descriptors (2), descriptors found: 1
$

Using 3.6.3:
$ helm version
version.BuildInfo{Version:"v3.6.3", GitCommit:"d506314abfb5d21419df8c7e7e68012379db2354", GitTreeState:"clean", GoVersion:"go1.16.5"}
$ export HELM_EXPERIMENTAL_OCI=1 ; helm pull oci://public.ecr.aws/aws-controllers-k8s/s3-chart --version v0.0.4 -d s3-chart
v0.0.4: Pulling from public.ecr.aws/aws-controllers-k8s/s3-chart
$

Expected outcome
Documentation regarding helm 3.7 to be accurate.

Thank you for bringing it to our attention.
In this case, v0.0.4(released 10 days ago) was generated using helm 3.6
Coming week, we will generate the new release of all ACK controllers, which will be compatible with helm 3.7, and also consistent with our documentation.

Please reopen if you still see concerns.
ACK team released new controllers which are compatible with Helm-3.7 and consistent with documentation.

@vijtrip2 I am still encountering this issue with the SageMaker chart v0.1.0:
➜ helm version
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.17"}
➜ helm pull oci://public.ecr.aws/aws-controllers-k8s/sagemaker-chart --version v0.1.0 -d sagemaker-chart
Error: manifest does not contain minimum number of descriptors (2), descriptors found: 1

Yes because sagemaker controller haven't been built and released with helm3.7 .
Sorry for the inconsistency among helm version compatibility but sagemaker team handle release of their own controller. I will reach out to them to make a new release. Current release should work well with helm 3.6


Use grin node as backend instead of relying on a third-party

Title says it all, would be awesome if Niffler was "completely standalone".

yes, working on it, will released this work

Awesome!

Done by v0.4.2


[Marketplace] support feature flag for Marketplace

Description
support feature flag for Marketplace:

hide DIAL Marketplace button on conversation panel
hide Search on My Applications
redirect to chat if marketplace is disabled

Use case/motivation
No response
Related issues
No response
Confidential information

[X] I confirm that do not share any confidential information

Verified on staging env successfully


OS8050875:Direct super calls in a base class constructor

Direct super calls in a base class constructor should be SyntaxError. Define new flags to signify where direct super calls are syntactically correct and pass these flags into eval() and multiple nested cases comprised of a mix of eval and lambda.

@aneeshdk @LouisLaf @pleath @Microsoft/chakra-es, could you review pls?

@aneeshdk @LouisLaf @pleath @Microsoft/chakra-es could you review pls?

@aneeshdk @LouisLaf @pleath @Microsoft/chakra-es, changed to lazy stack-walking to avoid special treatment of extra argument (unit test added to es6/rest.js). Perf flat. Review pls?

Moving to release/1.4


[Bugfix][CI/Build][Hardware][AMD] Install matching torchvision to fix AMD tests

PR https://github.com/vllm-project/vllm/pull/5908 installs transformers >= 4.42.0 for Gemma-2 support. This broke the AMD container and all AMD tests because certain torchvision features are used that are not yet supported by the container's version of torchvision.
This PR resolves the issue by installing a matching updated version of torchvision.
FIX #5908
An example of the error:
/vllm-workspace/tests/conftest.py:16: in <module>
    from transformers import (AutoModelForCausalLM, AutoModelForVision2Seq,
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/utils/import_utils.py:1551: in __getattr__
value = getattr(module, name)
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/utils/import_utils.py:1550: in __getattr__
module = self._get_module(self._class_to_module[name])
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/utils/import_utils.py:1562: in _get_module
raise RuntimeError(
E   RuntimeError: Failed to import transformers.models.auto.processing_auto because of the following error (look up to see its traceback):
E   operator torchvision::nms does not exist

To speed up the CI queue, I've cancelled the distributed tests for the latest CI run in this PR since they won't pass anyway until #5905 has been merged. Now that it has been merged, please merge main into your branch so that the CI can pass once again.

@DarkLight1337 @WoosukKwon
PR https://github.com/vllm-project/vllm/pull/5526 was merged while AMD CI was down and again contains the problematic runtime_env={"working_dir": VLLM_PATH} in tests/entrypoints/test_openai_chat.py that we discussed as superfluous in a prior PR https://github.com/vllm-project/vllm/pull/5422#issuecomment-2189084755
I've removed this, which should allow the AMD entrypoints test to pass assuming no further regressions in the ongoing entrypoints test refactors.

@mawong-amd Sorry for this CI break. Currently, because the AMD CI has a very long queue, we treat it optional to unblock the committers. Instead, we use it to find regressions like this. Once the CI gets more stabilized and optimized, we will make it required.

@mawong-amd Sorry for this CI break. Currently, because the AMD CI has a very long queue, we treat it optional to unblock the committers. Instead, we use it to find regressions like this. Once the CI gets more stabilized and optimized, we will make it required.

Thanks for the explanation @WoosukKwon. We are aware of the seriousness of this issue and actively working towards a solution to make AMD CI faster and more reliable.
In the meantime, however, given the fast pace of vLLM, and respecting its roots as a research project, I understand and respect that there will be times when a feature should be urgently added and any potential regressions fixed afterward. Adding Gemma 2 support in https://github.com/vllm-project/vllm/pull/5908 is a good example.
But it is difficult to find a better case where CI should be run completely than test refactoring. First, it does not add any new features by itself. Second, there is less urgency especially when tests already work, even if some think they are a little messy. Third, any changes to CI should obviously be tested extensively.
At the end of the day, AMD has devoted many resources to supporting CI in vLLM. And we are in the process of devoting more to address known limitations. Each time CI breaks in upstream, resources have to be expended to find and fix the issue. This becomes harder to justify if CI is so easily ignored even when it is needed most. And especially when it was communicated previously that despite its soft fail status, collaborators would make a serious effort to check AMD CI before merging.
vLLM has grown a lot very quickly and will continue to grow. Given how many people rely on it, even small changes can have large effects.
And, as evidence of how big vLLM has gotten: CI has been particularly slow today—6+ hours and increasing for both Nvidia and AMD tests :)

Hi @mawong-amd, sorry for the late reply. I totally missed your message somehow. I get where you're coming from with the AMD CI results - they should definitely be taken more seriously, and we'll make sure to pay closer attention to them.
Also, just to give you some context, most of the vLLM contributors don't have access to AMD GPUs. For example, the Berkeley team, just got the MI210 dev box installed ~1.5 weeks ago (around the time you wrote the comment). Up until then, we didn't have any way to test things out on AMD hardware ourselves. But now that we have the dev box, we'll be able to be more proactive on this.
Again, thanks for sharing your thoughts and concerns. We want this to be a productive collaboration for everyone.


Add cropping to train and validation

Add cropping to train and validation when para_load = False, and remove flag_datalayer=True condition, since flag_datalayer is actually not needed.

@hma02 you don't have to close the previous one and create a new one :)
simply push your changes to the same branch and the pull request will be updated
but we'll just work on this one.
Have you run a one / two day test on this to see if it works correctly?
if the curves looks right, we can merge it

seems this implementation is correct and give same results.
Let's merge it after all the comments like
###BUG 1 FIXED#####

@hma02 just make changes in your branch and push it, the pull request will be updated

Sounds good. By the way I fixed another bug which I noticed before, that is in train.py but not in train_2gpu.py, the drv.init() should be called no matter it is para_load or not, otherwise it will give error when para_load= False

@hma02 nice extra fix!
regarding flag_batch, it seems that it should be there anymore?
because we don't really need the flag_batch = True? because we always want to randomly crop and flip on a per image base?

Now the flag_batch = True is only used in validation, cropping the center of the image as input batch and giving a deterministic error evaluation, if this is what we are supposed to do.  It might be interesting to add another feature during validation, that is cropping on different part of the same photo to improve validation accuracy.

@hma02 good point, merged


Custom color swatch

Q
A

Bug fix?
[ ]

New feature?
[ X]

New sample?
[ ]

Related issues?
N/A

What's in this Pull Request?
Added the ability to add a third Color Swatch Group called custom.  This will allow you to add custom colors to the font color selector.
sample:
<RichText
                value={this.props.richTextValue}
                onChange={(text)=>this.props.onRichTextChange(text)}
                customColors={[
                  {
                    color: 'White',
                    id: '#ffffff',
                    label: 'White'
                  },
                  {
                    color: 'Grey',
                    id: '#efefef',
                    label: 'Grey'
                  }
                ]}
              />

Thank you @eweintraub for this feature!

My pleasure, keep up the great work!
On Oct 9, 2019, 2:30 PM -0400, Alex Terentiev<EMAIL_ADDRESS>wrote:

Thank you @eweintraub for this feature!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Reordering layers hide legends

Steps to Reproduce

Edit a map with several layers.
Go to the top layer.
Create a legend. In the GIF above I created one for color and another one for size.
Check that the legend is visible.
Go back to the layer list.
Go to the bottom one.
Create a legend for that layer.
Check that now we have a legend for three different values.
Go back to the layer list.
Reorder the layers. Grab the top one and move it one position down, for instance (like in the GIF above).
The two legends of the top layer disappear!!
If you edit that layer, you can notice that the legends are still there, but they're not visible anymore.

Picking this

Ready for code review.

Acceptance passed. Local 👍  Ded02 👍


feat(stepper): Add documentation for stepper

Revised based on review. Ready for review again :+1:

I'll leave it to @kara or @mmalerba for a final review

lgtm


Reliably kill multithreaded server

When I was trying to get Wraith to work, I updated our little Python server to support multiple threads.
This meant that Wraith could open up a bunch of pages simultaneously without the thing crashing out.
Unfortunately, this made killing the server with "Ctrl+C" extremely unreliable.  Lots of times it would just hang until the terminal pane was closed, which was immensely frustrating.
I think this commit fixes it.
Helpful source: http://kmkeen.com/socketserver/2009-02-07-07-52-15.html

Always on the cutting edge here at GDS, Kev.


Idle holding animations for anything bigger than a handgun

It would be cool if we had an idle "gun down" animation so the models don't stick into the ground especially when the even have something like a suppressor on them

Yes! This would be great! Perhaps if they redo the animation engine they could add this.
(Also, Mo' Bends support would be cool too!)

VMW 3.0 fixed mo bends support with armor just hands don't actually move to the guns position which is fine

VMW 3.0 fixed mo bends support with armor just hands don't actually move to the guns position which is fine

I'm confused, what do you mean just hands don't actually move?

VMW 3.0 fixed mo bends support with armor just hands don't actually move to the guns position which is fine

I'm confused, what do you mean just hands don't actually move?

Hands don't move to the gun points to hold the gun but mobends works with VMW armor now and It holds the gun properly still just without the second hand

Ah! Ok. I'll have to use this soon.


[question] todo-mvp Why the app don't show saved todo after I have killed the app

When I add todos and then kill the app. Then I reopen the app I found no todo in it.
I though I already saved in sqlite. Is there anything wrong?

Did the app can save/load todo from network?

Duplicate of #123


calicoctl ipam release/show cmd

Fix for #87

Behavior changes from the python version to go version:
calicoctl ipam info <IP> —> calicoctl ipam show <IP>
Python calicoctl:
vagrant@calico-01:~$ calicoctl ipam info <IP_ADDRESS>
No attributes defined for <IP_ADDRESS>
vagrant@calico-01:~$ calicoctl ipam info <IP_ADDRESS>
IP <IP_ADDRESS> is not currently assigned

vagrant@calico-01:~$ calicoctl ipam release <IP_ADDRESS>
Failed to release address
vagrant@calico-01:~$ calicoctl ipam release <IP_ADDRESS>
Address successfully released

Go calicoctl:
vagrant@calico-01:~$ calicoctl ipam show <IP_ADDRESS>
No attributes defined for IP <IP_ADDRESS>
vagrant@calico-01:~$ calicoctl ipam show <IP_ADDRESS>
IP <IP_ADDRESS> is not currently assigned in block

vagrant@calico-01:~$ calicoctl ipam release <IP_ADDRESS>
Failed to release IP address <IP_ADDRESS>
vagrant@calico-01:~$ calicoctl ipam release <IP_ADDRESS>
Successfully released IP address <IP_ADDRESS>

pushed the changes PTAL

A few more comments, then LGTM.

@caseydavenport made those changes and CircleCI build passes now. PTAL

Some more review comments from me.
I'm enjoying the amount of comments you've added to the code, but make sure you're using proper capitalization and punctuation!

TODO:

[ ] Fix up imports to use projectcallico instead of tigera

@gunjan5 could you address @fasaxc's comment to switch over the imports to use projectcalico, just for the files touched in this PR?
Once that is done, LGTM!

@caseydavenport done! but the build is failing because of that which, I think, is expected.
Also, commits are squashed

fatal: unable to access 'https://go.googlesource.com/tools/': Failed to connect to go.googlesource.com port 443: Connection timed out

I'm not sure the build is failing because of the import changes.

@caseydavenport seems like it was a temporary glitch, it's gone now. The build failure is because of different import paths now

@gunjan5 I think a rebase against master will fix that for you.

@caseydavenport done! PTAL


Create zoom controls

For apps that use mouse controls (Geo Map, Network, etc), there should be zoom controls in the top-right corner of the visualization.
Their is still some legacy JS/CSS in the source from v0.9 that should be refactored to achieve this.

The idea here is to have plus, minus, and reset buttons in one of the corners.


Add more blocks to frontend/_includes/emotion

1. Why is this change necessary?
In case of adding customizations here I have to overwrite the complete template. Not so cool.
2. What does this change do, exactly?
Adds more smarty blocks
3. Describe each step to reproduce the issue or behaviour.

Add rich snippets
Make attribute/free text field
Choose a central point for emotion worlds
Want to add meta-data
Has! To! Override! Complete! Template! :anger:

4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Please follow this naming scheme for smarty blocks: https://developers.shopware.com/designers-guide/html-smarty-coding-guidelines/#naming-smarty-blocks-correctly

So the _includes folder is already breaking the structure? The _includes folder does not suggest any controller. So I can't use the correct one. A voice from shopware here please.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-24823
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:


history-substring-search: add upstream updating and update to 2015_04_26

The history-substring-search plugin has an upstream repo at https://github.com/zsh-users/zsh-history-substring-search. The OMZ version is significantly behind.
This PR adds a script that can programmatically update the OMZ plugin from the upstream repo, by copying it in and adding OMZ-specific tweaks. This PR also updates the OMZ plugin with the latest upstream head version, c4a83561a12b898ff7145856d0e6ae50757e28ba (2015-04-26, current as of 2015-07-27).
Fixes #3913.

Updated to 2015-09-28 version.


Release 1.4.0+v1.4.0

Sure. I'd accept a PR that loosens them to 1 instead of 1.2.3 or 0.1 instead of 0.1.2.


Roles list issue

Laravel Version: 5.6.3
PHP Version: 7.2.5
Laravel-admin: 1.5.*

Description:
When I go to /admin/auth/roles
I see this error:
BadMethodCallException In Macroable.php line 99 :
Method Illuminate\Support\Collection::label does not exist.

Can't reproduce your issue

I have the same problem with user list edit page.
When I go to /admin/auth/users/{id}/edit
I see this error:
ErrorException In Macroable.php line 100 :

Method Illuminate\Database\Eloquent\Collection::getKey does not exist.


It's over. Confirmed broken on all my macs. :(

Not sure what's going on but I can't get it to work on either of my macs. Looks like others have already mentioned some of the problems in other issues (blank space in UI, song loading forever that doesn't play) but I figured I'd start this thread and see if it's fully broken for others. I tried the HTML5 fix but no luck.
Would love to see this take the direction MailPlane took and become a big boy paid app in the app store with full support.

Downloading the most recent beta fixed these issues (among others) on my Mac.
https://github.com/kbhomes/radiant-player-mac/releases/tag/v<IP_ADDRESS>-beta

Ditto for me.  On 20 May, Remote Desktop Client was updated (for Yosemite).  After that, I got all the same problems that mpsulli did.
Fortunately, the <IP_ADDRESS>beta seems to fix it.

Finally! Beta release fixed my current favorite app.

Thank you all for sharing the good news about the beta. Cheers to everyone
that's working on this project.
On May 24, 2015 7:51 PM, "Aaron B.W. Collins"<EMAIL_ADDRESS>wrote:

Finally! Beta release fixed my current favorite app.
—
Reply to this email directly or view it on GitHub
https://github.com/kbhomes/radiant-player-mac/issues/324#issuecomment-105100999
.

:+1:

Thanks you to all that made this happen / worked on it. Without this app I was thinking about cancelling my subscription, but alas it works again thanks again to all the people working on / supporting  this project!

Thanks for this release. Having to use that Chrome mini-player was killing me.

Works for me to, running 10.10.4 (14E26a)

Wohoo!
Working on MacBook Pro (Retina, 13-inch, Late 2013) OS X 10.10.3

Thanks! :-D


CI: upgrade pip in benchmarks CI run

A merge to master CI run just failed with:
  Could not find a version that satisfies the requirement
  pluggy<1.0.0a1,>=0.12 (from pytest) (from versions: )

  No matching distribution found for pluggy<1.0.0a1,>=0.12 (from pytest)
  You are using pip version 10.0.1, however version 21.1.2 is available.

I think this is an obvious fix so let's put it in. Thanks Ralf


Test environment configuration

Description of change

Test environment configured

tests for response of app.use(middleware)
tests for response of router.get(middleware)

Fix some errors while testing

write after end error
There was write after end error which is occured by invoking multiple res.end() per request.
response reset situation
text response has been changed to empty object because Boolean({}) is true

Pull-Request Checklist

[x] Code is up-to-date with the main branch
[x] There are new or updated unit tests validating the change
[ ] Documentation has been updated to reflect this change   ← don't know where to write
[x] The new commits follow conventions explained in CONTRIBUTING.md

conflict


Include timestamp and process ID in GC log file name

To avoid overwriting previous GC logs, the default GC log file name
includes the start timestamp and process ID.
See https://bugs.openjdk.java.net/browse/JDK-7164841 for more
information about the %t and %p -Xloggc template placeholders.
For example, the current log file may be of the form:
var/log/gc-2016-10-21_11-22-39-pid30532.log.0.current

@uschi2000 @markelliot for review

@uschi2000 or @markelliot can we tag a 0.9.2 release please?

0.10.0 due to behaviour change.


Added warning in the pull request template that this is a read only repo

Question
Answer

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets

License
MIT

Doc PR
n/a

Description
To avoid that people is opening PRs to our read only repos

Current coverage is 82.78% (diff: 100%)

Merging #91 into master will not change coverage

@@             master        #91   diff @@
==========================================
  Files            21         21
  Lines           964        964
  Methods         206        206
  Messages          0          0
  Branches          0          0
==========================================
  Hits            798        798
  Misses          166        166
  Partials          0          0

Powered by Codecov. Last update c31e37e...dd5310a


Is there any shared configs for Swift based projects?

Uncrustify and Clang Formatter don't support Swift and so this plugin is not able to format Swift code.


Updated to latest, installed extensions are gone and cannot reinstall

VSCode Version: Code 1.3.0 (e724f269ded347b49fcf1657fc576399354e6703, 2016-07-07T16:50:12.291Z)
OS Version: Linux x64 4.2.0-41-generic

Steps to Reproduce:
Using under Ubuntu Linux 15.10,

Quit Visual Studio Code 1.2
run .deb file to update from 1.2 to 1.3
Click More -> Show Installed Extensions , no extensions show up
Hit ctl-P, type 'ext install python' (for example)
Python shows up in Extensions sidebar.  Click on Install.
Nothing happens, nothing is installed.

Same with me...
Ubuntu Gnome 16

Looks like they've renamed the dpkg also, to roll back, do
sudo apt-get remove code
the old 1.2.1 package is named "visual-studio-code",
imho they should stick with "visual-studio-code"

I have the same issue with Ubuntu 16.04. Removing the old package and reinstall did not resolve the issue.

It worked after a reboot of the OS.

fpahl, you're right it does.  Thanks.
so upgrade procedure is:

Remove the old one with 'sudo apt-get remove visual-studio-code'
Install new one (1.3.0)
Reboot.
Remember that the 1.3.0 version is called 'code' instead of 'visual-studio-code'

This is a duplicate of https://github.com/Microsoft/vscode/issues/8859#issuecomment-231410408, see there for root cause and steps to fix.


Python stack is modified during module import

2d3571f490bc6592ef60fa904a17ea78f0fd9e2f modifies the Python stack depth while the module is being imported. This makes it impossible to keep track of and understand what is being done. Things like this should be done from the main function.

9b63b8e0c12428742d9add55550a8db8805fe574


Added 2 repositories to java main MD

Seems those repositories exist but are not listed.

@jack-berg Does this make sense?

thanks @asafm , minor change request: point to the sem conv on the docs website

@svrnm Fixed all comments

/fix format

/fix:all


Fixing facebook deep links

"On the bottom banner, clicking on the Instagram and Twitter logo, opens the corresponding when on mobile (Android / Chrome & iOS / Safari).
Clicking on the Facebook opens the m.facebook.xx page on the browser, rather than the app."
Used package.js and 'deep' link urls

Pushed the wrong branch - fixing rn

Pushed the wrong branch - fixing rn


[r2.12-rocm-enhanced] Changes to track call-context information (forward pass / backprop pa…

…ss) for GEMM calls
Changes to track call-context information (forward pass / backprop pass) for CONV calls
Updating rocm_blas.cc to call the rocblas_gemm_ex API with the  flag set for the fp16 datatype.
Updating rocm_dnn.cc to set the MIOPEN_CONVOLUTION_ATTRIB_FP16_ALT_IMPL attribute on the comvolution descriptor for the fp16 datatype.
Fix for the test //tensorflow/c/experimental/ops/gen/cpp:cpp_generator_test. This commit modifies machine generated files, so it is probably not the right thing to do. But it will have to do for now...the recommended script to regenerate this file (tensorflow/c/experimental/ops/update_cpp_ops.sh) errors out, and does not work as advertised
Fix for the test //tensorflow/compiler/mlir/xla/tests:legalize-tf-include-tf2xla-fallback.mlir.test. The test creates a tf.BatchMatMulV2 instance in MLIR that now needs to be updated to have the grad_x/grad_y attributes we have added to that op
Adjusting tolerances for gfx90a

retest gpu-non-pip-large please

retest gpu-non-pip-large please


Failed to minify the code from /lib/base.js

Steps to reproduce
Generate a create-react-app with @feathers/client with rest configured and "npm run build".
Expected behavior
A build pack is generated.
Actual behavior
"Failed to compile. Failed to minify the code from this file:
./node_modules/@feathersjs/rest-client/lib/base.js:2"

Thank you for developing feathersjs, you're awesome.

Since the new packages are not pre-transpiled, the Webpack Babel build configuration has to include node_modules/@feathersjs like this:
  module: {
    rules: [{
      test: /\.jsx?$/,
      exclude: /node_modules\/(?!(@feathersjs/))/,
      loader: 'babel-loader'
    }]
  },

If you don't want to deal with the chaos of an ejected create-react-app you probably want to use https://github.com/feathersjs/client (@feathersjs/dist/feathers)

Thank you @daffl, with 'feathers-client', 'feathers-hooks' and 'feathers-authentication-client' I was able to solve the problem and get a production build.
But now the problem is that in the app ( deployed to Heroku ) I can't auth a user, cause seems like feathers is not able to store jwt:

In chrome devtools I can't see 'feathers-jwt' in cookies or localstorage, and I still have my previous tested code (tested only in development, not on Heroku).
Is it possible that changing back to old packages causes this problem?
My feathers client code:
import io from 'socket.io-client'
import feathers from 'feathers-client'
import hooks from 'feathers-hooks'
import socketio from 'feathers-socketio/client'
import auth from 'feathers-authentication-client'

const apiURL = process.env.NODE_ENV === 'production' ? 'https://my-server.herokuapp.com' : 'http://localhost:5000'

const socket = io(apiURL, {
  transports: ['websocket']
})

let client = feathers()
  .configure(hooks())
  .configure(socketio(socket))
  .configure(auth({
    storage: window.localStorage,
    cookie: 'feathers-jwt'
  }))

export default client

Odd, it should be backwards compatible but to verify (I didn't get to updating the client documentation yet) try the latest version like this:
import io from 'socket.io-client'
import feathers from '@feathersjs/client/dist/feathers'

const { socketio, authentication } = feathers
const apiURL = process.env.NODE_ENV === 'production' ? 'https://my-server.herokuapp.com' : 'http://localhost:5000'

const socket = io(apiURL, {
  transports: ['websocket']
})

let client = feathers()
  .configure(socketio(socket))
  .configure(authentication({
    storage: window.localStorage,
    cookie: 'feathers-jwt'
  }))

export default client

If you are still getting the same error it might be something else.

Build packing still works with '@feathersjjs/client/dist/feathers', but the cookies problem still occurs. Any suggestions?

Please open a new issue with steps to reproduce if it still persists. I added docs for module loader integration so we can close this one.

Hi @daffl , could you please reopen this issue? I provided you a repo for reproduction https://github.com/lebrun-burel/demo-feathers-fail. The exact same issue still happens, and of course I'd like to avoid to eject if its possible. Do you have an idea on how to fix this?

I quickfixed this by forking the lib and transpiling them but this is not optimal :/ Is there a specific reason for not providing a ES5 version? I am not fond of requiring user to use webpack/babel to get ES5 js, see the issues it can raise with 3rd party tools like create-react-app.

All Feathers libraries are using CommonJS so I don't think there is a way around using Webpack/Babel anyway. As mentioned in the create-react-app section the ES5 builds are provided in @feathersjs/client. A specific build for the REST client can be found in @feathersjs/client/rest.

The @feathersjs/client does indeed contain all the ES5 compiled packages, however I don't see an ES5 version of the @feathersjs/errors in there and therefore am having same build errors with create-react-app while referencing the errors lib.
I solved it and hopefully any future ES6/ES5 issues by following the instructions here: https://daveceddia.com/customize-create-react-app-webpack-without-ejecting/

I used npm install babel-core babel-loader babel-preset-env to install the dependencies.
Added .babelrc with only the line { "presets": ["env"] }.
Added the config-overrides.prod.js (described in article) which looks like this:

module.exports = function(config) {
  // Add the babel loader second-to-last
  // (last one must remain as the "file-loader")
  let loaderList = config.module.rules[1].oneOf;
  loaderList.splice(loaderList.length - 1, 0, {
    test: /\.jsx?$/,
    exclude: /node_modules\/(?!(@feathersjs)\/).*/,
    loader: 'babel-loader'
  });
}

Everything works fine now, the build throws no errors.

The default export from @feathersjs/client should have a feathers.errors property (see https://docs.feathersjs.com/api/client.html#feathersjsclient).


Connection failed

SAP HANA Driver version -0.2.1
VsCode version :1.47.3
I have entered the connection details from CF service instance ->service key
Getting below exception
Connection failed (RTE:[89006] System call 'connect' failed, rc=10061:No connection could be made because the target machine actively refused it  (zeus.hana.canary.eu-central-1.whitney.dbaas.ondemand.com
Regards,
Anil

Hello,
HANA Cloud only supports secured connections (ssl). you need to mark this in the connection details. you also need to make the CA (https://dl.cacerts.digicert.com/DigiCertGlobalRootCA.crt) used by HANA Cloud trusted by the hana-client.
You can read about it in the following post. note, it is described how to do it in SAP Business Application Studio, but can also be done similarly in VS Code, and with this new driver, even directly in the connection UI.
https://blogs.sap.com/2020/04/22/creating-an-encrypted-connection-to-hana-as-a-service-and-hana-cloud-service-instances-in-business-application-studio/

This is quite commonly due to the fact that if the HANA Cloud instance is in a trial account then it's likely that it has automatically been stopped.
Double check that the instance itself is in a started state, then to connect again.
-Andrew

Closing due to lack of activity


Check the configuration file by default

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

So now the team (maybe the OTC) should reach a consensus whether we should leave this option enabled by default (and disablable by vendors) or not.

This pull request is ready to merge

Merged. Thanks!


More Information regarding "Rolling 90 Days"

In the line "The Azure Active Directory (Azure AD) default configuration for user sign-in frequency is a rolling window of 90 days."
What is the resetting factor of a "rolling" 90 days?  Does the 90 day period reset when a refresh token is used / requested?  Is another login required?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9561a367-20d8-62e9-57e5-694bab4c0878
Version Independent ID: a7c757e0-052b-fc42-70c5-030081baa573
Content: Configure authentication session management - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-conditional-access-session-lifetime.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@kvansaders
Thanks for your feedback! We will investigate and update as appropriate.

If there has been inactivity of over 90 days, users are required to reauthenticate with all required factors (first and second factor). They also need to reauthenticate and perform MFA if they've changed their passwords.
If you have a more restrictive policy set on the tenant, that policy will trump the 90 day policy and whatever policy is the most restrictive will take precedence (for example, if you've set Remember MFA for 14 days").
This is explained in this other document. https://docs.microsoft.com/en-us/azure/active-directory/authentication/concepts-azure-multi-factor-authentication-prompts-session-lifetime
Hope this helps! If you have further questions feel free to tag me.


TensorForestEstimator throws ValueError due to bad feature column handling

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):

Bug was discovered when writing a custom script that used TensorForestEstimator.  Code is provided below.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

Linux sandbox 4.15.0-45-generic #48-Ubuntu SMP Tue Jan 29 16:28:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
VERSION="18.04.2 LTS (Bionic Beaver)"
VERSION_ID="18.04"
VERSION_CODENAME=bionic

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:

not applicable

TensorFlow installed from (source or binary):

TensorFlow binary installed from PyPi via pip.

TensorFlow version (use command below):

tf.VERSION = 1.12.0
tf.GIT_VERSION = v1.12.0-0-ga6d8ffae09
tf.COMPILER_VERSION = v1.12.0-0-ga6d8ffae09
Sanity check: array([1], dtype=int32)

Python version:

Python 3.6.8

Bazel version (if compiling from source):

not applicable

GCC/Compiler version (if compiling from source):

Since Python was compiled from source via pyenv install, including compiler version:
c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0

CUDA/cuDNN version:

not applicable

GPU model and memory:

not applicable

Other information

== are we in docker =============================================
No

Python environment is managed with pyenv version. 1.2.9, with the following packages installed:
absl-py==0.7.0
asn1crypto==0.24.0
astor==0.7.1
awscli==1.16.109
azure-common==1.1.18
azure-storage-blob==1.5.0
azure-storage-common==1.4.0
backcall==0.1.0
bleach==3.1.0
boto3==1.9.99
botocore==1.12.99
certifi==2018.11.29
cffi==1.12.1
chardet==3.0.4
colorama==0.3.9
cryptography==2.5
cycler==0.10.0
decorator==4.3.2
defusedxml==0.5.0
docutils==0.14
entrypoints==0.3
future==0.17.1
gast==0.2.2
grpcio==1.18.0
h5py==2.9.0
idna==2.8
ijson==2.3
ipykernel==5.1.0
ipython==7.3.0
ipython-genutils==0.2.0
jedi==0.13.2
Jinja2==2.10
jmespath==0.9.3
jsonschema==2.6.0
jupyter-client==5.2.4
jupyter-core==4.4.0
jupyterlab==0.35.4
jupyterlab-server==0.2.0
Keras-Applications==1.0.7
Keras-Preprocessing==1.0.9
kiwisolver==1.0.1
Markdown==3.0.1
MarkupSafe==1.1.0
matplotlib==3.0.2
mistune==0.8.4
mpmath==1.1.0
nbconvert==5.4.1
nbformat==4.4.0
notebook==5.7.4
numpy==1.16.1
pandas==0.24.1
pandocfilters==1.4.2
parso==0.3.4
pexpect==4.6.0
pickleshare==0.7.5
prometheus-client==0.6.0
prompt-toolkit==2.0.9
protobuf==3.6.1
ptyprocess==0.6.0
pyasn1==0.4.5
pycparser==2.19
pycryptodomex==3.7.3
Pygments==2.3.1
PyJWT==1.7.1
pyOpenSSL==19.0.0
pyparsing==2.3.1
python-dateutil==2.8.0
pytz==2018.9
PyYAML==3.13
pyzmq==18.0.0
requests==2.21.0
rsa==3.4.2
s3transfer==0.2.0
scikit-learn==0.20.2
scipy==1.2.1
Send2Trash==1.5.0
six==1.12.0
snowflake-connector-python==1.7.6
sympy==1.3
tensorboard==1.12.2
tensorflow==1.12.0
termcolor==1.1.0
terminado==0.8.1
testpath==0.4.2
tornado==5.1.1
traitlets==4.3.2
urllib3==1.24.1
wcwidth==0.1.7
webencodings==0.5.1
Werkzeug==0.14.1

Describe the current behavior
When feature_columns argument is specified, TensorForestEstimator will throw the following error during a fit():
TypeError: '<' not supported between instances of '_RealValuedColumn' and 'str'

Describe the expected behavior
Expected behavior was that model would be built from training operation.
Code to reproduce the issue
Note that the CSV file 'Immunotherapy - ImmunoDataset.csv' can be obtained from the UC Irvine Machine Learning Repository at this URL:
https://archive.ics.uci.edu/ml/datasets/Immunotherapy+Dataset
Sample Code for TensorForestEstimator with pandas_input_fn
Python Standard Library Imports
import csv
import random

Non TensorFlow Imports
import numpy as np
import pandas as pd

TensorFlow Library Imports
import tensorflow as tf
import tensorflow.contrib.layers as layers
import tensorflow.contrib.tensor_forest as tforest

Aliased TensorFlow Library Imports
from tensorflow.estimator.inputs import pandas_input_fn
from tensorflow.python.platform import tf_logging as logging

tf.logging.set_verbosity(tf.logging.DEBUG)

Metadata for CSV Columns
COLUMN_PROPS = {
    'sex' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype' : tf.int32,
        'default' : -1,
        'feature_column' : layers.real_valued_column(
            'sex',
            dtype=tf.int32
        )
    },
    'age' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype' : tf.int32,
        'default' : -1,
        'feature_column' : layers.real_valued_column(
            'age',
            dtype=tf.int32
        )
    },
    'Time' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype' : tf.float32,
        'default' : -1.0,
        'feature_column' : layers.real_valued_column(
            'Time',
            dtype=tf.float32
        )
    },
    'Number_of_Warts' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype' : tf.int32,
        'default' : -1,
        'feature_column' : layers.real_valued_column(
            'Number_of_Warts',
            dtype=tf.int32
        ),
    },
    'Type' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype' : tf.int32,
        'default' : -1,
        'feature_column' : layers.real_valued_column(
            'Type',
            dtype=tf.int32
        )
    },
    'Area' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype' : tf.int32,
        'default' : -1,
        'feature_column' : layers.real_valued_column(
            'Area',
            dtype=tf.int32
        )
    },
    'induration_diameter' : {
        'is_feature' : True,
        'is_label' : False,
        'dtype': tf.int32,
        'default': -1,
        'feature_column' : layers.real_valued_column(
            'induration_diameter',
            dtype=tf.int32
        )
    },
    'Result_of_Treatment': {
        'is_feature' : False,
        'is_label' : True,
        'dtype': tf.int32,
        'default': -1,
        'feature_column' : None
    }
}

Ordering of CSV Columns
CSV_COLUMNS = [
    'sex',
    'age',
    'Time',
    'Number_of_Warts',
    'Type',
    'Area',
    'induration_diameter',
    'Result_of_Treatment'
]

Generate Lists of Features and Labels from Metadata
FEATURE_COLUMNS = []
LABEL_COLUMN = None

for k in CSV_COLUMNS:
    if COLUMN_PROPS[k]['is_feature']:
        FEATURE_COLUMNS.append(k)
    elif COLUMN_PROPS[k]['is_label']:
        LABEL_COLUMN = k

Helper Function for Shuffling and Exporting Subsets
This function is used to export training, evaluation, and test data sets as CSVs, shuffling the rows.
def generate_sets(datasets):
    for k, v in datasets.items():
        random.shuffle(v)
        with open(k + '.csv', 'w') as fobj:
            wrtr = csv.writer(fobj)
            wrtr.writerow(header)
            for rec in v:
                wrtr.writerow(rec)

Split Datasets for Traning, Evaluation, and Testing
trn = []
evl = []
tst = []

with open('Immunotherapy - ImmunoDataset.csv', 'r') as fobj:
    rdr = csv.reader(fobj)
    header = next(rdr)
    label_key = header[-1]
    feature_keys = header[:-1]

    for rec in rdr:
        # Output of random number generator determines
        # which set the record will be placed.
        rn =  random.random()
        if rn < 0.6:
            trn.append(rec)
        elif rn < 0.8:
            evl.append(rec)
        else:
            tst.append(rec)

datasets = {
    'train' : trn,
    'eval' : evl,
    'test' : tst
}

generate_sets(datasets)

Set up TensorForest Hyperparameters
fhp = tforest.tensor_forest.ForestHParams(
    num_classes=2,
    num_features=7,
    regression=False
)

Pluck Feature Columns from Metadata Dictionary
fcs = [COLUMN_PROPS[k]['feature_column'] for k in FEATURE_COLUMNS]

Instatntiate TensorForestEstimator Object
tfe = tforest.random_forest.TensorForestEstimator(
    fhp,
    feature_columns=fcs,
    report_feature_importances=True
)

Define a Wrapper for Training and Evaluation Using pandas_input_fn
def get_input_fn(csv_file, num_epochs=1):

    df = pd.read_csv(csv_file)

    # Workaround for this issue:
    #
    # https://stackoverflow.com/questions/48577372/tensorflowusing-pandas-input-fn-with-tensorforestestimator
    # https://github.com/tensorflow/tensorflow/issues/16692

    def internal_input_fn():

        features = df.loc[:,'sex':'induration_diameter']
        labels =  df.loc[:,'Result_of_Treatment']

        features, labels = pandas_input_fn(
            x=features,
            y=labels,
            shuffle=True,
            num_epochs=num_epochs
        )()

        features = {
            k : tf.expand_dims(features[k], axis=1)
            for k in features
        }

        labels = tf.expand_dims(labels, axis=1)

        return features, labels

    return internal_input_fn

Train on Data
tfe.fit(
    input_fn=get_input_fn('train.csv', num_epochs=None)
)

Evaluate the Model
tfe.evaluate(input_fn=get_input_fn('eval.csv'))

Define a Wrapper for Prediction
def get_predict_input_fn(csv_file):

    df = pd.read_csv(csv_file)

    print('actual values: {0}'.format(df.loc[:, 'Result_of_Treatment'].values))

    # Workaround for this issue:
    #
    # https://stackoverflow.com/questions/48577372/tensorflowusing-pandas-input-fn-with-tensorforestestimator
    # https://github.com/tensorflow/tensorflow/issues/16692

    def internal_input_fn():

        features = df.loc[:,'sex':'induration_diameter']

        features = pandas_input_fn(
            x=features,
            shuffle=False
        )()

        features = {
            k : tf.expand_dims(features[k], axis=1)
            for k in features
        }

        return features

    return internal_input_fn

Make Predictions on Test Data
# The documentation for tf.contrib.learn.Estimator.predict() lies.
#
# https://stackoverflow.com/questions/40705710/cannot-get-predictions-of-tensorflow-dnnclassifier

np.array(
    [
        res['classes']
        for res in list(
            tfe.predict(input_fn=get_predict_input_fn('test.csv'))
        )
    ],
    dtype=np.int32
)

Other info / logs
See my comment on the possible source of the problem.
https://github.com/tensorflow/tensorflow/commit/0b182c3940a3d15d574da327ac705c2efa18a985#r32454203

thank you for reporting this ! can you try to do this instead?
import pandas as pd
import numpy as np
import tensorflow as tf

def main(file_name='/Users/pengyu/Downloads/Immunotherapy.xlsx'):
    df = pd.read_excel(file_name)
    fhp = tf.contrib.tensor_forest.python.tensor_forest.ForestHParams(
        num_classes=2,
        num_features=7,
        regression=False
    )

    classifier = tf.contrib.tensor_forest.client.random_forest.TensorForestEstimator(
        fhp)
    x, y = df.drop('Result_of_Treatment', axis=1).values.astype(
        np.float32), df['Result_of_Treatment'].values
    classifier.fit(x, y)

if __name__ == "__main__":
    main()

since tf.contrib.tensor_forest and tf.contrib.layers is going to be deprecated soon, i'm not sure whether we want to encourage people to use it.

thank you for reporting this ! can you try to do this instead?
...

since tf.contrib.tensor_forest and tf.contrib.layers is going to be deprecated soon, i'm not sure whether we want to encourage people to use it.

Thanks for the follow-up on this.  I understand the reluctance to devote resources to deprecated code.  I did manage to find another way to address the problem.  The TensorForestEstimator constructor provides an argument for specifying a feature engineering function.
    def make_feature_engineering_fn(self):

        def _feature_engineering_fn(features, label):

            # Encode features according to column definitions
            # https://www.tensorflow.org/versions/r1.12/api_docs/python/tf/contrib/layers/transform_features
            xformed_features = tflayers.transform_features(
               features,
               self.metadata.feature_columns
            )

            # Features that have been transformed will be keyed on the FeatureColumn object
            # rather than the name associated with the feature.
            # https://github.com/tensorflow/tensorflow/blob/v1.12.0/tensorflow/contrib/layers/python/layers/feature_column_ops.py#L822
            features = {
               k.name : xformed_features[k]
               for k in xformed_features
            }

            if label is None:
                return features, None
            else:
                return features, self._parse_label_column(label)

        return _feature_engineering_fn

    def _parse_label_column(self, label_string_tensor):
        """Parses a string tensor into the label tensor.

        Args:
          label_string_tensor: Tensor of dtype string. Result of parsing the CSV
            column specified by LABEL_COLUMN.

        Returns:
          A Tensor of the same shape as label_string_tensor, should return
          an int64 Tensor representing the label index for classification tasks,
          and a float32 Tensor representing the value for a regression task.
        """

        label_props = self.metadata.column_props[self.metadata.label_key]
        if label_props['tf_dtype'] == tf.string:
            # Build a Hash Table inside the graph
            # https://www.tensorflow.org/versions/r1.12/api_docs/python/tf/contrib/lookup/index_table_from_tensor
            table = tf.contrib.lookup.index_table_from_tensor(
                # https://www.tensorflow.org/versions/r1.12/api_docs/python/tf/constant
                tf.constant(label_props['unique_values'])
            )

            # Use the hash table to convert string labels to ints and one-hot encode
            tf.logging.info('label_string_tensor: {0}'.format(label_string_tensor))
            return table.lookup(label_string_tensor)
        else:
            return label_string_tensor

where self.metadata.feature_columns is a Python list with instances from tf.contrib.layers.feature_column module.

@pjhinton,

Thanks for the follow-up on this. I understand the reluctance to devote resources to deprecated code. I did manage to find another way to address the problem. The TensorForestEstimator constructor provides an argument for specifying a feature engineering function.

Looks like issue is resolved. Can we move this to closure!


Figure out the possible consequences of skipping untilBuild completely

Skipping untilBuild would be useful since we won't need to make a release that just updates untilBuild every three-four months f o r e v e r...
But! what if we skip untilBuild completely, and then a new quarterly release comes out and breaks binary compatibility for us? :thinking:
Will Marketplace allow the users for downloading a plugin that does NOT pass their binary compatibility checks?

See https://youtrack.jetbrains.com/issue/IJSDK-888; possibly opening an issue against https://github.com/JetBrains/intellij-plugin-verifier is a good idea as well

Ok, received an answer on YouTrack:
Currently, plugin repository does not take information from compatibility checks for marking/making unavailable incompatible plugins to users. Please watch IDEA-195802 for progress on that feature.

Effectively, omitting until-build in your plugin puts risks in developers hands as newer IDE versions could become incompatible. Existing incompatible releases can be marked later with "proper" until-build manually on plugin repository if required.

What this means for us is that we cannot skip untilBuild and yes, we do need to make a separate release with every following IDEA release.
The most reasonable approach to avoid a "downtime" (when the users already have a new IDE version X but our plugin doesn't work since it hasn't been released for X yet, only X - 1) is to extend untilBuild to X.* when a X EAP or X RC is ready. Once X is released, we should verify ASAP that our plugin is also compatible with X. There's generally rather little chance that a plugin compatible with X EAP (let alone with X RC) and does NOT use any EAP-specific features (i.e. is also compatible with X - 1) will NOT be compatible with X itself.

@micpiotrowski pls add the above conclusions to the release docs on #452
Also, see https://youtrack.jetbrains.com/issue/IJSDK-701

Already done

Closing the issue: the conclusion is NO, we can't skip untilBuild at all; the only action was to add the adequate docs

Note: the answer might change in the future, but this hinges on development from JetBrains' side


No support for primitive array

Mentioned in #190 , there is no primitive array decorator in https://github.com/goldcaddy77/warthog/tree/master/src/decorators.
Now if i use the normal typeorm + type-graphql way i.e.
@Column({type: 'text', array: true, nullable: true })
@Field(() => [String], {nullable: true})
decorations?: string[]

it will obviously not work because they do not have the meta and will get parsed into string, causing type error

Good catch.  How would you expect this to work?

Sorting: likely doesn't make sense
Filtering: what operators should be supported?  Perhaps just contains?

Do you know if TypeORM/Postgres have the operators to cleanly filter in array columns?

Yes that is what I was concerned too because will need to generate a raw query for each kind of database.
Before i tried warthog, I set array field in models like
@Field(type => [String], { nullable: true })
@Column({ type: 'text', array: true, nullable: true })
hobbies?: string[];

and then use filter like
      usersQuery = usersQuery.andWhere(
        'users.hobbies && ARRAY[:...hobbies]::text[]',
        { hobbies }
      );

I think will need to generate raw queries like this?

To make this work with how I'm currently doing things in Warthog we'll likely need to make use of the Raw operator here:
https://github.com/typeorm/typeorm/blob/master/docs/find-options.md
...and have it map to Postgres`s array search operator:
select * from people where aliases @> '{"Prince Harry"}';

See: https://www.fulcrumapp.com/blog/tips-postgresql-arrays/

Will see if I have time for to create a PR :)

@BenBrostoff should be easier now that I’ve refactored the codegen pipeline. Will touched a lot of different spots, through. Lemme know if you gets need this.

@BenBrostoff do you guys still need this?

Actually no for me now since array is not performant for querying 🤔

@goldcaddy77 I think we should be fine for now 👍


READY : Extend tests

Module has problems with namespaces.
This ugly code demonstrates the problem, not solution
https://github.com/dmvict/wTestVisual/commit/9b8c7de157ef46a4c6475d47dec3272a40ed192e


New version: hoppscotch.Hoppscotch version 24.6.0-3

Pull request has been created with WinGet Updater :rocket:
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

/azp run


Deploy to base network

I deployed all contracts to base.
They are also verified at https://basescan.org
The base branch of this PR is release/1.2.x, but I guess a correct one should be release/1.3.x.
Not sure what is your process to do that.
I also did not add a changeset or changed any versioning file yet.

Not sure why test broke. Do you have any idea?

It's a problem with proof generation system. We've fixed it on main. Let me fix that real quick on this branch.

How are you handling changesets for a 1.x?
Do you want to create a realease/1.3.x branch and change the base branch to it?

Changed base branch to release/1.3.x

How are you handling changesets for a 1.x?

There are CI jobs ready to trigger for main, release/* and prerelease/* branches.
The CHANGELOG file will naturally get out-of-sync, but GitHub Releases will list all.

What I'm not understanding is that the release/1.x branches do not have changesets installed or the .changeset folder.

From what I've checked, release/1.1.x doesn't have changesets, but release/1.2.x (and now, release/1.3.x) do. You can find the .changesets folder at onchain/rollups. These also have the CI set up for releasing packages with changeset publish.


Update TypedArray builtins to latest standard

JerryScript-DCO-1.0-Signed-off-by: Bela Toth<EMAIL_ADDRESS>

The two newly added tests are timeout fails, raising testrunner timeout to 10 will passes them on my end.

The two newly added tests are timeout fails, raising testrunner timeout to 10 will passes them on my end.
built-ins/decodeURI/S<IP_ADDRESS>_A2.5_T1.js and built-ins/decodeURIComponent/S<IP_ADDRESS>_A2.5_T1.js are
known very slow tests, they can be timeout on slow machines, but pass always on the CI.

Just simply remove them from the excludelist. ;)

Note: #4287 adds ToIndex abstract operation which should be used by

https://www.ecma-international.org/ecma-262/11.0/#sec-typedarray-length
https://www.ecma-international.org/ecma-262/11.0/#sec-typedarray-buffer-byteoffset-length

(That patch is landed)


[Feat]:  Twitter bot

Is your feature request related to a problem? Please describe.
This script interacts with the Twitter API to automate actions on Twitter. It can be programmed to post tweets, like or retweet specific tweets, follow or unfollow users based on certain criteria, or even analyze sentiments of tweets.
Describe the solution you'd like.
adding the scripts required for making twitter bot
Describe alternatives you've considered.
no
Show us the magic with screenshots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Go Ahead @Abhinavcode13


Strawman roadmap

LSP supports many interesting use cases. I'm going to list a few that are within reach:

document formatting

supporting scalafmt via LSP should be easy. I've essentially done a more complicated version of this in vscode-scalafmt, and if we have a JVM server this is much easier.

linting

sending the results of scalafix linting rules is easy (they're called diagnostics in LSP lingo). We are already working on a POC in #1

symbols (listing, renaming)

the LSP supports workspace/symbol requests to list all the symbols in the workspace matching a query string
also it supports textDocument/documentSymbol to list all the symbols in a document
finally it supports textDocument/rename for renaming a symbol in the workspace (this could be cool, and potentially achievable with Scalafix)

go to definition

the textDocument/definition is for jumping to the definition of a symbol (this has been done already in metadoc)

autocomplection

this is way harder, obviously, but I would like to have a discussion on how the presentation compiler can play together with Scalameta in this area

A reference to the full spec of LSP is here: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md

To me, autocompletion, textDocument/definition and textDocument/rename are the killer features. I'm glad you're working on this @gabro, I think a hybrid of the presentation compiler and semanticdb can be a very interesting avenue to explore to provide people with better tooling.

I agree @jvican! Those would finally give any editor a great Scala experience without the burden of a full-fledged IDE.
definition and rename are definitely within reach using scalameta and scalafix respectively.
For autocompletion, I've zero experience on how the presentation compiler works, but I hope that will change soon :D

Hi! I just discovered this project and I'm really glad that it already exists! 👏  I was thinking how to use scalameta for creating a Scala language server, but I don't know almost anything about it and it would take me a lot of time to start and make anything working..
Here are some other LSP requests that, I think, could be in reach of SemanticAPI:

textDocument/hover to show type information on hover
textDocument/signatureHelp to show method/constructor signature when filling its parameters
textDocument/references to find project-wide references for the given symbol. I guess, once you have workspace/symbol, it should be easy.
textDocument/documentHighlight similar to references, but local to the document (docs also say it's more "fuzzy")
textDocument/codeAction to apply scalafixes?

The code action request is sent from the client to the server to compute commands for a given text document and range. These commands are typically code fixes to either fix problems or to beautify/refactor code.

Those are really good suggestions @laughedelic! We've just got the ball rolling and it's very promising. We'll see where this take us :)

autocomplection - I have seen IDEs help complect code before but I'm not sure it's a feature we should enable.

@ShaneDelmore you mean snippets?

I was just being silly.  To be more helpful, regarding the original bullet point:
/s/autocomplection/autocompletion

I think the roadmap we have in the README is comprehensive enough. Closing.


ppci-cc: x86 backend fails when converting float/double <=> char/short

double d;
short s;
char c;
d = c;
d = s;
c = d;
s = d;
The x86 backend fails to generate any of the 4 above expressions.
It also fails with "unsigned char" and "unsigned short" (but it works for int, unsigned int, long, unsigned long)
It also fails if "double" is replaced by "float"
All these expressions request the backend to implement templates such as:
I8TOF64, I16TOF64, F64TOI8, F64TOI16 which do not exist in current version.
For expressions converting char/short to double, it could be handy to do an implicit integer promotion and then rely to the existing I32TOF64 or U32TOF64 templates.
Same for "float" which could be promoted to double before being converted.

This is a fair point. I have given this some thought, and requiring the backend to implement all combinations, might be practical. An idea would be to create extra patterns in the instruction selector to use existing conversions like you suggested. If a backend implements a direct conversion, this would take precedence when it has a lower cost.


design export image with preview + select zone control

the export dialog needs to allow the user to control the zone is going to be exported

The selection should be user friendly, so that user can select, by mouse the following aspects of the image being exported
(1) the size of the image,
(2) zoom
(3) center the image to a desired point
This could be a part of the export dialog or some selection right from the main map and the export dialog can preview this image.

Following @saleiva's template I made this one with:
Proportions lock to proportionally increase screenshot size
Possibility to increase size draggin horizontally when click over the w (width) or h (height) (see 2nd design):

I miss a cancel button (I guess escape will do the thing).
@xavijam I don't know if there will be problems in safari with pointer-events

I don't think so http://caniuse.com/#search=pointer-events.

I agree with javisantana on the cancel button, we will need it.

v2:

The "back" button will work as a cancel button.

Available in map-editor-1.5.sketch
cc/ @javisantana

How does user cancel and go back to the regular mode?

Right now pressing the esc key will close the selection tool and go back to the regular mode, but I agree we should add a close button somewhere.

Cancel button:

(in the same file: take-image-04.sketch)

from @vishalya
(1) For the image selection, would you be able to change the UI so that, we have a 'X' image at the right top corner, like the windows dialog, which would server as a cancel operation.
(2) The Cancel button can be moved to the bottom next to the export button.

This will look more in line (consitent) with the a regular dialog for the users.

cc @josecruz @saleiva

Thanks for the feedback @vishalya!
We've updated it with the element we use on the new modals:

Let me get some more feedback from the users here, so let's not close this one.
In general, we always have 'cancel' buttons along side the 'Export' or 'OK' buttons, so please wait till I demo it to all the stake holders.

@vishalya do you have that feedback?

This can be closed.


Can't not export an interface

Given a normal interface:
interface IMyInterface {
  doSomething(): string;
};

export default IMyInterface;

I'm getting:
[flow] IMyInterface (type referenced from value position type IMyInterface)
Expected result
Should be able to export the interface, so I can use it in different places (e.g. test and production code)

@Hosar Did you try to use named export and how do you import this interface?

@TrySound export default is not working for interfaces or type aliases.

I guess the problem here is es modules compatibility. Default is value, not live binding (getter), so semantically better prevent using types as values.

it works if I use only export, instead of export default

@Hosar Yep. That's what we are talking about.

This probably can be closed.
/cc @vkurchatkin