Rework mailer settings

Since the require changes for the proposal are small, I figured I would just write the code and offer it, in case less discussion is needed. It's partially me verifying my claim that the proposal wouldn't result in that many code changes, so, I don't mind if I have to rewrite it to account for changes to the proposal. Higher level discussion of the proposal can be found in #18901.
Docs notes:

I can help rewrite the English versions of the relevant pages on the website docs depending on the status of the proposal, since they'd need to be modified to use the new settings.

Breaking changes:

If you specify credentials for sending emails but the server doesn't support using them, Gitea will fail to start instead of sending mails unauthenticated.
The combined mailer.HOST option has been deprecated, in favor of the new mailer.SMTP_ADDR and mailer.SMTP_PORT options.
The mailer.IS_TLS_ENABLED option has been deprecated in favor of using the new mailer.PROTOCOL option, which accepts smtp, smtps, smtp+startls, or smtp+unix explicitly. If you don't know what protocol your provider uses, you can leave it blank and it will be inferred by the given port. See the non-breaking changes section for more details on the new smtp+unix protocol.
The mailer.DISABLE_HELO (default false) option has been replaced with mailer.ENABLE_HELO (default true). It still does the same thing, but the option was negated to be less confusing.
The mailer.SKIP_VERIFY option has been replaced with mailer.FORCE_TRUST_SERVER_CERT to sound scarier, and to clarify what it does.
The mailer.USE_CERTIFICATE, mailer.CERT_FILE, and mailer.KEY_FILE have been deprecated and renamed to mailer.USE_CLIENT_CERT, mailer.CLIENT_CERT_FILE, and mailer.CLIENT_KEY_FILE.
The gitea admin auth add/update-smtp command now accepts an --addr option instead of --host.

Non-breaking changes:

This will log a warning if you choose to use mailer.PROTOCOL = smtp+startls but the server does not support it. It will also log a warning if you use smtp on a non-local address, with "local" being either localhost, <IP_ADDRESS>, or ::1; you should use smtps or smtp+startls instead.
mailer.PROTOCOL = smtp+unix is now supported, as an alternative to mailer.PROTOCOL = smtp on a local port. This is done by providing a file path to SMTP_ADDR, which will be the location of the socket to use. If you don't set the PROTOCOL variable but the SMTP_ADDR variable has slashes in it, the protocol will be assumed to be smtp+unix.
The installation page now asks for separate address and port options for SMTP, instead of one host option. (TODO: Take a screenshot of what this looks like.)

Fix #18901.

I noticed that the code for deprecated settings doesn't actually emit any warnings if you set both options in the config, and most code just blatantly overwrites the new setting with the old values if present; is this intentional? Should I be doing checks for these?

People should be made aware of setting changes, such they will hopefully read the documentation as it could be the case that the behavior of one of those options might change.

This completely removes the old config options from the example config file; I'm assuming this is what's desired, instead of including both. However, I can add back in both if that's preferred.

Yes the example config file is assumed to be copy-paste ready(with just changing the values).

This will now log a fatal error if credentials are provided but the server doesn't support auth; the old behaviour would simply proceed without authenticating.
This will log a warning if you choose to use StartTLS but the server does not support it. It will also log a warning if you use SMTP-over-TCP without TLS on a non-local address, with "local" being either localhost, <IP_ADDRESS>, or ::1.

Seems like a good change, did the old code not even warn about it?

SMTP-over-Unix is now supported, as an alternative to SMTP-over-TCP on a local port. The protocol will be assumed to be smtp+unix if the address has slashes in it, which I figure is probably an okay heuristic.

Because of this, It's hard to label this PR, as it it's a refactor + new feature. It could be that this should be splitted into a new PR.
Is there a manual overwrite for this heuristic?

Don't forget to run make fmt ;)

Because of this, It's hard to label this PR, as it it's a refactor + new feature. It could be that this should be splitted into a new PR.

If you'd prefer that, I'd be more than happy to split it. Not 100% sure how you'd want to handle that, though.

Is there a manual overwrite for this heuristic?

Yes; the heuristic is only if the protocol is unspecified. If it's unspecified, it first tries to infer, and if that fails it gives a fatal error.

If you'd prefer that, I'd be more than happy to split it. Not 100% sure how you'd want to handle that, though.

Not needed for now.

Been on/off adding fixes to the build, main barrier is updating the SMTP auth source since that also is coupled to this code. Not currently in a big rush since I figure there would still need to be discussion about the changes themselves (outside the code)

CI hasn't completed yet, but the preliminary tests have passed and I believe that everything should be ready now.
I updated the PR description to fully break down what this PR does, and deleted the questions that were already answered in previous comments.
The one big thing besides what's done here would be updating the docs for configuring emails on the website, but I believe that will require a separate PR.

Update: the CI seems to pass for everything but testing-arm64/test-pgsql, which looks spurious since this doesn't touch any code that should affect that. I think that things are ready to review.

Responding to your comments all at once @lunny to avoid spam: these seem to contradict what @Gusted said in this comment; I'm fine with changing the code if needed, but want to see which approach is explicitly preferred. What I'm doing now seems to be what other deprecated settings are doing.

@Gusted @clarfonthey @lunny I made some fixes to this PR. Please help to review whether these changes are correct.
Most problems have been resolved.

Change deprecated comments to "be removed in v1.19.0"
Only use deprecated key if the new key doesn't exist
Documents are updated, and tell users to visit old documents if they are using an old Gitea
Deprecated the MAILER_TYPE option, now use the unique PROTOCOL
Fix SMTP config fields in installation page

If no more necessary changes, I think this PR can be merged soon, and test it during 1.18-dev lifecycle, and fix problems in the first time.

Thank you for fixing this up! The changes look good to me, so, we should be good to merge with another approval.

I'll clean up the docs and add more explicit update notices.

I'm not sure if this is a bug in the LGTM bot, but it looks like it's still waiting for approval even though it seems to be lgtm/done?

I'm not sure if this is a bug in the LGTM bot, but it looks like it's still waiting for approval even though it seems to be lgtm/done?

Yes, botbug

Codecov Report

Merging #18982 (48d7743) into main (335e918) will decrease coverage by 0.02%.
The diff coverage is 33.76%.

@@            Coverage Diff             @@
##             main   #18982      +/-   ##
==========================================
- Coverage   46.82%   46.80%   -0.03%
==========================================
  Files         979      979
  Lines      135831   135920      +89
==========================================
+ Hits        63606    63620      +14
- Misses      64415    64486      +71
- Partials     7810     7814       +4

Impacted Files
Coverage Δ

cmd/admin.go
0.00% <0.00%> (ø)

routers/install/install.go
1.76% <0.00%> (-0.01%)
:arrow_down:

routers/web/admin/auths.go
46.35% <0.00%> (ø)

services/auth/source/smtp/auth.go
0.00% <0.00%> (ø)

services/auth/source/smtp/source.go
14.28% <ø> (ø)

services/auth/source/smtp/source_authenticate.go
0.00% <0.00%> (ø)

services/forms/auth_form.go
100.00% <ø> (ø)

services/forms/user_form.go
45.36% <ø> (ø)

services/mailer/mailer.go
29.50% <18.51%> (+1.33%)
:arrow_up:

modules/setting/mailer.go
39.28% <36.84%> (-11.29%)
:arrow_down:

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

these changes left MailerType hanging in templates/admin/config.tmpl, which gives me a 500...

Not sure if the two are connected but I used to both see Gitea's 500 on server error and had mailer configured properly, so I don't know but it looks like they might be (connected).
Note that I just updated to this commit (changed app.ini as per the new docs, of course) from already a pretty recent version (three days old?), so it's not like I haven't updated Gitea in a while...
ping me if you need more context/feedback..

Thank you for the test, I will fix it.

Thank you for the test, I will fix it.

cheers!
as to how I found out about the issue: I wanted to send a "test email" from the admin page to make sure the new settings work..and it blew up in my face :(
I should still be able to send a "test email" using the cli, right? so I can still validate the settings..

The fix:

#20633

Thank you both for fixing the issue so quickly! Sorry I didn't test the change thoroughly enough when writing it.

Hmm, one more bug.
The changing of auth/smtp/Source.Host is incorrect. https://github.com/go-gitea/gitea/pull/18982/commits/d60c43869420f5fc43ad19b454c9ae50dad65964
It should be reverted. It's not related to the SMTP config, it's just for the Auth Source.


Navbar misbehaving in a6

Issue description

version #4.2.0
components: Navbar

Steps to reproduce issue
Followed installation instructions from reactstrap README.md

Navbar is misbehaving - after reading the blog post about alpha6 I tried alpha5 and I got myself a working Navbar.
https://blog.getbootstrap.com/2017/01/06/bootstrap-4-alpha-6/
ps. great project - I think i'll stick around for this one.

Working as expected after studying propTypes.


Allow Zk storage to finalize

This PR is marked as a draft because of some open design questions. Currently, the APIs are brittle and very sensitive to the ordering of different calls. For example, each of these three calls has a differen result!
// This version is correct
jmt_storage.get_first_reads();
jmt_storage.finalize();
jmt_storage.take_treedb_log();

// This version returns an empty FirstReads
jmt_storage.finalize();
jmt_storage.get_first_reads();
jmt_storage.take_treedb_log();

// This version panics
jmt_storage.take_treedb_log();
jmt_storage.finalize();
jmt_storage.get_first_reads();

I've opened this as a draft anyway for a few reasons:

We can use it temporarily to set up a demo for tomorrow, even though we probably won't merge the current design
I hope that it sparks a useful discussion about how to set up host->guest interaction

Some thoughts, maybe we could use type state patter to ensure the correct ordering of operations:
https://rustype.github.io/notes/notes/rust-typestate-series/rust-typestate-part-1.html


VSCode cannot resolve Nuxt Auto Imports in a new/renamed file

In my current vscode setup, Nuxt and vue typescript is working fine. But when I rename or create a file, the type and resolution wont work on that new file only. Any ideas?
Project/Folder Setup, it is under a workspace:
/app-backend
/app-frontend
/app-frontend/tsconfig.json # This refs /app-frontend/.nuxt/tsconfig.json

I found that in the existing file, tsconfig is found:

But in a new file, no tsconfig is found:

For example, let's say I have a composable named useABC
VSCode can auto-suggest this when I type useAB only on an existing file.
AutoImport is working on an existing file:

After renaming, the resolution becomes different:

After restarting the entire VSCode, it will work again. Since now the vue restart command is removed (https://github.com/vuejs/language-tools/issues/4164), only restarting VSCode can resolve the issue.

You can execute the "Reload Window" command. No need to restart VSCode. I have the same problem in a conventional Vue3 project, without nuxt, in 2.0.7.

This problem should be fixed in the master branch, here are the relevant commits:

https://github.com/volarjs/volar.js/commit/6d7a54218a545553e55f27255878accb0c1b731e
https://github.com/volarjs/volar.js/commit/17d1fa2f4086025ca14dd5a1e773eb3da36261f5
https://github.com/volarjs/volar.js/commit/baf5a99d15b8e14cf638bef8217bcccf0d4cfee5

We need to wait for VSCode 1.88 to be released before we can update the extension. You can use 1.8.27 for now.

The restart command was re-add by #4174.


Dynamic Programming: Given two strings word1 and word2, return the minimum number of operations required to convert word1 to word2 in Python

You have the following three operations permitted on a word:

Insert a character
Delete a character
Replace a character

https://leetcode.com/problems/edit-distance/

I would like to take this up!


Unread notification does not clean up even after reading them

This means I have 1 unread notification:

which is normal, and when I read the notification and the 1 disappears. However, when I refresh the page, the 1 is shown again, which should not happen at all.

@Voileexperiments already asked #1454

The other is already closed.

This happens every time without fail; I think it popped up ~2-3 months ago.


Keep percent sign on zero values in transform-origin

I came across an issue that the percent sign on zero percent values are removed in order to minify the css.
Sass: transform-origin: 0% 0%
after cssnano: transform-origin: 0 0
This resulted for me in a problem when using 'transform-origin' on an element in the recent Google Chrome browser (version 51.0.2704.106 m, up to 54.0.2787.0 canary). Probably the Chrome distinguishes between the number 0 and 0 percent. However, I wasn't able to fix this by passing an option to cssnano. Neither 'reducePositions' nor 'reduceTransforms', both set to false, worked out.
After some time of try and error I have came around with this workaround to keep the percent sign:
transform-origin: calc(0%) calc(0%)
It would be nice to have a passable option which handles this.

Do you have something that can reproduce this breakage? Is it related to this issue? https://github.com/ben-eb/postcss-reduce-transforms/issues/2

It is somehow related to that issue but with a different css attribute, here 'transform-origin'.
I have set up a jsFiddle to show this behaviour: https://jsfiddle.net/oliverschwarzpdm/8s5h4ppb/2/
The first line is behaving as supposed with transform-origin: 0% 0% and the other one is behaving oddly with transform-origin: 0 0. Both lines should have that one transform-origin.

@oliverschwarzpdm This is not a bug in cssnano, this is a bug in browsers. Using transform-origin on a SVG element with percentage value will break in some browsers.
See: https://css-tricks.com/svg-animation-on-css-transforms/#article-header-id-0

@marcobiedermann I agree with you that is a bug in browsers. It would be nice then that cssnano won't strip off the percent sign on these values, don't you think?

@oliverschwarzpdm

I agree with you that is a bug in browsers.

In my opinion I would not add an option to cssnano for this special case (bug).
Browsers which do work correctly should benefit from this compressor / minifyer, instead of supporting broken features.

@marcobiedermann Thanks for your response! I would agree that it is not our responsibility to mitigate cross-browser issues, which sometimes can be a nice side-effect of minification but it is not my goal with this module.
Because the behaviour is different for each browser—Firefox can't handle percentage values, Chrome can't handle unit-less zero values, IE doesn't render the animation at all—there is no sense in providing this support here.


Test login register

Implement Unit tests and Integration tests including UI tests related to login and register

Implement Unit tests and Integration tests including UI tests related to login and register


Pull request for easier build and support maple mini

Hi, I cloned the repo locally and did slight modifications on the device config  to enable some more features :

use platformio and vscode to automate build without all pre-install requirements ( basically create a platformio.ini file and vscode plugin takes care of the rest )
support maple mini with auto-enumeration ( adapt pin's in device config )
https://stm32duinoforum.com/forum/wiki_subdomain/index_title_Maple_Mini.html
debug via vscode and platformio ( adapt launch.json for .vscode )
However I have no experience in how to create a pull request or I don't have enough access to push a proposal branch.
How do I proceed to push this code ?
Regards
Lieven

Hi,
please send me the link to your branch with these modification. Is it available on GitHub?
Best,
Kirill.

Hi,
the branch can be found here : https://github.com/vortex314/bluepill-serial-monster
Regards
Lieven

@vortex314 while the overall idea of adding maple support seems reasonable, I have a number of questions regarding the implementation:

.vscode/c_cpp_properties.json is an autogenerated files, there is no need to include it into the source tree;
.vscode/launch.json contains absolute paths specific to your development environment, it cannot be included into the source tree;
device_config.c was heavily modified and coding style was significantly changed. It is hard to maple-support related changes hidden in coding style changes. Anyway, if you want to add anything into the code, you should follow my coding style, not enforce yours;
Same applies to usb_io.c, however I don't see any non formatting changes there at all;

In the device_config.c the commend  /*  pin is occupied by USB      */  is wrong. PIN is occupied by the LED. Even if the PIN is occupied by LED, we should thing about remapping it (are there free PINs), not disabling. Also I don't see a single word about Maple in README.
At this point your branch cannot be merged.
Question: what exactly should be changed for maple support? Is it only about the LED pin?

Hi Kyrill, thanks for the detailed review, I admire the project you dis so far, some answers :
Overall I used the platformio setup as it is much more convenient to get all pre-requisites than the steps described in the README. Also from my own experience I know the USB renumeration on a bluepill is unpredicatble, I had better results with maple boards.

.vscode/c_cpp_properties.json is an autogenerated file, there is no need to include it into the source tree; ==> I've included this so the code view doesn't deplay errors in visual code of not finding files. Could be indeed that in a proper auto-generation it's not  needed

.vscode/launch.json contains absolute paths specific to your development environment, it cannot be included into the source tree; ==> I added this because it needs very specific option to be able to debug the code, not auto-generated

device_config.c was heavily modified and coding style was significantly changed. It is hard to see maple-support related changes hidden in coding style changes. Anyway, if you want to add anything into the code, you should follow my coding style, not enforce yours; ==> the coding style is enforced by the IDE. The maple dependencies can be found under the

#ifdef MAPLE
#else
#endif

Same applies to usb_io.c, however I don't see any non-formatting related changes there at all;
In the device_config.c the comment /* pin is occupied by USB */ is wrong. PIN is occupied by the LED. Even if the PIN is occupied by the LED, we should think about remapping it (are there free PINs), not disabling. Also I don't see a single word about Maple in README.
==> I didn't adapt the README yet as I was not able to make a pull request.
At this point your branch cannot be merged.
Question: what exactly should be changed for maple support? Is it only about the LED pin?
==> It's about the LED PIN but also the hidden pin in the usb_io.c code to drive the USB reset
#ifdef MAPLE
    GPIOB->CRH &= ~GPIO_CRH_CNF9;
    GPIOB->CRH |= GPIO_CRH_MODE9_1;
#else
    GPIOA->CRH &= ~GPIO_CRH_CNF12;
    GPIOA->CRH |= GPIO_CRH_MODE12_1;
#endif
    for (int i = 0; i < 0xFFFF; i++)
    {
        __NOP();
    }
#ifdef MAPLE
    GPIOB->CRH &= ~GPIO_CRH_CNF9;
    GPIOB->CRH |= GPIO_CRH_MODE9_1;
#else
    GPIOA->CRH &= ~GPIO_CRH_CNF12;
    GPIOA->CRH |= GPIO_CRH_MODE12_1;
#endif

Hope this helps, Lieven

I tried not to configure the txa pin for UART2 , however it needs one as otherwise it crashes in
__attribute__((always_inline)) inline static void usb_cdc_usart_irq_handler(int port, USART_TypeDef * usart,
    volatile uint32_t *txa_bitband_clear) {
    uint32_t wait_rxne = 0;
    uint32_t status = usart->SR;
    if (status & USART_SR_TC) {
        *txa_bitband_clear = 1;  // ==> memory fault
        usart->CR1 &= ~(USART_CR1_TCIE);
    }

As the code & doc  in my repo https://github.com/vortex314/maple-serial-monster is incomplete for all cases,forget about the pull request.
Regards


ODC-6778: Add console developer catalog customization

Story:
https://issues.redhat.com/browse/ODC-6778
Add dev catalog types customization API based on https://github.com/openshift/enhancements/pull/1206

/assign @jerolimov

/cc @lokanandaprabhu

/test verify

/test verify

/retitle ODC-6778: Add console developer catalog customization

/cc JoelSpeed
/assign JoelSpeed

Have you done any manual testing of the API to check that when you don't set the developer console new config, that it doesn't complain about a required field? Just want to check the validations here

@JoelSpeed This is what I have tested
https://user-images.githubusercontent.com/22490998/191085477-7acc8daa-f3ba-4d7b-ad31-edd66cb67b80.mov

Thanks for the video, are you happy to wait for the rebase to 1.25 to land before you merge this? I think it should happen this week. Once 1.25 is merged we can test this properly
The alternative is to build off of #1298 and add some tests for this project based on what we are doing there (eg #1297 for CPMS), that could help prove the validations

Tested this API via https://github.com/openshift/console-operator/pull/676 on a cluster bot.
Could verify that all the API change works fine.
/label qe-approved
/lgtm

Propagate from the ODC Epic:
/label px-approved
/label docs-approved

/assign @deads2k

I'm happy with this API and that testing will follow up once the 1.25 rebase has landed, deferring to @deads2k for final approval

verify passed so I'll assume the change in rolebindingrestrictions was correct.
/approve

/hold
I disagree, I don't think the served and storage versions can be removed, pretty sure if we try to install that CRD into a cluster it will not allow the CRD to be created

Yep, just tried to add an integration test for this and the API returned errors trying to install the CRD
                              {
                                  Type: "FieldValueInvalid",
                                  Message: "Invalid value: []apiextensions.CustomResourceDefinitionVersion{apiextensions.CustomResourceDefinitionVersion{Name:\"v1\", Served:false, Storage:false, Deprecated:false, DeprecationWarning:(*string)(nil), Schema:(*apiextensions.CustomResourceValidation)(nil), Subresources:(*apiextensions.CustomResourceSubresources)(nil), AdditionalPrinterColumns:[]apiextensions.CustomResourceColumnDefinition(nil)}}: must have exactly one version marked as storage version",
                                  Field: "spec.versions",
                              },
                              {
                                  Type: "FieldValueInvalid",
                                  Message: "Invalid value: []string(nil): must have at least one stored version",
                                  Field: ...

This commit can help demonstrate that the CRD change here is invalid, if you pull this branch (based on this PR) and from the root of the API repo run make -C authorization/v1 test it will error right now

I disagree, I don't think the served and storage versions can be removed, pretty sure if we try to install that CRD into a cluster it will not allow the CRD to be created

Thanks for finding and blocking this. It's fixed now. As this was the last blocker we can continue with this. We still can add some tests when your testing framework is ready.
/unhold
/lgtm


Fix misspelling in enum member

I noticed that MessageButtons's OkCancel was misspelled as OkCancle. This is still very much <1.0.0 so maybe this breaking change is fine.

Oh god, that's quite embarrassing mistake :smile:
Thank you!
API stability is not there yet so it's fine to change it right away.


Send dbt model and column descriptions to Databricks as table and column comments

Describe the feature
Send dbt model and column descriptions to Databricks as table and column comments. Models created through dbt are naturally documented through dbt. Getting that documentation to Databricks as comments is non-trivial. Having table comments with column comments in Databricks automatically generated through dbt would enrich the Databricks Data UI for both data producers and consumers. As both dbt docs and Databricks comments support markdown, they should be compatible with each other.
In case this is not desirable for everyone, it could be implemented for example as a flag, either on dbt project level or as a dbt model config, or as an on-run-end operation.
Who will this benefit?
I think this could be a great addition to teams using Databricks with dbt, especially those using Unity Catalog. This would be great for engineers to have documentation available in the Databricks UI, and particularily for data consumers that could find data documentation in the same place as they consume data.

SmartTenkt @mreistadvipps!
Would be a nice function when the project mature and we're ready for smart integrations! 👏

Hi @mreistadvipps, thanks for raising the issue.
I guess this is a duplicate of #247.
Have you tried persist_docs?

Hi @mreistadvipps, thanks for raising the issue.
I guess this is a duplicate of #247.
Have you tried persist_docs?

Thank you @ueshin, I didn't know about that config. That solves it for me. Closing the issue.


Feature Request: setSelfCollisionBehavior()

We can already set thresholds for joint/cartesian collisions via the setCollisionBehavior() function.
Could you please also provide a method to modify the thresholds for self-collisions?
Thanks

The setCollisionBehavior() function let's the user set force and torque thresholds to detect contacts and collisions. Self-collisions on the other hand happen when the geometry of the robot intersects with itself (i.e. one part of the robot gets too close to another part of the robot). What thresholds do you want to set for self-collisions?

Hi @ndehio
as @Stakkay mentioned, setting thresholds for self-collisions (aka the robot hits itself), is more like a thing of 'please don't do'. Hence, the collision volumes are chosen to prevent any self-harm (and not configurable).
Cheers,
Andreas


readme.md pip install command incorrect

Readme.md for azure-cosmosdb-table pip install command is incorrect, it is still listed as:
pip install azure-storage-table

Which no longer exists.
Should be:
pip install azure-cosmosdb-table

Please correct that!

Hi @aaron-schnieder . We have corrected it.

Closing this issue. Feel free to reopen it if you find anything else. Thanks!


Update sbt-github-actions to 0.11.0

Updates com.codecommit:sbt-github-actions from 0.10.1 to 0.11.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.codecommit", artifactId = "sbt-github-actions" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #209.


32-bit x86 CPUID code returns EBP instead of EBX

The inline assembly used by 32-bit x86 code needs to save and restore the EBX register because position independent code needs it unfortunately (https://ewontfix.com/18/). Since the CPUID instruction also uses the EBX register to return information, the inline assembly has to copy that data into another register (ESI in this case) before it restores the original EBX.
However, both the cpuid() and the cpuidex() functions contain a typo, and they return whatever is in the EBP register (essentially a random value) instead of EBX. This breaks run-time detection of AVX2 and newer CPU features.
The fix is very simple:
diff --git a/c/blake3_dispatch.c b/c/blake3_dispatch.c
index 7daf43e..b97b7c0 100644
--- a/c/blake3_dispatch.c
+++ b/c/blake3_dispatch.c
@@ -97,7 +97,7 @@ static void cpuid(uint32_t out[4], uint32_t id) {
   __cpuid((int *)out, id);
 #else
 #if defined(__i386__) || defined(_M_IX86)
-  __asm__ __volatile__("pushl %%ebx\ncpuid\nmovl %%ebp, %%esi\npopl %%ebx"
+  __asm__ __volatile__("pushl %%ebx\ncpuid\nmovl %%ebx, %%esi\npopl %%ebx"
                        : "=a"(out[0]), "=S"(out[1]), "=c"(out[2]), "=d"(out[3])
                        : "a"(id));
 #else
@@ -113,7 +113,7 @@ static void cpuidex(uint32_t out[4], uint32_t id, uint32_t sid) {
   __cpuidex((int *)out, id, sid);
 #else
 #if defined(__i386__) || defined(_M_IX86)
-  __asm__ __volatile__("pushl %%ebx\ncpuid\nmovl %%ebp, %%esi\npopl %%ebx"
+  __asm__ __volatile__("pushl %%ebx\ncpuid\nmovl %%ebx, %%esi\npopl %%ebx"
                        : "=a"(out[0]), "=S"(out[1]), "=c"(out[2]), "=d"(out[3])
                        : "a"(id), "c"(sid));
 #else

Nicely spotted!
The fix is a bit more involved that what you suggested; I used xchg instead of a push-pop sequence.


Fix fragment quirks mode, and make it easier to specify fragment context

What problem is this PR intended to solve?
Coming from the discussion at #3023, I wanted to improve the fragment parsing API

as discussed in #2646, parse in no-quirks mode if a context element name is provided (not a context Node, just the name)
allow passing :context kwarg to DocumentFragment.new and .parse
deprecate the positional options hash to .parse per notes at #3200

Have you included adequate test coverage?
Included additional coverage for the API changes
Does this change affect the behavior of either the C or the Java implementations?
HTML5 is only in CRuby.

This closed #3183


Fixing bug where JenkinsQueueJob task waits

even when the capture console checkbox is not checked
Bug #1017420

This is my proposed fix. I could not find any recent changes that were likely to introduce this bug.

Testing:

ran unit tests
Ran against various Canary jenkins jobs (like BuildCanary_Pipeline_Root)

with capture true and pipline true

with capture true and pipline false

with capture false and pipline false (false/true is not allowed)
All results were as expected.


[SignalR] [Java] Document minimum Android API levels

We should add the following notes to our Java Client documentation regarding compatibility:

The SignalR Java Client will run on Android API Level 16 and above.
Connecting through the Azure SignalR Service will require Android API Level 21 and above because the Azure SignalR Service requires TLS 1.2 and does not support SHA-1-based cipher suites. Android added support for SHA-256 (and above) cipher suites in API Level 20.

created pr: https://github.com/aspnet/Docs/pull/9342

@bradygaster 	no need to explicitly call out PR in the issue, it's added automagically when you refer in the PR.

Closing this issue as we have a PR open for it now in the Java client doc.

Hi, we were thinking of using SignalR with our android client application. But requirement is to use TLS1.2. Will it be possible to use it on android devices below API 20. Thanks.

It's my understanding that no, if you require TLS1.2 you must use Android API Level 20 or above. That's a general Android restriction, not specific to SignalR.

Hi, yes but we have to enable it on devices below 20, but i am not sure if it is available for the android sigalR  library

We don't test TLS 1.2 on Android applications below level 20. It may be possible to enable it, but we don't officially support it at this time.

Thanks, for your response.

I am not sure, about I was looking into the code and it is internally using OkHttp. If we could enable the TLSSocketFactory in the client builder. Maybe it will start supporting TLS1.2 on devices below API 20. Will update you as soon as found something.


Fullscreen Not Working on iOS

Browser: Chrome/Safari
OS: iOS 17
Clappr Version: 0.6.0 and 0.8.0
Fullscreen is not working on iOS devices.  Clicking the fullscreen icon does nothing.  It was happening in 0.6.0, and I just updated to 0.8.0 to see if that fixed the issue.  It did not.  Here's a demo config where the issue occurs..
http://clappr.io/demo/#dmFyIHBsYXllckVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGxheWVyLXdyYXBwZXIiKTsKCnZhciBwbGF5ZXIgPSBuZXcgQ2xhcHByLlBsYXllcih7CiAgc291cmNlOiAnaHR0cDovL2NsYXBwci5pby9oaWdobGluZS5tcDQnLAogIHBvc3RlcjogJ2h0dHA6Ly9jbGFwcHIuaW8vcG9zdGVyLnBuZycsCiAgbXV0ZTogdHJ1ZSwKICBoZWlnaHQ6IDM2MCwKICB3aWR0aDogNjQwLAogIHBsYXliYWNrOiB7CgkJCWNvbnRyb2xzOmZhbHNlLAoJCQlwbGF5SW5saW5lOiB0cnVlLAoJfQp9KTsKCnBsYXllci5hdHRhY2hUbyhwbGF5ZXJFbGVtZW50KTsK

Any update on this?  Looking to switch to Vidstack as it seems like development has slowed down here.  Vidstack has it's own issues though, especially with live streams.

Any update on this?  It's kind of a significant bug...

Is there any update or temporary workaround for this? I've temp switched to Vidstack because this is kind of a significant bug.  Seems to be an issue where Apple doesn't allow a non video element to be fullscreen on iOS devices.


MB-6044: db -> suite.DB()

Description
This lays the groundwork for an upcoming change that will add the ability for the testing suite to change the database connection used by Pop (pkg/testingsuite/pop_suite.go). Because the underlying database connection will be able to be changed at will, it will require a disconnect/reconnect. When this occurs, references to the old connection will no longer remain valid. Therefore, this PR removes references to database connections, and instead references the current database connection at the time of usage.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
$ go test -failfast ./pkg/notifications/...
ok      github.com/transcom/mymove/pkg/notifications    11.396s
$

Code Review Verification Steps

[ ] Request review from a member of a different team.

References

Jira story for this change

Messages

:book:
:link: MB-6044

  Generated by :no_entry_sign: dangerJS against 9f916e131fd0ecc8a7258c29a34e381a7a4884cc


chore: bdd-ghfjxy-import-1586229528 to 0.0.1

chore: Promote bdd-ghfjxy-import-1586229528 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


DBT + Bigquery : 404 Not found: Dataset hello-data-pipeline:staging_benjamin was not found in location EU

Describe the bug
When doing "DBT run" with this script
{{ config(materialized='table') }}

SELECT customer_id FROM `hello-data-pipeline.adwords.google_ads_campaign_stats`

I get the following error
15:41:51 | 2 of 3 START table model staging_benjamin.yo......................... [RUN]
15:41:51 | 2 of 3 ERROR creating table model staging_benjamin.yo................ [ERROR in
0.32s]
Runtime Error in model yo (models/yo.sql)
404 Not found: Dataset hello-data-pipeline:staging_benjamin was not found in location EU
(job ID: 4020ce42-ec44-438e-8ea0-9f4fe4adcc8c)

_NB. Bigquery does not show any error when doing this query in Bigquery Editor.
NB 2 DBT does not show any error when "running sql" command directly in the script editor
NB3 : No error when doing db run with example or with a public big query like this
{{ config(materialized='table') }}
SELECT *
FROM 'bigquery-public-data.stackoverflow.posts_questions'
ORDER BY view_count DESC
LIMIT 1

_
Steps To Reproduce

Create a bigquery project
Go to a bigquery table and click on "query table"
Take the Select and From Statement automatically generated
Create a DBT model and paste your code in your DBT model
DBT RUN

Expected behavior
It should DBT run without error..
System information
Which database are you using dbt with?
BIG QUERY
The operating system you're using:
DBT CLOUD
Others
Data imported from FIVETRAN

FYI when this happened to me I had to delete my dev dataset dbt_kmclaughlin in Big Query directly AFTER updating the location (in dbt cloud in my case). Only then did dbt run work.

In my case, the location of source dataset is EU , but destination dataset has to be europe-west1, dbt is giving me this error. Is it not possible to copy EU to europe-west1?

Having the same issue, did anyone else find a fix for this?
Beyond what this person said? Because this sounds pretty tedious for a lot of tables
Had the same issue and my fix was:
create the table manually in BigQuery, choosing the right region
delete the table
run dbt model that creates the table
Tada, it works automagically.


fix background scaling for large and small screens

application of background-size: cover to set background image to scale to size of screen.  applied as distinct rule so that inline background reapplication won't destroy.  (yay cascade)
before:
after:

Ugh, github's replacing the image links with its own, and they're failing.  Let's see if literals work.
before: http://imgur.com/ROrmxoc (imgur .com/ROrmxoc)
after: http://imgur.com/KnSx01F (imgur .com/KnSx01F)

Thanks for this fix! I didn't know there was a CSS property you could use to fix this. :)


typofixes - https://github.com/vlajos/misspell_fixer

Please note that this repository is unofficial and pull requests have no chances to be merged. Proper way to submit changes to nginx is via the nginx development mailing list, see http://nginx.org/en/docs/contributing_changes.html.


Status?

Is this abandonware? It looks like deprecation warnings are printed on the command-line when I use it now.

I think Cloudup itself is basically abandoned. I'd love to grab "up" in NPM for https://github.com/apex/up/issues/37 if possible, releasing a new semver major of course!

Not sure what you're trying to say here...

Cloudup itself is abandoned, no improvements in years, no monetization or anything, they just bought Cloudup for the team, so I'd like to use "up" on NPM since the project is defunct.

Okay. That's a big shame... "up" is not really something I consider a replacement.

Yea my thing isn't related at all, just a shame that NPM has one global namespace, but people could still install the old version if they still use cloudup instead of droplr/cloudapp/dropbox.

Aha, so that's what's happened.
I just tried to up a file and got a very unexpected error. I'll post it for other googlers to find:
Error: stage: "/Users/q/myfile.pdf" is invalid, must be one of:

• development
• staging
• production

Cloudup's NPM package up has been renamed to cloudup. The new up is Apex's up.  However, keep in mind that both tools install a program with the same name, up. If you try to install both, only the last one will remain (filename conflict, no namespacing).
Hey @tj, may I recommend that you add a project URL to the help message for apex/up? It took me awhile to figure out what up was and who makes it.


too much recursion

too much recursion editable_form.js:6
too much recursion editable_form.js:13
Im getting this error on the first load of the page. If I refresh the page it works fine
I have in my coffee script
$(document).ready ->
$(".editable").editable()
return
Can anyone else advise if this is an issue or something I have done
Also on the wysihtml5 it doesnt work at all Im getting lots of errors
Use of Mutation Events is deprecated. Use MutationObserver instead. bootstrap3-wysihtml5.js:5
TypeError: b.nativeSelection is null bootstrap3-wysihtml5.js:4
NS_ERROR_FAILURE:  bootstrap3-wysihtml5.js:7

Hi,
this is the same issue, like this: https://github.com/werein/x-editable-rails/issues/37
Just use version from GitHub:
gem 'x-editable-rails', :git => 'https://github.com/werein/x-editable-rails'


Add mouse button support

from https://github.com/flutter/engine/pull/9034/files

The embedding API now support for device type and different buttons, allowing for right click, middle click,etc.
Some reading:

flutter/engine PR
go-gl/glfw MouseButton doc
go-flutter code to change

I'll do it.
Just some question :
Do we want it to handle like keyboard and have separated files for each platform ?
Do we want to enable user customisation like keyboard where they can customise the callback ?

I think left/right/middle-click is fairly equal cross-platform. It doesn't feel like it needs separate implementation for win/mac/linux.
I don't think we need customization. This is quite straightforward: mapping GLFW mouse buttons to the embedder PointerEvent.

Closed by #159


WARN: "The git-mirrors experiment has been promoted to a stable feature"

Describe the bug
After upgrading to 5-21-0 (linux, arm instances), builds get a warning printed.
Steps To Reproduce
Run a build on a current stack with the "EnableAgentGitMirrorsExperiment" flag enabled.
Expected behavior
The "EnableAgentGitMirrorsExperiment" parameter should not be available in the stack, since the feature is enabled by default and the agent warns you if you still use it.

This will be fixed in V6, due out Very Soon™ :)

v6 is out, let us know if this is still an issue.


"Bad State: No Element" Exception when pasting text

While testing the editor I noticed a bug when pasting text.
Steps to reproduce:

Run the example app
Add "some" empty nodes (see the video, it occurred not only with those lines)
Select all text (in my case with CMD+A)
Copy it
Paste it at the bottom

https://user-images.githubusercontent.com/46776108/198871484-f296ac1a-b581-4082-8240-d20d8fa22013.mov
The error output is:
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following StateError was thrown building TextComponent-[GlobalKey#2a2a8](dirty, state:
TextComponentState#86374):
Bad state: No element

The relevant error-causing widget was:
TextComponent-[GlobalKey#2a2a8]
TextComponent:file:///Users/jac/dev/super_editor-751_typing_lag/super_editor/lib/src/default_editor/paragraph.dar
t:91:12

When the exception was thrown, this was the stack:
#0 List.last (dart:core-patch/growable_array.dart:348:5)
https://github.com/superlistapp/super_editor/issues/1 AttributedSpans.collapseSpans (package:attributed_text/src/attributed_spans.dart:913:24)
https://github.com/superlistapp/super_editor/discussions/2 ComputeTextSpan.computeTextSpan (package:super_editor/src/infrastructure/attributed_text_styles.dart:32:34)
https://github.com/superlistapp/super_editor/issues/3 TextComponentState.build (package:super_editor/src/default_editor/text.dart:783:31)
https://github.com/superlistapp/super_editor/issues/4 StatefulElement.build (package:flutter/src/widgets/framework.dart:4992:27)
https://github.com/superlistapp/super_editor/issues/5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4878:15)
https://github.com/superlistapp/super_editor/issues/6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5050:11)
https://github.com/superlistapp/super_editor/issues/7 Element.rebuild (package:flutter/src/widgets/framework.dart:4604:5)
https://github.com/superlistapp/super_editor/issues/8 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4859:5)
https://github.com/superlistapp/super_editor/issues/9 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:5041:11)
https://github.com/superlistapp/super_editor/issues/10 ComponentElement.mount (package:flutter/src/widgets/framework.dart:4853:5)
... Normal element mounting (24 frames)
https://github.com/superlistapp/super_editor/issues/34 Element.inflateWidget (package:flutter/src/widgets/framework.dart:3863:16)
https://github.com/superlistapp/super_editor/issues/35 MultiChildRenderObjectElement.inflateWidget (package:flutter/src/widgets/framework.dart:6435:36)
https://github.com/superlistapp/super_editor/issues/36 Element.updateChild (package:flutter/src/widgets/framework.dart:3592:18)
https://github.com/superlistapp/super_editor/pull/37 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:5964:32)
https://github.com/superlistapp/super_editor/issues/38 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6460:17)
https://github.com/superlistapp/super_editor/pull/39 Element.updateChild (package:flutter/src/widgets/framework.dart:3570:15)
https://github.com/superlistapp/super_editor/pull/40 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6307:14)
https://github.com/superlistapp/super_editor/issues/41 Element.updateChild (package:flutter/src/widgets/framework.dart:3570:15)
https://github.com/superlistapp/super_editor/issues/42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4904:16)
https://github.com/superlistapp/super_editor/pull/43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5050:11)
https://github.com/superlistapp/super_editor/pull/44 Element.rebuild (package:flutter/src/widgets/framework.dart:4604:5)
https://github.com/superlistapp/super_editor/pull/45 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2667:19)
https://github.com/superlistapp/super_editor/issues/46 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:882:21)
https://github.com/superlistapp/super_editor/pull/47 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:378:5)
https://github.com/superlistapp/super_editor/issues/48 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1175:15)
https://github.com/superlistapp/super_editor/issues/49 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1104:9)
https://github.com/superlistapp/super_editor/issues/50 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1015:5)
https://github.com/superlistapp/super_editor/issues/51 _invoke (dart:ui/hooks.dart:148:13)
https://github.com/superlistapp/super_editor/issues/52 PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:318:5)
https://github.com/superlistapp/super_editor/pull/53 _drawFrame (dart:ui/hooks.dart:115:31)

@angelosilvestre can you take a look at this?


Clean-up unified pipelines.

This PR removes the client.yml pipeline that was in use before unified pipelines was rolled out. As part of this clean-up we will also be doing the following:

[ ] Removing the internal net - client pipeline.
[ ] Removing the public net - client - ci pipeline.
[ ] What else do we need to do here?

@chidozieononiwu do you know if there are any parts that still require the full client build?

@chidozieononiwu do you know if there are any parts that still require the full client build?

No, I think its good to go.

Well if you guys see no issues I'll go ahead and merge this and nuke the pipelines (note I included the old release pipeline as one of the pipelines to get rid of). Or does that need to stay for management plane for now?

As part of removing these client pipelines I do want to ensure we still have coverage for changes under the eng directory. For .NET I've asked @annelo-msft to add that trigger path for core but for the other languages @mitchdenny can you be sure we have those trigger paths setup?

Paths are setup.

I wonder if we need to communicate this to the service teams in some way. We had someone from service bus trying to run these pipelines last week.

We should also clean-up the badges in the root readme https://github.com/Azure/azure-sdk-for-net/blob/master/README.md which are pointing at this build.

@mitchdenny another thing I saw earlier is that we have some release pipelines like https://dev.azure.com/azure-sdk/internal/_releaseDefinition?definitionId=63&_a=environments-editor-preview that trigger off of these client builds we need to audit those and see if we move them to the unified pipelines or come up with another option


Organizing state as recommended by Redux?

Is it possible to use store.select() on a store structured in the shape recommended by Redux?  Redux recommends storing entities in an object keyed by ID, rather than in an array.  Here is the recipe in the Redux docs:
http://redux.js.org/docs/recipes/reducers/NormalizingStateShape.html
I'm trying to use store.select() on a state shaped this way like so:
store.select(state => state.contacts)
    .map(contacts => contacts.allIds.map(id => contacts[id]))
    .filter(contact => contact.type == 'customer') //Removing this works but I need a filter!
    .subscribe(customers => this.customers = customers);

However, I am getting the following error:
store.select(...).map(...).filter is not a function

You need to import it import 'rxjs/add/operator/filter';

@DzmitryShylovich That was it.  Thank you!


M4 redemption flow

This PR add several functionality in order to close Afloat's Milestone 4

LGTM! :+1:

LGTM!


[WIP] Update to Pulsar 4.0.1

Closing as this was a temporary PR to verify the CI passes with everything updated to Pulsar 4.0.1


license lockout modal design changes and add sign out functionality

Signed-off-by: Sachin Bachhav<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?
If a user signs in as a non-admin user before a license is applied, they will get a license popup that they can't get past as only the admin can apply a license. They also can't get to the log out button to re-login as admin.
The current workaround is opening an incognito window or using the CLI to set a license key.
so as fix added sign out functionality along with some design changes.
:chains: Related Resources
#1484
:+1: Definition of Done
Added Sign out functionality in license lockout modal
:athletic_shoe: How to Build and Test the Change
build components/automate-ui

Set up environment
Log in as admin user
Create a non-admin user
Log out as admin user
Remove license in studio using remove_dev_license
Log in as non-admin user

:camera: Screenshots

as a note to anyone reviewing, a followup issue will be made for the apply license modal and applied license modal to get them to align, but its out of scope for this issue/pr.


[Generic signature builder] Use addSameTypeRequirementBetweenArchetypes consistently

Rather than trying to set the representative directly when adding
implicit requirements, use addSameTypeRequirementBetweenArchetypes()
consistently.

@swift-ci please smoke test and merge


Assignment 2: misleading guidance in batchnorm_forward method in layers.py

In the method documentation it is stated:
running_mean = momentum * running_mean + (1 - momentum) * sample_mean
running_var = momentum * running_var + (1 - momentum) * sample_var

But it should:
running_mean = momentum * sample_mean + (1 - momentum) * running_mean
running_var = momentum * sample_var + (1 - momentum) * running_var

(Spring, 2017)

what if the running_mean and sample_mean are of different dimensions, I mean, the smple mean compute the current input yet the running mean is iherited from former layer, and they don't necessarily have the same feature dimension right?


Make conf directory mappable

Seems like a good plan to me to make the conf directory mappable (through volume binding in Docker). This would allow advanced users to edit the app.conf (Beego web framework config file), and the template files that are used to create OpenVPN client files, at the host level (by command line editors, Cockpit with the Navigator addon, or Webmin for example).
We'd check for the existence of these files at container start, and if they don't exist (e.g. mapped for the first time), we'd copy them from a default directory.

would this feature enable the usage of multiple different subnets instead of a single one?


Enable CI-testing on macOS and Windows

This is just a WIP based on #386. Let's see how it goes.

CrateDB nightlies are not available for macOS and Windows, see [1]. Bummer.
[1] https://github.com/crate/crate-python/pull/388/checks?check_run_id=1347098559#step:4:124

We are seeing this again [1].
Error: Error downloading extends for URL https://cdn.crate.io/downloads/releases/cratedb/x64_windows/crate-4.3.0.zip: [WinError 10054] An existing connection was forcibly closed by the remote host
Error: Process completed with exit code 1.

[1] https://github.com/crate/crate-python/pull/388/checks?check_run_id=1347231174#step:4:115

While making some progress on this, the last command bin/coverage run $test_program -vv1 errors out on Windows like
No file to run: 'bin/test-quick'

or
No file to run: 'bin\test-quick'

See also [1].
This is somehow related to

how the system path and python path are handled on various operating systems Windows [2].

[1] https://github.com/crate/crate-python/pull/388/checks?check_run_id=1347349770#step:5:16
[2] https://stackoverflow.com/questions/3312451/how-can-you-get-unittest2-and-coverage-py-working-together

The reason that bin/coverage has not been able to find bin/test-quick is that it gets installed as bin/test-quick.exe on Windows. However, addressing that file obviously will not work as intended [1]:
Couldn't run 'bin/test-quick.exe' as Python code: SyntaxError: invalid or missing encoding declaration

[1] https://github.com/crate/crate-python/pull/388/checks?check_run_id=1347537748#step:5:17

After some more adjustments, the test suite also starts on Windows. Now, it croaks with AttributeError: module 'time' has no attribute 'clock' from sqlalchemy.util.compat [1], at least with sqlalchemy-1.1.18.
Traceback (most recent call last):
  File "D:\a\crate-python\crate-python\src\crate\client\tests.py", line 39, in <module>
    from crate.client.sqlalchemy.dialect import CrateDialect
  File "D:\a\crate-python\crate-python\src\crate\client\sqlalchemy\__init__.py", line 22, in <module>
    from .dialect import CrateDialect
  File "D:\a\crate-python\crate-python\src\crate\client\sqlalchemy\dialect.py", line 25, in <module>
    from sqlalchemy import types as sqltypes
  File "D:\a\crate-python\crate-python\eggs\sqlalchemy-1.1.18-py3.8-win-amd64.egg\sqlalchemy\__init__.py", line 9, in <module>
    from .sql import (
  File "D:\a\crate-python\crate-python\eggs\sqlalchemy-1.1.18-py3.8-win-amd64.egg\sqlalchemy\sql\__init__.py", line 8, in <module>
    from .expression import (
  File "D:\a\crate-python\crate-python\eggs\sqlalchemy-1.1.18-py3.8-win-amd64.egg\sqlalchemy\sql\expression.py", line 33, in <module>
    from .visitors import Visitable
  File "D:\a\crate-python\crate-python\eggs\sqlalchemy-1.1.18-py3.8-win-amd64.egg\sqlalchemy\sql\visitors.py", line 28, in <module>
    from .. import util
  File "D:\a\crate-python\crate-python\eggs\sqlalchemy-1.1.18-py3.8-win-amd64.egg\sqlalchemy\util\__init__.py", line 8, in <module>
    from .compat import callable, cmp, reduce,  \
  File "D:\a\crate-python\crate-python\eggs\sqlalchemy-1.1.18-py3.8-win-amd64.egg\sqlalchemy\util\compat.py", line 172, in <module>
    time_func = time.clock
AttributeError: module 'time' has no attribute 'clock'

[1] https://github.com/crate/crate-python/pull/388/checks?check_run_id=1347946253#step:5:42

Now, there's an error when trying to bootstrap CrateDB on Windows [1]. It goes like
b'[2020-11-03T15:11:44,184][WARN ][o.e.b.ElasticsearchUncaughtExceptionHandler] [crate] uncaught exception in thread [main]'
b'org.elasticsearch.bootstrap.StartupException: java.lang.IllegalStateException: failed to create a child event loop'
[...]
b'Caused by: java.net.SocketException: Unrecognized Windows Sockets error: 10106: socket'
[...]

[1] https://github.com/crate/crate-python/pull/388/checks?check_run_id=1348166824#step:5:212

java.net.SocketException: Unrecognized Windows Sockets error: 10106: socket
All of these didn't bring any improvements:
# Disable firewall.
netsh advfirewall set allprofiles state off

# Reset IP stack.
netsh winsock reset

# Disable IPv6.
netsh interface teredo set state disabled
netsh interface ipv6 6to4 set state state=disabled undoonstop=disabled
netsh interface ipv6 isatap set state state=disabled

set _JAVA_OPTIONS="-Djava.awt.headless=true -Djava.net.preferIPv4Stack=true"

java.net.SocketException: Unrecognized Windows Sockets error: 10106: socket
Some resources suggest to set the SystemRoot environment variable to C:\Windows:

https://bz.apache.org/netbeans/show_bug.cgi?id=91532
https://stackoverflow.com/questions/3947555/java-net-socketexception-unrecognized-windows-sockets-error-0-jvm-bind-jboss/60072492#60072492
https://community.microfocus.com/t5/StarTeam-Knowledge-Base/Network-problem-Unrecognized-Windows-Sockets-error-10106-create/ta-p/1755101

Indeed: With 4c05db6, CrateDB seems to be able to spin up successfully.

Now, we are seeing this:
Error in test D:\a\crate-python\crate-python\src\crate\client\sqlalchemy\doctests\itests.txt
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\unittest\case.py", line 59, in testPartExecutor
    yield
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\unittest\case.py", line 601, in run
    self.setUp()
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\doctest.py", line 2167, in setUp
    self._dt_setUp(test)
  File "D:\a\crate-python\crate-python\src\crate\client\tests.py", line 160, in setUpCrateLayerAndSqlAlchemy
    setUpWithCrateLayer(test)
  File "D:\a\crate-python\crate-python\src\crate\client\tests.py", line 148, in setUpWithCrateLayer
    cursor.execute("copy locations from ?", (data_path,))
  File "D:\a\crate-python\crate-python\src\crate\client\cursor.py", line 54, in execute
    bulk_parameters)
  File "D:\a\crate-python\crate-python\src\crate\client\http.py", line 396, in sql
    content = self._json_request('POST', self.path, data=data)
  File "D:\a\crate-python\crate-python\src\crate\client\http.py", line 523, in _json_request
    _raise_for_status(response)
  File "D:\a\crate-python\crate-python\src\crate\client\http.py", line 207, in _raise_for_status
    error_trace=error_trace)
crate.client.exceptions.ProgrammingError: SQLParseException[Illegal character in opaque part at index 2: D:\a\crate-python\crate-python\src\crate\testing\testdata\data\test_a.json]

Regarding this, we are lucky @seut already suggested at https://github.com/crate/crate/issues/7781 to

Use a valid file URI on windows see e.g.: https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/.


Can't get it to work under latest Game Version

I've tried both the latest official release installed as dev plugin, as well as building the plugin myself from current main branch and putting into dev plugins. It appears in the Plugin List, but shows the following error:
The Plugin is outdated and incompatible at the moment.
I was not able to find any API references in the code, or anything else I could easily change myself to make it work. Would love to use this as i just started an alt.
Thank you!

UPDATE: Can be loaded when enabling "Load all API Levels" in Dalamuds Dev Menu, but the plugin doesnt seem to do much? Let me know if it should work right now.

you can use repo link to install this plugin, it's not necessary to build it.
https://github.com/a08381/Dalamud.SkipCutscene/raw/dist/repo.json
use command /sc to enable or disable, when it saids "passed", it works; or "failed", it down.
this plugin is works for skip the cutscene from Castrum Meridianum
or The Praetorium, when it works, these two instance can skip cutscene when you set skip in your character settings.

Oh it's not general for all the cutscenes, then I misunderstood the plugin alltogether. Thank you for the help!


Add CI logos to build status badges

Also fixes the inconsistency between the two build badge captions.
See here for a live demo.

Codecov Report

Merging #49 into master will increase coverage by 0.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     83.37%   84.35%   +0.98%
- Complexity      208      224      +16
============================================
  Files            20       20
  Lines           415      441      +26
  Branches         99      105       +6
============================================
+ Hits            346      372      +26
- Misses           28       29       +1
+ Partials         41       40       -1

Impacted Files
Coverage Δ
Complexity Δ

...fejojo/schaapi/testgenerator/SootClassGenerator.kt
92.64% <0%> (+4.55%)
41% <0%> (+16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b40c5b...d7d0180. Read the comment docs.


HIVE-26201 QueryResultsCache should add permission check after mkdir with special permission

HIVE-26201 QueryResultsCache should add permission check after mkdir with special permission
What changes were proposed in this pull request?
TezSessionState, QueryResultsCache and Context use mkdirs(path, permission) to create directory with special permission. But If the umask is too restrictive, permissions may not work as expected. So we need to check if permission is set as expected.
Does this PR introduce any user-facing change?
no

Hi @abstractdog , Could you please have a look at this?It same as TEZ-4412.

Hi @abstractdog @achennagiri ,Could you please have a look at this ?


investigate what happened with 1.12.1

https://thanks.rust-lang.org/rust/1.12.1 <- somewhere along the way, this got lost, it seems. I bet it had to do with https://github.com/rust-lang-nursery/thanks/pull/57 and calculating the versions automatically.

From the logs:
Jan 31 13:55:16.948 INFO Assigning commits to release 1.12.1, version: 0.1.0
Jan 31 13:55:16.980 INFO Assigning commit d4f39402a0c2c2b94ec0375cd7f7f6d7918113cd to release 1.12.1, version: 0.1.0
<snip>
Jan 31 13:55:18.883 INFO Assigning commit d4f39402a0c2c2b94ec0375cd7f7f6d7918113cd to release 1.13.0, version: 0.1.0

I don't know why it's re-assigning that commit.

It's re-assigning because now, instead of manually choosing which is the previous, our inference creates 1.13.0 from 1.12.1 instead of 1.12.

This was fixed by https://github.com/rust-lang-nursery/thanks/pull/65


feat: added the new OS support for NGINX R31

Proposed changes

Alpine Linux 3.19 added
FreeBSD 14 added
Alpine Linux 3.15 removed
FreeBSD 12 removed

Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] I have run make install-tools and have attached any dependency changes to this pull request
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[ ] If applicable, I have updated any relevant documentation (README.md)
[ ] If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (17fe5e9) 66.15% compared to head (c7c1b1e) 66.14%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   66.15%   66.14%   -0.02%
==========================================
  Files         118      118
  Lines       13468    13468
==========================================
- Hits         8910     8908       -2
- Misses       3958     3959       +1
- Partials      600      601       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: update types based on PH discussion

In the PH on Tuesday we discussed that we would want to revert the Handler type to be a function and add an isIntrospectionQuery boolean to the graphql.query event.

Can you update the PR title? "PH discussion" is not suitable for a public npm package changelog ;)


Investigate Python Interop

Want to ensure the basic polyglot interop with Python is fully working.

Confirm we can move simple scalars back and forth (including Date, Date_Time and Time_Of_Day).
Also review what happens with big integers as it stands.
What happens with an Enso type.
Confirm that Vector/Array become python list appropriately
Confirm that Map become python dictionary appropriately
Verify works in both directions.

Verify we can import python libraries - specifically how to import datetime and show it works.

Python in GraalVM CE 17.0.7+7.1 seems to have a problem with treatment of null-like values (reported as https://github.com/oracle/graalpython/issues/345) and also converting ZoneId into tzinfo (being discussed):
import java.time.ZoneId;

import org.graalvm.polyglot.Context;

class t {
  public static void main(String... args) throws Exception {
    var ctx = Context.newBuilder().allowAllAccess(true).build();
    var dt = ctx.eval("python", """
    import datetime
    datetime.datetime
    """);
    var v = dt.execute(2023, 7, 26, 5, 55, 57, 440);
    System.out.println(v);
    var n = dt.execute(2023, 7, 26, 5, 55, 57, 440, null);
    System.out.println(n);
    var z = dt.execute(2023, 7, 26, 5, 55, 57, 440, ZoneId.of("CET"));
    System.out.println(z);
  }
}

v is fine, but n and z fail with:
Exception in thread "main" TypeError: tzinfo argument must be None or of a tzinfo subclass
	at <python> _check_tzinfo_arg(bin/graalvm-ee-java17-21.3.0/languages/python/lib-python/3/datetime.py:443:16056-16126)
	at <python> __new__(bin/graalvm-ee-java17-21.3.0/languages/python/lib-python/3/datetime.py:1587:53507-53531)
	at org.graalvm.sdk/org.graalvm.polyglot.Value.execute(Value.java:841)

Pros and Done

Confirm we can move simple scalars back and forth (including Date and Time_Of_Day).

Done: Date and Time_Of_Day seem to be fine as #7396 demonstrates.

What happens with an Enso type.

Not sure what this means?

Confirm that Vector/Array become python list appropriately

Done. Tested in Vector_Spec alrelady.

Confirm that Map become python dictionary appropriately

Done. Tested in Map_Spec already.

Verify how to import datetime and show it works.

Done: #7396 demonstrates how to import datetime library.
Cons or Pending

Confirm we can move simple scalars back and forth (including Date, Date_Time and Time_Of_Day).

There is a problem with Date_Time as Python cannot consume polyglot or Enso ZoneId.

Verify works in both directions.

Neither python seems to consume Enso's Time_Of_Day properly.

Also review what happens with big integers as it stands.

Pending. Tracked as #7213

Verify we can import python libraries

Not sure how to import generic python files not installed in the system.

Status Update

Confirm we can move simple scalars back and forth (including Date, Date_Time and Time_Of_Day).

There is a problem with Date_Time as Python cannot consume polyglot or Enso ZoneId.
Verify works in both directions.
Neither python seems to consume Enso's Time_Of_Day properly.

Reported as #7418

Also review what happens with big integers as it stands.

(Almost) Done as #7213
Future Work

Verify we can import python libraries

By writing own truffle.FileSystem we can control what files the Python implementation sees. According to the finding polyglot bindings specification we should be able to load Python, JavaScript files from polyglot/python and polyglot/js directories. I don't think this is implemented at all right now, but should be possible with the help of the truffle.FileSystem when really needed.


Remove the unnecessary placeholder scaler functions

Remove the unnecessary placeholder scalar functions that are already configured in the TransformFunctionType

Codecov Report

Merging #11552 (290f9f2) into master (6208e7c) will decrease coverage by 48.57%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11552       +/-   ##
=============================================
- Coverage     63.05%   14.49%   -48.57%
+ Complexity     1109      201      -908
=============================================
  Files          2320     2320
  Lines        124667   124655       -12
  Branches      19033    19033
=============================================
- Hits          78614    18064    -60550
- Misses        40458   105062    +64604
+ Partials       5595     1529     -4066

Flag
Coverage Δ

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-17
0.00% <0.00%> (-62.92%)
:arrow_down:

java-20
14.49% <0.00%> (-48.41%)
:arrow_down:

temurin
14.49% <0.00%> (-48.57%)
:arrow_down:

unittests
14.49% <0.00%> (-48.57%)
:arrow_down:

unittests1
?

unittests2
14.49% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...apache/pinot/common/function/FunctionRegistry.java
0.00% <ø> (-65.52%)
:arrow_down:

...e/pinot/common/function/TransformFunctionType.java
0.00% <0.00%> (-89.50%)
:arrow_down:

... and 1493 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

some of those are required as placeholders for calcite function registry.

@xiangfu0 IIUC, as long as we configure them properly within TransformFunctionType, they will be auto-registered into PinotOperatorTable. The placeholder functions are not configured correctly (e.g. arrayLength returns String instead of int), but the tests can pass.


Bad HTML encoding in blames

Gitea Version
1.15.6
Git Version
2.33.1
Operating System
Arch Linux
How are you running Gitea?
Using gitea official builds from dl.gitea.io/gitea. It's the  gitea-1.15.6-linux-amd64 executable.
Database
SQLite
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
Reproduction :

create a new repo in the web interface
commit a new file in this repo and put special characters in the commit like <, > or '
push the commit in gitea
look at the new file blame in the web interface

Result : the special characters of the commit text are badly encoded on the blame page.
I tested by commiting <yes> l'apo. It is displayed as <yes> l'apo on the web page.
Screenshots

The <a> tag contains &lt;yes&gt; l&#39;apo. It should contain <yes> l'apo. It's the same thing for the title attribute of <a>.

I think it is a double-encoding bug.
Can you share the existing reproducible URL on try.gitea.io? Then developers can view the bug at first glance.

Yes it is here https://try.gitea.io/issuereporter287/repo.


Error turning light on

I am having an issue with a light converted from custom_white with the jnimmo version of the integration.
I recently upgraded HA to 3.9.2 and of course custom_white was broken.
I followed recommendations to switch to this version of the integration and it went mostly smoothly.
I converted custom_white entities to color_temp
          - channel: 131
            name: Maker Light 1
            type: color_temp
            channel_setup: dt

However, now when I attempt to turn on the light I get the following error - failed to call service light/turn_on
My RGB light bars still work correctly as type: rgb

Can you show me under the attributes what the value is of 'Dmx values'? This config does seem to be correct.

Think it might be related to the migration process itself; try completely removing the integration and re-adding it once again?
To find the root cause, it would help me a bit if you could include the bit from the logs around this error.

Here is the associated image and log messages.

2022-09-13 14:59:41.114 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [140093288016256] Received {'type': 'call_service', 'domain': 'light', 'service': 'turn_on', 'service_data': {'entity_id': 'light.maker_light_2'}, 'id': 27}
2022-09-13 14:59:41.115 DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=light, service=turn_on, service_data=entity_id=light.maker_light_2>
2022-09-13 14:59:41.116 DEBUG (Recorder) [homeassistant.components.recorder.core] Processing task: EventTask(event=<Event call_service[L]: domain=light, service=turn_on, service_data=entity_id=light.maker_light_2>)
2022-09-13 14:59:41.116 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140093288016256]
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 199, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1713, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1750, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 204, in handle_service
    await service.entity_service_call(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 676, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 930, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 713, in _handle_entity_call
    await result
  File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 553, in async_handle_light_on_service
    await light.async_turn_on(**filter_turn_on_params(light, params))
  File "/config/custom_components/artnet_led/light.py", line 496, in async_turn_on
    await super().async_create_fade(**kwargs)
  File "/config/custom_components/artnet_led/light.py", line 276, in async_create_fade
    self._channel.add_fade(
  File "/usr/local/lib/python3.10/site-packages/pyartnet/dmx_channel.py", line 83, in add_fade
    assert 0 <= k.val_target <= (256 ** self._CHANNEL_SIZE) - 1
AssertionError
2022-09-13 14:59:41.121 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [140093288016256] Sending {"id":27,"type":"result","success":false,"error":{"code":"unknown_error","message":""}}

I published a quick v0.0.5 that will prevent crashing the flow and instead will print a warning message. It doesn't fix the root cause, but at least it will reduce the severity of the error.
After updating, could you please find this log line for me?
log.warning(f"Value for channel {channel} isn't within bound: {value}")

Lights are working-ish.
I have noticed that the control bars seem skewed.  For instance 0% brightness is around the middle of the the brightness bar.
Here's the data you were looking for.
[custom_components.artnet_led.light] Value for channel t isn't within bound: -45.82949308755758

Ah I see, that explains it. The brightness is set by HA itself, I'm not even touching that. I think that the color temperature value coming from HA is also offset similarly. It's giving you values that are outside of its own specification.
It might have to do with the data model of ATTR_WHITE_VALUE being interpreted as a ATTR_COLOR_TEMP. I know it's annoying, but I think perhaps it's best if you do a clean install:

Remove, or comment out, the config of the faulty lights
Restart HA
Remove the entities of the faulty lights
Put back the config
Restart HA

@JohnnyFlash Did that latest procedure fix it for you?


Monitoring-satellite/CRDs: Force replace on argocd sync

Description

Following ArgoCD docs, we can enable per resource sync policy.
This PR forces all CRDs to be installed with kubectl replace instead of kubectl apply

Nice 🎉 I don't understand why they're all prefixed with 0, e.g. 0alertmanagerConfigCustomResourceDefinition but I trust you 😃

Those are the names used upstream :)
https://github.com/prometheus-operator/prometheus-operator/blob/e2211ccdfe1600705ec3b4993d6befed5d26437c/jsonnet/prometheus-operator/prometheus-operator.libsonnet#L29-L37


QT6 programs fail when using a custom keyboard layout

Describe the bug
For example: anki doesn't respect XKB_CONFIG_ROOT
Steps To Reproduce

Add a layout to xserver.extraLayouts
Use that layout with xserver.layout
Build and run anki
Observe that it doesn't look in the correct $XKB_CONFIG_ROOT for your layout:

❯ echo $XKB_CONFIG_ROOT
/nix/store/33x74vs3ykb3xs1442r8yg1921fy329h-xkeyboard-config-2.33/etc/X11/xkb

~/src/nixpkgs on nixos-unstable [nix-shell]
❯ anki
Running with temporary Qt5 compatibility shims.
Run with DISABLE_QT5_COMPAT=1 to confirm compatibility with Qt6.
Preparing to run...
Qt warning: In /nix/store/4p8jsn41v70p3wblmcmkhwzwmg8s821i-qgnomeplatform-0.8.4/lib/qt-5.15.8/plugins/platformthemes/libqgnomeplatformtheme.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt warning: In /nix/store/ngj9sch1rfxc6d4mdki84p9mss84sxkn-adwaita-qt-1.4.1/lib/qt-5.15.8/plugins/styles/adwaita.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
Qt info:

GL Type: desktop
Surface Type: OpenGL
Surface Profile: CompatibilityProfile
Surface Version: 4.6
QSG RHI Backend: OpenGL
Using Supported QSG Backend: yes
Using Software Dynamic GL: no
Using Multithreaded OpenGL: yes

Init Parameters:
  *  application-name Anki
  *  browser-subprocess-path /nix/store/i8ppshlwyxjqn8im23wsgbry35dryyrs-qtwebengine-6.4.3/libexec/QtWebEngineProcess
  *  create-default-gl-context
  *  disable-features ConsolidatedMovementXY,InstalledApp,BackgroundFetch,WebOTP,WebPayments,WebUSB,PictureInPicture
  *  disable-setuid-sandbox
  *  disable-speech-api
  *  enable-features NetworkServiceInProcess,TracingServiceInProcess
  *  enable-threaded-compositing
  *  in-process-gpu
  *  use-gl desktop

xkbcommon: ERROR: Couldn't find file "symbols/fc660c" in include paths
xkbcommon: ERROR: 1 include paths searched:
xkbcommon: ERROR:       /nix/store/18kg67dfchk2l7ni9i0hrpbdspbxlrzw-xkeyboard-config-2.33/share/X11/xkb
xkbcommon: ERROR: Abandoning symbols file "(unnamed)"
xkbcommon: ERROR: Failed to compile xkb_symbols
xkbcommon: ERROR: Failed to compile keymap
Starting main loop...
[282321:282350:0416/224135.195895:FATAL:xkb_keyboard_layout_engine.cc(652)] Keymap file failed to load: fc660c
#0 0x7f3a6f8fea19 base::debug::CollectStackTrace()
#1 0x7f3a6f851306 base::debug::StackTrace::StackTrace()
#2 0x7f3a6f84232b logging::LogMessage::~LogMessage()
#3 0x7f3a70575f8e ui::(anonymous namespace)::LoadKeymap()
#4 0x7f3a70573ff6 base::internal::Invoker<>::RunOnce()
#5 0x7f3a6f8b455a base::TaskAnnotator::RunTaskImpl()
#6 0x7f3a6f8e4043 _ZN4base13TaskAnnotator7RunTaskIJZNS_8internal11TaskTracker11RunTaskImplERNS2_4TaskERKNS_10TaskTraitsEPNS2_10TaskSourceERKNS_13SequenceTokenEEUlRN8perfetto12EventContextEE_EEEvNSE_12StaticStringERNS_11PendingTaskEDpOT_.constprop.0
#7 0x7f3a6f8e468b base::internal::TaskTracker::RunContinueOnShutdown()
#8 0x7f3a6f8e480e base::internal::TaskTracker::RunTask()
#9 0x7f3a6f91bcd8 base::internal::TaskTrackerPosix::RunTask()
#10 0x7f3a6f8dfca1 base::internal::TaskTracker::RunAndPopNextTask()
#11 0x7f3a6f8ef39e base::internal::WorkerThread::RunWorker()
#12 0x7f3a6f8efb7d base::internal::WorkerThread::RunPooledWorker()
#13 0x7f3a6f91beeb base::(anonymous namespace)::ThreadFunc()
#14 0x7f3a8d29fe24 start_thread
#15 0x7f3a8d3219b0 __clone3
Task trace:
#0 0x7f3a705751e6 ui::XkbKeyboardLayoutEngine::SetCurrentLayoutByNameWithCallback()

[1]    282321 trace trap (core dumped)  anki

Expected behavior
Anki starts (and uses the correct layout)
Notify maintainers
@oxij @Profpatsch @euank
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.2, NixOS, 23.05 (Stoat), 23.05pre461539.c90c4025bb6`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixos"`
 - nixpkgs: `/home/e/src/nixpkgs`

I ran into this issue a few days ago as well, and worked around it by remapping my keyboard with kanata instead of xkb. It seems to affect all Qt 6 apps, not just Anki, and only at startup. (So if you change the layout with setxkbmap us before starting Anki, then change back to your custom layout after it's running, Anki will use the custom layout correctly.)

I can't reproduce this on my machine, but the code causing this appears to be https://invent.kde.org/qt/qt/qtwebengine-chromium/-/blob/22fec96c83014753f8d4d709dad25902cafa1a75/chromium/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc#L641 (we of course patch the path), which is (only?) called from https://invent.kde.org/qt/qt/qtwebengine-chromium/-/blob/22fec96c83014753f8d4d709dad25902cafa1a75/chromium/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc#L700 (the defined(PLATFORM_QT) is not there in upstream chromium, so this is unreachable in chromium?).
I imagine the correct thing to do is replace the path with getenv("XKB_CONFIG_ROOT") if set when the legacy display server is used and just use XKB_CONTEXT_NO_FLAGS instead of XKB_CONTEXT_NO_DEFAULT_INCLUDES otherwise.  The reason why they remove the default includes is probably to match X's behaviour. X doesn't support xkb overlays (and doesn't care about XKB_CONFIG_ROOT, we just set the environment variable to the same directory we pass to X), it only reads the xkbmaps from a single directory, usually /usr/share/X11/xkb.
I'm not sure I want to know why chromium/qtwebengine reads keyboard layouts from disk.

This is definitely not limited to Anki, I see a similar thing with Calibre when trying to open a book:
$ calibre
xkbcommon: ERROR: Couldn't process include statement for 'gb(qw0rty)'
xkbcommon: ERROR: Abandoning symbols file "(unnamed)"
xkbcommon: ERROR: Failed to compile xkb_symbols
xkbcommon: ERROR: Failed to compile keymap
[1014028:1014052:0417/142531.477515:FATAL:xkb_keyboard_layout_engine.cc(652)] Keymap file failed to load: gb-qw0rty
#0 0x7f0f3ecfea19 base::debug::CollectStackTrace()
#1 0x7f0f3ec51306 base::debug::StackTrace::StackTrace()
#2 0x7f0f3ec4232b logging::LogMessage::~LogMessage()
#3 0x7f0f3f975f8e ui::(anonymous namespace)::LoadKeymap()
#4 0x7f0f3f973ff6 base::internal::Invoker<>::RunOnce()
#5 0x7f0f3ecb455a base::TaskAnnotator::RunTaskImpl()
#6 0x7f0f3ece4043 _ZN4base13TaskAnnotator7RunTaskIJZNS_8internal11TaskTracker11RunTaskImplERNS2_4TaskERKNS_10TaskTraitsEPNS2_10TaskSourceERKNS_13SequenceTokenEEUlRN8perfetto12EventContextEE_EEEvNSE_12StaticStringERNS_11PendingTaskEDpOT_.constprop.0
#7 0x7f0f3ece468b base::internal::TaskTracker::RunContinueOnShutdown()
#8 0x7f0f3ece480e base::internal::TaskTracker::RunTask()
#9 0x7f0f3ed1bcd8 base::internal::TaskTrackerPosix::RunTask()
#10 0x7f0f3ecdfca1 base::internal::TaskTracker::RunAndPopNextTask()
#11 0x7f0f3ecef39e base::internal::WorkerThread::RunWorker()
#12 0x7f0f3ecefb7d base::internal::WorkerThread::RunPooledWorker()
#13 0x7f0f3ed1beeb base::(anonymous namespace)::ThreadFunc()
#14 0x7f0f5b09fe24 start_thread
#15 0x7f0f5b1219b0 __clone3
Task trace:
#0 0x7f0f3f9751e6 ui::XkbKeyboardLayoutEngine::SetCurrentLayoutByNameWithCallback()

Also observing it with Calibre’s ebook-viewer. But it must be a regression, I have had a custom keyboard layout for a while, and this just started being a problem.

"on 22.11" is probably pretty key, I just built 855fb684d9b374a122db730277849ff62f47d31a (as "a random commit on master from a month or so ago") and ebook-viewer still crashes on launch. I'll try to go further back in history if I have time...

For ebook-viewer, I figured it was worth seeing if it starting to fail corresponds with it switching to qt6.
Commit da6eaf2dbbecc92fb76f93e8197a0ff4c560fc04 is good (the last commit it's qt5) and works fine.
It fails to launch in the commit that switches to qt6 for another reason, but a commit soon after 3303cf254cd564dcebe287cea43d5db7316da2d8 exhibits the bug described in this issue (that's the first commit after the qt6 upgrade with qtwebengine cached, and I don't feel like compiling webengine right now).
I think it's s to say calibre's ebook-viewer has been failing in this way ever since it was upgraded to qt6. My guess would be that qt6 in nixpkgs has had this problem the entire time.
For anyone else who wants to poke at this, the repro I used for this is here; I just plugged the above nixpkgs commits into the nixpkgs input to test em.

This should be fixed on nixpkgs-unstable now!
I'm happy to backport it to 22.11 as well if anyone wants to advocate for that (I'd just do it without asking, but I feel like I'd end up compiling qt6 to verify the backport works, which is a lot of cpu cycles to burn).

Thank you, @euank!

I didn't backport the patch, but we waited long enough that 23.05 is now the stable release :D
Closing as fixed!


Geospatial component for heightmap & DEMs

🎉 New feature

Part of https://github.com/ignitionrobotics/ign-gazebo/issues/235

Summary

Moved heightmap and DEM classes to a new geospatial component, which depends on graphics
GDAL is a required dependency for the geospatial component
Ported over DEM updates & tests from gazebo11 except for DemTest.NegDem since https://github.com/osrf/gazebo/issues/2881 is still an issue and will hopefully be resolved in a future PR

Test it
/path/to/build/bin/UNIT_Dem_TEST

Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Thanks for the review!

It would be good to test compiling a downstream library that uses heightmap against this branch to make sure all the includes are found and everything links correctly

I was able to run ign gazebo heightmap.sdf in a Garden workspace without any issues. Does this suffice?

There are some CI failures, probably due to a different GDAL version on Bionic?

Yes, this is the likely cause but are we dropping Bionic support for Garden?

I was able to run ign gazebo heightmap.sdf in a Garden workspace without any issues. Does this suffice?

Cool! So you updated all locally libraries to use ign-common5?

Yes, this is the likely cause but are we dropping Bionic support for Garden?

Ahh good call. I didn't realize that would bear fruit so early. We need to update CI

Cool! So you updated all locally libraries to use ign-common5?

Yup, specifically ign-fuel-tools, ign-gazebo, ign-gui, ign-launch, ign-physics, ign-rendering, and ign-sensors.

Ahh good call. I didn't realize that would bear fruit so early. We need to update CI

Should I create an issue somewhere?

Should I create an issue somewhere?

I created some issues:

https://github.com/ignition-tooling/release-tools/pull/565
https://github.com/ignition-tooling/release-tools/issues/566

Also see https://github.com/ignitionrobotics/ign-common/pull/270

I think it definitely makes sense to move Dem.hh to the geospatial component, but I'm not sure about moving HeightmapData.hh and ImageHeightmap.hh out of graphics. gdal isn't used by ImageHeightmap, but moving this code to geospatial would add that dependency to this code.

I think it definitely makes sense to move Dem.hh to the geospatial component, but I'm not sure about moving HeightmapData.hh and ImageHeightmap.hh out of graphics. gdal isn't used by ImageHeightmap, but moving this code to geospatial would add that dependency to this code.

That makes sense. @chapulina do you have any thoughts before I make the changes?

I agree that requiring GDAL to use image heightmaps may be undesired, but when we have a geospatial component, I think it will be confusing for users that not all heightmap classes are in it, and some are actually in graphics.
The reason to add the geospatial component was to avoid adding that dependency to all graphics users, but we chose that name because we wanted the component to be semantically meaningful, and not just referent to a dependency. We need to draw the line at some point and inevitably some users will always get a bit more than they actually need. That's true for other ign-common components and other Ignition libraries too. Also note that all our "internal" users (that is, all Ignition libraries that will use this: rendering and physics) will support DEMs anyway.
I'm leaning towards being more semantically precise instead of trying to reduce the dependency surface for hypothetical users.

I'm leaning towards being more semantically precise instead of trying to reduce the dependency surface for hypothetical users.

I agree, I think this will avoid confusion for users.

I agree that requiring GDAL to use image heightmaps may be undesired, but when we have a geospatial component, I think it will be confusing for users that not all heightmap classes are in it, and some are actually in graphics.
The reason to add the geospatial component was to avoid adding that dependency to all graphics users, but we chose that name because we wanted the component to be semantically meaningful, and not just referent to a dependency. We need to draw the line at some point and inevitably some users will always get a bit more than they actually need. That's true for other ign-common components and other Ignition libraries too. Also note that all our "internal" users (that is, all Ignition libraries that will use this: rendering and physics) will support DEMs anyway.
I'm leaning towards being more semantically precise instead of trying to reduce the dependency surface for hypothetical users.

if users depend on the geospatial component, then they will get ImageHeightmap either way. I just wanted to point out that removing the currently functional heightmap classes from graphics will require migration action for downstream packages. If we proceed in this manner, then we need to update the migration guide to reflect this

I just wanted to point out that removing the currently functional heightmap classes from graphics will require migration action for downstream packages.

Ok, that's a good point, users currently depending on graphics would need to update to depend on geospatial.
At least this PR is targeting main. Ideally we'd tick-tock the change, but in this case I think it could get complicated.

I just wanted to point out that removing the currently functional heightmap classes from graphics will require migration action for downstream packages.

Ok, that's a good point, users currently depending on graphics would need to update to depend on geospatial.
At least this PR is targeting main. Ideally we'd tick-tock the change, but in this case I think it could get complicated.

so we should update the migration guide?

so we should update the migration guide?

That seems the most natural thing to me. When users update their find_package calls from comon4 to common5, they also need to add the geospatial component. I know it's not ideal, but some things are tough to tick-tock.

I have updated Migration.md 90e55a19f2616c8a19d880eb2193d5aee9b21625

I think this will require an update to https://github.com/ignition-release/ign-common5-release when it is merged

Please wait to merge, I may add a small update.


autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated.

autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler.

Hi @justinb-shipt @NehaShipt thanks for this PR, this update is really import has previous hpa version is no longer in kube.
How could I help this to be merged faster ? We really need this update too :-)
Kind regards,

It seems the CI is stuck in there. @NehaShipt by any chance, do you have power over it ? :-)

Hi @justinb-shipt  @NehaShipt thanks for this PR. Unfortunately, it doesn’t work due to breaking changes in the HPA structure in version 2. To address this, I’ve made a working PR here: #218 for the same issue.
Kind regards,


Fix (Pool) - Added way to LegalAddress to be Main Site Address in Pool

Description
Currently, it is not possible in the Pool for a legal address to be also a main site address at the same time. This PR adjust the way a Address is persisted if both Legal Entity and Site share it.
Related issues: #657
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@nicoprow Tested with the round trip, and it seems that its now associating both site and legalEntity to an address when the LegalAndSiteMainAddress is present on the AddressType.
I do have a question. Should also this logic apply when an update is done? so for example when type changes from SiteMainAddress to LegalAndSiteMainAddress, an association from both Site and Legal Entity to a single Address is done, with the deletion of the old persisted addresses. Thanks

@nicoprow Tested with the round trip, and it seems that its now associating both site and legalEntity to an address when the LegalAndSiteMainAddress is present on the AddressType.
I do have a question. Should also this logic apply when an update is done? so for example when type changes from SiteMainAddress to LegalAndSiteMainAddress, an association from both Site and Legal Entity to a single Address is done, with the deletion of the old persisted addresses. Thanks

For the update I would follow the same principle we have done before: The parent relationship between L/S/A business partners doesn't change

@nicoprow @alexsilva-CGI
We also need to think for the new endpoints which will do the same. In the current development there is no endpoint which we can use to create LegalEntity address as a SiteAddress.


Feature: Add ability to control zeplin overlay with Shift + arrow-keys

Hi @mertkahyaoglu! Awesome, repository!
This PR adds the ability to control overlay with Shift + Arrow keys. This ability might be helpful when you want to do pixel perfect.

Hey @mertkahyaoglu there's a failure in the netlify preview. Is it related to this PR?
1:12:12 PM: ERR! Module not found: Error: Can't resolve '../dist/register' in '/opt/build/repo/.storybook'
ERR! ModuleNotFoundError: Module not found: Error: Can't resolve '../dist/register' in '/opt/build/repo/.storybook'

@yannbf I think it was a cache issue. Now looks good.

Awesome addition! Thanks @lysenko-sergey-developer.


docfx and new .csproj

Cannot produce documentation because #26 uses the new .csproj format which docfx doesn't support

Following the work-around at https://github.com/dotnet/docfx/issues/1752#issuecomment-308909959 and then adding to docfx.json
"properties": {
  "TargetFramework": "net45"
},

we can get documentation generated!


k8s: assert that the watchers emit all existing resources at startup

Hello @nicks,
Please review the following commits I made in branch nicks/ch3277/list:
9c0fab812bc002366ced4d4d41ba85964995d5a8 (2019-09-05 13:28:52 -0400)
k8s: assert that the watchers emit all existing resources at startup

this is mostly just moving test code around


changes in matrixconnector/assetconnector & some bugfixes

-changes in matrixconnector & assetconnector, so that the label defined within the field is shown
-some minor bugfixes
-initial SettingsController (for clearing caches)
-graceful error handling for invalid json (in /workspace/elements/)

Made some changes to resolve conflicts. Don't know how to go on.... Do you need to resend your pull request? I pushed to pr5.

Is this done now?

Done


[Fancy Zones] Default setup for new monitor

Summary of the new feature/enhancement
New installation of PowerToys. When configuring a custom fancy zone for one screen, the other screen does not have any fancy zones configured. Seems to be independent of primary/secondary display.
Suggestion: When a display doesn't have any fancy zones available during dragging, the setup of another screen (priority: main screen, then using the numbers of the display) should be used.
Refs https://github.com/microsoft/PowerToys/issues/1945. Somehow refs https://github.com/microsoft/PowerToys/issues/611.

Hi @koppor
add your comment to https://github.com/microsoft/PowerToys/issues/4292
Closing this one.
Thanks.


Feature utility functions

Codecov Report

Merging #38 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines          918       941   +23
=========================================
+ Hits           918       941   +23

Impacted Files
Coverage Δ

src/zero_one/geni/ml.clj
100.00% <100.00%> (ø)

src/zero_one/geni/ml_feature.clj
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e5818...85da8ff. Read the comment docs.


Reland "ListTile Material Ripple and Shape Patch (#74373)"

Description
This reverts commit f8cd24de95b16b5a1ce6ebc0716154271fbf6252 in an attempt to re-land it.
There are no changes in this PR from flutter/flutter#74373, since it only failed Google internal tests, and we think that the solution involves updating those tests instead of changing this code.
/cc @NWalker1208

This change caused a regression in https://github.com/flutter/flutter/issues/86584