Fix SelectorAwareVirtualTopicInterceptor ClassCastException if next is not Topic.

next is not guaranteed  to be Topic. If there is plugin that injects another DestinationInterceptor, the code will fail with ClassCastException.
Added a method to correctly unwrap next.
Ran:

AMQ4899Test.java
VirtualTopicSelectorTest.java
JavaVirtualDestTest.java
SelectorAwareVTThatDropsMessagesWhenNoConsumer.java
TwoBrokerVirtualTopicSelectorAwareForwardingTest.java
to make sure there is no regression

What is the use case for this?

What is the use case for this?

you mean the use case of having a DestinationFilter after SelectorAwareVirtualTopicInterceptor?
I my case I add an interceptor to all topics. and that interceptor coexists with the rest of interceptors. and some topics can be vistual topics. it's technically possible on the plugin side to check if there is a virtual topic interceptor and not add my interceptor. But I checked other interceptors(this one for example) and they handle this situation correctly, so I thought it would be a positive change in general. In case people decide to do something similar in the future, they will not need to work around the edge case.

A couple of points:

This change needs to be a JIRA
This needs a unit test with an example configured w/ another DestinationFilter on top of Virtual Topic
If we are going to fix it, we should adapt all the Virtual Destinations to use the same set of methods.

1. This change needs to be a JIRA

Done. https://issues.apache.org/jira/browse/AMQ-9530

2. This needs a unit test with an example configured w/ another DestinationFilter on top of Virtual Topic

Updated VirtualTopicSelectorTest, as it's basically tests SelectorAwareVirtualTopicInterceptor. Also used it to initially reproduce the issue(see the ticket).

3. If we are going to fix it, we should adapt all the Virtual Destinations to use the same set of methods.

There are no issues like this in other pars of the Virtual Destination code. only in SelectorAwareVirtualTopicInterceptor

There are no issues like this in other pars of the Virtual Destination code. only in SelectorAwareVirtualTopicInterceptor

MappedQueueFilter has a nearly identical method:
ref: https://github.com/apache/activemq/blob/5309352e12c1d5f05c027331f49cc1caa6a62f2f/activemq-broker/src/main/java/org/apache/activemq/broker/region/virtual/MappedQueueFilter.java#L90

There are no issues like this in other pars of the Virtual Destination code. only in SelectorAwareVirtualTopicInterceptor

MappedQueueFilter has a nearly identical method:
ref:
https://github.com/apache/activemq/blob/5309352e12c1d5f05c027331f49cc1caa6a62f2f/activemq-broker/src/main/java/org/apache/activemq/broker/region/virtual/MappedQueueFilter.java#L90

are you proposing to extract this method to a helper class? If I create a new class, let's say VirtualTopicSupport or VistualTopicHelper, will it be okay? or do you have a particular place in mind fir it?

Yes, a base class that contains the lookup method to unwrap the destination to get to the root (real) destination that can be used by VirtualTopic and MappedQueueFilter.
ie BaseVirtualDestination(Inteceptor|Filter)

Yes, a base class that contains the lookup method to unwrap the destination to get to the root (real) destination that can be used by VirtualTopic and MappedQueueFilter.
ie BaseVirtualDestination(Inteceptor|Filter)

sounds good! done

FYI, in some contexts, the VirtualConsumerDemandTest can be stuck. It's not related to this PR (known issue).

This type of internal broker plugin and extension points (API/SPI) change should happen in a minor release 6.2.x and not a minor release.

@mattrpav as it's a bug fix, I think it's ok for have it on all active branches.


[FIX] XML View: case sensitivity in binding

Binding should be binding. XML documents are case sensitive.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: boghyon:x: OlMueYou have signed the CLA already but the status is still pending? Let us recheck it.


CUDA error 9

I benchmarking with your code. I have
const int sz1 = 102400, sz2 = 16, nClusters = 10;

If i try to increase sz1 to 1024000 im getting
terminate called after throwing an instance of 'std::runtime_error'
what():  CUDA error 9 at kMeansCuda.cu:604
Device 0: "GeForce GT 430"
  CUDA Driver Version / Runtime Version          6.5 / 6.5
  CUDA Capability Major/Minor version number:    2.1
  Total amount of global memory:                 1024 MBytes<PHONE_NUMBER> bytes)
  ( 2) Multiprocessors, ( 48) CUDA Cores/MP:     96 CUDA Cores
  GPU Clock rate:                                1460 MHz (1.46 GHz)
  Memory Clock rate:                             900 Mhz
  Memory Bus Width:                              128-bit
  L2 Cache Size:                                 131072 bytes
  Maximum Texture Dimension Size (x,y,z)         1D=(65536), 2D=(65536, 65535), 3D=(2048, 2048, 2048)
  Maximum Layered 1D Texture Size, (num) layers  1D=(16384), 2048 layers
  Maximum Layered 2D Texture Size, (num) layers  2D=(16384, 16384), 2048 layers
  Total amount of constant memory:               65536 bytes
  Total amount of shared memory per block:       49152 bytes
  Total number of registers available per block: 32768
  Warp size:                                     32
  Maximum number of threads per multiprocessor:  1536
  Maximum number of threads per block:           1024
  Max dimension size of a thread block (x,y,z): (1024, 1024, 64)
  Max dimension size of a grid size    (x,y,z): (65535, 65535, 65535)
  Maximum memory pitch:<PHONE_NUMBER> bytes
  Texture alignment:                             512 bytes
  Concurrent copy and kernel execution:          Yes with 1 copy engine(s)
  Run time limit on kernels:                     Yes
  Integrated GPU sharing Host Memory:            No
  Support host page-locked memory mapping:       Yes
  Alignment requirement for Surfaces:            Yes
  Device has ECC support:                        Disabled
  Device supports Unified Addressing (UVA):      Yes
  Device PCI Bus ID / PCI location ID:           1 / 0
  Compute Mode:
     < Default (multiple host threads can use ::cudaSetDevice() with device simultaneously) >

deviceQuery, CUDA Driver = CUDART, CUDA Driver Version = 6.5, CUDA Runtime Version = 6.5, NumDevs = 1, Device0 = GeForce GT 430
Result = PASS

Sorry @BenjaminHorn, I didn't see this until now.
CUDA error 9 means invalid configuration. I think the problem is that your CUDA device is pretty old. It has only 96 cores, and some of the configuration rules in the code somehow request a big value for the grid size and block size, which can't be fulfilled by your device.
I will recommend you to upgrade your GPU to something more recent. Or if you don't have that plan, I can show you where to change those parameters so it can be run on your device.
Are you still interested in this?

@phvu Although I moved to C++ cluster computing, I'm still interested. Maybe I will give a new try to GPU kmeans.

@phvu, I was tying to use it for clustering image with 15 channels.
So, each pixel is described by a 15 dimensional feature vector.
Compiled successfully. But while running, faced some similar issue as reported by @BenjaminHorn,
terminate called after throwing an instance of 'std::runtime_error'
what():  CUDA error 9 at kmeans_cuda-master/kMeansCuda.cu:388
Aborted (core dumped)
Your guidance very much required; kindly suggest changes.

@MAS-IITKGP can you post the output of nvidia-smi here? Thanks.

Please find the put put of nvidia-smi below:
Tue Aug 18 11:47:35 2015
+------------------------------------------------------+
| NVIDIA-SMI 331.75     Driver Version: 331.75         |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  Tesla K20m          Off  | 0000:90:00.0     Off |                    0 |
| N/A   45C    P0    47W / 225W |    490MiB /  4799MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Compute processes:                                               GPU Memory |
|  GPU       PID  Process name                                     Usage      |
|=============================================================================|
|    0      9858  /home/mt1/13CS60R34/work_new/cvtst2c                 252MiB |
|    0     13144  /home/mt1/13CS60R34/work_new/cvtst2c                 222MiB |
+-----------------------------------------------------------------------------+
I didn't get it though!

Looks like you have a decent GPU. Probably you should check the logic in computing the grid dimension and block dimension on kMeansCuda.cu:578 and kMeansCuda.cu:334
Btw, how big is your original matrix? What are the dimensions?
The implementation in this project will copy all the data to GPU first. Therefore you need enough GPU memory to hold the data, otherwise it won't work.
This can be fixed by switching to mini-batch k-means, we only copy a few batches to the GPU at every iteration. I would be grateful if you could improve that aspect.


display after refresh

Add cookies to all display changes so after refresh or next login displays or settings stay the same as you left them.
also city view, center, center of city view to center of screen, atm it aligns top left corner, if you are set to zoom out, city view aligns top left of screen after city change

Great idea!


Send E-mail Does Not Work in vCheck.ps1

The vCheck script finishes but I get an error when it tries creating the output file and shows this error Out-File : The given path's format is not supported.
see full error message below...
[13:56:51] ..start calculating Disconnecting from vCenter by Alan Renouf v1.1 [106 of 106]
[13:56:51] ..finished calculating Disconnecting from vCenter by Alan Renouf v1.1 [106 of 106]
Out-File : The given path's format is not supported.
At C:\scripts\vCheck\vCheck.ps1:767 char:16

$embedReport | Out-File -encoding ASCII -filepath $Filename

           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OpenError: (:) [Out-File], NotSupportedException
FullyQualifiedErrorId : FileOpenFailure,Microsoft.PowerShell.Commands.OutFileCommand

[13:56:54] ..Displaying HTML results
Invoke-Item : Cannot find path 'C:\Users\jarzynka\AppData\Local\Temp\4\natty.ad.salk.edu:443_vCheck_16-12-2015.htm' because it does
not exist.
At C:\scripts\vCheck\vCheck.ps1:772 char:4

Invoke-Item $Filename

+ CategoryInfo          : ObjectNotFound: (C:\Users\jarzyn..._16-12-2015.htm:String) [Invoke-Item], ItemNotFoundException
+ FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.InvokeItemCommand

[13:56:54] ..Sending Email
Exception calling "Send" with "1" argument(s): "The operation has timed out."
At C:\scripts\vCheck\vCheck.ps1:818 char:4

$smtpClient.Send($msg)

+ CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : SmtpException

PowerCLI C:\scripts\vCheck>

Ah, looks like you have specified a port (which is irrelevant since 443 is the default), which is likely what has broken it. We're probably using the wrong variable name in vCheck.ps1...

OK, this is fixed in the dev branch but I've pushed a fix to master as well. Download the latest vCheck.ps1 and this should be OK.

ok its working now but I get a new error when it actually tries to send the email
[15:36:39] ..Sending Email
Exception calling "Send" with "1" argument(s): "The operation has timed out."
At C:\scripts\vCheck\vCheck.ps1:818 char:4

$smtpClient.Send($msg)

+ CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : SmtpException

ok its working now but I get a new error when it actually tries to send the email
[15:36:39] ..Sending Email
Exception calling "Send" with "1" argument(s): "The operation has timed out."
At C:\scripts\vCheck\vCheck.ps1:818 char:4

$smtpClient.Send($msg)

CategoryInfo : NotSpecified: (:) [], MethodInvocationException

FullyQualifiedErrorId : SmtpException

From: Sneddo<EMAIL_ADDRESS>Sent: Wednesday, December 16, 2015 3:11 PM
To: alanrenouf/vCheck-vSphere<EMAIL_ADDRESS>Cc: surfingcaliforniacoastline<EMAIL_ADDRESS>Subject: Re: [vCheck-vSphere] Send E-mail Does Not Work in vCheck.ps1 (#433)
OK, this is fixed in the dev branch but I've pushed a fix to master as well. Download the latest vCheck.ps1 and this should be OK.
—
Reply to this email directly or view it on GitHub https://github.com/alanrenouf/vCheck-vSphere/issues/433#issuecomment-165277986 .  https://github.com/notifications/beacon/APklAoh73vRjK5N8SeyyWzXdcUgmD8dkks5pQecEgaJpZM4G26YA.gif

I downloaded the latest master vCheck.ps1 but it still is not sending.
[09:17:35] ..finished calculating Disconnecting from vCenter by Alan Renouf v1.1 [105 of 105]
[09:17:38] ..Sending Email
Exception calling "Send" with "1" argument(s): "The operation has timed out."
At C:\scripts\vCheck\vCheck.ps1:818 char:4

$smtpClient.Send($msg)

+ CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : SmtpException

I downloaded the latest master vCheck.ps1 but it still is not sending.
[09:17:35] ..finished calculating Disconnecting from vCenter by Alan Renouf v1.1 [105 of 105]
[09:17:38] ..Sending Email
Exception calling "Send" with "1" argument(s): "The operation has timed out."
At C:\scripts\vCheck\vCheck.ps1:818 char:4

$smtpClient.Send($msg)

CategoryInfo : NotSpecified: (:) [], MethodInvocationException

FullyQualifiedErrorId : SmtpException

From: Sneddo<EMAIL_ADDRESS>Sent: Wednesday, December 16, 2015 3:10 PM
To: alanrenouf/vCheck-vSphere<EMAIL_ADDRESS>Cc: surfingcaliforniacoastline<EMAIL_ADDRESS>Subject: Re: [vCheck-vSphere] Send E-mail Does Not Work in vCheck.ps1 (#433)
Closed #433 https://github.com/alanrenouf/vCheck-vSphere/issues/433  via  https://github.com/alanrenouf/vCheck-vSphere/commit/1bedfb2522572d79f7ad124964cc6ac069fa751f 1bedfb2.
—
Reply to this email directly or view it on GitHub https://github.com/alanrenouf/vCheck-vSphere/issues/433#event-494085733 .  https://github.com/notifications/beacon/APklAusGV4xe_nnCDwoGOOSPcUsCfbY3ks5pQebZgaJpZM4G26YA.gif

Have a look at your SMTP server to see why it is timing out.

I checked the logs and it never connects to my SMTP server –
This is our production SMTP server and we have lots of other scripts that relay mail through it.
Its as if it doesn’t try sending to my SMTP server.
I also ran a Send-MailMessage test from the server via powershell to verify I can send an email with attachment and it worked.
Send-MailMessage -To<EMAIL_ADDRESS>-From<EMAIL_ADDRESS>-SMTPServer helix.salk.edu -Subject “Daily report” -Body “Attached file has details of Natty vCenter” -Attachments “C:\Users\jarzynka\AppData\Local\Temp\4\vCheck.html”
Here are my global variables  settings:
You can change the following defaults by altering the below settings:

Set the following to true to enable the setup wizard for first time run
$SetupWizard = $False
Start of Settings
Report header
$reportHeader = "vCheck"
Would you like the report displayed in the local browser once completed ?
$DisplaytoScreen = $false
Display the report even if it is empty?
$DisplayReportEvenIfEmpty = $true
Use the following item to define if an email report should be sent once completed
$SendEmail = $true
Please Specify the SMTP server address (and optional port) [servername(:port)]
$SMTPSRV = "helix.salk.edu"
Would you like to use SSL to send email?
$EmailSSL = $false
Please specify the email address who will send the vCheck report
$EmailFrom =<EMAIL_ADDRESS>Please specify the email address(es) who will receive the vCheck report (separate multiple addresses with comma)
$EmailTo =<EMAIL_ADDRESS>Please specify the email address(es) who will be CCd to receive the vCheck report (separate multiple addresses with comma)
$EmailCc = ""
Please specify an email subject
$EmailSubject = "$Server vCheck Report"
Send the report by e-mail even if it is empty?
$EmailReportEvenIfEmpty = $true
If you would prefer the HTML file as an attachment then enable the following:
$SendAttachment = $true
Set the style template to use.
$Style = "CleanGreen"
Do you want to include plugin details in the report?
$reportOnPlugins = $true
List Enabled plugins first in Plugin Report?
$ListEnabledPluginsFirst = $true
Set the following setting to $true to see how long each Plugin takes to run as part of the report
$TimeToRun = $true
Report on plugins that take longer than the following amount of seconds
$PluginSeconds = 30
End of Settings
End of Global Variables
From: Sneddo<EMAIL_ADDRESS>Sent: Thursday, December 17, 2015 4:08 PM
To: alanrenouf/vCheck-vSphere<EMAIL_ADDRESS>Cc: surfingcaliforniacoastline<EMAIL_ADDRESS>Subject: Re: [vCheck-vSphere] Send E-mail Does Not Work in vCheck.ps1 (#433)
Have a look at your SMTP server to see why it is timing out.
—
Reply to this email directly or view it on GitHub https://github.com/alanrenouf/vCheck-vSphere/issues/433#issuecomment-165620739 .  https://github.com/notifications/beacon/APklAvowMD00E53zKX7ZO5R3HQtnCDrIks5pQ0XdgaJpZM4G26YA.gif


Builtin.assume_Int1 does not access memory.

Upcoming verification will catch this.

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - 25bb1909ab4d4b3be674a8cda3681ecad92006c0

Build failed
Swift Test Linux Platform
Git Sha - 25bb1909ab4d4b3be674a8cda3681ecad92006c0

SILCombine removes this Builtin if it's readnone. I don't want to invent a new flow-dependent attribute right now, so I'll just treat Builtin.assume as a memory access even though it defeats other optimizations.


spelling fixes and americanisms

Found & corrected with https://github.com/lukeapage/node-markdown-spellcheck

Learnt the difference between grey and gray. :+1:

@zcbenz On the topic of Americanisms, 'Learnt' or 'learned' :smile:


Action table username field not filled out

Action table should fill in the username field for EVERY actions initiated from an OAuth API call since there's an okta login associate with every requests.
Ideally, the lowest level code would just extract the username from the auth token and put into into the action row entry instead of requiring it be drill down through layers?

@arnejduranovic Please groom.


FakeFS doesn't create

Please see this video for understanding better: https://youtu.be/w8ckbhhfqJA

same, but i use palera1n in linux CLI

if you booted from virtual disk, you had better boot palen1x in hard disk, palera1n needs like 1gb for creating

In fact I have used a normal computer, not a Virtual Machine

still not working, and got stuck in pongo OS bot , after each minute then booting in IOs but Palera1n loader is none


Any support for Transformer with tabular timeseries 3D inputs?

I used deepExplainer for explaining a pytorch-implemented classification model(basically multiple layers of transformer encoders succeeded by a classifier). My data is tabular timeseries in the shape of (sample, time_step, features). Note that the time sequence samples have various lengths and the model pads them into same length, and mask out the padded part in the attention mechanism.
My code runs well(though very very slow), but the calculated shapley values sums up to a wrong value:
explainer = shap.DeepExplainer(model, X)
shap_values = explainer.shap_values(X)

sample_no = 1 # test the calculated shapley value validity on a random sample # x
class = 0# say binary classification and there is a two-dimension output
pred_val = predp_for_sample = model(X_test)[sample_no][pred] # f(x)
shapley_sum_on_timestepNfeatures = shap_values[pred][sample_no].sum() #\sum of phi_i
expected_val = expected_value[pred] # phi_0

it turns out shapley_sum_on_timestepNfeatures + expected_val doesn't approximate to pred_val, which means the calculated shapley value on transformer is invalid.
I then looked into the shapley value, I found that the padded timesteps are also assigned shapeley values(supposed to be 0). It suggest that the my way of calling SHAP API is not capable of dealing with the masking mechanism in  Transformer.

is there any way I'm doing it wrong? any correct api usage that I can use to do my task?
if SHAP is currently not supporting transformer with various-length tabular timeseries inputs, any other efficient explainable models/algorithms I can look into?
If I want to modified SHAP for my own use, any support document or tutorial I can look into?

Sorry for the late, late reply. Could you provide a reproducible example for this? Otherwise it's very hard for us to look into this.


Clothing cosmetic invisible when worn

I can't get my personal pants mod to appear on my character. It shows that I am wearing it, but it is not visible on my character.

I think I solved the problem. I was using the old rig for the avatar, so the game was looking for the wrong bones. Using the new rig, and transferring the bone weight in blender fixed it.


Replace "@" convention with "at-" or "on-"

Stylus requires three escaped characters to use the @ simple as a CSS selector.  Because of this, it might be more practical to just replace it with at- or on-.  This still serves the purpose of denoting a location or context while removing the need of escaping a simple all together.
// this
.\\\@location

// becomes this
.at-location

// or this
.on-location

Due to various changes, this is no longer an issue.


Configure the content-header of template

| Question                | Answer
| ----------------------- | [-----------------------]
| Issue or Enhancement    | Enhancement
| License                 | MIT
What's in this PR?
Allowing you to generate or not a content-header, thus allowing at 1024x768 resolutions gains more screen space,
Checklist

[x] I tested these changes.

a

@warquia what classes did you have added to the new config option you have created to get from picture 1 to picture 2. If the goal is to not shown the content-header when the section is not used, we can do like next:
{{-- Content Header --}}
@hasSection('content-header')

            @yield('content_header')

@endif

Also, note when you do:

the default value will only be used when the configuration option do not exists. So, when defining the option to null it will inject a null on the class and may result on undesired behavior. You can read laravel docs for details. For this case, I believe it will be better to use:

Good morning everyone, really has-section is the best approach, I will correct the pull-request with your analysis.
By the way, I'm new to git so I'm going to send this pull in master yet but next time I'll follow the guidance using a branch
Thank you all

@resslinger @warquia This PR is ok for me now...


Treat absent instances as terminated in GCP

After terminating an instance, it will no longer be listed in
EmsRefresh#refresh calls. Ensure that a missing instance in Google Cloud
Platform is treated as 'terminated' rather than 'unknown'.
https://bugzilla.redhat.com/show_bug.cgi?id=1335881

/cc @agrare @erjohnso @blomquisg

@selmanj looks like you need to update the spec test that is currently looking for "off"
https://travis-ci.org/ManageIQ/manageiq/jobs/132676864#L1063

@agrare Thanks for your help.  Spec should now be passing (the test was correct and caught a legit bug)

There was some confusion on the original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1335881.  It turns out that the current behavior is actually correct; while the power state code might be confusing (and might benefit from some refactoring), the actual behavior as currently implemented is correct.
In that case i'm closing this PR.


transient 400 errors cannot be re-applied

bossman apply does not try to re-apply a version it has already applied when the previous application failed with a bad request error, which is usually associated with rule tree validation errors. This normally makes sense because a validation error should really be fixed in a new commit.
Some 400 errors are transient, and should be retry-able. For example:
> bossman apply --force example_prop
⬆ build/akamai/property/example_prop [ffb7e0bd] "Merge branch 'integration'" John Doe
PAPIHostnamesValidationError
clientIp: xxxxxxxxx
detail: Invalid timestamp
instance: https://xyz.luna.akamaiapis.net/papi/v1/properties/prp_xxxxxxx/versions/17/hostnames
method: PUT
requestId: 55cb08a
requestTime: '2022-01-05T09:08:49Z'
serverIp: xxxxxxxxxxxxxxx
status: 400
title: Bad request
type: https://problems.luna.akamaiapis.net/-/pep-authn/request-error

Because this is a 400 error, bossman annotates the resource with a git note that says an error occurred, forcing us to either create a new commit, or hack the notes directly:
git fetch origin '+refs/notes/build/akamai/property/*:refs/notes/build/akamai/property/*'
git fetch --all
git notes --ref=refs/notes/build/akamai/property/example_property remove HEAD
git push origin '+refs/notes/build/akamai/property/example_property:refs/notes/build/akamai/property/example_property'

probably won't fix this, identifying retryable errors seems tricky

having found a way, it's worth doing


[Question] Is a PAL support planned?

I have an hacked wii witch doesn't support NTSC and only support PAL so my question is Have you planned a PAL support for randomizer?

Do you have usb loading setup on your wii? Since region unlock isnt required there and can run a rando iso anyway

Ok I didn't know usb loaders can bypass regions restrictions. But my iso is a copy of my original disc witch is a PAL version so I can't create randomized iso.

Ah yeah that's a problem. we can't give you a NTSC-U 1.0 iso so you'd have to somehow obtain one yourself

Due to version differences (the clip in ancient cistern, but also differences in various internal files) there are no plans to make a PAL version of the randomizer. However, I do want to make the randomizer work with other versions by simply patching them to NTSC 1.0. I'll make a separate issue for that


[Bug]: Gitea Webhook fails - Invalid signature

Error Message and Logs
[{"application":"resource-frontend","status":"failed","message":"Invalid signature."}]

Steps to Reproduce

Set a secret key in the Gitea Webhook Secret input field.
Go to your repository in Gitea and open the Repository Settings / Webhooks menu as Repository hooks.
Add the URL from Coolify to the URL input field and the secret token.
Select the Push option.
That’s it! Test Webhook and get "Invalid signature."

Example Repository URL
No response
Coolify Version
v4.0.0-beta.360
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
Debian 12
Additional Information
No response

Getting the same issue on bitbucket

Same here.
The issue seems to raise if two apps from same repo exist (e.g. auto deploy on push dev/prod).
In case of Gitlab this is the affecting code: https://github.com/coollabsio/coolify/blob/5d62a46a16f252e6ece4d25fe56838e99883d91b/app/Http/Controllers/Webhook/Gitlab.php#L113C1-L113C90
Would try to open a PR if i find time the next days.
Another thing: It seems to be no validation check in place against empty tokens? So its possible to push without any kind of auth (need to find domain/ip, routes (in the docs), and repo name (Maybe not to easy but still not impossible). Just stumbled over it while reading the code. will investigate further later.

Another thing: It seems to be no validation check in place against empty tokens? So its possible to push without any kind of auth (need to find domain/ip, routes (in the docs), and repo name (Maybe not to easy but still not impossible). Just stumbled over it while reading the code. will investigate further later.

So on fresh installs, someone could deploy with just little info as:
#Headers
Content-Type: application/json
X-Gitlab-Token:

#Payload
{
  "object_kind": "push",
  "event_name": "push",
  "ref": "refs/heads/main",
  "project": {
    "path_with_namespace": "<user>/<repo-name>",
    "url": "git@gitlab.com:<user>/<repo-name>.git",
    "http_url": "https://gitlab.com/<user>/<repo-name>.git"
  },
  "commits": [
    {
      "added": [],
      "modified": [],
      "removed": []
    }
  ],
  "total_commits_count": 1,
  "push_options": {
  },
  "repository": {
    "url": "git@gitlab.com:<user>/<repo-name>.git",
    "git_http_url": "https://gitlab.com/<user>/<repo-name>.git",
    "visibility_level": 0
  }
}


Make last_published_at filterable

This PR makes Page.last_published_at filterable along with first_published_at and other basic fields from the Page model.

Merged in ddb0665f79fe7e6cea849230cfc6f391278bc358 - thanks @m1kola!


Add golang1.19

Add the container definitions for golang1.19

Please add GO_1_19_CONTAINER to CONTAINERS_WITH_ZYPPER and adjust test_metadata.py as well.

Done.

@grisu48 Can you please rebase on main?

Rebased

Thank you! :slightly_smiling_face:


fix: update plural resolver map

PR Summary
Commit 65d5833246652f194e4b2bea01bb48aa0664b34b moved the location of plural_resolver_map.dart. This PR adjusts sources to changes.

Thanks


Add the ability to operate based on "IDC release index" in place of IDC API

This should significantly simplify the code, significantly reduce the latency for UI interactions, and will be zero-cost.

@vkt1414 to start with this, I would experiment locally, and work on adding an option to IDCClient to work with the index instead of API. You may need to install pandas - I am not sure it is available in the Slicer package - you can do it with slicer.util.pip_install("pandas").

TODO:

[ ] add handling of index updates

It is not clear at this point if we should/can handle index updates, since the content of the index and API of the package may not yet be fixed and stable across releases. Will consider this after we get some more progress on development and user feedback. For now, once idc-index is installed, it will not be updated, and if it has to be updated, extension itself will need to be updated, so we will handle this via extension update process.


Add a *.pyi file for auto-completion & hints.

Description

To enable auto-completion and hints in code editors such as VScode, create a *.pyi file. This feature is compatible with python 3.9 and later versions.
Where has this been tested?

Platform(s): Windows Desktop ...
Python version(s): 3.9.10 ...
Unreal Engine version(s): ...

Possible Drawbacks

It might be incompatible with python 3.8 or earlier versions.

So far it works with Python 3.7 without greater issues, but only looked into some small aspects. (Thanks a lot btw.!)

Completed the last todos, and added further fixes as well as a changelog to my pull request on @Minokori's branch.
In my opinion afterwards its ready to merge

Todo: FutureActor currently undocumented class; see #7236

Hey @Minokori All PRs must be against dev, could you correct this please?

If this PR does not go against dev we will need to close it and reject it

I've now opened a rebased and merged PR combining @Minokori and my version. Of course we should prefer Minokori's PR but as it has been kind of stale I now decided to open an up-to-date alternative with #7787 as long as this PR here is not maintained further. I hope this is fine with you all.


Add CF Dataspace specification

Add specification for the CF Dataspace and update the README.

👍 I reviewed the docs and it looks good to me.


Cannot get csrf_token from instagram.com

Describe the bug
Hello everyone, csrf_token is a value that you can find inside the page source of the Instagram website, you can simply find it by performing a GET request to  https://www.instagram.com then using a simple regex on the returned HTML code.
It's important because it's used as a header value (X-CSRFToken) which needed for login and challenge requests.
So here is my issue: using capacitor http plugin somehow doesn't return that value at all!
To Reproduce
So here is exactly what I did: on browser and node, I was able to use fetch to get csrf_token without any problem:
Here is the code: fetch('https://www.instagram.com/').then(async res => console.log(JSON.stringify(await res.text()).match(/csrf_token.{40}/)[0]))
browser (same origin):

node (node-fetch module):

But, on capacitor using this plugin:

code (executed on eruda console): Http.request({ method: 'GET', url: 'https://www.instagram.com/'}).then(res => console.log(JSON.stringify(res.data).match(/csrf_token.{40}/)[0]))
Expected behavior
It only gives an empty object instead, it should gives a string.
Desktop (please complete the following information):

OS: windows 10.
Browser: tested on opera and icedragon.
Version: least for both.

Smartphone (please complete the following information):

Device: LD Player Android Emulator.
OS: Android 7.1.2.
Browser: Android Webview (capacitor).
Version: I'm not sure.

Additional context
I think Instagram detects requests from this plugin as automated requests, so it hides the value to prevent bots/custom clients from login.

Update: I fixed it, the reason was a stored cookie called "csrf_token" has the value "{}".
Now I'll close this issue.


Update Set-CsBackupServiceConfiguration.md

New parameter added  as "EnableRgsBackupService"

Docs Build status updates of commit c5a7d8a:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hirenshah1 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Docs Build status updates of commit c5a7d8a:
:clock10: Full build: the average full build time is 12 min(s) 13 sec(s), this is based on the last 590 build(s) for this repository.

Docs Build status updates of commit c5a7d8a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsBackupServiceConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d68664d:
:clock10: Full build: the average full build time is 12 min(s) 9 sec(s), this is based on the last 614 build(s) for this repository.

Docs Build status updates of commit d68664d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsBackupServiceConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9dfc41c:
:clock10: Full build: the average full build time is 12 min(s) 2 sec(s), this is based on the last 675 build(s) for this repository.

Docs Build status updates of commit 9dfc41c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsBackupServiceConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


update macros.xml and maxquant.xml

@bgruening
I have updated the macros.xml and maxquant.xml file on the top of the @npinter latest fix. In brief, I updated the version of Maxquant from <IP_ADDRESS> to <IP_ADDRESS> , updated the pyyaml version and added the dotnet as part of the requirement section. Everything is looking good now.
Best

@mthang thanks a lot. Can you please look at the failing tests?

Its still failing @mthang :(

Hopefully this updated maxquant works @bgruening

Still fails unfortunately. Are you using planemo test --biocontainers?

@bgruening I just used planemo test --update_test_data --galaxy_root=/path/to/my/local/galaxy_21.05 maxquant.xml . Nothing fancy.

Have a look at @bernt-matthias comment. You need to adopt the test data properly. And running them in containers as here on CI night also help.

@mthang: please run tests with:
planemo test --biocontainers --no_dependency_resolution --no_conda_auto_init --galaxy_branch release_23.0 --galaxy_python_version 3.7 --test_timeout 900 --no_cleanup tools/maxquant/

Seemst that for maxquant_mqpar the parameter file needs an update. If updating the separate files in test-data is to much work I can also live with it as long as it survives at least to planemo test rounds. The first test times ou on CI because it needs to much time to build the container. Maybe you can double check if all requirements are needed. Alternatively we can build the container first in the multi-package container repo to make tests run through over here.

Closing in favor of https://github.com/galaxyproteomics/tools-galaxyp/pull/716


Humble: Speed scaling interface not found in hardware interface[bug]

hello, recently, i tried to test the driver using URsim,  I follow the step as below:

External control-1.0.5.urcap was successfully installed and external_control was created and loaded;
Run the command "ros2 launch ur_robot_driver ur_control.launch.py ur_type:=ur10 robot_ip:=<IP_ADDRESS> use_fake_hardware:=false launch_rviz:=false"
ros2 launch ur_moveit_config ur_moveit.launch.py ur_type:=ur10
Expected behaviour
use moveit to plan and execute the trajectory

Actual behaviour
Planed to a goal successfully but trajecory exectution failed for controller is not running
controller status:
force_torque_sensor_broadcaster[force_torque_sensor_broadcaster/ForceTorqueSensorBroadcaster] active
speed_scaling_state_broadcaster[ur_controllers/SpeedScalingStateBroadcaster] active
io_and_status_controller[ur_controllers/GPIOController] active
joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active
forward_position_controller[position_controllers/JointGroupPositionController] inactive
scaled_joint_trajectory_controller[ur_controllers/ScaledJointTrajectoryController] inactive
Node information
[INFO] [launch]: All log files can be found below /home/luo/.ros/log/2022-07-25-09-03-41-382979-luo-virtual-machine-49677
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [dashboard_client-2]: process started with pid [49682]
[INFO] [controller_stopper_node-3]: process started with pid [49684]
[INFO] [ur_ros2_control_node-1]: process started with pid [49680]
[INFO] [robot_state_publisher-4]: process started with pid [49686]
[INFO] [spawner-5]: process started with pid [49688]
[INFO] [spawner-6]: process started with pid [49690]
[INFO] [spawner-7]: process started with pid [49692]
[INFO] [spawner-8]: process started with pid [49694]
[INFO] [spawner-9]: process started with pid [49696]
[INFO] [spawner-10]: process started with pid [49738]
[controller_stopper_node-3] [INFO] [1658711021.992582544] [Controller stopper]: Waiting for switch controller service to come up on controller_manager/switch_controller
[ur_ros2_control_node-1] [INFO] [1658711022.013697486] [resource_manager]: Loading hardware 'ur10'
[robot_state_publisher-4] Link base_link had 2 children
[ur_ros2_control_node-1] [INFO] [1658711022.017282529] [resource_manager]: Initialize hardware 'ur10'
[ur_ros2_control_node-1] [INFO] [1658711022.017477401] [resource_manager]: Successful initialization of hardware 'ur10'
[ur_ros2_control_node-1] [INFO] [1658711022.017798714] [resource_manager]: 'configure' hardware 'ur10'
[ur_ros2_control_node-1] [INFO] [1658711022.017819880] [resource_manager]: Successful 'configure' of hardware 'ur10'
[ur_ros2_control_node-1] [INFO] [1658711022.017864325] [resource_manager]: 'activate' hardware 'ur10'
[ur_ros2_control_node-1] [INFO] [1658711022.017881527] [URPositionHardwareInterface]: Starting ...please wait...
[ur_ros2_control_node-1] [INFO] [1658711022.017934061] [URPositionHardwareInterface]: Initializing driver...
[robot_state_publisher-4] Link base had 0 children
[ur_ros2_control_node-1] Warning: No realtime capabilities found. Consider using a realtime system for better performance
[ur_ros2_control_node-1]          at line 396 in ./include/ur_client_library/comm/pipeline.h
[robot_state_publisher-4] Link base_link_inertia had 1 children
[robot_state_publisher-4] Link shoulder_link had 1 children
[robot_state_publisher-4] Link upper_arm_link had 1 children
[robot_state_publisher-4] Link forearm_link had 1 children
[robot_state_publisher-4] Link wrist_1_link had 1 children
[robot_state_publisher-4] Link wrist_2_link had 1 children
[robot_state_publisher-4] Link wrist_3_link had 2 children
[robot_state_publisher-4] Link flange had 1 children
[robot_state_publisher-4] Link tool0 had 0 children
[robot_state_publisher-4] Link ft_frame had 0 children
[robot_state_publisher-4] [INFO] [1658711022.024026949] [robot_state_publisher]: got segment base
[robot_state_publisher-4] [INFO] [1658711022.024407196] [robot_state_publisher]: got segment base_link
[robot_state_publisher-4] [INFO] [1658711022.024443632] [robot_state_publisher]: got segment base_link_inertia
[robot_state_publisher-4] [INFO] [1658711022.024458150] [robot_state_publisher]: got segment flange
[robot_state_publisher-4] [INFO] [1658711022.024471130] [robot_state_publisher]: got segment forearm_link
[robot_state_publisher-4] [INFO] [1658711022.024482735] [robot_state_publisher]: got segment ft_frame
[robot_state_publisher-4] [INFO] [1658711022.024494310] [robot_state_publisher]: got segment shoulder_link
[robot_state_publisher-4] [INFO] [1658711022.024505878] [robot_state_publisher]: got segment tool0
[robot_state_publisher-4] [INFO] [1658711022.024517595] [robot_state_publisher]: got segment upper_arm_link
[robot_state_publisher-4] [INFO] [1658711022.024529181] [robot_state_publisher]: got segment world
[robot_state_publisher-4] [INFO] [1658711022.024540287] [robot_state_publisher]: got segment wrist_1_link
[robot_state_publisher-4] [INFO] [1658711022.024551768] [robot_state_publisher]: got segment wrist_2_link
[robot_state_publisher-4] [INFO] [1658711022.024563718] [robot_state_publisher]: got segment wrist_3_link
[spawner-8] [INFO] [1658711022.303116557] [spawner_force_torque_sensor_broadcaster]: Waiting for '/controller_manager' services to be available
[spawner-7] [INFO] [1658711022.306384320] [spawner_speed_scaling_state_broadcaster]: Waiting for '/controller_manager' services to be available
[spawner-6] [INFO] [1658711022.321547808] [spawner_io_and_status_controller]: Waiting for '/controller_manager' node to exist
[spawner-5] [INFO] [1658711022.338579298] [spawner_joint_state_broadcaster]: Waiting for '/controller_manager' services to be available
[spawner-9] [INFO] [1658711022.348122629] [spawner_forward_position_controller]: Waiting for '/controller_manager' node to exist
[spawner-10] [INFO] [1658711022.394528354] [spawner_scaled_joint_trajectory_controller]: Waiting for '/controller_manager' services to be available
[ur_ros2_control_node-1] [INFO] [1658711023.132530896] [URPositionHardwareInterface]: Calibration checksum: 'calib_17227329492635474227'.
[ur_ros2_control_node-1] Warning: No realtime capabilities found. Consider using a realtime system for better performance
[ur_ros2_control_node-1]          at line 396 in ./include/ur_client_library/comm/pipeline.h
[ur_ros2_control_node-1] [INFO] [1658711024.193596505] [URPositionHardwareInterface]: Calibration checked successfully.
[ur_ros2_control_node-1] Error:   Unsuccessful in setting producer thread realtime priority. Error code: 1
[ur_ros2_control_node-1]          at line 366 in ./include/ur_client_library/comm/pipeline.h
[ur_ros2_control_node-1] Error:   Producer thread: Scheduling is NOT SCHED_FIFO!
[ur_ros2_control_node-1]          at line 379 in ./include/ur_client_library/comm/pipeline.h
[ur_ros2_control_node-1] [INFO] [1658711024.195378789] [URPositionHardwareInterface]: System successfully started!
[ur_ros2_control_node-1] [INFO] [1658711024.195426192] [resource_manager]: Successful 'activate' of hardware 'ur10'
[controller_stopper_node-3] [INFO] [1658711024.226306713] [Controller stopper]: Service available
[controller_stopper_node-3] [INFO] [1658711024.226424220] [Controller stopper]: Waiting for list controllers service to come up on controller_manager/list_controllers
[controller_stopper_node-3] [INFO] [1658711024.226546242] [Controller stopper]: Service available
[ur_ros2_control_node-1] [INFO] [1658711024.344358535] [controller_manager]: Loading controller 'force_torque_sensor_broadcaster'
[spawner-8] [INFO] [1658711024.400743528] [spawner_force_torque_sensor_broadcaster]: Loaded force_torque_sensor_broadcaster
[ur_ros2_control_node-1] [INFO] [1658711024.402267139] [controller_manager]: Loading controller 'speed_scaling_state_broadcaster'
[ur_ros2_control_node-1] [INFO] [1658711024.496275881] [controller_manager]: Loading controller 'io_and_status_controller'
[spawner-7] [INFO] [1658711024.497517867] [spawner_speed_scaling_state_broadcaster]: Loaded speed_scaling_state_broadcaster
[ur_ros2_control_node-1] [INFO] [1658711024.559519813] [controller_manager]: Loading controller 'joint_state_broadcaster'
[spawner-6] [INFO] [1658711024.560648410] [spawner_io_and_status_controller]: Loaded io_and_status_controller
[ur_ros2_control_node-1] [INFO] [1658711024.612665812] [controller_manager]: Loading controller 'forward_position_controller'
[spawner-5] [INFO] [1658711024.614150961] [spawner_joint_state_broadcaster]: Loaded joint_state_broadcaster
[ur_ros2_control_node-1] [INFO] [1658711024.663524998] [controller_manager]: Loading controller 'scaled_joint_trajectory_controller'
[spawner-9] [INFO] [1658711024.664247651] [spawner_forward_position_controller]: Loaded forward_position_controller
[ur_ros2_control_node-1] [INFO] [1658711024.723748416] [joint_trajectory_controller.interpolation_methods]: No interpolation method parameter was given. Using the default, VARIABLE_DEGREE_SPLINE.
[ur_ros2_control_node-1] [INFO] [1658711024.726642597] [controller_manager]: Configuring controller 'force_torque_sensor_broadcaster'
[spawner-10] [INFO] [1658711024.727177197] [spawner_scaled_joint_trajectory_controller]: Loaded scaled_joint_trajectory_controller
[ur_ros2_control_node-1] [INFO] [1658711024.736655173] [controller_manager]: Configuring controller 'speed_scaling_state_broadcaster'
[ur_ros2_control_node-1] [INFO] [1658711024.737027625] [speed_scaling_state_broadcaster]: Publisher rate set to : 100.0 Hz
[ur_ros2_control_node-1] [INFO] [1658711024.744459300] [controller_manager]: Configuring controller 'io_and_status_controller'
[ur_ros2_control_node-1] [INFO] [1658711024.744560037] [controller_manager]: Configuring controller 'joint_state_broadcaster'
[ur_ros2_control_node-1] [INFO] [1658711024.744644352] [joint_state_broadcaster]: 'joints' or 'interfaces' parameter is empty. All available state interfaces will be published
[ur_ros2_control_node-1] [INFO] [1658711024.762178447] [controller_manager]: Configuring controller 'forward_position_controller'
[ur_ros2_control_node-1] [INFO] [1658711024.769458657] [forward_position_controller]: configure successful
[spawner-9] [WARN] [1658711024.770356781] [spawner_forward_position_controller]: "--stopped" flag is deprecated use "--inactive" instead
[ur_ros2_control_node-1] [INFO] [1658711024.771621465] [controller_manager]: Configuring controller 'scaled_joint_trajectory_controller'
[ur_ros2_control_node-1] [INFO] [1658711024.772083049] [scaled_joint_trajectory_controller]: Command interfaces are [position] and state interfaces are [position velocity].
[ur_ros2_control_node-1] [INFO] [1658711024.778366978] [scaled_joint_trajectory_controller]: Controller state will be published at 100.00 Hz.
[ur_ros2_control_node-1] [INFO] [1658711024.782538325] [scaled_joint_trajectory_controller]: Action status changes will be monitored at 20.00 Hz.
[spawner-7] [INFO] [1658711024.827694258] [spawner_speed_scaling_state_broadcaster]: Configured and activated speed_scaling_state_broadcaster
[spawner-6] [INFO] [1658711024.890843170] [spawner_io_and_status_controller]: Configured and activated io_and_status_controller
[spawner-5] [INFO] [1658711024.905259648] [spawner_joint_state_broadcaster]: Configured and activated joint_state_broadcaster
[INFO] [spawner-9]: process has finished cleanly [pid 49696]
[ur_ros2_control_node-1] [ERROR] [1658711024.921636548] [scaled_joint_trajectory_controller]: Speed scaling interface not found in hardware interface.
[spawner-10] [INFO] [1658711024.924125919] [spawner_scaled_joint_trajectory_controller]: Configured and activated scaled_joint_trajectory_controller
[ur_ros2_control_node-1] [ERROR] [1658711024.931347775] [scaled_joint_trajectory_controller]: Speed scaling interface not found in hardware interface.
[ur_ros2_control_node-1] [ERROR] [1658711024.939526352] [scaled_joint_trajectory_controller]: Speed scaling interface not found in hardware interface.
[ur_ros2_control_node-1] [WARN] [1658711024.940153035] [controller_manager]: 'stop_controllers' field is deprecated, use 'deactivate_controllers' field instead!
[spawner-8] [INFO] [1658711024.942111912] [spawner_force_torque_sensor_broadcaster]: Configured and activated force_torque_sensor_broadcaster
[ur_ros2_control_node-1] [ERROR] [1658711024.949800424] [scaled_joint_trajectory_controller]: Speed scaling interface not found in hardware interface.
[INFO] [spawner-7]: process has finished cleanly [pid 49692]
[INFO] [spawner-6]: process has finished cleanly [pid 49690]
[INFO] [spawner-5]: process has finished cleanly [pid 49688]
[INFO] [spawner-10]: process has finished cleanly [pid 49738]
[INFO] [spawner-8]: process has finished cleanly [pid 49694]

Can someone help me?

Just wanted to say that I experience the same issue. I don't have any solution

Please see #448 With the current main branch this should be resolved. I'll go ahead and close this, but feel free to comment or reopen if the problem persists.

I have the same issue as described above.
scaled_joint_trajectory_controller[ur_controllers/ScaledJointTrajectoryController] inactive
Also need it to run MoveIt, any solution for that?

@Maxeva could you please open a new issue with more information of your system and log output? The issue mentioned above should not exist anymore. So, if it does for you we would need some further information.


gnomeExtensions.sound-output-device-chooser: 38 -> 39

Motivation for this change
Haven't tested functionality in a desktop session.yet.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Seems to work.


split QueryErrorHigh alert by handler and use different threshold for query_range

Description

By splitting calculations based on handler we can have finer thresholds for different queries. Right now we are aggregating all queries (including /read endpoint) which in turn skew results.
As a first step in fine-tuning thresholds this PR adds separate threshold (10%) for range queries. This in turn should improve UX when using promscale with grafana by reducing false-positives from 503 cancelations.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:

[ ] CHANGELOG entry for user-facing changes
[ ] Updated the relevant documentation

@paulfantom I just made a PR https://github.com/timescale/promscale/pull/1806 to update query metric with additional label. You maybe want to wait for that to get merged and update your PR respectively?

FYI https://github.com/timescale/promscale/pull/1806 has been merged. Maybe we close this PR and open new one that uses additional label.

IMHO https://github.com/timescale/promscale/pull/1806 is parallel to this PR and both should be merged.


feat/comment-get-all-pagination

Creating get all pagination using paginate method

Kindly review too @AchmadQiz @Achmadqizwini


Support asdf-based fzf installs

As an ASDF user, I prefer to install all my tooling through asdf. This plugin looks for fzf in a hardcoded location  (~/.fzf) which causes a duplicate installation of fzf.

Where does asdf install it?

In a path based on the version of fzf that is currently selected.
/Users/brandonmcnama/.asdf/installs/fzf/0.27.3/bin/fzf

It looks like this plugin looks in a couple of hardcoded locations only (based on https://github.com/unixorn/fzf-zsh-plugin/blob/5758b657efa262d9cd9810d343db92ff0d58fb16/fzf-zsh-plugin.plugin.zsh#L37) Is it possible to infer the location of  key-bindings.zsh based on the path of fzf?

That will make it easier, thanks.


Upload files to storage container fails with empty error, impossible to debug

Getting the following error:

Upload to container:   'mycontainer' in storage account: 'mystorageaccount' with blob prefix:   'myprefix' failed with error: '' For more info please refer to https://aka.ms/azurefilecopyreadme

it happened all of a sudden, previous builds were passing.
since today -- all of my builds fail executing this step.
I'm not sure what information I may provide you with in addition.

@johnib are you got unblocked here?

@johnib please feel free to close this if you are still facing an issue, and share the debug logs


Catch and Decorate the Request before Dingo Router gets to it

So here's a weird question...
I'm trying to intercept and decorate the request before dingo has had a chance to catch and clone it.  Using the PHPLeague OAuth2 package and OAuth2-Server-Laravel bridge for authentication.
There are 2 methods to use the API.  First is through regular client credentials and standard access using Authorization Header.  Second is through Authenticated UI.
For the UI access, I want to save the access token to a cookie can only be read by the server.  On a request where there is no Authorization header AND the cookie is present, I'd like to grab the access token, add the Authorization header to the request, and pass it long the way.
I've tried this with a middleware, a Route filter, as well as in the App::before() filter.  Each time, I can grab and decorate the request object, but dingo doesn't respect (or even use, maybe) the newly-decorated request.
I can provide code samples if needed, but just thought I'd ask, first.
Thanks.

Sorry for the very late reply David.
Hm, this sounds similar to how I'm working a current project. We have a proxy setup that all API requests are routed through so as we can safely store OAuth tokens without the client having to be responsible for that. The proxy is mainly responsible for reading this cookie and attaching the correct authorization header. Instead of altering the request though the proxy does an internal API call using the dispatcher.
Perhaps give something like that a crack?

That makes sense... I'm trying to avoid using a proxy as it adds a layer of complexity.
I don't think I'll be able to avoid that, though.
Thanks for the assistance.


TranslationUnitLoadError

Problems summary
just trying to get autocomplete with neovim.
from neovim :messages : http://pastebin.com/d48cuBTR
this is very similar to #59, but that seems to be solved with setting the right clang paths, which I think I have set correctly in my init.vim (this is minimal, but confirmed): http://pastebin.com/MPHVLRD1
I've installed llvm/clang with homebrew and had the same problem, but my current llvm I compiled into my home tree.
I get the same behavior as #59 where I type std and deoplete-clang goes nuts. also happens with sf (SFML).
Expected
autocomplete
Environment Information

OS: macOS 10.11.6
Neovim version: 0.1.7

reproduce

install neovim
run my init.vim using plug, deoplete, and deoplete-clang, also setting libclang and clang headers path
try to write c/c++
chain smoke and cry

logfile
I generated this logfile: http://pastebin.com/dakv1Seu
Screen shot

conclusion
let me know if you need anything else or about any work-arounds

I have the same problem.

@covercash2 @stjepang You should read README.md carefully. g:deoplete#sources#clang#libclang_path and g:deoplete#sources#clang#clang_header are needed to work this plugin.
example
let g:deoplete#sources#clang#libclang_path='/usr/lib/libclang.so'
let g:deoplete#sources#clang#clang_header='/usr/lib/clang'

here's the same init file i originally posted. also, this issue was only on macOS.
i tried to be thorough in my original report.

I think it depends clang version.

I get same errors:

[deoplete] Traceback (most recent call last):
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/repos/github.com/Shougo/deoplete.nvim/rplugin/python3/deoplete/deoplete.py", line 136, in gather_results
[deoplete]     ctx['candidates'] = source.gather_candidates(ctx)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 151, in gather_candidates
[deoplete]     params)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 318, in get_completion
[deoplete]     tu = self.get_translation_unit(fname, args, buf)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 305, in get_translation_unit
[deoplete]     tu = self.index.parse(fname, args, buf, flags)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/clang/clang/cindex.py", line 2322, in parse
[deoplete]     self)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/clang/clang/cindex.py", line 2440, in from_source
[deoplete]     raise TranslationUnitLoadError("Error parsing translation unit.")
[deoplete] clang.cindex.TranslationUnitLoadError: Error parsing translation unit.
[deoplete] Could not get completions from: clang.  Use :messages for error details.
[deoplete] Traceback (most recent call last):
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/repos/github.com/Shougo/deoplete.nvim/rplugin/python3/deoplete/deoplete.py", line 136, in gather_results
[deoplete]     ctx['candidates'] = source.gather_candidates(ctx)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 151, in gather_candidates
[deoplete]     params)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 318, in get_completion
[deoplete]     tu = self.get_translation_unit(fname, args, buf)
[deoplete] Too many errors from "clang". This source is disabled until Neovim is restarted.
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 305, in get_translation_unit
[deoplete] Too many errors from "clang". This source is disabled until Neovim is restarted.
[deoplete]     tu = self.index.parse(fname, args, buf, flags)
[deoplete] Traceback (most recent call last):
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/clang/clang/cindex.py", line 2322, in parse
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/repos/github.com/Shougo/deoplete.nvim/rplugin/python3/deoplete/deoplete.py", line 136, in gather_results
[deoplete]     self)
[deoplete]     ctx['candidates'] = source.gather_candidates(ctx)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/clang/clang/cindex.py", line 2440, in from_source
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 151, in gather_candidates
[deoplete]     raise TranslationUnitLoadError("Error parsing translation unit.")
[deoplete]     params)
[deoplete] clang.cindex.TranslationUnitLoadError: Error parsing translation unit.
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 318, in get_completion
[deoplete] Could not get completions from: clang.  Use :messages for error details.
[deoplete]     tu = self.get_translation_unit(fname, args, buf)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/sources/deoplete_clang.py", line 305, in get_translation_unit
[deoplete]     tu = self.index.parse(fname, args, buf, flags)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/clang/clang/cindex.py", line 2322, in parse
[deoplete]     self)
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/.cache/init.vim/.dein/rplugin/python3/deoplete/clang/clang/cindex.py", line 2440, in from_source
[deoplete]     raise TranslationUnitLoadError("Error parsing translation unit.")
[deoplete] clang.cindex.TranslationUnitLoadError: Error parsing translation unit.
[deoplete]
[deoplete] During handling of the above exception, another exception occurred:
[deoplete]
[deoplete] Traceback (most recent call last):
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/repos/github.com/Shougo/deoplete.nvim/rplugin/python3/deoplete/deoplete.py", line 59, in completion_begin
[deoplete]     self.gather_results(context), context['input'])
[deoplete]   File "/home/wsdjeg/.cache/vimfiles/repos/github.com/Shougo/deoplete.nvim/rplugin/python3/deoplete/deoplete.py", line 162, in gather_results
[deoplete]     self._sources.pop(source.name)
[deoplete] KeyError: 'clang'
[deoplete] Error while gathering completions.  Use :messages for error details.


Install plugin with --batch option in Elasticsearch 5.x or later

This mitigates breaking change https://github.com/elastic/elasticsearch/pull/29359 introduced in Elasticsearch 6.3.0.
Before Elasticsearch 6.3.0, if a plugin requires additional permissions, and standard input is closed or there is no console, then the plugin is installed without asking the user to acknowledge the additional permissions. Elasticsearch 6.3.0 introduced a breaking change where it waits for the user to acknowledge, so an attempt to install such a plugin hangs forever. Elasticsearch 5.x introduced the --batch option to install the plugin without asking the user to acknowledge.

Hi, thanks for contribution. Code looks ok, I'm merging this.


Fix LWRP build cache

Description
In lib/chef/provider/lwrp_base.rb the build_from_file method tries to avoid rebuilding LWRPs, but incorrectly stores "true" instead of the built resource in the cache.
This way, two different data types are returned.
Return values are only used in the resource inspector, so impact is mimimal.
Related Issue

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[X] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] All commits have been signed-off for the Developer Certificate of Origin.

heh yeah that's broken.  not quite sure how i managed to break that, although i can come up with crazy speculation before coffee, but i doubt it matters.


DSR Bulk Reprocess not working with 2.0 Demo

When running the Fides 2.0 demo via pip install ethyca-fides && fides deploy up bulk reprocessing of errored requests, after fixing the source of the error, only succeeds with 1 request, while putting the others into an unrecoverable state.
Steps to Reproduce

Install the fides 2.0 demo as described above and run it via fides deploy up
Login to the Fides admin UI
Create a Mailchimp connector with info that will cause an error
Submit 3 access requests on the privacy center
Approve the requests
Disable the mailchimp connector
Select all three errored requests
Click "Reprocess" in the upper right.

You'll see that one request will process correctly, the other two will fail. If you try to reprocess them individually they show an error like the attached image.

@mfbrown @sanders41 I was able to duplicate this issue. I have a screen shot but unable to post a video as I don't have a private loom account.

One of the first things to figure out here is how to reproduce this in the test_env

i've made some substantial progress on identifying the problem here, writing down some notes for tracking.

i've been able to reliably reproduce the problem using the described steps on a fides deploy up environment using ethyca-fides version 2.2.0. the steps mention 3 privacy requests - i've found that only 2 are needed to consistently reproduce the problem

i've created a test script that automates all the manual steps mentioned in the issue to more easily reproduce the problem
as a note, in the course of my manual testing, i did see some less consistent errors that showed somewhat similar symptoms, likely race conditions. i haven't pinned any of those down, but it's worth noting that there may be some other edge cases/race conditions in this workflow that aren't the core issue that's mentioned here

for the core issue here, the logs show the following error message indicating what's consistently causing one of the re-processed requests to error out: ERROR [root] Instance <PrivacyRequest at 0xffff6d53cf40> is not bound to a Session; attribute refresh operation cannot proceed (Background on this error at: https://sqlalche.me/e/14/bhk3)
some remote debugging and diagnostic logging has indicated to me that the underlying cause for the above error seems to be that in certain scenarios (see below), we're effectively executing request_runner_service.run_privacy_request() on two privacy request concurrently, even though we've got no worker configured and our task_always_eager celery config is set to True.

from my knowledge, this is not a state we expect to be in, and so in that sense it's not surprising that it's causing the above error. i'll dig more into precisely why we're hitting that error in this state, but i want to make clear why we're hitting this unexpected state only with certain conditions.

one contributing cause for this state seems to be that we're invoking privacy requests via an async endpoint, bulk_restart_privacy_request_from_failure.

in cases where we invoke privacy requests from sync endpoints, e.g. approve_privacy_request, we're not running into this problem.
i've also confirmed this hypothesis by temporarily switching bulk_restart_privacy_request_from_failure into a sync endpoint, and i did not see the problem. i don't know if this is a viable solution, and it does not feel like the correct solution to me, but it's worth noting.

another contributing cause for this state comes from the fact that our async endpoints actually need to get to a blocking call such that the current task is suspended. as far as i can tell, the only time this happens in general request execution is during the analytics.send_analytics_event() call to fideslog.

this explains why we only see the problem in a fides deploy up environment, and not in nox -s test_env or nox -s dev environments: the fides deploy environment does not necessarily opt out users from analytics;  whereas the other dev environments do, by default, opt out of analytics, which in turn bypasses the call to fideslog and means our task is never suspended.
as soon as the task for one re-processed privacy request is suspended on the analytics_client.send_async call, the other privacy request begins its request_runner_service.run_privacy_request() execution.
i believe what then happens is that the same DatabaseTask that manages the db session is being used concurrently, which is not expected. as the "first" request resumes and then wraps up execution, the session is cleaned up (likely closed), and it's never explicitly re-opened on the other request task, since that's also being resumed mid-execution.

i'm still not exactly sure the best path forward, but at least this is a start to understanding what's going on and why it's only happening in certain circumstances.


unexpected error error="invalid block type"

Hey,
I ran into few errors while setting up filebeat to fluentd.
errors:
#0 unexpected error error="invalid stored block lengths"
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-beats-1.1.0/lib/lumberjack/beats/server.rb:300:in `inflate'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-beats-1.1.0/lib/lumberjack/beats/server.rb:300:in `compressed_payload'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-beats-1.1.0/lib/lumberjack/beats/server.rb:171:in `feed'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-beats-1.1.0/lib/lumberjack/beats/server.rb:353:in `read_socket'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-beats-1.1.0/lib/lumberjack/beats/server.rb:328:in `run'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/fluent-plugin-beats-1.1.0/lib/fluent/plugin/in_beats.rb:111:in `block in run'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:348:in `run_task'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:337:in `block (3 levels) in create_worker'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `loop'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `loop'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `block (2 levels) in create_worker'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `block (2 levels) in create_worker'
  2019-06-27 18:22:06 +0000 [error]: #0 /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/concurrent-ruby-1.1.5/lib/concurrent/executor/ruby_thread_pool_executor.rb:319:in `catch'

unexpected error error="invalid block type"

unexpected error error="invalid distance code"

unexpected error error="unsupported protocol 54"

unexpected error error="too many length or distance symbols"

unexpected error error="incorrect header check"

Can anyone help with this?

Was there any update on this issue?


inputs are not protected

I've hooked up stm32f042 wideband module to a mis-wired cable.
heater wire into into Vm has caused flowing red stm32f042

well that's exciting


Bump minimum swift-crypto v2 version to 2.0.1

Motivation:
Test and upgrade to the latest swift-crypto 2.0.1 release, which
includes a BoringSSL update: https://github.com/apple/swift-crypto/pull/95
Modifications:
Tests that use real certs, which execute the OCSP code path, crash on Linux (swift:5.5 and swift:5.5-focal docker images). (rdar://85280061)
The crash happens on L351 of CertificatePolicy.swift (BoringSSLOCSPClient.checkStatus) because response, an OCSP_RESPONSE pointer, is NULL. It is NULL because the logic in BoringSSL's crypto/asn1/asn1_lib.c has changed (https://github.com/google/boringssl/commit/ee510f58895c6a88b59f1b66a94939d08ebdfe5b), so the return value needs to be handled differently in PackageCollectionsSigningLibc/asn1/a_d2i_fp.c.
I also don't think this change is correct: https://github.com/google/boringssl/commit/efab69bf7323009da8257f47e7e0976a43e12c64#diff-dc711de78524fcd1edcc461a96ca36b80cac1bf03a67287a9b434f772a6f4e3dR170.

Guard against NULL OCSP response in BoringSSLOCSPClient.
Update logic in PackageCollectionsSigningLibc/asn1/a_d2i_fp.c:

Add ASN1_get_object_without_inf and asn1_get_length_without_inf, copied from BoringSSL but reverting the "0x80 fix", such that we use the same logic regardless of swift-crypto version. We can probably remove them later when we switch over to swift-crypto 2.x completely (unless I'm correct the 0x80 fix).
Remove inf in asn1_d2i_read_bio.
Note that there are ASN1_get_object_with_inf and asn1_get_length_with_inf too. We can use these instead to keep the same behavior as swift-crypt 2.0.0 and less. I will delete these if reviewers are ok with the current approach.

@swift-ci please smoke test

@Lukasa I would appreciate if you can take a look at this as well. Thanks!

linux CI failure on asyncTest expected until CI gets newer toolchain cc @shahmishal

We have a new toolchain, please re-request testing.

@swift-ci please smoke test linux

@swift-ci please smoke test


Bump JetBrains products versions

Checklist

[ ] I have filed an issue about this change and discussed potential changes with the maintainers.
[ ] I have received the approval from the maintainers to make this change.
[ ] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: <please reference the issue number or url here>
Description of this change

we're going to have beta later this week, so should we just updated everything on Friday?

I have a feeling of something wrong here -- is it really ok to use devkit .172 with some earlier ij version?


Update quill dependency to v2

Quill v2 is still in development, however it contains some important fixes and therefore it might be preferable to use the up-to-date version.
In this PR besides the version bump I added a change to the clipboard.convert call where API changed in quill v2. For the moment it seems to me to be enough to make v2 work, but if I notice anything else I'll update my pull request.

We will definitely do this once the stable version is released

I think that could be a branch in your repository so that it is easier to find for those who want to use react-quill with quill v2. Also this would allow to work on quill v2 support iteratively while it is being developed instead of doing everything after release. This could speed up the delivery of the updated react-quill.
What do you think?


Is it feasible to handle required fields?

Hi,
Thanks for building and maintaining this library. I really like it :-)
I have a question somewhat related to our effort in the  react-basic-mui project about possible handling of required props.
Is it possible with the current strategy of the codegen to introduce a separation between required and optional props rows? I'm asking because I'm not sure what is the original source of the type information used by the codegen.
I think that in general we could preserve the current API but increase safety a bit with something like:
type PropsRequired_a r = ( ... | r )
type PropsOptional_a = ( ... )

type Props_a = PropsRequired_a PropsOptional_a

a
  :: forall attrs attrs_
   . Union attrs attrs_ PropsOptional_a
  => Record (PropsRequired_a attrs)
  -> JSX
a = element a'

Yeah, it's definitely possible. Mainly it's just a lot of work to define all these types.
The existing types are here: https://github.com/lumihq/purescript-react-basic/blob/main/codegen/react-html-attributes.json
And they're used to generate the DOM module here: https://github.com/lumihq/purescript-react-basic/blob/main/codegen/index.js

Hi @spicydonuts!
Thanks a lot for the response. Could you please tell me a bit more about the codegen process - how do you build a react-html-attributes.json file exactly (sorry if this is naive question ;-))?

The file was extracted from the npm package react-html-attributes. We created our own copy because we had a lot of overrides to make. You can run the codegen (react-html-attributes.json -> src/React/Basic/DOM/Generated.purs) using cd codegen; npm i; node ..

It seems that react-html-attributes is missing type info so it won't help in this case. I think I'm going to close this for now till I find time to experiment with typescript definitions through read-dts. Thanks!


Add exercise: roman-numerals

The tests coincide with:
https://github.com/exercism/x-common/blob/070e8d5aef4cd949305d0d8289ab4b0bae4c7295/exercises/roman-numerals/canonical-data.json

✨ Sweet!


[$1000] mWeb - Sign out - Button hidden under bottom, hard to sign out

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

launch App and login
Tap on profile > Settings
Tap on Sign Out

Expected Result:
Sign out button should be visible.
Actual Result:
Button hidden under bottom, hard to sign out
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/83ea3c5a-60b4-4af5-bd44-a891b5e3b59f
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f559d55619af61e2
Upwork Job ID:<PHONE_NUMBER>854782464
Last Price Increase: 2023-07-10

can't reproduce taking it to slack
https://expensify.slack.com/archives/C049HHMV9SM/p1686757919637879

bumping slack thread and closing for now

Hello @kevinksullivan I'm reopening the issue, because one of the contributor have the same issue with hidden buttons around the app.
Here is the Slack conversation https://expensify.slack.com/archives/C049HHMV9SM/p1686663005982659

https://github.com/Expensify/App/assets/93399543/ff1b3f71-7b89-46d1-966c-0cad02ee5680
https://github.com/Expensify/App/assets/93399543/ec359e7c-905b-4b01-8570-07964012ac17

Hey! I’m Maciej from Software Mansion, an expert agency, and I’d like to investigate this issue.
Anyone managed to reproduce this? I tested on staging, on iOS+Safari, Android+Chrome, iOS simulator and I can't reproduce the issue. I'm opening the app, scrolling, going to workspaces - bottom button looks well placed for all my devices.

@MaciejSWM I can't reproduce either. Maybe this is only reproducible if the deeplink banner is shown?

Melvin, this was reopened just yesterday

Maybe this is only reproducible if the deeplink banner is shown?

@s77rt were you able to reproduce it for this scenario?

@kevinksullivan I didn't test for that scenario. The banner was not visible in my case, it seems coming from iOS and not the App and only if certain conditions are met(?). I asked in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1688664348845969?thread_ts=1686663005.982659&cid=C049HHMV9SM for more info.

Hi, i was taking a look into it. i now why is the error being originated.
I'm still looking for the best solution.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~014c57c55cdc6e386f

Proposal
Please re-state the problem that we are trying to solve in this issue.
Sign out option is being hidden
What is the root cause of that problem?
The root of the problem is the Open App Banner that detects that you ca use a deeplinnk and shows the app banner. this messes with Safari DOM and makes that the page renders in a wrog way
What changes do you think we should make in order to solve the problem?
Every time that the settings page is render reload the component for it to take the right measures.
What alternative solutions did you explore? (Optional)

@jscardona12 Thanks for the proposal. I think your RCA makes sense although can't really validate since I can't reproduce. The solution does not seem the best we can do here. Can you explain how can we detect if the banner is shown (or would be shown)? And if so can we recalculate the height correctly in the first place without the need to have another render as that may cause visual jump behaviour.

@kevinksullivan Let's make this External again.

Hi, currently is not possible to detect if the Banner is active, but it is possible to refresh the page without the jump effect. i just did the test and its working correctly.

Without the solution:
https://github.com/Expensify/App/assets/16781411/b7c0df3e-fd72-45b8-b025-57b4cc7bfe04
With Solution:
https://github.com/Expensify/App/assets/16781411/e130cf00-62f5-46b5-a870-e0a0f9f68d8f

@jscardona12 Can you explain on what conditions we will refresh the page?

@s77rt The error just happens when you are navigating from the main page. So the page will only refresh when you are navigating from the main page, since there is not a way to detect de app banner in a consistent way on all the devices.

@jscardona12 Do you mean we will always refresh the page?

@s77rt  Just when it detects navigations from the main page. if you entered the settings url it wont have a refresh. but the most common use is navigating from the main page so mostly all the times it will refresh the component. Not the page. That is important. The thing reloaded is just the component not all the page.

@jscardona12 I think we should investigate more on this. Why remounting the components will fix the issue? or what exact component depends on the window height?

@s77rt because as you can see in the videos i send, where i show that the solution worked, the main component doesn't have the App Banner, when we enter in the settings page the banner appears but the ScrollView Component still takes the height of the previous page, but because of the Banner that has been reduce and the scroll fails. Remounting the component makes the ScrollView to takethe correct height and the scroll works again. I dont now if you want to have a quick meeting to clarify some doubts.

@jscardona12 It's still not clear what component we are talking about here. Can you link to that?

@s77rt yeah, this is the component ScrollView Inside InitialSettigsPage InitialSettingsPage

@s77rt ScrollView is a react-native-web component. Should we make an override o the library, or make a Wrapper component to fix this behaviour?

@jscardona12 We should submit a PR with the fix. I'm still not sure but based on your proposal it appears that ScrollView uses some window/viewport height at mount time but when that height changes (banner is added to the page) the ScrollView would be still using the old incorrect height.

Hi https://github.com/Expensify/App/pull/22854 this is a draft PR. To sum up, after analizing i figure that we needed to reload the component after the API Called ended. so i implemented a callback to know exactly when to reload the ScrollView component.

@jscardona12 Please do not raise PRs until you are assigned. The solution looks hacky. If the bug is on ScrollView we should fix that on RNW.

Hi @s77rt  just did another solution, is in this commit, https://github.com/jscardona12/ExpensifyJuanC/commit/892efc1aff2bce8a3ff5afb32624d73254cfa87f.
Found that the root cause,  is the navigator screen for the RightModalNavigator, it is the component that does not update when refreshing. The Height bedore was 100% i put hardcoded but it stills sets 746px instead of 700px that is set. this wasn not updating because of the min-height 100% set on the component. The fix was set the windowHeight to the navigation Screen and also set the minHeight to the same value. altough the value could be 0 as well.

@jscardona12 Thanks for the update. I don't think your RCA is correct/complete, it does not explain how this is related to the banner.
Please do not post commits, PRs, code diffs.

The RCA is releated to the banner becasuse the banner is the one that makes the window size to change, to error is the current styles with height 100% does not take the changes. so the proposed fix changes that 100% fot the actual innerHeight and overrides de min-height: 100% to innerHeight as well.

Discussing in https://expensify.slack.com/archives/C01GTK53T8Q/p1689516259835559

Proposal
Please re-state the problem that we are trying to solve in this issue.
[mWeb - Sign out - Button hidden under bottom, hard to sign out
What is the root cause of that problem?
The root of the problem is the Open App Banner that detects that you ca use a deeplinnk and shows the app banner. this messes with Safari DOM and makes that the page renders in a wrong way.
This error was previously fix on this PR
[PR with previous fix](https://github.com/Expensify/App/pull/19682
but a recent navigation refactor overwrote the changes and didn't took into accout to send the window height to the refactor styles
[PR with refactor] (https://github.com/Expensify/App/pull/19263.)
What changes do you think we should make in order to solve the problem?
pass the windowHeight to the new navigationModalCard implementation in App/src/styles
/styles.js. , and apply it to the height property.
navigationModalCard: (isSmallScreenWidth, windowHeight) => ({
    position: 'absolute',
    top: 0,
    right: 0,
    width: isSmallScreenWidth ? '100%' : variables.sideBarWidth,
    backgroundColor: 'transparent',
    height: windowHeight,
}),

This would be re-applying the fix on this [PR with previous fix](https://github.com/Expensify/App/pull/19682
to the new implementation.

@kevinksullivan Please mark this as External.

Hi @s77rt PR ready: https://github.com/Expensify/App/pull/23222

@s77rt @kevinksullivan i still doesn't have the Upwork Job assigned should i do something?  Thanks

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/19263
The offending PR has been commented on: https://github.com/Expensify/App/pull/19263#discussion_r1274225835
A discussion in #expensify-bugs has been started: Not needed, this was caused by a PR conflict where one accidentally reverted the other
Determine if we should create a regression test for this bug: No

@aimane-chnaif Yes, it seems to be the case. FWIW we just reapplied https://github.com/Expensify/App/pull/19682 because it was reverted by mistake.

Offer sent @jscardona12

Also it seems we'll be holding off on payment until the regression above is fixed, right?

@sakluger I am going OOO for a week, so tapping you in to help out in the interim. Thanks!

@kevinksullivan Yes, we have a regression https://github.com/Expensify/App/issues/23481

Just noting next steps here for clarity:

There were a few regressions, we're still waiting on a solution to https://github.com/Expensify/App/issues/23481
Once that regression has a solution and is deployed (with 7 day waiting period), we can pay out for this issue
The payout will be $500 taking the regression penalty into account

Please let me know if there's anything I missed or got wrong there, thanks!

@sakluger @s77rt Since the regretion bounty was of $2000 is it possible to payout $1000 in this one. The Safari issues are really tricky, and somettimes doesn't make any sense.

Checklist is done already https://github.com/Expensify/App/issues/20709#issuecomment-1650721950

@s77rt do you get paid in NewDot?

@kevinksullivan No, still in Upwork

@kevinksullivan are you back and able to handle this one? Or would you like me to handle it?
@jscardona12 regarding your comment on payment, can you clarify where there was a $2000 bounty? This issue shows $1000 so I'm not sure what you're referring to.

I can do it @sakluger . Still waiting on @jscardona12 's response though.

Hi, what I was saying was in a point the regression bounty was 2000 dollars.
Not the original ones. I was wondering if since we reapply a previous fix, that ended up in regression and to be honest the ton of testing and research to find a viable solution if it would be possible to pay 1000.
Thx!

I don't see anywhere that the bounty was $2000 - we pay out for this issue based on the price of this issue. We appreciate all your work on this, and testing and research is expected to be included in the job price.

@kevinksullivan I'm going to remove my assignment now, let me know if you need my help with anything else here!

following up on process here
https://expensify.slack.com/archives/C01SKUP7QR0/p1692917829830819

Payments made for $500 due to merge delay.


Dungeon incorrectly categorized

BM aka Black Morass is considered as Ramparts.
Version 2.5.7 (updated via WowUp).

Go to Settings -> Search patterns -> Turn off German and other languages you aren't using

Thanks, and that would fix my problem...
I assume the majority of installs for this addon are english users. Wouldn't it make sense to default these settings to be off?

As of few versions ago it only turns on the language that your client is using, however this isn’t reflected on users who had the add on before the change (their preferences are already saved which by default used to be every language)