Publish release assets in backup locations

We currently publish docker images to DockerHub and npm packages to NPM. If one of those sites are down, access to the artifacts will be restricted. As a backup, consider utilizing GitHub Packages  which support Container and NPM registries.

References:

Working with the Container registry
Working with the NPM registry

It's fine , but I don't think it is worth it for now. (Side note that GitHub's npm is great for private npm packages)

Archive


Nix packaging example does not exist anymore

In the linux dependencies page there is a link to the Jumpy package but the file of the derivation was removed en now it returns a 404.
Here's the link:
https://github.com/bevyengine/bevy/blob/e67cfdf82b5726db4d449e9af31b865a5324aa19/docs/linux_dependencies.md#nix
And here is the link that is there right now:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/games/jumpy/default.nix

Looks like it's been moved to https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/ju/jumpy/package.nix

#16601 attempted to fix this. I suggested the correct link but it has been S-Waiting-On-Author for a few weeks.


Feature request: Better Typing for methods not exposed on vm with Composition API and TypeScript

Is your feature request related to a problem? Please describe.
I'm starting to add unit tests to a new Vue 3 project with Composition API and I have a lot of problems with the wrapper.vm not showing up my list of methods. After couple of hours of googling and searching through issues in this project, I thought that doing something like await (wrapper.vm as InstanceType<typeof LoginPage>).login() (and I found out that the vm is actually that same type anyway) would help me out but it turns out that it only started to work after exposing the method through defineExpose({ login });, ok great but the thing is that I don't want to revisit and expose these methods simply for the sake of unit testing and typing, I mean sure I could do something like (wrapper.vm as any).login() and I'm good to go but then I lose the typing benefit.
Some similar or related issues found

#1368
#1336
Vue Docs - Typing Component Template Refs

Describe the solution you'd like
I wish that there would be simpler ways of pulling my list of methods without exposing them (with defineExpose) in Composition API
Describe alternatives you've considered
Well I guess that I have 3 ways that I have found so far for dealing with this

simply cast the wrapper vm to any... (wrapper.vm as any).login()
expose all my methods through defineExpose... defineExpose({ login });
maybe extend the VueWrapper like #1336 but I haven't tried that and I would find that it's way too much work

in most case I guess that I would go with the easiest which is step 1 but it's really sad to see that I completely lose the benefit of TypeScript typing.
Additional context

Hi @ghiscoding
Yes we agree with you. This issue is in fact a duplicate of one I created some times ago #972
TL:DR; we're waiting for improvements in Vue itself for now.
I'm going to close this one as a duplicate, please track #972 for updates

oh ok thanks that didn't come up in my search, thanks for the linking


✅ Add tests to raise coverage to at least 90% and fix recover password logic

Awesome! I just tweaked a couple of typing things, this looks great! :rocket: :man_dancing:


replace http client from java-sdk-core in flexbileEngine plugin

Currently the flexible engine plugin uses the http client from java-sdk-core and this must be replaced and we must use our own http client.

[ ] create http client using spring rest client.
[ ] write the request signer logic.
[ ] remove all dependencies to java-sdk-core from SBOM.

I will take it.


Streamfield can't render (show) own content blocks since version 2.13 in some cases

Issue Summary
Wagtail  >2.13 StreamField performance and functionality updates caused issue with stream-fields with large amount of blocks (content). Streamfield field stays collapsed and can't open. This only happens in streamfields with lots of content (some other pages are working properly, one of the pages that is not working contains content of  54904 chars). Also, the problem happens in the production environment only, locally it looks to work just fine. Errors seems to be from some javascript methods that "are" undefined. See the methods causing trouble attached below:

Steps to Reproduce

Add streamfield to a page
Use streamfield features like richtext or rawhtml to insert lots of content.
Publish it
Come back to edit the page
Streamfield content won't render

I have confirmed that this issue has only happened since the 12.3 wagtail updates

Technical details

Python version: 3.8.5
Django version: 3.1.7
Wagtail version: 2.13, 2.13.1, 2.13.2
Browser version: Chrome 91

Hi @bestasholli - thanks for the report. However, this doesn't give us enough detail to troubleshoot the issue. Usually, "...is not defined" JS errors would be a sign that you're running outdated Javascript from the previous version, perhaps because you didn't run ./manage.py collectstatic after upgrading or because you have the old files cached - the fact that this is only happening in production and not locally would back this up.
If you're able to find a set of steps starting from a clean Wagtail installation that reproduces this problem, we'll be happy to reopen and investigate further.


Learn2_new.py trainer inheritence

Learn2_new.py trainer should inherit more simple trainer class. This would allow greater generality and re-usability of our code, since currently it only applies to our specific project, e.g. it assumes the way data is stored and different pre-processing operations that have to be carried out, like balancing etc

This work is being carried out in this issue


why there are yarn.lock and package-lock.json both present?

Just wondering why. Since mostly I see it as a mishap. is it?
Also because I am keep getting error after run npm run setup

My versions

Thanks for opening this issue @adamchenwei! I believe both are present because at some point we were supporting both yarn and npm, and then we opted for just npm.
I'm pretty sure the yarn.lock file can be removed from the project, but I'll let @kwelch and @coryhouse  chime in.

I agree we should centralize around just one of them.

I vote we dump Yarn.

I'm fine with just npm as well.

I prefer how yarn handles lock files, but I am good with npm.
Alternative idea, since this is a template repo, do we want to include neither? And add something to the setup script that asks and removes one from the ignore file?

I just removed yarn.lock. Closing. Thanks guys!


Could not find gem 'sorbet-static' with platforms 'aarch64-linux',

Input
Sorbet Version being fetched: sorbet 0.5.10805
Using Docker Desktop: v20.10.22
ARM Mac: Apple M1 Pro running 13.2.1 (22D68)
Observed output
Could not find gem 'sorbet-static' with platforms 'aarch64-linux',
'arm64-darwin-21', 'arm64-darwin-22', 'x86_64-linux' in rubygems repository
https://rubygems.org/ or installed locally.

The source contains the following gems matching 'sorbet-static':

Expected behavior
Is there a version of Sorbet running on ARM Linux?

Dupe of #4119


Replace special chars in preset name with _

summary of problem:

the hipster word list in use for the first part of the preset name contains a mix of different formatted strings
with mixed case is already dealt with via strings.ToLower
whitespace remains
this can lead to "ugly" filenames like five dollar toast_downstairs.ablpresetbundle

my solution:

using regexp to replace everything but a-z with _

not sure if brianvoe/gofakeit provides a simpler way to get this result but fixing it like this was in reach for my capabilities.

A very good observation, I totally missed that. Can we go with strings.ReplaceAll() instead of regex?

thank you!


Rename 'Phase tag' component to 'Tag'

The Phase tag component has generic value beyond it's use in the Phase banner component.
For example, we could use it to style the task statuses in the task list pattern.
For this reason we should remove the reference to 'phase' from the name.
This is an example of a component that goes by a number of names - we should add 'pill' and 'chip' as aliases.

At the minute the tag will always be blue – do we need to make the tag more generic and allow it to be used with a wider palette of background colours?
There's also a right margin on the tag which makes sense when it's used as part of the phase banner, but less so if it was e.g. floated right as part of the task list. So we might want to remove the margin and specify it as part of the phase banner component.

so tag tag--phase (blue), tag--something?

Both of those examples are 'status' - might that work as a name?

I think 'status' might be too narrow a term. It's more of a pure UI component - though it's worth calling out statuses as a good use case in the guidance.

status-tag?

Cool, tag sounds good then

OK, following a conversation with @igloosi and @36degrees:

we'll design the 'Tag' component to meet the needs of the 2 use cases we currently know about (phase banners and task lists)
the default colour will be white on blue
there will be an inactive variant which will have a grey background

resolved in #291


Damage Calculation & Elemental Songs

-Update damage calculation
-Finish implementing element songs
-Small fix of TR12 Boss 4 Normal Reflect

Damage calculation being worked on later.
-Slightly off damage numbers involving elemental song damage up (ex. "Space Damage Up 9%") active songs.
Memoir already changed in another PR that has been merged.
Reflect added in another PR.


Update Dependencies

Handles this issue
https://github.com/dyninc/dyn-php/issues/26

@tfountain any chance we can get this PR merged any time soon?
We would love to be able to rely on the latest PHP8-suppored dependencies

Merged - sorry for the delay, and thanks @fogeytron! I've updated PHPUnit as well to bring things a bit more up to date.

@tfountain dude, you are awesome! Thank you!


Vessel::Engine#run is never idle

Since the last commit, it seems Vessel::Engine#run is no longer completed correctly.
I fixed it.

My bad, sorry! Was in rush)


Add troubleshooting gotcha for npm module mocks

When using manual mocks for node modules, they will not be properly
mocked if testPathDirs has been set and doesn't include the root level
'mocks` directory.
I can imagine this is a common source of confusion, and there doesn't seem to be too many easily searchable answers online.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

sure!

thank you :)


Code reorganization

Considering uniffi-rs's lack of support for external types for Ruby and Python we're forced to use a single UDL namespace.
Therefore we have to reorganize existing code:

[ ] Update dependencies - first we need to update dependencies to librustzcash (and related) crates and modify (if needed) existing code to work with updated dependencies,
[ ] Cleanup workspace - there will be two members in workspace:
uniffi-zcash - crate with our bindings,
uniffi-bindgen - crate related to bindings generation - already exists, nothing has to be changed.
[ ] Split code in lib.rs into modules (loosely) matching namespaces in librustzcash (see example project for reference)
[ ] Split .udl files to match those modules, join them together in build.rs script (see example project for reference)
[ ] Code cleanup - see below
[ ] Tests cleanup - see below

Additionally modify/cleanup existing code to match following convention (we'll stick to it from now on):
Use simple tuple structs:
This:
pub struct ZcashDiversifier(Diversifier);

NOT this:
pub struct ZcashDiversifier {
    inner: Diversifier,
}

Import and use name directly
Considering code split, I believe we can get away with simply doing this:
use zcash_primitives::legacy::TransparentAddress;

// ...

pub struct ZcashTransparentAddress(TransparentAddress);

Instead of using longer paths like:
pub struct ZcashTransparentAddress(zcash_primitives::legacy::TransparentAddress);

Constructors
Default constructors
Constructor named new in librustzcash - simply use a constructor in .udl.
Named constructors
Constructor with a name different than new use Name={constructor name} attribute in .udl:
interface ZcashOrchardDiversifier {
  [Name=from_bytes, Throws=ZcashError]
  constructor(sequence<u8> bytes);
};

Unless it's the only constructor - then use new in bindings Rust code and .udl.
Constructors returning optional
Constructors returning Option - use Result in bindings and ZcashError in .udl (chose or create a new error that seems most appropriate) - uniffi-rs does not support constructors returning optional types.
/* zcash_primitives::legacy::keys::AccountPrivKey */
interface ZcashAccountPrivKey {

// ...

  [Name=from_bytes, Throws=ZcashError]
  constructor(sequence<u8> data);

Doesn't Kotlin and Swift have some test runners that would do that automatically? It is weird that there is no such thing there already.

With Java (and Kotlin) you usually have a fully set up project with test dependencies, so it's difficult... .kts is a Kotlin script file - so not even a "proper" Kotlin.
With Swift - I have to try if proper test setup will work (again test dependencies may be a problem).

@hauleth thanks for resolving "Add wiki page explaining motivation of using a single namespace" task.


Deploy docker with python

Moves to using python for deployment things.
This will come in handy as I progress to make deployment a little more smart, and bash isn't quite cutting it.

next - start using has as Docker tag.

@alexwlchan Nice suggestions - thanks!

@alexwlchan thanks again - I'll look into the PEP8 linting.

I'll look into the PEP8 linting.

flake8 is very popular as a linter, and very widely used.
I’m on one project that uses pyformat for code auto-formatting, here: https://github.com/HypothesisWorks/hypothesis-python/blob/master/Makefile#L79-L85

@wellcometrust/experience-dev 👁 please as this will hopefully allow us to start working on the build to make our lives easier.

( 🙏  again @alexwlchan for the 🐍 🎶 )


Fix up german translation file

Closes https://github.com/devise-security/devise-security/issues/251

Coverage remained the same at 97.515% when pulling 25f99cd7f46ec374745bb284cd4dbac7b9dbb594 on oniofchaos:fix-german-translations into 63902d92e4c000aa285cd21fae959477c369691b on devise-security:master.


Tabs don't initialize inside collapsible bodies.

The indicator line is not showing up on the active tab, I assume because in display none, the width is coming up as zero. Consider adding a callback on the collapsible body visible event in order to manually initialize tabs at that time.

Collapsible now has callbacks for onOpen and onClose. You can initialize tabs within these callbacks


Fixtestcase calendar testcase failure

fix calendar testcase failing after date change (exposes helper failure)

can someone restart this as I changed the base branch while it was completing

can someone restart this as I changed the base branch

AFAIS the helper is not working (anymore) so every (electron) test running with a specific date does not run with this date but uses today.
So main problem is to fix the helper or find another solution because other tests will fail too in the future.
This is only a hotfix to get the tests running and should be reverted when the main problem is solved.
Will merge this and open an issue for the main problem.


Add telegram notifications support.

It would be awesome to have telegram as one of the notification channels.

Telegram support planned once I go to tackle #40


CapabilityProfile.load() fails on ios

flutter: >>> Unsupported operation: Isolate.resolvePackageUri, #0      Isolate.resolvePackageUri (dart:isolate-patch/isolate_patch.dart:340:7)
#1      resolveUri (package:resource/src/resolve.dart:11:20)
#2      Resource.readAsString (package:resource/src/resource.dart:74:21)
#3      CapabilityProfile.load (package:esc_pos_utils/src/capability_profile.dart:26:33)
#4      PrinterBloc._selectPrinter (package:aahi_sell/bloc/printer_bloc.dart:108:50)
#5      _rootRunUnary (dart:async/zone.dart:1198:47)
#6      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#7      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#8      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#9      Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#10     Future._addListener.<anonymous closure> (dart:async/future_impl.dart:393:9)
#11     _rootRun (dart:async/zone.dart:1190:13)
#12     _CustomZone.run (dart:async/zone.dart:1093:19)
#13     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#14     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
#15     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#16     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)

on androids too

Thank you, it should be fixed now.

@andrey-ushakov I am facing the same issue. Can anyone tell me what to do with this issue?
[ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: Null check operator used on a null value E/flutter (23782): #0      PlatformAssetBundle.load (package:flutter/src/services/asset_bundle.dart:222:39) E/flutter (23782): #1      AssetBundle.loadString (package:flutter/src/services/asset_bundle.dart:68:33) E/flutter (23782): #2      CachingAssetBundle.loadString.<anonymous closure> (package:flutter/src/services/asset_bundle.dart:165:56) E/flutter (23782): #3      _LinkedHashMapMixin.putIfAbsent (dart:collection-patch/compact_hash.dart:311:23) E/flutter (23782): #4      CachingAssetBundle.loadString (package:flutter/src/services/asset_bundle.dart:165:27) E/flutter (23782): #5      CapabilityProfile.load (package:esc_pos_utils/src/capability_profile.dart:25:10) E/flutter (23782): #6      main (package:flutter_app_printer/main.dart:9:43) E/flutter (23782): #7      _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:142:25) E/flutter (23782): #8      _rootRun (dart:async/zone.dart:1354:13) E/flutter (23782): #9      _CustomZone.run (dart:async/zone.dart:1258:19) E/flutter (23782): #10     _runZoned (dart:async/zone.dart:1789:10) E/flutter (23782): #11     runZonedGuarded (dart:async/zone.dart:1777:12) E/flutter (23782): #12     _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:138:5) E/flutter (23782): #13     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283:19) E/flutter (23782): #14     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

I/flutter (12056): Something really unknown: Null check operator used on a null value
When I go to load final profile = await CapabilityProfile.load();
It never finds the capabilities.json file
If you could help me with this problem I would appreciate it, I have tried to add it as assets in the project but it does not work.
Thanks


Update resource table value insert for HPDS.

Similar to

https://github.com/hms-dbmi/pic-sure-gic/commit/24a0406c88218c873e3888e3c875d2db9f68c7ce

Reviewed in office hours, May 16, 2023.


Error, loses connection to [merlin?] server.

On OSX: After updating bs-platform and re-installing reason-cli binaries, merlin / refmt functionality stops soon after starting VSCode. Output panel says:
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: spawn /usr/local/bin/refmt ENOENT
    at exports._errnoException (util.js:1022:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
[Error - 12:15:46 PM] Connection to server got closed. Server will not be restarted.

From the error message it looks like /usr/local/bin/refmt is not in your PATH. Can you verify that it is? If you specified that location manually through the extension preferences, try unsetting it and see if it picks up the location automatically.

It is in the path, no manual preferences set. Running with nvm, and the symlink from /usr/local/bin/refmt is actually absent. Plugin dies right after triggering refmt e.g. file save.
I manually set the symlink & VSCode plugin now seems to stay up.

Does the plugin depend on specific path /usr/local/bin/refmt?

No, the plugin doesn't depend on any specific path for refmt. It will use whatever is in the environment.
It appears the problem was that when you upgraded those packages the symlink was broken and left in a bad state. VS Code doesn't know anything about this, it just calls refmt which resolves to /usr/local/bin/refmt but then that symlink points to nowhere so it fails.
There's not much I can do about this in the extension short of trying to check for bad symlinks, but that's sort of an unusual thing to do in general. This is really something that should be fixed upstream with the installers.

Since it seems the issue was resolve I'm going to close this.


README issues

README at ends, shows this 2 lines:

one referencing a script, but I can't found it in latest images
the other is void

Would be interested provide some methodology to update your image using docker and real data: moodledata, and some installed plugins.
thanks!

Thank you for your work !
I followed #1 link but can't find anything there.
I guess the best way to upgrade will be:

Change docker-compose.yml to fit your desired version (do it one branch a time)
...  don't configure persistence on moodlehtml (comment docker-compose.yml line 56)
Recreate containers and restart
Manually download/copy custom modules when updater or notifications return a warning

Hi @lupa18,
Thanks for your suggestion! Your approach sounds great and aligns with a streamlined update process. Disabling persistence on moodlehtml and linking only the critical files like config.php and minimal required files is a smart way to ensure compatibility while keeping updates clean.
For moodledata, maintaining just the filedir in a persistent volume can be also a great idea since cache and other temporary directories (cache, temp, localcache, etc.) are automatically regenerated. This significantly reduces the storage overhead and avoids carrying over stale data during upgrades.
Additionally, including some logic in the startup scripts to ensure everything is properly updated/regenerated (e.g., clearing caches, running upgrade.php, and validating moodledata structure) would make the process more robust and reduce manual intervention.
This approach could be a solid foundation for a clean and maintainable Moodle Docker setup. Let me know if you’d like to collaborate on refining this further!
Best regards,
Ernesto

Yes, better than do like that, we may delete the volume before the upgrade, so better will be:

Backup your instance
Change image to pull desired version, ie: v4.5.1
Down the containers, and delete moodlehtml volume
Up again, wait for migrations (config file should re create automatically based on env vars)
Take note of missing plugins and install them again

I think this approach is not optimal, since step 5 should be kind of automatized.
About persistence in moodlehtml I think would be better for quickly down/up and only delete it when upgrading
About persistence in moodledata, I tried to do what you said, but when down and up, then a "invalid parameter" appears on front-end and couldn't be fixed, until I put back the original non 'filedir' folders (previous deletion). So I guesss is important to have all moodledata as is.

Thanks for the detailed feedback and suggestions!

moodledata persistence: You're right—maintaining the entire moodledata directory can be necessary in some setups to avoid issues like the “invalid parameter” error you encountered. This behavior is expected since Moodle depends on consistent data across several directories within moodledata. I'm okay with keeping the full moodledata persistence for now, as it ensures a smooth experience during upgrades and container restarts.

moodlehtml persistence: I agree with your point that managing this volume can be complex and error-prone. Instead of maintaining the volume, I think the best approach is not having it. This will make the workflow simpler:

Plugins could be installed using an environment variable, for example, PLUGINS, where you specify plugin names or URLs.
A banner in the admin panel could alert users that any plugins installed via the Moodle admin interface will be lost after a restart. We can recommend managing plugins through the PLUGINS variable instead.

Automatic config.php regeneration: The current logic for regenerating config.php from environment variables works well. During container restarts or upgrades, the container already includes the PHP files, so it will only need to update necessary components and download plugins. This approach is both efficient and maintainable.

By following this workflow, we reduce the risk of errors and simplify the upgrade process. Let me know if you want to help to implement these changes or refining the current setup further!

Thank you !

   * Plugins could be installed using an environment variable, for example, `PLUGINS`, where you specify plugin names or URLs.
   * A banner in the admin panel could alert users that any plugins installed via the Moodle admin interface will be lost after a restart. We can recommend managing plugins through the `PLUGINS` variable instead.

Interesting. So is this already working?
If not, we may add some entrypoint script to parse PLUGINS var (maybe name and version, or URL directly), and test if mod/myplugin not exists then installation tasks begin. But I also remember there are other components, like themes or admin components that must be located in other places than /mod

By following this workflow, we reduce the risk of errors and simplify the upgrade process. Let me know if you want to help to implement these changes or refining the current setup further!

I think changes for now are few, maybe commenting out line 56 and adding to readme why we don't use persistence there and what's the recommended method to upgrade.


rtype --> predicate parser/compiler

Anybody want to start working on a parser that will take an rtype string and return an object that can be used for runtime type checking and introspection? Initially, we'll want predicates for built-in types & complex types (objects, arrays, etc..), and eventually, we'll want a run-time wrapper to type check function arguments and return values. For each interface, we need to return an object like this:
interface TypeChecker {
  InterfaceName: String
  Interface: InterfaceString,  // original, unmodified interface string here
  Predicate: Predicate, // synchronous predicate, returns true if input matches interface shape, false otherwise
  Wrapper: WrapperFunction   // for functions, the wrapper monitors arguments, return values, throws, and warns if they deviate from the described interface
};

We may be able to build on existing work on jsig as described in this comment by Raynos. Start with unit tests, please. See Why I Use Tape Instead of Mocha & So Should You & Five Questions Every Unit Test Must Answer for guidance on how to write a good unit test suite.
Related issues:

https://github.com/ericelliott/rtype/issues/46
https://github.com/ericelliott/rtype/issues/47
https://github.com/ericelliott/rtype/pull/61
https://github.com/ericelliott/rtype/pull/42

No time at the moment. We have the big issue for runtime type checking in our project at work. But I can’t predict when we get at it.

Is this example correct?
parseSignature('Number => String') => {
  checkInputs: function isNumber(value) {
    return typeof value === 'number';
  },
  checkOutput: function isString(value) {
    return typeof value === 'string';
  },
  checkError: () => true // no errors defined in signature
}

@maiermic What does that look like with multiple arguments? =)
Also, I wonder how this will work for generator functions...

Good questions.

What should happen if a check fails?
We could wrap the generator object to check the type of each yielded value.

What does that look like with multiple arguments?

How about this example with two parameters?
function isNumber(value) {
  return typeof value === 'number';
}

function isString(value) {
  return typeof value === 'string';
}

parseSignature('(Number, String) => String') => {
  checkInputs(...inputs) {
    return isNumber(inputs[0]) && isString(inputs[1]);
  },
  checkOutput: isString,
  checkError: () => true // no errors defined in signature
}

The current suggestion for parseSignature looks like this:
parseSignature(signature: String) => TypeChecker

Regarding separation of concerns: How about splitting the functionality (signature parsing and generation of TypeChecker) into two functions?
parseSignature(signature: String) => RTypeAST
generateTypeChecker(signature: RTypeAST) => TypeChecker

Good suggestion. We should do that. We should also make the type checking functions return an array of TypeErrors (or emit in the generator case).


Slow display after on buster 4.8

When installing this driver on the latest version of retropie I'm seeing really bad performance. Any one else see this?
Using a cm4 with Buster4.8

I'm using the exact same settings as an older version of retropie and that version still works perfect. Now it's unusable.


check server connections

if server offline check connection every 5 sec

Few comments on an initial glance:

setInterval handle isn't stored so those intervals are leaked.
On connect + close the Promise gets both its resolve and reject callbacks triggered, isn't this against the Promise contract?
Quite few console.log invocations that are forced to the application console even if the application does not want these.
It seems that a user triggered disconnect would end up propagating close event, which then results in a reconnect when the user intended to disconnect.
I don't see how the error-callback is triggered on initial connection anymore.

On function naming

Despite the name, reconnect might not end up reconnecting.
Despite the name, getSocket is not a simple getter but performs reconnection as well.

The disconnect-detection should be built into the MumbleConnection class, which already has an interval for ping implementation, the same interval should be used for detecting dead sockets. That interval is handled properly in regards to closing the connection.


Implement Godeps or vendoring

Every project build must be reproducible and we need to support Godep or to vendor the current dependencies.

I would add glide.

It's best to avoid vendoring dependencies in a library because otherwise people will not be able to use the library unless they also vendor the same dependencies in their own project.

I think you are right @mikkeloscar . Thanks for your suggestion.


attempt to fix midi close output port

Attempt to fix https://github.com/AudioKit/AudioKit/issues/1757.
Solution:

revert to previous way of closing output ports by just removing them from the endpoints listing
do not close previous output port when opening a new one

Regarding the latest commit, besides the items discussed with @eljeff & @karnlund above, I've also noticed and fixed some other inconsistencies.
To sum it up, it seemed that the close & open output functions by index/name were either having incorrect comments or using incorrect functions / arrays:

the open output by name function had comments referring to destination index instead of destination name
the open output by uid function had comments referring to destination name instead of destination uid
the close output by name function had comments referring to closing an input by name instead. On top of this, it was looking for the uid in inputUIDs and not in destinationUIDs / through uidForDestinationAtIndex
the close output by index function had comments referring to closing an input by index instead. Similar to the above point, it was looking for the uid using uidForInputAtIndex vs uidForDestinationAtIndex

Most of those sound like typical me, copy and paste errors from when I switched us to uid's instead of names.  Sounds like a good clean up.


插件每次更新 就得重装一次torch cuda

插件每次更新就会来一次
AssertionError: Torch not compiled with CUDA enabled
就得重新运行一次 update_comfyui_and_python_dependencies.bat 脚本，
希望大佬能有所取舍 不要因为个别功能依赖，影响整个插件的使用体验
Installing collected packages: types-python-dateutil, setuptools, packaging, opencv-python-headless, opencv-python, oauthlib, torch, arrow, torchvision, fairscale, timm, rf-clip, inference-gpu, inference-cli
  Attempting uninstall: setuptools
    Found existing installation: setuptools 72.1.0
    Uninstalling setuptools-72.1.0:
      Successfully uninstalled setuptools-72.1.0
  Attempting uninstall: packaging
    Found existing installation: packaging 24.1
    Uninstalling packaging-24.1:
      Successfully uninstalled packaging-24.1
  Attempting uninstall: opencv-python-headless
    Found existing installation: opencv-python-headless <IP_ADDRESS>
    Uninstalling opencv-python-headless-<IP_ADDRESS>:
      Successfully uninstalled opencv-python-headless-<IP_ADDRESS>
  Attempting uninstall: opencv-python
    Found existing installation: opencv-python <IP_ADDRESS>
    Uninstalling opencv-python-<IP_ADDRESS>:
      Successfully uninstalled opencv-python-<IP_ADDRESS>
  Attempting uninstall: torch
    Found existing installation: torch 2.4.1+cu121
    Uninstalling torch-2.4.1+cu121:
      Successfully uninstalled torch-2.4.1+cu121
  WARNING: The scripts convert-caffe2-to-onnx.exe, convert-onnx-to-caffe2.exe and torchrun.exe are installed in 'I:\AI\ComfyUI_windows_portable\python_embeded\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  Attempting uninstall: torchvision
    Found existing installation: torchvision 0.19.1+cu121
    Uninstalling torchvision-0.19.1+cu121:
      Successfully uninstalled torchvision-0.19.1+cu121
  Attempting uninstall: fairscale
    Found existing installation: fairscale 0.4.13
    Uninstalling fairscale-0.4.13:
      Successfully uninstalled fairscale-0.4.13
  Attempting uninstall: timm
    Found existing installation: timm 1.0.9
    Uninstalling timm-1.0.9:
      Successfully uninstalled timm-1.0.9
  Attempting uninstall: rf-clip
    Found existing installation: rf-clip 1.1
    Uninstalling rf-clip-1.1:
      Successfully uninstalled rf-clip-1.1
  Attempting uninstall: inference-gpu
    Found existing installation: inference-gpu 0.17.1
    Uninstalling inference-gpu-0.17.1:
      Successfully uninstalled inference-gpu-0.17.1
  WARNING: The script inference.exe is installed in 'I:\AI\ComfyUI_windows_portable\python_embeded\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  Attempting uninstall: inference-cli
    Found existing installation: inference-cli 0.17.1
    Uninstalling inference-cli-0.17.1:
      Successfully uninstalled inference-cli-0.17.1
  WARNING: The script inference.exe is installed in 'I:\AI\ComfyUI_windows_portable\python_embeded\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
datasets 3.0.0 requires fsspec[http]<=2024.6.1,>=2023.1.0, but you have fsspec 2024.9.0 which is incompatible.
datasets 3.0.0 requires requests>=2.32.2, but you have requests 2.31.0 which is incompatible.
torchaudio 2.4.1+cu121 requires torch==2.4.1+cu121, but you have torch 2.3.1 which is incompatible.
xformers 0.0.28.post1 requires torch==2.4.1, but you have torch 2.3.1 which is incompatible.
Successfully installed arrow-1.3.0 fairscale-0.4.0 inference-cli-0.17.0 inference-gpu-0.15.2 oauthlib-3.2.2 opencv-python-<IP_ADDRESS> opencv-python-headless-<IP_ADDRESS> packaging-23.2 rf-clip-1.0 setuptools-69.5.1 timm-0.6.13 torch-2.3.1 torchvision-0.18.1 types-python-dateutil-<IP_ADDRESS>40906

不清楚你是用的什么安装工具，导致torch被替换为错误的版本。插件自带的脚本安装和手动安装requirements.txt都不会出现这种情况。

不清楚你是用的什么安装工具，导致torch被替换为错误的版本。插件自带的脚本安装和手动安装requirements.txt都不会出现这种情况。

不是工具的问题，就是某个包锁死torch版本，我目前只碰到过两个锁死torch版本的：一个libretranslate(锁死2.0.1最后只能自己放目录下然后sys.path.append解决)，一个就是图中这个。
解决办法：要么按照它的版本来，要么把它append进去，但是它的依赖得列出来。

不清楚你是用的什么安装工具，导致torch被替换为错误的版本。插件自带的脚本安装和手动安装requirements.txt都不会出现这种情况。

就直接从 ComfyUI管理器 更新全部；我为了确认是这插件，卸载了重新手动安装requirements.txt也会出现这问题，很迷的问题，可能是哪个插件冲突了？

不清楚你是用的什么安装工具，导致torch被替换为错误的版本。插件自带的脚本安装和手动安装requirements.txt都不会出现这种情况。

找到了 是ultralytics这个依赖问题, 看来是YOLO的兼容托了后腿
I:\AI\ComfyUI_windows_portable>python_embeded\python.exe -m pip install ultralytics>=8.2.0
  WARNING: The scripts convert-caffe2-to-onnx.exe, convert-onnx-to-caffe2.exe and torchrun.exe are installed in 'I:\AI\ComfyUI_windows_portable\python_embeded\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torchaudio 2.4.1+cu124 requires torch==2.4.1+cu124, but you have torch 2.3.1 which is incompatible.
xformers 0.0.27.post2 requires torch==2.4.0, but you have torch 2.3.1 which is incompatible.

I:\AI\ComfyUI_windows_portable>python_embeded\python.exe -m pip install ultralytics
Requirement already satisfied: ultralytics in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (8.2.87)
Requirement already satisfied: numpy<2.0.0,>=1.23.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (1.26.4)
Requirement already satisfied: matplotlib>=3.3.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (3.9.2)
Requirement already satisfied: opencv-python>=4.6.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (<IP_ADDRESS>)
Requirement already satisfied: pillow>=7.1.2 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (10.4.0)
Requirement already satisfied: pyyaml>=5.3.1 in c:\users\pengi\appdata\roaming\python\python311\site-packages (from ultralytics) (6.0.2)
Requirement already satisfied: requests>=2.23.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (2.31.0)
Requirement already satisfied: scipy>=1.4.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (1.14.1)
Requirement already satisfied: torch>=1.8.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (2.4.1+cu124)
Requirement already satisfied: torchvision>=0.9.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (0.19.1+cu124)
Requirement already satisfied: tqdm>=4.64.0 in c:\users\pengi\appdata\roaming\python\python311\site-packages (from ultralytics) (4.66.5)
Requirement already satisfied: psutil in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (6.0.0)
Requirement already satisfied: py-cpuinfo in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (9.0.0)
Requirement already satisfied: pandas>=1.1.4 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (2.2.2)
Requirement already satisfied: seaborn>=0.11.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (0.13.2)
Requirement already satisfied: ultralytics-thop>=2.0.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from ultralytics) (2.0.6)
Collecting torch>=1.8.0 (from ultralytics)
  Using cached torch-2.3.1-cp311-cp311-win_amd64.whl.metadata (26 kB)
Requirement already satisfied: contourpy>=1.0.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (1.3.0)
Requirement already satisfied: cycler>=0.10 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (0.12.1)
Requirement already satisfied: fonttools>=4.22.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (4.53.1)
Requirement already satisfied: kiwisolver>=1.3.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (1.4.7)
Requirement already satisfied: packaging>=20.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (23.2)
Requirement already satisfied: pyparsing>=2.3.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (3.1.4)
Requirement already satisfied: python-dateutil>=2.7 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from matplotlib>=3.3.0->ultralytics) (2.9.0.post0)
Requirement already satisfied: pytz>=2020.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from pandas>=1.1.4->ultralytics) (2024.1)
Requirement already satisfied: tzdata>=2022.7 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from pandas>=1.1.4->ultralytics) (2024.1)
Requirement already satisfied: charset-normalizer<4,>=2 in c:\users\pengi\appdata\roaming\python\python311\site-packages (from requests>=2.23.0->ultralytics) (3.3.2)
Requirement already satisfied: idna<4,>=2.5 in c:\users\pengi\appdata\roaming\python\python311\site-packages (from requests>=2.23.0->ultralytics) (3.10)
Requirement already satisfied: urllib3<3,>=1.21.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from requests>=2.23.0->ultralytics) (1.26.20)
Requirement already satisfied: certifi>=2017.4.17 in c:\users\pengi\appdata\roaming\python\python311\site-packages (from requests>=2.23.0->ultralytics) (2024.8.30)
Requirement already satisfied: filelock in c:\users\pengi\appdata\roaming\python\python311\site-packages (from torch>=1.8.0->ultralytics) (3.16.1)
Requirement already satisfied: typing-extensions>=4.8.0 in c:\users\pengi\appdata\roaming\python\python311\site-packages (from torch>=1.8.0->ultralytics) (4.12.2)
Requirement already satisfied: sympy in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from torch>=1.8.0->ultralytics) (1.13.1)
Requirement already satisfied: networkx in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from torch>=1.8.0->ultralytics) (3.3)
Requirement already satisfied: jinja2 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from torch>=1.8.0->ultralytics) (3.1.4)
Requirement already satisfied: fsspec in c:\users\pengi\appdata\roaming\python\python311\site-packages (from torch>=1.8.0->ultralytics) (2024.9.0)
Requirement already satisfied: mkl<=2021.4.0,>=2021.1.1 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from torch>=1.8.0->ultralytics) (2021.4.0)
INFO: pip is looking at multiple versions of torchvision to determine which version is compatible with other requirements. This could take a while.
Collecting torchvision>=0.9.0 (from ultralytics)
  Using cached torchvision-0.19.1-cp311-cp311-win_amd64.whl.metadata (6.1 kB)
  Using cached torchvision-0.19.0-1-cp311-cp311-win_amd64.whl.metadata (6.1 kB)
  Using cached torchvision-0.18.1-cp311-cp311-win_amd64.whl.metadata (6.6 kB)
Requirement already satisfied: colorama in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from tqdm>=4.64.0->ultralytics) (0.4.4)
Requirement already satisfied: intel-openmp==2021.* in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from mkl<=2021.4.0,>=2021.1.1->torch>=1.8.0->ultralytics) (2021.4.0)
Requirement already satisfied: tbb==2021.* in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from mkl<=2021.4.0,>=2021.1.1->torch>=1.8.0->ultralytics) (2021.13.0)
Requirement already satisfied: six>=1.5 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from python-dateutil>=2.7->matplotlib>=3.3.0->ultralytics) (1.16.0)
Requirement already satisfied: MarkupSafe>=2.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from jinja2->torch>=1.8.0->ultralytics) (2.1.5)
Requirement already satisfied: mpmath<1.4,>=1.1.0 in i:\ai\comfyui_windows_portable\python_embeded\lib\site-packages (from sympy->torch>=1.8.0->ultralytics) (1.3.0)
Using cached torch-2.3.1-cp311-cp311-win_amd64.whl (159.8 MB)
Using cached torchvision-0.18.1-cp311-cp311-win_amd64.whl (1.2 MB)
Installing collected packages: torch, torchvision
  Attempting uninstall: torch
    Found existing installation: torch 2.4.1+cu124
    Uninstalling torch-2.4.1+cu124:
      Successfully uninstalled torch-2.4.1+cu124
  WARNING: The scripts convert-caffe2-to-onnx.exe, convert-onnx-to-caffe2.exe and torchrun.exe are installed in 'I:\AI\ComfyUI_windows_portable\python_embeded\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  Attempting uninstall: torchvision
    Found existing installation: torchvision 0.19.1+cu124
    Uninstalling torchvision-0.19.1+cu124:
      Successfully uninstalled torchvision-0.19.1+cu124
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torchaudio 2.4.1+cu124 requires torch==2.4.1+cu124, but you have torch 2.3.1 which is incompatible.
xformers 0.0.27.post2 requires torch==2.4.0, but you have torch 2.3.1 which is incompatible.
Successfully installed torch-2.3.1 torchvision-0.18.1

或许有哪个插件自动让ultralytics降低版本？

或许有哪个插件自动让ultralytics降低版本？

是windows平台的ultralytics < torch-2.4.0,    在windows平台 当torch高于2.4时 安装ultralytics 会把torch降到2.4.0以下
https://github.com/ultralytics/ultralytics/issues/15049

ultralytics安装好了再装个torch 2.4.0 就没事了啊，为啥每次都要重新装这个呢？

ultralytics安装好了再装个torch 2.4.0 就没事了啊，为啥每次都要重新装这个呢？

因为requirements文件里有ultralytics，每次更新都会重新过一次requirements   ultralytics见到torch>2.4.0就让torch回到2.3

因为requirements文件里有ultralytics，每次更新都会重新过一次requirements ultralytics见到torch>2.4.0就让torch回到2.3

这个画蛇添足的功能应该关闭


Cannot run privileged workloads on containers without invoking sudo

Describe the bug
Cannot run privileged programs on containers without invoking sudo e.g. running iptables -L
Checks
N/A
To Reproduce
Steps to reproduce the behavior:
Running a workflow of the form:
  on-self-hosted:
    runs-on: [self-hosted]
    container:
      image: myimage
      options: '--privileged'

    steps:
      - name: Run a one-line script
        run: |
          if ! iptables -L >/dev/null 2>&1; then
            echo "is not running as root/with privileges."
            exit 1
          fi

Fails.
Even if I sudo -i and become root I still have trouble running privileged containers. I always have to sudo my docker calls.
Expected behavior
I was expecting to run sshuttle in the container, but it needs NET_ADMIN. I would expect options to be honor flags like --privileged like the native implementation.
If I run the exact same stanza:
  on-gh-runners:
    runs-on: ubuntu-latest
    container:
      image: myimage
      options: '--privileged'

    steps:
      - name: Run a one-line script
        run: |
          if ! iptables -L >/dev/null 2>&1; then
            echo "is not running as root/with privileges."
            exit 1
          fi

Screenshots

Environment (please complete the following information):

Controller Version 0.11.0
Deployment Method kustomize
Helm Chart Version 0.11.0

Additional context
Happy to assist if you need more information or help debugging.

@ciriarte Hey! How's your runner deployment and the runner spec look like?

@ciriarte Could you confirm your correct controller version number? 0.11.0 looks like a chart version. If you're really using controller 0.11.0, please upgrade to a more recent version.

@ciriarte Ah so are you basically saying that you need a way to add NET_ADMIN capability to the runner container, right?

If so, fyi, you might need to tweak the newPod function which generates the pod and containers spec:
https://github.com/actions-runner-controller/actions-runner-controller/blob/d2b0920454bc317c91b442b52776549d608e1bca/controllers/runner_controller.go#L565

@ciriarte Still not sure why you didn't need it for the managed runners, but shouldn't you need --cap-add=NET_ADMIN instead?
https://stackoverflow.com/questions/41706983/installing-iptables-in-docker-container-based-on-alpinelinux

@mumoshu thank you so much. Sorry for disappearing. I got sick and I was away from the keyboard.

@ciriarte Ah so are you basically saying that you need a way to add NET_ADMIN capability to the runner container, right?

Yeah, I need CAP_NET_ADMIN so I can use sshuttle. This is usually possible in regular GitHub runners by using the options key under the container config.
I got it to work for my use case, these are the steps I had to follow:

There's a section in the dockerfile where the we generate the /etc/sudoers file. I think it removes the ability of root to sudo itself (which we use during several steps while building the image):
https://github.com/actions-runner-controller/actions-runner-controller/blob/master/runner/Dockerfile.dindrunner#L47

Set the following env var: RUNNER_ALLOW_RUNASROOT.

I'm happy to submit a pull request with my changes if you're interested. Let me know! Thank you so much for this amazing project. I've learned a lot.

@ciriarte Could you share the correct controller version number? 0.11.0 looks like a chart version. If you're really using controller 0.11.0, please upgrade to a more recent version.

Ouch. I got confused. I'm using 0.18.2 thanks for catching that up.


Need a link to the IDataModelNameBinder topic

https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/dbgmodel/nn-dbgmodel-idatamodelnamebinder

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9080d10-05b2-ad02-0fdd-55ff87af1136
Version Independent ID: 7b2fa378-035a-04a8-1b6e-ee9fdaa7e792
Content: IDataModelScriptManager::GetDefaultNameBinder (dbgmodel.h) - Windows drivers
Content Source: wdk-ddi-src/content/dbgmodel/nf-dbgmodel-idatamodelscriptmanager-getdefaultnamebinder.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

@jazzdelightsme - I have added the link. I will close this issue when the changes are live. You are always welcome to send a PR for changes like this.

@jazzdelightsme - The topic updates are live, so closing this issue. Thanks for the issue and your interest in the DbgModel docs.


Parameters in the code

The parameters you set are different from the original papers. Can you explain why?
For example, the p_mult is 5.0 in the paper. It is 0.02 in your code.

Hi lileicv,
We have tried some parameters (but we did not do an hyperparameters fine-tuning) and this ones, for our implementation, seemed to work pretty well.
It is also important to note that in this implementation we have removed the pre-training, using GloVe as word embedding. Thus it is possible that our hyperparameters are different compared to the paper's ones.
Enrico & Aurel


kpt pkg get should exit gracefully when it succeeds in getting a package

Example:
$ kpt pkg get https://github.com/prachirp/kpt-functions-catalog/examples/helm-template@helm-template-example .
fetching package examples/helm-template from https://github.com/prachirp/kpt-functions-catalog to helm-template
Error: helm-template/helloworld-chart/templates/deployment.yaml: yaml: line 5: did not find expected node content
$ ls
helm-template

I ran kpt pkg get on a directory containing a helm chart and saw that the command exited with an error. But when I checked, I see that it kpt pkg got the directory correctly. The command should output a warning with the error but exit gracefully since it succeeded in getting the package.

@prachirp Is the repo in the example still available? It doesn't look like I have access. I would like to be able to reproduce it so I can understand why we get an error here.

@mortent the code is at: https://github.com/GoogleContainerTools/kpt-functions-catalog/blob/master/tests/helm_template.sh#L81

The package at https://github.com/prachirp/kpt-functions-catalog/examples/helm-template contains files with yaml extension that are not actually valid yaml. In this case they are Helm templates.
Kpt assumes that files in the package contain actual yaml files and will report an error if not. Kpt relies on being able to parse yaml in order to do support automatic setters and KRM-aware merging of resources during updates.
Is there a way to either rename the extension of the Helm templates to something different than yaml or not include them directly in the kpt package?

It's okay for kpt to warn if the files in the package are not valid yaml. My expectation on how kpt can handle helm template packages is to

Ideally kpt gets the package and creates a new local directory containing invalid yaml files, throw a warning message about invalid yaml, and exit with exit code 0
Alternately kpt fails to get the package, no new directories are created locally, throw an error message saying why the get command failed, exit with non-zero exit code.

Right now kpt does a mix of the above two scenarios, which gives users mixed messages. Can we move more towards the first scenario? Changing non-fatal errors to warnings which don't trigger non-zero exit code should fix this.

@mortent We should think more generally about non-k8s yaml/json files in kpt packages. We've discussed an ignore list in the past. Mocking with permissions seems kind of hacky.

I agree. An ignore list sounds reasonable. I think we should use an .kptignore (or .krmignore) file that must exist on the root of the package (i.e. parallel to the Kptfile). The format will be the same as the .gitignore file and any files/folders added to the file will be ignored for all purposes in kpt, except it will be downloaded as part of the package from git.
@frankfarzan WDYT?

This issue seems very similar to https://github.com/GoogleContainerTools/kpt/issues/517 now.
I have a PR to add support for .krmignore/.kptignore files: https://github.com/kubernetes-sigs/kustomize/pull/2898. I think that should address this issue.

Agree with what @mortent said.
I'm cleaning up the kpt issue list and will close this one to defer https://github.com/GoogleContainerTools/kpt/issues/517 for the kpt ignorefile discussions.


LGBMRegressor strange behavior

I have used LGBMRegressor with default settings. The resulting tree doesn't make sense. It has one parent node with split_gain of -1, internal value of 0, and 2 leaves both with the same value. When I remove the 1 feature being used to split on, the resulting tree just has the next most important feature as the one parent node.
I compared with XGBoost, and it results in a sensible tree.

It is by design.
This tree is a constant tree (thought it has 2 leave, but their outputs are the same.), whose output value is the average of the label.
For the regression task, boosting from the average can convergence much faster.
If you don't like this, you can disable it by set boost_from_average=false .


Unable to represent superscripts in "<IP_ADDRESS> PCEP-30-02 Practice Test Compendium – Operators"

E.g., 28 can't be represented on GitBook

GitBook has inline math formula feature. So, we can use this to write superscripts.


python310Packages.types-python-dateutil: <IP_ADDRESS> -> <IP_ADDRESS>

Description of changes
Update to latest upstream release <IP_ADDRESS>

Things done

Built on platform(s)

[x x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 197574 run on x86_64-linux 1

8 packages built:

python310Packages.cirq
python310Packages.cirq-rigetti
python310Packages.pyquil
python310Packages.types-python-dateutil
python39Packages.cirq
python39Packages.cirq-rigetti
python39Packages.pyquil
python39Packages.types-python-dateutil


[SPARK-24748][SS][FOLLOWUP] Switch custom metrics to Unstable APIs

Mark custom metrics related APIs as unstable
Move CustomMetrics (and a few other streaming interfaces in parent package) to streaming package

Ideally could move v2/reader/streaming and v2/writer/streaming under streaming/reader and streaming/writer but that can be a follow up PR if required.
How was this patch tested?
Existing unit tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #95521 has started for PR 22299 at commit 49a94c6.

Thanks, @jerryshao for pointing this out. I will close mine after we see what we want.

Test build #95521 has finished for PR 22299 at commit 49a94c6.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95521/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #95530 has started for PR 22299 at commit 49a94c6.

Test build #95530 has finished for PR 22299 at commit 49a94c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95530/
Test PASSed.


[BUG] Creating serializer from instance in async context

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

..
..

class Message(models.Model):
    text = models.TextField()
    user = models.ForeignKey(User, related_name="messages", on_delete=modelsCASCADE)

class MyConsumer(GenericAsyncAPIConsumer):
    queryset = Message.objects.all()
    serializer_class = MessageSerializer
    chat_room_name : Optional[str]

    @action()
    async def join_chat(self, chat: int, **kwargs):
        self.chat_room_name = f"chat_{chat}"
        await self.channel_layer.group_add(
            self.chat_room_name,
            self.channel_name,
        )
        user_serializer = await database_sync_to_async(UserSerializer)(self.scope["user"], many=False)
        await self.channel_layer.group_send(
            self.chat_room_name,
            {
                "type": "notification",
                "message": f"{self.scope['user'].username} joined the chat",
                "user": user_serializer.data,
                "chat": chat
            }
        )
    async def notification(self, event):
        content = dict(
            action="notification",
            message=event["message"],
            chat=event["chat"],
            user=event["user"],
            status=status.HTTP_200_OK
        )
        await self.send_json(content)

When I send the action to the websocket, it should add to a group of users, and send to each one the notification, with the key user that is the user that executes the action. BUT when i want to create the serializer in the async context, it never ends.

DRF does the DB query when you do user_serializer.data not on its __init__ method... the cleanest way to deal with this is to create a method that creates the UserSerializer and returns the .data.

Ok thanks! Will try it

@lautarodapin did this work for you?

@lautarodapin did this work for you?

yes thanks! the easiest way was to decorate a method for serializing the current user
@database_sync_to_async
def current_user(self) -> ReturnDict:
  return UserSerializer(self.scope["user"], many=False).data

@hishnash do you have a chat or some other active contact app like slack?
I just realized that this isnt a query search xD
 @chats_messages_handler.groups_for_signal
  def chats_messages_handler(self, instance: Message, **kwargs):
      # this block of code is called very often *DO NOT make DB QUERIES HERE*
      yield f'-chat___________{instance.chat_id}'

  @chats_messages_handler.groups_for_consumer
  def chats_messages_handler(self, chat: int, **kwargs):
      # This is called when you subscribe/unsubscribe
      if chat is not None:
          yield f'-chat___________{chat}'

@lautarodapin you can DM me on twitter https://twitter.com/hishnash


Contrast between h2 and label on win/nix

The s3 extractor and db extractors are using h2 to mark form sections.  This looks good on the mac because there is a contrast between the styles, but on win/nix browsers the h2 does not have much difference to the label.

This will be probably solved with new font which have both 300 and 400 weights.

Anyway, I wonder if we can tune font-family to fallback to some system font which have also both sizes? E.g. to system-ui?

For example, in my case, system-ui means I'll have nice Ubuntu font in UI. :)

Possible fix https://github.com/keboola/indigo-ui/issues/27

Fixed


SAP HANA reference architecture

@MikeWasson,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference-architectures/sap/index.md
:warning:Warning
View
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md

Line 13: [Warning] Invalid file link:(~/reference-architectures/images/SAP-HANA-RA-diagram.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference-architectures/sap/index.md
:warning:Warning
View
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md

Line 13: [Warning] Invalid file link:(~/reference-architectures/_images/SAP-HANA-RA-diagram.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference-architectures/sap/index.md
:warning:Warning
View
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md

Line 13: [Warning] Invalid file link:(~/reference-architectures/images/SAP-HANA-RA-diagram.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference-architectures/sap/index.md
:warning:Warning
View
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md

Line 13: [Warning] Invalid file link:(~/reference-architectures/images/sap-hana.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

docs/reference-architectures/toc.yml
:x:Error

Details

:x:Error

Details

docs/reference-architectures/toc.yml

[Error] W:\3cst-s\docs\reference-architectures\toc.yml is not a valid TOC File: (Line: 1, Col: 1, Idx: 0) - (Line: 1, Col: 1, Idx: 0): No node deserializer was able to deserialize the node into type Microsoft.DocAsCode.DataContracts.Common.TocRootViewModel, Microsoft.DocAsCode.DataContracts.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
[Error] Unable to load file: reference-architectures/toc.yml via processor: ExperimentalTocDocumentProcessor.
[Error] W:\3cst-s\docs\reference-architectures\toc.yml is not a valid TOC File: (Line: 1, Col: 1, Idx: 0) - (Line: 1, Col: 1, Idx: 0): No node deserializer was able to deserialize the node into type Microsoft.DocAsCode.DataContracts.Common.TocRootViewModel, Microsoft.DocAsCode.DataContracts.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
[Error] Unable to load file: reference-architectures/toc.yml via processor: TocDocumentProcessor.

[Error] W:\3cst-s\docs\reference-architectures\toc.yml is not a valid TOC File: (Line: 1, Col: 1, Idx: 0) - (Line: 1, Col: 1, Idx: 0): No node deserializer was able to deserialize the node into type Microsoft.DocAsCode.DataContracts.Common.TocRootViewModel, Microsoft.DocAsCode.DataContracts.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sap/images/sap-hana.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/index.md
:white_check_mark:Succeeded
View

docs/reference-architectures/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Sidebar: Replace avatar with Logout button

Adding the logout button in prominence for the sidebar is more straightforward for the user. This way, we can include the avatar, notifications icon and the dark/light mode toggle in a section on top of the main content. This section also includes the search bar.

Mockups to be added soon.


fillfacets should take stdin

fillfacets should be able to take stdin of geojson geometries
cc @ian29 @rclark

Still working on even getting stdin to work - so far (for a test run of echo test | makesurface fillfacets inputraster.tif ...  it seems the only was is to specify the input explicitly as a file, eg:
@click.argument('infile', default='-', required=False, type=click.File('rb'))

Otherwise, it is recognizing it as a string, "-". Tried a number of variations, but was hoping @sgillies could take a quick look?
https://github.com/mapbox/make-surface/blob/443baa454f0b393c26a027ed5e283a138279a1d0/makesurface/scripts/cli.py#L76
Also - @ian29 could I get a sample of what get-triangles.js is going to be outputting?

@dnomadb drop the type in the argument decorator, let it be a string like below.
example.py:
import click

@click.command()
@click.argument('input', default='-', required=False)
def example(input):
    try:
        src = click.open_file(input).readlines()
    except IOError:
        src = [input]
    for line in input:
        click.echo(line)

if __name__ == '__main__':
    example()

That will handle file names, stdin, or text input. So all three of these forms will work:
$ python example.py foo.json # prints each line of foo.json
$ echo '{"foo": 1}' | python example.py # prints out the line of JSON text
$ python example.py '{"foo": 1}' # also prints out the same JSON text

So, I had tried that, but am still only getting a string of -. With example.py above, it is the same:
▶ echo '{"foo": 1}' | python example.py
-

However, like this, it works (no checks for file):
import click

@click.command()
@click.argument('input', default='-', required=False, type=click.File('r'))
def example(input):
    click.echo(input.read())

if __name__ == '__main__':
    example()

Which runs like:
▶ echo '{"foo": 1}' | python example.py
{"foo": 1}

I'll keep trying tomorrow - thanks for the tips!

@dnomadb I got it: open_file is new in click 3.0.

Not sure that is it either - I tried upgrading (w/ pip install click --upgrade). I am running python 2.7, might this be why?
▶ pip freeze | grep click
click==3.3

@dnomadb a string of '-' is actually what you want. Look at https://github.com/mapbox/mercantile/blob/master/mercantile/scripts/init.py#L116 -- the value of input is '-' there. open_file('-') returns sys.stdin. But if you don't want literal JSON value arguments and just file/stdin, you can keep it like you've got it.

stdin from get-triangles.js is now accepted as an input to makesurface fillfacets as of https://github.com/mapbox/make-surface/commit/ce866de26b12bbdde47ef016063c1ba4489ec8d9

:tada: :dancer: :pray: :dancer: :tada:


Fix #1194 Confusion on the 'Download barge and run services section' from install.md

Fixes #1194
Changes proposed in this PR:

Fix the core issue, by:

moving barge section to be first. Why: once we have barge going in a separate console, we don't have to deal with that console again. (This is how it was pre-brownie too.)
in the "install library" section, emphasize that it's a new console

Tune some other language in the README, to make it easier to follow

Note: this PR does not currently fix Veronica's feedback about brownie installation. It focuses on the core barge issue

Note: the one failing test has nothing to do with this README.


ConfigureCell using [unowned self] can crash the app

I'm running into some random crashes when viewController is deallocated, configureCell is being call and crashed the app due to [unowned self].
I have something like this
func configureDataSource(_ dataSource: RxCollectionViewSectionedAnimatedDataSource<ChecklistSection>) {
    dataSource.configureCell = { [unowned self] (_, collectionView, indexPath, viewModel) in
        let cell = collectionView.dequeueReusableCell(withReuseIdentifier: "cell", for: indexPath) as! ChecklistCell
        cell.setup(with: viewModel)
        cell.delegate = self
        return cell
    }
}

Part of crash report:
Thread 1 Queue : com.apple.main-thread (serial)
#0 0x0000000117f8ed42 in __pthread_kill ()
#1 0x0000000117fc6457 in pthread_kill ()
#2 0x0000000117c4f107 in abort ()
#3 0x000000011719d315 in swift::fatalError(unsigned int, char const*, ...) ()
#4 0x000000011719d4af in swift::swift_abortRetainUnowned(void const*) ()
#5 0x00000001171ced16 in swift_unknownUnownedLoadStrong ()
#6 0x000000010df299b2 in closure #1 in ChecklistViewController.configureDataSource(_:)
#7 0x000000010df29c4a in partial apply for closure #1 in ChecklistViewController.configureDataSource(_:) ()
#8 0x000000010df29c6c in thunk for @callee_owned (@owned CollectionViewSectionedDataSource<ChecklistSection>, @owned UICollectionView, @owned IndexPath, @owned ChecklistItemViewModel) -> (@owned UICollectionViewCell) ()
#9 0x000000010df29d39 in partial apply for thunk for @callee_owned (@owned CollectionViewSectionedDataSource<ChecklistSection>, @owned UICollectionView, @owned IndexPath, @owned ChecklistItemViewModel) -> (@owned UICollectionViewCell) ()
#10 0x000000011185b7ea in CollectionViewSectionedDataSource._rx_collectionView(_:cellForItemAt:) at /App/Pods/RxDataSources/Sources/RxDataSources/CollectionViewSectionedDataSource.swift:190
#11 0x0000000111856587 in _CollectionViewSectionedDataSource.collectionView(_:cellForItemAt:) at /App/Pods/RxDataSources/Sources/RxDataSources/CollectionViewSectionedDataSource.swift:42
#12 0x000000011185660c in @objc _CollectionViewSectionedDataSource.collectionView(_:cellForItemAt:) ()
#13 0x00000001116b1132 in RxCollectionViewDataSourceProxy.collectionView(_:cellForItemAt:) at /App/Pods/RxCocoa/RxCocoa/iOS/Proxies/RxCollectionViewDataSourceProxy.swift:62
#14 0x00000001116b122c in @objc RxCollectionViewDataSourceProxy.collectionView(_:cellForItemAt:) ()
#15 0x000000011306d426 in -[UICollectionView _createPreparedCellForItemAtIndexPath:withLayoutAttributes:applyAttributes:isFocused:notify:] ()
#16 0x000000011306d2fe in -[UICollectionView _createPreparedCellForItemAtIndexPath:withLayoutAttributes:applyAttributes:] ()
#17 0x000000011307281b in -[UICollectionView _updateVisibleCellsNow:] ()
#18 0x0000000113078710 in -[UICollectionView layoutSubviews] ()
#19 0x0000000112687551 in -[UIView(CALayerDelegate) layoutSublayersOfLayer:] ()
#20 0x000000011130f4ba in -[CALayer layoutSublayers] ()
#21 0x00000001113135a9 in CA::Layer::layout_if_needed(CA::Transaction*) ()
#22 0x0000000112671e5f in -[UIView(Hierarchy) layoutBelowIfNeeded] ()
#23 0x000000011168c084 in closure #3 in ObservableType.subscribeProxyDataSource<A>(ofObject:dataSource:retainDataSource:binding:) at /App/Pods/RxCocoa/RxCocoa/Common/DelegateProxyType.swift:256
#24 0x000000011168c1a8 in partial apply for closure #3 in ObservableType.subscribeProxyDataSource<A>(ofObject:dataSource:retainDataSource:binding:) ()
#25 0x000000011192a0cd in AnonymousDisposable.dispose() at /App/Pods/RxSwift/RxSwift/Disposables/AnonymousDisposable.swift:46
#26 0x000000011192a2c0 in protocol witness for Disposable.dispose() in conformance AnonymousDisposable ()
#27 0x00000001119af101 in DisposeBag.dispose() at /App/Pods/RxSwift/RxSwift/Disposables/DisposeBag.swift:66
#28 0x00000001119af3d7 in DisposeBag.deinit at /App/Pods/RxSwift/RxSwift/Disposables/DisposeBag.swift:82
#29 0x00000001119af421 in DisposeBag.__deallocating_deinit ()
#30 0x000000011719f220 in _swift_release_dealloc ()
#31 0x000000010de1d962 in @objc ChecklistViewController.__ivar_destroyer ()

collectionView and disposeBag are properties of the ViewController.
Base on the crash report, my assumption is while viewController is being dealloc, disposeBag deinit is called and dispose() all Disposals, the disposeAction callback is triggered for the disposable created below
 items.asObservable()
    .bind(to: collectionView.rx.items(dataSource: dataSource))
    .addDisposableTo(disposeBag)

rx.item calls subscribeProxyDataSource In DelegateProxyType.swift file
 return Disposables.create { [weak object] in
   subscription.dispose()
   object?.layoutIfNeeded()   // line 256
   unregisterDelegate.dispose()
 }

The object here refers to my collectionView and it's nil as expected when I debugging it. I wasn't able to repro the crash with debugger attached and it happens so randomly. From the crash report, it seems object is not nil and object?.layoutIfNeeded somehow triggers collectionView to redraw itself and called configureCell?
Although I can easily prevent the crash by using weak self, it confuses me why configureCell is getting call when the viewController is destroyed.
Should [weak self] be used in configureCell closure and why?
Thanks!

Hi, @lingzlu
I remember I had some issues as well, not sure what was causing them at that time
@kzaher I wonder could this be an issue. As it force UI{TableView}{CollectionView} to reload its data. what if somehow data source is still alive by that time? Or I missing something?

Hi guys,
you should never use unowned.

@kzaher can you provide some reasoning on that?
I do agree

Don't reference self at all. Pull your dependencies that are required for configurecell outside of your vc and reference that object directly without referencing self.
I so far haven't encountered any cases where unowned should be allowed.

Thanks for the suggestion, I did move things a bit to avoid reference self.  :)
General, weak is safer than unowned. But I would argue there are cases you can safely use unowned.
Common example:
class Test {
    var closure: (() -> Void)? = nil
    var string = "Test"

    init() {
        closure = { [unowned self] in
            print(self.string)
        }
    }
}

From Apple's Documentation:
Define a capture in a closure as an unowned reference when the closure and the instance it captures will always refer to each other, and will always be deallocated at the same time.
Funny this actually help me realize that configureCell doesn't met the criteria of safely use unowned self. Logically, I would think configureCell (closure for cellForRowAtIndexPath) should always be called while the viewController exists, it appears that's not always true...

for UITableViewController will crash on debug mode, I solved this problem by add
tableView.dataSource = nil
tableView.delegate = nil

I have a similar issue where [unowned self] was changed to [weak self], and now I received a crash from returning a blank collectionViewCell that doesn't have a reuseIdentifier.
What changes are suggested to deal with this crash?
Should I make sure the collectionView.dataSource = nil?
Here are some screenshots to portray what I am looking at.
RxDataSource code:
       configureCell: { [weak self] dataSource, collectionView, indexPath, _ in
            guard let self = self else { return CanvasItemCollectionViewCell() }

            switch dataSource[indexPath] {
            case let .CellModel(model):
                let cell = collectionView
                    .dequeueReusableCell(
                        for: indexPath,
                        cellType: CanvasItemCollectionViewCell.self
                    )

                cell.model = model

                return cell
            }
        }

Crash:

I ended up using a closure to encapsulate the work that needed to be done by self. You can see how I managed to do this in the following SO question: https://stackoverflow.com/questions/67913373/how-do-i-properly-return-a-collectionviewcell-with-reuseidentifier-if-weak-self


Ribbon is not loading after the solution is imported into the system

Just letting you know that I've experienced the same issue. Did you find a way round this?

Hello Ben,
I plan to work on this issue. I believe it's something on the Platform Core side of things.
I will keep you posted.
Andrew

Hello Ben,
It seems to be the issue is caused by "RibbonMetadataGeneration" long-running operation. I created the trial version, installed the solution, and experienced exactly the same issue. I had to wait approximately 30 minutes until that operation was completed and ribbon in "Dialog" entity appeared as it has to appear:

Let me know if it doesn't work for you. I read multiple threads in regards to similar issues and the only "good" way was to open a support ticket with Microsoft so I bet there is nothing wrong with the solution itself - there is something with the dynamics core that's related to the import and publishing of the solution.
Andrew

Hi Andrew,Thanks for that. I’ll try it again later this morning and let you know…..Best wishes,BenSent from my iPhoneOn 9 Jan 2023, at 04:14, Andrew Butenko @.***> wrote:
Hello Ben,
It seems to be the issue is caused by "RibbonMetadataGeneration" long-running operation. I created the trial version, installed the solution, and experienced exactly the same issue. I had to wait approximately 30 minutes until that operation was completed and ribbon in "Dialog" entity appeared as it has to appear:
Let me know if it doesn't work for you. I read multiple threads in regards to similar issues and the only "good" way was to open a support ticket with Microsoft so I bet there is nothing wrong with the solution itself - there is something with the dynamics core that's related to the import and publishing of the solution.
Andrew
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Hi Andrew,
so I refreshed the browser where I did the original install last night (Edge with and Edge profile) and the problem is still there.
I then opened a new private session in Firefox and the icons are there and the form opens.
I then started a new private Edge session and this has also fixed the issue.
So, I think a combination of patience and cache clearing fixes the issue. As you say, it's a problem with the platform not with your solution.
Thanks for sharing this solution with us - I look forward to exploring its capabilities today.
Ben

Minor update. The ribbon and form still not behaving in an Edge profile after the above. Clearing the browser history in that Edge profile and restarting has fixed things there too...

Closing this issue cause it's not the solution's issue but the issue of the application core. I believe the issue is related to the fact that I modify the "global" ribbon - the ribbon that is used on all the forms that exactly causes the issue to appear.

@bwmodular and obviously I would love to hear your feedback in regard to the solution overall.

Ok. I will work on it since the demand appeared. But you can test your new dialog from the Dialog Selector - https://github.com/AndrewButenko/ABDialogsV2/wiki/4.-Calling-dialog-from-the-record-form

Ah, great - if there's already a way to preview dialogues, that's all I need for now. Thanks again.


Reseting private ip and gateway configurations of APIM service

Hi All,
We configured a APIM service in Azure with private IP and Gateway configurations using terraform.
We are using the templates provided in this forum to configure APIM and deploy API's using Azure Devops Pipelines. Templates taken from : .\azure-api-management-devops-resource-kit-master.zip\azure-api-management-devops-resource-kit-master\example
We categorized the templates and deploying API and APIM configuration Individually.
API's are deploying successfully to APIM service via Azure Devops pipelines with few exceptions like revision description is not updating.
Using APIM templates I added two products, 1 user, 1 group, subscribed to 1 new product and configured AppInsights. All the changes updated to master templates, When I deploy the templates using Azure Devops pipeline, APIM changes are reflecting exactly but it's removing the private IP and gateway settings in the APIM service.
Can someone help me the cause of issue and solution. Let me know if you need more information.
Regards,
RajuKumar

This is a problem with the APIM ARM deployment, and not with DevOps Resource Kit.  As a result, we cannot assist in correcting this behavior.


linux: increase thread stack size with musl libc

musl has tiny default thread stack sizes compared to glibc (80 kB vs.
2048 kB or more) so set an explicit stack size to harmonize between
different libcs.
Fixes: https://github.com/libuv/libuv/issues/1507

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/483/


Run cargo fix and fix some clippy warnings

The reason try! was used was so this kept working on Rust 1.6 or something like that - I remember testing it on those old versions back when I added the v0 module.

Based on above ci test, this crate can only be built with Rust 1.31.0 and onward.

I guess I'll leave it to @alexcrichton.


fix: find ts-node

Codecov Report
Base: 88.39% // Head: 88.32% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (817e99d) compared to base (56702d5).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   88.39%   88.32%   -0.08%
==========================================
  Files          40       40
  Lines        4094     4102       +8
  Branches     1196     1198       +2
==========================================
+ Hits         3619     3623       +4
- Misses        435      439       +4
  Partials       40       40

Impacted Files
Coverage Δ

packages/command-core/src/npm.ts
85.78% <0.00%> (-0.46%)
:arrow_down:

packages/cli-plugin-dev/src/index.ts
82.55% <66.66%> (-0.71%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update readme.md

Added our links to the read.me - website link, install instructions, productivity log, project wiki, sprint 1 taskboard, mywebclass boardcards, and sprint 1 retro

going to make another more updated one


📃: Add P2P Voice Call Application

🔴 Title: P2P Voice Call Application
🔴 Aim:
The aim of this project is to build a peer-to-peer (P2P) voice call application using Next.js, allowing users to initiate and join voice calls without relying on centralized servers for media streaming. The application will include core features like secure user authentication, voice conferencing, chat functionality, and seamless peer-to-peer communication.
🔴 Tech Stack Used:

Frontend: Next.js, ShadCN (UI components)
Backend: Node.js, Express
Real-Time Communication: WebRTC for peer-to-peer voice, Socket.io for signaling
Authentication: Clerk for secure user authentication
Database: MongoDB (for storing user data, call history, etc.)
Hosting: Vercel (frontend), Heroku or AWS (backend)

🔴 Screenshots 📷
N/A
✅ To be Mentioned while taking the issue:

Full Name: Sezal Lagwal
Participant Role: GSSOC'24 Ext, Hacktoberfest

#906

#906

its a video call app. i am trying to create a voice call app like discord vcs or whatsapp voice call
can you reconsider labels?

#906

my app is only for p2p video calls between two users. she is trying to make app like whatsapp calls or discord vc

Sorry for my response. It's just closed by watching similar issues heading and content. I'm not focusing on keyword difference.
Go ahead.


Added BSVPATH to makefilegen.py call and added deriving FShow to some types

thanks!
Please split pull requests by topic if possible.


[Bug]: Prefetching link doesn't work with relative pathname

What version of React Router are you using?
6.13.0
Steps to Reproduce
Use the prefetch="render" with the relative link like to="../something".
Expected Behavior
I would expect the to link to be resolved to the absolute path and used in such a format in the final anchor tag so that the browser can prefetch the link.
Actual Behavior
When using the Link or NavLink with the relative URL in the to property, the prefetching doesn't work and prints a warning in the console: Tried to prefetch RELATIVE_URL but no routes matched.

Currently, from what I understand it's using the relative link and browser fails to prefetch link. The fix is to use absolute URL but I guess the component should do it for the developer.

doesn't work on style links as well

I was suspecting that this might be due to Remix's Link not delegating relative prop to useHref:
https://github.com/remix-run/remix/blob/2d3e1d8b81263c02c2e606739aac42403f33d538/packages/remix-react/components.tsx#L228-L232
which could be intended to be useHref(to, { relative: props.relative }).
However, when I was testing similar scenario from what I can guess, I couldn't reproduce any issue on latest remix with vite at least https://stackblitz.com/edit/remix-run-remix-tgaoh2?file=app%2Froutes%2Fdir1.tsx, so this could be a totally different thing.
I would appreciate if anyone has a reproduction for the issue.

I was suspecting that this might be due to Remix's Link not delegating relative prop to useHref:
https://github.com/remix-run/remix/blob/2d3e1d8b81263c02c2e606739aac42403f33d538/packages/remix-react/components.tsx#L228-L232
which could be intended to be useHref(to, { relative: props.relative }).
However, when I was testing similar scenario based on what I can guess, I couldn't reproduce any issue on latest remix with vite at least https://stackblitz.com/edit/remix-run-remix-tgaoh2?file=app%2Froutes%2Fdir1.tsx, so this could be a totally different thing.
I would appreciate if anyone has a reproduction for the issue.

i an using unstable vite as well but links which are returned from links function not link component

@lukasa1993 If you are talking about <Links /> component, then that's likely a different issue since this issue is about <Link prefetch="..." />. It might better to create a new issue for that.

@lukasa1993 If you are talking about <Links /> component, then that's likely a different issue since this issue is about <Link prefetch="..." />. It might better to create a new issue for that.

oh okay

Having the same issue, any fix?


Interaction with RUST_LOG and our commandline printing

Hipcheck does some stuff to control writing to the commandline, and it seems that when I run with RUST_LOG=debug I don't see any log::debug! prints which I would like to be displayed. Diagnose why logging prints don't show up and fix

Oh, we reassign the environment variable to HC_LOG instead of RUST_LOG