Documenting new default headers in HTTP probes

Hello,
This PR is adding documentation about default headers when using http probes and including the changes being proposed in
https://github.com/kubernetes/kubernetes/pull/95641
This is my first PR in this repo so please kindly help me to get through it

/milestone 1.20

/remove-label language/fr language/id language/ko language/zh

/remove-label language/fr

/remove-language fr
/remove-language id
/remove-language ko
/remove-language zh

/milestone 1.20
/hold
pending merge https://github.com/kubernetes/kubernetes/pull/95641
/sig node network

thanks @sftim I altered a bit following your suggestions :) I have removed the table as I felt it was too much for 2 lines

Thanks @SergeyKanzhelev! Indeed that makes sense :)

BTW @fonsecas72 you might like to squash these commits (this repo preserves “lgtm” through squashes, too).

/hold cancel
@SergeyKanzhelev can you provide a technical review/ lgtm?

Made a final review and it's all LGTM. Thank you @fonsecas72!
/lgtm

/lgtm
/approve

Sorry I'm new to this but should not this be merged automatically ?  Just wondering If I need to do anything

oh well, thanks :)


deploy after tests complete + create deployment in github

This pull request updates the deployment workflow in the .github/workflows/deploy.yml file to improve automation and status tracking. The most important changes include switching the trigger from push to workflow_run, adding a step to create a GitHub deployment, and updating the deployment status upon completion.
Changes to workflow triggers and permissions:

.github/workflows/deploy.yml: Changed the trigger from push to workflow_run to run after specific workflows complete. Updated permissions to include deployments: write.

Enhancements to deployment process:

.github/workflows/deploy.yml: Added a step to create a GitHub deployment using chrnorm/deployment-action@v2.
.github/workflows/deploy.yml: Added a step to update the deployment status using chrnorm/deployment-status@v2. This step runs only if the previous steps succeed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


[Bug?] An empty file is determined to be binary.

Info

Operating System: Ubuntu 20.04 on WSL2
Shell: zsh
Terminal: Windows Terminal
nvim --version: NVIM v0.9.0-dev-6e8ed5aba
fzf --version: 0.32.0

[x] The issue is reproducible with mini.sh

Step to reproduce

$ cd /tmp
$ git clone git@github.com:ibhagwan/fzf-lua.git --depth 1
$ cat <<EOS > mini.vim
set hidden
set noswapfile

set rtp+=./fzf-lua
EOS
$ touch blank
$ nvim -u mini.vim

In nvim, use :FzfLua files to see the preview of blank.

Description
It is not a problem, so it is not a priority, but I feel uncomfortable with it, so I am reporting it as an issue.
As shown in the title, an empty file is determined to be a binary file in the preview.

Thanks for reporting, can you check if the utility function works as expected?

the second line should return false

:lua print(require"fzf-lua.utils".perl_file_is_binary("/bin/sh"))
:lua print(require"fzf-lua.utils".perl_file_is_binary("<empty file path>"))

Unfortunately, both of these would be true. This function seems to be the cause.

The fin room uses perl -B flag to test for binary, can you run the following in the shell?
perl -E 'exit((-B $ARGV[0])?0:1)' <empty file>
echo $? # should return 1
perl -E 'exit((-B $ARGV[0])?0:1)' /bin/sh
echo $? # should return 0

This is also the same for both, which is 0.

This is also the same for both, which is 0.

That’s wrong result by perl then, not much I can do about it, what’s special about this file?
Does this happen with other empty files? Perhaps a WSL issue?
What does file --dereference --mime <file> return?

Btw, this used to be done via file --dereference --mime (instead of perl) but it was way more inconsistent so I moved to perl.

That seems to be the specification of -B in perl.  Would it be bad to also include a determination of whether or not the file is empty in this utility function?

That seems to be the specification of -B in perl. Would it be bad to also include a determination of whether or not the file is empty in this utility function?

https://github.com/ibhagwan/fzf-lua/commit/74072cc855aeeafa7f963ad75b73828e71132bff - free check since we already have the stat result of the file.


refactor(docker): replace the multiple rosdep commands with resolve_rosdep_keys.sh.

Description
This PR replaces the multiple rosdep commands in the Dockerfile with a shell script, resolve_rosdep_keys.sh, to improve the readability of the Dockerfile.
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Interface changes

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

NOTE:
This feature was requested in this comment from @oguzkaganozt
https://github.com/autowarefoundation/autoware/pull/5363#pullrequestreview-2407733841


Fix web app link in views/footer.ejs

The link to the web app in the footer doesn't work. Please update this with the correct Heroku link.

Fixed with https://github.com/denisecase/web-app-2020-fall/commit/ef55b1adf8cbebf22c3e22dc916e56b5d608c297


AER: Fixed Linting issues

What type of PR is this?
Add one of the following kinds:

correction

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

merging the code without others providing additional review comments as this PR is only for the feature branch and there is another PR which merges these changes with main branch which is still open and available for everyone to review.


Wrap conversion exceptions in a ValueConversionException

To help provide better error reporting to users wrap the
conversion exception into another providing the column or
property that the conversion failed on. This allows for both the
column and row causing the issue.

Could you please rebase this PR so we can merge it?

Actually, this PR is not required anymore, as you can just hint the catch on the Ddeboer\DataImport\Exception interface.


Add tool to generate fasta file

This will be useful, thanks. It would be good to put the work 'random' a few more times in the description, docstrings, etc, etc, as it's not immediately clear that's what it's doing.

@jeromekelleher pushed a new commit addressing your concerns

+1, thanks.


Certifying a custom connector

Hi.
I need some help on what to do on my custom connector project in order to certify it.
I followed some required aspects of Connector Certification, but there are others that i don't know what to do exacly.
I sent an email to microsoft via the channel on that page, i'm waiting for an answer. I don't have to hurry, but i would like to finish this project, and for that i need some help.
Kind regards.

Same here
I sent an email to Microsoft to certify my custom connector, but so far I haven't received a response to my email.
Kind regards.

Hi all,
Sorry about delays. Our new certification portal will be going live next week and I will be onboarding you on it.

Colin I'm also very interested in the certification portal.  I have two connectors already live in the Power BI cloud that I haven't been able to engage with you to get certified and would like to do so.


Delete newline in branch name

Coverage remained the same at 94.318% when pulling<PHONE_NUMBER>0bab81daca82f32acf8d1de224cc79 on destroy-endline into 6b501214727a7e142cd5cf0fad02d70c03466e07 on master.

published as 0.10.1


fix(engine, api): check correctly against new cutout IDs in get_slot_definition

Overview
In the process of working on deck configuration, some shim code was added to convert the data in Deck Definition V4 to the old SlotDefV3 (which was the entirety of data stored in orderedSlots in the v3 deck). PR #13872 changed the cutout IDs in the new deck definition to be unique from the addressable area names. This caused an issue with the shim code which was comparing the two id names.
The temporary code has been updated to now correctly compare against the end of the cutout ID string, rather than the whole string.
Test Plan
Just CI.
Changelog

Fixed shim code in LabwareView.get_slot_definition

Review requests
Risk assessment
Low, bug fix.

Makes sense to me as a quick fix, but let’s definitely find a way to not have to do string comparisons like this. The app team is going to have similar stuff going on. If this turns out to be a recurring problem, we need to go back to the deck definition and figure out how to make this more readily computable, or build a shared set of utility functions or something.

Agreed, this code is not intended to be the final version of how this function will work. It isn't fully sketched out yet, but that will rely on the relations built into the deck between cutouts and addressable areas in the cutout fixture definitions.


What is the best way to save the current generation data to a file so that it can be reused later.

I am a bit confused on the difference between resumming and starting the GA, but when I try to load in the genes that I've saved it seems as though the data is always overwritten.
Currently my gene "Value" is an int[] and I am serializing all of those to a binary file.
I am then trying to load the saved data like this:
    List<Gene[]> list = bf.Deserialize(inStr) as List<Gene[]>;
    var ind = 0;
    foreach(Gene[] g in list)
    {
      if(ind < this.ga.Population.CurrentGeneration.Chromosomes.Count())
      {
          this.ga.Population.CurrentGeneration.Chromosomes[ind].ReplaceGenes(0, g);
       }
    }

However, as soon as I call ga.resume it appears as though my data get overwritten.
Thanks for any help.

@githubToolTester it's a really good question. Could you, please, provide the code you are using to serialize them?

Sure,
            string path = "resultPopulation.bin";
            using (Stream stream = File.Open(path, FileMode.Create))
            {
                var binaryFormatter = new System.Runtime.Serialization.Formatters.Binary.BinaryFormatter();
                List<Gene[]> genes = new List<Gene[]>();
                foreach (MyChromosome nc in this.ga.Population.CurrentGeneration.Chromosomes)
                {
                    genes.Add(nc.GetGenes());
                }
                binaryFormatter.Serialize(stream, genes);
            }

Thanks for the help,
Alex

I actually had a very dumb bug in my loading (missing an ind++ in the code above).  My approach works fine now, as long as I run 1 generation before I load in the saved gene data.
Thanks and sorry for the error.

Your solution is good, but there is another one: you can create a new IPopulation implementation that allow you to specified the chromosomes of the initial generation:
public class PreloadPopulation : Population
{
	private IList<IChromosome> m_preloadChromosome;

	public PreloadPopulation(int minSize, int maxSize, IList<IChromosome> preloadChromosomes)
		: base(minSize, maxSize, preloadChromosomes.FirstOrDefault())
	{
		m_preloadChromosome = preloadChromosomes;
	}

	public override void CreateInitialGeneration()
	{
		Generations = new List<Generation>();
		GenerationsNumber = 0;

		foreach(var c in m_preloadChromosome)
		{
			c.ValidateGenes();
		}

		CreateNewGeneration(m_preloadChromosome);
	}
}

You can see the full sample here Issue9Sample.

Yes this is definitely better, thank you!


Add 2 additional fields to data import

Add additional fields from import spreadsheet

test_trace_creation_date
isolation_start_date

Some minor refactoring to names in import method as row did not feel right in all places referenced
Move Rails.logger.unknown message about User imported new contacts to after Rollback, as if Rollback occurs then technically zero new records are imported
[1] pry(main)> Contact.last
  Contact Load (0.4ms)  SELECT "contacts".* FROM "contacts" ORDER BY "contacts"."id" DESC LIMIT $1  [["LIMIT", 1]]
=> #<Contact:0x00007f7878a037d0
 id: 639,
 first_name: "Casey",
 middle_names: nil,
 surname: "Addams",
 address: "201 White Shires Road",
 postcode: "N1 0AB",
 telephone: nil,
 mobile: "+44762",
 gds_import_data: nil,
 is_vulnerable: false,
 created_at: Tue, 15 Dec 2020 15:45:45 UTC +00:00,
 updated_at: Tue, 15 Dec 2020 15:45:45 UTC +00:00,
 email: nil,
 additional_info: nil,
 count_people_in_house: nil,
 any_children_under_age: nil,
 delivery_details: nil,
 any_dietary_requirements: nil,
 dietary_details: nil,
 cooking_facilities: nil,
 eligible_for_free_prescriptions: nil,
 nhs_number: "100000000",
 date_of_birth: Mon, 15 Feb 1971,
 has_covid_symptoms: nil,
 lock_version: 0,
 channel: nil,
 no_calls_flag: false,
 deceased_flag: false,
 share_data_flag: nil,
 lead_service_id: nil,
 lead_service_note: nil,
 imported_item_id: 44,
 test_and_trace_account_id: "yyddmm20201215",
 test_trace_creation_date: Thu, 03 Dec 2020,
 isolation_start_date: nil>
[2] pry(main)>

The last row in png is the record above.

Have not added the two fields to the permitted params for Contacts. As not yet added to views

Happy with everything apart from the refactoring - I think calling everything a record is confusing. But appreciate it's not crystal clear as is.  Can you move that commit ( #44d0a9cfb10b15106bf3c6070cdb6e1884f80ab2) a separate PR please so we can review later with @go8soft


Set dialog theme to avoid yellow texts

Could u provide a gif or img which shows how it changed?

Previously confirmation texts are yellow and the dialog title is white.

Now it is safe to see them 🙋

Awesome!

Awesome!

LGTM

Merge!


Support version 2.0.0 changes

To completely implement the version 2.0.0 changes , the following tasks and their subtasks needs to be completed.
All the tasks needs to be implemented , tested , reviewed and merged to the develop branch.
Individual Services :

[x] https://github.com/openBackhaul/AdministratorAdministration/issues/121
[x] https://github.com/openBackhaul/AdministratorAdministration/issues/125
[x] https://github.com/openBackhaul/AdministratorAdministration/issues/126
[x] https://github.com/openBackhaul/AdministratorAdministration/issues/127
[x] https://github.com/openBackhaul/AdministratorAdministration/issues/131
[x] https://github.com/openBackhaul/AdministratorAdministration/issues/133

Basic Services :

[x] https://github.com/openBackhaul/AdministratorAdministration/issues/140

OAM Services :

[x] https://github.com/openBackhaul/AdministratorAdministration/issues/141
[x] https://github.com/openBackhaul/AdministratorAdministration/issues/132

All subtasks are done.


Failed Fuzzy search returns a strange format

If I:
const Scry = require("scryfall-sdk");
await Scry.Cards.byName("rstdrdtst", true);

I get an object like this, which doesn't actually tell me that I've encountered an error or what the error was:
{
  "data": [],
  "not_found": []
}

However querying the actual Scryfall API with a similar request (curl 'https://api.scryfall.com/cards/named?fuzzy=rstdrdtst') , I get a much more helpful response:
{
  "object": "error",
  "code": "not_found",
  "status": 404,
  "details": "No cards found matching “rstdrdtst”"
}

It would be great if we could get this response instead.

If you get no results you can query Scry.error() to get the previous error object I believe? Or something like that. Lemme know if that doesn't work


Can not free GPU memory after Trainer.train() a Peft lora model

System Info
peft 0.13.2
accelerate 1.1.0
torch 2.4.0
trl 0.12.0
python 3.10.15
linux server
Who can help?
@BenjaminBossan @sayakpaul
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[x] My own task or dataset (give details below)

Reproduction
import torch
import os
from transformers import ( AutoTokenizer, AutoModelForCausalLM,BitsAndBytesConfig,TrainingArguments,)
from trl import SFTTrainer
from datasets import Dataset
from peft import LoraConfig, PeftModel
os.environ["CUDA_VISIBLE_DEVICES"] = "3"
os.environ["WANDB_DISABLED"] = "true"
os.environ["NCCL_P2P_DISABLE"] = "1"
os.environ["NCCL_IB_DISABLE"] = "1"
device_map = {"":0}
print("::::Before Loading Model, allocated GPU memory:",torch.cuda.memory_allocated())
pretrained_path = 'meta-llama/Meta-Llama-3-8B-Instruct'
#################### Prepare Data
tokenizer = AutoTokenizer.from_pretrained(pretrained_path)
tokenizer.pad_token = tokenizer.eos_token
data = {  'input_ids': [
        tokenizer.encode("Hello, how are you?"),
        tokenizer.encode("I am fine, thank you!")]}
train_dataset = Dataset.from_dict(data)

###################### Prepare Model
bnb_config = BitsAndBytesConfig(load_in_4bit = True,bnb_4bit_quant_type = "nf4",bnb_4bit_compute_dtype = "float16",bnb_4bit_use_double_quant = False)
peft_config = LoraConfig(lora_alpha = 32,lora_dropout = 0.1,r  = 32,bias = "none",task_type = "CAUSAL_LM")
print('start loading')
import time;time.sleep(2)
model = AutoModelForCausalLM.from_pretrained(
    pretrained_path,
    quantization_config = bnb_config,
    device_map = device_map,
)
model = PeftModel(model,peft_config)
print("::::After Loading Model, allocated GPU memory:",torch.cuda.memory_allocated())

######################## Train model
training_arguments = TrainingArguments(
    report_to=None,output_dir='.',
    per_device_train_batch_size=1,
    gradient_accumulation_steps=1,
    optim="paged_adamw_32bit",
    save_strategy = 'no',
    logging_steps=1,
    learning_rate=2e-4,
    fp16=True,
    max_steps=2,)
trainer = SFTTrainer(
    model=model,
    train_dataset=train_dataset,
    peft_config=peft_config,
    max_seq_length=2048,
    tokenizer=tokenizer,
    args=training_arguments
)
trainer.train()
print("::::After Training Model, allocated GPU memory:",torch.cuda.memory_allocated())

######################## Try to free GPU
import gc
del model
del trainer
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
torch.cuda.empty_cache();gc.collect()
print("::::After Free Memory, allocated GPU memory:",torch.cuda.memory_allocated())

Expected behavior
I expect the code should print the following GPU memory allocation:
Before loading model, the allocated memory should be 0
After loading model, the allocated memory should be<PHONE_NUMBER>
After training model, the allocated memory should be slightly higher:<PHONE_NUMBER>+?
After empty_cache() and garbage collecting, the allocated memory should be very low: 0~5000 (maybe?)
However, the code prints the results:
::::Before Loading Model, allocated GPU memory: 0
::::After Loading Model, allocated GPU memory:<PHONE_NUMBER>
::::After Training Model, allocated GPU memory:<PHONE_NUMBER>
::::After Free Memory, allocated GPU memory:<PHONE_NUMBER>
From the results, I see that I can not free the memory after the train()
I have done several tries, if I do not call train(), the GPU memory can be freed normally.
I have to do further procedure after training. But this memory consumption will accumulate. If I call this train() n times. The allocated memory will grow n times. BAD!
How can I free this memory? I even think this is a severe bug.

Thanks for reporting and providing a reproducer. I ran it on my machine and these are my logs (omitting fluff):
::::Before Loading Model, allocated GPU memory: 0
::::After Loading Model, allocated GPU memory:<PHONE_NUMBER>
{'loss': 2.8368, 'grad_norm': nan, 'learning_rate': 0.0002, 'epoch': 0.5}
{'loss': 3.83, 'grad_norm': nan, 'learning_rate': 0.0002, 'epoch': 1.0}
{'train_runtime': 0.5141, 'train_samples_per_second': 3.89, 'train_steps_per_second': 3.89, 'train_loss': 3.3334261178970337, 'epoch': 1.0}
::::After Training Model, allocated GPU memory:<PHONE_NUMBER>
::::After Free Memory, allocated GPU memory: 17039360

So for me, there is also a memory left after clearing the cache, but only a little, whereas for you, it's basically the same as before clearing. I'm not sure what's going on here. Could you try updating to the latest versions of PEFT, transformers, trl, accelerate, and torch?

I'm glad that this solved the issue for you.

i tried a non-peft model before and not notice this problem. So I wrongly take it as a bug of PEFT. Sorry~

It could be some strange interaction between PEFT and transformers that's causing it. As this is now patched though, I don't think it's worth it to investigate further. I'll close the PR, but if anything new comes up, feel free to re-open.


Make the detach process forward interval configurable

Setting this to a value less than the magic number of 0.2 (like 0.0) fixes the issue in #930

Thanks!


"Create an app manifest using Teams App Studio" step 6 requires further explanation

This step comprises of 3 images - please add text explaining the steps in each - images only would be an issue for people with poor eyesight.
Also - please explain how to obtain a GUID.

Fixed. Ready to close.

thanks, closing!


Use vendored intake-xarray.

The motivation is to avoid taking on all the format-specific dependencies
in intake-xarray and just use the server--client piece.

Looks good!


Membership operator doesn't work as expected for unicode strings in Python2, and Var expressions

This looks to me like two issues:

expressions that are values that contain strings don't trigger the string membership logic
expression values that are unicode strings don't trigger the string membership logic as six.strings_types contains only str, and not unicode.

Debugging values from breakpoint at https://github.com/google/dotty/blob/ee0f320c95bc978e911313ecc7dd7d0db1ea10c2/efilter/transforms/solve.py#L775
expr = {Membership} Membership(\n Literal('a message')\n Var('body'))
 _BinaryExpression__abstract = {bool} True
 _Expression__abstract = {bool} True
 arity = {int} 2
 children = {tuple} <type 'tuple'>: (Literal('a message'), Var('body'))
 element = {Literal} Literal('a message')
 end = {int} 25
 lhs = {Literal} Literal('a message')
 return_signature = {ABCMeta} <class 'efilter.protocols.boolean.IBoolean'>
 rhs = {Var} Var('body')
 set = {Var} Var('body')
  _Expression__abstract = {bool} True
  _ValueExpression__abstract = {bool} True
  arity = {int} 1
  children = {tuple} <type 'tuple'>: ('body',)
  end = {int} 4
  return_signature = {type} <class 'efilter.protocol.AnyType'>
  source = {str} 'body contains \\'a message\\''
  start = {int} 0
  type_signature = {tuple} <type 'tuple'>: (<type 'basestring'>,)
  value = {str} 'body'
 source = {str} 'body contains \\'a message\\''
 start = {int} 0
 type_signature = {tuple} <type 'tuple'>: (<class 'efilter.protocols.eq.IEq'>, <class 'efilter.protocols.iset.ISet'>)
needle = {str} 'a message'
values = {generator} <generator object __solve_and_destructure_repeated at 0x7fe778690550>
 gi_code = {code} <code object __solve_and_destructure_repeated at 0x7fe7944a81b0, file "/usr/lib/python2.7/dist-packages/efilter/transforms/solve.py", line 146>
 gi_frame = {frame} __solve_and_destructure_repeated [solve.py:146]  id:49887728
 gi_running = {int} 0
vars = {ScopeStack} ScopeStack(LibraryModule(name='stdcore', vars={'materialize': <efilter.stdlib.core.Materialize object at 0x7fe7944d2550>, 'singleton': <efilter.stdlib.core.SingletonReducer object at 0x7fe7944d24d0>, 'int': <type 'int'>, 'float': <type 'float'>, 'find': <e
 globals = {LibraryModule} LibraryModule(name='stdcore', vars={'materialize': <efilter.stdlib.core.Materialize object at 0x7fe7944d2550>, 'singleton': <efilter.stdlib.core.SingletonReducer object at 0x7fe7944d24d0>, 'int': <type 'int'>, 'float': <type 'float'>, 'find': <efilter.stdl
 locals = {TestEvtRecordEvent} <tests.analysis.tagging.TestEvtRecordEvent object at 0x7fe778684290>
  COMPARE_EXCLUDE = {frozenset} frozenset([u'store_number', u'display_name', u'uuid', u'data_type', u'timestamp', u'filename', u'store_index', u'tag', u'pathspec', u'inode'])
  CONTAINER_TYPE = {unicode} u'event'
  DATA_TYPE = {unicode} u'windows:evt:record'
  body = {unicode} u'this is a message'
  data_type = {unicode} u'windows:evt:record'
  display_name = {NoneType} None
  event_identifier = {int} 16
  filename = {NoneType} None
  hostname = {NoneType} None
  inode = {NoneType} None
  offset = {NoneType} None
  pathspec = {NoneType} None
  source_name = {unicode} u'Messaging'
  store_index = {NoneType} None
  store_number = {NoneType} None
  tag = {NoneType} None
  timestamp = {int}<PHONE_NUMBER>000000
  uuid = {unicode} u'c3f4974cacc44430b8a1b63d17308e90'
 scopes = {list} <type 'list'>: [LibraryModule(name='stdcore', vars={'materialize': <efilter.stdlib.core.Materialize object at 0x7fe7944d2550>, 'singleton': <efilter.stdlib.core.SingletonReducer object at 0x7fe7944d24d0>, 'int': <type 'int'>, 'float': <type 'float'>, 'find

I'll update this a little more when I have some more time, but in the interim:
I'm not sure what I was seeing to think that six.string_types was just str in Python2, you're quite right that this isn't an issue.
In the debug output above, the expression is Membership(\n Literal('a message')\n Var('body')) which should match the body var, whose value is "this is a message". However, this breakpoint was set at https://github.com/google/dotty/blob/ee0f320c95bc978e911313ecc7dd7d0db1ea10c2/efilter/transforms/solve.py#L775 so the function hasn't returned at https://github.com/google/dotty/blob/ee0f320c95bc978e911313ecc7dd7d0db1ea10c2/efilter/transforms/solve.py#L772 like I think it it should have.
I suspect  the issue is at https://github.com/google/dotty/blob/ee0f320c95bc978e911313ecc7dd7d0db1ea10c2/efilter/transforms/solve.py#L770 as expr.set is Var not Literal in the debug values.
Hopefully that clear things up a little. I'll try and expand a little more when I have a bit more time. https://github.com/log2timeline/plaso/issues/899 is the parent issue from Plaso where we encountered this.

And I didn't actually answer your question: the error is that an objectfilter expression like: ``body contains 'a message'``` doesn't match when run with efilter.api.apply(expression, vars=event) and event has an attribute "body" that contains a string "this is a message", and event has a protocol definition that looks like this: https://github.com/log2timeline/plaso/blob/master/plaso/containers/interface.py#L58.
That wasn't particularly eloquent, my apologies.

OK, failing test.
This event: https://github.com/Onager/plaso/blob/fix_tagging/tests/analysis/tagging.py#L56
Is not matched by this rule: https://github.com/Onager/plaso/blob/fix_tagging/test_data/test_tag_file.txt#L14
When it should be.


[Question] Make the podcast.New() smarter?

I didn't expect people to find this repo any time soon and I see a number of people already using it.  Oops.  Hehe.
There is a breaking change I wanted to do; but, I am holding off because of others that may be using it.
I want to change the podcast.New() method because of a number of reasons:

Make it simpler (don't ask for datetimes, use helper methods for them)
add Validation
with Validation, comes error handling

Basically, I want to change this:
func New(title, link, description string, pubDate, lastBuildDate *time.Time) Podcast

To this:
func New(title, link, description string) (Podcast, error)
func (p *Podcast) AddPublishedDate(t time.Time)
func (p *Podcast) AddLastBuildDate(t time.Time)

Notice that Podcast.New() no longer will take in time.Time, and now also returns an error if validation isn't correct (e.g. missing one of title, link or description).
Breaking Change
This would obviously be a breaking change to anyone currently using it (and not vendoring).  Therefore, it would require a version bump to 2.x.x.
IMO
I'm on the fence about this.  I like APIs that allow package.New() without requiring me to check for errors.  They should guarantee a result with package.New() that just works.  That was my originally intention when I created the New() method.
But at the same time, how do you know your Podcast is valid if we don't have validation checks?  The answer to that is simple: Apple rejects your podcast when you submit it for not being valid.

Added the following in commit cd785c6:
func (p *Podcast) AddPublishedDate(t time.Time)
func (p *Podcast) AddLastBuildDate(t time.Time)

Question still stands as to rather do the breaking change or not for New().

@naglis since u are the only other one I've heard using this shiny new package, could you review the question above and provide your opinion?

Hi @eduncan911,
IIUC according to RSS 2.0 spec both published date and last build date are optional, so it makes sense to not require people to set it when using New(). So I guess this comes down to the question of whether to do the breaking change now and have to support both v1 and v2 branches?
(Subjective opinion ahead) Personally, I don't mind having to set these two additional fields in New that much and if I were a maintainer of a library, I would maybe wait for more "breaking stuff" to accumulate before doing the breaking version jump.

Going to call this package final for now.  Maybe if someone finds this closed issue in some distant future, we can address a 2.0 release.
Until then, enjoy!


[misc] Add new tests for System test

Update LocalStorage tests.

Impacted TCs num(approved): New 22, Update 5, Delete 0
Unit test Platform: Crosswalk Project for Android 15.44.374
Unit test result summary: Pass 27, Fail 0, Blocked 0

@JianfengXu Please use http://www.quirksmode.org/js/cookies.html to test Cookie since the local Cookie will not work on Chrome.

LGTM


Allow passing in an e-mail string instead of a user object

Especially when doing quick mock-ups, I'd love to be able to call {% avatar_url<EMAIL_ADDRESS>50 %}

avatar_url calls get_primary_avatar which will lookup the user by their "natural key" if necessary. This means it should work just fine if you're email field is the User's USERNAME_FIELD. https://docs.djangoproject.com/en/1.9/topics/auth/customizing/#django.contrib.auth.models.CustomUser.USERNAME_FIELD


HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

What changes were proposed in this pull request?
Whenever value is returned from cache, it returns a copy object. So, that when doubleBuffer flushes, we don't see random ConcurrentModificationException errors like this.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2322
Please replace this section with the link to the Apache JIRA)
Ran freon tests with 100K Keys multiple times, now I am not seeing the error given in Jira description. Without this patch, we will see the error. (If you are not seeing error run multiple times in non-HA or just enable ozone.om.ratis.enable, and you will see the error in the first run)
How was this patch tested?
Command used for testing:
ozone freon rk --numOfBuckets=1 --numOfVolumes=1 --numOfKeys=100000 --keySize=0

https://issues.apache.org/jira/browse/HDDS-2356 issue happens here as well. From the stack I got, it looks like it may also be related to partKeyInfoList as TreeMap in OmMultipartKeyInfo.java being not thread safe. I may have little background knowledge here, but from the logs I got after running in actual env, it shows some other errors in https://issues.apache.org/jira/browse/HDDS-2356.
I wonder if we need to stay with TreeMap as a data structure since it's hard to make TreeMap thread safe.

https://issues.apache.org/jira/browse/HDDS-2356 issue happens here as well. From the stack I got, it looks like it may also be related to partKeyInfoList as TreeMap in OmMultipartKeyInfo.java being not thread safe. I may have little background knowledge here, but from the logs I got after running in actual env, it shows some other errors in https://issues.apache.org/jira/browse/HDDS-2356.
I wonder if we need to stay with TreeMap as a data structure since it's hard to make TreeMap thread safe.
Looks like after this change, there happens another recurring error in VM cluster. Please see https://issues.apache.org/jira/browse/HDDS-2356 for more info. I test several times and unfortunately the new issue seems to persist.

Thank You for trying out the fix. On a bucket, multipart upload complete cannot occur in parallel, as we acquire bucket lock and then perform the operation(during write/get), so I think we don't require TreeMap to be synchronized/thread-safe.

The change looks pretty good. A couple of minor comments, not a blocker to commit.
+1

Thanks for the review @arp7. I have replied to the comments.

Thank You @arp7 for the review.


[IOS Only] Error: Argument appears to not be a ReactComponent. Keys: clear,isFocused,focus,blur

Is it similar to RNTextInput?
I have to try this lib with react-native-ui-lib, but it doesn't work :(.
I got this error:
Error: Argument appears to not be a ReactComponent. Keys: clear,isFocused,focus,blur
import React, { useRef } from 'react';
import { TextInput } from 'react-native';
import PasteInput, { PastedFile, PasteInputRef } from "@mattermost/react-native-paste-input";
import { Keyboard } from 'react-native-ui-lib';

const YourTextInput = () => {
    const inputRef = useRef<PasteInputRef>(null);

    const onPaste = (
        error: string | null | undefined,
        files: Array<PastedFile>
    ) => {
        console.log('ERROR', error);
        console.log('PASTED FILES', files);
    };

    return (
      <Keyboard.KeyboardAccessoryView
              useSafeArea={true}
              addBottomView={true}
              renderContent={() => (
                 <PasteInput
                    ref={inputRef}
                    disableCopyPaste={false}
                    onPaste={onPaste}
                    multiline={true}
                    blurOnSubmit={false}
                    underlineColorAndroid="transparent"
                    keyboardType="default"
                    disableFullscreenUI={true}
                    textContentType="none"
                    autoCompleteType="off"
                />
                /* <TextInput
                    ref={inputRef}
                    multiline={true}
                    blurOnSubmit={false}
                    underlineColorAndroid="transparent"
                    keyboardType="default"
                    disableFullscreenUI={true}
                    textContentType="none"
                    autoCompleteType="off"
                /> */
              )}
              kbInputRef={inputRef}
              kbComponent={kbComponent}
              onItemSelected={onCustomKeyboardItemPressed}
            />
    );
}

Does the example app work for you? What is your react and react-native version?
This should be a drop replacement for RNTextInput.
I can take a look in a few hours but it would be good if you can provide the answers to my questions ;)

Thank you for quick response.
The problem may be could not findNodeHandle of it's ref.
https://github.com/facebook/react-native/blob/feae814153783a0d03d0a332917991f139c36e9f/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js#L23340
I think the inputRef is missing _nativeTag property like RNTextInput.

The problem is resolved! I have edited this method and it works. Thank you.
https://github.com/mattermost/react-native-paste-input/blob/03627dbf04d41ab39593ce7399cdb9ba9fdac547/src/index.tsx#L205
useImperativeHandle(
    ref,
    () => ({
        clear,
        isFocused,
        focus: () => inputRef.current?.focus(),
        blur: () => inputRef.current?.blur(),
        ...(inputRef.current || {}) <-- here
    }),
    [clear]
);

Would you please submit a PR so it is fixed upstream? Thanks

Would you please submit a PR so it is fixed upstream? Thanks

Yes, please. It's #6. Thank you.


Automaic render index.html under directory path

We should provide an option whether rendering index.html or predefined directory listing page view for users.

Done at #26

Merged at #26


No console output on PHP errors if testdox is set to true

When I  have testdox set to true, I just receive a "Testing Failed" message in the console, however if I set it to false, then I receive php errors directly into the console which is the ideal behavior.. Is there a way to keep testdox on, yet also have PHP errors outputted to console? thanks!

Hey Jeff
I will have a look at this tomorrow and see what’s up.


new version targeting varnish 7.1

should just be a formality, but a few APIs in the VDP/VFP sectors have changed, and they will break https://github.com/gquintard/vmod_reqwest

done


Excellent Grid Control! Recently move from core 1.0 to 2.1. Filter stopped working.

Filter stopped working. Currently on NonFactors.Grid.Mvc6(3.1.0). _Grid.cshtml won't compile. Copy _Grid.cshtml file from NonFactors.MVC6.Template and it works. But lost filterable icon. Can you please post an example of .net core 2.1 with Grid.MVC6(3.1.0)? Thank you SO MUCH!

This repository is the source of http://mvc6-grid.azurewebsites.net/, which runs netcoreapp2.1, so you can use this as an example and make sure you are following installation steps.

Thank you so much for your quick response. I followed the installation steps. It won't compile. I fixed the error manually. This is the error: "IGridColumn" doesn't contain a definition "IsFilterable".
I checked the IGridColumn interface and fixed from "column.IsFilterable" to "column.Filter.IsEnabled". I am upgrade from Grid.Mvc6(2.1.0) to (3.1.0)
I download code from this repository. After I update from 2.1.0 to 3.1.0, all the filters and sorting don't work anymore.

In my own project, we are on AspNetCore.App 2.1.3 and Mvc6(3.1.0). It was working fine when we were on netcoreapp 1.0 and grid.mvc6(2.1.0).  Now the filtering icon is gone.

Please suggest. Thanks a lot.

You didn't call .Filterable(true) on your currency column.

I tried both. Happened to post a version didn't call. Now the icon would show but there is no click event is registered with the newest js file. also paging not working. Thanks.

You can check js stack trace to find why it's not initializing correctly.

Did you find the problem?

Really sorry for my late reply. Have been struggled for a few days. Just
found out the reason yesterday. Everything is correct except my model is a
three layer nested objects. Something like an organization that has a list
of People and People has Children. The controller is passing the
Organization to the page and the page is displaying the grid of the list of
people.
If the view model is the organization and grid is binding to
Organization.People, then the filter would not be able to registered. If my
view model is people directly, then everything works fine. But it works
with Grid.MVC (<IP_ADDRESS>).
Anyway, I changed my objects structure a little bit and I know the reason
now.
Thank you SO MUCH for your help!!!
Wei
On Wed, Oct 3, 2018 at 2:57 AM Muchiachio<EMAIL_ADDRESS>wrote:

Closed #31 https://github.com/NonFactors/MVC6.Grid.Web/issues/31.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NonFactors/MVC6.Grid.Web/issues/31#event-1881457112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdmwVB765jRxwUy7_UCYYkpy5lwGJ9P7ks5uhIoFgaJpZM4WzILM
.

--
Thanks,
Wei Gao(408) 887 - 1678
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is
for the sole use of the intended recipient(s) and may contain confidential
and privileged information or otherwise protected by law. Any unauthorized
review, use, disclosure or distribution is prohibited. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies of the original message.


don't cache rotary_embeddings so we don't inadvertently weight_decay

we were stopping grad on them, but that doesn't stop weight decay from  doing stuff to them. We should really add a buffer to eqx.field....
Oof.

This means the regularization loss has a component of L2norm(ROPE sin&cos)? It should only affect the loss magnitude but nothing else right? cuz ROPE doesn't update.

right that's the problem. b/c it's stored it gets weight decayed


Expect html content in email template and change messages content typ…

…e accordingly.
An email template may contain html, in order to render it properly we must set correct content type for an email message.
is_template_html property tells us if message does have some <> and </>
Removed html_content param as its not needed anymore.
Refs MH-50

I think this is reasonably bulletproof.
Thanks. :)


[BUG] Aborted (core dumped)

Required prerequisites

[X] I have read the documentation https://safety-gymnasium.readthedocs.io.
[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[X] Consider asking first in a Discussion.

What version of Safety Gymnasium are you using?
0.1.2.dev2+ge3e3fa1
System information
3.8.16 (default, Jan 17 2023, 23:13:24)
[GCC 11.2.0] linux
0.1.2.dev2+ge3e3fa1
Problem description
When I execute the example/env.py, I got the bug:
root@autodl-container-b37a11a83c-666dc781:~/safety-gymnasium/examples# python env.py
/root/miniconda3/lib/python3.8/site-packages/glfw/__init__.py:912: GLFWError: (65544) b'X11: The DISPLAY environment variable is missing'
  warnings.warn(message, GLFWError)
/root/miniconda3/lib/python3.8/site-packages/glfw/__init__.py:912: GLFWError: (65537) b'The GLFW library is not initialized'
  warnings.warn(message, GLFWError)
python: /builds/florianrhiem/pyGLFW/glfw-3.3.8/src/monitor.c:445: glfwGetVideoMode: Assertion `monitor != ((void *)0)' failed.
Aborted (core dumped)

Reproducible example code
The Python snippets:
# Copyright 2022 Safety Gymnasium Team. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================
"""Examples for environments."""

import argparse

import safety_gymnasium

def run_random(env_name):
    """Random run."""
    env = safety_gymnasium.make(env_name, render_mode='human')
    obs, info = env.reset()  # pylint: disable=unused-variable
    # Use below to specify seed.
    # obs, _ = env.reset(seed=0)
    terminated, truncated = False, False
    ep_ret, ep_cost = 0, 0
    while True:
        if terminated or truncated:
            print(f'Episode Return: {ep_ret} \t Episode Cost: {ep_cost}')
            ep_ret, ep_cost = 0, 0
            obs, info = env.reset()  # pylint: disable=unused-variable
        assert env.observation_space.contains(obs)
        act = env.action_space.sample()
        assert env.action_space.contains(act)
        # Use the environment's built_in max_episode_steps
        if hasattr(env, '_max_episode_steps'):  # pylint: disable=unused-variable
            max_ep_len = env._max_episode_steps  # pylint: disable=unused-variable,protected-access
        # pylint: disable-next=unused-variable
        obs, reward, cost, terminated, truncated, info = env.step(act)
        #print("obs",env.observation_space.spaces)

        ep_ret += reward
        ep_cost += cost

if __name__ == '__main__':
    parser = argparse.ArgumentParser()
    parser.add_argument('--env', default='SafetyCarGoal2-v0')
    args = parser.parse_args()
    run_random(args.env)

Command lines:
python env.py

Traceback
No response
Expected behavior
No response
Additional context
No response

We will reproduce and test the bug.

Try this and
apt-get install libosmesa6-dev apt-get install python3-opengl

feel free to reopen it.


Delete Workflows

Description
As an admin,
so that I can remove outdated or incorrect workflows,
I want the ability to delete workflows.
Acceptance Criteria:

[ ] Admins can navigate to a delete option for workflows.
[ ] Workflows can be deleted with confirmation.
[ ] Deleted workflows are removed from the system.

Added blocked to due being blocked by #153.


Init row

Allow customizing of the initial row for more flexible layout options. This also fixes a small bug w/ the positioning of even rows when spacing is provided.
Spacing issue before:

Spacing issue after:

w/o initRow:

w/ initRow:

Thanks for the patch! Published in 2.0.2 and I added you as a maintainer on github and npm.


the problem

new request

my new request

Hi @Sarvesh19, thank you for your PR. I will check it later. Could you put more details in description?


Add a setup.py

This would make it easier to install on platforms like NixOS.
  plex-mpv-rev = "3d332db59580dd76d843689b1809dc0869aa4972";
  plex-mpv-shim = pkgs.python3Packages.buildPythonApplication rec {
    pname = "plex-mpv-shim";
    version = "0.1-${plex-mpv-rev}";
    name = "${pname}-${version}";
    src = pkgs.fetchFromGitHub {
      owner = "iwalton3";
      repo = "plex-mpv-shim";
      rev = plex-mpv-rev;
      sha256 = "06xdp54cxvf5q3i6zhyss2jlbkp46fd9yshyp0ykgc529r35snrc";
    };
    propagatedBuildInputs = with pkgs.python3Packages; [ mpv requests ];
    installPhase = ''
      mkdir -p $out/bin
      cp ${src}/mpv-shim.py $out/bin/mpv-shim
      chmod +x $out/bin/mpv-shim
    '';
  };

I have added a setup.py. (The project this was based on had one, but in porting it to python3 I had to change some things to get it to work.)

Wow, thanks for the quick response!


small_delta >= 256

terminate called after throwing an instance of 'std::runtime_error' what(): thread failed with: thread failed with: small_delta >= 256<PHONE_NUMBER>9)
getting this one after working for few hours.
memory ram problem or?

Maybe see #289.

thank you


Remove "This text does not support clickable word meanings." for mukundamAlA

"This text does not support clickable word meanings.
To test this feature, try the Ramayana or the Mahabharata."
on https://ambuda.org/texts/mukundamala/all should be removed since clickable word meanings are available.

Fixed in 414958d8ddc84bd0c0365eec34f17bd6f68f5753.

For future reference - If you refer to the issue in the changelist description, eg. "Fixes https://github.com/ambuda-project/ambuda/issues/74", the issue is auto-closed and a link appears under the issue thread to the fix.


patchActivation(Bash|Csh|Fish|Posix): init and apply to package root

Description of changes

This PR provides a clean way to patch an activation scripts (or any shell scripts meant to be sourced). It inserts a PATH prefix for the sourced commands and clean it up afterward, not polluting the PATH and avoiding issues caused by find-and-replace.
Most of the files added are test cases, which ensure the main packages work as expected.
The hooks are apply to package root to patch its activation scripts. A package test root.passthru.tests.test-thisroot is also added to verify the patching. (Continuation of #169579, cc: root maintainer @veprbl )
Things done

Built on platform(s)

[X] x86_64-linux
[X] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@ofborg build patchActivateBash.passthru.tests patchActivateCsh.passthru.tests patchActivateFish.passthru.tests patchActivatePosix.passthru.tests

@ofborg build root

@ofborg build patchActivationPosix.passthru.tests

Sorry for the ambigualty.
This PR introduce tools to patch the shell scripts that is meant to be sourced by the software users. The typical use case is to patch the "activation scripts" (scripts that acts like the bin/activate script of a Python virtual environment that alters PATH and some other environment variables to make the specified version of program available in this session).
Possible reasons a software shipped with such activation scripts:

It requires some environment variable to be changed to work.
It is typically not installed globally, either because it is not available in some mainstream package managers like apt, or because users would like to use it in a per-project basis.

One such software is CERN ROOT, a data analysis framework. It comes with thisroot.sh, thisroot.csh, thisroot.fish, etc. in its $out/bin/ for users to source.
The reason not to just insert a line export PATH=/nix/store/xxxxxx-foo-0.0.0/bin:$PATH in the beginning is because it will also go into the session when sourced by the user. These tools also add lines of commands to the bottom to clear up the inserted part of PATH.
I'll need to find an way to elaborate it a bit. (I'm not a native English speaker.)

@infinisil is this even worthwhile to pursue given that the duct-tape-and-bubble-gum nature of hooks makes them prone to replacement by the Nixpkgs architecture team at some point?

I don't think it's a problem, we shouldn't slow progress of nixpkgs without having any concrete plans yet. It might still take a long time for those to materialize.

@ofborg build patchActivationBash.passthru.tests patchActivationCsh.passthru.tests patchActivationFish.passthru.tests patchActivationPosix.passthru.tests

The reason why I don't let root.passthru.tests.test-thisroot check for unbound variables so far is because thisroot.sh itself needs refactoring from the upstream.
Here's the PR I sent to the upstream:
https://github.com/root-project/root/pull/11557

Rebase onto master and use the passthru parameter provided by #186323, as it finally made it into the master branch.

@ofborg build patchActivationBash.passthru.tests patchActivationCsh.passthru.tests patchActivationFish.passthru.tests patchActivationPosix.passthru.tests

@AndersonTorres Could you help take a look at the patchActivationScriptCsh?
My knowledge toward C Shell is very limited, so I simply use sed to do the string substitution. Not sure if there is a vanilla way to do so.

@veprbl I just notice that the $out/bin/thisroot.sh in current version of root in Nixpkgs doesn't contain commands like ps and lsof, which is why it doesn't break the dependent packages so far. The dependent packages get broken once overriding root.src with the upstream master branch source.
There's still a need to patch thisroot.sh for the current version to allow it to be sourced in a bare-minimum environment and make the behavior more deterministic.
The two commands are introduced since https://github.com/root-project/root/pull/10332 . Maybe I should remove procps and lsof from the dependency list of the current expression of root package.

@ShamrockLee It's okay to keep lsof and psutils for the future update

This looks way confusing to me. I will read it later when I have more time.

 Please force push a last time and let's merge this.

No problem. I'll rebase and squash them.
Update: Done. Thanks a lot for all your reviews!

Apparently there is still a merge conflict.

That's due to the root package update (#200412). Rebased.


Clarify exactly which query parameters are reserved

The spec says things like:

The filter query parameter is reserved for filtering data.

and

The page query parameter is reserved for pagination.

But it's pretty clear that we don't (only) mean the literal parameters named page and filter... we also mean parameters like page[offset]. (Moreover, the concept of a named query parameter isn't even in RFC 3986, so we should probably mention that it's actually an idea we're getting from—I think—HTML forms.)
We could fix this issue by just specifying the [...] form, but I wonder if there's an opportunity here to clean up the design a bit (as reserving too many query parameters is a bad idea anyway, and the notion of a query parameter being "reserved but not specified" has never made much sense to me).
For now, though, I just wanted to document the issue. Ref: http://stackoverflow.com/questions/33838358/jsonapi-org-correct-way-to-use-pagination-using-the-page-query-string

Will be addressed by #1308.

This has been clarified in v1.1 by introducing that the term query parameter family and stating that the entire family is reserved:

The page query parameter family is reserved for pagination. Servers and clients SHOULD use these parameters for pagination operations.

The filter query parameter family is reserved for filtering data. Servers and clients SHOULD use these parameters for filtering operations.

A “query parameter family” is the set of all query parameters whose name starts with a “base name”, followed by zero or more instances of empty square brackets (i.e. []) or square-bracketed legal member names. The family is referred to by its base name.

I'm going to close this issue. Please speak up if you see the need for further clarification.


Added run code link to clear vector

Thank you for your contribution @leemelisa  :+1:
:relaxed: :relaxed: :relaxed:


Nodes 1.0: Add Next/Previous buttons to CurrentImageNode.tsx

What type of PR is this? (check all applicable)

[ ] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[ ] No

Description
Adds Next/Previous buttons to CurrentImageNode.tsx

Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

I will wait till nodes 1.0 is merged in to main


Inconsistent installations

Sometimes when I run npm install on this package, it gives me an error saying that it found no compatible version.
If I run it again, it installs just fine. It might have to do something with case sensitivity.

Should be fixed with 0.6.0. If not, feel free to duplicate and reopen.


[SourceKit] Don't report the ObjC runtime name without @objc(Name)

We used to compute the mangled name in other cases, but document structure is a syntactic request and can't guarantee that the class/protocol we're getting the mangled name of is valid in any way so it often breaks assumptions in the mangler and causes it to crash. It's not clear if the runtime_name is actually being used anymore, so this change restricts reporting it to just the cases where we don't need to mangle, eliminating this class of crashes.
rdar://problem/40956377

@swift-ci please test

@jpsim  do you know of any tools that rely on key.runtime_name from sourcekitd's structure data?

Not as far as I'm aware, thanks for checking.


Configurable window geometry

Adds the ability to specify window geometry through either a config option or
command line flag. Geometry is set early to avoid "teleporting" the window from
its initial position (typically 0x0) to its configured position.
(Somewhat) resolves #41 -- Ideally, at some point this should become POSIX compliant à la COLUMNSxROWS+X+Y. For now, a combination of dimensions and geometry is a somewhat competent workaround.

This is my first "substantial" contribution to this project and I'm new to the code base, so I would appreciate any feedback on style and the like. I tested this on my local machine and nothing seemed out of the ordinary. I mostly copied the code present for setting the dimensions of the window and modified it as necessary.
The one thing I'm not very happy with is the set_position function in src/window.rs -- it looks messy in my eyes. If there is a better or more majestic way to do what I did, I would appreciate the tip.
Should I add the window geometry to the info! call here: https://github.com/jwilm/alacritty/blob/master/src/main.rs#L136?

Current problems:

[x] FIXED: Terminal now spawns at absolute 0x0, as opposed to 0x0 of the current screen.

Thoughts on making geometry configurable via the flag only, rather than by flag and config file? Now that I think about it, it doesn't make sense (to me) to be able to set the position of the window via the config file. Removing that part also makes it easier to decide whether or not to respect the specified geometry: if the flag is present, use it. Otherwise, respect current behavior of letting the window manager take care of it.
Unless there's any dissent on removing the config file stuff, I think I'll go ahead and do just that in the next push.

Changed names to more accurately reflect that we're setting position, not geometry (for now). Commented out position in config by default, make position field in WindowConfig an option (is there a better way you would prefer I do this?). Let window manager handle positions if no flag or config specifies it. Marked set_position uses with TODO so we don't forget to use with_position if/when it becomes available.
Brain was working a little slow this morning, hopefully I've addressed most/all of the issues.

Thanks for bearing with me (and fixing up those last bits of mess)!


Fixes #9290 Policies Don't Prevent Custom Properties Modification by …

…Object Owner
Describe your changes :

See #9290 for more details

Type of change :

[x] Bug fix

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Failures are unrelated to this patch. Merging it.


Stage 4 : Docker and container (optional)

[ ] Get Started with Docker
[ ] new an accout of docker hub
[ ] Install Docker in your system(for mac and linux user )
[ ] Run docker service
[ ] pull a existing image from docker hub
[ ] try docker-run command

[x] Get Started with Docker
[x] new an accout of docker hub
[x] Install Docker in your system(for mac and linux user )
[x] Run docker service
[x] pull a existing image from docker hub
[x] try docker-run command


Please document what "extras dependencies" are included in the Extra layer

What were you initially searching for in the docs?

What additional packages are included in the Extras Layer.
Is this related to an existing part of the documentation? Please share a link
Does not appear to be.
Describe how we could make it clearer
List the extra packages included in the Extra Layer.
If you have a proposed update, please share it here

Hi @gwlester, just to clarify: do you want to know what powertools functionality you will have by using the extras layer or are you interested in the python modules that are inside the extras layer?
I can see that the former is not clearly explained in the docs. The latter is part of the dependency definition in pyproject.toml

FormerSent from my T-Mobile 4G LTE Device
-------- Original message --------From: Alex @.> Date: 7/23/21  00:57  (GMT-06:00) To: awslabs/aws-lambda-powertools-python @.> Cc: Gerald Leter @.>, Mention @.> Subject: Re: [awslabs/aws-lambda-powertools-python] Please document what "extras dependencies" are included in the Extra layer (#538)
Hi @gwlester, just to clarify: do you want to know what powertools functionality you will have by using the extras layer or are you interested in the python modules that are inside the extras layer?
I can see that the former is not clearly explained in the docs. The latter is part of the dependency definition in pyproject.toml
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Hey @gwlester , I think something went wrong in your last answer 😅 I can't really see the content of the message.

what powertools functionality you will have by using the extras layer

Hi @gwlester ,
thanks for the follow up. The extra layer is only required for the parser utility function, from the docs:

Core plus extra dependencies such as pydantic that is required by parser utility.

I will make it more crispy in the docs that this heavy 75mb dependencies on top will only be necessary for the parser feature.

@am29d  i think the documentation was updated for it no ?

Hey @DanyC97 thanks for the info. Yes, I double checked and it is actually already in the docs. 👍


LCFS - Show red toast on network errors

As a tester of LCFS, I want to know as soon as a network failure happens so I can better report issues to developers.
Currently network errors fail silently, often leaving the loading spinner or updating message. We want to use react material toast handler to show failure toasts when a 400+ response is received.

hi @kevin-hashimoto , is error 422 just a validation error? Can we exclude those from the toast?


Add gridded attributes input file and forcings input file for test basin

Purpose
This PR adds an input NetCDF file containing gridded model attributes (e.g., land use, soils) for an example application of the model for the area draining to USGS Gage ID 04185000 (Tiffin River at Stryker OH). The PR also adds a (lumped) forcings file for the test basin using AORC data. This PR also adds the R script used to create the NetCDF file and the python script used to create the forcings file.
Additions
/data/TiffinGriddedAttributes.nc is the NetCDF file containing gridded model attributes for the test basin.
/data/TiffinForcings.dat contains the lumped forcings for the test basin.
/test/analysis/hyf.gpkg is the hydrofabric geopackage for the test basin.
/test/analysis/CreateGriddedAttributesNCFile.R is the R script used to create /data/TiffinGriddedAttributes.nc. Note that this script requires a directory of csv files -- one csv file for each catchment in /test/analysis/hyf.gpkg. The csv files contain lumped AORC forcings. The directory and zip file containing these files was too big to upload to this repo. Please contact me if you would like a copy to test this script.
/test/analysis/GetTiffinForcings.ipynb is a jupyter notebook used to create /data/TiffinForcings.dat.
Changes
/data/netcdf_input.nc was removed from the repo. data/netcdf_input.nc contained dummy model attributes.
/test/analysis/create_dummy_netcdf.py was removed from the repo because this file was used to create multiple nc files -- one for each gridded attribute (e.g., land use, soils). However, /test/analysis/create_dummy_netcdf_singlefile.py was added in PR #85 to create a single nc file to contain all gridded attributes and the code base now assumes a single nc file.
Testing
The shell command ncdump -h GriddedAttributes.nc (executed within /data/) gave this output.
I manually examined all variables and dimensions within /data/GriddedAttributes.nc.
Notes
Soil color is a required gridded model input variable/attribute but was not available via the Lynker AWS server, which /test/analysis/CreateGriddedAttributesNCFile.R queries to obtain all other model attributes. The Noah-MP user guide states that, "for a case lack of soil color data, one may choose a medium dark color index (= 4 or 5). For a sandy soil or desert, it is better to choose the lightest index (=1)" (pg. 15). A soil color value of 5 was assumed across the entire model domain for the test basin.
Noah-OM's capacity to read-in forcings needs to be refactored to support gridded forcings. This PR created a lumped forcing file for the entire model domain wherein the forcings for any given day correspond to the weighted mean forcings for that day across all of the test basin's constitutient hydrofabric catchments, weighted by catchment area.

@SnowHydrology, the forcings file that this PR adds to the repo essentially represents a lumping of lumped forcings. If we are uncomfortable with the extra lumping, it seems that we could simply switch to a smaller model domain composed of a single hydrofabric catchement. Let me know if I'm not making any sense or if you'd like to discuss further.


[YBUG.IO] #58 - If a user buys SOV and is...

If a user buys SOV and is waiting e.g. Pending for user" message appears and then they click any links like Input "Upgrade Code" or "Request higher limit" or discord.com/invite" etc thay are take off this page and when returning to the Sale page then they cannot see the "Pending for user" message so how do they know if the last Buy completed or is cancelled and they must start again? I think you should force an immediate refresh of the Sales page when a user opens it as I now see the "pending for user" message re-appear after a few seconds while I write this. Force a refresh on opening the page. thanks
Source url: https://test.sovryn.app/sales
Reported by:
Reported at: 14 Jan at 19:38 UTC
Location: ES, Catalonia, Barcelona
Browser: Chrome 87.0.4280.88
OS: Windows 10.0
Screen: 1920x1080
Viewport: 1536x750
Screenshot:

For more details please visit report page on Ybug:
https://ybug.io/dashboard/reports/detail/gfh08cd4fjg6047z3n73

Duplicate of #181

Duplicate of #181


Fix opinion scraper for Missouri Eastern Appellate Dist. court

Also changes super class for all Missouri opinion scrapers to OpinionSiteLinear.
Closes #492
Closes COURTLISTENER-23G

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Grecia Cortes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix indexing for old custom events

Summary

Custom events that were added before #230 are now one day earlier than they're supposed to be. This is because Sunday is now the first day instead of Monday.
To resolve this issue, we have to check if a custom event's days array is of length 5 (instead of 7) in calenderizeHelpers.js. If the array is of length 5, dayIndex should be incremented by 1 so that all the old custom events are shifted to the right day.
Additionally, we have to make sure the custom events have the correct day on the Added Classes page. The Custom Events dialog for old custom events should also have the correct days checked/selected.

Test Plan

Added custom events using the code before #230. These custom events are now in the correct place after this bug fix.
The Added Classes page correctly displays custom events.
The Custom Events dialog is correct for old custom events.
Adding/deleting custom events on the weekdays and weekend still works.
Loading, saving, and screenshotting the schedule all work normally.

Issues
Closes #292

Follow up question on this -
If I understand the code correctly, for someone who had days.length == 5 if they load and resave their schedule using this change, the next time they load, days.length == 7 right?
Since future users won't have this problem and this fix will eventually resolve the issue for everyone from this quarter, does that mean next year we would be able to remove the extra logic for this fix to simplify the code?

Currently, if a custom event had days.length == 5, the user would have to edit the custom event and save that edit in order to get days.length == 7. I can definitely try to make it so that saving the schedule again will make it change it to days.length == 7; that sounds much better.
We can definitely remove all the conditional logic after this quarter ends because all future custom events will have an array that supports the 7-day calendar.

I can definitely try to make it so that saving the schedule again will make it change to days.length == 7; that sounds much better.
Since we can delete the conditional logic after this quarter, this is probably not worth the effort. I'll add an issue for this so we don't forgot!


Add support for jupyter-server-proxy

Using proxy support implemented in #143, it should be easy to support jupyter-server-proxy for users that run Jupyter through reverse proxy.

To test, assuming jupyter-server-proxy is installed:
DWAVE_INSPECTOR_JUPYTER_SERVER_PROXY_EXTERNAL_URL='http://<IP_ADDRESS>:8888/' jupyter notebook

Open Jupyter notebook and run:
import dimod
import dwave.inspector
from dwave.system import DWaveSampler, EmbeddingComposite

# define problem
bqm = dimod.BQM.from_ising({}, {'ab': 1, 'bc': 1, 'ca': 1})

# get sampler
sampler = EmbeddingComposite(DWaveSampler(solver='Advantage_system4.1'))

# sample
sampleset = sampler.sample(bqm, num_reads=100)

then open the Inspector with:
dwave.inspector.show(sampleset)

Now notice that no request goes to http://localhost:18000 (the location of the inspector server) -- rather inspector requests are proxied via http://<IP_ADDRESS>:8888/proxy/18000/<...>.


Update External-Resources.md

I clicked the "edit" button from the docs to add a project I worked on with Swirrl, the ONS Structural Search demo. I think it's a decent example of a non-trivial re-frame project and was recently made public, so wanted to offer it here as an addition. Let me know if this is the wrong place or way to submit an update to this list! Thank you for all the amazing work that's gone into this project.

Very cool @kiramclean Thanks for sharing.


APP support: app store, play store, chrome mobile phone, desktop

A very important topic has been raised in PR #10.
We were talking about desktop support and chrome version, compares to supporting the app in app stores  (app store (iOS) and play store (Android)
Here is my first message:

But about desktop, here you are showing a screenshot for desktop, and on the other PR you're talking about the browser back button.
The app is designed to be a mobile app, even if right now we are using chrome to develop the app. A lot of code will be specific for mobile purposes (pull-to-refresh, action sheet, etc0 and for cordova(phone camera, phone contacts). This thread on the forum explains my point http://forum.ionicframework.com/t/why-no-desktop/7908/6 (see the answer of mhartington).

So just to be clear (since @marcandreoli is reading Github notifications):
the code on this repository should be only for a cordova webview for phones and tablets
if we want a desktop version app, we will have to make a regular angularjs app or any other technology (we will be able to reuse some services and some code). We will have to use another CSS framework.

@valdrinkoshi replied

Well no, the code should work in a generic browser (phone or not). I don't remember discussing about limiting the support to phone only (which phone btw? iphone only? android only?). Also, we won't limit the support of hybrid apps only, otherwise we'll be trapped in the circle of publishing a new app (app store, play store).
About mobile specific features, currently we don't have any. Action sheet behaves quite decently also on desktop. I don't think it will harm if we allow users to access homecooked also from their browser on desktop. We should support phone and tablet, and consider "tablet" experience also from desktop.

So for me there is a big question here which needs to be cleared out as soon as possible.
Ionic is for mobile hybrid apps (web technologies embedded in native applications). That means it is not designed for desktop browser.  On their concept page http://ionicframework.com/docs/concepts/structure.html, the first sentence is pretty clear:

Ionic apps are built with Cordova.

About your comments:

otherwise we'll be trapped in the circle of publishing a new app (app store, play store).

It is really not an issue + we are building mobile apps, so we will have to go through validation

About mobile specific features, currently we don't have any.

We will have a lot very soon. Camera/Gallery for pictures for instance.
For the future:

push notifications
native facebook connect
contact list access
phone number access
being able to start a call
being able to send SMS

You won't be able to do anything like that on browsers.

Action sheet behaves quite decently also on desktop.

You need to have a specific UX, you can't just have action sheet and pull to refresh on desktop. That won't work in terms of UX

consider "tablet" experience also from desktop

No, you have to consider tablet, a simple special case for phone, with a wider screen.
So to be clear, ionic is for hybrid apps if you guys want a "browser apps", which means not a native app but an app that you access in your browser from a URL. Ionic is not the appropriate technology. Ionic is for mobile apps for iOS, Android and other platforms (Windows phone etc).
IMHO, native apps is definitely the way to go, you can benefit of native features like push notifications, access to camera/gallery, provide native experience, etc. Also if you are using a browser, the user will have to log in every time because you won't use a shared localstorage to store the user token (security issue here, on a cordova, each app has its own localstorage).
So I am for the support of Android and iOS for the alpha, tablets can come for the v1 (very easy to maintain). And do not let the users use browsers to access the app. We are doing a native app not a web app.

Please read the updated issue, I hit saved by mistake.

Ionic brings a lot of stuff for supporting hybrid apps, but works quite well on browser too (mobile and desktop). All ionic UI widgets are designed for the mobile, but they still behave good on desktop as well, and on the web browsers of the devices. I wouldn't lock ourselves in hybrid/native apps, I believe this might slow us significantly. We already discussed about the support of which platforms, and for v1 we want to have 1 codebase that works on the web browser of as many platforms as possible.
We need to get location of the user and upload images from their device. Both are possible on a webapp (see http://www.html5rocks.com/en/tutorials/getusermedia/intro/)
@marcandreoli give your input as well. Do we want to support only iphone for v1? in that case we can go hybrid/native and that's it. This is a shift from the initial plan, parts of the app have to be revisited (e.g. facebook integration)

We can go hybrid/native after v1, when we have enough metrics on our users, which devices are mostly used, etc..

For notifications, we'll rely on sms for v1

why iphone only? the support for android does not require more work for the v1.

It would mean another store to follow, wait for approval, etc.
We should provide native application for v2. Web support will allow us broader audience and freedom of updates.
At least, that's my understanding so far. We integrated facebook with their web SDK for this reason. If this is no more true, we have to adjust soon. @marcandreoli please chip in.
@jonbwhite FYI

IMHO, going native after the v1 is not the right way to do it. People are expecting native apps, they won't use their phones, go to the browser and enter the app URL. That's for sure. They just want to tap an icon.
The effort of going native is not that big as you think. Ionic is developing something to facilitate and bypass the struggle of app store: http://docs.ionic.io/v1.0/docs/deploy-install
The android store validation is about 12 hours. The iOS store validation is between 7 days to 3 weeks. So by experience, android is way easier.

That's true for the buyers, but maybe for chefs having a desktop/tablet version might be more useful.
There is a way to have your website as an icon of iphone too (google maps used to do that for a while until they didn't implement the google maps app for ios).
The key thing we should understand here is: should we support desktop or not?
If no, let's just go hybrid/native. If we want to support desktop, let's go with web application

Yes, mobile is definately the priority over desktop. Since the UX would vary on a desktop, let's focus on mobile, and put browser availability on hold. Localization for tablets is a low hanging fruit, which we can pursue shortly after the Alpha.

I am still very much in favor of 1 codebase that works accross the web browsers of as many platforms as possible.

Alright then, v1 will be only on iphone/android native apps.
@marcandreoli, we'll see where we are after v1, and implement desktop version reusing services mainly, rewriting the views.

Keep in mind that many of our vendors will be "average Joe's": guys who are more likely to use Android devices.
For the Alpha, I was hoping to make the app available through the Play store on Android (since it takes 24hours to get going), and Ionic for iOS (since it takes 3 weeks to possibly be accepted on the Apple store). @valdrinkoshi @dbaq Is this feasible?

I think we should go fully mobile on both platforms. Dont worry about the validation time of iOS. Let's focus on the dev and iterate quickly on the most important features.and everything is going to be fine even if we have to wait 2 more weeks to have the iOS version out.

Ok thanks.
@dbaq I assume that once an app has been accepted on the Apple store, code changes (updates and enhancements) do not take 2 weeks to get approved, but are pushed automatically. yes?

Nope, Around 10 days. But ionic is working on a service (link in my comment above). To update remotely so we can skip the validation process.
Complains to apple for that or Arthur. It is the same thing for the all apps.

I agree, let's go with native apps only. I will enable the developer account for apple already and include @dbaq as dev there

Closing this issue.


Download link URL typo

cc0-both-country.mmdb
github.com/HostByBelle/IP-Geolocation-DB/releases/latest/download/cc0-botgh-country.mmdb

Whoops!
Fixed it, thanks :)


QUESTION: Less memory-intensive approach for getting a whole country network

I am trying to get a road network for the whole of peninsular Spain using the data from Geofabrik and it either times out or it returns the following error
MemoryError: Unable to allocate 1.08 GiB for an array with shape (145087585,) and data type float64
I'm using the following code (osm.pbf file is stored in my unit).
osm_path = "spain-latest.osm.pbf"
osm = OSM(osm_path, bounding_box = abgdf.loc[0, "geometry"])
nodes, edges = osm.get_network(nodes=True, network_type="driving")

Is there any way I can reduce the memory use of this operation or circumvent the error? For the record, I'm using a Lenovo Thinkbook 14 with Windows 10 installed (64 bits) and the following specs
11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40 GHz 2.42 GHz
RAM: 16 GB
Thanks in advance.

@marcbosch-idencity Hi! This indeed happens because you run out of memory. The next release of pyrosm aims to improve the control of the memory footprint in a way that it should be possible to read nodes and edges covering even larger countries such as Spain (see #87). Currently, it is possible to read larger countries using iterative approach by i) selecting data for smaller regions at a time (i.e. specifying bounding box/polygon when initializing the reader) and ii) then storing that e.g. to a temporary file, and then iii) merging all those sub-regions into a single GeoDataFrame using geopandas. Notice that this is slower approach because filtering the data while reading tend to take time (the coordinate lookups are slow).

Thank you so much! I'll try the bounding boxes approach by the meanwhile.

Is this change implemented? I'm trying to extract US West features but my Python kernel does (out of memory). I'm on a 16gb Mac.


Grafana does not show the evolution of numbers of broker online

Ping the Strimzi guys for this to be fixed.

IMHO this is grafana behaviour - you need to refresh via icon in top right corner

Clicko on Last 1 hour in top right corner, new window opens. Left most corner - Custom range, at the bottom choose Regresing every...


T and S output with parcels in POP

Discussed in https://github.com/OceanParcels/parcels/discussions/1298

Originally posted by norafried February  2, 2023
Hi,
I'm trying to get T and S properties along the particles tracks with POP data. I followed this tutorial and got until the kernel. Then got an error concerning the grid. I'm assuming the Bgrid in POP might be the reason for that. Has tried to do that before in POP and can direct me to an example?
Thanks a lot!

Since there was little follow-up on this Issue/discussion; I am closing the Issue (and PR #1315) for now until I find a group that can actively help me test and develop such a feature in POP


Does the vue template support some special variants?

On the official website, you can see that you can use variants with prefix symbols like Only Screen and Desktop First, these variants Can be used well in class. But these special variants seem to be unable to be used with Attributify Mode (the vue template cannot be parsed).
I generally use Attributify Mode to separate classes of different variants, so that it will be clear at a glance during future maintenance as stated on the official website, so I would like to know this issue, I am in windicss This issue has been raised in the repository.

Thanks for bringing this up. Please keep track on the issues under windicss repo.


Task ID for msgs in rmf_task_mgs

Mainly for enhancement. It will be great if there's a task_guid (or any similar name) in both delivery.msg and station.msg. This will be helpful for the task_initiator (mainly UI) to track each task.
Also, might also want to create a new feedback msg to any task_initiator, something like a  task_queue.msg which publishes periodically.

Also according to #50 . A list of task states with type Task.msg will be published to /task_states topic periodically.


xds: do not use protocol name in listener name

It's incorrect to put protocol name into the listener name. If the protocol name is changed, then you end up with two listeners bound to the same socket.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9c9db578410b8cc772bcbff09eeb4c225d3de914
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9c9db578410b8cc772bcbff09eeb4c225d3de914
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
9c9db578410b8cc772bcbff09eeb4c225d3de914
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

please fix lint

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [kyessenov,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

superceded by #5785


Update command_line.rst

Update PyThaiNLP Command Line Docs #266

Coverage remained the same at 90.051% when pulling 206a115090b53b746c90ffd6e6526af131753dfa on Command-Line-Docs into 23ba97e1226ea6619570bf0c1ee99e26ce132b7e on dev.


Move to using embedded Vue app for QR Code page

This pr resolves #432
In addition to the migration to Vue this PR adds a timer to catch when a credential has been stuck in the pending state for over a minute prompting the user.

As well as providing this feedback users are also informed on possible reasons for a failed credential.

I am not 100% sure these error messages make sense in all cases so feedback on them is appreciated.

Not seeing the redirecting working when trying locally any more.
It's sitting on
and I don't see callback_url referenced in the code any more

Just tested this. Should work now


Most of the localization work for Simplified Chinese have been completed

I have completed most of the localization work for Simplified Chinese which involves 52 properties files (42 files modifed, 10 files added), including mysql and oracle extension module.
But there are still some strings are hard-coded in the code and they are not completed. I think it might be better for the module developer to build the i18n properties file first.

Hello @bianyun1981,
Thanks for the contribution.
I have added localization entries for previously hard-coded string literals. Please see 2ecaf3b

Hi @ShadelessFox ,
I added all the hard-coded locations that can be found in the new issue #14964. Could you or someone else add localization entries for those hard-coded string literals too? After you commit, I will merge and then complete Simplified Chinese localization for those new entries.
Thanks.

Hello, @ShadelessFox,
Considering that the hard-coded lines listed in issue #14964 will be revised in the 21.3.3 milestone, I think it might be better to cancel pull request #14948 first, and wait for the 21.3.3 version to be released before doing the localization of Simplified Chinese.

Hello,
I am looking forward to it!


Inferring within mapped tuple's type parameter raises error unexpectedly

Bug Report

🔎 Search Terms

mapped tuple

🕗 Version & Regression Information

This is the behavior in every version I tried from 3.5.1 to the latest nightly (4.7.0-dev.20220215)

⏯ Playground Link

Playground
💻 Code

type SomeFunction = (...args: any) => any
type SomeMappedTuple<T extends readonly unknown[] | []> = { [P in keyof T]: Promise<T[P]> }
// ok if we put `infer` outside of the type parameter of SomeMappedTuple
type A<T extends SomeFunction> = T extends (...args: infer P) => any ? (...args: SomeMappedTuple<P>) => void : any
// error: A rest parameter must be of an array type
type B<T extends SomeFunction> = (...args: SomeMappedTuple<T extends (...args: infer P) => any ? P : any>) => void

// but in both cases there's no error inferring the correct type
type a = A<(a: string, b: number) => void>
type b = A<(a: string, b: number) => void>

🙁 Actual behavior

An error is raised for type B: A rest parameter must be of an array type, where the type parameter passed into SomeMappedTuple should be unknown[] or any
🙂 Expected behavior

type B should not raise any error

See #29919


Support for faststart on Android

Is anyone maintaining this library?
Current Behavior
faststart is not an option or on by default for android
Expected Behavior
a new option for faststart
add Trimmer.java L448
cmd.add("-movflags");
cmd.add("faststart");

Hi @jasoncarlson-Actavivo Please feel free to open a PR.
I'll review & merge quickly

https://www.youtube.com/watch?v=VqCdCLn9HQI


issues using D435 with Dell Precision 5540 vendor kernel

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 18.04

Kernel Version (Linux Only)
(4.15.0-1081-oem (provided by Dell, for the Precision 5540 laptop))

Platform
PC

SDK Version
{ 2 }

Language
not applicable - using realsense utilities

Segment
robot

Issue Description
I'm not sure if this camera is supposed to work with a vendor kernel, but I have a whole bunch of issues using the Realsense with this kernel... I am loath to switch to a vanilla kernel because I'll lose vendor-provided hardware support for the rest of the machine if I do that, but I'll give it a shot if support with vendor kernels isn't supposed to exist.
realsense-viewer reports every connection to the camera as USB2.1, not USB3, regardless of cable type (I am sure I have used a cable which has USB-C 3.0 support - there is a Thunderbolt 3, USB3.1-supporting Intel USB-C controller in the laptop).
I saw rs-color work a couple times, but it usually reports "Frame didn't arrive within 15000".
rs-depth doesn't work - sometimes says, "The connected device doesn't support depth streaming!", sometimes just also gets no frame within 15 seconds.
After running rs-color or rs-depth and not getting a frame, the camera usually stops being recognized and I have to plug it in again.
Sometimes I get permission denied on its video devices (/dev/video1, /dev/video2, /dev/video3 - there's a /dev/video0 that I think is the builtin webcam) but sometimes I don't. I'm using the udev rule which comes with the debian package, which has no diff with the one checked into the repo right now. I'm in the plugdev group and the video devices are owned by root/plugdev group.
Secure boot is disabled.
Last time I did an apt upgrade I saw that dpkg built the dkms module against my Dell OEM kernel so it's certainly trying.

Hi @sinback   If you build Librealsense with the 'backend' installation method then you should hopefully be able to sidestep the kernel situation entirely.  This method - which requires an internet connection - does not depend on Linux versions, kernel versions of patches.
If you would like to use this installation method, please go to the Build folder (Librealsense > Build) and run the CMake build instruction below:
cmake ../ -DFORCE_RSUSB_BACKEND=true -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true

@MartyG-RealSense Thanks for letting me know about the libusb backend! It sounds like a smart move for this project in terms of supporting more hardware in the future. :)
I built and installed it with the exact flags you suggested and had no issues building it, but when I run rs-enumerate-devices I now get:
20/05 13:30:01,293 ERROR [140360282916608] (handle-libusb.h:51) failed to open usb interface: 0, error: RS2_USB_STATUS_ACCESS
Could not create device - failed to set power state . Check SDK logs for details

I am not sure where to find the SDK logs but I'm happy to send those along too if you know where to find them

I reinstalled librealsense2-dkms to see if that helped with the uvcvideo problems and it did get rid of the messages in dmesg about unknown video format, but it didn't get rid of the message about unable to create debugfs directory, and it didn't change the behavior of rs-enumerate-devices either. With librealsense2-dkms installed dmesg looks like
[ 2399.590108] usb 1-1: new high-speed USB device number 56 using xhci_hcd
[ 2399.746847] usb 1-1: New USB device found, idVendor=8086, idProduct=0b07
[ 2399.746848] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[ 2399.746850] usb 1-1: Product: Intel(R) RealSense(TM) Depth Camera 435
[ 2399.746851] usb 1-1: Manufacturer: Intel(R) RealSense(TM) Depth Camera 435
[ 2399.751085] uvcvideo: Found UVC 1.50 device Intel(R) RealSense(TM) Depth Camera 435  (8086:0b07)
[ 2399.755962] uvcvideo: Unable to create debugfs 1-56 directory.
[ 2399.756003] uvcvideo 1-1:1.0: Entity type for entity Intel(R) RealSense(TM) Depth Ca was not initialized!
[ 2399.756004] uvcvideo 1-1:1.0: Entity type for entity Processing 2 was not initialized!
[ 2399.756005] uvcvideo 1-1:1.0: Entity type for entity Camera 1 was not initialized!
[ 2399.756054] input: Intel(R) RealSense(TM) Depth Ca as /devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1:1.0/input/input66
[ 2399.756513] uvcvideo: Found UVC 1.50 device Intel(R) RealSense(TM) Depth Camera 435  (8086:0b07)
[ 2399.759067] uvcvideo: Unable to create debugfs 1-56 directory.
[ 2399.759148] uvcvideo 1-1:1.3: Entity type for entity Processing 7 was not initialized!
[ 2399.759149] uvcvideo 1-1:1.3: Entity type for entity Extension 8 was not initialized!
[ 2399.759150] uvcvideo 1-1:1.3: Entity type for entity Camera 6 was not initialized!

Does reapplying the udev rules help please?
https://github.com/IntelRealSense/librealsense/issues/3263

No, it didn't help, sadly.
I borrowed my roommate's desktop and this particular camera's rgb stream acts much happier with that but the depth stream still seems to be totally broken. We tried both Ubuntu 18.04's debian release and using Windows 10. Especially because of the corruption on the output of rs-depth I saw before (and still now), now I am thinking it may have a hardware issue with the camera and we are both wasting our time :( but as far as I know, it's never really been used before except when I tried to get it to work this week, so I wonder how I could have broken it.
I think I can pick up a different unit from a coworker, how about we close this issue and I reopen it if I still have issues with that one?

It is very, very rare for a camera to have a hardware fault from the factory that renders it unusable no matter what is tried, but it can happen.
If you have access to the RealSense Viewer program then you could try going to the More option at the top of the options side-panel and then selecting 'On Chip Calibration' and going through the on-screen process to see if it improves the broken depth image.

I tried doing that just now, on the desktop, which does act a little better than my laptop, I think. I got a couple depth frames out of it but then it froze and the calibration progress bar in the top right stopped progressing. I waited for a few minutes without it progressing before giving up. I also tried the Very Fast calibration option but it didn't make any progress either.
I will let you know how the other camera performs.

Hey, an update - today I switched from NVIDIA graphics card graphics on my laptop to Intel integrated graphics, and switched from the libusb backend back to the apt repository backend, and saw a massive improvement in the D435. Both streams work fine now  It still thinks it's a USB 2 device and works super poorly with my USB-C controller, but it works alright with the normal USB 3 controller. It works alright with my python librealsense application too :) I tried a D415 as well and it wasn't working great either when I used the other GPU but did fine when I switched.
Based on this, I am fairly confident this was some kind of a power issue all along. I am not sure why it was also misbehaving with my desktop, which has never had USB power issues even with a bunch of peripherals, but I'm ok with closing this issue.

I'm glad you found a workable solution!  Thanks for the permission to close, and good luck with your work   :)


is still alive the project?

Hi, is still alive the project?

@Allan-Nava It works with Django 1.1 thru 1.4 and python 2.4 thru 2.7.[1] last update 2014[2]
[1] https://pythonhosted.org/johnny-cache/
[2] https://github.com/jmoiron/johnny-cache/commits/master

I use python 3.6 ?

@jmoiron do you need help maintaining this project, I see a lot of unreviewed PR's

Even I am willing to help, can I contribute somehow ?
cc: @jmoiron , @tawanda , @avelino


The first expandable hint text requires two clicks

I use this library in my app, and I am facing this issue which is also present on the demo app of this library. the first view of the bunch seems to be in a weird state when the activity first loads. therefore it requires two clicks to start registering input in this view. Is this an issue or is it simply the way these views function ?

@pierrekhouryy Hmm.. I can't replicate this. It starts taking input after 1 press for me. What device / OS version are you using?

Closing as can't replicate and receiving no further information.


Update PolioPagerViewController.swift

Is it possible to switch these lines? In my project PolioPager loads the SearchViewController before its properties (searchBar, searchTextField, cancelButton) are initialized.
This is because PageViewController.nowIndex will be set while PageViewController.initialized is true. In this case the SearchViewController will be initialized although the properties are not set yet.
nowIndex will be set when calling PageViewController.setPages(). And this call happens in PolioPageViewController.setPages() before PolioPageViewController.needSearchTab is checked and the SearchViewController properties were set.
I have no idea why this is. But switching these lines helps in my case.

Okay, I've checked it now. lgtm👍

Thank you very much. Works great. I'm glad i can use PolioPager in my app. I really like it.