Question: Why description and description URL arguments are mandatory?

The tool requires two mandatory arguments:
-d, --description <description> (REQUIRED)             Description of the signing certificate.
-u, --description-url <description-url> (REQUIRED)     Description URL of the signing certificate.

However, signing tools like azuresigntool, nuget sign, signtool do not require these arguments as mandatory. What's the reasoning of making those arguments required?

These arguments are used for Authenticode and ClickOnce signing.  If you aren't doing Authenticode or ClickOnce signing, it does seem weird for Sign CLI to require arguments anyway.  The current problem is that Sign CLI doesn't know at the time of argument parsing if it will be doing Authenticode or ClickOnce signing.  A signing operation could fail if these values were required but not supplied.
We should look into how to make this better.  Ideas include:

renaming the options (e.g.:  --authenticode-description) and making them optional
introducing a --dry-run option to see if a signing operation would require these options without actually signing
defaulting these options to zero-length strings

The --description and --description-url options are only required by AzureSignToolSignatureProvider. ClickOnceSignatureProvider uses  --description-url but this is optional.
I did some local testing and made them both null inside the AzureSignToolSignatureProvider:
using (var ctx = new Kernel32.ActivationContext(manifestFile))
{
    code = signer.SignFile(
        file.FullName,
        description: null,
        descriptionUrl: null,
        pageHashing: null,
        _logger);
    success = code == S_OK;
}

This seems to sign a file without any issues. I also double checked with GitHub Copilot and got this answer:

No, both pwszName and pwszDescription in the SIGNER_ATTR_AUTHCODE structure are not required fields.
The pwszName field is used to specify the name of the signed content, and pwszDescription is used to provide a description of the signed content. If either of these fields is set to NULL, the signing process will continue without these pieces of information.

I think we could remove setting IsRequired to true for both these fields? I can open up a PR for this if the team agrees with making them optional?

These parameters have been made optional and will be reflected in the next release.


missing_fat_arrows: enable checking class methods

Rule description mentions that class methods and class instance methods have this auto-bound. This doesn't seem to be true.
class Animal
  constructor: (@roar) -> null
  getRoar: -> @roar
  @planet: 'earth'
  @getPlanet: -> @planet

cat = new Animal('rawr')
cat.getRoar() # 'rawr'
catRoar = cat.getRoar
catRoar() # 'undefined'
Animal.getPlanet() # 'earth'
animalGetPlanet = Animal.getPlanet
animalGetPlanet() # 'undefined'

# vs

class Animal
  constructor: (@roar) -> null
  getRoar: => @roar
  @planet: 'earth'
  @getPlanet: => @planet

cat = new Animal('rawr')
cat.getRoar() # 'rawr'
catRoar = cat.getRoar
catRoar() # 'rawr'
Animal.getPlanet() # 'earth'
animalGetPlanet = Animal.getPlanet
animalGetPlanet() # 'undefined'

Any update on this?

Sorry for the delay. I haven't had much time for CoffeeLint recently.
I think whoever wrote the description didn't really mean to indicate that they were bound in the someFunction.bind() sense, but just that the context would be the class or instance when called through dot notation.
I just feel like I'm not understanding something here. Can you maybe restate exactly what the plugin is doing wrong?
@swang Maybe you can take a look?

Our code uses a more functional-style and thus dot-notation is not alawys sufficient.
e.g.
User.getFriends()
.then User.filterFriends
.then User.emailFriends

In those cases, the methods must be auto-bound to run correctly

class Animal
  constructor: (@roar) -> null
  getRoar: -> @roar  # <- warn
  @planet: 'earth'
  @getPlanet: -> @planet @ <- warn

If that's what this change does, I think it should be an option. I don't think it's a good idea to encourage everyone to just bind every function. I think there's some overhead involved in binding, but I haven't done any research on it in a while.

Aren't these
class A
  @x: => @y

class A
  @x: -> @y

Functionally equivalent?
I believe the comment about "bound" is in reference to what it says on the CoffeeScript site, which states:
Because in the context of a class definition,  this is the class object itself (the constructor function), you can assign static properties by using  @property: value, and call functions defined in parent classes: @attr 'title', type: 'text'
The comment never mentions autobounding, although I'm still not very clear what you're trying to accomplish. Do you mean chaining?

The two are functionally equivilent if you are creating a new instance (a = new A) and then calling them as a method on that instance (a.x()). The difference is when you're trying to use them as callbacks.
callback = a.x
callback()

The fat arrow callback will be bound, so this will be a, but the second one is not bound so this will default to window (or global). The change in this PR is definitely too far. It's going to recommend that everyone bind every method, which I think introduces overhead, just to get around one edge case around callbacks.

If you use a fat arrow in a parent class and a child overrides that function it ends up binding the child's function too. I think this is not a obvious behavior as you can't predict it without reading the parent's code.
testCallback = (callback, obj) ->
  console.log(callback() is obj)

class Bound
  getThis: => this

class Normal
  getThis: -> this

# Without going and reading the parent code you have no
# way of knowing that this function will be bound.
class Child extends Bound
  getThis: -> this

n = new Normal
testCallback(n.getThis, window)

b = new Bound
testCallback(b.getThis, b)

# spooky behavior
c = new Child
testCallback(c.getThis, c)

run
I'm going to go ahead and close this PR. After giving it more thought I don't think it's good to encourage binding every method on every class. If you still want that behavior you're welcome to publish it as a 3rd party rule.


Can't create in-meeting tab with developer preview via Visual Studio Teams Toolkit

Hello,
I'm looking to create an in-meeting Teams app consisting of tabs/bot features. It looks like this functionality is available in Developer Preview, as mentioned here.
I followed instructions to set up an O365 tenant with privileges to enable uploading custom apps and enabling Developer Preview. I use the same tenant in Visual Studio 2019 Enterprise and when I load the Teams toolkit and add a tab, the "Meeting" scope option is unavailable (screenshot below). Is this an issue given I set up developer preview, or is there something else I need to enable?

Thanks

@scrosoff, Sorry for the delayed reply. My team is checking this issue and we will get back to you

@scrosoff, Can you confirm your preview is selected? we checked this and found following for VS Code & Visual studio


Infra config tests implementation

I need some help with testIncrementInfra in class InfraTest. This tests first creates an addressspace using a custom StandardInfraConfig and then it tries to replace the infra config applied to the addressspace with a different StandardInfraConfig... this test is failing and I'm not sure if it isn't correct or fails because of a bug.
Basically the new infra config is not being applied correctly.
I noticed that I needed to set updatePersistentVolumeClaim=true in BrokerInfraSpec to make the infra update to change the persistent volume claim of the broker but then It seems to only apply the pvc change and not the rest of resource requirements.
Summarizing:

with updatePersistentVolumeClaim=true only apply storage

with updatePersistentVolumeClaim=null doesn't apply storage

To run this test
make SYSTEMTEST_ARGS="io.enmasse.systemtest.standard.infra.InfraTest#testIncrementInfra"

@enmasse-ci run tests

@famartinrh A couple of things worth noting with infra config changes:

Changes are not applied 'immediately', the system will converge to the new infra config. If you change router memory settings for instance, the address space will update the qdrouterd statefulset and update the 'active' infra config. So the test needs to do a wait-until-with-timeout loop with these checks, and fail if the changes are not applied within ~5 minutes.
Version needs to be the same as the release.version maven property. This should be injected to the systemtest environment
The setting updatePersistentVolumeClaim will only work for storage PVs that support resizing. The host volume PV that we use in CI does not support this. Glusterfs should support this on 3.11 and newer.

@lulf ok, I'm going to implement a wait-until-with-timeout loop on the assertions.
About the version I discovered that by myself, it remains to externalyze the value and inject it somehow.
And if it's possible to know in runtime if a PV supports resizing, testing the setting updatePersistentVolumeClaim can be optional

@famartinrh According to https://kubernetes.io/blog/2018/07/12/resizing-persistent-volumes-using-kubernetes/ , resizing is supported for: AWS-EBS, GCE-PD, Azure Disk, Azure File, Glusterfs, Cinder, Portworx, and Ceph RBD .
It should be possible to check if a storage class supports resize from the allowVolumeExpansion field.

@enmasse-ci run tests testcase=io.enmasse.systemtest.standard.infra.InfraTest

@enmasse-ci run tests testcase=io.enmasse.systemtest.standard.infra.InfraTest

@enmasse-ci run tests testcase=InfraTest

@enmasse-ci  run tests testcase=**.InfraTest


Connection closed on every docker build

I'm using Coreos-vagrant to develop my Dockerfiles in my notebook (osx 10.9.2) where I shared my working folder with coreos so I can edit the Dockerfile with my text editor and build the image on coreos from an ssh console.
Once docker outputs that the build was successfull, connection between host and coreos is lost leaving the image untagged and having me needing to ssh into coreos a gain. ALso
In my Vagrantfile I manually upgraded it to coreos-beta. Vagrantfile and output can be found on this gist.
UPDATE: I also noticed that the shared folder becomes empty unless I halt/up the virtual machine again.
Any ideas on what could it be? Am I doing something wrong here?
Thanks

Moved to https://github.com/coreos/bugs/issues/1380


Use mesh domain instead of cert domain

Is this ready to be merged or are there still discussions ongoing?

fine with me


docs(api, simulator-api): document APIs

closes #3239
closes #3137

:tada: This PR is included in version 5.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Execute trials for an experiment and Upload

US 01.05.01
As an experimenter, I want to be able to execute trials for an experiment and upload them to the experiment.
notes: might be a big issue, need to be divided into sub tasks later.
Rationale:
to contribute to the crowd test of an experiment
to provide peer review for other experimenters
Story points: 15
Risk level: high

This means they can take measures, count things, and add them to an existing experiment. They can also do it offline, so it can be uploaded later when they are connected.
They can add trials, but they must be able to do it offline.

An experiment consists of trials of 1 type.

Can an experimenter add more than 1 set of trials? For example, if an owner specifies a minimum of 3 trials for the experiment. Can the same experimenter upload multiple sets, each with 3 trials?

There's no sets. They can upload whatever they do.


cmd.Optional doesn't function as expected with enums

Could you show the command you've made?

I am guessing you should get an error creating the command with this commit: https://github.com/df-mc/dragonfly/commit/c7aca8334da8e23c4286653572fa63d54f4091db. You should make your cmd.Enum implementations of the type string.


Adds organization settings links to user nav

Fixes #93
This PR requires https://github.com/aptible/auth.aptible.com/pull/119 to work properly.
For you @mixonic.

@mixonic aptible/auth.aptible.com#119 will cause issues by exposing organizations to unauthorized users, so I instead use a computed property on models/user.js that returns all unique organization through roles.  Let me know if there is a better way to do this.

Some failing tests and I left some comments. I an generall :+1: with the rest though!

cc @mixonic
I updated the stacks route to include all of a user's organizations and use those to loop through and generate the stacks page.

@sandersonet I think there are some opportunities to reduce the number of organizations queries by fetching them from a top-level route. It feels like we are implying an organizations route at the top level that always fetches.
But let us keep moving forward. Excellent work here!


Consider removing auto-highlight-symbol

My suspicion is that this isn't really that helpful, since I can invoke something similar with # and *.

Currently trialing them disabled.

Conclusion seems to be that I don't use it. Will wait for a week or so, then remove it.


.github: Fix image digest job printing

Commit 044afab2ecf3 ("ci: Set up qemu in images workflow and build
cilium-test") introduced a new dependency for the "Display image digests"
job which provides a nice single page that developers can use to find
all of the CI image artifacts generated from the PR. Unfortunately the
new dependency is conditionally skipped, and when it is skipped, the
display digests job is also skipped because the dependency is skipped.
This is a known behaviour of GitHub actions/runner, issue 491.
This commit works around the issue by explicitly running the job if the
dependency was skipped, allowing the "display image digests" job to run
even when the qemu job is skipped.
This PR proposes the workaround listed on https://github.com/actions/runner/issues/491 .

Great, looks like the fix works: https://github.com/cilium/cilium/pull/16660/checks?check_run_id=2934571036


gha: disable fail-fast on integration tests

So that the failure of one matrix entry (e.g., caused by a flake) doesn't cancel the other ongoing tests, if any.

/test


chore: added "type": "module" to package.json

What I did

added "type": "module" to the esm modules in the packages folder

I was not sure, if I should add it to the root module too

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is most likely needed here (if you happen to be trying to use open-wc/testing with Jest) https://github.com/chaijs/chai/pull/1411

Sorry to be that guy, but bump. I'm having issues issuing the testing library in AVA in an ESM project. What needs to happen for this to be merged?


Activity:  Safety controller doesn't back up when on the dock

This one is pretty straightforward to implement.  The interesting part would be adding ROS tests for it
Desired Outcome

Modify the safety controller so no back-up happens when Kuri is docked
Add to the existing safety controller ROS test to check the new behavior

Upstream Requirements:

Need to simulate docked/undocked in the gazebo simulation

Done in PR https://github.com/MayfieldRoboticsPublic/kuri_edu/pull/20


Create forms of issues.

Forms for the bug, compatibility report and feature request. Action for 'need reproduction' label.

@xvaara yaml > yml gang


Improve navigation type safety by binding navigators to specific NavHosts

Proposal
Have typed navigators that only accept Directions that they know they can navigate to. This is relevant only when using multiple NavHosts.
Let me know below what you think of this! 🙂
Context and Reasonings
One of the questions I get asked often is how to have multiple NavHosts (DestinationNavHost) and how the inner screens can navigate to the outer ones. This can be a bit confusing at the moment and it can lead to runtime crashes if you use the DestinationsNavigator from the inner one to navigate to a Screen from the outer NavHost and vice-versa.
This was actually a point brought up in an article I read some time back, where the author compared Compose Destinations to other solutions and found this support lacking with it.
To be fair, Compose Destinations promotes the same as official Compose Navigation: you should "most likely" only use a single NavHost. For a lot of applications I maintain that this is the better approach, but it also somewhat bothers me that I don't support multiple NavHosts in a type-safe way (given that Compose Destinations main premise IS type safetyness).
Pros

Avoid compilations and builds that result in runtime exceptions if developers don't know how the NavHosts and navigators work
Help provide the outer navigator to inner screens in a type-safe way. This allows to easily have screens navigating in both outer and inner NavHosts.

Cons

Complication of the internal types - each navigation would have two generic type arguments : one for the navigation arguments type and the other for the "NavHost Nav Graph" (this is the top level nav graph that you pass to your DestinationsNavHost) that it belongs to. Also, Direction will make use of generics for the NavHost Nav Graph type the direction belongs to.
When generateNavGraphs configuration is set to false, there will be (at least this is the current solution I got) a type that it's always Nothing since there is no info about nav graphs in this case.

Show me the code!

@SettingsNavGraph(start = true)
@Destination
@Composable
fun SomeScreenFromInnerNavHost(
    navigator: NavHostNavigator<SettingsGraph>,
    parentNavigator: NavHostNavigator<RootGraph>
) {
    // Considering GreetingScreen as part of the RootGraph (and so an outer DestinationsNavHost where "RootGraph" is passed in)
    navigator.navigate(GreetingScreenDestination)
    // ☝   this does not compile since "GreetingScreenDestination" is a
    //`Direction<RootGraph>` but navigator can only navigate to a `Direction<SettingsGraph>`

    parentNavigator.navigate(GreetingScreenDestination)
    // ☝ This works 🙂
}

Closing this since it won't be done for v2. We'll revisit this if this is highlighted again.


Icon - aria-hidden="true" applied when as="a" is specified

Steps
<Icon
  name="point"
  as="a"
/>

OR
<Icon
  name="point"
  as="a"
  aria-hidden={false}
/>

<Icon
  name="point"
  as="a"
  aria-hidden="false"
/>

Expected Result

Actual Result

Version
0.78.3
Testcase
https://codesandbox.io/s/qq2vr3x2qj

This is an interesting problem, because there's no text content related to icons, they should be hidden, even if they are an anchor. What would probably be better is not to show aria-hidden if an aria-label is applied to the icon.

I have recently learned that assistive technologies rely on aria attributes to explain to impaired users what the element does. As an anchor with no content used for an icon, an aria-label can be used to describe the link. Even with an aria-label, the aria-hidden is still true.
The attribute link can be applied but the icon still renders as an  which provides no context to assistive technologies

On mobile, sorry. *Renders as an

Looks like there is consensus on:

What would probably be better is not to show aria-hidden if an aria-label is applied to the icon.

PRs welcome!

I was actually coming to file an issue requesting a way to provide aria-label for icons so that they are not invisible to the blind, since they have real meaning. However, if aria-hidden is applied statically, it will not work.
I understand that i18n will need to be considered: We use react-intl, so we would want to do something like:
<Icon
    label={formatMessage({ id: 'icon.email' })}
    name="at"
/>

Yields

Hey, would love to offer my help here. Just to make sure i understand the expected behaviour, the 'aria-hidden="true"' attribute should be applied unless aria-label attribute was passed.

@benbakhar correct, I'm hesitant to recommend the label="" route because other components explicitly use aria-label and we should be consistent. It's also good documentation to place aria-label on a component so people reading it know what it's doing.


Load more

How to use load more  in this package

Can you give a little bit more context on what you are trying to achieve?


Recognize_path should account for HTTP method

In a RESTful API, you'll use the same path multiple times, but with a different REST verb.
These will return the same endpoint:

GET /orders
POST /orders

So will these:

GET /orders/123
PUT /orders/123
DELETE /orders/123

Ideally, we'd be able to pass that in as an option:
API.recognize_path('/orders/123', method: 'PUT')

Indeed. I am actually kinda surprised it doesn't. Start by writing a spec that (fails to) differentiate(s) multiple methods on the same API. What do we return today? The first matching route? In which case I think we should consider making this recognize_path(path, verb = 'GET') vs. adding an options hash. What other options would make sense?

Hey 👋
I was taking a look to this issue. As @ideaoforder described, when using the recognize_path method, we are not able to specify the method. So in case you have more than one method for the same path, you will get always the one defined in the last position.
Check with this spec that when obtaining the routes for the /books path, we only get one of them.
https://github.com/jcagarcia/grape/commit/919f5f35a993aa28ca3de338ba1b40cf85e494b1
We need to define which behaviour we want for the recognize_path method (in case we want to change it):
Option a

Add an optional parameter verb/method, to the recognize_path method.
If not received, it will continue behaving as it is, just returning the last endpoint defined.
If received, return the endpoint that matches the path and the provided verb.

Internally, when verb/method parameter is provided, it will continue delegating into the greedy_match?(input) method for finding a match with the provided input.  On the other hand, if verb/method parameter is provided, it will delegate into the match?(input, method) method, that takes into account the method and will select the correct one depending on the provided method.
In this option, the routes will always return ONLY 0 or 1 routes inside the routes array.
Option b

Add an optional parameter verb/method, to the recognize_path method.
If not received, return all the possible routes and return them inside the routes array.
If received, return the endpoint that matches the path and the provided verb.

In this option, the routes will always return 0, 1 or N routes inside the routes array.
This is the option that is added to https://github.com/jcagarcia/grape/commit/919f5f35a993aa28ca3de338ba1b40cf85e494b1 as a failed spec.
For this Option b is pending to check how to include all the routes inside the array could affect the detection of the routes in Grape.

What do you think @dblock ?

Option b) is a breaking change whereas option a) is not but doesn't behave the way we want.
I think a cleaner option would be c) add a new method called, for example, routes(path, verb = nil) that behaves like b), and deprecate recognize_path. WDYT?


Added Count_Sort

Added Counting Sort implementation with c++
Fix issue: #232

New Script

Please star this repository to show your support, in the meantime I am reviewing your code.

@amritansh22 I hope the sorting is working well, if so will you merge the PR, please !!

Excellent work @chawlaj100 Thanks a lot for making this PR. The volume of incoming PR is drastically increased so it is taking a bit of time.


Is there a way to include markdown from a remote url?

I would like to include an md file from a blob in a remote GitHub repo. Like https://GitHub.com/ccc/ddd/blob/main/mailbox.md

Duplicate of #138

how do I compile and include my version of this plugin (for testing) into mkdocs?  I would like to try and build this functionality into a PR


Disable Gatekeeper syncing in hosted mode

Depends on:

https://github.com/open-cluster-management-io/governance-policy-framework-addon/pull/49

Are these failures caused by something we're already looking at? (We have a lot of things in the air right now)

I hadn't noticed it had failed (and I'm kind of surprised it did). Since these aren't framework E2E tests, it sounds like there might be something more here I need to investigate...

It's doing some whitespace chomping, and I'll bet it no longer needs to do that with a raw string...

Well. It wasn't that. Looks like I have some actually investigating to do!

Blocked by:

#71


How to change box color?

The boxes displayed are always blue. How can I change their color?

@Oddy123123 You can retrieve the bbox from the detection output and render them with your desired color on the original input image using OpenCV


Link in chat_sdk_firebase_social_login causes import to fail

The link to chat_sdk_firebase_social_login in chat_sdk_firebase_social_login causes Android Studio to never be able to import the project when starting a new project and following the directions.  Deleting the link allows Android Studio to import the project.  Nobody else has whatever the link is pointing to on the developer's system.

This will be fixed in the next commit.


fix: fixed quote errors and invalid amount inputs

Description
Fixed the issue where the box errors out when the input has quotes, also fixed the amount validation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Lgtm


pi/common: create a omni configuration for pi boards

It should be possible to create a configuration package to target all Raspberry Pi boards with a single build.
The separation between each version creates a build tailored for the CPU, firmware, and hardware (device tree) for each board. However, a Pi 4 can boot a Pi 3 image, and so on.
It's then likely best to keep the individual pi/0, pi/4 packages, and add an additional "pi/omni" package to target all of them, or simply use "pi/common" for this purpose.

Done


refine match pattern related code

Which issue does this PR close?

No
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

During I wrote #1649, I found we can refine the match-pattern related code to make it clearer.


[test](jdbc catalog) reopen db2 catalog test case

Change the download address of db2 image, reopen the test and fix the Result close problem in the test

run buildall

run buildall


JindoRuntime support HA with Raft backend

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #805 (bd367aa) into master (1fc1669) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

:exclamation: Current head bd367aa differs from pull request most recent head 712cb1e. Consider uploading reports for the commit 712cb1e to get more accurate results

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   13.16%   13.12%   -0.04%
==========================================
  Files         106      106
  Lines        4779     4792      +13
==========================================
  Hits          629      629
- Misses       4088     4101      +13
  Partials       62       62

Impacted Files
Coverage Δ

pkg/ddc/jindo/transform.go
12.76% <0.00%> (-0.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc1669...712cb1e. Read the comment docs.


[api-docs] Update changelog for join raid and mention raid changes (#6133)

A new commit was made into the api-docs repo: https://github.com/discord/discord-api-docs/commit/e3e9b6876937b2783e61c4211bcf887e45e960d4
No details given.
This is a bot created issue.

No code changes required.


Rescaling Layer Issue when Loading .keras Model

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
v2.16.1-0-g5bc9d26649c 2.16.1
Custom code
Yes
OS platform and distribution
macOS Sonoma 14.5
Mobile device
No response
Python version
3.10.5
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I'm currently training an MLP, and after training I add on a rescaling layer (tf.keras.layers.Rescaling). The rescaling is needed to return to the normal label values (I scale them during training). Previously, on older versions of tensorflow (2.9 or so), I could add the rescaling layer and then load the .keras model without any issue. Now that I upgraded to 2.16.1 and keras 3.0+, I can no longer get the model to predict after loading the .keras model. It is important to note that everything works great when I load in the weights via model.load_weights('model-weights.weights.h5'). My error occurs only when performing load_model and then doing inference (I can load the model fine but errors pop up during inference).
Standalone code to reproduce the issue
import numpy as np
import tensorflow as tf

# fake data
X = np.random.rand(100, 10)
Y = np.random.rand(100, 5)
r = np.random.rand(5)

# build/compile/fit model
model = tf.keras.Sequential(
    [
        tf.keras.layers.Dense(100, activation="relu", name="layer1"),
        tf.keras.layers.Dense(10, activation="relu", name="layer2"),
        tf.keras.layers.Dense(5, name="layer3"),
    ]
)
model.compile(optimizer="adam", loss="mse")
model.fit(X, Y, epochs=50)

# add rescaling layer
model.add(tf.keras.layers.Rescaling(r))

# test point
x_tst = np.random.rand(1, 10)

# this works!
print(model(x_tst))

# save model
model.save('model.keras')

# load model now
model = tf.keras.models.load_model('model.keras')
model.summary()

# error here!
print(model(x_tst))

Relevant log output
ValueError: Exception encountered when calling Rescaling.call().

Attempt to convert a value ({'class_name': '__numpy__', 'config': {'value': [0.5410176182754953, 0.03500206949958751, 0.6878430055707475, 0.8070027690483106, 0.2295546297709813], 'dtype': 'float64'}}) with an unsupported type (<class 'keras.src.utils.tracking.TrackedDict'>) to a Tensor.

Arguments received by Rescaling.call():
  • inputs=tf.Tensor(shape=(1, 5), dtype=float32)

@marcobornstein Could you try to use CustomRescaling layer that is defined to take a scaling vector as an input and scale the inputs accordingly. It overrides the get_config and from_config methods to ensure proper serialization and deserialization. For any further queries please raise the issue in Keras repository. Thank you!

Sorry @sushreebarsa, I am a bit confused. I have not defined a CustomRescaling layer in the code above. Previously, this Rescaling layer would work. I have also tried to implement a custom Rescalying layer (which you may be mentioning), however I still get issues with the get_config and from_config even if I write those functions myself. What other options exist?

@sushreebarsa yes, the previous TensorFlow version does allow correct model saving of the Rescaling layers. My issue is that this no longer works in TensorFlow 2.16. Is it possible to have this bug fixed? I am hoping to continue usage of TensorFlow 2.16 for my work.

@marcobornstein By saving your model again using the exact same TensorFlow version you used for training, please ensure the model is saved in the format that version expects. When you then load the model with the same version, there's a much higher chance of successful loading because the format and information about the re-scaling layer will be consistent.
Thank you!

@sushreebarsa, I am training and reloading the model using the exact same TensorFlow method. This can be shown in the "Standalone code to reproduce the issue" section of my Issue. How can this issue be fixed?

@marcobornstein Thank you for the update!
In TensorFlow/Keras, after you save and load a model, you need to recompile it before using it again.
Please follow the below code and let us know if it helps?
import numpy as np
import tensorflow as tf

# Fake data
X = np.random.rand(100, 10)
Y = np.random.rand(100, 5)
r = np.random.rand(5)

# Build/compile/fit model
model = tf.keras.Sequential([
    tf.keras.layers.Dense(100, activation="relu", name="layer1"),
    tf.keras.layers.Dense(10, activation="relu", name="layer2"),
    tf.keras.layers.Dense(5, name="layer3"),
])
model.compile(optimizer="adam", loss="mse")
model.fit(X, Y, epochs=50)

# Save model
model.save('model.keras')

# Load model
model = tf.keras.models.load_model('model.keras')

# Add rescaling layer after loading
model.add(tf.keras.layers.Rescaling(r))

# Test point
x_tst = np.random.rand(1, 10)

# Print prediction (should work after recompiling)
print(model(x_tst))

# Summary of the model
model.summary()

After loading the model, adding the Rescaling layer, and before using the model for prediction, we should recompile it:
# Recompile the model after adding Rescaling layer
model.compile(optimizer="adam", loss="mse")

# Now the prediction should work without error
print(model(x_tst))

Please find the gist here for reference.
Thank you!

Hello, the provided code does not reload the model after it's saved. I reproduce the error even when I recompile the model after loading it in again. The code to produce this is shown below;
# fake data
X = np.random.rand(100, 10)
Y = np.random.rand(100, 5)
r = np.random.rand(5)

# build/compile/fit model
model = tf.keras.Sequential(
    [
        tf.keras.layers.Dense(100, activation="relu", name="layer1"),
        tf.keras.layers.Dense(10, activation="relu", name="layer2"),
        tf.keras.layers.Dense(5, name="layer3"),
    ]
)
model.compile(optimizer="adam", loss="mse")
model.fit(X, Y, epochs=50)

# add rescaling layer
model.add(tf.keras.layers.Rescaling(r))

# test point
x_tst = np.random.rand(1, 10)

# this works!
print(model(x_tst))

# save model
model.save('model.keras')

# load model now
model = tf.keras.models.load_model('model.keras')

# Recompile the model after adding Rescaling layer
model.compile(optimizer="adam", loss="mse")

# error here!
print(model(x_tst))

Recompiling the model after loading it in does not fix the issue. There needs to be a patch to fix the rescaling issue.

@tilakrayal I was able to replicate the issue reported here.
Thank you!

@marcobornstein,
Apologies for the delay. Looks like this issue is more related to keras. Could you please raise the issue in the keras-team/keras repo for the quick resolution. Thank you!

@marcobornstein, Apologies for the delay. Looks like this issue is more related to keras. Could you please raise the issue in the keras-team/keras repo for the quick resolution. Thank you!

Thank you for the reply, I opened an issue here!. Do I need to do anything else?

@marcobornstein,
Could you please feel free to move this issue to closed status, since it is already being tracked in the Keras repo? Thank you!


core_selector selected attribute changes not propagating

Originally opened as dart-lang/sdk#20154
This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Define a polymer element like so:

<link rel="import" href="packages/polymer/polymer.html">
<link rel="import" href="packages/core_elements/core_selector.html">
<polymer-element name="binding-issue">
  <template>

    selected0 {{selected0}}

     <core-selector id="selector" selected="{{selected0}}" selectedClass='active' on-core-select="{{updateSelected0}}"></core-selector>

Item 0

Item 1

Item 2

Item 3

Item 4

  </template>

</polymer-element>
import 'package:polymer/polymer.dart';
@CustomTag('binding-issue')
class BindingIssue extends PolymerElement {
  @published String selected0 = '0';

  BindingIssue.created() : super.created() {
  }

  ready(){
    $['selector'].target = $['list'];
  }

 selected0Changed(old){
    print('selected0Changed $old =$selected0');
  }
  updateSelected0(e,d,t){
    print('updateSelected0 $selected0');
  }
}

Click on elements in the list

What is the expected output? What do you see instead?

The value of selected0 displayed by the browser should change.
The browser should print selected0Changed <old value> => <new value> to the console.

The value of selected0 should change
What version of the product are you using?
polymer: 0.11+5
core_elements: 0.6.0
sdk: 1.5.3
What browser (if applicable)?
Chromium

 Comment by jakemac53

Added Fixed label.

This comment was originally written by<EMAIL_ADDRESS>
I confirmed this issue is fixed in 0.12.0-dev.

This comment was originally written by<EMAIL_ADDRESS>
I forgot to mention the actual output in the original submission.  The value displayed in the browser doesn't change and only the event handler prints to the console.

 Comment by sigmundch

Hi Erik, thanks for filing this issue!
I believe this might be fixed now in polymer 0.12.0-dev (might be a duplicate of issue dart-lang/polymer-dart#224?). Do you think that's the case?

Removed Priority-Unassigned label.
Added Priority-Medium, Pkg-Polymer, Area-Pkg, PolymerMilestone-Next, NeedsInfo labels.


Workbox 3.5.0 docs

R: @petele @philipwalton
Auto-generated docs for the Workbox v3.5.0 release.

Whoops!
There were 18 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/reference-docs/latest/module-workbox-build.html#L241 - Common typo found: 'node' Should it be 'Node'?
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.CacheFirst.html#L90 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.CacheOnly.html#L81 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.NetworkFirst.html#L92 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.StaleWhileRevalidate.html#L94 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/module-workbox-build.html#L241 - Common typo found: 'node' Should it be 'Node'?
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-build_src__types.js.html#L45 - Common typo found: 'node' Should it be 'Node'?
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-build_src_entry-points_generate-sw.js.html#L46 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-build_src_entry-points_generate-sw.js.html#L99 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-build_src_index.js.html#L87 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-strategies_CacheFirst.mjs.html#L69 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-strategies_CacheOnly.mjs.html#L64 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-strategies_NetworkFirst.mjs.html#L72 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox-strategies_StaleWhileRevalidate.mjs.html#L77 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox.strategies.CacheFirst.html#L90 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox.strategies.CacheOnly.html#L81 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox.strategies.NetworkFirst.html#L92 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.5.0/workbox.strategies.StaleWhileRevalidate.html#L94 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.

:tada: This has been pushed live to https://developers.google.com/web/


Download Button on website

Describe the bug
The download button on website opens a page with all the code. Instead it should download a file with all the code.
Expected behavior of what should have happened (if applicable)
Screenshots (if applicable)
Additional notes

Hi @reveurguy thank you for submitting this. I'm actually aware of that but as of now it's fine. I'll add it to enhancements though as it is something that's worth working on.

also i want to suggest to use a lighter color for dark mode, like grey or black with some opacity or a lighter black color, so that the black buttons are clearly visible.

You can submit a PR with what you mean and we'll see if it's better


Mosdepth Subworkflow

PR checklist

[ ] Subworkflow that implements the mosdepth module.
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/blobtoolkit branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Which branch was this created from? I see a bunch of commits from @alxndrdiaz and not sure why it is here?

The problem was not the starting branch but the base branch. Fixed now 😊

Can you update the PR with a description of changes and check off the appropriate boxes? Make sure you include details of tests done on the changes.


Audio quality needed to train the model? Using mp3 files?

Hi!
This is a great implementation, thanks a lot!
Could someone please share their experience, which audio quality is needed to train the model? Will it be able to produce speech of at least low/medium quality if trained with 128 kbps .mp3 audio files from an audio book recorded by a professional speaker? The records sound clean to a human ear, there is no background noise.
Will 256 kbps .mp3 be better? Or do I need to use uncompressed .wav only in order to get any feasible results?

128 kbps mp3 should be fine -- that's what the LJ speech dataset was derived from. Would uncompressed .wav be even better? Possibly. If you are recording new prompts, I'd go with .wav.

@keithito
Thanks for the answer!
Trained on my non-English dataset. The model produces speech, but there are a lot of artefacts (the largest ones are that the model repeats words or parts of the phrase at the end or pronounces the phrase in very low volume and after the end of the phrase produces some weired loud noise for several seconds). The same problem with repeating the last part of the sentence occured when I used Nancy dataset for training. Isn't the model penalized heavily for producing the sequence which is longer than the ground truth sequence? Maybe this is a known issue with a known solution?
Can the quality of generated speech decrease with more steps of training? I.e. can the model overfit to the data if the data is, say, 15+ hours? Maybe it is worth creating a validation set and monitoring the validation error, or we can just train and produce eavluation audio files to monitor the quality of generated speech?

Yes, please make sure to trim any silences from the ends of your samples. That can help with the alignment. Also, you can try using the location sensitive attention mechanism from here:
https://github.com/keithito/tacotron/blob/tacotron2-work-in-progress/models/attention.py
It's possible to overfit if you don't have enough training data or there's not enough diversity in the training data. A validation set would probably be good.

Thanks, will try to cut the silence and use the location sensitive attention mechanism. I've actually cut the silence, but maybe it should be cut more tight.

@keithito trimming any silences from the starts of own samples can also help alignment? or the silences from the starts have no effect on the alignment?

Yes. Trimming should definitely help.


Feature Request: Option to View Comments in New Tab When Comments Are Othewise Disabled

I untick "Enable comments" in YTC's settings, but there are occasions when I actually want to read the comments on a particular video. Would it be possible to have an option somewhere to load all the comments in a new tab/window even if the user has disabled them on the main player page?
Cheers :)

middle mouse click the All Comments link (right click open in new tab)

@PamboHambo When you disable "Enable comments" a new button should appear in the comments place, clicking on it will load the comments when you want to read them.

Cheers guys, and apologies for the useless thread.

@PamboHambo Don't forget to close the ticket! :)

Haha sorry again, closed :)


Performance: Allow strings to be passed by reference [rt.cpan.org #2342]

Migrated from rt.cpan.org#2342 (status was 'new')
Requestors:

<EMAIL_ADDRESS>
Attachments:

diff

From  on 2003-04-04 18:52:09
:
We use XML::Parser in our product to parse very large XML documents.  We noticed that passing the document into XML::Parser as a string took a long time, as Perl copies this data into a second buffer.  Our solution was to pass the string by reference, but for this to work we had to modify XML::Parser to recognize references.  The attached patch shows our change.

Index: Expat/Expat.pm
===================================================================
RCS file: /webct1/cvsroot/external/XML-Parser/Expat/Expat.pm,v
retrieving revision <IP_ADDRESS>
retrieving revision 1.6
diff -u -p -u -r<IP_ADDRESS> -r1.6
--- Expat/Expat.pm	19 Apr 2002 00:19:43 -0000	<IP_ADDRESS>
+++ Expat/Expat.pm	9 May 2002 18:17:50 -0000	1.6
@@ -471,7 +471,14 @@ sub parse {
     ref($ioref)->input_record_separator($prev_rs)
       if defined($delim);
   } else {
-    $result = ParseString($parser, $arg);
+      if (ref($arg))
+      {
+          $result = ParseString($parser, $$arg);
+      }
+      else
+      {
+          $result = ParseString($parser, $arg);
+      }
   }

   $self->{_State_} = 2;

I'm open to this with tests. I'd point out that with modern versions of perl's support for COW strings, this patch is unnecessary.


[BUG]: Flaky test in children_served_report_service_spec.rb

See https://github.com/rubyforgood/human-essentials/pull/4273#discussion_r1564291195 for full discussion.
rspec ./spec/services/reports/children_served_report_service_spec.rb[1:2:1] --seed 56095 fails on main.
rspec ./spec/services/reports/children_served_report_service_spec.rb --seed 11104 passes.
The test is flaky, it is likely related to the items that are getting created when new kits are created by factory bot in the test. Most likely some of the BaseItem are getting counted as disposables since they sometimes have "Diaper" in their names. We can also tell that the seeded items are the issue since destroying all the items at the start of the test fixes the issue.
To fix this you will need to change
      toddler_disposable_kit = create(:kit, :with_item, organization: organization)
      infant_disposable_kit = create(:kit, :with_item, organization: organization)
      infant_cloth_kit = create(:kit, :with_item, organization: organization)

to ensure that those items do not have diaper in their names (i think :slightly_smiling_face: ).

I'd rather fix this with our bigger push to stop relying on seeded data for our tests.


Clean up and finalize switching RCs to Deployments in performance tests

For the justification behind the new threshold and in general going forward with Deployments instead of RCs see https://github.com/kubernetes/kubernetes/issues/79898#issuecomment-511393121

/assign @wojtek-t

/lgtm
/approve
/hold
@mm4tt - let's merge it tomorrow morning, so that we don't break anything unintentially.

/test pull-perf-tests-clusterloader2

/hold cancel

/hold

/hold cancel


My first whack at a P.R. I am likely to hose this up somehow, I guess.

Added write of line separator to modem.log within modem.py file.
Added /querynextcall to the webapp.

I am not sure where to start here... There are several items here which need to be addressed. I hope you had a chance to at least review CONTRIBUTING.md or Github Creating a pull request Please accept these comments as intended to help you create a good PR.

First off the Subject/Title of this PR conveys no useful information about the proposed change - Please edit it to describe the fix/feature being submitted. Ex: "Add new API to Web interface to support feature X."

The description of the PR does not explain what the feature is and/or how it is to be used. Submitting changes without a simple explanation of the problem being solved puts an expectation on the project developer to figure out what you are proposing. "This is good stuff, trust me..." is not useful.

Commit messages need not feature a list of files being modified/updated unless being added for clarity. A simple explanation of the changes usually suffices.

Ideally a PR should be a single commit and not the development journey. We would like to see the result or your work and not the process it took to get there. It also makes review easier. Please squash any fixes and/or additions and force push to your branch - this will automatically update the PR.

Important: Please do not submit a PR from a branch that is under active development in the upstream repository. You should always create a local patch branch for your feature and submit from there. This avoids several complications that can arise moving forward. Most notably is when future main-line development introduces unintentional conflicts with your submission and it can no longer be merged. Or, worse, if the PR is rejected, you will then have to cleanup your fork or continuously "rebase" your changes. After a PR is accepted and merged, you can then delete your patch branch.

I hope these comments give you a better idea of what the submission process is about and the level of quality expected in the application. I suggest you close this PR and re-submit after incorporating this feedback.
Additional review comments are to be found in-line on your commits.

All of this just seems like way too much effort for such small changes. And it is for reasons like my ignorance of the use/purpose of the modem.log that I asked about the value of some other changes from you and got rebuffed. Please do not think I do not appreciate all you have done and are doing. But I have no idea what "rebase, squash and force push the result" even means. So I have withdrawn this request as suggested. Sorry for bothering you.


Added option 'nofail' to fstab

As suggested in https://github.com/Azure/azure-content/pull/7774 added the option 'nofail' to this document as well

Hi @malachma, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@malachma : Thanks for your contribution to the Azure documentation! The author, @rickstercdn, has been notified to review your proposed change.

#sign-off looks good to go @tysonn

Only the author of the article can use the sign off comment to add the ready-to-merge label.

pull can be closed, after it went into main


WEBGL_UNSUPPORTED while https://webglreport.com/?v=1 and v=2 work

Hi, great component.
Unfortunately trying the demo I get WEBGL_UNSUPPORTED whereas https://webglreport.com/?v=1 or v=2 gives me
Linux x86_64 Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0
WebGL GLSL ES 3.00
GeForce RTX 2080 Ti/PCIe/SSE2

and https://get.webgl.org gives me a rotating cube.

Hi, thank you for your report. I am unsure why that would be the case and it will require some investigation.
My initial thinking is that the WebGL context crashes because it is forced in 'high-performance' mode (which indicates to the browser that it should use the most powerful GPU available on the system). Safari 12 was experiencing similar issues.
https://github.com/pmndrs/detect-gpu/blob/1c3d24dea939f02f70002276a2d89188104f3d83/src/internal/getWebGLContext.ts#L17-L25

If there is a page with and without high performance happy to test there and report back.
FWIW I did test with the WebGL cube precisely because sometimes, silently, WebGL craches but that's usually browser-wide, meaning if one tab fails, others do. Here specifically one WebGL tab worked while I had this error.

At the moment we don't support overriding this option manually in the constructor so I think this is something we might have to introduce and then I can prepare a way for you so you can test this properly in the near future.
For now could you use possibly https://jdashg.github.io/misc/webgl/low-power.html

{"powerPreference":"low-power"}
  => GeForce RTX 2080 Ti/PCIe/SSE2

{}
  => GeForce RTX 2080 Ti/PCIe/SSE2

{"powerPreference":"high-performance"}
  => GeForce RTX 2080 Ti/PCIe/SSE2

Could you try again with https://pmndrs.github.io/detect-gpu/ and if there are any errors thrown in the console report them please? It could possibly have something to do with iframing in the sandbox.

{
  "fps": 403,
  "gpu": "nvidia geforce rtx 2080 ti rev. a",
  "isMobile": false,
  "tier": 3,
  "type": "BENCHMARK"
}

It could possibly have something to do with iframing in the sandbox.

In that case we could detect it beforehand and log a error/warning.


Add the pricing page

Is your feature request related to a problem? Please describe.
Yes, I would like to add the pricing tag
Describe the solution you'd like
There will be 3 categories of prices.

Starter Plan

Price: $15/month
Features:
Access to basic design tools
50 design templates
5 projects per month
Single-user license
Access to free assets (images, fonts)
Basic export options (PNG, JPEG)

Professional Plan

Price: $49/month
Features:
All Starter features
Unlimited design templates
Unlimited projects
5 team members included
Advanced export options (SVG, PDF)
Custom branding and watermark removal
Access to premium assets (3D models, vectors, stock photos)
Real-time collaboration with team members
Version history for projects

Enterprise Plan

Price: Custom pricing (contact us)
Features:
All Professional features
Unlimited users
Custom integration with existing tools (Slack, Figma, etc.)
Dedicated account manager
24/7 premium support
Priority access to new features
API access for automation and custom workflows
Custom asset library creation
Training sessions and design consultation for teams

go ahead with this @Jay-1409

make something like this basic plan which every user can acces which is free  of cost

make something like this basic plan which every user can acces which is free of cost

okayy on it!!

@jahnvisahni31 could you pass this issue to someone better?, i am having lots of issues with using Next.js since i am not very experienced in it unlike in React . Really sorry :( .


Update vertex-notebook.ipynb

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Fix Terraform deprecated host_header condition syntax

What does this pull request aim to achieve? 💯
Deployment with Terraform is broken because of an update to a new version which deprecated the syntax for the condition block for the aws_alb_listener_rule resource.
Since this is a critical fix impacting review builds and staging, I will merge this in right away and post an announcement on Slack to rebase the latest from staging to fix deployments.

Thanks @mannykary ! Yeah I noticed last night when I was helping someone with their branch, that it was something to do with terraform that was not letting it build


ocamlPackages.mtime: 1.4.0 -> 2.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/ocaml:mtime/versions.
meta.description for ocamlPackages.mtime is: Monotonic wall-clock time for OCaml
meta.homepage for ocamlPackages.mtime is: https://erratique.ch/software/mtime
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.0 with grep in /nix/store/jgi3cqc8ww8bdmgv1klgr7l10imbc4qs-ocaml4.14.1-mtime-2.0.0
found 2.0.0 in filename of file in /nix/store/jgi3cqc8ww8bdmgv1klgr7l10imbc4qs-ocaml4.14.1-mtime-2.0.0

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
acgtk
comby
dune-release
jackline
ligo
liquidsoap

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jgi3cqc8ww8bdmgv1klgr7l10imbc4qs-ocaml4.14.1-mtime-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.mtime https://github.com/r-ryantm/nixpkgs/archive/706ec2debe4259ec01eb64f9588e4ff203d28fb3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jgi3cqc8ww8bdmgv1klgr7l10imbc4qs-ocaml4.14.1-mtime-2.0.0
ls -la /nix/store/jgi3cqc8ww8bdmgv1klgr7l10imbc4qs-ocaml4.14.1-mtime-2.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

17 packages failed to build:

acgtk
ligo
ocamlPackages.index
ocamlPackages.irmin
ocamlPackages.irmin-chunk
ocamlPackages.irmin-containers
ocamlPackages.irmin-fs
ocamlPackages.irmin-git
ocamlPackages.irmin-graphql
ocamlPackages.irmin-http
ocamlPackages.irmin-mirage
ocamlPackages.irmin-mirage-git
ocamlPackages.irmin-mirage-graphql
ocamlPackages.irmin-pack
ocamlPackages.irmin-test
ocamlPackages.irmin-tezos
ocamlPackages.progress

67 packages built:

comby
dune-release
jackline
liquidsoap
ocamlPackages.awa
ocamlPackages.awa-lwt
ocamlPackages.awa-mirage
ocamlPackages.ca-certs
ocamlPackages.ca-certs-nss
ocamlPackages.cohttp-lwt-unix
ocamlPackages.cohttp-mirage
ocamlPackages.conduit-lwt-unix
ocamlPackages.conduit-mirage
ocamlPackages.curly
ocamlPackages.dns-certify
ocamlPackages.dns-cli
ocamlPackages.dns-client
ocamlPackages.dns-client-lwt
ocamlPackages.dns-client-mirage
ocamlPackages.dns-resolver
ocamlPackages.dns-server
ocamlPackages.dns-stub
ocamlPackages.dnssec
ocamlPackages.eliom
ocamlPackages.erm_xmpp
ocamlPackages.git
ocamlPackages.git-mirage
ocamlPackages.git-paf
ocamlPackages.git-unix
ocamlPackages.graphql-cohttp
ocamlPackages.happy-eyeballs-lwt
ocamlPackages.happy-eyeballs-mirage
ocamlPackages.http-mirage-client
ocamlPackages.letsencrypt
ocamlPackages.letsencrypt-app
ocamlPackages.letsencrypt-dns
ocamlPackages.letsencrypt-mirage
ocamlPackages.metrics-unix
ocamlPackages.mimic-happy-eyeballs
ocamlPackages.mirage-crypto-ec
ocamlPackages.mirage-crypto-pk
ocamlPackages.mirage-crypto-rng
ocamlPackages.mirage-crypto-rng-async
ocamlPackages.mirage-crypto-rng-lwt
ocamlPackages.mirage-crypto-rng-mirage
ocamlPackages.mrmime
ocamlPackages.mtime
ocamlPackages.ocsigen-start
ocamlPackages.ocsigen-toolkit
ocamlPackages.ocsigen_server
ocamlPackages.ocsipersist
ocamlPackages.ocsipersist-pgsql
ocamlPackages.ocsipersist-sqlite
ocamlPackages.opium
ocamlPackages.otr
ocamlPackages.paf
ocamlPackages.paf-cohttp
ocamlPackages.piaf
ocamlPackages.plotkicadsch
ocamlPackages.resto-cohttp-self-serving-client
ocamlPackages.resto-cohttp-server
ocamlPackages.telegraml
ocamlPackages.tls
ocamlPackages.tls-async
ocamlPackages.tls-lwt
ocamlPackages.tls-mirage
ocamlPackages.x509

Maintainer pings
cc @vbgl for testing.

Updated as part of #230270


chore: loosen scenes requirement

We should be fine with anything greater than 4.26.1 which is when the ExtraQueryProvider APIs were added.

📦 Published PR as canary version: 0.1.1--canary.29.9615563401.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.1.3 :rocket:


Introduce "global" API type for Helm Values

How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
Introduces a new types/helm API package, which contains the type Values for storing arbitrary Helm values. This is mostly a copy of apiextensionsv1.JSON, but it explicitly reports its OpenAPI schema type as object, which means strategic-merge-patching is correctly used when using kubectl apply.
Which issue(s) this PR fixes:
Fixes #10267
Special notes for your reviewer:
I am not entirely sure (and also have no strong opinion) where to locate this new type. I chose pkg/apis/types/helm/ to leave room for others and to have a nice import name helm.Values{} - But we would for example move this to pkg/apis/types/v1 and rename it to  HelmValues - so that the import path could be gardenertypesv1.HelmValues{}
Created this as draft to discuss this and also because I want to see if and where I can add more tests.
Release note:
Not sure what to put here. The Kubernetes API surface is unchanged, but the go types have changed - so who is this breaking / notable for?
NONE

@dimityrmirchev
@ialidzhikov

Thanks for the PR!
I also shortly looked into fixing the issue upstream the way you described in the issue.
We could also join efforts in contributing this upstream together, or is there something that would block us from fixing it there?

By upstream you mean here? https://github.com/kubernetes/apiextensions-apiserver/blob/master/pkg/apis/apiextensions/v1/types_jsonschema.go#L337
Sure, feel free to contribute the changes there, I think code-wise it should be straight forward. If they accept the change we won't need this change here, and it's less code on our end. Once you opened the PR there I can close this one here.

Yeah, exactly :)
I cannot guarantee that I open the change upstream soon, but I have it on my list :)


[AIRFLOW-1281] Sort variables by key field by default

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following:

AIRFLOW-1281 Sort variables by key field by default

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Before:

After:

Tests

[ ] All existing tests pass.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2347 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2347      +/-   ##
==========================================
+ Coverage   69.53%   69.53%   +<.01%
==========================================
  Files         144      144
  Lines       11047    11048       +1
==========================================
+ Hits         7681     7682       +1
  Misses       3366     3366

Impacted Files
Coverage Δ

airflow/www/views.py
68.7% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e6aa7...12281be. Read the comment docs.


[helmchart] support artifacthub.io

What should the feature do:
Link the kubelet-csr-approver  helmchart to the central registry under https://artifacthub.io/
Should be not much effort: https://artifacthub.io/docs/topics/repositories/#helm-charts-repositories
What is use case behind this feature:
More visibility

hi @HaveFun83
good point! done: https://artifacthub.io/packages/helm/kubelet-csr-approver/kubelet-csr-approver

Thanks you for the quick response. :rocket:


add hex to bcd converter

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
i wud like to add this ocnverte

Go ahead
Deadline 20 May,2021


[5.7] Improve anchor escaping logic, fixing navigation to more section names

Rationale: Page sections with none standard characters do not get scrolled to, causing errors in the browse console upon clicking.
Risk: Medium
Risk Detail: Changes the escaping logic when finding which items to navigate to, upon clicking links
Reward: High
Reward Details: Users will be able to scroll to sections that have dots or other none standard CSS selector chars.
Original PR: https://github.com/apple/swift-docc-render/pull/334
Issue: rdar://57111953
Code Reviewed By: @marinaaisa
Testing Details: Added automation tests and tested manually in the browser

@swift-ci test


ENH: Refactor CLI scripts

Combine the pyradiomics and pyradiomicsbatch entry point into 1 joint entry point pyradiomics.
This new entry point operates in batch mode when input to Image|Batch has .csv extension.
In batch mode, Mask argument is ignored. In single mode Mask inputs is required.
Additionally, enables easy multi-threaded extraction by specifying --jobs / -j argument (with integer indicating number of parallel threads to use.
Will only work in batch mode, as extraction is multi-threaded at the case level (1 thread per case).
Removes argument --label / -l, specifying an override label to use is now achieved through specifying -s "label:N", with N being the label value.
Also includes a small update to initialization of the feature extractor:

In addition to a string pointing to a parameter file, feature extractor now also accepts a dictionary (top level specifies customization types 'setting', 'imageType' and 'featureClass') as 1st positional argument
Regardless of initialization with or without a customization file/dictionary, kwargs passed to the constructor are used to override settings.

cc @Radiomics/developers

Maybe for now include a stub entrypoint for pyradiomicsbatch that issues an error and pointer to the documentation for switching to the new style.

lgtm 👍


GT Trans Parameters

How can I create GT trans parameters of my own ply files?

Hello.
How did you solve that problem?
I met a same thing.
Thanks.


App: oraclejdk8: Manifest removed

While I've been using scoop for a while, I am not sure what this means:
These app manifests have been removed:
oraclejdk8
AFAIK, adb from android-sdk still requires Java 1.8, all attempts in the past year I've made with newer java resulting in weird issues.   Was this app removed?

Oracle does not distribute Oracle Java 8 anymore. Use one of the alternatives in scoop-java. I would go with AdoptOpenJDK or Zulu.

Invalid, Clarified in java bucket


onReconnecting and onReconnected bug fix

You should use the new repo at https://github.com/realtime-framework/RCTRealtimeCloudStorageIOS


Picker function is not defined

I have a grunt task which will concat all the js files in materializecss folder. As there are 2 files in the date_picker folder , picker.date.js which is dependent on picker.js . Whenever concatenation of the js takes place picker.date.js is added at the top and picker.js next. So this throws the error.

Take a look at https://github.com/Dogfalo/materialize/blob/master/Gruntfile.js to see how to concat the js files

Thanks .. that was helpful


format_code_block_text should avoid string copy when tag doesn't match

If the tag doesn't match anything, then the user should be able to say to format with the original string instead. This will avoid a needless copy.

Implemented in a5d3403b87198205e1bb61863dd918eb16489ff2


Align Credentials Input to AWS

Hello,
Ive noticed that when using AWS provided Actions, credentials are passed like this:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY }}
aws-secret-access-key: ${{ secrets.AWS_ACCESS_SECRET }}
aws-region: ${{ secrets.AWS_REGION }}

Note the dashes - while here, they are passed with underscores:
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY }}
aws_secret_access_key: ${{ secrets.AWS_ACCESS_SECRET }}
aws_region: ${{ secrets.AWS_REGION }}

Wondering if it makes sense to align with the provider whose service is actually being used?
Thanks!

Suggested fix - change src/constants.ts to:
export enum Inputs {
  AWS_ACCESS_KEY_ID = 'aws-access-key-id',
  AWS_SECRET_ACCESS_KEY = 'aws-secret-access-key',
  AWS_REGION = 'aws-region',
  SECRETS = 'secrets',
  PARSE_JSON = 'parse-json'
}

Makes sense. Feel free to submit a pull request 🙂
If not, I'll get to this soon.

PR Submitted: https://github.com/action-factory/aws-secrets-manager-action/pull/9
Thanks!


Mails shown twice

With some mails, K-9 Mail shows the mail twice; and selecting one of these messages also selects the other. The message-count is correct.
This seems to be a GUI error.
Maybe #981 was the same error.
Expected behavior
Every message should only be shown once.
Actual behavior
Some messages are shown twice by K-9 Mail.
Example (GUI output approximated in ASCII) with two messages (each shown twice):

Message list: 2 Messages
[ ] To<EMAIL_ADDRESS>"TEST 2"
[ ] To<EMAIL_ADDRESS>"TEST 2"
[ ] To<EMAIL_ADDRESS>"TEST 1"
[ ] To<EMAIL_ADDRESS>"TEST 1"

select 1st message -> duplicate is automatically selected, too
[X] To<EMAIL_ADDRESS>"TEST 2"
[X] To<EMAIL_ADDRESS>"TEST 2"
[ ] To<EMAIL_ADDRESS>"TEST 1"
[ ] To<EMAIL_ADDRESS>"TEST 1"

moving/deleting the message, also moves/deletes the duplicate

after moving the message to an other folder, it is then shown 3 times, after moving again to an other folder, it is shown 5 times, after then moving back it is shown 9 times, then 17 times, then 33 times ...
So, after each move, the "duplicates" increase.

there's also only one entry in the messages-table of the SQL database

Environment
K-9 Mail version: 5.600
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

You're using an over 1 year old version of K9 (from 2018). Try using 5.700 which was released in Nov 2019, or the new 5.703

Please update your app to v5.703 and see if the issue is still there.

I'have a similar problem that I get duplicated mails but only recently received and new mails. Old mails are shown correctly. With a different email's client mails aren't shown duplicated. Version is v5.707

Duplicate of #2705


Error: Operations are currently not running.

When users are trying to export data using the export to CVS Format tool they receive this message "Error: Operations are currently not running. Please contact administrator"
I want to know how to fix this problem? Is there an activation or deactivation functionality?

The System Version is 9.20

Hi @glorykakessa, "operations are currently not running" generally means the Delayed Job service on your linux server is not running. Can you try sudo systemctl restart delayed-job and see if that helps?
Happy to diagnose further depending on how that goes -- the next thing I'd need to know is the output of sudo systemctl status delayed-job.

Hi @cooperka i've tried to restart the dealayed-job but it didn't work, the after i decided stop all and restart later using the following steps :
I've first stoped the delayed-job and the nginx server as well with this command sudo systemctl stop delayed-job && sudo systemctl stop nginx
I've wait some minute and I've restart again using this sudo systemctl restart delayed-job && sudo systemctl restart nginx
And everything went well!!

Fabulous! I'm glad it's working, let us know if we can help with anything else.


GRA-985/host updates

-> Mq handlers for host updates
-> place holders to add logic for host update,delete actions
@theguy951357 I would suggest skip this PR for testing, no actual changes you can test on this one

fix staticcheck error for lastPeerUpdate unused in daemon.go
update gui/exported.go so build works

static checks are on a separate ticket, it does not affect what he wrote


firebaseConfig.ts

erm, should that really be public?

Thanks for the note, I know this is a very late reply, but this is the supported use for Firebase config- it does not contain sensitive information. See more here: https://firebase.google.com/docs/projects/api-keys?hl=en&authuser=0#api-keys-for-firebase-are-different


AKS doesn't play well with controllers

We have both our garden and seed clusters running on AKS.
Apparently AKS doesn’t play well with controllers running inside the cluster due to VPN issues between AKS control plane (apiserver) and nodes, you can find the details in https://github.com/Azure/AKS/issues/676
This is causing lots of noise both in gardener and machine controller manager logs and could be causing some other unpredictable issues since it regularly break watches.
Both component logs (gcm and mcm) are full of these errors:
E1017 09:12:18.882096       1 streamwatcher.go:109] Unable to decode an event from the watch stream: stream error: stream ID 989; INTERNAL_ERROR
The suggested solution from Azure is to inject these environment values to the pods which runs controllers:
      env:
        - name: KUBERNETES_PORT_443_TCP_ADDR
          value: <your-fqdn-prefix>.hcp.<region>.azmk8s.io
        - name: KUBERNETES_PORT
          value: tcp://<your-fqdn-prefix>.hcp.<region>.azmk8s.io:443
        - name: KUBERNETES_PORT_443_TCP
          value: tcp://<your-fqdn-prefix>.hcp.<region>.azmk8s.io:443
        - name: KUBERNETES_SERVICE_HOST
          value: <your-fqdn-prefix>.hcp.<region>.azmk8s.io

The gardener chart would be as easy as allowing to pass extra env values to the pods, so i think that would be covered easily.
But for charts/seed-controlplane/charts/machine-controller-manager I’m not sure about adding hosting provider specific logic, for which we also need to eventually update the pkg/operation/botanist/controlplane.go to discover if the shoot's seed is operating on AKS and pass it to the mcm chart.
But I can't see any other solution since there is no way we'd be moving out of AKS. Any suggestions?

Oh I didn't think about MutatingWebhooks, I guess thats what AKS is working on as the definitive (!) solution to the problem. We don't have experience on these but will check, thanks for the pointer.
I thought PodPreset would be a great fit for this but its still alpha and won't likely be enabled on AKS soon.

OK. Are you fine with closing the issue?


[DO NOT REVIEW] GEODE-7294: Update dependencies for v1.11

Update as many dependencies as we can for v1.11. Since
so many updates are included, please review the change
set to see them all. Not all dependencies have been
advanced; only the ones that seemed safest to do easily.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Let's close this out in favor of #4496.


Is there a way to scroll to a date / time on runtime?

It seems to be a great widget but before using it, is there a way to scroll to a date / time on runtime? I like to place a couple of "buttons" under the picker to preselect common times like "08:00", "13:00" or "18:00". After clicking a button, the picker should scroll to the selected time (in an animated style if possible). So I need somethink like a "scrollContainer"...are there plans to support this?

hi! such functionality already on my backlog:
https://github.com/dhiyaaulauliyaa/scroll_datetime_picker/assets/20693268/df0d2776-27db-49cd-a56e-1114882a36b4
should be released soon. stay tune!

Hi,
that's incredible!!! Thank you sooo much ;-)
Best regards,
Marc
------ Originalnachricht ------
Von "Ahmad Dhiyaaul Auliyaa" @.>
An "dhiyaaulauliyaa/scroll_datetime_picker"
@.>
Cc "Marc Hoffmann" @.>; "Author"
@.>
Datum 29.05.2024 09:51:56
Betreff Re: [dhiyaaulauliyaa/scroll_datetime_picker] Is there a way to
scroll to a date / time on runtime? (Issue #14)

hi! such functionality already on my backlog:
https://github.com/dhiyaaulauliyaa/scroll_datetime_picker/assets/20693268/df0d2776-27db-49cd-a56e-1114882a36b4
should be released soon. stay tune!
—
Reply to this email directly, view it on GitHub
https://github.com/dhiyaaulauliyaa/scroll_datetime_picker/issues/14#issuecomment-2136770425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZZGW5HKVZ4B6US5O2QAEDZEWCJZAVCNFSM6AAAAABIM4TXAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWG43TANBSGU.
You are receiving this because you authored the thread.Message ID:
@.***>

Could you please tell me when this feature will be released? I really need it, thanks.

嗨！我的待办事项中已经包含此类功能：
模拟器.屏幕.录制.-.iPhone.15.Pro.-.2024-05-29.at.14.49.12.mp4
应该很快就会发布。敬请期待！

hi! such functionality already on my backlog:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-29.at.14.49.12.mp4
should be released soon. stay tune!

Could you please tell me when this feature will be released? I really need it, thank you.


Peer to Peer Code Review

Hi @AnsarIbrahim. Great job with the project requirements so far👌.
You have implemented most requirements correctly.🎉
Finish up your workload by implementing auto-refresh of the comments section on the popup when a new comment is added🤞🤞.
Happy Coding.


Is it possible to loop over subfloders for AssemblySearchPath

My project uses huge nupackages references, and I cant afford to add them into AssemblySearchPath one by one
Is there a way to include a single path and also its sub folders to search for Assembly reference?
GPT told me to use this but it never works

This was brought up in the past several times, but no plan to implement it.
You can write your own script to generate the config file on the fly where the loop can be inside your own script, not Obfuscar itself.


Artifacting and Blurry Text

System Details

OS: Windows 10 Pro 21H2 19044.3086
Thorium Version: 117.0.5938.157
CPU: Ryzen 3900x
GPU: Gigabyte 1080ti
Ram: 4x16GB G.Skill
MB: MPG X570 GAMING EDGE WIFI

Problem
Artifacting on videos, other CSS elements, and blurry rendering of text. It's on and off, mouse position seems to have an effect, not sure exactly what though.
First time using Thorium so I am not aware if this is recent or old.
Screenshots
Video showing the problem
https://youtu.be/KUBqkhDh7GA
Additional Notes
Doesn't happen on a Windows 11 Ghost Spectre VM

Ticking off "Use hardware acceleration when available" appears to make the issue go away or reduce the occurrence immensely

Since turning on hardware acceleration can help solve or alleviate the problem, keep it turned on.

Since turning on hardware acceleration can help solve or alleviate the problem, keep it turned on.

Turning off* Turning hardware acceleration off appears to have stopped the issue.


Lots of Updates to Slides & Homework after teaching class.

General Updates:

removed nested <sections>. I find that students have a difficult time following along with the slides when they are nested.
added <strong> to bold important text
fixed typos
added <code> tags around filenames or syntax in text.
removed spaces in function invocations: console.log (numberOfKittens) becomes console.log(numberOfKittens)
added empty lines between code statements for better readability.
added spaces in code comments to make them more readable.

class1.html Updates

specified exact ECMAScript version covered in class.
added "What can JavaScript do?" sections to Intro.
moved explanation of <script> tags before first 'Develop It' exercise.
removed warning about browsers behaving differently.
rewrote slide explaining 'statements' to be clearer.
changed definition of variable to relate back to algebra.
updated inaccuracy: variables created with no value are undefined not null.
added 'avoiding reserved words' to 'naming variables' requirements & to 'choose clarity and meaning for humans to read later.'
rearranged variable slides.
added section about Data Types before jumping into types of data and operators.
added NaN to numbers section (in case they run across it doing calculations).
specified that strings can be in single or double quotes.
added toFixed() in last exercise (because all the students end up asking how to round up their bill amount)

class2.html Updates

added use of word "invoke" into functions section.
changed uses of the word 'call' to 'invoke'.
updated turtleFacts to parrotFacts because...parrots ;)
placed "return" in code tags and lowercased.
Updated definition of variable scope from 'The scope of a variable is how long the computer will remember it.' to more accurate 'The scope of a variable determines where it's value is accessible throughout your program.'
placed 'true' and 'false' in code tags and lowercased.
added slide to Boolean Variables section describing the concept of 'falsy' to replace misleading statement "If you try to use another variable as a boolean, JavaScript will guess...."
updated age at which you can run for Senate (it's 30, not 25).
updated all Conditional statements to follow same theme of 'running for office' examples.

class3.html Updates

added 'while' and 'for' in code tags and lowercased.
Updated "FizzBuzz" to be more closer to FizzBuzz examples I've seen.
added definition of 'zero-indexed' to array bracket notation example.
updated 'aboutMe' examples to be more ambiguous 'user' so there's no need to update slides.
updated 'myCats' examples to be more ambiguous 'users' so there's no need to update slides.
added suggestions for properties for the recipe to help them get started.
updated function example for recipe object to be more relevant to cooking.
removed slide about "built-in" objects. It was an incomplete list and seemed out of place in context.

class4.html Updates

updated example of ID's in html from footer to banner (since footer is more likely used as a tag in HTML5 now)
Updated description of DOM tree, discuss how it's not flat HTML, but a tree structure defined by the Document Object Model.
Updated DOM Access to have more accurate description of how Document object exists and what you can do with document.
Updated typo / more accurate description for DOM Access by tag name.
added comments to "DOM Nodes: Attributes" slide to more accurately describe what the code is accessing and setting.
added that innerHTML gets the html AND content of its children.
fixed issue with element example in "Creating New Nodes" being inaccurate example of appendChild
added comments to "Creating New Nodes" slide for clarity.
updated definition of 'event' to be more accurate to what events are and do.
updated use of 'onclick' listeners to more conventionally user of addEventListeners
added event as argument to all event listener functions.
updated Events table to actual event names (not event listeners).
added mouseout and blur into common events table.
removed 'Events and Codes' slide.
updated id of button to be more generic instead of describing behavior in "Calling Functions from HTML" slide
added example of "Calling Functions from JavaScript" as this is more common when writing JS.
updated "Develop It" section to specify "mouseover" as the event (not onmouseover)
updated Preventing Defaults slide to talk about 'links' and 'checkboxes' having default behaviors (not buttons since this is more complex example).
updated prevent default example to use addEventListener and to use the event argument to call preventDefault (which is more common)
updated "This" slide to instead reference event.currentTarget (which more accurately returns the element that the event listener is attached to).
Updated HTML <form> to take user input instead of temperatures to be less complex.

homework.html Updates

updated examples with degrees to include unicode character for degrees (pasting in degrees symbol does not work in JavaScript).
updated "Logo Hijack" example in Class 4 to remove replacing google search button text (Google has changed their markup and this example is no longer accurate).
updated book examples to JavaScript books in homework.
added missing closing <li> tags to "About Me" example in class 4.
updated image in homework answer from Pamela Fox to Ada Lovelace.

@jennifer-mann Ooo, fancy. Looks like there's a merge conflict. Can you try to rebase?

Fixed conflicts.


prettier breaks jinja whitespace control

Firstly, thanks for this, its made me able to get my jinja templates looking nice
I have a element which has a long enough class declaration such that the whole thing e.g
<element class="extemely_long__class_name extemely_long__class_name--modifier>{{ some_variable }}</element>

won't fit on on one line. Prettier therefore reformats it to (leaving out the class for clarity)
<element>
    {{ some_variable }}
</element>

Unfortunately as I am using a white-space: pre rule on that element this has undesirable side effects, by adding blank likes above and below the text
The way to fix that in jinja is to use the whitespace control rule and do
<element>
    {{- some_variable -}}
</element>

however this gets reformatted to
<element>
    {{ - some_variable - }}
</element>

which jinja parses as a syntax error
I've worked around it by adding <!-- prettier-ignore --> before the element, but wanted to let you know about the issue

Sorry for the late response.
I didn't know that you could strip whitespace with a minus sign in an expression.
Support for this syntax has now been added with the v0.3.0 release.
If you consider whitespace significant in your templates you can also add the config option "htmlWhitespaceSensitivity": "strict" to you prettier config.


Standalone build broken

Is this code supposed to build outside the RDK yocto environment?
Attempted to build on Ubuntu 18.04 LTS 64-bit platform using cmake version 3.10.2. The following error occurred:
cmake ~/Projects/Thunder/
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting up WPEFramework v1.0.0
-- Building on Linux
-- Looking for GNU_LIBRARY
-- Looking for GNU_LIBRARY - found
CMake Error at CMakeLists.txt:51 (find_package):
By not providing "FindProxyStubGenerator.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"ProxyStubGenerator", but CMake did not find one.
Could not find a package configuration file provided by
"ProxyStubGenerator" with any of the following names:
ProxyStubGeneratorConfig.cmake
proxystubgenerator-config.cmake

Add the installation prefix of "ProxyStubGenerator" to CMAKE_PREFIX_PATH or
set "ProxyStubGenerator_DIR" to a directory containing one of the above
files.  If "ProxyStubGenerator" provides a separate development package or
SDK, be sure it has been installed.
-- Configuring incomplete, errors occurred!
See also "/home/msm/Projects/Thunder/build/CMakeFiles/CMakeOutput.log".

I got around this issue by doing the following:

mkdir build-tools
cd build-tools
cmake ~/Projects/Thunder/Tools
sudo make install

I got around this issue by doing the following:

mkdir build-tools
cd build-tools
cmake ~/Projects/Thunder/Tools
sudo make install

Indeed you first need to install the tools (JSONRPC Code generator and COMRPC ProxyStb code generatr) and only than you can build the Thunder libray. Will updat the documentation to reflect this accordingly.


error message

Every polling leads to this response from finvizfinance:
\nsave as portfolio | \ncreate alert \nRefresh: 3min | off		\n\nPage 1/2Page 2/2\n

Please provide your code and your version. Looks fine on my end.

Close due to inactive.


Add (javax.)Validation Support for Stream Listener

Hi,
Just like Spring MVC, it would be great if StreamListener annotated methods could be additionally annotated with a @Valid annotation for the method parameter, then the converted message type could be validated using standard javax.validation (and spring validation) processes before the body of the method is invoked (i.e., in the example below, before fooRepository is called).
Something akin to this:
data class Foo(

   @field:NotBlank
   @field:Length(min = 1, max = 10)
   val name

)

@StreamListener(INPUT)
fun createNewFooInDatabase(@Valid foo: Foo) = fooRepository.create(foo)

A message that fails validation would be put unto any configured Error channel for alerting or handling by other business processes.
-=david=-

David
I am not sure what's required from us? I mean don't you just need to implement and register a validator for your object and register it with DataBinder?

I'm just getting familiar with the codebase so sorry if the analysis is wrong. I think I see your point, @olegz, about

just need to implement and register a validator

Since the PayloadArgumentResolver does take an optional validator to validate the incoming payload if it is annotated for validation. But I think the issue is that BindingServiceConfiguration::messageHandlerMethodFactory does not take a validator in its bean definition so it is never set on factory. If we set that in the factory, then annotating @Valid on the @Payload parameter should work like @dharrigan is expecting. Thoughts?

I think that would definitely help. Having the (optional) ability to validate a payload received by a StreamListener (which by design is meant to deserialise back into an object) would be mighty helpful!

Hi,
I've got a PR cooking that adds a Validator to the unreleased version of Spring Cloud Stream and it appears to work. I'll probably need a bit of assistance in answering a few questions, but in general the approach seems to be okay.
-=david=-

The best way is to submit a PR in whatever form it is and we'll work with you. The main thing is to include some level of testing.

Hi Oleg,
I've pushed up a branch (GH-1382) on my repo with the change. It's quite simple - however, I'm not too sure how to test it, also:
The class where the change is, BinderFactoryConfiguration is marked as deprecated. What to do?
If there is no validator found (i.e., if a JSR-303 implemenation is not found on the classpath), I'm not quite sure if a "null" for validator will be passed in.
Would you be able to offer some assistance on how to test and offer some guidance on the other points?
Thank you.
-=david=-

Here is a little (incomplete) example that shows a possible usage of the change:
private val LOGGER = KotlinLogging.logger { }

@Configuration
@EnableBinding(KafkaBindings::class)
class StreamConfig {

    @StreamListener(CONTRACT_CREATE)
    fun contractCreate(@Valid contractCreate: ContractCreate) {
        LOGGER.info { "Received [$contractCreate]." }
    }

    @Bean
    fun errorFlow(): StandardIntegrationFlow = IntegrationFlows.from("errorChannel")
        .routeByException {
            it.subFlowMapping(MethodArgumentNotValidException::class.java) { subFlow ->
                subFlow.handle { messageHandler ->
                    (messageHandler.payload as? MethodArgumentNotValidException)?.let { manve ->
                        manve.bindingResult?.fieldErrors?.forEach { fieldError ->
                            LOGGER.error { "[${fieldError.objectName}.${fieldError.field}] rejected [${fieldError.rejectedValue}] because [${fieldError.defaultMessage}]." }
                        }
                    }
                }
            }
        }.get()

}

data class ContractCreate(

    val id: String,

    @field:Length(min = 1, max = 5)
    val foo: String,

    @field:Length(min = 4, max = 3)
    val bar: String

)

If foo or bar fail validation, then the subFlow will fire. Inside that subFlow could be specific business logic to fix the data up, or route onwards to another channel for processing elsewhere (or error logging/reporting/metrics).

Hi,
I've pushed up a new commit that includes two tests - a test for valid validation and a test for invalid validation. I hope that helps to progress this issue :-)
-=david=-


WIP: add support for unstable tests to common

This PR proposes the first step to use the unstable flag for unstable tests in the containers.
See more in https://github.com/sclorg/s2i-python-container/pull/510

Do you plan to open a PR against Python container so we can test them together?

Yes, it is in progress, I am now testing it locally. When the change is ready I will create the PR against s2i-python.

[test-all]


fix(v2): ignore export declarations in excerpt

Motivation
Fixes #3700 (follow-up ##2380).
Also in this PR I refactored the logic of creating excerpt, make it much simpler and faster (because we no longer remove all the imports/exports).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Unit tests.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Oh dear, why are there no running job with unit tests  in CI? :man_shrugging:

thanks, LGTM 👍