[Suggestion] Check empty feed on broken bridges

Hello.
Broken bridges gives empty feed (like Bloomberg one on #768 ), maybe it could be tested (button ?), like asking all active bridges to "create atom feed" and if empty... mark as broken or create an html report ?

Most bridges do require parameters and have options, each of which must be selected carefully. This is not a job taken lightly. While I see a use for debugging purposes, the maintenance cost is high and there is hardly any use to the information.
Even if bridges are broken, why repair them? Bridges should be used, they are not made just for the purpose of being there. Once a bridge breaks you get error messages which should be reported (or fixed via PR). If nobody reports a broken bridge, it is either not used or nobody cares. In that case the bridge can stay broken or be removed entirely.
That being said, here is a script that @mitsukarenai made in the past to detect broken bridges: https://gist.github.com/mitsukarenai/936273089c45f8d64b7b28af4e903726
With some effort this script could be extended to utilize the new list action for some automation, but you still need to provide required parameters to a lot of bridges.

Thanks for the answer.
You're right about not being fixed unused bridges :)


JSONObject's license is restrictive

LGPL code can't be used in a lot of environments (anywhere that requires static linking, so the iOS app store, most consoles, etc), and so you should replace it with a JSON library with a more permissive license.
Unfortunately, I don't know if this can be done while maintaining backwards compatibility.

@thomcc I can't seem to find JSONObject's license. Could you link us to it?

JSONObject's license was changed to MIT license on Oct 2015.
https://github.com/mtschoen/JSONObject


Fixed LQRunningPollView using the incorrect poll object for visualization

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 48.515%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Liquid-Core.package/LiquidRunningPollView.class/instance/closePoll.st
0
1
0.0%

packages/Liquid-Core.package/LiquidVisualizationView.class/instance/visualizeResults.st
0
1
0.0%

packages/Liquid-Core.package/LiquidRunningPollView.class/instance/visualizeResults.st
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

packages/Liquid-Core.package/LiquidVisualizationView.class/instance/visualizeResults.st
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
490

Relevant Lines:
1010

💛  - Coveralls


Can we download the layout (graph) as a pdf/eps/svg?

That would be handy.
How difficult is this @antw @grdw?

It's currently already an SVG object within the html page. Could we use something like:
respond_to do |format|
  format.svg { render inline: svg}
end

The layout is rendered entirely using JavaScript, so there's nothing on the Rails side that we could reuse to build this: it would have to be made from scratch.
We can already generate the graph layout from Refinery using GraphViz, but it's not nearly as readable. If we could find a way to reuse the converter positions from ETEngine and feed the into GraphViz, that would make the output far more useable.

The layout is rendered entirely using JavaScript, so there's nothing on the Rails side that we could reuse to build this: it would have to be made from scratch.

Anything on the JavaScript side then?

You can convert an svg to a png. I had to investigate a little for ETMoses. I'm not sure if it's functional yet :sweat_smile: . I'm going to look into it tomorrow for ETMoses in https://github.com/quintel/etmoses/issues/604

You can convert an svg to a png. I'm going to look into it tomorrow for ETMoses in quintel/etmoses#604

:+1:
I have added a "save as SVG" option in the meantime:

You can convert an svg to a png. I had to investigate a little for ETMoses. I'm not sure if it's functional yet :sweat_smile: . I'm going to look into it tomorrow for ETMoses in quintel/etmoses#604

@grdw, what is the status of that search? Would you have time to pick this up?

@grdw, what is the status of that search? Would you have time to pick this up?

Pretty much over. It's possible to download an SVG as a PNG.

Pretty much over. It's possible to download an SVG as a PNG.

Would it be possible to implement something similar in ETEngine?

Would it be possible to implement something similar in ETEngine?

SVG download was added a month or two back. Go to the layout page, wait for the graph to load, and you should see this:

Is PNG really needed? I'd prefer not to have to add RMagick to ETEngine just for this feature unless it were truly necessary.

@dennisschoenmakers , as you raised this issue, can it be closed?

Yes, it can be opened and edited in Illustrator.


Hanging when quickly traversing pages

Bug
There are two (related?) issues:

Fast rewind hangs on the first-reached data page
Fast rewind hangs directly before the first-reached data page

Identical analogues exist for fast forward.
Repro

Make some number of objects on a page that's not the first (probably can be first but not tested)

Leave the other pages empty

Make a large (~100 should work) number of blank pages to the right
Press and hold the previous page binding
Sometimes hangs

Example
https://pihart.github.io/qboard/?json=issues/rewind-hang-121.json (f5781128920cc1c62a005ca4ba1e70ccaacda447)
Has been guaranteed to sometimes hang, both in forward and rewind, with both issue types 1 and 2. (Objects are on page 30.)

This has been a long-standing issue. I am reporting it to reference. It may be related to #72.

It doesn't make sense for this to be caused by locking, as suggested in #122, because in the current implementation locks are only used for history-adjacent operations.
In the linked example, I have also gotten it to hang on page 104, I believe while traversing leftwards. The entire application hangs, indicating that some operation is blocking the thread. While it's frozen, the application uses a high amount of CPU, indicating the same.


Password Reset Link Broken

When a user clicks on the forgot password button on the login screen the email sent out is of the form /login?token=a_long_hash_of_chars and missing the rcos.io

Fixed via a environment variable


Support generic qna/cmdline options in help form

Coverage decreased (-0.003%) to 57.607% when pulling 75d8a6911ad5e311e38cd737740ed8c5ce14a962 on dennisschagt:bugfix/cmdline-in-help into 6b1ac11f91559aeef19cc3765d0cb410b263f076 on newsboat:master.

Makes sense! Thank you for the PR.


feat: l1ToL2MessageNonce

Feature Request
Describe the Feature Request
As a user, I would like to query l1ToL2MessageNonce of the StarkNetCore contract.
Describe Preferred Solution
l1ToL2MessageNonce is accessible in the core library, and as a CLI command, and a REST API endpoint.
Describe Alternatives

Related Code

beerus_core

beerus_cli

beerus_rest_api

[X] Yes

[ ] No

Ok I'll try this one as my first issue if it's ok for all


Implement StrongboxUriComponentsBuilder to centralize generating urls

The issue
Strongbox has a configuration field in the strongbox.yaml called baseUrl. This field contains the baseUrl (i.e. http://my-domain.com) which is used when generating URLs for search results, download links and so on. This introduces a few inconveniences:

The field requires the user to actually configure it properly or else it will point to localhost which will result in "strange" behaviors that new users might consider as bugs.
No support for reverse proxies.
Using the baseUrl creates code duplication (i.e. baseUrl + "/api/browse", baseUrl + "/storages/**", being copy/pasted around).

Task Description
We need to create a UriComponentsBuilder class which can be used to generate any type of Strongbox URLs.
Tasks
The following tasks will need to be carried out:

[x] Create StrongboxUriComponentsBuilder class which extends org.springframework.web.servlet.support.ServletUriComponentsBuilder. This will give us X-Forwarded-* support out of the box.

[x] Use ServletUriComponentsBuilder.getCurrentRequest() to pre-populate the builder with the details from the current request.
[x] The baseUrl in strongbox.yml should be optional or blank by default.

[x] If baseUrl is not empty - it takes precedence over X-Forwarded-* headers and the generated URL will contain the configured baseUrl.
[x] If no baseUrl is configured (or is blank) then X-Forwarded-* headers will be honored; If no X-Forwarded-* headers have been found then the baseUrl will taken from HttpServletRequest (scheme, host, port, path, etc).

[x] Make it possible to get a "generic" builder so we can build any URL we need using the proper host, port and path.

[x] Remove RepositoryFileAttributeType.RESOURCE_URL and it's usage (no longer necessary?)
[x] Refactor the DirectoryListingServiceImpl to use StrongboxUriComponentsBuilder

[x] Apply all/any necessary changes to controllers using the DirectoryListingService.

Task Relationships
This task:

Relates to: #1698

Hi, I would like to take this up, I am new to open source projects so help me out to understand a little if possible and let me know if I can start on digging down into it.

Hi @Maganpreet - you are commenting under a finished pull request (in other words the task is completed). Maybe choose another task? :)

@steve-todorov ,
If the work for this is ready, could you please merge the pull requests, so we can close it? Thanks! :)

Hi @steve-todorov , my bad couldn't figure it out so the tasks having label help-wanted are gonna be the open issues right? or can you assign me anything if that's alright?

@Maganpreet ,
You can join our chat channel for such discussions.


Certificates instead of Client Secret

Can I use a certificate, to connect with BC2ADLS to the Data Lake?

At the moment you can only connect to data lake with client credentials flow with a secret and not with a certificate.

Thanks


[SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script

What changes were proposed in this pull request?
It seems that Jenkins tests tasks in many pr have test failed. The failed cases include:

org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V2 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V3 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V4 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V5 get binary type

The error message as follows:
Error Messageorg.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�]("Stacktracesbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�]("
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
	at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
	at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
	at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
	at org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.$anonfun$new$26(SparkThriftServerProtocolVersionsSuite.scala:302)

But they can pass the GitHub Action, maybe it's related to the LANG of the Jenkins build machine, this pr add export LANG="en_US.UTF-8" in run-test-jenkins script.
Why are the changes needed?
Ensure LANG in Jenkins test process is en_US.UTF-8 to pass HIVE_CLI_SERVICE_PROTOCOL_VX related tests
Does this PR introduce any user-facing change?
No
How was this patch tested?
Jenkins tests pass

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131634/testReport/org.apache.spark.sql.hive.thriftserver/SparkThriftServerProtocolVersionsSuite/HIVE_CLI_SERVICE_PROTOCOL_V1_get_binary_type/
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131659/testReport/org.apache.spark.sql.hive.thriftserver/SparkThriftServerProtocolVersionsSuite/HIVE_CLI_SERVICE_PROTOCOL_V1_get_binary_type/
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131619/testReport/org.apache.spark.sql.hive.thriftserver/SparkThriftServerProtocolVersionsSuite/HIVE_CLI_SERVICE_PROTOCOL_V1_get_binary_type/

Wait for Jenkins test  to verify the results

Test build #131669 has started for PR 30487 at commit 5c90411.

Thank you for investigating, @LuciferYang .

Merged to master/branch-3.0/branch-2.4.

Test build #131669 has finished for PR 30487 at commit 5c90411.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131669/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36269/

@dongjoon-hyun thx ~

Oh, I see. nice. @wangyum FYI

thx  ~ @HyukjinKwon :)


pip install fail

Collecting spider_rs
Using cached http://mirrors.aliyun.com/pypi/packages/26/ba/bc4bf77e7923583aede0ed4a203f2ea5c2d6a2c85fe8d07f4b3f81570c9b/spider_rs-0.0.30.tar.gz (38 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... error
error: subprocess-exited-with-error
× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [14 lines of output]
Updating rsproxy index
From https://rsproxy.cn/crates.io-index
* [new ref]         HEAD       -> origin/HEAD
error: failed to select a version for the requirement spider = "^1.86.11" (locked to 1.86.11)
candidate versions found which didn't match: 1.86.5, 1.86.4, 1.86.3, ...
location searched: rsproxy index (which is replacing registry crates-io)
required by package spider_rs v0.0.30 (C:\Users\m1778\AppData\Local\Temp\pip-install-v_9bx8vo\spider-rs_d3f1942900e14bb9966f68dbe963a045)
perhaps a crate was updated and forgotten to be re-vendored?
馃挜 maturin failed
Caused by: Cargo metadata failed. Does your crate compile with cargo build?
Caused by: cargo metadata exited with an error:
Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', 'C:\Users\m1778\AppData\Local\Temp\pip-modern-metadata-pzhkjv6h', '--interpreter', 'C:\Users\m1778\.pyenv\pyenv-win\versions\3.11.6\python.exe']' returned non-zero exit status 1.
Checking for Rust toolchain....
Running maturin pep517 write-dist-info --metadata-directory C:\Users\m1778\AppData\Local\Temp\pip-modern-metadata-pzhkjv6h --interpreter C:\Users\m1778\.pyenv\pyenv-win\versions\3.11.6\python.exe
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Hi can you try 0.0.31? There was an update with maturin messed up some of the compilation of the cargo crate metadata like being able to add a 'description' etc. This recently just started happening.

pip install spider_rs
Collecting spider_rs
  Downloading spider_rs-0.0.31.tar.gz (40 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 40.2/40.2 kB 1.9 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: spider_rs
  Building wheel for spider_rs (pyproject.toml) ... done
  Created wheel for spider_rs: filename=spider_rs-0.0.31-cp311-cp311-macosx_11_0_arm64.whl size=7828504 sha256=c3ec7eb5f5f60fc543f2f509f91f9bca1a7d4622456df2ebfd7a550b60593f5a
  Stored in directory: /Users/jmendez/Library/Caches/pip/wheels/53/46/f1/5045ed476b19aef1626e769090fb9707c541ed3da4eac50950
Successfully built spider_rs
Installing collected packages: spider_rs
Successfully installed spider_rs-0.0.31

0.0.31 works on mac, I need to spin up a windows vm to test later.

thx，I just installed 0.0.33 successfully.


Update typings for node-postgres version 6

I suggest we skip version 5 as it did not live very long. So this is a ticket handling the support for version 6, until I submit a PR.
Roadmap: due to business I will try to do it until next monday or tuesday (12th of july).

Hello @0815fox. I've update typed-pg and npm-pg-pool to match pg v6 and add each other as a dependency. By doing that we now don't have more duplicates interface like Client, Query, etc. I would like you to take a look at it before merging into master. All changes were committed to vnext tag.
https://github.com/typed-typings/typed-pg/tree/vnext
https://github.com/typed-typings/npm-pg-pool/tree/vnext

Hi Guilherme,
oh it looks great, thank you! I did not even expect it to work seamlessly with circular dependencies, interesting though, that it still works. I will take a look at it today and provide feedback. This week I do not have too much time, but, in case there is anything else I can/shall do, let me know!
Michael

@goenning: Shouldn't we switch the typed-pg-module to use the declare syntax as well?
Also, shouldn't:
export class Pool extends PgPool
{

}

better be sth. like:
export {PgPool as Pool} from "pg-pool"

@0815fox after an extensive battle with circular dependencies, I think I managed to get it working. I'll close this issue for now
Feel free to send any PR to improve it 👍


Add media files in a specific folder

Currently, we can only add media files at the root folder of each media collection, and not a sub folder. We should allow to specify the location

Is this possible right now? I'm having this exact issue and couldn't find how to add a file to a specific folder.


Allow for VEX to change in a collection

From slack (Thomas Grininger):
TEA Collection objects should only be updated to correct mistakes, spelling errors and similar things.
Specifically in the case of dynamic artifacts such as VEX I expect it to be rather common for updates to happen. E.g. when a new vulnerability is discovered one might always issue a VEX statement first with status under_investigation which at a later point in time might be changed to not_affected or affected .
Am I misinterpreting something or is the description of the TEA Collection Object currently not taking into account that this may be common and expected behavior for some artifact types to be adapted regularly even if the product version stays the same?

Make sure that VEX updates are documented

Related to #73

This is already fixed in merge request


46-height-selector

Expected Differences
The purpose of the height/pressure level selector should be more clear to the user.
Pull Request Testing
The code is deployed to the website.  Test it on a variety of devices and browser window sizes.
Pull Request Checklist

[x] Review the source issue metadata (labels, project, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

Closes #46

Good catch...I had to reverse the order of the array of pressure levels, and left the default value as index 0.  I have updated the code to default to the last index of the array, so that we use the lowest pressure level (1000 mb).  Changes are deployed.

@hahnd - Hmm, I'm still seeing the same default behavior. When I select a wrf job, then once the forecast viewer loads I select 3D temp, the vertical selector starts at 100mb with no data displayed. Same behavior for other 3D fields too. I looked at the WI run and the "short test" caribbean run.

Maybe clear your browser cache.  It’s working for me.

On Mar 26, 2023, at 20:31, Kate Fossell @.***> wrote:

@hahnd - Hmm, I'm still seeing the same default behavior. When I select a wrf job, then once the forecast viewer loads I select 3D temp, the vertical selector starts at 100mb with no data displayed. Same behavior for other 3D fields too. I looked at the WI run and the "short test" caribbean run.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


issue received when upload app to App Store

Godot version:
3.2.4 beta6

OS/device including version:

Issue description:

after submit to App Store, an email about an issue is received:
ITMS-90078: Missing Push Notification Entitlement - Your app appears to register with the Apple Push Notification service, but the app signature's entitlements do not include the 'aps-environment' entitlement. If your app uses the Apple Push Notification service, make sure your App ID is enabled for Push Notification in the Provisioning Portal, and resubmit after signing your app with a Distribution provisioning profile that includes the 'aps-environment' entitlement. Xcode does not automatically copy the aps-environment entitlement from provisioning profiles at build time. This behavior is intentional. To use this entitlement, either enable Push Notifications in the project editor's Capabilities pane, or manually add the entitlement to your entitlements file. For more information, see https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/HandlingRemoteNotifications.html#//apple_ref/doc/uid/TP40008194-CH6-SW1.
That's caused by the methods for push notifications added in beta6 such as:
didReceiveRemoteNotification
My app Do not use push notifications and the push notifications is not checked when export the project.
Steps to reproduce:
Minimal reproduction project:

cc @naithar

cc @naithar

@alexzheng this message should be simply a warning so it shouldn't block you from sending an app to review. Do you get this message while uploading the application or when you send an app to the actual review process? I didn't have an issue with updating a project with this feature.
If that's a critical issue for you - enabling Push Notifications entitlements in Capabilities section should be enough to pass the app store check. It wouldn't force you to do anything related to APNS.
I'll look into a ways to silence this warnings.

@alexzheng this message should be simply a warning so it shouldn't block you from sending an app to review. Do you get this message while uploading the application or when you send an app to the actual review process? I didn't have an issue with updating a project with this feature.
If that's a critical issue for you - enabling Push Notifications entitlements in Capabilities section should be enough to pass the app store check. It wouldn't force you to do anything related to APNS.
I'll look into a ways to silence this warnings.

Yes, this is just a warning to info you fix this issue on your next submit.
It happens when uploading the application.
Also there is a waning in Xcode:
You've implemented -[ application:didReceiveRemoteNotification:fetchCompletionHandler:], but you still need to add "remote-notification" to the list of your supported UIBackgroundModes in your Info.plist.
I can fix this issue simply by remove these methods add in beta6 for my situation since I do not need push.
But it would be better it can be removed when the Push Notifications is not checked when export.

Yes, this is just a warning to info you fix this issue on your next submit.
It happens when uploading the application.
Also there is a waning in Xcode:
You've implemented -[ application:didReceiveRemoteNotification:fetchCompletionHandler:], but you still need to add "remote-notification" to the list of your supported UIBackgroundModes in your Info.plist.
I can fix this issue simply by remove these methods add in beta6 for my situation since I do not need push.
But it would be better it can be removed when the Push Notifications is not checked when export.

Yes, this is just a warning to info you fix this issue on your next submit.

Not really, it's just an automatically generated message that comes from source analyzers. But I do understand that it's bothering you. :)

I can fix this issue simply by remove these methods add in beta6 for my situation since I do not need push.
But it would be better it can be removed when the Push Notifications is not checked when export.

Yeah, but the intention for adding a Pluggable App Delegates was to make integration of custom AppDelegate code easier, so it wouldn't require you to edit the source code.
I'll look into a ways to conditionally enable the method, hopefully there is a way for it without recompiling the source.

Yes, this is just a warning to info you fix this issue on your next submit.

Not really, it's just an automatically generated message that comes from source analyzers. But I do understand that it's bothering you. :)

I can fix this issue simply by remove these methods add in beta6 for my situation since I do not need push.
But it would be better it can be removed when the Push Notifications is not checked when export.

Yeah, but the intention for adding a Pluggable App Delegates was to make integration of custom AppDelegate code easier, so it wouldn't require you to edit the source code.
I'll look into a ways to conditionally enable the method, hopefully there is a way for it without recompiling the source.

I'll look into a ways to conditionally enable the method, hopefully there is a way for it without recompiling the source.

yeah, that's great.

I'll look into a ways to conditionally enable the method, hopefully there is a way for it without recompiling the source.

yeah, that's great.

@naithar
Define these methods in a macro still can not stop the waining email.

It seems any strings match these methods would trigger that waining.


Fragment is recreated after permission confirming

I implemented this library to my project and now I'm trying to use it in fragment to get camera permission.
Expected behaviour
After confirming I want to start camera fragment withaout application re-creation.
Actual behaviour
After confirming I return to last state of application.
I tried to override the onRequestPermissionsResult method, but in this method I receive the GRANTED value (i.e. 0) in any cases (independently I click on cancel or ok button in permission dialog).
Version of the library
last version (5.0.0)

@Papashkin Hi,
Can you resolve this problem ?

Maybe add a small delay time before doing something.

@Papashkin can you create a small project reproducing this issue so we can use it as a playground to see what's going on? Thank you in advance 😃

I'm having the same problem. In Fragment, I use Dexter to ask for permissions, and for test I don't do anything in onPermissionGranted.  Still, the fragment closes.

Hello!
This issue is no longer relevant anymore.
You can close this issue.


Indication of new items in client

It would be nice if the web client indicated when there was a new feed item. In Miniflux 1.2, when a new item was found by the cronjob, Firefox would highlight the Miniflux tab to indicate it had changed. A desktop notification would be another option. I usually keep Miniflux open in a pinned tab, and with Miniflux 1.2 I would never look at it unless it indicated there was new content.

Anyone interested in this feature should look at the Miniflux Notifications and Miniflux Checker browser extensions for Chrome and Firefox. They both provide notifications of new feed items through the browser. I am going to close this issue since these add-ons provide the requested functionality. fguillot can re-open if it seems worth building this feature into Miniflux rather than leaving it to an external project.

Miniflux Notifications (Google Play, GitHub)
Miniflux Checker (Firefox Add-ons, GitHub).

Disclaimer: I wrote Miniflux Checker because I wanted this feature and I didn't know Miniflux Notifications existed (part of my motivation for posting here -- so no one else makes this mistake).


how to give the permission for product variants option for partner Limited dashboard access( partner)

I want to add product variants option for partner Limited dashboard access( partner)

by default it is not available for Limited dashboard access user .
please guide me the best way to do this

Please use the mailing list for help with customising your Oscar store.


data type datetime is displayed as gibberish

MSSQL datetime data 2023-06-06 00:00:00.000 shows as  �

What is the exact mssql type of the datetime you are selecting ?
SQL Server has many datetime types

The mssql data type was datetime
'''sql
select count(*) as Y, cast(invoice_date as datetime) as X
from AMTV2.SPIRE_SALES_HISTORY_ITEMS
group by  invoice_date
'''

Okay. I implemented support for datetime in the latest sqlx-oldapi. But datetime is deprecated, you should use datetime2 or datetimeoffset.

Okay, the bug was actually in SQLPage. Working on it!

I updated the title because the issue was not specific to mssql. It'll be fixed in the next version.

Fixed in https://github.com/lovasoa/SQLpage/releases/tag/v0.9.2


Ad customization docs

While the docs themselves are a work in progress, I would like a public link to point to for the few people making these customizations.
Relates to #4647

It seems that we only have documentation for Sphinx. Isn't this possible in MkDocs yet? Do we care about it? :)

Not yet I'd say. It's definitely a work in progress but in general it will be similar. Override some of the templates and add the div with the appropriate ID.


How to download KsponSpeech dataset on AIHhub net?

I cant download KsponSpeech dataset on AIHhub net. Can you teach me how to download, thanks!

It occurred an error when I used LibriSpeech dataset to train. That is my error and command:


train_causal shouldnt require hf

just a minor change to imports
Stack from ghstack (oldest at bottom):

-> #247

/land

/land


enum generated as model

Describe the bug
Response model has enum and generator identify it like model
To Reproduce
"SomeResponse": {
        "type": "object",
        "properties": {
          "id": {
            "type": "string",
            "format": "uuid"
          },
          "name": {
            "type": "string",
            "nullable": true
          },
          "status": {
            "$ref": "#/components/schemas/SomeStatus"
          },
          "telegramBotId": {
            "type": "string",
            "format": "uuid"
          }
        },
        "additionalProperties": false
      },
      "SomeStatus": {
        "enum": [
          0,
          1,
          2
        ],
        "type": "integer",
        "format": "int32"
      },

Expected behavior
in generated model created enum SomeStatus
Additional context
Backend use minimal api

Hi,
i don't see property x-enumNames in Enum. Can you please add it. I guess it will help you

Yes, that's work, Thanks, can you add this inforamtion to README file please.


List of pages that needs to be converted to new UI

@Unknwon since there have been some Issues regarding pages that have not been converted to the new UI, I thought I'd make a list of sites that still need work. So people can see that you are still working on it. I hope you're OK with this.

[ ] Admin-Panel -> Configuration
[ ] Organization -> Main Page
[ ] Organization -> Member Page
[ ] Organization -> Member Page -> Invitations
[ ] Organization -> Teams Page
[ ] Organization -> Teams Page -> Create Team
[ ] Organization -> Teams Page -> Team Overview
[ ] Organization -> Teams Page -> Teams Settings

Thanks your list.
But please report this to https://github.com/gogits/gogs/issues/650

Man I mus be blind.... :sob:

:trollface: https://trello.com/c/aDv3sA7D/567-all-pages-use-semantic-ui


es6 modules - problems with circular dependencies

Hi all
this is my firts post
I'm having problems with circular dependencies
Microsoft Edge 39.15002.1001.0
Microsoft EdgeHTML 15.15002
Version 1607
Build SO 15002.1001
What is the right forum for edge support?
Could it be here?
If not, sorry!
If yes, could I send link from pastebindotcom with sample code?
Thank you very much

Hi @delmarwichnieski - welcome to the ChakraCore repo! It's not clear what your issue is so feel free to post a link to your sample code and we can give guidance.
For future reference, if it's a JavaScript/Chakra issue, then this is the right forum. If it's an issue with Edge itself, you can follow the instructions here to file Edge issues.

Sorry, the code is in pt-br. But the important parts are easy to understand.
index.html
http://pastebin.com/ZcfazmPB
main.js
http://pastebin.com/9Fp4fpUk
login.js
http://pastebin.com/FgcMC4TY
login.escola.js
http://pastebin.com/LiKQ5m5m
login.utils.js
http://pastebin.com/ukAT8aaM
ajax.js
http://pastebin.com/JZmapfeU
The problem occurs when I uncomment the 3rd line in the login.escola.js file.
If commented, everything is working perfectly.

If uncommented, no js file is loaded.

@boingoing @bterlson can one of you take a quick peek at this issue please?

@delmarwichnieski do you see any errors in the console?

@bterlson There are no errors in the console. I will test in 15007 and I will come back with new status.

same issue with build 15007.

@delmarwichnieski would it be possible to get a .zip of the repro? Email me (see my profile) or join us on gitter...

@bterlson I sent to your email.
I'm running with Apache Lounge 2.4.25 x64 VC14 e PHP 7.1.0 x64 TS
Apache and php are working perfectly.
The php code is ok although it is not POO.
From the server comes JSON only.
This project is SPA, with fetch API, modules and template strings / template literals.
Everything is ok, the only problem is the circular reference between the modules.
When programming the first circular reference, no js file is loaded.

This week, I will test build 15014 and also the new SystemJS 0.20.0 / es-module-loader 2.0.0 release at the same code, to see if I get any errors.

I'm happy to announce that the code is working with SystemJS 0.20.0 and the plugin-babel 0.0.19. No erros in console.

The same problem with
Microsoft EdgeHTML 15.15031
Microsoft Edge 40.15031.0.0

@suwc Is this fixed?

@boingoing this looks duplicate to what has been fixed in https://github.com/Microsoft/ChakraCore/pull/2822

@digitalinfinity yes, I will have to find out about that once I can confirm.

@boingoing @digitalinfinity
I confirmed this has been fixed in our internal staging branch 16189.1002.170512-2143 (Microsoft Edge 41.16189.1002.0).
But 16199.rs_prerelease.17513-2252 (Microsoft Edge 41.16199.1000.0) doesn't contain the fix.
In other words, it may not be in flight yet.

@boingoing @bterlson @suwc  @digitalinfinity
An additional test that could be predicted, is the use of repeated circular imports, due to reuse.
es-module-crash.zip
Similar to attachment

@suwc @bterlson @boingoing  16215.1000 contains the fix?

@delmarwichnieski I will try it and get back to you.

@delmarwichnieski, This is fixed in 16215.rs_prerelease.170603-1840 (Microsoft Edge 41.16215.1000.0, Microsoft EdgeHTML 15.16215).
(Also es-module-crash.zip posted above has been tested and no repro after fix)

Fixed in https://github.com/Microsoft/ChakraCore/pull/2822


incorrect gene_bed format

Description of the bug
My RNA-seq datasets were captured by TrueSeq ranther than by PolyA, so I set parameter --gene_bed manually. The TrueSeq bed only has 4 columns:
browser position chr1:14695-14814
track name="Covered" description="Agilent SureSelect DNA - SureSelectXT Human All Exon V8 - Genomic regions covered by probes" color=0,0,128 db=hg19
chr1    14694   14814   ref|WASH7P,ref|NR_024540,ens|ENST00000438504,ens|ENST00000538476,ens|ENST00000488147,ens|ENST00000541675,ens|ENST00000423562
chr1    14928   15048   ref|WASH7P,ref|NR_024540,ens|ENST00000438504,ens|ENST00000538476,ens|ENST00000488147,ens|ENST00000541675,ens|ENST00000423562
chr1    15752   15948   ref|WASH7P,ref|NR_024540,ens|ENST00000538476,ens|ENST00000438504,ens|ENST00000488147,ens|ENST00000541675,ens|ENST00000423562
chr1    16603   17068   ref|WASH7P,ref|NR_024540,ens|ENST00000538476,ens|ENST00000438504,ens|ENST00000488147,ens|ENST00000541675,ens|ENST00000423562
chr1    17235   17421   ref|WASH7P,ref|NR_024540,ens|ENST00000488147,ens|ENST00000438504,ens|ENST00000538476,ens|ENST00000541675,ens|ENST00000423562,miRNA|hsa-miR-6859-3p
chr1    17604   17724   ref|WASH7P,ref|NR_024540,ens|ENST00000488147,ens|ENST00000438504,ens|ENST00000538476,ens|ENST00000541675,ens|ENST00000423562
chr1    17893   18097   ref|WASH7P,ref|NR_024540,ens|ENST00000488147,ens|ENST00000438504,ens|ENST00000538476,ens|ENST00000541675,ens|ENST00000423562
chr1    18250   18390   ref|WASH7P,ref|NR_024540,ens|ENST00000488147,ens|ENST00000538476,ens|ENST00000438504,ens|ENST00000541675,ens|ENST00000423562
chr1    24768   24888   ref|WASH7P,ref|NR_024540,ens|ENST00000488147,ens|ENST00000538476,ens|ENST00000438504,ens|ENST00000541675,ens|ENST00000423562
chr1    65467   65587   -
chr1    69028   69630   ref|OR4F5,ref|NM_001005484,ens|ENST00000335137,ccds|CCDS30547
chr1    69674   70013   ref|OR4F5,ref|NM_001005484,ens|ENST00000335137,ccds|CCDS30547
chr1    129155  129273  ens|ENST00000453576
chr1    173732  173852  ens|ENST00000466557
chr1    334078  334304  ens|ENST00000455207,ens|ENST00000431812,ens|ENST00000455464,ens|ENST00000601814,ens|ENST00000445840
chr1    367681  368620  ref|OR4F3,ref|OR4F29,ref|OR4F16,ref|NM_001005221,ref|NM_001005224,ref|NM_001005277,ens|ENST00000455207,ens|ENST00000426406

Error occured when I run until RSEQC_READDISTRIBUTION  step:
-[nf-core/rnaseq] Pipeline completed with errors-
ERROR ~ Error executing process > 'NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_READDISTRIBUTION (GM1004CT)'

Caused by:
  Process `NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_READDISTRIBUTION (GM1004CT)` terminated with an error exit status (1)

Command executed:

  read_distribution.py \
      -i GM1004CT.markdup.sorted.bam \
      -r S33266436_Covered.bed \
      > GM1004CT.read_distribution.txt

  cat <<-END_VERSIONS > versions.yml
  "NFCORE_RNASEQ:RNASEQ:BAM_RSEQC:RSEQC_READDISTRIBUTION":
      rseqc: $(read_distribution.py --version | sed -e "s/read_distribution.py //g")
  END_VERSIONS

Command exit status:
  1

Command output:
  (empty)

Command error:
  WARNING: Skipping mount /var/lib/singularity/mnt/session/etc/resolv.conf [files]: /etc/resolv.conf doesn't exist in container
  processing S33266436_Covered.bed ... Traceback (most recent call last):
    File "/usr/local/bin/read_distribution.py", line 302, in <module>
      main()
    File "/usr/local/bin/read_distribution.py", line 191, in main
      intergenic_down1kb_base,intergenic_down5kb_base,intergenic_down10kb_base) = process_gene_model(options.ref_gene_model)
    File "/usr/local/bin/read_distribution.py", line 75, in process_gene_model
      utr_3 = obj.getUTR(utr=3)
    File "/usr/local/lib/python3.7/site-packages/qcmodule/BED.py", line 430, in getUTR
      strand=fields[5]
  IndexError: list index out of range

By default, ranseq pipeline will generate gene_bed from gtf file. The required bed format seems like BED6/BED12.Corresponding value of fields[5] is strand info(+/-).
So how can I change the bed format?
Command used and terminal output
No response
Relevant files
No response
System information
No response

@zhouzhendiao Thank you for reaching out and providing detailed information regarding the issue you've encountered with the nf-core RNA-seq pipeline. It seems that there is a format incompatibility with the BED file you are using.
The error message you are seeing is indicative of a mismatch between the expected input format for the read_distribution.py script and the format of your BED file. The script is expecting a BED file with at least six columns, where the sixth column contains strand information (either '+' or '-'). However, your BED file seems to have only four columns and does not include strand information, which is why the script fails with an IndexError.
The nf-core RNA-seq pipeline typically requires a BED6 or BED12 format for accurate processing, where:

BED6 includes columns for chromosome, start position, end position, name, score, and strand.
BED12 includes additional fields for block sizes and starts.

To resolve this issue, you will need to convert your 4-column BED file into a BED6 or BED12 format. This involves adding two additional columns for the score and strand. The score can often be set to a default value (such as 0 or .) if not used, and the strand can be set to +, -, or . if the strand information is not available.
Here is an example of how to format a BED6 file from your existing data:
chr1    14694   14814   ref|WASH7P    0   +
chr1    14928   15048   ref|WASH7P    0   +
...

Please ensure that the strand information (+/-) is accurate for your data. If you do not have this information, you may use . as a placeholder, but be aware that this might affect downstream analysis that is strand-specific.
If you require assistance with converting your BED file to the appropriate format, there are tools available that can help automate this process, such as awk for command-line text processing or more specialized bioinformatics tools.
Once you have a correctly formatted BED file, you should be able to rerun the pipeline without encountering the previous error.
Since this is unrelated to the functionality of this pipeline I'm closing the issue. Good luck with your project.

Hi @pinin4fjords ,
Thanks for your detailed tutorial!


when i am commented out dynamic param, the value keeps as the Previous setting

the nebula cluster , metad's config v defalt value is 0.
when i kubectl -n nebula edit nc nebulav,  and set metad's config v=1 , then the value in metad container is 1.
when i am commented it out by kubectl -n nebula edit nc nebulav, then the value in metad container's keeps 1.
i think if should change to the default value 0.
i do  as follows:

check the metad container:

operator的日志：
I0220 03:50:58.009144       1 workload.go:122] workload StatefulSet nebula/nebulav-metad updated successfully
I0220 03:50:58.072739       1 helper.go:238] dynamic flags: map[v:1]
I0220 03:50:58.156165       1 helper.go:238] dynamic flags: map[v:3]
I0220 03:51:00.051229       1 nebula_cluster_controller.go:174] Start to reconcile NebulaCluster
I0220 03:51:00.852325       1 nebulacluster.go:129] NebulaCluster [nebula/nebulav] status updated successfully
I0220 03:51:00.852352       1 nebula_cluster_controller.go:159] Finished reconciling NebulaCluster [nebula/nebulav], spendTime: (2.899363468s)

Your Environments (required)
operator镜像：reg.vesoft-inc.com/cloud-dev/nebula-operator:snap-1.35
Expected behavior
in container it should keep default value 0.

checked with snap-1.35，has resolved.
when commented the param, it set value as default value.


How to solve the "checksum" error when using "withRouter()" method on SSR

I used the withRouter() to solve the problem of push() method doesn't update route. With the withRouter() I can make the route updated with redux container. But there's one little problem is that when I using the withRouter() with SSR, it will occur the checksum error between client and server side as below, does any suggest to solve this problem?
Here is how I set up the withRouter():
export default withRouter(connect(mapStateToProps, mapDispatchToProps)(Component))

Here is the problem:

withRouter shouldn't render any HTML itself. How you are you using ReactDOM.renderToString()? That shouldn't happen.

@timdorr Here's is my final settings of client and server side, by that the push() method works
but the chunksum error still exist :

client.js :
// ...

const renderApp = () => {
  const nonBlockingRouter = withRouter(BrowserRouter);

  render(
    <AppContainer>
      <Provider store={store}>
        <ConnectedRouter history={history}>
          <nonBlockingRouter>
            <App />
          </nonBlockingRouter>
        </ConnectedRouter>
      </Provider>
    </AppContainer>,
    document.getElementById('react-view'),
  );
};

// ...

server.js :
// ...

const routerContext = {};
const htmlContent = renderToString(
  <Provider store={store}>
    <StaticRouter location={req.url} context={routerContext}>
      <App />
    </StaticRouter>
  </Provider>,
);

// ...

I found if I remove the <BrowserRouter> from client side, everything works great, the push() method works no need withRouter() and the chunksum error solved. Because there's no document about react-router-redux with SSR, so I'm wondering is that setting correct?
The client.js works :
// ...

const renderApp = () => {
  render(
    <AppContainer>
      <Provider store={store}>
        <ConnectedRouter history={history}>
            <App />
        </ConnectedRouter>
      </Provider>
    </AppContainer>,
    document.getElementById('react-view'),
  );
};

// ...

Well, you've got different trees on the client and the server, which is the crux of the issue. You need to implement the same tree on both sides for it to work. That's up to you, not this library.

@timdorr If I use the react-router-redux, should the BrowserRouter need to be instead by ConnectedRouter or I need to keep both?

You don't want two Router components in there. They both use <Router> under the hood and the inner one will override whatever history you set for <ConnectedRouter>.

@timdorr Cool, thanks a lot.


OAuth2Authenticator.RequestRefreshTokenAsync could raise the Error event?

The OAuth2Autheticator.RequestRefreshTokenAsync method currently throws an exception if the refresh fails. This is different behavior than the initial authentication/authorization flow that raises the Error event.
We could modify the code to raise the Error event? This would be an interface change; however, it would make the interface more consistent so it might be worth doing. It is easier to learn if we can say "errors are always reported via the Error event" rather than "sometimes errors are reported via the Error event and sometimes it throws exceptions".
Here's a possibility for an updated implementation:
public async virtual Task RequestRefreshTokenAsync(string refreshToken)
{
var queryValues = new Dictionary<string, string>
{
{ "refresh_token", refreshToken    },
{ "client_id",     this.ClientId   },
{ "grant_type",    "refresh_token" }
};
        if (!string.IsNullOrEmpty(this.ClientSecret))
        {
            queryValues["client_secret"] = this.ClientSecret;
        }

        try
        {
            var accountProperties = await RequestAccessTokenAsync(queryValues).ConfigureAwait(false);

            this.OnRetrievedAccountProperties(accountProperties);

            return int.Parse(accountProperties["expires_in"]);
        }
        catch (Exception e)
        {
            OnError(e);

            throw; // maybe don't need this? this will throw the exception in order to maintain backward compatibility, but maybe could just return -1 or something instead?
        }
    }

@marktap This code has now changed -> https://github.com/xamarin/Xamarin.Auth/blob/d592c51a6f91aa073f0c1be8a768c464aa6e62a7/source/Extensions/Xamarin.Auth.Extensions.LinkSource/OAuth2AuthenticatorExtensions.cs#L43
The authenticator now handles failed responsed

@newky2k : This issue is still happening in version <IP_ADDRESS>
Please review it once.


[GOBBLIN-1533] Add completeness watermark to iceberg tables

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1533

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
Added a new module "gobblin-completeness" and moved audit count APIs from gobblin-compaction here.
Added KafkaAuditCountVerifier that can be used to compare audit counts regardless of whether its a compaction or ingestion pipeline
Added logic to compute late partition for iceberg data files in IcebergMetadataWriter and logic to update the completeness watermark iceberg table property

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Added test case testWriteAddFileGMCECompleteness to IcebergMetadataWriterTest

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3385 (c611eb4) into master (2b36f27) will decrease coverage by 3.14%.
The diff coverage is 50.31%.

@@             Coverage Diff              @@
##             master    #3385      +/-   ##
============================================
- Coverage     46.42%   43.27%   -3.15%
+ Complexity    10155     1991    -8164
============================================
  Files          2056      398    -1658
  Lines         80102    17103   -62999
  Branches       8950     2109    -6841
============================================
- Hits          37184     7402   -29782
+ Misses        39467     8877   -30590
+ Partials       3451      824    -2627

Impacted Files
Coverage Δ

.../completeness/audit/KafkaAuditCountHttpClient.java
0.00% <0.00%> (ø)

...teness/audit/KafkaAuditCountHttpClientFactory.java
0.00% <0.00%> (ø)

...completeness/verifier/KafkaAuditCountVerifier.java
54.28% <54.28%> (ø)

.../gobblin/iceberg/writer/IcebergMetadataWriter.java
72.28% <87.32%> (+3.48%)
:arrow_up:

...in/java/org/apache/gobblin/cluster/HelixUtils.java
32.23% <0.00%> (-5.79%)
:arrow_down:

...blin/qualitychecker/row/RowLevelErrFileWriter.java

...che/gobblin/metrics/event/FailureEventBuilder.java

...he/gobblin/kafka/serialize/GsonSerializerBase.java

...e/materializer/MaterializeTableQueryGenerator.java

...ion/hive/entities/QueryBasedHivePublishEntity.java

... and 1663 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b36f27...c611eb4. Read the comment docs.


Diff. between Google Analytics

Any thoughts on how Trackomatic differs from Google Analytics' Autotrack feature?
(http://marketingland.com/165873-165873?utm_campaign=socialflow&utm_source=twitter&utm_medium=social)

Thanks Vilav, that's a good question. Although they are both GA plugins (and take configuration parameters), they track slightly different sets of data. There is a little bit of overlap in the way they track outbound links (Trackomatic looks for clicks on files, outbound links, email links, and telephone links, while Autotrack only looks for outbound clicks) and device data (Trackomatic uses browser width and height attributes, while Autotrack uses media queries). We're currently looking into the option of pulling Autotrack code into Trackomatic for features like social media tracking. Are there features in Autotrack that you think would be particularly useful to have in Trackomatic?

@awavering Sorry about the radio silence. I would love for it to support declarative tags to support tracking of specific links, buttons etc.
The social media tracking you referred to would also be a great addition if you can merge these features to build a analytics super plugin!
Thanks!

@awavering any updates on this likely?

Not for the foreseeable future - it ends up being easy enough to do through GTM (with a trigger set up to listen for a data property on the click element) that I'm not sure it's worth pulling into trackomatic.
function() {
	var isSet = function(val) {
		return val !== null && val !== '';
	};
	var el = {{element}};
	var val = el.getAttribute('data-track');

	while (el && el !== document.body && !isSet(val)) {
		el = el.parentElement;
		val = el.getAttribute('data-track');
	}

	return isSet(val) ? val : false;
}


Not directly an issue with the Flow, but:

I cannot get Node-Red to connect to the Grainfather.
from /var/log/daemon.log:
May  3 22:07:13 raspbian-dev Node-RED[373]: 3 May 22:07:13 - [info] [Generic BLE:f77bfd24.43ebf] [subscribe] Peripheral:bba0500b0c1e is NOT ready. state=>disconnected
Do I have to reset the controller in any way?

Got a bit further:
May  3 22:43:24 raspbian-dev Node-RED[2916]: 3 May 22:43:24 - [info] [Generic BLE:b82919c2.aa01b8] [subscribe] Peripheral:bba0500b0c1e is NOT ready. state=>connecting

And suddenly it works..... Beats me why.
But I'm getting a flshing error in the upper right corner on /ui
TypeError: Cannot read property 'stageTitles' of undefined

I have just pushed 465bdf which fixes some issues with initial connection and the 'stageTitles' alert
Looks like it might solve the issue you have reported

Thanks, it did solve it.


SentencePiece

Does it support the vocabulary segmentation trained by SentencePiece?

I have converted the "facebook/m2m100_418M" model, and now it is divided into encoder and decoder. I'm not sure what to do next. Since "facebook/m2m100_418M" does not have a tokenizer.json and uses a SentencePiece tokenizer, I'm a beginner.


Enable remaining analysis rules

avoid_classes_with_only_static_members: I converted StorageManager & SupabaseManager to default instance exports
use_setters_to_change_properties. Just changed the assignment for SupabaseManager setClient and setCurrentProfile. Now please use supabaseManager.currentProfile = ...  and supabaseManager.client = ... . Same for the getters, of course.

I also had to move some code into the initialize method to make sure that "Supabase.instance.client" is not called inside the tests, where it would not have been initialized.
Finally, I renamed the file to include the "Manager" name

https://dart-lang.github.io/linter/lints/avoid_classes_with_only_static_members.html

Creating classes with the sole purpose of providing utility or otherwise static methods is discouraged. Dart allows functions to exist outside of classes for this very reason.

And these get/set methods are basically just unnecessary because Dart already supplies getters/setters for public attributes via the standard syntax


MINOR: JoinGroup and SyncGroup callbacks should catch exceptions

We recently had a bug causing the JoinGroup callback to thrown an exception (https://github.com/apache/kafka/pull/12909). When it happens, the exception is propagated to the caller and the JoinGroup callback is never completed. To make it worst, the member whose callback failed become a zombie because the group coordinator does not expire member with a pending callback.
This patch catch exceptions for both invocation of JoinGroup and SyncGroup callbacks and retry to complete them with a UNKNOWN_SERVER_ERROR error if they failed.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Merged to trunk and 3.3.


DS-3412 Now it checks if the item is on the workflow

if so disable authorisation system, perform the update on the BT and enable it again

As noted in the ticket, I also wonder if this is related to (or fixed by) #1596

Closing because of lack of activity/response. We can reopen later if this still exists.


Not updating GPS Coords

I have found that a Blazor Server App (Scoped Service setting) gets the GPS coords first time, but not for a long time after that. I walk up to about 1K with no change.

.NET 5 C# Blazor Server only app.
Running in Edge Browser on an Android phone
Server is hosted on Azure
If I kill all apps on the phone and restart browser , still get same coords.
Only if I restart the phone do I get an update
An alternative. If I run Google Maps whilst walking and switch between it and browser , GPS coords in browser get updated.

So I conclude there needs to be a trigger to update the GPS coords.

I looked into it further ..
I am getting Dispatch called when I request an updated location but
navigator.geolocation.getCurrentPosition(function (position)
is not getting updated position, just the previous one.
PS I inserted alter messages in location.js to establish this.

I looked into it further ..
I am getting Dispatch called when I request an updated location but
navigator.geolocation.getCurrentPosition(function (position)
is not getting updated position, just the previous one.
PS I inserted alter messages in location.js to establish this.


Multiline error messages are not displayed to the user

The vscode.window.showErrorMessage api can only handle one line at a time.
@nturinski and I discussed a possible solution. We could detect if the error message contains a new line and display something generic like "The operation failed - check the output window for more details" and then print the error to the output window

I'm fine holding off on this until after 0.3.0


[BUG]: Deleting datadir/chain directory to force replay doesn't reindex meta store

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
Deleting datadir/chain and restarting does not send metastore notifications for the blocks.
Expected behavior
As a node operator, I want to re-process and replay events generated by blocks I have already downloaded, so those events can be consumed by contract meta store (or some other microservice that wants to custom index the chain).
In Hive, I could achieve this by implementing / enabling a plugin that has some custom block processing logic that creates some custom state objects.  Then run with --replay-blockchain and the state database will be deleted and rebuilt; plugins will "see" transaction / block notifications for the already-downloaded blocks, and thus rebuild their part of the database as they would have if I had operated them while downloading the blocks.
In Koinos, the contract meta store microservice is the equivalent of such a plugin, and rm -Rf datadir/chain is the equivalent of --replay-blockchain.  However, I observed that the microservice does not properly update for the replayed blocks.
Steps to reproduce
I ran without --profile=all and then I realized that I wanted metastore data for smart contracts.
Then I did docker-compose down && rm -Rf datadir/chain && docker-compose up thinking the resulting replay would resend the events to the metastore, but it did not.
Environment
- OS: Ubuntu 22.04

Anything else?
Some maybe useful log messages produced while reindexing:
block_producer_1       | 2022-08-26 20:35:50.056312 (block_producer.Koinos) [client.cpp:437] <warning>: No response to client request with correlation ID: njKQbMkPTBwwrMnxLLr5vfvBtN5p0pzn, within 8000ms
chain_1                | 2022-08-26 20:35:56.859012 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (1.07799%) - Height: 1000, ID: 0x1220759bd8a876119f20cf915964bab63444a6bb1e21024b8807442ef9ad59d74ff8
p2p_1                  | 2022-08-26 20:35:59.056802 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:274] <warn>: RPC error: context deadline exceeded
p2p_1                  | 2022-08-26 20:35:59.056848 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:275] <warn>: Trying again in 16 seconds
block_producer_1       | 2022-08-26 20:36:06.057639 (block_producer.Koinos) [client.cpp:437] <warning>: No response to client request with correlation ID: iTyWd7NkoRqqMlMIPbMDobQAW7RA2ddi, within 16000ms
p2p_1                  | 2022-08-26 20:36:16.058066 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:274] <warn>: RPC error: context deadline exceeded
p2p_1                  | 2022-08-26 20:36:16.058112 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:275] <warn>: Trying again in 30 seconds
chain_1                | 2022-08-26 20:36:16.706804 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (2.15599%) - Height: 2000, ID: 0x12200df6ebab8883e65aa5d39af073cf7101ed9e8c9f8e949e064ba3bbffd41d0c54
block_producer_1       | 2022-08-26 20:36:36.057936 (block_producer.Koinos) [client.cpp:437] <warning>: No response to client request with correlation ID: eOZ9j3yE0orfqQFUzoW7XQBPpFQThx6j, within 30000ms
chain_1                | 2022-08-26 20:36:36.745174 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (3.23398%) - Height: 3000, ID: 0x122090f984f39fb451ed0842abc0e32aa352d1c370c61041e544c65bb8a7e2ced2b9
p2p_1                  | 2022-08-26 20:36:47.059443 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:274] <warn>: RPC error: context deadline exceeded
p2p_1                  | 2022-08-26 20:36:47.065766 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:275] <warn>: Trying again in 30 seconds
chain_1                | 2022-08-26 20:36:56.373626 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (4.31197%) - Height: 4000, ID: 0x1220ead01eaf4d6c17682b2c41bc7df1ef1150a09fb337a87386db3bac77cac24d6d
block_producer_1       | 2022-08-26 20:37:06.058700 (block_producer.Koinos) [client.cpp:437] <warning>: No response to client request with correlation ID: WP0wlxBWwHwhJA6BGlMgak4ykXs0Hsdt, within 30000ms
chain_1                | 2022-08-26 20:37:15.888069 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (5.38996%) - Height: 5000, ID: 0x12201ca7fdc8e5961932fdb36dadb36488802e5bdeb4f772b796effb395d0f003bf5
p2p_1                  | 2022-08-26 20:37:18.067275 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:274] <warn>: RPC error: context deadline exceeded
p2p_1                  | 2022-08-26 20:37:18.067331 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:275] <warn>: Trying again in 30 seconds
chain_1                | 2022-08-26 20:37:35.809583 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (6.46796%) - Height: 6000, ID: 0x1220cb779e88b1bf53135969286812eabf5538c24988cc95683d956851486417e224
block_producer_1       | 2022-08-26 20:37:36.059133 (block_producer.Koinos) [client.cpp:437] <warning>: No response to client request with correlation ID: EEe9A4LvTe7nugjwOXKFeuaITO3ypwQQ, within 30000ms
p2p_1                  | 2022-08-26 20:37:49.067520 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:274] <warn>: RPC error: context deadline exceeded
p2p_1                  | 2022-08-26 20:37:49.067587 (p2p.Koinos) [koinos-mq-golang@v0.0.0-20220824200525-0230763309f3/client.go:275] <warn>: Trying again in 30 seconds
chain_1                | 2022-08-26 20:37:55.230731 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (7.54595%) - Height: 7000, ID: 0x12203796de2f628f8065d1732b2496cf61c0994a667af26d6c9be6362c83fbebde3b
block_producer_1       | 2022-08-26 20:38:06.060648 (block_producer.Koinos) [client.cpp:437] <warning>: No response to client request with correlation ID: 0KtHKGA8EA0Ve0hFwCPS6GoyNozCLybp, within 30000ms
chain_1                | 2022-08-26 20:38:15.381302 (chain.Koinos) [controller.cpp:366] <info>: Indexing chain (8.62394%) - Height: 8000, ID: 0x1220fe610496425ae050f7a9d09702cbb422f59553c44bcdfccf3ef07677f8d30099

This issue is stale because it has been open for 30 days with no activity.

This issue was closed because it has been inactive for 14 days since being marked as stale.


About the date display of report. #1310

I'm troubled. How do you solve this problem.
I suggested before. #1310
I fork and verified the repository to see how this should be resolved. And I found a way to solve this problem.
<IP_ADDRESS> - - [07/Mar/2019:01:48:21 +0900] "GET /timelines/62583497 HTTP/1.1" 200 109 "/user/kamino" "Mozilla/5.0 (Windows NT 6.0) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.56 Safari/535.11"

This is a part of the log recorded in the Combined format, but I was able to confirm that the date and time are in British expression.
Which source code should I change to convert this to RFC3339 format? (I think that the get_visitors_date function in util.c is doubtful)

Once this issue is resolved, I start to new issue proposing a change from "MIT" to "Apache License 2.0"
The contributors' rights will be clarified, the opportunities used by corporations will increase and the load (to solve problems) will be dispersed.

Just so I understand, are you trying to parse this specific format [07/Mar/2019:01:48:21 +0900] or  display  it in different format?

Parser don't modify. I will convert internal data and make it compliant with RFC3339 format.

To answer your question, yes, you are probably looking at get_visitors_date which should take care of the displaying of the parsed dates.

Thx! If conversion to RFC3339 format is successful, send PR.


dateFormat not working correctly with onChange action

Related to #125
Demo app: https://github.com/lytics/flatpickr-demo-app
I closed that issue because it didn't describe the problem correctly.
This works
{{ember-flatpickr
  value=dateValue
  onChange=null
  dateFormat="m/d/Y"}}

The date is formatted correctly
I expected this to work, but it doesn't
{{ember-flatpickr
  value=(readonly dateValue2)
  onChange=(action (mut dateValue2))
  dateFormat="m/d/Y"}}

The date is unformatted
I created an app demoing this, the most salient part of which can be found here

Twiddle showing the behaviour (strange dateFormats only to double check we're not using any defaults)
The reason for the unformatted date in the latter example is that ember-flatpickr onChange simply passes the flatpickr onChange arguments to the given action.
flatpickr onChange arguments are:

an array of JS Date
a string formatted accordingly to dateFormat with the latest selected date
the flatpickr instance

(action (mut dateValue2)) thus sets dateValue2 to the first passed argument, which is the array of JS Date, so dateValue2 becomes an array of JS Date and {{dateValue2}} prints the array, without any formatting as JS Date doesn't have any information about the formatting.
By not using readonly+onChange we let flatpickr handle the value, which goes against the ddau pattern, so using readonly allows to use that pattern.
We could change the order of ember-flatpickr onChange arguments, so that instead of dateObjs, dateStr, instance we have dateStr, dateObjs, instance thus onChange=(action (mut value)) works as expected, but this means that we have a slight difference from flatpickr API, which may be cause of oversight.
Personally I prefer working with JS Date instead of String containing dates, so what I'm using is a wrapper which ensures I'm using readonly in value property and onChange returns the first element of  the array so that I can use:
{{ember-flatpickr-wrapper
value=value
onChange=(action (mut value))
altInput=true
altFormat="d/m/Y"}}

and value is always a JSDate which I may or may not format.
altInput and altFormat allows flatpickr to display a custom format date, without altering what I expect as value type.

Thanks for that clarification @staskij! @humanchimp with this in mind, can we close the issue?

To me, it seems fairly unergonomic to require a wrapper in order to use the component in the DDAU paradigm, considering that DDAU is considered a best practice.
I think it's better to change the order of the arguments, since if someone is using this addon they shouldn't be using flatpickr directly. The original argument order seems like an implementation-level detail.
That said, it sounds like that would be a breaking API change, and not appropriate for minor release.
If you guys want to make the design decision to leave the original argument order, then I suppose we can close this issue, although it seems like it would be a good idea to make a note about the argument order in the documentation, since when I encountered this it seemed like a bug.
I would like to suggest that we at least consider the impact of changing the argument order.

@humanchimp it is documented in the README
Whenever a new date is selected, the action onChange will be fired: if you just want the event to set the array of selected dateObject, you can use (action (mut dateValues)) like the example above. Otherwise you should implement you own onChange action.

OK, sorry I missed that. I'll close this issue now


chore: add Prettier as dependency

Using prettier helps with ensuring consistency between everyone (and
also prevents having to rely on pre-commit to fix everything for you)
With this you should be able to run yarn run prettier and also
configure your editor/IDE to use the right settings as well.
I noticed there was already settings in package.json for Prettier, but
no file existed for ignoring artifact folders like build
TODO:

[ ] ‹fill in›

Fixes
Related to
Merge before
#205

RELEASE NOTES BEGIN
Add opinionated code formatter Prettier as a dependency
RELEASE NOTES END

Builds on top of #205 which needs to be merged first

@SpyTec please install pre-commit into the (cloned) repository hooks, thanks

@jpopelka, good point. Done. I also added this to the README under #208


chore(repo): Bump GH actions dependencies due to deprecation warning

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[x] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[x] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Resolves the following deprecation warnings:

It seems that the upgrade also improves the performance of the GH actions. It may be a coincidence or another reason for the difference in execution times, but these 2 runs are from before and after the upgrade but for different PRs.
Before

After

cc: @nikosdouvlis , @SokratisVidros


Towards pylexibank 2.0

See https://github.com/lexibank/diacl/commit/b43368a9d74a0c6640cb1d6929a10f5c4b7204dc
Still working on the code (imports, tqdm, concept lists) but could someone please check the way I handle the forms & whether this makes sense? This uses replacements as proposed in https://github.com/lexibank/pylexibank/issues/142. Specifically:
@attr.s
class FormSpec(object):
    brackets = attr.ib(
        default={"(": ")"},
        validator=attr.validators.instance_of(dict))
    separators = attr.ib(default=";/,")
    missing_data = attr.ib(
        default=('?', '-'),
        validator=attr.validators.instance_of((tuple, list)))
    strip_inside_brackets = attr.ib(
        default=True,
        validator=attr.validators.instance_of(bool))
    replacements = attr.ib(default={}, validator=attr.validators.instance_of(dict))

    def clean(self, form, item=None):
        """
        Called when a row is added to a CLDF dataset.

        :param form:
        :return: None to skip the form, or the cleaned form as string.
        """
        for s, t in sorted(self.replacements.items(), key=lambda x: len(x[0]), reverse=True):
            form = form.replace(s, t)

        if form not in self.missing_data:
            if self.strip_inside_brackets:
                return text.strip_brackets(form, brackets=self.brackets)
            return form

And I put the replacements in FormSpec as proposed by @SimonGreenhill.

But that would require a release of pylexibank 2.0.1, right? Or did you just add this FormSpecCode to the diacl-script?

Sorry, yeah, just modified my local environment/pylexibank until we can talk with @xrotwang next week to see if this makes it into pylexibank proper.

Alright! So you also use a FormOnlySpec there, right? Then you could add the "ffirst_form_only" = True/False attribute there as well, right?

Yup, updated the class definition above. Call is then:
    form_spec = FormSpec(
        separators=";,", strip_inside_brackets=False, replacements=replacements, first_form_only=True
    )

Depends on https://github.com/lexibank/pylexibank/issues/145.

@LinguList I'd aim at releasing pylexibank 2.1 tomorrow - and then do the final releasable runs makecldf.

Yes, this sounds reasonable.

Mapped now with concept lists from Concepticon & new replacements.


Problem: Clearing env vars breaks workflows

Issue
This security fix breaks many legitimate workflows by removing every single environment variable before running a pipeline.
I have several environment variables that I have set that I need to pass on the ansible run. On of them is for instance HTTPS_PROXY, now the pipelines are unable to reach out because this is no longer passed on.
Instead of removing every environment variable, would it be possible to use a user configurarable whitelist?
Impact
Ansible (task execution)
Installation method
Docker
Database
Postgres
Browser
No response
Semaphore Version
2.10.32-f33944e-1729509092
Ansible Version
No response
Logs & errors
No response
Manual installation - system information
No response
Configuration
No response
Additional information
No response

Just coming on to report this as well. We use quite a few ENV vars set in the the docker container running Semaphore, and inventory, and playbooks are no longer working as they require the ENV vars for authentication and configuration.

Reporting as well, closed my own issue #2467 as a duplicate.  Reverting to v2.10.31 resolved the problem.

This breaks for me as well – I have a few environment variables for proxy settings and installing private galaxy roles configured...

https://github.com/semaphoreui/semaphore/pull/2470

Added env vars to config file. PR: #2470
Is is solution the issue?

It would solve the issue, but as commented in the PR by @Omicron7, having a whitelist of environment variables would be preferable.

Could this breaking change be made in a major version?
Also could the path include /bin? (See https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin) and be configurable?

I've had some similar issues as described here, although I'm not convinced they are technically caused by this change, but they are nonetheless undesirable. Like @macau23 mentions, the paths included by Semaphore seems to be to look for executables in :/sbin:/usr/sbin:/usr/local/sbin, which is not typically where they tend to be installed. For example, in the error message below:
fatal: [server01]: FAILED! => {"changed": false, "msg": "Failed to find required executable \"rsync\" in paths: :/sbin:/usr/sbin:/usr/local/sbin"}

... Semaphore is looking in the "wrong" place for rsync. If I run the same playbook from the command line, Ansible properly finds rsync in /usr/bin/rsync, where it indeed is located. So, my conclusion is that this is a Semaphore issue.
By simply putting a symlink in /sbin to /usr/bin/rsync I was able to work around this problem, but I consider that more of a hack/workaround than a real solution.
Again, this might not actually be directly related to this issue, and if so, please let me know. Maybe there's a way to tell Semaphore what the path should be and I just missed it? But, in any case, I think /sbin might not be the best default value. I can also create a new issue to track the behavior I outlined above.

yes that got me as well today.. @mlanner your workaround is not a solution ofc and I did that as well at first (for the git binay) but the problem lays deeper and is discussed in PR: #2470 . it also breaks completely if you use e.g. AWS modules requiring to set a specific PYTHONPATH etc.
so what I used before 2.10.32 was:
[Unit]
Description=Ansible Semaphore
Documentation=https://docs.ansible-semaphore.com/
Wants=network-online.target
After=network-online.target
ConditionPathExists=/usr/bin/semaphore
ConditionPathExists=/etc/semaphore/config.json

[Service]
User=semaphore
Group=semaphore
ExecStart=/usr/bin/semaphore service --config /etc/semaphore/config.json
ExecReload=/bin/kill -HUP $MAINPID
Restart=always
RestartSec=20s
# add path so the executables are found
Environment=PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:~/.local/bin"
# to fix "python module not found" issues, the following WorkingDirectory must point to the same
# directory as ` tmp_path`  variable in your semaphore config.json
# if using non-default ansible.cfg params, it also should contain your `.ansible.cfg` (yes, `dot`ansible.cfg)
WorkingDirectory=/opt/data/semaphore/plays
# besides the WorkingDirectory we need to tell systemd where to find your pip installed libs:
# to find out the user's as $User exec: python -c "import site; print(site.USER_SITE)"
Environment="PYTHONPATH=/home/semaphore/.local/lib/python3.11/site-packages"
# pass environment vars to child processes:
PassEnvironment=PYTHONPATH PATH

[Install]
WantedBy=multi-user.target

downgrading to 2.10.31 "solved" that issue until we found a proper solution.
also (as suggested by @macau23 already) maybe such breaking changes should better happen in a major release?

Please try v2.10.33.
Fixed issue with PATH environment variable.
Added options SEMAPHORE_ENV_VARS and FORWAREDED_ENV_VARS.

Hi @fiftin
I can verify that 2.10.33 using SEMAPHORE_FORWARDED_ENV_VARS works for me, thank you

@fiftin Thank you - SEMAPHORE_FORWARDED_ENV_VARS works perfectly fine for my use case!

Sorry if I'm being dense here, but where should I add the two options SEMAPHORE_ENV_VARS and SEMAPHORE_FORWARDED_ENV_VARS? In a non-Docker environment, I'm assuming into the config.json, like so:
{
   "env_vars": {"SOME_VAR": "test"},
   "forwarded_env_vars": ["VAR1", "VAR2"],
}

And, as an example, VAR1 could be PATH, as discussed here:
https://github.com/semaphoreui/semaphore/pull/2470#issuecomment-2429482407
... ?
Thanks in advance.

Sorry if I'm being dense here, but where should I add the two options SEMAPHORE_ENV_VARS and SEMAPHORE_FORWARDED_ENV_VARS? In a non-Docker environment, I'm assuming into the config.json, like so:
{
   "env_vars": {"SOME_VAR": "test"},
   "forwarded_env_vars": ["VAR1", "VAR2"],
}

Yes, you can add it to config.json as you show. If you run it in a systemd service, you can also set the environment variables in the service if that works better
[Service]
Environment=SEMAPHORE_FORWARDED_ENV_VARS=[\"VAR1\", \"VAR2\"]

And, as an example, VAR1 could be PATH, as discussed here #2470 (comment) ?

https://github.com/semaphoreui/semaphore/commit/77358e3166cfb19d81d6ba2ad9ba9c03377a39b9 which is included in 2.10.34 passes on PATH as is, so with that there is no need to add PATH to forwarded env vars.


PromptCompressor -- Missing Package Accelerate but it is installed

I am trying to run the Retrieval Notebook and when I get an error about accelerate not being installed; however, as you can see from my logs below it is installed
Notebook: https://github.com/microsoft/LLMLingua/blob/main/examples/Retrieval.ipynb
# Setup LLMLingua
from llmlingua import PromptCompressor
llm_lingua = PromptCompressor()

I get the following error
[/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py](https://localhost:8080/#) in from_pretrained(cls, pretrained_model_name_or_path, config, cache_dir, ignore_mismatched_sizes, force_download, local_files_only, token, revision, use_safetensors, *model_args, **kwargs)
   2672                 )
   2673             elif not is_accelerate_available():
-> 2674                 raise ImportError(
   2675                     "Using `low_cpu_mem_usage=True` or a `device_map` requires Accelerate: `pip install accelerate`"
   2676                 )

ImportError: Using `low_cpu_mem_usage=True` or a `device_map` **requires Accelerate: `pip install accelerate`**

---------------------------------------------------------------------------
NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.

To view examples of installing some common dependencies, click the
"Open Examples" button below.

Machine: Colab with I have tried running this on colab with a L4 GPU.
Library Versions: Here are the version of my library.  I did a !pip show
!pip show transformers
!pip show sentence_transformers
!pip show llmlingua
!pip show accelerate
!pip show cohere

Version Output
Name: transformers
Version: 4.35.2
Summary: State-of-the-art Machine Learning for JAX, PyTorch and TensorFlow
Home-page: https://github.com/huggingface/transformers
Author: The Hugging Face team (past and future) with the help of all our contributors (https://github.com/huggingface/transformers/graphs/contributors)
Author-email: [transformers<EMAIL_ADDRESS>License: Apache 2.0 License
Location: /usr/local/lib/python3.10/dist-packages
Requires: filelock, huggingface-hub, numpy, packaging, pyyaml, regex, requests, safetensors, tokenizers, tqdm
Required-by: llmlingua, sentence-transformers
Name: sentence-transformers
Version: 2.3.1
Summary: Multilingual text embeddings
Home-page: https://www.sbert.net/
Author: Nils Reimers
Author-email: [info<EMAIL_ADDRESS>License: Apache License 2.0
Location: /usr/local/lib/python3.10/dist-packages
Requires: huggingface-hub, nltk, numpy, Pillow, scikit-learn, scipy, sentencepiece, torch, tqdm, transformers
Required-by:
Name: llmlingua
Version: 0.1.5
Summary: To speed up LLMs' inference and enhance LLM's perceive of key information, compress the prompt and KV-Cache, which achieves up to 20x compression with minimal performance loss.
Home-page: https://github.com/microsoft/LLMLingua
Author: The LLMLingua team
Author-email: [hjiang<EMAIL_ADDRESS>License: MIT License
Location: /usr/local/lib/python3.10/dist-packages
Requires: nltk, numpy, tiktoken, torch, transformers
Required-by:
Name: accelerate
Version: 0.27.2
Summary: Accelerate
Home-page: https://github.com/huggingface/accelerate
Author: The HuggingFace team
Author-email: [sylvain<EMAIL_ADDRESS>License: Apache
Location: /usr/local/lib/python3.10/dist-packages
Requires: huggingface-hub, numpy, packaging, psutil, pyyaml, safetensors, torch
Required-by:
Name: cohere
Version: 4.47
Summary: Python SDK for the Cohere API
Home-page:
Author: Cohere
Author-email:
License:
Location: /usr/local/lib/python3.10/dist-packages
Requires: aiohttp, backoff, fastavro, importlib_metadata, requests, urllib3
Required-by: llmx

I also can confirm that I have a GPU on the box
import torch
use_cuda = torch.cuda.is_available()

device = torch.device("cuda" if use_cuda else "cpu")
print("Device: ",device)

if use_cuda:
    print('__CUDNN VERSION:', torch.backends.cudnn.version())
    print('__Number CUDA Devices:', torch.cuda.device_count())
    print('__CUDA Device Name:',torch.cuda.get_device_name(0))
    print('__CUDA Device Total Memory [GB]:',torch.cuda.get_device_properties(0).total_memory/1e9)

Output

__CUDNN VERSION: 8902
__Number CUDA Devices: 1
__CUDA Device Name: NVIDIA L4
__CUDA Device Total Memory [GB]: 23.58378496

Is anyone else seeing this?  Does anyone know how to solve this?

Apologies for the delayed response. The issue stems from the 'accelerate' library.
To resolve it, you should restart your session after installing 'accelerate.' For further details, please refer to this solution on Stack Overflow: https://stackoverflow.com/questions/76902752/importerror-using-low-cpu-mem-usage-true-or-a-device-map-requires-accelerat.