[BUG] deepcopy of MLP fails

Describe the bug
When sending a TDmodule to a device (tested with cpu and mps) deepcopy fails.
The following error is raised:
Exception has occurred: TypeError
empty() received an invalid combination of arguments - got (int, dtype=NoneType, device=bool), but expected one of:
 * (tuple of ints size, *, tuple of names names, torch.memory_format memory_format, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)
 * (tuple of SymInts size, *, torch.memory_format memory_format, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)
 * (tuple of ints size, *, torch.memory_format memory_format, Tensor out, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)
  File "/Users/ndufour/Documents/pytorch/rl/examples/dreamer/deepcopy debug", line 32, in <module>
    td_copy = deepcopy(td_module)

To Reproduce
Here is a snippet to reproduce:
from copy import deepcopy
import torch
import torch.nn as nn
from torchrl.modules import TensorDictModule, MLP
mps = torch.device("mps")
cpu = torch.device("cpu")

### No bugs found in this file ###
linear = nn.Linear(10, 10).to(cpu)

td_module = TensorDictModule(
    nn.Sequential(linear),
    in_keys=["x"],
    out_keys=["y"],
).to(cpu)

lin_copy = deepcopy(linear)
td_copy = deepcopy(td_module)

### Bug found in this file ###

td_module = TensorDictModule(
    MLP(out_features=1, depth=3, num_cells=400, activation_class=nn.ELU),
    in_keys=["x"],
    out_keys=["y"],
).to(cpu)

lin_copy = deepcopy(linear)

Expected behavior
Expected behaviour is that deepcopy(MLP) should not prevent doing deepcopy.
Screenshots
If applicable, add screenshots to help explain your problem.
System info
Describe the characteristic of your environment:

Mac OS (M1 Chip)
3.9.12
Pytorch nightly 1.13

Additional context
Add any other context about the problem here.
Reason and Possible fixes
If you know or suspect the reason for this bug, paste the code lines and suggest modifications.
Checklist

[ ] I have checked that there is no similar issue in the repo (required)
[ ] I have read the documentation (required)
[ ] I have provided a minimal working example to reproduce the bug (required)

Actually looking deeper into it,
linear = deepcopy(MLP(out_features=1, depth=3, num_cells=400, activation_class=nn.ELU))

also triggers the bug so. This isn't linked to tdmodule or the device

Yes it's a known issue of lazy modules (see here)
Closing as this is unrealted to torchrl.


couldn't container install identity="" email="" words=""

Was trying container install from 3sdk
seems like words wasn't passed

I did args words val="mywords" the value was passed then

fixed in commit: https://github.com/threefoldtech/jumpscaleX_core/commit/7da53cfdc2948e980024bc7a6f3584bc645945f3

verified.


refactor!: string only for RevalidationType

#499  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


Disable bart onnx export for text-classification and question-answering

PyTorch 2.1 introduced a breaking change in torchscript graph capture that make the export of bart for those tasks fail.
Given that there is probably low usage anyway, let's simply remove the support for it and let's try to get the CI green.
See details: https://github.com/pytorch/pytorch/issues/110597

Now that this has been fixed in pytorch, would it be possible to revert this to get back Bart support ?


nixos/test-driver: shellopts with execute + timeout

Description of changes
In the test-driver, setting the shell opts in the machine.execute() command is inconsistent: When no timeout is used, shellopts set -euo pipefail are applied to the command as expected. When a timeout is specified, the shellopts are not applied to the command itself but rather to the timeout command (because the user command is called inside a sh -c that doesn't inherit the shellopts).
Using the example of pipefail, this leads to the following behavior (all commands succeed):
cmd = "false | true"

machine.fail(cmd)
machine.succeed(cmd, timeout=1)
machine.wait_until_succeeds(cmd) # --> indirectly adds a timeout

Expected behavior would be:
cmd = "false | true"

machine.fail(cmd)
machine.fail(cmd, timeout=1)
machine.wait_until_fails(cmd) # --> indirectly adds a timeout

In addition to the fix in this PR, the documentation has been adapted to clarify that the shellopts are set in every execute call and that the timeout parameter can be used in execute, succeed and wait_until_succeeds as well.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Seems sensible, even if machine.fail is now more likely to pass for "wrong" reasons. Will have to look again later.

Thanks for taking a look.
Most of the existing machine.fails commands don't use a timeout so their behavior is not affected by this change. The tests that use wait_until_fails look fine. (xmonad is not in this list as it doesn't seem to build on master, and chromium and vscodium are excluded)
@ofborg test xmonad sway jenkins zigbee2mqtt pinnwand dovecot docker-registry login mysql-backup rspamd udisks2 tinywl wiki-js turbovnc-headless-server collectd opensmtpd-rspamd opensmtpd cassandra_3_11

@ofborg test nat.firewall networking.scripted.link installer.simpleProvided installer.separateBootFat networking.scripted.virtual printing keymap.azerty keymap.dvorak-programmer boot-stage1 installer.swraid keymap.neo nfs4.simple i3wm udisks2 networking.networkd.loopback containers-ip ecryptfs login installer.simpleLabels php.httpd zfs.installer predictable-interface-names.unpredictable predictable-interface-names.unpredictableNetworkd mutableUsers

@ofborg test pantheon boot.biosCdrom boot.uefiUsb networking.networkd.static latestKernel.login networking.networkd.dhcpSimple networking.networkd.sit env switchTest hibernate predictable-interface-names.predictable gnome networking.networkd.bridge networking.networkd.privacy plasma5 systemd-networkd-ipv6-prefix-delegation lightdm installer.simple installer.btrfsSimple installer.btrfsSubvols sway networking.networkd.link networking.scripted.privacy

https://github.com/ofborg test nat.firewall-conntrack networking.scripted.sit networking.networkd.virtual networking.scripted.dhcpSimple firewall firefox networking.scripted.macvlan proxy firefox-esr sddm.default boot.uefiCdrom networking.scripted.static networking.scripted.routes installer.lvm networking.networkd.vlan containers-imperative boot.biosUsb xfce networking.networkd.dhcpOneIf installer.simpleUefiSystemdBoot keymap.qwertz gnome-xorg shadow networking.networkd.macvlan networking.networkd.routes

@ofborg test nfs3.simple php.fpm fontconfig-default-fonts networking.scripted.bond nano keymap.dvorak installer.luksroot networking.scripted.bridge docker simple chromium networking.scripted.dhcpOneIf networking.networkd.bond php.pcre nat.standalone openssh networking.scripted.vlan ipv6 installer.separateBoot misc predictable-interface-names.predictableNetworkd networking.scripted.loopback keymap.colemak installer.btrfsSubvolDefault

Some of the ofborg builds failed or timed out. Except for gnome, the failures can be reproduced on x86_64 on commit d888104 on which this MR is based, so I don't think they are related to the changes in this MR.
xmonad
This seems to be a compile issue (can be found by searching for getXMonadDataDir in the logs).
gnome (aarch64-linux only)
Opening the Gnome Terminal Window failed during the test.
nfs3.simple
Test "client2 obtains lock after resetting client1" fails with a timeout. The test runs into the same issue on d888104e4c7 when testing locally, so this is presumably another issue.
Timeouts

installer.simpleUefiSystemdBoot (aarch64-linux only)
Firefox (x86_64-linux only)
openssh (aarch64-linux only)
installer.separateBoot (x86_64-linux only)
chromium  (x86_64-linux only)

@roberth I'm unsure how to proceed here (with the tests and how to move the MR ahead in general). Can you help out?

gnome (aarch64-linux only)

This one reports going out of memory. Probably the VM's memory needs an increase. It'd make sense for ARM to trip first, as its code is a couple percent bigger. Other archs will follow it soon, if they don't already suffer from the same problem.

...

The installer tests have been flaky before. IIRC the USB tests suffer from a "hardware" issue in qemu. I'm not so sure about the other tests.
Perhaps you could link the logs and ask some of the test or package maintainers?
It's rather cumbersome to find logs for a single test with these commit statuses.

@ofborg test openssh nfs3.simple installer.simpleUefiSystemBoot gnome

@ofborg test gnome


I18n / SnackBarService for new course view

Description:
Use i18n and SnackBarService for new course view
Improvements

Translate two additional strings
Use SnackBarService

Pull Request Test Coverage Report for Build 2456

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.624%

Totals

Change from base Build 2455:
0.0%

Covered Lines:
1149

Relevant Lines:
1676

💛  - Coveralls


How to adjust the position of the connection when node resizes?

The node which I am using has the following css
.drawflow .drawflow-node {
    width: auto;
    height: auto;
}

.drawflow .drawflow-node .input,
.drawflow .drawflow-node .output {
    height: 15px;
    width: 15px;
    border: 2px solid var(--border-color);
}

.drawflow .drawflow-node .input:hover,
.drawflow .drawflow-node .output:hover {
    background: #4ea9ff;
}

.drawflow .drawflow-node .output {
    right: 0;
    transform: translateX(-50%);
}

.drawflow .drawflow-node .input {
    left: 0px;
    transform: translateX(-50%);
    background: #43b993;
}

when the node resizes the input and output are shifted also as they should be at the vertical center of the node. But the thing is connection doesn't shift. It attaches/shifts instantly to the input and output when I drag the node.
the problem occurs here
<svg class="connection node_in_node-2 node_out_node-1 output_1 input_1 p-task">
    <path class="main-path" d=" M<PHONE_NUMBER>392181<PHONE_NUMBER>399413 C<PHONE_NUMBER>31552<PHONE_NUMBER>399413
<PHONE_NUMBER>31552<PHONE_NUMBER>74121<PHONE_NUMBER>23886<PHONE_NUMBER>74121"></path>
</svg>

the d attribute  of path should dynamically update when node resizes.

View function updateConnectionNodes(id)
Example use:
editor.updateConnectionNodes('node-5');

Ohh yes. Sorry, I didnt study the documentation well.

the connection tries to update but doesnt attaches to the actual position of input and output.  what should be the problem now?

Same function

yeah, but it doesnt work properly. But works properly when node is dragged.
here how I am using it
$('#project-details').on('click', '.add-input', function () {
    $(this).prop('hidden', true)
    $(this).parent().find('.remove-input').prop('hidden', false)
    $(this).parent().find('.user-instruction-input').show(100)
    let node_id = $(this).closest('.drawflow-node').attr('id')
    drawflow.updateConnectionNodes(node_id)
})

$('#project-details').on('click', '.remove-input', function () {
    $(this).prop('hidden', true)
    $(this).parent().find('.add-input').prop('hidden', false)
    $(this).parent().find('.user-instruction-input').hide(100)
    let node_id = $(this).closest('.drawflow-node').attr('id')
    drawflow.updateConnectionNodes(node_id)
})

Could it be because it is taking 100 seconds to hide and show? Try settimeout.
Or prepare a codepen or sandbox to try

Yeah, 100 ms was the problem.


Don't attempt to transpile directories

Enable option in glob to disable directories from being returned when
finding paths to transpile during compilation
Description of the Change
Before this PR, building Atom involved transpiling all babel paths, coffeescript files, cson files, etc. by globbing for all paths matching (essentially) **/*.js, **/*.coffee, etc. Node modules like term.js appear in the directory structure as node_modules/term.js/<contents>, which previously caused the folder node_modules/term.js to be added to a list of paths to transpile under the assumption that it was a file. This causes an error when trying to read the folder) node_modules/term.js. This PR fixes that by enabling the nodir option, which filters out any directories from being in the results. While I only specifically witnessed this issue in finding javascript files, the bug also exists in the coffeescript, CSON, PEG.js, and custom transpilers if someone names a directory *.coffee, *.cson, or something else expected to be transpiled.
Alternate Designs
One could check if the path attempting to be transpiled is actually a directory where the error occurs right before transpiling, but glob already checks if the path is a directory.
Why Should This Be In Core?
Proposed update to building atom
Benefits
Can include node_modules named like module.js.
Possible Drawbacks
In the future, if the transpiler  (or a custom one) may support directories? In this event, a glob pattern that ends with a / still grabs directories (even if nodir is enabled).
Applicable Issues
None

Thanks, @edjubuh!


AAP-21066: Admin Dashboard: Revise RBAC configuration. Fix permission syntax

See https://issues.redhat.com/browse/AAP-21066
Further to https://github.com/RedHatInsights/chrome-service-backend/pull/410 this PR fixes the permission syntax.

/ok-to-test


v2 bug: StringSliceFlag not work

e.g.
go run main.go --test=a,b,c,d

output
[]string{"a,b,c,d"}

expect
[]string{"a", "b", "c", "d"}

@heyanlong here's a usage example for StringSliceFlag https://github.com/urfave/cli/issues/910#issuecomment-542353576
I'm sorry it's confusing! I'll make an issue for adding an example to the docs.


Heath bar / Armor bar

Hello Daniel, any chance to add soon Health Bar and Armor bar?

I've added hp and armor (text) but in a really messy way.
Would you like it?  @danielkrupinski

Its better to have bar and text for health and only bar for armor :)

Well doing anything in surface makes me want to kill myself

Chill bud, life is to short anyway :)

just use glow esp ( health )
ez fix

I know i can use that. But i would prefer more the bars.

Cool update @danielkrupinski can you add the bar also?

I love you !!! You can close this thicket.

@cojo1989 you forgot about armor bar


Improvement for k8s.io/docs/tasks/tools/

I'd like to understand the differences between the listed tools, so that I can choose the one that suits me best.
If I were the Technical Writer I would add a link for further reading which points to a comparison between the listed tools.

I'd welcome a blog article that surveys different ways to run Kubernetes for learning (including kind,  minikube and kubeadm, but also cloud options such as Katacoda and its competitors).
For the CLI tool kubectl there's no real competition. For setting up a production-like cluster, that could be a different article.
If we're able to commit to maintaining that kind of article, even better. That would let us mark the blog article as evergreen (always current). However, I don't think we have the capacity to do that.

The task page could then link to this article whilst the article remains current (up to 1 year after it was last reviewed).

/retitle Add tool comparison commentary to https://k8s.io/docs/tasks/tools/
/kind feature
/language en

Sounds very similar to:

#31186

/triage accepted


Update JSON schema

Update the current 0.7 JSON schema to 0.9 JSON schema.

To do so, the validator has to be updated along with the actual change. @lzehl and I talked about this and thought it would be nice to update the validator to a more general one that can check against different drafts dependent on the draft used within schemas with "$schema": "http://json-schema.org/draft-XY/schema#". --> If XY is 07, check against Draft7Validator. If XY is 09, check against Draft9Validator.
@skoehnen, could you create such a validator?

@skoehnen and @lzehl, I don''t know the status of this. @xgui3783 has performed some fixes related to this issue, but is it fixed?

@skoehnen OR @olinux : is the generator in the main openMINDS repo now using draft-07 or draft-09? or can you even choose between the json-schema draft (not sure if our schemas would actually look different...)?

I am still validating for the draft 7 and haven't encountered any errors yet ;)
But with the template language we could switch the draft version without it affecting the schemas.
What do you think @olinux?


Windows OVE-Electron does not load sequence on start

Hey, @tnrich ,
I use OVE-Electron on both Windows and Mac. On Mac, I appreciate that trying to open a sequence file type (ex: .gb) that I chose OVE-Electron to be my default viewer for, OVE-Electron starts in a new window with the sequence loaded. This does not occur on Windows however. On Windows, if I try to open a sequence file with OVE-Electron set as my default viewer, OVE-Electron just starts with no sequence loaded. I can import my sequence file just fine, but it's more effort than just 'double clicking' my sequence file and OVE-Electron loading it like it does on Mac.
For reference:
Version = 1.3.0
Install source: Windows Store
Best,
Josh

@jdmccauley would you mind opening the devtools on your windows machine after trying to open a sequence and see if you're getting any errors or messages logged out to the console?
Should be under View > Toggle Developer Tools I think..?
Thanks!

@tnrich
There's no errors that seem relevant to me...
I attached a video showing this behavior. On Mac, double clicking the gb file opens it in OVE Electron on start, whereas on Windows 10 I have to 'Import Sequence' no matter what.
https://user-images.githubusercontent.com/22922096/182716627-8986d90b-c622-4251-bead-d1557cff0da5.mp4

@jdmccauley would you mind checking if the latest version 1.4.1 fixes this issue for you? Thanks!

@tnrich
Just checked, unfortunately it does not.

@0xpsi  @jdmccauley darn I thought I'd fixed this.. I'll look into this issue when I get a spare moment..

@0xpsi want to try out this release and let me know if it works for you? - https://github.com/TeselaGen/ove-electron/releases/tag/v1.4.3
@jdmccauley I'm working on releasing the windows version now

Sounds great, thanks @tnrich!
On Fri, Oct 7, 2022 at 11:36 AM Thomas Rich @.***>
wrote:

@0xpsi https://github.com/0xpsi want to try out this release and let me
know if it works for you? -
https://github.com/TeselaGen/ove-electron/releases/tag/v1.4.3
@jdmccauley https://github.com/jdmccauley I'm working on releasing the
windows version now
—
Reply to this email directly, view it on GitHub
https://github.com/TeselaGen/ove-electron/issues/40#issuecomment-1271942204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFO4G4HWO2QFLRVJDK674STWCBURBANCNFSM55CKD6FQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@0xpsi want to try out this release and let me know if it works for you? - https://github.com/TeselaGen/ove-electron/releases/tag/v1.4.3
@jdmccauley I'm working on releasing the windows version now

Still unable to get it to work, although I may be doing something wrong. After downloading the .AppImage and making it executable, all I did was create a desktop shortcut in /usr/share/applications but not sure how to "install" it any other way. If I right click and "open with" it does not pop up as an option. Is there a particular way to "install" this? I'm on ubuntu 22

@0xpsi what happens when you double click the desktop shortcut you made? Does it launch the tool correctly? I am not familiar with how Linux does things. It seems like it not popping up as an option is perhaps not an issue with ove-electron?
I would expect that ove-electron would at least be an option for opening .gb files from a right click menu but that it would fail at the moment of trying to open it.

@tnrich double clicking on the .Appimage file works fine, as well as the desktop shortcut I manually made. Right clicking on .gb files does not show OVE as an option. I believe it was showing as an option when I had it installed as a snap package, but was still only opening a blank file and not the .gb file.

Ok, made a new release that hopefully simplifies the installation process. Basically I pulled the app from the various app stores and am no longer doing any sort of code signing or notarization (since those processes took soooo long to complete it made it difficult to iterate and fix bugs).
The installation instructions and downloads for the latest version (mac/win/linux) can be found here: https://github.com/TeselaGen/ove-electron/releases/tag/v1.5.0
Please let me know if it solves the issues you were seeing @0xpsi and @jdmccauley
Also @0xpsi the linux version icon is messed up right now but that should be fixable in a later release.

@tnrich there is arm architecture available but maybe you forgot to include the amd64 also? thanks

@0xpsi whoops didn't even realize that was an option for linux. Makes sense. I'll try to cut a new release with both architectures supported.

@0xpsi ok I updated the release again, please try one more time here https://github.com/TeselaGen/ove-electron/releases/tag/v1.5.0

@tnrich great, after installing the amd64 version I am able to open .gb files directly now! I am able to see the icon also.
However one issue now, (unrelated) but it appears it is not saving settings between states now (dark/light theme as well as custom enzyme groups)

However one issue now, (unrelated) but it appears it is not saving settings between states now (dark/light theme as well as custom enzyme groups)

@0xpsi what do you mean by saving settings between states exactly? Between closing and reopening the app?
It seems to be persisting theme and custom enzyme groups for me on Ubuntu running on an ARM architecture. Please open a new issue if you continue to have issues. Thanks! Once @jdmccauley responds we can close this one.

@tnrich yes between closing and reopening, and yeah I will create a new issue soon

@tnrich will do soon, sorry I am working from home with my mac. I'll test it when I get to the office where my windows machine lives!

@tnrich The windows install fails because it cannot find the installed .exe after setup. This fails both non-admin and admin setup runs.

Hmm @jdmccauley that is interesting. What version of windows are you on? And how are you installing? Could you provide a few more screenshots of your install process and what happens?
I was able to download the .exe file on Windows 11 and open it and install it and it seemed to work for me. I'll ask a coworker with a windows machine to try as well.

Here's my system info:
Edition	Windows 10 Pro
Version	21H2
Installed on	4/16/2021
OS build	19044.1889
Experience	Windows Feature Experience Pack 120.2212.4180.0
Sorry I'm trying to hold out against Windows 11 as long as I can...
More pics:

It gets to the end of the progress bar really fast.
Then this:

Calling 'Fix it':

Hi There,
Same problem than @jdmccauley here.
The installer fail without any notification. Only the uninstaller is present in the "C:\Users\Benjamin\AppData\Local\Programs\ove-electron".
The app from MS store works fine.
But unfortunately, the use of the MS store is not possible for us (security restriction)
This occurs both on:

Windows 10 Pro - 22H2 (Build 19045.2913).
Windows 10 Education - 22H2 (Build 19045.2846).

Is there a debug mode for the installer?


fix(link): change disabled handling

Changes <bx-link>, <bx-btn> (with href attribute/property) to make sure following link with context menu is prevented when they are disabled.
Also adds disabled and some other attributes/properties to <bx-clickable-tile>.
Refs carbon-design-system/ibm-dotcom-library#3405.

Thanks @RaphaelAmadeu for reviewing!


homebank: 5.8.2 -> 5.8.3

Description of changes
This MR upgrades homebank to most latest releases 5.8.3. It also move it to a by-name structure
During this change I've hard coded Gtk3 in the package, as it was done in all-packages anyway and this release will not build with neither Gtk2 nor Gtk4 anyway.
ChangeLog for the upstream release: https://www.gethomebank.org/ChangeLog
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Updated the MR. I also ran nixfmt with a separate commit as mixing content and format is always a bad idea.


APIs to return template information

Gears should have APIs to return supported template types and default template. The APIs should have no access control, and return static content (i.e. independent of tenant config).

Some thoughts and notes:
Currently the gears are mounted at path /_{id} at the gateway. e.g. https://example.com/_auth for auth gear. This is a convention among the between Skygear components.
Apart from this convention, do we want to have other conventions, so that we can have 'dynamic discovery' of Skygear app's configuration? For example:

obtaining the list of gears enabled for an app
checking whether MFA is required for an app
the focus of this issue, getting a list of templates required by a gear

There's some considerations:

Do we want to support potentially out-of-tree gears? (i.e. gears not maintained in this repo) Currently we have RBAC service (a potential gear), which is hosted at other repo. If we want to support them, we'll need to define common gear APIs, so that gateway could interact with it.
Do we want a cleaner and stricter responsibility separation between components? Currently the tenant config definition is shared across components. For example, if we add a field in some gear's configuration, we'll need to deploy every components, including the control-plane. We have nextimportslint to enforce isolation between gears in this repo, but it seems we're circumventing it by pushing codes into core.

* Do we want to support potentially out-of-tree gears? (i.e. gears not maintained in this repo) Currently we have RBAC service (a potential gear), which is hosted at other repo. If we want to support them, we'll need to define common gear APIs, so that gateway could interact with it.

This has always been the plan, and there was discussion in early dates of Skygear 2.0 revamp planning, that we should keep the shared interfaces for gears minimal.


[Backport] Update rhel8 branch

Picked change from #1087
Also updated translations which were provided by localization team. It still needs fr.po which will be available on Monday. Then I'll update the last commit.
If there is any other change that you want to get into 8.3 now is the time :) I went through commits in master that did not make it in and nothing stood up.
DO NOT MERGE YET, lets wait for the fr.po file.

I've added the missing fr.po file and cherry-picked the commit from #1088.

Fixed incorrect formatting strings in fr.po (and talked to Ludek about this), added closes and cherry-picked lines to commits.


Create a tag on actual master ?

Hello,
Could someone create a tag on the actual master branch ?
I'm pretty sure that lot of people have errors using chrome due to this bug : https://github.com/minkphp/MinkSelenium2Driver/commit/67c5b8a20274c53ec2f85fabda7005a6ac2dd1b9 it's fix on master but not on last tag.
Thanks

We must fix the tests before releasing

@stof Hey, any news on this? :)


added links for two new problems

Updated readme.md file for two pull requests I had submitted for below problems:

Electronic shop problem
Cat and mouse problem

@RyanFehr Thank you so much for taking all the pain with my first few check-ins. It was very first check-in a gitHub repository. Now I've a fair understanding of all the coding guidelines and readme guidelines you are following in your repository. I'm very confident now that going forward all my check-ins would not create problems for you while merging. Thanks a ton for helping me with my first commit into the world of open source. Your assistance was really encouraging.

@rasik210 Yea no worries! Glad I could help!


Event Reuqest on Codeunit 99000773

Hi
Need to have one event to modify prod order components when it is transfer from BOM
Though We have event for insert the customer values but not for modify.

Regards
Amol

Wrong Repo and wrong Issue tracker - you should post it here: https://github.com/Microsoft/ALAppExtensions/issues

Thank you I will post there

Posted Here
https://github.com/Microsoft/ALAppExtensions/issues/375

Posted in right place.


rephrase deployment cost message

Your deployment costs 511.2 TFTs or 6.134 USD/month based on the cloud resources (CPU, RAM, SSD, Public IP) selected  [Learn more about the pricing and how to unlock discounts.](https://manual.grid.tf/cloud/cloudunits_pricing.html)

deployment cost message rephrased


Slack interg improve

Fix prev commit "make unsets when other fieldParams are set logic more compact" - impossible to disable unset of text param. To turn ON unset of text just add unset_text: true to config.

Real hostname in Host attachment block.

Add customization of attachment color & title by adding to slack config attachmentCustom:

  slack:
    token: xoxp...
    ...
    attachmentCustom:
      color: '#a94442'
#      title: 'Деплой выполнен'

On weekends

No release yet


⚠ Bofrost.at has degraded performance

In 6170f8c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1472 ms

Resolved: Bofrost.at performance has improved in 410dfb8.


Injector: opt-out functions

In https://github.com/utahplt/FloatTrackerExamples/issues/5 , one of the random injections wound up in a function that (I claim) is protected against NaNs.
Even if my claim is wrong, it'd be helpful to ignore that function and let random NaNs appear in other places.
(For now there is a workaround: target specific functions one at a time. That might be better overall.)

The current injector supports only opt-in functions & libraries:
## Injector Fields

 - `active::Boolean` inject only if true

 - `ninject::Int` maximum number of NaNs to inject; gets decremented every time
   a NaN gets injected

 - `odds::Int` inject a NaN with 1:odds probability—higher value → rarer to
   inject

 - `functions::Array{FunctionRef}` if given, only inject NaNs when within these
   functions; default is to not discriminate on functions

 - `libraries::Array{String}` if given, only inject NaNs when within this library.

 - `record::String` if given, record injection invents in a way that can be
   replayed later with the `replay` argument.

 - `replay::String` if given, ignore all previous directives and use this file
   for injection replay.

`functions` and `libraries` work together as a union: i.e. the set of possible NaN
injection points is a union of the places matched by `functions` and `libraries`.

Sounds impressive, but also hard to implement. We'll need to normalize, check for vacuity, etc.
Let's leave this open until we have 3-5 examples of ways we might want to inject.
Then, use the examples to guide toward a low-work high-reward design.


Create legend for toggling windshaft map layers

Similar to how the GBIF layers are toggled on taxon/show, we'd like a good UI for toggling the windshaft layers on/off wherever they are shown. The toggle applies to both grids and point-level layers (i.e. when grids are off points are also off).

I have a version of this on Staging now using the existing GBIF Overlay toggle. It would be good to get confirmation the labels and descriptions used for the different layers - all observations, taxon range, place, observations featured. It's also worth taking a look at the guides card view which has pretty narrow maps and squeezes the text in the layer toggler. I even removed the map type selector there to make it all fit

Looking good. More things:

Change "Place Layer" to "Place boundary"
"Taxon Range Layer" to "Taxon Range"
"Observations Layer" to "Observations of this taxon" (assuming that's always what it is)
Scientific name in the taxon range layer byline should be italicized if it's a species or genus (species and genus names should always be italicized). If that's annoying I'm fine just skipping that byline.
Byline needs to be indented so it's flush with the layer title. Right now it's too far left:

In general my habit has been to capitalize the first word only in labels. I reserve capitalizing all words for titles.

OK these changes are done and I made a pull request #421 . Pushing this to Staging now


Provide troubleshooting tips for Unexpected application error message (or catch it in app)

Multiple times now, we have encountered user issues with the query tool throwing out a cryptic error that looks something like this either when the app is first loaded or when a query is submitted:
Unexpected Application Error!
c.sort is not a function
TypeError: c.sort is not a function
    at lA (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:194:8048)
    at Wp (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:38:19519)
    at wf (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:3139)
    at R1 (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:44804)
    at w1 (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:39766)
    at fw (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:39694)
    at cu (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:39547)
    at Lf (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:35914)
    at b1 (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:40:34865)
    at R (http://neurobagel.douglas.rtss.qc.ca/assets/index-ThZOToqV.js:25:1552)

This is not very user-friendly and can be difficult to troubleshoot both from a user's side (they most likely will not have any knowledge of React errors) and from our end, as it may require hands-on steps such as inspecting their network tab, checking what request bodies look like, etc.
It would be ideal if the query tool could catch this type of error internally, and return a more human-readable error message with some basic info on how to troubleshoot the problem (e.g., check your NB_API_QUERY_URL value) or at minimum, link to the docs / our "Getting help" page.
If this kind of error is too generic/challenging to catch within the app, I think an alternative solution would be to add a section to our docs dedicated to this specific type frontend error, with troubleshooting tips / what kind of info they should collect to share with us for debugging.

@rmanaem, wdyt?

See also #95!


uefi(filesystem): small quality of life improvements around filesystem and paths

Following #995, I propose some QoE changes to make some FS code easier, I would like to focus on:

ends_with (extension detection)
is_ascii (filename sanitization)
open (bridge between low level and high level)

at the moment.
Checklist

[ ] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[ ] Update the changelog (if necessary)

Closed as it's a useful internal experiment for me honestly, will separate the changes into consensual ones.


X11/cliprdr: Rework server to client clipboard handling

This gets rid of the multiple lock issue reported in https://github.com/FreeRDP/FreeRDP/issues/8846.
Quoting the main commit here:
The purpose of clipboard data locking is to make the other peer
retaining the current file list until a pending paste operation is done,
even though the clipboard selection changed.
As it may be difficult to determine, when a lock is needed, imitate the
same behaviour as mstsc:
When the server side supports clipboard data locking, always attempt to
lock the file list on the server regardless of what is advertised in a
FormatList PDU.
The Lock Clipboard Data PDU can even be already sent, before the
Format List Response PDU is sent.
This is also what mstsc, does: First, lock the new (potential) file
list, then unlock the file list, when the pending paste operation is
done.
So, rework the current clipboard implementation in that direction.

Since the implementation for timeouts for old file lists is a bit hard,
for now always force unlock pending locks, when the selection changes.
However, timeouts for old file lists can still be added in the future.

The reworked clipboard handling is done with the help of three hash
tables:

1. The inode table: This hash table manages all inodes for each file.
   The keys in this table are the inodes themselves, while the values
   the files and directories and their attributes (file size, last write
   time, etc.).
2. The clipdata table: This table manages the locks for each file list.
   The keys in this table represent the clip data id and the values the
   clip data entries, which have a reference to the clip data dir, a
   directory containing the whole selection, and some helper attributes,
   like the clip data id itself.
3. The request table: Every file size or file range request is managed
   here. When a FileContentsRequest is made, its stream id with the
   respective details are added to this table. When a response is
   received, these details can then be easily looked up here.

Tested with g-r-d and MS Windows RDS on Win 11.
Closes: https://github.com/FreeRDP/FreeRDP/issues/8846

Overall, the structure is very similar to what I did in g-r-d (minus the missing timeout part (can be added later)).


New release of specifications - Level 2

A new release of the specification has been deployed and we should check it to be sure all is still conform to it.

Woo, L2 hit Candidate Release! One step closer to Recommendation!
If you're interested, you view a diff of L1 and the CR of L2 here: https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2F2019%2FREC-webauthn-1-20190304%2F&doc2=https%3A%2F%2Fwww.w3.org%2FTR%2Fwebauthn-2%2F
This is where I admit that I've already implemented most of L2 in SimpleWebAuthn! I'll be going through that diff and comparing it to current SimpleWebAuthn functionality. If I notice anything off I'll capture it in here to prepare for a PR to get things updated.

In-Progress Notes for L2 CR Updates:

"Relying Parties SHOULD set [requireResidentKey] to true if, and only if, residentKey is set to "required"."

https://www.w3.org/TR/webauthn-2/#dom-authenticatorselectioncriteria-requireresidentkey

L2-specific changes addressed in PR #89 have been released as part of the latest v1.0.0 release (🎉)

L2-specific changes addressed in PR #89 have been released as part of the latest v1.0.0 release (🎉)


add reorder event and callback

Thanks @kyle-mccarthy, I'm reviewing.

You are correct about the type defs and I fixed those. I also moved the dispatch event into the view like you suggested.
One thing is that it will trigger the event while the user is still moving the items. What I mean by that is if there are two files A and B, if you click and move them to B and A and then move them back to A and B without releasing the mouse it will fire the event twice.
I am not sure if this is a problem or not, but I don't think that there is a easy way to resolve it. As far as I can tell the state of the mouse isn't currently tracked so that would have to be added.

I think that's fine for now, at that point the file's are actually re-ordered in the model. I'll merge this later this week.

Thanks @kyle-mccarthy and @rikschennink ,
By the way, it is missing in documentations.


Hidden subcommand

Is there a way to define a hidden subcommand?

With hidden.

@AdrienChampion I don't get it: subcommand is not an Arg, it's an instance of App, right?

My bad, I answered too quickly.
It sounds like you can do that with AppSettings. See AppSettings::Hidden and AppSettings::HidePossibleValuesInHelp for instance. I have to say I've never used that though.

Oh, thank you, it's exactly what I need! Missed it somehow...


Unknown protocol

Hello!
Got a device that send this hex string
3e303030323c244750524d432c3137303535392e3030302c412c303332382e333034352c4e2c30373633302e303733352c572c302e37332c3236362e31362c3230303831362c2c2c4137372c2073303030303738303135313830222c304d440d

That is decoded to
>0002<$GPRMC,170559.000,A,0328.3045,N,07630.0735,W,0.73,266.16,200816,,,A77, s000078015180",0MD

I can't find a matching protocol. Can someone help me?

It worked at 5013 port, so this post can be closed. Thanks

It doesn't actually look like H02 protocol, but if it works, I guess, it's fine.

No, really don't work. Positions using this H02 are bad, so it have to be another protocol

Do you have protocol documentation? It looks like it's not supported yet.

Unfortunately I don't have any documentation. I Will try to comunícate with manufacturer. If I find something I Will send it ro you. Thanks

Un their web site they talk about a HunterPro ASCII protocol (TAIP like). Have some reference?

It's not TAIP protocol. You can find TAIP protocol here:
https://www.traccar.org/protocols/

Yes, is not a TAIP...
I got more information. I found something here: http://www.gpsinformation.org/dale/nmea.htm#RMC
'>0002<$GPRMC,174927.000,A,0328.3022,N,07630.0733,W,0.21,258.46,200816,,,A7E, s000078015180",0MD'
So I think the following data can be collected from the decoded hex:
'>0002<'	(Verified, 0002 is the ID , is configured using a PC program and is a four digits number)
174927.000	Time Stamp
A		validity - A-ok, V-invalid
0328.3022	current Latitude (verified, is the right latitude)
N		North/South
07630.0733	current Longitude (verified, is the right longitude)
W		East/West
0.21		Speed in knots
258.46		True course
200816		Date Stamp (Verified 20/08/2016)
The following I think is the magnetic variations, checksum and something else
,,,A7E, s000078015180",0MD

I found it almost equal to PT3000, but in this case the ID is inside mayor and minor symbols. The device is an HP-LOW of HunterPro http://hunterpro.com.tw/ES/hp-low.html

I'm not skilled in Java, but I think if I modify the Pt3000Protocol.java and Pt3000ProtocolDecoder.java files we could make it work. I've done as described below. Am I right?
/*

Copyright 2015 Anton Tananaev<EMAIL_ADDRESS>
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package org.traccar.protocol;

import org.jboss.netty.bootstrap.ServerBootstrap;
import org.jboss.netty.channel.ChannelPipeline;
import org.jboss.netty.handler.codec.string.StringDecoder;
import org.jboss.netty.handler.codec.string.StringEncoder;
import org.traccar.BaseProtocol;
import org.traccar.CharacterDelimiterFrameDecoder;
import org.traccar.TrackerServer;
import java.util.List;
public class HplowProtocol extends BaseProtocol {
public HplowProtocol() {
    super("hplow");
}

@Override
public void initTrackerServers(List<TrackerServer> serverList) {
    serverList.add(new TrackerServer(new ServerBootstrap(), this.getName()) {
        @Override
        protected void addSpecificHandlers(ChannelPipeline pipeline) {
            pipeline.addLast("frameDecoder", new CharacterDelimiterFrameDecoder(1024, 'd')); // probably wrong
            pipeline.addLast("stringEncoder", new StringEncoder());
            pipeline.addLast("stringDecoder", new StringDecoder());
            pipeline.addLast("objectDecoder", new Pt3000ProtocolDecoder(Pt3000Protocol.this));
        }
    });
}

}
/*

Copyright 2013 - 2015 Anton Tananaev<EMAIL_ADDRESS>
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package org.traccar.protocol;

import org.jboss.netty.channel.Channel;
import org.traccar.BaseProtocolDecoder;
import org.traccar.DeviceSession;
import org.traccar.helper.DateBuilder;
import org.traccar.helper.Parser;
import org.traccar.helper.PatternBuilder;
import org.traccar.model.Position;
import java.net.SocketAddress;
import java.util.regex.Pattern;
public class HplowProtocolDecoder extends BaseProtocolDecoder {
public HplowProtocolDecoder(HplowProtocol protocol) {
    super(protocol);
}

private static final Pattern PATTERN = new PatternBuilder()
        .number(">(d+)<,")                   // imei
        .text("$GPRMC,")
        .number("(dd)(dd)(dd).?d*,")         // time
        .expression("([AV]),")               // validity
        .number("(dd)(dd.d+),")              // latitude
        .expression("([NS]),")
        .number("(ddd)(dd.d+),")             // longitude
        .expression("([EW]),")
        .number("(d+.?d*)?,")                // speed
        .number("(d+.?d*)?,")                // course
        .number("(dd)(dd)(dd)")              // date (ddmmyy)
        .any()
        .compile();

@Override
protected Object decode(
        Channel channel, SocketAddress remoteAddress, Object msg) throws Exception {

    Parser parser = new Parser(PATTERN, (String) msg);
    if (!parser.matches()) {
        return null;
    }

    Position position = new Position();
    position.setProtocol(getProtocolName());

    DeviceSession deviceSession = getDeviceSession(channel, remoteAddress, parser.next());
    if (deviceSession == null) {
        return null;
    }
    position.setDeviceId(deviceSession.getDeviceId());

    DateBuilder dateBuilder = new DateBuilder()
            .setTime(parser.nextInt(), parser.nextInt(), parser.nextInt());

    position.setValid(parser.next().equals("A"));
    position.setLatitude(parser.nextCoordinate());
    position.setLongitude(parser.nextCoordinate());
    position.setSpeed(parser.nextDouble());
    position.setCourse(parser.nextDouble());

    dateBuilder.setDateReverse(parser.nextInt(), parser.nextInt(), parser.nextInt());
    position.setTime(dateBuilder.getDate());

    return position;
}

}

Tananaev, sorry but the Tiket was closed  without being  answered. Please tell me if the information I have given is the right way to make the protocol work.
I would like to implement the protocol or give the necessary information to make it work, but I'm not Shure if the data is good enough for this.
Can you take a look, please?

I have implemented the protocol. See the linked commit above.


Pharaoh (1999)

Project Link
https://github.com/Banderi/Ozymandias
Project License
AGPL3
Steam App Ids
https://store.steampowered.com/app/564530/Pharaoh__Cleopatra/
Additional Context
The remake is coming out soon.  People will be wanting to play the old one as well.

@ddlyarcher Thanks, added in https://github.com/luxtorpeda-dev/packages/commit/70a6b68b953d416c98a8bf7b9a4959b391dec6e3


Update Sage to 6.10/6.9

SageMath has a number of different packages for different versions of OS X. I altered the original cask file to reflect this release structure.
Testing is needed for the releases for OS X versions 10.7 >= 10.9, and for 10.10.
Confirmed working on OS X 10.11.2, assumed working on OS X <= 10.10.
It would be great to be able to warn users on OS X 10.6 and below that their version of OS X is not supported by SageMath. Does anyone know how to do this? I tried checking the documentation but couldn't really find a way to do this.

It would be great to be able to warn users on OS X 10.6 and below that their version of OS X is not supported by SageMath. Does anyone know how to do this? I tried checking the documentation but couldn't really find a way to do this.

depends_on stanza details.

@jawshooah Thanks, I've updated the cask to use that stanza.

We could also support the PowerPC versions of sagemath, but these versions are no longer being updated. At least users on PowerPC archs would have access to sagemath. Is this something of interest or not really?

We could also support the PowerPC versions of sagemath, but these versions are no longer being updated. At least users on PowerPC archs would have access to sagemath. Is this something of interest or not really?

I don’t think that’s worth it. I doubt there is a relevant number of (or any) users using PowerPC and homebrew-cask.

Anyone know what I'm doing wrong? I've already tried scrunching up the depends_on stanza to the other stanzas to try to correct the problem but it doesn't seem to be working.
Casks/sage.rb:22:1: C: stanza groups should be separated by a single empty line
  depends_on :macos => '>= :lion'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Also, isn't it kind of bad that the travis build keeps downloading the sage binaries every time it tests the commits? I only realized that that was happening now that I was checking why the travis build keeps failing with my commits.

I'm just going to remove the depends_on stanzas altogether, as that's when the real problems started to appear. If anyone has any idea as to what I was doing wrong, please let me know.

@jdfm I'll take a look at this. You should be able to use depends_on, and our other features successfully

@adityadalal924 When the depends_on stanza was on, it worked on my machine, but failed the travis builds.
Also, let me know if you can do anything about the travis build for OS X 10.9 as well. It seems that it's creating a log file that's too big, and it results in the test failing prematurely.

Here's the fixed Cask. You almost had it - just needed an empty line. Check out CONTRIBUTING for instructions on how to do the style checks locally, as that's what was failing.
cask 'sage' do
  if MacOS.release <= :mavericks
    version '6.9'
    sha256 '21f460c90db2a9ee83d196937587de5daab8c6712b0f24366b6a1c15a8dd592b'
    # mit.edu is an official download host per the vendor download page
    url "http://mirrors.mit.edu/sage/osx/intel/sage-#{version}-x86_64-Darwin-OSX-10.7-app.dmg"
  elsif MacOS.release <= :yosemite
    version '6.9'
    sha256 '03112bf747cf807f308d518f34c1982ca3c9599e65bf64a6782efc78136198a4'
    # mit.edu is an official download host per the vendor download page
    url "http://mirrors.mit.edu/sage/osx/intel/sage-#{version}-x86_64-Darwin-OSX_10.10_x86_64-app.dmg"
  else
    version '6.10'
    sha256 '00092f6450267a46f94bfd69f148e71e05d5e4edbac234101afa63f40db45d1b'
    # mit.edu is an official download host per the vendor download page
    url "http://mirrors.mit.edu/sage/osx/intel/sage-#{version}-OSX_10.11.2-x86_64.app.dmg"
  end

  name 'Sage'
  homepage 'http://www.sagemath.org/'
  license :gpl

  depends_on :macos => '>= :lion'
  depends_on :arch => :x86_64

  if MacOS.release <= :yosemite
    app "Sage-#{version}.app"
    binary "Sage-#{version}.app/Contents/Resources/sage/sage"
  else
    app "SageMath-#{version}.app"
    binary "SageMath-#{version}.app/Contents/Resources/sage/sage"
  end

  zap :delete => [
                   '~/.sage',
                   '~/Library/Logs/sage.log',
                 ]

  caveats do
    files_in_usr_local
  end
end

Please update and squash your commits - tl;dr (make changes, commit, git rebase -i origin/master, fixup for everything except first commit, then force push to your Cask branch.)

@adityadalal924 I see what I did wrong now... In the commit that I added the stanza in I have depends_on separated from the other stanzas, but, I have whitespace at the start of the line preceeding the depends_on stanza... I'll add the stanzas back in now.

@adityadalal924 The OS X 10.9 build is failing, I don't think there's anything I can do about that one for the reasons stated in my above comments. I'll be squashing the commits in a couple of minutes. If it doesn't pass that 10.9 build will this pull request be rejected?

No, that's not a problem - squash the commits and just comment again when the builds are done (even if they fail).

Squashed.

Thank you for the contribution. It was merged directly as 1112fa34b3fae9de896173d19ea1166d59ffc731 to keep commit history cleaner. Your contribution is still credited to you.


[Bug] iOS stopped tracking custom events, only the standard events are showing

[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.3.20f1
Firebase Unity SDK version: 8.6.2
Source you installed the SDK: .unitypackage
Problematic Firebase Component: Analytics
Other Firebase Components in use: Remote Config, Messaging
Additional SDKs you are using: None
Platform you are using the Unity editor on: Windows
Platform you are targeting: iOS, Android
Scripting Runtime: IL2CPP

[REQUIRED] Please describe the issue here:
My custom events on iOS used to work up until October 21. From that date, I have not received any custom events.
I do receive the standard events (screen_view, user_engagement, session_start)
I did an app update around that time but I double-checked the change list and the update only contained new content, nothing Firebase or SDK-related changed. Also, it's weird that all events drop so instantly from one day to the other, an update roll-out always takes a while.
When it started I still used Firebase SDK 7.1.0 but by now I updated to 8.6.2 but I still don't receive any custom events.
(At least not visible in any dashboard)

Hi @nvdg,
Thanks for reporting this. In order to identify what's causing this behavior, could you provide a minimal, reproducible example of your project along with the debug logs you're getting after triggering custom events?

Sorry, I found that there actually already was a thread for this issue: https://github.com/firebase/quickstart-unity/issues/1099
If you want you can close this one and re-open the other. It looks like no one posted a solution there yet.
As for the steps to reproduce, it should just be adding the firebase to unity and making an ios build.
I'm not able to look a logs because it's on iOS and I don't own a mac myself. The builds are made on a build server.

Sorry, I found that there actually already was a thread for this issue: #1099

That thread locked , have you solved it ?

Hi @nvdg,
We can continue our thread here since the thread you mentioned is locked. With that, it would be helpful if you could provide the logs so that we can analyze if the issue is caused by the backend or the SDK.
If you're unable to provide a minimal, reproducible example, could you verify if custom events aren't being tracked from the quickstart?

@paulinon
Here are the log files:
log.txt
Sorry, but running a new project from the quickstart would take me way too much time. Especially since I have to setup and build from a build server.

Thanks for that, @nvdg. I was able to reproduce the issue as well using the quickstart, but this appears to be related to the backend rather than the SDK. You may contact Firebase Support where one of our agents will get in touch with you. That being said, I'll be closing this for now.


[tool_crash] RPCError

Command
flutter run

Steps to Reproduce

...
...
...

Logs
RPCError
#0      new _OutstandingRequest (package:vm_service/src/vm_service.dart:261:34)
#1      VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1778:25)
#2      VmService._call (package:vm_service/src/vm_service.dart:1790:8)
#3      VmService.getVM (package:vm_service/src/vm_service.dart:1245:25)
#4      FlutterDevice.initLogReader (package:flutter_tools/src/resident_runner.dart:428:55)
#5      HotRunner.attach (package:flutter_tools/src/run_hot.dart:266:21)
<asynchronous suspension>
#6      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:867:27)
<asynchronous suspension>
#7

Closing this as a duplicate of https://github.com/flutter/flutter/issues/154903