Delay when saving files

VSCode Version: 1.9.0
OS Version: macOS Sierra 10.12.3

Steps to Reproduce:

Open file
Make changes
File > Save

Expected: File to immediately save as it did with 1.8.1 (and verified after downgrading to 1.8.1)
Actual: File saves but with approximate 1 second delay.
Workaround: Revert to 1.8.1
Probably unrelated but 1.9.0 also broke the Contextual Duplicate extension.
Wish I could be more help but I'm not really sure how to track down the problem.  I did double check that re-install 1.9.0 still has the slow down where as 1.8.1 does not.

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

That is a great idea.  I tried it and it still had the slowdown but it got me thinking that it might have been something in my project so I managed to narrow down the test case to make it reproducible.

I've updated the issue title and description with the steps to reproduce.  It seems to be triggered by the presence of a .vscode/tasks.json file.

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

Attached is a Gist with the Terminal console log and the web console log.  I ran it with extensions disabled to ensure I wasn't logging any extra junk from my extensions.
https://gist.github.com/gshaw/0d76fae2a6fa147501d8a740982390a8
Unfortunately I'm not seeing anything of much help to move this along.  The only thing I did notice was the log message for ipc.cp.ts:152 [IPC Library: Watcher] [CHANGED] /Users/gerry/test/test.txt didn't appear in the log until after the delay between triggering a save and the save actually happening.
Is anybody else able to duplicate the problem? I'll try on Monday (Pacific Time) when I have access to other Macs and comment back here.

@gshaw this seems to be https://github.com/Microsoft/vscode/issues/19773 and I kindly ask you to maybe try what I suggested (set "break on error" and see if you are able to hit the breakpoint where the error happens).

I didn't hit any breakpoints during save but looking at #19733 this issue seems like it's resolved.  If you need any other info let me know.  The fast response and great communication is much appreciated.

Yeah we fixed it and will backport it to a 1.9.1 release.


error when dumping Report data model object to_dict

Calling to_dict on the report data model object returned from the API results in the following error when it hits the defaultdict of metrics/
TypeError: first argument must be callable or None

Is this worth worrying about now or should we wait until the EPRI metrics stuff is in? Guessing that some of the related code might change a lot.


Celery worker support for Druid Queries

I set up a superset cluster consisting of superset web server, redis (as broker, result backend and cache) and celery workers. Everything works fine within SQL Lab: The celery worker receive the tasks, write in the result backend and fill the cache.
On the other hand Druid queries via "Sources" --> "Datasources" are handled by the superset web server and not by the celery workers. Ist this normal behavior?
Did i miss a configuration that forces this kind of queries to use the celery workers as well?
Expected results
Druid queries via "Sources" --> "Datasources" are handled by the celery workers
Actual results
Druid queries via "Sources" --> "Datasources" are handled by the superset server
Environment
(please complete the following information):

superset version: 0.28.1
python version: 3.6.8
doker image: amancevice/superset:0.28.1

superset_config.py:

import os
from werkzeug.contrib.cache import RedisCache
if 'SUPERSET_HOME' in os.environ:
DATA_DIR = os.environ['SUPERSET_HOME']
else:
DATA_DIR = os.path.join(os.path.expanduser('~'), '.superset')
LOG_FORMAT = "%(asctime)s:%(levelname)s:%(name)s:%(message)s"
LOG_LEVEL = "DEBUG"
ENABLE_TIME_ROTATE = False
TIME_ROTATE_LOG_LEVEL = "DEBUG"
FILENAME = os.path.join(DATA_DIR, "superset.log")
ROLLOVER = "midnight"
INTERVAL = 1
BACKUP_COUNT = 30
ROW_LIMIT = 50000
VIZ_ROW_LIMIT = 5000
FILTER_SELECT_ROW_LIMIT = 1000
SQLALCHEMY_TRACK_MODIFICATIONS = True
SUPERSET_WEBSERVER_TIMEOUT = 60
QUERY_SEARCH_LIMIT = 1000
POSTGRES_SERVER_URL = os.getenv('POSTGRES_SERVER_URL', '')
POSTGRES_DB = os.getenv('POSTGRES_DB', '')
POSTGRES_USER = os.getenv('POSTGRES_USER', '')
POSTGRES_PASSWORD = os.getenv('POSTGRES_PASSWORD', '')
SUPERSET_SQLALCHEMY_DATABASE_URI = "".join(['postgresql+psycopg2://', POSTGRES_USER, ':', POSTGRES_PASSWORD, '@', POSTGRES_SERVER_URL, '/', POSTGRES_DB])
SQLALCHEMY_DATABASE_URI = SUPERSET_SQLALCHEMY_DATABASE_URI
CACHE_CONFIG =  {
'CACHE_TYPE': 'redis',
'CACHE_DEFAULT_TIMEOUT': os.getenv('CACHE_DEFAULT_TIMEOUT', ''),
'CACHE_KEY_PREFIX': 'superset_cache',
'CACHE_REDIS_URL': os.getenv('CACHE_REDIS_URL', '')
}
MAPBOX_API_KEY = os.environ.get('MAPBOX_API_KEY', '')
class CeleryConfig(object):
BROKER_URL = os.getenv('BROKER_URL', '')
CELERY_IMPORTS = ('superset.sql_lab')
CELERY_RESULT_BACKEND = os.getenv('CELERY_RESULT_BACKEND', '')
CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
CELERYD_TASK_SOFT_TIME_LIMIT = os.getenv('CELERYD_TASK_SOFT_TIME_LIMIT', '')
CELERYD_TASK_TIME_LIMIT = os.getenv('CELERYD_TASK_TIME_LIMIT', '') # 30 min
CELERYD_MAX_TASKS_PER_CHILD = os.getenv('CELERYD_MAX_TASKS_PER_CHILD', '')
CELERYD_LOG_LEVEL = os.getenv('CELERYD_LOG_LEVEL', '')
CELERYD_PREFETCH_MULTIPLIER = os.getenv('CELERYD_PREFETCH_MULTIPLIER', '')
CELERY_ACKS_LATE = True
CELERY_SEND_EVENTS = True
CELERY_CONFIG = CeleryConfig
RESULTS_BACKEND = RedisCache(
host=os.getenv('RESULTS_BACKEND_HOST', ''),
port=os.getenv('RESULTS_BACKEND_PORT', ''),
key_prefix='superset_results'
)

Command to start

Server:
gunicorn
-w 10
-k gevent
--timeout 60
-b  <IP_ADDRESS>:8088
--limit-request-line 0
--limit-request-field_size 0
superset:app
worker:
celery worker --app=superset.sql_lab:celery_app --pool=gevent -Ofair --task-events

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Hi @Stephan3555 - sorry I didn't respond to this earlier. The "sources > druid" system is deprecated. It is recommended to use the SQLAlchemy connection method and Druid's SQL interface going forward (via the Databases list). This is the recommended method for connecting to Druid going forward, and should support background queries.

Hi @willbarrett,
thanks for the info! Hmm that are not very good news for us.
Does this mean that "sources > Druid Datasources" will disappear someday? And only the SQL Lab stays?
We are working with a lot of users who are not able to use SQL because their background is not IT. Having a user friendly interface where people can just click together their query is mandatory for us.

@Stephan3555 have you tried using the Explore view for this functionality? That section is designed to accommodate less-technical users.

Hi @willbarrett!
Yes and its working very well. But unfortunately you have to write an SQL Query to get it working right?. And around 90% of our Superset User are not able to use SQL. And are not willing to learn it


Cake Pay Web Database Upgrade

Cake Pay Web will be down for up to 1 hour for a merchant database upgrade.

This upgrade is complete! Thanks for your patience!


Add progress bar while fetching grades

Creating progress bars

Added a little spinner foor the duration tahat it takes to retrieve everythin 47328f4314b24adbe246dd1bcfe1b7d900b89f35


Use Hero Patterns Death Star background?

See Death Star at http://www.heropatterns.com/

Brought in HeroPatterns code in 942cdd4a, but deciding not to use it as it seems too busy.


.Net: Add Anthropic Support (I can contribute a PR for this)

I use the Semantic Kernel (great toolkit, by the way) with both OpenAI and Anthropic at my startup and I'd like to contribute our AI connector for Claude back to the community
I have the connector implemented in my forked repo (https://github.com/glorious-beard/semantic-kernel) and I can create a PR if there's interest.

Yes! This would be very interesting. Please go ahead and create a PR and we can review it!

I'd suggest to make the apis avaiable to extend the connectors so that community can maintain and develop the connectors parallel to this repo. For instance, I am interested in get Ollama connector to run my all my stack locally. Whill trying to get it on a sepearte repo by referenceing kernel nuget, only found out there are internal classes to follow the openai connenctor implementation. It will be good to make them available to public while MS focus on couple of major ones.

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.

This is still interesting to us. @glorious-beard hasn't responded in #3476, but if he's willing to split up the pull request to comply with the feature branch ADR, that would be cool. Otherwise, we'll consider if we can contribute here.

Any updates on this? Looking into potentially integrating the Claude models into our usage of SK.

Looks like someone has started a new effort here. https://github.com/microsoft/semantic-kernel/issues/5690


fix(web-app): bx vs cds prefix issue

DO NOT MERGE this PR until the fix for https://github.com/carbon-design-system/carbon/pull/10128 is available in a release and has been picked up on this branch.

Remove carbon prefix workaround script
Remove FeatureFlags from _app.js

Marked as draft and removed requested reviewers for now so GitHub Slack app doesn't give daily review reminders about this.

When we pull latest from @carbon/react, let's make sure it addresses the issues identified here: https://github.com/carbon-design-system/carbon/discussions/9723#discussioncomment-1688492

Updating to<EMAIL_ADDRESS>does not fix the issue. bx-- prefixes are still being generated in production builds:


[AutoPR containerregistry/resource-manager] Add ContextPath and source location URL for encode task and run type, support for pull request based triggers

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4026

Codecov Report

Merging #3452 into restapi_auto_containerregistry/resource-manager will decrease coverage by <.01%.
The diff coverage is 46.66%.

@@                                 Coverage Diff                                 @@
##           restapi_auto_containerregistry/resource-manager    #3452      +/-   ##
===================================================================================
- Coverage                                            37.56%   37.56%   -0.01%
===================================================================================
  Files                                                 8789     8786       -3
  Lines                                               266344   266347       +3
===================================================================================
  Hits                                                100048   100048
- Misses                                              166296   166299       +3

Impacted Files
Coverage Δ

...9_01/models/docker_build_step_update_parameters.py
41.66% <ø> (+3.2%)
:arrow_up:

...ainerregistry/v2018_09_01/models/file_task_step.py
50% <ø> (+4.54%)
:arrow_up:

...ainerregistry/v2018_09_01/models/run_filter_py3.py
26.66% <ø> (ø)
:arrow_up:

...rregistry/v2018_09_01/models/base_image_trigger.py
55.55% <ø> (ø)
:arrow_up:

...e/mgmt/containerregistry/v2018_09_01/models/run.py
23.8% <ø> (ø)
:arrow_up:

...rregistry/v2018_09_01/models/source_trigger_py3.py
29.41% <ø> (ø)
:arrow_up:

...istry/v2018_09_01/models/trigger_properties_py3.py
44.44% <ø> (ø)
:arrow_up:

...models/base_image_trigger_update_parameters_py3.py
33.33% <ø> (ø)
:arrow_up:

...9_01/models/encoded_task_step_update_parameters.py
50% <ø> (ø)
:arrow_up:

...ainerregistry/v2018_09_01/models/source_trigger.py
50% <ø> (ø)
:arrow_up:

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bdf99...f03f7c7. Read the comment docs.

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3467


creating CI workfile

Description
Setup CI through GitHub Actions
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, but not tested (may need new tests)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] My changes generate no new warnings
[x] There are no merge conflicts

PLEASE NOTE: Fails are expected at this time as there is nothing to test or build! 😅


'gel electrophoresis system' has same definition as parent

'gel electrophoresis system' [OBI:0001121] has same definition as its parent 'electrophoresis system' [OBI:0001053]

Changes I've made in pull #

moved "agarose gel electrophoresis system" under gel electrophoresis system.
removed "electrophoresis system" as alternate term from gel electrophoresis system (it is label of parent class).
changed "gel electrophoresis system" definition to: "An electrophoresis system in which an electric field is applied to a gel matrix"
changed "pulsed-field gel electrophoresis system" definition to: "A gel electrophoresis system in which the gel matrix is subjected to an electric field that periodically changes direction."

For gel electrophoresis definition, I'm not sure if we want to add "to differentiate macromolecules (DNA, RNA and proteins) and their fragments, based on their size and charge. " as Wikipedia details?


Update/Add [tool name]

Tool information

Tool name:
Tool license:
Add or update?
Desired version:
Approximate size:
If this is an add request:

Brief description of tool:
URL for tool's homepage:
Provide a basic test case to validate the tool's functionality:

Area for Triage:

Question, Bug, or Feature?:

Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[x] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Can this tool be installed during the build?

Tool installation time in runtime

Are you willing to submit a PR?

Nice

Hello @alleydude,
Sorry, I don’t see enough information in this request. Please reopen after adding all necessary info based on template.


Weather app using React added

Build a weather app using reactjs and added in the Reactjs project folder.

use open weather API and added project screenshot in the readme.md file .
issue no: #450

@pranjay-poddar review it


B-17993 Recalculate sit dates after edit updates

Summary
This PR is to check and fix any issues found when TOO edits Total days of SIT approved or SIT authorized end date in the Edit SIT authorization modal. While editing the fields and/or save the new dates entered, other values should reflect the change correctly.

Edits have been made to the SIT authorized end date calculation to reflect the change to Total days used calculation.
Changed UI minimum value validation for Total days of SIT approved have been changed to show correct number of minimum days required.
Fixed the bug where the user was able to bypass the minimum value validation for the Total days of SIT approved.
Fixed auto-date change to show correct dates when editing Total days of SIT approved or SIT authorized end date

How to test

Create a HHG move with a SIT service item.
Login as TOO -> under "Move task order" tab -> use the 'Edit' button.
Make changes to the Total days of SIT approved or SIT authorized end date.
Verify that the changed edits are correct.

Screenshots
BEFORE

AFTER

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against c3e9e6296153226a8e5561796733851875557033


js-beautify adds a space between # and include

I'm using js-beautify when coding for Adobe After Effects that uses Javascript. The problem is that when I write #include js-beautify changes it to # include and breaks the code.
Is there a way to ignore # signs or another way to fix this or will it need to be done in the source-code?
Thanks!

The ignore directive might work:
https://github.com/beautify-web/js-beautify#directives-to-ignore-or-preserve-sections-javascript-only
Please provide an example input, expected output and actual output.

Input
The code looked like this before beautification:
#include "settings.jsxinc"

Expected Output
The code should have looked like this after beautification:
#include "settings.jsxinc"

Actual Output
The  code actually looked like this after beautification:
# include "settings.jsxinc"

Putting my includes between beautify preserve fixed the problem! I searched for a good hour but for some reason I missed beautify preserve.
Thanks!

Note: the above is definitely not valid JavaScript, so it's not really a surprise that the beautifier doesn't handle it.   Where can I find the spec for this language?

Here you have all documented info about Extendscript:http://download.macromedia.com/pub/developer/aftereffects/scripting/JavaScript-Tools-Guide-CC.pdf
I have used js-beautify for years with this language without problem except now with the #include

I've pulled this into the next milestone.  Getting the #include back is a minor change.


Cover image

It would be great if we can implement a cover image field for each post.

For this feature, should user upload cover image to server or just provide cover image URL from any other web sites?

Hi @TimothyYe,
I think we can just add an input field in /view/admin/edit_post.html to indicate a cover image URL first, and implement a drag-and-drop upload feature later.
If you are interested in working on this one, you may find out that there is already an Image field in post.go#L43, and what we need to do is to add a line in post.go#L216 to read image link from form data:
p.Image = r.FormValue("image")

And also add an input field in /view/admin/edit_post.html like this:
<input class="mdl-textfield__input" type="url" name="image" id="image" value="{{ .Post.Image }}">

Thanks!

Sure, I'll take it and try to implement this feature.

@dinever  Cover image URL not can be edited & saved in admin panel, I'll create a pull request later.

@TimothyYe Great. Looking forward to it.


Add Kiss CLI

Kiss! :

is IDEs agnostic
share snippets in a project
create multiple files based on single/multiple snippets in one line
kiss, the name, is keyboard compliant

kiss src/views/view.jsx src/index.ng

will output a simple React's src/views/view.jsx and an Angular's module in src/index.ng, using fs-extra to create folders hierarchy

https://github.com/sixertoy/kiss-cli/

Thanks for the suggestion, but I'm going to pass on this. The CLI tool list is growing too large and I need to be very picky about what I add there.
I would recommend submitting to https://github.com/aharris88/awesome-cli-apps instead :)

Thank you for taking time :)


[Bug] Invalid device info

Describe the issue

Home Assistant is reporting the following error when attempting to load the integration:
2023-08-30 15:52:12.195 ERROR (MainThread) [homeassistant.components.binary_sensor] truenas: Not adding entity with invalid device info: ...
How to reproduce the issue

Install integration
Setup integration
Expected behavior

No error messages
Screenshots

Software versions

Home Assistant version: 2023.9.0b0
TrueNAS integration version: 0.6.1
TrueNAS version: TrueNAS-SCALE-22.12.2

Diagnostics data

Traceback/Error logs

2023-08-30 15:52:12.195 ERROR (MainThread) [homeassistant.components.binary_sensor] truenas: Not adding entity with invalid device info: Invalid device info [...] for 'truenas' config entry: device info needs to either describe a device, link to existing device or provide extra information.

Additional context

known issue, caused by unlisted breaking change in last HA release. will be fixed in next integration release

Sweet thanks, figured I'd make an issue either way for any others who may hit this as well.

If you drop a beta, I'll be happy to test it out.

there wont be a beta for this integation.
I'm already working on new system for my integrations which is updated to latest HA standards. Once that is fully tested, I will just move it over to this integration and others since they share common code for this reason.

Either way, I'd be happy to test.

+1 Experiencing this issue for a while now too. Too lazy to post a report myself. Glad to hear it's known and in process. Thanks for the project/integration!

Hi @tomaae,
unfortunately I still have the same problem. HomeAssistant, HACS and the TrueNAS integration are up to date (2023.11.1, 1.33.0, v.1.2.5). I removed and reinstalled the complete Integration and the device itself - but there ist just one entity visible (update.update).
After a fresh reboot the following truenas related logs are generated:

Error while setting up truenas platform for sensor

Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_setup_platform await asyncio.shield(task) File "/config/custom_components/truenas/sensor.py", line 31, in async_setup_entry await model_async_setup_entry( File "/config/custom_components/truenas/model.py", line 58, in model_async_setup_entry update_controller() File "/config/custom_components/truenas/model.py", line 44, in update_controller model_update_items( File "/config/custom_components/truenas/model.py", line 111, in model_update_items if tmp := _register_entity(sensors, item_id, uid, uid_sensor):           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/config/custom_components/truenas/model.py", line 78, in _register_entity _sensors[_item_id].async_schedule_update_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 922, in async_schedule_update_ha_state self.async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 720, in async_write_ha_state raise RuntimeError(f"Attribute hass is None for {self}") RuntimeError: Attribute hass is None for <Entity fastpool/iocage/jails/blender>

Error while setting up truenas platform for binary_sensor

Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_setup_platform await asyncio.shield(task) File "/config/custom_components/truenas/binary_sensor.py", line 31, in async_setup_entry await model_async_setup_entry( File "/config/custom_components/truenas/model.py", line 58, in model_async_setup_entry update_controller() File "/config/custom_components/truenas/model.py", line 44, in update_controller model_update_items( File "/config/custom_components/truenas/model.py", line 111, in model_update_items if tmp := _register_entity(sensors, item_id, uid, uid_sensor):           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/config/custom_components/truenas/model.py", line 78, in _register_entity _sensors[_item_id].async_schedule_update_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 922, in async_schedule_update_ha_state self.async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 720, in async_write_ha_state raise RuntimeError(f"Attribute hass is None for {self}") RuntimeError: Attribute hass is None for <entity None=off>

If I can supply more information please dont hesitate to ask, I really appreciate your work!

thats not the same problem. open a new ticket for this one and provide debugs as well. there is most likely some error before those messages.


Elin/merge main v0.13.0 into main

This change is

Codecov Report
Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (bd986b3) 71.36% compared to head (4bd35dc) 71.00%.

Files
Patch %
Lines

...ates/native_blockifier/src/transaction_executor.rs
14.28%
41 Missing and 1 partial :warning:

crates/blockifier/src/execution/call_info.rs
10.52%
17 Missing :warning:

crates/blockifier/src/transaction/objects.rs
0.00%
7 Missing :warning:

crates/blockifier/src/state/cached_state.rs
14.28%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   71.36%   71.00%   -0.36%
==========================================
  Files          59       59
  Lines        7225     7360     +135
  Branches     7225     7360     +135
==========================================
+ Hits         5156     5226      +70
- Misses       1657     1722      +65
  Partials      412      412

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Port signed integer math to modern QDK

This PR ports the classic QDK's signed int math functionality to the modern QDK.
It is not intended to provide the perfect API -- it is just a port, that other libraries will build upon, primarily the fixed point library.

@sezna , Feel free to postpone all my comment for later time if you need. We can always improve code :)


Issue installing R package

Describe the bug
R package could not be installed due to not being able to write to the default directory location: /usr/local/lib/R/site-library
To Reproduce
Steps to reproduce the behavior:

Use the baker.yml below...

name: Rplayground
vm:
   ip: <IP_ADDRESS>
   memory: 2048
lang:
  - python2
  - R:
      packages:
        - coin
        - ggplot2

Run baker bake
...

Expected behavior
Do baker ssh then run R and execute library(ggplot2) on the interpreter and it should be loaded with no error messages.
Actual
Error in library(ggplot2) : There is no package called 'ggplot2'

Please complete the following information:

OS: MacOS
Version 10.13.6

Additional context
After running baker ssh I tried just running R with sudo and executed install.packages("ggplot2") which results in this message before successfully installing:
> install.packages("ggplot2")
Installing package into '/usr/local/lib/R/site-library'
(as 'lib' is unspecified)

Please disregard this, I could install R packages when I started the whole process.


Incompatibility with Carpet

Seems like the same mixin that crashed with Balm also crashes with Carpet Mod. Only happens when Fabrication is enabled, when I remove fabrication, carpet works fine
latest.log

Duplicate of #470


Document missing flags of Meta Arithmetic

I found two flags missing from the documentation. They seem to work well with 1.6.17:
> ma number k Oopaque v
< VA 2 knumber Oopaque
< 24

Thanks!

Out in 1.6.19


Unlist NSwag.MSBuild.CodeGeneration in nuget.org

Unlisted in favor of NSwag.ApiDescription.Design (renamed)


ShareX integration

Hello,
Would it be possible to have a version of PowerToys that would contain a little version (or not at first) of the ShareX capture software which is OpenSource https://github.com/ShareX/ShareX
Thanks for your work :)

@snak31 Thank you for your issue!
Integrating a software is quite a work and because of that we need to better understand what the advantages would be if we do this. Could you explain this?

why not just use ShareX if you want to use it?
you can even do "winget install ShareX"


fix(curriculum): copy edit for grammar

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

I felt it was important to use proper grammar when exploring the strange coincidences surrounding Chuck Norris and Camper Cat.

Great idea @gikf! I fixed the remaining English instances.


Use of angle brackets around file names for include statements

Would you like to replace any double quotes by angle brackets around file names for include statements?

Done, thanks for the suggestion! It's better since the library is "headers only".

Thanks for your small source code improvement.


Add the fun run & walk route to the map

Add the fun run & walk route to the interactive map and link back to the official map!

Since there is already a fun run map, I would vote for keeping it off of our map.  At least that is my first reaction.  Not a strong one though.

For those following along, @fawcett and I talked outside of GitHub and decided to try a feature branch named fun-run-route-and-legend to see how this plays out before commiting directly to themaster branch.
So... I just pushed up commit 70bd1e4db0a1966e4713726b0cb62b6838d89c89 that adds a legend to the map with two layers to turn on/off:

LRT stations/lines, and
Nice Ride stations.

In addition, I'll try adding the fun run route in another commit (coming soon). :smiley_cat:

@fawcett: Thoughts? Enhancements? Leave it out?
I'm open to any and all possibilities where you see fit.

I am up for looking at it on the map with the layer control.  I also think that it might look just fine with everything all in the same 'layer'.
If we were only doing a map for desktop/laptops, I wouldn't put much thought into adding the layer control.  My main concern is how it will work on a phone/mobile device.

Closing this, @fawcett and I had conversations outside of GitHub and talked about the effects. Additional editing may come into play later, but as of 8/11 the legend collapses on mobile devices and all layers load on load with the exception of the fun run layer.


Fix CI breakage w/ 22.04

Note: I think once we merge, it will bootstrap the new main and dependency CI will be back in business.


[typescript] withStyles produces wrong Record<never, string> types

This is the problem:
const styled = withStyles(theme => ({
  bg: {
    color: theme.typography.body1.color,
  },
}));

const MyComp = styled(({ classes }) =>
Hi
);
//                                                              ^
//                                                              |
//                   [ts] Property 'bg' does not exist on type 'Record<never, string>'.

[ ] This is a v1.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
The  type should be Record<"bg":string>
Current Behavior
The type is Record<never:string
Steps to Reproduce
See above
Context
The above example works fine if you omit the theme, for example:
const styled2 = withStyles(({
  red: {
    color: 'red'
  },
}));

const MyComp2 = styled2(({ classes }) =>
Hi
);

In this example, Typescript is able to deduce that the type should be var classes: Record<"red", string>
Your Environment

Tech
Version

Material-UI
v3.0.1

React
16.4.2

Browser
X

TypeScript
3.0.3

Visual Code
1.26.1

The typings are a little finicky. Try this:
const styles = (theme: Theme) => ({
  bg: {
    color: theme.typography.body1.color,
  },
});

const MyComp = withStyles(styles)(({ classes }) =>
Hi
);

@pelotom Thanks Pelotom. Providing a parameter type to withStyles  does the trick.
const styled = withStyles( (theme:Theme /* Type required */ ) => ({
  bg: {
    color: theme.typography.body1.color,
  },
}));

const MyComp = styled(({ classes }) =>
Hi
);


fix stuck tooltips on macOS

What does the pull request do?
Fixes stuck tooltips when new window is opened.
What is the current behavior?
As described in #6677 if a tooltip is active when a child window is shown, the tooltip remains active until the mouse is once again moved on the parent window.
What is the updated/expected behavior with this PR?
Tooltip has to disappear when a child window is shown.
Fixed issues
Fixes #6677

@gabornemeth thanks for doing this... can you explain what tracking area is and why its needed to solve the problem?

@danwalmsley With NSTrackingArea you can define a region from what you want to receive notifications in specific events. In this case when the mouse enters and exits this region. The area is set to the bounds of the view. Tracking area is managed by Cocoa with calling some methods like addTrackingArea removeTrackingArea updateTrackingAreas.
I haven't noticed so far that there is already a tracking area defined for the AvnView with name _area. But it is missing the mouse enter/exit flags. Probably I could have used that and don't create a redundant one. I give it a try.

Submitted a revised - and much simpler and smaller - fix which seems to work equally well.


Firefox and nested/numerous flexboxes

Firefox has big problems with flexboxes where Internet Explorer and Chrome display them without issues.
See this link to test : http://codepen.io/anon/pen/dhzJE
The slider allows user to increase the number of flexboxes.
Under IE & Chrome : no latency while dragging the slider left and right, under FireFox, if you scroll too much to the right, Firefox crash… -.-"
Ps : thx philipwalton, flexbugs is a good idea

I'm not getting any crash on OS X Firefox, but Firefox does get pretty laggy, whereas Chrome instantaneously responds to changing the slider.

Yeah I can concur that Firefox lags badly at multiple nested flexboxes. A team here at MS actually uses floats on FF to bypass this, which is always an option but a lot of additional work. It would all depend on the size of the team and site/application.

thx for your feedbacks guys, I should have been more specific with my comment :

Under IE & Chrome : no latency while dragging the slider left and right, under FireFox, if you scroll too much to the right, Firefox crash… -.-"
It was in a Windows 7 x64 environment and up to date browsers.

I am using FF 34.0.5 in Windows 7 Pro x 64 PC and I can confirm that the browser cannot handle multiple nested flexboxes.

I'm testing on FF/Mac as well and also notice a ton of lag and a loading spinner.
@Shuunen have you identified a particular depth at which things get really bad? I'm wondering if there's a cliff or if the progression is linear. If there were a point we could recommend not nesting beyond, that would be ideal.
The point of flexbugs is primarily to be able to offer workarounds. I'm hesitant to add a bug that merely suggests: "Don't nest too much".
Have you submitted this to bugzilla, or is there an existing bug for it?

@Shuunen I don't have too much time to dig into this one, but I don't think it's just because of nesting flex boxes, especially since you're not doing anything fancy with them. I wrote a simple fuzzer and you can up the number of containers to generate. I was able to create 60K containers inside of one another and Firefox did splendidly. It actually outperformed both Chrome and IE 11 (I'm at home doing this so I couldn't test it against IE12) from an end user POV. At any rate, there has to be something more to this, may I suggest reducing your example and pin-pointing what the lag is. Also, do the reduction on your own box locally so that you aren't fighting something that may be a CodePen issue. Thanks!

I've wrote this : http://jsfiddle.net/shuunen/kfq3d1wd/
Here's my browsers :

IE 11 crash at 60K
FF 34 crash at 150K

Maybe the problem is not with nesting, I will investigate more.

I'm not seeing noticeable lag with the original testcase anymore in Firefox 41.

Testing it with static nested flexboxes is not quite correct. Firefox can handle those pretty well.
Firefox is very slow when any of the nested flexbox containers contains changing element. This can be very well seen with contenteditable block inside a several levels of flexbox containers.
If time allows I'll try to create my own fiddle.

While performance is an awesome thing to focus on, that's not necessarily what this repo is for. I recommend filing a bug on Firefox once you have a 100% reproducible scenario. Thanks.


Incompatible with thor 0.19.2 dependency

After upgrading to thor-0.19.2 from thor-0.19.1, the following issue is takes place when running foreman:
/.../lib/ruby/gems/2.3.0/gems/thor-0.19.2/lib/thor/base.rb:534:in `thor_reserved_word?': "run" is a Thor reserved word and cannot be defined as command (RuntimeError)
	from /.../lib/ruby/gems/2.3.0/gems/thor-0.19.2/lib/thor/base.rb:597:in `method_added'
	from /.../lib/ruby/gems/2.3.0/gems/foreman-0.82.0/lib/foreman/cli.rb:80:in `<class:CLI>'
	from /.../lib/ruby/gems/2.3.0/gems/foreman-0.82.0/lib/foreman/cli.rb:11:in `<top (required)>'
	from /.../lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in `require'
	from /.../lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in `require'
	from /.../lib/ruby/gems/2.3.0/gems/foreman-0.82.0/bin/foreman:5:in `<top (required)>'
	from /.../bin/foreman:23:in `load'
	from /.../bin/foreman:23:in `<main>'

Everything works perfectly with thor-0.19.1 and below.

I've been seeing this issue as well with a fresh rails inited project
Here's my Procfile:
web: bundle exec rails s

Running foreman start gives the same error as above.

This is fixed in https://github.com/erikhuda/thor/commit/329cff6692c040fec7dfb67cc1fa742d31d5b97d and released in Thor 0.19.4

Indeed, fixed upstream.


Changes to manager task api for finals.

Add setting to stop game tasks being handed out.
Add setting to change to uniform seeding for the finals.

Add setting to stop game tasks being handed out.

Kinda unneeded. We can kill the workers (after checking that no compiles are going on), then make the change.


Use a should_write callback method to let the caller decide what should and shouldn't get logged.

Fixes https://github.com/Azure/azure-sdk-for-c/issues/1184 and https://github.com/Azure/azure-sdk-for-c/issues/1172
Follow up to https://github.com/Azure/azure-sdk-for-c/issues/1227 and https://github.com/Azure/azure-sdk-for-c/issues/1192
There are several benefits to this design, which I will enumerate shortly.
But first, I would like to get eyes from other folks on it.
More complete and cleaner alternative to https://github.com/Azure/azure-sdk-for-c/pull/1319, https://github.com/Azure/azure-sdk-for-c/pull/1321, with fewer downsides.
TODO:

Changelog update
README update

we need to do the same callback-filter mechanism for retry

I understand. I will do that in a separate PR.


Refactor camel k crd

First iteration to get Camel K CRD in place to reuse as much as possible from Camel model when parsing back and forth.
The idea is to use for parsing and writing the yaml files the official classes that Camel K uses, so we go along with changes and updates.

Some yaml test resources have been changed because now that we are using other classes the order of the attributes changed.

I know this is a classic, but I swear native build works on my machine :/
========================================================================================================================
GraalVM Native Image: Generating 'api-1.0.1-SNAPSHOT-runner' (executable)...
========================================================================================================================
[1/7] Initializing...                                                                                (18.4s @ 0.39GB)
 Version info: 'GraalVM <IP_ADDRESS>-Final Java 17 Mandrel Distribution'
 Java version info: '17.0.7+7'
 C compiler: gcc (redhat, x86_64, 8.5.0)
 Garbage collector: Serial GC

First difference which jumps to me is that you are not using the same version of Graalvm:

Yes, I am trying with this other version of graalvm

native build and native tests?

Yes, sure. Same command
 mvn  install -Pnative -Dquarkus.log.category.\"io.kaoto.backend.model.deployment.kamelet.step.FlowStepDeserializer\".level=OFF

Same version locally it works. Trying to update graalvm here instead... just in case :/

:crossed_fingers: :crossed_fingers:


[archlinux] Make the image follow all the requirements

[x] Add sysctl entry vm.min_free_kbytes=65536
[x] Configure NTP to use internal server.
[x] Configure SSH to only accept login through public keys and deny environment customization to avoid - [ ] errors due to users locale.
[x] Configure default locale to en_US.UTF-8.
[x] Configure network scripts to use DHCP and enable them. Although not, strictly speaking, needed since kernel already has IP address and gateway this allows DHCP hooks to be called for setting hostname, etc.
[x] Install custom DHCP hook for hostname to set entry in /etc/hosts for software using getent_r to get hostname.
[x] Install scripts to fetch SSH keys
[x] Install scripts to fetch kernel modules.
[x] Install scripts to connect and/or mount NBD volumes.
[x] Install scripts to manage NBD root volume.
[x] Disable all physical TTY initialization.
[x] Enable STTY @ 9600 bps.

Original issue: https://github.com/online-labs/image-builder/issues/23

Only one last item to make this image available as an official image?

@s0undt3ch: not really :)
This image is actually ready, the missing item is not the most blocking one.

We want to release this image as a community image and keep our focus on the most used images (ubuntu/debian)/fedora, so today we are just blocked by the web console.
We want to improve the create-server page of the console to highlight the official images and be able to launch more community images, i.e:

move the current gentoo image to community
release the archlinux image
release the openness image
release the slackware image

I've run Debian in the past, Ubuntu, Fedora, these days I also run some CentOS images on a CI server, but, ever since I moved my Dev system to Arch I've never had more fun managing it(Gentoo was fun too but I needed time to develop :smile:)
I know some Arch'ers which I think would at least be tempted to try the C1 approach.
I've been waiting for this image to move my "always running services" to Online Labs(not much these days, I no longer run my own mail server).
Yesterdays I looked again just to check. I don't want to setup an Ubuntu box just to have to set up another one when Arch comes out.
These days I don't have much free time but when I get some, I'll be creating a Online-Labs driver for salt-cloud(We could use CI testing on a C1) . That might bring some additional attention to your project.
Anyway, looking forward to get my hands on an Arch image :)
Sneek preview? :smile:

Hey @s0undt3ch,
I think the image is nearly ready for a beta, IIRC, there was a booting order issue (I'll check this in a couple of hours), so I think we can have a preview very soon!

Awesome!

LGTM :ok_hand:

First version released !

We experienced a kernel panic during a reboot, probably due to the nbd service in the stop sequence order.
If you encounter this behaviour, just click on Hard reboot on the web console.
Related issue: #5

If you encounter any other issues, you are free to open new issues/PR

I don't know if here is the correct place to ask for it.
Is it possible to install Arch Linux on the armv8/64 instances?


Bug: auto env in Bash works only once

Bug report
It seems that if a directory contains .sdkmanrc then in Bash it works only once (to be precise the version is changed once when entering the dir and then reset when leaving it). Subsequent cd doesn't set the version as set in .sdkmanrc.
To reproduce
In Bash cd into directory having .sdkmanrc, then cd -. The changes of e.g. JDK happen as expected.
Then repeat, nothing happens in Bash.
This is different from zsh, zsh changes the JDK every time when 'visited'.
Expected flow in zsh:
krypa% cat /tmp/envTest/.sdkmanrc
# Enable auto-env through the sdkman_auto_env config
# Add key=value pairs of SDKs to use below
java=15.0.2.hs-adpt
krypa% pwd
/tmp
krypa% cd envTest

Using java version 15.0.2.hs-adpt in this shell.
krypa% cd -
/tmp
Restored java version to 11.0.9.hs-adpt (default)
krypa% cd -
/tmp/envTest

Using java version 15.0.2.hs-adpt in this shell.
krypa% cd -
/tmp
Restored java version to 11.0.9.hs-adpt (default)

Perhaps fault flow with Bash?
piotr@krypa:/tmp$ cd envTest/

Using java version 15.0.2.hs-adpt in this shell.
piotr@krypa:/tmp/envTest$ cd -
/tmp
Restored java version to 11.0.9.hs-adpt (default)
piotr@krypa:/tmp$ cd -
/tmp/envTest
piotr@krypa:/tmp/envTest$ cd -
/tmp
piotr@krypa:/tmp$

System info

Ubuntu 18.04
Shell and version (GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu))
The output of sdk version: SDKMAN 5.10.0+617

Hi!
It seems to work if after going to the default version (that is the first cd - from the example above) I manually clean the env variable: unset SDKMAN_OLD_PWD.

It's a regression I've introduced when fixing another bug. I'll fix it ASAP.

Unsetting SDKMAN_OLD_PWD was a great pointer, I could fix the bug within minutes. I've also recognized that the auto env could be improved, in that the .sdkmanrc should not be re-read for folders beneath the folder where the .sdkmanrc is located.

Thanks for prompt fix, @helpermethod . I was trying to fix it locally, so even without much luck, I shared the findings. Saves time for maintainers ;-)


Nomination Pools

polkadot companion: https://github.com/paritytech/polkadot/pull/5308
To open rust docs run
cargo doc --package pallet-nomination-pools --open

TODO

[x] decide create + destroy logic
[x] tests
[x] benchmarks
[x] factor out slashing changes into its own PR as a pre-req for this: https://github.com/paritytech/substrate/pull/10982

future work

https://github.com/paritytech/substrate/issues/10792
https://github.com/paritytech/substrate/issues/10793
https://github.com/paritytech/substrate/issues/10860
https://github.com/paritytech/substrate/issues/10861
https://github.com/paritytech/substrate/issues/10862 <-- high priority
https://github.com/paritytech/substrate/issues/10902
https://github.com/paritytech/substrate/issues/10903 <-- high priority

/benchmark runtime pallet pallet_nomination_pools

Is it possible to get this branch building again? (It used to build)
  error[E0277]: the trait bound `PoolState: Clone` is not satisfied
      --> /Users/jacogr/Projects/parity/rust-substrate/frame/nomination-pools/src/lib.rs:1444:4
       |
  1444 |             state: PoolState,
       |             ^^^^^ the trait `Clone` is not implemented for `PoolState`

  For more information about this error, try `rustc --explain E0277`.

Let's target merging this by Monday, given we do:

[ ] If you are 100% okay with #11212, merge it in here, although not strictly needed
[ ] Rename "Delegator" to "PoolNominator". Let's do this in an isolated commit in case we change our minds again.

Delegators renamed to PoolMembers in 7aa9f43

/benchmark runtime pallet pallet_nomination_pools

/benchmark runtime pallet pallet_nomination_pools

bot merge

bot merge force

bot merge


Store Collections in the browser's Sync Storage

As mentioned in #47, #39 , and #43
This reworks a few things :

[x] Extract some blocks into methods, such as the backward compatibility method and storage related methods.

[x] Store collections as objects and not as stringified JSON. That gets rid of the need for parsing and stringifying all the time, which is not needed with chrome storage as it can directly store objects.

[x] The background script now listens for storage changes, and sends the collections updates to open panes. This makes sure that any sudden sync will be properly propagated, even when the pane is closed.
This also allow us to call UpdateTheme UpdateBadgeCounter whenever a collection is added from the cloud sync.
Ideally the same mechanism would be used for the settings, as the many listeners in the aside script are starting to build up. I'll work on that on another PR for 2.0 as it may introduce another backward compatibility mechanism

[x] Rework thumbnail storage. Thumbnails can't be stored in chrome.storage.sync, as they go way over the quota. This prevents any collection with a thumbnail from being saved. Thumbnails and icons URL are now stored in the chrome local storage.

[x] Rework Collection storage. The "collections" item is no longer an array, but an object, and each individual collection is stored in its own storage item (I've done this with "set_<timestamp>" as their key). Considering the sync storage has a per_item quota that is much lower than the overall quota, this was necessary to not be too limited.

[x] Compress strings to allow for more tabs to be saved without exceeding the quotas. This uses the LZUTF8 library, under MIT license, so no problem including it here.

[x] Added backend code to save a collection to the favorites.

[x] If a collection from pre-v2 is too big to be saved, or there is another issue migrating the data, that collection is saved in the browser's bookmarks.

[x] Test backwards compatibility to ensure no tabs are lost on upgrade

[x] Enabled sync storage by default, with a toggle variable that is (currently ? ) not exposed to the user
The code remains flexible so that it can be changed in the future, if we ever get feedback that some people need more storage than what the sync mechanism offers, we could make sync togglable.

[ ] Update localization strings for languages other than english

[x] RU
[x] IT
[x] PT_BR
[ ] ES
[x] ZH_CN

I've tested and fixed regression issues on chromium before sending the PR, as well as sync.

I think it'd be fine to store the thumbnails in HTML5's localStorage, just like it was done before for the collections, remove them from the collections variable, and join these two storages when they are used.
For example, the url of a collection item could be the key to its thumbnail in the localStorage.
What do you think about it ? It has quite the architectural impact, so I want to be sure you're okay with the approach before trying something out.

Seems legit. So sure, go ahead

@AmineI, hi. Are you still working on the PR? If you changed your mind I can take care of it and complete it myself

Hi ! I just got your approval recently to go ahead with the separation of collections/thumbnails data, and didn't get back to that yet ! Busy week as usual. But if you want to work on it just tell me and it's okay ! Otherwise I'll see if I can find enough time to implement that during the week-end

@AmineI no, it's ok. Just was checking if you still have intentions to work on it. There's no any deadline, so we can do it in our pace

@AmineI, hi. How is it going? Remember I said that there's no hurry? Slight change of plans. (Un?)fortunately there have been a lot of new PRs with features and tweaks to the project. But I can't push them to production since the main feature of 2.0 release is missing. So, if you complete it asap it would be great!

@AmineI, hi. How is it going? Remember I said that there's no hurry? Slight change of plans. (Un?)fortunately there have been a lot of new PRs with features and tweaks to the project. But I can't push them to production since the main feature of 2.0 release is missing. So, if you complete it asap it would be great!

Hello there ! Apologies, things got quite busy here with a curfew, a lot of things to deal with, and now another lockdown - and I lost track. Busy week this time too :x .
I do have a clear plan of just creating a thumbnails storage in the local storage, and using it with urls as keys of this storage, as mentioned previously - I got familiar with the codebase and it shouldn't take too much time, especially since it's the only thing left along with another round of testing.
I'd really love to work on that this week-end, but I can't definitely promise as I keep having urgent things piling up (and we saw how it ended last time I said "maybe this week-end" :P).

If you're in a hurry, you'll definitely be faster just completing this yourself :/ . A middle ground to agree on would be that if I still can't manage to finish it this week-end, I'll ask you to take over that last thing. What do you think ?

I see... Well, I could continue your PR, but I think it's not a good idea to touch someone's unfinished code, especially, trying to fix something in it. So, since you've already started your work on the issue and even are close to the end, I'd rather prefer you to complete it to avoid potential code quality degradation. Plus, ASAP literally means "as soon as possible". So, if it's impossible to do it right now, then it's ok. But it would be great if it will be done when it will be possible to do so ¯_(ツ)_/¯

Hello there ! I've completed the separation of thumbnails and collections, and it essentially works.
By essentially, I mean that everything works, displays thumbnails locally, and syncs between machines (except the thumbnails ofc), but the item quota for the sync storage is so small that even without the thumbnails, it gets filled with ~50 tabs.
But, let's face it, 50 tabs is not nearly enough.
Here are the quotas on Chromium browsers such as Edge:
>chrome.storage.sync.QUOTA_BYTES_PER_ITEM
8192
>chrome.storage.sync.QUOTA_BYTES
102400

//Local Storage for comparison, which does not sync :
>chrome.storage.local.QUOTA_BYTES
5242880
// (but can be unlimited with a permission in the manifest)

All collections are saved in a single "sets" item, so the 8192B per item quota is reached with around 50 tabs ( of "Youtube Rewind 2019" https://www.youtube.com/watch?v=2lAe1cqCOXo during my testing. )
We can multiply this limit by ~12 if we store collections in different items in the storage (max 512), but that adds complexity to saving and loading. I think I can handle it, though.
We can also multiply this limit by a whole lot with compression. LZUTF8 looks promising for example
I'll push my current approach first, and look into these two points next to actually make it useable

I just added truncating titles > 100 characters as a way to avoid one tab killing the quota alone, do you agree with that idea ? I can revert that commit otherwise, or just change the 100char threshold.

With compression, truncating long titles (>70chars), offloading thumbnails and favicons to the local storage, and a few other tricks, I was able to raise the limit to ~130 different tabs in a single collection. Considering we have 12.5 times this storage, that is 1625 tabs across the whole chrome sync storage; distributed among max 512 collections.
It looks good to me, way better than last time.
A few last checks and tests, such as migrating from an older version, and I'll push that 😃 .
I'll definitely be glad once this is finally done ! This sync feature caused so many changes, and some limitations - hopefully my implementation will be satisfying to you. Don't hesitate to request changes if it does not meet your standards or if you're not happy with something, or even refuse the PR (I'll be sad but I'll understand, I promise :p)

Whoa! That's an incredible work! I've walked through the files and they seem good so far. I just need more time to fully review the PR, but I don't think I'll find anything worse than styling issues. Great work, thank you!

Whoa! That's an incredible work! I've walked through the files and they seem good so far. I just need more time to fully review the PR, but I don't think I'll find anything worse than styling issues. Great work, thank you!

Thanks :) - no worries for the review !
Should anything be unclear, don't hesitate to ping me.
Ah, styling issues - I tried to follow the contributing guidelines you made, and for some cases I just followed the existing code formats, but I may have let some slip past me... Line breaks for example, sometimes 2, sometimes 1.

@amandafilizola, @Dustin-Jiang, @blackcat-917, @Wafflects, hi, guys! Need your help again. These lines need to be translated. This time you can make a PR to this branch of @AmineI's repo. Or you can just post translated strings here. The first option is preferable since in this case it will affect your contribution stats and you will be stated as contributors to the repo in GitHub

I went ahead and merged major-2.0 on this branch, in order to carefully deal with all the merge conflicts. I thus changed the base branch for this PR to major-2.0 so that the diff is not filled with 2.0 updates

Again, carefully reviewed conflicts, this branch is now in sync with major-2.0 .
I'll do a last commit with style & whitespace changes, and I'll have nothing left to add I believe.
(You can use the feature "Hide whitespace changes" in the diff view to make things easier for you)

hi, guys! Need your help again. These lines need to be translated. This time you can make a PR to this branch of @AmineI's repo. Or you can just post translated strings here. The first option is preferable since in this case it will affect your contribution stats and you will be stated as contributors to the repo in GitHub

@Dustin-Jiang, @Wafflects, hi, guys. I still need your assistance. It will be much better if provided translation won't be a google-translated

How is it going ? Do you want to go ahead with a machine translation in the meantime ?

@AmineI omg, yes please! I've completely forgot about the project. These days are kinda rough

@AmineI hi, Can you check the PR for one more time please? I'm about to merge, so I'd like to make sure that it won't break anything. It seems fine for me but who knows

@AmineI hi, Can you check the PR for one more time please? I'm about to merge, so I'd like to make sure that it won't break anything. It seems fine for me but who knows

I've just seen this - Sure, I'll also test all scenarios on the browser for extension upgrade/new installs one more time - Thanks for taking care of the translations as well ! I think some of the translations for this were merged on your 2.0 branch instead of this one, so we may have to recheck them after this gets merged/rebased


client: use WithContext pattern

Currently using telegram.Client requires passing context.Context to almost all method invocations. However, in most cases we just use the context passed to Run “callback” function.
We can make the use of context optional and default to background context using the WithContext pattern.
Before
err := client.Run(context.Background(), func(ctx context.Context) error {
	if err := client.AuthIfNecessary(ctx, authFlow); err ≠ nil {
		return err
	}
	self, err := client.Self(ctx)
	if err ≠ nil {
		return err
	}
	fmt.Println(self)
	return nil
})

After (context-free)
err := client.Run(func(client *telegram.Client) error {
	if err := client.AuthIfNecessary(authFlow); err ≠ nil {
		return err
	}
	self, err := client.Self()
	if err ≠ nil {
		return err
	}
	fmt.Println(self)
	return nil
})

After (using context)
ctx := req.Context()
ctx, cancel := context.WithCancel(ctx)
err := client.WithContext(ctx).Run(func(client *telegram.Client) error {
	if err := client.AuthIfNecessary(authFlow); err ≠ nil {
		return err
	}
	self, err := client.Self()
	if err ≠ nil {
		return err
	}
	return doSomething(client.Context(), self)
})

Context is used to control the lifetime of request, connection or client. Also we can use it pass different values to trace request execution (see #172).
Request lifetime may be is not equal to client lifetime, so I see no reason why methods client methods should not have context.Context parameter.

Indeed, but this proposal doesn’t prevent you from passing context per request, e.g.
client.WithContext(ctx).Self()

Usually you’d do a series of operations with single context, on one client. So passing ctx each time seems redundant.

client.WithContext(ctx).Self()

Where is context of request should be stored?

Besides, currently the only context we can reasonably pass to the client is the one in func(ctx context.Client) error callback. And anything other than that would require some non-trivial hacks to merge at least callback context cancellation with user’s context.

Where is context of request should be stored

Just to be clear, WithContext pattern usually assumes shallow copies of the object context is attached to.
That is, a possible implementation would have

an internal *baseClient that implements context-based APIs,
and a public *Client that invokes methods on internal client using the attached context.

Where is context of request should be stored

Just to be clear, WithContext pattern usually assumes shallow copies of the object context is attached to.
That is, a possible implementation would have

an internal *baseClient that implements context-based APIs,
and a public *Client that invokes methods on internal client using the attached context.

If you want API without context.Context, so you can add your own builder.
I see no reason why gotd  should provide this functionality. WithContext is not a pattern, I don't know any project which uses it.
The *baseClient/Client  separation produces API duplication, you must to not forget to add the same method to two different structures.

https://blog.golang.org/context-and-structs

Contexts should not be stored inside a struct type, but instead passed to each function that needs it.

Thanks for consideration! I understand your point, though I don’t agree that it’s a strict rule, and telegram.Client looks like a potential exception to me. It’s not a critical issue though, so I’m fine with closing this.


Refactor DSOReportbackItem image property

The image property is writable so that when a User submits a reportback, we don't have to query the API to get the photo back when we display it in the Post-Reportback state.
For most reportbacks however, it won't be set, we'll only have an imageURL. Ideally the image getter function should use SDWebImage to return a UIImage based on the imageURL if we don't already have an image set.
Then we can change this line in the Detail VC from:
UIImage *shareImage = cell.detailView.reportbackItemImage;
to
UIImage *shareImage = self.currentUserReportback.image;

Looking at this issue a few weeks later, and it doesn't seem that bad to use the image we already have from the given LDTCampaignDetailSelfReportbackCell's imageView instead of just a DSOReportback.image property. If we used downloadImageWithURL for the scenario where the Reportback.image is not set (which is most) in the init method, we may be making requests when we don't need to. Going to leave this is as .


Update README.md

Description
[Task name](link to task on the board goes here)
Description of the task you completed and/or features added. If it is a visual component or feature,
add a screenshot(s) of it.
Acceptance Criteria
Get the acceptance criteria for the story and/or task you are working on and put it all here.
Test Instructions

Steps on...
how to test...
or inspect this...
feature manually.

Help Requested

Things that you (the submitter)...
want reviewers to pay very close...
attention to when they review this PR.

Checklist

[ ] Strings use placeholders for translation (No hard coded strings)
[ ] Unit tests have been added/updated
[ ] Update CHANGELOG

Product and Sprint Backlog
Jira

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1275822898.azurewebsites.net

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1275822898.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1275822898.azurewebsites.net


Extended Timeouts for "Slow" Infrastructures

What would be a way to support also "slow" infrastructures (custom OpenStack in this case) that need more time for machine creation (more than the default of 10 mins for the health reconciliation) or F5 LB creation (likewise) and thereby avoiding a failure on the first run (eventually it will pass, because Gardener keeps trying for longer, but the first impression on these landscapes is a failure at first).

I just went through a shoot creation on Azure and seems like its better now, i only saw the issue below.
I simply watched the kubectl get shoot bekirtest -o yaml -w | sed -n '/^status:/,/apiVersion:/p'  output during the creation and here is an issue that the initial reconciliation hit 4 times in a row until it eventually succeeds.
  lastOperation:
    description: "Flow \"Shoot cluster reconciliation\" failed: 1 error occurred:\n\t*
      task \"Reconciling Shoot workers\" failed: timed out after 45.123480264s, last
      error: Failed while waiting for all machine deployments to be ready: 'Machine
      shoot--test--bekirtest-cpu-worker-6f54c9db78-tnvzz failed: Cloud provider message
      - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 --
      Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\"
      Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes
      not found.\" Details=[]'\n\n Operation will be retried."
    lastUpdateTime: 2018-11-05T15:23:01Z
    progress: 82
    state: Error
    type: Create

Its first kicked in 2018-11-05T15:20:16Z then first error was reported on 2018-11-05T15:23:01Z and kept failing until 2018-11-05T15:27:30Z and shoot creation completed on 2018-11-05T15:29:17Z
[msa-sandbox-garden:test]k8s-clusters: (enable-network-policies $ u=) $ kubectl -n garden logs gardener-controller-manager-ccc974454-cqczb | grep bekirtest | grep "Reconciling Shoot workers" | sed "s/$subs/xxx/g"
time="2018-11-05T15:21:01Z" level=error msg="Failure: timed out after 45.123480264s, last error: Failed while waiting for all machine deployments to be ready: 'Machine shoot--test--bekirtest-cpu-worker-6f54c9db78-tnvzz failed: Cloud provider message - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\" Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes not found.\" Details=[]'" flow="Shoot cluster reconciliation" opid=b8Vjn8LJ shoot=test/bekirtest task="Reconciling Shoot workers"
time="2018-11-05T15:23:01Z" level=error msg="Failed to reconcile Shoot \"bekirtest\": 1 error occurred:\n\t* task \"Reconciling Shoot workers\" failed: timed out after 45.123480264s, last error: Failed while waiting for all machine deployments to be ready: 'Machine shoot--test--bekirtest-cpu-worker-6f54c9db78-tnvzz failed: Cloud provider message - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\" Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes not found.\" Details=[]'\n\n\nflow \"Shoot cluster reconciliation\" failed\ngithub.com/gardener/gardener/pkg/utils/flow.(*execution).run\n\t/go/src/github.com/gardener/gardener/pkg/utils/flow/flow.go:258\ngithub.com/gardener/gardener/pkg/utils/flow.(*Flow).Run\n\t/go/src/github.com/gardener/gardener/pkg/utils/flow/flow.go:95\ngithub.com/gardener/gardener/pkg/controller/shoot.(*defaultControl).reconcileShoot\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control_reconcile.go:206\ngithub.com/gardener/gardener/pkg/controller/shoot.(*defaultControl).ReconcileShoot\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control.go:261\ngithub.com/gardener/gardener/pkg/controller/shoot.(*Controller).reconcileShootKey\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control.go:116\ngithub.com/gardener/gardener/pkg/controller/shoot.(*Controller).(github.com/gardener/gardener/pkg/controller/shoot.reconcileShootKey)-fm\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot.go:260\ngithub.com/gardener/gardener/pkg/controller/utils.worker.func1.1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:52\ngithub.com/gardener/gardener/pkg/controller/utils.worker.func1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:61\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88\ngithub.com/gardener/gardener/pkg/controller/utils.CreateWorker.func1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:33\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:2361" opid=b8Vjn8LJ shoot=test/bekirtest
time="2018-11-05T15:25:06Z" level=error msg="Failure: timed out after 30.837822511s, last error: Failed while waiting for all machine deployments to be ready: 'Machine shoot--test--bekirtest-cpu-worker-6f54c9db78-ns65x failed: Cloud provider message - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\" Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes not found.\" Details=[]'" flow="Shoot cluster reconciliation" opid=0985MuXD shoot=test/bekirtest task="Reconciling Shoot workers"
time="2018-11-05T15:25:10Z" level=error msg="Failed to reconcile Shoot \"bekirtest\": 1 error occurred:\n\t* task \"Reconciling Shoot workers\" failed: timed out after 30.837822511s, last error: Failed while waiting for all machine deployments to be ready: 'Machine shoot--test--bekirtest-cpu-worker-6f54c9db78-ns65x failed: Cloud provider message - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\" Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes not found.\" Details=[]'\n\n\nflow \"Shoot cluster reconciliation\" failed\ngithub.com/gardener/gardener/pkg/utils/flow.(*execution).run\n\t/go/src/github.com/gardener/gardener/pkg/utils/flow/flow.go:258\ngithub.com/gardener/gardener/pkg/utils/flow.(*Flow).Run\n\t/go/src/github.com/gardener/gardener/pkg/utils/flow/flow.go:95\ngithub.com/gardener/gardener/pkg/controller/shoot.(*defaultControl).reconcileShoot\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control_reconcile.go:206\ngithub.com/gardener/gardener/pkg/controller/shoot.(*defaultControl).ReconcileShoot\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control.go:261\ngithub.com/gardener/gardener/pkg/controller/shoot.(*Controller).reconcileShootKey\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control.go:116\ngithub.com/gardener/gardener/pkg/controller/shoot.(*Controller).(github.com/gardener/gardener/pkg/controller/shoot.reconcileShootKey)-fm\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot.go:260\ngithub.com/gardener/gardener/pkg/controller/utils.worker.func1.1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:52\ngithub.com/gardener/gardener/pkg/controller/utils.worker.func1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:61\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88\ngithub.com/gardener/gardener/pkg/controller/utils.CreateWorker.func1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:33\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:2361" opid=0985MuXD shoot=test/bekirtest
time="2018-11-05T15:26:38Z" level=error msg="Failure: timed out after 30.352762862s, last error: Failed while waiting for all machine deployments to be ready: 'Machine shoot--test--bekirtest-cpu-worker-6f54c9db78-ns65x failed: Cloud provider message - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\" Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes not found.\" Details=[]'" flow="Shoot cluster reconciliation" opid=ap4HIMrS shoot=test/bekirtest task="Reconciling Shoot workers"
time="2018-11-05T15:26:38Z" level=error msg="Failed to reconcile Shoot \"bekirtest\": 1 error occurred:\n\t* task \"Reconciling Shoot workers\" failed: timed out after 30.352762862s, last error: Failed while waiting for all machine deployments to be ready: 'Machine shoot--test--bekirtest-cpu-worker-6f54c9db78-ns65x failed: Cloud provider message - network.SubnetsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code=\"NotFound\" Message=\"Resource /subscriptions/xxx/resourceGroups/shoot--test--bekirtest/providers/Microsoft.Network/virtualNetworks/shoot--test--bekirtest/subnets/shoot--test--bekirtest-nodes not found.\" Details=[]'\n\n\nflow \"Shoot cluster reconciliation\" failed\ngithub.com/gardener/gardener/pkg/utils/flow.(*execution).run\n\t/go/src/github.com/gardener/gardener/pkg/utils/flow/flow.go:258\ngithub.com/gardener/gardener/pkg/utils/flow.(*Flow).Run\n\t/go/src/github.com/gardener/gardener/pkg/utils/flow/flow.go:95\ngithub.com/gardener/gardener/pkg/controller/shoot.(*defaultControl).reconcileShoot\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control_reconcile.go:206\ngithub.com/gardener/gardener/pkg/controller/shoot.(*defaultControl).ReconcileShoot\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control.go:261\ngithub.com/gardener/gardener/pkg/controller/shoot.(*Controller).reconcileShootKey\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot_control.go:116\ngithub.com/gardener/gardener/pkg/controller/shoot.(*Controller).(github.com/gardener/gardener/pkg/controller/shoot.reconcileShootKey)-fm\n\t/go/src/github.com/gardener/gardener/pkg/controller/shoot/shoot.go:260\ngithub.com/gardener/gardener/pkg/controller/utils.worker.func1.1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:52\ngithub.com/gardener/gardener/pkg/controller/utils.worker.func1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:61\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/go/src/github.com/gardener/gardener/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88\ngithub.com/gardener/gardener/pkg/controller/utils.CreateWorker.func1\n\t/go/src/github.com/gardener/gardener/pkg/controller/utils/worker.go:33\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:2361" opid=ap4HIMrS shoot=test/bekirtest
time="2018-11-05T15:27:35Z" level=info msg=Succeeded flow="Shoot cluster reconciliation" opid=OQihQWw0 shoot=test/bekirtest task="Reconciling Shoot workers"

We are seeing the same @bergerx. The infrastructure creation job succeeded (which is responsible for creating the subnet), however, when the machine-controller-manager tries to fetch it from the Azure API it answers with 404 Not Found.


Add '.rsrc' extension

Apple binary format https://file.org/extension/rsrc

Are they still used today in modern computers? Seems to be a legacy file.


Performance issue in unity webGL (Huge drop in FPS as soon as video chat is switched on)

Hi,
I have integrated Agora in my mobile(Android) webGL games.
Without Agora I was getting 50+ FPS but as soon as I start the video chat I get a huge performance hit the FPS drop to 2-5 frames per sec. and it gradually increased to 20 frames over the period of 20-40 sec.
When I build the same game as Android APK instead of WebGL build the FPS is stable and I get 60+ Frames per second. with video chat on.
Regards,
Abhishek

Hello, did you have any profiling data to share about this? e.g. what process is chewing up the CPU on WebGL? Also, are you running on Chrome and did you turn on WebGL v2.0 with hardware acceleration?
About comparison to Android - this is not a good comparison because they are totally different architecture.  And you shouldn't expect Web game can do any better than native.


Update IINA to 0.0.8

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as f5ec7b543d4cba5e6acfaccea9428f6ef3e92702. Your contribution is still credited to you.


AttributeError coming from base_layer

System information

Have I written custom code (as opposed to using example directory):  no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  python:3.6-slim docker image (Debian) https://github.com/docker-library/python/blob/35566cb6b14961c369e935b85b4c8879e6901ccc/3.6/buster/slim/Dockerfile
TensorFlow backend (yes / no):  yes
TensorFlow version:  1.14.0
Keras version:  2.3.0
Python version:  3.6
CUDA/cuDNN version:  N/A (running on cpu for inference)
GPU model and memory:  N/A (running on cpu for inference)

You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
You can obtain the Keras version with:
python -c 'import keras as k; print(k.version)'
Describe the current behavior
I am trying to initialize a model and I am running into an error coming from the base_layer class. The same code was working in Keras 2.2.5, but is now breaking with Keras 2.3.0
It looks like the _thread._local object doesn't have a value
https://stackoverflow.com/questions/20640679/thread-local-object-has-no-attribute
Describe the expected behavior
Initialize a model without this issue.
Code to reproduce the issue
from keras.models import Model, Input
input_text = Input(shape=(self.max_len,), dtype="string")
Other info / logs
Traceback (most recent call last):
input_text = Input(shape=(50,), dtype="string")
File "/usr/local/lib/python3.6/site-packages/keras/engine/input_layer.py", line 178, in Input
input_tensor=tensor)
File "/usr/local/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/keras/engine/input_layer.py", line 40, in init
super(InputLayer, self).init(dtype=dtype, name=name)
File "/usr/local/lib/python3.6/site-packages/keras/engine/base_layer.py", line 110, in init
self.input_spec = None
File "/usr/local/lib/python3.6/site-packages/keras/engine/base_layer.py", line 1215, in setattr
if not _DISABLE_TRACKING.value:
AttributeError: '_thread._local' object has no attribute 'value'
The changes to keras base_layer that are currently causing this issue came from this commit:
https://github.com/keras-team/keras/commit/479fc3a978221bb835f7e2781dcef0db66c96e1c

It sounds like you're using or defining a Keras model in multiple threads concurrently. Could you provide a complete runnable code snippet to reproduce the issue?

I have fixed this issue on master. Please install from master and check.

that has fixed that issue. Thanks for the quick turnaround!


Create project button throws error

Describe the bug

Screenshots

Hi @mohitsharma-22  the issue occured, since maximum file upload size in nginx configuration size was set as 2MB in production environment server . The maximum file upload size is now updated to  8MB. Can you please confirm is the issue is resolved in production environment.

@dsajwan2020 The issue is resloved. Thanks.

Closing this issue as it has been fixed  in production environment.


Implemented suggested improvements from guide moderation

I removed the loop parameter from the advance and back functions because it made it a little overly complicated and I went with pad instead of fit because the result was more along the lines of what I was actually trying to do.

nice, so kleen - is it any faster?

Actually, it does seem a bit faster.


api: support generate verilator emulator dl

I'm wondering why do we need this?

I'm wondering why do we need this?

Another team needs to use an RTL-level RISC-V core simulator in a cpp project. By adding dl interface, they can easily run core with difftest in their project.
As difftest is a little bit messy for now, this feature will not be merged. It will stay in an independent branch.


511 - Script - Existing script doesn't overwrite Feature Service

The existing script does a delete and then new publishing for the Feature Service.  This causes an issue where the Feature Service item definitions (like sharing) are lost.  The script should do an overwrite to the existing Feature Service --- or, we need to figure out how to maintain the sharing property on the service so that it doesn't go dark ...

This issue is now being tracked in devtopia.


Xnero: Watch casbay.com

Xnero requests the watch of the watch_keyword casbay\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Mast in Charcoal HQ

casbay\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Add support for Driver API

Can you add support for the Uber Driver APIs? Here is an example diff from the python sdk.

Thanks for the request @dustinwhittle! Sounds like a plan, and coincidentally last night before bed, I was reading through the docs at https://developer.uber.com/docs/drivers/introduction so it's cool to see it implemented for Python. I'll work on this.

Alright, so the progress of methods:

[X] GetDriverProfile implemented by PR https://github.com/orijtech/uber/pull/50
[X] List driver payments implemented by PR https://github.com/orijtech/uber/pull/51
[  ] List driver trips -- unimplemented

And with all those methods implemented, that concludes the implementation of the new API!!
Now I'll wait on my API being given full access and then run each example and test again.
Thank you @dustinwhittle for requesting for this!

Awesome, thanks!

Cheers 🍻


Tableland doesn't work as a JS module

Describe the bug
Can't import the Tableland sdk directly into the browser and run.
To Reproduce
Create an HTML file w/
<script type="module">
  import { connect } from "https://cdn.skypack.dev/<EMAIL_ADDRESS>  const tableland = await connect({ network: "testnet", chain: "polygon-mumbai" });
  console.log(tableland)
</script>
<body></body>

Expected behavior
Should log something.
Instead
Uncaught ReferenceError: Buffer is not defined

Thanks for reporting this!  Looks like the siwe dependency is being bundled in such a way that it's not finding the Buffer polyfill.
@carsonfarmer has a wip refactor of that will include the removal of the relayed testnet chain calls.  That will remove our need to use siwe and this issue should be fixed at that point.

I looked into this some more. Tableland works as a module when I bundle it with webpack and other bundlers.
This issue is specific to Skypack as far as I can tell, and the easy fix is to wait until we remove our siwe dependency which will happen with v4 of the sdk.

This should be working now that siwe is not a dependency.
I'm closing as part of the Linear sync.  If anyone on the Tableland team runs into this again, reopen in Linear.


libkml not found during build

Seeing this in my builds - I'll look into it, but also posting here for visibility.
checking for LIBKML... yes
checking if libkml can be linked... no
checking for Google libkml headers in /Users/msarahan/miniconda3/conda-bld/libgdal_1508343368879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include, /Users/msarahan/miniconda3/conda-bld/libgdal_1508343368879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include/kml, and /Users/msarahan/miniconda3/conda-bld/libgdal_1508343368879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include/kml/third_party/boost_1_34_1... not found
checking for Google libkml... no

This seems to be caused by boost not being available at build time.  It should have been a runtime req of libkml, so this was a bug in the libkml recipe.

Mike, I am away from office with limited connection. I'll check it as soon
as I get back.
On Oct 18, 2017 1:27 PM, "Mike Sarahan"<EMAIL_ADDRESS>wrote:

Seeing this in my builds - I'll look into it, but also posting here for
visibility.
checking for LIBKML... yes
checking if libkml can be linked... no
checking for Google libkml headers in /Users/msarahan/miniconda3/conda-bld/libgdal_1508343368879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include, /Users/msarahan/miniconda3/conda-bld/libgdal_1508343368879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include/kml, and /Users/msarahan/miniconda3/conda-bld/libgdal_1508343368879/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include/kml/third_party/boost_1_34_1... not found
checking for Google libkml... no
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/conda-forge/libgdal-feedstock/issues/15, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA6BL2RGG1UJYM5PWkGxCMf7PGQ6r69nks5stib7gaJpZM4P9_dy
.

oh no, not a bug in your recipes.  I meant ours.  We're doing all the kooky stuff.  As I'm replacing the many explicit run reqs with run_exports stuff instead, this kind of issue is common.
I have libgdal compiling and passing the tests fine.  I'll be working on the other stuff soon.