Uncaught TypeError: Cannot read property 'offsetTop' of null

[Enter steps to reproduce below:]

git timemachine
move mouse around in one timemachine pane

Atom Version: 1.9.9
System: Mac OS X 10.11.5
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Cannot read property 'offsetTop' of null
At /Applications/Atom.app/Contents/Resources/app.asar/src/block-decorations-component.js:82

TypeError: Cannot read property 'offsetTop' of null
    at BlockDecorationsComponent.module.exports.BlockDecorationsComponent.measureBlockDecorations (/Applications/Atom.app/Contents/Resources/app.asar/src/block-decorations-component.js:82:29)
    at TextEditorComponent.module.exports.TextEditorComponent.readAfterUpdateSync (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:284:73)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-component.js:3:61
    at ViewRegistry.module.exports.ViewRegistry.performDocumentUpdate (/Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:225:9)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:3:61

Commands
     -0:38.4.0 core:copy (atom-text-editor.editor.is-focused)
     -0:37 core:move-down (atom-text-editor.editor.is-focused)
     -0:36.1.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -0:35.5.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
  8x -0:35 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -0:33.2.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -0:32.8.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
  2x -0:32.2.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -0:28.1.0 core:copy (atom-text-editor.editor.is-focused)
     -0:26.4.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:25.9.0 core:move-up (atom-text-editor.editor.is-focused)
     -0:25.5.0 core:move-down (atom-text-editor.editor.is-focused)
  4x -0:25.3.0 core:move-left (atom-text-editor.editor.is-focused)
     -0:23.9.0 core:move-right (atom-text-editor.editor.is-focused)
  2x -0:23.3.0 core:move-up (atom-text-editor.editor.is-focused)
     -0:11 git-time-machine:toggle (atom-workspace.workspace.scrollbars-visible-when-scrolling.seti-icons.seti-roboto.seti-animate.theme-one-dark-syntax.theme-seti-ui)

Config
{
  "core": {
    "themes": [
      "seti-ui",
      "one-dark-syntax"
    ]
  },
  "editor": {
    "showIndentGuide": true,
    "tabLength": 4
  }
}

Installed Packages
# User
activate-power-mode, v0.8.1 (active)
atom-beautify, v0.29.10 (active)
atomic-chrome, v0.3.0 (active)
auto-detect-indentation, v1.2.0 (active)
autoclose-html, v0.23.0 (active)
autocomplete-python, v1.8.6 (active)
django-templates, v0.5.0 (active)
git-time-machine, v1.5.3 (active)
highlight-selected, v0.11.2 (active)
hyperclick, v0.0.37 (active)
integrated-learn-environment, v1.9.0 (inactive)
linter, v1.11.16 (active)
linter-flake8, v1.13.2 (active)
merge-conflicts, v1.4.4 (active)
minimap, v4.24.7 (active)
minimap-codeglance, v0.4.5 (active)
minimap-find-and-replace, v4.5.1 (active)
minimap-highlight-selected, v4.4.0 (active)
minimap-linter, v1.1.1 (active)
seti-ui, v1.3.2 (active)
split-diff, v1.0.4 (inactive)
Sublime-Style-Column-Selection, v1.7.2 (active)
tabs-to-spaces, v1.0.2 (active)
todo-show, v1.7.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.51.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.43.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.3.2 (inactive)
one-light-ui, v1.3.2 (inactive)
one-dark-syntax, v1.2.0 (active)
one-light-syntax, v1.2.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.2 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.0 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.0 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (active)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
find-and-replace, v0.198.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.1 (active)
metrics, v0.53.1 (active)
notifications, v0.64.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.238.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.1 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.98.1 (active)
timecop, v0.33.1 (active)
tree-view, v0.208.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.32.2 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.0 (active)
language-csharp, v0.12.1 (active)
language-css, v0.36.2 (active)
language-gfm, v0.86.0 (active)
language-git, v0.13.0 (active)
language-go, v0.42.0 (active)
language-html, v0.44.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.22.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.0 (active)
language-less, v0.29.3 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.0 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.68.5 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.52.0 (active)
language-shellscript, v0.22.3 (active)
language-source, v0.9.0 (active)
language-sql, v0.21.1 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.8 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

Hi is there any update on this issue?


Revert "Revert "chore: update MDC to latest canary""

Reverts angular/components#17932
Roll forward the original change. Don't merge until the MDC-sdie changes go into g3

This was rolled back on the MDC side, and it seems like they're doing smaller updates slowly. We can create separate PRs for them as needed


update dependencies and switch to compare_exchange as its deprecated …

…since 1.50 (and still exists in 1.40)

Published on crates.io: https://crates.io/crates/shred/0.13.0


Why is gcc-6? Can I use gcc-5?

I noted the CUDA_NVCC_FLAGS written in CMakeLists.txt used a /usr/bin/gcc-6. But, I have changed the gcc-6 into a gcc-5, and compiled it successfully. Can I use gcc-5?
My machine:
ubuntu 16.04
cuda 8.0 (gcc versions later than 5 are not supported!)
gcc-5.4.0

You could change the version of GCC to a version that fits your CUDA version. I try to avoid exotic C++ features that might not exist in some platforms.


cargo test wants to execute English language prose from bindgen as a doc test

Problem
Cargo test tries to execute English language prose in the comments of the rust file generated by bindgen as doc tests, just because the header documentation of the original code
had some indented passages.
It seems very inconvenient that code would not compile because of something going on in the comments.  Especially when what's in the comments is misintepreted by the toolchain.
Steps

I have src/lib.rs and bindgen/lib.rs. bindgen/lib.rs is generated by bindgen, lib.rs is the hand-written part.
src/lib.rs contains an `include!("../bindgen/lib.rs") to keep hand-written and generated parts separate.
Running cargo test tries to interpret comments in ../bindgen/lib.rs as rust tests.  They are just english prose that happens to be indented. Error is seen below.
It is possible to add #![doc(tests(ignore))], but it's a top level directive.  Which means if you do add it to both files, then the compiler will complain that src/lib.rs has this directive at a non-top-level
place.  If you add it just to one, the compiler will complain about the other file.

error: expected one of `!`, `.`, `::`, `;`, `?`, `{`, `}`, or an operator, found `are`
 --> src/../bindgen/lib.rs:4322:8
  |
3 | Fields are placed for optimal alignment on
  |        ^^^ expected one of 8 possible tokens here

error: aborting due to previous error

Couldn't compile the test.

Possible Solution(s)
There could be a flag to forbid doc test execution for files that I don't want treated this way.
Notes
Output of cargo version:
cargo 1.38.0-nightly (e853aa976 2019-08-09)

FWIW, there is a bindgen flag --no-doc-comments that may help...

This is an issue with bindgen creating comments with indentation which is treated as a code block.  Code blocks always default to rust in rustdoc.
Regardless, this isn't an issue for cargo.  Either bindgen could rewrite the comments (unlikely) or rustdoc could provide an escape hatch (see https://github.com/rust-lang/rust/issues/59867).  If you want to disable doc tests entirely for the crate, doctest=false can be set in Cargo.toml. There are also some workarounds noted in https://github.com/rust-lang/rust-bindgen/issues/1313.


Problem with leap year (2016)

var cal = moment();
cal.dayOfYear(100);
cal.year(2015);
var millis = cal.valueOf();
The millis will be one whole day before the actual millis for that specific day of year!
but only if moment() is initialized in a leap year and if the dayOfYear > Feb 29

This sort of behavior is documented here:
http://momentjs.com/docs/#/get-set/date/
Moment is not retaining the values passed to the setters and tracking them over time. Every time you do a set, it simply changes the date. For the same reason you are seeing this behavior, this can happen:
var a = moment('2016-05-31');
a.month(3);
a.format()
//the date has changed to the 30th because April doesn't have a 31
"2016-04-30T00:00:00-05:00"
//july has 31 days!
a.month(6);
a.format()
//still on the 30th
"2016-07-30T00:00:00-05:00"

The best advice we can give is to call set in order of size, from largest date part to smallest.


Loose BigQuery GCP project ID regex restrictions

This addresses https://github.com/apache/beam/issues/32168, please see rationale there

assign set of reviewers

There is probably a test flake?

I agree this is a reasonable change. Checked that PROJECT_ID_REGEXP is only used for extracting projectid/dataset/table from a table reference or table urn, it is not used in validation purpose.
For this reason please preserve the original comments, but could say
Formally, project IDs must contain 6-63 lowercase letters, ...

then
This regex is used for for basic parsing of table references rather than validation purpose, e.g. it allows looser restriction for testing on mock resources. It may allow for patterns that would be rejected by the service

Thanks @Abacn , I have adjusted the comment accordingly.


Allow other suffixes than -manual

Sometimes, it might be useful to be able to specify other suffixes than -manual; for example -manual_rater1 or -manual_rater2
https://github.com/spinalcordtoolbox/manual-correction/blob/39785a65104ab53f5d1477fc06725c772a642358/manual_correction.py#L650-L652
Related issue: https://github.com/spinalcordtoolbox/manual-correction/issues/40

IMO I would not use the suffix "manual" anymore, because:

this information is included in the JSON as per previous discussion, where the software OR the rater would be listed in the JSON sidecar
in general, to train a DL model, we generate GT by running a pipeline with SOTA software and then manually correct a fraction of it (typically 10-20%). Which means, that the remaining 80-90% are NOT human-corrected, BUT should still be used for DL training.

A potential issue with this approach however, is that we need a mechanism to know if a label created by a software has already been reviewed by a human. The 'manual' suffix addresses this problem...

I agree with https://github.com/spinalcordtoolbox/manual-correction/issues/48#issuecomment-1629296787 about mentioning that a label folders was either manually corrected and/or reviewed by a human (eg: called "labels_manual"). In case there is more than one rater, we could simply at a numerical suffix to the seg suffix. Examples:
```
...
...
├── sub-XXX
│   └── anat
│       └──sub-XXX_T1w.nii.gz
...
...
└── derivatives
    ├── dataset_description.json
    └── manual_labels
        ├── sub-XXX
        │   ├── anat
        │   │   ├──sub-XXX_T1w_label-SC_seg.nii.gz
        │   │   ├──sub-XXX_T1w_label-SC_seg1.nii.gz
        │   │   ├──sub-XXX_T1w_label-SC_seg2.nii.gz
        ...
        ...
```

We had some additional in-person discussion with @NathanMolinier. We agree with removing the suffix -manual from label filenames.
However, we are a bit reluctant to rename derivatives/labels to derivatives/manual_labels for two reasons:

the legacy reasons (all our datasets currently contain derivatives/labels)
where would we put the automatically generated labels? Under a second directory (automatic_labels)?

We would stay just with derivatives/labels. This folder will contain both automatically generated as well as manually corrected files (as it is now). The information if the file was generated automatically or manually corrected will be stored in JSON sidecar (discussion here).
...
...
├── sub-XXX
│   └── anat
│       └──sub-XXX_T1w.nii.gz
...
...
└── derivatives
    ├── dataset_description.json
    └── labels
        ├── sub-XXX
        │   ├── anat
        │   │   ├──sub-XXX_T1w_label-SC_seg.nii.gz
        │   │   ├──sub-XXX_T1w_label-SC_seg.json            # will contain information on how it was generated (https://github.com/spinalcordtoolbox/spinalcordtoolbox/issues/3394), and if manually corrected, also the name
        ...

In case there is more than one rater, we could simply at a numerical suffix to the seg suffix. Examples:

Good idea!

However, we are a bit reluctant to rename derivatives/labels to derivatives/manual_labels for two reasons:

i'm OK with that, but in that case we should be consistent and update our current SOP

where would we put the automatically generated labels? Under a second directory (automatic_labels)?

For us, there is often no clear distinction between automatic and manual labels, because labels are first created automatically, and then reviewed manually. The assumption should be that, if there is something under derivatives/  that has been git-annexed, then it has been reviewed by a human and it is correct (whether it was created automatically or not)

However, we are a bit reluctant to rename derivatives/labels to derivatives/manual_labels for two reasons:

i'm OK with that, but in that case we should be consistent and update our current SOP

Okay! Updated in https://github.com/neuropoly/intranet.neuro.polymtl.ca/commit/729bc53ec57374a6e8305bac310399110cf4f0aa.

Also, regarding my original comment:

Sometimes, it might be useful to be able to specify other suffixes than -manual; for example -manual_rater1 or -manual_rater2

This can be actually achieved by already existing -suffix-files-seg flag. For example, we can use -suffix-files-seg '_seg1'.
--> closing the issue


ShellScalingAPI.h missing

In file included from \base\vulkanexamplebase.cpp:9:0:

\base\vulkanexamplebase.h:16: error: ShellScalingAPI.h: No such file or directory
 #include <ShellScalingAPI.h>
          ^~~~~~~~~~~~~~~~~~~

With MingGW 7.3.0 64bit

That's only used for high-DPI scaling. If your compiler does not find this Windows header, just comment it out along with the part where high-DPI scaling is set.

#https://github.com/SaschaWillems/Vulkan/issues/575
Can't check if it compile, because of different issue.

I commented out high-DPI scaling.  I built several of the examples with gcc9.1 and mingw-64 and they all worked


TypeError: _vm.json is null

[Vue warn]: Error in render: "TypeError: _vm.json is null" found in ---> <AnnotationsPage> at src/components/AnnotationsPage.vue <HomePage> at src/components/HomePage.vue <App> at src/App.vue <Root>

I think this issue is related to how fileUploaded variable is being set in uploadStatus() method. I have raised a PR to fix this issue, https://github.com/cdqa-suite/cdQA-annotator/pull/43


Grade distribution: Rotate the My Grade label

Rotate the My Grade label 90% and put it at the top

Done


Enhance editing existing secrets

Summary
Editing an existing entry is a bit inconvenient at the moment, I think. If I don't know the exact path of the secret to edit, first I have to search for the path via find and then I could edit it copying the printed path and open that path via edit command.
Expected behavior
It would be nice if edit command would open same wizard than show if the given secret name isn't unique instead of opening an empty editor to create a new secret (which isn't what most users want to do if they type gopass edit <secret-xy>, I assume). From within the wizard it should be possible to switch to vim (or whatever your console editor of choice is) for one of the listed secrets via a keyboard shortcut.
I would like to have that possibility to edit one of the listed secrets from within the wizard even if it was opened via show command. So we don't have to implement different variants of the wizard, imho.

I'm not aware that this is a wanted inconsistency, is it @dominikschulz?
Please go ahead and create a PR if you want to improve situation. ☺

Thanks for creating this issue. Actually this is something I wanted to change for some time, too.
It's quite annoying and shouldn't be hard to fix.
Maybe I can work on that soon ...

It would be nice to have the opportunity to edit an entry listed in the wizard even if I opened it via gopass show command. So in addition to the existing options
<↑/↓> to change the selection, <→> to show, <←> to copy, <s> to sync, <ESC> to quit

I would like to have an option <e> to edit which is always there.
The only difference in the wizard whether it was opened via show or edit should be the default action which happens if I am hitting enter.

Sure, we can probably do that.


Allow unary expression for default values

We forbid expressions for default values, but we should allow unary
expressions. The reason for that, is that things like "-1", that are
obviously very reasonable defaults, are unary expressions.
Fixes #1171

@BearLemma updated.


Characteristic 'Brightness' will receive value higher than allowed

Describe the bug

Homebridge Config

Device Config

Additional Context

I'll re-open again..


Fix build error caused by missing bracket

Please note that at least another error remains:
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java:342: error: cannot find symbol
    public Intent getUploadServiceIntent(){
           ^
  symbol:   class Intent

This should have been fixed in #4451 .

Ah sorry thanks!


Merge develop into staging, 2023-Sep-21 Edition

Fixes failing tests that had been overlooked.

All tests are passing, the password reset email works - we're good to start testing! I'll open an issue presently.


Fix bug when changing shadowColor

I was changing the shadowColor according to whether the enclosing item was selected by the user, and noticed that after unselecting the item, the left half of the circle got painted with the previous shadowColor.
This should fix that.

Whoops, thanks for fixing that bug :+1:


update after changes to Rack32 lib

Removed the wrappers for the LCD/API/MQTT libs in the platform libs, and so force upstream firmware to use the LCD/API/MQTT pointers (added pointers for API/MQTT).
Saves having to change every platform lib if we add something to a low-level lib.

@moinmoin-sh should this be merged?

Sorry, I missed that one .


Centralize Python dependencies in setup.py

Moves all dependencies out of the conda environment definitions into setup.py
Removes the pip uninstall step. I'm not sure why it was needed, but pip seems to uninstall & reinstall sm (but not its unchanged dependencies) in the pip install step
Adds -e to the pip install step so that sm is installed in develop mode, so that when modules are imported from sm, it uses the code in /opt/dev/metaspace/metaspace/engine/sm/ instead of the copy that is made in /opt/dev/miniconda3/envs/sm/lib/python3.6/site-packages/sm/ at the time of installation.
Fixes pip package installation in docker

All looks good to me. We used to prefer installing binary packages like numpy and scipy using conda because pip didn't support it before. But now I cannot find any reason not to use pip inside conda environment for that.
We should test this ways of installing dependencies on staging before though.

One more caveat using dependencies in setup.py, the engine is installed automatically onto cluster machines when a dataset is submitted. If dependencies are not fixed, a new version of a library can be installed that is not compatible with engine code.

Per discussion: on Monday we'll test deploying it to staging. This branch won't be merged until then.
We should make sure to test processing speed before & after. For some tasks, Anaconda installs faster libraries. We currently specifically exclude MKL in favor of OpenBLAS because OpenBLAS is much smaller but apparently just as fast, it's worth checking.


Allow customized refreshControl in ScrollView for Android

Original Android's refreshControl in ScrollView is tightly coupled with AndroidSwipeRefreshLayout. If someone use ref= for RefreshControl in ScrollView, it does nothing since RefreshControl in Android return null.
This change allows customized  RefreshControl especially for ref= as well as making ScrollView's code clearer.

It was intentionnaly done this way because I didn't want to make it a view since it's layout is handled internally. I actually implemented it very similarly at some point before changing it to the way it ia now.
I don't have a problem changing it this way but I'm curious what is your use case where you'd need to acess the ref or manipulate the view directly?

@janicduplessis My use case is RefreshControl + ViewPagerAndroid.
AndroidSwipeRefreshLayout is so sensitive that I cannot swipe ViewPager since the gesture will be taken by AndroidSwipeRefreshLayout easily.
One workaround is that when you begin to swipe from ViewPager, disable the AndroidSwipeRefreshLayout and that's why I would use ref to get the element.
Please refer #5026 as well.

There is a disabled prop on RefreshControl, is it possible to use this instead?

disabled prop with setState() in re-rendering is too slow for my case. The latency will let swiping taken by AndroidSwipeRefreshLayout. I must use setNativeProps() and then using ref is need.

I see! Look good to me when you fix the little nits I pointed out :)

Thanks for your reviewing, ad796e9786 fixed some comments your mentioned.
However, for style from ScrollView to AndroidSwipeLayout, the flex: 1 seems done by style={styles.base}.
            <ScrollViewClass {...props} style={styles.base} ref={SCROLLVIEW}>
              {contentContainer}
            </ScrollViewClass>

Are there any other purposes if we should taken style from ScrollView to RefreshControl view since we could customize RefreshControl style out of box.

The reason why we transfer styles is to hide the implementation detail that on android the ScrollView is wrapper by the RefreshControl. On iOS it is not the case so it makes it consistent. If someone does something like
<View style={{flex: 1}}>
  <ScrollView style={{flex: 2}} refreshControl={...}>
    ...
  </ScrollView>
  <View style={{flex: 1}} />
</View>

then you'd expect the ScrollView to take 2/3 of the screen but it won't since the ScrollView is inside the RefreshControl. However it would work fine without the RefreshControl and on iOS.

@janicduplessis Thanks for your brief code snippet and updated as 45d76de.
Actually, I would like to transfer only flex: 1 if defined in ScrollView.props.style, but ScrollView.props.style is flattened and I cannot extract only flex property. Any idea if the code can be improved?
Thanks

Looks good to me, now it has the same behavior as before while exposing the native ref.

Thanks @janicduplessis. Then we should wait somebody to follow up review and shipit.

Cc @nicklockwood @mkonicek

This looks fine to me, although I'd prefer to handle the color array mapping in requireNativeComponent if possible, as we already have a pattern for doing that on iOS.

@nicklockwood Actually, the colors prop is for Android only. It seems Android requireNativeComponent does not support color array process mapping, so if I remove the processColor in the RefreshControl, it will raise redbox error.

I agree requireNativeComponent should handle the conversion like it does on iOS. I just checked what was necessary to make it work and it's pretty simple. You just have to register a new type mapping in TypeToPrecessorMap in requireNativeComponent.js:
var TypeToProcessorMap = {
  ...
  ColorArray: processColorArray,
};

Then in the annotation for the native prop you can use that type like this:
@ReactProp(name = "colors", customType = "ColorArray")
public void setColors(ReactSwipeRefreshLayout view, @Nullable ReadableArray colors) {
  ...
}

OK, now I must to modify PullToRefreshViewAndroid as well since the native AndroidSwipeRefreshLayout colors prop type will be changed.
Please wait me some minutes to revise and review again. Thank you.

4297dfd0b58 for the changes

Great, there is just one more issue, processColor was changed recently and it doesn't accept an array of color anymore so you should rebase on master and use the processColorArray function instead.

Oops, did not notice that and thanks.
I've rebased and force pushed the branch, please have a review again.
Thanks for you guys' kindly review.

@janicduplessis that's exactly the correct solution. Sorry I was a bit vague, and thanks for filling in the blanks :-)

@facebook-github-bot shipit

Thanks for your review and ship it @janicduplessis @nicklockwood

@nicklockwood I'm having an issue where a ListView won't scroll on Android. I traced it down to this line which I think should instead be props.style which inherits a flex: 1 from style.base. That seem right to you?

@Kudo input on my previous comment?

@keithnorm Good catch I didn't notice it was props.style before instead of this.props.style. Would you like to send a PR to fix it?

@janicduplessis sure, np

@keithnorm and @janicduplessis Sorry for my late reply and my miss for this bug.
Really thanks for your help to find this bug before official v0.20 released


Blendspace2D BLEND_MODE_DISCRETE_CARRY doesn't carry and resets for each animation

Tested versions

Reproducible in v4.2.1.stable.official [b09f793f5]
Was fixed in #48375

System information

Windows 10 v4.2.1.stable.official [b09f793f5] Forward+ and Mobile

Issue description
All the hard work for documenting this issue has already been done in #41028
and but unfortunately seems to have regressed.
Steps to reproduce
Please see the project provided below.
Minimal reproduction project (MRP)
Please see DiscreteCarryBug.zip from  #41028
NOTE: you might have connect the nodes from "Start" to "idle" in AnimationTree after you port the project to latest Godot version!

After some further testing, this seems to only occur when the animations are set to Looping, one-shot's carry work.


P2G strategy does not take into account number of units

I made the following LES

And expected the 1000(!) P2G units to easily take away any excess PV production. However, it appears like only 135 kW are taken away (in between the red arrows below). Since the capacity of one unit is 135 kW I believe that the number of units is not taken into account.

This is odd since the number of units multiplier is a "general" feature used by technologies of all types. P2G is a pretty simple technology and doesn't require any special handling for units.
Still, your conclusion sounds right to me; I'll look into this ASAP.


"show devices" hangs if SSH-process to any device is killed

What the title says.

"connection open" -> kill any SSH process -> "show devices" -> stuck.

Connection now immediately goes to state CLOSED as expected.


A small warning related to tar.exe appears in the CI

Yes, It seems to indicate that a certain cache program cannot be packaged on the Windows platform.

Yeah it seems so, though it's not as urgent as other issues :)


Only check the property value of isRequestCacheEnabled() once in HystrixObservableCollapser

NetflixOSS » Hystrix » Hystrix-pull-requests #189 SUCCESS
This pull request looks good


Keeps crashing every time I try to open

No matter how many times I try to use this program and what I try, EVERYTIME when I try to select a block IT KEEPS CRASHING with the error of "breakpoint"
do you think you can fix this?

G'day, is this still an issue for you?
I'd like to be able to reproduce it to then try to fix it.
IF it is, then info such as the browers you're using or a screenshot of the error code's popup would be helpful.
<3 mera


error/auth_onelogin_saml: auth failed due to missing username/email saml attribute

I have just plugued together my moodle to onelogin.
Once all steps in this guide is done :
https://onelogin.zendesk.com/hc/en-us/articles/201173644-Configuring-SAML-for-Moodle2
I get this error :
error/auth_onelogin_saml: auth failed due to missing username/email saml attribute:
The identity provider returned a set of data that does not contain the SAML username/email mapping field. Once of this field is required to login.
Please check your Username/Email Address Attribute Mapping configuration.
Now, I can't login with admin user to my Moodle.
What are the steps to solve this.
Thanks
P-L

You can access to //login/index.php?normal  in order to be able to log as an admin.
You need to set up the Attribute Mapping values, as suggested in the message:
"Please check your Username/Email Address Attribute Mapping configuration."
Moodle need to know the names of the attributes sent by OneLogin.

Hi @pitbulk ,
I see that if you forget to change the value in the database, you'll get this kind of error and should not be able to log back.
You should add a new step after step 10.
Here's the query to run for step 11 :
MySql Query
UPDATE moodle162.mdl_config set value=1
WHERE name='alternateloginurl';

After I log back to Moodle with admin account, I configure the section
ATTRIBUTE MAPPING
type the followin in the appropriate textbox :
Username : username
Email Address : email

Disconnect from your admin account.
Reconnect using the login button on top right.
You should be redirect to onelogin login page.
Use your credential for onelogin account.
Once you're connected, you're redirected to your moodle with this error :
error/auth_onelogin_saml: auth failed due to missing username/email saml attribute:
The identity provider returned a set of data that does not contain the SAML username/email mapping field. Once of this field is required to login.
Please check your Username/Email Address Attribute Mapping configuration.

What are the config to change to make this work properly ?
Regards,
DaRockWildCoder

Are you sure the IdP is sending username and email attributes? Can you share the SAMLResponse (record it with SAML Tracer).

Hi @pitbulk ,
I see that OneLogin is sending this SAML parameter to Moodle :
<saml:AttributeStatement>
         <saml:Attribute Name="saml_username" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:basic">
            <saml:AttributeValue xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="xs:string">***@****.com</saml:AttributeValue>
         </saml:Attribute>
      </saml:AttributeStatement>

Sure I have put some * in the username string.
IMPORTANT : Refer to step 10 c)

Check the option*
**Create user if not exists: **

ATTRIBUTE MAPPING
type the followin in the appropriate textbox :
Username : saml_username
Email Address : saml_username
First Name: saml_username
Surname: saml_username

Everything should be working after theses extra steps.
Cheers,
DaRockWildCoder


[DEVHAS-225] Set devfile repo context when scanning multi-component repos

What does this PR do?:
This PR updates the devfile.search() function so that if a devfile is found locally within a git repository, its context is returned in a devfileContextMapFromRepo map. This map is then used by the CDQ controller to properly set any source.devfileURL fields that are returned for detected components.
Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/DEVHAS-225
PR acceptance criteria:

[ ] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

Closed in favour of #240


WIP: Document Prop Types

Currently, we do a great job of showcasing in Storybook the various states/conditions under which our components can live
We don't do a super job, however, of documenting the APIs of our components in Storybook, meaning you often need to bounce between GitHub / Storybook to understand how to use a specific component.
This PR offers a few different approaches for bringing that lower-level information into Storybook.

I think Storybook V4 will have a first-class API for this. Closing until then.


Ungoogled Chromium Does Not Support WebGL

Describe the bug
So, I tried to use a website called StreamRaiders and when I wanted to join a Battlefield, an error pops up saying "Your browser does not support WebGL"
To Reproduce
Steps to reproduce the behavior:
There is no steps to reproduce
Expected behavior
I expected Ungoogled Chromium to run WebGL Games well instead of making the website throw that kind of error
Screenshots

Environment (please complete the following information):

OS/Platform and version: Windows 10 64Bit Build 20H1
ungoogled-chromium version: 86.0.4240.183-1

Do the experiments listed here work for you?
https://experiments.withgoogle.com/search?q=webgl

I have tested and some of them dont work

That is a Windows-specific packaging problem, you could try filing an issue over at https://github.com/ungoogled-software/ungoogled-chromium-windows
(IOW https://get.webgl.org/ works on GNU/Linux, so it's unlikely to be related to the ungoogled patches from this repository)

Alright, I am now gonna file a issue there and closing this.

Hi, this is happening for me on Linux, specifically on Debian 10 Buster.

Version 90.0.4430.212 (Developer Build, ungoogled-chromium) built on Debian buster/10, running on Debian buster/10 (64-bit)

Is there a fix?

SketchUp:

Please try https://get.webgl.org/. I see no issues:

Also please mention your OS/platform.

Also please mention your OS/platform.

Oops, added.
The https://get.webgl.org/ works.

Also happening with me, no WebGL application works on Linux 6.1.1-1-MANJARO and ungoogled-chromium-bin 108.0.5359.124-1 from AUR.
Log messages from chrome://gpu:
GpuProcessHost: The GPU process exited normally. Everything is okay.
GpuProcessHost: The GPU process exited normally. Everything is okay.
GpuProcessHost: The GPU process exited normally. Everything is okay.
GpuProcessHost: The GPU process exited normally. Everything is okay.
[9181:9181:0114/175632.560084:ERROR:angle_platform_impl.cc(43)] : Display.cpp:1004 (initialize): ANGLE Display::initialize error 0: Internal Vulkan error (-3): Initialization of an object could not be completed for implementation-specific reasons, in ../../third_party/angle/src/libANGLE/renderer/vulkan/RendererVk.cpp, initialize:1430.
GpuProcessHost: The GPU process exited normally. Everything is okay.
[9236:9236:0114/175632.623364:ERROR:angle_platform_impl.cc(43)] : Display.cpp:1004 (initialize): ANGLE Display::initialize error 0: Internal Vulkan error (-3): Initialization of an object could not be completed for implementation-specific reasons, in ../../third_party/angle/src/libANGLE/renderer/vulkan/RendererVk.cpp, initialize:1430.
[9236:9236:0114/175632.623520:ERROR:gl_display.cc(508)] : EGL Driver message (Critical) eglInitialize: Internal Vulkan error (-3): Initialization of an object could not be completed for implementation-specific reasons, in ../../third_party/angle/src/libANGLE/renderer/vulkan/RendererVk.cpp, initialize:1430.
[9236:9236:0114/175632.624136:ERROR:gl_display.cc(920)] : eglInitialize SwANGLE failed with error EGL_NOT_INITIALIZED
[9236:9236:0114/175632.624400:ERROR:gl_ozone_egl.cc(23)] : GLDisplayEGL::Initialize failed.
[9236:9236:0114/175632.634390:ERROR:viz_main_impl.cc(186)] : Exiting GPU process due to errors during initialization
GpuProcessHost: The GPU process exited normally. Everything is okay.
[9261:9261:0114/175632.710429:WARNING:vaapi_wrapper.cc(792)] : VAAPI video acceleration not available for disabled
[9261:9261:0114/175632.710560:ERROR:gpu_init.cc(523)] : Passthrough is not supported, GL is disabled, ANGLE is

also happening on https://earth3dmap.com/3d-globe/

Still happening as of June 29/2024


Show video full screen on click

Link #199
Reference

https://developer.android.com/develop/ui/views/layout/webapps/webview#UsingJavaScript
https://github.com/jocmp/article_forge/pull/2

I've reported some issues in the discussions related to this feature https://github.com/jocmp/capyreader/discussions/210#discussioncomment-10230714


Update README.md

@shawnhu444 Do we need these changes at this stage? I think we can review the Readme at the final milestone.

agreed on the changes


Addressed icon contrast ratio on IconsPage

Addressed issue : [WPF Gallery->Samples->Icons]: Color contrast ratio of text under icons is 3.152:1 which is less than the required ratio of 4.5:1.
Microsoft Reviewers: Open in CodeFlow

Same changes are present in #651. Therefore, closing this PR.


fix: fix the bug "the prompt.id in conversationKey are undefined"

Now it's like:
--------conversationKey start---------
provider.id:undefined
--------conversationKey end---------
In fact, it should be
--------conversationKey start---------
provider.id:prompt.id
--------conversationKey end---------

Thanks @qwlong!  Looks like there are some test failures we need to look at

@typpo
when would you merge this pull request?

Hi @qwlong, thanks for your contribution! This PR has gone stale, so I’m going to close it for now. If this issue persists or if you’d like to revisit it, please feel free to reply, reopen the PR, or create a new one. We appreciate your help and look forward to your future contributions.


Error with Description field exceeding 127 characters on some Lenovo models

While downloading a BIOS package for a Lenovo ThinkCentre M73 (10AX) we get this error related to package description length:
New-CMPackage : Cannot validate argument on parameter 'Description'. The character length of the 131 argument is too long. Shorten the character length of the argument so it is fewer than or equal to "127" characters, and then try the command again.
At line:18346 char:92
Here is the package description it attempted:
Package description is (Models included:10B3 10DL 10HK 10HM 10HL 10B5 10B7 10B4 10B1 10AX 10DN 10HJ 10B6 10B2 10DK 10AY 10DM 10B0)

Still the same...

#230 also having this issue with HP ProBook 640 G1 model.

#230 also having this issue with HP ProBook 640 G1 model. Did you manage to find any workarounds?

Having same the issue with 640 G1 1909 downloads

Having same the issue with HP ProBook 450 G8 Win1021H1 downloads

Having same the issue with HP ProBook 440 G8 Win10 21H1 and 1909 downloads
Driver Automation Tool 7.0.1

I also am having issues with HP ProBook 440 G8 Win10 21H1 - desc too long

For the 450 G8, I just pulled it down with the 'Model XML generation option' and it made this XML file for me.. it looks like the system sku ends up repeating for some reason. I bet I could manually edit the XML and do a custom import with the tool though

HP
ProBook 450 G8 Notebook PC
87e1,8a77,8a85,8808,8a75 8a85,8a75,87e1,8a77,8808 8a85,87e1,8808,8a77,8a75 8a75,8a85,87e1,8808,8a77 8a77,8808,87e1,8a75,8a85
Windows 10 21H1
64 bit
XML

I should also add that the original Lenovo model with issues has since been corrected by Lenovo, as the SKUs it had included were for three distinct models.
The 450 G8 is really curious to me, in the model selection pane, it only shows the five SKUs/baseboard IDs for that model, but the description it generates has them repeated multiple times, but in a different order. Interestingly, I had previously imported the driver and BIOS pack for that model and it only had three SKUs at that time.


Fix wrong href.

The href path of don't delete button needs to be ../../../
#1000

Thank you @afranjin and @Benbb96 for working on this! Makes it easy for me to look at and approve.


.NET January 2024 Update - ..NET 8.0.1, NET 7.0.15, .NET 6.0.26

.NET January 2024 Update
Today, we are releasing an update to our October 10 security releases. The .NET 8.0.1, .NET 7.0.15 and, .NET 6.0.26 releases contain the security fixes from our previous September release that were missing in the October release.
Release Notes

8.0.1
7.0.15
6.0.26

Status

Asset Type
8.0.1
7.0.15
6.0.26
Notes

Installers/Binaries
✅
✅
✅

Snaps
✅
✅
✅

Linux Packages (Microsoft distribution)

The list below refers to the Microsoft-provisioned feeds (packages.microsoft.com) and does not in any way represent direct availability in distros (eg RHEL, Fedora).

     Centos 7
NA
✅
✅

     Centos 8
✅
✅
✅

     Debian 10
✅
✅
✅

     Debian 11
✅
✅
✅

     Debian 12
✅
✅
✅

     Fedora 37
✅
✅
✅

     Fedora 38
✅
✅
✅

     Fedora 39
✅
✅
✅

     OpenSUSE 15
✅
✅
✅

      Ubuntu 20.04
✅
✅
✅

     Ubuntu 22.04
✅
✅
✅

     Ubuntu 23.04
✅
✅
✅

Issues
Please report any issues you find either by responding to this issue, creating a new issue or creating a new issue in one of the following repos:

ASP.NET Core: dotnet/aspnetcore
Entity Framework Core: dotnet/efcore
.NET CLI/SDK dotnet/sdk
.NET runtime dotnet/runtime
Winforms: dotnet/winforms
WPF: dotnet/wpf
NuGet: nuget/home
Containers: dotnet/dotnet-docker
Winget: microsoft/winget-pkgs

Known Issues

It is announced that 6.0.26 has CVE-2024-0056 fix. When I try to add "Microsoft.EntityFrameworkCore.SqlServer 6.0.26" package dependency to my project, I see that it has reference to Microsoft.Data.SqlClient 2.1.4 version. As I understand 2.1.4 version is vulnerable, and 2.1.7 should be used.
Is it correct that it is not enough to update "Microsoft.EntityFrameworkCore.SqlServer" package to  6.0.26, I also need to add direct reference to Microsoft.Data.SqlClient 2.1.7?
Links:
Microsoft.EntityFrameworkCore.SqlServer 6.0.26 is described as safe here:
https://github.com/dotnet/core/blob/main/release-notes/6.0/6.0.26/6.0.26.md
Microsoft.Data.SqlClient 2.1.7 is marked as save here:
https://msrc.microsoft.com/update-guide/vulnerability/CVE-2024-0056
And finally this announcement says that all <3.1.5 versions of Microsoft.Data.SqlClient  are vulnerable:
https://github.com/dotnet/announcements/issues/292

Is it correct that it is not enough to update "Microsoft.EntityFrameworkCore.SqlServer" package to 6.0.26, I also need to add direct reference to Microsoft.Data.SqlClient 2.1.7?

Yes.

It appears the packages in the packages-microsoft-com-prod repository for Fedora are broken because the dependency dotnet-runtime-deps-8.0-8.0.1 is missing.
 Problem: package aspnetcore-runtime-8.0-8.0.1-1.x86_64 from packages-microsoft-com-prod requires dotnet-runtime-8.0 >= 8.0.1, but none of the providers can be installed
  - cannot install the best candidate for the job
  - nothing provides dotnet-runtime-deps-8.0 >= 8.0.1 needed by dotnet-runtime-8.0-8.0.1-1.x86_64 from packages-microsoft-com-prod
================================================================================
 Package                 Arch    Version     Repository                    Size
================================================================================
Skipping packages with broken dependencies:
 aspnetcore-runtime-8.0  x86_64  8.0.1-1     packages-microsoft-com-prod   10 M
 dotnet-runtime-8.0      x86_64  8.0.1-1     packages-microsoft-com-prod   29 M

@simonhaines - which version of Fedora are you using? I just successfully installed dotnet-sdk-8.0 (8.0.101) through Fedora 37 (end-of-life as of 12/2023), 38, and 39 so hopefully things are working for you now.

Thanks @leecow , the issue is with the packages-microsoft-com-prod repository, which at one time must have been official the way to install dotnet on Fedora (I remember having to import a key for it once).
For others facing this issue, you can determine if you have this repository enabled:
~ $ sudo dnf repolist
repo id                      repo name
packages-microsoft-com-prod  packages-microsoft-com-prod
...

A quick look into this repository reveals that most packages have version 8.0.1 except for dotnet-runtime-deps-8.0 which is still on 8.0.0.
~ $ sudo dnf search dotnet --repo packages-microsoft-com-prod
...
Last metadata expiration check: 0:27:38 ago on Thu 18 Jan 2024 09:37:41.
======================== Name & Summary Matched: dotnet ========================
dotnet-runtime-deps-8.0.x86_64 : dotnet-runtime-deps-rhel.8 8.0.0
============================= Name Matched: dotnet =============================
dotnet-apphost-pack-8.0.x86_64 : Microsoft.NETCore.App.Host 8.0.1
dotnet-host.x86_64 : Microsoft .NET Host - 8.0.1
dotnet-hostfxr-8.0.x86_64 : Microsoft .NET Host FX Resolver - 8.0.1
dotnet-runtime-8.0.x86_64 : Microsoft.NETCore.App.Runtime 8.0.1
dotnet-sdk-8.0.x86_64 : Microsoft .NET SDK 8.0.101 8.0.101
dotnet-targeting-pack-8.0.x86_64 : Microsoft.NETCore.App.Ref 8.0.1
dotnet-templates-8.0.x86_64 : .NET 8.0 templates

I assume, from the documentation at https://learn.microsoft.com/en-us/dotnet/core/install/linux-fedora that this repository is no longer the official way of installing dotnet packages, so all installed packages should be removed and re-installed from the Fedora updates repo:
~ $ sudo dnf install dotnet-sdk-8.0 --disablerepo packages-microsoft-com-prod

To disable the broken repository altogether:
~ $ sudo dnf config-manager --set-disabled packages-microsoft-com-prod

Better now, thanks.

Is it correct that it is not enough to update "Microsoft.EntityFrameworkCore.SqlServer" package to 6.0.26, I also need to add direct reference to Microsoft.Data.SqlClient 2.1.7?

Yes.

Why Microsoft.EntityFrameworkCore.SqlServer v6.0.26 did not increase the dependency version of Microsoft.Data.SqlClient to >=2.1.7? Isn't it bug?

closing in favor of https://github.com/dotnet/core/issues/9163


Support DCE on make_jaxpr

It would be useful to support dead code elimination on staged out jaxprs as part of make_jaxpr, I would suggest making this a new optional argument that would run some simple passes like dead code elimination and perhaps could prune unused arguments from subjaxprs etc.
As a motivating use case, from access to an optimized/minimized jaxpr we would be able to determine which arguments to a given function were "live" and prune any unused inputs.

I believe that we could do something like this. It seems easy to start with something sound but not comprehensive, then gradually advance the latter. For example, how do we handle higher-order primitives like scan/loops? A simple analysis might dictate that every value read by a loop primitive is "live". A more thorough attempt might analyze the loop body jaxpr for DCE, maybe calling for some fixpoint procedure.
So, before we proceed with something like this, it'd be good to have an idea of how far an implementation would need to go. A more complete motivating use case would help there.
A related implementation question is whether we can reuse any DCE machinery from our underlying compiler (XLA). I'm not entirely clear on how that would look. Jaxpr and HLO are not identical (notably around control flow, via scan). Again the relevance of this may depend on the use case. For example, is this feature only useful to have under jit?

I'd also love to have this.
In my case it's a library that calls a jited function and passes it all the available data as inputs. The function itself only uses a subset of inputs. I'd love to be able to prune those inputs automatically to avoid the waste of uploading the unused inputs on-device just to drop them immediately.

In my case we build modular networks using Haiku, and the networks can compute multiple outputs. Very often a lot of the outputs aren't used in the outer jitted function (e.g. only used for debugging purposes), hence many of the params Haiku creates end up not being used, but are still expected to be provided. The problem comes into play once we need to sync params across devices, e.g. send from learners to actors in a distributed RL setup, since then we need to send all of the unused parameters as well.
I would like to create a helper function that wraps Haiku init_apply functions such that they produce/expect only the used params.

For completeness, @mattjj posted a snippet that should give us argnums of unused inputs, but it does not perform DCE:

In [2]: def foo(x, y, z):
   ...:     return x + z  # y unused
   ...:

In [3]: make_jaxpr(foo)(1, 2, 3)

Out[3]:
{ lambda  ; a b c.
  let d = add a c
  in (d,) }

In [4]: def unused_argnums(f, *example_args):
   ...:     jaxpr = make_jaxpr(f)(*example_args)
   ...:     unused_invars = set(jaxpr.jaxpr.invars)
   ...:     for eqn in jaxpr.jaxpr.eqns:
   ...:         unused_invars -= set(eqn.invars)
   ...:     return [i for i, v in enumerate(jaxpr.jaxpr.invars) if v in unused_invars]
   ...:

In [5]: unused_argnums(foo, 1, 2, 3)

Out[5]: [1]

It would only take a little bit more to set up some basic DCE:
from jax import make_jaxpr

def unused_argnums(f, *example_args):
  jaxpr = make_jaxpr(f)(*example_args).jaxpr
  used = set(jaxpr.outvars)
  for eqn in reversed(jaxpr.eqns):
    if used.intersection(eqn.outvars):
      used.update(eqn.invars)
  return [i for i, v in enumerate(jaxpr.invars) if v not in used]

This conservatively reasons that all operands to a primitive are read/used. Higher-order primitives (e.g. calls, control flow) supply an easy counterexample. For instance:
from jax import jit

def g(x,y,z,w):
  x, _ = jit(lambda x, y: (2*x, 2*y))(x, y)
  return x + w

unused_argnums(g, 1, 2, 3, 4)    # return [2], not [1, 2]

If we generalized the line used.update(eqn.invars) above to something along the lines of:
used_outs = [i for i, v in enumerate(eqn.outvars) if v in used]
used_ins = primitive_dce_rule(eqn.primitive, used_outs, **eqn.params)
used.update([eqn.invars[i] for i in used_ins])

we could include primitive-specific DCE rules. Part of my comment above was a request to estimate how far we'd need to go down this path, especially considering control flow primitives.
(Aside: we'd probably also want to pass in equation input/output types to primitive_dce_rule above.)

Thanks for the detailed reply @froystig! This is a great start. In my case we were hoping for a full general solution, if possible, because, I guess when using Haiku, the params are passed to all of the downstream transformations, so if there's a primitive that isn't implemented, all of the params would show up as being used.
If this avenue isn't possible with JAX, would it be possible to obtain this directly from XLA?
Otherwise, we could maybe start by enumerating the most common primitives that would need to be handled manually and estimate how much work it would take to implement top-k of those?

+1 To what Hamza mentioned.
Going with XLA it might also be easier, I think, to cover pmap as well as jit.  In my understanding there is no out-of-the-box way to produce a jaxpr for a pmap-ed function, because of the jax.lax primitives almost always present in a pmap-ed function.

Regarding reusing XLA's work, @hawkinsp pointed me to the HLO DCE pass here.
We would also need to change our calling convention to XLA, to allow us to avoid passing inputs that the callee has indicated aren't used.

Regarding DCE in the Jaxpr IR, conversation with @mattjj reminded me that we've already implemented roughly the DCE from my previous comment, as part of partial_eval here.


Set initial sort column to "title"

When initially loading the admin ui, the events table will  reorder itself after a few moments. This avoids the reordering by initializing table sorting parameters with "title" for the "sort by column" parameter.
Fixes #610

Note: Sort by date instead.

The latter, custom sort settings are currently not preserved.

This doesn't seem to work. I've just tested 2e4b2da using npm start and I see three stages when initializing the table

No data (00:00:04)
Event “Espresso” as first event (00:00:09)
Event “Test Scheduling” as first event (00:00:13)

Here is the (slowed down) recording:
https://github.com/opencast/opencast-admin-interface/assets/1008395/0eb57f72-6d31-47ad-9ba0-88531944c52e

Damn it, you're right. Curse you descending sorting order. I'll see what I can do.

Should be better now.


Make version numbers more obvious

Thanks for your work.
Because I install this into a multi-user system using module files, I use version numbers to control access.
Before I install this software, the only version number I can see is the last git commit hash: 5f44e1.
After installation I discover via pip list that this is version 1.0.4.
Would be great if there could be some way to know that version number before installation - either via a version file or a release tarball?

There is a version file:
https://github.com/mroosmalen/nanosv/blob/master/nanosv/version.py


Send Box becomes unresponsive on toggling ReactWebChat full bundle component

Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
NPM
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Edge (latest), Browser: Chrome (latest)
Which area does this issue affect?
Send box
What is the public URL for the website?
No response
Please describe the bug
When the <ReactWebChat/> (full bundle) component is rendered once, hidden, and then re-rendered the send box becomes unresponsive.
Do you see any errors in console log?
No response
How to reproduce the issue?

I'd expect to be able to render the ReactWebChat component multiple times using the same store/direct line token in a toggle manner without it becoming unresponsive.
What actually happened?
When toggling the ReactWebChat component, the send box becomes unresponsive.
Do you have any screenshots or recordings to repro the issue?
No response
Adaptive Card JSON
No response
Additional context
No response

Investigating.

Hi @cpendery,
Looks like this issue might be related to #4300
There are two possible solution:

Downgrade React: Downgrading react to 17.02 solved this issue from my end.

Open terminal and navigate to root project
Run npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>Change index.tsx code the following:import React from "react";
import ReactDOM from "react-dom";
import App from "./App";

const rootElement = document.getElementById("root");

ReactDOM.render(
  <React.StrictMode>
    <App />
  </React.StrictMode>,
  rootElement
);

Run npm start

Await Future Resolution: I will inform the WebChat development team about this issue so they can begin devising a solution.

Thank you @stevkan the help.  🚀


Composer - optimise rendering behaviour for onKeyPress & onSubmit

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/26347
PROPOSAL: https://github.com/Expensify/App/issues/26347#issuecomment-1755958039
Tests

Enter chat
Type in message
Check if draft indicator is shown correctly
Submit the message
Check if message is submit correctly
Type in another message to double check if there are no failures in the state store

Offline tests

N/A
QA Steps

[ ] Verify that no errors appear in the JS console

Enter chat
Type in message
Check if draft indicator is shown correctly
Submit the message
Check if message is submit correctly
Type in another message to double check if there are no failures in the state store

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/62747088/a1a5a89f-0ac9-43ea-8914-ff1316680022

Android: mWeb Chrome

https://github.com/Expensify/App/assets/62747088/bd2ca24a-9888-4fb8-b827-39a78cd55c43

iOS: Native

https://github.com/Expensify/App/assets/62747088/c583922e-93af-47dc-b1c0-6361fb7683e2

iOS: mWeb Safari

https://github.com/Expensify/App/assets/62747088/485c66ed-c4e9-4511-bb57-50b7fe920c24

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/62747088/afaeac73-eb63-45c4-b158-0c5be002b460

MacOS: Desktop

https://github.com/Expensify/App/assets/62747088/cee68ca2-45ed-4a6a-b9dd-04b6c31b5607

Update
Before 🐢
https://github.com/Expensify/App/assets/62747088/49307dcc-3b1a-458b-957e-d4e2ac6895e1
After 🔥
https://github.com/Expensify/App/assets/62747088/4adaf09f-d798-4460-b5bf-6731e28326cf

Removal of side effect setting the Report's draft in LHN, done in 956d7175a6700caf91bbe7fd86a77ea835e8bf18, was investigated and it looks like draft are being updated properly.
Same goes for functionality after logout - draft are being deleted after user logs out. Here is a video showing this functionality on current main:
https://github.com/Expensify/App/assets/62747088/f086cbcd-826c-459b-8139-fb530f97c01f
Please feel free to drop in your insight on if this useEffect can be safely removed. Thanks!

Melvin you haven't mentioned anyone

Use the links below to test this build in android and iOS. Happy testing!

Shall we move the PR forward? @aimane-chnaif

@aimane-chnaif conflicts resolved - ready for next step 👍

@aimane-chnaif Another pack of conflicts resolved, let me know if you could review it soon :thu

Hi @aimane-chnaif did you have a chance to look at the PR? Is there anything I can help you with to move it further? Thanks!

I think mentions test case needs to be added as that component is affected

Other platforms work well but not in android emulator which is super slow device
https://github.com/Expensify/App/assets/108292595/80c6e40c-3e15-4205-85ed-4e4b1fc1b733
will test on real device

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Error, Can't run the script

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
import numpy as np
np.sin(2)
Please provide any additional information below
File "D:\InstalledSoftwares\Anaconda3.6\lib\site-packages\spyder\plugins\ipythonconsole.py", line 890, in run_script
self.execute_code(line, current_client, clear_variables)
File "D:\InstalledSoftwares\Anaconda3.6\lib\site-packages\spyder\plugins\ipythonconsole.py", line 936, in execute_code
sw.execute(to_text_string(to_text_string(lines)))
File "D:\InstalledSoftwares\Anaconda3.6\lib\site-packages\qtconsole\history_console_widget.py", line 47, in execute
source, hidden, interactive)
File "D:\InstalledSoftwares\Anaconda3.6\lib\site-packages\qtconsole\console_widget.py", line 631, in execute
self._execute(source, hidden)
File "D:\InstalledSoftwares\Anaconda3.6\lib\site-packages\qtconsole\frontend_widget.py", line 294, in _execute
msg_id = self.kernel_client.execute(source, hidden)
AttributeError: 'NoneType' object has no attribute 'execute'
Version and main components

Spyder Version: 3.2.3
Python Version: 3.6.1
Qt Versions: 5.6.2, PyQt5 5.6 on Windows

Dependencies
pyflakes >=0.6.0 :  1.5.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.1 (OK)
numpy >=1.7      :  1.12.1 (OK)
sphi

This is a duplicate of issue #5053 and it'll be fixed in 3.2.4.


Ignore folders in version tags.

Please ignore the folder information and extract only the version.
Should: release/v2024.10.0 ==> 2024.10.0
Is: releases/v2024.43.0==> releases/v2024.43.0

Great idea @SvenBunge! Let me look into that.

@SvenBunge this should be now implemented in v4. Let me know if you have issues with it. Thanks for the idea!


Replace heading with logo and link to index page

Bug: T323680

Rebased onto main with all the fixups squashed into their respective commits.


Use Towncrier for Changelog?

Situation
Currently, all changes are recorded in a single CHANGELOG.rst file. In most cases this is enough and it works well.
However, in some cases conflicts can occur. Sometimes it would be helpful to have a tool which could create that changelog automatically.
Idea
Some projects use the towncrier tool. It is built around "news fragments", little text snippets that are stored in different files under a common directory (e.g. changes.d). When a new release is drafted, these files are brought together and create the final changelog file. This minimizes any conflicts.
Every filename contains an issue number and a "type". A type can be feature, bugfix, doc, removal, or you can use self-defined types. These types will become sections in the final changelog file. All fragments are collected, sorted, and added under the sections.
When Towncrier is correctly set up, a typical workflow looks like this:

Start working on a specific issue, let's say, 123.
Decide what type this issue is, for example, feature, bugfix, etc.
Combine the two information and create a fragment file: towncrier create 123.bugfix.
This file will be added inside the changes.d directory.
Describe the issue.
Commit the file.
Merge issue to master.

The more issues you solve, the more files you will collect inside your changes.d directory. At some point, we need to create a new release. In this case, the workflow looks like this:

Create a new release branch.
(could be done in other ways too, but this makes things a bit easier).
Raise the version.
Produce a draft changelog to see everything is included with: towncrier build --draft.
If satisfied, produce the final changelog file with: towncrier build.
This command will remove all files inside the changes.d directory and create the final changelog file.
Commit all changes and merge it.

Pros

All changes reside in single files under a common directory, for example, changes.d.
This makes it easier to see which will end up in the new release.
Reduces conflicts as changes are stored in separate files.
Able to configure

Cons

Works on Python 3.5+ only.
(This may be not as a big disadvantage as we move to Python 3 soon.)
Every file has to be named with ISSUE-TYPE. This may not always appropriate.
Towncrier works best in a development system where all merges involve closing a ticket.

@python-semver/reviewers @tlaferriere  what do you think about that? Would that be helpful or just too much?

Works on Python 3.5+ only.

Even with our 2.x I don't think this is an issue since this is a dev tool. No need to require the end users to have py >=3.5.
I see there are quite a few steps to this workflow, which will increase the chance to forget something. I think this would be best if it could be integrated with tox and easily automated.

Thanks Thomas for your feedback! :+1:

Works on Python 3.5+ only.

Even with our 2.x I don't think this is an issue since this is a dev tool. No need to require the end users to have py >=3.5.

Yes, I think, the normal user shouldn't be affected much as the releases are done by the maintainers only.

I see there are quite a few steps to this workflow, which will increase the chance to forget something. I think this would be best if it could be integrated with tox and easily automated.

I thought of that too. :wink:
Maybe my description was a bit verbose, but I wanted to make sure it contains some "flesh".
Typically, the normal user has to create only one file with a specific name and some content. That's all. I think, this is not really difficult. We could describe that in our "Contributing" section.
For the release manager(s), there are indeed some more steps involved. As you rightfully noted, this can be done with tox.

Every file has to be named with ISSUE-TYPE. This may not always appropriate.

Looking at the pypi page, the possible issue types seem to be rather complete, even including a misc type that can be good catch-all for all infra related stuff.

Towncrier works best in a development system where all merges involve closing a ticket.

We can ask the people who open PRs to also open an issue for reference and discussion.
In the end, I'm always for more automation, as it allows us to focus more on the essentials, and removes possibility for mistakes. That's a yes from me 👍

Looking at the pypi page, the possible issue types seem to be rather complete, even including a misc type that can be good catch-all for all infra related stuff.

That's true. I also worked with Towncrier in a local branch. The only issue that I found is, when you do *not have an issue, but you want to record the change.

We can ask the people who open PRs to also open an issue for reference and discussion.

You mean, we should separate the issue from a new issue which is only related to the fragment? Or maybe I missed your idea.

In the end, I'm always for more automation, as it allows us to focus more on the essentials, and removes possibility for mistakes. That's a yes from me :+1:

Thanks. :smiley: Yes, automation is usually a good thing. Just wanted to make sure I don't over-engineering it. :wink:
I still have my local branch. If I push it we can play with that.

The only issue that I found is, when you do not have an issue, but you want to record the change.

If that change is worth recording, maybe it is also worth creating an issue for 😉.

You mean, we should separate the issue from a new issue which is only related to the fragment?

I meant that each pull request (change effected) should close at least one issue.
For example, take the first PR I did on this repo: I just coded the changes, didn't bother actually creating an issue to discuss goals beforehand. In this case, if we were using towncrier, a part of getting this PR accepted would have been to open an issue and link it in towncrier and in the PR.
As for splitting off issues from another issue, I think this has more to do with what we consider to be in the scope of said issue (see the first sentence of this comment).
I think that having an issue for each changelog entry would make us more aware of what is actually changing, and it would encourage discussion on changes that could actually affect the users.
While we're at it, I have to say that I like the projects feature for repos and I think we should use it more (e.g for feature releases). I think it's a nice visual for tracking progress on related topics.

I think, that is closed with #290 and commit cbd4335f


Feature request - HyperHDR as supported Hyperion.NG fork

Hi!
It would be nice, if HyperHDR (https://github.com/awawa-dev/HyperHDR), as Hyperion.NG fork, would be supported. I think, most of the common parameters should be similar and at least turning things on and off or setting effects should be possible. At the moment the adapter only tells me
Your Version of hyperion (<IP_ADDRESS>) is not supported!!
and I cannot find out, if there should be more datapoints than the general ones that the adapter created.
EDIT: I modified line https://github.com/felixganzer/ioBroker.hyperion_ng/blob/28d7585c3f5ae5ae0b34bff8c093c25165eaad85/main.js#L605 and commented it out. Your adapter seems to work perfectly though.
Regards
Holger

I added the version Checking for your HyperHDR. I have to use it, because hyperion 1.X has a different API.


dequantize_affine modified the input in-place

The dequantize_affine function modifies the input in place, resulting in different outputs when a model is run multiple times with the same inputs.
Should we consider cloning the input, scale, and zero_point at the beginning of the function to prevent this issue?
Code to reproduce the issue
# demo.py
# modified from https://github.com/pytorch/ao/blob/cbc74ee6a3dc0bae367db5b03bc58896fffe3ae0/test/quantization/test_quant_api.py#L449-L467

import unittest
import torch

from torchao.dtypes import to_aq, AffineQuantizedTensor
from torchao.quantization.quant_primitives import MappingType, ZeroPointDomain
from torchao.quantization.quant_api import quantize
from torchao.quantization.utils import TORCH_VERSION_AFTER_2_4

import copy

class ToyLinearModel(torch.nn.Module):
    def __init__(self, m=64, n=32, k=64):
        super().__init__()
        self.linear1 = torch.nn.Linear(m, n, bias=False).to(torch.float)
        self.linear2 = torch.nn.Linear(n, k, bias=False).to(torch.float)

    def example_inputs(self, batch_size=1):
        return (torch.randn(batch_size, self.linear1.in_features).to(torch.float),)

    def forward(self, x):
        x = self.linear1(x)
        x = self.linear2(x)
        return x

@unittest.skipIf(not TORCH_VERSION_AFTER_2_4, "Test only enabled for 2.4+")
@unittest.skipIf(not torch.cuda.is_available(), "Need CUDA available")
def test_quantized_tensor_subclass_int4():
    # weight settings
    groupsize = 32
    mapping_type = MappingType.ASYMMETRIC
    block_size = (1, groupsize)
    target_dtype = torch.int32
    quant_min = 0
    quant_max = 15
    eps = 1e-6
    zero_point_dtype = torch.bfloat16
    # !! For using `AffineQuantizedTensor.dequantize`
    preserve_zero = True
    zero_point_domain = ZeroPointDomain.INT

    # use 1024 so that we don't need padding
    m = ToyLinearModel(1024, 1024, 1024).eval().to(torch.bfloat16).to("cuda")
    m_copy = copy.deepcopy(m)
    example_inputs = tuple(map(lambda x: x.to(torch.bfloat16).to("cuda"), m.example_inputs()))

    def apply_weight_quant(weight):
        return to_aq(
            weight,
            mapping_type,
            block_size,
            target_dtype,
            quant_min,
            quant_max,
            eps,
            zero_point_dtype=zero_point_dtype,
            preserve_zero=preserve_zero,
            zero_point_domain=zero_point_domain,
        )

    m = quantize(m, apply_weight_quant)
    assert isinstance(m.linear1.weight, AffineQuantizedTensor)
    assert isinstance(m.linear2.weight, AffineQuantizedTensor)

    res = m(*example_inputs)
    res2 = m(*example_inputs)
    assert torch.equal(res, res2), f"The results of the model are not consistent"

# pytest -sv demo.py

cc @jerryzh168

thanks for catching the issue, I think we could just remove the inplace operations in the code

Hi @jerryzh168, thank you for your feedback.
I just tested the code with commit 38dad9b, and the assert torch.equal(res, res2) still fails.
Did you try the above code snippet where I set preserve_zero=True and zero_point_domain = ZeroPointDomain.INT? In this case, the weight_qtensor gets dequantized (calling dequantize_affine) at each forward pass. If int_data is modified in-place, the results of two forward passes will differ.
If that makes sense, I'd be happy to submit a PR to address this issue.

@yiliu30 yes, please feel free to add the test to https://github.com/pytorch/ao/blob/main/test/quantization/test_quant_api.py#L494 for now, and submit the PR, I'd be happy to review

I can reproduce this as well. I'll see if I can fix it too.

@yiliu30 - Please verify that this resolved your issue and reopen the issue if it did not. Thank you for opening the bug report.

@cpuhrsch , it works for me, thanks a lot!


A change of the ghard factor is not applied

If you change the ghard factor in the adapter instance settings, the value is not applied. Even though the instance is restarted, the value in the object tree stays at 0.030303.
There seems to be an issue with the decimal seperator as well. By default the UI shows a comma, but when you enter a new value with  decimal it changes to a dot. Entering the value with dot instead of comma does not solve the issue.
BTW, with the default ghard factor the adapter shows me a ghardness of over 50. My real ghardness is about 28.

Change of the calculation factor in instance settings will be reflected immediately after adapter restart. So the calculation factor in settings is always used for calculation of German Water Hardness but corresponding object is updated only in very long timer method and therefore it takes a while until the new value will be shown in the object. => I will add the readout and actualization for this object into the instance startup process in order to have the correct value in the object right after start of the instance. => Change will be implemented into next release.
Regarding the “decimal separator” issue, there is nothing I can do because this depends on your global ioBroker settings and maybe as well on the country / region settings of your device running ioBroker.
Regarding accuracy of German Water Hardness calculation, you may have a look at the closed Issue #16 (but it’s written in German language) where this topic was already discussed in more detail.
Pleas let me know if I can close this Issue.

ghard factor object will be updated during startup : release v0.2.13


fix: several typos in the docs

Hello
I fixed some typos in the docs,
Hope it helps.
Br,
Tudor.

@tudorpintea999 hey, could you address @mapachurro's review and fix the conflicts please? thanks!


help for team management, fix for create teams route

@keybase/react-hackers

requested by coyne since we can't really add / remove members yet

noticed add channel from the teams page kinda leaves you there , now it'll back out

@chrisnojima Huh, I thought add channel navigated you directly to the new channel you created?

it onlyl does this on chat, and it does this just by selecting it, so its kinda a side effect. this works the same way on chat and on teams now with this, but really it should be smarter

oh you're saying we should switch tabs, yeah we can do that

Oh, I was actually saying that I was worried you were breaking the navigation inside Chat with this change.  Because the same navigateUp() will be run when you're inside Chat.  Now I'm curious why it doesn't break that.


Issue 21017 Fix and Tests

This pull request helps fix the issue #21017, in which the URL now encodes the stream settings panel. This means that when a user is within the stream settings and then proceeds to click the General, Personal, or Subscribers tabs, /General, /Personal, Subscribers will be added to the url respectively. (Shown in image and screen capture below).

https://user-images.githubusercontent.com/97240406/206018531-4555e2b3-4285-443f-9b7b-a826f2c1bdf5.mov
This change adds a new parameter to  the setup_subscriptions_stream_hash function, which is the select_tab variable from the file stream_edit.js. This is used within the setup_stream_settings function, so that once a user clicks on one of the tabs, the url encoding gets hashed, appending the name of the tab to the URL. In order to support this, the select_tab variable was also added to the stream_edit_url function in the static/js/hash_util.js file, as setup_subscriptions_stream_hash makes use of that function. Within the stream_edit_url, switch cases are used to determine which tab name must be appended to the URL. So far no bugs appear to have been encountered
Two tests have also been added to the frontend_tests/node_tests/hash_util.js file, testing when a user hasn't selected a tab yet, and then once a user has selected a tab. These tests are called test_stream_edit_url_empty_select_tab and test_stream_edit_url_select_tab.

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya The PR has been updated to use the proper URL's and all checks have passed.

Thanks! Please clean up your commit history and post again to request a review. See https://zulip.readthedocs.io/en/latest/contributing/version-control.html.

Thanks for working on this @otemitay but I'm going to close this since it never got into a reviewable state.


Docker image using singularity & conda installation not working on Rocky Linux 9

Hello,
I downloaded the docker image as per documentation:
singularity pull docker://quay.io/qiime2/amplicon:2023.9

I then run the image:
singularity run docker://quay.io/qiime2/amplicon:2023.9 /bin/bash

Singularity> qiime --help
Illegal instruction (core dumped)

It seems like the image is not compatible with my os?
Os-release:
NAME="Rocky Linux"
VERSION="9.3 (Blue Onyx)"
ID="rocky"
ID_LIKE="rhel centos fedora"
VERSION_ID="9.3"
PLATFORM_ID="platform:el9"
PRETTY_NAME="Rocky Linux 9.3 (Blue Onyx)"
ANSI_COLOR="0;32"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:rocky:rocky:9::baseos"
HOME_URL="https://rockylinux.org/"
BUG_REPORT_URL="https://bugs.rockylinux.org/"
SUPPORT_END="2032-05-31"
ROCKY_SUPPORT_PRODUCT="Rocky-Linux-9"
ROCKY_SUPPORT_PRODUCT_VERSION="9.3"
REDHAT_SUPPORT_PRODUCT="Rocky Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="9.3"

Singularity version:
singularity version 3.8.7-3.fc37

I tried the conda installation as well:
conda activate qiime2-amplicon-2023.9
QIIME is caching your current deployment for improved performance. This may take a few moments and should only happen once per deployment.
Illegal instruction (core dumped)

I don't have any other issues with running singularity or conda on the server. It has so far only happened with the qiime2 installation.
Any suggestions?

Hi @makrez,
Could you please re-post this question on our user forum? That's where we can assist with install issues, and other questions on using QIIME 2. Thanks!


feat: add support for named exports

Which problem is this PR solving?

Helps with https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2005
Closes #27 (I think)

Short description of the changes
There is some explanation here of the problems we were running into while trying to update our tests to use a new test runner. It seems that this will be resolved by providing named exports, which may help other folks using ESM as well.

Use named exports for wrap, unwrap, massWrap, massUnwrap
Add tests asserting named imports work, and also that wrap works with a named import
Update scripts to include the new test
Upgrade tap to v15.2. It needed a later version to allow proper testing of ESM files, but previous versions before 15.0 used a module @std/esm that didn't work as expected in tests. The latest version has some other changes so I opted for 15.2 to minimize overall changes while still allowing this test to work.

Since this is a larger change because of the test updates, I'm more than happy to reduce this to only add the named exports and not make adjustments to tests and updating the tap package.


feat(tasks, agents): support velocity tasks

Description

Support velocity tasks.
Add new agents forked from gymnasium.
Add tests for new tasks.
Update the color of the floor in old tasks.
After detailed testing:

Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[x] My change requires a change to the documentation.
[x] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.
[ ] I have reformatted the code using make format. (required)
[ ] I have checked the code using make lint. (required)
[ ] I have ensured make test pass. (required)

This PR needs to be done after the dev branch rebase main branch.


use older function to support old Postgres

closes #67
This PR replace string_to_table(...) by unnest(string_to_array(...)) to support older postgres

string_to_table() provides the set-based equivalent to string_to_array(), and is functionally the same albeit somewhat faster than unnest(string_to_array())

From PG docs: https://pgpedia.info/s/string_to_table.html
Note: we could also use regexp_split_to_table https://pgpedia.info/r/regexp_split_to_table.html which seems to give the same result 🤷

👋 @bitner ☝


Experimental/Beta installation docs

This PR adds docs for installing OPS as a developer install and adding a remote (and checking out a specific branch) from another developer. This workflow will be common when we ask users to verify bugfixes, or when users are interested in experimenting with features that are still in development.
Our advanced users are already doing this (@sroet @hejung — if you have a chance to look over these docs in the next day or two, please let me know if they make sense to you, since you're already doing these things.)
This also includes a fix to the testing section of the installation docs to include use of pytest.
This is a docs-only PR, so it should be easy to review. I'm giving 72 hours to review this; will merge on Thursday if no comments.

Looks good. And Hello again :)

Fixed the typo that Sander found, and made a few points a bit clearer. Since this has approval, will merge it this evening if no objections are raised. (Hi @jhprinz!)


Example in README.md uses wrong (old?) trait name

The trait with load()... should probably be Authentication, not SQLxSessionAuth.

thank you it was from a slightly older setup.


update citations.md

Description of feature
We need to update citations.md file

done. closed #133


pc init isn't working (windows)

When i use "pc init" is is just cming one line:
"Skipping bun installation on windows"
it isn't creating any kind of template or anything, it isn't even counting as an init when i run "pc run", it is just that one line and nothing else
Specifies:

Python Version: 3.11.0
Pynecone Version: 0.1.26
OS: Windows
NodeJS is installed

I just reverted the last release - try use pynecone v0.1.24 and let me know if you have issues.

It worked, thank you


Bump all dependencies to latest to upgrade controller-runtime

What this PR does / why we need it:
This upgrades all dependencies of the project to their latest releases. The most notable of those is controller-runtime, which has seen some significant rework. No semantic changes are intended in this change.
Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Hmm. Gotta fix the code generation. Will take care of that.

might need go mod tidy for this?
https://github.com/fluent/fluent-operator/actions/runs/7711728924/job/21017658151?pr=1050

Hmm. This diff is becoming much larger than intended because the PodSpec grew quiet a bit between versions, I suppose.

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

Hmm. This diff is becoming much larger than intended because the PodSpec grew quiet a bit between versions, I suppose.

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

@wanjunlei what do you think?

Hmm. This diff is becoming much larger than intended because the PodSpec grew quiet a bit between versions, I suppose.

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

@wanjunlei what do you think?

I think it's more appropriate to upgrade the controller runtime in smaller steps.

@dependabot rebase

@benjaminhuo As mentioned above, this diff has grown quite a bit. We could try to make it smaller by upgrading controller-runtime in smaller steps or trying to break the K8s upgrades out. Let me know if you'd like me to invest some effort into trying to make the diff smaller.

We might need to catch up with the upstream k8s community updates and drop supports for lower version K8s.
The dependencies are quite obsolete, so maybe big changes are also acceptable as long as we add a k8s support metrics @markusthoemmes @wanjunlei

We might need to catch up with the upstream k8s community updates and drop supports for lower version K8s.

we really need to catch up with upstream now because there're quite big differences and the code cannot compile with latest  k8s dependencies:

Fixed by https://github.com/fluent/fluent-operator/pull/1251, close this one


./xdebugPhpFpm start/stop

I'm not able in getting the ./xdebugPhpFpm start/stop script to work on my windows machine. If I'm correct it's a bash script, so I cannot execute it trough a regular windows command. With windows 10 there is an option however to use Bash on Ubuntu on Windows. Trough this bash console I can execute the script, however the script is not able to execute docker-compose because it is a windows command.
So I'm stuck between two options. Trough windows console I can't execute the bash script and trough the bash console I can't execute the windows command.
Am I doing something wrong?

Noticed that this question was asked and answered here.


sway: 1.8 -> 1.8.1

Description of changes
Release notes: https://github.com/swaywm/sway/releases/tag/1.8.1
I tested bin/sway, everything seems to work.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 216050 run on x86_64-linux 1

7 packages built:

nwg-panel
sway
sway-contrib.grimshot
sway-contrib.inactive-windows-transparency
sway-unwrapped
waybar
wlprop


Rework the SetSignerList transactor

Looking at @scottschurr's #2649 I struggled to understand the SetSignerList transactor. It is way more confusing than it needs to be with custom structs and tuples and way too many functionsWithUnnecessarilyLongNames spread over several files.
Before I got too far I want to see if there's interest. This compiles but won't pass any tests because I haven't written any. No point if this PR won't get any interest.
Obvioulsy this is only for 756086b. Should i fiish up the unit tests and submit this formally?

Thank you for your submission. It will be reviewed soon and submitted for processing in CI.

Ping @JoelKatz @scottschurr @nbougalis @seelabs @wilsonianb @bachase @ximinez

Thanks for your PR and for choosing to contribute to rippled.
We will review and consider any PR that improves the codebase, whether it involves adding new functionality, improving existing functionality or addressing technical debt. I'd urge you to only submit this PR when you feel that it is complete; but given that you don't consider the PR complete at this point, I think that a review would be premature.
I would also like to take a moment to urge everyone choosing to work on open-source projects to consider how they interact with others; anonymity doesn't mean foregoing manners and isn't a license to be rude. You can have substantive differences and engage with others on the technical merits of a change without being confrontational. You should always strive to remain respectful and professional in [i]all[/i] your interactions.

Jenkins Build Summary
Built from this commit
Built at 20181001 - 18:01:58
Test Results

Build Type
Log
Result
Status

Approval Check
console
Build aborted by [Michael Ellery]
FAIL :red_circle: