Convert unit tests to googletest

Description

Converts all unit tests to use googletest within a separate project saved in test/unit_tests. These unit tests are run along with extant model tests via RUN_TESTS:Build.
The CMake script for HPWHsim was changed to use $(PROJECT_NAME) (currently set as HPWHsim) as the name of the compiled library, rather than libHPWHSim. The corresponding change was made in a cse branch add-unit-tests-hpwh.
The file testUtilityFFcts.cc was removed entirely. Code within that file was either redundant, no longer needed, or changed to HPWH member functions. The function getHPWHObject was changed to an overloaded version of HPWH::initPreset using a string argument. Some function names were altered slightly for clarity.
The changes above highlighted the special case of HPWH model TamScalable_SP. The code allowed initiating variations of this model with double- and half-heating capacities, but these sub-models do not exist by model number, so ad hoc code had been inserted to perform the scaling after initialization via Preset. These were changed to regular models, with the scaling done in HPWH::initPreset.  (Alternatively, model modifiers could be used to distinguish these, which seemed outside the scope of this PR.) The non-member function scaleVector was added to perform the scaling. These submodel numbers remain undefined in cse.
An additional constexpr was defined to convert between metric and imperial units for $r$ values.
All HPWH tests are passed in their new forms.
The companion cse branch passes all tests.

Author Progress Checklist:

[X] Open draft pull request

[X] Make title clearly understandable in a standalone change log context
[X] Assign yourself the issue
[X] Add at least one label (enhancement, bug, or maintenance)
[x] Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)

[X] Make code changes (if you haven't already)
[X] Self-review of code

[X] My code follows the style guidelines of this project
[X] I have added comments to my code, particularly in hard-to-understand areas
[X] I have only committed the necessary changes for this fix or feature
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have ensured that my fix is effective or that my feature works as intended by:

[x] exercising the code changes in the test framework, and/or
[X] manually verifying the changes (as explained in the the pull request description above)

[X] My changes pass all local tests
[X] My changes successfully passes CI checks
[X] Add any unit test for proof and documentation.
[X] Merge in main branch and address resulting conflicts and/or test failures.

[X] Move pull request out of draft mode and assign reviewers
[] Iterate with reviewers until all changes are approved

[ ] Make changes in response to reviewer comments
[ ] Merge in main branch and address resulting conflicts and/or test failures.
[ ] Re-request review in GitHub

Reviewer Checklist:

[ ] Read the pull request description
[ ] Perform a code review on GitHub
[ ] Confirm all CI checks pass and there are no build warnings
[ ] Pull, build, and run automated tests locally
[ ] Perform manual tests of the fix or feature locally
[ ] Add any review comments, if applicable
[ ] Submit review in GitHub as either

[ ] Request changes, or
[ ] Approve

[ ] Iterate with author until all changes are approved

@spahrenk this looks good to me. A lot of unrelated cleanup here too that should maybe be in a separate branch, but it's not worth the effort to separate it out now. The source file in the companion CSE branch been completely reformatted, making it impossible to see where the API has caused changes. This highlights the need to get clang formatting set up in CSE, but for now, can you change the branch with your "autoformat" turned off?

Ah, OK. I'll clean that up.

Codecov Report
Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (4d4977d) 66.12% compared to head (554b169) 66.82%.

Files
Patch %
Lines

src/HPWH.cc
85.34%
34 Missing :warning:

src/HPWHpresets.cc
85.19%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   66.12%   66.82%   +0.70%
==========================================
  Files           6        6
  Lines        4976     5154     +178
==========================================
+ Hits         3290     3444     +154
- Misses       1686     1710      +24

Flag
Coverage Δ

integration
66.82% <85.66%> (+0.70%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for the adxl345#2

An alternative to PR#45, this PR aims to add support for ADXL345 into the OpenEEW firmware code using ADXL345_WE library.
It will interface the ADXL345 sensor over I2C to the ESP32 and will use fifo to get the readings, so that existing code will not need much replacement/ modification.

Fixes issue https://github.com/openeew/openeew-firmware/issues/41


notifcation attribute and event

1. Why is this change necessary?
Because nobody was able to take affect to the notification function by valid subscription or custom attributes
2. What does this change do, exactly?
Add a Table s_articles_notification_attributes.
Add a Event to take affect on the Notification database subscription
Pass through the attributes for the notifications to the mail tempalate
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[x] I have written tests and verified that they fail without my change - there were tests already
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

@mitelg what do i have to do for scheduling the pr?

@dasistweb-gmbh please be patient :blush:
normally we meet on a daily base, but today we skipped the meeting :disappointed:

@mitelg ok, alright :) i only wanted to get sure there's nothing i can do

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-22554
Please use this issue to track the state of your pull request.

CLA already signed.

Hi @dasistweb-gmbh, your PR got merged in c2feba646c6f9236d12ef3cff239fdd8532aebf0. Thank you for your contribution! 💙 🎉


ARXINVG-1038 - add support for legacy /abs request parameters

This PR essentially covers the conversion of https://github.com/cul-it/arxiv-httpd/blob/master/cgi-bin/abs.pl#L63-L124.
Some of these cases (like singleton parameters on /abs absent of any other path info) are fairly rare and might be candidates for removal in a future release.
The fmt=txt case is supported by a new Docmetadata field called raw_safe which is the raw abs string minus the submitter email address.
Examples are demonstrated in test cases.

Pull Request Test Coverage Report for Build 174

69 of 69 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 92.742%

Totals

Change from base Build 155:
0.2%

Covered Lines:
2300

Relevant Lines:
2480

💛  - Coveralls


[Bug] tpcds sf1000 core dump

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
dev-1.0.1
What's Wrong?
``
#0  tcmalloc::SLL_Next (t=0x61000000163) at ./src/linked_list.h:45
#1  tcmalloc::SLL_TryPop (list=0x9b9d440, rv=) at ./src/linked_list.h:69
#2  tcmalloc::ThreadCache::FreeList::TryPop (this=0x9b9d440, rv=) at ./src/thread_cache.h:220
#3  tcmalloc::ThreadCache::Allocate (this=0x9b9d3c0, size=48, cl=, oom_handler=) at ./src/thread_cache.h:379
#4  malloc_fast_path<&tcmalloc::cpp_throw_oom> (size=) at src/tcmalloc.cc:1898
#5  tc_new (size=) at src/tcmalloc.cc:2019
#6  0x0000000001dccf81 in std::__cxx11::basic_string<char, std::char_traits, std::allocator >::_M_construct<char const*> (
this=0x7fddcbd738c0, __beg=0x2a3cc080 "doris::vectorized::IColumn::clone_empty() const", __end=)
at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/basic_string.tcc:219
#7  std::__cxx11::basic_string<char, std::char_traits, std::allocator >::_M_construct_aux<char const*> (this=0x7fddcbd738c0,
__beg=0x2a3cc080 "doris::vectorized::IColumn::clone_empty() const", __end=)
at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/basic_string.h:247
#8  std::__cxx11::basic_string<char, std::char_traits, std::allocator >::_M_construct<char const*> (this=0x7fddcbd738c0,
__beg=0x2a3cc080 "doris::vectorized::IColumn::clone_empty() const", __end=)
at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/basic_string.h:266
#9  std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string<std::allocator > (this=0x7fddcbd738c0,
__s=0x2a3cc080 "doris::vectorized::IColumn::clone_empty() const", __a=...)
at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/basic_string.h:527
#10 boost::core::demangle[abi:cxx11](char const*) (name=)
at /root/regression/incubator-doris/thirdparty/installed/include/boost/core/demangle.hpp:99
#11 0x0000000001dccb06 in boost::stacktrace::detail::to_string_impl_baseboost::stacktrace::detail::to_string_using_backtrace::operator()[abi:cxx11](void const*) (this=this@entry=0x7fddcbd73950, addr=0x1f76451 <doris::vectorized::IColumn::clone_empty() const+17>)
at /root/regression/incubator-doris/thirdparty/installed/include/boost/stacktrace/detail/frame_unwind.ipp:41
#12 0x0000000001dcc948 in boost::stacktrace::detail::to_string[abi:cxx11](boost::stacktrace::frame const*, unsigned long) (frames=0x1b031b00, size=18)
at /root/regression/incubator-doris/thirdparty/installed/include/boost/stacktrace/detail/frame_unwind.ipp:76
#13 0x0000000001dc95a6 in boost::stacktrace::to_string<std::allocatorboost::stacktrace::frame > (bt=...)
at /root/regression/incubator-doris/thirdparty/installed/include/boost/stacktrace/stacktrace.hpp:402
#14 boost::stacktrace::operator<< <char, std::char_traits, std::allocatorboost::stacktrace::frame > (bt=..., os=...)
at /root/regression/incubator-doris/thirdparty/installed/include/boost/stacktrace/stacktrace.hpp:408
#15 doris::signal::(anonymous namespace)::FailureSignalHandler (signal_number=, signal_info=, ucontext=)
at /root/regression/incubator-doris/be/src/common/signal_handler.h:420
#16
#17 tcmalloc::SLL_Next (t=0x61000000163) at ./src/linked_list.h:45
#18 tcmalloc::SLL_TryPop (list=0x9b9d440, rv=) at ./src/linked_list.h:69
#19 tcmalloc::ThreadCache::FreeList::TryPop (this=0x9b9d440, rv=) at ./src/thread_cache.h:220
#20 tcmalloc::ThreadCache::Allocate (this=0x9b9d3c0, size=48, cl=, oom_handler=) at ./src/thread_cache.h:379
#21 malloc_fast_path<&tcmalloc::cpp_throw_oom> (size=) at src/tcmalloc.cc:1898
#22 tc_new (size=, size@entry=40) at src/tcmalloc.cc:2019
#23 0x0000000002537e42 in COWHelper<doris::vectorized::ColumnVectorHelper, doris::vectorized::ColumnVector >::create<>() ()
at /root/regression/incubator-doris/be/src/vec/common/cow.h:413
What You Expected?
does not core dump
How to Reproduce?
WITH   ss AS (    SELECT      s_store_sk    , sum(ss_ext_sales_price) sales    , sum(ss_net_profit) profit    FROM      store_sales    , date_dim   , store    WHERE (ss_sold_date_sk = d_date_sk)       AND (d_date BETWEEN CAST('2000-08-23' AS DATE) AND (CAST('2000-08-23' AS DATE) + INTERVAL  '30' DAY)   )       AND (ss_store_sk = s_store_sk)    GROUP BY s_store_sk ) , sr AS (    SELECT      s_store_sk    , sum(sr_return_amt) returns    , sum(sr_net_loss) profit_loss    FROM      store_returns    , date_dim    , store    WHERE (sr_returned_date_sk = d_date_sk)       AND (d_date BETWEEN CAST('2000-08-23' AS DATE) AND (CAST('2000-08-23' AS DATE) + INTERVAL  '30' DAY))       AND (sr_store_sk = s_store_sk)    GROUP BY s_store_sk ) , cs AS (    SELECT      cs_call_center_sk    , sum(cs_ext_sales_price) sales    , sum(cs_net_profit) profit    FROM      catalog_sales    , date_dim    WHERE (cs_sold_date_sk = d_date_sk)       AND (d_date BETWEEN CAST('2000-08-23' AS DATE) AND (CAST('2000-08-23' AS DATE) + INTERVAL  '30' DAY))    GROUP BY cs_call_center_sk ) , cr AS (    SELECT      cr_call_center_sk    , sum(cr_return_amount) returns    , sum(cr_net_loss) profit_loss    FROM      catalog_returns    , date_dim    WHERE (cr_returned_date_sk = d_date_sk)       AND (d_date BETWEEN CAST('2000-08-23' AS DATE) AND (CAST('2000-08-23' AS DATE) + INTERVAL  '30' DAY))    GROUP BY cr_call_center_sk ) , ws AS (    SELECT      wp_web_page_sk    , sum(ws_ext_sales_price) sales    , sum(ws_net_profit) profit    FROM      web_sales    , date_dim    , web_page    WHERE (ws_sold_date_sk = d_date_sk)       AND (d_date BETWEEN CAST('2000-08-23' AS DATE) AND (CAST('2000-08-23' AS DATE) + INTERVAL  '30' DAY))       AND (ws_web_page_sk = wp_web_page_sk)    GROUP BY wp_web_page_sk ) , wr AS (    SELECT      wp_web_page_sk    , sum(wr_return_amt) returns    , sum(wr_net_loss) profit_loss    FROM      web_returns    , date_dim    , web_page    WHERE (wr_returned_date_sk = d_date_sk)       AND (d_date BETWEEN CAST('2000-08-23' AS DATE) AND (CAST('2000-08-23' AS DATE) + INTERVAL  '30' DAY))       AND (wr_web_page_sk = wp_web_page_sk)    GROUP BY wp_web_page_sk ) SELECT   channel , id , sum(sales) sales , sum(returns) returns , sum(profit) profit FROM   (    SELECT      'store channel' channel    , ss.s_store_sk id    , sales    , COALESCE(returns, 0) returns    , (profit - COALESCE(profit_loss, 0)) profit    FROM      ss    LEFT JOIN sr ON (ss.s_store_sk = sr.s_store_sk) UNION ALL    SELECT      'catalog channel' channel    , cs_call_center_sk id    , sales    , returns    , (profit - profit_loss) profit    FROM      cs    , cr UNION ALL    SELECT      'web channel' channel    , ws.wp_web_page_sk id    , sales    , COALESCE(returns, 0) returns    , (profit - COALESCE(profit_loss, 0)) profit    FROM      ws    LEFT JOIN wr ON (ws.wp_web_page_sk = wr.wp_web_page_sk) )  x GROUP BY ROLLUP (channel, id) ORDER BY channel ASC, id ASC, sales ASC LIMIT 100
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I want to reproduce this, but I can't running, you can put the sql number about tpcds
ERROR 1105 (HY000): errCode = 2, detailMessage = aggregate function cannot contain aggregate parameters: sum(sum(sales))

It should be q77.

It should be q77.
I test newest dev-1.0.1.  it's could get result;
Are there any other steps need？

runtime error: member call on address 0x00002af70680 which does not point to a
n object of type 'doris::vectorized::ColumnVectorHelper'


Sending tokens to other Adress: failed transaction

If you are reporting a problem with ICO Wizard, please include the following information:
Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)
Ropsten Test Net
If you were able to create it, what is the URL of your crowdsale?
https://wizard.oracles.org/invest?addr=0x2171ADE6cCE61694Ed75926EADA5aCE2e8E9d1f2&networkID=3
Do you have screenshots showing the problem?
Transferring Created Tokens to other addresses Fails.
Any approval within the Contracts fails also. Cant set minting finished function.
 Any suggestions? Contract is Standard One.

Do you see errors in the dev console? If yes, please include a screenshot
No, Errors in DEV.
(To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab)
Your answer

You need to finalize your crowdsale first, please read an article about Finalizing in our wiki

thx. working now.


Update to FTC SDK v9.0

https://ftc-docs.firstinspires.org/en/latest/ftc_sdk/updating/rc_app/Updating-the-RC-App.html

so we are actually on 9.0, there's justa bug in it that it says its out of date when it isnt


Add an HTTPException for when the engine fails in query.py #29

{"tag": "INITIAL_PLANNING", "workflow": {"tasks": [{"step": "Step 1", "name": "Import HTTPException", "action": "modify", "file": "routers/retrievers/query.py", "start_line": 1, "end_line": 1, "instructions": "At the top of the file, import HTTPException from fastapi.exceptions by adding the line 'from fastapi.exceptions import HTTPException'. This will allow us to raise the HTTPException when the engine fails.", "async_score": 2, "assigned_agent": "AI", "dependencies": []}, {"step": "Step 2", "name": "Add HTTPException", "action": "modify", "file": "routers/retrievers/query.py", "start_line": 10, "end_line": 20, "instructions": "Identify the section of the code where the engine is called and could potentially fail. Surround this section with a try-except block. In the except block, raise an HTTPException with a status code of 500 and a detail message indicating that the engine has failed. This will look something like 'except Exception: raise HTTPException(status_code=500, detail='Engine failure')'.", "async_score": 7, "assigned_agent": "AI", "dependencies": ["Step 1"]}, {"step": "Step 3", "name": "Write tests for HTTPException", "action": "create", "file": "tests/test_query.py", "start_line": 1, "end_line": 50, "instructions": "Create a new file in the tests directory called test_query.py. In this file, write tests to ensure that the HTTPException is raised when the engine fails. This will involve creating a mock engine that always fails, and then calling the function in query.py that uses this engine. The test should assert that an HTTPException with a status code of 500 is raised. Make sure to import the necessary modules and functions, including HTTPException from fastapi.exceptions and the function you are testing from query.py.", "async_score": 8, "assigned_agent": "AI", "dependencies": ["Step 1", "Step 2"]}], "snippets": []}}
Step 1: Import HTTPException
	Action: modify
	File: routers/retrievers/query.py
	Start Line: 1
	End Line: 1
	Instructions: At the top of the file, import HTTPException from fastapi.exceptions by adding the line 'from fastapi.exceptions import HTTPException'. This will allow us to raise the HTTPException when the engine fails.
	Async Score: 2
	Assigned Agent: AI
	Dependencies: []
Step 2: Add HTTPException
	Action: modify
	File: routers/retrievers/query.py
	Start Line: 10
	End Line: 20
	Instructions: Identify the section of the code where the engine is called and could potentially fail. Surround this section with a try-except block. In the except block, raise an HTTPException with a status code of 500 and a detail message indicating that the engine has failed. This will look something like 'except Exception: raise HTTPException(status_code=500, detail='Engine failure')'.
	Async Score: 7
	Assigned Agent: AI
	Dependencies: ['Step 1']
Step 3: Write tests for HTTPException
	Action: create
	File: tests/test_query.py
	Start Line: 1
	End Line: 50
	Instructions: Create a new file in the tests directory called test_query.py. In this file, write tests to ensure that the HTTPException is raised when the engine fails. This will involve creating a mock engine that always fails, and then calling the function in query.py that uses this engine. The test should assert that an HTTPException with a status code of 500 is raised. Make sure to import the necessary modules and functions, including HTTPException from fastapi.exceptions and the function you are testing from query.py.
	Async Score: 8
	Assigned Agent: AI
	Dependencies: ['Step 1', 'Step 2']


Service Request by Nick Bove

[ ] Qualtrics Service Request Form was received from User
[ ] e-mail acknowledging that User's Qualtrics Service Request Form was sent
[ ] Problem NOT RESOLVED
[ ] Problem PARTIALLY RESOLVED
[ ] Problem FULLY RESOLVED and Issue is Closed
[ ] Qualtrics Post-Service Request Survey was sent to User

Use comments feature (below) to document:

A clear and concise description of the solution.

A clear and concise description of any alternative solutions or features you've considered.

Any additional context, such as screenshots about the problem.

Hi Team,
Has anyone updated Lewis County's IPA's lately? If not, has anyone heard of data being deleted in the tracker after being saved? I've not come across this issue as of yet.
Thanks,
Nick

Hi Megan,
I’m sorry this has happened. I’ll follow up with Donrie and
David to see if anyone may have deleted that “IPA”. This is the first I’m
hearing of IPA’s or any data being deleted unless it hasn’t been saved. I’ll
follow up with Jeff, our coder as well and get back to you.
My Best,
Nick

From: Megan Donato
<EMAIL_ADDRESS>Sent: Wednesday, September 8, 2021 12:18 PM
To: Nicholas Bove<EMAIL_ADDRESS>Subject: IPA Tracker

CAUTION: This email comes from an external   source; the attachments and/or links may compromise our secure environment.   Do not open or click on suspicious emails. Please click on the “Phish Alert”   button on the top right of the Outlook dashboard to report any suspicious   emails.
Hi Nick,

I am in the IPA tracker and notice that an IPA/Strategy are
no longer listed.  I had made an IPA/Strategy for more general
measures.  It wasn’t truly an IPA but a way for me to track and monitor
more overarching data related to the study (ODs, OD deaths, county-wide
naloxone distribution, etc.).  Now it is no longer in the tracker.
Do you know if anything happened that would have wiped that from the tool?

Thanks,
Megan

Ideally nothing should be deleted unless someone manually deleted it.

Thanks Donrie. I agree. Perhaps her colleague went in and accidentally deleted it?

I agree. Data is not deleted unless a user deletes it. And we do not delete entries. However, Donrie, we just asked Jeff to purge some 'old, unassigned' data records. I wonder if her work was cleaned up when Jeff did that for us.
In any case, please follow up to help her recover or reenter what she needs.
THANKS

Great, will do!


Exploratory Sprint: Optimizing for Speed Run

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/918
Originally created by @derek-knox on 2019-08-23 14:06:51

This issue is meant to house a discussion around ideas for optimizing the speed run UX flow of Meltano. Some decisions can have a large impact on the UX and that's why this issue exists prior to jumping straight to feature issues.
I just want us to be cognizant of the tradeoffs of skipping ahead for speed at the potential loss of exposure to sub-UIs, Meltano concepts, and the ELT process itself.

View 3 previous comments from the original issue on GitLab


Trying to pass custom prompt in load_qa_with_sources_chain results in error

Running the code below produces the following error: document_variable_name summaries was not found in llm_chain input_variables: ['name'] (type=value_error)
Any ideas?
Code:
def use_prompt(self, template: str, variables=List[str], verbose: bool = False):
    prompt_template = PromptTemplate(
        template=template,
        input_variables=variables,
    )

    self.chain = load_qa_with_sources_chain(
        llm=self.llm,
        prompt=prompt_template,
        verbose=verbose,
    )

use_prompt(template="Only answer the question 'What is my name?' by replaying with only the name. My name is {name}", variables=["name"])

That should work
It seems to be expecting {summaries} variable,
try this, it should work
def use_prompt(template: str, variables=List[str], verbose: bool = False):
    prompt_template = PromptTemplate(
        template=template,
        input_variables=variables,
    )
    llm = NewAzureOpenAI(deployment_name=deployment_name, temperature=0.5)
    chain = load_qa_with_sources_chain(
        llm=llm,
        prompt=prompt_template,
        verbose=verbose,
    )

use_prompt(template="""Only answer the question 'What is my name?' by replaying with only the name. My name is {name}
    =========
    {summaries}
    =========
    Final Answer:""", variables=["summaries", "name"])

I may really be doing something wrong. I get the error: ValueError: Missing some input keys: {'name'} with the code below. I pass exactly what you provided, right? Am i missing something? Could this be a bug?
from langchain import PromptTemplate
from langchain.chains.qa_with_sources import load_qa_with_sources_chain
from langchain.chat_models import ChatOpenAI
from dotenv import load_dotenv

load_dotenv()

def get_chain(template: str, variables, verbose: bool = False):
    llm = ChatOpenAI()

    prompt_template = PromptTemplate(
        template=template,
        input_variables=variables,
    )
    return load_qa_with_sources_chain(
        llm=llm,
        prompt=prompt_template,
        verbose=verbose,
    )

chain = get_chain(template="""Only answer the question 'What is my name?' by replaying with only the name. My name is {name}
    =========
    {summaries}
    =========
    Final Answer:""", variables=["summaries", "name"])

question = "test question?"
answer = chain.run(input_documents="", question=question)

I am a bit confused about how you're defining "name" in the prompt, actually I don't exactly understand the prompt since you do not take the name as input anywhere, what do you want to do exactly?
This works for me:
from langchain import PromptTemplate
from langchain.chains.qa_with_sources import load_qa_with_sources_chain
from langchain.chat_models import ChatOpenAI
from dotenv import load_dotenv
load_dotenv()
def get_chain(template: str, variables, verbose: bool = False):
llm = ChatOpenAI(engine=deployment_name)
prompt_template = PromptTemplate(
    template=template,
    input_variables=variables,
)
return load_qa_with_sources_chain(
    llm=llm,
    prompt=prompt_template,
    verbose=verbose,
)

chain = get_chain(template="""Only answer the question 'What is my name?' by replaying with only the name. My name is name
=========
{summaries}
=========
Final Answer:""", variables=["summaries"])
question = "test question?"
answer = chain.run(input_documents="", question=question)
print(answer)

How would the screenshot u shared work if you're not passing the summaries variable when you call run?

Another question about this. Why is {summaries} required at all? Shouldn't I be able to create a template that takes only the inputs I want it to take?

Is there an example of making it work with RetrievalQA ?
The code examples above do not work with RetrievalQA

I have the same issue...
other google search pointed out that i need to create a variable called "context" but i dont need it..

Have there been any resolutions here? This issue is still persistent. I am getting the same error when I am passing a custom prompt purposefully with no variables associated with the f-string. Following the documentation directly from LangChain:
https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/

Maybe this helps:
`
messages = [
SystemMessagePromptTemplate.from_template(promptTemplate),
HumanMessagePromptTemplate.from_template("{question}")
]
qa_prompt = ChatPromptTemplate.from_messages(messages)
qa_chain = ConversationalRetrievalChain.from_llm(
llm, retriever, memory=memory,get_chat_history=lambda h : h,combine_docs_chain_kwargs={"prompt": qa_prompt})
`

I have the same issue... other google search pointed out that i need to create a variable called "context" but i dont need it..

Did you ever solve it? What did you do


"change pen (color) by" errors out when serializing

It looks like we name one input colorParam instead of COLOR_PARAM. I noticed this when trying to strictly type the Scratchblocks output for the strict TypeScript PR.

Oh wow, can you check if this makes rendering at least do anything (rather than black screen) in the project linked in leopard-js/leopard#162? It's possible it's unrelated, but this seems like the kind of mistake which would cause a block to unintentionally no-op without visible error.

Probably not--the Leopard export works but the SB3 export was broken.


Better port detection in TcpSourceTest

From @sabbyanandan on May 6, 2016 17:8
From @ericbottard on December 18, 2015 11:24
in TcpSourceTest, use notification of TcpConnectionServerListeningEvent instead of polling to determine port.
see https://github.com/spring-cloud/spring-cloud-stream-modules/blob/7004eedcf5a8df87eaf8f9a3a796c0dab26ed5c0/tcp-source/src/test/java/org/springframework/cloud/stream/module/tcp/source/TcpSourceTests.java#L196
Copied from original issue: spring-cloud/spring-cloud-stream-modules#140
Copied from original issue: spring-cloud/spring-cloud-stream-app-starters#68

From @garyrussell on December 18, 2015 14:58
Note that this requires Spring Integration 4.3 which is not planned to be available until next summer, so this needs to stay on the backlog.


fix github page warning by replacing highlighter value

Followed the instructions in #697 . Fixed.
Has to be varied by merging this pull request.

Comments were fixed, and Merging.


AnyHttpUrl type parameter instead of raw str

Description
AnyHttpUrl type parameter instead of raw str
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.15%. Comparing base (468170b) to head (c3b41e6).
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   95.15%   95.15%
=======================================
  Files          55       55
  Lines        2045     2045
=======================================
  Hits         1946     1946
  Misses         99       99

Files
Coverage Δ

ols/app/models/config.py
95.95% <100.00%> (ø)

/retest

/lgtm

Isn't _is_valid_http_url redundant? Pydantic checks the value agains AnyHttpUrl, right?

I was also wondering this.
what happens to calls like this if the value is not a url?
https://github.com/openshift/lightspeed-service/blob/65e44ad1c5f9ce0762b4fa00842c818ddf990dd3/ols/app/models/config.py#L242
i assume it'll fail right there in pydantic validation, before it ever gets to:
https://github.com/openshift/lightspeed-service/blob/65e44ad1c5f9ce0762b4fa00842c818ddf990dd3/ols/app/models/config.py#L284
?

We were talking about this with Pavel offline. TLDR, as we are overriding the init (and not passing the data through super) in most of our config objects, we are doing the validation on our side.
That is one of the issues Michal was solving in his PR.

/approve


Cannot pre define constants

4.x
Description
I could not see any chance to define constants (e.g. ASSETS_DIR) before "framework/src/includes/constants.php" loaded.
I know in 3.x version, you can define constants in _ss_environment.php which is loaded before the silverstripe constants. Not sure how to do it in 4.x

I believe you’ll need to define them in index.php before the include vendor/autoload.php statements


Site Updated

Added 11 more mods and 6 more android mods. Added videos to mods submenu.

See commit messages.


Remove support for verify_subject_alt_name in CertificateValidationContext

This field has been deprecated in favor of of the match_subject_alt_names field which provides more flexible matching.
SAN list can still be specified via transport_socket_options's SAN list override and verified via verifySubjectAltName

Risk Level: Low
Testing: local test on linux (bazel test //test/...)

/retest

Adi, can you take a first pass?

@htuch @mattklein123 Are there any docs that need an update when removing the implementation of an already deprecated (v2) feature?
I'm guessing there's no need, as the entire v2 is not allowed, but wanted to make sure.

LGTM
Thanks for cleaning this up!

Thanks for review, Adi!  I just posted a comment/questions at the same time you reviewed the CL. Please take another quick look. Thanks!

I'm guessing there's no need, as the entire v2 is not allowed, but wanted to make sure.

Yeah, if the feature is v2 only no docs are needed.


BOOT LOOP IS CAUSED BY KERNEL PATCH CONFIRMED!

BOOT LOOP IS CAUSED BY KERNEL PATCH CONFIRMED!
update kernel patch for ios17

I don't get a bootloop, just some iBoot Error, it doesn't work though so I think that the dev should update this

umit is and also mounting is different in ios17


Issue with k8s.io/docs/tutorials/configuration/configure-redis-using-configmap/

The command (kubectl delete pod/redis configmap/example-redis-config) suggested to delete a pod (redis pod) ~ doesn't actually delete the pod. The deleted pod sticks around, and when lunching(updating) the pod as indicated in the documentation, the status CrashLoopBackOff re-tries indifinitely.

@sftim ~ If you waited to see if the Pod was removed after some time, how long did you wait? - Indefinitely. I had to reboot my computer. You are right, the Pod sticks around forever for some weird reasons.
I learnt after the fact that deleting the Deployment and not the Pod is the way to go. The question is, can that be mentioned in the documentation?

@murindwaz i think the description of the command is to delete the pod , it;s not certain that pod is deployed through deployment or statefulset.i think it's just an example statement . what you think @sftim

We know from https://k8s.io/docs/tutorials/configuration/configure-redis-using-configmap/ that the Pod was directly created.
If you're not following this guide, pasting in excerpts from it might not achieve what you want.
/kind support
/close


Fix viewBox of ViewportSpeed.svg

Fixes #58434
Unlike other icons, this SVG has a small viewBox attribute.
3.x is fine probably because we changed the SVG backend on master. Maybe this is also worth cherry-picking?

Thanks!


Project on archive page

Not sure if this is already possible, but it would be nice to display projects on the archive page as well

You can set the archive's section_path to a list of paths. See the docs.

Thank you!


WebDriver 5: Test fails with option manualStart=true: Cannot read property '$$' of undefined

It seems to be a regression in WebDriver 5. It works well with WebDriver 4 unless you upgrade using npm i webdriver@5.
It doesn't depend if you change the string "WebDriverIO" => "WebDriver" (ver. 5) in config file and helper or if you keep using "WebDriverIO" (ver. 4) in your config/helper.
What are you trying to achieve?
I want to start browser manually
What do you get instead?

Provide console output if related. Use --verbose mode for more details.

$ ../../node_modules/.bin/codeceptjs run --verbose
2019-03-10T11:07:43.152Z DEBUG @wdio/config: @wdio/sync not found, running tests asynchronous
CodeceptJS v2.0.7
Using test root "/home/mira/workspace/mycodeceptjs/tests/manual"
Helpers: WebDriver, My
Plugins: screenshotOnFail

Manual --
    [1] Starting recording promises
    Emitted | suite.before ([object Object])
  test something
    Emitted | test.before ([object Object])
    [1] Error | TypeError: Cannot read property '$$' of undefined
    Emitted | test.failed ([object Object])
  ✖ "before each" hook: codeceptjs.before for "test something" in 2ms
    [1] Error | TypeError: Cannot read property '$$' of undefined
TypeError: Cannot read property '$$' of undefined
    Emitted | test.after ([object Object])
    Emitted | suite.after ([object Object])

-- FAILURES:

  1) Manual
       "before each" hook: codeceptjs.before for "test something":
     Cannot read property '$$' of undefined
  ypeError: Cannot read property '$$' of undefined
      at WebDriver._before (/home/mira/workspace/mycodeceptjs/node_modules/codeceptjs/lib/helper/WebDriver.js:419:28)
      at recorder.add (/home/mira/workspace/mycodeceptjs/node_modules/codeceptjs/lib/listener/helpers.js:21:69)
      at process._tickCallback (internal/process/next_tick.js:68:7)

  FAIL  | 0 passed, 1 failed   // 8ms
    Emitted | global.result ([object Object])
    Emitted | global.after ([object Object])

Provide test source code if related

Feature("Manual");

Scenario("test something", (I) => {
    I.startBrowser();
    I.amOnPage("/");
    I.stopBrowser();
});

my_helper.js:
class My extends Helper {
    startBrowser() {
        this.helpers["WebDriver"]._startBrowser();
    }
    stopBrowser() {
        this.helpers["WebDriver"]._stopBrowser();
    }
}

module.exports = My;

Details

CodeceptJS version: 2.0.7
NodeJS Version: 10.15.1
Operating System: Ubuntu 18.10
WebDriverIO: 5.7.1
Configuration file:

exports.config = {
    tests: "./*_test.js",
    output: "./output",
    helpers: {
        WebDriver: {
            url: "https://codecept.io",
            browser: "chrome",
            manualStart: true
        },
        My: {
            require: "./my_helper.js",
        },
    },
    include: {
        I: "./steps_file.js"
    },
    bootstrap: null,
    mocha: {},
    name: "manual"
};

@mirao I suppose this is not occurring anymore with latest codeceptjs. Can you try and close this issue accordingly?

@PeterNgTr It's still an issue, just tested with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>When I downgrade webdriverio to ver. 4, it works well.

The issue persists in CodeceptJS 2.3.6, WebDriverIO 5.16.13

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Same issue!
TypeError: Cannot read property '$$' of undefined

Issue still present:
"webdriverio": "^6.1.12",
"codeceptjs": "^2.6.5",

TypeError: Cannot read property '$$' of undefined
It would be nice to expose that $$ property from WDIO for locators as it's quite smart and useful but for another time 💯

The same in v3.0.0-rc.0
This feature would be much appreciated

This issue is still present


Sporadic memory overflow failures

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.81.1
OS Version: Windows11 21H2

Steps to Reproduce:
I have a question, that is, when I use vscode for jupyter notebook programming, sometimes the memory overflow causes the program to crash, how can I troubleshoot the problem?
Here's how I do it:

Run a relatively small deep learning task.
Execute the "Data Processing Module".
Execute the network training code module.
At this time, my memory occupation should be very small under normal circumstances, but it will occasionally overflow and cause the vscode program to crash.

I would appreciate it if you could answer my questions

Sorry, it's not really possible to answer this without more specific detail. What are you specifically seeing? Can you check which process is using too much memory?
What is this:

Execute the "Data Processing Module".
Execute the network training code module.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Translator.exe weird behavior ??

Hi.
I´ve noticed a weird little thing.
I download the translator tool and unzip to a folder on my desktop:
C:\Users\Regmos5\Desktop\STG).
When I start the tool, it creates this folder:
C:\Users\Regmos5\Documents\Scripts\Autohotkey\ScreenToGif
It doesn't affect the program, but it just seems odd.
Shouldn't the location be in the STG folder ?
Kind regards
Regmos

Yes, what's happening is that the translator is using the startup folder instead of the base folder.
So, if the app was opened by the autohotkey, the translator is going to use that folder.
I'll fix this, so that the translator uses the correct base folder instead.


Bug in Find Helpers, when clicking 'assign' but with no selected helpers

In the modal for Find Helpers, if we do NOT select any helpers, but click the 'assign' button, it gets stuck.

LGTM - closing


Cop idea: force gem versions in Gemfile

Hi!
Many times I've seen problems when some gem, without noticing, gets updated to a newer version. I believe that versioning the gems in our Gemfile is a very good practice and we could have a Cop that enforces this.
I've created a prototype for this here.
Let me know what you think about it and if you think this deserves a PR or maybe create an extension gem.
Thanks!

I think it's cool. But it's also a good idea to not put a version if you're using a service like Deppbot to continuously update your dependencies. (Different strategies.) So should be configurable to support both. 🙂

In my opinion, this practice seems like an overkill to avoid reviewing changes to Gemfile.lock.
Check out https://robots.thoughtbot.com/a-healthy-bundle. The author gives an overview of dealing with versions in the Gemfile, including some cases when not specifying a version is appropriate.

I think it would be nice (if documented behaviour). Although I upped the suggestion, I am not completely sure if rubocop should also check Gemfiles versions per-se. Perhaps if it were an easy change and those who want to use it, would have to enable this behaviour specifically?


Support 'bungledid' Cookie

Possibly blocking issue #8.
Include the bungledid cookie in the http header for all api requests.

Cookies

In general, if you use an HTTP stack that correctly handles the Set-Cookie header in responses, you should be good to go. In particular, we ask that you support the bungled and bungledid cookies. These help us with specific diagnostics tasks, and will come in handy if you ever need us to help you troubleshoot an issue on Bungie.net.

Reference Link

Not blocking #8.


Update the OpenVPN configuration keyword list

I skimmed through the OpenVPN 2.4 reference (2.5 does not seem to exist at the time of writing), and updated the keyword list that I found. It Works For Me.

Thanks a lot for the PR. I will try to go through the changes on the weekend, so please have a little more patience!

Hi. Sure, take your time; I'm using the changes locally already.
Unfortunately, I didn't find a reference for OpenVPN 2.5. And in the meantime I found out that there also appears to be a deprecated keyword list (I wasn't focussed on that when I was looking for keywords in the 2.4 reference), so my work is probably incomplete in that regard.

The OpenVPN documentation is terrible. Would you have a link handy for the documentation you used?

Yes, I found it terrible as well. When I saw it, at first I shied away, but in the end took the time to go through the whole doc anyway. I used:
https://openvpn.net/community-resources/reference-manual-for-openvpn-2-4/
I'm sorry, AFAIK it's not getting any better than this. And I'm still not finding a 2.5 reference...

Well, things changed, and there are now reference manuals for 2.5 and 2.6:
https://openvpn.net/community-resources/reference-manual-for-openvpn-2-5/
https://openvpn.net/community-resources/reference-manual-for-openvpn-2-6/
However, I'm unsure if the reading experience will be better from before...

I've verified the keywords, but there's a merge conflict. Actually, I might add a build system to make this more maintainable.

Yes, well, I created the PR for v0.2.3, and you touched the keyword.language.openvpn regex in the openvpn.tmLanguage file when bumping to v0.3.0, so... ;-)
I'm a basic Git user, not a Git expert, and am unsure how to proceed. Do you need me to do anything?

Yes, well, I created the PR for v0.2.3, and you touched the keyword.language.openvpn regex in the openvpn.tmLanguage file when bumping to v0.3.0, so... ;-) I'm a basic Git user, not a Git expert, and am unsure how to proceed. Do you need me to do anything?

You have to resolve the conflicts yourself locally (it's the best practice when collaborating on OSS).
Your approach could look something like:
git remove add upstream git@github.com:idleberg/vscode-openvpn.git # Or HTTPS version if you use that instead
git fetch upstream
git checkout Update-OpenVPN-keywords
git rebase upstream/master
# Then you have to resolve the conflicts, contact me if you don't know where to start
git add syntaxes/openvpn.tmLanguage
git rebase --continue
git push --force # Or create new commit and push if you are not sure

Thanks. Did that.

Thanks guys, you are awesome!


RFC for Variable Arity Functions

Ongoing Discussion in Issue #1586.

To me, this is not something that belongs in a strongly typed systems language.

This is something I wouldn't rule out so quickly but it should be done with care. How this effects default arguments, and overloading need to be considered. I'm not sure this RFC without information about the surrounding issues can be accepted.
I really like MLs notion of tuples as the source of arguments to functions in the form foo(...). I'm not sure this is appropriate for Rust, but it's an idea, and syntactically consistent.

I'm not too fond of the idea because it supports the idea that there is multiple function bodies under one name, which I find confusing. Of course, specialization undermines this too, but I feel it's a slightly different thing: specialization applies for generic traits and functions (not stand-alone functions at the moment, but whatever), and requires there to be the most generic base case. I find that reassuring, because the base-case can be thought to set the precedent of how the semantics of the function should be, and the specializations should follow that, unless clearly and loudly indicated in documentation. But there is no such a precedent-setting base case with these.
Also, there is a lot of missing from the RFC. For example, if take a pointer to function, how do I select which N-ary version I mean? In this case it's clear: let f: fn(i32) -> i32 = varar_func; but in this case it isn't: let f = varar_func; Should type inference infer that too? That isn't discussed at all in the RFC.
Also, if there is going to be variadic generics in the future, there is then functions that are manually overloaded by arity as described here, and functions that are defined generically. That should at least be mentioned and given some thought.

Thanks for the feedback everyone, I appreciate it. I've update my PR with feedback regarding those areas.
Particularly:

Function Pointers
Variadic Functions
Default Arguments
Overloading
Multiple Function Bodies use case and Intention (Invariant #4, Identical Argument Types)

We discussed this in the @rust-lang/lang meeting. There were many concerns raised with this overall approach. The single biggest concern is that there was a general reluctance to complicate method dispatch more (for users, not necessarily the compiler) by adding another orthogonal kind of overloading. Moreover, while overloading on arity works fine for calls, it doesn't interact well with fully qualified paths to methods (aka UFCS) like T::method or <T as Trait>::method. We would presumably have to augment this syntax somehow (this may have been addressed in the commit pushed ~4 hours back, I haven't had a change to read that yet).
Finally, most people felt like default arguments was generally what was most desired in practice -- and while this can be modeled with overloading based on arity, it's more verbose than supporting default arguments -- and (as mentioned here) raises other complications to be considered. In general we felt like we'd rather see a proposal along those lines (defaulted arguments) than this more general arity-based overloading.

It would seem very strange to me for the language to introduce variable argument length, but not have general static overloading based on types. Definitely agree that the generally most desired feature is default values, which is fundamentally different.

Alright, Thanks for the consideration. I appreciate the feedback and learning more about why this isn't a desired feature. Shall I close this, or is there more to the RFC process/deliberation?

@zmoshansky

I appreciate the feedback and learning more about why this isn't a desired feature.

Thanks for your understanding! I'll go ahead and close the issue then.


affix taller than relative element

Does this lib supports case when sidebar is taller than  relative element?

What do you mean by being taller than the sidebar? The relative element in the demo is taller than the sidebar.
Could you give me a fiddle so I can see? I still didn't have the time to test it in a project so it probably might have some bugs.
Thanks!

I updated both title and content of this issue. It's the inverse of demo

Oh I see, indeed it is buggy when the sidebar is taller, I'll have a look at it tonight, thanks for the feedback :)

I'm not really sure what the default behavior should be in the case the Affix is taller than the relative element, so I simply don't apply the affix in that case and the sidebar stays static. I've tested with bootstrap's affix and it moves the affixed element up in a glitchy way when that happens, so I preferred to just ignore and don't apply the affix.
8e874e7fd8bd20a09e188922bba2aab032a02a4c Fixed

Think that's exactly the correct way to behave ;) Will you launch a new version to npm?

Already launched v0.1.5 :)


New Astral Clock app

This is ready to merge from my perspective.
A new astral moonphase clock app that can also display relative planet locations as well as other astronomy targets.

Great - thanks! And thanks for the really detailed README too

Great - thanks! And thanks for the really detailed README too


Preciso: updates docs for new fields

🏷 Type of documentation

[ ] new bid adapter
[x] update bid adapter
[ ] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[ ] Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
[ ] For new adapters check submitting your adapter docs

Is there are releated pull requested? Or have you documented features that you are not actually providing?

Hi @muuki88 , we have already created a PR (https://github.com/prebid/Prebid.js/pull/11161) with the latest changes we have made. Sorry for not mentioning the PR earlier.


Fix bug in ASB message renewal

Measure length after taking lock

Description
The length of the active messages was read before taking a lock on it. It was used to init the length a map that was then populated by reading the active messages after the lock was taken.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test


3Phase Current Power Usage

The problem
3Phase Current Power Usage - the power of three phases shows as one.
What version of Home Assistant?
2024.5.4
What version of OpenEVSE?
8.2.2
Diagnostics information
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response

Those are power calculations from OpenEVSE not the integration.


Name might not be a string

Fixes https://github.com/quantopian/pyfolio/issues/222

@twiecki this is a counterproposal to your downstream fix here: https://github.com/quantopian/qexec/pull/8520.

LGTM. Thanks. Now only have to update research.


If Celery already running, can't just use it.  Fails.

[INFO    ] Executing command '/home/vagrant/miniconda/envs/memex/bin/celery --detach --workdir="/vagrant/source" -A memex worker' as user 'vagrant' in directory '/vagrant/source'
[DEBUG   ] stderr: ERROR: Pidfile (celeryd.pid) already exists.
Seems we're already running? (pid: 8448)
[INFO    ] {'pid': 8970, 'retcode': 0, 'stderr': "ERROR: Pidfile (celeryd.pid) already exists.\nSeems we're already running? (pid: 8448)", 'stdout': ''}
[INFO    ] Completed state [/home/vagrant/miniconda/envs/memex/bin/celery --detach --workdir="/vagrant/source" -A memex worker] at time 19:02:07.775293

I'll take this one.

We got this one!


Use scipy.spatial.ConvexHull instead of pyhull

After spending a significant amount of time trying to get pyhull built on my Windows machine (with no success), I discovered scipy.spatial.ConvexHull, which I can easily import since I have scipy already built via Anaconda. It appears to have the same functionality.
It is up to you, but doing it this way works much better for me. I also cleaned up what looked like an error or two in terms of converting the Python arrays to julia ones. I also added a very basic test.
I will also take this opportunity to suggest that you submit this to METADATA.jl, since I think people would find it useful.

Hi Chris,
thanks for the contribution.  Perhaps you can squash the commits with a
git rebase --interactive origin/master

and pick the first commit and squash the following commits.  Then git push --force the result to your github repo---that should update the pull request.
Thanks,
---david

Is this better?
Thanks,
Chris

Yes, thanks.  I know rebasing is a bit of a pain, but it is the way things seem to happen here in the Julia community.


Updated Electron 11 to TinyCLR OS v1.0

Updated Electron 11 to TinyCLR OS v1.0

Looks like this was included in the other PR, so I'll go ahead and close this one out. Feel free to reopen if I missed something!


bserver_remote: use separate connections for gets and puts

Without this, if something is doing a bulk put, a small read could get
blocked behind the slow large block transfers.  With separate TCP
connections, the read finishes quickly.
Note that this will double the number of bserver connections, and
increase the amount of token signing done on the client.  It also
means that the bserver must not apply any per-device optimizations
that assume gets and puts from the same device reach the same bserver
(as far as I know, it makes no such assumptions today).
Issue: KBFS-1546

I think this looks good, but I'd like to do some testing to see where exactly the blocking is coming from, i.e. if it's at the RPC layer or the TCP layer. I'll try to do that today!

I'll open a low priority ticket for doing the same thing with MDServerRemote.  I think it's much less likely to happen since we only put one MD at a time per TLF.  We'd need a lot of concurrent operations on different TLFs to see a problem, I think.  Plus it's a little trickier given that the push updates that come back across the connection.

Linux Jenkins is down, and this PR passed before a rebase, so merging.


Support new emoji and fallback to Google Modern for Google Classic for new emoji.

Part of fixing #19371.
This PR:

Adds new emoji added since 2017, using their CLDR names and aliases.
Supports falling back to Google Modern for emoji not supported by Google Classic.
Updates the settings menu to note that Google Classic is no longer supported, linking to a new helpdesk blurb.

There's some remaining work before we can merge this, including:

Decide what names we want to use for the new emoji.
Decide if/how we want to switch users using Google Classic over to Google Modern (migration in the backend + messaging in the UI)

For the emoji_names.py part, would it be cleaner to import CLDR or similar as a dependency, and just have it fill in any value not present in emoji_names.py already?

It takes less space to just have this instead of all the CLDR package, though I agree that the way I manually did it is a bit jank. If we choose to move fully to CLDR there'll be a cleaner way to do this, so I'm sort of waiting to see how much we want to tweak names vs just use CLDR, and planning to clean this process up more after that. Does that sound ok to you?

(Chat thread is here, for cross-reference: https://chat.zulip.org/#narrow/stream/6-frontend/topic/update.20emoji.20.2319371/near/1391533 )

Can you adjust the commit messages for the first few commits to explain to what extent they contain any function/user-facing changes? I think my read is that at least the first two commits are intended to have no functional changes yet, but I'm not sure, and I'm a bit confused that the second commit adds the CLDR dependency, but only the 3rd commit discusses using CLDR data.
(My goal here is to be able to merge the first couple commits, since they seem like they might be lower risk than the cutover)

(I guess to be explicit, I think the strategy of extracting a custom_emoji_names.py file is a good one).

Also thanks for pointing out the CLDR package thing, it was indeed in the wrong commit!

#22475 #22476

No feedback from my end after playing with this a bit. :)

Thanks for all the work on this @evykassirer! I think we should be able to deploy this to chat.zulip.org soon, but I'm going to wait until we've resolved the above comments since I don't fully understand some of the code.

Thanks for the great comments Greg! Just made those changes.

A commit message nit: The commit title for the /help/ edit should something like help: Document Google blob deprecation. -- we use help: as the prefix for that (docs: is reserved for ReadTheDocs content, aka docs/ in the codebase). Though actually ... at the least the part of that commit that changes the labels would ideally be part of the previous commit, which actually changes those labels.
In any case, I'm test-deploying this on chat.zulip.org!

The chat.zulip.org deployment seems to be running happily without incident, so we should merge this soon.
One bug I've noticed is we're missing target="_blank`` (and the rel=` tags required for security) in the /help/ link about the deprecation; this means that clicking that links opens the /help/ article in the same window.
I believe our plans included a small migration to reset everyone using the Google blobs emoji to the modern Google emojiset; can you add a migration for that? We didn't want that on chat.zulip.org so we'd test both emoji set choices, but probably do for what we merge.

@alya @laurynmm I think it's reasonable for you to do a final review on the /help/ content for this change.

I think the help text looks fine.
Poking around the setting though, I have a couple of thoughts:

Can we drop the help center link on deprecated. Having actually experienced it, it feels confusing, and the information in the help center is roughly the same as what's explained in the ? tooltip on the same line.
I wonder if we should italicize deprecated? I think that would match better the formatting style we use for other settings.

Thanks!

We should also think about alternative ways to explain what's up with these emoji being deprecated.  I think this is the only place where the ? reveals a tooltip rather than linking to the help center, and it's not great to break that pattern.
We could have the ? link to the help center, but that does make the relevant text significantly harder to find.
We could also put the text directly into the settings page rather than hiding it in a tooltip, e.g. by displaying it only if "Google blobs" is the selected option.

I think this is the only place where the ? reveals a tooltip rather than linking to the help center, and it's not great to break that pattern.

I think we use the "fa fa-question-circle" when it's a tooltip (see @all note in notifications settings table) and "fa fa-question-circle-o" when it's a help center link.

We could have the ? link to the help center, but that does make the relevant text significantly harder to find.

If we link directly to the Change your emoji set section, then it wouldn't be too hard to find, which is what the current link in "deprecated" does.

My only other documentation note would be to maybe put the help center text in a warning note, but that might draw more attention to it than we want? See screenshot below.

Google blob note as warning screenshot

I think we use the "fa fa-question-circle" when it's a tooltip (see @all note in notifications settings table) and "fa fa-question-circle-o" when it's a help center link.

Oh, I forgot about that one! (We've been removing i icons, which previously offered tooltips in other parts of the menus, in favor of other approaches.)
I'm a bit confused -- the ? on all visually looks like "fa fa-question-circle"?

If it is somehow different, I'm not sure that would be intentional.

Anyway, what if we combine the ideas above and use the warning styling @laurynmm suggested for the help center, and have the question mark link to that help center section? That seems clear enough?

updates:

updated commit message to "help: Document Google blob deprecation"
moved link on "deprecated" to the icon and removed tooltip
added warning styling to helpcenter
added the new migration and tested it locally

(I reverted the migration locally and tried again and it didn't seem to work, so I'll look into it more later)

Okay I feel more confident now having written and run this test successfully:
class TempTestForEmojiMigration(MigrationsTestCase):
    migrate_from = "0415_delete_scimclient"
    migrate_to = "0416_set_default_emoji_style"

    @use_db_models
    def setUpBeforeMigration(self, apps: StateApps) -> None:
        iago = self.example_user("iago")
        iago.emojiset = "google-blob"
        iago.save()
        iago = self.example_user("iago")
        self.assertEqual(iago.emojiset, "google-blob")

    def test_emoji_updates(self) -> None:
        iago = self.example_user("iago")
        self.assertEqual(iago.emojiset, "google")

class TempTest2ForEmojiMigration(MigrationsTestCase):
    migrate_from = "0415_delete_scimclient"
    migrate_to = "0416_set_default_emoji_style"

    @use_db_models
    def setUpBeforeMigration(self, apps: StateApps) -> None:
        RealmUserDefault = apps.get_model("zerver", "RealmUserDefault")
        Realm = apps.get_model("zerver", "Realm")
        realm = Realm.objects.get(string_id="zulip")
        realm_user_default = RealmUserDefault.objects.get(realm=realm)
        realm_user_default.emojiset = "google-blob"
        realm_user_default.save()

        iago = self.example_user("iago")
        iago.emojiset = "google-blob"
        iago.save()
        iago = self.example_user("iago")
        self.assertEqual(iago.emojiset, "google-blob")

    def test_emoji_updates2(self) -> None:
        iago = self.example_user("iago")
        self.assertEqual(iago.emojiset, "google-blob")

I applied a few final changes, noted above, and marked this to merge once CI finishes. Thanks for making this happen @evykassirer!

What is the reason for "1f929" to have "star_struck" as its canonical name? The CLDR name is "grinning_face_with_star_eyes". Shouldn't "star_struck" be an alias instead?

@rht No, GRINNING FACE WITH STAR EYES is the Unicode character name, not the CLDR name. These are not the same thing.
https://github.com/unicode-org/cldr/blob/release-41/common/annotations/en.xml#L827

OK that clarifies it, thank you!

I was assuming that Slack (which has both "star-struck" and "grinning_face_with_star_eyes" for "1f929") takes it from CLDR. It turns out to be not the case.


A11y_SQLAzureDataStudio_ConnectToASQLServer_ConnectionDetails_ScreenReader: Status message not announced by screen reader for the loading screen after hitting enter on 'connect' button.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11yWCAG2.1;#A11yTCS;#SQLAzureDataStudio;#DesktopApp;#MacOs;#Benchmark;#A11y_SQLAzureDataStudioBenchmark;#A11ySev2;#MAS4.1.3;
Environment Details:
Application Name: Azure Data Studio
Version: 1.15.0-insider
Commit: 3a8b74a
Date: 2020-02-11T05:49:41.181Z
VS Code: 1.42.0
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
Mac OS:10.15.3
Additional Details:
Screen reader: Voice Over
MAS reference: MAS4.1.3
Repro Steps:
1.Launch Azure Data Studio.
2.Select the Connections icon (if not already selected) from left bar.
3.Hover over the 'Servers' header and select the 'New Connection' icon.
4.Navigate to connection details.
5.Launch Voice Over and navigate till connect button and press enter.
6.Check if proper status message is announced by screen reader.
Actual:
Status message about loading content is not announced when we press the connect button on connection details screen.
Same issue has been observed on following page:
1.Schema Compare->Menu Bar.(After selecting "compare" menu option from menu bar)
Expected:
Status message should be announced for the loading screen that is displayed after we hit connection button.
User Impact:
Screen reader users might not come to know what is the exact action being performed after they hit the 'connect' button.
Attachment link reference:
9410_A11y_SQLAzureDataStudio_ConnectToASQLServer_ConnectionDetails_ScreenReader.zip

issue: announce the connecting/connected status information when making a connection.

What's the expectation here for connections being made? For this dialog is it enough to just announce "Connecting" when the spinner starts? And then rely on the OE tree to announce connected/expanded? or should the dialog announce "Connected" right before closing?

GithubTags:#A11y_SQlADS_WCAG2.1;

https://user-images.githubusercontent.com/91586743/218711438-e168f1e3-a43a-48e6-8ee0-bf756cdc319f.mov
Verified the issue not it is not reproducing.
Git Hub Tags: #Closed;

GitHubTags:#BM-TCS-SQLADS-MAC-Feb2020;


Use IP address in the listeners

Change config generation to use three types of listeners:

inbound listeners, do not use CDS, RDS, SDS; bind to pod IP, port port pair.
outbound TCP listeners, use only SDS, bind to service IP, service port pair
outbound HTTP listeners, use CDS, RDS, SDS; bind to <IP_ADDRESS> and share ports

This PR touches a lot of cases, so please help reviewing this. This is needed to enable auth on inbound HTTP listeners.

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Can you link this PR to issue or proposal describing the design? It is hard to understand otherwise.

I can send a follow up documentation and cleanup when I'm back. An additional test that exercises combined HTTP routes on a port would also help.

Is there an urgency to get this code in before we can review it?

@andraxylia, yes, Auth is targeting on code complete by this week. And this is a PR that we are depending on.

I see Isaiah approved, so it must be good to go.
If this unblocks auth, it's wiser to get it in.

Jenkins job manager/presubmit passed

Do we have a tracking issue for the README doc mentioned in this thread?

That will make the code much more readable, thanks.

I will open tracking in istio/manager, so we have matching code and docs, although we may need to have it also in istio/istio.

The translation is changing every two weeks, so it's best to document in the code.

What is the translation? And why it changes every two weeks?
Btw, could you help to explain the second and third rules of that PR
https://github.com/istio/manager/pull/401? More specifically, why we only
use SDS for outbound TCP listener while use everything for HTTP listener?

inbound listeners, do not use CDS, RDS, SDS; bind to pod IP, port port
pair.
outbound TCP listeners, use only SDS, bind to service IP, service port
pair
outbound HTTP listeners, use CDS, RDS, SDS; bind to <IP_ADDRESS> and share
ports

On Thu, Mar 30, 2017 at 3:19 PM, Kuat<EMAIL_ADDRESS>wrote:

The translation is changing every two weeks, so it's best to document in
the code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/manager/pull/401#issuecomment-290561718, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AXQIZma316171vJ45GMiv38USvenm92oks5rrCp4gaJpZM4MpVvq
.

Translation is from istio config to envoy config. Changes happen because envoy keeps changing schema/adding features, and because manager gets new requirements (like auth).
Regarding TCP treatment, that's because there's no RDS for TCP proxy, and CDS doesn't function without RDS.

Envoy config churn should eventually slow down and be more predictable (see config: create config breaking change policy)

We will write proper documentation on the config generation once the churn is over. Otherwise, we'll be changing config gen before documentation is ready :)

I still need some documentation before the churn is over, otherwise I will not be able to review or see if things work as expected. Link to envoy configs are fine as well.


forcing earlier version of vcrpy in azure_devtools dependencies

The new version is breaking a lot of our tests.

Can one of the admins verify this patch?

Now let's just see the proper behavior out of the pipeline!

The 3 unreporting checks are a github app bug. Everything completed green.


[QUESTION] How to get plugins working when using laravel_mix

Environment
Complete the next environment information.

Item
Version

Laravel
8.76.2

Project
3.6

OS
Xubuntu 20.4

I am currently using the package with laravel mix to compile the assets,
everything work so far, I have always use custom code for almost everything but now I am trying to follow the package directive/implementation.
I got Toastr woring when directly including the cdn in the layout template extended from admin::page
but when I configure the plugin in conf/adminlte.php the assets are not being injected nor the cdn links
My guess is,it is proabably because I am using laravel_mix so how to I fix that please
After installing the plugin the assets were publish in /public/vendor/toastr folder
Setup
I created a separate js file for adminlte like so
ressources/assets/js/admin/app.js
content:
 require('.././bootstrap');
 require('hideshowpassword');
 // var Dropzone = require('dropzone');
 var password = require('password-strength-meter');
 require('overlayscrollbars');
 require('bootstrap');
 require('../../../../vendor/almasaeed2010/adminlte/dist/js/adminlte');

ressources/assets/sass/admin-css.scss
content:
```css
// Fonts
@import url('https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600,700,300italic,400italic,600italic');
@import<EMAIL_ADDRESS>// OverlayScrollbars
@import '~overlayscrollbars/css/OverlayScrollbars.css';
// iCheck
@import '~icheck-bootstrap/icheck-bootstrap.css';
// AdminLTE
@import '../../../vendor/almasaeed2010/adminlte/dist/css/adminlte.css';
// Bootstrap
// Already imported by AdminLTE
//@import '~bootstrap/scss/bootstrap';
```

Webpack.mix
```js
mix.js('resources/assets/js/app.js', 'public/js')
.vue({
    extractStyles: true,
    globalStyles: false
})
.sass('resources/assets/sass/app.scss', 'public/css')
.js('resources/assets/js/admin/app.js', 'public/js/admin')
.sass('resources/assets/sass/admin-css.scss', 'public/css')
.version();
```

plugin setting:
 ```php
   'toastr'    => [
           'active'    => true,
           'files'     => [
            [
                'type'  => 'css',
                'asset' => false,
                'location' => 'https://cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/toastr.min.css'
            ],
            [
                'type'  => 'js',
                'asset' => false,
                'location' => 'https://cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/js/toastr.min.js'
            ]
        ]
    ]
```

Hi @stoneC0der , if you look at the master.php file, then you can see plugins are not included from configuration file when enabling Laravel Mix, instead unique compiled files are included. I believe you should include plugins on the Mix configuration in these cases, but I'm not familiarized with Mix in order to help you. Check issue #490 for some more details.

Hi @Shidersz, thanks this how I solved it:
Extend the adminlte::page from layout/dashboard.blade.php in my case (or app.blade.php)
add this
@extends('adminlte::page')     @push('css')     {{-- Configured CSS --}}     @include('adminlte::plugins', ['type' => 'css'])     @endpush     @push('js')     {{-- Configured Scripts --}}     @include('adminlte::plugins', ['type' => 'js'])     @endpush
Then extend all your view from the dashboard or app template


fix: Add missing link href

[ x] I have read freeCodeCamp's contribution guidelines.
[ x] My pull request has a descriptive title (not a vague title like Update index.md)
[ x] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[ x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Can't submit the facility form for an LFO [8]

Describe the Bug:
When you click "Save and Continue," the button goes grey but you're never redirected to the next step: https://www.loom.com/share/dab33f8a692f470599df2bd106433e26. Operation 2 is our mock LFO.
SFOs seem to work fine.
Probability (how likely the bug is to happen, scored from 1-5): 5?
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")
Effect (how bad the bug is when it does happen, scored from 1-5): 3
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")
Steps to reproduce the behaviour:
Screenshots:
Additional information:

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Additional context

I looked into this because it was previously working and it's the small bugfix for the DataGrid empty rows that caused this to break. I'm not exactly why this one line fix caused it though from my work on the Facility DataGrid issue I know that the router.push in the form page change sometimes causes the DataGrid to refresh due to the query param change and stops the page transition.


Add __toString to Request

It would be nice if classes like Request had useful toStrings
http://www.php.net/manual/en/language.oop5.magic.php#language.oop5.magic.tostring

Duplicate of https://github.com/guzzle/psr7/pull/175

After reading through that other ticket, it looks like they have an entirely different goal. My goal was to get better debug information when something like Whoops prints out the value in the stack frame.

IMO __toString is not suitable here for debugging as it gives an opinioned result that people might expect something else to deliver like you can see with #175.
For debugging, I can recommend tools like https://symfony.com/doc/current/components/var_dumper.html that do a much better job than __toString can deliver.


POM-75 Transport views + some shared component fixes/additions

Fix the transport search list view, show destination in the result
Transport views & datepicker improvements/fixes

Apart from minor fixes like replacing some hard-coded texts in the transport
search view, this adds a new Datepicker component based on the Angular Material
one that wraps date handling to avoid the issue angular/components#7167. That
issue makes the Material Datepicker set dates one day earlier than the one
chosen by the user, at least in the Polish time zone. This change also uses that
new component in the transport views, both in find-help & give-help
variants.
Left to do is adding ngModel support to the Datepicker component instead of
binding to a custom prop name.

@bbartosiak PR updated, there are 2 new commits.


Code

I noticed that the code for DenoiseRep is not yet available in this repository. If possible, could you kindly provide access to the code or let me know if you plan to release it in the near future? I would greatly appreciate any guidance or resources you could share regarding the implementation.

The code has been released. I'm so sorry for the additional time to refine the code structure to enhance its readability.

Thank you so much for releasing the code! I completely understand the need for additional time to refine the structure and truly appreciate your effort in enhancing its readability. I look forward to exploring your work further and using it in my research.

maybe system delay of GitHub?


It's build in my project folder.


Wrong filters in 1.2.3

With vind 1.2.1 the following search
{"q":"*","filter":"((static_status='passive') OR (static_status='active')) AND ((static_partitionID='MV-1HP6U6PQS1W11') OR (static_partitionID='MV-1HP6TNXVH1W11') OR (static_partitionID='MV-1HP6UG2V51W11'))","timeZone":"null","sort":[{'direction':'Desc','field':'static_recordLastUpdateTimestamp'}],"result":{"sliceSize":21,"offset":0},"nestedDocSearchFlag":false,"nestedDocOp":"OR","nestedDocFactory":null,"nestedDocSearch":null,"facetFlag":false,"facetMinCount":1,"facetLimit":10,"facet":{},"geoDistance":null,"searchContext":"null","strictFlag":true}

resulted in those filters (only status and partitionID are relevant here)
&fq=((dynamic_multi_stored_filter_string_static_status:"active"+OR+dynamic_multi_stored_filter_string_static_status:"passive")+AND+(dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6UG2V51W11"+OR+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6TNXVH1W11"+OR+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6U6PQS1W11"))

which is the expected fq.
When using vind 1.2.3 the same code produces this search
{"q":"*","filter":"((static_status='active') OR (static_status='passive')) AND ((static_partitionID='MV-1HP6U6PQS1W11') OR (static_partitionID='MV-1HP6UG2V51W11') OR (static_partitionID='MV-1HP6TNXVH1W11'))","timeZone":"null","sort":[{'direction':'Desc','field':'static_recordLastUpdateTimestamp'}],"result":{"sliceSize":21,"offset":0},"nestedDocSearchFlag":false,"nestedDocOp":"OR","nestedDocFactory":null,"nestedDocSearch":[],"facetFlag":false,"facetMinCount":1,"facetLimit":10,"facet":{},"geoDistance":null,"searchContext":"null","strictFlag":true}

The filters in the search are the same as before (except the order). However, the generated fq for solr is broken since it now generates this:
&fq=dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6UG2V51W11"+OR+dynamic_multi_stored_filter_string_static_status:"passive"+OR+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6U6PQS1W11"+OR+dynamic_multi_stored_filter_string_static_status:"active"+OR+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6TNXVH1W11"

It seems to be an issue in the process of normalization of the filters. The expected normalized form should be:
(dynamic_multi_stored_filter_string_static_status:"active"+AND+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6UG2V51W11")+OR+(dynamic_multi_stored_filter_string_static_status:"active"+AND+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6TNXVH1W11")+OR+(dynamic_multi_stored_filter_string_static_status:"active"+AND+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6U6PQS1W11")+OR+(dynamic_multi_stored_filter_string_static_status:"passive"+AND+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6UG2V51W11")+OR+(dynamic_multi_stored_filter_string_static_status:"passive"+AND+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6TNXVH1W11")+OR+(dynamic_multi_stored_filter_string_static_status:"passive"+AND+dynamic_multi_stored_filter_string_static_partitionID:"MV-1HP6U6PQS1W11")


Runtime tests: Set default timeout if none is specified

It looks like there was the idea to do this years ago, but it wasn't implemented throughout the test framework so the parser still rejected tests without a TIMEOUT clause.
This is just to make it a little easier to write runtime tests. The vast majority shouldn't need to specify a timeout.

Nice! What do you think about auditing the tests and removing all the hardcoded timeouts if they are the same as the default?

Nice! What do you think about auditing the tests and removing all the hardcoded timeouts if they are the same as the default?

Good idea. That shouldn't take too long - I'll do it as a second commit in this PR


autoraise: fix darwin

Private frameworks need to be injected through a new hook. This requires configuration for the hook to be activated.

Things done
ZHF: #352882
Closes https://github.com/NixOS/nixpkgs/issues/355504

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355568

x86_64-linux

aarch64-linux

x86_64-darwin

:white_check_mark: 1 package built:

autoraise

aarch64-darwin

:white_check_mark: 1 package built:

autoraise


Spacing between action buttons on material dialog cancel | ok

How can give space between action buttons ok and cancel on material dialog

Sorry but you can't. The spacing is set to a static 8.

But the view is not look good Ok and | are overlap

This seems to be a bug. Can you provide what device you are using?

This seems to be a bug. Can you provide what device you are using?

I am using IPhone X, iOS 8+

Can you provide the code you used to show this dialog, including the custom configuration style.

I used the following code to show the dialog:
await MaterialDialog.Instance.SelectChoiceAsync("Select jobs", new string[]
{
    "Choice 1",
    "Choice 2",
    "Choice 3",
    "Choice 4",
    "Choice 5",
    "Chouce 6",
}, new XF.Material.Forms.UI.Dialogs.Configurations.MaterialConfirmationDialogConfiguration
{
    TintColor = Color.White,
    BackgroundColor = Material.Color.Primary,
    TextColor = Color.White.MultiplyAlpha(0.88),
    TitleTextColor = Color.White
});

And used an iPhone X simulator running iOS 12

Thanks for replying, The exact version of IPhone X is 11.2. and here is the code which I Used.
var confirmationDialogConfiguration = new MaterialConfirmationDialogConfiguration
{
CornerRadius = 8,
ButtonAllCaps = false,
};
var choices = dates.ToArray();
int wasConfirmed = await MaterialDialog.Instance.SelectChoiceAsync("Select Date",choices, confirmationDialogConfiguration);
        if (wasConfirmed >= 0)
        {
            //int index = view.SelectedIndex;
            //choices.GetValue(wasConfirmed)
            var value = choices.GetValue(wasConfirmed);
        }

Any update on this?

Hi. I can't replicate the issue. I even tried testing on a physical device, iPhone X running iOS 12.1.2.

which version of XF material are you used. can you please run this on Iphone X iOS 11.2.

Ok. Will try this on iOS 11.2.

Ok. Will try this on iOS 11.2.

Thanks for your help, really appreciable. it would be good if you will do this quick as i have to released the version of my app.

Hi @contrix09 did you get time to look in this point. we have tested in android device it's look fine but in iOS it seems overlap

Thanks for adding new params in SelectChoiceAsync Method. It's work now. I am using <IP_ADDRESS> version of this library.


non-root start docker daemon and run container

with the capability of binary and process, this pr get a way to start docker daemon and run a container with non-root
set the capability of binary
[root@localhost docker]# chmod +x contrib/gencap.sh
[root@localhost docker]# contrib/gencap.sh

start docker daemon, systemd need root user, so add --exec-opt native.cgroupdriver=cgroupfs
[hello@localhost ~]$ docker -d --exec-opt native.cgroupdriver=cgroupfs -D
...
DEBU[0000] /usr/sbin/iptables, [-t filter -C FORWARD -o docker0 -j DOCKER]
INFO[0000] Daemon has completed initialization
INFO[0000] Docker daemon                                 commit=d315e8d execdriver=native-0.2 graphdriver=devicemapper version=1.9.0-dev

run container
[hello@localhost ~]$ docker run --rm -ti ubuntu bash
groups: cannot find name for group ID 1000
I have no name!@12deb8235f1c:/$ ls
bin  boot  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
I have no name!@12deb8235f1c:/$ exit
exit
[hello@localhost ~]$ docker run --rm -ti -u root ubuntu bash
root@9c440be431df:/# pwd
/
root@9c440be431df:/#

we can compile docker with non-root
[root@localhost ~]# setcap all=ip /usr/bin/docker
...
[hello@localhost ~]$ docker -d --exec-opt native.cgroupdriver=cgroupfs -D

[hello@localhost docker]$ docker run --rm --privileged -t -i  -v `pwd`/vendor/src:/go/src -v `pwd`:/go/src/github.com/docker/docker -u root dockercore/docker ./hack/make.sh binary

bundles/1.9.0-dev already exists. Removing.

---> Making bundle: binary (in bundles/1.9.0-dev/binary)
Building: bundles/1.9.0-dev/binary/docker-1.9.0-dev
Created binary: bundles/1.9.0-dev/binary/docker-1.9.0-dev

Signed-off-by: keloyang<EMAIL_ADDRESS>

@keloyang I don't understand how container can be started without root and user namespace, what the trick?

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "nonroot" git@github.com:keloyang/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@LK4D4 http://man7.org/linux/man-pages/man7/capabilities.7.html can find some usefull info.
use non-root user, process capability of inheriytable is 0, this make all of the capability(permitted and effective) of its child process is 0,so we can see  much Permission.this pr can make the child process have the correct capability.

@LK4D4, Linux never mandate which user can do what, all it verified is what capabilities the process has(as well as other security rules), so the trick is giving the process enough capabilities to run docker daemon (all it needs and only all it needs), though most of the capabilities are not supposed to be owned by a normal process, such as sys_admin.
Quoted from security docs:

Eventually, it is expected that the Docker daemon will run restricted privileges, delegating operations well-audited sub-processes, each with its own (very limited) scope of Linux capabilities, virtual network setup, filesystem management, etc. That is, most likely, pieces of the Docker engine itself will run inside of containers.

That's what this PR does, but not let pieces of the Docker engine run inside of containers.
One of the biggest problem we use root to run docker daemon is that if daemon is attacked, user can hijeck docker daemon to do damage to the host, but now, it doesn't be much better, because daemon still has some privileged capabilities. We considered about drop these capabilities after daemon launched, but it won't work because all containers are created by daemon, and that still require some privileged capabilities, such as sys_admin for mount, we can't hack that because capability droping is a one way job, a process can only drop capabilities, can't add them.
Anyway it's still the best way we can figure out to narrow the attack interface for docker daemon.

MAINTAINERS
Please, avoid commenting in this pull request (an others why the label DCO/NO), and checking the code out until the DCO is properly signed.
Thank you

Anyway it's still the best way we can figure out to narrow the attack interface for docker daemon.

With this changes if someone can hijack docker, he can call setuid(0) in its context, can't he?
In addition, with this changes anyone can execute a docker daemon, execute a container, bind-mount the host /proc in it and get root access to the host system.
I don't think that these changes increase security of docker daemon.

I think the right solution for your task is unprivileged containers.
https://www.stgraber.org/2014/01/17/lxc-1-0-unprivileged-containers/

I don't think we should do this. I'm :-1: but I can change my mind if other maintainers make sure that we really really want to do it.

I agree with @avagin


Feat/multi mmr

Implements multi-mmr logic.
All tests are passing, except for full-flow, which is due to the input format having changed.
To make this pass, the following changes are needed in the input.json file:

like in the file checked in, update proofs["mmr_metas"] to be an array
each mmr_meta entry needs a chain_id
each header needs a mmr_idx param, indicating the index of the mmr_meta entry the ehader is contained in

fixtures updated https://github.com/HerodotusDev/hdp-test/tree/feat/run-script/fixtures

rebased with https://github.com/HerodotusDev/hdp-cairo/pull/53 branch, as this doesn't pass with latest cli

with the fixtures attached, it pass with `make run-ci-local`

porting CI fix change here https://github.com/HerodotusDev/hdp-cairo/pull/54/commits/5221d30fe10349c204079db5ab1a04a4813baf97


Is libmediasoupclient version 3.4.0 used in this code?

Hi,

Is libmediasoupclient version 3.4.0 used in this code?

download failed as below cmd for libmediasoupclient
https://github.com/versatica/libmediasoupclient/archive/55d724ff8b036991b0f0688adb334df976e458fe.tar.gz

Yes.
Check the network environment. That URL is working.

thanks.I'll look into it


Move Pageboy to correct category

Pageboy was incorrectly in the Activity Indicator section instead of general UI
Project URL
https://github.com/MerrickSapsford/Pageboy
Description
Move Pageboy to general UI
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

Hey @MerrickSapsford you can close this PR, and submit a new one to resolve the conflicts!
Btw thanks for correction.😊

Hi @naeemshaikh90, resolved and open in #1498 👍


Add support for arrays with holes as placeholders

This PR adds support for tagging empty positions in an array of children. This is best illustrated with the following snippet:

  {condition && <Foo />} // will be `null` if false

bar

The most obvious use case is conditional rendering like in the snippet above. With holes we can effectively skip a lot of work by matching indexes directly.
On top of that the PR includes the following changes:

Don't reuse unkeyed components anymore
Move focus handling to the top of the tree

this change was necessary to make the tests pass. The node that was focussed may be detached from the DOM making it impossible to focus again.

Fixes #1327 , Fixes #753 , Fixes #857 .
Adds +27 B +51 B +44 B +31 B

Coverage remained the same at 100.0% when pulling c8d156223f5b5b2cb3584ea750e1984eebfeac92 on holes2 into 750189b1978a032dfcd8e255325a32580d2c32b8 on master.

@marvinhagemeister Are you sure that this PR fixes (https://github.com/developit/preact/issues/1343)?, I tried you changes, But it still occurred!.

FYI, I have a review pending that I hope to finish today

@Almo7aya you're right it doesn't fix it. Removed it from the original post.

I found another way to modify toChildArray so that there are no breaking changes anymore. This makes the changeset a lot smaller. With the recent changes function components will be matched again. The match requirements are now:

Not a class component
Not a functional component with hooks

Or in a nutshell: Don't match anything stateful. This has a size cost though. The PR went up from +27 B to +51 B...

Waiting on #1515 to be merged first. That one will fix the remaining Fragment bugs and I don't want to get in the way. Stay tuned!

@andrewiggins I've completely reworked my reconciliation strategy. You were right all along that the previous changes were moving into the wrong direction :+1:  Would lvoe if you can take another look at this PR :tada:


Container crashes on cloud run

Container crashes on cloud run
To Reproduce

Use SvelteKit v1.0.0-next.94 and the current version of svelte-adapter-firebase.
Build the SvelteKit demo app with firebase adapter (for cloud run)
Deploy the demo app to cloud run with gcloud beta run deploy mysitessr --platform managed --region us-central1 --source .mysitessr --allow-unauthenticated
Goto /todos on the deployed app -> 500 error in the client and Cannot find package '@sveltejs/kit' imported from /workspace/app.mjs in the cloud run logs (detailed logs in the screenshot below)

This was also reproducible with other projects than the demo app. There the Cannot find package '@sveltejs/kit' imported from /workspace/app.mjs was returned back to the client.
Expected behavior
Container should work and not crash
Screenshots

Current SvelteKit version support is<EMAIL_ADDRESS>I am updating to<EMAIL_ADDRESS>atm.
Once the new version is released you can test again.


GPUs are not visible from the container

Which OS are you using?

OS: [Ubuntu 24.04.]
Env [Docker version 27.3.1, build ce12230 - ROOTFUL]

I thought this may be an issue from my two gpu rig running containers, but.. for some reason after wiping out docker and nvidia divers and cuda, I cannot get it working and I keep getting this error, it's something like my docker in not able tor each my GPUs
[+] Running 2/2
✔ Network whisper-webui_default  Created                                                        0.1s
✔ Container whisper-webui-app-1  Created                                                        0.1s
Attaching to app-1
app-1  | /Whisper-WebUI/venv/lib/python3.11/site-packages/torch/cuda/init.py:619: UserWarning: Can't initialize NVML
app-1  |   warnings.warn("Can't initialize NVML")
app-1  | Use "faster-whisper" implementation
app-1  | Device "auto" is detected
app-1  | Running on local URL:  http://<IP_ADDRESS>:7860
app-1  |
app-1  | To create a public link, set share=True in launch().
Any thought or idea on how can I make my GPUs visible?? (they are visible in the host - nvidia-smi validated.)

Similar with #294, it seems that "CUDA" ( the software that comes with the Nvidia GPU) is not installed or detected on your PC.
Can you do
nvcc --version

And see what it prints out?
It should print CUDA 12.4 version, as this project's recommended version.

Yep, correct, on my host it's working perfectly:
$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2024 NVIDIA Corporation
Built on Wed_Aug_14_10:10:22_PDT_2024
Cuda compilation tools, release 12.6, V12.6.68
Build cuda_12.6.r12.6/compiler.34714021_0
It works perfectly on the host:
$ nvidia-smi
Fri Sep 27 10:20:11 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 560.35.03              Driver Version: 560.35.03      CUDA Version: 12.6     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA GeForce RTX 3060        Off |   00000000:01:00.0 Off |                  N/A |
|  0%   38C    P8             12W /  170W |       4MiB /  12288MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   1  NVIDIA GeForce RTX 3070 Ti     Off |   00000000:03:00.0 Off |                  N/A |
|  0%   40C    P8             10W /  310W |    3228MiB /   8192MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|    1   N/A  N/A     28496      C   python3.10                                   3218MiB |
+-----------------------------------------------------------------------------------------+

It's workin on my host, but not from the container, I assuime it's my rig..


Add View Code command from a razor file

Fixes https://github.com/dotnet/aspnetcore/issues/33794
I know I need tests, I just hate mocks so I need to pluck up the courage overnight to create some.

Some questions, but mostly for my own education.

IMO exploratory / education questions are the best questions!

/azp run


Tidy up development settings

Changes based on Visual Studio Code settings.json file.
Exclude node_modules from watchman, cough 1.3 GB or 1.5 million files... discussion
Document OSX kernel file limitations and a fix since I personally got bit by this one... and I'm running OSX 10.13.5...

Pull Request Test Coverage Report for Build 1265

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.525%

Totals

Change from base Build 1263:
0.0%

Covered Lines:
2034

Relevant Lines:
3258

💛  - Coveralls