PST encodings don't decode plain text bodies well

Describe the bug
The libpff docs say to use PidTagInternetCodepage and then PidTagMessageCodepage to decode both HTML and plain text message bodies. This seems to work very well for HTML bodies, but often fails to decode plain text bodies in our test data. Like its successful only about half the time.
There are many cases where PidTagInternetCodepage and PidTagMessageCodepage both say "windows-1252" but the plain text body is really UTF-8.
Now that we handle encoding well, by default mailbagit tries the listed encodings, then raises a warning and tries chardetect if they are not fully successful. If that doesn't work, it decodes with the listed encoding and replaces any errors and raises a warning.
While this works okay since chardetect seems to decode the plain text bodies quite well, it spams lots of warnings even if it successfully decoded the message. So, to suppress this for now, PST plain text bodies considers chardetect a valid encoding for plain text bodies only.
Expected behavior
mailbagit should be able to decode plain text bodies without having to rely on trying to detect the encoding.
Environment (please complete the following information):
_ GUI or command line?: CLI

OS: [e.g. iOS] Win10
Python version: 3.9.12

Looking at this more, in all the examples we have, plain_text_body seems to always return a utf-8 encoded string. This seems to be in contrast to any documentation I can find, so I don't trust it. In practice, utf-8  seems to work 100% of the time while chardetect is confusing utf-8 with windows-1252 about 1 per 500 messages.
So I'm implementing it to check PidTagInternetCodepage and PidTagMessageCodepage still as first priorities if they are successful. If not, I manually added utf-8 as a third priority and chardetect as the last priority. The speed costs for checking all of these doesn't seem significant.

Addressed by #180.


[docs] Document some missing configuration parameters

The change is also adding some code for finding undocumented config constants in the setup/config.md file.

Will clean this up and merge it...


Not able to download the NLTK data module (python as well as manual download)

I am unable to download the NLTK data module files. I have attempted to download the data file using Python and have also tried manual downloading.
As mentioned in the documentation:
Python:
import nltk
nltk.download('punkt')
Manual download:
I am encountering issues with downloading from https://www.nltk.org/nltk_data/.

This issue was due to ISP blocking the site. It got fixed after changing internet connection.

Awesome, glad you got it resolved!


Display editor features in the README.

There is no description of any features on the Github page (README) or at https://google.github.io/xi-editor/.
Performance is mentioned, and granted that is a feature, but it might make sense to talk more about editor controls and other features instead of about its internal design. (That still has a place)

With all due respect to the project authors and maintainers, there are no features yet.
Despite how often it makes it to the frontpage of HN, it's still in progress and very early at that.
When it's further along, I expect the various frontends will document their features, perhaps with a link back to a centralized featurelist.  But the core editor piece is likely to be advertised to developers, not end users.

Yea, @Omar-Elrefaei pretty much nailed it; insofar as this is very much a work in progress, we're resistant to presenting it in such a way that would encourage people to actually use it as their editor. Basically: people are totally welcome to play around, but we don't want to present the idea that this is a text editor that you should consider for your day-to-day work (although I do use xi-mac quite a bit, though mostly just for markdown).

I see, that makes some sense. I guess this keeps making it to Hacker News so I assumed it was something people could start using.
Feel free to close the issue if it is not relevant for now.


iOS 9 Xcode 7.0GM issue

Hi Mustafa,
I am facing issue on this line, in code that you have shared:
labelString.drawInRect(textFrame, withAttributes: attributes as [NSObject: AnyObject])  // issue is here
Message: [NSObject: AnyObject] cannot be converted to expected type [String : AnyObject]?
Pankaj Bansal

Thanks for the opened issue. It's support Xcode 7 and swift 2.0.


3988 Omit inactive items from distributions#new dropdown

Description

This change resolves #3988 where inactive items were displayed when creating a new distribution.
An existing method was used to display the active items

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Created a system test to verify the changes.
Changes also verified manually

To reproduce

Sign in as org_admin
Go into Inventory | Inventory Items and delete Adult Large/XL
Go to Distributions
New Distribution
Fill in the storage location
Check list of items: Adult Large/XL will be omitted.

@rowenwillabus this looks good! Ideally we'd also have this work when editing a distribution and adding a new item to it (i.e. it shouldn't remove any existing inactive items, but you shouldn't be able to select new items for the same distribution that are inactive). @cielf does that sound right?
Were you able to verify for the other itemizables (donations, transfers, audits, purchases) that they don't currently show inactive items?

@dorner The gotcha regarding the edit was mentioned by @cielf: https://github.com/rubyforgood/human-essentials/issues/3988#issuecomment-1869000531 Initially, I shared the same train of thought (editing a distribution, to add a new item, shouldn't allow an inactive item). However, that'll punish users for making a mistake.
Scenario:

There is a distribution of two items Adult Briefs (Large/X-Large) and Bed Pads (Cloth)
Organization user creates a distribution and mistakenly adds 1 item

the error is realized two days later, both items are now inactive *

The Organization user will then be prevented from making the correction.
I'm happy to make the change, do let me know.

@dorner -- That does sound right.  Shouldn't be able to add inactive items.
We do need to consider the issue of what happens if someone reduces the amount distributed on an inactive item, whether it is on a line-item basis or a distribution reclaim.
One possibility is that we should display an error, and make the user make the item active to do the change (though only if they are changing the value or reclaiming).  It is going to be a uncommon case, I think.

And,  because it's a pretty uncommon case,  I don't really mind making the user work around the situation.

@cielf @dorner The issue stated "inactive" with an explanation on how to make an item inactive. Should we expand that to omit inactive (by status change) AND items with no inventory (zero count)?
If you try to distribute an item that has 0 in inventory, it displays Sorry, we weren't able to save the distribution. Validation failed: Inventory 1T Diapers is not available at this storage location. My thought is to remove such from the dropdown.
Do let me know. I'll wrap this up tomorrow.

What would the effect of that be on a case where we are creating a distribution from a request that has an item that has 0 in inventory?  Will they still initially see the item (that has 0)?

They wouldn't see that. They would only see items that can be added to the distribution. If they pick an item without any inventory and attempt to move forward, the validation blocks them. My proposal is to only show paths that can be travelled.
See screencast of what happens now:
Screencast from 12-31-2023 06:45:25 AM.webm

What would the effect of that be on a case where we are creating a distribution from a request that has an item that has 0 in inventory? Will they still initially see the item (that has 0)? - @cielf

No. They wouldn't. The item will not be displayed in the list. This is the same effect as a user requesting an item that then becomes inactive. However, I do see the utility in leaving it to be displayed as the user switches between storage locations. Whichever way, I believe it the new and edit experience should be similar, whether the distribution is from a request or not.
You have more context, happy to solve any way you suggest.

@rowenwillabus - it's a great idea, but I'd actually like to put a kibosh on any inspection of current inventory for these pages. Especially for the edit one - you don't want to know if there is inventory now, but if there was inventory at the time of distribution. We don't have a good way of doing this right now. We are in the process of reimplementing inventory entirely using event sourcing, so it will be handled on submit once that's done.

@dorner Thanks for mention that as I went down a rabbit hole and found some ways in which we can improve the process. E.g a request may have multiple distributions as all items requested may not come from a single storage location. Please loop me in on that work, happy to help.
I'll keep this PR focused on the inactive items affecting the new and edit methods. Thank you both for your time. Will submit changes shortly to close this.

"E.g a request may have multiple distributions as all items requested may not come from a single storage location"
In practice, that's not a thing I've seen happening.  And if it did happen, you would just create another distribution, not linked to the request,  for the second storage location.   It's a rare enough case that having  that  as a workaround is good.

@rowenwillabus Hi Rowen - what's the status on this PR?  Are you able to move forward with it?

Going to close this for now. Feel free to open a new one if relevant.


Errors parsing go.mod, invalid go version format

Describe the bug
The process yields the error complaining about the go version format.
go: errors parsing go.mod:
/src/go.mod:3: invalid go version '1.21.0': must match format 1.23

Version of dependency-check used
The problem occurs using version 8.4.0 of the docker image
Log file
Excerpt:
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Python Distribution Analyzer (0 seconds)
[WARN] While analyzing `/src/go.mod` `go` generated the following warnings:
go: errors parsing go.mod:
/src/go.mod:3: invalid go version '1.21.0': must match format 1.23

[WARN] An error occurred while analyzing '/src/go.mod' (Golang Mod Analyzer).
[INFO] Finished Golang Mod Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Created CPE Index (0 seconds)
[INFO] Finished NPM CPE Analyzer (1 seconds)
[INFO] Created CPE Index (0 seconds)
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[WARN] Unable to determine Package-URL identifiers for 1 dependencies
[INFO] Finished Sonatype OSS Index Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Known Exploited Vulnerability Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (0 seconds)
[INFO] Finished Unused Suppression Rule Analyzer (0 seconds)
[INFO] Analysis Complete (1 seconds)
[INFO] Writing report to: /report/dependency-check-report.xml
[INFO] Writing report to: /report/dependency-check-report.html
[INFO] Writing report to: /report/dependency-check-report.json
[INFO] Writing report to: /report/dependency-check-report.csv
[INFO] Writing report to: /report/dependency-check-report.sarif
[INFO] Writing report to: /report/dependency-check-jenkins.html
[INFO] Writing report to: /report/dependency-check-junit.xml
[ERROR] Error analyzing '/src/go.mod'; Error parsing output from `go list -json -m all`

To Reproduce
Steps to reproduce the behavior:

Install golang v1.21.0
mkdir example && cd example
go mod init foobar
Run the script of the docker page adding the --enableExperimental flag

Expected behavior
Scanning process should proceed with no error
Additional context
The obvious workaround is to edit the go.mod file and adjust the format.

The output that the Golang Mod Analyzer shows you in the error message is the output generated by go (go list -m -json -mod=readonly -all) and just handed to you in the output. You should ensure to start off with a proper formatted go.mod

The docker image embeds go 1.17.1 from the golang alpine image.
https://github.com/jeremylong/DependencyCheck/blob/main/Dockerfile

Ah okay ... Thank you. I did't see that.

Sounds strange to me by the way that your sequence of events leads to a quoted version as go documentation appear to suggest that it would be unquoted.
https://go.dev/doc/modules/gomod-ref#module-syntax

Try running go list -m -json -all without the readonly and see if that corrects the problem?

Hello,
I got the same issue, seems it's only broken if you use semantic versioning (X.Y.Z). If you use go 1.21 in you go.mod file, it'll work

Thanks @Tolrod22 , it worked for me :)

When you are using the semantic versioning - what happens when you run:
go list -json -m all

Hello,
I got the same issue, seems it's only broken if you use semantic versioning (X.Y.Z). If you use go 1.21 in you go.mod file, it'll work
Also reported here: #6052, but it's how go works, I guess

thanks, solved my problem

so how to update go version into docker image with openjdk?

This is happening to me on a brand new 'go mod init'. It is writing my go version correctly at 1.22.4 but I have to manually remove the '.4' to avoid the error.


Doesn't seem to work. :(

I followed all the steps mentioned in this doc. But building the project in Creators Update still gives me an error that says NavigationView is not supported in API version <IP_ADDRESS>. Am I missing anything?
Project built on Windows 10 version 1803.
MinTarget: 1703
MaxTarget: 1803

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09e77fe7-6970-8c3b-09f9-47986e2010c2
Version Independent ID: 25715011-c3c8-ce15-a1fc-db2bd62a58cf
Content: Getting started with the Windows UI library - UWP app developer
Content Source: winrt-related-src/toolkits/winui/getting-started.md
Product: windows
GitHub Login: @mijacobs
Microsoft Alias: mijacobs

@christoph-fer: I believe you either need to download the latest Windows Insider Preview (Build 1807) OR download the new Windows UI Library, which also contains the NavigationView (in a different namespace though, Microsoft.UI.Xaml.Controls.NavigationView). Here are the instructions: https://docs.microsoft.com/en-us/uwp/toolkits/winui/
I'll be updating the docs with this info.

@christoph-fer: Are you trying to use the platform version of the NavigationView (Windows.UI.Xaml.Controls.NavigationView) or the Windows UI Library version (Microsoft.UI.Xaml.Controls.NavigationView)?

@mijacobs: Hi. I tried using controls:NavigationView/ and that worked perfectly fine.

@christoph-fer: Great! We're in the process of updating the docs with examples that show how to use the Windows UI Library versions.

@mijacobs That's awesome! Looking forward to that. :)


Revealing all players choices

You need to reveal all players choices only after all players have selected an estimate. Can you elaborate a bit about this?

Also do i need to implement the entire game logic for the poker game?

@saurabh2209 great question!
The state of the game would be.

You have an active game with more that two two player. For our example assume we have exactly two players. Lets call them player "a" and player "b".
When player "a" submits an answer you can do nothing or notify player "a" that you are still waiting on other players.
When player "b" submits an answer since all platers in the current game have submitted,  you can now reveal all players selected answers to each other.

The exercise above it not overly complicated, but it is not trivial either, this is common concurrency problem and would like to see how you attack this problem.
Feel free to implement as much as you can and we can discuss what you had trouble with. I would say even if you don't get this feature right I would like to see an attempt.


⚠ gorzdrav.org has degraded performance

In e25ba37, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 1255 ms

Resolved: gorzdrav.org performance has improved in 357f0e0 after 9 minutes.


rouge-score==0.0.7

File "/root/.cache/huggingface/modules/datasets_modules/metrics/rouge/0ffdb60f436bdb8884d5e4d608d53dbe108e82dac4f494a66f80ef3f647c104f/rouge.py", line 21, in
from rouge_score import rouge_scorer, scoring
ImportError: cannot import name 'rouge_scorer' from 'rouge_score' (unknown location)
Version 0.0.4 works perfectly fine.

The same problem in our CI on Hugging Face Datasets: https://github.com/huggingface/datasets/runs/7463218591?check_suite_focus=true
The package seems not importable:
>   from rouge_score import rouge_scorer
E   ModuleNotFoundError: No module named 'rouge_score'

despite having been installed:
 Collecting rouge_score
  Downloading rouge_score-0.0.7.tar.gz (3.3 kB)

    Running setup.py install for rouge-score: started
    Running setup.py install for rouge-score: finished with status 'done'

Successfully installed: … rouge-score-0.0.7 …

Try 0.0.8

@peterjliu I'm still getting a ModuleNotFoundError: No module named 'rouge_score' with 0.0.8.
Here is a Colab replicating it: https://colab.research.google.com/drive/1b7IGGlsLBxD0ioVrAHFqrf-q3Vke9Enb?usp=sharing.

OK I've verified that 0.1.2 works in colab. Today I learned that colab uses python 3.7.


Mismatch between bias and bias weights

Hi there,
This may be a problem that's due to errors in my implementation, but I got some strange behavior regarding the bias and bias weights that I can't make sense of while fitting some of my rat 2-AFC data. For some context, the rats are previously trained on a visual task, but in these data are seeing blank screens so the stimulus is uninformative. As you'll see below, the stimulus variable weights are 0 precisely because this is the case. The object of using Psytrack is to see what stimulus-independent strategies they might be implementing in order to make their choices.
In short, my doubts are:
1 - I am not sure how to interpret a negative bias weight
-is it L/R?
-is it the presence/absence of bias (in which case a negative value is confusing, as well as a weight when there is no bias)?
-is it bias interacting with the other variables? (this would also be confusing, especially since the paper and documentation notes that bias weights are independent of other variable weights, and this seems to be the case when I run different models)
2 - I am unsure as to why the bias weights seem to have such large magnitude in some cases
-I saw in the paper that large weights can be a red flag, but it is unclear to me what the potential issue could be here
Here are some examples of the strange behavior:
Example 1
This animal appears to have a strong positive (rightwards) bias:

But, its bias weight is strongly negative:

From the paper, it seemed like the interpretation of +/- in the bias weights also corresponded to R/L, which makes this result confusing.
Example  2
This other animal appears to have a strong negative bias:

And here, its bias weights are also very strongly negative:

This would seem as expected, except that the magnitude on the bias weights is quite alarming.
Example 3
This animal has a strong negative bias:

And quite strangely, the shape of that bias trajectory seems to be tracked almost perfectly by a different variable:

Example 4
This animal has a slight negative bias that then switches to a positive bias:

The trajectory of its bias weights resembles its bias trajectory, but the weights remain negative:

Example 5
As a sanity check, I looked at bias and bias weights in the control sessions with visible stimuli beforehand, and there the results are not as strange, but still somewhat unexpected. For example, this animal seems to have a very slight bias, if any:

And its performance is reliably above chance:

And yet its bias weight is strongly negative and has the largest magnitude out of any variable, including the stimulus:

Example 6
This other animal during a control sessions viewing visible stimuli has the following bias:

Which actually seems to interact quite clearly with its performance:

And it appears to be tracked quite well by the bias weights (albeit with large error):
The fact that in this case the bias weights perhaps behave as expected makes me think like there may not necessarily be a problem in my implementation of the model.

Any help would be greatly appreciated! Thank you!
Javier

Hi again!
So I figured out the issue! The problem was appropriate categorical variable coding (i.e. L/R = 1 & 2 (or 0 & 1) for the variable 'y' whereas L/R = -1 & +1 for any 'input' variable). So for example, say you have ten trials with the following responses:
'y' = [ 1  2  2  1  1  2  2  2  1  2 ]
And you would like to check for perseverant behavior one trial back, meaning you displace the response vector by one. When you do this, now L/R must be coded as -1 & +1, not 1 & 2:
'previous_y' = [ 0 -1 +1 +1 -1 -1 +1 +1 +1 -1 ]
Apparently this can create very strange behavior in the fits, so for anyone reading this, make sure to double check this!
Love the package!
Javier

Thanks for the comments, @jmasis!  Glad you figured out the problem, and please let us know if you have any other issues!


[#2] Creation of the page listing the articles

Develop the page that displays the list of blog posts, sorted from newest to oldest, including for each post :

Title
Date of last modification
Chapô

Stress points : 5 points


Roll Engine from<PHONE_NUMBER>f1 to 828b5ce3224f (5 revisions)

https://github.com/flutter/engine/compare/1857470267f1...828b5ce3224f
2020-10-26<EMAIL_ADDRESS>Roll Skia from 189ecd485ade to 5bbbb49f1da0 (4 revisions) (flutter/engine#22121)
2020-10-26<EMAIL_ADDRESS>Remove some obsolete code from RuntimeController (flutter/engine#22091)
2020-10-26<EMAIL_ADDRESS>[ios] Convert FlutterPlatformViewsController to smart pointer (flutter/engine#22082)
2020-10-26<EMAIL_ADDRESS>Added the ability to set the initial route via launch urls. (flutter/engine#21336)
2020-10-26<EMAIL_ADDRESS>Roll Skia from c493eabd56d0 to 189ecd485ade (3 revisions) (flutter/engine#22119)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


File pretrained model on drive is not found

Dear rixez
Your drive path is no longer active. I'm unsure whether this is an issue on my end or with your drive. If you still have the pretrained model file, can you send for my gmail<EMAIL_ADDRESS>Thanks

Hi @TueNguyen2006,
Thank you for informing me about the link. I have reuploaded the models and updated the link.
Please try to download it again.
Thanks!

Hi @rixez
Thank you very much, do you still have the 'progress' and 'training_log' files? If so, could you please send them to me via my Gmail at<EMAIL_ADDRESS>I believe others might also need these files for research purposes (for me, I need to assess the model's performance across epochs and see how long each epoch takes). I appreciate it.


Nonwear detection window at end of data chunk incorrectly processed

In function detect_nonwear_clipping we have a step to allow for partial labelling of non-wear for the last window in a chunk:
https://github.com/wadpac/GGIR/blob/master/R/detect_nonwear_clipping.R#L39
I think this is incorrect and will lead to nonwear classifications less than the long window length (default 1 hour), which should never happen.
I have drafted a fix for this in branch https://github.com/wadpac/GGIR/tree/modify_nonwear_window
and will prepare a PR in the upcoming weeks, but maybe you already want to check it out @jhmigueles as I remember you worked on this function in 2023. With all the code migrations and function renaming it is not easy to retrace the origin of this line, so I think we just have to review it critically again.

As this is breaking unit tests I think it is better to postpone this work until a moment when we or someone else has time to more systematically review the non-wear detection code. Instead I have now made an effort to tidy up the syntax for function detect_nonwear_clipping.R to ease those future efforts.


Messaging permissions API

There's an outline of a permissions api already specified. It needs to be extended in the following ways:

internal/rules/operations.go

delete Permission{} if possible, it's invalid (we don't deal with "Scope", we have Rules{},
update API spec.json to use "[]rules.Rules" as well (keep TeamID as separate parameter)

So, the main point here is to have a unique data structure to read/save our permissions structure. A permission is defined for a [TeamID] over [ResourceID, Operation string, Access], so API calls for saving should use TeamID+[]Rules, while reading may only return "[]Rules".

internal/rules/interfaces.go

change parameter order for Grant, ListGrants (teamID should be first param)

Simple ordering fix, we're granting Teams permissions on Resource,...

extend API to retrieve Resources available

we return default scopes for organisation (from list, defined here)
we need an API call which will return available resources from scope name (list orgs, teams, channels), e.g. /permissions/scopes/{scope} - new API

So, the intent here is to have a Messaging navigation in the Administration panel where you would have 3 sub-menus for each scope - Org, Team, Channel; In the Team views and Organisation views the administrator must select a Team or Channel for which he wants to view / change permissions.

cosmetic: drop types from API names ("getTeam" => "get", see other spec.json examples for "name"...)

All of these are non-blocking and needed for the admin panel interface. Here's the trello link with more info and screenshots.

Points 1,2 and 4 are implemented.

Implemented & mostly obsolete.


Fix go hessian enum example

Fix go hessian enum example

should upgrade hessian2 ,ref https://github.com/apache/dubbo-go-hessian2/pull/332


🐞 Bug Button Functionality overwriting power.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

So whenever you are creating a circuit button should not by it's nature over write  the power supply but what happens is the 0 value of the button overwrites the power supply and causes errors.

After the button press:

So it does recognize that the power supply should light up the LED, but it only happpens when the button is clicked which should not be the optimum answer..
This may cause bugs in bigger circuit.

Steps To Reproduce

Go to simulator and make the same circuit as I showed in the image.
Try pressing the button and it should just show the bug by itself.

Expected Behavior

It should just light up the LED nonetheless the presence of the button, the button's 0 value is affecting this but it should not basically.

Screenshots
No response
Device Information [optional]
- OS: Arch Linux
- Browser: Firefox
- version:

Additional context
No response
Are you working on this issue?
Yes

Can I work on this?

cc @Prerna-0202 @Arnabdaz

Hey, @tanmoysrt can I work on this issue?


save clusters creds only when sharing the cluster

#1103  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BelSasha and the rest of your teammates on  Graphite


Quick clarification between dettach/attach and bind/unbind

I wast just hoping I could get some quick clarification and possible elaboration of the difference between detachFromWindow/attachToWindow and bindView/unbindView.  Specifically, the lifecycle order of the two as well as their overall functional difference of when they're called?  Thanks!

@ncapdevi basically the FastAdapter makes the methods normally called from the RecyclerView.Adapter accessible in the item.
I suggest you directly check out the lifecycle of the RecyclerView.Adapter

Ah, didn't realize this was a method directly from the adapter.  Fully explained here, sorry for the bother!
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#onViewDetachedFromWindow(VH)

bindViewHolder (bindView)
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#bindViewHolder(VH, int)
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#onBindViewHolder(VH, int, java.util.List<java.lang.Object>)

onViewRecycled (unbindView)
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#onViewRecycled(VH)

...


twitter crashed

Hi guys,
I got a trouble that when I used method login with  twitter: manager.authorize('twitter'), my app is crashed only on iOS. However, it works fine with both of facebook and google.
Beside that, when I set {scopes: 'email'} or {scopes: 'profile'} it returns ok but {scopes: 'email,profile'} return a error invalid_scope. How to get multiple scopes?
Please help me to solve this issue.
Thanks

Hm. I'm away from a keyboard this weekend, but can take a look when I get back. It's using the native twitter API. Do you have the crash logs?
If you use the latest version (master), you should see the URL it constructs (logging statement)

omg, I dont know what's happen but after run react-native log-ios, this issue went away and now everything work fine. Thanks

I'm having this issue with iOS also.

I found a solution for scopes that's changed coma to plus {scopes: 'email+profile'}

@naviocean Thanks, that doesn't seem to work for me, it does appear to be an issue with the scoping/credentials are showing null.

@naviocean @auser I'm getting a crash as well trying to connect to twitter. Crash logs:
2017-01-16 17:45:32.269 Swish[15811:1835348] *** -[_NSActivityAssertion _initWithActivityOptions:reason:expirationHandler:]: Warning: Could not create system idle sleep assertion (-536870199) 2017-01-16 17:45:32.471 Swish[15811:1829373] called clearPendingAccount: <DCTOAuth1Account: 0x60000033a2c0; type = twitter; identifier = 4CCA3FA3-60A6-4498-A533-48544080E17B; credential = (null)> 2017-01-16 17:45:32.471 Swish[15811:1829373] *** Assertion failure in -[DCTAuthURLOpener close:], /Users/arilitan/Swish/SwishMobile/ios/Pods/DCTAuth/DCTAuth/DCTAuthURLOpener.m:57 2017-01-16 17:45:32.478 Swish[15811:1829373] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Object should be the object returned from openURL:withCallbackURL:handler:'

Get the latest update. I pushed an update that fixes this problem.

@auser thanks for being on top of this. I downloaded the new version you published to npm, unfortunately I'm still getting the same crash

Oh you are on iOS... lemme finish debugging this Android problem

@auser yep indeed. thanks again

Alright, can you try with the latest push on master?

Thanks for your help on this issue @auser but It's crashing logs are showing this error now:
Jan 16 22:28:09 NBCMac-0256 Logoed[74777] <Warning>: called clearPendingAccount: <DCTOAuth1Account: 0x6080003258c0; type = twitter; identifier = D7BF579A-7BDF-47A2-A524-60C0CC2C4401; credential = (null)>
Jan 16 22:28:09 NBCMac-0256 Logoed[74777] <Warning>: *** Assertion failure in -[DCTAuthURLOpener close:], /Users/harryalford/Sites/workbook/raw/Logoed/ios/Pods/DCTAuth/DCTAuth/DCTAuthURLOpener.m:57
Jan 16 22:28:09 NBCMac-0256 Logoed[74777] <Error>: *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Object should be the object returned from openURL:withCallbackURL:handler:'
	*** First throw call stack:
	(
		0   CoreFoundation                      0x000000010ee11d4b __exceptionPreprocess + 171
		1   libobjc.A.dylib                     0x000000010d90321e objc_exception_throw + 48
		2   CoreFoundation                      0x000000010ee15e42 +[NSException raise:format:arguments:] + 98
		3   Foundation                          0x000000010d49866d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195
		4   DCTAuth                             0x000000010b893aea -[DCTAuthURLOpener close:] + 314
		5   DCTAuth                             0x000000010b884c0c +[DCTAuth cancelOpenURL:] + 92
		6   DCTAuth                             0x000000010b8999ed -[DCTOAuth1Account cancelAuthentication] + 77
		7   Logoed                              0x000000010b4a7c73 -[OAuthClient clearPendingAccount] + 115
		8   Logoed                              0x000000010b4a874d __59-[OAuth1Client authorizeWithUrl:url:cfg:onSuccess:onError:]_block_invoke + 109
		9   DCTAuth                             0x000000010b898853 __44-[DCTOAuth1Account authenticateWithHandler:]_block_invoke.66 + 1075
		10  DCTAuth                             0x000000010b899482 __44-[DCTOAuth1Account authenticateWithHandler:]_block_invoke.131 + 130
		11  DCTAuth                             0x000000010b890574 __44-[DCTAuthRequest performRequestWithHandler:]_block_invoke_2 + 116
		12  libdispatch.dylib                   0x0000000111a9f808 _dispatch_call_block_and_release + 12
		13  libdispatch.dylib                   0x0000000111ac112e _dispatch_client_callout + 8
		14  libdispatch.dylib                   0x0000000111aa84fb _dispatch_main_queue_callback_4CF + 1054
		15  CoreFoundation                      0x000000010edd5e49 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
		16  CoreFoundation                      0x000000010ed9b37d __CFRunLoopRun + 2205
		17  CoreFoundation                      0x000000010ed9a884 CFRunLoopRunSpecific + 420
		18  GraphicsServices                    0x0000000112b0fa6f GSEventRunModal + 161
		19  UIKit                               0x000000010bb7cc68 UIApplicationMain + 159
		20  Logoed                              0x000000010b49f2ef main + 111
		21  libdyld.dylib                       0x0000000111b0a68d start + 1
		22  ???                                 0x0000000000000001 0x0 + 1
	)

Can you share your code, by chance? I am having trouble trying to recreate the error here...

Hi @auser ,
After updated lastest version 2.1.13, the issue cant catched response.data is still occured.

// oauthmanager.js
import OAuthManager from 'react-native-oauth'
const config =  {
  twitter: {
    consumer_key: 'Cxxxxx',
    consumer_secret: '7xxxx'
  }
}

const manager = new OAuthManager('XXXX')
manager.configure(config)

export function authorize(success, failure) {
  console.log(manager)

  manager.authorize('twitter', {scopes: 'profile,email'})
    .then(success)
    .catch(failure)
}

And I call it by:
import * as oauth from 'oauthmanager'

oauth.authorize()

As soon as it calls manager.authorize() whole app crashes.

@madebysquares do you have any adb logs you could share?
You can get them using this command (substituting your app id, of course):
adb logcat | grep $(adb shell ps | grep -i com.firestackapp | cut -c10-15)

@auser looks like @madebysquares is also having the issue on iOS - same error I was seeing as well. below is my code if it helps:
const config =  {
  twitter: {
    consumer_key: 'Cxxx',
    consumer_secret: '8xxx'
  }
}

const manager = new OAuthManager('swish')
// configure the manager
manager.configure(config);

function connectTwitter(): ThunkAction {
  const thunk = (dispatch, getState) => {
    manager.authorize('twitter', {scopes: 'email'})
    .then(resp => console.log(resp))
    .catch(err => console.log(err));
  }
  return thunk
}

when I called the connectTwitter action the app crashes

Is this on iOS?

yes

Okay, so I was able to duplicate this issue and fix it.

Did you update your AppDelegate.m as the README.md shows?
Make sure you link libOauthManager.h
Did you add the URL types to your project?
Did you link the LinkingManager?

Feel free to reopen this issue if it still exists after all the steps on the README are setup in your app.

@auser yes I followed every step as described above, went back and double checked. still happening unfortunately

@madebysquares let us know if you have any luck

Did you rebuild your application after updating your app? Set a breakpoint in your AppDelegate.m on the handleOpenUrl method. Does that ever get triggered?

Happy to jump on ScreenHero to debug with you.

handleOpenUrl doesn't ever get triggered. the app is crashing on this line: https://github.com/fullstackreact/react-native-oauth/blob/master/ios/OAuthManager/OAuth1Client.m#L34
screenhero would be awesome i sent you an invite - not sure how to add ppl outside my slack org. I'm<EMAIL_ADDRESS>

for what its worth facebook login is working fine so i think the library is properly installed?

I stepped away for a few minutes. Will be back in about one hour.

Yes, I followed all the steps, I'm only working with iOS currently. Facebook works perfectly fine, (as @arilitan mentioned for him). I will pull the latest 2.1.14 and try again in a bit.

Hello guys... I'm having the same error as @madebysquares.
@auser thank you for this lib, that is really awesome!

Still getting this error:
<Error>: *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Object should be the object returned from openURL:withCallbackURL:handler:'

Thanks to @arilitan, we merged a patch that will give better error responses. Can you try pulling the latest version (2.1.15) and see what error response comes out in the iOS terminal?

Hello @auser, I've updated to 2.1.15, on IOS the warning promise is disappeared but nothing is returned.
manager.authorize('twitter')
      .then((response) => {
        console.log(response);
      })
      .catch((error) => {
        Alert.alert('Error', 'Can not login to Twitter');
      });

2017-01-18 19:25:15.004 okeeDeals[5644:104381] called clearPendingAccount: <DCTOAuth1Account: 0x600000132340; type = twitter; identifier = 91BFBFE4-D890-41D1-B34B-60CCF08A7857; credential = (null)>

Note: fb and google work fine on IOS

@auser
Jan 18 11:27:37 NBCMac-0256 Logoed[34652] <Warning>: Error in authorizeWithUrl: Error Domain=DCTAuth Code=0 "(null)" UserInfo={response=HTTP/1.1 0 Server Error

	<?xml version="1.0" encoding="UTF-8"?>
	<hash>
	  <error>Desktop applications only support the oauth_callback value 'oob'</error>
	  <request>/oauth/request_token</request>
	</hash>

	}

@madebysquares @naviocean we figured out you need to add a callback URL in your app settings. It doesn't matter what it is just has to be a valid URL.  I tested here and everything is working well. hahahaha I don't believe that!

Beside that, when I set {scopes: 'email'} or {scopes: 'profile'} it returns ok but {scopes: 'email,profile'} return a error invalid_scope. Ditto here, developing on Windows for Android and v 2.1.15. Another issue is, the rnpm prelink and postlink commands are .sh files, hence throw an error when linking on Windows.

@PranayShah try to set {scopes:'email+profile'}
@arilitan I've set callback url in app setting but my issue is still occured.

Tried it, no luck. The error is {invalid=[profile+email]}

I'm having the same error like @PranayShah but, on google.

Regarding the scopes, they should be comma (,) separated.
Does it work @adrianotadao with just a single scope?

It does work with a single scope, but with multiple scopes doesn't work
with the comma, space or plus separators for Google login on android.
On 21 Jan 2017 04:10, "Ari"<EMAIL_ADDRESS>wrote:

Regarding the scopes, they should be comma (,) separated.
Does it work @adrianotadao https://github.com/adrianotadao with just a
single scope?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fullstackreact/react-native-oauth/issues/42#issuecomment-274199374,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB64WyLkXS8myHdPvOy6gmfFIaCVZ9k2ks5rUTf4gaJpZM4Lj4UG
.

@auser yes, with a single scope it works very well.

For the benefit of anyone looking at this thread as of June 2018, they may find this page in the twitter docs is enlightening.
You will need to add a valid callback URL in twitter settings. Should be {your_app_name}://
check the log for
calling authorizeWithUrl
and make sure the callbackURL sent there matches your settings, but just the protocol (eg sent 'callback_url' will be 'exampleapp://oauth-response/twitter' so twitter settings callback url needs to be 'exampleapp://' )
The docs should probably be updated to reflect what appears to be a very recent change.


you broke reverse scrolling...

OS
macOS 13.3.1 (a) (Build 22E772610a)
LinearMouse
v0.9.0
Describe the bug
reverse scrolling no longer works, congrats
To reproduce
No response
Expected behavior
No response
Anything else?
No response

I am not experiencing any issues with it on my side. Could you please provide the logs?


[macos] alignment center do not work in profile/release mode

versions
flutter:  latest stable. (2.2.1) , latest master.
platform: macos
bitsdojo_window: 0.1.0+1
reproduce

cd bitsdojo_window/example

flutter run -d macos --profile

Expected window show in center of screen, but it did not. In additions, debug mode seems work good.

https://github.com/bitsdojo/bitsdojo_window/blob/f2d8dfabec25722526c8996929086902df5e8fbb/bitsdojo_window/example/lib/main.dart#L13-L22
Use size  final initialSize = Size(1280, 750);  It is more obvious that the window is not centered.
And after removing this line of code  win.alignment = Alignment.center; then the window can be centered correctly when it starts.

Any news? Seems that aligning on windows doesn't work properly as well sometimes.

You can try win.position to set the window at the custom position.
If you want to set the window in the center don't set the win.alignment value for the macOS platform.


Attempt to fix Korean lunar calendar bug.

This PR addresses a bug in exchange_calendars/pandas_extensions/korean_holiday.py. You can see the bug by adding the following test case to tests/test_xkrx_calendar.py:
def test_feb_29_2022_in_lunar_calendar(self, default_calendar):
    default_calendar.regular_holidays.holidays(date(2022, 3, 31), date(2022, 3, 31))

The underlying cause is that korean_holiday.py is trying to store lunar dates inside Gregorian date objects. 2022-03-31 (Gregorian) corresponds to 2022-02-29 (Korean Lunar), at least according to https://astro.kasi.re.kr/life/pageView/8 (with Google Translate). 2022-02-29 is not a valid Gregorian date, and so the operation fails. This PR widens the date range used in _reference_dates if necessary, and then filters out any extra holidays at the end.
As an aside, I've raised my concern about the Korean holiday generation code before, and I think that this bug highlights the inherent complexity that the code brings. I think that moving towards a hardcoded set of holidays is probably the right thing to do.

@gerrymanoim Please let me know if you have any concerns about this patch. Happy to go through it / improve it if anything's unclear. I do intend to produce a PR with a simpler XKRX calendar implementation at some point, but it's unlikely to be done terribly soon, and this fix would resolve the most pressing current XKRX issue.

Hey - @philiptromans - apologies for the delay - this LGTM.
As stated in the issue, I'm perfectly happy to go revert the Korean holiday if it is a maintenance burden. Thanks for the contributions!


How to get the channel that invoked a modal from modal submission handler @app.view("")

Hi, I am trying to say() (send message) to a channel on modal submission (@app.view('')) without using hard-coded channel id.
So far, I can only access to the user with body["user"]["id"]
Is there a proper way to grab the channel id that invoked modal to open ? (@app.action)

Not related to above problem, but what is a right way to use both @app.event('message') and  @app.message("word")?
The slack_bolt version
slack-bolt==1.11.1
Python runtime version
Python 3.9.7
OS info
ProductName:	macOS
ProductVersion:	12.0.1
BuildVersion:	21A559
Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:24 PDT 2021; root:xnu-8019.41.5~1/RELEASE_ARM64_T8101

Hi @imageschool

Is there a proper way to grab the channel id that invoked modal to open ? (@app.action)

There are two options. The first one is to use private_metadata in your modal view. Refer to our responses below:

https://github.com/slackapi/bolt-python/issues/550#issuecomment-998430750
https://github.com/slackapi/bolt-python/issues/486#issuecomment-935920573
https://github.com/slackapi/bolt-python/issues/392#issuecomment-874371844

The second is to use response_url_enabled and default_to_current_conversation in conversations_select block element in a modal. The channel ID can be absent if you use global shortcuts for opening the modal (global shortcuts are available everywhere, not only in the channel view). If you make the block input required, you can know where the end-user would like to receive a message in a channel.
Refer to the document for details: https://api.slack.com/reference/block-kit/block-elements#conversation_multi_select

Not related to above problem, but what is a right way to use both @app.event('message') and @app.message("word")?

It's fine but if you place @app.event('message') before @app.message("word") in your source code, @app.event('message') catches all the messages. If you prioritize @app.message("word") (I'm sure this is what you want to do), you can place it before @app.event('message') listener:
app = App()

@app.message("word")
def handle_specific_words():
    pass

@app.event('message')
def handle_the_rest_of_message_events():
    pass

I hope this helps.

Hi @seratch
Thank you for your quick response!
I absolutely had no idea that placing orders could matter for both @app.message() & @app.event('message')
I have now resolved both of the issues following your guide!
Thank you once again!


Proposal for changing how we search for attributes

Currently, FastCS walks all attributes in the dir of controller to find Attributes, which can be a problem for two reasons.

If the name of an Attribute is dynamic then during initialise() the controller will have to

dynamic_name, dynamic_type = ...
setattr(dynamic_name, however_it_generates_attributes(dynamic_type))

There are some places in pandablocks where we want a controller which also has a subcontroller, but also a top level attribute provided by the subcontroller:

    class Controller2(SubController):
        def __init__(self):
            self.sub_attribute = AttR(Int())
            self.attribute_for_base_controller = AttR(Float())

    class Controller1(Controller):
        async def initialise(self):
            block = Controller2()
            self.block = block.attribute_for_base_controller
            self.register_sub_controller("block", block)

We want the following to the complete list of records generated in the above:
PREFIX:BLOCK - a float
PREFIX:BLOCK:PVI
PREFIX:BLOCK:SUB_ATTRIBUTE - an int

instead we'd have to wrap attribute_for_base_controller in some structure so that it isn't seen as an Attribute when the controller is walked.
Suggestion
There should be three ways to define attributes on a controller:
class SomeController(Controller):
    some_attr_annotation: AttrR[int] # 1
    class_attr = AttrR(Float()) # 2

    def __init__(self):
        self.some_attr_annotation = AttrR(Int())

    def get_attributes(self) -> dict[str, Attribute]:
        return {"some_attr": AttrR(String())} # 3

Walk mappings will now:
1/2
Look for attributes in type(controller).__annotations__. This will include annotations #1 and #2. In both cases we get the attribute from getattr(controller, annotation_name).
In the case of #1 we raise an error if the annotated attribute doesn't show up in controller by the time we walk mappings (post initialise).
In the case of #2 we're already handling mutability so that SomeController.class_attr won't be changed when controller.class_attr changes it's state.
Principally, we're checking for the Attributes in type(controller), and not controller. This lets a controller make Attributes which it can put in other controllers (e.g defined in __init__).
3
We allow the user to provide whatever additional attributes via a method, defined to return {} in the BaseController.

@GDYendell @jsouter

I think this seems reasonable. I am still a little unclear what the use cases (current and future) for passing attributes up to the parent controller might be.
For panda, is there only ever a single Attribute in the parent for a given child controller, or could there be multiple? What is the value of the attribute, what does it represent?

In panda we have quite a lot of places in fields where we do this:
        structure out
            string r PANDA1:COUNTER1:OUT
        structure out_capture
            string rw PANDA1:COUNTER1:OUT:CAPTURE
        structure out_dataset
            string rw PANDA1:COUNTER1:OUT:DATASET
        structure out_mode
            string rw PANDA1:COUNTER1:OUT_MODE
        structure out_offset
            string rw PANDA1:COUNTER1:OUT:OFFSET
        structure out_scale
            string rw PANDA1:COUNTER1:OUT:SCALE
        structure out_units
            string rw PANDA1:COUNTER1:OUT:UNITS

...
        structure trig
            string rw PANDA1:COUNTER1:TRIG
        structure trig_delay
            string rw PANDA1:COUNTER1:TRIG:DELAY
        structure trig_edge
...
        structure dir
            string rw PANDA1:COUNTER1:DIR
        structure dir_delay
            string rw PANDA1:COUNTER1:DIR:DELAY

For panda, is there only ever a single Attribute in the parent for a given child controller, or could there be multiple?

The subcontroller will only ever pass one attribute element back to the controller to act as the root_element.
If we wanted to more formally support this we could also add a property
SubController::root_attribute() -> Attribute | None

which would be used in the parent controller _get_single_mapping to create a PREFIX:BLOCK attribute for a controller PREFIX:BLOCK:PVI.

If it is just one then a property would be a clearer API. Saying that, if there were more than one it could be a root_attributes property that returns a list.
I do still think we should make some of these changes to the way we search for attributes, though.


docs(repo): add docs for expected structure

add documenation around the expected structure for the file input
structure with link to example
closes GH-8

:tada: This PR is included in version 1.0.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


New Property: LabelFont

Expose the LabelFont as a property so that it can be changed as necessary. For example, when generating larger than normal barcodes we'll want to also have a larger than normal font to match.

Actually, it looks like most if not all of the properties could be exposed as properties. This would greatly reduce the number of constructors needed. (Though I wouldn't actually remove any of them to avoid breaking changes.)


server: add --shard-external-url

Summary
kcp deployers optionally need to be able to set the URL external clients
use when connecting to kcp (e.g., via a front proxy). Add a new
--shard-external-url flag that is used as the default value for
ClusterWorkspaceShard.Spec.ExternalURL.
Related issue(s)
Fixes #

/cc @sttts @csams
/assign @sttts @csams

/retest


Repo.insert/2 Struct converted to Changeset

Environment
Current Version
Elixir 1.4.1
Erlang/OTP 19

defp deps do
  [
    {:phoenix, "~> 1.3.0"},
    {:phoenix_pubsub, "~> 1.0"},
    {:phoenix_ecto, "~> 3.2"},
    {:postgrex, ">= 0.0.0"},
    {:phoenix_html, "~> 2.10"},
    {:phoenix_live_reload, "~> 1.0", only: :dev},
    {:gettext, "~> 0.11"},
    {:cowboy, "~> 1.0"},
    {:comeonin, "~> 4.0"},
    {:bcrypt_elixir, "~> 0.12"},
    {:guardian, "~> 0.14"}
  ]
end

Current behavior
Ecto.Repo.insert/2 states

...In case a struct is given, the struct is converted into a changeset with all non-nil fields as part of the changeset...

When I fire up the console in my Phoenix 1.3 app my changeset fails (which is correct because of validation) but my struct passes and is inserted in the DB.
# With changeset it return :error
iex(15)> Repo.insert User.changeset(%User{}, %{email<EMAIL_ADDRESS>{:error,
 #Ecto.Changeset<action: :insert, changes: %{email<EMAIL_ADDRESS>  errors: [name: {"can't be blank", [validation: :required]},
   password: {"can't be blank", [validation: :required]}],
  data: #Try.Accounts.User<>, valid?: false>}

# Struct it passes :ok
iex(16)> Repo.insert %User{email<EMAIL_ADDRESS>[debug] QUERY OK db=2.7ms
INSERT INTO "users" ("email","inserted_at","updated_at") VALUES ($1,$2,$3) RETURNING "id"<EMAIL_ADDRESS>{{2017, 8, 31}, {0, 56, 23, 5376}}, {{2017, 8, 31}, {0, 56, 23, 5389}}]
{:ok,
 %Try.Accounts.User{__meta__: #Ecto.Schema.Metadata<:loaded, "users">,
  email<EMAIL_ADDRESS>id: 151, inserted_at: ~N[2017-08-31 00:56:23.005376],
  name: nil, password: nil, password_hash: nil,
  updated_at: ~N[2017-08-31 00:56:23.005389]}}

Here is the User Schema I'm using...
defmodule Try.Accounts.User do
  use Ecto.Schema
  import Ecto.Changeset
  alias Try.Accounts.User

  schema "users" do
    field :email, :string
    field :name, :string
    field :password_hash, :string
    field :password, :string, virtual: :string
    timestamps()
  end

  @doc false
  def changeset(%User{} = user, attrs) do
    user
    |> cast(attrs, [:name, :email, :password])
    |> validate_required([:name, :email, :password])
    |> unique_constraint(:email)
    |> hash_password()
  end

  defp hash_password(changeset) do
    case changeset do
      %Ecto.Changeset{valid?: true, changes: %{password: password}} ->
        changeset
        |> put_change(:password_hash, Comeonin.Bcrypt.hashpwsalt(password))
        |> delete_change(:password) # remove the virtual password
        #put_change(changeset, :password_hash, Comeonin.Bcrypt.hashpwsalt(password))
      _ ->
        changeset
    end
  end

end

Expected behavior
I expected the struct to fail if the documentation is saying that the struct will be converted into a changeset.
In other documentation:
What's new in Ecto 2.1 PDF that Plataformatec provides as a download. It also has under a section called Less Changesets pg 38 and it states:

"..Ecto 2.0 goes away with all of those limitations. You can now also pass structs to the repository and Ecto will take care of building the changesets for you behind the scenes..."

I did get some feedback on Slack in the Ecto Channel that its probably an error in documentation and the idea that a struct will be converted into a changeset automatically is unlikely because you may have multiple changesets for that schema and how would it know.
What am I doing wrong?

The struct is converted to a Changeset using Ecto.Changeset.change/2, not
your own function, since that would be hard to do for the reasons
mentioned. Can you please send a PR that makes the docs clearer? Thank you.
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

I think I understand the documentation now based on your feedback.
iex(18)> Ecto.Changeset.change %User{email<EMAIL_ADDRESS>#Ecto.Changeset<action: nil, changes: %{}, errors: [],
data: #Try.Accounts.User<>, valid?: true>

Example 1
Ecto.Changeset.change/2 returns just an Ecto.Changeset with the data: containing the struct.
iex(19)> User.changeset(%User{}, %{email<EMAIL_ADDRESS>
#Ecto.Changeset<action: nil, changes: %{email<EMAIL_ADDRESS>errors: [name: {"can't be blank", [validation: :required]},
password: {"can't be blank", [validation: :required]}],
data: #Try.Accounts.User<>, valid?: false>

Example 2
This returns an Ecto.Changeset but this was built up and returned by my User.changeset/2 function so it has gone through validation etc.
When I read this part of the documentation

Inserts a struct defined via Ecto.Schema or a changeset.

I thought since my User schema has a changeset defined User.changeset/2 when it's passed into Repo.insert/2 it would insert a struct defined by User.changeset/2.

Yes, precisely.


feat: apply libs

Please check if the PR fulfills these requirements

[x] It's the right issue type on the title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] It does not introduce a breaking change or has a description of the breaking change

Description
Change package name of libs

libs
before
after

Squire
squire-rte
@toast-ui/squire

to-mark
to-mark
@toast-ui/to-mark

PR 1

Change editor's dependencies to libs : https://github.com/nhn/tui.editor/pull/741/commits/21fc18b113f7316d8eb7c43a819371480a6fec6d

PR 2

Update packages of libs : https://github.com/nhn/tui.editor/pull/741/commits/bcdfd8bf4293a31048d8269547aeaf5f0aac47cb

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

수고하셨어요~


add default project domain in execute launch plan

TL;DR
add default project domain in execute launch plan
Type

[X] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
When I executed a launch plan with FlyteRemote, it didn't run with default project domain of the remote but needed specified project domain. So, I fixed it with if there is no specified project domain, use default project domain of the remote.
Tracking Issue
NA
Follow-up issue
NA

should we just add this to the top level def execute instead?

Hi @wild-endeavor, do you mean we can resolve the identifiers before actually classify different types of entities?
For example, move the resolved_identifiers = self._resolve_identifier_kwargs(entity, project, domain, name, version)
to https://github.com/flyteorg/flytekit/blob/74d63d7265383c2af07952e835bcebf95b2d0942/flytekit/remote/remote.py#L1158


[R] mx.model.FeedForward.create in mxnet/example/kaggle-ndsb2/Train.R produced different results from python

Train.py code worked so well, but mx.model.FeedForward.create in Train.R code does not work. What is the cause?
> # Training the stytole net
> mx.set.seed(0)
> stytole_model <- mx.model.FeedForward.create(
+   X = data_train,
+   ctx = mx.gpu(0),
+   symbol = network,
+   num.round = 65,
+   learning.rate = 0.001,
+   wd = 0.00001,
+   momentum = 0.9,
+   eval.metric = mx.metric.CRPS
+ )
Start training with 1 devices
[1] Train-CRPS=0.248537092806794
[2] Train-CRPS=0.249575979181468
[3] Train-CRPS=0.249281826982739
[4] Train-CRPS=0.248988226596111
[5] Train-CRPS=0.248694746602638
[6] Train-CRPS=0.248402110901456
[7] Train-CRPS=0.248110486441219
[8] Train-CRPS=0.247818248773282
[9] Train-CRPS=0.247526859680184
[10] Train-CRPS=0.247235201653695
(Omitted)
[55] Train-CRPS=0.234554654820709
[56] Train-CRPS=0.234282698395829
[57] Train-CRPS=0.234008295194647
[58] Train-CRPS=0.233738730834488
[59] Train-CRPS=0.233467098573434
[60] Train-CRPS=0.233195344441995
[61] Train-CRPS=0.232924924355617
[62] Train-CRPS=0.232653180647331
[63] Train-CRPS=0.2323852445735
[64] Train-CRPS=0.23211576977677
[65] Train-CRPS=0.231845338545091

> sessionInfo()
R version 3.2.2 (2015-08-14)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 14.04.2 LTS

locale:
 [1] LC_CTYPE=ja_JP.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=ja_JP.UTF-8        LC_COLLATE=ja_JP.UTF-8
 [5] LC_MONETARY=ja_JP.UTF-8    LC_MESSAGES=ja_JP.UTF-8
 [7] LC_PAPER=ja_JP.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=ja_JP.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] data.table_1.9.6 mxnet_0.5

loaded via a namespace (and not attached):
 [1] htmlwidgets_0.5  DiagrammeR_0.8.1 magrittr_1.5     visNetwork_0.2.0
 [5] htmltools_0.3    tools_3.2.2      rstudioapi_0.4.0 Rcpp_0.12.2
 [9] codetools_0.2-14 stringi_1.0-1    jsonlite_0.9.19  stringr_1.0.0
[13] digest_0.6.8     chron_2.3-47
>

Can you tell me what is the expected result?

I expect to get the same results as the Train.py, because I input the same files. Is there anything I can do?
➜  kaggle-ndsb2  python Train.py
OpenCV is unavailable.
 Please give some time to check.

I have the exact same behavior with the R script too. Looking into this as well.

@Keiku out of curiosity what is your hardware setup ? your average Time cost above look pretty good to me.

@thirdwing @lelayf Thank you for your reply. I will check Train.R again.
@lelayf My hardware environment is as follows:
➜  deviceQuery  ./deviceQuery
./deviceQuery Starting...
CUDA Device Query (Runtime API) version (CUDART static linking)
Detected 1 CUDA Capable device(s)
Device 0: "GeForce GTX 980"
CUDA Driver Version / Runtime Version          7.5 / 7.5
CUDA Capability Major/Minor version number:    5.2
Total amount of global memory:                 4095 MBytes<PHONE_NUMBER> bytes)
(16) Multiprocessors, (128) CUDA Cores/MP:     2048 CUDA Cores
GPU Max Clock rate:                            1216 MHz (1.22 GHz)
Memory Clock rate:                             3505 Mhz
Memory Bus Width:                              256-bit
L2 Cache Size:                                 2097152 bytes
Maximum Texture Dimension Size (x,y,z)         1D=(65536), 2D=(65536, 65536), 3D=(4096, 4096, 4096)
Maximum Layered 1D Texture Size, (num) layers  1D=(16384), 2048 layers
Maximum Layered 2D Texture Size, (num) layers  2D=(16384, 16384), 2048 layers
Total amount of constant memory:               65536 bytes
Total amount of shared memory per block:       49152 bytes
Total number of registers available per block: 65536
Warp size:                                     32
Maximum number of threads per multiprocessor:  2048
Maximum number of threads per block:           1024
Max dimension size of a thread block (x,y,z): (1024, 1024, 64)
Max dimension size of a grid size    (x,y,z):<PHONE_NUMBER>, 65535, 65535)
Maximum memory pitch:<PHONE_NUMBER> bytes
Texture alignment:                             512 bytes
Concurrent copy and kernel execution:          Yes with 2 copy engine(s)
Run time limit on kernels:                     Yes
Integrated GPU sharing Host Memory:            No
Support host page-locked memory mapping:       Yes
Alignment requirement for Surfaces:            Yes
Device has ECC support:                        Disabled
Device supports Unified Addressing (UVA):      Yes
Device PCI Domain ID / Bus ID / location ID:   0 / 1 / 0
Compute Mode:
< Default (multiple host threads can use ::cudaSetDevice() with device simultaneously) >
deviceQuery, CUDA Driver = CUDART, CUDA Driver Version = 7.5, CUDA Runtime Version = 7.5, NumDevs = 1, Device0 = GeForce GTX 980
Result = PASS

The problem was solved. Probably, the cause was that CUDNN V3 Library PATH was not set. I reset CUDNN V3 Library PATH (as described below), and I re-installed Mxnet R package.
➜  ~  sudo cat /etc/ld.so.conf.d/cuda.conf
[sudo] password for kuroyanagi:
/usr/local/cuda-7.5/lib64
/home/kuroyanagi/opt/cuDNN_v3/cuda/lib64
The result is as follows, and I get the Public Score 0.039053. Sorry for bother you.
> # Training the stytole net
> mx.set.seed(0)
> stytole_model <- mx.model.FeedForward.create(
+   X = data_train,
+   ctx = mx.gpu(0),
+   symbol = network,
+   num.round = 65,
+   learning.rate = 0.001,
+   wd = 0.00001,
+   momentum = 0.9,
+   eval.metric = mx.metric.CRPS
+ )
Start training with 1 devices
[1] Train-CRPS=0.0877462931047688
[2] Train-CRPS=0.0456324221052159
[3] Train-CRPS=0.0400052660941088
[4] Train-CRPS=0.0383945520389002
[5] Train-CRPS=0.0375064123561753
[6] Train-CRPS=0.0371954288936829
[7] Train-CRPS=0.0369066569297323
[8] Train-CRPS=0.0366357021196248
[9] Train-CRPS=0.036498852389147
[10] Train-CRPS=0.0363256041206128
[11] Train-CRPS=0.0362967768782031
[12] Train-CRPS=0.0361696436480485
[13] Train-CRPS=0.0360133253702159
[14] Train-CRPS=0.0359714895919028
[15] Train-CRPS=0.035773565589106
[16] Train-CRPS=0.0356942368869444
[17] Train-CRPS=0.0356551214835385
[18] Train-CRPS=0.0354623456481464
[19] Train-CRPS=0.0354158807689773
[20] Train-CRPS=0.0352345527172354
[21] Train-CRPS=0.035248182435779
[22] Train-CRPS=0.0351510490964891
[23] Train-CRPS=0.0349674805664588
[24] Train-CRPS=0.0349555077210044
[25] Train-CRPS=0.0347828356163232
[26] Train-CRPS=0.0347312730678033
[27] Train-CRPS=0.0346366843095148
[28] Train-CRPS=0.0345923668671371
[29] Train-CRPS=0.0344321640904787
[30] Train-CRPS=0.0343131505896528
[31] Train-CRPS=0.0342747287954005
[32] Train-CRPS=0.0341063535267614
[33] Train-CRPS=0.0339723741807325
[34] Train-CRPS=0.0338380229391483
[35] Train-CRPS=0.0337685248008032
[36] Train-CRPS=0.0336959431313795
[37] Train-CRPS=0.0335495088868962
[38] Train-CRPS=0.0335088212618147
[39] Train-CRPS=0.0333586663439449
[40] Train-CRPS=0.0331459949125136
[41] Train-CRPS=0.0331119244409378
[42] Train-CRPS=0.0329116976042525
[43] Train-CRPS=0.0328198136411592
[44] Train-CRPS=0.0327235510218865
[45] Train-CRPS=0.0324554230123925
[46] Train-CRPS=0.0323232916335329
[47] Train-CRPS=0.032209057953488
[48] Train-CRPS=0.0320981216003946
[49] Train-CRPS=0.0320106385946798
[50] Train-CRPS=0.0316924550574673
[51] Train-CRPS=0.0315313752783472
[52] Train-CRPS=0.0313403861073017
[53] Train-CRPS=0.0312347643419887
[54] Train-CRPS=0.0310649411253917
[55] Train-CRPS=0.0308328422518276
[56] Train-CRPS=0.0306970435886117
[57] Train-CRPS=0.0304799400176602
[58] Train-CRPS=0.0303204193195818
[59] Train-CRPS=0.0300944426879003
[60] Train-CRPS=0.0299031844244978
[61] Train-CRPS=0.0296722100241339
[62] Train-CRPS=0.0295117787782605
[63] Train-CRPS=0.0293076340032746
[64] Train-CRPS=0.0290912068689586
[65] Train-CRPS=0.0289221597257294

On OS X Yosemite, RStudio would fail loading dynamic libraires so I ended up loading them explicitly before the requires. Now able to reproduce expected results. Shame that system-wide env vars in OS X are such a pain compared to Linux.
dyn.load('/usr/local/cuda/lib/libcudart.7.5.dylib')
dyn.load('/usr/local/cuda/lib/libcublas.dylib')
dyn.load('/usr/local/cuda/lib/libcurand.dylib')
dyn.load('/usr/local/cudnn-3.0/lib/libcudnn.dylib')

require(mxnet)
require(data.table)

@lelayf  You can also try to startup Rstudio from termimal by /Applications/RStudio.app/Contents/MacOS/RStudio

@thirdwing yes that had worked well too in terms of finding libs but would also expose my possibly messy libs setup that would cause the CRPS to be an average 0.24. Still kind of dumbfounded by this one but oh well, now it's fine.


with did:web access to well_known

When issuer uses did:web, the makes several call to wellknown , it means that probably didkit is called several time_
try with https://talao/gaixpass

yes.
NB : If the signature is verified as "failed" on the phone it is a didkit version issue. I have to upgrade the server


Aclock face

clock face was interrupting the widget area, so i shifted it down and maximized the space it can occupy while still leaving room in the widget area

woops, this was one the wrong branch to do a PR from! not sure why it's including all my history. i'll reclone the repo and start again


Failure in RT mode of the multi-scale calculation

After PR #213 , the RT mode of the multi-scale calculation does not reproduce the original results.
@uemoto1 san, could you fix it?

Thank you @shunsuke-sato san for bug reporting, I will check the reproduction of outputs !
And, Let me know the detail of the calculation condition and the related files?

As I wrote, the problem appears for the RT mode of the multi-scale calculation. So, if you set calc_mode = 'RT' and use_ms_maxwell = 'y', you can see the problem.
If you do not see any problem, please let me know.

As related problem (probably), I found the application crashed when executing example/bulk_Si/input_sc_Si.inp with 16 nodes KNL after PR #213.
I may take a long time for finding the cause of problem, because I stay in Denver until next saturday to attend the conference.

Sorry, I missed the execution environment.
In above, I modified the input parameters as follows:

num_rgrid = 16,16,16
num_kgrid = 24,24,24

@yhirokawa san. May I know the other parameters of the input files?
I suspect the problem in example/bulk_Si/input_sc_Si.inp seems to be a exceeding of the memory consumption. Recently, we turned off the symmetry option from the example input files, in order to provide the generality as the templates. I think present examples requires about 8 times larger memory resources than previous ones...

@uemoto1 san, no, I modified num_rgrid and num_kgrid only.
I hope the symmetry option sets to Sym = 1 as the default, right?
For old codes (checked git revision: c302577a41958e36388a5305fc544ef09a8e4ed5), this parameter can execute under the same environment.
I calculate the wave function array size:
number of MPI processes = # of nodes = 16
numer of kgrids = NK = 24^3
number of bands = NB = 32
number of rgrids = NL = 4096
wave function size in GS part: NK / 16 * 32 * NL = 1.6875 GB / node
wave function size  RT part: NK / 16 * (32/2) * NL = 0.84375 GB / node

I use MCDRAM only (16 GB / node), probably, this configuration not exceeds the memory capacity.

@yhirokawa san, could you add the following two line in &system group:
  isym = 8
  crystal_structure = "diamond"

This symmetry provides the equivalent condition to the older examples.

@uemoto1 san, thank you for your comment. I checked the performance of older example input.
After merging PR #213 (commit ID: ccffb36), the performance is very slower than the before merging it (commit ID: 7e3efb3), which over eight times difference.
Maybe, this increased the computational costs unintentionally when calculating SC mode.
I think that the initialization part causes this problem...

@uemoto1 san, I found and fixed a problem at #236. Could you please check it?


Pagination not working seems like i am looping on same page with for number provided in limit(n)

xray pagination not working
I have this next page link Next. Seems like im looping on same page
i wrote paginate as
.paginate(' .next a@href ')
.limit(2)
same data display 2 times

version of node: run node --version
version of npm: run npm --version

Steps to reproduce
Tell us how to reproduce this issue.
Expected behaviour
Tell us what should happen.
Actual behaviour
Tell us what happens instead.

It would be helpful to know the page you’re scraping and see the full call... Otherwise it’s hard to know. My first guess is that the selector may be slightly off.


Add replaceWithAnimation Method to Navigator component

New feature
This commit will add replaceWithAnimation function to the Navigator component which will allow the user to replace a route while having the default transition animation of the target scene.
fixes facebook/react-native#1981
Implemented based of Stack-Overflow solution - http://stackoverflow.com/questions/40393380/react-native-transition-animation-for-navigator-replace
Test plan
the following repository ReactNativeNavigationDemo (branch replaceWithAnimation) has a page implemented using the replaceWithAnimation function in SplashPage.js which replaces the splash page with the homepage and it is tested with various use cases and found that the component is working as expected.

Navigator has been moved out of this repo. Can you open this against https://github.com/facebookarchive/react-native-custom-components instead?

Sure thanks for the info!


Lack of LocalTime assertions

I faced with problem that kotlintest doesn't have assertions for LocalTime class

What kind of assertions do you suggest for LocalTime?
Em seg, 15 de jul de 2019 08:14, Abbas Abbasov<EMAIL_ADDRESS>escreveu:

I faced with problem that kotlintest doesn't have assertions for LocalTime
class
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest/issues/889?email_source=notifications&email_token=AAMBCI2UMG4DNPPX4NIWF33P7RL3BA5CNFSM4IDVWGCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7GF2QQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMBCIZUYJL4LMI4HGAMS53P7RL3BANCNFSM4IDVWGCA
.

LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeAfter(LocalTime)

LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeBefore(LocalTime)
LocalTime.shouldBeBetween(LocalTime)
LocalTime.shouldHaveSameSecondsAs(LocalTime)
LocalTime.shouldHaveSameHoursAs(LocalTime)
LocalTime.shouldHaveSameMinutesAs(LocalTime)
LocalTime.shouldHaveSameNanosAs(LocalTime)

and their versions with Not, they are the similar as from io.kotlintest.matchers.date

Great matchers!
Do you want to do it? We are open to prs!
If you are not, no worries, we can take it from here
Em seg, 15 de jul de 2019 10:10, Abbas Abbasov<EMAIL_ADDRESS>escreveu:

LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeBefore(LocalTime)
LocalTime.shouldBeBetween(LocalTime)
LocalTime.shouldHaveSameSecondsAs(LocalTime)
LocalTime.shouldHaveSameHoursAs(LocalTime)
LocalTime.shouldHaveSameMinutesAs(LocalTime)
LocalTime.shouldHaveSameNanosAs(LocalTime)
and their versions with Not, they are the similar as from
io.kotlintest.matchers.date
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest/issues/889?email_source=notifications&email_token=AAMBCI5YGVVYF56P2QBXVSTP7RZKXA5CNFSM4IDVWGCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ5ULGY#issuecomment-511395227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMBCI2U5Z74HU6NGNNNG4DP7RZKXANCNFSM4IDVWGCA
.

I can do it

We could add this to 3.4 if it's ready in the next couple of days !

We could add this to 3.4 if it's ready in the next couple of days !

I think I will do it today/tomorrow

When you do this @alladywek can you add them in a seperate file localtime.kt inside the date folder. Thanks.

When you do this @alladywek can you add them in a seperate file localtime.kt inside the date folder. Thanks.

yeah, I saw your message after PR =) I will change it.


#1788 fix karma exiting process only after a long delay, when using i…

…t via gulp. This should fix the issue, though I'm not 100% sure there are any drawbacks.

I signed it!

It seems like mike PR only kills the process as a whole, which is no improvement. I'm closing this.


Material ui does not style the pages in my isomorphic react app.

I have followed all the guide in setting up Material ui in isomorphic environment but my pages are still white without design showing on the text.
In firefox, I ge this in the console
Unknown property ‘mui-prepared’.  Declaration dropped.  localhost:3000
Unknown property ‘mui-prepared’.  Declaration dropped.  localhost:3000
Unknown property ‘mui-prepared’.  Declaration dropped.
In Chrome I get this
Uncaught (in promise) TypeError: Request scheme 'chrome-extension' is unsupported
at 80235ae9f69d4d5feb32.serviceworker.js:sourcemap:618
at
And my page looks like this

For days now, I have been unable to figure out the issue.

Please submit support requests and questions to StackOverflow using the tag material-ui. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.

DId you ever nail this?


Add a easy way for users to get a machine’s attributes, like connection information

We need an easy way to get a machine's attributes after it has been provisioned.
Something like machine['ipaddress'].
At the moment we need to query the node on the chef-server to get what we want.

+1


[Feature Request] Prompt Customization

This is also part of #105, currently this is the prompt that's always used:
prompt = f"""Use the following pieces of context to answer the query at the end. If you don't know the answer, just say that you don't know, don't try to make up an answer.
        {context}
        Query: {input_query}
        Helpful Answer:
        """

this should be customizable. I think everyone agrees. The question is whether it should be a class attribute of the app, or on a per question basis.

I would like to see #63 merged first, so we don't have a merge conflict. Then I can work on this.

The question is whether it should be a class attribute of the app, or on a per question basis.

Although it does add more (optional) boilerplate, the per question basis allows for higher customization. Also, we have not thought of a way to implement "global" class attribute settings, so this also speaks for the per question variant.

Waiting to see if we can merge #63, then this should be easy.


Force beats feature incomplete

Summary
Submitting this PR before previous merges. Much less controversial, but the body of it is only the latest commit - the rest is a duplicate of #104.
/domain @Betterment/test_track_core
/platform @samandmoore @smudge

<<domain platform

domainlgtm platformlgtm


VSCode does not have good behavior with '.properties' files when using apostrophe

VSCode Version: 1.9.0  insider 3af0e9d
OS Version: Windows 10

-- Sorry for the English, I used Google Translator --
See the gif with Sublime.

See the VSCode gif.  All extensions disabled.

Single quotes and double quotation marks should only autoclose if they have a space between them, if it is close to any letter (character) it should only open. See how the Sublime behaves.

@Tekbr thanks for reporting! I'm not personally familiar with the expected grammar for *.properties files - @aeschli any ideas?

-- Sorry for the English, I used Google Translator --
@alexandrudima @weinand @mousetraps @aeschli
Sorry for the question....
But from the code that moved, you just pulled the car shut, right?
If so, do not solve the problem.
I think @aeschli  understood.
Auto close is to continue !!
The idea is (this holds for all file types):
1- If single quotes are next to a word (either at the end or beginning) it should not auto close. And should be interpreted as single quotation marks
2- If single quotes are sepadara of the word (be at the end or beginning) for a space it interprets as like quotes.
3- This is also true for double quotes, auto close if the word is separated by a space, otherwise it only
The problem I reported is that VSCode continues to enclose in quotation marks even after the line change in '.properties' (which can not happen). See on Sublime.
Any questions, ask.

@Tekbr there are numerous cases where the current implemented heuristic or the heuristic you suggest will fail. Simply search our issues for label editor-brackets. No heuristic will please everybody. And the only way to possibly please everybody is perhaps to have a per-language implementation and not a generic language agnostic one as we have today.
In this case, in your original issue, you have specifically mentioned .properties files. It appears for .properties files that ' (single quotes) do not hold any syntactical meaning, therefore it is not useful for them to auto-close in .properties files, as single quotes are not a syntactical error as in most other programming languages.
If you have other specific cases where the current heuristic doesn't work, please open separate issues. We can then come up with a new holistic heuristic that covers all identified unhappy cases.

@alexandrudima
But in this case the problem is not autocompletion. Do the test!! See the gifs ...
The single quotation mark remains open on the other line.

Aha, two for one :). You also mean the grammar is incorrect:

@aeschli knows where we got the grammar from.

@alexandrudima Thank you...
Please ... undo your commit. The problem is not self-closing.
My suggestion above, I think is related to the case that @aeschli spoke. If you do not tell me where the issue is I make the suggestion.

@Tekbr Why revert my commit ?
https://en.wikipedia.org/wiki/.properties states that ' is not a significant character in a .properties file. Come to think of it, maybe we should remove " too.

@alexandrudima Because Atom and Sublime work well.
That's what I said above ... the question of whether the quotation marks are at the word or not.
Eg: ..properties

Eg: .html

@Tekbr my change affects only .properties files so comparison with html files is unnecessary. Again, since according to wikipedia, ' (single quote) is not a syntactical element in a .properties file, it is of no help for us to auto close single quotes in .properties files. Similar how we do not auto-close ' in JavaScript comments.

@alexandrudima I do not know how to say it ... See the gifs
If ' or " is next to for it does not auto close
If ' or " is separated from the word it auto complete.
The problem here is grammar is incorrect, but the tip above applies to all files.
If the gifs do not help ... I can try to write in my language and see if anyone can translate for you, maybe Google Translator is changing the meaning.
Autocompletion helps a lot. Please revert your commit.

The grammar issue is https://github.com/textmate/ini.tmbundle/issues/3

@Tekbr I understand quite well what you're saying, but I maintain my opinion that ' should not auto-close in .properties files, which is the change I pushed. Similar to how ' does not auto-close in a .txt file.
Please run vs code with my change and try it out, I believe there is some misunderstanding on your part to the extent of the impact of the commit, which only removes ' from .properties files. Please read closely the file the commit edits. It is the configuration file for the .properties language.

@alexandrudima I'll wait tomorrow to test!
But I manually modified your file here and it did not solve my problem. That may be the question.
How much .txt file is another problem that VSCode has.
If I open single quotation marks after word + space it's because I want to put something in quotes. If it is close to the word it is because it is apostrophe.
If it does not work, you roll back the file and reopen / move the question can you try to do something like Atom and Sublime?

@Tekbr They are all heuristics.
:+1: I agree the heuristic you propose (to take into account a space before, not only after -- only in the case of ' or perhaps ") is perhaps better in many cases. I suggest we track this suggestion in a new issue where we start fresh without any mention of .properties files .
But be advised, as with any heuristic that is not based on syntactical or semantical analysis, it will fail. e.g. for C++ where it is desirable to auto-close ' after a word character:
https://msdn.microsoft.com/en-us/library/69ze775t.aspx

Please run vs code with my change and try it out, I believe there is some misunderstanding on your part to the extent of the impact of the commit, which only removes ' from .properties files.

@alexandrudima I tested .. as I had said it did not solve the reported problem.
I created Issue #25658, as suggested.
Will you reopen this case because of the problem reported from the beginning? If you do not move to the correct place (only with the initial post). I did not put it in the repository that John said because it seems to have been abandoned / forgotten (I'm not sure). I'm waiting for an answer from you.
I can also create another issue reporting this problem again, since the initial idea (shown in the first and second gif of the initial post) did not follow the purpose.

@alexandrudima Can you answer my question?

Will you reopen this case because of the problem reported from the beginning? If you do not move to the correct place (only with the initial post). I did not put it in the repository that @aeschli said because it seems to have been abandoned / forgotten (I'm not sure). I'm waiting for an answer from you.


Not support UDP protocol

Hello
Thanks for your script.
But unfortunately it does not support UDP Protocol.
Add it if possible.
It will be great!
Thanks

Hi, the purpose of doing tls handshaking is for tcp connections, udp connections do not need handshake and can be easly done using forexample gost , this way:
https://v2.gost.run/en/kcp/
but if you are using something like v2ray , you dont need udp , the v2ray core will forward all udp packets inside tcp packets without any problem

v2rayNG cannot open websites without UDP. Because it does not have access to port 53 (UDP). Maybe this is a bug. But for most internet games, internet calls, UDP is needed. It would be helpful if you could add it. Using gost can be confusing for beginners.

I checked it again. You were right.
xray forwards udp packets to tcp in its own proprietary protocols like vless.
But for example, this does not happen in shadowsocks.


Automated cherry pick of #8395: lbcert delete bugfix

Cherry pick of #8395 on release/3.4.
#8395: lbcert delete bugfix

Codecov Report

Merging #8396 into release/3.4 will decrease coverage by 2.68%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.4   #8396      +/-   ##
==============================================
- Coverage         6.22%   3.53%   -2.69%
==============================================
  Files              759     304     -455
  Lines           117145   62303   -54842
==============================================
- Hits              7289    2205    -5084
+ Misses          109197   59945   -49252
+ Partials           659     153     -506

Flag
Coverage Δ

#aFlag
3.53% <0.00%> (-2.69%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/stats.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/events.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/notify.go
2.07% <0.00%> (-0.17%)
:arrow_down:

pkg/compute/models/buckets.go
1.10% <0.00%> (+0.03%)
:arrow_up:

pkg/compute/models/cachedimages.go
1.67% <0.00%> (-0.14%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.48% <0.00%> (-4.66%)
:arrow_down:

pkg/compute/models/dbinstance_skus.go
2.83% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/dbinstances.go
0.78% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/disks.go
0.50% <0.00%> (-0.01%)
:arrow_down:

... and 442 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3105a0...7da0a67. Read the comment docs.


member count is off

member count in is off by  a few hunderds i have heard it is a discord.net issue?
 the bot uses discord.net probably
this one uses another

Member Count should never be off as it's a value returned from the API endpoint. Whether the first bot in the image is actually using the appropriate property remains to be seen, as this doesn't actually show any helpful information.

If you're running into problems when using 0.9, the solution is to update to the latest release of 1.0. Support for 0.9 is minimal and bugs aren't going to be fixed.
You can find documentation on how to switch to 1.0 by clicking this link

If you don't download all users, you'll only get the first 250, iirc, so that, plus the 19 that have been updated since the bot was online, and you have your count.

ik asked the bot devs and they said is was a discord.net issue hence i came here i actually don't have much more info maybe their respository would help?
https://github.com/Kwoth/NadekoBot/compare/1cd785267435...cbc527346ab5

tfw you got reference to discord.net only to be redirected back orz

i did this on my own accord and i haven't gotten in touch with kwoth himself yet tbh thanks for your help

Nadeko is using a forked version of d.net that is literally monthes old... and it's Nadeko.  Do your own tests before reporting bugs.

This issue should be closed as invalid

Closing as this looks resolved.


fix: Fixed removing empty attachment modality in Response Editor

Description
Fixes issue removing empty attachment modality in the Response Editor
Task Item
Closes #6049

Coverage decreased (-0.0002%) to 53.775% when pulling b826176f6027b38b9318827d9493c43d5386916a on tdurnford:fix/remove-attachments into 8234b17ebf884e7abde206568a90aebf4619671a on microsoft:main.

The branch on remote fork is not playing nice with security analysis.


fix the protected ctor issue in resourcemanager

For all the types that might be inherited by other libraries in resourcemanager, they should have a protected ctor instead of internal ctor.
Internal ctor cannot be inherited and when you inherit it, you will get the following compilation error:
error CS1729: 'OperationStatusResult' does not contain a constructor that takes 0 arguments

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager

Please do not merge this PR because the changes here could be generated by https://github.com/Azure/autorest.csharp/pull/4126


feat: create a poetry virtual environment if it doesn't exist

When entering in a Poetry Python project, zsh-activate-py-environment tries to activate a new shell without checking if poetry env info --path returns an error. This is the case when the virtual environment was not previously created:

This PR first check if poetry env info --path return success, indicating that there exists a virtual environment. If not, zsh-activate-py-environment creates a new virtual environment and then activates it.

Please, squash this PR, I stupidly pushed .vscode/ in the first commit.

Now it is fully functional
Screencast from 19-12-2023 20:35:30.webm

Hi thanks a lot for your contributions!


Possible to view size of the db, And increase the limit of 2gb limit

Is it Possible to view size of the db, ?
And can anyhow increase the limit of 2gb limit?
What is the criteria to limit to 2gb , My phone supports 4gb main /64gb internal

@praveenpds  Is there a 2GB limit?

@praveenpds  have you found any solution for this?


New command: search externalConnections list

Usage
m365 search externalConnections list
Description
This command will allow the administrator to list external connections for use in Microsoft Search and soon for Viva Topics.
Options

Option
Description

Additional Info
This will build on the initial submission of the add command

Resetting as available due to lack of response

Can I work on this?

Of course, please go ahead!


BUG - Mod interaction with refined storage

Minecraft Version: 1.12.2
Forge Version: <IP_ADDRESS>16 (found in 2613)
Advanced Rocketry Version: 1.12.2-1.2.6-55 (found in 54)
LibVulpes Version: 1.12.2-0.2.8-27 (found in 27)
is this the latest curseforge build? yes
---- I found this issue in a mod pack and tested in a creative mode custom profile with only the 3 mods on the latest forge.

No crash
Crash Report:
Carbon collection cartridges seem to get confused when importing/exporting
basic test rig-

The exporter is able to stack collection cartridges with the same durability inside the co2 scrubber

the importer is configured with a specific durability on the cartridge (0) imports all cartridges and ignores the damage

(compare NBT is also on)

The cartridge scrubbers are standard items with a damage value and a max stack size of one.  So this is really strange.  Does this occur with tools like bows, swords and pickaxes in the same manner?

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


98% cpu stuck in parse_op()

Not sure how to debug this, but I'm seeing my app pegging the CPU (and not responding to anything) even though it's doing nothing. It looks stuck in beast::http::detail::parse_op.
Sorry for the formatting, there is a backtrace down there but github isn't maintaining formatting.
(gdb) info threads
Id   Target Id         Frame
18   Thread 0x7f34c7dbb700 (LWP 30420) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
17   Thread 0x7f34c55b6700 (LWP 31866) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
16   Thread 0x7f34ae7fc700 (LWP 31876) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
15   Thread 0x7f34ad7fa700 (LWP 31880) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
14   Thread 0x7f34a67fc700 (LWP 31884) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
13   Thread 0x7f3483fff700 (LWP 31888) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
12   Thread 0x7f34a4ff9700 (LWP 31917) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
11   Thread 0x7f3479ffb700 (LWP 31920) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
10   Thread 0x7f34797fa700 (LWP 31923) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
9    Thread 0x7f34c75ba700 (LWP 31925) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
8    Thread 0x7f34c6db9700 (LWP 31926) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
7    Thread 0x7f34787f8700 (LWP 31927) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
6    Thread 0x7f34c65b8700 (LWP 31928) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
5    Thread 0x7f34affff700 (LWP 31929) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
4    Thread 0x7f34af7fe700 (LWP 31930) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
3    Thread 0x7f347bfff700 (LWP 31932) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
2    Thread 0x7f34c4db5700 (LWP 31933) "dbhealth" pthread_cond_wait@@GLIBC_2.3.2 ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185

1    Thread 0x7f34c90f2780 (LWP 30416) "dbhealth" 0x000000000056045c in beast::http::detail::parse_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_serviceboost::asio::ip::tcp >, beast::basic_streambuf<std::allocator >, beast::http::parser_v1<false, beast::http::string_body, beast::http::basic_headers<std::allocator > >, beast::http::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_serviceboost::asio::ip::tcp >, beast::basic_streambuf<std::allocator >, false, beast::http::string_body, beast::http::basic_headers<std::allocator >, tlo::asio::detail::promise_handler > >::operator()(boost::system::error_code, unsigned long, bool) ()
(gdb) bt
#0  0x000000000056045c in beast::http::detail::parse_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_serviceboost::asio::ip::tcp >, beast::basic_streambuf<std::allocator >, beast::http::parser_v1<false, beast::http::string_body, beast::http::basic_headers<std::allocator > >, beast::http::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_serviceboost::asio::ip::tcp >, beast::basic_streambuf<std::allocator >, false, beast::http::string_body, beast::http::basic_headers<std::allocator >, tlo::asio::detail::promise_handler > >::operator()(boost::system::error_code, unsigned long, bool) ()
#1  0x0000000000561671 in boost::asio::detail::reactive_socket_recv_op<beast::basic_streambuf<std::allocator >::mutable_buffers_type, beast::http::detail::parse_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_serviceboost::asio::ip::tcp >, beast::basic_streambuf<std::allocator >, beast::http::parser_v1<false, beast::http::string_body, beast::http::basic_headers<std::allocator > >, beast::http::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_serviceboost::asio::ip::tcp >, beast::basic_streambuf<std::allocator >, false, beast::http::string_body, beast::http::basic_headers<std::allocator >, tlo::asio::detail::promise_handler > > >::do_complete(boost::asio::detail::task_io_service*, boost::asio::detail::task_io_service_operation*, boost::system::error_code const&, unsigned long) ()
#2  0x0000000000501af5 in boost::asio::detail::task_io_service::run(boost::system::error_code&) ()
#3  0x00000000004fd9c4 in boost::asio::io_service::run() [clone .isra.477] ()
#4  0x00000000004f9866 in main ()

Can you please email me the trace<EMAIL_ADDRESS>

The trace was above but hard to read, I sent you one by email (but it's from an internal email so you can't reply to it).

I see it, please confirm that it looks like this function is stuck in an infinite loop:
https://github.com/vinniefalco/Beast/blob/master/include/beast/http/impl/parse.ipp#L106
Some questions that could help:

Can this be reproduced?
Do you have the HTTP request or response that causes the loop?

Meanwhile, I am studying the function to see if I can guess what condition is causing a failure to terminate the state machine.

Infinite loop is what it looks like to me.

Has this been resolved? Is there any additional information?

Appears to be resolved in b18.

Do we have any idea which change resolved it? I can create a new issue to investigate it further to make sure it doesn't pop up again in the future.

Great, thanks!

Addressed by #175