Incorrect syntax highlighting for Markdown?

VSCode Version: 1.5.3
OS: elementary OS 0.3.2 Freya (built on Ubuntu 14.04)
Please refer to lines 18 - 21 in the screenshot for details.

# Arbitrary Piece of code

```c
#include <stdio.h>

int main(void)
{
    puts("hello world");
    return 0;
}
```

## The 2nd Heading

Lorem ipsum minim amet laboris id aliquip quis duis qui aliquip tempor ut.
Above is the main function (`int main(void)`).

## This Heading is not rendered properly

Also note that things'll get even worse after an apostrophe.
Excepteur nulla occaecat pariatur excepteur.
Reprehenderit laboris do laboris eu esse labore sit consequat.
In culpa ut mollit quis eu excepteur veniam.

Any ideas?

I'm unable to repo this colorization with VSCode 1.6, but I do still see incorrect results (such as the heading text being gold after the code block):

I believe this is another case where the fenced code block's syntax highlighting leaks outside of the fenced code block itself. We're planning to address this problem this month.

I'm seeing the same issue with version 1.7.1

Changing the ' to ’ seems to fix the colorization:

It seems that VS Code is trying to treat single-quote as a backtick. And then backticks don't get special colorization as I'd expect.
See the same file on Markdown Pad, for example:

Original issue seems to be fixed by #14626

@mairaw Can you please open a new issue to track the problem you are seeing and include the markdown source for the incorrectly highlighted file for testing. Thanks.

@mjbvz missed this earlier. Sure, I'll do that if it still repros!

Good news! Version 1.8.1 seems to have fixed my issue too:

Thanks!


Improve the events section in the home page GSSOC'23

The section can have alternate sections wherein the first event will be to the left of the screen in a container and second event will be to the right of the screen in a separate container and so on in an alternate fashion

I would like to work on this issue under gssoc'23

I am good at web development and have developed many web development projects, so adding this feature is not a big task for me. so please assign me this and I am also a GSSOC 2023 contributor.

Hello, I'm good at frontend development, I can add more features and functionalities. please assign me this issue.
I'm GSSOC'23 contributor.


Don't print stack frames from certain libraries

Is it possible to not print stack frames from third party library? Ideally with a confiuration ignore=['pandas', 'numpy'] or a function ignore(['pandas', 'numpy'])?

Yep, agreed.
Perhaps it would be useful to ignore paths that exist outside of the root of the module entirely, with the ability to enable them in scenarios where it's necessary via an environment variable.
@Delgan (hi! long time 👋🏻 hope you're doing well) what do you think about that idea?

Hey @Qix-!  :)
Regarding the issue raised here, it looks to me that it has little to do with better_exceptions and is rather a problem on loguru side. The traceback is displayed entirely which leads to printing undesired frames from third libraries. Using solely better_exceptions it would be displayed as follow:
Traceback (most recent call last):
  File "python-test/apscheduler-test.py", line 118, in print_greeting
    raise Exception("NOOOOOOOOOOOOOO")
Exception: NOOOOOOOOOOOOOO

However, if there exist cases for which better_exceptions formatting is considered too verbose, we could indeed imagine a solution to make it more readable. Adding an option to hide external paths seems like a good idea. Another possibility that I think we discussed a few years ago is to highlight the most interesting ones as done by tbvaccine:

Two others libraries that could be inspiring are PrettyErrors and rich.
Anyway, thanks for asking my opinion, I hope you're doing well too!

@Delgan I've created a new issue since it's specific to loguru https://github.com/Delgan/loguru/issues/622. I am closing this one.


[BitwiseCopyable] Remove existential conformance.

It makes sense to form an existential of a type that conforms to BitwiseCopyable but such an existential is not itself trivial and consequently not BitwiseCopyable.

@swift-ci please test

@swift-ci please test


selenium.common.exceptions.SessionNotCreatedException - Issues with GeckoDriver

Hi, thanks for the codes! Was trying to test this package out and faced this issue when running the sample codes in the README. I am not very familiar with web scraping but seems to be some issue with GeckoDriver, not too sure on why this error is popping out. Besides that, I would like to also check if this package works with Facebook groups (not pages). Please help!
>>> json_data = facebook_ai.scrap_to_json()
[WDM] - Driver [C:\Users\Jiayi\.wdm\drivers\geckodriver\win64\v0.29.0\geckodriver.exe] found in cache
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\Jiayi\Documents\GitHub\facebook_page_scraper\facebook_page_scraper\scraper.py", line 56, in scrap_to_json
    self.__start_driver()
  File "C:\Users\Jiayi\Documents\GitHub\facebook_page_scraper\facebook_page_scraper\scraper.py", line 52, in __start_driver
    self.__driver = Initializer(self.browser).init()
  File "C:\Users\Jiayi\Documents\GitHub\facebook_page_scraper\facebook_page_scraper\driver_initialization.py", line 48, in init
    driver = self.set_driver_for_browser(self.browser_name)
  File "C:\Users\Jiayi\Documents\GitHub\facebook_page_scraper\facebook_page_scraper\driver_initialization.py", line 42, in set_driver_for_browser
    return webdriver.Firefox(executable_path=GeckoDriverManager().install(),options=self.set_properties(browser_option))
  File "C:\Users\Jiayi\AppData\Local\Programs\Python\Python38\lib\site-packages\selenium\webdriver\firefox\webdriver.py", line 170, in __init__
    RemoteWebDriver.__init__(
  File "C:\Users\Jiayi\AppData\Local\Programs\Python\Python38\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 157, in __init__
    self.start_session(capabilities, browser_profile)
  File "C:\Users\Jiayi\AppData\Local\Programs\Python\Python38\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 252, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "C:\Users\Jiayi\AppData\Local\Programs\Python\Python38\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "C:\Users\Jiayi\AppData\Local\Programs\Python\Python38\lib\site-packages\selenium\webdriver\remote\errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.SessionNotCreatedException: Message: Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line

Thanks for your help, can I ask if this applies to Firefox only? Since I do have chrome installed and I assumed it will work with that...

Yeah it will, just replace "firefox" with "chrome"

Got it! Thanks for your help, hope to see the new feature for public groups soon. 👍🏻


Not working on 0.42 (iOS)

No events are fired, The ad is not displayed. I have verified by setting breakpoints in XCode that ad is being requested and received but its not displayed in the app. Also checked that its working properly on version 0.36. The code is the same.

Same issue with me react-native 0.42, doesn't fired the AdMobBanner.

@yelkamel try this
https://github.com/Sh3rawi/react-native-admob/commit/20829f13b46a986f5001bb5a49e3ccd1575d0cd5

When I do that the project didn't build because I got 7 issue on the RNAdMobManager lib.

+1

react-native-admob.zip
try this, have added the required changes

did you create pr for this ? @smakazmidd

Thank you so much for that :)

This should work with v1.2.1.


Add singlestat grids

Just like the singlegraph dashboard item can be added on its own, or in an automatically generated grid, it would be useful to add a Singlestat Grid for creating multiple singlestats from a single query. Should be a simple and straightforward addition.

Done


Event streams

Motivation

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

Codecov Report

Merging #169 (8d0916d) into main (e48429a) will increase coverage by 2.21%.
The diff coverage is 75.64%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   43.32%   45.53%   +2.21%
==========================================
  Files          10       15       +5
  Lines        4709     5106     +397
==========================================
+ Hits         2040     2325     +285
- Misses       2669     2781     +112

Flag
Coverage Δ

test
45.53% <75.64%> (+2.21%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/server.rs
18.47% <0.00%> (-0.10%)
:arrow_down:

src/ethereum/transport.rs
47.50% <47.50%> (ø)

src/contracts/abi.rs
16.66% <50.00%> (ø)

src/app.rs
70.93% <55.23%> (-21.05%)
:arrow_down:

src/ethereum/estimator.rs
72.72% <72.72%> (ø)

src/contracts/mod.rs
76.25% <76.25%> (ø)

src/ethereum/mod.rs
85.39% <80.74%> (+8.47%)
:arrow_up:

src/ethereum/rpc_logger.rs
96.29% <96.29%> (ø)

src/ethereum/gas_oracle_logger.rs
96.66% <96.66%> (ø)

src/lib.rs
40.78% <100.00%> (-0.02%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48429a...8d0916d. Read the comment docs.


Sarkar/bucket text gen

What does this PR do?
TL;DR
Instead of padding up the kvcache up to full size before starting, we grow the cache/input in multiples of bucketsize
Details
let p be prompt len, m be max_new_tokens, b be bucketsize
We start with shape = b*ceil(p/b) (the smallest multiple of b larger than p)
Once we fill it up, we move to next shape by adding b more space (shape = shape + b), and copying the old contents into the new expanded space
Advantages
If we have multiple sentences of different lengths p1,p2,p3, then each time we run, we will compile for shapes p1+m, p2+m, p3+m if we pad to max
With this bucketing we can reuse old shapes
Also pad to max wastes a lot of computation to padding especially in the earlier runs of the generation. with bucketing, the initial smaller buckets can run faster.
Test plan
Models: llama, falcon, bloom, gpt2
accuracy: fp32 test on piqa dataset, match with and without bucketing
performance: generate 256 tokens for 512, 1k, 2k prompt lens for llama
and some other tests

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Have also verified this with HPU graphs enabled and also with limit hpu graphs ? Do you hit any memory limits and recompilations ?

Have also verified this with HPU graphs enabled and also with limit hpu graphs ? Do you hit any memory limits and recompilations ?

Yes, it has been tested in conjunction with limit_hpu.

@regisss @libinta :
Addressed regiss's comments


Frequency Calculation

In your documentation you suggest this query:
SELECT
  customer_id,
  COUNT(distinct date(transaction_at)) - 1 as frequency,
  datediff('day', MIN(transaction_at), MAX(transaction_at)) as recency,
  AVG(total_price) as monetary_value,
  datediff('day', CURRENT_DATE, MIN(transaction_at)) as T
FROM
  orders
GROUP BY
  customer_id

If the point is to not take into account the first purchase for the calculation of the Frequency, What happens when the two first purchases are in the same period? In that case, that period should be count and your query is not counting it.
I think that this should be the query:
with orders AS (

SELECT
  customer_id,
  transaction_at,
  ROW_NUMBER() OVER (PARTITION BY customer_id ORDER BY transaction_at) as ranking
FROM
  orders
GROUP BY
  customer_id

),

freq AS (

SELECT
      customer_id,
      COUNT(DISTINCT date(transaction_at)) as frequency
FROM
      orders
WHERE
      ranking <> 1
GROUP BY
      customer_id

),

other AS (

SELECT
  customer_id,
  datediff('day', MIN(transaction_at), MAX(transaction_at)) as recency,
  AVG(total_price) as monetary_value,
  datediff('day', CURRENT_DATE, MIN(transaction_at)) as T
FROM
  orders
GROUP BY
  customer_id

)

SELECT
  *
FROM
  other
  LEFT JOIN freq USING (customer_id)

The same issue happens with your transformation from transactions data to frequency, recency and T data on your function  summary_data_from_transaction_data.
# subtract 1 from count, as we ignore their first order.
    customers["frequency"] = customers["count"] - 1

I'm not sure if I understood it correctly. Do you mean we are not accounting for intra-period transactions as possibly more than 1 purchase?
If that's the case, it's considered normal. Usually, we simply group intra-period transactions as a single purchase. I think that could be a problem if your period is more than a day, but otherwise I don't think it's that relevant.
In any case, consider creating a new PR, if you think it's relevant.


[graphql-language-service] Relay __id Fields are Unknown

Relay's client automatically defines an __id on any field-types which are queried with the @connection directive. E.g.:
{
  things @connection(key: "things") {
    __id
  }
}

This __id is not part of the server schema, and thus currently trips the FieldsOnCorrectType rule.
I've been trying to determine a way to ignore this, write a custom validation, etc., but I've come up short.
Any ideas? I'm coming from vscode-graphql if that's relevant.

Great question! Custom validation has worked in the language server since well before my time!
For graphql-language-service-server, vscode-graphql and any other IDE mode that uses the LSP server:
This readme needs another anchor for this section, but the second snippet is an example that shows how to add custom validation rules:
https://github.com/graphql/graphiql/tree/main/packages/graphql-language-service-server#custom-startserver
Because it requires an inline require, it needs to be a programattic config, only .js and .ts are supported currently. It predates dynamic imports

export default {
  schema: './schema.graphql',
  extensions:  {
  	 endpoints: { default: 'https://localhost:8080' },
     customValidationRules: require('./config/customValidationRules')
   }
}

here's where the config is actually loaded:
https://github.com/graphql/graphiql/blob/df57cd2556302d6aa5dd140e7bee3f7bdab4deb1/packages/graphql-language-service-interface/src/GraphQLLanguageService.ts#L201
this just expects a function that returns ValidationRule[] with the config as an argument, easy peasy!
for graphiql
you can use the validationRules prop


Mathematical formulas give high toxicity

Examples: :slightly_smiling_face:
F = 3x^2 - 0.86421335
f=4x+2 - 0.847609
f=2x^2 - 0.86421335
Using the latest TOXICITY model.

Y = 3x^2 (0.5206719)
y= 4x+2 (0.4463119)
y=2x^2 (0.5206719)
It's because of the letter F. These results are still very high, but it's all about how you implement PerspectiveAPI into your project. And a project like this will bring all kinds of false positives.

@KararTY is right about there being all sort of false-positives (and false-negatives); but reports like this are helpful, so thanks for sharing it @Foorack.
A good way to explore the false-positives is to sort comments and look at the top (and bottom) of your set. For example, see this blog post: https://medium.com/the-false-positive/better-discussions-with-imperfect-models-91558235d442
I suspect we'll need character levels models to make much progress on mathematical expressions; but we could at least start by increasing the number of data examples with mathematical formula. Perhaps by annotating talk pages of Wikipedia articles on mathematics.


performance audit/optimization

I understand this may not come at the best of times as you're currently switching from a test framework to another but let me know if you'd be interested in some kind of external performance audit/optimization of the javascript library.

This would be extremely useful indeed. I have developed brainsprite in part as a side project to learn javascript.  I am sure the code base could be dramatically improved and modularized. But as you pointed out, I do need to set up the tests before this can be moved forward. This is quite a bit of work as I am integrating the tests with documentation generation. Will tag you here when it's done.

@kchapelier the test suite is now functional. If you open a pull request, the tests will run automatically on circleci. If that's how you'd like to proceed, no need to read what's below.
If you want to run tests locally, I still need to add a "dev" section in the new documentation, but here is the short version:

install brainpsrite.py from the brainsprite folder
install js dev dependencies with npm using package.json
install py dev dependencies form docs/requirements.txt
run npm test

You can check the detailed circle test workflow in .circleci/config.yml. FYI running the dev convenience script ./update will run all tests and build the new documentation site inside docs/build
If a test fails, look at the *_diff.png images in the tests folder, they will tell you what has changed in the appearance of the viewer compared to a reference, approved version.
If you believe the changes make sense, based on the features you are adding (although I don't think this audit will bring user-visible change), you can change the reference images using:
./update -t

Thanks in advance for your help.

@pbellec 👍  I'll start to look at it in details this friday.

Some first results.
Most of the CPU time is spent processing the calls to the canvas context (drawImage and getImageData specifically), instead of dealing with pure javascript calculations. This is true both when instantiating brainsprite and when clicking on the canvas to update the value / change the coordinates.
When clickBrain is called on an instance with an overlay and a colorMap about half of the time is spent redrawing the scene, the other half is spent updating the value. This may vary depending on the source images and the colorMap size, but in my case this is true when clicking on the sagital plane, both operations were taking about 1.2ms.
This change reduces the time to update the value from 1.3/1.1ms to 0.2/0.1ms. The idea is to call getImageData only once since the method is rather costly and to manually iterate over each pixel in the array.
I haven't benchmarked the following changes (and I don't expect them to have much impact since they do not reduce the number of calls to the canvas context) but for the first one the multiply function was swapped in favor of a specific (more simple) vec4 * matrix4 function. The change also avoid multiple array instantiations and make sure coordinatesSlice receives the data as scalars. Previously coordinatesSlice was receiving arrays with a single element, but Javascript's automatic type conversion was transparently ironing out the issue.
The last change simplifies how the overlay color is checked for transparency in the updateValue function. Instead of drawing the color two times on solid black and white, the canvas is set to transparent so that the alpha value can be directly retrieved and tested.
I'll do a proper PR with those changes this week-end. There is also another optimization I want to investigate but it would imply a lot of changes and while it should improve the runtime performances (drawAll), it might cause some overhead at the initialization...

@pbellec I was wondering if you made some tests with high resolution images and if this is the case, where was the perceived bottleneck in terms of performance, is it during the initialisation or is it having trouble to update the planes when the coordinates are changed ?

This is awesome! Very interesting that the basic maths operations ended up costing as much as the actual drawing, huge thanks for sorting that out. Very much looking forward to the PR.
In terms of bottleneck, I never tried loading very large brain images, but I did try (and successfully implement) a dashboard with 80 synced viewers. The bottleneck was the drawing of the coronal and axial views. What I ended up doing was pre-build all slices in the three planes. It took a while to load, but once loaded it was much faster to draw, and I was able to move through the 80 brains at once relatively smoothly. But it also means that each sprite was duplicated three times in memory. I ended up scrapping that code (I think) because it was too much of a niche use case.
I could try to get some high res brain data to check if it is smooth.

The other optimization I wanted to investigate has more overhead than I hoped. The idea was to avoid drawImage and getImageData calls as much as possible at runtime, by loading the sprite, overlay and colorMap as imageData at the initialization and to manually populate the pixel values of a single ImageData containing all the slices/planes in drawAll(). The issue is that getting the full imageData of a sprite of 2000px/2000px at the initialization takes about 100ms. Doing it for both the sprites and the overlay at a larger resolution might get close to half a second. It doesn't seem like such a good idea anymore.

it would also come with a big memory overhead. I agree this may not be worth it.
FYI I want to add support for different voxelSize in the background and overlay brain images. Images would still need to have same spatial orientation and field of view, but one could have bigger voxels. As overlays are often much lower resolution, there may be big gains working like that, at least in terms of memory footprint.

I'm curious, did you ever run in a situation where memory became an issue (with multiple views or in a "nilearn" integration ?), or is it more of a preemptive action ?

It is more preemptive at this stage. However, I am planning to implement a 4D viewer extension soon, and upsampling the fMRI overlay to high (T1) resolution would actually be a memory hog.

it looks like we are done with the optimization at least for now, with the merge of https://github.com/brainsprite/brainsprite/pull/94 I am closing the issue.


Added dynamic year element in footer.html file

The element was made using HTML which was then made dynamic via javascript script. The year should change every year automatically.

fixes #33
Thanks this looks perfect 👏
The secrets for the test postgres db are not working so the tests are failing to run.
I'll fix this when I have some time soon and then this can be merged in 👍

https://simplytransport.ie/ Live now, thanks!


Close "Edit comment" window with key combo

I would love to be able to write a comment using the "Edit comment" button on the bottom right of the main window and then close the comment window with Ctrl+Enter. This is how most text forms, chat apps etc. handle it nowadays (including GitHub :wink:)
This would make keyboard-oriented translation workflows even more efficient.
Is there something like this planned?
I am using Poedit 2.4.2 on Ubuntu 21.04.
Thanks for consideration!

It actually does have that, since 2015 (ea1fd0e). And it does work in GTK+ version too.
If it doesn't work for you, investigate and submit a PR with a fix.

Or perhaps the issue wasn't with Enter but with Numpad Enter? If yes, then 0e2fc20243cb33f38d7d15dfa8a62af42acb4f88 fixes it; if not, then I honestly don't know and you need to investigate or provide reproduction steps.

Yes, it is the numpad Enter key! Thank you very much for implementing it ;)


Compatibility with manage.py inspectdb

I'm trying to use a legacy ldap data base by using the inspectdb command from the manage.py task, below is my settings.py code for the data base
Note: I removed IP, cn, dc & password for privacy reasons
i get the following error => AttributeError: enter
ldap.set_option(ldap.OPT_X_TLS_REQUIRE_CERT, False)

DATABASE_ROUTERS = ['back_end.router.Router']

DATABASES = {
    'default': {
        'ENGINE': 'ldapdb.backends.ldap',
        'NAME': 'ldaps://serverIP',
        'USER': u'serverCN&DC',
        'PASSWORD': u'pass',
        # 'TLS': False,
        # 'CONNECTION_OPTIONS': {
        #     ldap.OPT_X_TLS_DEMAND: False,
        # }
     },
}

Hi!
Unfortunately, there is no support for inspectdb in django-ldapdb for now.
The main issues are:

We would need to find a way to fetch and parse the LDAP schema
A LDAP database is not "tabular": there is no way to enforce (on the server) nor guess (on the client) that, for instance, objects in the ou=people branch should have objectClass: inetOrgPerson, posixAccount...

ok thanks however i have another question then, lets say we wrote the modules such as there're the same as the ones on the ldap server is it possible it interface with the ldap data base using our defined models

It could be trivial,
import ldap
con = ldap.initialize('ldaps://ldap.domain.it')
con.simple_bind_s('cn=admin,dc=domain,dc=it', 'slapdsecret')
results = con.search_s('ou=people,dc=domain,dc=it', ldap.SCOPE_SUBTREE, "objectclass=*", ["*", "+"])

The previous search_s call fetches all the entries with attributes and operational attributes together.
Something like
('uid=peppe,ou=people,dc=testunical,dc=it',
 {'cn': [b'peppe'],
  'createTimestamp': [b'20180705150529Z'],
  'creatorsName': [b'cn=admin,dc=testunical,dc=it'],
  'displayName': [b'peppe Rossi'],
  'eduPersonAffiliation': [b'faculty', b'member'],
  'eduPersonEntitlement': [b'urn:mace:terena.org:tcs:personal-user',
   b'urn:mace:terena.org:tcs:escience-user'],
  'eduPersonPrincipalName': [b'grossi@unical'],
  'eduPersonScopedAffiliation'<EMAIL_ADDRESS><EMAIL_ADDRESS>  'entryCSN': [b'20180710110305.975437Z#000000#000#000000'],
  'entryDN': [b'uid=peppe,ou=people,dc=testunical,dc=it'],
  'entryUUID': [b'99c74d9a-14b0-1038-8e58-6fb3297cf479'],
  'givenName': [b'peppe'],
  'hasSubordinates': [b'FALSE'],
  'mail'<EMAIL_ADDRESS><EMAIL_ADDRESS>  'modifiersName': [b'cn=admin,dc=testunical,dc=it'],
  'modifyTimestamp': [b'20180710110305Z'],
  'objectClass': [b'inetOrgPerson',
   b'organizationalPerson',
   b'person',
   b'userSecurityInformation',
   b'eduPerson',
   b'radiusprofile',
   b'sambaSamAccount',
   b'schacContactLocation',
   b'schacEmployeeInfo',
   b'schacEntryConfidentiality',
   b'schacEntryMetadata',
   b'schacExperimentalOC',
   b'schacGroupMembership',
   b'schacLinkageIdentifiers',
   b'schacPersonalCharacteristics',
   b'schacUserEntitlements'],
  'pwdChangedTime': [b'20180710095936Z'],
  'pwdHistory': [b'20180710095823Z#<IP_ADDRESS>.4.1.14<IP_ADDRESS>.40#7#8sd7fs78dfy87sdfy',
   b'20180710095840Z#<IP_ADDRESS>.4.1.14<IP_ADDRESS>.40#6#8sd7fs78dfy87sdfy333',
   b'20180710095844Z#<IP_ADDRESS>.4.1.14<IP_ADDRESS>.40#7#8sd7fs78dfy87sdfy111',
   b'20180710095936Z#<IP_ADDRESS>.4.1.14<IP_ADDRESS>.40#6#8sd7fs78dfy87sdfy234rwsdf'],
  'sambaNTPassword': [b'a2137530237ad733fdc26d5d7157d43f'],
  'schacHomeOrganization': [b'testunical.it'],
  'schacHomeOrganizationType': [b'university', b'educationInstitution'],
  'schacPersonalUniqueID': [b'CODICEFISCALEpeppe'],
  'sn': [b'grossi'],
  'structuralObjectClass': [b'inetOrgPerson'],
  'subschemaSubentry': [b'cn=Subschema'],
  'uid': [b'peppe'],
  'userPassword': [b'{SHA512}wwgjI6CgWzv/Ty+PcluiS0g+jRSnR1RacRwn2VD61wFb4pmMaMtzQqusJYoHii6uzq8t8X0+8mhjVdzjmcL4Ig==']})

So, this way, we could get the full list ob objectClasses iterating over all the entries, collecting all them in a global list. Then using a method to distinguish single value from multi value fields (if len(field_value)>1), then parse if datetime/timestamp.
This could be some good notes for a future implementation if you agree

@peppelinux That would be step 1, the easiest.
The problem is: how can we decide what each "table" would be? For most orgs, you can have devices, groups and persons arranged according to the team hierarchy.
How would inspectdb guess that "We want a model for employees (say, objectClass=inetOrgPerson, located in ou=employees); and another one for contractors (also objectClass=inetOrgPerson, but in ou=contractors)"?

You're right, there would be a inspection and a mapping of all the ou, and sub-ou, if you agree


1px width elements as .0625rem disappear in some browers

QUESTION
1px widths (borders etc) specced in rem can disappear completely in some browsers (Chrome) when users zoom out. This isn't a bug with pxtorem obviously, but some possible strategies for dealing with it might be:

add prop_black_list for prop_black_list: ['border', 'border-width'] type use
add a min-size to convert (going to mess with things like letter-spacing, so bad idea)

I realise that there is already a selector_black_list but that's not quite what I want.

Honestly, if this is a just me issue, then I might be best writing a postcss module to run afterwards and convert back any .0625rem (1px) values to px.

I've just noticed from here that mixed case and uppercase px values are ignored and not converted:
.myDiv {
  border: 1Px solid; // won't be converted
  border-width: 3PX; // also won't be converted
}

This does what I need — if a little hacky. Apologies if I missed this in the docs.

Thanks, you are correct about the border width being an issue. My personal use only consists of a white list of font related properties so I am not running into the same issues as others. Thanks for bringing this to my attention.
The property black list is a good idea and I'm debating whether I should add it if it won't slow down the process.
For now, I've added a paragraph on the README to show people how to use the uppercase px units to ignore specific declarations.

Thanks!


Update gh-actions-manifest-generation.md

Currently it links to https://fluxcd.io/guides/sortable-image-tags/, which is incorrect.
It should link to https://fluxcd.io/flux/guides/sortable-image-tags/ instead

Where are you seeing the broken link exactly?

I'm not sure what happened with the build failure, I don't think it was caused by your change. But I also don't see the bad link.

@kingdonb that's real weird, previously when I clicked it gives me the incorrect link, but now when I checked back it is correct -- probably error on another page 🤔
Closing this issue for the time being, sorry for the inconvenience 😅


Customize generated page title

❤ to all the contributors for this great plugin.
It seems like this gem is heavily reliant on its ability to set the page title, which prevents us from achieving our preferred page titles:

Is there a workaround? Am I missing something?

Would you like to change the title on all archive pages, or just for specific categories/tags?

I'm not really sure yet. Are there implications to each?
On Thu, May 19, 2016 at 10:12 PM, Nick<EMAIL_ADDRESS>wrote:

Would you like to change the title on all archive pages, or just for
specific categories/tags?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jekyll/jekyll-archives/issues/63#issuecomment-220518843

--
Adam Becker
(951) 9-BECKER
@AdamJacobBecker

Maybe. I'm working on a branch trying to add some support for this, as I have a similar need. jekyll-archives builds the URL for the archive page from title so if you set a custom title for a specific cat/tag it changes the URL. Either we need to build the URL from something other than title or we need to set an alt_title or page_title and provide this data via a tags.yml file in _data. This is approach I'm working on right now. Any thoughts?

I pushed a branch where I'm testing customizable tag and category titles. You can now set custom title prefixes in _config.yml using:
title_prefix:
tag_title_prefix:
category_title_prefix:

These strings will be added in front of the generated page title. If no tag or cat specific prefix, the plugin falls back to title_prefix, and if no prefix, just the tag/cat title is used.
You can set a custom title per tag/cat using _data files, specifically tags.yml and categories.yml consisting of the following format:
- title: tag title exactly as it appears on the archive page without modification
  custom_title: Modified tag Title, perhaps adding more words, or changing the case

@ajb using my branch, you'd set the following in _config.yml to achieve the result in your screenshot:
tag_title_prefix: 'Posts tagged with'

And in your tag archive layout, remove everything except {{ page.title | smartify }}

@ajb using my branch, you'd set the following in _config.yml to achieve the result in your screenshot:
tag_title_prefix: 'Posts tagged with'

And in your tag archive layout, remove everything from

 except {{ page.title | smartify }}

Any news on this issue? I would also like to see it fixed.

This is awesome! Any chance we could get a suffix too?

I'd also appreciate the ability to customize the title attribute of the generated pages.  Currently it's hard to use this plugin together with jekyll_seo_tag.

No news on this?
Thank you.


Active Directory on Windows Server 2019 Core

Can you install Active Directory Domain Services on Windows Server 2019 Core? I don't see in the list of Roles/Features on my VM but not sure if was removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 216d2c6e-b4ea-c927-0c99-bf35366529f0
Version Independent ID: 9fa31ffc-3465-a8f6-7426-7c4d76f3cc85
Content: What is Server Core?
Content Source: WindowsServerDocs/administration/server-core/what-is-server-core.md
Product: windows-server
GitHub Login: @lizap

You need to install the role manually, it is in the list of roles not installed by default:

https://docs.microsoft.com/en-us/windows-server/administration/server-core/server-core-roles-and-services#roles-included-in-server-core
(notice in particular the last column on the right hand side, "Installed by default?")

Hello @pisees,
As correctly noted by ghost, the Active Directory Domain Services role is not installed by default, but can be installed manually. Here's the list of roles available to install in the Windows Server Core: https://learn.microsoft.com/windows-server/administration/server-core/server-core-roles-and-services#roles-included-in-server-core.
If you need more information, you can also try engaging with one or more of these forums:

From Windows, use Windows Feedback Hub or press Windows + F. You can also provide feedback with Feedback.
Open a ticket with Microsoft Support.
Search or engage with Microsoft TechNet.
Search or engage with the Microsoft Developer Network.
Search or engage with the Microsoft Support Community.

Thanks for contacting Microsoft; we value your feedback. It appears that this issue has been addressed.
If you believe there’s still a documentation concern, you're encouraged to open a new GitHub issue. We welcome any additional suggestions for improving our documentation to provide a more satisfactory experience in the future. Thanks for your understanding and continued support.
#please-close


chore: js module function name change refactor

Description
Refactor for updating js object function name change refactor logic to include modules
PR fixes following issue(s)
PR for https://github.com/appsmithorg/appsmith-ee/pull/3242
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test<EMAIL_ADDRESS>


'rustup toolchain link' doesn't seem to work under MSYS2

$ rustup toolchain link stage1 build/x86_64-pc-windows-gnu/stage1

$ echo $?
0

$ rustup default stage1
info: no toolchain installed for 'stage1'

$ rustup toolchain list
nightly-x86_64-pc-windows-gnu (default)
stage1

$ rustup toolchain remove stage1
info: no toolchain installed for 'stage1'

I think this is because the toolchain subcommand has special logic on Windows because one can pick between two toolchains: mingw and msvc (I think the logic implicitly appends a triple to the toolchain or something like that). Perhaps, that special logic shouldn't be used for custom toolchains.
cc @brson

Dup of #488 - it's fixed on master there just hasn't been a release since.

Oh, OK. That's why I didn't find any open issue about this. Closing then.


Calculate number of Subsequence

Related Issue

#326

Proposed Changes

Added a code to count number of times a string occurs as a subsequence of other string
updated the readme file

Additional Info

This code uses dynamic programming and fills up the dp matrix in bottom up manner
This is one of the commonly asked interview questions and the concept of this question helps us to solve many more problems based on subsets.
This code solves an open issue #326
I have tested these changes on VS code and online compiler gdb using multiple inputs and matched the output with the expected output.
This change will not affect or create conflict with any other code
Time Complexity : O(m*n)
Space Complexity:  O(m*n)

Checklist

[x]  ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the documentation.
[x] 🎀 I have updated the documentation accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Function Screenshot
Output Screenshot

You can still improve your README
You need to follow particular guidelines for your README , please follow
these guidelines click here
also you can see how your README should look like see here
for more please go through these here

Closing this pr!


Optimization and simplification of Event handler management

Description of changes
(Improvement - no issue fixed)
NOTICE: These modifications still need testing, but I would first like your feedback about the assumptions I made.
E.g.: once the callback pointers are made static, leaving in place different entries for different transitions might still be unnecessarily cluttering, but with no penalty in terms of memory usage.
One more point to think about: analog inputs are the only type of input which might be more likely to require a different handler depending on the source channel.
In order to optimize memory usage and simplify code logic,  the Event handler functions have been modified as follows:

handlers for MFButton unified, also for MFEncoder (all transitions use the same handler anyway)
handlers for MFButton, MFEncoder and MFAnalog (pointers and assignment functions) made static (no need to define a different handler for each button. Exception: Stepper zero, see remark below).
MFAnalog: removed handler assignment from constructor; introduced separate attachHandler() function like MFButton/MFEncoder
MFStepper: removed dependency from MFButton in order to avoid the need for separate handler (not a "proper" button anyway)
(not related to the main topic) MFButton: added status argument to trigger() to avoid unnecessary double call

The changes are a little extensive as far as the number of files is concerned, but not really pervasive.

A little comparison of storage size, if that helps.
Before:
RAM:   51.0% (used 4178 bytes from 8192 bytes)
Flash:  9.8% (used 24832 bytes from 253952 bytes)

ProMicro
RAM:   67.3% (used 1723 bytes from 2560 bytes)
Flash: 88.7% (used 25432 bytes from 28672 bytes)

Uno
RAM:   73.3% (used 1502 bytes from 2048 bytes)
Flash: 71.3% (used 23012 bytes from 32256 bytes)

After:
RAM:   45.3% (used 3714 bytes from 8192 bytes)
Flash:  9.5% (used 24094 bytes from 253952 bytes)

ProMicro
RAM:   63.2% (used 1617 bytes from 2560 bytes)
Flash: 86.1% (used 24694 bytes from 28672 bytes)

Uno
RAM:   70.7% (used 1448 bytes from 2048 bytes)
Flash: 69.1% (used 22290 bytes from 32256 bytes)

While setting up my first draft for a keymatrix I also struggled about all these handlers. From my point of view this makes absolutely sense, I can do tests earliest on the weekend, maybe in the next days for a promicro but w/o device connected.
Just a few comments from my side:

Can the handlers for buttons/encoders/analogIn combined to one? They all transfer a "value" and name. The only difference is uint8_t / uint16_t (analog).
Must it be in this way like the handlers are used now or would be a global "function" (which would be called from each device) also sensefull/easier? Yes, I am not the best in C++ ;)

I am wondering what the best strategy would be to test these changes. I could set up a branch in my fork, but how do I get all these changes into my branch? Or can I directly "copy" a branch from gioCC into my repo?

My take on your welcome comments:

Can the handlers for buttons/encoders/analogIn combined to one? They all transfer a "value" and name. The only difference is uint8_t / uint16_t (analog).

They probably could, though I am not sure if that would bring a practical advantage. The way I see it, keeping it this way leaves  a minimum degree of flexibility that could be useful.

Must it be in this way like the handlers are used now or would be a global "function" (which would be called from each device) also sensefull/easier? Yes, I am not the best in C++ ;)

Similar answer as above: probably in this case an "ordinary" global function would do quite fine, but then again, this way the code has a little more sound decoupling at basically negligible cost.

I am wondering what the best strategy would be to test these changes. I could set up a branch in my fork, but how do I get all these changes into my branch? Or can I directly "copy" a branch from gioCC into my repo? I would appreciate some hints.

I guess the safest and more straightforward thing would be to clone my repository in a new folder. Probably a little early to think about a merge (even temporary and for testing) with other code.

@elral VSCode makes it easy to review/test pull requests.

Make sure you have the GitHub Pull Requests and Issues extension  installed.
Click the GitHub icon in the left icon rail
Right click on the pull request in the top part of the screen and select Checkout pull request

You can also use the pull request UI in VSCode to review and comment on pull requests.

@GioCC , did you test the changes on a board? I just tried it and the one button and one encoder which is connected do not inform about changes.

Unfortunately not yet, I finished late yesterday and I will be able to make time not sooner than tomorrow evening.

I found out that I was one local commit short when I made the pull request.
After line 238 in mobiflight.cpp there should be another line "attachEventCallbacks();"
Sorry for the mishap, I will correct is as soon.

Just saw this while looking through the code. Now the button and encoder is working ;)

The original motivation for individual callbacks/handlers comes certainly from my OOP background. Now that we know that we don't need the flexibility (other than the stepper), and we want to lower the memory footprint, such a change can be made.
I am still not decided if i really like the MFButton removal... I think it is like a button, and we should reuse our own building blocks. So I am not sure if it is worth it to save a couple of bytes for that. but I see exactly this is the "blocker" for the static button eventhandler... because otherwise we would have to put extra logic there... which won't work.

@DocMoebiuz exactly, you've summarized it perfectly. I was also reluctant to remove the MFButton from the stepper at first, and I would have probably left it if it hadn't blocked the whole modification... but in the end, even conceptually the stepper switch is unlikely to require most of the features of a generic button, and only a few lines of code are actually required. After all, I was convinced the choice was sound.

For me the stepper switch is a limit-/position switch, not an input switch. The function is different, the position switch should detect a defined position and this without debouncing. The first signal change must be detected and reacted, following debouncing is not really reproducable (and therefore the time its debouncing).
Input switches must detect exactly one signal change if pressed from the user, so they must be debounced. 2digit milliseconds later (debounced state) from the first signal change do not care.
But there is another topic I can't answer myself. I think in the existing version a signal change is detected and a message is given to the connector via the MFButton class. I don't know if this is processed by the connector.
With this new version I don not see that a message is given to the connector. If it would be required it could be added. Unfortenutely I do not know the connector in detail to answer this.

I think in the existing version a signal change is detected and a message is given to the connector via the MFButton class. I don't know if this is processed by the connector. With this new version I don not see that a message is given to the connector. If it would be required it could be added. Unfortenutely I do not know the connector in detail to answer this.
That is another reason why I considered the stepper switch not to be a "proper" button.
I didn't follow up on the check inside Connector, but the MFButton belonging to the stepper was not registered (thus it did not took part in forced retriggers), nor would transmit any status change (its callback had no calls to cmdMessenger).

@MobiFlight-Admin @neilenns I have one question to ask: I had already removed myself MF-FirmwareSource_GCC.code-workspace and nuovo 1.txt myself from my branch (and committed to the remote repo); I would have expected the deletions to appear in the PR, did they not? Do you have any suggestion about what I might have missed?

They should have appeared as long as you did these three steps:

Delete the files
Commit the changes
Push to the remote

It's possible you did 2 but not 3.

I thought I did all three, but it's definitely possible I'm mistaken. I'll take better care next time.


If hls live stream with dvr stalls, "back to live" button should appear

Currently it stays showing "live" when playback resumes, so you have to seek somewhere else, in order for "back to live" to become visible, to get back to the live point.

can we close this one?

No I'd forgotten about this but it still happens.
If you start a stream then throttle the network in chrome's dev tools, let it stall for a while, then unthrottle it so it resumes it still shows as being at the live point.


The loader is not same with templates, so the title can't work

I have three templates,for example:header.html、index.tpl.htmlandfooter.html, so zhe dist index.html is build from these three.
this is my index.tpl.html
<%= require('html!../../templates/header.html') %>

this is content

<%= require('html!../../templates/footer.html') %>

and i special the loader to underscore:

when i enter webpack,i found that thefooter.htmland theheader.html is load by html-loader,and index.tpl.html is load by underscore-template-loader as it below.
I didn't special any html-loader with  /\.html$/

What do you think means the 'html!' in html!../../templates/footer.html?

Oh! Haha That's my fault. I'm so sorry! Thx very much.

:)


[FEAT] Update CSS animations to only animate properties in the GPU

:bulb: Feature request
Feature Name
Update CSS animations to only animate properties in the GPU
The Desired Behavior
CSS animations should utilize properties/styles that are in the GPU to reduce implicit compositing and lessen memory. transform and opacity should ideally be the only properties that are animated.
Your Use Case
As a developer, I should not be animating styles that are not in the GPU.
Prior Work
https://medium.com/outsystems-experts/how-to-achieve-60-fps-animations-with-css3-db7b98610108
https://www.smashingmagazine.com/2016/12/gpu-animation-doing-it-right/
Environment

Daffodil version: X.Y.Z
Angular version: X.Y.Z

For Tooling issues:
- Node version: XX
- Platform:

Others:

By using GPU-accelerated properties and limiting the number of properties that are animated, you can reduce the amount of memory used by the animation and improve its performance. You can also consider using the will-change property to inform the browser that an element will be animated, which can help optimize its performance.
Overall, optimizing CSS animations for GPU acceleration can improve the user experience and make your application feel more responsive

Touched by https://github.com/graycoreio/daffodil/pull/2583

TODO:

[ ] Accordion
[ ] API List
[ ] Type Label Mixin


Add machine learning for excessive set overhead

This branch does a few things:

Adds get vs. set tracking to L1 caches, expressed as a key overhead score that the integrated cache can request.
When there's a request to set a key+value, the integrated cache checks the current overhead score for the key. In the common case where there's been a miss and then a set, the overhead score would be at -1 before setting the new key (and zero immediately after).
If the overhead score (attempted gets versus sets) is high (say around 100) and the local L1 has a negative cache for the key, then it doesn't set anything, anywhere.
If the overhead score is high and there is no negative cache in the L1, delete the key and set a negative cache in the local L1 with an escalating expiration (depending on how excessive the overhead score is).

The effect is distributed decision-making my the local PHP-FPM pools for which keys aren't worth the time to store. There's a bit of back-and-forth as the nodes converge on the same decisions, but it should normalize within 1000 requests.

Coverage remained the same at 100.0% when pulling c08fc530e67a414217b7b9cfb72ccf814b72ce31 on machine-learning into 1e40124afd2ce2064de2018f6189a83ac716fcfc on master.

Coverage remained the same at 100.0% when pulling a81651159e1e86ddc33f0efd3229cd4698d81e32 on machine-learning into 1e40124afd2ce2064de2018f6189a83ac716fcfc on master.

Coverage remained the same at 100.0% when pulling 267b0af5435b2a61d9650444b638b90983d0b5ef on machine-learning into 8e48054887baa9173ebc776d549df108932ecf26 on master.

Coverage remained the same at 100.0% when pulling dc9852c1e2b9ee072d5687c0bdacf82f13b46d2d on machine-learning into 8e48054887baa9173ebc776d549df108932ecf26 on master.


bump libcoap to v4.3.4a

This is the latest tagged release.

Are there any changes that are particularly relevant for us or just updating?

There is NULL pointer dereference bug fixed in this version. I was running into it on my Linux machine. This is the commit: https://github.com/obgm/libcoap/commit/ae2cc9ffef56245177b7682f44b66da648d05aea


CronJob with attribute suspended = context deadline exceeded

Output of helm version: 3.12.0
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3", GitCommit:"25b4e43193bcda6c7328a6d147b1fb73a33f1598", GitTreeState:"clean", BuildDate:"2023-06-14T09:47:38Z", GoVersion:"go1.20.5", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.5-gke.1400", GitCommit:"4eb57372b0f0ac0023caca078161b75185febeef", GitTreeState:"clean", BuildDate:"2023-06-05T09:29:48Z", GoVersion:"go1.19.9 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): GKE
Problem : when I install a new chart that contain a cronjob object that has the attribute suspend: true with the atomic flag, everything get installed correctly but helm reach the timeout and rollback the installation.
Command executed :
helm upgrade package-name oci://docker.pkg.dev/project/repo/package --install -f dev-values.yaml --version 2.0-test --namespace dev --atomic
output message :
Error: release package-name failed, and has been uninstalled due to atomic being set: context deadline exceeded
If I change the suspend value to false, it's working fine. Could this be a bug in the detection of the correctness of the installation with the atomic flag ?

I added the --debug flag and the waiting reason appeared.
ready.go:258: [debug] Service does not have load balancer ingress IP address: pod-name
I will check back my config, it should be related to a config that may not have followed during an upgrade.
Thank you !

I will close the case and it's effectively not related to a bug.
Thank you @MichaelMorrisEst for your answer !


Sync config with s3 input  for aws authmethod and http_proxy

The implementation of AWS authorization and http proxy have a gap between input and output s3. This PR standardizes aws authorization and HTTP proxy

support auth_method, which is supported in s3 input
standardize HTTP proxy config which is equal to the s3 input

proxy_host, porxy_port are deprecated

@dmikurube Could you take a look at this PR?
I don't know how to publish this plugin to sonatype.
And also, I don't have any permission in rubygems

@dmikurube I committed all ur suggestions:)

Thanks! The release may be next week...

Merging. Some pull requests would follow to upgrade dependencies / cleanup / else...


Deprecation warning (2024.09.1): async_forward_entry_setup will stop working in 2025.6

still some time left, but since it hasn't been reported yet, here you go :)
Logger: homeassistant.helpers.frame
Quelle: helpers/frame.py:151
Erstmals aufgetreten: 12:39:40 (1 Vorkommnisse)
Zuletzt protokolliert: 12:39:40
Detected code that calls async_forward_entry_setup for integration, rct_power with title: RCT Power Inverter at  and entry_id:, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead. Please report this issue.

Equal to to https://github.com/weltenwort/home-assistant-rct-power-integration/issues/397#issue-2512317742 but at different line number:
Logger: homeassistant.helpers.frame
Source: helpers/frame.py:234
First occurred: 5:08:50 PM (1 occurrences)
Last logged: 5:08:50 PM
Detected code that calls async_forward_entry_setup for integration, rct_power with title: RCT Power Inverter at {removed} and entry_id: {removed}, which is deprecated, await async_forward_entry_setups instead. This will stop working in Home Assistant 2025.6, please report this issue


Signing presentation is not working for RSA keys

Bug Report
Describe the Bug
Signing presentation is not working for RSA keys
Observed Behavior
Seems like a null public key is provided to Jwk creation here which in turn throws a NPE under the hood for RSA keys.
Steps to Reproduce
For example:

Replace Ed25519 algorithm with RSA in LdpPresentationGeneratorTest
Run tests

Context Information

Used version v0.5.1

@andresrosenthal thanks for raising this. RSA hasn't been a big requirement for us thus far, since most systems use ECDSA or EDDSA keys.
The fix is trivial, but it will happen in upstream EDC.


⚠ Bofrost.fr has degraded performance

In 02a7de3, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2220 ms

Resolved: Bofrost.fr performance has improved in b1990f1 after 9 minutes.


Feature Request: allow for groups of open editors quick switching

I think it would be very useful to be able to arrange groups of open editors ( including split screens, etc ) in vscode. Similar to how you can arrange groups of screen divisions in tmux.
So for instance, you could have a group consisting of a window split by half with different groups of files on each of them, and then have another group with another set of files with no split screen.
I use this feature extensively on tmux, and I think it can contribute to improve a lot the experience in vscode, as sometimes you are studying a large project and you need to keep track of several files at the same time, but with the current functionality you can get your current screen view super crowded of opened files.
Thanks!

Sounds like a feature request for editors, thus forwarding to @bpasero
We already have editor groups, but it sounds like you want something more permanent.


Enhance select order-by combine to use merge sort

Currently for selection order-by queries, when combining multiple segment results, we maintain a heap (PriorityQueue) of the top values, which has time complexity of O(nlogm) where n is the total number of values, and m is the number of top values to be collected.
This PR enhances that by using the merge sort which has the time complexity of O(n). Within each segment, we do need to convert the heap to a sorted list, but that can be done parallel.
This PR doesn't change the broker side merge logic for backward compatibility. We may optimize the broker side merge after this PR is released.

Codecov Report

Merging #10357 (7281ad4) into master (246f4db) will decrease coverage by 7.58%.
The diff coverage is 93.26%.

@@             Coverage Diff              @@
##             master   #10357      +/-   ##
============================================
- Coverage     32.06%   24.48%   -7.58%
+ Complexity      245       49     -196
============================================
  Files          2035     2023      -12
  Lines        110228   109893     -335
  Branches      16748    16716      -32
============================================
- Hits          35342    26905    -8437
- Misses        71742    80186    +8444
+ Partials       3144     2802     -342

Flag
Coverage Δ

integration1
24.48% <93.26%> (+0.02%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...erator/blocks/results/AggregationResultsBlock.java
44.44% <ø> (ø)

...core/operator/blocks/results/BaseResultsBlock.java
71.69% <ø> (ø)

.../operator/blocks/results/DistinctResultsBlock.java
100.00% <ø> (ø)

...operator/blocks/results/ExceptionResultsBlock.java
66.66% <ø> (ø)

...e/operator/blocks/results/ExplainResultsBlock.java
70.37% <ø> (ø)

...e/operator/blocks/results/GroupByResultsBlock.java
55.46% <ø> (+0.84%)
:arrow_up:

.../operator/blocks/results/MetadataResultsBlock.java
0.00% <ø> (ø)

...re/operator/combine/merger/ResultsBlockMerger.java
100.00% <ø> (ø)

...core/query/selection/SelectionOperatorService.java
64.58% <ø> (ø)

...operator/query/LinearSelectionOrderByOperator.java
72.22% <87.09%> (+5.29%)
:arrow_up:

... and 324 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This is great. Did we / can we consider using the order statistics algorithm that provides worst case linear time ?
cc @jasperjiaguo (we discussed this improvement in the past).

@siddharthteotia We can consider that algorithm inner-segment. Currently since inner-segment is already sorted, the combine is already linear time in the worst case.


Vendoring documentation is outdated

Issue description
The documentation included in pipenv/vendor/README.md is outdated.
I tried the command described there:
 ~/.local/bin/pipenv run inv
/home/oznt/.local/lib/python3.6/site-packages/pkg_resources/__init__.py:119: PkgResourcesDeprecationWarning: 1.6.5-ubuntu0.7-elementary19-ubuntu18.04.1 is an invalid version and will not be supported in a future release
  PkgResourcesDeprecationWarning,
Error: the command inv could not be found within PATH or Pipfile's [scripts].

Expected result
I expect to be able to create and updated packages in the directory vendor.
Actual result
The script failed with the error above.
Judging from the current CI, I think the correct way to do it is:
python -m invoke vendoring.update

Please run $ pipenv --support, and paste the results here. Don't put backticks (`) around it! The output already contains Markdown formatting.
$ pipenv --support
Pipenv version: '2022.1.8'
Pipenv location: '/home/oznt/.local/lib/python3.6/site-packages/pipenv'
Python location: '/usr/bin/python3'
Python installations found:

3.6.9: /usr/bin/python3.6
3.6.9: /usr/bin/python3
3.6.9: /usr/bin/python3.6m
2.7.17: /usr/bin/python
2.7.17: /usr/bin/python2
2.7.17: /usr/bin/python2.7

PEP 508 Information:
{'implementation_name': 'cpython',
 'implementation_version': '3.6.9',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '5.4.0-91-generic',
 'platform_system': 'Linux',
 'platform_version': '#102~18.04.1-Ubuntu SMP Thu Nov 11 14:46:36 UTC 2021',
 'python_full_version': '3.6.9',
 'python_version': '3.6',
 'sys_platform': 'linux'}

System environment variables:

LS_COLORS
LC_MEASUREMENT
LESSCLOSE
LC_PAPER
LC_MONETARY
XDG_MENU_PREFIX
LANG
GDM_LANG
PANTHEON_TERMINAL_ID
DISPLAY
QT_STYLE_OVERRIDE
OLDPWD
GTK_CSD
COLORTERM
XDG_VTNR
GIO_LAUNCHED_DESKTOP_FILE_PID
GTK3_MODULES
SSH_AUTH_SOCK
LC_NAME
XDG_SESSION_ID
XDG_GREETER_DATA_DIR
USER
DESKTOP_SESSION
QT_QPA_PLATFORMTHEME
PWD
HOME
SSH_AGENT_PID
QT_ACCESSIBILITY
LIBVIRT_DEFAULT_URI
XDG_SESSION_TYPE
XDG_DATA_DIRS
XDG_SESSION_DESKTOP
LC_ADDRESS
LC_NUMERIC
GTK_MODULES
TERM
SHELL
VTE_VERSION
XDG_SEAT_PATH
QT_IM_MODULE
XMODIFIERS
XDG_CURRENT_DESKTOP
GPG_AGENT_INFO
GIO_LAUNCHED_DESKTOP_FILE
XDG_SEAT
SHLVL
LANGUAGE
PROMPT_COMMAND
LC_TELEPHONE
GDMSESSION
GNOME_DESKTOP_SESSION_ID
LOGNAME
DBUS_SESSION_BUS_ADDRESS
XDG_RUNTIME_DIR
XAUTHORITY
XDG_SESSION_PATH
XDG_CONFIG_DIRS
PATH
LC_IDENTIFICATION
SESSION_MANAGER
LESSOPEN
LC_TIME
_
PIP_SHIMS_BASE_MODULE
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH
PYTHONFINDER_IGNORE_UNSUPPORTED

Pipenv–specific environment variables:
Debug–specific environment variables:

PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/oznt/.rvm/bin:/home/oznt/.rvm/bin
SHELL: /bin/bash
LANG: en_US.UTF-8
PWD: /home/oznt/Software/pipenv

Contents of Pipfile ('/home/oznt/Software/pipenv/Pipfile'):
[dev-packages]

flake8 = ">=3.3.0,<4"
pytest = "*"
mock = "*"
"delegator.py" = ">=0.0.13"
sphinx = "<=1.5.5"
"-e ." = "*"
toml = "*"

[packages]

pew = ">=0.1.26"
pep8 = "*"
pytest = "*"
pip-tools = "*"
semver = "*"
requests = "*"

[requires]
python_version = "3.6"

Pipenv does not have vendoring support built in, the documentation you read refers to the dependences that pipenv has included within itself - that is, vendored for it's own use

Yes, and that document I read is outdated. I'm am not expecting vendoring support. I'ml expecting the developer documentation to be updated.

the command inv could not be found within PATH or Pipfile's [scripts].

inv is provides by invoke package, you should find it after runpipenv install -d

So, I need to install pipenv before I develop pipenv?
This should also be documented. Using make install from the makefile is broken (it tries the system's pip).

So, I need to install pipenv before I develop pipenv?
That is the case, it can be install with pip install -e .

@frostming pip install -e . is broken.
See note: https://github.com/pypa/pipenv/blob/9770d6e11c4443742d1f4a617f1a8b4520ee2627/CONTRIBUTING.md?plain=1#L220
Currently, there is no clear way on how to start developing on pipenv.

Sorry, I didn't mention that you should do development in a vitualenv. That is the best practice.

So, the docs should say:
pip install --user pipenv
pipenv shell
pip install -e .

As I just noticed, @oz123, you have changed the directories from vendor to docs/dev or reworked the whole documentation. Can this issueu be closed?
I would like to make a request to also describe how a proper development environment for pipenv should look like? Or at least recommend a good one? I have decided, after a lot of back and forth, to keep installing pipenv in a docker image and testing the function I have been working on.
For example:

dockerfile:

FROM python:3.9

WORKDIR /opt

RUN apt update && apt upgrade -y && pip install --upgrade pip

COPY ./pipenv /opt/pipenv

CMD ["bash"]

docker build -t pipenv_dev .
docker run -it --rm pipenv_dev bash
# pip install -e ./pipenv
then follows teststs like # pipenv install


Lint also tests

Coverage remained the same at 100.0% when pulling a6f9c552c53e9f2433aefd7b4d2e33341922bb08 on lint into 3bec17b4a24391fdcc8845434cbddcc40eda1626 on master.


[Map] Make UX Map compatible with Live Components (and some internal things)

Q
A

Bug fix?
no

New feature?
yes

Issues
Fix #...

License
MIT

Here’s a corrected and polished version of your text:

Hi! 😊
This PR enhances the UX Map to be compatible with Live Components, allowing you to interact with the Map directly from your PHP code. You can perform actions and see your map update in real-time from the front-end!
To achieve this, I had to refactor and improve several areas:

Due to the hydration and de-hydration processes of Live Components, I ensured that the toArray and new fromArray methods for Map, Marker, and all other value objects could rebuild an equivalent object accurately (e.g., $marker == Marker::fromArray($marker->toArray())).
Since Stimulus monitors value changes, it wasn’t efficient to store everything in a single large view object containing zoom, center, markers, etc. These properties were split into individual values to improve performance.
Before rendering the map, an @id is now automatically computed for each Marker and Polygon definition. This optimization makes rendering significantly more efficient, avoiding the need to remove and re-render all markers or polygons (and avoiding a visual glitch aswell).

https://github.com/user-attachments/assets/c151e64c-7321-46d3-a5c6-cfeaf57beb47
https://github.com/user-attachments/assets/ffb12035-a0c3-48b3-afb7-ddf2c24c318a

Note: Usages and examples can be a bit limited for the moment, but for a next PR I would like to add more methods like getZoom() or removeMarker() (...)


luci-app-cifsd: fix typo and add Simplified Chinese translation

Ping @castillofrancodamian

Hi, what should I do with this?
El mié., 16 de oct. de 2019 a la(s) 23:43, Richard Yu (
<EMAIL_ADDRESS>escribió:

Ping @castillofrancodamian https://github.com/castillofrancodamian
You can view, comment on, or merge this pull request online at:
https://github.com/openwrt/luci/pull/3199
Commit Summary

luci-app-cifsd: fix typo
luci-app-cifsd: add Simplified Chinese translation

File Changes

M
applications/luci-app-cifsd/htdocs/luci-static/resources/view/cifsd.js
https://github.com/openwrt/luci/pull/3199/files#diff-0 (4)
M applications/luci-app-cifsd/po/templates/cifsd.pot
https://github.com/openwrt/luci/pull/3199/files#diff-1 (4)
A applications/luci-app-cifsd/po/zh-cn/cifsd.po
https://github.com/openwrt/luci/pull/3199/files#diff-2 (110)

Patch Links:

https://github.com/openwrt/luci/pull/3199.patch
https://github.com/openwrt/luci/pull/3199.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openwrt/luci/pull/3199?email_source=notifications&email_token=ALLWJKU66TZPC6CJKUV42ADQO7GOZA5CNFSM4JBTL7WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSKP4WA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALLWJKXBH7RBX3T6WNABGHTQO7GOZANCNFSM4JBTL7WA
.

@castillofrancodamian Update Spanish translation.

Something I forgot to say: I think the "Hide dot files" is not easy to explain in Chinese. (It means "hide files starting with a dot", which is too long.) So I leave it blink.


[How To] Maximize Slickgrid

I thought I would share a modification I made to maximize the slick-grid. Since my users use this similar to excel and would like it to be the main focus sometimes. Clicking the maximize button will fill the screen with the GridDiv, clicking again will restore it back it it's original state.
CSS in Dashboard.html

JS in Dashboard.html
Add after Q.initFullHeightGridPage($('#GridDiv'));
        $('#GridDiv .grid-title .title-text').append('');

        $('#panel-fullscreen').click(function (e) {
            $('#GridDiv').toggleClass('fullscreen');
            Q.initFullHeightGridPage($('#GridDiv'));
        });

If anyone wants to expand or clean this up, feel free.

Very nice and useful thanks for sharing.

Nice, thank you!

Looks like a cool feature to me, maybe add it to the wiki?

hey again. I just noticed a side effect.
When you have @Serenity.Decorators.filterable() on a grid, when screen is maximized, the EDIT FILTER button at the bootom right is not working.

For those using CardMixin, change the js in .html with :
      $('#GridDiv .view-switch').append('');
      $('#panel-fullscreen').click(function (e) {
        $('#GridDiv').toggleClass('fullscreen');
        Q.initFullHeightGridPage($('#GridDiv'));
      });

It will add the fullsize icon after cardmixin icons giving nice visual effect.

Nice Feature.
Thank you.

Works great. Thanks for sharing.

Based on the version of zKarp, I have made a more Serenity Framework integrated version.
For this, do the following:
(1) Create a new less file: e.g. site.myProject.less and insert the following content:
    #GridDiv.fullscreen {
        z-index: 9999;
        width: 100%;
        height:100vh;
        min-height: 100%;
        position: fixed;
        top: 0;
        left: 0;
    }

(2) Import this new less file within site.less like this:
@import "site.myProject.less";

(3) Create a new Helper Typescript file called GridHelpers.ts under /Common/Helpers/ and insert the following:
namespace <yourProject>.GridHelper {
    export function EnableFullSizeGrid() {
        Q.initFullHeightGridPage($('#GridDiv'));
        $('#GridDiv .grid-title .title-text').append('');
        $('#panel-fullscreen').click(function (e) {
            $('#GridDiv').toggleClass('fullscreen');
            Q.initFullHeightGridPage($('#GridDiv'));
        });
    }
}

(4) In the Modules where you want this feature to be added within the grid, do the following two steps:
(4a) Within xyzGrid.ts, insert the following:
    // *** Enable Full size grid resize ***
    <yourProject>.GridHelper.EnableFullSizeGrid();

(4b) Within xyzIndex.cshtml, remove the following line:
    Q.initFullHeightGridPage($('#GridDiv'));

With that, you can enable this feature on any grid you want and you don't have to write the full javascript code every time.
Hope this helps somebody.
With kind regards,
John

Hi @JohnRanger !
I try to follow your instructions for grid full size and it works.
My problem, when i try to open the edit link the dialog does not show when i'm in full size mode.
thanks!

Hi @alex-444 ,
I have quickly tested it and - yes - you are right - this does not work - I expect, that this also does not work with the original implementation.
Actually, the Dialogs do open but they are hidden under the full size grid.
If you do resize the grid back then they appear.
I will see if I can adjust the Z-index of full size panel so that it stays behind the dialogs.
With kind regards,
John

@zKarp ,
as this issue (actually a how to) is already open since nearly 1 year and howtos should be within the wiki, I have created a wiki article for your howto.
Would you mind to close this issue here? :-)
With kind regards,
John


Fix trimTextMid

There was a subtle bug in trimTextMid caused by calling substring methods with non-integer values. This happens because findValueBisect returns non-integer values, and there was no special handling of this.
The bug results in strings cutting off many of the last few characters in a string, rather than always displaying it when possible.
Before:

After:

Fixes #411

coverage: 42.978%. remained the same when pulling b2be6d60f13fc1f0610e4135cca5e7402c22838f on jlfwong/fix-trimTextMid into 693545b77abed8c135c8a90c3ab1d4e7d77d654d on main.


Add a default 6-minute timeout on CD

Add a timeout while calling the CD code so that we don't spend more than 6 minutes running their code and to prevent any hangs.

We discussed this on our side, and we should be using the standard CancellationToken pattern^1 if possible. From your side you will create a CancellationTokenSource, add a timeout, and provide us with the CancellationToken
var cts = new CancellationTokenSource();
cts.CancelAfter(TimeSpan.FromMinutes(6));
componentDetectionOrchestrator(args, cts.Token);

We ended up using a default of 15 minutes, which can be overridden by adding the Timeout argument, alone with the number of seconds, to the list of AdditionalComponentDetectorArgs.


Add ability to OCR the bus odometer

This is a big one and it's a mess, sorry. I'll try to clean it up a bit before merging.
This adds a component bus_analyzer. It watches segment directories and runs an analysis
against each segment file. Right now the only thing that analysis does is OCR the current bus odometer.
It places this result (or NULL if it couldn't read the odo) into a database table bus_data.
This table stores an odometer reading for each segment, along with a timestamp.
Finally, thrimshim has a method added that can read this table to fetch the latest reading.
I put this in thrimshim because restreamer doesn't have database access.
We intend to use this endpoint on the VST website backend to drive some automation around
"next point" etc.
An important point to note is that this OCR only works reliably on a high resolution BusCam,
not on the small buscam in the corner of the main stream. We assume this is available under
the channel name buscam (though this is of course configurable).
The OCR is very basic right now and only tries to read the first 4 digits, not the 1/10th mile digit
which is a different shape and moves in 8 animation frames instead of ticking over instantly.
The OCR is based on the following process:

Cut out a vertical slice of where the odometer digit might be, as it moves up and down
Find the region of the slice which has the most brightness, assume this is our digit
Normalize the digit by making it greyscale and adjusting the contrast
Compare it to a series of "prototype" digits. Comparison is based on the pixel error squared.
Whichever prototype is most similar to the digit is the winner, and we assign a score based on how close it was to the runner-up.
We average the scores for each digit in the image, and call that the frame's score
If the frame's score is above a threshold, we record a reading. Otherwise we record NULL ("could not determine a reading").

Future work:

Read the last digit
Read the in-between states of the last digit (eg. halfway between 1 and 2 should be read as 1.5)
Read the clock in addition to the odo
Read the other dials (such as speed) by looking at the angle of the green line

By way of example, here is a test frame:

We grab its odometer:

Within the odometer, we find each digit and normalize it:

Then we compare each one to the prototypes. Here is debug output for comparing digit 3:
Digit = 3 with score 0.07662805074830303
0: 0.6749983397240747
1: 0.49500557305278614
2: 0.7607713328448434
3: 0.899052645935728
4: 0.589575909300537
5: 0.7584262193861606
6: 0.7154477278085176
7: 0.5766948239415489
8: 0.7621688962241706
9: 0.822424595187425

We have picked the value 3 because it had the highest similarity (0.899), with 9 being the runner up (0.822) for a final score of 0.899 - 0.822 = 0.077. This is actually quite a low score! 3s and 9s are very similar in this font. We are saved by the other digits all being a more sure bet, which brings up our overall score:
Digit = 0 with score 0.12030949885125786
Digit = 1 with score 0.22004621713938277
Digit = 1 with score 0.2500588058898393
Digit = 3 with score 0.07662805074830303
test-frames/test-0113.25.png: 0113 with score 0.16676064315719574

Our threshold is currently 0.1, because an all-black frame scores a 0.7 because 1s aren't very different from all-black.
You can see why this is a crappy scoring system, but it works well enough for now.

This is a good implementation of the chosen solution. Where there is room for improvement I feel is in deciding whether a match is good or not.


Uncaught Invariant Violation: traverseParentPath(…): Cannot traverse from and to the same ID, ``

Would you please take a look at this: http://stackoverflow.com/questions/34914922/uncaught-invariant-violation-traverseparentpath-cannot-traverse-from-and ?
I'm facing an issue and I think one of these three libraries could be causing it: redux-form, material-ui and parse.

The invariant is not related to the Parse SDK, and there is not a single Parse method in the stack trace you mention. I'm going to close this task, as there is no identifiable issue with SDK code.

You're right, but if I remove the parameter from the object.save call everything works fine. Doesn't it mean anything?

What version of the SDK are you using? Is A+ compliance enabled on Parse Promise?
I can't really comment without more knowledge about how the object in question is being constructed and manipulated. I wish I could be of more help, but I'm no Redux expert. If the object already existed, and no parameters were passed to the save call, it'd just be a no-op and return an empty resolved Promise.

I suggest you replace the save() call with native Promises for debugging. Toggling whether it is resolved or rejected may help you find the bug.

Thanks for the interest in helping.
I'm using SDK v1.6.14.
The object is an existing ParseObject that was queried previously.
I already tried using native promises, but the result was the same.
If I keep the save parameters, but they didn't change compared to the previous values, the error doesn't happen. If I change any of the values, I get the error (and if re-submit the form is "clean" and I get no error).

I really appreciate you help, I'm keep trying to find out whats happening, I tried to contact the other libs collaborators to help me. I'll let you know if I ever find the error.

I am also facing this issue when i am trying to 'react-resizable-component' library. Can anybody help me out this.

@nishankkumar1994 were you able to resolve this issue for using react-resizable-component?

@nishankkumar1994 why not just create an issue on its own repo?


WIP: TSLint to ESLint migration

Description
For #134
Checklist

[x] I have read the contributing document.
[x] My code follows the code style of this project and yarn fix runs successfully.
[ ] I have updated the documentation where necessary.
[ ] New code is unit tested and all current tests pass when running yarn test .

Todos:

[ ] Configure and decide on new ESLint rules
[ ] Update any TSLint line ignores to new ESLint style
[ ] Remove TSLint

Screenshots

Alright, made a little progress and as per https://github.com/ifiokjr/remirror/issues/134#issuecomment-517936554 , I have began to remove individual lint scripts from nested package.json files in this commit (just for an example) https://github.com/ifiokjr/remirror/pull/139/commits/ffb259abd10c937faa9c6667e8107d283c3e81da.
Will hopefully have some time later in the day to sink into this.

@charlex
Thanks for the work on this. For the initial PR it might be easiest to create the eslint rules alongside the tslint rules. The eslint rules would check that the code is up to standard but wouldn't automatically fix things.
Once we're happy that the new eslint rules replicate or enhance the project it's then a case of

switching off tslint and turning on eslint exclusively
removing all tslint leftovers from the project

This would take place in a seperate PR.

@ifiokjr Smart! Yeah, I think this PR got a bit unwieldily.
Should we just start ESLint with the bare minimum rules that the project already conforms to?

Closing this in favor of https://github.com/ifiokjr/remirror/pull/140

You might want to check out https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin-tslint which allows you to continue using your TSLint rules inside of ESLint; it can make migration easier.

Nice suggestion @benjie! I had completely forgotten this was an option. The only gripe is the lack of auto-fix which might get annoying, so perhaps fixable rules should be migrated over but the rest can stay as they are.


Automatically publish artifacts to GitHub

After a successful Travis build, we should consider uploading necessary files to the release pages for Supernova.
Travis docs mention that we'll have to update the .travis.yml file. In addition, we'll need to use git to tag our releases - more info here.

I'd like to look into this some more - most of it will be new to me, so it'll be a great learning experience!


canutils: libcanutils: add GPL build barrier

Summary
Exclude libcanutils from build unless the license is set to
allow GPL code in the build.
NOTE
Depends on
https://github.com/apache/incubator-nuttx/pull/4352
Impact
LICENSE
Testing
Compiled

@gustavonihei  @xiaoxiang781216  can you please merge the commit

@jerpelea May I ask why libcanutils is identified as GPL2.0?
Checking the license header it indicates it's dual-licensed.
https://github.com/apache/incubator-nuttx-apps/blob/1c3d08a738cf395f99f211fad0b3a3ed2c19cc28/canutils/libcanutils/lib.c#L1
This it can be interpreted as either BSD-3-clause OR GPL2.0, I would prefer we see it's as BSD-3-clause since the license is more permissive.

in my opinion it can be threated both but since GPL v2 is more restrictive I think that it is better to handle it this way

Sure but let's say we treat it as GPL v2 and the code itself in incubator-nuttx-apps repo/project. Don't you get the problem we've to deal with copyleft?
I've added the code myself interpreting it as BSD3 so it's compatible with the incubator-nuttx-apps repo

In my opinion if it is not, compiled (due to the build barrier), or used in the final binary for the product, it can be safely treated as GPL
I think that you can consider that it does not influence your copylefts in any way since the code is isolated

Okay thanks for explanation, makes sense to interpret it that way.
Once last question would the following also work since it's dual licensed?
depends on NET_CAN && (ALLOW_GPL_COMPONENTS || ALLOW_BSD_COMPONENTS)

unfortunately if we do that the code will be included if the BSD flag is selected

@jerpelea but if we assume we are using libcanutils as GPL and the user want to use it, he/she need to enable GPL components that will make his final firmware GPL, but he doesn't want it as GPL because he is using it for a commercial product that cannot be GPL. If a library is dual license we can choose which license we want to use. I think in this case it is safe to use BSD instead of GPL.

Ah ok, I saw the issue: "SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)", I'm not sure if we can remove the "GPL-2.0-only" info. Probably this is a piece of code that we should move to apps_extra

when we will move the dual license components to a new git we can consider this option. In the current case it will be included in the main build.


fix: manual update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 12 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 46.408%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/entities/Place/migration.ts
0
12
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
298

Relevant Lines:
466

💛  - Coveralls


Translated Writing Markup with JSX Page

Added Hindi Translation for Writing Markup with JSX page.
:white_large_square: JSX: Putting markup into JavaScript @arshadkazmi42
:white_large_square: Converting HTML to JSX @arshadkazmi42
:white_large_square: The Rules of JSX @arshadkazmi42

@arshadkazmi42 I have updated the changes, let me know if there's something else.

@Anku5hk You have missed few of the comments. Can you work on those?

@Anku5hk You have missed few of the comments. Can you work on those?

Okay I have updated the changes.

@arshadkazmi42 I have updated the text, let me know if there's something else.


Implement configuration changes required by GDI spec

set default traces exporter to otlp
support SPLUNK_ACCESS_TOKEN in otlp
set default propagators to tracecontext,baggage
log a warning if service.name resource attribute is missing

MIGRATING.md should be changed as well

MIGRATING.md should be changed as well

I'll prepare a separate PR for documentation changes - it'll be merged just before the release. The current version is still using jaeger-thrift so the docs shouldn't say anything about otlp until we're ready to release.


[wip] feat: allow time unit selection

This is a WIP, leaving as draft so that the approach and UX can be validated. fixes #2768

Here's the suggested UI. Created a modal to keep it consistent with the Custom Range style, made it in a WebsiteChartSettings component to allow for further expansion of options. Used the centered approach to make it consistent with the Custom Range modal.
If that approach works, I can wrap this up.


Add final events from 2018

Description
https://jira.mesosphere.com/browse/DCOS_OSS-2903
https://jira.mesosphere.com/browse/DCOS_OSS-2976
https://jira.mesosphere.com/browse/DCOS_OSS-2806
Urgency

[ ] Blocker
[ ] High
[ x] Medium

Requirements

See the contribution guidelines.
Build content locally and test for formatting/links.

Not that this will make much sense to you right now ;)

@mattj-io Given these events are in the past, do you still want comments on the copy?

The copy is usually the submitted abstract. Comment if you like though !


add non-encrypted prv key in non-pem format(no -----begin header) check

Description:
Several apps pass RSA private key without header and footer (non-pem) format. Would like to add a check to include this

e.g., snowflake kafka connector

Checklist:

[x] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[x] Have you lint your code locally prior to submission?

too much testing / trial/ error going on with this one. Closing in favour of new PR with cleaner commits: https://github.com/zricethezav/gitleaks/pull/1043/files


[stable/external-dns] Support DigitalOcean (Fixes #10923).

/ok-to-test

@mattfarina Hi, can this PR be merged? Thanks

/ok-to-test
It seems the hook wasn't caught before.

/lgtm


fix pull request by correcting icon file name

Missnamed my icon file :)

New Repo with emulator and sort order

Hi! Are you ready to merge this? There are a few extra files in here that you probably don't want to go in... https://github.com/espruino/BangleApps/pull/596/files

Did you intend to add GentleNudge2?
There's _config.yml and apps/benWatch/code_3 (1).js
If you're not planning on adding anything to the README files I'd just delete them and remove the README reference from the apps.json
The apps/widviz/benWatch/benWatch-icon.js file contains require("../../GentleNudge/node_modules/heatshrink") - when it should just be 'heatshrink'

Gordon! I think I understand the process now! I'm going to develop off of my fork and I'll have a "real" app for you to merge here soon. Thank you so much for reviewing and guiding me to the right spots :)

Great - thanks! I look forward to it :)


get_transform_fxn signature

From #141, I was confused about the MEF section in process_beads_table and some of the confusion seemed to originate from the get_transform_fxn signature.
Relevant parts of original thread brought over from #141:
JS:
While I do think it's generally the case that beads should have the same number of peaks, I think it's an unnecessary assumption and possibly detrimental.

The user may not have put the known MEF values in that way. If this is a required assumption, I think it should be detected and an error should be raised if that assumption is violated. Would this get caught under the current implementation? Or would an underspecified known MEF values just get padded with zeros upon creation of the mef_values numpy array?

Looks like mef_values would not get padded, instead you appear to get a numpy object array where each element is a list. That may still work? I still think the more explicit dictionary data structure would be better there if an error is not warranted.

It's pretty easy to write this in a manner where each channel is independent. A {channel -> known MEF values} dictionary is intuitive and allows more general specification of known MEF values.
Some devil's advocate arguments for variable numbers of fluorophore concentrations:

it's not outside the realm of possibility that you could get beads with different numbers of fluorophore concentrations for different fluorophores. e.g. 8 MEF but 6 MECY. seems unlikely, though, and I'm not aware of a product which currently exists like this.
I could mix two different non-rainbow beads in the same sample, maybe to get FL1 and FL3 coverage, but the beads may have different numbers of peaks.

SMC:

All the MEF values from a single beads sample should have the same number of values, because a single sample has the same number of subpopulations.
It seems that you want to change the signature of get_transform_fxn, which does not belong here. You might want to open an issue for this. You might also want to reconsider this given my previous point.

JS:

Might consider promoting # Process MEF values to an emphasized comment.

I also had to re-read this section several times to understand it. Purpose of mef_values and mef_channels data structures isn't terribly clear from description or their names. Is mef_values referring to known MEF values? It's a list of lists that you convert to a numpy array? That seems dangerous if the specified known MEF values are not all of the same length (different beads have different numbers of peaks. just seems like an unnecessary assumption). Looks like this is supposed to be the input to mef.get_transform_fxn which expects a {channel -> known MEF} mapping. I'd almost prefer something more explicit like a dictionary or a list of numpy arrays rather than relying on indexing numpy columns? That would also more generally support different specifications of known MEF values.
Your comment refers to mef_channels which hasn't been defined yet. Very confusing way to start off the comment. Might explain that you first make mef_channels (and explain what that is).
What does if '{} MEF Values'.format(fl_channel) in beads_row: mean? A column exists with fl_channel (e.g. "FL1-H", "FL3", etc.) + "MEF Values" in the Beads table. When is this not true? If the instrument reads a fluorescence channel, but the user doesn't care about it for their analysis (e.g. our FL2?).
Is mef_channels a subset of fl_channels? Again, had to look at mef.get_transform_fxn documentation which apparently says it's channels that want MEF transformation functions. OK, that makes sense. If this really is just a subset of fl_channels, would help to mention that. When is this ever not fl_channels? Again, if the instrument measures a channel that the user doesn't care about? Something like a very simple "subset of fl_channels requesting MEF transformations" would help clarify that. I also still feel like it would be much more natural to have a {channel -> known MEF values} dictionary to capture all of this.
I'm still confused on what this is doing. ok, I think I got it?

This is now a bug. If the MEF values for two different channels for the same bead row do not match in number of elements, I get the following error:
Processing Beads table (4 entries)
==================================

Beads ID B1...
Loading file "OR20140627/Data.002"...
Performing gating...
Plotting density plot and histogram...
Calculating standard curve for channels FL1-H, FL3-H...
Traceback (most recent call last):
  File "C:\Users\John\Anaconda2\envs\FlowCalv1.0.0b1\lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "C:\Users\John\Anaconda2\envs\FlowCalv1.0.0b1\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "build\bdist.win-amd64\egg\FlowCal\excel_ui.py", line 830, in <module>
  File "build\bdist.win-amd64\egg\FlowCal\excel_ui.py", line 789, in run
  File "build\bdist.win-amd64\egg\FlowCal\excel_ui.py", line 333, in process_beads_table
  File "build\bdist.win-amd64\egg\FlowCal\mef.py", line 546, in get_transform_fxn
IndexError: tuple index out of range

The reason I do not specify the same number of MEF values for a given bead row is that I have different gain settings for different channels such that I can only resolve a subset of the peaks for one of the channels. I manually pruned the MEF Values entries for that channel and got this bug.
This bug seems to stem from the fact that you call mef_values = np.array(mef_values).copy() at the top of mef.get_transform_fxn(). mef_values is a list of lists containing the parsed MEF Values. When I tried to construct a numpy array from a list of lists where the inner set of lists were not of equal length, numpy gave me a 1D array of dtype=object (where each element is a list, instead of a 2D numpy array of numbers as originally intended here), which fails a few lines later when you try and call mef_values.shape[1].
This  may be specific to my current version of numpy? 1.10.1. While enforcing numpy requirements might fix this problem, I think a much better solution would be to redo the mef_values/mef_channels data structure.

There are two things here:
One, a complain about the impossibility of having a different number of MEF values on different channels. This is not a bug. We intentionally force these to be the same, because the beads that we have seen so far contain the same number of peaks in all channels. The clustering algorithm relies on this assumption, and clustering in N dimensions when the number of subpopulations in one axis is different than another doesn't make a lot of sense.
To address some of your "edge cases":

The user may not have put the known MEF values in that way

Then the user needs to read the documentation and use the package correctly.

If this is a required assumption, I think it should be detected and an error should be raised if that assumption is violated

A more explicit error message is not a bad idea.

it's not outside the realm of possibility that you could get beads with different numbers of fluorophore concentrations for different fluorophores. e.g. 8 MEF but 6 MECY. seems unlikely, though, and I'm not aware of a product which currently exists like this.

I have no idea how this would make sense if you look at it in a 2D scatter plot. I can think of a few convoluted ways in which this would be possible, but they are very complicated and would require extensive revisions of the clustering algorithm and the MEF algorithm in general. I'd rather not deal with this unless we confirm that such a product exists.

I could mix two different non-rainbow beads in the same sample, maybe to get FL1 and FL3 coverage, but the beads may have different numbers of peaks.

Or you could use beads properly, and run two separate samples. Even if you really wanted to do this, and even if beads in both channels had the same number of peaks, the clustering algorithm would break. Let's say that you're using beads with a green fluorophore (detected in FL1) and beads with a red fluorophore (FL3) and you mixed them in the same tube. If you assume no bleedthrough (best case scenario), then you would see that, in FL1, all the red beads would form their own group, probably with the same measured fluorescence as the blank peak of the green beads. Therefore, you would have a blank peak that has a much greater number of events than the other peaks. This would break the GMM clustering algorithm, because it is currently set up to find clusters of roughly the same size.
In summary, handling these edge cases requires way more than allowing different numbers of peak values. Since, to the best of my knowledge, there are no beads that require such behavior, and no scenario that can't be fixed by having the user use beads properly, this is not something that should be worked on. It may be a good idea, however, to have a more explicit error message when the user tries to enter a different number of MEF values into get_transform_fxn(). Feel free to open a new issue on this if you're interested.
The other issue is about mef_values being a dictionary, instead of a numpy array or a list of lists. Given that we don't want to support entering different number of MEF values on different channels (see above), the switch to a dictionary becomes more of a personal preference, in my opinion, and I am against changing a parameter for personal preference. Given the time passed since this issue's submission, I will assume that interest in this stylistic change has faded, and close. Feel free to open a more focused issue, but be aware that I will be against changing the datatype of a parameter if there is no clear advantage.


REACT_HOT_LOADER in production build

Hi, I'm seeing an issue where production code contains multiple instances of __REACT_HOT_LOADER__.register(_default, 'default', '/Users/username/…'); when running npm run dist ... even on a fresh project.
I don't have a lot of knowledge about webpack configurations, so I had trouble tracing the issue. I'm hoping someone here can help. Thanks.

I revisited this and tracked this issue to the process.env.NODE_ENV not being set to 'production' as noted here: https://github.com/gaearon/react-hot-loader/issues/357.
To correct this, I updated conf/webpack/Dist.js from
  get env() {     return 'dist';   }
to:
  get env() {     return 'production';   }


problem in importing sql updates

i cant figure out how to import sql updates.... when i am importing them mysql is throwing error (duplicate entry). Is it important to import sql upates? please help me regarding to this issue..

that's not a problem. use -f option while importing the mysql file.
for example
mysql -u userName -p -f -D dbName < script.sql