Unused path dependency patches don't emit warning or show up in lock file on update

Problem
While investigating #12419, a solution is to use the unused_patches field of the Resolve returned from resolve_ws.  It turns out this field wasn't being populated for path dependency patches. As a result, an unused patch doesn't emit a warning or show up in the lock file as an unused patch during cargo update
Steps
# Cargo.toml

[workspace]
members = ["serde", "serde_derive"]

[patch.crates-io]
serde = { path = "serde" }

# serde/Cargo.toml

[package]
name = "serde"
version = "1.0.0"

[dependencies]
serde_derive = { path = "../serde_derive" }

# serde_derive/Cargo.toml

[package]
name = "serde_derive"
version = "1.0.0"

Same test case in #12419, but running cargo update instead.
Current:
No warning and lock file below:
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 3

[[package]]
name = "serde"
version = "1.0.0"
dependencies = [
 "serde_derive",
]

[[package]]
name = "serde_derive"
version = "1.0.0"

Expectation:
The expectation is if a patch is unused, a warning would be emitted and would show up as a patch.unused section in the lock file
The following warning is emitted:
warning: Patch `serde v1.0.0 (/Users/alcolmenar/dev/3rd/test-patch/serde)` was not used in the crate graph.
Perhaps you misspelled the source URL being patched.
Possible URLs for `[patch.<URL>]`:
    /Users/alcolmenar/dev/3rd/test-patch/serde

Cargo file:
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 3

[[package]]
name = "serde"
version = "1.0.0"
dependencies = [
 "serde_derive",
]

[[package]]
name = "serde_derive"
version = "1.0.0"

[[patch.unused]]
name = "serde"
version = "1.0.0"

Possible Solution(s)
Haven't really looked into how to do it but I think the errant code is here:
https://github.com/rust-lang/cargo/blob/211fd7eac105f0960433a935ce17b8d787233692/src/cargo/core/resolver/resolve.rs#L142-L148
Notes
No response
Version
cargo 1.73.0-nightly (45782b6b8 2023-07-05)
release: 1.73.0-nightly
commit-hash: 45782b6b8afd1da042d45c2daeec9c0744f72cc7
commit-date: 2023-07-05
host: aarch64-apple-darwin
libgit2: 1.6.4 (sys:0.17.2 vendored)
libcurl: 7.79.1 (sys:0.4.63+curl-8.1.2 system ssl:(SecureTransport) LibreSSL/3.3.6)
ssl: OpenSSL 1.1.1u  30 May 2023
os: Mac OS 12.5.1 [64-bit]

Is this issue that all unused patches aren't detected or only with patches of path dependencies? The title and description mostly sound like all patches except in a place or two so its unclear if this is a more general problem.

It might just an issue with path dependency patches. I just tried git dependency patches:
diff --git a/Cargo.toml b/Cargo.toml
index 28b0284..60a77f9 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -5,4 +5,5 @@ members = ["serde", "serde_derive"]

 [patch.crates-io]
 serde = { path = "serde" }
+uuid = { git = 'https://github.com/uuid-rs/uuid.git' }

and cargo update gives:
    Updating git repository `https://github.com/uuid-rs/uuid.git`
warning: Patch `uuid v1.4.1 (https://github.com/uuid-rs/uuid.git#97b7f07b)` was not used in the crate graph.

I'll update the title

I've also made a slight change to the description,  It make it sound like this is a blocker for #12419.

if !self.graph.contains(&summary.package_id()) {

This could be the reason: PackageId of the patch dep and the dep to patch are the same. Not limited to path dependencies. In other words, the package of the “unused” patch is already in use in other place.
This should be recorded in Cargo.lock as it is really unused. However, I am not sure about the warning. What is the possible situation when this happens, and how could Cargo suggest fixing it? Haven't thought about it thoroughly but it seems that one needs to make several mistakes to go there.

Just note that if we decide to make this change, this could cause a churn in version control, as somebody will need to commit a new section of [[patch.unused]]. We could do it along with https://github.com/rust-lang/cargo/issues/12120, so that it won't cause too many churns.
Another approach is we can emit a warning without touching the lockfile at this time. Something like,
patch `foo 0.1.0 (/path/to/foo)` was not used because there is already a same package in the dependency graph.
This unused patch wasn't previously added to the lockfile, but will be in the future.

@rustbot label +S-needs-design -S-triage +A-patch +A-errors +A-lockfile

This could be the reason: PackageId of the patch dep and the dep to patch are the same. Not limited to path dependencies. In other words, the package of the “unused” patch is already in use in other place.

In the toy example, the patch dependency isn't patching anything. I may be wrong, but I think the reason why it shows up in the graph is because the patch dependency is a member of the workspace.

This should be recorded in Cargo.lock as it is really unused. However, I am not sure about the warning.

In this comment's example, I created a toy example of a known unused patch with a git dependency and it generated a warning because the resolver marked it as unused.

What is the possible situation when this happens

Good question. The cases where this might happen are probably limited actually: typos or thinking a package is used as a dependency but it isn't so the patch isn't applied. For some context, we fixed an issue where used patches were being cleaned up during cargo remove and in the PR we used the unused_patches field, but found in same cases this field isn't being populated correctly.

how could Cargo suggest fixing it?

Probably the easiest is to emit a warning that suggests to remove the patch manually from the toml. Or we can add a flag to cargo update providing users to explicitly say to remove it automatically.

why it shows up in the graph is because the patch dependency is a member of the workspace.

That's true IIRC. Cargo creates only one dependency graph per cargo invocation for a workspace. That's also why I called out this line of code as a culprit, and consider it has the same root cause as #12471:
if !self.graph.contains(&summary.package_id()) {

For https://github.com/rust-lang/cargo/issues/12464#issuecomment-1668696742 the example, they have different PackageId so the graph doesn't contain uuid and Cargo marks it as unused.
Feel like action items here would be:

Have a proper warning for this.
Adding this and #12471 unused patches to the lockfile.


[Ember] Intellisense dont work for this.[methodName]

From @atcq1 on March 25, 2016 13:11

VSCode Version:0.10.11
OS Version:ubuntu 14.04 x64

Intellisense\autocomplete not work to call methods and property through this.methodName () / this.propertyName.
Steps to Reproduce:

Create route:

import Ember from 'ember';

export default Ember.Route.extend({
    property1: 'text',
    model(params) {
        return {};
    },
    firstMethod()
    {
        //test1
    },
    secondMethod()
    {
        //test2
    },
    thirdMethod()
    {
        //Intellisense
        secondMethod(); //work
        this.secondMethod(); //do not work
        //Autocomplete
        property1; //work
        this.property1; //do not work
    }
});

2 Enter this.second or this.prop in thirdMethod(){}:
Copied from original issue: Microsoft/vscode#4671

I don't think that Salsa supports this pattern, moving to TypeScript for comment.

@sandersn you work now covers this correctly, right?

Or is this a duplicate of #8110?

Yes, this works in Salsa (as well as TypeScript) if, in settings.json, you set "typescript.tsdk" to a directory that contains the bits from typescript@next.


DWI Preprocess Not Outputting MNI Files

Hello,
I am running qsiprep (0.9.0beta1) through singularity with the following command:
singularity exec -B /DATA --nv -e /PATH/TO/qsiprep.img \
qsiprep /PATH/TO/BIDS \
/PATH/TO/DERIVATIVES \
participant \
-w /PATH/TO/DERIVATIVES \
--output-resolution 1 --hmc_model eddy \
--recon-spec mrtrix_singleshell_ss3t_noACT --fs-license-file /PATH/TO/license.txt \
--unringing_method mrdegibbs --force-spatial-normalization
Looking in my qsiprep output folder, I can easily find the MNI outputs for the anatomy preprocessing. However, the DWI preprocessing outputs are only in subject T1 space. Based on what I read at https://qsiprep.readthedocs.io/en/latest/preprocessing.html, it seems like it should be possible to output into MNI space as well, even if the "template" argument for --output-space is deprecated. This would be ideal, since for my tractography and tractometry analysis, I would like to start with CSD peaks from reconstruction in a standard space.
In the case that qsiprep cannot output these files directly, I see that in the qsiprep/subXXX/anat folder there are some xfm.hd5 files that I presume can be used to transform the DWI to MNI space (assuming the DWI was first registered to the T1). Do you know what kind of program would use a .hd5 for this purpose? I usually use FSL flirt which could take a .txt or .mat matrix to inform the transformation.
Thanks for the assistance,
Steven

Hi Steven,
Thanks for trying QSIPrep. The preprocessing pipeline does not write outputs to MNI space because the preprocessing registration only uses the T1w image. I'm going to update the commandline args and documentation to better reflect this #149.


Implement new Discogs authentication options

http://www.discogs.com/blog/api-update-discogs-auth
As OAuth is now no longer the only way of authentication, it needs to have its own module instead of being embedded into DiscogsClient

Discogs Auth support + OAuth cleanup will be in release 0.6.0


Fix bugs in demographics randomization code

Can you give some detail as to what bugs this should fix?

Yes.  The bug in question.
Original (pre-demographics randomization)
expected - gender (M:0, F:3)
reported - gender (M:1, F:2) - Error M should be 0, F should be 3
Original (post-demographics randomization, pre bug fix)
expected - gender (M:0, F:3)
Patient 1 was copied twice (and changed from F to M)
expected - gender (M:1, F:2) or (M:0, F:3)
reported - gender (M:2, F:1) - No error returned
Since the original file was copied twice, the validator was allowing the demographics to be altered twice (even though the copied patient should only be reported once)


Infinite loop without reverse (repeat:true)

I think volecity should have an loopAlternate option works exactly like css animation-direction.
Thisi is  a same issue metioned here, and the solution here works for me.
It's very useful with a step easing & loop animation like a loading spinner, walking animation etc.[example]

Can you guys do something about it! Really useful feature.

Needs thinking about and internal changes on code I don't want to touch yet - but I've done this before by running a forcefed animation, then reversing and looping the reverse ;-)

I actually made it work with tweene.

This seems like a pretty basic feature missing from Velocity -  would prefer not having more overheads with Tweene or GSAP in my Vue app

In v2 there is are options for loop, repeat and reverse.


Update Github API query

Currently the api query fetches issues with closed PRs only when hasPR is checked. We need to update the query so that it'll fetch:

All issues without PRs and closed PRs (when hasPR is false)
All issues with open PRs or draft PRs (when hasPR is true)

If you want to work on this, please comment below. If you need any help, just ping me, I can help you with this, thanks

Checked response data. It is fetching data for has_pull_request = true/false both.

Yes but what we want to know is whether it's a open pr or draft or close

@dotslashbit @sanketmn26 I was able to retrieve the PR state from the graphql query. Are you currently working on this? I May submit a PR here shortly.

@sanketmn26 @Sechorda
We are using graphql queries and in the docs I found this --> https://docs.github.com/en/graphql/reference/objects#pullrequest
It basically says that every Pr has a closed boolean, so intuitively what I'm thinking is,
lets keep the existing queries as is.
After fetching all the issues , we can run a query by providing the the Pr object and check its closed value if its closed then we can count it as the issue associated with the current Pr doesn't have any PRs.
Do you get it?  If you have any other idea, do let me know
We can take time on this, its not that big of a deal but this will make sure we are giving the best results possible to the user

@dotslashbit I think I know what you mean, but don't exactly follow. My brain went this way:
Include the PR state in the query, resulting in still only one query.
Filter issues base on PR state status with the logic that if it's open, draft, closed, or null (saw some null edge cases) then it returns the issue to the user.
const filteredIssues = issues.filter(issue => {       if (!params.hasPullRequests) {         return !issue.has_pull_requests;       } else {         return issue.has_pull_requests &&                 (issue.pr_status === 'OPEN' ||                  issue.pr_status === 'DRAFT' ||                  issue.pr_status === 'CLOSED' ||                  issue.pr_status === null);       }     });

@Sechorda I get it, but is the query working? If it's working then your way is a better solution

@dotslashbit the PR draft I submitted has a working query and filter based on the requested PR state logic. Double check me though!

@Sechorda sure will do that later, thank you so much

@dotslashbit woot

@dotslashbit @Sechorda  There was a bug in below statement.

We were not importing "nodes" data in query. So when "timelineItems.totalCount > 0 === true". It was throwing error because It could not find "totalCount.nodes"

Please have a look.

@sanketmn26 are you getting an error in the web app or in dev mode. Also have you updated your local setup

@dotslashbit I was getting error in dev mode in local setup. But not after adding nodes in query.

@sanketmn26 update your local code, cause I checked on my laptop and it's working perfectly fine


ESP-IDF LightDB Stream Example

NOTE:  The Zephyr LightDB Stream example uses the struct sensor_value from the Zephyr SDK. As this structure is not available outside of Zephyr, I have included its definition in the ESP-IDF example. Also, the Zephyr Example allows for obtaining temperature values directly from a temperature sensor if the platform supports it. However, the ESP-IDF example always generates fake temperature values.

@rashmivaidya72 The lightdb stream sample test failed on the esp32s3: https://github.com/golioth/golioth-firmware-sdk/actions/runs/8424019673/job/23067520531?pr=395

@rashmivaidya72 The lightdb stream sample test failed on the esp32s3: https://github.com/golioth/golioth-firmware-sdk/actions/runs/8424019673/job/23067520531?pr=395

@sam-golioth This seems to be a timing issue. The test expects 20.0, but the DUT has already published 20.0 and 20.5, causing the assertion to fail.
FAILED examples/esp_idf/lightdb_stream/pytest/test_sample.py::test_lightdb_stream - assert 20.5 == 20.0
If I remove the check for Golioth client connected, the test speeds up and the assertion succeeds.

We need to rebase this PR and fix the failing CI tests.

Seeing intermittent failures on the CI test: https://github.com/golioth/golioth-firmware-sdk/actions/runs/8546397122/job/23416975750?pr=395#step:7:244

@mniestroj @szczys This one is ready for a review


GeoParser is unable to parse geographic locations from solr index

Below is snippet of my solr index with all required geographic details.
{"id":"/dev/com/10news/www/42FD5EBC90236148BA72BEC73D622543F282BAF46F05AED2566EE6D7D7BF2A67","Geographic_LONGITUDE":"139.75309","Optional_LONGITUDE":"-87.76142","Optional_NAME":"Mount Carmel","Geographic_LATITUDE":"35.68536","Geographic_NAME":"Japan","Optional_LATITUDE":"38.41088","version":1530630356532723712},
After clicking geoparse button on memex home page , the page kind of stuck and returns the following logs in server
**_Total number of records to be geotagged 6
Generating khooshe tiles..
solr query - http://localhost:8983/solr/hw3/select?q=%3A&start=0&rows=500&wt=json
GenerateKhooshe Started..
http://localhost:8983/solr/PolarL_1/select?q=-points%3A"[]"&fl=points,id&wt=json&start=0&rows=50000
Traceback (most recent call last):
File "/Users/manasranjanmahanta/geoPolar/GeoParser/geoparser_app/solr.py", line 322, in QueryPointsIndex
if len(response['response']['docs']) == 0:
KeyError: 'response'
'response'
Retrieved 0 points in 0.0258848667145 seconds
Tiles created for 0 Points. Total time 0.0259318351746 seconds
{"responseHeader":{"status":0,"QTime":40}}
[04/Apr/2016 00:03:37] "GET /return_points_khooshe/http://localhost:8983/solr/hw3/PolarL HTTP/1.1" 400 58_**
Can you please tell where the error lies ?

This error is actually not causing any trouble as it comes while khooshe
generation. Which must be because there is nothing as of now to generate
points. I just now committed a change to remove these logs to avoid
confusion.
Focus on "query_crawled_index" API in logs. We can help you if you share
your full server console logs through pastebin preferably.
Also you said your page is stuck mostly your geoparsing is still running.
Can you see hits on you tika server logs?
Firstly I would recommend to check your setup. i.e. Step 5 in installation
5.MAKE SURE YOU ARE ABLE TO EXTRACT LOCATIONS FROM TIKA SERVER
curl -T /path/to/polar.geot -H "Content-Disposition: attachment;
filename=polar.geot" http://localhost:8001/rmeta
You can obtain file here
https://raw.githubusercontent.com/chrismattmann/geotopicparser-utils/master/geotopics/polar.geot
Output should be this
[
{
"Content-Type":"application/geotopic",
"Geographic_LATITUDE":"39.76",
"Geographic_LONGITUDE":"-98.5",
"Geographic_NAME":"United States",
"Optional_LATITUDE1":"27.33931",
"Optional_LONGITUDE1":"-108.60288",
"Optional_NAME1":"China",
"X-Parsed-By":[
"org.apache.tika.parser.DefaultParser",
"org.apache.tika.parser.geo.topic.GeoParser"
],
"X-TIKA:parse_time_millis":"1634",
"resourceName":"polar.geot"
}
]
--
Madhav Sharan
On Sun, Apr 3, 2016 at 7:46 PM, Manas007<EMAIL_ADDRESS>wrote:

Below is snippet of my solr index with all required geographic details.
{"id":"/dev/com/10news/www/42FD5EBC90236148BA72BEC73D622543F282BAF46F05AED2566EE6D7D7BF2A67","Geographic_LONGITUDE":"139.75309","Optional_LONGITUDE":"-87.76142","Optional_NAME":"Mount
Carmel","Geographic_LATITUDE":"35.68536","Geographic_NAME":"Japan","Optional_LATITUDE":"38.41088","
version":1530630356532723712},
After clicking geoparse button on memex home page , the page kind of stuck
and returns the following logs in server

_Total number of records to be geotagged 6 Generating khooshe tiles..
solr query - http://localhost:8983/solr/hw3/select?q=
http://localhost:8983/solr/hw3/select?q=%3A*&start=0&rows=500&wt=json
GenerateKhooshe Started..
http://localhost:8983/solr/PolarL_1/select?q=-points%3A"[]"&fl=points,id&wt=json&start=0&rows=50000
Traceback (most recent call last):
File "/Users/manasranjanmahanta/geoPolar/GeoParser/geoparser_app/solr.py",
line 322, in QueryPointsIndex
if len(response['response']['docs']) == 0:
KeyError: 'response'
'response'
Retrieved 0 points in 0.0258848667145 seconds
Tiles created for 0 Points. Total time 0.0259318351746 seconds
{"responseHeader":{"status":0,"QTime":40}}
[04/Apr/2016 00:03:37] "GET /return_points_khooshe/
http://localhost:8983/solr/hw3/PolarL HTTP/1.1" 400 58_**
Can you please tell where the error lies ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MBoustani_GeoParser_issues_66&d=CwMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=DhBa2eLkbd4gAFB01lkNgg&m=CLqzjljfdsAf9eonzaWruRA0W4pqwTxHmA764ekRZzQ&s=_ozTEwML0U-QTgwOwWc9kb-hz3U4FBgMmLt_l3Xtg6c&e=

I have attached the details of information you might need .I am able to index the required files with geographic measures but 'memex' is not able to locate points . Can you please tell what i should give input in domain name  & url ?? I have attached screenshot of my details . If there is any wrong in inputs you can please point out ?
ServerLogs.pdf
ServerIndex.pdf

Sorry for the damaged file . I have attached the correct ones
ServerIndex.docx
ServerLogs.docx

I can't open any of your files. Can you try pastebin.com
Before that please share results of step 5 in installation.
curl -T /path/to/polar.geot -H "Content-Disposition: attachment; filename=polar.geot" http://localhost:8001/rmeta

@Manas007 Is your issue resolved?

Yes, it is resolved .   I was not running two solr servers which are required for Memex GeoParser , got that understanding from previous posted discussions . Memex is up and running . Thanks for your immediate response . It was really helpful .


fixes and cleanups

fix post_init (renamed from _post_init)
fix generation usage (vLLM API changed)
deps: bump vllm to >=0.4.3
remove api_server.py (part of vLLM)
fix logging configuration (vllm_tgis_adapter messages were not being printed due to logging configuration)

@dtrifiro can we merge this now? 0.4.3 is released


Broken dependency: ModernGL.ext.obj

It is impossible to install ModernGL.ext.obj. In a virtualenv virtual environment on Python 3.7.0, pip is unable to fund the extension for loading obj files:
pip install ModernGL.ext.obj==1.0.0

ERROR: Could not find a version that satisfies the requirement ModernGL.ext.obj==1.0.0 (from versions: none)
ERROR: No matching distribution found for ModernGL.ext.obj==1.0.0

The same happens in a virtualenv environment with Python 3.8.10.

Solution: ModernGL.ext.obj has been renamed to objloader, put objloader==0.2.0 in the requirements.


Fix ActiveJob check

I was seeing a lot of this in my sidekiq logs:
NameError: uninitialized constant ActiveJob::Enqueuing

In a Rails, ActiveJob is defined even if ActiveJob::Enqueuing is not. ActiveJob::Enqueuing is only defined if you actually have a class that subclasses ActiveJob::Base. This just makes the defined? check more explicit.

@sixfeetover could you please rebase this commit. That way I can merge it and include it on a release.

Sure, all set.


Finish by 13/10/2024

Finish the following by that date:

Add start time to quotes (done)
Be able to convert quote to invoice
Add remove product (chnages picking status to removed) button (done)
Login page with just name for now (look into this)
Fix sizing of app for smaller devices (phones) (done)
Add/remove product for database (need to change how product is stored)
Product Details on settings page
redesign of useQuote into multiple files reducing unnecessary calls (BIG) (done)

did all except for Add/remove product for database (need to change how product is stored) and Login page with just name for now (look into this). Since these are not my priority right now and are for closer to production stage.


Netskope parser links give a 404 error

The links for the Netskope parser and function code all return a 404 error and it appears the code has been removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d6b717dc-2897-f89c-5d96-d517a0965286
Version Independent ID: 0827b9a2-1b47-f517-a9c5-2076e57f581e
Content: Find your Microsoft Sentinel data connector
Content Source: articles/sentinel/data-connectors-reference.md
Service: microsoft-sentinel
Sub-service: microsoft-sentinel
GitHub Login: @batamig
Microsoft Alias: bagol

Looks like this got fixed a while ago so #please-close


tickets/MSDKI-2-remove-dependency-on-main-queue-for-api-callbacks

@mondok Please review when you get a chance. This is one level up from https://github.com/forcedotcom/DeskApiClient-ObjC/pull/1

Added two comments here.  Other than that, looks good :+1:


only once appear

how to make tap target only once appear?

You need to handle this yourself. Its outside of the scope of this library. Setting a simple boolean in shared preferences or something is an easy way to do it.


Disable Wayland access

In my testing, PySide6 doesn't display window chrome if the wayland socket is open. Ultimately, we're going to want to make these permissions user-configurable; but for now, a set of defaults that work for the demo apps seems preferable.
This also re-orders the build so that bootstrap and resources (which are less likely to change) occur earlier, so they (in theory) should result in faster builds due to not spoiling the build cache.
PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Testing on debian 11 with system python 3.9, I noticed that pip was still installing PySide6==6.2.4. However, this was resolved if I upgraded pip before the install.
Do you want to add a statement to upgrade pip?

That's odd - the version of pip should be installed at the end of the build. I thought ensurepip always resulted in the most-recent pip... but if it doesn't, then yeah - I guess we should update pip before performing package installs.

(I'll push an update shortly)

For posterity....(I added -vv for my debugging):
[21:23:20] ========================================================================                                                                                subprocess.py:637
           Building module app_packages in /home/user/github/beeware/briefcase/tmp/pyside6test/linux/flatpak/pyside6test/.flatpak-builder/build/app_packages-1     subprocess.py:637
           ========================================================================                                                                                subprocess.py:637
           Running: mkdir -p /app/briefcase/app_packages                                                                                subprocess.py:637
           Running: /app/bin/python3 -m pip install -vv --no-cache-dir -r requirements.txt --target /app/briefcase/app_packages                                    subprocess.py:637
           Using pip 20.2.3 from /app/lib/python3.9/site-packages/pip (python 3.9)                                                                                subprocess.py:637

I spent way too long looking at this...
When you start the flatpak with Qt debugging enabled, you find this error:
$ flatpak run --env=QT_DEBUG_PLUGINS=1 com.example.pysidetest
.
.
.
qt.core.plugin.factoryloader: Got keys from plugin meta data QList("gnome", "gtk3", "qgnomeplatform")
qt.core.plugin.factoryloader: checking directory path "/app/briefcase/app_packages/PySide6/Qt/plugins/wayland-decoration-client" ...
qt.core.plugin.factoryloader: looking at "/app/briefcase/app_packages/PySide6/Qt/plugins/wayland-decoration-client/libbradient.so"
qt.core.plugin.loader: Found metadata in lib /app/briefcase/app_packages/PySide6/Qt/plugins/wayland-decoration-client/libbradient.so, metadata=
{
    "IID": "org.qt-project.Qt.WaylandClient.QWaylandDecorationFactoryInterface.5.4",
    "MetaData": {
        "Keys": [
            "bradient"
        ]
    },
    "archlevel": 1,
    "className": "QWaylandBradientDecorationPlugin",
    "debug": false,
    "version": 394240
}

qt.core.plugin.factoryloader: Got keys from plugin meta data QList("bradient")
qt.core.plugin.factoryloader: checking directory path "/app/bin/wayland-decoration-client" ...
qt.core.library: "/usr/share/runtime/lib/plugins/QGnomePlatform-decoration/wayland-decoration-client/libqgnomeplatformdecoration.so" cannot load: Cannot load library /usr/share/runtime/lib/plugins/QGnomePlatform-decoration/wayland-decoration-client/libqgnomeplatformdecoration.so: (/usr/share/runtime/lib/plugins/QGnomePlatform/lib/libadwaitaqt6.so.1: undefined symbol: qt_resourceFeatureZstd, version Qt_6)
qt.core.plugin.loader: QLibraryPrivate::loadPlugin failed on "/usr/share/runtime/lib/plugins/QGnomePlatform-decoration/wayland-decoration-client/libqgnomeplatformdecoration.so" : "Cannot load library /usr/share/runtime/lib/plugins/QGnomePlatform-decoration/wayland-decoration-client/libqgnomeplatformdecoration.so: (/usr/share/runtime/lib/plugins/QGnomePlatform/lib/libadwaitaqt6.so.1: undefined symbol: qt_resourceFeatureZstd, version Qt_6)"
Could not create decoration from factory! Running with no decorations.

From what I've gathered about qt_resourceFeatureZstd, this may imply a fundamental difference in expectations about how PySide6 is compiling Qt and how QGnomePlatform-decoration is expecting things to be compiled. It makes me wonder if instead of using the PySide6 wheel, we set things up such that PySide6 uses the Qt available in the flatpak kde platform, perhaps this issue would be avoided. However, I also feel quite a bit in over my head.
Anyway, as for avoiding Wayland and forcing X11....what if instead of letting Qt try to use Wayland, fail, and fallback to X11, we just tell Qt to use X11 from the beginning. If I add - --env=QT_QPA_PLATFORM=xcb to finish-args (and remove the socket for Wayland altogether), this achieves effectively the same outcome but in a bit more direct way I think.
Thoughts?

Thoughts?

I got nothing :-)
My original hope was that Flatpak was going to be a more reliable cross-platform single binary solution than AppImage, but it's clearly... not. Or, if it is, it requires a lot more platform expertise that they're going to great efforts to not document.
This is essentially why I've been working on the deb backend recently - I get the very distinct impression that the "single binary download" goal is near unattainable on Linux - or, at least, it comes with so many caveats that it's not really something we can recommend for general consumption.
So - my inclination is that we either merge this, as is, knowing that it's very imperfect, but marginally better than before; or we close it, document the limitations of the flatpak backend, and focus on getting deb/rpm/pacman backends working so we can look at adopting "native platform packaging" as the default for Linux.
Thoughts? :-)

my inclination is that we either merge this, as is

That's fair; I don't think either of these solutions are "great" by any means; so, I'm fine with merging this and disallowing access to Wayland by default given these issues with PySide. Ive also confirmed that Wayland can easily be re-enabled by end-users with flatpak run --socket=wayland ... or using Flatseal.
My primary takeaway from this exercise is packaging PySide in to a Flatpak is a largely unexplored area.


standard_init_linux.go:228: exec user process caused: exec format error

Bug Report

What did you do?
I installed olm on linux/s390x and connected to a catalog of operators.
I then attempted to install an operator.  This resulted in an InstallPlan resource being created and a Job resource being created in the OLM namespace.
The job failed, and looking at the corresponding pod, I could see it failed to run an initContainer called util
kubectl logs 648e77c9a7adc015c096cf0e2667326e167263a93266a3c6f52b4a62adlgnf2 util -n olm
standard_init_linux.go:228: exec user process caused: exec format error

Googling for this error suggests that the image is for the wrong architecture, and this is where Im confused as to how this is happening.  From the pod yaml, this is the image its trying to retrieve:
  initContainers:
  - command:
    - /bin/cp
    - -Rv
    - /bin/cpb
    - /util/cpb
    image: quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
    imagePullPolicy: IfNotPresent
    name: util

This appears to be exactly the same image, as is being run for the olm operator pod, which is running successfully.
  containers:
  - args:
    - --namespace
    - $(OPERATOR_NAMESPACE)
    - --writeStatusName
    - ""
    command:
    - /bin/olm
    env:
    - name: OPERATOR_NAMESPACE
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.namespace
    - name: OPERATOR_NAME
      value: olm-operator
    image: quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
    imagePullPolicy: IfNotPresent

kubectl get pods -n olm
NAME                                                              READY   STATUS       RESTARTS   AGE
648e77c9a7adc015c096cf0e2667326e167263a93266a3c6f52b4a62adlgnf2   0/1     Init:Error   0          2d1h
648e77c9a7adc015c096cf0e2667326e167263a93266a3c6f52b4a62admm8n6   0/1     Init:Error   0          2d1h
catalog-operator-8d9d97478-8v5mx                                  1/1     Running      0          6d21h
ibm-operator-catalog-x9gln                                        1/1     Running      0          2d2h
olm-operator-64b58958bb-pprtx                                     1/1     Running      0          21h
packageserver-545b4f5db8-nf42n                                    1/1     Running      0          6d23h
packageserver-545b4f5db8-pkp9h                                    1/1     Running      0          6d21h

So Im confused how an image can be running successfully in one container and failing when used in another container, unless that image really does have a binary in it for the wrong architecture?
What did you expect to see?
The job to execute to completion
What did you see instead? Under which circumstances?
The pod for the job failed at the first initContainer
Environment

operator-lifecycle-manager version:

sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.0", GitCommit:"ab69524f795c42094a6630298ff53f3c3ebab7f4", GitTreeState:"clean", BuildDate:"2021-12-07T18:16:20Z", GoVersion:"go1.17.3", Compiler:"gc", Platform:"linux/s390x"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.2", GitCommit:"9d142434e3af351a628bffee3939e64c681afa4d", GitTreeState:"clean", BuildDate:"2022-01-19T17:29:16Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/s390x"}

Kubernetes cluster kind:
Vanilla cluster with only 1 node (I had to add tolerations to various pods to get them to run on the control plane node)

Possible Solution

Additional context
Add any other context about the problem here.

In order to support different architectures in our release builds, OLM is fed information from the environment when choosing which image to use in the unpacker pod, something seems to be going wrong here. Could you please share:

Which version of OLM you installed.
Where you got the OLM manifests.
The entire output of the OLM Deployment yaml.

Hello,
I installed OLM via the operator-sdk, using the following set of commands
apt-get install operator-sdk
export ARCH=$(case $(uname -m) in x86_64) echo -n amd64 ;; aarch64) echo -n arm64 ;; *) echo -n $(uname -m) ;; esac)
export OS=$(uname | awk '{print tolower($0)}')
export OPERATOR_SDK_DL_URL=https://github.com/operator-framework/operator-sdk/releases/download/v1.23.0
curl -LO ${OPERATOR_SDK_DL_URL}/operator-sdk_${OS}_${ARCH}
gpg --keyserver keyserver.ubuntu.com --recv-keys 052996E2A20B5C7E
curl -LO ${OPERATOR_SDK_DL_URL}/checksums.txt
curl -LO ${OPERATOR_SDK_DL_URL}/checksums.txt.asc
gpg -u "Operator SDK (release<EMAIL_ADDRESS>--verify checksums.txt.asc
grep operator-sdk_${OS}_${ARCH} checksums.txt | sha256sum -c -
chmod +x operator-sdk_${OS}_${ARCH} && sudo mv operator-sdk_${OS}_${ARCH} /usr/local/bin/operator-sdk
operator-sdk
operator-sdk olm -h
operator-sdk olm install

The operator-sdk version is operator-sdk version: "v1.23.0", commit: "1eaeb5adb56be05fe8cc6dd70517e441696846a4", kubernetes version: "1.24.2", go version: "go1.18.5", GOOS: "linux", GOARCH: "s390x" and from the sha of the operator-framework/olm image, I think its v0.22
The full deployment yaml is
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "2"
  creationTimestamp: "2022-09-08T12:50:25Z"
  generation: 2
  labels:
    app: olm-operator
  name: olm-operator
  namespace: olm
  resourceVersion: "23091916"
  uid: 70eff54d-6b69-47ca-bbef-8b6886972605
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: olm-operator
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: olm-operator
    spec:
      containers:
      - args:
        - --namespace
        - $(OPERATOR_NAMESPACE)
        - --writeStatusName
        - ""
        command:
        - /bin/olm
        env:
        - name: OPERATOR_NAMESPACE
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
        - name: OPERATOR_NAME
          value: olm-operator
        image: quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
        imagePullPolicy: IfNotPresent
        livenessProbe:
          failureThreshold: 3
          httpGet:
            path: /healthz
            port: 8080
            scheme: HTTP
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 1
        name: olm-operator
        ports:
        - containerPort: 8080
          name: metrics
          protocol: TCP
        readinessProbe:
          failureThreshold: 3
          httpGet:
            path: /healthz
            port: 8080
            scheme: HTTP
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 1
        resources:
          requests:
            cpu: 10m
            memory: 160Mi
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: FallbackToLogsOnError
      dnsPolicy: ClusterFirst
      nodeSelector:
        kubernetes.io/os: linux
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext:
        runAsNonRoot: true
        seccompProfile:
          type: RuntimeDefault
      serviceAccount: olm-operator-serviceaccount
      serviceAccountName: olm-operator-serviceaccount
      terminationGracePeriodSeconds: 30
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/master
        operator: Exists
status:
  availableReplicas: 1
  conditions:
  - lastTransitionTime: "2022-09-08T12:50:25Z"
    lastUpdateTime: "2022-09-08T12:57:57Z"
    message: ReplicaSet "olm-operator-64b58958bb" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  - lastTransitionTime: "2022-09-14T15:39:12Z"
    lastUpdateTime: "2022-09-14T15:39:12Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  observedGeneration: 2
  readyReplicas: 1
  replicas: 1
  updatedReplicas: 1

I did have to edit the yaml to add a toleration to run the deployment on my control plane node.

Incase it helps with debug, I tried an experiment directly with the image using docker on the linux/s390x system
root@1c9f20cc8943:~# docker pull quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b: Pulling from operator-framework/olm
Digest: sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
Status: Image is up to date for quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b

Run the default entrypoint which does something
root@1c9f20cc8943:~# docker run quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
time="2022-09-20T10:30:42Z" level=info msg="log level info"
{"level":"error","ts":1663669842.7247128,"logger":"controller-runtime.client.config","msg":"unable to get kubeconfig","error":"invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable","errorCauses":[{"error":"no configuration has been provided, try setting KUBERNETES_MASTER environment variable"}],"stacktrace":"sigs.k8s.io/controller-runtime/pkg/client/config.GetConfigOrDie\n\t/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/sigs.k8s.io/controller-runtime/pkg/client/config/config.go:153\nmain.Manager\n\t/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/cmd/olm/manager.go:50\nmain.main\n\t/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/cmd/olm/main.go:135\nruntime.main\n\t/opt/hostedtoolcache/go/1.18.5/x64/src/runtime/proc.go:250"}

now run the /bin/cp command as the entrypoint, which fails
root@1c9f20cc8943:~# docker run --entrypoint /bin/cp  quay.io/operator-framework/olm@sha256:2b4fee73c05069d9d2c537c7d3072241097914748abfb938b5b08c969b2f544b
standard_init_linux.go:228: exec user process caused: exec format error

I also tried deliberately pulling the s390x image down to an amd64 system and reran the same commands.  In this case /bin/cp executed, so my guess is the s390x image is being built from an amd64 base layer.
[root@oc3 millwood]# docker run quay.io/operator-framework/olm@sha256:14afcf5c38f7055cb5a45a053da10791469e58de264bc449bef24f54b8bb6be2
WARNING: The requested image's platform (linux/s390x) does not match the detected host platform (linux/amd64) and no specific platform was requested
exec /bin/olm: exec format error

[root@oc3 millwood]# docker run --entrypoint /bin/cp quay.io/operator-framework/olm@sha256:14afcf5c38f7055cb5a45a053da10791469e58de264bc449bef24f54b8bb6be2
WARNING: The requested image's platform (linux/s390x) does not match the detected host platform (linux/amd64) and no specific platform was requested
BusyBox v1.34.1 (2022-04-13 00:26:55 UTC) multi-call binary.

Usage: cp [-arPLHpfinlsTu] SOURCE DEST
or: cp [-arPLHpfinlsu] SOURCE... { -t DIRECTORY | DIRECTORY }


Add robots.txt and exclude public lists from it

Currently's there's no robots.txt at all; we should have one to make it easy to update.
Secondarily, it should exclude public lists for now as that isn't content we control.

Done.


Multi iterators

Introduce multi-iterators in for.
A single for can now iterates over more than one collection at once. An iterator is used for each collection and the iteration is finished once the shortest iterator is finished.
for i in [10, 20, 30], j in [1..10] do print i+j # outputs 11 22 33

As expected by POLA, multi-iterators are also naturally usable on maps and comprehension arrays
var m = new HashMap[Int,String]
m[1] = "one"
m[2] = "two"
for k, v in m, i in [1..10] do print "{k}:{v}:{i}"
# outputs 1:one:1 2:two:2

var a = [for i in [10, 20, 30], j in [1..10] do i + j]
print a # outputs [11, 22, 33]

Close #1735

Cool! +1

This is great, :shipit: and +1 !


Update star.user.js

What these changes are supposed to do 🤔. And, I think, changes will cause a syntax error

Hi
On Thu 9 Jan, 2020, 7:49 PM Muhammad Wasif<EMAIL_ADDRESS>wrote:

What these changes are supposed to do 🤔. And, I think, changes will
cause a syntax error
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/star-me/pull/25?email_source=notifications&email_token=AOGZGD6EAZ4ASM7FU2F4WZDQ44W6RA5CNFSM4KEYJS42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIQOL3Y#issuecomment-572581359,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOGZGDYJGVKWFT54BUH6EQ3Q44W6RANCNFSM4KEYJS4Q
.


Default to --cap-lints=warn

It took me a long time to figure out why we need to or should do this. Thanks @Nemo157 and @Nilstrieb for telling me to keep looking.
What confused me is that the backtrace crate is actually turned into a module inside std, and the sysroot depends on std via path dependency, so we have no lint capping by default when we build backtrace.
I think lint capping is a prudent thing to do here to make things smoother in the future, even though I'm also going to try to fix the sources of warnings that come out of cargo miri setup.

Sounds good! Unfortunately as_encoded_bytes doesn't build on older nightlies...
Also this seems worth documenting somewhere, it might cause some unexpected interactions.

Sounds good! Unfortunately as_encoded_bytes doesn't build on older nightlies...

Why are we supporting older nightlies? as_encoded_bytes was stabilized in 1.74, which is now the previous stable release. I'll admit I didn't check the CI setup for this repo, but I assumed that a stabilized API was old enough for a nightly-only tool.

Fair question. In xargo times I always made sure we supported older nightlies as well since not everyone always tracks the very latest nightly, and I carried that over to this library. Maybe supporting one year old nightlies is a bit too much, though I would like to support a few months worth of nightlies.


BFSDFS.cpp

Breadth First Search & Depth First Search

https://user-images.githubusercontent.com/43691873/135965000-a3019b12-c089-4a61-bae3-81f915ec39a5.png
Pls read the readme file again. Your PR will be excluded by system. Pls submit genuine PR.


The decoder is unable to support the Long Address 32-bit ISO Long packets

When I utilize the coresight-decoder to decode the trace data produced by ETMv4 on Juno R2, I find that the decoder can't identify the Long Address 32-bit ISO Long packets with the header 0b10011010.

In addition, the decoder is unable to update the three address registers when decoding the address-related packets.

Thanks for trying out. We tested the tracer and the decoder with ARM64 mainboards listed in the AFL++ CoreSight mode README:
https://github.com/AFLplusplus/AFLplusplus/blob/stable/coresight_mode/README.md
They are not tested under 32-bit address environments yet.
We are always open to any PRs. Please submit a PR to support your desired environment.

In 64-bit address environments, there are some other address-packets such as Exact Match Address, Long Address 64-bit IS1 Long. However, the decoder is unable to recognize these packets. Moreover, ETMv4 utilizes three registers to store the three latest addresses. When the new address-packet is generated, it need to update the registers. However, it seems that this decoder does not support it.

Yes, there are other packets in the ETM specification for 64-bit environments, but CoreSight in our primary experimental environment (Marvell ThunderX2) did not output such packets. This is probably because the CoreSight hardware implementation has not caught up. So we did not implement IS1 Long or anything else that we did not need. If you want a complete decoder, use https://github.com/Linaro/OpenCSD.


Feature request: Directly extract license info for dotnet/nuget

With newer .NET installations, I've been having a lot of trouble getting LF to properly restore/extract the packages.
I have found another tool, https://github.com/tomchavakis/nuget-license, that directly reads the information from the equivalent of the lockfiles and yielded very fast and thorough results.
It would be amazing if either that tool could be integrated or LF could perform the same approach to extract the license info.

#903 might relate to this, I'll test it as soon as I can


feat: added support for v23

[x] wait for official v23 docker node image
[x] prebuilds shared metrics
[x] prebuilds autoprofiler
[x] add tekton 23 pipeline
[ ] update public documentation https://github.ibm.com/instana/docs/pull/11240
[x] compare with the Node v22 release

Pls merge as

feat: added v23 support


TCPRouteRule and BackendRef

What happened:
Implementing a GW Api implementation, we're focusing on TCPRoute. I'm puzzled by the structures used in v1alpha2 for TCPRoute.
I see that TCPRouteSpec contains a slice of TCPRouteRule like this: Rules []TCPRouteRule. But a TCPRouteRule itself is simply a slice of BackendRef like this: BackendRefs []BackendRef. Comments in code don't reveal the reason for this structure. Finally, through Rules and BackendRefs, we're manipulating a slice of slice of BackendRef but for apparent reason.
What you expected to happen:
As there's no obvious reason for using of slice of slice of BackendRef, why not simply a slice of BackendRef ? This structure implies the two following examples should be different.But how?
rules:
    - backendRefs:
        - group: ''
          kind: Service
          name: my-foo-service
          port: 6000
          weight: 1
        - group: ''
          kind: Service
          name: my-foo-service
          port: 8000
          weight: 1

and
rules:
    - backendRefs:
        - group: ''
          kind: Service
          name: my-foo-service
          port: 6000
          weight: 1
    - backendRefs :
        - group: ''
          kind: Service
          name: my-foo-service
          port: 8000
          weight: 1

How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

If my memory serves: the reason we're in this state is that we wanted to leave the option open for matching rules in the future, similar to what you see with HTTPRoute.Spec.Rules currently. Despite not having those rules now, it is simpler to add them horizontally at a later time as needed given this structure (which can be made backwards compatible) than to have to vertically add them later (which could not be made backwards compatible). GEP-735 is one of the few GEPs that has explored options in this area, and in fact for a brief period we had an implementation of this but decided to pull back on it (leading reason being a lack of "champion" with a use case to drive it forward) if that helps to provide some more context.
Given all that context I wanted to mention that in general we could use more champions for L4 related use cases and features, if you're interested in helping to provide new designs and redesigns of our L4 APIs like TCPRoute based on your own use cases (which by the sound of it are one of your 1st class use cases) we would welcome that in the form of GEPs, discussions, issues, and conversations in our weekly meetings.

Thanks @shaneutt for clear explanation, We'll keep in mind we can get involved for that matter.


control and activity black list

hi boy:
how can i config the control and activity black list ? as you know, if some buttons are functional buttons, such as back, or logout button. i don't want to click it in  a traveler job, how can i add those button in the black list?

Hi,
This is a good feature and worth adding.
It can be done by maintaining a view id list.
Thanks.


docs: update spec.yaml to support Frames & validateMessage

Motivation
Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.
This PR updates the openAPI spec to support Frames.
Helpful UI for viewing spec: https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/standard-crypto/farcaster-js/develop/packages/farcaster-js-hub-rest/src/openapi/spec.yaml
Change Summary
Updates the openAPI spec with the following changes:

Add the Frames types (FrameActionBody object & Message Type MESSAGE_TYPE_FRAME_ACTION)
Add the /validateMessage endpoint & types to support it
Changes some message body types to add type property
Fixes /submitMessage request body

Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] PR title adheres to the conventional commits standard
[ ] PR has a changeset
[ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
[x] PR includes documentation if necessary.
[x] All commits have been signed

Additional Context
If this is a relatively large or complex change, provide more details here that will help reviewers

PR-Codex overview
This PR focuses on updating the documentation links in the spec.yaml file of the Hub Node.js package.
Detailed summary

Updated the Farcaster docs link from https://docs.farcaster.xyz/reference/hubble/httpapi/httpapi to https://www.thehubble.xyz/docs/httpapi/httpapi.html
Updated the content type of the request body for /v1/validateMessage from application/json to application/octet-stream
Added a new endpoint /v1/validateMessage to validate a signed protobuf-serialized message with the Hub
Added new schemas MessageDataFrameAction and FrameActionBody for Farcaster Frame actions
Made various changes to existing schemas, including adding the type property and updating required properties

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

cc @sanjayprabhu

Looks like your last commit is not signed. Please sign the commit and I'll merge.


Fix jwt.js and add scripts to package.json

A bug was introduced in #50 which caused the tests to fail. And it
appears that one of the tests was wrong.

I was also thinking that a .travis.yml file should be added. I can update the PR if need be.

Thanks for this.
Completely open to a Travis file and Travis badge.
Thanks for the PR :).


Add a principles and guidelines section

Includes discussion of trailing commas which closes #42

@nrc - see my comment above. There seems to be a typo in the text you merged.


Is there a way to read wav files per slices?

The *.wav files I am trying to read are quite large (about 100e6 samples) and I get a memory error when trying to use the gain function, and the function Signal.from_wav takes really long to execute.
Any tip to be able to read the files per chunks or to read them faster?
PySoundFile has a way to read per slices the wav files, and their reading algorithm is a bit faster, but then it takes again so long to convert it to an acoustics.Signal object.
I could also maybe try to implement it myself if there is no code prepared for it or any trick I am missing.
Any help will be really appreciated! :)

I suppose the Signal class could be improved by supporting numpy.memmap. Anyway, the way it is now, the Signal class is not intended for long signals requiring in-core operations.

Thanks!


Update Pages “mais-uma”

Automatically generated by Netlify CMS

👷 Deploy Preview for mozdrag processing.

Name
Link

🔨 Latest commit
eb6c4a122f75a93888cb3d3cf5e691dbcf36e651

🔍 Latest deploy log
https://app.netlify.com/sites/mozdrag/deploys/6524ed2d5c6015000887370d


Example usage of DependencyScanning.Timeout

Hi,
Can example usage for DependencyScanning.Timeout be provided in the documentation? It's unclear how this is passed to the AdvancedSecurityDependencyScan pipeline step.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 121e4848-4927-4353-8283-b3e413fc8f42
Version Independent ID: 121e4848-4927-4353-8283-b3e413fc8f42
Content: Dependency Scanning for GitHub Advanced Security for Azure DevOps - Azure Repos
Content Source: docs/repos/security/github-advanced-security-dependency-scanning.md
Service: azure-devops
Sub-service: azure-devops-integration
GitHub Login: @juliakm
Microsoft Alias: jukullam

@gigabytte -- thank you for your feedback.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@juliakm -- please look into this issue.

Hi @gigabytte - thanks for the feedback, I'll add an example to the docs. In the meantime, here is an example:
- task: AdvancedSecurity-Dependency-Scanning@1     env:       DependencyScanning.Timeout: 120


Item pickup not working

I tried hard coding the DefaultDropGenerator to always drop a specific type (e.g. Excellent), it worked, but, I can't pick it up.
I tried dropping some items from my inventory and I can't pick them up too.
I will try to investigate this tomorrow. If you can guide me where to look, or you already have an idea, I'd appreciate it.

I couldn’t reproduce the issue. Did you close it because it works for you now, too?

Did you close it because it works for you now, too?
I closed it because I'm not so sure if this report is valid.
This was what I did:

        public IEnumerable<Item> GetItemDropsOrAddMoney(MonsterDefinition monster, int gainedExperience, Player player)
        {
            ...
            yield return this.GetRandomExcellentItem((int)monster[Stats.Level]);
            /*
            for (int i = 0; i < monster.NumberOfMaximumItemDrops; i++)

I got the following exception:
[ERROR] 2019-05-28 00:09:45,095 [MUnique.OpenMU.GameServer.RemoteView.RemotePlayer] [1] - System.ArgumentException: The item needs to be of type MUnique.OpenMU.Persistence.EntityFramework.Item.
Parameter name: item
   at MUnique.OpenMU.Persistence.CollectionAdapter`2.Add(TClass item) in D:\Mu\MU_S6\server\src\Persistence\CollectionAdapter.cs:line 71
   at MUnique.OpenMU.GameLogic.ItemStorageAdapter.CollectionAdapter.Add(Item item) in D:\Mu\MU_S6\server\src\GameLogic\ItemStorageAdapter.cs:line 78
   at MUnique.OpenMU.GameLogic.Storage.AddItem(Byte slot, Item item) in D:\Mu\MU_S6\server\src\GameLogic\Storage.cs:line 107
   at MUnique.OpenMU.GameLogic.InventoryStorage.AddItem(Byte slot, Item item) in D:\Mu\MU_S6\server\src\GameLogic\InventoryStorage.cs:line 73
   at MUnique.OpenMU.GameLogic.DroppedItem.TryPickUp(Player player) in D:\Mu\MU_S6\server\src\GameLogic\DroppedItem.cs:line 158
   at MUnique.OpenMU.GameLogic.DroppedItem.TryPickUpBy(Player player, Item& stackTarget) in D:\Mu\MU_S6\server\src\GameLogic\DroppedItem.cs:line 100
   at MUnique.OpenMU.GameLogic.PlayerActions.Items.PickupItemAction.TryPickupItem(Player player, DroppedItem droppedItem, Item& stackTarget) in D:\Mu\MU_S6\server\src\GameLogic\PlayerActions\Items\PickupItemAction.cs:line 67
   at MUnique.OpenMU.GameLogic.PlayerActions.Items.PickupItemAction.PickupItem(Player player, UInt16 dropId) in D:\Mu\MU_S6\server\src\GameLogic\PlayerActions\Items\PickupItemAction.cs:line 29
   at MUnique.OpenMU.GameServer.MessageHandler.Items.PickupItemHandlerPlugIn.HandlePacket(Player player, Span`1 packet) in D:\Mu\MU_S6\server\src\GameServer\MessageHandler\Items\PickupItemHandlerPlugIn.cs:line 36
   at MUnique.OpenMU.GameServer.MessageHandler.PacketHandlerPlugInContainer`1.HandlePacket(Player player, Span`1& packet, THandler handler) in D:\Mu\MU_S6\server\src\GameServer\MessageHandler\PacketHandlerPlugInContainer.cs:line 96
   at MUnique.OpenMU.GameServer.MessageHandler.PacketHandlerPlugInContainer`1.HandlePacket(RemotePlayer player, Span`1& packet) in D:\Mu\MU_S6\server\src\GameServer\MessageHandler\PacketHandlerPlugInContainer.cs:line 73
   at MUnique.OpenMU.GameServer.RemoteView.RemotePlayer.PacketReceived(ReadOnlySequence`1 sequence) in D:\Mu\MU_S6\server\src\GameServer\RemoteView\RemotePlayer.cs:line 144

I hard-coded the item return since monsters don't drop any items in my env.


No matching method for class

Since clojure 1.12 hit I figured I'd use some qualified methods, such as String/.split.
Sadly this seems to fail with the following error message:
Execution error (ExceptionInfo) at clojure.tools.analyzer.passes.jvm.validate/validate-call (validate.clj:127).
No matching method: .split for class: class java.lang.String and arity: 2

Usage example:
^{:nextjournal.clerk/visibility {:result :hide}}
(defn to-matrix [input]
  (for [line (String/.split input "\\n")
        :let [numbers (String/.split line "\\s+")]]
    (map parse-long numbers)))

Clerk-version:
io.github.nextjournal/clerk {:git/sha "d9cab25aae62029557cff3346e7bd06e878999cd"
                                             :git/url "https://github.com/nextjournal/clerk"}

Hi @Oddsor,
Suport for the new Clojure syntax depends on tools.analyzer.jvm support for it, see https://clojure.atlassian.net/browse/TANAL-138. It was merged a while back and I've asked on slack if someone can cut a new release. Will keep you posted when I hear back.

tools.analyzer.jvm has been released and I updated it in 73c6a5002734f568bbbb5421a59462b61462ccc6  but found out that method values aren't supported yet, this is tracked as https://clojure.atlassian.net/browse/TANAL-141.

org.clojure/tools.analyzer.jvm {:git/url "https://github.com/borkdude/tools.analyzer.jvm"
                                        :git/sha "318dc38f0a903fabb22a7e2caafea5a5b4c37df8"}

has some more fixes


Add --with-netstd for all available versions

Add --with-netstd for all available versions. Otherwise, Is it a reason why it's not been added?
Thanks in advance.

@hotohoto If I remember correctly, this repository is forked to the following repository.
https://github.com/jaegertracing/docker-thrift

Unfortunately, I cannot create an issue there. 🤔
Thanks for the information. 👍


Implement tracecontext propagation format

This is quite similar to the Node package @opencensus/propagation-tracecontext, but this does not make use of Node-specific libraries (for trace ID generation). It can makes a couple simplifications and having this as a separate package for web could enable additional optimizations once we use the Closure compiler, e.g. not doing validation in the minified production builds.

I think I addressed all the comments. @mayurkale22 is this ready to merge?


Add method count for Android developers

Android has a 64k method limit, so a lot of Android developers take method count into consideration when choosing libraries.
As this library appears to be pretty compact (especially compared to some of the bloat-ridden alternatives like Guava) highlighting the method count might encourage more use by Android developers.

Hi Chris, I'm happy to add the number to the readme if you calculate it. I don't have the android tool chain handy to generate a dex file to get an official count.

Here's the results I get:

Here's the results I get from the dexcount plugin:

'com.github.andrewoma.dexx:collection:0.6' = 1036 methods
'com.github.andrewoma.dexx:kollection:0.6' = 1213 methods

Thanks, I've added the counts to the README


Heuristic evaluation of the site (Usability audit / baseline)

We would like to better understand the challenges that exist across the current website.
This evaluation will allow us to conduct a usability audit of the site using a variety of pre-determined measures to highlight key areas to optimise.
This will allow us to populate the backlog with a series of 'optimisation' activities that are designed to drive incremental (positive) change within the current experience and have a backlog of well refined stories to take into sprints. Key to collating, synthesising and prioritising known issues and resolving these.

[ ] Review initial audit template and agree this is fit for purpose (https://docs.google.com/spreadsheets/d/13hEjqtvWFHzJSYrcj5t2p0gRZEq1Rri72BQ97WZKGbs/edit?usp=sharing)
[ ] Conduct audit
[ ] Collate, analyse and determine actions from the results
[ ] Create new optimisation stories to be delivered in future sprints

To do: work out page goals


How to connect Database to rasa core?

How to connect Database to rasa core?
Want to fetch data from the database as per the query defined in the action.

I don’t think this is really Rasa-related since you can use pymysql (for MySQL obviously :smiley:) & others, or an ORM such as SQLAlchemy to do this. For example, for returning the first name of a person in a database from an “ID” entity, things could look like this:
def read(id_person: int) -> Person:
db = pymysql.connect(SERVER, USER, PASSWORD, DB)
cursor = db.cursor()
sql = "SELECT * FROM PERSON WHERE ID = '%d'" % (id_person)
try:
cursor.execute(sql)
results = cursor.fetchall()
for row in results:
first_name = row[1]
last_name = row[2]
age = row[3]
sex = row[4]
income = row[5]
person = Person(id_person, first_name, last_name, age, sex, income)
except:
print("Error fetching data.")
finally:
db.close()
return person
If the ID is in a slot, you can easily pass it to the read function using the tracker.get_slot function and then get the person object in return. Then using the dispatcher you could simply pass person.first_name in the response.


Add attributes describing API stability.

What does the pull request do?
Inspired by the conversation in #8015, adds two attributes which describe the stability of an API:

UnstableAttribute indicates that we provide no API stability guarantees for the class between minor/patch versions. This is mostly applied to *Impl interfaces which describe the interface between core Avalonia and platform implementations, but also to some other APIs which are unlikely to be of use to client code, and are likely to change
NotClientImplementableAttribute indicates that an interface is stable for consumption by a client, but should not be implemented outside of Avalonia itself (either because custom implementations are not supported, or because as members may be added to its API)

This can be used to suppress API Compat warnings for changes to unstable APIs, and later we may want to write an analyzer which produces warnings when an unstable type is used in client code.
I may have missed some types, or labeled some types incorrectly. Please let me know or push to this branch if so.

You can test this PR using the following package version. 0.10.999-cibuild0020130-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 0.10.999-cibuild0020427-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 0.10.999-cibuild0020445-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 0.10.999-cibuild0020481-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


[NBCNewsIE] Broken IE - doesn't work for full episodes

Falls back to the generic extractor. I opened a separate issue to #2946 due to the sufficiently different URL structure. I suspect a new IE will be needed in this case.
Example URL: http://tve-nbcnews.nbcuni.com/tve/show/Meet the Press#show/Meet the Press/239227971771/0/Meet the Press%2C April 27%2C 2014
$ youtube-dl -v http://tve-nbcnews.nbcuni.com/tve/show/Meet%20the%20Press#show/Meet%20the%20Press/239227971771/0/Meet%20the%20Press%2C%20April%2027%2C%202014
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://tve-nbcnews.nbcuni.com/tve/show/Meet%20the%20Press#show/Meet%20the%20Press/239227971771/0/Meet%20the%20Press%2C%20April%2027%2C%202014']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.05.13
[debug] Python version 3.4.0 - Linux-3.14.1-1-ARCH-x86_64-with-arch
[debug] Proxy map: {}
[generic] Meet%20the%20Press%2C%20April%2027%2C%202014: Requesting header
WARNING: Falling back on generic information extractor.
[generic] Meet%20the%20Press%2C%20April%2027%2C%202014: Downloading webpage
[generic] Meet%20the%20Press%2C%20April%2027%2C%202014: Extracting information
ERROR: Unsupported URL: http://tve-nbcnews.nbcuni.com/tve/show/Meet%20the%20Press#show/Meet%20the%20Press/239227971771/0/Meet%20the%20Press%2C%20April%2027%2C%202014; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 516, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 161, in extract
    return self._real_extract(url)
  File "/usr/lib/python3.4/site-packages/youtube_dl/extractor/generic.py", line 687, in _real_extract
    raise ExtractorError('Unsupported URL: %s' % url)
youtube_dl.utils.ExtractorError: Unsupported URL: http://tve-nbcnews.nbcuni.com/tve/show/Meet%20the%20Press#show/Meet%20the%20Press/239227971771/0/Meet%20the%20Press%2C%20April%2027%2C%202014; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

Now the URL of the provided example is:
http://tvenbcnews.nbcuni.com/now/#show/Meet the Press/239227971771/0/Meet the Press%2C April 27%2C 2014
and there's another example from #11736:
http://tvenbcnews.nbcuni.com/now/dateline/full-episode/after-the-storm/855288387677


Added description property to Asset model

Implements @ChristopherJennings request #40
I'm wanting to add an assertion after Line208 in the DeliveryClientTests.cs file
But item.AssetField.First().Description property appears to be null for project with sandbox id e1167a11-75af-4a08-ad84-0582b463b010
Edit looks like I messed up indentation, will update indentation to spaces

thanks @VarinderS ! we'll fix the tests after #22 gets implemented


Some question about add_window

Hello.I think i don't know about the function add_window.There's some code that makes me wonder，“idx < len(doc) - window_size”. Actually,I know it's a critical condition,It makes the last window retain size.But I think,in the bottom of the code,there is " item.metadata[f"{window_idx_name}_lower_bound"] = min(window)
item.metadata[f"{window_idx_name}_upper_bound"] = max(window)",
we use the min and mix func to deal the bound.So i guess the condition “idx < len(doc) - window_size” does not seem to make much sense.

The main reason I added this condition is that when the number of elements at the end of doc list is not enough to create a new large chunk index, I will combine those last few elements into the previous large chunk index. You can reference this below graph:

ok,that is what i guess.Thanks for your reply,Thank you!


No exports for operator and add

RxJS version: 5.5.2
Code to reproduce:
Try to import catch from the add/operator  or throw from the add/observable
Expected behavior:
It should be imported in the TypeScript style like map or Observable:
import { catch'} from 'rxjs/add/operator/catch';
import { throw'} from 'rxjs/add/observable/throw';
Actual behavior:
We must use the old style import like this
import 'rxjs/add/operator/catch';
import 'rxjs/add/observable/throw';
Additional information:
If there is a reason why we import all in operators with the construct:
import { } from from 'rxjs/operators'
and we cannot do the same with all the operator in 'rxjs/add', I would like to know why.

You can import by
// JavaScript ES7 Function Bind Syntax
import {Observable} from "rxjs/Observable";
import "rxjs/add/observable/interval";
import {take} from "rxjs/operator/take";
import {map} from "rxjs/operator/map";
import {bufferCount} from "rxjs/operator/bufferCount"

Observable
  .interval(200)
  ::take(9)
  ::map(x => x + "!!!")
  ::bufferCount(2)
  .subscribe(::console.log);

Source: https://gist.github.com/MichalZalecki/d78c52ec55d7ec7b53f7

I already know that. But for operator, there is an operator.ts that export all the operator present in rxjs/operators but there is no files named operator.ts that exports all from rxjs/add/operator so that we can do the same import as map like this:
import { catch'} from import 'rxjs/add/operator';
like
import { map } from 'rxjs/operators';

rxjs/add/* modules are not designed to export anything, they're designed to patch the prototype to have those methods.


[Site] Spelling error on http://twister.net.co/?page_id=25

On this http://twister.net.co/?page_id=25 page the word "transation" is mispelt and should be "transaction".

thanks, fixed!

Pleasure


Connection to CloudSQL works in all scenarios except via socket in Docker container

Hopefully I'm doing something wrong, I've read all documentation and scoured forums but can't seem to get to the bottom of an issue I'm experiencing. I'm using OSX btw.
Things that are working:

Connect to cloud SQL from local OS using proxy via either TCP or Socket
Connect to cloud SQL from local OS using proxy in container via TCP
Connect to cloud SQL from GKE using proxy in the same pod via TCP

Things that are not working:

Connect to cloud SQL from local OS using proxy in contain via sockets
Connect to cloud SQL from GKE using proxy in the same pod via socket

I suspect both of these problems are actually the same problem.  However when I attempt to connect I get the following error:
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/cloudsql/node-sql:us-central1:nodedb' (61)
The proxy doesn't generate a new line  when I try to connect which makes me think that it's not receiving the request, it simply says "Ready for new connections" and waits.
Any idea what's going wrong, or how I could troubleshoot this further?

Please follow this instruction:
https://cloud.google.com/sql/docs/mysql/connect-docker ("9. Start the proxy.")
for the command to connection in container via unix sockets.  Particularly:
docker run -d -v /cloudsql:/cloudsql \
  -v [PATH_TO_KEY_FILE]:/config \
  gcr.io/cloudsql-docker/gce-proxy /cloud_sql_proxy -dir=/cloudsql \
  -instances=[INSTANCE_CONNECTION_NAME] -credential_file=/config

Closing due to lack of updates.  Feel free to reopen this if there's still an issue.

I have encountered with the same  issue. But it's more likely linked to https://github.com/docker/for-mac/issues/483.
Inside docker container connection through socket is working:
➜  ~ docker exec -it cloud-sql sh
/ # apk add --no-cache mysql-client
/ # mysql -u root -p -S /cloudsql/xxx\:europe-west3\:xxx
Server version: 5.6.36-google (Google)
MySQL [(none)]>


tests/storage: import kubevirt.io/api/core/v1 only once

No reason to import the same package twice, with two different names.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[x] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[x] Community: Announcement to kubevirt-dev was considered

Release note:
NONE

/approve


cache maxAge response header

I think there should be set a max age for the static directory according to react documentation:
https://create-react-app.dev/docs/production-build
Right now it defaults to 0.
Documentation suggests: Cache-Control: max-age=31536000 for build/static

I will take this up!


Register a typed Store class with the DI

This allows us to inject AppStore into our components instead of the more verbose approach of manually typing the Store to AppState with Store<AppState> every time.

@MikeRyan52

@krjordan it appears there are some conflicts with the recent changes that have been made. I'll sort them out right away if @MikeRyan52 approves the PR.

Conflicts are resolved.

First off, I apologize for the delay in getting back to you on this PR.
I don't think I'll be making this part of the official example app. This isn't because your proposed changes aren't useful (it looks like they would be saving a lot of import statements in big apps) but because it could make it more difficult for beginners to understand what the typed alias is doing.
I am considering adding an 'advanced' version of the example app in the future where this change would make more sense.
Thanks for the contribution!


Remove server calls in Manage Streams

This is stacked on #2118, and we may want to get a little bit of burn-in on those changes before this simplification.  It's not that big a deal, though, because I think these changes make sense for our long term strategy, and any bugs should be easy to address quickly.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

@timabbott I think we've had good burn-in here.

Merged, thanks @showell!  It's exciting to have this code simplified.


Beginner in this Open Source Contribution

Hello, I'm Aryan, and I'm a beginner in open source. I'm currently exploring the field and looking for a suitable "Good First Issue" to contribute to. Is there an opportunity for me to participate in one of your projects?

I am also looking for any opportunity to contribute in open source

Hello, I am Faal, I am a beginner at open source and I am  looking forward to contributing to open source projects

Hello guys Vaibhav Vats this side,
I have some experience in MERN stack and web development and I'm looking forward to contributing on open-source projects.
Hope we contribute together and create some next level projects.
Thank you.


Added Lobby List and Lobby detail pages

We have implemented basic html pages for the lobby list and detail pages for each lobby. They are under the URL "lobby/". For the lobby list, since I want to display it as a table element, I did not use the default ListView from django and instead wrote a customized view method for it.

Updated files so that they reflect suggested changes. Namely, changed the class ViewLobbyDetails to a function instead in views.py, and updated the URL in urls.py so that they reflect the changes in views.py

Lobby list view is now available. For each lobby, a detailed list is also implemented. In the future we might be more careful before each commit and should test around with a fixture.

Issue Score: Excellent
Comments:
Good work on a simple detail page! For future PRs, make sure you code is 100% tested and ready to go instead of iterating multiple rounds of reviews. Also, make sure you detail exactly who did what in your closing comment.


Create tests for gh-emoji. Use of some more ES6 goodness :)

@oskarcieslik Thank you very much for the PR! looks quite better now ^^. Actually I'm looking for other maintainer of the repo, would you like to be part of it? I can grant you access and we can build some new features if you are interested. Think about it and let me know :smile:

Sure, I would love to help! :) I'm currently working on demo with autocomplete :)
Also I'm a little bit worried about those hardcoded values of github emoji images with v6 at the end, it will break after they update their api..

@oskarcieslik amazing! Now you are a official collaborator of gh-emoji ^^. What do you mean with the v6??


deleting_users.js returning empty dataset

When running on an OSM extract, the deleting_users.js script returns and empty .json - other user scripts work fine

The deleting users requires a full history (osh) file to report anything useful. Did you use an osh file? They are available from geofabrik.


Replace metalsmith-assets with metalsmith-include-files

metalsmith-assets is deprecated.
metalsmith-include-files does the same job and is being maintained.
Makes sense to swap 'em out!
No diff between compiled files before and after.

@domoscargin I know this is merged now but I'm trying to understand why we needed to include assets/fonts and assets/images separately. Wouldn't these just be included with the rule that imports govuk/assets/*?

Hi @ahosgood govuk/assets/* actually currently picks up nothing, as that pattern would only find files within govuk/assets, not folders (that would require govuk/assets/**/*.
It's there as a bit of gentle futureproofing, but isn't strictly necessary.
The reason the fonts and images folders are configured separately is that metalsmith-include-files flattens files into whatever you've passed as a key. So, { assets: govuk/assets/**/* } would not retain the folder structure, just lump everything into the assets folder.
I can't recreate your error locally - it's a bit odd, since the build process starts by cleaning the destination folder, so I wouldn't necessarily expect that error.

Okay, that makes sense - thank you for the context! The documentation on https://github.com/emmercm/metalsmith-include-files wasn't brilliantly helpful.
I assumed it was an issue with my local setup... 😅


Fix crash resulting from bad month check in core_bind.cpp

Fixes #18221

@akien-mga Done the changes, and added similar behaviour for the day parameter.

Cherry picked into 3.0.3


fix(htmlhint): fix not working problem on<EMAIL_ADDRESS>

fix #53
don't know how to test, should work.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: fisker sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

当我们可以自己修复自己机器上的问题的时候，为什么要在这里求别人，为什么我要这样讲，因为我看了下#48 再见
I  wrote this  in  chinese  is on  purpose.


[FIX] Show "no data" message if no visible columns

Simple fix for the problem. If there are no columns or rows, "no data" message would be shown.
Issue: https://github.com/SAP/openui5/issues/904

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Control owner has been informed (finally, sorry; some process issues on our side...).

Hello Etignis,
thanks for your contribution.
This is a duplicate of https://github.com/SAP/openui5/pull/905
We are currently checking also with our designers how such a feature could be provided. It will not only cover the "no columns defined case" but also the "all columns are hidden" (visibility property) case.
BR
Jens


refactor LibraryModelsHandler.onOverrideMayBeNullExpr

this does a similar refactoring as in https://github.com/uber/NullAway/pull/747
i held back on putting this up for review because i was assuming the removal of analysis.nullnessFromDataflow(state, expr) could be controversial
we can use this review to figure our what kind of tests are missing that would make clear why nullnessFromDataflow was being called inside a handler

@msridhar i think it is independent (assuming there is no good reason why it was running dataflow early before...) but of course we should rebase and re-run CI after one of them got merged, to confirm all tests are still passing with the combination of the two

@msridhar rebased justFYI

thanks for the review, please let me know the results of internal testing and performance impact of all these changes if possible

thanks for the review, please let me know the results of internal testing and performance impact of all these changes if possible

Thanks again for the contribution!  For performance impact, the best tests we have for that are the jmh tests in open source.  Usually it's hard to see a statistically significant performance win there, as there is a good amount of noise in the runs.  If you're going to try it, you should try to run on a system with as little load / interference as possible

thanks for the info

Long digression, but basically convinced that this change is a good idea. Worth internal/performance testing, but I'd expect it to be mostly the same, just clearer code! (for which: thank you!)

due to this comment i thought there might be some internal testing going on outside of the JMH benchmarks...

thanks for the info

Long digression, but basically convinced that this change is a good idea. Worth internal/performance testing, but I'd expect it to be mostly the same, just clearer code! (for which: thank you!)

due to this comment i thought there might be some internal testing going on outside of the JMH benchmarks...

You're right that there is some internal performance testing that @lazaroclapp can do.  But those numbers are even more noisy than the JMH benchmarks :-)  So, outside of some unusual coding pattern or combination of flags that doesn't show up in the benchmarks, it probably won't surface any further perf insights (in my opinion).

thanks for the info

Long digression, but basically convinced that this change is a good idea. Worth internal/performance testing, but I'd expect it to be mostly the same, just clearer code! (for which: thank you!)

due to this comment i thought there might be some internal testing going on outside of the JMH benchmarks...

You're right that there is some internal performance testing that @lazaroclapp can do. But those numbers are even more noisy than the JMH benchmarks :-) So, outside of some unusual coding pattern or combination of flags that doesn't show up in the benchmarks, it probably won't surface any further perf insights (in my opinion).

To be fair, I was mostly thinking of internal conformance testing (i.e. any changes to the behavior of NullAway on our full codebase) + JMH for performance benchmarking. I am not sure anything that doesn't show up in JMH benchmarks will show up in internal builds, since those are a lot more noisy, but definitely will report if something does :)

@XN137 FYI I sent an email to you a while back at the email address associated with your GH commits.  Maybe you saw it, I'm just not sure.  If you didn't see it, you can email me at the address on my web site from whatever address works best for you


Fix to determine assembly PlatformTarget for AnyCpu assemblies

Use AssemblyName.GetAssemblyName to determine platform.

Got approve from @codito offline.


How can we Create a blurry background for the video

How can we Create a blurry background for the video
example

GL shaders can create blurred video but how to create a blurred background and overlay a normal video over it.
can we use  GLSurfaceView ?

Do you need the background to be static or animated? If static is good enough, you can do this now by following what FreeTransformVideoGlFragment does. If it needs to be animated and show blurred and zoomed version of original video frame, that will probably require writing a new filter. I will have to think about this, it is a very interesting problem and feels like LiTr "almost" supports this.


Peer Review for Amrom

@amromeo
Hi Amrom.
Went through the intro slides and your updated deck.
Intro:
All looks good.  Looks like you left a bit of a gap to be able to pull in some of our presurvey data.  I think that will be cool.  Like the encouragement for folks to introduce themselves to their neighbors too!
Transform deck:
Thanks for the opportunity to share feedback via phone, I like the changes you made and think you are going to be really good for time with ~70 slides.  Really like the way you show pre & post highlighted tables also for the code you execute.
(slide #)
(16) - I'd be prepared to spend some time unpacking the c() function.  This may be one of the first stretches for them (function in a function).
(33) - Appreciate that you broke out the challenge here.  I think beginners will feel more comfortable if they feel like they aren't failing if they don't get through all the components.
(35) - So appreciate that you call out == and =, hugely important for the beginner!
(47) - for exercise 5, the second part may be another opportunity for challenge/extra credit (esp in 3 minutes)
(49) - love the piping slides, might suggest going real slow here, I found piping a bit of a trip when starting R (even after good comfort in python) and since we continue to leverage this throughout, I would hate to lose folks here.
(56) - your turn #6 is a nice synthesis, just a thought to consider some additional skeleton code for them to build off of
(69) - coercing data types may be entering intermediate territory, but since it is at the end of the block, you could definitely gauge abilities and dive deep or pass as you feel the attendees are up for it.  Nice to have in the deck for future reference for sure.

Thanks, these are great suggestions!
appreciate your thoughts re piping, will defineitly take it slow.
i hear you regarding the exercises.
We are absolutely going to have a substantial skill spectrum in there. Probably the best way to buffer is to have good entry level stuff but allow for people to level up on their own


Cannot create standalone page for Project tiers

Describe the bug
Cannot create standalone page for Project tiers
To Reproduce
Steps to reproduce the behavior:

Create a new project
Click on 'Create Contribution Tier'
Scroll down to find no Standalone Page toggle option

Expected behavior
I expect to be able to create Standalone Pages for any type of Contribution Tier, including on Projects
Screenshots
This option is available for the main collective's contribution tiers, and for event tickets, but not for project contribution tiers. It should be available for for all Contribution Tier types across all of open collective:

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

That was a conscious decision made to simplify the interface for projects & events. @jdaviescoates could you share more information about your use case?

That was a conscious decision made to simplify the interface for projects & events

I don't understand. Event tickets have this already, so how now having this for projects "simplify the interface for projects & events" :confused:
I also don't understand how adding this small simple toggle option which is already present for normal Contribution Tiers and for Event Ticket Tiers could possibly make the interface for projects overly complex :confused:
My use case is simply that we have a "Create a new bus" Project and we'd like a Standalone Page to run a crowdfunding campaign for that Project. For now we're just going to create a standard Contribution Tier. But then that makes me wonder what Projects are actually designed for?
Thank you for your consideration.  Could you please elaborate on the reasoning for this decision? Thanks! :slightly_smiling_face:

But then that makes me wonder what Projects are actually designed for?

Having just had a look at https://docs.opencollective.com/help/collectives/projects :

Projects
Projects are a lightweight way for collectives to manage budgets for initiatives independent of their parent collectives. Use a project if:
You would like to collect funds for a specific initiative or idea
You would like to allocate part of your collective's budget to a specific initiative
You would like to track the spending on a specific initiative separate from the rest of your collective

Projects have many of the same features as Collectives. Projects have their own balances, contributions, and expenses. Projects can describe contribution tiers, set goals, and provide updates.
Budgets are independent. Projects can only spend what is allocated to them. And what is available within the project is not available from the parent Collective.

Yes, that is exactly what I want to do, but I also want a crowfunding-like Standalone Page for the project.

Please do make it possible to create crowdfunding type Tiers (i.e. "Standalone pages") for Projects.
It actually seems the most obvious place to have them: lots of projects need to run a crowdfunding campaign to get started!
Thanks!

Hey, @jdaviescoates thank you for your time opening this issue! I lead the design team and are now revamping our fundraising game. Are you interested in walking me through your experience using Open Collective's fundraising features? That would add tremendous value to the process :)
Please do let me know! Thank you!

Are you interested in walking me through your experience using Open Collective's fundraising features?

@Memo-Es sure, book yourself a slot via https://ud.coop/quickchat - thanks!


[Feature] Evenly space elements on a diagram

With multiple elements selected on a diagram, provide an option to space the elements evenly either vertically or horizontally. Leave the outer elements (topmost and bottommost for vertical or leftmost and rightmost for horizontal) in place and distribute the remainder with even spacing between the elements.

I can have a go at implementing this if not already on the roadmap. Let me know.

I agree that this is a needed feature and would make a difference to diagrams. Most other products have such a feature in their alignment options.

Hi. In fact this is now easy to do through jArchi (the script plugin for Archi). I personaly don't have time to do it now, but you should be able to do it quickly by yourself.

I have created a gist to achieve this


Grafana is not showing docker worker nodes on Windows

Swarmprom is sucessfully running on Ubuntu Machine.
Currentl it is not showing worker nodes
Kindly assist me

My cluster has 2 nodes, 1 manager and 1 worker.
In the grafana dashboard I can see details for only manger node

I have checked it is working on docker in Linux not for docker in Windows.

Hi,
Is there anything we can do about this? I know from Portainer, that it doesn't work with running global agents, but rather running separate containers on each windows node.
See step 4 here: Portainer Deployment documentation

any updates??

Any updates on this???

+1

+1


armdev: sys_clone is broken

new task with pc == 0 will fail, of course.
with this simple program:
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <unistd.h>

int main()
{
	printf("testing fork; init pid = %d\n", getpid());
	pid_t p = fork();
	if (p < 0) {
		printf("fork failed!");
		exit(1);
	}
	if (p == 0) {
		printf("print from child. pid = %d\n", getpid());
	} else {
		printf("print from parent. pid = %d\n", getpid());
	}
	return 0;
}

Erorr Log:
[INFO] [1/43c0140000|0] (1/1)------get call id sys_clone arg0:4111
[INFO] [1/43c0140000|0] Clone opts is CloneOptions { sharingOption: SharingOptions { NewAddressSpace: false, NewSignalHandlers: true, NewThreadGroup: true, TerminationSignal: Signal(11), NewPIDNamespace: false, NewUserNamespace: false, NewNetworkNamespace: false, NewFiles: true, NewFSContext: true, NewUTSNamespace: false, NewIPCNamespace: false }, Stack: 7f4d8e3137b0, SetTLS: false, TLS: fffffffe7fffffff, ChildClearTID: false, ChildSetTID: false, ChildTID: 0, ParentSetTID: false, ParentTID: 0, Vfork: true, Untraced: false, InheritTracer: false }
[INFO] [1/43c0140000|0] created child task with context with pc 0 , sp 43c01dfec8
[DEBUG] [1/43c0140000|0] set tpidr_el0 from 2b8410f7f640 to 2b8410f7f640
[DEBUG] [1/43c01c0000|0] get instruction abort fault from el1
[INFO] [1/43c01c0000|0] DFSC/IFSC == 0x5, FAR == 0x0, acces-type fault == --x, during address translation == false, ESR=86000005, PC=0
[ERROR] [1/43c01c0000|0] VM: PageFault in kernel FAR: 0x0, TTBR: 0x43c0401000, PtRegs: SP:[0x43c01dfec8]
                   PC:[0x0]                   <<<<<<< note that this pc is null
                   State:[0x800003c5]
                   X0:[0x7f4d8e3137b0]
                   GenRegs:[[ ... ]]

I'll try fixing this.
btw @CharlyYu I saw your comment in task_clone.rs#677
        // TODO what is this?
        #[cfg(target_arch = "x86_64")]
        {
            toPtRegs.rax = 0;
        }

If I unsderstand correctly, this is because the fork() returns child PID to the parent, and returns 0 to the child.

this is due to inconsistent definition of aarch64 context. This has been fixed.
However this sys_clone is still incorrect as it returns EFAULT (bad address) , this is undefined in man 2 clone

patch coming soon.
I'm getting access flag faults and permission faults on the forked child process.

this is because the fork() returns child PID to the parent, and returns 0 to the child.

That makes sense.

data abort: child process is trying to write to read-only memory
[DEBUG] [1/43c0140000|0] get data abort fault from el0
[INFO] [1/43c0140000|0] DFSC/IFSC == 0xF, FAR == 0x7F1438AE4AA0, acces-type fault == -w-, during address translation == false, ESR=9200004f, PC=419580
[DEBUG] [1/43c0140000|0] need to handle fault: ctx is SP:[0x7f1438ae4ae0]
                   PC:[0x419580]
                   State:[0x0]
                   X0:[0x2]
                   GenRegs:[[
    2,
    0,
    2,
    0,
    4825296,
    4827072,
    4825088,
    0,
    220,
<PHONE_NUMBER>20007,
    49,
    10,
    1,
    0,
    0,
    0,
    1,
    4286080,
    0,
    2,
    48,
    4788224,
    4827072,
    0,
    4778008,
    24,
    0,
    0,
    4792368,
<PHONE_NUMBER>20000,
    4296412,
]]
[DEBUG] [1/43c0140000|0] VM: Entered HandleFault.
[ERROR] [1/43c0140000|0] PF HANDLER: sending SIGSEGV
[ERROR] [1/43c0140000|0] TASK ID:<PHONE_NUMBER>24, thread-uid: 307
[DEBUG] [1/43c0140000|0] Dump mapping for virt addr 7f1438ae4aa0
[DEBUG] [1/43c0140000|0] L0[254]<PHONE_NUMBER>000000 - 0043c040d -<PHONE_NUMBER>11 - MapRange:     7f0000000000 + 512G
[DEBUG] [1/43c0140000|0]     L1[080]<PHONE_NUMBER>000000 - 0043c040e -<PHONE_NUMBER>11 - MapRange:     7f1400000000 + 1G
[DEBUG] [1/43c0140000|0]         L2[453]<PHONE_NUMBER>000000 - 0043c040f -<PHONE_NUMBER>11 - MapRange:     7f1438a00000 + 2M
[DEBUG] [1/43c0140000|0]             L3[228]<PHONE_NUMBER>000000 - 0043c040c -<PHONE_NUMBER>11 - MapRange:     7f1438ae4000 + 4K

@shrik3 Can we now close this?

@shrik3 is the issue still relevant or can be closed?


typo on Readme

Hi,
Under  the next heading:
***** New April 27th, 2020: A PyTorch implementation of the sliding window attention *****
the typo:
dowstream -> downstream
Thanks for the great work of this repository!
Gorka

Fixed. Thanks.


I can't visualize all my flow due lack of scroll

I have a big flow that can't be shorted as conductor is unable do handle subflows inside loops.
So, in Firefox, when I'm browsing my flow I'm not able to visualize all the steps but it was possible to take a screenshot of everything with Firefox screenshot tool.
I have 3 more items after the last visible step.

Sorry, just after past the flow I could see the last items were moved to the top, may some mistake, but it is complete anyway.