Feature/1726 iframe widget

Description

Create an iframe widget

Fixes #1726
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/1726-iframe-widget

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
51.68 (-0.01)
32.89 (-0.04)
29.61 (-0.03)
52.16 (-0.01)

:sparkles: :new:
app/client/src/components/designSystems/blueprint/IframeComponent.tsx
33.33
20
0
33.33

:red_circle:
app/client/src/icons/WidgetIcons.tsx
54 (-0.17)
100 (0)
4.17 (-0.18)
54 (-0.17)

:red_circle:
app/client/src/utils/WidgetRegistry.tsx
75.56 (-0.3)
100 (0)
26.67 (-0.92)
75.56 (-0.3)

:sparkles: :new:
app/client/src/widgets/IframeWidget.tsx
47.06
0
33.33
46.88

We don't have the Visible property in the property pane. However, it shows up in the autocomplete. We should also include the source and title properties in the autocomplete.

@yatinappsmith @NandanAnantharamu tests are failing here 😞

@yatinappsmith @NandanAnantharamu tests are failing here 😞

https://github.com/appsmithorg/appsmith/pull/5118  this has fixed this issue

@wmdev0808 please merge the latest relase here!

@wmdev0808  Tested iframe widget in Deploy Preview and please find our observations below,
1.Default iframe should be displayed

The text url in the OnChangedURL tool tip message should be displayed in Capital letters

3.Green Border colour is not applied - Choose Green border colour and click on deploy and observe

iframe size is reduced in the Deploy Mode compared to the editor mode

https://www.loom.com/share/8413e74df2904c24b4bb761cbbb1bc3e

Border Opacity is not functional

Drag and Drop any widgets nearby iframe and set the iframe Border Width to 150 and then click on deploy and observe the widgets placed nearby iframe are shown within iframe container in the deploy mode

https://www.loom.com/share/f3bd9c172f3647bcaf4799eba8024219

The query value truncates/breaks on selecting Reset option with widget - Widget name and Reset Children - Yes on OnURLChanged field

8.Expected DataType field is not displayed for Border Opacity and Border Width fields

9.Application Crashes when the user passes invalid page name in the Navigate option on OnURLChanged actions
https://www.loom.com/share/801fee21324c42789563ee67372358ce

Re-ran all tests, Forkapplication.spec.js was failing, Not related to this

Re-ran tests, Other tests are failing now!

Re-ran tests, Other tests are failing now!

we have to work on a fork/duplicate app the current solution is not working, we will et back to you. @hetunandu should we validate the widget instead of dsl validation ? this is failing again

Re-ran tests, Other tests are failing now!

We have been playing catchup with this test for 3 weeks now. I had pushed a fixed that seemed to pass at the PR level but failed once merged. Will try again tomorrow. @NandanAnantharamu @somangshu

We have retested iframe in deploy preview and find the status below,
Issues fixed - 1,2,3,4,8
Issues still open
5 - Border Opacity is not functional - This is still not functional
6-Drag and Drop any widgets nearby iframe and set the iframe Border Width to 150 and then click on deploy and observe the widgets placed nearby iframe are shown within iframe container in the deploy mode > - This issue is fixed for border width 150 but this issue is still reproducible for border width above 170
7-The query value truncates/breaks on selecting Reset option with widget - Widget name and Reset Children - Yes on OnURLChanged field - This issue still exists
New observations:
10) For any invalid source url app smith deploy page is displayed in iframe
https://www.loom.com/share/563cedf38ad646e3b2870a21c1d5d0ee

Is there any restrictions for source url - Most of the source url’s are not loaded in iframe - For Example - LinkedIn, Google, Stack-overflow
https://www.loom.com/share/21838a9c44e243c1b17157091b2ec864

12)Some of the tooltip message inside iframe content are breaking
https://www.loom.com/share/bf946d1c70494ae4ba081045995185fb
Note: OnMessageReceived Action scenario is still pending


added shap_values_output tests and fixed issue

added tests for shap_values_output for tree explainer and mimic explainer, fixed issue with XGBoost and TreeExplainer case
Note latest XGBoost doesn't work with shap 0.34.0 so I pinned it, there is a serialization issues which is already fixed in latest shap, but requires us upgrading to it.

@gaugup @gregorybchris would be great to get another review of this PR


[Function Expose] Codeunit 130401 AddTestCodeunits FunctionVisibility External

Hello,
it would be great if the function AddTestCodeunits in the Codeunit 130401 "CAL Test Management" would be set to External (FunctionVisibility)... then we would have the possibility to automatically create our own test suite with lines when installing a test app.
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


TableHeader width not matching column width

I can't figure out how to get the TableHeader to match the size of the column. The 'name' column (of which I did not show) is also twice as large as it needs to be. I realize I can hard code in width's, but even still the Title's do not much the data columns.
Also, how do I get rid of the separation from of the Titles and the first row of data?

Got it.

@tylerkeesling what was your solution?


When will qwen 2.5 be supported?

When will qwen 2.5 be supported?

qwen2.5 and qwen2 have the same structure. Just follow the configuration of qwen2 to successfully run llmc.