Potential rule duplication

Do you think having a rule no_behaviour_info (with a u) would make sense? It would simply be an alias for no_behavior_info. [I don't want to get into an argument over the English language, since I don't have a preference...]
I remember being surprised, a few years back, when I discovered that both spellings worked the same for erlang. I think, at a given moment in time, about 10 years ago, dialyzer would complain about missing stuff if the spelling was behavior.

I don't think we need a new rule. If no_behavior_info doesn't warn you about behaviour_info/1, it should.

I think that should be the case as well, that is, if it doesn't do it at the moment it should. 😄

I just checked and the style rule does check for both 🥳 , see [here](https://github.com/inaka/elvis_core/blob/master/src/elvis_style.erl#L433.

I just checked and the style rule does check for both 🥳 , see here.

I wasn't talking about the check itself, but the rule name. :) It was simply a new alias...

Aaah, I misunderstood then. I think it's probably better to have a single one to avoid confusion. I just updated the documentation so it mentions both spelings.

Aaah, I misunderstood then. I think it's probably better to have a single one to avoid confusion. I just updated the documentation so it mentions both spellings.

Got it. Thanks.


Convolution filtering and convolution networking broken

Connections are not getting created correctly.
Working on a fix that will also include a graphic visualizer to make it easier to see what is happening at each layer of the network.

Commit 6ba0a2c6679825ee0f4d5ead15b83e6b52d92e4d fixes most of the connection bugs. There may still be errors in the math calculations for updating weights in convolution networking layers. If so, we'll open a new issue to track it.


Incorrect guidelines/colors/usage documentation for $inverse-support-04

On guidelines/color/usage the documentation of $inverse-support-04 for the White and Gray 10 themes incorrectly states it uses the color token Blue 40 (#408BFC).
Blue 40 is in fact defined as #6EA6FF, the correct color token for $inverse-support-04 should be Blue 50 which is #408BFC, as specified.
Incorrect token Blue 40:

Correct token Blue 50 (as used by $interactive-04 for the White theme):

This has been fixed (maybe a while ago).


update paper list for FL-NLP

As the title says.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: 董晨鹤:x: cheneydon董晨鹤 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

some license errors


FileDialog minor UI inconveniences

Godot version: 3.2-stable
OS/device including version: Debian Buster amd64
Issue description:
Currently, FileDialog behaves very differently from what you would expect in any other system file dialog. With a few minor changes, it would be much more "pleasant to use". Those don't deserve separate issues because it's all one thing - "Fix FileDialog design".

"Open" button state (enabled/disabed) is determined by selection only, not by what's typed.

This is pretty confusing. Currently, the "Open" button is disabled when nothing is selected, and enabled when you select something. This leads to a lot of confusion when coupled with typing things manually. I can type the file name in the bottom LineEdit, but "Open" is still disabled. But I can press "Enter", and it will work. Or I can select a file and then type a nonexistent filename - the button is enabled, but clicking it does nothing. My suggestion is: either disable the button "properly" (when nothing is selected AND there is no text in LineEdit), or don't disable it at all (error checking is already there, so it won't be any worse).

Entering a full path/name manually (instead of navigating to it) should work.

For example, the dialog is asking you to locate a certain file on your filesystem. Typing "/usr/bin/myfile" is MUCH faster than navigating to that file, especially with folders containing a lot of files. Currently, typing a filename is possible, but typing a full path+name does not work.

Typing a path and hitting "Enter" should navigate to this path.

Currently, it is possible to type the path in the top LineEdit to navigate there, but not in the bottom one. So we have to click the top one, delete everything there (no "Clear" button!), enter the path, then click the bottom one, enter the file name, wonder why "Open" is still not active, and hit "Enter" hoping for the best.
Some of those may be tricky to implement considering various modes of the same FileDialog, but we can have a discussion here about it. Maybe there are other "usually present" features I have missed.
I've tried to tackle such a "cosmetic polish" myself, but no, I can't handle C++ in an unfamiliar project...

im currently working on making the file dialog much better, expect to have last modified, size, and sort by it
Currently having problems with cell selected on SELECT_MODE_ROW currently trying to figure it out

Oh, cool! Usability enhancements! :)
If you are interested in pimping up the dialogs in general, there is one more idea in proposals:
https://github.com/godotengine/godot-proposals/issues/455
But that is more than just one-component overhaul, and probably requires a discussion about core UI design. On the other hand, FileDialog seems to have a "hard-coded" minimal size already, so maybe it wouldn't be much of a problem to just increase it to a more reasonable value.

im currently working on making the file dialog much better, expect to have last modified, size, and sort by it

do you need help with that? i would like to participate in making the FileDialog better

@Grosskopf ShlomiRex opened a pull request here: #36053

I've confirmed that this is still relevant for 3.2.3 (was that PR successful?..)

I'd also add that it would be cool if drag-and-dropping files into the dialog would work (go to that path), it would save time to people who already have their file/path open in a file manager, and it would make sense to implement it generally. ( https://docs.godotengine.org/en/stable/classes/class_mainloop.html#method-descriptions )


cleanup 2

errors in pytest are weird. They nly show up in python 3.9 cicd so ill leave that for now


feat(test): add model extract/convert e2e test

What type of PR is this?
/kind test
/area model

What this PR does / why we need it:
add model extract/convert docker e2e test
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @simon-cj

Does this PR introduce a user-facing change?:

Add model extract/convert docker e2e test

/lgtm


ImportError

Trying to build ungoogled chromium and getting this error:
FAILED: gen/ui/gfx/x/damage_undef.h gen/ui/gfx/x/damage.h gen/ui/gfx/x/damage.cc
python ../../ui/gfx/x/gen_xproto.py /usr/share/xcb/damage.xml gen/ui/gfx/x/damage_undef.h gen/ui/gfx/x/damage.h gen/ui/gfx/x/damage.cc
Traceback (most recent call last):
File "../../ui/gfx/x/gen_xproto.py", line 1028, in
sys.exit(main())
File "../../ui/gfx/x/gen_xproto.py", line 1018, in main
import xcbgen.xtypes
ImportError: No module named xcbgen.xtypes
ninja: build stopped: subcommand failed.
=> ERROR: chromium-84.0.4147.125_1: do_build: 'ninja -C out/Release ${makejobs} chrome chromedriver mksnapshot' exited with 1
=> ERROR:   in do_build() at srcpkgs/chromium/template:272
Ive serched for this module but just cant find.
any solutions?

You need a version of xcb-proto built with Python 2.

https://github.com/Eloston/ungoogled-chromium/issues/1151#issuecomment-680043925 is correct, closing.


Add async functions to the IConsumers.

This is a larger effort to allow for better options in consumers.
I would appreciate feedback around the general approach and if you have ideas of how to reduce redundancy.

It's currently not building in Travis - will review when green :)

I think all the ...Async methods should take an optional CancellationToken (correct me if I'm wrong Jon) which is passed to the WaitAsync calls of the SemaphoreSlims. Also, all Wait(Async)...Release pattern should be done in a try...finally so you don't lock out the resource in the case of exceptions.

Fixed the build.  Task.CompletedTask is not available in 4.x.

Righto, will have a look - I agree about cancellation tokens being important though.

Alright I will add CancellationTokens and wrap in try/finally, thanks :)

Jon/Mike would using Task.WaitWithUnwrappedExceptions be a good way to remove more redundancy here? Am I missing an issue this may cause?

Where there is a sync code path to use, that's generally better than using Wait. Will review this a bit later - thanks for the changes.

Thanks Mike, PTAL

Yeah something odd is going on with the comments. Because of that, you may have not seen the comments about using ConfigureAwait(false) and I forgot to mention it in my latest review. So I would just say add .ConfigureAwait(false) to the end of every expression with await in front of it in the libraries (not the tests). Other than that, LGTM.

I did miss it.
I just took a look at the docs and not entirely sure what it does or when it should be used.

Done.
Jon if you ever get bored and feel like explaining in detail I'd love to listen.

Thank you Jon and Mike, I appreciate all the feedback!


Application rootElement?

Instead of slapping the classes on <body> shouldn't it be put onto rootElement?

Either way, it might be a nice option to do that :)

@tonycoco commented on Sep 18, 2015, 12:57 AM EDT:

Instead of slapping the classes on <body> shouldn't it be put onto rootElement?

If that happens, this package might have to be renamed to be more accurate! :stuck_out_tongue:

True! :)

I would agree with @jalcine and say that it would probably need to be a new package 😂 also I'm not sure what extra functionality you might be able to achieve putting the class on the application instead of the body 🤔
I'm closing this for now. Let me know if people think it needs to be re-opened


Proposal: add notify command to send stats results to an endpoint

PR adds the following:

cli integration using --notify (includes support for configuring --group_name, --url, --frequency, --timeout)
Logic to handle pushing stats notifications to a https endpoint on a loop using timeout and frequency
Test coverage for notify
README updates on how to use the new command

Looks like I can't merge, if you wouldn't mind doing the honors @shayonj 🙏


Add number of offers in amazon

Create one more function that using to return the number of sellers

Thanks @hqtoan94 .


Allow to specify path for SSH authorized_keys and home directory

Closes #9
Only .travis.yml is missing for checking, it the path change works.

adding manage_dir (from authorized_key) adds complexity which could break ssh.
Specifically: "Be sure to set manage_dir=no if you are using an alternate directory for authorized_keys, as set with path, since you could lock yourself out of SSH access."
Without thorough tests (via travis) this seems too dangerous.
Closing PR.


Forward unhandled WebView URI schemes to InterApp

Some URIs are intended for other apps on device, and when those are loaded the webview currently just goes to an invalid uri. We only intercept the URISCheme set in the unoproj, and i'm reticent to add some sort of whitelist of URIs that we forward to InterApp.LaunchUri automatically... Open to thoughts on how to approach this.

The forum thread Custom URI support in WebView posted by Matti Tihveräinen was linked to this issue.

Any progress on this issue? Whitelisting URIs seems like a good idea to me. And is it possible to overcome this issue with Foreign Code by rewriting the shouldOverrideUrlLoading method?

We're using a payment method (Mobilepay) that handles via WebView. However the payment method on Android want's to use the Mobilepay app for the process, so at some point the WebView redirects to an URI requesting to open the app. With this issue we're unable to complete the payment, thus making our app ioperable.

Seems that https://github.com/fusetools/fuselibs-public/issues/792 was reverted by https://github.com/fusetools/fuselibs-public/issues/617 due to some incompatibility with URISchemeHandler. URI schemes such as tel: and mailto: would be a good use-case for this functionality for enterprise company apps which make use of web pages.


Running Twill within a Frame

Is it possible to run Twill within an iframe or similar container within the parent application? (i.e. within the panel highlighted in red) - if so, is this relatively easy to implement or am I potentially opening a huge and enormously expensive can of worms?
Thanks!

Hi @jkhamler!
I would say why not? I can't think of anything that wouldn't work except for the challenge you have with logging in existing users transparently from your parent application. I have to give more thoughts to that.

Hi @jkhamler,
closing this as we didn't hear from you in a while. The challenge is not really in Twill's purview but rather a cross domain and iframing concern that you should be able to solve without changes to Twill's internals.


Maven index source becomes unstable and collapses after some time

Describe the bug
After some time the discovery stream collapses as no more identifiers can be read from the source. There seems to be an issue with HTTP connection reading from the maven index. It may be timing out.
The stack trace reads like this:
[2018-10-19 11:24:31,703]  d.u.c.s.d.c.s.ElasticActor - Stream failed!,
java.lang.RuntimeException: read error,
	at org.apache.maven.index.reader.ChunkReader$IndexIterator.nextRecord(ChunkReader.java:155),
	at org.apache.maven.index.reader.ChunkReader$IndexIterator.next(ChunkReader.java:138),
	at org.apache.maven.index.reader.ChunkReader$IndexIterator.next(ChunkReader.java:112),
	at de.upb.cs.swt.delphi.crawler.discovery.maven.IndexProcessing$MavenIndexReader.read(IndexProcessing.scala:66),
	at de.upb.cs.swt.delphi.crawler.discovery.maven.IndexProcessing.$anonfun$createSource$3(IndexProcessing.scala:39),
	at akka.stream.impl.UnfoldResourceSource$$anon$1.onPull(UnfoldResourceSource.scala:42),
	at akka.stream.impl.fusing.GraphInterpreter.processPull(GraphInterpreter.scala:526),
	at akka.stream.impl.fusing.GraphInterpreter.execute(GraphInterpreter.scala:422),
	at akka.stream.impl.fusing.GraphInterpreterShell.runBatch(ActorGraphInterpreter.scala:588),
	at akka.stream.impl.fusing.ActorGraphInterpreter$SimpleBoundaryEvent.execute(ActorGraphInterpreter.scala:45),
Caused by: java.net.SocketException: Connection reset,
	at java.net.SocketInputStream.read(SocketInputStream.java:210),
	at java.net.SocketInputStream.read(SocketInputStream.java:141),
	at java.io.BufferedInputStream.read1(BufferedInputStream.java:284),
	at java.io.BufferedInputStream.read(BufferedInputStream.java:345),
	at sun.net.www.MeteredStream.read(MeteredStream.java:134),
	at java.io.FilterInputStream.read(FilterInputStream.java:133),
	at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:3393),
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:246),
	at java.io.BufferedInputStream.read1(BufferedInputStream.java:286),
	at java.io.BufferedInputStream.read(BufferedInputStream.java:345),
[2018-10-19 11:24:31,709]  d.u.c.s.d.c.s.ElasticActor - Stream failed!,
java.lang.RuntimeException: read error,
	at org.apache.maven.index.reader.ChunkReader$IndexIterator.nextRecord(ChunkReader.java:155),
	at org.apache.maven.index.reader.ChunkReader$IndexIterator.next(ChunkReader.java:138),
	at org.apache.maven.index.reader.ChunkReader$IndexIterator.next(ChunkReader.java:112),
	at de.upb.cs.swt.delphi.crawler.discovery.maven.IndexProcessing$MavenIndexReader.read(IndexProcessing.scala:66),
	at de.upb.cs.swt.delphi.crawler.discovery.maven.IndexProcessing.$anonfun$createSource$3(IndexProcessing.scala:39),
	at akka.stream.impl.UnfoldResourceSource$$anon$1.onPull(UnfoldResourceSource.scala:42),
	at akka.stream.impl.fusing.GraphInterpreter.processPull(GraphInterpreter.scala:526),
	at akka.stream.impl.fusing.GraphInterpreter.execute(GraphInterpreter.scala:422),
	at akka.stream.impl.fusing.GraphInterpreterShell.runBatch(ActorGraphInterpreter.scala:588),
	at akka.stream.impl.fusing.ActorGraphInterpreter$SimpleBoundaryEvent.execute(ActorGraphInterpreter.scala:45),
Caused by: java.net.SocketException: Connection reset,
	at java.net.SocketInputStream.read(SocketInputStream.java:210),
	at java.net.SocketInputStream.read(SocketInputStream.java:141),
	at java.io.BufferedInputStream.read1(BufferedInputStream.java:284),
	at java.io.BufferedInputStream.read(BufferedInputStream.java:345),
	at sun.net.www.MeteredStream.read(MeteredStream.java:134),
	at java.io.FilterInputStream.read(FilterInputStream.java:133),
	at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:3393),
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:246),
	at java.io.BufferedInputStream.read1(BufferedInputStream.java:286),
	at java.io.BufferedInputStream.read(BufferedInputStream.java:345),

To Reproduce
Steps to reproduce the behavior:
Run a crawler instance with a discovery process for some time. The bug will eventually occur and processing will cease.
Expected behavior
The stream source should be stable not to crash the stream.
Screenshots
n/a
Affected components (if known)
crawler
Desktop (please complete the following information, if relevant):
n/r
Smartphone (please complete the following information, if relevant):
n/r
Additional context
A few ideas already sprung to my find:

gracefully end the source after a problem and restart the process
check the timeouts attached to the connection
first create a local copy of the index and then read locally
index from a local proxy where timeouts can be configured
implement a totally different Source using directory traversal

Uhhh just learning that there are backoff operators and kill switches already in akka streams... Neat!
https://doc.akka.io/docs/akka/2.5/stream/stream-error.html

Driving the read timeout incredibly high has apparently helped a lot.
The backoff handler seems be a good idea nonetheless.


ng2-smart-table css customization

I'm submitting a ...
[ ] bug report
[x] feature request
[x] question about the decisions made in the repository

Do you want to request a feature or report a bug?
More of a question which could become a feature request.

What is the current behavior?
Unable to control the ng2-smart-table's CSS

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
Making changes to the smartTables.scss file is not making any difference to the look of the table.

What is the expected behavior?
I expect to change the color of selected rows.

What is the motivation / use case for changing the behavior?
To have a different look if the colors are invisible after changing background and for better control in general.

Please tell us about your environment:
I'm using a Mac El Capitan system for my testing.

Chrome Browser
Angular version 2.4.4
npm: 3.10.10
node: v7.3.0

Other information
Not sure of the fix. I'm not sure how to override the default CSS of the ng2-smart-table

May have jumpted the gun on this one. I had a require problem for the style. The style customization seems to be working just fine.


Feature/prefer ssh url

Hello there,
this PR "solves" issue #140 and adds some unit tests.
I hope this fits :) Learned somthing...
Best regards,
Willi

thanks


Non-root users are unable to view logs in UI

My Environment
ArangoDB Version: 3.7.6
Storage Engine: RocksDB
Deployment Mode: Single Server
Deployment Strategy: Manual Start in Docker
Configuration: 4 vcpus 32 GiB memory
Infrastructure: Azure Standard E4s v3
Operating System: Ubuntu 16.04
Total RAM in your machine: 32Gb
Disks in use: SSD
Used Package: Docker - official Docker library
Component, Query & Data
Affected feature:

Logs tab on UI
Steps to reproduce

As root, Create user, assign 'Administrate' or 'Access' permission to database
Log in as the user, select the database and click 'Logs' tab in the UI

Problem:
User cannot view logs in the UI - a blank screen is shown with no error or information. On previous versions (3.6 & 3.3) our users have been able to view the logs if they have 'Administrate' or 'Access' permission to the database.
We then found this article https://www.arangodb.com/docs/3.7/security-security-options.html
and ran:
--server.harden false (also tried true) - this did not fix the issue
Expected result:
Non-root user with regular access permissions  can view logs in the UI

We have identified the solution, granting _system access to the users has allowed logs access. Closing the issue


Return values as const to make the compiler happy in typescript

Based on this thread:
https://github.com/microsoft/TypeScript/issues/35423
I had to change the return type to be const to satisfy the typescript compiler

Thanks for the pull request!


Server as a TCP server for NMEA0183 data

Apparently there are use cases where this might come in handy, for example when you use iSailor as your course computer and you want NMEA0183 data, like wind, available in iSailor and you want iSailor generated autopilot sentences routed to your serial connection via the same tcp connection.

I have 2 problems in the scenario tkurki outlined. The first is allowing bidirection comms on 10110, the other is getting the autopilot data back out on a NMEA serial link. Can’t do the latter without sending everything out, AIS and all. So filtering sentences out on the serial link would also be required. Current workaround is to do autopilot input and output filtering in opencpn

Sorry, perhaps it should be in another thread. I’m new here
Bidirectionality lets autopilot data in from isailor. Filtering allows its output to a legacy autopilot without flooding a 4.8k link. For this issue very much related.

Implemented in #639


Can't access any site in any quickstart (IPs lead nowhere/not discoverable on network)

OS: Windows 10
Host: Virtualbox (5.1.28)
Issue: Whenever a quickstart is used, following the tutorials, the console eventually prints an IP address to hit. i.e. <IP_ADDRESS> or something. This is presumably being served through the Host-Only Adapter since that's the only adapter shown in ifconfig on the VM guest (as eth0). Even port forwarding the guest port (say 80 to 8080) on localhost results in the connection being reset the instant it's established.
Reproduction: I started with this QS, followed it through until visiting the page.
Notes: Nanobox works fine on my Linux partition partition and my Macbook, but the above issue on both of my Windows computers running Windows 10.

Update, fixed it thanks to some helpful peeps in Slack 😄
Be sure to not disable the TAP network interfaces in the network manager. They're _Quite Important_™


Map point preview missing

From @katarinabatina on December 1, 2014 21:26
press point on map, black bar preview does not appear
Copied from original issue: artsy/eigen-private#2030

From @ashfurrow on January 9, 2015 16:5
Hmm. Not seeing this on my end – any idea on how to reproduce? Seeing this.

From @katarinabatina on January 9, 2015 17:46
launch app>armroy show>map>zoom>tap point>preview flickers...It might be an iPhone 6 compatibility issue.

From @ashfurrow on January 12, 2015 17:9
OK, I'll be sure to try it on an iPhone 6. Thanks for the info!

Confirmed, pretty sure I've seen this.

To clarify, the originally reported issue by @katarinabatina is about the black callout immediately disappearing after showing.

This bug only occurs when running the application on a device that runs iOS 8.x
I have verified that the bug does not occur on a device running iOS 7 (7.1.1).


joinedAt-fix

Description
joinedAt is working .
Fixes #(issue number)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
I tested it myself and it works correctly without using any database, I used the joinedAt function from discord.js.
The problem was that the user does not have the joinedAt function, but the chat member does.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have restored .env.template
[ ] I have performed a self-review of my code
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

Thanks @rj564zi!


Structure package stuff

Stuff from the structure package from #1956
This is the sixteenth of the follow ups from that, dividing into top level packages

Also needs to update branch to merge into before merge

Conflicts after changing branch.


[RFC] Support async handler on thread function

I have proposal to make async handler works inside thread, Here is sample of async handler
import Thread from "../Thread.ts";

let thread = new Thread<number>(async (e: MessageEvent) => {
  console.log("Worker: Message received from main script");
  const result = e.data[0] * e.data[1];
  await new Promise((resolve) => setTimeout(resolve, 5 * 1000))
  if (isNaN(result)) {
    return 0;
  } else {
    console.log("Worker: Posting message back to main script");
    return (result);
  }
}, "module");

thread.onMessage((e) => {
  console.log(`recived back from thread: ${e}`);
});
thread.postMessage([10, 12]);
thread.postMessage([10, 10]);

//thread.stop();

It handy to have async handler so I can use await inside those function. I can prepare a PR if you want  to implement this

Hey @praswicaksono look good to me. Did you want to implement this yourself? if so you may go ahead and fork/open a PR.
If you wanted me to implement it instead just let me know and I'll try some things out


fix(chargebee/get-sub-metadata): return 0(unlimited) for trail

@dabeeeenster is there a reason that we're implementing this on our side rather than adding trial periods to the chargebee plans?

Yep - to avoid having to programatically create an account in Chargebee for the trial


Miss important factor: Language services / language server protocol support

I don't know about flow but you forgot to mention an important aspect about TypeScript. Is more than a language, is a language server, similar to LSP (https://github.com/Microsoft/language-server-protocol)) but on its own. General users won't use that API, but TS architecture force users to use their server (tsserver) running in the IDE / editor. This new concept although could seem not KISS,  I think in part is why TS UX is faster than flow cause server is managing the project. Also as user you can develop a plugin for refactor, suggestion, folding, fixes, etc and it will work out of the box on any IDE supporting tsserver,
Although there are no much plugins today and ts team is advancing slowly in this aspect I think is a good idea. Perhaps in time will be obsolete in favor of LSP, who now . I'm learning how to use TS Compiler API myself because I want refactor plugins like those you have in other strongly typed languages / IDEs ike Java/eclipse (like move this method to this other class) and these are some I have (WIP) https://github.com/cancerberoSgx/typescript-plugins-of-mine/tree/master/typescript-plugin-proactive-code-fixes
In the future, perhaps now, flow could tackle this implementing LSP (probably there is already one) but TS is in advantage because tsserver API is very close to the language and LSP is more generic since it needs to support all. On the other hand, depending on a server for managing the project could have negative consequences in large projects performance IMO
I think this aspect is very interesting in the comparison too.Nice work, keep it up, couple of links:
https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API
https://github.com/Microsoft/TypeScript/wiki/Standalone-Server-(tsserver)
https://github.com/Microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin

Flow has LSP support

I know would be interesting to see in which platforms / languages and what's the quality of the implementations.

Indeed, quality of LSP is an interesting factor, so I'd welcome a PR adding the comparison of LSP in both platforms.


Add project link + explanation to readme

Added the hosted link to the readme, and an explanation for why it's super slow first time around (hosted link is already at the top so probably good to explain it's google's fault not ours)

@Gleoman ?

:shipit:
Apologies on late response. Hectic week and some plonker hit me with his car while I was on the way to an interview this morning...


Mobile first work about

work and about sections complete
-no lint errors
-buttons work when hovering over them, as well as the 'languages' section: when hovered a drop-down menu appears (as it is a mobile version button has to be clicked).

@shahadat3669 regarding PR description, i think i have mixed it up and left my description in the comment rather than description section, could you advise me how i could edit PR description?


Support for custom HTTP request headers

If an application is required to set additional HTTP headers on image requests, I don't see a way to either supply an NSURLRequest for each image request (with the appropriate headers already set) or to add the headers globally to all requests.
As one solution, PINRemoteImageManager uses [NSURLSessionConfiguration defaultConfiguration] in its initialization. If PINRemoteImageManager offered a way to customize that configuration, that could be configured to add the additional headers to all image requests made through that (shared) instance of PINRemoteImageManager.

Good idea! Would be happy to entertain any pull requests that implement this.


Add A Nebula Inside by nlfl

Song Name
A Nebula Inside
Artist Name
nlfl
Source
Youtube
Youtube Link
https://youtu.be/lMLyqDpSgGM?si=DPqJC0oERwuV005y
Direct File Link
No response
Song ID
156693
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 95453908

reject
duplicate request, see issue 1894


Add BiGRU

Description

Add BiGRU and configs.
New metrics: RP@k and nDCG@k.

But I don't think this is right. Now sort_indices isn't used at all. I think we want
indices[sorted_indices] = torch.arange...

This is the old one. We have this:
data_size = sorted_indices.size(-1)
indices = torch.empty(data_size, dtype=torch.long)
indices[sorted_indices] = torch.arange(data_size)

at the latest commit.


⚠ ClamAV has degraded performance

In 453215c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 451 ms

Resolved: ClamAV performance has improved in fd40b50 after 5 minutes.


Fixed 32 bit windows build

Current coverage is 100.00%

Merging #4 into master will not affect coverage as of 2820f1f

@@            master      #4   diff @@
======================================
  Files            1       1
  Stmts           92      92
  Branches         0       0
  Methods          0       0
======================================
  Hit             92      92
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 2820f1f

Powered by Codecov. Updated on successful CI builds.


AOT hints prevent compilation when using JdbcOAuth2AuthorizationService or JdbcRegisteredClientRepository

If you have a bean of type org.springframework.security.oauth2.server.authorization.JdbcOAuth2AuthorizationService or org.springframework.security.oauth2.server.authorization.client.JdbcRegisteredClientRepository then the compilation fails in processAot with the error:
java.lang.ClassNotFoundException:
  org.springframework.security.oauth2.server.authorization.jackson2.OAuth2ActorAuthenticationTokenMixin

To reproduce use Spring Initializr with dependencies "OAuth2 Authorization Server", "Spring Data JDBC" and "GraalVM Native Support", and just add the bean
@Bean
public JdbcRegisteredClientRepository registeredClientRepository(JdbcOperations jdbcOperations) {
    return new JdbcRegisteredClientRepository(jdbcOperations);
}

I have created an example repository.
My investigation leads me to believe this this is caused by the AOT hint OAuth2AuthorizationServerBeanRegistrationAotProcessor
The hint was introduced by 25a785de498b, but was not updated when the class was renamed by 2f1f45bc0152 (#60).

Closing as duplicate of gh-1630


Fix folder rename

Fix #25

hello, is there any progress in this merger?

Hey, is there any progress on this?


Expose max_wait_secs per operation (and make it a float)

@ttomsu This change would have let you change the per-operation timeout yesterday

LGTM


[Bug]: local models not able to be configured to work

Is there an existing issue for the same bug?

[X] I have checked the troubleshooting document at https://github.com/OpenDevin/OpenDevin/blob/main/docs/guides/Troubleshooting.md
[X] I have checked the existing issues.

Describe the bug
There are a number of issues open about whether local models are usable or not. It works fine making remote calls to Groq but I run out of credit really quickly, and I need to use my local gpus in any case.
I have tried for six hours today to get these working LOCALLY:
codellama:7b
llama3:latest
In Issue #1336 rbren says "In general, local models aren't powerful enough yet to run OpenDevin...." Well, that may be the case, but I have llama3:70b installed on my local machine, and four gpus to run it (ollama spreads the load nicely). I think that configuration will easily work for OpenDevin. But I cannot get it to work based on the instructions.
A am not really asking you to fix this at this point, but can you just confirm whether there is a known issue here?
If you're not aware of one, then I'm happy to carry on testing, and I'll report all the different configurations I've attempted. But I don't want to spend hours more testing if there is a known issue.
for example:
llama3
llama3:latest
ollama/llama3
ollama/llama3:latest
LLM_API_KEY=ollama
LLM_MODEL=ollama/llama3
Thanks for your help - I feel it's an amazing product - if only I could get it to work!  Attempt #1 | You can customize these settings in the configuration.
21:55:21 - opendevin:ERROR: llm.py:64 - argument of type 'NoneType' is not iterable. Attempt #2 | You can customize these settings in the configuration.
21:55:22 - opendevin:ERROR: llm.py:64 - argument of type 'NoneType' is not iterable. Attempt #3 | You can customize these settings in the configuration.
21:55:24 - opendevin:ERROR: llm.py:64 - argument of type 'NoneType' is not iterable. Attempt #4 | You can customize these settings in the configuration.
21:55:30 - opendevin:ERROR: llm.py:64 - argument of type 'NoneType' is not iterable. Attempt #5 | You can customize these settings in the configuration.
21:55:30 - opendevin:ERROR: agent_controller.py:103 - Error in loop
Traceback (most recent call last):
File "/app/.venv/lib/python3.12/site-packages/litellm/main.py", line 736, in completion
optional_params = get_optional_params(
^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 4981, in get_optional_params
_check_valid_arg(supported_params=supported_params)
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 4630, in _check_valid_arg
if k not in supported_params:
^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/opendevin/controller/agent_controller.py", line 99, in _run
finished = await self.step(i)
^^^^^^^^^^^^^^^^^^
File "/app/opendevin/controller/agent_controller.py", line 212, in step
action = self.agent.step(self.state)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/agenthub/SWE_agent/agent.py", line 90, in step
action, thought = self._think_act(messages=msgs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/agenthub/SWE_agent/agent.py", line 45, in _think_act
resp = self.llm.completion(
^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 289, in wrapped_f
return self(f, *args, **kw)
^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 379, in call
do = self.iter(retry_state=retry_state)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 325, in iter
raise retry_exc.reraise()
^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 158, in reraise
raise self.last_attempt.result()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 449, in result
return self.__get_result()
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
raise self._exception
File "/app/.venv/lib/python3.12/site-packages/tenacity/init.py", line 382, in call
result = fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File "/app/opendevin/llm/llm.py", line 79, in wrapper
resp = completion_unwrapped(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 2977, in wrapper
raise e
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 2875, in wrapper
result = original_function(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/main.py", line 2137, in completion
raise exception_type(
^^^^^^^^^^^^^^^
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 8665, in exception_type
raise e
File "/app/.venv/lib/python3.12/site-packages/litellm/utils.py", line 8640, in exception_type
raise APIConnectionError(
litellm.exceptions.APIConnectionError: argument of type 'NoneType' is not iterable

I do realise btw that this is broadly the same issue as https://github.com/OpenDevin/OpenDevin/issues/1208
but I still can't seem to find a resolution for that anywhere? Perhaps there is and I just can't find it.
Thanks

FWIW I have seen reports that ollama/llama3 runs successfully - this comment
I'm sorry for the frustration. I'm not aware of an issue preventing you from running, but we can definitely improve the experience here, as we learn what and where the problems are.
The error you get (initially, "argument of type 'NoneType' is not iterable") is not one reported before, as far as I can see. It's also a curious one, it seems to complain that supported_params is wrong... if I see this right. Can you please try a command in the opendevin directory:

poetry show litellm

What version does it have?
Perhaps more importantly to make it work now, you're running the 'main' opendevin docker image. Can you try 0.4.0 instead of main?
The last one: as we can see in the linked comment, it appears that ollama:llama3 can work. Use that, and, can you please check and tell what ollama list shows?

Thanks enyst. It's okay, I'm not frustrated at all :) I know your product's in early alpha, just really keen to get it working :)
Here is the output you were asking for... thanks again.
$ poetry show litellm
RuntimeError
The Poetry configuration is invalid:
- Additional properties are not allowed ('group' was unexpected)
at /usr/lib/python3/dist-packages/poetry/core/factory.py:43 in create_poetry
39│             message = ""
40│             for error in check_result["errors"]:
41│                 message += "  - {}\n".format(error)
42│
→  43│             raise RuntimeError("The Poetry configuration is invalid:\n" + message)
44│
45│         # Load package
46│         name = local_config["name"]
47│         version = local_config["version"]

I'll set about fixing this, as it's clearly indicative of a problem.  Don't worry about commenting again in the meantime, unless you want to.
Thanks :)

RuntimeError
The Poetry configuration is invalid: - Additional properties are not allowed ('group' was unexpected)

Poetry configuration is invalid - Additional properties are not allowed ('group' was unexpected)
--
Run this to check whether LLM is working properly.
import tomllib as toml
from litellm import completion
from datetime import datetime
file_path=r'config.toml'
config = toml.load(open(file_path,'rb'))

messages = [{ "content": "If there are 10 books in a room and I read 2, how many books are still in the room?","role": "user"}]
dt = datetime.now()
response = completion(model=config['LLM_MODEL'],
                        api_key=config['LLM_API_KEY'],
                        base_url=config.get('LLM_BASE_URL'),
                      messages=messages)

content = response.choices[0].message.content
print(content)

if '8' in content:
    print('--> Correct answer! 🎉')
    print('There are still 10 books in the room; reading them does not reduce the count. Consider exploring more accurate models for better results.')

dt2 = datetime.now()
print('Used model:',config['LLM_MODEL'])
import os; print('AZURE_API_VERSION',os.environ.get('AZURE_API_VERSION'))
print(f"Time taken: {(dt2-dt).total_seconds():.1f}s")


Proposal for playlist CRD

Description
A design example for playlist. This will be used in our v5 release of the grafana-operator and won't be backported to v4.
Relevant issues/tickets

https://github.com/grafana-operator/grafana-operator/issues/817
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] This change requires a documentation update
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added a test case that will be used to verify my changes
[ ] Verified independently on a cluster by reviewer

Verification steps

@theknight1509 please take a look at this PR and say if you think this CRD definition would be a good fit for the playlist CRD?
I have taken this straight from the API and I have started on a example implementation in our v5 repo.
I hope I will get more time to work on it later this week.

I can only speak for the yaml, because I do not know anything else :-D
The format looks good! Is it possible for several dashboards to be associated with the same tag? if so, will addng a "dashboard_by_tag" add all the dashboards with that tag?
Other then that it looks good to me :-D
Can't wait to try it out!

hey bot, bye bot


Update Bounties

CI is failing, otherwise looks good I think.

@duje just install and run prettier before each commit to maplibre.github.io Let me know if you need any help with this.

npm run format
git add -p
git commit -m "Format"


Add meta data spreadsheets

See #9

kupot.csv maps kupa_id to Hebrew name
assets.csv maps asset_id to Hebrew name

At the moment (since these files are needed for batch processes), this PR only contains the spreadsheets (and not code to reproduce them).
In order to scrape the <SELECT/> and reproduce kupot.csv, we first need to POST to dafmakdim.aspx hidden strings that should be scraped from a GET to that url (or do this manually).
assets.csv can be reproduced by going over tl-*.csv (produced by #8, takes >24h to run) and creating a union of all assets there.
After merging this PR, we should either keep #9 open (until we add the code) or open a new issue for that.

Added dum-latest.sh to automate routine monthly dumps. It demonstrates [somewhat unorthodox] use of kupot.csv (and may perhaps be useful for cron jobs).


BPA - apply custom fixes

Is your feature request related to a problem? Please describe.
Allow the ability to create scripts which apply fixes or script fixes for a given BPA rule.
Describe the solution you'd like
Currently, the 'apply fix' or 'script fix' is only available for limited scenarios. It would be great to have the ability to write a script that can be associated with the BPA rule that can be executed to 'script the fix' or 'apply the fix'. The script would likely be saved as a custom action. Actually, it could just be an option to reference one of the custom actions.
Describe alternatives you've considered
Additional context

While I like the idea, I'm hesitant to add this feature without further investigation, as malicious users could use this feature to "hide" code inside a Best Practice Analyzer rule file or even inside an annotation of the model (since Tabular Editor allows rules to be stored as annotations).
So far, Tabular Editor does not allow execution of custom code unless you explicitly load a script into the Advanced Editor text box, or modify your CustomActions.json file. It would be too easy for someone to send a gullible consultant a Model.bim file containing a malicious piece of code hidden as a best practice fix and then say, "Hey could you take a look at this file". The consultant might then attempt to fix any best practice violations, not being aware that custom code would then be executing.
This is why the current restrictions on the "apply fix" functionality for the Best Practice Analyzer exists, since it only allows changing a single property.
So for now, I'll close this issue. If at some point Tabular Editor has an option to "warn" users before outside code is executed, I'll consider this (see discussion on #428).

I clearly see your point with regard to security. However, perhaps we can slowly expand the scope of the FixExpression. As an example, if there is a rule to catch single-partition tables where the partition name is different than the table name. The fix for this (to change the partition name to match the table name) is pretty simple however it currently isn't feasible.
The code would be something like this:
Partitions[0].Name = Name
or this:
Partitions[0].Name = Partitions.[0].Table.Name
I think that things like this should be added (as long as security is not compromised). Essentially, right now it seems you're only allowed one reference to the object in question (the left side of the formulas above). A second reference is not allowed (the right side of the formulas).
Thanks!

2.16.1 now allows to use the it keyword in the FixExpression. This should allow you to create a FixExpression that sets a partition's name to the name of the parent table. See my comment on #846.


Build error: failed to run custom build command for glib-sys

Error
λ ~/projects/SolidOak/ master cargo build --verbose
       Fresh c_vec v1.0.8 (https://github.com/oakes/c_vec-rs.git#6cb6f620)
       Fresh pkg-config v0.3.0
       Fresh rustc-serialize v0.3.1
       Fresh libc v0.1.2
       Fresh bitflags v0.1.1
       Fresh neovim-rs v0.0.9 (https://github.com/oakes/neovim-rs#dbaabf31)
       Fresh racer v0.0.1 (https://github.com/oakes/racer#fd596824)
       Fresh gcc v0.3.1
   Compiling cairo-sys v0.1.0 (https://github.com/oakes/rgtk#01b611cf)
     Running `/home/vagrant/projects/SolidOak/target/debug/build/cairo-sys-fbbf5b476f8c9abf/build-script-build`
   Compiling glib-sys v0.1.0 (https://github.com/oakes/rgtk#01b611cf)
     Running `/home/vagrant/projects/SolidOak/target/debug/build/glib-sys-315c48ed6be1c944/build-script-build`
Build failed, waiting for other jobs to finish...
failed to run custom build command for `glib-sys v0.1.0 (https://github.com/oakes/rgtk#01b611cf)`
Process didn't exit successfully: `/home/vagrant/projects/SolidOak/target/debug/build/glib-sys-315c48ed6be1c944/build-script-build` (exit code: 101)
--- stderr
thread '<main>' panicked at '`"pkg-config" "--libs" "--cflags" "glib-2.0"` did not exit successfully: exit code: 1
--- stderr
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'glib-2.0' found
', /home/vagrant/.cargo/git/checkouts/rgtk-3e0fc177da20fde3/master/glib-sys/build.rs:6

Sys Info
λ ~/projects/SolidOak/ master cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.2 LTS"

λ ~/projects/SolidOak/ master uname -a
Linux localdev 3.13.0-44-generic #73-Ubuntu SMP Tue Dec 16 00:22:43 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux```

Did you run the export command from the readme?
On Mar 11, 2015 7:06 AM, "Leonids Maslovs"<EMAIL_ADDRESS>wrote:

ë ~/projects/SolidOak/ master cargo build --verbose
Fresh c_vec v1.0.8 (https://github.com/oakes/c_vec-rs.git#6cb6f620)
Fresh pkg-config v0.3.0
Fresh rustc-serialize v0.3.1
Fresh libc v0.1.2
Fresh bitflags v0.1.1
Fresh neovim-rs v0.0.9 (https://github.com/oakes/neovim-rs#dbaabf31)
Fresh racer v0.0.1 (https://github.com/oakes/racer#fd596824)
Fresh gcc v0.3.1
Compiling cairo-sys v0.1.0 (https://github.com/oakes/rgtk#01b611cf)
Running /home/vagrant/projects/SolidOak/target/debug/build/cairo-sys-fbbf5b476f8c9abf/build-script-build
Compiling glib-sys v0.1.0 (https://github.com/oakes/rgtk#01b611cf)
Running /home/vagrant/projects/SolidOak/target/debug/build/glib-sys-315c48ed6be1c944/build-script-build
Build failed, waiting for other jobs to finish...
failed to run custom build command for glib-sys v0.1.0 (https://github.com/oakes/rgtk#01b611cf) https://github.com/oakes/rgtk#01b611cf)
Process didn't exit successfully: /home/vagrant/projects/SolidOak/target/debug/build/glib-sys-315c48ed6be1c944/build-script-build (exit code: 101)
--- stderr
thread '' panicked at '"pkg-config" "--libs" "--cflags" "glib-2.0" did not exit successfully: exit code: 1
--- stderr
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'glib-2.0' found
', /home/vagrant/.cargo/git/checkouts/rgtk-3e0fc177da20fde3/master/glib-sys/build.rs:6

ë ~/projects/SolidOak/ master cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.2 LTS"
ë ~/projects/SolidOak/ master uname -a
Linux localdev 3.13.0-44-generic #73-Ubuntu SMP Tue Dec 16 00:22:43 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux```
--
Reply to this email directly or view it on GitHub
https://github.com/oakes/SolidOak/issues/10.

Can you verify that you've installed the libraries from apt-get? Once they are installed, that pkg-config command should return something.

Yes, I did

root@localdev:~/projects/SolidOak# apt-get install libgtk-3-dev libglib2.0-dev libcairo2-dev libvte-2.90-dev -y  -qq && echo Done
apt-get install libtool autoconf automake cmake libncurses5-dev g++ pkg-config unzip -y -qq && echo Done
Done
root@localdev:~/projects/SolidOak# apt-get install libtool autoconf automake cmake libncurses5-dev g++ pkg-conf ig unzip -y -qq && echo Done
Done

how could I check that pkg-info returns something?

Try this: pkg-config --libs --cflags glib-2.0

It gives me the following
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'glib-2.0' found
root@localdev:~/projects/SolidOak#

On 2015.03.11. 16:24, Zach Oakes wrote:

|pkg-config --libs --cflags glib-2.0|

Try pkg-config --list-all. You don't need to paste the results if it's a
big list. I'm just curious if it finds anything.
On Wed, Mar 11, 2015 at 10:26 AM, Leonids Maslovs<EMAIL_ADDRESS>wrote:

It gives me the following
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'glib-2.0' found
root@localdev:~/projects/SolidOak#

On 2015.03.11. 16:24, Zach Oakes wrote:

|pkg-config --libs --cflags glib-2.0|

--
Reply to this email directly or view it on GitHub
https://github.com/oakes/SolidOak/issues/10#issuecomment-78272843.

It's not that big list
λ ~/projects/SolidOak/ master pkg-config --list-all
vte-2.90    vte - Vte terminal widget.
liblzma     liblzma - General purpose data compression library
dbus-python dbus-python - Python bindings for D-Bus

Weird. If you run ls /usr/lib/x86_64-linux-gnu/pkgconfig do you see a lot
of *.pc files?
On Wed, Mar 11, 2015 at 10:46 AM, Leonids Maslovs<EMAIL_ADDRESS>wrote:

It's not that big list
ë ~/projects/SolidOak/ master pkg-config --list-all
vte-2.90    vte - Vte terminal widget.
liblzma     liblzma - General purpose data compression library
dbus-python dbus-python - Python bindings for D-Bus
--
Reply to this email directly or view it on GitHub
https://github.com/oakes/SolidOak/issues/10#issuecomment-78277089.

yep, I also see
 ls /usr/lib/x86_64-linux-gnu/pkgconfig/*glib*
/usr/lib/x86_64-linux-gnu/pkgconfig/glib-2.0.pc

Try export PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig. I never had to do this, but it looks like in your case pkg-config doesn't seem to be finding this directory.

It_partially_ helped. It solved glib issue, however I'm facing the new one.
Process didn't exit successfully: `/home/vagrant/projects/SolidOak/target/debug/build/cairo-sys-fbbf5b476f8c9abf/build-script-build` (exit code: 101)
--- stderr
thread '<main>' panicked at '`"pkg-config" "--libs" "--cflags" "cairo"` did not exit successfully: exit code: 1 --- stderr
Package xproto was not found in the pkg-config search path.
Perhaps you should add the directory containing `xproto.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xproto', required by 'xau', not found
', /home/vagrant/.cargo/git/checkouts/rgtk-3e0fc177da20fde3/master/cairo-sys/build.rs:6

and the meta is below
λ ~/projects/SolidOak/ master ls /usr/lib/x86_64-linux-gnu/pkgconfig/*cairo*
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo-fc.pc       /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-svg.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo-ft.pc       /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-tee.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo-gobject.pc  /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-xcb.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo.pc          /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-xcb-shm.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo-pdf.pc      /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-xlib.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo-png.pc      /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-xlib-xrender.pc /usr/lib/x86_64-linux-gnu/pkgconfig/cairo-ps.pc       /usr/lib/x86_64-linux-gnu/pkgconfig/pangocairo.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/cairo-script.pc
λ ~/projects/SolidOak/ master ls /usr/lib/x86_64-linux-gnu/pkgconfig/*proto*
zsh: no matches found: /usr/lib/x86_64-linux-gnu/pkgconfig/*proto*

OK, try this: export PKG_CONFIG_PATH=/usr/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig

That was it.
Thanks for your patience and effort. I would try to solve it myself, unfortunately I'm not that familiar with Linux and pck-config particularly.

I was 5 seconds away from hitting 'close and comment' button, when build failed with that ld error https://gist.github.com/leonardinius/31617d848cde1b508465#file-build-log
tl;dr;
note: /usr/bin/ld: cannot find -lnvim
/usr/bin/ld: cannot find -lmsgpack
collect2: error: ld returned 1 exit status

Is it nvim error, or is it something controlled by SolidOak

I tried to rm -rf  /home/vagrant/.cargo/git/checkouts/neovim-rs-2bb65758e77de428 and then to retry cargo build, with same result.

Additional info (might be useful): I've recently & successfully done  brew reinstall --HEAD neovim (around 1h ago).

Looks like Neovim didn't build correctly. Cargo doesn't does the full output, so the best way to see what happened is to clone https://github.com/oakes/neovim and run make libnvim in that repo. Let me know what errors you get.

hmmm
...
[100%] Built target libnvim
make[3]: Leaving directory `/home/vagrant/projects/neovim-oakes/build'
make[2]: Leaving directory `/home/vagrant/projects/neovim-oakes/build'
make[1]: Leaving directory `/home/vagrant/projects/neovim-oakes/build'

λ ~/projects/neovim-oakes/ master* ls build/lib/libnvim.a
build/lib/libnvim.a

Wow, so it worked. Can you try cargo clean && cargo build in SolidOak? It's building the exact same project behind the scenes.

That solved it. Once again, thanks for your patience and effort.
PS> Gave it a quick try. SolidOak so far looks fantastic and just works. Will try to start using it on regular basis and looking towards future releases.


Both encoder and decoder masking could be considered harmful

I strongly suggest disabling both mask_encoder and mask_decoder for we might well fail to convergence due to encoder masking and get stuck during early training due to decoder masking if we want linear spectrograms output without wavenet.

@begeekmyfriend, I am training 16KHz dataset by disabling mask_encoder and mask_decoder.
mask_encoder = False,
mask_decoder = False,
I also changed the decoder params...
prenet_layers = [128, 128], # original value - [258, 258]
decoder_layers = 2,  #number of decoder lstm layers
decoder_lstm_units = 512, # original value - 1024
But no alignment after 5K, the align plot looks as below.

Maybe you need to revert your decoding parameters?

@begeekmyfriend it's True that it's often harder to train with masks, as a following of this issue, I set the masks to False as default. Thanks for your contribution :)


Wasm blobs should have different names in debug vs. release

Our build scripts generate a wasm blob to embed into the web server, but right now this blob will be named identically whether you're building in debug or release... which can lead to pretty nasty bugs to track down (e.g. a background cargo check overwriting your release blob without you knowing...).

With this, we now include both the release and debug wasm files when we publish our crates, which more than doubles the crate size (the debug build is larger). Ideally we should only include the release build.


Improve Laravel setup

Is your feature request related to a problem? Please describe.

DDEV does a good job of setting up itself and pre-configuring a Drupal project.
It would be nice if we could automate other frameworks too.
Describe the solution you'd like
After running ddev config in a new Laravel project, there are 2 additional steps required.

Updating PHP version. Addressed in #3588
Updaitng Laravel .env file

# These are the current defaults
APP_URL=http://localhost
DB_CONNECTION=mysql
DB_HOST=<IP_ADDRESS>
DB_PORT=3306
DB_DATABASE=laravel
DB_USERNAME=root
DB_PASSWORD=

Eg. Assuming I create  a new project call phpcs-demo
Test

Start a new Laravel project

laravel new phpcs-demo
cd phpcs-demo

Add DDEV to project, accepting all default

$ ddev config
...
Configuration complete. You may now run 'ddev start'.

Bump DDEV PHP version in ./.ddev/config.yaml

php_version: "8.0"

Config Laravel .env

APP_URL=https://phpcs-demo.ddev.site
DB_CONNECTION=mysql
DB_HOST=ddev-phpcs-demo-db
DB_DATABASE=db
DB_USERNAME=db
DB_PASSWORD=db

This assumes a mysql database, but I think all of these might be ddev variables already?
It would get great if a laravel-project type ddev config could automatically update the .env file too.
Additional context
Ideally, we would want to update other supported frameworks (WP, Magento) but I have no idea how involved those are. A Laravel feels like an easy win to start though.

Thanks for this!
I imagine you're queueing up a PR for this, but reading this issue it's not clear to me what you want to do.

No PR on the way, more of a TODO placeholder
After running ddev config , if  the project type = 'laravel', ddev should update the .env file with its setting.
- APP_URL=http://localhost
+ APP_URL=<DDEV_PRIMARY_URL>
- DB_CONNECTION=mysql
+ DB_CONNECTION=<DDEV_DB_TYPE>
- DB_HOST=<IP_ADDRESS>
+ DB_HOST=<DDEV_DB_HOST>
- DB_PORT=3306
+ DB_PORT=<DDEV_DB_PORT>
- DB_DATABASE=laravel
+ DB_DATABASE=db
- DB_USERNAME=root
+ DB_USERNAME=db
- DB_PASSWORD=
+ DB_PASSWORD=db

Does GO have good filewriting support?

It's happy to write files, and ddev writes oh-so-many. This is the equivalent of what is done in settings.ddev.php.
I imagine there's a reason that I did this in Laravel instead of writing the .env directly, but I don't remember what it was:
https://github.com/drud/ddev/blob/8b38b9e7b53d7026ec2f44f5d01213c7dfb1b1ad/pkg/ddevapp/laravel.go#L22-L34

On 1.19.0-alpha5, is the database type and database port exposed to a host/web command script?
I have a script that adds the URL and "db" for database but I need to change the database driver/port based on the DDEV config.
I want to do something like:
...
        | sed  -E 's/DB_PORT=(.*)/DB_PORT=$DDEV_DB_PORT/g' \
        | sed  -E 's/DB_CONNECTION=(.*)/DB_CONNECTION=$DDEV_DB_TYPE/g' \
        | sed  -E 's/DB_(HOST|DATABASE|USERNAME|PASSWORD)=(.*)/DB_\1=db/g' \

I have a little custom command named "vars" that I use for checking these things:
$ cat vars
#!/bin/bash

set | grep DDEV

It should work fine on host or web (~/.ddev/commands/host or ~/.ddev/commands/web)
Here's what I see on host side:
DDEV_APPROOT=/Users/rfay/workspace/d9
DDEV_DBAIMAGE=phpmyadmin:5
DDEV_DBIMAGE=postgres:14
DDEV_DB_CONTAINER_COMMAND='-c config_file=/etc/postgresql/postgresql.conf -c hba_file=/etc/postgresql/pg_hba.conf'
DDEV_DEBUG=true
DDEV_DOCROOT=web
DDEV_FILES_DIR=/var/www/html/web/sites/default/files
DDEV_GID=20
DDEV_HOSTNAME=d9.ddev.site,mac
DDEV_HOST_DB_PORT=49712
DDEV_HOST_HTTPS_PORT=
DDEV_HOST_WEBSERVER_PORT=
DDEV_LIVE_NO_ANALYTICS=true
DDEV_MAILHOG_HTTPS_PORT=8026
DDEV_MAILHOG_PORT=8025
DDEV_PHPMYADMIN_HTTPS_PORT=8037
DDEV_PHPMYADMIN_PORT=8036
DDEV_PHP_VERSION=7.4
DDEV_PLATFORM_API_TOKEN=_gWx3fGS_qOkA3HJad4jA9ug56d6D7dctAkmv5WTEjU
DDEV_PRIMARY_URL=https://d9.ddev.site
DDEV_PROJECT=d9
DDEV_PROJECT_TYPE=drupal9
DDEV_ROUTER_HTTPS_PORT=443
DDEV_ROUTER_HTTP_PORT=80
DDEV_SITENAME=d9
DDEV_TLD=ddev.site
DDEV_UID=501
DDEV_WEBIMAGE=drud/ddev-webserver:20220227_change_path_environment
DDEV_WEBSERVER_TYPE=nginx-fpm
DDEV_XDEBUG_ENABLED=false
IS_DDEV_PROJECT=true

The docs on available env vars, which may not be perfect, are at https://ddev.readthedocs.io/en/latest/users/extend/custom-commands/#environment-variables-provided

+1 for this, cool idea :-)
Side note for interested readers: I tried to use something like this for APP_URL replace command
ddev exec 'echo ${DDEV_PRIMARY_URL} && cat .env.example | sed -E \\'\s\/APP_URL=(.*)\/APP_URL=${DDEV_PRIMARY_URL}\/g\\'\ > .env'

for the APP_URL, but couldn't get it to work yet because of the escaping of shell commands.
ddev exec "echo ${DDEV_PRIMARY_URL}" # doesn't work, empty output
ddev exec 'echo ${DDEV_PRIMARY_URL}' # works

@mandrasch  yeah, DDEV generate a settings.php for Drupal.
I think we should have a post-install hook, or maybe a custom command that writes back to the .env

+1 for this, cool idea :-)
Side note for interested readers: I tried to use something like this for APP_URL replace command
ddev exec 'cat .env.example | sed -E \\'\s\/APP_URL=(.*)\/APP_URL=${DDEV_PRIMARY_URL}\/g\\'\ > .env'

for the APP_URL, but couldn't get it to work yet because of the escaping of shell/bash commands.
ddev exec "echo ${DDEV_PRIMARY_URL}" # doesn't work, empty output
ddev exec 'echo ${DDEV_PRIMARY_URL}' # works

Side note, now I got it :-)
ddev exec 'sed -i "/APP_URL=/c APP_URL=$DDEV_PRIMARY_URL" .env'

Would love to have you do a PR @mandrasch !

I think we should have a post-install hook, or maybe a custom command that writes back to the .env

This is what we'd ideally like to have for our Craft CMS project type as well. A way to call a function in our integration that runs after ddev project create so we can clean up the .env file.


Update MD file on new branch 2017-23-22_09-11-38

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix timezone bug on win32 platform

RT
Fix bug on win32 that new Date always returns UTC time
in this issue https://github.com/bellard/quickjs/issues/122

I recommend time_t now = time(NULL); Replace with time_t now = (time_t)(time / 1000);. In this way, the parameter name does not need to be changed, and the logical integrity of the function can be guaranteed.

OK thanks for your advice, i have not notices the parameter 😂 will fix later

Finished fix & tested


Fix typos in doc

Fixed import errors in docs

Thank you for your contribution!
If it is convenient for you, please change all nni.feature_engineering in the Overview.rst doc to nni.algorithms.feature_engineering

Hello @OliverShang, thanks for your contribution!
If it is convenient for you, please change all nni.feature_engineering to nni.algorithms.feature_engineering in the docs/en_US/FeatureEngineering/Overview.rst doc, and do not modify the Chinese doc, we will update it in other branch.

Done that, but the FeatureSelector is indeed in nni.feature_engineering.feature_selector, so that part is unchanged.


opentelemetry-collector for loki not match the endpoints of loki addons  in v1.22.2

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
In loki addons (samples/addons/loki.yaml), the path prefix is "/var/loki", but in opentelemetry-collector for loki (samples/open-telemetry/loki/otel.yaml), the loki endpoint is "http://loki.istio-system.svc:3100/loki/api/v1/push". It's not match.
Version
$ istioctl version
client version: 1.22.2
control plane version: 1.22.2
data plane version: 1.22.2 (2 proxies)

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

did you find a real issue for that?

You're right, I was mistaken. There is no problem here.


adding find redeemer by ref

Need a function to find a redeemer data by some output reference

adding find.redeemer_by_ref


Having fails in Query

having 'Door Cnt' = 0 gives Attribute 'Door Cnt' not found
eval 'Door Cnt' = sum(if(equals(field,'value'),1,0))
I’ve used 'Door Cnt' in sort by and table OK
p.s. Also fails for non-derived fields

Raised in Error, field was not defined in extraction.


⚠ Bofrost.si has degraded performance

In d2921ce, Bofrost.si (https://www.bofrost.si) experienced degraded performance:

HTTP code: 200
Response time: 8807 ms

Resolved: Bofrost.si performance has improved in 3a6903a after 303 days, 16 hours, 18 minutes.


I'm having issues using this, please help

I'm new to Cordova and I would like to use webpack with my cordova project using your plugin but I'm having some issues.
Basically I followed your instructions but js files cannot recognize import/require.
I have basically hello world cordova starting app with your plugin. Could you look at it and tell me what I am doing wrong?
I attached my project.
I really appreciate your help.
Archive.zip

@Joseph-Ryu Thanks for using this plugin.
Is the problem solved?
The problem is solved by fixing www/index.html as follows.
-         <script type="text/javascript" src="js/index.js"></script>
+         <script type="text/javascript" src="dist/bundle.js"></script>

Yes I fixed it. Thank you for looking into it still!

That's good!
I'm happy to hear that!


Upstream Clang (12.0.0) support (probably more of ROCm/HIP issue)

I hit some new issue with using hipSYCL compiled against upstream Clang 12.0.0 in OpenSUSE and ROCm 4.2. While hipSYCL compiles with no issues, however it fails to compile any SYCL code using ROCm/HIP backend.
The issue seems to be that upstream Clang does not allow atomics on FP data types and therefore cannot compile "hip_runtime.h" header:

In file included from /opt/rocm/hip/include/hip/hip_runtime.h:60:
In file included from /opt/rocm/hip/include/hip/amd_detail/hip_runtime.h:67:
/opt/rocm/hip/include/hip/amd_detail/hip_atomic.h:60:12: error: address argument to atomic operation must be a pointer to integer or pointer ('float *' invalid)
return __atomic_fetch_add(address, val, __ATOMIC_RELAXED);
/opt/rocm/hip/include/hip/amd_detail/hip_atomic.h:75:12: error: address argument to atomic operation must be a pointer to integer or pointer ('double *' invalid)
return __atomic_fetch_add(address, val, __ATOMIC_RELAXED);

This issue can be resolved by building hipSYCL against Clang/LLVM distributed with ROCm 4.2. In both cases I also have to add HIP include path "-I/opt/rocm/hip/include" to "default-rocm-cxx-flags" in /etc/hipSYCL/syclcc.json.

I don't really know how the ROCm releases work (i.e. which version of Clang they package), but in upstream Clang this commit should lead to the support of this feature, i.e. it will only be released in Clang/LLVM 13+
ROCm seems to package some trunk-based version of Clang somewhere in between 12 and 13 and have adapted their runtime to it..

Hi Filip,
I believe you are right with your suspicion that this is a ROCm/HIP issue rather than a hipSYCL issue. The error seems to be that HIP's hip_atomic.h header uses atomic compiler builtins that are not yet available in mainline clang.
hipSYCL does not call __atomic_fetch_add directly on HIP, instead the hipSYCL atomic implementation for AMD invokes atomicAdd() for fetch add.
As a workaround, you could either downgrade to ROCm 4.0 or 4.1, or use the clang from ROCm. In earlier ROCm versions, atomic add for float types (at least for 64-bit types, not sure about 32) was implemented as CAS loop rather than compiler builtin AFAIR. It seems that ROCm changed this in 4.2, breaking compatibility with earlier clang versions.
Does the error also happen for a basic test program, or it only triggered when actually using atomics?

The problem gets triggered even for example code included with hipSYCL or syclinfo. Unfortunately, it looks like its enough to have HIP headers included by hipSYCL HIP backend without ever using atomics.

Can confirm this, any solution for now?

can confirm

I have this snippet to speed things up
https://gist.github.com/iyadahmed/bcf7f48d1d972a3442b3fb18fa250f12


DEC-268: Next/previous showcase

Adding next/previous showcase to the API. https://github.com/ndlib/beehive/pull/93 depends on this pull.

Coverage decreased (-0.19%) to 94.04% when pulling 8403efa96e4ad9c9e2cbfcdaf2b85aababe1ee00 on DEC-268 into ad75b2ef1ec1537eca4970af3e70dd1e481c71f8 on master.

I'd like to see the hound complaints fixed.  Once that's done, :

Coverage decreased (-0.19%) to 94.04% when pulling 52acf80b24a7a4e20fa58d8b70239d385d81b4fd on DEC-268 into ad75b2ef1ec1537eca4970af3e70dd1e481c71f8 on master.


swap ed25519-dalek for ed25519-zebra

Please see #8764 as it explains all of this.
Fixes #8055
Polkadot burn in: https://github.com/paritytech/polkadot/pull/5747

@bkchr fixed all cicd; should be ready


WatchKit 1.0 apps are no longer installable on this watchOS version.

Hi @degtiarev
I am going to build MotionCollectorWatch to the simulator of apple watch 5series 40nm.
It shows the following issue. Could you please tell me how can I fix this?
Details
This app could not be installed at this time.
Domain: IXUserPresentableErrorDomain
Code: 1
Failure Reason: Could not install at this time.
Recovery Suggestion: WatchKit 1.0 apps are no longer installable on this watchOS version.
WatchKit 1.0 apps are no longer installable on this watchOS version.
Domain: MIInstallerErrorDomain
Code: 133
User Info: {
FunctionName = "-[MIInstallableBundle _isValidWatchKitApp:withVersion:installableSigningInfo:error:]";
LegacyErrorString = UnsupportedWatchKitVersion;
SourceFileLine = 698;
}
System Information
macOS Version 10.15.6 (Build 19G2021)
Xcode 12.1 (17222)

Hi,
I currently don’t have Apple Watch to look at it. Try this solution


feat: migrate to vtprotobuf fork

Part 1 of https://github.com/elastic/apm-data/pull/152
Related to https://github.com/elastic/apm-data/issues/130
Migrate to vtprotobuf fork, regenerate modelpb and return batch events to the vtpool.
The additional go.mod is needed because the fork is still using the original package name so we need a replace directive.

Should the renovate config be updated to handle tools/go.mod?

That go.mod is a temporary solution until the upstream PRs are merged in and we can get rid of the fork.

🤞


keybase login fails with: no auth system available; consider upgrading your client if it's old (error 100)

I upgraded from 1.0.15 to 1.0.16. It couldn't start because it couldn't find my config.json or secretkeys.$USER.mpack (they were in my home directory for some reason). After restoring those files in .config/keybase/ , I tried to log in and got "no auth system available".
my log id: 19df5bf4f756c26c04fc2b1c

We don't support that old version any more since we upgraded our login
system.
How did you get this still quite old version? Our latest version is about 6
months newer
Cc: @oconnor663
On Sun, Jan 15, 2017 at 3:17 PM Adam Bliss<EMAIL_ADDRESS>wrote:

I upgraded from 1.0.15 to 1.0.16. It couldn't start because it couldn't
find my config.json or secretkeys.$USER.mpack (they were in my home
directory for some reason). After restoring those files in .config/keybase/
, I tried to log in and got "no auth system available".
my log id: 19df5bf4f756c26c04fc2b1c
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/5401, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_77lx9i4v5ohZ2gc3afSyz21Qusdks5rSn7RgaJpZM4LkBNx
.

I'm running Ubuntu 14.04 and just did apt-get update through http://dist.keybase.io/linux/deb/repo/

Updating to 1.0.18 seems to have fixed it.

I just installed 64-bit .deb version from https://github.com/keybase/client/blob/master/go/README.md and it says is version 1.0.16 which has this problem. I try to update but I get ERROR No updater available. Could you please update the package or remove it because it is really confusing.

@caisah Thanks, that link is bad/old.  Please use https://keybase.io/download instead.
CC @oconnor663

Woops, thanks for reporting. I've updated those old links.


and how to check that I'm using openai?

`import pandas as pd
import sketch
import os
from dotenv import load_dotenv
os.environ['OPENAI_API_KEY'] = 'key'
os.environ['SKETCH_USE_REMOTE_LAMBDAPROMPT'] = 'False'`
and it doesn't seem to work

One thing you can do is set SKETCH_ENDPOINT_URL to some fake url eg. os.environ['SKETCH_ENDPOINT_URL'] = 'broken', this should cause (when using remote lambdaprompt) an error.
I just checked with a new notebook, and the code you included worked for me (just copy pasted from your question).

Note that it will say (with newest version of sketch, run pip install -U sketch) something along the lines of
No backend set for [completion], setting to default of OpenAI when running off of your own key rather than sending to the endpoint_url, so if you don't see that print statement the first time you run something, then you know there is probably an issue with spelling one of the env vars or something.
Additionally, you can check if a local backend was set up for lambdaprompt by doing
import lambdaprompt as lp
print(lp.backends.backends)

in the case that you are still using remote, lp.backends.backends will be an empty dictionary.
Going to close since this seems like it works, but if you can give me more examples of how its failing you I can re-open the issue.

Looks like its working to me. The fact that it says no backend set means that it defaulted to open-ai and then it finished the completion in local mode.
It shouldn't pop up that warning anymore after that.


Problem of download

I am using ubuntu18 with ros melodic
When I running "rosdep install --from-paths src -i -y --rosdistro $ROS_DISTRO "
It will return:
ERROR: the following rosdeps failed to install
apt: command [sudo -H apt-get install -y ros-melodic-franka-example-controllers] failed
How can I solve that?

ros-melodic-franka-example-controllers: dependency: ros-melodic-panda-moveit-config, but it will not be installed
E: The error cannot be fixed because you require some packages to remain as they are, because they break the dependencies between packages.


Bug: setGenerateType only accepts type = 1

When attempting to create a "flat" profile, I am presented with the following error:

Checking by myself, I noticed the conditional to check if the value is 0 or 1 is wrong.
Current implementation:
 setGenerateType: function (type) {
    const types = [0, 1];
    if (types.indexOf(type) > 0) {
      binding.cpu.setGenerateType(type);
    } else {
      console.error(`type should in [${types.join(', ')}], got ${type}.`);
    }
  },

My suggestion:
 setGenerateType: function (type) {
    const types = [0, 1];
    if (types.indexOf(type) > -1) {
      binding.cpu.setGenerateType(type);
    } else {
      console.error(`type should in [${types.join(', ')}], got ${type}.`);
    }
  },

https://github.com/hyj1991/v8-profiler-next/commit/a8ebd969c6c618af370aebfa7a6ada4d7c85e956

Thank you for your feedback :)


Added back theme upload event

no issue

With the changes in https://github.com/TryGhost/Ghost/commit/79ca6c575c2a10e77ddf618dfb20a571bd4c5655 we removed old unused events
The theme upload event is still used and needed to be put back
Added the event emit right after the successful upload of the theme

The theme upload event is still used

But it looks to me it never worked, right? Because you added the upload emit event just now.
Changes LGTM 👍


Add warning message for deprecated "hashicorp/terraform" provider

Closes #108
What changed

Added the warning message for deprecated "hashicorp/terraform" provider

Why do we need it

Parity terraform and OpenTofu.

Followups

Consider the ports-adapters pattern to facilitate testability, i.e. define adapters to the clients using interfaces.

Add more unit tests. Even if the logic seems simple, there is still a handful of conditions, we can do better when it comes to testing.

@Yantrio @yaronya Hey folks! Could you please have a look? Thanks!

How would you feel about moving this logic out to it's own package?
I think a small package with a function that accepts a namespace + type, and returns errors based on that would be amazing.
In the long run this package could be swapped out easily for something else.
Part of the reason that I raise this is that I feel like it doesn't really belong as a function dangling on ListProvidersPathParams

@Yantrio Hey James! Thanks for a prompt review.

How would you feel about moving this logic out to it's own package?

It's a very reasonable proposal indeed. I'll do the factoring according to it.
Also, post-alpha, we shall how to govern warnings for any arbitrary provider. In other words, how can we make sure that we, as a governing body between the provider's user and the provider's maintainers, keep warnings and any additional provider's info consistently with intentions of the provider's maintainer. For example, shall we warn tofu users when the provider they rely on is deprecated a/k/a fetched from the archived github repo?

Part of the reason that I raise this is that I feel like it doesn't really belong as a function dangling on ListProvidersPathParams

You are absolutely right that ListProvidersPathParams indicates the Rest interface, and as such it shall not be coupled with the logic coupled to the "Provider" object.
WDYT about the module refactoring after the alpha release? I'd like to propose its simplification and clear boundary separation between every app layer. Frankly, our app feel over-complex despite the size of the problem it solves. I highlighted the proposal in the PR description as

Consider the ports-adapters pattern to facilitate testability, i.e. define adapters to the clients using interfaces.

The motivation:

Maintainability;
Testability;
Interoperability through reuse of the packages in other modules, e.g. for CLI we could use in CI.

I like this approach, especially passing the warnings through the context to simplify the function sigs everywhere. I'm happy to merge this.
When it comes to the post-alpha comments above and the TODOs in your code, I think we should raise some issues on this repo so we don't forget them for the long term solution, and each of those can be considered individually at a later date.
As for refactoring, I think it's a good idea and we should look into this, can you raise an issue with some of your comments around this please?

@kislerdm Would you mind fixing the linting issues before we merge please? 🙏 Thanks

@Yantrio

Would you mind fixing the linting issues before we merge please? 🙏 Thanks

Definitely! I also created the issue "placeholder" to configure linting explicitly.

@cube2222 hey Kuba, I support your point of view on explicit declaration, however context binding is a commonly used pattern to propagate information without modifying signatures. In this particular case, I was more inclined towards segregating the warnings handling logic without extending functions' signatures because there are many assumptions about warnings handling/reporting. In other words, I wanted to modify signatures of the least number of functions even though they are private.
All in all, if you'd find this a blocker, I can, of course, refactor. However, I'd rather suggest coming back to this decision post alpha release, because if I understood your comment here, we will have to make more critical decisions about registry. WDYT?

BTW the tf diagnostics is also singleton, but with a better defined concern. We could split warnings propagation into a dedicated diag context moving forward. For example, it'd enable us to report if the provider's repo was archived - find details here.

Hey folks! I refactored the implementation for the sake of simplicity:

Removed implicit warnings propagation in the context. I do agree with Kuba that decision for implicit warnings/diag propagation is premature.
Refactored the initial logic to make the cache-aside strategy more clear for the code reader.
Unified signatures of the "helper functions" which wrap the singleton config.

cc: @Yantrio @cube2222

Hey @Yantrio! Not at all! I'll fix linting error tomorrow.

@Yantrio Hey James! The fix addressing the nil-pointer issue was implemented. Please have a look. Thanks!


Maven integration

Issue #, if available:
AN-974 TinkerPop build Integration via Maven
Description of changes:

Added maven lifecycle to invoke docker and test golang
Added hooks for Godog in maven
Updated docker-compose

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Note: Got a looks good approval in Slack from @xiazcy as well


LineEdit cursor fixes and improvements

Fixed weird text selection behaviours.
Added OSX hotkeys.
Added word jumping with Ctrl+← and Ctrl+→ (Alt instead of Ctrl on OSX).

Fixes #1004

PR is ready :+1:


[20.09] Powerdns backports

Motivation for this change
Backport security fixes to 20.09
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS tests (powerdns, pdns-recursor)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @aanderse @mweinelt

I guess that supersedes https://github.com/NixOS/nixpkgs/pull/100416?

I tested manually dnsdist and everything else looks good.


sales: Iterate on lifecycle stages in HubSpot

Description

Related Issue(s)

Checklist

[ ] I have read the contribution guidelines
[ ] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

@Yndira-E Can you fix the table at: https://deploy-preview-2240--flowforge-website.netlify.app/handbook/customer/hubspot/#lifecycle-stage ? I think the page should just be provided much more space / width

@ZJvandeWeg I made the table scrollable.
I've also opened this PR: https://github.com/FlowFuse/website/pull/2246 to provide more space for content on all handbook and docs pages. Didn't want to do all of that here, since the scope of this PR is a different one.


Selecting 'composer2-php80' for 'composer' failed: The specified version 'composer2-php80' is not valid.

Getting this error on sudo port select composer composer2-php80, though composer2-php IS installed...

@onodera-punpun Which error do you get?
Hint: If you want to select composer2-php80 as you default composer, you'll have to install composer2-php80 (and not composer2-php as you stated)

@onodera-punpun My last comment was nonsense. Your description was not very precise. Nevertheless, I could find a tiny glitch in teh composer-selection configuration. So, please sync this repository with the latest upstream, upgrade all outdated composer-ports and the issue should be solved.
I appreciate any feedback regarding this issue!

Closing due to lack of feedback …