How to limit scale?

How can I limit scale when initialize number or result after calculations?
For example, I wanna set scale as 10 and expect result as below.
If I pass number 10.123451234512345 to create decimal.Big object, I wanna get 10.1234512345.
In this case, this passed value has scale:15. But I wanna set scale limitation anytime.

See Context.

Yes, I've already tried to use Context, but nothing happened, I may've made something mistake though.
I wonder, this test TestDecimal_Format indicates that fmt.Sprintf("%.10f") is used for display of scale setting.
If Content could support scale initially, that format is not needed anymore.

I tried this issue using Context to set maxScale, minScale.
As I expected maxScale and minScale in context seems to be not working now.
Even is scale is set, precision is always prioritized.
I guess that Scale depends on precision in context as far as I tried.
I'm sorry if I made a mistake.

Okay, so to clarify you want to limit the number of digits after the decimal point? Yes, fmt.Sprintf("%.10f", x) will allow you to print x with 10 digits after the decimal point.
Quantize will allow you to change the number of digits after the decimal point.
package main

import (
	"fmt"

	"github.com/ericlagergren/decimal"
)

func main() {
	x, _ := new(decimal.Big).SetString("10.123451234512345")
	fmt.Printf("%0.10f\n", x)
	x.Quantize(10)
	fmt.Println(x)
}

@ericlagergren
I got it tanks to it. Thus this issue is closed.


Support for Toggl Button in Kanbanery

A support for Kanbery would be really nice:
https://kanbanery.com/

Added with #424


chore: 🤖 run lint-staged on pre-commit hook

remove pretty-quick from pre-commit hooks and replace it with lint-staged
configure lint-staged linters for .js, .json, .md files
add format script to format the whole codebase (to be used when needed)

closes #788

The CI failed cause I've removed the format-check script from package.json,
I think it's fine to just run Eslint in the CI pipelines since it's already configured to check prettier rules as well via the eslint-plugin-prettier.
any suggestions?

Oh. Hmmm shoot. I guess we should've waited until https://github.com/iterative/dvc.org/pull/776/files was merged because it introduces lint-staged without .lintstagedrc.json (configured in package.json) and changes the lint script name to lint-check.

[ ] But OK let's keep working on it and I'll take care of resolving conflicts later...

@theashraf first of all thanks again for your contribution!

The CI failed cause I've removed the format-check script...

On this, please notice https://github.com/iterative/dvc.org/pull/790#pullrequestreview-317185114, and then we just need to remove that step from .circleci/config.yml for the CI to work again 🙂

Ah wait no. I need to think about removing the format-check script actually... I'll get back to you.

I think it's fine to just run Eslint in the CI pipelines...

OK yeah all good. We do want to run Prettier separately as a CI check, but we simply need to update the format-check run stage in .circleci/config.yml to use format now. Please. Thanks!

we simply need to update the format-check run stage in .circleci/config.yml to use format now.

I've done this in my recent merge from master.

@jorgeorpinel I think that using git add here is ok. prettier shouldn't try to change anything that will break the code, and I don't see a lot of meaning for the developer to manually check prettier fixes, because we are forcing them anyway. So even if they didn't like the changes, it's not like that they can do something about it.

Thanks Alexey. Agree with you again. Let's just see if lint-staged provides a way to "bail", like pretty-quick did. (Waiting for okonet/lint-staged/issues/730.) Although, yet another option is simply to keep pretty-quick... I'l check with Ivan directly about this.

UPDATE: No updates 🙁
I just pinged the lint-staged guys again (https://github.com/okonet/lint-staged/issues/730#issuecomment-559260063). If there's no answer this week we'll just make an executive decision here.

UDPATE: The lint-staged guys are actually implementing this 😬 See okonet/lint-staged/pull/745

So unfortunately the lint-staged guys ended up changing their minds about implementing this so let's keep pretty-quick --bail for now? I think it's important being able to know what you're committing without automatic git add. We can keep this PR alive (will get stale but oh well) to check for future versions of lint-staged though, as they hinted maybe they'll try to implement in a future version.

p.s. apologies to @theashraf who was great at submitting this PR. This is very rare that we don't end up merging them, especially when they come from an open issue (which I'm closing for now, BTW).
Abdelrahman, if you're interested in any other issue please feel free to check with me or anyone on the team (#dev-docs channel of our chat before having a go just so we double check the issue validity. Again, this situation is very rare, in fact it's the first time it happens that I'm aware. But still, sorry!

Closing this, @jorgeorpinel , right?

OK in that case I'll reopen the issue and relabel it. I guess that makes more sense.


mod_ldap: Use the LDAP API directly to implement the rebind callback

mod_ldap: Use the LDAP API directly to implement the rebind callback
for modern versions of OpenLDAP, avoiding the overhead of the apr-util
implementation.

* modules/ldap/util_ldap.c:
  Define USE_APR_LDAP_REBIND if a modern version of OpenSSL is used.
  (uldap_rebind_proc): New function.
  (uldap_rebind_init, uldap_rebind_add): Define, using either the
  callback or the (bad) APR-util versions.
  (uldap_connection_unbind): Clear the rebind pool to remove rebind
  references prior to destroying the LDAP *.
  Omit for !USE_APR_LDAP_REBIND.
  (uldap_connection_init): Use new wrappers, only create the rebind
  pool if USE_APR_LDAP_REBIND.

* include/util_ldap.h: Don't include apr_ldap_rebind.h here.

PR: 64414

I can no longer get referrals to happen on my system but +1

Do you mean they have broken, or you can't get the test setup configured @covener? I am going to try with a referrals config here.

Sorry not broken, my hack test  LDAP server with a referral shoved into the search tree no longer "simulates MSAD" like it used to so no referral goes on the wire.


vscode-insiders: Change to a static url and hashes

Description
VSCode-Insiders seems to use a "canary-build" version and new "file" replace the current version of file (for example 1.57.0-insider). Because of that, since the URL and version didn't changed the hashes wasn't updated by the "excavator Actions".
This "tweak" change finds the exact location of a version and will use it until the next version changes (minor, major or patch)
Also, we changed the registry files location to use this repository instead of an external
Related Tickets & Documents
Not related
Did you
Check Hashes?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Check Url?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Check the last version?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added a description in the manifest?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Beautified the json manifest format?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added some notes in the manifest?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added/Needed any dependencies?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Added/Needed any pre-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Added/Needed any post-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

[optional] What gif/emoji best describes this PR or how it makes you feel?
:disappointed:

Your changes do not pass checks.
vscode-insiders

[x] Description
[x] License
[ ] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction

/verify

All changes look good.
Wait for review from human collaborators.
vscode-insiders

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction


if shell-general-graph-creation-cluster.js is ran with coverage instrumented binaries, this test will not finish any time soon

Scope & Purpose
creating the maximum number of available shards with the preconfigured number of replications is quiet resource intense.
Disable replication for this test, since it primarily wants to check whether the limit is respected.

gcov instrumented binaries perform way slower than regular binaries. Hence this runs into a timeout.
A Probable better solution would be to pin-point this to replication_factor=1 unconditionally if the API permits that.

@dothebart Can you do it only for gcov? for an example in gcov build you can set some environment variable.
I don't think it's an a good idea to disable replication in some tests.

I did that first - internal.coverage - However, I don't think that replication in this case is functional part of this test - but the bottleneck.

I fully agree with @dothebart here! These tests are also among the longest running in CircleCI. Since replication isn't really a relevant aspect of these tests I also think we should just disable it. BTW: there is also a similar enterprise test

Blue except for unrelated arangosearch test error


Get the uri of every track in of playlist

I want to check if an track is already exists in a playlist but I cant find a method to get all uris of the tracks that are in a playlist.
I tried it with these function:
Paging<PlaylistTrack> playlistsItems = spotifyApi.getPlaylistsItems(playerlistId).build().execute();

Please use code tags for code. I've added them for you:
```java
Paging<PlaylistTrack> playlistsItems = spotifyApi.getPlaylistsItems(playerlistId).build().execute();
```

You're using the correct endpoint for what you're trying to achieve!
Reading the docs for it you can see that you'll receive a Paging object, as you wrote. That one contains a property items which, following the documentation, can contain "an array of track objects and episode objects". So typecast your instances to Tracks and voila: you can access the tracks' URIs :)

Thank you. :)


add Maza support

please do this kind of PRs to the original repo https://github.com/spesmilo/electrumx


Collab page enhancement + live chat + homepage

Description

Add homepage, which includes a table for users to view/rejoin their active sessions.
Add chat functionality for collab.
Add line wrap for editor.
Add language selection, which auto syncs for both users.
Update splitter to highlight on hover.
Add more languages to codemirror.
Allow indentation with tab key.
Add more languages for code formatters. I tried my best and currently this only supports the following: java, javascript, PHP, XML, rust, SQL. This is 6/18 languages currently available in the editor.
Update default path to /home. (including logo click) .

Checklist

[x] Collab page enhancement
[x] Rejoin sessions/homepage
[x] Chat

Screenshots (if applicable)

Will be closing this PR.


Create Polygon with multiple Point

DotSpatial version: latest Version
I have multiple latitude and longitude point with order number in my DB now I just want create one simple polygon shp file in my Web Project.I read this Example but I dont Understand Completely.
this is my Point for Example:
order Nmber       latitude                           longitude
1                         48.9160041021872           27.5997012829732
2                         48.9163221021872           27.5997312821732
3                         48.9130241021872           27.5997912821632
4                         48.9165641021872           27.5997112821132
1-which one become center according to sample Code in this line?
Coordinate center = new Coordinate((rnd.Next(50) * 360) - 180, (rnd.Next(60) * 180) - 90);
2-this ii is next latitude and longitude points ?
coord[ii] = new Coordinate(center.X + Math.Cos((ii * 10) * Math.PI / 10), center.Y + (ii * 10) * Math.PI / 10);

Just put all your coordinates in a coordinate array and add the first point again as last point. Then use them to create a LinearRing that you can use to create your polygon.
            FeatureSet fs = new FeatureSet(FeatureType.Polygon);

            Coordinate[] coord = new Coordinate[]
            {
                new Coordinate(48.9160041021872, 27.5997012829732),
                new Coordinate(48.9163221021872, 27.5997312821732),
                new Coordinate(48.9130241021872, 27.5997912821632),
                new Coordinate(48.9165641021872, 27.5997112821132),
                new Coordinate(48.9160041021872, 27.5997012829732) //repeat the first coordinate to make sure the polygon is closed
            };

            fs.Features.Add(new Polygon(new LinearRing(coord)));

tnx alot for your help jany-tenaj.
1-latitude is first parameter and longitude is second parameter of coordinate .is it correct?
2-I have a list of Data that each Data have a list of Geographic Coordinate, Each Data may have point or line or polygon Geographic Coordinate.is it ok if i define this two class this way and add it(point or Line or polygon) to FeatureSet ?

  Feature f = new Feature();
  FeatureSet fs = new FeatureSet(f.FeatureType);
// a foreach in Data that each Data have A list Of Geographic Coordinate

// if it is PolyGon
 var pg = new Polygon(new LinearRing(coord));  //coord is list of Coordinate
  fs.Features.Add(pg);
// if it is Line
  LineString ls = new LineString(coord); //coord is list of Coordinate
   fs.Features.Add(ls);
// if it is Point
  Coordinate c = new Coordinate(Lat, Lang);
   fs.Features.Add(c);

No idea what the correct order would be as I've never worked with them before.
Make sure that you have one featureset for polygons, one for lines and one for points. Don't put polygons, lines and points into the same featureset. Otherwise the posted code looks ok.

tnx jany-tenaj again for your help.
i cant make one featureset for polygons, one for lines and one for points.
because i want one final shp file.i create shp file with this line of code.what can i do?
fs.SaveAs(fileAddress, true);

According to their definition shapefiles can only contain a single feature type. So if you want to export polygons, lines and points to shapefile, you'll have to create one shapefile for each feature type.
What exactly is your problem with the code you posted?

Based on the Esri Shapefile Technical Documentation page 4 paragraph 2:

All the non-Null shapes in a shapefile are required to be of the same shape type.

that is not possible. So you either create one shapefile for polygons, one for lines and one for points or use some other way to export your shapes.

you are correct.
last question: how can i Instead of save shp file save it to memoryStream ?

I'm not sure but I think you'll have to write your own method for that.
Have a look at the SaveAs method of PolygonShapefile for example.

I will check it if i have any question i will ask it in new issue.tnx for jany-tenaj help


Foreign Key with Data Annotations

Is it still relevant that Foreign keys  can't be created using Data Annotations?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6c8f247-1832-aac8-b783-7b9ba3337110
Version Independent ID: 5120ef68-7b31-cdce-372d-4aa3ef497be2
Content: Foreign Key Constraints - EF Core
Content Source: entity-framework/core/modeling/relational/fk-constraints.md
Product: entity-framework
GitHub Login: @rowanmiller
Microsoft Alias: divega

I don't think so, this seems to work:
[ForeignKey("Blog")]
public int PostId { get; set; }

Doesn't seem to work for me with regards to using data annotations as Daniel did.
using Microsoft.EntityFrameworkCore & System.ComponentModel.DataAnnotations after performing a successful dotnet add package Microsoft.EntityFrameworkCore.Relational still throws an error for 'ForeignKey' and 'ForeignKeyAttribute' not being found. Thought, I am really just trying to throw stuff together because the documentation, it seems, is right here and says you can't.


Consumables don't consume themselves

Tried a few different settings from serums to food to poisons etc, nothing seems to expend the charges.
FoundryVTT v10.291
Starfinder V0.22.1

Was fixed as part of #1018


Registration

Add registration
Add email confirmation

Btw: the sonaqube check action is a bit buggy after all. It failes if the pull request was anlready analyzed. I opened an issue in the owners repo, if you're interested (https://github.com/kitabisa/sonarqube-action/issues/16).


When new Twitter profile and banner photos are retrieved, also update Voter Guide & Organization

We cache a voter's photos in a Voter Guide, Organization, and Position. When new Twitter profile and banner photos are retrieved, we should update the photos in all of the cached locations in a refresh function. We have some refresh/migration routines that could be upgraded or used.
We have done some work on this, and started an audit here:
https://docs.google.com/document/d/1Lz-JQOBYAYB0em0MNw8gMMUv-5KMuwuJT4-IfXMcb0A/edit#heading=h.400eehwfn2sb

Got this done for Organization in #377

@DaleMcGrew  So from the previous PR, Organization gets its twitter info and we_vote_hosted_profile_image_url_... from twitteruser.
In voter_guide/models in update_or_create_organization_voter_guide_by_election_id you receive an organization_we_vote_id that has no column in twitteruser, and it pulls from organization (which now pulls from twitteruser).
Is this existing code good enough?  If so this issue is done.

Done


It cannot pack some property.

When I use CSS property -webkit-box-orient in my mixin.scss, this property cannot be found in the Chrome pannel after build. So that property cannot work in my app.

Please provide a repo, ideally with codesandbox -> https://template.nuxtjs.org/


Error trying to load PRMan for Blender on version 2.78a

Hello,
I've been getting the following error installing the PRMan addon in Blender version 2.78a on a PC running Win 10.   Any help would be greatly appreciated.
-Dave
Traceback (most recent call last):
File "C:\Program Files\Blender Foundation\Blender\2.78\scripts\modules\addon_utils.py", line 349, in enable
mod.register()
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78\scripts\addons\PRMan-for-Blender-master_init_.py", line 118, in register
load_addon()
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78\scripts\addons\PRMan-for-Blender-master_init_.py", line 94, in load_addon
if guess_rmantree():
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78\scripts\addons\PRMan-for-Blender-master\util.py", line 543, in guess_rmantree
throw_error("Error loading addon using RMANTREE=%s.  RMANTREE must be version 21.0 or greater.  Correct RMANTREE setting in addon preferences." % rmantree)
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78\scripts\addons\PRMan-for-Blender-master\util.py", line 58, in throw_error
raise ImportError(msg)
ImportError: Error loading addon using RMANTREE=C:\Program Files\Pixar\RenderManProServer-20.11.  RMANTREE must be version 21.0 or greater.  Correct RMANTREE setting in addon preferences.

Sorry, I updated the plugin for the impending NCR release of RenderMan 21
tomorrow.  If you're using with a 20.X version of renderman download from
here:
https://github.com/bsavery/PRMan-for-Blender/tree/20.X
Or wait till tomorrow and install 21 ;)
On Mon, Nov 14, 2016 at 7:52 PM, davidKertesz<EMAIL_ADDRESS>wrote:

Hello,
I've been getting the following error installing the PRMan addon in
Blender version 2.78a on a PC running Win 10. Any help would be greatly
appreciated.
-Dave
Traceback (most recent call last):
File "C:\Program Files\Blender Foundation\Blender\2.78
scripts\modules\addon_utils.py", line 349, in enable
mod.register()
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78
scripts\addons\PRMan-for-Blender-master_init.py", line 118, in register
load_addon()
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78
scripts\addons\PRMan-for-Blender-masterinit_.py", line 94, in
load_addon
if guess_rmantree():
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78
scripts\addons\PRMan-for-Blender-master\util.py", line 543, in
guess_rmantree
throw_error("Error loading addon using RMANTREE=%s. RMANTREE must be
version 21.0 or greater. Correct RMANTREE setting in addon preferences." %
rmantree)
File "C:\Users\david_000\AppData\Roaming\Blender Foundation\Blender\2.78
scripts\addons\PRMan-for-Blender-master\util.py", line 58, in throw_error
raise ImportError(msg)
ImportError: Error loading addon using RMANTREE=C:\Program Files\Pixar\RenderManProServer-20.11.
RMANTREE must be version 21.0 or greater. Correct RMANTREE setting in addon
preferences.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/373, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABzffG6WID2nP0WUEUphkF5sY2caZl1pks5q-SyKgaJpZM4KyGa1
.

--
<EMAIL_ADDRESS>508-274-8700

Cool thanks for the update, I'll wait for updated release.
Cheers :)

Hi Brian,
I installed Blender 2.78a and Renderman 21.2 but when I rty to enable PRman I get:
Traceback (most recent call last):
File "C:\Program Files\2.78\scripts\modules\addon_utils.py", line 349, in enable
mod.register()
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77\scripts\addons\PRMan-for-Blender-master_init_.py", line 91, in register
from . import properties
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77\scripts\addons\PRMan-for-Blender-master\properties.py", line 467, in
class RendermanSceneSettings(bpy.types.PropertyGroup):
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77\scripts\addons\PRMan-for-Blender-master\properties.py", line 970, in RendermanSceneSettings
items=get_integrator_names(),
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77\scripts\addons\PRMan-for-Blender-master\properties.py", line 50, in get_integrator_names
for f in os.listdir(args_path)]
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'C:\Program Files\Pixar\RenderManProServer-21.2\lib\RIS\integrator\Args'
I browsed in the RenderManProServer-21.2  directory and it is true that path does not exist. Should I reinstall 21.2? Thanks in advance

You're using an older version of the addon I think.  Update to the latest
master branch.
On Wed, Nov 16, 2016 at 4:13 PM, JSKjaer<EMAIL_ADDRESS>wrote:

Hi Brian,
I installed Blender 2.78a and Renderman 21.2 but when I rty to enable
PRman I get:
Traceback (most recent call last):
File "C:\Program Files\2.78\scripts\modules\addon_utils.py", line 349, in
enable
mod.register()
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77
scripts\addons\PRMan-for-Blender-master_init_.py", line 91, in register
from . import properties
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77
scripts\addons\PRMan-for-Blender-master\properties.py", line 467, in
class RendermanSceneSettings(bpy.types.PropertyGroup):
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77
scripts\addons\PRMan-for-Blender-master\properties.py", line 970, in
RendermanSceneSettings
items=get_integrator_names(),
File "C:\Users\Joe\AppData\Roaming\Blender Foundation\Blender\2.77
scripts\addons\PRMan-for-Blender-master\properties.py", line 50, in
get_integrator_names
for f in os.listdir(args_path)]
FileNotFoundError: [WinError 3] The system cannot find the path specified:
'C:\Program Files\Pixar\RenderManProServer-21.2\lib\RIS\integrator\Args'
I browsed in the RenderManProServer-21.2 directory and it is true that
path does not exist. Should I reinstall 21.2? Thanks in advance
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/373#issuecomment-261114666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffINCPPQjUV8y-yXSCji8fty2U63Xks5q-5wygaJpZM4KyGa1
.

--
<EMAIL_ADDRESS>508-274-8700

thanks Brian, I noticed that Blender 2.78 was still going to 2.77 subdirectory for some reason. Until I figure out why, I replaced PRMan in the 2.77 dir and all is good  (cockpit error ) :)

No worries.  Yeah sometimes I've noticed that, not sure why Blender does it...

21.2 is looking awesome so far, thanks to you and the team

So we can close this?

FYI, the new 21 is working for me now.  Thanks for everything guys, it looks great.

Fantastic. Closing.


run on start if api disabled and corn enabled

Fixes: #473

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 8 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 59.206%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/sync/sync.go
0
8
0.0%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.09%

Covered Lines:
1238

Relevant Lines:
2091

💛  - Coveralls


there is no step 4

"If you are using Jubilinux 0.3.0 (Debian Stretch) or the Raspberry Pi, please skip to #4. If you are using Jubilinux 0.2.0 (Debian Jessie), you will need to manually initialize bluetooth. (click here to expand instructions)"
There is no step 4 that  I can find ...
What are the steps for  Jubilinux 0.3.0 ?

@dougboss resolved via https://github.com/openaps/docs/pull/1521, the docs are now updated (the formatting dropped). PS - in future you can open an issue in https://github.com/openaps/docs/issues if you spot issues with the docs but don't have a proposed fix. Thanks for flagging it!


Asserting that the shift key isn't being held down

In the example holding down shift whilst pressing enter adds the tag, when in reality that key combination is technically different from just enter.
For the above example it doesn't matter too much, but when you set your delimiter to tab for instance, then you're unable to enter < into the textbox because the keyCode for , is the same as < and thus takes it as the delimiter.
This change ensures the shift isn't being held down. Interestingly I couldn't find any tests for addTag and so I didn't add a test for this PR. Existing tests pass just fine.
I don't imagine this change will affect anybody as it really is an edge-case, however it is a breaking change.

Sorry for the late update on this, Adam. I was travelling so didn't get a chance earlier to look at this.

but when you set your delimiter to tab for instance, then you're unable to enter < into the textbox because the keyCode for , is the same as < and thus takes it as the delimiter

Pardon my ignorance here, but how does adding the check you added (i.e. removing shift-key) fix this problem?
Thanks for the PR, though :)

Sorry, it should read "when you set your delimiter to , for instance".
Comma and < share the same keyCode — alternatively use http://caniuse.com/#search=KeyboardEvent.key.

Ah ok! Thanks for clarifying! :)

Thanks!


mev-boost: command not found

Platform: linux arm64
After runnning command 'go install github.com/flashbots/mev-boost@latest' without errors, how to run mev-boost? I cannot locate the excution file. Console says mev-boost: command not found

@tunlong  ./mev-boost

@tunlong ./mev-boost

Not working. I can't find the excution file under home folder, do you konw where I can locate the file?


workflows: Run git submodule update --init --recursive failed

Run git submodule update --init --recursive
Submodule 'libs/MUTILS' (https://github.com/UnknownBugs/MUTILS.git) registered for path 'libs/MUTILS'
Submodule 'libs/TDEBUG' (https://github.com/UnknownBugs/TDEBUG.git) registered for path 'libs/TDEBUG'
Submodule 'libs/TMATH' (https://github.com/UnknownBugs/TMATH.git) registered for path 'libs/TMATH'
Submodule 'platform/uefi/UEFIWrapper' (https://github.com/UnknownBugs/UEFIWrapper.git) registered for path 'platform/uefi/UEFIWrapper'
Cloning into '/home/runner/work/TUGUI/TUGUI/libs/MUTILS'...
fatal: could not read Username for 'https://github.com': No such device or address
fatal: clone of 'https://github.com/UnknownBugs/MUTILS.git' into submodule path '/home/runner/work/TUGUI/TUGUI/libs/MUTILS' failed
Failed to clone 'libs/MUTILS'. Retry scheduled
Cloning into '/home/runner/work/TUGUI/TUGUI/libs/TDEBUG'...
fatal: could not read Username for 'https://github.com': No such device or address
fatal: clone of 'https://github.com/UnknownBugs/TDEBUG.git' into submodule path '/home/runner/work/TUGUI/TUGUI/libs/TDEBUG' failed
Failed to clone 'libs/TDEBUG'. Retry scheduled
Cloning into '/home/runner/work/TUGUI/TUGUI/libs/TMATH'...
fatal: could not read Username for 'https://github.com': No such device or address
fatal: clone of 'https://github.com/UnknownBugs/TMATH.git' into submodule path '/home/runner/work/TUGUI/TUGUI/libs/TMATH' failed
Failed to clone 'libs/TMATH'. Retry scheduled
Cloning into '/home/runner/work/TUGUI/TUGUI/platform/uefi/UEFIWrapper'...
Cloning into '/home/runner/work/TUGUI/TUGUI/libs/MUTILS'...
fatal: could not read Username for 'https://github.com': No such device or address
fatal: clone of 'https://github.com/UnknownBugs/MUTILS.git' into submodule path '/home/runner/work/TUGUI/TUGUI/libs/MUTILS' failed
Failed to clone 'libs/MUTILS' a second time, aborting
Error: Process completed with exit code 1.

https://github.com/UnknownBugs/TUGUI/runs/4580841988?check_suite_focus=true

name: Makefile CI

on:
  push:
    branches:
    - main
    - dev
  pull_request:
    branches:
    - main
    - dev
jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
    - name: sync code
      run: git submodule update --init --recursive
    - name: 配置环境
      run: sudo apt-get install g++-mingw-w64-x86-64 -y
    - name: 编译所有测试模块
      run: make
    - uses: actions/upload-artifact@master
      with:
        name: 导出二进制文件
        path: ./bin

issue links: #46

查看https://github.com/UnknownBugs/TUGUI/pull/52#issuecomment-998888620
应该是这个问题


Fix protocol schedule for devnets

PR description
Introduces a hard fork id into the protocol schedule and keeps track of all the hardforks in the genesis file. This allows correct checks in the engine API if certain hardforks have already occured or not.
Fixed Issue(s)
fixes #7413
Testing
After running ./gradlew distDocker the PR can be tested with the following Kurtosis config:
participants:
  - el_type: besu
    el_image: hyperledger/besu:24.8-develop-6fd65ec
    cl_type: teku
    cl_image: ethpandaops/teku:master
    count: 1
  - el_type: besu
    el_image: hyperledger/besu:24.8-develop-6fd65ec
    cl_type: nimbus
    cl_image: statusim/nimbus-eth2:amd64-latest
    count: 1
network_params:
  electra_fork_epoch: 1
  min_validator_withdrawability_delay: 1
  shard_committee_period: 1
additional_services:
  - dora
snooper_enabled: true

To get the log output of the Besu instances in Kurtosis use:
# 1. instance
docker logs `docker ps | grep besu: | sed -n 1p | cut -d " " -f1`

# 2. instance
docker logs `docker ps | grep besu: | sed -n 2p | cut -d " " -f1`

Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

verified successful block production using kurtosis provided above.

2024-08-12 09:32:45.102+00:00 | vert.x-worker-thread-0 | INFO  | MergeCoordinator | Start building proposals for block 12 identified by 0x0342148f02e3e038
2024-08-12 09:32:57.048+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineNewPayload | Imported #12 / 0 tx / 0 ws / 0 blobs / base fee 201.42 mwei / 0 (0.0%) gas / (0x1ca204099b11549a813a9b56087f5004098009da933184958a4deada23d89dab) in 0.002s. Peers: 1
2024-08-12 09:33:09.084+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineNewPayload | Imported #13 / 0 tx / 0 ws / 0 blobs / base fee 176.24 mwei / 0 (0.0%) gas / (0xcae3e37b14b0b76d35add2702165a652ba6222fe8ddd2680eb53ee424a6e92e0) in 0.002s. Peers: 1
2024-08-12 09:33:09.091+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineForkchoiceUpdated | VALID for fork-choice-update: head: 0xcae3e37b14b0b76d35add2702165a652ba6222fe8ddd2680eb53ee424a6e92e0, finalized: 0x95cd143de892722f42572cb89308c9f055664ff613b01ec38a4fe9fed43a2d67, safeBlockHash: 0x95cd143de892722f42572cb89308c9f055664ff613b01ec38a4fe9fed43a2d67
2024-08-12 09:33:21.096+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineNewPayload | Imported #14 / 0 tx / 0 ws / 0 blobs / base fee 154.21 mwei / 0 (0.0%) gas / (0x8cbd215ed19d6e2608a1203969c117582ad5c8a46898024bdea6695e0a7f2f22) in 0.001s. Peers: 1
2024-08-12 09:33:21.105+00:00 | vert.x-worker-thread-0 | INFO  | MergeCoordinator | Start building proposals for block 15 identified by 0x4f6c8d91ddcb8dec
2024-08-12 09:33:33.045+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineNewPayload | Imported #15 / 0 tx / 0 ws / 0 blobs / base fee 134.93 mwei / 0 (0.0%) gas


Remove Dockerfile.integration - not used - reduce confusion

Remove Dockerfile.integration
Description
This issue updates the builder used for creating the image for e2e tests from Dockerfile.integration
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

/lgtm


Add CI -race and OSX tests; update CI Golang version

I'm an OS X user, so I know the tests are passing on OSX; however, when running with -race they are not.  I thought it might be useful to add to CI as a separate step.
Additionally, the .travis.yml file only tests up to Go1.6.

Travis CI claims that go is not available on their OSX platforms.  Not sure why that is.


setting default_auto_field in AppConfig

to avoid unnecessary migrations with Django 3.2 as the default will change to BigAutoField

related docs - https://docs.djangoproject.com/en/3.2/releases/3.2/#customizing-type-of-auto-created-primary-keys

Merged, thanks !


Player can't take screenshots in multiple save files without restarting game

Description of Bug
The player cannot take screenshots in multiple save files without restarting the game.
Steps to Reproduce
Steps to reproduce the behavior:

Have a screenshot taken in a save file.
Return to title screen and select a different save file.
Attempt to have a screenshot taken.
Notice that no screenshot is taken.

Expected behavior
Player should not have to restart the game in order for automatic screenshots to work in different save files.

Resolved by #13, closing.


Runtime Erro

Hello, I am using this gem for my project. It worked fine when I instilled it. After few days when I re-run my scripts then it gave me this error message. I am not sure how can I fix this issue. Error messages that I got is as follow:
[WARN] RAutomation AutoIt adapter is DEPRECATED and will be removed in the future!
RuntimeError: Start Ruby with administrative rights when using AutoIt adapter for the first time.
Any kind of help would be appreciated.
Here is my scrript:
window = RAutomation::Window.new(:title => /Enter name of file to save to/i)
window.activate
puts window.exists? # => true
sleep 2
window.send_keys(:tab)
window.send_keys(:enter)

Hello!
It seems that you want to try AutoIt adapter for some reason, which is deprecated (although works). If you want to use that, then you need to run script with administrator rights for the first time to register dll-s in the system required for AutoIt.
The question is though, why do you want to use AutoIt adapter? Is there anything missing in the default adapter?
Since it doesn't show in code, then I guess you have an environment variable called RAUTOMATION_ADAPTER set. Just remove it and start using default adapter instead. Or do the trick with running administrative privileges as stated above.

Closing this due to inactivity.


No vboxsf mounts when running docker-machine from Linux

This might be an issue in boot2docker but I only could reproduce it with docker-machine, so here we go:
Two files in one folder
$ ls
docker-compose.yml  it-works.txt

# docker-compose.yml
test:
  image: busybox
  volumes:
    - .:/test

(it-works.txt is just an empty file to check)
On a Linux host
$ docker-machine create --driver virtualbox bug
[…]
$ eval "$(docker-machine env bug)"
[…]
$ docker-compose run test sh -c 'ls -lsa ./test'
total 4
     0 drwxr-xr-x    2 root     root            40 Oct 22 21:04 .
     4 drwxr-xr-x   19 root     root          4096 Oct 22 21:34 ..

On an OS X host
$ docker-machine create --driver virtualbox bug
[…]
$ eval "$(docker-machine env bug)"
[…]
$ docker-compose run test sh -c 'ls -lsa ./test'
total 8
     0 drwxr-xr-x    1 1000     staff          136 Oct 22 21:05 .
     4 drwxr-xr-x   19 root     root          4096 Oct 22 21:09 ..
     4 -rw-r--r--    1 1000     staff           66 Oct 22 21:05 docker-compose.yml
     0 -rw-r--r--    1 1000     staff            0 Oct 22 21:05 it-works.txt

If I compare both machines, I see that machine on OS X has mounted /Users:
docker@bug:~$ mount
tmpfs on / type tmpfs (rw,relatime,size=918072k)
proc on /proc type proc (rw,relatime)
sysfs on /sys type sysfs (rw,relatime)
devpts on /dev/pts type devpts (rw,relatime,mode=600,ptmxmode=000)
tmpfs on /dev/shm type tmpfs (rw,relatime)
fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
/dev/sda1 on /mnt/sda1 type ext4 (rw,relatime,data=ordered)
cgroup on /sys/fs/cgroup type tmpfs (rw,relatime,mode=755)
cgroup on /sys/fs/cgroup/cpuset type cgroup (rw,relatime,cpuset)
cgroup on /sys/fs/cgroup/cpu type cgroup (rw,relatime,cpu)
cgroup on /sys/fs/cgroup/cpuacct type cgroup (rw,relatime,cpuacct)
cgroup on /sys/fs/cgroup/blkio type cgroup (rw,relatime,blkio)
cgroup on /sys/fs/cgroup/memory type cgroup (rw,relatime,memory)
cgroup on /sys/fs/cgroup/devices type cgroup (rw,relatime,devices)
cgroup on /sys/fs/cgroup/freezer type cgroup (rw,relatime,freezer)
cgroup on /sys/fs/cgroup/net_cls type cgroup (rw,relatime,net_cls)
cgroup on /sys/fs/cgroup/perf_event type cgroup (rw,relatime,perf_event)
cgroup on /sys/fs/cgroup/net_prio type cgroup (rw,relatime,net_prio)
none on /Users type vboxsf (rw,nodev,relatime)
/dev/sda1 on /mnt/sda1/var/lib/docker/aufs type ext4 (rw,relatime,data=ordered)

while the Linux has no vboxsf mounts or /home mounts
docker@bug:~$ mount
tmpfs on / type tmpfs (rw,relatime,size=918064k)
proc on /proc type proc (rw,relatime)
sysfs on /sys type sysfs (rw,relatime)
devpts on /dev/pts type devpts (rw,relatime,mode=600,ptmxmode=000)
tmpfs on /dev/shm type tmpfs (rw,relatime)
fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
/dev/sda1 on /mnt/sda1 type ext4 (rw,relatime,data=ordered)
cgroup on /sys/fs/cgroup type tmpfs (rw,relatime,mode=755)
cgroup on /sys/fs/cgroup/cpuset type cgroup (rw,relatime,cpuset)
cgroup on /sys/fs/cgroup/cpu type cgroup (rw,relatime,cpu)
cgroup on /sys/fs/cgroup/cpuacct type cgroup (rw,relatime,cpuacct)
cgroup on /sys/fs/cgroup/blkio type cgroup (rw,relatime,blkio)
cgroup on /sys/fs/cgroup/memory type cgroup (rw,relatime,memory)
cgroup on /sys/fs/cgroup/devices type cgroup (rw,relatime,devices)
cgroup on /sys/fs/cgroup/freezer type cgroup (rw,relatime,freezer)
cgroup on /sys/fs/cgroup/net_cls type cgroup (rw,relatime,net_cls)
cgroup on /sys/fs/cgroup/perf_event type cgroup (rw,relatime,perf_event)
cgroup on /sys/fs/cgroup/net_prio type cgroup (rw,relatime,net_prio)
/dev/sda1 on /mnt/sda1/var/lib/docker/aufs type ext4 (rw,relatime,data=ordered)

What it does have though, is an empty folder at exactly the same location that the host has:
docker@bug:~$ find /home/bascht/
/home/bascht/
/home/bascht/Documents
/home/bascht/Documents/Code
/home/bascht/Documents/Code/docker-machine-bug

Both Mac OS and Linux are using docker-machine 0.4.1 and docker-compose version 1.4.2 with VirtualBox and Boot2Docker version 1.8.3. I tried docker-machine v0.5.0-rc3 and got the same behaviour. If I can supply more information, let me know.
Thanks to @railsbros-dirk for testing this on shiny Apple hardware. :)

Thanks for the issue -- it's a dupe of : https://github.com/docker/machine/issues/1376


Bug ipad Mini 2 - 10.3.3  sample app of Cognito auth with Swift

Trying out the sample app of Cognito auth with Swift as language and find following error when I tap on Sign In
2017-09-18 16:56:03.789252+0530 CognitoAuthSample[467:55748] *** Terminating app due to uncaught exception 'NSGenericException', reason: 'UIPopoverPresentationController (<UIPopoverPresentationController: 0x101020240>) should have a non-nil sourceView or barButtonItem set before the presentation occurs.'
*** First throw call stack:
(0x18ce0efe0 0x18b870538 0x19397ebe8 0x19328c0d4 0x193289e04 0x1931c6594 0x1931b8630 0x192f2c28c 0x18cdbc9a8 0x18cdba630 0x18cdbaa7c 0x18cceada4 0x18e755074 0x192f9ec9c 0x10001c254 0x18bcf959c)
libc++abi.dylib: terminating with uncaught exception of type NSException

@IBAction func signInTapped(_ sender: Any) {
self.auth.getSession  { (session:AWSCognitoAuthUserSession?, error:Error?) in
if(error != nil) {
self.session = nil
self.alertWithTitle("Error", message: (error! as NSError).userInfo["error"] as? String)
}else {
self.session = session
}
self.refresh()
}
}
App crashes when executing above function from ipad

@gitton Thanks for reporting this.  I was able to repro locally, it is an issue with the Cognito Auth SDK and popover's requiring a sourceView and sourceRect on ipads.  I've made some progress on fixing it, but it doesn't display fullscreen like on iphones.  I'll continue working on it as time permits and will let you know if I have a patch.

Thank you @behrooziAWS for looking into the issue. Is there any fixes for the same

@gitton I believe you also reached out through AWS support,  I've provided support with a preliminary patch with a few issues that may get you unblocked.  If they haven't already they likely will reach out to you soon.

Thank you for the response @behrooziAWS . Waiting for the patch

Thank you @behrooziAWS got the patch and it works!


Update build matrix

Added Python 3.5 and 3.6. Also added PyPy and pip cache.

Coverage remained the same at 97.689% when pulling 09e8a1dcfb3b5528771e40e52378500997200c59 on thedrow:patch-2 into e3814d2ff924b76e4db972c755da4baa250ef941 on uber:master.

Coverage remained the same at 97.689% when pulling 09e8a1dcfb3b5528771e40e52378500997200c59 on thedrow:patch-2 into e3814d2ff924b76e4db972c755da4baa250ef941 on uber:master.

It seems like we do not support PyPy. I'll remove it and we'll deal with it in a different PR.

@toddsifleet Can you please merge this?


ValidationError ['Invalid input for a Location instance. Latitude must be convertible to float ']

when I goto my location list after create location then found this error.

please solve it urgently.

Hello, what value is saved in the database?

It will be beacuse the value is save in te data base as string.
For example if I add it to a migrate with default value.
migrations.AddField(
            model_name='order',
            name='destination_location',
            field=mapbox_location_field.models.LocationField(default='0,0', map_attrs={}),
            preserve_default=False,
)

All update fields will have ',0' as value in the database.
If I implement for example django-rest-framework with LocationField I have the same result.
I solved temporaly adding "or isinstance(value, str)" to the LocationField model.
   def get_prep_value(self, value):
       if value is None or isinstance(value, str):
           return value

       return "{},{}".format(value[0], value[1])

Yeah, this error probably occurs when the value from db is converted to Python representation. However, I raise it purposely when parsing is impossible. It means you have some wrong value stored in db.
The big question is WHY?
I always remain open to the possibility that it's a bug in saving the value, but I haven't encountered anything similar, so I need some information about your configuration, to reproduce this problem.
Do you use plain or spatial field? Is it nullable? Read-only? Anything that you think may be useful. Maybe some code example for easier bug reproducing? That would be great to.
Did you have something saved in your database before implementing this field? You can try to clean your db and then check if you still encounter this problem on fresh new db.

For example django-rest-framework take the field like charfield.

I haven't used my package with DRF, but something seems definitely wrong, so I will take a closer look at it today.

Ok, so basically I changed get_prop_value function because it used to assume that you always provide a tuple or list and not a string value. Of course, DRF's serialization with CharField is a clear example, why it was a wrong assumption. Since 1.6.1 it's fixed. However, saving string values is not a safe procedure and can potentially cause multiple errors (similar to @sajib1066 ). That's why I implemented the protection mechanism and when string can't be parsed, the default value of null (in case of nullable field) or "0,0" (in case of non-nullable field) is saved to db. If it's undesired behavior, then you have to implement a validation mechanism in your API. It's quite simple. That's a code example:
from rest_framework import serializers
from mapbox_location_field.forms import parse_location, ValidationError

class LocationSerializer(serializers.HyperlinkedModelSerializer):
    class Meta:
        model = SomeLocationModel
        fields = ["location"]

    def validate_location(self, value):
        try:
            parse_location(value)
        except ValidationError as error:
            raise serializers.ValidationError(error.message)
        return value

It's serializer for SomeLocationModel with location field, which is a LocationField

I hope I resolved this issue. If you still encounter it, reopen it, or create a new one. If you have some wrong values stored in db, you have to clean it.


Enquire output quality

Strangely, running @wikiatlas in 2015 generated #svg images of smaller dimensions yet higher quality🙄
For topography&hillshade.🤔
To dig in!🤣

[x] hillshade
[ ] topography

[x] Hillshade

[ ] Topographic

Regression likely due to topojson's simplification settings changes.
Balancing GIS raster precision with Topojson simplification is known to be tricky ! :roll_eyes:


Fix vr rendering

Closing due to inactivity.
If there is still some VR problem and this is a solution, please re-open!


add docs of installs

cf #12
mostly stealing content from https://stat.ethz.ch/pipermail/r-package-devel/2019q2/003985.html :wink:

Thank you!


WIP: homematic: Add homematic.put_paramset service

The service enables access to an advanced part of the Homematic XML-RPC
API. This allows users to use features, which are not directly exposed
by device attributes. For instance this service can be used to set the
WEEK_PROGRAM_POINTER for some Homematic thermostat devices.
Description:
Related issue (if applicable): danielperna84/pyhomematic#139
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#6032
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

@danielperna84 I know you have suggested that we should specify the "interface" in the service signature, but do we really need it there? I thought about this a bit and I find it kind of bulky and it also does not match with the signature of set_device_value (which is comparable feature-wise).
Without the "interface" I could also do the following, if you don't like the looping over the available interfaces:

Call _device_from_servicecall just like in _hm_service_virtualkey. That would still result in looping over the interfaces, but at least it's in line with other service code then.
Then I'd call the putParamset() method directly on the device returned by  _device_from_servicecall

and it also does not match with the signature of set_device_value (which is comparable feature-wise).

Sure it does:
def set_device_value(hass, address, channel, param, value, interface=None):

The one service that does not have the interface is the set_variable_value. There it's the entity id of the interface. Which essentially is still the same. So the way I read it all services that interact with the CCU in this way at least have the interface optionally. Which would be ok for putPramset too. It can be left out if there only is one interface. But for people with more interfaces (I have a CCU and Homegear running in parallel) it won't work anymore when the interface is not provided.
And one (optional) extra line in yaml to me is far less bulky than iterating over possibly 50-100 (or even more) objects every time the service is called. That's totally unnecessary as long as the interface is provided. And with interface=None and a change to the service schema you can leave it out if you just have a single CCU.

Ahh, ok. In case of set_device_value it's optional, but let's leave it as it is right now then. I'll remove the WIP tag so this can get reviewed/merged. Sorry for the noise.


Replaced Depreciated apt-key

Replaced Depreciated apt-key with recommendations from apt-key man page.

Learn Build status updates of commit 51815d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/linux/quickstart-install-connect-ubuntu.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@VanMSFT

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Co-assigning myself to remember to track this.
#assign:rwestMSFT

@dphaas2004 - Thanks Daniel! Looks correct to me.
@amvin87-zz - Amit, can you please verify the changes?

@amitkh-msft - Amit, can you please verify the changes?

PG also verified. Approving.
#sign-off


Fix bug with running queries on Windows

Line Breaks and Windows command line arguments: not even once.

Fixed here for winbros, already on main. Closing PR.
https://github.com/justin-lyon/sfdx-delete-flow-versions/commit/5dff69fb3615ed4e723a66afdaedda61ad079523


[v1.2] Fixed auth-model linkage & added logout command test

Basically just refactoring some code

Pull Request Test Coverage Report for Build 471

10 of 17 (58.82%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 81.035%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/LoginCommand.java
0
1
0.0%

src/main/java/seedu/address/model/ModelManager.java
2
5
40.0%

src/main/java/seedu/address/model/UserAccount.java
7
10
70.0%

Totals

Change from base Build 470:
0.3%

Covered Lines:
1581

Relevant Lines:
1951

💛  - Coveralls


CB-8819 Fixed FileReader's readAsBinaryString on wp8

https://issues.apache.org/jira/browse/CB-8819

Ran on my machine and verified that it works. LGTM.

Merged to master in https://github.com/apache/cordova-plugin-file/commit/6f20c19263df80b4bc5aebc1d75e7567d105b2bf @alsorokin, could you please close this


certificate verify failed

I'm using flask_oauth in an app deployed on heroku.
And 'certificate verify failed' occurs when requesting the access token from https://api.weibo.com. But it's ok to access the website in browser, no certificate warning.
So, how can I just ignore the ssl certificate verification?

Stack trace:
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/flask_oauth.py", line 429, in decorated
  data = self.handle_oauth2_response()
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/flask_oauth.py", line 400, in handle_oauth2_response
  resp, content = self._client.request(url, self.access_token_method)
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/oauth2/__init__.py", line 682, in request
  connection_type=connection_type)
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/httplib2/__init__.py", line 1597, in request
  (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/httplib2/__init__.py", line 1345, in _request
  (response, content) = self._conn_request(conn, request_uri, method, body, headers)
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/httplib2/__init__.py", line 1281, in _conn_request
  conn.connect()
File "/Volumes/ws/prj/mark1x/venv/lib/python2.7/site-packages/httplib2/__init__.py", line 1036, in connect
  raise SSLHandshakeError(e)
SSLHandshakeError: [Errno 1] _ssl.c:504: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed

Hey guys, we just merged some changes in joestump/python-auth2 that should help :)

In case it helps anyone other than myself. :) Newer versions of urllib2 verify ssl certificates by default. You can override this behavior by monkey patching the http_request method of the flask_oauthlib.client.OAuth class.
import ssl
from flask_oauthlib.client import OAuth, prepare_request, http

auth = oauth.remote_app()

def net_http_request(uri, headers=None, data=None, method=None):
    '''
    Method for monkey patching 'flask_oauthlib.client.OAuth.http_request'
    This version allows for insecure SSL certificates
    '''
    uri, headers, data, method = prepare_request(
        uri, headers, data, method
    )
    req = http.Request(uri, headers=headers, data=data)
    req.get_method = lambda: method.upper()
    try:
        resp = http.urlopen(req, context=ssl._create_unverified_context())
        content = resp.read()
        resp.close()
        return resp, content
    except http.HTTPError as resp:
        content = resp.read()
        resp.close()
        return resp, content

auth.http_request = new_http_request

Thanks @dwoz! it helped to do quick fix
just typo: new_http_request must be net_http_request


[fix] jsx-uses-vars ignores lowercase tag names

Context: eslint/eslint#15040

Codecov Report

Merging #3070 (5340e9d) into master (577cb64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3070   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files         111      111
  Lines        7525     7529    +4
  Branches     2768     2769    +1
=======================================
+ Hits         7332     7336    +4
  Misses        193      193

Impacted Files
Coverage Δ

lib/rules/jsx-uses-vars.js
95.23% <100.00%> (+1.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577cb64...5340e9d. Read the comment docs.

Nice fix.

Hola @alanorozco! 👋 It seems like this PR caused a breaking change in a patch release, see: https://github.com/yannickcr/eslint-plugin-react/issues/3080
Could you please have a look? I am not sure what would be the right thing to do in this case. 🤔


tests/input/svg/test_svg.py test_to_jpeg fails with wand backend.

Related to #113 (read first).
I'm getting:
        with Image.open(path_to_file) as jpeg:
            assert jpeg.height == 256
>           assert jpeg.width in range(358, 360)
E           assert 181 in range(358, 360)
E            +  where 181 = <PIL.JpegImagePlugin.JpegImageFile image mode=RGB size=181x256 at 0x7FEA731BC870>.width
E            +  and   range(358, 360) = range(358, 360)

This one is really strange, the input svg looks in portrait mode, but the test expect the thumbnail to be in landscape mode?

this has been fixed with the improved wand backend #253


Version 0.5.3 does not work with remote-ssh on the Mac system

desktop: MacBook Pro (14-inch, 2021) Apple M1 Pro
remote: #78~20.04.1-Ubuntu x86_64
vscode:
Version: 1.86.0 (Universal)
Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
Date: 2024-01-31T10:29:15.765Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.3.0
Fallback to version 0.5.2 and it will work

Version 0.5.2

Version 0.5.3

Can you verify if this was caused by zig.zls.path becoming scoped to machine-overridable or by this recent bug #177?

I tried manually starting zls and the problem was resolved. This should be similar to bug #177

Upgrading to version 0.5.4 also resolved

thanks 👍


modals display information for default tarot card set after "reshuffle" button is pressed and images switch

resolved, but introduced new bug where all modals are being displayed at once, and stop looping through the array on "reshuffle" click


Requesting v2 Router documentation about trailing slashes in path

This is a (multiple allowed):

[ ] bug

[X] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 2.1.3

Platform and Target: generic

What you did
All of the Framework7 router documentation uses trailing slashes in the example routes.  It's good that it is consistent.  For example, it says:
var view1 = app.views.create('.view-1', {
  routes: [
    {
      path: '/users/',
      url: './pages/users.html',
    },
    {
      path: '/user/',
      url: './pages/user.html',
    },
  ],
});

However, the role of those trailing slashes is never really explained.  I tried removing them in my F7-Vue application, and it worked perfectly in most but not all cases-- it took me quite a while to realize that not having the trailing slashes seemed to be the issue.  If it's a misconfiguration, it would be nice if the framework could just emit a warning.  If it's a feature, maybe an explanation would help others.
Expected Behavior
Documentation improvement to explain the semantics of the trailing slashes.

not having the trailing slashes seemed to be the issue

It is not true. If you don't have trailing slashes in route path then you just need to have the same in links or when you call router.navigate. Currently routes with paths with and without trailing slashed are treated as different paths

I think i will better add an option to make them as same routes


feat(gateway): TLRFU cache content

cache improvement to #121

implement TLRFU for caching content

#143


I have added a loading progress bar

When you navigate to some other page by clicking the buttons, the loading bar shows up adding a good user experience to the webpage. Modified the existing JavaScript function and put that into a separate file named logic.js.
Also, some changes in the ref tag link :)

please rephrase the issue by considering the react js technology and if you didn't joined onboarding group please do join
Developers needs to onboard to opensource community for easy information flow along with admins, please join with this link Curious Developers Community - Hacktoberfest

please rephrase the issue by considering the react js technology and if you didn't joined onboarding group please do join
Developers needs to onboard to opensource community for easy information flow along with admins, please join with this link Curious Developers Community - Hacktoberfest

Hey @thecuriousteam. Kindly merge my pull request :)

please rephrase the issue by considering the react js technology and if you didn't joined onboarding group please do join
Developers needs to onboard to opensource community for easy information flow along with admins, please join with this link Curious Developers Community - Hacktoberfest

@VishnuAmit your code is giving merge conflicts
Thank You
Instructions

Yes you can start working on it by taking latest pull from main branch
Don't Forget to join onboarding group for knowledge flow and direct conversation and support from other developers link  Curious Developers Community - Hacktoberfest
Please write the comments in your source code for development work and don't forget to attach the screenshots and video of the development work once it is done
Contributions more than 3 will be awarded a certificate of appreciation from curious ecosystem please mail to<EMAIL_ADDRESS>for claiming certificate and please attach your issue number
Respect Co Developers And Please Reachout to admins if any issues

Thanks & Regards
The Curious Team

Yea ok. I am working on it 👍


Fix and update french TL

In this PR, I updated French translations, and fixed some syntax because everything sounds like it got translated using Google or something.

everything sounds like it got translated using Google or something

Honestly a lot of it probably has been. Thank you for the translations!


Missing functions

Since the recent removal of the CLI menu switch a couple of functions are no longer accessible. This is because i hadn't moved then across to BasicFunctions.js yet.
These will need re-enabled:

History (up/down still works just not the list)
Send (doesn't do much yet anyway)

added Send back in- still does sweet nothing at the point but give errors


Create / Update code of conduct

Should we just update the README and link to this @isabela-pf
https://jupyter.readthedocs.io/en/latest/community/content-community.html#code-of-conduct

Related to https://github.com/isabela-pf/jupyter-communitycalls/issues/16

I actually reference this right now: https://jupyter.org/conduct. I think just linking could work though, good idea!
Long term, I do want to add more specifics on top of these guidelines because I personally find them vague and potentially insufficient in the case that we do need to address a code of conduct violation.

Fixed with 72e7341.


Simplify eviction

The blocking mode did not work as it should, it was doing an empty spin, that's why the tests worked.

Codecov Report

Merging #26 (86fd9e4) into master (ebafe99) will increase coverage by 2.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   84.12%   86.80%   +2.68%
==========================================
  Files           3        3
  Lines         296      288       -8
==========================================
+ Hits          249      250       +1
+ Misses         25       20       -5
+ Partials       22       18       -4

Impacted Files
Coverage Δ

record.go
84.00% <ø> (-2.67%)
:arrow_down:

cache.go
91.30% <100.00%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebafe99...86fd9e4. Read the comment docs.

warning Performance Alert warning
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
Benchmark suite 	Current: 86fd9e4 	Previous: 14b5bc8 	Ratio
BenchmarkSetExists 1402 ns/op 160 B/op 4 allocs/op 	685.2 ns/op 32 B/op 2 allocs/op 	2.05
This comment was automatically generated by workflow using github-action-benchmark.

This comes down to not using the pool for evicted records. Won't fix.


Is this project dead?

 Is this project unmaintained? If so, I think it'd be cool to give maintenance permissions to someone else who is willing to maintain the project (+ability to update domain name, perhaps using IPFS-based hosting?).
I'd be willing to be a temporary maintainer if need be, have a few recipes I want to add :)

Yes it's been abandoned for a while. I created this repo and merged a lot of the PRs from here into it. https://github.com/ronaldl29/public-domain-recipes https://publicdomainrecipes.com/

lolz


Upgraded Json.NET version to 10.0.1

@kichalla,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Do we do this everywhere?

Yes, we are doing this all across our repos except a few exceptions (ex: Razor). Any specific concerns?

No if we are doing this across all/most of the repos.


⚠ Bofrost.lu has degraded performance

In 2da532d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1200 ms

Resolved: Bofrost.lu performance has improved in 054b00b.


Sanic 0.2.0 changes to  type of request.args['xxx']

In sanic 0.2.0 type of request.args['xxx'] is now str it used to be list.  Is that the intention?
Also if I send two instances of 'xxx' i still get a str.  If more then one instance of the same query parameter are sent, how will they be accessed in 0.2.0?

request.args.getlist(<key>)
https://github.com/channelcat/sanic/blob/master/sanic/request.py#L35


Feature/help

#105 @petebachant
Add message for restart option and modify the program name.

Thanks for comments, Checked #116 , @rafmudaf


updated news

@jpfairbanks this addresses #123
I also really wanted to call this branch anchorman

I am sure something might be missing, and I can add it afterwards

Looks good, I reorganzied it a little bit. If everyone could take a look and make sure the code they wrote is on there. I expect we will have to add:

Dataflow Graphs #145  @crherlihy
NLP #135  @kuncao0228
Autoencoder #94 @gallupBenRyan

Each of those PRs should be amended with a patch to the news file that describes what they did.


Localization network

Hello,
How can I utilise localization network to predict the affine transformer parameters for images?
thanks

The localization network is predicting inside the STN model the affine parameters.


Response body for content type error

This PR adds a response body with a helpful error message when a request is rejected because of an invalid content-type header.
Because the JSONAPI.ContentTypeNegotiation has no logging, and was returning an empty body, it can be non-obvious to you and your users why their requests are being rejected with a 415.

@mattpolzin merged in master and CI is running for this now. Feel free to merge if it's all green 👍

Thanks!


[Tree Details - Design] Once removed a tree, confirmation screen

Once you want to remove a tree there should be a screen that says either thank you for removing the tree or do you really want to remove this tree.


i18n: Uzbek (uz) translation

I’ve completed the Uzbek language translation.

Adds Uzbek (uz) language translation.

This looks great. Thanks @root5427!


.build and save results in nil attributes

I'm having some weird issues using nested attributes and building embedded models.
When using .build and specifying attributes, on save the embedded model creates an embedded translation doc, with the proper locale set. However, all of its attributes are blank.
For instance, I have a page model, and an embedded Content model. Content is subclassed (perhaps thats the culprit?) with a model called TextBlock which has a "body" attribute.
page.contents.build({ body: "some content" }, TextBlock)
# misc code here
page.save

Upon save inspecting the embedded TextBlock I have one embedded translation for :en (default locale) but its body, as well as the body on the model itself are both blank.
I'm wondering if its something to do with the changes mongoid made recently with how embedded docs persist mentioned here because if I re-save the embedded doc after the parent is saved, the attributes/translations are properly saved
class Page
  after_save :resave_contents

  def resave_contents
    self.contents.each(&:save)
  end
end

page.contents.first.inspect #=> <TextBlock _id: 4ee6e3644dd9624091000010, _type: "TextBlock", created_at: 2011-12-13 05:32:20 UTC, updated_at: 2011-12-13 05:32:20 UTC, position: 2, body: "some content">

All translations are also set properly.
In addition, as mentioned in the mongoid link above, when updating embedded docs with update_attributes, all attrs/translations are updated perfectly, but using model.attributes= and model.write_attribute(key, value) or model.write_attribute(key, value, :locale => I18n.locale) don't seem to persist either.
I tried overriding the nested_attributes callback (contents_attributes=) and the documents update with the exception of translated attributes.  Going through the code also got me to try doc.globalize.write(locale, key, value) but the updated attrs still don't persist.
Without translation enabled everything saves properly, and I'm wondering if this isn't an issue created with how mongoid handles setting embedded docs on the parent as of version 2.2.0. When creating/updating non-embedded docs everything works as expected.
I'm happy to fork and test a few things out, I was just wondering if  anyone had any thoughts :)

Hello, Brent,
I absolutely didn't consider option when translatable model will be embedded...
So if you can examine this question I will be pleased :)
Gem creates fields for embedded translation in before_save callback, looks like it doesn't call on embedded models when you save Page model.

Apparently this is how mongoid is handling embed callbacks for performance reasons (makes sense). The next release should include a after_build callback which may be the way to resolve this.
Right now the solution is to use embed.create instead of embed.build when creating embedded docs on a parent. This will call the save callbacks to fire and it will work properly.
I started looking into detecting embedded docs with translations and manually firing callbacks but that seems like a little much to solve the issue :)   I'll leave it open and keep an eye on it though since I'm using Globalize in a cms engine we're working on for translations. Its definitely the cleanest implementation I've seen yet, so awesome work by the way!


Extend GCC compiler optimization for Linux.

Partly fixes #1098.
Only covers Linux GCC (4.8.5) optimizations. Due to the lack of Mac devices, I can't verify the compilerflags for Mac.
In addition to the desired loop-unroll, some more loop optimizations have been added, which are trying to optimize loops. Generally, optimization flags have been chosen to increase runtime-speed, while maintaining precision (that's why e.g. -fast-math is not included) and sacrificing compile-speed and filesize.
Flags chosen from GNU Optimization Options.
GCC 4.8.5 has been chosen, since it's the latest 4.8 version available.
Code compiles and is still able to render simple scenes (i.e. the cornell box) with these flags.

What difference do they make the new flags?
The most important factor is speed, but also check the size of libappleseed.so before and after.

Sorry for not mentioning the precise use of each flag. I selected them with speed in mind:

funroll-loops:

Unroll loops whose number of iterations can be determined at compile time or upon entry to the loop. -funroll-loops implies -frerun-cse-after-loop. This option makes code larger, and may or may not make it run faster.

Loops with a known (const expr) number of iterations will be unrolled into single statements. The compiler would convert
for(int i = 0; i < 10; i++)
{
    a[i]++;
}
into
a[0]++;
a[1]++;
a[2]++;
...

ftree-loop-ivcanon

Create a canonical counter for number of iterations in loops for which determining number of iterations requires complicated analysis. Later optimizations then may determine the number easily. Useful especially in connection with unrolling.

Supports the unrolling, by enabling it possibly to unroll more loops, especially the ones not having a const expr as iteration number, but which still can be determined at compiletime.

fgcse-las

When -fgcse-las is enabled, the global common subexpression elimination pass eliminates redundant loads that come after stores to the same memory location (both partial and full redundancies).

When you have the following code
a[i] = x;
x = a[i];
you can skip the second line. This is a very simple example, but it illustrates the idea.

fgcse-sm

When -fgcse-sm is enabled, a store motion pass is run after global common subexpression elimination. This pass attempts to move stores out of loops. When used in conjunction with -fgcse-lm, loops containing a load/store sequence can be changed to a load before the loop and a store after the loop.

Since loading may take a while and you may benefit from doing it before entering a loop, such that the loop itself doesn't need to wait for each load, it can be beneficial to perform loads and stores before and after the loop. If everything is loaded before the loop happens and stored afterwards, the loop can benefit a lot more from pipelining.
Sorry for the bad code formatting, I'm not sure how to insert linebreaks into a code-block.

Use triple backticks for formatting:
'''
your code
'''
(Replace single quotes by backticks).

Allright, it took some time, but I got some numbers.
About the testsetup:

Each time I changed a compileflag I compiled the whole system anew (make clean && make)
I disabled the Warnings-to-Errors flag
I used the appleseed.cli to render
While rendering I didn't touch the computer at all
While rendering only a terminal was opened, no other user application was running (besides the desktop environment).
The system runs Ubuntu 18.04 LTS on a Core<EMAIL_ADDRESS>(x8) and 16GB of RAM.

I checked different flag configurations. All configurations had the O3 included:

No additional flags
funroll-loops, fgcse-las, fgcse-sm, ftree-loop-ivcanon (All additional flags)
funroll-loops (no ftree-loop-ivcanon)
fgcse-las, fgcse-sm

Unit tests:
All configurations passed all unit tests with summaries like the following:
2019-03-25T21:24:56.813932Z <001>   124 MB info    |   suites      : 179 executed, 0 failed (0.0%)
2019-03-25T21:24:56.813932Z <001>   124 MB info    |   cases       : 1,529 executed, 0 failed (0.0%)
2019-03-25T21:24:56.813952Z <001>   124 MB info    |   assertions  : 389,572 executed, 0 failed (0.0%)

Only difference between the outputs was the time and the size info.
Results
The following table will refer to the size of libappleseed.so as Size. The rendering times will have three columns. One for the best time, one for average time and one for worst time.

Configuration
Size
Worst Timing
Average Timing
Best Timing

No additional flags
22.580.624 Bytes
13:17.267
13:16.214
13:15.161

All additional flags
24.960.400 Bytes
13:37.888
13:32.430
13:26.933

Only funroll-loops
24.956.304 Bytes
13:37.320
13:37.577
13:37.789

Two fgcse flags
22.584.720 Bytes
13:14.022
13:12.284
13:10.977

From my point of view, the size is acceptable for any configuration.
Interestingly, unrolling loops worsens the whole process (which might be the reason, it's not included by default into O3). Nevertheless, shifting loads and stores out of loops seems to bring a slight benefit.
Therefore, I removed the funroll-loops and ftree-loop-ivcanon flags, but kept the two fgcse ones.

Thanks for the excellent and thorough work!
Just one question:

I disabled the Warnings-to-Errors flag.

Why did you have to do this? Were you getting new warnings with the new optimization flags?
Regarding your PR: it contains a lot of unrelated files, we cannot merge it as is. Here's one solution:

Fetch (not pull) master.
Create a new branch at the tip of master.
Cherry-pick interesting changes from this branch and commit them into the new branch.
Push your new branch to LZaw:Issue1098 on GitHub to update this PR (no need to close it and open a new one).
Delete your old branch.

And here's another:

Fetch (not pull) master.
Rebase this branch interactively on top of master. Delete the merge commit (@LZaw Merge branch 'Issue1098'...).
Force-push to LZaw:Issue1098.

That rebase didn't work out as inteded. Really sorry about the mess. I will try to clean up, may take a small while. -.-
About the errors: I got them from the first day, regardless of the flags. I disabled them to get the Release build don, respectively, to get the Release flags set. One of these errors has been discussed in #2483 as well as #2325. The warnings during compiling didn't change when I added or removed any flags.

Allright, it should be fine now. Sorry again for the mess.


Clean seed words text area when returns from empty wallet view

Description
Clean seed words text area when returns from empty wallet view
Tested
Tested on Android after
Related issues

Fixes #1700

Backwards compatibility
Backward compatible

BTW, I can't take screenshots because of security policies of the app


Unknown license

Please list your license.

https://github.com/zertosh/jstify/blob/2c3ef7d3bcc05337ea6afe575d23dda722532408/package.json#L15

I means LICENSE file in the root dir of the repo, we're using automated tools to monitor our vendor licenses (versioneye.com).
Do you want me to open PR with this?


carbonlink query doesn't work for tagged series

When fetching data from a tagged series, graphite-web as evidenced by the carbon-cache query.log uses the encoded series path (something like _tagged.301.220.3012209b6ac3b582a8fd1a3317a5f40407fa446943af8f24ed32beff3f13b620 in my case with TAG_HASH_FILENAMES=True) to query the carbon-cache for in-memory data. However, AFAICT carbon-cache organizes its memory cache not by the encoded path, but by the path it received from the metric sender (after normalizing it, ie. sorting the tags and converting OpenMetrics tag syntax to Carbon syntax), something like my.metric;bar=a;foo=b. Hashing to get the filename is only done when data is finally written to disk. Therefore, the carbonlink query will fail to retrieve any data currently floating in the carbon-cache.
In theory this could be fixed on either end by changing the behaviour to match the other end. However, if you were to change this in carbon-cache, you would run into a related issue, namely that the relay doesn't take tagging into account when consistent-hashing (I'm going to open another bug report on carbon for that). Since it is essential that the hash used for consistent-hashing is the same in both graphite-web and carbon-relay, changing carbon-cache would mean that carbon-relay would also have to be aware of the TAG_HASH_FILENAMES setting for one thing, and it would have to calculate the final encoded path for the series in order to decide to which carbon-cache the metric should be sent.
OTOH, fixing it in graphite-web should be straightforward, since at the point where carbonlink is queried the human-friendly name of the series must have already been queried from the TAGDB (otherwise the series wouldn't have been found in the first place).

Hi @andreasferber ,
Valid concern, indeed.

As suspected, the fix was pretty simple indeed, PR coming up shortly.


Mutation "-i" option not working

I have created a instrument_classes file with the classes that i want to be mutated, but at the end, all mutants listed in mutatnts.log file belong to the class modified by the fix. In version 51 its org.apache.commons.lang.BooleanUtils.
Im runing the following comand for the checkout of version 51f:
defects4j mutation -i classes.src
classes.src contains the following:
org.apache.commons.lang.ArrayUtils
org.apache.commons.lang.ArrayUtilsTest
org.apache.commons.lang.BitField
org.apache.commons.lang.BooleanUtils
org.apache.commons.lang.CharEncoding
org.apache.commons.lang.mutable.MutableBoolean

It results in 391 generated mutants:
Mutants generated: 391
Mutants covered: 391
Mutants killed: 283
Mutation score: 72.4% (72.4%)
Total run time: 47.0 seconds

Which is the same result as running defects4j mutation without the "-i" parameter

Hi @diogom42,
Thanks for the bug report!
This seems to be caching issue. For efficiency reasons, the classes are not re-mutated after the first execution of defects4j mutation, which is useful when running multiple test suites against the same set of mutants. The cache of mutated classes, however, needs to be updated if setting the "-i" flag changes the set of classes that should be mutated. This is apparently not the case and clearly a bug.
As a workaround, the "-i" option is working properly on a fresh working copy (i.e., defects4j checkout followed by defects4j mutation -i ...).
Thanks,
René


name pages routes correctly

Forgot you need unique names
@wellcometrust/experience-dev you'll have to run a terraform init before hand.

We should hopefully be able to remove these and catch all routes by this app.


Allow Jenkins to configure global shared library at startup

This adds a feature to the Jenkins image that allows a global shared library to be installed whe deploying if desired. It allows all pipelines access to common methods like patchBuildConfigOutputLabels(). This feature is added through an init.groovy.d script and the deployment needs to provide env vars (defined in s2i-config/jenkins-master/README.md) which references the git repository containing the shared library. It supports public repos and private repos through an OCP secret.
Pipelines will NO longer have to import libraries with code like
            steps {
                library identifier: 'shared-library@master',
                    retriever: modernSCM([$class: 'GitSCMSource',
                    credentialsId: 'git-secret',
                    remote: 'git@mygit.com:labs/shared-jenkins-library.git',
                ])
            }
        }

@mcanoy NICE!


Shield waf filter action

this branch has a few too many unrelated changes, going to split it out into separate pull requests for review.


fix: artwork details improvements

Description
Two small UX improvements in the artwork details screen:

add a drop shadow
use BottomSheetScrollView so that the pull down to close gesture works as expected

PR Checklist

[x] I tested my changes on iOS
[x] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.

To the reviewers 👀

[x] I would like at least one of the reviewers to run this PR on the simulator or device (Android!)

Need help with something? Have a look at our docs, or get in touch with us.

Thanks for this change @admbtlr
But I dont see any difference with the pull-down to close gesture works as expected.
Can you post a before-after video, please?
Also, there is a merge conflict👀

This change means you can drag the details bottom sheet closed from anywhere on the screen; currently you can only drag it closed from the top handle.
Old behaviour:
https://user-images.githubusercontent.com/1815204/187723895-8bc1072c-acb2-4d14-be0f-73d7a56d4e21.mov
New behaviour:
https://user-images.githubusercontent.com/1815204/187723938-39cbc129-3886-49dc-b2db-a0cc51952b1f.mov


Addressing issue with chat-to-video feature

Summary
some feedback from @leroychan that the use of chat-to-video had some hiccups

the localization effort had encoded the url

fixed

the deployment did not include the chat-to-video assets and some manual work arounds were used

the assets have unique ids in their filenames so the deployment scripts were updated to auto generate these and deploy as part of serverless as well as ensure when running locally everything lines up with the local serverless environment.

experienced some odd behavior with final commits not showing up in PR


parse error

Parse error: syntax error, unexpected '[', expecting ')' in /..../mpk/tests/BIP32Test.php on line 39

this library is PHP 5.4+

also I recommend you learn how composer works and use composer to install libraries (including this one), it will install the rest of the dependancies and also check for requirements such as the PHP version.

Definitely want to echo @rubensayshi's advice.. Use composer, it takes away these problems. I noticed on Reddit you wanted to avoid gmp. Are you on a shared host, or is there a reason you might not be able to install more software?

Will close this, as the error in this case is purely the PHP version.


Add signed/unsigned shifts to PrimInt

Looks good to me.
@homu r+

:pushpin: Commit afee4e4 has been approved by hauleth

:zap: Test exempted - status