feat(tauri): intergrate warp native api

While we could utilize web assembly using tauri, it would make more sense to integrate the native side of warp to give more flexibility across native platforms (ie desktop and possibly mobile), utilize optimizations that is not available on the browser (utilizing tcp and quic, upnp (if available and if desired), be able to utilize tor or other transport means (in the future), etc), and give an better experience while utilizing desktop and mobile while making it easier to debug issues.
Note:

There might be some changes needed to be done to the UI (none that I am aware of), which might be small (webview might vary but I dont foresee any changes needed)
The code that implements warp-wasm in js can possibly be reused when sending commands to tauri by checking to see if its the browser or tauri and use the correct function based on the check. Some that might not be reusable would be ones dealing with streams or events in which case would need to utilize tauri api to handle them in event handlers (or write a custom command to handle them on rust that can used from js via tauri command call)
If building for tauri, we could exclude the warp-wasm module, cutting down the overall package size (it makes no sense to include it while building and using native calls)

If included, we could have some type of flag or environment variable to be able to switch between the two (though would not be seamless and would likely need a restart to reinitialize)

This would not be recommended due to the difference in how the data is stored locally

At this time, this would be low priority but would be a nice-to-have type of thing on platforms where it would make more sense to utilize native over wasm where possible long term while utilizing wasm where feasible (eg browser).

Have you had any luck building the app with tauri at all? My understanding is that many have tried but none have been successful. Maybe that's just for mobile and desktop is already using tauri?

Im not sure I follow? From my knowledge, others were able to build uplink web with tauri in the past unless you are referring to something else.

Yeah, turns out we are using tauri for Desktop builds now. I just heard that we were switching from one to the other at various times so just wanted to be sure I understood the current state.


Running App in Xcode

Description of the Bug
Your text
Code and Logs
from kivy.app import App
from kivy.lang import Builder

kv = """
Screen:
    # KV-Code
"""

class MainApp(App):
    def build(self):
        self.root = Builder.load_string(kv)

if __name__ == '__main__':
    MainApp().run()

Screenshots
Add images to explain us this bug. Paste urls here.
Remove this section if no images here
Versions

OS:
Python:
Kivy:
KivyMD:

@fraanco7 The essence of the issue is missing.


Bug fix in interactive solver for non-canonical UMP2

This PR fixes a bug in the iterative non-canonical UMP2 calculation (described in  #1988), causing discrepancy in UMP2 and RMP2 for a close-shell carbon atom.

Please fix the test


Environment variable

Why can't we use the GTM_ID as an env variable on start?
nuxt.config.js
modules: [
    [
      'nuxt-env',
      {
        keys: ['GTM_ID']
      }
    ]
],
gtm: {
  id: process.env.GTM_ID
},

GTM_ID=xxxx nuxt start
The GTM ID is not loaded

Hi @man-andy because it is too early. nuxt-env injects env to runtime. Two ways you can use it:

Use manual init which inside plugins, we have access to process.env.GTM_ID: https://github.com/nuxt-community/gtm-module#manual-gtm-initialization
Add require('dotenv').config() to the beginning of nuxt.config.js

Hi,
It's great that #53 has been added for the GTM id.
Could you add the same behavior for all options (or at least "debug" and "enabled") ?


K8SPXC-637 improve crash recovery message

 ❨?❩

Test name
Status

storage
passed

haproxy
passed

recreate
passed

upgrade-haproxy
failed

big-data
passed

scaling
passed

init-deploy
passed

self-healing
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

limits
passed

self-healing-advanced
passed

monitoring-2-0
passed

demand-backup
passed

affinity
passed

operator-self-healing
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

pitr
passed

users
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

scheduled-backup
failed

validation-hook
passed

upgrade-proxysql
failed

smart-update
passed

upgrade-consistency
passed


The page lists options that are NOT available, i.e. the "Download all, then install" feature

[Enter feedback here]
The page lists options that are NOT available, i.e. the "Download all, then install" feature

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 228076d1-94bf-c502-c018-08f7c0faf377
Version Independent ID: c64a5cd5-6236-4192-2bfc-923aa20c94da
Content: Create an offline installation - Visual Studio (Windows)
Content Source: docs/install/create-an-offline-installation-of-visual-studio.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@CarlBateman - I'm a little confused by your assertion that this page lists options that are not available.  This page is discussing how to create a local cache of the Visual Studio files onto the local machine.  If you are using the installer to manually install the product, on the screen where you pick workloads there is a dropdown where you can specify to "Install while downloading" or "download all, then install" just like what's shown in the picture.
What exactly are you doing that's leading you to believe the option isn't available?

#reassign: @christineruana

From a clean install, the dialog had no options, specifically no dropdown, and no options to "Install while downloading" or "download all, then install".
I can't recreate without uninstalling, which I'm afraid I don't have time for (it took over 5 hours last time :( ).
HTH


less candles when using talib and candleSize < 0.5 * batchSize

I'm submitting a ...
[x] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
Talib indicator added and candle size < 0.5 * batchSize
Expected result (what you hoped would happen)
The total number of candles executed should be as per the time period and candle size. eg. 60 candles in 1 hour
Actual result (unexpected outcome)
Less than expected candles are executed. eg.
Strategy run duration = 24 hours, batchSize = 50, candleSize = 30. Expected candles = 48, Actual = 48
Strategy run duration = 24 hours, batchSize = 50, candleSize = 20. Expected candles = 72, Actual = 59
Strategy run duration = 24 hours, batchSize = 50, candleSize = 10. Expected candles = 144, Actual = 59
Strategy run duration = 24 hours, batchSize = 40, candleSize = 10. Expected candles = 144, Actual = 75
Strategy run duration = 24 hours, batchSize = 20, candleSize = 10. Expected candles = 144, Actual = 144
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
Gekko v0.6.6
macOS 10.13.6 (17G65)

Can you provide a reproducable test case? eg your strategy and logging code

Managu
On Wed, Sep 12, 2018, 11:05 AM Pankaj Goyal<EMAIL_ADDRESS>wrote:

I'm submitting a ...
[x] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
Talib indicator added and candle size < 0.5 * batchSize
Expected result (what you hoped would happen)
The total number of candles executed should be as per the time period and
candle size. eg. 60 candles in 1 hour
Actual result (unexpected outcome)
Less than expected candles are executed. eg.
Strategy run duration = 24 hours, batchSize = 50, candleSize = 30.
Expected candles = 48, Actual = 48
Strategy run duration = 24 hours, batchSize = 50, candleSize = 20.
Expected candles = 72, Actual = 59
Strategy run duration = 24 hours, batchSize = 50, candleSize = 10.
Expected candles = 144, Actual = 59
Strategy run duration = 24 hours, batchSize = 40, candleSize = 10.
Expected candles = 144, Actual = 75
Strategy run duration = 24 hours, batchSize = 20, candleSize = 10.
Expected candles = 144, Actual = 144
Other information (e.g. detailed explanation, stacktraces, related
issues, suggestions how to fix, links for us to have context, eg.
stackoverflow, etc)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2522, or mute the thread
https://github.com/notifications/unsubscribe-auth/AilBefVGAZ4KAsximx-sX3rm6srUU_G_ks5uaT7wgaJpZM4Wlzij
.

Strategy
`var strat = {};
strat.init = function () {
this.addTalibIndicator('mom', 'mom', { optInTimePeriod: 10 });
this.count = 0;
}
strat.check = function (candle) {
console.log(this.count++);
}
module.exports = strat;`
config:
config.tradingAdvisor = {   enabled: true,   method: 'test',   candleSize: 15,   historySize: 150 } config.backtest = {   //daterange: 'scan',   daterange: {    from: "2018-05-14 00:00:00",    to: "2018-05-14 01:00:00"   },   batchSize: 50 }
Output:
0
1
2
3

Thanks for the report! I was able to reproduce and pushed a fix, could you download the develop branch and let me know if that solves it? If it doesn't please comment here. Thanks!

It works now. Thanks Mike.


Get current span within express handler

[x] This only affects the JavaScript OpenTelemetry library
[ ] This may affect other libraries, but I would like to get opinions here first

I've followed the instructions for setting up an express app with instrumentation from the repo: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-express
I have a handler like this, and want to add some extra attributes to the handler span, but I can't for the life of me figure out how to get at the current span.  I expected this to work, but the span is always undefined:
router.post("/", async (req, res) => {
  const span = getSpan(context.active());
  span?.setAttribute("some_prop", "something I care about");
})

Is this possible?
I can't find any documentation on how at least, and don't mind adding some once it's figured out.
Thanks

Please post all versions of your opentelemetry dependencies as well as setup code

This is the basic example:
import {
  SimpleSpanProcessor,
  ConsoleSpanExporter,
} from "@opentelemetry/tracing";
import { ExpressInstrumentation } from "@opentelemetry/instrumentation-express";
import { HttpInstrumentation } from "@opentelemetry/instrumentation-http";
import { NodeTracerProvider } from "@opentelemetry/node";
import { registerInstrumentations } from "@opentelemetry/instrumentation";
import { trace, context, getSpan } from "@opentelemetry/api";

const provider = new NodeTracerProvider();

registerInstrumentations({
  tracerProvider: provider,
  instrumentations: [new HttpInstrumentation(), new ExpressInstrumentation()],
});

provider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter()));
provider.register();
trace.setGlobalTracerProvider(provider);

import express from "express";
const app = express();
app.post("/", async (req, res) => {
  const span = getSpan(context.active());
  span?.setAttribute("some_prop", "something I care about");
});

and dependencies:
"dependencies": {
    "@opentelemetry/api": "^1.0.0-rc.0",
    "@opentelemetry/exporter-zipkin": "^0.18.2",
    "@opentelemetry/instrumentation": "^0.18.2",
    "@opentelemetry/instrumentation-express": "^0.15.0",
    "@opentelemetry/instrumentation-http": "^0.18.2",
    "@opentelemetry/node": "^0.18.2",
    "express": "^4.17.1"
}

Could you please try with API 0.18.1 and express 0.14.0 as these would match better according to https://github.com/open-telemetry/opentelemetry-js#compatibility-matrix

Yes, that worked - thanks so much!

FYI, with API v1.x and Core/Contrib v0.24.x, this has changed from...
const span = getSpan(context.active());

to
const span = trace.getSpan(context.active());

per https://github.com/open-telemetry/opentelemetry-js-api/pull/47/files


Add tile example

Looks like it's something that  people like to do, having this kind  of  stuff:
https://fluxml.ai/
as an example would be  nice (I  think it can just be done with columns but we should probably write it out and check)
\begin{:columns}
\column{
**Compiled Eager Code**

Flux provides a single, intuitive way to define models, just like mathematical notation. Julia transparently compiles your code, optimising and fusing kernels for the GPU, for the best performance.
}

\column{
**Differentiable Programming**

Existing Julia libraries are differentiable and can be incorporated directly into Flux models. Cutting edge models such as Neural ODEs are first class, and Zygote enables overhead-free gradients.
}

\column{
**First-class GPU support**

GPU kernels can be written directly in Julia via CUDA.jl. Flux is uniquely hackable and any part can be tweaked, from GPU code to custom gradients and layers.
}
\end{:columns}

\begin{:columns}
\column{
**The Model Zoo**

A rich collection of Flux scripts to learn from, or tweak to your own data. Trained Flux models can be used from TextAnalysis or Metalhead.
}
\column{
**Probabilistic Programming**

The Turing.jl and Stheno libraries enables probabilistic programming, bayesian inference and Gaussian processes on top of Flux.
}
\column{
**TPUs & Colab**

Flux models can be compiled to TPUs for cloud supercomputing, and run from Google Colab notebooks.
}

Yep, it should work automatically: https://getbootstrap.com/docs/4.5/layout/grid/#auto-layout-columns


annotate satellite answers with metadata from routeviews

The main point of this is annotate_answer_ips which performs another triple cogroup to overwrite the satellite answer ip metadata with data from routeviews.

Refactoring some of the *WithKey types in schema.py to be clearer about when we're using date vs source keys.
Moved adding page fetch info as late as possible in the satellite pipeline to speed up processing since page fetches are huge.
Fixed beam pipeline tests in test_add_metadata.py which were broken.
Similar to PR138 this does the triple cogroup independently. This means we now have three independent triple cogroups (adding satellite tags, routeview metadata, and page fetches) which we should eventually refactor to share work. That will speed up the pipeline at the cost of code readability.

Currently running a test backfill

I did some rough analysis (although I'm not 100% convinced my query is correct) of the new AS information added by this change. The top contributors are common ASes (facebook, dropbox, twitter) but there's a very long tail of smaller ASes that were missing information before.


Is it possible to set a specific property in an object?

I'm doing y.share.map.set('one',{two:'three',four:'five'}), which works ok.
How could I y.share.map.get('one.two')? or even y.share.map.set('one.two','six')? (these do not work)

y-map does not make any assumption about your data in map.set(name, data). Here are two methods to set a sub-property if data is an Object.
Use Object.assign
// set property `two` to `six`
map.set(name, Object.assign(map.get(name), { two: 'six' }))

Use y-map
// assuming map.get(name) is of type y-map
let myMap = map.set(name, Y.Map)

// set some propertyies
myMap.set('one', 'two')
myMap.set('three', 'four')
.. I think you get the idea..

thank you!


Verified that the targetNamespace will now update in status. I deployed everything into env-metaverse in the metaverse namespace. After that came up, I edited the same env to use oopsie as the targetNamespace. The base env pods deployed to the oopsie namespace. The status.targetNamespace updated to oopsie. However, the pods in metaverse hang around after the transition to a new targetNamespace. Is this intended behavior?

It's not intended behaviour, but it is expected behaviour right now. There is a label issue that I REALLY want to solve - but havn't found priority to do it yet.


remove status package

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3760077). Click here to learn what that means.
The diff coverage is 3.59%.

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage          ?   15.78%
=========================================
  Files             ?       26
  Lines             ?     1375
  Branches          ?        0
=========================================
  Hits              ?      217
  Misses            ?     1125
  Partials          ?       33

Impacted Files
Coverage Δ

pkg/cli/flags.go
61.62% <ø> (ø)

pkg/storage/mock.go
0% <0%> (ø)

pkg/storage/local.go
27.67% <0%> (ø)

pkg/storage/backup.go
0% <0%> (ø)

pkg/cli/util.go
2.08% <0%> (ø)

pkg/cli/info.go
5.4% <0%> (ø)

pkg/storage/storage.go
0% <0%> (ø)

pkg/storage/temp_backup.go
0% <0%> (ø)

pkg/storage/service.go
11.19% <19.35%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3760077...0978126. Read the comment docs.


Bug Issue: tf.case incompatible with list comprehension

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): custom
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

$ uname -a
Linux archlinux 5.1.5-arch1-2-ARCH #1 SMP PREEMPT Mon May 27 03:37:39 UTC 2019 x86_64 GNU/Linux

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: None
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below):
v1.14.0-rc1-22-gaf24dc91b5
1.14.0
Python version: 3.6
Bazel version (if compiling from source): None
GCC/Compiler version (if compiling from source): None
CUDA/cuDNN version: None
GPU model and memory: None

Describe the current behavior
Bug 1: the function random_choice below has the correct behaviour only when using the decorator @tf.function. If the decorator is not used, tf.case no longer consider the predicate and always outputs the same value.
Bug 2: even if the decorator @tf.function is used, the function random_choice does not have the correct behaviour if I use list comprehension to create the list of pairs predicate / functions. Although, it has the correct behaviour when the list is populated iteratively with append (in a for loop).
Describe the expected behavior

Decorating the function random_choice with @tf.function should not affect tf.case, unless I am not aware of the intricacies of tf.function and tf.case.

Choosing for loops or list comprehension to create the list of predicate / function pairs should not affect tf.case, unless (again) I am not aware of the intricacies of tf.function and tf.case.

Code to reproduce the issue
import tensorflow as tf
import tensorflow.keras as keras
import tensorflow.keras.backend as K
import tensorflow_probability as tfp

K.clear_session()

def fct1(x):
  return x + 5

def fct2(x):
  return x - 5

# Bug 1: if you remove<EMAIL_ADDRESS>the function `random_choice`
# no longer works, because `tf.case` no longer considers `idx`.
@tf.function
def random_choice(x, choices):
  idx = tfp.distributions.Bernoulli(probs=0.5).sample(1)[0]
  outputs = [c(x) for c in choices]

# Bug 2: if you use<EMAIL_ADDRESS>but you replace this code:
  fns = []
  for o in outputs:
    fns.append(lambda: o)
# by this one:
#   fns = [lambda:o for o in outputs]
# then, `tf.case` no longer considers `idx`.

  y = tf.case([(tf.equal(idx, i), fn) for (i, fn) in enumerate(fns)])
  return outputs, idx, y

x = tf.constant([4.0])
choices = [fct1, fct2]
outputs, idx, y = random_choice(x, choices)
sess = tf.Session()
for i in range(10):
  outputs_np, idx_np, y_np = sess.run([outputs, idx, y])
  print(y_np, outputs_np[idx_np])

Example outputs.
For the code above (this is the expected behaviour):
[9.] [9.]
[-1.] [-1.]
[-1.] [-1.]
[-1.] [-1.]
[9.] [9.]
[9.] [9.]
[-1.] [-1.]
[9.] [9.]
[9.] [9.]
[-1.] [-1.]

When removing @tf.function, or when using @tf.function but using list comprehension to create fns (this is the unexpected behaviour):
[-1.] [9.]
[-1.] [9.]
[-1.] [-1.]
[-1.] [9.]
[-1.] [9.]
[-1.] [9.]
[-1.] [-1.]
[-1.] [-1.]
[-1.] [-1.]
[-1.] [9.]

Other info / logs
I could reproduce this bug in tensorflow:
2.0.0-beta1
v2.0.0-beta0-16-g1d91213fe7

Was able to reproduce the issue on Colab with Tensorflow 1.14. Please see the gist here. Thanks!

Thanks for the feedback. Let me know when this is fixed.

@kkimdev can you help triage this? The implementation of tf.case with eager execution should be relatively straightforward to follow.

As a side note, I tested tf.switch_case in colab 1.14, and I had the same problems.

If I do this however, it works:
idx = tf.constant([0], dtype=tf.int32)
o1 = tf.constant([2.])
o2 = tf.constant([4.])
fns = [lambda: o1, lambda: o2]
tf.switch_case(idx[0], fns)

Outputs:
<tf.Tensor: id=223, shape=(1,), dtype=float32, numpy=array([2.], dtype=float32)>

@ltrottier Hi, sorry for getting back late.  Though it seems like this is just how Python works.
fns = []
for o in 'abcdefg':
  fns.append(lambda:o)

print(fns[0]())
# prints 'g', not 'a'

More info: https://stackoverflow.com/a/19837590
I agree that it's quite confusing though :(

Thanks for the link. It is indeed how python works. I can't believe I've never seen this before.


Add a public function to calculate the flash layout to the FlashLoader

LGTM other than the nit.
What's the use case? just curious.

The usecase for this is to be able to analyze how a binary will be flashed without it actually being flashed; in a tool that does all kinds of analyses for example. Tho, during my experiments I learned that making this function public is not enough, which is why I did not pursue it any further yet. I might close this or extend it a bit on the useability side :)


@primer/react is incompatible with next 12.2.5 / create-next-app

Describe the bug
Next.js causes an error when attempting to import components from @primer/react
To Reproduce
Steps to reproduce the behavior:

Create a blank Next.js project using

yarn create next-app primer-bug

Install @primer/react.

yarn add @primer/react styled-components

Edit the index.js to import a component; e.g

import { Button } from "@primer/react";

export default function Home() {
  return (
    <Button></Button>
  )
}

Start the dev server using yarn dev
Next.js gives us the following error:

error - Error [ERR_REQUIRE_ESM]: require() of ES Module<EMAIL_ADDRESS>from<EMAIL_ADDRESS>not supported.
Instead change the require of index.js in<EMAIL_ADDRESS>to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/drafts/hooks/useCombobox.js:8:43)
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/drafts/InlineAutocomplete/_AutocompleteSuggestions.js:16:20)
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/drafts/InlineAutocomplete/InlineAutocomplete.js:22:55)
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/drafts/InlineAutocomplete/index.js:8:50)
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/FormControl/FormControl.js:28:50)
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/FormControl/index.js:13:43)
    at Object.<anonymous> (primer-bug/node_modules/@primer/react/lib/index.js:669:43)
    at Object.@primer/react (primer-bug/.next/server/pages/index.js:32:18)
    at __webpack_require__ (primer-bug/.next/server/webpack-runtime.js:33:42)
    at eval (webpack-internal:///./pages/index.js:7:71)
    at Object../pages/index.js (primer-bug/.next/server/pages/index.js:22:1)
    at __webpack_require__ (primer-bug/.next/server/webpack-runtime.js:33:42)
    at __webpack_exec__ (primer-bug/.next/server/pages/index.js:52:39)
    at primer-bug/.next/server/pages/index.js:53:28
    at Object.<anonymous> (primer-bug/.next/server/pages/index.js:56:3)
    at Object.requirePage (primer-bug/node_modules/next/dist/server/require.js:58:12)
    at primer-bug/node_modules/next/dist/server/load-components.js:56:50
    at async Promise.all (index 2)
    at async Object.loadComponents (primer-bug/node_modules/next/dist/server/load-components.js:53:49)
    at async DevServer.findPageComponents (primer-bug/node_modules/next/dist/server/next-server.js:451:36) {
  code: 'ERR_REQUIRE_ESM',
  page: '/'
}

Thank you for reporting, would you consider this a duplicate of https://github.com/primer/react/issues/2245?

Thank you for reporting, would you consider this a duplicate of #2245?

Yep! Sounds good.


[IGNORE] Add debug variable to look into rich nav failure

Summary of the changes

Fixes:

@jepetty were you able to diagnose the root cause here?


Sanitize orientation

Also make sure all the commands are async.

Port of https://github.com/appium/appium/pull/5890


Fix unit test for sqrt and add no_std support.

I needed the tests working so I could be confident I didn't break anything, and no_std support is really nice for embedded development.

Thanks!


Remove rounding of metrics to improve granularity

Rounding reported metrics to 3 decimals unnecessarily removes granularity that some users may need. It's better to remove this.
This is an update of the pull request proposed by @christophermadsen in #190 and associated Pull Request, but it never made it onto main. I'm hoping this can be included now.

Thanks, as you see, right now unrelated tests are failing. I'll try to fix that first. Then this branch will be merged as well

Thanks Reinier!

Rounding reported metrics to 3 decimals unnecessarily removes granularity that some users may need. It's better to remove this.
This is an update of the pull request proposed by @christophermadsen in #190 and associated Pull Request, but it never made it onto main. I'm hoping this can be included now.

I see now that #191 was just closed and never merged, I think that's unfortunate. It would be better if we didn't close pull requests and issues just because they are relatively old.
The work is identical to mine, so if @ReinierKoops can fix the (ubuntu, 3.10) unit test, I will also vouch for it to be merged.
Thank you @daaf89

@ReinierKoops thank you for fixing and closing this.


Add failing test for onExit with promises

Added a quick test for case when there are 2 onExit handlers defined.
The first onExit handler is a Promise rejected in 100ms.
The second one is a Promise resolved  in 1 sec.
I expect both of them to be fulfilled before process is finished.
If it's proven to be a real issue i would be glad to replace it with more precise unit test.

Yes, I think both should settle. I believe this is caused by https://github.com/ember-cli/capture-exit/blob/master/index.js#L109, swapping for allSettled seems like it would fix...

Also, I think it should be possible to test this in the _flush unit tests (instead of the spawn style tests).

@rwjblue thanks for your guidance.
Updated test per your suggestion. Will re-base once finish the work.

@rwjblue you right. allSettled makes the trick.
Rebased.

I've updated implementation to search for the first rejected promise and then re-throw.
One thing to note: it re-throws not the first rejected handler but the first registered one which rejects. There is a test for it.
@stefanpenner does this change address your concern about allSettled or am I still  missing something?

@rwjblue replaced find(fn) with filter(fn)[0] per your suggestion and rebased. Will create an issue for filter=>find once this pr is accepted.

Something I noticed while reviewing https://github.com/ember-cli/ember-cli/pull/6615 is that PR seems to expect rejecting handlers to be able to determine exit code.  I might be missing something, but it really looks like that isn't the case.
If handlers reject with an integer, whether to use it for an exit code or not seems to have three cases:

beforeExit
process.exit(0)
process.exit(nonzero)

Having typed this out and thought about it in the process I think we don't want to support this because it's not obvious what the best thing to do is and the rules may get tricky.  That said, I'm interested to hear others' thoughts.
In the case where handlers want to control the exit code they already can, not by rejecting, but by calling (the captured) process.exit(code).  This will generally behave as we want.

Having typed this out and thought about it in the process I think we don't want to support this because it's not obvious what the best thing to do is and the rules may get tricky. That said, I'm interested to hear others' thoughts.

I suspect controlling the exit code is fraught with peril, but waiting for all pending tasks to complete before exiting seems ok no?

I suspect controlling the exit code is fraught with peril, but waiting for all pending tasks to complete before exiting seems ok no?

Yes I'm 👍  on this PR.
The other PR seems to expect to be able to Promise.reject(code) which is why I brought it up.

The tests in this PR also kind of imply that handlers can set exit code but that seems like too minor of an issue to matter.

Now after digging to tests I believe I understand better why exiting with a code provided by rejected promise is a problem.
Anyway from the current implementation I can see that currently capture-exit exits with an error provided by the first rejected(not registered) exit handler. Looks like it behaves in similar way as with calling of process.exit(code) manually.
But the original issue(waiting for promises are settled) remains.
I can see 2 possible ways to move it forward:

get rid of promise rejection handling. Seems like it's undesirable change.
store rejection time of each exit handler and than throw the first rejected code

As for me the second option seems better. There is an opened question in case we choose this direction: should this behavior(preserving of rejection time and re-throwing) be replicated to beforeExit?
@hjdivad @stefanpenner  your thoughts?

updated test to ensure that we re-throw not the first registered handler which rejects but the first rejected. Seems like this behavior is an original intention.
Also updated an implementation too match the original behavior.

Thanks you all guys for help with this @rwjblue @hjdivad @stefanpenner

@ro0gr thanks for doing the heavy lifting!


Update README with conda installation instructions

Fix https://github.com/mims-harvard/TDC/issues/2

Hi @hadim, thanks for the PR. I would make a slight change to the text after merging as the only requirement for RDKit is the oracle.


Docs rework help

Changes for the developer documentation, mainly helping out with grammar but also trying to simplify the technical side where possible.

I've fixed calling map a table instead of a function.
Also fixed the sentence "that you already have some knowledge", was missing "you".

I think thats good. The last sentence is wrong tho.

(Not display as that would be a reference to itself.)

Because you also have access to display itself. But you shouldn't call that function. Or maybe you can if you want to implement display recursive :rofl:

So lets remove that sentence. Otherwise its good to go imo.
We can always iterate over it later :laughing:
Also hacktoberfest is coming and people love to fix typos ;)

OK, that's done.
I've asked TJ of he can find the drawing I mentioned.
I'll also look at adding screenshots of what should be seen as you run this code.

Thanks :)

But lets do that some other time. Otherwise we never merge it :laughing:

Oh yes, we'll do that later.


Seems like the nothing value messes something up.

commands get
If a list has none value ,it cannot be get

and first that list , it can work

it would be good to have that Cargo.toml file too in order to test with it, if possible.

Its your cargo.toml , just this project,engine-q

it would be good to have that Cargo.toml file too in order to test with it, if possible.

Its your cargo.toml , just this project,engine-q

ok, I see it now. thanks! open Cargo.toml | get bin. Thanks!

ya, it must be something with the $nothing entry, like someone else said in discord.
> open ./Cargo.toml | get bin | flatten
╭───┬───────────────────┬───────────────────────────────────────┬───────────────────╮
│ # │       name        │                 path                  │ required-features │
├───┼───────────────────┼───────────────────────────────────────┼───────────────────┤
│ 0 │ nu_plugin_inc     │ src/plugins/nu_plugin_core_inc.rs     │ inc               │
│ 1 │ nu_plugin_example │ src/plugins/nu_plugin_core_example.rs │ example           │
│ 2 │ nu_plugin_gstat   │ src/plugins/nu_plugin_extra_gstat.rs  │ gstat             │
│ 3 │ engine-q          │ src/main.rs                           │ ❎                │
├───┼───────────────────┼───────────────────────────────────────┼───────────────────┤
│ # │       name        │                 path                  │ required-features │
╰───┴───────────────────┴───────────────────────────────────────┴───────────────────╯

> open ./Cargo.toml | get bin | flatten | get required-features
Error: nu::shell::name_not_found (link)

  × Name not found
   ╭─[entry #15:1:1]
 1 │ open ./Cargo.toml | get bin | flatten | get required-features
   ·                                             ────────┬────────
   ·                                                     ╰── did you mean 'name'?
   ╰────

Seems it has been solved. Then I close this issue


feat: Migrate Ethereum : eth_get_block_by_number from "beerus_rest_api" to "beerus_rpc"

Feature Request
Describe the Feature Request
We are deprecating "beerus_rest_api" and now migrating all the api endpoints to "beerus_rpc".
Migrate eth_get_block_by_number and add tests on beerus_rpc.
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

Self-assigned


Unmap keybinding doesn't work for all keys

As described in "Advanced usage", keybindings can be unmapped.
I tried to unmap Ctrl-k ("C-k") keybinding, as I use it for quick switch between windows (C-h/j/k/l). The method described above does't work, as "C-k" is not in "default_mappings".
Even more, I can't just remap this keybinding, because it seems to be mapped in on_attach callback for each LSP-enabled buffer.
https://github.com/VonHeikemen/lsp-zero.nvim/blob/fb9ae911ef7b40b9d47b23f55cd4acfe8ce1e80f/lua/lsp-zero/server.lua#L148
Is there any way to get control over those mappings too?

The link you mention is part of the section "Customizing nvim-cmp". That's how you configure the autocompletion engine, is not directly related to the "lsp functions".
You can override the default keymaps with the .on_attach function.
local lsp = require('lsp-zero')
lsp.preset('recommended')

lsp.on_attach(function(client, bufnr)
  local noremap = {buffer = bufnr, remap = false}
  local bind = vim.keymap.set

  bind('n', '<C-k>', '<C-w>k', noremap)
end)

lsp.setup()

You could also disable all "lsp keymaps" if you wanted to.
local lsp = require('lsp-zero')
lsp.preset('recommended')

lsp.set_preferences({
  set_lsp_keymaps = false
})

lsp.on_attach(function(client, bufnr)
  local noremap = {buffer = bufnr, remap = false}
  local bind = vim.keymap.set

  -- use bind to make your own keymaps
end)

lsp.setup()

Thank @VonHeikemen for quick response.
Yes, on_attach approach works, though quite hackish (now my mappings are duplicated in original place and in lsp-zero config). As those keybindings are introduced by this plugin, would be great to have a unified way to enable/disable individual keybindings.

You could also disable all "lsp keymaps" if you wanted to.

Yes, I tried that. But I still want to keep majority of those default keybindings, and figuring out how to do it properly would take time.

For better or worse the .on_attach function is the recommended way of making lsp specific keybindings with builtin lsp client.
If it helps, this snippet implements the default keybindings in the .on_attach function. You can modify whatever you like. Explanation for each keybinding can be found in the help page :help lsp-zero-keybindings.
lsp.on_attach(function(client, bufnr)
  local map = function(mode, lhs, rhs)
    local opts = {remap = false, buffer = bufnr}
    vim.keymap.set(mode, lhs, rhs, opts)
  end

  -- LSP actions
  map('n', 'K', '<cmd>lua vim.lsp.buf.hover()<cr>')
  map('n', 'gd', '<cmd>lua vim.lsp.buf.definition()<cr>')
  map('n', 'gD', '<cmd>lua vim.lsp.buf.declaration()<cr>')
  map('n', 'gi', '<cmd>lua vim.lsp.buf.implementation()<cr>')
  map('n', 'go', '<cmd>lua vim.lsp.buf.type_definition()<cr>')
  map('n', 'gr', '<cmd>lua vim.lsp.buf.references()<cr>')
  map('n', '<C-k>', '<cmd>lua vim.lsp.buf.signature_help()<cr>')
  map('n', '<F2>', '<cmd>lua vim.lsp.buf.rename()<cr>')
  map('n', '<F4>', '<cmd>lua vim.lsp.buf.code_action()<cr>')
  map('x', '<F4>', '<cmd>lua vim.lsp.buf.range_code_action()<cr>')

  -- Diagnostics
  map('n', 'gl', '<cmd>lua vim.diagnostic.open_float()<cr>')
  map('n', '[d', '<cmd>lua vim.diagnostic.goto_prev()<cr>')
  map('n', ']d', '<cmd>lua vim.diagnostic.goto_next()<cr>')
end)


AutoZoom with minimum zoom level

Hi,
I would like to use the AutoZoom functionality, but still make it possible to define a minimum zoom level.
Can you tell me how I can accomplish such thing?
Thanks in advance,
Kevin

Hey @KevinSleegers
I just give a try to your interesting issue :)
First, you can use the map options (maxZoom and minZoom) but it strongly limits the map zoom...
I have google it and found this answer: http://stackoverflow.com/questions/2989858/google-maps-v3-enforcing-min-zoom-level-when-using-fitbounds
When using the auto zoom feature, the bundle internally uses a bound in order to wrap all overlay elements and then, make the map fit this bounds. In order to limit the zoom automatically, you need to reproduce this javascript snippet with the library:
google.maps.event.addListener(map, 'zoom_changed', function() {
    var zoomChangeBoundsListener = google.maps.event.addListener(map, 'bounds_changed', function() {
        if (this.getZoom() > 15 && this.initialZoom === undefined) {
            // Change max/min zoom here
            this.setZoom(15);
            this.initialZoom = true;
        }

        google.maps.event.removeListener(zoomChangeBoundsListener);
    });
});

$eventRenderer = $this->get('ivory.google_map.helper.renderer.event.event');
$formatter  = $this->get('ivory.google_map.helper.formatter');

$eventListener = 'zoomChangeBoundsListener';

$code = <<<EOF
if (this.getZoom() > 15 && this.initialZoom === undefined) {
    // Change max/min zoom here
    this.setZoom(15);
    this.initialZoom = true;
}
google.maps.event.removeListener($eventListener);
EOF;

$boundEvent = new Event(
    $map->getVariable(),
    'bounds_changed',
    $formatter->renderClosure($code)
);

$boundEvent->setVariable($eventListener);

$zoomEvent = new Event(
    $map->getVariable(),
    'zoom_changed',
    $formatter->renderClosure($eventRenderer->render($boundEvent))
);

$map->getEventManager()->addEvent($zoomEvent);

I have git it a try and it's working :)


Bug withdrawn application backend

⭐ alot lines added are comments and doc strings! ;-) 400 lines are tests
👁 seed script was viloating validation in the refactored RecruitmentApplication model
What
This PR refactors the RecruitmentApplication model. I found a bug which caused the applicants prioitiy of positions to "come out of sync".  This PR fixes this bug by adding constraints to the RecruitmentApplication model, as well as refactors the save and clean methodes.
Why
First of all; when an application was withdrawn the "active applications" count was not updated. Therefor it as possible to set position priority on a scale of "all applications" including withdrawn applications.
This would cause the priority to not be deterministic. By refershing the page, a new query would be made which fethced the correct priority sequence, but by reprioritizing the priority sequence could come out of sync again.
New validation and helper methodes in RecruitmentApplication
RecruitmentApplication  became extencive because I created helper methodes for almost everything. I also added some validation which should have been implemented before, like validation constrains for reprioritization deadline and priority deadline for recruitment admins.
The logic for update_applicant_state is unchanged.
get_total_interviews is unchanged
get_total_applications is unchanged
Views and tests
Views
Some of the views related to fetching applications for applicant where also refactored.

RecruitmentApplicationForApplicantView now only gives non-withdrawn applications. There is a view dedicated to getting withdrawn applications.

RecruitmentApplicationWithdrawApplicantView was extended with a get methode

RecruitmentApplicationApplicantPriorityView was refactored to work with the refactored RecruitmentApplication model better

Tests

test_withdrawn_application_priority_handling test that priorities are properly managed when applications are withdrawn
test_reapplying_after_withdrawal_priority test that reapplying after withdrawal gets correct priority
test_priority_constraints_with_withdrawn_applications test that priorities stay within bounds of active applications only
test_multiple_withdrawals_and_priorities test complex scenario with multiple withdrawals and reapplications
test_recruiter_priority_update_before_deadline test that recruiter can update priority before the deadline
test_recruiter_priority_update_after_deadline test that recruiter cannot update priority after the deadline
test_deadline_validation_with_multiple_applications test deadline validation with multiple applications
test_applicant_update_application_priority_before_deadline Test that applicant can update their application priorities before the deadline
test_applicant_update_application_priority_after_deadline Test that applicant cannot update their application priorities after the applicant reprioritization deadline
test_applicant_priority_remains_sequential Test that application priorities remain sequential (1,2,3...) when updated
test_deadline_validation_constraints Test application validation against recruitment timeline deadlines
test_priority_validation Test validation of application priority assignments
test_reorder_priorities_edge_cases Test edge cases in priority reordering logic

Replaces backend part of #1542
closes https://github.com/Samfundet/Samfundet4/issues/1535

Hvordan er denne over 1000 linjer lang wut

Hmmm ser ganske greit ut, men burde nok egt vært flere issues, ser ut som  dette er en stor refactor av application og modulasering med _ functionene


fix: AttributeInstance#addModifier not refreshing cachedValue for new modifier values

Doesn’t this do effectively nothing? Since putIfAbsent won’t change the maps contents if the key is already present, the cached value will be the same

Still not good. operation can also change which should invalidate it. also please add a test or two

Resolves #2225


convnext-v2

can convenxtv2 models be converted to tenorflow using the scripts in this repo?

I think they need to be amended.


incorrect xref phospholipid biosynthetic process MetaCyc:LIPASYN-PWY

id: GO:0008654
name: phospholipid biosynthetic process
namespace: biological_process
def: "The chemical reactions and pathways resulting in the formation of phospholipids, any lipid containing phosphoric acid as a mono- or diester." [ISBN:0198506732]
synonym: "phospholipid anabolism" EXACT []
synonym: "phospholipid biosynthesis" EXACT []
synonym: "phospholipid formation" EXACT []
synonym: "phospholipid synthesis" EXACT []
xref: MetaCyc:LIPASYN-PWY
xref: MetaCyc:PHOSLIPSYN-PWY
xref: MetaCyc:PHOSLIPSYN2-PWY
is_a: GO:0044249 ! cellular biosynthetic process
intersection_of: GO:0009058 ! biosynthetic process
intersection_of: has_primary_output CHEBI:16247 ! phospholipid

This is a degradation pathway, not biosynthesis

Fixed in https://github.com/geneontology/go-ontology/pull/23942
(linked the wrong ticket)


Do not use Karma via ng new

Command
new
Description
Stop generating a Karma example framework via ng new. Karma is officially deprecated: https://github.com/karma-runner/karma?tab=readme-ov-file#karma-is-deprecated-and-is-not-accepting-new-features-or-general-bug-fixes
Currently ng new still seems to add packages like karma, karma-jasmine and more. And also use this configuration in angular.json by default.
Describe the solution you'd like
Use another test framework, which is at least not deprecated. Like Jest maybe:
        "test": {
          "builder": "@angular-builders/jest:run",
          "options": {
            "tsConfig": "tsconfig.spec.json",
            "assets": ["src/assets", "src/favicon.ico"],
            "styles": ["src/styles.scss"],
            "scripts": []
          }
        },

Describe alternatives you've considered
No response

Hi @melroy89, thanks for this issue!
We definitely want to get to this as soon as the Jest and Web Test Runner builders move out of the experimental phase.  In the meantime, let's keep an eye on a related issue #25854.


how to show full image in card

When opening an issue please provide a description, any sample code and a detailed description of 1. how to reproduce the issue 2. Expected behavior 3. actual behavior
If you are still encountering a issue please open a new issue with the information above


Quoted object key expected but got { at line 3848 column 5

Fixed invalid JSON

Quoted object key expected but got { at line 3848 column 5

Introducing break: https://github.com/Azure/azure-sdk-for-java/pull/33731

/check-enforcer override


refactor(action): update demo publish to use node 18

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #2
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Updates demo publishing workflow with script that updates demo html scripts to use bundled versions in surge demos.
Introduces neccessary auxiliaries to support writing javascript in this repo.

Example of the surge demo creation can be found here.
Type of change:
Please delete options that are not relevant.

[x] Revision of an existing capability

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow past sessions/schedule to be visible in sessionizer

People reach out to us looking for info on that one session by that one person who talked about some random tech. Expose past sessions and the schedule so that they can seek it out themselves.

For context, the main reason the old sessions aren't in sessionizer is that we were/are trying to run it on a free Heroku Postgres database and the database size was too small for multiple events 😭

This is a good point. Over the past couple years I did increase the DB to a paid tier so we do have data loaded since MinneBar 10 (I think.) As for the very old data, maybe we could dig up some old heroku db dumps - or maybe @jthingelstad has an old wiki dump and we could port it back into the tool?

So when we rebranded and redesigned the website, we did it with this in mind... that the wiki would go away and the web site would now be the source of truth after an event for more marketing type purposes. See: https://minnestar.org/minnebar/past-sessions/
But... Not all of that was implemented (like the sucking of data from sessionizer back to the website) due to time/budget constraints.
I think it's probably worth a larger discussion to figure out where it should live before these tasks are worked on.

I believe I have backups of at least some a few older Minnebars lying around somewhere. Remind me after the event and I’ll see if I can dig any up.


Custom Categories doesnt work

Addon Version
v01.1.6
World of Warcraft Version
Retail
Describe the bug
I can create custom categories, but I can't assign items to them. what am I doing wrong? Drag and drop doesn't work, putting an item in a free slot doesn't work either....
Steps to reproduce

Open options
open Custom Categories
new category
https://i.gyazo.com/f0268ec4667ad2704cdc5922dddbf021.png
drag and drop doesnt work

how can i add items or put them in a free slot?

You need to drag and drop, not pick up an item and put it down.  This will be fixed in a later release, see #129

https://gyazo.com/802bebcbae311c76cb6a8104acb1a17a
i try but, i can't get it, i don't let go of the left button, where should i drag the item to


UI - New Title Headings Design

CC: @adamcogan @christianmorfordwaitessw @bradystroud @AndreasLengkeek @tiagov8
As per my conversation with @tiagov8, we want to redesign the Title Headings to make it look more similar to the old site

Redesign the Title Headings

Figure: Mockup of new title headings
AB#59193

Redesign the Title Headings

Done - New redesigned title headings

Figure: New title heading design


i18n(zh-cn): Add mpa-vs-spa.md translation

What kind of changes does this PR include?

Translated content

Description

Add mpa-vs-spa.md translation

Thank you @Dustella! 🎉

Sorry for causing trouble to the community, I opened this PR because I didn't see the Chinese translations of MPA vs. SPAs and Astro Islands when I looked at the Doc yesterday.Maybe I should read PRs and Issues more carefully later to open PRs


Multicluster: namespace controller should be run only by leader istiod

Bug description
Currently, for the primary cluster, namespace controller is only run by leader to maintain root-certificate. However, for multicluster scenario, it is run by all istiod instances, there maybe some conflicts.

For multi-primary, we could also do something where the remote-secret specifies whether the cluster being accessed is a remote or a primary. If it's a primary, we don't have to setup the namespace controller – that cluster should be running its own.

I'll try to tackle this in the PR you linked.


utilize image and image_worker vars in object defs

Feel free to reopen and add some comments into the yamls.


Prevent side effects when printing frisby objects

Coverage increased (+0.03%) to 92.5% when pulling 2d58ccafcbe49fa4e4080aa0c3c4b3a37744d909 on paulmelnikow:inspect into cf2da202ffe6113584d0f1ac8f96800deb5be539 on MarkHerhold:master.

Coverage increased (+0.03%) to 92.5% when pulling 2d58ccafcbe49fa4e4080aa0c3c4b3a37744d909 on paulmelnikow:inspect into cf2da202ffe6113584d0f1ac8f96800deb5be539 on MarkHerhold:master.

Coverage increased (+0.03%) to 92.5% when pulling 2d58ccafcbe49fa4e4080aa0c3c4b3a37744d909 on paulmelnikow:inspect into cf2da202ffe6113584d0f1ac8f96800deb5be539 on MarkHerhold:master.

Coverage increased (+0.03%) to 92.5% when pulling 4a3c1049f5b4dc03e714632ca8961a86f17814ad on paulmelnikow:inspect into cf2da202ffe6113584d0f1ac8f96800deb5be539 on MarkHerhold:master.

Coverage increased (+0.02%) to 92.574% when pulling 942abfbef5b7036cbfc3ab230719f0cb5a865acf on paulmelnikow:inspect into 0d5e46f9da3137e511cf9338211305a292fc46d8 on MarkHerhold:master.


style: code cleanup

:white_check_mark: Build TheIdServer 7.2.0-user-ole1-0033 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/6686d39a11 by @)

:white_check_mark: Build TheIdServer 7.1.3-user-ole1-0012 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/7b25a25172 by @)

:white_check_mark: Build TheIdServer 7.1.3-user-ole1-0013 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/43bf451c7c by @)


feat: Enable Tilt Value Configuration via WebConfig

Overview
This pull request adds the ability to configure the Tilt value through WebConfig.
Background
Different characters may require unique Tilt values to perform their intended actions. Given this, it is desirable to allow users to set these values themselves.
Usage
Users can now freely set the Tilt value through the WebConfig settings interface.
Impact
This change affects the WebConfig UI and the logic that processes the Tilt value.
Testing
Manual testing was conducted in a local environment to ensure that the Tilt value could be accurately set.
Please review. Thank you!

Looks neat!  I will check this out today when I have some time


⚠ Redacted has degraded performance

In 8e15ec9, Redacted ($RED) experienced degraded performance:

HTTP code: 502
Response time: 16569 ms

Resolved: Redacted performance has improved in b6c0a72 after 31 minutes.


Unable to post comments with umlaut domains in the website field

Checklist

[x] I am running the latest version. Installing Isso from GitHub from the master branch does not fix my issue
[x] I have checked the troubleshooting guide
[x] I have searched the open issues, but my issue has not already been reported

Note: I was unable to get the master branch running, but I compared the source code and the relevant parts didn't change

What is not working?
Posting a comment with an umlaut in the website (IDN) fails. The developer console of the browser shows the error from the server:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>400 Bad Request</title>

Bad Request

Website not Django-conform

I tracked it down to the regex definition in views/comments.py, which only allows [A-Z0-9-].
Using the validator module instead looks promising, otherwise the domain probably needs to be converted to IDN notation before the check.
How can one reproduce this issue?
Enter an IDN domain with an umlaut in any installation, it also fails in the demo in the isso website, and check the developer console.

Should be resolved by https://github.com/posativ/isso/pull/952
Otherwise, please comment if this should still be an ongoing issue.


Fix empty instance bug

This PR fixes the bug where an empty string is stored as one of the batch instances, causing a CODE_ERROR when that instance is run. This is because sec['batch_instances'] has the form "\n...", so the first element of sec['batch_instances'].splitlines() will always be ''.

The commit 94022144a7e40528a9e9be57b31ff65fb5fdd8e7 in the unstable branch already takes care of that.
It also fixes the issue for bin instances inside files, prunes empty bins, and adds support for comments with "#".


An error occurred while running on the real mobile terminal

20:56:20.761 [Vue warn]: Error in mounted hook: "ReferenceError: getComputedStyle is not defined"
20:56:20.824 found in
20:56:20.887 --->
20:56:20.919 　　　　at pages/index/index.vue:1
20:56:20.951 ReferenceError: getComputedStyle is not defined

getComputedStyle has been well supported since Internet Explorer 9 and as far back as Safari iOS 1 and WebView Android 1. Could you please provide more details what exactly is the real mobile terminal in your case?


document callback parameters?

I haven't seen a way to document callback parameters in esdoc. E.g.:
/**
 * @param {function(!param1: number, param2: string): string} callback -
 *        How can I document `param1`, `param2` and callback result?
 */
export function(callback) { /* */ }

In object parameters you can document the object properties using dot notation. Is there a way to specify  the callback function parameters?
The only way I saw documented was to use a @typedef from #53 & #58. Is there a way to document them directly?

Welcome! This should answer your question. Check out the rest of the document for other info on how to handle tags for ESDoc.
https://esdoc.org/tags.html#function
Please close this issue if this answers your question.

So the answer is no? If  you look at tags#object you will see that you can document the properties of an object parameter individually. So that cannot be done with the parameters of a callback parameter? See, for example, Array#find on MDN:

This is, apparently, how it's done with jsdoc:

If the typedef approach isn't suitable then you can use markdown.
/**
 * @param {function(element: *, index: number, array: Array<*>): boolean} callback - Function to execute on each value in the array, taking three arguments:
 * ```
 * element - The current element being processed in the array.
 * index - The index of the current element being processed in the array.
 * array - The array find was called upon.
 * ```
 * @param {!Object} thisArg - Optional. Object to use as this when executing callback.
 */
export default function find(callback, thisArg) { /* */ }

I use this approach for documenting object hashes with two or more levels deep as well as ESDoc doesn't support:
@param object - some hash
@param object.level1.level2 - some nested entry

I'm using the @typedef approach, but thanks for the tip. And, thanks for the welcome, too!


[Maint] Fix comprehensive tests by skipping labels controls test on py311 pyqt6

Fixes/Closes
Closes # https://github.com/napari/napari/issues/5921
Description
In #5439 @Carreau identified a failing condition for the qt_layer_controls test that a results in a fault on python 3.11 and pyqt5 on ubuntu. However, in that PR, pyqt6 was not tested with python 311. The same test can be see to fail in comprehensive tests which do run python 311 and pyqt6.
This PR adds pyqt6 to the check to skip the test.
References
#5439
Type of change

[x] CI test fix

How has this been tested?
Final checklist:

@Czaki I see that https://github.com/napari/napari/pull/5439 is 0.4.18 so this should be as well, even though it just touches CI?

As a note, can we please avoid including github user names in descriptions to avoid having them in commit messages. When a name is in a commit message (in that case me), I get notification each time the commit is pushed into a new branch, which may include forks or people playing with the repository.

I'm sorry for this. (As I'm the caller) and 100% agree, as I also got multiple notifications.

As a note, can we please avoid including github user names in descriptions to avoid having them in commit messages. When a name is in a commit message (in that case me), I get notification each time the commit is pushed into a new branch, which may include forks or people playing with the repository.

That's totally my bad—I had no idea that would/could happen! 😬
Sorry!
(It explains some puzzling notifications I've also gotten recently, so I guess the more you know...)


Scopes passed in orderChanged passed as string "$SCOPE"

I replicated the simple example on my local machine and use version 1.3.1 of the library. When I log the event parameter to console in the orderChanged th itmeScope, sortableScope of both source and dest are set to "$SCOPE"

Not an issue, but a misinterpretation from my end.


Update blog: Verifying Container Image Signatures Within CRI Runtimes

Removing the unused PNG image as mentioned in
https://github.com/kubernetes/website/pull/41776#issuecomment-1609171347.
cc @reylejano @sftim @dipesh-rawat

/approve


feat(*): replace ow with joi

Please describe the changes this PR makes and why it should be merged:
Finally fixes #54 (ow hasn't supported ESM in at least 6 months, it likely never did).
To fix ESM, the package author is planning on moving to ESM only, which in turn will break cjs users (they can still use dynamic imports but it's a pretty terrible solution, plus I don't know if the minifier would recognize this and minify accordingly?). So the option was to alienate esm users, or alienate cjs. The best solution I could think of was to just ditch ow.
Another solution would be to remove validation entirely because Discord's documentation is good enough as a reference for users to use instead. Or someone could roll back changes between v0.7.0 and 0.8.x that causes ow to get used in SlashCommandBuilder?
Another user experiencing the same issue.
Status and versioning classification:

I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added) - changes the errors and likely breaks other things, however all tests pass
Code changes have been tested, or there are no code changes
This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Codecov Report

Merging #56 (91b7b1d) into main (db39cc0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        21
  Lines          264       263    -1
  Branches        33        33
=========================================
- Hits           264       263    -1

Impacted Files
Coverage Δ

src/interactions/contextMenuCommands/Assertions.ts
100.00% <100.00%> (ø)

src/interactions/slashCommands/Assertions.ts
100.00% <100.00%> (ø)

...s/slashCommands/mixins/CommandChannelOptionBase.ts
100.00% <100.00%> (ø)

...ractions/slashCommands/mixins/CommandOptionBase.ts
100.00% <100.00%> (ø)

...s/slashCommands/mixins/CommandOptionWithChoices.ts
100.00% <100.00%> (ø)

...actions/slashCommands/mixins/NameAndDescription.ts
100.00% <100.00%> (ø)

src/messages/embed/Assertions.ts
100.00% <100.00%> (ø)

src/messages/embed/Embed.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db39cc0...91b7b1d. Read the comment docs.

The whole point of the module is to provide TS-and-JS side validation of the data, so you know ahead of time if your commands are valid.
I'd love to know how the errors reported by Joi look like. Does Joi report all validation errors encountered or just the first one?

I'd love to know how the errors reported by Joi look like. Does Joi report all validation errors encountered or just the first one?

When using objects, Joi can report multiple errors (not enabled in this pr yet), but not for each assert.
For example:
const schema = Joi.object().keys({
    a: Joi.string(),
    b: Joi.number()
});

Joi.assert({a: 1, b: false}, schema, { abortEarly: false })

and the error is
    throw error;
    ^

Error [ValidationError]: {
  "b" [2]: false,
  "a" [1]: 1
}

[1] "a" must be a string
[2] "b" must be a number
    at Object.exports.process (\ts\node_modules\joi\lib\errors.js:184:16)
    at Object.internals.entry (\ts\node_modules\joi\lib\validator.js:150:26)
    at Object.exports.entry (\ts\node_modules\joi\lib\validator.js:27:30)
    at internals.Base.validate (\ts\node_modules\joi\lib\base.js:548:26)
    at Object.internals.assert (\ts\node_modules\joi\lib\index.js:225:27)
    at Object.assert (\ts\node_modules\joi\lib\index.js:102:19)
    at Object.<anonymous> (\ts\fff.cjs:9:5)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32) {
  _original: { a: 1, b: false },
  details: [
    {
      message: '"a" must be a string',
      path: [ 'a' ],
      type: 'string.base',
      context: { label: 'a', value: 1, key: 'a' }
    },
    {
      message: '"b" must be a number',
      path: [ 'b' ],
      type: 'number.base',
      context: { label: 'b', value: false, key: 'b' }
    }
  ]
}

Other validation libraries, such as zod or superstruct should be considered as well. My personal vote is for zod. In my opinion, zod's syntax is more concise and it also requires no additional options to be enabled to report all errors. The equivalent of the above example using zod is
const schema = z.object({
    a: z.string(),
    b: z.number()
});

schema.parse({ a: 1, b: false });

which throws
ZodError: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "number",
    "path": [
      "a"
    ],
    "message": "Expected string, received number"
  },
  {
    "code": "invalid_type",
    "expected": "number",
    "received": "boolean",
    "path": [
      "b"
    ],
    "message": "Expected number, received boolean"
  }
]
    at new ZodError (E:\builders\builders-validation\node_modules\.pnpm\zod@3.11.6\node_modules\zod\src\ZodError.ts:140:5)
    at handleResult (E:\builders\builders-validation\node_modules\.pnpm\zod@3.11.6\node_modules\zod\src\types.ts:72:19)
    at ZodObject.ZodType.safeParse (E:\builders\builders-validation\node_modules\.pnpm\zod@3.11.6\node_modules\zod\src\types.ts:184:12)
    at ZodObject.ZodType.parse (E:\builders\builders-validation\node_modules\.pnpm\zod@3.11.6\node_modules\zod\src\types.ts:162:25)
    at Object.<anonymous> (E:\builders\builders-validation\index.ts:16:8)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Module.m._compile (E:\builders\builders-validation\node_modules\.pnpm\ts-node@10.4.0_0cb88d80cb04d25b21fa3ec194608c65\node_modules\ts-node\src\index.ts:1371:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Object.require.extensions.<computed> [as .ts] (E:\builders\builders-validation\node_modules\.pnpm\ts-node@10.4.0_0cb88d80cb04d25b21fa3ec194608c65\node_modules\ts-node\src\index.ts:1374:12)
    at Module.load (node:internal/modules/cjs/loader:981:32) {
  issues: [
    {
      code: 'invalid_type',
      expected: 'string',
      received: 'number',
      path: [Array],
      message: 'Expected string, received number'
    },
    {
      code: 'invalid_type',
      expected: 'number',
      received: 'boolean',
      path: [Array],
      message: 'Expected number, received boolean'
    }
  ],
  format: [Function (anonymous)],
  addIssue: [Function (anonymous)],
  addIssues: [Function (anonymous)],
  flatten: [Function (anonymous)]
}

Honestly I just chose the most popular validation library I could find and really couldn't care less which one replaces ow. If you make a PR in place the maintainers can choose which lib to use I guess.

I would love to see this merged!

awesome!


[TextField] Label shows single space if label prop is set to "" since Version 5.2.4

Duplicates

[ ] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
If the label prop is set to "", its shows an empty space in the textfield-label area.
Version 5.2.4

Expected behavior 🤔
There shouldn't be an empty space like in Version 5.2.3 or other previos versions.
Version 5.2.3

Steps to reproduce 🕹
(https://codesandbox.io/s/formpropstextfields-material-demo-forked-5ynnp?file=/demo.tsx)
Context 🔦
No response
Your environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Duplicate

Duplicate

https://github.com/mui-org/material-ui/issues/30230


Add descriptive message for the pull secret in the config window

Fix few alignment issues, and add correct message for the pull secret
Fix uploading artifacts for circle ci

Verified the UI and artifacts available in the CI from this PR(https://app.circleci.com/pipelines/github/code-ready/tray-macos/14/workflows/eab312f8-4c2e-48b5-ad56-e94a32116f26/jobs/16/artifacts) Merging!


[ci] [docs] docs rendering failing with 'undefined label: 'metadata_routing''

Description
The check-docs CI job is failing with this error that seems to be occurring while rendering the sphinx docs to HTML

Warning, treated as error:
/home/runner/work/LightGBM/LightGBM/python-package/lightgbm/dask.py:docstring of lightgbm.dask.DaskLGBMClassifier:1:undefined label: 'metadata_routing'

(build link)
Reproducible example
I see that in multiple CI builds here, including the latest on master (build link).
I'm able to reproduce this locally in a Python 3.10 environment on macOS, with the following:
mamba install --yes \
    breathe \
    doxygen \
    scikit-learn \
    sphinx \
    sphinx_rtd_theme \
    'scikit-learn>=1.3'

Additional Notes
When downgrading from scikit-learn 1.3.0 to 1.2.2, this error goes away and the docs render correctly. I strongly suspect that it's related to changes in the most recent version of scikit-learn.

strongly suspect that it's related to changes in the most recent version of scikit-learn

scikit-learn v1.3.0 was released 2 days ago (link), which coincides with when I first started seeing these CI failures.
I see the following in the release notes (link)

Metadata routing’s related base methods are included in this release. This feature is only available via the enable_metadata_routing feature flag which can be enabled using sklearn.set_config and sklearn.config_context. For now this feature is mostly useful for third party developers to prepare their code base for metadata routing, and we strongly recommend that they also hide it behind the same feature flag, rather than having it enabled by default.

I'm still reading through this to understand what it means and why it'd show up as a breaking change in the documentation generation.

I think I see the problem.
All of lightgbm's scikit-learn estimators inherit from sklearn.base.BaseEstimator. For example:
https://github.com/microsoft/LightGBM/blob/9f78cceee4911dd56f4635dfd36d4482363db5aa/python-package/lightgbm/compat.py#L73
https://github.com/microsoft/LightGBM/blob/9f78cceee4911dd56f4635dfd36d4482363db5aa/python-package/lightgbm/sklearn.py#L391
https://github.com/microsoft/LightGBM/blob/9f78cceee4911dd56f4635dfd36d4482363db5aa/python-package/lightgbm/sklearn.py#L1068
When we render this project's sphinx docs using sphinx.ext.autodoc, all of the public properties and methods (anything not beginning with a _) get a documentation entry. See, for example, https://lightgbm.readthedocs.io/en/latest/pythonapi/lightgbm.LGBMClassifier.html.
Prior to v1.3.0, sklearn.base.BaseEstimator had only two public methods and 0 public attributes... get_params() and set_params(). Both of those are overridden by LightGBM, and the docstrings are overridden as well.
https://github.com/microsoft/LightGBM/blob/9f78cceee4911dd56f4635dfd36d4482363db5aa/python-package/lightgbm/sklearn.py#L583-L584
https://github.com/microsoft/LightGBM/blob/9f78cceee4911dd56f4635dfd36d4482363db5aa/python-package/lightgbm/sklearn.py#L601-L602
As of v1.3.0, there's now a third public method, BaseEstimator.get_metadata_routing.
from sklearn.base import BaseEstimator
[x for x in dir(BaseEstimator) if not x.startswith("_")]

# ['get_metadata_routing', 'get_params', 'set_params']

Since that isn't overridden by lightgbm, its docstring gets passed directly through to lightgbm's docs-generation process. Unfortunately, that docstring contains a reference to another part of scikit-learn's documentation, which means results in the error reported at the top of this issue.
from sklearn.base import BaseEstimator
BaseEstimator.get_metadata_routing.__doc__

shows:
'Get metadata routing of this object.\n\n        Please check :ref:`User Guide <metadata_routing>` on how the routing\n        mechanism works.\n\n        Returns\n        -------\n        routing : MetadataRequest\n            A :class:`~utils.metadata_routing.MetadataRequest` encapsulating\n            routing information.\n        '

See that <metadata_routing>? That's a documentation link that's assuming you're building alongside scikit-learn's own docs 🙃
It's a reference to this scikit-learn-only :ref: https://github.com/scikit-learn/scikit-learn/blob/b88b53985d9ddf8cec60414934c55a5745e8b958/doc/user_guide.rst#L42

Ok, so what do we do?
I'm going to do the following right now to unblock development in this repo:

put up a PR adding get_metadata_routing() to the public API of LGBMModel, with our own docstring and just transparently passing through to the method from sklearn.base.BaseEstimator

And then after that, I'll do the following:

open a PR in scikit-learn removing that reference to the User Guide, so other projects like xgboost that implement scikit-learn-compatible estimators don't experience this same issue
open a feature request here in LightGBM describing the need to add support for this new "metadata routing" concept to this project's scikit-learn estimators

cc @trivialfis @hcho3, you might see the same thing the next time xgboost's docs build, since xgboost scikit-learn estimators also inherit from sklearn.base.
https://github.com/dmlc/xgboost/blob/f90771eec64cea7b1cb4e41a31000c8c54fcc6d8/python-package/xgboost/compat.py#L48-L50
Hopefully this write-up can save you some time.

Thank you for the detailed analysis @jameslamb ! I saw this PR: https://github.com/microsoft/LightGBM/pull/5956 by @thomasjpfan . XGBoost is using intersphinx as well for making references to related projects like numpy and pandas.

From another repo that inherits BaseEstimator and ran into the same issue, thanks for the research :tada: !

Sure, glad it helped you!


Rethink the error reporting mechanism

All nice and dandy, lsdj_error_t, but:

It requires malloc, and the lib shouldn't assume people want that (or even have it available)
It's overly complex

Using error codes now :)


Progress Bar default color

The Progress Bar provides a default value for the color prop: https://github.com/cerner/terra-core/blob/master/packages/terra-progress-bar/src/ProgressBar.jsx#L27
We have consumers that want to style the progress bar with css instead of the color prop. We should remove the default value for color prop to make it easier for consumers wanting to style with css.

Resolved in #378


Mode-Aware Styles - Brackets In Dreamweaver

Prerequisites

[ ] Can you reproduce the problem with Debug -> Reload Without Extensions?
[ ] Did you perform a cursory search to see if your bug or enhancement is already reported?
[ ] Did you read the Troubleshooting guide?

For more information on how to write a good bug report read here
For more information on how to contribute read here
Description
[Description of the bug or feature]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Versions
Please include the OS and what version of the OS you're running.
Please include the version of Brackets. You can find it under Help -> About Brackets (Windows and Linux) or Brackets -> About Brackets (macOS)

Can anyone explain why the addModeClass flag and mode-aware styles in code colouring themes do NOT work in the Brackets engine integrated into Dreamweaver 2017 ?
Thanks

The Dreamweaver integration is pretty new and there might still be issues. @abose can probably help and get this to the right persons attention

The Dreamweaver integration is pretty new and there might still be issues. @abose can probably help and get this to the right persons attention

Thanks, I appreciative the reply ....

Thanks, I appreciative the reply ....


Does not work anymore

I try to use the cmd teslacmd -a and got
Teslamotors.com logon information loaded from ~/.teslams/config.json
[Error: expecting an array from Tesla Motors cloud service]

I pretty sure the login and password are correct. It looks like Tesla has changed  the API. .Any help would be greatly appreciated.

Should be working now. This does happen some times when Tesla temporarily shuts down their authentication servers.


Multi-threaded downloads and basic caching

I added a ThreadPoolExecutor to speed up the downloading process - seems to help a lot.  I also added some basic caching to speed up restarting a process that failed partially through.  I have 40k photos in my library that I'm trying to back up, so this has made a big difference so far.
Three issues with this approach:

I didn't update the progress bar at all.  It seems to still work fine though, but is kind of random in which file it shows at any given time.
Ctrl-C doesn't always work due to all the threads. I tried to fix this a little but if you just hit it a couple times it eventually works so I gave up.
Caching only sort of helps, since we still need to hit icloud to get the filename of each file to compare with the cache.  I tried on id as well, but that also requires a network hop so it doesn't speed up as much as possible.  Diving into the pyicloud internals more might show a better thing to cache on but I didn't find it quickly.

Great, thanks! I agree that multi-threading is a good idea and will speed things up.
I'm not sure about the need for caching, because we can just check to see if the file exists on the disk, and like you say the network operations are a bottleneck. But pyicloud is doing paginated requests to return the first x photos, so a better way would be to skip any pages that have all been downloaded. We might need to add a new hook in pyicloud so we can see the current page, because at the moment all that pagination logic is hidden.
I think it's probably fine to only support Python > 3.2, but it might be better if we can also support 2.7 and maybe use a library, or some of the other concurrency modules. Oh and also I think the progress bar is fine, as long as it isn't totally broken. But I'm thinking it might be cool to show different progress bars for each thread, and I think tqdm supports that.

Just to add my $0.02, caching would be nice if it allows me to move the downloaded files to another location in the future without making icloudpd "lose its place" in the photo stream or re-download them later on.

I pulled this new version to test and it definitely downloads faster. Easily 3-5x faster. I have 60k+ items so that makes a big difference.
The progress bar is very inaccurate though. It seems to jump through all the items then stops when it gets to 100%. Meanwhile it's continuing to download in the background.
I'm not sure the best way to present the current status while keeping the download speeds fast.
If checksum validation can be added in with these features this is a nearly perfect tool for me to keep an offline backup of my invaluable family photos and videos.
Thank you for all your efforts on this!

Got error python 3.4
  File "/home/orangepi/icloud_photos_downloader/icloudpd/base.py", line 490, in main     with ThreadPoolExecutor() as executor: TypeError: __init__() missing 1 required positional argument: 'max_workers'

Merged in #132


Add instance scale-in protection for nomad-cluster

This change solve issue: https://github.com/hashicorp/terraform-aws-nomad/issues/70
The changes are tested with an existing nomad-cluster without scale-in protection. The optional scale-in protection is set to true.
The terraform plan output is here:
https://gist.github.com/mawa-jnd/1f1ee3c744f9c38718527c240a5d9475
The change is:

backward compatible
has no downtime with default setup as changing the ASG will not automatically restart instances

Tests passed! Merging now.

https://github.com/hashicorp/terraform-aws-nomad/releases/tag/v0.6.4


fix: separate component registration from components

@alvrs This is a fix for the component registration issue I mentioned in discord, where you can't deploy a new component with an existing ID (RegisterSystem expects the owner of the old component to be the new component, instead of the deployer).
2 and 3 don't have to be in the same PR as 1, but they're very related breaking changes that would go well together imo.

Make world.registerComponent call external, like with systems. Remove registerWorld from components.
id in Component constructor only existed to support registerWorld, remove it as well. This simplifies the constructor and the component state. Id can still be obtained via getIdByAddress when needed.
In Component's constructor change world from address to IWorld. I assume it was address because some components (like world's registries) had to have world separately initialized, and the constructor could receive address(0). That is no longer the case, and component constructor now treats world exactly the same as system constructor. This also simplifies Component creation (all the places I've seen had to cast IWorld to address).

World.init, std-contracts, tests, LibDeploy.ejs are changed to support the new constructor and registration.
I don't think this breaks any other packages, but I may have missed something.
This is naturally a breaking change for any project that implements or deploys components

Sure, closed it for now, will look out for v2 branch


DRF JWT [non_field_errors: 'Invalid payload.'] on custom payload handlers

I have had an issue related to custom payload handlers. My Django User Model uses the user email as the means of authentication (i.e. username).
Therefore, as I have concluded, you must have a method that overrides the default username field to 'email'.
Just for clarification for those looking for an answer in the future, I have managed to solve it. The problem lied at the payload handlers.
I had overwritten the payload and response payload handlers respectively in such way:
def jwt_payload_handler(user):
   return {
       'user_id': user.pk,
<<<<         'email': user.email,>>>>
       'is_cidadao': user.is_cidadao,
       'is_politico': user.is_politico,
        'exp': datetime.utcnow() + api_settings.JWT_EXPIRATION_DELTA,
       'orig_iat': timegm(
           datetime.utcnow().utctimetuple()
       )
   }
def jwt_response_payload_handler(token, user=None, request=None):
    return {
        'token': token,
<<<<        'email': user.email,>>>>
        'is_cidadao': user.is_cidadao,
        'is_politico': user.is_politico,
    }
OTHERWISE, it is possible to fix this by declaring the 'username' field on the first level (outside any objects) of the payload handlers. Notice the email field in bold, it should, therefore be changed to
def jwt_payload_handler(user):
   return {
        'user_id': user.pk,
<<<<        'username': user.email,>>>>
        'is_cidadao': user.is_cidadao,
        'is_politico': user.is_politico,
        'exp': datetime.utcnow() + api_settings.JWT_EXPIRATION_DELTA,
        'orig_iat': timegm(
            datetime.utcnow().utctimetuple()
        )
    }
def jwt_response_payload_handler(token, user=None, request=None):
    return {
        'token': token,
<<<<        'username': user.email,>>>>
        'is_cidadao': user.is_cidadao,
        'is_politico': user.is_politico,
    }
I have solved this using feedback given in issues #284 and #145.

Closing as duplicate of #284 then.
Thanks for reporting back.
Over there a possible solution was mentioned.. wanna give this a try?

@ebotean Thanks a lot for your feedback on this issue, I was lost because of this message ! Thank you !


Some workarounds for DAdaption loss going NaN

I've been having an issue where loss goes to NaN when using DAdaptation, but after days of debugging I came up with a few things that can cause this.  (DAdaptation is so fragile...)
This applies to LoRA and LoCon model training:

I have to include betas as an optimizer arg for DAdaptAdam. --optimizer_args "decouple=True" "weight_decay=1.0" "betas=0.9,0.99" Not sure why.  Otherwise loss goes NaN. (weight_decay can vary 1.0-0.01)
Don't include a --vae, or at least not the Av3 VAE, else loss goes NaN
Don't accidentally include --max_token_length if you are not training with captions.  Loss will go NaN if set above default.

edit: even when training with captions I get NaN after a hundreds steps when setting this value above default :(

Alpha must match Dim.  Leaving Alpha=1, loss will go NaN, though a little slower than the rest

I'm still tinkering but ill update with more details if I find any other bad arguments.
Hope it helps, DAdaptation is promising, but a pain to use so far.
related: https://github.com/kohya-ss/sd-scripts/issues/570

can you provide you config about steps?
image number、repeat、epoch and so on...

Sure.
I recommend using the latest optimizer Prodigy, which is very effective.
I will soon publish a related tutorial article on Civitai.

Had some success with DAdaptation + cosine_with_restarts.  I just had to ignore all the others here mentioning that you should use constant with DAdaptation ¯\_(ツ)_/¯
But I agree that DAdaptation learns much faster than ADAfactor.  You can see DAdaptation reach peak LR in a fraction of the time it takes ADAFactor to do the same.  ADAFactor still seems more hands-off and stable overall, but ill have to compare results to tell which I want to stick with.


Issue #669 Check if crc VM exist before executing cmd functions.

Commands which require user input or expose some message should check
if crc vm exist, before display the message (or take user input).
$ ./crc stop
Stopping CodeReady Containers instance... this may take a few minutes
ERRO Error occurred: Machine "crc" does not exist. Use "crc start" to add a new one.

$ ./crc delete
Do you want to delete the crc VM? [y/N]: y
ERRO Error occurred: Machine "crc" does not exist. Use "crc start" to add a new one.

@cfergeau should the exit code in this case is 0 or 1 I am incline to have it 0 since the VM is not even exist so the command just display that and exit with message ?

@cfergeau should the exit code in this case is 0 or 1 I am incline to have it 0 since the VM is not even exist so the command just display that and exit with message ?

I would return 1 as it's an error to call it on a non existing VM. That's similar to calling virsh undefine nonexistentvm which returns 1


page event type should not require name payload value

per segments docs name is optional https://segment.com/docs/spec/page/

Maybe im confused it appears to be prepending category to my trackings
analytics.page('Web App v3', '/scheduler', {
  name: '/scheduler',
  category: 'Web App v3',
  path: '/scheduler',

which is NOT what i want i want to send a request like so
analytics.page('/scheduler', {
  name: '/scheduler',
  category: 'Web App v3',
  path: '/scheduler',

Is that possible?


Improve vue build help (facing a "Failed to locate entry file" error)

What problem does this feature solve?
After creating a project with the cli, I cd into the project folder and run vue build, only to get a Failed to locate entry file error. When I try run vue build --help, I get this:
$ vue build --help

  Usage: build [options] [entry]

  build a .js or .vue file in production mode with zero config

  Options:

    -t, --target <target>  Build target (app | lib | wc | wc-async, default: app)
    -n, --name <name>      name for lib or web-component mode (default: entry filename)
    -d, --dest <dir>       output directory (default: dist)
    -h, --help             output usage information

That optional entry argument is not document. Since it's optional, I was not providing. Turns out that running vue build ./src/main.js works.
What does the proposed API look like?
It would be great if the use of the optional entry argument was explained in the cli help or if the cli could automatically figure it out, perhaps by reading the entry from the cli-controlled webpack config:
  entry: {
    app: [
      './src/main.js'
    ]
  }

I'm not quite sure I understand? Did you or did you not use the --target option? you talk about it as if you did, yet nowhere in your snippets did you use it.

The entry argument, not target. It’s shown in brackets, which leads me to believe that it’s optional.

Well it is optional, and /src/main.js is the default, which is why I was confused.
If that doesn't work for you, please provide a repository with a project that reproduces your issue.

Sure. It's just after running vue create hello-world. I pushed it here: https://github.com/cmermingas/vue-hello-world

Well, you should run npm run build rather than vue build.
They are two different commands.

npm run build runs vue-cli-service build underlyingly, and its default entry is src/main.js.
vue build is for instant prototyping only. Its default entry is one of main.js, index.js, App.vue or app.vue in the current directory.

@sodatea - My only request on this issue is to improve the CLI help. If the help said what you typed in the second bullet in your comment above, it would have been clear from the beginning and I wouldn't have been motivated to open this ticket. Instead, the help says build a .js or .vue file in production mode with zero config, which is misleading because:

It says production, which contradicts your statement about instant prototyping only.
It doesn't mention that the file used must be given in the entry argument.
It doesn't indicate what this optional entry argument defaults to.

While I think we can indeed improve this, I'm not sure all of your points are valid. We don't aim to replicate all of the extensive documentation that we provide on https://cli.vuejs.org.
Sure, the CLI help should be able to give correct istance pointers about what each option does, but that does not free the developer from reading the documentation to learn how to use a tool correctly in all circumstances.

It says production, which contradicts your statement about instant prototyping only.

Well, the term mode has a special meaning, see here, and it certainly does not
In that context, I think this phrase is absolutely correct:

vue build will build your prototype in production mode
vue serve will run your prototype in development  mode, with a dev server, hot releading, no minimizing etc.

It doesn't mention that the file used must be given in the entry argument.

Because you don't have to provide the argument if you use any of the default values.

It doesn't indicate what this optional entry argument defaults to.

We should document these defaults in the cli help, no argument here

I think the use of the term entry was inadvisable, as I had assumed it to be a webpack entry and it isn't. I think it would be helpful if the documentation clarified that the vue-cli lib [entry] is not a webpack entry, but simple a file path to the 'root' file to build the library export.
It took me a while to get it working, as I had kind of assumed that it was a webpack entry and it took a few readings of the docs to realise it referred to a file. One could argue that reading the documents properly would help, but the reality is that people skim read these things and so I feel a short bracketed note or similar would be helpful.

I do think that it is a bit difficult on newbies (just the kind of people who use vue cli without knowing webpack very well) to expect them to realize that they should just use 'npm run build' instead of all the options mentioned in the guide.


feature(Errors) add information to errors & fix JSDoc

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>
Checklist

[ ]  A link to the issue/user story that the pull request relates to
[ ]  How to recreate the problem without the fix
[x]  Design of the fix
[ ]  How to prove that the fix works
[x]  Automated tests that prove the fix keeps on working
[ ]  Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story
This PR provides improvements to the composer-concerto error handling:

Adds fileName field to fileLocation in errors when possible
Adds component field to errors which defaults to composer-concerto but can let consumers set their own.
Fixes to JSDoc for errors

Steps to Reproduce

Existing issues

[x] Stack Overflow issues
[x] GitHub Issues
[ ] Rocket Chat history

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

@dselman Thanks. I've made a few additional changes to errors, so it may be worth a further review.


Fix deep comparison checks

Codecov Report

Merging #34 (98a7de2) into main (a51c4bf) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   77.52%   77.56%   +0.04%
==========================================
  Files          55       55
  Lines        2051     2055       +4
==========================================
+ Hits         1590     1594       +4
  Misses        371      371
  Partials       90       90

Impacted Files
Coverage Δ

internal/checks/comparison.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51c4bf...98a7de2. Read the comment docs.


Use colors from GUI dev feedback for bones

Tune metallic properties of default materials to make "bones" less metallic.

Thanks @AlbertoCasasOrtiz


Cloning this repository and running npm run bootstrap throws a TypeScript compilation error.

Not a regular user of typescript so I’m probably just a big dummy.
node version: v8.11.1
npm version: v5.6.0
os: Mac High Sierra 10.13.4
13 error src/index.ts(55,50): error TS2345: Argument of type 'DocumentNode' is not assignable to parameter of type 'DocumentNode'.
13 error   Types of property 'loc' are incompatible.
13 error     Type 'Location' is not assignable to type 'Location'. Two different types with this name exist, but they are unrelated.
13 error       Types of property 'startToken' are incompatible.
13 error         Type 'Token' is not assignable to type 'Token'. Two different types with this name exist, but they are unrelated.
13 error           Types of property 'kind' are incompatible.
13 error             Type 'TokenKind' is not assignable to type '"<SOF>" | "<EOF>" | "!" | "$" | "(" | ")" | "..." | ":" | "=" | "@" | "[" | "]" | "{" | "|" | "}"...'.
13 error               Type '"BlockString"' is not assignable to type '"<SOF>" | "<EOF>" | "!" | "$" | "(" | ")" | "..." | ":" | "=" | "@" | "[" | "]" | "{" | "|" | "}"...'.
13 error src/index.ts(59,51): error TS2345: Argument of type 'DocumentNode' is not assignable to parameter of type 'DocumentNode'.
13 error src/index.ts(63,30): error TS2345: Argument of type 'DocumentNode' is not assignable to parameter of type 'DocumentNode'.
13 error src/index.ts(88,21): error TS90010: Type 'DocumentNode' is not assignable to type 'DocumentNode'. Two different types with this name exist, but they are unrelated.
13 error src/index.ts(88,21): error TS90010: Type 'DocumentNode' is not assignable to type 'DocumentNode'. Two different types with this name exist, but they are unrelated.
13 error   Types of property 'definitions' are incompatible.
13 error     Type 'DefinitionNode[]' is not assignable to type 'DefinitionNode[]'. Two different types with this name exist, but they are unrelated.
13 error       Type 'DefinitionNode' is not assignable to type 'DefinitionNode'. Two different types with this name exist, but they are unrelated.
13 error         Type 'TypeExtensionDefinitionNode' is not assignable to type 'DefinitionNode'.
13 error           Type 'TypeExtensionDefinitionNode' is not assignable to type 'DirectiveDefinitionNode'.
13 error             Types of property 'kind' are incompatible.
13 error               Type '"TypeExtensionDefinition"' is not assignable to type '"DirectiveDefinition"'.

This should now be fixed (but please let us know otherwise). Thanks!


Add the ability to only check for a cache key without restoring

Overview
In some situations it helps to have a way to only check that a cache key exists without spending the extra time to download the cache: for example when you have a job that handles building and a separate job that handles running tests.
The job that builds is a NOOP when the cache exists but it needs to verify first. If the build is pretty large that adds time spent downloading a payload that gets ignored and then downloaded again in the other job.
Fixes: #321
❗ Until this gets merged
This can be used today by referencing bowd/cache@v3 in the actions instead of actions/cache@v2
The input is only-check-key. If that is set to true it will skip the downloading but output the same cache-hit as the normal flow.

Also unrelated to this CI is failing because of this: https://github.com/actions/toolkit/pull/589

If anyone else stumbles across this, https://github.com/marketplace/actions/cache now has lookup-only.


style(play button): removed unused css and added clearer colors

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change
After working a lot with the web interface of mohca, I noticed that the play button to start a test is not vertically aligned and the colors are not clear enough (not easy to find the action button).
This PR fixes those issue with just adding a dark border and making the play icon a bit darker.
Alternate Designs
I believe that the web interface should be updated (and added dark mode  🌙)
Why should this be in core?
A feature that is being used so much should be clearer to see (better UX)
Benefits
Clearer UX helps the user find the button faster and use it more
Possible Drawbacks
none.. (maybe some users will miss the challenge of looking for the button)
Applicable issues
none

Coverage remained the same at 94.143% when pulling 8fa8dc10474eea34db540ec5317f361e1920d3d0 on eifr0980:changed-style-of-'play-button' into bc8ce0535d2b94c6f4cd3c23a0d9ccce87d6e53b on mochajs:master.


Functions Config not saved from console

Summary
I can not save config from the UI, here are the steps to re-produce
1- Create a function
2- Add Config
3- Save the function
4- Config is not saved
System configuration and versions

Jitsu Next
Artifacts (logs, etc)

@mabumusa1
Functions Config was a design concept that was unintentionally released into production.
It is now time to remove it.
For now you can configure using constants within the function code.