WinRMv2.1 Support

Add support for the new V2.1 version of the WinRM Gem.
This Gem uses the PSRP protocol to communicate to PowerShell
processes running on the Windows server.
Except for elevated processes needed to access network shares (see below)
this support allows powershell to run across invocations of WinRM.  Variables
created in one invocation can continue to be accessed in further invocations
using the same shell.
The API has changed somewhat requiring changes in the Microsoft Provider code
as well as in the gems/pending code for SCVMM/HyperV SSA.
@roliveri @Fryguy @djberg96 please review and merge.

@jerryk55 v2 is supposed to have nicer stderr output isn't it? Is that something we could use here?

@djberg96 @roliveri Getting close to making this real and taking off the WIP flag.  You may want to pre-review.  :-)  Tests are looking good.

@djberg96 @roliveri updates made based on comments.  Failing spec tests based on no longer relevant gem API removed.  Ready to review and merge when appropriate.  Removing WIP title.

👍 LGTM

@djberg96 @roliveri its always nice when the tests actually find an issue in the code.  connection option handling has changed and fixes were required in some of the credential validation code both for hosts and providers.  in addition the spec tests in question needed some modification.  If the tests go green this can be merged.

@djberg96 @roliveri any chance of merging this?  Thanks!

@roliveri I do not have such power. Rich?

@jerryk55 Should this be euwe yes or no?

It speeds some SCVMM SSA up, but doesn't fix any issues, so I would say no.
On Mon, Oct 17, 2016 at 4:57 PM, Richard Oliveri<EMAIL_ADDRESS>wrote:

@jerryk55 https://github.com/jerryk55 Should this be euwe yes or no?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq/pull/9867#issuecomment-254331676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF1cZ-XjNWHw21Rywm75UjSKNsPm1W31ks5q0-EjgaJpZM4JNylj
.

--
--
Jerry Keselman
Principal Software<EMAIL_ADDRESS>| p.<PHONE_NUMBER>


How to style a row dynamically in version 3.1 [QUESTION]

I want to color a row based on a column value. If the value of the column is 0 it should be red and if the value of the column is 1 it should be green.
also I want to format a cell based on a column.
`<?php
namespace App\Exports;
use App\Book;
use Maatwebsite\Excel\Concerns\FromCollection;
use Maatwebsite\Excel\Concerns\WithHeadings;
#use Maatwebsite\Excel\Concerns\WithColumnFormatting;
use Maatwebsite\Excel\Concerns\ShouldAutoSize;
use Maatwebsite\Excel\Concerns\WithStyles;
use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
class CsvDataExport implements FromCollection, WithHeadings, ShouldAutoSize,WithStyles#,WithColumnFormatting
{
public function columnFormats(): array
{
    return [
        'N' => "###-###-####"
    ];
}

public function styles(Worksheet $sheet)
{
    return [
        // Style the first row as bold text.
        1    => ['font' => ['bold' => true]],

        // // Styling a specific cell by coordinate.
        // 'B2' => ['font' => ['italic' => true]],

        // // Styling an entire column.
        // 'C'  => ['font' => ['size' => 16]],
    ];
}

/**
 * @return \Illuminate\Support\Collection
 */
public function collection()
{
    return collect( \DB::select( \DB::raw("SELECT 'no' as no, contact_duplication_removal.*,CONCAT (PHONE_NUMBER_MOBILE, '_', name_of_contact_the_person_who,'_',age) AS Group1 FROM contact_duplication_removal  group by Group1 order by NAME_OF_THE_PATIENT,NAME_OF_CONTACT_THE_PERSON_WHO,name_of_the_panchayatmunicipal ") ))->transform(function($item, $key) {
        $item->no = $key+1;
        unset($item->Group1);
        unset($item->id);
        unset($item->empty_name);
        return $item;
    });

}

public function headings(): array
{
    return ['NO','Contact ID',
        'Name of the patient',
        'Name of  Contact (the person who had contact with identified +ve case)',
        'Age'

    ];

}

}
`
Versions

PHP version: 7.3
Laravel version: 5.8
Package version:3.1

What else information needed ?
my controller cod is
`
public function export()
{
$name="contact_duplicate_removed".date("d-m-Y  H:i A").'.xlsx';
return \Excel::download(new CsvDataExport(), $name);
}
`

You'll have to use PhpSpreadsheet directly inside the styles() method.
https://phpspreadsheet.readthedocs.io/en/latest/topics/recipes/#conditional-formatting-a-cell
The $sheet parameter is equivalent to the getActiveSheet

Thanks for the reply,   Where does it specify the particular column  which is going to compare? I assume it can be specified inside   $conditional1->addCondition(A3==0); is it okay ?
\PhpOffice\PhpSpreadsheet\Style\Conditional();  is it accessible after installing matwebsite package in laravel.?
`
public function styles(Worksheet $sheet)
{
$conditional1 = new \PhpOffice\PhpSpreadsheet\Style\Conditional();
$conditional1->setConditionType(\PhpOffice\PhpSpreadsheet\Style\Conditional::CONDITION_CELLIS);
$conditional1->setOperatorType(\PhpOffice\PhpSpreadsheet\Style\Conditional::OPERATOR_EQUAL);
$conditional1->addCondition('0');
$conditional1->getStyle()->getFont()->getColor()->setARGB(\PhpOffice\PhpSpreadsheet\Style\Color::COLOR_RED);
$conditional1->getStyle()->getFont()->setBold(true);
$conditional2 = new \PhpOffice\PhpSpreadsheet\Style\Conditional();
$conditional2->setConditionType(\PhpOffice\PhpSpreadsheet\Style\Conditional::CONDITION_CELLIS);
$conditional2->setOperatorType(\PhpOffice\PhpSpreadsheet\Style\Conditional::OPERATOR_EQUAL);
$conditional2->addCondition('1');
$conditional2->getStyle()->getFont()->getColor()->setARGB(\PhpOffice\PhpSpreadsheet\Style\Color::COLOR_GREEN);
$conditional2->getStyle()->getFont()->setBold(true);
$conditionalStyles = $sheet->getStyle('B2')->getConditionalStyles();
$conditionalStyles[] = $conditional1;
$conditionalStyles[] = $conditional2;
$sheet->getStyle('B2')->setConditionalStyles($conditionalStyles);
}
`

\PhpOffice\PhpSpreadsheet\Style\Conditional(); is it accessible after installing matwebsite package in laravel.?
Yes, this package is w wrapper for PhpSpreadsheet so all its classes are accessible.

I have never used it myself, so you'll have to dive in the docs to find out how it works. You can always open a question on StackOverflow if you need more help with it.


Contribution guidelines

Closes #421

Nice! It's a great idea to include contribution guidelines in the project. Just some comments I added.
(Also, you could rebase onto dev to avoid the merge changes)

Merged.


Upgrade LVL to AGP 8.1.4.

Upgrade the licensing library to be compatible with Gradle 8.2 and AGP 8.1.4.

I have build.gradle with this line:
implementation 'com.github.google:play-licensing:-SNAPSHOT'
and got an error:
Failed to resolve: com.github.google:play-licensing:-SNAPSHOT
This entry will no longer be shared?

@splendapps The library is not published with Gradle. You can refer to https://developer.android.com/google/play/licensing for a guide on how to integrate and customize the license check in your app.
For further problems, please file a separate issue which would make it easier to contain the relevant information necessary for troubleshooting the problem. Thank you!

@splendapps Did you figure how to make it work using the line
implementation 'com.github.google:play-licensing:-SNAPSHOT'
?
Thank you.

Yes, thanks! Everything work well!

Yes, thanks! Everything work well!

Thank you for your reply, but, what changes have you made?
Still using the
implementation 'com.github.google:play-licensing:-SNAPSHOT'
line?

No, just implemented licensing it in the following method you recommended:
https://developer.android.com/google/play/licensing/setting-up

@KhaledHelmy Please, I have created a new ( #10 ) issue!
Thank you!


Building from source does not work any longer?

I did the following:
git clone https://github.com/openanalytics/shinyproxy.git
cd shinyproxy/
mvn -U clean install

This seems not to work any longer.
I get the following error:
Downloading: http://nexus.openanalytics.eu/nexus/content/repositories/releases/org/springframework/boot/spring-boot-starter-parent/2.0.0.RELEASE/spring-boot-starter-parent-2.0.0.RELEASE.pom
Downloading: http://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.0.0.RELEASE/spring-boot-starter-parent-2.0.0.RELEASE.pom
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project eu.openanalytics:shinyproxy:2.3.0 (/home/administrator/testing/shinyproxy/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM: Could not transfer artifact org.springframework.boot:spring-boot-starter-parent:pom:2.0.0.RELEASE from/to central (http://repo.maven.apache.org/maven2): Failed to transfer file: http://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-starter-parent/2.0.0.RELEASE/spring-boot-starter-parent-2.0.0.RELEASE.pom. Return code is: 501 , ReasonPhrase:HTTPS Required. and 'parent.relativePath' points at no local POM @ line 19, column 10 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

Something in the pom.xml file seems to be wrong. Please help me how to fix this issue :-)

Thanks for reporting, @MarkusLang1987 Do you still have this issue? I was able to build fine from the current state of the git repo.

This is because the pom.xml is referring to http urls and all urls should be https. This will get solved in the next release. In the meantime you can simply replace http:// by https://


Overlord: Music tweak struct.

Pull Request Test Coverage Report for Build 861839371

1 of 3 (33.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.022%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

game/overlord/iso_cd.cpp
0
2
0.0%

Totals

Change from base Build 861467434:
0.0%

Covered Lines:
34569

Relevant Lines:
50084

💛  - Coveralls


Decimal adjustment (DAA) result error

It adds 06 to any numbers (i.e. although the number is less than 0xA) to adjust decimal using DAA after once DAA executed for number greater than 0x9.

DAA memonics is broken keeps adding 06 for any numbers after  DAA executed  BCD giving result 9. eg 34 after daa gives 3A

@baikunth2a Can you share an example that is failing? The output you are observering and the expected one will be good to know.

@debjitbis08  Thanks for responding. Please observe the result of following program.
MVI A, 0AH
DAA
MVI A, 01H
DAA
HLT

@baikunth2a This is happening because the AC flag is being set by the first DAA instruction. You would need to handle the flag value from the first DAA execution.
From the documentation,
DAA operates as follows:

If the least significant four bits of the accumulator have a value greater than nine, or if the auxiliary
carry flag is ON, DAA adds six to the accumulator.
If the most significant four bits of the accumulator have a value greater than nine, or if the carry
flag is ON, DAA adds six to the most significant four bits of the accumulator.

Hope this helps.

Hi, I'm facing a similar issue with DAA. Here is my code to convert hex to bcd:
`;
jmp start
;code
start: LDA 2050H
MOV C, A
MVI D, 00H
MVI A, 00H
loop: ADI 01H
DAA
JNC skip
INR D
skip: DCR C
JNZ loop
MOV L, A
MOV H, D
SHLD 2060H
hlt`
When I insert FF at 2050, the expected output is 55 at 2060 and 02 at 2061; instead I'm getting 13 at 2060 and 0B at 2061. I cross checked my code on these websites:
https://www.tutorialspoint.com/8085-program-to-convert-hex-to-bcd
https://www.zseries.in/embedded lab/8085 programs/hex to bcd conversion.php#.X6Efq3xR201

Hi, I'm facing a similar issue with DAA. Here is my code to convert hex to
bcd:
`;
jmp start
;code
start: LDA 2050H
MOV C, A
MVI D, 00H
MVI A, 00H
loop: ADI 01H
DAA
JNC skip
INR D
skip: DCR C
JNZ loop
MOV L, A
MOV H, D
SHLD 2060H
hlt`
When I insert FF at 2050, the expected output is 55 at 2060 and 02 at 2061;
instead I'm getting 13 at 2060 and 0B at 2061. I cross checked my code on
these websites:
https://www.tutorialspoint.com/8085-program-to-convert-hex-to-bcd
https://www.zseries.in/embedded lab/8085 programs/hex to bcd conversion.php#.X6Efq3xR201
On Fri, Oct 23, 2020, 11:31 AM Debjit Biswas<EMAIL_ADDRESS>wrote:

@baikunth2a https://github.com/baikunth2a Can you share an example that
is failing? The output you are observering and the expected one will be
good to know.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/debjitbis08/sim8085/issues/18#issuecomment-714927705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQYBATKWH45FPI6WJOQSXHLSMEKDFANCNFSM4R4BEVVQ
.

@abhishekUpmanyu that's because the AC flag was set by DCR C, and 06/60 was being added to the accumulator after DAA since it takes AC flag into account.
Just load 02H in C and see the result. The expected result is 02H, but due to the DCR C instruction the result becomes 08H (02H + 06H) after DAA. So, you'll have to handle the AC flag yourself.

@jarp0l After DCR C, ADI 01H will be there, so Flags should again get adjusted (Reset) properly before getting up to DAA. So yes this is an error with sim8085 itself...

Fixed the AC flag handling in ADI.


Are extra GIT variables in 1.78.0 necessary?

VS Code Version: 1.78.0
OS Version: Windows 21H2 + Cygwin

The terminal session in Code is only useful to me so long as it behaves exactly as would a bash run outside of Code. Until this update, the output of env was exactly the same no matter how I started bash. Now, these variables are exported:

VSCODE_GIT_ASKPASS_NODE
GIT_ASKPASS
VSCODE_GIT_ASKPASS_EXTRA_ARGS
VSCODE_GIT_IPC_HANDLE
VSCODE_GIT_ASKPASS_MAIN

In case it matters, my git environment cannot use passwords and I've never seen a prompt for one. I run git from the Cygwin command line.
Are they necessary for the terminal to function. How do I prevent them from appearing? (Short of unseting them.)

I don't know what the previous version was. I accept updates within a week, so I expect it was reasonably current. But, more to the point, it's likely been a long time since I last ran anything in a Code terminal that cares about the environment variables.
Setting git.useIntegratedAskPass to false cuts the extra variables down to this:
 env | grep -E 'VSCODE|GIT'
VSCODE_GIT_IPC_HANDLE=\\.\pipe\vscode-git-c44ffff26a-sock

And this is gets me close enough. Thank you.


[Q] SRT plugin multiple connections

Hello. Is it possible to make TSDuck Srt plugin accept multiple connections in listener mode? Now its allow only one connection.
Thank you.

Do you refer to the srt input plugin or output plugin?
Do you mean multiple simultaneous connections or multiple sequential connections?

SRT output plugin in listener mode.  Multiple simultaneous connections.
Multiple sequential connections working with --multiple key, as i understand.

SRT output plugin in listener mode. Multiple simultaneous connections.

This is not possible. Only RIST has built-in support for multiple simultaneous outputs. Using SRT, this must be manually achieved inside the application, here tsp. The tsp processing model is one input / one output through simple plugins.

Multiple sequential connections working with --multiple key, as i understand.

Exactly.

Hint:  You could have a look to sls (SRT-Live-Server)


Make convertSemesters as pure function

Summary
The firestoreCourseToAppCourse is still doing too many things. After talking with @hanywang2, looks like the predecessor of this function convertCourse is doing two things at once: converting data from firestore and converting data from course roster. This is very bad because it makes it very hard to reason about what kind of data we are dealing with, and it caused a tight coupling between data conversion and component logic.
This PR starts to unentangle it. It's obvious from context that convertSemesters is only dealing with firebase data, so we can see how we can simplify it. We know in the firestore data that every course has a unique id and a color, so there is no need to call some code to create color and id for it. I believe those code is written for course roster data.
To avoid doing too many things at once in this PR, I still keep the ugly callback structure in firestoreCourseToAppCourse (the incrementID and addColor callback), but make the callback passed into firestoreCourseToAppCourse from convertSemesters no longer having side effect. After this, convertCourse will finally become a pure function!
Test Plan
I added some assertions that this is safe. You can load and look at the console that none of the error newly added is thrown.

subsumed in #185.


Model state not updated after setting value

Trying to accomplish something like this post: https://github.com/ngx-formly/ngx-formly/issues/180
I want to auto format the users input as they type but the model state is a step behind.
https://stackblitz.com/edit/angular-zmw9wb-ubt9vw?file=src%2Fapp%2Fapp.component.html
Does anyone have thoughts on how to solve this or an alternate way to accomplish formatting user input?

use distinctUntilChanged() and remove emitEvent parameter:
hooks: {
  onInit: ({ formControl }) => {
    return formControl.valueChanges.pipe(
      distinctUntilChanged(),
      startWith(formControl.value),
      tap((v) => {
        if (v) {
          formControl.patchValue(v.toUpperCase());
        }
      }),
    );
  }
}

https://stackblitz.com/edit/angular-zmw9wb-2gwah5?file=src/app/app.component.ts


#1: Reporting Tool

Added some basic project structure/common code as well as the basics of the reporting tool. This tool will be modified slightly in the future, but the base is there.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ecb69af). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   90.00%
=======================================
  Files           ?        1
  Lines           ?       10
  Branches        ?        0
=======================================
  Hits            ?        9
  Misses          ?        1
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb69af...5a53e64. Read the comment docs.

Closes #1


podnetwork: TestRouting and TestKeepAlive fails on Github's runner

The podnetwork's TestRouting and TestKeepAlive tests (in pkg/podnetwork/tunneler/routing) fail int the Ubuntu runner of Github (even though running as root).
The error is like:
=== RUN   TestKeepAlive
    keepalive_test.go:32: failed to add vrf ppvrf1: failed to create an interface of vrf: ppvrf1:  operation not supported
--- FAIL: TestKeepAlive (0.01s)

@wainersm is this issue still relevant or can be closed?
If it's still relevant to what release do you think we should map it to (mid-November, end-December, mid-February etc...)?


rkt fetch should check the remote images's hash before trying to download.

Today, when docker pulls an image, it will check the hash of the image, if that's the same as the one stored on disk, it will not try to download, which reduces the pulling latency in such cases. I think rkt should be able to provide such ux as well.
$ docker pull nginx
Using default tag: latest
latest: Pulling from library/nginx
Digest: sha256:dc53b036d0084d56d7957026c785762359620681096f405218c4cfb715012948
Status: Image is up to date for nginx:latest

cc @coreos/rkt-maintainers cc @sgotti

similar to #2937
My answer is https://github.com/coreos/rkt/issues/2937#issuecomment-233117585

Looks like an exact duplicate, thanks for the link! Maybe we should close that and just follow there?


Tree-shaking does not work for redux-logger

Describe the bug
I use the source-map-explorer to analyze the production bundle.
Event though, redux-logger shouldn't be in the bundle (because of the check against NODE_ENV), it is!
This is the code I'm using:
configureStore.js

import { applyMiddleware, compose, createStore } from 'redux';
import { createLogger } from 'redux-logger';
import apiMiddleware from '../middleware/apiMiddleware';
import rootReducer from '../reducers';

const configureStore = preloadedState => {
  const middleware = [apiMiddleware];

  if (process.env.NODE_ENV === 'development') {
    middleware.push(createLogger());
  }

  const composeEnhancers =
    window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose;

  const store = createStore(
    rootReducer,
    preloadedState,
    composeEnhancers(applyMiddleware(...middleware))
  );

  return store;
};

export default configureStore;

Did you try recovering your dependencies?
Yes
npm --version
6.10.1

Environment
System:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz
  Binaries:
    Node: 10.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.10.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 44.18362.1.0
    Internet Explorer: 11.0.18362.1
  npmPackages:
    react: ^16.8.6 => 16.8.6
    react-dom: ^16.8.6 => 16.8.6
    react-scripts: 3.0.1 => 3.0.1
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

Run the build script
Run the source-map-explorer on the production js files

Expected behavior
redux-logger shouldn't be in the production bundle.
Actual behavior
redux-logger is in the production bundle.

AFAIK tree shaking is applied prior to Terser, so it could not know whether import is used or not in advance.

I have even commented out the part where logger is used:
//  if (process.env.NODE_ENV === 'development') {
//    middleware.push(createLogger());
//  }

and left the:
import { createLogger } from 'redux-logger';

at the top as is.
Still, the production bundle contains the redux-logger.
I believe this should not happen.
I mean, that's the whole point of tree-shaking, right? To eliminate imports that are not used.

Ah, the answer is simple. In order to support tree shaking, the library must have "sideEffects": false in package.json.
No tree shaking:
https://github.com/LogRocket/redux-logger/blob/master/package.json
With tree shaking:
https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/package.json#L37

It doesn't seem that redux-logger does any side effects. It just exports several things:
https://github.com/LogRocket/redux-logger/blob/master/src/index.js#L124
It's weird!

It's absolutely normal and documented behavior: https://webpack.js.org/guides/tree-shaking/


Generate Base64 encoded QRCode image string

Hey, codebude,
Thanks for this amazing library.
I'm building a website and needed to generate QRCode for Urls dynamically, and then show them in the webpage. Since there is a way to render Base64 encoded image string in the browser like this:
<img src="data:image/jpg;base64,......" />

it'll be much better that QRCoder could directly output the encoded string rather than having users transforming its output Bitmap image to the Base64 string.

Done with this commit: https://github.com/codebude/QRCoder/commit/28325f91be17790ba09a801def254fa31a542427
Just use "Base64QRCode" instead of "QRCode" class. The GetGraphic-method of Base64QRCode returns a string, which contains the qr code in base64 format. Although there is a new optional parameter "ImageType" in all GetGraphic-methods, which enables you to choose in which file format the image should be converted before saving it as bade64 string.

Thank you for your effort! It'll be much friendly to web developer now.


Extract z value from MediaPipe Hand JavaScript API

Could anyone tell me how to extract z values from MideaPipe Hand JavaScript API?
I can get all 3D landmarks in Python API, but in JavaScript, it gives only x, y and visibility(always undefined) fields.
Thanks for JS support!
I found comment regarding the same question in this post: 1163. But there is no solution.

Also related to this issue : #1392

@mgyong and @mhays-google,
Just want to make sure, Are you going to solve this issue in the near future and release the solution soon?
Because I am developing a project that must require 3D coordinate and so I have to choose this API or not based on your next JS version.
Thanks for your support!

@mgyong and @mhays-google,
Just want to make sure, Are you going to solve this issue in the near future and release the solution soon?
Because I am developing a project that must require 3D coordinate and so I have to choose this API or not based on your next JS version.
Thanks for your support!

Hello everyone,
Any updates -- insight -- anything on this?

We have updated the documentation regarding the Z value in hands https://google.github.io/mediapipe/solutions/hands.html#multi_hand_landmarks and you can also refer this https://github.com/google/mediapipe/issues/742#issuecomment-637162399


missing owner in seed-data

http://localhost:3000/doc/soq12023167 seems to have no owner and fouls several things up in the browser. Can this be fixed for ea3? I don't know how many docs have this issue.

Deployed the SS with latest develop code + 01/05 ML server . Login as joe and click on the Votes Button .
First QnA shows author unknown . Link :100:
http://rh6-intel64-80-qa-dev-2:3000/?sort=votes
http://rh6-intel64-80-qa-dev-2:3000/doc/soq646628
Is it expected or legitimate bug ?

Confirming that 'unknown' is the right value for a missing user.

In SO, there's no data for the missing user.  In the StackOverflow UI, they make a string from the deleted user's id ('userid341352') and make it not-a-link

so it's an empty element when we inherit the data?

or is it that in the SO archive, we get that string with user id?

The former -- this is when there's no user at all in the SO data.  We can use any string at all -- I thought we had consensus on 'unknown' but it can be anything at all.

@yawitz I'm wondering if this makes sense to add to wireframes - for SO data with no user, we inherit no data. SO makes up a string based on the user's old id, but my understanding is we do not even get this string. Rather than generate a made up string, we'll just label as user: 'unknown', with reputation [0]. This reputation should still be impacted if posts are voted up/down.

I take it back, if it's all the same implementation-wise we should do reputation [unknown] and NOT calculate reputation for these users at all. I think that simplifies and follows SO model. Open to considering 0 though.

I'd leave reputation off of the unknown users altogether. I will add this detail to the wireframes.

Ok - so no brackets at all? i'm fine with that.

Yup, just the string "unknown" for the user, no reputation appended.

i believe this needs to go to browser for implementation - but feel free to correct me if middle tier also needs updating.

With the latest develop able to spot an entry with unknown user is seen . ML 01/18 and latest develop code.
Login as joe user
Sort via votes
No goto page 6
6 entry question has a user unknown
Link : http://rh6-intel64-80-qa-dev-2:3000/doc/soq1493839

I can reproduce this on the QA machine:
http://rh6-intel64-80-qa-dev-2:3000/doc/soq1493839
I can also reproduce it locally:
http://localhost:3000/doc/soq1493839
Here is what owner data I see from the call to the questions endpoint:
"owner":{
"id":"unknown",
"displayName":"unknown",
"userName":"unknown",
"reputation":0
}

The UI is doing what is spec'd above for this case, display "unknown" without a reputation. If this requires a fix, I believe it is the seed data that needs fixing (@grechaw?).

There's a new way we are to spell it. Please poke around in issues with text 'unknown'. It has something to do with stackoverlow id.

A new way?  If this should go into a search transform (there's deafult values in search transform for not-found-users) then let me know what to do.

Its assigned to Mike again. I gather you've done what we need. Id=unknow needs to trigger a different rendering of username.

Not sure if we're talking about the same thing here. Further up this thread (https://github.com/marklogic/marklogic-samplestack/issues/312#issuecomment-69088833), we agreed to render unknown user as:

...just the string "unknown" for the user, no reputation appended.

and the the wireframes were updated 2 revisions ago.

Earlier we discussed what SO does in these cases (i.e. appending an ID), but agreed to the recent rendering instead.

I didn't realize we'd gone back on that again, In that case, reassgining to @ggha to test.

browser readme needs to be updated: https://github.com/marklogic/marklogic-samplestack/tree/develop/browser
@laurelnaiad what about end to end tests - credentials up to date with joe/mary @example and not @marklogic?

(commented on wrong thread, moving to correct issue)


Custom field support with config file

Please describe your feature request:
By default, katana supports multiple pre-defined fields to customize output and can be extended to allow users to write custom fields in the config  file named field-config.yaml located at ~/.config/katana/
Example field config file:
# custom fields

- name: email
  type: regex
  regex:
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>
- name: phone
  type: regex
  regex:
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>

regex is supported to write a custom field
group field is supported with regex like nuclei
regex will be applied on crawled response (header + body)
single or multiple regex can be used with a custom field
name value will be used as field name to pass with cli option
name field needs to be unique + pre-defined names are reserved.
name field validation to accept only aA-zZ-0-9_-
default example field config file will be created upon 1st run.

./katana -u https://www.hackerone.com -f email,phone

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>+1-32424234
+1 32424234
+91324324324

./katana -u https://www.hackerone.com -f email,phone -v

[email]<EMAIL_ADDRESS>[email]<EMAIL_ADDRESS>[email]<EMAIL_ADDRESS>[email]<EMAIL_ADDRESS>[phone] +1-32424234
[phone] +1 32424234
[phone] +91324324324

@xiaoliangli1128 this is a feature issue and will be supported in the future.

Is there an option to check all the custom fields in the config file?
so instead of doing that
katana -u https://www.hackerone.com -f email,phone
we can do something like that
katana -u https://www.hackerone.com -f all


Drag and drop rows

Problem
It would be nice to be able to change the order of rows
Solution

Additional details
No response

Added in 6.3.0


Consume bicep-type generation package via gitmodule

Consume bicep-type generation package via gitmodule

Codecov Report

Merging #1150 (175ea35) into main (33588d1) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 175ea35 differs from pull request most recent head 571be56. Consider uploading reports for the commit 571be56 to get more accurate results

@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   84.74%   84.74%
=======================================
  Files           5        5
  Lines          59       59
=======================================
  Hits           50       50
  Misses          9        9

Flag
Coverage Δ

dotnet
84.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Simplify example identity-obj-proxy configuration

I saw an opportunity to simplify the example identity-obj-proxy configuration. This doesn't require the styleMock.js and fileMock.js files.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

This is good! Thank you :)

Current coverage is 87.47% (diff: 100%)

Merging #1803 into master will not change coverage

@@             master      #1803   diff @@
==========================================
  Files            38         38
  Lines          1214       1214
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1062       1062
  Misses          152        152
  Partials          0          0

Powered by Codecov. Last update 98cffb0...c21a948


working with a local schema

Notes on some things to add in future.
In the section on working with support modules we need to enable the ability to generate the schema for a generic IOC locally.
To do this we would just need to (for example pmac support):

make your changes as needed to /epics/ioc-pmac/ibek-support/pmac/pmac.ibek.support.yaml
perhaps do that automatically with something like:

../../ibek/builder2ibek.support.py /dls_sw/prod/R<IP_ADDRESS>/support/pmac/2-5-23beta1/ pmac/pmac.ibek.support.yaml  -o '14:A+B 474:A+B 801:1 805:1.0 804:1.0'

update the symlinks (only the first time)

ibek support generate-links pmac

regenerate the schema

ibek ioc generate-schema  --output /tmp/pmac.ibek.ioc.schema.json

change the top of the ioc.yaml instance you are working with to

# yaml-language-server: $schema=/tmp/pmac.ibek.ioc.schema.json

Having done the above once you can now:

edit pmac.ibek.support.yaml
run ibek ioc generate-schema  --output /tmp/pmac.ibek.ioc.schema.json
continue editing your ioc.yaml which will now see the new schema

ALSO to document, the yaml plugin does not always see changes to schema files. If this fails you can untick and retick the last option in the extension settings (enable schema validation)


Add documentation for rabbitmq msg_rate parameters

Add documentation for rabbitmq msg_rate parameters for version 2.11
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Relates to issue kedacore/keda#4507
Relates to PR kedacore/keda#4658

This will need updating, waiting for sister-pr to be accepted first.


Skill is not re-connected by parent if stopped while parent is running (due to port recycling)

Scenario:

Parent connected to skill correctly
skill is stopped and restarted, parent remains on.
Parent cannot access skill
Error:

No connection could be made because the target machine actively refused it.

Variation:

I have persistent cosmos db storage on the skill. Verified with storage explorer (tried w/ & w/o cosmost db)
Restarted both

All works

Restart only skill

Hit connection failure
Restarted the conversation in emulator
Failure persists

Restarted both – they work.

In such distributed, I think the parent should have a way to recover without requiring restart (essentially discover disconnect and try to recreate the connection).
Moved from: https://github.com/microsoft/botframework-components/issues/590
Investigation findings
The root cause is port recycling on restart by the Composer. Normally you'd expect the ports to be pinned retaining affinity; however here they always get assigned a new port number, thus the parent loses connection to the restarted bot.

@garypretty, assigning this one to you for review, let me know if you need more information

@srinaath Good to get your thoughts on this one - seems to be related to the other issue we were looking at with web chat?

@garypretty
The issue @gabog mentioned does seem like a problem for a lot of code first folks moving to Composer.
I think we can take the cue from VSCode launch.json and pick random port if static port is not set for a bot. If a static port is present and its not a reserved port used for Composer internal functionalities makes sense to provide some UI to allow passing port value and maybe even persist it in the bot project file. Hence, root bot and skills are opened up on the ports specified in the file.

Slightly related to #7765


Refs #23 - Initialized preview form with files.

Even if file uploads are not supported in preview, we properly initialize
forms with both data and files. In certain use cases, custom process_preview()
implementations may access uploaded file data.

In fact, there is an issue with form_hmac calculation when we initialize a form with files. I should add a test and a fix.

At last I was able to finish the patch. Hasan, would you mind reviewing it again?


asc_space.cpp file is added..

the file is present in C++ asc_space.cpp

code seems to be working


Full IME support for Windows

We need full unicode support using system IMEs for example CJK input.

Update 2020-10-20: Working locally with on-the-spot composing and tested w/ Japanese input. Still needs documentation and cleanup. Will likely get this landed in the next two weeks.

This should Just Work with Windows 10's emoji keyboard as well, right?

Landed https://github.com/flutter/flutter/issues/65574, with the IMM32 implementation. Verified Japanese input works.

Landed https://github.com/flutter/flutter/issues/65574, with the IMM32 implementation. Verified Japanese input works.

Warning -- while I do speak Japanese, I don't speak either Mandarin or Korean. I think I got 'nihao' right but not sure if I got 'bird' in Korean :)
MS Japanese IME:

MS Simplified Chinese:

Microsoft Korean IME:

Warning -- while I do speak Japanese, I don't speak either Mandarin or Korean. I think I got 'nihao' right but not sure if I got 'bird' in Korean :)
MS Japanese IME:

MS Simplified Chinese:

Microsoft Korean IME:

This should Just Work with Windows 10's emoji keyboard as well, right?

@Jjagg -- this emoji keyboard? 😃

This should Just Work with Windows 10's emoji keyboard as well, right?

@Jjagg -- this emoji keyboard? 😃

Yes! That's great, thanks for testing! :)

Yes! That's great, thanks for testing! :)


Hooks stop working when importing npm modules

import { useState } from "preact/hooks";
import builder from "npm:utm-builder";

export default function test() {
  const [value, setFn] = useState(null);
  const a = builder("https://example.com", "sdf", "sdf", "sdf");

  return (
    <>
      <input
        type="text"
        onInput={(e) => {
          setFn(e.target.value)}}
      /><br />
      {a}{value}
    </>
  );
}

The npm module works fine in Deno, but in Fresh it makes the hooks stop working.

deno 1.42.0 (release, x86_64-pc-windows-msvc)
v8 <IP_ADDRESS>
Not sure how to get Fresh version but I just update it

Running the snippet you provided and opening the browser's DevTools console, we see the following error:

Looking at the source of the utm-builder npm module on GitHub reveals that they rely on the built in url module from node .
// See  https://github.com/mahnunchik/utm-builder/blob/9feff4f343176d54bee9666f46c2ecd753cc1c4a/index.js#L3

// This "url" a module provided by Nodejs. In more modern code bases
// you'll find it under the "node:url" alias instead.
var url = require('url');

// ...
module.exports = function(link, source, medium, campaign, content, term) {
  // ...
}

Built-in modules from node are not available in the browser and cannot be easily shimmed. So this module won't work in the browser.
The module's description "utm-builder adds custom campaign parameters to your URLs." made me curious. Looking at the GitHub history it was last updated 10 years ago (excluding README updates). That puts it right after the very first public 0.10.x Nodejs release was made available to the world. A lot has happened in the last 10 years and URL handling has gotten much simpler. Every JavaScript runtime ships with the native URL class out of the box for example.
Using the URL constructor we can write a much simpler version of what the utm-builder module provides and make it even typesafe in the process, so that you get some nice autocompletion in your editor!
// Does the exact same as the `utm-builder` npm module. On top of that,
// this implementation allows passing URL instances directly and is type safe.
function utmBuilder(
  link: string | URL,
  source: string,
  medium: string,
  campaign: string,
  content?: string,
  term?: string
) {
  const url = new URL(link);
  url.searchParams.set("utm_source", source);
  url.searchParams.set("utm_medium", medium);
  url.searchParams.set("utm_campaign", campaign);

  if (content !== undefined) {
    url.searchParams.set("utm_content", content);
  }

  if (term !== undefined) {
    url.searchParams.set("utm_term", term);
  }

  return url;
}

tl;dr: Running built-in modules from Node in the browser is not supported. In this case the npm dependency that relies on node:url is more 10 years old and can be replaced with a simple function these days, thanks to the URL class.

That's wild. Thank you so much for a detail analysis on the problem. I take that when Node was just released there was no way to convert Node modules to run in the browsers. Is that correct? I'm also surprised that JS didn't have the URL class as well, since it seems to be a basic feature.
I also wonder why it stops the hooks? I know that the browsers don't support that, but it's irrelevant to them. And is there a way to convert Node/Deno modules to have it run on browsers?

So does Deno encourage the use of bundler? When you say "it's better to fail early than to allow developers to unknowingly ship lots of unnecessary JavaScript to their users", I take that it doesn't. However I'm not sure how frameworks be much different on playing the role of bundler?

You don't need a bundler for Deno, you need one for the browser. TypeScript doesn't work in the browser, JSX doesn't work in the browser, npm: and jsr: module prefixes don't work in the browser, etc. All these kind of things we paper over in Fresh by using a bundler. Deno doesn't need that because it supports these things natively. In that sense Deno doesn't encourage the use of bundlers for running code in Deno. It's encouraged to use with browsers though.

When you say "it's better to fail early than to allow developers to unknowingly ship lots of unnecessary JavaScript to their users", I take that it doesn't.

Well, it did fail for you, otherwise you wouldn't have opened this issue :-) We should print a better error message though.

However I'm not sure how frameworks be much different on playing the role of bundler?

Yeah, pretty much every framework that aims to make building websites or web apps easier uses a bundler under the hood. These days more and more framework features are implemented through the bundler, so the lines between framework and bundler are pretty blurry these days.


Row detail open by default

Hi,
Is there an easy way to have have the row details display by default in the example
https://datatables.yajrabox.com/eloquent/row-details
Thanks in advance.

tr.addClass('shown');


Error when adding as dependency - Missing boring-imp

error: no matching package named boring-imp found
location searched: registry crates-io
required by package chromimic v0.12.1

error: no matching package named boring-imp found location searched: registry crates-io required by package chromimic v0.12.1

I had the same issue. It appears that the user @0x676e67 (now deleted) has deleted their GitHub account and yanked the crates required for this project. Fortunately, Cargo does not allow deletion of crates, and you may download them manually. Here's a list of the requisite crates and their links via crates.io (imp stands for impersonate):
hyper_imp v0.14.42
boring-sys-imp v4.9.3
boring-imp v4.9.3
h2_imp v0.5.0
tokio-boring-imp v4.9.3
hyper-boring-imp v4.9.3
To make these work, download each of the crate files and unzip them in some local folder. Then you can refer to them directly by replacing package = "hyper_imp" with path = "./imp/hyper_imp-0.14.42", as an example. Also, you need to remove imp from the library names:
[lib]
name = "boring-imp"
path = "src/lib.rs"

to
[lib]
name = "boring"
path = "src/lib.rs"

and also in the package name of each of the subpackages, as they are not referred to as -imp packages in the individual package config files. You also need to update the version specs of each of the v2.0.0 packages as they won't work on the specified versions, only on the recent v4.9.3 crates. With these changes I was able to get it running smoothly.


async DefaultAzureCredential incompatible with AsyncTokenCredential per pyright

Pyright reports a type error when the async DefaultAzureCredential is used anywhere where an AsyncTokenCredential is expected:
  C:\Users\krpratic\azure-sdk-for-python\sdk\cognitivelanguage\azure-ai-language-conversations\samples\async\sample_authentication_async.py:57:66 - error: Argument of type "DefaultAzureCredential" cannot be assigned to parameter "credential" of type "AzureKeyCredential | AsyncTokenCredential" in function "__init__"
    Type "DefaultAzureCredential" cannot be assigned to type "AzureKeyCredential | AsyncTokenCredential"
      "DefaultAzureCredential" is incompatible with "AzureKeyCredential"
      "DefaultAzureCredential" is incompatible with protocol "AsyncTokenCredential"
        "__aenter__" is an incompatible type
          Type "() -> Coroutine[Any, Any, DefaultAzureCredential]" cannot be assigned to type "() -> Coroutine[Any, Any, None]"
            Function return type "Coroutine[Any, Any, DefaultAzureCredential]" is incompatible with type "Coroutine[Any, Any, None]"
        "__aexit__" is an incompatible type
          Type "(*args: Unknown) -> Coroutine[Any, Any, None]" cannot be assigned to type "(exc_type: Unknown, exc_value: Unknown, traceback: Unknown) -> Coroutine[Any, Any, None]"

This is due to the difference in how the Protocol is typed vs. how it is typed in identity:
https://github.com/Azure/azure-sdk-for-python/blob/ac0672ffa01c038b10632a559f742660bf19b016/sdk/core/azure-core/azure/core/credentials_async.py#L28-L35
https://github.com/Azure/azure-sdk-for-python/blob/ac0672ffa01c038b10632a559f742660bf19b016/sdk/identity/azure-identity/azure/identity/aio/_internal/__init__.py#L11-L20
Note that this doesn't occur with the sync credential since __enter__ and __exit__ are not described by TokenCredential.

I think it would be less disruptive to update AsyncTokenCredential (although I'm not sure if this would be considered breaking):
 async def close(self) -> None:
     pass

 async def __aenter__(self) -> typing.Self:
     pass

 async def __aexit__(self, *args: Any) -> None:
     pass

@mccoyp is this something you are working on? (I want to avoid dup the work)

Looks like pyright is more strict than mypy, and in a similar boat as PyCharm's type checker. https://github.com/Azure/azure-sdk-for-python/pull/25788 should resolve this.
When I last spoke with Laurent, he feels that we should update our type signatures to correctly implement the TokenCredential protocols (even when some of the kwargs can't be used, like tenant_id with ManagedIdentityCredential). We would just need to clearly document when these kwargs aren't being used.

I think it would be less disruptive to update AsyncTokenCredential (although I'm not sure if this would be considered breaking):
 async def close(self) -> None:
     pass

 async def __aenter__(self) -> typing.Self:
     pass

 async def __aexit__(self, *args: Any) -> None:
     pass

After taking a look at reference docs, I do think updating the protocol definition would be a better option since examples use *exc instead of exception type, value, and traceback positional parameters:
async def __aexit__(self, *exc):
    print('Finishing')
    return False

That said, I do think it would be a breaking change to put these named parameters into *args. You would no longer be able to pass named arguments in method calls without getting an "unexpected keyword argument" error. The question is whether this is a real scenario that we need to worry about; someone would have had to exactly implement the protocol and call the dunder method directly in order to see this.

Resolved by https://github.com/Azure/azure-sdk-for-python/pull/31494.

With the changes in #31585, seems like the fix for this is to update the __aexit__ implementations in azure-identity  with the updated signature?
Like here.
    async def __aexit__(
        self,
        exc_type: Optional[Type[BaseException]] = None,
        exc_value: Optional[BaseException] = None,
        traceback: Optional[TracebackType] = None,
    ) -> None:
        pass

Seems like https://github.com/Azure/azure-sdk-for-python/pull/31578/files can fix it. :)


[Feature Request]: Add RoutingIntent child module to Virtual Hub module.

Description
Hi,
Could we have a routing Intent functionality for virtual Hub which would allow sending traffic to Azure Firewall:
https://learn.microsoft.com/en-us/azure/templates/microsoft.network/virtualhubs/routingintent?pivots=deployment-language-bicep
resource symbolicname 'Microsoft.Network/virtualHubs/routingIntent@2023-02-01' = {
  name: 'string'
  parent: resourceSymbolicName
  properties: {
    routingPolicies: [
      {
        destinations: [
          'string'
        ]
        name: 'string'
        nextHop: 'string'
      }
    ]
  }
}

Hey @arnoldna ,
I just migrated this issue over from CARML. Please take a look and triage if still relevant :)

Working on this now

Running in to an issue with integrating this functionality; the problem is that this feature requires a firewall (Azure Firewall, for example), to be created and associated with the virtual hub before it is invoked, otherwise it will error out with an "invalid next hop" condition. In order for the firewall to be properly associated to the hub, it has to be created after the virtual hub, since the hub.id needs to be specified during the firewall creation (confirmed with the VWAN PG that providing the firewall.id during hub creation does nothing; it is a read-only parameter). The deployment flow needs to be:

Create the hub
Create the firewall (passing in hub resource id)
Invoke routing intent config

The requirement for a firewall effectively introduces a race condition; @ChrisSidebotham is going to discuss amongst the core team how to approach this issue. There are a couple different courses of action under consideration:

Leaving routing intent out of the virtual hub module and calling it from a VWAN pattern instead
Deploying the Azure Firewall as part of the virtual hub module
Something else?

Work is on-hold pending further direction.

Hey @ericscheffler,
thank you for the elaborate description. Maybe I'm simplifying this too much, but wouldn't it work to

Implement the child module as a normal child module
Implement a test that creates a plain VirtualHub & Firewall in its dependencies - and then invoke the module in an idempotent way with the routing intent defined as a parameter

I did something similar for some CMK tests where I wanted to show how to do this with a System-Assigned identity. Similar issue: How to assign permissions to a MSI if the MSI is only created after the service is deployed for which I want to define CMK. Same solution: Deployed the vanilla service with a system-assigned identity in the test's dependencies, set the permissions, then invoked the module like nothing happened in an idempotent way. For reference: https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/cognitive-services/account/tests/e2e/system-assigned-cmk-encryption/main.test.bicep


exclude_labels_with_map_values_out_of_range parameter does not fit the prototype version

... need also to look at similar function

should be fixed now


Better UI for Hero Section

The nav bar width and alignment can be improved and the way the Fix your Nums is showing on the hero page can be made better too.

hey @Srijita-Mandal i would like to make these changes

@Saishreekouda go for it.

@Saishreekouda make PR before tonight. Else I'll assign next one.

@Srijita-Mandal yes working on it


Word-count: tests reject mutable hashes

Hello all!
I came here from exercism to talk about the source of some confusion about the word-count problem in racket. It seems the tests fail if the returned hash is mutable. Neither in the README nor the test file is it mentioned, that the returned hashes should be immutable. The test's failure messages, e.g.:
--------------------
Tests for the word-count exercise > #f
Unnamed test
FAILURE
name:       check-equal?
location:   word-count-test.rkt:37:5
actual:     '#hash(("for" . 1) ("wait" . 1) ("it" . 1))
expected:   '#hash(("it" . 1) ("wait" . 1) ("for" . 1))
message:    "multiple spaces"
Check failure
--------------------

are also not very helpful in finding the cause of the failure.
Is the behavior of the tests intentional?
If not, please fix the tests.
If yes, maybe you could make it more obvious what the tests are expecting?

Hi - thanks for catching that! I defined a custom hash check, which should fix that.


Move upcase to css

I have moved some cases from ruby to CSS.

Excellent @hin101; looks good to me!

Yes, this looks great!


laggy and slow response when scrolling,typing,etc...

Type: Performance Issue
my vscode suddenly get laggy and choppy and slower response after I crashed it by printing a lot of "1"s in an endless loop.
VS Code version: Code - Insiders 1.88.0-insider (bb171489789c9a49e985a4a2c8694138d70d42c1, 2024-03-01T18:18:03.639Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i5-12500H (16 x 3110)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.71GB (0.81GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	   139	 10864	code-insiders main
    0	   521	  2304	   window
    0	    31	  8280	   utility-process
    0	    53	 10116	fileWatcher [1]
    0	    82	 11000	extensionHost [1]
    0	    72	 12588	shared-process
    0	    42	 17564	   utility-network-service
    0	   162	 19300	   gpu-process
    0	   106	 19332	window [2] (Issue Reporter)
    0	   281	 19908	window [1] (● acf.cpp - THN_TK4 - Visual Studio Code - Insiders)

Workspace Info
|  Window (● acf.cpp - THN_TK4 - Visual Studio Code - Insiders)
|    Folder (THN_TK4): 261 files
|      File types: cpp(91) exe(72) o(56) OUT(22) out(6) INP(4) json(2) c(1)
|                  save-failed(1)
|      Conf files: settings.json(1) tasks.json(1);

Extensions: none
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593:30376534
py29gd2263:30784851
vscaat:30438846
c4g48928:30535728
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
welcomedialogc:30812479
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
h48ei257:30968133
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
d6fi2104:30968146
pydisww2:30959801
cppperfnew:30963552
d34g3935:30961436
edj9j583:30969294
fegfb526:30952798
bg6jg535:30946824
78248357:30976997
ccp2r6:30958154
pythonait:30973460

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Adds Arquillian Cube Q Alpha2 Announcement

Sigh! I totally forgot about it. Will take care of it tomorrow


DRAFT: Clarifying & Controlling Unwinds

To get a comment thread available for initial text review quickly
Counter-proposal to https://github.com/rust-lang/rfcs/pull/3288 (if you see the crosslink congrats you get to see this early)
Note that a number of editor comments are left in html comments
[rich diff] [rendered]

Some early notes based on a quick read:
#[nounwind] is generally useful and I would love to have it in the language. In fact, we already have this in the form of #[rustc_allocator_nounwind] which has exactly the semantics you want (minus using it on a Drop impl). It's just a matter of renaming the attribute and giving it a feature name & tracking issue.
I'm having trouble seeing the rationale for #[catch_unwind(return)] when you can just write the catch_unwind in the function body. There's no need for it to be a language-level attribute.

When Rust's personality routine is called, it does one of two things:

How would this work with other unwinding schemes that don't use a personality function? For example, SEH unwinding on MSVC, Emscripten unwinding, future native WASM exceptions, etc.

I agree on #[catch_unwind]; the next revision was already going to demote it to the "maybe useful" part of the future possibilities.
I haven't looked specifically into SEH or other native unwinding mechanisms yet. The practice of maintaining a sidechannel like panic_count or similar is necessary to get ill-nested panics to immediately abort if the native exception runtime does not offer a way to detect this case.
For mixing foreign unwinds, noting this down now that I did a quick experiment for data:

unwind
current
best theoretical

cxx during rust
works
Itanium UB[^0]

rust during cxx
no panic hook, otherwise fine
abort

cxx catch rust
abort
mostly works (out of our control)

rust catch cxx
abort
“works”[^1]

cxx rethrow rust
works
works[^2] (out of our control)

[^0]: Various sources, but most clearly §1.6.4 states w.r.t. C++ that behavior is undefined if a __foreign_exception is active at the same time as another exception. My standards brain is not strong enough to say for certain whether this (and the other statements) only mean that nesting foreign exceptions inside of a catch _UA_HANDLER_FRAME is UB and unwinding inside of cleanup frames is acceptable, or if nesting a foreign unwind during cleanup landing pads is also UB.
[^1]: Under Itanium, the unwind handler must either _Unwind_Resume or _Unwind_Delete a foreign exception (or maybe[^2] _Unwind_RaiseException) within the handler. Which it does must be declared in the search phase by returning _UA_CONTINUE_UNWIND or _UA_HANDLER_FOUND, respectively. Rust catch_unwind contains a handler, and thus must internally destroy the foreign exception. This is true even if we understand the exception object format (see §1.6.4).
[^2]: My reading of the Itanium ABI states that rethrowing a foreign exception results in undefined behavior (see §1.2, exception handler, _URC_FOREIGN_EXCEPTION_CAUGHT)... but then it goes on to state that rethrowing is implemented by calling _Unwind_RaiseException again with the same exception object (§1.3, _Unwind_Resume) and that a C++ catch(...) may rethrow a foreign exception (§1.6.4).

and that a C++ catch(...) may rethrow a foreign exception (§1.6.4)

This, at least, is resolved by §2.5.2:

If the exception is not a C++ exception, the C++ personality routine must not catch it, that is it should return _URC_CONTINUE_UNWIND in both phases, after performing any required cleanup actions in the second phase.

C++ catching a foreign exception will call _Unwind_Resume on the foreign unwind. UB results if a catch (...) or catch (__foreign_exception const&) does not use throw; to rethrow when a foreign exception is caught.

rethrowing is implemented by calling _Unwind_RaiseException again with the same exception object (§1.3, _Unwind_Resume)

This only states how rethrowing from a handler is done. Combined with §2.5.4, we can presume that __cxa_rethrow() and __cxa_end_catch() collaborate to reraise and suspend the exception such that it can be passed to _Unwind_Resume (iff the exception is not foreign).

One last note for myself: per my reading just now, I think §2.5.5 Finishing and Destroying the Exception

An exception is considered handled:

Immediately after initializing the parameter of the corresponding catch clause (or upon entry to a catch(...) clause).

means that for a native C++ exception, the exception is no longer active at the base ABI level during execution of the catch clause.
This would mean that a Rust exception during a C++ catch of a C++ exception is always defined behavior.

I haven't looked specifically into SEH or other native unwinding mechanisms yet.

SEH is implemented on top of MSVC C++ exceptions. A Rust panic is just a C++ exception of type rust_panic. A similar thing is done for emscripten exceptions.

For mixing foreign unwinds, noting this down now that I did a quick experiment for data:

We could make most of these work by changing __rust_drop_panic and __rust_foreign_exception to not abort. The decision to make these abort was a choice, which can be reversed to make them work as expected. This would allow C++ to catch Rust panics and discard them (instead of rethrowing them) and for Rust to catch foreign exceptions (as a Box<ForeignException> where ForeignException is a ZST: we can't support capturing & rethrowing C++ exceptions due to the way catch_unwind is designed).
Once those are fixed, there is only one place where an abort can occur: the C++ runtime keeps a linked list of exceptions, but _Unwind_Exception doesn't have a link pointer, only __cxa_exception does (it contains a _Unwind_Exception). If a catch (...) catches a foreign exception (Rust panic) while a C++ exception is already active (it has been thrown but not caught yet) then the runtime can't add the foreign exception to the linked list because it has no nextException pointer. At this point it just aborts by calling std::terminate.

After doing the research and writing that went into this draft, I am much less confident that we should retain support for unwinds from drops. As such, I'm completely restructuring this into https://github.com/CAD97/rust-rfcs/pull/3 which puts drop-panics-unwind and drop-panics-abort on equal footing.
I respect the choice of RFC 3288 to defer any changes to nested unwinds or foreign unwinds, but believe that the picture cannot be fully contextualized without their context. This is why I continue to author a counter-RFC to present a fuller illustration of the problem space.


[WFLY-3532] Re-instate RemoteFailoverTestCase

See the issue WFLY-3532 for details.

Windows Build 27 is now running using a merge of 818a803359764c53ebcd68b72d405ba6b9660e59

Linux Build 28 is now running using a merge of 818a803359764c53ebcd68b72d405ba6b9660e59

Linux with security manager Build 26 is now running using a merge of 818a803359764c53ebcd68b72d405ba6b9660e59

Linux with security manager Build 26 outcome was SUCCESS using a merge of 818a803359764c53ebcd68b72d405ba6b9660e59
Summary: Tests passed: 825, ignored: 317 Build time: 0:05:34

Windows Build 27 outcome was SUCCESS using a merge of 818a803359764c53ebcd68b72d405ba6b9660e59
Summary: Tests passed: 2864, ignored: 371, muted: 4 Build time: 0:47:49

Linux Build 28 outcome was SUCCESS using a merge of 818a803359764c53ebcd68b72d405ba6b9660e59
Summary: Tests passed: 2867, ignored: 371, muted: 1 Build time: 0:49:01


Double billed

Issue in ./help/support-tools/patches-available-in-qpt-tool/v1-0-7/mdva-31282-magento-patch-double-authorization-on-paypal-payflow-pro.md
I have been double billed in the amount of 13.64 (x7) the last 7 months.  Please point me in the direction to have this rectified as I can find no portals for an actual Adobe customer service.

@CLGrant11 Hello,
Please refer to steps on how to submit a ticket here for Adobe Commerce https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/help-center-guide/magento-help-center-user-guide.html?lang=en#submit-ticket


[BUG] Air-gapped environment won't load the dashboard

Describe the bug

When you install Harvester to an air-gapped environment it finishes the install but won't load the dashboard or the auth/setup pages
To Reproduce
Steps to reproduce the behavior:

Install to an air-gapped environmnet
Finish Install
Reboot
Wait for harvester to show as ready
Navigate to URL
Expected behavior

Dashboard should load
Support bundle

Environment:

Harvester ISO version: harvester-preview1
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): virtualized environment with KVM

Additional context
Add any other context about the problem here.

Will need to add support to serve UI from embedded cluster instead of remote server URL.

I thought that was a supported option, it just defaulted to the remote server URL.

To test:
For tag release, check that UI is loaded as expected in air-gapped env.
For master build, it still defaults to fetch the latest remote UI.
Run
kubectl patch setting ui-source --type=merge -p 'value: bundled'

Then verify it works in air-gapped env.

verified using the master-c6474a74-head

go to the Advanced => Settings and config ui-source to Bundled
Refresh the page again, make sure the UI is loaded successfully and the JS/CSS assets are loaded from the local server.


WIP: region serialization

Tries to implement stable serialization of stateful Region objects consisting of three words

id: unboxed word 16 (padded to word32) (immutable)
page_count: unboxed word 32 (mutable)
vanilla Blob (mutable) (holding an array of allocated block ids)

These region objects are stateful descriptors of stable memory isolated regions.
Unfortunately, the simplest example fails to upgrade properly.
[nix-shell:~/motoko/test/run-drun]$ more stable-regions-one.mo
import P "mo:⛔";
import Region "stable-region/Region";
import Region0 "stable-mem/StableMemory";

actor {
  stable var r0 = Region0.region();
  stable var r1 = Region.new();

  system func preupgrade() {
    P.debugPrint("pre");
  };

  system func postupgrade() {
    P.debugPrint("post");
  };

  public func sanityTest() {
  };
}

//SKIP run
//SKIP run-low
//SKIP run-ir
// too slow on ic-ref-run:
//SKIP comp-ref
//CALL ingress sanityTest "DIDL\x00\x00"
//CALL upgrade ""
//CALL ingress sanityTest "DIDL\x00\x00"

Produces:
[nix-shell:~/motoko/test/run-drun]$ ../run.sh -d stable-regions-one.mo
WARNING: Could not run ic-ref-run, will skip running some tests
stable-regions-one: [tc] [comp] [valid] [drun-run]
--- stable-regions-one.drun-run (expected)
+++ stable-regions-one.drun-run (actual)
@@ -0,0 +1,6 @@
+ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
+ingress Completed: Reply: 0x4449444c0000
+ingress Completed: Reply: 0x4449444c0000
+debug.print: pre
+ingress Err: IC0503: Canister rwlgt-iiaaa-aaaaa-aaaaa-cai trapped explicitly: read_alias unexpected idl_typ
+ingress Completed: Reply: 0x4449444c0000
Some tests failed:
stable-regions-one.mo

@nomeata any clue what I'm doing wrong here?

@matthewhammer, ok, I think this is working enough to merge in.

@crusso I still get errors when I run the unit tests, like this
ingress Err: IC0503: Canister rwlgt-iiaaa-aaaaa-aaaaa-cai trapped explicitly: read_alias unexpected idl_typ

@matthewhammer https://github.com/dfinity/motoko/pull/3906/commits/0bbea9b00cc5371bcabbab830140345f55a128fd is a test that shows what goes wrong if we expose region0 and don't take extra steps to ensure all region0 objects are identified.
One fix is to not exposing region0 at all, the second might be to ensure correct aliasing for region0 on deserialization. It think the former might be cleanest.


check supplied path

if the supplied path exists, :tada:
if it doesnt exist, :untada: we need to decide what happens and update the script.

done!


Missing exports in index.js

There is no exported member of the module progressBar and codeView(blockCodeView and inlineCodeView).

I could only import it directly from the component folder.

Version:
"@kyndryl-design-system/shidoka-applications": "^1.39.1"

@vrblymt You should always import component files directly, because it doesn't tree shake properly due to side effects.
@wbarbee I think we need to make a couple of changes here:

The Code View folder structure kinda breaks our standard import structure, and makes the import path on the Docs pages incorrect. We should probably bring the blockCodeView and inlineCodeView folders up a level, so the import paths are consistent with our other components.
Add the Progress Bar and Code View component exports to src/index.ts. In 2.0 I may consider removing this file, since it's recommend to import files directly anyway.

Resolved by #248

Released as v1.39.2


[DO NOT MERGE] Revert "Pause Content-data-api Database Sync"

Reverts alphagov/govuk-puppet#11415 after govuk_env_sync supports restoring Postgres 13.3
Ref:

trello card

Looks like these changes were applied in https://github.com/alphagov/govuk-puppet/commit/2efdde756ac472a745df2b6938c88302a8458185 so this can be closed.

Looks like these changes were applied in 2efdde7 so this can be closed.

Thank you!


Failing unit test for bug #2143

This PR contains a failing unit test demonstrating that calling AppendExclusive with no events and then calling Append fails with Marten.Exceptions.EventStreamUnexpectedMaxEventIdException

Got it, and thank you!


auro-icon: Additional icons for inflight amenities

Is your feature request related to a problem? Please describe.
We'd like the seat map to better market inflight experience upgrades to guests in a way that is easily scannable when scrolling through the full plane layout. Many amenities are already well represented by Auro inflight icons but could be improved by adding new icons to capture key differences in the experiences.
Describe the solution you'd like

Complementary cocktails icon: (Premium Class) Currently food and drink are only represented by the "meal service" icon (fork & spoon) which is only applicable to First Class. Using the same icon to represent complementary cocktails for Premium Class does not do enough to differentiate the two while scanning the seat map.
More legroom icon: (Premium Class) Currently there is only one "seat" icon which is used in many contexts such as referencing comfort and seat selection for fare comparison and safety for seat blocking. For communicating the additional legroom available with Premium Class seats at a glance, an icon designed for this purpose would be helpful.
Most legroom icon: (First Class) As mentioned in #2 above, the only seat icon currently available is not specific to the use case of communicating the comfort and legroom available in First Class. Ideally, this icon and the More legroom icon would be slightly similar so as to communicate increasing levels of the same benefit.

Describe alternatives you've considered
Due to the nature of these inflight features the iconography would need to be fairly specific to the use cases provided above. Keeping the icons tied to the Auro family in style would also make them easy to use in other marketing contexts beyond the seat map.
Additional context
These are placeholder icons used in mockups to communicate with the engineering team.

@clockeby for this to happen there are two steps.

Add the new icons to Abstract and submit for review with @sryckman
Once merged, please attach the exported SVG to this ticket for inclusion with the Icons library.

I am moving this ticket to Auro Icons. The auro-icon web component is an easy-to-use tool for accessing the Icon library.


WASI errno support

This adds support for errno on the wasm32-wasi target, which is
currently only supported on Rust nightly.
WASI is a new system-call-like API being designed for WebAssembly; see
the WASI project page for details.

Yes, it's possible -- with a wasm runtime such as Wasmtime installed, one can run "cargo +nightly test --all --target=wasm32-wasi" and the tests pass. Are you ok adding Wasmtime and Rust nightly to the travis script?

Sure, that would be great!

I think the error is due to GCC 4.8 missing stdatomic.h. It might be worth updating to Xenial to solve this problem.

Everything is straightened out now, and the CI is green.


Smooth onboarding for Terraform

[Was getting set up this afternoon and ran into a couple bumps in the road. Hopefully this PR will help smooth those out for future contributors.]
Updates the Terraform usage and documentation to simplify onboarding.

Provide a script to create a private, encrypted S3 bucket for storing
Terraform state
Use a config file to specify backend configuration so that devs can
specify their bucket name once in a gitignored config file.
Update README to describe how to use the script and the backend
config. Separate out infrastructure setup documentation from the main
build-and-deploy loop documentation.

@bhushanRamnani Thanks for the feedback! Updated with documentation for using local tfstate.


#10/better-path-error-messages

Made path errors more readable by highlighting them in red and clearing the console to bring them into better focus to the user.
Path errors now display the given path so the user can see at a glance if they made a mistake without having to dig in the ini file.
When there is an error with a given path the user will now have to press a key to continue allowing them to read the error without the console closing on them. (partially implements #8)
Made some slight formatting
closes #10

Note: Only path errors have received this treatment so far.

Gotta love it when you set your username and email in git but you only did it locally when you thought you did it globally.


Add FloatQuant mode

Rough draft, do not merge.
PR description TBD.
Implements https://github.com/mwlon/pcodec/issues/191.

@mwlon, sharing this draft because I bet you'll have feedback even at this incomplete stage.
Would appreciate both high-level feedback as to "is this basically on the right track," as well as Rust tips.  Rust has been pretty interesting and not too hard to guess, but I haven't tried to compile it yet (lol) and there are probably some places that could be better expressed using language features I don't know about.

Next step is to fix build errors until it compiles.

Is there a reason you're not compiling it? I'd think it would help to have a faster feedback loop.
I think there are at least 3 more things to change (and just so you don't worry, I wouldn't expect anyone to anticipate these):

in pco/src/chunk_metadata.rs we encode/decode the mode and its associated data.
in pco/src/constants.rs we'll want to bump the CURRENT_FORMAT_VERSION since we'll be extending the format. This indicates that old decoders won't be able to read files written with new encoder versions.
in docs/format.md we'll want to add a bit of information about this mode and the new format version

Thanks for the comments!  I'll take a look soon / probably tomorrow.

I've taken a look at the whole thing now. Excited! I suggest you use some cargo commands (and maybe get an IDE? I'm using RustRover and people like VSCode) so that you're not doing this on hard mode

I've been using cargo build and cargo run, and I ran cargo test when I first cloned the repo to make sure main could run on my machine.  Based on this cheat sheet, I don't see any other obvious commands to use right now?  Definitely interested in tips tho, please hmu if applicable.
For editor, my first attempt will probably be to look for lightish-weight vim integrations with cargo, similar to what vim-fugitive does with git.  For example, it would be nice to have a vim command that runs cargo build and populates the quickfix window with a list of build errors that open the relevant file + line when an error is selected.

Btw, I avoid VSCode specifically because I am sympathetic to the objections raised in "Visual Studio Code is designed to fracture."

Haven't had time to work on this in the past few days, but I've got some time this evening.
Here's my estimate of what's left:

Add unit tests
Check with @mwlon whether I should run a non-unit-test benchmark and add a chat of the results to the PR description and/or markdown docs
Ask @mwlon whether anything else is needed before merge

For unit tests, the obvious ones that come to mind are:

split_latents → join_latents round trip
FloatQuant performs better than Classic on a dataset of quantized floats

A third unit test could be sanity-check of the "decide whether to use FloatQuant" logic,
float_quant_utils::choose_config<F: FloatLike>(nums: &[F]) -> Option<FloatQuantConfig>

which is sort of crude and currently unused, since in this initial implementation we don't allow Enabled, only Provided(k) (see https://github.com/mwlon/pcodec/pull/193#discussion_r1609850809 and https://github.com/mwlon/pcodec/issues/194).  So it might make the most sense to just remove that code rather than unit test it for now.

@mwlon, the Rust-noob errors I'm hitting are making this inefficient - I think it would be much faster (and more fun) if we pair-program on this in real time.  I'll reach out off-band to see if we can set something up.

  AFK, apologies if typos. You might need to add a few lines into pco_cli/src/bench/codecs/pco.rs to parse float_quant
(Note to self: compress and bench subcommands should probably receive configurations in the same way in the future)

Sweet!  AFK, apologies if typos. You might need to add a few lines into pco_cli/src/bench/codecs/pco.rs to parse float_quant
(Note to self: compress and bench subcommands should probably receive configurations in the same way in the future)

$ cargo run --release -- \
    bench \
    --datasets quantized_normal \
    --codecs pco,pco:float_mult=disabled:float_quant=32

╭──────────────────────┬──────────────────────────────────────────────────┬─────────────┬───────────────┬─────────────────╮
│ dataset              │ codec                                            │ compress_dt │ decompress_dt │ compressed_size │
├──────────────────────┼──────────────────────────────────────────────────┼─────────────┼───────────────┼─────────────────┤
│ f64_quantized_normal │ pco                                              │ 51.456746ms │    8.721847ms │         3708019 │
│ f64_quantized_normal │ pco:float_mult=Disabled:float_quant=Provided(32) │ 40.630794ms │    4.655311ms │         3446617 │
│ <sum>                │ pco                                              │ 51.456746ms │    8.721847ms │         3708019 │
│ <sum>                │ pco:float_mult=Disabled:float_quant=Provided(32) │ 40.630794ms │    4.655311ms │         3446617 │
│ <sum>                │ <sum>                                            │  92.08754ms │   13.377158ms │         7154636 │
╰──────────────────────┴──────────────────────────────────────────────────┴─────────────┴───────────────┴─────────────────╯

Just in case bench doesn't make sure the decompressed output is the same as the origin input, I confirmed:
$ cargo run compress \
    --input-format csv \
    --float-mult disabled \
    --float-quant 32 \
    --input data/txt/f64_quantized_normal.txt \
    qn_float_quant.pco

$ cargo run decompress \
    --output binary \
    qn_float_quant.pco \
    > qn_float_quant_decompressed.bin

$ diff qn_float_quant_decompressed.bin \
    data/binary/f64_quantized_normal.bin
# nothing

Man, it is not easy to see which threads were updated!  I wonder why the review UI is this hard to use.  (it's probably hard to do well)

Added a unit test confirming that secondary == 0 in FloatQuant when the input float (whether positive or negative) is exactly quantized.

I think this is basically good to go! Can you fix the failing unit test? And maybe add in -1.0 - f32::EPSILON and 1.0 + f32::EPSILON to it

@mwlon,

I think this is basically good to go! Can you fix the failing unit test? And maybe add in -1.0 - f32::EPSILON and 1.0 + f32::EPSILON to it

Done, by replacing the intentionally-wrong expected with the actual.  Since the point of this unit test is to make sure the expecteds make sense to us, could you sanity check them before merging?  They look good to me.

Thanks for your hard work!


Update of wrong variable name

To avoid confusion when reading the code

@JeanCollas,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Support two-phase borrows

The following code errors:
#![feature(nll)]

trait S: Sized {
    fn tpb(&mut self, _s: Self) {}
}

impl S for i32 {}

fn two_phase1() {
    let mut x = 3;
    x.tpb(x);
}

fn two_phase2() {
    let mut v = vec![];
    v.push(v.len());
}

fn two_phase_overlapping1() {
    let mut x = vec![];
    let p = &x;
    x.push(p.len());
}

fn two_phase_overlapping2() {
    use std::ops::AddAssign;
    let mut x = 1;
    let l = &x;
    x.add_assign(x + *l);
}

fn match_two_phase() {
    let mut x = 3;
    match x {
        ref mut y if { let _val = x; let _val = *y; true } => {},
        _ => (),
    }
}

fn with_interior_mutability() {
    use std::cell::Cell;

    trait Thing: Sized {
        fn do_the_thing(&mut self, _s: i32) {}
    }

    impl<T> Thing for Cell<T> {}

    let mut x = Cell::new(1);
    let l = &x;
    x
        .do_the_thing({
            x.set(3);
            l.set(4);
            x.get() + l.get()
        })
    ;
}

fn main() {
    two_phase1();
    two_phase2();
    two_phase_overlapping1();
    two_phase_overlapping2();
    match_two_phase();
    with_interior_mutability();
}

It errors less now, but the overlapping ones still error. Also see https://github.com/rust-lang/rust/issues/56254#issuecomment-444428525.

None of these error now; further researching the interaction of Stacked Borrows and two-phase borrows is more spec work than Miri implementation work.


New option: --force-color for calendar and agenda

Enables coloring even if stdout is not a tty.

closed in favor favor of #365


Adding Notes & Highlights For Future Reference

It would be better if there is an option to add our private notes for reference [like we do in Skillpipe course wares] instead of current side notes feature

⚠ Idea migrated from UserVoice
Created By: Abirami Rajendran
Created On: 2017/03/09 23:16:31 +0000
Votes at Migration: 1
Supporters at Migration: 1

Closing as this is not something our team will be building at this point.


Marathon UI health check graphic "resets" infrequently during large rolling restart

When doing a rolling restart (1000 containers), the UI for app health clears all the green and turns grey for a short period of time. This happens infrequently but I've observed it multiple times today in testing.
If I click through to the app tasks list, I see many pages of healthy, but the summarized view seems to reset.

I've started 2000 tasks to check this.
I couldn't detect any anomalies also a review of the according UI code for the HealthBar didn't show up any failures.
It seems that there was no health information on the application object for some reasons. The health informations for the tasks are bound to the different tasks objects. So this could reflect your recognized behavior.
We have some health properties on the application object we receive from the API:
tasksHealthy: 0
tasksUnhealthy: 0
tasksStaged: 100
tasksRunning: 900
...

It seems that app.tasksHealthy was 0, so the grey bar is a results of an unknown application health status.
@aquamatthias Do you have any ideas?

Looks like a service problem: the task has the health status, but the aggregated app data does not reflect that.

Hey @dontrebootme I tried to reproduce the problem, but was not able to do that.
Some background information:

during a rolling restart, all tasks of an application get restarted
the health check have to be performed for every new task
until then the status is unknown --> grey
if you have a lot of tasks (1000 in your case) this can take some time

In your screenshot I see the progress bar with a small amount of green and some tasks which are reported green as well. Hard to judge, if this is a problem.
Can you be more precise what exactly the problem is and how to reproduce?
Thanks!

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2902. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


add sample Docker file

Here's the Dockerfile and instructions I used to test #20.

Pull Request Test Coverage Report for Build #13
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.561%

Totals

Change from base Build #11:
0.0%

Covered Lines:
217

Relevant Lines:
237

💛  - Coveralls

@nrabinowitz @ibgreen Please take a look


FEAT: ORV2-1961 Display Company Suspended when Suspended

Description

during the login process, display the Company suspended error when company is suspended

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Vehicles
Dops
TPS-Migration

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are promoted to:

Merge Workflow

Upon closer inspection, this implementation will not work due to the jwt strategy we have. Closing this PR to free up resources.


Opening user home dir instead of file or project root - Yosimite

I am having an issue where both "Open" and "Open Project Root" does open terminal, but enters on the user home dir (eg: /Users/username) instead of the file or project root. I am running Yosemite with default Atom settings and the only thing I get in console is:
atom-terminal executing:  open -a "Terminal.app"

Having this issue too

Having the same issue.

Version 0.8.1. should contain a fix for this issue, but it has not been released for a few months now.
That is why I made a clone of this project about a week ago where this issue has been fixed:
https://atom.io/packages/atomerinal

@tkw1536 Thanks! That works a treat!

Thank you.

This issue is happening for me too in El Capitan.

works great @tkw1536 thank you! I am running Yosemite.

This is happening for me in El Capitan 10.11.4 and running the default Terminal and in iTerm.


unnecessary files included in repo

Extremely minor issue: while poking around trying to find why sklearn was still required (answer: because we didn't remove it until a week after we tagged v0.98.2 and uploaded to PyPI), I saw a couple unnecessary files that are either outdated and/or unneeded, one of which was built with a now very old version of sklearn, and would not work properly even if someone did try to use it. I'm going to remove these files for a bit of clean up before we tag a new version of RAIL.

closed by #306


Visual Studio Code Addon

The VSIX package for installing for Visual Studio doesn't work for Visual Studio code.
I would like to request that a compatible package be made for VS Code.
Steps to Reproduce the Problem

Download the VSIX package
Go to extensions tab
Select the ellipsis in the extensions tab
Click "install from VSIX"
Select the VSIX package
Receive extension package .json error

Specifications

Version: 2.5.0
Operating System(s): Ubuntu 19.10

Given this announcement, looks like getting the same functionality into VS Code will be a higher priority..


Full names for manufacturers

There are several manufacturers listed only by their abbreviation. I'd like us to know what who these are. @dyf does it make sense to use the BaseName class here? My worry with that is that we don't have abbreviations for all manufacturers.
Specific examples:
OEPS = Open Ephys Production Site
IMEC
FLIR
LG
MPI
I think for some of these we want to use the abbreviation in most instances (eg. IMEC) but I also think we want to know what these all are.

BaseName has optional abbreviation I believe, so it shouldn't be an issue to use.

Duplicate of other ticket


plugin good added for logging

Hi,
I added the plugin good added for logging on console and file.
check docs: https://github.com/hapijs/good
A logging plugin that supports output to console, file and udp/http endpoints

Hello, is this been approved or rejected?

@victorsosa
Thanks for the PR, it has been merged.
Sorry for the super-late response, for some reason I was not receiving notifications for this repository


Allow non-zero axis for .rolling (for application over columns)

Looks good to me.  Merging soon if no comments.


Custom token with theme patcher not working

Hello,
I'm trying to add a custom token in HA with theme patcher, but it does not work for me...
Any help would be greatly appreciated.
This is what my script looks like :

and this is the error HA is throwing :

I've also tested with something more "simple" just to see :

This time I get no error in HA, but that test token is not added to the graphite.yaml file...
PS: this is what my shell commands looks like :

Many thanks for any help you could provide.
PS: also, It is currently not possible to set "none" as value for a token.
I've had to modify the script to allow it, could you please add that possibility "officially" ?
Thanks.

Hi there,
We use GitHub issues as a place to track bugs and other development-related issues.
Please see the link below to our dedicated support line:
Help Center :  Click Here
Ticket ID: WB240
Note: Click on the live chat icon at the bottom corner of the page to start a conversation.

Hi @NeeeeB,
It would be great if you could share your theme patcher log file. You should find it in scripts/logs/graphite_theme_patcher.log. Additionally, please provide the corresponding shell script entry.
It seems like you’re trying to patch generic (non-validated and non-converted) values. I’d need more details about this, specifically the type of value you’re aiming to patch. Keep in mind that the "generic" option is primarily a developer feature and bypasses all type checks.
If you’re patching an RGB value, ensure the RGB components are joined with commas, like this:
action: shell_command.patch_theme
    data:
      theme: graphite
      token: token-rgb-primary
      type: rgb
      value: "{{ my_color| join(',') }}"

I’m currently out of town for the next few days over Christmas, so I may not be able to help you immediately. However, when I find some time and have more details from you, I’ll do my best to assist.
Merry Christmas! 🎄


Allow to set uid and gid instead of owner and group.

https://github.com/Mic92/sops-nix/issues/514
Allow to set uid and gid instead of owner and group. No checks will be performed when uid and gid are set.
sops.secrets = {
  sslCertificate = {
    sopsFile = ./secrets.yaml;
    owner = "";
    group = "";
    uid = config.containers."nginx".config.users.users."nginx".uid;
    gid = config.containers."nginx".config.users.groups."nginx".gid;
  };
  sslCertificateKey = {
    sopsFile = ./secrets.yaml;
    owner = "";
    group = "";
    uid = config.containers."nginx".config.users.users."nginx".uid;
    gid = config.containers."nginx".config.users.groups."nginx".gid;
  };
};

Could you also add a simple secret example to our existing nixos test? Than we won't regress in future.

@munnik cd sops-nix; nix-build -A sops-install-secrets.tests

For a single test:
nix-build -A sops-install-secrets.tests.age-ssh-keys

Could you also add a simple secret example to our existing nixos test? Than we won't regress in future.

Done in https://github.com/Mic92/sops-nix/pull/637/commits/a24e29e38dca7e16b88bade2c5789de396dc7273

@mergify queue

Thank you! Also, for the help and feedback. Learned a lot of new Nix things. :+1:


Mainfest version 2 is depreciated.

Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details.

@calee0219  I have created a PR for this


PianoKeyboardView not showing up

Issue
I added this package via SPM on the Example app, but PianoKeyboardView did not appear. What do I need to do additionally?

ScreenShot

Device / OS
iPhone 13 / iOS 16.4.1

same problem

you need to explicitly specify style in PianoKeyboardView

Example app should be fixed now


the differences between checkpoint and pretrained model

Hi,
I just want to know the differences between checkpoint and pretrained model in pytorch. Does pytorch have checkpoint files like tensorflow? I just know the .pth file created by function of torch.save.( I am a new user in pytorch, please don't mind if my qusetion is easy...)
Thank you very much!

Hi @EricKani basically a pretrained model can be also considered as one checkpoint, the only difference is the way how you would like to use it. For fine-tuning, you could initialize all the weight in the network with a pretrained model, while you could also resume the training from a pretrained model, just treat it as a checkpoint.


Types for consumers

Codecov Report

:exclamation: No coverage uploaded for pull request base (types_for_consumers@c511e7f). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                  Coverage Diff                   @@
##             types_for_consumers      #35   +/-   ##
======================================================
  Coverage                       ?   54.60%
======================================================
  Files                          ?       32
  Lines                          ?     5087
  Branches                       ?        0
======================================================
  Hits                           ?     2778
  Misses                         ?     2309
  Partials                       ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


What resolution of the files?

What is your question?
I would like to know what resolution the buttons have, if they are those of the original game cube it would be a better idea if they were in HD.

Most packages are configured so that they have four times the resolution of the original textures.
As an example if the original texture is 48x48 the replacement texture is 192x192.


Unexported

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@03cc4f4). Click here to learn what that means.
The diff coverage is 22.72%.

@@           Coverage Diff            @@
##             master     #78   +/-   ##
========================================
  Coverage          ?   34.5%
========================================
  Files             ?      59
  Lines             ?   28026
  Branches          ?       0
========================================
  Hits              ?    9669
  Misses            ?   17327
  Partials          ?    1030

Impacted Files
Coverage Δ

pkg/server/collector.go
0% <0%> (ø)

pkg/server/grpc_server.go
16.86% <0%> (ø)

pkg/server/rpki.go
18.6% <26.41%> (ø)

pkg/server/server.go
36.05% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cc4f4...5c8fd14. Read the comment docs.


Add Error::source

As discussed in https://github.com/nox/serde_urlencoded/pull/63 Error::source was added in 1.30.0
This PR implements Error::source

bors r+


Add text-spacing feature

I took data from MSDN.
@Fyrd this PR is important for Autoprefixer 6.3 release https://github.com/postcss/autoprefixer/issues/588

@cvrebert fixed. Sorry.

@cvrebert fixed. Seems like I should not send PR at the morning :).

Travis is now passing :-)

Thanks!