[wip] Small race fixes

Description:
There are a few race conditions which seemed to have snook in with the introduction to the mulit-websocket connection multiplexer. This pull request addresses those race conditions which were found using go run -race.
Breaking changes:

[x] Changed rest.Trades to use the correct trade type for authenticated trade data. Not really a breaking change as this was not working before but the data type has changed.

New features:
None
Fixes:

[x] Multiple writes when trying to send a websocket message race
[x] Building snapshot and get orderbook race

PR status:

[x] Version bumped
[x] Change-log updated

Seems like the change affected the v2 integration tests.

Seems like the change affected the v2 integration tests.
Checking now

@JacobPlaster thank you. The code looks good to me. I ran a few tests and found a corner case. Enabling order book checksum verification leads to another data race. Pasting more details:
WARNING: DATA RACE
Read at 0x00c0001881d8 by goroutine 25:
  github.com/gorilla/websocket.(*Conn).beginMessage()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:459 +0x5e
  github.com/gorilla/websocket.(*Conn).NextWriter()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:500 +0xae
  github.com/gorilla/websocket.(*Conn).WriteMessage()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:753 +0x261
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*ws).Send()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/transport.go:89 +0x389
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).EnableFlag()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/api.go:33 +0x1ae
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).checkResubscription()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/client.go:489 +0xaac
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).handleOpen()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/client.go:533 +0x169
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).handleEvent()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/events.go:119 +0x469
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).handleMessage()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/client.go:461 +0x10a
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).listenUpstream()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/client.go:421 +0x221

Previous write at 0x00c0001881d8 by main goroutine:
  github.com/gorilla/websocket.(*messageWriter).endMessage()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:526 +0xb9
  github.com/gorilla/websocket.(*messageWriter).flushFrame()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:613 +0x92e
  github.com/gorilla/websocket.(*messageWriter).Close()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:711 +0xba
  github.com/gorilla/websocket.(*Conn).WriteMessage()
      /Users/andrey/Code/go/src/github.com/gorilla/websocket/conn.go:760 +0x315
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*ws).Send()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/transport.go:89 +0x389
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).subscribeBySocket()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/api.go:58 +0xed
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).Subscribe()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/api.go:79 +0x102
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).SubscribeBook()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/api.go:121 +0x454
  main.main()
      /Users/andrey/bitfinex-api-go/examples/v2/ws-book/main.go:26 +0x246

Goroutine 25 (running) created at:
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).connectSocket()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/client.go:395 +0x32e
  github.com/bitfinexcom/bitfinex-api-go/v2/websocket.(*Client).Connect()
      /Users/andrey/Code/go/src/github.com/bitfinexcom/bitfinex-api-go/v2/websocket/client.go:220 +0xbf
  main.main()
      /Users/andrey/bitfinex-api-go/examples/v2/ws-book/main.go:18 +0xe6

Thanks @andreygrehov, the help is appreciated! The above error was found without using this PR fix right? I've tested this version out quite a lot and cant seem to reproduce any race conditions

@JacobPlaster I tested your branch. Let me double-check.

@JacobPlaster apologies. I indeed mistested it. No more races.

No problem, thanks again


Added replicaset tracking to metrics

See https://github.com/cloud-bulldozer/e2e-benchmarking/pull/615 for context

ReplicaSets get created on a 1:1 ratio with deployments, are you sure we need this?

@memodi See above, does this satisfy the requirement you've mentioned?

Thanks for the review @rsevilla87! Made the requested changes :+1:


Enums are generated as strings

Try starting the latest react examples. It seems that this applies to all enum properties.
The following error appears:
ERROR in src/samples/charts/category-chart/annotations-all/index.tsx:93:21
TS2322: Type 'string' is not assignable to type 'CategoryChartType'.
    91 |                 <IgrCategoryChart
    92 |                     ref={this.chartRef}
  > 93 |                     chartType="Column"
       |                     ^^^^^^^^^
    94 |                     computedPlotAreaMarginMode="Series"
    95 |                     isHorizontalZoomEnabled="false"
    96 |                     isVerticalZoomEnabled="false"

This is on purpose, they are supposed to accept strings, the types have already been fixed.


Why there is three replicated required?

It is bit confusing, In this protocol three replicates are generated.
Can you explain why three replicated required ?

Some researchers and articles reviewers require that a simulation be replicated 3 times as a sort of validation and sampling a wider space of conformations.

Thank you for answering @Marwa-Abdelkader, and same as the other issue, I just forgot to answer.
+1 On your answer.
Reproducibility is important. For example, I already asked to remove an MD result in a paper I reviewed because they show a loss of secondary structure when increasing the temperature slightly. Still, without replicas, it is hard to say if it is because of the temperature or just "by chance". If you observe the same thing in 3 replicas then it is easier to conclude that this observation is due to the parameter you have changed (here: the temperature) and not due to the seed.


Potential copy-paste error in Http message factory

I was looking for the exact implementation of proxies, and stumbled across this.
https://github.com/aws/aws-sdk-net/blob/3fc03fac088bee773d2c4b4df746408688fc5a57/sdk/src/Core/Amazon.Runtime/Pipeline/HttpHandler/_bcl/HttpWebRequestFactory.cs#L421-L422
It would seem metric no. 2 should use a name for "Port", and not "Host".

Yup. Looks like a bug to me.  Thanks for pointing this out!

Fixed with https://github.com/aws/aws-sdk-net/commit/b180905d51779336bb58b5d1e3f78d5a3f340ef0.


where are  the xxx_base.txt files generated?

I just found the fewshot  txt files generated in prepare_xxx_few_shot.py.  where are  the xxx_base.txt files generated?

Have you solved this problem? I made this mistake when I started training  "Dataset 'voc_2007_trainval_base1' is not registered!

The dataset files can be found here. Regarding the xx_base.txt files, we only generate shots for each class, and in the code it will load in the correct class depending on whether it's a base class or a novel class.


caching requests

to avoid unnecessary network requests (and therefore contentful "bandwidth", which is limited depending on the amount of $ you pay) – we should cache the locals in-between "watch" compiles. to pull down fresh content that may have been edited since your last compile, you'll need to stop the watcher.
this configuration should be true by default, but overridden by cache: false in your extension config.

+1 would also greatly improve development speed for people with not-so-fast internet.


⚠ Atom Calculator has degraded performance

In c6b1e61, Atom Calculator (https://atomcalc.org) experienced degraded performance:

HTTP code: 520
Response time: 22591 ms

Resolved: Atom Calculator performance has improved in 17cc11e after 11 minutes.


Realtime Wireless graph does not work

Router: TL-WDR4300
LuCI: Master (git-21.008.63257-bc121a5)
OpenWrt: SNAPSHOT r15466-2e590a6364
It always shows zero.

@jow-
FYI, likely an additional piece broken by the iwinfo changes.
I tested with ath10k ipq806x/R7800 and mwlwifi mvebu/WRT3200ACM and the wireless realtime remains empty.

@jow-
FYI, likely an additional piece broken by the iwinfo changes.
I tested with ath10k ipq806x/R7800 and mwlwifi mvebu/WRT3200ACM and the wireless realtime remains empty.

Likely here the libiwinfo needs modernising, too:
https://github.com/openwrt/luci/blob/master/modules/luci-mod-status/src/luci-bwc.c#L256
static void * iw_open(void)
{
	return dlopen("/usr/lib/libiwinfo.so", RTLD_LAZY);
}

Likely here the libiwinfo needs modernising, too:
https://github.com/openwrt/luci/blob/master/modules/luci-mod-status/src/luci-bwc.c#L256
static void * iw_open(void)
{
	return dlopen("/usr/lib/libiwinfo.so", RTLD_LAZY);
}


Dashboard branches should be captured in the URL, make it sharable, refresh should use last selected branch

I wanted to share the devicelab test results for a particular branch, but the URL is just https://flutter-dashboard.appspot.com/#/build which defaults to master.
When I'm looking at a branch and hit refresh, it also returns to the master branch.

\cc @CaseyHillers

It would be nice to enable that also for the performance dashboard.


docs(Tracer): remove link to nonexistent method

The previously referred method was removed from the API, hence it no longer exists. Must say too that semantic versioning was used wrong! Removing this method was a breaking change. The same as removing ScopeManager.activate(Span span, boolean finishSpanOnClose). Please be more careful with the versioning of the libs, deprecating a method is better than removing directly :)

Nope, it wasn't used incorrectly. OpenTracing never made it out of 0.y.z:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
https://semver.org/#spec-item-4


[docs] Add a customization example with ToggleButton

Adds an example on the dividers component page to show vertical orientation, pretty straightforward 😄

[x] I have followed (at least) the PR section of the contributing guide.

@nrkroeker Thank you

@oliviertassinari Sorry I didn't end up having time to wrap that up, thank you for taking care of it! I've put together a stripped down version of this example that might be more suited to the divider demo but I can make a new PR for that.

@nrkroeker No problem :)!


Pagination jumps down and up after clicking a page element within pagination

Checks

[X] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to Vue Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
0.6.12
Description
The whole pagination bar jumps down and up quickly after clicking a page element.
This does not happen with the same code in v3, so we had to downgrade to ^0.5.15
Reproduction Link
No response
Steps to Reproduce

Activate Pagination (options)
Create a carousel that leads to a more than one page (so there are active and non-active pagination buttons in the pagination)
Click an inactive button

Expected Behaviour
The whole pagination bar should stay in the same position

add this to fix pagination jumping up and down
.splide__sr {
display: none !important;
height: 0 !important;
}


Move masking of the Forbidden error to the handler

Is there a related GitHub Issue?
No

What is this change about?
Error masking is usually done in the HTTP handlers rather than in the
repositories.

Does this PR introduce a breaking change?
No

Acceptance Steps
N/A - no functional change

Tag your pair, your PM, and/or team
@georgethebeatle

It turned out that we cannot merge this change as masking the forbidden error in the repo on get has the purpose of space managers (that are allowed to get service bindings, but not delete them) get forbidden errors rather than not found. This has been expoxed by an e2e test failure


Find a way to inject  AmazonS3Client client in  the RollingFileSink in a dotnet core application

In the RollingFileSink.cs
private async Task<PutObjectResponse> UploadFileToS3()
The library creates a new instance of the AmazonS3Client
new AmazonS3Client();
Doing this would not get all the aws configured options at startup and this is especially bad for AWS using different IAM roles
For my fix, I Injected the IServiceProvider (I know this is not the best way)
so instead of creating a new instance,
I used
client = (AmazonS3Client)serviceProvider.GetService(typeof(IAmazonS3));

Yes, this needs an extension method for Serilog / AspNetCore. I will check this and see what I can do here.

This should be fixed with https://github.com/SeppPenner/Serilog.Sinks.AmazonS3/commit/1bc72a9fa5b5015a3f0bb088b9cc9e25c6a406e7 and in the next release.

Version 1.1.0 should work here, you can now specifiy a client option of type AmazonS3Client in the logger configuration as first parameter.


TextConverter property for finer control over NumericUpDown text display

What does the pull request do?
This PR introduces TextConverter property to NumericUpDown
which allows for finer control over string representation of NumericUpDown values.
This automatically provides a workaround for hexadecimal mode that is currently
broken due to NumericUpDown value currently being decimal.
What is the current behavior?
Currently, setting HexNumber style causes an exception since decimal does not support that format.
What is the updated/expected behavior with this PR?
Using TextConverter property would override the entire conversion process in both directions.
How was the solution implemented (if it's not obvious)?
Bidirectional IValueConverter?-typed property.
When left being null, the conversion reverts to the original logic.

You can test this PR using the following package version. 11.0.999-cibuild0023421-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

Made changes as @kekekeks requested

You can test this PR using the following package version. 11.0.999-cibuild0023427-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0023429-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Getting Keyboard & Numberpad Height & Width for better user experience

Hello ,
It would definitely help if we can get height of keyboard and numberpad before hand without loading the keyboard . This will help in giving out much better layouts and user experience . Flutter community should save the height and width to a class so that it can be easily called and allow usage of rest of space to its maximum potential .
This feature is important as real estate on mobile screen is very limited and thus making use of every bit of space can be a game changer .

@n1k3sh
You may checkout https://pub.dev/ where you may find several packages that offers the functionality. One such is https://pub.dev/packages/keyboard_utils.
Also, see this SO link for answers on how you can find the keyboard height.
I am going ahead and closing this, as above link and plugins may help to achieve what you are looking for. If you disagree, write in comments and I'll reopen it.


Updating heading for reasons for rejection page

This aims to make it clearer that the rejection reasons are being sent to the candidate and should be directed at them.
We have evidence that some providers do not currently understand this, as they are writing about the candidate in the third person and using very short, terse reasons such as.
Screenshots
Before

After

This was a quick idea that @MaeveRoseveare and I came up with. @MylesJarvis what do you think?
We do already have this warning on the following page, but perhaps that's not being read or understood?

(Am expecting this to break some of the tests but let's see...)


Support jwt 2

SimpleJWT 4.6.0 already support sPyJWT 2.0.0. Investigation just shows that we merged PRs for the alpha versions ahead of time, but our CI wasn't using the alpha versions so the tests never failed until the mature 2.0.0 came out. Tests just failed, but a quick adjustment to the tests without adjustments to the actual library shows everything passing.
Many tests relied on passing a payload into encode and changing it payload by reference. In PyJWT 2.0.0, the payload is copied (dict.copy()).
Verify was deprecated in favor of using the option verify_signature. This is reflected in backends.py. Unless you wrote verify=False, you are not effected by this change as we will continue to use the verify keyword.

[xrmx: same as #349, fixed first commit message]

Once the CI passes and I merge this, you'll need to rebase the other PR so I can merge that as well.


wheel files for Python 3.7

Python 3.7 was just released yesterday and there is already a Stack Overflow question asking about how to get pyodbc installed via pip. Looks like we need some cp37 wheel files....

For the time being, Christoph has made cp37 wheels for 64-bit and 32-bit Windows available here.

Version 4.0.24 was released today with binary wheels for macOS and Windows.  I apologize for getting so far behind - I'm a bit gun shy about PRs after 4.0.22.  I expect things to be smoother from now on and I'll stay on top of releases.


Use Mopidy's proxy config

See https://docs.mopidy.com/en/latest/api/httpclient/ for useful helpers.

I sort of fixed this over on the fork I've been working on. It works, but it is not pretty. Any suggestions on how to do it properly?
https://github.com/natumbri/mopidy-youtube/tree/feature/proxy


A few suggestions :)

A Desmos to Wolfram module: The ability to convert a desmos expression in to ascii math.
Symbols module: A keyboard or shortcuts to type greek letters and other math symbols.
Autosave module.
The replace all feature needs to be able to replace all forms of a letter: L->B should replace L2 by B2, we should be able to choose.

Desmos to Wolfram:  see https://github.com/Heavenira/desmos2ascii - in the repo Heaverina said it could be coming to Desmodder sometime.
Symbols module: Desmos Unlocked extensions allows for this, although now that extension has been broken in a while. I don't know what Jared has in mind, but also implementing more greek letters causes problems for Desmos, as they might want to give them special functions in the future (ex: theta currently).
Autosave: Already exists in native Desmos using recover graph feature works almost all the time.
Replace: That would be nice indeed


Create first unit test (for checking captures)

Add a first unit test for function board.CheckCaptures.
Closes #15 and a checkbox in #4 :)

No minutes! (A good reason to write unit tests for your own functions as there are theoretically other scenarios to test too...)
Feel free to co-author if you wanna add them, if not plz update issue & I'll merge as-is ;)

Ok, added #16 feel free to merge


Cache CI builds

enable caching for CI builds, which reduces the build time from 10 min to 1 min, and
add more fine-grained build steps (running tests is separate from building them).

Oops, accidentally rebased rather than squashed.
Thanks!


Remove irrelevant folders from cmake and swig

Cmake and swig are stripped down. But not Python yet.

@jakoch for python this?:
rd /s /q "C:\Python27\Doc"
rd /s /q "C:\Python27\tcl"

rd /s /q "C:\Python35\Doc"
rd /s /q "C:\Python35\tcl"


KubeCon Docs Sprint: Added Missing Weight for Concepts/Workloads/Pods

This PR adds a missing weight to the Downward API subsection of Concepts/Workloads. This will allow consistent sorting for localization.

Related # https://github.com/kubernetes/website/issues/35093

/lgtm
/approve


avizo: 1.1 -> 1.2

Motivation for this change
Update Avizo to release 1.2.
Changelog:

Fix several bugs
Improve styling options and the defaults

Tested working with a random avizo command: avizo-service & ; avizo-client --image-resource=volume_high --progress=0.6 --bar-bg-color='rgba(0,0,0,1)'
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Can we also remove the use-sysconfdir-instead-of-etc.patch file here?

Oops, forgot to delete that file.


use the new github simplified docs publishing

Instead of handling the gh-pages branch, github now alloes using /docs directly: https://github.com/blog/2228-simpler-github-pages-publishing
Maybe its a good Idea to switch?

Took a short glance at it and it might be a bit simpler but not much.

so we stick to the plan


Rule proposal: NoSpacesBeforeTabs

As found here and described here.
Sometimes when one person is using tabs with size 4 and another has size 3 tabs, extra spaces can make formatted code look wrong.  This rule just makes sure you don't have a tab, a space, and another tab or something strange like that.
This issue tracks porting the rule from the legacy StyleCop style implementation to StyleCop.Analyzers. You may assign it to me.

I'm going to vote against this one, at least for now. This rule would only apply to users that disable both SA1027 (use spaces) and SX1027 (use tabs). If a team doesn't feel strongly one way or the other regarding tabs, I'm not sure this rule would provide much benefit for them either.

I'm undecided yet. It would very much depend on the implementation of SX1027 to see if it is useful at all. If SX1027 would accept <tab><tab><space><space>, which is a sequence generated by Visual Studio when having tab size 3 and indentation size 4, then this rule would make sense.

@sharwell I wonder if you're misunderstanding the use case here. It is for use in combination with SX1027. Consider the following code, and imagine tab width + indent are set to 5 characters for sake of conveniently making these characters "visible" in the below snippet:
<TAB>var foobar = select a
<TAB><TAB><TAB>   from source;

This is roughly what VS would do by default when using tabs. It uses as many tabs as possible to intend the second line then falls back to spaces for the remainder of the indent in order for the LINQ query to line up with the previous line. While this looks good with tabs set to 5 characters wide it will not look good when the IDE on another user's machine is configured for 3 characters:
TABvar foobar = select a
TABTABTAB   from source;

This of course is one of the chief arguments against using tabs. But this is a fault of the language service's use of mixed tabs and spaces rather than a fundamental flaw with tabs. If instead the original characters were:
<TAB>var foobar = select a
<TAB>             from source;

Then again when 5 column tabs are changed to 3 column, the appearance is still good:
TABvar foobar = select a
TAB             from source;

This proposed rule is to enforce and preserve the optimal combination of tabs and spaces so that it looks good at any tab width.
I actually had convinced the Roslyn team to fix their default behavior for indentation to produce the correct combination of tabs and spaces since they were writing it from scratch, although I haven't confirmed whether they do it or not this close to RTM.

That's a really nice explanation. I'm changing my vote to :+1:

Why would we not just say this is SX1027?

Hmm.... You know I think I just explained a different rule. "NoSpacesBeforeTabs" doesn't seem to fit my scenarios since there are never any spaces before tabs. Sorry. The NoSpacesBeforeTabs rule is about preventing this:
<SPACE><TAB>int foo;
<TAB>string bar;

This is visibly equivalent so long as the leading spaces are fewer than the width of a tab. But it's noise that Format Document would clean up and therefore a StyleCop rule keeps the noise down and the indentation at its simplest form.
I shouldn't have gotten these two confused. Sorry for that.
As for whether my earlier representation about proper indentation with various tab widths should be merged into SX1027, we could. Since it helps make tab use better that makes sense to me. I'll copy my earlier comments into the spec for SX1027 and we'll consider that the NoSpacesBeforeTabs proposal is just the simple one I described just now. Sound good?

Ya, my discussion about changing tab widths is my OneTabIndent rule.

OK. I've updated this issue's description to keep it focused on the original proposal and updated #730 with the description from my earlier comment

Sound good?

Sure. But now I'm back to not understanding why we would need this rule. The case you described is mixed indentation, and both SA1027 and SX1027 would report it as such.

As long as they do report it as such, sure. We can close this. It might be interesting to add tests for each one to confirm.

Remember if we ever find out that this isn't working out for some users, we can always revisit the issue :smile:

Verified that we are testing this case in SA1027: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1027UnitTests.cs#L76


mongoose >= 4.11.0 logs a deprecation warning for generated service

feathers generate service
Choose mongoose
Choose /messages
node ./src
and the console logs

(node:4447) DeprecationWarning: `open()` is deprecated in mongoose >= 4.11.0, use `openUri()` instead, or set the `useMongoClient` option if using `connect()` or `createConnection()`. See http://mongoosejs.com/docs/connections.html#use-mongo-client

Looks like we'll have to change https://github.com/feathersjs/generator-feathers/blob/master/generators/connection/templates/mongoose.js#L6 to
mongoose.connect(app.get('mongodb'), {
});


Use FloatTensor to store Cifar10, allowing it to fit into the 2GB add…

…ress space.

@crowsonkb Thanks!


 Godot couldn't load the Materials (.mtl) properly.
Steps to reproduce:

Create a new Project
Close Godot
Make inside the Project a folder and put there some Wavefront Object with its Material Files
Put also the Textures inside the folder
Open godot and let it import everything
Try to place one of the Objects: no texture or material on it
Console also reports errors like:

ERROR: Couldn't open MTL file 'curve_01.mtl', it may not exist or not be readable.
   At: editor/import/resource_importer_obj.cpp:49
WARNING: _parse_material_library: OBJ: Ambient light for material 'street_01' is ignored in PBR
     At: editor/import/resource_importer_obj.cpp:67
ERROR: No loader found for resource: res://Models/Streets/street_base_01.png
   At: core/io/resource_loader.cpp:285
WARNING: _parse_material_library: OBJ: Ambient light for material 'street_01_NONE' is ignored in PBR
     At: editor/import/resource_importer_obj.cpp:67
ERROR: No loader found for resource: res://Models/Streets/street_base_01.png
   At: core/io/resource_loader.cpp:285

bump still exists and it's a core feature

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

Yes, it is still reproduceable in 3.2.3.
The Zip contains an Godot project that shows the issue, the bug also survives restarts. the only fix for now is to manually re-import all Models.
I also added the blender source file that I used to create the Wavefront Object.
ModelImportBug.zip

Confirmed in 64d3827
The model appears untextured when you remove .import folder, but it's fine when you remove only the model file imports.

Confirmed as still reproducible in recent Godot versions by @and-rad in https://github.com/godotengine/godot/issues/36173#issuecomment-1525699419.

Just to be clear, this is only reproducible on the 3.x branch. On 4.0.2-stable and onwards this works without issues.

Just to be clear, this is only reproducible on the 3.x branch. On 4.0.2-stable and onwards this works without issues.

Not true. Problem exist with: https://github.com/godotengine/godot/releases/download/4.2.1-stable/Godot_v4.2.1-stable_win64.exe.zip


NotADirectoryError when running --generate-hashes

Running pip-compile works flawless, but pip-compile --generate-hashes produces the following error:

Traceback (most recent call last):
File "/home/ric/.local/bin/pip-compile", line 11, in
sys.exit(cli())
File "/home/ric/.local/lib/python3.5/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/home/ric/.local/lib/python3.5/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/home/ric/.local/lib/python3.5/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/ric/.local/lib/python3.5/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/ric/.local/lib/python3.5/site-packages/piptools/scripts/compile.py", line 186, in cli
hashes = resolver.resolve_hashes(results)
File "/home/ric/.local/lib/python3.5/site-packages/piptools/resolver.py", line 77, in resolve_hashes
return {ireq: self.repository.get_hashes(ireq) for ireq in ireqs}
File "/home/ric/.local/lib/python3.5/site-packages/piptools/resolver.py", line 77, in
return {ireq: self.repository.get_hashes(ireq) for ireq in ireqs}
File "/home/ric/.local/lib/python3.5/site-packages/piptools/repositories/pypi.py", line 169, in get_hashes
for candidate in matching_candidates
File "/home/ric/.local/lib/python3.5/site-packages/piptools/repositories/pypi.py", line 169, in
for candidate in matching_candidates
File "/home/ric/.local/lib/python3.5/site-packages/piptools/repositories/pypi.py", line 176, in _get_file_hash
download_dir=tmpdir, only_download=True, session=self.session
File "/usr/lib/python3/dist-packages/pip/download.py", line 821, in unpack_url
hashes=hashes
File "/usr/lib/python3/dist-packages/pip/download.py", line 663, in unpack_http_url
unpack_file(from_path, location, content_type, link)
File "/usr/lib/python3/dist-packages/pip/utils/init.py", line 623, in unpack_file
untar_file(filename, location)
File "/usr/lib/python3/dist-packages/pip/utils/init.py", line 595, in untar_file
with open(path, 'wb') as destfp:
NotADirectoryError: [Errno 20] Not a directory: '/tmp/tmprk7taktxbuild/LICENSE/LICENSE_STIX'

Environment Versions

Ubuntu 16.04
Python 3.5.3
pip 9.0.1
pip-compile 1.9.0

This is my requirements.in file:

seaborn==0.7.1
pandas==0.20.1
numpy==1.12.1
scipy==0.19.0
tqdm==4.11.2
matplotlib==2.0.2

I encountered the same error – I believe it's matplotlib – see https://github.com/jheinen/matplotlib/blob/master/LICENSE/LICENSE_STIX .

Seems to be a duplicate of #438.


Copy editor

I found the default "Copy" very painful... on small screen with a pretty small font and big fingers, I almost always miss the line or the part of text I want to copy and ends up doing my "Copy" over and over until I get it right. Also, the console has no margins, so copying from the first character of a line is mission impossible (almost).
The idea in this pull request is to show the scrollback buffer of the current console to the user in an EditText (in a new Activity) with large margins, allowing to use the default Android copy/paste system.
I haven't found a way to restore CR/LF to their proper places, it seems it's impossible without adding a buffer somewhere (I think TerminalView::mAccessibilityBuffer does somthing like that).

I agree this is a problem, but I kind of wanted a better copy & paste experience all around. I'd rather have a "loupe view" when touch is being used on a phone. Also there are a couple use cases with different devices:

The loupe view for touch on the phone.
Using selection with a mouse:

On a TV where the remote control has a touchpad or joystick.
Tablet with a bluetooth mouse where there is a cursor for selection.

(Also tagging @jklein24 who has discussed this with me before.)

Won't it be "more simple" to extend or mimic the behavior of TextView in TerminalView and use the default Android copy/paste system ?

This seems very similar to what Juice SSH does right now for copy. I definitely agree that, for the reasons you've mentioned, this is a nicer solution for touch selection (there's a reason all of Android text selection works this way).
However, I'm not sure that I like the idea of having "copy" and "copy editor" menu items separately. As a user, I'd want the app to choose the mode that makes the most sense in the right context. As @kruton noted, if I'm using a bluetooth mouse, copying should just work like on a desktop. I just feel like having multiple copy modes in the menu is a bit confusing as a user.
I also don't totally love the idea of opening a new activity to do copying. It felt really weird to me the first time I saw this in JuiceSSH. My ideal here would be that we make it feel like the same view in a copy mode like an ActionMode. I wonder if we could silently swap out the terminalview for an EditText when the user enters copy mode to get all the Android text selection goodness. It's hacky, but could result in the nicest UX.

cc @bengolds

I've deleted the branch by mistake !
Whatever, we all agreed that it was not a good solution.
For testing purpose I've made :
In TerminalView :

extends TextView instead of View
setTextIsSelectable(true), unfortunately this is >= API 11
SetText("This is a test !")

In ConsoleActivity

Remove all long click references (gestures & context menu).

And it seems work perfectly !
Obviously this still need work, but what do you think ?


access: go-approvers

I'd like to help out with issue gardening would like to request access to the go-approvers team https://github.com/orgs/golang/teams/go-approvers
See https://golang.org/wiki/GithubAccess

It's not up to me and I hope this won't come out as me trying to be a gatekeeper, but please note that the wiki says

If you've been regularly active in the Go community for some time

There are only a dozen comments from you in the issue tracker and just one in the last 6 months. People are usually given gardening access after they've been visibly and regularly active in the tracker for some time.
Anyway cc @broady @bradfitz for a decision.

Hi @iand,
As you haven’t been very active recently we ask that you keep up with community work and we can revisit once you’ve had a more solid record of contributions.
Thanks


Update PostgreSQL JDBC Driver dependency due to CVE-2022-21724 vulnerability

Due to CVE-2022-21724 vulnerability, it's recommended to upgrade PostgreSQL JDBC Driver to version >= 42.3.2.
Currently, for example, the hibernate-types-55 pom.xml uses version 42.2.19.
Although the dependency is of type "provided", it's probably a good idea to update it.

All dependencies are optional. The library uses whatever you have at runtime. For instance, the 50 and 43 modules use Java 1.6, hence all dependencies have lots of security issues, but that's not a problem since the libraries are used only during testing and are not provided to the user.


See https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code

Please report the output of brew gist-logs openssl
Please check the warnings output by brew doctor
Unset LD_LIBRARY_PATH if you have it set.


Antispam important note to headers #740

Added important note on #740
Copy review @nenonix @JohanFreelancer9 is required on this one guys. Thank you in advance!

@chrisda - PR has been copy edited and is ready for final review. This is based on issue #740
Thank you.
cc: @kenwith


Action manifest not working

"The action manifest was not found" when I play the game
I tried

restarting (SteamVR, Unity, PC)
reinstalling
moving actions.json to the main folder

actions.json needs to be in the StreamingAssets/SteamVR folder. If you're still having this issue can you attach a log?

@zite
In my environment I have the same problem when I put the app in a folder that contains non-ASCII characters.
It's probably a runtime issue as it gives an error on the SteamVR web console.


Does not compile with GHC 8.4.*

[1 of 2] Compiling Paths_tasty_html ( dist/build/autogen/Paths_tasty_html.hs, dist/build/Paths_tasty_html.o )
[2 of 2] Compiling Test.Tasty.Runners.Html ( Test/Tasty/Runners/Html.hs, dist/build/Test/Tasty/Runners/Html.o )

Test/Tasty/Runners/Html.hs:115:10: error:
    • No instance for (Semigroup Summary)
        arising from the superclasses of an instance declaration
    • In the instance declaration for ‘Monoid Summary’
    |
115 | instance Monoid Summary where
    |          ^^^^^^^^^^^^^^

Should be an easy fix: just write the instance of Semigroup for Summary.

Thanks for the notice — should be fixed in the version <IP_ADDRESS>.


Add duration of element.longPress for iOS

Related to #410. I also added the test case Long Press Me 1.5s.

Alright, I started working on this feature base on this PR.

@jozan, for Android?

For iOS, we need this feature eventually for Android as well but even
getting iOS to work would be very nice.
I tried to rebase to master but it did not work out of the box since lot
has changed past three months especially in generation dir. Also, after
rebase both longPress and longPress(duration) did not pass tests and failed
to error from this line:
https://github.com/wix/detox/blob/master/detox/ios/Detox/MethodInvocation.m#L225
where value i was 0.
I don’t have time to debug further today.
On Sun, 4 Feb 2018 at 22.31, Rotem Mizrachi-Meidan<EMAIL_ADDRESS>wrote:

@jozan https://github.com/jozan, for Android?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wix/detox/pull/412#issuecomment-362937030, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXsqY4PksoiZHmNxM3_YnH-F0mjDShOks5tRhONgaJpZM4QglCG
.

 Sorry for the huge delay. We have intention to merge this in.

Any news on this PR? Let’s merge for iOS and then in the future add for Android?

Yes, let's do it

@jhen0409 Could you please merge master and see that tests are not broken?

@LeoNatan 👌

Thanks!

@yershalom Jenkins is flaky, please look why.

The some style changes caused by Prettier, I reverted it.

Cool. Let’s wait for the CI and I’ll merge. Thank you for your contribution!


Added the domain for Box Elder School District<EMAIL_ADDRESS>

It should be noted, that each student in Box Elder School District also has an email under the domain of<EMAIL_ADDRESS>which is provided to give students access to Microsoft's Student A3 plan among other things... But most students don't even know about the other domain, so I'm only going to register this one (:

A bit more information:
District Website

I realized I did not create a proper request (since this is a district domain) I will probably return later with a corrected request.


[Frontend] [PaddlePaddle] group_norm adjusts test accuracy

Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
Solve the problem:
https://github.com/apache/tvm/issues/11435
@jiangjiajun  @driazati  @masahi

@driazati @masahi  Can you help rerun tvm-ci?  failed to docker pull images

I don't know how to run a new job as an admin. You can also rebase and push.


[RFE] Add MPI3MR kernel module

Current situation
MPI3MR module is not present in default build :
CONFIG_SCSI_MPI3MR is not set
Impact
RAID controllers using MPI3MR module (standard for Dell 16gen, PERC12, H965i) are not configured.
Ideal future situation
New images contain mpi3mr module.
Implementation options
N/A
Additional information
N/A

The change itself to enable the module would be trivial enough. Is there anything which is blocking from doing this? I could provide the (one-line) PR for a start.
I'm eagerly waiting for support for this module and we'd only build custom images for this, which is a bit much overhead, but likely we must go into this to have it in stable in a timely manner?

Go ahead and post a PR to enable it in the AMD64 config. They only consideration is going to be - how does this affect initrd size.

thx, done (to commonconfig though). To my understanding, this is relevant for ARM, too. I only would be able to test on amd64. Please advise if I should restrict to amd64.

Hello @sfudeus, the alpha/beta/stable channels will contain the change - in a few days at most. Can you please verify that the fix works, in the meantime, using the direct links:
Alpha 4116.0.0, Beta 4081.1.0, Stable 3975.2.2
Pre-view images are available in https://bincache.flatcar-linux.net/images/amd64/$VERSION/

@ader1990 We tested stable today, looking good from our perspective. Shall I do the effort and run our servers against beta/alpha as well? Not sure if alpha would possibly fail for unrelated reasons.


How to retrieve build.parameters?

Not retrieved using propertyFilters.
2- Is it "properties" or "propertyFilters"? there is mismatch between syntax and parameter list in this doc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f225bc86-a0d2-78d7-c060-82abf1a65229
Version Independent ID: 7e1f2e49-2130-f15d-f11c-6db5638c5355
Content: Builds
Content Source: docs/integrate/previous-apis/build/builds.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

@vtbassmatt - since these docs are hand-written (i.e. not easily maintained at this point), one solution may be to reference the later/generated reference docs. You might also want to chat with @wnjenkin about a more general solution for pushing people to the newer docs (i.e. the current purple info message may not be sufficient).

This doc is owned by @vijayma

Hi @ahmadyo, Following up on this issue, it appears to be almost 6 months old now! The doc has been updated since then, however I'm unsure of what has been updated. Please let us know whether you feel it still needs an update, otherwise I'll be closing this issue. Thanks very much.

This bug is about "Builds" [https://docs.microsoft.com/en-us/azure/devops/integrate/previous-apis/build/builds?view=tfs-2017]
Simply compare syntax with pameters list; syntax has "[&propertyFilters={string}]" but list has "properties" instead.
How a good job you did! Let bug unanswered 6 month, and close it within 6 hours simply without reading it!
Nice.

Hi @ahmadyo , I got this notification so I wanted to swing by and offer some context. These APIs are for older versions of TFS, and as Will mentioned above, they were hand-written once upon a time and very expensive to maintain/update. We like to point people to our new REST API docs that are autogenerated, but we know they don't work for older versions.
That being said, we don't mind reviewing PRs for these docs if users find out they're incorrect. Did you test out this API call for us, did you find which one worked? That would be extremely helpful in this scenario. From the new Builds - List API, it looks like "properties" is probably correct, any chance you could confirm that?

First of all, I did not test it for you, I tried to use it, but it's not working.
Secondly, all prefer that customers use latest version, but sadly I can't update our TFS just for a bug and that is another project.


Create *.ricardo-inc.is-cool.dev.json

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] Your website is not hosting on the following due to SSL issues: Vercel, Netlify

Description

Link to Website

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

can you help me my dns is not workin


 As of v0.6.0, we're now shipping all binaries compiled with Go 1.5.1. The linux packages also bundle Go 1.5.1 to compile.
Obviously, our tests will run in about 1/3rd the time. We can also start supporting newer std lib features and code syntax that we couldn't with Go 1.3.
Any objections? This should only affect git lfs contributors and homebrew users. I think we can configure the git lfs recipe to require Go 1.5+ though.

:+1:

:+1:

\o/


ambiguous union discrimination when multiple models correspond to the input arguments

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Hello,
I'm building an app and stumbled on a not reliable behaviour of pydantic. Basically, when the input corresponds to multiple base model, the one that is going to be selected in the end will depend on unknown things. See the example below for more context.
Example Code
The following :
from pydantic import BaseModel

class SuperEnum(str, Enum):
    ENUM_1 = "ENUM_1"
    ENUM_2 = "ENUM_2"

class A(BaseModel):
    one: ONE_ENUM

class B(BaseModel):
    two: int
    three: str | None = None

class C(BaseModel):
    zero: A | B

will return
C(**{"zero": {"one": "ENUM_1"}}).zero
>>> A(one=<SuperEnum.ENUM_1: 'ENUM_1'>)
C(**{"zero": {"one": "ENUM_1", "two": 3}}).zero
>>> B(two=3, three=None)

but
from pydantic import BaseModel

class A(BaseModel):
    one: str  # difference here, now it is just a string instead of the enum

class B(BaseModel):
    two: int
    three: str | None = None

class C(BaseModel):
    zero: A | B

will return
C(**{"zero": {"one": "ENUM_1"}}).zero
>>> A(one='ENUM_1')
C(**{"zero": {"one": "ENUM_1", "two": 3}}).zero
>>> A(one='ENUM_1')

Python, Pydantic & OS Version
pydantic version: 2.6.4
        pydantic-core version: 2.16.3
          pydantic-core build: profile=release pgo=true
                 install path: /Users/datategy/Documents/o2_ml/.venv/lib/python3.10/site-packages/pydantic
               python version: 3.10.11 (v3.10.11:7d4cc5aa85, Apr  4 2023, 19:05:19) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]
                     platform: macOS-14.4.1-arm64-arm-64bit
             related packages: fastapi-0.110.0 typing_extensions-4.10.0 pydantic-settings-2.2.1
                       commit: unknown

@MarcBresson,
Thanks for your question. This is a consequence of pydantic's smart union matching logic, that tries to find the best match out of the possible union candidates. If you'd prefer to always match A when one is present, you can use union_mode='right_to_left' in the config for the zero field, which will ensure that the first match is the one returned.
Let me know if you have any other questions! :)


release 175 changes

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

local validation on PRs passed, so merging this PR. Will recheck validation after tags are created.


clojure.repl should be available everywhere

Currently, clojure.repl (and, with it, doc, source, and pst) are automatically loaded into the initial namespace when a REPL starts. However, they're not loaded into any other namespaces you switch to. This causes annoying errors when you forget you have to (use 'clojure.repl) before calling any of the above functions.

I'm adding quite a few more things in this vein to profiles.clj, as per this excellent article:
http://z.caudate.me/give-your-clojure-workflow-more-flow/

Resolved as a small part of edd3a9274b36021cad2bb3047bc1bff2f16c1f19. It's not possible to make the functions available everywhere without adding a prefix or putting them in a separate namespace (I tried for many, many hours, and got so far as hacking the ns macro and rebinding stderr to a custom class before giving up), so they are available in the . namespace.


Run a story end-to-end in Talk mode in Rasa x

Description of Problem:
I would like to run a story end-to-end in either Talk mode or Interactive Learning. I am currently testing out my bot and some of the features I want to test for are at the very end of the story. I would like to run a story or part of a story end-to-end.
Overview of the Solution:

Select a story or part of the story
Show a button which says "run selected part as a new/independent story".
It will run the selected part again, with scope for continuing the conversation after that.

Examples (if relevant):
Blockers (if relevant):
Definition of Done:

Thanks for submitting this feature request, we'll discuss this and get back to you

Thank you for raising this issue about Rasa X. We decided to stop supporting the Community Edition (free version) of ‘Rasa X’ (see more info here: https://rasa.com/blog/rasa-x-community-edition-changes/). That’s why we’ve closed your issue. We suggest that Rasa Enterprise customers raise the issue with our customer support team if they haven’t done so already.


WIP: Implement constructors directly from datasets for reference objects

In the SR module there are a number of classes that represent various types of references to source images:

highdicom.sr.content.ReferencedSegment
highdicom.sr.content.ReferencedSegmentationFrame
highdicom.sr.content.SourceImageForMeasurement
highdicom.sr.content.SourceImageForRegion
highdicom.sr.content.SourceImageForSegmentation
highdicom.sr.content.SourceSeriesForSegmentation

The constructors for these classes require that the user manually pass the relevant UIDs. This is by no means a large burden but is a little low-level and increases the probability of a mistake.
I propose implementing alternative constructors as class methods called from_dataset that allow constructing objects by simply passing the relevant dataset and have highdicom take care of the rest.
For example
import pydicom
from highdicom.sr.content import SourceImageForMeasurement

ct_dataset = pydicom.dcmread(...)

# Currently a source image object must be constructed like this
source_image = SourceImageForMeasurement(
    referenced_sop_class_uid=ct_dataset.SOPClassUID,
    referenced_sop_instance_uid=ct_dataset.SOPInstanceUID
)

# Under the proposal, it could also alternatively be constructed like this
source_image = SourceImageForMeasurement.from_dataset(ct_dataset)

I personally think this is a bit higher level and a nice reduction in boilerplate.
For now, I have just implemented this for the SourceImageForMeasurement class. If you like the idea, I will implement for the other classes and write tests.

@CPBridge I like the idea!
What do you think about calling the classmethod from_source() instead of from_dataset()? The constructor of these classes will also create a Dataset, therefore this could get confusing.

Cool, I'll get to work on the rest then. I agree that dataset is a little confusing as all these objects are datasets. I could get behind from_source(). Or maybe the slightly more verbose from_source_dataset(), since source is also a bit vague?

@hackermd this is now implemented and ready for review. The referenced segment and referenced segmentation frame versions were more complex than I thought since there are a few different ways that source information may appear in a segmentation dataset. But this also means it will be more useful. Hopefully I've covered most eventualities.

@hackermd this is awaiting rewiew

I have addressed most comments. Will look into checks on the validity of source images (as suggested in the comments) later.

I have addressed most comments.

Could you kindly respond to the comments with Addressed with #COMMIT_HASH. This will make it easier for me to keep track of changes and determine whether a comment can be resolved.

Didn't I do that?

Didn't I do that?

You did indeed. Excellent! Sorry I didn't notice. The comments were already resolved and hidden. Please keep comments open and let me close them. That makes it easier for me to keep track of changes.

I have addressed all comments and also added:

Checks that ensure that referenced frame numbers are valid for the specific dataset passed (previously this was only done for frame numbers that are always incorrect, i.e. < 1)
Tests for the checks on dataset appropriateness and frame number correctness


feat(#8): char is LOWERCASE_LETTER

closes #8

PR-Codex overview
This PR focuses on modifications to the parsing rules in src/program.pest and src/parser/fsl_parser.rs, specifically adjusting the definitions for login and char, as well as updating test cases to reflect new valid and invalid inputs.
Detailed summary

In src/program.pest:

Changed -login to +login definition.
Updated -char to +char to only allow LOWERCASE_LETTER.

In src/parser/fsl_parser.rs:

Updated test cases to change valid input from "foo123" to "foo" and added invalid inputs "X" and "XYZ".

Removed comments regarding prohibiting upper-case letters in references.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 42min)


Error compiling JavaScript files in Angular 5 CLI project

Versions
  Angular CLI: 1.6.2
    Node: 6.10.0
    OS: darwin x64
    Angular: 5.1.2
    ... animations, common, compiler, compiler-cli, core, forms
    ... http, language-service, platform-browser
    ... platform-browser-dynamic, router

    @angular/cli: 1.6.2
    @angular-devkit/build-optimizer: 0.0.36
    @angular-devkit/core: 0.0.22
    @angular-devkit/schematics: 0.0.42
    @ngtools/json-schema: 1.1.0
    @ngtools/webpack: 1.9.2
    @schematics/angular: 0.1.11
    @schematics/schematics: 0.0.11
    typescript: 2.4.2
    webpack: 3.10.0

Repro steps

Create an empty CLI (1.6.2) project (ng new test2). The project runs fine.
Modify tsconfig.json to include the line allowJs": true, to compile/bundle Javascript files
Create a simple Javascript file (eg test.js with content i=1;) in the app folder.
Build fails in Angular 5 (ng build) with the error below.

test2.zip
Observed behavior
Build fails with the error below:
"ERROR in error TS5055: Cannot write file
'/Users/user/Documents/workspace/test2/src/app/test.js' because it would
overwrite input file.  Adding a tsconfig.json file will help organize
projects that contain both TypeScript and JavaScript files. Learn more at
https://aka.ms/tsconfig."

Desired behavior
The js file is copied to the out-tsc directory and included in the output bundle.
Mention any other details that might be useful (optional)
In Angular 4 JS file is compiled to the output directory specified in the outDir parameter and included in the final bundle.

Same behavior observed.

There is a work in progress PR for this bug in https://github.com/angular/angular-cli/pull/8930.

https://github.com/angular/angular-cli/pull/8930 was merged and should be out in the 1.7 release.

Thanks @filipesilva!

@filipesilva  Many thanks.  Working fine now.


Updated flags, and fixed minor syntax errors.

Short Description:
Some improvements to the README.md for better readability,
Changes:

Updated the falgs documentation to be more readable, greatly inspired by gulp (https://github.com/gulpjs/gulp-cli/blob/master/README.md#flags).
Fixed text that were rendered as code due to bad indentation, and properly marked the commands as code.

@OpenPoGo/maintainers

Please use Markdown tables instead of HTML tables.

Actually, we should also update the "How to use the map" section as we no longer use SimpleHTTPServer.

👍 since everything otherwise looks good and I need to sleep

Good night then! :) Updated everything!

:+1: looks good!

:+1: (for pull approve)

:+1: Looks good!

:+1: Looks good!


Added Que.after_fork and a rake task for forking workers

Still a work in progress. No tests yet. Not sure if all this code should go in a rake task.  Probably need to modify the logging.
The after_fork in my test app looks like:
Que.after_fork do
  DB.disconnect
  Que.connection = DB
end

Hi @chanks ... We're in need of forking Que workers, and this looks like it fits the bill. I found the commit https://github.com/chanks/que/commit/703e5b68e3b73ddf10c0ab6d28ede637113ce1ba where you removed it for lack us use. Were there any actual issues with it (lack of tests I understand was one)?
@joevandyk You migrated off it in production I understand. Can you tell us if there were any reasons?
Thanks both - we'll be looking at reimplementing this ourselves soon...

Well, it depends on what you mean by forking workers. If you want to start a process, fork it a few times, and then start working jobs in the children, that's not really an issue, people do that already.
If you want to be continually forking the process so you can run each job in its own fork, though, you're going to run into problems. The issue was that if the parent process has any PG connections going when it forks, the child processes hang onto them. Then, when the child process exits, they close down those connections, which disrupts the parent. I'm not sure that there's a way around it, it seems to just be how Ruby works. See #22 for more discussion.

Yes, this would be to run each job in its own fork (a la Resque). It goes a long way to negating most memory leaks (current or future) in our, or other gems', code.
Much like Resque, an after_fork hook to reconnect to the DB seems to work fine.
I'll work with the code from the past commit, and see what happens. Thanks!


(fix)[group-commit] Fix some group commit case

Proposed changes
Fix some group commit problems found by https://github.com/apache/doris/pull/26856
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Version 0.7

Reference Issues/PRs
#88 #116 #121
What does this implement/fix? Explain your changes.
Version 0.7
Any other comments?

@sadrasabouri Hi
Please complete this review until Wednesday - 2022-05-04 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge

Codecov Report

Merging #128 (9d47fe5) into master (2c4a367) will increase coverage by 1.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #128      +/-   ##
===========================================
+ Coverage   98.96%   100.00%   +1.05%
===========================================
  Files           4         4
  Lines         381       412      +31
  Branches       58        64       +6
===========================================
+ Hits          377       412      +35
+ Misses          2         0       -2
+ Partials        2         0       -2

Impacted Files
Coverage Δ

samila/functions.py
100.00% <100.00%> (+0.79%)
:arrow_up:

samila/genimage.py
100.00% <100.00%> (+2.64%)
:arrow_up:

samila/params.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4a367...9d47fe5. Read the comment docs.


Fix scope of vesting stats table

https://github.com/GolosChain/golos.contracts/blob/9d37f6248e95b3e6cb043bc044afff3f6bafb1e5/golos.vesting/golos.vesting.cpp#L61-L62
cyber.token stats table uses symbol as scope, this allows to simplify (duplicating) code and use singleton to access stats object.
We have self in that scope, this was necessary to iterate parameters inside vesting::timeoutconv() (with #547 where will be no dependency from parameters, so nested loop in vesting::timeoutconv() can be removed).
Propose to use symbol as scope to simplify vesting code and unify it with cyber.token. this also increases performance slightly

Note: looks like in scope is useful in current implementation. Doublecheck before implement.


rGuiIcons header export

Hi,
I'm not sure where to put this issue since I didn't find rGuiIcons github repo.
There is noted in the source code of raygui that rGuiIcons can generate a custom ricons header file that can be included by raygui.
https://github.com/raysan5/raygui/blob/master/src/raygui.h#L531
But I can't find other exports than .rgi and .png. Where can I generate the header file?

@ProkopRandacek Actually the .h export feature is only available on version ONE (the paid one)... but I changed that for next release, hopefully by the end of this month.


kilosort, klusta, spykingcircus sorting extractors + writeBinaryDatFormat function

implemented extractors and tests for:

klusta
kilosort
spykingcircus

in the tools the writeBinaryDatFormat(recording, save_path, transpose=False, dtype='float32') writes a dat file from a recording extractor

Looks good! Do you think the binary writer should be encapsulated in a recording extractor called BinaryRecordingExtractror?

I think that a function is enough, as the binary format has no info on sampling frequency for example,
so it would be useless on its own!


Update renovate

This PR contains the following updates:

Package
Type
Update
Change

alpine
final
minor
3.17 -> 3.19

alpine
final
minor
3.16.2 -> 3.19.1

alpine
final
minor
3.18.5 -> 3.19.1

anchore/sbom-action
action
minor
v0.12.0 -> v0.15.8

cloud.google.com/go/binaryauthorization
require
minor
v1.6.1 -> v1.8.1

cloud.google.com/go/container
require
minor
v1.24.0 -> v1.32.0

cloud.google.com/go/serviceusage
require
minor
v1.5.0 -> v1.8.4

github.com/aquasecurity/trivy
require
minor
v0.35.0 -> v0.49.1

github.com/aws/aws-sdk-go-v2/config
require
minor
v1.18.3 -> v1.27.4

github.com/aws/aws-sdk-go-v2/service/eks
require
minor
v1.22.1 -> v1.40.1

github.com/aws/smithy-go
require
minor
v1.18.1 -> v1.20.1

github.com/bombsimon/logrusr/v4
require
minor
v4.0.0 -> v4.1.0

github.com/castai/image-analyzer
require
minor
v0.2.0 -> v0.3.0

github.com/cenkalti/backoff/v4
require
minor
v4.1.3 -> v4.2.1

github.com/containerd/containerd
replace
minor
v1.6.1-0.20220706215228-681aaf68b7dc -> v1.7.13

github.com/containerd/containerd
require
patch
v1.7.8 -> v1.7.13

github.com/fatih/color
require
minor
v1.13.0 -> v1.16.0

github.com/go-resty/resty/v2
require
minor
v2.7.0 -> v2.11.0

github.com/golang/glog
require
minor
v1.1.2 -> v1.2.0

github.com/google/go-containerregistry
require
minor
v0.12.0 -> v0.19.0

github.com/google/uuid
require
minor
v1.3.1 -> v1.6.0

github.com/googleapis/gax-go/v2
require
minor
v2.11.0 -> v2.12.2

github.com/gorilla/mux
require
patch
v1.8.0 -> v1.8.1

github.com/hashicorp/golang-lru
require
minor
v0.5.4 -> v0.6.0

github.com/magiconair/properties
require
patch
v1.8.6 -> v1.8.7

github.com/open-policy-agent/cert-controller
require
minor
v0.7.0 -> v0.10.1

github.com/prometheus/client_golang
require
minor
v1.14.0 -> v1.19.0

github.com/samber/lo
require
minor
v1.33.0 -> v1.39.0

github.com/spf13/cobra
require
minor
v1.6.1 -> v1.8.0

github.com/spf13/viper
require
minor
v1.13.0 -> v1.18.2

golang.org/x/oauth2
require
minor
v0.11.0 -> v0.17.0

golang.stackrox.io/kube-linter
require
minor
v0.4.1-0.20221021125313-bd11843210d1 -> v0.6.8

golangci/golangci-lint-action
action
patch
v3.7.0 -> v3.7.1

google.golang.org/api
require
minor
v0.126.0 -> v0.167.0

helm/kind-action
action
minor
v1.4.0 -> v1.9.0

k8s.io/api
require
minor
v0.26.11 -> v0.29.2

k8s.io/apimachinery
require
minor
v0.27.1 -> v0.29.2

k8s.io/client-go
require
minor
v0.26.11 -> v0.29.2

k8s.io/klog/v2
require
minor
v2.90.1 -> v2.120.1

oras.land/oras-go
replace
minor
v1.1.1 -> v1.2.5

sigs.k8s.io/controller-runtime
require
minor
v0.14.2 -> v0.17.2

[!WARNING]
Some dependencies could not be looked up. Check the warning logs for more information.

Release Notes

anchore/sbom-action (anchore/sbom-action)
v0.15.8
Compare Source
Changes in v0.15.8

Update Syft to v0.103.1 (#441) [anchore-actions-token-generator]

v0.15.7
Compare Source
Changes in v0.15.7

chore: migrate action to use node v20.11.0 (Iron) FROM node v16.x.x (#440) [spiffcs]

v0.15.6
Compare Source
Changes in v0.15.6

chore(deps): update Syft to v0.102.0 (#438) [anchore-actions-token-generator]

v0.15.5
Compare Source
Changes in v0.15.5

chore(deps): update Syft to v0.101.1 (#437) [anchore-actions-token-generator]

v0.15.4
Compare Source
Changes in v0.15.4

chore(deps): update Syft to v0.101.0 (#436) [anchore-actions-token-generator]

v0.15.3
Compare Source
Changes in v0.15.3

chore(deps): update Syft to v0.100.0 (#435) [anchore-actions-token-generator]

v0.15.2
Compare Source
Changes in v0.15.2

chore(deps): update Syft to v0.99.0 (#432) [anchore-actions-token-generator]
chore: fix github-script invocation in update-snapshots workflow (#433) [willmurphyscode]

v0.15.1
Compare Source
Changes in v0.15.1

chore(deps): update Syft to v0.98.0 (#431) [anchore-actions-token-generator]
Add config input (#430) [eyakubovich]
chore: pin and upgrade gh actions (#429) [willmurphyscode]

v0.15.0
Compare Source
Changes in v0.14.4
Breaking Changes

Previously, running on Windows required WSL. Now, running on Windows expects to be run on native windows (#426) [willmurphyscode].

Other Changes

pin and upgrade actions/checkout (#428) [willmurphyscode]
chore(deps): update Syft to v0.97.1 (#427) [anchore-actions-token-generator]
add oss community board auto-add workflow (#421) [wagoodman]

v0.14.3
Compare Source
Changes in v0.14.3

update Syft to v0.84.0 (#418) [anchore-actions-token-generator]

v0.14.2
Compare Source
Changes in v0.14.2

Update Syft to v0.80.0 (#415)
Make sure all invalid artifact name characters are replaced #396 (#417) [lts-po]
Ensure SBOM is copied to output-file (#411) [gszr]

v0.14.1
Compare Source
Changes in v0.14.1

chore(deps): update Syft to v0.76.0 (#403) [anchore-actions-token-generator]

v0.13.4
Compare Source
Changes in v0.13.4

Added support of workflow artifact's retention policy (#398) [ViacheslavKudinov]
Use the correct SHA for dependency snapshots from pull requests (#401) [juxtin]
Update Syft to v0.75.0 (#394) [anchore-actions-token-generator]

v0.13.3
Compare Source
Changes in v0.13.3

Update Syft to v0.68.1 (#391) [anchore-actions-token-generator]

v0.13.2
Compare Source
Changes in v0.13.2

Update Syft to v0.68.0 (#387) [anchore-actions-token-generator]

v0.13.1
Compare Source
Changes in v0.13.1

File input not being passed properly to Syft invocation (#385) [kzantow]
Update Syft to v0.60.3 (#386) [anchore-actions-token-generator]

v0.13.0
Compare Source
Changes in v0.13.0

Allow type "file:..." to enable creation of SBOMs from tar and other package formats (#357) [malt3]
Update Syft to v0.59.0 (#371) [anchore-actions-token-generator]
Update dependencies and node version (#372) [kzantow]

aquasecurity/trivy (github.com/aquasecurity/trivy)
v0.49.1
Compare Source
Changelog

6ccc0a5 fix: check unescaped BomRef when matching PkgIdentifier (#6025)
458c5d9 docs: Fix broken link to "pronunciation" (#6057)
5c0ff6d chore(deps): bump actions/upload-artifact from 3 to 4 (#6047)
e2bd7f7 chore(deps): bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#6042)
f95fbcb chore(deps): bump k8s.io/api from 0.29.0 to 0.29.1 (#6043)
7651bf5 ci: reduce root-reserve-mb size for maximize-build-space (#6064)
fc20dfd chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.48.1 (#6041)
3bd80e7 chore(deps): bump github.com/open-policy-agent/opa from 0.60.0 to 0.61.0 (#6039)
2900a21 fix: fix cursor usage in Redis Clear function (#6056)
85cb9a7 chore(deps): bump github.com/go-openapi/runtime from 0.26.0 to 0.27.1 (#6037)
4e962c0 fix(nodejs): add local packages support for pnpm-lock.yaml files (#6034)
aa48a7b chore(deps): bump sigstore/cosign-installer from 3.3.0 to 3.4.0 (#6046)
8aabbea chore(deps): bump github.com/go-openapi/strfmt from 0.21.7 to 0.22.0 (#6044)
ec02a65 chore(deps): bump actions/cache from 3.3.2 to 4.0.0 (#6048)
27d35ba test: fix flaky TestDockerEngine (#6054)
c3a66da chore(deps): bump github.com/google/go-containerregistry from 0.17.0 to 0.19.0 (#6040)
2000fe2 chore(deps): bump easimon/maximize-build-space from 9 to 10 (#6049)
2be6421 chore(deps): bump alpine from 3.19.0 to 3.19.1 (#6051)
41c0ef6 chore(deps): bump github.com/moby/buildkit from 0.11.6 to 0.12.5 (#6028)

v0.49.0
Compare Source
⚡Release highlights and summary⚡
👉 https://github.com/aquasecurity/trivy/discussions/6033
Changelog

729a051 fix(java): recursive check all nested depManagements with import scope for pom.xml files (#5982)
884745b chore(deps): bump github.com/opencontainers/runc from 1.1.5 to 1.1.12 (#6029)
59e5433 fix(cli): inconsistent behavior across CLI flags, environment variables, and config files (#5843)
5924c02 feat(rust): Support workspace.members parsing for Cargo.toml analysis (#5285)
4df9363 docs: add note about Bun (#6001)
70dd572 fix(report): use AWS_REGION env for secrets in asff template (#6011)
13f797f fix: check returned error before deferring f.Close() (#6007)
adfde63 feat(misconf): add support of buildkit instructions when building dockerfile from image config (#5990)
e2eb70e feat(vuln): enable --vex for all targets (#5992)
f9da021 docs: update link to data sources (#6000)
b4b90cf feat(java): add support for line numbers for pom.xml files (#5991)
fb36c4e refactor(sbom): use new metadata.tools struct for CycloneDX (#5981)
f6be42b docs: Update troubleshooting guide with image not found error (#5983)
bb6caea style: update band logos (#5968)
189a46a chore(deps): Update misconfig deps (#5956)
91a2547 docs: update cosign tutorial and commands, update kyverno policy (#5929)
a96f66f docs: update command to scan go binary (#5969)
2212d14 fix: handle non-parsable images names (#5965)
7cad04b chore(deps): bump aquaproj/aqua-installer from 2.1.2 to 2.2.0 (#5693)
fbc1a83 fix(amazon): save system files for pkgs containing amzn in src (#5951)
260aa28 fix(alpine): Add EOL support for alpine 3.19. (#5938)
2c9d7c6 feat: allow end-users to adjust K8S client QPS and burst (#5910)
ffe2ca7 chore(deps): bump go-ebs-file (#5934)
f90d4ee fix(nodejs): find licenses for packages with slash (#5836)
c75143f fix(sbom): use group field for pom.xml and nodejs files for CycloneDX reports (#5922)
a3fac90 fix: ignore no init containers (#5939)
b1b4734 docs: Fix documentation of ecosystem (#5940)
a2b6549 docs(misconf): multiple ignores in comment (#5926)
ae134a9 fix(secret): find aws secrets ending with a comma or dot (#5921)
c8c55fe chore(deps): bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.90 to 1.15.11 (#5885)
4d2e785 docs: ✨ Updated ecosystem docs with reference to new community app (#5918)
7895657 fix(java): don't remove excluded deps from upper pom's (#5838)
37e7e3e fix(java): check if a version exists when determining GAV by file name for jar files (#5630)
d0c81e2 feat(vex): add PURL matching for CSAF VEX (#5890)
958e1f1 fix(secret): AWS Secret Access Key must include only secrets with aws text. (#5901)
56c4e24 revert(report): don't escape new line characters for sarif format (#5897)
92d9b3d docs: improve filter by rego (#5402)
a626cdf chore(deps): bump github.com/cloudflare/circl from 1.3.6 to 1.3.7 (#5892)
47b6c28 docs: add_scan2html_to_trivy_ecosystem (#5875)
0ebb6c4 fix(vm): update ext4-filesystem fix reading groupdescriptor in 32bit mode (#5888)
c47ed0d feat(vex): Add support for CSAF format (#5535)
2cdd65d chore(deps): bump github.com/aws/aws-sdk-go-v2/service/sts from 1.26.2 to 1.26.7 (#5880)
cba67d1 chore(deps): bump actions/setup-go from 4 to 5 (#5845)
d990e70 chore(deps): bump actions/stale from 8 to 9 (#5846)
c72dfbf chore(deps): bump github.com/open-policy-agent/opa from 0.58.0 to 0.60.0 (#5853)
1218984 chore(deps): bump sigstore/cosign-installer from 3.2.0 to 3.3.0 (#5847)
682210a chore(deps): bump modernc.org/sqlite from 1.23.1 to 1.28.0 (#5854)
e1a60cc chore(deps): bump alpine from 3.18.5 to 3.19.0 (#5849)
b508414 chore(deps): bump actions/setup-python from 4 to 5 (#5848)
df3e90a feat(python): parse licenses from dist-info folder (#4724)
fa2e883 chore(deps): bump github.com/secure-systems-lab/go-securesystemslib from 0.7.0 to 0.8.0 (#5852)
30eff9c feat(nodejs): add yarn alias support (#5818)
013df4c chore(deps): bump github.com/samber/lo from 1.38.1 to 1.39.0 (#5850)
b1489f3 chore(deps): bump github.com/hashicorp/go-getter from 1.7.2 to 1.7.3 (#5856)
7f2e422 chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#5855)
da597c4 refactor: propagate time through context values (#5858)
1607eee refactor: move PkgRef under PkgIdentifier (#5831)
b3d516e fix(cyclonedx): fix unmarshal for licenses (#5828)
c17b660 chore(deps): bump github.com/go-git/go-git/v5 from 5.10.1 to 5.11.0 (#5830)
1f0d629 feat(vuln): include pkg identifier on detected vulnerabilities (#5439)

v0.48.3
Compare Source
Changelog

eac7513 chore(deps): bump github.com/cloudflare/circl from 1.3.6 to 1.3.7 (#5892)
d866b71 chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#5855)
34ba96e chore(deps): bump github.com/go-git/go-git/v5 from 5.10.1 to 5.11.0 (#5830)

v0.48.2
Compare Source
Changelog

4cdff0e chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ec2 from v1.116.0 to v1.134.0 (#5822)
be969d4 chore(deps): bump github.com/containerd/containerd from 1.7.7 to 1.7.11 (#5809)
81748f5 chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 (#5805)

v0.48.1
Compare Source
Changelog

ba825b2 chore(deps): bump trivy-iac to v0.7.1 (#5797)
abf227e fix(bitnami): use a different comparer for detecting vulnerabilities (#5633)
df49ea4 refactor(sbom): disable html escaping for CycloneDX (#5764)
f25e2df refactor(purl): use pub from package-url (#5784)
b5e3b77 docs(python): add note to using pip freeze for compatible releases (#5760)
6cc00c2 fix(report): use OS information for OS packages purl in github template (#5783)
c317fe8 fix(report): fix error if miconfigs are empty (#5782)
9b4bced refactor(vuln): don't remove VendorSeverity in JSON report (#5761)
be5a550 fix(report): don't mark misconfig passed tests as failed in junit.tpl (#5767)
01edbda docs(k8s): replace --scanners config with --scanners misconfig in docs (#5746)
eb97419 fix(report): update Gitlab template (#5721)
be1c554 feat(secret): add support of GitHub fine-grained tokens (#5740)
a5342da fix(misconf): add an image misconf to result (#5731)
108a5b0 feat(secret): added support of Docker registry credentials (#5720)
6080e24 chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.45 to 1.25.11 (#5717)
e27ec32 chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ecr from 1.21.0 to 1.24.1 (#5701)

v0.48.0
Compare Source
⚡Release highlights and summary⚡
👉 https://github.com/aquasecurity/trivy/discussions/5724
Changelog

f2aa9bf chore(deps): bump sigstore/cosign-installer from 4a86152 to 1fc5bd3 (#5696)
6d7e2f8 chore(deps): bump helm/chart-testing-action from 2.4.0 to 2.6.1 (#5694)
0ff5f96 feat: filter k8s core components vuln results (#5713)
a54d1e9 feat(vuln): remove duplicates in Fixed Version (#5596)
99c04c4 feat(report): output plugin (#4863)
70078b9 chore(deps): bump alpine from 3.18.4 to 3.18.5 (#5700)
49e83a6 chore(deps): bump github.com/google/go-containerregistry from 0.16.1 to 0.17.0 (#5704)
af32cb3 chore(deps): bump github.com/go-git/go-git/v5 from 5.8.1 to 5.10.1 (#5699)
1766271 chore(deps): bump actions/github-script from 6 to 7 (#5697)
7ee8547 chore(deps): bump easimon/maximize-build-space from 8 to 9 (#5695)
654147f docs: typo in modules.md (#5712)
2569575 feat: Add flag to configure node-collector image ref (#5710)
c061009 chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azcore from 1.7.1 to 1.9.0 (#5702)
aedbd85 chore(deps): bump github.com/alicebob/miniredis/v2 from 2.30.4 to 2.31.0 (#5698)
e018b9c chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity from 1.3.1 to 1.4.0 (#5706)
b5874e3 feat(misconf): Add --misconfig-scanners option (#5670)
075d8f6 chore: bump Go to 1.21 (#5662)
16b757d feat: Packagesprops support (#5605)
372efc9 chore(deps): Bump up trivy misconf deps (#5656)
edad5f6 docs: update adopters discussion template (#5632)
ed9d340 docs: terraform tutorial links updated to point to correct loc (#5661)
8ff574e fix(secret): add sec and space to secret prefix for aws-secret-access-key (#5647)
ad977a4 fix(nodejs): support protocols for dependency section in yarn.lock files (#5612)
b1dc60b fix(secret): exclude upper case before secret for alibaba-access-key-id (#5618)
65351d4 docs: Update Arch Linux package URL in installation.md (#5619)
c866f1c chore: add prefix to image errors (#5601)
ed0022b docs(vuln): fix link anchor (#5606)
3c81727 docs: Add Dagger integration section and cleanup Ecosystem CICD docs page (#5608)
2145464 fix: k8s friendly error messages kbom non cluster scans (#5594)
44d0b28 feat: set InstalledFiles for DEB and RPM packages (#5488)
ae4bcf6 fix(report): use time.Time for CreatedAt (#5598)
b6fafa0 test: retry containerd initialization (#5597)
1336223 feat(misconf): Expose misconf engine debug logs with --debug option (#5550)
7105186 test: mock VM walker (#5589)
d9d7f3f chore: bump node-collector v0.0.9 (#5591)
e3c28f8 feat(misconf): Add support for --cf-params for CFT (#5507)
ac0e327 feat(flag): replace '--slow' with '--parallel' (#5572)
5372067 fix(report): add escaping for Sarif format (#5568)
a389529 chore: show a deprecation notice for --scanners config (#5587)
f4dd062 feat(report): Add CreatedAt to the JSON report. (#5542) (#5549)
d005f5a test: mock RPM DB (#5567)
a96ec35 feat: add aliases to '--scanners' (#5558)
950e431 refactor: reintroduce output writer (#5564)
2310f0d chore(deps): bump google.golang.org/grpc from 1.58.2 to 1.58.3 (#5543)
04b93e9 chore: not load plugins for auto-generating docs (#5569)
cccaa15 chore: sort supported AWS services (#5570)
3891e3d fix: no schedule toleration (#5562)
138feb0 fix(cli): set correct scanners for k8s target (#5561)
cb241a8 fix(sbom): add FilesAnalyzed and PackageVerificationCode fields for SPDX (#5533)
e7f6a5c refactor(misconf): Update refactored dependencies (#5245)
2f5afa5 feat(secret): add built-in rule for JWT tokens (#5480)
91fc8da fix: trivy k8s parse ecr image with arn (#5537)
05df244 fix: fail k8s resource scanning (#5529)
a1b4744 refactor(misconf): don't remove Highlighted in json format (#5531)
7712f8f docs(k8s): fix link in kubernetes.md (#5524)
043fbfc docs(k8s): fix whitespace in list syntax (#5525)

v0.47.0
Compare Source
⚡Release highlights and summary⚡
👉 https://github.com/aquasecurity/trivy/discussions/5520
Changelog

d6df5fb docs: add info that license scanning supports file-patterns flag (#5484)
156d4cc docs: add Zora integration into Ecosystem session (#5490)
772d1d0 fix(sbom): Use UUID as BomRef for packages with empty purl (#5448)
df47073 ci: use maximize build space for K8s tests (#5387)
fed4710 fix: correct error mismatch causing race in fast walks (#5516)
46f1b9e docs: k8s vulnerability scanning (#5515)
fdb3a15 chore(deps): bump github.com/aws/aws-sdk-go-v2/service/sts from 1.23.2 to 1.25.0 (#5506)
d0d956f chore(deps): bump github.com/owenrumney/go-sarif/v2 from 2.2.2 to 2.3.0 (#5493)
68b0797 docs: remove glad for java datasources (#5508)
474167c chore(deps): bump github.com/testcontainers/testcontainers-go/modules/localstack from 0.21.0 to 0.26.0 (#5475)
7299867 chore: remove unused logger attribute in amazon detector (#5476)
8656bd9 fix: correct error mismatch causing race in fast walks (#5482)
2e10cd2 chore(deps): bump goreleaser/goreleaser-action from 4 to 5 (#5502)
13df746 chore(deps): bump docker/build-push-action from 4 to 5 (#5500)
b0141cf chore(deps): bump github.com/package-url/packageurl-go from 0.1.2-0.20230812223828-f8bb31c1f10b to 0.1.2 (#5491)
520830b fix(server): add licenses to BlobInfo message (#5382)
9a6e125 chore(deps): bump actions/checkout from 4.1.0 to 4.1.1 (#5501)
6e59272 chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ecr from 1.17.18 to 1.21.0 (#5497)
f3de7bc feat: scan vulns on k8s core component apps (#5418)
e2fb3dd fix(java): fix infinite loop when relativePath field points to pom.xml being scanned (#5470)
3e833be chore(deps): bump github.com/docker/docker from 24.0.5+incompatible to 24.0.7+incompatible (#5472)
ca50b77 fix(sbom): save digests for package/application when scanning SBOM files (#5432)
048150d docs: fix the broken link (#5454)
013d901 docs: fix error when installing PyYAML for gh pages (#5462)
26b4959 fix(java): download java-db once (#5442)
57fa701 chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 (#5447)
53c9a7d docs(misconf): Update --tf-exclude-downloaded-modules description (#5419)
01c98d1 feat(misconf): Support --ignore-policy in config scans (#5359)
05b3c86 docs(misconf): fix broken table for Use container image section (#5425)
1a15a3a feat(dart): add graph support (#5374)
f2a12f5 refactor: define a new struct for scan targets (#5397)
6040d9f fix(sbom): add missed primaryURL and source severity for CycloneDX (#5399)
e5317c7 fix: correct invalid MD5 hashes for rpms ending with one or more zero bytes (#5393)
9fba79f chore(deps): move to aws-sdk-go-v2 (#5381)
00f2059 docs: remove --scanners none (#5384)
57a1022 docs: Update container_image.md #5182 (#5193)
5b2b4ea feat(report): Add InstalledFiles field to Package (#4706)

v0.46.1
Compare Source
Changelog

27a3e55 fix(java): download java-db once (#5442)
d223732 chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 (#5447)

v0.46.0
Compare Source
⚡Release highlights and summary⚡
👉 https://github.com/aquasecurity/trivy/discussions/5377
Changelog

cbbd1ce feat(k8s): add support for vulnerability detection (#5268)
24a0d92 fix(python): override BOM in requirements.txt files (#5375)
0c3e2f0 docs: add kbom documentation (#5363)
6c12f04 test: use maximize build space for VM tests (#5362)
c413422 chore(deps): bump golang.org/x/net from 0.15.0 to 0.17.0 (#5365)
20ab703 fix(report): add escaping quotes in misconfig Title for asff template (#5351)
91841f5 ci: add workflow to check Go versions of dependencies (#5340)
57ba05c chore(deps): Upgrade defsec to v0.93.1 (#5348)
fef3ed4 chore(deps): bump alpine from 3.18.3 to 3.18.4 (#5300)
ced54ac fix: Report error when os.CreateTemp fails (to be consistent with other uses) (#5342)
2798df9 fix: add config files to FS for post-analyzers (#5333)
af485b3 fix: fix MIME warnings after updating to Go 1.20 (#5336)
008babf build: fix a compile error with Go 1.21 (#5339)
00d9c46 feat: added Metadata into the k8s resource's scan report (#5322)
03b6787 ci: check only PR's in actions/stale (#5337)
e6d5889 chore: update adopters template (#5330)
74dbd8a ci: do not trigger tests on the push event (#5313)
393bfdc fix(sbom): use PURL or Group and Name in case of Java  (#5154)
76eb8a5 docs: add buildkite repository to ecosystem page (#5316)
6c74ee1 chore(deps): bump docker/setup-qemu-action from 2 to 3 (#5290)
6119878 chore(deps): bump docker/setup-buildx-action from 2 to 3 (#5292)
a346587 chore(deps): bump actions/cache from 3.3.1 to 3.3.2 (#5293)
7e613cc chore(deps): bump github.com/google/uuid f

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: go.sum
Command failed: go get -d -t ./...
go: github.com/castai/kvisor/cmd/kvisor/imgcollector/collector imports
	github.com/castai/image-analyzer/image imports
	github.com/aquasecurity/trivy/pkg/fanal/image/token: cannot find module providing package github.com/aquasecurity/trivy/pkg/fanal/image/token
go: warning<EMAIL_ADDRESS>retracted by module author: v3.9.0 is the only tag in openshift/api and it was created before go.mod was
go: to switch to the latest unretracted version, run:
	go get github.com/openshift/api@latest


macos-latest-large gets resolved to macOS 13 instead of macOS 12

Description
When I use runs-on: macos-latest-large it gets resolved to a runner with macOS 13 (13.6.3), but according to this docs it supposed to be macOS 12.
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[X] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[X] macOS 12
[X] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
20240114.1
Is it regression?
With all the image renames it is hard to say
Expected behavior
macos-latest-large gets resolved to macOS 12 (per documentation)
Actual behavior
macos-latest-large gets resolved to macOS 13
Repro steps

use runs-on: macos-latest-large
see the "Set up job" -> "Operating System"

Hey! do you have a workflow run url? (no matter public or not?)

Hey! do you have a workflow run url? (no matter public or not?)

Hi, @mikhailkoliada! Sure, here is a link

Hello @Vyazovoy!
Unfortunately, we do not have access to the repository you provided.

macos-latest-large indeed points at macos-13.
cc @Steve-Glass for updates on documentation.

Documentation update has been merged as I see, thanks! Nice catch!

@mikhailkoliada, I see the corrected docs on site but it would be good to update README of this repo as well.


Missing test file

Tests are looking for a file called invalidfile.pdf which is missing:
    it('should add options', function(){
      var ptext = new pdftotext(__dirname + '/pdfs/invalidfile.pdf');

@lirantal Thats fine and error handler should be invoked when error occurs. May be you can describe this test better.

that invalidfile.pdf doesn't exist at all so obviously anything that test tries to do will fail. So either that file is accidentally missing, or if we deliberately want to fail the test on missing file then I think the test should be corrected as well as it's name which doesn't suggest it.

It's deliberately missing but totally agree with you that we should describe it better.

Okie, I'll fix the test.

Closing via https://github.com/fagbokforlaget/pdftotextjs/pull/10


Make sure all the codesandbox tutorials are under Solid's github account control

Right now, the codesandbox tutorials are created by the Creators in their own name, which is not sustainable on the long run. All these projects should be migrated to be accessed by the Solid account.

@Mitzi-Laszlo Can I get access to the Solid 1Password?
Note that this isn't that big a deal: it's always possible to fork a sandbox under a new account and then to update the links.
(That said, there are also many that are just direct references to a mirror the Notepod repository. I can move that mirror to the Solid GitHub group and give the Creators access.)


Include datamart based sample generation

Is your feature request related to a problem?
We have some tools/scripts developed in-house to generate a dataset from an ADM datamart that mimics the (univariate) distribution. Such scripts could be of use to a broader audience. Such a dataset might be useful to port ADM statistics from one system to another if this is not possible in any direct way.
Describe the solution you'd like
Take the existing tool (originally in R but got ported to Python) and make part of PDS tools - including an example NB, Wiki content etc
Describe alternatives you've considered
NA
Additional context
No response

https://git.pega.io/projects/DS/repos/data-generation/browse

Not needed as functionality in pdstools, closing.


Add ability to interact with loot on the ground

[ ] Update map to allow items to be in grid cells
[ ] Spawn items in the dungeon when it is created
[ ] Add controls to pickup items
[ ] Implement "Item Action Menu" panel - 'examine' and 'drop' options

Closing as duplicate


Could not find windows installers in assets

Hi there! my problem is that could not find windows installers in assets. Are you going to build it for version 0.27.0 or maybe not?

Installers are available now


Feature/pwa

Motivation
Provide a progressive web-app.
Issues closed

closes #80

[Bug]: App shows white-screen after five reloads. Bug appears if PWA is enabled.

[Bug]: App shows white-screen after around five reloads. This branch has been reverted back to e21dec8 and closed. Please see new pull-request!


Removed git show filter to avoid empty list errors

Any filtering on git show can result in an empty list of changed files, and then a failure of the check. To include more types of commits, the only ignored files will be deleted files (hence the lower-case d).
Addresses Issue #31

This doesn't resolve the issue entirely, and can still result in an error if the commit in question contains only the deletion of a single file.

@merill Do you think this is worth incorporating?

@jimbudarz Thanks for the updated. For information i will also look at the analyser handling of empty lists. If there is nothing changed in the content it makes sense not to check any files and most importantly not fail the check.

Thanks a lot @jimbudarz for the PR! Apologies for my tardiness.


Feature Request: ability to "continue" scrolling if needed

One of the things I wish I could do is alter the scrolling mechanism or skipping elements to scroll based on certain conditions, but the side-effect of attaching a function to behavior is that it effectively interrupts all scrolling. It would be nice to alter the list of elements to scroll, and where they will scroll to, but then pass the action back to the library, since it already polyfills smooth scrolling. Otherwise, if I use behavior: Function, then I have to additionally polyfill smooth scrolling, even though it's polyfilled in your library internally. It would be nice to say back to scrollIntoView, "yes, continue scrolling this and this element smoothly, although change element 2's eventual scroll position. And no, don't scroll element 3." And then the magic just continues from there.

I think what you should probably do is, rather than have a function as behavior, leave the other values for behavior and then have something like beforeScroll with the entries. Returning true should just execute normal behavior. Returning an object should change what is scrolled and to what scroll values.

This is something I've wanted as well. It's mentioned shortly after the initial v2 release:

For those who want to skip some overflow elements, but not all, I plan on introducing another callback option for that, similar to options.boundary where you can make your own assertions and decide what should count as a scrolling box or not.

It would be super nice to just be able to skip certain elements and have everything just work™ instead of needing to reimplement so much functionality. This feature would belong in compute-scroll-into-view though, to ensure the scrolling coordinates are correct when elements are skipped.
Instead of calling it beforeScroll how about shouldScroll?


Publish to PyPI

For ease of use in downstream projects, publish this as a PyPI package. There is a separate Test PyPI that can be used for testing publishing workflows. GitHub can act as a trusted publisher, which simplifies authentication--there is no need to create a PyPI token.

The Test workflow should be executed before each Publish workflow. See GitHub Actions / Reusing workflows and SO: Dependencies Between Workflows on Github Actions.

Commit c62577e11cab9f530058ef37b2c819d0334c854c is published to Test PyPI, and the project repo has been added as a trusted publisher to PyPI.

Issue resolved by commit f4ae15084cad607109cc9bf6b9483600c04e2343.


add optional features for less used algorithms

This commit disables by default a few of the weaker cryptographical algorithms into
a "weak-crypto" feature as well as some of the less used algorithms into
their own specific features.
These algorithms are not directly exposed through the rust-openssl crate.
The compilation of these can be re-enabled by selecting the desired features.
This should slightly reduce build time and library size.
Signed-off-by: Petre Eftime<EMAIL_ADDRESS>Testing
I've tested this feature by building this crate with cargo, and by modifying a local rust-openssl repo to use my local clone as the source for openssl-src, and ran cargo test --features vendored, with and without these features specified in Cargo.toml.

Could you also add a test on CI to just one builder that build --all-features works?

Could you also add a test on CI to just one builder that build --all-features works?

I initially tried adding an extra step in the workflow for stable, but I couldn't find an easy way to run this in the container, so I've added this to the ci/run.sh file instead, but I'm not convinced of this approach. I was considering adding a second parameter to ci/run-docker.sh that would allow setting a different script to run instead. Would this be better?

Looks good to me, thanks!


How to save image with PHP?

I have included the javascript in my project and FilePond works great on the FrontEnd, as you can see below:

Here is the code in my HTML:

When I submit the form this is what I get for filepond:

Now, how can I save the image to a folder, let's say: C:/temp/?
I know that I have to decode because the data is base64 encoded, here is my PHP so far, with decoded format:
$filepond = $_POST["filepond"];
$json_decoded = json_decode($filepond[0], true);
var_dump($json_decoded);
and this is what I get from the decoded format:

Could you please tell me what should I do next in order to save the image in a folder and in a MySql DB? Thank you very much!

👉 https://github.com/pqina/filepond-server-php

Dear,
I am aware of the link you sent me but there is not a single good guide on how to use it!!! That it why I opened the question.. So, can you please explain me? Thank you in advance.
Yours Sincerely,
Viktor

On Mar 11, 2020, at 10:19, Rik<EMAIL_ADDRESS>wrote:

👉 https://github.com/pqina/filepond-server-php
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@vgavrilovikj As stated in the issue template, please ask questions on SO:

🧠 If you have a question, please ask it on StackOverflow -> https://stackoverflow.com/questions/ask?tags=filepond


added ABP Framework (7.3K stars)

ABP is an open-source web application framework that is built in Turkey!

Please confirm this pull request meets the following requirements:

[X] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[X] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[X] Content (and my changes are in index.md)

Added a new repository to the index.md

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Hi @ebicoglu, thanks for the contribution ❤. Unfortunately, as per our contribution guidelines, we don't allow self promotion if you are a maintainer of the project:

Maintainers of a project cannot add a topic or collection for their own project. If a topic is popular enough to warrant inclusion, someone else will add or improve it.

We do this so that we can maintain a high level of independence in this project, and projects will be curated if there is enough support/activity in the community. Thank you!

Hi @ebicoglu, thanks for the contribution ❤. Unfortunately, as per our contribution guidelines, we don't allow self promotion if you are a maintainer of the project:

Maintainers of a project cannot add a topic or collection for their own project. If a topic is popular enough to warrant inclusion, someone else will add or improve it.

We do this so that we can maintain a high level of independence in this project, and projects will be curated if there is enough support/activity in the community. Thank you!

I think you should modify the contribution guideline, there's no point to prevent adding a repo as a maintainer 🙄