Move sighash types around

This PR is now part 1 of great sighash clean up. It does not attempt to split ecdsa into two parts as discussed below, that is WIP and will be done in a separate PR. This PR moves us along the road by doing:

Move sighash to the crypto module, where I should have put it ages ago :)
Move the taproot keys to the keys module
Make the taproot types look like this:
taproot::SighashType
taproot:Signature
Rename EcdsaSighashType -> ecdsa::SighashType

Fix: #1550
@Kixunil, now that hashes is proving to be so painful to patch I'm not sure what order you want to go in re #1555. I'm happy to reabase anything and go in what ever order suits you.

Needs https://github.com/rust-bitcoin/rust-bitcoin/pull/1594 to get past clippy.

Yeah, I guess this is worth rebasing. :)
The following is is only important if we need to distinguish between hash-creating algos rather than signing algos. I suspect it's the latter.
I'm not sure about if it should be schnorr::Sighash or taproot::Sighash. What if a new sighash is created that still uses schnorr but not taproot? Presumably this could be the case for CISA. Also is "taproot" the name of witness v1 or of the construction? because if witness v2 uses same construction but different sighash algorithm then it'd still be confusing.
Maybe they should be called LegacySighash and WitnessV1Sighash.

@Kixunil I think we should go with taproot::SigHash and then deprecate it in the (far?) future when we know how it's wrong.
I definitely agree with you in principle that associating the sighash with "Taproot" is not the right categorization (though I do think it's better than "schnorr"). But the next sighash version could appear in several ways:

a new segwit version greater than 1
a whole new transaction format, maybe in an extension block or something
a new tapleaf version not equal to 0xc0
a new CHECKSIG opcode using the same segwit/tapleaf version
some sort of weird hybrid thing that uses the "same" sighash but adds meaningful data to the annex field, which is currently policy-limited to be empty but has no consensus limits whatsoever

The first couple are far-fetched but if I had to put odds on the what the next sighash version would look like, I'd give double-digit percentages to each of the last 3. And it would be pretty hard for us to specify all of those in the name of a type, while still making it discoverable and explainable.
Maybe when the next taproot leaf version comes out we'll deprecate much of the taproot module and replace it with a more specific tapleaf_c0 module or something. But I think it's just too hard to predict this from here.

Wouldn't it be better to just not track the algorithm which produced the type but only track which signing algorithm needs to be used? Similar to what we did with TapNode. I can't imagine a reasonable use case where one would want to distinguish them.
Also it just occurred to me we could simply start using tagging with a default if we wanted backwards-compatibility at all costs.

I'm skeptical. I suppose that distinguishing between ECDSA and Schnorr may make certain kinds of signing APIs more type-safe, but this seems like a weird and arbitrary place to stop using the type system.
Legacy and Taproot sighashe types are generated differently, but also encoded differently, used in different kinds of outputs, and commit to different sets of transaction data. All of those differences will be true between Taproot sighashtypes and future kinds of sighashtypes.
We should probably also distinguish between legacy and segwit sighash types, because even though they have the same names, they commit to very different sets of data and have different security implications for signers.

This uncovers a bit of tangle in the taproot code.

taproot keys could go in crypto/keys.rs
We could remove ecdsa/schnorr in favour of taproot.rs/legacy.rs/segwit_v0.rs (holds signatures, sighash, and sighash types, currently types in ecdsa would need to be duplicated for legacy/segwit_v0
We get naming conflicts with crate::taproot and the re-export of crate::crypto::taproot (after re-name) but we could re-export the crypto stuff from crate::taproot.
Some stuff in crate::taproot should probably be over in crate::crypto::taproot

I can probably do this all in two separate PRs, one for taproot stuff and one for ecdsa -> legacy/segwit_v0 if we get a bit of consensus on the direction.

@apoelstra that convinced me. I agree with also separating legacy vs segwit v0.
@tcharding can you be more specific about naming conflict in crate::taproot?
I know there would be a naming conflict at top-level. IME sighashes are not that commonly used, so I would just not reexport them.
Separating into two PRs sounds fine.

We have bitcoin/src/taproot.rs and we reexport crate::crypto::schnorr so folks can use schnorr::Sighash. If that becomes taproot::Sighash it becomes impossible for lib users to use both modules at the same time (considering we now favour disambiguating by way of a single level of additional path). All the stuff in src/taproot.rs currently has Tap prefixes but I still do not think we should be having multiple modules with the same name without doing reexports because sooner or later it will break.
The only reason to have all the crypto stuff separate is for users to not use the soon-to-be-created crypto crate, but for 'normal' users we can feature gate the reexport so they just use crate::taproot for all taproot stuff.
Anyways, I'll do a PR to showcase it.

I'd appreciate a PR. I agree with Kix that it'd be fine to just not export these types. You can only obtain them from non-generic funcitons (I'm pretty sure) so whenever users handle these they should be able to use type inference. I also think it's fine to drop schnorr::Sighash (or to deprecate this and require they switch to taproot::Sighash. I also think the various Tap prefixes are fine, even if you have to do ugly stuff like taproot::TapBranch. This is because words like "tapbranch" are standard terms by themselves.

I'd appreciate a PR.

Been working on this, thought I had a draft with some problems and while writing the PR description I gave myself some new ideas. Hence I pushed the first part to this branch, second part to come. Spoiler - the taproot stuff was easy.

This is because words like "tapbranch" are standard terms by themselves.

Indeed, that's my thinking as well.

BTW  team, lets not test against the strings in error messages, it is super painful to maintain.

For anyone following along closely I got confused with the Sighash and TapSighashHash types, this PR has never touched them but I erroneously claimed yesterday to fix #1550. We now have #1620 to do that. My bad.

BTW team, lets not test against the strings in error messages, it is super painful to maintain.

EDIT: Oooh, I see why we did this now, since we no longer derive Eq on error types and we don't have matches! yet its a PITA to check a function returns the expected error type. Perhaps after MSRV bump the situation will improve. Worth keeping in mind during the error overhaul.

Nothing prevents us from writing the compiler-version-gated matches! macro ourselves. (similar to what we plan to do with unsigned_abs).

Rebased to fix merge conflicts, no other changes.

Rebase only, no changes.

Rebase only.

One more thing to think about: I'd like to have a type that stores sighash and sighash type and has a sign method which would produce Signature. This type would be returned from sighashcache.
Should we rename current sighashes to *RawSighash and name the new structs Sighash or do we have a better name?

Hmm, maybe calling the other struct FlaggedSighash is better?

I agree FlaggedSighash is better. I'd be tempted even to just make it a type alias (not even a newtype) around (Sighash, SighashType). I think because we own both types we could still implement a .sign method on it, not sure.
Would also be happy with a struct with both fields pub if you think it's clearer to give the fields names.
We had something similar where BitcoinSig was a (ecdsa::Signature, ecdsa::Sighash) for a long time and TBH I think it worked pretty well.
This would be strictly additive so no need to get this in before the 0.30 deadline.

A struct with named pub fields sounds the best.

strictly additive

Well, I want SighashCache to return them instead of sighash so it's API-breaking and also I have a use case for it. But not a big deal if it doesn't get in.

Sorry for the late complaint here again. I will try to be an active reviewer again so that I don't fall behind again. Most of the PR is good, but I don't like the following changes:
Rename the schnorr module -> taproot

To the best of my knowledge, everyone in the bitcoin ecosystem calls schnorr signatures and not taproot signatures.
I get that having all things in taproot sign API start from Tap is a good idea for new people who want to get started. But I think some of the terms like schnorr::Signature (read "Schnorr signatures") are too widespread in the existing community that using taproot::Signature ("taproot signatures") would just create more confusion.
Rename SchnorrSighashType -> TapSighashType

This is something I can live with, but still have a preference for the first one.  For ecdsa case, we have EcdsaSighashType, but schnorr we have TapSighashType? I really prefer having consistent names, but this strikes as slightly odd to me.
I don't think many people outside rust-bitcoin even distinguish between the sighash types (TapSighashType vs EcdsaSighashType), so this is still a call that rust-bitcoin gets to make.

I am convinced by @Kixunil's comment here. https://github.com/rust-bitcoin/rust-bitcoin/issues/1665#issuecomment-1443136963.
Still that thrilled with ecdsa::Signature for pre-taproot outputs vs taproot::Signature for taproot outputs. But I can live with this.

To the best of my knowledge, everyone in the bitcoin ecosystem calls schnorr signatures and not taproot signatures.

The authors of Taproot call them "BIP 340 signatures" ;).
It may be that "everyone" calls these signatures Schnorr signatures, just like they call both legacy and segwit signatures "ECDSA signatures" even though they're encoded differently and sign different things, but this sort of ambiguity is harmful when trying to create a well-typed library that doesn't let you do invalid things.

Thanks for the input @sanket1729, made me think it would be kinda nice if we could push cryptography terms down into secp256k1 and in rust-bitcoin just have bitcoin terms i.e., in secp the sigs are called schnorr::Signature and ecdsa::Signature but in bitcoin they are taproot::Signature and a-soon-to-be-better-named-crate-that-describes-legacy-and-segwit-v0::Signature as we did for sighash (LegacSighash, SegwitV0Sighash, TapSighash)?
Its a hard line to ride between doing what everyone in the ecosystem does and doing it right (for the times when we thing there is a better way).

Warning, personal opinion: I also tend to agree with the sentiment raised before that Schnorr did the wrong thing by the people when he copyrighted the signature scheme so we should not make his name a central focal point now that we can use the scheme.

In addition to disliking Schnorr, BIP-340 are literally not Schnorr signatues because they commit to the public key. They also have a specific encoding and use a particular tagged hash etc.


Pre-condition Headers not Supported by Storage Service

During our review with the storage service team, they pointed out that the SDK exposes numerous pre-condition headers that are not in fact supported by the service. If these parameters do nothing, they should probably not be part of the public SDK interface.
Here are some of the SDK calls which expose unsupported pre-condition headers:

*BlobService.get_blob_metadata
*BlobService.get_blob_properties
*BlobService.acquire_container_lease
*BlobService.break_container_lease
*BlobService.change_container_lease
*BlobService.release_container_lease
*BlobService.renew_container_lease
*BlobService.set_container_metadata

There may be more, but those were the ones specifically called out by the storage service team.
CC: @hasonmsft, @vinjiang, @johanste, @mayurid

These APIs do indeed support conditional headers as per our REST spec.


fixing regressions

from #2138 and #2295

+1  after checks
(but I'm curious as to why you chose not to divide the test code into two separate tests.)

@rasahner purely because all of if was related and still kept test simple.

#2138 is a pretty big PR, is it fully backward compatible?

:+1:


Documentation: we need a README

Oh my god it's Hacktoberfest and we don't have a README to help attract people.
Here are some resources, maybe we can put together something with content from there and/or links to there:

announcement on nixos discourse https://discourse.nixos.org/t/new-tool-for-exploring-nar-contents-online/21840?u=wh0
gallery entry on glitch support forum https://support.glitch.com/t/explore-the-insides-of-nix-packages-from-the-comfort-of-your-browser/56276?u=wh0

a20c3359e73521c86e6d7440768209b34f3f30e3


chore: promote h52 to version 0.1.4-SNAPSHOT

chore: promote h52 to version 0.1.4-SNAPSHOT
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign q1323829945
You can assign the PR to them by writing /assign @q1323829945 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[WIP] Add model to support matching results

Resolve #51

Pull Request Test Coverage Report for Build 341

25 of 55 (45.45%)  changed or added relevant lines in 12 files are covered.
5 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.6%) to 86.774%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/model/ModelManager.java
4
6
66.67%

src/main/java/seedu/address/model/test/matchtest/MatchTest.java
1
3
33.33%

src/main/java/seedu/address/logic/commands/MatchCommand.java
4
7
57.14%

src/main/java/seedu/address/ui/MainWindow.java
0
4
0.0%

src/main/java/seedu/address/ui/AnswerListPanel.java
0
5
0.0%

src/main/java/seedu/address/ui/QuestionListPanel.java
0
5
0.0%

src/main/java/seedu/address/model/test/matchtest/MatchTestResults.java
3
12
25.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/ui/MainWindow.java
1
75.0%

src/main/java/seedu/address/logic/commands/MatchCommand.java
1
77.42%

src/main/java/seedu/address/ui/AnswerListPanel.java
1
0.0%

src/main/java/seedu/address/ui/QuestionListPanel.java
2
0.0%

Totals

Change from base Build 290:
-0.6%

Covered Lines:
2001

Relevant Lines:
2306

💛  - Coveralls


App force-closed channel with coordinator: Failed to find corresponding channel

It looks like this morning a channel with an app has been force closed. Unfortunately, I was not able to match the channel to a user. The counterparty pubkey is 021070ab75d6ef553bca3ba710c0d97c413725e97f469977cebf1d42bbca626aa6, but it is not listed in our users table.
{"timestamp":"2023-05-05T06:14:15.967456542Z","level":"DEBUG","fields":{"message":"Successfully handled event","event":"\"ChannelClosed { channel_id: [15, 103, 246, 64, 137, 122, 115, 242, 51, 190, 220, 129, 88, 211, 181, 239, 35, 112, 202, 72, 57, 92, 213, 104, 136, 174, 230, 154, 200, 236, 210, 125], user_channel_id: 0, reason: CounterpartyForceClosed { peer_msg: \\\"Failed to find corresponding channel\\\" } }\""},"target":"ln_dlc_node::ln::event_handler"}
{"timestamp":"2023-05-05T06:14:15.967444063Z","level":"INFO","fields":{"message":"\nChannel closed","channel":"0f67f640897a73f233bedc8158d3b5ef2370ca48395cd56888aee69ac8ecd27d","reason":"CounterpartyForceClosed { peer_msg: \"Failed to find corresponding channel\" }"},"target":"ln_dlc_node::ln::event_handler"}
{"timestamp":"2023-05-05T06:14:15.967352639Z","level":"INFO","fields":{"message":"Received event","event":"ChannelClosed { channel_id: [15, 103, 246, 64, 137, 122, 115, 242, 51, 190, 220, 129, 88, 211, 181, 239, 35, 112, 202, 72, 57, 92, 213, 104, 136, 174, 230, 154, 200, 236, 210, 125], user_channel_id: 0, reason: CounterpartyForceClosed { peer_msg: \"Failed to find corresponding channel\" } }"},"target":"ln_dlc_node::ln::event_handler"}
{"timestamp":"2023-05-05T06:14:15.967252469Z","level":"ERROR","fields":{"message":"Error broadcasting transaction: Electrum(Protocol(String(\"sendrawtransaction RPC error: {\\\"code\\\":-25,\\\"message\\\":\\\"bad-txns-inputs-missingorspent\\\"}\")))"},"target":"bdk_ldk"}
{"timestamp":"2023-05-05T06:14:15.864011428Z","level":"INFO","fields":{"message":"Broadcasting local commitment tx with txid 6f02c320b0f0af58165b06c4f283550c4f9e4c9c3d0b5b77d17f29e84552e8d3","log.target":"lightning::chain::channelmonitor","log.module_path":"lightning::chain::channelmonitor","log.file":"/home/runner/.cargo/git/checkouts/rust-lightning-8ffd0e8d14b5d2cc/6df5761/lightning/src/chain/channelmonitor.rs","log.line":2296},"target":"lightning::chain::channelmonitor"}
{"timestamp":"2023-05-05T06:14:15.863811609Z","level":"INFO","fields":{"message":"Applying update to monitor 0f67f640897a73f233bedc8158d3b5ef2370ca48395cd56888aee69ac8ecd27d, bringing update_id from 33 to 34 with 1 changes.","log.target":"lightning::chain::channelmonitor","log.module_path":"lightning::chain::channelmonitor","log.file":"/home/runner/.cargo/git/checkouts/rust-lightning-8ffd0e8d14b5d2cc/6df5761/lightning/src/chain/channelmonitor.rs","log.line":2307},"target":"lightning::chain::channelmonitor"}
{"timestamp":"2023-05-05T06:14:15.863803616Z","level":"DEBUG","fields":{"message":"Finishing force-closure of channel with 0 HTLCs to fail","log.target":"lightning::ln::channelmanager","log.module_path":"lightning::ln::channelmanager","log.file":"/home/runner/.cargo/git/checkouts/rust-lightning-8ffd0e8d14b5d2cc/6df5761/lightning/src/ln/channelmanager.rs","log.line":2135},"target":"lightning::ln::channelmanager"}
{"timestamp":"2023-05-05T06:14:15.863791539Z","level":"ERROR","fields":{"message":"Force-closing channel 0f67f640897a73f233bedc8158d3b5ef2370ca48395cd56888aee69ac8ecd27d","log.target":"lightning::ln::channelmanager","log.module_path":"lightning::ln::channelmanager","log.file":"/home/runner/.cargo/git/checkouts/rust-lightning-8ffd0e8d14b5d2cc/6df5761/lightning/src/ln/channelmanager.rs","log.line":2172},"target":"lightning::ln::channelmanager"}
{"timestamp":"2023-05-05T06:14:15.863791539Z","level":"ERROR","fields":{"message":"Force-closing channel 0f67f640897a73f233bedc8158d3b5ef2370ca48395cd56888aee69ac8ecd27d","log.target":"lightning::ln::channelmanager","log.module_path":"lightning::ln::channelmanager","log.file":"/home/runner/.cargo/git/checkouts/rust-lightning-8ffd0e8d14b5d2cc/6df5761/lightning/src/ln/channelmanager.rs","log.line":2172},"target":"lightning::ln::channelmanager"}

Could it be that this channel was never properly opened because the fund transaction did not make it into the chain?

Could it be that this channel was never properly opened because the fund transaction did not make it into the chain?

It could also be, that the user opened a channel, deleted the app and installed it again. Upon re-connecting, the coordinator would try to re-establish the channel, but the app would reject, because it doesn't know about the channel anymore. I think that would trigger a force close.

Shouldn't you get a new seed and a peerid if you uninstall the app and reinstall the app?

This LN channel is still open in the sense that the funding transaction is unspent. The coordinator's ChannelManager has forgotten about it, but I think all attempts to publish the commitment transaction have failed. This is probably because we have an LN-DLC channel[^1], so LDK is always trying to publish the wrong transaction, as we've documented in #591.
[^1]: This is confirmed by my analysis of the mainnet position statuses, which reveals that we do have an "open" DLC with 021070ab75d6ef553bca3ba710c0d97c413725e97f469977cebf1d42bbca626aa6.


⚠ Bofrost.fr has degraded performance

In a2a54c0, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1623 ms

Resolved: Bofrost.fr performance has improved in e492468 after 5 minutes.


Workon virtuanenv

Workon virtuanenv is still unavailable

Hi,
This doesn't seems to be an error message of mine.
When you type workon without environment the message is
ERROR: No python venv to work on. Did you forget the -Name option?

since the first commit.
Don't you use virtualenvwrapper from Guillermo López on BItBucket?
Regards

hello
Yes, I have found my problem, I am sorry, I will close this problem


Automate updates to gist download page for new releases

@Jamie-SA I'm moving this to an issue since it's on the back burner. This keeps it on the radar but doesn't have to keep appearing in meeting action items.

Manual rewrites to the current page are required as well.

@rjyounes
Do you want to keep this in its current status?


Social Links

by providing social media icons at the bottom of the page to make the links visually appealing.

@Sanskriti65 please provide SWOC label.

@Sanskriti65 please provide SWOC label.

Done


FINERACT-1529: Update dependencies

org.mockito:mockito-core [4.0.0 -> 4.4.0]
org.mockito:mockito-junit-jupiter [4.0.0 -> 4.4.0]
org.apache.activemq:activemq-broker [5.16.3 -> 5.17.0]
org.apache.poi:poi [4.1.2 -> 5.2.2]

FYI: this PR contains also a minor "fix" concerning the Gradle plugin configurations... before we had too many submodules declared as Java projects.

LGTM


32bit compatibility for ndarray

numpy's ndarray use ssize_t to store their shape, while Pythran uses
long, for compatibility with other Python integer. This does not cause
any issue on 64 bit platform, but it was problematic under 32 bit
platform where sizeof(long) != sizeof(ssize_t).
this patch proposes a non-intrusive fix.

Updated!

Should we add a travis compilation with -m32?
Of course it will be too long to do it for each commit but may be we can do it only for the master branch?

On Mon, Jan 05, 2015 at 06:48:28AM -0800, pbrunet wrote:

Should we add a travis compilation with -m32?
Of course it will be too long to do it for each commit but may be we can do it
only for the master branch?

I tried this, but it fails on python headers...


Don't run pump at a stop

OP increases braking strength at a stop.  This prevents the pump from running.

Adjusting brake_stopping_target to a smaller amount has a bigger effect without stopping the signal to the brake pump.  So closing this PR.


Chat Bidding Broken

Simply always get "Chat Bidding is currently disabled." every time we attempt to test with !bid, even though !dkp works - so clearly chat commands are enabled.

Chat bidding hasn't functioned in almost 2 years. This is by design. References to chat bidding will be removed in the future.

Ah, unfortunate. Was hoping to not force guildies into downloading an addon if the chat bidding worked as well. Thank you for the response.


Dependency problem

When I try to install musicKube on my MX-Linux via the deb package it gives me these errors:
musikcube : Depends: libboost-thread1.63.0 but it is not installable
Depends: libboost-system1.63.0 but it is not installable
Depends: libboost-filesystem1.63.0 but it is not installable
Depends: libev4 but it is not going to be installed
These unmet dependencies are wrong because libboost is not currently on version 63.0 they are on version 62.0 so these dependencies are wrong.

Hmm, we don't explicitly support that Linux distro, but it looks like the Ubuntu Zesty deb uses boost 1.62.0. Have you tried that? https://github.com/clangen/musikcube/releases/download/0.65.0/musikcube_0.65.0_ubuntu_zesty_amd64.deb


duplicate_vertices silently consumes indices

How can Bevy's documentation be improved?
Mesh::duplicate_vertices silently takes indices from the Mesh but doesn't mention it in the method documentation.
This lead to my code breaking because it relied upon indices being present. I added a call to duplicate_vertices and didn't realise my later code that did something for each index was now not running.
I assume not rebuilding the index data is an optimisation. Either way this behaviour should be documented or the code should rebuild the index data if it was previously present.
An alternative could be to have a  function duplicate_vertices_without_indices (naming aside) that would have the current behaviour, and change duplicate_vertices to rebuild the index data before finishing. I'm thinking along the same lines as Vec::sort and Vec::sort_unstable, or Vec::remove and Vec::swap_remove having longer/different names for behaviours that have side effects the programmer should take note of.

The way I see this function is:
It expands the vertices so that no vertex position is reused. Therefore no index appears twice in the index array and may only order the vertices. Now order the vertices array and you dont need the index data anymore.
This can obviously be better documented, but this side effect can be implied with some knowledge about the rasterization process. But - yes - as you have suggested, its only implicit.
I would argue expand_vertices, or even something like integrate_indices is a better name, though. There are probably even better ones.


System solver test

Lets add this test https://www.instagram.com/p/CLUQ3nQj43n/

https://www.instagram.com/p/CLTo1p-DgXi

https://twitter.com/engineers_feed/status/1526779710910345217?s=21&t=1Wsn0nqj9GajpUT6MDrfwQ


How to autoload my PEAR-style library

I can't configure behat through behat.yml to autoload my PEAR-style non-namespaced project library

Switch to using Composer for both your composer and PEAR libraries - that's much easier solution than what you're trying to do


Work in progress - Split ssh utils into a separate module

This is work in progress and not ready to be merged yet.
Addresses #338 - Splits ssh utils into a separate module.

Removes SshUtils, tests and profile additions from posh-git
Creates a new posh-ssh module (inside the posh-ssh subdirectory for now)
Splits SshUtils into various files
Duplicates some posh-git utility functions that the ssh utilities need

All posh-git tests are passing. 2 Posh-ssh tests are currently failing.

I'll take a closer look later today, but an immediate observation: what if we moved the posh-git module into src/posh-git/ and SSH module into src/posh-ssh/? I think this would fix #467.

what if we moved the posh-git module into src/posh-git/ and SSH module into src/posh-ssh/?

Nevermind. I really don't think we want to invest anything in making the SSH organization better here.

Still pondering this. I wonder if it's worth making any SSH fixes at all here in this repo, rather than just spawning a new repo?
From a preservation-of-history standpoint, perhaps the easiest path forward would be to actually make posh-ssh a fork of the posh-git repo at whatever point we consider the v0 fixes "done". Delete all the Git-only files, rename/prune the module, new readme/changelog, fix up some code and we're good to go. Thoughts?

I like that idea, preserving the history is good.

@dahlbyk I've removed the commits that create posh-ssh and squashed the destructive ones. I think this should be good to go - let me know if you'd like anything changed.

@dahlbyk Is there anything else you'd like me to do for this, or are you happy for me to merge it to master?


Update content programming guide with info about pagination

Depends on https://github.com/spotify/HubFramework/pull/135
Resolves https://github.com/spotify/HubFramework/issues/28

@spotify/objc-dev

Current coverage is 92.65% (diff: 100%)

Merging #136 into master will increase coverage by 0.26%

@@             master       #136   diff @@
==========================================
  Files            61         61
  Lines          4451       4451
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4112       4124    +12
+ Misses          339        327    -12
  Partials          0          0

Powered by Codecov. Last update 511ba6f...d8587fd


changing theme flavour for a running server does not work

Hi
I like to change my iterm & tmux & vim themes from light to dark and vice-versa throughout the day.
My workflow is as follows:

I detach the tmux session.
I change the flavour in iterm.
I change the flavour for tmux from terminal: tmux set-option -g @catppuccin_flavour ....
I attach the tmux session.

I have also tried to source the .tmux.conf file as well as reload the tpm after 3. but it doesn't work. This workflow of mine was working with the solarized theme.
What am I missing here?
Thanks for help.

tmux run-shell '~/.tmux/plugins/tpm/tpm' after 3. does the job. I was messing up something before.

it stopped working after i have upgraded to the latest version. i am not using tpm anymore. i have followed the manual setup as recommended. the plugin in itself works perfectly, but dynamically changing the flavor for running server not. what is the current way to do it?

Due to the complexity of this plugin, this cannot be easily supported. You could manually unset some of the internally derived options on reload if you really wanted

I had the same workflow as well, which was working fine on <0.2.0 but is broken starting on 1.0.0. To reproduce, tmux.conf:
set -g @catppuccin_flavor 'mocha' # latte, frappe, macchiato or mocha

run ~/.config/tmux/plugins/tmux/catppuccin.tmux

Reload the server
Prefix+: set -g @catppuccin-flavor 'latte'
Prefix+: run ~/.config/tmux/plugins/tmux/catppuccin.tmux
Nothing changes

Considering there seems to be some interest in this feature from @nimaai as well as other users that asked about setting up automatic theme changes in the past, would you reconsider marking this as not planned?

I'm really hesitant to build this into the theme the way that it works. Switching the colours on a tmux server based on what is happening on a client seems like an antipattern. Tmux is quite strict w.r.t. the client-server model, and works well when that model is followed.
Therefore, I'd highly recommend using colours that rely on the terminal itself. See the terminal style here: https://man7.org/linux/man-pages/man1/tmux.1.html#STYLES
If your terminal is using the catppuccin colours then you don't really need to style tmux at all, just make tmux style things less


I can't deploy the pivottable react component on the apache server.

I tried to use the pivottable react component on the apache server. But I don't know how.
Please help me.

Hi!
A couple of responses:

If you have questions regarding react-pivottable, please create issues in that repo (https://github.com/plotly/react-pivottable/issues) rather than here, otherwise it's very confusing for everyone...
I will need a lot more detail about what you're wanting to do, what you tried and how it went wrong, in order to help you :)

Issue created here: https://github.com/plotly/react-pivottable/issues/6


Add clasp to dev dependencies

Hello! Thanks for this project. I'm wondering if clasp should be required as a dev dependency here or if it just needs to be installed globally on the local machine?

@joejansen
Thanak you your Pull request.
gas-clasp-starter is based https://github.com/google/aside.
aside seems to recommend a global installation.
https://github.com/google/aside/blob/main/package.json#L47-L73
I Added to README.md that global installation is recommended.
https://github.com/howdy39/gas-clasp-starter/pull/173/files

@howdy39 sounds good! Thanks for the README update.


Enable pwa

As a user I want to be able to download the page as an app using PWA

Holding of on this since I kinda dont want to do this right now. It didnt work last time i tried.


api: use variadic args in Mutate

It makes the API less verbose and more homogeneous with other commands
such as Where()
Fixes: #124
Signed-off-by: Adrian Moreno<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 871365747

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 72.476%

Totals

Change from base Build 859723497:
0.03%

Covered Lines:
1780

Relevant Lines:
2456

💛  - Coveralls


Amplitude of BHPTNR surrogate doesn't match that of of other waveforms for q <= 50 and also upto 1000.

For q < 50, I tested BHPTNR surrogate against a few waveform approximants available in the lalsuite.
I see that there can be a huge discrepancy between BHPTNR surrogate amplitude and that of IMRPhenomD, IMRPhenomXAS and SEOBNRv4 for q in range (10, 50) and total mass in range 1, 100.
Even when I compare the two waveforms in the same frequency band, the amplitudes do not match.
As the mass ratio grows, SEON and Phenom waveform models differ slightly but not as much as BHPTNR surrogate.
With `IMRPhenomXAS, I did compare the amplitudes till q = 1000, but they differ by orders of magnitude. I only compared lmax = 2 modes. Even though the amplitudes do not match, the matches between the waveforms are not too bad (sub per cent to ~10% per cent).  This tells me that the geometric to SI scaling may be the issue but I could not locate the pattern.
I was trying to use BHPTNR surrogate waveforms as injections in IMRI-sub-solar mass searches which I am currently pursuing.

@bhooshan-gadre This appears to be due to a bug in gwtools when calling the geo_to_si function. The latest version (1.1.6) fixed the bug.
If this fixes your problem, we can close out this issue.

@sfield17 I don't think pc --> 1e6 * PC actually fixed the big. It has made it even worse. BHPTNRSurrogate SNR/amplitude was constantly lower than other waveform models by ~2-3 orders of magnitude. But now it has even gone down further by 6 orders of magnitude!

gwtools 1.1.7 fixes the issue.


AutoBuyer Trading strategies

Sorry for using GitHub issues for this, but I feel like it is the most appropriate place to ask.
Is there a reliable strategy with this tool to make coins or how do people use it?
Is there a filter I can copy to make coins or do I have to analyse and understand the market to set up the filters myself?
Thank you for your help!

You can join the  Discord here people discuss about filters.
But if you want to maxmize the coins you make it makes sense to analyze the market yourself and up come with the filters


Superfluous entry

Already covered by EXTERN, EXTRN.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25372c13-281f-c01a-ccb0-7746c9589f7a
Version Independent ID: 5849bf2f-35d5-af1f-eca7-7c6ef0940ea6
Content: EXTRN
Content Source: docs/assembler/masm/extrn.md
Product: visual-cpp
Technology: cpp-masm
GitHub Login: @corob-msft
Microsoft Alias: corob

@Player1UK thanks for the feedback! However, after considering pros and cons, the product team has decided that the entries should not be merged.


[Candidate 4v4 Umbrella Corps ZH v1] Destructible buildings in map center cannot be attacked or take vastly inconsistent damage to die

Observed behavior
Destructible buildings in map center cannot be attacked or take vastly inconsistent damage to die.
Expected behavior
All destructible buildings are properly attackable and take more consistent damages to die.
Videos
https://github.com/TheSuperHackers/GeneralsRankedMaps/assets/4720891/b1263467-8d44-4542-b61d-30ed7a9ee4e2

fixed

Not seeing improvement. Armor is still vastly inconsistent. Plus the destructible buildings no longer have health bars now. Is this intended? There are now some destructible civ buildings that have health bars and others to not.
Destructible oil tank with no health bar

Destructible oil tank with health bar

This behavior is very inconsistent right now.

Not seeing improvement. Armor is still vastly inconsistent. Plus the destructible buildings no longer have health bars now. Is this intended? There are now some destructible civ buildings that have health bars and others to not.
Destructible oil tank with no health bar

Destructible oil tank with health bar

This behavior is very inconsistent right now.

yes its intended that the buildings in mid do not have a HP Bar and the Buildings at the corners do. In mid you should be able to klick free on all possible units, the HP Bars might bring missklicks with it. On the corners its fine to see how long you need to fire on a building to destroy it there is no trouble with fighting. Also all buildings sunken into the ground in mid are consistent killable now.

How about making it consistent? All destructible civ buildings behave the same?

If i reveal all HP Bars from the destructible buildings ppl will cry if i hide all Hp Bars ppl will also cry, so i think this is a design thing.

How is this done in Official Maps? Perhaps we should stick to what the original maps do for consistency.

same as it is rgn some do have bars some have non

I do not understand this design.
This Silo takes 1 shot and is attackable and has a health bar

This Silo takes 1 shot and is not attackable and has no health bar

Why do they have to behave differently?

i only touched the hp bars on mid so thats a thing made by the mapper i can change those but i think thats a unnessecary thing to do cause only the ppl in here will notice this


Graphql 16 upgrade

Attempt to support GraphQL v16 (cloned from @saihaj's PR)
cc: @saihaj
Closes #1982

graphql-language-service-utils was not added in the changesets and it was not updated:
../../../node_modules/.pnpm/graphql-language-service-utils@2.5.3_graphql@16.0.1/node_modules/graphql-language-service-utils/dist/validateWithCustomRules.js:5:40: error: Could not resolve "graphql/validation/rules/ExecutableDefinitions" (mark it as external to exclude it from the bundle, or surround it with try/catch to handle the failure at run-time)
. prepare: packages/helix/graphiql prepack:     5 │ ...itions_1 = require("graphql/validation/rules/ExecutableDefinitions");


Update virtual-machines-faq-for-disks.md with FAQ item for leases

@singhkays please review

@ScottAzure : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

@singhkays - Would you review the proposed changes?  Thanks

@ScottAzure Consider rewording as "This is not supported " since it's not exactly a feature and we don't intend on supporting this behavior.

#sign-off

@singhkays - If this pull request is ready to be resolved, please add an appropriate comment to enable automation to take the corresponding action. Thanks


Remove Http4s NonEmpty List

Do we still have one, or just syntax for it?  I think getting that syntax moved onto cats' NonEmptyList would be great.

I moved it into org.http4s.syntax in the cats PR and removed one of the methods, since it already exists on NEL.
The rest are still used in a couple of places, but getting them into cats would be nice I guess.

Those syntax methods are now in cats-1.1.  And I don't like them being ours, because they're not enhancing our types.  I don't think we can deprecate this without clashing with the cats versions.  I think we should remove this entirely.

Can this be closed? :)

These methods are all deprecated now. :+1:


Extraction of the example data results in an error

This error occurs in the Example_OLR_Tracking_satellite.ipynb notebook upon trying to download and extract the example data.
It is caused by the fact that while zipfile.Zipfile is called the corresponding module is never imported.
Fixing this problem is probably trivial, however I would like to know what the preferred method of extracting the temporary zipfile is as there are two possibilities:

import zipfile
use shutil.unpack_archive (cf. Example_OLR_Tracking_model.ipynb)

Good catch! I think it would be best to use the same method we use in the main tobac repository:
https://github.com/tobac-project/tobac/blob/43060c2ecc25df64a04eb889b25d653d8e538037/examples/Example_OLR_Tracking_satellite/Example_OLR_Tracking_satellite.ipynb?short_path=27769cc#L90-L102
This also automatically checks for the data and downloads it if missing, which is nicer than commenting out/uncommenting code blocks.
We should look into updating the tobac-tutorials notebooks to bring them up to date with the main repository. Could you look into whether we can merge the changes in directly?

We should look into updating the tobac-tutorials notebooks to bring them up to date with the main repository. Could you look into whether we can merge the changes in directly?

Because the notebooks in the main repository use a more robust & consistent approach to downloading / extracting the example data I think this is the best way to deal with this issue.
I will have a look at this at the beginning of next week

After thinking about this again I would like to suggest that we wait with this until we have transitioned to notebooks without output (cf. issue in main repository). This would make the process of merging different versions of the same notebook much easier.
Another quick solution would be to simply update the download and extraction of example data according to the approach chosen in the main repository.
I would also like to hear your thoughts on this @w-k-jones

I think the idea of making the notebooks easier to merge without output is a good one. I've been thinking about how we could use this repository as a sort of "draft" for preparing more polished examples to add to the main repository, so making sure we can easily merge changes is important


Determine local time from lat/long

Currently, the system time zone is used for determining local time. Currently, the software assumes your weather spot is also in your time zone, which works fine for 99% of use cases, but if you want to build a rotating display showing weather in other places, things go a bit wrong.
For example, a computer in the UK displaying weather in Australia will never show a "good laundry day" because your 10am time to put the laundry out is in UK time, which is evening in Australia.
Need to double check how iCal times are handled as well, make sure we are getting the times as UTC so they are plotted right.
Need to find a library for inferring time zone from lat/long, if such a thing exists.

https://pypi.org/project/timezonefinder/


Chart lost height when container is resizing

When rendering a chart with responsive: true and maintainAspectRatio: false, chart will lost its height when container is resizing.
Expected Behavior
Chart should keep its original height, just like 2.9.x version.
Current Behavior
Chart's height will collapsed to 0.
Possible Solution
Re-render the chart will restore its height
Steps to Reproduce (for bugs)
See this jsfiddle
Click Hide button first, then click Show button, you'll see the chart will be missing.
Here's the same jsfiddle but with version 2.9.3, which doesn't have the bug.
Context
Needs to switch from tabs (which implements by setting blocks' display to none, which will cause the case)
Environment

Chart.js version: 3.0.0-alpha
Browser name and version: Microsoft Edge Version 84.0.488.1 (Official build) dev (64-bit)

One possible solution: As in the original behavior the chart will skip resizing when its resizing to (0, 0), I think add a size check at the observer call back like below should resolve this problem:

If you think the change is reasonable, I'll submit a PR for this change later

Looks like it will introduce other bugs. Just ignore that.

Oh, looks like that's another bug(?), not introduced by above change. If the container is hidden when the chart is created, then it will have a size of 0. If that's by design, then above change should fix this issue.


【Server】added engine type and asr inference

PR types
New features
PR changes
Models
Describe
added engine type and asr inference

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: pollyyan:white_check_mark: Jackwaterveg:white_check_mark: WilliamZhang06:white_check_mark: yt605155624:white_check_mark: zh794390558:white_check_mark: Honei:x: rootroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Access to DerivedClass2

"If Assembly1.cs contains an InternalsVisibleToAttribute that names Assembly2, the derived class DerivedClass1 will have access to private protected members declared in BaseClass."
As written, this does not make any sense, since DerivedClass1 already has access. Assembly2 contains DerivedClass2, so DerivedClass1 should be changed to DerivedClass2.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee5e6972-0f7a-8bb7-9f5a-0ba75909f9d8
Version Independent ID: 618c0361-38a0-4d6f-f46a-881db2e4b399
Content: private protected - C# Reference
Content Source: docs/csharp/language-reference/keywords/private-protected.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @sputier
Microsoft Alias: wiwagn

Hi :wave: @RobertGBryan
The article is correct as written.  The private protected access modifier means that the method is visible to derived classes in the same assembly.  The situation you're describing above applies to protected internal.
The best way to remember it is this:

private protected means derived types AND in the same assembly.
protected internal means derived types OR in the same assembly.

I'll close this as an answered question.

Hi @BillWagner,
One of us appears to be a little confused. I sure hope its not me.
So, first off, your analysis of private protected and protected internal is correct. But, that is not really relevant here. What is relevant is that the article says:
"If Assembly1.cs contains an InternalsVisibleToAttribute  that names Assembly2, the derived class DerivedClass1 will have access to private protected members declared in BaseClass. InternalsVisibleTo makes private protected members visible to derived classes in other assemblies."
If you look up the InternalsVisibleToAttribute link, it says:
"Specifies that types that are ordinarily visible only within the current assembly are visible to a specified assembly."
Again, DerivedClass1 already has access because it is both in the same assembly and it is a derived class. If you look at the code:
 // OK, accessed through the current derived class instance
myValue = 5;
So, clearly DerivedClass1 clearly already has access. There is no reason to give it access with the InternalsVisibleToAttribute class. The only reason for specifying Assembly2 via the InternalsVisibleToAttribute class is so that DerivedClass2 will have access. Notice the code for DerivedClass2:
// Error CS0122, because myValue can only be// accessed by types in Assembly1// myValue = 10;
The reason for using the InternalsVisibleToAttribute class here is to fix the compilation error in DerivedClass2.
Also, notice that DerivedClass1 is not in Assembly2. It is in Assembly1. So, why would the documentation try to claim that naming Assembly2 gives access to DerivedClass1? DerivedClass2 is in Assembly2. So, clearly this is just a simple typo.
The documentation should say:
"If Assembly1.cs contains an InternalsVisibleToAttribute  that names Assembly2, the derived class DerivedClass2 will have access to private protected members declared in BaseClass. InternalsVisibleTo makes private protected members visible to derived classes in other assemblies."
I tried to explain this as simply as possible. If you still do not understand it, then please talk to either a senior software engineer or a manager.
Please reopen and / or escalate if you insist that it is still correct as written.
Sincerely yours,
Bob Bryan    On Thursday, July 15, 2021, 06:27:15 AM PDT, Bill Wagner @.***> wrote:
Closed #25153.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for clarifying @RobertGBryan I missed which sentence you were referring to.
Reopening.

@RobertGBryan I just opened #25169 to fix this. Thanks for re-engaging so that it's fixed.


Add ability to select cloud model and persist selection

Added a selected model writable store and now we can persist the radio menu settings beyond the lifecycle of its view component, as well as set the QGPTQuestionInput's model property (in CopilotStreamController) with the selectedModelStore value.
We also called CopilotStreamController.connect() on page load to avoid any problems with modelsController.ts being loaded into the main page view before we've sent any queries to the server.

this solves #4


Create and push the patch/content/primary branch

Create the patch/content/primary branch from the feature/body branch.
Push the branch to the remote - git push origin patch/content/primary.

Create the patch/content/primary branch from the feature/body branch.
Push the branch to the remote


CSUB-369 Staking/Unstaking flow

Description of proposed changes:
Take a look at the Staking blog post in confluence, I'm updating it daily. We build on top of the staking and session pallets. I included basic unit tests. We can add more if you like this implementation.
Update:
You will immediately notice that there are two useless structs to fill some associated types. The idea behind these is that these types may need to be fleshed out later or not. To allow for a smooth development experience any piece not needed is unreachable and it has as few assumptions as possible, cheating when absolutely needed, and being conservative about populating data and logic. All the new changes target a mocked runtime.
Add features incrementally. Split development into approachable chunks. Marking everything out of scope defensive,(panics while testing, logs at  --release.). All paths were checked, defensive() does not mean it wasn't audited. There are some blatant hacks that are meant to be obnoxious enough to be easy to spot and refactor later while still being safe, well-tested, and minimal in the requirements and assumptions being introduced.
This is a very arguable implementation that is meant to be refactored after the MVP is finished, so think in terms of agile development.
This is my very best attempt to meet the following.
Move fast and safely to get an MVP.
Not breaking abstraction and building on top of the available primitives.
Introduce requirements iteratively.
I purposely did not cover all the unit tests in case someone wants to do pair programming, wink @atodorov. Otherwise, point them out and I'll cover them.
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #896 (9573af6) into dev (fd1e262) will decrease coverage by 2.79%.
The diff coverage is 45.61%.

@@            Coverage Diff             @@
##              dev     #896      +/-   ##
==========================================
- Coverage   78.24%   75.46%   -2.79%
==========================================
  Files          68       80      +12
  Lines       10726    11591     +865
==========================================
+ Hits         8393     8747     +354
- Misses       2333     2844     +511

Impacted Files
Coverage Δ

pallets/difficulty/src/lib.rs
93.05% <ø> (ø)

pallets/staking/src/slashing.rs
0.00% <0.00%> (ø)

primitives/src/lib.rs
93.33% <ø> (ø)

runtime/src/lib.rs
24.13% <0.00%> (+0.35%)
:arrow_up:

pallets/staking/src/ledger.rs
27.83% <27.83%> (ø)

pallets/staking/src/pallet/mod.rs
27.54% <27.86%> (ø)

pallets/staking/src/pallet/impls.rs
38.65% <38.65%> (ø)

pallets/task-voting/src/mock.rs
53.48% <52.38%> (ø)

pallets/staking/src/lib.rs
26.47% <55.55%> (ø)

pallets/staking/src/era.rs
80.32% <80.32%> (ø)

... and 21 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

#925


polyline convert to line and arc with AsSimpleEntities method get wrong start/end angle

dxf like this:

result like this:

I suggest you to check extrusion direction property too. I had similar question when extrusion direction (Z axis) was non-standard

Also, if possible - attach dxf file

sa.zip
@uzername thanks


Including text metadata in pinecone upsert.

While using langchain for pinecone upsert I was frequently running into an error discussed here. I found that langchain is including text metadata along with whatever the user sends as metadata here. What is the purpose of doing this? It will easily generate metadatas which are over the permissible limit set by pinecone in many cases.

Even though this might still cause high cardinality for metadata, I guess this step is essential in order to actually fetch the text.

I have the same question here too. What are the thoughts on doing this in a way that will not cause high cardinality? I am basically thinking that pinecone (or any vector database) should be storing the vectors and an id, and that the texts should be elsewhere indexes by that id. I do think that other vector databases (e.g. weaviate) deal with having the text alongside the vector data better than pinecone claims to - perhaps the idea is just to wait it out and eventually storing the text will be okay?

I do note that Pinecone, in their examples (e.g. https://docs.pinecone.io/docs/semantic-text-search#creating-an-index or https://docs.pinecone.io/docs/gen-qa-openai#indexing-data-in-vector-db etc.) do just go ahead and store the text in the metadata, rather than "storing high cardinality data in a separate key value store" as they suggest elsewhere (https://docs.pinecone.io/docs/troubleshooting#pods-are-full)

TL;DR: make sure you create your index specifying only the metadata fields other than "text" (where the metadata will be put by default) for indexing
I also had the same question. I did find that pinecone have many examples of putting the text in the metadata (e.g. https://docs.pinecone.io/docs/semantic-text-search#creating-an-index or https://docs.pinecone.io/docs/gen-qa-openai#indexing-data-in-vector-db etc.). They do suggest putting high cardinality data in the metadata for filtering is not a good idea (https://docs.pinecone.io/docs/troubleshooting#pods-are-full), they do have a solution for storing metadata that is not filterable: Selective metadata indexing (https://docs.pinecone.io/docs/manage-indexes#selective-metadata-indexing), which should be fine for us as the langchain code does not ever create the index, so one should be able to specify that the text metadata column should not be indexed when creating the index.
I haven't seen this pointed out in any pinecone docs, though it surely must cause issues for anyone just working from their examples. It might also be a good idea to note this somewhere in the langchain documentation specific to pinecone, that the index should be set up to not index the metadata field where the text will be stored.
This might become more of a concern if langchain ever decides to create indexes, or more deeply integrate searching the metadata - would then need to ensure metadata_config was set up correctly.
(I've combined my two previous comments, posted without fully investigating, into this summary one)

@kitfit-dave thanks so much for this explanation. My index of embeddings was created elsewhere and I'm not keen on rebuilding it, so i think I understand now how I can modify my index to have metadata. It may not be recommended, but it'll suit my purpose especially as I'm just learning and testing for now.

@kitfit-dave thanks so much for this explanation. My index of embeddings was created elsewhere and I'm not keen on rebuilding it, so i think I understand now how I can modify my index to have metadata. It may not be recommended, but it'll suit my purpose especially as I'm just learning and testing for now.


MosaicAuto: Enable highlight from image click

In investigating ejeschke/ginga#515, I wish that when I click on a point on the displayed image, it would draw the associated footprint and highlight the image on the table. Similar feature had been implemented in TVMask plugin.

Fixed by spacetelescope/stginga#140


Add pulseIn feature for arduino

Is your feature request related to a problem? Please describe.
Some Arduino sensors work by reading a pulse for HIGH and LOW on a digital pin.
Describe the solution you'd like

Add a "read pulse [HIGH | LOW] on pin [P]" block.
Add a "read pulse HIGH" | "read pulse LOW" mode on the read pin block.

Describe alternatives you've considered
Because the pulse is read in micro seconds, it is not possible to read the pulse with a timer.
Additional context
Arduino pulseIn function: https://www.arduino.cc/reference/en/language/functions/advanced-io/pulsein/

As there was another request I took a quick look on how to implement it using the existing "read pin" block.
We could add the two PULSEHIGH and PULSELOW modes to the sensor definitions of the out sensor and add two very ugly ifs to the special OUT case in the robSensors.js:
...
// this is a special case for arduino
if (sensor.title === 'OUT') {
    var configBlockName = option.toLowerCase() + 'out';
    var dropDownPorts = getConfigPorts(configBlockName);
    if (option === 'PULSEHIGH' || option === 'PULSELOW') {
        dropDownPorts = getConfigPorts('analogout');
    }
    var fieldSensorPort = thisBlock.getField('SENSORPORT');
    thisBlock.dependConfig.type = configBlockName;
    if (option === 'PULSEHIGH' || option === 'PULSELOW') {
        thisBlock.dependConfig.type = 'analogout';
    }
    ...

As this is not the nicest approach we should discuss this soon.

This feature seems to have been a bit forgotten, but I would really appreciate to see this implemented. With the Calliope this possibility already exists - maybe a transferable implementation for the Arduino can be found there:

On the one hand, this feature would be helpful for the ultrasonic sensor, which could then also be read out manually. On the other hand, this would make it possible to measure the CO2 concentration with the MH-Z19B sensor.
Example for reading the MH-Z19B sensor with pulseIn: https://funduino.de/nr-51-co2-messung-mit-arduino-co2-ampel
Personally I had used another formular according to the data sheet of the MH-Z19B sensor (see below). The only thing missing is the pulseIn-command.
/* Measures CO2 Level of the air and indicates it with colours
 *  Data Sheet of CO2-Sensor MH-Z19B:
 *  https://www.winsen-sensor.com/d/files/infrared-gas-sensor/mh-z19b-co2-ver1_0.pdf
 */

#define CO2_PWM 4

unsigned long preheatTime = 3*60*1000L;    // sensor needs 3min for heating up
int range = 5000;               // sensor measures from 0ppm to 5000ppm

long newppm = 0;                // variable for storing the ppm value

int interval = 10000;            // time between two measurements in ms

void setup() {
  Serial.begin(9600);
  pinMode(CO2_PWM, INPUT);

  Serial.println("Testing MH-Z19B with PWM Interface");

}

void loop() {

  // measure co2 level
  newppm = getCO2();

  if ( newppm == -1) {    // handle error of measurement

    // output on serial monitor
    Serial.println("Measure failed, now pausing, then restarting");

    // wait for the time left, when subtracting the measurement time
    delay( interval - 10 * interval / (2*10) );

    // skip next steps of this loop turn
    return;
  }

   // output of co2 level on serial monitor
  Serial.println("CO2 value: " + String(newppm) + "ppm");
  Serial.println();
  Serial.println();

  // wait
  delay(interval);
}

/* Measure CO2 in ppm by analyzing the pwm-pin according to p. 6 in the data sheet (see header for link)
 * returns -1, if measure didn't succeed
 */
long getCO2(void) {

  long th, tl, ppm_pwm = 0;

  byte counter = 5;         // try to measure five times, otherwise report an error
  do {
    th = pulseIn(CO2_PWM, HIGH, 1004000) / 1000;
    if (th == 0) {
      Serial.println("Measure failed.");
      counter--;
    }
    tl = 1004 - th;
    ppm_pwm = range * (th - 2) / (th + tl - 4);
  } while (th == 0 && counter > 0);

  if ( counter == 0) return -1;
  return ppm_pwm;
}


Adding swagger files for 2020-02-02-preview API version, and updating 2015-05-01-preview for ManagedInstance operation group

… 2015-05-01-preview API version for ManagedInstnces operation group
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk


Fix code scanning alert - Log injection

Check what can be written in log files before write them.
Tracking issue for:

[x] https://github.com/tugcantopaloglu/juice-shop/security/code-scanning/108

Fixed on 357b2df65187aad2ef17dfc97cde5997e7da2f78


Hackdays dev console overhaul

WHY are these changes introduced?
See https://hackdays.shopify.io/projects/18849

WHAT is this pull request doing?
See project and commits for details
How to test your changes?
Remove broken links for pos-ui extensions

Create a POS ui extension
Run dev and open the dev console.
Assert that the POS UI extensions are displayed without links (other than the mobile QR code)

Fix cursor and capitalization styles

Create some extensions
Run dev and open the dev console.
Assert that extension targets are not capitalized, and that only clickable links show the pointer cursor.

Remove unused show/hide methods

Regression.

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes

🎩 Tophat
Remove broken links for pos-ui extensions
Before (main)
https://github.com/Shopify/cli/assets/6130520/cbb3269b-ae58-47f0-b7b1-a4812312d645
After (ml/dev-console)
TODO


OpenSCENARIO support for Lane change

Hello, when will the OpenSCENARIO support be available for Lange change?
Than you in advance.

We have some basic support in, see also our LaneChangeSimple.xosc example. More comprehensive support is work in progress.


Add v1.24.10-rancher4-1

Current latest version v1.24.10-rancher3-1 has RC build of kubelet and the node version shows as v1.24.x-xxx-dirty.
Will need to add final release v1.24.10-rancher4-1 that uses final release tags, and node version would be v1.24.10.

/forwarport v2.7-KDM-For-2.6.11

/forwardport v2.7-KDM-For-2.6.11

Using k8s versions - v1.24.10-rancher4-1and v1.25.6-rancher4-1.

provision an RKE1 cluster. Ensure cluster comes up Active. System Project page workloads are up and Active
Ensure the node version shows the right k8s version - v1.24.10-rancher4-1or v1.25.6-rancher4-1.

v1.24:
https://github.com/rancher/kubernetes/releases/tag/v1.24.10
https://github.com/rancher/hyperkube/releases/tag/v1.24.10-rancher4

Available to test with Rancher v2.6-head after build passes https://drone-publish.rancher.io/rancher/rancher/9173.

Validated on rancher v2.6-head(9b65d8b), KDM pointing to dev-v2.6

Provisioned RKE1 v1.24.10-rancher4-1, k8s cluster(1-cp, 1-e, 1-w).
Cluster came Active with all the pods up and running
Validated node version :

Using kubectl :
> kubectl version
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.10", GitCommit:"5c1d2d4295f9b4eb12bfbf6429fdf989f2ca8a02", GitTreeState:"clean", BuildDate:"2023-01-18T19:08:10Z", GoVersion:"go1.19.5", Compiler:"gc", Platform:"linux/amd64"}

> kubectl get nodes
NAME          STATUS   ROLES          AGE   VERSION
rishabh-cp1   Ready    controlplane   19m   v1.24.10
rishabh-e1    Ready    etcd           19m   v1.24.10
rishabh-w1    Ready    worker         17m   v1.24.10

Kubelet logs also shows:
I0227 10:55:37.391296    7334 server.go:399] "Kubelet version" kubeletVersion="v1.24.10"

Node yaml :
nodeInfo:
      kubeProxyVersion: v1.24.10
      kubeletVersion: v1.24.10

On UI :

Result :

Node version is correct, hence closing the issue.


Donut Chart resize option not working

See fiddle:
https://jsfiddle.net/sava/w4fab3uq/4/

Hi @sava-vidakovic . Can you double check the way you write the attribute?  'donut' rather than 'dount'

Oh... i see now... thanks! :beers:


base: fix inherited class name...

Description
Use a different name for the loop variable, as name was already used as a parameter for this method.
Changes

core/base/meta.py

Related Issues
#489.
Checklist

[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings

Codecov Report

Merging #490 into development will increase coverage by 0.52%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #490      +/-   ##
===============================================
+ Coverage        67.56%   68.09%   +0.52%
===============================================
  Files               81       81
  Lines             3780     3780
===============================================
+ Hits              2554     2574      +20
+ Misses            1226     1206      -20

Impacted Files
Coverage Δ

jumpscale/core/base/meta.py
92.00% <100.00%> (ø)

jumpscale/clients/gedis/gedis.py
94.38% <0.00%> (+1.12%)
:arrow_up:

jumpscale/clients/redis/redis.py
88.23% <0.00%> (+2.94%)
:arrow_up:

jumpscale/servers/gedis/server.py
68.42% <0.00%> (+9.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de05723...12c349e. Read the comment docs.


Can this do IPC with NamedPipes?

Hi i came across this looking for a solid solution to communicate between some personal .net core 2.0 applications im working on. I was wondering if i can do NamedPipe IPC with it? i notice that i can setup custom transports with it. How would i setup a namedpipe transport? Sorry im new to c# just wondering if you had an example custom transport
Thank you

Named pipes are internal windows only transport. you can use WCF for that. you still can implemented in Xeeny but WCF is ready for you.


Set reference p5 examples to noLoop() on window.blur()

Nature of issue?

[ ] Found a bug
[x] Existing feature enhancement
[ ] New feature request

Most appropriate sub-area of p5.js?

[x] Other (website documentation)

Which platform were you using when you encountered this?

[x] Desktop/Laptop

Feature enhancement details:
I regularly notice that students like to have multiple p5.js reference tabs open (also p5 editor) while researching how things work. While great, one big problem is that each of these p5 instances are constantly running (loop()) in the background..! With just 1 or 2 tabs that quickly eats up a lot of browser resources, sometimes there's 5+ tabs all running p5 instances.
In P5LIVE Eco Mode is set active by default, so p5 changes to noLoop() on window.blur() and back to loop() on window.focus(). I propose enabling this especially for the references and ideal (but more discussion needed) if also applied to the web editor.
A proposed snippet for the website (Q: what's the array variable for storing each p5 instance??):
window.onblur = function () {
  for (let i = 0; i < p5Instances.length; i++) {
    p5Instances[i].noLoop();
  }
}

window.onfocus = function () {
  for (let i = 0; i < p5Instances.length; i++) {
    p5Instances[i].loop();
  }
}

If this gets a green light (especially for the reference pages), then perhaps someone from the website-team knows how/where to implement this quickly.. otherwise if pointed in the right direction (which src file and the name of p5 instances array) I'd be happy to give it a go.

Ahh - totally missed that this was definitely an issue for the website repo and not p5.js repo!
Thanks for moving it.

If you are interested in investigating the possibilities (or anyone else), the code for rendering reference example is here and the code for rendering example on examples page is here. Almost all the js files the website use can be found here if that's useful.


Update WindowsAppSDK-RunHelixTests-Job.yml

Migrated MRT's MrmBaseUnitTests, MrmUnitTest, and MrtCoreUnpackagedTests test suites from Helix to the pipeline test environment, leveraging the recently introduced .testdef mechanism for onboarding them. There is then no longer a need for WindowsAppSDK-RunHelixTests-job.yml, hence it is deleted in this PR.
Those 3 test suites were also being directly run on the current build job agent via the vstest task. That looks redundant now, because in the pipeline environment all TAEF tests are being run on many OS images, instead of just one version of Server. Hence, WindowsAppSDK-BuildAndTestMRT-Steps.yml is updated to stop running the 3 MRT test suites.
This PR not only allows us to drop dependency on Helix (whose support is dwindling) from the Foundation repo, but also makes the pipeline more efficient, e.g., in a sample pipeline run in the past: https://dev.azure.com/microsoft/ProjectReunion/_build/results?buildId=64221252&view=results, the "TestInHelix Release_x64" job that runs the MRT tests took 25m 23s.
In an early pipeline run of this PR: https://dev.azure.com/microsoft/ProjectReunion/_build/results?buildId=66122428&view=results, the "PipelineTestsX64 rs_prerelease_x64fre" that runs the same MRT suites, plus a couple of other pre-existing test suites there, took 12m 59s, i.e., a speed up of ~50%.
CR: Michael, Will, Robert
How built:

Changes built fine when triggering the TransportPackage-Foundation-PR pipeline manually
PR validation

How Tested:

In a test pipeline run of this PR: https://dev.azure.com/microsoft/ProjectReunion/_build/results?buildId=66131963&view=results, MRT's MrmBaseUnitTests.dll, MrmUnitTest.dll, and MrtCoreUnpackagedTests.dll produced results below, respectively, as expected in the "PipelineTestsX64 rs_prerelease_x64fre" job:
Summary: Total=268, Passed=268, Failed=0, Blocked=0, Not Run=0, Skipped=0
Summary: Total=21, Passed=21, Failed=0, Blocked=0, Not Run=0, Skipped=0
Summary: Total=27, Passed=27, Failed=0, Blocked=0, Not Run=0, Skipped=0

A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the develop branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.
For status checks on the main branch, please use microsoft.ProjectReunion
(https://dev.azure.com/ms/ProjectReunion/_build?definitionId=391&_a=summary)
and run the build against your PR branch with the default parameters.

/azp run

/azp run

/azp run

/azp run

/azp run


Create dedicated website for the project

Hi Konrad.   I assume you want a website separate from GitHub repository?   Could you elaborate on what should be included and what specific audience needs should be served?

Correct, a separate website with its own domain was mentioned during the initial brain storming. But this will be something for a later phase. We first need find a consensus of the audience and scope of the collection. See issue #6 which is crucial for the whole operation. If you have any opinion regarding that please free to put that there.

I'm also fine with GitHub pages, as long as the content can be pulled from this repo directly and synced.

GitHub page would also be fine for me (e.g. using Pelican or Jekyll)


Pan gesture on close

Hi,
The pan gesture on menu close doesn't work.

Sorry, this demo only to achieve the click of the closure, the purpose of this project is to achieve spring animation, touch gestures can be customized according to their needs


Exit Button

Sometimes I want it to not run in the background when in close it, which is always.
This is a beautiful application, I wish I did not need to kill it to exit fully.

Thank you. When you are in WalkieTalkie or Conversation mode and press the home button these will continue to run in the background, but only when you are in those two screens, to avoid this and exit either mode correctly just press the back button and go back to translation mode text (or the pairing screen) and then press the home button.


Update data grid/table row selection docs

This fixes documentation and examples on doing row selections, for Shiny 0.9.0.

@wch I just went looking for this example and realized that the docs aren't live yet, so I'm going to merge this now.


Notifications - handle Turn On action

This is the full implementation of the process of enabling push notifications:

isNotificationSupported, isPushManagerSupported, isPermisionGranted will help manage the UI, and prevent redundant requests
handleRequestPermission - first thing that needs to be done is request permission from the user
registerServiceWorker - next we are registering service worker
handlePushManagerSubscribe - next we wait for the service worker to be ready and subscribe user - this gives us subscription object
sendToPushServer - sending subscription abject and accountId to push server.

@marcinbodnar public/service-worker.js - empty, is this OK?


[cbc] Add new port

This port is one of or-tools dependencies.
No feature need to test.
Fixes #10425

/azp run

It needs to depend on cgl #7810.

/azp run

This port failed on all triplets, due to the following reason:

CMake Error at C:/vsts/_work/1/s/installed/x64-uwp/share/cgl/CglTargets.cmake:74 (message):
The imported target "Coin::Cgl" references the file
 "C:/vsts/_work/1/s/packages/cgl_x64-uwp/lib/Cgl.lib"

but this file does not exist.  Possible reasons include:

The file was deleted, renamed, or moved to another location.

An install or uninstall procedure did not complete successfully.

The installation package was faulty and contained
"C:/vsts/_work/1/s/installed/x64-uwp/share/cgl/CglTargets.cmake"

but not all the files it references.
Call Stack (most recent call first):
C:/vsts/_work/1/s/installed/x64-uwp/share/cgl/CglConfig.cmake:28 (include)
C:/vsts/_work/1/s/scripts/buildsystems/vcpkg.cmake:256 (_find_package)
CMakeLists.txt:44 (find_package)
-- Configuring incomplete, errors occurred!

I wondered why it cannot find cgl. I have merged cgl to this branch, but it still build failed.

The failures are the same as before.

/azp run

See failures "C:/vsts/_work/1/s/packages/cgl_x64-uwp/lib/Cgl.lib", please check cgl, it shouldn't reference anything in packages directory.

/azp run

Hi @dan-shaw maybe you closed this PR as you misread this as an solved issue.
So I reopen it.

/azp run

/azp run

Add these codes to CMakeLists.txt
set(CGL_INCLUDE_DIR "include/Coin/CglProbing"
                     "include/Coin/CglPreProcess"
                     "include/Coin/CglClique"
                     "include/Coin/CglFlowCover"
                     "include/Coin/CglGomory"
                     "include/Coin/CglKnapsackCover"
                     "include/Coin/CglMixedIntegerRounding2"
                     "include/Coin/CglOddHole"
                     "include/Coin/CglRedSplit"
                     "include/Coin/CglRedSplit2"
                     "include/Coin/CglTwomir"
                     "include/Coin/CglDuplicateRow"
                     "include/Coin/CglLandP"
                     "include/Coin/CglGMI"
                     "include/Coin/CglZeroHalf"
                     "include/Coin/CglResidualCapacity"
                     )
list(APPEND RELATIVE_INSTALL_INCLUDE_DIR ${CGL_INCLUDE_DIR})

Print out the value of RELATIVE_INSTALL_INCLUDE_DIR:
RELATIVE_INSTALL_INCLUDE_DIR:include/Coin;include/Coin/CglProbing;include/Coin/CglPreProcess;include/Coin/CglClique;include/Coin/CglFlowCover;include/Coin/CglGomory;include/Coin/CglKnapsackCover;include/Coin/CglMixedIntegerRounding2;include/Coin/CglOddHole;include/Coin/CglRedSplit;include/Coin/CglRedSplit2;include/Coin/CglTwomir;include/Coin/CglDuplicateRow;include/Coin/CglLandP;include/Coin/CglGMI;include/Coin/CglZeroHalf;include/Coin/CglResidualCapacity
The error like this:
CMake Error in CMakeLists.txt:
  Target "Cbc" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "F:/7850/vcpkg/buildtrees/cbc/src/0978144e9f-840ab9ffcc/${_IMPORT_PREFIX}/include/Coin/CglProbing"

  which is prefixed in the source directory.

Could anyone help give some suggestion about this?

Temporary close this PR, Please reopen it when continue this work.

@NancyLi1013 has there been any update or progress?


Branch 1.1

to fix REST API Issue

hi!
it looks like your merge request is jumbled up. Could you please open an issue on our project tracker describing the issue and attache a patch:
https://issues.apache.org/jira/browse/HBASE
for more information on submitting contributions to the project, please read through our new contributor section:
http://hbase.apache.org/book.html#getting.involved


date and time disappear

Sample:-https://shubham3211.github.io/facebook-sample-1/schedule.html
Fixes #1787

@shubham3211 I guess you deleted the fork of this project from where you made this PR. You need to create a new PR as we are unable to merge it.

New pull request submitted:-#1804


pull request for e2e test at 01/01/2017 21:26:05

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Handling string dtype

modified var creation for incomplete profiles.
it looks like this branch is on an old fork (50 commits behind master). if it is more efficient i can make a new fork and make my changes again. let me know.

@kwilcox sorry, can't figure out how to assign this review to you.

i synced the lucmehl fork to master.

Ah so the issue here is if the first profile is all NaN or a number, future profiles will need to map to that type since the netCDF variable is created based on the data on the first profile. You changed it so the netCDF variables are created at the full dataframe level. Cool, that makes sense. I'll have to port this to the other feature types.
Can you fix up the paths in the tests?

I will try to work on the tests with Jessica.
I think a similar correction needs to be made at the dimension level. Trevor ran into this with profile ids of mixed datatypes... pocean say int first, assigned the dim with int, and then errored on subsequent non-int.

I updated the test file path, not sure if it will work for you.

https://github.com/pyoceans/pocean-core/pull/53


refactor: Use error definition in github.com/cilium/ebpf instead of using hard-corded error message

Use error definition of github.com/cilium/ebpf, in which the bpf map errors are defined.
This commit is refactoring of https://github.com/cilium/cilium/commit/31652abc9c2d782f8cb395fe0333e2acee3c092d and https://github.com/cilium/cilium/commit/88ebd10726a19a2253c09552c905091c7e5b467f .

@christarazi
Thank you for reviewing.
Could you give some release-tag?

@tommyp1ckles
I'm sorry for repeating mentioning.
Could you review and allow to execute further test?

/test


Cert Manager Tavros CA, and Kong Hybrid Mode

This is brilliant! 🔥🔥
Couple questions
Is there a 2.5.0 ce version we can use to keep in sync?
Do the clustering Certificate need isCa?
Are the Kuma annotations around gateways and mtls stuff resolved?

This is brilliant! 🔥🔥
Couple questions
Is there a 2.5.0 ce version we can use to keep in sync?
Do the clustering Certificate need isCa?
Are the Kuma annotations around gateways and mtls stuff resolved?

I removed the isCA from them and the CE reference for the tag so it will use the default for the chart. Currently 2.5.
Kuma is resolved currently by applying gateway mode to the CP as well.


congelado

Repro steps:

Action: appService.showFile
Error type: Error
Error Message: TextEditor(vs.editor.ICodeEditor:2,$model3) has been disposed
Version: 0.9.0
OS: win32

@loquillo10 Were you by chance double-clicking on a file in the explorer to open it?  Thx.

si así mismo era, pero ya gracias a Dios no hace..


Dask XGboost impossible to reproduce same results

I´m using dask for implementing a data pipeline with dask dataframes and dask ml in a Yarn Cluster.
When I build an XGBoost model, the results are always different, even if I manually fix a seed with da.random.seed().
import dask_xgboost as dxgb

params = {'objective': 'binary:logistic', 'n_estimators': 420,
           'max_depth': 5, 'eta': .01,
          'subsample': .8, 'colsample_bytree': .8,
          'learning_rate': .05, 'scale_pos_weight': 1}

bst = dxgb.train(client, params, fitted.transform(X), y)

Is it possible to reproduce the results of a dask model like the one in local using sklearn instead of dask ml???

The problem is when I run the model in cluster mode (not local). It´s a Yarn Cluster as I mentioned before.

Closing, as double posted in the dask-xgboost repo: https://github.com/dask/dask-xgboost/issues/37. Will continue discussion there.


Text Overlay Size

This is a really useful node so thank you so much for your work.
One issue I've found is that when posting a text overlay the set font size is overridden to the smallest. On my setup this is too small to be useful so I'm not really able to use this feature.
I think it would be helpful if the sizes (for me 16x16, 32x32, 64x64) could be specified in the node as I assume this must already be being in the data posted (or perhaps it's not and DVRs that support multiple sizes are defaulting to [0] which is 16x16)?
There is also a setting for flashing and/or transparent text which would be pretty useful if it could be added.
Settings on my DVR, per camera:

Hi Deggle
the ISAPI documentation doesn't even mention the font size, so i must dig into the internet and find a way to do this.
I'll take a look.

Hi Deggle
the ISAPI documentation doesn't even mention the font size, so i must dig into the internet and find a way to do this.
I'll take a look.

Thanks for taking the time to look into it. Let me know if I can do anything to help.
I'm not sure if the element names in the web GUI align with the ISAPI info, but in case it's useful:

Thanks for taking the time to look into it. Let me know if I can do anything to help.
I'm not sure if the element names in the web GUI align with the ISAPI info, but in case it's useful:

Mmm... yes and no, but thank you anyway... i maybe found an old API document mentioning this.
Stay tuned. If possible, i'll push a new version already today.

Mmm... yes and no, but thank you anyway... i maybe found an old API document mentioning this.
Stay tuned. If possible, i'll push a new version already today.

Sorry for the delay
i had to fix some issue first with TTS-Ultimate.
I'll work on that tomorrow.
Sorry for that!

Sorry for the delay
i had to fix some issue first with TTS-Ultimate.
I'll work on that tomorrow.
Sorry for that!

I had the same too.  I fixed it myself, but I don't know is a common solution for other cameras/DVRs
For my DVR  must be sent a frame started
<VideoOverlay version="1.0" xmlns="http://www.hikvision.com/ver20/XMLSchema"> <fontSize>1</fontSize> <TextOverlayList size="6"> <TextOverlay version="1.0" xmlns="http://www.hikvision.com/ver20/XMLSchema"> <id>1</id>
This is config for 32x32 size.
Below is my modified hikvisionUltimateText.js:
hikvisionUltimateText.js.txt
So I think the complete must be started at <VideoOverlay....> xml tag.

I had the same too.  I fixed it myself, but I don't know is a common solution for other cameras/DVRs
For my DVR  must be sent a frame started
<VideoOverlay version="1.0" xmlns="http://www.hikvision.com/ver20/XMLSchema"> <fontSize>1</fontSize> <TextOverlayList size="6"> <TextOverlay version="1.0" xmlns="http://www.hikvision.com/ver20/XMLSchema"> <id>1</id>
This is config for 32x32 size.
Below is my modified hikvisionUltimateText.js:
hikvisionUltimateText.js.txt
So I think the complete must be started at <VideoOverlay....> xml tag.

Hi Xuri
nope, this isn't standard, as ISAPI tell to do this in other way.
You suggestion didn't work for neither my NVR nor my cameras.
I'm doing what ISAPI documentation tells to do. Let's see what happens.

Hi Xuri
nope, this isn't standard, as ISAPI tell to do this in other way.
You suggestion didn't work for neither my NVR nor my cameras.
I'm doing what ISAPI documentation tells to do. Let's see what happens.

I've 4 ISAPI documents, and each one is telling a different way to do the same things.
I won't loose other time on that, but i found a solution for all you: i'll create an XML sender node, so you can freely send whatever XML you want.

I've 4 ISAPI documents, and each one is telling a different way to do the same things.
I won't loose other time on that, but i found a solution for all you: i'll create an XML sender node, so you can freely send whatever XML you want.

V. 1.0.30 is out with this new node.

V. 1.0.30 is out with this new node.

Hello,
Shame to not have the functionality in the existing node, but understand the approach - and the benefits when I start to look into ISAPI (not familiar at all yet). Thanks to @xury77 for the code tweak above as that helped get what I was initially doing to work!
Thanks again,
Tim

Hello,
Shame to not have the functionality in the existing node, but understand the approach - and the benefits when I start to look into ISAPI (not familiar at all yet). Thanks to @xury77 for the code tweak above as that helped get what I was initially doing to work!
Thanks again,
Tim


Unexpected Scroll

add perfect scroll bar in bootstrap popover( this popover contains form elements with labels )
when trying to select label and drag mouse to down
scroll bar start scroll infinitly all time to down -
and sometimes  in other direction

Hi,
Infinite scrolling is usually caused by padding, margin or absolutely positioned elements, all of which increase scrollHeight infinitely in some cases. So, you can start from checking these properties.
If you can't narrow down the reason, please feel free to ask me again. An example page or a fiddle which can reproduce the problem may be helpful.
Thanks :)

perfect-scrollbar  will bind the mousemove  by bindSelectionHandler when you have some selection.
You can read it for details.

Closed for inactivity. Please feel free to reopen.
Thanks!


Add max-idle param to RSetCache and RMapCache

splitted to several tasks https://github.com/mrniko/redisson/issues/373 and https://github.com/mrniko/redisson/issues/372 due to task complexity.


Running web extension-contributed commands in insiders.vscode.dev fails

Go to insiders.vscode.dev/github/microsoft/vscode
Run Open Remote Repository
:bug: nothing happens, see this error message in console

Externalized strings were not present in the environment.: Error: Externalized strings were not present in the environment.
    at s._executeContributedCommand (../../../vs/workbench/api/worker/extensionHostWorker.js:68:64568)

Reported by @kieferrm

I also see this preceding message in console:
Loading vscode-nls-web-data failed. Are you running this outside of VS Code? If so, you may need to intercept the import call with your bundled NLS data.

fixed in https://github.com/microsoft/vscode-remotehub/pull/524

Should be fixed in insiders now with latest Azure Repos pre-release. Needed to go back from 5.1.0 to 5.0.1 of vscode-nls. Thanks @TylerLeonhardt for the quick PR ✨


interactive visualizations

in the plotting section can we get the interactive visualization showing.
https://qiskit.org/documentation/plotting_data_in_qiskit.html#interactive-histogram-plots-for-jupyter-notebooks
If we can it would be nice to do it for all plot state types.

@JavaFXpert any thoughts on how this might be done?

To get the interactive widgets working in the Qiskit documentation , this page would need to be connected to a Jupyter kernel. Perhaps it would be good to use the same Jupyter backend that IQS uses, so that it is always on.
Regards,
James Weaver
On Fri, Feb 15, 2019, at 3:46 PM, Paul Kassebaum wrote:

@JavaFXpert https://github.com/JavaFXpert any thoughts on how this might be done?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Qiskit/qiskit/issues/99#issuecomment-464193080, or mute the thread https://github.com/notifications/unsubscribe-auth/AJee2n49d6Id772ZmDnfO3sm1VV5GLftks5vNxyOgaJpZM4a8092.

I dont think this is correct. If we say the data and since the interactive visualizations are in java script i think this can be done. @ismaelfaro or what you do you think.

In order for this to work there would have to be some png representation of the js object that can be stored. The ipywidgets have a store state option in the notebooks, but this only works in the notebooks as they are also JS.

I assumed that the goal was to make the widgets interactive in the Qiskit docs. Is the goal to just display static images of the interactive widgets in the Qiskit docs?
On Mon, Feb 18, 2019, at 10:29 AM, Paul Nation wrote:

In order for this to work there would have to be some png representation of the js object that can be stored. The ipywidgets have a store state option in the notebooks, but this only works in the notebooks as they are also JS.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Qiskit/qiskit/issues/99#issuecomment-464775317, or mute the thread https://github.com/notifications/unsubscribe-auth/AJee2rvcQlLsgOWAVXIRsMbzYgPJl-Ndks5vOsbOgaJpZM4a8092.

Currently they show nothing. So anything is an improvement. The problem is that we need some way of storing the js state from a notebook, to rst text, and then revive it in html for interactive to work. And all automatically. I am unuse has how to do this

@nonhermitian you are mixing two different things up. One is the addition to make it show in the qiskit tutorial and the other is to render on a webpage. Here let's focus on the webpage, not the qiskit tutorial.

after talking with @diego-plan9, I took a look to the .. raw:: html tag in Sphinx, and it seems that we could include in the docs the JS file of the visualizations so you would be able to write code blocks in the docs calling the javascript functions passing the data to plot them on an interactive way @diego-plan9, @carlosazaustre and Borja are going to give this approach a chance and create an example to see if it works and come back with the results

This is still a WIP but I think we can achieve. I need to work with the styles a little bit.
I will keep you updated.
Thanks @francabrera for the examples an the html tag recomendation in Sphinx.


postgreSql unix socket

I got an error,in my postgresDB,and the error likes billow
[2018/09/05 10:04:02][error] Database::PostgreSQL::Error: Dump Failed!
[2018/09/05 10:04:02][error]   Pipeline STDERR Messages:
[2018/09/05 10:04:02][error]   (Note: may be interleaved if multiple commands returned error messages)
[2018/09/05 10:04:02][error]
[2018/09/05 10:04:02][error]   pg_dump: [归档 (db)] 与数据库 "postgres" 联接失败: 无法联接到服务器: 不是目录
[2018/09/05 10:04:02][error]    服务器是否在本地运行并且在 Unix 域套接字
[2018/09/05 10:04:02][error]    "/tmp/.s.PGSQL.5432/.s.PGSQL.5432"上准备接受联接?
[2018/09/05 10:04:02][error]   The following system errors were returned:
[2018/09/05 10:04:02][error]   Errno::EPERM: Operation not permitted - 'pg_dump' returned exit code: 1
[2018/09/05 10:04:02][error]
when i try this commend in terminal (without backup) , it works.
PGPASSWORD=postgres /usr/bin/pg_dump --username=postgres --host='localhost' --port='5432'  moocdb
How can i fix this issue? thanks.

This is likely an issue with your file permissions, and seems unrelated to backup itself


Question: How to best handle images in css?

What's the best practice of importing and using images, especially when you want to use them as background images of elements.
For example:
If I use CSS in JS or Glamorous and point the url to an image under src folder, this image is never copied to dest and in such ends up with 404.
I know I can just put all images in the public folder, but it this the best way?

Follow up question:
When I import a svg file everything works fine in development, but when trying to run build, the process fails with errors trying to parse the svg file.

Working on a fix for this in the next release. Stay tuned.

Thanks!! Really looking forward. Re-builfing our website and prefer to do it with React-Static instead of Gatsby.

There is now import support for imagesm Fixed with the latest version. yarn upgrade react-static@2