Fragment::getUriComponent wrongly evaluate the component emptyness

I have this uri http://www.test.com?foo=bar#0 and want to merge/append this query string bar=foo.
The result is http://www.test.com?foo=bar&bar=foo0 which is obviously wrong.
It should be http://www.test.com?foo=bar&bar=foo#0.
I did not check the code but most likely its because 0 evaluates to false? ;)

@dmaicher thanks for reporting the bug. The bug was not on the MergeQuery modifier but on the Fragment component. A patch will be made available as soon as possible

Thanks for the fast reaction :+1:  :)

This bug fix will be made available in the next release

:+1:

version 4.1 is out with the fix included

:+1:  thx


Missing jQuery detection not working

If you fail to load jQuery you'll get TypeError: $ is undefined, or TypeError: g is undefined if you load the minified version.

Fix here: https://github.com/twbs/bootstrap/commit/0524944b584caf988888c64b9a531955ca8e2cee
But we'll have to do a proper v4 branch to merge that
/CC @XhmikosR

Yeah, on it. I will create a new branch and start cherry picking stuff, and we'll force push it to the current v4-dev.

Closing this since it's in the v4-dev-new branch, which well be pushed to v4-dev when I can force push it.


how to validate LISA-13B-llama2-v0?

I tried downloading the model and it has pytorch_model-000001-of-000003.bin, pytorch_model-000001-of-000003.bin, pytorch_model-000002-of-000003.bin, instead of of a single pytorch_model.bin.

However, when I tried to validate following the validation instruction using the command:
deepspeed --master_port=24999 train_ds.py \
  --version="models/LISA-13B-llama2-v0" \
  --dataset_dir='./dataset' \
  --vision_pretrained="sam_vit_h_4b8939.pth" \
  --exp_name="lisa-7b" \
  --weight='models/LISA-13B-llama2-v0/pytorch_model.bin' \
  --eval_only

and met file not found error. Passing --weight='models/LISA-13B-llama2-v0/ gives error too. What did I do wrong? How can I get a single pytorch_model.bin that can be passed for the weight argument?

Please ignore the weight argument, and in the latest version of the repo, there is no weight argument in the train_ds.py file.


ensure that each src/schema YAML file can be re-generated in isoloation

gen-linkml 1>/dev/null
next step: gen-owl
see also
#1886

see

https://github.com/microbiomedata/nmdc-schema/issues/1885


Use P/Invoke for os.strerror

Besides producing correct error message on Linux and macOS, the main benefit is the elimination of the switch on constants from PythonErrorNumber. The values in module errno vary depending on OS so cannot be implemented as constants.
On Windows, P/Invoke calls into ucrtbase, which may not be available on Windows 7 by default. I don't know if IronPython is still supposed to support Windows 7, if so, the the WIX installer may have to install msvcrt on that system.
This PR also contains a few small fixes of Mono.Unix usage (ref. https://github.com/IronLanguages/ironpython3/pull/1490#issuecomment-1157003535)
On a side note: I'm wondering if it wouldn't be cleaner to factor module posix out of nt (and putting common functionality in an additional static class, e.g. PythonOS).

Sorry for the delay in reviewing. Am away from my dev PC for the week so just doing this on my phone.
Microsoft isn't supporting win7 so I don't see why we should (although apparently a lot of people are still using it). Is there no API that can give us the same result without ucrtbase? How does the pinvoke call on Windows compare to new Win32Exception(errorCode). Message? Interestingly they're adding Marshal.GetPInvokeMessage(errorCode) to .NET 7. In any case, if it's too much effort then too bad for win7...
As for the split posix/nt modules I'm not opposed to it - though it may be hard to untangle. We have issue #266 which is suggesting the same.

Microsoft isn't supporting win7 so I don't see why we should (although apparently a lot of people are still using it).

Fine with me. A helpful note in a readme, release notes or something to install the needed library should be sufficient.

Is there no API that can give us the same result without ucrtbase?

Not that I am aware of. Of course, it is always possible to run a script and generate code that has all Windows messages hardcoded. Looks like a waste of memory to me but it would remove the dependency. Another (marginal, untested) benefit of using ucrtbase is that it should produce different messages depending on locale.

How does the pinvoke call on Windows compare to new Win32Exception(errorCode). Message?

Win32Exception(errorCode).Message gives the message for Windows error (aka winerror), while the p/invoke call I introduced gives the message for C error (aka errno). PythonExceptions._OSError.WinErrorToErrno can convert from winerror to errno but there is no way to unambiguously convert in the opposite direction, simply because winerror is more specific.
For instance winerror ERROR_FILE_NOT_FOUND (value 2) has message The system cannot find the path specified.; ERROR_PATH_NOT_FOUND (value 3) has message The system cannot find the path specified.. However both, plus some six more winerror codes are mapped to errno ENOENT (value 2), which has message No such file or directory.

Interestingly they're adding Marshal.GetPInvokeMessage(errorCode) to .NET 7.

I didn't know that; too bad it comes so late. Luckily all supported Windows versions have ucrtbase (if I am not mistaken).

As for the split posix/nt modules I'm not opposed to it - though it may be hard to untangle.

Yes, it may be. The main reason I brought it up is that any time Mono.Unix is used it is being factored out to a separate method, with a comment Isolate Mono.Unix from the rest of the method so that we don't try to load the Mono.Unix assembly on Windows. I have been following this approach in my changes though I do not fully understand the mechanics; if I don't factor the code out it still seems to work OK. As module posix gets more complete, this approach may create quite some clutter.

I have been following this approach in my changes though I do not fully understand the mechanics; if I don't factor the code out it still seems to work OK.

I think this only occurs outside of the dev environment since the Mono.Unix dll isn't packaged on Windows. Although I haven't checked this since we switched from Mono.Posix to the Mono.Unix package.


Improve working with folds

Hi,
I've been looking into making working with folds a bit smoother to fix #8023.
The functionality in this PR:

Allows the end of the fold line on the screen to represent the end of the fold in the buffer. This makes us able to delete up until the boundaries of folds.
More conservative fold expansion: only expand a fold when necessary.
More conservative deletion: removed some cases where the entire fold would be deleted.

Let me know what you think!
I'm pretty new to CoffeeScript so any comments are welcome!
A demo:

/cc @nathansobo - This looks like very nice, but it seems like it will be subsumed by your display-layer work. Not sure if it's worth taking on the risk of changing this system in the interim while that work is going on. Could you take a quick :eyes: at this?

In case you're considering merging this, I was also wondering if it would be better to set the invalidation strategy of folds to inside. This would help with, for example, deleting from the start to the end of the fold. The markers would also become exclusive automatically.


WIP: Add pg_tracing extension

The extension is brand new, no tagged releases yet.
Created a PR to get a build to staging for testing. Do not merge!

Let's merge this. This requires superuser to install, and needs to be added to shared_preload_libraries, so just by having it present in the compute image won't make it usable to anyone. But it makes it easier for us to develop and play with.


/504 responds with 200 instead of 504

% curl https://httpstat.us/504 -i
HTTP/1.1 200 OK
Server: Kestrel
Request-Context: appId=cid-v1:1e93d241-20e4-4513-bbd7-f452a16a5d69
Strict-Transport-Security: max-age=2592000
Set-Cookie: ARRAffinity=a9cebb550e254ba9270d015acd372767c78fa4f3f79fc353fb793f2912e673b3;Path=/;HttpOnly;Secure;Domain=httpstat.us
Set-Cookie: ARRAffinitySameSite=a9cebb550e254ba9270d015acd372767c78fa4f3f79fc353fb793f2912e673b3;Path=/;HttpOnly;SameSite=None;Secure;Domain=httpstat.us
Date: Tue, 29 Mar 2022 20:40:18 GMT
Content-Length: 0

/500 and /404 work fine. Perhaps this is a limitation of the hosting platform?
Thanks very much for this service.

Currently expected due to https://github.com/aaronpowell/httpstatus/issues/89#issuecomment-705978272
Once I get some time to finish off the #97 I'll revisit that workaround

Ah, understood, and thanks. I should have searched the closed issues for the same thing.


Bug: framework.Reconciler reconciles against unmanaged child batch/job

What happened:
The framework.Reconciler reconciles against child batch/job even if the batch/job isn't managed by kueue.
So, the kueue-controller-manager forcefully stops the unmanaged running child batch/job, and then the batch/job is dead.
https://github.com/kubernetes-sigs/kueue/blob/8a0d088e43adbc6a5bcf574aa882ef24d06c0921/pkg/controller/jobframework/reconciler.go#L110-L115
This happens when the following conditions are met:

Set manageJobsWithoutQueueName=false to kueue-controller-manager.
Users don't set queue names to parent jobs(e.g., MPIJob).
The batch/job is child one.
enable to watch both of parent job (MPIJob) and child job like the following:

...
integrations:
  frameworks:
  - "batch/job"
  - "kubeflow.org/mpijob"

What you expected to happen:
The framework.Reconciler ignores the unmanaged child batch/job.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): v1.25.5
Kueue version (use git describe --tags --dirty --always): v0.3.1
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign

Through more investigating, I found that the kueue-controller adds an annotation to indicate parent workload even if the parent job (e.g., MPIJob) doesn't have a queue name.
https://github.com/kubernetes-sigs/kueue/blob/433881616b83eb495e0b6b5b82c68f5c4aadf910/pkg/controller/jobs/job/job_webhook.go#L63-L72
Ideally, we shouldn't add an annotation to the child batch/job if kueue doesn't manage the parent job. But, during webhooks, it is complicated to add the annotation to the child job, considering whether Kueue manages the parent job.
So, it would be better to define standaloneJob as a job that doesn't have an annotation to indicate a parent workload, or that has an annotation to indicate a parent workload even if the parenting workload doesn't exist in the cluster.
https://github.com/kubernetes-sigs/kueue/blob/433881616b83eb495e0b6b5b82c68f5c4aadf910/pkg/controller/jobframework/reconciler.go#L108
@alculquicondor What do you think?

cc: @kerthcet

In the current implementation, if the child job meets the following conditions, kueue-controller-manager doesn't skip to reconcile.

Set manageJobsWithoutQueueName=false to kueue-controller-manager.
Users don't set queue names to parent jobs(e.g., MPIJob).
The batch/job is child one.
enable to watch both of parent job (MPIJob) and child job

https://github.com/kubernetes-sigs/kueue/blob/433881616b83eb495e0b6b5b82c68f5c4aadf910/pkg/controller/jobframework/reconciler.go#L110-L115
So, the kueue-controller-manager suspends the unmanaged child batch/job in the following parts:
https://github.com/kubernetes-sigs/kueue/blob/433881616b83eb495e0b6b5b82c68f5c4aadf910/pkg/controller/jobframework/reconciler.go#L291-L293

Uhm, just skipping the following processes might be better when the parenting workload doesn't exist in the cluster.
https://github.com/kubernetes-sigs/kueue/blob/433881616b83eb495e0b6b5b82c68f5c4aadf910/pkg/controller/jobframework/reconciler.go#L291-L293

So, it would be better to define standaloneJob as a job that doesn't have an annotation to indicate a parent workload, or that has an annotation to indicate a parent workload even if the parenting workload doesn't exist in the cluster.

I think this line is wrong
https://github.com/kubernetes-sigs/kueue/blob/433881616b83eb495e0b6b5b82c68f5c4aadf910/pkg/controller/jobframework/reconciler.go#L112
It's correct for standalone jobs. But for child jobs, we should be checking if the parent has a queue name. If it doesn't we should skip.

You're right.
I was thinking of a way not to check a parent job. But your suggested way sounds much more reasonable.

It's correct for standalone jobs. But for child jobs, we should be checking if the parent has a queue name. If it doesn't we should skip.

+1, another topic is do you think we should not reconcile the child job at all, leave the control to its parent job, then if it's a child job, we'll skip directly.

do you think we should not reconcile the child job at all, leave the control to its parent job, then if it's a child job, we'll skip directly.

I don't have use cases that would reconcile the child Job. However, since the kueue-controoler suspends the child job instead of the framework job controller, reconciling the child jobs might be useful for the framework jobs without suspend semantics.

If the parent CRD didn't implement the semantics correctly, we want to stop the child Job from running.

If the parent CRD didn't implement the semantics correctly, we want to stop the child Job from running.

In my opinion this is a very strange pattern, if the parent, CRD  didn't implement the semantics correctly how can have a working integration for it?
I think we should not touch any job that has a parent manageable by kueue.


FFI

This needs design.
What do you import?
How do you import it?
Preferably you can use PureScript FFI modules as-is, so we'll likely want something like that ABI.

Here is an example of what I have in mind:
// foreign "foo" imports "foo" CommonJS module and returns its exports as a record
let $f:any = foreign "./foreign.js" in
$f:any.add(1:int32, 2:int32)

BUT! How will this work with e.g. CLR? foreign "mscorlib.dll/System.Console"?


Error while running data script

I am trying to run the data script for CK+ dataset with python 2

python make_ck_plus_dataset.py --input_path "E:\CK+" --save_path E:\approach1_april_10\data

It gives the following error:

Traceback (most recent call last):
File "make_ck_plus_dataset.py", line 459, in
numpy_file_generator.run()
File "make_ck_plus_dataset.py", line 298, in run
num_samples)
File "make_ck_plus_dataset.py", line 332, in make_data_label_mats
y[index_slice] = label_vec
ValueError: could not broadcast input array from shape (4) into shape (3)

What am I doing wrong?

Hi.
When you run the code what is in the CK+ folder? The CK+ folder should contain the following:
CK_Agreement_Form.pdf
extended-cohn-kanade-images.zip
Consent-for-publication.doc
CVPR2010_CK.pdf
Emotion_labels.zip
FACS_labels.zip
ReadMeCohnKanadeDatabase_website.txt

I ran the code again and it was able to generate the dataset. I've included a copy of the conda environment I used as a zipped yaml file. You can try using it to set up your environment
environment.yml.zip. Hope this helps!

Thanks
I was able to correct it, a system specific problem.
You can close the issue

@amogh112 @pkhorrami4
I am having the same problem. This is my folder structure.

And when I open cohn-kanade-images, there are subject folders. The same with Emotion_labels.
Any help would be appreciated.
Thanks

@amogh112 It is happening inisde S506 folder. It has four folders then inside.

Would it affect the data that is generated if I ignore the error and move on to the next iteration?

Also, those four folders inside S506 have more than 10 images each.

The cropped images are being saved in cohn-kanade-images/S506/006, where instead of 4 only 3 images were saved. So I just made a copy of one of the images in it. Yeah, 5 folders were lost. You would have to see why images aren't being cropped and saved. Sorry, can't help you with that. Please share your solution if you end up doing it.

@amogh112 i am facing this error can you help me ?
Condensed CK+ Dataset Statistics:
Total Number of Image Sequences: 327
Total Number of Label Sequences: 327
Number of sequences with correponding label .txt file: 327
Total Number of Subjects: 118
Number of image files: 1307
Detecting and Cropping Faces
C:\Users\nomi\Anaconda3\lib\site-packages\skimage\transform_warps.py:84: UserWarning: The default mode, 'constant', will be changed to 'reflect' in skimage 0.15.
warn("The default mode, 'constant', will be changed to 'reflect' in "
Missed the face!
Missed the face!
Missed the face!
Missed the face!
Missed the face!
Traceback (most recent call last):
Missed Faces:  ['./CK_PLUS_HERE/cohn-kanade-images\S010\002\S010_002_00000012.png', './CK_PLUS_HERE/cohn-kanade-images\S010\002\S010_002_00000013.png', './CK_PLUS_HERE/cohn-kanade-images\S010\002\S010_002_00000014.png', './CK_PLUS_HERE/cohn-kanade-images\S042\002\S042_002_00000014.png', './CK_PLUS_HERE/cohn-kanade-images\S076\001\S076_001_00000015.png']
File "D:/Masters/Research/dexpression-master/make_ck_plus_dataset.py", line 455, in
face_cropper.run()
File "D:/Masters/Research/dexpression-master/make_ck_plus_dataset.py", line 199, in run
self.crop_and_align_all_faces(self.image_path)
File "D:/Masters/Research/dexpression-master/make_ck_plus_dataset.py", line 227, in crop_and_align_all_faces
self.write_list_to_file(missed_faces_file_path, missed_faces)
File "D:/Masters/Research/dexpression-master/make_ck_plus_dataset.py", line 204, in write_list_to_file
f.write(item + '\n')
TypeError: a bytes-like object is required, not 'str'
i am unable to generate .npy file of dataset due to this face crop error.

@amogh112 Thank you for your question. I encountered the same problem as you but I can't fix it. Could you please tell me how you correct it? I would really appreciate it! Thank you:)


Allow panning

When zoomed in, user should be able to pan around (ie. with the "hand" tool) instead of scrolling.

Since Page component is now a simple image, maybe we can simply use React Draggable


Feature/UIPSetting update

@AlexanderBazukevich @PolinaVolchetskaya @nattallius @ala-n

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Missing EV charger power and state

Hello Charles,
I'm missing the actual EV charger power along with charger state like:

Is that something you could potentially implement?
Thanks,
Frank

The Alpha OpenAPI at https://open.alphaess.com/developmentManagement/apiList does have getEvChargerStatusBySn  which returns the charger state, there's also getEvChargerCurrentsBySn  - does that return the power metric that you are looking for?
I don't have either of those currently used in my python library, I don't have a charger to test with but if you would be open to volunteering to do some testing I'm sure that I could add both of them relatively easily.

Certainly I could help here as I have an AlphaESS Charger type 'SMILE-EVCT11'. And I have experience in using the ioBroker adapter provided by Gaspode69 at https://github.com/Gaspode69/ioBroker.alpha-ess/tree/main . Since version 1.3.0 this is supporting the wallbox based on OpenAPI.

I will see whether I can work on it on Sunday. Today, no chance...

This would be really great! I am happy to help with testing if necessary.

Hi @CharlesGillanders, @Poshy163, I almost forgot that I provided the details (response from OpenAPI) some time back already to Gaspode69 in Storion4You forum. Based on the information available here  he implemented the EV charger in the ioBroker AlphaESS adapter. Would this information be sufficient? I guess so.
If required I would translate that from German to English but Google Tranlator should do was well...

Cheers for that @farmer1969 so the only data you are looking at using is the  "currentsetting"?

Not really, I think I should extend the information...
Please refer to the script in #13.
As there are (refer to https://open.alphaess.com/developmentManagement/apiList):

getEvChargerConfigList ==> Obtain the SN of the charging pile according to the SN, and set the model
getEvChargerCurrentsBySn ==> Obtain the current setting of charging pile household according to SN
setEvChargerCurrentsBySn ==> Set charging pile household current setting according to SN
getEvChargerStatusBySn ==> Obtain charging pile status according to SN+charging pile SN
remoteControlEvCharger ==> According to SN+ charging pile SN remote control charging pile to start charging/stop charging
getChargeConfigInfo ==> According SN to get charging setting information
updateChargeConfigInfo ==> According SN to Set charging information，Setting frequency 24 hours, set once a day

All that shall be provided through the AlphaESS integration for use through HA.

Hi @CharlesGillanders, @Poshy163, is the above anything you can work with?
Thanks, Frank

Guten Tag, ich würde mich gerne als Tester zur Verfügung stellen.
Ich besitze die SMILE-G3-EVCT11

Hey there, sorry for the late response,
Yeah im able to implement this, thing is, its going to make the startup time for the integration very long, as alpha has enforced a limit of 10 API calls per minute, and currently we are at 8 on startup, adding these 4 will bring it to 12, which means those 12 will need to be throttled at 10 per min, so it will take ~1:12 to fully start up the integration which home assistant does not like at all (throws slow start up warnings and hangs HA until setup is complete)
I am currently working on a PR to add this stuff, and i also have a ticket open with alpha to see if we can get the rate limit eased a bit. but not sure how successful that will be as the API team that develop it/maintain it seem to be in limbo at the moment

Isn't there any option to proceed for the startup as is (with only 8 API calls) and set a time-based trigger to do the rest 1-2 min later...?


[Feature Request] Add option to support updating history file even with

Sometimes,  just run fzf for previewing without do any action. While still want to record the query into history file.

If query could be exposed like {}, could use execute to accomplish this.

If query could be exposed like {}

It's {q}.
fzf --history /tmp/fzf --bind 'ctrl-c:execute(echo {q} >> /tmp/fzf)+abort'


lint-commit job isn't run for PRs without code changes

After #4092 checking of commit messages isn't run for DOCS PRs. #4152 for example

@prutskov Good catch, we should fix ASAP.


Backend cleanup

I added a commit that removes the need for the central_state file for a local backend. This file just acted as a index for some of the information about all the resource states. I removed it because it was causing issues when multiple people were working on the same git repo in regards to merges. We can just compute this information during the init for the local backend and not have to actually change  much of the business logic.
I add *args and **kwargs to the init that was the object remains backwards compatible with the previous function signature.
I tested it out with all the different operations in a demo project and all the unit test are passing still.


Listener Positions don't seem to update regularly

Unsure how often listener positions are meant to update, but during a flight today I didn't see them updating - I had to refresh the page for new listeners to appear on the map.

Possibly fixed?

Yep, this is fixed :-)


Checkbox Fix Release

Hi, I noticed the issue with your last release and how true/false is being set on your checkboxes.  I was curious when you intend to tag/release that fix? We need it for the project I am working on.

Hi @sgrady,
I've fallen really behind on this project because of my day job. (I joined a startup recently and it's taking the majority of my focus.) You are correct that a release is all that's needed to address this issue.
I've just created release 4.1.4 which contains several nice additions by @indrimuska


[Bug]: Fly Deployment on jokes app doesn't detect SQLite

Which Remix packages are impacted?

[X] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[ ] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
^1.1.1
What version of Node are you using? Minimum supported version is 14.
v16.13.0
Steps to Reproduce
Run the following command on the jokes tutorial deployment section:
fly launch

Expected Behavior
I expected fly to automatically detect sqlite from my prisma configuration and create a fly volume:
Created a 10GB volume vol_18l524yj27947zmp in the dfw region

Actual Behavior
The fly cli created the app and wrote the config file without creating a volume.
Created app remix-jokes-jame2 in organization personal
Wrote config file fly.toml

I did the tutorial yesterday (with remix v1.1.3 and flyctl v0.0.292) and the Fly.io project creation detected the sqlite db for me.
I think this is rather handled by flyctl though. Maybe somewhere here, but that part of their code has not changed for the previous two months.

The issue for me was here:

Remix can be deployed in a large and growing list of JavaScript environments. The "Remix App Server" is a full-featured Node.js server based on Express. It's the simplest option and it satisfies most people's needs, so that's what we're going with for this tutorial. Feel free to experiment in the future!

I selected the Remix App Server at the beginning as the tutorial said. I created a new app and selected "Fly" this time and copied over all the code, and the deployment went flawlessly.
I would recommend we change the docs so that people select "Fly" since the tutorial is deploying to that. I could make that change if nobody else wants to.!


Implement Check session endpoint & add Silent renew

done

https://github.com/robisim74/angular-openid-connect-php/commit/cce2da2dcaec3b0f9ab7f387c51658f73d509fde
https://github.com/robisim74/angular-openid-connect-php/commit/b3051ee101575c9e91ee0f093d3dff3a4d728f11


chore: Send applicationDetail in create application payload

Description

Add the applicationDetail payload to the create application request.
This allows instances which have Anvil enabled, to default to Anvil when an application is created.

PR fixes following issue(s)
Fixes #28237
Type of change

Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

[x] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress - If all existing tests pass, we're good to merge

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test


uuid() blueprint method creates a char(36) column instead of binary(16)

I am using v1.3.0 of this package with Laravel v5.6.39.
According to the docs, $table->uuid('uuid')  is supposed to create a binary(16) column in database, but for some reason a char(36) is created instead.
I am changing database connections on the fly, so maybe that's the problem? Maybe the override behavior of Laravel's uuid() method is not working or something is not registering correctly?

It sounds like the service isn't loaded correctly. Our service provider will register the custom grammar on boot: https://github.com/spatie/laravel-binary-uuid/blob/master/src/UuidServiceProvider.php
My guess is that by changing the connection on the fly, you'll also have to manually override the grammar for that connection.
Unfortunately this package doesn't explicitly support this feature, so I'll be closing the issue. If you find a solution for the problem though, you're free to send a PR.


bug: Terraform can not read role assignment created along subscription using module

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions
terraform {
required_version = ">= 1.5.5"
backend "azurerm" {
use_azuread_auth = true
}
required_providers {
azurerm = {
source  = "hashicorp/azurerm"
version = ">= 3.74.0"
}
}
}
Please paste the output of terraform version command from within the initialized directory:
- Using previously-installed hashicorp/random v3.6.2
- Using previously-installed azure/azapi v1.13.1
- Using previously-installed hashicorp/azuread v2.51.0
- Using previously-installed hashicorp/azurerm v3.107.0
- Using previously-installed hashicorp/time v0.11.2

Please enter the module version that you are using:
  source                                            = "Azure/lz-vending/azurerm"
  version                                           = "3.4.1"

Description
Steps to Reproduce
create subscription and create role assignment for it, the role assignment is created.
tf

plan

apply
│ Error: loading Role Assignment "/subscriptions/xxxxx-xxxx-xxxx-xxxx-xxxxx/providers/Microsoft.Management/managementGroups/st-sandboxes/providers/Microsoft.Authorization/roleAssignments/xxxxx-xxxx-xxxx-xxxx-xxxxx": authorization.RoleAssignmentsClient#GetByID: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidApiVersionParameter" Message="The api-version '2020-04-01-preview' is invalid. The supported versions are '2024-03-01,2023-07-01,2023-07-01-preview,2023-03-01-preview,2022-12-01,2022-11-01-preview,2022-09-01,2022-06-01,2022-05-01,2022-03-01-preview,2022-01-01,2021-04-01,2021-01-01,2020-10-01,2020-09-01,2020-08-01,2020-07-01,2020-06-01,2020-05-01,2020-01-01,2019-11-01,2019-10-01,2019-09-01,2019-08-01,2019-07-01,2019-06-01,2019-05-10,2019-05-01,2019-03-01,2018-11-01,2018-09-01,2018-08-01,2018-07-01,2018-06-01,2018-05-01,2018-02-01,2018-01-01,2017-12-01,2017-08-01,2017-06-01,2017-05-10,2017-05-01,2017-03-01,2016-09-01,2016-07-01,2016-06-01,2016-02-01,2015-11-01,2015-01-01,2014-04-01-preview,2014-04-01,2014-01-01,2013-03-01,2014-02-26,2014-04'."
Additional context
not sure if related but running from local shell give (I have owner permission)
│ Error: reading Subscription Alias "it-sandbox": subscriptions.SubscriptionsClient#AliasGet: Failure responding to request: StatusCode=401 -- Original Error: autorest/azure: Service returned an error. Status=401 Code="UserNotAuthorized" Message="User does not have access Microsoft.Subscription/aliases/write over scope providers/Microsoft.Subscription/aliases/it-sandbox"
│
│   with module.sandbox_subscriptions["itsbx"].module.subscription[0].azurerm_subscription.this[0],
│   on .terraform\modules\sandbox_subscriptions\modules\subscription\main.tf line 2, in resource "azurerm_subscription" "this":
│    2: resource "azurerm_subscription" "this" {

Hi,
Please can you tell me the relative scope you supplied to the role assignment?

Reason I ask is that all role assignments are relative to the subscription scope.
It seems like you want to create a role assignment at management group scope. If you want to do this you will have to do it outside the module.
See docs here:
https://github.com/Azure/terraform-azurerm-lz-vending?tab=readme-ov-file#input_role_assignments

Yes, i was trying to do so. How do you mean doing it outside the module? should i create a separate role assignment för that?

Any idea about the second error message?

Yes, i was trying to do so. How do you mean doing it outside the module? should i create a separate role assignment för that?

Yes, create the role assignment in your main.tf, or similar.

Any idea about the second error message?

I suspect that the error will go away once you fix the role assignment issue

I removed the role assignment from state file since it could not find it was created in portal, so that issue has gone, but by mistake the subscription was deleted from state file, so if i try to import it back or if i run plan from my local, the same error will keep showing up (the error about subscription alias )

I would recommend the at you never remove anything from the state file.
Terraform now has import and removed blocks to achieve the same.
Importing the alias resource is difficult. I would recommend configuring the module with the existing subscription id and managing the sub as if it was not created by this module.


How to save an image along with the annotations?

Suppose I did mark some things using a box in the image, and now I want to save/export/download that image along with that box. How can we do that?

Any answer for this question?

@nadavof You can use canvas to redraw the image and caption frame then export it as an image

Hi guys, I've got the same issue, So I code it like this:

Create canvas element into the HTML and also get element in the script (js)

Draw with that canvas (with getContext("2d") functionality)

Load an image which I'm using canvas background

forEach region where can I have boxes/sizes/etc.

Export canvas to the image/jpeg format (base64)

Briefly, I'll share with you what I wrote on my project and enjoy it.
const canvas = document.getElementById("myCanvas")
const ctx = canvas.getContext("2d")

const image = new Image()
image.src = imageUrl
image.crossOrigin = "Anonymous"
image.onload = () => {
      ctx.drawImage(image, 0, 0, canvas.width, canvas.height)

      output.images[0].regions.forEach((obj) => {
        ctx.strokeStyle = obj.color
        ctx.lineWidth = 2
        ctx.strokeRect(
          obj.x * canvas.width,
          obj.y * canvas.height,
          obj.w * canvas.width,
          obj.h * canvas.height
        )

        ctx.font = "20px Arial"
        ctx.fillStyle = obj.color
        ctx.fillText(1, obj.x * canvas.width, obj.y * canvas.height - 10)

        ctx.globalAlpha = 0.2
        ctx.fillStyle = obj.color
        ctx.fillRect(
          obj.x * canvas.width,
          obj.y * canvas.height,
          obj.w * canvas.width,
          obj.h * canvas.height
        )
})

const dataURL = canvas.toDataURL("image/jpeg")

I'm using this function on the onExit param in Annotator

@asyncfinkd  I achieve the download task by doing this.
    const downloadAnnotatedImage = () => {
        const divElement = document.getElementById('image-container');
        const svgElement = document.getElementById('region-svg');
        html2canvas(divElement, {
            width: svgElement.getAttribute('width'),
            height: svgElement.getAttribute('height'),
        }).then(canvas => {
            const dataURL = canvas.toDataURL('image/png');
            const link = document.createElement('a');
            link.href = dataURL;
            link.download = 'downloaded-image.png';
            document.body.appendChild(link);
            link.click();
            document.body.removeChild(link);
        });
  };

Here, image-container is the wrapper that wraps the canvas and  svg image.  You can check my work here.


btcatomicswap auditcontract from output address (redeem address)

The btcatomicswap utility takes in a contract and contract transaction as the arguments in a format of long hexstrings.
Example:
btcatomicswap --testnet auditcontract<PHONE_NUMBER>a820dca04d3bb2332d9441964798c846d00d892d8d7dcf8a0cd02ede232dcf12a0298876a9141205a71bca338c827ab7e983fa877d0df4ea068e670423b8065bb17576a914d4cad03b36abd5e2e890dce6d7902abba06d28dc6888ac<PHONE_NUMBER>01019f3388b5ab5853b0c456e0da1391f5f5c476495e9d4f58c31f760481f52e8f1e0000000017160014504058af6af2ead87d4e347f51ec09263f7f2bfbfeffffff02a08601000000000017a914c1adc9411f7b87353459b2f2b4d2c5fcccb4528e878850f6000000000017a914c7068e75c1e873181d66e538ad5e9b779294be748702473044022024c94c68e6a8bb35bfa74a1563e148bfb751dc52d7cde2853c67d6b82e26aa79022068ee09f68d36ca53507a85fa0ab4b7067db60a5839bc2996a089e23d3bfce1b90121028e7966a869b77aa7da4254779317ce8a4ac5c824c605fea2aec0aaa814e8250b00000000
For an automation of atomicswaps we are implementing we'd like to be able to perform an audit given a simple output address, that we can find in a confirmed contract transaction via block explorer.
Example:
btcatomicswap --testnet auditcontract 2N1y1Jh5pv7uY5atXYpvV4quqLZuFkjJ37C

Sorry, but we're not going to make external calls to a block explorer from these tools.  They will only integrate with your wallet.  Your suggestion also leaves an ambiguity as there can be many transactions that all pay to the same contract address.

In addition, the address alone, even with a specific transaction paying to the contract, is not capable of being audited.  The address is P2SH and auditing the contract requires the actual nested script.  The address does not contain this script, it only contains a hash.

Okay. How would I go about making sure that what I audited with this tool matches a mined transaction on the blockchain?

That responsibility is on you.  You pick where the data comes from (your own full node would be the most secure) and simply feed it to the tool to check.


Fix the crash at the end (issue #476)

Fix a crash at the end
Fixes #476
Task List

[ ] Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
[ ] Implemented the source code change that satisfies the tests
[ ] Documented the feature by providing worked example
[ ] Updated the README or other documentation
[ ] Completed the pre-Request checklist below

Change Description
I fix the crash at the end by replacing the destructor of Timer (in Timer.hpp). This seems to work, but I wonder if there are side effects because there are two constructors, Timer() and Timer(const Key& rootKey), and because the destructor is no longer a virtual function.

Test Description
Run cmake with CMAKE_BUILD_TYPE=Release, and compile the model from scratch. Run either the thermodynamics or june23 integration tests. These should run to the end, but end with a segmentation fault (signal 11).

Documentation Impact
None

Other Details
None

Pre-Request Checklist

[ ] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[ ] No new warnings are generated
[ ] The documentation has been updated (or an issue has been created to track the corresponding change)
[ ] Methods and Tests are commented such that they can be understood without having to obtain additional context
[ ] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[ ] File dates have been updated to reflect modification date
[ ] This change conforms to the conventions described in the README

Is it the lack of virtual or the reset() call that fixes the crash? Or are both changes necessary?

Good point! I thought it was the reset() call that fixed things, but it's in fact removing virtual that does it. I.e.
    ~Timer() = default;

works, and so does
    ~Timer() { reset(); }

but both
    virtual ~Timer() { reset(); }

and
    virtual ~Timer() { reset(); }

give a crash at the end. Which also means that I don't understand what's going on. I thought that calling reset() would clear the memory so that we could have a clean exit.

Good point! I thought it was the reset() call that fixed things, but it's in fact removing virtual that does it.

That does suggest a deeper problem with how I am using the class. I'll take a look and see if I can see anything obviously wrong. If I can't find anything, then we can just push the non-virtual version.

Good point! I thought it was the reset() call that fixed things, but it's in fact removing virtual that does it.

That does suggest a deeper problem with how I am using the class. I'll take a look and see if I can see anything obviously wrong. If I can't find anything, then we can just push the non-virtual version.

Not a flippin´scooby.


[Backtracing] Bail out earlier for privileged binaries on macOS.

Also remove the code that deals with file descriptors; we will now only start the backtracer for processes that have the get-task-allow entitlement, which means that they've been specifically signed for debugging, and that means that it is no longer critical to ensure that unexpectedly inherited fds are closed.
rdar://137551812

@swift-ci Please test

Explanation: This is a belt & braces improvement for the backtracer's security; instead of relying on the swift-backtrace process to check for some of the privileged types of program, we check up front in the runtime. We weren't doing this originally because I was concerned about calling csops from a potentially arbitrary sandbox, but I've been assured that that should be OK, and by checking up front for get-task-allow, we can also be more relaxed about closing file descriptors (since the process is already marked as suitable for debugging, so it's easy to get hold of its fds anyway).
Risk: Low. This just improves the checks that we do to make things even more secure.
Original PR: #77162
Reviewed by: @mikeash
Resolves: rdar://137551812
Tests: The backtracer's tests exercise this code.

@swift-ci Please test

@swift-ci Please test

Closing as this doesn't need to land on this branch.


[CASSANDRA-15450] in-jvm dtest cluster uncaughtExceptions propagation of exception goes to the wrong instance, it uses cluster generation when it should be using the instance id

👍 - only question is if we really need to change the getGeneration method name... it ends up it's no longer used internally, and I doubt there are many (any) external users of it, but it's changing a public API which is always a bit of a concern to me.

Yeah, I get that.  This is something I talked with Alex a little about so thought good time to rename.
Since it's dead code also glad to delete


New build needed to fix the Windows package.

Oops.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


cellcraft old agar.io

hi gus, i want to implement agario-client to cellcraft.io. but i have not yet figured out how to open multiple bots simultaneously from the same PC? how to connect the bots to agar.io and click the "play button as guest"? where is the script that do that?

how the bots follow specific cordinates?


Geoserver

Hi,
I'm trying to install cartoview on windows 7 with the windows installer, everything works except Geoserver : no response from the homepage.
Can you help me please ?

hi,
please check port 4041
Geo
On Sun, Jun 12, 2016 at 7:42 PM, Cww7<EMAIL_ADDRESS>wrote:

Hi,
I'm trying to install cartoview on windows 7 with the windows installer,
everything works except Geoserver : no response from the homepage.
Can you help me please ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cartologic/cartoview/issues/2, or mute the thread
https://github.com/notifications/unsubscribe/AEQoG9PNqjHDUfJLOhyLG_c0bvkW1Dndks5qLDb0gaJpZM4Iz1OG
.

Please read the installation instruction and make sure you have the correct
java runtime
http://cartoview.readthedocs.io/en/latest/installation/index.html
login to cartoview as admin/admin
then launch geoserver
http://localhost:4041/geoserver/web/
On Sun, Jun 12, 2016 at 10:32 PM, George Ioannou<EMAIL_ADDRESS>wrote:

hi,
please check port 4041
Geo
On Sun, Jun 12, 2016 at 7:42 PM, Cww7<EMAIL_ADDRESS>wrote:

Hi,
I'm trying to install cartoview on windows 7 with the windows installer,
everything works except Geoserver : no response from the homepage.
Can you help me please ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cartologic/cartoview/issues/2, or mute the thread
<
https://github.com/notifications/unsubscribe/AEQoG9PNqjHDUfJLOhyLG_c0bvkW1Dndks5qLDb0gaJpZM4Iz1OG
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cartologic/cartoview/issues/2#issuecomment-225458657,
or mute the thread
https://github.com/notifications/unsubscribe/AMktx26oiwuR7qYLlJw7macxNe2REy-aks5qLGzugaJpZM4Iz1OG
.

Java 64 is installed. I also created an inbound rule in the Windows firewall (port 4040, 4041, 5432, 555) but with the netstat -a command the port 4041 does not appear... I don't know why...
Is it possible to set another port for Geoserver ?

JDK7 (1.7) or higher must be installed and JAVA_HOME must refer to JDK
directory "C:\Program Files\Java\jdk1.8.0_74"
then  try to restart Tomcat from service manager most probably it is not
started.
On Mon, Jun 13, 2016 at 7:26 PM, Cww7<EMAIL_ADDRESS>wrote:

Java 64 is installed. I also created an inbound rule in the Windows
firewall (port 4040, 4041, 5432, 555) but with the netstat -a command the
port 4041 does not appear... I don't know why...
Is it possible to set another port for Geoserver ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cartologic/cartoview/issues/2#issuecomment-225650502,
or mute the thread
https://github.com/notifications/unsubscribe/AMktxw9YJGu4xebIdvm_0Q3O5LOjzQomks5qLZLPgaJpZM4Iz1OG
.

It works ! Thanks !!


Not Working on UserStyles Website

I am getting this error when trying to upload the CSS code using https://userstyles.org/ and other errors that involve --yt

It looks like Userstyles doesn't support changing the site's variable's values.
You will have to manually go and fine wherever the variable was used and type the CSS code to overwrite it with the variable's value


Remove public facing KeyBuffer

This is a follow up to #20. When I added the _boxed variants there is no real need to be able to pass owned boxed arrays into the regular keypair, encapsulate and decapsulate functions. I find this could simplify things a lot! One type less in the public API and lots of fewer generics!

The CI fails, because I first built this on top of #23. Once that documentation improvement PR is merged, this will work. Please get #21 reviewed and merged and then I can rebase this.


DockerComposeContainer assumes that env DOCKER_HOST is unix://var/run/docker.sock

When running testcontainer tests using docker/compose inside a docker container (which is the case for bitbucket pipelines amongst others), DOCKER_HOST is typically set to tcp://<ip>:<port>
There is a comment in DockerComposeContainer.java that states:
        // Ensure that compose can access docker. Since the container is assumed to be running on the same machine
        //  as the docker daemon, just mapping the docker control socket is OK.

I do not agree with this statement and assumption.
Proposed solution is to make ContainerisedDockerCompose more agnostic, so that it checks DOCKER_HOST and if not set, or starting with unix:// it mounts the socket to /docker.sock, otherwise forward the environment variable as is. (typically the container testcontainers is running in could set `-e DOCKER_HOST=tcp://:")
To reproduce with OSX+maven I tested this by exposing docker on tcp like so (WARNING this exposes your docker daemon to the network):

brew install socat
socat TCP-LISTEN:1234,fork UNIX-CONNECT:/var/run/docker.sock
Make sure $HOME/Library/Containers/com.docker.docker/Data/docker.sock is not shared in "docker.app preferences->File Sharing"

Then run the maven build inside a container:
# Assuming your pwd is in the root of the maven project that uses testcontainers
docker run -it \
-e DOCKER_HOST=tcp://host.docker.internal:1234 \
-v $PWD:$PWD \
--workdir $PWD \
maven:slim mvn test

I'm having quite some issues with getting the gradle build (failing sql tests) to work, but have some working code locally.

updating the  docker-compose image and disabling checks got it working without this fix.
#testcontainers.properties
compose.container.image = docker/compose:1.24.1
checks.disable = true


Integrate FiftyOne for loading datasets and visualizing video classification predictions

What does this PR do?
Integrates lightning flash with the analysis and visualization tool, FiftyOne. Primarily adds:

VideoClassificationData.from_fiftyone loading data directly from FiftyOne datasets
FiftyOneLabels() serializer returning predictions in the FiftyOne Classification(s) format

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @ehofesmann! Thanks for opening this PR.

In the file flash/core/classification.py:

Line 210:30: E251 unexpected spaces around keyword / parameter equals
Line 210:32: E251 unexpected spaces around keyword / parameter equals
Line 211:35: E251 unexpected spaces around keyword / parameter equals
Line 211:37: E251 unexpected spaces around keyword / parameter equals
Line 219:26: E251 unexpected spaces around keyword / parameter equals
Line 219:28: E251 unexpected spaces around keyword / parameter equals
Line 220:31: E251 unexpected spaces around keyword / parameter equals
Line 220:33: E251 unexpected spaces around keyword / parameter equals
Line 221:27: E251 unexpected spaces around keyword / parameter equals
Line 221:29: E251 unexpected spaces around keyword / parameter equals
Line 226:22: E251 unexpected spaces around keyword / parameter equals
Line 226:24: E251 unexpected spaces around keyword / parameter equals
Line 227:27: E251 unexpected spaces around keyword / parameter equals
Line 227:29: E251 unexpected spaces around keyword / parameter equals

In the file flash/core/data/data_source.py:

Line 472:1: E302 expected 2 blank lines, found 1
Line 480:67: W291 trailing whitespace

In the file flash/video/classification/data.py:

Line 24:21: W291 trailing whitespace
Line 25:24: W291 trailing whitespace
Line 27:17: W291 trailing whitespace
Line 149:36: E231 missing whitespace after ':'
Line 149:43: E741 ambiguous variable name 'l'
Line 149:44: E231 missing whitespace after ','
Line 151:33: W291 trailing whitespace
Line 155:49: E231 missing whitespace after ','

Do see the Hitchhiker's guide to code style


SPFX WebPart - AngularJS 1.5.8 - Error on Preview

Category

[ ] Question

I have created a SharePoint Framework WebPart using AngularJS 1.5.8. This is not using TypeScript.
The WebPart works fine until I press Preview button in the workbench.html page. Once I click Preview button, I see the following error:
Sometimes I see this error in the SharePoint Page where this WebPart is added.
Any Idea?

@waldekmastykarz - Any suggestions?

Could it be that you're bootstrapping the Angular application in the web part render method without wrapping it in if (this.renderedOnce === false) { }?

You are correct @waldekmastykarz. Will this affect the other SPFX WebParts in the same page which uses the same angualr js file?

Could you also share the contents of ./config/config.json? I'm curious how you are loading Angular and if you're seeing any errors related to it.

Hi @waldekmastykarz
Please find the details below
{
"entries": [
{
"entry": "./lib/webparts/Recognition/RecognitionWebPart.js",
"manifest": "./src/webparts/Recognition/RecognitionWebPart.manifest.json",
"outputPath": "./dist/recognition.bundle.js"
}
],
"externals": {
"angular": {
"path": "https:///js/vendor/angular.1.5.8.min.js",
"globalName": "angular"
}
},
"localizedResources": {
"RecognitionStrings": "webparts/Recognition/loc/{locale}.js"
}
}

The issue is intermittent. Sometime it is working and sometime not. I feel there is a delay in loading the angualrjs file.

Can you reproduce the issue with only one web part on the page?

No, The WebPart works consistently when I add it in a different page without other WebParts.
We tried to load the angular file from page layout to see if it works when we have multiple WebParts but no luck.

Do you see the issue only when loading Angular from CDN or also when it's included in the bundle?

Yes @waldekmastykarz.
We can see the error when loading Angular from CDN as well bundle.

I can't seem to repro it. Do you have a sample project with the issue that I could have a look at?

As it is company sensitive code, I just created sample files for your review.
Please check your inbox for repository details.

I saw an issue posted for Jquery for similar scenario.
https://github.com/SharePoint/sp-dev-fx-webparts/issues/192

If I understood it correctly, in that case jQuery was already present on the page, plus the issue was with plugins, not jQuery itself.

Hi @waldekmastykarz
We are getting the similar error when the webparts are failing.
.bootstrap is not a function.
 = angular and this can be a.bootstrap or c.bootstrap based on bundled file.

@waldekmastykarz
I found the root cause. The issue occurs when we have JavaScript custom actions with jQuery and angularJS SPFX WebParts in the page.
The jQuery(1.11.1) loads from custom action giving some conflict to SPFX angularJs(1.5.8).
We have few site collection level custom actions(example : global navigation, site analytics telemetry, custom site request link) runs with jQuery(1.11.1). Now I have to find the jQuery version angularJs 1.5.8 likes or resolve the jQuery conflict issue.
Changing the custom action jQuery version to 3.2.1 resolves the problem in all the browsers. I have verified this with one custom action and SPFX webpart combination in a page.
Thoughts?

@waldekmastykarz
I have created a repo with sample code and added you as contributor. Please check your account connected to your github. Please refer the readme file for more details.

@sprider not sure if it's indeed the case, but jQuery v3.2.1 is being listed amongst AngularJS dependencies. You could try using that version to see if it helps to solve your issue.

@waldekmastykarz
When I use V3.2.1 in custom action the SPFX webpart works in all the browsers except Safari.
Are you suggesting to add jQuery 3.2.1 in SPFX WebPart as dependency?

@waldekmastykarz
We have resolved this issue by removing JQuery from our custom actions for now.
But I am not sure about MS recommendation for Custom Actions with JQuery added in the page with SPFX webPart plus Safari combination. It is definitely not working as we worked with MS engineer regarding this.
I am closing this issue for now. Please reopen if required

@sprider what was the error that you were getting in Safari?

Safari was not throwing any errors specifically. But other browsers threw the below error
TypeError: s.bootstrap is not a function

When I use V3.2.1 in custom action the SPFX webpart works in all the browsers except Safari.

This is why I asked specifically about Safari.

The SPFx web parts were failing intermittently with JQuery 3.x as well as 2.x but in safari we could reproduce this issue consistently.
We have deployed our custom actions without JQuery and SPFx Webparts are 100% working in all the browsers including iPhone and iPad Safari.

When the web part was failing in Safari, were you seeing a specific error?


Can't upload public files to S3

Describe the bug
Files won't be publicly readable in S3 bucket even if expires is set to 0
Error probably caused by
Line 22 in build/features/upload-file/providers/aws-provider.js
this.expires = options.expires || constants_1.DAY_IN_MINUTES;
and/or Line 55 in src/features/upload-file/providers/aws-provider.ts
this.expires = options.expires || DAY_IN_MINUTES
if expires is set to 0 the || will cause the code to use the constant value of 86400 minutes for expires
Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Expected behavior
Upload file to bucket with ACL 'public-read'

Hi this should be fixed in v1.3.1


Use omnibus-ctl version that supports license acceptance.

This is a minor change in chef-server but a major change in omnibus-ctl.
https://github.com/chef/omnibus-ctl/pull/42
Will update this PR with a real version number once omnibus-ctl PR is merged and released but I wanted to share this here to see if it is going to raise any alarm bells.
Note that once this is in, all existing automation calling reconfigure will break and users will need to add --accept-license to fix. We have got product's :+1: on this. You can read this for more information on the future.
/cc: @chef/server-team

OK looks like we do not want to do this for Chef Server.
Moving along :smile:


Update README.md about need to "chown 1000 ./public*"

The error in #9 occurs under Ubuntu 20, and likely similar platforms enforcing non-root write privileges for the active user, due to hardcoded uid 1000 in the container images pulled during build.  This explains build errors like these:
hellodjango-js-1        | mkdir: cannot create directory '../public/js': Permission denied
hellodjango-js-1        |
hellodjango-js-1        | Task completed in 0m0.001s
hellodjango-css-1       | mkdir: cannot create directory '../public/css': Permission denied
hellodjango-css-1       |
hellodjango-css-1       | Task completed in 0m0.001s

Resolution is to chown ./public* prior to first build with docker-compose.  Likely have to do with sudo if the active user doesn't have root privileges.
$ sudo chown 1000 {public,public_collected}

Hi,
The containers run as a non-root user and Docker by default will bind mount files as uid/gid 1000:1000 when you set USER xxx in your Dockerfile with no other details.
Is your user not 1000? You can check by running id from your Docker host. I do run native Linux and have deployed this app on many Linux systems without issues on various VPSs since the first user you create on a Linux system will be 1000:1000 by default.

The active user running docker-compose having uid 1000 won't be guaranteed.  Mine is 1001 due to presence of other local users, and similar for systems with centralized user management like via LDAP.  For an active user with uid != 1000 to chown something to that id, sudo is required.
Recommendation is to add mention of default uid.gid = 1000:1000 to the README, and Linux users with different ids need to update Dockerfile with USER xxx or chown 1000 {public,public_collected}.

You are correct in that it's not guaranteed, but it is the default behavior of Docker.
If you chown those directories as 1000, chances are your 1001 user won't have write access to those directories and you'll end up with the same permission denied error. Basically this ends up being very system specific but works out of the box 98% of the time. I wish I had a better answer but Docker doesn't make this process any more portable and the benefits of running things as a non-root user vastly out weigh having everything owned by root.

Hey, I know it's been a while but can you try out this PR and report back whether it works or not in that PR? https://github.com/nickjj/docker-flask-example/pull/7
I know it's a Flask app and not Django but I can port the same change over to this Django example app if it works.

This is fixed in: https://github.com/nickjj/docker-django-example/commit/b269057cd7df996ffa479d76e3b441435c3af5d9


No longer possible to scroll by dragging up when empty zone directly out of viewport

VSCode Version: 1.10.0
OS Version: macOS

Steps to Reproduce:

have a diff that has deleted lines
move the right hand side up enough so that the viewzone of the deleted lines is right outside of the viewport
drag up with the mouse to scroll up

=> you cannot scroll anymore up anymore with dragging the mouse
A video:

This is not a regression. Tried in 1.7.2

This has been fixed in the meantime.

I am still seeing it with latest.

Aha, I tried to reproduce by having the view zone partially in the viewport, while the bug is about having the viewzone not in the viewport.


[SPARK-46698][SPARK-46895][CORE][3.5] Replace Timer with single thread scheduled executor

backport #44701 and #44718 to branch 3.5 as a fix for SPARK-49479: Non-daemon Timer prevents Spark driver JVM from stopping.
What changes were proposed in this pull request?
This PR propose to replace Timer with single thread scheduled executor.
Why are the changes needed?
The javadoc recommends ScheduledThreadPoolExecutor instead of Timer.

This change based on the following two points.
System time sensitivity
Timer scheduling is based on the absolute time of the operating system and is sensitive to the operating system's time. Once the operating system's time changes, Timer scheduling is no longer precise.
The scheduled Thread Pool Executor scheduling is based on relative time and is not affected by changes in operating system time.
Are anomalies captured
Timer does not capture exceptions thrown by Timer Tasks, and in addition, Timer is single threaded. Once a scheduling task encounters an exception, the entire thread will terminate and other tasks that need to be scheduled will no longer be executed.
The scheduled Thread Pool Executor implements scheduling functions based on a thread pool. After a task throws an exception, other tasks can still execute normally.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.

Kindly ping @beliefer @LuciferYang @dongjoon-hyun.

This is only a minor improvement for Spark 4.0, not a bug fix, and it should not be backported to 3.x.

This is only a minor improvement for Spark 4.0, not a bug fix, and it should not be backported to 3.x.

@LuciferYang Thanks for reply! It actually includes a fix for https://issues.apache.org/jira/browse/SPARK-49479 as a side effect, by adding shutdown of a timer in BarrierCoordinator.

@jshmchenxi, Can we submit separate pull requests along with their primitive forms?

@jshmchenxi, Can we submit separate pull requests along with their primitive forms?

Yes, I created another PR for the first commit: #47957. The second commit is in this PR.
And the fix for SPARK-49479 is #47956. It depends on the other 2 commits to fix in branch 3.5.


Proxy environment variables support

It would be nice when the project uses the environment variable http_proxy, https_proxy and no_proxy.
When running docker for example, this makes it much easier to deploy docker containers.

@MelvinKool If you set the https_proxy or http_proxy variable, the system should honor it. I have no way of testing, but feel free to reopen ticket if you run into problems.

@stevespringett That was quick!  You might also want to check the uppercase version HTTPS_PROXY and HTTP_PROXY.
Both upper case and lower case are valid.

Unfortunately, it failed.
I had both the lower and upper case version of the proxy environment variables set.
I'm sure they are used and work in other docker containers.
Do you see a possible cause, by looking at the following logs?
2018-03-02 08:45:51,484 [] INFO [alpine.Config] -------------------------------------------------------------------------------- 2018-03-02 08:45:51,485 [] INFO [alpine.Config] Initializing Configuration 2018-03-02 08:45:51,485 [] INFO [alpine.Config] System property alpine.application.properties not specified 2018-03-02 08:45:51,485 [] INFO [alpine.Config] Loading application.properties from classpath 2018-03-02 08:45:51,488 [] INFO [alpine.Config] -------------------------------------------------------------------------------- 2018-03-02 08:45:51,489 [] INFO [alpine.Config] Application: Dependency-Track 2018-03-02 08:45:51,489 [] INFO [alpine.Config] Version:     3.0.0-SNAPSHOT 2018-03-02 08:45:51,489 [] INFO [alpine.Config] Built-on:    2018-03-01 20:28:59 2018-03-02 08:45:51,489 [] INFO [alpine.Config] -------------------------------------------------------------------------------- 2018-03-02 08:45:51,489 [] INFO [alpine.Config] Framework:   Alpine 2018-03-02 08:45:51,489 [] INFO [alpine.Config] Version :    1.0.0 2018-03-02 08:45:51,490 [] INFO [alpine.Config] Built-on:    2018-02-28 00:19:40 2018-03-02 08:45:51,492 [] INFO [alpine.Config] -------------------------------------------------------------------------------- 2018-03-02 08:45:51,696 [] INFO [alpine.persistence.PersistenceManagerFactory] Initializing persistence framework 2018-03-02 08:45:54,472 [] INFO [org.owasp.dependencytrack.persistence.CweImporter] Syncing CWEs with datastore 2018-03-02 08:45:56,832 [] INFO [org.owasp.dependencytrack.persistence.CweImporter] CWE sync complete 2018-03-02 08:45:56,920 [] INFO [alpine.AlpineServlet] Starting Dependency-Track 2018-03-02 08:46:03,352 [] INFO [org.owasp.dependencytrack.tasks.MetricsUpdateTask] Executing metrics update on portfolio 2018-03-02 08:46:03,429 [] INFO [org.owasp.dependencytrack.tasks.MetricsUpdateTask] Executing metrics update on vulnerability database 2018-03-02 08:46:03,427 [] INFO [org.owasp.dependencytrack.tasks.NspMirrorTask] Starting NSP mirroring task 2018-03-02 08:46:03,439 [] INFO [org.owasp.dependencytrack.tasks.NspMirrorTask] Retrieving NSP advisories at Fri Mar 02 08:46:03 GMT 2018 2018-03-02 08:46:03,441 [] ERROR [alpine.Config] Error parsing number from property: alpine.http.proxy.port 2018-03-02 08:46:03,783 [] INFO [org.owasp.dependencytrack.tasks.NspMirrorTask] Retrieving NSP advisories from https://api.nodesecurity.io/advisories 2018-03-02 08:46:53,353 [] INFO [org.owasp.dependencytrack.tasks.VulnDbSyncTask] Starting VulnDB mirror synchronization task 2018-03-02 08:46:53,354 [] INFO [org.owasp.dependencytrack.tasks.VulnDbSyncTask] VulnDB mirror directory does not exist. Skipping. 2018-03-02 08:46:53,361 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Starting NIST mirroring task 2018-03-02 08:46:53,361 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Downloading files at Fri Mar 02 08:46:53 GMT 2018 2018-03-02 08:46:53,363 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://nvd.nist.gov/download/nvdcve-2002.xml.gz 2018-03-02 08:48:11,090 [] ERROR [org.owasp.dependencytrack.tasks.NspMirrorTask] An error occurred while retrieving NSP advisory com.mashape.unirest.http.exceptions.UnirestException: org.apache.http.conn.HttpHostConnectException: Connect to api.nodesecurity.io:443 [api.nodesecurity.io/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 	at com.mashape.unirest.http.HttpClientHelper.request(HttpClientHelper.java:143) 	at com.mashape.unirest.request.BaseRequest.asJson(BaseRequest.java:68) 	at org.owasp.dependencytrack.tasks.NspMirrorTask.getAdvisories(NspMirrorTask.java:96) 	at org.owasp.dependencytrack.tasks.NspMirrorTask.inform(NspMirrorTask.java:72) 	at alpine.event.framework.BaseEventService.lambda$publish$0(BaseEventService.java:86) 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 	at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.http.conn.HttpHostConnectException: Connect to api.nodesecurity.io:443 [api.nodesecurity.io/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 	at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:158) 	at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:353) 	at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:380) 	at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236) 	at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184) 	at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88) 	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110) 	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184) 	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82) 	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:107) 	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:55) 	at com.mashape.unirest.http.HttpClientHelper.request(HttpClientHelper.java:138) 	... 9 common frames omitted Caused by: java.net.ConnectException: Operation timed out (Connection timed out) 	at java.net.PlainSocketImpl.socketConnect(Native Method) 	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) 	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) 	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) 	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) 	at java.net.Socket.connect(Socket.java:589) 	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:337) 	at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:141) 	... 20 common frames omitted 2018-03-02 08:48:11,090 [] INFO [org.owasp.dependencytrack.tasks.NspMirrorTask] NSP mirroring complete 2018-03-02 08:49:00,624 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to nvd.nist.gov:443 [nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 08:49:00,624 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://nvd.nist.gov/feeds/xml/cve/nvdcve-2.0-2002.xml.gz 2018-03-02 08:51:07,856 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to nvd.nist.gov:443 [nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 08:51:07,856 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://static.nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-2002.json.gz 2018-03-02 08:53:15,088 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to static.nvd.nist.gov:443 [static.nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 08:53:15,088 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://nvd.nist.gov/download/nvdcve-2003.xml.gz 2018-03-02 08:55:22,320 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to nvd.nist.gov:443 [nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 08:55:22,320 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://nvd.nist.gov/feeds/xml/cve/nvdcve-2.0-2003.xml.gz 2018-03-02 08:57:29,552 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to nvd.nist.gov:443 [nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 08:57:29,552 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://static.nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-2003.json.gz 2018-03-02 08:59:36,784 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to static.nvd.nist.gov:443 [static.nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 08:59:36,784 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://nvd.nist.gov/download/nvdcve-2004.xml.gz 2018-03-02 09:01:44,016 [] ERROR [org.owasp.dependencytrack.tasks.NistMirrorTask] Download failed : Connect to nvd.nist.gov:443 [nvd.nist.gov/<IP_ADDRESS>] failed: Operation timed out (Connection timed out) 2018-03-02 09:01:44,016 [] INFO [org.owasp.dependencytrack.tasks.NistMirrorTask] Initiating download of https://nvd.nist.gov/feeds/xml/cve/nvdcve-2.0-2004.xml.gz

Lower, upper, and mixed case of the vars should work now.
Regarding the timeout issue, likely a proxy preventing the request from going through.
I also found a flaw in the proxy credentials logic. So if the proxy required authentication, it would not work. This has also been fixed.
Between these two fixes, if you still experience the issue, it would be really helpful if you could set org.apache.http to DEBUG in logback.xml and restart the application. This should write all debug info (including headers and connections) to the log. If the log contains sensitive information, feel free to PM me on the Slack channel or send the log to<EMAIL_ADDRESS>

Closing. Verified that current proxy functionality works.


Clean up OpenBSD a bit, all supported releases use ld.lld

this re-adds the OpenBSD cleanup from @adamsteen on top of the big PR.

Thanks, I cherry-picked the commit on the PR about the new toolchain.


Wt optimisation

Velocity profile bug (fixed)
Memory leak bug (pending)

I think compiling with valgrind is a good idea. I will like at the approach you used and see if there is a nice way to add a debugging  option to the build that enables it across the whole proteus build if not also petsc and some of the other important dependencies. Also, I'm noticing a lot more use of the C++--11 shared pointers, which we can start doing in our C++ modules to make memory allocation safer.


load fmt as external fail

the tag of fmt has no v prefix
6.1.0
6.1.1
6.1.2
qls
v0.11.0

default strategy will add v prefix to VERSION supplying by user.
148   if (NOT DEFINED CPM_ARGS_GIT_TAG)
149     set(CPM_ARGS_GIT_TAG v${CPM_ARGS_VERSION})
150   endif()

should we give an option to handle this situation as well as VERSION equal master?

Packages not using v-prefixed tags require specifying GIT_TAG explicitly and additionally to  VERSION to the same value, which I agree feels awkward. I think it makes sense to assume the v-prefix by default as it seems to be most common convention on GitHub, but it makes sense to override this on a per-package basis.
Perhaps we could add an additional option VERSION_PREFIX to the package definition e.g.
CPMAddPackage(
  NAME fmt
  VERSION 6.1.2
  GITHUB_REPOSITORY fmtlib/fmt
  VERSION_PREFIX ""
)

As it turns out, CMake did not support empty arguments until very recently, which is why using VERSION_PREFIX "" will not work. Currently however CPM can take the version from GIT_TAG as well, reducing the need for double specification as well. So the current "correct" way to add fmt would be the following.
CPMAddPackage(
  NAME fmt
  GIT_TAG 6.1.2 # CPM will take the version from this tag
  GITHUB_REPOSITORY fmtlib/fmt
)

I will update the documentation and add fmt as an example accordingly.


⚠ ClamAV has degraded performance

In 1c347c7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in 72dd260.


Port SpanTag fix to 1.3.x

Fixes gh-990

@ethanbishop Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@ethanbishop Thank you for signing the Contributor License Agreement!

Codecov Report

Merging #1119 into 1.3.x will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              1.3.x    #1119   +/-   ##
=========================================
  Coverage     76.47%   76.47%
  Complexity     1386     1386
=========================================
  Files           184      184
  Lines          4939     4939
  Branches        556      556
=========================================
  Hits           3777     3777
+ Misses          866      865    -1
- Partials        296      297    +1

Impacted Files
Coverage Δ
Complexity Δ

...k/cloud/sleuth/zipkin2/DefaultEndpointLocator.java
75% <0%> (-5%)
16% <0%> (-1%)

...mework/cloud/sleuth/stream/StreamSpanReporter.java
80% <0%> (-2.23%)
12% <0%> (ø)

...trument/reactor/TraceReactorAutoConfiguration.java
100% <0%> (+30%)
1% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d17f7...82bd941. Read the comment docs.

Congrats @ethanbishop on your first contribution !!! :)

Thanks, hopefully the next will be more interesting!


<IP_ADDRESS> update

Bring this repo up to date with latest.

Can one of the admins verify this patch?

ok to test

test this please

test this please

test comment from Jenkins

test this please

test this please

test this please


UI problems on mobile

There are some issues with the UI on mobile as pointed out by @hturner:

"Proudly supported by R Consortium" overlaps with copyright notice
Layout is really squished so that you get thin column of text and phot that does not fit (3rd screenshot shows rest of phot if you horizontally scroll, which you wouldn't want to do on mobile)
Transparent navbar is difficult to read when it overlays text underneath
Squished layout is particularly bad for tables!

Transparent navbar is difficult to read when it overlays text underneath
Fixed in 690d8d4cfbbb61c2145edce49f2d79bb91d1d53b

"Proudly supported by R Consortium" overlaps with copyright notice
Use two columns instead of three in the footer


Don't add Style/Alias offense for use of alias in eval_instance blocks

This fixes an issue with the Style/Alias cop. instance_eval blocks are found to be dynamic scope, so Rubocop currently adds an offense when using alias instead of alias_method, but object instances do not respond to alias_method.

Before submitting a PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it)
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

:+1:

@magni- Squash the commit together and rebase on top of the current master.

@bbatsov done!

Had to rebase this once more myself. The commit is merged now.

Thanks!


Streamer's new emotes don't show in the emote menu or autocomplete weeks after they were added

The streamer Emiru added new emotes, I think it was a few weeks ago and they still aren't showing up in the menu or emote autocomplete
Screenshots
Twitch emote menu

Chatterino emote menu

OS and Chatterino Version
Windows 10, Chatterino Nightly 7.3.3 (commit d9372S4b6 )

Duplicate of #2935


TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "C:\Users\usuario\ANACONDA\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 561, in show_time
elapsed_time = time() - self.t0
TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'
Traceback (most recent call last):
File "C:\Users\usuario\ANACONDA\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 561, in show_time
elapsed_time = time() - self.t0
TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'
Traceback (most recent call last):
WARNING:traitlets:kernel died: 3.0197155475616455
File "C:\Users\usuario\ANACONDA\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 561, in show_time
elapsed_time = time() - self.t0
TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'
Traceback (most recent call last):
File "C:\Users\usuario\ANACONDA\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 561, in show_time
elapsed_time = time() - self.t0
TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'
Traceback (most recent call last):
File "C:\Users\usuario\ANACONDA\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 561, in show_time
ela

Thanks for reporting. We'll fix this problem in our next release.
@csabella, this one is yours :-) I think it happens when the kernel takes too much time to start.

This is the old code before my change in #6699, but we don't know what version of Spyder the OP is running.  @ccordoba12 , do you think one of the other fixes to the console would have helped with the kernel start up time?  Just thinking if @angelalarc99 updates to 3.2.8, then it may resolve their issue.
I will, however, also put in a check to make sure self.t0 isn't None.  :-)

do you think one of the other fixes to the console would have helped with the kernel start up time?

I made several changes to improve kernel startup time in the same release the timing functionality was introduced. After that, nothing significant has changed in that regard.

I will, however, also put in a check to make sure self.t0 isn't None. :-)

Thanks a lot for your quick response!


Error: "no such table: geometry_columns"

Getting that on this page today: https://latest-with-plugins.datasette.io/fixtures/roadside_attractions

Tried installing SpatiaLite there and it didn't help. Must be a plugin conflict - maybe from leaflet freedraw since that changed recently?

Removing the freedraw plugin fixed this. I'll move this issue to that repo.


Type definition

Please review if there is some other type for file input. Thanks

I'm not qualified to review the TS parts. I can accept it if it doesn't interfere with other things

I forgot to add return type. Will do and then we can merge tomorrow.
FYI: It does not affect the JS part of the library in any way at all.

@JuanIrache What function can you pass to the GPMFExtract function as the file parameter?

To sum it up; You can use the library the same way you used to, but now you have type information fully compatible with what the library can accept.
Also, I added the possibility to import the function as named import. Not that it is needed, but it is a nice to have in TS.
It is ready to be merged :)

Thank you. Merged. Could you make future changes in the dev branch instead of master?

Will do. Browser compatibility branch is in progress ;)


Android Support

Could it be possible to add Android support?

+1

And now Android + Kotlin support?

What is needed for Android support?

AFAIK Kotlin sources are already covered in version 0.2.0

@aalmiray This plugin does not support Android:
$ gradlew stats

BUILD SUCCESSFUL in 0s
1 actionable task: 1 executed

See this line: https://github.com/aalmiray/stats-gradle-plugin/blob/master/src/main/groovy/org/kordamp/gradle/stats/StatsTask.groovy#L89. Android sourcesets are under android. sourceSets in the Android Gradle Plugin DSL.

@jaredsburrows could you build a local snapshot and test it out in one of your projects?

It is ok if you do not want to support Android, I just thought it would be awesome.
There is more than one Android plugin: com.android.library, com.android.application, com.android.test and I believe com.android.feature.
I might be able to look into this but the docs for the DSL are here: https://google.github.io/android-gradle-dsl/current/.


feat: provide filter function in directive handler arg

Provide a filter function in directives. It will filter the result at the type level no matter if it is an array or a single entry.
https://github.com/accesimpot/graphql-gene/blob/c0d271759172cf3b3e3ed2ff5412ceeb21f1f3cf/packages/dev-playground/src/models/ProductVariant/filterBySize.directive.ts#L4-L16

:tada: This PR is included in version graphql-gene-v1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use XDG data directory for fish import

I cherry picked the commit from #601. That PR was closed after some inactivity.
On MacOS, atuin was looking for fish history under "$HOME/Library/Application Support".
Now atuin honors XDG_DATA_HOME, if set, and otherwise uses "$HOME/.local/share".
closes #682

ah - just a cargo fmt and we're good to go


Added an example entitled helpdm.cr

Helpdm essentially is an example which by calling "!help", the user will get a private message sent to them by the bot with help information (or in this case, a string).
It's not as simple as ping.cr, but is not meant to be super complex either.

use two spaces for crystal indentation and add a newline to the end of the file

Or just run the formatter

Okay, I seem to still be having formatting issues, but will get on it. (Thought it was formatting related)

I would love to merge a more complex example, but I think it's a little too similar to the existing one at the moment. If you add a simple command dispatch using a case statement I think that would be an interesting example. Maybe showcase a few more basic things you might want to do in a bot.


Add ability to apply OpenType

Given an open type, it should be possible to pass it a Map<TypeParameter,ClosedType> to get a ClosedType or a Map<TypeParameter,OpenType> to get another OpenType. That is, let us do type param substitution.
Not sure if this would be for 1.2 or later, but I expect metamodel users would need that.

Yes. Yes we do.

Moving to 1.3 as it may require lots of work on the JS side.


0.0.10 Release

0.0.10 Changes
Highlights

❔ Use BaseBleakClient for typing instead of BleakClientBlueZDBus.
📝 Update examples/basic_usage.py
🛠 Fix logging and deprecation around requires_client wrapper.

Contributions
Special thanks to @jarcoal for contribution around these changes.

Codecov Report

Merging #16 (4bd35ae) into master (d497bd9) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   97.70%   97.51%   -0.19%
==========================================
  Files           8        8
  Lines         567      564       -3
==========================================
- Hits          554      550       -4
- Misses         13       14       +1

Impacted Files
Coverage Δ

tests/mocks.py
85.71% <100.00%> (-0.96%)
:arrow_down:

tests/test_wave.py
100.00% <100.00%> (ø)

wave_reader/utils.py
100.00% <100.00%> (ø)

wave_reader/wave.py
93.71% <100.00%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d497bd9...4bd35ae. Read the comment docs.


Plonk with Plookup

This PR adds the implementation of the Plookup protocol (https://eprint.iacr.org/2020/315) into Plonk so as to optimize the proofing system for the computations that involve various lookup functions. This is valuable for constraining the computations of functions/operations that are, otherwise, expensive to implement in a circuit over a prime field.
The proposed implementation adds support for a single lookup table to be looked up for a witness vector which is the 4-th column (for columns 0..=4) vector of Plonk witness. The feature is implemented with the following two mechanisms:

Addition of LOOKUP custom Plonk constraint. This constrains the column 0..=3 values to that of the column 4 as encoding of the constrained operation operand and result values, along with the supported operation opcodes, into the lookup value to be checked against the constraint system lookup table. For example, LOOKUP constraint for the 8-bit XOR operation constrains the values of the XOR opcode, two input operands and one output into the lookup value with the bitwise shifts and addition. Similarly for AND, OR (with different opcode values). For NOR, the gate constrains the opcode, input and output operands to the lookup value. Other types of lookup functions can also be constrained with this gate type to encode inputs and outputs into the lookup values.

Addition of Plookup index/prover/verifier functionality into Plonk protocol. This addition is implemented as per the protocol specification of https://eprint.iacr.org/2020/315. It is important to note here that Plookup protocol, as integrated into Plonk, bears some burden on the Plonk performance as prover/verifier functionality has to deal with the additional polynomials and their evaluations/commitments. Nevertheless, for a significant class of computations which depend on SNARK-inconvenient operations, the resulting proofing system provides the performance benefit of the smaller circuit, constraining the computation.

The implementation of Plookup in Plonk has been augmented with the test of this functionality. The turbo_plonk test has been enhanced with the lookup constraints for the 8-bit binary operations such as XOR, AND, OR, NOR.
This implementation is the step in the design/implementation of the custom Plonk constraints for the computation that involves encryption of HTTPS data with TLSNotary that computes irrefutable evidence of the session.

This seems to include the changes from #75 (which are now split into #81, #82, #83 on top of current master), and modifies the 3-wires constraint system.
@ltvvlz can you change this to create a new constraint system for 5-wires-plonk+plookup instead of replacing the 3-wires one, and update it to merge cleanly to master? It may make sense to base it upon #82, which introduces the 5-wires poseidon parameters, or perhaps even #83 if it makes sense to share some gates etc. with that change instead of duplicating them.

Plus 1 to @mrmr1993's comments. It will make review (and merging) a lot more straightforward. Looking forward to reading this!


Further testing

I change Standard.md to be an actual markdown file.
I renamed Transaction.Output and Transaction.Input to SiacoinOutput and SiacoinInput respectively, because there are siafunds as well.
I added a forking test to make sure the state rewinds and reapplies correctly (it didn't, but now it does).
I added contract testing, transaction testing, and expanded the crypto package a little bit to check for nil stuff.
I changed to using encoding.Marshal and encoding.Unmarshal instead of doing it manually. This may have introduced regressions, but only in packages that have minimal to no testing. The bugs should pop up immediately once we add testing.
The consensus testing suite is a bit of a mess right now. The functions could be more oragnized, and it could use better tooling in general. I've decided to let it be messy for now though, because the testing is now pretty thorough (74%!) and we don't need to test it to death before we return to working on the user experience. I think we can come back in a few weeks and do organizational cleanup, and improve the testing tooling.
Pretty much all that remains at this point is the 100 block limit and the siafunds, and testing for each. (We also need to test the exported functions).

fixes #157

unless there is something urgent about one of these, I would like to implement them in my next pr. I think there would be merge conflicts otherwise.

next pr will hopefully be ready in a few hours.

nvm doin it now

comments addressed

if I'm being nitpicky...SignBytes/VerifyBytes should be SignHash/VerifyHash now.

I'll move it over.
Eventually we're going to need to distinguish between the types of crypto that we're using, because we are planning on supporting multiple types. SignEd25519Blake2b or something. heh. Maybe we can come up with a better scheme than that.

Maybe signing and verifying could be properies of the key types.
Ed25519GenerateKeys()
secretKey.SignBlake2b(hash Blake2b)
publicKey.VerifyBlake2b(hash Blake2b, pk Ed25519PublicKEy, sig Ed25519Signature)


Fix the OTelTraceSoruceTest

Issue #, if available:
Fixing the build.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Removing the asserts and making it Print the outputs so that I can debug this later.


Embeded videos not showing

🐛 Bug Report
I am migrating a documentation site from Jekyll to Docusaurus, and a lot of the .md files have html sprinkled in at the moment, generally related to displaying images and video files. The images are wrapped in
 tags (for styling), and those are working fine.
The problem is with the video files - this is what they look like:

  <video width="100%" height="100%" playsinline autoplay muted loop>
    <source src="video/2.mp4" type="video/mp4">
    <source src="video/2.webm" type="video/webm">
    <source src="video/2.ogg" type="video/ogg"> Your browser does not support the video tag.
  <video>

(I have to wrap the <video> tag in a
 tag or it cuts off the rest of the content - another bug?)
At the moment, the page is just showing a blank space where the video should be. This format was working in Jekyll, so I'm not sure what's happening in Docusaurus' conversion of .md files that's breaking the display.
Have you read the Contributing Guidelines on issues?
Yup.
To Reproduce

Add a <video> tag to any doc

Expected behavior
Shows the video.
Actual Behavior
Shows a blank space.

Reproducible Demo
The repo is private so I can't post it, but right now I've only brought in my .md files and haven't yet messed with the siteConfig.js, so it's something that should be reproducible in any configuration.

Hi, @bildungsroman
I have tried it, the video will show liks this:

I guess you video source url is incorrect. You can try to move your video file to /website/static/video. Add a / before you video src url:

  <video width="100%" height="100%" playsinline autoplay muted loop>
    <source src="/video/2.mp4" type="video/mp4">
    <source src="/video/2.webm" type="video/webm">
    <source src="/video/2.ogg" type="video/ogg"> Your browser does not support the video tag.
  <video>

But the video's style is not so good, I can create a PR for this.

Great point by @wszgxa. Thank you for helping to look into this. Awesome 😄
I shall close this issue because this is caused due to wrong source

Thank you, @wszgxa!

Took me a while to figure out that the controls props was missing in the <video> element here. Adding the code with correct closing tags:

  <video width="100%" height="100%" playsinline autoplay muted controls>
    <source src="/videos/myvideo.mp4" type="video/mp4" />
  </video>


How might we reuse the same component multiple times on a page?

How might we reuse the same component multiple times on a page?
Could a selector return more than one element?
Test case: https://codepen.io/miguelslp/pen/VwmaVqg
Thanks!

Ooh, that's a good one! As the code is written today, you'd want to create a separate component for each element, but you can centralize the data through a Data Store, and reuse the template through an external named function.
Using your clock as an example, here's how I would approach it: https://codepen.io/cferdinandi/pen/QWGNzjp
Let me do some research on whether or not having one component inject into multiple elements is a good idea or not.

Okay I will look forward for news on the topic, thank you 😁 !

I guess I wanted to ask the similar questions: how does one have ie component  todo and then another component for todos where todo are iterated.

Maybe that should help me too.
I need to learn how to build my app the "reef way"...
I try to setup routes and change the component based of current route. But it isn't possible to bind a component to a route or get the template...
route "home" render component "home" and route "about" renders component "about".
But maybe it's easier to do?
How to replace template based on current route? Or do I need to wait until this issue is solved?

Hi @cferdinandi,
template functions may help me with #119. But if some preparation is needed it looks like that:
function tpl1(vars) {
    return `My template....`
}

And component template part with changeable template function for example based on route:
                template: function(vars) {
                    let func = route.template // string with template function name
                    return window[func](vars) // need to improve that I think
                }

+1 vote from me. I want to mount one component on multiple places on the page.

I'm closing this as won't fix, because reef v12 was just released with a totally different API and authoring pattern that negates this question.