Release notes for 348

Dain Sundstrom

[x] all checked
11-30 23:03:34    82289021c6 Simplify BlockEncodingSerde
12-02 23:33:11    8a436b0896 Require calling convention for scalar functions
12-02 23:33:11    8d5687697b Remove unused keyEqualsMethod and keyType from MapElementAtFunction
12-08 05:22:07    41a777bd52 Fix dynamic system tables for clusters with multiple coordinators

David Phillips

[x] all checked
11-26 03:25:18    1c83f385da Improve bind pattern description
11-26 03:25:18    ac9a322691 Document ldap.ignore-referrals config
11-26 03:25:18    f9a060e88f Decrease table column width
11-30 08:08:01    14e2436043 Validate Hive bucketing on read
11-30 08:08:01    a780b6d1d4 Extract ForwardingRecordCursor
11-30 18:28:40    3a1bf59d7c Disable cache refresh for bulk metastore calls
11-30 23:21:14    8f1e53a6bb Simplify CachingHiveMetastoreModule
11-30 23:21:14    d10be6e856 Decrease refresh thread count for metastore cache
12-01 21:45:02    20c054c5e4 Fixup! Correcting typos, adding logging line for shutdown, and adding sys info rule details.
12-01 21:45:02    2511116b55 Add graceful shutdown documentation.
12-01 21:45:02    4842b6e948 Fixup! Changing graceful-shutdown doc to 80-char line length.
12-01 21:45:02    afcced6b08 Fixup! Adding link to system information rules and phrasing changes.
12-01 23:21:03    77d9a35b40 Update Kafka docs with tested versions
12-01 23:21:03    e10e8106ed Add Kafka tests against latest 5.5.2
12-02 23:25:18    e3c4ba863e Remove extra stat call when opening Iceberg files
12-04 00:58:44    f14ec75cb8 Adds S3 endpoint configuration to security mapping
12-04 01:15:45    7d48b21496 Remove deprecated isVarcharType and isCharType methods
12-04 01:16:19    3032bbe62b Update to ANTLR 4.9
12-04 01:26:47    f681708aab Implement s3 streaming upload

Grzegorz Kokosiński

[x] all checked
11-26 10:21:23    28bc79b7db Make filterColumns to be coherent with other filter methods
11-26 10:21:23    b9e3f42cf4 Use static import
11-26 20:13:52    1a73f83c6b Implement tests for CachingJdbcClient
11-26 20:13:52    bcb24d086f Fix caching for TableHandle in CachingJdbcClient
11-27 09:23:59    463c2313a0 Use Cache instead of LoadingCache
11-27 13:34:31    ae830d65c7 Propagate more information from ConnectorSession to ConnectionFactory
11-29 08:36:01    684a61028c Lowercase alias in testCastTimestampToTimestampWithTimeZone
12-01 11:08:11    3879f4557b Add OAuth2 WebUI authenticator
12-01 11:08:11    61b517f289 Extract waiting for the node refresh
12-01 11:08:11    7d026cc39e Ensure static web assets are always visible
12-01 11:08:11    ced3a05f81 Expose http server https uri in TestingPrestoServer
12-03 20:14:05    2aeae824ab Extract AvroDecoderModule
12-04 14:54:01    c2ac3ab273 Accept Scope at ExpressionTestUtils.resolveFunctionCalls()

Karol Sobczak

[x] all checked
11-27 12:39:29    47dbf0ab8d Make sure operators have matching ids across tasks
11-27 12:39:29    510208ae7b Fix formatting
11-27 12:39:29    f84cf5ecfb Remove redundant LocalExecutionPlanContext#getSession
11-27 15:06:17    b983b9a3ee Fix formatting
11-27 15:06:17    df4fe40be6 Validate operator type when merging OperatorStats
11-27 15:37:49    4c2e09e4ce Merge null and non-null cases in BenchmarkBlockSerde
11-27 15:37:49    8461ec1c5e Extract data generation from BenchmarkBlockSerde
11-27 21:54:54    2103f11a48 Move assertExplainAnalyze to AbstractTestQueryFramework
11-27 21:54:54    714bf35188 Make OperatorHashCollisionsStats self-contained
11-27 21:54:54    9e6bb0854a Gather plan node auxiliary statistics separately
11-27 21:54:54    e95dac7347 Fix collisions reporting for joins
11-30 21:17:34    004033f6c2 Correctly prune dynamic filters in LocalDynamicFilterConsumer
11-30 21:17:34    68c7424b92 Remove redundant tests
11-30 21:18:57    152e3360ff Add more types to BaseBlockEncodingTest
11-30 21:18:57    1bf513b2d0 Generify TestLongArrayBlockEncoding
12-01 07:35:07    2e4191db9a Add static imports
12-01 07:35:07    ac1c71bccc Fix mask matching in AggregationMatcher
12-01 07:35:07    b6486f8c20 Fix aggregation symbols mapping
12-01 07:35:07    ca5a0f7024 Cast null to expected type
12-01 10:45:24    4e9fe72594 Document insert overwrite limitation
12-02 10:43:23    d0858b5162 Improve serde performance for Int96 blocks
12-02 10:45:17    0330d9eee4 Reduce unexpected Integer object creation
12-02 10:54:20    0e33c35333 Extract BackgroundHiveSplitLoader#createHiveSymlinkSplits
12-02 10:54:20    7e019cc70a Efficiently enumerate symlinked files from manifest
12-02 10:54:20    cea86fb98a Add Parquet symlink table product test
12-03 21:29:39    1b54652c9b Fix testRedirectAfterColumnPruningOnPushedDownPredicate test
12-03 21:29:39    2cdba9aa0b Add test when filter domain type is different then target column type
12-08 10:44:27    61d33ccb25 Improve split generation for symlinked tables

Martin Traverso

[x] all checked
11-25 23:09:57    02dd2929b9 Remove unused exception declaration
12-05 00:33:57    4bfb13c7ba Add rules for decorrelation of aggregations
12-05 00:33:57    709a673545 Verify that grouping keys are not correlated
12-05 00:33:57    7e1831d2ee Add comment explaining decorrelation of AggregationNode
12-05 00:33:57    8123b66d9b Support matching filter in AggregationFunctionMatcher
12-05 00:33:57    f76feca5ce Support multiple filter to mask rewrites for aggregation

Piotr Findeisen

[ ] all checked
11-25 22:55:29    c88b2f0057 Add explanation for calcite-core dependency exclusion
11-25 22:58:39    72eb05a26e Simplify loading columns into cache in CachingJdbcClient
11-26 12:49:05    cd542ac5bb Remove version-based condition from TestHiveBasicTableStatistics
11-26 13:02:29    e300ae8ec9 Ensure no operator info is ignored
11-26 18:10:56<PHONE_NUMBER> Fix container startup time measurements when start retried
11-27 09:49:44    3582199a11 Make testUnwrap more flexible
11-27 09:49:44    a0c5155467 Verify expected plan consistently
11-27 09:49:44    a10aaf1c6e Separate tested behavior from mechanics in TestUnwrapCastInComparison
11-27 20:55:54    8eb2fa930f Mark TestSyncPartitionMetadata as @Flaky
11-28 18:45:17    4e97e917fd Declare TS alias with same case as used in the expected plan
11-28 18:45:17    9310d75775 Use same symbol case as declared in TS aliases
11-28 18:45:17    b18c1cd3f5 Make SymbolAliases case-sensitive
11-29 19:55:43    7fd58225de Add convenience method for getting assignment during aggregation pushdown
11-29 20:03:46    872e0271b4 Fix indeterminism in PlanNodeStats mergeability check
11-30 09:13:14    3041d98d6d Support getting array as List from ResultSet
11-30 09:13:14    69ce786942 Change representation of ROW on the client side
11-30 09:13:14    8f7fc54288 Convert array to object representation recursively
11-30 14:39:23    2b4355959b Split JSON date-time formatter tests
11-30 14:39:23    95b0d0c49a Support writing TIMESTAMPTZ with JSON encoder
11-30 22:12:42    9a225c3f94 Fix equals check on Optional
11-30 22:12:42    bb115e212d Aid with IDE syntax highlighting for Flaky.match
11-30 22:12:42    c55d7ba4b8 Remove redundant .* from the pattern
12-01 11:47:04    a91537a0c2 Supplement type mappings in JDBC connectors
12-01 11:47:04    c14338872e Replace IFs with a SWITCH
12-01 15:30:03    d5cf3ab266 Fix terminal width detection in CLI
12-03 15:30:50    3834af604f Fix retries in TestRaptorIntegrationSmokeTest.testCreateBucketedTable
12-03 15:30:50    e202eff3bd Remove incorrect @Flaky annotation
12-04 08:10:42    04533cc4cf Fix TIMESTAMP [TZ] in JDBC when nanos overflow
12-04 08:10:42    613c7c5996 Remove redundant checks on server capabilities
12-04 08:10:42    e59d9eaa8f Separate TIMESTAMP and TIMESTAMP WITH TIME ZONE test cases
12-04 08:10:42    ee45530f06 Fix formatting
12-04 10:31:08    46fbb4bf4e Make JdbcTypeHandle.columnSize optional
12-04 10:31:08    7e76c0b683 Validate DATA_TYPE is present
12-04 10:31:08    d4954f8011 Remove @JsonCreator annotations from non-@JsonCreator constructor
12-04 13:27:47    0bc66f4eec Improve error reporting when one of test cases fails
12-04 13:27:47    0bcf1fc33e Test with implicit session zone in TestJdbcResultSetTimezone too
12-04 13:27:47    12ba4e9cd1 Allow different literals for compared databases
12-04 13:27:47    5365728e40 Prepare tested data once
12-04 13:27:47    a36ddb1a78 Declare support by default in test reference driver
12-04 13:27:47    c7aca9bdff Rephrase TIMESTAMP TZ ResultSet tests in point-in-time semantics
12-04 13:27:47    f12937d89f Fix formatting
12-04 13:27:47    fc8dd44bfc Test TIMESTAMP WITH TIME ZONE calendar compatibility
12-04 23:46:57    ca82c4091d Use the passed type to serialize in SerDeUtils
12-04 23:46:57    f5f1d9a275 Simplify HiveType.getTypeSignature with factory methods
12-07 13:16:25    94160af09f Report malformed Presto JDBC URL better
12-07 14:44:56    ba496198bc Fix typo in PostgreSQL type mapping test
12-07 21:55:45    920583b50a Fix 'testCreateExternalTableWithFieldSeparator' flakiness
12-07 21:58:09    3a9cc19163 Verify before getting element from a list
12-07 21:59:30    d09188a2a6 Test no predicate pushdown in case of forced mapping to varchar
12-07 22:04:26    5fcc7fe623 Limit number of threads created by TestSqlStageExecution
12-07 22:05:03    6ef69bb10e Update @Flaky annotation
12-08 13:40:39    028d724260 Use literal expected values in TestJdbcCompatibility
12-08 13:40:39    20aa88cd9b Remove excessive use of String.valueOf in ResultSet
12-08 13:40:39    232fc982cc Fix TIME/TIMESTAMP TZ column declaration for result set
12-08 13:40:39    32f5c74ed1 Use AssertJ for comparing arrays
12-08 13:40:39    47cb68d1e1 Define type conversions in terms of source type name
12-08 13:40:39    4cfe3ae221 Convert array elements to proper representation
12-08 13:40:39    50d45f1933 Allow SQLException within convertFromClientRepresentation
12-08 13:40:39    833ba38e31 Unify ResultSet.getObject logic with type conversions
12-08 13:40:39    8db281ecc5 Fix typo
12-08 13:40:39    e15b71e7d6 Add test for SQL Array element type introspection
12-08 13:40:39    ef2c9a1e5e Add runtime type checks when invoking type conversion
12-08 13:40:39    fb8bf99066 Fix product test README examples
12-08 13:46:21    752b87ea58 Verify ResultSetMetaData column type declaration against reference driver
12-08 13:46:21    7d950e505c Use more descriptive variable name
12-08 13:47:57    2d92d051a9 Support TIMESTAMP WITH TIME ZONE as ZonedDateTime in JDBC
12-08 13:47:57    73a6929740 Separate TIMESTAMP [TZ] parsing and conversion
12-08 13:50:16    2b31f2bb4f Remove imprecise conversion with Number in MaterializedResult
12-08 14:21:00    3a733493c6 Add aggregation pushdown test cases with unsupported functions
12-08 14:36:23    f92c6c3940 Fix test case for INSERT with unsupported type
12-08 17:05:41    2c8b58f53e Fix SphericalGeography handling on the client
12-08 17:05:41    55b38fd275 Remove redundant else
12-08 17:05:41    d23f7d6ed9 Expose QueryAssertions.matches(MaterializedResult)

Pratham

[ ] all checked
12-07 23:34:31    92d0caab3e Add catalog name to SplitCompletedEvent
12-07 23:34:31    bbfd486fb3 Add deserializer class name to HiveSplit#getInfo
12-07 23:48:52    fcb565a6bb Add documentation for subnet based topology

Yuya Ebihara

[x] all checked
11-30 06:39:30    423d82643f Add Cassandra unit test class against latest 3.11.9
11-30 06:39:30    75ba0d9020 Update Cassandra docs with tested versions
11-30 06:39:30    cbbc6aaf69 Extract BaseCassandraDistributedQueries
11-30 10:38:35    a366eb6452 Use DockerImageName in TestingMemSqlServer

Łukasz Osipiuk

[x] all checked
11-27 10:02:35    5f0a0a0c6c Add extra wait time for query Events in tests
11-27 10:02:35    ff2d42ac5a Drop extra query-completed event for queries failing during preparation
11-27 11:10:49    621cc20ec9 Allow running multiple suites
12-01 11:16:01    28b3f624a1 Mark TestEventListenerBasic.testPlanningFailure flaky
12-03 18:09:35    f89304fbab Mark testArrayOfMapOfStruct and testDoubleNaNInfinity as @Flaky
12-03 18:10:04    90d04bd94b Ensure exactly single delivery of query completion event
12-03 23:06:43    16c38d05a8 Allow using legacy Hive view translation logic
12-03 23:06:43    630a0ae764 Pass session to view reader factory
12-04 18:10:37    28703a907d Use simple type instead if an object
12-07 12:47:35    f88b1154dd Ensure query-created event is called before query-completed event
12-08 18:02:39    39dd7aeda0 Fix qdigest type braces in docs

SPI
----
 * Change `SystemAccessControl#filterColumns` and `ConnectorAccessControl#filterColumns` method to accept a set of column names and return a set of visible column names.

JDBC Connectors
----
* Fix table metadata information caching. Previously cache did not store information if table exists and it was always verifing that in remote database.  ({issues}`6081)

#6081

UI
--

* Fix operator stats reporting in detail stage view. ({issue}`6114`)

https://github.com/prestosql/presto/pull/6114

General
-------

* Fix ``EXPLAIN ANALYZE`` for certain queries that contain broadcast join. ({issue}`6115`)

https://github.com/prestosql/presto/pull/6115

CLI
* Fix rendering of `row` values with unnamed fields. Previously they were printed using fake field names like `field0`, `field1`, etc. ({issue}`4587`)

JDBC
* Change representation of a `row` value. `ResultSet.getObject` now returns an instance of `io.prestosql.jdbc.Row` class, which better represents
  the returned value. Previously a `row` value was represented as a `Map` instance, with unnamed fields being named like `field0`, `field1`, etc.
  You can access the previous behavior by invoking `getObject(column, Map.class)` on the `ResultSet` object. ({issue}`4588`)

#4587 #4588

Kafka
* Allow writing `timestamp with time zone` values into columns using `milliseconds-since-epoch` or `seconds-since-epoch` JSON encoders. ({issue}`6074`)

#6074 #5955

General
-------
* Fix planning failures for queries that contain filtered aggregation and outer joins. ({issue}`6141`)

https://github.com/prestosql/presto/pull/6141

General
---
* Add support for OAuth2 authorization in Web UI. ({issue}`5355`)

#5355

CLI
- Fix query progress reporting. ({issue}`6119`)

#6119

General:
* Improve query performance by reducing worker to worker communication overhead. ({issue}`6126`)

https://github.com/prestosql/presto/pull/6126

General:
* Reduce memory pressure and improve performance of queries that contain join. ({issue}`6176`)

https://github.com/prestosql/presto/pull/6176

Hive:
* Reduce planning latency for queries where scanned files that are referenced by symlinks
  are located in same directory . ({issue}`6158`)

https://github.com/prestosql/presto/pull/6158

JDBC
* Fix failure when reading a `timestamp` or `timestamp with time zone` value with second fraction greater than or equal to<PHONE_NUMBER>00 picoseconds. ({issue}`6147`)

#6147 https://github.com/prestosql/presto/pull/6149

* Fix incorrect results when correlated subquery in join contains aggregation functions such as `array_agg` or `checksum`. ({issue}`6145`)

https://github.com/prestosql/presto/issues/6145

* Add support for `DISTINCT` clause in aggregations within correlated subqueries. ({issue}`5904`)

https://github.com/prestosql/presto/issues/5904

## SPI Changes:

* Expose catalog names corresponding to the splits through the split completion event of the event listener. ({issue}`6006`)

## Hive Connector:

* Add deserializer class name to hive connector split information, which is exposed through the event listener. ({issue}`6006`)

#6006

Hive
* Improve parallelism for queries that scan symlinked tables. ({issue}`6213`)

https://github.com/prestosql/presto/pull/6213

JDBC
* Fix element representation in arrays returned from `ResultSet.getArray`, making it consistent with `ResultSet.getObject`.
  Previously the elements were represented using internal client representation (e.g. `String`). ({issue}`6048`)
* Fix `ResultSetMetaData.getColumnType` for `timestamp with time zone`. Previously the type was miscategorized as `java.sql.Types.TIMESTAMP`. ({issue}`6251`)

#6251  https://github.com/prestosql/presto/pull/6208 #6048

JDBC
* Allow reading `timestamp with time zone` value as `ZonedDateTime` using `ResultSet.getObject(int column, Class<?> type)` method. ({issue}`307`)

#307

CLI
* Fix failure when instance of `SphericalGeography` Geospatial type is returned to the client. ({issue}`6238`)

JDBC
* Fix failure when instance of `SphericalGeography` Geospatial type is returned in the `ResultSet`. ({issue}`6240`)

#6238 https://github.com/prestosql/presto/pull/6240

General
* Fix duplicate call to event listener on query completion if query failed early during preparation for execution. ({issue}`6103`)

#6103

## Iceberg Connector

* Optimize predicate pushdown by using filters on non-partition columns during split generation and table scan. ({issue}`4932`)

#4932

Hive
* Allow fallback to legacy Hive view translation logic via `hive.legacy-hive-view-translation` config property or `legacy_hive_view_translation` session property. ({issue}`6195 `)

#6195 #5977

JDBC
* Fix failure when reading a `time` value with second fraction greater than or equal to<PHONE_NUMBER>00 picoseconds. ({issue}`6204`)

part of #6204, https://github.com/prestosql/presto/pull/6206

JDBC
* Represent `varbinary` value using hex string representation in `ResultSet.getString`. Previously the return value was useless, similar to `"B@2de82bf8"`. ({issue}`6247`)

#6247 https://github.com/prestosql/presto/pull/6246

JDBC Connectors
----
* Consider session properties when caching metadata. ({issue}`6167`)
* Fix cache entries invalidation, so entries are removed for all users not only the one that was running the query. ({issue}`6167`)

#6167

# Iceberg Connector Changes

* Add support for Google Cloud Storage and Azure Storage. ({issue}`6186`)

#6186

# Hive Connector Changes

* Allow configuring S3 endpoint in security mapping. ({issue}`3869`)

#3869

# Hive Connector Changes

* Verify that data is in the correct bucket file when reading bucketed tables.
  This is enabled by default, as incorrect bucketing can cause incorrect query results,
  but can be disabled using the `hive.validate-bucketing` configuration property
  or the `validate_bucketing` session property.

#6012

# Hive Connector Changes

* Reduce load on metastore when metastore caching is enabled with background refresh
  by removing background refresh for partition metadata and statistics. ({issue}`6101`)

#6101

# Hive Connector Changes

* Decrease default refresh thread count for metastore cache. ({issue}`6156`)

#6156

# Iceberg Connector Changes

* Remove extra file system stat call when opening files. ({issue}`6174`)

#6174

# Hive Connector Changes

* Add support for S3 streaming uploads. Data is uploaded to S3 as it is written, rather
  than staging to a local temporary file. This feature is disabled by default and can be enabled
  using the `hive.s3.streaming.enabled` configuration property. ({issue}`3712`, {issue}`6201`)

#3712, #6201

JDBC
*  Fix the value of the `DATA_TYPE` column for `time(p)` and `time(p) with time zone` in the result set returned from `DatabaseMetaData#getColumns`.  ({issue}`6307`)
* Report precision of the `time(p)`, `time(p) with time zone`,  `timestamp(p)` and `timestamp(p) with time zone` in the `DECIMAL_DIGITS` column
  in the result set returned from `DatabaseMetaData#getColumns`. ({issue}`6307`)

https://github.com/prestosql/presto/pull/6307

# General
* Fix query failure when views are accessed and current session does not specify default schema and catalog. ({issue}`6294`)

#6294 #6296

# General
* Improve performance of top-n queries. ({issue}`6072`)

#6072

JDBC
* Accept `java.time.LocalDate` in `PreparedStatement.setObject(int, Object)`. ({issue}`6299`)

#6299 #6301

General
* Fix incorrect query results when using `timestamp with time zone` constants with precision higher than 3 describing same point in time but in different zones. ({issue}`6318`)

#6318 https://github.com/prestosql/presto/pull/6310

General
* Support arbitrary query in `SHOW STATS`. ({issue}`3109`)
* Output of `SHOW STATS` is changed ({issue}`3109`):
   * null fraction is normalized to `1` for tables with row count `0`, regardless of what the stats returned by the connector.
   * all relation columns are listed, even if duplicated.

#3109


list object has no attribute 'lower'

(Please take the time and describe the problem you're having before you propose a solution.)
What I'm trying to achieve
The only change I made was to use sqlite3 instead of postgres.
...
Steps to reproduce the problem
1.Simply checked out from git
2. replaced the database directive
it failed
...
(Please include a stack trace if this problem results in a crash.)
Starting development server at http://0:8000/
Quit the server with CONTROL-C.
ERROR django.request Internal Server Error: / [PID:23989:Thread-1]
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/django/core/handlers/exception.py", line 35, in inner
response = get_response(request)
File "/usr/local/lib/python3.4/dist-packages/django/utils/deprecation.py", line 93, in call
response = self.process_request(request)
File "/usr/local/lib/python3.4/dist-packages/django/middleware/common.py", line 55, in process_request
host = request.get_host()
File "/usr/local/lib/python3.4/dist-packages/django/http/request.py", line 97, in get_host
if domain and validate_host(domain, allowed_hosts):
File "/usr/local/lib/python3.4/dist-packages/django/http/request.py", line 565, in validate_host
if pattern == '' or is_same_domain(host, pattern):
File "/usr/local/lib/python3.4/dist-packages/django/utils/http.py", line 273, in is_same_domain
pattern = pattern.lower()
AttributeError: 'list' object has no attribute 'lower'
ERROR django.request Internal Server Error: / [PID:23989:Thread-1]
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/django/core/handlers/exception.py", line 35, in inner
response = get_response(request)
File "/usr/local/lib/python3.4/dist-packages/django/utils/deprecation.py", line 93, in call
response = self.process_request(request)
File "/usr/local/lib/python3.4/dist-packages/django/middleware/common.py", line 55, in process_request
host = request.get_host()
File "/usr/local/lib/python3.4/dist-packages/django/http/request.py", line 97, in get_host
if domain and validate_host(domain, allowed_hosts):
File "/usr/local/lib/python3.4/dist-packages/django/http/request.py", line 565, in validate_host
if pattern == '' or is_same_domain(host, pattern):
File "/usr/local/lib/python3.4/dist-packages/django/utils/http.py", line 273, in is_same_domain
pattern = pattern.lower()
AttributeError: 'list' object has no attribute 'lower'
ERROR django.server "GET / HTTP/1.1" 500 83661 [PID:23989:Thread-1]
ERROR django.server "GET / HTTP/1.1" 500 83661 [PID:23989:Thread-1]
ERROR django.server "GET / HTTP/1.1" 500 83661 [PID:23989:Thread-1]

I'm using Django 2, I guess your code is not compatible with that.

Oh my bad, I messed up with the settings.

Also please take a note that Saleor is developed against the PostgreSQL as it elevates features specific to it (like hstore) and will not work with SQLite.
If you are looking to play around with it on local host, Docker is fast and easy way to go about it:
Setting up the Saleor for development on localhost

Thank you,
I will try to isntall Postgres then.

Oh my bad, I messed up with the settings.

Maybe say why there is this bug could be usefull for other peoples maybe ?


add support for NIRStar 14.2 files

Describe the new feature or enhancement
Please provide a clear and concise description of what you want to add or
change.
I am trying to import my fNIRS data with
mne.io.read_raw_nirx("/Users/name/Downloads/PROTOCOLLO_TDCS_FILE_GREZZI/SHAM/CONTROLLI/2018-11-27_002/")
but I have this error message
Loading /Users/name/Downloads/PROTOCOLLO_TDCS_FILE_GREZZI/SHAM/CONTROLLI/2018-11-27_002/
:1: RuntimeWarning: Only import of data from NIRScout devices have been thoroughly tested. You are using a "NIRSport 8x8" device.
mne.io.read_raw_nirx("/Users/name/Downloads/PROTOCOLLO_TDCS_FILE_GREZZI/SHAM/CONTROLLI/2018-11-27_002/")
:1: RuntimeWarning: Extraction of measurement date from NIRX file failed. This can be caused by files saved in certain locales. Please report this as a github issue. The date is being set to January 1st, 2000, instead of "mar 27 nov 2018""18:13:22.559"
mne.io.read_raw_nirx("/Users/name/Downloads/PROTOCOLLO_TDCS_FILE_GREZZI/SHAM/CONTROLLI/2018-11-27_002/")
Out[8]: <RawNIRX | 2018-11-27_002, 40 x 1934 (247.4 s), ~54 kB, data not loaded>
We used a continuous wave NIRS system (NIRSport 8X8, Nirx Medical Technologies LLC, Berlin, Germany). The fNIRS data acquisition software was the NIRStar 14.2 (Version 14, Revision 2, Release Build, 2016-04-15 NIRx Medizintechnik GmbH, Berlin, Germany; www.nirx.net).
Describe your proposed implementation
Describe how you think the feature or improvement should be implemented (e.g.,
as a new method on an existing class? as new capability added to an existing
method?) If you're not sure, please delete this section and the next section.
Please, could you help me to implement a function that can import my data?
Describe possible alternatives
If you've suggested an implementation above, list here any alternative
implementations you can think of, and brief comments explaining why the chosen
implementation is better.
Additional comments
Add any other context or screenshots about the feature request here.

Can you share the problematic file? Or even better, any chance you could record a little 1 sec data file from this system and share that so we could add it to our tests?

cc @rob-luke

Sure,
Please find enclosed an example of data that gives me that issue
2020-01-24_SHAM_CTRL_0050.zip
I am looking forward to hearing from you
.

Hi @mlrocca,
Thanks for this very clear report. MNE currently only supports reading NIRx data from NIRStar version 15.0 and above. Whereas, you are trying to read data acquired with NIRStar version 14.2. I don't think the file format changed very much, so adding support might not be too much effort. Could you open a PR to add support for older NIRx files?

This might also be related to https://github.com/mne-tools/mne-python/pull/7891 where we had issues handling dates with formats other than Australian English.

Thank you,
I opened a new issue to add support for older NIRx versions.
If there is also the issue of the dates, is it possible to fix that too?
Best,

Ok thank you,
how long do you think you will take to implement that feature?
Are you going to advice me when it will be implemented?

Ok thank you,
how long do you think you will take to implement that feature?

I don't know.  The winter holidays mean many of our developers are not available right now.

Are you going to advice me when it will be implemented?

The pull request that fixes the issue will be linked here and will automatically close this issue when it is merged in.  Unless you've disabled it in your GitHub notification settings, you will get a notification when that happens.

Hi,
any update on the implementation of the feature in the object?


pip install requirement.txt  。 i run this in a pure conda enviroment ,is not ok ~ which version could be satisfied? can u help me

as the title u can see

thanks for your reply ~
but i tried the command "unset PYTHONPATH" in that link 。Also come wrong as : ERROR: Could not find a version that satisfies the requirement rospy>=1.15.14 (from versions: none)
ERROR: No matching distribution found for rospy>=1.15.14
maybe,because of my conda enviroment python is 3.10.X 。not support more perfect the ROS than python2.7

You will need to look in the answers section of the stackoverflow link I sent, not the question.
Anyway, maybe install the packages one by one (from requirement.txt) using conda (because you have a conda environment, not pip). For example: conda install -c conda-forge ros-rospy.

I am going to close this issue, because it is unrelated to the repo.


[🐛 Bug Report]: Visualization draw_model function crashes on None/Null

Describe the bug
From the This example notebook Visualization.ipynb:
Call to neuralogic.utils.visualize.draw_model function, draw_model(model), results in the following error:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-7-59797e1249fd> in <module>
      7 model = template.build(Backend.JAVA, Settings())
      8
----> 9 draw_model(model)

...\lib\site-packages\neuralogic\utils\visualize\__init__.py in draw_model(model, filename, draw_ipython, img_type, value_detail, *args, **kwargs)
     93     template_drawer = get_template_drawer(get_drawing_settings(img_type=img_type, value_detail=value_detail))
     94
---> 95     return draw(template_drawer, template, filename, draw_ipython, img_type, *args, **kwargs)
     96
     97

...\lib\site-packages\neuralogic\utils\visualize\__init__.py in draw(drawer, obj, filename, draw_ipython, img_type, *args, **kwargs)
     55         return
     56
---> 57     data = bytes(drawer.drawIntoBytes(obj))
     58
     59     if draw_ipython:

TypeError: cannot convert 'NoneType' object to bytes

Similarly, adding a filename to the call (draw_model(model, 'img.png'), see code snippets below) results in a NullPointerException:
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
...\lib\site-packages\_jpype.cp38-win_amd64.pyd in cz.cvut.fel.ida.drawing.Drawer.drawIntoFile()

...\lib\site-packages\_jpype.cp38-win_amd64.pyd in cz.cvut.fel.ida.drawing.GraphViz.writeImageToFile()

~\Anaconda3\envs\bakalarka\lib\site-packages\_jpype.cp38-win_amd64.pyd in java.io.FileOutputStream.write()

Exception: Java Exception

The above exception was the direct cause of the following exception:

java.lang.NullPointerException            Traceback (most recent call last)
<ipython-input-8-91eec29cdcf5> in <module>
      7 model = template.build(Backend.JAVA, Settings())
      8
----> 9 draw_model(model, 'img.png')

...\lib\site-packages\neuralogic\utils\visualize\__init__.py in draw_model(model, filename, draw_ipython, img_type, value_detail, *args, **kwargs)
     93     template_drawer = get_template_drawer(get_drawing_settings(img_type=img_type, value_detail=value_detail))
     94
---> 95     return draw(template_drawer, template, filename, draw_ipython, img_type, *args, **kwargs)
     96
     97

...\lib\site-packages\neuralogic\utils\visualize\__init__.py in draw(drawer, obj, filename, draw_ipython, img_type, *args, **kwargs)
     51 def draw(drawer, obj, filename: Optional[str] = None, draw_ipython=True, img_type="png", *args, **kwargs):
     52     if filename is not None:
---> 53         drawer.drawIntoFile(obj, os.path.abspath(filename))
     54
     55         return

java.lang.NullPointerException: java.lang.NullPointerException

Steps to reproduce the behavior
I have come across this error in my own example codes, but it is enough to run the Visualization.ipynb notebook, concretely:
from neuralogic.utils.visualize import draw_model
from neuralogic.utils.data import XOR_Vectorized
from neuralogic.core import Settings, Backend

template, dataset = XOR_Vectorized()
model = template.build(Backend.JAVA, Settings())

draw_model(model)

For the NullPointerException, I used:
from neuralogic.utils.visualize import draw_model
from neuralogic.utils.data import XOR_Vectorized
from neuralogic.core import Settings, Backend

template, dataset = XOR_Vectorized()
model = template.build(Backend.JAVA, Settings())

draw_model(model, 'img.png')

Expected behavior
I should be able to visualize the model.
Environment
No response
Additional context
No response

Hi, thanks for the bug report.
Can you verify you have the latest version of PyNeuraLogic, which is 0.1.4? I feel like this issue has been solved.
Thanks

Indeed, this is with the current 0.1.4. I was actually getting other error before upgrading the package (but haven't saved the stack trace). I can try to completely reinstall the package later, if that helps.

I can confirm that the same issue appears on macOS as well

Hi, I released a new version 0.1.5 (changelog), that should contain a fix for this issue. I added some tests running on Windows, and it seems to work, but unfortunately, I wasn't able to check macOS.
Now, NeuraLogic will try to use the dot executable from Path. If it isn't installed on your Path, then you can specify the path via the new graphviz_path parameter of draw_model and draw_sample.
Can you please try it out again if it works now @martin-krutsky @borisrakovan ? Thanks

I can confirm it works for me on Windows, both in the visualization notebook and in my own experiment. Thanks! @borisrakovan, feel free to close this issue, if you can confirm the issue is solved on macOS, as well.

I bumped the version to 0.1.5 and the drawing works fine on macOS. Thanks.


Enrich Simapro flows with CAS number before matching

Issue from https://github.com/fjuniorr/flowmapper/issues/8#issuecomment-1867316058.
There are at least two ways to go about this depending if must of the work will be done by users or flowmapper maintainers:

If the users would do must of the work then we don't need to change anything[^1]. The data transformation (ie. adding a cas number) can simply be provided as a data migration file and everything will work as expected.

If this should be a builtin[^2] it falls on flowmapper maintainers and we need to decide if it's better to add the information as constants or do a dynamic search during the match process[^3].

Maybe for now the best is to stick with 1 and create a data migration file from SProf94_final_substanceList.xlsx that can be used as needed by users.
[^1]: Maybe increase the priority of match_identical_cas_numbers?
[^2]: Such as context mapping
[^3]: Using something like CAS Common Chemistry API (I haven't looked their license terms nor pricing conditions)

Maybe for now the best is to stick with 1 and create a data migration file from SProf94_final_substanceList.xlsx that can be used as needed by users.

Yes, this is the way.

Using something like CAS Common Chemistry API (I haven't looked their license terms nor pricing conditions)

Better to use ChemIDPlus, it's free and has the info we want.

Ok, that was really fast! :sweat_smile:


Document stability guarantees

This documents the stability guarantees of windows, windows-sys, and windows-bindgen. Once we agree on the text in this PR, I proceed to file similar PRs for the lib.rs documentation of our respective crates.
cc/ @RobJellinghaus, I believe you had thoughts on stability guarantees? How does this read to you?

I think this sort of thing doesn't belong in the readme just yet - it's too vague and aspirational and the readme is prime real estate. 😉
Perhaps an FAQ, so long as it is maintained and updated. Or better yet a "Stabilization" issue. Even then, I question the wording or value at this stage in light of the fact that we use semver which explicitly reserves 0.x releases for pre-release software. So, there is already the implication that the windows crates are pre-release.

I think the standard for stability for representing the Windows API has to be a higher standard than what random OSS libraries do.

We discussed this in our meeting last week at great length and you were on board with the concept at that time. What changed?
Sent from Samsung Galaxy smartphone.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Kenny Kerr @.>
Sent: Monday, January 24, 2022 8:22:16 AM
To: microsoft/windows-rs @.>
Cc: Rob Jellinghaus @.>; Mention @.>
Subject: Re: [microsoft/windows-rs] Document stability guarantees (PR #1449)
Closed #1449https://github.com/microsoft/windows-rs/pull/1449.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/windows-rs/pull/1449#event-5943794126, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAXRYZMVFTWTNQJILOZBKK3UXV4DRANCNFSM5MVYHVSA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>


Document how to load the CVMFS environment

Everything is ready except to

[ ] document it,

[ ] what would be a good user experience here? Wrapper scripts?
[ ] think about constraining to x86-64-v4

[ ] think about long term support policy, we shouldn't be keeping all of them forever...

(base) [northgridsgm@cvmfs-uploader02 simonsobservatory]$ pwd
/cvmfs/northgrid.gridpp.ac.uk/simonsobservatory
(base) [northgridsgm@cvmfs-uploader02 simonsobservatory]$ ls -1 pmpm conda
conda:
so-conda-20231121
so-conda-20231122
so-conda-20231123
so-conda-py310-20231211
so-conda-py310-20231212
so-conda-py38-20231211
so-conda-py39-20231211

pmpm:
so-pmpm-py310-mkl-x86-64-v3-mpich-20231212
so-pmpm-py310-mkl-x86-64-v3-openmpi-20231212
so-pmpm-py310-mkl-x86-64-v4-mpich-20231212
so-pmpm-py310-mkl-x86-64-v4-openmpi-20231212
so-pmpm-py310-nomkl-x86-64-v3-mpich-20231212
so-pmpm-py310-nomkl-x86-64-v3-openmpi-20231212
so-pmpm-py310-nomkl-x86-64-v4-mpich-20231212
so-pmpm-py310-nomkl-x86-64-v4-openmpi-20231212

Close with 8050b21, 38afe07, 13e441e among others.


Allow iteration over keys with #each (and include Enumerable)

I would like to be able to iterate over all keys in a Trie, or all keys that start with a certain prefix (keys that are under a certain TrieNode.) Right now, there is no way to tell what keys are in the trie without trying to access every possible letter from every possible trie node.
You could support this by implementing #each, which should enumerate all objects in the trie, in order. Implementing #each will also allow you to include Enumerable, which provides many convenient methods.
Without this functionality, I cannot use this library to implement the word game GHOST. With my current array implementation, I print a random sample of words that start with a certain prefix:
starting_word_offset = Kernel::rand(wordlist.length - NUM_OF_WORDS_TO_SHOW)
wordlist_subset = wordlist[starting_word_offset, NUM_OF_WORDS_TO_SHOW]

And I also use Enumerable methods to filter the words in the trie:
return wordlist.reject { |word| word.length < MINIMUM_WORD_LENGTH }

If providing this functionality would make Trie operations unacceptably slower, you can provide two trie classes with your library: a SimpleTrie and a Trie, where a Trie provides more methods, but is slightly slower.

The inability to enumerate all objects in the trie is a limitation of the underlying data structure implementation and is an intentional trade-off. This is using a dual-array trie, which has the advantage of being highly compact. The downside is that the only way to tell whether or not a particular branch exists is by attempting to traverse it.
Without completely changing the underlying implementation there is no way around this. There are other trie implementations that do not have that limitation which would probably be a better fit for your use case.

Newer versions of the upstream C library libdatrie reportedly support breadth-first traversal (and some other kind?), so progress might be possible
See https://github.com/kmike/datrie/blob/master/libdatrie/ChangeLog#L376 and https://github.com/kmike/datrie/blob/master/libdatrie/ChangeLog#L342

They add the TrieIterator stuff a while ago, but it's implemented in the way I mentioned above. (See: https://github.com/kmike/datrie/blob/9e794aac1f68ebf920bd46e977825f374a64dc47/libdatrie/datrie/darray.c#L825-L830) I'd actually forgotten that I'd implemented the same thing really early on in order to support the Trie#children method. (See: https://github.com/tyler/trie/blob/master/ext/trie/trie.c#L227-L228) I was hesitant to add that because of the performance implications... I prefer not to add things which are egregiously inefficient. Unless you're familiar with the code it can be very easy to shoot yourself in the foot. (The difference between Array#push and Array#shift in Ruby is my favorite example of this.)
But given that it already exists, is implemented in the upstream library, and would apparently be useful to people... Maybe I should reconsider.

@tyler What other trie implementations would you suggest if I need this functionality?


lxd/storage: Backward compatibility for content types

Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Testsuite passed


Add E2E framework functions to create Service w/o selector and Endpoints

This PR is to add E2E framework functions to create Service w/o selector and Endpoints.
These functions are needed by https://github.com/submariner-io/submariner/pull/1455 and maybe be reused by other E2E tests.

As a result of testing with these functions, I found that name field in Endpoints's port needs to match with name field in Service's port. So, these functions are modified to take portName as an argument.


dangerouslySetInnerHTML is not working in hono/jsx/dom

What version of Hono are you using?
4.0.0-rc.0
What runtime/platform is your app running on?
any
What steps can reproduce the bug?
import { render } from 'hono/jsx/dom'

const root = document.getElementById('root') as HTMLElement

const Div = () => {
  const inner = { __html: '
Hello
' }
  return

}

render(
, root)

What is the expected behavior?
Render the content:

Hello

What do you see instead?

Additional information
No response

https://github.com/EdamAme-x/hono/blob/5ba31090dabe4dd275babde22cfb427167ee4add/src/jsx/dom/index.ts#L348
It looks like it could be implemented here.

@EdamAme-x
Thanks. But this will be fixed by #1955.

Fixed, thanks!


Pass ODCS renew params as JSON

CLOUDBLD-437

Signed-off-by: Athos Ribeiro<EMAIL_ADDRESS>Maintainers will complete the following section:

[x] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[x] Pull request includes link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

No release notes added: Fixing feature introduced in this release cycle


outsource iteration state

@kwk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1756-1


[FEATURE] supports variables expansion inside k3d config

It would be convenient if k3d expand variables inside the config file.
For instance for environnement variables

This addition will be very helpful.

Hey @myannou , thanks for opening this issue!
The feature will land in k3d v5.0.0 (hopefully) soon-ish :+1:


Fixed Rust benchmark for complex benchmark names

This fixes cargo/criterion benchmarks for benchmarks that have complex names, with spaces or parenthesis, for example.

Hello @rhysd, let us know if there is something else we should be adding here. This issue breaks our CI, and we had to fork the action to make it work.

closed by PR #94


docs: explain better the distinction between islands and components

Quoting @CAYdenberg in: https://github.com/denoland/fresh/issues/2363#issuecomment-2004817651

Well, if it helps, components that are children of islands can receive functions as props. So, your ComplexOrBigComponent could live in components/, receive onClick when used as a descendent of an island, and not receive it when used outside of an island. Just mark onClick as being optional in your props interface declaration (and handle the cases where it is undefined).

I also found this confusing at first. When should a file go under components/ versus islands/?
I had thought that islands were client-side and components were server-side, but that's not right.  (Why? Because there are restrictions on what you can pass in to an island.)
In particular, the component page has some components tagged as islands that are really just components that can run on both client and the server. (A button could be an island, but why?)

I don think is confusing, from the docs: https://fresh.deno.dev/docs/concepts/islands

Islands enable client side interactivity in Fresh. Islands are isolated Preact components that are rendered on the server and then hydrated on the client. This is different from all other components in Fresh, as they are usually rendered on the server only.

You mentioned

In particular, the component page has some components tagged as islands that are really just components that can run on both client and the server.

Thats what islands are, thats what the docs says "components that are rendered on the server and then hydrated on the client."
And for

(A button could be an island, but why?)

Why would not? buttons can be used to trigger forms by using props, or actions by onClick event, for the second will always be necessary to be an island or be used inside and island

I think based on the fact that multiple people are confused (who presumably took the time to try to understand, since they took the time to give feedback), that by definition it is confusing.
I think the concept that needs to be fleshed out is that the children of islands are still "within" the island. Or, put differently, a distinction should be made between the island "entry-point" and the components which are part of the island.
However, I am not a maintainer, so I won't make the call myself. It's also possible the change should be folded into the broader re-org of the Getting Started section (#319)

I think based on the fact that multiple people are confused (who presumably took the time to try to understand, since they took the time to give feedback), that by definition it is confusing.

I guess u are right 🤔

Component: function that starts with an uppercase letter that can use hooks and optionally return JSX. Doesn't say anything about where it runs.
Island: A form of component that is bundled and executed it in the browser, looks the exact same as a normal component. The only difference is that they're put in special files like islands/MyIsland.tsx and Fresh flags components exported from these as an island.
Server Component: A form of component that's only run on the server. Looks the exact same as a normal component, only difference is where it's executed.

Just as an anecdote, I did find this somewhat confusing at first, especially because I copied the Button island into a component in my Fresh project, and then was confused why it was constantly disabled. Of course, now this makes sense to me.
But then when I look at the interactive islands documentation now, looking at the following example:
islands/my-island.tsx
import { useSignal } from "@preact/signals";

export default function MyIsland() {
  const count = useSignal(0);

  return (

      Counter is at {count}.{" "}
      <button onClick={() => (count.value += 1)}>+</button>

  );
}

It's now clear to me that the button here, could be a components/Button and still function perfectly fine. I wonder if in a documentation level it's worth just creating an example which illustrates this use case a little more? Something like:
islands/my-island.tsx
import { useSignal } from "@preact/signals";
import Button from '../components/Button.tsx'

export default function MyIsland() {
  const count = useSignal(0);

  return (

      Counter is at {count}.{" "}
      <Button onClick={() => (count.value += 1)}>+</Button>

  );
}


Add Build Stage to Continuous Delivery pipeline

As a Developer
I need a build stage for my CD pipeline
So that I can run unittests and push my docker image to the IBM cloud registry
Details and Assumptions

Needs to be on the shared IBM cloud account
Must checkout the code from GitHub repo
Must run nosetests
Must build a docker image and push it to the IBM Cloud registry

Acceptance Criteria
Given the shared IBM Cloud is working
When I set up the build stage for the CD pipeline
Then it should run all unittests for the service and push the newly built docker image to the IBM Cloud registry

Build stage passing


Allow more supported docker versions

The docker version installed on the VM I'm using is 20.10.17 and everything is working if I remove this check. So we can lower it to support a wider range.

Did you also check the docker compose version ?

It doesn't have a compose version pre-installed. I installed a recent version myself.


[Q] stream_type 0xC0 (192) reported as unknown from analyze plugin

I am using tsduck 3.36-3528 on windows 10
analyze plugin, in the pid list,  reports pid with stream_type 192 as Unknown.
shouldn't it be "private data"?
{ 			"audio": false, 			"bitrate": 17755, 			"bitrate-204": 19266, 			"description": "unknown (0xC0)", 			"ecm": false, 			"emm": false, 			"global": false, 			"id": 666, 			"is-scrambled": false, 			"packets": { 				"af": 0, 				"clear": 97, 				"discontinuities": 0, 				"dts": 0, 				"dts-leap": 0, 				"duplicated": 0, 				"invalid-scrambling": 0, 				"pcr": 0, 				"pcr-leap": 0, 				"pts": 0, 				"pts-leap": 0, 				"scrambled": 0, 				"total": 97 			}, 			"pmt": false, 			"service-count": 9, 			"services": [ 				14205, 				14206, 				14209, 				14210, 				14212, 				14239, 				14255, 				14256, 				14260 			], 			"t2mi": false, 			"unit-start": 97, 			"unreferenced": false, 			"video": false 		},
thanks

ISO 13818-1 (MPEG-2 TS) says that stream types 0x80 to 0xFF are "user private". However, within the context of higher level standards, some of these values have known meaning. For 0xC0, it is just unknown...
0xC0 to 0xD0 used to be used by Canal+ a long time ago, when I was working there. Since there were so many technical changes in the meantime, I do not know if their previous private interpretations are still valid (these stream types are still there but commented out in the tsduck.dtv.names file).


camel-cdi: Fix dead link in adoc

Changed API doc link to javadoc.io
Also updated the CDI doc link to version 2.0 (which is the version used by the component)

Thank you


Have all the packages in the same tree

A thing that really bugs me is that I can't pip install https://github.com/schlamar/pytest-cov/archive/2.0.zip. This is quite inconvenient for development where I have to use requirement files (most always).
Having that in mind having two repos for the whole shebang wasn't that bad ....
What do you think about this?

You can install from subdirectories in pip's "editable" mode. See example 5 on https://pip.pypa.io/en/latest/reference/pip_install.html#examples

You're right


Can't paste anything

Running the contributed command:'editor.action.clipboardPasteAction' failed.

Hi @Alexandria65r, can you please provide the following info?

VSCode version
What OS are you using?
Do you have extensions installed, and are you able to reproduce the problem after running Reload Window with Extensions Disabled?
What were you doing before you saw the error message? Do you always see this error when trying to paste?


Added capitalization warning during CSS introduction

Pre-Submission Checklist

[ x] Your pull request targets the staging branch of freeCodeCamp.
[ x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ x] You have only one commit (if not, squash them into one commit).
[ x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ x] Tested changes locally.
[ x] Closes currently open issue (replace XXXX with an issue no): Closes #14006

Description

Following the issue reported and the discussion, I've added the following lines of text into the very first tab of introduction to basic CSS lesson in order to inform campers about capitalization in CSS:

Note that CSS is case-sensitive so be careful with your capitalization.

To me that was the place where adding this few lines of text made the most sense, but I'm happy to reconsider and change accordingly.
Also I have kept the same syntax as the other seeds description and created the space by writing a double <br>.
Here's a screenshot of the finished product:

@Marmiz Tested locally and LGTM! 👍 🌮 ⚡

@Marmiz excellent wording. Thanks for this PR!


fix: Microsoft.Authorization model validation

Remove leading slash for DOUBLE_FORWARD_SLASHES_IN_URL errors

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?


Depth image back projection doesn't handle pinhole and transform3d on same entity

How to reproduce:
pip install rerun-sdk==0.8.2
Then run the following code:
import numpy as np
import rerun as rr

# Create a dummy depth image
image = 65535 * np.ones((200, 300), dtype=np.uint16)
image[50:150, 50:150] = 20000
image[130:180, 100:280] = 45000

rr.init("rerun_bug_backproject", spawn=True)

rr.log_transform3d("world/camera", rr.RotationAxisAngle([0, 1, 0], radians=np.pi / 2))

rr.log_pinhole(
    "world/camera",
    width=image.shape[1],
    height=image.shape[0],
    focal_length_px=200,
)

rr.log_depth_image("world/camera/depth", image, meter=10000.0)

Which gives the following result:

Commenting out  rr.log_transform3d("world/camera", rr.RotationAxisAngle([0, 1, 0], radians=np.pi / 2)) gives:

And changing the entity path in rr.log_pinhole from world/camera" to world/camera/depth" also works:

Closing as duplicate of https://github.com/rerun-io/rerun/issues/3296


Fix/privacy manifest

Issue Number
#5

Summary

Update the versions of some libraries to those that are compliant with the Privacy Manifest.
Update the versions of some libraries.
Update the minimum supported Flutter version to 3.19.0.
Modify the test code.

I am currently fixing the issue with the failing Github Actions checks.

I have completed the revisions, so please feel free to review the PR.


[Core] archive extraction under windows/linux does not work

Extracting archives under windows and linux seems not to work, as the temporary directory is not being properly created. This might be a permission problem and has to be tested

Hi,
First of all, great job with c3po. I tried using the c3po on windows and I am not sure if it works - I do not find the c3po-cmd.jar, do I have to build and compile myself or is there way out? . Have the aforementioned bug been fixed? What is the remedy that you guys suggest?
Thank you
Harish

Thank you for your kind words, @proteann. I am glad that you have been able to resolve the problem. Unfortunately, I am no longer supporting c3po.
Maybe @artourkin can give you some more insight about the project and whether it is still developed/supported by the UT Vienna or OPF? Thanks @artourkin
best


Update on "Build Your First Application"

Description

Reference the view() function (for rendering templates) as a function instead of method.
Removed unused code (that got copied from CI3)
Added references to other part of the userguide
Code examples are up to CI4 coding standards
Using esc() to prevent XSS, and give hints about it.
Use view() method consistent in the tutorial. First pages had showme, and later on used view() for News. Give user a warning about the different view() method and function.
Improved rendering on some elements
Always reference a method by index() and not index.

Checklist:

[X] Securely signed commits
[X] User guide updated
[X] Conforms to style guide

Looks great to me! I'll give @MGatner  a chance to resolve his change request.


Generate Transit Gateway using ACK runtime v0.15.1

Issue #, if available:
https://github.com/aws-controllers-k8s/community/issues/489
Description of changes:
process is broken up into commits between the generated and manual steps.

Generate Transit Gateway resource Create and Delete
Tests for Create and Delete (the sleeps on TGW create and delete are lengthy because the resource takes so long to be created and will error out if a delete is attempted while in a "pending" state)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/test ec2-kind-e2e


adding ts-jest mock util functions in jest-mock

Summary
This PR can close #9534  which was opened as a feature request by @ahnpnl
This PR includes  -

mocked test helpers from ts-jest https://github.com/kulshekhar/ts-jest/blob/main/src/utils/testing.ts

type MockedClass , Mocked  from @types/jest https://github.com/DefinitelyTyped/DefinitelyTyped/blob/a68259ee8883cc9899463fe79a78bb49a9d2f6de/types/jest/index.d.ts#L1042-L1298

there is also another proposal for partialMocked in  kulshekhar/ts-jest#1065 which  can  be added after these changes are approved.
Any suggestions/ changes  which can help in closing the above issue are most welcome.
Test plan

Sorry for messing up with commits
Forget to create a new branch XD


Add Eloisa Guerrero to Contributors list

Adding myself to the list.

@grrrero, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I accepted it?


[Concurrency] Adopt stable keyword consuming instead of __owned

Description:
This change is ABI stable with regards to the mangled name of the enqueue method.
We confirmed this by manually comparing mangled names of a method with __owned and later a consuming parameter -- please double check this though @kavon as you'd know more about this than myself.
This also improves diagnostics around implementing move-only job requirement, since the diagnostics offered by _owned are wrong: they don't show the attribute leading people to add     func enqueue( job: ExecutorJob) which is incorrect because they MUST add consuming.
This PR includes tests that simulate an SDK with either the __owned or consuming versions and implementations with the other spelling, to make sure this works as expected.
Risk:  Low, the mangling and ABI is the same.
Review by: @kavon @DougGregor
Testing: CI testing; manually verified mangling of the changed method
Original PR: https://github.com/apple/swift/pull/65571
Radar: rdar://108467550

@swift-ci please test

Depends on https://github.com/apple/swift/pull/65455 since that introduces new methods; so we want to do the same to the new ones IF we are to merge these new methods.

@swift-ci please test

Github is having issues; Exception: ['git', 'clone', '--recursive', 'https://github.com/apple/swift-docc.git', 'swift-docc'] checkouts failing

@swift-ci please test

Just as a note:

This also improves diagnostics around implementing move-only job requirement, since the diagnostics offered by _owned are wrong: they don't show the attribute leading people to add func enqueue( job: ExecutorJob) which is incorrect because they MUST add consuming.

This isn't what the PR is improving. It's just using the consuming attribute rather than __owned, because the latter is confusing for people to see because it's not one of the official ownership specifiers (it's an old name for consuming). So this change is really about changing an API so it uses the better names for this. I don't think we're ever going to suggest people write __owned in a diagnostic.

I mean this specifically was causing bad diagnostics telling people to implement "enqueue( job: ExecutorJob)" which then would not compile, since it was missing the __owned; Unless I'm misremembering this change also causes producing the right diagnostic.

Thanks for review!


[GC] Removed deprecated getBaseGCDetails and related code

getBaseGCDetails and related code were deprecatedmore than a year ago by https://github.com/microsoft/FluidFramework/pull/14196. This PR removes it.

@DLehenbauer @anthony-murphy  Can we remove deprecated api causing public api change until 2.3?

@DLehenbauer @anthony-murphy Can we remove deprecated api causing public api change until 2.3?

The ones removed aren't public. They are alpha / legacy.

@DLehenbauer @anthony-murphy Can we remove deprecated api causing public api change until 2.3?

The ones removed aren't public. They are alpha / legacy.

alpha APIs are the ones we can't remove until 2.3. public APIs can't be broken until 3.0.

Okay. I will hold off on this PR until 2.3 then. Thanks!


Added html img component instad of next/image when using srcSet

Summary

Added the <img /> component instead of next/image when using srcSet
It has been added on PostContent file, to be used on Group Blocks.

Notes

Added the @next/next/no-img-element on the eslint rules, because was getting an error to don't use the <img /> tag.
components/PostContent/PostContent.tsx line 27 was added to prevent warning on if statement.

@elazzabi Make sense, I did some tests here, and you're right. So maybe we can add a config inside the next.config.js file and check it inside the if statement. What do you think?

@elazzabi I did the update with the config approach. Let me know what do you think about it.

@elazzabi Talking with @chriszarate today, we had the idea to create a new file with the vip.configs to keep the next.config.js file with only the settings from next.js. I moved the logic and comments to the new file and worked on your requests. Thanks :)

@elazzabi Can you double-check the last suggested change? If I understood your request, it's already been done.

@luiztiago Hmm weird, it still shows that we are using defaultProps instead of imageProps 🤔

@elazzabi It's fixed now, sorry I misunderstood your request before.

@elazzabi Hey, just a reminder, if you can approve it again because I did some updates after your first approval :)


Add Nick to AUTHORS.rst

cc @CircArgs

Done!https://github.com/DataJunction/dj/commit/d53f8189c321078d149d6e9fcfdc74e06215d236


System provided scards support

Hi,
In this PR I've implemented the system provided smart cards support. Now the user can use real smart cards using our library as well as emulated ones.
More information you can read in those pull requests descriptions:

https://github.com/Devolutions/sspi-rs/pull/246
https://github.com/Devolutions/sspi-rs/pull/248
https://github.com/Devolutions/sspi-rs/pull/249
https://github.com/Devolutions/sspi-rs/pull/250
https://github.com/Devolutions/sspi-rs/pull/251

Implementation notes

The sspi loads all additional libraries (like libpcsclite or winscard.dll) in the runtime. Related discussion: https://github.com/Devolutions/sspi-rs/pull/246#discussion_r1621256727.
The system scards implementation is hidden under the WinScard and WinScardContext. The system scard is just another implementation of these traits. Our custom FFI layer works only with high-lever Rust API. It gives us a few advantages:

Easier to maintain the system scard implementation.
Easier to maintain our FFI layer.
Easier to debug.
Fewer if/match expressions in the FFI layer.

We've introduced the RequestBufferType and OutBuff types to improve the memory management.

Configuration
The user should set the WINSCARD_USE_SYSTEM_SCARD env variable with the value set to true to use system-provided smart cards.
The sspi library uses the PCSC Lite library on Linux and macOS to access the system-provided smart card. This library is loaded in the runtime. The user can use the PCSC_LITE_LIB_PATH env variable to specify the libpcsclite location.
The standard WinSCard will be used on Windows. But the user has an ability to confiture the winscard.dll location using the WINSCARD_LIB_PATH env variable. It can be helpful in situations when the original winscard.dll is hooked and we need to call the original one anyway.
Demo
Using mstscex:
https://github.com/Devolutions/sspi-rs/assets/43034350/172137a8-b8f4-41a4-b6c8-6853418f37e0
Using FreeRDP:
https://github.com/Devolutions/sspi-rs/assets/43034350/1ce20d19-4032-4997-bc15-ac5984bf87e2
Note
Currently, only the winscard part pf the sspi-rs is modified. Currently, our CredSSP implementation can use only the emulated smart card. We plan to improve the CredSSP module in next iterations.
Docs & references:

winscard.h
PCSC Lite

cc @awakecoding

@TheBestTvarynka Do you want to rebase or squash this PR? If rebasing, can you reword the commits? Thank you!

On Windows, with mstscex, I'm always getting E_INVALIDARG (0x80070057):

I'm trying to use a Windows virtual smartcard device with this in my .RDP file, similar to what it would be without sspi-rs:
username:s:@@BooZeoydRgfEwgrQROH1cL4sWZlA
ClearTextPassword:s:12345678
My environment variables:
MSRDPEX_LOG_LEVEL=DEBUG
MSRDPEX_LOG_ENABLED=1
MSRDPEX_CREDSSP_DLL=C:\wayk\dev\sspi-rs\target\release\sspi.dll
MSRDPEX_WINSCARD_DLL=C:\wayk\dev\sspi-rs\target\release\sspi.dll
SSPI_LOG_LEVEL=trace
SSPI_LOG_PATH=C:\wayk\dev\sspi-rs\target\release\sspi.log
SSPI_KDC_URL=IT-HELP-DC.ad.it-help.ninja
WINSCARD_USE_SYSTEM_SCARD=1

From my testing in Windows, it is still checking all the WINSCARD_ environment variables required for virtual smartcards. I would have expected WINSCARD_USE_SYSTEM_SCARD=1 to be the only one required? I also expects the certificate file and key which makes no sense for the system-provided smartcard.

Note
Currently, only the winscard part pf the sspi-rs is modified. Currently, our CredSSP implementation can use only the emulated smart card. We plan to improve the CredSSP module in next iterations.

@TheBestTvarynka Do you want to rebase or squash this PR? If rebasing, can you reword the commits? Thank you!

I would like to rebase this PR. Yes, I'll reword commits

If rebasing, can you reword the commits?

@CBenoit, done!


Predis Error while reading line from the server

I try to modify the config like this:
set read_write_timeout = -1...

Did not work for me, same error

We had the same error with AWS ElastiCache. read_write_timeout = -1 results in an error "Can not write bytes to server".
Our solution was to disconnect Predis connection in our forked process. It reconnects itself on the next access to redis.


setup to lint git staged files with lint-staged and husky

I did not add anything to the readme, as I was unsure of how you would want to include details (If you decide to merge this).

thank you very much @rubinj30

thank you very much @rubinj30


Video wall

Add VIDEO_WALL related commands
I only need the trivial VIDEO_WALL_ENABLE, maybe you can have a look over the second commit: VIDEO_WALL_MODEL.
This is more complicated; maybe you can have a look how you like this implemented?

I tested everything from the first commit; the second one should also work now.

@helge000 Thanks for PR, great work!
I merged it and released in 1.8.0 version with some fixes:

There is no need to keep SERIAL of video wall in same field as coordinates. So I moved it to separate field.
pack_videowall implementation wasn't clear for me - so I rewrite it - hope it still works the same)
What was the reason for limit for x * y < 90 and serial < 90? I believe this should be 100 or 99 for 10x10 video wall? There is no such limit in latest protocol documentation (see MDC-Protocol.pdf from root repository), there is 225 limit (15x15 max), but I believe it's ok to leave such errors to samsung anyway (to NAK error), or add separate error for exceeding limit (don't mix it with wrong tuple length i mean) - but really I wouldn't bother).

Please test it on your video wall and confirm everything is ok, or feel free to create new PR if you think I missed something!


IncubateEggs update

Short Description:
IncubateEggs task now return WorkerResult depending on egg hatching.
Now uses class Pokemon from inventory.py to display Pokemon stats and data.
Created table eggs_hatched_log in db to log eggs hatched.
Print ncp of the Pokemon.
Fixes/Resolves/Closes (please use correct syntax):

Closes #4930

CI failed because the incubate_eggs_test.py isn't updated with the changes I made so the task uses de DB. I don't know what I must change here.


[Feature] [UI] Improve the clarity of event list display in trace span

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Change the event list in trace span to Trace view
Use case
Currently, the event list displayed in trace spans is not clear and easy to understand. We suggest implementing a trace display mode where the current span is used as the root span, and event names are displayed as span names. Additionally, the events should be sorted based on their start time (in nanoseconds) to form a trace tree. This way, the names of the events will be easily visible on the left side, and the execution time will be easily visible on the right side. This will greatly improve the overall visibility and clarity of the trace spans.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

We just need to reuse similar UI component, it doesn't need to a span.

This could be using the style of alerting page to show the time series flow.

Sure. Also, I propose adding a timeline to the right side of the Trace view(style like the below image) to quickly and easily visualize each event's start and end times.

Resolved by https://github.com/apache/skywalking-booster-ui/pull/234


ValueError: 'CAMSv0.6p-FDRes' is not in list

GitHub Actions fails with:
2024-02-09 17:54:02 INFO Syncing iNaturalist observation Observation(id=197415492, taxon=Taxon(id=75499, full_name=Species: Araujia sericifera (Moth Vine)), observed_on=Jan 24, 2024, user=User(id=138584, login=keiths, name=Keith S), place_guess=Birkenhead, Auckland, New Zealand)
2024-02-09 17:54:02 INFO Observed on 2024-01-24T11:11:28
2024-02-09 17:54:02 INFO Found existing CAMS feature with 1 visit rows for iNaturalist id 197415492
2024-02-09 17:54:02 INFO Reading CAMS feature where OBJECTID='[116](https://github.com/EcoNet-NZ/inaturalist-to-cams/actions/runs/7839779532/job/21393360190#step:7:117)778'
2024-02-09 17:54:02 INFO Found visit table row {"attributes": {"OBJECTID": 116778, "GUID_visits": "c5594198-38dd-434f-ba29-ed3c3a0d0059", "DateCheck":<PHONE_NUMBER>000, "Area": null, "Height": null, "Treated": null, "HowTreated": null, "Age": null, "Flowering": null, "GlobalID": "cf937efe-cfc8-468c-8171-2c2973afd873", "UrgencyForReturnVisit": null, "Difficulty": null, "CheckedNearbyRadius": null, "VisitType": null, "HoursSpent": 0.2, "NumberOfVolunteers": null, "Sex": null, "NotesAndDetails": "contractors will be digging up bank to build retaining wall", "NbrPodsRemoved": null, "WhoVisitedName": null, "WhoVisitedEmail": null, "ProjectOrJob": null, "NextSteps": null, "NumberOfStems": null, "GUID_Preserve": null, "VisitStage": null, "CreationDate_1":<PHONE_NUMBER>199, "Creator_1": "Inat-to-CAMS_econethub", "EditDate_1":<PHONE_NUMBER>714, "Editor_1": "ksalmon_econet", "ReqForServiceDetails": null, "ContractorEngaged": null, "DateForReturnVisit": null, "BioControlInd": null, "WeedVisitStatus": "RedGrowth", "TreatmentSubstance": null, "TreatmentDetails": null, "iNatRef": "197415492", "PodsBurst": null, "PlantsRemainingMature": null, "PlantsRemainingImmature": null, "LocationOnProperty": null, "BasicOptionsFlag": "Basic", "HelpNeeded": null, "SeedsDispersed": null, "DifficultyChild": null, "PlantsPresentImmature": null, "PlantsPresentMature": null, "PlantsControlledImmature": null, "PlantsControlledMature": null, "iNaturalistURL": "https://www.inaturalist.org/observations/197415492", "SiteDifficulty": null, "ObservationQuality": "needs_id", "VisitDataSource": "CAMSv0.6p-FDRes", "SendEmail": null, "Visit_Date_Editor_SaveLast": "TurnedOff", "EditDate_SaveLast": null, "Editor_SaveLast": null, "Date_Editor_SaveLast": null, "CommunicationURL": null}}
2024-02-09 17:54:02 INFO Found layer row {"geometry": {"x":<PHONE_NUMBER>970181, "y": -36.820426154587, "spatialReference": {"wkid": 4326, "latestWkid": 4326}}, "attributes": {"OBJECTID": 66671, "DateDiscovered":<PHONE_NUMBER>000, "GlobalID": "c5594198-38dd-434f-ba29-ed3c3a0d0059", "SpeciesDropDown": "MothPlant", "SiteSource": "CAMSv0.6p-FDRes", "Urgency": null, "LocationInfo": "Opp 35 Hinemoa -   but will be dug up when retaining wall built", "OtherWeedDetails": null, "LastSeasonStatus": null, "PropertyContactDetails": null, "GeoPrivacy": null, "ParentGuid": null, "CreationDate_1":<PHONE_NUMBER>708, "Creator_1": "Inat-to-CAMS_econethub", "EditDate_1":<PHONE_NUMBER>261, "Editor_1": "ksalmon_econet", "ParentStatusWithDomain": "RedGrowth", "Elevation": null, "iNatURL": "https://www.inaturalist.org/observations/197415492", "DateVisitMadeFromLastVisit":<PHONE_NUMBER>000, "DateForNextVisitFromLastVisit": null, "LatestVisitStage": null, "LatestArea": null, "StatusDisplay": null, "StatusAt202211": null, "AddressAuto": "Autocalc turned off", "LandOwnership": null, "DedupStatus": null, "DateOfLastCreateFromLastVisit": 170605045[119](https://github.com/EcoNet-NZ/inaturalist-to-cams/actions/runs/7839779532/job/21393360190#step:7:120)9, "DateOfLastEditFromLastVisit":<PHONE_NUMBER>714, "AddressSortKey": null, "WeedInstanceNotes": null, "UnitOwnership": null, "EditDate_SaveLast":<PHONE_NUMBER>470, "Editor_SaveLast": "Audit Trail suspended", "EditorNames_SaveLast": "Salmon (EcoNet), Keith", "DataQualityCheck": null, "StatusAt202310": null, "UseCalcAddr": null, "Date_Editor_SaveLast": null, "UserName": "GetUser($layer).Username", "UserName2": "GetUser($layer).username", "UserEditDateTime": null, "ContactURL": null}}
Traceback (most recent call last):
  File "/home/runner/work/inaturalist-to-cams/inaturalist-to-cams/inat_to_cams/config.py", line 47, in cams_field_key
    return list(field_dict.keys())[list(field_dict.values()).index(value)]
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: 'CAMSv0.6p-FDRes' is not in list

See https://github.com/EcoNet-NZ/inaturalist-to-cams/actions/runs/7839779532/job/21393360190

Resolved by adding all the SiteSource values to the ./config/cams_schema.json file.
Still need to find why it occurred and possibly ensure the configuration is kept up to date with changes to SiteSource.
The problem was caused by one of the features having an iNaturalist URL but also having a SiteSource of "CAMSv0.6p-FDRes". Is the SiteSource updated when you edit the feature? I figured it would stay constant so would always by "iNaturalist" for observations we synced.
If we are updating the SiteSource when changes are made, we'll need to either loosen up our checking, or make sure we add new values to our configuration when they are added to CAMS.

Modified to be a simple text field rather than a list of values in 56d6803


I am getting an error after upgrading to latest mobx

https://github.com/mobxjs/mobx-react-devtools/blob/1f8a998114cd5c7c1a92bdcb4580ce1e975ac7e3/src/consoleLogChange.js#L240
Is this pending to be fixed or is there a specific option I need to configure mobx with to expose the debug names?
Thanks
Andy

Is there a version of the dev tools in the works compatible with MobX 4?

No response on this yet? Hopefully it's because they're hard at work updating the library...

Don't worry, it's being worked on
Op zo 18 mrt. 2018 05:44 schreef Jack Linton<EMAIL_ADDRESS>
No response on this yet? Hopefully it's because they're hard at work
updating the library...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx-react-devtools/issues/84#issuecomment-373972716,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhF4KU13Rw45tJSQvNIiXNuSe3Ar8ks5tfeYrgaJpZM4SnN9M
.

Published<EMAIL_ADDRESS>compatible with mobx@4

It gives a warning during install as the mobx peer dependency in package.json have not been updated, but otherwise works fine. Thanks!

It seems to work but I am getting a whole bunch of "undefined" reaction names and I don't quite know where they are coming from. There seems to be some names not being picked up in the tooling.

@kalmi, thanks, fixed in 5.0.1
@richtera, this is more related to mobx-react package, see https://github.com/mobxjs/mobx-react/pull/368


fix the type of the stargazer_count column TEXT -> INT (and upd…

…ate README)

Codecov Report

Merging #159 (e8cbb04) into main (f5bbd4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   68.34%   68.34%
=======================================
  Files          36       36
  Lines        1744     1744
=======================================
  Hits         1192     1192
  Misses        355      355
  Partials      197      197

Impacted Files
Coverage Δ

extensions/internal/github/org_repos.go
75.34% <ø> (ø)

extensions/internal/github/user_repos.go
72.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bbd4c...e8cbb04. Read the comment docs.


Feature request: treat every var as let?

Is it possible to add an option to treat each var-statement as if the developer wrote a let-statement?
My javascript-code is currently filled with warnings for variables declared twice:
for(var i = 0; i < array1.length; i++) {
    //Do something
}
for(var i = 0; i < array2.length; i++) {
    //Do something else
}

This is pretty annoying, since the code is totally fine in my opinion. Moving the var-statements to the top would IMO not improve readability at all.
This issue could be easily resolved if each var-statement is simply treated like a let by jshint.
Could this be implemented as an option?
Since it will still take a lot of time until all browsers support let, this would IMO still be worth it.

i quite agree for the need for an option like that; i guess it could be added to the already relatively crowded "shadow" function.
the main argument for forcing var statements at start of functions is due to the hoisting problem, and the supposed danger of putting one loop inside another one with doubly declared same-named variables.
fact is, it nearly never happens, does it? however, to copy paste code from one function to another is common thing, isn't it, and what happens if this copy-pasting doesn't take account of the loop variable declared possibly very very above in the source function? well the destination function will nicely create a global variable at first call.
now of course jshint would take care of that kind of error too, but this is i think, despite current norm, quite a bad habit to take in the case where one ends up in a place where a l/hinter isn't accessible.
anyhow, i think that, better than var === let, it would be more bulletproof to make an added suboption to the "shadow" option that only warns about shadowing for more-than-one-level-nested blocks, that is, only if there's at least two levels of non-functional blocks inside the same scope with a shadowing problem.
this would prevent the rare but possible nested loop (or whatever) trouble, but would nicely reduce negative verbosity.

Can you post an example of what you mean by "doubly nested blocks"?
BTW: Detecting the special for-syntax would not solve my problem. Rather often, I do also declare variables inside if-blocks:
if (x) {
    var y = 12;
    //Do something with y.
} else {
    var y = 13;
    //Do something else with y.
}

Can you post an example of what you mean by "doubly nested blocks"?
Sorry, i have a long history of not being clear at all. ^^
The best sentence that resumed what i meant was this one:
anyhow, i think however that, better than var === let, it would be more bulletproof to make an added sub-option to the "shadow" option that warns about shadowing only if there's at least two levels of non-functional blocks inside the same scope with a shadowing problem.
non functional blocks == if/for/while/etc blocks, two levels would mean a for loop in a for loop that would redeclare a variable of the first for loop or of the functional block that contain both for loops, or else.
i tried to resume everything in the following explicative snippet:
function foo()
{
	for (var i = 0; i<10; i++) // first for loop
	{
		//...

			//second for loop
		for (var i = 5; i<10; i+=2) {}
			/*	this [[i]] variable is being redeclared inside
				this second for loop's block
					(
						proof just in case:

						the for loop special "(a;b;c)" structure
						is indeed part of the for loop (potentially fake) scope:
						if it were a let declaration,
						it would be considered as inside this
						second for loop's scope

						in other terms:
							for (var a = 0;;) {}
						is scope-equivalent to:
							for (;;){var a = 0}
						although of course it doesn't do the same thing.
					).

				But, the first declaration of i was inside a nested block
				(the first for loop's), itself inside the functional block
				of foo()

				Thus, with this second for loop's block,
				it makes a double nesting of non-functional blocks,
				that is of blocks that share the same scope.

				Schematically:
					foo scope <= first for <= second for
				each arrow representing a nesting of non-scoping block.

				=> to raise a warning seems statistically relevant,
				because there's a true risk of having done the shadowing
				of the variable [[i]] by mistake.
			*/

		//...

		function foo2()
		{
			var i = 42

			//here obviously, there's a double nesting of blocks:
				//foo scope <= first for <= foo2 scope
			//but since this last foo2 block is functional, and consequently,
			//creates a real true scope, well the classical rule applies:
			//no warning.
		}
	}

	//...

	var i = 5, max = 20
	for (; i
i'm not sure it's quite clear, don't hesitate questioning me.

Are you suggesting that you don't think JSHINT should warn if you do
for (var i = 0; i < 10; ++i) {
  for (var i = 0; i < 5; ++i) {}
}

? Because it's an endless loop

Is it possible to add an option to treat each var-statement as if the developer wrote a let-statement?

No.

Thank you very much for the nice clarification, why this does not make any sense for you.
Currently, our JS-Code is in a very clean state. A justified warning here and there, but that's it - except several pages of redeclarations in the jsHint-output.
IMO, this change would be very easy to implement, would not interfere with anything else and would help many developers a lot.

caitp: i probably haven't expressed myself clearly enough, once more ^^
no, your endless loop case would be part of what my idea of option would warn for: there's (at least) two for loops = two blocks that aren't functions, that is, which share the same scope, and shadowing => danger, warning.


options in project scaffolding screen can be taller

taken from https://github.com/aurelia-ui-toolkits/assets/issues/4
. the scrollbar is unnecessary

Funny - how obvious and I missed it


chore: bump unstructured-inference to 0.7.3

Summary

bump unstructured-inference to 0.7.3

NOTE: The TextRegion class has been updated in the new unstructured-inference version 0.7.3, so the code and test cases related to the TextRegion class have been updated.

This is being handled in #1634

This is being handled in #1634

Okay, Thanks for letting me know!

handled in #1634


langkaer.txt

Langkaer Gymnasium/HF/IB World School

@adrianleong98: Do you mean http://langkaer.dk/?
If school doesn't offer higher education it doesn't fit in Swot database, it can only be added to https://github.com/kiler129/SwotNG-database


Regularisation losses with nested layers and BasicDecoder

System information

OS Platform and Distribution : Manjaro Linux testing
TensorFlow version: tensorflow-gpu 2.0 from pypi
TensorFlow-Addons version: 0.6.0 from pypi
Python version: 3.7.4
Is GPU used? (yes/no): yes

Describe the bug
Building a seq2seq model based on tfa.seq2seq seems to return a wrong number of regularisation losses for the decoder. Assume that both the encoder and the decoder use LSTM cells with the kernel_regularizer argument set. No other variables were regularised in the making of this model.
Calling model.losses (where model is an instance of tf.keras.Model) appears to return the correct number of losses for the Encoder module (one regularisation loss per LSTM layer), but the incorrect one for the Decoder. In particular, it is the same loss value replicated three times, instead of appearing only once. The effect is an overestimation of the total batch loss, possibly causing divergence issues.
Code to reproduce the issue
I have implemented the training loop in the most basic way, like this:
    def _train_step(self, data):
        with tf.GradientTape() as tape:
            prediction = self.model(data, training=True)
            main_loss = loss_fn(logits=prediction, label_ids=data.labels, sequence_lengths=data.labels_length)
            loss = tf.add_n([main_loss] + self.model.losses)

and the model is implemented as in the readme file.
This is how nested_layers list within self._gather_children_attribute('losses') in keras.engine.base_layer.py looks like:
result = {list} <class 'list'>: [<tensorflow.python.keras.layers.recurrent_v2.LSTMCell object at 0x7f80502bd9d0>, <tensorflow.python.keras.layers.core.Dense object at 0x7f80502bd2d0>, <tensorflow.python.keras.layers.embeddings.Embedding object at 0x7f80502a4c10>, <tensorf
 0 = {LSTMCell} <tensorflow.python.keras.layers.recurrent_v2.LSTMCell object at 0x7f80502bd9d0>
 1 = {Dense} <tensorflow.python.keras.layers.core.Dense object at 0x7f80502bd2d0>
 2 = {Embedding} <tensorflow.python.keras.layers.embeddings.Embedding object at 0x7f80502a4c10>
 3 = {BasicDecoder} <tensorflow_addons.seq2seq.basic_decoder.BasicDecoder object at 0x7f80503946d0>
 4 = {BeamSearchDecoder} <tensorflow_addons.seq2seq.beam_search_decoder.BeamSearchDecoder object at 0x7f80502a4410>
 __len__ = {int} 5

The issue here is that LSTMCell, BasicDecoder, and BeamSearchDecoder all return the same .losses value. All three classes are instantiated in my Decoder's constructor. It looks like the two decoders need to be removed from the list, since they only hold a reference to LSTMCell, while the variables were not created there. I suspect this behaviour may also appear in other similar cases where there is a "has" relationship between classes.
Other info / logs
pinging @fchollet as well since the git log indicates familiarity with the code in base_layer.py.

Here is a minimal example to reproduce the issue outside the scope of tfa.seq2seq
import tensorflow as tf

class A(tf.keras.layers.Layer):
    def __init__(self, layer):
        super(A, self).__init__()
        self.layer = layer

    def call(self, inputs):
        return self.layer(inputs)

class B(tf.keras.layers.Layer):
    def __init__(self):
        super(B, self).__init__()
        self.obj = tf.keras.layers.Dense(13, kernel_regularizer=tf.keras.regularizers.l1(5))
        self.layerB = A(self.obj)

    def call(self, inputs):
        return self.layerB(inputs)

model = B()

output = model(tf.ones([5, 10]))
print(len(model.losses))

Once we rename self.obj to obj, i.e. not saving it as a class member, we end up with a single regularisation loss.

I believe this should be fixed in TensorFlow. For attributes such as weights or trainable_weights, there is already an explicit deduplication of the return variables (see the related commit https://github.com/tensorflow/tensorflow/commit/596d3ccb0303f54f6184f027840c69e7a6ca2b68). A similar logic should probably be applied for losses.
I would suggest opening an issue on the TensorFlow main repository with the code snippet above.

Closing now that an issue is in TF-Core. Thanks for reporting!


Does it pre-load the next song in the playlist?

Or only buffers the song you're playing?

That is an implementation detail that Google themselves implemented. I'd check with them on their product forums.


[VC] Setting up Hadoop queues during deployment

Note: This PR is for design discussion and validation at the moment.
Design:

Let deploy.py generate capacity-scheduler.xml from a template.
Before creating the configmap, capacity-scheduler.xml will be copied to the folder which will be mounted as the configmap, so that it can be accessed inside the container.
The container of resourcemanager, nodemanager, and jobhistory will copy the capacity-scheduler.xml file from configmap folder to the hadoop configuration folder, and then starts the service.

Pull Request Test Coverage Report for Build 421

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.39%

Totals

Change from base Build 419:
0.0%

Covered Lines:
394

Relevant Lines:
532

💛  - Coveralls

Pull Request Test Coverage Report for Build 421

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.39%

Totals

Change from base Build 419:
0.0%

Covered Lines:
394

Relevant Lines:
532

💛  - Coveralls


PolyLine custom strokeColor

It will be good if we can change the default strokeColor in PolyLine (this can be used for heatMap from lines -to show the vehicle speed between points).
this.state = {
      polyline: [
        {
          latitude: 42.7,
          longitude: 27.6,
        },
        {
          latitude: 42.8,
          longitude: 27.7,
          strokeColor: '#FFF'
        },
        {
          latitude: 42.9,
          longitude: 27.8,
          strokeColor: '#00FF00'
        },
        {
          latitude: 42.7,
          longitude: 27.6,
        },
      ],
}
<MapView.Polyline
            coordinates={this.state.polyline}
            strokeColor="#FF0000" // default color red
            strokeWidth={3}
          />

In this example 4 points with 3 lines the first line will be red (default one). The next one white and the last one green. If strokeColor is defined in coordinates this will (change or override?) default color for the next line.

This can be done on the native side here:
https://github.com/airbnb/react-native-maps/blob/master/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapPolyline.java#L94
to separate Polyline by colors and add it to Map. But the same can be done on the JavaScript side too:
// polyLines = [ color: [{lat, long},{lat,long}...], color: ...];
const heatMap = this.state.polyLines.map((line) => Object.keys(line).map((color) => {
               return (<MapView.Polyline
                   coordinates={line[color]}
                   strokeWidth={3}
                   strokeColor={color}
               />);
           }));
return (<MapView onLayout={this.setPolyLines}>
           {heatMap}
       </MapView>);

and I cannot see drawbacks in JavaScript implementation of this functionality ?
feels free to reopen this if its have


Reproduce results in your paper

Hello! Thanks for your wonderful work.
I have trained your model following the github instructions ./train_pcnet_m_std_no_rgb_gaussian.sh, and tried to calculate the mIOU results on COCOA-test using your code. But I got 88.41 rather than 89.87 as you stated in your paper. Could you please let me know how to get that result? Is it correct for me to use ./train_pcnet_m_std_no_rgb_gaussian.sh which uses the config file of config_train_std_no_rgb_gaussian.yaml?

@Championchess Hello, I am a university student doing research in this field.
The data used for training is randomly generated, so reproducing it will not give the same results.
You should read chapter 3 of this paper or the baseline paper "Self-Supervised Scene De-occlusion".


Add custom scrollbar

I want to add custom scrollbar to the webpage
the current scrollbar looks odd.
i would like to work on this
Thanks

i would also like to add contributors section in your readme


update the name

Ran Plan for dir: 01-intro workspace: default
Show Output

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # aws_instance.instance_test01 will be created
+ resource "aws_instance" "instance_test01" {
      + ami                                  = "ami-08c64544f5cfcddd0"
      + arn                                  = (known after apply)
      + associate_public_ip_address          = (known after apply)
      + availability_zone                    = (known after apply)
      + cpu_core_count                       = (known after apply)
      + cpu_threads_per_core                 = (known after apply)
      + disable_api_stop                     = (known after apply)
      + disable_api_termination              = (known after apply)
      + ebs_optimized                        = (known after apply)
      + get_password_data                    = false
      + host_id                              = (known after apply)
      + host_resource_group_arn              = (known after apply)
      + iam_instance_profile                 = (known after apply)
      + id                                   = (known after apply)
      + instance_initiated_shutdown_behavior = (known after apply)
      + instance_state                       = (known after apply)
      + instance_type                        = "t2.micro"
      + ipv6_address_count                   = (known after apply)
      + ipv6_addresses                       = (known after apply)
      + key_name                             = (known after apply)
      + monitoring                           = (known after apply)
      + outpost_arn                          = (known after apply)
      + password_data                        = (known after apply)
      + placement_group                      = (known after apply)
      + placement_partition_number           = (known after apply)
      + primary_network_interface_id         = (known after apply)
      + private_dns                          = (known after apply)
      + private_ip                           = (known after apply)
      + public_dns                           = (known after apply)
      + public_ip                            = (known after apply)
      + secondary_private_ips                = (known after apply)
      + security_groups                      = (known after apply)
      + source_dest_check                    = true
      + subnet_id                            = (known after apply)
      + tags                                 = {
          + "Name" = "test003"
        }
      + tags_all                             = {
          + "Name" = "test003"
        }
      + tenancy                              = (known after apply)
      + user_data                            = (known after apply)
      + user_data_base64                     = (known after apply)
      + user_data_replace_on_change          = false
      + vpc_security_group_ids               = (known after apply)

      + capacity_reservation_specification {
          + capacity_reservation_preference = (known after apply)

          + capacity_reservation_target {
              + capacity_reservation_id                 = (known after apply)
              + capacity_reservation_resource_group_arn = (known after apply)
            }
        }

      + ebs_block_device {
          + delete_on_termination = (known after apply)
          + device_name           = (known after apply)
          + encrypted             = (known after apply)
          + iops                  = (known after apply)
          + kms_key_id            = (known after apply)
          + snapshot_id           = (known after apply)
          + tags                  = (known after apply)
          + throughput            = (known after apply)
          + volume_id             = (known after apply)
          + volume_size           = (known after apply)
          + volume_type           = (known after apply)
        }

      + enclave_options {
          + enabled = (known after apply)
        }

      + ephemeral_block_device {
          + device_name  = (known after apply)
          + no_device    = (known after apply)
          + virtual_name = (known after apply)
        }

      + maintenance_options {
          + auto_recovery = (known after apply)
        }

      + metadata_options {
          + http_endpoint               = (known after apply)
          + http_put_response_hop_limit = (known after apply)
          + http_tokens                 = (known after apply)
          + instance_metadata_tags      = (known after apply)
        }

      + network_interface {
          + delete_on_termination = (known after apply)
          + device_index          = (known after apply)
          + network_card_index    = (known after apply)
          + network_interface_id  = (known after apply)
        }

      + private_dns_name_options {
          + enable_resource_name_dns_a_record    = (known after apply)
          + enable_resource_name_dns_aaaa_record = (known after apply)
          + hostname_type                        = (known after apply)
        }

      + root_block_device {
          + delete_on_termination = (known after apply)
          + device_name           = (known after apply)
          + encrypted             = (known after apply)
          + iops                  = (known after apply)
          + kms_key_id            = (known after apply)
          + tags                  = (known after apply)
          + throughput            = (known after apply)
          + volume_id             = (known after apply)
          + volume_size           = (known after apply)
          + volume_type           = (known after apply)
        }
    }

  # null_resource.example will be created
+ resource "null_resource" "example" {
      + id = (known after apply)
    }

Plan: 2 to add, 0 to change, 0 to destroy.

:arrow_forward: To apply this plan, comment:

atlantis apply -d 01-intro

:put_litter_in_its_place: To delete this plan click here
:repeat: To plan this project again, comment:

atlantis plan -d 01-intro

Plan: 2 to add, 0 to change, 0 to destroy.

:fast_forward: To apply all unapplied plans from this pull request, comment:

atlantis apply

:put_litter_in_its_place: To delete all plans and locks for the PR, comment:

atlantis unlock

atlantis apply

Ran Apply for dir: 01-intro workspace: default
null_resource.example: Creating...
null_resource.example: Creation complete after 0s [id=801811828872194890]
aws_instance.instance_test01: Creating...
aws_instance.instance_test01: Still creating... [10s elapsed]
aws_instance.instance_test01: Still creating... [20s elapsed]
aws_instance.instance_test01: Creation complete after 27s [id=i-0cb6426e3af5ae01d]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.


bad code on exit-sketch should no delete code

Resolves #2832

Of the two tests that failed in playwright
if your kcl gets an error from the engine it is inlined I ran locally fine, so I think it just needs to be CI hardened
And Position _ Is Out Of Range... regression test has a known issue.
Merging.