RFC: extend CREATE TABLE syntax to support creating append-only table source

RFC: extend CREATE TABLE syntax to support creating append-only table source
To support append-only table source use case and facilitate the e2e test of append-only data stream.
Background
Currently we don't support creating an append-only table source, and to support this use case we need to extend the CREATE TABLE syntax.
Design
The idea is to put the append-only attribute to the storage_parameter part in the WITH clause, which is consistent to CREATE SOURCE syntax.
For example, the SQL to create an append-only table named orders:
CREATE TABLE orders (
        o_orderkey BIGINT,
        o_custkey INTEGER,
        o_orderstatus VARCHAR(1),
        o_totalprice NUMERIC,
        o_orderdate DATE,
        o_orderpriority VARCHAR(15),
        o_clerk VARCHAR(15),
        o_shippriority INTEGER,
        o_comment VARCHAR(79))
        WITH (
         'appendonly'='true'
        )

The append-only attribute will be stored in the corresponding struct in catalog. And the stream plan for MVs created on top of this table should be append-only true.
Future Optimizations
Discussions
Q&A

+1 for this. It's similar to our create source syntax. Besides, Greenplum uses a similar syntax.


argv is at 'this.process.argv' not 'this.argv'

Title says it.
this.argv is undefined for me.
https://github.com/jchip/xclap/blob/master/REFERENCE.md#task-options
We use xclap-cli is that the reason?

Of Course!
Becuse they dont have 'this' and it points to the parent context!

Thanks!


feat: add ef-tests to SSJ

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Resolves: #
What is the new behavior?
This integrates ef-tests to the kakarot ssj CI.
Does this introduce a breaking change?

[ ] Yes
[x] No

This change is

We need to merge #672 before merging this.

I think we should merge #672 and #668 together, not sure why we split?

yeah, makes sense, I splited them, but could have done them together as well!


Integration of ChromDB | Colab notebook demo

Pull Request Template
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Description
Please include a summary of the change and which issue it addresses. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style (BLACK) of this project.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have updated the documentation accordingly.
[ ] I have added an appropriate CHANGELOG entry.

Author's Note
Please provide any additional information, questions, or concerns you have about this pull request.

Hey @aryangoyal7, can you pull and merge main into your branch?


Specify the behavior when ViewManager.getView() is called for unregistered views

Currently in our implementation, if someone called ViewManager.getView() for an unregistered view, an IllegalArgumentException will be thrown: https://github.com/census-instrumentation/opencensus-java/blob/master/core_impl/src/main/java/io/opencensus/implcore/stats/StatsManager.java#L52.
However, this API might be simpler to use if we return null for unregistered views instead. Users could simply check for null instead of trying to deal with unchecked exceptions.
Also, as @sebright pointed out,

Indicating that a view isn't registered would become even more important if we ever added ViewManager.unregisterView.

See more discussion at: https://github.com/census-instrumentation/opencensus-java/pull/713/commits/37ffb47fc4c7cdc0f57d2f71ed6e202218d3abd0#diff-453a0897e016f2c5fe149602aba1e353R198

We will probably need to support unregistering views, so we should return null, or at least throw a checked exception.


What is customer specific end point described in android pubsub sample?

I want to publish a message to an AWS IoT thing from an android app as in the android pubsub example. I didn't understand  CUSTOMER_SPECIFIC_ENDPOINT parameter in PubSubActivity.java. Please explain what value should I use for this parameter?

Hi RnD-Qrio,
The customer endpoint is in your AWS IoT console, You may find it in the "setting" tab, it is in the format of :  *****.iot..amazonaws.com
Thanks.

It is different for each user. So we can't tell what is your's. Login to yours AWS IoT console click on Settings from left bottom. It will show your endpoint.


Design System > Elements > Datepicker > Default/With time/Advanced > Layout > Minor UI issues

Describe the bug
Missing space between two words
First letter of word is not in capital
Steps to reproduce bug
1.Go to 'https://stage-react.raaghu.ai/?path=/story/elements-datepicker--with-time'
2. Navigate to 'Elements > Datepicker > Default/With time/Advanced > Layout '
Actual result-
Missing space between two words
First letter of word is not in capital
Screenshots

Expected result-
add space between two words
"D" should be capital

Fixed on dev

Fixed on stage


Parse erlcloud_elb:describe_loadbalancer output to tuples

Added elastic load balancer parsing to retrieve ELB data.

Won't this break any existing clients that expect the current output?


[CT-2016] [Spike] Static artifact for CLI validation

The ask: A language-agnostic data structure to validate dbt CLI commands, without actually requiring dbt-core to be imported/installed. (Could be a JSONSchema, doesn't have to be.) Let's get away from any need for naïve regex.
For starters, the goal here wouldn't even be to parse CLI strings into meaningful representations — just to say, this is or isn't a valid CLI string. But I'd also imagine wanting to extend this nicer-to-have territory (auto-complete, blocking certain options, extending with additional options).
As I see it, two options:

Abstract the combination of commands + params one step further than we already have, by means of Python methods & decorators, into a static data structure (e.g. JSON). Then, within dbt-core's CLI, consume that data structure to generate the CLI methods/decorators.
Serialize click.cli to a static data structure, which could then be used (itself? by click? by another tool?) just to validate CLI strings.

The closest thing I could find built into click is the to_info_dict method, which is really intended to support auto-generating documentation:
https://click.palletsprojects.com/en/8.1.x/api/#click.Command.to_info_dict
>>> from click import Context
>>> from dbt.cli.main import cli
>>> with Context(cli) as ctx:
>>>   info = ctx.to_info_dict()
>>> info['command']['commands'].keys()
dict_keys(['build', 'clean', 'compile', 'debug', 'deps', 'docs', 'init', 'list', 'ls', 'parse', 'run', 'run-operation', 'seed', 'snapshot', 'source', 'test'])
>>> [param['name'] for param in info['command']['commands']['run']['params']]
['defer', 'favor_state', 'exclude', 'fail_fast', 'full_refresh', 'models', 'profile', 'profiles_dir', 'project_dir', 'select', 'selector', 'state', 'target', 'target_path', 'threads', 'vars', 'version_check', 'help']

FYI to Execution team: I'm going to queue this up for estimation discussion. Not expecting a point estimate (since it's a spike), just expecting that you all know more than I do about this topic & might have some strong opinions!

Here's a Python script that will output an artifact named dbt-core-cli-flags.json:
generate_cli_flags_artifact.py
import json
from click import Context
from dbt.cli.main import cli

def convert_to_serializable(obj):
    # Convert non-serializable objects to strings
    return str(obj)

def serialize_dict_to_json(input_dict):
    # Use a custom conversion function when serializing
    return json.dumps(input_dict, indent=4, default=convert_to_serializable)

with Context(cli) as ctx:
    info = ctx.to_info_dict()

    pretty_json_string = serialize_dict_to_json(info)

    # Write the JSON string to a file
    with open("dbt-core-cli-flags.json", "w") as file:
        file.write(pretty_json_string)

Usage
python generate_cli_flags_artifact.py

Note: the dictionary can contain content that isn't serializable to JSON (like tuples, functions, etc), so this script just converts those to a string.

Here's a section of the documentation that outlines which sub-commands are available in dbt Core, dbt Cloud CLI, and dbt Cloud IDE:


Missing CS Profile-URI's in ServerProfileArray

@GoetzGoerisch @DrHaraldWeber @xenonforlife
We need to add the CS Profile URI's for the CS-Model-Instance's to the configuration.json
e.g.
https://reference.opcfoundation.org/v104/MachineTool/v100/docs/14.2.1/

so just post the URI's here and a make a PR to add them!

ping @GoetzGoerisch


singularity version issue

I am trying to use singularity with snakemake with version 7.30 and I am seeing the following error:
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/snakemake/__init__.py", line 771, in snakemake
    success = workflow.execute(
              ^^^^^^^^^^^^^^^^^
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/snakemake/workflow.py", line 919, in execute
    dag.pull_container_imgs(
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/snakemake/dag.py", line 367, in pull_container_imgs
    img.pull(dryrun)
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/snakemake/deployment/singularity.py", line 46, in pull
    self.singularity.check()
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/snakemake/deployment/singularity.py", line 173, in check
    if parse(v) < parse("1.0.0"):
       ^^^^^^^^
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/packaging/version.py", line 52, in parse
    return Version(version)
           ^^^^^^^^^^^^^^^^
  File "/panfs/jay/groups/27/mccuem/perso208/mambaforge/envs/snakemake/lib/python3.11/site-packages/packaging/version.py", line 198, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: '1.1.8-1.el7
'```

Fixed in #2337


use only base rules of airbnb(exclude react rules)

As eslint-config-airbnb/base is deprecated in favour of eslint-config-airbnb-base, eslint-config-airbnb has to be removed and eslint-config-airbnb-base should be added from the dev-dependencies list

The airbnb rules keep on messing with typescript rules.
As an alternative to eslint-config-airbnb-base, I am going with eslint-config-airbnb-typescript as it exposes a javascript base config(from eslint-config-airbnb-base) and also exposes overridden typescript rules

I am not happy with using separate packages for javascript(eslint-config-airbnb-base) & typescript(eslint-config-airbnb-typescript)
It might be better to publish a new package say eslint-config-airbnb-pluggable that exposes

base.js (exposes rules of eslint-config-airbnb-base)

typescript.js (exposes eslint-config-airbnb-typescript/lib/shared.js)
so that

Base configuration can extend from eslint-config-airbnb-pluggable/base and

Typescript configuration can extend from Base and eslint-config-airbnb-pluggable/typescript

Released in v2.3.3


VerifyXml method does not work correctly with empty tags

Method VerifyXml expects opening and closing tags instead of empty tag.
Test to reproduce:
[Fact]
public Task EmptyTag() => VerifyXml("<body><empty /><node>text</node></body>");

This test fails with error, received file contains this xml:
<body>
  <empty></empty>
  <node>text</node>
</body>

Obviously, this is not correct xml, the empty tag should be a single tag.
The bug has been reproduced since version 19.8.2, in older versions everything works correctly.

do you want to have a go at fixing this?

I'll try it this weekend, but I'm not quite sure of my skills.


settings: Improve permissions banners on Invitations panel.

Fixes: #24158
This PR fixes both the part of #24158. I have created a new function update_invite_users_setting_tip in invite.js for handling the permissions banner.

Screenshots and screen captures:
Screenshot for a non-admin user who can invite users.

Screenshot for a non-admin user who cannot invite users.

Screenshot for a admin for each possible permission configurations.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya please review this PR. Thanks !

Thanks!
The banner doesn't quite look right: we need a space after the comma, the roles all need to be plural, and we'd like to have an "and" instead of a comma before the last role.

Once you've updated the PR, please post the variants of the new banner that will be shown for each possible permissions configuration.

@alya I have updated the PR and screenshots. Please have a look.

Thanks, those screenshots look good to me!
@sahil839 could you please review this one? I have not tested the PR.

@sahil839 I have done the changes. Please have a look.

LGTM. @alya do we want the text to be like ... only admins can .. and ... only admins and moderators can .... or is it fine as it is now?

I thought for simplicity we could leave off the "only", since I think it sounds awkward when pretty much everyone (or everyone other than guests) can do it, and it avoids having to figure out special cases. @timabbott for your thoughts.
Also, this PR has been reviewed by @sahil839 and me (just the screenshots), and is ready for you to take a look.

Merged, thanks @Ujjawal3!
That said I think in a few months we'll want to replace this with a groups-based setting with language that feels good regardless of whether the group is large.


Use shared actions

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.49%. Comparing base (49870ee) to head (e9321f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   70.49%   70.49%
=======================================
  Files           9        9
  Lines         244      244
=======================================
  Hits          172      172
  Misses         62       62
  Partials       10       10

Flag
Coverage Δ

Linux
?

macOS
70.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix password protect downloads and copying ComicInfo files in LocalSource

fixes #1076
Trying to access the image files directly causes access denied errors, switching to streams fixes this.

I also fixed copying ComicInfo files into encrypted archives. This is still broken for unencrypted ComicInfo files but I will check if this is also broken upstream and fix it in Mihon first if it is.

It has already been fixed upstream. I applied the fix here because it was only a few lines of code.

I think we should keep the tempFileManager for TachiyomiSY, since zip4j does not support channels. We could still use channels for normal unencrypted zip files if we only switch to using zip4j if opening the file throws an error.

I implemented it using streams but reading them is pretty slow. This is probably worth the load time in LocalSource were the cacheDir could get spammed with temp files. But this will not work for The ZipPageLoader, my test implementation had a loading time of 10 seconds per page. If anyone has any ideas how to load them faster please let me know.

I did some more tests and i don't think using ZipInputStreams will be feasible for the ZipPageLoader. Every time a page is loaded all pages that came before must be read again (and i think decrypted). that alone adds an overhead of 0.5-1s per page that has come before. I'll implement a 2 way solution were we use the TempFileManger for encrypted zip files and channels for unencrypted files. This should be pretty easy to implement since we are already using a 2 way solution with zip4j for encrypted and Tachiyomis Java zip implementation for unencrypted files.
I think this PR can be merged for now.


AttributeError: module 'jinja2.utils' has no attribute 'escape'

This is an issue with nbconvert
https://github.com/jupyter/nbconvert/issues/1736

@aidan-gibson here's my workaround:

Installed recommended package versions:

jupyter==1.0.0
jupyter-client==7.0.2
jupyter-console==6.4.0
jupyter-core==4.7.1
jupyterlab-pygments==0.1.2
jupyterlab-widgets==1.0.1
nbclient==0.5.4
nbconvert==6.1.0
nbformat==5.1.3
notebook=6.4.3

Activated virtual environment into which I installed them.
pip uninstall jinja2
pip install jinja2==3.0.3

Works now.

Thank you!

I'll just leave this open for now until nbconvert fixes the issue, so others can see.


⚠ Bofrost.fr has degraded performance

In a6c2623, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 901 ms

Resolved: Bofrost.fr performance has improved in a3f8b1b after 6 minutes.


Fixes and Extensions to Aic-Emu CmdLine options

Related Issue: VSMGWL-60237

Fix issue in passing device option to Gfx class
Remove unnecessary restrictions on socket path
Add following cmd line options to Aic-Emu: --manage-fps to control test fps settings, --instance to control session ID

imho, you should have broken that into 3 commits each dedicated to the feature/fix you introduce. Same PR would be fine, but 3 commits.

Restructured the commits.


Fix targetFramework so that te latest runtime is chosen

Related to https://github.com/microsoft/vscode-azurestaticwebapps/issues/899
Currently the runtime is chosen using .find so the first match will be chosen. Within SWA the targetFramework is set to  ['net8.0', 'net7.0', 'net6.0'] so net6.0 will match first since latest versions are at the bottom of the list. It seems like we would rather have .net 8.0 match first so we are using the latest runtime.

I'm a little perplexed why it would have that behavior. Shouldn't it being an exact match on the .NET framework? So looking for .NET 8.0, and .NET 6.0 shouldn't match?

I think we should probably either a.) prompt the user if there are multiple matches or b.) add a property to the elements that indicates which is default

I think originally the SWA team wanted to prompt so I could see "a" being the best option. And I do think the list is always returned the same way but either way makes more sense to me to prompt than to automatically choose.

Uh make sure these tests are passing in the Actions before merging. Also is the plan that this should not change any existing Functions UX right? We might want to inform CTI of this change and have them watch out for it.

Make sure these tests are passing in the Actions before merging. Also is the plan that this should not change any existing Functions UX right? We might want to inform CTI of this change and have them watch out for it.

I am investigating right now since one of the tests I added is failing. And you are correct this should only change when a targetFramework exists which at the moment should only be in SWA. I will inform CTI of the change.


Installing bcbio on Amazon Cloud with starcluster

Hi,
I am trying to install bcbio on Amazon cloud with starcluster. At first, I created a cluster with starcluster and then I log into the head node to install the isolated version. I found the bcbio installation will temporally download all third party packages to the root volume even thought I specified the path to bcbio to an attached big volume. Unfortunately, the root volume on the head node is only 8GB. When bcbio installation was downloaded GRCh37-bwa.tar.xz, it was failed due to no space.
Is there anyway to install bcbio on the SGE cluster by starcluster? Or is there anyway to run bcbio on a cluster on amazon cloud? Thanks!

Thanks @michaelxu2014, hope you eventually got it up and going.


a request in Video Object Tracking

is there any way to add a choice inside one video tracking? like, in one video tracking, 0-3s one object is sitting, 3-5s he is standing, with NO change to tracking ID. Can i add classification to this?
in other words, can i change label value in one tracking ID?

/jira create

This feature is on our roadmap and will be released soon ;-)


Copy over new version of Milo's geo-based locales

Adopt milo fix for incorrect lang attributes on html tag
Add new reg property for future use

See https://github.com/adobecom/milo/pull/915 and https://github.com/adobecom/milo/pull/938
Test URLs:

Before: https://main--bacom--adobecom.hlx.page/customer-success-stories?martech=off
Before: https://main--bacom--adobecom.hlx.page/la/customer-success-stories?martech=off
After: https://hparra-patch-2--bacom--adobecom.hlx.page/customer-success-stories?martech=off
After: https://hparra-patch-2--bacom--adobecom.hlx.page/la/customer-success-stories?martech=off

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@dd33b71). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage        ?   96.36%
=======================================
  Files           ?        6
  Lines           ?      468
  Branches        ?        0
=======================================
  Hits            ?      451
  Misses          ?       17
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hparra There's no ui or functionality to verify here, right? It's just adding the new lang and reg properties and alphabetizing?

@meganthecoder There is new functionality in Milo that is enabled when these values exist. You can confirm in test urls that HTML lang attribute now only uses language subtag instead of full tag, e.g <html lang="en"> vs. <html lang="en-US">. See https://github.com/adobecom/milo/pull/915 and linked issue for more details. Milo features use getConfig().locale and do not read locale from this attribute.

@hparra Cool, I updated the description to reflect that and assigned myself to verify. Is the reg tag being used yet? I didn't see anything in the PRs you mentioned.

Is the reg tag being used yet?

Not yet. A couple of new features use it and I will begin porting existing features to use it one by one -- those changes will be in Milo only but it will affect all Milo consumers. There will be additional comms of those.

There are a few locales added that we don't support in bacom

This should be OK. locales is just a source of truth for mappings. locales should NOT be used to enable or disable a particular locale. I can remove but it makes syncing more difficult.

Also, when I was testing, I saw that CaaS cards weren't loading for la

This is probably not OK and is the sort of thing I was afraid of. Can we sync on this so I can understand what is happening?

Waiting for https://github.com/adobecom/milo/pull/945

@hparra @meganthecoder looks like la cards are loading again on this one, some links:
https://hparra-patch-2--bacom--adobecom.hlx.page/la/customer-success-stories?martech=off
https://hparra-patch-2--bacom--adobecom.hlx.page/la/resources/main

I believe a different solution was determined here: https://github.com/adobecom/milo/pull/963
@hparra Can this PR be closed?

@meganthecoder I was waiting until handoff to close all PRs but I think we're ok.


🐛 Refresh external managed token secret if service account is deleted

Summary
Compare the uid of the service account to check if the service account is recreated.
Related issue(s)
similar PR: https://github.com/open-cluster-management-io/ocm/pull/458
Fixes #https://github.com/open-cluster-management-io/ocm/issues/503

/assign @elgnay
/cc @qiujian16

lgtm

/approve
/lgtm


Unexpected keyword "workers" (scipy)

I installed the SimpleICP package with pip (python), and tested the code presented in the documentation. And now I had this problem. Can you help me please ?

You're probably using an old scipy version. Previous to version 1.6 the parameter "workers" was called "n_jobs", see here:

Can you check your scipy version with pip show scipy?

It worked. Thank you so much.
The error no longer appeared.

Great!
.


catch KeyboardInterrupt

Hello,
Somewhere there needs to be a place that triggers an event for KeyboardInterrupt. This can be done by using a try statement:
try:
yield event
except KeyboardInterrupt:
yield KeyboardInterruptEvent
This will help in:
https://github.com/zeth/inputs/issues/23#issuecomment-443534823
It is also useful to allow users to block KeyboardInterrupt if they really want (although it should not be default).

I did some playing around and think I know what needs to be done, I just don't understand the structure of the code well enough to do a PR. KeyboardInterrupt happens in both the main thread and the Process.
For the process it is:
def handle_input(self, ncode, wparam, lparam)

Something needs to go in this function catching the KeyboardInterrupt event, similar to what happens in the main thread. In the main thread, the following works pretty well, although I would like to return an KeyboardInterruptEvent object:
def get_key(ignoreKeyboardInterrupt=False):
    """Get a single keypress from a keyboard."""
    try:
        keyboard = devices.keyboards[0]
    except IndexError:
        raise UnpluggedError("No keyboard found.")
    try:
        return keyboard.read()
    except KeyboardInterrupt:
        if not ignoreKeyboardInterrupt:
            raise KeyboardInterrupt
        else:
            return KeyboardInterruptEvent


maintenance

Good day to you, Luke,
I have a question,

Will you be maintaining this module?

Thanks for reading and your time.
@Dr-Insanity

Hi, if I have any ideas or problems, I will develop/fix them


Remote Address Might Not Always Available

So looking more carefully at how hyper does its thing it looks like the remote address (from the transport) might not always be available.
In the case of a GET request there likely won't be a body and it looks like https://github.com/hyperium/hyper/blob/master/src/server/mod.rs#L329
won't be called then.
If thats the case then the remote address is never available for certain request types which would seem to be a bug.

I've also simply felt that it'd be better to have access to the Transport in the on_request event. So to do this, I've been thinking of adding a &'a T field to the Request struct.
fn on_request<'a>(&mut self, req: Request<'a>) -> Next {
    let addr = req.transport().peer_addr().unwrap();
}

I wonder if lifetime elision can remove the need for those 'as...
@Ogeon @Ryman would this hurt ergonomics for frameworks much that you could no longer hold on to the Request object? You could still get the underlying fields with req.deconstruct()...

I don't think it will be a problem. I'm consuming the request in on_request, so it won't leave the scope. I'm quite sure the 'as will be elided, as well. It's the same for the Handler trait in Rustful.

I haven't spent enough time with the new api to know if it'll be a problem, but I imagine if deconstruct is available it'll probably be fine :)


Support XDG spec for providers cache dir

What does this do / why do we need it?
Allow to place providers cache by XDG spec, like ${XDG_CACHE_HOME}/m1-terraform-provider-helper/ with fallback to current default ${HOME}/.m1-terraform-provider-helper/
How this PR fixes the problem?
On app configuration init, searching for existing directory via xdg.SearchCacheFile and if ${XDG_CACHE_HOME}/m1-terraform-provider-helper/ not found, fallback to ${HOME}/.m1-terraform-provider-helper/
What should your reviewer look out for in this PR?
Terraform itself still doesn't support XDG spec, so xdg.SearchDataFile("terraform") probably will always return error, but this allows to use custom terraform build or tofu.
Check lists

[x] Test passed
[x] Coding style (indentation, etc)

Additional Comments (if any)
{Please write here}
Which issue(s) does this PR fix?

Can anyone review this, please?


Add configuration ability

This allows to set basic auth username + password and base_url in the configuration.
We've been using it in prod for about a week, all fine

Do you want me to squash the commits?

Na, no need for that.

Thanks, Zack


Added compat for Vanilla Nutrient Paste Expanded

Can't find it in their github either

I still had the link in my browser, but it's leading to page not fount: https://github.com/AndroidQuazar/VanillaNutrientPasteExpanded


Write the Thoughts section of the documentation

Write the initial version of the Thoughts section in the documentation

This is a test to see if I get an email for a mention in an issue.


Fix eslint rule violations

Codecov Report

Merging #889 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%
==========================================
  Files          36       36
  Lines        3240     3410     +170
  Branches      274      493     +219
==========================================
+ Hits         3167     3333     +166
+ Misses         73       66       -7
- Partials        0       11      +11

Impacted Files
Coverage Δ

browser/pages/confirm/controller.js
94.92% <100%> (-1.5%)
:arrow_down:

browser/main.js
98.41% <66.66%> (-1.59%)
:arrow_down:

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/model/devstudio.js
96.8% <0%> (-0.97%)
:arrow_down:

browser/model/cdk.js
99.21% <0%> (-0.79%)
:arrow_down:

browser/model/jdk-install.js
96.61% <0%> (-0.42%)
:arrow_down:

browser/model/hyperv.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/util.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/version.js
100% <0%> (ø)
:arrow_up:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4934184...80f4676. Read the comment docs.


prefetch container optimization

To reduce cold start overhead -- if we have a good reason to believe that an action will be invoked soon -- then send a message to /init a container.    I think this could be done by adding "init" messages to the kafka protocol.    When receiving an "init" message, the invoker would /init a container if none is present already.
The obvious use case is sequences -- when a sequence is run,  "init" all the actions in the sequence immediately.

Hi sjfink,
i'd be glad to contribute to the openwhisk project and this issue seems a good starting point.
what do you think about?


Area default is not included in the deployment , but the interface always displays default

Describe the Bug
Area default is not included in the deployment, but the interface always displays default
so that the node cannot be seen

@moweiwei
/area console

/milestone v1.2.0


docs(ngReadonly): added note about input type checkbox and radio

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Current docs does not mention, that ngReadonly does work with input type checkbox|radio.
What is the new behavior (if this is a feature change)?
Added note to docs string.
Does this PR introduce a breaking change?
No, text change in comment only.
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

I signed it!

This doesn't only apply to checkbox and radio - see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-readonly
I'd would rather add a link to this section in the docs, so that we don't have to keep that up to date.

@Narretz Ok, agreed, thanks for processing through.


autodeploy of nuvolaris

at the moment in devcontainer.json, we execute init.sh that creates kind but does NOT install nuvolaris yet.
Becsause the devcontainers.json is also useful for codespaces, we want to change it to deploy also current version of nuvolaris.
The idea is to add to the kind configuration for Kubenelet Configuration the creation of a static pod for the operator.
With this configuration the operator will start but will not deploy nuvolaris because it needs a crd. But we can pass an environment variable to the operator, like NUVOLARIS_AUTO_DEPLOY
We should then change operator startup script that if the envirorment variable NUVOLARIS_AUTO_DEPLOY is set it will deploy the configuration crd instance for kind.
We may also need to add the crd instance to the operator image to be able to use it.

giving up - not pratical


Tunnels not working in the Ponder.

Describe the Bug
The Ponder page of Brass Tunnel and Andesite Tunnel's example are not working.
Reproduction Steps

Ponder

Expected Result
The demo should work.
Screenshots and Videos
https://user-images.githubusercontent.com/21377465/202910963-72c24e10-32ec-4d99-ba4d-6293f43c2144.mp4
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.0f
Minecraft Version
1.19.2
Other Mods
Mods:
  [✔] 3dskinlayers-fabric-1.5.2-mc1.19.1
  [✔] Adorn-3.7.0+1.19.2-fabric
  [✔] antighost-1.19.1-fabric0.58.5-1.1.5
  [✔] appleskin-fabric-mc1.19-2.4.1
  [✔] appliedenergistics2-fabric-12.8.4
  [✔] architectury-6.3.49-fabric
  [✔] authme-mc1.19.2-4.2.0
  [✔] badpackets-fabric-0.2.1
  [✔] bclib-2.1.3
  [✔] better-end-2.1.1
  [✔] better-nether-7.1.2
  [✔] BetterF3-4.0.0-Fabric-1.19.2
  [✔] BetterPingDisplay-Fabric-1.19.2-1.1.1
  [✔] cc-restitched-1.101.2
  [✔] cloth-config-8.2.88-fabric
  [✔] create-fabric-1.19.2-0.5.0f-776
  [✔] cullleaves-fabric-3.0.0
  [✔] dashloader-4.1.3+1.19
  [✔] DistantHorizons-1.6.9a-1.19.2
  [✔] dynamic-fps-2.2.0
  [✔] enhancedblockentities-0.7.2+1.19.2
  [✔] entityculling-fabric-1.5.2-mc1.19
  [✔] expandeddelight-0.2.5
  [✔] fabric-api-0.66.0+1.19.2
  [✔] fabric-language-kotlin-1.8.6+kotlin.1.7.21
  [✔] fabrishot-1.9.1
  [✔] farmers-delight-fabric-1.19.X-1.3.5
  [✔] ferritecore-5.0.0-fabric
  [✔] gravestones-v1.13
  [✔] indium-1.0.9+mc1.19.2
  [✘] InventoryProfilesNext-fabric-1.19-1.8.5.jar (disabled)
  [✔] iris-mc1.19.2-1.4.2
  [✔] jmi-fabric-1.19.2-0.13-30
  [✔] journeymap-1.19.2-5.9.0beta3-fabric
  [✔] krypton-0.2.1
  [✔] lazydfu-0.1.3
  [✔] libIPN-fabric-1.19-1.0.6
  [✔] lithium-fabric-mc1.19.2-0.10.2
  [✔] mcwifipnp-1.5.6-1.19.1-fabric
  [✔] memoryleakfix-1.19.1-0.7.0
  [✔] midnightcontrols-1.7.1+1.19
  [✔] modmenu-4.1.1
  [✔] notenoughanimations-fabric-1.6.2-mc1.19.2
  [✔] Oh_The_Biomes_You'll_Go-fabric-1.19.2-<IP_ADDRESS>
  [✔] owo-lib-0.8.5+1.19
  [✔] Patchouli-1.19.2-77-FABRIC
  [✔] PetOwner-1.8.3-1.19+
  [✔] reeses_sodium_options-1.4.7+mc1.19.2-build.59
  [✔] RoughlyEnoughItems-9.1.572
  [✔] sodium-extra-0.4.13+mc1.19.2-build.76
  [✔] sodium-fabric-mc1.19.2-0.4.4+build.18
  [✔] spark-1.9.45-fabric
  [✔] starlight-1.1.1+fabric.ae22326
  [✔] TerraBlender-fabric-1.19.2-<IP_ADDRESS>
  [✔] voicechat-fabric-1.19.2-2.3.15
  [✔] wraith-waystones-3.0.5+mc1.19.2
  [✔] wthit-fabric-5.13.4
  [✔] YetAnotherConfigLib-1.7.1
  [✔] Zoomify-2.8.0
Additional Context
No response

ah ok this is a bug was very confused XD


Separate auto typename handling flag for objects and arrays

We often get into issue when we want to use Auto value for TypeNameHandling. If some property has IEnumerable<> type then we don't get array in JSON but object with 'values' property. This is by design, but what we really need is: $type shall appear only on objects, any collection always appear as JSON array when serialized.
I see it is possible to solve issue by extending type name handling. If Auto flag would be possible to split to AutoArray and AutoObject then we would be able to disable adding type names to arrays but still keep $type in our objects.
Is it possible to add such change? Would you accept pull request with such change?

I don't want to do this. If you want to apply it selectively then you can set it on attributes against properties and types.

Is there an example on how to do it?
Or some declarative way to add to some types?
For example, my classes I would like to be auto, but the API errors I woudn't.
Can I register some dictionary of tyes and serializeSettings?

@dainius-bekeris  take a look at my question on stack overflow
https://stackoverflow.com/questions/69486089/override-newtonsoft-json-serialization-in-asp-net-core-to-make-the-typenamehandl


bacalhau get

Currently you need to have an ipfs binary installed to be able to view the results of your jobs - it would be nice if the bacalhau binary did this for us to avoid the UX problem of failed ipfs installations
This also means you can use a bacalhau job id as the input to the get command
bacalhau get <jobid> --target /tmp/results

This should be possible by vendoring some parts of the go-ipfs codebase into bacalhau

That would be super nice, I guess using a public gateway for now?


Response not being handled

Only response 410 is being handled by apns.
We need to handle all the errors appropriately.
Ideally return the error status-code & reason to the owner scheduling.
https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CommunicatingwithAPNs.html#//apple_ref/doc/uid/TP40008194-CH11-SW1

Table 8-4Status codes for an APNs response

  Status code

  Description

  200

  Success

  400

  Bad request

  403

  There was an error with the certificate or with the provider authentication token

  405

  The request used a bad :method value. Only POST requests are supported.

  410

  The device token is no longer active for the topic.

  413

  The notification payload was too large.

  429

  The server received too many requests for the same device token.

  500

  Internal server error

  503

  The server is shutting down and unavailable.

At the very least log out to rails logger with the response if not 200
https://github.com/Papercloud/notify_user/blob/feature/apns-http2/app/models/notify_user/apns.rb#L38


multiple ng-model-options are not merged when inherited

Since #7212,  the example in the documentation indicates that multiple ngModelOptions are merged:
<div ng-model-options="{ allowInvalid: true }">
  <form ng-model-options="{ updateOn: 'blur' }">
    <input ng-model-options="{ updateOn: 'default' }" />
  </form>
</div>

According to the doc, this should yield for the input element:
{ allowInvalid: true, updateOn: 'default' }
But this is not working: options set on children elements will simply override the options from the parent (without merging).
So the input element in the previous exemple has the following options:
{ updateOn: 'default' }
See plunker (I had to inspect the input's ngModel controller to have a look at its $options to be sure)
The documentation (not the example) does not say anything about merging multiple options:

If a setting is not specified as a property on the object for a particular ngModelOptions directive then it will inherit that setting from the first ngModelOptions directive found by traversing up the DOM tree. If there is no ancestor element containing an ngModelOptions directive then the settings in $modelOptions will be used.

So I think the behavior is the expected one, but the example is wrong so this should be a simple doc fix. Is that correct?

You are apparently using Angular v1.5.8, but the docs you mention are from the latest code on the master branch. The v1.5.8 docs can be found here and they should be consistent with the behavior in the example.
Note, that there has been a change wrt ngModelOptions. In v1.5.x, an element would inherit its ancestor's ngModelOptions only if it didn't have its own ngModeOptions. Since v1.6.x (yet to be released), the inheritance is more granular, so even if an element has its own ngModelOptions, it will still inherit specific properties that it doesn't have.
(The related PR is #10922.)
(Since this is a breaking change, it will not be backported to v1.5.x, so v1.5.x will keep the current "inherit-all-or-nothing" behavior.)

My bad, I thought the current docs still applied to 1.5.8 (since latest is still 1.5.9.x) and forgot to check.
Thanks for the clarification!


UI fixes and PROBLEMS view

remove hover from the information icon

remove default values from duration / loop_iter

add an option to choose branch in production: customize branch, staging


In auto evolve, if not enough candy, should be faster

Expected Behavior
This should be a very fast check too see if there are enough candies. Or maybe i am wrong?
In the log, it took 5 seconds.
Actual Behavior
[17:29:13] Captured Pidgey! [CP 391] [Potential 0.38] [0/7/10] [+210 exp]
[17:29:13] You now have 8 Pidgey candy!
[17:29:14] Failed to evolve Pidgey!
[17:29:19] Spun pokestop Gilda's Club. Experience awarded: 50. Items awarded: {u'Pokeball': 4}
[17:29:21] Moving towards pokestop Guardian  - 0.08km
Your config.json (remove your credentials and any other private info)
	"evolve_captured":			"Caterpie, Pidgey, Weedle, Rattata",

The mods have been discussing about this. They might plan to remove the unnecessary pauses. Stay tuned!

I do not recommend this evolve_captured.
This parametre send request to pgo's API for evolve without look number of candy.
Is Not like officiel's app and Is not comportement human like.
It's easy for Niantic to landmark use of bot with this and banned.... =S
Please, Juste Use a Task "EvolvePokemon", this count candy before request API.

Thank you @Happyrain67 @giomasce  for the input. Now I know about the causes, I'll close this.


runtime: intermittent os/exec.Command.Start() Hang on Darwin in Presence of "plugin" Package

What version of Go are you using (go version)?

$ go version
go version go1.14.2 darwin/amd64
$

Does this issue reproduce with the latest release?
Yes. Also with go version devel +be08e10b3b Fri May 1 21:57:29 2020 +0000 darwin/amd6.
It does not reproduce with Go 1.13.10.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/Users/craig/go/bin"
GOCACHE="/Users/craig/Library/Caches/go-build"
GOENV="/Users/craig/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/craig/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/craig/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/craig/github/golang/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/craig/github/golang/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
GOAMD64="alignedjumps"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/m_/0sxkm11s5wd625ypnp0g0ffm0000gn/T/go-build624939018=/tmp/go-build -gno-record-gcc-switches -fno-common"
$

Note that, in a different shell, GOROOT=/usr/local/go, corresponding to Go 1.14.2, where the same problem occurs (though, anecdotally, less frequently) compared to the recent commit, identified above, on master.
What did you do?
Built a simple Go program, ran it repeatedly via:
$ while true; do ./hangme 100; date; done

What did you expect to see?
Repeated runs ad infinitum, no hang.
What did you see instead?
Occasionally (intermittently), the program hangs. SIGQUIT stack dump shows it usually hangs in the Command.Start() receiver in os/exec, which is not supposed to hang at all. (I've seen somewhat-different stack traces across different programs and built with different versions of Golang, but they all hang at that call or soon after.)
Such hangs have been observed (by me) only in programs that import plugin (even though they don't use it at all; only its initialization code should run). Comment-out the _ "plugin" import line in the above program, rebuild (via go build), and rerun the ever-looping command, and it runs until manually stopped.

Background: I maintain a fork/branch of Joker (a Clojure interpreter/clone written in Go) that "autowraps" much of the Go standard library for easy access by Joker code.
A couple of weeks ago, I first noticed that the (small) test suite occasionally hung. Digging further, I posted this to get some feedback:
https://stackoverflow.com/questions/61342000/why-might-exec-command-start-hang-on-darwin
As suggested there, I ran git bisect run on the Go source code to find "the" commit that introduced or triggered the problem. The culprit simply turned on "new" timer code (turning off old code), which was quite suggestive.
Later, I boiled the pertinent Joker code down to a small test program and was able to reproduce that. The first such version pulled in all the Go standard library that my fork of Joker did. I then performed manual bisections of that set and narrowed them down to just the plugin package: when included (despite not being referenced), the sample program would occasionally hang; without it, it wouldn't.
This issue is being tracked (on my end) via https://github.com/jcburley/joker/issues/19. It's Closed due to a workaround being implemented such that plugin isn't included in the list of imported (and wrapped) packages when Joker is built for OS X (Darwin).
A slightly "fuller" version of the sample program, along with instructions on another approach to run it, is here:
https://github.com/jcburley/hangme/blob/master/README.md

cc @odeke-em re MacOS

Hi, the same thing in golangci-lint: can reproduce only on Mac OS (Linux and Windows are ok), only on go1.14 (1.13 works ok). Also, reproduces not every time: I ran in loop to reproduce.
When reproduced I see in ps two identical processes win my binary, one is the child of another.
And I also import plugin and can't reproduce the problem when comment out this importing.
backtrace from dlv

(dlv) bt
 0  0x00007fff6bcef062 in ???
    at ?:-1
 1  0x00007fff6bdab937 in ???
    at ?:-1
 2  0x00007fff6bbaa786 in ???
    at ?:-1
 3  0x000000000b163395 in ???
    at ?:-1
 4  0x000000000b143acb in ???
    at ?:-1
 5  0x00007fff6bbaa692 in ???
    at ?:-1
 6  0x00000000053c4000 in ???
    at ?:-1
 7  0x0000000004067da0 in runtime.asmcgocall
    at /usr/local/go/src/runtime/asm_amd64.s:655
 8  0x0000000000000000 in ???
    at ?:-1
 9  0x0000000004055a8c in syscall.rawSyscall
    at /usr/local/go/src/runtime/sys_darwin.go:107
10  0x00000000040b1d1f in syscall.forkAndExecInChild
    at /usr/local/go/src/syscall/exec_darwin.go:157
11  0x00000000040b284b in syscall.forkExec
    at /usr/local/go/src/syscall/exec_unix.go:201
12  0x00000000040d5ef0 in syscall.StartProcess
    at /usr/local/go/src/syscall/exec_unix.go:248
13  0x00000000040d5ef0 in os.startProcess
    at /usr/local/go/src/os/exec_posix.go:53
14  0x00000000040d591c in os.StartProcess
    at /usr/local/go/src/os/exec.go:102
15  0x000000000429b5f6 in os/exec.(*Cmd).Start
    at /usr/local/go/src/os/exec/exec.go:422
16  0x0000000004512610 in golang.org/x/tools/internal/gocommand.runCmdContext
    at /Users/denis/go/pkg/mod/golang.org/x/tools@v0.0.0-20200502202811-ed308ab3e770/internal/gocommand/invoke.go:153
17  0x0000000004511d29 in golang.org/x/tools/internal/gocommand.(*Invocation).RunPiped
    at /Users/denis/go/pkg/mod/golang.org/x/tools@v0.0.0-20200502202811-ed308ab3e770/internal/gocommand/invoke.go:147
18  0x000000000451178e in golang.org/x/tools/internal/gocommand.(*Invocation).runRaw

I took a quick look at this today and can at the very least confirm that the bug still exists with 1.14.3:

(Here's my very slightly modified code, where all I did was add some more STDOUT output to figure out what's going on.)
As we can see here, I ran it the same way as James and indeed it locked after only 3 attempts. At the point this screenshot was taken, the same program had been hanging for 7 minutes, 35 seconds.
So I looked at Activity Monitor.app to see if I can get some more information:

Here's the text of that stack trace if you can't view the image for some reason:
[...snip...]
Call graph:
    973 Thread_4709590   DispatchQueue_1: com.apple.main-thread  (serial)
      973 runtime.asmcgocall  (in hangme) + 112  [0x405f8c0]
        973 ???  (in hangme)  load address 0x4000000 + 0x1de000  [0x41de000]
          973 dyld_stub_binder  (in libdyld.dylib) + 282  [0x7fff6e279692]
            973 dyld::fastBindLazySymbol(ImageLoader**, unsigned long)  (in dyld) + 86  [0x10656acb]
              973 ImageLoaderMachOCompressed::doBindFastLazySymbol(unsigned int, ImageLoader::LinkContext const&, void (*)(), void (*)())  (in dyld) + 53  [0x10676395]
                973 dyldGlobalLockAcquire()  (in libdyld.dylib) + 16  [0x7fff6e279786]
                  973 _pthread_mutex_firstfit_lock_slow  (in libsystem_pthread.dylib) + 222  [0x7fff6e47a937]
                    973 _pthread_mutex_firstfit_lock_wait  (in libsystem_pthread.dylib) + 83  [0x7fff6e47c917]
                      973 __psynch_mutexwait  (in libsystem_kernel.dylib) + 10  [0x7fff6e3be062]
[...snip...]

 Stuck in a mutex wait in the kernel? I went for a dtruss (like strace but for BSD/MacOS) on the pid for that process:
$ sudo dtruss -p 46759
Password:
dtrace: system integrity protection is on, some features will not be available

SYSCALL(args) 		 = return

It's just flat hung on the last line, no progress beyond that point at all.
My theory at this point is that the process isn't returning because one of the executions of ./hangme 0 is being held up by the kernel, which is waiting on a mutex to be released on some resource. This, to me, smells of a bug in MacOS, not necessarily in Go. I'm not sure why it worked with previous versions and not this version, but clearly something that plugin is doing is causing a hang at the kernel level (or at least appears to be) by having some resource tied up.
This is about the depth of my ability to debug at this point (I'm always learning, in fact that's why I'm looking at this issue!). I don't know how much help it'll be, but I certainly hope this aids in tracking things down.

Hi, I'm so glad to find a fellow sufferer from this :)
From that stack trace, and stack traces of my own issues, it looks like the dup2 call is calling into libc, which must be re-bound, which requires dyld, which has a global lock, which was already locked in the parent.
We are also importing plugin via containerd, so I suspect it's related.  This is highly reproducible in "release" builds of the product (https://github.com/datadog/datadog-agent) but not in dev builds, and when it reproduces it occurs fairly late in the process startup: we shell out to lots of subprocesses, probably simultaneously with gathering containerd information, and around 5s into that, a subprocess will hang.  That suggests that if this is a race condition, it's got a pretty broad failure window.  Also, I don't have containerd installed on my system, so it's unlikely that it's actually loading any plugins, but I'll continue to investigate that.

Glad to know someone else might have been saved some time by this report! Hope they fix it someday (though it's not blocking me, and I don't expect it will for some time).

I cannot reproduce this locally, using hangme, with go1.16.5 or go1.16.7, which are the versions we are using in our production builds. There's some other ingredient here, as well.  Do you happen to have a recollection of other details of the environment where you saw this fail? OS X version, go version, etc.?

^^ I take that back, right after posting the comment, it failed (go1.16.7).

I've adjusted hangme to run lots of exec's in parallel, and it reproduces much more quickly.  I can confirm it does not reproduce with the unused plugin import removed.
I've built a custom Go1.16.7 which panics in plugin.Load and plugin.Plugin#Lookup as well as plugin_lastmoduleinit just to be sure that code wasn't being called.  I think that covers everything I could imagine occurring at runtime in this package, and none of it is happening.  So, I don't see what could be causing the mere import of plugin to cause this issue.

One difference I can see is that, when importing plugin:
$ otool -L hangme
hangme:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.60.1)

but when not importing plugin:
        /usr/lib/libSystem.B.dylib (compatibility version 0.0.0, current version 0.0.0)

but I don't know what would cause that.  I think the #cgo linux LDFLAGS: -ldl in plugin_dlopen.go applies only on linux, so no additional linker flags should be involved to include plugin.
Looking at disassembly of hangme binaries both with and without the import shows that the two cgo functions are included in the binary when plugin is imported, but the linker has discarded all of the go functions in the package.
I tried adding the cgo comment directly in hangme.go, and not importing plugin, but was unable to reproduce.  I was also unable to reproduce after removing the cgo comment from plugin_dlopen.go (and stubbing out the calls to it with a panic(..)).

I've narrowed this further, slowing making changes to plugin_dlopen.go.  Here's where I'm at:
--- fails.go    2021-12-15 15:56:19.000000000 -0500
+++ works.go    2021-12-15 15:42:11.000000000 -0500
@@ -7,10 +7,6 @@

 package plugin

-/*
- */
-import "C"
-
 import (
        "sync"
 )

or in words, if plugin_dlopen.go has import "C" in it, then there's a good chance that something holds the dyld global lock when the process is fork()'d.  If it doesn't have import "C", everything works fine.

What if you have some source file outside of the standard library that does import "C"?  I can't see why it would matter whether it is the plugin package that uses cgo or some other package.

For that matter, what if you take your working version, and build with go build -ldflags=-linkmode=external?

I'll try those things.  The pattern of

compatibility version 0.0.0, current version 0.0.0 -> working
compatibility version 1.0.0, current version 1292.60.1 -> failing

appears to have held up.  I'm not sure what that means, though -- any ideas?

The two also seem to be drastically different executables:
dustin.mitchell@bell ~/tmp/hangme [master*] $ dlv exec hangme-succeeds
Type 'help' for list of commands.
(dlv) break main
Command failed: Location "main" ambiguous: runtime.main, main.main…
(dlv) break runtime.main
Breakpoint 1 set at 0x10354d3 for runtime.main() /Users/dustin.mitchell/p/go/src/runtime/proc.go:115
(dlv) c
> runtime.main() /Users/dustin.mitchell/p/go/src/runtime/proc.go:115 (hits goroutine(1):1 total:1) (PC: 0x10354d3)
Warning: debugging optimized function
   110:
   111: // Value to use for signal mask for newly created M's.
   112: var initSigmask sigset
   113:
   114: // The main goroutine.
=> 115: func main() {
   116:         g := getg()
   117:
   118:         // Racectx of m0->g0 is used only as the parent of the main goroutine.
   119:         // It must not be used for anything else.
   120:         g.m.g0.racectx = 0
(dlv) exit
dustin.mitchell@bell ~/tmp/hangme [master*] $ dlv exec hangme-fails
Type 'help' for list of commands.
(dlv) break main
Breakpoint 1 set at 0x4067be0 for main() /Users/dustin.mitchell/p/go/src/runtime/asm_amd64.s:23
(dlv) c
> main() /Users/dustin.mitchell/p/go/src/runtime/asm_amd64.s:23 (hits total:1) (PC: 0x4067be0)
Warning: debugging optimized function
    18:
    19: // main is common startup code for most amd64 systems when using
    20: // external linking. The C startup code will call the symbol "main"
    21: // passing argc and argv in the usual C ABI registers DI and SI.
    22: TEXT main(SB),NOSPLIT,$-8
=>  23:         JMP     runtime·rt0_go(SB)
    24:
    25: // _rt0_amd64_lib is common startup code for most amd64 systems when
    26: // using -buildmode=c-archive or -buildmode=c-shared. The linker will
    27: // arrange to invoke this function as a global constructor (for
    28: // c-archive) or when the shared library is loaded (for c-shared).
(dlv)

import plugin
plugin_dlopen
linkmode
otool -L
result

none
standard go1.16.7
external
compatibility version 1.0.0, current version 1292.60.1
success

none
standard go1.16.7
none
compatibility version 0.0.0, current version 0.0.0
success

_ "plugin"
no import "C"
external
compatibility version 1.0.0, current version 1292.60.1
success?

_ "plugin"
no import "C"
none
compatibility version 0.0.0, current version 0.0.0
success?

_ "plugin"
empty import "C"
external
compatibility version 1.0.0, current version 1292.60.1
failure

_ "plugin"
empty import "C"
none
compatibility version 1.0.0, current version 1292.60.1
failure

_ "plugin"
standard go1.16.7
external
compatibility version 1.0.0, current version 1292.60.1
failure

_ "plugin"
standard go1.16.7
none
compatibility version 1.0.0, current version 1292.60.1
failure

From the above chart and reading https://cs.opensource.google/go/go/+/refs/tags/go1.17.5:src/cmd/cgo/doc.go it seems that the otool -L output is reliably distinguishing internal and external linking.  We only see the 0.0.0 variant when nothing containing import "C" is imported, and when -linkmode=external isn't passed to go build.  I suspect this explains the marked difference in executables in my previous comment.
"Don't call cmd.Start() with external linkage" is not the whole answer, though: the error never occurs with internal linkage, but it does not always occur with external linkage.  So what is the additional variable here?  From the above table, the rule appears to be

If plugin is imported, and
If the plugin package contains an import "C" statement, then
cmd.Start() hangs intermittently

Obviously this isn't a great answer!  What other variables should I investigate?

I just tried copying the stripped-down plugin module locally and that test was also successful.

I don't know what is happening here.  Just a note that in the linker there is special handling of the case in which the plugin case is imported and uses cgo: https://go.dev/src/cmd/link/internal/ld/lib.go?#L551.  I don't see any obvious reason why that would cause a hang, though.

Oh, thanks! I was grepping for "plugin" but hadn't found that yet. That explains why this behavior is tied to the plugin package, and not reproducible with a local copy of that package.
Referring back to earlier in this issue, the hang is because the dyld global lock is held when fork() is called, so trying to resolve a libc symbol in the child results in a deadlock.
At this point, I think that's because of something that link is doing when CanUsePlugins() and iscgo, presumably building a binary that interacts differently with dyld at runtime.  Do you know of folks familiar with the linker that might have some intuition about that connection?

CC @cherrymui @thanm

(just confirmed this is still an issue with go1.17.5 and go1.18beta1)

Thanks. I can reproduce with Go tip locally as well. I'll look into it.

The difference for if plugin is used is that it pass -Wl,-flat_namespace to the darwin linker https://cs.opensource.google/go/go/+/master:src/cmd/link/internal/ld/lib.go;l=1272 , which is necessary to support plugins.
If I remove the import of plugin package but pass -ldflags="-linkmode=external -extldflags=-Wl,-flat_namespace", I can still reproduce.

It seems it hangs if only the parent uses plugin. I can reproduce if hangme just shells out /usr/bin/true.
It does not hang if only the child uses plugin, but parent does not.

With async preemption disable it can still hang, albeit with seemingly lower frequency. So #41702 or any workaround related to that probably would not help.

As mentioned above (thanks @djmitche !) this may be related to the dynamic linker resolving bindings. Forcing early binding resolution (-Wl,-bind_at_load) seems to make it no longer hang. At least I can no longer reproduce. I sent a CL for the workaround.
I'll look further into it to see how exactly this happens and if it is a bug of the dynamic linker.

From dyld source
	// <rdar://problem/8663923> race condition with flat-namespace lazy binding
	if ( this->usesTwoLevelNameSpace() ) {
		// two-level namespace lookup does not require lock because dependents can't be unloaded before this image
	}
	else {
		// acquire dyld global lock
		if ( lock != NULL )
			lock();
	}

So it is indeed that the use of flat namespace makes it acquire the global lock (which could deadlock if we're forking while the lock is held and the child needs to resolve a binding before exec). Resolve bindings ahead of time seems the right workaround to me.
Another possibility is to  just resolve the set of symbols that the child may use before exec (e.g. by making dummy syscalls before forking). Probably not worth it.

Awesome, what teamwork!  Knowing what's wrong, and that there's a fix in a future Go, means we can work around it for the time being.

@gopherbot please backport this to previous releases. This can cause program that uses plugins to hang on macOS.


code splitting

I was also looking to use inversifyJS and was very glad that you working on creating this component. So, I like to ask whether this component support code-splitting and SSR kind of things?

Hey, inversify-components is not built for the client at the first hand. We don't handle things like server side rendering.


stuck with curl under alacritty

Hello, this tool is pretty cool, but when I use this tool under terminal. it stucks as blew:
▸ d hello world
curl: (3) URL using bad/illegal format or missing URL

why would this happen ? :joy:

Interesting, can you type curl -V and paste the output here?
Also, please try following command and paste the output as well:
curl -SsLG "http://dict.youdao.com/w/eng/hello world/"

Interesting, can you type curl -V and paste the output here? Also, please try following command and paste the output as well:
curl -SsLG "http://dict.youdao.com/w/eng/hello world/"

sure. the outputs just below.
▸ curl -V
curl 7.82.0 (x86_64-solus-linux-gnu) libcurl/7.82.0 OpenSSL/1.1.1n zlib/1.2.11 libssh2/1.9.0_DEV nghttp2/1.41.0
Release-Date: 2022-03-05
Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS GSS-API HSTS HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz NTLM NTLM_WB SPNEGO SSL TLS-SRP UnixSockets
▸ curl -SsLG curl -SsLG "http://dict.youdao.com/w/eng/hello world/"
curl: (3) URL using bad/illegal format or missing URL

Interesting... seems like newer version doesn't encode URL

Filed a bug on https://github.com/curl/curl/issues/8654

OK，let us wait for reply。😊

@iysheng Fixed, please re-pull and re-install to upgrade

Great, it's ok now,thanks a lot.


Make fragments of Document and Sub-Document available using WHERE query parameter

We notice that when searching within a collection using a WHERE clause/query parameter, it returns the whole document(s) including the sub-documents that do not qualify.
Here's a document:
{     "documentId": "104",     "data": {         "club_checkins": [             {                 "checkin_date": "2021-02-03T18:25:43.511Z"             }         ],         "club_expiration": "2021-10-13T18:25:43.511Z",         "club_id": 12359,         "club_joined": "2020-06-13T18:25:43.511Z",         "club_membership": "50K",         "contact": {             "cell_phone": "+1<PHONE_NUMBER>",             "email": [<EMAIL_ADDRESS>           ],             "home_address": "104 Main St, Palo Alto, CA 95005",             "opt_in": true,             "work_address": "104 Main St, Palo Alto, CA 95005",             "work_phone": "+1<PHONE_NUMBER>"         },         "flight_history": {             "domestic": [                 {                     "bags_checked": 2,                     "flight": "ABC0304",                     "flight_date": "2012-04-23T18:25:43.511Z",                     "miles_earned": 1795,                     "ticket": "68780000-1111-1111-1111-000011110004"                 },                 {                     "bags_checked": 1,                     "flight": "ABC0305",                     "flight_date": "2015-12-23T07:25:43.511Z",                     "miles_earned": 891,                     "ticket": "68780000-1111-1111-1111-000011110005"                 }             ],             "international": [                 {                     "bags_checked": 2,                     "flight": "ABC9303",                     "flight_date": "2013-06-01T06:25:43.511Z",                     "miles_earned": 3458,                     "ticket": "68780000-1111-1111-1111-000011110006"                 }             ]         },         "id": "104"     } }
And we'd like to pull only those elements within Flight_History -->> Domestic array with bags_checked >= 2
Performing a GET request using returns the entire document:

https://{{db}}-{{region}}.apps.astra.datastax.com/api/rest/v2/namespaces/{{keyspace}}/collections/customers?page-size=20&where={"flight_history.domestic.[*].bags_checked" : {"$gte" : 1}}

Is an enhancement feasible to support the requirement?

Thank you @EricBorczuk for clarifying

@ranjitg2021 @EricBorczuk Can you write in a comment a way to solve the problem described in the ticket, so that other people can have a clear picture as well?


Inconeistency for needed npm packages

There is a inconsistency for npm packages under Install identity and bootstrap packages .
In the Visual Studio section, @azure/msal-common is also mentioned as a dependency, but not in Visual studio code. Is it supposed to be this way for some reason?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 10606184-6c56-5925-498a-413a22381186
Version Independent ID: 7cbfe11a-105a-78c2-6b87-8d4869ecec27
Content: Tutorial: Prepare an application for authentication - Microsoft Entra
Content Source: articles/active-directory/develop/single-page-app-tutorial-02-prepare-spa.md
Service: active-directory
Sub-service: develop
GitHub Login: @OwenRichards1
Microsoft Alias: owenrichards

@mrrobertsson
Thanks for your feedback! We will investigate and update as appropriate.

@mrrobertsson
Yes, the @azure/msal-common package is required for both Visual Studio and Visual Studio Code when following the "Single-page application tutorial: Sign in users and call the Microsoft Graph API" tutorial.
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


[Workshop page] Too many numbers are displayed in the average rating of the workshop

Environment: Windows 10, 64-bit, Google Chrome 123.0.6312.58.
Reproducible: always.
Preconditions

Go to https://oos.dmytrominochkin.cloud/;
A workshop must have at least 3 different reviews.

Steps to reproduce

In the search field, select the city of "Івано-Франківськ";
Enter "Паралель" in the search field;
Click on the More details button;
Pay attention to the average rating of the workshop.

Actual result
There are too many numbers in the average rating of the workshop.

Expected result
The average rating of the workshop is displayed in the format "2.3".
Labels to be added
"Bug", Priority ("Priority: Medium"), Severity ("Severity: Major").

This bug also reproduces on the service provider's page with the list of available workshops.


Added responsiveness to PizzaCorner

Description
Fixes:  #(issue no.)

Type of change

[ x ] Bug fix (non-breaking change which fixes an issue)
[ x ] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[ x ] My code follows the style guidelines of this project
[ x ] I have performed a self-review of my own code
[ x ] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

unable to paste screenshots


Plugin does not update

Might be that the manifest did not get an update on version number? It keeps saying there is an update, or it is not downloading the update.

Hey buddy, same here — Anyway your plugin's Rock.

+1

+1

@tijmenvangurp @Microburo @brunogdesign Thanks for reaching out, I totally missed that! I just pushed an hotfix, apologies for the annoying orange badge 😄


Upgrading to AWS SDK V2

Upgraded source and tests to be compliant with AWS SDK V2. Tested in our production environment, works as expected.

Missing aws_region in TravisCI.

I don't like the previous solution with fetch, and I also want to update to Ruby 2.4.1.

Addresses #13. Also, see #21.

I'm just now coming back to maintain this repository using the new AWS SDK and AWS launch templates. I will not be maintaining the old ELBAS that relied on launch configurations and AWS SDK v1. I also have updated this repository to go straight from SDK v1 to v3 and that's what I will focus on going forward.


[camera] access to audio stream during video recording

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
The camera plugin has an option to specify onLatestImageAvailable callback that receives "preview" images from the camera during video recording in order to facilitate on-the-fly video analysis.
However there is no option to specify callback for an audio stream analysis. It would be really handy to have an option to get audio data while recording is still in progress in order to do audio analysis or some visualization during video recording.
Proposal
The camera plugin  API CameraController.startVideoRecording() could have an additional parameter to specify callback to receive the raw audio data (not encoded). E.g. something like this:
typedef onAudioAvailable = Function(List<int> audioData);

Future<void> startVideoRecording(
      {onLatestImageAvailable? onAvailable, onAudioAvailable onAudio}) async {
  ...

Thanks for the report. There's already a similar open issue describing your case, https://github.com/flutter/flutter/issues/108921. Please follow-up in it for further updates.
Closing this as a duplicate.

@darshankawar I don't see anything similar in the issue you referred to. That one is asking about selecting the audio source.
But here I'm requesting access to the actual audio data being recorded and have a rather common use case for that.
Closing this as not planned without providing any alternative or a workaround is very disappointing.

Thanks for the feedback @ekuleshov  I might have misread the issue with the linked one.
Reopening.

@stuartmorgan the platform audio APIs (Android, iOS, etc) usually gives you a stream of PCM buffers. Depending on the audio format configuration each buffer could be a list of numbers, an unencoded/raw list of numbers of specified precision (9, 16, 32, float, etc). There are also options to get encoded/compressed or non-encoded data. For audio analysis an uncompressed data is needed.
For example:

on Android https://developer.android.com/reference/android/media/AudioFormat#encoding
on iOS https://developer.apple.com/documentation/avfaudio/avaudiopcmbuffer?language=objc and APIs around it

Admittedly there are several 3rd party plugins to capture audio from Flutter. But none of them is integrated or can be synced with the video capture.

Any update on this issue, I'm also having the same issue on iPhone, but Android app works fine.


Property attribute in continuation class does not match the primary class

FYI there is a compiler warning that mentions a type mis-match between the .H and .M files:
.H file:
@property (nonatomic, strong, readonly)	id	targetObject;
.M file:
@property (nonatomic, retain, readwrite)	id	targetObject;
So should this property be readonly or readwrite?

Oh - I just noticed it's a private variable vs public variable issue.  I'd recommend renaming one.

Hi, targetObject is a property that is publicly read-only, but privately read-write.
You shouldn't see a compiler warning as this is standard Obj-C Property Redeclaration ( http://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ObjectiveC/Chapters/ocProperties.html#//apple_ref/doc/uid/TP30001163-CH17-SW19 )
Which SDK/Xcode/Compiler combination are you using?
For example, right now with iOS 5 SDK, Xcode 4.2.1, LLVM 3.0, I see no compiler warnings.
Cheers,
Chris

Xcode 4.2.1, SDK 5.0 because I'm working on an iCloud enabled app.
Thanks,
-Matt


feat: Adds a safeguard validation for the user table

This PR introduces a safeguard filter when the user table is processed before sending it to mainline backend.

/quack review

/quack review

/quack review

/quack review

/quack review

/quack review

/quack review

/quack review

/quack review

/quack review


All Regions not available for Python Functions on Linux

As reported here https://github.com/Azure/Azure-Functions/wiki/Azure-Functions-on-Linux-Preview, you can only deploy Python Linux Functions Apps in the following regions:
West US
East US
West Europe
East Asia

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a509bdc-f8b8-8488-7ab4-2c03cae6bfb5
Version Independent ID: 3174a893-394c-c622-6c96-0b89955edfb5
Content: Create an HTTP triggered function in Azure
Content Source: articles/azure-functions/functions-create-first-function-python.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @joshmosby Thank you for your feedback! We will review and update as appropriate.

Hi @joshmosby Thanks for pointing this out and helping us drive improvements towards MS Docs! We have added following statement in the Note section that follows the particular step where we create the function app on Azure to clarify that the app will be available on the said regions:

Azure Functions, Consumption plan for Linux is currently in preview and only available on following regions: West US, East US, West Europe, East Asia.

The changes should reflect with our next scheduled auto-merge within 24hrs. We will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


OS singleton destroys memory pool manager too soon

In those platforms that require the OS singleton to be created/destroyed dynamically by calling new/delete, the memory pool manager is destroyed before the OS singleton, causing that those objects in the singleton that were created using the memory pool manager, fail to be freed.
For instance the OS singleton in the iOS platform
int iphone_main(int width, int height, int argc, char** argv) {
    //...
    os = new OSIPhone(width, height);
    //...
};

void iphone_finish() {
    printf("iphone_finish\n");
    Main::cleanup(); // <-- this destroys the memory pool manager
    delete os; // ... but the manager is needed here
};

The error reported by Godot for this error is:
ERROR: free_static: Condition ' !MemoryPoolStatic::get_singleton() ' is true.
   At: /Users/rhodylugo/Desktop/Godot/core/os/memory.cpp:58.

What's the status on this issue? Is it still valid in the current master branch? Why was the above commit not proposed in a PR?

Can someone reproduce this issue, and if so, is the proposed patch meaningful?

Closing as old, since inactive and nobody confirmed the issue so far. Feel free to comment and ask me to reopen if the issue is still valid.

I opened a topic at the Godot Q&A that might circle back to this issue: https://godotengine.org/qa/9630/godot-editor-interface-performance-bottleneck-on-mac-os-x?show=9697#c9697

@fogelfish I recommend you to open another issue with your specific responsiveness problem. It's not clear that the problem you're having is related to this issue.

Anyway, based on the QA post, there's two confirmations that this is still valid.

Is it still valid in the current master branch?

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

As there was no answer to the above request, we're closing this issue as inactive.
If you can still reproduce it, please open a new issue against a currently supported release of Godot.


Does Link support set parameter, auto fill path ?

I mean something like:
const docId, name, tagValue = this.props;

<Link to="/doc/:docId" params={ docId: docId}>detail</Link>
<Link to="/doc/:docId?search=:name&tag=:tag" params={ docId: docId, name:name, tag:tagValue}>detail</Link>

For now, I have to write a function to do such thing:
function docUrl(docId) {
  return `/doc/${docId}`;
}

<Link to={docUrl(n.id)} >detail</Link>

Use PatternUtils.formatPattern is something similar,  hope this feature can be embed in Link.

Unfortunately, no. Our underlying library (path-to-regexp) is one-way and doesn't support rebuilding URLs with named parameters.

I think it is a quite common requirement.  May I ask the reason?  Performance ?

path-to-regexp does support this, but React Router isn't really configured to take advantage of it. The feature that you're requesting works best when you have named routes, which React Router does not have. Instead, with React Router, you are always using the full pathname.
You could in theory write your own <Link> component to take advantage of this, but I don't really see the advantage of doing so.
For example, this:
<Link to="/doc/:docId" params={{ docId: docId }}>detail</Link>

is more verbose than this:
<Link to={`/doc/${docId}`}>detail</Link>

If you have named routes, then you can do the following, but named routes and dynamic routing don't really flow together.
<Link to="Detail" params={{ docId: docId }}>detail</Link>

Also, path-to-regexp only does pathname matching/compiling, so the query string that you include in your example would not work even if React Router supported this.


Huge memory footprint

Describe the bug
Spark profiler reported that advancedseasons is using way too much memory
How to reproduce
Install the plugin, then wait for couple of hours while running the memory profiler (/spark profiler start --alloc)
Screenshots / Videos
No response
Server Log
No response

Fixed! Wait for the next update and if you have more issues, we are here to fix them!


XML parser bugfix [5047]

This pull request solves temporarily the error with the XML parser dependency.
This temporal solution must be improved creating an XML parser independent of  Fast RTPS.

Build status:

Linux
Windows

Build status:

Linux
Windows


Functions and Trigger commands

Updated apps to use appID instead of name.
Added functions and triggers command.
Invoking a function/trigger is not yet supported.
Both fn and fn_go have the trigger branches in master.

I think we should. The client is initialized on each app command, is there a way to check what API server is being used so we can create the client dependent on that?
Also are we planning to hide the functions/triggers commands initally? @owencliffe @msgodf

Not sure using the api-url works in general here - currently it's not canonically with or without the version suffix (the provider currently normalises it based on this - that's how it provides both v1 and v2 clients.

Discussed this more with @zootalures - checking the api-url won't quite work. Wondering if we have the CLI enforce a minimum required server version somehow? Checking the Server version does require an API call, which we don't really want to have to make on each CLI invocation, but we could cache the last-seen version for a given context in the context .yaml, and only look up if that is not present or lower than the version required by the CLI? If the resultant version is still too low, simply message that the server version is too low and to upgrade the server - might only need something like this when using a default context.

Maybe just on error?


Alternatives for jsx

Looks like sooner or later jsx becomes a big mess in big components. So the goal is to look for the alternatives:

native syntax
hyperscript-helpers

At the first approach hyperscript looks pretty good. Small reference:
import { createElement } from 'react';
import h from 'hyperscript-helpers';
import Button from '../button.js';

const { createTag, div } = h(createElement);
const button = createTag(Button);

export default () => div(null, button({className: '.button'}, 'click me'));

Looks like hh is a good choice


[improve][ci] Improve TestNG test execution to debug flaky test failures

Motivation
In order to investigate some flaky test failures such as #20386, it is necessary to add logging to find out what was the failure of the first attempt. In some cases, the exception in the test retry is not the root cause.
In the case of #20386, there's "Index 0 out of bounds for length 0" recorded in the skip message:
  <testcase name="testMsgDropStat" classname="org.apache.pulsar.client.api.NonPersistentTopicTest" time="0">
    <skipped message="Index 0 out of bounds for length 0"/>

However, the full exception isn't logged.
Modifications

Log possible exceptions before retrying a test run

this will help debug issues when tests are retried

Don't log anything when skipping is a result of fail fast mode (SkipException)
Execute cleanup methods when using fail fast mode
the change in #19252 broke the logic that intends to run cleanup methods after the first failure

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #20425 (d730f75) into master (aa3bfcd) will decrease coverage by 0.01%.
The diff coverage is 78.57%.

@@             Coverage Diff              @@
##             master   #20425      +/-   ##
============================================
- Coverage     72.90%   72.90%   -0.01%
- Complexity    31864    31877      +13
============================================
  Files          1864     1865       +1
  Lines        138416   138439      +23
  Branches      15188    15192       +4
============================================
+ Hits         100919   100932      +13
- Misses        29477    29491      +14
+ Partials       8020     8016       -4

Flag
Coverage Δ

inttests
24.20% <10.71%> (+0.02%)
:arrow_up:

systests
25.00% <10.71%> (-0.07%)
:arrow_down:

unittests
72.18% <78.57%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...a/org/apache/bookkeeper/mledger/ManagedCursor.java
42.85% <0.00%> (-3.30%)
:arrow_down:

...a/org/apache/bookkeeper/mledger/ManagedLedger.java
0.00% <0.00%> (ø)

...rg/apache/bookkeeper/mledger/impl/OpReadEntry.java
84.31% <75.00%> (+4.72%)
:arrow_up:

...che/bookkeeper/mledger/impl/ManagedCursorImpl.java
78.79% <76.92%> (+0.33%)
:arrow_up:

...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java
81.32% <100.00%> (+0.16%)
:arrow_up:

...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java
89.31% <100.00%> (ø)

...kkeeper/mledger/impl/cache/EntryCacheDisabled.java
70.83% <100.00%> (ø)

...keeper/mledger/impl/cache/RangeEntryCacheImpl.java
58.75% <100.00%> (ø)

... and 65 files with indirect coverage changes


refactor(perception): rearrange clustering pipeline

Description
This PR rearrange downsample_filter in clustering pipeline and add low_range_crop_filter to limit hight pointcloud before Euclidean cluster.

Realated link
TIER IV INTERNAL LINK
slack
ticket
Releated PR
Tests performed
Tested result by logging_simulator using internal data.
perception_mode: camera_lidar_fusion_based

perception_mode: lidar_based

Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

It is not change in this PR, but one question.
Is this shape_estimation node necessary?
https://github.com/autowarefoundation/autoware.universe/blob/3d3aa4f1199e6f73a1fc0bdd2329f32d5c1240cd/launch/tier4_perception_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml#L129-L134

It is not change in this PR, but one question. Is this shape_estimation node necessary?
https://github.com/autowarefoundation/autoware.universe/blob/3d3aa4f1199e6f73a1fc0bdd2329f32d5c1240cd/launch/tier4_perception_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml#L129-L134

@miursh It seems the estimated shape isn't used in detection_by_tracker so I think it is unneccessary. I will check carefully and changed it in another PR.


Updated Readme for Direct Uploads

This would have helped me when i first used the gem.  May be useful information for someone else.

I think the format of this is a bit of a mess. Content-Type is a header, not a param, and I have no idea what the params section is supposed to be. Maybe describing this in text would actually be more helpful, since the file can actually be sent encoded in a number of ways, just provided Sinatra can parse it.
Also, if we add a section like this, it should really talk about Refile.direct_upload.

Cool, will reformat and resubmit.  The content-type was part of the headers used in a successful send using a rest api client so i can see how that would be confusing to people just looking at it from a params standpoint.
Is the location in the read me good or do you want a new section?

I'll reopen once this receives further updates.


Replace tests_per_second with test_interval

Every time I'm looking on this option I do convertation from interval to frequency and vise versa. I think this is probably because intervals are widely used in programming. Also I have to pass fractional values when I want the check to happen once per two seconds or more.
For this specific task I think interval is more convenient because it is easy to compare interval with hanging time, while it's hard to compare frequency with time without doing convertation.

@niccokunzmann What is your opinion about this?

Sure, let's do this. I think it is important to document the unit: seconds or milliseconds.

I think it's generally better to use milliseconds as unit or should we support unit to be changed ?

All is fine. I think, we can close this. If I forgot something, please re-open!


server/lock_manager: Support reporting the full wait chain when deadlock is detected

This PR is now reviewable. But before merging, I want to test if there's any performance regression and try to optimize it if necessary.
What problem does this PR solve?
Problem Summary:
We are going to implement the feature Lock View . A part of it is to support collecting information about recent deadlocks.
What is changed and how it works?
What's Changed:  Two more fields key and resource_group_tag is added to deadlock detection request, deadlock detector's inner information, and deadlock error message. SQL Digest will be encoded into resource_group_tag. The resource_group_tag may also be used by another feature Top SQL, and they want to pass both SQL Digest and the plan to TiKV by the resource_group_tag.
Related changes

Requires kvproto: https://github.com/pingcap/kvproto/pull/752

Check List
Tests

Unit test
Manual test

Tested several simple workload with this PR: https://github.com/pingcap/tidb/pull/24380 , and compared with the merge base to master.
There are 1 TiDB node and 3 TiKV nodes, each has 16c cpu adn 90G mem (TiDB has 64G), nvme disk.
No observable performance regression is found, no observable difference is found in TiKV's metrics.

With this PR
Workload
Threads
Table size
QPS
.95 lat

Y
oltp_read_write
32
100,000
14455.2
54.83

Y
oltp_read_write
128
100,000
24456.78
127.81

oltp_read_write
32
100,000
14522.35
54.83

oltp_read_write
128
100,000
24734.54
127.81

Y
oltp_write_only
32
100,000
10184.40
31.37

Y
oltp_write_only
128
100,000
21315.33
80.03

oltp_write_only
32
100,000
10227.46
31.37

oltp_write_only
128
100,000
20600.07
82.96

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Release note

No release note

/bench

/release

/bench

/release

/test

/test


Add WASM MIME type

This PR fixes #125778 (not really in the full generality I requested there, but it fixes the specific problem I needed it for). WebAssembly local resources are now served with the proper MIME type.

Thanks!


Font Styles Added

Just added font styles.
Adding images review it.

@vedant-jain03  basically font style should also come under theme popup if i under stand correctly


New features and preparation for release 0.3.0

Release 0.3.0 breaks backward compatibility with the earlier releases. Specific changes and new features are as follows:

Concurrent animations: it's now possible for either or both view controllers (presenting and presented) to participate in the drawer animation so that their views can be animated while the drawer is moving up and down.

Automatic display of a "handle view": it's now possible to have the drawer add a "gray bar" near its top. This bar, referred to as the "handle view", can be customised in its size, background color, and corner radius, and can be automatically dimmed as the drawer moves towards its collapsed or fully-expanded states.

Support for not expanding to cover the entire screen. It's now possible to select the behaviour of the drawer when it fully-expands itself. You may choose from covering the entire screen (the default), not covering the status bar, and leaving a gap at the top, of any desired size.

Partial transitions (collapsed to partially-expanded and partially-expanded to fully-expanded, and vice-versa) can now have durations that are equal to, or fractions of, the duration for a full-size transition (collapsed to fully-expanded, and vice-versa). This allows for transitions to have the same speed, if desired.


Increase polling frequency

Once per minute shouldn't be too hard on the DWD servers

Please make the polling frequency configurable. I think this would be handy for brightsky deployments on low power devices.


Porting Google sheets for POC

Fixes #6591

Closing as unnecessary. Porting Google sheets in the same plugin in #9506


Options

Why not allow options to be passed in
Something like
def photos(album_id, opt={})
  data = connect("/data/feed/api/user/#{Picasa.config.google_user}/albumid/#{album_id}&#{opt.to_query}")
 ...

would do the trick. (useful when wanting different sized images)

Hi.
Passing custom options will be supported in next release - you can already use it on rewrite branch

Sounds good, thx

Sounds good, thx


Podman inside execution enviroment using ansible-navigator

ISSUE TYPE

podman enabled base EE

SUMMARY

Unable to run podman modules or ansible-builder inside an execution enviroment using ansible-navigator.
Steps to reproduce the issue:

Try to run any podman module/command on an Execution enviroment.

Describe the results you received:
Depending on how I build it, get either
podman run localhost/ee_tools ansible localhost -m ansible.builtin.shell -a 'podman images'
REPOSITORY  TAG         IMAGE ID    CREATED     SIZEtime="2021-10-07T20:03:22Z" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers"
time="2021-10-07T20:03:22Z" level=warning msg="using rootless single mapping into the namespace. This might break some images. Check /etc/subuid and /etc/subgid for adding sub*ids"

or
Errors were encountered while running the playbook:
ERROR! Invalid callback for stdout specified: awx_display...
[HINT] To see the full error message try ':stdout'
[HINT] After it's fixed, try to ':rerun' the playbook

Describe the results you expected:
things to work.
Additional information you deem important (e.g. issue happens only occasionally):
This is the working dir where I've been storing info trying to do this
This may be out of the scope of whats is expected here, but thought it might be a good place to broach the subject.

Container in container is.......... tricky.  You may find some help here: https://github.com/cidrblock/container_in_container.  The team is working on a more formal approach/answer to this and we should have something in the next few months.

@jorgenspange This was my fix
https://www.redhat.com/architect/ansible-execution-environment-automated-build

Thi8ngs take time :)  We've got container-in-container setup here: https://ansible.readthedocs.io/projects/dev-tools/container/
It's a devcontainer image, ee image, and has podman installed and working.


Dataset Release Time

Hi, thanks for your great work. When will the training dataset and the evaluation code be available?

Same question. It will be of great help if the dataset can be out soon. Also, the download link of test-01 set is not working anymore. I'm afraid it might need some updating work. Thanks a lot!


feat: velodyne lidar azimuth correction

PR Type

Improvement

Related Links

Description
I fixed https://github.com/tier4/nebula/pull/112 azimuth correction function pr. It was reverted.
This pr makes nabula velodyne detecoder lighter.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

I checked the azimuth value and LGTM!

Hi, I just merged the current main branch into your PR but it seems that this PR:

https://github.com/tier4/nebula/pull/150
produces a conflict in the VLS128 unit tests (that PR modified the Rosbag used, so the unit tests of this PR fail now).

Could you regenerate the VLS128 unit test .pcd file once more?
Sorry for the extra work this causes :bowing_man:


Merge pullrequest feature

Feature to merge pullrequest.

Thank you for your pr !
I'll check this in this week.

+1

Your code looks good to me !
But I try to merge my pull request with thie feature on bitbucket, Bitbucket API respond 400 Error response with {"error": {"message": "Conflicts during merge."}}. (My pull req on bitbucket does not have conflict issue.)
This problem looks like Bitbucket API issue...

I have the same problem  and i open this issue https://bitbucket.org/site/master/issues/11895/error-api-accept-and-merge-a-pull-request .
I will contact the support.

Thanks, @mvlbarcelos !

Hi @hirakiuc follow up of a issue:
Hi Marcus,
I've talked internally to some colleagues and this looks to be a bug.
I'm escalating this for our Developer Team and we should be back to you soon.
Thank you in advance for your patience.
All the best
Renato Rudnicki
Atlassian Support

Hi @hirakiuc follow for this issue:
https://bitbucket.org/site/master/issues/11895/error-api-accept-and-merge-a-pull-request
From the development team:
This is a bug. It is not using the default commit message for the merge commit when using the API. The fix will be deployed to production by this coming Monday. A workaround is to specify a message in the request you send. The docs are correct in stating that the message field is optional, but for the time being you will need to specify one.
https://confluence.atlassian.com/bitbucket/pullrequests-resource-423626332.html#pullrequestsResource-Acceptandmergeapullrequest

From the development team:
This is a bug. It is not using the default commit message for the merge commit when using the API. The fix will be deployed to production by this coming Monday.

I see.
I'll try to test again after next Monday,  and merge this pull request if no problem occurred.
Thanks again, @mvlbarcelos !

I try to merge my pull req on bitbucket with this feature, and merged successfully.
:+1:


Update Stackdriver Agent so we don't need API keys

Changes

Change the init scripts to use GCM, using the almost-default stackdriver script now
Add a ruby script to download the stackdrier-agent deb and repackage it for our release [binary bits only]
Removed stackdriver-extractor, this is not used in a 'GCM' configuration
Update to latest stackdrier-agent
Added libyajl, new dependency for the agent

Story: #131196105
Validation
Deployed to bosh/CF instances and observed metrics on stackdriver

ping @evandbrown

@johnsonj LGTM. Rebase from master, push, and you're good to merge!