[Impeller] drawShadow behaves differently on the impeller compared to Skia

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

run demo code on impeller

	<key>FLTEnableImpeller</key>
        <true/>

run demo code on skia

   <key>FLTEnableImpeller</key>
       <false/>

Expected results
drawShadow behaves the same on the impeller as it does on Skia.
Actual results
drawShadow behaves differently on the impeller compared to Skia.
Code sample
Code sample

import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      title: 'Demo',
      home: TestPage(),
    ),
  );
}

class TestPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Demo"),
      ),
      body: CustomPaint(
        painter: TestCustomPainter(),
      ),
    );
  }
}

class TestCustomPainter extends CustomPainter{
  @override
  void paint(Canvas canvas, Size size) {
    var shadowPath = Path();
    shadowPath
      ..moveTo(-11.0, 790.0)
      ..lineTo(350.0, -389.67592592592587)
      ..lineTo(165.4612188365651, 844.0)
      ..close();
    canvas.drawShadow(shadowPath, Colors.black, 40, true);

  }

  @override
  bool shouldRepaint(covariant CustomPainter oldDelegate) {
    throw false;
  }

}

Screenshots or Video

Screenshots / Video demonstration

Skia
impeller

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel beta, 3.13.0-0.2.pre, on macOS 13.4.1 22F82 darwin-arm64, locale zh-Hans)
    • Flutter version 3.13.0-0.2.pre on channel beta at /Users/zohar/flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ac71592bc6 (11 days ago), 2023-07-18 14:53:57 -0600
    • Engine revision e14db68a86
    • Dart version 3.1.0 (build 3.1.0-262.2.beta)
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/zohar/Library/Android/sdk
    • Platform android-34, build-tools 33.0.0-rc4
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.4)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.4.1 22F82 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 115.0.5790.114

Hi @Liloupar, this has been fixed on the master channel. See the screenshots below.
Per our triage policy, I'll be closing this since it has been fixed on the master channel. If you run into this issue on the master kindly leave a comment below and I will reopen this.
Thank you

beta
master

flutter doctor -v
[!] Flutter (Channel beta, 3.13.0-0.1.pre, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.13.0-0.1.pre on channel beta at /Users/nexus/dev/sdks/flutter_beta
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter_beta. Consider adding /Users/nexus/dev/sdks/flutter_beta/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter_beta. Consider adding /Users/nexus/dev/sdks/flutter_beta/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1f6bdb6fa2 (3 weeks ago), 2023-07-11 14:31:59 -0700
    • Engine revision ae470c12d3
    • Dart version 3.1.0 (build 3.1.0-262.1.beta)
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 74.0.5
    • Dart plugin version 232.8660.129

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9225.16/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.8660.185/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (4 available)
    • Pixel 7 (mobile) • 28291FDH2001SA            • android-arm64  • Android 13 (API 33)
    • Nexus (mobile)   • 00008020-001875E83A38002E • ios            • iOS 16.5.1 20F75
    • macOS (desktop)  • macos                     • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)     • chrome                    • web-javascript • Google Chrome 115.0.5790.114

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 3.13.0-12.0.pre.41, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.13.0-12.0.pre.41 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision af5d9c198b (2 hours ago), 2023-07-31 03:05:27 -0400
    • Engine revision 22f9aad5ab
    • Dart version 3.2.0 (build 3.2.0-15.0.dev)
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9225.16/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.8660.185/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (4 available)
    • Pixel 7 (mobile) • 28291FDH2001SA            • android-arm64  • Android 13 (API 33)
    • Nexus (mobile)   • 00008020-001875E83A38002E • ios            • iOS 16.5.1 20F75
    • macOS (desktop)  • macos                     • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)     • chrome                    • web-javascript • Google Chrome 115.0.5790.114

[✓] Network resources
    • All expected network resources are available.

• No issues found!


chore: Cleanup extra parenthesis in chart

Fixes #N/A
Description
Cleanup extra parenthesis in helm chart that are unneccesary
How was this change tested?
make presubmit
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.283%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
5974

Relevant Lines:
7535

💛  - Coveralls


Scalatest 3.1.1

Codecov Report

Merging #228 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   62.14%   62.07%   -0.08%
==========================================
  Files          38       38
  Lines        1284     1284
  Branches        6        8       +2
==========================================
- Hits          798      797       -1
- Misses        486      487       +1

Impacted Files
Coverage Δ

...s2/src/main/scala/laserdisc/fs2/RedisChannel.scala
73.68% <0%> (-5.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba528d...e959faa. Read the comment docs.


Update README.md

I think Bostr would be also very helpful for decentralization.

Does not looks needs to be added as it's just an proxy that still connects to certain relays.
Nostr is not really decentralized, It's more of being portable than decentralized by itself.

While it may still seems connecting to different server, the events is still being accessed or stored in other servers.

Ok, thanks for your reply :)


Update LICENSE to Bauddhik-Geeks

Change License Owner from EFFLUX to Bauddhik-Geeks

@EFFLUX110 You can do this by yourself too

@adityamangal1 this is for very beginners to start their open source contribution

@EFFLUX110 You can do this by yourself too

@harikanani told me to keep it for others to contribute.


DX12 debug layer errors on MeshViewer PostVS

Description

MeshViewer PostVS rendering causes debug layer errors on IASetVertexBuffers and IASetIndexBuffer for DX12:
[13324] D3D12 ERROR: ID3D12CommandList::IASetVertexBuffers: 0x000002700DCD4190 + SizeInBytes - 1 (0x000000010aa27ffe) exceeds end of the virtual address range of Resource (0x000002700DCD4190:'PostVS vsoutBuffer for 17', GPU VA Range: 0x000000000aa28000 - 0x000000000aa2805f).  [ EXECUTION ERROR #726: SET_VERTEX_BUFFERS_INVALID]
[13324] D3D12 ERROR: ID3D12CommandList::IASetVertexBuffers: 0x000002700DCD4190 + SizeInBytes - 1 (0x000000010aa27ffe) exceeds end of the virtual address range of Resource (0x000002700DCD4190:'PostVS vsoutBuffer for 17', GPU VA Range: 0x000000000aa28000 - 0x000000000aa2805f).  [ EXECUTION ERROR #726: SET_VERTEX_BUFFERS_INVALID]
[13324] D3D12 ERROR: ID3D12CommandList::IASetIndexBuffer: pDesc->BufferLocation + SizeInBytes - 1 (0x000000010aa26ffe) exceeds end of the virtual address range of Resource (0x000002700DCD3D00:'PostVS idxBuf for 17', GPU VA Range: 0x000000000aa27000 - 0x000000000aa27017).  [ STATE_CREATION ERROR #725: SET_INDEX_BUFFER_INVALID]

This should reproduce with any DX12 app.
Steps to reproduce

Use DebugView or Visual Studio Debug Output view or similar.
Capture a DX12 app and open the PostVS tab in MeshViewer.
Observe the debug layer errors in DebugView etc.

Environment

RenderDoc version: 1.28
Operating System: Windows 10
Graphics API: DX12

Cause
The direct cause seems to be MeshFormat::vertexByteSize and MeshFormat::indexByteSize being set to 0xFFFFFFFF;
https://github.com/baldurk/renderdoc/blob/d78565df33e1b2e2a4550de6c689b77d22dc4a82/renderdoc/driver/d3d12/d3d12_postvs.cpp#L1514
https://github.com/baldurk/renderdoc/blob/d78565df33e1b2e2a4550de6c689b77d22dc4a82/renderdoc/driver/d3d12/d3d12_postvs.cpp#L1496
which causes D3D12_VERTEX_BUFFER_VIEW::SizeInBytes and D3D12_INDEX_BUFFER_VIEW::SizeInBytes to be set to 0xFFFFFFFF:
https://github.com/baldurk/renderdoc/blob/d78565df33e1b2e2a4550de6c689b77d22dc4a82/renderdoc/driver/d3d12/d3d12_rendermesh.cpp#L403-L407
https://github.com/baldurk/renderdoc/blob/d78565df33e1b2e2a4550de6c689b77d22dc4a82/renderdoc/driver/d3d12/d3d12_rendermesh.cpp#L547-L551
I tried to tackle this myself but it wasn't clear if I'm correctly covering all cases myself, e.g instancing, geometry shader, etc.

Can you explain what the user-visible problem is here rather than referring to code internals? Do you get a crash, misbehaviour, or hang? When just using the program what is visible as wrong?

Sorry I wasn't clear enough.
I do not visually observe anything being incorrect on my RTX 3090 Ti (536.23.0), I am just assuming this is UB and thought it best to bring it to attention.

Ah OK, I understand. If nothing is wrong then I'll close this issue. There are many false positives and negatives in the D3D12 validation layers so it's not worth the time to investigate unless there is a real problem to be observed.


[BACKLOG-26272] Remove page transitions for status changes on Carte s…

…erver status page on Pentaho Server

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/www/CleanupTransServlet.java
  engine/src/main/java/org/pentaho/di/www/GetStatusServlet.java
  engine/src/main/java/org/pentaho/di/www/PrepareExecutionTransServlet.java
  engine/src/main/java/org/pentaho/di/www/RemoveJobServlet.java
  engine/src/main/java/org/pentaho/di/www/RemoveTransServlet.java
  engine/src/main/java/org/pentaho/di/www/StartJobServlet.java
  engine/src/main/java/org/pentaho/di/www/StartTransServlet.java
  engine/src/main/java/org/pentaho/di/www/StopJobServlet.java
  engine/src/main/java/org/pentaho/di/www/StopTransServlet.java
  engine/src/main/resources/org/pentaho/di/www/messages/messages_en_US.properties

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: +0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.www.CleanupTransServlet

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.6% :small_red_triangle_down:

org.pentaho.di.www.StartJobServlet

Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.2% :small_red_triangle_down:

org.pentaho.di.www.StartTransServlet

Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

org.pentaho.di.www.StopJobServlet

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.6% :small_red_triangle_down:

org.pentaho.di.www.StopTransServlet

Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

@bmorrise


Fold code sections back after being searched over

Closes https://github.com/godotengine/godot-proposals/issues/5361
When you have a big script where most functions are folded, the Find&Replace bar becomes a wrecking ball if you're searching for something far down in the script.
https://user-images.githubusercontent.com/85438892/188762548-1ab5692e-ef9a-4d77-bb08-d51d684b3fe6.mp4
This PR makes it so until you close the bar or change the script, Find&Replace will only temporarily unfold lines, like a small peek inside the current search result:
https://user-images.githubusercontent.com/85438892/196509512-fba7d570-990b-4888-ab4d-326c5e0ebbc8.mp4

Something popped up in my head. Should temporary line unfolding be implemented in CodeEdit instead? I think it might be useful to have for searching over folded lines (i.e. Find in Files too)

Just an enhancement, should be postponed.

I'm still looking forward to this being considered.

Dropping it in rocketchat will likely get more attention

Made the changes mentioned above, except for fixing how this goes out of scope. I'll search for a solution to this now.

I've provided a solution to the first line case above

I think the bug is also minor, afaik the first line never makes sense to be foldable in languages that someone might use in Godot. It's absolutely not a blocker and I have a feeling I be able to sniff out a clean solution that doesn't overscope the PR. :)

The first line being foldable makes sense, see my example, no reason not to implement the fix

I mean that the first line would realistically be extends Something, class_name Something, @tool, or @icon("path/to/icon"). Similarly for pretty much any other language. A few languages might be exceptions, and it's possible to have an invalid script for some reason, just saying it's not that important imho.
But I'm looking into it right now.

Yes, but the fix I've given is so trivial that it's worth fixing :) just try out my code

I'll do it if I don't figure out anything else, dw.

Anything else for the foldable region? Or for the first line?

Any way to make the search not go out of scope and possibly check the entire document. What you've suggested is a workaround for a real bug. Also tbh I don't like do {} while

Fair enough, but there's still an issue that the code there treats the 0 like differently in a way that isn't correct

Yea yea I'll submit a fix soon whether I find something or not

One idea is to add a function to CodeEdit, can call it find_folded_line(int p_line) that does something like:

checks that the current line is hidden, if not return -1
walk up and find the first folded line, which is indicated by that the line is not hidden and the next line is, this would be as simple as just scanning for the first line that isn't hidden

This should always return the first line in a block of folded lines, or -1 if there's no folding
This could then be used here, and we'd check if the return value is not -1 and unfold in that case
This removes the need for finding what I was suggesting above, as we now only get the valid segment
Will test some code tomorrow if I am able

I think I got it. If a line doesn't start with whitespace, we can stop backtracking.

Oh, yeah that's true - but in_string and in_comment checks should really solve all cases.

Not cases like this:
func test()
    foo()
(No indentation)
    bar() <-

Sorry, I'm a tad confused about this example. This isn't valid code, and "(No indentation)" is gonna, indeed, be the part that folds bar()

It is valid code, just a line with no indentation is legal gdscript, it's just an empty line here

... Oh. Ok, I see the problem now. Well, I still think a way to catch all this is trivial, I'll do it there and then comment out what it's trying to do in case we wind up implementing a method for this at some point.

Should be good now I think?

Looks right I think, unable to test it at the moment but will as soon as I am able

Ok thanks a lot for the assistance!

Tested and it seems to work generally, it does have one quirk though, which might be considered undesirable
In the following file, search for foo
func test_a():
    foo()

func test_b(): # Folded
    foo()

    bar()

func test_c():
    foo() <-

And stop when you reach the arrow, if you now manually unfold test_b it will be re-folded if you search again
Same happens (might be considered undesirable by some) if you search, stop in a folded region, move the cursor somewhere, and search again, I would expect it to only fold again if you search immediately, not if you do something else in the editor

MO removing the memorized temporary line only when you actually edit the text is a good behavior, I'd personally prefer it like that (I frequently randomly move my caret with arrow keys for example).
The first quirk is definitely uncool, I don't get why it happens but I'll look into it

That's fair, though I think the specific behaviour with changing selection/moving caret should be discussed

My idea seems faulty, is_in_comment() and is_in_string() doesn't seem to work at all the way I'd expected.

I don't really know how to detect the caret moving without false-detecting when it moves because I moved to the previous/next search result.


The function inside the closure will be renamed

Describe the bug
The internal function will be renamed if its name is same to the external function.
This seems related to the compiler because it won't happen when vite is working with pure javascript.
function myFunc() {
  return function myFunc() {};
}

// expect the function name to be 'myFunc', but the actual name is 'myFunc2'
console.log(myFunc().name);

Can be reproduced with:

Combination
Link

vite + typescript
https://stackblitz.com/edit/vitejs-vite-7fmv91?file=src/main.ts

vite + react
https://stackblitz.com/edit/vitejs-vite-w9neds?file=src/App.jsx

vite + typescript + react
https://stackblitz.com/edit/vitejs-vite-bdguti?file=src/App.tsx

Cannot be reproduced with:

Combination
Link

vite + javascript
https://stackblitz.com/edit/vitejs-vite-7rhr1u?file=main.js

pure typescript
https://stackblitz.com/edit/typescript-v3lbde?file=index.ts

create-react-app + javascript
None

create-react-app + typescript
None

Reproduction
https://stackblitz.com/edit/vitejs-vite-7fmv91?file=src/main.ts
Steps to reproduce

npm install
npm run dev

System Info
System:
  OS: Linux 5.0 undefined
  CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Memory: 0 Bytes / 0 Bytes
  Shell: 1.0 - /bin/jsh

Binaries:
  Node: 16.14.2 - /usr/local/bin/node
  Yarn: 1.22.19 - /usr/local/bin/yarn
  npm: 7.17.0 - /usr/local/bin/npm

npmPackages:
  vite: ^3.2.4 => 3.2.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Ah, I see. Go to know that the function name will be changed by esbuild.
I try to add esbuild.keepNames in vite.config.js, but it doesn't work. Is something missing?
Not work

Combination
Link

vite + typescript
https://stackblitz.com/edit/vitejs-vite-7fmv91?file=vite.config.js

vite + react
https://stackblitz.com/edit/vitejs-vite-w9neds?file=vite.config.js

vite + typescript + react
https://stackblitz.com/edit/vitejs-vite-bdguti?file=vite.config.ts

Can work
It can work if I use Object.defineProperty without adding esbuild.keepNames in vite.config.js. However, I prefer the solution to config esbuild so that I don't need to refactor the huge code base.
function myFunc() {
  function myFunc() {}
  Object.defineProperty(myFunc, 'name', { value: 'myFunc' });
  return myFunc;
}

You are right. esbuild keepNames option are still set to false by Vite though it is presented in user config.
There is an early issue(#9164). It discovered the keepNames breaks the tree-shaking.

Got it. I think it would be better to update the document to mention some of the esbuild configs are disabled.
https://vitejs.dev/config/shared-options.html#esbuild
Does Vite has a plan to bring keepNames back in the future? I would like to keep tracking this if there is a relevant issue.

+1 on this, vite renames a function in my app, breaking my feature completely. Is there an eta on when this will be re enabled?


Queries on relation fields with multiple ins do not work correctly.

For implementation related questions or technical support, please refer to the Stack Overflow and Server Fault communities.
Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

[x] You've met the prerequisites.

[x] You're running the latest version of Parse Server.

[x] You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Steps to reproduce

See "queries on relation fields with multiple ins" case in ParseRelation.spec.js

The expected number of results must be zero not two. The case is incorrect.

it("queries on relation fields with multiple ins", (done) => {
    var ChildObject = Parse.Object.extend("ChildObject");
    var childObjects = [];
    for (var i = 0; i < 10; i++) {
      childObjects.push(new ChildObject({x: i}));
    }

    Parse.Object.saveAll(childObjects).then(() => {
      var ParentObject = Parse.Object.extend("ParentObject");
      var parent = new ParentObject();
      parent.set("x", 4);
      var relation = parent.relation("child");
      relation.add(childObjects[0]);
      relation.add(childObjects[1]);
      relation.add(childObjects[2]);
      var parent2 = new ParentObject();
      parent2.set("x", 3);
      var relation2 = parent2.relation("child");
      relation2.add(childObjects[4]);
      relation2.add(childObjects[5]);
      relation2.add(childObjects[6]);

      var otherChild2 = parent2.relation("otherChild");
      otherChild2.add(childObjects[0]);
      otherChild2.add(childObjects[1]);
      otherChild2.add(childObjects[2]);

      var parents = [];
      parents.push(parent);
      parents.push(parent2);
      return Parse.Object.saveAll(parents);
    }).then(() => {
      var query = new Parse.Query(ParentObject);
      var objects = [];
      objects.push(childObjects[0]);
      query.containedIn("child", objects);
      query.containedIn("otherChild", [childObjects[0]]);
      return query.find();
    }).then((list) => {
      equal(list.length, 2, "There should be 2 results");
      done();
    });
  });

Logs/Trace

The actual REST request generated by the case
{
  "where": {
    "child": {
      "$in": [
        {
          "__type": "Pointer",
          "className": "ChildObject",
          "objectId": "t4EmF6vnq5"
        }
      ]
    },
    "otherChild": {
      "$in": [
        {
          "__type": "Pointer",
          "className": "ChildObject",
          "objectId": "t4EmF6vnq5"
        }
      ]
    }
  },
  "_method": "GET"
}

Causes
DatabaseController.prototype.addInObjectIdsIds = function(ids, query) {
  if (typeof query.objectId == 'string') {
    // Add equality op as we are sure
    // we had a constraint on that one
    query.objectId = {'$eq': query.objectId};
  }
  query.objectId = query.objectId || {};
  let queryIn =  [].concat(query.objectId['$in'] || [], ids || []);
  // make a set and spread to remove duplicates
  // replace the $in operator as other constraints
  // may be set
  query.objectId['$in'] = [...new Set(queryIn)];

  return query;
}

multiple $ins on different relation fields end up having a merged $in on objectId
{
  "child": {
    "$in": [
      "pointer to child0"
    ]
  },
  "otherChild": {
    "$in": [
      "pointer to child0"
    ]
  }
}

becomes
{
  "objectId": {
    "$in": [
      "objectId of parent",
      "objectId of parent2"
    ]
  }
}

It is supposed to be like
{
  "$and": [
    {
      "objectId": {
        "$in": [
          "objectId of parent"
        ]
      }
    },
    {
      "objectId": {
        "$in": [
          "objectId of parent2"
        ]
      }
    }
  ]
}

I've managed to reproduce this and am working on a fix.

PS: thanks a lot for the extremely detailed bug report. I'm going to start pointing to this as a "perfect" bug report.


Add helper message for zenml up --blocking login

Over on #2213 at https://github.com/zenml-io/zenml/issues/2213#issuecomment-1892549278 it was raised that there's no message about what username and password to use when running zenml up --blocking. This would apply to Windows users mainly, so this PR outputs such a message.

@coderabbitai review


Working prototype of TiledWriter-based data access

TODOs:

[x] fix data types (int32 vs. float64)
[x] testing with real hardware

This PR was tested and the changes work as expected.


Snippet RDFa linking

Overview
Adds a new sample page which is set up for editing snippets. The main addition here is to enable hasResourceImports on the doc node of the editor schema.
This is a draft as there are a few issues to work out, which will be listed in the how to test section.
connected issues and PRs:
Requires linking to (and includes in the package.json) https://github.com/lblod/ember-rdfa-editor/pull/1212 which adds most of the capabilities used.
Can be linked to https://github.com/lblod/ember-rdfa-editor/pull/1213 to try out creating links to imported resources instead of just from them.
Used by https://github.com/lblod/frontend-reglementaire-bijlage/pull/263
Jira ticket: GN-4898
Setup
Needs some hacking to get a snippet with the required imported resources specs into the insert list.
How to test/reproduce
There are 3 steps to this:

Create a snippet with imported resources:

Go to the snippet edit sample page
Insert the snippetTemplate template, this contains the attribute on the doc node that imports some resources to the editor
Create arbitrary RDFa in the editor
Click on the 'document' node (so click on the page outside of the content), and verify that the RDFa tools give the type 'document'
Open the 'Add Relationship' modal, create a link as normal, except also specify the subject. For the first imported resource you'll need to enter the placeholder URI into the power-select 'search' and hit enter, this will set the field to this new value. Later you can select an existing import or create a new one in the same way.
If testing the experimental editor branch, select a resource in the editor and click 'add relationship'. Select the type as 'NamedNode' and manually type the imported resource URI.
export the HTML from the editor as you'll need it later.

Create a template containing a snippet placeholder:

Go to the regulatory statements sample page
Insert a snippet placeholder (for now any snippet list selected will have the imported resources added that match those in the sample template)
Select the placeholder and see that the RDFa relationship editor has a new section listing the imported resources. You can click on the + to choose the 'real' resource URI that it links to in the document.

Create a real document from a template with a snippet placeholder:

Select the placeholder and click 'insert snippet' from the sidebar
Unfortunately to get a snippet with the right imported resources, you'll need to override the snippet-plugin utils fetch-data function fetchSnippets to return the html you created in 1.
You should see the snippet contents now and if you click within the snippet, the RDFa tools should show the correct links to the outer document.
You can also add more snippets using the new tooling, these should also be linked.

Known issues:

~Links from the outer document to the snippet are not set up, the page needs to be refreshed before they're wired up correctly.~
~Still some hacks in place.~
Tools are not pretty or easy to see the required data.
When editing a link from an imported resource, the subject isn't populated in the modal.

Challenges/uncertainties
Many.
Checks PR readiness

[ ] UI: works on smaller screen sizes
[ ] UI: feedback for any loading/error states
[ ] Check if dummy app is correctly updated
[ ] Check cancel/go-back flows
[ ] changelog
[ ] npm lint
[ ] no new deprecations

Reviewed as part of https://github.com/lblod/frontend-reglementaire-bijlage/pull/263 so merging this.


Fix conflicts in "Forward-merge branch-22.12 to branch-23.02" [skip gpuci]

xref: https://github.com/rapidsai/cucim/pull/467

LGTM

Thank you both! 🙏


Remove unused "multiprocess" argument from parallel_map.

I suspect that if threading isn't enough for parallelism, we are going to need a code structure change to support it. I verified all references to parallel_map pass 3 arguments.

What's the problem with using multiprocessing?  In my experience, it was faster than using threads.

No problem specifically, it's just that 0 callers actually using this functionality today.
IMO we should only keep this option if we believe some but not all callers of parallel_map want multiprocess, and those callers will need it in the next 6 months. If not, deleting until that use case arises makes the code simpler to follow. Alternatively, if we believe all callers would be better with multiprocess, we can switch to only having that option.

Yeah, that's fine.


I'd like to use project name as initial value of repository name

like this:

I see, this make sense.
Maybe you can make a PR for this if you want.


message_feed_display: Change /todo and /poll widget styles to make them consistent

This PR solves #20283
Testing plan:

./tools/lint
./tools/test

GIFs or screenshots:
/todo widget
Light theme:

Dark theme:

/poll widget
Light theme:

Dark theme:

@timabbott Can you review this? the tests are passing on my local repo, the changes made are same as the previous PR #20999
This time with commit messages for each change as you mentioned

@timabbott The puppeteer test error is probably solved and the PR is up for review

@Arch0125 thanks for working on this!  First, please learn how to update an existing GitHub pull request; there's no need to make a new PR every time you edit something, and it makes it hard to follow reviews :).  Check out our GitHub guide and commit guidelines for more details.

The commits here are really messy, but that can be fixed later, what's concerning is that this still doesn't address https://github.com/zulip/zulip/pull/20535#issuecomment-1011942283... (none of these did, I believe).
Here are the two comments there:

A lot of the rules between label.checkbox and label.checkbox_todo are duplicate, so can we just apply checkbox and just override the rules we want to change with checkbox_todo?

let's not add the additional border
can you explain why we need to add the additional border to .add-task-button?

The previous commits use overriding using IDs but as suggested those were removed and separate checkbox class was made under .todo-widget

It isn't valid HTML to use IDs for elements that appear more than once in the DOM. A CSS class is appropriate, but as you see we already have one -- so you should be able to just scope your CSS properly as e.g. .todo_widget .checkbox without adding this.

Im not getting what border you are talking about int .add-task-button , they are made exactly similar to the Save buttons in message edit ui

@Arch0125 can you rebase this?

Sure! I will resolve the conflicts and rebase

@timabbott I've updated the PR and it's up for review

@Arch0125 can you clean up the commit history? It seems like most of the commits here are fixups to problems introduced earlier in the commit series. Possibly the right answer is to squash your commit series.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html

@Arch0125 do you plan to continue working on this PR, or should we have someone else take it over to get it merged? Thanks!

@Arch0125 do you plan to continue working on this PR, or should we have someone else take it over to get it merged? Thanks!

I think it would be great if someone else takes up the work from here

I'll take this up!

I'll take this up!

Please go through previous commit/changes and reviews so that you don't have to work over it again


Chore: Signed payload support for aws

This PR is to add support for Signed Payload when signing with AWS. this is my first rust PR, lmk  if I'm doing something wrong.
close https://github.com/Xuanwo/reqsign/issues/10

@Xuanwo PTAL


blank edit forms fields

When editing fields, fields should be pre-filled with values for editing, an empty form always appears here. Perhaps in the partial view
@include('components.form.text', [         'field' => 'last_name' | 'object.name',         'label' => __(file.key) (default: __("general.$field"))         'required' => 'required' (default: '')         'icon' => 'envelop' (default: no icon displayed),         'readonly' (default: none)     ]),
an option should be added with passing value values

@WitekS,
sorry, there was a bug in the partial view: it has been fixed in the last commit.
Can you try again and send me feedback?
Thank you.

I solved this by adding value in components.form.text
value="{{ !empty($value) && empty(old($field)) ?  $value : old($field)}}"
and in the call, e.g.
@include('components.form.text', ['field' => 'name', 'icon' => 'user', 'label' => 'general.name', 'value'=> $user->name])

Yes, your solution works as well.
I used LaravelCollective package to generate input fields, and LaravelCollective has an old() function in vendor/laravelcollective/html/src/FormBuilder.php that is different from the old() function in Laravel.
Calling old($field) outside of LaravelCollective context don't get the required values.
Thank you for reporting this.


Support custom workQueue in FoundationStream

Resolves #551

Thanks for the PR! Based on the issue reported in #551, I don't think that is the direct source of the problem. I've used multiple sockets with the same work queue without issue, but there could be something specific to your use case. Do you happen to be pushing a lot of data on each socket (reading or writing)? I'm curious if maybe there is just a lot events getting added to the queue and thus causing issues.
I'm not against this change, I just want to make sure we are making it for the right reasons. Thanks again!

@daltoniam It only happens when one of them is connecting, everything works after both are connected.

@daltoniam I've just faced the same issue and I fixed in a similar way @akiroz did before seeing this thread.
In my case, I try to connect 3 sockets at the same time and one of them is returning a timeout after 5 seconds. During that time, the rest of the sockets can't connect properly.
On the disconnect callback from the failing socket, I have a retry mechanism that tries to connect after 5 seconds. Each time it tries to connect, is blocking the R/W operations from the other 2 sockets during the timeout period.
In my solution I create a sharedRWQueue that is the one used in CFReadStreamSetDispatchQueue and CFWriteStreamSetDispatchQueue
@daltoniam any chance you could check this again please?

@akiroz could you please check the merge conflicts? Thanks!

@fassko Just rebased on master, all tests passing on Xcode 10.1

@akiroz I think now there is code missing where this queue is going to be used.

Do you mean outside of this class with the same label as com.vluxe.starscream.websocket?

The codebase has actually under gone a major refactor and completely changed how we handle our work queues. Feel free to check it out here #653. Feedback welcomed.


[usecase-cordova][XWALK-1855] Update one usecase for Crosswalk WebView Plugin

Impacted tests(approved): new 0, update 1, delete 1
Unit test platform: [Android]
Unit test result summary: pass 1, fail 0, block 0

LGTM


Outsourced Distributed Computation

Port rabit.get_rank()
Enables outsourced distributed computation

Outsourced distributed computation will perform training on an enclave cluster over some training data, then save the trained model. In practice the trained model could be saved to a shared file storage between the client and the enclave cluster.

Forgot to mention this in the PR description:
Here the client actually attests all enclaves individually, though the rabit init also performs inter-enclave attestation after the client attests all enclaves. The client must attest all enclaves because the current add_client_key function that is called on every enclave requires each enclave's public key (we encrypt the symmetric key used to encrypt the data with each enclave's public key, then send the encrypted symmetric key to each enclave).
Maybe in the future we can think of a design such that the client doesn't need to attest all enclaves individually, which would presumably require some kind of shared key among all enclaves. Haven't thought much about the security implications of this though.

Is there a way for the client to only attest and call add_client_key for the master? That would be ideal. The enclave counterpart of add_client_key would then call sync_client_key internally, which would broadcast the key to all the enclaves in the cluster. This is safe because rabit_init makes each enclave attest its neighbors and also creates TLS channels between enclaves (so the key broadcast would be encrypted).

Thanks!


Detect an unsupported root filesystem

Handle the server returning an "unsupported_guest" encryption state.
Sample output:
...
14:38:11 Waiting for encryption service on i-82ebd859 at <IP_ADDRESS>
14:38:50 Creating encrypted root drive.
14:39:00 Terminating encryptor instance i-82ebd859
14:39:00 Waiting for instances to terminate.
14:39:57 Deleting orphaned volume vol-1b32e2fd
14:39:58 Deleting orphaned volume vol-1832e2fe
14:39:58 Deleting orphaned volume vol-f333e315
14:39:58 Deleting orphaned volume vol-8833e36e
14:39:58 Deleting temporary security group sg-8fccb9eb
14:39:58 Deleting snapshot copy of original root volume snap-ec370fae
14:39:58 The specified AMI uses an unsupported operating system
Change-Id: Icecd357f621f08fbc0304e6934018af30f88f843

Closing, will reopen with a new commit.


Node support

RequestException: ReferenceError: XMLHttpRequest is not defined
It looks like this library doesn't support use in node, would be nice to support it.

Hello, thanks for this feedback. This is something we can work on. As a temporary solution, you can embed XMLHttpRequest on Node side, like done here : https://framagit.org/Pic4Carto/Pic4Review/-/blob/master/webpack.config.js#L57

Thanks for the tip! For now I decided to directly call the API rather than using this library.

Kind of a late hacky answer, but this worked for me:

yarn add w3c-xmlhttprequest
Insert this line before importing osm-request:

global.XMLHttpRequest = require("w3c-xmlhttprequest").XMLHttpRequest;


rename AWS EC2 Container Registry

https://aws.amazon.com/jp/ecr/
The correct name is Amazon Elastic Container Registry.

/check-cla

/assign @stewart-yu

Renamed on 2017-11-21
The change in name will break fragment identifiers; that's OK.
/lgtm

/approve


Add an example when actual object you want to deserialize is wrapped in non essential layers

I had hard time deserializing the list of objects wrapped in several non-essential layers. I couldn't understand why I was getting JsonException with "read too much, or not enough" message (more details here).
I finally got an explanation on Stackoverflow, but I believe the requirement "When reading an object, JsonConverter.Read() must leave the Utf8JsonReader positioned on the EndObject token of the object where it was originally positioned." should be added to this page to help other developers, when they face similar issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5de37d79-751f-e372-e866-efde28f4908c
Version Independent ID: 678c4f23-764a-7ccd-0d6d-159a30957477
Content: How to write custom converters for JSON serialization - .NET
Content Source: docs/standard/serialization/system-text-json-converters-how-to.md
Product: dotnet
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Thanks for the suggestion, I'm adding this to our backlog.


Bug with disallowSpacesInsideParentheses

I have disallowSpacesInsideParentheses set to true and I'm getting this error:
Illegal space after opening round bracket at filename.js :
     6 |export default function startApp(attrs) {
-----------------------------------------^

I've even remove all other rules to confirm there wasn't anything conflicting. Thoughts?

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Upon further inspection, this is only the case when esnext: true.

@elidupuis Definitely it is only about esnext. Feels like there are a lot of bugs in es6 parsing logic. ;-(

this is export default specifically. Removing default "fixes" the bug (but will break your single function module).
Minimal test case:
export default function() {

}

$ jscs --esnext -c js/.jscsrc js/foo.js
Illegal space after opening round bracket at js/foo.js :
 1 |export default function() {
   --------------------------------^
 2 |
 3 |}

1 code style error found.

I have a patch https://github.com/jscs-dev/node-jscs/pull/990 but also files bug with esprima: https://code.google.com/p/esprima/issues/detail?id=631


Tests improvement

I did not add unit tests but I've encountered 2 problems during my code testing.

A field is not updated after setting it to null

$blogs = new \Maphper\Maphper($blogSource);
$blog = $blogs[1];
$blog->title = null;
$blogs[1] = $blog;

title is not modified.

The table type is not changed

$blogs = new \Maphper\Maphper($blogSource);
$blog->value = 10;
$blogs[] = $blog;

value type is integer
$blogs = new \Maphper\Maphper($blogSource);
$blog->value = 'ten';
$blogs[] = $blog;

value type is integer but value is 'ten'
(I guess this last behavior is specific to sqlite, but just in case you want to add more tests)

thanks, I've fixed the issue with inserting NULL values and added tests for changing column type.
Looking at SqliteAdapte, does SQLite support INSERT...SELECT? It may make the alterDatabase method a little simpler?
If so, instead of
$results = $this->pdo->query('SELECT * FROM '.$table);

which in a large db may be very inefficient (i don't know how PDO works internally, it may be fine but either way it would be tidier code if we can...)
can this entire block be replaced with:
$this->pdo->query('INSERT INTO ' . $this->quote($table . $affix) .' SELECT * FROM ' . $this->quote($table))?

I don't know exactly for the INSERT...SELECT but from the doc I think it's possible: https://www.sqlite.org/lang_insert.html
I will have a try tomorrow I did not think about that better option.

I think, it's ok
https://github.com/TomBZombie/Maphper/pull/18


Various improvements

Tests are failing as a result of the OEDB SSL connection:
SSLError: HTTPSConnectionPool(host='openenergy-platform.org', port=443): Max retries exceeded with url: /api/v0/schema/supply/tables/wind_turbine_library/rows (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)')))
Investigating.


Get by index in array or string should be nullable.

Reproduce:
const char: string = ''[0];
const number: number = [][0];

It's known. Flow do not check lengths of arrays and strings, since having conditions for everything can reduce performance. Also in a lot of times length is not predictable.

Maybe you can introduce settings for this behaviour?

Probably lint rule.

Closing, this has been discussed many times over the years.


[Feature] Get contents of deleted file

Is this feature missing in the latest version?

[X] I'm using the latest release

Is your feature request related to a problem? Please describe.
Basically I'm using this action to get all the files that were changed/created and run terragrun on top of each one. My problem today is that for me to destroy a resource in terragrunt, I need the file. What I would like is to take the file that was deleted, keep it until the end of the workflow execution and delete it, so that the resources can be deleted.
Describe the solution you'd like?
It would be something like:
  - name: Run changed-files with dir_names
    id: changed-files-dir-names
    uses: tj-actions/changed-files@v35
    with:
      dir_names: "true"
      content_file_tmp: "true"
      files: |
        terraform/mongodb-atlas/clusters/**

  - name: Terragrunt Destroy
    id: destroy
    run: |
      for folder in ${{ steps.changed-files-dir-names.outputs. file_tmp }}; do
        terragrunt destroy -auto-approve --terragrunt-working-dir $folder
      done

Describe alternatives you've considered?
I couldn't think of many things at the moment.
In summary, I would like to run my destroy on the file before it is deleted or get the state prior to deletion, mount it and run. then discard it.
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@SamuelMolling does the file need to still be located in the working tree or can it reside in a temp directory?

The file needs to reside in the directory, on account of the state file, located in a bucket in the google cloud

Also, I would like to know if it is possible to run on all modified files excluding one.

To solve the problem, I made an if, like this.
      for folder in ${{ steps.changed-files-dir-names.outputs.all_changed_files }}; do
        if [ -f $folder/cluster.hcl ]
        then
          echo "cluster.hcl found"
        else
          terragrunt init --terragrunt-working-dir $folder
        fi
      done

Given the complexity of reverting the state of the repository in order support this feature, I’ll recommend your workflow destroys the resource via inputs if necessary and deletes the related folder prior to committing the changes.

@jackton1 Do you have an idea how to do it? I'm not sure how I would do it. Would you have to open 2 prs there? One to destroy and another to delete the files, right?

@jackton1 It is not possible to recover the value of the deleted file in PR and create it temporarily in the container and then remove it, I believe it is not so complicated to get this value, there is a load diff, basically it would be to get the value before it for deleted files .

Se tiver como recuperar o valor do arquivo deletado, eu consigo fazer a lógica localmente para criação e depois deletar o mesmo.

Could this help? https://github.com/marketplace/actions/get-diff-action


Fix null pointer issue on Switch in NavigationFragment

There was a crash in Navigation Fragment for switch drawable.
I was unable to reproduce this issue but have tried to fix it logically.
@nasthagiri , @rohan-dhamal-clarice - Please review
JIRA: https://openedx.atlassian.net/browse/MOB-1350

:+1:


is there a possibility to set one of the header as a image?

is there a possibility to set one of the header as a image?

Hi ArunPandiyan,
yes of cause this is possible ;) You can do so by writing your own TableHeaderAdapter. Here is an example for a CustomTableHeaderAdapter that shows an ImageView in the first column, a CustomView in the second column and a TextView in all other columns.
public final class SimpleTableHeaderAdapter extends TableHeaderAdapter {

    @Override
    public View getHeaderView(final int columnIndex, final ViewGroup parentView) {
        switch( columnIndex ) {
            case 0: return new ImageView(getContext());
            case 1: return new MyFancyView(getContext());
            default: return new TextView(getContext());
        }
    }

}

As you see you can use the getContext() method of the TableHeaderAdapter to initiate new Views. (In this example all views are empty, but you can fill them like you need it.)
When you have created your custom TableHeaderAdapter you can set this to your TableView (or SortableTableView).
    tableView.setHeaderAdapter( new CustomTableHeaderAdapter( context ) );

Thanks ISchwarz23, for a quick response. I was implementing custom tableheader as you did in the example, but

tableView.setHeaderAdapter( new CustomTableHeaderAdapter( context ) );

i missed to add the above line to the tableview.


remove non-wpa targets and update README

I'm abandoning hybrid apps and focusing on pwa apps (where it makes sense, like in this calculator). It needs some cleanup and simplification.

Fixed in 8148242a4dff7be5c4eada30998247485d48fdf4


Use sync.Mutex to lock the conntrack cache when getting the elements

Resolve #118

| |
聂剑刚
|
|
@.***
|
签名由网易邮箱大师定制
On 03/17/2022 16:14，Daxin @.***> wrote：
Resolve#118
You can view, comment on, or merge this pull request online at:
https://github.com/Kindling-project/kindling/pull/120
Commit Summary
c7bd0e3 Use sync.Mutex to lock the conntrack cache when getting the elements
File Changes
(2 files)
Mcollector/metadata/conntracker/conntracker.go (8)
Mcollector/metadata/conntracker/conntracker_cache.go (18)
Patch Links:
https://github.com/Kindling-project/kindling/pull/120.patch
https://github.com/Kindling-project/kindling/pull/120.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because your review was requested.Message ID: @.***>


New release successor to 0.2.2 to reflect updates in master?

Is there a plan to update the add-on repo with a new release to reflect the changes in master branch? (I am interested in getting rid of 30 seconds  status of wg tunnel, which seems to be handled in master branch via log level variable.)

Hi @archont00 try with the brand new release v0.2.3 👍


Create on-click event to show recipe instructions

Seems like no others things for me to add. Looks quite good.


New release please

Hi @svanharmelen, could you create a new release tag please?
How would you feel about automating the tag creation either on every new change on main or on a schedule (if there have been changes)?

I prefer to create a release manually for the time being. There are a couple of open PR's that I want to get merged first, after that I will create a new release again.

Released a version yesterday...


[HELP ASAP] Accidentally sent to mint address

Can I retrieve my money if I accidentally sent it to a token mint address? (Transferred from FTS and accidentally sent it to Samo token mint address instead of Solana address)

Unfortunately there's nothing that can be done in this case, unless someone has the Samo mint private key. This isn't sollet related, so closing.


added section for reflection libs

I added a new section called "Reflection" for libraries which enable reflection in C++.

i've submitted a pull request with 2 reflection libs :
https://github.com/fffaraz/awesome-cpp/pull/248

Fixed in 5ce0f1a423134e683a776179301b1c6ed376e9ad. Thanks for the addition and sorry for the delay!


Unable to publish OpenStreetMaps apk to google play store

[x] Your app currently targets API level 29 and must target at least API level 30 to ensure it is built on the latest APIs optimized for security and performance. Change your app's target API level to at least 30. Learn More

[x] Your APK or Android App Bundle is using permissions that require a privacy policy: (android.permission.READ_PHONE_STATE). Learn More

[x] Your APK or Android App Bundle needs to have the package name org.osmdroid.

API level 30 shouldn't be a problem (spoiler alert: that's the typical start of a long week-end of nervous breakdowns trying to build)
"android.permission.READ_PHONE_STATE": I'm a bit surprised - any idea where we need it?
"Your APK or Android App Bundle needs to have the package name org.osmdroid.": isn't that the case, at least in the code? Something strange in the settings then?

i think the last part is my fault, probably something with the build tech update. i'll look at that
not sure where read phone state came from, maybe it was something to detect wifi networks vs cell?

i just tried moving to target sdk 32 and got the following
[com.android.support:animated-vector-drawable:28.0.0] C:\Users\Dad\.gradle\caches\transforms-3\626013b64f292d0ce7646a7fee424c0d\transformed\animated-vector-drawable-28.0.0\AndroidManifest.xml Warning:
        Package name 'android.support.graphics.drawable' used in: com.android.support:animated-vector-drawable:28.0.0, com.android.support:support-vector-drawable:28.0.0.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:107:9-118:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.intro.IntroActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:119:9-128:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.MainActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:129:9-138:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.StarterMapActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:139:9-147:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.samples.SampleWithMinimapItemizedoverlay>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:149:9-157:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.samples.SampleWithTilesOverlay>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:158:9-166:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.samples.SampleWithTilesOverlayAndCustomTileSource>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:167:9-173:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.BugsTestingActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:175:9-181:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.debug.browser.CacheBrowserActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:182:9-188:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.debug.CacheAnalyzerActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:189:9-196:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.ExtraSamplesActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:197:9-204:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.bugtestfragments.WeathForceActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:207:9-215:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.PreferenceActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:216:9-224:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.LicenseActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:225:9-231:20 Error:
        android:exported needs to be explicitly specified for element <activity#org.osmdroid.diag.DiagnosticsActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.

the permissions thing seems to be because of...
uses-permission#android.permission.READ_PHONE_STATE
IMPLIED from C:\projects\osmdroid\OpenStreetMapViewer\src\main\AndroidManifest.xml:2:1-235:12 reason: org.osmdroid.library has a targetSdkVersion < 4
so another build tech update thing

moving to the current min was successful, but we'll have to address the other issues when going 30+

I forked this project in order to use API 31, but this happens before your #1776. I also updated the GeoPackage library in my branch. I also modified the API to include Context in the majority of the classes. https://github.com/electice/osmdroid


adds checkTable.

A little bit over engineered imho. But still nice to have it ! good job :)

I mean in a ideal world this kind of thing should be part of the test framework


AWS extra Oregon

This fixes #99. spinning up a PE infra anywhere other than us-west-2 now works.
All this does is run the terraform::apply task twice, with no refresh (whereas the code used to call terraform::apply once but with a refresh afterwards). It seems that the refresh was causing various elements of the tfstate file get nuked whereas the second apply makes one further change and gets the tfstate file where it needs to be for the resolving of references to complete successfully.
I have no idea exactly where the default region from variables.tf is being picked up in favour of the cloud_region parameter, but this PR avoids it somehow.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixing the refresh to pass --var-file is a better solution so closing this PR


Radar map

Fixes #314

Several points:

it works properly outdoor, but not for indoor maps like factory / labs.
it flickers with streets of tarkov but I think this is related to all the hacks they use for this map.
super clean for others like woods / customs.
player positions are perfect when moving the whole body, but it is a bit strange when only moving the mouse. I also spotted this without the map. Perhaps we need to finetune the location computation @solareon  ?
I spotted a NullReferenceException out of our control when the raid is ending, probably a race when the game is disposing all attached gameobjects. It does not seem super important but if we can prevent it that would be great
We can extract the "set-nice-weather" code later in a TriggerFeature, that could be useful.

Using the main camera transform instead of the player transform seems to solve everything.

I did notice that turning on the camera forces the weather and time to mid day and clear. Is that due to not being able to set the weather controller just for the radar camera?

Yes from my understanding the weather is bound to the world, not to a specific camera (because they never had the need to use several cameras).

The original post makes reference to a cullingMask to get it to work on factory/labs. I saw that the camera object has it but unsure what value it is looking for to make it work.

Yes that's just an int, we can try several values. Probably a power of two when using several layer at a time.
Perhaps a map level in factory has its own value.

Found way to prevent exceptions when exiting raid.


feat(react-server): generate mapping of server route to client assets

related https://github.com/hi-ogawa/vite-plugins/pull/257

Looking back https://github.com/hi-ogawa/vite-plugins/pull/257, the manifest manipulation looks to complicated, so I'm trying a new approach here.
todo

build time

[x] use transform.meta and PluginContext.getModuleInfo to map from route to client reference (during server build)
[x] map client reference id to browser asset file (during browser build)

runtime

[ ] this is probably unavoidable and just need to copy https://github.com/hi-ogawa/vite-plugins/pull/257
separate PR?

[ ] test

#331  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite

Merge activity

Jun 3, 11:09 PM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.


Auto approval config - missing default value

Max number of claims per month has no default value. Default values are added in the AutoApprovalConfig table migration.
We should consider if we can change the existing migration script, or if we should add a new one.

Same problem referenced in #150.  Can this issue be picked up in #150 or is it still worth keeping this task open?


VM can not start if VBox was reinstalled by installer

If VBox was installed on host and Installer installs it on top of it, VM can not start.

Installer should check if application (Chrome, VBox) is already installed and if yes - not install it, for any version

Cause of that problem is VBox installed on top of previously installed version. Fixed - will check if application installed already and if so - will not install.


Experiment with better compression for on-disk batches

Detailed Description
For example, pbzip2 reduces our NWP batches to 20% of their original size.  Hopefully we can achieve similar reductions using "proper" NetCDF compression algorithms.
Smaller batches should be faster to load; and easier to upload to public cloud / Lancium / etc.
Related issues

#61
#280
#498

Also, if we do find better compression, then we should probably use that better compression for our intermediate zarrs, too.
Not urgent.

I remember using something like 'gzip' made the files smaller. But then it took longer to load.
http://xarray.pydata.org/en/stable/generated/xarray.Dataset.to_netcdf.html
I'm not sure on the right balance here
also just some general searching - not sure how useful this is
https://www.unidata.ucar.edu/blogs/developer/entry/netcdf_compression

I'm not sure on the right balance here

yeah, I think the only way to tell is to do a bunch of experiments

tbh I wouldn't worry about better on-disk compression for v16.  The compression we have now is fine, IMHO.


Remove ocean map trade

Problem: Experimental feature has never been removed.
Possible solution: Remove ocean map code, because it doesn't work.
Image:

deleted


Getting error - "sqlite3.OperationalError: database is locked"

Hi,
I am executing command:
sudo python3 run_start.py /home/pi/picframe/picframe_data/config/configuration.yaml
I get this output:
pi@raspberrypi:~/picframe/picframe_data $ sudo python3 run_start.py /home/pi/pic                                           frame/picframe_data/config/configuration.yaml
INFO:start.py:starting ['run_start.py', '/home/pi/picframe/picframe_data/config/                                           configuration.yaml']
INFO:model.Model:Open config file: /home/pi/picframe/picframe_data/config/config                                           uration.yaml:
Traceback (most recent call last):
File "run_start.py", line 2, in
start.main()
File "/home/pi/picframe/picframe/start.py", line 130, in main
m = model.Model(args.configfile)
File "/home/pi/picframe/picframe/model.py", line 177, in init
model_config['portrait_pairs'])
File "/home/pi/picframe/picframe/image_cache.py", line 41, in init
self.__update_schema(3)
File "/home/pi/picframe/picframe/image_cache.py", line 318, in __update_schema
self.__db.execute("DROP VIEW all_data")
sqlite3.OperationalError: database is locked
What does it mean by "database is locked"?
Thank you,

UPDATE: I was able to execute the command once, and I have that blue screen with "No Pictures Selected" text on it.  But, I do not know how to close out of that running instance of the program.  I tried Ctrl+C, Ctrl+Z.  Maybe, this is why the database is locked, because another instance is using it?  How do I stop the other instance?
Thank you,

UPDATE 2: I was able to type "exit" in the terminal and get back to the desktop, but now when I use the same command from the original post, I get this output and error:
pi@raspberrypi:~/picframe/picframe_data $ sudo python3 run_start.py /home/pi/picframe/picframe_data/config/configuration.yaml
INFO:start.py:starting ['run_start.py', '/home/pi/picframe/picframe_data/config/configuration.yaml']
INFO:model.Model:Open config file: /home/pi/picframe/picframe_data/config/configuration.yaml:
Traceback (most recent call last):
File "run_start.py", line 2, in
start.main()
File "/home/pi/picframe/picframe/start.py", line 130, in main
m = model.Model(args.configfile)
File "/home/pi/picframe/picframe/model.py", line 177, in init
model_config['portrait_pairs'])
File "/home/pi/picframe/picframe/image_cache.py", line 41, in init
self.__update_schema(3)
File "/home/pi/picframe/picframe/image_cache.py", line 319, in __update_schema
self.__db.execute("ALTER TABLE folder ADD COLUMN missing INTEGER DEFAULT 0 NOT NULL")
sqlite3.OperationalError: duplicate column name: missing

Hi @Ascendin81. I would propose you stop picframe and delete the database (~/picframe_data/data/pictureframe.db3). If you restart picframe the database will be recreated.

Yes, ok that worked.  I got the blue screen again with the coffee cup.  How do I exit it correctly? :)  so the database does not get corrupted again.
Thanks!

If you enable the http interface, there is a stop button. Or run picframe as a systemd service https://github.com/helgeerbe/picframe/wiki/Running As Service

There is a pending pull request for mouse, touchscreen and keyboard. So chances are good, that keyboard will work in near future.

self.__db.execute("ALTER TABLE folder ADD COLUMN missing INTEGER DEFAULT 0 NOT NULL")

Related, the cause of the above error has been fixed in dev also. It's caused by the following situation:

picframe is started for the first time (so, no database exists)

The initial db is created and upgraded to the current schema (but not committed, this is the bug that has been fixed in dev)

Something (anything) goes wrong later in the execution (prior to any images being loaded) that causes a crash

From this point on, when picframe is restarted, you'll get the mentioned error. Without the bug fix, the best way around it is to remove the database file.

Well I guess it's time to make a new release.

Ah, thank you guys, everything is working great now.  I love it!

Well I guess it's time to make a new release.

@helgeerbe - how soon are you cutting a new release? I still have some WIP changes here to address some of the things discussed in https://github.com/helgeerbe/picframe/issues/203, but they're not quite ready. I might be able to get them ready this weekend if it matters, but they're not critical and probably don't need to hold up your plans. Let me know.

@jgodfrey I'm not in a rush. Just tell me when you are done.


Problem assigning static IP addresses

Tectonic Version
Latest
Environment
VMWare with Bare Metal Config

Provisioner, already configured and running.

Expected Behavior
Nodes get some static IP address
Actual Behavior
Hi,
I followed the tutorial and I can run the installer and when the servers are booting they are doing some things, but never complete. So I checked everything and I realized that I have an issue with the IP addresses.
My plan is to have 2 nodes at the beginning:
controller => xx.xx.xx.222
worker01 => xx.xx.xx.223
I have DNS entries for controller, worker01 and workers which point to the correct IP addresses. To give them the correct IP address I made a reservation in the DHCP server. It works at the beginning, but when the server restarts they get a total new IP address. In the DHCP server I see very long IDs, e.g. 3139322e3136382e36382e31383300 for worker01 and I have no idea where this ID is coming from or how it is generated. I have no Idea how to assign a static IP address to my nodes.
Feature Request
Configure IP Addresses in Installer

Ok, my understanding is that the long ID is the ClientIdentifier. Can I configure the system to use the mac address instead?

Can you share more about the dhcp configuration? You should be able to rely on a Mac address to IP configuration. Here is an example that works well for me.
https://gist.github.com/coresolve/46b629b8f85220d4de5500b8e0a3e4b3

It is a DHCP server and I cannot configure him to just use the Mac Address, he always uses the Client Identifier. Therefore I also see 2 entries after the reboot:

BOOTP = (Mac => IP)
DHCP = (Client Identifier => IP)

Can I configure systemd in the provisioner for new nodes?

DHCP is configured to use machine id as client identifier when requesting ip, but it isn't the case for first boot.
I solved this issue by adding this config (that will force using mac based identifier for all interfaces)
networkd:
 units:
   - name: 10-dhcp.network
     contents: |
       [Match]
       Name=en*
       [Network]
       DHCP=yes
       [DHCP]
       UseMTU=true
       UseDomains=true
       ClientIdentifier=mac

to files: /var/lib/matchbox/ignition/tectonic-controller.yaml.tmpl and /var/lib/matchbox/ignition/tectonic-worker.yaml.tmpl

Awesome, this sounds good :)

Tested it, does not work for me. I still see the long machine ids in the DHCP table.

@SebastianStehle to make it work, you have to reinstall your nodes or to place that file manually to /etc/systemd/network/

Sure, I destroyed my whole cluster. Strange...

I'm having the same problem. @Szpadel I tried your workaround: After reinstalling my nodes that file did not make it onto the disk. I manually placed the file in /etc/systemd/network/ as suggested and rebooted the node. It's still picking an address that is not the address I reserved for the node. My DHCP server is a Microsoft DHCP Server running 2012R2 which I cannot change in my environment, I cannot use the long ID when manually creating a reservation.

Modern DHCP servers should all have the ability to map requests from a MAC address to a configured IP address. Here's the Matchbox example dnsmasq configuration which maps known MAC addresses to IPs and DNS names to those IPs. https://github.com/coreos/matchbox/blob/master/contrib/dnsmasq/docker0.conf#L6
You should not need to make any changes to the default networkd units.


Can we change devServer setting to https ?

As title described,
I tried adding https: true in dev-env/webpack.server.js and
change every occurrence of http to https , but can't work out as expected,
(I have to let chrome explicit access to https://localhost:3001/content.js)
If I can't change that setting, then I can't let content.js works in
ex: https://facebook.com and almost most of the site.
Do we have a better solution for this, since development for most of the site that is https based
is a non-trivial thing.

Thanks for feedback,
After some digging I figured out how to do that. Commit https://github.com/schovi/webpack-chrome-extension/commit/f62a616d4461345a2ee53bbfbb92613bd54fda03
HTTPS as default is better, but I will make some config to allow change protocol, host, port and other webpack properties.

One more fix in making manifest.json https://github.com/schovi/webpack-chrome-extension/commit/57927db13c71d427f40f28b6ca2fbdd7e7008a4b#diff-d202225ac87f27a10bf4a0f7e469305aR44
setting property content_script_policy was not correct


Fix Darwin Compatibility Tests build

Broken since #2910. validPathSeps is internal to SwiftFoundation
and can't be accessed from Compatibility tests.
I think it is ok to define expected values in local scope of test.

CC @compnerd @millenomi

@swift-ci please test


Fix setting fee asset by Asset

https://github.com/Codaone/DEXBot/issues/263

Yeah you right, as fee_asset argument may be a different type, it needed to be handled properly.


tests/modular/macro fails on ddc-win-chrome

Example log:
uncaught exception: ProcessException: The system cannot find the file specified.

  Command: chmod rwxrwxrwx C:\b\s\w\ir\x\t\modular_test_res-64ad525c\2add_function.macro.exe
#0      _ProcessImpl._start (dart:io-patch/process_patch.dart:402:33)
#1      Process.start (dart:io-patch/process_patch.dart:38:20)
#2      _runNonInteractiveProcess (dart:io-patch/process_patch.dart:579:18)
#3      Process.run (dart:io-patch/process_patch.dart:49:12)
#4      IOPipeline.runStep (package:modular_test/src/io_pipeline.dart:178:23)
<asynchronous suspension>
#5      Pipeline._recursiveRun (package:modular_test/src/pipeline.dart:181:5)
<asynchronous suspension>
#6      Pipeline._recursiveRun (package:modular_test/src/pipeline.dart:153:7)
<asynchronous suspension>
#7      Pipeline.run (package:modular_test/src/pipeline.dart:140:7)
<asynchronous suspension>
#8      IOPipeline.run (package:modular_test/src/io_pipeline.dart:82:5)
<asynchronous suspension>
#9      _PipelineTest.run (package:modular_test/src/runner.dart:59:5)
<asynchronous suspension>
#10     runSuite (package:modular_test/src/generic_runner.dart:115:7)
<asynchronous suspension>
#11     runSuite (package:modular_test/src/runner.dart:29:3)
<asynchronous suspension>
#12     main (file:///C:/b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/test/modular_suite.dart:20:3)
<asynchronous suspension>

To repro run:
  C:\b\s\w\ir\cache\builder\sdk\out\ReleaseX64\dart-sdk\bin\dart.exe /C:/b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/test/modular_suite.dart --verbose --filter macro

@sigmundch had mentioned this operation might not even be necessary so I can try just removing it.

For context: https://dart-review.googlesource.com/c/sdk/+/361261/ has more details.

@fishythefish I think this is probably resolved but tbh have absolutely no clue how to confirm or deny that assumption lol. Is it possible to browse the test database at all per platform or something to see if it is passing?

Looks like it's passing, per https://dart-current-results.web.app/#/filter=tests/modular/macro&showAll, so I think we can close this issue.


harden stress test - cannot commit to miner

Flaky stress test
Overview
1) stress tests
       C-C-C-Combo breakers
         {tag:boba} 3 L2 transactions, L1 => L2 transactions, L2 => L1 transactions (txs serial, suites parallel):
     Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"id\":5475,\"error\":{\"code\":-32000,\"message\":\"Cannot commit transaction in miner\"}}\n", error={"code":-32000}, requestBody="{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0xf88a04843b9aca008301af1d9422a9b82a6c3d2bfb68f324b2e8367f346dd6f32a80a49faa1de3424242424242424242424242424242424242424242424242424242424242424282f4f8a00c380cf225fc2868117b0942540ad01d07e2e036fbf5b9e0562c521c07136b0aa03041da7524909909ff865c52eb05a66ba06b9ffb001eb2f4f0d3c100e580aaad\"],\"id\":5475,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="http://l2geth:8545", code=SERVER_ERROR, version=web/5.5.1)
      at Logger.makeError (/opt/optimism/node_modules/@ethersproject/logger/src.ts/index.ts:225:28)
      at Logger.throwError (/opt/optimism/node_modules/@ethersproject/logger/src.ts/index.ts:237:20)
      at /opt/optimism/node_modules/@ethersproject/web/src.ts/index.ts:321:28
      at step (/opt/optimism/node_modules/@ethersproject/web/lib/index.js:33:23)
      at Object.next (/opt/optimism/node_modules/@ethersproject/web/lib/index.js:14:53)
      at fulfilled (/opt/optimism/node_modules/@ethersproject/web/lib/index.js:5:58)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)

Changes

retry on stress test in case of failure

Testing
/

Codecov Report

Merging #266 (635d9be) into develop (dc4c6d9) will increase coverage by 30.49%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #266       +/-   ##
============================================
+ Coverage    47.22%   77.71%   +30.49%
============================================
  Files           99       39       -60
  Lines         3867     1324     -2543
  Branches       762      202      -560
============================================
- Hits          1826     1029      -797
+ Misses        2041      295     -1746

Flag
Coverage Δ

boba-contracts
?

contracts
77.71% <ø> (ø)

core-utils
?

data-transport-layer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../contracts/contracts/L1MultiMessageRelayerFast.sol

packages/core-utils/src/common/index.ts

packages/data-transport-layer/src/utils/common.ts

packages/core-utils/src/common/bn.ts

...contracts/contracts/standards/L2StandardERC721.sol

packages/core-utils/src/common/misc.ts

packages/core-utils/src/common/hex-strings.ts

...ices/l1-ingestion/handlers/transaction-enqueued.ts

.../l1-ingestion/handlers/sequencer-batch-appended.ts

...ages/boba/contracts/contracts/BobaFixedSavings.sol

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4c6d9...635d9be. Read the comment docs.

Cannot commit transaction in miner can be added to https://github.com/bobanetwork/boba/blob/15fcfe19e3b55cfbf10b9089a3b0a0b6e0003749/integration-tests/test/shared/stress-test-helpers.ts#L160-L167 to increase the stability too.


Fix broken cmd/cli and pkg/plugin/flavor links in documentation

Resolves #611

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "611-fix-docs" git@github.com:stealthybox/infrakit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Use Go in a more idiomatic way

This is a result of working on https://github.com/matrix-org/waterfall/issues/120 which did not quite work as expected due to some bugs and issues with Pion.
So currently it's more a preparation to properly implement a https://github.com/matrix-org/waterfall/issues/120 and to get ready for https://github.com/matrix-org/waterfall/issues/117
This PR changes the following things:

The way we work with the Go channels. It removes some helpers that we used to use in the past since they were not generic enough and their implementation would not work as expected if used as a generic channel implementation. We also use unbounded channels more than before that simplifies the backpressure between the router and the conference. The only part that is left that does not look super idiomatic is pkg/channel/sink.go (might get improved in the future).
We now use a bit more idiomatic package structure, i.e. this PR removes the usage of a common package as it seems to be an antipattern that is used to overcome Go limitations and which ends up having everything that does not belong to other packages.
Prepare for https://github.com/matrix-org/waterfall/issues/117

Note that there is one significant change in the behavior: currently, the router process the messages from the Matrix SDk and sends them to the conference via an unbounded channel. This means that if one conference freezes, it will affect all other conferences! It's not a problem for now since we only primarily use a single conference and the conferences should never freeze (so it helps to check if our implementation is sound), but ideally we probably need to get the buffer back for the conference, otherwise we won't be able to make them all independent.

I think this looks good, but this is a huge PR with a lot of unrelated changes, making it very hard to review. Moving things out of common, in particular, feels like it doesn't belong here.

Yeah, sorry, perhaps the common part should have been moved into its own PR.


Allow null input for hostname/externalIps

In external service. As these 2 params are mutually exclusive now.
W/o this fix, externalService.update will always fail in the UI.

LGTM

LGTM


Could not find com.github.adroitandroid:ChipCloud:2.2.1.

could you please kindly check if 2.2.1 has been removed?
saw 404 error while downloading https://jitpack.io/com/github/adroitandroid/ChipCloud/2.2.1/ChipCloud-2.2.1.pom

Same problem here, any update?


https://adoptium.net/docs/aqavit-verification/ give a wrong link for "test prerequisites"

Describe the bug
[A clear and concise description of what the bug is.](https://adoptium.net/docs/aqavit-verification/ give a wrong link about "test prerequisites")
To Reproduce
Steps to reproduce the behavior (or Grinder rerun link):

open web by chrome : https://adoptium.net/docs/aqavit-verification/
click the link of "test prerequisites"

Expected behavior
relink to the correct web for "test prerequisites"
https://github.com/adoptium/aqa-tests/blob/master/doc/Prerequisites.md
Actualed behavior
relink to wrong web for "test prerequisites"
https://adoptium.net/https://github.com/adoptium/aqa-tests/blob/master/doc/Prerequisites.md
Screenshots

Additional context
NA

Fixed via https://github.com/adoptium/website-v2/pull/405


Could NOT find LibXml2 (missing: LIBXML2_LIBRARY LIBXML2_INCLUDE_DIR)

When I run command make depends，I get follow error
++ echo -n '-mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 '

COMPILER_FLAGS='-mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 '
cmake -Wno-dev -B_build -GNinja -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_CXX_STANDARD=17 '' '' '-DCMAKE_CXX_FLAGS=-mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 ' -DBUILD_TESTING=OFF
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- checking compiler: GCC (9.3.)
-- Looking for dladdr
-- Looking for dladdr - not found
-- Looking for nanosleep
-- Looking for nanosleep - found
-- adding c++0x support for gcc compiler
-- Checking whether strerror_r returns an int
-- Checking whether strerror_r returns an int -- no
CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
Could NOT find LibXml2 (missing: LIBXML2_LIBRARY LIBXML2_INCLUDE_DIR)
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.16/Modules/FindLibXml2.cmake:92 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:21 (FIND_PACKAGE)

-- Configuring incomplete, errors occurred!
See also "/data1/tangyun/gluten-trino/Gluten-Trino/cpp/_deps/hawq/depends/libhdfs3/_build/CMakeFiles/CMakeOutput.log".
See also "/data1/tangyun/gluten-trino/Gluten-Trino/cpp/_deps/hawq/depends/libhdfs3/_build/CMakeFiles/CMakeError.log".
real    0m19.367s
user    0m13.873s
sys     0m2.389s
make: *** [Makefile:28: depends] Error 1
what is the problem？ need i install LibXml2 in ubuntu 20.2 by hand？

Yes, you should install libxml2 in your building environment through sudo apt-get install libxml2-dev.

Yes, you should install libxml2 in your building environment through sudo apt-get install libxml2-dev.

Thanks, after run sudo apt-get install libxml2-dev I ran make depends success
But when I ran make release, I got error:
-- Checking for module 'thrift'
--   No package 'thrift' found
-- Could NOT find Thrift (missing: THRIFT_LIB THRIFT_INCLUDE_DIR) (found version "")
CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
Could NOT find JNI (missing: JAVA_AWT_LIBRARY JAVA_INCLUDE_PATH
JAVA_INCLUDE_PATH2 JAVA_AWT_INCLUDE_PATH) (Required is at least version
"17")
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.16/Modules/FindJNI.cmake:372 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
src/CMakeLists.txt:15 (find_package)
Shold I install thrift  in ubuntu 20.2 by hand？

Yes, you should install libxml2 in your building environment through sudo apt-get install libxml2-dev.

Thanks, after run sudo apt-get install libxml2-dev I ran make depends success But when I ran make release, I got error:
-- Checking for module 'thrift' -- No package 'thrift' found -- Could NOT find Thrift (missing: THRIFT_LIB THRIFT_INCLUDE_DIR) (found version "") CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message): Could NOT find JNI (missing: JAVA_AWT_LIBRARY JAVA_INCLUDE_PATH JAVA_INCLUDE_PATH2 JAVA_AWT_INCLUDE_PATH) (Required is at least version "17") Call Stack (most recent call first): /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.16/Modules/FindJNI.cmake:372 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) src/CMakeLists.txt:15 (find_package)
Should I install thrift in ubuntu 20.2 by hand？

No, you don't need to install thrift by yourself. But it's okay if you want to install it. The root cause is that you need to install a JDK whose version should be higher than 17.


Log original request parameters before ReqMgr default values are added

We should keep a record of every POST (and PUT) ReqMgr2 request before we apply the default parameters/values to the user request, in addition to what we have already.

@amaltaro, Alan where would you keep this and what will be the usage?

Darn it! We should get this in for August deployment. I think we can simply log the user input in the usual reqmgr2 log.
The use case is debugging workflows and making sure that what the user claims to have posted to reqmgr2 is actually what he really posted. Example are the EventsPerJob and EventsPerLumi, that we're rounding now in ReqMgr2.
I'm working on it today.

Fixed by #8691