Ambari-26147: Add Ruff integration to ambari

What changes were proposed in this pull request?
The entire Ambari project has accumulated a large amount of Python code, which is the result of the collective efforts of multiple contributors to make Ambari better.

Language
Files
Lines
Code
Comments
Blanks

Java
3330
690679
427116
156389
107174

JavaScript
2125
512742
374238
87081
51423

Plain Text
68
500082
0
497409
2673

JSON
758
479988
479689
0
299

Python
1096
218057
175499
9547
33011

XML
1135
156581
130300
20189
6092

During this process, a problem has emerged: everyone has different coding styles, which leads to inconsistencies in the submitted code. This can result in various inconveniences, such as increased understanding costs of the underlying principles and greater difficulty in identifying the root causes of issues. As the codebase grows, these problems become increasingly apparent. Therefore, we are introducing ruff, along with some additional processes, to format the code and alleviate these issues.
What is Ruff?
An extremely fast Python linter and code formatter, written in Rust. Its speed is one of its advantages. More information can be found here: ruff.
(Please fill in changes proposed in this fix)
Ruff rules are derived from the Apache Superset project's rule file.
Ruff integration plan:

Project integration with Ruff, formatting all Python files, ensuring all tests pass, and the cluster runs normally. Completed.
Integration of Ruff detection into Jenkins. Completed.

Notice: This PR's Ruff rules ignore some rule checks because these rules involve significant changes that will be addressed in subsequent PRs. The current PR ensures that all Python indentation and basic formatting conform to standards.

Ruff Usage Instructions in Ambari Code Submission
Install Ruff:
pip install ruff

Format Code with Ruff:
ruff format .

Check Code Format Manually:
ruff check .

Check Code Format with Maven:
mvn exec:exec@ruff-check -Pruff-check

Fix Code Format with Maven:
mvn exec:exec@ruff-format -Pruff-format

How was this patch tested?
manual test CI/CD
After formatting thousands of files with Ruff, I deployed a simple cluster to verify that Ambari runs smoothly.

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

@virajjasani Could you help check this PR?

Wow, this is huge and yet it seems worth having. Skimmed through at high level, looks good. I wonder if anyone else is also interested to review this, otherwise let's get this in and see how things go.
Nice work!

Hi @JiaLiangC,
Which environment are you deploying the cluster for testing? It seems you're having success with the setup.
I recently tried to build and deploy an Ambari cluster on Rocky Linux 8 and encountered two blocking issues:
AMBARI-26183 (Fixed)
AMBARI-26187 (Still open)

@arshadmohammad  Good catch! Your deployment failed because of this PR: https://github.com/apache/ambari/pull/3770, which introduced numerous bugs in the frontend.
Although the subsequent PR https://github.com/apache/ambari/pull/3846 fixed many issues, around 60 of them, there are still many bugs remaining. One of them is the blocking issue you encountered, which is a bug caused by the frontend upgrade. I tested using the code from before this PR was merged: AMBARI-25289 Upgrade Jquery and Bootstrap to latest versions #3770.

Hi @JiaLiangC, Which environment are you deploying the cluster for testing? It seems you're having success with the setup. I recently tried to build and deploy an Ambari cluster on Rocky Linux 8 and encountered two blocking issues: AMBARI-26183 (Fixed) AMBARI-26187 (Still open)

@arshadmohammad Already resolved by this pr  https://github.com/apache/ambari/pull/3849.

Thanks @JiaLiangC, I will review this patch

@arshadmohammad I have added the usage of Ruff involved in this PR to the description. Additionally, all code changes in this PR are the result of ruff format.

Hi @JiaLiangC , many changes include indentation / spacing between the lines, the current codebase uses two spaces for indentation / spacing instead of the typical four spaces / tabs. Is it possible to configure ruff to consider two spaces as the indentation and spacing size as it is the standard followed. Doing so may help reduce the size of the change as well and have clear diff for the actual changes.

@vishalsuvagia Thank you for the reminder. I've changed the indent-width to 2 and committed it. This indeed makes it easier to review. However, there are still a massive 900 files, which I believe makes manual review very difficult. We can only rely on unit tests and subsequent bug reports after usage. Currently, the unit tests have passed, and I've deployed a complete cluster in my environment without finding any issues so far. Theoretically, code formatting tools like ruff shouldn't change the code semantics.


message pull request

:star: PR built and available in a preview environment upendrasahu-pythonapp-9442-pr-1 here


[update-checkout]: Add --fetch option.

When checking out repositories, it's sometimes necessary to run git fetch
first to pull the latest commits, branches, and tags down from GitHub. This
commit adds a --fetch option so that the update-checkout script will
perform a git fetch first.
Note: this change preserves the default behavior, such that update-checkout can
be run without an internet connection.

It fetches by default for me. What behavior are you observing?

It fetches by default for me. What behavior are you observing?

The behavior I've observed is: after updating Git hashes in utils/update_checkout/update-checkout-config.json, swift/utils/update-checkout --clone --scheme tensorflow doesn't fetch and fails.
diff --git a/utils/update_checkout/update-checkout-config.json b/utils/update_checkout/update-checkout-config.json
index d147ca1722..82b071f287 100644
--- a/utils/update_checkout/update-checkout-config.json
+++ b/utils/update_checkout/update-checkout-config.json
@@ -355,29 +355,29 @@
         "tensorflow": {
             "aliases": ["tensorflow"],
             "repos": {
-                "llvm": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
+                "llvm": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
                 "clang": "ea2e6942a25eb7201d32c7c21b1dd7e5658ba1e8",
                 "swift": "tensorflow",
                 "lldb": "4514d21fbe49a16baf26ba918c5a4906d54e8091",
-                "cmark": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "llbuild": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "swiftpm": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
+                "cmark": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "llbuild": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "swiftpm": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
                 "swift-syntax": "ce19fd53c3137baa1c3370d9577c18f125934a04",
-                "swift-stress-tester": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "compiler-rt": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "swift-corelibs-xctest": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "swift-corelibs-foundation": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "swift-corelibs-libdispatch": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "swift-integration-tests": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "swift-xcode-playground-support": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
+                "swift-stress-tester": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "compiler-rt": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "swift-corelibs-xctest": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "swift-corelibs-foundation": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "swift-corelibs-libdispatch": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "swift-integration-tests": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "swift-xcode-playground-support": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
                 "ninja": "release",
                 "icu": "release-61-1",
-                "clang-tools-extra": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "libcxx": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
+                "clang-tools-extra": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "libcxx": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
                 "tensorflow": "ebc41609e27dcf0998d8970e77a2e1f53e13ac86",
                 "tensorflow-swift-apis": "5d3ef57b501781f1bab3b4ca85e8b8fc91671c14",
-                "indexstore-db": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a",
-                "sourcekit-lsp": "swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a"
+                "indexstore-db": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a",
+                "sourcekit-lsp": "swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a"
             }
         }
     }

Previously, all repositories were checked out at swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a and have not been fetched since then.
$ /swift/utils/update-checkout --clone --scheme tensorflow --skip-repository swift
Including icu on Linux
Skipping clone of 'sourcekit-lsp', directory already exists
Skipping clone of 'indexstore-db', directory already exists
Skipping clone of 'llbuild', directory already exists
Skipping clone of 'swift-xcode-playground-support', directory already exists
Skipping clone of 'swift-syntax', directory already exists
Skipping clone of 'swift-corelibs-xctest', directory already exists
Skipping clone of 'swiftpm', directory already exists
Skipping clone of 'compiler-rt', directory already exists
Skipping clone of 'libcxx', directory already exists
Skipping clone of 'tensorflow-swift-apis', directory already exists
Skipping clone of 'lldb', directory already exists
Skipping clone of 'tensorflow', directory already exists
Skipping clone of 'icu', directory already exists
Skipping clone of 'llvm', directory already exists
Skipping clone of 'clang', directory already exists
Skipping clone of 'swift-corelibs-foundation', directory already exists
Skipping clone of 'ninja', directory already exists
Skipping clone of 'swift-integration-tests', directory already exists
Skipping clone of 'swift', requested by user
Skipping clone of 'clang-tools-extra', directory already exists
Skipping clone of 'swift-stress-tester', directory already exists
Skipping clone of 'cmark', directory already exists
Skipping clone of 'swift-corelibs-libdispatch', directory already exists
Not cloning any repositories.
Skipping update of 'swift', requested by user
Running ``update_single_repository`` with up to 192 processes.
Updating '/home/danielzheng/swift-merge/sourcekit-lsp'
Updating '/home/danielzheng/swift-merge/indexstore-db'
Updating '/home/danielzheng/swift-merge/llbuild'
Updating '/home/danielzheng/swift-merge/swift-xcode-playground-support'
Updating '/home/danielzheng/swift-merge/swift-syntax'
Updating '/home/danielzheng/swift-merge/swift-corelibs-xctest'
Updating '/home/danielzheng/swift-merge/swiftpm'
Updating '/home/danielzheng/swift-merge/compiler-rt'
Updating '/home/danielzheng/swift-merge/libcxx'
Updating '/home/danielzheng/swift-merge/tensorflow-swift-apis'
Updating '/home/danielzheng/swift-merge/lldb'
Updating '/home/danielzheng/swift-merge/tensorflow'
Updating '/home/danielzheng/swift-merge/icu'
Updating '/home/danielzheng/swift-merge/llvm'
Updating '/home/danielzheng/swift-merge/clang'
Updating '/home/danielzheng/swift-merge/swift-corelibs-foundation'
Updating '/home/danielzheng/swift-merge/ninja'
Updating '/home/danielzheng/swift-merge/swift-integration-tests'
Updating '/home/danielzheng/swift-merge/clang-tools-extra'
/home/danielzheng/swift-merge/sourcekit-lsp
+ git checkout swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-xcode-playground-support
Updating '/home/danielzheng/swift-merge/swift-stress-tester'
+ git checkout swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/indexstore-db
Error on repo "/home/danielzheng/swift-merge/sourcekit-lsp": Traceback (most recent call last):
  File "/home/danielzheng/swift-merge/swift/utils/update_checkout/update_checkout/update_checkout.py", line 128, in update_single_repository
    shell.run(['git', 'checkout', checkout_target], echo=True)
  File "/home/danielzheng/swift-merge/swift/utils/swift_build_support/swift_build_support/shell.py", line 231, in run
    raise eout
Exception: ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
+ git checkout swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a

error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

Updating '/home/danielzheng/swift-merge/cmark'
Error on repo "/home/danielzheng/swift-merge/swift-xcode-playground-support": Traceback (most recent call last):
  File "/home/danielzheng/swift-merge/swift/utils/update_checkout/update_checkout/update_checkout.py", line 128, in update_single_repository
    shell.run(['git', 'checkout', checkout_target], echo=True)
  File "/home/danielzheng/swift-merge/swift/utils/swift_build_support/swift_build_support/shell.py", line 231, in run
    raise eout
Exception: ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']

... # more failures

======UPDATE FAILURES======
/home/danielzheng/swift-merge/sourcekit-lsp failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/indexstore-db failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/llbuild failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-xcode-playground-support failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-corelibs-xctest failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swiftpm failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/compiler-rt failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/libcxx failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/llvm failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-corelibs-foundation failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-integration-tests failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/clang-tools-extra failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-stress-tester failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/cmark failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

/home/danielzheng/swift-merge/swift-corelibs-libdispatch failed (ret=1): ['git', 'checkout', u'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a']
error: pathspec 'swift-DEVELOPMENT-SNAPSHOT-2019-06-16-a' did not match any file(s) known to git.

update-checkout failed, fix errors and try again

With this patch, passing --fetch makes the command succeed:
$ ./swift/utils/update-checkout --clone --scheme tensorflow --skip-repository swift --fetch
...
update-checkout succeeded

It fetches by default for me. What behavior are you observing?

Concretely, it looks like there's a git fetch happening here but it's happening after the git checkout which is the problem as the tags and latest commits have not been pulled down.
Thank you very much for taking a look @jrose-apple !
All the best,
-Brennan

Ah, I guess I don't use update-checkout to change schemes very often. But the very next lines say that this is a bad idea.
https://github.com/apple/swift/blob/85bfbe2dd33f7fea023f8d2a88689810b870adbd/utils/update_checkout/update_checkout/update_checkout.py#L126-L128
…unfortunately, the person who wrote them is no longer on the project.

PTAL @jrose-apple / @dan-zheng . I've switched over to using git remote update which should do what we want without stomping on .git/FETCH_HEAD based on my read of the git documentation. Thanks!

This seems reasonable to me. @gottesmm?

Can you add a unit test for this? I recently provided the infrastructure to create mock repos/etc. Every new update-checkout change that we put in should at least have a test that makes sure it runs without asserting. Something like this:
https://github.com/apple/swift/blob/master/utils/update_checkout/tests/test_dump.py
I haven't messed around with checking the actual output, but I imagine it would be pretty easy to add such checks.

Can one of the admins verify this patch?

I'm going to close this out due to age and inactivity. I think it's still a change worth pursuing, so I've converted this into an SR. Please take a look at it when you find the time.


import and create random addresses in the 'pending' set

Issue Number

ADP-619
Overview

e427df198c3f1d271cf358cbb0a3945e4f7cdd9f
:round_pushpin: import and create random addresses in the 'pending' set
When we implemented these features, all addresses were placed in the discovered set. The problem with that is that it makes
them affected by rollbacks. So a client may import 100K addresses, and the next minute they're all gone. We've seen some
integration tests being 'flaky' actually just showing symptoms of that issue.
In addition to moving imported and manually created addresses in the pending set, this commit also make the pending set
returned as part of the total addresses set returned by the API to avoid breaking clients' code and because this is actually
what most clients would want.

Comments

bors r+

bors r+

bors retry

bors retry


"cregbundle set to False" warning should not raised when no classical bits are involved

@Guillermo-Mijares-Vilarino discovered that the following code raises a very confusing warning:
from qiskit.circuit.library import QFT
qft = QFT(3)
qft.decompose().draw('mpl', reverse_bits=True)

RuntimeWarning: Cregbundle set to False since either reverse_bits or wire_order has been set.
  wire_order=wire_order,

This fix checks if classical bits are involved before touching cregbundle.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.001%) to 84.364%

Files with Coverage Reduction
New Missed Lines
%

qiskit/extensions/quantum_initializer/squ.py
2
79.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
57868

Relevant Lines:
68593

💛  - Coveralls

This PR would be very helpful for the explanation section I'm adding in #8685.

Would you like to make this part of a slightly larger issue surrounding the cregbundle parameter?  I've just made #8690 to describe it, although the behaviour has been present for a super long time.  Your fix here is good with or without touching that issue, I'm just bringing it up since you're touching the code anyway.

Would you like to make this part of a slightly larger issue surrounding the cregbundle parameter?

I fixed that one too by changing the way that the default is handled for that parameter.


Enable additional deps (opencv, portaudio, qt-main)

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [64, 100]

Windows is failing with:
2022-06-13T17:39:39.7493831Z Fixing permissions
2022-06-13T17:39:40.2945154Z Packaged license file/s.
2022-06-13T17:39:40.7709012Z INFO :: Time taken to mark (prefix)
2022-06-13T17:39:40.7710656Z         0 replacements in 0 files was 0.47 seconds
2022-06-13T17:39:40.7711678Z Files containing CONDA_PREFIX
2022-06-13T17:39:40.7712386Z -----------------------------
2022-06-13T17:39:40.7713308Z Library/lib/cmake/YARP_cv/YARP_cvTargets.cmake (text): Patching
2022-06-13T17:39:40.7714251Z Library/lib/cmake/YARP_manager/YARP_managerTargets.cmake (text): Patching
2022-06-13T17:39:40.7715120Z Library/share/yarp/plugins/yarp.ini (text): Patching
2022-06-13T17:39:49.3744965Z Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
2022-06-13T17:39:49.3747959Z WARNING:conda_build.build:Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
2022-06-13T17:39:59.8403458Z INFO:conda_build.build:Packaging yarp-python
2022-06-13T17:39:59.8404870Z Packaging yarp-python
2022-06-13T17:40:00.7326011Z Reloading output folder: D:\bld
2022-06-13T17:40:01.2930927Z Mamba failed to solve:
2022-06-13T17:40:01.2933184Z  - ca-certificates 2<IP_ADDRESS>.* h5b45459_0
2022-06-13T17:40:01.2936799Z  - ucrt 10.0.20348.0.* h57928b3_0
2022-06-13T17:40:01.2938006Z  - vs2015_runtime 14.29.30037.* h902a5da_6
2022-06-13T17:40:01.2939032Z  - vc 14.2.* hb210afc_6
2022-06-13T17:40:01.2939939Z  - openssl 3.0.3.* h8ffe710_0
2022-06-13T17:40:01.2941031Z  - sqlite 3.38.5.* h8ffe710_0
2022-06-13T17:40:01.2941950Z  - python 3.7.12.* h900ac77_100_cpython
2022-06-13T17:40:01.2943101Z  - python_abi 3.7.* 2_cp37m
2022-06-13T17:40:01.2944273Z  - wheel 0.37.1.* pyhd8ed1ab_0
2022-06-13T17:40:01.2945199Z  - setuptools 62.3.4.* py37h03978a9_0
2022-06-13T17:40:01.2946184Z  - pip 22.1.2.* pyhd8ed1ab_0
2022-06-13T17:40:01.2947073Z  - yarp-cxx 3.7.0.* hf2cc95b_1
2022-06-13T17:40:01.2947756Z
2022-06-13T17:40:01.2948547Z with channels:
2022-06-13T17:40:01.2949184Z
2022-06-13T17:40:01.2951568Z The reported errors are:
2022-06-13T17:40:01.2952748Z - Encountered problems while solving:
2022-06-13T17:40:01.2954078Z -   - package yarp-cxx-3.7.0-hf2cc95b_1 requires libopencv >=4.5.5,<<IP_ADDRESS>a0, but none of the providers can be installed
2022-06-13T17:40:01.2955532Z -
2022-06-13T17:40:01.3059490Z Traceback (most recent call last):
2022-06-13T17:40:01.3061913Z   File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 124, in mamba_get_install_actions
2022-06-13T17:40:01.3093729Z     solution = solver.solve_for_action(_specs, prefix)
2022-06-13T17:40:01.3094594Z   File "C:\Miniforge\lib\site-packages\boa\core\solver.py", line 226, in solve_for_action
2022-06-13T17:40:01.3112588Z     t = self.solve(specs)
2022-06-13T17:40:01.3113489Z   File "C:\Miniforge\lib\site-packages\boa\core\solver.py", line 216, in solve
2022-06-13T17:40:01.3114905Z     raise RuntimeError("Solver could not find solution." + error_string)
2022-06-13T17:40:01.3115800Z RuntimeError: Solver could not find solution.Mamba failed to solve:
2022-06-13T17:40:01.3116664Z  - ca-certificates 2<IP_ADDRESS>.* h5b45459_0
2022-06-13T17:40:01.3117448Z  - ucrt 10.0.20348.0.* h57928b3_0
2022-06-13T17:40:01.3118282Z  - vs2015_runtime 14.29.30037.* h902a5da_6
2022-06-13T17:40:01.3119044Z  - vc 14.2.* hb210afc_6
2022-06-13T17:40:01.3119713Z  - openssl 3.0.3.* h8ffe710_0
2022-06-13T17:40:01.3120446Z  - sqlite 3.38.5.* h8ffe710_0
2022-06-13T17:40:01.3121169Z  - python 3.7.12.* h900ac77_100_cpython
2022-06-13T17:40:01.3121642Z  - python_abi 3.7.* 2_cp37m
2022-06-13T17:40:01.3122112Z  - wheel 0.37.1.* pyhd8ed1ab_0
2022-06-13T17:40:01.3122547Z  - setuptools 62.3.4.* py37h03978a9_0
2022-06-13T17:40:01.3123074Z  - pip 22.1.2.* pyhd8ed1ab_0
2022-06-13T17:40:01.3123548Z  - yarp-cxx 3.7.0.* hf2cc95b_1
2022-06-13T17:40:01.3123775Z
2022-06-13T17:40:01.3124111Z with channels:
2022-06-13T17:40:01.3124358Z
2022-06-13T17:40:01.3124709Z The reported errors are:
2022-06-13T17:40:01.3125178Z - Encountered problems while solving:
2022-06-13T17:40:01.3125792Z -   - package yarp-cxx-3.7.0-hf2cc95b_1 requires libopencv >=4.5.5,<<IP_ADDRESS>a0, but none of the providers can be installed
2022-06-13T17:40:01.3126534Z -
2022-06-13T17:40:01.3126800Z
2022-06-13T17:40:01.3127731Z During handling of the above exception, another exception occurred:
2022-06-13T17:40:01.3128236Z
2022-06-13T17:40:01.3128702Z Traceback (most recent call last):
2022-06-13T17:40:01.3129256Z   File "C:\Miniforge\Scripts\conda-mambabuild-script.py", line 9, in <module>
2022-06-13T17:40:01.3129823Z     sys.exit(main())
2022-06-13T17:40:01.3130328Z   File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 239, in main
2022-06-13T17:40:01.3130898Z     call_conda_build(action, config)
2022-06-13T17:40:01.3131615Z   File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 211, in call_conda_build
2022-06-13T17:40:01.3132399Z     result = api.build(
2022-06-13T17:40:01.3133275Z   File "C:\Miniforge\lib\site-packages\conda_build\api.py", line 186, in build
2022-06-13T17:40:01.3137173Z     return build_tree(
2022-06-13T17:40:01.3138035Z   File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 3088, in build_tree
2022-06-13T17:40:01.3190739Z     packages_from_this = build(metadata, stats,
2022-06-13T17:40:01.3191718Z   File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 2314, in build
2022-06-13T17:40:01.3198334Z     host_actions = environ.get_install_actions(m.config.host_prefix,
2022-06-13T17:40:01.3199241Z   File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 126, in mamba_get_install_actions
2022-06-13T17:40:01.3200236Z     conflict_packages = parse_problems(str(e))
2022-06-13T17:40:01.3201055Z   File "C:\Miniforge\lib\site-packages\boa\cli\mambabuild.py", line 41, in parse_problems
2022-06-13T17:40:01.3202030Z     assert words[1] == "package", f"words = {repr(words)}"
2022-06-13T17:40:01.3204133Z AssertionError: words = ['-', '-', 'package', 'yarp-cxx-3.7.0-hf2cc95b_1', 'requires', 'libopencv', '>=4.5.5,<<IP_ADDRESS>a0,', 'but', 'none', 'of', 'the', 'providers', 'can', 'be', 'installed']
2022-06-13T17:40:07.8197623Z ##[error]Cmd.exe exited with code '1'.
2022-06-13T17:40:08.0468614Z ##[section]Finishing: Build recipe

Let's try to workaround this by pinning openssl to 1.1.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Now the openssl problem happens also on Linux:
with channels:

The reported errors are:
- Encountered problems while solving:
-   - package yarp-cxx-3.7.0-h70892ea_1 requires qt-main >=5.15.4,<5.16.0a0, but none of the providers can be installed
-

During handling of the above exception, another exception occurred:

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Content and elements inside it  not getting rendered

Hi! Thanks for trying out NativeBase!
Due to the overwhelming requests and issues/questions we ask you to add the following details with your issue.
Please check the existing open/closed issues for a possible duplicate before creating a new issue :)
Also DO fill out the below form to give us a better idea about your environment and help us debug it quicker. Issues without the required details will mostly be unattended to.
react-native, react and native-base version

Expected behaviour
Input element should be rendered.
Actual behaviour

Steps to reproduce (code snippet or screenshot)

Screenshot of emulator/device
Genymotion Emulator

Is the bug present in both ios and android or in any one of them?
Tested on Android only
Any other additional info which would help us debug the issue quicker.

Update:
Running any example such as "HeaderExample" is crashing the app, without any warning/error message.

@zurez Tried your code with the versions specified. Didn't see any issue. Attaching a gif

Closing this due to no response


Error on logs with mob kills quest

What is your Quests version / build number (do not say "latest")?
182
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
I have this error in my log: https://pastebin.com/P6WNFNYY
I use the crackshot plugin too, is that a problem?
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
https://pastebin.com/MmEHxe6S

Thanks for the report. Try https://ci.codemc.io/job/PikaMug/job/Quests/183/
Note that QuestsGUI may not be fully compatible with that build.


How to revert model outside the admin

So I have a project, in which users should be able to revert to their previous model instances directly from website. So my question is what function is used when clicked revert in django-admin? Or any other way to reach a solution to my issue.

@tsolan3 , it looks like the code for that is in admin.py here (lines 133-144):
form = form_class(request.POST, request.FILES, instance=obj)
            if form.is_valid():
                new_object = self.save_form(request, form, change=True)
                self.save_model(request, new_object, form, change=True)
                form.save_m2m()

                self.log_change(request, new_object,
                                self.construct_change_message(
                                    request, form, formsets))
                return self.response_change(request, new_object)

Essentially they just take the old object and save it normally (since save automatically versions). For reverting a model, just grab an old instance of the model and save it.

@tsolan3 you can do the following. Say I have an instance of Poll called poll and I want to revert back to the first version of poll. I could do it like this:
poll.history.earliest().instance.save()


Add Gitlab renderer for Gitlab CI

Description
There is a Github renderer at the moment, so it only makes sense to also add a Gitlab version. There are some ways to convert the json output, but that also requires additional software to parse the json output and nobody wants that kind of strain on the runners.
As far as i can tell the output should look something like this:
[
  {
    "type": "issue",
    "categories": [
      "Style",
      "PHP"
    ],
    "check_name": "ExcessiveClassComplexity",
    "fingerprint": "/var/www/html/app/SomeFile.php:31:ExcessiveClassComplexity",
    "description": "The class SomeFile has an overall complexity of 51 which is very high. The configured complexity threshold is 50.",
    "severity": "unknown",
    "location": {
      "path": "/var/www/html/app/SomeFile.php",
      "lines": {
        "begin": 31,
        "end": 2772
      }
    }
  },
]

Checks before submitting

[x] Be sure that there isn't already an issue about this. See: Issues list
[x] Be sure that there isn't already a pull request about this. See: Pull requests
[x] Tell if you have the option to provide the code for this proposal.
[x] This issue is about 1 feature proposal and nothing more.
[x] The issue has a descriptive title. For example: "Add JSON render option".

@metalmini thanks for the idea, I think it can be a nice addition.
Are you able to create a PR for this?

@tvbeek i will give it a go if i find some spare time.

@metalmini thanks for the PR. It is very nice to see someone writing a good idea to add and implementing the code for it. 👍


subsys/shell/modules/devmem_service.c violates coding guidelines rule A.5

Describe the bug
Zephyr's coding guideline rule A.5 states which C library functions can be used by (embedded) code in the Zephyr tree
https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-5-c-standard-library-usage-restrictions-in-zephyr-codebase
subsys/shell/modules/devmem_service.c uses getopt:
https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/shell/modules/devmem_service.c#L101
which is not between these, and therefore is breaking this rule.
To Reproduce
N/A, code inspection
Expected behavior
No use of C library functions beyond those in that list in embedded Zephyr code (outside of the POSIX compatibility API layer)
Impact
Prevents progress in cleaning up the too wide setting of _POSIX_C_SOURCE macros.
Logs and console output
N/A
Environment (please complete the following information):
N/A
Additional context
Introduced in 510dca57da8

Still applicable


Add boost-gecko search box

This is a temporary solution for integrating the current search functionality from boost.org into the new website. We should explore for a more effective way of incorporating and updating the boost-gecko scripts.
The script is a build from the new-website branch, which has been modified to extract template parameters, such as dark/light mode and font-family, and use externally provided search buttons.
The search functionality will be further extended to include searching in guidelines, news, and mailing lists as well.

@gregnewman, would you be able to take a look at this?

NOICE!

@ashtum I'm reviewing

@gregnewman Could you please merge this? I don't have the necessary access.

@ashtum Looks good to me, just pulled it down locally to check it out.  I'll merge!


Cleanup inactive WorkloadInstances and AppVersions

Currently, we're not triggering pre-deployment tasks and evaluations if the corresponding app/workload version has already been deployed on the environment. As this is misleading in rollback cases and our current behavior might be resource-consuming, the LT should keep track of its workloads/applications and find out if they are still on the environment, mark them inactive if they are no more available, and delete them after some time.
FYI: @grabnerandi

We can add a new entry to KeptnConfig for configuring how many last items we should keep before deleting them.


signald: 0.13.1 -> 0.15.0

WARNING: Totally broken
Motivation for this change
https://gitlab.com/signald/signald/-/releases
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

https://gitlab.com/signald/signald/-/issues/242

I got the update working in #149955.

Already in #149955.


puppeteer-real-browser displays webpages incorrectly (frame issue)

Description
When loading the following webpage, the scroll bar doesn't show and it is impossible to scroll to the last line (the line with the four zeros [0000]) even with the mouse (scroll wheel). This webpage works fine with normal puppeteer and normal Chrome, so the issue must be with puppeteer-real-browser.
My conditions:

Headless: false
On Windows
Screen resolution 1366x768 and 100% scale
100% zoom on webpage (no zoom)
Browser window is maximized

connectOption: {
			defaultViewport: {
				width: 1366,
				height: 768,
				deviceScaleFactor: 1,
			},
		},

Full steps to reproduce the issue
use page.setContent() with the following HTML code I prepared for debugging:
scroll_example.zip
Issue Type
Bug
Operating System
Windows
Do you use Docker?
No

It should be fixed with the last update. If not, can you provide information on this issue? Thank you.


added New pixel my username

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

actually updated packagejson oops

actually updated packagejson oops


Mle_Router: Check the child's state to be valid when receiving a  "…Child Update Request"

In HandleChildUpdateRequest() check that the child is already
in state kStateValid before sending the full reply. This
addresses an issue during re-attach process (where the child
could switch to valid state before counters were synced on the
parent).

Codecov Report

Merging #1270 into master will increase coverage by 0.04%.

@@            Coverage Diff            @@
##           master   #1270      +/-   ##
=========================================
+ Coverage   69.25%   69.3%   +0.04%
=========================================
  Files         170     170
  Lines       26700   26698       -2
  Branches     3320    3320
=========================================
+ Hits        18491   18502      +11
+ Misses       6792    6786       -6
+ Partials     1417    1410       -7

Impacted Files
Coverage Δ

src/core/thread/mle_router.cpp
80.19% <ø> (+0.2%)
:white_check_mark:

src/ncp/ncp_base.cpp
34.56% <ø> (-2.72%)
:x:

third_party/mbedtls/repo/library/ctr_drbg.c
71.32% <ø> (-0.74%)
:x:

src/core/net/netif.cpp
61.85% <ø> (-0.52%)
:x:

src/core/thread/mesh_forwarder.cpp
75.77% <ø> (-0.12%)
:x:

src/core/thread/mle.cpp
80.55% <ø> (+0.07%)
:white_check_mark:

third_party/mbedtls/repo/library/bignum.c
50.95% <ø> (+0.13%)
:white_check_mark:

src/core/mac/mac.cpp
78.64% <ø> (+0.46%)
:white_check_mark:

src/core/thread/network_data_leader.cpp
80.59% <ø> (+0.49%)
:white_check_mark:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49697ac...c4fc756. Read the comment docs.


Add finalizers role for node and tsp

What this PR does / why we need it:
Users may use OwnerReferencesPermissionEnforcement plugin, so add finalizers role for node and tsp to role

/LGTM


[5.10 cherry-pick] Fix infinite lookup importing forward declarations from bridging header

Explanation:
The upcoming feature ImportObjcForwardDeclarations allows forward declared ObjC interfaces and protocols to be represented in Swift. However, a forward declaration @class Foo which is defined in Swift is intentionally not imported. To determine if a forward declaration is defined natively in Swift, the ClangImporter must perform a lookup for Foo in all imported Swift modules. It uses the IsNonSwiftModule bitfield to skip ModuleDecls which contain non-Swift FileUnits.
The __ObjC Swift module is a special module that houses among other things synthesized declarations from the bridging header. It contains a single ClangModuleUnit, but does not point to an underlying Clang module but rather defers to the BridgingHeader lookup table. Prior to this patch, this module was not marked "NonSwift" despite it including exclusively non Swift declarations.
This sent the aforementioned lookup for a native Swift definition Foo into an infinite loop. The loop looks like:

ClangImporter discovers @class Foo
Looks up Foo in all imported modules including __ObjC
Lookup is delegated to BridgingHeader table
Lookup finds the same @class Foo declaration
Repeat

This patch marks the module as NonSwift so it isn't considered in this lookup in the first place.
Scope:
Without this change users cannot enable the upcoming feature ImportObjCForwardDeclarations while using a bridging header that has forward declared ObjC protocols or interfaces. The stack will overflow if they do. This is a bug fix that should not break any existing behavior. As far as I can tell, users of the IsNonSwiftModule already the property to be true for overlays, and this module is basically a fancy overlay.
Risk:
Some code might be relying on this special module being considered a Swift module, but that would not align with the semantics of the property I've observed.
Testing:

Swift compatibility test suite
Swift LIT / unit tests

@swift-ci Please test

@swift-ci Please test source compatibility


Add Odessa robbery

May 2018 https://www.bloomberg.com/news/features/2018-10-10/revolution-anarchy-and-bitcoin-in-ukraine

Emailed author<EMAIL_ADDRESS>for clarification / source but no response.


Add a test on real data

As we have discussed here, add_inputs_from may spend duplicate UTxOs when 1 UTxO is not enough to cover all the outputs. I'm trying to fix this issue in this PR.
I'll add unit test to show the issue first.
Fee Settings (on Testnet)
A: 44
B: 155381
UTxOs

1 tADA
10 tADA

Outputs
1 tADA

The root cause is that cip2_random_improve_by() doesn't exclude the chosen index from available_indices, which could be chosen again by the random algorithm.

@SebastienGllmt Is there any other change required? The warnings are not from this PR. I tried to remove the warnings but some them such as "warning: field is never read: cert" are something you are still working on?


Cannot read property 'getComputedStyle' of null

I am using the input[type=date] in a popup that I show and hide, and this is causing the following problem:
https://github.com/chemerisuk/better-dom/issues/45
I'm not sure if the problem is from the library (better-dom) or the polyfill (better-dateinput-polyfill)

@dertin Do you found a solution?

I attached an example how to reproduce the problem.
datepicker.zip

Version 4 does not depend on better-dom so the issue should be fixed there.


Company Import, creates custom fields without Value.

And It had created Custom fields with name Column1,Column2,etc.

Still DOI and DOB field's value is missing.
And system appends Column 1 to Column 7 in custom fields.


Fix race condition when editing the "Check" field in the note

Noticed this weird bug:

Add a note with a boolean (checkbox) field in the header (eg, closed)
Enable the "Checked" field function in Board view (set Checked to our boolean field, closed):

Open the note in a new tab (Projects tab still loaded)
Change the value of the closed field in the note (not in Board view)

Obsidian freezes, as Projects falls into the following race condition:

Note file edit triggers a view update in Svelte
Card Checkbox on:check() is triggered, since the checked state changed (call, source)
handleRecordCheck is triggered, complementing the checked state again (source)
checked state complement causes another file edit trigger again, repeat

Easy fix: only trigger handleRecordCheck() when we click the checkbox in Board view, dont respond to all checked field changes

Thanks! Will review it this weekend.

Calendar checkbox has a similar problem. Working on a better fix.


Tool doesn't work on esp32c3 risc-v cpu's

When running idf.py clang-check on a project using the esp32c3 you get the following output in warnings.txt repeated:
error: unknown target CPU 'rv32imc' [clang-diagnostic-error]
note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, cor
ei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake,
 cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, optero
n, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x8
6-64, x86-64-v2, x86-64-v3, x86-64-v4
Error while processing /home/robert/Programs/esp-idf/components/openssl/platform/ssl_port.c.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).

versions of all the components used:
$ clang --version
clang version 12.0.1 (https://github.com/espressif/llvm-project.git d9341b81fc589c0483d629155bc88e6e85e3db34)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: .espressif/tools/xtensa-clang/12.0.1-d9341b81fc/xtensa-esp32-elf-clang/bin
$ clang-tidy --version
LLVM (http://llvm.org/):
  LLVM version 12.0.1
  Optimized build.
  Default target: x86_64-unknown-linux-gnu
  Host CPU: skylake
$ which run-clang-tidy.py
.espressif/tools/xtensa-clang/12.0.1-d9341b81fc/xtensa-esp32-elf-clang/bin/run-clang-tidy.py
$ idf.py --version
ESP-IDF v5.0-dev-1462-g3441dd1e98

Adding the following replacements in https://github.com/espressif/clang-tidy-runner/blob/79b79fa772cb9ee93b91af0b04e97fa8822207c9/pyclang/runner.py#L51
fixes this error
	'-march=rv32imc': '',
	'-Wno-error=format=': '',
	'-Werror=unused-but-set-variable': '',
	'-Wformat-overflow=2': '',
	'-Wformat-signedness': '',
	'-Wformat-truncation': '',
	'-Wlogical-op': '',
	'-Wno-old-style-declaration': '',

But still leaves another error, "machine/endian.h not found".

@sqrtroot Hi, according to the doc, it doesn't support RISC-V yet. I'll keep it open and ping you again when we support this :)

This should now work with ESP-IDF master branch. esp-clang distribution bundled with IDF now supports both Xtensa and RISC-V.


[BEAM-5037] fix synthetic options

This fixes SyntheticOptions bug related to the transient hashFunction field. It changes scope of hash function field and introduces a hashFunction() method allowing to postpone hashFunction until it is needed. It also gets rid of the need to check hashFunction property (the line which caused the problem).

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

@pabloem @chamikaramj could you take a look?

Retest this please

Run Java PreCommit


Associate "Open link to the side" with Ctrl+shift+click

Hi,
let me start by expressing my gratitude for your efforts into this nice project !
It has much improved since I've first evaluated it last year, and it will be a nice fit in out current project's toolset. Also, as an Obsidian user, I'm feeling quite at ease, despite the inevitable missing features.
I think the biggest UX problem I encountered is that "Open link to the side" can only be triggered using the keyboard.
Given the importance of this command, I wish to propose that it is also associated with Ctrl+shift+click.
This way, a link to an image can easily be opened to the side, overcoming the absence of preview on hover.
Cheers

Hi,
Besides keyboard "Open link to the side can" be triggered also via context menu.

I wish to propose that it is also associated with Ctrl+shift+click.

As far as I know vscode does not support shortcuts with mouse clicks at the moment. https://github.com/microsoft/vscode/issues/38849

As far as I know vscode does not support shortcuts with mouse clicks at the moment.

Thanks for the detailed explanation. I've voted for the upstream issue: apparently the number of votes is taken into account when deciding which VS Code issues to fix first.

This one could be reopened as soon as there are more news on progress with it from vscode team. 👍


Audio for Dynamic memory allocation in C

Description
I will contribute audio in Dynamic memory allocation in C.
Domain
C/CPP
Type of Contribution
Audio
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Bug in dpt function in overpressure.py

Hi. I recentely found your code while looking for info on nuclear blast effects and I believe there is a bug in _dpt. The function uses the variable t at line 555 in the overpressure.py source but it is never defined (that I can see) before it is used.  I presume its missing from the function argument list. ie the function definition should be ,
def _dpt(shob, sgr, x_m, ta_air, dp_q, pair, b, t):
The function reference in _dynamicpressureatscaledtime should also be corrected.
BTW if you are looking for a report that has a (mostly) legible copy of the DNA 1KT standard Fortran source, look for  University of Toronto IAS Report UTIAS Technical Note. 259, April 1986 Title : "Quick Reproduction of Blast-wave Flow-Field Properties of Nuclear, TNT and ANFO Explosions" by Clinton P.T. Groth. I found a PDF vi Google Search

Thanks for pointing this out--I've gone ahead and committed the suggested changes to the master branch,


Add doc for @configu-integrations/hashicorp-vault

Closes #589

Hi @Ritesh-Udgata ,
Here are the details for claiming your Hacktoberfest prizes! 🎉 Check out #465  (comment) for more information or simply fill out the form here: Claim Your Swag.
Remember, you only need to fill out the form once for all your PRs. 😊


E2E tests for Biometrics

Description
Add e2e tests for biometrics on iOS (ignore Android for now)
Acceptance Criteria

[ ] E2E tests cover onboarding for biometrics.
[ ] E2E tests cover where biometrics are requested from the users who are opted in.
[ ] E2E tests cover the cases where users opt out of biometrics after previously enabling them.
[ ] E2E tests if biometrics is enabled you don't see pin screen (recovery phrase screen might be an easy one to test this against)
[ ] E2E tests if biometrics is disabled you must enter pin (recovery phrase screen might be an easy one to test this against)
[ ] E2E tests are not flaky in CI --> run test N times and it passes M times (talk to Tom about N and M values)

Closing as react-native-keychain doesn't appear to support iOS simulators: https://github.com/oblador/react-native-keychain/issues/340#issuecomment-631681484.


Add construction assistant

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.吴高升 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Transform JSON output in stdout & stderr streams in Paramiko runner

Hm, looking at the existing code, it looks like Fabric runner does it in the Action system model.
In any case, I'm personally not a big fan of the whole Action system model abstraction so hopefully we can get rid of that once we deprecate and remove Fabric runner (I hope we will be able to do this for v1.0 once we fix all the issues in the new runner).


Use our sourceforge mirror for Metis and Mumps.

Fixes issue #459
Brief summary of changes
I uploaded zips of Metis and MUMPS to our Sourceforge project. Downloading from Sourceforge should be more reliable.
CHANGELOG.md (choose one)

[x] updated

This change is

Ready for review again.

I added a bunch of files. Can you review this again, @nbianco?


home-assistant: add missing ifaddr dependency

Motivation for this change
ifaddr is now a core dependency of home-assistant (https://github.com/home-assistant/core/blob/dev/setup.py#L46).
This isn't causing any failures in normal usage because ifaddr seemingly leaks into the runtime dependencies from a checkInput (presumably due to #118452).  In my environment I sometimes override doInstallCheck = false since the tests take a long time, which exposes the issue.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Copy of https://github.com/NixOS/nixpkgs/pull/152462


Document the need for Python 3.6

Document the need for Python 3.6 minimal supported version
Connected:

https://github.com/Nitrokey/pynitrokey/pull/121#issuecomment-1019248836
https://github.com/Nitrokey/pynitrokey/pull/158

Also mentioned in #219

Pasting relevant comment from #224:

(...) apparently only the Windows build is holding us up. Looking at the last packages list for the given release we can safely move further to even Python 3.9.

https://repology.org/project/python/badges

cc @robin-nitrokey

We should also describe the platforms we want to support in the developer guide.  I think you answered that question previously, but I can’t find it atm.  I think latest Ubuntu and latest Ubuntu LTS?

Yes, writing that down would be good. I think we had in mind support 2 LTS distributions back, which would mean 20.04 right now. Let me confirm that.

@robin-nitrokey Only the current LTS, so 22.04.

Helpful resources to establish the supported version:

https://repology.org/project/python/badges
https://repology.org/badge/vertical-allrepos/python.svg

Looks like the oldest one is on the current stable Debian - Python 3.9.2.


fix: add missing field to light client header

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] Commit messages follow the conventional commits spec
[x] If this is a code change: I have written unit tests.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Issue #1095, no response from maintainers so no approval on working plan

Motivation
I don't like this pattern of having a duplicate field for the same thing, but this type matches nearcore now, and these view types seem purely cosmetic in this lib where custom parsing wouldn't really fit (especially for this very simple change). Proposing this PR as it's the quickest workaround for #1095, but I don't feel strongly about any API change to resolve it if maintainers indicate they'd prefer something else.
Test Plan
Added test for this field's existence, verified schema against nearcore source, checked json response from RPC for this method
Related issues/PRs
Mentioned above

This test only exists in the NAJ package, and not in the providers test file. Do you want me to move it in this PR or will that be done in a separate PR when the duplicate files are deleted? @andy-haynes

This test I modified only exists in the NAJ package, and not in the providers test file. Do you want me to move it in this PR or will that be done in a separate PR when the duplicate files are deleted? @andy-haynes

@austinabell the json rpc light client proof test is in packages/accounts/test/providers.test.js at the moment (as it relies on the Account class), I don't have a strong opinion whether it stays in packages/near-api-js but it should be updated in accounts please


Using parts of Meltano?

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/959
Originally created by @emilie on 2019-09-05 15:02:57

I love the end-to-end videos, but if people want to use a part of Meltano, can they do that? For example, just airflow? or just the ELT? I know Meltano is opinionated but it's unclear if it's an all-or-nothing tool

View 9 previous comments from the original issue on GitLab


[github] Update CODEOWNERS for root files

What does this PR do?

Updates ownership of some files at the root of the repository.
Motivation

Reflect actual ownership of these files.
Additional Notes

n/a
Possible Drawbacks / Trade-offs

n/a
Describe how to test/QA your changes

n/a

/merge


Adding image labels and publishing

Description
There is no way to take the existing awsutils container and cleanly publish it to a registry. Additionally since we are using the derivations for the image tags we have no way of identifying what versions of pkgs are contained in the container without running it.
New Behavior

image push script
adding unstable pin to use the newest version of skopeo
pkg versions be included in image as label: com.nebulaworks.packages

Tests
Sample of published image in registry:
$ skopeo inspect docker://docker.io/sarcasticadmin/scratchpad:6bav52ynfcyz1cxb48bj4vbyrc1q7i8j
{
    "Name": "docker.io/sarcasticadmin/scratchpad",
    "Digest": "sha256:dd5894ee738ceed126d11fd36917f28589701c42c287b3a7aa7e85fbf7ffc248",
    "RepoTags": [
        "6bav52ynfcyz1cxb48bj4vbyrc1q7i8j",
        "9fs4f9khpgrk96z1dx52x94200f1psr2",
        "i32rn7xmkpxfy46562281hnp8zyqz68p",
        "sai0gh76j257mc74p5nf5nkmvpfs5l4f"
    ],
    "Created": "1970-01-01T00:00:01Z",
    "DockerVersion": "",
    "Labels": {
        "com.nebulaworks.packages": "awscli:1.17.13,bash:4.4,coreutils:8.31,curl:7.68.0,jq:1.6"
    },
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:6f29a11d541b258cbfb4956ccc442ac0ecf8a6c052f10d1ed0d6d6078ae30f2a"
    ],
    "Env": [
        "PATH=/bin/"
    ]
}

Closing in favor of #2


Changed the Aggregate Lambda to use a Delimiter approach

Hi Bill,
I finally figured out how to do a Pull Request.  :)
Here's my proposed change for the Aggregate Lambda.  The Lambda is now an expanded function that uses a static variable for the delimiter.  On first run, the delimiter is empty, and on subsequent passes, the delimiter is ", "
Pat

@patware Thanks!  This is a great addition.


Not able to agent with tool from example

i tried to run code from your example
@tool
def search_api(query: str):
# Add your logic here
return query
Initializing the agent with the OpenAI instance and other parameters
agent = Agent(
agent_name="Covid-19-Chat",
agent_description=(
"This agent provides information about COVID-19 symptoms."
),
llm=llm,
max_loops="auto",
autosave=True,
verbose=True,
stopping_condition="finish",
tools=[search_api],
)
Defining the task and image path
task = ("What are the symptoms of COVID-19?",)
Running the agent with the specified task and image
out = agent.run(task)
print(out)
i got error

and one more thing is there any blog or something to see working of multi agents with tools.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

@vaidikcs try another llm like Anthropic or Llama3Hosted, this has a parsing error but it did run!

@kyegomez @vaidikcs I'm having this problem as well using Groq with the OpenAIChat class. @tool definition looks like this:
@tool(name='dumb_string', return_string=True, return_dict=False)
def dumb_string(dumb_str: str):
    return f'this is dumb: {dumb_str}'

I've tried removing all params from @tool, different params, using just @tool(), etc.

@kyegomez got same error here

@Vits-99 @aimzieslol @nictuku no more tool decorator is needed, just the function with types, and doc strings.

@kyegomez thanks! But why running the Devin Example I get this error in tool parsing?
2024-07-21T11:16:58.305840+0200 Error parsing and executing JSON: Expecting value: line 1 column 1 (char 0)
The code I am running is this:
from swarms import Agent, OpenAIChat
import subprocess

# Tools in swarms are simple python functions and docstrings
def terminal(
    code: str,
):
    """
    Run code in the terminal.

    Args:
        code (str): The code to run in the terminal.

    Returns:
        str: The output of the code.
    """
    out = subprocess.run(
        code, shell=True, capture_output=True, text=True
    ).stdout
    return str(out)

def browser(query: str):
    """
    Search the query in the browser with the `browser` tool.

    Args:
        query (str): The query to search in the browser.

    Returns:
        str: The search results.
    """
    import webbrowser

    url = f"https://www.google.com/search?q={query}"
    webbrowser.open(url)
    return f"Searching for {query} in the browser."

def create_file(file_path: str, content: str):
    """
    Create a file using the file editor tool.

    Args:
        file_path (str): The path to the file.
        content (str): The content to write to the file.

    Returns:
        str: The result of the file creation operation.
    """
    with open(file_path, "w") as file:
        file.write(content)
    return f"File {file_path} created successfully."

def file_editor(file_path: str, mode: str, content: str):
    """
    Edit a file using the file editor tool.

    Args:
        file_path (str): The path to the file.
        mode (str): The mode to open the file in.
        content (str): The content to write to the file.

    Returns:
        str: The result of the file editing operation.
    """
    with open(file_path, mode) as file:
        file.write(content)
    return f"File {file_path} edited successfully."

# Agent
agent = Agent(
    agent_name="Devin",
    system_prompt=(
        "Autonomous agent that can interact with humans and other"
        " agents. Be Helpful and Kind. Use the tools provided to"
        " assist the user. Return all code in markdown format."
    ),
    llm=OpenAIChat(model_name="gpt-4o-mini", openai_api_key="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"),
    max_loops="auto",
    autosave=True,
    dashboard=False,
    verbose=True,
    interactive=True,
    tools=[terminal, browser, file_editor, create_file],
    code_interpreter=True,
)

# Run the agent
out = agent("Create a new file for a plan to take over the world.")
print(out)

I can then interact with it but it is not able to use the tools. Any suggestion?


Update bootstrap.sh script in cloud-native-toolkit-demos/multi-tenancy-gitops-mq to support Security & HA flags

We need to update https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-mq/blob/ocp47-2021-2/scripts/bootstrap.sh to support flags for enabling Security and HA components respectively.
This is dependent upon https://github.com/cloud-native-toolkit/multi-tenancy-gitops/issues/105 being completed first.
Currently, the only "activations" required are for Security, but HA is dependent on Security being enabled.
The resources required to be activated for this include but may not limited to the following:

multi-tenancy-gitops-services/operators/cert-manager/operator.yaml installing the correct Marketplace version, and not the Community version
multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/2-services/kustomization.yaml

argocd/operators/cert-manager.yaml
argocd/instances/cert-manager-instance.yaml

multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/1-infra/kustomization.yaml

argocd/namespace-openldap.yaml

Items from https://github.com/cloud-native-toolkit/multi-tenancy-gitops/issues/105 in their respective namespaces.

1. Activate OpenLDAP namespace via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/1-infra/kustomization.yaml#L10
2. Activate OpenLDAP instance via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/2-services/kustomization.yaml#L29
3. Activate CertManager Operator via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/2-services/kustomization.yaml#L31
4. Activate CertManager Instance via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/2-services/kustomization.yaml#L32
5. Activate all MQ-level CertIssuers and Certificates via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-mq/blob/ocp47-2021-2/0-bootstrap/argocd/single-cluster/3-apps/kustomization.yaml#L11
6. Activate CI Certificates via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-apps/blob/ocp47-2021-2/mq/environments/ci/kustomization.yaml#L2-L3 (only required if secured in that namespace)
7. Activate DEV Certificates via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-apps/blob/ocp47-2021-2/mq/environments/dev/kustomization.yaml#L2-L3 (only required if secured in that namespace)
8. Activate STAGING Certificates via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-apps/blob/ocp47-2021-2/mq/environments/staging/kustomization.yaml#L2-L3 (only required if secured in that namespace)
9. Activate PROD Certificates via uncomment https://github.com/cloud-native-toolkit-demos/multi-tenancy-gitops-apps/blob/ocp47-2021-2/mq/environments/prod/kustomization.yaml#L2-L3 (only required if secured in that namespace)
10. Once Hollis's current PR is merged, you will also need to activate the `mq-client-jks-password-secret` via uncomment similar to https://github.com/osowski-demos/multi-tenancy-gitops-apps/blob/ocp47-2021-2/mq/environments/prod/kustomization.yaml#L4


update readme for more usage reminder

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          10     10
  Branches        2      2
=====================================
  Hits           10     10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea5cbc...046aa3c. Read the comment docs.

Definitely a good add. I think its more appropriate in the "Usage" section rather than the "Why" section. I also changed up the sentence structure to be a little more clear IMO.


Generate parameterized types t

For a parameterized versioned type like
module V1 = struct
  type t = Foo.V1.t Bar.V2.t
end

we want, at the module top level, to generate
type t = Foo.t Bar.t constraint t = Stable.Latest.t

Currently, we're generating
type t = Stable.Latest.t

I've found a couple of instances where the missing type equality breaks compilation. The workaround is not to generate t using no_toplevel_latest_type and entering the definition above.

@psteckler can you add more context why we should prioritize this on the product eng team?

@bkase It's not a high-priority item, because there's a workaround.
Generating the type definition will make for simpler, more maintainable code.

@bkase See the Answer and Query modules in Mina_ledger.Sync_ledger, where this issue shows up.


Update access-cluster-api.md

Updated listPodForAllNamespaces method call, and println.

/check-cla

@vishalbiradar I'm going to close this PR for now, feel free to open once you get the email situation / CLA resolved.
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement
Let me know if you have any questions!
/close


refactor: test_read.py

Would be great to refactor test_read.py - https://github.com/openclimatefix/pv-site-datamodel/blob/main/tests/test_read.py
as the file is a it long.
Could

make a folder in tests called read
divide up the tests by which file they come from, would be about 3 or 4 seperate files

Why?
Makes it more readable, and easy to run a smaller amount of tests

Hi @peterdudfield,
I've refactored the test_read.py as follows :
tests/read/

test_get_sites.py
Classes:
TestGetAllSites
TestGetSitesByCountry
TestGetSiteByUUID

test_get_site.py
Functions:
test_get_site_group_by_name
test_get_site_group_by_name_new_group
test_get_all_users
test_get_all_site_groups
test_get_site_from_user
test_get_site_list_max
test_get_site_list_min

test_get_latest_status.py
Classes:
TestGetLatestStatus

test_get_PV_generation.py
Classes:
TestGetPVGenerationByUser
TestGetPVGenerationBySites

test_get_latest_forecast_values.py
Functions:
_add_forecast_value
test_get_latest_forecast_values
test_get_latest_forecast_values_day_head
test_get_latest_forecast_values_day_head_with_timezone

test_get_api_req.py
Functions:
test_get_all_last_api_request
test_get_api_requests_for_one_user
test_get_api_requests_for_one_user_start_datetime
test_get_api_requests_for_one_user_end_datetime

test_get_user_by_email.py
TestGetUserByEmail

Is this fine and should I send out PR?

Yea, thanks for doing this, a pr would be great
some small comments
I'd be tempted to put 1 and 2 together, as they are all sites tests.
4. test_get_PV_generation.py --> est_get_generation.py
6.req to requests

@peterdudfield Thank You,
Can you please review into the PR.


Release v6.44.0 removed support for cf oauth-token with client credentials

Please fill out the issue checklist below and provide ALL the requested information.

[x] I tried updating to the latest version of the CF CLI to see if it fixed my problem.
[x] I attempted to run the command with CF_TRACE=1 to help debug the issue.
[x] I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with
My team's deployment tooling relies on the cf oauth-token command. We also authenticate as a client using cf auth --client-credentials. As documented in the 6.44.0 release, this combination no longer works.
What happened
We receive a Credentials were rejected, please try again error message when calling cf oauth-token while authed as a client.
Expected behavior
The command prints a valid oauth token without erroring.
To Reproduce
Steps to reproduce the behavior; include the exact CLI commands and verbose output:

Run cf auth --client-credentials $CLIENT_ID $CLIENT_SECRET
Run cf oauth-token
Observe the Credentials were rejected, please try again error

Provide more context
This has been reproduced on Mac OS X 10.14.3, running CLI 6.44.1+c3b20bfbe.2019-05-08
The CC API version was 2.134.0 (on PWS)
My team is using cf oauth-token to implement our own version of cf curl that supports the -f flag. As you've recently added support for that flag to the built-in cf curl command, we could switch to that, but we'd prefer not to have to patch the past few versions of our product for this backwards-incompatible change.
Note: As of January 2019, we no longer support API versions older than CF Release v284/CF Deployment v1.7.0 (CAPI Release: 1.46.0 (APIs 2.100.0 and 3.35.0).

Hi Matt,
Sorry we broke your workflow. We intend to fix this but I want to share the current behaviour and see if there is any feedback on our proposed approach.
The reason it broke is because of a change in 6.44.0 around how client credentials were handled, and how this interacts with the existing behaviour of cf oauth-token.

When authenticating with client credentials version 6.44.0 of the cli includes a change to remove the client secret from the config file.
The current behaviour of the cf oauth-token command is not (as you might expect) to return the current token, but to always refresh the token and output the refreshed token.
UAA clients do not have a refresh token. Prior to 6.44.0 the cli would re-authenticate using the client id and secret from the config file. However as the secret has been removed the authentication will now fail.

cf-oauth-token behaviour prior to 6.44.0

token status
client credentials
username & password

current
re-authenticate and return
refresh and return

expired
re-authenticate and return
refresh and return

no token (not logged in)
fail
fail

cf-oauth-token current behaviour (6.44.1)

token status
client credentials
username & password

current
fail
refresh and return

expired
fail
refresh and return

no token (not logged in)
fail
fail

cf-oauth-token proposed behaviour

It's not possible to re-authenticate and return a new token when using client credentials. We no longer have access to the client secret to do this.
We can return the current token when using client credentials. We have the option here of either returning the token always (including when it has expired, causing a subsequent call using the token to fail) or checking the token validity and failing when the token is invalid. We're leaning towards the later.
For users we can either keep the existing behaviour and always refresh the token, or return the existing token without refreshing. We're leaning towards always refreshing the token so that we are reducing the risk of breakage in case someone relies on the current side-effect of the token being refreshed.

token status
client credentials
username & password

current
return current token
refresh and return

expired
fail
refresh and return

no token (not logged in)
fail
fail

While we hope to implement this soon, we'd love to hear any feedback on the proposed approach above.
Thanks,
Andrew.

Thanks for the quick response, @acrmp. The solution you're leaning towards (i.e. return the token if its valid and error otherwise) sounds good to us. In our case, we'll always have authenticated recently so it shouldn't be an issue

Closing this issue because we've released v6.45.0 which includes this update to oauth-token.  Please do not hesitate to reach out if any questions, thanks.


Need to not cache result if there is an exception

The approach I plan to take here -

Modify Cache.store so that it returns the key rather than None
When LanguageModel generates a cacheable entry, it passes that key up to the Invigilator
When the Invigilator does its "valid_answer" check, if it's bad, use the cache key to delete the entry

We could hold-off on writing to the cache at all, but that's bit more complex so I think this is easier.


User Interface broken after addition of ant-d

Description
After the introduction of the ant-d package to add filters, the existing interface design has broken.
Examples:
Before

Present

There seems to be unnecessary padding, margin, and fonts that have been overridden.
We need to make importing ant-d doesn't break other UI interfaces.
Acceptance criteria

Make sure the UI is not broken by ant-d css

It looks like adding ant-design has overridden the styles of the website.
Before:

After:

The alignments have also broken in navbar and font size changes in the footer
Do you know a way to prevent ant-design to override global styles?
@Abhikumar98

We might have to remove ant-design

@subeshb1  I've fixed the styling issues caused by due to antd.

@Abhikumar98
We might have to look for an alternative to ant-design
In dark mode, the theme picker inputs color is overridden and shown white.
The font's in the footer are smaller.
The icons size have been made smaller
The padding in div has been changed
Since we have a lot of issues, it's better to use another library or build our own.

@subeshb1  Got it.
I'll look into this.

Thanks, @Abhikumar98. Happy to have you as a contributor :)

I'll be removing ant-design for now until we look for another alternative

Closing this as this has been stale for 2 days. Revisiting this idea


Socket hung up, every 5 seconds, only on cluster (dev is fine, same code)

So I've been struggling with an issue for the past couple of days.
Every time I make a connection (from a variety of clients), the client will connect, and then around 5s later I get:
Mon Jul 08 2019 15:42:06 GMT+0000 (UTC) - handshake
Mon Jul 08 2019 15:42:07 GMT+0000 (UTC) - connection
Mon Jul 08 2019 15:42:11 GMT+0000 (UTC) - closure
1562600531990 - Origin: Worker (PID 52)
[Warning] SocketProtocolError: Socket hung up
at SCServerSocket._onSCClose (/usr/src/node_modules/socketcluster-server/scserversocket.js:249:17)
at WebSocket.<anonymous> (/usr/src/node_modules/socketcluster-server/scserversocket.js:80:10)
at emitTwo (events.js:126:13)
at WebSocket.emit (events.js:214:7)
at WebSocket.emitClose (/usr/src/node_modules/socketcluster-server/node_modules/ws/lib/websocket.js:180:10)
at Socket.socketOnClose (/usr/src/node_modules/socketcluster-server/node_modules/ws/lib/websocket.js:802:15)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at TCP._handle.close [as _onclose] (net.js:561:12)

As far as I can see, it is a warning, and the worker itself isn't crashing. Then the client auto reconnects, and it just keeps going in circles. Also this is happening on every connection.
Now, when running this locally, it works fine. The problem only seems to happen when running it from our EKS cluster. This was running fine previously, so I've rolled back the commits to a couple of places, I've stripped out everything I can think of both client and server side (eg login and subscription handling).
All that remains is the broker / server / worker controllers, and within the worker controller it logs out the various basic events eg handshake / connection / error / closure.
It feels like there is some kind of timeout happening, due to it ALWAYS being 5 seconds after the initial handshake / connection. Any idea how I can debug this?
Due to the workflow of deploying it to the cluster everytime, via a docker build and kubectl apply its quite painful xD

Ok so it turns out this was the load balancer with an idle timeout of 5s.

I previously had some mocked data emitting every second, which was keeping the connection alive. Having removed this, and the ping / pong events not happening in time, the load balancer was severing every connection after 5s.


Flow typed createFragmentContainer

https://twitter.com/estejs/status/968306738775633926

For now, Page.js is hacked, but that's ugly.

https://github.com/facebook/relay/blob/master/packages/react-relay/modern/__flowtests__/ReactRelayFragmentContainer-flowtest.js
This does not work yet. Why?

OK, flow-typed is good enough with $FlowFixMe on variables.


Agent version mapping to TFS Version

Question: I am writing an extension for on-prem agent, but I need to specify TFS 2015 Update 2 and higher.  How can I map this to an agent version?  Is there a list of which agent was released with which version of TFS?

1.95 is TFS 2015 Update 2.
Closing this issue. I added context to existing issue that is tracking documentation gaps.


cmd/go: "An unrecognized flag" is thrown when trying to 'go get'

What version of Go are you using (go version)?

$ go version
go version go1.12.7 darwin/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?

Ran GO111MODULE=on go get github.com/onsi/ginkgo/ginkgo. I tried go getting other packages, but got the same output.

What did you expect to see?
I expected to get no output and the package to successfully install.
What did you see instead?
The following output was given to me:
go: finding github.com/onsi/ginkgo/ginkgo latest
# runtime/cgo
xcrun: error: unrecognized option: -E
Usage: xcrun [options] <tool name> ... arguments ...

Find and execute the named command line tool from the active developer
directory.

The active developer directory can be set using `xcode-select`, or via the
DEVELOPER_DIR environment variable. See the xcrun and xcode-select manual
pages for more information.

Options:
  -h, --help                  show this help message and exit
  --version                   show the xcrun version
  -v, --verbose               show verbose logging output
  --sdk <sdk name>            find the tool for the given SDK name
  --toolchain <name>          find the tool for the given toolchain
  -l, --log                   show commands to be executed (with --run)
  -f, --find                  only find and print the tool path
  -r, --run                   find and execute the tool (the default behavior)
  -n, --no-cache              do not use the lookup cache
  -k, --kill-cache            invalidate all existing cache entries
  --show-sdk-path             show selected SDK install path
  --show-sdk-version          show selected SDK version
  --show-sdk-build-version    show selected SDK build version
  --show-sdk-platform-path    show selected SDK platform path
  --show-sdk-platform-version show selected SDK platform version

It looks like you have CC and CXX set to xcrun. How are those set? Is that intentional?
The go command uses the C compiler to type check and build cgo code. The program that CC points to must have a command line interface similar to gcc or clang, and it must print errors in the same format.

Oh well that's interesting:
$ echo $CC
xcrun clang
$ echo $CXX
xcrun clang++

not sure how it was set though, but I am guessing the xcrun should be omitted?

Not sure how those would have been set. Maybe check .profile, .bashrc, or related files?
I'll close this since it seems to be working.


Cryptic clue "The effects of this fire are magnified." doesnt work

Describe the bug
The cryptic hard clue scroll "The effects of this fire are magnified." does not trigger the clue solver
To Reproduce
Steps to reproduce the behavior:

Get a hard clue scroll
if it says "The effects of this fire are magnified."
See error

Expected behavior
The clue scroll solver should display the panel at top right and explain the clue scroll
Environment (please complete the following information):

OS: Windoes 10
RuneLite version: 1.5.11
Launcher version: 1.5.2

Additional context
Cryptic clue wiki link: https://oldschool.runescape.wiki/w/Treasure_Trails/Guide/Cryptic_clues#/media/File:Cryptic_clue_-_dig_Kebos_Swamp.png

Duplicate of #7275


Improve DMN modeling UX for Camunda Cloud

Is your feature request related to a problem? Please describe.
In Camunda Cloud ~1.3.0~ 1.4.0, we will support evaluating DMN decisions in Zeebe. Since Zeebe will use a different DMN engine than Camunda Platform and doesn't support all features from the Platform, we should remove some properties to improve the modeling UX.
Describe the solution you'd like
In order to improve the DMN UX for Zeebe and the new DMN engine, we should adjust the following parts:

decisions (in DRG view):

remove the property Version Tag - not supported by Zeebe
remove the property History Time to Live - not supported by Zeebe
remove the description of the Id property (similar to the Id property of processes) - in Zeebe the ID will be serialized as decisionId (in Zeebe, keys are the identifiers of the record entity)
tracked via https://github.com/bpmn-io/dmn-js-properties-panel/issues/29

decision table:

remove the property to select the Expression Language on inputs (i.e. input expressions), input entries, and output entries - Zeebe supports only FEEL
remove the property Input Variable on inputs - in FEEL, the input value can be accessed by using ? if needed
remove the options integer + long + double in favor of a new option number on selecting the Type of inputs and outputs - in FEEL, there is only a number type (represented as BigDecimal)
add the options time + dateTime + dayTimeDuration + yearMonthDuration + Any on selecting the Type of inputs and outputs - in order to cover the most common types of FEEL

literal expression:

remove the property to select the expression language - Zeebe supports only FEEL
remove the options integer + long + double in favor of a new option number on selecting the Variable Type  - in FEEL, there is only a number type
add the options time + dateTime + dayTimeDuration + yearMonthDuration + Any on selecting the Variable Type of inputs and outputs - in order to cover the most common types of FEEL

Describe alternatives you've considered
No changes. It should be possible to deploy a DMN with the current modeler if no unsupported features are used. Otherwise, the deployment with the DMN is rejected.
Additional context
None.

@barmac we should plan a few more adjustments to improve the UX:
Restricting the naming/usage of the decision ID

currently, the decisionId must be a valid QName
but in a DMN for Camunda Cloud, the decisionID may be referenced in a dependent decision (i.e. to access the decision result/output of a required decision)
the FEEL engine has the limitation that a variable should not contain any special characters or symbols (e.g. whitespace, dashes, etc.), except the variable name is escaped
if the decisionId has a special character (e.g. my-decision) and it is used in an input expression then the FEEL expression can't be parsed and the DMN is rejected by Zeebe
it works for Camunda Platform 7 because their DMN engine uses the output names instead of the decisionId (but this behavior is not correct according to the DMN specs)
we have the same issue for output name (i.e. the name of a decision table output) and variable name of decision literal expressions

Suggestion/idea:

add a new validation for the decisionId (and the other properties) and limit the value to alphanumeric names

Avoiding differences of the decision ID and the output name

a decision table can have one or more outputs and each output has an output name
currently, the output name can be named independently from the decisionId
but in a DMN for Camunda Cloud, the output name is not used if the decision table has only one output
instead, the DMN engine uses the decisionId. It uses the output names only if the decision table has more than one output.
if the output name is different from the decisionId and the output name is used in an input expression then the FEEL expression/the DMN decision may fail or return an unexpected result
it works for Camunda Platform 7 because their DMN engine uses always the output name instead of the decisionId (but this behavior is not correct according to the DMN specs)

Suggestion/idea:

the output name is not editable if the decision table has only one output

cc: @nikku

Makes a lot of sense @saig0.
@barmac please correct me on the following assessment:

Restricting the naming/usage of the decision ID

Straight forward to implement.

Differences of the decision ID and the output name

A little harder to implement.

Avoiding differences of the decision ID and the output name

As I understand the engine will ignore the output name, right? @saig0.
So we could argue here that this is a case for linting (tell users their output name is going to be ignored for single output column tables).

I think we can change the ID validation pretty easily. However, I believe in this case linting is more suitable as the DMN is still valid but the engine cannot handle the ID (yet?). The same can be applied to the single output decision -> we should be able to model DMN as we want but get a warning if it's not supported by the engine.

we should be able to model DMN as we want but get a warning if it's not supported by the engine.

That approach would follow the principles that we defined for validation and linting:

Direct validation only for entries that would break the diagram in the modeler. Behavior: we ignore the input, refuse to change the XML, and as result keep the previous (valid) state.
Everything else is part of the linting scope. No additional direct validation in the properties panel.

However, so far there is no DMN linting in place. So, doing things differently here is not preferred but is an option.

Hey @saig0, I created follow-up issues for your suggestions in https://github.com/camunda/camunda-modeler/issues/2525#issuecomment-1041446764:

https://github.com/camunda/camunda-modeler/issues/2836
https://github.com/camunda/camunda-modeler/issues/2835


584112B0 - Call of Juarez: Gunslinger

Marketplace
Tested on https://github.com/xenia-canary/xenia-canary/commit/145870e2237c1dacb23491f6b5eb6869f476c5b1
Issues:
Crash host at startup
Log:
canary
Screenshots:
N/A

Ingame with https://github.com/xenia-canary/xenia-canary/commit/ca63206cc7ace405e4c8c24d083cb69fb3c91bfb
Tested on https://github.com/xenia-canary/xenia-canary/commit/5a3929109332afc16eb6e9ef723c1dd0aa53d461

Log: canary


[Dialog] Never closes on clicks outside the dialog window or on Esc

Why does Dialog component cannot be closed by mouse clicking outside the Dialog window? In your examples they close all right. But the same Dialog on my site doesn't close. Actually onRequestClose is even never called on mouse clicks outside Dialog window. Here is my code:
    getInitialState() {
        return {
            isDialog: false,
        };
    },

   render() {
      return (
                    <Dialog
                        title={i18n.titl;e}
                        actions={null}
                        modal={false}
                        open={this.state.isDialog}
                        onRequestClose={ ()=>{
                            console.log('isDialog', this.state.isDialog);
                            this.setState({
                                isDialog: false
                            })
                        }}
                        >
                        Alert
                    </Dialog>
      )
   }

Also, a warning is thrown on Dialog open:

Warning: a div tag (owner: Overlay) was passed a numeric string value for CSS property left (value: 0) which will be treated as a unitless number in a future version of React.

Why does it happen? How to enable close on mouse clicks outside Dialog?

I've myself figured out what caused the issue.
I didn't import and call react-tap-event-plugin after refactoring my code. After doing so Dialogs closes all right.
import injectTapEventPlugin from 'react-tap-event-plugin';
injectTapEventPlugin();

However, while searching for that bug, I've found a strange behavior of a Dialog component. I'd like to know if it is intentional behavior or some kind of bug.
I have 10+ Dialog components on a page. Each of them has onRequestClose method. I've included console.log in every one. The scene looks as follows:
    getInitialState() {
        return {
            isDialogA: fasle,
            isDialogB: fasle,
            isDialogC: fasle,
            isDialogD: fasle,
            .... so on 10+ times
        };
    },

                        onRequestClose={
                            function() {
                                console.log('[isDialog + suffix]:', this);
                                this.setState({
                                    [isDialog + suffix]: false
                                });
                            }.bind(this)
                        }

Now, when neither Dialog is open and I press Esc button, for some reason onRequestClose method of each and every Dialog is executed! This is an output in dev console:
[isDialogA]: Constructor {props: Object, context: Object, refs: Object, updater: Object, state: Object…}
[isDialogB]: Constructor {props: Object, context: Object, refs: Object, updater: Object, state: Object…}
[isDialogC]: Constructor {props: Object, context: Object, refs: Object, updater: Object, state: Object…}
[isDialogD]: Constructor {props: Object, context: Object, refs: Object, updater: Object, state: Object…}
[isDialogE]: Constructor {props: Object, context: Object, refs: Object, updater: Object, state: Object…}
[isDialogF]: Constructor {props: Object, context: Object, refs: Object, updater: Object, state: Object…}
... and so on ...

Why does it happen? It means that this.setState is called 10+ times and my root App component is rendered 10+ times! How can it be? Could you please explain such a behavior?
Also, the warning still remains:

Warning: a div tag (owner: Overlay) was passed a numeric string value for CSS property left (value: 0) which will be treated as a unitless number in a future version of React.

@wzup that's because the current implementation of the close on escape key press doesn't check the previous state of the dialog (if it is open or close) before setting the close state to false.
What I would suggest you is that you can minimize your use of dialogs by combining them into dialogs of same type and setting their inner data using a prop or state and update it each time you want a new dialog, it would be optimised and would follow the react ideology of reusable components :smile:

@wzup Can we close this issue?

Closing issue due to inactivity

Hi I am facing this issue and have tried the above mentioned methods.
Even
import injectTapEventPlugin from 'react-tap-event-plugin';
injectTapEventPlugin();`


a module teaching folder

pls review the pr i have made the changes

pls review my pr as i made the changes


added windows 11

after reading this article, i confirmed windows 11 is supported

Learn Build status updates of commit 6be41e6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/security/threat-protection/security-policy-settings/load-and-unload-device-drivers.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


add various actions

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[ ] No, because:

Have you updated all relevant documentation?

[ ] Yes
[ ] No

Description
Add various redux actions for commercial purposes
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Could we hold on merging this till 3.6 is released in a bit?

Good to go on this when it's ready!


Release 3.1.5 does not contain all commits since last release

Hey @rochacbruno, I updated to the latest version of dynaconf this morning but the strategies implementation is not included. Took a look at the latest release commit and it says it doesn't belong to a branch in this project and was likely created from a fork? Looking at the parent of that commit and it is after the prefix strategy implementation but that commit doesn't seem to be included.
Any idea what has happened here?

Hi,
3.1.5 was a z-stream release (a patch release for version 3.1.z)
It included just bug fixes, no new feature was added. https://github.com/rochacbruno/dynaconf/releases/tag/3.1.5
As master has some new features

Filter strategies (ready)
Selective validation (ready)
Conditional variable attribution #632 (in progress)
More mergin strategies (probably with schema) #299 (todo)

More bug fixes:

Parse of Jinja and format fields  #642
Django gettext lazy #648

This will be a new minor (y) release and is included in 3.2.0 milestone https://github.com/rochacbruno/dynaconf/issues?q=is%3Aissue+sort%3Aupdated-desc+milestone%3A3.2.0+
I wish to release 3.2.0 soon, but I need to address the features on the roadmap.
If it takes too long, I can release a 3.2.0 with what we already have testes and then a 3.3 comes later.

@rochacbruno Aha thanks for clarifying! Will close this

@zzZIMAWAKE if you need we can release 3.2.0 soon, otherwise will wait for more implementation before releasing it.