Argo dag failFast option not working Argo version: 2.12.3

Argo dag failFast option not working
Argo version: 2.12.3
Steps to Reproduce
Execute following example: https://github.com/argoproj/argo-workflows/blob/master/examples/dag-disable-failFast.yaml
Set failFast to true.
Actual Behaviour
All steps in the pipeline are scheduled and executed even though one step failed.
Expected Behaviour
If one of the steps in the pipeline fails other steps should not be scheduled, only the ones which are currently running should be finished.

Argo version: 2.12.3

The UI from your screenshot is not the one from v2.12. Are you still using argo-ui? If so, that has been deprecated. Please see the getting started to use the new UI.
I'll take a look at failFast meanwhile.

I was able to reproduce... looking into it

Thank you Simon

See #5398 for further discussion


Question: ListBoxItem common visual states

Hello,
What common visual states support the ListBoxItem in ListBox?
I have found in the ListBoxItem template the following states: Normal, Disabled, PointerOver, Pressed, Selected, SelectedUnfocused, Focused, SelectedPointerOver, SelectedPressed. Are these all visual states?
Thanks

Yes, these are visual states.  A control only supports states which are present in its template, so if your looking at the template that is an exhaustive list.  Also, we do encourage people to use ListView instead of ListBox where possible.

Yes, these are visual states.  A control only supports states which are present in its template, so if your looking at the template that is an exhaustive list.  Also, we do encourage people to use ListView instead of ListBox where possible.


hello [Feature] 🌈 vision models doesnt follow openai api schema

Describe the problem related to the feature request
im getting the follow error when trying to ask questions about images
open-webui  | ERROR:apps.openai.main:0, message='Attempt to decode JSON with unexpected mimetype: text/plain; charset=utf-8', url=URL('http://<IP_ADDRESS>:8082/v1/chat/completions')
open-webui  | Traceback (most recent call last):
open-webui  |   File "/app/backend/apps/openai/main.py", line 469, in generate_chat_completion
open-webui  |     response_data = await r.json()
open-webui  |                     ^^^^^^^^^^^^^^
open-webui  |   File "/usr/local/lib/python3.11/site-packages/aiohttp/client_reqrep.py", line 1176, in json
open-webui  |     raise ContentTypeError(
open-webui  | aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/plain; charset=utf-8', url=URL('http://<IP_ADDRESS>:8082/v1/chat/completions')

Uh-oh! There was an issue connecting to Precise-vision.
text input must be of type `str` (single example), `List[str]` (batch or single pretokenized example) or `List[List[str]]` (batch of pretokenized examples).

Describe the solution you'd like
upload images and ask about them
Describe alternatives you've considered
ollama vision models working fine
Additional context
No response

It's fine on NextChatWeb, please Check Your Code

It's fine on NextChatWeb, please Check Your Code

hello and thanks for your time and response, the post that open webui does https://github.com/open-webui/open-webui is the follow
POST /openai/chat/completions HTTP/1.1
Host: localhost:80
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:126.0) Gecko/20100101 Firefox/126.0
Accept: */*
Accept-Language: en-US,en;q=0.5
Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6ImMzYjMyY2VjLTU2YjQtNDEzYy1hZTk1LWFhNzU4NmE1ZjlmNyJ9.-BDsYaPd-Iz431VELDVc0FOaaOvNpgKqXzZuVPXEaXc
Content-Type: application/json
Origin: http://localhost:80
Connection: keep-alive
Priority: u=4
Accept-Encoding: gzip, deflate
Content-Length: 2774263

{"model":"Precise-vision","stream":true,"stream_options":{"include_usage":true},"messages":[{"role":"user","content":[{"type":"text","text":"describe the image"},{"type":"image_url","image_url":{"url":"data:image/jpeg;base64,/9j/4AAQSkZJRgABAgAAZABkAAD/7AARRHVja3kAAQAEAAAAZAAA/...(VERY LONG STRING...)4/KoP8ru/wCn7nvf/wCJv2bf/wChjf8A/VZ07/vbO1r/AMK5f/4X1X9e7/6Hpb8a/9k="}}]}],"citations":false,"chat_id":"cf2e96eb-f693-4e67-822c-1a271fb51dd1"}

and the response it get back is the follow:
HTTP/1.1 500 Internal Server Error
date: Fri, 28 Jun 2024 23:54:19 GMT
server: uvicorn
content-type: application/json
access-control-allow-origin: *
access-control-allow-credentials: true
x-process-time: 0
Content-Length: 169

{"detail":"text input must be of type `str` (single example), `List[str]` (batch or single pretokenized example) or `List[List[str]]` (batch of pretokenized examples)."}


Ninja support

Closed.
If this issues still persists in the current 0.11.0-beta4, feel free to reopen this one or create a new one.


improvement add max_failure_num to skip tests when too much failure

Proposed changes
Issue Number: close #xxx
Problem summary
Add a new config max_failure_num for regression test.
If the failure tests num exceeds this config, all following test cases will be skipped.
This is to save the test env resource and do fast quit when encountering error.
And for p0/p1, the max_failure_num is set to 50.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


up logs isn't finding all log entries

Prerequisites

[x] I am running the latest version. (0.7.8-pro)
[x] I searched to see if the issue already exists.
[x] I inspected the verbose debug output with the -v, --verbose flag.
[x] Are you an Up Pro subscriber?

Description
up logs isn't finding all log entries when compared to awslogs.
Steps to Reproduce
Please refer to this repo to reproduce the issue: https://github.com/asavoy/up-logs-issue and the test script https://github.com/asavoy/up-logs-issue/blob/master/test.sh

The lambda function calls console.log() on each invocation
The test script calls the function 100 times, assuming the function has been deployed.
Note that ab is used to send 100 concurrent requests, and it doesn't report any failed or non-identical responses
up logs finds 31 log entries
awslogs finds 98 log entries
When I use the CloudWatch Logs Web UI it looks like I see 98 entries too

I can swap over to use awslogs but thought it would be worth raising this issue.
Here's a dump of the terminal output:
$ ./test.sh
++ up url
+ ab -c 100 -n 100 https://j2zv02ct9h.execute-api.us-west-1.amazonaws.com/staging/
This is ApacheBench, Version 2.3 <$Revision: 1826891 $>
Copyright 1996 Adam Twiss, Zeus Technology Ltd, http://www.zeustech.net/
Licensed to The Apache Software Foundation, http://www.apache.org/

Benchmarking j2zv02ct9h.execute-api.us-west-1.amazonaws.com (be patient).....done

Server Software:
Server Hostname:        j2zv02ct9h.execute-api.us-west-1.amazonaws.com
Server Port:            443
SSL/TLS Protocol:       TLSv1.2,ECDHE-RSA-AES128-GCM-SHA256,2048,128
TLS Server Name:        j2zv02ct9h.execute-api.us-west-1.amazonaws.com

Document Path:          /staging/
Document Length:        16 bytes

Concurrency Level:      100
Time taken for tests:   18.173 seconds
Complete requests:      100
Failed requests:        0
Total transferred:      68000 bytes
HTML transferred:       1600 bytes
Requests per second:    5.50 [#/sec] (mean)
Time per request:       18172.749 [ms] (mean)
Time per request:       181.727 [ms] (mean, across all concurrent requests)
Transfer rate:          3.65 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:       74  867 262.9    960    1009
Processing:   261 8480 2445.4   9103   11516
Waiting:      261 8479 2448.8   9102   11516
Total:       1009 9347 2544.4  10064   12473

Percentage of the requests served within a certain time (ms)
  50%  10064
  66%  10789
  75%  11263
  80%  11454
  90%  11687
  95%  11899
  98%  12109
  99%  12473
 100%  12473 (longest request)
+ echo 'Expect 100 complete requests and 0 failed requests'
Expect 100 complete requests and 0 failed requests
+ echo 'Wait for CloudWatch to catch up'
Wait for CloudWatch to catch up
+ sleep 60
+ up logs -S 1h 'message = "test"'
+ wc -l
      30
+ echo 'Should expect 100 logs found'
Should expect 100 logs found
+ awslogs get /aws/lambda/up-logs-issue --start 1h -f '{ $.message = "test" }'
+ wc -l
      98
+ echo 'Should expect 100 logs found'
Should expect 100 logs found

hmm interesting, thanks for the detailed report! I'll see if I can replicate

@tj Thanks! The fix in v0.8.1 resolves the issue. 🎉

awesome :D thanks again!


Make it possible to use egui-remixicon with older/newer egui version (and bump versions)

Closes #1
Thought it may be just as good to bump egui (and package) version to make it simpler to release a new one.
I can naturally remove the second commit if you prefer.

Awesome!
I think you did a good job, thanks!

I have fixed the path of the font file.


feat: UI Performance Infra setup v1

Description

Add an utility to run performance traces and generate reports
Add ui performance tests to /ok-to-test
Add a basic performance test and spit out summary of the run

Fixes #9677
Type of change
Enhancement to CI, work in progress.
How Has This Been Tested?
Tested the profile script.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: ui-performance-infra-v1

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.23 (0)
37.08 (-0.01)
34.08 (0)
55.74 (0)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

/ok-to-test sha=8ac146a

/ok-to-test sha=8ac146a

/ok-to-test sha=ab46db3

/ok-to-test sha=ab46db3


vscode-extensions.mgt19937.typst-preview: 0.11.4 -> 0.11.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Enter-tainer/typst-preview-vscode/releases.
meta.description for vscode-extensions.mgt19937.typst-preview is: Typst Preview is an extension for previewing your Typst files in vscode instantly
meta.homepage for vscode-extensions.mgt19937.typst-preview is: https://github.com/Enter-tainer/typst-preview-vscode
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.11.6 with grep in /nix/store/xyhpvk7hc262rwrdfxnkgf1y3lnjgza7-vscode-extension-mgt19937-typst-preview-0.11.6
found 0.11.6 in filename of file in /nix/store/xyhpvk7hc262rwrdfxnkgf1y3lnjgza7-vscode-extension-mgt19937-typst-preview-0.11.6

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

vscode-extensions.mgt19937.typst-preview

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xyhpvk7hc262rwrdfxnkgf1y3lnjgza7-vscode-extension-mgt19937-typst-preview-0.11.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vscode-extensions.mgt19937.typst-preview https://github.com/r-ryantm/nixpkgs/archive/7fc78a816dffb8bfbc61ef9422a5be98cd3bd672.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7fc78a816dffb8bfbc61ef9422a5be98cd3bd672#vscode-extensions.mgt19937.typst-preview

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xyhpvk7hc262rwrdfxnkgf1y3lnjgza7-vscode-extension-mgt19937-typst-preview-0.11.6
ls -la /nix/store/xyhpvk7hc262rwrdfxnkgf1y3lnjgza7-vscode-extension-mgt19937-typst-preview-0.11.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

vscode-extensions.mgt19937.typst-preview

Maintainer pings
cc @drupol for testing.

@ofborg build typst-preview vscode-extensions.mgt19937.typst-preview typstyle


Add support for VK_EXT_host_image_copy to the mock icd

In preparation for adding validation to VVL

CI Vulkan-Tools build queued with queue ID 21598.

CI Vulkan-Tools build # 1091 running.

CI Vulkan-Tools build # 1091 passed.

Should just need to update the test to include the capability to make CI pass

CI Vulkan-Tools build # 1093 running.

CI Vulkan-Tools build # 1093 passed.


ProjectExtensionsElement doesn't do correct comparison for new and old value

Steps to reproduce

Open Web Application project (ASP .NET Web Application (.NET Framework)) (or create if you don't have one)
Add new class to this project
Click "Save All" button.
Close VS

Expected  behavior
.csproj.user file is not updated after this operation.
Actual behavior
.csproj.user file is updated after this operation.
Where problem is?
The problem is in the ProjectExtensionsElement.cs code in the method 'public string this[string name].set()' in this line:
if (idElement.InnerXml != value)
Here we compare serialized value of Xml in memory and new value. If it is the same we do nothing, otherwise we overwrite new value and mark node as a 'dirty' which causes re-write *.user file. Comparison is not correct, because InnerXml also adds schema information in the serialized string, but 'value' doesn't have this information. In this case this condition always 'true', even though XMLs are the same. Example:
InnerXml: <FlavorProperties GUID="{349c5851-65df-11da-9384-00065b846f21}" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"><WebProjectProperties><StartPageUrl></StartPageUrl><StartAction>CurrentPage</StartAction> .... and so on
Value: <FlavorProperties GUID="{349c5851-65df-11da-9384-00065b846f21}"><WebProjectProperties><StartPageUrl></StartPageUrl><StartAction>CurrentPage</StartAction>.... and so on

Fallout from #699, probably, same as #1457 (but more severe).


[Lake][Fetching vs Joining] Fetch available data from subgraph rather than joining w/ sql.

Background / motivation

It's easier to just fetch the data already from subgraph rather than perform a join (more costly too).
These, shouldn't have to be obtain through a join with the predictions table.
{etl_bronze_pdr_predictions_table_name}.pair as pair,
{etl_bronze_pdr_predictions_table_name}.timeframe as timeframe,
{etl_bronze_pdr_predictions_table_name}.source as source,

The issue here too, is that in SQL there is 1 slot event being joined <= N prediction events. Again, costly. This is being done as a left join, but it would be good to check the results of bronze_pdr_slots.py as a way to verify this.

TODOs / DoD

Review this query and it's current results/accuracy.
Simplify this query by just getting this data from subgraph.
Review other subgraph queries & etl joins where this could be simplified and fix them

Tasks

[ ] update slots and other tables to get pair/timeframe/source info from subgraph
[ ] deprecate implementing this in SQL joins
[ ] verify that queries are generating corect/expected data

Because it feels like the previous work wasn't quite complete.
We can get the data from subgraph and clean this up.
I tagged it as low priority.

I am now reviewing this in issue #1000 and it's coming up again.
The bronze_slots query is taking a very long time to complete, and although it may be to other reasons, I can't help but stare at this super expensive join that we can basically get for free.

This is now being tracked in #1299 and this will be closed. Please reopen as we address backlog.


Adafruit AirLift

Is the library compatible with Adafruit AirLift WiFi coprocessor like the Metro M4 Express AirLift?

Maaaaaybe. Ampule relies heavily on the CircuitPython wifi and socketpool libraries - so if it supports CircuitPython 7 and the wifi libraries, you should be good to go.

Let me know if you have any issues with the AirLift @speccy88 - I'll re-open this as an enhancement if so


[Slider] Fix focus after click

[x] I have followed (at least) the PR section of the contributing guide.

This fixes a regression with the Slider variant with marks that was introduced in 4.9.10, which broke keyboard interaction.  This fixes that and adds a new test to check for this behavior.  Original bug report:
Closes #20645

@davidcalhoun I have updated your test to be failing without the patch. I believe we were already testing that the component responds to arrow changes.

@oliviertassinari No worries, thanks for the heads up!  The test I added was failing on my machine without the patch, though maybe that was some side effect that wasn't testing the root issue.  In any case, the test you added was cleaner and probably tests the root issue better!


Sensors not appearing in the dropdown list

Hi there!  Installed your plugin and the OpenHardwareMonitor software.  I was able to create stream deck buttons and it was working well.  I then realized i had installed the old, orphaned version of the OHM so I uninstalled it and installed the recommended version.
Since then when I try to create a streamdeck button the "Sensor" dropdown is not populating.
Suggestions?

Do make sure that OHM is configured to use port 8085. I have noticed that the forks may have different defaults


bottles: 2021.7.14-treviso -> 2021.9.14-treviso

Added new dependency patool as it's now needed during runtime.
Motivation for this change
Update to latest release.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 30, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 30 (delta 15), reused 14 (delta 13), pack-reused 6
Unpacking objects: 100% (30/30), 224.55 KiB | 782.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   9f761047cc4..b7255cd8b96  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-df00de53009d941f5417aa298761f558da758a5b-dirty/nixpkgs b7255cd8b96994ebfc20810f3cad4b6e871af7f4
Preparing worktree (detached HEAD b7255cd8b96)
Updating files: 100% (27893/27893), done.
HEAD is now at b7255cd8b96 Merge pull request #138542 from figsoda/cargo-tally
$ nix-env --option system x86_64-linux -f /home/asbachb/.cache/nixpkgs-review/rev-df00de53009d941f5417aa298761f558da758a5b-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune

[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

/marvin opt-in
/state needs_review

/status needs_reviewer

/cc @bloomvdomino @SCOTT-HAMILTON

Happy to help you get this merged.
The diff looks good.
There seems to be a conflict, could you have a look at it ?

As the there was also an upstream update I'll open a new PR.


Unity support

Unable to use this in Unity 2019, as system.reflection and system.reflection.emit not unavailable in unity. Any way to use this in unity
Thanks

Hello @amit-nath30, this project was not been maintained for a long time, and I would recommend you to use https://github.com/RevenantX/LiteNetLib instead, as it is a lot better maintained.

As for your question, I would recommend you to build GServer shared library and reference it in your unity project. This way you should avoid those errors.

You may also want to remove all that CodeGen staff from GServer and serialize your structures by hand.
CodeGen is an experimental feature that does some CLR injections at runtime. As far as I remember, I got some security warnings in windows, when I was trying to use that. On Linux, it works well.

thank you for your reply,


An error when saving model and weights!

json_string = tweet_model.to_json()
open(r'models\tweet_model_architecture.json', 'w', encoding = 'utf-8').write(json_string)
tweet_model.save_weights(r'models\tweet_model_weights.h5',overwrite = True)

  File "C:\Anaconda2\lib\site-packages\spyderlib\widgets\externalshell\sitecustomize.py", line 699, in runfile
    execfile(filename, namespace)

  File "C:\Anaconda2\lib\site-packages\spyderlib\widgets\externalshell\sitecustomize.py", line 74, in execfile
    exec(compile(scripttext, filename, 'exec'), glob, loc)

  File "E:/EMNLP/attention/keras-language-modeling-master/keras-language-modeling-master/tweet_similarity.py", line 305, in <module>
    json_string = tweet_model.to_json()

  File "C:\Anaconda2\lib\site-packages\keras\engine\topology.py", line 2343, in to_json
    return json.dumps(model_config, default=get_json_type, **kwargs)

  File "C:\Anaconda2\lib\json\__init__.py", line 251, in dumps
    sort_keys=sort_keys, **kw).encode(obj)

  File "C:\Anaconda2\lib\json\encoder.py", line 207, in encode
    chunks = self.iterencode(o, _one_shot=True)

  File "C:\Anaconda2\lib\json\encoder.py", line 270, in iterencode
    return _iterencode(o, 0)

UnicodeDecodeError: 'utf8' codec can't decode byte 0x88 in position 22: invalid start byte

Any opinions would be appreciated!

somehow you have a super weird character somewhere. I have no idea where. I get them with NLP data a bunch.
in general, you can solve them by:
bad_string = '\xc3' # or something
bad_string.decode('utf8').decode('ascii','ignore')

Isn't a single backslash a very bad idea in general within python strings?
I could be wrong, but what about the following change:
r'models\tweet_model_architecture.json'
r'models\\tweet_model_architecture.json'

The model itself only contains numerical data, so the error would come from a layer name. You may have used a non-JSON serializable (non-UTF8) string as a name somewhere.


Angular 15 upgrade

References

Fixes #2043

Description
Updates DSpace angular to version 15 and relevant dependencies with it
Instructions for Reviewers
Dependency conflict
Majority of dependencies were upgraded to their latest version, supporting Angular 15. However, there's a couple exceptions that proved troublesome, mainly:
Upgrading @ng-bootstrap/ng-bootstrap to the latest version (v14, using angular 15) complains that @ng-dynamic-forms/ui-ng-bootstrap requires an earlier version of ng-bootstrap, v11. I've tried ignoring this warning and upgrading regardless, but this breaks DSpace to a point it's unable to build. Even the latest version of ui-ng-bootstrap still requires ng-bootstrap v11, so upgrading that isn't an option either.
It's possible ng-dynamic-forms is dying out, meaning we might have to migrate to a different library for the next angular upgrade. Currently, this isn't an issue yet, as the current versions of @ng-bootstrap/ng-bootstrap and @ng-dynamic-forms/ui-ng-bootstrap work perfectly fine with Angular 15.
This would involve heavy refactoring of submission, related to #858.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@tdonohue

We were already on Webapck 5. At some point during the upgrade @Atmire-Kristof ended up with two different minor versions side by side, which lead to build issues. I suggested to remove the explicit dependency on Webpack so yarn would resolve to the specific version it needed, which introduced those warnings.
→ Added a new dependency on the one "correct" version now.
Production builds use tsconfig.server.ts, and the target wasn't updated in that file yet.

@tdonohue I'm seeing the same thing.
Looks like it has something to do with the  @slideSidebarPadding animation on ds-root. Simply removing the animation "solves" the errors -- we'll investigate further to see if we can find a proper solution.


Use requests Session for connection pooling to NBNco

I think this might speed things up a little
https://requests.readthedocs.io/en/latest/user/advanced/#session-objects

Unclear whether sessions/urllib3 are thread-safe for ThreadPoolExecutor
https://github.com/psf/requests/issues/2766

If they're not thread-safe, maybe could pre-split the list into chunks, and process each chunk in a separate thread (each of which has a Session)

Resolved by https://github.com/LukePrior/nbn-upgrade-map/pull/66


Bug: Approvar not showing in approvar list for specific app for specific user

📜 Description
Approvar not showing in approvar list for specific app for specific user
👟 Reproduction steps
-Create an app
-configure for approvar

give access for specific area not for all
give approver access as well
check approvar list

👍 Expected behavior
Approvar should show in approvar list if user have approvar permission for specific app for specific user
👎 Actual Behavior
Approvar not showing in approvar list if user have approvar permission for specific app for specific user
☸ Kubernetes version
AKS: 1.26
Cloud provider
Azure
🌍 Browser
Chrome
🧱 Your Environment
QA
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#10155

this issue has been fixed so closing it.


[modify][chorg] multiple contacts support

Coverage: 82.923% (+0.1%) from 82.82% when pulling b1574cf3e33e2178cc22c4a1eeaf8423dc81468b on pr-chorg-enhancement into 4ad0d64eaa083a4df843402758f16f177fd5b59e on master.


Feature request: Only enable plugin features when in-between $ symbols

It's really annoying when I want to make something bold with __this__ but pressing space automatically appends a curly bracket after it.
Also annoying when you want to type the word 'up ' but instead it changes to \upsilon. I've disabled the shorthand but it would be much better if it only works inside $$ and not outside of it.

Hi @laur-ns ,
I am sorry, but I could not replicate the issue you have mentioned.
These two functions you mentioned only fires when the cursor is enclosed by a single dollar sign $ or double dollar sign $$.
Might you have an empty double dollar sign $$ some where in your text? when that happens, the plugin will think that the rest of the text after the double dollar sign $$ are all within the multiline latex, and so these functions will fire.
If possible, please kindly try typing in a brand new document and see if the issue still persist?
Thank you!

Omg you're right, after searching for a while it turns out there was an extra $ that I added. Sorry about that, and thank you for this plugin!

@laur-ns    Thank you! Really hope the plugin is useful to you :)


Minor documentation fix

https://github.com/duo-labs/isthislegit/wiki/Installation#creating-the-oauth-client
The oauth block within manifest.json should actually be oauth2[1], not oauth.
1 - https://developer.chrome.com/apps/app_identity#update_manifest

Hi @kiwiz!
Thanks for sending this over. You're absolutely right. I've fixed the manifest block in the documentation. Sorry for the trouble!
Thanks again for bringing this to our attention! Let us know if you run into any other issues, as the documentation is still a work in progress.


Efficiency improvements for package de.upb.crypto.math.pairings.BarretoNaehrig

(This issue has been imported from the Gitlab repository because it seems to not have been addressed yet)
Original Text (Issue 85)
Several optimizations are pending:

Currently, fields are derived fromde.upb.crypto.math.structures.quotient.FiniteFieldExtension. This is inefficient, especially the implementation of multiplication. The BN fields shall directly implement the Field interface, including a Karatsuba based implementation of FF multiplication.
Only the less efficient Tate Pairing is implemented. Also Ate and optimal Ate pairing shall be implemented.
The final exponentiation is not optimized. It shall be based on Frobenius Endomorphism and multi exponentiation.
Remove artificial BN BaseField
Implement inversion in GT based on conjugation (unitary elements)

Comment by Peter Günther
The first item is handled in branch feature/native_bn_arithmetic and already partly merged into develop with commit https://git.cs.uni-paderborn.de/ag-bloemer/sis/-/commit/0b709fe25bf8c56b423edb5d2959d04e6f5828c9
Comment by Fabian Eidens
[at]peterg can you give us a hint for 2. such that we can look at it and implement it?
Comment by Peter Günther
This should be a good starting point.
Frederik Vercauteren. “Optimal pairings.” In: IEEE Transactions on
Information Theory 56.1 (2010), pp. 455–461.
Also diss of Michael Naehrig.
Comment by Peter Günther
To get something closer to an implementation, look at Algorithm 6.3 in
http://nbn-resolving.de/urn:nbn:de:hbz:466:2-24853
http://digital.ub.uni-paderborn.de/hsx/download/pdf/2041207?originalFilename=true
The expected speedup for a product of pairings is roughly factor 4 compared to Tate pairing, I guess.
Is it critical for you? If you really need it, I could implement it together with the Jacobean coordinates when there is a bit more time.
I would first implement Jacobean coordinates because it applies to a wider class of curves and because it should bring more speedup.

Similarly to #91, it seems it was decided to make use of existing efficient pairing implementations and just use our own pairings for convenience and not performance..

Seems about right.
For 1., we have had a Bachelor thesis looking at Karatsuba multiplication, but because of weird-ish design choices of the BigInteger interface, it's hard to employ properly.
I've recently committed 3.
Peter has implemented 5. at some point.
So I'd say this issue is mostly done and our current strategy with the library is to not put too much effort into optimizing the Java pairings, as you've said.


Possible collision between EPUB error codes and Windows error codes

If you look at the file error_handler.h, you will see that there is a list of error codes for possible EPUB errors. Most of them describe errors in which the book in question is not following something from the EPUB 3 specification.
In addition to that, if you look at the bottom of the file, you will find the following macro definition:
#if EPUB_PLATFORM(WIN)
define THROW_WIN_ERROR(err) HandleError(static_cast(err), std::system_category())
define THROW_LAST_ERROR() THROW_WIN_ERROR(::GetLastError())
#endif
Something similar to this can be found in many many Windows programs. It is just a macro to deal with the very common GetLastError() pattern from Windows.
The problem, though, is that if anybody in Windows uses this, you can have a collision between Windows errors and EPUB errors. For example, if some Windows code in Readium gets the following error:
ERROR_BAD_FILE_TYPE
The value of that error is 0xDE, which corresponds to 222. However, the EPUBError enumeration defines 222 as "OPFMissingSpineIdref" ("Spine  MUST have an idref attribute. Critical."). So a Windows error could be interpreted as an EPUB error, and the wrong error message may be shown to the user (plus the confusion for the poor developer trying to debug this).
This is a small issue, but I thought it would be a good idea to have it documented, just in case the Windows developers start seeing weird errors all of sudden.
One possible solution is to adopt another pattern that has been used in many other Windows applications. Given that we have the whole range of integers available to us as error codes, in the case of a Windows error, the code could simply add 20,000 (for example) so that we would define that errors on 20,000 and above are Windows errors. This way, "OPFMissingSpineIdref" would correspond to 222, whereas ERROR_BAD_FILE_TYPE would be 20,222.

This is where the category comes in: all Windows errors should be placed into std::system_category(), while EPUB errors are in epub3::epub_category() (I think...)

Correction: EPUB errors should be in the category returned from epub3::epub_spec_category().

Note that the "error handler" callback functions registered in iOS, OSX, and Android launchers filter messages based on the is_spec_error() boolean, which obviously is false for
std::system_error (which is triggered for std::system_category()).
See:
error_details(const std::system_error& __sysErr)
https://github.com/readium/readium-sdk/blob/develop/ePub3/utilities/error_handler.h#L445
__DispatchError(const std::system_error& __err)
https://github.com/readium/readium-sdk/blob/develop/ePub3/utilities/error_handler.h#L517
HandleError(int __code, const std::error_category& __cat)
https://github.com/readium/readium-sdk/blob/develop/ePub3/utilities/error_handler.h#L530
_THROW_WIN_ERROR_(err) HandleError(static_cast<int>(err), std::system_category())
https://github.com/readium/readium-sdk/blob/develop/ePub3/utilities/error_handler.h#L585
See launcher app -specific "error handlers":
iOS:
https://github.com/readium/readium-sdk/blob/develop/Platform/Apple/RDServices/Main/RDContainer.mm#L68
		ePub3::ErrorHandlerFn sdkErrorHandler = ^(const ePub3::error_details& err) {

			const char * msg = err.message();

			BOOL isSevereEpubError = NO;
			if (err.is_spec_error()
					&& (err.severity() == ePub3::ViolationSeverity::Critical
					|| err.severity() == ePub3::ViolationSeverity::Major))
				isSevereEpubError = YES;

			BOOL res = [m_delegate container:self handleSdkError:[NSString stringWithUTF8String:msg] isSevereEpubError:isSevereEpubError];

			return (res == YES ? true : false);
			//return ePub3::DefaultErrorHandler(err);
		};
		ePub3::SetErrorHandler(sdkErrorHandler);

OSX:
https://github.com/readium/SDKLauncher-OSX/blob/develop/LauncherOSX/LOXePubSdkApi.mm#L62
bool LauncherErrorHandler(const ePub3::error_details& err)
{
    const char * msg = err.message();
    NSLog(@"%s\n", msg);

    if (err.is_spec_error())
    {
        switch ( err.severity() )
        {
            case ePub3::ViolationSeverity::Critical:
            case ePub3::ViolationSeverity::Major: {

                if (m_ignoreRemainingErrors != YES)
                {
                    NSAlert *alert = [[NSAlert alloc] init];
                    [alert setMessageText:@"EPUB warning:"];
                    [alert setInformativeText:[NSString stringWithUTF8String:msg]];

                    [alert addButtonWithTitle:@"Ignore"];
                    [alert addButtonWithTitle:@"Ignore all"];
                    switch ([alert runModal]) {
                        case NSAlertFirstButtonReturn: {
                            // Dismiss
                            break;
                        }
                        case NSAlertSecondButtonReturn: {
                            // Ignore all
                            m_ignoreRemainingErrors = YES;
                            break;
                        }
                        default:
                            break;
                    }
                }

                break;
            }
            default:
                break;
        }
    }

    return true;
    // never throws an exception
    //return ePub3::DefaultErrorHandler(err);
}
ePub3::ErrorHandlerFn launcherErrorHandler = LauncherErrorHandler;
ePub3::SetErrorHandler(launcherErrorHandler);

Android:
https://github.com/readium/readium-sdk/blob/develop/Platform/Android/src/org/readium/sdk/android/SdkErrorHandler.java
https://github.com/readium/readium-sdk/blob/develop/Platform/Android/src/org/readium/sdk/android/EPub3.java#L157
https://github.com/readium/readium-sdk/blob/develop/Platform/Android/jni/epub3.cpp#L222
static bool LauncherErrorHandler(const ePub3::error_details& err)
{
    const char * msg = err.message();

	bool isSevereEpubError = (err.is_spec_error()
			&& (err.severity() == ePub3::ViolationSeverity::Critical
			|| err.severity() == ePub3::ViolationSeverity::Major));

    LOGD("READIUM SDK ERROR HANDLER (%s): %s\n", isSevereEpubError ? "warning" : "info", msg);

    jstring jmessage = m_env->NewStringUTF(msg);
    jboolean b = javaEPub3_handleSdkError(m_env, jmessage, (jboolean)isSevereEpubError);
    m_env->DeleteLocalRef(jmessage);
    return (bool)b;

    // never throws an exception
    //return ePub3::DefaultErrorHandler(err);
}

    public static SdkErrorHandler m_SdkErrorHandler = null;
    public static void setSdkErrorHandler(SdkErrorHandler sdkErrorHandler) {
        m_SdkErrorHandler = sdkErrorHandler;
    }

	private static boolean handleSdkError(String message, boolean isSevereEpubError) {
        if (m_SdkErrorHandler != null) {
            return m_SdkErrorHandler.handleSdkError(message, isSevereEpubError);
        }

        System.out.println("!SdkErrorHandler: " + message + " (" + (isSevereEpubError ? "warning" : "info") + ")");

    	// never throws an exception
    	return true;
	}

So, the crux of the issue is that, in Windows, whoever is writing the RDServices layer for Windows and also its launcher, must always check the method error_details::is_spec_error() (or error_details::is_system_error()) in order to differentiate between the EPUBError enumeration and one of the Windows errors.
We are doing the right thing in iOS and Android, as we can see above. I must confess that I don't know in which state the RDServices layer and/or the Windows launcher is, therefore I don't know if they are making that check there.
I wonder if a better idea here would be to make completely separate classes here (like SystemError and EPUBError) so that there is no way to get both things confused here. However, given that there is a way to avoid a collision now, I don't think that we need to change the code. As such, I'm marking this issue as closed.


OIPA-1643

https://app.zenhub.com/workspaces/iaticloud-5b8e865bb2cc7b6c78ece322/issues/zimmerman-zimmerman/iati.cloud/1643

:tada: This PR is included in version 5.3.2-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.3.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


dff2dffe

Been wondering why cell count does't change after running dff2dffe. If I run opt or opt -fine it doesn't change situation. Only when running opt -full it detects constant selectors on $muxes. I suggest connecting one of the $mux input directly to D, S to E, and delete $mux.
When doing synthesis tests with big designs opt -full...... take time :)
module add_conated_const (CLK, a, e, x);
input CLK;
input e;
input [1:0] a;
output [1:0] x;

  reg  [1:0] x;

  always @(posedge CLK) begin
    if (e)
	begin
	    x <= x;
	end else begin
	    x <= a;
	end;
   end
endmodule

Only when running opt -full it detects constant selectors on $muxes.

That's intentional.


Byte Pair Encoding

Hey, I saw you are using keys.txt file for encoding data. if i am wrong please correct me.

If you are using keys.txt then how you are making it and if any word is not in training data then it can be handled or not.
I have to train on another language then how can i do?

i same the question. Can you explained purpose and effect of that file?

it look like you need build a vocab in your language in new file keys.txt and retrain the model. In my case, the vocab is: aAàÀảẢãÃáÁạẠăĂằẰẳẲẵẴắẮặẶâÂầẦẩẨẫẪấẤậẬbBcCdDđĐeEèÈẻẺẽẼéÉẹẸêÊềỀểỂễỄếẾệỆfFgGhHiIìÌỉỈĩĨíÍịỊjJkKlLmMnNoOòÒỏỎõÕóÓọỌôÔồỒổỔỗỖốỐộỘơƠờỜởỞỡỠớỚợỢpPqQrRsStTuUùÙủỦũŨúÚụỤưƯừỪửỬữỮứỨựỰvVwWxXyYỳỲỷỶỹỸýÝỵỴzZ0123456789!"#$%&''()*+,-./:;<=>?@[]^_`{|}~

it look like you need build a vocab in your language in new file keys.txt and retrain the model. In my case, the vocab is: aAàÀảẢãÃáÁạẠăĂằẰẳẲẵẴắẮặẶâÂầẦẩẨẫẪấẤậẬbBcCdDđĐeEèÈẻẺẽẼéÉẹẸêÊềỀểỂễỄếẾệỆfFgGhHiIìÌỉỈĩĨíÍịỊjJkKlLmMnNoOòÒỏỎõÕóÓọỌôÔồỒổỔỗỖốỐộỘơƠờỜởỞỡỠớỚợỢpPqQrRsStTuUùÙủỦũŨúÚụỤưƯừỪửỬữỮứỨựỰvVwWxXyYỳỲỷỶỹỸýÝỵỴzZ0123456789!"#$%&''()*+,-./:;<=>?@[]^_`{|}~

I got your point that we have to build vocab to include each character. I was confused about words but I forgot that pick is working on the character.
Thanks

I got your point that we have to build vocab to include each character. I was confused about words but I forgot that pick is working on the character.
Thanks


enhancement(config): better path verification at startup

Fixes incorrect subfolder detection on qbit when cross-seed OS differs from client. Using safe mode should be fine cross platform (as it was in v5) since cross-seed does not interact with the client paths. Linking however cannot be done without manually converting the OS paths, assuming they can even be linked in the first place. It's possible to be done automatically or a user defined translation, but not worth the added complexity for such a niche userbase.
cross-seed will now check all the torrent save paths that the users already have in the client. If the OS is different from cross-seed, it will fail at validation if user is trying to use linking in support of the above.
These save paths will also get tested for linking support to linkDir at startup. For now this will only show an error not fail, we need to check if the torrent is blocklisted by category or tag.
dataDirs will also get tested for linking to linkDir at startup. This won't fail as well, we need to see if the path would have been blocklisted.
Ensure torrentDir dataDirs linkDir outputDir can never be a child of any other. These are never valid uses and give early feedback to the user that they misunderstood what they do.
Require absolute paths for torrentDir, linkDir, and dataDirs.
torrentDir must contain at least one .torrent file or be null. This should prevent users from pointing it to the wrong directory.
outputDir should only contain .torrent files, will only display a warning on startup.
Set the save path for duplicateCategories to the save path of the original category. This is needed if autoTMM is enabled on the torrent.

rTorrent does not perform the save path checks on startup as we need all the infohashes to query the client. This could be a long operation.

Require absolute paths for torrentDir, linkDir, and dataDirs.

Why?

All these changes have been issues that pop up in the support threads. I don't see how this limits any setups so we should enforce it. Considering that cross-seed will be used with multiple mounts in 99% of cases, relative is pretty much always wrong for linkDir and dataDirs. Also, the path for dataDirs will be used as the save path in client, and having that be relative seems problematic.
With the other changes, we now need absolute paths to detect if windows or linux for cross-seed to work correctly, though I'm not sure if it's necessary for these options. With this branch as is, if a user's config passes validation, there is little chance for runtime errors.


Make a static build of a launcher

Launcher library has been built configured to support static build. However, end product (ui or cli) should be built statically too, because static libs doesn't include other static builds (unless we do ar manually with all object files)


Ensure all tests pass with gcc-7 (trunk) and gcc-7 branch of opencoarrays

UPDATE (2016-12-21 by @zbeekman):
All original tests are passing with the possible exception of the NS tests under OpenMPI on docker, and a new test added by @vehre but requires more work by @afanfa on the library side, #260. Since we have separate issues for all those improvements, I'm going to investigate the NS-OMPI-GCC-trunk-Docker failures some more and then, most likely, just close this issue. I suspect the NS failures may be due to the fancy assembly FFT routines.
Fix all failing tests when using GCC-7 (trunk) and the gcc-7 branch.

[x] 1
[x] 9
[x] 8
[x] 10
[x] 22
[x] 24

Here is some text from @vehre elaborating on some failures he was seeing:
With these changes and the update of gcc-trunk I have only three testcases
failing:
1 - initialize_mpi (Failed)      -- I have no clue, why this fails.
The reason for failure here is not obvious to me and I don't think it is caused
by the changes to the caf-interface.
 10 - whole_get_array (Failed)

This can be fixed, when allocatable arrays on the right-hand side of a coarray
get operation are not unnecessarily declared allocatable although they get
allocated just once with a fixed size and never change.
24 - coarray_navier_stokes (Failed)

The same as with 10.
For testcase 22 - coarray_burgers_pde I had to change the number of process to
4 in the makefile to get it running reliably with the same result. With 2
processes it always asserts.

The latest GCC trunk (241802  2016-11-02) and OpenCoarrays (dfe2ec0932d7bd60064922f57afdb3ca60521146) pass all tests except for test 9: get_with_offset_1d
test 9
      Start  9: get_with_offset_1d

9: Test command: /usr/local/bin/mpiexec "-np" "2" "/Users/ibeekman/Sandbox/opencoarrays/build/src/tests/unit/send-get/get_with_offset_1d"
9: Test timeout computed to be: 9.99988e+06
9:
9: Program aborted. Backtrace:
9: #0  0x10eb4e949
9: #1  0x10eb4f5f4
9: #2  0x10ec25118
9: #3  0x10e7b2892
9: #4  0x10e7ba65b
9:
9: ===================================================================================
9: =   BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
9: =   PID 87355 RUNNING AT Izaaks-MacBook-Pro.local
9: =   EXIT CODE: 6
9: =   CLEANING UP REMAINING PROCESSES
9: =   YOU CAN IGNORE THE BELOW CLEANUP MESSAGES
9: ===================================================================================
9: YOUR APPLICATION TERMINATED WITH THE EXIT STRING: Abort trap: 6 (signal 6)
9: This typically refers to a problem with your application.
9: Please see the FAQ page for debugging suggestions
 9/24 Test  #9: get_with_offset_1d ...............***Failed  Required regular expression not found.Regex=[Test passed.
]  0.06 sec

All:
FYI, I have created a docker project that rebuilds every night with the latest GCC trunk. I am planning to use this to add testing against GCC trunk to our CI infrastructure, however, I may set these tests (with GCC trunk) to be allowed failures since we can't guarantee that GCC trunk will always build and behave correctly.
Here is the github repo: zbeekman/docker-gcc-build and here is the docker hub page: https://hub.docker.com/r/zbeekman/docker-gcc-build/
The nightly rebuilds are triggered via nightli.es and my zbeekman/nightly-docker-rebuild project. I'll probably create an OpenCoarrays docker image that is triggered to rebuild nightly by the GCC image, so that the latest bleeding edge OpenCoarrays and GCC can be easily tested together.

This is now true, except for under some circumstances the Navier-Stokes test (pending confirmation) and the extra test that depends on #260 getting done...

I believe that all the tests pass now, with the exception of those blocked by #260 which are new...
I was seeing intermittent failure of NS test with OpenMPI on Docker images, and want to investigate more before closing this issue...

I can confirm that all tests pass on OS X with GCC trunk gcc-7 (Homebrew GCC HEAD-244466_1 --without-multilib) 7.0.0 20170114 (experimental) except for those that have their own issues and are known regressions/defects:

#260 (waiting for specific features to be implemented by @afanfa)
#292

As such, I'm closing this issue.
Here is what I get on Sierra:


Fix documentation about depth and width of Height map

Fix wrong documentation part of #58933 in 3.x branch.

Thanks!

Cherry-picked for 3.4.4.


Warden reconciliation loop causes DoS to the Notary service for unsigned images

/kind bug
Upon further inspection of Signify access logs I've managed to find a problem where Warden's reconciliation loop would cause unintended DoS attack when it asks for unsigned images.
Once every 10 minutes, for a failed image the retry reconciliation is issued. This currently occurs for every instance where Warden is deployed. https://github.com/kyma-project/warden/blob/b6285328efb207f8ba0d1b7fe58f9b604d61c770/controllers/pod_controller.go#L81. As some of the images that we use are not yet signed, every request for unsigned images queries Notaty server, increasing load.
Cache is not working for unsigned images, because Warden only caches signatures for already signed images.
Possible solutions:

Cache responses from Notary
Increase the time between retries to hours
Remove retry logic and rely on automatic K8s reconciliation schedule (around every 10 hours).

Change default to 60 Min
expose as overridable parameter managed by SRE

requeueAfter period is changed to 60min and is configurable per landscape


HHH-4808 - SessionImpl.initializeCollection() does not release JDBC connection (if outside of a transaction)

https://hibernate.atlassian.net/browse/HHH-4808

Haven’t reviewed the PR but the JIRA number of the second commit is incorrect :)

fixed
Thanks @gsmet

superseded by https://github.com/hibernate/hibernate-orm/pull/3868


Flow Emulator Broken since version 2.0.5

Instructions
Update the flow emulator to version 2.0.5. Also for version 2.0.6. Then I go to my current Cadence project and run "flow emulator" and throws the error described below.
If I create a new flow project with "flow init" it works fine.
Problem
The emulator brokes, this is the error message:
❯ flow emulator
panic: unknown chain:

goroutine 1 [running]:
github.com/onflow/flow-go/fvm/systemcontracts.SystemContractsForChain({0x0, 0x0})
        /root/go/pkg/mod/github.com/onflow/flow-go@v0.37.10/fvm/systemcontracts/system_contracts.go:260 +0x9d
github.com/onflow/flowkit/v2/config.isCoreContract({0xc0010ac540?, 0xc001366e20?}, {0xc0010ac55e, 0x6}, {0xc00198f1b8, 0x10})
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/config/contract.go:138 +0x76
github.com/onflow/flowkit/v2/config.(*Contracts).AddDependencyAsContract(0xc001c5fba8, {{0xc0013661d8, 0x6}, {{0xc0010ac540, 0xa}, {0xb6, 0x76, 0x3b, 0x43, 0x99, ...}, ...}, ...}, ...)
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/config/contract.go:166 +0xf0
github.com/onflow/flowkit/v2/config/json.(*jsonConfig).transformToConfig(0xc0013cba10)
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/config/json/config.go:80 +0x39b
github.com/onflow/flowkit/v2/config/json.(*Parser).Deserialize(0xc001300000?, {0xc0010ea000, 0x1b57, 0x2000})
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/config/json/config.go:149 +0xbd
github.com/onflow/flowkit/v2/config.(*Loader).loadConfig(0xc0013c0480, {0x285d632, 0x9})
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/config/loader.go:126 +0x295
github.com/onflow/flowkit/v2/config.(*Loader).Load(0xc0013c0480, {0x445ede0?, 0x2?, 0xb?})
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/config/loader.go:137 +0xc7
github.com/onflow/flowkit/v2.Load({0x445ede0, 0x2, 0x2}, {0x2f48f10, 0xc0014fe0f0})
        /root/go/pkg/mod/github.com/onflow/flowkit/v2@v2.0.0/state.go:297 +0x15f
github.com/onflow/flow-cli/internal/emulator.configuredServiceKey(0x0, 0x8?, 0x0?)
        /go/src/github.com/onflow/flow-cli/internal/emulator/start.go:75 +0xb4
github.com/onflow/flow-emulator/cmd/emulator/start.Cmd.func1(0xc001506800?, {0x2855097?, 0x4?, 0x285509b?})
        /root/go/pkg/mod/github.com/onflow/flow-emulator@v1.0.0/cmd/emulator/start/start.go:126 +0x205
github.com/spf13/cobra.(*Command).execute(0xc000b26608, {0xc000144010, 0x0, 0x0})
        /root/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:989 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0xc000b26908)
        /root/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        /root/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041
main.main()
        /go/src/github.com/onflow/flow-cli/cmd/flow/main.go:131 +0xf74

Steps to Reproduce
Run the command:
sh -ci "$(curl -fsSL https://raw.githubusercontent.com/onflow/flow-cli/master/install.sh)"
cd to my cadence project and run:
flow emulator
Context
<what are you currently working on that this is blocking?>

It's still present. What should I do?
I have core contracts pointing to previewnet like this:
		"ViewResolver": {
			"source": "previewnet://b6763b4399a888c8.ViewResolver",
			"hash": "eaa3214b0e178c5692cfc243a14c739150d5d57ef3f9204a252d70667a67db76",
			"aliases": {
				"emulator": "f8d6e0586b0a20c7",
				"mainnet": "1d7e57aa55817448",
				"previewnet": "b6763b4399a888c8",
				"testnet": "631e88ae7f1d7c20"
			}
		}```

How do I replace that "source" field? I understand that for aliases I should remove the entry for previewnet.

I also tried to create a new project with flow init all core contracts as dependency, to see how they are generated. But have this error:

❯ flow init test206
✔ Yes
Select any core contracts you would like to install or skip to continue.
Use arrow keys to navigate, space to select, enter to confirm or skip, q to quit:
[x] FlowEpoch
[x] FlowIDTableStaking
[x] FlowClusterQC
[x] FlowDKG
[x] FlowServiceAccount
[x] NodeVersionBeacon
[x] RandomBeaconHistory
[x] FlowStorageFees
[x] FlowFees
[x] FlowToken
[x] FungibleToken
[x] FungibleTokenMetadataViews
[x] FungibleTokenSwitchboard
[x] NonFungibleToken
[x] MetadataViews
[x] ViewResolver
[x] EVM

[x] Burner

🔄 Installing selected core contracts and dependencies...
❌ Command Error: error processing dependency: contract Burner not found at address e467b9dd11fa00df

Hi! I corrected my flow.json and updated flow-cli to latest version and everything works! Thanks!


Document adding a CLR keys to owned collections

See https://github.com/dotnet/efcore/issues/19856#issuecomment-903257552 and https://github.com/dotnet/efcore/pull/25652

Note that this only applies to relational providers. For Cosmos the keys are synthesized and never stored in the database.


Is there a read_state implementation for system calls?

Making query and update calls are great, but sometimes I want to make system calls, which requires read_state syntax as can be seen here: https://smartcontracts.org/docs/interface-spec/index.html#http-read-state
Is this interface implemented in the Python agent? I know the JavaScript agent tests supported some read_state calls, but the documentation around it still wasn't very good.
Thanks!

https://github.com/rocklabs-io/ic-py/blob/main/ic/agent.py#L107

Yeah, beautiful. That is the one that I found as well. Although "time" is the only path that I could get to work. I kept getting CBOR decode issues if I tried any other paths. Are other paths other than "time" supported? Like canister_ranges? Or subnet information?

Canister info and subnet informatoin are supported. Text in paths must be blob and principal in the paths must be bytes-form,  e.g
cert = ag.read_state_raw("gvbup-jyaaa-aaaah-qcdwa-cai", [["subnet".encode(), Principal.from_str("w4asl-4nmyj-qnr7c-6cqq4-tkwmt-o26di-iupkq-vx4kt-asbrx-jzuxh-4ae").bytes, "canister_ranges".encode()]])
ret = lookup(["subnet".encode(), Principal.from_str("w4asl-4nmyj-qnr7c-6cqq4-tkwmt-o26di-iupkq-vx4kt-asbrx-jzuxh-4ae").bytes, "canister_ranges".encode()], cert)
print(cbor2.loads(ret))

Actually, read_state_raw is too low level. Maybe we can absract it into easy-to-use function later.

#41
You can look into the code in test_readstate and try ur own code to check whether get correct result.


[otbn] Fix mismatch caused by uninitialised WDRs

For more detail regarding the problem this PR fixes: https://github.com/lowRISC/opentitan/issues/17154

Thanks for the quick feedback @jadephilipoom and @andreaskurth. I've added both of your suggestions now


Add documentation for custom formatters

Great work on this library, it's really cool!
I was looking for a way to add custom formatters and found the custom_formatters argument. I found it very useful, so I thought I'd add it to the documentation.
I'm not sure if the usage example I gave is the best (are you supposed to provide both validate and unmarshal in this case?) so I'd be happy to get suggestions on how to improve it.
I didn't find any contribution guidelines so I hope I'm doing this right!
Best regards,
@chreke

Hi @chreke
thank you for the contribution. LGTM 👍


Expected 'AS' in alias when SELECT

I'm just starting to try Proton and maybe I'm missing something or misunderstanding something.
I'm trying to run a request with pseudocode and getting an exception. This behavior is not reproduced in any version of Clickhouse.
How to reproduce

Executing a query:
SELECT x.* FROM (SELECT 'test' name) x

When executing query following exception is received:
Syntax error: failed at position 32 ('name'):

SELECT x.* FROM (SELECT 'test' name) x

Expected one of: NOT, BETWEEN, IS, AS, FROM, WHERE, PARTITION BY, SHUFFLE BY, GROUP BY, WITH, HAVING, WINDOW, ORDER BY, LIMIT, EMIT, SETTINGS, UNION

Executing a query when an alias is created with the 'AS' keyword:
SELECT x.* FROM (SELECT 'test' AS name) AS x

When executing query following output is received:
┌─name─┐
│ test │
└──────┘

1 row in set. Elapsed: 0.001 sec.

Additional context
I expect that such queries should be executed without exceptions, since the keyword 'AS' is optional.

yes, it may need an enhancement, i tried the clickhouse in the same query, it can work well,

Thank you for your experience @Catwoolfii .
For some reasons, we must use explicit aliases for tables via AS keyword.
In fact, we always recommend using AS to define aliases everywhere, which is more understandable.


Date extractions from the future

Found several articles with dubious extraction dates.

The article with 2019-05-01 as the extraction date has doc_id: "20668872"

Tossing articles with future dates during vectorization
Closing


Unmarshal function

The BibliographicItem and IsoBibliographicItem class has a marshaller, to.xml().
It also needs an unmarshalling function: I need to be able to read entries from a cache that are in a serialisation, and convert them to the IsoBibliographicItem class. This is to meet the requirements of https://github.com/riboseinc/relaton/issues/1:
x = Relaton.fetch("ISO19011")
=> <# Relaton::Iso @docidentifier: "ISO 19011:2011" ... >

x.to_xml
=> <bib-item ...>

Relaton::Database.load(:local, doc_identifier: "ISO19011").to_xml / to_bibtex / to_rfcxml ...

If the ISO19011 is fetched from a local cache instead of the web site, I need to convert it from the serialisation back to the IsoBibliographicItem class, before converting it on to BibTex or anything else.
I'm quite happy for that serialisation to be XML, in which case the unmarshalling is simply a series of Nokogiri .at queries. So:
def from_xml(xmldoc)
        xml = Nokogiri::XML(xmldoc)
        IsoBibItem::IsoBibliographicItem.new(
          docid:        xml&.at("./docidentifier")&.text,
          edition:     xml&.at("./edition")&.text,
         ....
        )
end

The skeleton of the function is in lib/iso_bib_item/from_xml.rb

@opoudjis is the task for me?

@opoudjis if Relation store documents in JSON format then wouldn't it be easier to create BibliographicItem from JSON instead of XML?

I leave the decision to you.

And yes, @andrew2net, this task is for you.

I'll add also that while the cache is in JSON now, it might later turn into a local key/value database (as Ronald wants to be able to modify individual entries). So again, not seeing a strong argument to make serialisation be in JSON.

we're going to have to subclass the behaviour by standards type. If the standard is ISO, it will be broken up into three parts like that. If the standard is not ISO, we will expect it to be a single string.

@opoudjis why do we need to inherit IsoProjectGroup form Organization class? As I understand IsoProjectGroup serialized to editorialgroup element. But we don't serialize any data from Organization. So we can't recreate Organization from XML.
editorialgroup = element editorialgroup {
  technical-committee, subcommittee?, workgroup?, secretariat?
}

technical-committee =
  element technical-committee { IsoWorkgroup }

subcommittee =
  element subcommittee { IsoWorkgroup }

workgroup =
  element workgroup { IsoWorkgroup }

IsoWorkgroup =
    attribute number { xsd:int }?,
    attribute type { text }?,
    text

Inheritance in the UML diagrams is somewhat abused; it's actually an override operation. While conceptually the editorial group is a suborganization of ISO, in the serialisation there is no mention of the organization, nor does there need to be. So you can ignore that inheritance for the purposes of serialisation: it won't be populated.

@andrew2net Could you please prioritise this task now? It's required for further work on relaton.

@opoudjis working on it right now, suppose to finish today

@opoudjis done. I'm ready for next task

Thank you!


Add Sankey Chart Card

Insert URL to the project you want to be reviewed here: https://github.com/MindFreeze/ha-sankey-chart

[x] The project is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All listed projects on OpenSustain.tech will be supported via multiple community services:

Issues labeled as Good First Issue will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon and Bluesky channel.
Listed project that provide donation option via Open Source Collective or GitHub Sponsors can by nominated via OpenClimate.fund. All project currently supported can be found here.

Insert an project you want to nominate for a micro grant here:

@MindFreeze


How do I switch themes using Astro?

Hi, I have been trying to switch themes using ts-particles, I have seen your codepen https://codepen.io/matteobruni/pen/MWopjRP for switching themes using vanilla js, but I am wondering how to do it in Astro, because I can't get the theme container

Since there's no particlesLoaded function, you can get tsParticles running instances using tsParticles.domItem(<index>), importing tsParticles like in the readme. I haven't found a way to pass functions to an Astro component, so that's the only way for now.

Oh nice, I'll try it out 😃 thanks

Tried this out and it works 🔥, closing it


ci: add release tag action

Description
Add a release-tag action same as used in vue-next tho it handles monorepo releases conditionally.
Additional context
In the release description, I used the same format as vue-next. Though the difference is we provide the link to the CHANGELOG from the git tag, not from main branch since I noticed there is release/* branches for minor releases.
To view this PR in action, you can refer to my forked repo and I tested on this branch.
One thing is stable releases of plugins are not considered as latest in GitHub releases.
Maybe because of they use semantic matching for latest release?

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

This is great! Thanks a lot. Do you think it is possible to always point to the entry in main changelog using its anchor? It seems better to also see new releases if there are already

I also thought it like that at first. But there are some changelog missing on the main branch. For example, there is no 2.6.14 changelog on main but only on release/2.6.x.
If we could merge it back to main, it would be really great.
Another edge case is we might need to run date command in CI to get the release date which can be different from the maintainers' region and in the CI but this should be very rare, I think.


[5.7] [Test Coverage] Route Implicit Binding

While running PHPunit Coverage Report, I noticed that the framework has quite a number of classes that are 100% uncovered by tests. This Pull Request covers SubstituteBindings Middleware and ImplicitRouteBinding with just a small set of integration tests.
I intend to write a number of more PRs to add coverage to parts of the framework that has none or very shallow code coverage. If these PRs are undesirable, please let me know.
Thanks!

I ran the report wrong, this class is already covered.


perms regex is too lax

If I set perms = [{ regex = "/tmp"; }] then that also matches /some/path/tmp.
I tried to use regex = "^/tmp$" but now that doesn't seem to match anything.
I think it should be possible to set the permissions for one specific, exactly specified path.

Ah, I figured it out.
You have to do regex = "^/nix/store/abcd......../tmp$";.
I was misled by the use of .* in documentation and examples. Usually, it makes sense and is needed if there is some kind of ^...$ added to the pattern implicitly elsewhere. But, since there is not, it is rendundant - foo and foo.* both mean the same thing as .*foo.*.


Modify the data submission form for LCMethod

Summary Change Description
The submission form was edited in google docs to request LCMethod details and the documented instructions were changed to reflect that.
I also:

updated the submission form
added a template for the LCMS-metadata file.

Affected Issues/Pull Requests

Resolves #705
Waiting on #774 - The update of the submission form and associated documentation depends on the changes to the loading of LCMethod data and the association of samples in the database with sample data headers in the accucor/isocorr files.  Thus, this will be revisited once #774 is merged

Review Notes
Note, I edited the submission form.  Please take a look at that.

I edited the link in section 1 from tracebase-dev to tracebase
I changed the LC Method(s) question to read:

What liquid chromatography method and run length did you use for each file (e.g. polar-HILIC-25-min, polar-reversed-phase-ion-pairing-25-min, polar-reversed-phase-25-min, lipid-reversed-phase-25-min)?
If none of these, please include a description (e.g. lipid-reversed-phase-25-min This method uses C18 columns for the analysis of lipids).
I tried to indicate that the user should use the supplied example values, with run-length, and that if their method differs, they should also include a description.

I changed the answer from short answer to long answer (paragraph)

Personally, I feel like this data should be in a sheet in the uploaded excel file so that each method can be associated with the appropriate sample/file, but I tried to stay true to the issue description.
Checklist

This pull request will be merged once the following requirements are met.  The
author and/or reviewers should uncheck any unmet requirements:

Review requirements

Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: @add_username_here

Review period: 2 days

Associated issue/pull request requirements:

[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)

Basic requirements

[x] All linters pass
[x] All tests pass
[x] All conflicts resolved

Overhead requirements

[x] New/changed method tests implemented/updated (or no change)
[x] Added changes to Unreleased section of changelog.md
[x] Migrations created & committed (or no change)

I agree that this should probably be a new sheet added to the template. The issue #705 states "Update sumbission templates..." so I don't see any conflict in doing that, but please let me know if you have questions or concerns.

The ambiguous/confusing part to me about this is, I wasn't sure it the animal/sample template was included in "submission templates" or if the qualifier "submission" was singling out the sheet associated with the submission form by name and that it was plural because it was "allowing" a separate submission template to be added (separate from the animal/sample sheet) for the newly required information, given the M:M association between the sample and LCMethod / MSRun.  I can see you could make a case that that is over-complicating the issue, but given I was struggling with reconciling this question with other issues/concerns, it just wasn't clear to me.  So thanks for providing your interpretation.  It sounds like you're suggesting that the design here is given a wide berth of interpretations, so I will come up with what I think is the most appropriate solution and possibly revise this and request a followup review.

Thanks Rob. I suggest that run your design past the group before committing significant time to it. As we've reviewed before, providing a means for researchers to provide a single lcmethod for each accucor file should cover the majority of cases. When we write the loading code, we can allow for finer grained control (see #706). However, it is best to keep things as simple and straightforward for researchers.

Thanks Rob. I suggest that run your design past the group before committing significant time to it. As we've reviewed before, providing a means for researchers to provide a single lcmethod for each accucor file should cover the majority of cases. When we write the loading code, we can allow for finer grained control (see #706). However, it is best to keep things as simple and straightforward for researchers.

I am a step ahead of you on that. I created a design proposal yesterday before I left, for issue #706.  There is a lot of overlap between this issue and that one, if you implement the changes called for here in the animal/sample table, since it's the loading code of the accucor data loader that takes in that data.  And that's often how I approach design for challenges like this: from the perspective of the code.  It informs what I need in terms of the data structure required.  Since I was in the mindset of the submission form with this issue, and it didn't seem to fit with the data relationship between LC Method and the submission form, I was having trouble reconciling what seemed like contradictory requirements.  Looking at it from the perspective of the loading code helped clarify it for me.
The design I created in issue #706 relates to the changes we discussed yesterday in #687, where I liked the suggestion you made to add an optional sample data header column.  That design proposal suggests adding that value as a "name" field to an MSRun record (or equivalent ms-related table - I have to review the schema design to get familiar with the model names you assigned).  What that design doesn't explicitly say is that instead of adding that sample data header column to the animal/sample table, I instead propose supplying a separate LCMS metadata file to the accucor loader that associates sample names to sample data headers, along with the other metadata delineated in the issue description (AccuCor file, mzXML filename, Researcher, Date, Instrument, lc method).
This is my proposed alternative to re-supplying the animal/sample table to the accucor data loader.  And my reason for that relates to a comment I made that points out that additional data submissions, if we re-supply the animal/sample table, would require either modifying the original sample table associated with a previous submission or duplicate the samples in new submission, neither option of which seemed desirable to me.  This alternative design, adding an LCMS metadata file separates the dependency, keeps the animal/sample table clean and uncluttered, decouples the animal/sample table loading code from the accucor code, and meets the data relationship problems without duplicating data or modifying old data.

@lparsons - The dependencies have been merged to main and I updated this branch. Do you want to review it? Your last review was a comment, so I'll wait for the approval before merging.

I guess the review was a tad premature.  I should have read my affected issues section.  I made some changes to the docs based on the changes in #774.  Take a look.
I also updated the submission form and I added a template for the LCMS-metadata file.
If you see anything there, let me know.

I changed the access of the metadata template to public (like the animal sample template).  You should be able to access it now if you're not logged into your google account - I assume that's how you tested it, since it was restricted, but you have edit access.

I was thinking before that perhaps having a separate page in the docs that includes an example would help?  I'd have added that yesterday, but was eager to move on...  I know that you'd found it confusing in the design and asked for an example, which I believe seemed to help...

Examples can be really useful, but I'd like to keep the instructions as streamlined as simple as possible. Right now we have two major issues to contend with:

TraceBase doesn't strore the mzXML files
Submission of new data is too cumbersome

I started working on #710 this afternoon. I've been selecting issues to work on based on the issue-tracking issues (#693, #700, and #701).  I don't actually see an issue for storing the mzXML files.  Am I just overlooking it?  If it doesn't exist, I can create an issue for it, if you like.
Also, I have a pretty well-thought-out plan for streamlining the submission process.  I outlined it on pages 2 & 3 of my original proposal.  Its groundwork is laid out in:

#671
#661

But I haven't created issues for the rest of it.  Essentially, all a user would have to do is submit accucor/isocorr files and once errors are addressed, it would spit out an excel file with the usual animals/samples/treatments/tissues tabs plus tabs for study, infusates, tracers, and the LCMS metadata (which in the proposal, is referred to in 2 sheets: corrections and mzxml sheets) with much of the tedious work done automatically.
They wouldn't have to be new tabs in an excel file either.  It could just output tsv files (e.g. compounds, lcms metadata, etc.) like we currently use, though a new tracer/infusate tab would be nice.
But the major benefit would be that it can stub-out all these files with the easy things and the user can just manually fill in the rest (i.e. data that cannot be unambiguously computed).
The one limiting factor is speed.  E.g. They couldn't submit an entire study's accucor files.  But it could work per handful of accucor files and accumulate the results


Update bower.json to the last version

Bower.json isn't the same as package.json

Bower does not recognize the version number at all; there's no need to ever update it.


Build failed when I use Firebase Messaging version 5.2.1 on Android

Environment
Unity editor version: 2017.2.2p2
Firebase Unity SDK version: 5.2.1
Additional SDKs you are using (Facebook, AdMob, etc.): None
Platform you are using the Unity editor on (Mac, Windows, or Linux): Mac
Platform you are targeting (iOS, Android, and/or desktop): Android
Issue
Build failed when I use Firebase Messaging version 5.2.1 on Android.
I was successful until about last week.
It seems to be caused by Maven repository' aar being updated?
On iOS all ok, but on android have a problem.
If I use firebase version 4.2.1, success on android.
Step

Create empty unity project. Set SCRIPT BACKEND: IL2CPP.

Import Package > Custom Package > firebase_unity_sdk/FirebaseMessaging.unitypackage

Assets > Play Services Resolver > Version Handler > Update
[ Result ]
Google Version Handler
Update complete.

Assets > Play Services Resolver > Android > Resolve
[ Result ]
Android Dependencies
Resolution Succeeded

Set build system > Gradle(new)

Select build

Build failure

com.android.build.api.transform.TransformException: java.lang.RuntimeException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.ide.common.process.ProcessException: Return code 1 for dex process See the Console for details.

CommandInvokationFailure: Gradle build failed.
/Library/Java/JavaVirtualMachines/jdk1.8.0_40.jdk/Contents/Home/bin/java -classpath "/Applications/Unity/PlaybackEngines/AndroidPlayer/Tools/gradle/lib/gradle-launcher-2.14.jar" org.gradle.launcher.GradleMain "assembleRelease"

stderr[
Dex: Error converting bytecode to dex:
Cause: Dex cannot parse version 52 byte code.
This is caused by library dependencies that have been compiled using Java 8 or above.
If you are using the 'java' gradle plugin in a library submodule add
targetCompatibility = '1.7'
sourceCompatibility = '1.7'
to that submodule's build.gradle file.
    UNEXPECTED TOP-LEVEL EXCEPTION:
    java.lang.RuntimeException: Exception parsing classes
    	at com.android.dx.command.dexer.Main.processClass(Main.java:761)
    	at com.android.dx.command.dexer.Main.processFileBytes(Main.java:727)
    	at com.android.dx.command.dexer.Main.access$1200(Main.java:87)
    	at com.android.dx.command.dexer.Main$FileBytesConsumer.processFileBytes(Main.java:1655)
    	at com.android.dx.cf.direct.ClassPathOpener.processArchive(ClassPathOpener.java:284)
    	at com.android.dx.cf.direct.ClassPathOpener.processOne(ClassPathOpener.java:166)
    	at com.android.dx.cf.direct.ClassPathOpener.process(ClassPathOpener.java:144)
    	at com.android.dx.command.dexer.Main.processOne(Main.java:681)
    	at com.android.dx.command.dexer.Main.processAllFiles(Main.java:578)
    	at com.android.dx.command.dexer.Main.runMonoDex(Main.java:315)
    	at com.android.dx.command.dexer.Main.run(Main.java:286)
    	at com.android.builder.internal.compiler.DexWrapper.run(DexWrapper.java:52)
    	at com.android.builder.core.AndroidBuilder$2.call(AndroidBuilder.java:1511)
    	at com.android.builder.core.AndroidBuilder$2.call(AndroidBuilder.java:1507)
    	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    	at java.lang.Thread.run(Thread.java:745)
    Caused by: com.android.dx.cf.iface.ParseException: bad class file magic (cafebabe) or version (0034.0000)
    	at com.android.dx.cf.direct.DirectClassFile.parse0(DirectClassFile.java:472)
    	at com.android.dx.cf.direct.DirectClassFile.parse(DirectClassFile.java:406)
    	at com.android.dx.cf.direct.DirectClassFile.parseToInterfacesIfNecessary(DirectClassFile.java:388)
    	at com.android.dx.cf.direct.DirectClassFile.getMagic(DirectClassFile.java:251)
    	at com.android.dx.command.dexer.Main.parseClass(Main.java:773)
    	at com.android.dx.command.dexer.Main.access$1600(Main.java:87)
    	at com.android.dx.command.dexer.Main$ClassParserTask.call(Main.java:1694)
    	at com.android.dx.command.dexer.Main.processClass(Main.java:758)
    	... 17 more

1 error; aborting

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':transformClassesWithDexForRelease'.
> com.android.build.api.transform.TransformException: java.lang.RuntimeException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.ide.common.process.ProcessException: Return code 1 for dex process

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
]
stdout[
Observed package id 'add-ons;addon-google_apis-google-23' in inconsistent location '/Applications/AndroidSDK/adt-bundle-mac-x86_64-20140702/sdk/add-ons/addon-google_apis-google-23-1' (Expected '/Applications/AndroidSDK/adt-bundle-mac-x86_64-20140702/sdk/add-ons/addon-google_apis-google-23')
Observed package id 'build-tools;20.0.0' in inconsistent location '/Applications/AndroidSDK/adt-bundle-mac-x86_64-20140702/sdk/build-tools/android-4.4W' (Expected '/Applications/AndroidSDK/adt-bundle-mac-x86_64-20140702/sdk/build-tools/20.0.0')
Incremental java compilation is an incubating feature.
:preBuild UP-TO-DATE
:preReleaseBuild UP-TO-DATE
:checkReleaseManifest
:preDebugBuild UP-TO-DATE
:Firebase:preBuild UP-TO-DATE
:Firebase:preReleaseBuild UP-TO-DATE
:Firebase:compileReleaseNdk UP-TO-DATE
:Firebase:compileLint
:Firebase:copyReleaseLint UP-TO-DATE
:Firebase:mergeReleaseProguardFiles
:Firebase:packageReleaseRenderscript UP-TO-DATE
:Firebase:checkReleaseManifest
:Firebase:prepareReleaseDependencies
:Firebase:compileReleaseRenderscript
:Firebase:generateReleaseResValues
:Firebase:generateReleaseResources
:Firebase:packageReleaseResources
:Firebase:compileReleaseAidl
:Firebase:generateReleaseBuildConfig
:Firebase:mergeReleaseShaders
:Firebase:compileReleaseShaders
:Firebase:generateReleaseAssets
:Firebase:mergeReleaseAssets
:Firebase:processReleaseManifest
:Firebase:processReleaseResources
:Firebase:generateReleaseSources
:Firebase:incrementalReleaseJavaCompilationSafeguard
:Firebase:compileReleaseJavaWithJavac
:Firebase:processReleaseJavaRes UP-TO-DATE
:Firebase:transformResourcesWithMergeJavaResForRelease
:Firebase:transformClassesAndResourcesWithSyncLibJarsForRelease
:Firebase:mergeReleaseJniLibFolders
:Firebase:transformNative_libsWithMergeJniLibsForRelease
:Firebase:transformNative_libsWithSyncJniLibsForRelease
:Firebase:bundleRelease
:prepareAndroidArchLifecycleRuntime100Library
:prepareComAndroidSupportSupportCompat2610Library
:prepareComAndroidSupportSupportCoreUi2610Library
:prepareComAndroidSupportSupportCoreUtils2610Library
:prepareComAndroidSupportSupportFragment2610Library
:prepareComAndroidSupportSupportMediaCompat2610Library
:prepareComAndroidSupportSupportV42610Library
:prepareComGoogleAndroidGmsPlayServicesAdsIdentifier1600Library
:prepareComGoogleAndroidGmsPlayServicesBase1601Library
:prepareComGoogleAndroidGmsPlayServicesBasement1601Library
:prepareComGoogleAndroidGmsPlayServicesMeasurementApi1630Library
:prepareComGoogleAndroidGmsPlayServicesMeasurementBase1630Library
:prepareComGoogleAndroidGmsPlayServicesStats1601Library
:prepareComGoogleAndroidGmsPlayServicesTasks1601Library
:prepareComGoogleFirebaseFirebaseAnalytics1630Library
:prepareComGoogleFirebaseFirebaseAnalyticsImpl1630Library
:prepareComGoogleFirebaseFirebaseAppUnity521Library
:prepareComGoogleFirebaseFirebaseCommon1610Library
:prepareComGoogleFirebaseFirebaseCore1607Library
:prepareComGoogleFirebaseFirebaseIid1710Library
:prepareComGoogleFirebaseFirebaseIidInterop1601Library
:prepareComGoogleFirebaseFirebaseMeasurementConnector1701Library
:prepareComGoogleFirebaseFirebaseMeasurementConnectorImpl1705Library
:prepareComGoogleFirebaseFirebaseMessaging1740Library
:prepareComGoogleFirebaseFirebaseMessagingUnity521Library
:prepareGradleOutFirebaseUnspecifiedLibrary
:prepareReleaseDependencies
:compileReleaseAidl
:compileReleaseRenderscript UP-TO-DATE
:generateReleaseBuildConfig UP-TO-DATE
:mergeReleaseShaders UP-TO-DATE
:compileReleaseShaders UP-TO-DATE
:generateReleaseAssets UP-TO-DATE
:mergeReleaseAssets
:generateReleaseResValues UP-TO-DATE
:generateReleaseResources UP-TO-DATE
:mergeReleaseResources
:processReleaseManifest
:processReleaseResources
:generateReleaseSources
:incrementalReleaseJavaCompilationSafeguard
:compileReleaseJavaWithJavac
:compileReleaseNdk UP-TO-DATE
:compileReleaseSources
:lintVitalRelease
:prePackageMarkerForRelease
:transformClassesWithDexForRelease FAILED

BUILD FAILED

Total time: 15.891 secs
]
exit code: 1
UnityEditor.Android.Command.WaitForProgramToRun (UnityEditor.Utils.Program p, UnityEditor.Android.WaitingForProcessToExit waitingForProcessToExit, System.String errorMsg)
UnityEditor.Android.Command.Run (System.Diagnostics.ProcessStartInfo psi, UnityEditor.Android.WaitingForProcessToExit waitingForProcessToExit, System.String errorMsg)
UnityEditor.Android.GradleWrapper.RunJava (System.String args, System.String workingdir, UnityEditor.Android.Progress progress)
Rethrow as GradleInvokationException: Gradle build failed
UnityEditor.Android.GradleWrapper.RunJava (System.String args, System.String workingdir, UnityEditor.Android.Progress progress)
UnityEditor.Android.GradleWrapper.Run (System.String workingdir, System.String task, UnityEditor.Android.Progress progress)
UnityEditor.Android.PostProcessor.Tasks.BuildGradleProject.Execute (UnityEditor.Android.PostProcessor.PostProcessorContext context)
UnityEditor.Android.PostProcessor.PostProcessRunner.RunAllTasks (UnityEditor.Android.PostProcessor.PostProcessorContext context)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Is it possible that you need to update your Android SDK's build tools component?  See this.
Are you able to reproduce this with our sample project(s) (in this repo)?

Thank you for response.
I had this problem on other unity project.
Today success on Android after I updated Google play game service  plugin from 0.9.5 to 0.9.62.
Because this plugin updated 3 days ago.
https://github.com/playgameservices/play-games-plugin-for-unity
Added Assets/Plugins/Android/com.google.firebase.firebase-iid-17.0.4.aar
Deleted Assets/Plugins/Android/com.google.firebase.firebase-iid-17.1.0.aar
This is one of diff after android resolve.

It used to work fine but this week I'm having the same issue.
I was able to build my project, but now it failed when I clicked 「Android Resolver」 => 「Resolve」and built.
Then when I revert those diff, it succeeded again.
I will list the diff below:
(I just clicked「Resolve」button and didn't change any dependencies.xml files)

before
after

<file>Assets/Plugins/Android/com.google.firebase.firebase-common-16.0.4</file><file>Assets/Plugins/Android/com.google.firebase.firebase-iid-17.0.4.aar</file><file>Assets/Plugins/Android/com.google.firebase.firebase-messaging-17.3.4.aar</file>
<file>Assets/Plugins/Android/com.google.auto.value.auto-value-annotations-1.6.jar</file><file>Assets/Plugins/Android/com.google.firebase.firebase-common-16.1.0</file><file>Assets/Plugins/Android/com.google.firebase.firebase-iid-17.1.0.aar</file><file>Assets/Plugins/Android/com.google.firebase.firebase-messaging-17.4.0.aar</file>

I guess it's not caused by Firebase Messaging Plugin For Unity,  but I want to report this here to see if they come up with solutions.
Also, I will try to update build tools on our build machine tomorrow.
Here is my environment info:
Unity 5.3.6p4
Firebase Messaging version 5.4.4
Google.JarResolver_v<IP_ADDRESS>
Build System: Gradle

@wei-jiaxing, I think your guess is probably right. There's probably a conflict between the versions of Firebase you're trying to use and the dependencies that some other library is expecting.
Can you try to reproduce this in the quickstart app? If you can get the quickstart app to run, try adding the other libraries you're using one at a time until the build breaks again. That way you can diagnose where the conflict is coming from.

Thank you for advice.
When there are Firebase's dependencies.xml files only, it resolves the library version I write in before column and works.
But when I add com.google.android.gms:play-services-xxx, the conflict has occurred and it resolves the library version I write in after column then build become failed.
Here is the conflicting dependencies infomation.
Some conflicting dependencies were found.
The following dependency versions were modified:
com.google.android.gms:play-services-basement:9.4.0 --> com.google.android.gms:play-services-basement:9+
com.google.android.gms:play-services-location:9.4.0 --> com.google.android.gms:play-services-location:+
com.google.firebase:firebase-auth:16.1.0 --> com.google.firebase:firebase-auth:+
com.google.firebase:firebase-common:16.0.4 --> com.google.firebase:firebase-common:16+
com.google.firebase:firebase-core:16.0.6 --> com.google.firebase:firebase-core:+
com.google.firebase:firebase-iid:17.0.4 --> com.google.firebase:firebase-iid:+
com.google.firebase:firebase-iid:[17.0.4] --> com.google.firebase:firebase-iid:+
com.google.firebase:firebase-messaging:17.3.4 --> com.google.firebase:firebase-messaging:+

I don't know why the com.google.android.gms:play-services-xxx affects the firebase's library version.
But the problem was solved when I changed

com.google.android.gms:play-services-basement:9.4.0 --> com.google.android.gms:play-services-basement:16.0.1(the com.google.android.gms:play-services-basement.aar version in Plugin/Androids)
com.google.android.gms:play-services-location:9.4.0 --> com.google.android.gms:play-services-location: 16.0.0(com.google.android.gms:play-services-location.aar version in Plugin/Androids)

Back to the error Dex: Error converting bytecode to dex: Cause: Dex cannot parse version 52 byte code. This is caused by library dependencies that have been compiled using Java 8 or above.
It seems that one of the file was been compiled using Java 8 or above and cannot be built by unity.
I will temporarily change the version as I wrote above before resolved
<file>Assets/Plugins/Android/com.google.auto.value.auto-value-annotations-1.6.jar</file>
<file>Assets/Plugins/Android/com.google.firebase.firebase-common-16.1.0</file>
<file>Assets/Plugins/Android/com.google.firebase.firebase-iid-17.1.0.aar</file>
<file>Assets/Plugins/Android/com.google.firebase.firebase-messaging-17.4.0.aar</file>

I don't think you should need to add play-services to the dependencies.xml file. In fact, I don't think you need to manually edit that file at all. Is there a reason you're manually adding that?

Oh, I forgot to say that play-services is used by other plugins in my project

play services resolver is importing 'com.google.auto.value.auto-value-annotations-1.6.jar', this is compiled by Java8(1.8).
but auto value annotation 1.6.3 is compiled by Java7. so, to avoid the error,  use 1.6.3.
e.g. add new dependency file 'FooBarDependencies.xml' and write
<dependencies>   <androidPackages>     <androidPackage spec="com.google.auto.value:auto-value-annotations:1.6.3">     </androidPackage>   </androidPackages> </dependencies>
then resolve and build.

Hi @izibazi, would like to double check if your issue has been resolved.

Thank you. My issue has been resolved by upgrade google-play-services plugins.
https://github.com/firebase/quickstart-unity/issues/321#issuecomment-469234259


Svg image and event handler?

Is there a way to detect clicks/taps on a image?
/Oliver

SkiaSharp has this which FFImageLoading is based on, you can see some examples of it here:
https://github.com/xamarin/xamarin-forms-samples/tree/master/SkiaSharpForms/SkiaSharpFormsDemos

If you're using SvgCachedImage, you can just add a GestureRecognizer as in any other Xamarin.Forms view: https://developer.xamarin.com/guides/xamarin-forms/application-fundamentals/gestures/tap/

<?xml version="1.0" encoding="UTF-8"?>
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
     xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
     x:Class="App.Views.MainPage"
     xmlns:image="clr-namespace:FFImageLoading.Forms;assembly=FFImageLoading.Forms">
    <ContentPage.Content>
        <image:CachedImage Aspect="AspectFill" HeightRequest="200"
            WidthRequest="200" Source="usericon200.png"
            DownsampleToViewSize="true" HorizontalOptions="Center"
            VerticalOptions="Start" x:Name="ProfileImage">
            <image:CachedImage.GestureRecognizers>
                <TapGestureRecognizer Tapped="ActivateDebugMode"
                     NumberOfTapsRequired="7" />
            </image:CachedImage.GestureRecognizers>
        </image:CachedImage>
        <Image Source="settings50.png" VerticalOptions="Center"
            TranslationX="80" TranslationY="-50"
            HorizontalOptions="Center" WidthRequest="40">
            <Image.GestureRecognizers>
                <TapGestureRecognizer Tapped="OpenSettings" NumberOfTapsRequired="1" />
            </Image.GestureRecognizers>
        </Image>
    </ContentPage.Content>
</ContentPage>

Is there any way to add custom gesture recognizer? Before applying FFImageLoading I had custom ImageRenderer. Is there any way to "subscribe" or override CachedImage OnTouch event?


Whitelist SPV_GOOGLE_user_type extension

The smoketest failure in glslc-tests is fixed upstream by now.
The MSVC failures is to be fixed in https://github.com/KhronosGroup/SPIRV-Tools/pull/2675

Thanks @dneto0

Sorry, this is going to need another rebase to pick up #2676


phd info

Offered in Physics, Chemistry, Mathematics and Statistics. M.Sc. students of The Department of Physics are allowed to continue for a Ph.D.

again phd


[Pigeon] add support for C/C++ handlers

The public platform channels API doesn't support this but we support it internally.  We'd have to make that API public, create a new code generator and somehow make it easy to get the generated code compiled and linked into the plugin/app.
related issue: https://github.com/flutter/flutter/issues/70254

As multi-threaded callback on Dart function is quite hard: https://api.flutter.dev/flutter/dart-ffi/Pointer/fromFunction.html

The returned function address can only be invoked on the mutator (main) thread of the current isolate. It will abort the process if invoked on any other thread.

We are working heavily on Windows/macOS C/C++ plugin implementation
Any update for Pigeon support for C/C++?

@Sunbreak There's currently no timetable for this feature.  There is more and more interest to contribute to Pigeon internally and from external contributors, but I wouldn't expect it in the next 6 months.


Remove trailing tag spaces, keep inline children inline, fix top-level sibling indent

Fixes 3 minor issues:

Opening <tag > with no attributes now correctly renders as <tag> (no extra space)
Inline children, such as Link Text now renders inline, rather than as:

  Link Text

This is important because the extra white-space actually changes what a browser will display.

HTML/XML fragments which have multiple top-level nodes no longer indent each child further, as:

Fragment 1

Fragment 2

Fragment 3

This is amazing! Thanks!


AAL extra parameters with multiple search items

Reading through the AAL calculator documentation, it looks like inputting extra parameters (e.g. a custom first floor elevation) can only be done through the command line on an item-by-item basis. As an extra feature, it would be very helpful to be able to pass a vector of extra parameters alongside a vector of search items when pulling data from a python file across many FSIDs.
Happy to clarify, and thank you as always for all the great API features and support!

Hi @mulderphilip,
Yes, that's one of the features I thought about as well when updating the library but didn't have time to implement.
I have this on the backlog, but it might be a while before I can get to it


with the module class can you put a module inside of a module?

Hi there, I've noticed that a lot of things inside of the designers comps I'm working with could be considered a module...
however, when I started to code the site I begun to overwrite module properties because the things I was inheriting didn't follow the design.
I assume you wouldn't put a module inside of a module... but in the facebook design there are modules inside of modules... unless these stacked items should be called something else.
please advise.
Thanks!

Was there ever an actual answer to this?

@BenLeggiero it was 8 years ago, I’m having trouble remembering what my intent was. But no, never got answered.


Page alias with redirect

Checking the docs for page routing tells me that I can set aliases for a page or specify a redirect. But what I cannot do right now is to specify an alias that redirects to the main URL. Would that be possible?
Cause a "normal" alias, as it is right now gives bad SEO, as it is just duplicated content. Having that alias redirect function in the page header would be super handy, as you can always specify outdated/old/legacy URL in there directly.

If you set pages.redirect_default_route: true in system.yaml it should redirect any alias to the default route.

Thanks, that works.
With Grav 1.7.8 it is also possible to set the redirect code to 301:
redirect_default_route: 301


Package.loadSettings is deprecated.

Store package settings files in the settings/ directory instead of scoped-properties/
Package.loadSettings (/usr/local/share/atom/resources/app/src/package.js:565:9)
<unknown> (/usr/local/share/atom/resources/app/src/package.js:187:43)

Atom: 0.189.0-edd46e4

Thank you for reporting. I will check it.

It already fixed in @716739a