Regression coverage for refcount handling

There's currently no regression coverage for refcount handling beyond what testcases and assertions cover. It would be nice to have more automatic regression coverage for refcount handling.
If refcount is artificially high, this usually goes unnoticed because mark-and-sweep ignores refcounts and will collect garbage even when their refcount is > 0. This is also memory safe, so the only functional issue is late memory freeing and potentially late finalizer execution. If refcount is artificially low, memory unsafe behavior may happen; this is obviously usually noticed quite quickly.
A mark-and-sweep like process could be used to calculate the correct refcounts for all heap objects and the refcounts could then be compared. However, refcounts are artificially bumped e.g. during refzero finalizer execution which would need to be fixed first (e.g. by pushing the value being finalized instead, so that the refcount bump is also associated a reference). As a practical matter replicating mark-and-sweep code for assertions only would be quite awkward. On the other hand running a mark-and-sweep essentially for doing assertions would also be awkward because mark-and-sweep has side effects.
A compromise approach would be to recompute refcounts during mark-and-sweep when assertions are enabled, and then compared them at the end of mark-and-sweep. Each duk_heaphdr would get an extra field with assertions enabled to allow the comparison. Refcounts would thus be checked on every mark-and-sweep pass -- too late to easily identify the cause, but still better than nothing.
A black box approach would be to start measuring testcase memory usage patterns and make commit tests point out any significant deviations from previous. For example, when refcounts work correctly many testcases have a relatively smooth memory usage profile. When a refcount is too high, and a lot of such objects are created, memory usage becomes more of a sawtooth because mark-and-sweep releases the garbage as a backstop. Just comparing maximum memory usage to previous master would identify such a sawtooth as well as other bugs.

However, refcounts are artificially bumped e.g. during refzero finalizer execution

I've never understood why this was necessary.  The finalizer is passed the object being finalized as a parameter, so that should be enough to ensure the object remains reachable during finalizer execution, right?

What if the finalizer says argumentObject = null? Similarly, when the finalizer call returns and the value stack is unwound, the argument would have its refcount drop to zero before the call site for the finalizer would be able to do anything about it.
The main point is to avoid a refzero event for the object because we're already in refzero handling. This is now achieved by a refcount bump. It could equally be pushed on the value stack though.

So to clarify, it's not enough for the value to get into the finalizer safely - it must also come out without being refzero processed so that we can decide whether to rescue or free the object without the object being re-queued into the refzero list (which would cause an infinite loop because we're already processing that list).

Hm, would it be possible just to add a check to refzero processing to ensure it can't be invoked recursively, like mark-and-sweep does now?

Refzero processing (refzero free pending) is not entered recursively and there's a flag against that (which has a checking cost unfortunately). That's not the issue here; instead, the refzero code would queue the object back into the refzero_list (at the tail) so it would get processed again (and again) but the current "refzero free pending" call which works the list until it becomes empty.
The cheapest way to prevent that is to ensure the refcount doesn't drop to zero during finalization - otherwise some extra flags and flag checks would be needed for every refzero event anywhere.

Ah, I see.  That makes sense: Mark-and-sweep deals with the entire heap as a unit, while refzero logic is more localized and concerned with individual objects.  So what works for one mechanism doesn't necessarily work for the other one.

Yep, the sequence of events is roughly:

A DECREF operation drops some refcount to zero.
The object in question is queued to refzero_list.
The duk_refzero_free_pending() function is called to process the refzero_list, which at this point only has one object.
The function processes the head of refzero_list until it becomes NULL. Each object freed may call further DECREF operations for whatever references it points to (just before being freed).
Each such DECREF may have another refcount to drop to zero. These are handled by queueing them to the tail of refzero_list so that the initial duk_refzero_free_pending() will process them, in order.
The duk_refzero_free_pending() function is called but it returns as a no-op because the list is already being processed.
As a result, an entire object tree (without cycles) is potentially freed, inline in the initial DECREF operation.

In general there are one or two flags that could be eliminated from the current solution. It may seem unimportant but since the checks affect potentially every refcount or at least every refzero situation, it adds up easily. Also the current refcount code is not very efficient considered as a whole, and there's much room for improvement.
For example, the refzero-within-refzero case could be handled a bit more efficiently by making the "process refzero list" a function pointer and make the first call replace it with a nop function so that no explicit flag check would be needed in the common case.

Another simple improvement is to combine the refzero_list queueing and "free pending" checks so that:

If refzero_list is NULL before queueing, no "free pending" is running and we should start one.
If refzero_list is not NULL before queueing, a "free pending" is already running and we don't need to start one.

This would be nice because the queueing code needs to check for refzero_list == NULL anyway in the queueing code.
I'll try this out in a pull ;)

Hmm, that won't strictly work as described above because in some cases objects are refzero queued without a "free pending" check (e.g. the NORZ macros).

#1406 adds refcount asserts.


Underline goes 1 character to far

When you user underline
    <Grid>
        <TextBlock TextDecorations="Underline">This is a test</TextBlock>
    </Grid>

it generates 1 char to much

Also, Line has same bug
<StackPanel>
    <TextBlock Foreground="White">0123456789</TextBlock>
    <Canvas Grid.Row="1" Background="Black" Width="20" Height="1" HorizontalAlignment="Left" >
        <Line StartPoint="0,0" EndPoint="10,0" Stroke="Yellow" StrokeThickness="1"/>
    </Canvas>
</StackPanel>

draws one char too many


Added New Playbook

New Playbook Added

In SFSP v2.0.2, playbook 03 Enrich > Indicator (Type URL) - Get Reputation (Fortinet Sandbox) got removed.
The "Investigate Suspicious Email" playbook that refers to the same playbook fails as it no longer exists
To resolve this, added the playbook  Indicator (Type URL) - Get Reputation (Fortinet Sandbox) in the SP collection "02 - Use Case - Phishing Email Response"

UTC:

For Upgraded SFSP v2.0.2

Upgraded SFSP from v2.0.0 to v2.0.2
the playbook "Investigate Suspicious Email" executed successfully

For Fresh SFSP v2.0.2

the playbook "Investigate Suspicious Email" executed successfully

Doc Input

Added release_notes.md
Updated content.md with information related to the newly added playbook "Investigate Suspicious Email"


node exit with Error [ERR_HTTP2_SESSION_ERROR]

Description
process crashed with error when fetch in try-catch context
the exception was caught, but nodejs still exit.
Version:
"@adobe/helix-fetch": "^3.0.0"
nodejs v16.13.0
Crash log:
[2021/12/31 20:26:23][error] error: FetchError - Session closed with error code 1
[2021/12/31 20:26:23][info] retry after 10s
Error [ERR_HTTP2_SESSION_ERROR]: Session closed with error code 1
at new NodeError (node:internal/errors:371:5)
at Http2Session.onGoawayData (node:internal/http2/core:679:21) {
code: 'ERR_HTTP2_SESSION_ERROR'
}

Is this reproducible? If so please provide  self-contained example code which demonstrates the issue.

It rarely happens.
I've only see it twice in the past month.

@ranbochen AFAIU, node doesn't crash (as in segfault / process.exit) but rather your code throws a unhandled exception.
fetch is allowed to throw error for different reasons, eg network down, host unreachable, dns error, etc. so those should probably be anticipated by your code and the request should be retried.

@ranbochen AFAIU, node doesn't crash (as in segfault / process.exit) but rather your code throws a unhandled exception. fetch is allowed to throw errors for different reasons, eg network down, host unreachable, dns error, etc. so those should probably be anticipated by your code and the request should be retried.
you might also start node with --trace-uncaught to show stack traces for the throw behind uncaught exceptions.

I mean app crashed.
all my calls to fetch is in try-catch context,
and  log shows error has been catched, but app still crashed.
that's odd

all my calls to fetch is in try-catch context,

and you await the calls to fetch ?

sure thing~
the log says
there are two error throw out.
first: Http2 throw "NodeError", helix-fetch catch it and translate to "FetchError" , then throw to app.
my app catch "FetchError" and print it out.
then the second http2 "NodeError" happens, no one catch it, so app crashed.

see https://github.com/adobe/helix-fetch/issues/238#issuecomment-1005771491

Note that as of Node v16 unhandled promise rejections trigger process.exit(1) rather than just printing a warning on the console.
You can prevent the process termination by a adding a global unhandledRejection handler, e.g.:
process.on('unhandledRejection', (reason, promise) => {
  console.log('Unhandled Rejection at:', promise, 'reason:', reason);
});

i think it's a nodejs issues, it may throw error twice in http2 module~
the first throw can be handled in try-catch, but the second ... nothing we can do in our code.
add process.uncaughtException handler will prevent app crash
you can close the issue report.
[2022/1/9 19:57:16][info] 10 秒后重试
node:events:368
      throw er; // Unhandled 'error' event
      ^

Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code NGHTTP2_PROTOCOL_ERROR
    at new NodeError (node:internal/errors:371:5)
    at ClientHttp2Stream._destroy (node:internal/http2/core:2313:13)
    at _destroy (node:internal/streams/destroy:102:25)
    at ClientHttp2Stream.destroy (node:internal/streams/destroy:64:5)
    at Http2Stream.onStreamClose (node:internal/http2/core:545:12)
Emitted 'error' event on Readable instance at:
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  code: 'ERR_HTTP2_STREAM_ERROR'
}

[2022/1/10 22:53:52][debug] Starting work
[2022/1/10 22:54:24][error] error: AbortError - The operation was aborted.
[2022/1/10 22:54:24][info] 10 秒后重试
node:events:368
      throw er; // Unhandled 'error' event
      ^

RequestAbortedError
    at EventEmitter.onAbortSignal (D:\proj\proj\node_modules\@adobe\helix-fetch\src\core\h2.js:235:14)
    at EventEmitter.emit (node:events:390:28)
    at AbortSignal.dispatchEvent (D:\proj\proj\node_modules\@adobe\helix-fetch\src\fetch\abort.js:67:41)
    at AbortSignal.fire (D:\proj\proj\node_modules\@adobe\helix-fetch\src\fetch\abort.js:72:10)
    at AbortController.abort (D:\proj\proj\node_modules\@adobe\helix-fetch\src\fetch\abort.js:137:39)
    at Timeout._onTimeout (D:\proj\proj\dist\utils\fetch.js:36:49)
    at listOnTimeout (node:internal/timers:557:17)
    at processTimers (node:internal/timers:500:7)
Emitted 'error' event on Readable instance at:
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

[2022/1/12 17:05:23][error] error: FetchError - The pending stream has been canceled (caused by: connect ETIMEDOUT <IP_ADDRESS>:443)
[2022/1/12 17:05:23][info] 15 秒后重试
[2022/1/12 17:05:23][error] *******************************************************************
[2022/1/12 17:05:23][error] uncaughtException: Error
Error [ERR_HTTP2_STREAM_CANCEL]: The pending stream has been canceled (caused by: connect ETIMEDOUT <IP_ADDRESS>:443)
    at new NodeError (node:internal/errors:371:5)
    at closeSession (node:internal/http2/core:1133:20)
    at ClientHttp2Session.destroy (node:internal/http2/core:1512:5)
    at TLSSocket.socketOnError (node:internal/http2/core:2962:13)
    at TLSSocket.emit (node:events:390:28)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  cause: Error: connect ETIMEDOUT <IP_ADDRESS>:443
      at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1161:16) {
    errno: -4039,
    code: 'ETIMEDOUT',
    syscall: 'connect',
    address: '<IP_ADDRESS>',
    port: 443
  },
  code: 'ERR_HTTP2_STREAM_CANCEL'
}
[2022/1/12 17:05:23][error] *******************************************************************

@ranbochen Thanks for the update. I am closing this issue.


Add a missing invalid chunk_keys verificartion in #configure

In #2, I've forgot to add tag existence checking in #configure.
Fluentd plugins should check its config parameter validity in #configure.
Sorry for inconvenience.
Thanks,

Thanks!


issues installation

Hi,
get this message when trying to go through the steps:
How to run InComb

Create a new MySQL database from the schema in src/main/sql/schema.sql
Execute src/main/sql/data.sql
Adjust your settings in WebContent/WEB-INF/conf/incomb_config.json

Get this when running step 2.
#1452 - Cannot add or update a child row: a foreign key constraint fails (incomb.fly_with, CONSTRAINT fk_User_has_User_User1 FOREIGN KEY (user_id) REFERENCES user (id) ON DELETE NO ACTION ON UPDATE NO ACTION)
Any ideas?
thanks

Can you post the specific SQL statement which triggers your error?

INSERT INTO fly_with (user_id, fly_with_id, fly_with_start_date) VALUES (1, 2, '2015-01-04 01:26:34')

It looks like you didn't have the current version of our project.
Allfly_withgot removed from data.sql since they are covered in test.sql.

ok... So if I download the latest version it all should be ok then?

cool project by the way...

Thank you.
Yes, I guess so. Fly with is in our definition a user which follows another user. But we removed the users from data.sql earlier.

Please let us know if you need any further help. We're happy to help.

yeah...
downlöoad the a,ltest veriosn and installed DB and got this message when executin data.sql::
#1452 - Cannot add or update a child row: a foreign key constraint fails (incomb.category_preference, CONSTRAINT fk_CategoryPreference_User1 FOREIGN KEY (user_id) REFERENCES user (id) ON DELETE NO ACTION ON UPDATE NO ACTION)

this is what causing this:
INSERT INTO category_preference (user_id, category_id, factor) VALUES(1, 1, 1.0)

Should be working now, there was still left over test data of the test users...

:-(
sorry...
#1062 - Duplicate entry '1' for key 'PRIMARY'
caused by:
INSERT INTO incomb.module (id, name_key, image_path, template_path) VALUES(1, "modules.news", "", "")

You need to remove the current data first. Please execute schema.sql again and then try again with data.sql

that did it I think... Thanks :-)


G2p master merge

@bwalsh here's the merge of master into the g2p branch

We should merge this ASAP so we can open a PR against master and start the final review.

@dcolligan @saupchurch Working with G2P/RNA merge:  All tests pass except one - server/tests/datadriven/test_rna_quantification.py
Failure: OSError ([Errno 2] No such file or directory: 'tests/data/datasets/dataset1/rnaQuant')


Support static HTML/JS/CSS generation from spec via npm tooling

It would be great to be able to take any Open API spec and generate a set of static HTML/CSS/JS output (same as what is dynamically rendered by ReDoc currently)
I don't really understand the current trend of ONLY supporting dynamically rendered documentation tools... It would be really nice to be able to automate static HTML/CSS/JS docs at build time so they could be bundled up and deployed to a standard web server.  This would greatly ease managing docs for lots of internal projects, offline distribution to clients, offline viewing, etc.

related to #62

Seems to me like getting the best of both worlds would be quite doable with a "dynamic static site generator" like @KyleAMathews' https://github.com/gatsbyjs/gatsby. Being built on top of an existing project like that would also mean you could focus primarily on solving API documentation problems, and spend less time solving "rendering stuff on a page" problems.
I've not seen many such projects for Angular though, so making this happen would probably require a major rewrite. In other words, not likely to happen :P Just wanted to float the idea.

Would be happy to help with this! It'd be a great fit for Gatsby. Gatsby 1.0 will have theme support plus be able to generate sites very easily straight from the specs.
https://github.com/gatsbyjs/gatsby/issues/419

Hey @erlend-sh. Thanks for the idea 👍
We will definitely evaluate it.
But this definitely won't happen in the near feature. As we are moving to more interactivity and I'm not sure we can get enough flexibility with gatsby (thanks @KyleAMathews for offering help) or similar tools. E.g. recently we've added search, and are going to implement API Console for ReDoc.

Cool! Best of luck with things.
FWIW, Gatsby would easily be able to do search, an API console, etc. as sites are built using React components so frontend interactive bits are trivial.

To clarify: ReDoc is not server-side tool. You can just deploy it to any static web-server and with and will work.
ReDoc is dynamic only in terms of the client browser as it requires spec to work and builds the doc on the fly.
There is no plan to support fully static behaviour. At least in the nearest future.

Thanks Roman for the reply,
I understand that  if  we want  to deploy API documentation, we deploy redoc build engine with the required JS and swagger files and after that we start redoc (npm start) which  renders the API documentation.
Is there any way to pre generate the required  files and deploy only the generated files (not the ReDoc build engine) . To be more precise,  is there any way to render the API without deploying the ReDoc build engine.
By looking at your reply it seems there is no way and the ReDoc build engine is required to render the swagger in client browsers.  Could you please confirm it.
Thanks & Regards

You don't have to start redoc with npm start. You don't need npm, node, nothing!
All you need is to just deploy html page to the server. Here is the example of simplest html page:
https://github.com/Rebilly/ReDoc#tldr

Closing as out of scope

@KyleAMathews what would we need to do to make this Gatsby-compatible?

@braco in fact, it is already Gatsby-compatible.

static API doc generator based in React would be amazing and widely adopted
We think so and we are working on this. Stay tuned 😉!

Hey @RomanGotsiy! Thanks for the reply. You're saying we can expect a true static output sometime... soon? Cool! Thanks for all your work.

I had the same problem with React Static. Redoc's sidebar in React version of Redoc didn't work when embedded in react static.
There were several ways to solve this issue, One of them was to create the documentation pages separately and not include them in the routes rather, locate them in public folder.

Another method, which I am using currently is to embed a static page with redoc script and container as an iframe. It does have it's own disadvantages, for example, the scrolling could be janky. But it suited my usecase.

@xypnox Can you elaborate on "didn't work"? What were the symptoms? (Working w/ inegrations here, too.)
FWIW Our chief issue has been the size of our API. When client-side rendered all on a single page, it's a big performance issue. But that's not exactly "because it's React and we need static HTML." Lighthouse complains about the number of HTML nodes. Crashed browsers. Would've happened even with a static HTML page.
So we actually needed output chunked into multiple smaller pages. We've been looking at https://redocpro.redoc.ly/ to solve that. No iframe was needed.

In the beginning I thought the trouble was with redoc's inability to generate static pages. However I found the problem in this thread: https://github.com/Redocly/redoc/issues/433#issuecomment-487187549
The problem is with smooth scrolling.
This should be a part of FAQ where it should be mentioned that scrolling doesn't work with smooth scrolling turned on using css.
Or are there future plans to mitigate this?


Replaced ternary with bitwise magic

The submitted change, as proposed by @00asdf should be a bit faster :)

bruh this doesn't even compile. Cannot implicitly convert type 'ulong' to 'int'

:(

Also it doesn't actually work lol, here's the output from running the (fixed) code 10 times
18446744073709551615
18446744073709551615
18446744073709551615
1
18446744073709551615
18446744073709551615
18446744073709551615
1
18446744073709551615
18446744073709551615

Superseded by 6afeed6


Upscale amount field size in send form once shorter value entered

It seems that once we downscale the amount field in the send form, we don't then upscale it again if the user changes the entered value to a shorter value than the longer one that caused the downscaling in the first place. Ideally we rescale up and down as necessary based on values.
https://github.com/hirosystems/wallet/assets/28991/8dab3988-5280-485b-b4eb-dae8cec974f3

Hey @markmhx I got a PR open to fix this https://github.com/hirosystems/wallet/pull/4012 😀
I would appreciate a review
Thanks!

Much thanks, @ddanielcruzz!


How to detect in parallel

I use from concurrent.futures import ThreadPoolExecutor as Exe.
then
class ObjectTrack:
def init(self):
self.config = Config.config['root']
def __load_picture(self, image):
    img = tf.image.decode_image(image, channels=3)
    img = tf.expand_dims(img, 0)
    return transform_images(img, self.config['size'])

def decode_pictures(self):
    # 本地测试，正常使用socket
    import json
    with open('Data/SeriImageArray.json', 'rb') as f:
        res = json.load(f)
    pars = [[bytes(image['Image']), res['batch'], True] for image in res['Imagelist']]
    for par in pars:
        self.wrap_decode_picture(par)
    with Exe(4) as Pool:
        Pool.map(self.wrap_decode_picture, pars)

def wrap_decode_picture(self, pars):
    self.decode_picture(*pars)

def decode_picture(self, image=bytes(), batch=1, accurate=False):
    model = Model.model_accurate.copy()
    image = self.__load_picture(image)
    boxes, scores, classes, nums = model(image)
    res = [[np.array(scores[0][i]), np.array(boxes[0][i])] for i in range(nums[0]) if int(classes[0][i]) == 0]

    json_str = {"batch": batch,
                'time': time(),
                "code": "00001",
                "target_info": []
                }
    for score, box in res:
        json_str["target_info"].append(
            {'box': box.tolist(),
             "player": 1,
             "person": 1,
             "socre": float(score)}
        )
    print(json_str)

but nothing happened.Maybe it's because the model can't be serialized
What are the methods of parallel recognition？
thanks

i would recommend using tensorflow serving for multi threaded inference.
I don't think tensorflow is easy to setup in multithreaded mode

Thank you very much.
How to identify pictures in batches?
How should it be modified?

instead of threadpool you should use keras predict_on_batch. Tensorflow is already multithreaded internally, there is no need to run multiple model in parallel


Fix integration tests running with VFS retention enabled

We want that all our integration tests pass with VFS retention enabled.

Things we need to fix for VFS retention to work:

when cleaning up empty source files, notify the global VFS
when cleaning up stale output files, notify the global VFS
GeneratedSingletonFileTree needs to notify the VFS when it creates the file - or replace the type by a task for generating the Manifest
Only watch parents which are directories. For missing files, the parent can also be a file, and we would currently try to watch it.

There are more problems, which I would fix later:

fix watching symlinks, aka the target of a symlink in the input/output of a task changes.
Detect changes while the build is running.

Finally, there is some flakiness in IncrementalJavaAvoidanceAgainstClassDirIntegrationSpec, which causes changes to the annotation processor sources to go undetected. I still don't know what is going on there.

Another problem: We currently don't inform the VFS, that the previous output is cleaned in CleanupOutputsStep. That isn't a problem when the previous output is in the same location, but it is a problem when the previous output is somewhere else and the task has been reconfigured.
In BuildSrcPluginIntegrationTest the test uses Project.delete() at configuration time to remove some outputs. That also goes undetected and we try to watch the now non-exisiting directory. We should probably fix this later by watching files during the build as well.

There also seems to be a problem on macOS: When the parent directory is removed, then no events are received for a watched subdirectory. For example, when watching build/classes, and build is removed from the command line, we do not get any information about that. That causes some relocation tests to fail, e.g. Antlr2RelocationIntegrationTest.

I found this Rust library which offers an OS-independent API for file watching: https://github.com/notify-rs/notify
We could steal some things from there.

The failures are now understood, and I created the follow-up issues:

Fixes for the executor and some individual tests: https://github.com/gradle/gradle/pull/11848
Support long paths on Windows: https://github.com/gradle/gradle/issues/11832
Investigate failing play test: https://github.com/gradle/gradle/issues/11849
File change on macOS not recognized when whole watched directory is removed: https://github.com/gradle/gradle/issues/11833
Re-evaluate tests again when all the above is fixed: https://github.com/gradle/gradle/issues/11850

I am closing this PR for now.


Ensure compatibility with other libraries

In order for distributed tracing to work properly across languages/libraries, the format of messages in the different carrier formats should be consistent.
I have drafted a specification for my JavaScript implementation, and I would like to collaborate with you to make it evolve into a final version. I based the current specification on your project since it seemed to be the only OpenTracing implementation for Datadog (until now :). I haven't included the parent ID since I didn't understand its purpose (the span ID is the actual parent ID of the next span, so the parent ID would be the ancestor).
Please let me know what you think!

I am thinking on moving to ot-tracer- and ot-baggage- as text map prefixes. It seems to be what every example and most implementations are doing right now, so there are more chances for interoperability since new implementations are more likely to follow the common pattern.
@gchaincl What do you think? I would like to finalize this spec ASAP so I can finish version 1 of the JavaScript implementation and then help with yours :)

@rochdev the draft looks like a great initiative, I'd be happy to collaborate to achieve consistency.
You're right, propagate the ParentID doesn't make too much sense and it should be removed.
Regarding moving to ot- prefix, it makes sense if that's the standard, but AFAIK zipkinbg for example uses B3 (BigBrotherBird), so I think each implementation uses a different prefix, but I'm not completely sure.

My observation was based on these libraries:
https://github.com/opentracing/basictracer-go/blob/master/propagation_ot.go
https://github.com/opentracing/basictracer-python/blob/master/basictracer/text_propagator.py
https://github.com/opentracing/basictracer-javascript/blob/master/src/propagation.js
https://github.com/lightstep/lightstep-tracer-javascript/blob/master/src/imp/tracer_imp.js
However, I agree that this is in no way a standard. I was just thinking that if someone would build for example a python custom tracer, there are more chances of them using the ot- prefix if they look at the examples (I know I did when I started my tracer before I found your library).
I'm fine with leaving it as is if you think it's unnecessary since like you said it's inconsistent anyway.


Call initiating_close and delay delete_stream

Another issue found while tracking down leaked Http2ClientSessions using the zombie event (PR #3713).
Some cases the stream would be removed from the stream_list but then never deleted.   Replacing the calls to delete_stream with a call to stream->initiating_close solved the problem.  The delete_stream gets called from the stream destroys.

Yes, I'm not entirely sure this change is necessary.  I'm testing with this backed out of the environment that is exhibiting the leak.  Will close this PR assuming that the other changes make this good.

Ran without these fixes last night and the zombie event triggered multiple times on the INACTIVITY_TIMEOUT.  At the time of the zombie assert, fini_received is true, total_client_stream_count is 1, and stream_list is empty.   I'll adjust my test build to change the EOS to ERROR in initiating_close() but not make the other changes.   If that doesn't work, I'll try making the change from delete_stream to initiating_close only for cleanup_streams.
Sadly, the only machine I have access to exhibiting this behavior is in a far time zone and this issue only triggers at high traffic time, so I probably have to wait 15 hours to see if my current attempt fixes the issue.

Just changing the EOS to ERROR did not suffice.  I'm running now with changing delete_stream to initiating_close only for the cleanup_streams method.

Pushed a new version.  My problem machine ran all weekend and one business day with this fix and did not trigger the zombie debug crash.  We only replace delete_stream with initiating close on the cleanup_streams case which gets called in the cases when the session is coming down hard.  I also changed the destroy to transaction_done so the case where the HttpSM has already been cleared follows the more standard clean up process.  My last asserts were actually this case.  The current_reader (HttpSM) was null so it was never getting freed and termimate_stream was never being set.  Our version did not have the destroy in place.
I'll go ahead and try my problem case with the destroy added instead.

Closing this for now.  I need to get back to this scenario and reverify.


Requesting 'logstash-input-opensearch' plugin

Sorry I realise this isn't exactly what this repo is about, but I figure it's the closet there is...
Is your feature request related to a problem? Please describe.
Please create a logstash-input-opensearch plugin
Describe the solution you'd like
If for any reason, I'd need to export / re-process / reindex large amounts of logs data I no longer can.
Running Logstash version 7.16.2 against OpenSearch 1.2.3 with compatibility turned off you get the error message: Could not connect to a compatible version of Elasticsearch
The solution I'd like is a logstash-input-plugin that worked against opensearch.
Additional context
While I realise its not this repo's responsibility, perhaps you can notify the right persons to request it?  Other perhaps point me in the right direction for who to ask?
Many Thanks

HI @camAtGitHub Thanks for raising issue. We are working on adding new plugin . You can track this request here

I am closing this ticket since it is tracked in other place. Please comment in other ticket for any additional questions. Thanks.


prepareElement doesn't work with @material-ui

Type of issue
Bug
Description
Currently using material ui & Fusion.js results in an error with a stacktrace leading back to fusion-react. It seems that this may be resulting in mismatches when server rendering and hydrating.
Error message
Warning: Can't call setState on a component that is not yet mounted. This is a no-op, but it might indicate a bug in your application. Instead, assign to `this.state` directly or define a `state = {};` class property with the desired state in the TransitionGroup component.
	warningWithoutStack
react.development.js:244
warnNoop
react.development.js:293
enqueueSetState
react.development.js:362
./node_modules/react/cjs/react.development.js/Component.prototype.setState
react.development.js:413
componentWillMount
react-lifecycles-compat.es.js:12
renderCompositeElementInstance
prepare.js:36
prepareElement/<
prepare.js:89
run
es6.promise.js:75
notify/<
es6.promise.js:92
flush
_microtask.js:18

<EMAIL_ADDRESS>

Possibly something in here doesn't agree with our usage of prepare/prepared? https://github.com/reactjs/react-transition-group/blob/8943f40432e60d66ee2b5dc2eb6b660ed5dc9b34/src/TransitionGroup.js#L109-L119


Allow the Danger Meter to have a custom screen position

Kinda like those custom clients (Lunar) which allow you to move modules filled with information around.
It's a little hard to peek at the bottom left corner to check your danger, especially if you have a ultra wide monitor.

A Client Configuration For change the X and Y of the Overlay [Or even a "grab and drag" system] for any location of the screen sounds like a good feature


Serial Port

Hi
in the description, you name 34 and 33 as GPS serial pins
in the GPS scetch
#define RXPin 34
#define TXPin 35
are defined.
all correct ? - am i missing something ?
best Christoph

You are right, I put 33 by mistake.
Thanks for you contribution!


Updated wfc

Updated wfc to work with the updated encodings, and to produced a specified number of agents.
Issues (will add these as an issue on github):
Do some kind of hyperparameter tuning for the weights for different board sizes / number of agents;
Incorporate Ugo’s and Randy’s fancy removal methods for when the wfc board has too many wires.

I'll sort out docstrings tomorrow!
It can be guaranteed (kind of): I added the galaxy brained removal method of "just get rid of all wires over the limit" when the method produces too many wires; and if it doesn't produce enough, I restart the process and change the weights to be more likely to include start / end points. This should mean that it will eventually produce enough wires, although I imagine it will work poorly when someone tries to generate an incredibly packed board.

Added better docstrings

cool! I'll merge now


Autoloading issues after the introduction of Remountable API?

The introduction of this commit https://github.com/ruby-grape/grape/commit/cf14fc79d0100b988fb0d5ccd9182e3135e9ae48 completely broke one of my api's.
I get any possible erro from guess_for_anonymous when autoloading modules to missing methods from included module.
My API is mounted as:
# api_base.rb
class ApiBase < Grape::API
   mount InternalApi::Base
end

# internal_api/base.rb
module InternalApi
    class Base < Grape::API
        mount InternalApi::V1::Base
        mount InternalApi::V2::Base
....

# Then InternalApi::V1::Base and InternalApi::V2::Base mount the final api files

One of the error I get (undefined method paginate) from:
module InternalApi
    module V1
      class Base
          version :v2
           include Grape::Kaminari
           paginate per_page: 30, max_per_page: 200

Is this expected and does exists an upgrade guide?

Thanks for trying HEAD out @andreacfm, cc: @myxoh, related to #1803.
It would be helpful to get a spec that can reproduce this, let's fix it or document a workaround before release.

@dblock here a spec to show the failing in including modules.
https://github.com/ruby-grape/grape/pull/1816

Hi, I'm going to be looking at the issues caused by the PR now. Sorry, it's been a very heptic week for me

I haven't spent any time investigation besides just reverting, just sharing what I know
/dependencies.rb:203:in `guess_for_anonymous': SlackBot cannot be autoloaded from an anonymous class or module (NameError)

in application.rb
config.autoload_paths << "#{Rails.root}/lib"
Location of module
lib/slack_bot.rb
Somewhere inside Grape::API
include SlackBot

@rromanchuk I couldn't reproduce that on Rails 5.2. I'll try on 4.2. Perhaps you could answer a couple of questions for me?
Which Rails version are you using?
How are you loading the API?
Is the errors happening on load time or run time?

@andreacfm I also was't able to reproduce autoloading issues adding helpers V1Helpers where V1Helpers is a module of helpers. It seemed to work just fine

I couldn't reproduce on 4.2 either. It seems that my test case is not triggering the issue. I need more information to be able to help unfortunately

@myxoh

using Rails 4.2.10
api is mounted as per docs in routes.rb mount ApiBase => '/'
error fires on load

I will try to reproduce the error I get with the helpers in a spec. I have already submitted the error I get using include.

@myxoh autoloading errors are scary. Are you sure that the remountable  implementation worth the pain?

If you can post a sample git repo, I can work from that. While they are scary, they are not un-solvable. I want to at least give it a go.
I do believe remountable is worth the trouble, and I couldn't think of any other implementation that would make this faster. This is a very core change to the way things work, so things were bound to be somewhat broken.
The alternative was my first choice, having a separate set of APIs just for the remountable feature, but the issue with that is that they will always have second-class support.
No alternative is particularly attractive right now, but the feature I feel is a real must on grape.

@myxoh make sense. I will have something for you asap.

I agree, we definitely want remountable. Lets fix the bugs and move forward!

@myxoh sorry but I could not find the time to put together a test app. I will try by tomorrow ... busy days ... you know :)

Hi @rromanchuk . I've used your example as a basis for: https://github.com/myxoh/testing-grape
Could you try and make that project fail and raise a PR against it? Or anything that could help me get anything to fail

Wait @rromanchuk is your issue happening on grape 1.1???
If that's the case I think you have a different one, very likely not even related to grape at all!

@myxoh sorry, that was misleading, you should throw that information out, that's what is on production right now.  I only meant to share to give you context of potential troublesome gems. The issue started when i updated to the latest release against this github branch

@myxoh same for me. The issue appears when using a codebase that runs fine  with grape 1.1 on the last master.

@andreacfm , @rromanchuk I'm still waiting on any code that replicates the issue: please 😄 ? I've linked to a blank project use master on grape and the autoloader which has no issues. And I've tried using master on a large project I'm working on, also without issues.
I'm not sure what I'm doing differently from you, I need any blank rails project (or a PR to my project), or some more information that can help me fix the problem so that we can release

@myxoh I'll give this a go tomorrow

@rromanchuk, @andreacfm any luck?

I finally was able to reproduce the issue by including the gem Kaminari Grape. Will try to solve it now

Found the issue :smile:, creating a PR

@dblock if you are happy with that change, let's merge it. Afterwards could @rromanchuk  and @andreacfm test on your projects?
Let's get this over the line :trophy:

Closed via https://github.com/ruby-grape/grape/pull/1823
Please give HEAD a try.

@dblock @myxoh I have a new error. In one of my code base I was injecting some helper class method reopening Grape::API.
Grape::API.class_eval do
 include ....
end

The methods are not available anymore in my api classes that extend Grape::API. Is this an expected behaviour?

@myxoh works for me now. Thanks. Any idea of when this will be released?


missing type "object" for 5.1.0-rc2 container subschemas

When using the 5.1.0-rc2 container subschemas in ajv (with its default configuration of strictTypes), this output always occurs:
strict mode: missing type "object" for keyword "additionalProperties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_adpContainer.json#" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_adpContainer.json#" (strictTypes)

strict mode: missing type "object" for keyword "additionalProperties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_cnaPublishedContainer.json#" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_cnaPublishedContainer.json#" (strictTypes)

strict mode: missing type "object" for keyword "additionalProperties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_cnaRejectedContainer.json#" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_cnaRejectedContainer.json#" (strictTypes)

The issue may be in these parts of the subschema files:
https://github.com/CVEProject/cve-schema/blob/2aa608b6733cc2730a43901472ef0e706d0ef2b5/schema/v5.0/docs/CVE_JSON_adpContainer.json#L2553-L2560
https://github.com/CVEProject/cve-schema/blob/2aa608b6733cc2730a43901472ef0e706d0ef2b5/schema/v5.0/docs/CVE_JSON_cnaPublishedContainer.json#L2553-L2560
https://github.com/CVEProject/cve-schema/blob/2aa608b6733cc2730a43901472ef0e706d0ef2b5/schema/v5.0/docs/CVE_JSON_cnaRejectedContainer.json#L2553-L2560
For example, if the bottom of CVE_JSON_cnaPublishedContainer.json is modified to:
  },
  "type": "object",
  "properties": {
    "cnaContainer": {
      "$ref": "#/definitions/cnaPublishedContainer"
    }
  },
  "additionalProperties": false
}

(i.e., "type": "object", has been inserted), then the above six messages no longer occur.

I will run the ajv validator against the current versions of the files and fix this if it's still validating incorrectly.

Looks like we need to add the '"type": "object",' line to the sub schema generation in https://github.com/CVEProject/cve-schema/blob/develop/schema/support/schema2markmap/schema-bundle.js. Following Matt's recommendation it would be inserted into line 43. I will need to test this by running a new schema bundle.


GD 4.4dev7 E 0:00:31:0634   invert: Condition "0.0 == r3[3]" is true.   <C++ 源文件>      core/math/projection.cpp:758 @ invert()

Tested versions
E 0:00:31:0634   invert: Condition "0.0 == r3[3]" is true.
<C++ 源文件>      core/math/projection.cpp:758 @ invert()
System information
win10 gd4.4dev7
Issue description
E 0:00:31:0634   invert: Condition "0.0 == r3[3]" is true.
<C++ 源文件>      core/math/projection.cpp:758 @ invert()
Steps to reproduce
E 0:00:31:0634   invert: Condition "0.0 == r3[3]" is true.
<C++ 源文件>      core/math/projection.cpp:758 @ invert()
Minimal reproduction project (MRP)
E 0:00:31:0634   invert: Condition "0.0 == r3[3]" is true.
<C++ 源文件>      core/math/projection.cpp:758 @ invert()

Please follow the issue guideline and provide the steps to reproduce and/or a minimal reproduction project, otherwise we can't help.

Sorry, we can't help you if you're not provide a required information.

This issue has been properly re-created in https://github.com/godotengine/godot/issues/100850


Is this a library based on Multithreading?

I can use it to bind multiple events at once. Do they not affect each other?

This library is for multithreading. You need to understand how to write thread safe code before using it, or try the examples included.

I'm closing this issue as hopefully resolved for you.


[Supported Hardware] Board and Beacon on Home Assistant

Just flashed 1.07 to the following board; 'AZDelivery ESP-32 Dev Kit C V4' using the web tool, everything worked straight up no issues.
https://www.amazon.nl/gp/product/B07Z83H831/
Im using this with Holyiot nRF52810 beacons and they seem to get picked up perfectly.
https://www.aliexpress.com/item/1005003211033416.html
Ill keep a close eye on this for the next couple of weeks but seeing how smooth everything was to set up i really dont foresee any issues.
Let me know if you need anything specific from me to be able to call this hardware 'supported'.

@maarten682
Thank you for your support! I really appreciate this comment and feedback.
I'll add this board to the list.
I am going to merge the dev branch to the master soon and you can try the new version too. Or if you want you can find a binary package in the dev version to test.
Thank you again!

@maarten682
I've added your devices to the device list. Thanks again!


[Question]: Ingestion Pipelines and Workflows?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Is the IngestionPipeline impacted by workflows at all or is it strictly QueryPipeline?

@brycecf actually, despite the name, the ingestion pipeline is neither a query pipeline or a workflow.
Probably at some point, we could consider making it a workflow so that it's more dynamic, but a little unsure what that will look like just yet. Maybe just something like IngestionPipeline(workflow=workflow, ...) rather than specifying transformations?


May22 connectathon

Summary
Added examples for bulk submit data with _type parameters included in the body and with a group/id/$export style export url. Also added sushi as a dependency and a sushi script to package.json
Testing Guidance
Look over the included examples and ensure that they are correctly formatted and helpful. Run npm run sushi and ensure it executes correctly

npm run sushi appears to complete without errors, but it only appears to include one instance and nothing else. Is that what we expect?


Clearer interface for Read primitives

Reads from FUSE always operate on a length and offset within a file. This makes the simplest interface to adapt the io.ReaderAt interface. It also maps well to some modes of object access like AWS S3 and Google Cloud Storage APIs, or using dd to access parts of a file.
However other things we want to read don't have a pre-determined size, and we have to download the entire thing to find out the size. In those cases we want to save the content when we download it for later block reads. We want to download that data as soon as the file is accessed (Open is the earliest clear access) so we can update the size attribute of the file. Release could be used to free the buffered data.
So we want to provide a basic Read function for block access
type BlockReadable struct {
  Read(ctx context.Context, size int64, offset int64) ([]byte, error)
}

Files where you need to download the content to know the size should implement
type Readable struct {
  Read(context.Context) ([]byte, error)
}

External plugins have matching semantics
// Block-readable entries
<plugin_script> read <path> <state> <size> <offset> # data written to stdout
// All other readable entries
<plugin_script> read <path> <state> # data written to stdout

Here, we still preserve the methods array, but we add the following semantics for read:

read can be a tuple of [read, <block_readable>]. If block_readable is true, we use the block-readable calling convention.

If read isn't a tuple, then assume <block_readable> is false. This avoids breaking external plugins.

For prefetching, [read, <content>] we can assume that <block_readable> is false.

read prefetching is not supported for block-readable entries.

Note that the [read, <block_readable>] tuple is a specialized case of the more general [<method>, <signature>] tuple. The latter could be useful for overloaded actions; overloading's a useful way to capture a common pattern that could be implemented in different ways.

Updated the issue to change BlockReadable's signature to size, offset b/c the latter results in a less wordy comment ("read size bits of content starting at offset")

https://github.com/puppetlabs/wash/pull/643 was the last PR needed for this work.


when_visible not working

Was trying to execute code inside of block and it would never reach that code.

I'll try to focus on this in the next release.

I've faced such bug too.

I've written new features that demonstrate how to use this functionality.  If you are still having problems please send me an example that reproduces what you are seeing.


HHH-13614 - Allow the IntegratorProvider to be supplied via its FQN in the JPA persistence.xml

https://hibernate.atlassian.net/browse/HHH-13614

hi @vladmihalcea the PR applies few changes to your https://github.com/hibernate/hibernate-orm/pull/3032

@dreab8 Looks good. Much better to split the logic into dedicated methods.

I'm failing to see the use case. Integrator Providers can be automatically picked up from classpath, the reason is takes an object instance is to allow for this to  work in modular / managed environments - but that wouldn't work with a FQN as you can't set the classloader.
So what's the point to have this?

For Spring Boot, you could define the IntegratorProvider in the application.properties file. Otherwise, you need to do all sorts of hacks to pass an instance.

ok, thanks @vladmihalcea . Weird that they don't use the automatic integration facility but I guess that's their choice.

@Sanne I wrote several articles that show the advantages of using the IntegratorProvider, and several people commented that they can't use the functionality easily with Spring Boot.

That's when I noticed the opportunity for having this enhancement.

added few more tests, rebased and merged upstream.
Thanks a lot @vladmihalcea

@dreab8 Cool! I'm going to update my articles once this will be released.

Nice, thanks @vladmihalcea . Keep in mind that if you declare your Integrator as a manifest, ORM can pick it up without any configuration being needed. For example Hibernate Validator and Hibernate Search are automatically integrated - no need to configure them, one just needs to add the dependency.


tc.aggregate.QUANTILE does not meet "guaranteed" accuracy

As mentioned in #745, tc.aggregate.QUANTILE is actually an approximation. According to the docstring: "quantiles are guaranteed to have 0.5% accuracy". However this does not seem to be true.
import numpy as np
import turicreate as tc

l = [-4, 10, -1, -100]
print(np.quantile(l, [.5])[0])

temp = tc.SFrame({'x': l})
temp['dummy'] = 1
result = temp.groupby('dummy', {'y': tc.aggregate.QUANTILE('x', 0.5)})
print(result['y'][0][0])

Produces:
-2.5
-1.0

-1.0 is not with 0.5% of -2.5.

Numpy appears to do some sort of linear smoothing between -4 and -1, which is not standard but common.  Technically (in statistics) the quantile of an empirical distribution like this can be anywhere in between the two values given.  Typically, one of those values is returned as the quantile.  In this case, [-100, -4, -1, 10] would mean that anything in [-4, -1] is valid as a numerical quantile.  However, the median almost always returns value that is present in the dataset, which is what we do here, returning -1.  So our result is correct.


[SPARK-14906][ML][WIP] Move VectorUDT and MatrixUDT in PySpark to new ML package

What changes were proposed in this pull request?
Move the VectorUDT and MatrixUDT in PySpark to new ML package.
How was this patch tested?
Existing tests.

Test build #57642 has started for PR 12870 at commit 24ec53e.

Test build #57642 has finished for PR 12870 at commit 24ec53e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57642/
Test FAILed.

Merged build finished. Test FAILed.

@viirya Thanks for this PR.   I'll make a few high-level comments.
We need to keep the old pyspark.mllib.linalg APIs.  We also want to freeze the pyspark.mllib.linalg APIs, which means we need to keep that old code (not just alias it).
Can you please modify the PR to do the following:

Keep the pyspark.mllib.linalg code
Copy the linalg code to pyspark.ml.linalg, including unit tests
Update the pyspark.ml.linalg code as needed to handle UDTs and make tests run

Thanks!

Test build #57723 has started for PR 12870 at commit b504a60.

Test build #57723 has finished for PR 12870 at commit b504a60.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class VectorUDT(UserDefinedType):
class MatrixUDT(UserDefinedType):
class Vector(object):
class DenseVector(Vector):
class SparseVector(Vector):
class Vectors(object):
class Matrix(object):
class DenseMatrix(Matrix):
class SparseMatrix(Matrix):
class Matrices(object):
class QRDecomposition(object):

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57723/
Test FAILed.

Test build #57725 has started for PR 12870 at commit 7314444.

Test build #57725 has finished for PR 12870 at commit 7314444.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57725/
Test FAILed.

Test build #57728 has started for PR 12870 at commit 7df46dc.

@jkbradley Thanks for your comments. I want to make sure that you said we will freeze the pyspark.mllib.linalg APIs, so do I need to change the current PySpark ml/mllib codes which use pyspark.mllib.linalg APIs to use new pyspark.ml.linalg?
I just did that. So if you mean we don't touch that, I need to revert it back. Thanks.

Test build #57728 has finished for PR 12870 at commit 7df46dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57728/
Test PASSed.

ping @jkbradley @dbtsai @mengxr

Test build #58489 has started for PR 12870 at commit 33afa2e.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58489/
Test FAILed.

Merged build finished. Test FAILed.

i will retrigger this build once maintenance is over.

jenkins, test this please

jenkins, test this please

Test build #58500 has started for PR 12870 at commit 33afa2e.

@viirya Sorry for late response! The changes should be similar to mllib-local. The scope is not moving UDTs but copying the entire linalg package to spark.ml. We should leave spark.mllib unchanged and turn it to maintenance mode in 2.0. Do you have time to make this change? Or I can send a PR based on yours. Thanks!

Test build #58500 has finished for PR 12870 at commit 33afa2e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58500/
Test PASSed.

@mengxr Currently I moved only Vector/Matrix and their UDTs to pyspark.ml and made pyspark.ml and pyspark.mllib codes to use moved ml.linalg Vector/Matrix. Besides, pyspark.mllib is untouched.
Do you mean that we want to keep pyspark.mllib codes using pyspark.mllib.linalg and let pyspark.ml codes using new pyspark.ml.linalg?

@mengxr @dbtsai Separating the pickle paths for pyspark.ml and pyspark.mllib is not possible without the changes in #12627, as it requires the Scala ML code changes as well.
I will submit another PR for this jira that only copies pyspark.mllib.linalg to pyspark.ml.linalg. When that PR is merged, I will apply the changes of python codes in this PR against #12627 by submitting a PR for it. Then I think it should solve the problem.

@mengxr @dbtsai That PR is at #13099.

Ping @mengxr


composer.json

is there any reason why composer.json is still referencing 5.0.x@dev now that L5 is actually out?
& if not can it be fixed up ?

Because you are using pingpong/modules in not stable version. We can fix that up by releasing this package to a stable version.

try setting:
"minimum-stability": "dev"

In your composer.json file.


implement linear intervention scale-up

Implemented the scale-up of interventions as a linear increase rather than a step upon coverage initiation.
I would love to get feedback regarding whether there is utility in adding LinearScaleUpIntervention to vivarium_public_health, since we scale interventions up linearly in this fashion quite often.

I think it may be useful to add LinearScaleUpIntervention to VPH. I'm pro-adding it, since I think every scale-up I've implemented for models has been linear.


[Feature request] allows inspect database / debug on local without internet data

As a developer who doesn't have a lot and fast internet, I really want you to make an inspect database on localhost

I'm also worried that my data could be stolen.
Sorry for my bad request and english

That should be easy: Just clone the Isar repository and run the inspector on your machine.  The inspector runs locally. Just the files are hosted on inspect.isar.dev.

How did you do it? Mine cant connect

How did you do it? Mine cant connect

I have made my own package to support local without internet
https://github.com/isar/isar/issues/1251#issuecomment-1789430605


WRN-11134: fix security vulnerabilities

Issue Resolved / Feature Added
For preventing malware issues, we need to update node modules that fix severity vulnerabilities.
Resolution
Update node modules' warnings via checking "npm audit"
Additional Considerations
Links
WRN-11134
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong<EMAIL_ADDRESS>

we will handle this on WRN-16762


Trigger coverage build on the master branch

I copied over the changes from https://github.com/ros-controls/ros2_control/pull/1119

I have no idea what happened with the binary - testing job, but this is for sure not linked to this PR's change.


Replace the current demo app with a React-based demo

This is a complete rewrite of the SDK Web Demo in React, with a proper design.
It uses the rainway-react package, which we should publish first 🙂
Instead of S3, the idea is to deploy this version to GitHub Pages using the gh-pages tool. Can we set it up so that it lives at https://webdemo.rainway.com rather than https://rainwayapp.github.io/rainway-sdk-web-demo ?
Here's a screenshot!

Can we set it up so that it lives at https://webdemo.rainway.com/

Definitely! I don't have access to our DNS right now but will need to have that access soon anyway for other stuff, so that lines up nicely. This should be fairly straightforward though!

Published react-rainway this afternoon, so this should be merge-able from that perspective now!

tested manually, looks like everything is working! Think it's time to ship this one.


[Joy] Add Sheet doc

Preview: https://deploy-preview-32820--material-ui.netlify.app/joy-ui/react-sheet/

[x] I have followed (at least) the PR section of the contributing guide.

@danilo-leal @siriwatknp What do you think about changing the default variant value to either outlined / soft / solid? plain doesn't seem to showcase the component well enough: https://deploy-preview-32820--material-ui.netlify.app/joy-ui/react-sheet/

Added "bg": true to the demo, this should be enough to see that the plain Sheet has a background.

Added "bg": true to the demo, this should be enough to see that the plain Sheet has a background.

I agree!

Added "bg": true to the demo, this should be enough to see that the plain Sheet has a background.

I agree!
@siriwatknp Should we add some other examples other than the playground? Do you have ideas?

May be not in this PR since the variant override feature is not done.

@hbjORbj I wonder if we remove the elevation prop from the sheet. I afraid that developers might be confused because the behavior of the elevation in Joy is different from Material-UI.
We should have lean API as much as possible. The shadow is can be added by the sx prop.
If you are agree with this, please remove the prop from the implementation.

What do you think about changing the default variant value to either outlined / soft / solid? plain doesn't seem to showcase the component well enough:

Hm... I'm not sure about it, I don't think that the point of the default value should be to showcase the component well enough but rather what would be the most common use case for the component in real apps. As the Sheet is a generic container/wrapper component, I'd bet that in most cases, using it plainly, without any borders or lighter backgrounds, would be the most common. But of course, this is my position now, we could change as we get different experiences :)

@danilo-leal Gottcha gottcha 👍
@siriwatknp I removed the elevation prop! :)

Merging this one for now! It's good enough for a first path, nice work you two!
Further iterations can be handled in #33158.


Unable to turn off Sentry-Native on Linux & Windows

Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which version of the SDK?
https://github.com/getsentry/sentry-unreal/commit/edf4751aa8edbf83addfc142884d43ec31a3cba1
How did you install the package? (Git-URL, Assetstore)
Git
Which version of Unreal?
5.2.1
Is this happening in Unreal (editor) or on a player like Android, iOS, Windows?
Compilation of Client.
Steps to Reproduce

Navigate to the Sentry.build.cs file
Disable Sentry-Native (Turning USE_SENTRY_NATIVE to 0) for both the Linux and Windows Platform
Compile

Expected Result
No compilation failures.
Actual Result
Multiple compilation failures
Any logs or screenshots

@Edstub207 What's the reason you're trying to exclude plugin implementation for Win/Linux from the build? It should be a straightforward fix though I'd like to understand the motivation behind this

@tustanivsky It's very closely tied to https://github.com/getsentry/sentry-unreal/issues/354 where we just aren't getting reliable callstacks in Sentry. So we want to revert back to using the Crash Reporter for now to see if that improves things.
Admittedly, it's not clear what's Sentry-Native and what's part of the generic plugin.

@tustanivsky It's very closely tied to #354 where we just aren't getting reliable callstacks in Sentry. So we want to revert back to using the Crash Reporter for now to see if that improves things.

I believe disabling the Initialize SDK automatically option in the plugin setting should be enough for switching back to the crash reporter testing unless you're willing to use any other plugin functionality at the same time (i.e. sending messages to Sentry manually on certain occasions).

Admittedly, it's not clear what's Sentry-Native and what's part of the generic plugin right now, a lot seems to be guarded by Sentry-Native?

Basically, the UE plugin is a wrapper for a bunch of other Sentry SDKs (sentry-native for Win/Linux, sentry-jave for Android and sentry-cocoa for macOS/iOS). The generic part of it provides Unreal-friendly APIs allowing to initialize the underlying native SDKs and enrich captured events with some data specific to the engine. The actual crash/event capturing is fully handled on the native SDKs side and we're somewhat limited in terms of altering their behavior.
Speaking of Win/Linux implementation the USE_SENTRY_NATIVE definition prevents scripts in Sentry/Source/Private/Desktop from being compiled while using the plugin on Mac.

@Edstub207 I've added some extra USE_SENTRY_NATIVE checks so now disabling it programmatically shouldn't cause any trouble.


Explicitly convert string to int for comparison operation

In Python 3 the string needs to be explicitly converted to
an int to be used in the comparison operation

Hit the same problem, the request id's need conversion from hex or just a string if check...
if cloud_service_request_id: # assert not an empty string or None
or
if int(cloud_service_request_id, 16) > 0:

Truth testing has not changed AFAIK
Python 3.4.6 (default, Mar 22 2017, 12:26:13) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.

a = 'a'
if a:
...   print('Worked')
...
Worked

Sorry didn't mention the error but only possible solutions...
With this PR I get the following error because the request ID is really a string not an int.
ERROR: Unexpected error:
Traceback (most recent call last):
  File "/home/smarlow/projects/venvs/azurectl3/bin/azurectl", line 11, in <module>
    load_entry_point('azurectl', 'console_scripts', 'azurectl')()
  File "/home/smarlow/projects/azurectl/azurectl/azurectl.py", line 45, in main
    App()
  File "/home/smarlow/projects/azurectl/azurectl/app.py", line 31, in __init__
    task_class().process()
  File "/home/smarlow/projects/azurectl/azurectl/commands/compute_vm.py", line 166, in process
    self.__create_cloud_service()
  File "/home/smarlow/projects/azurectl/azurectl/commands/compute_vm.py", line 245, in __create_cloud_service
    if int(cloud_service_request_id) > 0:
ValueError: invalid literal for int() with base 10: 'e208fe07ca6006e7a3e64f6309a928b8'

OK, that would imply that the request_id we are after was never meant to be compared to 0 in the first place. I'll go look at what the SDK has to say about he request id

I guess I got lucky when I tested this, oh well sometimes even a blind ....
Latest push should fix the issue, this was a latent bug, should have never worked, but for the "favors" python2 played.

@schaefi the only documentation I could find about what request_id should be was here: https://docs.microsoft.com/en-us/rest/api/storageservices/troubleshooting-api-operations
This of course does not specify what the type is and in the code all I found was
def parse_response_for_async_op(response):
''' Extracts request id from response header. '''
if response is None:
    return None

result = AsynchronousOperationResult()
if response.headers:
    for name, value in response.headers:
        if name.lower() == 'x-ms-request-id':
            result.request_id = value

return result

Where value could of course be of any type, it appears that based on https://msdn.microsoft.com/en-us/library/azure/ee460783.aspx the request-id should be treated as a string, in which case the current implementation would probably be correct. However in the tests the request-id is treated as an int, thus the tests fail. The only thing we do know for sure is that the API does not return an int. Thus the tests do not replicate the expected value from the API and thus the SDK.

More empirical information, for "storage disk upload" and "compute image create" the "len(request_id" implementation works, but for "compute vm create" the request_id is an integer and the len() fails.
Great that the REST API is inconsistent with returned values. Then again what would
one expect from Msft.

Thanks for the investigations. With all your information I think it would be a good idea to pass along any request id to a method to allow a common validation as we need it. Thus I opened #225 and like to ask for a review. So far the method just calls format() on the value which might be not complete. But with the one place to deal with the value we can enhance the method as needed
Thoughts ?

ok so this one needs a fix for the unit test to be complete

OK, finally, with this we make it through a complete cycle:
storage disk upload
compute image create
compute vm create
and the tests pass :smile:

OK, cleaned up the history and fixed the test. This should work now without superfluous calls to unify_id

Thanks much :+1:


mDNS: failed to join multicast group goroutine 299

Your environment.

Version: Ubuntu 18 in WSL
Browser: Chrome 77.0.3865.90

What did you do?
-Run the server
-Go to browser and publish
Then in other PC via local network
-Go to browser and subscribe
What did you expect?
-The video and audio from the publisher
What happened?
-Nothing happen
-Error: mDNS: failed to join multicast group goroutine 299

@Stunext
I am not familiar with the networking stack in WSL, but it sounds like it doesn't implement everything we need.
Pion should work on Windows, we don't require any C code! Would you mind trying the program directly on Windows (and not in WSL)?
thanks

I tried and now no more errors appears but is the same... nothing happen and the only log in the console is: http: TLS handshake error from <IP_ADDRESS>:40707: remote error: tls: unknown certificate

@Stunext also running into this with Ubuntu 20 in WSL, what did you do to make it work?


Elaborate what "Vi compatible backspacing" is

Tested delete in insert mode on vi and nvi. Pressing delete for the first time inverted the case of the previous character (wat) and then it worked like normal delete. I guess this makes vim backspace not 100% compatible/identical, which is a good thing lol (assuming this isn't a weird bug on the vi/nvi versions I used).

Inverting case means the key is not recognized.
The 'backspace' option has nothing to do with the Delete key.  Vi compatible means none of the ways mentioned (backspacing over start of insert, start of line, etc.) is possible.  I can add a note about that.


Timex.parse with {kitchen} breaks when the hour is 2 digits

First off, thank you for Timex!
Steps to reproduce

API function called: Timex.parse!
Arguments provided: "10:00AM", "{kitchen}"

Description of issue
Expected results
Returns ~N[2020-09-18 10:00:00] (date would change depending on the day you run it).
Actual results
** (Timex.Parse.ParseError) Expected `:`, but found `0` at line 1, column 2.
    (timex) lib/parse/datetime/parser.ex:110: Timex.Parse.DateTime.Parser.parse!/3

Commentary
Basically, the problem is that you can Timex.format! a time with {kitchen}, but then when you Timex.parse! the output with {kitchen} it crashes if the hour (in the string) is a 2-digit number such as 12 or 10.
Another demonstration from a different angle:
iex> ~T[01:00:00] |> Timex.format!("{kitchen}") |> Timex.parse!("{kitchen}")
~N[2020-09-18 01:00:00]

iex> ~T[02:00:00] |> Timex.format!("{kitchen}") |> Timex.parse!("{kitchen}")
~N[2020-09-18 02:00:00]

iex> ~T[09:00:00] |> Timex.format!("{kitchen}") |> Timex.parse!("{kitchen}")
~N[2020-09-18 09:00:00]

iex> ~T[10:00:00] |> Timex.format!("{kitchen}") |> Timex.parse!("{kitchen}")
** (Timex.Parse.ParseError) Expected `:`, but found `2` at line 1, column 2.
    (timex) lib/parse/datetime/parser.ex:110: Timex.Parse.DateTime.Parser.parse!/3

iex> ~T[00:00:00] |> Timex.format!("{kitchen}") |> Timex.parse!("{kitchen}")
** (Timex.Parse.ParseError) Expected `:`, but found `2` at line 1, column 2.
    (timex) lib/parse/datetime/parser.ex:110: Timex.Parse.DateTime.Parser.parse!/3

Workaround
If anyone else if having this problem, I've found you can do this instead:
Timex.parse!("10:00AM", "{h12}:{m}{AM}")

For example:
iex(70)> ~T[00:00:00] |> Timex.format!("{kitchen}") |> Timex.parse!("{h12}:{m}{AM}")
~N[0000-01-01 00:00:00]

Thank you 🙂


v1.wormholebridge transfer error

https://explorer.solana.com/tx/5KSPQW4RMdCjr68gHCnJru8S9Cg7vamMW2Zk6Cr4jCMiBmrLQyghEGZCd3QMKwUuJCJXvYQoPtC6WdfWC1ZnNHAb

It says Error: insufficient funds so presumably you do not have enough SOL to pay for fees?

This is not the issue since 900 USD worth of SOL is in the Phantom wallet. Also, if this had not been enough then DAI would have stayed in the wallet. The situation now however is it is somewhere I cannot access.


Update redirects in Readme

Created with https://github.com/dkhamsing/frankenstein

Hey, Thanks!

:smile:


Extra GroupFunction factory

About #247

Merging ; will mark this API deprecated in favor of the upcoming command framework.


When you search and key and save files all keys is removed

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enable inlay hints in Visual Studio

Describe the feature you are requesting
Visual Studio now has support for inlay hints via LSP, so given that the Python serves has support for these, it would be nice to enable them in Visual Studio.
Reasons for requesting this feature
It would better align with the language service experience in other editors (e.g. VS Code).
Additional context
TypeScript is now using LSP for their inlay hints in Visual Studio, and Razor is also using them to provide C# inlay hints in script blocks: https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes-preview#inlay-hints-for-c-code-in-razor-files

@MariaSolOs Thanks for reaching out. Are we only looking to display the inlay hints, or are you anticipating a behavior that's more consistent with VS Code, where users can double-click the inlay hints in the editor to insert into their code?

@MariaSolOs Thanks for reaching out. Are we only looking to display the inlay hints, or are you anticipating a behavior that's more consistent with VS Code, where users can double-click the inlay hints in the editor to insert into their code? What do other languages in VS currently support?

The plan is to support the same level of interactivity that VS Code has (AFAIK that’s part of the editor roadmap).


Docs for Non-production IDP support

Description:

Create docs for Non-production IDP support

Added content in [1]. Waiting for content to be reviewed.
[1] https://github.com/wso2/apk/wiki/Adding-Secured-APIs-in-an-Organization

Added docs to APK wiki
https://github.com/wso2/apk/wiki/Using-a-Non-Production-IdP

Note
Removed [1] from wiki
[1] https://github.com/wso2/apk/wiki/Adding-Secured-APIs-in-an-Organization


Display ‘shortName’ for Case of the Week block/API call

DEV:

PROD:

 Update Case of the Week block in newsletter to pull in title vs description


Setting configurations do not seem to take effect

I've been trying for awhile to get a database setup with my iron functions. No dice so far.
func.yaml env vars didn't seem to take effect so I tried setting it in the apps config:
$ fn apps config set myapp key value
myapp updated key with value

$ fn apps config view myapp
this application has no configurations

Is there something I need to setup before this works?

Creating an environment variable at app creation works:
$ fn apps create --config DB_URL=http://example.org/ myapp

$ fn apps config view myapp
myapp configuration:
DB_URL: http://example.org/

But when I actually want to access the app configuration it only appears as _DB_URL, not DB_URL.

@pedronasser do your new changes fix this?

This issue is solved.
I've just checked using the latest master.


Test other Rubies on Redis Bugfix

Overview
Trying to see how the bugfix works on other verisons of Ruby by adjusting the ci_cron job and running it on the PR
Relates to #1640

Tests passed on other Rubies 🎉


Show progress bar as a circle instead of horizontal growing bar

This shall indicate time left much better

Do you have a mock of what this might look like?

@dziemborowicz

just a quick draft using powerpoint


redirect to URL pointing to a record doesn't display in record2 markdown annotation

See the "VIEW TARGET IMPT-CCR1" link in
https://dev.gpcrconsortium.org/chaise/record/#1/gpcr_browser:construct_gui/title=IMPT-1003
The url is correct but need to do an extra page reload in order to display the page.
Redirects to results set, like the one above for "VIEW BIOMASSES..." work ok

This might be relevant to issue #581. @chiragsanghvi @robes do you have any suggestions?

@hongsudt yep, i believe its exactly like that issue.

Fixed in PR https://github.com/informatics-isi-edu/chaise/pull/629


German Translation for the 2024 annual survey

r? @Kobzol

We haven't received further feedback on this translation, so let's merge it.

Thank you for the translation!

My pleasure.


incorrect call to New-AzureADServiceAppRoleAssignment

In the section "Grant permissions to User assigned managed identity", the 3 calls to New-AzureADServiceAppRoleAssignment  must be
New-AzureADServiceAppRoleAssignment -ObjectId $MSI.ObjectId  -PrincipalId $MSI.ObjectId  -ResourceId $AAD_SP.ObjectId  -Id $AAD_AppRole.Id
instead of
New-AzureADServiceAppRoleAssignment -ObjectId $MSI.ObjectId  -PrincipalId $MSI.ObjectId  -ResourceId $AAD_SP.ObjectId[0]  -Id $AAD_AppRole.Id

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b55c753f-05c3-3a72-4196-dc1541c6f868
Version Independent ID: f91ac085-dfed-3740-bb6d-8fb38de1c473
Content: Set up Microsoft Entra authentication - Azure Database for MySQL - Flexible Server
Content Source: articles/mysql/flexible-server/how-to-azure-ad.md
Service: mysql
Sub-service: flexible-server
GitHub Login: @SudheeshGH
Microsoft Alias: sunaray

@danvalero
Thanks for your feedback! We will investigate and update as appropriate.

@danvalero
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


fix: allow multiple instances of core to interact with context

Because of the way node handles modules, multiple instances of core may exist in the same installation. For instance, core may be depended on by a propagator, a plugin, and the tracing module. If any of these depend on a slightly different version, the functions used to interact with context will fail to work together. Using Symbol.for ensures these symbols are the same regardless of the instance of core that is being used.

Fixes #1379

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/for

In contrast to Symbol(), the Symbol.for() function creates a symbol available in a global symbol registry list. Symbol.for() does also not necessarily create a new symbol on every call, but checks first if a symbol with the given key is already present in the registry. In that case, that symbol is returned. If no symbol with the given key is found, Symbol.for() will create a new global symbol.


Option for custom CDN endpoint when using S3 file store

When using an S3 file store, it looks like files are fetched using a presigned URL direct from the bucket. This is probably okay for most people, but it would be nice to be able to define a custom CDN endpoint, for example if you want to put Cloudfront in front of the bucket with a custom URL or proxying a Cloudflare R2 bucket. This would let us stick with a single domain and configure caching to avoid excessive requests to the bucket.
I'm not familiar with Elixir, but I'm willing to give it a shot at implementing.

I actually thought about this too. Seems like a good idea.
We're serving files from a private bucket (i.e. objects themselves being private, requiring pre-signing). Do you have examples of how e.g. Cloudflare, Fastly, Cloudfront URLs would look like when compared to the original bucket URL? I assume simple domain substitution would only work for fully public objects, right?


feat(compat): License added to rxjs-compat package

Description:
Per request of #3926 , adding the Apache license to the rxjs-compat package.json.
Related issue (if exists):
#3926

Another tip: if you add Closes #3926 to the body of the commit message, the specified issue will be closed automatically when the PR is merged.

Coverage decreased (-0.2%) to 96.797% when pulling f8c8ae1b8b97adc34d274d64efd341c66230927f on pertrai1:3926-rxjs-compat-license into 514a870de5e510e68794524d8996dac0382a9b4b on ReactiveX:master.

@cartant thanks. I changed the commit to having that in the body of the commit message.

thanks @pertrai1


fix misleading docstring return description for covariance SVD plot

seems misleading to refer to SVD plots as "spectra" given that eigenvalue indices are discrete; a spectrum

is a condition that is not limited to a specific set of values but can vary, without gaps, across a continuum. (Wikipedia)

xref: https://mne.discourse.group/t/spectra-plot-of-the-covariance-explanation/8141

Also from Wikipedia for Spectrum_of_a_matrix, though:

In mathematics, the spectrum of a matrix is the set of its eigenvalues

And for a positive semidefinite matrix (like a noise cov), the singular values are the same as the eigenvalues.
So I think we're mathematically correct here, but I understand why people would feel a bit mislead because "spectrum" is so commonly used to refer to a frequency spectrum and here we mean matrix spectrum. Maybe saying "matrix spectrum (i.e., eigenvalues)" specifically or maybe better "eigenvalues (i.e., matrix spectrum)" would help? If not I can live with the current approach.

I think we're mathematically correct here, but I understand why people would feel a bit mislead because "spectrum" is so commonly used to refer to a frequency spectrum and here we mean matrix spectrum. Maybe saying "matrix spectrum (i.e., eigenvalues)" specifically or maybe better "eigenvalues (i.e., matrix spectrum)" would help? If not I can live with the current approach.

Sorry I left this sitting so long. I've done what you suggested @larsoner, should be good to go.

Thanks @drammock !


add initial support for the PF firewall in OpenBSD

also exclude iptables and nftables code on !linux because
that is the only platform supporting them and it is just
a waste of space building them in on !linux

Thanks @rnagy, the initial support looks good, can we also add my commits to cover FreeBSD.
I'm also testing the cs-firewall-bouncer on FreeBSD

All commits from this PR have been merged in https://github.com/crowdsecurity/cs-firewall-bouncer/pull/37
Thank you very much for you contribution !


test: Add setup file, handle matchMedia

Summary
Added in a setup.ts file to mock the window.matchMedia function. JSDOM does not support it, resulting in our tests breaking.
Test Plan
Tests should run clean
Issues
Closes #827

@ap0nia I think you mentioned using a different config than vitest/config. Is that still how you think it should be implemented?

Also, is there any way to change the devops to exclude the author from the random reviewer selection? Or, alternatively, automatically rerun it if it fails?


Enhancement: dps but with recursive safe pointer following

Regular dps:
> dps 26ee7c30
26ee7c30  2368c010
26ee7c34  13234900
26ee7c38  5f080100 d2d1!CSRGBToLinearTranslator::s_shaders+400f0
26ee7c3c  26db1aa8
26ee7c40  26ee74a8
26ee7c44  26e80020

Awesome recursive dps:
26ee7c30  2368c010  -> 50afffa8 jscript9!Js::JavascriptLibrary::`vftable'
26ee7c34  13234900  -> 50b35650 jscript9!Js::GlobalObject::`vftable'
26ee7c38  5f080100 d2d1!CSRGBToLinearTranslator::s_shaders+400f0
26ee7c3c  26db1aa8  -> 50afa570 jscript9!ScriptEngine::`vftable'
26ee7c40  26ee74a8  -> 21dd7da0  -> 50afffa8 jscript9!Js::JavascriptLibrary::`vftable'
26ee7c44  26e80020  -> 26a0cda0  -> 50afffa8 jscript9!Js::JavascriptLibrary::`vftable'

Ah! It is so much more clear what I am looking at now! And with colorization it's even better!

Hey, that's a cool idea. Did you actually try implementing it, or is that just a mockup?

I did indeed, although just as a quick hack that replaces the standard dps:
        private static ColorString _DefaultSymLookup( DbgEngDebugger debugger, ulong addr )
        {
			var tempCs = ColorString.Empty;
			int depth = 0;
			do
			{
				if (tempCs.Length > 0) { tempCs = tempCs + "-> " + DbgProvider.FormatAddress(addr, is32bit: true, useTick: true, numericNull: true) + " "; }
				if (debugger.TryGetNameByOffset(addr, out string symName, out ulong disp))
				{
					ColorString cs = tempCs + DbgProvider.ColorizeSymbol(symName);
					if (disp != 0)
						cs.AppendPushPopFg(ConsoleColor.Gray, "+" + disp.ToString("x"));

					return cs;
				}

				tempCs += " ";
				depth++;
			} while (addr > 4096 && depth < 5 && debugger.TryReadMemAs_pointer(addr, out addr));

			return tempCs;
		} // end _DefaultSymLookup()


Helm chart for kuberhealthy 0.1.1

Signed-off-by: Eric Greer<EMAIL_ADDRESS>Satisfies https://github.com/Comcast/kuberhealthy/issues/26
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

circleci above shows a generic error, but helm lint does in fact pass on this chart.

@unguiculus @seanknox May I have a review please? :-)

@unguiculus @seanknox Help please!  We are blocked on product release without this chart being approved.

@nvtkaszpir I moved several things to the more current kubernetes versions . Thanks for pointing that out!
I also added a newline in that one file.

@nvtkaszpir Can you get some forward movement on publishing this for me?

Unfortunately I have no power to push any PRs forward, you can ask owners for review on github/slack. Please to fix build issues first.

Unfortunately I have no power to push any PRs forward, you can ask owners for review on github/slack. Please to fix build issues first, notice that maintainers must point to github accounts, unfortunately.

Thanks @nvtkaszpir.  The prior builds were erroring out, so the build that happened most recently was the first time I was actually able to see the errors.
I will work on those and then ping people on slack again.  Thank you!

@unguiculus and @seanknox can you please review my chart? :-)

@unguiculus and @seanknox help! Please review!

Please make sure you apply our guidelines (e. g. standard labels on all resources) and our RBAC best practices.
https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
https://github.com/helm/helm/blob/master/docs/chart_best_practices/rbac.md

Thank you @unguiculus.  I have made the requested changes and now include all the recommended labels and variables.  I also added an OWNERS file and helpers for things like RBAC.  Is there anything else you would like to see changed?
@seanknox
Are you guys at kubecon this week?  I am there!


Joystick input throws an error when user reconnects

Joystick input works fine when the user first loads up interactive. However, if they refresh, any attempt to interact with the joystick will result in an error message (and no joystick event):
Error: Error while processing method: giveInput
UnityEngine.Debug:Log(Object)
Microsoft.Mixer.InteractivityManager:Log(String, LoggingLevel) (at H:/GIT/WatchBeam/interactive-sdk-csharp/interactive-sdk-csharp/Source/Microsoft.Mixer.Shared.CSharp/InteractiveManager.cs:3361)
Microsoft.Mixer.InteractivityManager:LogError(String, Int32) (at H:/GIT/WatchBeam/interactive-sdk-csharp/interactive-sdk-csharp/Source/Microsoft.Mixer.Shared.CSharp/InteractiveManager.cs:3350)
Microsoft.Mixer.InteractivityManager:LogError(String) (at H:/GIT/WatchBeam/interactive-sdk-csharp/interactive-sdk-csharp/Source/Microsoft.Mixer.Shared.CSharp/InteractiveManager.cs:3344)
Microsoft.Mixer.InteractivityManager:ProcessMethod(JsonReader) (at H:/GIT/WatchBeam/interactive-sdk-csharp/interactive-sdk-csharp/Source/Microsoft.Mixer.Shared.CSharp/InteractiveManager.cs:1459)
Microsoft.Mixer.InteractivityManager:ProcessWebSocketMessage(String) (at H:/GIT/WatchBeam/interactive-sdk-csharp/interactive-sdk-csharp/Source/Microsoft.Mixer.Shared.CSharp/InteractiveManager.cs:1391)
Microsoft.Mixer.InteractivityManager:OnWebSocketMessage(Object, MessageEventArgs) (at H:/GIT/WatchBeam/interactive-sdk-csharp/interactive-sdk-csharp/Source/Microsoft.Mixer.Shared.CSharp/InteractiveManager.cs:1342)
WebSocketSharp.Ext:Emit(EventHandler`1, Object, MessageEventArgs)
WebSocketSharp.WebSocket:messagec(MessageEventArgs)
WebSocketSharp.WebSocket:message()
WebSocketSharp.<>c__DisplayClass179_0:<startReceiving>b__1(WebSocketFrame)
WebSocketSharp.<>c__DisplayClass83_0:<ReadFrameAsync>b__3(WebSocketFrame)
WebSocketSharp.<>c__DisplayClass77_0:<readPayloadDataAsync>b__0(Byte[])
WebSocketSharp.<>c__DisplayClass55_0:<ReadBytesAsync>b__0(IAsyncResult)

Fairly quickly the stack trace goes into DLLs, so I don't know exactly what is going on, but I haven't found any dirty workarounds so this is a somewhat pressing issue.
Another note is that for some reason different results are produced when the Mixer Editor is open. When open, all users have the same joystick (rather than each client having their own like it's supposed to work). I mention this because the joystick error doesn't appear if the editor has been opened at any point while playing, so that may produce a false positive when testing.

Thank you for logging the issue we will investigate.

Can this be repro'ed on the Joystick example that comes with the plugin? Here's what we tried, but weren't able to reproduce the issue (let me know what step we're missing):

Open and run the Joystick sample.
Move the capsule through the channel Mixer website.
Refresh the browser.
Move the joystick again.

Actually, I have the repro now. I see you have to close the Mixer Editor. We'll investigate what's going on.

Didn't mean to close, meant to comment. We're still investigating.

Thank you so much for reporting this issue! We apologize for the frustration. It is fixed in the latest unitypackage in the releases section.

Thank you!


ibus-setup-hangul in ibus-hangul not working

Issue description
In executing ibus-setup-hangul, got this error message:
Traceback (most recent call last):
  File "/nix/store/7mny8v5nq9s5a343imn8r31gmwrj36qc-ibus-hangul-1.5.0/share/ibus-hangul/setup/main.py", line 23, in <module>
    from gi.repository import GLib
ImportError: No module named 'gi'

Steps to reproduce

configuration.nix

  # Select internationalisation properties.
  i18n = {
    consoleFont = "Lat2-Terminus16";
    #consoleKeyMap = "us";
    defaultLocale = "en_US.UTF-8";
    consoleUseXkbConfig = true;
    inputMethod = {
      enabled = "ibus";
      ibus = {
        engines = [ pkgs.ibus-engines.hangul ];
      };
    };
  };

nixos-rebuild switch
run ibus-setup-hangul in a shell

Technical details

System: NixOS  17.03.1584.48ecdcf598 (Gorilla)
Nix version: 1.11.11
Nixpkgs version: 17.03.1584.48ecdcf598
Sandboxing enabled: build-use-sandbox = false

Might be due to 66b05cd4e68408bf9026bb304f344b87c66feec3.
@abbradar What was the reason to remove pygobject3 from ibus-hangul dependencies?

@ericsagnes I think that was because I noticed that it is propagated from some other package, but looking at this now it doesn't seem to be the case. I'll investigate this today!

This seems more deep than I thought. The bug is two-fold:

setup.py script is not patched as needed for Python scripts;
pygobject3 should be propagated from ibus. However, only its .dev output is propagated, so it's not added as a Python library.

I can fix the first one but not sure what to do about the second -- maybe we should change behaviour of this propagation in some way. @FRidh?

The same problem appears with anthy, and directly adding the same pyEnv to buildInputs like 6dc4b5229bd85156169be39be376bb85a5fccd0f did in ibus definitely fixes the build fails (tested with both anthy and hangul), but the python environment isn't propagated by itself.


Convert some check tests to support e2e

Motivation
Test a few before doing the rest

Codecov Report

Merging #2349 into master will increase coverage by 13.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2349       +/-   ##
===========================================
+ Coverage   79.55%   93.48%   +13.93%
===========================================
  Files         204       19      -185
  Lines       13775      814    -12961
  Branches     1460       74     -1386
===========================================
- Hits        10959      761    -10198
+ Misses       2428       33     -2395
+ Partials      388       20      -368


Resolve 'Publish-Module doesn't report error but fails to publish module'

This is happening as the latest version of dotnet cli is not writing the error messages into error stream.
Resolves #316.

2.0.1 version of PowerShellGet module includes this fix.


Speedboost

This fixes the benchmark and I experienced a 5% performance increase with my changes.

@SimonSchick, thanks for your PR! By analyzing the history of the files in this pull request, we identified @connor4312 to be a potential reviewer.


Adds java matrix to test and build workflow

Signed-off-by: Robert Downs<EMAIL_ADDRESS>Issue #, if available:
Description of changes:
CheckList:

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #297 (cecbc89) into main (12b5705) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

:exclamation: Current head cecbc89 differs from pull request most recent head 4c4761a. Consider uploading reports for the commit 4c4761a to get more accurate results

@@             Coverage Diff              @@
##               main     #297      +/-   ##
============================================
- Coverage     75.54%   75.41%   -0.14%
- Complexity     1997     2002       +5
============================================
  Files           253      253
  Lines         11466    11466
  Branches       1815     1815
============================================
- Hits           8662     8647      -15
- Misses         1771     1788      +17
+ Partials       1033     1031       -2

Impacted Files
Coverage Δ

...anagement/step/forcemerge/WaitForForceMergeStep.kt
32.50% <0.00%> (ø)

...statemanagement/model/destination/CustomWebhook.kt
65.21% <0.00%> (-27.54%)
:arrow_down:

.../rollup/action/start/TransportStartRollupAction.kt
66.27% <0.00%> (-3.49%)
:arrow_down:

.../action/explain/TransportExplainTransformAction.kt
64.77% <0.00%> (-2.28%)
:arrow_down:

...nt/rollup/action/stop/TransportStopRollupAction.kt
70.93% <0.00%> (-1.17%)
:arrow_down:

...earch/indexmanagement/transform/model/Transform.kt
85.21% <0.00%> (ø)

...ndexstatemanagement/IndexStateManagementHistory.kt
78.72% <0.00%> (ø)

...earch/indexmanagement/transform/TransformRunner.kt
86.42% <0.00%> (+0.71%)
:arrow_up:

...ensearch/indexmanagement/rollup/model/ISMRollup.kt
94.73% <0.00%> (+1.75%)
:arrow_up:

...rch/indexmanagement/rollup/model/RollupMetadata.kt
84.52% <0.00%> (+1.78%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b5705...4c4761a. Read the comment docs.


Entitizing

I'm guessing that the line
characters &, <, and > are always entitized to &, <, and > respectively
should be displaying the entitized string but when posting the page they have been un-entitized

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a4b4c7d-dbc7-1e59-9dd5-8aaff8a3d061
Version Independent ID: 47b3b896-bc7d-8b6e-9c28-60e7d2fd8491
Content: Define the Serialization of XML Data - SQL Server
Content Source: docs/relational-databases/xml/define-the-serialization-of-xml-data.md
Product: sql
Technology: xml
GitHub Login: @MightyPen
Microsoft Alias: genemi

This Issue #5782 is now Fixed by private PR 18024.

https://github.com/MicrosoftDocs/sql-docs-pr/pull/18024

The fix should be live in less than 48 hours.
@KentGorrell , thank you for bringing mistake to our attention.  The origin of the problem was in imperfection in a tool we used a few years ago to bulk translate from our old Content source into markdown.  This was a tricky case, and the tool was not literally perfect.
I am Closing this Issue 5784 now, as fixed.  We hope to hear from you again.
GeneMi (= MightyPen)


feat: 🎸 add an option to show input chip when selected for link

✅ Closes: #808

[x] I read the contributing guide
[x] I agree to follow the code of conduct

Summary

display input chip when selected for link text
add an option displayWhenSelected to link node (default: false)

How did you test this change?

Test cases:

.use(
    gfm.configure(link, {
        input: {
            displayWhenSelected: true,
        },
    }),
)

Running the following commands also show no errors:

pnpm test passed.
pnpm build:packs passed.
pnpm build:doc passed.
pnpm doc:preview works as you expected.

@Saul-Mirone The default value of displayWhenSelected is false, is it necessary to change it to true?

@Saul-Mirone The default value of displayWhenSelected is false, is it necessary to change it to true?
I think it is better to show the input chip by default after toggle link.

Let's keep it false to avoid unexpected behavior in current version. I'll consider to change it in next minor version.


Support for storybook 7

Is your feature request related to a problem? Please describe.
Currently can't use the addon with Storybook 7.
Describe the solution you'd like
Support for Storybook 7.

+1 on this.

+1

+1

Hey @ArturoDucasse and everyone watching this issue, this addon changed from storybook-addon-designs to @storybook/addon-designs and alongside with that change, the support for Storybook 7. The documentation was also updated to reflect the new package.
Please use @storybook/addon-designs instead and things should work as intended!

this addon changed from storybook-addon-designs to @storybook/addon-designs

Great to see @pocka's project became part of the official Storybook ecosystem. IMHO it may be worthwhile adding the information regarding the above change to the README.md, to avoid friction or confusion for people upgrading their addons as part of a Storybook upgrade (such as myself, luckily i found this issue).


add obsrvtn_event_dnstr, obsrvtn_species_codes_dnstr to access model output

For CCIRA/Gowgaia style 'inferred' habitat for a given species, we need to know if an observation of a given species is downstream.
This seems like the best way to do that, with known limitation that the list generated is only for observations within the same group.

complete with #300


Fix issue 393

Description
Fixes #393
Type of change

Documentation update

Testing steps
N/A

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   70.39%   70.39%
=======================================
  Files          12       12
  Lines         652      652
=======================================
  Hits          459      459
  Misses        189      189
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef0f81...80e6462. Read the comment docs.