[NETBEANS-1074] Module review j2ee.kit

Added license headers to files in test/qa-functional/data, as they are not in the rat report
Scanned sources and no other issues
No external libraries

Did you run Test before and after your changes? If tests fail, we should not add the license header to test data.

@junichi11 thanks for the review.  I have issues running the j2ee.kit tests even without the modifications to the license headers in-place.  They tend to error out regardless.  After making the modifications, I see the same issues arising.  Do you wish for me to omit the license headers for the test data?  Thanks

@junichi11 Perhaps I am running the tests incorrectly?  Can you please point me in the correct direction to issue the "ant test" command for testing a specific module?  Typically I traverse inside of the module and then issue the command.   Thanks in advance!

I tested the following steps:

open the module
right-click the functional test file e.g. J2eeProjectsTest.java
click "Test File"

Many functional tests seem to fail before the license headers are added... I'm not sure whether we should add the license header. Test data are already excluded from rat report.
@matthiasblaesing Should we add the license header to test data?

@junichi11 I have had the same assessment as you...many functional tests were failing before the headers were added to those files.  Let me know if you'd like for me to roll the headers back.
Thanks for your time, it is appreciated.

@junichi11 the ASF has pretty good summary here: https://www.apache.org/legal/src-headers.html#faq-exceptions (TL;DR: test data can omit the header if the test would fail if it is added), so in general testdata should hold the license header. In general adding the header is a problem where either a direct comparisson between generated text and a reference text is done or where fixed file offsets are used to find elements in the file.

@matthiasblaesing Yes, I know it. In this case, I think that it is hard to verify all tests because many tests fail before the license header is added. So just add and go ahead?

@matthiasblaesing Agree with you. Thank you!

Let me know if you need anything else done with this PR before it is merged.  Thanks

@junichi11 I only took a quick look, but in general it looked good. The tests are indeed broken before, so it would say: Lets get this in.

@matthiasblaesing I've checked only the license headers. Other than one file should be OK. However, I'm worried about removing trailing whitespaces. These are test data. So, they may be added intentionally. I think that we should not remove them if possible until the tests are fixed.

I would go this way: Run the unittests for j2ee.kit on master - not which tests fail, rerun with this patchset applied, compare. If the same number or less unittests fail, merge it. @juneau001 it would be great if you could do it.

I don't think that we can remove trailing whitespaces with that comparison. However, please squash and merge this if it is OK with Matthias.
As I wrote above, I think that we should just add the license headers. i.e. We should leave other than those as it is. @juneau001 So, could you please add only the license headers to test data from next time?

@junichi11 I committed the JSP header changes, but I cannot get the commits to squash.  I must be doing something incorrectly.  Would you please be able to tell me which commands to use in order to squash the commits?  Thanks in advance!

@juneau001 Please don't worry. We can use the "Squash and merge" button. So just fix the license header :) If there is no problem, Matthias would merge your changes, maybe. (As I wrote above, I don't think we should remove trailing whitespaces. So I would not merge this, sorry.)

@junichi11 @matthiasblaesing I ran tests on each package before and after applying the headers.  Same number of errors each time.  Thanks and let me know if you need me to do anything else.

@juneau001 Please don't worry. We can use the "Squash and merge" button. So just fix the license header :) If there is no problem, Matthias would merge your changes, maybe. (As I wrote above, I don't think we should remove trailing whitespaces. So I would not merge this, sorry.)

License header fix for the .jsp should be in the last commit.  Thanks

Sorry - I won't merge this. I just noticed, that this PR contains unrelated changes:

enterprise/websvc.jaxwsmodel/src/org/netbeans/modules/websvc/jaxwsmodel/resources/jax-ws.xml gained a header and that whole module was reviewed about a month ago
you claim that this is a review for j2ee.kit yet changes are all over the place (j2ee.ddloaders, j2ee.ejbcore, j2ee.ejbjarproject and several more)

I think it would be good to refocus and retry fixing only j2ee.kit. Thank you.

@matthiasblaesing I do agree with you...I attempted to squash commits yesterday and I see that other things got mixed into j2ee.kit.  It is unfortunate because we've spent a lot of time on this PR.  I can restart it to ensure that it is clean.  Thanks for your assistance.

I began this PR before the reorg was done on the directory structure.  I believe that other modules were somehow pulled into this PR when I performed a squash on the final set of commits.  Closing to start over.


H5 video full screen show nothing

Ionic version: (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If using HTML5 video in a nav in ion-split-panel, full screen mode show nothing(only chrome with this bug).
Expected behavior:
full screen.

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having? Thanks for using Ionic!

Hello! Is this still an issue with the latest version of ionic? If so, can you please provide a sample application via GitHub or https://stackblitz.com? Thanks!

It has been quite a while without a response, so I am going to close this issue. If this is still an issue for you, please provide a sample application demonstrating the issue that we can use to help debug and test this out, and I will be happy to reopen the issue.


Build docs in CI

If possible, I would like to build the RTD site as part of the CI.

I requested to join the RTD CI beta and was added, but for some reason the build just isn't being triggered. We can either spend some time trying to figure out why it isn't working or we can wait until RTD releases the integration generally. Either way, it looks like there are solid options moving forward.


[zh] add zh/docs/setup/learning-environment/kind.md, fix #23950

Add page content/zh/docs/setup/learning-environment/kind.md
update weight field of page content/zh/docs/setup/learning-environment/minikube.md to make ensure display order

fix #23950

Nice.
/lgtm
/approve


remove special chars

Added a few entries to replace list

@shantanuo thanks for the additional changes! I just reviewed the tests, it appears that the tests you've added/modified cause others to fail.
Could you take a look at the test cases that fail? There are two ways to do so.
You can run the tests locally if you have pytest installed. Be sure you are in the pyjanitor/ directory (top-level), and then run pytest at the terminal.
Alternatively, you can click on the "details" link to see the output from Travis.

Please accept the PR sent by the user "szuckerman" because his code is more pythonic. I have chained the "replace" method several times that was unnecessary.
He has also added "preserve_case" parameter to clean_names functions.
Is there any way to revert back my PR?

@shantanuo that's very gracious of you! Ok, I will accept his PR instead.
As for your PR, I just have to close it, and that'll be good enough. If you want, you can also delete your fork of pyjanitor, it won't affect my version.
It'll take me a little bit of time to do the release after merger. Hang tight!


Feature request: Carthage support for iOS

From @Andrea65 on February 16, 2018 11:14
Would it be possible to support Carthage libraries besides Cocoapod?
I'm developping a plugin that uses a third party library supplied only in carthage/framework.
Copied from original issue: NativeScript/NativeScript#5429

Hi @Andrea65,
Thank you for your suggestion.
Regarding that, we do not have plans for providing support for Carthage libraries in ios runtime.
However, we will log this issue as a feature request, and if there is interest, we will research how we could provide support for this lib in NativeScript.

+1


Allow multiple emails to be added when inviting members to workspace

Details
Allow multiple emails to be added when inviting members to workspace. Previously, only one email could be added at a time.
Fixed Issues
$ https://github.com/Expensify/App/issues/26242
PROPOSAL: https://github.com/Expensify/App/issues/26242#issuecomment-1735705251
Tests

Log in with any account
Add multiple emails at once as members to a workspace, by using a comma as a delimiter
Observe how all valid emails/numbers appear in the list (and how invalid ones are ignored)

[X] Verify that no errors appear in the JS console

Offline tests

Add multiple emails at once as members to a workspace, by using a comma as a delimiter
Observe how all valid emails/numbers appear in the list (and how invalid ones are ignored)

QA Steps

Log in with any account
Add multiple emails at once as members to a workspace, by using a comma as a delimiter
Observe how all valid emails/numbers appear in the list (and how invalid ones are ignored)

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/10816880/ac9b0b27-e1ea-487d-9c07-b873a993c04a

Mobile Web - Chrome
https://github.com/Expensify/App/assets/10816880/d952f7e9-c63d-4f7c-bf87-ea1bfe60aea1

Mobile Web - Safari
https://github.com/Expensify/App/assets/10816880/41aecff0-2f82-41b9-97b9-6b886a8cc55b

Desktop
https://github.com/Expensify/App/assets/10816880/560a4593-016d-4896-a621-a1ee199b1798

iOS
https://github.com/Expensify/App/assets/10816880/089ac5dc-99cf-4e09-a8f8-3924797440ed

Android
https://github.com/Expensify/App/assets/10816880/31ba7b0a-f1ec-489d-b3bf-337e0029612b

recheck

@Samueljh1 I started testing this but if I have consecutive comma it still won't show the valid emails.

Also when I have spaces in between as an invalid email, it will still filter out the correct email.

@mananjadhav Thanks for this. I have added a new commit to make the email parsing more strict.

recheck

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/3069065/08bf003c-758b-4b31-8b39-8813b4a87d2f

Mobile Web - Chrome
https://github.com/Expensify/App/assets/3069065/c4ba5298-4350-442d-80a5-d307650b3e8c

Mobile Web - Safari
https://github.com/Expensify/App/assets/3069065/ad5bb8df-6315-4e40-bc7b-4244951d9f20

Desktop
https://github.com/Expensify/App/assets/3069065/8b3f2156-f39a-441d-af12-184dcd6068bd

iOS
https://github.com/Expensify/App/assets/3069065/c44994d7-b295-4e2e-879e-b822101822e1

Android

Thanks for the patience here @Samueljh1. It was related to Workspace, so needed more time.
@francoisl All yours.
🎀 👀 🎀 C+ reviewed.

@francoisl fixed prettier issues, should be good to ship

All done @francoisl

@francoisl changes made, let me know if you're happy

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Weird, it looks like this caused a regression, I didn't initially catch it here, via scrolling up from the bottom on this PR, not sure how I would have, @mananjadhav , @Samueljh1 , any idea how I would?
https://github.com/Expensify/App/issues/29435#issuecomment-1759604153


Remove deprecated cri SandboxInfo RuntimeHandler

This field has been deprecated since 1.3. I think we can remove it as part of 2.0 deprecation?
The tracking issue mentioned in the code comment: https://github.com/containerd/cri/issues/1064
The release note mentioning the deprecation of this field:
https://github.com/containerd/containerd/pull/3492#:~:text=runtimeHandler field is moved from the sandbox info into status

cc @mikebrow could you PTAL this PR when you get some time? 🙏 (since you approved the PR to deprecate the field https://github.com/containerd/cri/pull/1063 😄 ). Thank you!

cc @dmcgowan @estesp  could you PTAL this PR when you get some time? 🙏 thank you!


#ngramCounts method should be added to NgramModel

I think it's nice that we have everything wrapped inside a single ngram object but some missing functionality makes it difficult to get to some of the properties from the outside, such as accessing the ngram count info.

The use case i had in mind was to be able to access the table in order to cut off some of the results (for example, if you want to leave only the results with frequencies above a certain threshold). If this is by design and you don't want people to modify the tables for their own use, then maybe there should be some implementation from within the ngram model that would handle cases like this.

OK.  But the private properties should not be accessible from outside. The way I see it (I might be wrong), it is the responsibility of the  NgramModel to perform the filtering after (or as part of) the training.
So you have two options:

Create a subclass of NgramModel and add the filtering functionality to this class
Update the current implementation of NgramModel and make a PR.

I think you should do the latter because indeed the filtering option could be very useful for many applications of the NgramModel.


Implement Git Files Discovery

Implement this example https://github.com/argoproj-labs/applicationset/blob/master/examples/git-files-discovery.yaml
Relate to #28
Might requires changes to the repo service

I want to work on this. However, there's some clarifications I need on this spec before proceeding.
Should we implement the file path filter regex as specified here: **/config.json? Contrary to the GitDirectory generator implementation, the directory path filter regex, e.g., addons/* is a valid filter working with Golang's path library.
But the regex used in the example here won't work as is to filter file paths using the path library. Examples

However, using a pattern like */*/*/config.json works perfectly with path.Match for paths specified in the example here.

I think that using a valid regex pattern that's directly compatible with path.Match(...) rather than coming up with a new non standard pattern like **/config.json would make more sense. Also, */*/*/config.json explicitly mentions at which level of the directory tree to look for the config.json file.
Thoughts? cc @OmerKahani @dgoodwin @xianlubird

I used path.Match in https://github.com/argoproj-labs/applicationset/pull/7

I have a few more queries.

Are Git directory generator and Git file generator mutually exclusive? (Seems so to me from the examples)
What are the allowed patterns/variations for path in git file generator? **/config.json will force to look for cluster configs in the entire repo. On the other hand, cluster-configs/**/config.json would be able limit search for configs to specific paths. What all patterns do we plan to support for path for file discovery?

cc @OmerKahani @xianlubird

I think we can start with them been mutually exclusive.
About the paths, both examples are good, and we should probably support both. I don't think we can map all the patterns in advance, we should structure the code so adding a new pattern is easy and can be tested with a unit test.
I will recommend starting with one or two patterns, get the PR merged, and then start to think about other patterns.
Hope this is helpful


[KYUUBI #2708] Open engine session and renew engine credentials in the one

Why are the changes needed?

To close #2708
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @lightning-L  @cxzl25

Codecov Report

Merging #2856 (130a3bb) into master (d958a2c) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #2856      +/-   ##
============================================
- Coverage     63.31%   63.29%   -0.02%
  Complexity      205      205
============================================
  Files           485      485
  Lines         21688    21696       +8
  Branches       2859     2860       +1
============================================
+ Hits          13731    13732       +1
- Misses         6658     6660       +2
- Partials       1299     1304       +5

Impacted Files
Coverage Δ

.../org/apache/kyuubi/config/KyuubiReservedKeys.scala
0.00% <ø> (ø)

.../kyuubi/credentials/HadoopCredentialsManager.scala
92.80% <60.00%> (-1.32%)
:arrow_down:

.../org/apache/kyuubi/session/KyuubiSessionImpl.scala
76.31% <75.00%> (+0.64%)
:arrow_up:

...ubi/engine/spark/SparkTBinaryFrontendService.scala
83.33% <93.75%> (+0.90%)
:arrow_up:

...ala/org/apache/kyuubi/operation/LaunchEngine.scala
84.61% <100.00%> (-5.39%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
80.82% <0.00%> (-1.37%)
:arrow_down:

...i/spark/connector/tpcds/TPCDSStatisticsUtils.scala
39.78% <0.00%> (-1.08%)
:arrow_down:

...la/org/apache/kyuubi/session/AbstractSession.scala
96.26% <0.00%> (-0.91%)
:arrow_down:

.../org/apache/kyuubi/events/KyuubiSessionEvent.scala
93.33% <0.00%> (-0.22%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d958a2c...130a3bb. Read the comment docs.

thanks, merged to master

The kyuubi.engine.credentials is still visible in spark ui.


std Atomic{I,U}{8,16}::fetch_{max,min} seem to broken on a few platform (LLVM bug)

std Atomic{I,U}{8,16}::fetch_{max,min} is currently broken for the following targets
https://github.com/taiki-e/portable-atomic/blob/55b3d49c293030016c1fc7f60e61e4eca6eec619/src/lib.rs#L1458-L1467
I haven't checked if it's a bug in rustc or in qemu-user, but this crate contains a workaround for this problem.
portable-atomic implements a workaround for this bug, so users aren't affected by this bug. This issue itself is tracking the upstream bug.

It seems armv5te's AtomicI{8,16}::compare_exchange is also broken: https://github.com/taiki-e/portable-atomic/runs/7041957669?check_suite_focus=true

It seems to be reproducible without qemu: https://github.com/rust-lang/rust/issues/100650

I tested MIPS targets because the problem on MIPS was supposedly fixed in LLVM 19, but it seems that only bit-endian's MIPS32R2 is actually fixed, other MIPS targets still have problems.
https://github.com/taiki-e/portable-atomic/actions/runs/11314088026


Topic/add cred scan to build

PR Summary
Including Credscan from the Microsoft Security Code Analysis from Microsoft, which enables to check for credentials in source code, thus improving code quality.
Related to: #185
PR Checklist
since this is only improving the pipeline, the checklist would not apply.

I will review ASAP

I think I found the people to Email. But if you know for sure who to contact let me know so I can get the extension added to the org.

@DarqueWarrior I added also a documentation page to the new CredScan task if people need to add suppression rules for unit tests.
Please tell me if I put it in the correct folder (I created the folder "build").
Also, I do not fully understand the suppression rules for "hash" type suppressions. If you want to use file-based suppression then we should think of a constants file for passwords that can be used within unit tests. Otherwise, we need to add many files to the suppression rules in the future.
What would be your suggestion?
And thanks for the quick installation of the task! 😄

I like the idea of a constants file with fake creds to use in tests.


Add Snippet of the Day/Week Feature for Highlighting Popular Snippets

Description: Feature one popular snippet on the homepage based on rating, recent usage, or activity.

Functionality: Automatically select a “Snippet of the Day” or “Snippet of the Week” based on predefined criteria (e.g., top-rated or most bookmarked). Display it prominently on the homepage.
Additional Features: Include an archive where users can view past featured snippets.
Implementation: Write backend logic to select the snippet based on rating or popularity, and design a section on the homepage for the featured snippet.

I would like to work on this issue kindly assign it to me under Gssoc'24 extended and Hacktoberfest.

Could you assign me this

Hi @ananyakaligal ,
Thanks for your interest in contributing! 🙌 You are welcome to work on this issue. Feel free to start by creating a branch and share updates or questions as you progress. Also go through our contributing guidelines first.
Looking forward to seeing your contributions! 🚀

can you assign it to me... I'm willing on work on this issue

@ananyakaligal
Hello! It's been 3 days since this issue was assigned. If you’re still working on it, please provide an update. Otherwise, I will need to remove you from the assignment to free it up for others to take over. Thank you!

@vk-cse go ahead, i am assigning you the issue as well.

thank you sir... I'll update you asap

@notsoocool hey, i'm really sorry..ive exams going on, ill do it in 2 days

No worries, @ananyakaligal! Thanks for the update. Focus on your exams, and you can get back to it whenever you're free. Good luck!

Any update @vk-cse and @ananyakaligal

@vk-cse working on it, will make a PR by the EOD

Okay, Thank you for the update!

@notsoocool i'm working on it. will update you asap

Hi @ananyakaligal and @vk-cse,
It’s been over a week without any updates. I will be closing this issue by the end of the day. If you have any progress to share, please do so before then.
Thank you!


darktable 4.2 fails to build with nixpkg version of lensfun 0.3.95

I'm updating the darktable package to the newly release version 4.2, but the build fails because now darktable explicitly doesn't support lensfun 0.3.95, which is the version packaged in nixpkgs.
lensfun 0.3.95 is (1) an alpha version at best, (2) is quite old, and (3) lensfun release 0.3.3 is newer (and compatible with darktable)
I don't mind packaging up lensfun 0.3.3, as I already carry an overlay for it on my system, but I'd like to work out whatever governance issues may arise before I put in that time.
TIA & happy holidays
@flokli  @goibhniu @flosse @mrVanDalo  @jtojnar

cc #207531

The update from 0.3.2 to 0.3.95 was included in ac91e6ae04ac014184bac9f29c0ceed4442c46c4, which links to https://github.com/NixOS/nixpkgs/pull/43754.
And https://github.com/NixOS/nixpkgs/pull/43754#issuecomment-887929942 already mentioned this shouldn't have happened (as it was a prerelease which wasn't flagged appropriately in repology) but there apparently never was a revert of that bump.
I think it'd make sense to change lensfun to 0.3.3, which is "their latest stable release", so https://github.com/NixOS/nixpkgs/pull/207531 looks like the right call to me.

https://github.com/NixOS/nixpkgs/pull/207531 is incomplete, as it'll use the wrong version XML files, since the XML files in master are v2 and release 0.3.3 requires v1.
I am going to create a git repo that pulls the tarball from the website and checks it into git, which will provide the correct version of the xml files
or
we can run the conversion script on the profiles, as is done in the flatpak: https://github.com/flathub/org.darktable.Darktable/blob/master/org.darktable.Darktable.json#L68

@flokli @paperdigits still open but seems fixed. Is this still relevant?

No, darktable 4.6.x does not support that version of lensfun at all. It is an alpha version and was never officially released by the lensfun team. TBH it should've never been packaged.
I think we haven't changed it because it would impact people who are already using that version negatively.
I have an overlay version of the newer 0.3.4 if we are interested in packaging that.
On February 19, 2024 11:22:51 AM PST, Szymon Scholz @.***> wrote:

@flokli @paperdigits still open but seems fixed. Is this still relevant?
--
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/issues/207610#issuecomment-1953051536
You are receiving this because you were mentioned.
Message ID: @.***>

Oops, we have changed it, this can be closed.
On February 19, 2024 11:22:51 AM PST, Szymon Scholz @.***> wrote:

@flokli @paperdigits still open but seems fixed. Is this still relevant?
--
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/issues/207610#issuecomment-1953051536
You are receiving this because you were mentioned.
Message ID: @.***>


Discord Canary not compatible with latest version [Bug]

Description
Discord Canary no longer opens properly with its latest update. Even when deleting all files related to BD, and uninstalling BD from Discord Canary, any reinstallations to Canary causes it to crash due to BD again. This occurs whether or not plugins or themes are installed.
Reproduction

Install BD to Discord Canary
Restart Discord Canary (ctrl + r)
Discord Canary no longer properly launches

Expected Behavior

Install BD to Discord Canary
Restart Discord Canary (ctrl + r)
Discord Canary opens with BD properly

Screenshots

Discord Version
Canary
Additional Context
The issue with restarting Discord seems to occur with the other versions as well, however, these are easily resolved with the removal of certain plugins. Discord Canary in particular simply does not load properly upon restarting the client.

Merging to #821


No links to learning about languages 05AB1E Actually Brachylog Husk Jelly ?

Hi, love your APL bar, it has helped me doing the Dyalog and GNU APL tutorials.
However, I am curious about these other language modes in your bar though -- are these other APL-like languages, or some esoteric 'expert' modes for doing APL development with special vocabularies?
I would request adding links to the languages, if they are other ones we could build and try, if applicable, or to appropriate FAQs for what these are. Thanks!
PS. Apologies if this is not the proper channel to contact you. I could not seem to find any email link in the via or via github.

Great idea! (Btw, only Jelly is related to APL, by way of J.)

Great idea! (Btw, only Jelly is related to APL, by way of J.)

:) Thank you. I like trying obscure languages but could not find links to most of the languages. I would love to try some of them if possible.

The first word in the heading for each page is a link:

Ugh. I hang my head in shame. Thank you.


HMAC512: register overlap in RDL

Since the move to hmac512 the HMAC512 TAG was widened and overlaps with HMAC512 LFSR SEED.

confirmed. it's due to extending HMAC tag to support hmac512. We will push LFSR_SEED to @000160 to avoid overlapping with TAG.


different partykit cursor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Related: #9502
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Community participation

[x] Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

hmm, close for now or apply just the random colors?

you can use random from the 500 row from tailwind colors - for light and dark mode
https://tailwindcolor.com/

same colors still appearing, should be different:

yeah when testing all the cursor had the same color

same colors still appearing, should be different:

hah fr I thought I'd fixed it when colors changed on refresh XD

okay for me, dont close the issue please with this pr
what about @prury ?

still:

@iMac7
lol, i may have been mistaken and may have took it from canary, sorry for that, but here it goes:

Looks like it works then 😄

still some dupes on the right side, but its better, yes

Thanks!
pay 50 usd

pay 50 usd

probably can resolve later

pay 50 usd
@iMac7 use /dot/ in url not /ahp/ :)

😍 Perfect, I’ve sent the payout
💵 $50 @ 10.29 USD/DOT ~ 4.859 $DOT
🧗 14dLrAvjDw7cFLaxM7VWR6YtHd7bGZY2QpzXDhAJJ4yv6oGw
🔗 0x3546d721be4cfa357e18a44fc706bca81082ef9005580bc3160783010fb52667
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


fix: Flatten the cache before filtering

Description
The endpoint https://cache.yearn.finance/v1/chains/1/vaults/getDynamic is returning an array of arrays, however we are filtering the addresses as if it was a flat array. Wondering if anyone has some context on why we are grouping this array into chunks of 20 and if we should get a flat array from that endpoint?
It's working for https://cache.yearn.finance/v1/chains/1/vaults/get because it's a flat array and both are using exactly the same filtering, but unfortunately that only works for the flatten one:
cached.filter((vault) => addresses.includes(vault.address));

Related Issue
Fixes https://github.com/yearn/yearn-sdk/issues/274
How Has This Been Tested?
Tested by running the sdk/fe locally
Screenshots (if appropriate):

Thanks @karelianpie this makes sense as to the reason why we're having the issue. The reason why we are 'paginating' the results is because if we attempted to fetch all of the vaults at once then the call would run out of gas, instead we split it into multiple separate calls, and aggregate the result. A lot of the reason why it runs out of gas is because it's fetching prices from the oracle, which can be very gas intensive - https://github.com/yearn/yearn-lens/tree/master/contracts/Oracle
I think this PR would fix it, but I think it'd be better to fix it at this line here - https://github.com/yearn/yearn-caching-api/blob/master/jobs/vaults.mjs#L29. Perhaps by using concat rather than push. This will let us leave the implementation in the sdk the same, consistent with other reads from the cache, and it'll be quicker for us to deploy the fix. Would you be happy making that change?

Thanks @karelianpie this makes sense as to the reason why we're having the issue. The reason why we are 'paginating' the results is because if we attempted to fetch all of the vaults at once then the call would run out of gas, instead we split it into multiple separate calls, and aggregate the result. A lot of the reason why it runs out of gas is because it's fetching prices from the oracle, which can be very gas intensive - https://github.com/yearn/yearn-lens/tree/master/contracts/Oracle
I think this PR would fix it, but I think it'd be better to fix it at this line here - https://github.com/yearn/yearn-caching-api/blob/master/jobs/vaults.mjs#L29. Perhaps by using concat rather than push. This will let us leave the implementation in the sdk the same, consistent with other reads from the cache, and it'll be quicker for us to deploy the fix. Would you be happy making that change?

Sounds good, done with https://github.com/yearn/yearn-caching-api/pull/53
I think that repo could do with some tests too at some point


TSF_MALLOC(...) without non-NULL check/error handling

I've checked the code, and TSF_MALLOC(...) appears to be used in many places without non-NULL check/error handling. Since such "out of memory unawareness" in code always infects each entire program that uses this library, and it's not a gigantic amount of work to do better, it would be nice if this could be fixed. Basically, any use of TSF_MALLOC should be followed by a check if the allocated item is not NULL, and if it is NULL, resulting safe error bail-out code that doesn't crash. Here are some (not all!) of the problematic spots:
https://github.com/schellingb/TinySoundFont/blob/bf574519e601202c3a9d27a74f345921277eed39/tsf.h#L731
https://github.com/schellingb/TinySoundFont/blob/bf574519e601202c3a9d27a74f345921277eed39/tsf.h#L830
https://github.com/schellingb/TinySoundFont/blob/bf574519e601202c3a9d27a74f345921277eed39/tsf.h#L1223
...and so on.

Hey there.
Now that there is plenty of usage of this library in embedded systems and other platforms with small amounts of memory this certainly is warranted. I wish I had thought of this when originally writing the code but I was in my usual mood of targeting the higher end platforms with fancy virtual memory and swapping.
It looks like tsf_channel_init might be the most annoying one to fix? Maybe it can be split up in fixing the allocation of non-channel API first. Most allocations are during loading which can just return NULL. New voices would just not play if the realloc there fails which should be fine, too.
Would you be interested in trying to improve things here? Otherwise I can see if I can find a few hours to do this.

Yes, I'd be interested in investing some hours soon to try a pull request for this. (No promises that I'll manage to catch all instances but I'll try, and I'd only do tsf.h and not tml.h since I happen to use a different parser). However, it might make sense to test & merge #1 first to avoid conflicts.


Trimming VK_KHR_synchronization2

Test code:
https://github.com/locke-lunarg/Vulkan-Tools/tree/sync2
The main stuff in this PR is vkQueueSubmit2.  The code is similar to what it did for QueueSubmit. The different is that vkQueueSubmit2 pack VkSemaphore and VkCommandBuffer to VkSemaphoreSubmitInfo and VkCommandBufferSubmitInfo. The two new features are timeline semaphore and device group. Nothing need to do for timeline semaphore. I prefer to leave device group to the following PR.

CI gfxreconstruct build queued with queue ID 12995.

CI gfxreconstruct build # 1635 running.

CI gfxreconstruct build # 1635 passed.

CI gfxreconstruct build queued with queue ID 13134.

CI gfxreconstruct build # 1636 running.

CI gfxreconstruct build # 1636 passed.


Revert "add namespace warning at top of standalone upgrade section"

Reverts kubeflow/website#2041
/assign @amygdala
Shall we revert this first before resolving https://github.com/kubeflow/pipelines/issues/4261

/approve

thanks, makes sense.
(I wonder if in the meantime we should add a note explicitly indicating that this doesn't work with marketplace installs).


Consider reversing layer order in JSON

The current way of defining the layers array is intuitive when you edit the JSON in a code editor: the visually topmost layer (first in the array) is rendered as the topmost layer in the map. However, it introduced some complexity during rendering, and also for other components such as layercontrol. It is also opposite to how the layers are ordered within OpenLayers and its API.
Changing the layer order (so that the last layer in the JSON array is rendered as the topmost layer on the map) would be a pretty big breaking change, so something that bumps eox-map to v2.0.0.

No strong opinion on this, as the use of the map is still under our control i would say if we want to make the change the sooner the better.
One point for changing is that someone using this would probably come from using OL before, so it would be more familiar to them

I would expect the same order like OL has which if I understand correctly means changing it (topmost in array is bottommost - e.g. first rendered on map). This means I am up for a change?


byzantine api gateway

Signed-off-by: dpitt<EMAIL_ADDRESS>Enables client access to Hyperledger Fabric blockchain network through RESTful API's.

No worries, we are not strongly tied to the name. I do like the
simplicity of Keyhole Fabric API Gateway, will talk with some folks around
the shop about changing it.
Thanks,
David
On Mon, Feb 3, 2020 at 7:39 AM Arnaud J Le Hors<EMAIL_ADDRESS>wrote:

@lehors requested changes on this pull request.
Sorry for not getting to this earlier but I really feel that the name is
inadequate. At the very least it should be something like Byzantine Fabric
API Gateway to clearly indicate the relationship with Fabric but I would
argue that the use of "Byzantine" here is unfortunate. This term obviously
has a strong connotation in blockchain space and I don't think it is
advisable to use it indiscriminately. It is only going to confuse. Couldn't
you simply call it Keyhole Fabric API Gateway? That'd be unique and precise.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hyperledger-labs/hyperledger-labs.github.io/pull/109?email_source=notifications&email_token=AAD675WIRUFT6PII24C6U23RBANCJA5CNFSM4J6WM542YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT7QO5Y#pullrequestreview-352257911,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD675QDCJVJBNPGD3Z2H4TRBANCJANCNFSM4J6WM54Q
.

--
*Mentoring, Training, and Consulting *
www.keyholesoftware.com
*Software Tools and Services for Enterprise Software *
www.keyholelabs.com

Per a couple suggestions changed the project and pull request name

@trbs : it looks like this PR is waiting your approval of your requested changes. Once that is done, we can merge this. Then @dpitt can transfer the repository to the hyperledger-labs organization.

Sorry for the delay.
Approved and ready to go :-)
Have a great labs project !

Thanks, let me know if you need help with the repo.
On Wed, Feb 19, 2020 at 5:52 PM trbs<EMAIL_ADDRESS>wrote:

Sorry for the delay.
Approved and ready to go :-)
Have a great labs project !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hyperledger-labs/hyperledger-labs.github.io/pull/109?email_source=notifications&email_token=AAD675U7QZJTEN6F6HSGUQ3RDXA3LA5CNFSM4J6WM542YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKFL7Q#issuecomment-588535294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD675SZD3OCOSHSJUIZKDTRDXA3LANCNFSM4J6WM54Q
.

--
*Mentoring, Training, and Consulting *
www.keyholesoftware.com
*Software Tools and Services for Enterprise Software *
www.keyholelabs.com


Update project to support latest Android SDK and tooling

Update project to support latest Android SDK and tooling
Description
This pull request updates the Android project setup including Gradle, Android Gradle Plugin, Java version, and Kotlin version to support the latest available Android SDK in order to meet build applications with latest Flutter and Android SDKs.
Key Changes:
1. General Android Project Update:

Updated Gradle to version 8.9
Updated Android Gradle Plugin (AGP) to version 8.7.3
Java version updated to 17
Kotlin version updated to 2.0.20
Android SDK updated to level 35

2. Updated Example App:

Reworked build.gradle files to accommodate new updates
Updated gradle-wrapper to include the new Gradle version
Fixed a typo in README.md which improves the documentation clarity

How Has This Been Tested?

✅ Run the project to ensure that it builds without errors using the new Gradle and AGP versions
✅ Launch the example app to verify that it runs correctly on devices or emulators targeting Android SDK level 35
✅ Verify documentation readability and correctness

Additional Notes
Please review the updates and merge them if everything is in order. This PR is crucial for maintaining the project's relevance and compatibility with new Android development standards.

🤦♂ It was late at night and I forked your repo instead of original. I recreated PR in original repo. But you can use this if you want to  😄


Second decimal mark

I understand using , or . or other character is a cultural issue, and usage varies across different regions. This said, the current international standards (like ISO 8601) tend to use . for such purposes. I would recommend using . as the default separator too, i.e. making the default datetime specifier %datetime{%Y-%M-%d %H:%m:%s.%g} instead of %datetime{%Y-%M-%d %H:%m:%s,%g}.

A reference: https://en.wikipedia.org/wiki/Decimal_mark
Honestly, I did not know there are more countries that use a decimal comma than countries that use a decimal point. Some interesting points:

In 1958, disputes between European and American delegates over the correct representation of the decimal mark nearly stalled the development of the ALGOL computer programming language.[Ha ha] ALGOL ended up allowing different decimal marks, but most computer languages and standard data formats (e.g. C, Java, Fortran, Cascading Style Sheets (CSS)) specify a dot.

In countries with a decimal comma, the decimal point is also common as the "international" notation because of the influence of devices, such as electronic calculators, which use the decimal point.

SI style: 1 234 567.89 or 1 234 567,89 (in their own publications, the dot "." is used in the English version, and the comma "," in the French version).

So I guess the decimal point is not that standardized as I thought, but is still preferred in the English/computing contexts.

According to ISO8601, comma is the recommended decimal separator (but dot is allowed, as well):

[...]  the	 decimal	fraction	shall	be	divided	from	the	integer	part	by	the	decimal	sign	specified	in	ISO 31-0,	i.e.	the	comma	[,]	or	full	stop	[.].	Of	these,	the	comma	is	the	preferred	sign.

The default C locale never uses such conventions. It is inconsistent with the rest of the system in its default behaviour. Inconsistency is always a bad thing.

According to ISO8601, comma is the recommended decimal separator (but dot is allowed, as well):

[...]  the	 decimal	fraction	shall	be	divided	from	the	integer	part	by	the	decimal	sign	specified	in	ISO 31-0,	i.e.	the	comma	[,]	or	full	stop	[.].	Of	these,	the	comma	is	the	preferred	sign.


Add testing bundle

I'd like to create custom testing bundle with folders structure

Created in #22 pull request


Rename config/apps/OpenSourceAppConfig.py to follow snake case convention

🐛 Describe the bug
Listed file name should follow snake case convention.
Also handle the related imports of this file and make sure that everything works.

@taranjeet want to work on this

Hey @subhajit20 , just assigned it to you


Section self-links are cut off

https://api.csswg.org/bikeshed/?url=https://github.com/WebBluetoothCG/web-bluetooth/raw/gh-pages/index.bs#security-and-privacy has its self-link too far to the left, where it gets cut off by the table-of-contents pane:

Done, they now exactly fill the gap between the TOC and content and are centered there.


Config option to disable rotten flesh to leather recipe

Would like a config option added to disable the rotten flesh to leather recipe for those who don't want to have to resort to using craft tweaker to remove it. It would be useful as a game balancing option.

Closed in d308e2d

@DWX12  Will upload the updatedd version soon


parsing error using INSTANTIATE_TEST_SUITE_P

There is probably an error during test name parsing and interpretation using INSTANTIATE_TEST_SUITE_P.
Here is my cpp test code :
INSTANTIATE_TEST_SUITE_P(
    StandardFilesWrite,
    MultipleFileWriteTests,
    testing::Values(
        FileWriter::BUFFER_SIZE,
        FileWriter::BUFFER_SIZE * 2,
        FileWriter::BUFFER_SIZE * 4,
        FileWriter::BUFFER_SIZE * 10,
        0ul,
        1ul,
        500ul,
        1000ul,
        5000ul,
        10000ul,
        100000ul,
        500000ul,
        1000000ul,
        10000000ul));

My test are well recognized for neotest summary but are not found for ctest instantiation.
Here is my investigation, It seams that ctest --show-only are interpreting code from GTEST macro :
$ ctest --test-dir build\src --show-only
...
  Test #248: StandardFilesWrite/MultipleFileWriteTests.WriteFile/65536
  Test #249: StandardFilesWrite/MultipleFileWriteTests.WriteFile/131072
  Test #250: StandardFilesWrite/MultipleFileWriteTests.WriteFile/262144
  Test #251: StandardFilesWrite/MultipleFileWriteTests.WriteFile/655360
  Test #252: StandardFilesWrite/MultipleFileWriteTests.WriteFile/0
  Test #253: StandardFilesWrite/MultipleFileWriteTests.WriteFile/1
  Test #254: StandardFilesWrite/MultipleFileWriteTests.WriteFile/500
  Test #255: StandardFilesWrite/MultipleFileWriteTests.WriteFile/1000
  Test #256: StandardFilesWrite/MultipleFileWriteTests.WriteFile/5000
  Test #257: StandardFilesWrite/MultipleFileWriteTests.WriteFile/10000
  Test #258: StandardFilesWrite/MultipleFileWriteTests.WriteFile/100000
  Test #259: StandardFilesWrite/MultipleFileWriteTests.WriteFile/500000
  Test #260: StandardFilesWrite/MultipleFileWriteTests.WriteFile/1000000
  Test #261: StandardFilesWrite/MultipleFileWriteTests.WriteFile/10000000
  ...

My debugging investigation with some prints give me this :
in lua/neotest-ctest/init.lua:58
table.insert(runnable_tests, testcases[node.name])

node.namedoesn't correspond with testcases since one is interpreted and the other is not.
Here is the printed list of non interpreted tests from node.name variable
StandardFilesWrite/MultipleFileWriteTests.WriteFile/FileWriter::BUFFER_SIZE
StandardFilesWrite/MultipleFileWriteTests.WriteFile/FileWriter::BUFFER_SIZE * 2
StandardFilesWrite/MultipleFileWriteTests.WriteFile/FileWriter::BUFFER_SIZE * 4
StandardFilesWrite/MultipleFileWriteTests.WriteFile/FileWriter::BUFFER_SIZE * 10
StandardFilesWrite/MultipleFileWriteTests.WriteFile/0ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/1ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/500ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/1000ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/5000ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/10000ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/100000ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/500000ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/1000000ul
StandardFilesWrite/MultipleFileWriteTests.WriteFile/10000000ul

if anybody has idea how to deal with this issue, I'm open to fix issue.

Pretty sure we've hit a limitation with simple text-based parsing that neotest-ctest currently relies on (through treesitter). I didn't really consider literal suffixes, named constants, or even preprocessor macros for that matter when I started working on supporting parameterized gtest tests. So the implementation is pretty naive in that respect.
I know that  gtest_discover_tests will run the test executable (as part of execute_process) in order to enumerate all the test cases for ctest. So I assume the test executable reports the test cases with their values replaced by their numeric/actual values, which should explain the output you see from running ctest --test-dir build\src --show-only.
Given your example, I think neotest-ctest should be able to parse StandardFilesWrite/MultipleFileWriteTests.WriteFile part of the parameterized tests reliably at least, but for the test case values it might be better if neotest-ctest just queried ctest and perfomed a match (with StandardFilesWrite/MultipleFileWriteTests.WriteFile as a match criteria) to parse the actual test case names reported by the gtest test executable to ctest.
As far as I can tell, there's two disadvantages to this method though: (1) Querying ctest as part of neotest's discover_positions may have a negative performance impact on test discovery, and (2) the parameterized test cases in the neotest summary would show up as:
StandardFilesWrite/MultipleFileWriteTests.WriteFile/65536
StandardFilesWrite/MultipleFileWriteTests.WriteFile/131072
StandardFilesWrite/MultipleFileWriteTests.WriteFile/262144
...
StandardFilesWrite/MultipleFileWriteTests.WriteFile/1000000
StandardFilesWrite/MultipleFileWriteTests.WriteFile/10000000

instead of the more verbose naming in your code.
Nevertheless, you should at least be able to run the individual test cases from the neotest summary. Which is better than not being able to run parameterized tests at all :sweat_smile:
While thinking on it, this approach might even work for the other parameter generators currently not supported by neotest-ctest as well. Would be nice if it did.
I don't have much time at the moment to have a look at this, but if you want to have a go at it then that would be much appreciated. I would start looking at neotest-ctest/lua/framework/gtest.lua and in particular the function gtest.build_parameterized. you would need to require("neotest-ctest.ctest") in order to query the test cases.


Fix pip version to 2.7.

Platformio currently only supports python 2.7 not 3.0. This leads to issues when having both python2 and python3 installed.
I ran into the following error:
Installing platformio...
Collecting platformio
  Downloading platformio-3.5.0.tar.gz (91kB)
    100% |████████████████████████████████| 92kB 2.5MB/s
    Complete output from command python setup.py egg_info:
    PlatformIO Core v3.5.0 does not run under Python version 3.6.4.
    Minimum supported version is 2.7, please upgrade Python.
    Python 3 is not yet supported.

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-8vfq5sgq/platformio/

Is there a way to make this work universally?

Why wouldn't this work? In my experience, pip aliases itself to pip2.7 when installing, so this would only fail if you don't have pip installed. Am I wrong?

Also, a way to avoid needing sudo for this is to attempt a user installation with --user. You'll need to refer to the full path as the directory might not be in the user's path afterwards, but that might be acceptable and it's cleaner than installing system-wide.

I fixed this locally by creating a virtualenv, but this means I had to remove the --user from pip install platformio --user. imho if you're going to run this outside of docker you should use a virtualenv.


Switches to cudnn-frontend pypi package

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
cuDNN frontend wheels are now available from pypi. Link
This PR uses pypi wheels for cudnn frontend instead of building them from source.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@t-vi @carmocca can you please approve and merge? Thanks!

Done 😄


fix resolution_milestones + batch_size in prolificdreamer configs

fix an AssertionError in prolificdreamer due to the batch size milestones check added in https://github.com/threestudio-project/threestudio/commit/1f3cb26c9044c710f6e838fc15324b7da64c539e.
assert len(self.heights) == len(self.widths) == len(self.batch_sizes)

closed as we already have a PR: https://github.com/threestudio-project/threestudio/pull/201


Create radars page

[x] Derive from OPERA
[x] Provide as CSV
[x] Provide link to CSV
[x] Section per country
[x] TOC
[x] Deep anchors to radar codes
[x] Link out the coordinates to a map

Radar page now available at https://aloftdata.eu/radars/


CompletableFuture future = new CompletableFuture<>(); // WHEN ThrowingCallable code = () -> assertThat(future).hasFailed(); // THEN assertThatAssertionErrorIsThrownBy.withMessage(shouldHaveFailed create())

CompletableFuture future = new CompletableFuture<>(); // WHEN ThrowingCallable code = () -> assertThat(future).hasFailed(); assertThatAssertionErrorIsThrownBy.withMessage(shouldHaveFailed create())

CompletableFuture อนาคต = ใหม่ CompletableFuture <> (); // เมื่อ ThrowingCallable code = () -> assertThat (ในอนาคต) .hasFailed (); assertThatAssertionErrorIsThrownBy.withMessage (ควรมีaveFailedสร้าง ()

CompletionStage tokenFuture = firebaseAuthService.getCustomToken(email); with CompletionStage tokenFuture = CompletableFuture.completedFuture(firebaseAuthService.getCustomToken(email).join());


Fix structure code alignment

Aligned the structure by removing white space.

/ok-to-test

/approve

Can we abandon this one @subh007 ?


0x32 Origin

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Origin opcode was not implemented
Issue Number: 104
What is the new behavior?
This PR adds the origin opcode to the kakarot VM, It currently fetches starknet address, It has to be changed in the future to fetch EVM address from the starknet address.
Other information

If you run "make format" should fix the "compilation-tests" issue


Generator: Executes integration tests with a configuration derived from application configuration

This makes tests more reliable since they use a configuration that is more real (since it's derived from main configuration).
Indeed it's currently possible to have passing tests because of wrong/outdated test configuration, whereas main application fails.
Also this decreases maintenance burden of test configuration (application-test.properties) since it only contains overridden parameters configuration.

Why keeping the application.properties test file with all properties in place?

Why keeping the application.properties test file with all properties in place?

The application.properties in fact has been renamed to application-test.properties, so it doesn't exist anymore.


[YUNIKORN-2856] Remove redundant conditional

What is this PR for?
Remove redundant of if function.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2856

Hi, thanks for your PR. Please resolve syntax error.

I see, there's two routes using the handler


Allow vector of floats for mean in statsrs::distribution::Normal (as per numpy.random.normal)

The code below understandably runs into a type mismatch as the argument mean of statsrs::distribution::Normal requires a f64.
Similar to np.random.normal in Python's numpy package, it would be good to add support for Vector arguments of mean in statsrs.
Rust code (doesn't work due to type mismatch in let n...)
let x0: Vec<f64> = thread_rng().sample_iter(Standard).take(200).collect();

let endpoint_mean: Vec<_> = x0
  .iter()
  .map(|&x| x * (-0.5).exp())
  .collect();

let endpoint_variance: f64 =
  (SIGMA.pow(2) as f64 /  (1.0 - (-1.0).exp())).sqrt();

// this should output a vector n of some arbitrary length (here, 200). the argument endpoint_mean could be a Vec<f64> (as per numpy), but currently must be f64.
let n = Normal::new(endpoint_mean, endpoint_variance).unwrap();

Python code (works with an array of floats)
x0 = np.random.normal(loc = 0, scale = 1, size = 10000) // initial points, outputs a 10_000 vector
mean = X0*np.exp(-0.5) // 10_000 vector
variance = np.sqrt(4/(1-np.exp(-1)) // = 1.5901201952413002
xt = np.random.normal(m,v) // = 10_000 vector

I'm not sure that this is in the scope of statrs, because in general this will depend on some array and possibly linear algebra crate. Shouldn't this functionality rather be provided by the array/linear algebra crates? Note that random (from the Python standard library) does not provide this either, you have to use the array library numpy instead.
Does the ndarray-rand crate provide what you want?

Is there a reason map is not the preferred way to accomplish this?
Alternatively, there's MultivariateNormal which has a constructor that allows multidimenstional arguments.

Is there a reason map is not the preferred way to accomplish this?
Alternatively, there's MultivariateNormal which has a constructor that allows multidimenstional arguments.

Apologies if this is going out of the scope of GitHub issues, but how would map work in this scenario? (To clarify, I start with an initial, random normal distribution of points, I take the mean and variance of the endpoint of an Ornstein-Uhlenbeck process, and calculate the random, normal distribution of endpoints from that).
MultivariateNormal seems promising, although I have a scalar variance and that crate requires a (co)variance matrix (perhaps this should just be a diagonal matrix?). I'll explore this crate further.

I'm not sure that this is in the scope of statrs, because in general this will depend on some array and possibly linear algebra crate. Shouldn't this functionality rather be provided by the array/linear algebra crates? Note that random (from the Python standard library) does not provide this either, you have to use the array library numpy instead.
Does the ndarray-rand crate provide what you want?

Thanks for the suggestion, but ndarray-rand only accepts floats as inputs. And yes, perhaps this is slightly outside the scope of statsrs! If this could be accomplished with statsrs and map (see above) then that would be interesting. Failing that, the MultivariateNormal crate could be interesting.

let x0: Vec<f64> = thread_rng().sample_iter(Standard).take(200).collect();

let variance: f64 =
  (SIGMA.pow(2) as f64 /  (1.0 - (-1.0).exp())).sqrt();

let normals: Vec<_> = x0
  .iter()
  .map(|&x| Normal::new(x * (-0.5).exp(), variance).unwrap())
  .collect();

Does this help?
I think you're expecting a different programming model coming from Python. Rust is more explicit, and functions cannot currently be overloaded based on the type of the arguments. There are some hacks to get around this, but they are rather atypical.
I'm not sure if you mistyped, I was referring to the type MultivariateNormal in this crate. Yes, picking a scalar covariance matrix would work. Although I've not tested whether the nalgebra matrices can be pushed like that, given they aren't sparse.

We have a multivariate normal distribution now, which supports this use case.


Trouble with incremental deploy: The "path" argument must be of type string. Received undefined

Hey there,
we're having trouble with incremental deploys. During Generating incremental deploy state, there seems to be an exception with the above error message.
What could be causing this / how can we fix this issue to finally be able to use incremental deploys? Would it make sense to share the entire build log / serverless template?
Here is an excerpt of the build log:
$ SLS_DEBUG=* serverless package --stage dev --package sls-package-output

150.69 s

Running "serverless" from node_modules

Packaging offer-tool-api for stage dev (eu-west-1)

Seed: Generating incremental deploy state...

Seed: There was a problem generating the incremental deploy state

    The "path" argument must be of type string. Received undefined

✔ Service packaged (146s)

Thanks in advance!

@SimonThormeyer not sure if you've messaged us on support about this yet?

@jayair not yet, but can do if that's the preferred way of support?
Cheers

Yeah it works better there. Unless of course you've found something specific to this plugin!

Hey @jayair, I discovered that this wasn't directly related to seed but probably this plugin, since downgrading the version of this plugin to version 0.3.12 made the error disappear (which occurs during the serverless package command).
I guess leaving I'm the issue open since the problem wasn't really solved.


demo does't work

I'm submitting a ...  (check one with "x")
[ ] bug report
[ ] feature request
[ ] support request

Steps to reproduce the bug:
Related code:
    insert any relevant code here

Important information:

Hey all, thanks a lot for registering this issue. I was using a hosting provider that wasn't cool at all, and by having a high amount of requests it was being shut down automatically. I updated the repo to use github pages instead (updated README also), so this should not happen again.
You can access here: https://yannbf.github.io/ionic3-components
Thanks once again!


Extended Duration of Integration Tests Run

Describe the bug
The integration-tests run time has been increasing steadily, now taking over 20 minutes. It seems that in some of the integration tests, no images are provided, resulting in the need to destroy the machine due to no OS. This, coupled with a high gracefulShutdownTimeout, as seen here, is causing the extended duration of the integration-tests run.
Proposed Solution
To improve the situation, machines should boot properly in integration tests so that the shutdown process can be triggered, ultimately leading to a shorter run duration for the integration tests.

i did that in this PR: https://github.com/ironcore-dev/libvirt-provider/pull/222/files


make cargo bench more stable

Describe the problem you are trying to solve
currently cargo bench isn't so stable, it doesn't run long enough, and the data can vary a lot (20-30%), which makes it hard to know if there is really a regression or not.
Describe the solution you'd like
no sorry
Notes

cargo bench is a wrapper around functionality in rustc. If you want to change the behavior https://github.com/rust-lang/rust is probably a better place to discuss it. On the other hand the bench is unstable exactly because it is not robust or flexible enough. There is work in rustc to make it more a plugin system. The recommendation at this time is to use the https://crates.io/crates/criterion .


Copy Content - edit fields are in the wrong order

4.1 edit screen is Active - name - copy
5.0 edit screen is copy - name - active

can not reproduce. looks right.


Fix bridging

Correct info on bridging based on Claude's article here:
https://spotlight.tezos.com/moving-tez-etherlink/
Preview: https://docs-etherlink-git-fix-bridging-trili-tech.vercel.app/get-started/bridging#how-bridging-works
Also need to cover  the reverse process.
Fixes #84.

LGTM.


Johnson's Algorithm

Describe the solution you'd like
Here is the step-by-step solution approach of Johnson's algorithm:
Add an extra vertex, called the "source vertex," to the given graph. Connect the source vertex to all other vertices with zero-weight edges.
Run the Bellman-Ford algorithm starting from the source vertex to find the shortest path distances from the source to all other vertices. If a negative-weight cycle is detected during this step, the algorithm terminates as the problem is infeasible.
Re-assign the edge weights of the original graph by using the computed shortest path distances. The new weight of an edge (u, v) is calculated as the sum of the old weight of (u, v) and the shortest path distance from the source to u minus the shortest path distance from the source to v.
Remove the extra source vertex added in step 1 and restore the original edge weights.
For each vertex in the graph, run Dijkstra's algorithm starting from that vertex to find the shortest path distances to all other vertices.
Finally, the shortest path distances between all pairs of vertices can be obtained by combining the distances computed in step 2 and step 5.
It's important to note that Johnson's algorithm has a time complexity of O(V^2 * log V + VE), where V is the number of vertices and E is the number of edges in the graph. The Bellman-Ford algorithm is used to compute the shortest path distances in step 2, and Dijkstra's algorithm is used in step 5.
By using Johnson's algorithm, you can efficiently find the shortest paths between all pairs of vertices, even in graphs with negative edge weights, making it a useful tool in various applications, such as network routing and graph analysis.

Please assign me this @Kumar-laxmi !!

refer #758


Add tests for filterByName and splitWithSeparator

added some tests for filterByName and splitWithSeparator.
One problem I found is I had to export the functions to make them visible. Looked into this a bit and found a solution on stackoverflow.
anyway, i'm totally new to QuickCheck and this is not quite as beginner as i expected :sweat:

@prt2121  well done!


I have encountered this as well occasionally

open

maybe caused by https://github.com/containerd/containerd/issues/3971

Hitting this as well, in the Debian packaged ContainerD. It seems as through ctr c rm <name> does not always delete all the state associated with a container.
$ ctr version
Client:
  Version:  1.4.0~ds1
  Revision: 1.4.0~ds1-1
  Go version: go1.14.7

Server:
  Version:  1.4.0~ds1
  Revision: 1.4.0~ds1-1
  UUID: 12cdce0a-9026-4402-bd82-ee608e25d87a


Could not load file or assembly 'System.Collections.Immutable with 3.0.3

Describe the bug
After upgrading to 3.03  I started getting build errors:
CSC : warning CS8032: An instance of analyzer Vogen.Rules.AddValidationAnalyzer cannot be created from C:\Users\richa\.nuget\packages\vogen\3.0.3\analyzers\dotnet\cs\Vogen.dll : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified..
1>CSC : warning CS8032: An instance of analyzer Vogen.Rules.DoNotUseDefaultAnalyzer cannot be created from C:\Users\richa\.nuget\packages\vogen\3.0.3\analyzers\dotnet\cs\Vogen.dll : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified..
1>CSC : warning CS8032: An instance of analyzer Vogen.Rules.DoNotUseNewAnalyzer cannot be created from C:\Users\richa\.nuget\packages\vogen\3.0.3\analyzers\dotnet\cs\Vogen.dll : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified..
1>CSC : warning CS8032: An instance of analyzer Vogen.Rules.DoNotUseReflectionAnalyzer cannot be created from C:\Users\richa\.nuget\packages\vogen\3.0.3\analyzers\dotnet\cs\Vogen.dll : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified..
1>CSC : warning CS8784: Generator 'ValueObjectGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.'

Downgrading to 3.0.1 solves the issue, explicitly adding the system.collections.immutable package did not fix the error
Did I miss a step in the upgrade?
Steps to reproduce
updated the nuget package to 3.0.3 and clean and rebuild
Expected behaviour
successful compilation

Thanks for the bug report @richardjharding - what framework are you targetting?

Also, what version of Visual Studio are you using? There was a bug in Visual Studio 2022 Preview 2.1 (and lower) which meant that analyzers would try to load the wrong version of System.Collections.Immutable

I think the version of Visual Studio is the key here. You need that latest version of either 2022 or 2022 Preview

I'm on Microsoft Visual Studio Professional 2022 (64-bit) - Preview Version 17.4.0 Preview 2.0
any other logs that might be helpful?

seems I'm a couple versions behind on preview - I'll update and see if that helps - preview 6.0 is out

I'm on Microsoft Visual Studio Professional 2022 (64-bit) - Preview Version 17.4.0 Preview 2.0
any other logs that might be helpful?

Aha! I had the exact same thing and I literally spent 3 solid days trying to suss out what the issue was. It is actually a bug in Visual Studio that was fixed in 17.4 Preview 3!
Vogen has a dependency on Microsoft.CodeAnalysis.CSharp, version 4.3.1, but this has a dependency on System.Collections.Immutable version 6.0. Thing is, it shouldn't - it should reference 5.0 because that's maximum version for netstandard. All analyzers should only target netstandard. It's all bit strange; if you use reflector to load that assembly, you'll see, even for this 'fixed' version, that it still has the wrong dependency:

Anyway, MS fixed it in Visual Studio itself. The Roslyn team helped me immensely on Discord!
I've never been more glad to see something fixed (albeit magically as far as my knowledge extends!)

yep that looks to have been it thanks! - upgrading to the latest preview solved it


[next] Add the old test suite to the grunt task (dummy PR with deliberately broken test to test CI)

It works as it should :-)
This relies on a hack to bypass the mocha detection by grunt-mocha-phantomjs.
The tests have to run in less than 10 seconds, which is unlikely to be problematic on current
hardware.
Alternatively, adding the following to tests/index.html also makes the old test suite compatible
with the mocha runner without a timeout, but it entails loading mocha:
<script src="../node_modules/mocha/mocha.js"></script>
<script>
    mocha.setup("bdd")
    describe("dummy test", function(){
        it("is a dummy test to run the old test suite with grunt-mocha-phantomjs like the new one", function(){})
    })
    mocha.run()
</script>

I can submit a PR with a clean history if you want.


chore: release 2.10.5

:robot: I have created a release *beep* *boop*
2.10.5 (2024-08-28)
Bug Fixes

compose: correctly handle multiple compose files with -f/--file option (acf0c29)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v2.10.5 :sunflower:


Travis CI is failing when fetching from maven

Started failing in https://travis-ci.org/googleapis/gapic-generator/builds/422278897, and it's been failing in all my open PRs.
Failure snippet:
> Task :extractIncludeProto FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Could not resolve all files for configuration ':compile'.
> Could not resolve com.google.api:api-common:1.1.0.
  Required by:
      project :
   > Could not resolve com.google.api:api-common:1.1.0.
      > Could not get resource 'https://repo.maven.apache.org/maven2/com/google/api/api-common/1.1.0/api-common-1.1.0.pom'.
         > Could not GET 'https://repo.maven.apache.org/maven2/com/google/api/api-common/1.1.0/api-common-1.1.0.pom'. Received status code 403 from server: Forbidden
> Could not resolve com.google.api:api-compiler:0.0.8.
  Required by:
      project :
   > Could not resolve com.google.api:api-compiler:0.0.8.
      > Could not get resource 'https://repo.maven.apache.org/maven2/com/google/api/api-compiler/0.0.8/api-compiler-0.0.8.pom'.
         > Could not GET 'https://repo.maven.apache.org/maven2/com/google/api/api-compiler/0.0.8/api-compiler-0.0.8.pom'. Received status code 403 from server: Forbidden

Doesn't seem to be a problem with fetching from https://plugins.gradle.org/m2, only problems from https://repo.maven.apache.org

Someone already filed an issue has been filed on TravisCI https://github.com/googleapis/gapic-generator/issues/2281

Seems to be fixed in our latest Travis runs. closing for  now


test that removeAllListeners works on elements without detector

I forgot to submit a test for that last change. :)

Thanks :)


Error handling in different environments

These returns stack string in most of the environments:
new Error().stack
new Error().stacktrace

Each environment has a different stack string. I need something like https://github.com/stacktracejs/error-stack-parser . I'll probably pull it in as a dependency. I'll whether this is possible.
By node.js there are functions which can return Array by default and not string. e.g. Error.captureStackTrace
By old msie you have to throw the Error to generate a stack string. By even older msie you can mock the feature by discovering the callee.caller.caller... structure. (but I guess I won't support msie7, because it does not support any type of watch.)

http://www.eriwen.com/javascript/js-stack-trace/

http://www.stacktracejs.com/

window.onerror is not supported everywhere: https://dev.opera.com/articles/better-error-handling-with-window-onerror/

http://stackoverflow.com/questions/4213351/make-node-js-not-exit-on-error
process.on('uncaughtException', function (err) {
  console.log('Caught exception: ' + err);
});

way too easy :+1:
I'll need a polyfill in the browsers, and that's all... some of them does not support window.onerror, by them I cannot do anything I guess.

https://github.com/LuvDaSun/xhr-polyfill here is an xhr polyfill if I want to create a logger which automatically sends the errors to the server...

I think the logger should be a special Listener, which binds to process.uncaughtExceptions or window.onerror. it should have a factory dependent on the environment. that's all. so global error catching and stacktrace parsing what I need to implement. the core should contain only an EventEmitter, which emits Error instances. a simple Listener can bind to it. I should implement stack parsing by native errors as well.

http://extechops.net/2011/generic-onerror/
it is possible to add the onerror calling to UserError by browsers like opera 11.5- . the only problem that some of the errors are caught, and there is no way to check whether an error was caught
so we are not talking just about throw new UserError here, but a lot of try-catch blocks which send the errors to error Publishers... I can define a global Network error subscriber, which will be able to log.

I should have a UncaughtError composite class, so I will be able to send it to a queue or to the server etc... along with caught errors. it is important to know when our code does not catch every error.

http://stackoverflow.com/questions/951791/javascript-global-error-handling
window.onerror = function(msg, url, line, col, error) {
   // Note that col & error are new to the HTML 5 spec and may not be
   // supported in every browser.  It worked for me in Chrome.
   var extra = !col ? '' : '\ncolumn: ' + col;
   extra += !error ? '' : '\nerror: ' + error;

   // You can view the information in an alert to see things working like this:
   alert("Error: " + msg + "\nurl: " + url + "\nline: " + line + extra);

   // TODO: Report this error via ajax so you can keep track
   //       of what pages have JS issues

   var suppressErrorAlert = true;
   // If you return true, then error alerts (like in older versions of
   // Internet Explorer) will be suppressed.
   return suppressErrorAlert;
};

http://stackoverflow.com/questions/7898952/best-practice-for-reporting-client-errors-with-window-onerror
$("img#my-image").error(onImgError).prop("src", "images/my-image.jpg");

catching error by loading image which is not found

I think the best option here:
var original = console;
global.console = new Logger();
console.echo(original);

or
var reporter = new ConsoleReporter({
    // ...
});
global.console = new Logger({
    reporters: [reporter]
});

we need a way to access the original console...
var global = (function (){return this;})(),
    console = global.console;
df.native = {
    global: global,
    console: console
};

so by adding a new ConsoleReporter() we can access the df.native.console
another way to not override the console. and use global.logger instead...
so logger.log() would be okay.
since Network would have an own logger Subscriber they will be able to have their own logger if they want...

Workers have their own onerror which has the same problem as window.onerror: it does no support stack properly... :S

Moved to o3 https://github.com/inf3rno/o3/issues/60


New QuantEcon/base

Assets

Environment
Resources

Linux
git, wget, pandoc, texlive-latex-base, texlive-xetex, inkscape, ...

Julia (v1.0 Environment)
Expectations, Compat, IJulia, Interpolations, Revise, QuantEcon, InstantiateFromURL, Plots, GR, Parameters, Distributions

Julia (QELP)
Whatever's in the latest https://github.com/QuantEcon/QuantEconLecturePackages, as well as the last tagged release.

Python
quantecon, pandas, numba, numpy, scipy, urllib3, matplotlib, linearmodels...

Overview/Changes

Instead of using local TOML, we use the InstantiateFromURL.jl setup (along with a few base packages in the v1.0 environment), so that there's only one set of dependencies to maintain.

Instead of basing off of jupyter/scipy-notebook, we use the jupyter/base-notebook to manage image size.

As per @sglyon, we decided to persist the Julia user depot in a Docker volume. I think the most elegant way to do this is to specify a VOLUME statement from inside the Dockerfile, and then give that volume a name at runtime. See below.

Usage
@jlperla I made a few changes; here are the new instructions. Will put these into the lectures soon. These should be followed in order.

Install the Docker image.

Run docker pull quantecon/base.

Clear any existing qe-julia Docker data volume (or other name).

Run docker volume rm qe-julia.

Create a container.

Run docker run --rm -p 8888:8888 -v qe-julia:/home/jovyan/.julia quantecon/base.
This is worth unpacking. The --rm flag says that Docker should garbage-collect this container (but not the associated data volume) upon exit. (The -d flag had some bad side-effects, like suppressing the token for the Jupyter notebook). The -p flag is standard. The -v flag will either:

If the volume doesn't exist, create it, fill it with the ~/.julia specified by the image, and then proceed to step 2.
If the volume does exist, use it in place of the ~./julia specified by the image.

Stop a container.

Just ctrl+c it, or run docker kill $(docker ps -aq) in the terminal.

Run a container in the local folder.

This will require specifying two volumes, or:
(Linux) docker run --rm -p 8888:8888 -v qe-julia:/home/jovyan/.julia -v "$PWD":/home/jovyan/local quantecon/base
(Powershell) docker run --rm -p 8888:8888 -v qe-julia:/home/jovyan/.Julia -v {pwd}:/home/jovyan/local quantecon/base

@jlperla In order to use this persistently, run docker create volume quantecon to create a volume named quantecon, and mount it using docker run -p 8888:8888 -v quantecon:/home/jovyan/work -d quantecon/base. Everything students save to the work directory (including package versions installed on top of the base) will be persisted between containers.

(I'm still making some tweaks, but nothing that changes core functionality or structure).

All sounds great! What do you guys think about preparing a simple shell command and bat file which formalize the commands? Then we could tell people to put it somewhere in their path? The instructions could have it download as a link in some repo (eg static build assets)

Sure, we can do that @jlperla

Are we sure the gc is a good idea? I think we should avoid it.  Especially with the new Julia package system where you would frequently be using different package versions simultaneously


fixes several sonar code-smell for no assertion in test.

fixes sonar code-smell for "Add at least one assertion to this test case."
List of sonar links related:

https://sonarcloud.io/project/issues?id=GoogleContainerTools_jib&issues=AXrlUTLzcB_fbtb802UR&open=AXrlUTLzcB_fbtb802UR
https://sonarcloud.io/project/issues?id=GoogleContainerTools_jib&issues=AXrlUTjqcB_fbtb802X_&open=AXrlUTjqcB_fbtb802X_
https://sonarcloud.io/project/issues?id=GoogleContainerTools_jib&issues=AXrlUTUecB_fbtb802Vf&open=AXrlUTUecB_fbtb802Vf
https://sonarcloud.io/project/issues?id=GoogleContainerTools_jib&issues=AXrlUTUqcB_fbtb802Vh&open=AXrlUTUqcB_fbtb802Vh

Used expect attribute of the @Test annotation for tests that success with no exceptions. This should be enough to silent sonar.

Adding some context: I only found about this attribute in this stack-overflow answer.
Briefly read here and junit javadoc describes Test.None as default empty exception.
Let me know what do you think about this approach?

LGTM, just a few minor comments.


Foreground Task Doesn't Work on iOS

Hi,
We are trying to fetch data from API on interval given to Foreground task. Despite it shows as started, nothing happens on interval or sometimes. Perfectly works on android but we have tried --release mode on our real device iphone 14 pro nothing happens.
Only when user interacts with notification from foreground task it fires _onReceiveTaskData but it ends with count 3. Then no notification comes.
We tried to reproduce example app. Enabled background fetch, background processing.
Declared that works fine on foreground but does not work.
Is there anything except from it?

Does the example work fine in debug mode?

It works same as debug mode. I need to ask it, if we leave app and use another apps is not  it expected to run along?
It works like count 5ish and stops the work on example app debug mode.

no. using another app means that the app running the task has entered the background state.
check this plugin limitations.
if the app can't perform tasks at the exact time, but you want to run it periodically in the background, trythis flutter_background_service.

Okay, thanks for infroming me about these states.
I know background service interval can not be less than 15 minutes. Is scheduling local notifications then make operations under the notifs working to decrease fetching interval like 30 seconds or is there any limitations again? Or does rooting the phone work?

This plugin does not implement BGProcessingTaskRequest. I simply used Timer.scheduledTimer to allow short interval while the app is in use. This method has the advantage of being able to communicate with the main isolate (UI isolate) while maintaining the internal state of the TaskHandler.

This plugin does not implement BGTaskScheduler. I simply used Timer.scheduledTimer to allow short interval while the app is in use. This method has the advantage of being able to communicate with the main isolate (UI isolate) while maintaining the internal state of the TaskHandler.
https://github.com/Dev-hwang/flutter_foreground_task/blob/a61fbcbf6208239fc698ef0f9427fa036719e6e6/ios/Classes/service/BackgroundService.swift#L305C20-L305C40

@alperenbaskaya58
This plugin does not implement BGTaskScheduler. I simply used Timer.scheduledTimer to allow short interval while the app is in use. Timer.scheduledTimer only runs in the background for about 30 seconds. This is a limitation of iOS. You must return to the app to continue working.
https://github.com/Dev-hwang/flutter_foreground_task/blob/a61fbcbf6208239fc698ef0f9427fa036719e6e6/ios/Classes/service/BackgroundService.swift#L305


feroxbuster: 2.9.4 -> 2.9.5

Diff: https://github.com/epi052/feroxbuster/compare/refs/tags/v2.9.4...v2.9.5
Changelog: https://github.com/epi052/feroxbuster/releases/tag/v2.9.5
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228549 run on x86_64-linux 1

1 package built:

feroxbuster


Fix add raider tropo docker

Fixed janky specifile - docker verified working locally with new specifile. I probably skipped something when I previously tested successfully. 🤷
Updated environment install to use only conda forge

Thank you. Hopefully, it will work


Added missing known_failure import

cql_tracing_test.py currently doesn't run because known_failure was added without an import for it.

I pushed this fix before I saw your PR. In the future, feel completely free to push these kind of things to directly to master.

Thanks for the advice, in future I will push this kind of things directly to master.


Color of Raid notice

is there a way to change the color of the Raid notice font that appears at bottom middle of screen?
not the one that appears in the bottom left chat.
Wish to change it from blue to bright yellow.

Raid leader noticrs are displayed in yellow by default. You can change the color in the Tera chat settings.

yes my raid leader color is selected to yellow, but the words that appear in the middle-bottom of the screen are blue.

This is the one i mean - it's blue.

If you have lNotice is enabled, then the messages at the bottom are displayed as party leader notices. I don't know how to change this color.