Multi-target with .NET Standard 2.0

Hey @MisinformedDNA,
Great! Multi-targeting actually it's a better idea than publishing a separate package for EF Core 3.
Can you think of any scenario that we can mess it up for someone? 🤔

Projects with net5.0 TFM, will pick up the netstandard2.1 version. So they will be on EF Core 5. It's OK.
Projects on NETFX, will pick up the netstandard2.0 version. So they will be on EF Core 3. That will be OK too.
Projects with net3.1 TFM and older? I assume they will pick up the netstandard2.0. That's OK perhaps? 🤔 Anyhow, right now they can't consume the Ardalis.Specification.EntityFrameworkCore v5 since it's on 2.1, right?

@fiseni I don't see any downsides.

I have just started using Ardalis and I find its architecture interesting for developing applications with clean code.
I am developing an app that has three entities: Category, Document, Product and everything works fine except when I want to list the products where the name of the category and the document appear.
This is my Product entity
`namespace Domain.Entitys
{
public class Product: AuditableBaseEntity
{
public int IdCategory {get; set; }
public int IdDocument {get; set; }
public string Code {get; set; }
public string Name {get; set; }
public string UM {get; set; }
public decimal PurchasePrice {get; set; }
public decimal SalesPrice {get; set; }
public int Stock {get; set; }
    public Category Categories {get; set; }
    public Document Documents {get; set; }
}

}and my ProductDto:public class ProductDto
{
public int Id {get; set; }
    public int IdCategory {get; set; }

    public string Category {get; set; }

    public int IdDocument {get; set; }

    public string Document {get; set; }

    public string Code {get; set; }

    public string Name {get; set; }

    public string UM {get; set; }

    public decimal PurchasePrice {get; set; }

   public decimal SalesPrice {get; set; }

    public int Stock {get; set; }

    public bool Status {get; set; }`

When making the list I get this:
"pageNumber": 1,
"pageSize": 10,
"succeeded": true,
"message": null,
"errors": null,
"data": [
    {
        "id": 4,
        "idCategory": 1,
        "category": null,
        "idDocument": 1,
        "document": null,
        "codigo": "CPMK0004",
        "nombre": "Desayuno Cumpleaños",
        "um": "Pack",
        "precioCompra": 15.20,
        "precioVenta": 21.50,
        "stock": 10,
        "estado": true
    },

My PagesProduct is as follows:
`public PageProducts (int pageSize, int pageNumber, string name, string code)
{
Query.Skip ((pageNumber -1) * pageSize)
.Take (pageSize);
        Query.Include (x => x.Categorys)
                .Where (x => x. Status == true)
                .OrderByDescending (x => x.Id);

        if (! string.IsNullOrEmpty (name))
        {
            Query.Search (x => x.Name, "%" + name + "%");
        }

        if (! string.IsNullOrEmpty (code))
        {
            Query.Search (x => x.Code, "%" + code + "%");
        }
    }`

They could tell me where I may be failing so that the list does not match the names of those properties.
Thanks for your support.
Greetings from Peru.

@Huacnin Please file a new issue.


mat-select not showing mat-error on submit.

Bug, feature request, or proposal:
mat-error not displayed when form is submitted. I see there was an issue on this which has been closed, but I'm still experiencing this problem after my update to 2.00-beta-12.
<mat-form-field>
      <mat-select placeholder="Choose Job Role*" formControlName="role" ng-required="true">
        <mat-option *ngFor="let rl of roles" [value]="rl">{{ rl }}</mat-option>
      </mat-select>
      <mat-error *ngIf="role.hasError('required')">
        Job Role is required.
      </mat-error>
</mat-form-field>

on touch and leave the error shows, but not on submit.
What is the expected behavior?
After form submission the relevant error message should show if the select field is invalid.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular ^4.4.6

was on ^5.00 but mat-select threw error when changing the chosen option so on https://github.com/angular/material2/issues/8213 #issuecomment-341735433 they said to downgrade core to 4.x and so I did to avoid  getting the error.

Typescript ^2.6.1
Material ^2.00-beta.12
OS Windows 10
Browsers (Chrome, Firefox)

Fixed in rc0 via https://github.com/angular/material2/pull/7640.
https://stackblitz.com/edit/material2-rc0-tcjgdf?file=app%2Fapp.component.html

Closing as closed by #7640


Support enumerating a channel

This wouldn't be 100% accurate, but we could use sources like Filmot, IA, etc to try to query all the videos of a channel

I'm not sure this is a good idea, given how large many channels are.
If I were to do it, it would be a standalone project.


Django1.10

django 1.10 branch with only a few changes to make django-plans compatible with django 1.10 and translations to pt_BR

@cypreess take a look please

@arianerocha could you look is there any changes needed for 1.11 support? Could you also fix things changed in setup.py (repo url)

Sure @cypreess! I'll check and fix setup.py

Pull request https://github.com/cypreess/django-plans/pull/56 is newer and fixes this already.


Merge Issue#6 to main

Changed calling the python script to flask api
To trigger the text generation select the text, right click and click on either Generate Documentation Below or Generate Documentation Above to generate documents above or below the selected text
The input to the LLM is the selected text, trimmed.
process.py can now take all arguments either via the .env file or command line arguments
The vs code extension can take the below arguments via the settings.json file  "jaac.modelPath": "",
  "jaac.embeddings": "",
  "jaac.prompt_yaml_path": "",

FastAPI might be a better option over Flask RESTful: https://fastapi.tiangolo.com/
Built in documentation. error handling, and support for larger apps if we decide to support multiple versions or host the API on a server somewhere

I'll look at changing it to use fastapi. It doesn't matter much for now, but I agree it will give us some capabilities for the future.


Make the component ChangeDetectionStrategy.OnPush friendly.

When ChangeDetectionStrategy.OnPush is used, the component after updating its model has to call markForCheck on ChangeDetectionRef.
The above has to be called where the value is updated programatically. I hope to have covered all the cases.

Could someone please explain in detail how this can be implemented ?
Reference to the issue I raised - https://github.com/CuppaLabs/angular2-multiselect-dropdown/issues/51

I think the ngmodel takes care of the changes right now.


[SPARK-31946][CORE] Make worker/executor decommission signal configurable

What changes were proposed in this pull request?

This PR proposed to make worker/executor decommission signal configurable.

Added confs: spark.worker.decommission.signal / spark.executor.decommission.signal
Rename WorkerSigPWRReceived/ ExecutorSigPWRReceived to WorkerDecomSigReceived/ ExecutorDecomSigReceived

Why are the changes needed?

The current signal PWR can't work on macOS since it's not compliant with POSIX while macOS does.  So the developers currently can't do end-to-end decommission test on their macOS environment.
Besides, the configuration becomes more flexible for users in case the default signal (PWR) gets conflicted with their own applications/environment.
Does this PR introduce any user-facing change?

No (it's a new API for 3.2)
How was this patch tested?

Manually tested.

cc @cloud-fan @dongjoon-hyun @holdenk Please take a look, thanks!

Test build #133514 has started for PR 30968 at commit 851d4c1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38103/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38103/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38103/

Test build #133514 has finished for PR 30968 at commit 851d4c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133514/

Test build #133561 has started for PR 30968 at commit 3afdf70.

Test build #133561 has finished for PR 30968 at commit 3afdf70.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133561/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38150/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38150/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38150/

Merged to master for Apache Spark 3.2.0.


Documentation for the Sky programming model

Better docs would help develop a better mental model of how Sky works for new developers adopting it.  Some questions that came up for me:

What's the lifecycle of a Widget?  When is it Ok to call which methods?
It seems that you can only create new Widgets from build() methods.  What are other restrictions that generate a runtime error but aren't enforced by static checks?
When can the developer use existing Widgets, and when do you have to subclass Component and StatefulComponent?
What is a contract on the Component implementation?  What should I do and what can't I do?  What's the deal with syncConstructorArguments()?
How is Sky model different from Swing and GWT frameworks?

/cc @Hixie
I'll take a pass at a first draft of this doc.

Some of these topics are addressed at the end of the tutorial https://flutter.github.io/tutorial/, but we should present the information in reference form.

What's the lifecycle of a Widget?

Sorry it took so long to answer your question.  When I drew out the diagram for the lifecycle of a widget, it didn't many any sense, so we did a big refactoring project to fix it.  Now the state machines make sense and are draw in this slide deck:
https://docs.google.com/presentation/d/1cw7A4HbvM_Abv320rVgPVGiUP2msVs7tfGbkgdrTy0I/edit?usp=sharing

When is it Ok to call which methods?

This is now documented in dartdoc for each method.

It seems that you can only create new Widgets from build() methods.

This is no longer the case.  Now you can create widget whenever you like.

What are other restrictions that generate a runtime error but aren't enforced by static checks?

There are lots of them.  We use asserts liberally throughout the codebase to enforce various path-dependent invariants of the system.  For example, initState needs to call super.initState or it will trigger an assert.  Hopefully these asserts have reasonable messages that explain the issue.  If you run into some that are mysterious, please file bugs and we'll attempt to demystify them.

When can the developer use existing Widgets, and when do you have to subclass Component and StatefulComponent?

Widgets are meant to be used by composition rather than subclassing.  That means you almost always subclass StatelessComponent or StatefulComponent and return tree of Widgets in your build function.  There are still a few cases where we subclass widgets (e.g., Scrollable), but we've been using less of that over time.
It's very possible that we shouldn't be using subclassing in Scrollable either.  We might want to look at that issue at some point.

What is a contract on the Component implementation? What should I do and what can't I do?

This should now be documented in dartdoc comments.  If the dartdoc comments are insufficient, please file a bug with specifics and we'll improve them.

What's the deal with syncConstructorArguments()?

We've removed syncConstructorArguments from the system because it was too confusing.

How is Sky model different from Swing and GWT frameworks?

The main difference is that Flutter is a functional-reactive system, which means the "create" and "update" steps in Swing and GWT are combined into a single "build" step.  The other major difference is that you build Flutter widgets by composition rather than inheritance.  I'm not sure how best to document these ideas other than to say them in the getting started guide and in the tutorial.  If you have specific ideas for how we can improve the docs in connection with this question, would you be willing to talk with me in person?  That's probably a better way to get something useful here than creating a long bug thread.
Thanks for filing this issue.  Working through your questions motivated me to make a lot of improvements to the system (e.g., drawing out the component lifecycle made me very interested in doing fn3).


[resolves #2790] org.apache.tika module has missing dependency for org.apache.xerces

retest this please


colcon build fails on Foxy

Hi all, I've been working with this library on ROS2 Dashing/Ubuntu 18 and today updated to Ubuntu 20 with a fresh install of ROS2 Foxy. I cloned this repo and have been unable to get colcon build to succeed. Here are the steps I've been taking to reproduce the build failure. Please let me know if there's anything else I can provide or do to get this issue fixed.
Cheers,
Luke

You need to use the foxy branch, not ros2

Thanks for the speedy reply! I've tried using the contents of both the foxy-devel branch and ros2 branch, I get the same error on both.

You probably have something cached wrong somewhere, I just verified (output of history in my terminal):
 2004  mkdir -p hi/src
 2005  cd hi/src/
 2006  git clone git@github.com:ros-drivers/ros2_ouster_drivers.git -b foxy-devel
 2007  cd ../
 2008  source /opt/ros/foxy/setup.bash
 2009  colcon build

builds fine

This was indeed a cache-related issue. After recompiling and reinstalling pcl the packages build fine. Thanks!


Blog as app content did not work because of missing request context

Made modification to render_to_response of ElephantblogMixin to get templates from content/ and use RequestContext.

I ran across this bug also, but the code in this pull request didn't work for me.  All I had to do to get this to work, was add the 'request' key to the context.  Here's the code I used:
Imported RequestContext
from django.template import RequestContext
Added the 'request' key to the context
def render_to_response(self, context, **response_kwargs):
    if 'app_config' in getattr(self.request, '_feincms_extra_context', {}):
        context['request'] = RequestContext(self.request)
        return self.get_template_names(), context

marcelbeumer: This code branch requires the FeinCMS v1.5 class based view (feincms.views.cbv). Most FeinCMS template tags require the request django context processor. I'm not sure why the request would not be available in the final template -- the context from the application context and the context from FeinCMS itself is merged after all before rendering:
https://github.com/feincms/feincms/blob/next/feincms/content/application/models.py#L415
cjflory: I haven't tested your code but it seems that there is a bug in there: Shouldn't context['request'] be the request instance itself, not a RequestContext? That being said, I don't think this is necessary at all (as outlined above)
I'd be grateful for additional comments;
Thanks!

matthiask:  You're right...it's not necessary.  The default settings.py file created by startproject in Django 1.3.1 doesn't have the TEMPLATE_CONTEXT_PROCESSORS setting.  I removed my changes to the views.py file, and added this to settings.py, and it works perfectly!
TEMPLATE_CONTEXT_PROCESSORS = (
    'django.contrib.auth.context_processors.auth',
    'django.core.context_processors.request',
)

Cool, thanks!


"Could not gather sufficient random data" random_bytes(), docker and php7

Hi everyone,
This is a quick notice for anyone that has the above issue ("Could not gather sufficient random data") with docker with random_bytes and docker.
There seems to be a general issue with php 7.x and 7.1.x at the moment where most people cannot use random_bytes(); within a docker container. The reason is that the random_bytes() implementation that ships with php7 calls a system function getrandom() more details here.
The getrandom() system function isn't available to php when it is compiled against one linux kernel and then used with another. This is frequently but not exclusively true with docker because we use images that were compiled on the hub or from a package manager. A lot of the time we tend not to compile php ourselves.
It looks like there will be a fix in the next release version. For now try downgrading to 7.0.15 or 7.1.1.
Bug
Cause
Fix
Cheers,
Will
P.s. Apologies if the above information is incorrect. My source is written in german and I'm not a fluent german speaker.

Thanks for the report. I'll leave this open for a while with the "informational" label on it, in case anyone comes here looking for an answer to this issue.

@ramsey Thanks hopefully it will save people some time. I added some text to describe a temporary solution.


Add howardjohn to pilot owners

Also removed ijsnellf as they haven't contributed to Istio in months

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
13fdabf96da1c74fcc05ce2e7acaf9ac227e6163
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
13fdabf96da1c74fcc05ce2e7acaf9ac227e6163
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
47706689e4f34da69f6261c63df2e97fb4dcc0e3
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
47706689e4f34da69f6261c63df2e97fb4dcc0e3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Reenable acyclic compiler plugin

Would be nice to have acyclic reporting on warning level.
See https://github.com/com-lihaoyi/acyclic/pull/24


Documented scale of CIELAB wrong?

The documentation says CIELab values for a and be should be between -50 and 50.
However, I get sensible results, comparable to wikipedia here:
https://en.wikipedia.org/wiki/CIELAB_color_space#/media/File:Lab_color_space.png
When using a range of -100, 100:
import matplotlib.pyplot as plt
import colorspacious
import numpy as np

N = 1200
a, b = np.meshgrid(np.linspace(-100, 100, N), np.linspace(-100, 100, N))

for L in (20, 50, 80):
    lab = np.full((N, N, 3), L)
    lab[:, :, 1] = a
    lab[:, :, 2] = b

    rgb = colorspacious.cspace_convert(lab, 'CIELab', 'sRGB1')
    # rgb = np.clip(rgb, 0, 1)
    rgb[np.any((rgb < 0) | (rgb > 1), axis=-1)] = 0

    w, h = plt.rcParams['figure.figsize']
    fig = plt.figure(figsize=(h, h))

    ax = fig.add_subplot(1, 1, 1)
    img = plt.imshow(rgb[::-1], extent=[-100, 100, -100, 100])
    img.set_rasterized(True)

    ax.set_title(f'$L* = {L}$')
    ax.set_xlabel('a*')
    ax.set_ylabel('b*')

    fig.tight_layout()
    fig.savefig(f'build/plots/lab_{L}.pdf')

I also see pronounced steps, is this some numerical issue?

CIE L*a*b* is not technically bounded, the common [-128, +128] boundaries are appropriate for sRGB but larger gamuts will go beyond that. For example, ACES2065-1 has the following limits in CIE L*a*b*:
array([[ -58.99202084,<PHONE_NUMBER>6],
       [-404.18830391,<PHONE_NUMBER>4],
       [-274.02976251,<PHONE_NUMBER>4]])

The documentation states:

L* is scaled to vary from 0 to 100; a* and b* are likewise scaled to roughly the range -50 to 50

https://colorspacious.readthedocs.io/en/latest/reference.html

This should probably updated accordingly!

Notice the word "roughly" :-) Maybe the numbers in the docs should be tweaked, but all that sentence is trying to do is to give a rough idea of which scale we're on (e.g. they're not all floating point values <1).

I understand that, still, the -50 to 50 seem very rough, for sRGB the primaries are:
In [1]: from colorspacious import cspace_convert

In [2]: cspace_convert((1, 0, 0), 'sRGB1', 'CIELab')
Out[2]: array([53.23138711, 80.11440251, 67.21999924])

In [3]: cspace_convert((0, 1, 0), 'sRGB1', 'CIELab')
Out[3]: array([ 87.73559768, -86.18402274,  83.18300646])

In [4]: cspace_convert((0, 0, 1), 'sRGB1', 'CIELab')
Out[4]: array([  32.30269787,   79.19228008, -107.86329661])

What @njsmith is trying to say is that you should open a PR :D

Alrady did ;-)
#21


⚠ AGEG website (redirect) has degraded performance

In dc8f7dd, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2150 ms

Resolved: AGEG website (redirect) performance has improved in 3314d75.


Missing tags for 1.7.0 and 1.7.1

TSIA, it would be nice to have tags for 1.7.0 and 1.7.1 here, at least the latest 1.7.1, thank you!

Oops, looks like I forgot to release drafted tags and release. Sorry about that. Will fix this ASAP.

No worries, and thanks!


[ci.baseline.txt] Mark tensorflow-cc as skip on OSX

Currently, attempting to build tensorflow-cc on OSX is resulting in the builds timing out after 24 hours; this is clogging up the OSX pipeline, plus we expect the build to fail regardless.

/azp run

/azp run


Never render duplicate axis labels

In https://github.com/vega/vega-encode/pull/11#issuecomment-384479845 I proposed to only render unique labels. The tricky thing is to figure out which labels to show. Intuitively, we should show only the label that is closest to the value it is representing.
{
  "$schema": "https://vega.github.io/schema/vega/v4.json",
  "height": 200,
  "padding": 5,

  "data": [
    {
      "name": "table",
      "values": [
        {"amount": 3.8},
        {"amount": 1.5},
        {"amount": 4.3},
        {"amount": 2.1},
        {"amount": 1.1},
        {"amount": 3.3},
        {"amount": 1.9},
        {"amount": 2.7}
      ]
    }
  ],

  "scales": [
    {
      "name": "yscale",
      "domain": {"data": "table", "field": "amount"},
      "nice": true,
      "range": "height"
    }
  ],

  "axes": [
    { "orient": "left", "scale": "yscale", "format": "d" }
  ]
}

We currently show

But should show

cc @andrewbanchich


Docker Hub tags no longer include SBT version

For example: eclipse-temurin-11.0.16__2.12.16.

thanks for letting us know, already fixed in #215


Autologin and very significant refactor of stores and login views

This is a preliminary PR for review purposes, since a lot of stuff is changed.
All related to this PR:
https://github.com/zulip/zulip-mobile/issues/32
Principles followed (that will in time expand to other parts of the app):

Very flat stores, almost all stores contain primitives or list of objects, but not objects within objects within objects
Multiple reducers can process the same action, for simplicity and better organization of data

Stuff to be done:

Logout
Handling of stored but invalid login
Better testing of whole workflow

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!

I think we should rename almost all components that are ZulipThisAndThis to just ThisAndThis.

I am continuing to commit in this branch, but it is ready to merge when you don't have more comments.

Thanks for the updates @borisyankov. I'm looking through the code again now.
Tested it in the simulator and noticed that the stream subscription colors aren't showing up (in either the stream headers or in the stream sidebar). Also, the app fails when opened for the first time because action.payload.auth is undefined in appReducers.js:41

Also, I agree that we should remove the Zulip prefix from the component names

@borisyankov would you mind creating separate PRs for the presence and user list changes? Easier to review and merge if each PR is one set of related changes.

The two features were very interconnected, and that forced the continuation.
I actually have few more issues to fix until the presence is mostly done.
I will fix the two issues you reported, and will make sure the presence is done.
Will a well working PR be easier to merge? :)

I will also write few unit tests for some of the reducers.

@borisyankov I just noticed that narrowing seems to be broken when running this in the simulator

The latest commits address all the issues and fixes the colors and auth exceptions.
I am continuing work in a different branch based off of this one...

Continuing the multi-account in a separate branch based off of this one, so it is easy for you to follow the new changes. It is coming today or tomorrow, since I am adding UI and new behavior for account picking.
If you want you can merge this one, or wait for me to finish the multi-accounts.

@borisyankov Would you mind rebasing this off of master to get rid of the merge commits? I'd like to preserve all of the commits you have when I merge this in but maintain a linear history (with no merge commits).

Would you mind just squashing this time?
Tried couple of times the interactive rebase, and remembered how many merge conflicts there were... also on some of the merges there were mess ups that were fixed later.

@borisyankov No worries. I just tried to rebase against master (using git rebase master) and fixed some of the conflicts -- seemed to work ok. If you don't mind I'll merge this version (with all your rebased commits) so that the whole PR isn't one huge commit


All buttons pressed at all times.

The title is self-explanatory, when I start the program all the buttons are being pressed so nothing is playable.  Log looks like this and it just keeps going and going. What am I doing wrong?

EDIT: I tried both the older and newer versions, 0.14, 0.15, 0.17 and 0.18.

@anonymus177 do you happen to have any other controller emulators installed? I am thinking there might be some other software interfering with XJoy. The best way to find out would be to try installing on a fresh install of windows 10 and see if it works. Please let me know anything unique about your setup that you think could be causing this, as without the ability to reproduce the error I have no way to debug.

Xjoy was the first I tried, I started trying the others only after it didn't work. But amazing news - after the last update it miraculously works! So it could have been caused by the analog sticks maybe? I have calibrated them by myself, maybe that was the issue, but now it all works as it should and I'd like to thank you for your amazing work!

Hah great to hear its working and yeah no idea why lol!


Limit which tasks transformers has support for

Until now, the Hub assumes transformers has support for all tasks for which there's API, such as audio-to-audio (and there's no AudioToAudioPipeline in transformers). This list is derived from https://github.com/huggingface/api-inference/blob/main/shard/app/validation/init.py#L24
This will hide widgets/snippets for tasks not supported here

I opened https://github.com/huggingface/moon-landing/pull/9442 for moon-landing
For api-inference-community, given all recent changes and that we're not adding new tasks over there recently, I would just keep as-is for now.


Make LDAPInitialContextFactory dynamic for LDAP.

Description:
With the current LDAP implementation LDAPInitialContextFactory, is being hard coded. Make it dynamic and allow it to read from user store configurations.

Fixed with https://github.com/wso2/carbon-kernel/pull/2114


Better management of output filenames and previous run directories

While programming the diff utility, I realized I wanted access to the Pipeline's knowledge of its
output filenames, so the diff utility knows which files to compare in which order.
Working on making that available led to a whole bunch of related improvements:

moved the logic that decides on filenames to class methods which can be overridden easily when developers subclass Pipeline and want to change the names of things
Picked the name for the "prev run dir" based on the timestamp of the PREVIOUS run, not the current timestamp!
Moved the logic that moves old run files in to the previous run dir into one place - previously I had hacked it into several different places
Removed the logic that added incremental number to phase names for saving - this just wasn't needed any more because phases have their own logic to pick a name from the class name if not set otherwise
Added safety checking to make sure that none of the files are going to overwrite each other - while at it, also checked that the developer hadn't saved the source file into the output directory with a name that would collide (or more likely, that the developer would enter a name of a previous output file into the pipeline as input)

I like this all better overall; with the previous arrangement of logic we had choosing the run dir name in a different place than creating it, as well as moving old files to prev run dir in too many places.

This PR looks great.  I like the refactorings.


Error on querying unsuccessful tx

Note: This is not an issue resolvable in this repo. It's just documented here for further discussion.
Description
A failed tx can't be found in the chain in Stargate version.

Details
Cmd used to create tx
{app}d tx bank send {addr 1} {addr 2} 10token --from=user1 --keyring-backend test --chain-id {app} --account-number 0 --fees 100000token

Returned result after tx created
{"height":"0","txhash":"3396E19225B0E275AA0AEFF09E8C3488DDFF615134AF41B1E8C3F67C726DEEEB","codespace":"sdk","code":5,"data":"","raw_log":"1000token is smaller than 100000token: insufficient funds: insufficient funds","logs":[],"info":"","gas_wanted":"200000","gas_used":"25241","tx":null,"timestamp":""}

Cmd used to get tx
bard q tx 3396E19225B0E275AA0AEFF09E8C3488DDFF615134AF41B1E8C3F67C726DEEEB

Returned error
Error: RPC error -32603 - Internal error: tx (3396E19225B0E275AA0AEFF09E8C3488DDFF615134AF41B1E8C3F67C726DEEEB) not found

That's the correct behavior that can be observed both on Launchpad and Stargate.
When tx fails due to lack of funds (when a user sends more than they have), tx is registered on-chain. When tx fails due to "insufficient funds" for fees, it fails a "basic check" and is not included in the block.

@fadeev I see. But in Launchpad, after a failed tx is created, you can query it with tx hash, and getting this response:
{
  "height": "34",
  "txhash": "1E7C7AAD1BB6ED73EEFE4695CB01C3BD6C4C917F1A91CD316ADC4B800363B7FB",
  "codespace": "sdk",
  "code": 5,
  "raw_log": "insufficient funds: insufficient account funds; 1000token \u003c 1000000token: failed to execute message; message index: 0",
  "gas_wanted": "10000000",
  "gas_used": "36258",
  "tx": {
    "type": "cosmos-sdk/StdTx",
    "value": {
      "msg": [
        {
          "type": "cosmos-sdk/MsgSend",
          "value": {
            "from_address": "cosmos1dj5ujle6e6ehsual67jgmkp3cqmv4uauk6vhwg",
            "to_address": "cosmos1dj5ujle6e6ehsual67jgmkp3cqmv4uauk6vhwg",
            "amount": [
              {
                "denom": "token",
                "amount": "1000000"
              }
            ]
          }
        }
      ],
      "fee": {
        "amount": [],
        "gas": "10000000"
      },
      "signatures": [
        {
          "pub_key": {
            "type": "tendermint/PubKeySecp256k1",
            "value": "AqpG/uXiR8hjsMDxDay/Fb9iYpL/iuT3usufzxrPbCo1"
          },
          "signature": "dgONcR3RbAiP+j8c0lRuoXmGHsjD9r3lyOgRPXDj/usOyw+ksmLA1K+bFZdBH+WkM8g5MJ2BtCuNfY73lkkvyA=="
        }
      ],
      "memo": ""
    }
  },
  "timestamp": "2020-11-10T12:59:06Z"
}

This is why block explorers can display failed txs, I suppose? Without the ability to query it, we can't display the failed ones.

@vince19972 here is a failed tx on Stargate. It's possible to query for this tx, because it has failed due to a lack of funds for transfer. If it had failed due to a lack of funds for fees, it wouldn't have been possible to query for it.

@fadeev Ahhh I see. Thanks for clearing up 🙏


Fix wrong special tokens being used for llmlingua-2

What does this PR do?

Fixes #181
The model_name parameter was not set when initializing TokenClfDataset which lead to the special tokens (bos/eos/pad) of the llmlingua-2-small model being used always, even when using the xlm-roberta-large based compression model.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@iofu728, @XufangLuo (I hope I tagged the correct people?)
I had to adjust the llmlingua2 tests slightly as the generated compressed text now differs a bit from before.


fix: switch from viper to koanf

mostly to get around spf13/viper#1014

Closing. I incorporated this in #232


envoy secret clean up

Please describe the Improvement and/or Feature Request

Scope (please mark with X where applicable)

New Functionality          [ ]
Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [X]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Project Release            [ ]

Possible use cases

We have secrect count limit in quota, and the secret is not cleaned up automatically after pod terminated.
Warning   FailedCreate             replicaset-controller               Error creating: Internal error occurred: admission webhook "osm-inject.k8s.io" denied the request: secrets "envoy-bootstrap-config-e605c17a-6bcf-4bce-9684-2d47af3bf3a4" is forbidden: exceeded quota: xxxx-quota, requested: secrets=1, used: secrets=280, limited: secrets=280

A different way of provisioning the bootstrap config is explored here: https://github.com/openservicemesh/osm/pull/2234
We need to either change how we deliver the bootstrap config (find a better way) or find a way to clean-up secrets once a pod is terminated.


Added in write to file example in README.md, and added font examples

I was making use of the gem to write a tag cloud out for some histogram data, and I needed to save this generated tag cloud to file.  Not rendering on a page, which I think might be the typical use case.  Just thought it might be helpful to have a save example too and additional fonts.

Thanks!


MongoDB support

Did this work support MongoDB? I think mongo is more convenient to store those fingerprints (most of my project were using Mongo), so just want to sure if dejavu support mongo, if it does, how to config in dejavu?

its possible i think, i will  try implement it on this project...

@algeorge That would be nice! Another question, can this repo using for recognize different human voice? For example to differ my voice and my friends?

No its only for audio noise see:
"Note that for voice recognition, Dejavu is not the right tool! Dejavu excels at recognition of exact signals with reasonable amounts of noise." if you are looking for voice recog then theres alot of repo can do that.

Thanks pal, I am newbie in voice recognition, do know any opensource tools which can using for train a model to recognize voice or convert voice into text?

theres few of them but i like Pocketsphinx  i used mainly for my talking chatbot. "google is the magic!!!"

@jinfagang no Mongo support at this time.
@jinfagang @algeorge there are many tools to do ASR (speech to text). Google, MS, IBM all have their own offerings.


[ENH] Migrated LSTMFCN Classifer from sktime-dl

Reference Issues/PRs

Fixes #3193
PR checklist

For all contributions

[x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Hey @fkiraly ,
Wanted to confirm if the creation of modules directory here is in line with what you were recommending when we discussed this.

Sorry I forgot to comment on this,
The issue I am facing with this classifier is that authors in sktime-dl have created there on keras layer (LSTMAttention) for this in a separate file: layer_utils in sktime_dl
To migrate the same structure into sktime I was thinking to create a modules directory (and then add appropriate layers there) (I have done this in current PR)
Need clarification if I can approach with this (also there seem to be dependancy issues wrt it, so some help on that) or if there is a better and cleaner option

can this not go in the network dir? Let's not proliferate subdirs of src root.

Hey,
Facing a soft dependancy issue in this, we need to import keras.layers in the file in this in the file (not within the class/function as is recommended) in the file attentionlstm.py
Is there a possible workaround for it?

stick the import inside the function

@fkiraly it cant, since those imports are essentially base classes from which our defined classes AttentionLSTM and AttentionLSTMCell are inheriting

@fkiraly
From what I understand, the idea behind Network classes was such that any keras network would be wrapped around it, yes, but in a way which would allow us to directly use the particular network for the estimators (like CNNNetwork can be easily used within CNNClassifier just by calling an object of it)
In this case, the AttentionLSTM network is not meant to be used in a way where we directly use it within the estimator, just that its a network which is used within another network
A possible solution could be that we stick the functions _getAttentionLSTMCell and _getAttentionLSTM (basically all the functions in the file networks/attentionlstm.py) within the LSTMFCNNetwork, which would make the network class a bit crowded, but would still preserve the architectural consistency.


Migration.rb: deal with $stdin being Nil (happend for some reason in …

…production)

This happens to me if I run svn2git --rebase as a cronjob:
* * * * * svn2git --rebase > ~/cron_log 2>&1

The error in ~/cron_log is then:
#<Thread:0x000055f5267eaa10 /usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:404 run> terminated with exception (report_on_exception is true):
/usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:405:in `block (2 levels) in run_command': undefined method `chomp' for nil:NilClass (NoMethodError)
	from /usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:405:in `loop'
	from /usr/lib/ruby/gems/2.7.0/gems/svn2git-2.4.0/lib/svn2git/migration.rb:405:in `block in run_command'


cannot run az network firewall ip-config create using Azure CLI in powershell 6 Locally

Describe the bug
cannot run az network firewall ip-config create in powershell on local Windows 10 PC.  Error returned from the script is
request failed: Error occurred in request., RetryError: HTTPSConnectionPool(host='management.azure.com', port=443): Max retries exceeded with url: /subscriptions/xxxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/Test-FW-RG/providers/Microsoft.Network/azureFirewalls/Test-FW01?api-version=2019-09-01 (Caused by ResponseError('too many 500 error responses',))
To Reproduce
The IP addresses and code is copied from Deploy and configure Azure Firewall using Azure CLI  The web page assumes you are using the BASH shell but I removed the line continuations for powershell
az extension add -n azure-firewall
az group create --name Test-FW-RG --location eastus
az network vnet create --name Test-FW-VN --resource-group Test-FW-RG --location eastus --address-prefix <IP_ADDRESS>/16 --subnet-name AzureFirewallSubnet --subnet-prefix <IP_ADDRESS>/26
az network vnet subnet create --name Workload-SN --resource-group Test-FW-RG --vnet-name Test-FW-VN --address-prefix <IP_ADDRESS>/24
az network vnet subnet create --name Jump-SN --resource-group Test-FW-RG --vnet-name Test-FW-VN --address-prefix <IP_ADDRESS>/24
az network firewall create --name Test-FW01 --resource-group Test-FW-RG --location eastus
az network public-ip create --name fw-pip --resource-group Test-FW-RG --location eastus --allocation-method static --sku standard
az network firewall ip-config create --firewall-name Test-FW01 --name FW-config --public-ip-address fw-pip --resource-group Test-FW-RG --vnet-name Test-FW-VN

Expected behavior
When running the code in Azure Portal Cloud Shell BASH or PowerShell it works correctly;  However, the ip-config create command takes up to 5 minutes to complete.  I believe the timeouts for the CLI in the Cloud Shell are different than powershell 6 running locally which would explain why it executes successfully in the Cloud Shell.
When running in PowerShell under Windows 10 you get the error mentioned above:
Environment summary
Windows 10 Enterprise
Version 1903
OS build 18362.449

az --version
azure-cli                         2.0.81

command-modules-nspkg              2.0.3
core                              2.0.81
nspkg                              3.0.4
telemetry                          1.0.4

Extensions:
azure-firewall                     0.1.8

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\bdm0609\.azure\cliextensions'

Python (Windows) 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 02:47:15) [MSC v.1900 32 bit (Intel)]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Please let us know how we are doing: https://aka.ms/clihats

$psversiontable

Name                           Value
----                           -----
PSVersion                      6.2.4
PSEdition                      Core
GitCommitId                    6.2.4
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visual Studio Code Environment
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:58:56.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

Additional context
I normally run Powershell under Visual Studio Code but you will get the same error if running under the PowerShell Command Environment.

Another update.
I have a previously created resource group, firewall, vnet and correct subnet
AzureFirewallSubnet <IP_ADDRESS>/26
I Tried to run az network firewall ip-config create on the firewall and getting the same error as mentioned in the previous post.  The difference is that I executed the command within the Cloud Shell in both BASH and PowerShell.
az network firewall ip-config create --firewall-name "nxt-aaa-devnxt-wu2-afw" --name "IpConf"  --public-ip-address "nxt-aaa-devnxt-wu2-pip" --resource-group "nxt-aaa-devnxt-wu2-rg"  --vnet-name "nxt-aaa-devnxt-wu2-vnet"
request failed: Error occurred in request., RetryError: HTTPSConnectionPool(host='management.azure.com', port=443): Max retries exceeded with url: /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/nxt-aaa-devnxt-wu2-rg/providers/Microsoft.Network/azureFirewalls/nxt-aaa-devnxt-wu2-afw?api-version=2019-11-01 (Caused by ResponseError('too many 500 error responses',))

Hi @MyronFanQiu , could you please help take a look at this ?

add to S166.

@bmukes Hello. Let's confirm the problem.

running the full scripts within cloudshell in bash/powershell will success.
running the full scripts in local powershell will fail.
running the command with existed RG/Vnet/IP within cloudshell will fail.
Am I right?

Yes confirmed

@bmukes Hello. It's quite strange because azure cli doesn't do anything special. Do you still meet such problem? Do you try to create new RG, Vnet and IP?

I stopped trying to create a firewall using CLI for now because they cost approximarely $1000 per month which is a bit much for a development environment.
BRIAN MUKES | Architect
INSURANCE TECHNOLOGIES
t: +1<PHONE_NUMBER> | f: +1<PHONE_NUMBER>
[cid:image001.png@01D5E63C.DAD58430]https://www.insurancetechnologies.com/
From: MyronFanQiu<EMAIL_ADDRESS>Sent: Monday, February 17, 2020 10:37 PM
To: Azure/azure-cli<EMAIL_ADDRESS>Cc: Mukes, Brian<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-cli] cannot run az network firewall ip-config create using Azure CLI in powershell 6 Locally (#12082)
@bmukeshttps://github.com/bmukes Hello. It's quite strange because azure cli doesn't do anything special. Do you still meet such problem? Do you try to create new RG, Vnet and IP?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli/issues/12082?email_source=notifications&email_token=AAU2RRKNIB4PUGAP7KZU3TDRDNXWNA5CNFSM4KRBMMS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMAUVSY#issuecomment-587287243, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAU2RRIMUI2OZ25VV54RNI3RDNXWNANCNFSM4KRBMMSQ.
• Confidential and proprietary information may be contained in this communication, including attachments. If you are not the intended recipient, you must not use, copy, disclose, distribute or retain this communication or any part of it. Any unauthorized use, dissemination of the information, or copying of this message is prohibited. If you are not the intended addressee, please notify the sender immediately by return e-mail and permanently delete this message and any attachments.

@bmukes Hello. Thanks for opening this issue. Currently, we don't have enough tests for different terminals. We will consider this issue and add more tests for it in the future . I would close this issue first since it's not a blocker right now. Feel free to open a new issue if you have any more question.


time to archive?

hey @bsvensson 👋 i see that you just wired up a bot to close stale issues in this repo.
given the lack of activity, you might consider just archiving it.

Hello @jgravois 👋👋 - I wish!
No, not yet. But long-term yes that is the direction.


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.10.93

from: https://github.com/jenkins-x/jx

/retest


Remove git workaround since no longer run as root

As part of bringing updater into core, we stopped running as root.
Now:

base core Dockerfile flips to USER dependabot near the end
Updater Dockerfle has FROM dependabot/dependabot-core:$OMNIBUS_VERSION... buildkit inherits the user from the previous dockerfile.

So now that git is running as the dependabot user it can access the folder /home/dependabot/dependabot-updater/repo owned by user dependabot w/o needing us to specify a safe.directory exclusion.

I marked draft because this is blocked on an internal migration of one last place where we use this image running as root.
Once that migration is finished, this can be merged.

This is now unblocked as we're just finishing up the migration to no longer run as root internally:

https://github.com/dependabot/dependabot-core/pull/6309
https://github.com/dependabot/cli/pull/46


/request_axis_service is taking a long time to respond

Hello @samuelsadok,
I am using the odrive_can_node to rotate the botwheel. By starting the odrive_can_node and executing ros2 service call /request_axis_state odrive_can/srv/AxisState "axis_requested_state: 8", I was able to change to CLOSED LOOP mode. However, there was a delay of about 1 second in the response of the service after execution.
Upon checking the source code at https://github.com/odriverobotics/ros_odrive/blob/5e4dfe9df8e5ef4fb6c692c210eafb713cb41985/odrive_node/src/odrive_can_node.cpp#L174, I noticed that there is a 1-second wait process, and I believe this might be the cause of the delay.
Is the 1-second wait here because it takes 1 second for the response to be correct? Would it be difficult to change the axis_state without waiting for 1 second?
Best regards

This is due to a limitation with the protocol which boils down to the fact that the status+error response ("heartbeat") doesn't echo a sequence number or similar. As a consequence, we don't know if a given status+error response was emitted before or after the request went through, and the ROS node could be returning the wrong result if it doesn't ignore too early responses. Note that the request could be delayed due to bus congestion, while the heartbeat is normally sent every 100ms.
The one second delay is a workaround for this, since it's unlikely that the request would be delayed by one second or more. You can probably reduce this and still get reliable results. However to fix it properly, a protocol change is required which we didn't get to yet. I'll make a note to revisit this.

Thank you for your response.
I now have a better understanding of the current situation, and I look forward to seeing improvements in this matter.


Don't accept .pdf websites from Wikidata

https://lux-front-dev.collections.yale.edu/view/text/4a9d1cd9-ba2f-4916-ad46-661ca06113ec
has a garbage website link thanks to WD. check in mapper and don't accept if ends in .pdf

rewrite to be more robust


Add secret Directory Sync button to demo.workos.com

Totally right @mjyoung was on autopilot. I'll fix it up :)


⚠ Bofrost.be has degraded performance

In ebced62, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2629 ms

Resolved: Bofrost.be performance has improved in 47df067.


object key order can change between executions

I have been trying to track down an issue in our usage of Goja that is causing the order of keys in an object to change between executions of a script.
I have been trying to create a reproducible but have failed to isolate the issue in a small enough script and go example to provide something that could highlight the issue.
I am opening the issue in hopes there may be some idea of what might be causing the issue we are seeing?
Below I will provide a little snippet of code that shows a very simplified example of the code we are using that is exhibiting the issue, but just to be clear this code snippet doesn't reproduce it.
The below snippet is trying to replicate the following logic: we are parsing some JSON we load from an external file, we then are trying to create an object that contains the "remaining" fields that weren't known about ahead of time and print the keys, but in our more complex version of this the order of the keys printed from the line console.log(JSON.stringify(Object.keys(remaining))); changes most executions, just not in this simplified example.
package main

import (
	"github.com/dop251/goja"
	"github.com/dop251/goja_nodejs/console"
	"github.com/dop251/goja_nodejs/require"
)

const js = `
const rawJSON = ` + "`" + `{ "id": "test123", "email"<EMAIL_ADDRESS>"first_name": "Trystan", "last_name": "Crooks", "age": 32, "postal_code": 94110, "metadata": { "allergies": "none", "color": "red", "height": 182, "weight": 77, "is_smoking": true }}` + "`" + `;

const json = JSON.parse(rawJSON);

handleObject(["id", "email", "first_name", "last_name", "age", "postal_code", "metadata"], json);

function handleObject(fieldsToKeep, obj) {
	let remaining = { ...obj };

	for (const field of fieldsToKeep) {
		let subValue = remaining[field];
		delete remaining[field];

		if (typeof subValue === "object") {
			handleObject(["allergies"], subValue);
		}

		console.log(field, subValue);
	}

	console.log(JSON.stringify(Object.keys(remaining)));
}
`

func main() {
	registry := new(require.Registry)
	vm := goja.New()
	registry.Enable(vm)
	console.Enable(vm)

	_, err := vm.RunString(js)
	if err != nil {
		panic(err)
	}
}

"Native" objects (i.e. created with NewObject() or returned by built-in methods) should maintain the order as per ECMAScript specification, however wrapped Go maps (i.e. created with ToValue(map[string]any{.... }) or passed to an exposed JS functions) do not, because they just wrap a Go value. Most likely this is what you're seeing. A solution here is to manually copy the Go map into a JS object, or wrap it using a DynamicObject implementation that maintains consistent property order.

Thanks for the response, I suspected originally it may be because the type was backed by a Go map but we are not passing a go type to this code except for the string that represents the raw JSON to be parsed as shown in the example above.
I then went hunting for where maybe some level of JS object manipulation might have fallen back on Go maps in the Goja code base but haven't made much progress there.
Will see if some of the workarounds you suggested help us or try and get the reproducible together

Thanks for the pointers, got to the bottom of it and it was a call site that was moving the object out to a go function and then back again that caused the order to change. Just an innocuous little call that got looked over.
Anyway thanks again and closing this now


github 101 - copilot.pdf is broken

github 101 - copilot.pdf

New presentation uploaded and tested.  Thank you for the heads up.


Update vendored Molinillo to 0.5.6

See https://github.com/CocoaPods/Molinillo/releases/0.5.6
closes #5359
closes #5362

@bundlerbot r+


Changing the admin language selection logic (relates to #1292)

I don't have an extensivelly large settings.LANGUAGES ready to test it right now, hope that someone else can.

Learning something new every day, I just used the Django's default LANGUAGES list and things seems 3 to 4 times faster.
Waiting for someone to confirm.

Forget it, I was checking things wrong. This does not speed things up at all.
Sorry for the noise


Style/StringLiterals now works with non-ascii strings

Fixes #3017 and #3056.
There were a couple of failing tests which I didn't fix because I don't think the functionality they test makes a lot of sense, but I'm probably missing something.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it)
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

The solution looks very elegant, and since the tests pass, I bet it's correct. But I still find it a bit hard to understand. Could you add something at the place I've indicated?

:+1: Looks good!

@jonas054 Cool, thanks for reviewing! Rebased on top of latest master.

The changes look good to me as well, but this will have to be rebased one more time.

Rebased!


Table Row borders are not appearing.

Code:

Table:

Please fill the issue template fully and don't use screenshots to share code.
As I see, markup is not fully defined:
  <Table basic='very'>
    <Table.Body>
      <Table.Row>
        <Table.Cell>John</Table.Cell>
      </Table.Row>
      <Table.Row>
        <Table.Cell>Jill</Table.Cell> /* Table.Cell is required */
      </Table.Row>
    </Table.Body>
  </Table>

Are they visible there?
https://react.semantic-ui.com/maximize/table-example-very-basic/

They are

So, it means that it's an issue on your side 🤔
Please provide a minimal repro on CodeSandbox, you can use this one as reference:
https://codesandbox.io/s/rmx8v67724?module=/example.js So I will be able to clarify the issue, however it's definitely a CSS problem.

We don't have a repro, closing for housekeeping.


Doc: Add documentation for SFrame.read_csv() nrows_to_infer

Fixes https://github.com/apple/turicreate/issues/1367.

@TobyRoseman: review ping.

@tapaswenipathak - thanks for the ping. Also thanks for the helpful pull request and addressing my feedback.


migrate to createRoot #717

rebased and Now I'm not looking any warning @johnaohara

Merged.
Thanks for your contribution !

Reverted


The following assertion was thrown while handling a gesture: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 829 pos 12: '_hold == null': is not true.

Steps to reproduce

In a NotificationListener, set a onNotification like sample code.
Run code.
Scroll, and Scroll again before the first scroll ends.

Expected results
Scroller may be faster.
Actual results
Scroll stopped and the error causes.
Code sample
Code sample
NotificationListener<ScrollNotification> {
onNotification: (ScrollNotification notification) {
                    if (notification is ScrollStartNotification) {
                      isScrolling = true;
                    }
                    if (notification.context != null && isScrolling) {
                      if (notification.metrics.axis == Axis.vertical) {
                        ScrollController scroller =
                            timetableProvider.tableVertScrollController!;
                        if (!scroller.position.isScrollingNotifier.value) {
                          var currentScrollPosition = scroller.position.pixels;

                          timetableProvider.setScroller(scroller, timeHeight,
                              (currentScrollPosition / timeHeight).round());
                          isScrolling = false;
                        }
                      }
                      if (notification.metrics.axis == Axis.horizontal) {
                        ScrollController scroller =
                            timetableProvider.tableHorScrollController!;
                        if (!scroller.position.isScrollingNotifier.value) {
                          var currentScrollPosition = scroller.position.pixels;

                          timetableProvider.setScroller(scroller, timeWidth,
                              (currentScrollPosition / timeWidth).round());
                          isScrolling = false;
                        }
                      }
                    }
                    return false;
                  },
  child: [Some ScrollView]
}

void setScroller(ScrollController controller, double timeLength, int mul) {
    double targetOffset = timeLength * mul;
    if (controller.offset != targetOffset) {
      if (controller.hasClients && controller.position.pixels != targetOffset) {
        controller.animateTo(
          targetOffset,
          duration: const Duration(milliseconds: 300),
          curve: Curves.easeInOut,
        );
        notifyListeners();
      }
    }
  }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
The following assertion was thrown while handling a gesture:
'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 829 pos 12: '_hold == null':
is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.yml

When the exception was thrown, this was the stack:
#2      ScrollableState._handleDragStart (package:flutter/src/widgets/scrollable.dart:829:12)
#3      DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:787:53)
#4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:344:24)
#5      DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:787:7)
#6      DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:754:5)
#7      DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:681:7)
#8      GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:282:12)
#9      GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:233:11)
#10     GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12)
#11     OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:444:13)
#12     DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:648:15)
#13     PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12)
#14     PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9)
#15     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:633:13)
#16     PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18)
#17     PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7)
#18     GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:495:19)
#19     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:475:22)
#20     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:425:11)
#21     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:420:7)
#22     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:383:5)
#23     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:330:7)
#24     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:299:9)
#25     _invoke1 (dart:ui/hooks.dart:328:13)
#26     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:442:7)
#27     _dispatchPointerDataPacket (dart:ui/hooks.dart:262:31)
(elided 2 frames from class _AssertionError)

Handler: "onStart"
Recognizer:
  HorizontalDragGestureRecognizer#19581
════════════════════════════════════════════════════════════════════════════════════════════════════

Another exception was thrown: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 834 pos 12: '_hold == null || _drag == null': is not true.
Another exception was thrown: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 834 pos 12: '_hold == null || _drag == null': is not true.
Another exception was thrown: 'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 840 pos 12: '_hold == null || _drag == null': is not true.

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.0, on macOS 14.5 23F79 darwin-arm64, locale en-KR)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.85.0)
[✓] Connected device (4 available)
[✓] Network resources

Closing this as a duplicate of https://github.com/flutter/flutter/issues/14452


feat: bundle ic-btc-adapter binary into dfx

Description
Updates the replica and adds the ic-btc-adapter to the dfx binary cache.
Fixes https://dfinity.atlassian.net/browse/SDK-351
How Has This Been Tested?
dfx cache delete && dfx cache install, then make sure the ic-btc-adapter binary exists in the cache directory and is executable.
Checklist:

[x] The title of this PR complies with Conventional Commits.
[ ] I have edited the CHANGELOG accordingly.
[x] I have made corresponding changes to the documentation.

Just as a reminder: #2111 added the ./scripts/update-replica.sh script. I think the adapter also would have to be added to that after merging


Make preview size listbox invisible when Sizing = Fixed

Fixed #1571. Make drop-down list invisible when Sizing = Fixed, and make it visible when Sizing = Responsive. And the pre-setting will be preserved.

I'm testing with Firefox 65.0.1 if that's of any help.

@ZhengCornell Now I have the opposite problem. If I create a project and set the Sizing to Responsive, it works until I reload the page. When the project reloads, it won't show the dropdown even though it should.

@ZhengCornell I have one last bug for you: If I switch to Responsive and set the size to be either tablet or monitor, and then switch from Response to Fixed, the size doesn't reset back to phone.


Everything Bagel's next steps

tl;dr
Everything Bagel's spiritual home is now https://github.com/treeverse/lakeFS-samples, from where it is more discoverable and usable.
I would now like to tidy up the existing Everything Bagel code in lakeFS repo and looking for opinions on the approach to take.
Current State
lakeFS-samples
lakeFS-samples was updated recently to be built around a single Docker Compose with a library of notebooks for the user to explore.

Some examples don't easily fit in this model and are included in the repository standalone. An example of this is Airflow, which extends the Docker Compose with additional containers:

More complex deployments that would take too long to migrate have just been copied here and left unchanged ("lift and shift")
The background and discussion for this is here and on Slack.
Everything Bagel
https://github.com/treeverse/lakeFS/blob/master/deployments/compose/

Everything Bagel includes things not present in lakeFS-samples:

Trino
Catalog (Hive)
dbt
[Standalone spark containers, but Spark is included in the Jupyter notebook]

👉 However, these are not referenced in any docs or samples. One Everything Bagel blog (41 page views in 90 days) covers Trino but doesn't clearly send users to EB.
The docs cover these tools (e.g. Trino, dbt) but don't reference or link to Everything Bagel.
Retaining Everything Bagel, or porting these containers, for the sake of it seems redundant. How will users know to use them?
Proposal
The driving aim of all this is to consolidate our demo code into one place so that users can easily find and run it.
Therefore, I suggest that we do the following (split into parts to avoid blocking/big bang):

Stage 1 - remove Everything Bagel

Update both EB blogs (1 2) to point users to https://github.com/treeverse/lakeFS-samples
rm -rf ./deployments/compose/*
Update ./deployments/compose/README.md to point users to https://github.com/treeverse/lakeFS-samples

Stage 2 - build new content

Add Trino content to lakeFS-samples, update our Trino integration doc directly to reference it, update existing EB blog
Add dbt content to lakeFS-samples, update our dbt integration doc directly to reference it, update existing EB blog

The risk of doing this in two stages is minimal given that very few people will find their way to the existing Everything Bagel for dbt and Trino since it's not referenced anywhere other than in passing in the EB blog (41 page views in the last 90 days)
Request for Comments 👂🏻
Paging @treeverse/developers for background context that I may have missed, opinions, comments :)
Especially @nopcoder who created the original Everything Bagel, @guy-har who added dbt, and @arielshaqed who added Airflow.

Zero feedback on this when shared on Slack so going ahead with my proposal as planned.


jQuery warning at play store console

I get this warning in my app.
Your app contains one or more libraries with known security issues. Please see this Google Help Center article for details.
Vulnerable JavaScript libraries:
Name	Version	Known issues	Identified files
jquery	3.1.1	SNYK-JS-JQUERY-174006	assets/js/jquery-3.1.1.min.js
jQuery version inside this project is 3.1.1 could anyone update it to a newer version?

[https://github.com/FolioReader/FolioReader-Android/pull/417](Check this link)

@KishanViramgama https://github.com/FolioReader/FolioReader-Android/tree/0.5.4 I'm using this and in this version it is still 3.1.1

Yes new version not available.. but you have use FolioReader module.

Yes new version not available.. but you have use FolioReader module.

Canyou please, release a new version with updated jQuery as gradle library?

Yes new version not available.. but you have use FolioReader module.

Hi @KishanViramgama can you please elaborate what do you mean by using FolioReader module?
Do we need to change the below line in root build.gradle?
   implementation "com.folioreader:folioreader:0.5.4"

Download  FolioReader-Android code and Import module FolioReader
Like this :-  implementation project(path: ':folioreader') @saptha

Thanks @KishanViramgama I solved it now.

@saptha Have your issue fixed ?

My App got suspended from play store. But I'm not sure if this issue causes to suspend the App.
Please let me know if any other one facing same issue and their app got suspended from Play store.
I'm not sure if folio reader causes App suspension or any other one. I'm just confirming with any other one who is facing same issue.

@saptha Have your issue fixed ?

yes @mtamailindia my issue got fixed. I had to uninstall epub_kitty and create a flutter channel using Folioreader android plugin.


[BugFix] Only show current db when using show materialized view with where expr

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0


Added MD to cmdlet references

OPS Build status updates of commit ae89e71:
:clock10: Preparing: average preparing time is 1 min(s) 13 sec(s)


palemoon: 32.1.1 -> 32.2.0

Description of changes

Changelog & Notes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This should be backported to 22.11 since python2 is still usable there. Afterwards, we should drop palemoon and redirect users to the palemoon-bin package.


[MRG] Fix PDB reader + add argument to toggle proximity bonding

What does this implement/fix? Explain your changes.
Disclaimer - this is still "work-in-progress".
This aims to fix issues with parsing PDB files by RDKit, such as:

[x] covalent bonding with metals
[x] multivalent Hs (bonded to many heavy atoms via ConnectTheDots)
[x] covalent bonds with HOH residues
[x] add an option to disable automated bonding, if the molecule was once sanitized, but for some reasons gets bad bonds again, or has pregenerated bonding

Any other comments?
These are the most common issues that we found on PDBBind refined set.
Do you know of any other common issues I could add to that TODO?
I'm still struggling to make the proximityBonding parameter work as it should (disable ConnectTheDots). I think I've missed some place and it gets ignored, any ideas?
My conda went crazy, I think everything is OK with the parameter and it works.

I've done some extra testing on PDBbind refined set v2016 (4057 protein-ligand complexes). Current stable 2017.09.1 sanitizes 3459 and this PR sanitizes 3776 successfully, which is quite good improvement given the simplicity of addition.
First, tests suggest that all other problems can be resolved by templates of PDB residues (will discuss this in other PR/Issue).

This PR is ready for review. Here are some final stats on PDBbind database v2016. I think it's remarkable improvement, I was not expecting such improvement. Ping @greglandrum
I still need to validate in depth those proteins that fail. The sanitization of a protein does not guarantee that the residues have reasonable bonding, but a fix to that issue is yet to come and is out of scope of this PR.

Version
Refined Set
Sanitized Pockets - Refined Set
Sanitized Proteins - Refined Set
General Set
Sanitized Pockets - General Set
Sanitized Proteins - General Set

PR
4057
4031
3895
13283
13222
12833

2017.09.1
4057
3459
2087
13283
11302
6984

improvement
-
572
1808
-
1920
5849

I have found yet another easy fix - unbinding the HOH residues from protein. Here are updated results on PDBbind.

Version
Refined Set
Sanitized Pockets - Refined Set
Sanitized Proteins - Refined Set
General Set
Sanitized Pockets - General Set
Sanitized Proteins - General Set

PR
4057
4051
3995
13283
13259
13047

2017.09.1
4057
3459
2087
13283
11302
6984

improvement
-
592
1908
-
1957
6063

It would be nice to merge #1280 as well

I checked how these changes affect performance. I compared this version to the current release on 157 protein structures from the PDBbind v2016 core set (i.e. the structures I was able to load with the current release). The new version is 2% slower on average. I thinks this difference is insignificant when we think of the benefits.

@mwojcikowski , @marta-sd : thanks for the effort here!
Now that these are ready to be reviewed, should I start with #1280 and then do this one or would you prefer that I start here?

@greglandrum I have fixed all raised issues. Additionally I've improved bonding removal from metals so that the metalorganic ligands are fine + additional tests. The "inter-residue" bonds are also removed from noble gasses and halogen ions.

Also PDBbind v2016 general set stats went up from 13047 to 13082 proteins (my rdkit build includes #1643 since there are proteins larger than 65k atoms).

Thanks @mwojcikowski !


Signing in using phone auth returns user: null

Bug report
I am trying to "Using OTP as a passwordless sign-in mechanism", as follows:
const { error } = await supabase.auth.signIn({
phone,
});
const { user, session, error } = await supabase.auth.verifyOTP({
phone,
token: otp,
});
however the session returned has user: null.
supabase.auth.onAuthStateChange callback, which is registered, is also called after sign in but supabase.auth.user() is returning null
My app is working correctly when I try to signup/signin using email, password

hi @meghaboggaram, let me know if this issue is still a blocker for you, else i'll close this one for now. Feel free to re-open it though!


How to train the model on our own dataset?

Hi, I'm also thinking about this.  Have you solved it?

You can follow the CycleGAN instructions  for training your models.


[WIP] Deduce visits from views (#891)

Hi,
I marked this as WIP to allow you to play around with it, and see how it works, before we settle on a way to implement it.
Basically it discards the entire visits table, and uses the views to deduce views.
Views are grouped by Ip, user-agent string and the current date. Meaning one user can create multiple views by jumping IPs, using different browsers or visiting on different days.
I believe the existing setup counts visits the same way, but simply relies on what's in the visits table. which can be manipulated by manually removing the Laravel Session, IE. by going Incognito or clearing cookies.
Mainly, this proves to an advantage for users who use Laravel as an API with a separate frontend. See #891

I'll fix the tests and make it behave as expected across scopes, if this is something you're interested in bringing to Canvas.

Thanks for submitting this @JapSeyz! I'll take a look as soon as I can. Currently moving into a new house this week, so might be just a minute.

No rush! Focus on you first. This is free OSS work, nobody dies if it takes a week or two

@JapSeyz I appreciate the work that went into this. After reviewing it more, I don't think I want to go this route. Again, thanks for submitting it, I'd be more than happy to look at other PRs if you have other ideas!

@JapSeyz I appreciate the work that went into this. After reviewing it more, I don't think I want to go this route. Again, thanks for submitting it, I'd be more than happy to look at other PRs if you have other ideas!


[WIP] Move current_pods/deployments to instance attributes

These were previously class_attributes but now that WorkerManagement is a class these can be initialized when that class is instantiated

Going to move this back to WIP until we figure out https://github.com/ManageIQ/manageiq/pull/21525#discussion_r740279239

Okay so I think the class-level list of pods/deployments is needed so that it can be shared with the rest of the MiqServer instances on podified.  There is an issue however with each miq_server instance appearing to start its own kube_monitor threads which each clear then set the global cache on startup leaving it in an undefined state across threads:
Thread A clears current_pods
Thread A calls client.get_pods and sets current_pods
Thread B clears current_pods
Thread A accesses current_pods
Thread B calls client.get_pods and sets current_pods

The solution is to have only the "master" miq_server instance set the global state.  I'll work on fixing this in a different PR
cc @jrafanie @Fryguy


Plain test and binary endpoints not working

This change 51c53e301 hides the concrete type of the EnvironmentRepository so it doesn't expose the fact that it is a SearchPathLocator and consequently a ResourceRepository is never created, and so the "raw resources" endpoints are not created either. We'll have to ask @spencergibb why he made that change because it is clearly deliberate.

raw resources  can be  refresh?

Fixed in b827877 (1.1 didn't appear to be tested so that's fixed in 512e58).


Don't send webp to CriOS when there is no accept:image/webp

The latest Chrome on iOS, based on WKWebView, cannot render webp images, but mod_pagespeed sends them.
See http://blog.chromium.org/2016/01/a-faster-more-stable-chrome-on-ios.html
I confirmed that this browser also does not send accept:image/webp.  If, in the future, webp is re-enabled in CriOS, it will likely send accept:image/webp again.
This is a workaround:
SetEnvIf User-Agent CriOS mps_disable_webp
RequestHeader set ModPagespeedFilters -convert_jpeg_to_webp env=mps_disable_webp

Note: a similar issue was found in https://github.com/pagespeed/mod_pagespeed/issues/969

At this point maybe we should switch to a simple "send webp if and only if we get accept:webp"?

I agree with that, but that's a larger change (assuming we still want to send webp to Android 4.0) and want to do that in a follow-up.

Android browser supports WebP since 4.0 but doesn't have WebP header. It
still has ~11% market share totally in mobile and tablet [1]. It's not
clear what is the portion of 4.0+ in this 11%, however most likely it's not
trivial.
[1]
https://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=1
On Thu, Jan 28, 2016 at 10:41 AM, Joshua Marantz<EMAIL_ADDRESS>wrote:

I agree with that, but that's a larger change (assuming we still want to
send webp to Android 4.0) and want to do that in a follow-up.
—
Reply to this email directly or view it on GitHub
https://github.com/pagespeed/mod_pagespeed/issues/1256#issuecomment-176241170
.

It turns out we need to separately disable webp-lossless and webp-animated, so the full workaround is:
SetEnvIf User-Agent CriOS mps_disable_webp
RequestHeader set ModPagespeedFilters -convert_jpeg_to_webp,-convert_to_webp_lossless,-convert_to_webp_animated env=mps_disable_webp

More detailed workaround information for nginx and apache.  None of this will be needed once we have https://github.com/pagespeed/mod_pagespeed/commit/23947d0006005c5e3aa7539d81b7819fdb454e4c in a release.
Apache & mod_pagespeed 1.10:
# Temporary workaround for
# https://github.com/pagespeed/mod_pagespeed/issues/1256
SetEnvIf User-Agent CriOS mps_disable_webp
RequestHeader set ModPagespeedFilters -convert_jpeg_to_webp,-convert_to_webp_lossless,-convert_to_webp_animated env=mps_disable_webp
Nginx & ngx_pagespeed 1.10:
http {
pagespeed ProcessScriptVariables on;
server {
set $disable_filters "";
if ($http_user_agent ~ CriOS) {
set $disable_filters "convert_jpeg_to_webp,convert_to_webp_lossless,convert_to_webp_animated";
}
pagespeed DisableFilters "$disable_filters";
}
}
In 1.9, there is no convert_to_webp_animated filter, and the nginx variable support is not present in PageSpeed so you have to completely disable webp until we get you a patch.
Apache & mod_pagespeed 1.9:
# Temporary workaround for
# https://github.com/pagespeed/mod_pagespeed/issues/1256
SetEnvIf User-Agent CriOS mps_disable_webp
RequestHeader set ModPagespeedFilters -convert_jpeg_to_webp,-convert_to_webp_lossless env=mps_disable_webp
Nginx & ngx_pagespeed 1.9:
http {
pagespeed DisableFilters "convert_jpeg_to_webp,convert_to_webp_lossless";
}


implemented responsive navbar component #21

Description
Implemented feature responsive navbar component  as discussed in issue #13.
Changes

Modified App component.
Created Navbar component.

Linked Issue
Closes #13
Testing

Verified that the changes work.

@BamaCharanChhandogi  are we getting conflicts because issue is not assigned to me ?

You have to just pull the latest code, then you can raise PR.

You have to just pull the latest code, and then you can raise PR. because your code and updated code are different that's why facing merge conflicts.

You have to just pull the latest code, and then you can raise PR. because your code and updated code are different that's why facing merge conflicts

okay @BamaCharanChhandogi  ,I will create new PR


cassandra install instructions (version 3) invalid

Cassandra installation instructions are invalid.  Cassandra sources moved to a new location last year see https://stackoverflow.com/questions/76259969/cassandra-3-11-x-downloads-are-missing
For version 3 install (note you should probably provide both 3 and 4 instructions) I used:
echo "deb http://archive.apache.org/dist/cassandra/debian 311x main" | sudo tee -a /etc/apt/sources.list.d/cassandra.sources.list
apt update

Rod
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5212a093-4b1e-b51b-c94a-d1612669bf90
Version Independent ID: 52c6c519-447f-192f-4abd-2a3b2c45437b
Content: Quickstart - Create Azure Managed Instance for Apache Cassandra cluster from the Azure portal
Content Source: articles/managed-instance-apache-cassandra/create-cluster-portal.md
Service: managed-instance-apache-cassandra
GitHub Login: @TheovanKraay
Microsoft Alias: thvankra

@rodneytamblyn
Thanks for your feedback! We will investigate and update as appropriate.
I've delegated this to @TheovanKraay, a content author, to review and share their valuable insights.

fixed by PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/240520

Thanks @rodneytamblyn, are you happy to close this one?

@RamanathanChinnappan-MSFT or @seesharprun - can you please help with closing this issue?

#Please-close


Can you fix the WIN wallet? You want to make money and not do your job right?

Can you fix the WIN wallet? You want to make money and not do your job right?

This is the Windows wallet I fixed http://pepenet.cobrapool.com/FEPC_100_Windows

谢谢
linpengishero @.***> 于2023年9月18日周一 11:34写道：

This is the Windows wallet I fixed
http://pepenet.cobrapool.com/FEPC_100_Windows
—
Reply to this email directly, view it on GitHub
https://github.com/FEPCoin/FEPC/issues/5#issuecomment-1722708437, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AYUI7BSIAQLXL3A4TDNM7SDX266K3ANCNFSM6AAAAAA355E66I
.
You are receiving this because you authored the thread.Message ID:
@.***>


Fuzzy matching for intellisense

VSCode Version: 1.7 Insider
OS Version: OS X 10.11.6

I've wanted this too.

This is the first bad thing i've noticed during the switch from sublime/other modern editor
Actually, matching is not completely fuzzy, so take it into account :+1:

Since @octref doesn't really state what we wants and since I have made some improvements in that area for #14583 and #14446 I take the freedom to close this issue with another attached gif. This is what you see on master

@jrieken Thanks a lot. This looks good. I'll try it out and report issue with more description next time.


Complete mnm assignment

I just realized Seth told us a slight factual inaccuracy, all the records returned by the mix and match API are in fact true mismatches. I'm going to fix this and then push the changes.

All's generally looking good on my end, @funblaster22. Some changes:

I renamed the notebook so it's full snake case
You were defining f-strings with single quotes, and per Black/Ruff that are the formatting standards these should be double quotes with single quoted keys
I get importing NAN from numpy, but just from what I've seen it's usual that people directly use np.NAN (a bit of documentation for which definition of null is being used)
The generated CSV wasn't valid as you forgot to do index=False on pd.to_csv

We thus had a blank column name with the index, which isn't valid for Mismatch Finder
I just reloaded it and saved it again :)

I also removed the cell outputs so it's not super long on GitHub.
Another quick check: the file name is first-4327..., but the current length is ~315? You reran it and it got smaller?
Happy to merge later on. Let's discuss really quick in the meeting :blush:

Very much applaud the effort going into all this, @funblaster22 :clap: Let me know later what the status of the full run is. Again, very happy to try on my end to run it through :)

@andrewtavis-wmde it's done! I made & verified the mismatch csv.

Thanks @funblaster22! Looking forward to the review :)


delete dspace tags

too many tags
new tags start from 0.2.4, bumping from v0.2.3 in the baryonics-invenio repo

done


Upgrade vendored libs

Upgrade all the things!
(Except Go.  Wishing to avoid the issue Docker hit where it rejects old Docker clients)
Each library was upgraded to the latest release, the latest commit, or some other appropriate commit.
See commit message for details on which versions were selected.

Good job @bboreham - I like how you have recorded the versions in the commit message.


v1beta1 KfDef

Bootstrapping KfDef for v1beta1.
Relates to kubeflow/kubeflow#4002

This change is

Thanks
LGTM
@yanniszark @kkasravi comments?

please help and take a look at condition types and reasons, I try to fit the new status into our new semantics.

Will it be compatible with https://github.com/kubeflow/kubeflow/blob/v0.6-branch/bootstrap/config/kfctl_gcp_iap.0.6.2.yaml ?

no, this is the new version.  we will make kfctl to be backward compatible with v1alpha1 KfDef, tho.

there is a merged doc on conditions and ApplicationStatusCondition

@kkasravi I've updated the conditions part according to the link, could you take a second pass?

thanks @gabrielwen
/lgtm

@yanniszark will wait for your review.  please approve this when you think it looks good.

@yanniszark @kkasravi Can you please take another look?
@gabrielwen What are the remaining issues to be resolved? It looks like we are waiting on @kkasravi to answer the question about why value is StringOrArray?
@yanniszark @kkasravi Can you please prioritize reviewing this? Its critical we get the v1beta1 API finalized so we can get the implementation done in time for 0.7.

Great discussion !
I've nothing to add to the comments.
Just a small question, is there a doc or issue tracking the steps to be done make kfctl backwards compatible?

Great discussion !
I've nothing to add to the comments.
Just a small question, is there a doc or issue tracking the steps to be done make kfctl backwards compatible?

kubeflow/kubeflow#4002 is the tracking issue but it doesn't really have the steps to make it compatible.  After this PR we need another one to unify both paths (v1alpha1/v1beta1)

@yanniszark @kkasravi Can you please take another look?
@gabrielwen What are the remaining issues to be resolved? It looks like we are waiting on @kkasravi to answer the question about why value is StringOrArray?
@yanniszark @kkasravi Can you please prioritize reviewing this? Its critical we get the v1beta1 API finalized so we can get the implementation done in time for 0.7.

yes, I think that is the only question.

@swiftdiaries I think to make kfctl backwards compatible we just need to write a conversion function to convert v1alpha1 specs to v1beta1 specs; and then we can just run that when kfctl runs.

@kkasravi to answer the question about why value is StringOrArray?

there are use cases where an array would be valuable.
If we allow lists to be passed to kf apps then params.env is not the best way to pass a list.
This approach (string or array-of-string) is used by tektoncd in their parameter passing implementation. We should try and have well typed information for app params

Would it make sense to change Plugin to include data where this info can be
embedded?

@kkasravi the Spec of a plugin is already free-form data.
The author of a Plugin can freely choose the correct structure that fits their plugin, including the structure you mentioned.
Why would we force a certain structure upon all plugins beforehand?

there are use cases where an array would be valuable.
If we allow lists to be passed to kf apps then params.env is not the best way to pass a list.

Has such a use-case come up though? Is there a Kubeflow application that needs a list?
I'm hesitant about this because if we start conservatively then AFAIK we can make it StringOrArray without breaking backwards compatibility.
However, if we make it StringOrArray from the start, then we won't be able to take it back without breaking compatibility.
The last outstanding issue is Object vs RawExtension (https://github.com/kubeflow/kfctl/pull/29#discussion_r323288805).

Responding to @kkasravi's question about how users would modify the DM templates. I think this is working as intended. If there are specific parameters we want to expose (e.g. workloadIdentity, pipelinepersistentstorage) the plugin owners can define an appropriate high level API.
I don't think we need to let users embed arbitrary json/YAML.
The underlying config files are DM config files. If users want to easily modify those and customize them in weird ways they can do that by copying that to an appropriate directory, modifying them, and running gcloud to create the GCP infra. They can  then just use kfctl to install Kubeflow on their existing cluster.

but could we do more in this area? My point is we already create an opinionated cluster:
2 machines with 8 vCPUs and 30 GB of memory, tpu's disabled, 0 gpus.
Just as we're providing device overlays that can be configured so that jobs run on accelerated hardware, can we provide hooks that vendors could utilize to meet customer requirements?

/hold
place hold until runtime.Object/runtime.RawExtension is resolved.

/hold cancel

@yanniszark @kkasravi could I have lgtm from both of you?

/lgtm

/lgtm
/approve
/hold
To give @yanniszark time to review

@yanniszark done, could you take a final look? :)

@gabrielwen thanks for all the great work.
/lgtm
One last concern I had, which is worth mentioning now:
AFAIK, we don't have a good story for providing secrets for securing applications.
eg we probably want to configure MySQL, OIDC clients, Minio etc with good random passwords and not default ones like we do now.
Are we confident that we'll be able to have a good story for this without needing a new version?
/cc @jlewi
@gabrielwen @jlewi that's all from my side, please remove the hold when you believe everything is ready.

@yanniszark We can extend SecretSource if need be to allow people alternative methods of referencing secrets.

/lgtm
/approve
/hold cancel


Explore use of Portable Software Instance (PSI)

Proposal to support Zowe install by Portable Software Instance(PSI) - research needed - software prereqs, use of build environment, automation, etc.....
Text from zlc email - Few  comments -

I have meeting today with Marna Walle to get some education on PSI - she a I spoke last year and - at the time - PSI was a z/OS 2.4 item and we (Zowe team) stayed with SMP/E. I have seen comments implying the capability has been rolled back to prior z/OS level
We need to be sensitive to the fact the build environment (Marist) is at z/OS 2.3 and therefore may need PTFs added to support PSI - they control the changes and help Zowe on a best effort basis - they are great to work with but changes need to be requested and coordinated
We need to understand how PSI can be automated in the CI/CD pipeline - I hear mention of REST APIs - I assume for driving the process programmatically
CI/CD pipeline team already spread thin - great to get help if possible - PSI work needs to be prioritized - I think the highest priority is to get to Linux Foundation Jenkins when technical issues sorted out  BUT I do not know what else is in the backlog - I recall some Ansible work too.

Hi Sujay and Bruce,
let me summarize the idea technically. Currently, there are two versions of Zowe distribution, convenience build, and SMP/E build. During the packaging of Zowe, SMP/E environment is created. This environment is the starting point for the PSI creation process. SMP/E location, a few additional variables, and z/OSMF workflows are fed to the z/OSMF using REST API. As a result of this call, z/OSMF generates a JCL. The JCL can be submitted and the result of the job is a PSI. I believe (and here I could be wrong) that the 2.3 z/OMSF version is sufficient for the PSI creation (please ask Marna to confirm that). We have now two approaches ready, the one with the REXX script and the other with the shell script. As far as I know, (and Jack can expand on this, as he is working with my team), the preferred way is to use the shell script, which will be part of the Jenkins CI/CD. What could be confusing is that we are working on it in the Cupids squad, not in the CI/CD squad.
So, to sum it up, we know how to do it, we have people to do it, I believe we have the environment ready as well. The only thing missing now is the agreement to do that.
Best Regards
Jan

The Cupids squad has a 30 minute scrum three times a week https://lists.openmainframeproject.org/g/zowe-dev/calendar - tomorrow Friday March 6th it is at 10am EST.  Would it make sense for us to chat about this then, or else the architecture call every week is Tuesday 9am EST https://lists.openmainframeproject.org/g/zowe-dev/viewevent?repeatid=21909&eventid=683269&calstart=2020-04-14 which is 1 hour long and this could be a good discussion to have with the wider squads who attend to work out any remaining issues that are holding this up from being completed ?

I have a day off tomorrow, so if you need more details from me, I would prefer to talk about it on Tuesday at the architecture call.

@nkocsis and @1000TurquoisePogs - could we please add Jan to the agenda of next Tuesday's architecture call.  I'll also try to invite someone from IBM who can present on PSI and help set the stage.