How to start controller with specified config file?

I've installed dealbot (built with git tag v0.0.40).
and downloaded dealbot-example.toml, and renamed to dealbot.tom, and changed its data dirs, and created those dirs.

Then when run according to README file:
dealbot controller --configpath ~/dealbot.toml
or
dealbot daemon --configpath dealbot.toml
both and got error:

FATAL	dealbot	dealbot/main.go:94	flag provided but not defined: -configpath

Then checked dealbot -h for help, and tried:
dealbot -c ~/dealbot.toml controller
and got error:

FATAL	dealbot	dealbot/main.go:94	Unable to create input source with context: inner error:
'Unable to load Yaml file '/home/eric/dealbot.toml': inner error:
'yaml: unmarshal errors:
line 1: cannot unmarshal !!seq into map[interface {}]interface {}'

content of dealbot.toml:
[controller]
listen = "localhost:8764"

[daemon]
listen        = "localhost:0"
data_dir      = "/mnt/star/data/filecoin/dealbot/dealbot"
node_data_dir = "/mnt/star/data/filecoin/dealbot/dealbot"
api           = "token:/ip4/<IP_ADDRESS>/tcp/1234/http"
wallet        = ""
workers       = 4

[client]
endpoint = "http://localhost:8764"

So, is the README.md out of date? Any help?
Thanks.

first issue ('--configpath' instead of '-c') is because go uses single '-''s even for full arguments ('-configpath')
second issue is that you'll need the non optional flags for the controller - you can dealbot controller -h to see them

The config file is one way, env vars are another, or passing directly in on command line are a third.

@willscott Thanks.

@willscott Thanks.
Regarding first issue, you mean I should use -c instead of --configpath?
I've tried 4 commands:
dealbot controller --configpath ~/dealbot.toml
dealbot --configpath ~/dealbot.toml controller

dealbot controller -c ~/dealbot.toml
dealbot -c ~/dealbot.toml controller

Only the last one can recognize the -c param
About the second issue, you mean all flags from https://github.com/filecoin-project/dealbot/blob/main/commands/flags.go#L229 are required?
Is there a working dealbot .toml example? Or a working env file example, or a  command line example ?
Thanks.

either
dealbot -c ~/dealbot.toml controller

or
dealbot -configpath ~/dealbot.toml controller

we run the controller through a kubernetes / helm setup. The env var setup we use is here

@willscott Thanks, I've check the source code & tried, and get below result:
Regarding the first issue, it seems only -c and --config works.
Regarding the second issue, toml is not supported anymore, though yaml is supported.
And I succeed to start controller via purely command line flags without config file.

So, the README file is quite out of date, maybe it need an update.


Unused component data in devtools won't be changed by event methods

Version
Vue: 2.5.13
Chrome: 62.0.3202.75
Vue-devtools: 3.1.7
Reproduction link
https://github.com/vuejs/vuex/tree/dev/examples/shopping-cart
Steps to reproduce
In App.vue file, i add some simple code, a button click method:
<template>

Shopping Cart Example

Products

    <product-list></product-list>

    <cart></cart>
    <button @click="handleClick">click me</button>

</template>

when you click the click me button, the App component's data in devtools won't change, the test value is still 1, but when you click the Refresh button, it will change to 2.
But if you use test data in this component, like adding a
{{ test }}
 or watch the test value, the devtools will change correctly.
What is expected?
component's data will change to new value
What is actually happening?
component's data is still old value
Others
At first, i think it seems to be a devtool's bug, but i add some breakpoint in source code, i found the problem was in vue.js source code.
I add breakpoint in: https://github.com/vuejs/vue/blob/e274c96881f8b14486587e93f404be489454d781/src/core/observer/scheduler.js#L88-L90
But when i click the button, devtools.emit('flush') was not paused, it's weird.

This may be because Vue doesn't register any dependency to test because it is never used in any template/render function/computed property/vuex getter, so Vue doesn't keep track of its state.

@Akryum
Thanks for your answer:)
But i still have some questions. If you add another data value such as test2, add
{{test2}}
 in template, add this.test2++ in handleClick method, then click the button.
<template>

Shopping Cart Example

Products

    <product-list></product-list>

    <cart></cart>
    <button @click="handleClick">click me</button>

{{test2}}

</template>

As we know, test2 will change value. But the test will also change value, in Devtools.
It makes me confused. If Vue doesn't keep track of its state, test should still be 1.

This is because the devtool fetches the whole component state when it is refreshed.

@Akryum Thanks :)


[MPWG- design task] MicroProfile Guest Banner

We need this so that when printed shirts, swag happens, the guests are included into 1 category making it scalable for print and usage beyond the year the guest might be invited, as renewals are per year.

this belongs to https://github.com/eclipse/microprofile-marketing/issues/365


Update info.description

Purpose:

documentation

What this PR does / why we need it:
Updates info.description with:

New Commonalities template for User identification
Add section on multi-SIM scenario handling

Which issue(s) this PR fixes:

Fixes #None
But helps with #212 and #222
Special notes for reviewers:
Will need to revisit once multi-SIM scenario handling is standardised
Changelog input
 release-note
 - Update info.description section for user identification and multi-SIM scenario handling

Additional documentation
None

I updated all YAMLs with text on multi-SIM scenario handling, and also the "identifying the device from the token" text for the device roaming API.
I had a question on identifying the device for the subscription APIs. Currently device is a required parameter of the Subscription Request. So does this mean that subscriptions can only be created with a 2-legged token? Or should device actually be optional?


FrameTimingMetric benchmarks fail when startupMode is set to StartupMode.COLD

Component used: androidx.benchmark:benchmark-macro-junit4
Version used: 1.2.4
Devices/Android versions reproduced on: Pixel 6 Pro Android 14
I have setup benchmark module more than a year ago and everything was working fine back then. I haven't been running or checking benchmarks since then, because there were no high prio performance issues. I have however, been updating library versions on constant basis, including macrobenchmark and other testing libraries.
Now, I decided to come back to this and update the user flows, benchmark current code and generate new baseline profiles. But my tests started to fail. Specifically, FrameTimingMetric with StartupMode.COLD started to fail at the measureBlock. Leaving startupMode=null makes tests run finally, but I would rather prefer to have app killed and restarted between iterations to be able to measure across multiple instances of the app.
The error I get is all about UiAutomator not being able to find any object by resId. Here are some details in the SO question I submitted earlier https://stackoverflow.com/q/78591545/6272369
I'm not allowed to share my project, but this issue is reproducible in current project of macrobenchmark codelab https://github.com/android/codelab-android-performance/tree/end
There are however, compilation errors that needs to be fixed and StartupMode.COLD needs to be added first before running the benchmark.
What can be done on my side to be able to run FrameTimingMetric benchmarks with StartupMode.COLD?
P.S. I would actually also like to ask you to go through codelab https://developer.android.com/codelabs/android-macrobenchmark-inspect and update or filling missing steps. Just following the steps in the codelab is not enough to be able to run the benchmark. There seems to be missing steps or instructions when starting from the main branch. And end branch code doesn't match with what is described in the codelab. For example, codelab includes StartupMode.COLD at the step #10, but it is not there when checking out end branch code.

If StartupMode.COLD is used, the app process is killed between the
execution of setupBlock and measureBlock to allow for app preparation
without starting the process.
If you need the process to remain active, use
StartupMode.WARM, which restarts activities without restarting the process, or
set startupMode to null and call killProcess() within the setupBlock.
You can subscribe to b/278214396 to get more updates about this in the future.
Thank you for reporting this! We added information about this to DAC as well :)


Python 3.12 wheels on PyPI (and perhaps a new release?)

Component
PyDIP.
Describe the problem that this feature would solve
Following the release of Python 3.12, it would be appreciated if you could provide wheels on PyPI for that version of Python, either for the previous (3.4.1) diplib release, or for a new one.  Thanks!
Describe your suggested solution to the problem
New wheels.
Additional context

Yes, you are right, we should have added 3.12 to the list before making the release.
I'll try to get this done soon(ish).

There's Python 3.12 wheels available now for all supported platforms.

Thanks for the extremely fast reply!


feat: Support for the Transform section

Fixes https://github.com/cdklabs/decdk/issues/278

I assume this change is only to support transforms declared at template level?

Yes. What else are you thinking about? The Fn::Transform intrinsic function?

Yes. What else are you thinking about? The Fn::Transform intrinsic function?

Yea I think the issue was meant to cover that as well. But we can have another issue to track that.


luci-mod-network: invalid dnsmasq instance written to config

Static leases are saved with an invalid dnsmasq instance setting. The instance is saved by index, not by name, and does not end up in the resultiing dnsmasq config file.
Steps to reproduce:

Go to network -> DHCP and DNS and create a second dnsmasq instance
Create a static lease and choose one of the dnsmasq instances, rather than leaving it unspecified/
Save and note the proposed config has instance '0', not the name

config host
	option name 'testmac'
	list mac '99:88:77:66:55:44'
	option instance '0'

Apply and note that the static lease is not in the dnsmasq config file.

Actual behavior:
1.Selected instance is referenced by number, which does not work.
Expected behavior:
1.Selected instance is referenced by name, which does work.
Additional Information:
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='23.05.2'
DISTRIB_REVISION='r23630-842932a63d'
DISTRIB_TARGET='mvebu/cortexa53'
DISTRIB_ARCH='aarch64_cortex-a53'
DISTRIB_DESCRIPTION='OpenWrt 23.05.2 r23630-842932a63d'
DISTRIB_TAINTS=''

Would you be able to test 23.05.3? It sounds like this was fixed with https://github.com/openwrt/luci/pull/6579 and cherry-picked to 23.05 with https://github.com/openwrt/luci/commit/26e67f5ef88dbe114cded88d88ec557ebf0c25ea, which is after the 23.05.2 release but is included in 23.05.3.

That PR does look relevant, but I tried 23.05.3 and it seems unchanged. I also tried adding a new dnsmasq instance with the new version but static leases are still being assigned by index; the generated commands for a static lease were
uci del dhcp.cfg34fe63.mac
uci add_list dhcp.cfg34fe63.mac='99:88:77:66:55:44'
uci set dhcp.cfg34fe63.instance='2'

and the lease still doesn't end up in the generated dnsmasq config.

I've tried now with 23.0.5 and I don't see any change unfortunately.

Should be available in the repo tomorrow.

Thanks. I upgraded luci-mod-network:
root@router:~# opkg upgrade luci-mod-network
Upgrading luci-mod-network on root from git-24.111.76511-ff6b275 to git-24.205.48215-4f80a61...
Downloading https://downloads.openwrt.org/releases/23.05.4/packages/aarch64_cortex-a53/luci/luci-mod-network_git-24.205.48215-4f80a61_all.ipk
Configuring luci-mod-network.

It doesn't seem to be quite right. I see both my instances in the list when I edit a static lease, but if I edit a lease and save it without any changes the instance is lost.

I don't observe those results. What you see happening is the mac getting re-written, since it's now (for simplicity) a list, and not a space separated field. All other properties are retained. You might need to toggle instance to another, save it, edit again and toggle back, save to get the result you need the first time.

What you see happening is the mac getting re-written

This seems to happen on every single edit now, btw. Even if I save the changes, next edit does exactly the same thing. Unrelated to this issue of course.

Might be related to the mac verify function that runs. One could add a bit more code to prevent a new write.


common.log mutates an Error object passed as meta

In common.js there is the following code:
    output         = exports.clone(meta) || {};
    output.level   = options.level;
    output.message = options.message.stripColors;

But in exports.clone of the same file, you have:
exports.clone = function (obj) {
  //
  // We only need to clone reference types (Object)
  //
  if (obj instanceof Error) {
    return obj;
  }

If an error is passed as meta, the error message is unexpectedly mutated by the log call:
var error = new Error('this is the real error');
console.log(error.message); // -> this is the real error
logger.error('Func.name error', error);
console.log(error.message); // -> Func.name error

If you can let me know how you want that resolved, I'm happy to do the PR and tests.

This seems to be a duplicate of #610, and a (unmerged) fix is available in #703

Yes. This is a duplicate of #610. Good catch @harriha


lang/julia: Add support for julia-vterm when vterm is enabled.

There is a new Julia REPL (https://github.com/shg/julia-vterm.el) built to work specifically with the vterm backend. I have been using it for a few months and greatly prefer it over the julia-repl package (even with its own vterm backend). Here are my suggested changes to use julia-vterm when vterm is enabled.

Sorry for the super late response. It appears vterm support was incorporated into julia-repl at some point, which renders julia-vterm obsolete. I will add it to the README soon. Thanks for bringing this to my attention!


Return the right class, when subclassing a DataFrame with multi-level index

Subclassing pandas.DataFrame had some issues, when a multi-level index was used. This PR should fix that.

needs tests

What to test for, @jreback ? I can test, if subclassing works correctly, but there are other open issues on this topic and I understand it's work in progress.

well you need to assert that the correct class is returned
you create a dummy class do the operation and assert
not sure what you mean by the rest of your statement - exactly what doesn't work?

You're right. That's something that can be tested. I'll just add the use cases that were broken before. Thanks for the pointer.

whats new is now available for 0.16.1 https://github.com/pydata/pandas/commit/5ebf521eac528f5a4b772e4677f70b689b8b1826

Great. Now it pulled in some other commits as well. Is that an issue?

@manuelRiel If you do:
git fetch upstream
git rebase upstream/master

this should solve the extra commits

Yes. That did the trick. Usually I do a feature branch, but I forgot this time. So the PR is ok now?

@manuelRiel you need to git push gitusername branchname -f
in order to reflect these changes here.

Actually all my changes are reflected here. Or do you miss something?

pls add a release note in v0.16.1 (you can put in API changes).
@sinhrks can you take a look

Thanks for the heads up, guys. I have added the reference to the PR, as well as the release note. Let me know, if there is anything else to change.

pls rebase / squash, see here for help

Done @jreback

@manuelRiel Thanks for the fix. Can you prepare test cases when the column is MultiIndex, because you're fixing _getitem_multilevel?  Pls check followings can return correct classes.
# comments are results of current master
mcol = pd.MultiIndex.from_tuples([('A', 'A'), ('A', 'B')])
df = CustomDataFrame([[0, 1], [2, 3]], columns=mcol)

type(df['A'])
# <class 'pandas.core.frame.DataFrame'>

mcol = pd.MultiIndex.from_tuples([('A', ''), ('B', '')])
df = CustomDataFrame([[0, 1], [2, 3]], columns=mcol)
type(df['A'])
# <class 'pandas.core.series.Series'>

Sure. I'll look into that. We're using multi-levels extensively and didn't run into issues. But it's possible I overrode this function in the subclass. I'll make sure it works properly.

Added the tests, @sinhrks . Returns custom class as expected.

@manuelRiel this looks fine. Can you rebase and ping on green.

Rebased and passing, @jreback

@manuelRiel thanks!


title

PR-Codex overview
This PR updates the project's name and description to better reflect its focus on JSON manipulations instead of transformations.
Detailed summary:

Updated project name in pom.xml and README.md.
Updated project description in pom.xml and README.md.
Changed "Transformations" to "Manipulations" in project name and description.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo from the code, please don't forget to remove it.

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-06-29T12:19:04.930111.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Make Hover Listener respect transforms

Description
Before this change a RenderPointerListener that had active hover listeners (onPointerEnter, onPointerHover, onPointerExit) would drop any previous transforms on the floor if nobody else in that subtree required compositing. With this change RenderPointerListener itself now requests compositing if one of the hover listeners is set.
Debugging notes: If Nobody in a subtree requests compositing, the RenderTransform will execute the provided transform directly on the canvas instead of introducing a TransformLayer. When the RenderPointerListener pushes a new AnnotatedRegionLayer to make hover detection work, a new canvas for a new PictureLayer is created and all subsequent render objects draw into this new canvas, which doesn't know anything about the transform. Hence, the transform is ignored for all following draw operations.
If you push a layer, you need to request compositing to ensure that everything works correctly. Ideally, we should have an assert somewhere ensuring this.
Related Issues
Fixes https://github.com/flutter/flutter/issues/31986.
Tests
I added the following tests:

A test to verify that RenderPointerListener with active hover listeners doesn't drop the transforms on the floor.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes).
[x] No, this is not a breaking change.

Test added and rebased.


HIVE-26036: NPE caused by getMTable() in ObjectStore

What changes were proposed in this pull request?
Some api in ObjectStore invoke getMTable() but not check that if the returned value is null, which may cause the NPE, like addPartitions(), addPartition(), alterPartition() et.
Such api described above will check that whether the table exists in HMSHandler (first check), but if the table is dropped by other threads after the first check, the NPE will happen.
The simple idea is that we can check the table each time we get from getMTable().
Why are the changes needed?
To fix the NPE from getMTable() while others dropping this table.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Just add one test in TestObjectStore, can use the minimal test command:
mvn test -Dtest=org.apache.hadoop.hive.metastore.TestObjectStore#testPartitionOps -pl :hive-standalone-metastore-server

@kgyrtkirk @marton-bod Could you pls review this PR?

@wecharyu merged it - thanks for the fix!


"Widdle-to" questions, and related feature suggestions

Very curious about your new --widdle-to option.  First of all, as a point of nomenclature, did you perhaps mean to call this "whittle" rather than "widdle"?
Second, even after reading the help text, I'm unclear on what exactly this option does, what some typical use case would be, and how the iteration process works.  Perhaps you can explain by way of example?
Third, even before seeing this new option, I had planned to suggest something that is probably not directly related, but may share some similarities, insofar as it is another way of paring down the input list.  What I have in mind is simply stripping headers and footers (of known length) from the input file.  Some word list files (especially those that contain metadata) may have one ore more rows with header information (e.g., column titles).  Other word list files may include a footer (for example, for a PGP signature).  To allow tidy to use such lists without first preprocessing the files with a separate app that can strip out the rows that do not contain words,  I would suggest that you implement an option with a syntax like --strip <HEADER_ROWS>,<FOOTER_ROWS> (or if you prefer, two complementary options --strip-first <HEADER_ROWS> and --strip-last <FOOTER_ROWS>) to remove the specified number of header rows and/or footer rows from the file when it is first read in.
To keep things simple, if the <Inputted Word Lists> argument includes more than one file, then the stripping of header and footer rows would be done identically to each of the input files.

Very curious about your new --widdle-to option. First of all, as a point of nomenclature, did you perhaps mean to call this "whittle" rather than "widdle"?

haha omg how embarrassing. Fixed!

Second, even after reading the help text, I'm unclear on what exactly this option does, what some typical use case would be, and how the iteration process works. Perhaps you can explain by way of example?

This is definitely a niche thing, but I'll go over my particular use-case. Maybe you can help me re-write the help text (and/or add a paragraph to the readme).
Let's say we want to make a diceware list from the most frequently used words in (English) Wikipedia. First, let's download this enwiki-20210820-words-frequency.txt file. Note that this file is sorted by word frequency, and contains word frequency metadata after a space.
davis 129087
publications 128959
pair 128899
churches 128784
wins 128738
applications 128639

Next, let's write a Tidy command. Since we want this to be a diceware list for 5 6-sided dice, we need the list to be exactly 7,776 words. Let's say we also want to remove suffix words, set a minimum and max word length, exclude non-Latin words, lowercase all words, and filter out some profane words.
A naive approach
tidy -AA --cut-to 7776 -SlL -d s -m 3 -M 11 -r ~/lists/profane-words.txt --dice 6 -o wiki-diceware.txt ~/code/wikipedia-word-frequency/results/enwiki-20210820-words-frequency.txt

While this will produce a 7,776-word list from the Wikipedia data, it does not take advantage of the fact that the Wikipedia list is sorted by word frequency. To see why, let's summarize what this command does. It takes all 2,676,542 words on the Wikipedia list, does its various filtering and word modifications, then, thanks to --cut-to 7776, it randomly takes 7,776 words from the list to make its outputted list.
This is no good because it's just as likely to take a word from the way bottom of the list (a very infrequently used word, like amsanctus) as it is from the top. (And actually, since it has to operate on 2 million words, our Tidy command, as composed, takes a really long time to run.)
A basic approach
You might be saying to yourself "That's what the --take-first option is for!" And yes, it is! Let's see how we can use it.
tidy -AA --take-first 13000 --cut-to 7776 -SlL -d s -m 3 -M 11 -r ~/lists/profane-words.txt --dice 6 -o wiki-diceware.txt ~/code/wikipedia-word-frequency/results/enwiki-20210820-words-frequency.txt

Better! We get a word list with 7,776 words.
But... what if we could take just the first 12,000 words? That'd be better, since we wouldn't be including some less frequently words like "minsk" and "boone". Could we get away with 11,900? 11,800?
Optimizing
To find out, we could remove the --cut-to option and keep lowering and raising the --take-first value until we get 7,776 words exactly. But that's a lot of manual guess-and-check. And if you made any changes to your options or you reject/approve lists, you'd have to start over.
Whittling
Instead, we could use Tidy's brand-new, totally correctly spelled --whittle-to feature! Whittle does this guess work for us. We just run:
tidy -AA --whittle-to 7776 -SlL -d s -m 3 -M 11 -r ~/lists/profane-words.txt --dice 6 --force -o wiki-diceware.txt ~/code/wikipedia-word-frequency/results/enwiki-20210820-words-frequency.txt

Tidy will make an initial "guess" of a --take-first value (arbitrarily defaults to 7776*1.4), create the resulting list in memory, then compare this resulting list's length to the desired amount. If it's too long (over 7,776, in this case), it takes fewer words and runs again. If it's too short, it takes more and runs again. It'll run over and over again until it finds an initial --take-first amount that produces the exact number of words the user specified[1]. Then that list is outputted to the specified output location.
I argue there are other cases when you'd want a resulting list to be exactly a specified length, but diceware lists is the clearest.
(1) Whether there are cases in which this will never happen is an open question...

What I have in mind is simply stripping headers and footers (of known length) from the input file. Some word list files (especially those that contain metadata) may have one ore more rows with header information (e.g., column titles). Other word list files may include a footer (for example, for a PGP signature). To allow tidy to use such lists without first preprocessing the files with a separate app that can strip out the rows that do not contain words...

Re: the starting lines of metadata: I'm tempted to say this is out-of-scope. Unless you're getting an updated version of this source file every few seconds/minutes/hours, in this case I don't think it's a huge deal to pre-process header and/or footer lines. I'm proud of the --ignore-after/--ignore-before options, since that's handling per line metadata, which is more of a pain to re-apply accurately after processing.
By contrast, header and footer information is trivial to re-add after processing. Plus, you'd likely want to remove PGP header/footer information permanently, since the signature would no longer be valid after any change to the list.
(I'll note here that if we ever #12 working, users could do this header-footing stripping themselves -- probably with some nifty cat command -- and we wouldn't need a new Tidy option.)

I believe that --take-first and [--take-rand] operate directly on the unmodified input word list.

Yes, correct. (Think you meant "rand".) We can think of these as "pre-process" options.

In contrast, --cut-to is the equivalent of --take-rand, except that it operates on the final, modified word list.

Also correct. We can think of --cut-to as a "post-process" option.

Now you're adding --whittle-to, which (correct me if I'm wrong!) is the equivalent of --take-first, except that it operates on the final, modified word list.

Not quite. --whittle-to effectively operates on both the pre-process side and the post-process side. It is essentially a guess-and-check loop. It guesses a --take-first then runs through what we'll call "the tidying process" and sees how long the resulting list would be. If this list is not the desired length, Whittle makes a different --take-first guess and runs the tidying process all over again.
I like that both the pre-process options are called "take". They can be thought of as siblings. In contrast, given how Whittle works on both sides and employs a loop, it's unique, and thus I don't think it's a "sibling" of the --cut-to option (which is strictly a post-process option). As tempting as it it to want the symmetry between these 4 options, it's just not quite there.
I chose "whittle" because it's a process that takes small chunks out until it reaches the desired destination. "Cut" is more violent and exact. If we wanted to emphasize the random nature of --cut-to, I suppose we could rename it --cut-randomly-to or --randomly-cut-to, but that seems unnecessary, especially since we have "random" in the help text. So I like the naming scheme as is.
Why can't we just keep the first 7,776 words from the post-processed list?
I think this is the question you're asking here:

[*and if my understanding of --whittle-to is not correct, would my concept be a faster approach to addressing the use-case you described above??]

Or in other words:
Why can't we do all the processing on the entire input list (without ever sorting it alphabetically), then, right before printing the list, take the first 7,776 words to make a good diceware list? Wouldn't that be easier and faster?
The answer to this has to do with how prefix words, suffix words, and Schlinkert pruning work. If we removed all prefix words from the entire inputted list, then made cuts, we'd lose "good" (high word frequency) words unnecessarily. I believe that in order to do the cuts optimally, we need to make all the unrelated cuts first (like reject words, non-Latin words, etc.), then cut prefix/suffix words. That's why I went to all the trouble of making whittle-to do the looping.
You might then say: That's all fine and good, but to the end-user, whittle-to is basically a post-process option, and should be named as such.
I think I disagree with this. Whittle to is more complex than a post-process "cut" option, and I think it should have a unique name to signify that.

Slept on this and came up with: renaming cut-to as print-rand, and creating a brand new print-first. I like "print" to help denote it happens at the end. And adding print-first gives us the symmetry with take-first.
I left whittle-to as is. It's the odd cousin!

And if a user simultaneously specifies --cut-to-first with -P, -K, or -S, they could get a warning message telling them to use --whittle-to instead of --cut-to-first.

Neat idea. I've added a "Recommendation" for this niche case.

Just making sure that the cut is made prior to sorting, if the alphabetic sort option is left on (--no-sort false).

Whoops, will fix in next push.

What I have in mind is simply stripping headers and footers (of known length) from the input file. Some word list files (especially those that contain metadata) may have one ore more rows with header information (e.g., column titles). Other word list files may include a footer (for example, for a PGP signature). To allow tidy to use such lists without first preprocessing the files with a separate app that can strip out the rows that do not contain words...

I reconsidered this. Working on --read-line-start and --read-line-end options. Might have some question about how they should be indexed...

Haha, ok, let me get --skip-rows-start and -skip-rows-end working and I'll go from there.

If you still want to include some functionality more akin to --read-line-start and --read-line-end, perhaps the easiest thing to do would be to allow for an optional two-argument form of the --take-first option. For example, you could let --take-first 10000,5 be interpreted as "read the first 10,000 rows, starting with the 5th row."

Nah, think you're write that "skip" is the better verb and functionality, since it's easier to count the number of lines in a footer than to get the line number of the file where the footer starts.
I've just pushed v 0.2.65 to the repo, which includes
  --skip-rows-end <SKIP_ROWS_END>
            Skip last number of lines from inputted files. Useful for dealing with footers like from
            PGP signatures

  --skip-rows-start <SKIP_ROWS_START>
            Skip first number of lines from inputted files. Useful for dealing with headers like
            from PGP signatures

As well as print-rand, print-first.


When selecting an attack, pressing enter defaults to charge

Reported by FrBr on RT discord. When selecting an attack, if you choose punch or kick then hit , the action switches to the default Charge action instead of staying on punch or kick.

Fixed in 0.6.6


Example Unity Project

Hey, I'm a big fan of this body of work. From some initial, immediate tests with the Meta SDK, executing the permission and screenshot operations isn't as smooth as intended. In short, the UI disappears and nothing loads from the plugin, suggesting some null errors in the background for loading the plugin.
Would you be willing to share a zipped project that is formatted with the Meta SDK or Unity XRIT to test this out? I'm happy to debug issues further in Logcat if needed. But I would love to start with a working copy to verify things immediately.

Hi, @TheWiselyBearded .
Thank you so much for showing interest in this project. I really appreciate it.
I've created the sample project repository with the Meta SDK. Please take a moment to check it out.
Feel free to follow the instructions provided in the README of the linked repository for usage guidance.
Additionally, I've also prepared a zipped version of the project. If needed, you can download it from the releases section of the repository.
If you have any questions or need further assistance, please feel free to reach out.


Unable to import CSV or delete rows in local azurite (but can delete an entire table)

Storage Explorer Version: 1.17.0
Build Number: 20201211.10
Platform/OS: macOS
Architecture: x64
Regression From:  Yes, unknown version number - sorry just upgraded
Bug Description
I created a couple of tables and then tried to import the test data from CSVs but they failed to import.  I then tried to manually insert rows which worked.  Deleting a row then fails with an error.
Steps to Reproduce

Add a table called 'application'
Drag in the CSV file from a backup
The error "Importing '/Users/rob/Desktop/application.csv' into table 'devstoreaccount1/application': Failed: Cannot read property 'tableName' of undefined (0 entities imported)"
Manually insert a row (this works)
Try to delete the row just added
The error "Deleting entities from table 'devstoreaccount1/xxx': Failed: Cannot read property 'tableName' of undefined" appears

Expected Experience
I should be able to import from a CSV file and delete rows added.
Actual Experience
Can't import and can't delete rows.
Additional Context
I'm using a Local Azure deployment.
I can delete the table in its entirety, but not individual rows.
The Azurite terminal also has some output with 501 errors, note below is when I was testing with 'xxx' instead of 'application' - but the end result is the same.
 Please open an issue against Azurite first:
https://github.com/Azure/Azurite

@devology-rob - Did you open an issue in Azurite repo?

Sorry - I did not.
In the end I used the Azure storage for my dev use (rather than my local machine)
I'm closing this as advised it should be an Azurite issue.


(bug) Image screenshot that is taken for comparison comes Same and Distorted

Steps to replicate the issue:

Run the cypress code First time to get the original screenshot.
Now re run the Cypress code with a different image comparision.
The functionality works fine and it thus gives the error that "Snapshot does not match"
Now when I click on the button

I get the comparison screenshots as distorted and same (review the below screeshot), not able to differentiate the changed pixels, although please see that the functionality for the comparing screenshot works fine.

I'm seeing the same thing

Same with me.

This bug is fixed, but not yet in the latest release.
To install the latest version, including the fix, do:
$ npm install --save-dev github:meinaart/cypress-plugin-snapshots
instead of:
$ npm install --save-dev cypress-plugin-snapshots

@robertheessels Great. Thanks for the update!

Is there an update for the bug
I'm seeing the same thing between different browsers

I'm seeing the same thing

This's not work for me.


Broken dependency in tests/conftest.py - requires glci

What happened:

Tests fail because tests/conftest.py tries to import glci.util, but glci module was removed from this repository

glci removed with: https://github.com/gardenlinux/gardenlinux/commit/1eb667063dcd5a5fd4515cf35d0aa54c7119b635
tests/conftest.py dependency here: https://github.com/gardenlinux/gardenlinux/blob/main/tests/conftest.py#L11

Debug Logs:
example log: https://github.com/gardenlinux/gardenlinux/actions/runs/3838064843/jobs/6534104250#step:9:7114
+ sudo podman run --name f4c93c27-2f9b-4646-b7bd-e58979215bdc --cap-add sys_admin --cap-add mknod --cap-add audit_write --cap-add net_raw --security-opt apparmor=unconfined --rm -v /home/vincinator/workspace/job/gardenlinux/gardenlinux:/gardenlinux -v /tmp/tmp.T012dGeIvg:/config gardenlinux/base-test:today pytest --iaas=chroot --configfile=/config/config.yaml
ImportError while loading conftest '/gardenlinux/tests/conftest.py'.
conftest.py:11: in <module>
    import glci.util
E   ModuleNotFoundError: No module named 'glci.util'
make: *** [Makefile:62: aws] Error 4

How to reproduce it:

make aws
build succeeds, but tests can not be started

Hey @ccwienk, there seems to be a dependency in the garden linux tests to the glci python module.
For now, I suggest to keep using glci module, and resolve the dependency somehow. Whether it makes sense to re-implement the glci.utils for the conftest.py is a different discussion for later.
One solution could be to make the glci python module in https://github.com/gardenlinux/glci installable via pip, so we can resolve the dependency for now, what do you think?

As discussed in today's daily, we will implement the functions required in the gardenlinux/gardenlinux repo.


Get Youtube links working for each song

When searching for a song, the Youtube icon must be able to take the user to the corresponding video.

YouTube links & searches now work


Add search functionality to cellxgene-census docs

Description
Add search functionality to cellxgene-census documentation website at https://chanzuckerberg.github.io/cellxgene-census/index.html.
Context
See https://cziscience.slack.com/archives/C04LMG88VKJ/p1689261048038369.

Some updates after an initial investigation:

Sphinx by default includes search entirely client side search. E.g. you start a new project and run make html, there will be a functioning search bar
Currently this feature is disabled in the census docs. The search index is still built, but the search bar isn't excluded by using a blank "searchbox.html" template. If I remove that, a search bar is visible but still seems non-functional due to a missing jquery. Still not sure how that is being excluded or how I can get it back.

As an alternative to client side search, there is also Algolia DocSearch. I've had a little bit of trouble with it in the past, but think it's overall fine. No idea if it's going to give users cookies.

Closing, since it was fixed in #1166

Great, thanks so much, @ivirshup!


Db based on diagram

In this pull request the following changes were introduced as per these specifications

Created a file named schema_based_on_diagram.sql where you.
Implemented the database from the diagram.
Joined tables from many-to-many relationships.
added the FK indexes.

Project Status: INVALIDATED :red_circle:
Hi @lengushuru and @byiringiroscar ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, for the wrong Milestone. The milestone you submitted for is Enumerable's but this pull request is for create a database based on a schema 👍
So kindly submit this pull request to the right Milestone 👍

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Specs are executed before async beforeAll completes if...

I opened this bug originally on https://github.com/jasmine/jasmine/issues/898 but was suggested that it is related to protractor.
describe('test suite', function(){
   beforeAll(function(done) {
       // login logic that navigates to Windows Azure AD login page
       // then enter login on azure
      // then wait for azure to return to my app
      // then click on a button for logged-in user
      .then(function(){
          done();
       });
   }, 20000);

   describe('verify bla', function() {
          it('should bla....', function() {

         });
   });
});

From the sample code above, the it spec gets executed before beforeAll calls done and fails with the following message:
- Failed: Error while waiting for Protractor to sync with the page: "angular could not be found on the window"
This used to work in protractor 1.x + jasmine 1.x and stopped working after we upgraded to jasmine v2.3.4 + protractor 2.1.
Thanks.

It looks like a chrome/chrome driver issue.  The same specs are failing with Chrome 43/44 but passing with Chrome 42.  Where should I file this bug? Thanks.

Probably the selenium github.  Sorry for the slow response - hopefully the problem has since been fixed!

@mocsharp Did you ever get this sorted?

I am seeing this issue with Chrome 50. Is there a workaround?

Seems like this can be circumvented with browser.wait
beforeAll(function () {
    browser.wait(doSomethingThatReturnsAPromise());
});

jasmine 2.5.2 and 2.6.0 support asynchronous for me only with the code:
(angular 2 + typescript)
describe('some test', function(){
const before = function(resolve){
   ....your async actions
  some_callback(){
    resolve()
  }
}

beforeAll(function(done){
   new Promise(before).then(done) //really work
   some_callback(){
     done() //!Does not work!
   }
})

it('',function(){....})
...
it('',function(){....})

})

Why i can not easy call done?


troll

👏👏👏👏 hahahaha

:trollface: 😭

Please close this. Don't ruin plz

spinner.svg gives it away anyway

we can make it even better let me rename

Can confirm, keep's spinning... hopefully this can be fixed in the next release.

almost sure that the problem is related to this file
https://github.com/sindresorhus/sindresorhus/blob/a8f62759fdc1e98539faf74a941f315439586f69/.gitattributes#L3

Guys I think I found a fix #2 we need to get this merged ASAP our lives depend on it...

😂😹

lol That is funny. I wasted a lot of time on it.

I feel trolled. Nice @sindresorhus 😆

I even tried to disable ublock thinking this is the issue :trollface:

@sindresorhus @makbol's idea is just pure evil! It's a must-have!

😭😭😭😭😭

All your base are belong to us!

Guys the pr opened @szmarczak made the readme fail to display immediately fixed in #9

@Richienb No, you're wrong. My PR loads immediately as the content is displayed on the first run. Yours takes 10s to load, so yours doesn't load immediately.

Lovely approach doe!

Can we close the issue? @Richienb fixed this issue. Just wait a while and it loads :D


Update statistics title

We need to indicate that there are research documents in this finder too.
https://trello.com/c/kyjyR5RB/573-update-title-of-statistics-finder

@karlbaker02 I'm not really fussed about keeping finder-frontend in step with the content items.  Those files are there for development purposes and for test fixtures.  As long as our test fixtures allow us to exercise the functionality we've added that's fine, isn't it?
I'd rather rely on these files being a single source of truth, and the ones in finder-frontend being indicative, but not real.


refactor: Dockerfile

Use golang version as per in go.mod for build stage
Used non-alpine which comes with preinstalled build essentials (gcc, make, git, curl ca-certificates)
Use ENTRYPOINT instead of CMD which enables signal forwarding and better args support for binary
Copy binary in /bin to avoid specifying absolute path everywhere and follow best practice
Add -trimpath in go build flags to remove absolute path in debug more here
Move LABEL to built image
Move CGO_ENABLED to global
Remove go mod download since go build will do the same before building

It should not break anything exising but still putting ! in commit as warning

Started trying this project and loving it. Glad to see infra level projects in web3 so looking forward to contribute

May the source be with you

Hey @pratikbin, is this PR ready for review?

Hey @pratikbin, is this PR ready for review?

Yes

@jay-dee7 made changes

@pratikbin can you please sign your commit? commit signing is required, and it'll be best if it's done via GPG (tutorial on how to set it up)[https://github.com/pstadler/keybase-gpg-github] but I think just email signing would work too

@pratikbin can you please sign your commit? commit signing is required, and it'll be best if it's done via GPG (tutorial on how to set it up)[https://github.com/pstadler/keybase-gpg-github] but I think just email signing would work too

Do I have to push all the sign-off commits or what?

Yes. You must sign both of your commits or you can merge your commits into one and and then sign a single commit

Either I have to create new PR with signed commit or I have to revert all these commit and sign it. Which one you would suggest?

Either I have to create new PR with signed commit or I have to revert all these commit and sign it. Which one you would suggest?

Oh no, it's actually quite simple to do.

Make sure your main branch is up-to-date with OpenRegistry main
then run git rebase -i main, it'll open up an editor (vim/nano/etc) and present you three commits (since this PR has three commits): This is how it'll most probably have the following format:

pick commit-hash commit-msg
pick commit-hash commit-msg
pick commit-hash commit-msg

Change the word pick to edit in the commits that you own, save the file and exit
and then run git commit -S --amend --no-edit && git rebase --continue twice and you should be good
Push to your branch

Remember when committing, -S (capital letter works with GPG key so if you don't have that setup, just use -s (lower case/small letter s)

@jay-dee7 check once

@pratikbin this just added more unsigned commits (because of merge). Just reset the head and make a single signed commit, we should be good after that

@jay-dee7 I'm usually good at git but failed here

Superseded by #196


Unclear if the parameters of /LTCG are supported

The description notes that lib.exe has a /LTCG option. The description links to the /LTCG option documentation of link.exe, which lists several parameters of /LTCG. It is unclear if these are also supported by lib.exe.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a64e0671-42d6-8a30-ebff-d2b501d731c1
Version Independent ID: 2f675905-9ad0-14bd-2b1b-c2f08fd831dd
Content: Running LIB
Content Source: docs/build/reference/running-lib.md
Product: visual-cpp
GitHub Login: @corob-msft
Microsoft Alias: corob

doc is updated. thanks again!

Where? I can't see any PR referencing this issue, and  looking at https://github.com/Microsoft/cpp-docs/blob/master/docs/build/reference/running-lib.md, I also cannot find any recent change.


Add Crac JDK support (SSM open socket)

Type: Feature
I've been experimenting with https://github.com/CRaC/docs. However, when you attempt to do a crac checkpoint and you've got awssdk:ssm dependency in the pom then Crac checkpointing fails with

Suppressed: jdk.internal.crac.mirror.impl.CheckpointOpenSocketException: Socket[addr=ssm.eu-west-1.amazonaws.com/<IP_ADDRESS>,port=443,localport=36852]
2024-01-19 09:56:26             at java.base/jdk.internal.crac.JDKSocketResourceBase.lambda$beforeCheckpoint$0(JDKSocketResourceBase.java:68) ~[na:na]
2024-01-19 09:56:26             at java.base/jdk.internal.crac.mirror.Core.checkpointRestore1(Core.java:169) ~[na:na]
2024-01-19 09:56:26             at java.base/jdk.internal.crac.mirror.Core.checkpointRestore(Core.java:286) ~[na:na]
2024-01-19 09:56:26             at java.base/jdk.internal.crac.mirror.Core.checkpointRestore(Core.java:265) ~[na:na]
2024-01-19 09:56:26             at jdk.crac/jdk.crac.Core.checkpointRestore(Core.java:72) ~[jdk.crac:na]
2024-01-19 09:56:26             at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[na:na]
2024-01-19 09:56:26             at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[na:na]
2024-01-19 09:56:26             at org.crac.Core$Compat.checkpointRestore(Core.java:141) ~[crac-1.4.0.jar:na]
2024-01-19 09:56:26             ... 13 common frames omitted

as CraC JDK requires no open sockets and files before checkpointing.
Describe the solution you'd like

Spring Cloud AWS to add support for Crac JDK to automatically pause the SSM open socket when checkpointing OR
add an ability to manually stop/restart the SSM socket via a code property at runtime

I think this is more complex than just open socket. On restore, secrets have to be fetched again. If you are able to provide a PR we are happy to look into it.

I think an option would be to reload the ssm automatically at runtime with a different profile. In most cases one would take the crac snapshot in a profile like devl but when deploying you would want to switch to QA/PROD when you restore. So is there any way to refresh the ssm config and all related beans at runtime without destroying and recreating the whole app?

There is a way to reload properties https://docs.awspring.io/spring-cloud-aws/docs/3.1.1/reference/html/index.html#propertysource-reload-2

yeah but will that update the properties of all related beans. For instance, if you've got mongoDB or Kafka configured I guess you would have to manually re-create these beans?


Update to use Typed Quotes

What Changed
Arrow Meta made some changes to adopt Typed Quotes (arrow-kt/arrow-meta#679) in NamedFunction, Property, and TypeAlias, so we need to update our code to pick up that change.
Why
Todo:

[ ] Add tests
[ ] Add docs
[ ] Add release notes

Release Notes

@stabbylambda can you link to the docs for this change? Or explain why it only affects the properties?

:rocket: PR was released in v0.9.0 :rocket:


Associated types in constraints are not normalized

trait T {
    type O;
}

impl T for () {
    type O = ();
}

fn f<X, F>(_v: F)
where
    X: T,
    F: FnOnce(&X::O),
{
}

fn main() {
    f::<(), _>(|_z| {}); // _z is inferred as `&<() as T>::O>`
}

Possibly unrelated, but inference no longer works if the code is changed to F: FnOnce(X::O). F: FnOnce(X) is fine, though.
Split off #3138.
https://github.com/rust-analyzer/rust-analyzer/blob/eb804261dce7f13056566377148a41f460feed28/crates/ra_hir_ty/src/infer.rs#L410 might need to be called on types returned by chalk.

Interestingly, _z does get normalized when we use it in an expression :thinking:

@flodiebold should I file a new issue for the F: FnOnce(X::O) case :laughing:?

It looks like that's just another case of rust-lang/chalk#234, though I have no idea why it works with &. We could maybe add it to #2603 and make that the list of cases to check once the Chalk issue is resolved :sweat_smile:


259 update libraries to latest version

#259
CHANGES

[x] Update libraries in cloud generated code

https://github.com/codeandpepper/janush/pull/260#pullrequestreview-1002368798
🙄


Compile-time dispatch instead of switch-case

As I pointed out in one of my messages in #775, there are many cases like this, where a switch-case is employed to make the decision of which intrinsic to call, even though this decision could be done at compile-time.
As part of our program to improve debug build performance, as @marzer suggested, and for improving performance overall, this should be changed to using some std::enable_if type thing.

I think we should run benchmarks and see how / whether this hits performancs before complexifying the implementation.

We already have a similar system for neon intrinsic, and from a maintenance perspective, a single switch is much easier to maintain / read... I'm personally not in favor of trading ease of maintenance with debug build speed.

One thing we could do, which I think would be very nice, is use if constexpr if the __cplusplus macro's value is greater than 201703L, and otherwise, stick to the switch-case statement.
if constexpr would solve this problem at almost zero cost to ease-of-maintenance.

I don't mind that, provided we can write a nice compat macro that performs either a switch or a cascade of constexpr if.

@serge-sans-paille what are your thoughts on replacing the existing switch statements with an if-clause? Granted, the readability of the code will be hurt a little, but doing so would make writing a macro for switching between if and if constexpr very easy.
Moreover, from what I could tell, it doesn't look like there is really a big difference performance-wise between switch and a cascade of ifs for such a small number of cases.

is use if constexpr if __cplusplus >= 201703L

@wermos Testing the whole C++ version isn't necessary; compilers should define __cpp_if_constexpr with a value >= 201606 when if constexpr is supported.

is use if constexpr if __cplusplus >= 201703L

@wermos Testing the whole C++ version isn't necessary; compilers should define __cpp_if_constexpr with a value >= 201606 when if constexpr is supported.

The problem with these feature test macros is that they were added in C++20, so it is not neccesarily defined if, for example, a compiler is fully C++17 compliant (meaning they have if constexpr) but have no C++20 support yet (meaning these feature test macros don't exist).

https://godbolt.org/z/Yznoh9nKT

Do you have any links [...]

I don't; that page has always been my go-to. It has been on cppreference since 2015, though, so I suspect the "C++20" but at the top was more that "oh hey these are all actually official now, whereas they've been pseudo-standard up until this point", a bit like how #pragma once is 'non-standard' but supported everywhere that matters.
The feature test macros page in 2015: https://en.cppreference.com/mwiki/index.php?title=cpp/feature_test&oldid=77408

I like the idea of cascading if. Has the test is trivially constant,  compilers should have no difficulties folding it so the runtime cost at -O2 should be null.


Improve error message for misconfigured models: block in dbt_project.yml

Describe the bug
This is almost certainly user error rather than a bug. To the extent someone knows off-hand what I'm doing wrong that would be greatly appreciated. I'm new to using dbt with postgres and so have changed my setup somewhat.
Steps To Reproduce
I posted the details on SO, but not sure dbt is that active there, vs GH / Slack; I had to create the dbt tag.
Including here:
I have a dbt_project.yml like:

name: rdb
profile: rdb
source-paths: ['models']
version: "0.1"

models:
  rdb:
    schema: cin
    materialized: table
    post-hook: 'grant select on {{ this }} to rer'
    on-run-end:
        # TODO: fix
        - 'grant usage on schema "{{ target.schema }}" to rer'

DBT has worked really well. But with the on-run-end entry, it fails with Compilation Error  'target' is undefined. With that line commented out, it works fine.
Am I making a basic mistake? Thanks!
Expected behavior
A clear and concise description of what you expected to happen.
System information
Which database are you using dbt with?

[x] postgres
[ ] redshift
[ ] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
installed version: 0.15.1
   latest version: 0.15.2

The operating system you're using:
Linux
The output of python --version:
Python 3.6.8
Additional context
Add any other context about the problem here.

hey @max-sixty - this is a pretty gross error message from dbt.
You'll just want to slide the on-run-end out of the models: config and make it a top-level configuration, eg:
on-run-end: "grant ..."

models:
  rdb:
    ...

I'll leave this issue open to track a feature request for a better error message for these kinds of things :)

Perfect! Thanks for the quick response.
Yeah, even if the error message isn't ideal, showing the on-run-end with the perspective of a dbt_project.yml file in the docs meant I probably would have realized my mistake earlier.
Thanks a lot for dbt; it's such a good tool. I recently converted from an airflow stack.

Also FWIW using target.schema didn't include the cin part of the schema. Changing to just schema correctly used dev_cin

closing this, as the target var is now available in the models: block, even if the on-run-start hook does need to be declared at the top-level of the file :)

Thanks @drewbanin ! And congrats on your recent funding!


Linux line endings auto-converted to Windows line ending when cloning repo to Windows machine causing setup.sh to fail

If a user wants to use Windows Subsystem for Linux (WSL) to execute setup.sh, the installation will script will fail if the user just executes a Git clone operation against the OpenEduAnalytics repo. The reason for this is that the default git client behavior on Windows is to convert Linux line endings to Windows line endings, as controlled by the following git config parameter:
Configuring Git to handle line endings
While it's true that this parameter is under end-user control and will need to be adjusted on their end, it might be worth adding a brief note to the Setup section about this default behavior when cloning the code to Windows machines. The git clone command can be invoked with the following parameters to override the system defaults with regards to line endings:
git clone --config core.autocrlf=false https://github.com/microsoft/OpenEduAnalytics

Excellent - thanks for this Sergio


Should be merged in promise-toolbox

Personally I'd prefer that this remains a standalone package...or that it's available as both, like lodash functions

Hi everyone,
May I know your reasons for this?
promise-toolbox is a small package (less than 200kB on disk) and completely modular, you can import only what you need so it you will not pay the price of the rest in your bundles.
It's much easier for me to manage a single package with whole this utilities instead of having tons of separate packages.

Actually since discovering this I've found other packages that do the same thing like p-event

@julien-f I definitely understand...from the perspective of a package user, anytime I want to use lodash' throttle as a dep of a small package or my own I cringe a little bit inside, even though I can inport only the throttle function... it's an awkward tradeoff

I understand, thanks for your feedback :slightly_smiling_face:


Fix keep continue before login successfully

Closes: #1028

Coverage remained the same at 73.802% when pulling 6a824f16008b14fb7be603ab08f7199536881246 on vxcamiloxv:fix-keep-continue-before-login into beff2901fc48baa0fd45582678c37b90802f0d34 on pump-io:master.


Update 01-spatial-data.Rmd

spelling err

closing this, as material has been substantially revised


Addition of management schema and resolving of dates

can you please do a commit with the other files need to solr for working? thanks


Cursor disappears on text editor

Type: Bug
The cursor disappears on the text editor.
The following Issue seems to be a similar problem.
Mouse cursor dissapears when i move it to the editor area. · Issue #204181 · microsoft/vscode
According to the report, the Issue is resolved by disabling hardware acceleration.  And I solved it that way.
But that is a temporary fix, and I want a permanent BugFix.
By the way, when I record the screen, the cursor appears in the video (which also seems similar to a common hardware acceleration problem).

This is just a prediction, but it may have been an Issue caused by Windows Update.
Windows Update (KB5046740) was distributed on December 10, the date and time this Issue occurred, and it is natural to assume that this was the cause.
And today, KB5048667 has been distributed. Well, since the Issue was resolved before the update, the causal relationship is unclear...
Anyway, it has been resolved.
You can close it, but it seems to be a frequent problem, so you might want to take action.

Disabling HDR fix it for me.

Let's track in https://github.com/microsoft/vscode/issues/204103


Formatting of Configuration Object Items lost

Please restore formatting for the Configuration Object
The docs for the older version 1.10.1 of the Configuration Object have nice formatting:
https://kivy.org/doc/stable-1.10.1/api-kivy.config.html#module-kivy.config

The more recent versions have lost the formatting: https://kivy.org/doc/master/api-kivy.config.html#module-kivy.config

Moved to kivy/kivy, as docs are managed in this repo.


Add cudaLaunchHostFunc

According to the CUDA Runtime API documentation, cudaStreamAddCallback will be deprecated in favor of this new function, added since CUDA 10.0:

This function is slated for eventual deprecation and removal. If you do not require the callback to execute in case of a device error, consider using cudaLaunchHostFunc. Additionally, this function is not supported with cudaStreamBeginCapture and cudaStreamEndCapture, unlike cudaLaunchHostFunc.

TODO:

[x] Skip tests for CUDA 9.x
[x] Add stubs

/test

pfnCI, test this please.

Jenkins CI test (for commit d7dc7d3a0634770e674a26c2636772a770151ebf, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit d7dc7d3a0634770e674a26c2636772a770151ebf, target branch master) succeeded!

LGTM!

Thanks!

Thanks @takagi @pentschev!


Possibility to add comments to findings

It can be cool to have the possibility to add comments/remarks on findings written in a audit.

This can be achieved using Custom Fields. See https://github.com/pwndoc-ng/pwndoc-ng/blob/master/docs/data.md


Can I change huggingface yoken to my own sd path

I want to use my local running sd-webui-1111 version to generate texture for 3d model. Could I just change the model path?

I have tried it.
I created ./stabilityai and manually downloaded the "stable-diffusion-2-depth" and "stable-diffusion-2-inpainting" on the hugging face website.
It works, however, I got many warning messages like "keys mismatch" between the downloaded model checkpoints and the built models. And I got very bad results when running the demo, such as:

I am interested in what results you can get if you download the hugging face checkpoint locally.

The back view is like:

Well, now I have fixed the problem.....
I find that I used the wrong checkpoint before thus it outputs the "key mismatch" warning. Now it works well. I think you can use your local SD model and just simply replace the pre-trained model path will work.


Extract first frame from Shaka player

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
If the question is related to FairPlay, have you read the tutorial?

Not related to FairPlay.
What version of Shaka Player are you using?
4.11.11
What browser and OS are you using?
All mobile, desktop browsers and system browser for webview.
Please ask your question
We are creating a reels (verticle videos) kind of platform using single player. The first frame info is present with player. So, while swipping the next/previous page is blank as there is only single player instance. I have following questions:

Does shaka player can extract first frame while preloading?
Does shaka player can extract first frame from MPD file?

Any update?

Shaka delegates the decoding of any video to the browser, so Shaka cannot extract any frames. If the video is not encrypted you could use a canvas to extract a frame and turn it into a png image for example...


improvement to add caddy for easier server config

This repo is just fantastic. Thank you for your work.
Do you think we can add caddy to the docker-compose config introduce automatic TLS renewal for https connection, and introduce server layer on top of docker container for reverse proxy so that we can have easier way to deal with server configs?
Let me know what you think. @vmelnych
Thanks!

Thanks, @halukugurlu , I wanted to keep it clean from proxies, because by majority of cases this repo is enough to use on the laptop for the R&D purpose. My personal preference is traefik, but be it caddy, traefik or nginx - it is a matter of adding a few lines to the existing docker-compose file. I might consider creating another sample of a compose file if many people ask for it.


Added WPF port article

Summary
Added article for porting WPF to Core 3.0
Fixes #10178

Don't need a lot of review. This is a carbon copy with a few changes here and there of the winforms version.


crash with '?' in password, function_clause in Regex, :match?

using the url short format with '?' in password, like this:
config :app, App.Repo,
  adapter: Ecto.Adapters.MySQL,
  url: "ecto://test:test?@<IP_ADDRESS>:3306/app"

i got:
** (Mix) Could not start application app: exited in: App.start(:normal, [])
    ** (EXIT) an exception was raised:
        ** (MatchError) no match of right hand side value: {:error, {:shutdown, {:failed_to_start_child, TpossCcs.Repo, {:EXIT, {:function_clause, [{Regex, :match?, [~r/^\/([^\/])+$/, nil], [file: 'lib/regex.ex', line: 158]}, {Ecto.Repo.Config, :parse_url, 1, [file: 'lib/ecto/repo/config.ex', line: 61]}, {Ecto.Repo.Config, :config, 2, [file: 'lib/ecto/repo/config.ex', line: 31]}, {App.Repo, :start_link, 0, [file: 'lib/app/models.ex', line: 2]}, {:supervisor, :do_start_child, 2, [file: 'supervisor.erl', line: 314]}, {:supervisor, :start_children, 3, [file: 'supervisor.erl', line: 297]}, {:supervisor, :init_children, 2, [file: 'supervisor.erl', line: 263]}, {:gen_server, :init_it, 6, [file: 'gen_server.erl', line: 306]}]}}}}}
            (app) lib/app.ex:17: App.start/2
            (kernel) application_master.erl:272: :application_master.start_it_old/4

if my definition format is correct, this point must be tested for all possible characters

@umatomba No, that is not valid. The error message could be better though.

@josevalim should the userinfo part be automatically encoded |> URI.parse |> decoded in ecto?

and i dont understand why in erlang:
<EMAIL_ADDRESS>me").
"http%3A%2F%2Fdc%3Ad%3Fc%40dc.com%2FSo%20me"

but in elixir only the part after @ will be encoded
``
<EMAIL_ADDRESS>me")
<EMAIL_ADDRESS>me"
Is it a bug in URI.encode?

I think http_uri:decode(http_uri:encode("http://dc:d?c@dc.com")).
could be a good solution

please keep in mind that URL encoded paswords have own rules for encoding due to the fact of URL special characters. We should decide either
a) to NOT allow special characters from a operational perspective
b) use another schema to configure parameters in a K/V fashion and not URL
c) train all operations people to further encode the passwords with the URL encoded escaping.
Background:
https://app.zencoder.com/docs/guides/getting-started/special-characters-in-usernames-and-passwords

@umatomba not a bug in URL encoded. check URL.encode and URL.encode_www_form.

@josevalim I personally see only one problem:
Ecto.Repo.Config.parse_url "ecto://test:test%3F@<IP_ADDRESS>:3306/app"
[username: "test", password: "test%3F", database: "app", hostname: "<IP_ADDRESS>",
 port: 3306]

At the moment it is impossible to have ? in password nor as percent-encoded with URIs in ecto. I think, this is a primary bug? Or it is desired behaviour?

specially a password with a ":" would raise problems here. I would not like to train OPS staff to learn URL encoding rules to encode a already complex password to fit URL encoding rules. If this abstracted away in some form i.e. connection string -> URL encoded string. K7V Fields -> URL encoded string I'm happy and fine. May this can happen in the Application Config above the ecto library ?!?!

@hwinkel : My preferable solution is, If percent-encoded will works, than we can modify our configuration parser, that it takes configuration db = test:test?@<IP_ADDRESS>:3306/app transforms to ecto://test:test%3F@<IP_ADDRESS>:3306/app
Than, we do not need to train(not the c)), not need to use other schema(not the b)), if we can forbid : from operational perspective, because it is separator between username and password. If it not an option, than b) is our way.

@liveforeverx You are right but then the thing is not a URL anymore, because it not follows  URL encoding and it is just  string. BTW: anybody knows how DB tool interpreted this "connection string" usually. Do they assume this connection string is an URL and therefore needs to be encoded as URL?

@liveforeverx the url_encoding or decoding is not our task. I think it must be on ecto side

@umatomba do not agree, the ecto should encode URI string, as RFC specifies it. If we want to allow not to encode, we need to do it on our side.

@liveforeverx if I would look from untrained OPS perspective I would assume something is wrong as the string is changing. In this context I would say have K/V app config wich transforms to a (hidden) URL encoded string. Or use the URL just for the resource and encode db.user db.pass separately like:
db.db = mysql://<IP_ADDRESS>:3306/app
db.user = user
db.pass = test?
This also tells the db repo driver in use?

@hwinkel yes

@hwinkel : String changes are not seen by OPS, as they do not see the erlang term configuration at all. (Only, if they will try to check running erlang term configuration).

@liveforeverx let leave our OPE 3rd Level Support question alone for now, I think this has may no interest for the ex community. I'm fine with a encoded URL string in the ex context as long it will be not exposed in this form to the higher level application which uses the ecto library,

the solution that we take is to combine the possibility of short host, port and database definition using URI format and username and password options. it's look like:
url: "ecto://localhost:3306/ecto_simple",
username: "user",
password: "pass_][?/<~#`!@$%^&*()+=}|;:',>{_word"


Some colors of beacon beams does not match the color of the waypoints

Issue
Some colors seem to be swapped
(I am not sure about the right color of dark purple and light purple)

Versions

Minecraft: 1.20.4
Xaero's World Map: 1.39.0
Xaero's Minimap: 24.4.0
XaeroPlus: 2.23.2

thanks looks like the green/blue color components got swapped accidentally
will be fixed in next release

fixed in 2.24 https://github.com/rfresh2/XaeroPlus/releases/tag/2.24


Workdir path problem (?)

Hi
I just ran into a problem as I indicated the workdir in the command.
My command was as follows: bcbio_nextgen.py config/rnaseq.test.yaml --workdir work -t local -n 16.
First, I didnt have the directory work created and bcbio_nextgen complained. So I created the directory 'work'. The upload dir in the config/rnaseq.test.yaml is specified as follows:
dir: ../output.
Cutadapt (RNA-seq pipeline) then stored the trimmed sequences in the folder work/work/trimmed, so an extra work-folder. In the next step, when the STAR aligner is running (or has run), an exception is produces, which says:  IOError: [Errno 2] No such file or directory: 'work/align/Patient_6L002/1_19.06.12_rnaseq_experiment_star/Patient_6L002.bam' . There is a file under work/work.... with exactly this name and path.
My guess is, that the error was produces, because I indicated the workdir flag in the command?
The complete error log:
[2015-06-19T11:48Z] multiprocessing: process_alignment
[2015-06-19T11:48Z] Aligning lane 1_19.06.12_rnaseq_experiment with star aligner
[2015-06-19T11:48Z] Running STAR aligner on work/trimmed/6_ACTGAT_L002_1.trimmed.fastq.gz and /home/mpschr/bin/bcbionextgen/data/genomes/Hsapiens/GRCh37/star/
[2015-06-19T11:58Z] [bam_sort_core] merging from 32 files...
Traceback (most recent call last):
  File "/home/mpschr/bin/bcbionextgen/tools/bin/bcbio_nextgen.py", line 220, in <module>
    main(**kwargs)
  File "/home/mpschr/bin/bcbionextgen/tools/bin/bcbio_nextgen.py", line 43, in main
    run_main(**kwargs)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 36, in run_main
    fc_dir, run_info_yaml)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 79, in _run_toplevel
    for xs in pipeline.run(config, run_info_yaml, parallel, dirs, samples):
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 291, in run
    samples = run_parallel("process_alignment", samples)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 84, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"])(joblib.delayed(fn)(x) for x in items):
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 657, in __call__
    self.dispatch(function, args, kwargs)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 404, in dispatch
    job = ImmediateApply(func, args, kwargs)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 142, in __init__
    self.results = func(*args, **kwargs)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 49, in wrapper
    return apply(f, *args, **kwargs)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/distributed/multitasks.py", line 31, in process_alignment
    return sample.process_alignment(*args)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/pipeline/sample.py", line 100, in process_alignment
    data = align_to_sort_bam(fastq1, fastq2, aligner, data)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/pipeline/alignment.py", line 67, in align_to_sort_bam
    bam.index(data["work_bam"], data["config"])
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/bam/__init__.py", line 50, in index
    utils.symlink_plus(in_bam, tx_bam_file)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 278, in symlink_plus
    shutil.copyfile(orig + ext, new + ext)
  File "/home/mpschr/bin/bcbionextgen/data/anaconda/lib/python2.7/shutil.py", line 82, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: 'work/align/Patient_6L002/1_19.06.12_rnaseq_experiment_star/Patient_6L002.bam'

Here is the command log:
[2015-06-19T10:14Z] /home/mpschr/bin/bcbionextgen/data/anaconda/bin/cutadapt --times=2 --quality-base=33 --quality-cutoff=5 --format=fastq --adapter=AACACTCTTTCCCT --adapter=AGATCGGAAGAGCG --adapter=AGGGAAAGAGTGTT --adapter=CGCTCTTCCGATCT  --minimum-length=25  -o work/trimmed/6_ACTGAT_L002_1.trimmed.tmp.fastq.gz -p work/trimmed/6_ACTGAT_L002_2.trimmed.tmp.fastq.gz /home/mpschr/Documents/projects/rnaseq-raw/samples/6_ACTGAT_L002_1.fastq.gz /home/mpschr/Documents/projects/rnaseq-raw/samples/6_ACTGAT_L002_2.fastq.gz;/home/mpschr/bin/bcbionextgen/data/anaconda/bin/cutadapt --times=2 --quality-base=33 --quality-cutoff=5 --format=fastq --adapter=AACACTCTTTCCCT --adapter=AGATCGGAAGAGCG --adapter=AGGGAAAGAGTGTT --adapter=CGCTCTTCCGATCT  --minimum-length=25  -o work/trimmed/6_ACTGAT_L002_2.trimmed.fastq.gz -p work/trimmed/6_ACTGAT_L002_1.trimmed.fastq.gz work/trimmed/6_ACTGAT_L002_2.trimmed.tmp.fastq.gz work/trimmed/6_ACTGAT_L002_1.trimmed.tmp.fastq.gz; rm work/trimmed/6_ACTGAT_L002_1.trimmed.tmp.fastq.gz work/trimmed/6_ACTGAT_L002_2.trimmed.tmp.fastq.gz
[2015-06-19T11:03Z] /home/mpschr/bin/bcbionextgen/data/anaconda/bin/cutadapt --times=2 --quality-base=33 --quality-cutoff=5 --format=fastq --adapter=AACACTCTTTCCCT --adapter=AGATCGGAAGAGCG --adapter=AGGGAAAGAGTGTT --adapter=CGCTCTTCCGATCT  --minimum-length=25  -o work/trimmed/6_ACTGAT_L001_1.trimmed.tmp.fastq.gz -p work/trimmed/6_ACTGAT_L001_2.trimmed.tmp.fastq.gz /home/mpschr/Documents/projects/rnaseq-raw/samples/6_ACTGAT_L001_1.fastq.gz /home/mpschr/Documents/projects/rnaseq-raw/samples/6_ACTGAT_L001_2.fastq.gz;/home/mpschr/bin/bcbionextgen/data/anaconda/bin/cutadapt --times=2 --quality-base=33 --quality-cutoff=5 --format=fastq --adapter=AACACTCTTTCCCT --adapter=AGATCGGAAGAGCG --adapter=AGGGAAAGAGTGTT --adapter=CGCTCTTCCGATCT  --minimum-length=25  -o work/trimmed/6_ACTGAT_L001_2.trimmed.fastq.gz -p work/trimmed/6_ACTGAT_L001_1.trimmed.fastq.gz work/trimmed/6_ACTGAT_L001_2.trimmed.tmp.fastq.gz work/trimmed/6_ACTGAT_L001_1.trimmed.tmp.fastq.gz; rm work/trimmed/6_ACTGAT_L001_1.trimmed.tmp.fastq.gz work/trimmed/6_ACTGAT_L001_2.trimmed.tmp.fastq.gz
[2015-06-19T11:48Z] /home/mpschr/bin/bcbionextgen/tools/bin/STAR --genomeDir /home/mpschr/bin/bcbionextgen/data/genomes/Hsapiens/GRCh37/star/ --readFilesIn work/trimmed/6_ACTGAT_L002_1.trimmed.fastq.gz work/trimmed/6_ACTGAT_L002_2.trimmed.fastq.gz --runThreadN 16 --outFileNamePrefix work/align/Patient_6L002/1_19.06.12_rnaseq_experiment --outReadsUnmapped Fastx --outFilterMultimapNmax 10 --outStd SAM --outSAMunmapped Within --outSAMattributes NH HI NM MD AS --readFilesCommand zcat  --outSAMattrRGline ID:1 PL:illumina PU:1_19.06.12_rnaseq_experiment SM:Patient_6L002  --outSAMstrandField intronMotif  | /home/mpschr/bin/bcbionextgen/tools/bin/samtools sort -@ 16 -m 1G  -T work/align/Patient_6L002/1_19.06.12_rnaseq_experiment_star/tx/tmpkKmCic/Patient_6L002-sorttmp -o work/align/Patient_6L002/1_19.06.12_rnaseq_experiment_star/tx/tmpkKmCic/Patient_6L002.bam /dev/stdin

I have comfirmed the behaviour changing the directory name from work to tmp and the same happened: The pipeline created tmp/tmp/... folder hierarchy and failed at the same point.
Before I had run the pipeline without from within the workdir, without the workdir flag. This worked fine and did not create extra subdirectories

Michael;
Sorry about the issues with using --workdir. The code was assuming that the directory would exist and be a full non-relative path (ie. /path/to/wherever/work`). Apologies. I pushed a fix that will create the directories and make them absolute if not specified, and will hopefully resolve the issue for you. You can either update to the latest development version or specify the full path, or just change to the work directory since that's essentially all this option does. Hope this gets things running for you and thanks again for the report.

Hi Brad
Thanks for the quick reaction. I'll try to use --workdir as soon as the current run is done and will report back.

Hi Brad.
I can confirm now, that the --workdir argument is not causing anymore the above exception and STAR aligner could be run


Package Scope
@suspensive/react-query
Description
ref: https://tkdodo.eu/blog/react-query-fa-qs#why-should-i-usequeryclient
<QueryClient>
  {(queryClient) => (
    <button
      onClick={() => queryClient.invalidateQueries({
        queryKey: ['items']
      })}
    >
      invalidate items
    </button>
  )}
</QueryClient>

Possible Solution
No response
etc.
No response

related: https://github.com/toss/suspensive/issues/1251


Fixes for #184, #185, #186

I would like to propose some bugfixes for the issues
#184 TypeError: Cannot read properties of undefined (reading 'fields') with Jhipster 7.9.3
#185 Incorrect package names and imports in templates
#186 Duplicated code after regenerating application with entity-audit enabled

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Need to fix prettier errors

Thanks @nitram84


fix: fix pubkeyToAddress bug

Codecov Report

Merging #141 (506776d) into main (4117c82) will decrease coverage by 3.16%.
The diff coverage is n/a.

:exclamation: Current head 506776d differs from pull request most recent head 91c405d. Consider uploading reports for the commit 91c405d to get more accurate results

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   41.08%   37.92%   -3.17%
==========================================
  Files          23       17       -6
  Lines        1969     1743     -226
  Branches       48        0      -48
==========================================
- Hits          809      661     -148
+ Misses       1160     1082      -78

Impacted Files
Coverage Δ

...les/eth-contracts/contracts/libraries/SafeMath.sol

...ules/eth-contracts/contracts/libraries/Address.sol

...ain-modules/eth-contracts/contracts/test/ERC20.sol

...in-modules/eth-contracts/contracts/ForceBridge.sol

...es/eth-contracts/contracts/libraries/SafeERC20.sol

...th-contracts/contracts/libraries/MultisigUtils.sol

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4117c82...91c405d. Read the comment docs.


Install Salt requirement first since we share some requirements

Codecov Report

Merging #5 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   89.01%   88.92%   -0.10%
==========================================
  Files          76       76
  Lines        4225     4225
  Branches      475      475
==========================================
- Hits         3761     3757       -4
- Misses        307      314       +7
+ Partials      157      154       -3

Flag
Coverage Δ

#Linux
88.92% <ø> (-0.10%)
:arrow_down:

#factories
81.84% <ø> (-0.19%)
:arrow_down:

#py35
88.92% <ø> (ø)

#py36
88.92% <ø> (-0.10%)
:arrow_down:

#py37
?

#salt_3000_1
88.92% <ø> (-0.10%)
:arrow_down:

#tests
96.51% <ø> (ø)

Impacted Files
Coverage Δ

saltfactories/utils/processes/helpers.py
67.02% <0.00%> (-2.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d7b85...3ae0964. Read the comment docs.


Devicelab window1 causes infra failures

This bot has been failing tests consistently. Manually quarantine the bot to unblock the tree.

Example build: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android basic_material_app_win__compile/7120/overview
Cannot run a document in the middle of a pipeline: C:\salt\Get-ChildItem.
At line:1 char:1
+ gci -Recurse cert: |Where-Object {$_.Subject -like "*GTS CA 1D4*" -or ...
+ ~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (C:\salt\Get-ChildItem:String) [], RuntimeException
    + FullyQualifiedErrorId : CantActivateDocumentInPipeline

Closing this favor of https://github.com/flutter/flutter/issues/114935


NoSuchMethodError: method not found: 'toString' on null in Production for Flutter web

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
1.flutter·3.7.8, 3.10.0
2.debug for flutter web on chrome is ok
3. build web, all network requests are failed,  I can see this 'NoSuchMethodError: method not found: 'toString' on null' on Console windows while develop check.
Expected results
running ok as debug model.
Actual results
NoSuchMethodError: method not found: 'toString
Code sample
Code sample
[Paste your code here]

### Screenshots or Video

Screenshots / Video demonstration

[Upload media here]
![image](https://github.com/flutter/flutter/assets/15399971/b7ab2f8c-f9bb-43a2-b7a6-bb0bda111516)

### Logs

Logs

```console
[Paste your logs here]

### Flutter Doctor output

tyzl@192 workplace % flutter doctor

┌─────────────────────────────────────────────────────────┐
│ A new version of Flutter is available!                  │
│                                                         │
│ To update to the latest version, run "flutter upgrade". │
└─────────────────────────────────────────────────────────┘
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
Found an existing Pub cache at /Users/tyzl/.pub-cache.
It can be repaired by running `dart pub cache repair`.
It can be reset by running `dart pub cache clear`.
Found an existing Dart Analysis Server cache at /Users/tyzl/.dartServer.
It can be reset by deleting /Users/tyzl/.dartServer.
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.0, on macOS 13.4 22F66 darwin-arm64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.1.1)
[✓] VS Code (version 1.79.2)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Closing this issue in favor of https://github.com/flutter/flutter/issues/129631. That issue is still in triaging, please leave there your comment with more information will help to identify the issue. Thank you!


WIP: fix(modules): Separate prefix/suffix tags, revert tag stack

Fixes #639 and #544, as requested by @patrick96. Provides a non-breaking solution to the problem posed in #544.
Stacks are removed (including the font index %{T}), but now the tags of prefixes and suffixes are separated from the main output.
There might still be some optimizing to be done, as the reset flag %{X-} still sometimes appears when switching between two defined values: %{B#8d7e45}prefix %{B- B#feffff}main. Also, module-wide settings (format-<type>) are not applied to the prefix and suffix.

To apply module wide settings to the prefix and suffix, could we move the builder->node(suffix); before we close all the formatting tags (Line 44)?
And for the prefix, we could duplicate the opening of all the format tags in front of the prefix node.
The prefix and suffix should then overwrite the settings, if they were set. Or is that not how labels and the builder work?

We could do that, but it doesn't seem very elegant. Our other option of a shallow reset might be cleaner.

Sorry, for the delay.
While it is not very elegant and duplicates a lot of code, I think having stacks just for that is overkill. And I think that with your latest commit, you agree.
I'll start testing on this now


Move OSX CI builds to GitHub Actions

This PR moves our OSX CI builds over to GitHub Actions.
cc @jakirkham
TODO:

[ ] Unit tests and/or doctests in docstrings
[ ] tox -e py38 passes locally
[ ] tox -e py27 passes locally
[ ] Docstrings and API docs for any new/modified user-facing classes and functions
[ ] Changes documented in docs/release.rst
[ ] tox -e docs passes locally
[ ] AppVeyor and Travis CI passes
[ ] Test coverage to 100% (Coveralls passes)

Status checks for GitHub Actions won't appear on pull requests until this PR is merged into master, but you can see the OSX builds for this PR here https://github.com/jrbourbeau/numcodecs/actions?query=branch%3Agha-osx

Thanks for reviewing @alimanfoo : )


Issue #294: Optimization of Unindexed Files [Staging Area]

Description
Adds #294
Type of change
New Feature. The Unindexed Files of a Qbeast Table were only optimizable from the StagingDataManager component. After thinking about structure and use cases, we noticed that the Staging Area has lost its original purpose (check issue #438) and that we should treat Indexed and Unindexed File separately from the Append execution.
For that reason, we extend the interface of optimization to enable the processing of the unindexed files too.
API
import io.qbeast.spark.QbeastTable

val qbeastTable = QbeastTable.forPath(spark, "/path")
qbeastTable.optimize(revisionID = 0L, fraction = <fraction_to_optimize>)

revisionID = 0L is the selected Revision ID for Unindexed Files.
fraction: Any number from 0.0 to 1.0 that we want to optimize. By default is 1.0. If it's a recently converted table with Qbeast, and contains a lot of legacy data, we suggest reducing the fraction to optimize and doing the operation in batches.

WARNING: each time we execute optimize() for the Unindexed Files it would calculate the bytes to optimize from the current state. If some files had already been indexed, they would not be part of the second iteration.

Implementation

Load the QbeastSnapshot of the Table.
Read the list of Unindexed Files from the QbeastSnapshot.
Select files til fraction * totalBytes threshold is reached.
Apply indexing and roll-up to the Data.
Write the data in files.
In the same transaction: (this step should be done internally as Qbeast Spark, since we have more control of Add Files, Delete Files, and transaction open/close. )

mark the old files as Deleted.
Add the new file entries.

Checklist:
Here is the list of things you should do before submitting this pull request:

[x] New feature / bug fix has been committed following the Contribution guide.
[x] Add logging to the code following the Contribution guide.
[x] Add comments to the code (make it easier for the community!).
[ ] Change the documentation.
[x] Add tests.
[x] Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested? (Optional)
This has been tested locally with: QbeastOptimizationIntegrationTest.
I've added four cases:

Optimization of a Converted Table. (All data is unindexed).
Optimization of a Hybrid Table after Append. (Some data is unindexed after an external append).
Optimization of a fraction of a Hybrid Table. (Do not optimize all the Unindexed Files at once).

Test Configuration:

Spark Version: 3.5.0
Hadoop Version: 3.3.4
Cluster or local? Local

Leaving this review and merge after #446

One more question: Are we checking if the input fractions are valid values—f in (0, 1.0]?

Yes, there's an assertion on IndexedTable optimize method:
  override def optimize(
      revisionID: RevisionID,
      fraction: Double,
      options: Map[String, String]): Unit = {
    assert(fraction > 0d && fraction <= 1d)
    log.info(s"Selecting Files to Optimize for Revision $revisionID")
    // Filter the Index Files by the fraction
    if (isStaging(revisionID)) { // If the revision is Staging, we should INDEX the staged data up to the fraction
      optimizeUnindexedFiles(selectUnindexedFilesToOptimize(fraction), options)
    } else { // If the revision is not Staging, we should optimize the index files up to the fraction
      optimizeIndexedFiles(selectIndexedFilesToOptimize(revisionID, fraction), options)
    }
  }


Support HA deployment structure

harbor boshrelease should support HA deployment structure, main idea:

Remove docker-compose out of harbor boshrelease, directly run services on docker via images
Split harbor-app job into functional service jobs, may include nginx, ui, adminserver,jobservice,systemlog and registry etc.
Add HAProxy and keepalived jobs for internal LB (backlog)
Extract database, cache, clair, and notary into external boshrelease

Hei @steven-zou, could you please explain what the motivation is to remove docker-compose and split the main job into separate jobs? Would it not work keeping docker-compose or is it just because it would be more elegant to go that way?


Add TagAs and related wrapper classes

Looking at the issues, I thought #1404 would be a nice way of getting introduced to the codebase so I went ahead and implemented a proof of concept of what this might look like.
I can see that there has been no discussion on this feature request (also, only now learned about the existence of the project board), fully understood if this is not something that might be needed.
Anyhow, I welcome any feedback and comments and am happy to make any changes that might be needed 🙂
Thank you!
resolves #1404

The test failing in CI fails on main as well.
Also, now after black and pylint I guess there wouldn't be a whole lot of difference if TagAs<something> were to be just child classes of TagAs as they would take up as much space and removing the TagAsMeta would probably improve readability.

thank you very much for the feedback, @karlhigley! appreciate it! 🙂 I just pushed an updated version, happy to make any changes that might be needed

Thanks for the contribution, @radekosmulski! 🚀

np at all, glad I can be of help! 🙂


electrum: 4.0.2 -> 4.0.3

Motivation for this change
Version update: https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I can build successfully on aarch64, but if I start the binary I get the error
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

fish: “./result/bin/electrum” terminated by signal SIGABRT (Abort)

This is not a new error, but it would be nice to fix with this update.

Works for me with the following:
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 91d9790fca8..3c3094c0a55 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -20134,11 +20134,11 @@ in

   electron-cash = libsForQt514.callPackage ../applications/misc/electron-cash { };

-  electrum = libsForQt514.callPackage ../applications/misc/electrum { };
+  electrum = libsForQt5.callPackage ../applications/misc/electrum { };

   electrum-dash = callPackage ../applications/misc/electrum/dash.nix { };

-  electrum-ltc = libsForQt514.callPackage ../applications/misc/electrum/ltc.nix { };
+  electrum-ltc = libsForQt5.callPackage ../applications/misc/electrum/ltc.nix { };

   elementary-planner = callPackage ../applications/office/elementary-planner { };

Updated the PR to fix the Qt issue.


fix: swap sip import order for pyqt5 to account for compat w private …

…module names in 5.11+
for issue #333

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @maxnbk, this looks solid. Would you mind bumping the version to 1.2.4? That way I can make a release with this fix.

version bumped.

Thanks!


Followup from #10040 - Support uv compiled requirements files

Skimming the template to make this a bit easier to understand for maintainers.
This is a replay of PR #10040.
to help out @avilaton, i have....

fixed the cause of the Sorbet error
incorporated feedback from @RazerM.
I also properly updated the patch via rebase to clean up the commit history.

I took note of the refactoring note given some of the duplication between the file and update methods. It's not a bad idea in general to abstract some of that out, however the level of effort there might not be worth it just now -- so I left it as is.
anything else needed to get this landed, @jonjanego / @sachin-sandhu ?
thanks all!

OK, quick update- this isn't going to work as is. There are other bugs in it also, and now taking a deeper look at the way pdm/uv/pip-compile/etc are supported (or not) here, that's showing up a bit more to do. will come back to it shortly. @jonjanego - can you reach out to me please? thanks!

OK, quick update- this isn't going to work as is. There are other bugs in it also, and now taking a deeper look at the way pdm/uv/pip-compile/etc are supported (or not) here, that's showing up a bit more to do. will come back to it shortly. @jonjanego - can you reach out to me please? thanks!

can you email me at<EMAIL_ADDRESS>- i do not see your email on your profile