[$500] Android-Chat-Tapping "Go back to home page", user directed to concierge page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

**Version Number:**1.4.11
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app
Tap profile icon
Tap Workspaces --- Workspace
Tap first Workspace " Vincenzoddragon+98's Workspace "
Tap question mark on top
Tap chat with concierge
Tap with " Enter the amount" link
Tap "Go back to home page"

Expected Result:
When user taps on "Go back to home page", he must be directed to home page
Actual Result:
When user taps on "Go back to home page", he is directed to concierge page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/aed5e74f-5296-4eac-ada9-90f08bf34d62
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ae40b53cb7ec7aed
Upwork Job ID:<PHONE_NUMBER>091346432
Last Price Increase: 2023-12-18

Proposal
Please re-state the problem that we are trying to solve in this issue.
Tapping "Go back to home page", user-directed to concierge page
What is the root cause of that problem?
here we use goback to redirect the user
https://github.com/Expensify/App/blob/17a924f6594ff478af4f2a55ddf03a9dd15629f9/src/pages/ReimbursementAccount/ReimbursementAccountPage.js#L405
What changes do you think we should make in order to solve the problem?
instead we should navigate to the home page
                    onBackButtonPress={() => Navigation.navigate(ROUTES.HOME)}

Proposal
Please re-state the problem that we are trying to solve in this issue.

Android-Chat-Tapping "Go back to home page", user directed to concierge page

What is the root cause of that problem?

The  FullPageNotFoundView used in our app and also appeared in the evidence video.
Clicking on  "Go back to home page" in this page will trigger the function onLinkPress. By default, onLinkPress: () => Navigation.dismissModal():
https://github.com/Expensify/App/blob/d6755d68444d5d8e9e2c7593c7eb3f1228a20c67/src/components/BlockingViews/FullPageNotFoundView.js#L51
In the case of this bug, when user is in concierge report, the app's route stack is [Home, CentralPaneNavigator].
Then, clicking on "Enter the amount" will navigate the user to FullPageNotFoundView. Now, the app`s route stack is [Home, CentralPaneNavigator, RightModalNavigator].
Then, if user clicks on "Go back to home page", it just pops the RightModalNavigator from the route stack, and user is redirected to concierge page.

What changes do you think we should make in order to solve the problem?

We need to check if the device is small screen or not. If true, onLinkPress: Navigation.navigate(ROUTES.HOME). If not,
onLinkPress: Navigation.dismissModal()
Do it by just update the bellow:
https://github.com/Expensify/App/blob/d6755d68444d5d8e9e2c7593c7eb3f1228a20c67/src/components/BlockingViews/FullPageNotFoundView.js#L73

What alternative solutions did you explore? (Optional)

NA

@situchan a couple of proposals to review when you get chance

@situchan when you get chance could you review the proposals above?

Still waiting on C+ review

Sorry missed this

I don't think this is bug. We should go back to last page, not LHN skipping all previous pages.
If something should be fixed to avoid users get confused, linkKey can be updated like "Go back to Concierge", similar to https://github.com/Expensify/App/blob/3bd747dd59692a9144e38060302e45b3de5adc12/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L258, but not worth fixing imo.

as a user if I click a wrong click i'd prefer to goback to last screen instead of any other screen

We should change the wording to "Go back to previous page"/"Go back" so we are not contradicting in terms of wording and functionality

@muttmuure i agree with @ishpaul777  https://github.com/Expensify/App/issues/32856#issuecomment-1850809658
But is this something worth doing?

I'm not sure I think this is super important to fix right now.


RAScore environment installation error

environment.yml is not found as the file is actually named rascore-env.yml
EnvironmentFileNotFound: '/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/data/models/RAScore/environment.yml' file not found
Failed to create rascore-env automatically please install as per instructions on respective GitHub with correct name
[2024-08-22 12:28:58,843][base][ERROR] - Failed to create rascore-env automatically please install as per instructions on respective GitHub with correct name
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/tony/Software/acegen-open/./scripts/reinforce/reinforce.py", line 92, in main
task = MolScore(
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/manager.py", line 192, in init
self._set_objective(
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/manager.py", line 274, in _set_objective
self.scoring_functions.append(fclass(**fconfig["parameters"]))
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/scoring_functions/rascore_xgb.py", line 50, in init
super().init(
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/scoring_functions/base.py", line 96, in init
self._create_env()
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/scoring_functions/base.py", line 123, in _create_env
raise e
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/scoring_functions/base.py", line 118, in _create_env
subprocess.run(cmd, shell=True, check=True)
File "/home/tony/miniconda3/envs/acegen/lib/python3.10/subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'conda env create -f /home/tony/miniconda3/envs/acegen/lib/python3.10/site-packages/molscore/data/models/RAScore/environment.yml' returned non-zero exit status 1.

Thanks for highlight this, should be addressed in the most recent version now #59


Add Dynamic Type support for iOS (Paper and Fabric)

Summary
This adds Dynamic Type support in iOS as described here.
Text elements have a new prop, dynamicTypeRamp, that allows users to specify which font ramp a particular Text element should take on as the OS's accessibility setting for text size. The different types line up with different values of UIFontTextStyle. If not specified, we default to the current behavior.
For the moment, this change is only for Paper. I tried applying a corresponding change to Fabric by adding an additional field to facebook::react::TextAttributes and changing RCTEffectiveFontSizeMultiplierFromTextAttributes to use that new field, but in the process I discovered that this function doesn't seem to ever get called, hence this bug.
Changelog
[iOS] [Added] - Dynamic Type support
Test Plan
Validated with a test page in RNTester. Screenshots follow:
A) Default text size
B) Largest non-accessibility text size
C) Largest accessibility text size, split across two screenshots due to size

A
B
C

Hey there. When we talked about this PR a bit internally, there was a little bit of concern on accepting new capabilities which are paper-only. Having functionality that works on Paper, but not Fabric, means we would be taking new features away when the new Architecture is rolled out/default in OSS.
I see that the Fabric implementation is blocked by a separate bug in #34990. I will make sure this is surfaced internally.

@NickGerleman Now that e9b89b5ff2b0085128bec2879d761352747d6714 is a thing, I've added a Fabric implementation as well.

Seeing the below when we are invoking the Cocoapods build internally via react-native-oss-ios-jsc, but not coverage in CircleCI. @cipolleschi @hramos any guesses?

The following build commands failed:

CompileC <>/Library/Developer/Xcode/DerivedData/RNTesterPods-avhcctdswdycllfjzyasqkbrubnn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-RCTText.build/Objects-normal/x86_64/RCTUITextView.o <>/Libraries/Text/TextInput/Multiline/RCTUITextView.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'React-RCTText' from project 'Pods')
(1 failure)


Provide descendant() and anscestors() functions

The library really should provide descendants() and ancestors() functions (recursive versions of predecessors() and successors()) out of the box, like python's networkx lib does. This was mentioned before in issue #34 .

Hey mate, I saw that the concern in issue #34 was the recursive versions hit stack-overflow issues in JS while imperative versions didn't.
Why do you want descendants() and ancestors() despite this? What am I missing? 😅


"No such user" popup when user tries logging in

Bug Report
System Information

Windows 10 Pro version 21H2
AMP Release "Triton" v<IP_ADDRESS>, built 28/03/2022 15:21
Mainline Build

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

What are you trying to do?
Login to a NEW user account that has two-factor authentication as REQUIRED.

What are you expecting to happen?
Log in by entering details, set up two-factor authentication, enter the 2FA code, complete login and go to the dashboard.

What is actually happening? ('Nothing' is not an acceptable answer!)
Log in by entering details, a popup indicating that the user must setup 2FA appears, user hits continue, a popup appears saying "no such user". User is unable to setup 2FA or login.

Reproduction

REQUIRE 2FA both in ADS and in the APPLICATION in my case Minecraft
Create a NEW USER
Set a temporary password for the user
Disable Cannot Change Password for user
New user goes to login by entering credentials
New user is advised they are required to set up 2FA, hits continue
New user is given an error "no such user" and is unable to set up 2FA or login.

To add on to this, a user with 2FA enabled is unable to change their password after successfully entering in their 2FA code. They're given "no such user" popup.

I wasn't quite able to reproduce this, but it is true that a user with 2FA enabled can't follow through with a 'password change required' prompt. This has now been addressed.
You should only turn on the 2FA setting at the ADS level, ADS is responsible for all authentication and the setting doesn't apply to the instances themselves.

Im pretty sure this just happens when the user tries to change his password
at the instance level. I have it so my user can Only access the individual
instance and not ADS.
The user specifically accesses only that specific instance on port 8081 and
never logs into ADS which prevents him from changing his password. The user
was created at the ADS level though.
On Mon, May 9, 2022, 4:44 AM PhonicUK @.***> wrote:

I wasn't quite able to reproduce this, but it is true that a user with 2FA
enabled can't follow through with a 'password change required' prompt. This
has now been addressed.
You should only turn on the 2FA setting at the ADS level, ADS is
responsible for all authentication and the setting doesn't apply to the
instances themselves.
—
Reply to this email directly, view it on GitHub
https://github.com/CubeCoders/AMP/issues/615#issuecomment-1120992800,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVO6R6HR5SP4RATVWTGVJU3VJD3A3ANCNFSM5TUGJK6Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

You shouldn't have users accessing instances directly on their own port. Right click an instance in ADS and select "Manage in new tab" and give users that URL.

I never knew about this! This is what I needed to know. Thank you very
much. I'm sure this will fix the problems I had
On Mon, May 9, 2022, 6:49 AM PhonicUK @.***> wrote:

You shouldn't have users accessing instances directly on their own port.
Right click an instance in ADS and select "Manage in new tab" and give
users that URL.
—
Reply to this email directly, view it on GitHub
https://github.com/CubeCoders/AMP/issues/615#issuecomment-1121128443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVO6R6ADVTSLN33XPN2J6ETVJEJYDANCNFSM5TUGJK6Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

I've changed my configuration to use the /?instance=c9ce16a URL instead. I
created a new user, logged in using the new URL for that specific instance,
setup 2FA as it's required (at ADS level only), go to the user profile to
change the password from the temporary password I gave the user and still
get this after entering my 2FA code. I think I've modified every setting
and still can't change it.
NOTE: This only happens when the user changes their own password from their
profile screen. NOT from the user management screen, which allows me to
change the password fine.
[image: image.png]
Thomas Lyon
On Mon, May 9, 2022 at 6:59 AM Thomas Lyon @.***> wrote:

I never knew about this! This is what I needed to know. Thank you very
much. I'm sure this will fix the problems I had
On Mon, May 9, 2022, 6:49 AM PhonicUK @.***> wrote:

You shouldn't have users accessing instances directly on their own port.
Right click an instance in ADS and select "Manage in new tab" and give
users that URL.
—
Reply to this email directly, view it on GitHub
https://github.com/CubeCoders/AMP/issues/615#issuecomment-1121128443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVO6R6ADVTSLN33XPN2J6ETVJEJYDANCNFSM5TUGJK6Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

This has been addressed in the latest nightly build.

It looks like this issue still exists. User Logs in using the /?instance= URL, user goes to change the password using their profile page. Popup appears "Failed to change password" "No such user". This is presently occurring with 2FA disabled.

Did you create the user at the ADS level then give them access to the instance? Or only added them directly in the instance. That will cause this error.

What if you turn on 2FA after they reset their password?

This is presently occurring with 2FA disabled globally because I was hoping that would fix the issue. When this issue was originally raised 20 days ago this was occurring with 2FA enabled though. Looks like it just happens regardless.


A phpext script is missing and v. 1.0.0 is not available

According to a documentation, there should be a phpext script to enable/disable PHP extensions:

And a second helper script, phpext enables or disables an extension for the current version of PHP.

But looks like it's not included in the repository.
https://github.com/rlerdorf/php7dev/search?q=filename%3Aphpext returns 0 results.
The reason behind this issue might be an unavaiable version of the box (1.0.0). When I try to add this version to vagrant, I receive the following message:

The box you're attempting to add has no available version that
matches the constraints you requested. Please double-check your
settings. Also verify that if you specified version constraints,
that the provider you wish to use is available for these constriants.
Box: rasmus/php7dev
Address: https://atlas.hashicorp.com/rasmus/php7dev
Constraints: 1.0.0
Available versions: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.9, 0.1.0

Same thing for me - I even tried to destroy the VM, clone the repo and create a new VM.
The phpext script is missing, and xdebug is not available.
If I do vagrant box update it says it's in the latest version 0.1.0.
 There is not currently a released version.

source

There is no way to install a unreleased version, see also mitchellh/vagrant#4079
@rlerdorf Could you press the release button for v1.0.0?

I downloaded v1.0.0, uploaded and released it as alfredbez/php7dev to test if that resolves the issue, but it looks like that didn't helped:
vagrant@php7dev:~$ phpext list
-bash: phpext: command not found
vagrant@php7dev:~$ php -m | grep xdebug
vagrant@php7dev:~$

It has been released 🎉
However I had already managed to install XDebug and use it with PhpStorm in the previous version, and after upgrading my VM to 1.0.0 (with XDebug included), it doesn't work anymore... 😢

Actually I have been trying things, and the problem is only when I'm using PHP 7.1 - if I do newphp 7 and use that, it works ok...
The most strange thing is with 7.1, it does recognise xdebug and it stops at the breakpoint in the index file, and also in my Controller class, but then it won't stop in other classes - I had never seen anything similar... I tried to find a pattern that makes it fail - e.g., when trying to step into a particular file/folder, when waiting for some time, or when the call stack is big - but I couldn't find any pattern...


Add chart variable system

placeholder

closing in lieu of https://github.com/patternfly/patternfly-next/issues/1723


File looses executable bit after editing through web interface

Gitea version (or commit ref): 1.8.1
Git version: n/a
Operating system: n/a
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL) https://try.gitea.io/jovandeginste/test/src/branch/master/script
[ ] No
[ ] Not relevant

Log gist:

Description
When I edit a file through Gitea's web interface, the file's modes are (re)set to 644, effectively losing the executable bit if it was set.
I understand that it's not trivial to change file modes through the web interface (eg. when creating new files), but I believe existing files should keep their modes.
The git log of the above repository:
commit 1635a011929aadf493be0863fb936f56b6ed4188
Author: Jo Vandeginste <Jo.Vandeginste@>
Date:   Tue Aug 6 11:42:38 2019 +0200

    Add an executable script

    Signed-off-by: Jo Vandeginste <Jo.Vandeginste@>

diff --git a/script b/script
new file mode 100755
index 0000000..516115d
--- /dev/null
+++ b/script
@@ -0,0 +1 @@
+Some command

commit b7aa45df3b4cb3a085e5b10cae36fbf4c8fed170
Author: jovandeginste <jo.vandeginste@>
Date:   Tue Aug 6 09:44:40 2019 +0000

    'script' updaten

diff --git a/script b/script
old mode 100755
new mode 100644
index 516115d..fa29636
--- a/script
+++ b/script
@@ -1 +1,3 @@
 Some command
+
+some edit
\ No newline at end of file

So... it just won't be fixed then? What a strange procedure!

hi,
can we get this issue fixed? This is really annoying, especially when you work on scripts for infrastructure.

+1 I can confirm this bug too
Running Gitea 1.9.5

Has this been fixed?

@jovandeginste Yes, we've just merged a PR fixing this on the master branch (which will become Gitea 12.0 eventually). See #10607.

It will be in version 1.11.2


provision_request returns a miq_request object instead of a hash of error and miq_request

https://bugzilla.redhat.com/show_bug.cgi?id=1447793
The provision request returns the miq_request object if there are no errors
else we raise an exception with the errors
Links

https://bugzilla.redhat.com/show_bug.cgi?id=1447793

https://github.com/ManageIQ/manageiq/pull/13972

Steps for Testing/QA
Described in BZ

@mkanoor Please address rubocop issues.

@gmcculloug Please review

Fine backport details:
$ git log -1
commit 19e141d971c758f848a56fd7dbca07eeae9a4be9
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Fri May 5 08:32:50 2017 -0400

    Merge pull request #14987 from mkanoor/bz_1447793

    provision_request returns a miq_request object instead of a hash of error and miq_request
    (cherry picked from commit 2b2aff4815afdb80c27a81e7708c097217f291f1)

    https://bugzilla.redhat.com/show_bug.cgi?id=1448506


Catch when modifiers are pressed in pyglet

If we want to catch a modifier being pressed, for example via
io.key_alt, we need to catch when the alt key is pressed by itself.
Pyglet fires events for the key press of alt, but in those cases it's
not flipped on in the modifiers argument.  (Conversely, it is on when
key release is fired when you let go of it.)
This catches that and sets the io attribute appropriately.

Coverage decreased (-0.02%) to 53.315% when pulling 62455b204d789a284189ad0175d458bb7bab950d on matthewturk:pyglet_modifiers into f9f45a5565e6f82d6c88482469f130d17d00b5b0 on swistakm:master.

Thanks for contribution!

Released as 1.3.0:

release notes
available distributions


Update annotations only if the key exists. If not create and update, Pretty JSON format

This is great, @poornima-krishnasamy
I think there is some room to make it a bit more idiomatic, and perhaps a bit easier to understand, by replacing some of the if statements with ruby method from the Array class.
So, where you've got this in list_ingresses_has_annotations (which I'd probably rename to ingresses_matching_class or something):
ingress_array = []
get_ingresses.map do |ingress|
  if ingress.dig("metadata").include?("annotations")
    if ingress.dig("metadata", "annotations", "kubernetes.io/ingress.class").to_s == target_ingress_class
      ingress_name = ingress.dig("metadata", "name")
      namespace = ingress.dig("metadata", "namespace")
      if check_is_production(namespace).include?("false")
        ingress_array.push({namespace: namespace, ingress_name: ingress_name})
      end
    end
  end
end
ingress_array

You're starting with an array of objects returned by get_ingresses, and return a list of {namespace: ..., ingress_name: ...} tuples.
Rather than if statements, you can do a lot with map, filter (or find_all if you're on ruby < 2.6) and reject (which is the inverse).
So, instead of if ingress.dig("metadata").include?("annotations"), you could filter the list like this:
get_ingresses.filter { |ingress| ingress.dig("metadata").has_key?("annotations")` }

The result of this is a list of ingress hashes which have an "annotations" key (you've used include?(key) called on a hash, which I didn't know you could do! I think hash.has_key?(key) is clearer here - it just answers the question "does hash have a key key? and returns true/false).
Once you've filtered the list of ingresses to find ones with annotations, you can just chain another filter on the end to match the class, like this:
list.filter { |ingress| ingress.dig("metadata", "annotations", "kubernetes.io/ingress.class").to_s == target_ingress_class }

So, so far, we can filter our ingress list like this:
get_ingresses
  .filter { |ingress| ingress.dig("metadata").has_key?("annotations")` }
  .filter { |ingress| ingress.dig("metadata", "annotations", "kubernetes.io/ingress.class").to_s == target_ingress_class }

But, I'm not sure you need to do this in 2 steps, because dig will return nil as soon as it fails to find a given key in the list of keys you're digging. So, the first filter statement is not needed, because dig("metadata", "annotations", "kubernetes.io/ingress.class") will return nil if there is no annotations key, and nil != target_ingress_class. So, this should work:
get_ingresses
  .filter { |ingress| ingress.dig("metadata", "annotations", "kubernetes.io/ingress.class").to_s == target_ingress_class }
  .map do |ingress|
    ...

You could also reduce duplication by extracting this common part to a method:
ingress_name = ingress.dig("metadata", "name")
namespace = ingress.dig("metadata", "namespace")
if check_is_production(namespace).include?("false")
  ingress_array.push({namespace: namespace, ingress_name: ingress_name})
end

Something like this:

ingress_array.push(non_production_tuple(ingress))

...

def non_production_tuple(ingress)
  ingress_name = ingress.dig("metadata", "name")
  namespace = ingress.dig("metadata", "namespace")
  if check_is_production(namespace).include?("false")
    {namespace: namespace, ingress_name: ingress_name}
  else
    nil
  end
end

Doing this means ingress_array ends up like this [ tuple1, nil, nil, tuple2, nil, ... ]
So, at the end of your method, return ingress_array.compact which will exclude all the nil elements, and return [tuple1, tuple2, ...]
There's more we could do here, but that's probably more than enough for now! Sorry this turned into a bit of an epic review ;)

Thanks @digitalronin. that was very helpful and in detail, I. would bookmark this review as a reference for ruby tips. I have changed the code to address this.


How to know if my CPU supports BLAS?

I am trying to run the project on Linux and I installed the library using following:
CMAKE_ARGS="-DLLAMA_BLAS=ON -DLLAMA_BLAS_VENDOR=OpenBLAS" pip install ctransformers

Q: How to know if my CPU supports BLAS?
Is there any way to know beforehand? I got no error, nothing.
Instance information
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              4
On-line CPU(s) list: 0-3
Thread(s) per core:  2
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               85
Model name:          Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
Stepping:            7
CPU MHz:             3105.462
BogoMIPS:            4999.98
Hypervisor vendor:   KVM
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
L3 cache:            36608K
NUMA node0 CPU(s):   0-3
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves ida arat pku ospke

One more note...
When I monitor the CPU usage while inference, it only uses 50% of the CPU.
Please help me get out of this.
Thanks!

How to know if my CPU supports BLAS?

you don't; blas is software

When I monitor the CPU usage while inference, it only uses 50% of the CPU.

increase threads


Hash package contents / mtime to detect cache miss

Right now, if you have a local package dependency such as symlink, esy will just rebuild everything any time you do esy build. esy should hash the package contents to detect if a rebuild is actually necessary.
I believe for local file system dependencies file://blah there are other issues with not detecting changes correctly perhaps.

Should we move issues over to reasonml/esy?

Yes, perhaps I just didn't know how to do that, and wanted to avoid having them spread out over two locations (do I have to do it manually)?


install on NAS

Hi, can you help? I try to install your P1 monitor plugin on my Homebridge installation on a Sinology NAS but without succes. I misses a lot of dependencies and cannot finish the install. I receive the following:

<EMAIL_ADDRESS>install
node-gyp-build

gyp ERR! build error
gyp ERR! stack Error: not found: make
gyp ERR! stack     at getNotFoundError (/volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:10:17)
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:57:18
gyp ERR! stack     at new Promise ()
gyp ERR! stack     at step (/volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:54:21)
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:71:22
gyp ERR! stack     at new Promise ()
gyp ERR! stack     at subStep (/volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:69:33)
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:80:22
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/isexe/index.js:42:5
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/isexe/mode.js:8:5
gyp ERR!
Bundled install / update could not complete. Trying regular install / update using npm.
USER: homebridge
DIR: /volume1/homebridge
CMD: npm install --save<EMAIL_ADDRESS>[##################] \ reify:@serialport/bindings-cpp: timing reifyNode:node_modules/h

<EMAIL_ADDRESS>install
node-gyp-build

gyp ERR! [##################] / reify:@serialport/bindings-cpp: timing reifyNode:node_mbuild error
gyp ERR! stack Error: not found: make
gyp ERR! stack     at getNotFoundError (/volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:10:17)
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:57:18
gyp ERR! stack     at new Promise ()
gyp ERR! stack     at step (/volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:54:21)
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:71:22
gyp ERR! stack     at new Promise ()
gyp ERR! stack     at subStep (/volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:69:33)
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/which/which.js:80:22
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/isexe/index.js:42:5
gyp ERR! stack     at /volume1/@appstore/homebridge/app/lib/node_modules/npm/node_modules/isexe/mode.js:8:5
gyp ERR!   Please review log for details.

I’m afraid I cannot help here.  Homebridge P1 uses the serialport repo to interact with the USB serial port provided by the P1 cable.  serialport uses a C++ module that needs to be compiled for each system.  It provides pre-compiled binaries for the most common platforms, but, obviously, not for Synology DSM.
I’ve been contemplating ditching serialport altogether, in favour of ser2net, but that doesn’t run on Synology DSM either.  You would still need a Raspberry Pi or another system to expose the serial port over the network.

gyp ERR! stack Error: not found: make

To start with, it's make that's missing (and after that, C++ compiler and...)
So I guess you have to install build-essentials, however, not sure if it is OK to install all this on NAS

ok, i see. So no P1 monitor on the Synology then.
Thanks for your response! I'll close this one.


Update sbt-native-packager to 1.7.6

Updates com.typesafe.sbt:sbt-native-packager from 1.4.1 to 1.7.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.sbt", artifactId = "sbt-native-packager" } ]

labels: sbt-plugin-update, semver-minor

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   71.64%   71.64%
=======================================
  Files          21       21
  Lines        1132     1132
  Branches       16       16
=======================================
  Hits          811      811
  Misses        321      321

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ed170...0b22638. Read the comment docs.


⬆ UPGRADE: Autoupdate pre-commit config

Base PullRequest
default branch (https://github.com/nbQA-dev/nbQA/tree/master)
Command results

Details:

add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/bin

pip install pre-commit
Collecting pre-commit
  Using cached pre_commit-2.7.1-py2.py3-none-any.whl (171 kB)
Collecting cfgv>=2.0.0
  Using cached cfgv-3.2.0-py2.py3-none-any.whl (7.3 kB)
Collecting identify>=1.0.0
  Using cached identify-1.5.6-py2.py3-none-any.whl (97 kB)
Collecting toml
  Using cached toml-0.10.1-py2.py3-none-any.whl (19 kB)
Processing /home/runner/.cache/pip/wheels/69/60/81/5cd74b8ee068fbe9e04ca0d53148f28f5c6e2c5b177d5dd622/PyYAML-5.3.1-cp39-cp39-linux_x86_64.whl
Collecting nodeenv>=0.11.1
  Using cached nodeenv-1.5.0-py2.py3-none-any.whl (21 kB)
Collecting virtualenv>=20.0.8
  Downloading virtualenv-20.1.0-py2.py3-none-any.whl (4.9 MB)
Collecting filelock<4,>=3.0.0
  Using cached filelock-3.0.12-py3-none-any.whl (7.6 kB)
Collecting six<2,>=1.9.0
  Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
Collecting distlib<1,>=0.3.1
  Using cached distlib-0.3.1-py2.py3-none-any.whl (335 kB)
Collecting appdirs<2,>=1.4.3
  Using cached appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
Installing collected packages: cfgv, identify, toml, pyyaml, nodeenv, filelock, six, distlib, appdirs, virtualenv, pre-commit
Successfully installed appdirs-1.4.4 cfgv-3.2.0 distlib-0.3.1 filelock-3.0.12 identify-1.5.6 nodeenv-1.5.0 pre-commit-2.7.1 pyyaml-5.3.1 six-1.15.0 toml-0.10.1 virtualenv-20.1.0

stderr:
WARNING: You are using pip version 20.2.3; however, version 20.2.4 is available.
You should consider upgrading via the '/opt/hostedtoolcache/Python/3.9.0/x64/bin/python -m pip install --upgrade pip' command.

pre-commit autoupdate || (exit 0);
Updating https://github.com/pre-commit/pre-commit-hooks ... [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
updating v3.2.0 -> v3.3.0.
Updating https://github.com/pre-commit/pre-commit ... already up to date.
Updating https://github.com/python/black ... already up to date.
Updating https://github.com/prettier/prettier ... already up to date.
Updating https://github.com/PyCQA/pylint ... already up to date.
Updating https://gitlab.com/pycqa/flake8 ... already up to date.
Updating https://github.com/PyCQA/isort ... already up to date.
Updating https://github.com/PyCQA/pydocstyle ... already up to date.
Updating https://github.com/econchick/interrogate ... already up to date.
Updating https://github.com/pre-commit/mirrors-mypy ... already up to date.
Updating https://github.com/asottile/pyupgrade ... [INFO] Initializing environment for https://github.com/asottile/pyupgrade.
updating v2.7.2 -> v2.7.3.
Updating https://github.com/codespell-project/codespell ... already up to date.
Updating https://github.com/terrencepreilly/darglint ... already up to date.

pre-commit run -a || (exit 0);
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/asottile/pyupgrade.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Fix End of Files.........................................................Passed
Fix requirements.txt.....................................................Passed
Trim Trailing Whitespace.................................................Passed
Debug Statements (Python)................................................Passed
Validate Pre-Commit Manifest.............................................Passed
black....................................................................Passed
prettier.................................................................Passed
pylint...................................................................Passed
flake8...................................................................Passed
isort....................................................................Passed
pydocstyle...............................................................Passed
interrogate..............................................................Passed
mypy.....................................................................Passed
pyupgrade................................................................Passed
codespell................................................................Passed
darglint.................................................................Passed

Changed files

Changed file:

.pre-commit-config.yaml

:octocat: Repo | :memo: Issues | :department_store: Marketplace

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #376   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          477       477
=========================================
  Hits           477       477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19cd9c6...d23459e. Read the comment docs.

Good bot!


Support for "completion mode"?

I've been hacking my way around different completion plugins to support my approach for completion, and I realize this may be something others may be interested in, I don't know. Basically, I use completion in manual mode, until I don't lol The idea is that whenever I start completion, I want to enable autocomplete/as you type completion, then disable it again when I exit insert mode. So it's basically a transition from normal mode, to insert mode and then to insert mode with autocomplete enabled (which I'm calling "completion mode" here).
I've recently migrated to nvim-cmp and tried a similar approach to what I did in nvim-compe (set autocomplete to true when starting completion), but that doesn't seem to work, even after I set autocompl. Before figuring out how to make it work for myself, I wanted to check if this is something you'd be interested in supporting more directly.
My previous approach with nvim-compe: https://github.com/fsouza/dotfiles/blob/a0f215977b4d480d6d2fdcdfaeac092a95db9fcb/nvim/lua/fsouza/lsp/completion.lua#L43-L52
Current one with nvim-cmp: https://github.com/fsouza/dotfiles/blob/13f57c03d4637bd574adda6d62c135c52ac1a3e0/nvim/lua/fsouza/lsp/completion.lua#L50-L60
I did some preliminary investigation and noticed that the "issue" is that the context isn't considered changed here, so I get the following logs if I enable debug mode:
>>> TextChanged
ctx: `^Ic`
unchanged

Again, feel free to ignore this if you don't feel like this is a feature that makes sense, I can figure something out :D

@fsouza I've fixed the issue. I think your expected behavior can realize by the following config.
autocmd vimrc InsertEnter * call s:on_insert_enter()
function! s:on_insert_enter() abort
lua <<EOF
local cmp = require'cmp'
cmp.setup.buffer {
  completion = {
    autocomplete = false,
  },
  mapping = {
    ['<C-Space>'] = function(fallback)
      cmp.setup.buffer {
        completion = {
          autocomplete = { cmp.TriggerEvent.TextChanged }
        },
        mapping = {
          ['<C-Space>'] = cmp.mapping.complete()
        }
      }
      print(vim.inspect(require('cmp.config').get().completion))
      cmp.complete()
    end
  }
}
EOF
endfunction

Thank you very much for the very quick fix!


Map table and column names to original cell letters

Add a mapping to map table and column to original excel column letter. This can be used insed to_message functions to get original letters to be displayed this should be combined with row indexes in a seperate PR, as well as add adequate test coverage for this.
Change description
A brief description of the pull request

[ ] Unit tests and other appropriate tests added or updated
[ ] README and other documentation has been updated / added (if needed)
[ ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

There's a bit of a convoluted way to test this by looking at the position of a given column, taking its index, and converting it into the letter it should represent.
Should we add the column letters to the failure messages when we can't verify, test, or use them yet?
Otherwise, looking good, I can't see any mistakes in the mapping, I will manually check again.

There's a bit of a convoluted way to test this by looking at the position of a given column, taking its index, and converting it into the letter it should represent.
Should we add the column letters to the failure messages when we can't verify, test, or use them yet?
Otherwise, looking good, I can't see any mistakes in the mapping, I will manually check again.

On second thought, there's no point testing the actual data structure, but we could separate out just putting in the mapping of values and changing of the validation messages to include their original column values (which will require changing the tests).

).

Good point, I think I will reveret some of this PR, just to contain the mapping and leave how we use the maaping for a future PR


Fix core windows build that was failing when building coreclr

Coreclr build.cmd arguments order seems to matter in Windows. Since -PortableBuild=[true,false] is defined in config.json and passed all the way through run.exe the arguments after it (in Windows case -nopgooptimized) where passed into run.exe instead of being parsed by build.cmd. Causing this to failure saying -nopgooptimized is an invalid switch.
Submitting the PR to see non-windows builds still work.
cc: @weshaggard

Seems like a safe change, but I'm not sure what's driving this PR. At the moment I think we'll want to wait until 2.1 ships to do any improvements to make source-build more buildable on Windows.
/cc @crummel @dseefeld @dleeapho

Seems like a safe change, but I'm not sure what's driving this PR. At the moment I think we'll want to wait until 2.1 ships to do any improvements to make source-build more buildable on Windows.

@dleeapho  Can we merge the dev/release/2.1 branch into master and do work for my MQ source-build stuff there?

Closing this PR since this work is going to be done in master.


Daily update

Automated changes by create-pull-request GitHub action

Build failed because of:
no headquarter addresses for red-panda at https://www.crunchbase.com/organization/red-panda
No cached entry, and The Ritsumeikan Trust has issues with twitter: https://twitter.com/RitsARC, Request failed with status code 400
No cached entry, and Research Institutes of Sweden has issues with twitter: https://twitter.com/RISEsweden, Request failed with status code 400
No cached entry, and Sollers College has issues with twitter: https://twitter.com/SollersEdu, Request failed with status code 400
No cached entry, and Open Sourcing Mental Illness, LTD has issues with twitter: https://twitter.com/osmihelp, Request failed with status code 400
No cached entry, and NIAB has issues with twitter: https://twitter.com/NIABEMR, Request failed with status code 400
No cached entry, and Open Compute Project has issues with twitter: https://twitter.com/OpenComputePrj, Request failed with status code 400
No cached entry, and iRespond Global has issues with twitter: https://twitter.com/iRespond, Request failed with status code 400
No cached entry, and Galgotias University has issues with twitter: https://twitter.com/GalgotiasUni, Request failed with status code 400
No cached entry, and Yazaki Corporation has issues with twitter: https://twitter.com/@YazakiNA, Request failed with status code 400
No cached entry, and Zeeve Inc has issues with twitter: https://twitter.com/ZeeveDeeptech, Request failed with status code 400
No cached entry, and Union.ai has issues with twitter: https://twitter.com/union_ai, Request failed with status code 400
No cached entry, and Uffizzi has issues with twitter: https://twitter.com/Uffizzi_, Request failed with status code 400
No cached entry, and TietoEVRY has issues with twitter: https://twitter.com/Tietoevry, Request failed with status code 400
No cached entry, and True B.V. has issues with twitter: https://twitter.com/true_nl, Request failed with status code 400
No cached entry, and Super Micro Computer, Inc. has issues with twitter: https://twitter.com/Supermicro_SMCI, Request failed with status code 400
No cached entry, and Sonatus, Inc. has issues with twitter: https://twitter.com/SonatusHQ, Request failed with status code 400
No cached entry, and SICPA SA has issues with twitter: https://twitter.com/SICPA_enEspanol, Request failed with status code 400
No cached entry, and Seekret Software Security Ltd. has issues with twitter: https://twitter.com/SeekretSoftware, Request failed with status code 400
No cached entry, and Rakuten Group, Inc. has issues with twitter: https://twitter.com/Rakuten, Request failed with status code 400
No cached entry, and ScoutAPM has issues with twitter: https://twitter.com/ScoutAPM, Request failed with status code 400
No cached entry, and ProfiSea has issues with twitter: https://twitter.com/ProfiSea, Request failed with status code 400
No cached entry, and Palm NFT Studio has issues with twitter: https://twitter.com/PalmNft, Request failed with status code 400
No cached entry, and Pionix GmbH has issues with twitter: https://twitter.com/PionixDe, Request failed with status code 400
No cached entry, and Okteto has issues with twitter: https://twitter.com/oktetohq, Request failed with status code 400
No cached entry, and Optic has issues with twitter: https://twitter.com/useoptic, Request failed with status code 400
No cached entry, and OnGres has issues with twitter: https://twitter.com/ongresinc, Request failed with status code 400
No cached entry, and Mondoo has issues with twitter: https://twitter.com/MondooLabs, Request failed with status code 400
No cached entry, and MDxBlocks Inc. has issues with twitter: https://twitter.com/MDxBlock, Request failed with status code 400
No cached entry, and mogenius has issues with twitter: https://twitter.com/mogenius, Request failed with status code 400
No cached entry, and Mycelial has issues with twitter: https://twitter.com/mycelial, Request failed with status code 400
No cached entry, and Lightspin has issues with twitter: https://twitter.com/LightspinTech, Request failed with status code 400
No cached entry, and Lightrun Ltd has issues with twitter: https://twitter.com/Lightruntech, Request failed with status code 400
No cached entry, and lightlytics has issues with twitter: https://twitter.com/lightlytics, Request failed with status code 400
No cached entry, and KUKA Deutschland GmbH has issues with twitter: https://twitter.com/KUKA_Press, Request failed with status code 400
No cached entry, and KSOC has issues with twitter: https://twitter.com/ksoclabs, Request failed with status code 400
No cached entry, and iSoftStone Information Technology (Group) Co., Ltd has issues with twitter: https://twitter.com/iSoftStone, Request failed with status code 400
No cached entry, and JVC KENWOOD Corporation has issues with twitter: https://twitter.com/JVCKENWOOD_SR, Request failed with status code 400
No cached entry, and Itopia has issues with twitter: https://twitter.com/itopia_GCP, Request failed with status code 400
No cached entry, and IO Builders Blockchain Technologies & Ventures has issues with twitter: https://twitter.com/iobuilders, Request failed with status code 400
No cached entry, and Honor Device Co. Ltd has issues with twitter: https://twitter.com/Honorglobal, Request failed with status code 400
No cached entry, and GotoAdmins has issues with twitter: https://twitter.com/gotoadmins, Request failed with status code 400
No cached entry, and Globant LLC has issues with twitter: https://twitter.com/Globant, Request failed with status code 400
No cached entry, and GitLab Inc. has issues with twitter: https://twitter.com/gitlabhq, Request failed with status code 400
No cached entry, and Fournine Cloud Solutions has issues with twitter: https://twitter.com/CloudFournine, Request failed with status code 400
No cached entry, and FlexiDAO has issues with twitter: https://twitter.com/flexidao, Request failed with status code 400
No cached entry, and Equideum Health has issues with twitter: https://twitter.com/equideumhealth, Request failed with status code 400
No cached entry, and Era Software, Inc. has issues with twitter: https://twitter.com/era, Request failed with status code 400
No cached entry, and DataCore Software has issues with twitter: https://twitter.com/DataCore, Request failed with status code 400
No cached entry, and Datachain, Inc. has issues with twitter: https://twitter.com/datachain_en, Request failed with status code 400
No cached entry, and DevSamurai has issues with twitter: https://twitter.com/devsamurai_com, Request failed with status code 400
No cached entry, and Cybeats has issues with twitter: https://twitter.com/cybeatstech, Request failed with status code 400
No cached entry, and CoolIT Systems Inc. has issues with twitter: https://twitter.com/CoolITSystems, Request failed with status code 400
No cached entry, and Comcast Cable Communications, LLC (Xfinity) has issues with twitter: https://twitter.com/Xfinity, Request failed with status code 400
No cached entry, and Coinbase Inc. has issues with twitter: https://twitter.com/coinbase, Request failed with status code 400
No cached entry, and Cribl Inc has issues with twitter: https://twitter.com/cribl_io, Request failed with status code 400
No cached entry, and CodeWave has issues with twitter: https://twitter.com/Codewave_Inc, Request failed with status code 400
No cached entry, and Code Zero Technologies Inc has issues with twitter: https://twitter.com/codezeroio, Request failed with status code 400
No cached entry, and Clastix SRL has issues with twitter: https://twitter.com/clastix, Request failed with status code 400
No cached entry, and Checkmarx has issues with twitter: https://twitter.com/Checkmarx, Request failed with status code 400
No cached entry, and Catalogic Software has issues with twitter: https://twitter.com/CatalogicSW, Request failed with status code 400
No cached entry, and Bonifii has issues with twitter: https://twitter.com/BonifiiOfficial, Request failed with status code 400
No cached entry, and BMW has issues with twitter: https://twitter.com/BMWGroup, Request failed with status code 400
No cached entry, and Block, Inc. has issues with twitter: https://twitter.com/blocks, Request failed with status code 400
No cached entry, and Beijing Kingsoft Cloud Internet Technology has issues with twitter: https://twitter.com/KINGSOFT_PR, Request failed with status code 400
No cached entry, and Beijing Fourth Paradigm Intelligent Technology Co., Ltd. has issues with twitter: https://twitter.com/paradigm4, Request failed with status code 400
No cached entry, and Argonaut has issues with twitter: https://twitter.com/Argonaut_Dev, Request failed with status code 400
No cached entry, and Baumer Management Services AG has issues with twitter: https://twitter.com/baumergroup, Request failed with status code 400
No cached entry, and Arvancloud has issues with twitter: https://twitter.com/ArvanCloud, Request failed with status code 400
No cached entry, and across.cloud has issues with twitter: https://twitter.com/AcrossCloud, Request failed with status code 400
No cached entry, and Althea has issues with twitter: https://twitter.com/AltheaNetwork, Request failed with status code 400
No cached entry, and Absa Bank Limited has issues with twitter: https://twitter.com/AbsaSouthAfrica, Request failed with status code 400
Redpanda either has no crunchbase entry or it is invalid


Issue2207

Fixes #2207
This adds a script that uses the GitHub API to log download metrics on our release assets.  It generates a plot showing the trend of our downloads for each OS.
This script can be run for any repository by modifying the variables located at the top.
It can also be run by CircleCI at an arbitrary frequency to collect and post the metric data.
To use:

python /VAPOR/scripts/metrics.py

Scott, this looks great. But I’ve been running it for 20 minutes and it hasn’t returned anything. Is that expected?
thanks - jc

On Feb 5, 2020, at 12:02 PM, sgpearse<EMAIL_ADDRESS>wrote:
@sgpearse requested your review on: #2212 Issue2207.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

It should print one of two things:

A message that the GitHub API request failed
Info on the total downloads, and a new window with a plot

The script terminates in the case of 1.  It also terminates after the plot window is closed.
If it's not reporting anything after 20 minutes, then that's not right.  But it's possible that your plot window is still open somewhere, so the script is waiting for it to close.

I can't find any open plot windows. The script just hangs and does not print anything.
Also, do you want the pickle file included in this PR

I think you may not be specifying which python executable to use.  I previously had the usage stated as follows:

python /VAPOR/scripts/metrics.py

But I just went ahead and added a shebang line to specify the first python3 found in the user's path.  You can now launch it by just typing the script name.

PS - The pickle file holds all of the data for our metrics, so we can generate a time series.  GitHub's API only allows us to gather the current number of downloads, so we need to log our queries somehow.  Pickle files let us save logs and restore them later.

Still confused. Does the pickle file need to be in the  repo?

On Feb 5, 2020, at 1:52 PM, sgpearse<EMAIL_ADDRESS>wrote:
PS - The pickle file holds all of the data for our metrics, so we can generate a time series. GitHub's API only allows us to gather the current number of downloads, so we need to log our queries somehow. Pickle files let us save logs and restore them later.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Got there in the end.


jnxplus/nx-boot-maven init fails

nx-boot-maven:init generator fails when running on an empty repo.
Reproduce steps

Create a new workspace npx create-nx-workspace@latest name
Install nx-boot-maven plugin npm install --save-dev @jnxplus/nx-boot-maven
Try to initialise the parent module npx nx g @jnxplus/nx-boot-maven:init

Result
> NX Cannot find .prettierrc

Nx Version: v15.9.2
jnxplus/nx-boot-maven Version: 5.1.1

I have seen that this plugin expects .prettierrc
.prettierignore to present in the workspace when calling init.
I would change the code to check first if the file exists before modifying them. Prettier will most likey not be present in a non js/ts workspace

@cladera, @jbadeau Now I fixed this issue in the 5.2.2 version.

Thanx fir the great support by the way


fix(mergeWizard): insert element at valid position

The merge wizard was implemented before our "choose a valid position
automatically" feature was implemented for insert and move actions in
Editing (reference: undefined).
Therefore, all insert actions fired by the merge wizard insert the
element at as the parent's last child, resulting in schema invalid files
in many cases (e.g. insert a Substation section in a file with an IED or
DataTypeTemplates). This fixes that issue, making our Merge and
UpdateSubstation plugins schema compliant.

@JakobVogelsang this itty bitty bug fix is still looking for a bug issue and a regression test. If you find the time, I'd much appreciate you adding them. Otherwise I'll do it myself next week at the latest.

Closes #890

This functionality is not tested at all - schame on me :(. So adding regression tests means adding fresh tests and that is a bigger issue. I would therefore add the fix as it is a pretty obvious one and create another issue to add tests for this functionality. @ca-d what you think?

See #892


No window appears

Hi,
Thanks for the toolbox. I wanted to try out the calibration and I have followed your instructions. However, even tough kinect2_bridge starts properly and I do get expected messages in terminal. No image viewer windows appears. I mean there is no visual.
I tried to start the registration viewer. It says starting receiver but again no window.
Do you have any idea what might be the cause ?

And in protonect from libfreenect2, I have windows appearing and also  successful visual data.

What do the log messages for depth and color say? What it the frame rate of both?
The windows are created as soon as the first frame is received. If no windows are created, then it is still waiting for frames to arrive.

That was the thing! I did not get any warning or error. And frames were arriving just fine.
Anyway, I did a clean install of ros. I think it was due to somehow messed up compressed_image_transfer plugin. I have just successfuly run color calibration.
When kinect2_bridge is run, no window should appear right?
Danke und Grüsse

Good to hear that it's working now. Yes, kinect2_bridge does not open any windows.

Well, now I got a segmentation fault.
I have completed calibration steps until depth calibration. But in depth calibration, I get the following error:
/home/bellekci/ros_catkin_ws/devel_isolated/rosbash/bin/rosrun: line 4: 27288 Segmentation fault      (core dumped) "/home/bellekci/ros_catkin_ws/src/ros/rosbash/scripts/rosrun" "$@"
I tracked the error and it is due to this line in compareDists function:
<< "  median: " << diffs[diffs.size() / 2] << std::endl;
The reason it gives segmentation fault is that diffs.size is 0. Because imageDists.size is 0.
I have seen that nothing gets added to the imageDists and depthDists vectors in computePointDists function.
It is probably due to the two if statements which force for loop to skip.
In other words, all of my data returns true in at least one  of  the next two conditions :
if(dDist < 0.1)
if(std::abs(diff) > 0.08)
What do you think of that?

I think I am making progress. You have probably thought that difference cannot be larger than 8cm and thus placed the if(std::abs(diff) > 0.08) check.
In my case, diff is always larger than 2m. The reason is that planeDistance is calculated as 3.32395m and the chessBoard is about at 1.3m which is fine. So, planeDistance is not correct.

Miscalculation of the planeDistance is very probably due to the fact that my kinect2 is looking downwards and ground plane is recognized instead of the chessboard plane.
I have seen that you are getting the region-of-intereset with your computeROI function but this does not seem to correspond to the chessboard, am I right?
Plus, the output ROI is not used in getPlane function. So, solvePnPRansac must be returning a faulty rotation vector in my case and finally a wrong distance to the plane.

So I have placed chessboard at different positions on ground and repeated the calibration steps. However, I am still getting 3.5 m as the planeDistance. I have no idea why.

Could it be that you passed a wrong size for the pattern? What pattern are you using, what are the dimensions, and to what was the parameter on the command line set?
The plane is calculated from the points on the pattern, it does not detect anything else. The two if statements are used to filter out invalid points (noise). The first one filters out everything that is near zero and the second one filters out all depth values that are not in between +/- 8 cm around the calculated distance.
It is also important to run the ir calibration prior to the depth calibration.

I do not think so. I have used the one you suggested chessboard5x7x0.03.
I have also confirmed that the size of edges are 0.03 as requested.
I have just uploaded my last samples and here is the link:
https://drive.google.com/file/d/0B6WiFqTOIhcfVEg0dm9zYUxQckE/view?usp=sharing
You can give it a try and let me know if my data is somehow wrong. Thanks.

I looked at the files and noticed that there is something wrong. The intrinsic parameters of the color and the ir sensor are totally off. For the ir the focal length should be ~366 and ~1060 for the color sensor.
Your results are 920 and 5000. This would explain why the depth calibration has problems to find valid points. I don't know why it found values that are so big. I just copied the intrinsic parameters of one of the kinects I use, and the depth calibration works fine.
There are a couple of things you could try. Glue the pattern on a flat non-flexible plate, for example with a pritt stick. Take more images, from different distances (0.6 to 1.3 m) and with different rotations, not just rotation around z, also around x and y axis. You could use a tripod to hold the pattern. And try to place the pattern also near the corners of image area.

OK I will give it another go.
Do you think would it make a difference to move the camera closer to or away from the object instead of moving the object?

That works as well.

I have collected 50 new frames and repeated color calibration.
I have rotated in x y domain but also in z domain too meaning the pattern was not parallel to the camera in some conditions as you have said. The results I am getting are as follow:
´error: 0.244091
Camera Matrix:
[1122.954624015307, 0,<PHONE_NUMBER>51898;
0, 1121.299450091302,<PHONE_NUMBER>949537;
0, 0, 1]
Distortion Coeeficients:
[0.05917318195316226, -0.0222640363528383, 0.001712035826921513, -0.00503893035660427, -0.01847429183100217]´
so fx is 1123. Is that fine ?

I have also collected 100 new frames for IR as you said but did not get good results.
error: 0.102318
Camera Matrix:
[1086.418288331477, 0,<PHONE_NUMBER>936668;
0, 1094.2196422849,<PHONE_NUMBER>614918;
0, 0, 1]
Distortion Coeeficients:
[0.9994792108812481, -22.85798595131196, -0.006675062443077072, -0.02544958247078666, 60.7512906858388]
I do not know what is wrong. For reference, here is the link for my samples:
https://drive.google.com/file/d/0B6WiFqTOIhcfVk5TUGRaNDhjQm8/view?usp=sharing

OK. I got it. I have redone everything but this time in every sample I have inclined the chessboard. In previous trials, I was mostly keeping chessboard parallel to the camera because I thought that would result the best calibration results.
After I have done calibration, the focal length of ir is calculated as 356.

Hi.
I looked at your calibration images. I think the main problem is that on the IR pictures, your calibration pattern seems to always be on the same plane. You keep rotating them around the center of the calibration pattern, but that has little effect. On the RGB images, that is also mostly true, except for 3 or 4 where the calibration pattern was inclined respect to the camera, you want more of those.
Please watch this video:
https://www.youtube.com/watch?v=iEjH244KRbw
On that video, they use the new Halcon calibration patterns, that should completely cover the image. Ignore that part, using the normal OpenCV calibration pattern, the pattern should cover from approx 20% to 90% of the image. (So you have to get closer and farther away from the sensor).
The most important thing to learn about that video is how you have to tilt the pattern relative to the camera. They use a little wedge, and get images where the pattern has been tilted around the four directions. We tilt our calibration patterns even more, maybe 40 degrees.
Another detail is that for calibrating the intrinsics of the IR (The first step, that seems to be giving you problems), you can hold the calibration pattern in your hand.
Please try getting better calibration images, and run the calibration again.
Greetings!

Thanks @amaldo  for the help.
I have done what you have just suggested (as I have stated just before you posted) but now I started to think that maybe I have done too much tilting. I am pretty sure that I have tilted more than 40 degrees in many cases. Would that also harm the results? 356 is still a bit off from 366 as reported in Table 9  in this paper:
http://www.int-arch-photogramm-remote-sens-spatial-inf-sci.net/XL-5-W4/93/2015/isprsarchives-XL-5-W4-93-2015.pdf

I think that is close enough. These sensors can be a bit different from each other, that is why we do the calibration.
If you can still see the complete pattern in all the images, you should be fine. If you have inclined some of them so much that the intersections between black and white are no longer visible, those images will probably get thrown out by the calibration software anyway.
The important thing is that the calibration pattern is really flat. Companies usually use profesionally made patterns, glued on a sandwhich of aluminum and foam, to ensure flatness.
So check that your glue is not coming off, or that you have bubbles.
Also good lighting on the RGB images (soft light, no bright reflections on the images).
If you upload your pictures again, I can have a look to tell you if they look ok.
Greetings!

356 seems to be much better then before. With the latest calibration of one of our sensors I got 365 for fx and 363 for fy. The sensors are not all the same, but they should result pretty similar values. So there is probably space for improvements. Rotations of more then 40 degrees should be fine as long as the pattern is still recognized and the detected point really lie in the corners of the pattern (should be visible in the GUI).
It might help to imagine a grid of for example 5x4 field which overlays the image. Then position the pattern in the top left field, take a image and move it to the next field. At the end of one row, move it on field down and take images from that row, etc. Then rotate the pattern in a different manner (or place it at a different distance) and repeat it again. This usually results in a good calibration.

I have glued it onto a flat board. Here is my data: (100 images for color and ir)
https://drive.google.com/file/d/0B6WiFqTOIhcfUFgyelo2VnhDcVU/view?usp=sharing

I have re-run kinect2_bridge after calibration but data is not meaningful. I suppose my calibration was still not properly done.

What do you mean with "not meaningful"?

Well, there is nothing visible in the point cloud when I run viewer.
I have also incorporated the calibration results to protonect example and overwritten the IrCameraParams and the resulting point cloud is some weird data. Probably, those weird points get filtered in your viewer.

The viewer has a point cloud and a image view. How does the image look like? Do the borders of objects fit to the depth image? Is far as I know Protonect is not showing any point clouds.
Did you copied the calibration files to kinect2_bridge/data/<serialnumber>/? and restarted kinect2_bridge?

Yes , I did copy and restart the kinect2_bridge. In the beginning, I can see that my calibration data is read with following print in terminal:
camera parameters used:
camera matrix color:
[1051.847775732713, 0,<PHONE_NUMBER>114121;
0, 1053.880705503419,<PHONE_NUMBER>684801;
0, 0, 1]
distortion coefficients color:
[0.04057789315071465, -0.04128195232054094, 0.001108985127145222, 0.003555978800049442, 0.002421125128892641]
camera matrix ir:
[356.2164615979822, 0,<PHONE_NUMBER>844542;
0,<PHONE_NUMBER>176692,<PHONE_NUMBER>460727;
0, 0, 1]
distortion coefficients ir:
[0.09359137443536884, -0.2824486250826749, 0.001094532756217535, -0.001267718882340789, 0.1210202181680398]
rotation:
[1, 0, 0;
0, 1, 0;
0, 0, 1]
translation:
[-0.052;
0;
0]
depth shift:
-32.2154
Yes, protonect does not have point clouds but I am converting the data to pointcloud. IR image is completely dark blue. No detail.

You probably mean the visualization of the depth image in the registration viewer is all blue, right? On your last images there was depth information in the images. You could check if the images are all zero with rostopic echo -n 1 /kinect2/depth/image. Could you provide some screenshots? You can create some with the registration viewer by pressing SPACE or s.

True, depth image was all blue.
Depth images seemed fine but I will let you know if they were all zero and provide screenshots.

I managed to get meaningful calibration results by switching to a different checker board. The one with the smallest square size (chess9x11x0.02.pdf).
I have also compared my calibrated data and windows sdk.
First of all, I have checked if I am getting the same 3d view with libfreenect2 when I use the intrinsic parameters from windows sdk. There must be some discrepancy between windows sdk and libfreenect2 calculations because in windows SDK, the shape of the image is more rectangular but with libfreenect2 image is more bended, i.e. corners are stretched.
I have also checked whether my calibration data fixed this situation. Although, it seemed better than windows intrinsics, it was still worse compared to the windows SDK. I will try add some snapshots.


chore(deps): update root yarn.lock

Description
Please explain the changes you made here.
Missed updating cross-spawn in root yarn.lock
CVE-2024-21538
Which issue(s) does this PR fix

Fixes #?
RHIDP-4864

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Tested on PR build and verified the OCM and kubernetes views are functional:
RHDH Version: 1.3.2
Backstage Version: 1.29.2
Last Commit: janus-idp/backstage-showcase/pull/2025 @ dfd1d7cf
Build Time: 2024-11-29T16:45:09Z


Filter frames

Another feedback I've got says that it would be useful to filter the frame list and display only those that represents actual user messages. This would make easier to follow e.g. Socket IO traffic, which is constantly sending ping/pong frames.
Honza

@esphen What do you think?
Honza

@janodvarko
Yeah, it's been annoying me at work too. We send ping and pong frames once every 30 sec or so, even though we don't use Socket.IO :)
I think in some circumstances it would be useful to see the ping frames, i.e. when you're implementing the ping functionality. So we could say that the user can enable the ping frames with a pref in the addons panel.
What do ping frames in the different protocols look like. What should we hide?
At work we use simple frames that say ping or pong, so exact matches on those can be filtered out.
Are these 1B frames socket.io ping frames?

What about Sock.JS and WAMP? Do you know any conventions for pinging?
I can have a look at some way to implement this when I get time. This weekend maybe.

I think in some circumstances it would be useful to see the ping frames,

Definitely. I wasn't thinking about hiding these frames entirely, but rather provide a UI that allows the user to do that if wanted.

What do ping frames in the different protocols look like? What should we hide?

Of course, there can be many 'ping' messages, protocol based or custom like you have...
It's currently possible to filter frames using search box in the toolbar. Fox example, if you type tweet into it, only frames with tweat string in the payload will be displayed. Perhaps we could make this filter box smarter and allow to filter out frames that represents a 'ping' message.
I don't know about the syntax, but e.g. !ping would hide all frames with ping in the payload?
Or ! would hide frames with empty content? Are there any existing tools we could take an inspiration from. Does Wireshark have any standard syntax for filtering?
We might want to remember the filter in the UI (directly in the search box or in a recent filter list?)  so, it's simple to set it again the next time.
Honza

@janodvarko

I don't know about the syntax, but e.g. !ping would hide all frames with ping in the payload?

Netmonitor uses something like this. They have a - syntax where you can write -ping to get anything that does not contain ping. We could do that to stay consistent with our sibling tools.

Does Wireshark have any standard syntax for filtering?

Yes, they got a brief introduction here. They use == with values on fields to confer equality, ! to negate expressions, and have predefined protocols like smb that only show samba traffic. It seems like a very intricate system, and albeit powerful, may be a bit overkill for us.

Or ! would hide frames with empty content?

I think !ping could hide both empty messages and ping, so the user wouldn't have to write something like !ping ! !pong which looks quite silly.
Speaking of which, should the user be allowed to enter several of these filters? How do we handle that? One suggestion is to use commas to separate expressions, i.e. !ping,!pong. Alternatively we can do what Wireshark does and use &&. Thoughts?

We might want to remember the filter in the UI (directly in the search box or in a recent filter list?)

Sure, we can do this with simple storage or similar. What is more interesting is how we would display them in the GUI. I was reminded of your suggestion in a different issue earlier to make a box like in the debugger panel. We could do something like that?
I drew a sketch of the idea. Please excuse the SUPER rough draft; I'm not a graphical designer :smile:

Would be just nice to have an option in the settings for hiding ping-pong requests. Standard websockets send them every 10 seconds so it's would be great to have it.

Netmonitor uses something like this. They have a - syntax where you can write -ping to get anything that > does not contain ping. We could do that to stay consistent with our sibling tools.

I like the idea

I think !ping could hide both empty messages and ping, so the user wouldn't have to write something like
!ping ! !pong which looks quite silly.

Also agree

Speaking of which, should the user be allowed to enter several of these filters? How do we handle that?
One suggestion is to use commas to separate expressions, i.e. !ping,!pong.

Commas sounds good to me.
I also like the screenshot (with popup box). We can do it in a second step (also such UI could be reused in the Net panel).
Honza


Refactor dyn Value

Context
dyn Value currently implements all the methods from dyn Any. We can avoid having to implement these methods and simplify the api by adding an as_any method that casts from Value to  dyn Any.
Description
add the as_any and as_any_mut methods to the Value trait

Manually testing the PR
ran the hello world example and confirmed that it works

LGTM


Accept planned and finished

This is a valid state if there are no changes to be done.
See https://app.terraform.io/app/xmtp/workspaces/testnet/runs/run-c4pjWSbpXaz3sMKh

@neekolas how do we "release" this?


added options to save videos and seed them with webtorrent-desktop

I like these features.  After I merge them I might tweak the settings a bit and add "Save" and "Continue Seeding" as context menu options.


Bookstore Iniatilaze

In this milestone, I did the following activities:

Initialize Bookstore
Add component book
Fix linters Errors

thank you 😄


Include shellCheck in travis builds

Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST

Multiple images in the test-tools repo make use of bash scripts as the container business logic. They need to be validated via shellCheck utility as part of sanity checks before building/pushing the images.

Ref: https://dev.to/david_j_eddy/using-shellcheck-to-lint-your-bashsh-scripts-3jaf

I am doing this


Preview 11 Xaml hexadecimal colors not working

Describe the bug
In previous versions we could set hex colors in Xaml, the following snippet used to work, not it does not.

To Reproduce
Not sure if it happens on every hex color in Xaml, but it happens in the LiveCharts2 repo.

Clone LiveCharts2 at the avalonia preview branch
See this file and use the commented XAML instead of the current one.
see the exception.

Expected behavior
The Xaml to compile

OS: Windows 11

Additional context
The same XAML used to work In version 0.10.18

Seems like a mismatch in assembly versions. Check if all projects are using the same version of Avalonia and maybe you need to reopen the solution (or restart VS) to make sure the build tools with the correct version are loaded.

The issue here is that your brush properties are typed SolidColorBrush instead of IBrush. This prevents using multiple brush implementations. Avalonia 11 creates immutable brushes at compile time for performance reasons and therefore your code doesn't work anymore.

thanks @Gillibald .

It works thanks!  but this was a breaking change in case you want to add it to the migration docs.


test/add functional tests

test: add TestSemanticsByRound and TestByEquivalence classes
test: add CoreTestInterpreter
test: add CoreTestUtils
test: add TestByEquivalence/
test: change test name
test: add TestSemanticsByRound implementation
test: define Random seeds to use always the same sequence
test: swith from var to val in test
chore: add scalac options for deprecation and feature
test: fix feature and deprecation warnings
build: add fork=true in SBT
test: fix part of should fail if the sensor is not available
test: fix should fail if the sensor is not available

Close #64
Close #65

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

6.0.0
GitHub release

Your semantic-release bot :package::rocket:


PSharpCompiler should link external assemblies

I'm working on a project that depends on some external assemblies.  When I compile it with PSharpCompiler, the assemblies are not copied into the output directory and the program fails to load them at runtime.  It looks like the code to link external assemblies is unfinished:
https://github.com/p-org/PSharp/blob/master/Source/LanguageServices/Compilation/CompilationEngine.cs#L293
Workaround: Build once with Visual Studio, then compile and test with PSharpCompiler as desired.  The external assemblies remain in the output directory, so the program works.

This issue is no longer a priority for me.  I realized that my project needs to download NuGet packages, so I need to build once with Visual Studio anyway.

Hi Matt, I am aware of this issue and had the same problem with Cheng's code and had to do it manually as you said. I not 100% sure what is the best way to make sure they are properly copied using the available APIs (although I did not spend more than an hour looking for a good solution). If you are aware of a good way please let me know, else I will try to find out (but as a low priority for now). Thanks.


AttributeError: module 'gtp' has no attribute 'Engine'

C:\Users\Liu\Anaconda2\envs\py3\lib\site-packages\h5py_init_.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Traceback (most recent call last):
File "main.py", line 35, in
from gtp_wrapper import make_gtp_instance, MCTSPlayer
File "D:\Training\机器读心术之神经网络与深度学习（第九期）\第10课\minigo-master(2)\minigo-master\gtp_wrapper.py", line 16, in
import gtp_extensions
File "D:\Training\机器读心术之神经网络与深度学习（第九期）\第10课\minigo-master(2)\minigo-master\gtp_extensions.py", line 42, in
class KgsExtensionsMixin(gtp.Engine):
AttributeError: module 'gtp' has no attribute 'Engine'

we no longer have the gtp dependency, so this should be, if not fixed, at least a different bug :)  Closing.

i have the same error when running the MLPerf training workloads.
the output is
Traceback (most recent call last):
File "loop_init.py", line 21, in
import main
File "/data/training/reinforcement/tensorflow/minigo/main.py", line 35, in
from gtp_wrapper import make_gtp_instance, MCTSPlayer
File "/data/training/reinforcement/tensorflow/minigo/gtp_wrapper.py", line 16, in
import gtp_extensions
File "/data/training/reinforcement/tensorflow/minigo/gtp_extensions.py", line 42, in
class KgsExtensionsMixin(gtp.Engine):
AttributeError: module 'gtp' has no attribute 'Engine'
and the ptp version=0.2


Get Iterations History

First, I would like to congratulate the contributors of this project. It is a great work.
I would like to ask if there is a canonical way to get the value of the optimization variables for the iterations along the optimization process.
I see that the class ifopt::Problem  has a member x_prev which I think it contains the data i desire. But this member is private.
My questions are:

Contains x_prev  the history of the iterations?
Is there a way to get its value?

I think that a const method const std::vector<VectorXd> &GetIterations() const { return x_prev; }; will be usefull. It this solves the problem I can do a pull request.

I think this is reasonable. If you create a PR I will review it.


Added changes

Changed.

Thanks, I also updated the version in .nuspec file, next time make sure to update the version of redist (to game version) in .nuspec file

Sure thing.


[Feature][Udf] Whether to add UDF/UDAF/UDTF Module

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Spark/Flink SQL supports UDFs, UDAFs and UDTFs, Should we add corresponding features.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @obobj, nice idea!


UI stuck when switching tabs by tapping on Android and Expo.

Current behaviour
I have 7-10 tabs, each one contains SectionList with 50-100 items.
Sometimes, when I switch back and forth between 2 adjacent tabs, the UI is frozen for 2-4 seconds before the switch takes place. It's not only upon first render.
Swiping between these 2 tabs is smooth, however the TabBar takes this amount of time to update.
Expected behaviour
Render should be a lot faster, specially when it's not the first visit to the tabs
Code sample
I can't give a runnable code, as it involves the amount of the data in order to reproduce. But here's how I use :
<TabView
	navigationState={{ index: this.index, routes: this.routes }}
	renderTabBar={props => (
		<TabBar
			{...props}
			inactiveColor={'rgb(129, 167, 227)'}
			activeColor={'rgb(27, 125, 225)'}
			indicatorStyle={styles.indicator}
			style={styles.tabBar}
			scrollEnabled={true}
			renderLabel={renderLabel}
		/>
	)}
	renderScene={this.renderScene}
	onIndexChange={index => (this.index = index)}
	lazy={true}
	lazyPreloadDistance={1}
/>

renderScene = ({ route }) => {
		let items: any = route.items;
		return (
			<SectionList
				sections={items}
				renderItem={this.renderItem}
				renderSectionHeader={this.renderSectionHeader as any}
				ItemSeparatorComponent={this.itemSeparator}
				keyExtractor={keyExtractor}
				nestedScrollEnabled={true}
				stickySectionHeadersEnabled={true}
				contentContainerStyle={styles.tabList}
				scrollEventThrottle={5}
				showsVerticalScrollIndicator={false}
			/>
		);
	};

renderItem = ({ item }: { item: MFindingGroup }) => (
		<GenericItem
			item={item}
			goToDV={this.goToDV}
			goToPathView={this.goToPathView}
			style={commonStyles.flexOne}
		/>
	);

const GenericItem = ({
	item,
	goToDV,
	goToPathView,
	style
}: {
	item: MFindingGroup;
	goToDV: (item: MFindingGroup) => void;
	goToPathView: (item: MFindingGroup) => void;
	style: any;
}) => {
	const goToPV = () => goToPathView(item);
	switch (item.type) {
		case FindingGroupType.OPEN_DISTRIBUTION:
			return withPathsDrillDown(
				<Distribution item={item} goToDV={goToDV} style={style} />,
				goToPV
			);
		case FindingGroupType.CLOSED_DISTRIBUTION:
			return withPathsDrillDown(
				<ClosedDistribution item={item} goToDV={goToDV} style={style} />,
				goToPV
			);

		case FindingGroupType.PREVALENCE:
			return withPathsDrillDown(
				<PrevelanceGroup item={item} goToDV={goToDV} style={style} />,
				goToPV
			);

		case FindingGroupType.LABTEST_GROUP:
			return withPathsDrillDown(
				<LabTestGroup item={item} goToDV={goToDV} style={style} />,
				goToPV
			);
		case FindingGroupType.MULTI_LEVEL_GROUP:
			return (
				<MultiLevelGroup
					item={item}
					goToDV={goToDV}
					style={style}
					goToPathView={goToPathView}
				/>
			);
		default:
			return withPathsDrillDown(
				<LeafItem item={item} goToDV={goToDV} style={style} />,
				goToPV
			);
	}
};

What have you tried
I've tried to profile the scenario (more reproducible on a real device then on an emulator) and in the Chrome profiler, the React FlameChart looks like most of the period has a grey duration with no data (probably native code). the React part, where I can see my components hierarchy - the duration looks fine.
Your Environment

software
version

android
9

react-native
Expo 33 (Managed Workflow)

react-native-tab-view
2.6.2

react-native-gesture-handler
1.2.1

react-native-reanimated
The default included in Expo 33

node
10.15.1

npm or yarn
1.17.3

I can't give a runnable code, as it involves the amount of the data in order to reproduce. But here's how I use

It's impossible to know what's happening without code. You need to at least post your renderScene function.
Have you followed optimization tips? https://github.com/react-native-community/react-native-tab-view#avoid-unnecessary-re-renders

thanks @satya164 - I've added more code.

 Please follow the README to implement shouldComponentUpdate/PureComponent/React.memo to prevent unnecessary re-renders.

I have.
As you can see, renderScene() returns a SectionList which is a PureComponent.

Anything else that comes in mind?

SectionList which is a PureComponent

Can't say without code which I can run and debug. Your example is also storing state in class property which I'm not sure is going to behave correctly.

So from what I've read, it's exactly the same as described in #720 .
I'm running version 2.6.2 so it's after your changes. There is also a report in #778 that this is still not fixed. I'm aware that @xaviershay said that it has fixed his issue - I wonder, are you sure?

it definitely made an improvement on the isolated test case I had, but haven't had a chance to incorporate into our main app yet.

I am still facing this UI stuck issue in version ^3.1.1 on Android only. Can anyone please help me with this?


Restore previous package name: Microsoft.AspNet.Html.Abstractions

nit: add a couple of solution items

FYI only. Will merge immediately to fix build break.

1b0e2e5


What is the best way to expose line and column of XML elements and attributes?

Hey Lukas,
I’m thinking of forking your XML package to retain and expose line and column number ranges for XML attributes and elements. This could be useful for in-place editing and the like.
I’m curious how you would change you parsing strategy to retain these ranges?

I believe earlier versions of this packagedid something like this. However, with the push towards a mutable DOM (where any edit would invalidate positions) and supporting incremental parsing (where line and column indexes are ambiguous) I removed it from the public API.
That said, it is relatively easy to collect the position of each DOM element without even changing the existing code. You just need to create a custom subclass of the XML parser that keeps track of the positions. I've hacked together an example: https://github.com/renggli/dart-xml/blob/master/example/xml_pos.dart
$ dart example/xml_pos.dart example/books.xml
1:1: <?xml version="1.0"?>
2:1: <catalog>...
3:3: <book id="bk101">...
4:5: <author>Gambardella, Matthew</author>
5:5: <title>XML Developer\s Guide</title>
...

Thank you Lukas, that’s perfect.


az sql mi create crashes

Describe the bug
az sql mi create with certain options, causes python to barf
Command Name
az sql mi create
Errors:
The command failed with an unexpected error. Here is the traceback:

Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 206, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 560, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 618, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 611, in _run_job
    six.reraise(*sys.exc_info())
  File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
    raise value
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 588, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 297, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 461, in default_command_handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/sql/custom.py", line 2005, in managed_instance_create
    kwargs['sku'] = _find_managed_instance_sku_from_capabilities(cmd.cli_ctx, kwargs['location'], sku)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/sql/custom.py", line 1974, in _find_managed_instance_sku_from_capabilities
    managed_instance_version_capability = _get_default_capability(capabilities.supported_managed_instance_versions)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/sql/custom.py", line 118, in _get_default_capability
    next(c for c in capabilities if c.status == CapabilityStatus.available))
StopIteration

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az sql mi create -g {} -n {} -l {} -i -u {} -p {} --subnet {} --capacity {} --storage {} --edition {} --family {}

Expected Behavior
Environment Summary
Linux-4.15.0-1045-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.65

Extensions:
azure-devops 0.8.0
aks-preview 0.4.2

Additional Context

This error is happening because Managed Instance is not available to your subscription in the specified region. I will improve the error message.

Fixed by #9918


Hotfix for build break with latest merges

Description

include api_vulkan_sample.h in gltf_loader.cpp again, and remove its locally defined struct Vertex.
change from the vanished vkb::Platform to vkb::ApplicationOptions in samples/extensions/gshader_to_mshader.[cpp|h]

General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style

[x] I have reviewed file licenses

[x] I have commented any added functions (in line with Doxygen)

[x] I have commented any code that could be hard to understand

[x] My changes do not add any new compiler warnings

[x] My changes do not add any new validation layer errors or warnings

[x] I have used existing framework/helper functions where possible

[x] My changes do not add any regressions

[x] I have tested every sample to ensure everything runs correctly

[x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[ x My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[ ] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[ ] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
[ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering

Merging on two as this PR is needed to fix main


Squat Nimbleness not fully functioning

The 'squat nimbleness' feat for shorties doesn't appear to be working correctly. It doesn't give the +1 to movement speed. It does, however, appear to give the other two effects (+1 to STR or DEX and athletics or acrobatics skill proficiency) - but my shorties are still slow. I guess two out of three ain't bad, but it makes it a much less useful feat for my vertically challenged party members!

Save and logs?

fixed in dev.


refactor: update wsl clipboard for windows with recomand

use the recommanded config to use clipboard in windows.
https://github.com/neovim/neovim/wiki/FAQ#how-to-use-the-windows-clipboard-from-wsl

#736


GEODE-7345: reinstate 'be sick' test hook

GEODE-7345
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

the DistributedTestOpenJDK11 failure in the RebalanceManagementDunitTest > rebalanceNonExistRegion test is caused by GEODE-75045 which is being reverted, so I'm going ahead and merging


Client: investigate pylint warnings

What is the current behavior?
From #178 we reported some weird pylint warnings.
What is the expected behavior?
Investigate how to fix / remove them.

Here's the warnings:
lint: commands[1]> pylint -rn quantum_serverless tests

------------------------------------
Your code has been rated at 10.00/10

pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions
option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name
(maybe 'builtins.BaseException' ?) instead.
pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions
option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name
(maybe 'builtins.Exception' ?) instead.

FWIW, they don't appear to be blocking, as I saw these even in a passing test...

Thanks @psschwei ! About the priority agree, I marked it as priority: low just to have it in the radar and not forget it.


404 links in tutorial

Hi,
https://irmin.io/tutorial/contents chapter 4 links to:

Irmin.Type
official documentation

which do not exist (404). I thought you would want to know :sweat_smile:

Hi, thanks for bringing this up.
Irmin.Type has moved, the documentation can be found here https://mirage.github.io/repr/repr/index.html. We haven't corrected the tutorial yet.

Hi, thanks for bringing this up.
Irmin.Type has moved, the documentation can be found here https://mirage.github.io/repr/repr/index.html. We haven't corrected the tutorial yet.

Now fixed; thanks! :slightly_smiling_face:


Experiment with splitting death toll into a separate graph

Currently the shared y-axis for infections and cumulative deaths can make the latter hard to see:

Splitting into two separate graphs might alleviate the issue. Cumulative deaths could also be a bar chart, and hence much slimmer.

Closed by https://github.com/archydeberker/corona-calculator/pull/49


chore(bench): update CodSpeed/action to v2

Upgrading to the v2 of https://github.com/CodSpeedHQ/action will bring a better base run selection algorithm, better logging, and continued support.

Hey, thanks for this! I hadn't noticed there was a v2. I'll let it run through everything to see that it's all good.

I will take care of that later. Thanks for this PR and all the work you put into this!

It looks like it's having trouble finding the benchmarks now. Is this a familiar issue? https://github.com/Ogeon/palette/actions/runs/8859407386/job/24329330697

It looks like it's having trouble finding the benchmarks now. Is this a familiar issue? Ogeon/palette/actions/runs/8859407386/job/24329330697

This is because in the latest version of cargo-codspeed, benchmarks are now run in their package root directory.
So here in the case of palette, they are not run in the integration_tests anymore.

@Ogeon if the path in https://github.com/Ogeon/palette/blob/ffcab42be71d9250581a7ef09edcf3ca354509d5/integration_tests/tests/convert/data_color_mine.rs#L329 is relative to the folder actually running the benchmarks (ie: benchmarks in our case), cargo codspeed run works again
Maybe the solution would be to change a bit the load_data() function to ensure that it works, no matter what the current_dir() is?

I was using the working directory parameter so it could still find the CSV files, due to the relative paths, but has its purpose changed? Running the same commands locally seemed to work like before, so I'm curious to know how that differs here. What I tried was to build the benchmarks from the workspace root and then run them from integration_tests. It found everything as usual. 🤔

Have you udpated cargo-codspeed to the latest version, 2.6.0?
It should not work with it. And since the CI takes the latest version, it is failing as well

I thought I did, but I'll have to check again. That would explain things. 🤔 It's about time I sort these files out anyway. I'll see if I give it another try on Wednesday, and get back to you about how it went. It's almost midnight where I live and tomorrow is a bit too busy.

I found a way to make it work again in #398 😇

Well, I can't complain when the whole thing already was a hack. 😁 Thanks a lot! I hope you don't mind that I wait with the merge until tomorrow, when I have the rest of my brain up and running again. It looks like everything should be all good, though!