🌋 E|F ➾ Generate, Fund and List Accounts

Product Board Link
No response
🚥 Status

[x] 🔮 Product/Feature Design
[ ] ✍🏻 Architecture/Implementation Planning
[ ] 🏗 Under Construction
[ ] ⛳ Feature Complete
[ ] ⛵ GTM / Release

✅ To Do
No response
📐 Feature Description
This epic tracks the work required to implement account generation and funding per environment
🚩 Problem or Use Case
No response
🔭 Scope
🏎 In Scope:

...

🙅♂ Out of Scope:

...

⚖ Acceptance Criteria
✨ Features:

[ ] ...

📚 Docs:

[ ] ...

🔗  Related Issues and Subtasks
No response
🦄 Sizing
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Here's some "pseudo" json we used to model some ideas. It's not a specification. This file suggests that we store secret key material in the config, which we should not do, and if we do, it's only as a stop-gap measure.

Closing: complete


Date picker locales: same change as from admin panel

I think we do that already in the JS file that’s included. Could be wrong

On 12 Mar 2021, at 15:14, abdelouahedhamdi @.***> wrote:

@abdelouahedhamdi commented on this pull request.
In components/booking/picker_form.blade.php:

@@ -18,6 +18,7 @@
@.($disabledDaysOfWeek ?? [])'
@.($disabledDates ?? [])'
data-format="yyyy-mm-dd"

           data-language={{ setting('default_language') }}

should it be :
data-language= "{{ strtolower(str_replace('_', '-', setting('default_language'))) }}"
instead ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


[iOS] Create Media List Screen

Issue

close #450

Overview

Implement MediaScreen

Confirming with the designer

[x] Search bar placeholder
[x] Design when search controller just actived

Implement initial loading for MediaScreen
Add searchTextDidChang(to:)to MediaAction
Adjust codes trigger redundant_discardable_let
Change the way to set the background
The old way cases some bugs related to navigation bars in large title mode.

Links
Screenshot

Before
After

Thank you for your review!
I will fix those issues I marked with  👍 tonight.
For those comments without 👍, I commented my thought. Please check.

@ry-itto
About the constraint warnings, which simulator did you use?
Those warnings didn't show in my environment. (I fixed it unintendedly?)

About the constraint warnings, which simulator did you use?
Those warnings didn't show in my environment. (I fixed it unintendedly?)

It seems have not fixed yet 🙏🏼
I checked by iPhone 12 Pro Max simulator.

Could you also tell me the iOS version?
I still can't reproduce the warnings. 🙇♂

Could you also tell me the iOS version?
I still can't reproduce the warnings. 🙇♂

I found same warnings with Xcode: 12.4, iPhone 11 Pro (iOS 14.4)

Thank you! I will fix them tonight.

I found same warnings with Xcode: 12.4, iPhone 11 Pro (iOS 14.4)
(I could not see this in iPhone 11 Pro (iOS 14.2). This problem might be hard to solve)

I couldn't reproduce it in iOS 14.5 too. So it may be a bug in iOS 14.4, let's ignore it.

Please fix conflicts :pray:


Comments API

Add API to leave comments on Wissles.

Coverage decreased (-3.03%) to 11.839% when pulling a78e9343b5a00426dd3c3d5ad518d66c06bd866f on comments-api into f51624a4d38efa94c7cd5125b8d1b08c6bf4950d on master.


Make H5Dict accept pathlib Paths.

Summary
The type checking done in the constructor of H5Dict restricts users to use strings to denote paths, but Path objects from pathlib (https://docs.python.org/3/library/pathlib.html) also make sense there.
Related Issues
Closes https://github.com/keras-team/keras/issues/11459.
PR Overview

[x] This PR requires new unit tests [y/n] (make sure tests are included)
[x] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[x] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

The build failure appears to be just a transient network error: https://travis-ci.org/keras-team/keras/jobs/445247077#L475.

Not sure about this. Can't the user just pass the H5py file object? Also it is possible to have python 2 Keras installations without pathlib2.

Not sure about this. Can't the user just pass the H5py file object?

Mh, that's not really up for me to decide... But I'd say that as long as it accepts a path as a string it should accept a Path.

Also it is possible to have python 2 Keras installations without pathlib2.

Ach, I didn't notice that pathlib2 is installed transitively by pytest ! Can fix that.

Thanks!


refactor(tests): Refactor tests to use artsy setupTestWrapper pattern

Description
This updates Energy's tests with the setupTestWrapper relay test pattern we see around various artsy apps, which simplifies how we do testing overall. Also updated tests to be more "real world", in the sense that we no longer have two app provider wrappers executing -- one for tests, and one for real app -- and instead use one and share them between.
cc @artsy/mobile-platform
PR Checklist

[ ] I tested my changes on iOS and Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

Sorry @damassi I didn't notice I was the assignee for the PR 🙌


feat: Python Runtime Windows Builds on TRT 10

Description

TRT-10 based implementation of Windows builds

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ - ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

Like TRT 9, need to manually install tensorrt-cu12-bindings==10.0.0b6 and tensorrt-cu12-libs==10.0.0b6 too.

https://github.com/HolyWu/TensorRT/tree/windows_CI_trt_10_fix
Did some cleanup and fixes. Also changed to install torch and trt according to desired_cuda from build matrix, otherwise torch and trt with cuda 12 would be installed in cu118 matrix.

Thanks very much @HolyWu - I've cherry-picked in the non-C++ changes (those can be ported in a different PR), plus some test modifications, and will see how the CI tests go.


RISC-V Support

This is a request that extends https://github.com/bpfman/bpfman/issues/1063.
I would like RISC-V support for bpfman, and in particular I'm currently using Fedora on RISC-V so it would be extra nice if we could add a package to the Fedora RISC-V Repositories.

Warning: at the time of writing, there's some problems with Fedora RISC-V support (including the package repository
(which is under fedora.riscv.rocks) not having any TLS at the moment).

I am potentially interested in adding this support myself, though I might need some help with the Fedora packaging scene for RISC-V.

Note: Aya already supports RISCV64, which is what I'm using. I don't need 32bit support at the moment personally.

FYI: You might run into issues here: bpfman is being built in a container using Containerfile.bpfman which builds in rust:1 (FROM --platform=$BUILDPLATFORM rust:1 as bpfman-build). RISC-V is not list as one of the supported architectures (https://hub.docker.com/_/rust), although it is in one of the "other architectures" supported by docker (https://github.com/docker-library/official-images?tab=readme-ov-file#architectures-other-than-amd64).


Fixing error handling on ApiController

Coverage remained the same at 100.0% when pulling 9ce1df12ef2f2791f3a40ae59f8e1ed6ffcf3d71 on ktutnik:master into f5401fdd26c5c52f7c13e013cf16fefe910e2697 on kambojajs:master.


When provising your first Service instance, you get a blank page

Steps to reproduce:

On the list of potential services instances to provision for a specific broker, select one
Fill the required text fields and click provision

Expected results:

The user gets back to the Service Instances page and there is a card for the current provisioning service

Actual results:

The user gets back to the Service Instances page, but it is blank. After refreshing it, they get the card of the service that is being provisioned

+1 was able to repo, we should be able to fix by just await-ing on the API call, or when we have websockets in the Service Instance view. cc @ritazh @sozercan


Add const-erased versions of the various

Making code flexible around heapless structures can be a bit verbose because it requires being generic over the capacity of each collection. This could be helped by providing versions of the structures with the const erased. This would allow removing the generics  in some cases.
For example, heapless::Vec currently is :
pub struct Vec<T, const N: usize> {
    len: usize,
    buffer: [MaybeUninit<T>; N],
}

It should be possible to provide a struct that goes hand in hand with it:
pub struct VecView<'a, T> {
    len: &'a mut len,
    buffer: &mut [MaybeUninit<T>],
}

impl<T, const N: usize> Vec<T, N> {
    fn as_view(&mut self) -> VecView<'_, T> {
        VecView { len: &mut self.len, buffer: &mut self.buffer }
    }
}

With VecView implementing most of the API that Vec currently implements. This would allow for example methods that write data to an outbuffer of type &mut Vec<T, N> to instead take a parameter VecView<'_, T>.
Something like:
fn do_something<const N: usize>(response_buffer: &mut Vec<u8, N>)

could become
fn do_something(response_buffer: VecView<'_, u8>)

In a trait for example this would also have the advantage of making it object-safe.
I believe this pattern:

Improve ergonomics
Might reduce compilation time and binary size because of monomorphisation (unverified)

Types:

[x] Vec

https://github.com/rust-embedded/heapless/pull/453
https://github.com/rust-embedded/heapless/pull/425
https://github.com/rust-embedded/heapless/pull/451
https://github.com/rust-embedded/heapless/pull/465

[ ] String

https://github.com/rust-embedded/heapless/pull/452

[ ] Deque

https://github.com/rust-embedded/heapless/pull/459

[ ] LinearMap

https://github.com/rust-embedded/heapless/pull/479

[ ] HistoryBuffer
[ ] BinaryHeap
[ ] MpMcQueue
[ ] SortedLinkedList

For this one it might also be interesting to erase the Idx generic at the same time, though it would likely be a challenge.

[ ] spsc::Queue

IndexMap and IndexSet
IndexSet depends on the View type for IndexMap being available.
IndexMap is currently implemented with a CoreMaptype that looks like:
struct CoreMap<K, V, const N: usize> {
    entries: Vec<Bucket<K, V>, N>,
    indices: [Option<Pos>; N],
}

It is not possible to construct a View for this type like for Vec since the N would have to be erased twice.
We could solve that issue by "inlining" the indices into the entries:
struct CoreMap<K, V, const N: usize> {
    entries_indices: [(MaybeUninit<Bucket<K, V>>, Option<Pos>); N],
    len: usize,
}

Then only one N needs to be erased, and this can be implemented. However this requires changing the implementation significantly.
It might even be possible to get rid  of the len field (I think an entry is initialized if and only if a index points to it, and only one index can point to it at a given time?).

There are cases where some adjacent structures have the const generic that could be removed thanks to this implementation. Would it be worth making breaking changes to remove this const generic?


Fix i2c data lost on start repeat condition

I2cResult::Data is only given by I2c::check_isr_flags when the stop condition interrupt is generated. The problem being that the stop condition interrupt is not generated on a repeated start condition.
This fixes the issue by checking if there is pending data when an address interrupt is pending. This means that there wasn't a stop condition after the last address event.
I2cResult::Data also now returns the type of event which marked the end of the data. This is useful if special functionality is desired depending on the type of event. For example, some I2C interfaces require that the register and read/write commands be issued with no stop conditions between them.
Fixes #136

Thank you!


No registered route was found to handle '/videos/1234'.

I tried to implement routing in my application with fluro, however I had several problems following the 'getting started' guide on Github.
My implementation is rather simple, since the new GestureDetector(               onTap: () {                 _handleTap(context);               }, .... )
is supposed to manually push the route with  void _handleTap(BuildContext context) {   router.navigateTo(context, "/videos/1234",       transition: TransitionType.native); }.
The router is initialized according to the getting started example, but once I test the app the error

No registered route was found to handle '/videos/1234'.

What else is needed in order to push the route, or am I doing something wrong?

Can you share the code where you register / create the routes?

Yes, sure.
final router = new Router();
var usersHandler = new Handler(handlerFunc: (BuildContext context, Map<String, dynamic> params) {
  return new VideosScreen(params["id"]);
});
void defineRoutes(Router router) {
  router.define("/videos/:id", handler: usersHandler);
}
void _handleTap(BuildContext context) {
  router.navigateTo(context, "/videos/1234",
      transition: TransitionType.native);
}

The full file is here.

Will take a look

I tested here and it seems to be working ok. But, let me shoot over some suggestions to try and if it doesn't work we can take another look.
If you're only using one router in your app (which probably most people do) you can try creating a class specifically for routing responsibilities. For example:
import 'package:fluro/fluro.dart';
import 'package:nativedemo/routing/handlers/product_handlers.dart';

class AppRouter {

  static final AppRouter _instance = new AppRouter._internal();
  final Router _router = new Router();  // global router

  factory AppRouter() {
    return _instance;
  }
  AppRouter._internal();

  // singleton
  Router router() { return _router; }

  void configureRoutes() {
    _router.define("/videos/:id", handler: videoDetailHandler);
  }
}

Then inside your Home class you can add (or inside initState if you make it stateless):
  Home() : super() {
    final appRouter = new AppRouter();
    appRouter.configureRoutes();
    appRouter.router().printTree();
  }

Adding it to the constructor or initState will mean that it wont be re-created / reconfigured each time build() is called.
Finally, at the point when you want to navigate to the route you can use:
new AppRouter().router().navigateTo(context, "/videos/1234");

Let me know how it goes.

Thanks a lot for your help, will try it out in a few hours and get back to you how it worked. Thanks again!

I implemented fluro following your advice, but I still have the error "Undefined name 'context'." for the part that manually pushes the route
new AppRouter().router().navigateTo(context, "/videos/1234");
How do I define the variable and what type of parameter is required? Thanks again for your help!

Can you share the code again? That's almost certainly a regular dart issue. It means that context, as a variable, is undefined.

Sure. I already expected it to be a dart issue, but I somehow am unable to fix it. The code is here, and the line in question is 69, where the 'context' in void _handleTap() {   new AppRouter().router().navigateTo(context, "/videos/1234"); } seems to be undefined.

Your _handleTap method is declared at a global level and is not contained inside a class. The BuildContext object is not defined at that scope. You should move _handleTap into BookList and pass context to it via void _handleTap(BuildContext context). You will need to swap out your onTap to be something like:
onTap: () { _handleTap(context) }

If you're new to flutter then I highly recommend jumping on the flutter/flutter Gitter chat. Everyone there is super helpful and we hang out there as well.

Going to close this issue because it seems like it's working normally. I'll work to expand on the examples a little in the future.

It works now, thanks a lot for your help!


Stable/3.0

Thank you for contributing to openstack/fuel-plugin-contrail!
openstack/fuel-plugin-contrail uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Update LOCALIZATION_CONTRIBUTORS

Summary
Adding myself to the Spanish (ES-es) group in the docs/LOCALIZATION_CONTRIBUTORS file.
Details and comments

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Scrollers don't draw correctly always

Turns out that the code that draws the bars for the scrollers does not work correctly and the only reason the Settings app looks correctly is a pure fluke. Registers are not set properly and will the bar can end up being drawn just about anywhere (sometimes even in the palettes o_O).

Bug already fixed (bugfix should come in the next time I push), just submitted this issue for the sake of documenting that the problem exists.


I am try to upload a custom Certificate

Hi!
I'm trying to make use of my organization's own certificate in NPM, but for some reason I'm not able to upload it, I go through the web interface and add the certificate as shown in the image below:

As soon as I give this command in the nginx logo that is in data / logs / error.log this line appears:
2020/11/13 10:33:19 [warn] 258 # 258: * 225 a client request body is buffered to a temporary file / tmp / nginx / body / 2/00/0000000002, client: <IP_ADDRESS>, server: nginxproxymanager, request: "POST / api / nginx / certificates / validate HTTP / 1.1", host: "<IP_ADDRESS>:81", referrer: "http://<IP_ADDRESS>:81/nginx/certificates"
the web interface stays on that screen for several minutes:

After a long time he presents this error in the web interface:

and in the logs the following message appears:
2020/11/13 10:48:19 [error] 258#258: *225 upstream timed out (110: Operation timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: nginxproxymanager, request: "POST /api/nginx/certificates/validate HTTP/1.1", upstream: "http://<IP_ADDRESS>:3000/nginx/certificates/validate", host: "<IP_ADDRESS>:81", referrer: "http://<IP_ADDRESS>:81/nginx/certificates"
I'm using it via Docker following the instructions on the page:
https://nginxproxymanager.com/setup/
I've tried using both mariadb and sqllite as a database
I’ve also tried uploading using Firefox, Chorme and Cromium

Lets continue this discussion on #594


Testing: Do not configure HttpClient resilience by default

Since it is not straightforward to configure resilience policies after the handler has been added (see https://github.com/dotnet/extensions/issues/4814), we decided to remove these from the testing host so that developers are free to choose how resilience is configured in test projects.
cc @DamianEdwards
Related to #3431
Microsoft Reviewers: Open in CodeFlow

Does this need a corresponding update in docs somewhere?

We don't have docs for this area yet, so kind-of

/backport to release-8.0

/backport to release/8.0


How to set the Columns Width manually

Hello,
I have been reviewing the code / documentation and I couldn't find any function to set the widths of the columns manually.
Is there any way to set it?
Thanks in advance.

Hi there,
Thanks very much for your issue. We're closing many of the old issues while we focus on v2. If you
still think this is a major problem, please reopen.
Many thanks,
James


move nbd sigterm handling to backend

Here is an implementation of what I proposed in your merged SIGTERM PR.
Let me know what you think, and feel free to merge it if you like it.
I still think we should also handle the SIGTERM signal in the tlogserver, to ensure that the tlogserver is also gracefully quit. I know, in normal cases it should be fine without, but in production we don't always know what is normal. If you agree, we could make an issue for it, and plan it for milestone 7.

I still think we should also handle the SIGTERM signal in the tlogserver, to ensure that the tlogserver is also gracefully quit. I know, in normal cases it should be fine without, but in production we don't always know what is normal. If you agree, we could make an issue for it, and plan it for milestone 7.

We already have the issue.

We already have the issue.

Ah, you're correct! I forgot about https://github.com/zero-os/0-Disk/issues/322.


Disable editing a constraint's constraint template

Editing a constraint's constraint template would require us to delete
the existing constraint and create a new one transactionally. Since
the backend doesn't support this transaction of we're disabling the ability
to edit which template is being used.
I also noticed a number of inconcictencies and poor behaviors
with the LabeledSelect component so I went ahead and made
it consistent with LabeledInput.

The search field switched to a color distinct from the rest of the container
when disabled and hovered.
There wasn't a focus outline.
The size was slightly different because it was in a container
There was a distinct background color around the arrow indicator

rancher/dashboard#433

Conflict


powershell transformPattern.Resize(width, height);

Hello
I would like to learn how to move and resize an microsoft store app with flaui and powershell.
For now, as an example, I'm able to launch the calculator and to extract size and position.
I need some help to find out how to call the transformPattern move and resize with flaui, uia3 and powershell.
For now I'm trying to understand and convert the following tutorial from microsoft
https://docs.microsoft.com/fr-fr/dotnet/api/system.windows.automation.transformpattern.resize?view=net-5.0#System_Windows_Automation_TransformPattern_Resize_System_Double_System_Double_
thank you for your support
Thierry
here is the code
$core = Add-Type -Path "Z:\FLAUI\FlaUI.Core.3.2.0\lib\net45\FlaUI.Core.dll"
$uia3 = Add-Type -Path "Z:\FLAUI\FlaUI.UIA<IP_ADDRESS>\lib\net45\FlaUI.UIA3.dll"
Start-Sleep -s 2
$calcapp = [FlaUI.Core.Application]::LaunchStoreApp("Microsoft.WindowsCalculator_8wekyb3d8bbwe!App");
$calcId = ((Get-Process).where{ $_.MainWindowTitle -eq 'Calculator' })[0].Id
$uia0 = New-Object FlaUI.UIA3.UIA3Automation
$cf0 = $uia0.ConditionFactory
$desktop = $uia0.GetDesktop()
$calc = $desktop.FindFirstDescendant($cf0.ByProcessId($calcId)) #
$calc.BoundingRectangle
$calc.ActualHeight
$calc.ActualWidth

StoreApps are a bit of a pain. Make sure that you have the outmost Window (and not the inner window) of the application. They have different process ids and only the outermost window (directly a child of desktop) is a real window you can interact with.
As for the pattern: Either directly use the pattern or convert the window to an element (like Window) that implements this pattern.
An example that works for me is that:
$core = Add-Type -Path "C:\Temp\FlaUI.Core.dll"
$uia3 = Add-Type -Path "C:\Temp\FlaUI.UIA3.dll"

$calcapp = [FlaUI.Core.Application]::LaunchStoreApp("Microsoft.WindowsCalculator_8wekyb3d8bbwe!App");
$uia0 = New-Object FlaUI.UIA3.UIA3Automation
$cf0 = $uia0.ConditionFactory
$desktop = $uia0.GetDesktop()

Start-Sleep -s 2
$calc = $desktop.FindFirstDescendant($cf0.ByName('Calculator'))
# Move by pattern
$calc.Patterns.Transform.Pattern.Move(200, 200)

Start-Sleep -s 2

# Move by implemented element
$window = [FlaUI.Core.AutomationElements.AutomationElementExtensions]::AsWindow($calc)
$window.Move(300,300)


Updated Owner References

Description of the change:
Updated Reference from " to_be_owned.namespace "
to " to_be_owned.metadata.namespace " at line 186.
Signed-off-by: wasup-yash
Motivation for the change:
Closes #6318

@everettraven what needs to be done here from my side?

Created new PR #6409 resolving the same issue #6318 .


Re-integrate SPS selenium install in preparation of SPS being added into the marketplace

Re integrate the test installation of SPS with Selenium in preparation of SPS being added into the marketplace. The test will fail however when SPS is integrated into the marketplace the nightly will be ready to test the install.

https://github.com/unity-sds/unity-cs-infra/pull/74
PR

ISSUE: All the buttons/html elements in the Management console marketplace have the same class name. Sometimes the selenium scripts clicks the wrong button due to this.

Test Name                     | Status
------------------------------+--------
test_navigate_to_mc_console   | ✔
test_bootstrap_process_status | ✔
test_initiate_core_setup      | ✔
test_core_setup_save_btn      | ✔
test_naviate_to_SPS_module    | ✖
test_SPS_module_name          | ✖
test_SPS_module_branch        | ✖
test_click_SPS_install_btns   | ✖
test_SPS_install_status       | ✖

The installation of SPS is failing as expected until SPS is integrated into the MC marketplace.

@hargitayjpl and @galenatjpl  this needs an estimate.  Also, when do we expect this ticket to get un-blocked and which ticket unblocks it?

@GodwinShen - Once #351 is completed and SPS is added to the Management Console Marketplace, I'll be able to add to our selenium nightly script a function that tests the install and uninstall of SPS. I'll also add an estimated time to finish this task to the ticket.

@GodwinShen @hargitayjpl @jpl-btlunsfo @mike-gangl I added a "dependency" tag on #351 , that references this ticket, and also updated that ticket's description.
@hargitayjpl is the work needed to solve "sometimes the selenium clicks the wrong button" done?  Was there a separate ticket for @jdrodjpl about this?

@galenatjpl and @jdrodjpl - There is no ticket for that issue however work does need to be done. Most of the Buttons in the MC share the same HTML Class/ID name. This makes it ambiguous for the Selenium script to select the correct button.

@hargitayjpl I think that https://github.com/unity-sds/unity-cs/issues/363 solved this, correct?  It looks like the change by @jdrodjpl was merged in https://github.com/unity-sds/unity-management-console/pull/13 .

@galenatjpl Yea, that ticket solves it!!!


MSBuild warning/error behavior properties

https://github.com/microsoft/msbuild/pull/1928 introduced a few properties that can control MSBuild's error behavior:

[ ] MSBuildTreatWarningsAsErrors
[ ] MSBuildWarningsAsErrors
[ ] MSBuildWarningsAsMessages

(I can write this up, but am filing this so we don't forget entirely.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab5a5a0e-ae03-1237-6ebe-743066f27fa9
Version Independent ID: a342bfa4-4b0c-0a47-3695-858044f5aa5f
Content: MSBuild Reserved and Well-known Properties - Visual Studio
Content Source: docs/msbuild/msbuild-reserved-and-well-known-properties.md
Product: visual-studio-windows
Technology: msbuild
GitHub Login: @ghogen
Microsoft Alias: ghogen

@rainersigwald Can you provide an ETA for this?

NoWarn was for compiler messages but as of 16.9 now applies to all warnings (dotnet/msbuild#5774)
The $(WarningLevel) property is passed to compilers and does not affect MSBuild warnings
a.	MSBuild warnings do not have “levels” today
You can specify properties to elevate/suppress warnings (initial implementation: dotnet/msbuild#1928):
a.	MSBuildTreatWarningsAsErrors makes all warnings into errors unless they’re suppressed
b.	MSBuildWarningsAsMessages suppresses specific warning codes
c.	MSBuildWarningsAsErrors elevates specific warning codes
You can also pass these on the command line
a.	Msbuild.exe -WarnAsError
b.	MSBuild.exe -warnAsMessage:ABC1234;DEF5678
c.	MSBuild.exe -warnaserror:ABC1234;DEF5678
Some MSBxxxx error cannot be suppressed by properties, because MSBuild emits the warnings before we’ve fully loaded the project so we can’t see the properties. Tracked by dotnet/msbuild#4038 but no clear solution so worth documenting as a caveat.


Update functions-infrastructure-as-code.md

@andresnava : Thanks for your contribution! The author(s) have been notified to review your proposed change.


How to upgrade to v1.0.0-rc-2

These are instructions on the breaking changes on SDK v1.0.0-rc-2.
DaprException
Now, every method in the SDK throws DaprException, which contains error code via the getErrorCode() method. DaprException may contain a child exception in the cause property.
Here is an example of catching an exception in synchronous code:
      try {
        client.getState("Unknown state store", "myKey", String.class).block();
      } catch (DaprException exception) {
        System.out.println("Error code: " + exception.getErrorCode());
        System.out.println("Error message: " + exception.getMessage());

        exception.printStackTrace();
      }

ActorProxy and ActorProxyBuilder
ActorProxyBuilder now implements Closeable. This is needed because actor APIs are now over GRPC. It means that there is an instance of GRPC's ManagedChannel class that needs to be closed internally by the Dapr SDK and ActorProxyBuilder is responsible for keeping that reference. For this reason, the instance of ActorProxyBuilder should remain referenced until all the ActorProxy instances it created have been used. Then, it must be closed via the close() method.
See this example of using ActorProxyBuilder, where try-with-resource is used to automatically close ActorProxyBuilder:
    try (ActorProxyBuilder<DemoActor> builder = new ActorProxyBuilder(DemoActor.class)) {
      ActorId actorId = ActorId.createRandom();
      DemoActor actor = builder.build(actorId);
      actor.say(message);
    }

Concerning that DaprException introduction: Please make this a bit clearer, as it cannot be correct in the way it is described above.
It is stated: "every method in the SDK throws DaprException" which is definitly not true. E.g. there are many simple methods (aka getter) that simply return a value, so they never throw an exception.
But also for more complicated methods this sentence is misleading. If you look e.g. at CloudEvent.deserialize(). It prototype says it returns an IOExeption, which is obviously try as it calls ObjectMapper.readTree(). From the statement "every method throws DaprException" I would have expected that the method catches the IOException and wrap it into an DaprException, but this is not true.

Concerning that DaprException introduction: Please make this a bit clearer, as it cannot be correct in the way it is described above.
It is stated: "every method in the SDK throws DaprException" which is definitly not true. E.g. there are many simple methods (aka getter) that simply return a value, so they never throw an exception.
But also for more complicated methods this sentence is misleading. If you look e.g. at CloudEvent.deserialize(). It prototype says it returns an IOExeption, which is obviously try as it calls ObjectMapper.readTree(). From the statement "every method throws DaprException" I would have expected that the method catches the IOException and wrap it into an DaprException, but this is not true.

@frochi42 Makes sense. Thanks for the feedback. We updated the description.

@frochi42 Makes sense. Thanks for the feedback. We updated the description.

Closing in favor of https://github.com/dapr/java-sdk/issues/493


Subclass PyTorchYolo and PyTorchDetectionTransformer off PyTorchObjectDetector

Description
Modify both the PyTorchYolo and PyTorchDetectionTransformer estimators to be subclassed off the PyTorchObjectDetector estimator. This reduces a lot of redundant code and allows most functionality to be shared among the estimators. Additionally, this adds the option to train the PyTorchDetectionTransformer since the code is inherited accordingly.
Fixes #2267
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[x] Unchanged unit tests for PyTorchObjectDetector
[x] Unchanged unit tests for PyTorchFasterRCNN
[x] Unchanged unit tests for PyTorchYolo
[x] Updated unit tests for PyTorchDetectionTransformer

Test Configuration:

OS
Python version
ART version or commit number
TensorFlow / Keras / PyTorch / MXNet version

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] My changes have been tested using both CPU and GPU devices

Codecov Report

Merging #2321 (008679e) into dev_1.17.0 (337a15f) will decrease coverage by 65.01%.
The diff coverage is 10.71%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff               @@
##           dev_1.17.0    #2321       +/-   ##
===============================================
- Coverage       85.62%   20.61%   -65.01%
===============================================
  Files             324      324
  Lines           29323    29027      -296
  Branches         5405     4899      -506
===============================================
- Hits            25108     5985    -19123
- Misses           2837    22969    +20132
+ Partials         1378       73     -1305

Files
Coverage Δ

...estimators/object_detection/pytorch_faster_rcnn.py
77.77% <ø> (-22.23%)
:arrow_down:

art/estimators/object_detection/pytorch_yolo.py
21.73% <14.81%> (-61.22%)
:arrow_down:

.../object_detection/pytorch_detection_transformer.py
16.66% <12.50%> (-46.60%)
:arrow_down:

...mators/object_detection/pytorch_object_detector.py
17.55% <6.66%> (-68.25%)
:arrow_down:

... and 261 files with indirect coverage changes

Hi @f4str It looks like that one of the new unit test is change the prediction when the test runs on the GitHubActions machine. I have tried to fix it with #2371 but was not yet successful. Do you have an idea why the mode changes its predictions in that failing test?


Background Colour Appears Darker than Configured

Which operating system does the issue occur on?
Arch Linux
If on linux, are you using X11 or Wayland?
X11 + i3
If I configure the background to be 0x1c1c1c,  the colour actually ends up being 0x141414 (tested with a colour picker). So to actually get it to be 0x1c1c1c I have to set the colour to 0x282828.
From 0x1c / 0x14 I calculated the factor to be 1.4:
0x1c * 1.4 = 0x28

Do you have color profiles setup? Alacritty just renders out the colors exactly the same way they're specified.
If the color is specified correctly in the config and you're actually checking the color which you've specified, I'd say it's highly unlikely that the color would be different without some system configuration messing with color profiles.

Not that I know of. Where would I check for that? Other things like polybar and i3's borders use correct colours.

Could you post your config?
Also please make sure the correct config is loaded, you can check with alacritty -v.

Turns out this issue was due to the background opacity being configured in alacritty. When I first started debugging this colour issue I did set it back to 1.0 but for some reason i3 had to be restarted for this change to take affect and I didn't realise that needed to happen. I discovered this when doing alacritty -v just now worked with the correct colours (before I was always launching alacritty via i3).


cmake, doc: Update build-freebsd.md

Friendly ping @vasild @fanquake @m3dwards @jarolrod :)

Rebased.
@vasild  Is anything left to be done here?

@vasild

Maybe these (non-blockers):
#133 (comment)
#133 (comment)

Thank you! All your comments have been addressed in the recent push.


KeyError: u'licenseResponseBase64'

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

General infomration
Prerequisites

[x] Are you running the latest version?
YES

Description
When selecting a title in the menu, the loading wheel apears for a second or two then a Screen with the Error 'licenseResponseBase64' appears and wnat me to enable debug log for more informations
Steps to Reproduce

Opened Netflix Add-On
Selected Series
Selected Episode

Expected behavior: [What you expected to happen]
Play the selected episode
Actual behavior: [What actually happened]
Error 'licenseResponseBase64' appears
Context (Environment)
Installation

[x] I installed the plugin via zip from the Releases page
[ ] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[x] Linux (ARM)
[ ] Android

Additional informatin on the environment
Latest nightly of OSMC
Debug log
https://file.io/Gg7COJ
Screenshots
https://imgur.com/a/M0MwXHP

please put the complete log file,
and write me the name of series you tried

Complete Log http://sprunge.us/BQCIkb
Tried to watch Nightflyers

http://sprunge.us/BQCIkb

I'm sorry, but I haven't been able to reproduce your problem,
I also tried to change the language in German but the series you mentioned to me works correctly.
I noticed that in your log, there is a lack of logging debug information and profile debugging which is particularly strange... unless you deleted it.
The error however reports that the series mentioned is not playable in streaming. Maybe a temporary problem?

Also getting this error. Running under Swedish locale...
2019-08-30 21:51:15.959 T:3011836384  NOTICE: VideoPlayer::OpenFile: plugin://plugin.video.netflix/play/show/80073754/season/80073803/episode/80073804/
2019-08-30 21:51:15.960 T:2615628656  NOTICE: Creating InputStream
2019-08-30 21:51:15.969 T:2615628656   ERROR: GetDirectory - Error getting /usr/lib/kodi/addons/inputstream.adaptive/
2019-08-30 21:51:20.161 T:2657592176   ERROR: [plugin.video.netflix (0)] Traceback (most recent call last):
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/http_server.py", line 34, in do_POST
                                                challenge=data[0], sid=base64.standard_b64decode(data[1]))
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 41, in error_catching_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 246, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 231, in get_license
                                                return response[0]['licenseResponseBase64']
                                            KeyError: u'licenseResponseBase64'
2019-08-30 21:51:20.162 T:2615628656   ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 400
2019-08-30 21:51:20.162 T:2615628656   ERROR: CCurlFile::Open failed with code 400 for http://localhost:48729/license?id=80073804:
2019-08-30 21:51:20.162 T:2615628656   ERROR: AddOnLog: InputStream Adaptive: License server returned failure
2019-08-30 21:51:20.163 T:2615628656   ERROR: AddOnLog: InputStream Adaptive: License update not successful (no keys)
2019-08-30 21:51:20.163 T:2657592176   ERROR: Traceback (most recent call last):
2019-08-30 21:51:20.163 T:2657592176   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 293, in _handle_request_noblock
2019-08-30 21:51:20.163 T:2657592176   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 321, in process_request
2019-08-30 21:51:20.163 T:2657592176   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 334, in finish_request
2019-08-30 21:51:20.164 T:2657592176   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 657, in __init__
2019-08-30 21:51:20.164 T:2657592176   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 716, in finish
2019-08-30 21:51:20.164 T:2657592176   ERROR:   File "/usr/lib/python2.7/socket.py", line 283, in close
2019-08-30 21:51:20.164 T:2657592176   ERROR:   File "/usr/lib/python2.7/socket.py", line 307, in flush
2019-08-30 21:51:20.164 T:2657592176   ERROR: error: [Errno 32] Broken pipe
2019-08-30 21:51:20.204 T:2615628656   ERROR: AddOnLog: InputStream Adaptive: Initialize failed (SingleSampleDecrypter)
2019-08-30 21:51:20.206 T:2615628656   ERROR: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.netflix/play/show/80073754/season/80073803/episode/80073804/]
2019-08-30 21:51:20.207 T:2615628656  NOTICE: CVideoPlayer::OnExit()
2019-08-30 21:51:20.228 T:3011836384  NOTICE: CVideoPlayer::CloseFile()
2019-08-30 21:51:20.228 T:3011836384  NOTICE: VideoPlayer: waiting for threads to exit
2019-08-30 21:51:20.228 T:3011836384  NOTICE: VideoPlayer: finished waiting ```

When I logged in I did not have the Widevine plugin installed yet. Logging out and logging in again after that was installed seems to have solved the problem.

this log segment does not help is not clear, i need a full log with kodi debug activated

Here's a full kodi debug log with the same issue: kodi.log


Improve resource utilization on Compute nodes

Stackanetes enables operators to run OpenStack as any other applications on top of Kubernetes. As such, OpenStack's services run alongside mixed workloads, potentially owned by various tenants. For fairness and in order to guarantee that the orchestrator's scheduler can make knowledgeable decisions, it is crucial to have the ability to arbitrarily define, reserve and limit OpenStack's resource utilization.
Kubernetes' resource allocation model currently let operators define optional requests and limits for CPUs and Memory hardware resources. Different Quality of Service policies then define Kubernetes' behavior regarding to overcommitment and contention. Custom resource types can also be defined. Administrators may also define quotas on a per-Namespace basis.
While defining resources' requests and limits for most of Stackanetes' applications is straight-forward following the documentation referenced above, and is a task left to end-users, there is currently one exception: Nova Compute, and more specifically, the nova-libvirt pods. Running virtual machines are arranged on the hosts in different control groups than the libvirt and compute services that are executed by either rkt or Docker. Therefore, the resources that virtual machines consume are not accounted for by Kubernetes. This fact can easily be seen in the figure below, where the memory allocation of the virtual machine and containers are distinct and not summed whatsoever.

Therefore, it is currently impossible to properly limit / monitor the resource usage of Nova Compute on Kubernetes. Virtual machines are able to get scheduled and started as long as the Kubernetes node has enough available physical memory (Nova Compute's RamFilter). The desired behavior would be to have virtual machines scheduled until the pre-allocated memory for Nova Compute runs out.
The way I see it, there are mainly two parts to this issue. First, the resources used by the virtual machines must be accounted for in either the nova-compute or nova-libvirt containers for limiting / monitoring and helping the Kubernetes' scheduler to make good decisions. Second, the Nova Compute's scheduler should be aware that it doesn't have all the physical memory at its disposal but only what have been allocated.
Technically, on the Kubernetes side, we may be able to write a monitoring plugin that would sum the resource utilization of both the containers and virtual machines under the same metrics. And on the OpenStack side, we may either play with the ram_allocation_ratio / cpu_allocation_ratio or create a new filter for the scheduler. Note that ideally, the available resources reported by Nova should be correct.

Why cannot we run nova-compute, nova-libvirt and three openvswitch processes as a single rkt-lkvm pod?

@DTadrzak I am not familiar enough with the resource reporting when using the lkvm stage1 isolation layer but I believe that it won't make a difference as resource requests/limits apply to containers (stage2) directly. Regardless, the VMs would still be registered to different scopes on systemd - which will be the lkvm's systemd instead of the host's systemd - and their resources won't be accounted for. This idea also raises some fundamental issues. Off the top of my head, how could we run both Neutron/Open vSwitch/Nova services in the same pod while we have a clear separation (packages) between them? What about Docker users?

In order to let OpenStack think that the only available memory is what we define as a container limit, defining a new libvirt driver based on the existing libvirt.LibvirtDriver, and overwriting get_available_resource is enough. The hypervisor is properly reported with the proper amount of memory and this limit is updated as well when necessary. I also verified that the RamFilter indeed prevents launching new VMs past that limit.
The cleanest solution to have the VMs resource usage counted as part of the pod is to root the VMs' cgroup hierarchy under the pod's cgroup hierarchy. However, by default, a cgroup hierarchy is created per container, rather than per pod. This behavior doesn't respect our constraint of NOT having the VMs parented by the nova containers (e.g. an update should keep the VMs running). Since very recently, it is possible to have kubelet layout cgroups differently and maintain a cgroup slice for each pod.
kubelet parameters
  --cgroup-driver=systemd \
  --experimental-cgroups-per-qos \
  --cgroup-root=/

tree sample
  │   ├─BestEffort-pod17587970_fd3e_11e6_b240_0602d725b9dc.slice
│ │   │ ├─7889c4879721ff5a477b13d3ba75c750ad62f84ef994220d838a2e719d29035b
│ │   │ │ └─9541 /pause
│ │   │ └─d72c5c32d5ea4551d455ec6a6062b4603537f05df75bdd44e7b5195beec59f5a
│ │   │   ├─ 9638 /nginx-ingress-controller --nginx-configmap=tectonic-system/tectonic-custom-error --default-backend-service=tectonic-system/default-http-backend --default-ssl-certificate=tectonic-system/tectoni
│ │   │   ├─ 9681 nginx: master process nginx
│ │   │   ├─11050 nginx: worker process is shutting down
│ │   │   ├─11051 nginx: worker process is shutting down
│ │   │   ├─11052 nginx: worker process is shutting down
│ │   │   ├─11053 nginx: worker process is shutting down
│ │   │   ├─11559 nginx: worker process
│ │   │   ├─11560 nginx: worker process
│ │   │   ├─11561 nginx: worker process
│ │   │   └─11562 nginx: worker process

This would allow us to specify the root slice of the VM's cgroups as the pod slice with libvirt, using the XML domain/resource/partition configuration. Also, libvirt hardcodes the .slice suffix but as shown above, kubelet create pod slices with the suffix too.
I will know try to see how Nova could be modified to inject this custom cgroup slice and verify it works.

Here's what we want:

Terminating a Nova pod does not terminate the VMs

Already achieved by the usage of the preStop/postStart hooks

Scheduling a new VM that would exceed the set limit is not possible

Achieved by adding memory requests and by tweaking get_available_resource

The memory usage that is reported for the Nova pod contains both the memory used by nova-compute and the VMs so that:

Ops have a better vision of how much Nova consumes
Kubernetes can take smart decisions when it comes to reclaiming memory or killing Nova for exceeding its memory limit

The memory consumption of a pod is calculated as the sum of the the memory consumption of the containers that are part of it. This will be true until Kubernetes decides to create pod cgroups by default and to change cAdvisor to monitor that instead (which might never happen). This means that the VMs' processes must be parented under the nova-compute container's memory cgroup is we want their memory to be accounted for.
Since we can't assign the VMs directly to the desired cgroup, we have to re-assign them asynchronously. Fortunately, this is quite straight-forward to do on GNU/Linux. We could have the driver do it for us (if there is a right place to do so), or have a separate process managing that. Additionally, when a process leader is migrated from one memory cgroup to another, and when the destination cgroup has memory.move_charge_at_immigrate = 0b11, all anonymous pages and file pages of that process are moved to it too. In other words, the memory utilization of the migrated process is accounted on its new cgroup, which is what we need. See https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt.
The issue with having the VMs under the nova-compute's cgroup is that terminating that container will orphan the VMs and kill them too. However, we currently have a hook that is executed right before the container is being stopped. This hook migrates the VMs when the pod is stopped and the node is Unschedulable. We could have it to re-parent the VMs back to the /machine.slice cgroup when the pod is stopped and the node is still Schedulable so that the VMs don't get terminated early. Since we have a symmetric hook that is executed after the pod is started, we could re-attach the VMs to the pod.
It would solve the third point above. However, here is the catch. When the nova-compute's pod is being stopped, it might be for two reasons:

Because of an update, in which case we want the VMs to keep running on the host and therefore their processes to be re-parented on the host
Because Kubernetes has decided to kill it for reclaim memory or because it has taken too much memory, in which case we should migrate the VMs out if possible - or kill them
Unfortunately, there is no way to distinguish between the two cases and can only pick one of the two behaviors. The first one describes what we have been wanting to do until now (otherwise we'd simply have attached the VMs under the nova-libvirt container and called it a day), the second one fits better our use-case of co-locating workloads and the general use-case anyways where there are multiple hosts available to take the VMs load.

Does the implementation sound reasonable?
Which behavior do you prefer?
/cc @DTadrzak @PiotrProkop

/cc @brancz

/cc @lucab


Create OneLogin_Saml2_Auth::getLoginUrl() that gets the url OneLogin_Saml2_Auth::login() redirects to.

I'd like to proxy the service that runs the OneLogin api.

You can use the login method with stay=true and you will get the URL that you asking for.


Paycoin <IP_ADDRESS> missing binary/installer downloads

It's just source, where are the binaries?

They are being generated today and will be release with the Press Release

Ok thanks.

@CodeChief this is now complete, please see: https://github.com/PaycoinFoundation/paycoin/releases/tag/v<IP_ADDRESS>

Issue resolved, please close.


Base url

My blog is in some folder, so the url of my blog is:
https://xyz.com/something
instead of just https://xyz.com
The problem is that all of the links on the website lead to https://xyz.com/post_name instead of https://xyz.com/something/post_name . For that reason CSS and links don't work.
I tried to set  "baseUrl" config to '/something', but that didn't work. It worked in other themes like "Minima" for example.
Can I get this theme to work with a blog in a folder? What is the best way to do that?

This should work exactly the same with as with "Minima". Both themes use the relative_url liquid filter.
Have you tried using baseurl instead of baseUrl?

Yes, you're right. I should have used baseurl instead of baseUrl.


ngif ? directive and audio

dom:
http://plnkr.co/edit/vVC7KYMKUhjLTAdCWzbw
Repeat inserted audio object

Hi, can you please add a description of the problem / steps to reproduce either here or in the plunkr? We don't have time to decipher the problem from code only.

@Narretz; Hi, i need help;

Hi, your issue reads like a support question. This github repo is only for bug reports and feature requests. Please try one of these channels instead: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question


Wilma freeze with reply if token is invalid

PEP version: 7.0.1 (not matter)
IDM version: 7.0.0
Sending correct token:

pep_1    | 2018-08-21 16:34:38.135  - INFO: IDM-Client - Token in cache, checking timestamp...
pep_1    | 2018-08-21 16:34:38.135  - INFO: Root - Access-token OK. Redirecting to app...

Sending incorrect token:

pep_1    | 2018-08-21 16:35:16.456  - INFO: IDM-Client - Checking token with IDM...
pep_1    | 2018-08-21 16:35:16.908  - ERROR: IDM-Client - Error validating token. Proxy not authorized in keystone. Keystone authentication ...
pep_1    | 2018-08-21 16:35:17.317  - ERROR: Server - Caught exception: SyntaxError: Unexpected token u

if token is valid, http return code is 200.
If token is invalid, session freeze.

@aalonsog any news about this?

Hi @jmcanterafonseca, we will take a look today. Apologies for the delay

Hi @caa06d9c, @jmcanterafonseca we have created a new release: 7.0.2. In this release if token is invalid the session doesn't freeze and returns http code 401.

Image was  rebuilded
TypeError: Cannot read property 'enabled' of undefined     at pep (/opt/fiware-pep-proxy/controllers/root.js:48:38)     at Layer.handle [as handle_request] (/opt/fiware-pep-proxy/node_modules/express/lib/router/layer.js:95:5)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:137:13)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:131:14)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:131:14)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:131:14)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:131:14)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:131:14)     at next (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:131:14)     at Route.dispatch (/opt/fiware-pep-proxy/node_modules/express/lib/router/route.js:112:3)

Image was rebuilded
Wilma returns 401 if token is not authorized, thanks!


[UPGRADE} S3 2.17.170 -> 2.17.189

S3 team had been, partly on our reports [1] working
on numerous performance enhancements [2] [3] that
Apache James IMAP workload would definitely benefit
from.
[1] https://github.com/aws/aws-sdk-java-v2/issues/3162
[2] https://github.com/aws/aws-sdk-java-v2/pull/3175
[3] https://github.com/aws/aws-sdk-java-v2/pull/3178

Arf....
io.lettuce.core.RedisConnectionException: Unable to connect to localhost:49462
Caused by: io.netty.handler.codec.EncoderException: java.lang.NoSuchMethodError: io.netty.util.internal.ReferenceCountUpdater.setInitialValue(Lio/netty/util/ReferenceCounted;)V
Caused by: java.lang.NoSuchMethodError: io.netty.util.internal.ReferenceCountUpdater.setInitialValue(Lio/netty/util/ReferenceCounted;)V

Netty version alignement issue with the lettuce driver. We need to wait them to jump to 4.1.77 onward...
GRRRR


Fixed processing of model config file.

Bug
Instantiating models from configs did not perform some required checks performed when creating the model interactively.
Fix
Both use cases now go through the same checks.
Misc
This also required to update some test configs to avoid duplicate names.

Did a tiny bit to reduce complexity in c/model.py. Since a rework is in order for the model and propagation libraries in #99, this is postponed.


Contributors section in README.md

Issue Number
fixes #51

Describe the changes you've made
Added a credits section in our README.md file like this to recognize contributors in the project.
Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)
NA
Additional context (OPTIONAL)

Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Why are these tests not passing

Don't know, I only made changes in README.md file

Hi @Harshal0902,
I think the tests are failed because of the eslint errors,
Just take the pull from main branch and they will be resolve.

@Harshal0902 try deleting this PR, then pull the recent changes made in the readme and then try adding these changes and then make a PR. Due to constant PR's in the readme this error maybe occuring


Obfuscator is breaking my jar (it wasn't before - I think that's because of the plugin size)

Bug Report
Expected Behaviour
The plugin should work and not crash because of an error caused by the obfuscator.
Actual Behaviour
There's an error that is caused by the obfuscator.
https://pastebin.com/K7M62Rkd
How to reproduce the behaviour
Not sure how to replicate it, I am pretty sure it has to do with the file size tho (maybe I am wrong). Here is my configuration anyways:
https://pastebin.com/yXXdRRXS

(The original plugin size is 740kb)

Disable FlowObfuscator::MangleSwitches

yeah, seems like it works. Looks like this option is broken.


fix: file size limit in comment body

also adds  minor improvement to failed msg

Can this be merged @ppremk ? 🙏


Plagiarism cases: Send emails for notifications posts in plagiarism cases

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Motivation and Context

Currently students are not notified via email that they received a plagiarism case, even though they should.
Description

This PR adds email templates and makes sure that they’re sent when a plagiarism case is notified.
Steps for Testing

Prerequisites:

1 Instructor
1 Student
Your own account
1 Exercise

Log in to Artemis
Participate with both students (your account and other student)
Check for plagiarism in that exercise (you might have to decrease the needed similarity)
Confirm the case for your user
Notify your user account about the case in the plagiarism overview of the course
Set a verdict
Check the emails in your mail client

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

I don't know much about the email related parts of the project, are emails always in English? I couldn't see German translations for the strings in messages.properties or PlagiarismVerdict.java that's why I asked.

I don't know much about the email related parts of the project, are emails always in English? I couldn't see German translations for the strings in messages.properties or PlagiarismVerdict.java that's why I asked.

You're right I missed that. Now the student can also receive their plagiarism case in German

Render the Markdown in the notification body correctly

I'll cover this in a follow up, where I refactor the emails. Otherwise we have to render the markdown in multiple places

Include the verdict information (percentage of point deduction or actual warning message) in the email

The email is mostly a notification that there is a verdict. But we could make the email more informative in the future


33 improve props pattern

What's new/changed?

Remove componentWillUpdate pattern and replace with componentDidUpdate
Refactor to allow props.content to re-render the component
Moved utils to separate file
Refactor caret position calculations
Refactor onKeyDown & onKeyUp handlers
Reactor handling of sanitise to remove trims leading & trailing whitespace, this can now be handled by providing props.sanitise as a function if this behaviour is required. This function will receive value and range as args, allowing the implementing code to decide how the value should be sanitised with additional information from the range.
Refactor of the unit tests, many were employing workarounds due to the previous approach taken within the component

@nijk I was facing the content prop update issue and I tried this PR with my project. The issue that I faced is that it is setting the caret position even when I pass focus prop as false. And I added my own keyboard navigation logic. So if there is any way we can disable it from props, it would be great. Thanks :)
Watching this PR now.

@sahildev-jd I'm afraid I don't fully understand what you require here. Perhaps you could provide a minimal reproduction of the issue in https://codesandbox.io?

@sahildev-jd I've taken a look at the code and think I see the issue now. I'll update this PR shortly

@sahildev-jd Can you pull the latest version of this branch and test again please?

@nijk Thanks for getting back so quickly. I tried with the latest version.
The focus issue is now solved but the original issue of content not getting updated with changing props is not solved now. The content was updating earlier when the content prop changed. But it's not working now.

That's interesting, the unit tests are all passing so I think I'm going to
need a code sandbox to progress this any further.
On Fri, 28 Jun 2019, 11:00 Sahil Dev<EMAIL_ADDRESS>wrote:

@nijk https://github.com/nijk Thanks for getting back so quickly. I
tried with the latest version.
The focus issue is now solved but the original issue of content not
getting updated with changing props is not solved now. The content was
updating earlier when the content prop changed. But it's not working now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ashleyw/react-sane-contenteditable/pull/52?email_source=notifications&email_token=AAMKMZC43ILULQA4JCDYD3DP4XOKJA5CNFSM4HB3AY5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYZU24Y#issuecomment-506678643,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMKMZHDK63EJ2IA4FACXOLP4XOKJANCNFSM4HB3AY5A
.

@sahildev-jd I haven't been able to replicate your reported issue with content not updating via props. I've created a Code Sandbox here that can be manipulated via the React dev tools to change the props. Please do clone the sandbox and adjust accordingly to demonstrate the problem.

Resolves https://github.com/ashleyw/react-sane-contenteditable/pull/57
Resolves https://github.com/ashleyw/react-sane-contenteditable/issues/56


Add Mohd Shukri Hasan's devcontainer templates

Update with my devcontainer templates repository: https://github.com/hsm207/devcontainer-templates
Adding templates for learning new technologies e.g. qiskit and contributing to OSS projects that have complicated setup steps but no devcontainer support.

@eljog have you had a chance to review the changes I made?


help cannot connect SSH

Hello, scaleway VM Cannot connect to SSH port 22, inboud open port 22

Hi Avenbreaks,
It seems this issue isn't related to the sdk-js, but to a specific product.
If so, then please reach out in the slack community.
If you still think this issue is related to the Javascript SDK, feel free to re-open this MR.
Have a nice day,
VIncent


How to check balance using HDWallet?

Current behavior
this code try! blockStore.calculateBalance(address: address) returns 0

Expected behavior
0.1 TBTC is in the test address
Steps to reproduce

Environment

BitcoinKit: ?.?
Xcode Version: 10.2
Swift Version: 4.2

The same problem

I do have same issue. Its not clear on how to check the balance. Frustrated over how I can use. Anybody happy to answer..?

Have you had any luck? HDWallet has an unavailable deprecated property but it is 0. I am just trying to convert WalletExample to work with HDWallet, since there is no Wallet. The code currently seems to take one address and calculate the balance from that by looking up in the database using some SQL statements.


updated content/zh-cn/docs/setup/production-environment/container-runtimes.md

original file: https://kubernetes.io/zh-cn/docs/setup/production-environment/container-runtimes/

I'm afraid this one will have some conflicts with another PR.
/hold

/hold cancel
Please address the comments.

merge conflict not properly resolved.
/hold

/approve
/hold cancel

/lgtm


Native Currency view

Ability to change display currency (show value in local currency and Seeds) as well as seeds.
Example 1,000 Seeds (10 USD) ... We can pull the conversion right from our contract for the USD price and use any number of currency conversions to get to the other currencies.

Closing as a legacy issue.


Support circular references (in order to remove "rel": "self" workaround)

doca uses "rel": "self" within the "schema" and "targetSchema" schemas more or less like an internal "$ref" to the containing resource's schema.  But "rel" is properly only a keyword in the link description object, so we should switch this to a  normal "$ref"

The problem here is that while json-schema-ref-parser (3rd party) supports circular references, json-schema-loader (ours) serializes the results in a way that does not.  Fixing this will require a significantly different approach, but a necessary one as circular references are quite useful in JSON Schema and should be supported in general.

As it turns out, PR cloudflare/json-schema-loader#3 from @justmoon will fix the failure of circular references to even load.  Additional work is needed in json-schema-example-loader to avoid infinite loops.

Is there any update on this? I would love to use this tool, but my schema has circular references. ¯_(ツ)_/¯

I've been doing some preliminary work, not all of which is visible here (a key need is to merge the code base of our internal theme and the public theme).
How extensive are your circular references?  If it is just referencing the containing file from within a request ("schema") or response ("targetSchema"), there is a workaround for that.

Dude! @stephencroberts I went to college with you!
Small world.

@handrews: Good to hear. Unfortunately, I think my circular references are pretty nasty:
{
  ...
  "definitions": {
    "components": {
      "comp1": {
        "type": "object",
        "properties": {
          "content": {
            "type": "array",
            "items": {
              "anyOf": [
                { "$ref": "#/definitions/components/comp1" },
                { "$ref": "#/definitions/components/comp2" }
              ]
            }
          }
        }
      },
      "comp2": {
        "type": "object",
        "properties": {
          "content": {
            "type": "array",
            "items": {
              "anyOf": [
                { "$ref": "#/definitions/components/comp1" },
                { "$ref": "#/definitions/components/comp2" }
              ]
            }
          }
        }
      }
      ...
    }
  }
}

The list of components can contain any of the other components.

@jculvey I remember! So funny meeting here of all places after a decade.

@stephencroberts yeah, tree structures won't work right now.
What I've done so far is create a generic visitor function for hyper-schema that can apply transformations in a modular way.  I need to replace pretty much all of the guts of json-schema-example-loader with that (it will also get released as part of a more generic JSON Hyper-Schema utility package, probably).
I still need to solve the recursion problem, though.  Either by keeping track of what schemas have been seen and stopping as soon as a loop is detected, or by adding an extension keyword to indicate that a static processor should not dereference a particular $ref.  I haven't worked through it enough yet to figure out if the loop detection thing will consistently produce the desired output.
What is your timeline?  And for that matter, what about doca is makes it a tool particularly worth investigating for you?  And are you sticking with JSON Schema draft-04 or would you be interested in draft-06 (or draft-07 in about two months) support?  I'm just trying to get a better feel for what interests people so as not to accidentally break those things :-)

I'm speaking out of ignorance here, but how do the validation tools handle circular refs? Some of them fail, but it seems the majority of them have figured it out.
I don't really have a timeline -- it's more of a nice-to-have. I'm only interested in docs for a JSON Schema, not a Hyper-Schema. I would like to provide some readable documentation on a pretty complicated schema and doca seems to be the only tool out there that can do it. I tried one other tool but it failed to handle arrays with anyOf and the UI wasn't particularly attractive. Doca has a really nice ui.
I'm also not tied to draft-04, if a later draft would help me solve my problems better, I'd be interested. I didn't see any changes in 06 that would give me major advantages.
I'd be interested in contributing if there's anything I can do to help. :-)

References are supposed to be evaluated lazily, in the context of an instance.  So while your tree schema would produce infinite recursion if we tried to flatten it on its own, given an instance document you will eventually reach leaf nodes and stop processing references.
As doc generators work without instances, they need to have other ways to recognize and handle cycles.
I assume you mean the doca-bootstrap-theme UI?  One thing that we do need is for updates to be made to that UI to work with newer versions of json-schema-example-loader.  And do things like support more than one level of nesting for arrays/objects/etc.  Right now I don't have time to maintain both the public and internal themes (or converge the component source code and just handle themes through styling, which is the proper long-term solution).
You can see the changes that the theme needs to pick up in json-schema-example-loader's CHANGELOG.  Some of the needed changes are filed here as issues, some have not been filed (e.g. there is no issue filed to update the extension property names).  Let me know if you decide to take a look and need any pointers.  It's probably not that much work.
Currently doca expects at least a little hyper-schema usage to identify which things are resources, but it shouldn't be hard to make an option to just document the object properties without endpoints (in which case we would want the object properties section to not start out collapsed, which I think it does in the bootstrap theme as well as the Cloudflare one).  That would also be in the theme so another reason to poke around there.
As for draft-04 vs draft-06, most of the changes were in Hyper-Schema.  const is nice but inessential.  propertyNames is great if you need it, and offers a less problematic way to check for misspelled keywords than the ever-problematic "additionalProperties": false, although it is more verbose.  It also formally includes examples (note plural: json-schema-example-loader needs support for this as well).
draft-07 will include if/then/else which will make conditional processing (and its documentation) much more intuitive.

This set of packages is being deprecated in favor of the JSON Schema Tools monorepo.  Contributions are still welcome here but most work will be done on the new packages.
This issue is now tracked at cloudflare/json-schema-tools#2


default handler for 404 metrics to '404'

To address #144

Coverage increased (+0.07%) to 46.194% when pulling 9135629a44eadc95e4163ba11aeb47d3b02cc1d1 on oliver-nyt:oh_fix_404_metrics into bec4a802d517edc9ce935efbf4981b0e81db509d on NYTimes:master.


Omnipod > Diasend/Glooko

If using Omnipy, am I right in assuming that there is no way to get the insulin delivery into Diasend/Glooko? With the PDM you can upload this device, but I assume that information is stored in the PDM, and can not be backfilled from the pod itself at a later date to be uploaded ?
Thanks

Yes, everything you have just said is correct. The way glooko works is by getting data from pdm, so no pdm, no glooko.


Karspesky detects it as a trojan

Describe the bug
Event: Blocked Application: Host Process for Windows Services
User type: Active user
Component: Proactive Watchdog
Result description: Blocked
Type: Trojan Name: PDM:Exploit.Win32.Generic
Threat level: High
Object type: Process Object path: c:\windows\system32\windowspowershell\v1.0
Object name: powershell.exe Database publication date: Today, 07/28/2023 06:20:00 a.m.
To Reproduce
Steps to reproduce the behavior:

Karspesky installed and running
Run the ps command

Additional context
I hate antivirus but the company does not allow to remove it. This could be a problem for new users.

This happens on any system modification powershell script. Kaspersky flags almost everything and has a ton of false positives.


Decaffeinate remaining spec files from list-spec on

This PR is meant to supersede https://github.com/pulsar-edit/ppm/pull/35.
Honestly, I don't think there is an easy way around it - I took all the commits from @GuilleW, readded the semicolons and compared the files to the decaf branch state of things, much like a review. Sometimes new code needed to be added, sometimes nodeVersion needs to be read from config, sometimes the function signatures could be improved.
I don't think there are more grandiose changes than previously but the amount of them is relatively big compared to the single-file PRs.

@2colours Glad to see we are almost at the end of the decaf work on spec files!
Since I'm assuming this is the last one on the list. But want to mention, specs are failing here, so it seems something's not happy with this decaf

@confused-Techie Yes, well, that was to be expected, this time around I only had a vanilla Meld to aid me so even a sneaky syntax error is imaginable. Just please, if you know where the error is, do tell me, I don't even know what "the specs are failing" means in practice.

So in programming, specs or tests refer to tests run against the code. Oftentimes on GitHub, tests or specs will be run automatically during PRs. like you'll see on this PR we have several tests/specs that run on every PR you've made. And here they are all failing. If you click on the details link of the test run it'll show you a CLI output of the test that will tell you exactly where the error is, or whatever output the testing framework shows for test runs.
If we click on the details of yours it does in fact show that there was an unexpected ) on line 165 of the list-spec.js file. So presumably we could take a look at that line to see what was going on. (Which I've done, but didn't seem to fix any of the tests. Meaning the JavaScript code you've submitted is invalid somewhere else.)
Generally, as PR's are a way of saying here is my code that I think would be good to submit, it's up to the one making the PR to investigate what's gone wrong. Because I didn't know what had gone wrong, since I just saw the failing status. Don't worry I'll check it out and get it fixed.

Generally, as PR's are a way of saying here is my code that I think would be good to submit, it's up to the one making the PR to investigate what's gone wrong.

In this particular case, though, since I'm just a mere "garbage collector" who doesn't even use this software, let alone actively develop it, I think it would be kind of unfair to expect me to set up the whole environment for myself to test things out. The whole premise is that I can do something so somebody else doesn't have to, it doesn't mean that I will "double down" on it, should something go off, that's above my paycheck.
Of course, it would be different if there were a ready-made environment (a Docker container for example) that somebody can just quickly load and use without much hassle; or if the named CI builds didn't tend to fail even for pull requests that were apparently right.
Anyway, now that I'm back home, I was going to check at least the syntax either way, and there isn't necessarily much more that should be done, hopefully.

Thanks for fixing the tests. They are passing again.
I will hope to make some progress reviewing these PRs soon. (This one is a big one, of course, but it can be reviewed file by file, and individual files can be marked as "seen" in the "changed files" tab, to make it easier for reviewers to do part of the review and come back to it in another session, at least I think it saves these markings across sessions? Worth trying.)


feat: Create support an external addons

Description
In this new functionality the idea is
we have the possibility to install external/additional addons, that is, the addons that are not installable by the aws_eks_addon resource.
Motivation and Context

Currently there are components/addons that are ideal for a functional installation of an EKS Cluster, at least to have a good functioning and that it is possible to implement applications without great complexities.
We have examples of addons that fulfill this role: Cluster Autoscaler, Metric Server, AWS Load Balancer Controller, etc.
In this way, the creation of additional/external addons opens the possibility of implementing several others (currently we contemplate only Cluster Autoscaler).
Breaking Changes

NDA
How Has This Been Tested?

[ x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ x] I have tested and validated these changes using one or more of the provided examples/* projects

[ x] I have executed pre-commit run -a on my pull request

Mentions
@snifbr - Great technical support and amazing conversartion <3

we are not adding those here - you can check out https://github.com/aws-ia/terraform-aws-eks-blueprints-addons

@bryantbiggs Thanks for the tip! It was inside the blueprints repository.

whats inside the blueprints repository?

Sorry for my bad english haha.
I just realized that this code is in another repository.
In addtional, @bryantbiggs, there are two repositories with addons: the one you showed me (terraform-aws-eks-blueprints-addons) and this one terraform-aws-eks-blueprints. Which the "community" recomends to use?

https://github.com/aws-ia/terraform-aws-eks-blueprints
Modules/addons are no longer available in https://github.com/aws-ia/terraform-aws-eks-blueprints and the last remaining helper modules will be removed soon https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/1699

Nice! Now I know which repository I will contribute haha. Thanks @bryantbiggs!


Integration with OpenAI API

I’m looking to understand the expected timeline for integrating this system with the OpenAI API. Could you provide any details on when this integration might be available or if there are any updates on its progress?

Hey, as you can see we currently have a PR for OpenAI API integration that is very close from being merged. Such integration will definitely be available by the end of this week 🤗

@eustlb
That sounds amazing! I'm really excited about the OpenAI API integration and can't wait to see it in action. Looking forward to the final merge this week and exploring the new capabilities it will bring. Keep up the great work!

The OpenAI API PR (#81) is now merged!
Use it with the following parameters: --llm open_api --open_api_api_key YOUR_API_KEY --open_api_init_chat_prompt "You are an helpfull AI assistant" --open_api_stream True --open_api_model_name gpt-3.5-turbo


consistent treatment of literals

This is a minor cleanup to handle all the types of SqmLiteral in the same place, with consistent code.

This was merged into #2863.


⚠ Bofrost.lu has degraded performance

In 13825e6, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1718 ms

Resolved: Bofrost.lu performance has improved in b22fb29.


Allow users to set personal configuration details

[ ] Show or hide dicelang command in Atropos' reply to a +roll request

Not really necessary, since functions are transparent in their representation and can be reviewed on a simple call. Users cannot obfuscate their operations unless they create private functions in a private channel, in which case, other users are not obliged to regard them as fair.


Add the possibility to reorder the repositories

Fixes Issue

Closes #9810
Changes proposed
I added the possibility to reorder the user repository.
When the repos are returned, they are retrieved in saved order.
The mechanic used is the same as for user links reordering, just adjusted it a bit

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Hi @eddiejaoude checked out the adding part and that is true! Working to fix that!

Okay @eddiejaoude i fixed all previous issues, it should be okay by now!

Sorry, on this now 👍

Sorry for the delay! Yes you're right, fixing it rn!


Add support for Mysql flexible Server

Introduces initial release for MySQL flexible server. CI scenarios and examples. Separate PR will be done for CAF and CAFName

@arnaudlh this is ready to merge


🐛 Alerts appear behind navbar

Describe the bug
Admin alerts (runtime errors) are obscured by the navigation bar

What if we could get toast notifications to work instead?
https://getbootstrap.com/docs/4.5/components/toasts

Didn't work


doc strings for most important gates/circuits #54

-Added new doc strings for important gates & functions
-Added documentation nav for  circuit,parametric, primitive in mkdocs.yml
-To generate documentation added  sub dir in docs \documentation\modules

Hi! Awesome, thanks for this! expect a review until tomorrow ideally :)

hey, can you make sure the CI passes on your branch? you can double-check the list here how to run linting/tests. i think its just a minor linting issue though! thanks

@dominikandreasseitz   :)   ok yeah  line char limit for lint was 100 char  per line , I updated commit   :)

can we automatically compile this into the documentation?

everything looks good to me! @prilcool you know what i was thinking? :) i discovered https://github.com/pycqa/pydocstyle, if you want, could you have a look into how to integrate it into the tests + CI pipeline such that every docstring gets automatically formatted/checked. i tried it out already but it complains a lot and i guess you have to put a lot of ignores etc. maybe you find out more :)

i closed it

i closed it

Thanks ,ok yes  @dominikandreasseitz I will go through this   https://github.com/pycqa/pydocstyle  and get  back .
It says  by default  it supports Pep -257 naming conventions for docstring ,  https://peps.python.org/pep-0257/
so most lkely is to modify all the docstrings to meet that or  put ignores

@dominikandreasseitz  bro  I just got email from Nate  Stateman
It says bounties will be only paid if PR  is merged before June 20th .

@prilcool ok, so i can merge it today! dont worry about the pydocstyle stuff then :)


Add Menu Sorting to Look Ahead

i.e. Same as #12 but on Look Ahead View

Closed with f1b3d27

Closed with 043abc2


Add comments to code

Hi, I see that you do not have any comments in your code. It would make it much easier for others to work on it if you commented your code. What I usually do is I ask chatgpt or whatever ai I am using to comment it for me.

I'd like to get onto this issue next, but since the code is still being refactored, I don't think it would be wise to add comments at this point of time


add publishing workflow to rank

Workflow:

yarn devInit
work on query
yarn devPublish images images-fancy-pants-index
Change the query in scala till it matches the JSON
voi la

Next will be the update index workflow, which will be more conveluted as the index is actually stored in catalogue-pipeline.


[observability] exclude health probes and metrics endpoints from traces

Currently, all calls to /healthz and /metrics are traced. Those should be excluded.

[x] OrdersService
[x] ProductsService
[x] Gateway
[x] AuthenticationService
[x] ShippingService
[x] OrderMonitorService
[x] NotificationService
[x] PriceDropService
[x] PriceWatcherService

must be merged into main

With merging ab56d9e into main this is finally done ✅


Add directory key to package.json repository

Description
TL;DR
#1224 should have made this change instead:
 "name": "@shopify/{{name}}",
 "repository": {
   "type": "git",
   "url": "git+https://github.com/Shopify/quilt.git",
+  "directory": "packages/{{name}}",
 },

Details
This follows up on #1224, which updated the repository fields, in an effort to improve support for tools such as Dependabot to deep-link into the repo:
 "name": "@shopify/{{name}}",
-"repository": {
-  "type": "git",
-  "url": "git+https://github.com/Shopify/quilt.git"
-},
+"repository": "https://github.com/shopify/quilt/tree/master/packages/{{name}}",

While these links do work, they still did not improve integration with Dependabot.
After speaking to Dependabot support, and being referred to React's package.json repository entry, it looks like specifying the additional directory key is the answer:
 "name": "@shopify/{{name}}",
-"repository": "https://github.com/shopify/quilt/tree/master/packages/{{name}}",
+"repository": {
+  "type": "git",
+  "url": "git+https://github.com/Shopify/quilt.git",
+  "directory": "packages/{{name}}",
+},

This makes that change, fixes some other small inconsistencies, and adds tests along the way.
Type of change

[x]  Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above

@GoodForOneFare, I've added a commit in which I switch to pre-compiling the expected template for each package, instead of using compile on a per-value basis. It does look much cleaner, while keeping things based on the template, though at the cost of generating the expected contents each time (probably fine).

I've addressed all exceptional packages and lint errors:

polyfills now specifies files: ["dist/*", "!tsconfig.tsbuildinfo"]
csrf-token-fetcher, dates, react-effect, react-google-analytics, and useful-types have had sideEffects: false added
graphql-persisted now exposes a main entrypoint which re-exports the existing entrypointsimport * as apollo from './apollo';
import * as koaMiddleware from './koa-middleware';

export {apollo, koaMiddleware};

@GoodForOneFare, should these changes have accompanying changelog entries? Should they be in a separate PR, or are they fine here?

RE changelog entries, I guess they have to be part of this PR.  Otherwise, any merge gap between this and a changelog PR will result in someone else having to release everything.


Null Reference on Build

Hey, I'm getting this when building the project:
  Sharpliner.targets(20, 5): [MSB4018] The "PublishDefinitions" task failed unexpectedly.
System.NullReferenceException: Object reference not set to an instance of an object.
   at PipelineGenerator.ApiContractTestsPipeline.get_Pipeline() in C:\repo\pipeline\generator\PipelineGenerator\ApiContractTestsPipeline.cs:line 15
   at Sharpliner.AzureDevOps.PipelineDefinitionBase`1.get_Validations()
   at Sharpliner.SharplinerPublisher.Validate(ISharplinerDefinition definition, String typeName)
   at Sharpliner.SharplinerPublisher.PublishDefinition(ISharplinerDefinition definition, Boolean failIfChanged, Type collection)
   at Sharpliner.SharplinerPublisher.Publish(String assemblyPath, Boolean failIfChanged)

My pipeline looks like this:
using Sharpliner;
using Sharpliner.AzureDevOps;
using Sharpliner.AzureDevOps.Tasks;

namespace PipelineGenerator;

public class ApiContractTestsPipeline : SingleStagePipelineDefinition
{
    private const string Always = "always()";

    public override string TargetFile => Path.Combine("ProfileApi", "pipeline", "azure-pipeline-contract-validation-tests.yml");
    public override TargetPathType TargetPathType => TargetPathType.RelativeToGitRoot;

    public override SingleStagePipeline Pipeline => new()
    {
        Trigger =
        {
            Branches =
            {
                Include = { "develop" }
            }
        },

        Resources = new Resources
        {
            Repositories =
            {
                new(new RepositoryResource("ApiContractsRepo")
                {
                    Name = "Core/MyOtherRepo",
                    Type = RepositoryType.Git
                })
            }
        },

        Variables =
        {
            new(new Variable("ENVIRONMENTNAME", "10")),
            new(new Variable("ENVIRONMENTTYPE", "test")),
            new(new Variable("IS_CONTRACT_TEST_RUN", true)),
            new(new Variable("GitBranchName", variables.Build.SourceBranch)),
            new(new Variable("ApiContractSpecLocation",
                $"{variables.System.DefaultWorkingDirectory}/MyOtherRepo/my-proj/api/my-proj-v2.yaml")),
            new(new Variable("ApiUrl", "https://my-api.example.com")),
        },

        Jobs =
        {
            new Job("RunApiContractTests", "Run API Contract Tests")
            {
                Pool = new Pool("windows-latest"),
                Steps =
                {
                    Checkout.Self,
                    Checkout.Repository("ApiContractsRepo"),

                    DotNet.Restore.Projects("'**/MySolution.AcceptanceTests.csproj") with
                    {
                        NuGetConfigPath = "my-proj-api/nuget.config",
                        DisplayName = "Restore Acceptance Test Packages"
                    },

                    DotNet.Build("'**/MySolution.AcceptanceTests.csproj") with
                    {
                        Arguments = "--configuration Release --no-restore --framework net5.0",
                        DisplayName = "Build Acceptance Tests"
                    },

                    Task("NodeTool@0", "Install Node") with
                    {
                        Inputs = new TaskInputs
                        {
                            { "versionSpec", "14.x" },
                            { "checkLatest", true }
                        }
                    },

                    Script.Inline("npm install -g @stoplight/prism-cli", "Install Prism"),

                    Powershell.File("my-proj-api/ProfileApi/pipeline/RunProxyTests.ps1", "Run Contract Validation Tests") with
                    {
                        Arguments = $"{variables["ApiContractSpecLocation"]} {variables["ApiUrl"]}"
                    },

                    Task("PublishTestResults@2", "Publish Test Results") with
                    {
                        Condition = Always,
                        Inputs = new TaskInputs
                        {
                            { "testResultsFormat", "VSTest" },
                            { "testResultsFiles", "**/*.trx" },
                            { "failTaskOnFailedTests", true },
                            { "testRunTitle", "Contract Validation Tests" },
                        }
                    }
                }
            },
        }
    };
}

Hey @thomhurst,
I quickly checked and it seems (or VS is giving me) null reference assignment in the Trigger. Seems like this should help:
        Trigger =
        {
            Branches =
            {
                Include = { "develop" }
            }
        },

into this
        Trigger = new Trigger("develop"),

should do the trick. I will make it so that this doesn't happen.
Meanwhile couple of tips to improve the code:
// This
        Variables =
        {
            new(new Variable("ENVIRONMENTNAME", "10")),
            new(new Variable("ENVIRONMENTTYPE", "test")),
            new(new Variable("IS_CONTRACT_TEST_RUN", true)),

// can be turned into this:

        Variables =
        {
            Variable("ENVIRONMENTNAME", "10"),
            Variable("ENVIRONMENTTYPE", "test"),
            Variable("IS_CONTRACT_TEST_RUN", true),

Same for the new() around the RepositoryReference.
Hope this helps and let me know if you have any other issues!

That fixed it, and thanks for the tips!