The tasks in beforeRelease and beforeBump actually run after the release was done

I added a build task in beforeRelease but it doesn't actually run before the release is done. Here's the output:
Running "release:0.0.99" (release) task
>> running beforeRelease
>> bumped version of bower.json to 0.0.99
>> staged bower.json
>> Committed all files
>> created new git tag: 0.0.99
>> pushed to remote
>> pushed new tag 0.0.99 to remote
>> created 0.0.99 release on github.

Running "clean:dist" (clean) task
Cleaning dist/images...OK
Cleaning dist/scripts...OK
Cleaning dist/styles...OK
Cleaning dist/views...OK
....

+1

:+1:

:+1:

According to the docs tasks passed to the grunt.task.run call "will be run immediately after the current task completes". My workaround is to register a new task which calls my build task before the release task.
:+1:

That workaround won't work for my project. We have items in the build that reference the version so we need

Version bump
Build the project
Commit / tag / push

I tried using targets but grunt-release only works with the [major,minor,patch,prerelease] targets as far as I can tell.

:+1:

+1

@chrisprice The problem is that the "current task" is "release" and the beforeRelease-tasks are being run after release (which is too late).

+1

Thank you for the work. I've merged it new. There will be a new version with more fixes and stuff.


ADDING NEW FUNC TO XXX

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jdjjd


Initial FHIRCast setup

coverage: 94.03% (+0.008%) from 94.022% when pulling 577901dc90cb24a38aa3c6ca8caa40168629d911 on cody-initial-fhircast-setup into 3b35daf1bc098f53a13865bffc7da17d5584f7d2 on main.


Oracle JDK8 is EOL. Use OpenJDK

Codecov Report

Merging #68 into master will increase coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #68      +/-   ##
===========================================
+ Coverage     54.96%   55.6%   +0.64%
- Complexity      559     565       +6
===========================================
  Files           106     106
  Lines          2540    2552      +12
  Branches        139     139
===========================================
+ Hits           1396    1419      +23
+ Misses         1063    1058       -5
+ Partials         81      75       -6

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/axibase/tsd/model/data/Property.java
87.5% <0%> (-6.25%)
15% <0%> (-1%)

...java/com/axibase/tsd/client/HttpClientManager.java
79.12% <0%> (-6.07%)
23% <0%> (ø)

...c/main/java/com/axibase/tsd/client/HttpClient.java
81.39% <0%> (+0.14%)
33% <0%> (ø)
:arrow_down:

...om/axibase/tsd/client/DefaultStreamingManager.java
36.25% <0%> (+4.49%)
16% <0%> (+3%)
:arrow_up:

...a/com/axibase/tsd/client/PlainStreamingSender.java
54.41% <0%> (+9.55%)
20% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8500278...4bc392d. Read the comment docs.

Naturally, after an Oracle conference, it's time to ditch its JDK :)


Levers

[x] Stone and variants

[x] Mossy Cobblestone

[x] Granite and variants

[x] Andesite and variants

[x] Diorite and variants

[x] Stone brick variants

[x] Ensure they work

[x] Get in-hand model rotation right

Features are complete, awaiting changes to be cherry picked from #11 (I'll do it in the morning, don't trust myself to not mess up right now :p)


Error with the latest version

Hi,
After updating the plugin today an error appears and Nerdtree doesn't show
I'm using neovim and NERDTree 6.9.3 (latest)
An error detecten when processing function 188[2]..189[20]..192[8]..156[25]..154[15]..266[5]..NERDTreeGitStatusRefreshListener[5]..NERDTreeGetGitStatusPrefix:
line    6:
E716: The key doesn't exists in dictionary: Slash()
Press ENTRAR or introduce a command to continue

Thanks

I've got a similar problem with the same version.
Error detected while processing function 188[2]..189[20]..192[8]..156[25]..154[15]..266[5]..NERDTreeGitStatusRefreshListener[5
]..NERDTreeGetGitStatusPrefix:
line    6:
E716: Key not present in Dictionary: Slash()
Error detected while processing function 188[2]..189[20]..192[8]..156:
line   25:
E171: Missing :endif

nerdtree removed the 'Slash' function, i'm trying to find a resolution

@ixdi @sol-austin should work now


ItemImplBuilder, ItemImplItemBuilder, ConstBuilder, ItemConstBuilder, MethodBuilder refactor, float literal support

Refactor MethodBuilder to be simpler, have a default starting point, and more flexible in terms of composing its parts. It can be used generically for composing either a MethodImplItem or a MethodTraitItem.
Add ConstBuilder, a generic const builder that can be used generically for composing either a ConstImplItem, ConstTraitItem, or an ItemConst.
Add float support to LitBuilder and ExprBuilder.
Add ItemImplBuilder and ItemImplItemBuilder to compose ItemImpl and ImplItem nodes.

This is a final state for this PR. Feedback is appreciated, thanks! I'll be coding my project against this work :)

I have some incoming work (more expr types).


Missing log level keys and fallback

What happened:
When using --template with the function levelColor it prints this error, without the log entry, when encountering level keys it's not familiar with.
expanding template failed: template: log:1:148: executing "log" at <levelColor $d.levelname>: error calling levelColor: runtime error: invalid memory address or nil pointer dereference

What you expected to happen:
I expect the most common level keys to be handled and a fallback to exist instead of generating an error.
How to reproduce it (as minimally and precisely as possible):
Produce "warning" and "critical" logs from a Python application. These two levelnames are not handled.
If stern could read from stdin (I couldn't find that it does at least) it could have looked something like this.
echo '{"levelname": "warning"}' | stern --template='{{with $d := .Message | tryParseJSON}}{{levelColor $d.levelname}}{{end}}{{"\n"}}'

Anything else we need to know?:
I'm submitting a PR for this in a moment.
Environment:

stern version (use stern --version):

version: 1.24.0
commit: 68305a0ab1383053166b7b606ad167b43fc6b329
built at: 2023-03-12T06:50:44Z

OS (e.g: cat /etc/os-release): Arch Linux
Install tools (e.g: Homebrew): Arch AUR https://aur.archlinux.org/packages/stern-bin

PR merged, closing


Add code style

Add GitHub workflows similar to zkfold-base. Use the same stylish-haskell style.

Also clippy can be used for linting Rust code


Output extra optional data from parser for scrapers.

Some scrapers already export extra information, like ICU, Vent,
Hospitalized, Recovered.
Export this optional data from parser, and consume in add_db_entry.py
Closes: https://github.com/openZH/covid_19/issues/237

I am open to suggestions before merging this.

LGTM, I will test this for some scrapers tonight and then give feedback or merge.

Looks good, just a minor issue.

Fixed.

Thanks @baryluk!


update log

add update log please because you update osiris every week xd

~Redundant Duplicate of #2297 by the same user @uzdiiilekk
All commits are self-explanatory. New features or reworked features are in the README. Most of the updates are optimizations. We've already solved this. There is no need for an update log if you can do a little bit of reading.
Please Close This Issue.


Setup Google Analytics

Setup Google Analytics for the Kindly's public website at https://kindly.unicef.io

I would love to do this with you, if you don't mind.

Thanks @Ifeanyi30 for your interest. That was a fairly trivial task, which was implemented int his commit 81d8f87e0d2095c2d96cdfa231f9b0f46e1cd7eb. If you are interested, you can learn more about the react-ga4 package, or a guide like this one

Thanks @lacabra


about Min()

https://github.com/mbdavid/LiteDB/blob/master/LiteDB/DbEngine/DbEngine/Aggregate.cs#L12
 should be ？

Yes, it´s open database to access collection page/indexes references.

I means should be return a "long" type instead of BsonValue?

No, because collection didn't know which data type your ID class has. You can use Min to Date, Int, Guid, String, ... And if there is no document, LiteDB returns BsonValue.MinValue

but in source code, it appears as "long", not BsonValue, that's my question
https://github.com/mbdavid/LiteDB/blob/master/LiteDB/DbEngine/DbEngine/Aggregate.cs#L12

Oh, you right...  thanks.


Move event not firing in Firefox without forceFallback

I've tried master and dev and sometimes, I cannot get Firefox to start dragging unless forceFallback is set to true. I'm using that now, but I think there's an issue with Firefox sometimes not initializing the drag start when draggable is set. When I click my handle, I'll see draggable=true and the classes are added, but nothing happens when you start dragging.
This was happening when my drag handle had another element over it. The click events work on the button but drag events never happen.
Think it might be related to http://stackoverflow.com/questions/13920345/html-drag-event-does-not-fire-in-firefox.

Related: https://bugzilla.mozilla.org/show_bug.cgi?id=646823#c4

Just faced this issue, at least with v1.5.0-rc1, not sure if also with previous versions. forceFallback: true solved it. In our scenario, we had items in a list, each one of them with button acting as the drag handle, next to other buttons as well.

Please add an example, to I can reproduce the problem.

Hi, no quick and ready example available at the moment, sorry. Not sure it may help, but here's an excerpt of the interested bits:
This is the generated HTML, produced out of an Angular SPA:

        dbColumnName

        uiLabel

        uiLocation

        formatType

          actions

        <list-item>

dbColumnName 1

uiLabel 1

uiLocation 1

              formatSample 1

                <button type="button" class="btn btn-xs btn-default drag-handle">

                  move
                </button>

                <button type="button" class="btn btn-xs btn-primary">

                  edit
                </button>

                <button type="button" class="btn btn-xs btn-warning">

                  delete
                </button>

        </list-item>

        <list-item>

dbColumnName 2

uiLabel 2

uiLocation 2

              formatSample 2

                <button type="button" class="btn btn-xs btn-default drag-handle">

                  move
                </button>

                <button type="button" class="btn btn-xs btn-primary">

                  edit
                </button>

                <button type="button" class="btn btn-xs btn-warning">

                  delete
                </button>

        </list-item>

        <list-item>

dbColumnName 3

uiLabel 3

uiLocation 3

              formatSample 3

                <button type="button" class="btn btn-xs btn-default drag-handle">

                  move
                </button>

                <button type="button" class="btn btn-xs btn-primary">

                  edit
                </button>

                <button type="button" class="btn btn-xs btn-warning">

                  delete
                </button>

        </list-item>

From the same app, this is the value passed as options:
this.dragOptions = {
  onEnd: this.onListItemDragEnd.bind(this),
  handle: '.drag-handle',
  // ignore the HTML5 DnD behaviour and force the fallback to kick in
  // NOTE: without this, dragging does not start in Firefox and MS Edge
  forceFallback: true,
};

We're using a wrapper library around Sortable, angular-sortablejs, and already talked through the issue with author: the library apparently is just wrapping Sortable behaviour and making it available to Angular components.
Sorry for not being able to provide a complete working example.
HTH


Have anybody used the Nvidia NVENC？

I use the
-c:v h264_nvenc -pixel_format yuv420p -preset default
to start the NCENC output video，the output is successful ，but the speed increase is not obvious, and the CPU usage is still very high.
My graphics card is P2000, after turning on the NVENC encoder which only takes 5%. I am not familiar with the ffmpeg command. Can anyone help me?

This feature was properly implemented in version 2.28.


Build: minify js file

the js build file lookout.js is right now half a MB gzipped (which is what github serves) and 2.5 MB uncompressed
it'd be nice if we setup webpack to minify that thing on production build

@Olamuhammed this may actually not make any sense if github is gzipping the file already 😂 but why not try it out and see if it gets any better


Update SOFTWARE-LIST.md

Added PHOENIX CONTACT, Siemens Healthineers, and Thermo Fisher Scientific.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Add a tag or create a release.

thanks, was it because of a * character?


CI requires formatting, but the project doesn't specify which one

Problem
I have a custom system-wide rustfmt configuration, which doesn't match what Cargo wants, and running cargo fmt on my machine causes a complete mess.
Please add rustfmt.toml to the project to nail down the formatting required.
Steps
No response
Possible Solution(s)
No response
Notes
No response
Version
No response

As a maintainer of projects more generally, I don't want to add empty files to my projects (there are already enough random files). I'm surprised rustfmt supports this and think having a non-default settings is setting yourself up for trouble.
Others on the team may disagree, there might be reasons specifically for cargo to do this, or there might be a reason to change my mind. Open to hearing more thoughts.

I don't object to adding a file. Have seen contributors tweaking unrelated formatting in pull requests, I should have realized it might be a global rustfmt.toml doing that.
It makes the contributing process better, so I am in.

The global rustfmt config is painful indeed. But it's easier to add empty config files to reset defaults, than to have unchanged defaults and keep copying and maintaining copies of big non-default config files everywhere else.
The only problem with resetting to default, is that Rustfmt is not entirely idempotent/input-independent (e.g. wraps comments and that can't be undone). This makes it impossible to undo wrong accidental formatting by reformatting with the correct settings. A single mistake can ruin the work in progress, and it'd be better to prevent that reliably.

The global rustfmt config is painful indeed.

Could you help me understand your use case for why you do it?

For my day job, I'm writing domain-specific code that frequently uses certain code patterns that rustfmt doesn't have any dedicated rules for, and basically doesn't understand they exist. It applies its general heuristics, which in my case are a poor fit, and too often result in code that is significantly harder to follow and harder to maintain.
However, because "readability" is assumed to be subjective to the point it's impossible for anybody to state that something is objectively worse, and any disagreement with a universal style guide is suspected to be merely provoking an unproductive bikeshedding about unimportant details, I'm unable to convince anybody that there is a problem with rustfmt that needs fixing. People tell me to stop complaining, and just configure rustfmt the way I like it, so I did. Rustfmt doesn't have options to avoid ruining the specific code patterns that I care about, so I'm forced to tweak multiple other global settings to minimize rustfmt's disruptions.

In hopes to better undetstand what you are saying, is $DAYJOB that pushes back against changing their rustfmt config or the rustfmt team doesn't accept input?
If $DAYJOB needs some specific formatting, it seems like it should live $DAYJOB's repo and not on each users system.

I work on many more projects where I need my custom formatting than projects that reject PRs over formatting differences.

A custom config file is harder to maintain across many repos than the default config. I can't symlink to my ~/.rustfmt.toml, because that will work only on my machine. I'd rather not sync many copies across many projects, and I'd prefer cargo new to use my config.

The global config in rustfmt exists, and it conceptually clashes with an implied-default fmt --check in CI. I think in rustfmt as it exists today, the correct solution is to define the config to check against.

I've opened an issue about this dilemma.
The notion that formatting should be automated creates manual work for me either way, and that is really frustrating.

A custom config file is harder to maintain across many repos than the default config. I can't symlink to my ~/.rustfmt.toml, because that will work only on my machine. I'd rather not sync many copies across many projects, and I'd prefer cargo new to use my config.

If the formatting is common between them, then there are likely other aspects in common between them that people need to keep in-sync.  For myself, I keep https://github.com/epage/_rust as a merge-base (initially added via --allow-unrelated-histories) to keep CI workflows, lint config, etc common between all of my projects in an easy-to-update fashion.  Having a git-synced file shared between the projects seems like a much better on-boarding experience rather than asking everyone touching those code bases to have a user config.

The global config in rustfmt exists, and it conceptually clashes with an implied-default fmt --check in CI. I think in rustfmt as it exists today, the correct solution is to define the config to check against.

I feel this is patching over the problem.  This is further cementing user configs without helping the user not apply it when it isn't wanted, leaving the user to still wait until CI fails before they find out what happens.  If we define a config to check, then we'd have a blank file somewhere anyways so that seems to be shuffling things around.

The cargo team discussed this issue and have decided to close it as something we would prefer to not add at this time. In general we felt like the approach of using a global config is not a pattern we want to encourage. We understand that it is a problem dealing with a large config across other projects. I might suggest placing projects in subdirectories with a parent rustfmt.toml file that contains whether settings is appropriate for those projects.


baisakhi-sarkar/got summarizer streamlit UI

Draft Streamlit UI

Great work baisakhi! Please change the name of the python file to app.py.
Cheers!

Looks good! Merge approved.


Only Compile module-info.java in intermediate compile

Description
Updates the compile phases configured in the client parent POM to only compile module-info.java when compiling for the base module support. Also, this changes that compilation to use Java 9 to support the widest audience available even though most users using Java 9+ will be targeting Java 11 or 17 as they're the LTS versions.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


#text methods are broken

Hedron::Entry#text and Hedron::MultilineEntry#text both fail when called, with the message

type must be String, not Pointer(UInt8)

It looks like the issue is that both methods try to implicitly cast the Pointer(Uint8) (a.k.a LibC::Char*) into String via their return type, but that's not allowed. As mentioned in this Stack Overflow answer, the pointer should used to create a new String, so the following changes fix it for me:
diff --git a/src/hedron/ui/entry.cr b/src/hedron/ui/entry.cr
index b084b2e..ccdc950 100644
--- a/src/hedron/ui/entry.cr
+++ b/src/hedron/ui/entry.cr
@@ -42,7 +42,7 @@ module Hedron
     end

     def text : String
-      return UI.entry_text(to_unsafe)
+      return String.new(UI.entry_text(to_unsafe))
     end

     def text=(entry_text : String)

diff --git a/src/hedron/ui/multiline_entry.cr b/src/hedron/ui/multiline_entry.cr
index 6d977ae..1c688bf 100644
--- a/src/hedron/ui/multiline_entry.cr
+++ b/src/hedron/ui/multiline_entry.cr
@@ -46,7 +46,7 @@ module Hedron
     end

     def text : String
-      return UI.multiline_entry_text(to_unsafe)
+      return String.new(UI.multiline_entry_text(to_unsafe))
     end

     def text=(entry_text : String)

Happy to open a PR if desired. :)

Sorry for the late reply - sure, go ahead and open a PR! I'm currently in the process of rewriting most of the code of Hedron on my Windows device (because of lacklustre documentation and custom widgets), so it's fairly slow at the moment.


refactor!: add Async suffix to all async methods

close #39

Codecov Report

Merging #40 (1190cbd) into dev (d560a3c) will increase coverage by 0.14%.
The diff coverage is 30.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev      #40      +/-   ##
==========================================
+ Coverage   69.20%   69.35%   +0.14%
==========================================
  Files          61       61
  Lines        1442     1439       -3
==========================================
  Hits          998      998
+ Misses        444      441       -3

Impacted Files
Coverage Δ

src/Flandre.Adapters.Mock/MockBot.cs
46.00% <0.00%> (ø)

src/Flandre.Core/Common/Bot.cs
0.00% <0.00%> (ø)

src/Flandre.Core/Common/BotEvents.cs
0.00% <0.00%> (ø)

src/Flandre.Core/Utils/FlandreCoreUtils.cs
0.00% <ø> (ø)

src/Flandre.Framework/Common/Command.cs
77.50% <ø> (ø)

src/Flandre.Framework/Common/CommandExtensions.cs
0.00% <ø> (ø)

.../Flandre.Framework/Extensions/SessionExtensions.cs
100.00% <ø> (ø)

src/Flandre.Framework/Common/Plugin.cs
66.66% <40.00%> (ø)

src/Flandre.Framework/FlandreApp.cs
83.70% <66.66%> (ø)

src/Flandre.Adapters.Mock/MockAdapter.cs
100.00% <100.00%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Babel polyfill dynamic load

For the Babel polyfill for promises, have the script be dynamically loaded for the browser it is using if needed.

I'm not sure if this is really needed so I'll just close this.


Use --nginx option

I've tested this option and it works perfectly. Why not use it?

Thank you. I'll have to look into this. Not so long ago it was failing for me due to https://github.com/certbot/certbot/issues/921. It also used to overwrite portions of nginx.conf with older versions.
Apparently, it's working better now, but I'm still somewhat suspicious.
Two questions:

is --nginx required? I think it remembers the authenticator, so it's only needed once
is the systemctl reload nginx hook required?

And we'll also want to update the README with instructions for setting it up. Keeping the webroot section might not be bad, as it can be quite useful.

I didn't know that certbot remembers the authenticator, so maybe this pull request is useless.
I thought that I had the last version of the service file but I'm using "ExecStopPost=/bin/systemctl --no-block reload nginx" as the last release on AUR. It works just fine so I'm not really sure that the hook is needed or not. My mistake!

Sorry. I did some more tests, and it seems to be stable. To answer my questions:

is --nginx required? I think it remembers the authenticator, so it's only needed once

The renewal config file gets updated with the new authenticator, so there's no need to pass --nginx every time.

is the systemctl reload nginx hook required?

No, certbot-nginx does that automatically.
Given the two points above, the only remaining thing this package could do is simply run certbot renew, but then it should be renamed. There is, however, an unrelated certbot-systemd AUR package that does exactly that (it also runs systemctl reload nginx, which is useless).
So it looks like I should drop this package in favor of certbot-systemd. What do you think?

See also the discussion in https://github.com/parchd-1/certbot-systemd/issues/1.

I think you're right, infact I already switched to certbot-systemd without issues.

Closed in https://github.com/lnicola/certbot-systemd-nginx/commit/4d7478d1ca4788b042cfdb0fff26d12955916b5e.


Remove paragraph about extensions built with release builds are not compatible with debug builds

As an example of an ABI issue that many Python developers will encounter: a debug build of CPython is not ABI-compatible with a release build, hence if one wants to use a debug Python, one has to rebuild every package that uses the Python C API.

This is simply not true. The other way around is true. If you build an extension module with a debug build it is not compatible with a release build.

Thanks for catching that @isuruf! I'll fix that text soon.

Removed now. Even the reverse is mostly no longer true. From https://docs.python.org/3/using/configure.html#python-debug-build:
Changed in version 3.8: Release builds and debug builds are now ABI compatible: defining the Py_DEBUG macro no longer implies the Py_TRACE_REFS macro (see the --with-trace-refs option), which introduces the only ABI incompatibility.


Improved Tennis HUD and improved the CSS in Tennis

PR Description 📜
I improved the Score Heads-Up-Display in the game Tennis. I also commented some CSS code for the same code, which I thought was unnecessary, please do check the same.
Fixes #3336

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have specified the respective issue number for which I have requested the new game.

📸

Thank you soo much for contributing to our repository 💗

Thank you @VijaySamant4368 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @VijaySamant4368,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

Thank you  @VijaySamant4368 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Please do add the label for GSSoC 2024, as well as the level.


Ignore clang warnings due to unused stuff caused by glog

Looks... tolerable to me?

Makes me think of Windows code.


Fix for Issue #299: Correctly handle edge cases in formatValue and t…

…ype comparisons
To resolve Issue #299, specifically targeting improper handling of decimal input in the formatValue function. The const declaration for "value" is now replaced with let, allowing reassignment when input starts with a decimal . Consequently, decimal values are correctly prefixed with zero ('0'). Additionally, a conditional statement ensures this prefixing for such inputs.
Built and tested.

Hi @cchanxzy,
Just a quick note to highlight that PR #302 solves the reported issue and all tests are passing smoothly. Appreciate your efforts in maintaining this valuable library. If possible, could you consider merging this PR at your earliest convenience?
Thanks,
Lubna Naqvi

Please write some tests for the edge case you are fixing.
Sorry, and thank you for the feedback. This was my first issue fix...  in the future I will be sure to include new tests and only commit files relevant to the change (didnt even notice the other files were changed.


I just trademarked "Eddie Jaoude"

Pay up or I will be forced to sue.

thank you again for the test issue 👍 - no automated reply this time, it works 🎉


Implement Response builder helper fns

Just like Request has get, post, etc... helper fns, there should be equivalent helpers for Response.

I was looking at this and was about to begin but it dawned on me that responses don't have verbs. What are the helpers that should be built?

Response::ok() -> Builder etc... probably.
It's just a bit nicer than pulling in StatusCode.

Ah, that makes sense!

Is there a need for Response::ok()? The default status code is already OK, either with Response::new(body), or with Response::builder().

Well, I think that there is definitely use for other common status code helpers, and having ok seems useful for consistency (or someone will be looking for a while through the docs wondering why it isn't there).

It sounds like it's a question of explicitness vs implicitness. I am curious which other response codes make sense to add. My pr #154 has several, but not all, implemented.

Is there still strong desire for this? With 0.2 coming, I'd rather propose we don't do this, and remove the ones that exist for Request.

@seanmonstar why remove?

It would be useful to have From<StatusCode> for Response<Body>. I often need to create a response from a status code.


Cap log file size at 10MB

Uses the new code in BuildaUtils to automatically split log files when they reach 10MB. Be aware that it won't automatically delete old log files (but I suppose that's not something a sysadmin expects by default)
Fixes #142

Result of Integration 1
Duration: 5 minutes and 43 seconds
Result: Perfect build! All 33 tests passed. :+1:
Test Coverage: 23%

Thanks! Just two little things:

You'll need to merge master into this branch first, there are conflicts and I can't merge it.
Can you please run pod install with the latest public CocoaPods (0.39.0) please? The lockfile otherwise gets overwritten to an older version.

Thanks again, great work on this. 👍

Fixed. I use an old Cocoapods-version because 0.39 breaks a few pods that I need for work projects :(

Result of Integration 2
Duration: 1 hour, 38 minutes and 53 seconds
Result: -1 error, failing state: trigger-error

Result of Integration 3
Duration: 4 minutes and 51 seconds
Result: Perfect build! All 33 tests passed. :+1:
Test Coverage: 23%

Awesome, thanks for this! 🖖


Help!

Excuse my ignorance, but still did not understand how to have the script to work, put I saved the Shuntfile file and how do I call the task?
Would someone send me an example?
I thank everyone's attention.

There is an executable for Shunt that will pick up your task
cd /path/to/your/root/project
bin/shunt


google-cloud-storage==0.20.0 on GAE will get ImportError

OS type and version: GAE (debian?)

Python version : python 3.4  to run Flask

google-cloud-python version:

google-api-python-client (1.5.5)
google-cloud-core (0.21.0)
google-cloud-storage (0.20.0)
googleapis-common-protos (1.5.0)

Stacktrace
/env/lib/python3.4/site-packages/flask/exthook.py:71: ExtDeprecationWarning: Importing flask.ext.sqlalchemy is deprecated, use flask_sqlalchemy instead.
  .format(x=modname), ExtDeprecationWarning
Traceback (most recent call last):
  File "main.py", line 1, in <module>
    from activation import app
  File "/home/vmagent/app/activation/__init__.py", line 10, in <module>
    from google.cloud import storage
  File "/env/lib/python3.4/site-packages/google/cloud/storage/__init__.py", line 42, in <module>
    from google.cloud.storage.batch import Batch
  File "/env/lib/python3.4/site-packages/google/cloud/storage/batch.py", line 30, in <module>
    from google.cloud.storage.connection import Connection
  File "/env/lib/python3.4/site-packages/google/cloud/storage/connection.py", line 17, in <module>
    from google.cloud import connection as base_connection
ImportError: cannot import name 'connection'

Steps to reproduce:
deploy app engine on flexible environment

Code example
from flask import Flask
from flask.ext.sqlalchemy import SQLAlchemy
from google.cloud import storage   # <== ImportError
# ... other code ...

one week ago, it's work to deploy the same code for me, but today it's always show there is possible a unhealthy code...
therefore, i deep into check why it dosen't work, so i found that google-cloud-storage (0.20.0) should be upgraded to 0.21.0, but i don't know why it was work for google-cloud-storage (0.20.0)
requirements.txt with ImportError after running as following:
Flask==0.11.1
Flask-SQLAlchemy==2.1
gunicorn==19.6.0
PyMySQL==0.7.9
requests==2.11.1
azure==1.0.3
pymemcache==1.3.7
google-cloud-storage==0.20.0
google-api-python-client==1.5.5
requirements.txt without ImportError after running as following:
Flask==0.11.1
Flask-SQLAlchemy==2.1
gunicorn==19.6.0
PyMySQL==0.7.9
requests==2.11.1
azure==1.0.3
pymemcache==1.3.7
google-cloud-storage==0.21.0
google-api-python-client==1.5.5

@brian1125 We did a release of 0.21.0 yesterday both for google-cloud-storage and google-cloud-core (storage depends on core).
The import
 from google.cloud import connection as base_connection

comes from core and moved between releases.
So the error is because you have a version of core (0.21.0) that is not meant to work with the previous version of storage (0.20.0). Please upgrade.

It's worth noting that this is partially our "fault" for not putting an upper bound on the google-cloud-core dependency in the storage setup.py file

@dhermes  Thank you for your explanation.


Inquiry on 1.16 support

Found out about this project and I was frankly amazed and in awe. Latest release seems to support 1.15 and I would like to ask on 1.16 support.

The latest release (just posted) should work with 1.16.3


Add support for Tag Sources.

Add support for Tag sources.  https://github.com/konveyor/enhancements/pull/94
Model:
Add optional Source to the Application-Tag association model.
API:

Update the application/tags (Endpoints) API to replace Ref with TagRef which includes an optional Source.
Add PUT /applications/1/tags body=[]TagRef  to atomically replace associated tags. Filtered by a source query parameter. Example: PUT /applications/1/tags?source=Analysis

Binding:
Update AppTags:

Add Source(name string) which will be used (when specified) as a qualifier in all methods.
Add Replace([] int) to support addons replacing all of the tags. Expected to be used only with sources. Perhaps fail when source is not set.

Example:
tags := Application(app.ID).Tags()
tags.Source("Analysis")  <-- new to set the source qualifier.
tags.Add(tag.ID)
tags.Replace([]uint)     <-- new to support addon replacing tags

Fixed: #245


BaSyx SDK incompatible with Spring Boot due to Tomcat Version mismatch

Hi,
as I am implementing an application in Spring Boot that relies on the BaSyx java SDK I came upon a problem with the Apache Tomcat dependency used by the BaSyx SDK. Calling RegistryComponent.startComponent() or AASServerComponent.startComponent() produces an exception preventing the user from starting an AAS server or registry.
org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[d2e61a47-5324-4448-8c8f-a0cca4e2fb72]]
	at org.apache.catalina.util.LifecycleBase.handleSubClassException(LifecycleBase.java:440) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:198) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:432) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.eclipse.basyx.vab.protocol.http.server.BaSyxHTTPServer.lambda$start$0(BaSyxHTTPServer.java:161) ~[basyx.sdk-1.0.2.jar:na]
	at java.base/java.lang.Thread.run(Thread.java:833) ~[na:na]
Caused by: java.lang.NullPointerException: Cannot invoke "java.util.concurrent.ScheduledExecutorService.scheduleWithFixedDelay(java.lang.Runnable, long, long, java.util.concurrent.TimeUnit)" because the return value of "org.apache.catalina.Server.getUtilityExecutor()" is null
	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:951) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183) ~[tomcat-embed-core-9.0.62.jar:9.0.62]
	... 7 common frames omitted

Steps to reproduce
I created a minimal example to demonstrate the problem:

Use Spring initializr https://start.spring.io/ to create a new project
Add the Spring web dependency (uses tomcat-embed-core-9.0.60)
generate the project and add the BaSyx SDK to its dependecies
create a controller that uses the SDK to start an AAS registry

@Controller
public class ServerController {

    @PostConstruct
    void init() {
        // assemble paths of AAS Server and Registry
        int registryPort = 4000;
        String registryContextPath = "registry";

        //create RegistryComponent
        BaSyxContextConfiguration registryContextConfig = new BaSyxContextConfiguration(registryPort, registryContextPath);
        BaSyxRegistryConfiguration registryConfig = new BaSyxRegistryConfiguration(RegistryBackend.INMEMORY);
        RegistryComponent registry = new RegistryComponent(registryContextConfig, registryConfig);

        registry.startComponent();
    }

}

I also created a project that contains the code to demonstrate the problem: https://github.com/Marrrrtthias/basyx-dependency-problem
Investigation
To me it seems like the problem comes up because a dependency mismatch between Spring-web which uses tomcat-embed-core 9.0.62 and basyx.sdk which uses tomcat-catalina 8.5.41, both of which provide the classes Tomcat.java, LifecycleBase.java and others. Because Maven can not handle different versions of the same library in ine project the BaSyx SDK uses the classes from tomcat-embed-core 9.0.62 which are apparenly incompatible.
I am not sure if this is really a BaSyx problem or if you can really do anything about it, but because Spring is a very widely used library i wanted to report the problem nonetheless.

Many thanks for pointing this out. We will take a look and see if we can easily upgrade to Tomcat 9. I will update this ticket when the upgrade is done.

I am also facing the same issue.

Hi Marrrrtthias,
The PR #93 will address the issue raised here.
However, as you said that dependency mismatch between Spring-web which uses tomcat-embed-core 9.0.62 and basyx.sdk which uses tomcat-catalina 8.5.41, this is right. But we can easily exclude "spring-boot-starter-tomcat" from springframework dependency.
It means that we are explicitly instructing to not use Tomcat server from springframework package, then it will use the Tomcat version defined in the Basyx SDK and the issue will not occur.
I have excluded  "spring-boot-starter-tomcat" from your provided basyx-dependency-problem project and the Tomcat server defined in Basyx SDK i.e 8.5.41 is getting executed and not the 9.0.62 defined in Springframework.
Following are the logs :
2022-06-26 15:53:32.619  INFO 16604 --- [           main] c.e.d.DependecyProblemApplicationTests   : Starting DependecyProblemApplicationTests using Java 1.8.0_202 on lap552 with PID 16604 (started by danish in C:\Users\danish\eclipse-workspace\basyx-dependency-problem) 2022-06-26 15:53:32.621  INFO 16604 --- [           main] c.e.d.DependecyProblemApplicationTests   : No active profile set, falling back to 1 default profile: "default" 2022-06-26 15:53:33.934  INFO 16604 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Bootstrapping Spring Data MongoDB repositories in DEFAULT mode. 2022-06-26 15:53:33.965  INFO 16604 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Finished Spring Data repository scanning in 17 ms. Found 0 MongoDB repository interfaces. 2022-06-26 15:53:34.585  INFO 16604 --- [           main] o.e.b.c.registry.RegistryComponent       : Creating InMemoryRegistry 2022-06-26 15:53:36.356  WARN 16604 --- [           main] o.apache.catalina.core.StandardContext   : A context path must either be an empty string or start with a '/' and do not end with a '/'. The path [registry] does not meet these criteria and has been changed to [/registry] 2022-06-26 15:53:36.836  INFO 16604 --- [       Thread-2] o.apache.catalina.core.StandardService   : Starting service [Tomcat] 2022-06-26 15:53:36.836  INFO 16604 --- [       Thread-2] org.apache.catalina.core.StandardEngine  : Starting Servlet Engine: Apache Tomcat/8.5.41 2022-06-26 15:53:37.233  INFO 16604 --- [           main] o.e.b.c.registry.RegistryComponent       : Registry server started 2022-06-26 15:53:38.831  INFO 16604 --- [           main] org.mongodb.driver.cluster               : Cluster created with settings {hosts=[localhost:27017], mode=SINGLE, requiredClusterType=UNKNOWN, serverSelectionTimeout='30000 ms'} 2022-06-26 15:53:39.050  INFO 16604 --- [localhost:27017] org.mongodb.driver.connection            : Opened connection [connectionId{localValue:1, serverValue:23}] to localhost:27017 2022-06-26 15:53:39.050  INFO 16604 --- [localhost:27017] org.mongodb.driver.cluster               : Monitor thread successfully connected to server with description ServerDescription{address=localhost:27017, type=STANDALONE, state=CONNECTED, ok=true, minWireVersion=0, maxWireVersion=13, maxDocumentSize=16777216, logicalSessionTimeoutMinutes=30, roundTripTimeNanos=71426200} 2022-06-26 15:53:39.055  INFO 16604 --- [localhost:27017] org.mongodb.driver.connection            : Opened connection [connectionId{localValue:2, serverValue:24}] to localhost:27017 2022-06-26 15:53:39.179  WARN 16604 --- [           main] o.s.data.convert.CustomConversions       : Registering converter from class java.time.LocalDateTime to class org.joda.time.LocalDateTime as reading converter although it doesn't convert from a store-supported type! You might want to check your annotation setup at the converter implementation. 2022-06-26 15:53:39.336  WARN 16604 --- [           main] o.s.data.convert.CustomConversions       : Registering converter from class java.time.LocalDateTime to class org.joda.time.LocalDateTime as reading converter although it doesn't convert from a store-supported type! You might want to check your annotation setup at the converter implementation. 2022-06-26 15:53:40.051  INFO 16604 --- [           main] c.e.d.DependecyProblemApplicationTests   : Started DependecyProblemApplicationTests in 7.933 seconds (JVM running for 10.156) [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.348 s - in com.example.dependecyproblem.DependecyProblemApplicationTests
Also when using the Tomcat updated version 9.0.64 in BaSyx SDK you will see that it is still using 9.0.62 version which is defined in  "spring-boot-starter-tomcat" , so if needed exclude tomcat from Spring to avoid such error.
Following lines you have to add to exclude Tomcat from Springframework :
<exclusions> 		            <exclusion> 		                <groupId>org.springframework.boot</groupId> 		                <artifactId>spring-boot-starter-tomcat</artifactId> 		            </exclusion>         		</exclusions>


feat: support querying by join date in member directory 📆

Description ✏
This PR supports a search param called joinedDirectoryDate in the Member Directory and updates the feed notification accordingly.
Type of Change 🐞

[x] Feature - A non-breaking change which adds functionality.
[ ] Fix - A non-breaking change which fixes an issue.
[ ] Refactor - A change that neither fixes a bug nor adds a feature.
[ ] Documentation - A change only to in-code or markdown documentation.
[ ] Tests - A change that adds missing unit/integration tests.
[ ] Chore - A change that is likely none of the above.

Checklist ✅

[x] I have done a self-review of my code.
[x] I have manually tested my code (if applicable).
[ ] I have added/updated any relevant documentation (if applicable).

@tomas-salgado @ramiAbdou This is super nitpicky, but current the feed message will say "Say hello to the 1 members"  if only one person joined, when it should say "Say hello to the 1 member". Same with the "these company reviews" when it should say "this company review". Basically, there could be a catch for if there is only one thing. I am more than happy to implement this!


xtube: new video page

XTube have completely redune their video page it looks like, so youtube-dl doesn't work.
here's the error I get:
$ youtube-dl --verbose http://www.xtube.com/watch.php?v=[redacted]
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://www.xtube.com/watch.php?v=[redacted]
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.10
[debug] Python version 2.7.11 -<EMAIL_ADDRESS>[debug] exe versions: ffmpeg 2.8.5, ffprobe 2.8.5, rtmpdump 2.4
[debug] Proxy map: {}
[XTube] OhSVg-G770-: Downloading webpage
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 666, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 315, in extract
    return self._real_extract(url)
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/xtube.py", line 40, in _real_extract
    r'<p class="title">([^<]+)', webpage, 'title')
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 619, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/lib64/python2.7/site-packages/youtube_dl/extractor/common.py", line 610, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Not very important since it's failing so early.  I imagine it's completely broken.
I left out the video ID for the sake of my own privacy but it should be similarly broken on every video.

I left out the video ID for the sake of my own privacy

Actually, you've failed to left out all the occurrences.

ahhhhh, I see.  hehe, whoops. :p


Explicit dependency on Meteor.Session

Thanks for making this useful package,
however you might want to update the docs for this package for Meteor 1.3 users.
I had assumed this was a drop in replacement for the Meteor package and tried using it on its own.  My blaze templates threw errors when I tried to get/set Session, but there was no error when I actually installed your package so it doesnt seem like Session is a dependency.
Once I installed meteor/session the errors of course went away.
You could also make it clear that after installation the correct import command is still :
import { Session } from 'meteor/session';

The ReadMe has been updated with your suggestion. Thanks for pointing this out to us. 😄


Script missing after phase 1

Team
I am at the step where the VM is created, and I am supposed to run some script :https://github.com/Azure/AzureStackHCI-EvalGuide/blob/main/deployment/steps/1_DeployAzureVM.md#troubleshooting
Unfortunatly I am blocked here. According to the documentation I am am supposed to have a directory but it is not there

Could you advise me ?
Thanks a lot
fred

Hi,
I decided to go back and this time have been able to pass this stage.
What I have discovered is tha name change in the path, making the script to fail.
Thanks
fred

Ok Thanks, was going to look at this today. Glad you made it past. LMK of any more issues.


[Plugin] Source plugins

Adds source plugin. This is in continuation of #4608.

:umbrella: The latest upstream changes (presumably #4700) made this pull request unmergeable. Please resolve the merge conflicts.

@asutoshpalai I was trying to edit lib/bundler/errors.rb and found that you've used a duplicated status code 23 in L44 which was already taken in L69

@allenzhao Yes, right! Sorry, will fix that with the next push!

@asutoshpalai @indirect is this ready to merge?

@segiddins I think it's now ready to merge

@asutoshpalai if you can get this passing, ill give it one last look over and then likely merge

This shall pass, there is some problem with travis. It is giving error.
Since the last time it was passing, I just added some new specs that are
passing. (and another small change that I reverted)
On 01-Jul-2016 5:13 pm, "Samuel Giddins"<EMAIL_ADDRESS>wrote:

@asutoshpalai https://github.com/asutoshpalai if you can get this
passing, ill give it one last look over and then likely merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bundler/bundler/pull/4674#issuecomment-229926398, or mute
the thread
https://github.com/notifications/unsubscribe/AIFEgs_HHllKXcje3g66rk0I2-ed-QmAks5qRP1pgaJpZM4I3kK2
.

@segiddins I fixed the problem with the specs setup and they are passing now.

Here is the path with which I fixed the specs
diff --git a/spec/support/rubygems_ext.rb b/spec/support/rubygems_ext.rb
index 95f596e..e45e69f 100644
--- a/spec/support/rubygems_ext.rb
+++ b/spec/support/rubygems_ext.rb
@@ -6,13 +6,15 @@ module Spec
   module Rubygems
     DEPS = begin
       deps = {
-        "fakeweb artifice rack compact_index" => nil,
+        "fakeweb artifice compact_index" => nil,
         "sinatra" => "1.2.7",
         # Rake version has to be consistent for tests to pass
         "rake" => "10.0.2",
         # 3.0.0 breaks 1.9.2 specs
         "builder" => "2.1.2",
         "bundler" => "1.12.0",
+        # 2.0.1 requires ruby >= 2.2.2
+        "rack" => "1.6.4",
       }
       # ruby-graphviz is used by the viz tests
       deps["ruby-graphviz"] = nil if RUBY_VERSION >= "1.9.3"
@@ -33,7 +35,7 @@ module Spec
         FileUtils.rm_rf(Path.base_system_gems)
         FileUtils.mkdir_p(Path.base_system_gems)
         puts "installing gems for the tests to use..."
-        DEPS.each {|n, v| install_gem(n, v) }
+        DEPS.sort {|a, _| a[1].nil? ? 1 : -1 }.each {|n, v| install_gem(n, v) }
         File.open(manifest_path, "w") {|f| f << manifest.join }
       end

:umbrella: The latest upstream changes (presumably #4744) made this pull request unmergeable. Please resolve the merge conflicts.

@asutoshpalai I'll merge if you can rebase to get rid of the merge commit :)

@homu r+

:pushpin: Commit 57e8172 has been approved by segiddins

:hourglass: Testing commit 57e8172 with merge cc4df62...

:sunny: Test successful - status


Advanced Weapon Training doesn't show as correct on proficiencies tab

Advanced Weapon Training Feat gives my fighter the correct att bonus and when rolled it shows as correct, but it doesn't appear to be correct in the proficiencies tab
correct option & feat present

correct att bonus (master & +1 potency vs expert)

however, on the proficiencies tab it still shows advanced swords as expert (twice)

We need to be able to specify a Martial Proficiency to be the same as a specific group within a category, as opposed to just a category. Relabeling this as a feature request.


Update version number in catalog-v001.xml files

Description of the issue
In the v1.1.0 release it was missed to update the version number in the catalog-v001.xml files, see #550.
Ideas of solution
Hotfix bumping version number to 1.1.1 in all omn and catalog-v001.xml files.
Workflow checklist

[ ] I am aware of the workflow for this repository

Is this something a bot could solve for future releases @akleinau @sfluegel05 ?

I close this without merging as we do now the 1.2.0 release instead of a hotfix 1.1.0 release.


Hidden elements calculated at 0px width

If a ui-select element is hidden on page load, then width is calculated as 0px.
I can override this in my css with:
.form-group input {
    width: 100% !important;
}

but then the dynamically calculated widths are overridden and after entering a multiselect item, the cursor is forced to a new line.

any non-jquery fix/workaround for that issue ?

I just put _searchInput.css('width','100%'); instead of 10px and all fine, don't know why is set to 10px

As a workaround to fix select control at hidden tabs you could render content of a tab only when user switches to it.
  <tabset>
    <tab select="tabOneRendered = true">
      <tab-heading>Tab One</tab-heading>
      <ui-select ng-if="tabOneRendered">...</ui-select>
    </tab>
    <tab select="tabTwoRendered = true">
      <tab-heading>Tab Two</tab-heading>
      <ui-select ng-if="tabTwoRendered">...</ui-select>
    </tab>
</tabset>

I've tried the Plunk linked to above with 0.11.1 and it works fine now. See http://plnkr.co/mDfda7
(I thought it might have been fixed by #712 but it was already working with 0.10.0. Not sure which exact change fixed this.)
@seacucumba are you seeing this problem with the current version? If so, can you please provide an example?

I can see that if an ui-select multiple initialized in hidden part of template then its input is 10px only. It is hard to click on it.
After some experiments I found simple workaround:
$timeout(function () {
    $scope.$digest();
});

Is this not being fixed - what exactly is the workaround because this is still a problem in the latest version

kshutkin's workaround works for me

$timeout(function () {
$scope.$digest();
});

kshutkin's workaround didn't work for me.
For now, would use ng-if to avoid the issue..

I decided to not use the control altogether since this should have been fixed.

Where exactly are you placing the $scope.digest timeout?


Point cloud and display problems during 3D reconstruction

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Win 10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ legacy / 2.50.0 }

Language
python

Segment
others

Issue Description
I am using python trying to get point cloud data by depth frame and display or export a ply file，and this is the code i wrote, now i have got the verts and textcoords, Below is my code.
      points = pc.calculate(depth_frame)         pc.map_to(color_frame)         v = points.get_vertices()         t = points.get_texture_coordinates()         verts = np.asanyarray(v).view(np.float32).reshape(-1, 3)  # xyz         textcoords = np.asanyarray(t).view(np.float32).reshape(-1, 2)  # uv
But in fact, I'm not very clear about the meaning and role of these two parameters (verts and textcoords) (I want to figure them out), now I don't know what to do next, I just simply want my point The cloud map can be displayed first, and then do other plans.I think the next step should be a matching operation between coordinates (from my guess).
So,I hope someone can help me answer my doubts, thank you very much

My device is D455. And can I visualize point clouds with numpy arrays?

Hi @w-1016-Papman  My understanding is that verts and texcoords represent two separate numpy arrays (named 'v' and 't' in your code), and that the 'verts' array stores the xyz pointcloud coordinates in array 'v' whilst the 'texcoord' array stores the texture coordinates (uv map) for the point cloud in array 't'.
The RealSense SDK's Python example program opencv_pointcloud_viewer.py demonstrates the generation and viewing of a live pointcloud via numpy array storage using the technique that you highlighted in your question.
https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/opencv_pointcloud_viewer.py
https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/opencv_pointcloud_viewer.py#L310

嗨@w-1016-Papman 我的理解是verts和texcoords代表两个单独的 numpy 数组（在您的代码中命名为“v”和“t”），并且“verts”数组将 xyz 点云坐标存储在数组“v”中而'texcoord'数组将点云的纹理坐标（uv贴图）存储在数组't'中。
RealSense SDK 的 Python 示例程序opencv_pointcloud_viewer.py演示了使用您在问题中强调的技术通过 numpy 数组存储生成和查看实时点云。
https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/opencv_pointcloud_viewer.py  https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/opencv_pointcloud_viewer.py #L310

I'm sorry to come to you again. Thank you very much for the link, that helped me a lot, but I found a phenomenon,
Why is the value of the textcoords array all zeros after I align the depth frame with the color frame and then execute the following part of the code (at least from my run window it has all zeros in its internal data)
points = pc.calculate(depth_frame)
pc.map_to(color_frame)
v = points.get_vertices()
t = points.get_texture_coordinates()
verts = np.asanyarray(v).view(np.float32).reshape(-1, 3)  # xyz
textcoords = np.asanyarray(t).view(np.float32).reshape(-1, 2)  # uv
print(textcoords)
I just added two lines of code:
algin_to = rs.align(rs.stream.color)
algin_frames = algin_to.process(frames)
And I also found that even if I don't have an alignment operation, if I don't add the decimation filter, the output of the running window also shows zero, But after I add the decimation filter code, it shows some non-zero data, I'd love to know why this is
decimate = rs.decimation_filter(2)
depth_frame = decimate.process(depth_frame)

I believe that you do not need to use depth-color alignment when generating a pointcloud with the pc.map_to() method, as it is already mapping beween depth and color.  Alignment would be used if a pointcloud was being generated with rs2_deproject_pixel_to_point, the other main method of pointcloud generation other than points.Get_vertices()

But why does the decimation filter affect the value change? I see his reduced resolution, I think it should be good for noise reduction, but why does it affect the internal value of textcoords?

Intel's post-processing guide states about the decimation filter that after the decimated frame is produced, the frame intrinsic parameters are recalculated to compensate for the resolution changes.
https://dev.intelrealsense.com/docs/post-processing-filters#section-decimation-filter


Function selection_style doesn't work

On D3 v3 you could write:
.style({
   fill:"none",
   stroke:"#f00",
   "stroke-width":"10"
})

but on V4, if you do that get nothing. Looking at the function selection_style inside style.js
function selection_style(name, value, priority) {
    var node;
    return arguments.length > 1                     // *
        ? this.each((value == null
              ? styleRemove : typeof value === "function"
              ? styleFunction
              : styleConstant)(name, value, priority == null ? "" : priority))
        : window(node = this.node())
            .getComputedStyle(node, null)
            .getPropertyValue(name);
  }

here, argument.length = 1 because it recibe an object:

and arguments.length > 1 fails on recognize the 3 arguments.
Object.keys(arguments[0]).length give the right styles counts.
For me this is a bug, not a feature :)

See the release notes; you’ll need d3-selection-multi.

Thanks Mike, now its works.
Q: If you expect just one pair [key, value],  why do you use 'this.each'?

Not sure I understand the question. When you call selection.attr (or other
selection methods) they typically apply to all elements in the selection,
so selection.each is used to implement iterating over the selected elements.

Sorry, you right. I misunderstand the code. Thanks a lot


Update non-Rust portion of codebase for Godot 4

Fixed & refactored all project examples (some subjective implementation changes too)
Updated GUT dependency & unit tests
Updated C# wrapper & visualization example
Reintroduced addons directory with GDExtension requirements
Updated Readme details & formatting/wording
Updated file & directory names to better match Godot 4 style guide
Updated gitignore to include asset imports and discard some unnecessary file types

Hey there, thanks for your amazing work so far! :D
i tested your PR and I have a few notes
tests are supposed to be automatically generated, so i wouldn't bother fixing them if I were you (still an amount of them that doesn't pass)
all the examples are working, good job!
I have not tested C# as I don't have the right version of the engine!
it's also not a blocker, you don't have to fix everything at once!
The right repo to open your PR (the main one) is https://github.com/MatejSloboda/Dijkstra_map_for_Godot , which I can merge anyway

Thanks for reviewing it!
I don't know if it makes sense to merge to my changes to the main repo yet since this is all built on the Godot 4 updated version of DijkstraMap which right now only lives in your fork/branch; wouldn't we want to either merge that to the main repo first (probably not ideal since there are still some minor things to fix on the Rust side), or merge the changes here first?

We can merge to the main repo as long as we don't release it ! also, if it's merged here then I merge it from here there, you won't appear in the main repo's stats which is not fair ^^


[TH2-4915] Updated dependencies

TH2-4987 Added com.gorylenko.gradle-git-properties plugin

@Nikita-Smirnov-Exactpro can we close this PR? It looks like it contains outdated changes

@Nikita-Smirnov-Exactpro can we close this PR? It looks like it contains outdated changes

I'm OK but tests in this PR maybe useful

Okay, I will rebase tests on the main branch

As I can see both tests are already added to the master branch
https://github.com/th2-net/th2-codec-json-dictionaryless/blob/master/src/test/kotlin/com/exactpro/th2/codec/json/EncodeTest.kt#L100 https://github.com/th2-net/th2-codec-json-dictionaryless/blob/master/src/test/kotlin/com/exactpro/th2/codec/json/DecodeTest.kt#L75
So, probably, we can close the PR

Thank you for checking


Company name and change name

Adds company name for vendors and merchants and the ability to change the name
Everyone can also change their own name
@Huntrr
@webfreak7

LGTM


Rename to cc2dataset?

yeah let's do it. Right after #18 is done and confirmed to work

cc2dataset


Admin UI: Loading stops before data is shown

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration tests.
[X] I ensured that the PR title is good enough for the changelog.
[X] I labeled the PR.

Now we don't have a loading indicator at all?

Of course we do, what makes you say that? ❓

Let me rephrase the question: why did you remove all these loading properties?

Let me rephrase the question: why did you remove all these loading properties?

I only removed the one that was unused.
The other components still have their loading property, the only behaviour change was that the animation is now only contingent on the main request (e.g., identities overview), as opposed to being toggle for items such as the filters.


Provision a Basic System User

what

Provision a basic IAM user
Provision a basic IAM Access Key/Secret Access Key

why

For CI/CD systems or other systems which are incompatible with IAM Instance Profiles

Tested.


Download prompt when pressing Ctrl/Cmd + S

The download prompt is awesome, but shouldn't it also appear when we press Ctrl/Cmd + S on a site. Currently nothing notifies you that a file have been downloaded to your machine.

Are you on master? We just merged that update

Ah no, I'm on the last release. Sorry, I should really stop reporting already done issues...

All good!
On Wed, Oct 10, 2018 at 1:07 PM Hunor Karamán<EMAIL_ADDRESS>wrote:

Ah no, I'm on the last release. Sorry, I should really stop reporting
already done issues...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/beakerbrowser/beaker/issues/1209#issuecomment-428673235,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhU7impGfKSp0eqMfyX2vfr4W3Ri6tks5ujjdLgaJpZM4XUsdI
.


Menu Items and Hovers Rendering as Symbols

VSCode Version: 1.25
OS Version: Red Hat Enterprise Linux Server release 7.4 (Maipo)

Steps to Reproduce:

Open VSCode

Does this issue occur when all extensions are disabled?: Yes

What is exactly the issue here? What is unexpected and what behavior would you expect?
Can you reproduce with vscode insiders https://code.visualstudio.com/insiders/

The unexpected behavior is that I'm seeing "Wingdigs" instead of English characters in the menu dropdowns. Yes, I can reproduce this with the insider version.

@fny you only see those weird characters in the menu, nowhere else in the UI?

Also tooltips/popovers.

Let's start with the localisation crew

Does this reproduce if you disable all extensions?

This is already a bare installation without any extensions running.
For some more context, this the untarred running on a fairly bare bones box
that has no internet access for security reasons (patient data.)
On Fri, Aug 3, 2018 at 4:44 AM Andre Weinand<EMAIL_ADDRESS>wrote:

Does this reproduce if you disable all extensions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/55416#issuecomment-410187525,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVH1CTMD_2J0XmTksC9uHInrzeEhen-ks5uNA1bgaJpZM4VnmXp
.

Not sure if it is a localisation issue as this occurs only in context menus, anything to do with electron?

Agree with @sandy081 that this is very likely not a localization issues since it only appears in menus. I guess that this is a font setup issue.
@bpasero what do we do to control the font of these menus. Is this something electron does automatically? Seems to affect native Electron controls.

That didn't fix anything. Also, it looks like text in an editing pane has the same issue.

@fny can you update to our latest stable release (1.26) and try again?


Refactor api

Some code quality improvement for the Api class.
Testing the class
dropping support of HttpParty before 0.15 because it does not delete the trailing backslash at the end of base_url

Coverage increased (+4.8%) to 87.94% when pulling f5aa8027177cea02ec6da9886b2536fe72d678e4 on hezanathos:refactor_api into ab6f3d484cdd0bd37a133a181941cca22f416e8e on Cyberwatch:master.

Coverage increased (+4.8%) to 87.94% when pulling f5aa8027177cea02ec6da9886b2536fe72d678e4 on hezanathos:refactor_api into ab6f3d484cdd0bd37a133a181941cca22f416e8e on Cyberwatch:master.

Coverage increased (+4.8%) to 87.94% when pulling e990f5b53a3909226e44b693ec854207caecc3f7 on hezanathos:refactor_api into ab6f3d484cdd0bd37a133a181941cca22f416e8e on Cyberwatch:master.

Coverage increased (+4.8%) to 87.94% when pulling e990f5b53a3909226e44b693ec854207caecc3f7 on hezanathos:refactor_api into ab6f3d484cdd0bd37a133a181941cca22f416e8e on Cyberwatch:master.

Coverage increased (+4.9%) to 88.06% when pulling 71e1ade853dc1d0e806002c348aae9999438761f on hezanathos:refactor_api into ab6f3d484cdd0bd37a133a181941cca22f416e8e on Cyberwatch:master.

Coverage increased (+4.9%) to 88.06% when pulling 71e1ade853dc1d0e806002c348aae9999438761f on hezanathos:refactor_api into ab6f3d484cdd0bd37a133a181941cca22f416e8e on Cyberwatch:master.


[1.12.2] A Wild Fairly Lights Conflict Appears!

Seemingly completely different than #90
https://pastebin.com/TA2am5gp
I'm dumb, forgot to mention it only appears when switching dimensions as far as I can tell, loading is fine normally, but if you say, go to "Yet another mining dimension" and back it'll cause the issue.

You are currently using an outdated version of the mod, from curseforge. Note that updating will cause issue #279


rethink cleanup of channels with no members

If a channel has no members, all its in-memory datastructures are cleaned up. This includes channel history, even in the case of a registered channel.
Possibly, if autoresize-window is set, then an unregistered channel with no members should be kept alive (but not shown in /LIST?) until the end of the window.

Idea: registered channels with no members should not be cleaned up, but should not display in LIST either.
Unregistered channels can just be cleaned up, probably.


Add support for org.apache.zookeeper:zookeeper:3.8.1

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

~Yes, this is a pre-issue to https://github.com/oracle/graalvm-reachability-metadata/issues/163 .~

Since Zookeeper Server 3.8.1 includes critical https://issues.apache.org/jira/browse/ZOOKEEPER-4460 to fix GraalVM nativeTest.  Refer to https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12351398&styleName=Html&projectId=12310801 .

Describe the solution you'd like
A clear and concise description of what you want to happen.

Add support for org.apache.zookeeper:zookeeper:3.8.1.
The relevant JSON entry is available at https://github.com/apache/shardingsphere/tree/0397f829d60b47cd57b255a4f48132d627e7b10c/infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.zookeeper/zookeeper/3.9.0 .

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Null.

Additional context
Add any other context or screenshots about the feature request here.

Metadata generated at https://github.com/linghengqian/graalvm-trace-metadata-smoketest/issues/1 .

Linkes to https://github.com/apache/shardingsphere/issues/21347 and https://github.com/apache/shardingsphere/issues/29052 .

I'm working on this issue.

@linghengqian Any updates on this issue? :)

@linghengqian Any updates on this issue? :)

As a ShardingSphere Committer, the relevant metadata actually exists on the Apache ShardingSphere side for a long time, and the ShardingSpher side also has a small test set to verify the availability of the relevant metadata JSON. Reference https://github.com/apache/shardingsphere/tree/0397f829d60b47cd57b255a4f48132d627e7b10c/infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.zookeeper/zookeeper/3.9.0 .
As a student, I don’t have much time to handle multiple issues at the same time. I don't actually have merge permissions for the current repository. I have been waiting for the open PR on this repository for 6 months and have not received any review comments. Reference https://github.com/oracle/graalvm-reachability-metadata/pull/388 .
If you need this part of JSON now, you can copy the relevant JSON to your own project.
In the past 6 months, I could not find a committer in the current warehouse who was free to review my PR, so the GraalVM Reachability Metadata involved in the issue I opened was submitted to the ShardingSphere side by me.
If you have time, you can just write additional test suites, submit a PR and close this issue. Obviously as a student, I really don’t have that much energy to wait for multiple PR reviews.

Please, see this

I confirmed in https://github.com/apache/shardingsphere-elasticjob/pull/2428 that https://github.com/apache/shardingsphere/blob/cb729ed63f234118202d41210f3ffdba035286b1/infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.zookeeper/zookeeper/3.9.0/reflect-config.json is not all the GraalVM Reachability Metadata required by Zookeeper. Once trying to connect to Zookeeper Server with DIGEST-MD5 as SASL mechanism, JAAS related GraalVM Reachability Metadata is missing for Zookeeper Client.

To be honest, this is my first time to touch such an old thing as JAAS under GraalVM Native Image, and the SASL mechanism in JAAS is even more niche. Perhaps it is necessary to initiate relevant investigation in the ASF JIRA of apache/zookeeper and apache/curator . After all, the Kafka Client of apache/kafka can connect to the Kafka Server with SASL mechanism enabled under GraalVM Native Image. I will of course assume that the Kafka Native Server in the form of the GraalVM Native Image that has been announced to be generally available solves the problem with the SASL mechanism.

But then again, the PMC of apache/curator is migrating the issue tracker, so it may take some time to wait. See https://x.com/tison1096/status/1821834353917206865 and https://lists.apache.org/thread/jky33br972m1nwbnp9cjfzl9vlrmrt85 .


Should hint and instruction be consistent in "Side Scroller"

Describe the bug
Should hint and instruction be consistent in "Side Scroller"
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Multipart Tutorials---->Side Scroller---->Start Tutorial---->Jump your cat
3.Click Step 6
4.Compare hint with instruction
Expect behavior
Hint and instruction are consistent
Actual behavior
Instruction: Drag 2 on sprite of kind overlaps tile blocks

Hint: There are 3 on sprite of kind overlaps tile blocks in the hint

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.3.7
3.Microsoft MakeCode version: 6.4.2

So, steps 4, 6, and 7 have images showing how to setup the blocks on the workspace. Step 6, mentioned here (and step 4), has the code hint included as well. I will propose removing the code hint for step 6 and remove images for steps 4 and 7.


Order of option matters?! Shouldn't, imo.

Hi,
with the following code snippet:
let foo = TmuxCommand::new()
             .select_layout()
             .target_pane("vm_dmz:1")
             .layout_name("tiled")
             .output()?;
println!("{foo:#?}");

If one puts the .layout_name before the .target_pane, foo will contain a tmux error like
stderr: "usage: select-layout [-Enop] [-t target-pane] [layout-name]\n",
The above order (first target_pane, then layout_name) works nicely.
Appears that the order of them function calls translates directly into the order things take on commandline for tmux.
I think that shouldn't be the case, unless the options really interact with each other. A user of this interface usually shouldn't need to care of the order tmux expects things in, that IMO would be the interfaces job to handle.
Greetings,
Ganneff

Hi,
thank you for your improvement idea. I agree, for an end user it would be better to have suggested abstraction and safety.
Most likely it can be changed right along with planned direct/control mode, single/multiple commands features. They imply some rework of basic instances. Anyway unfortunately I can't promise any dates.


(for Gary) Switch to upstream jsonschema2pojo

Switches our special fork of js2p to upstream. Also removes a few dependencies and improves tests.

LGTM

LGTM


Initial clean up of Spring Boot dependencies

The version was not up to date, plus there are many conflicts between
Spring Boot and FF4J parent, so we can't really use one of those as a
parent and the other as a BOM.
Also excludes a load of things that looked like they should be optional in
FF4J (like grizzly and jersey test jars).
And removed spring-boot-admin because it doesn't add anything to the
sample.

Thank you !!

@dsyer Please note that you reviewed a sample not up-to-date with

a lot of unsed dependencies
usage of jersey2x instead of SpringWebMvc for REST controllers and API.

we put some effort to be as much spring-boot friendly as we can for months now.
Please have a look here
https://github.com/clun/ff4j-samples/tree/master/ff4j-sample-springboot
And also here with the spring-boot-starter
https://github.com/clun/ff4j-samples/tree/master/ff4j-sample-springboot-starter


template concatenation fails with photo.location

>>> {photo.location}
-33.87155666666666
151.24746166666668
>>> {,+photo.location}
sequence item 0: expected str instance, float found

The values should be casted to str before the concatenation

The code in phototemplate.py to handle concatenation (delim in OTL), sorts the values. Ugh. This makes sense for keywords, etc. (and makes testing easier) but would break things like location.
            if self.expand_inplace or delim is not None:
                sep = delim if delim is not None else self.inplace_sep
                vals = [sep.join(sorted(vals))] if vals else []

Yep, removing the sort breaks a test (but this would be easy to fix):
tests/test_template.py::test_expand_in_place_with_delim - AssertionError: assert ['weddingflowers'] == ['flowerswedding']

I don't know if the sort makes sense (it's non-intuitive action at a distance). If user wants sorted join, they could use {template|sort|join(,)} so I think it best to remove the sort from this join.

I think the real issue with this is that photo.property lookup doesn't cast to str. All other templates return value in str. Place the case in the lookup for the photo property.  Also figure out what to do about the sort.

Got rid of the sort but for template fields where sort made sense (e.g. keywords) I implemented sort at the field level not at the concatenation step.


Trigger CI with a tag

Which issue this PR addresses:
Fixes partially https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/9739113/
What this PR does / why we need it:
Trigger code check and following chain of pipelines when tag is pushed into the ARO-RP repository.
This is required for next steps for https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/9739113/
It is done separately as Azure Pipelines does not reliably handle new pipeline code in the PR.
Signed-off-by: Petr Kotas<EMAIL_ADDRESS>Test plan for issue:
Manual
Is there any documentation that needs to be updated for this PR?
None needed

Part of https://github.com/Azure/ARO-RP/pull/1684


Implement true row props

See issue #647. This PR is tentative based on performance impact.

What's the difference between this and #640?

@nmichaud Whoops forgot to push the 2nd commit; it's pushed now

Rebased ("2nd commit" is now the only commit).

As a side note:
It would be nice if Hypergrid had a property to specify the properties hierarchy because I can see how some apps would prefer a different order, for example:

grid ← row ← column ← cell

Unfortunately, this is not possible in a performant way due to the current design. However it may be possible in a future version if we can address the design issue.

I did some performance profiles and performance is not measurably impacted, which is great.
Deprecated grid.properties.rowProperties (with a warning) in favor of a better name stripes because we now have true row properties and this was now confusing.
Implemented following new properties, defaulted to true, which if set to false will disable rendering the related properties, significantly improving performance.

renderColumnProps
renderStripes
renderRowProps
renderCellProps

I also isolated the logic for layering properties during rendering into a new method grid.renderer.configurator so that developer can override it with different or faster logic.

@Dwaynekj @dcchuck @nmichaud @neilslinger @texodus @stevewirts Success! This PR passed performance tests so it's definitely a go, so please review.
Note that row properties api is simpler and shorter cell properties api — which we could consider simplifying as well.

@joneit what Browsers and OS did you test? Chrome 40 is in that list?

@Dwaynekj Good point. I'll test in Chrome 40. But this can still go because of the props and the overridable method:

If impactful to Chrome 40l, I'll try setting grid.properties.renderRowProps = false to skip the logic (the line I called out in previous comment).

If better, we can consider making that the default? ...although upgrading to v3.0.0 is going to require some code tweaks anyway and setting this prop to false but I hesitate doing that for the relatively few Chrome 40 users; rather it could be a "recommended Chrome 40 tweak."

If still impactful, we can supply a simpler configurator akin to the original logic (by eliding that line entirely).

Again, we could consider making that the default, but again that setting could be a recommended Chrome 40 tweak.

I WILL be there at 330 today
On Dec 20, 2017 12:55 PM, "Jonathan Eiten"<EMAIL_ADDRESS>wrote:

@Dwaynekj https://github.com/dwaynekj Good point. I'll test in Chrome
40. But this can still go because of the props and the overridable method:

If impactful to Chrome 40l, I'll try setting grid.properties.renderRowProps
= false to skip the logic (the line I called out in previous comment).

If better, we can consider making that the default? ...although
upgrading to v3.0.0 is going to require some code tweaks anyway and setting
this prop to false but I hesitate doing that for the relatively few
Chrome 40 users; rather it could be a "recommended Chrome 40 tweak."

If still impactful, we can supply a simpler configurator akin to the
original logic (by eliding that line entirely).

Again, we could consider making that the default, but again that
setting could be a recommended Chrome 40 tweak.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fin-hypergrid/core/pull/648#issuecomment-353136303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC6Sp1RgRvOUQ_OFjkB3o1BS_CI6dr4Aks5tCUoqgaJpZM4Q-LA5
.

Layering prop classes in any order
I've re-pushed this PR with new logic to select prop classes to render and in which order. Overcame some performance-related issues to do this.
Performance checks out!
I did some performance profiles and performance is not measurably impacted, which is great.
There is still one case where performance takes a hit (when column props are omitted; see below).
Renamed property: rowProperties → stripes
Deprecated grid.properties.rowProperties (with a warning) in favor of a better name stripes because we now have true row properties and this was now confusing.
New property: cellEvent.prototype.rowProperties
This is a new getter/setter (example).
The logic layers the property classes in the order defined in Hypergrid.properties (aka require('defaults.js')):
propClassLayers: [ 'columns',  'stripes',  'rows',  'cells' ]

In addition to the above grid default, the tree and row handle columns both override the grid property (actual code):
treeColumnProperties.propClassLayers = rowColumnProperties.propClassLayers = ['columns'];

The above only renders the column props, thus preventing row stripes from rendering in those columns.
Example
So the default is to override column props with row props. To override this default to render column props on top of row props:
grid.properties.propClassLayers = ['rows', 'columns'];

New overridable method: grid.renderer.assignProps
The layering logic is isolated in a new method which developers can override with alternative or faster logic.


how to adjust get_ip_address for macOS

Hey there!
Awesome theme, first to say! I wanted to use the get_ip_address() stuff as well on my theme, but I noticed that the if statement does not work out on macOS.
When I have an IP address, all is fine, but the if statement will also assert to true if the interface exists but there is no connection. On Linux it seems there will be no return and that's why -n works out?
Could you give me some assistance there? :)

This is how I fixed it now.
get_ip_address() {
  if [[ -n "$(networksetup -getinfo Wi-Fi | grep 'Subnet mask: ')" ]]; then
    echo "$(ifconfig en0 | awk '/inet / {print $2}')%{$reset_color%}"
  else
    echo "%{$bg_bold[red]%} No IP %{$reset_color%}"
  fi
}

Heyy, nice, can you create a pr....create heapbytes-mac.zsh-theme file, i've recevied few mac os people, it will be easier for them to pull from here........also does the wifi icon worked for you?

I can, but in my solution i left out the VPN stuff. And I can't really bother about including that, since I never use a VPN.


Bypass not working in acortalink

Domain
https://acortalink.me/
Link
https://acortalink.me/s.php?i=VTJGc2RHVmtYMThmQWV6c2czWENUNk5QL0NuRmxxVHZhWUsrK1phUUJTWmZhajFPamVac3hNSTdkejFVSnZXUEVRTUkxTWlLUnVmRVNFRzNQdm5sOW5NaUwrMlV1VGIyR2I2ZEZ1MXd1Mld5Zk53SDdvbml1QW9tdGZxakFqdWRCbzhPcnpXV3JiN1VWNUF3UGlRVDBBPT0=
Version
0.2230
What browsers are you seeing the problem on?
Brave
What OS are you seeing the problem on?
Windows
Anything else?
I was trying to use fastfoward to skip acortalink in hackstore.re, it was working at  the first times but for some reason stopped working and it is not skipping the url.

Second that!


Embedding getting saved as "number" datatype in Elastic Search Store, instead of "dense_vector". What can be the reason behind it?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Following is the code snippet i am using for indexing data into Elastic Store
`
from llama_index.vector_stores.elasticsearch import ElasticsearchStore
from llama_index.core import (
VectorStoreIndex,
ServiceContext,
StorageContext,
Settings
)
self.node_parser = SentenceWindowNodeParser.from_defaults(
window_size=3,
window_metadata_key="window",
original_text_metadata_key="original_text",
)
self.service_context = ServiceContext.from_defaults(
llm=None,
embed_model=self.embedding, # azure open ai embedding of 512 dimensions
)
self.document_store = ElasticsearchStore(
es_url=self.elasticsearch_url,
index_name=index_id,
)
self.storage_context = StorageContext.from_defaults(
vector_store=self.document_store,
)
self.index = VectorStoreIndex.from_vector_store(
vector_store=self.document_store,
storage_context=self.storage_context,
service_context=self.service_context,
)
sentence_nodes = self.node_parser.get_nodes_from_documents(docs) # docs is of List[Document] type
self.index = VectorStoreIndex(
sentence_nodes,
service_context=self.service_context,
storage_context=self.storage_context
)
`
When i am indexing the data, its taking embedding field as number data type. Because of this I am unable to perform the retrieve operation as it is expecting a dense vector field.
What can be the reason that after indexing, the embedding field is getting saved as number datatype ?

No idea. Feel free to make a PR if the code can be improved
https://github.com/run-llama/llama_index/blob/32e3c1f6f3acd28ec48b868568d3337b783e56d7/llama-index-integrations/vector_stores/llama-index-vector-stores-elasticsearch/llama_index/vector_stores/elasticsearch/base.py#L355


[SPARK-12692][BUILD][HOT-FIX] Fix the scala style of KinesisBackedBlockRDDSuite.scala.

https://github.com/apache/spark/pull/10736 was merged yesterday and caused the master start to fail because of the style issue.

I am going to merge it.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49319/
Test FAILed.

Thanks for the recovery.


[DO NOT MERGE] Enable strict sphinx

This PR should trigger a CI failure of Build Extended. This is just a test, and shouldn't be merged.

Broke CI, worked as expected, I'm happy, I'm closing


add csrf token lifetime element in template

https://jira.movember.com/browse/TN-3137

Hello @achen2401! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/factories/app.py:

Line 174:80: E501 line too long (91 > 79 characters)


AMD support breaks non AMD applications using global window.Backbone

I tried updating to the latest Backbone version 1.1.2 today, sadly this seems to break our legacy code that is not using AMD (at least not in every part of the application).
The global reference to window.Backbone seems to be missing:

Uncaught ReferenceError: Backbone is not defined

I think this is due to the fact, that Backbone will be attached to the window in the AMD factory/callback:
define(['underscore', 'jquery', 'exports'], function(_, $, exports) {
      // Export global even in AMD case in case this script is loaded with
      // others that may still expect a global Backbone.
      root.Backbone = factory(root, exports, _, $);
    });

This one will only be executed on the first (at least with using almond.js or similar)
require('backbone', ...)

Which, from my perspective, makes sense, since you don't want to execute a factory unless the module is really required.

So far this discussion assumed that the developer has full control over the global environment (and what gets loaded into it), but that is not always the case.
It is not the case when developing modular plugins for CMSes, such as WordPress.
A WordPress plugin developer may happily use Backbone in his plugin, and have it test out well and deploy fine on his and many other WordPress instances.  But eventually, some administrator of some other WordPress instance decides to install that particular plugin along with some other plugin that happens to just as happily use say the RequireJS AMD loader.  That site would work fine with either one of the plugins, but as soon as both are installed together disaster will strike.
At this time, the only way to avoid this problem is for the developer of the Backbone plugin to alter the Backbone he's integrating to remove AMD support, and for the developer of the RequireJS plugin to alter the RequireJS he's integrating to have it inject the AMD API into some unique namespace rather than the global namespace.  This will prevent either plugin from getting into this kind of a future collision.
However, if stock Backbone is intended to be used safely in modular CMS plugins then I think this issue has been closed prematurely.
Fixing this issue will likely require changes to the AMD API to be able to have the Backbone logic ask AMD if the dependencies are available via AMD before attempting to use AMD to load them, so that if not Backbone could just default to accessing them from the global namespace.
jQuery UI also has similar problem that I already filed a ticket on -- http://bugs.jqueryui.com/ticket/13449

Demonstrated here -- http://jsfiddle.net/wp9ebxbL/3/

@jrburke: Mind weighing in? As far as I know, there's now way to determine if you're inside a requirejs dependency load, or merely in the global context where define() is present.

If the developer is not in control of the overall environment, and they want the non-AMD pathway followed, they can construct this sort of script sequence around Backbone:
<script>var oldDefine = define; define = undefined;</script>
<script src="backbone.js"></script>
<script>define = oldDefine; oldDefine = undefined;</script>

Note that defer or async attributes on the script tags should not be used in this case.
I do not believe extraordinary measures should be done in UMD boilerplate to account for all possible global environment setup, it would make the UMD blocks incredibly large, and likely will not be comprehensive. If not in control of the whole global environment, I expect the developer will need to be more defensive in coding style anyway, and will know best what sorts of mitigations like the above are needed.
A define('backbone', function() { return Backbone; }) can be used in that third script tag if backbone also wants to be used in the AMD parts of the page. In that case, the developer may need to add in manual script tags for jQuery and underscore in that case to that script block above, and perhaps also do similar define() work for them in addition to the backbone one.
@jridgewell to your question, there is a require.specified(moduleId) that can return true if a module has been specified for loading, but it is only true if the module is part of a require([]) top level dependency chain. It will not be true if a bunch of defines are done without a top level require([]) being done before the require.specified() check.
But I do not believe knowing that distinction will help if the situation is a developer has some things that want a global backbone immediately but also has AMD parts that may also want backbone loaded.


Leaving the modal recording screen leads to data loss.

If accidentally swiping down the modal record screen, all my data will be lost.

Occurs even if an image is selected.
Occurs even in the middle of a recording session.

I made the modal view fullscreen. So it can't be swiped down anymore.


nx_tutorial_script

@Qudirah could you convert the jupyter notebook (.ipynb) to a python script (.py)? Thanks!

I will do that now. Thank you. I replied to some issues in the networkx
repo but I haven’t gotten a reply.
On Mon, 10 Oct 2022 at 17:30, Mridul Seth @.***> wrote:

@Qudirah https://github.com/Qudirah could you convert the jupyter
notebook (.ipynb) to a python script (.py)? Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/networkx/outreachy/pull/91#issuecomment-1273562076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWRSFHPCOXPEPNZZDNSINYTWCRACFANCNFSM6AAAAAARBOJQYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add support for ACME VHOSTs

Supporting change for https://github.com/aptible/sweetness/pull/606
cc @fancyremarker @blakepettersson

LGTM!


nixos/networkd: add/adopt IPv6 options

Description of changes
Adds a bunch of new options and deprecations, mostly related to Systemd 250 and IPv6.
The most significant change is the replacement of DHCPv6PrefixDelegation in favor of DHCPPrefixDelegation.
I've included the relevant systemd news entries in the commit messages.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I have a bunch of hosts where I did set networkConfig.IPv6Token in my config.
Is there a way to alias these things, or add some migration notes in the release notes?

Thanks for the review! I'd much rather add a release note entry. In my opinion, Systemd renames and deprecates options to regularly to alias them.
Therefore, I'd suggest to add entries to the release notes for the renamed/deprecated options in this PR. Fine for you?

Yes, fine for me

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@flokli Done 🙂

Thanks!


cherry-pick: add keep alive support on etcdv3 connections

Description

Cherry-pick of #777
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Fixes bug where Calico would silently lost its connection to etcd and never recover when the etcd server was terminated.

Hm, I cherry-picked this into master, which already had the commit :'(

The real one is here: https://github.com/projectcalico/libcalico-go/pull/780


aipcreator.py -supplement

Purpose: Add reports or outputs from the QC processes to the information package after sipping.
An example would be the easyDCP report. Currently if we want to add this report to the information package we have to perform QC before sipping. and this isn't ideal.
The files following -supplement will go into the 'supplemental' sub-folder in the 'metadata' folder.

Awesome that you used package_update for this.

Waiting for the update detail on batchaipcreator.py -supplement

Will start a new PR for batchaipcreator.py -supplement. This PR will be closed.


chore: remove snakeyaml dep from graphql-dgs-mocking

fixes issue #400

As discussed in issue #400, if I do not exclude this snakeyaml(with a classifier android), it will stop me to build the whole dgs-framework under my Windows system.
It is also a barrier when creating some sample codes, also encountered build issues if I do not exclude it.

Thanks, @hantsy! I still don't understand why we're not seeing the issue consistently, but this is good anyway.