feat(schematics): allow for using @nrwl/nx generate on @angular/material add schematic

Feature Description
@nrwl/nx is becoming more popular for managing mono-repos. However, nx doesn't have an nx add command, only an nx generate command. It would be nice to have some sort of schematic alias that would allow the ng add @angular/material logic to be run within an nx mono-repo.
There are some hurdles to overcome. At the moment, you can only run ng add @angular/material if you chose angular instead of nx as your CLI. If you choose nx as your CLI, then it generates a workspace.json instead of an angular.json. You can kind of get around this by moving workspace.json to angular.json, installing the angular CLI, and then running the ng add command, but it would be nice if there was first-class support for usage in an nx mono-repo using the nx CLI.

@kyliau IIRC there's a way to run an ng add schematic via the ng generate command, yes?

@jelbourn, you can run the ng-add schematic from another schematic, although prior to running the ng-add schematics, the package will need to be installed, this logic and logic to save the package in the package.json as dependency, dev dependency or not save it at all is only available in Angular CLI (https://github.com/angular/angular-cli/blob/master/packages/angular/cli/commands/add-impl.ts).
This seems to me that it should be a feature request to nx.

@alan-agius4 that wasn't quite what I had in mind. I decided to just try it out and yes, you can use ng generate to run the ng add command so long as you install the package first:
ng generate @angular/material:ng-add

Not sure if nx supports this, but that would be a feature request for nx.


Get rid of Laravel ;-)

Nice timing :-)

Initial Release 3 days ago

You could easily refactor this to be universal, not just for Laravel:

Remove Illuminate\Filesystem\Filesystem from the constructor of LaravelEpcQr
Use it like this:

use Ccharz\LaravelEpcQr\LaravelEpcQr;

$result = (new LaravelEpcQr())->amount(150)
    ->receiver('AT000000000000000000', 'ABCDATWW', 'Max Mustermann')
    ->note('test')
    ->purpose('AT12')
    ->text('Test Überweisungstext')
    ->build()
;

Rename it :-)
If that's really necessary (don't know, cause I'm not using Laravel), you could move the Laravel integration to a separate package, like https://github.com/endroid/qr-code-bundle for Symfony.

BTW: I would also rename all setters: setIban(), setBic(), ...

Thank you for your feedback.
If you need a non-laravel version there is already a package on GitHub you can use https://github.com/smhg/sepa-qr-php


replace rails dependency with AR+AS directly

I bumped version to 1.0.0 here, but maybe it would be fine to just bump to 0.0.8, potentially so that it doesn't require an inst_statsd release in order to upgrade. I should still be all compatible, other than bumping the minimum required Rails version from 3+ to 5.2+.

👍 looks good to me


About FedOpt (using bias-corrected momentum or not)

Thans for your excellent code.
Lines 50-63 in FedOpt
self.momentum = self.beta1 * self.momentum + (1 - self.beta1) * delta
delta_2 = torch.pow(delta, 2)
if self.option == "adagrad":
    self.vt += delta_2
elif self.option == "yogi":
    self.vt = self.vt - (
            1 - self.beta2) * delta_2 * torch.sign(self.vt - delta_2)
else:
    # adam
    self.vt = self.beta2 * self.vt + (1 - self.beta2) * delta_2
serialized_parameters = self.model_parameters + self.lr * self.momentum / (
            torch.sqrt(self.vt) + self.tau)

I note that in the original paper of adam [1] and also the pytorch website of adam optimizer, the bias-corrected first (and second) moment estimate is used for updating, i.e., ($beta_1$ to the power of $t$, from [1])
$$\hat{m}_t = m_t /(1-\beta_1^t)$$
$$\hat{v}_t = v_t /(1-\beta_2^t)$$
$$\theta_t = \theta_{t-1} - \alpha \cdot \hat{m}_t / (\sqrt{\hat{v}_t} + \epsilon)$$
Also, in [1], it has been shown that using bias-corrected momentum is better. Since I can not find the original code of "Adaptive Federated Optimization" (which is written in tensorflow, yet I still can not find the main code in their provided github code), so I am not sure which one I should use.
Thanks for your time and help.
[1] Adam A method for stochastic optimization

I implement this part strictly follows the Algorithm 2 in the original paper "Adaptive Federated Optimization" regardless of priori works. This algorithms work quite well in my experiments, especially FedYogi.

Thanks, I have checked the original code of "Adaptive Federated Optimization", which used the default optimizer of tf.keras.optimizers.Adam as their server optimizer. So I think they use the bias-corrected momentum in their experements for both adam and  yogi.
Thanks for your kind reply. If the issue actually deserves some value, I think we can add some comments in the code to remind the users of this issue.

Yes, sure.


Skip empty partitions on replay from Cassandra

Do not stop reading events from EventLog on empty partitions if
the toSequenceNr is known (i.e. not Long.MaxValue)
Closes #403

FWIW, LGTM!


New UI requirement: data upload

Need to create a UI that can showcase current APIs capabilities
The UI must support the following functionalities

upload json input(s)
show details of the uploaded apps
trigger entity standardization api call
present entity standardization result
4.1.	global breakdown (doughnuts/pie charts)
4.2.	individual app presentation
trigger containerization advisor api call
present containerization recommendations
6.1.	global breakdown
6.2.	individual app presentation

Drag and drop feature to upload the file


Distinguish between essential modal dialogs and popup notifications

Currently, the product does not distinguish between an essential modal dialog (e.g. a sign-in dialog, a trusted workspace dialog) and a non-essential pop-up (e.g. a recommendation to install a linter, a popup asking users to fill out a survey).
If this distinction were possible, we would enable a wide range of new notification management features - office hours, snooze, turn of notifications by extension, turn off all non-essential notifications.  These changes could empower the user to drastically reduce the notification load in their workspace.

@devinvalenciano just to clarify we know from the API wether an extension shows a modal dialog or a notification but we currently don't know if an extension shows a notification that is essential for the user to engage or just for information purposes. We have some heuristic by looking if any button is part of the toast, but it is not ideal.
I think extensions will have to move to our modal dialog API once we allow to snooze notifications.

@bpasero this is helpful context, thanks for sharing.
Here are some possible options I see moving forward -

We have three classes of notifications - modal dialogs, essential notifications, non-essential notifications.
As you mention, extensions could make use of the existing modal dialog API for essential notifications.
As you mention, we could look for interaction surfaces (e.g. buttons) to estimate whether a dialog is essential.

Only option 3 would require no changes from the extensions themselves, but I'm not sure we could sufficiently detect essential dialogs from the data we have available today.  An example where this could get blurry - see the non-essential linter recommendation dialog, which requests input from the user.

Is it possible to unify all of these concepts at a telemetry/API level?  Right now, we have a modal dialogs and notifications, and we're discussing the ability to differentiate between two types of notifications.  Within notifications, we have many different telemetry events.  Some examples, just for extension recommendation pop-ups:
"monacoworkbench/remoteextensionrecommendations:popup",
"monacoworkbench/terminallaunchrecommendation:popup",
"monacoworkbench/languagepacksuggestion:popup",
"monacoworkbench/extensionworkspacerecommendations:popup",
"monacoworkbench/fileextensionsuggestion:popup",
"monacoworkbench/extensionrecommendations:popup"
Would there be any benefits to consolidating these (plus any others out there) into two events?  One that fires when the notification is shown, and one that fires when the notification is interacted-with - regardless of what type of notification/dialog it is.  All of the other distinctions could be made in Properties.  See example schemas below:
"monacoworkbench/notificationshown" - Properties["type":"modaldialog", "purpose":"trustedworkspace", "id":"AAA"....]
"monacoworkbench/notificationshown" - Properties["type":"essential", "purpose":"extensionrec", "source":"fileextension", "id":"BBB"....]
"monacoworkbench/notificationshown" - Properties["type":"notification", "purpose":"extensionrec", "source":"config", "id":"CCC", "extension":"ms-vscode.ms-python"....]
"monacoworkbench/notificationinteraction" - Properties["action":"cancelled", "type":"modaldialog", "purpose":"trustedworkspace", "id":"AAA"....]
"monacoworkbench/notificationinteraction" - Properties["action":"install", "type":"essential", "purpose":"extensionrec", "source":"fileextension", "id":"BBB"....]
"monacoworkbench/notificationinteraction" - Properties["action":"show", "type":"notification", "purpose":"extensionrec", "source":"config", "id":"CCC", "extension":"ms-vscode.ms-python"....]

Yes I think once there is central telemetry for notifications (and possibly dialogs?) I would not expect to have these telemetry events that are notification specific anymore.
I do not think we can detect "essential" notifications going forward. Extensions will be forced to use the modal dialog API for those that need immediate attention. Possibly with some new API for the user to "Do not show again" in case an extension is spamming.


Align paceage version of SkiaSharp to Avalonia.Skia

To avoid errors when building WASM.
this PR fix #180

though align with Avalonia.Skia can compile, but it cannot run as WASM due to
aot-runtime-wasm.c:150 <disabled>
[balabala]


Updates for balena blocks

Change-type: minor
Signed-off-by: Alex Bucknall<EMAIL_ADDRESS>

@balena-ci I self-certify!


Log solc version in manifest

Related to https://github.com/OpenZeppelin/openzeppelin-upgrades/pull/658#issuecomment-1252951724.
If we want a chance to support UDVTs in Truffle in the future, we will need the solc version used for a deployed implementation because of #438. This simply adds that information in the StorageLayout objects in the manifest.

Should this include changelog entries (in core, hardhat, and truffle)?


Include .NET Core 2.1 runtime for signing task

.NET Core 2.1 is now out of support, but the codesigning task requires it. This change also adds some files we don't need to track to .gitignore

/azp run


Compatibility with empty chapters

Hi,
I really like your plugin, great work!
I use the ungrey plugin to make visible and clickable empty chapters.
It looks like this in the SUMMARY.md:
* New Section
  * [Chapter 1](chapter1.md)

Unfortunately, your plugin does not mark it as expandable (see the screenshot).

Could you please have a look if you could make it compatible? It would increase usability of the TOC greatly.
Thank you very much in advance!
Imre

I would love this as well! I've swapped over to toggle chapters but I like this one much more.

Hi, we don't need empty chapters. So I will not implement this enhancement immediately ...
But it's open source, so I would appreciate any pull request :-)


Interface files for base/dense and base/linalg

This is a follow-up to the last PR #471. I have added interface files for files in src/base/linalg and src/base/dense; and use these signatures in for the interface files in src/owl/dense and src/owl/linalg.
Functions that are defined in the core interface files are the ones that have not been (fully) implemented in base. The hope is as we implement more and more functions in base, we would need less and less signatures in the core interface files.
I've created owl_base_dense_matrix_{s,c,d,z} files so that the structure mirrors that which we see in src/owl/dense. A lot remains to be done.
@ryanrhymes @jzstark I found that there were two implementations of inv in base and I assumed that one of them is deprecated (link). Is this right?

One thing I'm still bit confused about the relation between owl_base_dense_ndarray_intf.ml and base/types/owl_types_ndarray_basic.ml. So my understand is that  for now if a function is updated in one file, then it is likely that the other one should also change accordingly. Is that right?

those in base/types are carefully crafted to provide a minimal set of functions Algodiff needs to implemented. One needs to be careful when modifying those files since it may break algodiff, dnn, cgraph ....
on the other hands, the ones Calvin made are simply for defining the interfaces implemented in Ndarray or Linalg modules. Though ideally, they shall/can also be in types folder.

For inconsistent APIs in Base.Linalg, Jianxin already had a plan for fixing them and extending to complex numbers, see this issue https://github.com/owlbarn/owl/issues/473

I’ve changed Base to Common in all the intf. The reason for this change was that I didn’t want to confuse Base in the interface with owl-base. I chose Common to because these signatures common to both real and complex ndarrays. But to be honest I don’t have a strong opinion about this. Happy to change it back to Base or something else. Any ideas?

I’ve changed Base to Common in all the intf. The reason for this change was that I didn’t want to confuse Base in the interface with owl-base. I chose the name Common because these signatures are common to both real and complex ndarrays. But to be honest I don’t have a strong opinion about this. Happy to change it back to Base or something else. Any ideas?

Common is fine, as long as they are used consistently in the code. I agree Base might be confusing, so let's stay with common.

@tachukao do you still any pending commits? if not, I will merge it then.

None left. Sounds good!


HIVE-27150: Drop single partition can also support direct sql

What changes were proposed in this pull request?
We want to reuse the dropPartitionsInternal() method for drop_partition_common api to enjoy the high performance, to achieve this we will refactor the RawStore#dropPartition api.
Why are the changes needed?

support direct sql for drop single partition
reduce one query to the DB, that is MPartition query in ObjectStore#dropPartition

Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass all existing tests.
Add the benchmark test for dropPartition:

java -jar hmsbench-jar-with-dependencies.jar -H localhost --savedata /tmp/benchdata --sanitize -N 10 -N 100 -o bench_results.csv -C -d testbench --params=100 -E 'list.*' -E 'createTable' -E 'dropTable.*' -E 'get.*' -E 'add.*' -E 'renameTable.*' -E 'dropDatabase.*' -E 'openTxn.*' -E 'PartitionManagementTask'

Before use direct sql:
Operation                      Mean     Med      Min      Max      Err%
dropPartition                  29.60    28.32    27.38    57.81    13.86
dropPartition.10               263.1    272.3    160.7    292.5    12.09
dropPartition.100              2461     2735     1610     4381     22.36
dropPartitions.10              22.97    22.46    21.56    36.05    8.306
dropPartitions.100             26.97    26.35    24.71    35.25    7.569

After use direct sql:
Operation                      Mean     Med      Min      Max      Err%
dropPartition                  24.76    24.56    20.86    36.23    11.47
dropPartition.10               190.1    165.7    153.5    275.1    23.76
dropPartition.100              2181     2591     1482     4831     28.61
dropPartitions.10              17.71    17.43    15.84    25.37    7.857
dropPartitions.100             34.42    33.10    31.61    58.97    11.98

@deniskuzZ @kasakrisz @saihemanth-cloudera: Could you please review this PR?

Put the benchmark in PR description, it shows some performance improvement. FYI: @deniskuzZ @saihemanth-cloudera @VenuReddy2103

Address comments. cc: @saihemanth-cloudera


Migration Tool treats local file as an external package that hasn't migrated

Please see this screenshot:

name: listenable_collections
description: A collection of Dart collections that behave like ValueNotifier if their data changes.
version: 0.0.5
author: Thomas Burkhart
homepage: https://github.com/escamoteur/listenable_collections

environment:
  sdk: ">=2.7.0 <3.0.0"
  flutter: ">=1.17.0 <2.0.0"

dependencies:
  collection: ^1.15.0
  flutter:
    sdk: flutter

this is the repo I try to migrate https://github.com/escamoteur/listenable_collections

Hi @escamoteur, thanks for the bug report!  It looks like you aren't the first person to run into this problem - a similar issue was also reported in #45478, which I unfortunately wasn't able to reproduce.  Fortunately, I was able to reproduce your bug (checking out https://github.com/escamoteur/listenable_collections/commit/010b5ba881a9a7ea99bf5dbf072b6a3a25e1621c), so I will work on a fix.
I see from https://github.com/escamoteur/listenable_collections/commit/0f28b6b945764daf5667aabe63557a9dc2beba21 that you were able to perform migration in spite of this bug.  I'm glad to see that!
In case it's useful to anyone else, I was able to work around the bug and get the migration tool to proceed by changing the import statement in test/list_notifier_test.dart from this:
import '../lib/src/list_notifier.dart';

to this:
import 'package:listenable_collections/src/list_notifier.dart';

It looks like the migration tool is getting confused by the presence of the relative import from test to lib.  Most Dart code I work with uses package: imports when going from test to lib, but I'm not sure whether that's just a matter of personal preference or if there's a good reason to prefer one of the other.  I'm talking with some folks on the language team to try to get clarification on that, and I'll update this bug when I have more information.

Found the problem: the migration tool's logic for detecting unmigrated dependencies uses URIs to exclude a package's own files from the check.  But importing a lib file from test causes that file to be reached via a file: URI, whereas the rest of the migration tool assumes that files in lib will be reached via a package: URI.  The URIs don't match so the migration tool doesn't exclude the dependency.
I have a fix in the works.

@stereotype441 was there a fix included in the sdk for this?  I seem to be having this issue now.  I'm about three years behind and the migration tool was left out of the latest upgrades.  I'm here
Flutter 3.7.12 • channel unknown • unknown source
Framework • revision 4d9e56e694 (5 months ago) • 2023-04-17 21:47:46 -0400
Engine • revision 1a65d409c7
Tools • Dart 2.19.6 • DevTools 2.20.1

@stereotype441 was there a fix included in the sdk for this? I seem to be having this issue now. I'm about three years behind and the migration tool was left out of the latest upgrades. I'm here
Flutter 3.7.12 • channel unknown • unknown source Framework • revision 4d9e56e694 (5 months ago) • 2023-04-17 21:47:46 -0400 Engine • revision 1a65d409c7 Tools • Dart 2.19.6 • DevTools 2.20.1

Yes, the fix for this was included in Dart 2.14.

@dcoleyoung @stereotype441 i'm hitting this as well with Dart 2.19.6, could it be possible it's not in there?
any file that is included with a 'package:<path_to_subdir_in project>/file' is getting flagged by tool...
thanks

I actually got the conversion tool to work on my app.  What I did was download and use FVM trying it from earlier possible sdk to see what would run.  My app was created with SDK 1.22.0 so it was too far behind for anything modern.
The migration tool ran on sdk 2.0.0 on my app with minimal evaluation errors (~10).  When I corrected those by hand the migration tool ran and I was able to apply the changes.  Then I reboosted the sdk to higher versions.

@nholmvio the last flutter version with the bundled migration tool is 3.7.12


Cancelling Comma Prime UI issue

The UI presents the "sorry to see you cancel screen" with a back button "<" icon on the top left and a CANCEL button.  To me the cancel button means cancel the request to cancel comma prime command, but the comma connect app uses the cancel button to means proceed with the cancellation. It would be better if the app had a button like "YES I I WISH TO CANCEL COMMA PRIME" and another button "NO I WANT TO KEEP COMMA PRIME". or something like that.

prime settings are no longer in connect


The types of the render functions in the Placeholder component props are not correct or missing

Description

Problem 1: The typing of the renderEach function in the PlaceholderProps does not match the way it is being used in the Placeholder render function. In the props it is typed like this
renderEach?: (components: React.ReactNode[], data: (ComponentRendering | HtmlElementRendering)[], props: PlaceholderProps) => React.ComponentClass<any> | React.SFC<any>;
but in the Placeholder render function it is called with a single component and an index, which is correct. The type in the props is wrong.
Problem 2: The renderEmpty function is not mentioned in the Placeholder props
Problem 3: All the 3 render, renderEach, renderEmpty functions have a return type not allowing to return a React element

Expected behavior
When I install the sitecore-jss-react package version 12 or 13 in my project and I am using typescript, I would expect to be able to use the renderEach function by providing a component and an index parameter and not having a type error. I would also expect to be able to define a render function on my placeholder and be able to return a react element without getting a type error. And lastly, I would expect to be able to see the type of the renderEmpty function exposed in the PlaceholderProps.
Steps To Reproduce

Assuming that you have a react typescript repo using sitecore jss, install version 12 or 13 of sitecore-jss-react
Create a component and add a Placeholder inside
Try to add a renderEach prop on the Placeholder, for example:

export const renderEach = (component: React.ReactNode, index: number) => (

{component}

)

export const Component = ({ rendering }: Props) => (
  <Placeholder rendering={rendering} name='main' renderEach={renderEach} />
)

Run a type check
See error

Additional note
The prop [key: string]: any; is hiding all the type errors from the Placeholder component. The mismatching function prototypes are being accepted as correct because of this prop. If you temporarily comment it out and run a type check, it is clear that the types in Placeholder component are incorrect.
Your Environment

Sitecore Version: 9.0.2
JSS Version: 13.0.3
Browser Name and version: Not applicable
Operating System and version (desktop or mobile): Not applicable
Link to your project (if available):

@vsirakova Merged PR, fix will be released in version 14.0.0.


backgroundImageOpacity seems to be ignored.

My settings file is below.  The background image is opaque no matter what I set it to.
``
// This file was initially generated by Windows Terminal 0.11.1333.0
// It should still be usable in newer versions, but newer versions might have additional
// settings, help text, or changes that you will not see unless you clear this file
// and let us generate a new one for you.
// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation
{
"$schema": "https://aka.ms/terminal-profiles-schema",
"defaultProfile": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",

// You can add more global application settings here.
// To learn more about global settings, visit https://aka.ms/terminal-global-settings

// If enabled, selections are automatically copied to your clipboard.
"copyOnSelect": false,

// If enabled, formatted data is also copied to your clipboard
"copyFormatting": false,

// A profile specifies a command to execute paired with information about how it should look and feel.
// Each one of them will appear in the 'New Tab' dropdown,
//   and can be invoked from the commandline with `wt.exe -p xxx`
// To learn more about profiles, visit https://aka.ms/terminal-profile-settings
"profiles":
{
    "defaults":
    {
        // Put settings here that you want to apply to all profiles.
    },
    "list":
    [
      {
        "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
        "hidden": false,
        "name": "PowerShell",
        "source": "Windows.Terminal.PowershellCore",
        "fontFace": "Cascadia Code PL",
        "useAcrylic": true,
        "acrylicOpacity": "0.5",
        "backgroundImage": "C:\\Users\\gary\\OneDrive\\Pictures\\powershell-core-logo-mini.png",
        "backgroundImageStretchMode": "none",
        "backgroundImageAlignment": "bottomRight",
        "backgroundImageOpacity":  "0.1"
      },
      {
        // Make changes here to the cmd.exe profile.
        "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
        "name": "Command Prompt",
        "commandline": "cmd.exe",
        "hidden": false,
        "fontFace": "Consolas",
        "useAcrylic": false,
        "acrylicOpacity": "0.5"
      },
      {
        "guid": "{c6eaf9f4-32a7-5fdc-b5cf-066e8a4b1e40}",
        "hidden": false,
        "name": "Ubuntu-18.04",
        "source": "Windows.Terminal.Wsl",
        "fontFace": "Consolas",
        "useAcrylic": true,
        "acrylicOpacity": "0.5",
        "background": "#643200",
        "backgroundImage": "C:\\Users\\gary\\OneDrive\\Pictures\\ubuntu-logo32.png",
        "backgroundImageStretchMode": "none",
        "backgroundImageAlignment": "bottomRight",
        "backgroundImageOpacity": "0.1"
      },
      {
        "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
        "hidden": false,
        "name": "Azure Cloud Shell",
        "source": "Windows.Terminal.Azure",
        "fontFace": "Consolas",
        "useAcrylic": true,
        "acrylicOpacity": "0.5",
        "backgroundImage": "C:\\Users\\gary\\OneDrive\\Pictures\\azure.png",
        "backgroundImageStretchMode": "none",
        "backgroundImageAlignment": "bottomRight",
        "backgroundImageOpacity": "0.2"
      },
      {
        // Make changes here to the powershell.exe profile.
        "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
        "name": "Windows PowerShell",
        "commandline": "powershell.exe",
        "hidden": false,
        "fontFace": "Cascadia Code PL",
        "useAcrylic": true,
        "acrylicOpacity": "0.5",
        "background": "#00007f",
        "backgroundImage": "C:\\Users\\gary\\OneDrive\\Pictures\\windows-powershell-logo-mini.png",
        "backgroundImageStretchMode": "none",
        "backgroundImageAlignment": "bottomRight",
        "backgroundImageOpacity": "0.1"
      },
      {
        // Make changes here to the powershell.exe profile.
        "guid": "{F4580F1B-BE5E-406C-9363-2B1A726A8DB1}",
        "name": "Windows PowerShell ISE",
        "commandline": "powershell_ise.exe",
        "hidden": false,
        "fontFace": "Consolas",
        "useAcrylic": true,
        "acrylicOpacity": "0.5"
      }
    ]
},

// Add custom color schemes to this array.
// To learn more about color schemes, visit https://aka.ms/terminal-color-schemes
"schemes": [],

// Add custom keybindings to this array.
// To unbind a key combination from your defaults.json, set the command to "unbound".
// To learn more about keybindings, visit https://aka.ms/terminal-keybindings
"keybindings":
[
    // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json.
    // These two lines additionally bind them to Ctrl+C and Ctrl+V.
    // To learn more about selection, visit https://aka.ms/terminal-selection
    { "command": {"action": "copy", "singleLine": false }, "keys": "ctrl+c" },
    { "command": "paste", "keys": "ctrl+v" },

    // Press Ctrl+Shift+F to open the search box
    { "command": "find", "keys": "ctrl+shift+f" },

    // Press Alt+Shift+D to open a new pane.
    // - "split": "auto" makes this pane open in the direction that provides the most surface area.
    // - "splitMode": "duplicate" makes the new pane use the focused pane's profile.
    // To learn more about panes, visit https://aka.ms/terminal-panes
    { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" }
]

}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cdc47554-5bdf-3c0b-b0aa-9cdf7dd1f552
Version Independent ID: d4f44877-99e8-4563-6b06-7b6f9bcd43bd
Content: Windows Terminal Profile Settings
Content Source: TerminalDocs/customize-settings/profile-settings.md
Service: terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

Try taking the quotes off the 0.1 :)

Thanks for the quick response!  "acrylicOpacity" was accepting strings, so I assumed "backgroundImageOpacity" would as well.  Taking away the quotes worked!  Thanks!


[Task]  com/usthe/warehouse/controller/MetricsDataControllerTest.java

Description
Description
Help us impl Unit Test For com/usthe/warehouse/controller/MetricsDataControllerTest.java
You can learn and refer to the previous test cases impl.

controller example unit case:  https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/controller/AccountControllerTest.java
service example unit case:  https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/service/TagServiceTest.java
jpa sql dao example unit case: https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/dao/MonitorDaoTest.java

Task List

[ ]  Impl Unit Test For  com/usthe/warehouse/controller/MetricsDataControllerTest.java

pls assign it to me.


Revert "Added meta tags,titles,and favicon"

Reverts Jazeebarana/web-page-site#1

changed jpeg to png


Installer not finishing...Help needed newbie here

Hi,
I was installing pagekit on my shared hosting. I have uploaded pagekit using filezilla and started the installation.
I have connected to database, filled site details and click on installer. Everything was smooth till this step. Then the installer is not finishing the installation

. it's been 1 hour now the process is still  going on see the screenshot (my domain name is masked and edited by me).
I was confused, so I loged into my database. Shockingly there is no tables created by pagekit installer, even after 1 hour.
Please help me.
J2D555

i have same problem

@nakamura, sadly no one found a solution yet... Lets find a solution together.

I think it is installing the php extension as the requirement those have to exist to be installed.
I have installed for 24 hours and still not finishing, accessing joomla is forbidden.
damn. this take a very long time.

Did you guys notice any javascript error in the debug console?

Don't know if it is related, I got the following error:

Installation failed!
The contents of     http://pagekit.com/package/pagekit/blog%247e3ec449993dac0122a6f3ea19865798652f7c7897b2f497f90e43d5aa832be7.json do not match its signature. This should indicate a man-in-the-middle attack. Try running composer again and report this if you think it is a mistake.

I had a similar problem in, see #523
Was fixed in https://github.com/pagekit/pagekit/commit/674a8411df2853b3d960794ba87c66e4a8f92ddc

i have same problem,and Warning: zlib_decode(): data error

@leefouce please clear the composer cache (tmp/temp/composer) and try again.

The next Pagekit release (and current dev branch) comes with a reworked installer.
Please open a new issue if problems occur.


error when creating image

hi there any ideas why i get this error when doing a docker build
Step 9/10 : RUN ./setup.sh
---> Running in b6abe9fa1f84
Adding user kubeactuser' ... Adding new group kubeactuser' (1000) ...
Adding new user kubeactuser' (1000) with group kubeactuser' ...
Creating home directory /home/kubeactuser' ... Copying files from /etc/skel' ...
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100    84  100    84    0     0    325      0 --:--:-- --:--:-- --:--:--   325
The command '/bin/sh -c ./setup.sh' returned a non-zero code: 1

Same here.
 => ERROR [6/6] RUN ./setup.sh                                                                                0.6s
------
 > [6/6] RUN ./setup.sh:
#11 0.195 Adding user `kubeactuser' ...
#11 0.195 Adding new group `kubeactuser' (1000) ...
#11 0.206 Adding new user `kubeactuser' (1000) with group `kubeactuser' ...
#11 0.232 Creating home directory `/home/kubeactuser' ...
#11 0.233 Copying files from `/etc/skel' ...
#11 0.268   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#11 0.268                                  Dload  Upload   Total   Spent    Left  Speed
100    90  100    90    0     0    248      0 --:--:-- --:--:-- --:--:--   249
------
executor failed running [/bin/sh -c ./setup.sh]: exit code: 1


Inconsistent API for on_predict_epoch_end

🚀 Feature

Background
We are auditing the Lightning components and APIs to assess opportunities for improvements:

https://github.com/PyTorchLightning/pytorch-lightning/issues/7740
https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#

One item that came up was on_predict_epoch_end() defined on the ModelHooks Mixin. This accepts an outputs: List[Any] argument. However, this is inconsistent with the other model hooks of the same type: on_train_epoch_end, on_validation_epoch_end, and on_test_epoch_end
Motivation
API consistency with other epoch end model hooks.
Pitch

Add a prediction_epoch_end hook to the LightningModule
Deprecate the outputs argument from on_predict_epoch_end in v1.5 and remove entirely in v1.7
Update the prediction loop to only cache predictions if prediction_epoch_end is implemented

Users can optionally avoid this entirely and cache their prediction outputs as needed by implementing this logic in predict_step directly

Alternatives
Keep as is?
Additional context
cc @borda @tchaton @justusschock @awaelchli @carmocca @ninginthecloud @daniellepintz @rohitgr7

I'd like to work on this, could you assign this issue to me?

So I just want to follow up on the standard way of now returning data using the predict step.
Ideally I would want this all defined in the model class so I dont have to tweak the prediction script for each model I use.
Would it be something like this, because it seems less intuitive to me compared to the older methods and adds alot of boilerplate code:
class Model(pl.LightningModule):
    def __init__(self, *args):
        super().__init__()
        self.save_hyperparameters(logger=False)
        self.predict_step_outputs = []
        self.predict_outputs = None
        ...

    def on_predict_epoch_start(self) -> None:
        self.predict_outputs = None

    def predict_step(self, batch: tuple, _batch_idx: int) -> None:
        outputs = ... # However to calculate the outputs
        self.predict_step_outputs.append(outputs)

    def on_predict_epoch_end(self, outputs) -> tuple:
        combined_predictions = ...  # However to combine, like T.vstack etc
        self.predict_outputs = combined_predictions

# Then in the export/predict script
trainer.predict(model=model, datamodule=datamodule)
outputs = model.predict_outputs

That works. You can also do the combination after trainer.predict() so that you don't need the predict_outputs attribute

So there is no way to overload how the trainer.predict() method combines the output of each batch? Will it always return as a list?

Are you asking about the predictions returned? predictions = trainer.predict(..., return_predictions=True)?

Exactly. By default it returns a list of whatever was returned by the model's predict_step for each batch pass.  I was wondering if there was a built in function for this or would I have to define my own like:
predictions = trainer.predict(..., return_predictions=True) predictions = model.process_and_combine(predictions)


Fix Build Breaking from Issue#44

@MauleshSTrivedi please review. @shaun-edwards please merge as soon as CI passes and Maulesh approves. Thanks.


Promise.all(...load) returns different order when batched

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Given the following GraphQL resolver that does a Promise.all on several loader.load(id) calls:
/**
 * GraphQL resolver that, given an ugly "posts" feed fetches
 * the pretty version from a loader.
 */
posts(ugly, args, context) {
  console.log("ugly", ugly.posts.map((post) => post.id));

  // Wait on all posts to load from the prettier source
  return Promise.all(
    ugly.posts.map((post) => loader.load(post.id))
  ).then((posts) => {
    console.log("pretty", posts.map((post) => post.id));

    return posts;
  });
},

When batch: false, the result is correct:
// ugly [ 7, 82, 102, 9, 11, 6, 201, 22, 75, 327 ]
// pretty [ 7, 82, 102, 9, 11, 6, 201, 22, 75, 327 ]

However, when batch: true, the output is somehow ordered:
// ugly [ 7, 82, 102, 9, 11, 6, 201, 22, 75, 327 ]
// pretty [ 6, 7, 9, 11, 22, 75, 82, 102, 201, 327 ]

(Note that the value of cache has no impact on this whatsoever).
I couldn't find any place in the code that ordering occurs based off of batch.
This behavior is worrisome as it doesn't match expectations with example code:
var [ a, b ] = await Promise.all([
  myLoader.load('a'),
  myLoader.load('b')
]);

Ah, ok. Simple dilemma, simple solution: ensure that the batchedFn provided in the constructor sorts results to match the passed in keys.
By default, it seems MySQL returns rows sorted by id when no sort has been provided.
When batch: true, these IDs are fetched in bulk (and sorted by MySQL) vs. when batch: false, the IDs are fetched individually, so they return their original order.
Thanks for being here to talk it out :D

Haha, glad you resolved this. Yes, it is important that your batch loader maintain this order.


Illegal option -B on boot opnsense-devel

Hi,
I updated opnsense-devel to 17.1.a_277 (amd64/OpenSSL) And I'm seeing this on boot:

Work in progress. This area of opnsense-update is still under development. For now the error is intended and only on -devel. :)

ok, thanks!

These stubs will prevent the message from appearing in 16.7.4 even when the work isn't finished:
https://github.com/opnsense/update/commit/275cc86ab05a8d361782efda98535544bfc7f85e


Tokenizer for using UKWac model

Dear creator (@orenmel),
I am currently using your great tool and the pre-trained UKWaC model to create context vectors for target words in Wikipedia sentences.
To my questions: 1. Do you use the default UKWaC tokenization as input for the training? 2. Which tokenizer should I use for new input at test time in order to make the best out of the model? (Do you have any suggestions?)
Best regards,
David

Hi David,

Yes. I believe we used the default UkWaC tokenization.
At test time, we used NLTK tokenizers (see for example mscc_text_tokenize.py) and that worked fine. Do make sure to also lowercase the input.
Oren.
PS: For your use case, it seems like a model trained on Wikipedia would be best. If you happen to have the time and resources to train a context2vec Wikipedia model, I'd be happy to know about it.

Thanks for the information, Oren!
Im aware that it might be not the optimal to use the UKWaC model on Wikipedia data but at the moment I only have (non-admin) access to GPUs that run on Cuda 8.0 which causes problems with chainer 1.7. Due to time limitations I can't switch to CPU :)


fix(root-layout): use inner child width for sidebar

fix(root-layout): use inner child width for sidebar

:hammer_and_wrench: Type Of Change

[x] Fix
[ ] Feature
[ ] Refactoring
[ ] Documentation

:book: Description
Made Root Layout sidebar use the child element width rather than setting fixed width.
:bulb: Context
Root layout was displaying width even when empty, similar to what the header and footer were doing before.
:pencil: Checklist

[x] I have reviewed my changes
[x] I have added tests
[x] I have added all relevant documentation
[x] I have validated components with a screen reader
[x] I have validated components keyboard navigation
[x] I have considered the performance impact of my change
[x] I have checked that my change did not significantly increase bundle size
[x] I am exporting any new components or constants in the index.js in the component directory
[x] I am exporting any new components or constants in the index.js in the root

Does this fix
https://dialpad.slack.com/archives/C03DXS7NB7D/p1696540132350419 ?

Does this fix https://dialpad.slack.com/archives/C03DXS7NB7D/p1696540132350419 ?

yep


feat: add helm execution gradle task: HelmUninstallChartTask

Description
This pull request changes the following:

add HelmUninstallChartTask to fullstack-gradle-plugin
add example usage in fullstack-examples/build.gradle.kts

PR Walkthrough (2 minutes): https://www.loom.com/share/a4742de2d0f74e5bb9c4d47caf19866e?sid=c2e55ba2-6bdd-44d3-ab83-fe9d191a3e23
Related Issues

Closes #323
depends on #288

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


viking: Fix usage of data_symbols

When trying to resolve data symbol-pointers, the checker tries to account the file offset of the pointer twice: Once in the check_data_symbol_ptr itself, and once again when calling elf::get_bytes. This lead to the pointers pointing to a wrong offset, resolving into different data structures and thus displaying (nonexistant) errors or just failing to resolve due to an out-of-bounds read.
This PR fixes this behaviour, by removing the manual offset calculation from this class and just letting that handle the elf class.

This change is

Please put the PR description in the commit message. It should be possible to figure out why a change was made just by reading the commit description.


Add 'Cancel' button to add room view

Purpose or Intent

The goal of this PR is to add a Cancel button to the Add_Room view.

Coverage remained the same at 89.8% when pulling 549ca6a31a6860e5a6ff2105a1e49361f496923a on sebjimenez:add_room_cancel_btn into 286c309b7b3f9bb76c4036d9e0005c105751509f on propedeutica:master.

Coverage remained the same at 89.921% when pulling 80ab05e8c3fd2fb93a530bd490663c57706815e2 on sebjimenez:add_room_cancel_btn into 884c21589fc6d2e4697bfde027222d0d9385fa80 on propedeutica:master.

Already passed haml-lint. Ready to merge @sergio-ocon

@agarciavera please review

Coverage remained the same at 91.245% when pulling e0943832a48b90f65fe17ff5340bf445eb4bed68 on sebjimenez:add_room_cancel_btn into b3ff297c48c5725a264624f61f0253039c036194 on propedeutica:master.

Coverage remained the same at 91.245% when pulling 232e2e01770ef68e480aaa0453a53614e5a26aa7 on sebjimenez:add_room_cancel_btn into b3ff297c48c5725a264624f61f0253039c036194 on propedeutica:master.

Coverage remained the same at 91.245% when pulling d5bc4d95addfc572d6499f2b389d42edd691ac24 on sebjimenez:add_room_cancel_btn into b3ff297c48c5725a264624f61f0253039c036194 on propedeutica:master.

Coverage remained the same at 91.245% when pulling e1e325c06c4b5e10858ee065d154fdef5220e660 on sebjimenez:add_room_cancel_btn into b3ff297c48c5725a264624f61f0253039c036194 on propedeutica:master.

Coverage remained the same at 91.245% when pulling bdf695bea5c1e5b84155bb02dae092c06ed57460 on sebjimenez:add_room_cancel_btn into b3ff297c48c5725a264624f61f0253039c036194 on propedeutica:master.

Coverage remained the same at 91.245% when pulling bdf695bea5c1e5b84155bb02dae092c06ed57460 on sebjimenez:add_room_cancel_btn into b3ff297c48c5725a264624f61f0253039c036194 on propedeutica:master.


Find a way to avoid the standard method collisions like the GetTypeInfo

See #366 for details

In v5 GetTypeInfo polyfil was removed.


Keyboard focus rings are not fully visible in landing page header in Chrome

Describe the bug
When navigating the page using the keyboard it is not possible to see if a link is highlighted in the header section. This is dependent on screen resolution and zoom level and at least affects the Chrome browser. Chrome appears to use a black ring with a white border for the focus ring. This is similar to the existing styles on the links in the header and makes the focus ring difficult to detect visually.
To Reproduce
Steps to reproduce the behavior:

Using Chrome, Go to the Together landing page at https://together.cyclic.app/
(If you are redirected to the calendar view, click the Home button in the top left to go back to the landing page.)
Click on the URL bar in your browser.
Press the tab key repeatedly to cycle through all the site links.
Notice that the top buttons never appear to have a visible focus ring but the other links do.

Expected behavior
Links should have a visible focus ring for accessibility.
Screenshots
Above 100% zoom, there is a barely perceptible white ring around the home button in this screenshot

At 75% zoom, there is a more pronounced black ring on the home button but it is still difficult to see.

Which Branch should this fix be Pulled into?
PR into main
Device Information
Desktop (please complete the following information):

OS: Windows 11
Browser: Chrome
Version: 114.0.5735.199 (Official Build) (64-bit)
Tested on my machine but likely affects all devices.

Additional context
The focus ring for these links could be changed to a more contrasting color or larger size but this change should still be tested on additional browsers before closing the issue.
If you're interested in working on this feature, please comment so you can be assigned

Hey Eric, Can I take this issue ?


Psalm integration

Feature Request

Q
A

QA
yes

Summary
As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.
Implementing psalm is quite easy.
Required

[ ] Create a .psalm.xml.dist in the project root
[ ] Copy and paste the contents from this psalm.xml.dist
[ ] Run $ composer require vimeo/psalm
[ ] Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
[ ] Add a composer script static-analysis with the command psalm --shepherd --stats
[ ] Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
[ ] Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Optional

[ ] Fix as many psalm errors as possible.

Closed with #16


🐛 [cloud_firestore_odm_generator] orderBy queries are using hardcode values.

Considering the model used in the documentation:
@JsonSerializable()
class User {
  User({
    required this.name,
    required this.age,
    required this.email,
  }) {
    // Apply the validator
    $assertUser(this);
  }

  final String name;
  final String email;

  // Apply the `Min` validator
  @Min(0)
  final int age;
}

After running
flutter pub run build_runner build --delete-conflicting-outputs

the helper methods it creates for orderBy don't make use of the descending variable passed to them, for example:
Current code:
UserQuery orderByName({
  bool descending = false,
  // ... other properties
}) {
  var query = reference.orderBy('name', descending: false); // <-- This is the issue.
  // ...
}

Expected code:
UserQuery orderByName({
  bool descending = false,
  // ... other properties
}) {
  var query = reference.orderBy('name', descending: descending); // <-- This is what it should be
  // ...
}

Doing this will now solve the queries returned by:
usersRef.orderByName(descending: true);

@dark-chocolate
Can you confirm if this is same as https://github.com/FirebaseExtended/flutterfire/issues/7733 ?

@darshankawar  A bit similar because in that thread the OP is only raising issue for snake_case fields but in my issue it's about all the fields.

Thanks for the update.
/cc @rrousselGit


[retirement] Improve UX of Verra project page link

This feature request came from a community member and was captured in #851
Feedback/Suggestion: It's not obvious that to go to the corresponding Verra page for the project, you need to click the VCS code of the project. "Project Details Page" or something could be a band aid solution
Developer Comment: Agree with this. The verra project page link wasn't part of the initial brief but I included it because it felt sensible to do so. I think we can more intentionally expose the link.
Next steps:

[ ] @theprofessora to provide design recommendation to improve the UX of this feature

I think this is the solution for now (see below). It's starting to feel a bit cluttered visually, but everything will improve once we start to publish the new designs from our re-imagined KI User Journey

Take the font down to 14px (and reduce the size of the icon accordingly)
remove underline
change wording to "view project details"

sounds good

Thanks @theprofessora, I'll have a play around and tag you in the PR for final approval :)


Sample application time zone problem

It seems that the Sample application's ci_log4net formatting https://github.com/cityindex/log4net.Appenders.Contrib/blob/master/src/SampleApp/App.config#L37 doesn't work properly, when the application is launched in time zone different from the server's time zone. (time is formatted with local application's time zone, but gets parsed with London time zone at the server side)

I've tried to format timestamp with time zone, but this results with "syslog_standard,ci_log4net,_dateparsefailure" tags.
Source message was
2015-09-30T07:46:42.826Z INFO  SenderThread RemoteSyslog5424AppenderDiagLogger - Starting 'log4net.Appenders.Contrib.SampleApp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' 'log4net.Appenders.Contrib, Version=<IP_ADDRESS>15, Culture=neutral, PublicKeyToken=null

@mrdavidlaing, do you have any ideas how we can fix this problem?

@fandrei,
The ci_log4net parsers force the time to be London time, since the offset isn't normally included.
Looks like we need to extend the ci_log4net parsers to support log messages that include the timezone.


Vickel: Watch oceanpowerltd.com

Vickel requests the watch of the watch_keyword oceanpowerltd\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

oceanpowerltd\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


Lora

I have LLamaSharp working with my c# Winform, thanks everyone for helping.  When I use oobabooga I have created a Lora.  Is it possible to load that with LLamaSharp?

You should be able to add it to the LoraAdapters in the parameters when you load the model. It will be applied then.

(Assuming a Lora created with oobabooga is compatible with llama.cpp of course).

Can we do this with LlamaSharp llike in llama.cpp? (Use multiple lora adapters)
If it's not implemented I would like to help, it is something I could really use for my project.


Clarifying Slack adapter Oauth token functionality

In working with the Slack connector I've noticed a couple things that others could likely benefit from knowing as follows:

Bot service connector vs. Bot builder adapter.   A key difference is that since the Slack adapter is tied to a specific OAuth token, OOB it can only be used with a Slack workspace that the developer has access to, so publishing an app to the Slack app directory would require using the bot service connector.   Also might be worth clarifying that the SlackBotToken in the Slack adapter settings is the Slack Bot User OAuth Access Token and not the Slack App Client Secret.

The bot service connector only supports the legacy Slack message button format, not the current Block Kit button elements.  More details are this are in an issue I raised on the BotFramework-Services repo here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97b7eb7d-843a-774e-3ee4-8f3126cfea20
Version Independent ID: 5d501ffc-819f-0634-671c-13d432aa7f28
Content: Connect a bot to Slack with the Bot Framework SDK - Bot Service
Content Source: articles/bot-service-channel-connect-slack.md
Service: bot-service
GitHub Login: @JonathanFingold
Microsoft Alias: iawilt

The Connect to Slack article has been updated to point users to the Community repo if they want instructions on how to use the Slack adapter.


Docs: Fix few things related to the docs.

Fix missing link for TxnBox inside the plugins main doc page.
Fix doctree for Stale response plugin. They were all displayed at the doctree level, it now just show the title.

[approve ci autest]

Cherry-picked to v10.0.x


error rapidjson

hello , i'm facing an error i don't understand
=> `
utils/../../include/rapidjson/document.h:1038:29: error: call of overloaded 'GenericValue(long unsigned int&)' is ambiguous
GenericValue v(value);
^
utils/../../include/rapidjson/document.h:536:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(double) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
explicit GenericValue(double d) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberDoubleFlag) { data_.n.d = d; }
utils/../../include/rapidjson/document.h:525:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(uint64_t) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>; uint64_t = long long unsigned int]
explicit GenericValue(uint64_t u64) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberUint64Flag) {
^
utils/../../include/rapidjson/document.h:511:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(int64_t) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>; int64_t = long long int]
explicit GenericValue(int64_t i64) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberInt64Flag) {
^
utils/../../include/rapidjson/document.h:504:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(unsigned int) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
explicit GenericValue(unsigned u) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberUintFlag) {
^
utils/../../include/rapidjson/document.h:497:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(int) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
explicit GenericValue(int i) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberIntFlag) {
^
utils/../../include/rapidjson/document.h:447:5: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(const rapidjson::GenericValue<Encoding, Allocator>&) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
GenericValue(const GenericValue& rhs);
^
utils/../../include/rapidjson/document.h:440:5: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(rapidjson::GenericValue<Encoding, Allocator>&&) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
GenericValue(GenericValue&& rhs) RAPIDJSON_NOEXCEPT : data_(rhs.data_), flags_(rhs.flags_) {
^
make: *** [utils/logger.o] Error 1
`
sounds like he's looking for a value but don't know which one take

Can you spot in the compilation trace the file/line in the code base that is responsible for the call?

Hi,
Apparently, it is the first line of the compilation trace :
utils/../../include/rapidjson/document.h:1038:29:
GenericValue v(value);
Best regards,
Julien Boulay

Two questions:

I expect you get the same error when compiling from master or develop?
what version of gcc are you using?

Seems like rapidjson is unhappy with an unsigned long parameter for AddMember. I guess this happens when the computing times are logged (https://github.com/jcoupey/vroom/blob/master/src/utils/logger.cpp#L41-L49).
As I can't reproduce this issue on my machine, please try to replace unsigned long with unsigned in https://github.com/jcoupey/vroom/blob/master/src/structures/typedefs.h#L26-L29. Let me know if you are able to compile then.

I'm facing exactly the same error in develop mode and in master
switching unsigned long to unsigned doesn't change anything
i'm using g++ -std=c++14
here the error i still face ( quit thiner than the first one)
//
//
utils/logger.cpp:48:74: required from here
utils/../../include/rapidjson/document.h:1038:29: error: call of overloaded 'GenericValue(long unsigned int&)' is ambiguous
GenericValue v(value);
^
utils/../../include/rapidjson/document.h:536:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(double) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
explicit GenericValue(double d) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberDoubleFlag) { data_.n.d = d; }
^
utils/../../include/rapidjson/document.h:525:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(uint64_t) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>; uint64_t = long long unsigned int]
explicit GenericValue(uint64_t u64) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberUint64Flag) {
^
utils/../../include/rapidjson/document.h:511:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(int64_t) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>; int64_t = long long int]
explicit GenericValue(int64_t i64) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberInt64Flag) {
^
utils/../../include/rapidjson/document.h:504:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(unsigned int) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
explicit GenericValue(unsigned u) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberUintFlag) {
^
utils/../../include/rapidjson/document.h:497:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(int) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
explicit GenericValue(int i) RAPIDJSON_NOEXCEPT : data_(), flags_(kNumberIntFlag) {
^
utils/../../include/rapidjson/document.h:447:5: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(const rapidjson::GenericValue<Encoding, Allocator>&) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
GenericValue(const GenericValue& rhs);
^
utils/../../include/rapidjson/document.h:440:5: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(rapidjson::GenericValue<Encoding, Allocator>&&) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
GenericValue(GenericValue&& rhs) RAPIDJSON_NOEXCEPT : data_(rhs.data_), flags_(rhs.flags_) {
//
//
thanks you very much
Best regards
Julien Boulay
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Coupey"<EMAIL_ADDRESS>À: "jcoupey/vroom"<EMAIL_ADDRESS>Cc: "namtrac"<EMAIL_ADDRESS>Envoyé: Mercredi 23 Mars 2016 12:29:49
Objet: Re: [vroom] error rapidjson (#31)
Two questions:
* I expect you get the same error when compiling from master or develop ?
* what version of gcc are you using?

Seems like rapidjson is unhappy with an unsigned long parameter for AddMember . I guess this happens when the computing times are logged ( https://github.com/jcoupey/vroom/blob/master/src/utils/logger.cpp#L41-L49 ).
As I can't reproduce this issue on my machine, please try to replace unsigned long with unsigned in https://github.com/jcoupey/vroom/blob/master/src/structures/typedefs.h#L26-L29 . Let me know if you are able to compile then.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

The utils/logger.cpp:48 file/line given in the compiler error points to a remaining unsigned long. What if you switch this one to unsigned too at https://github.com/jcoupey/vroom/blob/master/src/utils/logger.cpp#L22?

i'm using g++ -std=c++14

I meant the compiler version, given in the output of g++ -v. I'd like to know because I can't see why I'm not having the same error, apart from different compilers/versions having different representations for some types.

my compiler version is gcc version 5.3.1 20160307 (Debian 5.3.1-11)
i deleted the "long " and now, different error in vroom-develop
//
//
g++ -std=c++14 -Wpedantic -Wall -O3 -DBOOST_LOG_DYN_LINK -c utils/logger.cpp -o utils/logger.o
g++ -std=c++14 -Wpedantic -Wall -O3 -DBOOST_LOG_DYN_LINK -o ../bin/vroom main.o heuristics/christo_heuristic.o heuristics/heuristic.o heuristics/local_search.o heuristics/mst_heuristic.o heuristics/tsp_strategy.o structures/tsp.o utils/exceptions.o utils/logger.o -lboost_system -lboost_regex -lboost_log -lboost_log_setup -lpthread -lboost_thread
/usr/bin/ld: cannot open output file ../bin/vroom: No such file or directory
collect2: error: ld returned 1 exit status
make: *** [../bin/vroom] Error 1
//
//
but same error in vroom-master
//
//
utils/../../include/rapidjson/document.h:1038:29: error: call of overloaded 'GenericValue(long unsigned int&)' is ambiguous
GenericValue v(value);
^
utils/../../include/rapidjson/document.h:536:14: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(double) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
...
...
...
utils/../../include/rapidjson/document.h:440:5: note: candidate: rapidjson::GenericValue<Encoding, Allocator>::GenericValue(rapidjson::GenericValue<Encoding, Allocator>&&) [with Encoding = rapidjson::UTF8<>; Allocator = rapidjson::MemoryPoolAllocator<>]
GenericValue(GenericValue&& rhs) RAPIDJSON_NOEXCEPT : data_(rhs.data_), flags_(rhs.flags_) {
//
//
Thank you
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Boulay"<EMAIL_ADDRESS>À<EMAIL_ADDRESS>Envoyé: Mercredi 23 Mars 2016 15:56:32
Objet: Fwd: [vroom] error rapidjson (#31)
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Coupey"<EMAIL_ADDRESS>À: "jcoupey/vroom"<EMAIL_ADDRESS>Cc: "namtrac"<EMAIL_ADDRESS>Envoyé: Mercredi 23 Mars 2016 15:52:35
Objet: Re: [vroom] error rapidjson (#31)
The utils/logger.cpp:48 file/line given in the compiler error points to a remaining unsigned long . What if you switch this one to unsigned too at https://github.com/jcoupey/vroom/blob/master/src/utils/logger.cpp#L22 ?
i'm using g++ -std=c++14
I meant the compiler version, given in the output of g++ -v . I'd like to know because I can't see why I'm not having the same error, apart from different compilers/versions having different representations for some types.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

/usr/bin/ld: cannot open output file ../bin/vroom: No such file or directory

Did you create the bin folder as described in https://github.com/jcoupey/vroom/wiki/Building?

but same error in vroom-master

From the error being the same as before (about long unsigned), I suspect your last modification only affected the code from the develop branch. You might need to apply the same modification after checking out the master branch.

i didn't created the bin folder
but i applyed the same modification before trying the "make " on master branche
thank you
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Coupey"<EMAIL_ADDRESS>À: "jcoupey/vroom"<EMAIL_ADDRESS>Cc: "namtrac"<EMAIL_ADDRESS>Envoyé: Mercredi 23 Mars 2016 17:10:53
Objet: Re: [vroom] error rapidjson (#31)
Did you create the bin folder as described in https://github.com/jcoupey/vroom/wiki/Building ?
From the error being the same as before (about long unsigned ), I suspect your last modification only affected the code from the develop branch. You might need to apply the same modification after checking out the master branch.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Nothing has changed on develop since the last merge to master so you'll currently get the same behaviour whatever the branch you manage to build the executable from.
Can you build successfully now with an existing bin folder?

hi,
Yes i can build successfully now, had a prob of library with boost but it's solved.
Thanks you very much for help
Julien Boulay
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Coupey"<EMAIL_ADDRESS>À: "jcoupey/vroom"<EMAIL_ADDRESS>Cc: "namtrac"<EMAIL_ADDRESS>Envoyé: Mercredi 23 Mars 2016 18:16:10
Objet: Re: [vroom] error rapidjson (#31)
Nothing has changed on develop since the last merge to master so you'll currently get the same behaviour whatever the branch you manage to build the executable from.
Can you build successfully now with an existing bin folder?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Nice. I'm glad it worked for you in the end!

@namtrac I hope the commit referenced above solves the issue you encountered. Could you update your develop branch to this commit to check if you are able to compile without any modification to the code?

it does solved the issues i encountered,
i tryed ton compile without any modifications but it did not worked with unsigned long , i'm working on running it actually
thanks for your help
Julien Boulay
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Coupey"<EMAIL_ADDRESS>À: "jcoupey/vroom"<EMAIL_ADDRESS>Cc: "namtrac"<EMAIL_ADDRESS>Envoyé: Jeudi 24 Mars 2016 13:45:38
Objet: Re: [vroom] error rapidjson (#31)
@namtrac I hope the commit referenced above solves the issue you encountered. Could you update your develop branch to this commit to check if you are able to compile without any modification to the code?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

I mean without any modification but after checking out at https://github.com/jcoupey/vroom/commit/60881f6c6b1de0c1a2789a39aa4455cdb7cea659 (last commit currently on develop branch, added today). No more unsigned long then, I wonder if you are able to get this version to compile without modification?

Hi
I'm able to compile without any modification with the last commit with the duration_t ints
thanks again for the help
best regards
Julien Boulay
Julien BOULAY
+33 4 78 48 23 17
----- Mail original -----
De: "Julien Coupey"<EMAIL_ADDRESS>À: "jcoupey/vroom"<EMAIL_ADDRESS>Cc: "namtrac"<EMAIL_ADDRESS>Envoyé: Jeudi 24 Mars 2016 18:54:59
Objet: Re: [vroom] error rapidjson (#31)
I mean without any modification but after checking out at 60881f6 (last commit currently on develop branch, added today). No more unsigned long then, I wonder if you are able to get this version to compile without modification?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Good, thanks for reporting!


Implement CorsFilter

A filter is needed to set the "Access-Control-Allow-Origin", "*" header on the response.

done


"Pause chat when hovering" option fix has created some problems

if the option is selected the chat will keep scrolling even if the user has scrolled up to look at a message (while the right behaviour is still found if the option is not selected)
if the option is not selected and the user, after scrolling up, selects some text, it will happen that the chat will move up and down while correctly highlighting the text

Thanks a lot for the amazing software.

https://github.com/fourtf/chatterino2/commit/6416bf39275b4da522d9af622753ed697c5daad4


linux: added support for frames with info

Instead of defaulting to frames with no packet information, I added a flag that lets the user decide.

github shows that vxcute, made the request which is an old account, and I had the email and username set in my global config.


Heavy message traffic leads to "Oh no! Something went wrong. Try Again?"

When a user is looking at a stream/topic and a lot of messages are being posted to that stream or topic, the red "Oh no! Something went wrong! Try again?" banner will briefly appear, despite all the messages updated and no connection issues occurring.
This seems related to the "New Messages" banner, as users don't seem to be able to self activate the error- it only occurs when someone else is sending messages.
Tested by typing gibberish and hitting return a bunch.

Observed on:

Google Pixel 3 XL - Android 9 - Build number: PQ3A.190605.003
iPhone Xs, OS version 12.3.1

Latest Zulip app as of this message, Zulip server is 2.0.3
This issue was only seen on mobile- desktop users do not see the banner or have any connection issues.

Thanks @swallitsch for the report!
The next step for someone to debug this is to reproduce it, and look at the app's error log, e.g. with adb logcat. That will have more detail on the error.
If reproducing in a debug build of the app, the banner will also be longer and have more detail on the error.
We also log these errors to Sentry. Looking, here's one that looks like a match -- the relevant bit of JSON blob is
{"message":"Uncaught SyntaxError: Failed to execute 'querySelectorAll' on 'Document': The provided selector is empty.",
"line":436,"column":49,
"error":{
"stack":"Error: Failed to execute 'querySelectorAll' on 'Document': The provided selector is empty.\n    at Object.handleUpdateEventMessagesRead [as read] ...",

That should be a solid lead for debugging.

Some detailed debugging by @jainkuniya in the duplicate issue #3544 .


Update vpn-gateway-vpn-faq.md

Updated "Can I get my VPN gateway IP address before I create it?" and "Can I request a Static Public IP address for my VPN gateway?" to factor in the AZ VPN gateway SKUs that relay on standard SKU public IPs which are static.  The proposed changes are a more complete answer.

#sigh-off


Confirm to access registration

TL;DR Is it possible to create a confirm-to-register type of new user flow using Authboss?
To elaborate slightly, what we're looking to do is:

Collect email address
Generate single-use confirmation token to deliver to email collected in step 1.
Collect more information post-confirmation
Create new user account

I'm new to both Golang and Authboss and couldn't immediately figure out how to accomplish this without implementing it ourselves. If we indeed need to implement this ourselves, as Authboss already has facilities for generating Confirmation tokens and sending email, can we hook into those somehow?

This is possible by stealing most of confirms code. You can reuse its interface (ConfirmableUser) and it's generate token function. But you would have to create a new module for the flow that you want I think. Most of what would be shared is exported AFAIK.

@aarondl thanks. I'll have a stab at it and if something (elegant and working) comes out of it, I'll definitely consider contributing back :-)

@aarondl I managed to achieve what we wanted, but the implementation is not ideal.
In the end I went with

Copy most of confirm into a new module
Fork register so that I can uncomment the router bindings
Bind the routes for register in the new confirm2register module, augmenting the Get and Post handlers in register

This led me to thinking that the autosetup is perhaps not ideal and the approach used in the 2FA modules, requiring an explicit call to module.Setup() enables greater flexibility.
I get that Authboss is supposed to be very plug&play-ish, but I think there are good arguments for not having side-effects from simply importing a package, such as the call to authboss.RegisterModule() in the init in most Authboss modules.
For instance I think I wouldn't have had to duplicate nearly as much code as I now did, if I could've simply composed my new confirm2register by augmenting the handlers in confirm and register.
I'm rambling a bit, but there's some food for thought in there. I could definitely pull together a PR better showcasing what I mean, if there is interest.

I absolutely agree that the side effect imports are a mistake hence the new modules not doing that. Unfortunately it's now a breaking change to change it :( Probably should have done it in v2, now we've got to wait until v3.

Good to hear that you agree. Is there a roadmap for Authboss or is it simply as needs arise or community contributions?
I could definitely be interested in working on this, but wouldn't want to waste work if there is already a plan and work in progress happening elsewhere.

There's no roadmap at the moment. I consider authboss "complete" for what it's supposed to offer. The dev branch has a few things I'll eventually push out is all.
Revving major versions and introducing breaking changes like that frequently is a bit more problematic than in other languages because go get so I like to move a bit slower on that front. But I do encourage vendoring etc. :\ Tough call.

I was going to come here with my great innovation of providing a flag to authboss.Init which prevents automatic invoking of module.Init, but then I read the source code and noticed authboss.Init can already take a list of modules to initialise, which is perfectly sufficient.
Thanks for chatting and the help, and thanks for Authboss!


Picture transparency not retained

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Post a picture/sticker in Telegram. The transparent background in a connected Slack channel has become grey.
Expected behavior
Transparency should be retained.
Screenshots/debug logs
see screenshots
Environment (please complete the following information):

OS: Mac
Matterbridge version: 1.15.1

Slack:

Telegram:

Can you try dev build https://bintray.com/42wim/nightly/Matterbridge/v1.15.1-9-g9200eb0#files and let me know if this fixes it?

@MrBuddyCasino can you test it?

Sorry traveling rn, will take some time until I‘m back home.

Closing because no feedback


RFC (pdk): standardized tracing api and core instrumentation

Summary
Currently, Kong has no tracing instrumentation in its core code. kong-plugin-zipkin exists, and is useful for getting a general sense of the timing of the different Nginx phases, but I'm seeing some unexplained latency that the plugin is not capturing.
I believe it would be hugely beneficial if Kong core took a lead in standardizing a tracing API within the PDK which could then be extended/implemented in plugins like the existing Zipkin one, or perhaps, a future OpenTelemetry plugin.
With a standardized API, Kong core could be instrumented in a concrete and fine-grained way. The API could be written in a way that the default implementation in core is a no-op, and only when a tracing plugin is enabled would the PDK tracing functions actually do anything.
This is mostly just a brain-dump of my thoughts at the moment. I'm happy to discuss further if there is interest in the idea. Thanks!

https://github.com/opentracing-contrib/nginx-opentracing

+1
There have been talks about doing the same with metrics in the PDK, where different implementations such as Prometheus, Datadog, statsD can pull metrics from the core.
Log serialization(f3653f8ff) recently made it's way into core.
Is this something you would be willing to contribute?

+1 to further enhanced tracing and latency explanations with core Kong. I have always thought a glaring feature missing is information on how long DB queries were taking on a given tx to help explain if the hits being seen were from lua code execution, nginx, or just waiting for db's to respond to given queries.

+1

+1

@vito-laurenza-zocdoc did you make it works https://github.com/opentracing-contrib/nginx-opentracing in Kong ?

@vito-laurenza-zocdoc did you make it works https://github.com/opentracing-contrib/nginx-opentracing in Kong ?

No, I haven't had time to work on this.

+1!!!


bundler: 2.3.20 -> 2.3.21

Description of changes

Upgrade bundler from 2.3.20 to 2.3.21
Add passthru.updateScript to automatically update bundler
Add missing meta information
Add anthonyroussel to maintainers

There is no maintainers on this package
I use bundler really often, so I propose to add myself as a maintainer of the package

See release notes: https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md#2321-august-24-2022
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

As labeled by OfBorg, this was a huge rebuild, so I reverted it and moved to staging branch.


Incorrect integer values due to float64 conversion

Due to the float64(val) conversion at https://github.com/sijms/go-ora/blob/master/v2/utils.go#L591, int64 values can get "corrupted".
Demo at https://gist.github.com/robstradling/363b54e979b879e0450cfa36e238cca6
Interestingly, if I remove the int64 case at https://github.com/sijms/go-ora/blob/master/v2/utils.go#L590, my sql.NullInt64 test case then works correctly, presumably because the sql.Scanner stuff in the default case doesn't do a floating point conversion.

I will use new type Number to hold or number variety and solve these issues

Please fix this quickly

I add changes in last commit
would you please test and give me feedback

Thanks @sijms.  Commit https://github.com/sijms/go-ora/commit/b04862ca3078dc46907e4e8a566507bd505af880 fixes my demo and looks good to me.  Time for a v2.8.10 release?


Correct varying varchar

Changes
Correct varying varchar
Checklist

[X] have tested my change
[ ] updated relevant documentation
[X] Remove any/all console.logs I added
[ ] eslint is not complaining
[ ] have added myself to the contributors' list in the README
[ ] for feature PRs: PR only includes one feature enhancement.

But digits was a String and the value is casting into a number.
In this exemple, we can see that the length in getPrettyType is 0 while the length was 52

With the modification

@sebCIL Ok, I have found a bug in vscode-ibmi. I need to make a fix and release before we can merge this.
With SQL disabled, these are strings. With SQL enabled, these are numbers. They should always be numbers.
			WHFLDB: strLength,
			WHFLDD: digits,

@sebCIL<EMAIL_ADDRESS>has just been released. Update the extension, debug again and you should always see numbers this time.
It returning a string was a bug, and I have now fixed that.

Waouh ! That's the definition of reactivity ! Thanks. :clap:
It look good. I remove the it.

@sebCIL Awesome fixes. Thank you!


Reset RemovedFromBrokerCatalog when broker re-adds a removed service class

fixes #1757
Reconciliation loop was not resetting the RemovedFromBrokerCatalog status when the broker re-adds a previously delisted Cluster Service Class.  Fixed and added unit test.

@jboyd01 can you fix the import ordering, and merge after?


Search inspector filter

This adds UI to search within just one IG. I'm not :100:% on how this looks, would welcome better ideas. Screenshots included for convenience. (See also #24)

Works like a charm. :+1:


New tab should open after pinned tabs

If opening a tab from a pinned tab, it is inserted next to the current pinned tab.  It would be nice if it would open the new tab adjacent to the last pinned tab, or perhaps add a toggle to skip pinned tabs when inserting.

yes, this extension is great but it should open the new tab after the pinned.


Error: no goals found for contract quantum-camp-2023

There is a bug regarding to current contract looks like. I can't use any of the apps.  I think we need to add it contracts.json?

The same thing happened to me, and is now happening again with another contract

I Got the same issue for record-heat-2023

now that I finished record-heat-2023 I get an error for a-new-grade.
It might just be a coincidence, but the base64 strings for proto are not being colored from a-new-grade and down. I tried to use an online json validator and it says there are no problems though.

There is a bug regarding to current contract looks like. I can't use any of the apps. I think we need to add it contracts.json?

I'm having the same issue with a different contract

Thank you


feat!: convert Gapic client to TypeScript

Converting the auto-generated parts of the library to TypeScript using the new https://github.com/googleapis/gapic-generator-typescript.

The system tests should pass once https://github.com/googleapis/gapic-generator-typescript/pull/173 is merged and released.

I'm guessing we first need to update synth.py to make changes for your latest fixes, then run the generator again.

Re-ran synthool and pushed changes. The only remaining blockers (in my opinion) are the setting for initial_rpc_timeout_millis and max_rpc_timeout_millis. Should we drop them?

Updated all the dependencies since the CI requires a newer version of gts than in package.json and the generated clients require a newer version of Google Gax (for gax.OperationsClient).

Dropping of initial_rpc_timeout_millis and others will be done in gax (the exported type requires those unused parameters to be set). I will first remove them from there, then from the generator. All generated libraries will be updated within the nightly synthtool run.
I think we are good to go here! I suggest we treat this PR as a breaking change just in case (feel free to merge the PR then), otherwise, if you think it's just a minor, remove ! from the PR title before merging :)  It's up to you.

https://github.com/googleapis/gapic-generator-typescript/pull/175 will reset the parameters to 60000. We can merge now (this change will come within a nightly synthtool run) or wait for this change to make its way into the Docker image (will happen on Monday).

This PR is linked in the v3.0.0 release notes as a breaking change. Is there something we need to alter to comply with this change? The only thing I could imagine this affecting is the typings of some exposed objects. In v2.X we imported a few specific types with
import { GeoPoint, FieldValue, Timestamp, DocumentReference } from '@google-cloud/firestore'

but that shouldn't have to change in v3, correct?

We bumped the major version because of the risk with this PR. We are not aware of any specific breakages.


Adjust replay-related metrics for unified scheduler

Problem
Some fields of replay-related metrics are broken if the unified scheduler is enabled with --block-verification-method unified-scheduler
Summary of Changes
Adjust/Deprecate metrics fields like below only if unified scheduler is enabled:

Field name
Change

replay-slot-stats.total_batches_len
Removed

replay-slot-stats.num_execute_batches
Removed

replay-slot-stats.execute_batches_us
Removed

replay-slot-stats.replay_time
Renamed to .task_submission_us along with change of definition

replay-slot-stats.confirmation_time_us
Renamed to .confirmation_without_replay_us along with change of definition

replay-slot-end-to-end-stat.total_batches_len
Removed

replay-slot-end-to-end-stat.num_execute_batches
Removed

replay-slot-end-to-end-stat.total_thread_us
Removed

replay-slot-end-to-end-stat.total_transactions_executed
Removed

note that these metrics changes are inevitable because of the complete switch of the replay implemention (blockstore_processor => unified_scheduler)
samples
replay-slot-stats
before (--block-verification-method unified-scheduler is used to show zeroed or hard-coded 1 values for removed fields):

[2024-06-12T07:33:37.293875680Z INFO  solana_metrics::metrics] datapoint: replay-slot-stats slot=271362801i fetch_entries_time=4334i fetch_entries_fail_time=0i entry_poh_verification_time=57479i entry_transaction_verification_time=14134i confirmation_time_us=79201i replay_time=6921i execute_batches_us=0i replay_total_elapsed=347424i bank_complete_time_us=6074i total_transactions=1063i total_entries=191i total_shreds=440i validate_transactions_us=4813i program_cache_us=12671i load_us=10681i execute_us=443589i collect_logs_us=0i store_us=33453i update_stakes_cache_us=22897i total_batches_len=0i num_execute_batches=1i update_transaction_statuses=6216i execute_details_serialize_us=33597i execute_details_create_vm_us=26055i execute_details_execute_inner_us=312620i execute_details_deserialize_us=9644i execute_details_get_or_create_executor_us=6i execute_details_changed_account_count=1518i execute_details_total_account_count=4960i execute_details_create_executor_register_syscalls_us=0i execute_details_create_executor_load_elf_us=0i execute_details_create_executor_verify_code_us=0i execute_details_create_executor_jit_compile_us=0i execute_accessories_feature_set_clone_us=0i execute_accessories_compute_budget_process_transaction_us=13i execute_accessories_get_executors_us=0i execute_accessories_process_message_us=438390i execute_accessories_update_executors_us=1i execute_accessories_process_instructions_total_us=436692i execute_accessories_process_instructions_verify_caller_us=0i execute_accessories_process_instructions_process_executable_chain_us=434847i execute_accessories_process_instructions_verify_callee_us=0i

after (--block-verification-method unified-scheduler):

[2024-06-14T14:02:55.538896068Z INFO  solana_metrics::metrics] datapoint: replay-slot-stats slot=277128148i fetch_entries_time=8500i fetch_entries_fail_time=0i entry_poh_verification_time=72352i entry_transaction_verification_time=19670i confirmation_without_replay_us=103454i task_submission_us=10446i replay_total_elapsed=653197i bank_complete_time_us=5681i total_transactions=3001i total_entries=401i total_shreds=1104i validate_transactions_us=18893i program_cache_us=28480i load_us=13967i execute_us=138400i collect_logs_us=2i store_us=63256i update_stakes_cache_us=42290i update_transaction_statuses=25890i execute_details_serialize_us=1233i execute_details_create_vm_us=4522i execute_details_execute_inner_us=10559i execute_details_deserialize_us=241i execute_details_get_or_create_executor_us=0i execute_details_changed_account_count=3259i execute_details_total_account_count=9701i execute_details_create_executor_register_syscalls_us=0i execute_details_create_executor_load_elf_us=0i execute_details_create_executor_verify_code_us=0i execute_details_create_executor_jit_compile_us=0i execute_accessories_feature_set_clone_us=0i execute_accessories_compute_budget_process_transaction_us=1i execute_accessories_get_executors_us=0i execute_accessories_process_message_us=127215i execute_accessories_update_executors_us=17i execute_accessories_process_instructions_total_us=124058i execute_accessories_process_instructions_verify_caller_us=0i execute_accessories_process_instructions_process_executable_chain_us=120445i execute_accessories_process_instructions_verify_callee_us=0i

after (--block-verification-method blockstore-processor):

[2024-06-17T03:56:04.583243563Z INFO  solana_metrics::metrics] datapoint: replay-slot-stats slot=277645538i fetch_entries_time=8533i fetch_entries_fail_time=0i entry_poh_verification_time=41414i entry_transaction_verification_time=18600i confirmation_time_us=90988i replay_time=29885i execute_batches_us=23261i replay_total_elapsed=305064i bank_complete_time_us=3483i total_transactions=2861i total_entries=141i total_shreds=1024i validate_transactions_us=2469i program_cache_us=22923i load_us=18463i execute_us=107858i collect_logs_us=1i store_us=106104i update_stakes_cache_us=86908i total_batches_len=238i num_execute_batches=11i update_transaction_statuses=30730i execute_details_serialize_us=56i execute_details_create_vm_us=361i execute_details_execute_inner_us=770i execute_details_deserialize_us=11i execute_details_get_or_create_executor_us=0i execute_details_changed_account_count=2872i execute_details_total_account_count=9027i execute_details_create_executor_register_syscalls_us=0i execute_details_create_executor_load_elf_us=0i execute_details_create_executor_verify_code_us=0i execute_details_create_executor_jit_compile_us=0i execute_accessories_feature_set_clone_us=0i execute_accessories_compute_budget_process_transaction_us=16i execute_accessories_get_executors_us=0i execute_accessories_process_message_us=96486i execute_accessories_update_executors_us=0i execute_accessories_process_instructions_total_us=95125i execute_accessories_process_instructions_verify_caller_us=0i execute_accessories_process_instructions_process_executable_chain_us=92576i execute_accessories_process_instructions_verify_callee_us=0i

replay-slot-end-to-end-stats
before (--block-verification-method unified-scheduler is used to show zeroed or hard-coded 1 values for removed fields):

[2024-06-12T07:30:11.518197708Z INFO  solana_metrics::metrics] datapoint: replay-slot-end-to-end-stats slot=271362338i total_thread_us=0i total_transactions_executed=0i validate_transactions_us=2747i program_cache_us=17670i load_us=18271i execute_us=681804i collect_logs_us=21i store_us=26436i update_stakes_cache_us=15400i total_batches_len=0i num_execute_batches=1i update_transaction_statuses=8456i execute_details_serialize_us=99045i execute_details_create_vm_us=83649i execute_details_execute_inner_us=399716i execute_details_deserialize_us=11800i execute_details_get_or_create_executor_us=41i execute_details_changed_account_count=3085i execute_details_total_account_count=10296i execute_details_create_executor_register_syscalls_us=0i execute_details_create_executor_load_elf_us=0i execute_details_create_executor_verify_code_us=0i execute_details_create_executor_jit_compile_us=0i execute_accessories_feature_set_clone_us=0i execute_accessories_compute_budget_process_transaction_us=20i execute_accessories_get_executors_us=0i execute_accessories_process_message_us=674855i execute_accessories_update_executors_us=0i execute_accessories_process_instructions_total_us=672092i execute_accessories_process_instructions_verify_caller_us=0i execute_accessories_process_instructions_process_executable_chain_us=669463i execute_accessories_process_instructions_verify_callee_us=0i

after (--block-verification-method unified-scheduler):

[2024-06-14T14:02:55.538916657Z INFO  solana_metrics::metrics] datapoint: replay-slot-end-to-end-stats slot=277128148i validate_transactions_us=18893i program_cache_us=28480i load_us=13967i execute_us=138400i collect_logs_us=2i store_us=63256i update_stakes_cache_us=42290i update_transaction_statuses=25890i execute_details_serialize_us=1233i execute_details_create_vm_us=4522i execute_details_execute_inner_us=10559i execute_details_deserialize_us=241i execute_details_get_or_create_executor_us=0i execute_details_changed_account_count=3259i execute_details_total_account_count=9701i execute_details_create_executor_register_syscalls_us=0i execute_details_create_executor_load_elf_us=0i execute_details_create_executor_verify_code_us=0i execute_details_create_executor_jit_compile_us=0i execute_accessories_feature_set_clone_us=0i execute_accessories_compute_budget_process_transaction_us=1i execute_accessories_get_executors_us=0i execute_accessories_process_message_us=127215i execute_accessories_update_executors_us=17i execute_accessories_process_instructions_total_us=124058i execute_accessories_process_instructions_verify_caller_us=0i execute_accessories_process_instructions_process_executable_chain_us=120445i execute_accessories_process_instructions_verify_callee_us=0i

after (--block-verification-method blockstore-processor):

[2024-06-17T03:56:04.583279050Z INFO  solana_metrics::metrics] datapoint: replay-slot-end-to-end-stats slot=277645538i total_thread_us=20702i total_transactions_executed=126i validate_transactions_us=272i program_cache_us=973i load_us=886i execute_us=6340i collect_logs_us=0i store_us=5700i update_stakes_cache_us=4761i total_batches_len=1i num_execute_batches=11i update_transaction_statuses=3177i execute_details_serialize_us=56i execute_details_create_vm_us=361i execute_details_execute_inner_us=770i execute_details_deserialize_us=11i execute_details_get_or_create_executor_us=0i execute_details_changed_account_count=137i execute_details_total_account_count=419i execute_details_create_executor_register_syscalls_us=0i execute_details_create_executor_load_elf_us=0i execute_details_create_executor_verify_code_us=0i execute_details_create_executor_jit_compile_us=0i execute_accessories_feature_set_clone_us=0i execute_accessories_compute_budget_process_transaction_us=0i execute_accessories_get_executors_us=0i execute_accessories_process_message_us=5832i execute_accessories_update_executors_us=0i execute_accessories_process_instructions_total_us=5753i execute_accessories_process_instructions_verify_caller_us=0i execute_accessories_process_instructions_process_executable_chain_us=5637i execute_accessories_process_instructions_verify_callee_us=0i

well, i noticed that solana-metrics supports Option<_>.. cool. will rework...

well, i noticed that solana-metrics supports Option<_>.. cool. will rework...

this is now done.

But I am confused about a few:
* `replay-slot-end-to-end-stat.total_transactions_executed`

* `replay-slot-end-to-end-stat.total_thread_us`

well, these metrics are broken to be begin with.. these should be handled correctly here at https://github.com/anza-xyz/agave/pull/1741/files#r1643602132

I know we're collecting the execution time per tx, so I'm wondering where those are now reported if not here.

with the above thing said, when unified scheduler is enabled, there's no perfect equivalent for total_thread_us. However, I think most of metrics coverage is adequate just with ExecuteTimings, which are reported by replay-slot-stats and replay-slot-end-to-end-stat. note that replay-slot-stats.replay_total_elapsed is still intact.
That said, I can restore total_thread_us by adding another field to ExecuteTimings in this pr or as a follow-up pr.
Note that total_transactions_executed is redundant with replay-slot-stats.total_transactions.

@apfitzge Well well well. I misread the code. T_T

well, these metrics are broken to be begin with.. these should be handled correctly here at https://github.com/anza-xyz/agave/pull/1741/files#r1643602132

So, this statement is wrong. Seems, replay-slot-end-to-end-stats isn't broken as it is, after another careful code read and reviewing the original pr (https://github.com/solana-labs/solana/pull/25752).
I put rather verbose words in this commit for its definition. And more importantly, I disabled the metrics for unified scheduler (the justification is written in th ecommit as well): 436e89df24271e9738536a9d6e55fdbb854d96db.
so, with reasons describe above...

That said, I can restore total_thread_us by adding another field to ExecuteTimings in this pr or as a follow-up pr.

I rather not to restore total_thread_us at this point. I'll later update the pr description, if you think the direction is okay.

ci is failing due to unrelated cargo audit failures...

ci is failing due to unrelated cargo audit failures...

this is fixed by and this pr got rebased on it: #1786

as a tip, you can only display metrics from nodes which enabled unified scheduler or blockstore processor like this:


Feature: Realtime updates of glosario's yml glossary

Currently this project fetches a copy of carpentries/glosario's glossary.yml every day and includes it within this repo via a GitHub Action. One issue with this is after installation of glosario-py, the glossary.yml file is never updated again.
Instead, we could add code that calculates a hash of carpentries/glosario glossary.yml and the local copy, upon start up/import. If there is a difference we download the updated copy. If write permissions for downloading the update are a problem, we can cache the updated YAML file in memory and get the library to use that instead of what's on disk.

There definitely needs to be a way to update the glossary.yml; when installed via pip, the version downloaded is not even the current version from this repository.
A manually triggered update would be a good start, but ideally one that does not require the user to navigate their install paths. Eg, I'd like to use glosario while teaching with participatory live coding.  It would be okay to have learners run a command that re-downloads and updates the file, but not that they navigate all of their (very different) installs.

Sure, I'd love to help. What do you think of my proposal? The YAML file would be updated on each user's machine each time glosario is imported. I was under the impression that we could get the hash of any file from a repository by asking git - that way it wouldn't need to be downloaded each time-, but now I'm not so sure, I'll have to dig a bit deeper. Optionally the carpentries/glosario repository could also store the hash of the YAML file. But given that a hash cannot be attained to verify whether an update is required, the YAML file is small enough to be downloaded anew on every import: at 214KB that's realistically like importing a minified jQuery twice.