Cocoapods distribution?

I've read in README.md that You would rather like to use SPM, even though It would take a while until It would be supported.
If someone would make Pull Request that would allow to distribute Your magnificent Library through Cocoapods, would You re-consider using NeuralNet with Cocoapods?

+1

I've made one btw to do just this

resolved in #10


MM-29040 Switch center-channel-color-## to -rgb variables

Summary
Remove usage of center-channel-color-## CSS variables from modals
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/15778
JIRA https://mattermost.atlassian.net/browse/MM-29040

Hello @anchepiece,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

/update-branch

Thanks for the contribution @anchepiece :tada:


999 minimum, 0 maximum.  (First week and renovation)

As the title says, I had my renovation on tuesday, and it was on track for a small spike until this morning.  This was my first week buying from my own island.
Possibly the renovation threw everything a bit off, like the first week?  Just my own guess.

Can you please provide all your numbers for the week? Ideally a permalink from the app!
As far as the renovations go... We don't have any hard data that suggests one way or the other whether Nook's upgrade could cause the market to shuffle. It's not outside the realm of possibility though.

I've also run into the same issue. Here is my permalink: https://turnipprophet.io?prices=<IP_ADDRESS>.179.316.107.134.....&pattern=3

@anch56 can you please report that under a new issue? Prediction issues typically need to be investigated individually.

Unfortunately, I can't find my way back to the version of the page that has the exact prices.  I closed the tabs after it broke and I sold my turnips at a friends.  I did take a screenshot to share with my friends, though, so hopefully that can help in addition to what I remember exactly.
https://cdn.discordapp.com/attachments/246343041399390219/702901883743764501/unknown.png
What I do remember: sunday was 106, monday AM was 80, PM was slightly lower.  Tuesday was the renovation.  Wednesday AM was about 110 (sorry, it's on the screenshot though) PM was 161.  Thursday AM (the one that broke the prophet), 150, PM 52.

I'm sorry, the code can be quite sensitive to precise numbers (as it's built following the mined information, and we can filter things out based on whether the number was in one small range or another. Without those, we're not going to be able to investigate this further
I hope you still find the tool useful, and you make lots of bells each week. :)


Index() with parameters

fixes https://github.com/fusetools/fuselibs-public/issues/205
This PR contains:

[-] Changelog: no change to released API yet
[x] Documentation
[x] Tests

Source\Fuse.Reactive.Expressions\VarArgFunction.uno(45.32): E3104: Uno.Collections.IList<Fuse.Reactive.Expression> does not contain a member called 'Length'. Could you be missing a package reference?


Render only DatePicker or TimePicker

I think there should be an option to display only a TimePicker on the input field without the Date option above for <input type="time" /> elements.
And vice versa for <input type="date" /> elements
I noticed setting dateFormat to false and vice versa does this already, but a ViewMode will be the best implementation

Hi @finetimi. I'm guessing you found the viewMode prop :) I'm just posting it here if someone else wants to know in the future.


STORM-1977 Restore logic: give up leadership when elected as leader but doesn't have one or more topology codes on local (1.x)

PR for master: #1573

Nimbus H/A introduced condition for becoming a leader
It got removed when BlobStore was introduced
This patch is restoring previous logic with making logic compatible to BlobStore

The code to do the leader election based off of the IDs was removed because architecturally the blobstore should be in charge of maintaining high availability.  Exposing what is stored on the local disk in an implementation detail and exposing that to nimbus breaks a lot of things.  Not to mention is not really possible with some blobstore implementations, like the HDFS backed one.
To offset this we made sure that you could access the version of the blob even if it is stored on a different instance of the blobstore.
Additionally the old code did not guarantee consistency either.  There was a timeout where if nimbus waited long enough to get a copy of all of the items it gave up and would still become leader.  If there really is no guarantee why add in the extra overhead?

@revans2
If we can guarantee that leader nimbus has all topologies code, leader nimbus can function well. Old code is based on this assumption, not considering followers and also not about code distribution. It should be eventually distributed since each nimbus runs sync-code / sync-blob periodically to try to sync up.
In leader nimbus' point of view I think old code is consistent, and this code is trying to have same guarantee.

@revans2
And local BlobStore should be designed to achieve hive availability just same as HDFS BlobStore. But the process BlobStore is behind is Nimbus, which is designed to fail-fast, which I think is just not same way.
For example, suppose the scenario what I addressed from STORM-1977.
Tested with the scenario I've described from STORM-1977

comment cleanup-corrupt-topologies! from nimbus.clj (It's a quick workaround for resolving STORM-1976), and patch Storm cluster
Launch Nimbus 1 (leader)
Run topology1
Kill Nimbus 1
Launch Nimbus 2 from different node

Without having condition for granting leadership, Nimbus 2 can grant leadership, and act as leader. This is not a blocker for BlobStore's view, since replication count for topology1 is 0 but it doesn't make them crashed, and reviving Nimbus 1 should eventually replicate topology 1 to Nimbus 2.
The thing is, leader nimbus should do the own work as Nimbus. In this case just requesting getClusterInfo can make Nimbus 2 crashed, and Nimbus 1 comes in later and gain leadership, but replication count for topology1 is still 1 until Nimbus 2 comes in.
With having condition for granting leadership, Nimbus 2 gives up leadership, and continuously waits for new leader. (No leader at that time) And Nimbus 1 comes in, and topology1 is eventually replicated to Nimbus 2 to ensure replication count.
Due to this behavior, the crash and recovery scenario heavily depends on sequence of launching Nimbuses. I think this is not a good UX.

@HeartSaVioR
I am OK with this change, like I am OK with the change for STORM-1976.  I just don't think that this is the final solution for the local blobstore+nimbus, nor do I think that either is a blocker.   The reality is if I use HDFS as the backing for the blobstore and I only set it to have a single replica, then I lose a datanode, nimbus will still crash in almost exactly the same way.  Is this a bug in nimbus?  Is it a bug in the blobstore or HDFS? I would say no. It is user error because the user is trying to make something HA without configuring it properly. Then when an error happens we cannot recover.  So the question is, if it does happen is it better for nimbus to crash or is it better for nimbus to hang?  Because all this does is it switches from one to the other.  I can see advantages for hanging over crashing, so I am OK with this fix.
Does the blobstore code have bugs in it and things that we can change to make it work better? I would expect it to, it is software after all.  I just want us to spend some time thinking about how we really want it to behave and fix it properly.  If that proper fix comes after making a few patches to improve things, that is fine.

+1. Agree on having a discussion around these scenarios in another JIRA.

@revans2
I'm just thinking about the responsibility of Nimbus.

Nimbus was "soft" SPOF and we claimed that Nimbus is designed to fail-fast and stateless so just supervising Nimbus works like a charm. But it doesn't help from machine failure, and moving Nimbus to other machine requires at least configuration change of whole cluster. (This assumes that Supervisor is also supervised by aux. process. If not starting Supervisor should be done manually.)
Nimbus H/A came in. It was relatively easier than other process on other project since Nimbus is designed as stateless so no need to sync. Only thing Nimbuses should sync up is topology code, and Nimbus H/A tried to address this by full replications and restriction of becoming leader. It made some overhead trying to replicate topology codes to all of Nimbuses but it was a best try to achieve higher availability. When other nimbuses crashed but only one 'leader' nimbus was alive, that was completely OK for that moment. There was a chance for all alive nimbuses not having complete set of topology code thus no leader and hang, but it was relatively smaller than counting replication count since it was doing full replication at all.
BlobStore came in. I don't know the details of BlobStore so hard to tell. I'd be happy if you fill out this : After BlobStore.

One thing I'm concerning is, there's new requirement for Nimbus to not easily crashed since every Nimbuses are also replica of BlobStore like DataNode, but Nimbus itself has lots of works to do (sure for leader, and not sure for followers) and it is still based on fail-fast. Is it OK to play together?

@revans2
Let me back to code change. Could you clarify that this change can also work well with HDFS backed BlobStore? If not how to do this?
I'd like to address this as abstraction level of BlobStore by preventing nimbus to gain leadership when there's a topology which one of code is not available (replication count 0), but don't have an idea for how to do. If you feel more convenient to make a patch by yourself, please take over and go ahead.
I think I should have a time to play with BlobStore by local and HDFS backed, but I'm not sure I can do that right now.

@HeartSaVioR the local file system blobstore behaves exactly the same as the nimbus HA before it.  It tries to replicate all of the blobs to all of the nimbus nodes as quickly as possible.  It stores the metadata for each blob in ZK, just like the original nimbus HA code.  The big difference is that it can store a general set of blobs and they are all versioned so you can upload a new one, and if you ask for a blob that is not currently local on that nimbus it will speed up they sync process and go grab it from another nimbus instance for you.
There is still a race, like with nimbus HA where it may not have fully replicated, but if you set the replication count when the blob is uploaded it should be waiting for the replication to complete before declaring success.
The one bug I saw while going through the code is that when we list keys, we are doing it only from the local storage, not form ZK.  If we were doing it from ZK then when someone asks for all of the keys they would be guaranteed to get all of the keys, but this patch would do no good. Simply because it would not have an API to know what is local and what is not local.  In the short term I think this is OK, but long term we need to discuss how we really want all of this to work in the different failure cases.
When configured to use HDFS as the backing, all of the "blobs" are stored in HDFS.  We do a directory listing to get the key listing.  With that nimbus truly becomes stateless, and you can stand up a nimbus on a different node and not have to worry about it.  This code would simply do the directory listing and then become a noop.

@revans2
I might be wrong with explaining my patch. My understanding is that title is wrong instead of code. No need to be in local, just need to be available at Blobstore.
I didn't still see the details of Blobstore, so please correct me if I'm wrong.
I had a change to review this patch myself, and realize that I didn't rely on implementation details.
If local BlobStore is properly abstracted, BlobStore.filterAndListKeys() should handle underlying mechanism, thus it should list keys from blobstore regardless of locality of blob, and apply filter. So code-ids should be working well with local and HDFS, and diff-topology should only have missing topology code for all available blobstore replicas.
If you also think title is wrong please let me know so that I can correct JIRA and PR title. Thanks in advance!

@revans2
I'm not clear on part of your comment,

The one bug I saw while going through the code is that when we list keys, we are doing it only from the local storage, not form ZK. If we were doing it from ZK then when someone asks for all of the keys they would be guaranteed to get all of the keys, but this patch would do no good. Simply because it would not have an API to know what is local and what is not local. In the short term I think this is OK, but long term we need to discuss how we really want all of this to work in the different failure cases.

I think the one bug you stated is about BlobStore, right? Because code-ids just uses exposed BlobStore API, so underlying mechanism shouldn't be affected to its behavior. And achieving abstraction for BlobStore, like we pull a file from HDFS and expect pull will be succeed if there's at least one replica serving that file, when we use local BlobStore and pull blob which is not available for this nimbus, it should pull from another nimbus automatically without waiting for nimbus to next sync up cycle.

@HeartSaVioR yes there is no bug with this code.  I am +1 on merging this in as is.
The bug I found is in the BlobStore implementation.  It impacts this patch in the future, because if we fix it, this will no longer work.  I just wanted to point that out.  It should not be a big deal, again because all of the nimbus instances should be synching with one another, so the race should be very small.

@revans2
IMO this patch will still work if we address both of the expectations: 1) BlobStore should list keys for all available keys for listing keys. 2) BlobStore should ensure that it will pull from another replica when blob is not in local. If we address only 1) it will break this patch and go back to now.
Suppose both things are achieved, we would like to have nimbus giving up leadership rather than crash when we have zero replication count on one of topologies code in blobstore. Like we talked we don't want to crash Nimbus in this case, since itself is a replica of blobstore, so it incurs decreasing replication count of some part of blobs, and next leader nimbus has more chance to crash.
But also as you said there should be few problem if we have enough nimbuses and syncing up blobs is enough fast and done often.

Thanks @HeartSaVioR . Merged into 1.0.x, 1.1-x and master.

Filed an issue regarding local BlobStore bug what @revans2 mentioned.
https://issues.apache.org/jira/browse/STORM-1986
Btw, get / delete / set / update operations seems to have proper logic: it finds blob from local and download if it's not, though it doesn't check download is succeed or not. So we don't need to care about this for now.


Remove ethereumjs-utils dependency

We use some utility functions from the library ethereumjs-utils. As ethers also provides such functionalities, we should use this instead.

done


Feature: OTEL service daemon for ECS on EC2 container instances.

Description
Terraform module provisioning OTEL agent collector as an ECS service daemon. Supports EC2 container instances.
Feature request: CDS-762 Create OTEL ecs-ec2 Terraform.
How Has This Been Tested?

Environment Setup:

Create New AWS VPC, ECS Cluster on EC2 container instances.
Deploy test nginx service.
Open a terminal with valid AWS session credentials and Coralogix key as  TF_VAR_private_key
Review terraform-coralogix-aws/tests/ecs-ec2/ecs-ec2.tf, edit region and coralogix_region accordingly to your environment.
Deploy ecs-ec2 Terraform module:cd terraform-coralogix-aws/tests/ecs-ec2
terraform init
terraform plan
terraform apply -auto-approve

Testing:

Verify ECS service named coralogix-otel-agent runs as a daemon task on all EC2 instances.
Send requests to nginx container endpoint.
Verify Coralogix console shows nginx logs and container metrics

Checklist:

[ ✅ ] I have updated the relevant example in the examples directory for the module.
[ ✅ ] I have updated the relevant test file for the module.
[ ✅ ] This change does not affect module (e.g. it's readme file change)

Additional capabilities pending investigation:

OTEL container health check.
Test for user-defined OTEL Config file.
Integration test across multiple regions and Coralogix endpoints.
Support for Windows

Implemented changes requested by @royfur , including:

Improved variables:

custom_domain parameter to override coralogix_region parameter
api_key instead of private_key

Improved test configuration. Added test readme.
Tested multi-region (SG and IN), custom_domain.

Additional capabilities pending investigation:

OTEL container health check.
Test for user-defined OTEL Config file.
Integration test across multiple regions and Coralogix endpoints.
Support for Windows

Windows will be implemented in a separate Terraform template with a separate PR.

Added my GPG key and retro-signed commits 1307029..2e9167 for this PR.


Build error when adding tcod="0.15" to [dependencies]

Hitting a roadblock very early in Tomas Sedovic' Roguelike Tutorial. All I've done is add:
tcod = "0.15" to the dependencies and used brew to install pkg-config and sdl2.
I'm on macOS Ventura 13.4.1.
Let me know if there's any more useful info I can provide. This is my first issue I've opened.
The build error:
cargo build --release
    Updating crates.io index
   Compiling tcod-sys v5.0.1
The following warnings were emitted during compilation:

warning: libtcod/src/zlib/gzlib.c:256:24: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

...

Hi! I'm sorry but this project hasn't been maintained for a while.
Please check the readme for much more viable alternatives:
https://github.com/tomassedovic/tcod-rs#alternatives

@tomassedovic I noticed that the second I pressed submit, sorry about that and thanks for replying :)


[BUG] How to reproduce demo for English TTS

I am trying to use webui. I load the checkpoint and use the reference wav provided in demo page. But I can not reproduce.
Describe the bug
I am trying to reproduce this demo

model settings

I used same reference wav.

But the results are pretty bad
audio.zip
How could I reproduce the demo performance? Thanks!

There are not enough English training data in v0.3, this should be fixed in v1.0. As the demo page mentioned, you need to enable the g2p (aka 自动音素) for English and Japanese synthesize.

There are not enough English training data in v0.3, this should be fixed in v1.0. As the demo page mentioned, you need to enable the g2p (aka 自动音素) for English and Japanese synthesize.

Thanks for your reply. Do you have plan to release v1.0 checkpoint in the future?

Of course. It should be released in the next 4 weeks.

@leng-yue  Any update on the progress of v1.0 model checkpoint?

We are optimizing the VQGAN for better audio quality, most issues are solved now.


Nextcloud to OnlyOffice - larger than 100MB word document - Download failed

I am running Nextcloud 13.0.8 integrated with OnlyOffice (on a separate server). The integration is working fine, overall. However, if I try to open a document that is larger than 100MB it shows a download failed. 96MB is fine. I read somewhere a hint this might be a limitation with onlyoffice or the integration. Is this a hard limit or something that can be configured in OnlyOffice and/or NextCloud? I already tweaked the php on Nextcloud to get larger files uploaded.
Thanks
Alan

OK, I found in the out.log for the converter the following:
at Request.onSizeError (/var/www/onlyoffice/documentserver/server/Common/sources/utils.js:235:19)
at Request. (/var/www/onlyoffice/documentserver/server/Common/sources/utils.js:256:21)
when  looking at that code, there is a variable optLimit that is being used. Is there a place I can set this value?

Found the answer. Two values can affect this in /etc/onlyoffice/documentserver/default.json
in the "FileConverter": "converter" section
maxDownloadBytes
downloadTimeout
If you increase either of these it will increase the maximum filesize.  the downloadTimeout is multiplied by 1000 to determine the maximum size. the maxDownloadBytes is a raw number and these are checked and if one is favorable it continues.

#127


What is the purpose of the VerifiedByGS1DataCredential

Looking for clarity between the VerifiedByGS1DataCredential and GS1DataCredential. Both credential have the same fields.

What use cases would a VerifiedByGS1DataCredential be used instead of a GS1DataCredential?
Who can issue VerifiedByGS1DataCredential?

VerifiedByGS1DataCredential was originally a mapping of the Verified by GS1 trade item attributes. As it is not connected to the Verified by GS1 service, it is now ProductDataCredential.


Add the ability for the MP Health extension to discover HealthCheck instances not only from CDI beans but also from providers discovered using the ServiceLoader.

This is a straight forward change to the HealthMpService class so that the HealthCheck instances that it adds to the HealthSupport.Builder can be provided by an alternative means than just discovering CDI beans that implement HealthCheck and are annotated with Health. This functionality is required by the future gRPC MP work so that the gRPC MP extension can supply health checks for all of the deployed gRPC services as these health checks would not come from annotated CDI beans.
A new interface called HealthCheckProvider has been added that has a single method that returns an array of HealthCheck instances. The HealthMpService uses the Helidon service loader to discover implementations of HealthCheckProvider and adds the provided HealthChecks to the HealthSupport.Builder.
A new functional test was added to verify that this all works, which necessitated adding the fail-safe plugin to the MP health module's pom.xml.
The existing HealthCheckProducer class has been renamed as it was quite close in meaning to HealthCheckProvider but it did not actually produce any health checks and is in fact a CDI producer for some JVM runtime classes.

Adding @romain-grecourt - could you please check the additions to the pom.xml files, if these are aligned with what we want to do?
Thanks


refactor: change align for logo text

When the welcome text is too large, it is positioned on the left, which does not look very good


Upgraded API version to 0.5.0

Added unit price to list-passes, list-plans commands for satellite and ground station.
Added ground station organization name to list-passes, list-plans for satellites.
Added satellite organization name to list-plans for ground station.
Added verbose flag to list-plans for satellite and ground station.
Small code refactoring.

Looks good, just need to fix formatting.


Add App karaok-AI

Karaoke Player / Editor with automatic clip creation from any song file using vocals and lyrics extraction.

Remark: in the Contribution Guidelines, there is "If the submitted project is an open-source project on GitHub: It should have at least 20 stars.".
This submission is before all an App, that could have been delivered without its open-source code.
The fact it's also a GitHub Project is not the main purpose.


[Need support]:

Describe the problem
After executing ROBOT test cases 4-5 time successfully, By default enable_healing column value is marked as false in Selector table. As it has not marked true as enable_healing healing is not happening. In Selector URL http://localhost:7878/healenium/selectors/ for each web element Healing Enable is False.
So is it new future? Do we have to manually change enable_healing as true for each web element on selector url ? In earlier hlm_backend there was no enable_healing column.
I am using :
HLM_PROXY_VERSION="1.3.3"
Healenium Web version
NA
Healenium Backend version
3.3.4
Selenium version
4.8
Platform
Python
Logs appeared during using Healenium
NA

Additional context
No response

Hi @ap0087105 , By default, Healenium performs healing on all findElement methods executed during the testing session. However, healing is not performed when using findElements methods. If you want to enable healing for findElements, you can do so by toggling the relevant selector on the Healenium selectors page.


Update documentation and add a basic quickstart sample app.

this is great! awesome to have a simpler example.


MINOR: Port changes from trunk for test stability to 2.3 branch

Just a port of changes from trunk to 2.3 for test stability.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @mjsax for review

@bbejeck This PR basically increases the timeout to 60 seconds, right?
LGTM.
Retest this please.

Both runs failed. Test result not available any longer.
Retest this please.


Changes to support environment variable in Restel variable

Restel variable should be able to resolve values from environment variables.
Context:
There might be scenarios in which few params of the excel sheet need to resolved dynamically for each time the test is getting executed. For ex, when Restel is configured for CI/CD the server host/port against which the Restel will run might be dynamic. In such situations, we need to provide a way to control parameters in a dynamic way. Allowing Restel variable to resolve environment variable will be useful in such scenarios.

The changes has been made and respective info has been added restel-docs  as well.


Fix handling of missing progression data

For  now pfs and os are just zero-d when not available, though we should have proper na handling.
See https://github.com/hammerlab/cohorts/issues/46

I'm curious why these would ever be NA - the XML version of the clin data has a field last_contact_days_to, for example, which can be used to populate these values. If they are actually unknown, then a value of 0 seems appropriate. Not sure if there an analogous field available from the cases endpoint of the API.
In general seems likely we will want/need a few post-processing steps for clin data.

I saw a few cases where last_contact_days_to or I think it's called days_to_last_follow_up or something was also None.  There was also a case where this was longer than the OS which was odd.

Interesting. I see a field called followup_lost_to which may also be informative?
Perhaps we should look at annotations for these use cases, to see if they can help reconcile the issues.

@jburos what is this blocked on?

@hammer  The blocking issue is hammerlab/cohorts#46 (cohorts doesn't currently support unknown progression/mortality status).


Properties are listed with different icons

See screen shot. The name property has different icons. Looks like the icon depends on the value of the property (string versus number)

We categorize the properties by value type: array, string and number in this case.


Create CONTRIBUTING.md to provide guidelines for contribution to the project

As the title suggests. Create at CONTRIBUTING.md to let folks know how to contribute and inform.

implemented basic guidelines


Can we push multiple Sheets at same time?

Let's said we have multiple dashboard want to push,  can we do that? Or I just need to deploy other python code

@howardpen9 Hello! There's a few ways you could do that.
This will be easier to exemplify when I'm back at a computer -- out of town for the weekend.
If you want to have the Slack bot post multiple dashboards at the same time...
Edit the JSON payload in the Python script. You will need to duplicate the Slack Block Kit section that posts the image and give it new variables. One new block per view/dashboard.
If you want many dashboards to post at different intervals, you can just schedule the script multiple times using different environment variables.
Hope that makes sense. Let me know how I can help! Will be back next week. Depending on how you have this deployed you could suite either case.

ok, I will try and upload a my version on new branch.
If you want to have the Slack bot post multiple dashboards at the same time...
Edit the JSON payload in the Python script. You will need to duplicate the Slack Block Kit section that posts the image and give it new variables. One new block per view/dashboard.

No updates, so going to close this now.


added the possibility to have a flat map, without nested objects

Hi
I used your Gulp plugin but in my situation I needed a JSON file without the objects nested in it, just one flat object with the filenames and corresponding paths.
I've made some small changes to have that option when setting up the plugin in your Gulpfile.
gulp.task('mapTemplates', function() { 	gulp.src(paths.main + '/**/*.tpl.html') 		.pipe(directoryMap({ 			filename: 'templates.json', 			flat: true 		})) 		.pipe(gulp.dest(paths.app)) 		.pipe(browserSync.stream()); });
The flat: true makes sure you get a JSON file with just one flat object in which all the files of a certain type are mapped.
Regards,
Denis

Coverage increased (+0.3%) to 91.176% when pulling d88327328a171255fd270605511408219f4e0ac2 on DenisValcke:master into 164ab5c5bd2889feb51f9cd193ff9d4043c63196 on masondesu:master.

Coverage increased (+0.3%) to 91.176% when pulling d88327328a171255fd270605511408219f4e0ac2 on DenisValcke:master into 164ab5c5bd2889feb51f9cd193ff9d4043c63196 on masondesu:master.

The test failed because the default behavior was blocked, renamed the parameter and fixed the error. Now it works as followed:
gulp.task('mapTemplates', function() { gulp.src(paths.main + '/**/*.tpl.html') .pipe(directoryMap({ filename: 'templates.json', showObjects: false })) .pipe(gulp.dest(paths.app)) .pipe(browserSync.stream()); });
The showObjects: false makes sure you get a JSON file with just one flat object in which all the files of a certain type are mapped.

Coverage increased (+0.3%) to 91.176% when pulling 1cd4506bed286c063c7d300155140d71756d865b on DenisValcke:master into 164ab5c5bd2889feb51f9cd193ff9d4043c63196 on masondesu:master.

LGTM +1, sorry for the delay. Thanks!

@DenisValcke version 0.2.0 is now on NPM with your additions. Thanks again.


Replace index.json with index.sql as the main index

Summary
After this PR is ready, the json index will not be considered the main source of truth anymore. Instead, the index.sqlite3 will replace it in that role.
The index.json will still be around, but it will only be written at the end of the processes that run. If the archive is old (no index.sqlite3 is present) running archivebox init --force will be necessary to update it to the latest version.
Changes these areas

[ ] Bugfixes
[X] Feature behavior
[ ] Command line interface
[ ] Configuration options
[X] Internal architecture
[X] Archived data layout on disk

Roadmap Goals
This is one of the main goals of the 0.5 release.

Thanks for the review! I will make the required changes, and start the removal of Link from archivebox.

@pirate I think that most of the requested changes were done. There are a couple of them pending, but we can address them later. What else do you want in place to be able to close this PR?


i18n(fr): Update reference/error-reference from #10447

Description (required)
Update reference/error-reference from #10447

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

fr/reference/error-reference.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


ISPN-12725 Conflict resolution fails in transactional cache with auto-commit disabled

https://issues.redhat.com/browse/ISPN-12725
https://issues.redhat.com/browse/ISPN-12715
https://issues.redhat.com/browse/ISPN-12717
ISPN-12725 Conflict resolution fails in transactional cache with auto-commit disabled
ISPN-12715 Conflict resolution failure logged at debug level
ISPN-12717 DefaultConflictManager.getAllVersions fails in tx caches

@pruivo updated to include the IllegalArgumentException fix

Updated to fix the test failures (sometimes the transaction manager is null) and to rebase on master.

Thanks @danberindei


Copilot: Regarding Your Copilot Access

Hi,
Since I started using avante.nvim with copilot as a back-end I got the following message twice from github:
"On behalf of the GitHub Security team, I want to first extend our gratitude for your continued use of GitHub and for being a valued member of the GitHub community.
Recent activity on your account caught the attention of our abuse-detection systems. This activity included use of Copilot that was indicative of scripted interactions or of an otherwise deliberately unusual or strenuous nature. While we have not yet restricted Copilot access for your account, further anomalous activity could result in a temporary suspension of your Copilot access.
While I’m unable to share specifics on rate limits, we prohibit all use of our servers for any form of excessive automated bulk activity, as well as any activity that places undue burden on our servers through automated means. Please refer to our Acceptable Use Policies on this topic: https://docs.github.com/site-policy/acceptable-use-policies/github-acceptable-use-policies#4-spam-and-inauthentic-activity-on-github.
Please also refer to our Terms for Additional Products and Features for GitHub Copilot for specific terms: https://docs.github.com/site-policy/github-terms/github-terms-for-additional-products-and-features#github-copilot.
Sincerely,
GitHub Security"
Did anyone else receive this? I have been using copilotchat.nvim without a problem for the past months. So I'm suprised that I get this message since I've started using avante.

are you using with suggestion on? YOu should disable suggestion for now.

I use the default config only with copilot specified as the provider in opts.

I just got this email too. I used suggestion 5min and disabled it because the debounce timeout was too high and not configurable.
I will comment back if I ever get a follow up (or ban) from GitHub with suggestion disabled

Hmm this is strange, since I have also been using copilot and yet to see this form github

I also got this. I just installed this plugin yesterday and played around with it for maybe 5 minutes, then got the same email today. I've been using Copilot for a year+ and never had this issue before. I used the default config as well.

Can you disable suggestion for now?

I just got this email too. I used suggestion 5min and disabled it because the debounce timeout was too high and not configurable.
I will comment back if I ever get a follow up (or ban) from GitHub with suggestion disabled

Confirming that I disabled suggestions two weeks ago and I didn't get any emails or ban from GitHub Copilot

I activated the suggestion feature and used it for 1 minute. Could this be the reason I received this notice in my email? Can someone confirm this, as I would like to continue using Avante.

yes, suggestion is currenlty debounce every 100 ms, which might trigger the error.
For now please turn off suggestion, we are working on a fix.

Probably same issue as https://github.com/zbirenbaum/copilot-cmp/issues/117

@aarnphm  what part of the configuration are you disabling to turn off the suggestions ? auto_suggestions default value is already false and i did received that email

@jsongerber @aarnphm what part of the configuration are you disabling to turn off the suggestions ? auto_suggestions default value is already false and i did received that email

Yes I had to enable it, it's disabled by default. I asked to the GitHub support why I got this email and they would not tell me, only that I should use copilot.vim as this is the only supported client for vim/neovim. I'm still using the avante chat and copilot.lua suggestions and did not receive others emails.

I got the same email from the github. It has been less than 24 hrs with this plugin.
Something weird is that I didn't touch any default config but only auto_suggestions_provider to copilot.
I thought it would be okay with the default config below:
    auto_suggestions = false, -- Experimental stage

But I was wrong.

@greyHairChooseLife  hey ! I saw your change switching suggestions to Claude. I did the exact same change in my config... Resulting in a second email from Github a few hours later.... So far i will have to stop using avante until it's fixed..

I only get this email when I used copilot.lua
idk if this is related to avante.nvim at all
when I use supermaven, everything seems fine

FYI, i contacted the Github support regarding this issue, and received the following response
Hi benjah13,

Thanks for contacting GitHub Support and for providing us with more info regarding your Copilot usage!

There seems to be an error on the automated notification regarding Copilot access and usage which should be fixed by now.

You should receive another notification correcting the initial notification you have received. If this isn't the case, please let me know.

Feel free to reach out if there's anything else I can help you with. :)

Cheers,
Nix
GitHub Support Engineer

Let's see if we receive that correction email 👍

Thanks for reaching out to them ben

i just received a correction email from them 😭
Hi benjah13,

Hope all is well! I just wanted to follow-up with you.

I've discussed this internally with our team and they've confirmed that the warning notification you received is legitimate.

Based on investigation, token retrieval by the third party plugin avante.nvim is placing excessive burden on Copilot infrastructure.

Continued usage of the plugin comes at the risk of flagging by GitHub abuse detection tooling

Hope this helps clear things out. Feel free to reach out if there's anything else I can help you with!

sg, let me investigate this

I suspect https://github.com/yetone/avante.nvim/blob/3f947f8deb31af42bc3a7280c3d0d57763565222/lua/avante/providers/copilot.lua#L127
with parse_curl_args calling refresh_tokens too many times if users send consecutive messages

I suspect
https://github.com/yetone/avante.nvim/blob/3f947f8deb31af42bc3a7280c3d0d57763565222/lua/avante/providers/copilot.lua#L127
with parse_curl_args calling refresh_tokens too many times if users send consecutive messages

The problem seems to be in copilot-cmp, see: https://github.com/yetone/avante.nvim/issues/557#issuecomment-2408934454
But the maintainer of that project doesn't seem to be very responsive unfortunately.. so hopefully your fix, stops people from receiving warmings/ getting banned.


refactor: simplify Array.findIdx? code

This shortens Array.findIdx? code, by using termination_by (and well-founded recursion) instead of a structural recursion trick, with the intent to make it more proof friendly.
One motivation is that it makes it easier to write a proof that Array.findIdx? and List.findIdx? are equivalent. Furthermore, this will be useful to prove that more complex functions are equivalent.
Closes #3646

@michelsol, we would need to see convincing evidence there is no possible performance regression from this.

!bench

I would expect the new version to perform better than the original one, because it has an unnecessary fuel parameter which will be there in the compiled code. It has the look of something that was written either before a good well founded recursion mechanism was available, or in order to avoid well founded recursion for other reasons (e.g. defeq reduction in the kernel), but I think we have since decided not to worry about this in Array functions given the proliferation of well founded recursive definitions.

Sorry I wasn't aware of the bench command. Is the benchmark report good enough or is there something else I'm expected to do?


Missing Tests

Describe the bug
Tests are only testing the mock client. Specific Tests need to be added.

We should not do that. Testing already tested functionality is wasted time. we can simply fake the return values of the actual fficlient. Not only that, but this would be hard to actually do as we would need to deploy the binaries to the smalltalkci squeak env, which Patrick said would be considerable work.

got it. I was worried the new FFIClient without module name was not working on other OSes besides mac


Issue #1 'Restore' batch action doesn't work since the 'action_methods'

method is overridden and only supplies the 'index' action. Now added the
'batch_action' string as well to the array being returned.

@raihan2006i  - yes, this issue is fixed as part of this PR.


Update README.md

Added xmlns:soulwolf="http://schemas.android.com/apk/res-auto", as it is needed to invoke XML properties later down the line

Let me know what you think :)


How can I disable simplebar for responsiveness.?

How can I disable or remove simplebar based on screen size in a vue template.  I want to disable this simplebar when screen goes to 768px width. How can I achieve this, help me somebody please

I'd recommend to only check the screen size on page load and decide based on that if you want to use simplebar or not. Otherwise the breaking point can get quite janky and bad for user experience. Developers are really the only people in the world who play with window size and expect something to happen, user would find it weird that scrollbar changes if they narrow the viewport to <700px or something.

@kalnode you're right. Thing is SimpleBar changes the DOM structure and it can't bring back the initial structure once it's been instantiated.
I would advice to only enable it when needed (mobile first) with for example matchMedia:
const shouldActivateSimplebar = window.matchMedia("(min-width: 600px)")
let simplebarInstance;

if (shouldActivateSimplebar) {
   simplebarInstance = new SimpleBar(...)
}

then to "disable" it you could hide it in CSS the same way with media queries.


run linter on all source files except on output directory

Codecov Report

Merging #167 (44cd372) into main (b48429b) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   97.37%   97.37%
=======================================
  Files          14       14
  Lines         723      723
  Branches      286      293    +7
=======================================
  Hits          704      704
  Misses         19       19

Files
Coverage Δ

src/core/generateZodSchema.ts
96.16% <100.00%> (ø)

src/core/jsDocTags.ts
98.50% <100.00%> (ø)

src/utils/resolveModules.ts
100.00% <100.00%> (ø)


Add sample to create expiring kubeconfig with controller runtime

How to categorize this PR?
/area dev-productivity
/area documentation
/kind cleanup
What this PR does / why we need it:
I found it somehow difficult to figure out howto create a expiring admin kubconfig from our go code, document my findings.

/ok-to-test
/lgtm
/approve

/milestone v1.71

/retest-required

Thanks guys, this was fast


Databases create API documentation has no information about the valid service type

Example of a valid request for (https://sandbox.open-metadata.org/docs#operation/create_3):
{
"description": "DB for test purposes",
"name": "TestDB",
"service": {
  "id": serviceId,
  "type": "databaseService"
}

Example of an invalid request, that seems intuitive based on API:
{
"description": "DB for test purposes",
"name": "TestDB",
"service": {
  "id": serviceId,
  "type": "database"
}

Error in case of this request:
'{"code":400,"message":"Invalid service type database for the database"}'

@eliseealex, unfortunately the API documentation generated is not carrying for the documentation from schemas (we should find a way to fix this). CreateDatabase request is derived from this JSON schema:
https://github.com/open-metadata/OpenMetadata/blob/main/catalog-rest-service/src/main/resources/json/schema/api/data/createDatabase.json
The entityReference that it uses a type to point to the database service where the database is from is derived from:
https://github.com/open-metadata/OpenMetadata/blob/main/catalog-rest-service/src/main/resources/json/schema/type/entityReference.json
So the type in the entityReference should be the type of entity the id is pointing to. That is  databaseService. Perhaps we should the error message to - serviceId does not refer to an entity of type database. Wdyt?

@eliseealex can you give us some update on the above comment. We can update the docs accordingly. Thanks

JSONSchema allows extensions. We could create a custom field toEntities and customize the tool generating the API documentation.
{
  "$id": "https://github.com/open-metadata/OpenMetadata/blob/main/catalog-rest-service/src/main/resources/json/schema/api/data/createDatabase.json",
  "$schema": "http://json-schema.org/draft-07/schema#",
  "title": "Create Database entity request",
  "description": "Create Database entity request",
  "type": "object",

  "properties" : {
    "name": {
      "description": "Name that identifies this database instance uniquely.",
      "$ref": "../../entity/data/database.json#/definitions/databaseName"
    },
    "description": {
      "description": "Description of the database instance. What it has and how to use it.",
      "type": "string"
    },
    "owner": {
      "description": "Owner of this database",
      "$ref": "../../type/entityReference.json",
      "toEntities": ["user", "team"]
    },
    "service" : {
      "description": "Link to the database service where this database is hosted in",
      "$ref" : "../../type/entityReference.json",
      "toEntities": ["databaseService"]
    }
  },
  "required": ["name", "service"]
}

Changing the error returned to be more clear when service type is not correct for all the different entities as shown below:
Invalid service type `invalid` for database. Expected [BigQuery, MySQL, Redshift, Snowflake, Postgres, MSSQL, Oracle, Athena, Hive, Presto, Trino, Vertica, Glue, MariaDB, Druid, Db2].


Update load-balancer-arm.md

Spelling update - line 70

Hi @HeathL17, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@tysonn - approved

#sign-off


Migrate deletes chapters

Steps to reproduce

Open comic
Select migrate from menu
Select source and next arrow
Deselect "Delete downloaded" from "Data to include in migration"
Press migrate
Select accept

Expected behavior
Comic migrates to new source but keeps old chapters (in my case it is the same source).
Actual behavior
Migrate is successful but the chapters are deleted.
Crash logs
No response
TachiyomiSY version
1.10.5
Android version
Android 14
Device
Samsung Galaxy S24 Ultra
Other details
I've tried with both the check box selected and not selected but the file got deleted either way. I previously had no problem with this but in one of the recent updates to TachiyomiSY it stopped working.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.10.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Downloads are not moved because there is no exact matching between chapters for sources. This is intentional as there can be a lot of differences. We provide the delete chapters option to cleanup orphaned downloads


Fix Maps Route Readme Issues

Fixes https://github.com/Azure/azure-sdk-for-js/issues/26648

API change check
API changes are not detected in this pull request.

@joheredi, @markweitzel, @andykao1213  Could you help review this PR?

@andykao1213 Could you help merge this PR? Thanks a lot.


why not report the finetuned results on some QA datasets?

Hi,
Have you tested your finetuned model on some QA datasets, which can be used to compare with some strong baseline models, such as BLIP-2?

Additionally, the zero-shot results of BLIP2 in your Table 2 seem not consistent with the original paper.


Can resolve_titles also work on local file?

I have set
prefer_titles = "all"
resolve_titles = true
I have some mp3 with filename Track01 Track02....etc and they have titles.
Now it seems only the playing file will show the title.
Other file will show the filename until they are played.
Is it possible to resolve title also for local file like for url?
Thanks for your reading.

I think this is currently not trivial since mpv doesn't load files before they are played. So the lua API doesn't have access to the titles, they are only cached once the file has been loaded.
It could be possible to run a subprocess to fetch the title metadata with some program but it easily gets messy. I'm not aware of a way to do it with the mpv binary. Perhaps ffmpeg could do it.

OK, i undestand, thanks for your reply ^^

Let's keep this open since it's a nice feature. Hopefully someone can come up with a good solution for this.

mediainfo has a Movie name field in its output.

ffmpeg seems to be able to do it with the following command: ffmpeg -f ffmetadata pipe:1 -hide_banner -loglevel warning -i [filename].
An example of the output to stdout:
;FFMETADATA1
album=Ghost Hound Original Soundtrack
artist=TENG
date=2007
genre=Soundtrack
title=Awake
track=1
encoder=Lavf58.45.100

The title should be easily extractable using string.match(stdout, "title=([^\n\r]+)")
Alternatively, it may be better to use ffprobe, which is bundled with ffmpeg and seems better designed for this.
ffprobe -show_format -show_entries format=tags -print_format ini -loglevel warning [filename] provides a similarly parsable output with the added advantage of escaping newlines:
# ffprobe output

[format]
[format.tags]
album=Ghost Hound Original Soundtrack
artist=TENG
encoder=Lavf57.36.100
genre=Soundtrack
title=Awake
track=1
creation_time=reation_time
date=2007

This has been implemented by @2084x :+1:


Added helper methods for spring

Added helper methods to the builder to make it easier for the end user when configuring dozer.
CC @orange-buffalo ; any views?

@garethahealy, looks good to me, just one thought here. I would keep builder methods which accept single object instead of deprecating them. Imo, code like this:
    ...
    .withCustomConverter(MyConverterBuilder.create()
            .withThis(..)
            .withThat(..)
            .build())
    .withCustomConverter(AnotherConverter.ofSomething(..))
    .withCustomConverter(new SimpleCoverter())
    ...

is more expressive than
    ...
    .withCustomConverters(MyConverterBuilder.create()
            .withThis(..)
            .withThat(..)
            .build(),
            AnotherConverter.ofSomething(..),
            new SimpleCoverter())
    ...

We could call withCustomConverters with single argument multiple times, but then it looses its semantics.
Of course, this is a matter of personal preferences, do not insist that it is the only and the best way :)

@orange-buffalo ; removed the deprecated as requested. I am easy either way, so left them.

@garethahealy thanks!


Docker container not running

Hi there,
I'm trying to run the docker container using: docker run -p 6080:80 -p 10000:10000 -p 5005:5005 --shm-size=1024m unity-robotics:nav2-slam-example, however it stays stagnant loading and never loads the docker container (see attached image). Any suggestions as to what to do would be appreciated.

Solved: Once I opened the web browser (http://<IP_ADDRESS>:6080), it worked!

Great! Yep we don't call out anywhere that the console output from the image doesn't necessarily mean it's not working - some of the messages look mildly alarming but it's all normal and expected.


feat: return all (semver) tags sharing one commit

When one commit has more than one semver tag, do not pick one but emit both with same the hash.

Coverage remained the same at 100.0% when pulling e25afee8456995c78618504cea931317e88ab602 on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling e25afee8456995c78618504cea931317e88ab602 on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling e25afee8456995c78618504cea931317e88ab602 on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

@ikhemissi It's a bigger PR than it should be but getList would have getting complicated to follow with that array of array to flatten in the middle.
I refactored it in the first commit and then changed the parsing of the list of tags.
I hope it's ok.

Coverage remained the same at 100.0% when pulling 96a8fd59917149b544d08770de8d4f9985be4e57 on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling 8245c5959845b552e5a3e57fa1b72ba72d26f01b on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling 8245c5959845b552e5a3e57fa1b72ba72d26f01b on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Although, most repo will have a file holding the version number (be it "package.json" for a npm package or "VERSION" for something more generic) that's not a requirement. You could have a commit having more than one semantic tag, e.g. a bug free RC version becoming final version.

Coverage remained the same at 100.0% when pulling f2d967ce2cbcaf7c986fca32dd9617323dd6ecd3 on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

@ikhemissi Thanks for the review. It should be fixed.
Please, let me rebase before merging.

I'm happy with the changes and I will merge them (and create a release) once you finish the WIP.
Thank you @dinoboff

Coverage remained the same at 100.0% when pulling d970c7619eef7a1ca81175e0bc6d1a54195b905d on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling d970c7619eef7a1ca81175e0bc6d1a54195b905d on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling d970c7619eef7a1ca81175e0bc6d1a54195b905d on dinoboff:feat-multi-tag-per-commit into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Released in version 1.3.0


fix: #112

closes #112

Codecov Report

Merging #114 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master    #114      +/-   ##
=========================================
- Coverage   58.92%   58.9%   -0.03%
=========================================
  Files         174     174
  Lines       14682   14694      +12
=========================================
+ Hits         8652    8655       +3
- Misses       5380    5386       +6
- Partials      650     653       +3

Impacted Files
Coverage Δ

g/crypto/gaes/gaes.go
74.07% <50%> (-6.88%)
:arrow_down:

g/os/gtimer/gtimer_entry.go
86.04% <0%> (-3.49%)
:arrow_down:

g/container/garray/garray_normal_int.go
72.2% <0%> (-1.21%)
:arrow_down:

g/container/garray/garray_normal_string.go
72.2% <0%> (+1.2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eea93c...e8c3dfa. Read the comment docs.


adds postgres version to the schema cache.

Adds the postgres version in the schema cache using SQL from the pg-meta library.

Hey @psteinroe , thanks for the reply.
While it does make sense to have a single type instead of a Vec, the SchemaCacheItem trait is defined as
pub trait SchemaCacheItem {
    type Item;

    async fn load(pool: &PgPool) -> Vec<Self::Item>;
}

is defined as having a Vec of the type. Should we make the version implement a different trait?

Ah yeah I think it makes sense to refactor this a bit. Do you want to do it in your pr or should we merge and do a follow-up? 🙏🏼

Let's do a follow up. I'm not sure how the refactoring will look like at the moment.

sounds good! the ci is failing due to an unrelated issue. I am going to fix it soon and then merge 🙏🏼


Add a "generic" hostname for ephemeral hosts

in CI or automated environments joining a machine to a fleek config litters the config file with hostnames that are likely to be gone soon.
add a FLEEK_HOSTNAME env var, and override the hostname in fleek.Hostname() if it's set to allow multiple machines to share the same host level configs without polluting the config file.

fixed by #287


clear chat history (just whats on the screen), and a "flush conversation and start from scratch" button.

I would like to clear the chat history.  Also sometimes I go a rabbit hole with the chat and it keeps referring to the old conversation and it gets confused.  Sometimes I need an "ok.. let's start over, forget everything I was talking about and start fresh" option.

Several ways you can do this:

Use the plus in the toolbar (see picture)
Use the /clear command directly (see picture)
In the command palette (F1)using Chat: New Chat

OK!  Thanks!


Fixed #484

Amazing, thanks @idok! This is great news! I don't know why coveralls is even reporting that as a problem. @Snugug could you just force merge this anyway? I don't have access to temporarily disable it.

I have no idea why that failed. Temporary disabled.
@idok Please look through our contributing guidelines and ensure that your PR matches our process (specifically developer cert of origin)

Thankyou @idok


Split testing into its own project

This PR splits out all the integration-based testing into its own test project. Only a few tests were true unittests and did not require a full database connection to perform the test (which is a natural consequence of creating a database connection library).
The rest have been added to a subproject called integration-tests. You can run these via dub run :integration-tests
At this point, we are using vibe exclusively for the tests. We still need to perform the integration tests with Phobos sockets, that will be a future enhancement.
Also, the troublesome app.d has been moved to its own project called testconn (it needs testing as well).

ping @SingingBush

TODO: have to investigate spacing. My editor I used for a lot of this didn't obey the .editorconfig. grrrr.....

There are two files in my branch that I believe should be copied into this pull request (with tweaks):

integration-tests/docker-compose.yml
integration-tests/README.md

It should make it trivial for people to check the project out and run the tests with no prior setup (except to have docker) and a readme file specific to the test project means that the readme in the root of the project can be used to just put information that's relevant to people that want to use mysql-native as a dependency.

I might need your help on docker, I'm not well-versed in it.

Are checks for version(DoCoreTests) are redundant now?

Yeah, I think so. Working through the version logic, if you define MYSQLN_CORE_TESTS as opposed to MYSQLN_TESTS, the only test that is run is the basic connection test. Which is pretty useless.
I'm thinking we should get rid of these version statements, and rely on unit-threaded to allow running of individual tests. But maybe as a future PR, don't want to distract too much from the sheer copy-paste-ness of this PR.

So I've run into a weird problem. With dub, if you have a dependency with an optional dependency, you can't optionally depend on that optional dependency.
I added a second config to omit the dependency on vibe-core, and it still pulls in vibe-core.
I think I will need to create a third project that tests vibe, and make the vibe-core dependency optional. Ugh...

So I've run into a weird problem. With dub, if you have a dependency with an optional dependency, you can't optionally depend on that optional dependency.
I added a second config to omit the dependency on vibe-core, and it still pulls in vibe-core.
I think I will need to create a third project that tests vibe, and make the vibe-core dependency optional. Ugh...

isn't it something you can sort with configurations? like in this: https://github.com/SingingBush/mysql-native/blob/pipeline/integration_testing/tests/dub.sdl
dependency "mysql-native" path="../"

configuration "default" {
    subConfiguration "mysql-native" "library"
}

configuration "use-vibe" {
    subConfiguration "mysql-native" "library"
    dependency "vibe-core" version="~>1.16.0" optional=false
}

No, it doesn't work. I'm going to file a dub bug, but I have a crappy workaround at the moment. You'll see.

@SingingBush why aren't we running windows/macos integration tests? Are those not possible?

Added the dub issue: https://github.com/dlang/dub/issues/2136

@SingingBush I've noticed that the "Install dependencies on Ubuntu" never gets run for integration tests. Any idea why? It seems like it's not needed anyway.

why aren't we running windows/macos integration tests? Are those not possible?

testing confirms, windows and macos do not support docker, and therefore cannot run an instance of mysql or mariadb. This is a shame, but I'm OK with it for now.

@SingingBush can you take a look at the docker file and integration test readme that I just added? I have not tested the docker image, I don't really know how to use docker.

that looks fine, cheers. After this is all merged I'll use it anyway so any issues then I'll push a commit.

Pretty satisfied with this. The only thing I need to figure out is how to restructure the dub file so that it doesn't spit out tons of warnings.

Pretty satisfied with this. The only thing I need to figure out is how to restructure the dub file so that it doesn't spit out tons of warnings.

Use silenceWarnings in build requirements. in dub.json this would be done with:
    "buildRequirements": [
		"silenceWarnings"
    ]

OK, I found another solution using "sourceLibrary", now the ugly warnings only appear in integration-tests, which I'm not so worried about.
I think this is ready to merge.
BTW, @SingingBush feel free to open a PR to add your name to the author/copyright

@SingingBush can you explain the "dub upgrade" portions of the workflow? We don't need to dub upgrade anything, because there is no checked-in dub.selections.json file. So I'm confused why this is there.
I'm also not clear what the caching thing is, but I can probably ask webfreak about that on discord.

@SingingBush can you explain the "dub upgrade" portions of the workflow? We don't need to dub upgrade anything, because there is no checked-in dub.selections.json file. So I'm confused why this is there.
I'm also not clear what the caching thing is, but I can probably ask webfreak about that on discord.

Feel free to remove the dub upgrade bit. Sooner this is merged the better. Can then perhaps get both #187 and #220 merged in and do another release before you rebase/merge #214 and bump the major release version.

I checked with webfreak, and the dub upgrade is somewhat misnamed, as it caches the entire .dub folder for subsequent runs, in addition to running dub upgrade, as if you were storing it locally on your PC. A good test would be to run it with and without the dub upgrade to see how much time it saves.
I'll leave it there for now, it's not hurting anything (though I think it never runs the second dub upgrade).


is there a way to change font settings?

is there a way to edit the font size, color, height etc..? if there is, sorry I haven't found it

You should be able to override any of the CSS rules defined in https://github.com/jonmbake/react-terminal-ui/blob/master/src/style.css with your own styling similar to what we are doing in the demo here: https://github.com/jonmbake/react-terminal-ui/blob/master/demo/index.tsx#L5. For example to change, the font family for the demo, we'd add:
div.react-terminal-wrapper {
    font-family: 'some-font-family'
}

to the demo's style.css. We may want to think of ways to make this easier in the future.

Ohhh... thank you!!
Loved the new changes you did with the TerminalInput/TerminalOutput keep the great work!


Created chocolate-chip-cookies.md file

Hi! Thank you! Can you edit the config file so the recipe appears in the navigation? 😎

@jlooper Done!

Ah there might be conflicts, can you fix those and I'll merge 🙏


Updates to MemberNameConverterImpl

Description
Fixes #32546
Fixes #33241
Updates MemberNameConverterImpl to use MethodHandle.Lookup's unreflect APIs instead of findVirtual, defers the creation of MemberNameConverterImpl until it is used, and adds a test to validate whether the proper implementation is being used based on the Jackson Databind version found on the classpath.
This should resolve issues with LinkageErrors as MemberNameConvertImpl is rarely used, so most common workflows won't trigger this class to be instantiated, so even if a LinkageError would occur when instantiating it won't happen unless the specific code path is used.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

Thanks @alzimmermsft
When should the next release of "azure-core" be expected?


suggestion: multiple leaksources

For future releases maybe expand with more leakreporting sources like haveibeenpwned.com for example.
rgrds
Davelicious

The next update will have WeLeakInfo website and maybe add more too,thanks !


[pmo] Re-apply load [copy] fixes eliminating some non-determinism that came up.

I reapplied and put the commit that eliminated the non-determinism on top.
Specifically, I was abusing some sorting behavior on some arrays that I really
needed to iterate over == non-determinism. To work around these issues, I made
two changes:

Rather than using a bit vector to mark copy_values that were handled as part
of phi handling and thus needing a way to map copy_value -> bit vector index, I
instead just added a separate small ptr set called
copyValueProcessedWithPhiNodes.

I refactored/changed how copy cleanups were inserted for phi nodes by
constructing a flat 2d-array that is stable sorted by the index of the incoming
value associated with the cleanups. An incoming value's index is the count of
the copy cleanup when we see it for the first time. Thus when we do the stable
sort we will be visiting in cleanup insertion order and also will be doing
insertion order along the incomingValue axis.

rdar://57257309

I tested this locally and it eliminated these issues for me.

@swift-ci test

@swift-ci asan test

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS Platform

@brentdax I started off a custom preset job that should run the same preset as the bot did. So we can be sure it doesnt happen.


feat: add proof of presence token contract

First draft of Proof-of-Presence ERC20 token. closes #86
Current mechanism of Presence token:
Minting
Presence token is minted by calling onCheckOut function with a number of days that a user stayed. It is expected that this function will be called daily, so the $PRESENCE token is minted each day of staying even during your stay, but this implementation gives option to e.g. mint a $PRESENCE tokens for more days if needed under some circumstances. This function is possible to be called by user with role BOOKING_PLATFORM_ROLE, which is expected to be a backend which will run the script daily for each of the user that stayed during the night.
Minting the tokens daily means that e.g. someone can't just easily book stay for 1 year and be given all of the $PRESENCE tokens at once, despite that he would later leave after e.g. 3 days - and in which during these 3 days he would have the $PRESENCE tokens for full year. Minting the $PRESENCE for daily for each night spent eliminates this issue.
Decaying
Presence token will decay over time with rate set by dao (value is stored in PresenceToken.decayRatePerDay) and allows up to 2 decimal places. Currently the contract exposes decay function that is possible to use to decay balance for a specific user. Probably it also makes sense to create a decayForAll function that will decay balances for all users for gas savings.
Unresolved is how the decay function will be actually triggered, it can be either via:

some periodic script on Closer backend that will run once a day
possibly other interesting alternative to explore to not rely on Closer backend too much would be triggering the decay using something like Chainlink Automation or Gelato Web3 Functions, etc.

Completely different approach how to possibly do the decay would be to override balanceOf function to count the decayed balance. Also then on transfer, approve and probably on some other state mutating functions as well, we would also call inside these functions the decay function, so the actual balances are updated before state mutation. However this approach would mean that e.g. balances retrieved from the Transfer events would be incorrect, as the decay would happen only e.g. after transfer, approve and maybe some other state mutating method, if we would not call it in some script regularly.
Current problems/challenges/questions:

Who should be able to mint the $PRESENCE tokens?:

BOOKING_PLATFORM_ROLE = yes
BOOKING_MANAGER_ROLE = ?
dao = ?
anyone else?

Resolve how the decay should function and how it should be triggered. I've outlined some of my thoughts above.

In the PresenceToken I was not able to inherit from both Modifiers and Ownable2StepUpgradeable as both implements onlyOwner modifier. I wanted to inherit from Modifiers to be able to use onlyRole modifier, so my question is what is the best way to access the currently used role store - maybe somehow via Diamond and AdminFacet contracts? Here I would appreciate your opinion about best way of doing that.

Will the treasury hold any $PRESENCE tokens? Or all $PRESENCE tokens will be sent to user from zero address? Just asking if it's necessary to have the treasury variable on the PresenceToken contract or no.

I don't see too much into real operational stuff, so you better add your thoughts here, but since the $PRESENCE tokens will be minted on backend for each user marked that stayed during night, is it still necessary to implement the burn inside the cancelAccommodation function to handle some edge cases?

Any other functionality is missing that should be part of this PR?

There is bunch of TODOs in the code, mostly related to specific modifiers, I can work on these later once we will align on the questions and architecture above.

Would appreciate your comments and thoughts on overall concept and if you agree with it or think that something else might be a better solution. Thanks! cc: @closerearth

@coderabbitai review


Simplify appxtrue a lot by just calling it on the mean

Codecov Report

Merging #167 (2ac9a10) into main (279271f) will increase coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   91.27%   91.68%   +0.40%
==========================================
  Files          24       24
  Lines         940      914      -26
==========================================
- Hits          858      838      -20
+ Misses         82       76       -6

Impacted Files
Coverage Δ

src/devtools.jl
100.00% <100.00%> (+22.22%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


JoinMarket: add remote QT GUI option with ssh -X

As mentioned in: https://github.com/rootzoll/raspiblitz/issues/842#issuecomment-605343230
test with:
# download
wget https://raw.githubusercontent.com/openoms/raspiblitz/jm-ssh-x/home.admin/config.scripts/bonus.joinmarket.sh
# run
sudo bash bonus.joinmarket.sh on

Try the remote QT GUI connection:
ssh -X joinmarket@RASPIBLITZ_IP joinmarket-clientserver/jmvenv/bin/python joinmarket-clientserver/scripts/joinmarket-qt.py

The password is the PASSWORD_B

The remote QT GUI is tested on Debian Buster desktop.


How to use the transaction, did not find the corresponding transaction package interface

Dao.RunInTransaction() ?

Pocketbase web API currently does not support transactions.
See for example this issue in the official js-sdk


Incorrect color for headlineSmall and bodySmall in Material TextTheme

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

See https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/text_theme.dart
Also https://api.flutter.dev/flutter/material/TextTheme/apply.html

Expected results
https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/text_theme.dart#L685C7-L695C9
      headlineSmall: headlineSmall?.apply(
        color: displayColor, // <--
        decoration: decoration,
        decorationColor: decorationColor,
        decorationStyle: decorationStyle,
        fontFamily: fontFamily,
        fontFamilyFallback: fontFamilyFallback,
        fontSizeFactor: fontSizeFactor,
        fontSizeDelta: fontSizeDelta,
        package: package,
      ),

https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/text_theme.dart#L751C3-L761C9
      bodySmall: bodySmall?.apply(
        color: bodyColor, // <--
        decoration: decoration,
        decorationColor: decorationColor,
        decorationStyle: decorationStyle,
        fontFamily: fontFamily,
        fontFamilyFallback: fontFamilyFallback,
        fontSizeFactor: fontSizeFactor,
        fontSizeDelta: fontSizeDelta,
        package: package,
      ),

Actual results
https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/text_theme.dart#L685C7-L695C9
      headlineSmall: headlineSmall?.apply(
        color: bodyColor,
        decoration: decoration,
        decorationColor: decorationColor,
        decorationStyle: decorationStyle,
        fontFamily: fontFamily,
        fontFamilyFallback: fontFamilyFallback,
        fontSizeFactor: fontSizeFactor,
        fontSizeDelta: fontSizeDelta,
        package: package,
      ),

https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/text_theme.dart#L751C3-L761C9
      bodySmall: bodySmall?.apply(
        color: displayColor,
        decoration: decoration,
        decorationColor: decorationColor,
        decorationStyle: decorationStyle,
        fontFamily: fontFamily,
        fontFamilyFallback: fontFamilyFallback,
        fontSizeFactor: fontSizeFactor,
        fontSizeDelta: fontSizeDelta,
        package: package,
      ),

Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
      ),
      home: const TypographyScreen(),
    );
  }
}

// from https://github.com/flutter/samples/blob/main/material_3_demo/lib/typography_screen.dart
class TypographyScreen extends StatelessWidget {
  const TypographyScreen({super.key});

  @override
  Widget build(BuildContext context) {
    final textTheme = Theme.of(context)
        .textTheme
        // .apply(displayColor: Theme.of(context).colorScheme.onSurface);
        .apply(displayColor: Colors.red, bodyColor: Colors.green);
    return Expanded(
      child: ListView(
        children: <Widget>[
          // const SizedBox(height: 7),
          TextStyleExample(
              name: 'Display Large', style: textTheme.displayLarge!),
          TextStyleExample(
              name: 'Display Medium', style: textTheme.displayMedium!),
          TextStyleExample(
              name: 'Display Small', style: textTheme.displaySmall!),
          TextStyleExample(
              name: 'Headline Large', style: textTheme.headlineLarge!),
          TextStyleExample(
              name: 'Headline Medium', style: textTheme.headlineMedium!),
          TextStyleExample(
              name: 'Headline Small', style: textTheme.headlineSmall!),
          TextStyleExample(name: 'Title Large', style: textTheme.titleLarge!),
          TextStyleExample(name: 'Title Medium', style: textTheme.titleMedium!),
          TextStyleExample(name: 'Title Small', style: textTheme.titleSmall!),
          TextStyleExample(name: 'Label Large', style: textTheme.labelLarge!),
          TextStyleExample(name: 'Label Medium', style: textTheme.labelMedium!),
          TextStyleExample(name: 'Label Small', style: textTheme.labelSmall!),
          TextStyleExample(name: 'Body Large', style: textTheme.bodyLarge!),
          TextStyleExample(name: 'Body Medium', style: textTheme.bodyMedium!),
          TextStyleExample(name: 'Body Small', style: textTheme.bodySmall!),
        ],
      ),
    );
  }
}

class TextStyleExample extends StatelessWidget {
  const TextStyleExample({
    super.key,
    required this.name,
    required this.style,
  });

  final String name;
  final TextStyle style;

  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(8.0),
      child: Text(name, style: style),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.2, on macOS 13.5.1 22G90 darwin-arm64, locale en-BE)
    • Flutter version 3.13.2 on channel stable at /opt/homebrew/Caskroom/flutter/3.10.6/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ff5b5b5fa6 (2 weeks ago), 2023-08-24 08:12:28 -0500
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/pierre/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.5.1 22G90 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.140

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @pierredewilde, thanks for filing this.
Can you share a link to the spec that states that should be the case? Based on the doc, it seems like this is working as intended, but if it is not in line with the spec, then it would need to be updated.
Thank you

Indeed, doc is synced with code:
The displayColor is applied to displayLarge, displayMedium, displaySmall, headlineLarge, headlineMedium, and bodySmall. The bodyColor is applied to the remaining text styles.
Is it really by design that bodyColor is not applied to bodySmall but displayColor is applied to bodySmall ?
It is much more natural that

displayColor is used for display* and headline*
bodyColor is used for body* and label*

[Large|Medium|Small]

Just my 2 cents.

I am not an expert on this and I can't seem to find anything in the material guidelines as to what the correct behavior should be, labeling for further insight from the material team.

https://github.com/flutter/flutter/blob/3c4b81daebb7625ca5ff2935fa0872fa88cee301/packages/flutter/lib/src/material/typography.dart#L186-L202
flutter: displayColor: Color(0xfffffbfe)
flutter: bodyColor: Color(0xfffffbfe)

In Material 3, both displayColor and bodyColor are the same. Just inverted for dark and light.
ThedisplayColor doc was simply updated for Material 3 with backward compatibility as these two colors may differ in previous versions of Material Design.
We can update this to be a single-color property when the material2014 and material2018` text styles are deprecated and update docs. For now, this is a low-priority fix.
cc: @HansMuller


update nuget packages accross projects

in the vs solution, some projects are using nuget packages meant for .NET 3.1. other for 6.0 or even 7.0
consolidate the packages to target .NET 6.0 as the output of your app.

Could you confirm if you are referring to these

Packages are updated and Released in V3.1.0


waiting for v1.30 with fixed icons

Hi is there any update on the fix icon release the latest is 1.20

Sorry, it's the second time GitHub remove the release v1.3.0.
I readded it, you can normally get it now.

Hi Thanks its now working
From: Deejayfool @.>
Sent: Sunday, 24 April 2022 14:26
To: Deejayfool/hass-shutter-card @.>
Cc: shay lami @.>; Author @.>
Subject: Re: [Deejayfool/hass-shutter-card] waiting for v1.30 with fixed icons (Issue #71)
Sorry, it's the second time GitHub remove the release v1.3.0.
I readded it, you can normally get it now.
—
Reply to this email directly, view it on GitHub https://github.com/Deejayfool/hass-shutter-card/issues/71#issuecomment-1107821103 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6FWAH5A5U4G5NS57G5LDVGUVUPANCNFSM5UF6EBFA .
You are receiving this because you authored the thread.Message ID: @.*** @.***> >


geopackage invalid coordinate system

it's been noted that arcgis cannot open the national grid polygon when exported in geopackage format. the error is something like 'coordinate system description is invalid

after a bit of digging, ESRI requires certain projection parameters - and more importantly, the parameter names matter (https://support.esri.com/en/technical-article/000011503). For example, they do not consider 'Central_Meridian' to be the same as 'Longitude_Of_Center' - (even though they are evidently aware they are the same?). GDAL, however, uses the 'other' names by default (http://www.gdal.org/wktproblems.html).
So, the projection definition for the polygon has been updated to use WKT instead of the proj4 definition, and the WKT uses the terms required by ESRI.

this appears to be fixed after recent commits. closing.


Property mocking

When you pass a lower case key on rewire (rewire Conversation, [{:english, EnglishMock}]) instead of a module name, rewire infers that is a property and replaces it.
Example
# Implementation
defmodule Conversation do
  @english Application.compile_env!(:my_app, :english)
  def start(), do: @english.greet()
end

# Test
defmodule ConversationTest do
  use ExUnit.Case, async: true
  import Rewire
  import Mox

  rewire Conversation, english: EnglishMock

  test "say g'day" do
    stub(EnglishMock, :greet, fn -> "g'day" end)
    assert Conversation.start() == "g'day"
  end
end

Sorry for the late reply; this is great!

Thank you for your awesome library and for merging my PR ❤.
I forgot to add documentation for property mocking feature, would you appreciate another PR for this?

Good point, I'll add a little note about it in the docs.


Add pull request guidelines

closes #4
Please let's discuss this before merging it.

Pull Request (3) "also assign the person that you want to do the code review."
How do I know who to assign?
Pull Request (4) the whole reassigning when reviewing a pull request is a nice idea but I'm not sure if it is really good. What if people tend to forget to change the assignment and no one will care for the pull request anymore
(I hope no one expects reviewers to fix merge conflicts from others because sometimes the reviewer might take more time than the person who made the pull request. Correct me if I'm wrong, I never was a reviewer!)
About the thing @jessicalins mention to have a better description, I always said it would be nice to have better descriptions of what to do in issues. The person who does the issue immediately knows what to do (I often have problems here!) and also the reviewer can check the issue to see what the task was and check the pull request to see an explanation of the changes. I often had to explain my issues to other because they didn't know what it was about (like when I started with the issue).
Maybe we can have a little checklist with 2 or 3 points that state what we have to mention in an issue and PR. Ofc you just need to write stuff down if it is necessary but it could be easier this way. In the end it's all subjective and people tend (as far as I know) to think that other sure know what to do and know what is meant in an explicit situation. (I hope that was not complicated xD)

How do I know who to assign?

If you touched backend -> Some backend person
If you touched frontend -> Some frontend person
If your changes affect product behaviour -> Some UX person
They are not mutually exclusive.

Pull Request (4) the whole reassigning when reviewing a pull request is a nice idea but I'm not sure if it is really good. What if people tend to forget to change the assignment and no one will care for the pull request anymore

I think now with new github approve/reject functionality you will get a notification when your PR is rejected. But good point.
Agree on the issues description, we need to work on that. What about a needs_description tag and assign that to the person who created the issue.

Ok, I think if nobody else complained in 9 days means that you are not completely opposed to it. So can someone merge?


Core assets missing / Nuget Packages do not restore, and/or corrupt NuGetFallbackFolder

This issue is exactly as described in:
#1006 - ".Net Core v2.0 - Nuget Packages are not getting restored"
and
#5995 - "Assets from packages are missing after restore"
#920 - ".NET Core 2 does not work...."
But, I actually just performed a Windows Defender full "System Refresh", and then a full reinstall of VS Enterprise 15.5.2, and had the issue, so then uninstalled, and did VS Installer InstallCleanup -f, and even after that yet one more full Repair ...
And still I was only able to fix it by eventually removing the NuGetFallbackFolder.
I thought I should post another issue because none of those extensive 'Repairs' actually fixed the problem!

@steevcoco what was the permanent resolution? I don't think running dotnet restore int the console is acceptable. Preferred behaviour is when you create a new project in Visual Studio and build, all dependencies should resolve.

@salmonz sorry: I actually closed the issue because I have not seen the problem again ...
My ACTUAL solution did require deleting the NuGetFallbackFolder. You THEN can do dotnet restore on some solution to rebuild that folder: I had to delete the folder to get it in working order again.
I closed the issue because it has just been sitting open ... Perhaps I should re-open it.


feat: merge the GitHub Actions workflows

Things added/changed:

Merge the GitHub Actions workflows. This will:

Make things cleaner.
Run for all OSes on the same workflow.
Seamlessly check all jobs in one place (example).
Run directly on all pull requests and multiple branches.

Hi,
Looks good but can you separate linux and darwin?
Because of we can have multiple linux or darwin action in the future.
We think it would be better for us to see actions as a separately by kernels.

...can you separate Linux and Darwin?

So only separate Linux and Darwin to multiple jobs, and keep all the other stuff as-is?
I like to have everything in one file to make everything cleaner, and you can still check each job (like seen here). But if you prefer to have it separated into multiple actions, then we can close this PR. 🙂

We like your single file approach. What we are wondering is, can we keep all kernels separate in this single file?
For example, windows is alone but linux and darwin are a matrix. We want to get rid of this matrix.

For example, windows is alone but linux and darwin are a matrix. We want to get rid of this matrix.

Oh, like having separate jobs for Linux and Darwin?

Yes, something like that.

LGTM, thanks for your contribution.


Update README.md

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   66.99%   66.99%
=======================================
  Files           7        7
  Lines         803      803
=======================================
  Hits          538      538
  Misses        265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4e905...0e7a9a9. Read the comment docs.


Browse experience improvements

We want to make have more detail in the browse experience as well as making it more useful. The TwoLineRowEntity should show license and the "score" so that people scanning the list can quickly understand what they are looking at. Ultimately there will be sorting and filtering on these sort of fields.
On the drop down we can add links and the tools used (new info that will be added as part of another issue)

remove revision selection affordance
add in file counts
add score (use badge?)

more tweaks to come but this is looking reasonable for now


V11: Hover detected even if window on top of token

When a journal is covering several tokens, moving the cursor within the border of the window will trigger the image hover on tokens that are on the canvas beneath the journal.

This might be related to something I read on discord. Something about the newer version of PIXI always processing events despite a window above it also using the event.

I can't recreate the issue, am I misunderstanding something?

I think I raised this on Foundry 305 or earlier, and it was a bit in core event handling rather than your module.
It is not a problem with core 11.307


Fix NullPointerException in ReflectionQuery.SelectMethodHandler#toValue

There's a bug in single value projections where an NPE can be thrown if there are no matching rows. This is because we incorrectly pass an Any? into a method that wants Any. Oops!

LGTM

Oops, there was more :) I'll get another review from you when I'm done!


keyboard teleop in gazebo

Hi,
I have already installed the sim, without any problems in 5 minutes (!)
I tried:
roslaunch f1tenth-sim simulator.launch run_gazebo:=true keyboard_control:=true

I get an empty world in gazebo with yellow car and asphalt plane (no track).
When I press WASD I receive on /car_1/command following msgs:
---------- 28.10.2019 11:46:11.035356 --------------------
steering_angle: 0.0
steering_angle_velocity: 0.0
speed: -0.5
acceleration: 0.0
jerk: 0.0
---------- 28.10.2019 11:46:11.155518 --------------------
steering_angle: -0.25
steering_angle_velocity: 0.0
speed: 0.5
acceleration: 0.0
jerk: 0.0

but the car doesn't move at all.
The topic is subscribed by one node: /car_1/control_plugin
I will appreciate any help,
Karol

Hi Karol,
The most common reason for the race track to not appear is that the model files were not placed in the correct folders. We have provided more details about it here. Please check the directory of .gazebo/models/ to see if the race_track model exists. If not, copy the contents of the world directory in the git repo to the models directory. This should solve your first problem.
For the keyboard tele-operation, is the terminal from which the roslaunch command issued active on your screen? The terminal must be active to read keyboard events and forward them to the racecar.
Let me know if this works and I will update the wiki to emphasize the need to do this.

Varundev

That was it.
I missed the First Time Setup
The terminal had focus, but it wasn't working. Now it works ok.
Thank you so much!
Resolved.
BTW I plan to use this sim to teach students and create an online competition soon.


separate variable from eventListener

https://github.com/Whtneyas/web-app-from-scratch-2223/blob/c2c082fcd52b849a7b13a12ce6f1c37f4682d467/Bijbelversus/scripts.js#L8
separating the variable from the eventListener will help with readability

done


Properties with setter or getter implementation and [FieldProperty] should not compile

Expected
Compiler Error
Actual
undefined
Steps To Reproduce
Live Bridge
public class App
{
    [Ready]
    public static void Main()
    {
        var a = new A();

        Console.WriteLine(a.K); // undefined, should print 0 (not 7, see desc)
    }

    public class A
    {
        // compiler should fail to compile code where property is
        // marked as FieldProperty and have implementation of setter
        // and getter, because they will not be used as intended
        [FieldProperty]
        public int K
        {
            get { return 7; }
            set {}
        }
    }
}

@kcudnik, yes, thank you for this suggestion. It makes sense and we will implement it in 1.14 release.

Thanks for adding this feature!

Maybe generate a warning instead, so it wouldn't be a breaking change?

Thanks for the suggestion @TriEdgeAI. It makes sense to avoid breaking change. However, Bridge can be used through Console so that warnings can be missed. I think in this case we should throw an exception.

Implementation details:

If property has [FieldPropery] attribute but has a getter/setter implementation then the Compiler throws error like [Property TestApp.A.K] is marked with [FieldProperty] attribute but implements getter and setter. To fix the problem either remove [FieldProperty] (swith off bridge.json option autoPropertyToField) or add [External]/[Template] attributes;
The same thing when bridge.json option autoPropertyToField turned on.

Thanks for addressing this issue!


Where do custom directives belong?

I couldn't find anything in the guide about a best practice on this.  It seems a custom directive could be a plain old javascript file with the Vue.directive(...) syntax but I don't see a clear winner for its directory or is the best practice to simply put the registration in the default.vue layout?
Just wanting to use this in my project:
// Register a global custom directive called `v-focus`
Vue.directive('focus', {
  // When the bound element is inserted into the DOM...
  inserted: function (el) {
    // Focus the element
    el.focus()
  }
})

Thanks!

This question is available on Nuxt.js community (#c2708)

I'd tend to register directives in a plugin:
plugins/
├── directives.js

// nuxt.config.js
{
  plugins: [
    '~/plugins/directives.js'
  ]
}

Thanks @paulgv , I was considering that but there's a statement in https://nuxtjs.org/guide/plugins about these being run before the instantiating the root Vue application...do you think directives loaded before will still be recognized once the root Vue app is instantiated?

I did what you suggested, no problems I was was curious about with the root Vue instantiation.  @paulgv, do you think it would be worth a little statement in the guide (https://nuxtjs.org/guide/directory-structure) or README's about what to do with directives?

It might be nice to have some more examples on what you can do in plugins (register mixins, filters, directives, etc.) for sure :)

oh good, I'm glad you think that.  What can I/we do to ensure something like this is added?

The best way would be to fork https://github.com/nuxt/docs and add your examples to the plugins guide, then you can submit a PR to the main repo.

ok @paulgv , that makes sense and it looks like running it locally isn't difficult.  I'll put this on my list to do.

hey @paulgv , I've started running into issues with the spa aspects of nuxt and am going to have to abandon nuxt for now.  Hopefully simply having this note here will help others in the future.  Thanks!


Add time format with "AM/PM"

While using this sqlite3 driver, we found it couldn't process time format with "am/pm" correctly.

Coverage remained the same at 63.874% when pulling 80fc01a8b0bab738040592abcff67704baa4f229 on ptsolmyr:master into cf7286f069c3ef596efcc87781a4653a2e7607bd on mattn:master.

Coverage remained the same at 63.874% when pulling 80fc01a8b0bab738040592abcff67704baa4f229 on ptsolmyr:master into cf7286f069c3ef596efcc87781a4653a2e7607bd on mattn:master.

Coverage remained the same at 63.874% when pulling 80fc01a8b0bab738040592abcff67704baa4f229 on ptsolmyr:master into cf7286f069c3ef596efcc87781a4653a2e7607bd on mattn:master.

sqlite3 doesn't handle time format strictly. So you can store time in any formats. I don't want to add code each times for someone want to add new format.

@mattn Please close.


It would be neat to have standard deviation for average measurements

(Maybe only in JSON/textual, not in the visual user interface)

Resolved in commit 91a940b