HBASE-25525 - WALKey Extended Attributes don't serialize to Replicati…

…onSink

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 46s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  4s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 44s
the patch passed

-1 :x:
checkstyle
1m 32s
hbase-server: The patch generated 5 new + 10 unchanged - 0 fixed = 15 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 39s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

-1 :x:
findbugs
2m 59s
hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
109m 12s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

151m 13s

Reason
Tests

FindBugs
module:hbase-server

Dead store to scopeBuilder in org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:[line 110]

Dead store to uuidBuilder in org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:[line 114]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2900

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 2b9d172be0d0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2900/out/precommit/personality/provided.sh

git revision
branch-1 / a819012

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/artifact/out/diff-checkstyle-hbase-server.txt

findbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/artifact/out/new-findbugs-hbase-server.html

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/testReport/

Max. process+thread count
3362 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 46s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  4s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 44s
the patch passed

-1 :x:
checkstyle
1m 32s
hbase-server: The patch generated 5 new + 10 unchanged - 0 fixed = 15 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 39s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

-1 :x:
findbugs
2m 59s
hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
109m 12s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

151m 13s

Reason
Tests

FindBugs
module:hbase-server

Dead store to scopeBuilder in org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:[line 110]

Dead store to uuidBuilder in org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:org.apache.hadoop.hbase.protobuf.ReplicationProtbufUtil.buildReplicateWALEntryRequest(WAL$Entry[], byte[], String, Path, Path)  At ReplicationProtbufUtil.java:[line 114]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2900

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 2b9d172be0d0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2900/out/precommit/personality/provided.sh

git revision
branch-1 / a819012

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/artifact/out/diff-checkstyle-hbase-server.txt

findbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/artifact/out/new-findbugs-hbase-server.html

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/testReport/

Max. process+thread count
3362 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 40s
branch-1 passed

+1 :green_heart:
compile
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 42s
branch-1 passed

+1 :green_heart:
shadedjars
3m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  2s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 43s
the patch passed

-1 :x:
checkstyle
1m 33s
hbase-server: The patch generated 6 new + 10 unchanged - 0 fixed = 16 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 40s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
2m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
116m 15s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

157m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2900

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7282b6e4629a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2900/out/precommit/personality/provided.sh

git revision
branch-1 / a819012

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/testReport/

Max. process+thread count
3438 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 40s
branch-1 passed

+1 :green_heart:
compile
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 42s
branch-1 passed

+1 :green_heart:
shadedjars
3m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  2s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 43s
the patch passed

-1 :x:
checkstyle
1m 33s
hbase-server: The patch generated 6 new + 10 unchanged - 0 fixed = 16 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 40s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
2m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
116m 15s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

157m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2900

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7282b6e4629a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2900/out/precommit/personality/provided.sh

git revision
branch-1 / a819012

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/testReport/

Max. process+thread count
3438 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bharathv - fixed the checkstyle errors (unused imports) and added a simple test.

@bharathv - fixed the checkstyle errors (unused imports) and added a simple test.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 42s
branch-1 passed

+1 :green_heart:
compile
0m 39s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  3s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 58s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
2m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
110m  8s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

151m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2900

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b6169680167f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2900/out/precommit/personality/provided.sh

git revision
branch-1 / a819012

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/3/testReport/

Max. process+thread count
3443 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 42s
branch-1 passed

+1 :green_heart:
compile
0m 39s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  3s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 58s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
2m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
110m  8s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

151m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2900

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b6169680167f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2900/out/precommit/personality/provided.sh

git revision
branch-1 / a819012

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/3/testReport/

Max. process+thread count
3443 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2900/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Fixing the NhsdOds Organisation tests

Fixing the organisation tests.

Added in the CodeSystems for the organisation meta data


[Add] trivy

Site URL
https://trivy.dev/
Description of the above provided site
add
Category
Cyber Security
Sub Category
Web Security
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

added to project


save_to doesn't work properly with redirects

I should start of by saying I am using Guzzle 5, not sure if this issue also exists in v6.
The problem I am having is that the save_to request option does not work properly when the page you are requesting is a redirect. It also behaves differently depending on what type of value you pass to it.
For instance, say I have my web server set up to redirect /hello.html to /world.html. Now if I use Guzzle to download that page to a file by passing a file resource like so:
$test = fopen('C:\dev\test.html', 'w');
$client->get('http://<IP_ADDRESS>/hello.html', ['save_to' => $test]);

Then the get call will throw an exception saying save_to must be a GuzzleHttp\Stream\StreamInterface or resource. This only happens when there is a redirect, the exact same code works fine if there is no redirect.
If, instead of a file resource, I pass a Guzzle Stream, like this:
$test = fopen('C:\dev\test.html', 'w');
$stream = Stream::factory($test);
$client->get('http://<IP_ADDRESS>/hello.html', ['save_to' => $stream]);

Then I don't get an exception, and it almost all works properly, but it writes the redirect body to the output file before writing the actual response body. So if the response has a shorter body then the redirect, some of the redirect's body will be left over. For example, here is my test.html file when my original world.html file contained only world. As you can see, the proper response was written to the beginning, but there is leftover garbage from when the redirect body was written to it:
world/DTD HTML 2.0//EN">

<title>301 Moved Permanently</title>

Moved Permanently

The document has moved <a href="http://<IP_ADDRESS>/world.html">here.

<address>Apache/2.4.17 (Win32) OpenSSL/1.0.2d PHP/5.6.23 Server at <IP_ADDRESS> Port 80</address>

Finally, if I pass just the path to the file as a string, like so:
$client->get('http://<IP_ADDRESS>/hello.html', ['save_to' => 'C:\dev\test.html']);

Then it behaves properly, only writing the contents of world.html to test.html.

Well, the exception seems to be weird.
About redirection: have you enabled following redirection?

Doesn't Guzzle follow redirects automatically? And it is following the redirects, if I debug it I can see it get the first response, process it as a redirect, then try to follow the redirect, which is where it crashes in the first scenario. It looks like something causes the file resource to become an unknown resource type rather than a stream after the redirect response is processed, which causes the exception.

Same with me

After some debugging I found out that when guzzle uses fopen for request execution it doesn't find Location header. Installing cURL resolved the issue.


merge

NOTE
Please verify that the base repository above has the intended destination!
Github by default opens Pull Requests against the parent of a forked repository.
If this is your personal fork and you didn't intend to open a PR for contribution
to the original project then adjust the base repository accordingly.

lol sorry, a mistake


Questions on legality

Hey, thanks for making this awesome little project! Me and my friends have played a few games and we all find it pretty neat. However, I question the legality of hosting the UNO card game myself. I haven't been able to find any online resources that say it one way or another. According to some sites, only the "UNO" brand name can be copyrighted, and someone hosting it would have to remove the name but could keep the gameplay mechanics. I would appreciate any knowledge that you all have on this subject. Thanks again for the fun game! :)

Hey @onkoe! I really appreciate your feedback :)
Since I've started this project, I've tried to look forward informations about the legality and being honest I've got the same info that you said:

Only the "UNO" brand name can be copyrighted, and someone hosting it would have to remove the name but could keep the gameplay mechanics

Another thing that could involve copyright issues would be using the same card pictures they already use in the original game (being minded about it, my friend created the card pictures that we are currently using on our game).
Being minded about it, in my opinion it will be really hard to get in some trouble with legality because we have much less players than the official game (so it will be hard to call a lot of attention to the brand owners in a way they would try something). So, in case we get in some trouble anytime, I think we just need to remove the "UNO" brand name from everything 😆


Cannot compile JSX files

My webpack.config.js
const path = require('path');
const merge = require('webpack-merge');

module.exports = (storybookBaseConfig, configType, defaultConfig) => ({
	...defaultConfig,
	module: {
		...defaultConfig.module,
		rules: [
			...defaultConfig.module.rules,
			{
				test: /\.jsx?$/,
				loaders: ['babel-loader', require.resolve('@storybook/addon-storysource/loader')],
				include: [path.resolve(__dirname, '../src/stories'), path.resolve(__dirname, '../src/components')],
				enforce: 'pre'
			}
		]
	},
	resolve: {
    ...defaultConfig.resolve,
    extensions: ['.jsx','.js', ...defaultConfig.resolve.extensions],
  }
});

My src/stories/components/button.js
import React from 'react';
import { storiesOf } from '@storybook/react';
import { action } from '@storybook/addon-actions';
import { withInfo } from '@storybook/addon-info';
import { withKnobs, boolean } from '@storybook/addon-knobs/react';
import Button from '../../components/button.jsx';

const stories = storiesOf('Button', module);

// Add the `withKnobs` decorator to add knobs support to your stories.
// You can also configure `withKnobs` as a global decorator.
stories.addDecorator(withKnobs);

stories.add('Basic Button', withInfo()(() => <Button onClick={action('clicked')}>Hello Button</Button>));
stories.add('Basic Disabled Button', withInfo()(() => <Button disabled={boolean('Disabled', true)} onClick={action('clicked')}>Hello Button</Button>));
stories.add(
	'Basic Button With Emoji',
	withInfo()(() => (
		<Button onClick={action('clicked')}>
			<span role="img" aria-label="so cool">
				Cool 😎
			</span>
		</Button>
	))
);

My src/components/button.jsx
import React from 'react';
import PropTypes from 'prop-types';
import '../styles/components/index.scss';

/** Button component description imported from comments inside the component file */
const Button = ({ children, onClick, disabled }) => (
	<button type="button" onClick={onClick} disabled={disabled}>
		{children}
	</button>
);

Button.defaultProps = {
  children: '',
  disabled: false,
	onClick: () => {}
};

Button.propTypes = {
	/** button label. */
	children: PropTypes.string.isRequired,
	/** onClick handler */
	onClick: PropTypes.func,
	/** disable flag */
	disabled: PropTypes.bool
};

export default Button;

The error which I am getting is
`
ERROR in ./src/components/button.jsx 7:1
Module parse failed: Unexpected token (7:1)
You may need an appropriate loader to handle this file type.
| /** Button component description imported from comments inside the component file */
| const Button = ({ children, onClick, disabled }) => (

  <button type="button" onClick={onClick} disabled={disabled}>

|               {children}
|
@ ./src/stories/components/button.js 6:0-49 16:2-8 23:2-8 30:2-8
@ ./src/stories/components sync .js$
@ ./.storybook-react/config.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook-react/config.js (webpack)-hot-middleware/client.js?reload=true
`

@storybook/react ^4.0.0-alpha.16
@storybook/addon-[anything] ^4.0.0-alpha.16

Does it happen without addon-storysource configured?

Same problem
https://gist.github.com/ASnow/b3489e674c91c3d61d8b466f5619979b
Possible problem area - babel v7

@igor-dv I removed require.resolve('@storybook/addon-storysource/loader') from loader array and still getting error.
PS: I don't have any .babelrc in my app or in my .storybook folder.

In my case prolem was in webpack.config.js.
Add next line into /node_modules/@storybook/core/dist/server/loadCustomWebpackConfig.js:108 file:
console.log(e);

When you start it will show error in console if something wrong.

I'm having the same problem. If I import a file with .jsx extension, I will get the unexpected token error, but it works if I change the extension to .js

What kind of file? Do you have a webpack.config.jsx ?

This commit seems to have removed /\.jsx?$/ in favor of just /\.js$/ (notice missing x?) 4652a292c27209116904c70c9ea521e79be2f90b.
Might not be it, but custom webpack config, fishing out the babel-loader rule and doing this fixes it: babelRule.test = /\.jsx?$/;

I will bring it back

same problem.
Webpack version is 4.2.0.
@storybook/react ^4.0.0-alpha.16

The jsx is back to the core. It will be in the next release.

@igor-dv
I`ve updated to alpha.18, seems like everything is ok.

I'm still seeing this issue with a similar setup to above(Using 4.0.7 for all storybook packages). Fails when using the -o argument. Let me know if I should create a separate ticket or provide information here.


Support more languages

Any chance to support M$ PowerShell and VBScript in one of the next releases?

In v3.0 or 3.1 :)

please support Golang, too.=)

of course!

Thank you so much =)

Go language support is ready :)

Powershell experimental support is added to v3.0

VisualBasic NET and Classic are added:

look here https://github.com/AndiDittrich/WordPress.Enlighter/issues/37
but i think i can add a special R highlighting set to v3

@AndiDittrich Any rough plans when R support/v3 will be available? Right now we´re using your script on our wordpress site with a lot of R code (http://www.neo.uni-jena.de/2016/11/01/polygon-fishnet-with-custom-rowcolumn-count/ - It would be really cool to have R support in the near future :)

I hope i can release v3 in Q1-2017.
The biggest problem on creating new language support files are demo/language example files which cover all possible language syntax elements.
if you like to contribute you may can create such demo file like http://enlighterjs.org/v3/golang.html

I'd love to see support for Typescript ;)

Definitely Typescript and JavaScript (ES6 and newer).

Then Sass and SCSS don't work well with the latest version. It has a problem with this code:
`.parent {
color: #000;
background: #ccc;
&--child-one {
    color: #4e4e4e;
}

&--child-two {
    color: #g5g5g5;
}

}`

@zacol EnlighterJS v3 is not released yet. it is currently only available as closed beta.

Sorry 👍

Please support Kotlin ~~

Thank you!
any chance to see MS-DOS one day?

ms-dos, seriously ? it's not a real "language"...

shell is not a real language either however it's in the list

shell/bash are full featured scripting languages. ms-dos isn't.
maybe you mean dos compatible "batch/bat" files ?

@AndiDittrich, Almost 2 years ago you announced that you had added support for Visual Basic.  Did this ever make it into a released version?  I'm not seeing it in the version I got through WordPress and I wasn't able to find language support definition for it in the source either.

EnlighterJS v3 is not release yet, sry
50% of the themes are missing - everything else has been finished :(

Good@! keep up the good work@
@brianekins You could do as I did, take some of your own time and pull a request with modified files with your language. It didn't took me much time to understand how to find out which file to update, properly modify the code, pull the request, but the overall process takes some time I must confess.
This way you can help yourself, and help the community.
And to go faster, peak at the keywords used in another dev that does the same job ;) I peaked at Highlighter.js... It helped aloooot. I shouldn't admit such an embarrassment I know ;)

VisualBasic NET and Classic are added:

No .. it is not.

it is.... https://github.com/EnlighterJS/EnlighterJS/blob/master/src/lang/visual-basic.js


Restrict protobuf gem version and bump version

Protobuf https://github.com/ruby-protobuf/protobuf just bumped their version of multi_json, which is causing problems with Compass. Temporarily restrict version

looks like you got it already


Method VideoInput is not a registered operator

I use Pre-Built Binaries to install Caffe2 (conda install -c caffe2 caffe2-cuda8.0-cudnn7). During feature extraction, I get an error as following. Why is VideoInput not registered?
Traceback (most recent call last):
File "tools/extract_features.py", line 292, in
main()
File "tools/extract_features.py", line 287, in main
ExtractFeatures(args)
File "tools/extract_features.py", line 118, in ExtractFeatures
devices=gpus,
File "/home/dujiajun/anaconda2/envs/caffe2/lib/python2.7/site-packages/caffe2/python/data_parallel_model.py", line 32, in Parallelize_GPU
Parallelize(*args, **kwargs)
File "/home/dujiajun/anaconda2/envs/caffe2/lib/python2.7/site-packages/caffe2/python/data_parallel_model.py", line 208, in Parallelize
input_builder_fun(model_helper_obj)
File "tools/extract_features.py", line 94, in input_fn
use_local_file=args.use_local_file,
File "/home/dujiajun/R2Plus1D/lib/utils/model_helper.py", line 120, in AddVideoInput
data, label, video_id = model.net.VideoInput(
File "/home/dujiajun/anaconda2/envs/caffe2/lib/python2.7/site-packages/caffe2/python/core.py", line 2067, in getattr
",".join(workspace.C.nearby_opnames(op_type)) + ']'
AttributeError: Method VideoInput is not a registered operator. Did you mean: []

Make sure that you compile caffe2 correctly and set the LIBRARY_PATH and PYTHON_PATH correctly point to caffe2. Please check https://caffe2.ai/docs/faq.html


Feature/deployment concurrency

What issue type does this pull request address?
/kind enhancement
/kind feature
What does this pull request do? Which issues does it resolve?
Enables deployments to opt into deploying concurrently in order to improve performance for configs with many deployments.
resolves #1877
We did some tests with a modified version of examples/quickstart and found a roughly 35% - 50% reduction in deployment time. The more deployments, the greater the improvement.

3 concurrent vs 3 sequential deployments saw ~35% reduction in time.
6 concurrent vs 6 sequential deployments saw ~50% reduction in time.

Please provide a short message that should be published in the DevSpace release notes
Allow select deployments to deploy concurrently by setting concurrent: true.
What else do we need to know?
The logging was changed to resemble how concurrent image build logs are handled. We attempted to capture the effect the sequential deploys get from using StartWait but this is something we were less certain about.
Example snippet of logging output:
[redis] Done: Successfully deployed redis with helm
[pgsql] Done: Deployed helm chart (Release revision: 1)
[pgsql] Done: Successfully deployed pgsql with helm
[wait] ⠋ Deploying 2 deployments concurrently (13s)

Something we didn't love but are not sure how to address is that as the number of remaining deployments decrements a new StartWait call is made and therefore the count of seconds starts back at 0.
We also wanted to wait for feedback before updating any documentation and will certainly do this if/when things are looking good :D

@erikkrieg Thanks a lot for the PR! :)

It'll also help if you could add an e2e test for this feature. You can refer to some existing e2e tests under ./e2e/tests/deploy and add a new one to the same dir. @FabianKramm WDYT?

Thanks for the suggestion @pratikjagrut
I just added some e2e tests for both all concurrent and some concurrent some sequential.
I also included some vscode config to run e2e, similar to what vcluster has. Let me know if you prefer that specific part to be in a different PR since it's not really related to this PR.

I also included some vscode config to run e2e, similar to what vcluster has. Let me know if you prefer that specific part to be in a different PR since it's not really related to this PR.

Personally, I would have prefered separate PR for this change as it is not an intrinsic part of this feature.

Included documentation. Feeling pretty good about most of it but not sure whether the warning about an edge case with Helm hooks and concurrency is too specific or not.

Thanks, @FabianKramm and @pratikjagrut!


error case

print(w2n.word_to_num("two hundred twenty two million and two hundred twenty two thousand point three"))
returns 222222002.3
expected 222222000.3

Thanks for pointing this out. I will look into this ASAP.
Meanwhile, you're also welcome to fix the error and submit a Pull Request. If it passes all the tests, it will be merged most probably.


subscribe

Steps to reproduce: Adapt fly_mission.cpp of examples to use MissionRaw and push back 1 waypoint. Start mission and subscribe to MissionProgress.
Expected Results: As soon as the first and only waypoint is reached The MissionProgress Callback is called once when the waypoint is reached to confirm this.
Actual Result: MissionProgress is called multiple times with different ooutput messages, even though the vehicle stopsat the waypoin.
Arming...
[08:35:23|Debug] MAVLink: info: Armed by external command (system_impl.cpp:250)
Armed.


No styles on 'File Input' form element

The styles seems to be broken on the 'File Input' form element.
Here's screenshots from the documentation page:
Firefox

Chrome

The index page references to an input-file class that doesn't exist though: https://github.com/twitter/bootstrap/blob/gh-pages/index.html#L1165

Also, there's plenty of content out there that shows that file upload boxes most certainly can be styled. The Blueimp file upload pluging/library, which runs on top of jquery and uses Bootstrap, does just that.
There's no practical reason why file upload buttons styling can not be part of Bootstrap.


yubikey-manager: fix build

Motivation for this change
Closes: #154673
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

fixes #154673

Result of nixpkgs-review pr 154675 run on x86_64-linux 1

4 packages built:

gen-oath-safe
yubikey-manager
yubikey-manager-qt
yubioath-desktop

tested the gui, detected my yubikey, everything worked as expected.


Feature: Adding Footer

I would like to add a footer.

Can you assign this issue to me under hacktoberfest

@Kritika30032002


Adding nifty-renderer-processing to nifty

Implementation of RenderDevice and InputSystem for Processing 2.*
A simple implementation of RenderDevice for Processing wrapped around the Java2D renderer, but using Processing's own VLW bitmap font format. Also included is an implementation of InputSystem for Processing's proprietary input event classes.
I also needed to change access of AwtToNiftyKeyCodeConverter in the Java2D renderer package to public for use in implementing the input system. Let me know if this is okay.

Are the eclipse files necessary?

Oh, not really. I'll add them to .gitignore - sorry about that.

@void256 Why has this PR been sitting here for so long?

Waaaah! I think I agreed with spaceemotion that the eclipse files shouldn't be part of the commit .. and then somehow didn't notice barefists changes!
My apologies!

I am still noticing eclipse files in the nifty-minim-soundsystem directory. Also, mvn clean install is not running from the project root. Claims it cannot find that new soundsystem module. Might be my setup though. Investigating.

argh :smile: already cleaned that up too!

Seems processing is gradually depreciating Java2D over JavaFX in the latest 3.0.1 version. Guess it's time to revise the Processing renderer to better support the changes. If you are trying to use the current renderer in 3.0.1, you'll run into issues, it still works well for 2.2.1 though.


Initial Configs Changes for Spanish

I rule and have completed some work on Case Manager that's ready for review!
This is the start of some work on the Configs pages to translate them into Spanish
This pull request makes the following changes:

Changes to config index template
Changes to _config template
Supporting keys in es, en locales

@colinxfleming @lomky I got a few things started, but I'm kinda not sure what to do about the key stuff (that I think is loaded from the db). Open to ideas, thoughts before I move forward.
It relates to the following issue #s:

Bumps #1382

We can frankly probably live without config key names off the bat, so I think we can figure that out later and/or write a mapping of some kind down the road.

@colinxfleming hi! Can I get a screenshot of the english version of this translation, please? Just need a reference point since this one is a little longer. Thank you!

@colinxfleming made a couple of edits. Here yah go! https://docs.google.com/document/d/1OswVVCbIao6PabVlSArhYDiihKUNRPRrYi6ayQbbs1A/edit?usp=sharing

@montanezp this is after changing the keys to what you put in the doc, I'm holding off on some of the config keys based on the convo with @colinxfleming in here (making those changes is a bit more involved than most of the other translation stuff). The button looks wonky to me (mainly because I kept the key in there). Do you want me to take the key out completely?
It would go from:
Opciones para el compromiso externo %{option}, (por favor separe con comas)
to:
Opciones para el compromiso externo, (por favor separe con comas)


#3.02U

Cosmetic changes

__GHOSTV version disabled. Now instead is __NETV (v0x76C2) working with newer CXX Standards (__NETV > CXX20 > CXX23)


Location does not work

What the title says. I enable location in settings, expecting to see the current location's weather in the main screen (leftmost tab). The main screen stays completely blank for me. Setting locations manually works, though.

Do you have Google services on your phone?

Yes, there is a standard GApps installation on the phone. I also tried with my tablet (MicroG and open source location services, older Android version), and there are actually no problems there, location works.

Same issue with Android 12 and microG, other apps do not have problems, this one seems to request access for a second or two, then from the notification bar the "Location in use" indicator disappears, and reappears for other two seconds after a while, and so on

I will try to fix it by the next update.

Looks like there is some return value that should be checked if it's null.
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Null check operator used on a null value
#0      ItemScrollController.scrollTo (package:scrollable_positioned_list/src/scrollable_positioned_list.dart:254)
#1      LocationController.readCache.<anonymous closure> (package:rain/app/controller/controller.dart:210)
#2      new Future.delayed.<anonymous closure> (dart:async/future.dart:427)
#3      Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18)
#4      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398)
#5      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189)

This error does not affect the location search in any way.

Can you see if everything works fine in this version?

Tried the ARM8 / FOSS version and location works as it should. Do you want me to try the GMS version, too? Otherwise this one can be closed from my side. Thanks a lot, this version seems to be improved in other aspects, too. I like it a lot!

You don't have to try the gms version. Thanks for checking.

I tried the FOSS version too, and for me it still searches for the location for a second, then gives up and loads indefinitely. Does it matter if it's the release or just the armv8?

I tried the FOSS version too, and for me it still searches for the location for a second, then gives up and loads indefinitely. Does it matter if it's the release or just the armv8?

To be honest, I do not know, I am fixing the location search error blindly, since in previous versions I did not have any problems with this.

#97


Not receiving TestPyPI verification emails

Similar to #4704 and #5957, I signed up for a test pypi account and have not received the verification emails I've tried to send a few times over the past two days. Email address is correct and it's not ending up in the spam folder. Test pypi username is gboeing.

Also experiencing this, test username is mattfriz. Tried gmail and custom domain, neither delivered and it is not ending up in spam.

I'm experiencing the same issue. Test username is skeletorXVI and email address is with a custom domain.


feat: add tool calling for cohere

Description
Adds function calling for Cohere integration in llama-index.
Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

@Anirudh31415926535 @harry-cohere is this good to go from your point of view?


gcs: not all  GcsBuilder configureables are supported in GcsBuilder.from_map

I'm not sure what is the guideline about from_map though.
Should it try to support all config methods in impl GcsBuilder? If yes I'm happy to send a small PR.

Sorry I wasn't looking at the latest code. They are indeed supported.


Accounts and Logins

Hey I noticed the Account links to this url - https://go.insane.codes/account/login how do I connect my Shopify login/account flow and can I access User information on the Client if they've logged in through Shopify? would be really interested to know how Shopify - Auth  is handled :)

Hey there @LeoSonnekus !
I'm not sure where you're seeing that URL being linked, but on the HULL demo it should be linking to here: https://shop.hull.dev/account/login
(password is hull-demo if you want to preview how it looks)
In any case, you will have to setup accounts yourself, as that's not currently something offered out of the box with HULL. In the demo, we're simply using the Shopify native theme to handle the account flow. We call this a "hybrid" approach, where your store is headless, but accounts are native.
In the near future I plan to have a headless solution for accounts as well, but for now I'd suggest going the "hybrid" route or rolling your own custom headless solution.

Hey @ndimatteo
I thought that might be the case, hybrid sounds like a good approach.
I mostly ask because I'm migrating a Shopify store to headless in a few months that relies quite heavily on the Account ordering flow and just needed to see what the limitations are.
For my current project I have a login flow as a payment wall to access video courses on a blog like page structure that I've added alongside the e-commerce functionality so what I'm planning on doing is using all the features that Hull so generously has setup already and building a firebase + stripe based auth for the other services.
 I definitely think if you're wanting all the features that come with shopify user accounts, the hybrid approach will be great, as you'll get everything out of the box with them from that.
Rolling headless accounts for Shopify is a bit challenging from both a security standpoint and all the API requirements to manage all the different aspects (account info, shipping info, orders, etc).
Definitely will keepe everyone posted as we get closer to adding that into HULL! 🤘

In the demo, we're simply using the Shopify native theme to handle the account flow.

Hi Nick,
I visited the account flow on the demo site, it looks great and fits in with the HULL desgin. How did you customise the page layout? Is is defined in the 'theme.liquid' file?

Hey there @Brett-SustainedAffair!
The native "accounts" pages are part of the theme files that I modified a bit to better match the headless design.
The theme.liquid file is not where this is defined, as that file only handles which pages redirect to the headless side of things. You'll need to edit the associated theme template liquid files.
To match the styles, I simply copied over the compiled CSS from the headless side into the theme.css file in the Shopify theme assets file and then adjusted the HTML in the template files.
I hope that helps!

he theme.liquid file is not where this is defined, as that file only handles whic

Thanks for your reply Nick!
I have tried doing the same but this made some UI element render funny. I ended up editing the theme settings on a point-and-click basis in Shopify and managed to make the account page look just like HULL!

Hi, sorry to drop into a closed thread. I'm trying to use the Hybrid approach, but ever since I changed the DNS settings (A record) for the main domain to point to the new, custom storefront, links like domain.com/account now don't work and can't access the Native Shopify account screen and instead point to HULL's "404 not found" page.
How do I make an exception so that URLs like "/account" still point to Native Shopify?


Run Python File in Terminal and Run Line in Python Terminal Use the Same Terminal

When using Run Python File in Terminal and Run Selection/Line in Python Terminal they use the same terminal yet the former expects a terminal and calls python current_file.py and the latter expects a Python REPL.

Environment data

VS Code version: 1.24.1
Extension version (available under the Extensions sidebar): 2018.6.0
OS and version: macOS High Sierra
Python version (& distribution if applicable, e.g. Anaconda): 3.6.5
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: -none-

Actual behavior
/Users/bnord/git/project/env/bin/python /Users/bnord/git/project/src/playground.py is passed to the Python REPL raising a Syntax Error.
Expected  behavior
Either execute the file in the REPL using exec or use a different terminal to run files.
Steps to reproduce:

Create and open a Python file e.g. test.py
Enter a line of python code e.g. print('Hello World')
Run Run Selection/Line in Python Terminal
Save the file
Run Run Python File in Terminal

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
source /Users/bnord/git/project/env/bin/activate
/Users/bnord/git/project/env/bin/python
➜  project git:(master) ✗ source /Users/bnord/git/project/env/bin/activate
(env) ➜  project git:(master) ✗ /Users/bnord/git/project/env/bin/python
Python 3.6.5 (default, Jun 17 2018, 12:13:06)
[GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> print('Hello World')
Hello World
>>> /Users/bnord/git/project/env/bin/python /Users/bnord/git/project/src/test.py
  File "<stdin>", line 1
    /Users/bnord/git/project/env/bin/python /Users/bnord/git/project/src/test.py
    ^
SyntaxError: invalid syntax
>>>

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
empty

This is by design. If we use new terminals, for each of those, then users would complain about new terminals being created instead of re-using them. In fact that's what used to happen in the past.
Related issue https://github.com/Microsoft/vscode-python/issues/85

@DonJayamanne I don't suggest creating new terminals each time. Those two features require two fundamentally different types of terminals so each command should either make sure to put the terminal in the appropriate state (which I don't think is desirable) or have two distinct terminals for this. I don't think users would complain about two terminals being created if they use two features that require two types of terminals.
This is different from issue #85 as the terminal was not manually put into an incompatible state by the user.


Allow DQL search or publish parsing library to generate query from DQL

Is your feature request related to a problem? Please describe.
Searching using OpenSearch API requires a lot of documentation reading  and requires to find samples ending often in copy pasting without really understanding why the query is formatted this way.
The documentation is there but split into dozens of pages due to how complex query can be, this result in making simple query unnecessarily complex to write.
OpenSearch already have DQL that would simplify greatly these requests.
Exemple of a simple DQL query with the complex result in JSON:
system.last_assessment>"2022-08-21T23:15:13.570Z" and version>2 and system.status:P2

{
  "query": {
    "bool": {
      "must": [],
      "filter": [
        {
          "bool": {
            "filter": [
              {
                "bool": {
                  "should": [
                    {
                      "range": {
                        "system.last_assessment": {
                          "gt": "2022-08-21T23:15:13.570Z",
                          "time_zone": "Australia/Sydney"
                        }
                      }
                    }
                  ],
                  "minimum_should_match": 1
                }
              },
              {
                "bool": {
                  "filter": [
                    {
                      "bool": {
                        "should": [{ "range": { "version": { "gt": 2 } } }],
                        "minimum_should_match": 1
                      }
                    },
                    {
                      "bool": {
                        "should": [{ "match": { "system.status": "P2" } }],
                        "minimum_should_match": 1
                      }
                    }
                  ]
                }
              }
            ]
          }
        }
      ],
      "should": [],
      "must_not": []
    }
  }
}

Describe the solution you'd like
Export existing DQL parser as an npm library to allow DQL integration to any frontend application.
Or
Having a new type of full-text search query_dsl that will take a DQL (or alike) query and does the parsing and search in the backend would simplify future integration with OpenSearch as the learning required to learn DQL is way smaller than the current JSON implementation.
Exemple:
GET movies/_search
{
 "query": {
    "query_dsl": {
      "query": "actors:*Gadot  and release_date>\"2023-01-01T00:00:00.000Z\" and imdb_score>5"
    }
  }
}

Describe alternatives you've considered
query_string covers part of it but does not allow any comparators.
Additional context

DQL
Kuery (DQL Parser)

Just wanted to call out that query_string does have syntax for range queries, though it's a little clunkier.
Your example query would be:
GET movies/_search
{
 "query": {
    "query_dsl": {
      "query": "actors:*Gadot AND release_date:{\"2023-01-01T00:00:00.000Z\" TO *} AND imdb_score:{5 TO *}"
    }
  }
}

In general, though, a DQL query builder would be pretty nice.

In order to add this to OpenSearch itself, we would need a way to support the .peg grammar in Java in order to convert to OpenSearch QueryBuilder objects.
@austintlee suggested maybe separating the formal grammar from the Peggy implementation.
Basically:
formal grammar -> Peggy grammar (with suggestions) -> Javascript parser`

but also
formal grammar -> (some Java-friendly parser generator grammar, like ANTLR) -> Java parser

@Galardolind - would you be interested/willing to bring this issue up for discussion at OpenSearch Dashboards office hours? See https://www.meetup.com/opensearch/events/294620421/ for details.

Just wanted to call out that query_string does have syntax for range queries, though it's a little clunkier.

Would be great to have that in the query_string documentation, but agree too that DQL would simplify a lot more to the point that it is almost not necessary to learn something as it would be really close to natural language.

@Galardolind - would you be interested/willing to bring this issue up for discussion at OpenSearch Dashboards office hours? See https://www.meetup.com/opensearch/events/294620421/ for details.

Signed up, thanks for the suggestion 👍

A summary from the Dashboards office hours about this topic:
The reason for this request is because DQL is a veery simple language to use to search with, its desireable to have it accessible directly through an API as opposed to being only available through OSD's UI. There are a few ways to do this

Include it as a part of the core api for OS so that both OSD and other applications can use it
Add a new OS plugin that adds the DQL API so that other applications can use it. The downside here is thta since DQL is a part of the minimal distribution of OSD, unless it can be garaunteed in the min distrobution of OS too, we cant switch over to using the new API.
Move DQL to a new npm module. Downside being that its another package to maintain and separately keep up to date
Use PPL instead. This already has an API that does not need OSD to work.

Personally the easiest solution here is to see if PPL satisfies the requirements and if not look to see what the gap are. I also like the idea of moving DQL to core since it makes the backend easier to access with a simplified laguage that already support in Dashboards.
Would love to hear opinions from some of the maintainers of this repo about the solutions here. @nknize @dblock @andrross and even folks working on PPL @anirudha

In the Search Relevance community meeting, @lukas-vlcek made a really good point that Peggy (what DQL uses for its grammar) excels at offering contextual hints on errors and autocomplete suggestions.
If that part, plus the part that converts from DQL into query DSL, were made available to application developers to use in their frontend (essentially option 3 from @ashwin-pc's comment), it could provide a good "power-user" experience.
Adding DQL support to the OpenSearch backend (either as a core feature, a module, or a plugin) might be nice, but we probably wouldn't want to remove support from OSD, because of those nice Peggy features. At that point, we would need to maintain the Peggy JS implemented in OSD and some Java implementation in the backend and make sure their grammars are kept in sync (hence @austintlee's suggestion above of deriving both from some canonical grammar).

Hi, are there any plans to implement this in near future?


Issue 34 - Failed creation of a submission returns to form

Fixes issue 34, where
invalid create actions on the SubmissionsController would redirect
to the speakers index, instead of back to the form.
What does this PR do?
Currently, when a user tries to create an invalid submission (submission of a proposal, not a form submission), the app currently redirects them to the speakers index instead of back to the form.
This PR changes this flow so the user is redirect back to the submission creation form.
It also changes the spec for the SubmissionsController so that it tests not submissions with all invalid attributes, but submissions with all attributes invalid except for the proposal ID.
This PR does not test the case when all submitted attributes are invalid, because this actually opens questions about the SubmissionsController routing behavior: it displays Rails errors when the user accesses /submissions/new without a proposal ID URL attribute. (Issue 48 opened for this).
Why was this work done? Is there a related Issue?
Fixes issue 34; also part of 24 Pull Requests.
Where should a reviewer start?
The only changes are in the SubmissionsController and its spec file.
Worth noting, in the spec, the let(:proposal)... declaration was moved so it can be accessed in both contexts, and the invalid attrs context no longer uses an anonymous double because it needs a valid proposal attribute.
The additional expectation that the action should retain its proposal id (line 37) is technically redundant because the redirect expectation on line 36 already catches this, but feels useful in case something else happens to the URL structure.
Are there any manual testing steps?

(Add a speaker)
(Add a proposal for the speaker)
Create a submission for the proposal without selecting a "Accepted/Rejected" result
Confirm you are redirected back to the submission form

Screenshots
Deployment instructions
Database changes
New ENV variables

Closing because I just had to do some git-fu on my fork, will recreate in a second.


Save simulation results to CSV / MAT

Feature Request
Is there a (simple) way to save the simulation results to a *.csv or *.mat file? I couldn't find one.
I can create a DataFrame and save it myself, but it is very inconvenient. An API function would be very nice.
My Workaround
using FMI
using DataFrames
using CSV

outputVars = ["outputs[1]", "outputs[2]", "outputs[3]", "outputs[4]", "outputs[5]", "outputs[6]", "outputs[7]", "outputs[8]"]
result = fmiSimulate(fmu, 0.0, 10.0; recordValues=outputVars)

df = DataFrame(time = result.values.t)
for i in 1:length(result.values.saveval[1])
  df[!, Symbol(names[i])] = [val[i] for val in result.values.saveval]
end
CSV.write(resultFile, df)

We could add this as weak dependency using Requires.jl.
There is already a command fmiSaveSolution, we could make a "dispatch" for file formats other than JLD2 (only if MAT.jl or CSV.jl is imported).
I will add this soon.

@ThummeTo should I handle this or is it of rather low priority?

Julia 1.9 can now handle package extensions similar to Requires.jl:
https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

will be closed with #175


Scrolling disabled after close modals

When I click at picture it have 'MORE' button to open modal with bottom-sheet but after close modal I can't scrolling to anywhere. I don't know why it happened.
I reproduce issue here https://testtube.rayriffy.com/mat_issue

The overflow value is removed, see https://github.com/Dogfalo/materialize/blob/master/js/modal.js#L34-L38
I will try to find a fix.

Use the following code in the complete callback as workaround
$('body').css({
    overflow: 'visible'
});

@tomscholz should we set visible in the code at https://github.com/Dogfalo/materialize/blob/master/js/modal.js#L34-L38 as this is the default value in CSS?

Yes, problem resolved. Thanks

Closing issue

I have still problem with that.. what fix should I use, because here: https://github.com/Dogfalo/materialize/commit/41f04c33acb8a808224d5c673649a9e4e86901cd#diff-452a8aa82569876ba89deba84331011c I can see scrolling is reverted.

I'm using version 1.0.0 latest release and still have problem. overflow: hidden; is not removed when I'm closing the modal.


"no method slice of undefined" issue still exists when there is no TOC on an object.

Seems to have reappeared.  To duplicate, try one of these manifests:
http://scta.info/iiif/pp-sorb/manifest
http://scta.info/iiif/pdt-bnf14556/manifest
http://scta.info/iiif/pg-lon/manifest
http://scta.info/iiif/pl-bnf15705/manifest

All of these manifests have the property that they have dozens of ranges with no top-level range. This seems like a strange use of ranges, but I suppose it ought to be handled. We don't really have a design for multiple ranges yet though.
When we were first doing ranges and TOC, we made some "requirement" that there needed to be a top-level range. I have a design in mind for multiple ranges, but this use of ranges: no hierarchy and one page per range, seems like a misunderstanding of ranges.

Sadly, there doesn't seem to be any way to control this because the spec is fairly silent on the issue. 200 1-item ranges with no grouping is perfectly valid.

Hmm, so maybe I'm not quite understanding, but I think http://scta.info/iiif/pg-lon/manifest does have a top level.
First there is the top level range: "http://scta.info/iiif/pg-lon/range/r1" which includes under the canvas property includes all the canvases in array, like so:
"canvases": [
"http://scta.info/iiif/pg-lon/canvas/L11v",
"http://scta.info/iiif/pg-lon/canvas/L12r",
"http://scta.info/iiif/pg-lon/canvas/L12v",
"http://scta.info/iiif/pg-lon/canvas/L13r",
"http://scta.info/iiif/pg-lon/canvas/L13v",
"http://scta.info/iiif/pg-lon/canvas/L14r",
"http://scta.info/iiif/pg-lon/canvas/L14v",
"http://scta.info/iiif/pg-lon/canvas/L15r",
"http://scta.info/iiif/pg-lon/canvas/L15v",
"http://scta.info/iiif/pg-lon/canvas/L16r",
"http://scta.info/iiif/pg-lon/canvas/L16v",
"http://scta.info/iiif/pg-lon/canvas/L17r",
"http://scta.info/iiif/pg-lon/canvas/L17v",
....
and so on.
Then there is a sub level range that identifies itself with the top level range, like so:
{
"@id": "http://scta.info/iiif/pg-lon/range/r1-1",
"within": "http://scta.info/iiif/pg-lon/range/r1",
"@type": "sc:Range",
"label": "Quaestio 1",
"viewingHint": "top",
"canvases": [
"http://scta.info/iiif/pg-lon/canvas/L11v",
"http://scta.info/iiif/pg-lon/canvas/L12r",
"http://scta.info/iiif/pg-lon/canvas/L12v",
"http://scta.info/iiif/pg-lon/canvas/L13r",
"http://scta.info/iiif/pg-lon/canvas/L13v",
"http://scta.info/iiif/pg-lon/canvas/L14r",
"http://scta.info/iiif/pg-lon/canvas/L14v",
"http://scta.info/iiif/pg-lon/canvas/L15r"
]
},
Is this wrong? It seems correct and its validating perfectly. However, when you click on a given range label, no navigation occurs.
Whereas navigation for this manifest http://scta.info/iiif/pp-sorb/manifest works well.
Disregard
http://scta.info/iiif/pl-bnf15705/manifest
http://scta.info/iiif/pl-bnf15705/manifest
because these aren't validating.

This is happening because mirador is having trouble building the bottom panel on the first focused image of the range when it is loaded, and usually only when there is one range to load (with no parent, just one range.).
I had to alter toc.js to allow for there to be a range with no parents:
In the init in toc.js:
this.element = jQuery(this.template({ ranges: this.getTplData() })).appendTo(this.appendTo);
has trouble because getTplData() does this:
ranges = _this.extractRangeTrees(_this.ranges)
if (ranges.length < 2) {
ranges = ranges[0].children; //Why do this?  It doesn't make sense here.
}
return ranges;
This usually causes ranges to be null which I believe causes the 'splice of undefined' error down the road when building out the bottom panel.  ranges is an array of range objects.  Even if the length is 1, we still want an array of one range object to be returned, so there is no need to alter ranges. I commented out if(ranges.length<2){...} block of code, and everything seems to be running smoothly.  I have two ranges that are disconnected without parents that both load to the view and can be navigated to and navigated through and I do not have the 'splice of undefined' error anymore and the bottom panel thumbnail images load (and to connect this with my previous work, even when they are non-IIIF images and thumbnails are not defined with the object).

@jeffreycwitt I am looking into this some more.  For http://scta.info/iiif/pg-lon/manifest, I think the issue is that you don't have individual leaf nodes for each canvas that is in a range.
For example, you have the range:
{
 @id: "http://scta.info/iiif/pg-lon/range/r1-1",
 within: "http://scta.info/iiif/pg-lon/range/r1",
 @type: "sc:Range",
 label: "Quaestio 1",
 canvases: [
  "http://scta.info/iiif/pg-lon/canvas/L11v",
  "http://scta.info/iiif/pg-lon/canvas/L12r",
  "http://scta.info/iiif/pg-lon/canvas/L12v",
  "http://scta.info/iiif/pg-lon/canvas/L13r",
  "http://scta.info/iiif/pg-lon/canvas/L13v",
  "http://scta.info/iiif/pg-lon/canvas/L14r",
  "http://scta.info/iiif/pg-lon/canvas/L14v",
  "http://scta.info/iiif/pg-lon/canvas/L15r"
 ]
}

But there needs to be a range for each canvas that indicates that it is within the higher level range.  So something like:
{
 @id: "http://scta.info/iiif/pg-lon/range/r1-1-1",
 within: "http://scta.info/iiif/pg-lon/range/r1-1",
 @type: "sc:Range",
 label: "L11v",
 canvases: [
  "http://scta.info/iiif/pg-lon/canvas/L11v"
 ]
},
{
 @id: "http://scta.info/iiif/pg-lon/range/r1-1-2",
 within: "http://scta.info/iiif/pg-lon/range/r1-1",
 @type: "sc:Range",
 label: "L12r",
 canvases: [
  "http://scta.info/iiif/pg-lon/canvas/L12r"
 ]
},
...

Mirador can then show which canvases belong to Quaestio 1 in the side panel, and have the canvas in the TOC can match the canvas in the bottom filmstrip while in ImageView.

That would be a bug in Mirador, however, rather than a requirement from the specification.  The top example is the way that ranges are intended and specified to work.
See: http://iiif.io/api/presentation/2.0/#ranges

I can try that, but a range for each canvas seems redundant. Isn't it kind of overkill to say that a canvas is a range composed of one canvas? What else could it be?
Anyway, it seems to work without problem in the universalviewer:
http://universalviewer.azurewebsites.net/?jsonp=false&testids=false&defaultToFullScreen=false&manifest=http%3A%2F%2Fscta.info%2Fiiif%2Fpg-lon%2Fmanifest&locale=en-GB#?c=0&m=0&s=0&cv=296&z=0.0136%2C-0.0395%2C1.9729%2C1.3826
It does seem to be very strange and elusive problem. Some ranges in some manifests seem to be working fine and others are not. But all of them are machine generated by the same code. So their different behavior is confusing.

I agree, I will make sure the TOC works with a valid range.  Adding leaf nodes will offer more functionality that is built into Mirador, but should not be necessary for the basic TOC to be viewable.

Actually, this has nothing to do with the leaf nodes.  There are some canvases that are not referenced in the range and the TOC code is trying to scroll to a non-existent range.  This will be fixed in master momentarily.

Awesome,
Thanks.
jw
Dr. Jeffrey C. Witt
Philosophy Department
Loyola University Maryland
4501 N. Charles St.
Baltimore, MD 21210
www.jeffreycwitt.com http://www.jeffreycwitt.com/
From:  Rashmi Singhal<EMAIL_ADDRESS>Reply-To:  IIIF/mirador
<reply+00117f3d82743f9381a538287ce60f575c03bf79ab2cc66692cf00000001122e50e89
<EMAIL_ADDRESS>Date:  Thursday, October 8, 2015 at 11:42 AM
To:  IIIF/mirador<EMAIL_ADDRESS>Cc:  Jeffrey Witt<EMAIL_ADDRESS>Subject:  Re: [mirador] "no method slice of undefined" issue still exists
when there is no TOC on an object.  (#190)
Actually, this has nothing to do with the leaf nodes.  There are some
canvases that are not referenced in the range and the TOC code is trying to
scroll to a non-existent range.  This will be fixed in master momentarily.

Reply to this email directly or view it on GitHub
https://github.com/IIIF/mirador/issues/190#issuecomment-146583094 .


Fix setup indicator LED to account for blocking I/O in setup functions

This PR makes the indicator LED behave more correctly in the firmware during setup. Previously, the indicator LED was using software PWM (assuming non-blocking I/O in the setup functions), while the setup functions themselves were using blocking I/O and blocking delays. Thus, the indicator LED wouldn't actually flash or blink during failure or setup. Now, setup phase has a solid on indicator LED, while failure blocks for flashing for ~2 seconds. Also, now the "setup succeeded" indicator is a slow blink for 2 seconds rather than a solid on.

This PR is in the critical path of development, passes clang-tidy and clang-format checks, is needed for to support hardware bring-up at Bharat Forge, is of at least comparable quality to the rest of the firmware codebase, and probably would not be able to find someone to review it very quickly. We will probably go back and refactor the affected sections of code anyways. I will merge in this PR now.
For records-keeping:

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
Were any of these contributions also part of work you did for an employer or a client? No
Does this work include, or is it based on, any third-party work which you did not create? No


Update maya CLI commands in the use-cases documentation

What happened:
Help document is updated with latest Maya Cli changes
What you expected to happen:
Update the use-case docs which will be having latest/updated volume CLI commands.
Volume related commands:
maya volume -h
Usage: maya volume <subcommand> [options] [args]

This command provides operations related to a Volume.

    Create a Volume:
    $ maya volume create -volname <vol> -size <size>

    List Volumes:
    $ maya volume list

    Delete a Volume:
    $ maya volume delete -volname <vol>

    Statistics of a Volume:
    $ maya volume stats <vol>

Subcommands:
    create    Creates a new Volume
    delete    Deletes a running Volume
    list      Display status information about Volume(s)
    stats     Displays runtime statistics of a Volume

Still open?

Thanks @abhisheklakra007 for pitching in.
@carolkng is looking into this.
I hope you will find another issue here to take on for Hacktoberfest :)


How to work with Shadows?

Stitches.dev core supports shadows as part of their theme object: https://stitches.dev/docs/tokens like:
shadows: {
  solidGrayLarge: `0px 0px 0 5px $gray400`
}

This css obviously won't work on react-native, because it expects an object like (see react-native-shadow-generator):
shadowColor: "#000",
shadowOffset: {
  width: 0,
  height: 9,
},
shadowOpacity: 0.48,
shadowRadius: 11.95,
elevation: 18,

and textShadowColor, textShadowOffset, textShadowRadius for Text.
Questions

Should we remove shadows from the types (see https://github.com/Temzasse/stitches-native/blob/main/src/types/core.d.ts#L115) given that it won't work one to one? Right now shadows is not being used
I see the value of having shadows being part of the underline theme, but... how can we support them?

I found this library that transforms css strings into RN styled-object https://github.com/styled-components/css-to-react-native/blob/4f96cf6bb81b48894b53bce041512d495de715ba/src/transforms/util.js#L47 but seem not longer maintained :/

@csantos1113 this is a very good question 🤔
The issue of shadows in RN is a particularly nasty one because of the whole mismatch between iOS and Android. There is basically no way to have unified looking shadows as part of the theme by providing a single token value because the shadows behave so differently on each platform (elevation system vs. proper customisable shadows).
What do you think, would it make sense to handle the shadows via utils since that way it is possible to change the returned style properties based on the platform?
import { Platform } from 'react-native';

const { ... } = createCss({
  utils: {
    shadow: () => (level: "small" | "medium" | "large") => {
      return {
        small:
          Platform.OS === "android"
            ? { elevation: 2 }
            : {
                shadowOffset: { width: 0, height: 1 },
                shadowRadius: 3,
                shadowOpacity: 0.1,
                shadowColor: "#000",
              },
        medium:
          Platform.OS === "android"
            ? { elevation: 5 }
            : {
                shadowOffset: { width: 0, height: 3 },
                shadowRadius: 6,
                shadowOpacity: 0.2,
                shadowColor: "#000",
              },
        large:
          Platform.OS === "android"
            ? { elevation: 10 }
            : {
                shadowOffset: { width: 0, height: 6 },
                shadowRadius: 12,
                shadowOpacity: 0.4,
                shadowColor: "#000",
              },
      }[level];
    },
  },
});

And then use it like this:
const Comp = styled('View', {
  shadow: 'large',
});

We could document this in the README with a comprehensive example like the one above.


Suggestions

Have the auto classify/summarise conversion request as an optional tickbox -- Personally I'd rather not waste credits on it being on. (and would prefer to edit the convo title myself)

Have the spoken text captured from the mic go into to textfield -- not auto submit -- so it can be adjusted incase of any transcription errors or reconsiderations after speaking -- rather than trying to re-speak the whole spiel again.

maybe have the max tokens also visible on the main area, so can adjust more quickly.   // maybe having an advanced and basic ui toggle.

With the API access, we have access to the system, assistant and user roles -- Being able to built the 'fake' prior context out of those roles would be useful. As is done in (https://platform.openai.com/playground?mode=chat)

Good stuff tho!

Hey Abul, I like 1 & 2 and have added them to my TODO. I will think about 3/4! I fear they might make the tool a bit complex/cluttered

1 is in main.

Hey Abul, I like 1 & 2 and have added them to my TODO. I will think about 3/4! I fear they might make the tool a bit complex/cluttered

How about having a "power user" toggle or "advanced settings" section that expands to show stuff like this?

2 is now live as well! :) For 3 I'd be open to PRs, maybe make it switchable in settings like you said. For 4 hmmm I think it would indeed be going far into a "Playground" area whereas I'm trying to keep this closer to a "product" like the main UI.

Although #2 works for Azure STT with "auto send text" unchecked, whisper still auto sends. I would have hoped it would follow the auto send rule.

On 4 - I found this option which allows customization of system prompt: https://github.com/cogentapps/chat-with-gpt


defineConfig MultiplyCompiler Type not export.

System Info

Details
MultiplyCompiler Type did not export, caused ts error.
Reproduce link
No response
Reproduce Steps
You can use a arrray to test type.
// rspack.config.ts
module.exports = [], // expect array shouldn't cause ts error.

@underfin Would you mind describing the correct behaviors or giving the related code link of Webpack repo?

Procedure to reproduce this issue:
Create a test.js under examples/library, with following content.
/** @type {import('@rspack/cli').Configuration} */
const test = [];
module.exports = test;

Expected
No validation error.
Actual
const test = []; fails to be validated, and displays error message.
Solution
Change the definition of type Configuration in packages/rspack/src/config/types.ts, to export type Configuration = MultiRspackOptions | RspackOptions;

@suica I'm not clear description the issue, here should be add MultiRspackOptions  for defineConfig.


chore: use optional chains

they're great.

since the original pr is approved I'll go forward with this.


popToRootViewControllerAnimated is wrong

method -(NSArray *)popToRootViewControllerAnimated: (BOOL)animated has theese issues:

It returns only n-1 controllers ( I don't count that one, which remains as root view controller )
First issue cause that for that one view controller that is not returned is not called method removeFromParentViewController
Returned view controllers are not returned in order that is should be returned ( it should be returned in order like if you pop every single controller, now it's in order it was added to navgiation controller )

cheers

Hey,
yes, you are right. The issues seem to have been introduced in the last PR. It should fixed here a1fb08b00b925dc56471a7ece4e6bbe8988833e3
Heiko

cool!


Support for overflow

Support for overflowing would be very useful,
especially when height: 100% has to be used on the parent (html, body) elements.
Thanks.
With best regards

We consider overflow to be somewhat of an anti-pattern, given spotty mobile support. Therefore, we probably won’t add this—sorry!
The readme does currently say: “This plugin does not support overflow on parent elements.”


[WIP] Use Serial/IDPATH to Identify Disk

What this PR does / why we need it:
part of #982
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #1058 (067e6e5) into main (56822dc) will decrease coverage by 0.09%.
Report is 16 commits behind head on main.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   42.36%   42.28%   -0.09%
==========================================
  Files          24       24
  Lines        1584     1587       +3
==========================================
  Hits          671      671
- Misses        842      845       +3
  Partials       71       71

Files Changed
Coverage Δ

...manager/builder/localdiskvolume/localdiskvolume.go
48.78% <0.00%> (-1.86%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AmazingPangWei cc~

@carlory cc~


File upload not working for me

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
setfilestoupload is not working
What is the expected behavior?
How would you reproduce the current behavior (if this is a bug)?
have an input field with type field
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code

Specify your

operating system:
testcafe version:
node.js version:

Hi @vigneshwar-v
I am afraid this information is not sufficient to find the cause of the issue. Could you please provide a page or a small example so that we can reproduce it on our side?

I will close the issue because no activity has been encountered for a long time.
Feel free to reopen the issue if the problem persists and you can provide an example to reproduce it.


Generate Report displays for non-logged in user

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to https://tttc-turbo.web.app/report/heal-michigan-edit-claims

Expected behavior
Generate Report does not display
Actual behavior
Generate report displays.
Screenshots

Done.