Upgrading Calico

Details
Describe the solution you'd like:
Document a way to upgrade Calico, for now the process can be done by running against an already provisioned cluster
kubectl apply -f https://projectcalico.docs.tigera.io/archive/v3.22/manifests/tigera-operator.yaml

After it is upgraded it is wise to manually bump the version in the Ansible config:
https://github.com/k8s-at-home/template-cluster-k3s/blob/63d077e1dd50cb0ae9af5c21d951bec1d78c60ad/provision/ansible/inventory/group_vars/kubernetes/k3s.yml#L31

Would using tigers operator be an acceptable solution? I can open a PR tomorrow if that's the case.
Example

I'm taking over tigera-operator with helm too but it's not ideal because you manually need to apply the helm ownership labels to the CRDs or else it will not install.

I would be more inclined to support the method of install Calico with the k3s HelmChart CRD and then take it over with a Flux HelmRelease but I haven't had time to explore this much

That's fair to want to support upgrades. Could also add a job to do the relabeling. I already havea a messy bash script I can clean up for use: https://github.com/h3mmy/bloopySphere/blob/main/fix-crd.sh

Combing through the process, using the k3s HelmChart just seems like it's adding an extra step since the relabeling would still need to be performed with a Patch or Job.

That's a bummer, I was hoping that it would add in the annotations for us.

I'll try a dry run when I'm able. Just want to make sure.

Right now this component is in limbo - it is not manged by either k3s or flux.
Could we perhaps apply the helm ownership labels to the tigera-operator manifest on the ansible side, when it is first deployed to the cluster?

I am not sure the best way forward to be honest, right now there's two methods:

Apply the new manifests with kubectl
kubectl apply -f https://projectcalico.docs.tigera.io/archive/v3.22/manifests/tigera-operator.yaml

Patch calico resources to add the helm ownership and then apply the HelmRelease or helm chart
kubectl patch installation default --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch installation default --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'
kubectl patch installation default --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'
kubectl patch podsecuritypolicy tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch podsecuritypolicy tigera-operator --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'
kubectl patch podsecuritypolicy tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'
kubectl patch -n tigera-operator deployment tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch -n tigera-operator deployment tigera-operator --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'
kubectl patch -n tigera-operator deployment tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'
kubectl patch -n tigera-operator serviceaccount tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch -n tigera-operator serviceaccount tigera-operator --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'
kubectl patch -n tigera-operator serviceaccount tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'
kubectl patch clusterrole tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch clusterrole tigera-operator --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'
kubectl patch clusterrole tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'
kubectl patch clusterrolebinding tigera-operator tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch clusterrolebinding tigera-operator tigera-operator --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'
kubectl patch clusterrolebinding tigera-operator tigera-operator --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'

Having a Ansible playbook just for applying the patches might be annoying to maintain moving forward, like calico adding another resource that needs to be patched or whatever.
Ideally I would like to switch to Cilium but I am dead set on them implementing BGP without metallb hacks before I consider it.

I was going to suggest scripting that to check what CRDs require patching and run a templated task. But that may be equally annoying to maintain. I'm hoping to switch to Cilium at some point as well. I'm currently trying to figure out how to transition the cluster to BGP first.

I had to do those as well
kubectl patch apiserver default --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-name": "tigera-operator"}}}'
kubectl patch apiserver default --type=merge -p '{"metadata": {"annotations": {"meta.helm.sh/release-namespace": "tigera-operator"}}}'
kubectl patch apiserver default --type=merge -p '{"metadata": {"labels": {"app.kubernetes.io/managed-by": "Helm"}}}'

Noting for anyone that stumbles onto this thread and has the following error when trying to kubectl apply -f a newer version
The CustomResourceDefinition "installations.operator.tigera.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

https://github.com/projectcalico/calico/issues/6491 You'll want to use kubectl replace since these are CRDs.


Allow "Tree Item" to Gray Out or Be Not Clickable

Our teams build a vs code extension to help developer create and deploy Microsoft Teams apps with integrated Identity, cloud storage, Microsoft Graph etc.
A developing lifecycle include create project, provision cloud resource, deploy resource, publish package. These lifecycle operations have dependency on each other. For example, "Provision Cloud Resource" is a long running operation, "Deploy Resource" is not allowed to be triggered during "Provision Cloud Resource".
The extension presents the lifecycle in the Tree View. See the left side screenshot. Once user click "Provision in the cloud", the provision process is running in the background, so the "Deploy to the cloud" tree view item should gray out, user is not able to click this item. We expected the behavior should similar to the right side screenshot.
So I am requesting add one more property called "disable" (or other name) in vscode.TreeItem . If disable == true, then the specified tree item will display as "Gray".

@alexr00 I see this issue was auto closed. Is there any plan to follow up this issue?


Android chip-tool crash during saving wifi credentials screen

Problem
Complied the master latest branch(JAVA 8), got the android chip-tool.
While chip-tool crash without any prompt during saving wifi credentials screen
<what's wrong or missing, please include any applicable:

expected behavior
Pairing process succeed
actual behavior
The pairing process did NOT start,   chip-tool crash after clicking "SAVE NETWORK".
steps to reproduce
Just normally follow the steps: "PROVISION CHIP DEVICE WITH WI-FI" -> "SUBMIT" -> "SAVE NETWORK". Then app crash without any prompt.
system configuration
oppo android phone
screenshots, images, logs, etc.

android chip-tool crash.log
Proposed Solution
<suggested fix, suggested enhancement>

The logs indicate this is a duplicate of https://github.com/project-chip/connectedhomeip/issues/21493 being worked on by @chrisdecenzo

Closed as the dup was closed.


N+1 integration test

[ ]  In this project, I create integration tests for all of the views used in the project to cover the user stories (or user workflows) that you want your users to experience while taking into consideration the possible errors your users may cause.
[ ]   Make sure that the N+1 problem is solved when fetching all posts and their comments for a user.

BEFORE

AFTER

Thank you @omarsalem7


WSL2: D3D12CreateDevice Check Failed

Windows: Build 20150.rs_prerelease.200612-1734
WSL2 kernel: 4.19.121-microsoft-WSL2-standard
Intel HD 630, Driver: <IP_ADDRESS>22
Radeon RX Vega M GH, Driver: <IP_ADDRESS>
GeForce RTX 2070, via Thunderbolt 3, Driver: 455.38

$ uname -a
Linux hades 4.19.121-microsoft-WSL2-standard #1 SMP Thu May 14 20:25:24 UTC 2020 x86_64 GNU/Linux
$ lspci
a087:00:00.0 3D controller: Microsoft Corporation Device 008e
ad33:00:00.0 3D controller: Microsoft Corporation Device 008e
addd:00:00.0 SCSI storage controller: Red Hat, Inc. Virtio filesystem (rev 01)
b7a1:00:00.0 3D controller: Microsoft Corporation Device 008e
b8b2:00:00.0 SCSI storage controller: Red Hat, Inc. Virtio filesystem (rev 01)
$ ls /usr/lib/wsl/lib
libcuda.so  libcuda.so.1  libcuda.so.1.1  libd3d12.so  libdirectml.so  libdxcore.so

$ conda --version
conda 4.8.3
$ python --version
Python 3.7.7
$ conda list | grep directml
# packages in environment at /home/username/.conda/envs/directml:
tensorflow-directml       1.15.3.dev200615          pypi_0    pypi

The code I was trying to run is the basic example from Tensorflow tutorials:
#!/usr/bin/env python

import tensorflow as tf

mnist = tf.keras.datasets.mnist

(x_train, y_train),(x_test, y_test) = mnist.load_data()
x_train, x_test = x_train / 255.0, x_test / 255.0

model = tf.keras.models.Sequential([
  tf.keras.layers.Flatten(input_shape=(28, 28)),
  tf.keras.layers.Dense(512, activation=tf.nn.relu),
  tf.keras.layers.Dropout(0.2),
  tf.keras.layers.Dense(10, activation=tf.nn.softmax)
])

model.compile(optimizer='adam',
              loss='sparse_categorical_crossentropy',
              metrics=['accuracy'])

model.fit(x_train, y_train, epochs=5)
model.evaluate(x_test, y_test)

DirectML was able to create devices on the Intel/AMD adapters, but failed for the NVIDIA one. The complete output:
$ ./test_direct_ml.py
WARNING:tensorflow:From /home/username/.conda/envs/directml/lib/python3.7/site-packages/tensorflow_core/python/ops/resource_variable_ops.py:1630: calling BaseResourceVariable.__init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version.
Instructions for updating:
If using Keras pass *_constraint arguments to layers.
Train on 60000 samples
2020-06-19 04:04:30.146727: I tensorflow/core/common_runtime/dml/dml_device_factory.cc:45] DirectML device enumeration: found 3 compatible adapters.
2020-06-19 04:04:30.147651: I tensorflow/core/common_runtime/dml/dml_device_factory.cc:32] DirectML: creating device on adapter 0 (Radeon RX Vega M GH Graphics
2020-06-19 04:04:31.902541: I tensorflow/stream_executor/platform/default/dso_loader.cc:60] Successfully opened dynamic library libdirectml.so.ba106a7c621ea741d2159d8708ee581c11918380
2020-06-19 04:04:31.930277: I tensorflow/core/common_runtime/dml/dml_device_factory.cc:32] DirectML: creating device on adapter 1 (Intel(R) HD Graphics 630
2020-06-19 04:04:35.040210: I tensorflow/core/common_runtime/dml/dml_device_factory.cc:32] DirectML: creating device on adapter 2 (NVIDIA GeForce RTX 2070
2020-06-19 04:04:35.050639: F tensorflow/core/common_runtime/dml/dml_device.cc:26] Check failed: (((HRESULT)((D3D12CreateDevice(adapter.Impl()->Get(), feature_level, __uuidof(**(&d3d_device_)), IID_PPV_ARGS_Helper(&d3d_device_))))) >= 0) == true (0 vs. 1)
Aborted

NOTE: If I disconnect the NVIDIA adapter from my machine, the above code runs well on the other two devices with the expected output, 3D usage in Task Manager and everything.

Hi @MikeChou , thank you for trying out the preview! Nvidia doesn't have a DirectX driver for WSL yet, but it's coming soon. Keep an eye out for future announcements or the Nvidia section on this page.

Hi @PatriceVignola , thanks for your promptly answer. So the current NVIDIA driver (455.38) is only for CUDA on WSL, right?
I am closing this.

If the NVIDIA device is not supporting this right now, the library should not detect it as a usable DML device, shouldn't it?
So the sample code will run just well out of box without manually handling this situation even if the NVIDIA device is active in the system.

@MikeChou : I absolutely agree, and we'll look at ways to improve this. Thanks for the suggestion!

Hi @MikeChou , we recently released an update that should fix this issue. Tensorflow should now pick the first supported graphics, even if Nvidia is detected first. The wheels are now uploaded on pypi, so you can install it with pip install tensorflow-directml. Let us know how it works for you!


Add ability to configure bus endpoint queue name for MassTransit.Host…

… based projects
Verified manually by starting RapidTransit.Sample project and observing that the bus queue has expected name.
All transport that do not support bus queue name overriding are throwing NotSupportedException. Additionally added ability to use some formatting based on current Host to set queue name. RapidTransit sample demonstrates how to use format to mimic current behavior of creating bus queue name.
PS if you think that the PR is OK i will add some docs.

So this is a very specialized use case, and the implementation for RabbitMQ seems like it's easily used by the other transports.
I'll have to think about this one and how I'd like it changed versus just accepting it unmodified.
But thanks, I see what you're trying to do here.


Add a size_t count argument to some BNCustomArchitecture.free* fields

Specifically, the freeFlagConditionsForSemanticFlagGroup and freeRegisterList fields should take an additional size_t count argument so that custom architectures implemented in other languages can correctly free the pointers passed to them through these functions without resorting to hackery (as discussed in #5654).
cc-ing @CouleeApps @KyleMiles

After 4.2 stable this will be added with https://github.com/Vector35/binaryninja-api/commit/4f9ae2fb35fac84fbdbb1915d0d9930c2d92b6be#diff-9f2cfb8588b84fe78e355bee9c2e91b8aea21a8f25c7f75927ea1505d70bd9f4

Added with https://github.com/Vector35/binaryninja-api/commit/b34ddd03f71c8637a80a264a3ea757b8295d482b and https://github.com/Vector35/binaryninja-api/commit/121c16592476754800b00a3b51595f4799944d04.


pydantic validator for each yaml configuration section

into the pydantic validator class add block in case of critical execption otherwise rise a warning

Overseeded by https://github.com/italia/eudi-wallet-it-python/issues/248


XGBoost tree vs usual gradient boosting tree

Hi!
Is training XGBoost tree on each iteration (forget about regularisation and other usuful features) the same as training regression tree in usual gradient boosting with samples x_i with weights h_i and targets g_i/h_i?
It is easy to see that leaf weights are calculated this way.
But it seems to me that Gain in XGBoots is not variance based as in normal regression tree for RMSE.
If there is difference here which algorithm (simple GB or XGBoost) gives better tree structure and why?
@tqchen any comments from author of this great library?
Thanks a lot!
Sergey.

Take a look at the XGBoost paper: https://arxiv.org/pdf/1603.02754v2.pdf
XGBoost uses second-order gradients to fit trees.

It is a topic that fits better at https://discuss.xgboost.ai/


Bullet point links are broken.

The bullet point links are all broken.  Please fix this as we in CSS use these as reference and provide to our customers.
Enable the interface
Verify Windows Defender AV is running
Update antimalware definitions
Submit Samples
Configure automatic exclusions
Thank you,
Blakemo

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dfee81e6-dba5-cbd6-4190-3b3aa3fd5f94
Version Independent ID: ad63832b-7b61-01c2-83f8-11a446ddfbb7
Content: Windows Defender Overview for Windows Server
Content Source: WindowsServerDocs/security/windows-defender/windows-defender-overview-windows-server.md
Product: windows-server
Technology: security
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

#assign:xelu86

Hey @BlakeMsft,
All hyperlinks have been updated with new content to better serve our customer needs. The following link encompasses the 5 previous hyperlinks into 1 article:
https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-on-windows-server
Changes to the main article will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day. #please-close


add original non-detect/degrees of freedom option

The original CMNN estimator does not replace non-detections with 1-sigma limits as I do, it instead has them set to nan and does a np.nansum over the colors (thus skipping the nan values), then reduces the degrees of freedom to correspond to the number of bands used, as well as the threshold/ppf lookup that corresponds to those reduced DoF numbers.  We could add a config parameter that lets the user choose either this original implementation or the replacement that I implemented, then compare the resulting photo-z performance in different scenarios to see which functions better.

done and closed by #4


already exists and is not an empty directory. error on macOS Catalina 10.15

Hello,I have an issue abount outline-client yarn build.My Mac system is macOS Catalina 10.15 and xcode is 11.0.When I use yarn to build the project,it has a npm error say destination path '/Users/xxx/.npm/_cacache/tmp/git-clone-ec795e26/.git' already exists and is not an empty directory.But there are no any files under '/Users/xxx/.npm/_cacache/tmp/*'.I hope someone know how to solute the problem and tell me how to do.Or someone else who build success can tell me what mac and xcode system you have.Thank you very much!

Hello,
I have been getting the same problem. Someone Do cant found a solution?
tks
EBJ

We no longer use yarn. Can you please try again with the new setup instructions in the README?


[Auto-Complete] Investigate why auto-complete is not working for non-GET queries and make necessary fixes

This appears to be a bug. Upon investigation and requesting context, there is nothing in the original implementation that would stop auto-complete from working with non-GET queries.
The ask here is to confirm if this is a bug, in which case we should fix it.

Autocomplete fully depended on the links provided by making a call to the autocomplete endpoint. Part of the payload is a links property that has all the paths we can use. These links are only present in the get segment of the response.
From consultations with @irvinesunday there was no need to also place the paths in the other methods. This for us means that we can assume that the paths available in the get method are available in the other methods.

This means that the approach to fixing it should assume that the autocomplete options are available for all methods


~ in path does not become user directory

Issue
If I try to add a file with a path starting with the ~ alias for my home directory, the path does not work correctly. I get an error like this:
> /read-only ~/README_CONVENTIONS.md

File not found:
/Users/larryhudson/my-current-directory/~/README_CONVENTIONS.md

I would like to be able to use the ~ alias so that I can store useful files outside of the current repo - eg. global code conventions etc. At the moment, it means I need to write out the absolute path (e.g. /Users/larryhudson/).
Version and model info
Aider v0.51.0
Model: Claude 3.5 Sonnet
macOS Sonoma 14.3.1

Thanks for trying aider and filing this issue.
Great idea! Aider just added this feature.
The change is available in the main branch. You can get it by installing the latest version from github:
python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

Great, thank you so much! I'm loving Aider, it's been a huge productivity boost. Thanks for all your work on it!


Generate report from csv file

taking the data from the csv file, the program then get the data ,then generate a file with the report with the extracted data.

I suppose this pull-request is irrelevant to this repository. So I'll close this pull-request.
Thanks.
P.S. You shouldn't use two argument open() because it has a potential of mixing a vulnerability. You should use three argument open() instead.


ScrapeChangesCommand Doesn't run after the Webscraper

ScrapeChangesCommand gets called in WebScrapeCommand at line 749 however it fails with
  [RuntimeException]
  Not enough arguments.

Should probably pass empty arguments
$arguments = array('');

Becuase the Command should be loading what it needs from the parameters.

See commit 730faa7


Incorrect results using @turbo with linear array indexing

There was some discussion about this issue here. Essentially, when using linear indexing of an array @turbo appears to start indexing the array incorrectly when a offset term is used. An example of this (code and commentary copied directly from the discourse discussion) is below.
julia> H = collect(reshape(1.0:6.0, 3, 2))
3×2 Matrix{Float64}:
 1.0  4.0
 2.0  5.0
 3.0  6.0

julia> su = zeros(3);

julia> for k = 1:1
           ind = 0 # LinearIndices((3, 2))[1, 1] - 1
           for ij in 1:3
               su[ij] += H[ij + ind]
           end
       end

julia> su
3-element Vector{Float64}:
 1.0
 2.0
 3.0

julia> su = zeros(3);

julia> for k = 1:1
           ind = 0
           @turbo for ij in 1:3
               su[ij] += H[ij + ind]
           end
       end

julia> su
3-element Vector{Float64}:
 6.94274366677856e-310
 1.0
 2.0

so H is being indexed at 0, 1, 2 instead of 1, 2, 3. The effect doesn’t seem to happen on the left hand expression e.g. su[ij + ind] and doesn’t seem to shift more with more additions e.g. H[ij + ind + ind]. It does it correctly if the index was added to a literal 0 instead of ind or if not added:
julia> su = zeros(3);

julia> for k = 1:1
           @turbo for ij in 1:3
               su[ij] += H[ij + 0]
           end
       end

julia> su
3-element Vector{Float64}:
 1.0
 2.0
 3.0

julia> su = zeros(3);

julia> for k = 1:1
           @turbo for ij in 1:3
               su[ij] += H[ij]
           end
       end

julia> su
3-element Vector{Float64}:
 1.0
 2.0
 3.0

Probably a bug in some of the offsetting code.
If anyone wants to take a look at it, I'd be happy to answer any questions.
I am unlikely to get around to fixing this myself.


diagnostic logging

more logs for #11322

Codecov Report

Merging #11514 (b48c48f) into main (a5645ed) will increase coverage by 0%.
The diff coverage is 40%.

@@          Coverage Diff           @@
##            main   #11514   +/-   ##
======================================
  Coverage     63%      63%
======================================
  Files        477      477
  Lines      34155    34156    +1
  Branches    5544     5544
======================================
+ Hits       21579    21596   +17
+ Misses     10516    10494   -22
- Partials    2060     2066    +6

Impacted Files
Coverage Δ

src/interactive-window/interactiveWindow.ts
75% <25%> (-1%)
:arrow_down:

...rc/interactive-window/interactiveWindowProvider.ts
77% <100%> (ø)

src/platform/common/cancellation.ts
62% <0%> (-2%)
:arrow_down:

src/kernels/raw/launcher/kernelProcess.node.ts
72% <0%> (-2%)
:arrow_down:

src/platform/msrCrypto/msrCrypto.js
19% <0%> (-1%)
:arrow_down:

src/kernels/jupyter/jupyterKernelService.node.ts
76% <0%> (+1%)
:arrow_up:

.../standalone/survey/dataScienceSurveyBanner.node.ts
69% <0%> (+3%)
:arrow_up:

src/kernels/jupyter/finder/remoteKernelFinder.ts
93% <0%> (+4%)
:arrow_up:

src/kernels/execution/notebookUpdater.ts
96% <0%> (+7%)
:arrow_up:

...nels/jupyter/jupyterRemoteCachedKernelValidator.ts
53% <0%> (+25%)
:arrow_up:


Fix wrong socket type for extra addresses in QUIC listeners

Please provide a description of this PR:
This will address a DS-exclusive issue: #48336
As I mentioend in the issue, when both DS and QUIC listeners are enabled we end up using different socket type between the address and additional_addresses.
Because we end up with both a UDP and TCP address in the same listener, Envoy will correctly rejects the configuration.
I have updated the code to ensure a proper listener configuration.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@leosarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
ae1fbba5d6647121d84b40e60ce097d59616b3e2
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient

@kfaseela @zhlsunshine

@leosarra could you please unskip the quic tests for dual-stack and show that it passes now with the fix? https://github.com/istio/istio/blob/master/tests/integration/security/sds_ingress/quic/ingress_test.go#L111

please add a test

I have removed the skip condition from the ingress QUIC tests that were failing on master without this fix

@leosarra could you please unskip the quic tests for dual-stack and show that it passes now with the fix? https://github.com/istio/istio/blob/master/tests/integration/security/sds_ingress/quic/ingress_test.go#L111

please add a test

I have removed the skip condition from the ingress QUIC tests that were failing on master without this fix

The presubmit tests won't usually run this test. If you want to make sure if runs fine before merging the PR, you can temporarily edit this line and see it passes :) https://github.com/istio/istio/blob/master/tests/integration/tests.mk#L129

The presubmit tests won't usually run this test. If you want to make sure if runs fine before merging the PR, you can temporarily edit this line and see it passes :) https://github.com/istio/istio/blob/master/tests/integration/tests.mk#L129

Ah, I see :)
This time I have tested the QUIC tls/mtls tests locally by using a personal build.

@leosarra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
cca4c1e017b6ebe41f924d332a6e87f97b9fef91
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot

LGTM from test perspective. Would leave to @hzxuzhonghu @zhlsunshine and @howardjohn for final approval

/cherry-pick release-1.19
/cherry-pick release-1.20

@leosarra: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherry-pick release-1.20

@leosarra: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leosarra: #48334 failed to apply on top of branch "release-1.19":
Applying: Fix wrong socket type for extra addresses in QUIC listeners
Using index info to reconstruct a base tree...
M	pilot/pkg/networking/core/v1alpha3/listener.go
M	pilot/pkg/networking/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/util/util.go
Auto-merging pilot/pkg/networking/core/v1alpha3/listener.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/listener.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix wrong socket type for extra addresses in QUIC listeners
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leosarra: new issue created for failed cherrypick: #48365

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leosarra: #48334 failed to apply on top of branch "release-1.20":
Applying: Fix wrong socket type for extra addresses in QUIC listeners
Using index info to reconstruct a base tree...
M	pilot/pkg/networking/core/v1alpha3/listener.go
M	pilot/pkg/networking/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/util/util.go
Auto-merging pilot/pkg/networking/core/v1alpha3/listener.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/listener.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix wrong socket type for extra addresses in QUIC listeners
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leosarra: new issue created for failed cherrypick: #48366

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Show all apps permission

If you click on the App Icon, then Permissions you should see all the permissions.


Add atStart and atEnd properties to ScrollMetrics

Adds atStart and atEnd properties to ScrollMetrics, so ScrollController users can distinguish which which edge the ScrollView is at when atEdge is true.
Fixes #92265
Note: given that the ScrollMetrics mixin does not seem to have tests, I'm not entirely sure what the best approach is for testing this change.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

Closing this for now. If you find the bandwidth to add tests in the future feel free to re-open this. Thanks!
The issue is also tracked in #92265.


[GLib] Add GArrowBinaryViewDataType

Describe the enhancement requested
arrow::BinaryViewType has been introduced.
GLib needs to be implemented as GArrowBinaryViewDataType.
Component(s)
GLib

Issue resolved by pull request 44659
https://github.com/apache/arrow/pull/44659


runtime-sdk/modules/evm: Add withdraw/deposit

Closes #351.

Thanks for the comments!  I've started working on changing the gas payment as you've described.
Currently, the e2e tests fail because the accounts module's invariant checker finds that the gas fee gets lost somewhere -- I'll continue debugging this on Monday :)
(It's probably something really simple, but I've been looking at the same code all day and can't really notice anything that could cause this at the moment.)


add domain

Please add my college named Prisma University.

@nofretspoaiprisma First stage of verification passed, official domain for Universitas Prisma is prisma.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@nofretspoaiprisma Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Reference Cabal Environmental Variables

https://github.com/berberman/arch-hs/blob/94ad1bd361ebb40be5ce82b357a4df3ea4cea823/src/Distribution/ArchHs/Hackage.hs#L39
This is a hard-coded path to CABAL_DIR, which can be changed by the user. It would be helpful to reference the variable or to have a flag to change where we look for Cabal's files.

There is a CLI option -h to specify the path to hackage database.


Improve simple HTML landing page

Currently it is partly outdated and not yet complete.

Done with c4467f9905c9e51ac3093d15c4ecd8525156130b. For now.


[Windows] Suppress unnecessary ar messages

Removes some useless creating ***.a waning messages cause by https://github.com/godotengine/godot/pull/94747, which enabled stderr print, and ar is sending these to stderr without c modifier.

CC @alvinhochun

Looks fine to me, thanks.

Superseded by #96407.


Add Applicative Packet Support

Changing back to 0.3. Its hard to write about this without including the applicative packet discussion.


java.lang.NoClassDefFoundError: Failed resolution of: Ljava/util/Base64;

i try this dependency for get feed data of Instagram but error occur in login method
and error is
  com.github.instagram4j.instagram4j.exceptions.IGLoginException: java.lang.NoClassDefFoundError: Failed resolution of: Ljava/util/Base64;
    at com.github.instagram4j.instagram4j.IGClient$Builder.performLogin(IGClient.java:278)
    at com.github.instagram4j.instagram4j.IGClient$Builder.login(IGClient.java:255)

i also add this in build.gradle
compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
}

Actually, java.lang.Base64 class is not available on some android emulators. For that, we have to use the android.utils.Base64 class. But there's a catch, If developers use android.utils.Base64 then the same error will occur in Non-Android projects

Can you use org.apache.commons.codec.binary.Base64 or other base64 package for Base64 functions instad of java.lang.Base64?


MIDI File Parser crashes on copyright meta events

macOS Version(s) Used to Build
macOS 12 Monterey
Xcode Version(s)
Xcode 13.4.1
Description
Observed on : AudioKit 5.1
MIDI files containing copyright notice meta events makes the MIDI file Parser crash.
These kind of event doesn't seem to be supported in the MIDIFileTrackChunk chunkEvents process:

Crash Logs, Screenshots or Other Attachments (if applicable)
Here is a MIDI file which contains a copyright notice event.
It Must Be Love.mid.zip

We're going to be overhauling the MIDI with @orchetect 's https://github.com/orchetect/MIDIKit


Sharing on Twitter is not working

See image below!

Thanks @ftonato !
Hey @robsongajunior , take a look.

I made an emergency fix, it is now live at http://jsrocks.org.
Make sure to hard-refresh the page if you have caching issues.
We would still like to improve those default share texts, see #39

:+1:


Allow sharing of text with PocketPlan => Import as new Note

hi all,
testing v1.3.4, but wait, the application does not appear to SHARE menu..
example, select text on any other application and press SHARE..
can you add the application there  ??
you need to declare intent listeners in your android manifest

What device / Android version are you on? I tested it, and it worked. What i did:
Open a note => select text

select more options

select share

hi @JakeGonder
Im talking about the opposite, to be on SMS or a website and send a note to PocketPlan

Oh now i understand, sounds like a good idea, we will try to add this.

Added the feature on the beta branch

The feature is now live in 1.3.5


[ResourceManager] Remove HttpMessageUtilities

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API changes have been detected in Azure.ResourceManager. You can review API changes here


[1.14.4] Crash Report, WritingException at startup

Describe the bug (Required)
The Server crashes on start-up, I've deleted the world before starting.
To Reproduce (Required unless not known)
Steps to reproduce the behavior:

Create a new server with the listed .jar's
Start the server

Crash report (via. Hastebin)
https://hastebin.com/raw/vahovicuko
Expected behavior (Required)
Not to crash 😅
Versions:(check log if you don't know)

Forge Version: forge-1.14.4-28.1.1.jar
MC Version: minecraft_server.1.14.4.jar
Mod Version: VanillaTweaks-<IP_ADDRESS>.5.6.jar
JEI Version (if present) : jei-1.14.4-<IP_ADDRESS>.jar
Baubles Version (if present) :

Additional context
Add any other context about the problem here. This may be skipped/removed.

Hey can you show vanillatweaks config folder?

Delete the content.toml folder and try again please.

I've made an empty file called Content.toml and now it works

Yeah, now everything's fine, I suppose a previous version could have caused issues.

Could you trying using the latest version of the mod in an new instance?


BUG: syspin checksum fails, aborts installation

Describe the bug and expected behavior
Try to install on Windows 1909. After some time installation stops.
Manual reboot enforced, after manual reboot installation CLI opens again but fails verifying the syspin checksum.
Attempt to install it manually fails with a similar error.
Anyone any idea what this could be?
Version

OS: Windows 1901

Log output
cinst -y syspin -f
Chocolatey v0.10.15
2 validations performed. 1 success(es), 1 warning(s), and 0 error(s).

Validation Warnings:
 - A pending system reboot request has been detected, however, this is
   being ignored due to the current Chocolatey configuration.  If you
   want to halt when this occurs, then either set the global feature
   using:
     choco feature enable -name=exitOnRebootDetected
   or pass the option --exit-when-reboot-detected.

Installing the following packages:
syspin
By installing you accept licenses for the packages.

syspin v<IP_ADDRESS> (forced) [Approved]
syspin package files install completed. Performing other installation steps.
WARNING: Url has SSL/TLS available, switching to HTTPS for download
Downloading syspin
  from 'https://www.technosys.net/download.aspx?file=syspin.exe'
Progress: 100% - Completed download of C:\ProgramData\chocolatey\lib\syspin\tools\syspin.exe (19 KB).
Download of syspin.exe (19 KB) completed.
Error - hashes do not match. Actual value was '07D6C3A19A8E3E243E9545A41DD30A9EE1E9AD79CDD6D446C229D689E5AB574A'.
ERROR: Checksum for 'C:\ProgramData\chocolatey\lib\syspin\tools\syspin.exe' did not meet 'a6967e7a3c2251812dd6b3fa0265fb7b61aadc568f562a98c50c345908c6e827' for checksum type 'sha256'. Consider passing the actual checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
The install of syspin was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\syspin\tools\chocolateyInstall.ps1'.
 See log for details.

Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - syspin (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\syspin\tools\chocolateyInstall.ps1'.
 See log for details.

Apparently the problem is not only limited to syspin, folder lib-bad contains various other tools as well.
Searching chocolatey.log for other failed packages, such as adexplorer or dnspy.flare, doesnt return any findings.

Apparently multiple sources are invalid.
The installation scripts even finishes, yet it appears many tools are not installable.
For example Bloodhound or Foca are still missing.
Anyone any idea?

唉，我也遇到了這個問題。不僅如此，如果你使用full.json作爲repo去下載軟件的話，你會發現滿屏都是”下載失敗“。問題出在軟件源所指向的URL上。倘若要改的話，太麻煩（個人覺得沒時間在此瞎折騰）……而且如果自己去下載對應的軟件，安裝程序根本無法識別，它仍然會重新下載，然後報錯。只能火眼實驗室更新一下他們的軟件源了。（爲啥顯示出來的不是簡體中文……[\捂臉]；英文水平不高，只能用中文，翻譯一下吧）

Well, I also encountered this problem. Not only that, if you use full.json as a repo to download software, you will find that the full screen is "download failed". The problem lies in the URL that the software source points to. If you want to change it, it will consume a lot of time, and if you download the corresponding software, the installation program can't recognize it at all, it will still download it again, and then report an error. We have to update their software source at fireeye. (Why isn't simplified Chinese displayed? Due to poor English, I can only use Chinese, translate it)

感谢您的留言。 我遇到了同样的问题。 确实似乎与要下载的软件的校验和有关。 显然他们在脚本中引用的版本不再可用。
似乎没有简单可行的解决方案。 太糟糕了，我非常感谢Commando-VM。
PS：我不会说中文，所以我希望翻译能工作。

Thank you for your message. I encountered the same problems. It really seems to be a problem with the checksum of the software to be downloaded. Apparently the versions they reference in the script is no longer available.
It seems there is no easy, feasible fix for that. Too bad, I really appreciated Commando-VM.

Yeah it looks like some of the packages will need to be updated. All of the packages ending in .fireeye or .flare are maintained by us, and we can have them updated. Other packages that do not end that way (syspin for example) are maintained by others and we will need to wait until they update those packages.

Thanks for the update @day1player!
Just for my understanding, is it intended behaviour that an error with these packages results in a subsequent failure to install the other packages? For example bloodhound or Foca is also not installed. I assume this is a follow up issue?

@HachimanSec some packages that have specific dependencies will fail if the dependency is unable to be installed, but I think BloodHound and Foca should not be affected by dependencies and they could be other issues. If you want to feel free to create new issues or post some screenshots here and I can create the new issues

Thanks @day1player. Strange thing is, I see no further errors as to why it stops the installation of further packages such as BH and Foca.
All I see is the errors of syspin, etc. and then it simply stops. I try to dig into it a bit more and if I have enough info I will open a new bug.
I just dont want to spam you guys with bugs that have no content ;)

Yeah it looks like some of the packages will need to be updated. All of the packages ending in .fireeye or .flare are maintained by us, and we can have them updated. Other packages that do not end that way (syspin for example) are maintained by others and we will need to wait until they update those packages.

Is there any ETA?

if you want all packages that fail for some reason can be reinstalled you can as well edit urls or their checksums in file C:\ProgramData\chocolatey\lib\windbg.flare\tools\chocolateyInstall.ps1 which can easily be changed you then need to pack and install it using chocolatey:
cpack C:\ProgramData\chocolatey\lib-bad\windbg.flare\windbg.flare.nuspec
cinst C:\ProgramData\chocolatey\lib-bad\windbg.flare\windbg.flare.nuspec

keep in mind that this is a workaround and most of those that fail can be fixed within 10 minutes by flare team or anyone doing a proper PR.

Maybe it will work in some ways. But we need a completely and permanently solution, or every time, you need to edit their URLs and checksums ,after they update their software. I think FireEye should learn from Offensive Security, depending on several officially resources,which can reliable and stable storage the packages.

@WYMzg we rely on other official repos where we can, dnSpy is not officially supported as a chocolatey package by anyone but us 👍
fixed with june update #262


Bad dependencies for parameters.xml

@jgoppert @LorenzMeier
make posix
Then have a look at build_posix_sitl_simple/CMakeFiles/xml_gen.dir/build.make
parameters.xml depends on EVERY file under Firmware/src including all example directories, all of Eigen, all platform specific code, and src/lib/dspal. The path passed to the parameter generation script needs to be more specific.
These excess dependencies are breaking a build of qurt following a build for posix.

Would *_params.c catch everything?

That would seem dangerous to me. Param define macros can be anywhere.

I should have grepped first. Yes, they're all over the place.
modules/mavlink/mavlink.c, modules/fixedwing_backside/params.c, modules/sdlog2/sdlog2.c, etc

Is it worth the effort for the time saved to have dependencies on this?

well, the trivial fix is to exclude external libraries. Then we'll see what we end up with.
@mcharleb We need to get integration testing up and running for your platform, there is no other way to maintain this. Is there someone on your end with significant time available to get this up with me?

Fixed by @mcharleb - thanks!


Extracting DI as a lib

I was wondering, if extracting the new DI engine would be a possible/good thing to do.
Right now, the only good DI lib we have in Dart is di.dart, that seems to be lowly maintained. Is this new version better than the old one?
I'd very much like to use this for redstone instead of the old one if it's better, and if it's possible at all.
Thanks!

Something like this is on the roadmap - it just won't necessarily be in it's current form.
As you can probably tell the current DI is pretty ingrained within the framework and moving it out isn't very practical. Hopefully will have more information on our plans soon. We definitely agree :)

This is currently a WIP as a new library based on Java's Dagger2 (https://google.github.io/dagger/). We won't immediately consume it within Angular but it will likely be a mostly gradual rollout. Definitely excited to have a new first-class dependency injection for Dart.

Just an update: We have something working, though obviously not part of Angular yet.
It's changing fast, so nothing publicly available yet - but this is still an important issue to us.

What will be the strategy w.r.t. documented alternatives to OpaqueToken (cf. #35).
I'm updating the dependency injection page and was wondering if I could update the text regarding this.
cc @kwalrath @filiph

There is no strategy regarding OpaqueToken

Is there any update on this? Any early access package available somewhere? or github repo?

Hi folks. I do have an update - I've gotten through the necessary steps to open source the new package. Some caveats though, of course:

It's a new package, i.e. is not Angular's DI extracted as-is
It doesn't work with Angular yet (entirely standalone), there is plans to unify, but not a P1
It is entirely statically generated, i.e. no dynamic providers (like Dagger2)

It will take a few more weeks to get it available. I might be able to show super passionate Dartisans an early demo (before it's formally released). If you're interested I'll have some more information soon.

This is now planned to have a pre-release by the 4.0 release.

This has been pushed back, as the infrastructure to support this externally might not be ready by 4.0.0. Sorry about that.

I'm closing this issue because it won't happen as part of AngularDart (but a separate library), and I don't want to keep folks waiting expecting that this is going to happen soon.


Broaden appropriate flake8-pyi rules to check non-stub code too

Of the rules that flake8-pyi enforces for .pyi type stubs, many of them equally make sense to check in normal runtime code with type annotations.  Broaden these rules to check all files:
PYI013 ellipsis-in-non-empty-class-body
PYI016 duplicate-union-member
PYI018 unused-private-type-var
PYI019 custom-type-var-return-type
PYI024 collections-named-tuple
PYI025 unaliased-collections-abc-set-import
PYI030 unnecessary-literal-union
PYI032 any-eq-ne-annotation
PYI034 non-self-return-type
PYI036 bad-exit-annotation
PYI041 redundant-numeric-union
PYI042 snake-case-type-alias
PYI043 t-suffixed-type-alias
PYI045 iter-method-return-iterable
PYI046 unused-private-protocol
PYI047 unused-private-type-alias
PYI049 unused-private-typed-dict
PYI050 no-return-argument-annotation-in-stub (Python ≥ 3.11)
PYI051 redundant-literal-union
PYI056 unsupported-method-call-on-all
The other rules are stub-specific and remain enabled only in .pyi files.
PYI001 unprefixed-type-param
PYI002 complex-if-statement-in-stub
PYI003 unrecognized-version-info-check
PYI004 patch-version-comparison
PYI005 wrong-tuple-length-version-comparison
PYI006 bad-version-info-comparison
PYI007 unrecognized-platform-check
PYI008 unrecognized-platform-name
PYI009 pass-statement-stub-body
PYI010 non-empty-stub-body
PYI011 typed-argument-default-in-stub
PYI012 pass-in-class-body
PYI014 argument-default-in-stub
PYI015 assignment-default-in-stub
PYI017 complex-assignment-in-stub
PYI020 quoted-annotation-in-stub
PYI021 docstring-in-stub
PYI026 type-alias-without-annotation (could make sense to broaden, but gives many false positives on runtime code as currently implemented)
PYI029 str-or-repr-defined-in-stub
PYI033 type-comment-in-stub
PYI035 unassigned-special-variable-in-stub
PYI044 future-annotations-in-stub
PYI048 stub-body-multiple-statements
PYI052 unannotated-assignment-in-stub
PYI053 string-or-bytes-too-long
PYI054 numeric-literal-too-long

This looks great! I've been wanting this to happen but someone had to go through and do the hard work of auditing the rules for appropriateness, thank you for taking that on. I may rename the rules that are stub-only to have a consistent -in-stub suffix, but that can happen separately.

Would any of PYI003 - PYI006 make sense to include?

PYI003 unrecognized-version-info-check and PY004 patch-version-comparison target version comparisons that aren’t specially recognized by type checkers but seem fine to allow in runtime code:
MIN_VERSION = (3, 10)
if sys.version_info < MIN_VERSION:  # PYI003
    exit(1)

if sys.version_info < (3, 10, 0):  # PYI004
    exit(1)

Broadening PYI005 wrong-tuple-length-version-comparison and PYI006 bad-version-info-comparison could make sense. I had skipped these four rules together because they’re handled by the same function.
I note that these rules are currently restricted to the context of an if statement condition, and then within at most one level of and or or. The flake8_2020 functions cover all relevant expressions and might be a better home for generalized versions of these rules.


It doesn't work.

Describe the Bug
I downloaded it, but it doesn't work.
Reproduction Steps
1.Download the Minecraft 1.19.2 with Fabric 0.14.10
2.Download the Create and other mods into the mods directory
3.Launch Minecraft.
4.It doesn't work.
All the mod I downloaded:

Expected Result
I want it to work.
Screenshots and Videos

As you can see, there are no Create objects here.
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.0f
Minecraft Version
1.19.2
Other Mods

Additional Context
No response

you are using Create Forge 😆

@JieningYu Oh, it worked after I downloaded the Fabric version. Thank you.


Sso updates

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/develop/sso-in-office-add-ins.md
:warning:Warning

Details

docs/develop/auth-external-add-ins.md
:white_check_mark:Succeeded

docs/develop/authorize-to-microsoft-graph.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-nodejs.md
:white_check_mark:Succeeded

docs/develop/grant-admin-consent-to-an-add-in.md
:white_check_mark:Succeeded

docs/develop/register-sso-add-in-aad-v2.md
:white_check_mark:Succeeded

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

docs/images/sso-access-to-microsoft-graph.png
:white_check_mark:Succeeded

docs/images/sso-overview-diagram.png
:white_check_mark:Succeeded

docs/includes/grant-admin-consent-to-an-add-in-include.md
:white_check_mark:Succeeded

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/develop/sso-in-office-add-ins.md

Line 58: [Warning] Invalid file link:(~/develop/register-sso-add-in-v2).
Line 89: [Warning] Invalid file link:(~/develop/troubleshoot-sso-in-officd-add-ins).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/develop/sso-in-office-add-ins.md
:warning:Warning

Details

docs/develop/auth-external-add-ins.md
:white_check_mark:Succeeded

docs/develop/authorize-to-microsoft-graph.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-nodejs.md
:white_check_mark:Succeeded

docs/develop/grant-admin-consent-to-an-add-in.md
:white_check_mark:Succeeded

docs/develop/register-sso-add-in-aad-v2.md
:white_check_mark:Succeeded

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

docs/images/sso-access-to-microsoft-graph.png
:white_check_mark:Succeeded

docs/images/sso-overview-diagram.png
:white_check_mark:Succeeded

docs/includes/grant-admin-consent-to-an-add-in-include.md
:white_check_mark:Succeeded

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/develop/sso-in-office-add-ins.md

Line 58: [Warning] Invalid file link:(~/develop/register-sso-add-in-aad-v2).
Line 89: [Warning] Invalid file link:(~/develop/troubleshoot-sso-in-office-add-ins).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: missing tlsConfig for ServiceMonitor example

ServiceMonitor example is missing tlsConfig that caFile, certFile etc should go under (spec)

/cc @simonpasquier @jan--f


Update 2016-02-11-bn-opendatamap-nrw.html

Labname aktualisiert

A single PR would be nice.  Does https://desktop.github.com/ help you?  Or maybe try https://atom.io/ or https://code.visualstudio.com/.  They should have good enough git/github integration.


Selection in Editor Help is not accurate

Godot version
67d4015
System information
Windows 10 x64
Issue description

It's off by 1 character.
EDIT:
Actually it only happens in code blocks.
Steps to reproduce

Open some help page
Try to select text in a code block

Minimal reproduction project
No response

Selection within tables likely has some issues. In master, code blocks are located within a table with 1 row and 1 column to add padding on the background (and make the background span the entire line).

Is this still an issue? There have been some fixes to RTL and tables.

Yes.


Add setContent and getContent API for L.divIcon class

Similar to the L.popup class it would be nice to provide methods like setContent and getContent for L.divIcon, for better implementation of custom icons. Also it would be nice to be able to set also DOM elements, instead of only a html string in L.divIcon.

I'm not really sure this is a good idea - the code for L.Icon expects to have control over the HTMLElement of the icon, so it can be repositioned. While this is a good idea, I don't think implementation would be trivial.

@IvanSanchez why would this be difficult for icons and not for popups/tooltips?

I am agree.If L.divIcon accept a HtmlElement as content,it would be a decent  way of implementing a interactive icon.

I'm not sure what version it was implemented, but div icon now accepts HTMLElement.
html = String|HTMLElement
"Custom HTML code to put inside the div element, empty by default. Alternatively, an instance of HTMLElement."

@aeromac Nice, you are correct! 😃 HTMLElement support was introduced in 1.5.0 (see https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md#150-2019-05-08) with #6571. So this issue is partially fixed, but setContent and getContent are yet to be implemented.


Added my name & md file

I added my name in contributions.dart and added an md file.

Kindly add your full name and github username in the existing List [ ] not to create a new one and create another pull request for merge the code.
Thanks


DB Exceptions seen on latest master

On latest master, with only db deployed and no environments I see this:
2018-05-14 16:57:47,617 INFO  [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-ed4a764d) (logid:d70d0be5) Started resource counters recalculation periodic task.
2018-05-14 16:57:47,637 WARN  [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-ed4a764d) (logid:d70d0be5) Discrepency in the resource count (original count=0 correct count = 13) for type template for account ID 1 is fixed during resource count recalculation.
2018-05-14 16:57:47,657 DEBUG [c.c.u.d.T.Transaction] (ResourceCountChecker-1:ctx-ed4a764d) (logid:d70d0be5) Rolling back the transaction: Time = 2 Name =  ResourceCountChecker-1; called by -TransactionLegacy.rollback:889-TransactionLegacy.removeUpTo:832-TransactionLegacy.close:656-TransactionContextInterceptor.invoke:36-ReflectiveMethodInvocation.proceed:174-ExposeInvocationInterceptor.invoke:92-ReflectiveMethodInvocation.proceed:185-JdkDynamicAopProxy.invoke:212-$Proxy71.countCpuNumberAllocatedToAccount:-1-ResourceLimitManagerImpl.countCpusForAccount:929-ResourceLimitManagerImpl$4.doInTransaction:902-ResourceLimitManagerImpl$4.doInTransaction:872
2018-05-14 16:57:47,658 WARN  [c.c.u.d.T.Transaction] (ResourceCountChecker-1:ctx-ed4a764d) (logid:d70d0be5) txn: Commit called when it is not a transaction: -Transaction.execute:41-Transaction.execute:47-ResourceLimitManagerImpl.recalculateAccountResourceCount:872-ResourceLimitManagerImpl$ResourceCountCheckTask.runInContext:1065-ManagedContextRunnable$1.run:49-DefaultManagedContext$1.call:56-DefaultManagedContext.callWithContext:103-DefaultManagedContext.runWithContext:53-ManagedContextRunnable.run:46-Executors$RunnableAdapter.call:511-FutureTask.runAndReset:308-ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301:180
2018-05-14 16:57:47,661 DEBUG [c.c.u.d.T.Transaction] (ResourceCountChecker-1:ctx-ed4a764d) (logid:d70d0be5) Rolling back the transaction: Time = 3 Name =  tx-320; called by -TransactionLegacy.rollback:889-TransactionLegacy.removeUpTo:832-TransactionLegacy.close:656-TransactionContextInterceptor.invoke:36-ReflectiveMethodInvocation.proceed:174-ExposeInvocationInterceptor.invoke:92-ReflectiveMethodInvocation.proceed:185-JdkDynamicAopProxy.invoke:212-$Proxy71.countMemoryAllocatedToAccount:-1-ResourceLimitManagerImpl.calculateMemoryForAccount:933-ResourceLimitManagerImpl$4.doInTransaction:904-ResourceLimitManagerImpl$4.doInTransaction:872

ISSUE TYPE

Bug Report

COMPONENT NAME

DB, API, background tasks

CLOUDSTACK VERSION

master, possibly 4.11 branch

OS / ENVIRONMENT

Basic install with no env deployed
STEPS TO REPRODUCE

Deploy latest master, start mgmt server with no env deployed see logs

EXPECTED RESULTS

Exceptions should not be seen

@DaanHoogland @PaulAngus ping - is this happening on 4.11, if you do have time please help triage. Thanks.

@nvazquez is this the same as in your work on connection pool configuration work?

Btw, I've verified this happens with latest 4.11 as well especially for the case of cpu, memory capacity checks. However, it seems harmless, but annoying.

Hello @rhtyd,
I will not be able to check this problem now. I glanced the code though.
Are you talking about “Discrepancy in the resource count” or the “Rolling back the transaction”?
The first one seems to be a similar case to #2629. The count for user templates is wrong.
On the other hand, the second one seems to be an exception that is being hidden from us. Looking at the code, I noticed that the method uses @DB that is supposed to open and close (commit) a transaction. However, it does not seem to be doing that.

@rafaelweingartner I see the 'rolling back transaction' as shared in the logs in this issue, even with mgmt server started without any env/zone deployed.

@DaanHoogland it doesn't seem to be the same error as the connection pool replacement.

The fix is to identify which part of the code is trying to call a commit() when it's not in a transaction, likely an update could have been performed without any changes to the rows (VOs) that may be causing this.

On investigation, I found that this happens when cpu and memory counts are updated in a transaction where no update are performed i.e. old and new cpu/memory counts are the same. The log is seen because txn.commit() is called but txn itself is not started.

Fixed in PR.


processHandshake is unnecessarilly strict in UTF-8 decoding

We see cases where some browsers, in foreign locale's trigger the default strict decoding of utf-8 during processHandshake. It seems like lenient utf-8 decoding should be done.
The error:
encodings.utf_8 in decode
UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9 in position 647: invalid continuation byte

Stacktrace (most recent call last):

  File "autopush/websocket.py", line 85, in wrapper
    return func(self, *args, **kwargs)
  File "autopush/websocket.py", line 313, in processHandshake
    return self.parent_class.processHandshake(self)
  File "autobahn/websocket/protocol.py", line 2761, in processHandshake
    (self.http_status_line, self.http_headers, http_headers_cnt) = parseHttpHeader(self.http_request_data)
  File "autobahn/websocket/protocol.py", line 388, in parseHttpHeader
    raw = data.decode('utf8').splitlines()
  File "encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)

Couldn't this use 'ignore' on the decode line to ignore anything it can't coerce?

I have dug into the spec for HTTP header processing and in particular this, this and this.
I think the immediate bug here is that we decode using UTF8, while we should decode using ISO-8859-1. Only via the mechanism described in RFC5987, it would be possible to support full UTF8 in HTTP header values.

Unfortunately I don't know offhand what characters caused this bug for a reproduction, since Sentry used utf-8 decode with ignore to submit the bug, which stripped the characters out.

Is the goal to use ISO-8859-1 decoding? Any idea when this will be fixed, as we're increasing our scale this error is happening increasingly regularly. Right now I'm probably going to use a separate fork that relaxes the strictness.

waiting for travis, but this should be good.

Great, thanks!


Security issue: user can request arbitary blob digest as manifest digest of an image

So basically if an image has some very big layers, a bad user can bring the server down.
When user request a manifest, it provides the digest in the format: /v2/images/manifests/sha256:{digest}.
However if the user provides a layer digest in the request, registry server will first read all the content of the layer into memory, and then find out it's not manifest. This could take down the server easily if some layers are very big.
https://github.com/docker/distribution/blob/master/registry/storage/manifeststore.go#L76
The registry treats the layer and manifest content separately. For manifest, it reads everything into memory; for layer request, if the redirect is enabled, it returns a redirect response with the blob url for user to download directly (so registry server doesn't need to read the content into memory).
To address this, the registry needs to check if the requested digest is really a manifest digest before reading the content. A easy check is to see if the link file is under the path /v2/repositories/{image}/_manifests/revisions. If it's not, return error directly without reading the blob.

@DavidObando @SajayAntony @sivagms

@stevvooe @dmcgowan Do you think that this needs to be fixed?

@yuwaMSFT2 I think blobStore already does that check for the manifest endpoint. Note that there are different blob stores for each kind of end point that perform these checks.
Can you demonstrate this or is it theoretical? If you have a demo, please send it to<EMAIL_ADDRESS>

@stevvooe Yes I was able to blow away the server in my private registry using Azure storage driver...In the image I had a 2GB layer; I sent the manifest GET request by digest with this layer digest. The server tried to read the full layer and ran out of memory.
The manifesthandler doesn't check the digest, and calls manifeststore.get, which calls linkedBlobStore.Get. Here we only check if the digest exists in the repository before calling blobStore.Get to read content. Since the layer blob belongs to this image, the check succeeds...we should actually check if it's manifest blob instead.
Repro is easy as I mentioned....I just pushed an image with layer layer (with digest sha:xxx). The request manifest by digest using this sha:xxx

Since the layer blob belongs to this image, the check succeeds...we should actually check if the requested on is actually manifest blob.

There is no way to perform this check without creating a hard demarcation between layers and blobs. We'll have to have size limit for reading a blob as a manifest.

 Size limit on manifest read is necessary.
One other optimization I tried on my server is to check if the requested digest exist using manifestRevisionLinkPathSpec, since manifest blob should have a ref link in the revision path. This can avoid us from reading the layer blob.

@yuwaMSFT2 As I said above, please take this conversation to<EMAIL_ADDRESS>


TypeError: Cannot read property 'getRow' of undefined

Folks, not sure why I am seeing this,
"exceljs": "^1.6.2"
"node": "8.12.0"
stack=TypeError: Cannot read property 'getRow' of undefined

        function reaplceColumnDefs() {
            let workbook = new exceljs.Workbook();
            return workbook.xlsx.readFile(fileLocation).then(function() {
                let worksheet = workbook.getWorksheet(1);
                worksheet.getRow(1).values = ['column1Name', 'column2Name'];
                workbook.commit().then(function () {
                      return workbook;
                });
            });
        }

Hope I am chaining promises appropriately.  workbook.commit is async, yes?

Update:  This seems to be occurring to older versions of excel files, not anything i create locally .


RestSharp - Method 'get_StatusCode' does not have an implementation

Hello,
I am trying to implement Manatee.Trello in my program. I am currently stuck with Framework 4 as I wish to still works on Windows XP (backward...)
Env:
-Visual Studio Pro 2015
-Latest version of nuggets.
Error:

Method 'get_StatusCode' in type 'Manatee.Trello.RestSharp.RestSharpResponse' from assembly 'Manatee.Trello.RestSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=783b036be1eaf5a7' does not have an implementation.

Code generating exception:
var addToList = new List("zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz");
Stack:

at Manatee.Trello.Internal.ExceptionHandling.DebugLog.Error(Exception e, Boolean shouldThrow) in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\Internal\ExceptionHandling\DebugLog.cs:line 26
at Manatee.Trello.Internal.DataAccess.JsonRepository.ValidateResponse(IRestRequest request) in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\Internal\DataAccess\JsonRepository.cs:line 64
at Manatee.Trello.Internal.DataAccess.JsonRepository.Execute[T](TrelloAuthorization auth, Endpoint endpoint, IDictionary2 parameters) in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\Internal\DataAccess\JsonRepository.cs:line 29    at Manatee.Trello.Internal.Synchronization.SynchronizationContext1.Merge() in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\Internal\Synchronization\SynchronizationContext.cs:line 160
at Manatee.Trello.Internal.Synchronization.SynchronizationContext.Synchronize(Boolean force) in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\Internal\Synchronization\SynchronizationContext.cs:line 63
at Manatee.Trello.List.get_Id() in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\List.cs:line 82
at Manatee.Trello.ReadOnlyCardCollection..ctor(Type type, Func`1 getOwnerId, TrelloAuthorization auth) in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\CardCollection.cs:line 38
at Manatee.Trello.List..ctor(String id, TrelloAuthorization auth) in C:\Users\gregd\Desktop\Manatee.Trello\Manatee.Trello\List.cs:line 177
at XXX.XXXClasses.Trello.Initialize() in F:\XXXXX\Trello.cs:line 25

So this is happening in .net 4 as well? Okay.
Could you copy your comment over to #32, please? That's where I'm tracking this issue.
I thought it was limited to .net 4.5+, but I suppose I need to re-evaluate.

I have confirmed that the property is missing, and it's the same problem as the issue referenced above, just with RestSharp instead of WebApi.  I'll have an update published soon.

@mathieuchateau, please see Manatee.Trello.RestSharp v1.3.1 now available on Nuget.


Category issue

Translated shop with localization guide in Russian.
When create or rename categories to russian language in CMS, it either becomes not selectable or transforms in empty part of url and doesn't work.
In this case category 'Колонки' transformed in 'n' in url

Hi @DimaJedi,
I know where is the problem. Please follow these steps for your localization:

install slug from NPM $ npm install slug
create a definition file called overrides.js

const slug = require('slug');
const slug_options = { lower: true };

String.prototype.slug = function(max) {
    !max && (max = 60);
    var output = slug(this, slug_options);
    return (output.length > max ? output.substring(0, max) : output);
};

I'll write a blog about this.
Give me a feedback.
Thank you!

Hello @petersirka!
Works extremely fine now!
Thanks a lot.

Hello @DimaJedi  !
How could you transform "Колонки" into "n" ?
I created a definition file called overrides.js but my url is empty and doesn't work yet :-(

@kasraJannati you need at least to rename your page/category or better create again to apply the changes :)
p.s. and I hope you sure made a restart of the app...


Tab key indent on multiple-line selection is weird if any line does not match indent levels

Issue Type: Bug
I have a file with this content, indentation set to 2 spaces
foo
  bar
   foobar

If I select all lines and press TAB once, I would expect two spaces to be added in front of every single line:
  foo
    bar
     foobar

However, it seems like vscode is trying to be smart and indent each line to the next level of indentation (ie n*2 spaces):
  foo
    bar
    foobar

This is incredibly annoying. For example look what happens in my Jinja HTML template (with attributes being aligned below the start of the first one) with this:

    {% trans %}Withdraw{% endtrans %}

After indenting it (4 space indentation here) I get this nonsense:

        {% trans %}Withdraw{% endtrans %}

To me it feels like a bug, but in case people may actually like this it should at least be configurable...
VS Code version: Code - Insiders 1.48.0-insider (2277c8e2a3e1cc630a6397301ba54a1dccd8a60d, 2020-08-07T11:32:09.993Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.97-gentoo

System Info

Item
Value

CPUs
AMD Ryzen 7 2700X Eight-Core Processor          (16 x 3693)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (18.92GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: blackhole

OS
Linux x64 4.19.97-gentoo

CPUs
Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (8 x 1453)

Memory (System)
15.53GB (0.86GB free)

VM
0%

Extensions (33)

Extension
Author (truncated)
Version

systemd-unit-file
coo
1.0.6

udev-rules
dpk
1.0.0

viml
dun
0.1.7

tmux
mal
0.1.0

remote-containers
ms-
0.134.0

remote-ssh
ms-
0.51.0

remote-ssh-edit
ms-
0.51.0

remote-wsl
ms-
0.44.4

vscode-remote-extensionpack
ms-
0.20.0

jinjahtml
sam
0.13.0

gitconfig
sid
2.0.1

mako
tom
0.2.0

vscode-icons
vsc
10.2.0

overtype
ada
0.2.0

vscode-module-templates
asb
1.3.0

vscode-postgres
cko
1.1.11

quick-open-prefill-selection
col
0.0.1

vscode-eslint
dba
2.1.8

gitlens
eam
10.2.2

EditorConfig
Edi
0.15.1

prettier-vscode
esb
5.1.3

go
gol
0.16.1

search-editor-apply-changes
jak
0.1.1

vsc-python-indent
Kev
1.10.1

restructuredtext
lex
129.0.0

MagicPython
mag
1.1.0

vscode-github-actions
me-
3.0.1

vscode-docker
ms-
1.4.1

python
ms-
2020.8.93521-dev

vscode-pylance
ms-
2020.8.0

puppet-vscode
pup
0.28.0

vscode-yaml
red
0.9.1

vscode-stylelint
sty
0.84.0

(1 theme extensions excluded)

The behavior in action:

You can control this and disable snapping to tab stops with "editor.useTabStops": false

@alexdima unfortunately this is not a solution. When I disable this setting I also lose the usual outdent-by-tabstop behavior of the backspace key.
Is there any case where the behavior from my original issue would be what people expect? I'd say no, so IMHO it's still a bug when you select multiple lines and indenting/dedenting them does not apply the same indent/dedent on every single line.

The bug, in my opinion, is that "editor.useTabStops": true is applied on every line independently. This is at least what is causing the inconsistent behavior. To prevent this behavior, what I would expect is the "editor.useTabStops": true being applied on the first line of the multiline selection and all the following lines being [de]indented the same number of spaces.

I appreciate your opinion, but "editor.useTabStops": true is doing exactly what it was designed to do. If you want your code to be aligned at multiples of tab stops, then please continue using "editor.useTabStops": true. If you don't want your code to be aligned at multiples of tab stops, then please configure "editor.useTabStops": false. You cannot have the first line of a statement be aligned and the rest of the statement be not aligned, the editor logic regarding indenting and backspace is not semantic, it does not understand that the next lines contains the same statement, the editor just sees another line.
When "editor.useTabStops": false is configured, indenting will insert a tab stop worth of spaces or a tab character to the starts of all the selected lines. Unindenting will also do the same. This will keep the relative indentation of lines. Backspace will remove precisely one space to allow you to position things at non-multiples of tab stops, how else can you create that 3 spaces indent from 4 spaces.

But this whole issue is about cases where selecting multiple consecutive lines and then using tab or shift-tab applies inconsistent indentation changes to the different lines. Again, I don't think this is something you'd ever want. If you want to fix inconsistent indentation you either use a formatter or fix lines individually.
But the common case when selecting a block of text is that you want to indent/outdent that whole block! I think every other editor does this just fine. The current vscode behavior is inconsistent and right now cannot be disabled except by toggling a setting which also disables other, much more useful, functionality.

how else can you create that 3 spaces indent from 4 spaces.

move cursor one left, and press "del". anyway, this sounds like a normal usecase for the useTabStops setting if you prefer to be able to use backspace for this.

The best is to install a formatter that you like and understands these language specific things.

I agree, unfortunately there is none for jinja+html.

@ThiefMaster
By default "editor.useTabStops" is true. You do not agree with how that works. I get that and that is perfectly fine. Then please configure it to "editor.useTabStops": false.
The idea behind "editor.useTabStops" is that you want your code to align to tab stops or not. You declare that via a setting and then everything makes sure to keep your code aligned or not. We don't support out of the box that you have indenting not aligning to tab stops, but backspace aligning to tab stops.
But that is not a problem! There are very many VS Code extensions that can get you covered.
e.g. Backspace++ https://marketplace.visualstudio.com/search?term=backspace&target=VSCode&category=All categories&sortBy=Relevance
or maybe take a look at all the possible indentation extensions e.g. https://marketplace.visualstudio.com/search?term=indent&target=VSCode&category=All categories&sortBy=Relevance  maybe there is one that indents just the way you want it to.
VS Code is extensible, you are not forced to use only the builtin commands. The builtin commands are serving very many programming languages, and might not fit well with all programming languages, nor with all programming styles.

The idea behind "editor.useTabStops" is that you want your code to align to tab stops or not.

I agree. But do you expect a simple indentation change to perform some kind of re-formatting on the code block you are re-indenting, and not just changing the indentation of the block as a whole?
I still believe this is something completely unrelated to whether one wants to use tabstops in all other cases or not!

Yes, that is intentional. For example, I often copy code from something formatted with spaces (maybe stack overflow) and then I paste it somewhere where I use tabs and then I indent it once and most of the times the indent is fixed. Using "editor.useTabStops" makes it that indenting also replaces the wrongly indented lines with the correct indent. For example, here I copy some lines indented with spaces to an editor configured to indent with tabs. When I indent the lines, notice how a tab is inserted to each line, but also the 4 spaces are converted to tabs. So indenting snaps the lines to tab stops and fixes their indentation. This is what I want to happen, I don't want to end up in a mixed-indentation situation.

Interesting usecase - but is that really an intended usage of the indent/dedent feature?
Wouldn't it be better to have a formatter for this, or an extension that fixes indentation style on paste? (scnr)

Interesting usecase - but is that really an intended usage of the indent/dedent feature?

Yes! That is why I implemented it like that! :) Definitely before we supported format on paste in the editor. I personally use it very often like that. If there is one thing I dislike more than mixed line endings, it is mixed whitespace in indentation. By the way: did you notice that VS Code is one of the only code editors that doesn't support mixed line endings. Mixed line endings have caused me so much pain in the past, so I built an editor where you cannot get mixed line endings :). But now some people want mixed line endings support :). What I'm saying is that sometimes the built-in things may be opinionated, and I am open to being wrong and changing them, but sometimes it is not so clear-cut, so that's why we added these options.

Wouldn't it be better to have a formatter for this, or an extension that fixes indentation style on paste?

Yes, formatters are awesome! But not all languages have formatters, and this behaviour is super helpful for the long tail of programming languages that don't have awesome language servers with good formatters available in VS Code. I sometimes even do cmd+a,tab, shift+tab to quickly "align" some code that I'm randomly working on.
I personally think you might be happy with "editor.useTabStops": false and Backspace++. Please, just give it a try. In fact Johannes did Backspace++ before I had a chance to implement it in the editor's core, so my implementation is based on his extension.

Sure, I don't mind trying the extension. That might fix it for myself.
But I had a few cases where people in my team ended up having messed-up indentation in their PRs due to this strange behavior, and asking everyone to install an extension takes more effort than just trying to get it improved in the core :)

I have to say, I often run into this problem too. Just the other day, I started using prettier in a couple of my projects. So far I have a good opinion of it and will try adding it to more repos. It turns out it was quite easy to add, and via husky, it is configured to run as a pre commit hook. See https://github.com/microsoft/monaco-editor-samples/commit/9dd7846d2542d925372b359827c5d96ee4e14ab0 . I found it liberating to just "give up" and delegate the formatting to an opinionated tool :). I could definitely add it to the CI, etc. But at least I don't need to think too much, I can just run npx prettier --write . if think something's off.


Handle for the async functions?

Hi. This code do nothing:
from pyee import AsyncIOEventEmitter
ee = AsyncIOEventEmitter()

@ee.on('ready')
async def ready():
        print('ready')

if __name__ == '__main__':
        ee.emit('ready')

What can I do?

you need to run the event loop. I would suggest reading asyncio's documentation.

Like
ee = AsyncIOEventEmitter(asyncio.get_event_loop())

?

https://docs.python.org/3/library/asyncio-eventloop.html

Can you, please, give any example?


don't pass URL from server

The reasons for the previous way of doing things are somewhat cloudy — something to do with ensuring that we use the same route in the client as we do on the server, and with the same params, even if the page is prerendered and deployed somewhere that it doesn't expect to be.
But since those things are passed along separately, I think it's preferable to set the URL based on window.location — this means client-side access to search and hash (without weird hacks), and is arguably more correct, even if there is a risk of inconsistency in edge cases.
This will allow us to close #3650 and #3680.
No tests because it's a bit of an awkward thing to test for.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@Rich-Harris it looks like the tests are failing with this PR

the adapter-static changes were a red herring, but worth keeping anyway

Why is this adding devalue? Is that being used anywhere in these changes?

I think this also fixes #1511. Rock on!


Adding telescope & lottery benchmarks

Content
Relates to https://github.com/cardano-scaling/alba/issues/54
Depends on https://github.com/cardano-scaling/alba/pull/105

@tolikzinovyev @curiecrypt @djetchev
Should we remove the benchmarks checking the variance of the number of repetitions (the dfs_bound is so high that we never repeat, which makes criterion fails when generating the plot), or should we lower dfs_bound to observe some variances in retry_counter?
-> Do we want the retry_counter to increase?
Some local tests showed me that we would need to reduce dfs_bound by a factor 100. Choosing this number would feel a bit arbitrary (Is this the right number for all lambdas...?) so I am not sure it is the best option.

@tolikzinovyev @curiecrypt @djetchev
Should we remove the benchmarks checking the variance of the number of repetitions (the dfs_bound is so high that we never repeat, which makes criterion fails when generating the plot), or should we lower dfs_bound to observe some variances in retry_counter? -> Do we want the retry_counter to increase?
Some local tests showed me that we would need to reduce dfs_bound by a factor 100. Choosing this number would feel a bit arbitrary (Is this the right number for all lambdas...?) so I am not sure it is the best option.

Removing the benchmark sounds reasonable!

I find @tolikzinovyev idea the best. What do you think @curiecrypt @djetchev ?

I will not have time to review this PR before Monday, unfortunately, since it is a pretty large.

Rebased on top of https://github.com/cardano-scaling/alba/pull/105 which now is blocking


I found no feedback from the html2canvas promise in IOS13.4

Please make sure you are testing with the latest release of html2canvas.
Old versions are not supported and issues reported for them will be closed.
Please follow the general troubleshooting steps first:

[x] You are using the latest version
[ ] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:
Please replace this line with a brief summary of your issue AND if possible an example on jsfiddle.
Specifications:

html2canvas version tested with:
Browser & version:
Operating system:

Did you find a solution for this, @StubbornG?


Provide @types/react-tournament-bracket

Please provide a @types/react-tournament-bracket module so we can do the following:
npm i @types/react-tournament-bracket
or
yarn add @types/react-tournament-bracket
That way we can apply your module to TypeScript based React-TSX files.

The types are included in the distribution package - you don't need a separate @types package

Fair enough. Is there code for that demo anywhere? Also what format does the game Parma take? Thanks.

The code for the demo is on gh-pages branch but uses the 0.1.x version of the code. Need to update the demo unfortunately but haven't figured out exactly how i want to do it, will probably add a demo folder to master that uses create-react-app and build to gh-pages branch.
The type for the game parameter is described in model.ts, but I want to make it flat for version 0.3 and would love a PR to change the model


Not working with latest @loadable/server & @loadable/babel-plugin v5.16.0 version

🐛 Bug Report
After updating @loadable/server and @loadable/babel-plugin to version v5.16.0 started having an error:
loadable: SSR requires '@loadable/babel-plugin', please install it
To Reproduce
Steps to reproduce the behavior:
Install latest  "@loadable/server" and "@loadable/babel-plugin" version "5.16.0"
Run the app
You will see the message: loadable: SSR requires '@loadable/babel-plugin', please install it
Expected behavior
It should work the same way it worked with previous versions
Link to repl or repo (highly encouraged)
https://github.com/denchiklut/ssr-boilerplate/pull/11

switch to the feat/update branch:
yarn install
yarn dev (u will see an error "loadable: SSR requires @loadable/babel-plugin, please install it")

To see working version:

switch to the main branch
yarn install
yarn dev (this time everything will work)

## System:
 - OS: macOS 13.4.1
 - CPU: (8) arm64 Apple M1 Pro
 - Memory: 63.30 MB / 32.00 GB
 - Shell: 5.9 - /bin/zsh
## Binaries:
 - Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
 - Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.0/bin/yarn
 - npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
## npmPackages:
 - @loadable/babel-plugin: 5.16.0 => 5.16.0
 - @loadable/component: ^5.15.3 => 5.15.3
 - @loadable/server: 5.16.0 => 5.16.0
 - @loadable/webpack-plugin: ^5.15.2 => 5.15.2

@theKashey small update I think the issue is actually only with @loadable/babel-plugin.

Thank you for the insight, that would greatly simply the fix process. @denchiklut +++

Root cause - broken "loadable" detection
In your code you just import your stuff as loadable, and that's it - https://github.com/denchiklut/ssr-boilerplate/blob/414ff83dc991d59e75db92a031f55b279ee19c15/src/client/components/%40shared/app/routes/index.tsx#L7
"Signatures" broken this moment requiring an explicit configuration, which you should want to implement (😉)
In any case, no breaking changes should occur even for not very widely used functionality and the behaviour has been corrected.
Currently it's too late to perform release, I'll do it tomorrow morning (and time zones are hard)

<EMAIL_ADDRESS>should fix the problem


Credential Assignment-High Level Architecture

Update the design link https://github.com/NessDigitalEngineering/salesforce-practice-studio/wiki/Design:-Credential-Assignment-Draft

This is complete.
https://github.com/NessDigitalEngineering/salesforce-practice-studio/wiki/Design:-Credential-Assignment


os: TestNetworkSymbolicLink failure with The network path was not found.

What version of Go are you using (go version)?

$ go version
go version go1.21rc3 windows/amd64

Does this issue reproduce with the latest release?
yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=auto
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Administrator\AppData\Local\go-build
set GOENV=C:\Users\Administrator\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=E:\gofile\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=E:\gofile
set GOPRIVATE=
set GOPROXY=https://goproxy.cn,https://proxy.golang.org,direct
set GOROOT=C:\Users\Administrator\.go\current
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Users\Administrator\.go\current\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.21rc3
set GCCGO=gccgo
set GOAMD64=v2
set AR=ar
set CC=clang
set CXX=clang++
set CGO_ENABLED=0
set GOMOD=
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=D:\TEMP\go-build1363264525=/tmp/go-build -gno-record-gcc-switches
GOROOT/bin/go version: go version go1.21rc3 windows/amd64
GOROOT/bin/go tool compile -V: compile version go1.21rc3
lldb --version: lldb version 16.0.5
gdb --version: GNU gdb (GDB for MinGW-W64 x86_64, built by Brecht Sanders) 13.2

What did you do?
go test os
What did you expect to see?
Test passed.
What did you see instead?
--- FAIL: TestNetworkSymbolicLink (0.08s)
    os_windows_test.go:492: CreateFile \\localhost\GoSymbolicLinkTestShare\: The network path was not found.
FAIL
exit status 1
FAIL    os      6.903s

(attn @golang/windows)
Can you provide some more debugging detail?
If you modify the test to add a time.Sleep(10 * time.Minute) before that t.Fatal, can you see the GoSymbolicLinkTestShare share in, say, Windows Explorer?

Does the same test pass using go1.20.6?

(attn @golang/windows)
Can you provide some more debugging detail?
If you modify the test to add a time.Sleep(10 * time.Minute) before that t.Fatal, can you see the GoSymbolicLinkTestShare share in, say, Windows Explorer?

Execute net share to see GoSymbolicLinkTestShare
D:\TEMP\TestNetworkSymbolicLink514216218\001\GoSymbolicLinkTestShare

add a time.Sleep(10 * time.Minute) before that t.Fatal.
go test -timeout=10000s
--- FAIL: TestNetworkSymbolicLink (600.13s)
os_windows_test.go:494: CreateFile \localhost\GoSymbolicLinkTestShare: The network path was not found.
FAIL
exit status 1
FAIL    os      607.942s

Thanks. Does that test pass using go1.20.6 and go1.19.11 (or a build from source on their respective release branches)?
I wonder if this may be related to https://go.dev/cl/460595.

That error message comes from ERROR_BAD_NETPATH. Unfortunately I can't easily investigate the problem because this test does not run on the Go project's gomote servers:
gopher@GOLANG-BUILDLET C:\workdir\go\src>..\bin\go test os -run=TestNetworkSymbolicLink -v
=== RUN   TestNetworkSymbolicLink
    os_windows_test.go:473: The Server service is not started.
--- SKIP: TestNetworkSymbolicLink (0.00s)
PASS
ok      os      0.029s

@qmuntal, do you have the bandwidth to look into this?

@qiulaidongfeng, does anything about the test change if you patch in https://go.dev/cl/512075?
In particular I wonder if we need to set ACCESS_READ in the SHARE_INFO_2 struct at creation time in order for CreateFile to be able to access the share.

I'm not able to get the test to run without skipping even when running it as an administrator on a local device. 🤯

I finally got my settings sorted out so that the test will run. It passes at HEAD for me.
@qiulaidongfeng, perhaps you have some kind of firewall preventing the test from working?

@bcmills I obtained CL 512075 and found that https://github.com/golang/go/blob/master/src/os/os_windows_test.go#L484 Change to  UNCPath:=shareName+'\'  , and the test will pass on my computer.

That would not be a UNC path — it would no longer be testing the property it aims to test.

I still suspect that this has something to do with a system-specific firewall setting or network-security hook. Since neither I nor @qmuntal are able to reproduce this failure mode and we don't have a specific theory of what could cause it, I am not able to investigate further.
I wonder if it also depends on some specific combination of SMBv1, SMBv2, and/or SMBv3 support (see https://learn.microsoft.com/en-us/windows-server/storage/file-server/troubleshoot/detect-enable-and-disable-smbv1-v2-v3?tabs=server).
Moving to Unplanned since we don't have any apparent way to move forward, and since getting the test to run in the first place — let alone fail! — seems to require a lot of fairly unusual factors (running the test as an administrator, having the service running, and so on).
@qiulaidongfeng, please let us know if you figure out more about what may be causing this test to fail in your setup.

After enabling SMB, the test passed, and I sent CL 512736 to fix the failure when SMB was not enabled.

After enabling SMB, the test passed, and I sent CL 512736 to fix the failure when SMB was not enabled.

There has to be something else. I disabled SMB1 by running Disable-WindowsOptionalFeature -Online -FeatureName SMB1Protocol but I still can't reproduce the TestNetworkSymbolicLink failure.

On my computer, execute Disable WindowsOptionalFeature Online FeatureName SMB1Protocol to turn off SMB and the test will fail. Execute Enable WindowsOptionalFeature Online FeatureName SMB1Protocol to turn on SMB and the test will succeed.

https://learn.microsoft.com/en-us/windows-server/storage/file-server/troubleshoot/smbv1-not-installed-by-default-in-windows says that SMBv1 is not installed by default on some Windows versions, including the version I tested on — and I did not install it explicitly.
But: @qiulaidongfeng, I do think you may be on to something with https://go.dev/cl/512736. If the SMB Server service is running but the client is disabled — or if the server is only serving SMBv2/SMBv3 but the client is only configured to use SMBv1 — then the call to NetShareAdd could succeed (because the server is able to set up the share) but the call to Stat would then fail (because the client is unavailable to connect to it).

@qmuntal Thank you for telling me that disabling SMB can still pass the test. I have found that even if SMB is disabled, enabling the Workstation service on Windows will pass the test.
@bcmills I have updated CL 512736 to avoid testing failures when the Workstation service is not enabled.

@qmuntal Thank you for telling me that disabling SMB can still pass the test. I have found that even if SMB is disabled, enabling the Workstation service on Windows will pass the test.

Yay! I disabled the Workstation and got the The network path was not found error.

Can the WaitingForInfo label be removed?

Label removed. @qiulaidongfeng mark all resolved CL 512736 comments as resolved, either using the Done button or checking the Resolved checkbox. This is normally done by the CL owner, not the reviewer. There are less chances to get reviews if there are  unresolved comments.

Label removed. @qiulaidongfeng mark all resolved CL 512736 comments as resolved, either using the Done button or checking the Resolved checkbox. This is normally done by the CL owner, not the reviewer. There are less chances to get reviews if there are unresolved comments.

Thank you.


Can't run Pleco

I try to run the pleco binary, but nothing happens. Ever since this commit
https://github.com/sfleischman105/Pleco/commit/57250eff05bbd793a5b95772098bcadb0c2cb0f2
the main.rs function has been empty. How am I supposed to run this?

Hi @Melvillian,
Some of the branches got mixed up when pushing. This'll be fixed soon.

Fixed with #40
Right now pleco.rs is only available for use with a UCI interface, or for usage as an external library for implementing chess into your own program. In the future we'll be adding more commands for other uses.