Airflow Generation Update: 1.5 (trigger rules)

Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).

[X] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
[ ] No

Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.

[X] My contribution does NOT include PII data
[ ] My contribution includes PII data

Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

[X] My contribution does NOT contain encryption or other export-controlled technology
[ ] My contribution includes encryption or other export-controlled technology
Contributor.Agreement.nicrobert.txt

Commit does not contain an updated readme that lists an update release date representing the day you last touched it (presumably yesterday). As you have changed the code, readme and About tab need to have that updated release/version date.

@snlwih @Criptic Hey, any reason why it has not been merged yet? I made the changes requested. Thanks.

@nicrobert just that I was out-of-office a lot - sorry about that

SAS Internal Due Diligence Review - COMPLETED on 13MAR2024


Icons should not have hardcoded font size, it prevents them from scaling with text

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Icons (both the <Icon> and specific icon components like <ChevronRight>) inherit their parent's fontSize so that they scale with the text
Current Behavior
Icons have a hardcoded fontSize of 24px.  This makes width: 1em and height: 1em pointless, because the em square is fixed to the element's own fontSize of 24px instead of the parent's font size.
Steps to Reproduce (for bugs)

In this example I have two icons inside of an <h1> with fontSize: 4rem, and also inside of another <h1> with fontSize: 3rem.  The first icon is default and fails to scale to the parent font size.  The second icon has CSS overrides to produce the expected behavior.
https://codesandbox.io/s/8n27qrv9q8

Workaround (in theme.overrides)
  MuiIcon: {
    root: {
      fontSize: 'inherit',
    },
  },
  MuiSvgIcon: {
    root: {
      fontSize: 'inherit',
      verticalAlign: 'middle',
    },
  },

Context

As seen in the example, I am using inline chevron icons as part of a breadcrumb component.
Your Environment

Tech
Version

Material-UI
1.0.0-beta or 1.0.0-rc.1

React
16.2.0

browser
Chrome 66.0.3359.181

@jedwards1211 We have been doing some back and forth on this point in the past: #10349.

This makes width: 1em and height: 1em pointless,

The point is that you can apply a font size instead of changing the width and the height.

Icons (both the  and specific icon components like ) inherit their parent's fontSize so that they scale with the text

This is a tradeoff. We follow the same one than the material font icons set: https://fonts.googleapis.com/icon?family=Material+Icons
...

.material-icons {
  ...
  font-size: 24px;
  ..
}

Also, this is an important breaking change, something we don't want to introduce for the next +6 months.
Maybe we should add a property to the component people can globaly enable with the theme?
theme: {
  props: {
    MuiIcon: {
      fontSize: "inherit",
  },
  MuiSvgIcon: {
    root: {
      fontSize: "inherit",
    },
  }
}

@oliviertassinari I like the component property idea.  Considering that 1em behaves pretty much the same as inherit, it would also be nice if the property passes values other than 'inherit' | 'default' straight to the CSS.
One problem: since both the <Icon> wrapper component and the SVG icons set their own fontSize, one would have to pass the property on both, which is kind of annoying.  Can you think of any way to work around this?

one would have to pass the property on both

@jedwards1211 Why would one have to pass the property on both? Shouldn't a user pick on approach, font vs svg and stick to it?

@oliviertassinari oh...seems I though I had to wrap my svg icons in <Icon> for some reason, was this a relic of an old way of doing things?

@jedwards1211 I don't think that we document this pattern anywhere in the documentation.


New version: MSI.Kombustor.4 version <IP_ADDRESS>

[ x ] Have you signed the Contributor License Agreement?
[ x ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ x ] Have you validated your manifest locally with winget validate --manifest <path>?
[ x ] Have you tested your manifest locally with winget install --manifest <path>?
[ x ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

There is a new version: https://geeks3d.com/dl/show/713

I'm on to it, opened PR here: https://github.com/microsoft/winget-pkgs/pull/98890


Stricter parsing of delivery dates

Canada post is returning some far in the future delivery dates as "1 to 3 months" instead of a timestamp.
DateTime.parse("1 to 3 months").to_s
=> "2011-11-07T00:00:00+00:00"

That's pretty odd. Digging deeper parse tries a number of strategies to try and parse the date correctly, this string is triggering "mon" which returns the date for monday of this week. This change makes delivery date parsing stricter so we don't end up with completely wrong dates. If we want to handle the "1 to 3 months" case for Canada Post in the future we can override date_for.
@odorcicd @jstorimer for review

That's good with me based on the delivery dates that are currently supported :+1:

:+1:

closed by 7ca800d76c8da2116394bbb27562531658f0b720


Question - timing configuration for pictures

I'm using this plugin for a long time and I like it very much.
My use case is as following:
I have reed contacts at garden doors and send an MQTT message on issuing.
camera-ui shall take a screenshot and send and telegram message.
This is working as expected (I'm using the current version v5.0.14)
With my new cameras (Reolink RCL-410W) a have a delay in rtsp and rtmp stream from about 2-3 seconds.
So if the reed contact triggers, homebridge-camera-ui takes immediate the screenshot, but the camera stream has to this time a picture from 2-3 seconds before and I can see nobody on the picture.
I observed the smaller I configure the framerate in the camera (e.g. 6-10) frames, the greater is the delay. Very strange.
But for other software (zoneminder) I need a small frame rate.
My question is: Could it be possible to configure a delay between triggering from mqtt and taking the picture?
Thank you
regards
Andre

added in v5.0.25
add eg "motionDelay": 5 in config.json

Thank you for implementing this


Added Marketing for Engineers by @LisaDziuba

Project URL

https://github.com/LisaDziuba/Marketing-for-Engineers
Description

A curated collection of marketing articles & tools to grow your product.
Why it should be included to awesome-ios (optional)
Because this collection is really good and it is definitely working as I see @LisaDziuba marketing her startup
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 2 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

1806
301
https://github.com/Lab111/Hedwig redirects tohttps://github.com/dereklimbus/hedwig

2070
301
https://github.com/lab111/pivot-slider redirects tohttps://github.com/dereklimbus/pivot-slider

  Generated by :no_entry_sign: Danger

thank you so much :)


xSQLServer: Now it correctly loads the correct assemblies when SqlServer module is present

Pull Request (PR) description

Changes to xSQLServer

Updated appveyor.yml so that integration tests run in order and so that
the SQLPS module folders are renamed to not disturb the units test, but
can be renamed back by the integration tests xSQLServerSetup so that the
integration tests can run successfully.
(issue #774).

Changes to xSQLServerHelper

Changes to Connect-SQL and Import-SQLPSModule

Now it correctly loads the correct assemblies when SqlServer module is
present (issue #649).
Now SQLPS module will be correctly loaded (discovered) after installation
of SQL Server. Previously resources depending on SQLPS module could fail
because SQLPS was not found after installation because the PSModulePath
environment variable in the (LCM) PowerShell session did not contain the new
module path.

Changes to xSQLServerSetup

Fixed so that the integration test renames back the SQLPS module folders if
they was renamed by AppVeyor (in the appveyor.yml file).
(issue #774).
Fixed so integration test does not write warnings when SQLPS module is loaded
(issue #798).

This Pull Request (PR) fixes the following issues:
Fixes #649
Fixes #774
Fixes #798
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[x] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #800 into dev will decrease coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #800   +/-   ##
===================================
- Coverage    97%    96%   -1%
===================================
  Files        30     30
  Lines      3255   3256    +1
===================================
- Hits       3170   3139   -31
- Misses       85    117   +32

Reviewed 2 of 3 files at r1, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 2 of 3 files at r1, 4 of 4 files at r3.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@randomnote1 Big thanks for reviewing this for me!


SICP-JS: Add anchor links feature

Description
Breaking changes, merge together with source-academy/sicp#556.

Added anchor links to each section. Expected behaviour:

Link icon visible on the top right of each section when you hover over the section.
Hovering over the link highlights the relevant section in light-grey, to show which section is being linked to.
Clicking of the link icon adds the link to the address bar, similar to GitHub wiki pages.

https://user-images.githubusercontent.com/60355570/124362149-e8c58b00-dc65-11eb-9337-c7e7aa5a808e.mov
Also fixed:

Footnote links not working
Anchor links not working on Safari

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test

Behaviour should be as described in description section.
Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build 996725242

11 of 16 (68.75%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 30.011%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/features/sicp/TableOfContentsButton.tsx
0
1
0.0%

src/features/sicp/parser/ParseJson.tsx
9
10
90.0%

src/pages/sicp/Sicp.tsx
2
5
40.0%

Totals

Change from base Build 996160950:
-0.01%

Covered Lines:
3196

Relevant Lines:
9805

💛  - Coveralls

Pull Request Test Coverage Report for Build 996725242
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

11 of 16 (68.75%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 30.011%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/features/sicp/TableOfContentsButton.tsx
0
1
0.0%

src/features/sicp/parser/ParseJson.tsx
9
10
90.0%

src/pages/sicp/Sicp.tsx
2
5
40.0%

Totals

Change from base Build 996160950:
-0.01%

Covered Lines:
3196

Relevant Lines:
9805

💛  - Coveralls


How do i change the host thing?

Hi i want to host it on my ip adress instead of localhost, what do i change to make it host there instead of the localhost?
No idea how to add labels :/

that's the default


cloudflare ddos

Here is the code that will bypass cloudflare ddos 100%. Anyway to integrate it with mechanize?

I'd recommend @lord8266's answer.


Sync/v4.18.0

Test failures due to https://github.com/huggingface/transformers/issues/16672.

Closing in favor of #344.


Colliding async routes don't work as expected

👋 If you have two synchronous routes that overlap as I'd expect:
app.get('/a', c => c.text('a'));
app.get('/:slug', c.text('slug'));

Requesting /a returns a, and requesting /b returns slug.
However, if these routes are asynchronous, then things don't behave correctly:
app.get('/a', async c => {
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('a');
});
app.get('/:slug', async c => {
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('slug');
});

Requesting either /a or /b results in slug being returned. Would be great to see this fixed so that there is a deterministic priority for route matching that is consistent.

Fwiw, it looks like this can be worked around for now by doing something like this:
app.get('/a', async c => {
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('a');
});
app.get('/:slug', async (c, next) => {
    if (c.req.param('slug') === 'a') {
        await next();
        return;
    }
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('slug');
});

But, it'd still be great to have this solved in the lib itself. Cheers :)

Hi @MattIPv4 !
It's a bug, I've fixed it in PR #259 .  This bug fix will be included next release.
Thank you.

Thank you! 💙

👋 Hey @yusukebe, I just pulled down the latest release, and it seems that this is partially fixed, but not fully. There seems to be some pollution going on between handlers, and both handlers seem to be invoked.
Taking an example of:
app.get('/a', async c => {
    console.log('a');
    await new Promise(resolve => setTimeout(resolve, 10));
    return c.text('a');
});
app.get('/:slug', async c => {
    console.log('slug');
    await new Promise(resolve => setTimeout(resolve, 10));
    c.status(404);
    return c.text('slug');
});

If I make a request to /a, I do now get back the text a, but the status code is 404 -- polluted by the /:slug handler.
If I then look in console, I see both a and slug logged, so it seems like both handlers are being invoked (with /:slug being invoked first).

Hi @MattIPv4
Actually, the behavior that both handlers are invoked is expected. So,

If I then look in console, I see both slug and a logged

That is not wrong. Because all handlers are treated as Middleware. Every handlers are called, and only one of the Response returned from the handlers will be used for the end user.
It's in the specifications.
BUT, I notice that this design is not good. In this case, only one handler should be processed, console.log should emit only a.
I'll consider about it. Thank you!

@MattIPv4
Hi! We've released v1.4.0.
https://github.com/honojs/hono/releases/tag/v1.4.0
In this release, this issue may be fixed. Check it out.

Just bumped and can confirm this is now behaving in a far more intuitive way to me (first handler that returns stops the chain)! Tyvm!


Scrolling disables carousel on iOS 6 Safari

Hey,
On iOS 6 using Safari if you scroll up or down on any carousel it will disable it from being able to swipe next/previous and even disable the buttons from working.
To recreate:

On your site. go down to "Single Item",
Tap on the carousel and drag the page up or down

Now you can't control the carousel at all - either by buttons, swiping or pagination.
Thanks!

Visiting http://kenwheeler.github.io/slick/
on ipad mini iOS 6.0.1 and ipad 3rd gen 6.01
And can confirm the bug is still happening.


Unexpected Behaviour

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce

✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/dup #31226


test - adjusted margin size

Project Cards had awkward space between the title and the last edited date.
To fix this, I removed the unnecessary marginTop on the last edited date.
Before:

After:

🥳


ARROW-14050: [C++] Make TDigest/Quantile kernels return nulls instead

As requested, this makes it so that TDigest/Quantile return nulls instead of empty arrays, making them easier to consume from bindings, and making them compose better with kernels like list_flatten and list_element.

Works great from the R bindings. Thanks!


Don't provide 'Reply' option for messages that can't be replied to

... e.g. (and possibly i.e.), messages in admin-only streams when the active user is not an admin.
(See also #3528.)

Reopening, as explained here: https://github.com/zulip/zulip-mobile/pull/3811#pullrequestreview-353341099


fix(ffe-cards): Remove screen type from media queries, see #719

Coverage remained the same at 81.459% when pulling 144f858ae15a9b0011b4e84a9f449c5628654add on cards-remove-screen-media into e5b885de1323a8f19028ef7f2e72d866f387fc82 on develop.


Natural Movement Speeds mode [feature request]

What:
A setting in the mod settings tab that enables playing with unmodified, vanilla movement speeds.
Why:
If I understand correctly, when you play on a controller using Controllable mod, your in-game movement speed will be influenced by the analog stick positions on the controller, so you can move more smoothly and gradually, similar to how movement in typical gamepad-supported games works. It's not a typical behavior for a player using keyboard in Minecraft Java. Java players when being in an unobstructed terrain have one of those fixed speed- it's either no movement if "W" key isn't pressed, standard walk speed if it is, or sprint speed, there are no states between though.
The problem comes when you're playing on servers that have anti-cheat systems to detect unusual movement behavior. These systems might pick up on the different movement speeds caused by the Controllable mod and flag it as something suspicious.
In the practice, player with the mod for example might not be able to move if his/her speed is unusual.
An example server with anti-cheat conflicting with the mod: earthmc.net (1.19.4, the behavior can be noticed even in the lobby, no need to wait in the queue)

Additionally some anticheats restrict player's movement to only the directions attainable by pressing the wasd keys (8 possible directions), whilst the analogue stick on the controller allows for many more degrees of motion, causing the anticheat to trigger and block the player from moving.


prevent errors when loading the page

angular-bootstrap-prettify.js fails when the scope is not ready

thanks for this


Add support for webdav/cloud providers via OpenDAL

Would be great if OpenDAL support is added. Ton of cloud providers such as S3/Azure Blobs/Webdav/Google Drive/Dropbox support would come for free.
Here are the list of services supported. https://docs.rs/opendal/latest/opendal/services/index.html

That's a neat library! On first glance, it seems this should be doable by implementing the SourceStream trait for some type wrapping Operator.


"These can be used in anywhere expecting a value."

In this chapter:
https://ziglearn.org/chapter-1/#labelled-blocks
There is this sentence:
"These can be used in anywhere expecting a value."
Which I think sounds odd, but I'm not a native english speaker.

Closed in https://github.com/Sobeston/ziglearn/commit/9c194f3567c06a7947b91e0dbfc4ac1f6d07757d


Fix: Ensure Vagrant default provisioning mode is "once"

Considering:

Default value of python-vagrant for provision is None
python-vagrant documentation states the boolean is optional, defaulting to Vagrant default behaviour (which is to run provisioners once on creation)

The Molecule's Vagrant plugin currently override the default value, defaulting to False, and only settable to True (None is rejected, not being a boolean).
This PR suggests a change so the default value of the Molecule plugin is aligned with python-vagrant's one, and eventually with Vagrant's behaviour.

I can't find the reason for it in git but I think that disabling the provisionning step of vagrant is done on purpose. Since ansible is used later, the instance configuration is supposed to be done with the prepare step. If the problem is missing python for ansible, it can probably be done with the raw module.
What the problem you're having exactly / you're trying to solve ? I don't see that explained clearly in your description.

This is a very surprising stance!
Are you saying the molecule-plugins project decides for users what's good for them with Vagrant?
If you prefer to keep the current default value, that is no problem: all I am requesting is a way to override it when so wished.
Vagrant provides 3 options for provisioning:

Always
Once
Never

python-vagrant provides the means to leverage all those three options.
... and the vagrant module of molecule-plugins withdraws one options from users, hence disempowering them.
Where the provisioning shall be done is to be decided on a case-by-case basis.
Not all provisioning steps apply to all available plugins.

This is a very surprising stance! Are you saying the molecule-plugins project decides for users what's good for them with Vagrant? If you prefer to keep the current default value, that is no problem: all I am requesting is a way to override it when so wished.

I was trying to say that some author of the project has chosen some default, possibly due to the fact that the provisionning should rather be done with molecule prepare step. Of course, it should be possible to override the default and your problem (if I finally understood correctly) is that you can't override it with the value you want. The problem is not the default value.

Vagrant provides 3 options for provisioning:
* Always

* Once

* Never

python-vagrant provides the means to leverage all those three options. ... and the vagrant module of molecule-plugins withdraws one options from users, hence disempowering them.

I've not tested on my test VM but looks like your change is only changing the default value to match the missing use case instead of properly adding support for it. As long as this PR is modifying the default plugin behavior, imho, this PR is wrong.

As long as this PR is modifying the default plugin behavior, imho, this PR is wrong.

The molecule plugin is changing the default Vagrant and python-vagrant behaviour. How wrong is that?

I have a fix https://github.com/ansible-community/molecule-vagrant/pull/174 before migration, and now as https://github.com/ansible-community/molecule-plugins/pull/155 which is working fine for my daily CI.

Issue closing duly noted. I will have tried.
Has this been a waste of my time?

python-vagrant provides python binding for interacting with vagrant with the intent of maintaining the same behavior of vagrent.

This is precisely what I was attempting to address: the molecule Vagrant plugin differs from Vagrant behaviour-wise.
Please re-read my original post, and all my subsequent answers.


[Bug] send message should be disabled if user not enter anything in message input

Description

Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Hello @Rakesh9100 please assign this issue to me under gssoc 24

Pls work on your previous issue first @kapilG0
You can go ahead @sanyaP19

Pls work on your previous issue first @kapilG0
You can go ahead @sanyaP19

Hello @Rakesh9100 sorry but I raised two issue #780 #781 on #780 because description no cleared so it was not assigned to me and on #781 you are saying me to work on previous issue first. Can you please help me out which issue are you talking about


no option to set initial date calendar month view upon opening datepicker window?

minDate seems to prevent selecting dates prior than this value. however the datepicker window will still focus on dates before minDate, I can't seem to find how to do this without setting my datepickers model value.. I want it to function like the start and end date example from bootstrap 2 datepicker where the end  dates selectable and shown are based on the startDate.

Please provide a plunkr reproducing this problem with UI Bootstrap 0.13.0.

Closing due to lack of response & reproduction.


fix: use master's wall time(physical time) as ttl in binlog

Summary by CodeRabbit

New Features

Introduced logic time management to enhance time-related operations in the storage system.

Improvements

Enhanced protection mode to improve the robustness of time-sensitive functions.

Bug Fixes

Improved time updates and logic handling to ensure accurate time retrieval and updating.

从是不会写的 感觉一直都是保护模式？

PR Review 🔍

 ⏱ Estimated effort to review [1-5]
3, because the PR involves multiple files and integrates a new logical time management system across various components, which requires a careful review to ensure consistency and correctness in the implementation.

 🧪 Relevant tests
No

 ⚡ Possible issues
Possible Bug: The UpdateLogicTime method is called before the exec_time_ is updated from the binlog_str in all binlog transverter files. This could lead to using an outdated exec_time_ value.

 🔒 Security concerns
No

 Code feedback:
relevant filesrc/pika_binlog_transverter.cc
suggestion

Consider updating the exec_time_ from binlog_str before calling UpdateLogicTime to ensure the logic time is updated with the correct value. [important]

relevant linestorage::g_storage_logictime->UpdateLogicTime(binlog_item->exec_time());
relevant filetools/binlog_sender/binlog_transverter.cc
suggestion

Update the exec_time_ from binlog_str before calling UpdateLogicTime to prevent using stale execution times. [important]

relevant linestorage::g_storage_logictime->UpdateLogicTime(binlog_item->exec_time());
relevant filetools/pika-port/pika_port_3/binlog_transverter.cc
suggestion

Ensure that exec_time_ is retrieved from binlog_str before updating the logic time to maintain accurate time tracking. [important]

relevant linestorage::g_storage_logictime->UpdateLogicTime(binlog_item->exec_time());

PR Code Suggestions ✨
CategorySuggestion                                                                                ScorePossible bug

Add null pointer check before using g_storage_logictime

Consider checking if g_storage_logictime is initialized before calling UpdateLogicTime to avoid potential null pointer dereference.
src/pika_binlog_transverter.cc [88]
-storage::g_storage_logictime->UpdateLogicTime(binlog_item->exec_time());
+if (storage::g_storage_logictime) {
+  storage::g_storage_logictime->UpdateLogicTime(binlog_item->exec_time());
+} else {
+  LOG(ERROR) << "Logic time storage not initialized";
+}

Suggestion importance[1-10]: 9
Why: This suggestion addresses a potential null pointer dereference, which is a critical issue. Adding a check ensures the code is more robust and prevents crashes.
9
Enhancement

Handle potential errors when fetching the current time

Add error handling for GetCurrentTime in LogicTime::Now to handle potential failures in retrieving the system time.
src/storage/src/storage_time.cc [20]
-rocksdb::Env::Default()->GetCurrentTime(&t);
+if (rocksdb::Env::Default()->GetCurrentTime(&t) != rocksdb::Status::OK()) {
+  LOG(ERROR) << "Failed to get current time";
+  return -1; // or handle error appropriately
+}

Suggestion importance[1-10]: 8
Why: This suggestion improves the robustness of the code by handling potential errors when fetching the current time, which is important for reliability.
8
Possible issue

Ensure thread safety and initialization check for g_storage_logictime->Now()

Ensure that the Now method is thread-safe if g_storage_logictime is accessed from multiple threads, considering the use of atomic variables inside LogicTime.
src/storage/src/base_filter.h [30]
-int64_t unix_time = g_storage_logictime->Now();
+int64_t unix_time;
+if (g_storage_logictime) {
+  unix_time = g_storage_logictime->Now();
+} else {
+  LOG(ERROR) << "Logic time storage not initialized";
+  unix_time = -1; // or handle error appropriately
+}

Suggestion importance[1-10]: 7
Why: This suggestion adds a check for initialization and ensures thread safety, which is important but not as critical as preventing a null pointer dereference.
7
Best practice

Use a safe wrapper function for getting the current time

Replace direct calls to g_storage_logictime->Now() with a function that checks for initialization and handles errors, to improve code reuse and reliability.
src/storage/src/base_value_format.h [139]
-int64_t unix_time = g_storage_logictime->Now();
+int64_t unix_time = GetSafeCurrentTime(); // Implement this function to include checks and error handling

Suggestion importance[1-10]: 6
Why: This suggestion promotes code reuse and reliability by encapsulating error handling in a function, which is a good practice but less critical than addressing direct issues.
6

这个暂时不修复


Regarding Meta tags

Is this package support meta tags?

Hi @anuragbhargava889
Twill is a toolkit to build a headless CMS, you could include any tags in the view templates as you like.


use libsForQt512

Motivation for this change
Since upgrading to 20.09 I have noticed:

okteta crashes on startup
k4dirstat looks terrible
dolphinEmuMaster looks terrible

These changes seem to fix the above issues.
This needs a backport to 20.09.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The dolphin issue seems unrelated to https://github.com/NixOS/nixpkgs/issues/100707.
The okteta issue is definitely related to https://github.com/NixOS/nixpkgs/issues/100707 but currently the list of affected packages there doesn't list it because it was generated by ofborg when kdeFrameworks didn't use qt515 by default.
The k4dirstat issue is the same as okteta.

@aanderse Could you please push the okteta and k4dirstat commits to https://github.com/NixOS/nixpkgs/pull/101369 ? An additional check of these packages with libsForQt5 (515) would be worth it while at it.
There's a Nix script that may be handy to you / me / us if one wishes to verify incompatible qt versions are used together:
https://github.com/NixOS/ofborg/issues/533#issue-717633427

Both okteta and k4dirstat build and run and look fine on https://github.com/NixOS/nixpkgs/pull/101369 , with qt515.

Thanks for your feedback @doronbehar. I'll remove okteta and k4dirstat from this PR.
For reference I have built dolphinEmuMaster 3 ways on/against 20.09 to see the ui:
nix-build -E 'with import <nixpkgs> {}; libsForQt512.callPackage <nixpkgs/pkgs/misc/emulators/dolphin-emu/master.nix> { CoreBluetooth = null; ForceFeedback = null; IOKit = null; OpenGL = null; }'
nix-build -E 'with import <nixpkgs> {}; libsForQt514.callPackage <nixpkgs/pkgs/misc/emulators/dolphin-emu/master.nix> { CoreBluetooth = null; ForceFeedback = null; IOKit = null; OpenGL = null; }'
nix-build -E 'with import <nixpkgs> {}; libsForQt515.callPackage <nixpkgs/pkgs/misc/emulators/dolphin-emu/master.nix> { CoreBluetooth = null; ForceFeedback = null; IOKit = null; OpenGL = null; }'

Only building against libsForQt512 looked correct. When I build dolphinEmuMaster on unstable the ui also looks bad.
So do you agree I should keep this PR, but only the dolphinEmuMaster commit (dropping the other 2) and then backport to 20.09?

Only building against libsForQt512 looked correct. When I build dolphinEmuMaster on unstable the ui also looks bad.

I can't reproduce this on https://github.com/NixOS/nixpkgs/pull/101369 - building with either qt5 there gives an OK looking UI, to my view. Perhaps your environment is polluted, but that doesn't matter with https://github.com/NixOS/nixpkgs/pull/101369.

Thanks for letting me know. Will that PR get back ported to 20.09? It looks massive...

Yes we should.
On Oct 25 2020, at 12:08 pm, Aaron Andersen<EMAIL_ADDRESS>wrote:

Thanks for letting me know. Will that PR get back ported to 20.09? It looks massive...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://github.com/NixOS/nixpkgs/pull/101411#issuecomment-716122354), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ACT5IMZB3TZKCU5YH67RUILSMP2KTANCNFSM4S3T7XXA).

Thanks!


Create new node after releasing the edge drag

Discussed in https://github.com/wbkd/react-flow/discussions/1329

Originally posted by kumarvikramaditya1 July  9, 2021
Is there a way in which we can create a new node from a context menu which gets triggered on releasing an edge drag. Here is some more explanation.

There is a default node created.
Two create a new node:
3. Drag an edge from the handle and release it in the open space.
4. A context menu appears asking a type of node selection
5. On selecting a type, the new node is created and the Source and Target nodes are auto linked.

Any help is appreciated. Thanks !

Let's try to use the issues for bugs and stuff. I will close this in favor of #1329


[1.1.0] Cannot open Modal on load

Hi,
This morning I noticed that Vue-strap has been updated. I am currently developing a form inside a modal so I had the modal automatically opening on load. When I updated this stopped working, and even clicking a button to change the shown property doesn't work. Please see the following jsfiddle,
https://jsfiddle.net/jono20201/ma976td9/1/
As you can see showModal is set to true, but the modal doesn't load. Equally the button doesn't open the modal.
Next see: https://jsfiddle.net/jono20201/ma976td9/2/
If I set showModal to false it still doesn't open on page load (as expected), but I can click the button and it does open successfully.
As a work around I have figured you can do the following in the ready method and it does open on load as expected, but I see this as a but of an odd work around as I'd usually expect setting the default data in Vue to open the modal on load instead of utilising the ready method.
https://jsfiddle.net/jono20201/ma976td9/3/
Is this something that could be fixed?
Thanks for your awesome work.

For some reason the variable stop syncing if you start it as true.
The best solution is change it to true in the ready event.
https://jsfiddle.net/ma976td9/5/
Watch the changes. I hope this work for you.


[AKS] Fix snapshot not resolved according to the subscriptions field in the --snapshot-id option

Related command

az aks create
az aks nodepool add

Description

Fix the issue where snapshot is not resolved according to the subscriptions field in the --snapshot-id option. Otherwise, when the subscription specified by --snapshot-id is inconsistent with the currently logged in subscription, an attempt will be made to obtain the corresponding snapshot through the currently logged in subscription, resulting in an error that the resource cannot be found.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AKS


tokei: fix missing Security framework on macOS

Motivation for this change
It refused to compile for me complaining about the lack of the Security framework on macOS. I also slightly changed the buildInputs because both the framework and libiconv are Darwin specific dependencies. I haven't yet tested this on my NixOS machine, but will try it tomorrow.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build tokei


⚠ ClamAV has degraded performance

In 00ae761, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 697 ms

Resolved: ClamAV performance has improved in 8edee9e.


Parameterized getComponents method

I've made a small modification to the getComponents module to pass in the state params to the user defined getComponents method.
This will allow use-cases like this:
var typeHandler = function(params, cb) {
	switch(params.typename) {
		case 'user': cb(null, PersonCalendarWrapper);
		case 'team': cb(null, GroupCalendarWrapper);
	}
	cb();
}

var periodHandler = function(params, cb) {
	cb(null, require(params.typename + '/' + params.period + '-calendar'));
}

<Router handler={App}>
	<Route name='calendar' path='calendar' components={CalendarMaster}>
		<Route name='type' path=':typename/:id' getComponents={typeHandler}>
			<Route name='period' path=':period' getComponents={periodHandler} />
		</Route>
	</Route>
</Router>

Also included are tests for the entire getComponents module (which were not present before).

+1

+1

we discussed this when we first designed the getComponents and getChildRoutes APIs.
We decided against passing anything to getComponents because 1) the component you provide to a route can read params and render something different, and 2) getChildRoutes can return different routes by reading params. So, sending params to getComponents seems redundant.  Thoughts?

I thihnk it still would be useful to send params especially for something like react-router-relay (when it supports async children). Because that way you would be able to load a different fragment which is wrapped around a component depending on certain params

generally a dupe of #1700, which passes the entire state, which I'd rather do if we do anything at all. Lets discuss over there.

@ryanflorence I might be misunderstanding something, so please go easy on me, but... don't we lose the benefits of the path being parsed on the server side if we use getComponent?
Say I've got a route: <Route path='post/:id' getComponent={getPost} />. If I want to fetch the data first and then return a component (so if there's no post with given id, I will return something like NotFound), then the only place the params would be useful is in fact in the arguments of getComponent - by the time we get to returning the component through callback the data will already be there and the id from the params in props will have no use.
So in this case I have to extract the id myself, which of course isn't something hard to do, but it would be nicer to have the already parsed parameters passed too. Or is my case too
strange?


Bug: The GTM Tag ID shows as "G-XXXXXXX", "UA-XXXXXX" or "AW-XXXXXXX" not GTM-XXXXXX

Info

Tool
Version

Plugin
v2.2.0

Vue
v3.3.4

Node
v18.3.0

OS
win

Input
import { createApp } from 'vue'
import App from './App.vue'
import router from './router'
import { createGtm } from '@gtm-support/vue-gtm';
const app = createApp(App)
app.use(router)
app.use(
    createGtm({
        id: 'AW-XXXXXXXXX', // Your GTM single container ID, array of container ids ['GTM-xxxxxx', 'GTM-yyyyyy'] or array of objects [{id: 'GTM-xxxxxx', queryParams: { gtm_auth: 'abc123', gtm_preview: 'env-4', gtm_cookies_win: 'x'}}, {id: 'GTM-yyyyyy', queryParams: {gtm_auth: 'abc234', gtm_preview: 'env-5', gtm_cookies_win: 'x'}}], // Your GTM single container ID or array of container ids ['GTM-xxxxxx', 'GTM-yyyyyy']
        queryParams: {
            // Add URL query string when loading gtm.js with GTM ID (required when using custom environments)
            // gtm_auth: 'AB7cDEf3GHIjkl-MnOP8qr',
            // gtm_preview: 'env-4',
            // gtm_cookies_win: 'x',
        },
        //source: 'https://customurl.com/gtm.js', // Add your own serverside GTM script
        defer: false, // Script can be set to `defer` to speed up page load at the cost of less accurate results (in case visitor leaves before script is loaded, which is unlikely but possible). Defaults to false, so the script is loaded `async` by default
        compatibility: false, // Will add `async` and `defer` to the script tag to not block requests for old browsers that do not support `async`
        nonce: '7646c7f45a', // Will add `nonce` to the script tag
        enabled: false, // defaults to true. Plugin can be disabled by setting this to false for Ex: enabled: !!GDPR_Cookie (optional)
        debug: false, // Whether or not display console logs debugs (optional)
        loadScript: true, // Whether or not to load the GTM Script (Helpful if you are including GTM manually, but need the dataLayer functionality in your components) (optional)
        vueRouter: router, // Pass the router instance to automatically sync with router (optional)
        //ignoredViews: ['homepage'], // Don't trigger events for specified router names (optional)
        trackOnNextTick: false, // Whether or not call trackView in Vue.nextTick
    }),
);

app.mount('#app')

Output or Error
The app and plugin are not working
Uncaught Error: 'AW-XXXXXXXXX' is not a valid GTM-ID (/^GTM-[0-9A-Z]+$/). Did you mean 'GTM-645401673'?

Expected Output
Working application and plugin

Additional Context

I am not sure if this is bug, because i realized thatt it is from Google Ads tag identificator.

I am not sure if this is bug, because i realized thatt it is from Google Ads tag identificator.

It's not a bug, it's by design
vue-gtm is not usable with nothing else then Google Tag Manager


fix(vite-plugin): remove directoy check on route file

This PR tries to solve this issue
What I did was to remove the check against the appDirectory, the change look safe on the test I run which is based in the reproduction case submitted in the issue. But I don't have the background to know if that check is really needed.
Let me know and I can update the PR 😄

Nice this would also fix https://github.com/remix-run/remix/issues/6711#issuecomment-1880183280

Superceded by #8795
Thanks @lfantone for filing the issue and putting up a PR! 🙏 We want this bug fix to land in time for out 2.7 release and rebasing PRs onto the release branch via GitHub UI is messy... So instead, I recreated this PR in #8795 and tagged you as a co-author in that commit.


Makefile: add platform Makefile to quickly build guest component binaries

Currently we are building AA/CDH/ASR with different and complex compiling parameters controls. To make it simpler for default cases, this commit adds a Makefile with the following assumption:
test: libc=musl, KBC=offline_fs_kbc
tdx: libc=gnu, KBC=cc_kbc_tdx
sev: libc=musl, KBC=online_sev_kbc
Fixes #373
Hi @stevenhorsman @Alex-Carter01 @fidencio @arronwy Please check if it is as expected.

The SEV case makes sense


Integrate fredrikhgrelland/bionic64-ansible-docker base image

What is the issue?
The base image fredrikhgrelland/bionic64-ansible-docker is not regular updated and is outside of this org.
Suggestion(s)/solution(s) [Optional]
Transplant the code from https://github.com/fredrikhgrelland/vagrant-bionic64-ansible-docker into this repository
Checklist (after created issue)

[x] Added label(s)
[ ] Added to project
[x] Added to milestone

Will add ~10 minutes to the build process in GithubActions. Might reduce size of image

https://github.com/fredrikhgrelland/vagrant-bionic64-ansible-docker/issues/6


mmal_vc_component_create failed to create vc.ril.camera

Hello,
installed the web interface on RPI-zero w.
When starting I get an error:
mmal: mmal_vc_component_create: failed to create component 'vc.ril.camera' (1:ENOMEM)
mmal: _component_create_core: could not create component 'vc.ril.camera' (1)
sh: 1: /var/www/html/macros/error_hard.sh: Permission denied

Don't worry about the 3rd permission denied error message. That is just it trying to execute a macro script when it encounters an error.
The first two indicate that it is not managing to connect to the Raspberry camera.
Have you enabled camera support in the Raspbian OS? It is also worth checking using raspivid or raspistill to see if the basic camera is working OK.

Hi Robert,
thanks for the quick responce, you're right, the camera cable is broken )-8


/public/ error

Hi, i have an issue w/ mod_rewrite w/ ci
i moved the index.php to http://localhost/ci/public/ and change the variables
 /*
  *---------------------------------------------------------------
  * SYSTEM FOLDER NAME
  *---------------------------------------------------------------
  *
  * This variable must contain the name of your "system" folder.
  * Include the path if the folder is not in the same  directory
  * as this file.
  *
  */
$system_path = '../system';

/*
 *---------------------------------------------------------------
 * APPLICATION FOLDER NAME
 *---------------------------------------------------------------
 *
 * If you want this front controller to use a different "application"
 * folder then the default one you can set its name here. The folder
 * can also be renamed or relocated anywhere on your server.  If
 * you do, use a full server path. For more info please see the user guide:
 * http://codeigniter.com/user_guide/general/managing_apps.html
 *
 * NO TRAILING SLASH!
 *
 */
$application_folder = '../application';

and an .htaccess in /var/www/ci/
<IfModule mod_rewrite.c>
    RewriteEngine on
    RewriteRule ^$ public/ [L]
    RewriteRule (.*) public/$1 [L]
</IfModule>

and an .htaccess in /var/www/ci/public/
<IfModule mod_rewrite.c>
    RewriteEngine on

    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteCond %{REQUEST_FILENAME} !-d

    RewriteRule ^(.*)$ index.php?/$1 [L]
</IfModule>

Hope you can help :)

i face some issues on CI 2.0.. about hosting problem.. i need some one help.. this is my first project developed using CI. so i face index.php issues in base URL.. ple help me... i used .htaccess but that file cant remove index.php..

probably mod_rewrite is not enabled.


Add DiffHorizontalTransformer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (624ba44) to head (eb9b511).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           50        50
  Lines         1307      1315    +8
  Branches        52        52
=========================================
+ Hits          1307      1315    +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Better structuring of the algorithms

Structure the algorithms based on what they act upon (strings, arrays) or based on the use cases(sorting).

Renaming the files either to include the number for all files or not at all.

After the above tasks are done, make sure the guidelines are updated to the Readme about the changes.

@divyanshu-rawat I am hoping adding a first timers badge would help someone looking to contribute for the first time.

Ya so how to do it ?? @RakshithNM thanks for suggestion 👍

I was specifically talking about adding a label, as in here : https://github.com/camilosampedro/Aton/issues/55. Also would be great to have the up-for-grabs label.


node 0.10.36

It's based on latest formula from https://github.com/Homebrew/homebrew/blob/06b10bc64605ece33b56d2607a1480cf8177fd8f/Library/Formula/node.rb right before it had been bumped to 0.12.x

Any particular reason you want Homebrew to keep supporting the 0.10.x branch? The devel and head blocks would need to be killed here as well.

I've removed both devel and head blocks.
The only reason I'd like to have it is I'm using it now and I cannot switch to 0.12 nor I want to switch to nvm for now. And as there are 0.6 and 0.8, why not to have  0.10 after all? :)

I've removed both devel and head blocks.

Thanks, Appreciated.

And as there are 0.6 and 0.8, why not to have 0.10 after all? :)

To be fair, If it was my choice I wouldn't support 0.6 or 0.8. I can see a justification for 0.10 if absolutely necessary, but I loathe supporting versions that upstream have long since abandoned by upstream and pose potential security issues. Thankfully the choice is not mine :smile_cat:

I totally agree with you here. 0.6.x is no longer supported and when 0.12 came out, 0.8.x stopped being supported as well, so there is no reason to keep updating formulas. For 0.10.x it's different as it's not abandoned yet and we probably gonna see couple more releases of it.

There are some changes in 0.12 that break certain projects, I ran into this. Having 0.10 in homebrew/versions would be a welcome addition for a while.

Plus one here, check out please for instance this node-sass incompatibility.
https://github.com/sass/node-sass/issues/550

No need for +1s :smiley_cat:, the maintainers are likely to accept this when they see it.

@DomT4 I think voting is very important (and actually one of biggest missing features of GitHub) for many reasons:

It answers on your first question - "any particular reason to keep supporting the 0.10.x branch". It's because community needs it for now. Usually it's not easy to get community involved so even 2 people is a good start.
It helps maintainers to stay focus on what is important for community. Otherwise why would you open source your pet and allow people to send PRs? I assume because you wanted to be community-driven. It doesn't mean community is always right, but at least you know that among XXX PRs, people really need A, B and C at this moment.
Maintainers may not accept it nor provide any feedback besides "doesn't make sense", but now they see people are gathering around, so they are expected to give or suggest a workaround, or even change their mind.

I already had 1 answered by you and Roman to an extent I'm happy with. I don't maintain this particular repository (Or Homebrew/Homebrew) so the maintainers may want more, but I'm content it's more than just "Support x old version because that's what we always do".
As for 2 & 3, the maintainers in Homebrew/Homebrew tend to specifically request people don't add votes to an issue or PR. Although I can't read their minds that's potentially because it then makes dealing with that issue/PR a complete nightmare as you have to wade through a billion votes to find the substance you need to resolve the issue/PR one way or another.
I don't think the maintainers are likely to forget the wider community suddenly, Mike has been on a one-man mission the past 2 days to move Homebrew's bottles away from Sourceforge to a new provider which is easily the most anticipated fix/change in Homebrew/Homebrew's issues and PRs for quite some time. It's a huge amount of work but you can see 20+ commits upstream in Homebrew/Homebrew on that change alone for the past 24 hours or so.
This will come to the attention of the maintainers sooner or later, and you'll get maintainer feedback on it. That will happen regardless of voting :smiley:

Just to be clear - I'm not saying that voting means "we need maintainers right here and right now", it just means "whenever you guys have time, please take a look here first". We all appreciate a hard work and no one is in power to command what to do. For sure.

Requested a bundle of changes, just syncing with changes we made in Homebrew/Homebrew's Node in the recent update (other than the version bump obviously) that iron out certain bugs/issues/etc going forwards.
After that, I'm happy to merge this in; There may be a slight hold up whilst Homebrew/Homebrew resolves some bottling issues with new formulae, but I'll merge this in as soon as we resolve that.

All requested changes have been applied.

Thanks!

Merged! Thanks for your contribution to Homebrew, We appreciate it! For future reference, preferred commit message for new formula is node 0.10.36 (new formula). Thanks! :smiley_cat:

Got it, sir. Thank you too! Now it's time to exhale :)


Group name not appearing in-game

Everything seems to work fine except the name of the group (in my case: Founder) is not appearing. If someone could help, that would be great... Thanks
-LM

Unfortunately PermissionsEx is currently unmaintained and no further updates are planned. Because of this, all issues are being closed. If you are looking for an actively maintained permissions plugin, take a look at LuckPerms. It is compatible with major server platforms and can import data from PEX.


Update mcontext_t definition on musl, add fpstate struct

Hello!  This PR updates definitions for x86_64 in musl to match the GNU ones and the current musl headers:
Relevant links for review:

fpstate in musl header
mcontext in musl header
fpstate in Rust libc on GNU
mcontext in Rust libc on GNU

:umbrella: The latest upstream changes (presumably #1649) made this pull request unmergeable. Please resolve the merge conflicts.

@MarkMcCaskey Could you rebase to check CI?
r? @JohnTitor

I'm not sure if we could apply the same way as GNU since musl does a different way. At least, I think _libc_fpstate should be fpregset_t here.

I'm going to close this as inactive. Feel free to re-open if you have some time to resolve the above comment, thanks!


Fix UnresolvedAddressException connecting to job master

Sometimes the InetSocketAddress given to the client is not resolved, causing gRPC to panic when connecting to the server. This change adds a retry mechanism and force a resolution of the hostname before performing connect.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2697/
Test PASSed.

@ggezer @calvinjia PTAL.

alluxio-bot, merge this please.


Floodgate 2.2.2-SNAPSHOT

some notable things

bstats must be shaded
changes to LanguageManager/Logger require that bindings allow guice to create a circular proxy for the circular dependency

Superseded by https://github.com/GeyserMC/Floodgate-Fabric/pull/115 - i've built on top of your commits :p


Dedicated page full support

Do dedicated pages currently support the ability to change the background colour, or is this issue intended to address that? I have been trying to change the background colour scheme to match the home page for hours without success...

@corch yes, this ticket should cover it.

Thanks for merging <3
This should at least address @corch 's issue (which I ran into as well).

If I set a single page to dark section's color I get on single pages a white space between the content and the footer and after the footer.
Looks like this... The first dark area is the content, the latter the footer.

I'm seeing this also. In my case, it looks like this is caused by the bottom padding (1em) of the final p element in the page.
This patch seems to help, can you try?
--- a/assets/css/theme.scss
+++ b/assets/css/theme.scss
@@ -225,7 +225,8 @@ a.fn-item {
   .post {
     margin-top: 0;
     border-bottom: none;
-    padding-bottom: 0;
+    // to account for the margin of content elements
+    padding-bottom: 1em;
   }

   // Kill that stylish little circle that was on the border

the small white space between the content and the footer is gone.
But after the footer I am still seeing white space - it is only to see if the content is shorter than the actual browser window - if there's enough content and you have to scroll the browser window, there is no white space after the footer. I'd expect the white space to have the same background color as the conten.

the small white space between the content and the footer is gone.
But after the footer I am still seeing white space - it is only to see if the content is shorter than the actual browser window - if there's enough content and you have to scroll the browser window, there is no white space after the footer. I'd expect the white space to have the same background color as the conten.

I played around with it and added the height line into theme.scss - that enlarges the content to the entire browser window size. Will play with it a little more.
.page-template {

  background-color: var(--single-page-bg-color);
  color: var(--single-page-text-color);
  height: calc(100vh - 2em);

Is 2em the right amount? How to get the height auf the actual footer?

please see #159


Skyline/work/20210507 skyline batch dev

71 of the 72 files modified were changed in the "fix warnings" commit. Those changes should not impact the code behavior.

Do the warning fixing as a separate PR. Increase the granularity of your PRs to make them easier to review and less likely to contain unexpected consequences.


rename bolt_ppc64le as bolt_powerpc to build ppc64 and ppc64le

part of changes to build docker on openSUSE https://build.opensuse.org/request/show/364697

trial version 3 of the patch

close because still have failure reported by  continuous-integration/appveyor/pr


Regression: some CIFS/SMB3 mounts broken on 22.05 / linux-5.18.8+

Describe the bug
Description in<EMAIL_ADDRESS>Steps To Reproduce
Steps to reproduce the behavior:

find a smb server ("srv") running samba<4.15
mount.cifs -o vers=3.1.1,... //srv ./mntpnt

Expected behavior
Mount works as it did on linux-5.18.7.
Additional context

Also observed by others: https://bugs.archlinux.org/task/75241
From what I can see from the diffstats this hasn't been addressed in 5.18.9 or 5.18.10 so far.

Notify maintainers

Metadata

host os: Linux 5.18.9, NixOS, 22.05 (Quokka), 22.05.1543.71d7a4c037d

According to the Archlinux bug tracker entry this was fixed in kernel commit 32f319183c439b239294cb2d70ada3564c4c7c39 which was contained in 5.19. Closing this issue.


az login --identity error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
 az login --identity -u /subscriptions/<Subscr>/resourcegroups/TEST_MS/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<id>
Errors:
Traceback (most recent call last):
python3/dist-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 608, in execute
    raise ex
cli/core/commands/__init__.py, ln 666, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 659, in _run_job
    six.reraise(*sys.exc_info())
...
python3/dist-packages/msrestazure/azure_active_directory.py, ln 649, in get_token
    token_entry = self._retrieve_token_from_imds_with_retry(resource)
python3/dist-packages/msrestazure/azure_active_directory.py, ln 704, in _retrieve_token_from_imds_with_retry
    raise HTTPError(request=result.request, response=result.raw)
requests.exceptions.HTTPError

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az login --identity -u {}

Expected Behavior
Environment Summary
Linux-5.15.0-1030-azure-x86_64-with-glibc2.29
Python 3.8.10
Shell: bash

azure-cli 2.0.81

Extensions:
azure-devops 0.17.0

Additional Context

@jiasli for awareness

May I know where you are running Azure CLI? As indicated by https://github.com/Azure/azure-cli/issues/15656#issuecomment-716372982, the managed identity on the VM or Azure resource should be configured properly.
Meanwhile, it looks like you are not using the official Azure CLI. See https://github.com/Azure/azure-cli/issues/19640

@jiasli I created standart Ubuntu VM in Azure, and setup cli by "sudo apt-get install azure-cli"

fixed by install CLI from https://github.com/Azure/azure-cli/issues/19640


fix(gravsearch): When link property compared in filter, don't compare link value property, too

https://dasch.myjetbrains.com/youtrack/issue/DSP-594

Thanks for the bug report and the review!


[enhance](buffered reader)add bvar to detect download bytes and download speed

Proposed changes
Issue Number: close #xxx
Add bvar to detect the speed and downloaded bytes for buffered reader

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Update partner endpoints to use new control codes

This PR updates the /partner endpoints to take in a partner-code which is an enum value. For example endpoint/deploy/1
Thoughts on naming convention @makk94 ? Not sure if I should switch between partner and control

Thoughts on naming convention @makk94 ? Not sure if I should switch between partner and control

no strong opinion from me, using partner in the sdk seems fine to me

I would merge, but this is still in draft

Good to go now


applocal.ps1 depends on dumpbin.exe

vcpkg/scripts/buildsystems/msbuild/applocal.ps1:
$(dumpbin /DEPENDENTS $targetBinary |
..
What about if dumpbin is not in %PATH%? I only have msbuild in path, and it is smart enough to figure out where the compiler is.

Generally, applocal.ps1 is intended to be run inside a build environment, such as inside the VS developer prompt or during an MSBuild invocation (as a post-build task).
Could you elaborate more about what situation are you in that is solved by running the script outside of the above environments?

MSBuild can find the location of the compiler/linker tools without my intervention; it can also build for different platforms from a single command prompt, while with VS developer prompt I have to open one command window for each platform. Therefore I prefer to have MSBuild in PATH and do not open VS developer prompt whenever possible.
with VS-template based vcxproj:

msbuild /p:Platform=x64 will invoke:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\CL.exe

msbuild /p:Platform=x86 will invoke:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\CL.exe

Certainly, Msbuild is a much nicer entry to the compiler than constantly switching developer prompts.
However, I'm still curious about what you're looking to achieve by running applocal.ps1 from your main command prompt -- as long as applocal.ps1 is being invoked from inside MSBuild (such as a PostBuildStep), it should work correctly. Additionally, Vcpkg internally handles the developer prompt for you, so inside a portfile the applocal.ps1 script will also run correctly.
We really haven't authored the applocal.ps1 script to be a "public" script that's easy to take out of Vcpkg and use elsewhere; if there's a significant need, that might be an interesting direction to go in the future, but I'd like to know what that need is before considering that script as part of our public "API".

I see. I was reading the said applocal.ps1 file and made an assumption that it was invoked on a bare-bone environment. Actually it is not. When msbuild tries to build a vcxproj, it automatically adjusts PATH etc. to the right VC toolset.
\msbuild\Microsoft.Cpp\v4.0\v140\Microsoft.CppBuild.targets
  <Target Name="InitializeBuildStatus" DependsOnTargets="PrepareForBuild">
  <Target Name="PrepareForBuild" DependsOnTargets="SetBuildDefaultEnvironmentVariables;SetUserMacroEnvironmentVariables;GetResolvedWinMD;$(PrepareForBuildDependsOn)">

\msbuild\Microsoft.Cpp\v4.0\v140\Microsoft.Cpp.Current.targets
  <Target Name="SetBuildDefaultEnvironmentVariables"
    <SetEnv Name   ="PATH"
            Value  ="$(ExecutablePath)"
            Prefix ="false">
      <Output TaskParameter="OutputEnvironmentVariable" PropertyName="Path"/>
    </SetEnv>

\msbuild\Microsoft.Cpp\v4.0\v140\Platforms\x64\PlatformToolsets\v140\Toolset.props
    <ExecutablePath Condition="'$(ExecutablePath)' == ''">$(VC_ExecutablePath_x64);$(WindowsSDK_ExecutablePath);$(VS_ExecutablePath);$(MSBuild_ExecutablePath);$(FxCopDir);$(PATH);</ExecutablePath>

Therefore dumpbin is indeed located when msbuild the project. I double verified it by adding a line of "(get-command dumpbin).Path" to applocal.ps1, and checked the msbuild output contains C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\dumpbin.exe.
Thanks for your time. There is no issue on vcpkg side.


feat(db/redis): remove backward compatibility code

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.
What did you implement:
#186 created a new key (CPE#CACHE#Titles) when fetched, and changed to use it.
However, there is a code that is conscious of backward compatibility in case where CPE#Cache#Titles is not found when searching with a new go-cpe-dictionary without fetching with a new go-cpe-dictionary.
https://github.com/vulsio/go-cpe-dictionary/blob/92597e29a77b0c8f57e109fa7eb331436f381388/db/redis.go#L266-L269
This part is imagined that it is no longer necessary over time, so I will erase it after a certain period of time for the hygiene of the code.
Type of change
Please delete options that are not relevant.

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Checklist:
You don't have to satisfy all of the following.

[ ] Write tests
[ ] Write documentation
[x] Check that there aren't other open pull requests for the same issue/feature
[x] Format your source code by make fmt
[x] Pass the test by make test
[ ] Provide verification config / commands
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES
Reference

@shino
When should we set the deadline? (1 week ?, 1 month ?

How about 2weeks? (geometric mean of the two)

Diff looks nice!
One thing I don't understand yet is...

titleListKey        = "CPE#Titles"
This key is only used in InsertCpes() . Can we remove it completely?

@shino
SET CPE#Titles cannot be deleted because it is necessary to create the StringCPE#Cache#Titles.

:100644 100644 6c3b7cc 0000000 M	db/redis.go

diff --git a/db/redis.go b/db/redis.go
index 6c3b7cc..bea4d6d 100644
--- a/db/redis.go
+++ b/db/redis.go
@@ -72,7 +72,6 @@ const (
 	vpSeparator         = "##"
 	deprecatedCPEsKey   = "CPE#DeprecatedCPEs"
 	titleListKey        = "CPE#Titles"
-	titleListCacheKey   = "CPE#Cache#Titles"
 	titleKeyFormat      = "CPE#Title#%s"
 	depKey              = "CPE#DEP"
 	fetchMetaKey        = "CPE#FETCHMETA"
@@ -255,31 +254,13 @@ func (r *RedisDriver) GetSimilarCpesByTitle(query string, n int, algorithm edlib
 	}

 	ctx := context.Background()
-	t, err := r.conn.Type(ctx, titleListKey).Result()
+	var ts []string
+	bs, err := r.conn.Get(ctx, titleListKey).Bytes()
 	if err != nil {
-		return nil, xerrors.Errorf("Failed to TYPE CPE#Titles. err: %w", err)
+		return nil, xerrors.Errorf("Failed to Get Titles. err: %w", err)
 	}
-
-	var ts []string
-	switch t {
-	case "string":
-		bs, err := r.conn.Get(ctx, titleListKey).Bytes()
-		if err != nil {
-			return nil, xerrors.Errorf("Failed to Get Titles. err: %w", err)
-		}
-		if err := json.Unmarshal(bs, &ts); err != nil {
-			return nil, xerrors.Errorf("Failed to Unmarshal JSON. err: %w", err)
-		}
-	case "set":
-		bs, err := r.conn.Get(ctx, titleListCacheKey).Bytes()
-		if err != nil {
-			return nil, xerrors.Errorf("Failed to Get Titles Cache. err: %w", err)
-		}
-		if err := json.Unmarshal(bs, &ts); err != nil {
-			return nil, xerrors.Errorf("Failed to Unmarshal JSON. err: %w", err)
-		}
-	default:
-		return nil, xerrors.Errorf("unexpected CPE#Titles type. expected: %q, actual: %q", []string{"string", "set"}, t)
+	if err := json.Unmarshal(bs, &ts); err != nil {
+		return nil, xerrors.Errorf("Failed to Unmarshal JSON. err: %w", err)
 	}

 	if len(ts) < n {
@@ -438,7 +419,6 @@ func (r *RedisDriver) InsertCpes(fetchType models.FetchType, cpes models.Fetched
 	for cpeURI := range oldDeps["DeprecatedCPEs"] {
 		_ = pipe.SRem(ctx, deprecatedCPEsKey, cpeURI)
 	}
-	_ = pipe.Del(ctx, titleListCacheKey)
 	for title, cpeURIs := range oldDeps["Title"] {
 		for cpeURI := range cpeURIs {
 			_ = pipe.SRem(ctx, fmt.Sprintf(titleKeyFormat, title), cpeURI)


Dulicate messsage warning

Type: Bug
On any .js file with this code
console.log("eff ".trim().length);
When you hover over the invisible character after eff there is a popup that shows 2 times the same warning.
VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T16:59:02.252Z)
OS version: Windows_NT x64 10.0.22623
Modes:
Sandboxed: No

Sorry VSCode created the issue, but didn't allow to attach a screenshot, so here it is.

The reason there are two messages is that there are actually two characters:

(backspace deletes both at once though)

The reason there are two messages is that there are actually two characters:

Oh, missed that, I though it was 1 space and then that character.


issue install

ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/rtl8812au-legacy-dkms.0.crash'
Error! Bad return status for module build on kernel: 6.2.0-31-generic (x86_64)
Consult /var/lib/dkms/rtl8812au-legacy/4.2.2~ppa/build/make.log for more information.
dpkg: error processing package rtl8812au-legacy-dkms (--configure):
installed rtl8812au-legacy-dkms package post-installation script subprocess returned error exit status 10
Errors were encountered while processing:
rtl8812au-legacy-dkms
E: Sub-process /usr/bin/dpkg returned an error code (1)

You're in the wrong place. This is a driver problem and it should be reported here:
https://github.com/aircrack-ng/rtl8812au/issues
Closed because it is not related to hcxdumptool.


Questions on distributed agents

Hi!
I have been working on a distributed version of the JAX IMPALA agent. I found the distributed TF D4PG to be really helpful for guiding my implementation. However, after making a nearly complete implementation, I have the following questions and hope the Acme maintainers can provide some tips about them.

Creating reproducible environments with different processes. In D4PG, I saw that the agent takes in an environment factory with signature environment_factory(training: bool). I would love to create environments with different seeds in a deterministic way in the actors and evaluators, but I have not found an API for this. Normally in distributed training one would seed the process based on some initial seed and the rank of the worker. However, I couldn't find an API for getting the "rank" of a process. Would the maintainers be able to share some tips on how to implement this behaviour?
I found that I cannot get a graceful shutdown as the reverb process does not seem to respect shutdown signals from LaunchPad. I have no idea why this is failing and it would be really useful if there are some tips regarding this. I would also prefer that LaunchPad does not kill the process after the timeout period by killing the process since I may want to perform some cleanup or continue another experiment in the same process.
About logging. It would be really useful if Acme can support an experiment tracking platform such as wandb, I am not suggesting that Acme should have built-in integration with such platforms, but it should make it easy for such integrations to be possible. I find challenging to incorporate a custom logger. There is currently no API for sending data to a single logger process, and this makes it hard to adopt a common pattern in parallel training such as in MPI where the rank-zero process will be responsible for logging the results for the experiment.

Also interested in answers to this

Regarding question #2 - we have made a number of changes to Launchpad and Reverb integration, so it should not hang anymore. Could you give it a try?

@ethanluoyc I've submitted separate requests for 1) and 3) (we are still working on them) and my understanding is that 2) is no longer an issue. Closing this bug.
Duplicate of #171 and #172


Setting minimum password length to greater than default admin password length leads to failed setup on Docker

As in title.. I set the password length to 20, and a fresh install failed to boot up with this error message during DB migrations:
ActiveRecord::RecordInvalid: Validation failed: Password is too short (minimum is 20 characters)
I had been using it successfully for a while, but I had previously set it up and then changed that config setting to 20 when the admin password already qualified for the minimum length. Sadly, somehow the entire install simply..disppeared, including the database. I wish I could submit a bug report for that one but I haven't the first clue where to source useful log output! Here's hoping that never happens again..
So, uh, maybe permit the default admin password to bypass password length validation, at install time. :)

Hmm that is a good question, you can get around it by passing in the SEED_PASSWORD. I am not sure which behavior is better, always obeying the minimum password length (which the user must have explicitly changed) or ensuring the seed process works even though the password is too short.


Allow line break between } and while

See:
$ goawk 'BEGIN{do{}
while(0)}'
<cmdline>:1:11: expected while instead of <newline>
BEGIN{do{}
          ^
$

POSIX allows line breaks after every closing brace, the one terminating a do group is no exception.

Fixed and merged in #220. Thanks for the report!


[Bug]: Is not posible to create a G/L Account Mapping using Client

Describe the issue
Is not possible to create a new Standard account from the list.
Is not possible to create a new Standard account category using web client.
Expected behavior
The Standard account can be created using web client.
Steps to reproduce

Extend the enum "Standard Account Type" with any new enum.
Create a GL Account Mapping Using new Standard Account Type
Create a Standard Account Group. Here is a new problem. You can do this only with the Configuration package(
Fill out Standard Account Group No. in line and lookup in the field standard account no.
Try to create a new record on the standard accounts page.

Additional context

Great catch! And thank you for reporting the issue. Unfortunately, this repository isn't the right place to report your bug.
In this repository you can create issues concerning the extensibility of Business Central, such as missing events. You can also create issues you would like to fix yourself in the code present in this repository, which are our 1st party apps.
 Do you want me to transfer this issue to the BaseApp pilot repository?
Note, that the transferred issue would have to get approved in triage and you would have to create a pull request yourself. GitHub is not the right place to report issues you would like Microsoft to address. For that, please create a support request.
PS: You need to be granted access to the pilot repo, if you would like to collaborate on the BaseApp with us. To get access, please fill out the following form: https://forms.office.com/r/E9wyE5a58f.
PPS: I recognize that the process on where you can report which issues is a bit messy these days. We're in between processes and hope to be able to streamline and document the right processes in the very near future.

@JesperSchulz  Hello, but the issue related to the AuditFileExport extension, is not about the base application.
As I see in BaseApp contribution pilot. repo contains only base application.

@vlkov, oh my! I'm really sorry! Would you like to provide a fix for this issue you found? Should I reopen and approve the issue?

Yes, I can create a pull request with the fix.

In that case, go right ahead 😊


fix: application edit date is updated when an user is added or remove…

Description
Last edit time of an application was updated when a new user is added or existing user is removed from the corresponding organization.
Fixes #8828
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually
JUnit tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=d2c0fc5

/ok-to-test sha=d2c0fc5

/ok-to-test sha=fdf0800

/ok-to-test sha=8560571

/ok-to-test sha=8560571


writing MC (memory controller) for communication between host and SDRAM

** Goal

Create communication interface between host computer and SDRAM

** requirements

The controller will receive 128bit data (cache line) and transfer it to SDRAM at 16bit granularity.
The communication is bi-directional
The unit will take care of forwarding in case of RAW (read after write) that causes data hazard
The protocol designed to work with DE10-lite SDRAM
Support bursts
Further specifications will be added in the future

issue closed at PR #638


name 'xrange' is not defined

this is the difference between python2 and python3, python3 has removed xrange, instead of range


Switch server from unicorn to puma

coverage: 94.532%. remained the same
when pulling e428f924bd8c553defcebe1caa6102e7fb04b821 on unicorn-to-puma
into<PHONE_NUMBER>540b6a6ed218a152aaaf314c58aff5 on main.

Was just thinking about this due to the outage this morning.  Great to see progress here!


Merge with TypeORM project?

Is your feature request related to a problem? Please describe.
The maintainers of TypeORM are accepting PRs for adding DynamoDB support as of October 2020 https://github.com/typeorm/typeorm/issues/2480#issuecomment-713267562
Describe the solution you'd like

Add DynamoDB support in TypeORM instead.
Recommend TypeORM from TypeDORM README/docs.
Archive the TypeDORM project.

Describe alternatives you've considered

Stick with using TypeDORM.
Use AWS SDK for JavaScript (v3) in TypeDORM as requested in https://github.com/typedorm/typedorm/issues/102

Additional context
The maintainer of TypeDORM @whimzyLive is aware of this update, and has already commented in Feb 2021 https://github.com/typeorm/typeorm/issues/2480#issuecomment-787652081
This issue was created just for tracking purposes.

Hi @trivikr ,
This is indeed a good direction to go ahead in, but this library was written mainly to work with DynamoDB's "single table design pattern", and I do agree to some extent, it does offer support for working with multiple tables.
I am very much keen to see DynamoDB's support in TypeDORM, for which I will do a separate PR and port some logic over from TypeDORM to TypeORM, and once that happens TypeDORM can focus entirely on improving UX for single table design patterns, and TypeORM can be the defacto object mapper for DynamoDB.


Wrong screenshot for the Azure AD app registration

Create an Azure AD app registration to connect to Microsoft Graph under step #9 there is a screenshot which is irrelevant to the topic. Perhaps you would like to fix it :)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9fe69498-a485-5379-97ff-53fbe029f11a
Version Independent ID: 5b3f9705-9e49-1575-4ae7-0293d12b739c
Content: Set up inventory components - Power Platform
Content Source: power-platform/guidance/coe/setup-core-components.md
Service: power-platform
Sub-service: guidance
GitHub Login: @manuelap-msft
Microsoft Alias: mapichle

Thanks for your comment, @TodoroskiAco. This issue has been assigned to the doc author for review.

Thank you, fixed for the next docs update.

This has been updated. Closing out.


JDK 11 base build

Vert.x 5 should switch to JDK 11 as as minimum version, and builds/CI updated accordingly.

[x] Vert.x 5 CI build and deployment with base JDK 11
[ ] Vert.x pom parents allow deploy with JDK 11 for Vert.x 5

I think that Java 11 is old already, you should at least think about jdk 17.
but I think that Vertx would have benefits from all new stuffs coming with jdk21 (records, virtual threads, record pattern matching, string templates, and many others.

among all these features only virtual thread is actually interesting and we will provide this project in Vert.x 4.5 that uses them  https://github.com/vert-x3/vertx-virtual-threads-incubator
the decision of the Java version to use is a balance between the project needs and the user needs, currently we only need Java 8 (besides virtual threads) and wee are moving to Java 11 because it makes Vert.x available to a wider audience of users, the other constraint is Netty 5 that moved to Java 11.


Updates structurizr-export dependency, fixes compilation errors from …

…breaking change in transitive structurizr-core dependency.
I had to make a breaking change in the structurizr-core library (https://github.com/structurizr/java/releases/tag/v1.20.0), and this PR fixes the resulting compilation errors.

Great! Thank you for your contribution :)

Likewise!

@simonbrowndotje, I just made the release 1.2.0, which is now available at the maven repo. So you can update the cli dependency :)


Move some opinionated peerDependencies as optionalDeps (or somewhere else)

IMHO, I would remove these packages as peerDependencies. They are too opinionated
"eslint-config-i-am-meticulous": "^2.0.0",

Maybe others eslint packages as well. User can add there own preset of eslint or using a different linting options
The same reason for stylelint
"stylelint": "^4.0.0",
"stylelint-config-standard": "^1.0.0",

What if I want to use SASS instead of cssnext ?
"postcss-browser-reporter": "^0.4.0",
"postcss-cssnext": "^2.4.0",
"postcss-loader": "^0.7.0",
"postcss-reporter": "^1.3.0",

Maybe opininated (optional) deps should be in referenced in optionalDependencies.
For peer deps are deps used by the default boilerplate (and I think default boilerplate should be a rock solid standard).
For eslint, I should indeed maybe just offer something more "standard" (eslint-config-standard or eslint:recommended).
For stylelint and postcss, like I said in the beginning of my comment, it should be optional but still referenced somewhere so the default boilerplate "just works" by default.

Maybe opininated (optional) deps should be in referenced in optionalDependencies.

Yes. Then merge them into devlDependencies on initial setup right ?

Currently (with latest npm version) peerDeps are not installed, so I am using a trick in the "setup" script to read and install them (saved as dev deps). So we could just save them as dev deps, and if people remove deps, it won't produce any warning. Sound like a solution?

Are you sure? When I remove those deps from devDeps, npm produces warnings about UNMET-DEPENDENCIES , this breaks my build (npm@3)

Because it's in your dev deps AND in statinamic peerdeps. My proposal is to remove from statinamic peer deps (and move to optional) in order to avoid the warning.

:+1:  sound like a solution

So

we should move this (eslint, eslint config, stylelint stylelint config, postcss-* and maybe some other optional peer deps) under a "optionalPeerDependencies" section
we should install those in the "setup" script (since default boilerplate need those)


replace fs-extra usage with native NodeJS fs API

Now NodeJS fs api is pretty comprehensive we may be able to remove dependency on fs-extra and @types/fs-extra

@jeremymeng The biggest outlier is support for fs.cp which is experimental and introduced in 16.7

In addition, we would have to introduce our own file exists such as the following:
import fs from "node:fs/promises";

export async function fileExists(path: string): Promise<boolean> {
  try {
    await fs.access(path, fs.constants.R_OK | fs.constants.W_OK);
    return true;
  } catch {
    return false;
  }
}


Tax details are either missing or don't belong to the tax solution

Just trying to create a basic AP Bill in the system and get hit with the following error.
ResultException: Result status: failure for Control ID: f844fa93-16b8-46f9-875a-f6f33661b21f - BL01001973 Tax details are either missing or don't belong to the tax solution. [Support ID: X6d3pEB030%7EYoHkIP0z3J3--9mWDHwtDwAAABE] Ensure each line item has a tax detail that belongs to the applicable tax solution. - BL01001973 Currently, we can't create the transaction 'V100-001'. Check the transaction for errors or inconsistencies, then try again.
The code being used is
        Intacct.SDK.Functions.AccountsPayable.BillCreate NewInvoice = new Intacct.SDK.Functions.AccountsPayable.BillCreate()
        {
            VendorId = "V125",
            TransactionDate = DateTime.Now,
            BillNumber = "V125-001",
        };

        Intacct.SDK.Functions.AccountsPayable.BillLineCreate NewInvoiceLine = new Intacct.SDK.Functions.AccountsPayable.BillLineCreate()
        {
            TransactionAmount = 44,
            GlAccountNumber = "5002",
            VendorId = "V125",
        };

        NewInvoice.Lines.Add(NewInvoiceLine);

        Task<OnlineResponse> updateTask = client.Execute(NewInvoice);
        updateTask.Wait();

You have to use the non legacy endpoints to create an AP Bill with Tax Entries in it.

@mickbaulch , did the advice above help solve your issue? If so, I'll close this.

closing this as stale, if it's still an issue, please re-open.


What is the reason to have this delay PUT_METHOD_STEP_DELAY_MILLIS?

https://github.com/carlnordenfelt/aws-api-gateway-for-cloudformation/blob/a0bac09d7de63af77be7a99b9e2c1e025fd3facb/lib/service/ApiMethod/ApiMethodService.js#L12

Hi!
That is a relevant question.
There have been issues in the past from time to time where AWS has responded with ConcurrentModificationsException while executing these operations. After long discussions with AWS where they ensured that each API call will complete its actions on their end before responding the only advice they had was to add a delay between the operations. Since adding this I don't think this problem has occurred again.
I should perhaps write a comment about this in the code.
/ Carl

Hi,
Thank you for clarification. I am actually went trough your code because of this issue https://forums.aws.amazon.com/thread.jspa?threadID=226162&tstart=0 when in AWS Console I see the Region: undefined inside** Integration Request **tile.

Interesting.
I've never reflected over the fact that you don't have to specify in which region the lambda is running.
I just checked a method created with this project and Lambda Region is set to eu-west-1.
That value must come either from the fact that my SDK is configured with region = eu-west-1 or extrapolated internally by AWS using the Lambda ARN.
It would be interesting to know where they take it from.
I take it it's ok to close this issue?

Yes. It should be closed.


Roll engine 1a96087747ac..617938024315 (5 commits)

git@github.com:flutter/engine.git/compare/1a96087747ac...617938024315
git log 1a96087747ac..617938024315 --first-parent --oneline
2019-12-03<EMAIL_ADDRESS>Update fallback to Roboto url to be HTTPS (#14086)
2019-12-03<EMAIL_ADDRESS>Revert "Fix fml_unittests (#14062)" (#14087)
2019-12-03<EMAIL_ADDRESS>Revert PRs to unblock David and Jim's work (#14088)
2019-12-03<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 6QxEZ... to OSk8h... (#14085)
2019-12-03<EMAIL_ADDRESS>Roll src/third_party/dart e4344a568f..a4d799c402 (7 commits) (#14083)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


[continuous-integration] build-pretty fails intermittently

It seems that the tool was not found after being installed.
========================================
     check markdown
========================================
npm WARN exec The following package was not found and will be installed<EMAIL_ADDRESS>npm WARN exec The following package was not found and will be installed<EMAIL_ADDRESS>sh: 1: prettier: not found

Example: https://github.com/openthread/openthread/actions/runs/3424574325/jobs/5704405512

The failure seems to happen due to package being installed when we first run it.

Submitted https://github.com/openthread/openthread/pull/9279 which may  help address this (in the PR we install the package in Bootstrap step).


TBI - Improve Function Based Mock Data API

Description
The function based mock data API would benefit from some improvement over functionality.

[x] Include the request as part of the parameters
[x] Include tenant information as well (part of the request though)
[x] updateEntry should include the data that was modified and not only the full data
[x] we should be able to define sap-messages directly from the mock function without necessarily creating an error

The API should stay stable for current consumers but add additional features on top.

Available with version 2.1.0 of @sap/ui5-middleware-fe-mockserver


Docker for Windows version 3.3.1 is much slower than 3.2.2

Problem description
Docker for Windows version 3.3.1 is much slower to stop instances and to start and control
Problem location

I saw the problem after the system did the update of the Docker for Windows, from version 3.2.2 to 3.3.1
I use a docker-compose system very often, and while with 3.2.2 the system would be un in a minute or so,
with 3.3.1 this took about 4-5 minutes without any changes in the dockers I used.
Also, when I gave the command to stop the "docker composition", either from command line (with Ctrl+C) or from Docker Desktop app, my instances stopped much slower with 3.3.1 - something like 2 minutes or so, while with 3.2.2 it was 30 seconds or so (about 4 times faster)
Sometimes even the UI (Docker Desktop app) was slower in it's usage, responding slower to commands

Project version(s) affected
I saw the problem after the system did the update of the Docker for Windows, from version 3.2.2 to 3.3.1
Suggestions for a fix
No suggestions for the fix -- Maybe you will find something that you've introduced that might add time-consuming to all processes of getting images up and running, and stopping them.
Frustrations generated by the issue

My work was affected by the time it took for the docker images to start and stop,
I worked with it for a few days, while I had to finish something,
but after that, as the problem didn't go away, I uninstalled version 3.3.1 and reinstalled version 3.2.2
to get back to normal time-consumption of starting and stopping the docker images

Moving forward / expectations / hopes

I will skip the [installment/ upgrade to] 3.3.1, and I hope/expect a newer version will get back to moving faster/better, more comparable to 3.2.2

Looks like Docker 3.3.3 does not have the issue any more, so looks like it is fixed.
Thank you. I will try to close this issue

Not happening with version 3.3.3


Bug: Named varargs in lambda function

When trying to name your varargs and wrapping it into a lambda function it may cause an error that shouldn't and it's not even making sense, for example:
pluto_use const

const f = |...args| -> tonumber(args) + 1

print(f(1)) --> here: expected '|' to begin & terminate the lambda's paramater list.

But without named varargs it works as it should.

Named varargs are currently not supported in lambdas.

Oh lol i thought thats a bug, alright thanks.

In meantime, you can pass function(...args) return ... end instead of using Lambda.


Move communication to BLE devices to pypi package

This custom component will (hopefully) result in an official integration in Home Assistant. First, a couple of bugs need to be fixed, which will take some time.
When that is finished, the next step would be to create a pypi package that handles the communication part of the code. The official home assistant developers documentation states the following:

All communication to external devices or services must be wrapped in an external Python library hosted on pypi.

This issue is created to collect the information we need, and to discuss the development for this.
Note however that @Magalex2x14 is first focusing on bug fixing the current code.

Instructions to create pypi packages
https://packaging.python.org/tutorials/packaging-projects/

Progress

[x] Created and uploaded an example package at the test environment of pypi.

@Magalex2x14 This issue is not aimed to push you. I just created this issue for myself, so I can start looking into this, collect information and prepare some stuff. Even if it takes months before all bugs are sorted out, I can already start looking into this what we need in the end. I guess, in the end, we can just move part of your code out of sensor.py to the pypi package.

This issue intersects with #9 . It is quite possible that the matter will be solved with the help of existing libraries using the BlueZ D-Bus API.

Ok, it’s not quite clear to me when one should move things to an pypi package and when not. Let’s see after you’ve implemented #9 if this issue is still relevant. Found an example here, maybe helpful for you. https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/test/example-gatt-client

Closing this issue for now. We can always reopen it if needed.


log4j zero day response

In response to https://www.lunasec.io/docs/blog/log4j-zero-day/
@DonRichards and I decided to shim the protection into all JAVA_OPTS and force a build.

Unfortunately when testing, I've encountered an issue:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-container-environment-00-init.sh: executing...
[cont-init.d] 00-container-environment-00-init.sh: exited 0.
[cont-init.d] 00-container-environment-01-override-tomcat.sh: executing...
[cont-init.d] 00-container-environment-01-override-tomcat.sh: exited 0.
[cont-init.d] 00-container-environment-02-database-defaults.sh: executing...
[cont-init.d] 00-container-environment-02-database-defaults.sh: exited 0.
[cont-init.d] 01-confd-render-templates.sh: executing...
[cont-init.d] 01-confd-render-templates.sh: exited 0.
[cont-init.d] 02-ngnix-install.sh: executing...
[cont-init.d] 02-ngnix-install.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
Error: Could not find or load main class ‐Dlog4j2.formatMsgNoLookups=True
[services.d] service tomcat finish: executing...
[services.d] service tomcat exiting with exit code: 1
[services.d] service nginx finish: executing...
[services.d] service nginx exiting with exit code: 0
[cont-finish.d] executing container finish scripts...
[cont-finish.d] done.
[s6-finish] waiting for services.
[s6-finish] sending all processes the TERM signal.
[s6-finish] sending all processes the KILL signal and exiting.

I'll investigate it further

So turns out only fits uses log4j and it's using a super old version 1.2.17 for which the workaround in the CVE will not work since its 2.10.  It would appear that this is of limited risk for users as fits isn't typically exposed so:

An attacker who can control log messages or log message parameters can execute arbitrary code loaded from LDAP servers when message lookup substitution is enabled.

Should not be applicable. That being said it would be nice to update but fits isn't exactly updated frequently https://github.com/harvard-lts/fits.

I'm going to close this for now as it breaks the application, and a lower priority work can be done to investigate what can be done about fits.

Ah I just noticed from Luke's comment on slack about solr, we're currently on and earlier version so again it has the same problem as fits in that this work around doesn't work for earlier versions of log4j.