Docs nav bar doesn't show what section you're in

@CreaturesInUnitards
When in Guides, Reference, Samples, or Support, we should have the horizontal bar highlight this in some way.

yup done


Limit imports from scripts to last compilation block

These changes limit imports coming from scripts to the last compilation block of the script, so scripts won't spam the REPL scope with internal variables.

This looks good! There's some finnickiness with loading modules in modules, but i'll open a new issue for that


Image Creation Issue

Hi, I am creating VkImage with usage VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT and number of layers is bigger than 1 (VkImageCreateInfo.arrayLayers > 1). App is crashing with next log: [mvk-error] VK_ERROR_FEATURE_NOT_PRESENT: vkCreateImage() : This device does not support rendering to array (layered) attachments.
But I don't using layered rendering. I need this usage flag to create image view (2D) for concrete slice and use it as colour attachment. So formally I didn't break some rules. And Metal lets me to do this kind of work, but not MoltenVK.
If I am creating image without this usage flag everything works in iOS, but in MacOS I get errors(not crashes) from validation layers because image views haven't this flag and used as colour attachments.
Will be happy to see your thoughts on this case.

But I don't using layered rendering. I need this usage flag to create image view (2D) for concrete slice and use it as colour attachment. So formally I didn't break some rules. And Metal lets me to do this kind of work, but not MoltenVK.

Thanks for catching this. You are correct. This error is inappropriate during VkImage creation, and should be moved to VkImageView creation, instead.

This error is inappropriate during VkImage creation, and should be moved to VkImageView creation, instead.

@amagdach This is fixed in PR #1443. Please retest with latest version of MoltenVK, and close this issue if fixed.

This fix resolves initial issue and raises next question. If I need to create image view for all layers does it mean that I should shrink usage of image view by using VkImageViewUsageCreateInfo to exclude VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT?

Yes that is correct.

Thank you


Moving the ScrollView's bar when scroll_type=['bars','content'] causes a crash.

Software Versions

Python: 3.8.5
OS: Win 10
Kivy: 2.0.0
Kivy installation method: conda

Describe the bug
Run the program and try moving the bar using the mouse. Note that if you first move the content and then try the bar, the program works properly. Things also work fine when the scroll_type=['bars'] only.
Code and Logs and screenshots
from kivy.uix.gridlayout import GridLayout
from kivy.uix.button import Button
from kivy.uix.scrollview import ScrollView
from kivy.core.window import Window
from kivy.app import runTouchApp

layout = GridLayout(cols=1, spacing=10, size_hint_y=None)
# Make sure the height is such that there is something to scroll.
layout.bind(minimum_height=layout.setter('height'))
for i in range(100):
    btn = Button(text=str(i), size_hint_y=None, height=40)
    layout.add_widget(btn)
root = ScrollView(size_hint=(1, None), size=(Window.width, Window.height),scroll_type=['bars','content'],bar_width=30)
root.add_widget(layout)

runTouchApp(root)

[INFO   ] [Logger      ] Record log in C:\Users\Marko\.kivy\logs\kivy_21-04-01_43.txt
[INFO   ] [Kivy        ] v2.0.0
[INFO   ] [Kivy        ] Installed at "C:\Users\Marko\anaconda3\lib\site-packages\kivy\__init__.py"
[INFO   ] [Python      ] v3.8.5 (default, Sep  3 2020, 21:29:08) [MSC v.1916 64 bit (AMD64)]
[INFO   ] [Python      ] Interpreter at "C:\Users\Marko\anaconda3\python.exe"
[INFO   ] [Factory     ] 186 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: sdl2
[INFO   ] [Window      ] Provider: sdl2
[INFO   ] [GL          ] Using the "OpenGL" graphics system
[INFO   ] [GL          ] GLEW initialization succeeded
[INFO   ] [GL          ] Backend used <glew>
[INFO   ] [GL          ] OpenGL version <b'4.6.0 NVIDIA 456.71'>
[INFO   ] [GL          ] OpenGL vendor <b'NVIDIA Corporation'>
[INFO   ] [GL          ] OpenGL renderer <b'GeForce GTX 970/PCIe/SSE2'>
[INFO   ] [GL          ] OpenGL parsed version: 4, 6
[INFO   ] [GL          ] Shading version <b'4.60 NVIDIA'>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <32>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO   ] [Base        ] Start application main loop
[INFO   ] [GL          ] NPOT texture support is available
[INFO   ] [Base        ] Leaving application in progress...
 Traceback (most recent call last):
   File "c:/Users/Marko/Source/Repos/The Spiral Language/Spiral Compilation Tests/cython_experiments/ui_leduc5/scrollview_bug.py", line 16, in <module>
     runTouchApp(root)
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\base.py", line 582, in runTouchApp
     EventLoop.mainloop()
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\base.py", line 347, in mainloop
     self.idle()
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\base.py", line 391, in idle
     self.dispatch_input()
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\base.py", line 342, in dispatch_input
     post_dispatch_input(*pop(0))
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\base.py", line 301, in post_dispatch_input
     wid.dispatch('on_touch_move', me)
   File "kivy\_event.pyx", line 709, in kivy._event.EventDispatcher.dispatch
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\uix\scrollview.py", line 855, in on_touch_move
     if self.dispatch('on_scroll_move', touch):
   File "kivy\_event.pyx", line 709, in kivy._event.EventDispatcher.dispatch
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\uix\scrollview.py", line 908, in on_scroll_move
     self.effect_x.update(touch.x)
   File "C:\Users\Marko\anaconda3\lib\site-packages\kivy\effects\scroll.py", line 116, in update
     self.displacement += abs(val - self.history[-1][1])
 IndexError: list index out of range

I believe this is fixed in master. Please try that and report back.

I am busy, so I'll take your world for it. Getting this to your attention is good enough for me. When the next version comes out officially I'll give it a try then.


Feature request: "the ability to prevent inputs to the slider node being automatically outputted".

Working with the ui node are find creating a quick ui a breeze! great work!
I have noticed something that might help sync a slider with an external system.
If we can have a tick box that prevents inputs into the slider node being outputted, it would be possible to drive the slider to a level as inputted into it as a feedback signal from an external system (lighting control) for example.
The example is as follows, if I set the slider to 50% I can use the output to drive an external system to 50%. If I then externally adjust the system and input the slider with a value of 100%, it would be great to only have the slider react to the inputted value (100%) as a feedback signal and not output 100% as it creates a feedback loop.
Hope that makes sense?
Thanks
W

You should check node-red-dashboard, it has replaced ui and if I recall the feature you ask for is implemented.


HADOOP-17468. NullPointerException from register in MetricsSystemImpl

https://issues.apache.org/jira/browse/HADOOP-17468

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m  9s

trunk passed

+1 :green_heart:
compile
20m  7s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 54s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
shadedclient
18m  9s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 19s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 17s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
19m 16s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 16s

the patch passed

+1 :green_heart:
compile
17m 27s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 27s

the patch passed

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 29s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 21s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 28s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

178m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2644/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2644

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 042dd76a773e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d82009599a2

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2644/1/testReport/

Max. process+thread count
3011 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2644/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m  9s

trunk passed

+1 :green_heart:
compile
20m  7s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 54s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
shadedclient
18m  9s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 19s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 17s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
19m 16s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 16s

the patch passed

+1 :green_heart:
compile
17m 27s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 27s

the patch passed

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 29s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 21s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 28s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

178m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2644/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2644

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 042dd76a773e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d82009599a2

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2644/1/testReport/

Max. process+thread count
3011 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2644/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


⚠ Processors has degraded performance

In e3602f8, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 44 ms

Resolved: Processors performance has improved in 4184654.


Prevent unnecessary reconciles on provider restarts

What problem are you facing?
Today, when provider pods are restarted (whether it's due to updates to the provider version or simply k8s nodes shuffling), the cache is completely lost forcing the controllers to reconcile all MRs regardless of the last time they were synced and the configured poll frequency.
Depending on the provider, this can be fine and fast, but can sometimes be very slow and even problematic (think external APIs rate limiting). The specific use-case I am referring to is provider-upjet-azure which easily gets rate-limited by the Azure RM API if it gets restarted when managing a large number of MRs.
How could Crossplane help solve your problem?
Since we have no choice but to requeue all objects (this makes sense), I think a nice improvement would be to validate the last time this object (assuming Synced and Ready are both true) was reconciled and calculating based on the poll frequency if it needs to be reconciled again right now or if it should be requeued at the time the poll frequency would be hit.
This would prevent mega bursts of external calls every time we need to restart provider pods, regardless of the reason.

I have done a basic implementation of this on a custom provider by adding the following fields to our MR CRDs:
	SpecHash              string                      `json:"specHash,omitempty"`
	LastExternalReconcile metav1.Time                 `json:"lastExternalReconcile,omitempty"`

The following logic was done in the reconciler:
func (c *External) Observe(ctx context.Context, mg resource.Managed) (managed.ExternalObservation, error) {
	// Calculate the hash of the spec of the MR
	hash, err := ComputeHash(mg)
	if err != nil {
		return managed.ExternalObservation{}, err
	}

	// On first run, the saved hash will be empty and/or the LastExternalReconcile will be empty
	firstRun := GetSpecHash(mg) == "" || GetLastExternalReconcile(mg).IsZero()
	// If the spec has changed or the sync period has passed, we need to resync
	needsResync := GetSpecHash(mg) != hash || GetLastExternalReconcile(mg).Add(*constants.SyncPeriod).Before(time.Now()) || mg.GetCondition(xpv1.TypeReady).Reason == xpv1.Deleting().Reason
	if firstRun || needsResync {
		result, err := c.Handler.Observe(ctx, mg)
		if err != nil {
			return result, errors.Wrap(err, "error in fetching resource")
		}

		if !result.ResourceExists {
			return result, nil
		}

                // Set the calculated hash in the MR status
		SetSpecHash(mg, hash)
                // Set the last external reconcile time in the MR status
		SetLastExternalReconcile(mg, time.Now())

		mg.SetConditions(xpv1.Available())
		return result, nil
	}

	return managed.ExternalObservation{ResourceExists: true, ResourceUpToDate: true}, nil
}

This makes it so a reconcile is done if the MR spec changes or if the Sync time has passed since the last external reconcile.
Hope this gives more detail about what kind of implementation could be done.

Thanks for your efforts to describe this issue and for showing up to community meetings to advocate for it. We appreciate the way you're engaging on this @gravufo 🙇♂
I think the general idea is reasonable to me, so that large deployments can make the conscious trade-off of sync frequency (and drift detection) vs. control plane performance and health. A few thoughts:

should probably be opt-in as opposed to the default behavior, so the minority of users that know they have a lot of resources and potential performance issues can turn it on, while other folks with smaller deployments get the current behavior
these tracking fields like last sync and spec hash could fit better as annotations so that all these objects across the crossplane ecosystem don't have to deal with upgrading their schemas
is this sync period a new value, or would an existing value be reused like syncInterval or pollInterval? https://github.com/crossplane-contrib/provider-upjet-aws/blob/main/cmd/provider/ec2/zz_main.go#L65-L66

these tracking fields like last sync and spec hash could fit better as annotations so that all these objects across the crossplane ecosystem don't have to deal with upgrading their schemas

I wonder how big the hash actually looks? I think we are moved to SSA so things like size of annotation size shouldn't really matter but I do wonder if we hinder the experience of dealing with annotations relating to external-name, by adding the hash in annotations.

Thank you for your feedback @jbw976!
Here are my thoughts about every point you brought up:

should probably be opt-in as opposed to the default behavior, so the minority of users that know they have a lot of resources and potential performance issues can turn it on, while other folks with smaller deployments get the current behavior

I'm definitely not against making this behaviour opt-in, but I would argue that this would benefit everyone, including users in small scale. As a user (large or small scale), I expect my resource to be synced immediately when initially created or when I update the spec and I expect it to be regularly reconciled based on the syncInterval that is set on the provider.
From there on, it would be clear that the pollInterval is simply to ensure we haven't missed an update on the MR at the Kubernetes level and the syncInterval would garantee that your MR will be reconciled at that frequency and no faster (unless something changes in the spec).
Not having this garantee makes the syncInterval parameter quite awkward and hard to understand the real impact.

these tracking fields like last sync and spec hash could fit better as annotations so that all these objects across the crossplane ecosystem don't have to deal with upgrading their schemas

I think this is a possibility, however I see it more like a Condition, just as the Synced and Ready states are set. That is just my impression though, no strong opinion on where it is saved.

is this sync period a new value, or would an existing value be reused like syncInterval or pollInterval? https://github.com/crossplane-contrib/provider-upjet-aws/blob/main/cmd/provider/ec2/zz_main.go#L65-L66

It's actually the syncInterval. I did not seem to find it exposed anywhere for us to use in the Observe function, so I had to save it in a global var at the initial setup of the controller, but this is just a quirk 😅  Ideally we could just use the syncInterval directly and that's probably what we would want if it were to be done in this repo.
About the comment from @blakeromano:

I wonder how big the hash actually looks? I think we are moved to SSA so things like size of annotation size shouldn't really matter but I do wonder if we hinder the experience of dealing with annotations relating to external-name, by adding the hash in annotations.

In our implementation, we used hashstructure which generates small hashes that look like this: specHash: "12301606614063621924". Note that the repo has just been archived a few days ago...Definitely will need to stop using that 😄
That said, I'm pretty sure there's a better way to determine if something has changed and requires an external reconcile. We just used a basic hashing of the spec value as a "quick and dirty way" of achieving our goal.
I appreciate the feedback and I hope we can have a good discussion about this! Thanks everyone 👍

I'm supportive of addressing the issue. I'm not sure about the proposed solution though. Some initial thoughts:

I'd definitely prefer to use status.observedGeneration instead of adding a hash of spec. There's a desire to support that more generally. Work started per https://github.com/crossplane/crossplane/issues/4655, but we only got around to adding the field to all MRs (and XRs? I forget). I don't think we have any code that actually propagates the generation to the observed generation.

I'm ambivalent about making this opt-in. I agree it'd benefit everyone, but it is also a behavior change. I'm not sure how impactful the behavior change would be though. Would anyone be relying on the burst of reconciles at startup time and be surprised if it was more smoothed out?

I don't think we can rely on the status conditions to know when the resource was last reconciled. Their lastTransitionTime only tells you the last time a state transitioned (e.g. the MR moved between ready and unready, or reconcile error and reconcile success). (Maybe you weren't suggesting this? I don't see it in your example code snippet.)

We need to be careful about recording the last reconcile time, since writing that reconcile time will queue a new reconcile. At a glance I don't think your example code would be subject to that issue though since it'd typically return early from the queued reconcile.

Is there anything we could do to the existing controller-runtime / client-go reconcile rate-limiting machinery to smooth out large bursts of reconciles on startup without needing to add tracking fields, additional logic, etc? I wonder if there's any prior art for addressing this issue in other Kubernetes controllers, especially controller-runtime based controllers. I imagine others must have faced similar problems.

I'm ambivalent about making this opt-in. I agree it'd benefit everyone, but it is also a behavior change. I'm not sure how impactful the behavior change would be though. Would anyone be relying on the burst of reconciles at startup time and be surprised if it was more smoothed out?

 I may have been too optimistic about it being enabled by default. I really don't mind if there's a flag, but I think aiming to have this behaviour by default would make more sense to me, because that's how I initially thought it would behave before I actually realized it wasn't. Not sure how we could go about that though...feature flag it and in a major change the default?

I don't think we can rely on the status conditions to know when the resource was last reconciled. Their lastTransitionTime only tells you the last time a state transitioned (e.g. the MR moved between ready and unready, or reconcile error and reconcile success). Maybe you weren't suggesting this? I don't see it in your example code snippet.

I actually don't save it as a condition for that specific reason, I simply saved it as a field straight under status. As mentioned in my previous comment and like you suggested, using something similar to status.observedGeneration may make more sense.

We need to be careful about recording the last reconcile time, since writing that reconcile time will queue a new reconcile. At a glance I don't think your example code would be subject to that issue though since it'd typically return early from the queued reconcile.
Is there anything we could do to the existing controller-runtime / client-go reconcile rate-limiting machinery to smooth out large bursts of reconciles on startup without needing to add tracking fields, additional logic, etc? I wonder if there's any prior art for addressing this issue in other Kubernetes controllers, especially controller-runtime based controllers. I imagine others must have faced similar problems.

I agree that it would be nice to avoid the extra reconcile loop if possible, but exiting early mitigates most of the drawbacks, especially considering that the extra reconcile would only happen when the external api is called only, which is not that frequent (depending on syncInterval and/or spec changes).
I tried to think of other products/controllers in the kubernetes ecosystem that could have the same type of problem and the only thing I thought of is maybe ArgoCD since it reconciles apps every 3 minutes by default and has to sync external git repos and/or helm repos. Not sure if it's exactly the same though.


Update driver: Exception, EditDriverCommand, Driver Status

Codecov Report

Merging #100 (d523b23) into master (5308fd5) will decrease coverage by 1.74%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     42.15%   40.40%   -1.75%
  Complexity      413      413
============================================
  Files           127      130       +3
  Lines          2223     2319      +96
  Branches        263      282      +19
============================================
  Hits            937      937
- Misses         1237     1333      +96
  Partials         49       49

Impacted Files
Coverage Δ

...du/address/logic/commands/DeleteDriverCommand.java
0.00% <0.00%> (ø)

...eedu/address/logic/commands/EditDriverCommand.java
0.00% <0.00%> (ø)

...eedu/address/logic/commands/ListDriverCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
59.25% <0.00%> (-2.28%)
:arrow_down:

.../address/logic/parser/EditDriverCommandParser.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
61.40% <0.00%> (-7.23%)
:arrow_down:

src/main/java/seedu/address/model/AddressBook.java
63.07% <0.00%> (-3.06%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
55.55% <0.00%> (-1.92%)
:arrow_down:

...c/main/java/seedu/address/model/driver/Driver.java
0.00% <0.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5308fd5...d523b23. Read the comment docs.

Looks good! Like the use of enums :)


Primitive boolean attribute doesn't work with entity views

Although we support primitive types now, the special case for the boolean type is problematic. When having an abstract method boolean isAbc() the attribute name extraction fails.

it seems that it's doesn't work in 1.6.8

Thanks for the report @roma2341, but let's discuss the matter about multiset on https://github.com/Blazebit/blaze-persistence/issues/1830


[ Pooling2D ] backwarding

This PR provides backwarding process of Pooling 2D.
. backwarding for max pooling 2D
. backwarding for average pooling 2D
. backwarding global_max, global_averge is NYI.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #192. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.


Youtube link is invalid syntax?

I believe I've installed everything correctly, however upon running the line;
yt_chapters.py --split "https://www.youtube.com/watch?v=5CyezVfR_lA"
I get a syntax error highlighting the entire Youtube link. I'm fairly new to Python, so I'm not exactly sure what I'm doing wrong, but I'll try my best to answer any questions.

Works for me.
I get the following files:

'Maniac - Maniac (Full Album) 1985 - (1.You Don'''t Know It).mp4'
'Maniac - Maniac (Full Album) 1985 - (2.Get Ready).mp4'
'Maniac - Maniac (Full Album) 1985 - (3.Dressed to Kill).mp4'
'Maniac - Maniac (Full Album) 1985 - (4.God of Thunder).mp4'
'Maniac - Maniac (Full Album) 1985 - (5.Ride On).mp4'
'Maniac - Maniac (Full Album) 1985 - (6.Shout it Loud).mp4'
'Maniac - Maniac (Full Album) 1985 - (7.Stage Free).mp4'
'Maniac - Maniac (Full Album) 1985 - (8.We Swear at You).mp4'
'Maniac - Maniac (Full Album) 1985.mp4'

Did you try running it without --split to see if the main installation is working?
Also: please post your actual error rather than saying "I get a syntax error highlighting the entire Youtube link". There's nothing wrong with the syntax.

Tried without the --split, did the same thing. The error simply says;
SyntaxError: invalid syntax

Does youtube-dl work? You won't get the chapters but you will get the download.
Do other python scripts run successfully?
Are you on Windows? Mac? Linux?
Are you running in a Windows command line, Powershell window, bash shell etc.?
Since the code works and I tested your link this evening, it must be something in your configuration or the way you are running it.

Doing a pip installation says that youtube-dl is installed and up to date, but I don't know how else to check it.
Other scripts are working fine.
On Windows 10 Education (64-bit).
Running in Windows command line, tried with and without Python running.

Did you download via git clone or by copying the code into your own file?
The active file in the repo is called yt_chapters, not yt_chapters.py - you probably have file extensions hidden and didn't notice. On Linux you don't need the .py extension as the associations work differently.
Try renaming the script to yt_chapters.py. Not sure why Windows would say SyntaxError: invalid syntax when trying to call a file that doesn't exist.

Then I'm sorry to say it's either the way you have copied it or your system configuration.
The code itself isn't generating the SyntaxError: invalid syntax, I have tested this twice, both with my local copy and cloning the repository. Both work correctly.
I would strongly suggest your redownload using git clone https://github.com/alan1world/yt_chapters.git yt_chapters and then running the file from in there.


Formwrapper and Pdfwrapper cannot fill image field

Hello there,
It seems that the package has difficulties identifying and filling image selection fields.
Here's an example of file with such field: https://www.liguepulmonaire.ch/sites/default/files/documents/fr_musterverordnung-nr.-4.pdf
That's a prescription template.
It detects the field as Checkbox but the field doesn't have the /AP/D properties.
Here's the value of the widget:
{'/A': IndirectObject(665, 0,<PHONE_NUMBER>89648), '/DA': '/SyntaxLTStd-Roman 10 Tf 0 g', '/F': 4, '/FT': '/Btn', '/Ff': 65536, '/MK': {'/IF': {'/FB': True}, '/TP': 1}, '/P': IndirectObject(485, 0,<PHONE_NUMBER>89648), '/Rect': [382.767, 123.965, 541.868, 215.683], '/Subtype': '/Widget', '/T': 'ImageSign', '/Type': '/Annot'}
I will try to reverse engineer the content of the field just as I have done in #559 in order to try to fix this but I guess that won't be an easy trick.

The wrong detection seems to come from these lines:
https://github.com/chinapandaman/PyPDFForm/blob/master/PyPDFForm/patterns.py#L25-L26
Which catch all buttons

So image field is not a widget type that the library supports. I don't think it's explicitly stated in the docs but I can add it later if it ever causes confusions.
The reasons is simple, I do not know what pattern precisely characterizes a widget as an image field. If this ever comes clear someday I can make PdfWrapper support it. This is not hard given it already supports signature field and draw_image. I don't think there will ever be a day that FormWrapper supports image field because I don't think I can feed an image file stream into a image widget even if I know it's an image field. This is the same reason why FormWrapper doesn't support signature field and I made that very clear in the docs.

Hey @chinapandaman,
Indeed, I've searched on the internet and didn't find a standard regarding image fields. I totally understand that it will be hard to implement a standard out of it.
If you wish, I can try to support the signature field in Formwrapper first.

Hey @73VW, it's been a little over a week now. Do you mind if I close this issue? When you have something we could always open another one.

Hey, so I spent today looking into this a bit more. When I compared your PDF with a PDF form with image field of mine, I noticed something that both PDF's image widgets share in common. Both image widgets have an /A property and it has three sub-properties:

/Type with a value /Action
/S with a value /JavaScript
/JS with a value event.target.buttonImportIcon();

I believe the /JS property's script is what get's executed when rendering the image field widget. So I googled event.target.buttonImportIcon(); and all the results I got indicate something related to PDF form's image field.
So I think this is a good enough evidence for identifying image field and I went ahead and wrote this PR. I added your PDF form as a test case and it seemed to work fine.
Anyway, the changes are released. Give v1.4.21 a try and tell me what you think. Docs are also updated.

Hey buddy @chinapandaman,
Sorry for the delay I have been quite busy recently.
I will give a look at your PR, that's very cool!
Best.

Hello everyone, I was trying to fill an image field on a PDF created by LibreOffice. Basically, I do not see the JavaScript code that is mentioned here (maybe is something custom added for conveniently set the image from a reader) so the image field is not recognized as so. In a reader or in a browser if I click on the image field nothing happens.
Trying things around I created in LibreOffice a PDF (exported from a docx) with both a "normal" button and an "image" button, and it seems to me that when exported they are basically the same? I edited the code here just to treat every button as an Image Field (({FT: Btn},),), and both of them are correctly filled with a picture as they were an Image Field. Here are both the DOCX and PDF files.
I think that the image field is just a normal button (with sometimes extra JS code or custom appearance to visually differentiate it) and maybe should be treated as such? So that we can fill every button with an image.
Searching around for other libs that interacts with PDFs I can also see that PDF-LIB doesn't have a specific class for the Image Field and that on the PDFButton class there is the setImage method.

Hey @cip91sk , thanks for posting.
Unfortunately after some experimenting, I cannot make such changes you proposed, for two reasons:

Currently the library tests filling image fields using two different PDFs. sample_template_with_image_field.pdf and 560.pdf which is the one @73VW brought up in this thread. If I open both of them in Adobe Acrobat and click on their image fields there will be a popup that lets me actually insert an image to that field (see screenshots). I also tried your PDF and like what you said when clicked nothing happens. To me this behavior is important to classify a widget as an image field and I do think the secret classifier is the JavaScript code described above.
I cannot just make (({FT: Btn},),), the classifier for image field because it simply classifies too many other types of widgets. It is the base classifier for checkbox and radio buttons and it is also, despite not supported by the library, the classifier for other types of buttons such as clear form. Making it the classifier for image fields will just introduce a lot of problems to the library both now and in the future.

Let me know if you have more questions.

Yes I understand your concerns, and sorry about the classifier I have not made myself clear, it was just a quick and dirty way to test if simple buttons could have an image set to them, not a proposal for effectively making that change in code.
I think there should be a way to recognize all buttons without breaking checkboxes and radios, and as for the clear form button I think it could also have an image set to it. More specifically, I think that all "pressable" buttons (e.g. not checkboxes and radios) should have a way to have an image set.


CONCERN: Documentation of language support - DHM-S1-32

We need some documentation telling us the expected status of support for various languages, so we know what to expect when we test.
I have seen many comments / commits about various languages, but no consolidated overall status.
When switching my phone to Italian, I note the app stays in English.  Is that a bug?  Or do we simply not have Italian language support yet?
I'd like a doc, so that I can know, and raise issues where appropriate.
Probably this shoudl be in the MVP documentation, or successors of that?
https://docs.google.com/document/d/13R-oHWuuodsBBtPH974crMuow0H2UihW6DY5CfkHGgE/edit#heading=h.v6prkwjuyv0f
Can't find any mention (searched for "language" and "translation").

@alpita-masurkar can weigh in on this I guess

Hi @diarmidmackenzie, as Ken mentioned in another issue, there were several translations before that were removed or not merged because the content in the app got changed.
The number 16 that you are referring to is based on this old version and doesn't accurately capture the current status.
If you would like me to update some documentation on the current status of the languages, I'd be happy to add them somewhere.
In the meanwhile, this is the document that I currently use to track our language support: https://docs.google.com/spreadsheets/d/1Vm6RzpgQQ1PvF6ZShHeK9NkBbEHCz0gFCRHe5GYPtUg/edit#gid=1901130528
Do have a look at it and let me know if you'd like something else to ease this process. (Sheet 2 is the sheet for the newer Safe Paths content and the status of various languages)
Thank you.

That info looks good - we just need to work on discoverability of it.  I'll try to do something here in terms of a set of useful links for testers.

Perfect! Let me know how I can help or if you want to move this document somewhere.
Once there's a resolution on how to move forward with this, we can close this issue.

Closing this as we are now using Lokalise.


[New Resource] ErrorLog configuration

Details of the scenario you tried and the problem that is occurring
Request a configuration for controlling the error log configuration for a given instance.
Pretty much would be reading and updating the registry entry that controls this for a given instance since it does not exist within the sys.configurations right now.
Would have two options or properties to validate/set:

LogCount
LogSize (2012+)

Starting in SQL Server 2012+ you have the option for setting the size limit of a log file with the instance, it will cause it to roll over.
The DSC configuration that is using the resource (as detailed as possible)
N/A
Version of the operating system and PowerShell the target node is running
N/A
SQL Server edition and version the target node is running
N/A
What SQL Server PowerShell modules, and which version, are present on the target node.
N/A
Version of the DSC module you're using, or write 'dev' if you're using current dev branch
N/A

Sounds like a good idea, Do you have a suggestion for a name for this resource proposal? There is a naming convention here https://github.com/PowerShell/SqlServerDsc/blob/dev/CONTRIBUTING.md#naming-convention

I would likely say SqlErrorLog would be sufficient. I don't think it needs to be scoped to Server because there is only one ErrorLog in SQL Server. There is an Agent log I know but you can't configure that one in the same manner.

Sounds perfect to me, thank you for suggesting a name! Updated the issue title. It is also labeled help wanted so that anyone in the community can run with this, adding the new resource.

For this resource, maybe we should have a requirement to use the SqlServer (v21.0.17279) module, and not the SQLPS? SqlServer module has the cmdlet Set-SqlErrorLog, and the parameters MaxLogCount and ErrorLogSizeKb .
C:\WINDOWS\system32> get-command Set-SqlErrorLog | select -expand Parameters

Key                 Value
---                 -----
ServerInstance      System.Management.Automation.ParameterMetadata
Credential          System.Management.Automation.ParameterMetadata
ConnectionTimeout   System.Management.Automation.ParameterMetadata
MaxLogCount         System.Management.Automation.ParameterMetadata
ErrorLogSizeKb      System.Management.Automation.ParameterMetadata
InputObject         System.Management.Automation.ParameterMetadata
Path                System.Management.Automation.ParameterMetadata
Script              System.Management.Automation.ParameterMetadata

Just a suggestion. Not a must, if it limits in some other way.


Can not import NotRequired from typing_extensions.py

System Info
Langchain version >= 0.0.198 and python version 3.9
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[x] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction

install python3.9

install following requirements
Flask==1.0.2
jsonobject== 2.1.0
gunicorn==20.1.0
gevent==21.12.0
greenlet==1.1.2
py-healthcheck==1.9.0
aenum==2.2.3
flask-log-request-id==0.10.1
numpy==1.19.5
faiss-cpu==1.7.0
sentence-transformers==2.2.2
contractions==0.0.25
grpcio==1.39.0
tensorflow==2.6.0
tensorflow-serving-api==2.5.2
keras==2.6.0
PyYAML~=6.0
setuptools~=60.10.0
requests~=2.28.2
Werkzeug~=2.2.3
transformers~=4.21.3
Jinja2>=2.10.1,<3.1
itsdangerous==2.0.1
elastic-apm[flask]==6.7.0
langchain==0.0.198
openai==0.27.4
redis==4.5.4
tiktoken==0.2.0
mysql-connector-python==8.0.33
kafka-python==2.0.2
pymongo==3.6.1

import following library --
from langchain.chains.conversational_retrieval.prompts import CONDENSE_QUESTION_PROMPT, QA_PROMPT

Expected behavior
When I am running project with LangChain >= 0.0.198, I am getting exception that Can't Import NotRequired from typing_extensions.py.

Generated by a 🤖
Answer
I found related issues that might be helpful. I did my best to summarize the solutions, but I recommend looking at the related issues yourself.
Related Issues
Closed Issues
import langchain with python<=3.9 fails
The suggested solution is:
Update pydantic to the latest version (1.10.8) which has fixed the issue as mentioned in this pull request. LangChain does not need an update as its pydantic dependency is already set to > 1.
To update pydantic, you can run:
pip install --upgrade pydantic

Then, you can test the update with the following commands:
python -m "import langchain"
pip freeze | grep pydantic

This response is meant to be helpful and save users time. It is not meant to be a precise solution.
Please leave a 👍 if this is helpful and 👎 if it is irrelevant


Cluster init failure is marked as a Warning

Due to a personal misconfiguration rosa init failed to create a cluster.  However, the failure was reported as a W: (warning).  I am using rosa v1.0.5.
❯ rosa init
I: Logged in as 'pratis.openshift' on 'https://api.openshift.com'
I: Validating AWS credentials...
I: AWS credentials are valid!
I: Validating SCP policies...
I: AWS SCP policies ok
I: Validating AWS quota...
I: AWS quota ok
I: Ensuring cluster administrator user 'osdCcsAdmin'...
I: Admin user 'osdCcsAdmin' created successfully!
I: Validating SCP policies for 'osdCcsAdmin'...
I: AWS SCP policies ok
I: Validating cluster creation...
W: Cluster creation failed. If you create a cluster, it should fail with the following error:
In order to run Red Hat OpenShift Service on AWS you need to enable the service in the AWS Console. Please visit https://console.aws.amazon.com/rosa/
I: Verifying whether OpenShift command-line tool is available...
W: Current OpenShift Client Version: v4.7.5
W: Your version of the OpenShift command-line tool is not supported.
Run 'rosa download oc' to download the latest version, then add it to your PATH.

I would assume an E: to be returned once cluster init fails since it is a hard requirement. What do you think?

@dastergon - This doesn't actually create a cluster, it just does a dry-run of cluster creation to see if it would fail or not when actually creating a cluster (through the rosa create cluster command). The rosa init command just preps the account and checks that everything is in order to create the cluster. In this case, your account is set up with quota and permissions, but still need access to the ROSA product itself.
Regardless, I think you bring up a good point. The account is not actually ready to create a cluster, so maybe this should be an error output, rather than a warning.

Thanks for the quick reply @vkareh. I am aware of the steps, I just thought that showing a warning is a bit misleading. Hope it's an easy fix.


feat(FAQs): create faqs and install heroicons

Create FAQs component
Install heroicons
Got an error using "uuid" so use Math.random instead.

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


VASim has no documentation

VASim really needs documentation. Considering using doxygen. Please comment if there is some major issue with using doxygen. Seems like the obvious choice.

Added doxygen documentation in commit faaed156ff425661b2282cbf8e4b0b4a83edae77.


[HOLD 34424] Chat - Not here page shows up when thread loads after joining and leaving thread offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/34376
Action Performed:

Go offline
Send a message
Right click on message > Unsubscribe from thread
Right click on message > Reply in thread.
Click Join
Click 3-dot menu > Leave
Right click on message > Reply in thread
Click on the header subtitle to return to main chat
Right click on message > Reply in thread
Go online.

Expected Result:
Thread view loads successfully.
Actual Result:
Not here page shows up
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/76c95cbd-468e-4c5c-b05b-9a7528298aa0
View all open jobs on GitHub

@paultsimura @srikarparsi Could you check this one out, seems like a regression from the PR you have worked on possibly, but it and edgecase that i dont think this has to be a blocker

Yeah agree,  it does seem like a regression from https://github.com/Expensify/App/pull/34376, I can take this one @AndrewGable

Hey @srikarparsi @mountiny, fortunately (for me 🙂) it's not a regression from our PR. We just enabled the "Leave" button on empty threads and made this bug a
I reverted the PR, and was able to reproduce the same bug with one extra step: need to add a reply in the thread before leaving it (it changes nothing, just shows the "leave" button because the thread becomes non-empty):
https://github.com/Expensify/App/assets/12595293/be8bd88f-50c9-4725-8c19-ff5bdf036173

Thanks! I agree its not direct regression but should be looked at

In the referenced issue – https://github.com/Expensify/App/issues/34424 – the Contributors have posted proposals that will fix this issue as well. The root cause here is that we remove the thread from Onyx once leaving it. And when we come back online, we remove it with this successData:
https://github.com/Expensify/App/blob/b1e2aeb976d32625c3afde22117ff678440dffe9/src/libs/actions/Report.ts#L2118-L2129
Can we just ask for this failure to be tested in that issue as well?

Agree, putting it on hold for https://github.com/Expensify/App/issues/34424

on hold

on hold

on hold, moving to weekly

still on hold

Holding for this now.

This issue is no longer reproducible, closing it out.


[Cluster extension] Enabled custom attribute not loaded

When custom attributes are enabled, all these attributes are set disabled when the zap project is loaded.  I'm using version 2022.10.18.
To replicate:

Create a test.xml file with a single attribute:

<?xml version="1.0" encoding="UTF-8"?>

<configurator>

  <domain name="4Noks" />

  <clusterExtension code="0x0000">

    <attribute
      side="server"
      code="0xFC00"
      define="BOOTLOADER_VERSION_STRING"
      type="CHAR_STRING"
      length="32"
      writable="false"
      default=""
      optional="true"
      manufacturerCode="0x1071"
      >Bootloader Firmware Version</attribute>

  </clusterExtension>

</configurator>

Add test.xml to ZCL Extensions
Enable the attribute (Basic cluster, attribute FC00)
Save the zap project: in the .zap file the custom attribute is successfully saved
Reopen zap e load the project: the custom attribute is disabled

Yeah, this was a plain old bug.
When loading in the zap file with the custom XML, if the package was ALREADY loaded from before, it would not link properly. Therefore this did work correctly if you erase the ~/.zap state directory, since in that case the package would be LOADED and LINKED, but if it was there already, the LINKAGE failed.
I've just pushed a PR that fixed this and I've linked this issue to the PR.


DEV 8543.3 Add a System nodes section which has a button in the UI Initialize System Nodes with a text-box for friendly name of the node, in dashboard.html

https://github.com/Shippable/pm/issues/8543

this is done, closing


feat: Adds config modifier to bigquery job options

Implement Configuration Modifier in BigQuery Jobs.
Note: Integration tests are not added intentionally as nothing is going to change the way backend apis are treated.

Hi @jskeet and @amanda-tarafa ,
Please have a look and share your feedback.
Thanks,


Failed to get sample ad

Failed to get sample ad in iOS after following the step below:

git clone the whole project
pod install
open RewardedVideoExample.xcworkspace in Xcode
change team name in signing (because I want to test it on device)
change Deployment Target to 10.0
Run the app on device and got the following error in Xcode console:
"2018-10-20 08:39:17.066739+0800 RewardedVideoExample[6137:945422]  Cannot find an ad network adapter with the name(s): com.google.DummyAdapter. Remember to link all required ad network adapters and SDKs, and set -ObjC in the 'Other Linker Flags' setting of your build target.
Reward based video ad failed to load: No ad returned from any ad server."

Please indicate I have done anything wrong or missed any step.  Thanks for advance.

Video ad can be served now (Time: 18:12).  Apparently there may be some intermittent problem with the test ad server.  I will close the issue.


Login via OpenID

As
pupil
I want to
log in with other accounts via OpenID
In order to
only remember one password for all my accounts.

OAuth is probably the more recent and most used protocol these days. Although OpenID would still be great for HPI users.

We probably don't have to reinvent the wheel for openID; I found another swt2 project that already implemented that, although I haven't checked the code yet. https://github.com/hpi-swt2/event-und-raumplanung

Check if OmniAuth is compatible with CanCanCan

Check if OmniAuth is compatible with CanCanCan

Authentication is not Authorization, so the question rather was wheter Devise supported OmniAuth. And Devise does, see #663.


nudge

@dotnet-bot test this please

@dotnet-bot build this please

@dotnet-bot test this please

@dotnet-bot test this please

okay maybe Jenkins is able to run the tests reliably now.


Improve tool configuration and usability

#584 started a little discussion on where to put tool configurations (for mypy, pytest, etc).
I would like to propose the following steps to improve the pipeline:
mypy
The mypy configuration has already been moved to pyproject.toml in #584.

Change mypy src/ to mypy . in tox.ini (this currently leads to two easy to fix issues)

pytest

Move the [pytest] section from tox.ini to a [tool.pytest] section in pyproject.toml
Add --cache-clear and -vv to the [tool.pytest] section of pyproject.toml and remove them as command line arguments in tox.ini
Move src/tests to tests and change pytest src/tests {posargs} to pytest {posargs} in tox.ini

pydocstyle

Move the [py257] section from tox.ini to a [tool.pydocstyle] section in pyproject.toml

Where is this configuration used in the pipeline? I don't see pydocstyle being invoked anywhere.
black

Change black --check src/pydocstyle to black --check . in tox.ini

isort

Change isort --check src/pydocstyle to isort --check . in tox.ini

The aforementioned changes allow simply running pytest, mypy ., black . and isort . in the project folder. Furthermore, the changes facilitate setting up these tools in an IDE (e.g., format on save in VS Code) without having to specify any options.

We run pydocstyle on the project at https://github.com/PyCQA/pydocstyle/blob/50894da3e69556ee87066ffcd8e7da59c59577d6/src/tests/test_integration.py#L182

While I am in favor of some of these changes, others will likely either cause problems with tests or unnecessarily large diffs:

Black reformats docstrings, so we wouldn't want it to run on some of the files in test. I can't point to specifics at the moment.
Moving src/test to test and adding Black and isort to more files will create some diffs that will make the commit history more difficult to read. https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/ will make it easier when using GitHub, and other tooling will need to rely on whatever git blame --ignore-revs-file support exists.

If we really want an easy and short version to run commands with different scopes from the terminal, we can add targets to the Makefile. We would have make mypy be mypy src while make black would be make src/pydocstyle. It probably wouldn't help much with other programs, but I believe that some (e.g. PyCharm) do support calling a Makefile.

We run pydocstyle on the project at
https://github.com/PyCQA/pydocstyle/blob/50894da3e69556ee87066ffcd8e7da59c59577d6/src/tests/test_integration.py#L182

But that specifies its own configuration, right? I have just checked and we could simply run pydocstyle via its CLI as part of the tox pipeline.

@aphedges Fair points. That leaves:

Move the [pytest] section from tox.ini to a [tool.pytest] section in pyproject.toml

Add --cache-clear and -vv to the [tool.pytest] section of pyproject.toml and remove them as command line arguments in tox.ini

Move the [py257] section from tox.ini to a [tool.pydocstyle] section in pyproject.toml

@Mr-Pepe, it looks like different configuration is being used in test_pep257_conformance compared to tox.ini. It's probably okay to just delete the [pep257] section entirely and not replace it with anything else. Keeping the two configurations in sync seems like more trouble than it would be worth.


Fix argument coercion in property functions

Fixes #281, and should also fix issues encountered trying to self-build or build corefx where property functions (such as those calling String.TrimEnd()) would fail.
The root cause of the issue was that in porting to .NET Core, I replaced a call to Type.GetMethod with logic that was more strict, requiring all argument types to be assignable to the parameter types, which didn't allow for argument coercion.  This change pulls in more of the reflection code from RuntimeType and DefaultBinder to more closely match full Framework MSBuild's behavior.

I suppose this code duplication is unavoidable?

LGTM though I share the code-duplication concerns.  Do we have a work item here or in CoreFX/CoreCLR to track a permanent resolution of the reasons we've needed to copy code here?

LGTM

I've filed #294 to follow up on the duplicated code.


chore(DIA-942): add tests for auth2

This PR resolves DIA-942
Description
This PR adds tests for the remaining user flows in the new auth flow after #11183.
PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Added more tests for Auth2

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (Added more tests for Auth2 - iskounen)

  Generated by :no_entry_sign: dangerJS against 4f2c669a0ec7b066bb128837371aae2fc24a3e16


New stable release 2.10.22

The current stable release of GIMP is 2.10.22 (2020-10-04)
https://www.gimp.org/downloads/

Is there any news regarding the latest stable version? Why hasn't it been updated yet?


Error: Command failed with ENOENT: vsce verify-pat

When the semantic release action is executed using the vsce plugin in my repo, Testify, i get the following error:
[8:23:46 PM] [semantic-release] › ✖  EINVALIDVSCETOKEN Invalid vsce token. Additional information:

Error: Command failed with ENOENT: vsce verify-pat
spawn vsce ENOENT
Error: AggregateError:
    SemanticReleaseError: Invalid vsce token. Additional information:
    Error: Command failed with ENOENT: vsce verify-pat
    spawn vsce ENOENT
        at module.exports (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release-vsce/lib/verify-auth.js:14:11)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at async module.exports (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release-vsce/lib/verify.js:8:3)
        at async verifyConditions (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release-vsce/index.js:10:3)
        at async validator (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release/lib/plugins/normalize.js:34:24)
        at async /home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release/lib/plugins/pipeline.js:37:34
        at async Promise.all (index 0)
        at async next (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/p-reduce/index.js:16:18)

I am using the GitHub secrets to store my Personal Access Token and I double checked that the token is really there.
I also double checked the permissions of said token in the Azure Portal and it has the necessary access specified in the VSCode documentation
When I run the same command as the plugin locally, I get the following result:
The Personal Access Token verification succeeded for the publisher 'felixjb'.

Is this a bug? Am I doing anything wrong?

One suggestion is to run:
vsce verify-pat

Directly in your workflow.

Alright, I'll do that right now!

Actually, nevermind. I think the issue is due to https://github.com/felipecrs/semantic-release-vsce/pull/294 maybe. I'll check it further.

As a temporary workaround, try to run with the last but one version of the plugin. If it works, please let me know to confirm the issue.

So, I ran the workflow again with the debug logs on and it seems like the variable is there:
##[debug]Evaluating: secrets.VSCE_TOKEN
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'VSCE_TOKEN'
##[debug]=> '***'
##[debug]Result: '***'

Sorry, I didn't get that. I should try again with the second to last version of the plugin?

Yes, exactly 5.0.14.

@felipecrs Do I need to update the version in the package.json too if I'm running the workflow on GitHub Actions?

As a temporary workaround, try to run with the last but one version of the plugin. If it works, please let me know to confirm the issue.

@felipecrs Nope, didn't work either

@felipecrs Do I need to update the version in the package.json too if I'm running the workflow on GitHub Actions?

I don't know... never used the semantic-release-action myself (I just call semantic-release directly).

I just tried using a full access token and even that didn't work.
Do you think it's possible that because I didn't register a NPM_TOKEN for semantic release, as I am using the private: true option for not publishing to npm registry, it is messing up with the VSCE_PAT?

No, I don't think so. Can you try without using the semantic-release action?

Sure. I'll try it now

It seems like it works without the action:

I meant this: https://github.com/felixjb/testify/pull/97

Oh, I see! Wouldn't it be better to make the plugin work with the action?

Yes, but first we need to make sure that's the issue indeed.

Fair enough. Can we continue on this tomorrow then? Haha

What's happening is the following:

The plugin fails to call vsce (we use execa for that) with ENOENT (file not found)
This probably means that vsce isn't in the PATH environment variable.

Probably something different happens in the action which makes the PATH variable not be filled properly (i.e. with node_modules/.bin on it).

@felixjb lol, sure. I'm on vacation anyways!

So, that is it: the plugin cannot verify the PAT when using the GitHub actions at this time. Maybe try explicitly passing the PAT and the publisher to the command can help?

I guess the correct assessment is: the plugin cannot call the vsce binary when running upon @cycjimmy/semantic-release-action.

@cycjimmy do you have any clue on why this is happening? The plugin does not do anything special, it just calls the vsce binary here, the same way other semantic-release plugins do.
The catch is that vsce comes from the NPM dependency, therefore, it's executable is on node_modules/.bin.

Hey @felixjb, I published v5.2.2 which contains a potential fix for this issue. Would you mind testing it? Thanks in advance.

I'm closing this issue as I believe it's fixed. If someone notices the opposite, please comment here and I can reopen it.


Add a site: Remove asterisk on fields that are not required

There are some fields in the "Add a site" form that appear to be required even though they are not. We need to:

Remove the * in the label above these fields; and
Remove any validation associated with these fields.

Here are the fields:
Location tab

[ ] Latitude
[ ] Longitude

Demographic information tab

[ ] Average household size
[ ] Average landholding size.

Would this be part of Sites?

Yup, part of Sites.

I took a closer look at these fields, and it turns out they are required fields. What threw me is that I don't have to enter anything in there. And that's because they put a default value of 0.00 in both cases. I question that approach, but... That's more of a UX issue, and not a validation bug. Closing this ticket as invalid.


Not compiling c++ code giving error of not able to open external programme msbuild.

complile a new one

There were some build issues to do with heap size that were also impacting the upstream codebase. These are now resolved and a new build has been deployed. Can you update and confirm if this issue still exists?

The code has now been adapted for Github/Travis CI and is now released to this repository.
Can you try installing the latest version for your architecture to confirm if this fixes your problem?

Closing this out as I haven't heard anything in some time - please re-open if this is still an issue.


Initialize the input text area with realistic clinical note

Is your proposal related to a problem?
No
Describe the solution you'd like

Pick one clinical note from this archive
Initialize the app so that the selected appears in the input text area
Test the de-identification. Consider customizing the note to make sure that our simple annotators capture at least some annotation. Consider making the selected note more concise so that it fits in the entire text area (no scroll bar visible)

Initialize the input text area with the example text that we use in the Note schema.


add verbosity to environment of created processes

cmake automoc needs VERBOSE=1 in env to print its commands:
cmake generates rules of the form "cd QT && cmake -E cmake_autogen project Debug"
This call to cmake executes the QT moc and uic and rcc compilers which generate files. If any of those calls fail it is impossible to see the actual command lines even if ninja is run with "-v". cmake prints the commands if the environment variable VERBOSE is set - so add this to the current environment.

This feels kinda cmake-specific.  Why not just
VERBOSE=1 ninja ...
?
On Fri, Dec 9, 2016 at 5:15 AM, Martin Haaß<EMAIL_ADDRESS>wrote:

cmake automoc needs VERBOSE=1 in env to print its commands:
cmake generates rules of the form "cd QT && cmake -E cmake_autogen project
Debug"
This call to cmake executes the QT moc and uic and rcc compilers which
generate files. If any of those calls fail it is impossible to see the
actual command lines even if ninja is run with "-v". cmake prints the
commands if the environment variable VERBOSE is set - so add this to the
current environment.
You can view, comment on, or merge this pull request online at:
https://github.com/ninja-build/ninja/pull/1215
Commit Summary

add verbosity to environment of created processes

File Changes

M src/build.cc
https://github.com/ninja-build/ninja/pull/1215/files#diff-0 (2)
M src/subprocess-posix.cc
https://github.com/ninja-build/ninja/pull/1215/files#diff-1 (13)
M src/subprocess-win32.cc
https://github.com/ninja-build/ninja/pull/1215/files#diff-2 (17)
M src/subprocess.h
https://github.com/ninja-build/ninja/pull/1215/files#diff-3 (6)

Patch Links:

https://github.com/ninja-build/ninja/pull/1215.patch
https://github.com/ninja-build/ninja/pull/1215.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ninja-build/ninja/pull/1215, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPB-KoVAnw5NPUlZ7Kk0_ZbDQqMn91ks5rGVRwgaJpZM4LI7Wk
.

VERBOSE=1 ninja  would only put the cmake_generator part into debug mode, not ninja itself, essentially it leads to to mechanisms to turn on verbose output and a user would need to  "VERBOSE ninja -v" to see it all.
With ninja -v the user excpects to see all executed commands, so additionally to the proposed patch the ninja documentation should state that all commands should honor the VERBOSE environment if called from ninja.

Thanks for the PR, but I still think this is too CMake-specific, sorry. IMHO the correct way to fix this, is to further the integration with cmake --build.


Add reducers and actions

This PR Configures and implements Redux toolkit

add redux
configure redux
add reducers for Books
add reducers for categories
implement reducers

Thank you @ShadyShawkat i will make sure it will be corrected

Thanks @ShadyShawkat


Add custom exceptions.

Add a custom exception package for more convenient exception handling and management!

LGTM. Merging!


[DOCS] Baseline setup instructions from a clean AMI

Is your feature request related to a problem? Please describe.
I'm trying to run install.sh and it seems to make some assumptions about what OS I'm running, and what I have installed. It also seems to have a problem validating the default config. I'm guessing you have an existing workspace, which works for you.
Describe the solution you'd like
Some documentation or scripts that can get this working from a clean base AMI like ALinux2023. That way there's a good known version, and no version mismatches for tooling or libraries.

Thanks for reporting the issue. I do most of my testing using Amazon Linux 2. I haven't tested with Amazon Linux 2023. I have done testing in the past with RHEL 8 and RHEL 9.

Let me know if I should open a separate issue for this, but I setup a clean ALinux2 instance, checked out the code, and ran install.sh, and it errored out with the following:
Working directory: /home/ec2-user/aws-eda-slurm-cluster/source
INFO:
====== Validating AWS environment ======

INFO: Using default config: /home/ec2-user/aws-eda-slurm-cluster/source/resources/config/default_config.yml
/home/ec2-user/aws-eda-slurm-cluster/source/.venv/lib64/python3.7/site-packages/boto3/compat.py:82: PythonDeprecationWarning: Boto3 will no longer support Python 3.7 starting December 13, 2023. To continue receiving service updates, bug fixes, and security updates please upgrade to Python 3.8 or later. More information can be found here: https://aws.amazon.com/blogs/developer/python-support-policy-updates-for-aws-sdks-and-tools/
  warnings.warn(warning, PythonDeprecationWarning)
Traceback (most recent call last):
  File "source/installer.py", line 31, in <module>
    app.main()
  File "/home/ec2-user/aws-eda-slurm-cluster/source/slurm_installer/installer.py", line 114, in main
    self.config = self.get_config(args.config_file)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/slurm_installer/installer.py", line 453, in get_config
    validated_config = check_schema(config_parameters)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/config_schema.py", line 548, in check_schema
    config_schema = get_config_schema(config_in)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/config_schema.py", line 442, in get_config_schema
    Optional('SlurmRestApiVersion', default=get_slurm_rest_api_version(config)): str,
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/config_schema.py", line 146, in get_slurm_rest_api_version
    slurm_version = get_PC_SLURM_VERSION(config)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/config_schema.py", line 142, in get_PC_SLURM_VERSION
    parallel_cluster_version = get_parallel_cluster_version(config)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/config_schema.py", line 127, in get_parallel_cluster_version
    return config['slurm']['ParallelClusterConfig']['Version']
KeyError: 'Version'

You can try checking out the bug fix branch:
git fetch
git checkout 193-docs-baseline-setup-instructions-from-a-clean-ami

Thanks! This one got a little further. I went with ./installer.sh --prompt to fill out the missing fields, but still ran into this issue.
INFO: ErrorSnsTopicArn     set from command line: None
INFO: slurm/SubmitterSecurityGroupIds in config file overridden on command line from {} to {'default hpc grid': 'sg-01f6a0a2b8dc0c8fc'}
INFO: slurm/ClusterName defaulted to slurmminimal
ERROR: Invalid config
Traceback (most recent call last):
  File "/home/ec2-user/aws-eda-slurm-cluster/source/.venv/lib64/python3.7/site-packages/schema.py", line 405, in validate
    nvalue = Schema(svalue, error=e, ignore_extra_keys=i).validate(value, **kwargs)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/.venv/lib64/python3.7/site-packages/schema.py", line 440, in validate
    raise SchemaUnexpectedTypeError(message, e.format(data) if e else None)
schema.SchemaUnexpectedTypeError: None should be instance of 'str'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/cdk_slurm_stack.py", line 457, in check_config
    validated_config = check_schema(self.config)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/cdk/config_schema.py", line 551, in check_schema
    validated_config = config_schema.validate(config_in)
  File "/home/ec2-user/aws-eda-slurm-cluster/source/.venv/lib64/python3.7/site-packages/schema.py", line 409, in validate
    raise SchemaError([message] + x.autos, [e.format(data) if e else None] + x.errors)
schema.SchemaError: Key 'ErrorSnsTopicArn' error:
None should be instance of 'str'

Try git pull -r and try again. This should be fixed if you don't have an SNS topic.


add https alias

add https alias for http
in addition to PR #723

Thanks!
Also you can push to pull request branch and Github updates it.


RE7 - only half refresh rate

Hello !
Just a question,  is there any reason why game menu works on 90Hz , but as soon as game is loaded and starts , it goes to half refresh rate , 45FPS
Same thing is when I change to 80Hz , it plays with 40FPS.
Thank you for all your work , hope to get answer for this problem.

Sounds like vsync is on or ASW is engaging because you aren't hitting the native refresh rate of the HMD.    If you're on the Rift S try downloading oculus tray tool and disable ASW.

well , I have Oculus Quest , in OTT asw is disabled , in Half life Alyx everything is fine , 90 fps , this only happenes in RE 7 and my driving games Dirt Rally 2 , Project cars 2
Tried many things from net , nothing helps yet.


Ensure CUDA support

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Ensured CUDA support to match OpenMM.
@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Pipeline runs successfully but does not publish results (pipeline) or create a test run in Azure Load Testing

Describe the bug
The test results are not published in the CI/CD pipeline. Secondly a test run is also not generated in Azure Load Testing
To Reproduce
Steps to reproduce the behavior:

Run the pipeline
Step execute successfully and runs the load test
Test reults arent published to the CI/CD Pipeline
Test Run is not generated in the Azure Load Testing (Azure Portal)

Alternatively

Go to Azure portal and open the Azure Load Testing service
Create a Test plan and upload the Jmeter file
run the Test
No test run is generated in the test plan

Expected behavior
I should atleast see a test run generate in the Azure Portal
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]Windows 10
Browser [chrome]
Version [e.g. 22]

Previous Successful Run

Current Failed result

AB#1567518

I had this issue yesterday as well.
Also tried a new test and it got stuck while provisioning and failed after about 10 minutes. At some point I got it to run successfully but when trying a new run it succeeded but did not actually run in the portal.
Also existing tests that used to run successfully, failed or succeeded in the pipeline but did not actually run.

The pipeline is generating results for the test run. What was the issue as I havent changed anything for it to work

@johnAgilisys @LisaKemeling thanks for reaching out. There were some issues with provisioning in the service during this time. That could be the reason for failure. Can you share the test id so that we can investigate this further? This can be found in the browser URL when you navigate to the test.

@ninallam -The issue is resolved now and is working as expected.. As you can see in the screenshot it did not provision anything and no test run was created in Azure Load testing

The issue @johnAgilisys mentions seems to be something else indeed, I had that also yesterday. I just ran one of the tests again and now it works fine.

@radhikajain99 can you please check why does the pipelines task report success even when the test run is not created?

@ninallam We were not failing the pipeline task in case of validation timeout. The fix for this has been deployed


Kebab menu (Ellipsis menu) cant be used inside  modus-accordion,

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the Modus style guidelines

Proposal
When trying to view a kebab menu within an accordion it is not possible to display the menu option items,
The menu items  must be independently positioned  so that you can see the options outside the accordion and not inside where it loses visibility.
This functionality can be achieved with styles changes for  some modus-accordion  Shadow DOM elements.
Here’s a link with a brief example (this example is not complete at all because there’s some elements that are placed inside a shadow-dom, if we set UL tag for modus-list-item with position:unset, we can see the Kebab menu list item (ellipsis menu items).
https://codepen.io/Roliver-Rodriguez-EXT/pen/NWeWxBj

Motivation and context
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
Medium
What product/project are you using Modus Components for ?
Navigators
What is your team/division name ?
Navigators
Are you willing to contribute ?
None
Are you using Modus Web Components in production ?
No response

@rjavier-trimbler Thank you for submitting the issue. Could you kindly inform us if your team is interested in resolving the issue?

We should wait for Accordions Tigers team to confirm/update whether to show a dropdown/button inside accordion.

Closing the issue as the PR  #1683 fixes it indirectly and informed @egunther39 @soniakaukonen


deployment: add gh-pages

Description
add github pages

@helder-moreira do you have any pointers for getting this to work? It keeps erroring when i reload the page

@marbar3778 do you mean reloads except on root?

Looks like Github pages does not support SPA 😕 . Try looking at the workaround here

Trying out your suggestion, but i cant build the front end anymore because scss does not support scss

@marbar3778 why do you need arm64?

@marbar3778 why do you need arm64?

My computer is arm based, new M1.

My computer is arm based, new M1.

Oh I see. Try checking if docker or multipass are already supported 🙂


Some questions about going to global state

In alexa I used to do this:
this.handler.state = '';
In Jovo for now I am doing: this.toStatelessIntent('null');, and created a 'null' intent.
Is there a better way? Also how would I do a tell and go back to global?
this.followUpState('').tell('blah blah');

You can do this.removeState() or this.followUpState(null)

Just added it to the docs as well: https://github.com/jovotech/jovo-framework-nodejs/tree/master/docs/04_app-logic/01_routing#remove-a-state
Please reopen if this doesn't solve your problem.


Can't run pts_view file

I have used this command   ->   ./pts_view ./bunny/*.pts
But its showing error - >   bash: ./pts_view: cannot execute binary file: Exec format error

I have used this command -> ./pts_view ./bunny/*.pts
But its showing error - > bash: ./pts_view: cannot execute binary file: Exec format error

Did you solve this problem？

same problem

Maybe because the pts_view program was not compiled by local user.

I would recommend MeshLab to open .pts files though. I have already tried by myself.
Microsoft 3D Viewer does not have a library to handle the .pts file for sure.


Added "proxies" argument to _HTTPConnection.init() to allow proxy support

Codecov Report

Merging #36 into master will decrease coverage by 0.13%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   94.56%   94.43%   -0.14%
==========================================
  Files           3        3
  Lines         681      683       +2
==========================================
+ Hits          644      645       +1
- Misses         37       38       +1

Impacted Files
Coverage Δ

taxii2client/__init__.py
89.41% <66.66%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573ec9a...055f95f. Read the comment docs.

@mikekhusid , before I merge this, can you sign the OASIS TC Open Repository CLA? If this is a problem, let me know and we can figure something else out.

@gtback Signed the agreement, it's pending approval.  Thanks for reviewing the pull request quickly!

Re: before I merge this...  the CLA was filed, all clear
https://www.oasis-open.org/resources/open-repositories/cla/view-individual
Contributor Name: Mikhail Khusid
Contributor Email<EMAIL_ADDRESS>Github Username: mikekhusid

Thanks @robincover and @mikekhusid !


WIP - Attempt at using more structured errors

To repro, after checking out diesel and applying this PR:

Run $ docker-compose up
Run $ cargo test --features "postgres". This starts the tests, including a test that just hangs out sleeping (I don't want to submit this test, but it's easy for repro-ing).
Run $ docker network disconnect diesel_default diesel.postgres. This causes the sleeping test to fail, and shows what the result of a network disconnect through Diesel.

After doing this, I see the following output:
test pg::connection::tests::wait_a_looooong_time ... FAILED

failures:

---- pg::connection::tests::wait_a_looooong_time stdout ----
Unknown error code: None
thread 'pg::connection::tests::wait_a_looooong_time' panicked at 'called `Result::unwrap()` on an `Err` value: DatabaseError(ClosedConnection, "server closed the connection unexpectedly\n\tThis probably means the server terminated abnormally\n\tbefore or while processing the request.\n")', diesel/src/pg/connection/mod.rs:353:10

Indicating:

The actual error code is none
We only see a ClosedConnection error because of the equality check on the "server closed the connection..." message.

This is not yet ready for review - I'm trying to use structured errors, but noticing that PG_DIAG_SQLSTATE sometimes returns None here.
This is odd - it's documented as always present in the postgres docs!

A quick search brought up this which sounds like it may be possible that there is just no SqlState associated with certain errors.

A quick search brought up this which sounds like it may be possible that there is just no SqlState associated with certain errors. That would mean that the documentation is wrong

Oof, that's a bummer. I updated the codebase to at least make this more obvious to the next person coming along, and handled some of the connection errors explicitly regardless, if Diesel gets the chance to encounter them.


Charts, diagrams, graphs

Is it possible to add graph components to the library, or is there already some work being done on this?
Example of different types: https://demos.wrappixel.com/premium-admin-templates/react/flexy-react/stylish/#/charts/line-chart

I really liked the charts from tailwind elements. Thank you very much @mhaidarhanif :+1:
Closing this issue.

You're welcome @paraparadox 👍


Incompatibility with grape_juice's isometric module

module is at:  https://foundryvtt.com/packages/grape_juice-isometrics

i think you need to use interaction manager  ( mapPositionToPoint)

https://github.com/shemetz/ZoomPanOptions/blob/99ba5b2fd24bd7d70642c699c7827d6dd0b8981f/scripts/zoom-pan-options.js#L160

Fixed in v1.9.0


Mitaka

@ssorenso
What issues does this address?
What's this change do?
Merging up liberty into mitaka
Where should the reviewer start?
Any background context?

retest this please


Hardlock (not responding) when trying to use App Grabber

Describe the bug
When I try to use App Grabber (Programs -> App Grabber), a dialog "Please wait while Cairo adding programs", but then it just stops responding, tho I have load up on CPU.
Steps to reproduce

Go to "Programs"
Click on "App Grabber" on the right
PROFIT (joke)

Expected behavior
After waiting for a while, the programs should have appeared in "Programs" menu.
System information:

Microsoft Windows 10 Pro 21H1 (pirated)
Cairo version: <IP_ADDRESS>321 - Pre-release
64-bit
In Cairo Settings > Advanced, is Cairo set as shell?: Nope, because I am using UWP apps.

Additional context
After a bug, computer starts lagging. UWP apps may stop working. Log out and back in fixes this.
As I said, CPU overloads while bug happens. Tho I have pretty clogged drive.
Screenshots
Sadly no.

this is happening to me too

I also have same problem.
Win11 Pro 64bit 26252.5000 JP
16GB RAM, 1TB SSD
Shell is still Explorer.


Issue 183: Propagate subselect errors properly.

This addresses https://github.com/doug-martin/goqu/issues/183 by propagating subselect errors into newly returned SelectDataset so caller doesn't have to explicitly check for errors in subselects. Let me know what you think @doug-martin.

So I still think there's an issue here that needs work. Specifically, if you use Where using a subselect, we have the exact same problem. Because Where simply copies the where clauses without looking at any errors that might be in the contained subselects. Thoughts @doug-martin ?

Here's an example of what is still not covered by this PR:
func TestSelectWithSubSelectError2(t *testing.T) {

    ds := goqu.From("test").As("t").SetError(fmt.Errorf("An error"))
    assert.NotNil(t, ds.Error())

    ds2 := goqu.Select(Star()).From("table").Where(Ex{"s.id": Select(Star()).From(ds)})
    assert.NotNil(t, ds2.Error())
}

In this case I don't get an error b/c the Where handling doesn't propagate errors. So It expands it to an empty string, yielding a super unhelpful error message from Postgres such as:
pq: SELECT * with no tables specified is not valid"

@marshallmcmullen thanks for the PR. Ill get this in the next release and look into the other error cases.

@marshallmcmullen I think we can get around this error by having AppendSQL method set the error on the builder, that way when you build the SQL if any nested Dataset will return the first error encountered.
Will that address your use case? Ill open a PR showing what I am thinking.

@marshallmcmullen I think we can get around this error by having AppendSQL method set the error on the builder, that way when you build the SQL if any nested Dataset will return the first error encountered.
Will that address your use case? Ill open a PR showing what I am thinking.

@doug-martin that sounds perfect to me. I didn't realize we could just use AppendSQL to solve this. I think that sounds like a perfect solution.


community[minor]: Add support for Azure AI Search vector store

This PR adds Azure AI Search vectore store integration.
This is a follow-up of https://github.com/langchain-ai/langchainjs/pull/2396 that has been stuck for months. I forked the original PR to keep the prior contribution history, I hope it's ok that way.
Many changes happened since the original PR, as Azure Cognitive Search was renamed Azure AI Search,the SDK was updated with breaking changes, and LangChainJS structure has also changed.
I updated all of these, and went a bit further to align with the existing Azure Cosmos DB integration documentation, examples and tests.

Note: this is a first version to unblock the usage of this service, but I plan to push it a bit further in another PR with options to customize the index schema and fit existing indexes.

Fixes #2349
Twitter: @sinedied

Thanks for the feedbacks! I'm leaving some of the comment open here for reference, as I'd like to tackle these in a separate PR (optional embeddings, improved schema and maybe think of the 100k limit).
It seems there's a still build issue coming from the main branch, but otherwise the PR is ready for the next step.

Thanks @jacoblee93 for your review and comments, I'll update the PR in the coming days and rebase it from main to fix the conflict

@jacoblee93 I've process all comments an rebased the branch

Looks good - unfortunate about metadata filtering but I think better to get it in at this point.

Thank you!


Describe local installation of PDD to Windows/MacOS

Current installation manual covers only debian-based linux distributives (apt-get install).
It will be nice to have Windows + MacOS installation manual.

@yegor256 please do something about this issue

@alexey-krylov take a look: 1137402 works?

@alexey-krylov I'm not sure this will work on RedHat... can you please confirm?

@alexey-krylov I believe it's easy now, we don't have any specific dependencies anymore.


Allow passing a CA key password when signing a cert

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

REFERENCE.md is outdated

Please update REFERENCE.md with
$ bundle exec rake strings:generate:reference

Add it to the PR and CI should continue.
Otherwise looks good

Hey @ehelms , thanks for the PR! I rebased and merged it in https://github.com/voxpupuli/puppet-openssl/pull/214


Godot4.4-dev5: Breaks my mock implementation, get_method_list provides invalid method info for get_primary_rotation_axis

Tested versions
v4.4.dev5.mono.official [9e6098432]
System information
All
Issue description
I'm providing a mocking util for testing in my plugin GdUnit4 and the test are broken now.
My tests try to mock all Godot classes, and it fails now on LookAtModifier3D#get_primary_rotation_axis
The method is documented as

But the Vector3 has no enum Axis defined.
Steps to reproduce
Run the script to check the provided method info.
extends Node

func _ready() -> void:
	get_method_info()
	get_tree().quit()

func get_method_info() -> void:
	var modifier := LookAtModifier3D.new()

	var axis := modifier.get_primary_rotation_axis()
	prints("get_primary_rotation_axis value:", axis, "return type:", typeof(axis))

	var methods := modifier.get_method_list()
	var mi_get_primary_rotation_axis := methods.filter(func(m :Dictionary) -> bool:
		return m["name"] == "get_primary_rotation_axis"
	)
	prints(mi_get_primary_rotation_axis[0]["return"])

The output is:
get_primary_rotation_axis value: 1 return type: 2
{ "name": "", "class_name": &"Vector3.Axis", "type": 2, "hint": 0, "hint_string": "", "usage": 65542 }

I use the provided method info to build the mocking class, and it will not be compiling about missing enum Vector3.Axis
e.g. use a valid script code will show the compile error
var axis_typed :Vector3.Axis = modifier.get_primary_rotation_axis()
Parse Error: Built-in types don't contain nested types.
Same issues for all classes inherits from SpriteBase3D
Minimal reproduction project (MRP)
n/a

Related to #98446 which added the method, though it's not the first use of Vector3.Axis in the API, so I'm surprised it's only a problem now for your use case.
#99424 sounds related and might solve this? CC @dalexeev

e.g. use a valid script code will show the compile error var axis_typed :Vector3.Axis = modifier.get_primary_rotation_axis()
Parse Error: Built-in types don't contain nested types.

#99424 sounds related and might solve this?

Yes, it should fix this, see the test analyzer/features/global_builtin_and_native_enums.gd in the PR.

@akien-mga it is an older issue right, I checked my mock tests and see I had explicit excluded "Sprite3D", "AnimatedSprite3D" in the past, but I can't remember which version of Godot

@akien-mga it is an older issue right, I checked my mock tests and see I had explicit excluded "Sprite3D", "AnimatedSprite3D" in the past, but I can't remember which version of Godot

I'm fairly confident it exists at least in 4.3 stable (and perhaps earlier), since this PR originated as an attempt to fix #99309 (which turned out to be a minor symptom of the same core problem)


Doc correction

In Step 1 it is stated "If you have already deployed the Clause sample on IBM Blockchain Platform via the toolchain, you can skip to step 3."
However, I have to do step 2 to create an account in Clause.

You also need step 2 to know what is being referred to as the demonstration application in step 4.

Also fixed in the guide. Thanks again @markparz


Add multilanguage support

I know, that is not our prior task, but it would be really cool if we implement multilanguage support, so this script will be more valuable for international open-source community.

It has been decided to to provide a multi-language support.


possible issue with <IP_ADDRESS> msysgit

tried installing msysgit <IP_ADDRESS> and git stopped working. not sure if this is a posh-git thing or a git thing. but should probably be looked at.

when i use git log under powershell ,it show me unicode character ,not the chinese commit message.
but the git log work well in mysisgit bash after i modified the mysisgit profile :
[gui]
encoding = utf-8
[i18n]
commitencoding = utf-8
logoutputencoding = gbk
how to fix the problem ? thanks

You should try utf-16 output encoding. AFAIK, PowerShell uses it by default.

I somehow missed notifications that there were other comments here... Anyone still having issues?


Fixed a typo in the 'deploy' documentation

Fixed a minor typo in the deploy documentation.

@marconetto please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"


when use STRATEGY_FILL_VIEW, gravity center invalid

itemView gravity center invalid, it seems cause by layout view without measure

Yes, I can confirm that. Items are left aligned in their container that will be stretched on STRATEGY_FILL_VIEW. A possible bypass could be to fill the contents to the container, but even setting fill_parent on the layout_width will be ignored.

Yes, I can confirm that. Items are left aligned in their container that will be stretched on STRATEGY_FILL_VIEW. A possible bypass could be to fill the contents to the container, but even setting fill_parent on the layout_width will be ignored. Last commit 4 years ago, dead.

flexbox instead

@ColorfulHorse Flexbox was not right for me, I used the GridLayoutManager, instead.


CI: Update matrix

Updates the CI matrix to latest versions.
Also:

Removes an old setting from Travis. See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

Why are we doing this?
Reflect latest changes in Ruby.
Benefits
We will know about any warnings and changes in released versions of Ruby.
Drawbacks
None.

Coverage decreased (-0.06%) to 97.732% when pulling eee9947ff76cc74b78d0aeb3a792b583a4d2dfb7 on olleolleolle:patch-1 into 1e9c669cbb956c8288a1f31ce8ad3475545a5d2c on piotrmurach:master.

Coverage decreased (-0.06%) to 97.732% when pulling eee9947ff76cc74b78d0aeb3a792b583a4d2dfb7 on olleolleolle:patch-1 into 1e9c669cbb956c8288a1f31ce8ad3475545a5d2c on piotrmurach:master.

Coverage decreased (-0.06%) to 97.732% when pulling eee9947ff76cc74b78d0aeb3a792b583a4d2dfb7 on olleolleolle:patch-1 into 1e9c669cbb956c8288a1f31ce8ad3475545a5d2c on piotrmurach:master.

Coverage decreased (-0.06%) to 97.732% when pulling eee9947ff76cc74b78d0aeb3a792b583a4d2dfb7 on olleolleolle:patch-1 into 1e9c669cbb956c8288a1f31ce8ad3475545a5d2c on piotrmurach:master.


"edit this page" link in documentation is broken

🐛 Bug Report
The "edit this page" link leads to the deprecated "master" branch instead of "main"

Before reporting an issue please remember:

One issue, one bug: Please report a single bug per issue.

(Write your answer here.)
To Reproduce

go here: https://opctl.io/docs/reference/opspec/op-directory/op/parameter/array
click "edit this page"
get a 404

Expected behavior

I thought it would open a github editor for the markdown file backing the page in question.
Actual Behavior

it took me to github's 404 page

this pr ought to fix this: https://github.com/opctl/opctl/pull/929