ONE incorrectly handles "failed" live migration

Description
A VM live migration succeeds but ONE receives an exit code of "1" by migrate script and assumes the migration has not succeeded. While in practice the VM has been live migrated successfully (only the SYNC_TIME part failed).
To Reproduce
Unsure what conditions lead up to this bug. We only have this behavior on one cluster. The error message is:
Jun 26 10:43:38 oned3 oned[481791]: [VM 0][Z0][VMM][I]: Failed to execute virtualization driver operation: migrate.
Jun 26 10:43:38 oned3 oned[481791]: [Z0][VMM][D]: Message received: MIGRATE FAILURE 0 virsh --connect qemu:///system migrate --live  DOMAIN-ID qemu+ssh://some_host/system (9.769216494s) Error mirgating VM DOMAIN-ID to host some_host: undefined method `upcase' for nil:NilClass ["/var/tmp/one/vmm/kvm/migrate:234:in `<main>'"] ExitCode: 1
Jun 26 10:43:38 oned3 oned[481791]: [VM 0][Z0][VMM][E]: MIGRATE: virsh --connect qemu:///system migrate --live  DOMAIN-ID qemu+ssh://some_host/system (9.769216494s) Error mirgating VM DOMAIN-ID to host some_host: undefined method `upcase' for nil:NilClass ["/var/tmp/one/vmm/kvm/migrate:234:in `<main>'"] ExitCode: 1

The piece of code that fails:
/var/lib/one/remotes/vmm/kvm/migrate
    # Sync guest time
    if ENV['SYNC_TIME'].upcase == 'YES'
        cmds =<<~EOS
            (
              for I in $(seq 4 -1 1); do
                if #{virsh} --readonly dominfo #{@deploy_id}; then
                  #{virsh} domtime --sync #{@deploy_id} && exit
                  [ "\$I" -gt 1 ] && sleep 5
                else
                  exit
                fi
              done
            ) &>/dev/null &
        EOS

Turns out that the virsh command does not result in a list with domains, is therefore empty, and the error is not handled properly. So ideally above piece of code gets fixed so it checks if the hash is not empty. If it is empty then a clear error message should be returned: unable to obtain $domain with virsh command here.
And ideally ONE should not assume that the VM is still running as it is currently doing: Jun 27 15:55:18 oned1 oned[1434842]: [VM 0][Z0][LCM][I]: Fail to live migrate VM. Assuming that the VM is still RUNNING. It will detect the VM is in poweroff state and the hypervisor the VM is running on detects a zombie. Ideally this is handled better: do some extra checks to see where the VM is running.
I can reproduce the behavior of virsh not listing domains by executing the ssh command without LIBVIRT_URI exported. This sounds like it could be related to this bug:  LIBVIRT_URI
Strange enough I do not hit this issue when I explicitly export export SYNC_TIME=yes. It does not matter what value SYNC_TIME is set to. Either no, yes, or even broken will then_ not_ trigger this issue. So maybe somehow, if this is indeed the issue, kvmrc  ENV vars are read when SYNC_TIME is exported (and otherwise not?).
Expected behavior
I expect ONE to handle the error gracefully instead of hitting an assert in the code. And to have ONE double check where a live migrated VM ended up living if a non zero exit code gets returned (instead of assuming the VM keeps on running on the source hypervisor).
Details

Hypervisor: KVM
Version: 6.8.3

Additional context
There seems to be a specific pre-condition that has to be true to hit this bug as we see it only happen on one specific (dedicated) cloud but as of now it is unclear what this is. I can reproduce this issue so if further debug information has to be gathered, please let me know.
Ubuntu 22.04 ONE / hypervisors

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

So for the updating state, the monitor process will update the VM state if it is not running to poweroff (libvirt should keep it running). In the same way if the migration fails, the VM will be running in the source host.

So for the updating state, the monitor process will update the VM state if it is not running to poweroff (libvirt should keep it running). In the same way if the migration fails, the VM will be running in the source host.

Yes, I understand how this is currently handled. And on the destination host a "zombie" VM will be detected. This still leaves a time window for error (as long as storage fencing is not implemented). I think this behavior could be improved. To check for failure scenarios like this. One of the things ONE could do is perform a bit of extra checking on the destination host and double check if the VM is not there. And raise an error instead (with a helpful message).  In this particular case it would not have helped, as it wasn't able to detect any domains running.
For my understanding: this issue has been closed. Was this already fixed in another PR for the 6.10 release? To be clear: the main issues here are: 1) Hitting the live-migration issue (ONE unable to detect running domains), 2) graceful handling of this error by the code (in case no domains are detected).

yes it is fixed in 6.10, but actually it solves the migration with SYNC_TIME part.
So maybe we can keep this open, for future improvements as we did not address any change to current behavior


The json file is not accessible in HEIM

https://crfm.stanford.edu/heim/latest/benchmark_output/runs/v1.1.0/groups/json/mscoco_base_mscoco_base_.json

cc @teetone

This seems to be fixed. The file is located at https://nlp.stanford.edu/helm/v1.1.0/benchmark_output/runs/latest/groups/mscoco_base.json


TypeGuard from PEP 647 not working?

It seems the TypeGuard on callable isn't working.
Environment data
Ubuntu 20.04
VSCode 1.73.1
Python 3.10.8
Pylance v2022.11.20
Code Snippet

super_func = getattr(super_class, function_name)
assert callable(super_func)       # mouseover callable says it returns TypeGuard[(...) -> object]
super_code = super_func.__code__  # mouseover all these symbols gives "Any"
super_func = cast(Callable[..., Any], super_func)
super_code = super_func.__code__  # mouseover all these symbols gives what I want

Expected behavior
Shouldn't assert callable(super_func) narrow the type like super_func = cast(Callable[..., Any], super_func)?
Actual behavior
(in code snippet comments)

Could you provide a complete, self-contained code sample? The sample above refers to symbols like super_class and function_name that are not defined, so we won't be able to repro the problem you're seeing.
I suspect what is happening is that super_func is type Any. In general, Any is never narrowed. There are a few specific exceptions to this rule that the major Python type checkers have all agreed to — namely, isinstance, issubclass, and match/case type narrowing patterns. For all other type guards, an Any remains an Any. Does that explain the behavior you're seeing?

As requested previously, please provide complete, self-contained code samples. I can only guess at what you mean when you use symbols that are not declared (like super_func).

It was complete and self-contained before your last message.

User-defined type guards (as spec'ed in PEP 647) are also exempt from the "Any is never narrowed" rule. That explains why isfunction acts as is does.
Pyright (the type checker upon which pylance is built) has built-in type type guard logic for callable that predates the introduction of TypeGuard. It is more sophisticated than what can be provided for user-defined type guards. It supports both positive ("if") and negative ("else") narrowing, and it supports intersection types. Its behavior is therefore different from the user-defined type guard behavior seen for isfunction. It is not exempt from the "Any is never narrowed" rule.
This explains the difference you're seeing between callable and isfunction. This behavior is expected, and we don't currently have any plans to change it. Doing so will introduce false positive errors in code that currently type checks without errors. You'll need to adjust your code accordingly.

Doing so will introduce false positive errors in code that currently type checks without errors.

Can you give an example of this?

from typing import Callable

def func(x: Callable[[int], int] | int, param: int = 0) -> int:
    if not callable(x):
        return x

    return x(param)

This will fail because x won't be narrowed to Callable[[int], int] in the negative case if we were to apply TypeGuard narrowing.

Here's another example that uses an intersection type:
def func2(x: A) -> A | None:
    if callable(x):
        x()
        return x

We have test cases in pyright for these cases because existing code relies on these behaviors.

I see.
We have a false positive from this:
from typing import Callable, TypeGuard

def my_callable(o: Callable[[int], int] | int) -> TypeGuard[Callable[[int], int]]:
    return callable(o)

def func(x: Callable[[int], int] | int, param: int = 0) -> int:
    if not my_callable(x):
        return x

    return x(param)

I believe this is expected. See Eric's comment:

This will fail because x won't be narrowed to Callable[[int], int] in the negative case if we were to apply TypeGuard narrowing.

I believe this discussion: https://github.com/python/typing/discussions/1013 outlines what would be necessary to support the negative case.


Electric Grid Consumption

Hi,
I discovered that my Bosch cw 100 controller also stores the electric grid consumption. It would be great to have that as an energy device, so that it can be tracked as a device in the energy board. It is the eltric energy, that is used e.g. for the pump.
I added the raw search and a screenshot of the controller screen. In the screen you can see total consumption and the share for heating or hot water.
Thanks a lot for this great integration!
Best
Sven
Archiv.zip

Hi, just wanted to ask if you already had a chance to look at the issue? Best Sven

Hi, did you try to enable new api and recording sensors: actualCHPower, actualDHWPower?

Hi, I see figures for both sensors but do you have a description what they record?
Best Sven

central heating power and domestic hot water power.

I think we might misunderstand each other. I am searching for a sensor for the electric power. If the heater burns gas to make hot water there is gas consumption but also electric consumption for the circulation pump, Standby and so forth. I see the electric consumption on the heaters monitor and am now searching a corresponding sensor in home assistant.

I don't see any data in your scan which show electric power usage, so it might not be available in API.

Okay thank you for checking it! Best Sven


unrecognized 'FontAwsome5Pro-Regular'

Environment
OS: IOS
packages version
"dependencies": {
    "@react-native-picker/picker": "^2.2.1",
    "react": "17.0.2",
    "react-native": "0.67.2",
    "react-native-navigation": "^7.25.4",
    "react-native-picker-select": "^8.0.4",
    "react-native-vector-icons": "^9.1.0"
  }

Description
I've been trying to upgrade to FontAwsome5Pro, but I keep getting " unrecognized 'FontAwsome5Pro-Regular' "
I did the following:
1-upgraded to pro as the FontAwsome5Pro README suggest

2-executed "react-native link"
3-add Fonts group to Xcode

4-added font to "copy build phase/copy bundle resources"

5-added new fonts to info.plist

and still getting  "unrecognized 'FontAwsome5Pro-Regular' " error

I ran into the same issue today. Running fc-scan on the pro font files returned this:
postscriptname: "FontAwesome6Pro-Regular"(s)

... which looks suspicious. Any chance the upgrade script is pulling the latest version of FA (version 6) instead of 5? Replacing the ttf files with an older copy of "real" FontAwesome5 pro ttf files fixed the issue for me 👍

@Maddoc42 exactly I installed the font without the package and used it with the name as 'Font Awesome 6 Pro Solid' and it worked.
In the end, I switched to 'react-native-fontawesome'

Still no fix? I've encounter the same issue

i have the same issue'??? .

i just switched to https://github.com/FortAwesome/react-native-fontawesome

If anyone still has this issue,

npm uninstall react-native-vector-icons
Delete the Fonts folder from XCode project
Follow all the installation steps again (You may not need to update info.plist if you're using iOS)

Closing as OP has moved to a different library. Please open a new issue if you are having the same problem


wordpress: packages for plugins and themes

Motivation for this change
I packaged some Wordpress themes and plugins in the subset wordpressPlugins and wordpressThemes. These packages can be used in a Wordpress installation like this:
services.wordpress = {
  webserver = "caddy";
  sites."blog.${config.networking.domain}" = {
    plugins = with wordpressPlugins; [
      anti-spam-bee
      code-syntax-block
      lightbox-with-photoswipe
      wp-gdpr-compliance
    ];
    themes = [ wordpressThemes.geist ];
  };
};

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

#96910

#96910

Oh I wasn't aware of wp4nix. Is this something we could get merged into nixpkgs? Would be cool to have Wordpress packages in there too.

Result of nixpkgs-review pr 124383 at 1758c907 run on x86_64-linux 1

1 package failed to build:

wordpressPlugins.webp-converter-for-media

14 packages built successfully:

wordpressPlugins.anti-spam-bee
wordpressPlugins.async-javascript
wordpressPlugins.breeze
wordpressPlugins.co-authors-plus
wordpressPlugins.code-syntax-block
wordpressPlugins.disable-xml-rpc
wordpressPlugins.jetpack
wordpressPlugins.lightbox-with-photoswipe
wordpressPlugins.opengraph
wordpressPlugins.simple-login-captcha
wordpressPlugins.wp-gdpr-compliance
wordpressPlugins.wp-statistics
wordpressPlugins.wp-user-avatar
wordpressThemes.geist

29 suggestions:

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:127:5:
    |
127 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/servers/web-apps/wordpress/plugins.nix:25:14:
   |
25 |       inherit pluginName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:83:5:
   |
83 |     buildInputs = [ pkgs.unzip pkgs.php ];
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/web-apps/wordpress/themes.nix:27:7:
   |
27 |       installPhase = "mkdir -p $out; cp -R * $out/";
   |       ^

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/servers/web-apps/wordpress/plugins.nix:25:14:
   |
25 |       inherit pluginName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:105:5:
    |
105 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: unused-argument
Unused argument: path.
Near pkgs/servers/web-apps/wordpress/themes.nix:19:5:
   |
19 |     path ? lib.getName themeName,
   |     ^

warning: license-missing
Package is missing a license.
Near pkgs/servers/web-apps/wordpress/plugins.nix:25:14:
   |
25 |       inherit pluginName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:182:5:
    |
182 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:138:5:
    |
138 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: license-missing
Package is missing a license.
Near pkgs/servers/web-apps/wordpress/themes.nix:25:14:
   |
25 |       inherit themeName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:61:5:
   |
61 |     buildInputs = [ pkgs.unzip ];
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:94:5:
   |
94 |     buildInputs = [ pkgs.unzip ];
   |     ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/servers/web-apps/wordpress/themes.nix:25:14:
   |
25 |       inherit themeName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:171:5:
    |
171 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:149:5:
    |
149 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/servers/web-apps/wordpress/plugins.nix:25:14:
   |
25 |       inherit pluginName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: unused-argument
Unused argument: src.
Near pkgs/servers/web-apps/wordpress/themes.nix:12:5:
   |
12 |     src,
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:40:5:
   |
40 |     buildInputs = [ pkgs.unzip ];
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:160:5:
    |
160 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: unused-argument
Unused argument: src.
Near pkgs/servers/web-apps/wordpress/plugins.nix:12:5:
   |
12 |     src,
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/web-apps/wordpress/plugins.nix:27:7:
   |
27 |       installPhase = "mkdir -p $out; cp -R * $out/";
   |       ^

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/servers/web-apps/wordpress/themes.nix:25:14:
   |
25 |       inherit themeName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:72:5:
   |
72 |     buildInputs = [ pkgs.unzip ];
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:50:5:
   |
50 |     buildInputs = [ pkgs.unzip ];
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/plugins.nix:116:5:
    |
116 |     buildInputs = [ pkgs.unzip ];
    |     ^

warning: unused-argument
Unused argument: path.
Near pkgs/servers/web-apps/wordpress/plugins.nix:19:5:
   |
19 |     path ? lib.getName pluginName,
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/servers/web-apps/wordpress/themes.nix:40:5:
   |
40 |     buildInputs = [ pkgs.unzip ];
   |     ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/servers/web-apps/wordpress/themes.nix:25:14:
   |
25 |       inherit themeName unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

I changed the package attributes according to wp4nix:
nix-shell -p wordpressPackages.plugins.jetpack

and for themes:
nix-shell -p wordpressPackages.themes.geist

Most of the plugins and themes have version tags so that the zip download url is fixed to a specific version.
@ajs124 @mohe2015 The pull request mentioned above looks interesting. It addresses several issues and contains breaking changes, so it's a bigger thing and maybe not so easy to merge? In how far does it relate to packaging of plugins and themes?

Most of the plugins and themes have version tags so that the zip download url is fixed to a specific version.

People republish these versions by pushing to the same subversion tag regularly.

@onny

Most of the plugins and themes have version tags so that the zip download url is fixed to a specific version.

This was actually a problem we faced because the plugins can update their contents without updating the version. This is one reason ajs124 wrote the script that downloads them from svn.

ajs124 mohe2015 The pull request mentioned above looks interesting. It addresses several issues and contains breaking changes, so it's a bigger thing and maybe not so easy to merge?

I'm currently waiting for https://github.com/NixOS/nixpkgs/pull/84446 to get merged and would probably try again to get it merged then.
The first three commits are easy improvements and should be fairly easy to get merged.
Changing the default database name makes it easier to create multiple wordpress services but is a breaking change (well stateVersion).
Changing the prefix of the apache service name is not required but may be benefical. Unfortunately this would break with the nginx PR so maybe I should think about it now.
Removing the version from the theme folder name is probably the most important change as otherwise wordpress is almost unusable if a theme doesn't store the settings in a way this doesn't break. But this is also a breaking change which is unfortunate.
Allowing a mutable wp-content directory is mostly convenience for testing new plugins and themes or using plugins that don't work with the non-writable approach but then you loose most benefits of the module anyways.
I also added some documentation for changing the hostname but this is also terribly supported by wordpress itself so it's only a documentation change but I would still avoid it if possible.
As ajs124 just said plugin and theme versions are not immutable. Also it's way easier to just use an automatic tool to package and update these.

In how far does it relate to packaging of plugins and themes?

The main change is the change of the directory names for plugins and themes. Other than that I would strongly recommend to use something like wp4nix (possibly with flakes) and not packaging manually at all.


Veracode vulnerability in dependent package shell-quote

Hello, We identified a vulnerability issue in<EMAIL_ADDRESS>so we need to use version >1.7.3

I want to fix this so let me know if I can contribute. thanks.


[FLINK-28922][docs-zh] Translate "ORDER BY clause" page into Chinese.

What is the purpose of the change

Translate "ORDER BY clause" page into Chinese:  https://nightlies.apache.org/flink/flink-docs-master/zh/docs/dev/table/sql/queries/orderby/.
The markdown file is located in "docs/content.zh/docs/dev/table/sql/queries/orderby.md".
Details See FLINK-28922 for information.

Brief change log

Translate "ORDER BY clause" page into Chinese.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@MartijnVisser , Sorry to bother you again, can you help me review this pr? Thank you.

@wuchong , Can you help me review this pr？Thank you very much.


Add UX tests for column / View

Test the Column / View dropdowns

Proposed solution
Add four tests,

collapse.spec.js
collapse_all.spec.js
collapse_left.spec.js
collapse_right.spec.js

The test should basically collapse one or more columns, and ensure that the columns labels are empty (or possibly just hidden).
Additional context
See also #3415, with some very similar tests about collapsing
When collapsing, column labels are not hidden, they are removed from the DOM.

I want to work on 3

I am interested to work on this, may I proceed with this.

Let's first ask @AhwiniMirajkar if they are still working on this.

Sure sir.

can I work on this issue??

@wetneb with all due respect I would like to ask that is there a mistake in assigning this issue because I asked permission to work on this issue.

@riteshsoni123 sorry, indeed!

@riteshsoni123 for inspiration, you might want to have a look at this tests : OpenRefine/main/tests/cypress/cypress/integration/project/grid/all-column/view.spec.js
There's a similar feature on OpenRefine, when you click on the "all" column, where you can collapse/expand, and definitively a good idea to cover this behavior at the column level.
Thx !

Thanks @fgiroud for the suggestion, it was really helpful.


resetNetworkFork() failing in hardhat test

Hello, when I include await resetNetworkFork() at the top of one of my tests, I get
InvalidArgumentsError: Errors encountered in param 0: Invalid value undefined supplied to : HardhatNetworkConfig | undefined/forking: RpcForkConfig | undefined | undefined/jsonRpcUrl: string
Here is the top of one of my tests:
        console.log("resetting local net")
        await resetNetworkFork();
        console.log("reset complete");

Here's what I get
      resetting local net
      resetNetworkFork to latest

But no reset complete message
using hardhat v 2.6.3.  Here is my hardhat config if that's helpful:
import '@typechain/hardhat'
import "@nomiclabs/hardhat-ethers";
import "@nomiclabs/hardhat-waffle";
import "@nomiclabs/hardhat-solhint";
import "hardhat-gas-reporter";
import "solidity-coverage";
import "hardhat-contract-sizer";
import "hardhat-tracer";

// This is a sample Hardhat task. To learn how to create your own go to
// https://hardhat.org/guides/create-task.html
task("accounts", "Prints the list of accounts", async (taskArgs, hre) => {
  const accounts = await hre.ethers.getSigners();

  for (const account of accounts) {
    console.log(account.address);
  }
});

// You need to export an object to set up your config
// Go to https://hardhat.org/config/ to learn more

/**
 * @type import('hardhat/config').HardhatUserConfig
 */
module.exports = {
  solidity: {
    version: "0.8.4",
    settings: {
      optimizer: {
        enabled: true,
        runs: 1
      }
    }
  },
  networks: {
    hardhat: {
      initialBaseFeePerGas: 0, // workaround from https://github.com/sc-forks/solidity-coverage/issues/652#issuecomment-896330136 . Remove when that issue is closed.
    },
    ropsten: {
      url: process.env.ROPSTEN_URL || "",
      accounts:
        process.env.PRIVATE_KEY !== undefined ? [process.env.PRIVATE_KEY] : [],
    },
  },
  gasReporter: {
   /* enabled: process.env.REPORT_GAS !== undefined,*/
    enabled: false,
    currency: "USD",
    coinmarketcap: "53712f5c-19c3-4b47-aa65-5794a2868056"
  },
  etherscan: {
    apiKey: process.env.ETHERSCAN_API_KEY,
  },
};```

You might be calling this too early, before Hardhat+web3 instances are ready.
When used in tests, you probably want to call it in beforeEach(async() => await resetNetworkFork());
closing as cant reproduce, reopen if needed


Changes needed by cedar-policy/cedar#1114

Issue #, if available:
Description of changes:

Are there changes we should make to the Java API?

Good catch. Yes. I'll update them as well.


Use src directory structure for project

Requires #15
Move to using a src directory structure for the project and then add a MANIFEST.in

@lukasheinrich this is ready for review.

you're on a roll :rocket:

you're on a roll

:) Though I think I'll stop here for a while, as the next thing to do is add unit tests and identify files that make sense to use on them. We can follow up next week — have a good flight home!


Segmentation fault when running vivit experiment

Hi,
Thanks for sharing the code. I am trying to reproduce the vivit paper results for kinetics-400.
But I got segmentation fault when trying to run main.py. I am using 8 x 3090 with cuda 11.2
The jax version is 0.2.24, jaxlib version is 0.1.69, and tensorflow version is 2.7.0.
I've never used jax before, so it is not clear to me what causes this issue. Could anyone help here? The following is the exception traceback.
Thanks!
root@01b7ceb4a818:/workspace# python3 scenic/projects/vivit/main.py --config=scenic/projects/vivit/configs/kinetics400/vivit_base_k400.py --workdir=vivit_base_k400/
I1109 01:22:51.434930<PHONE_NUMBER>21312 xla_bridge.py:232] Unable to initialize backend 'tpu_driver': Not found: Unable to find driver in registry given worker:
I1109 01:22:52.361684<PHONE_NUMBER>21312 xla_bridge.py:232] Unable to initialize backend 'tpu': Invalid argument: TpuPlatform is not available.
I1109 01:22:52.361946<PHONE_NUMBER>21312 app.py:80] JAX host: 0 / 1
I1109 01:22:52.362037<PHONE_NUMBER>21312 app.py:81] JAX devices: [GpuDevice(id=0, process_index=0), GpuDevice(id=1, process_index=0), GpuDevice(id=2, process_index=0), GpuDevice(id=3, process_index=0), GpuDevice(id=4, process_index=0), GpuDevice(id=5, process_index=0), GpuDevice(id=6, process_index=0), GpuDevice(id=7, process_index=0)]
I1109 01:22:52.362362<PHONE_NUMBER>21312 local.py:45] Setting task status: host_id: 0, host_count: 1
I1109 01:22:52.362540<PHONE_NUMBER>21312 local.py:51] Created artifact Workdir of type ArtifactType.DIRECTORY and value vivit_base_k400/.
I1109 01:22:52.853591<PHONE_NUMBER>21312 app.py:91] RNG: [0 0]
I1109 01:24:19.953434<PHONE_NUMBER>21312 train_utils.py:149] device_count: 8
I1109 01:24:19.954089<PHONE_NUMBER>21312 train_utils.py:150] num_hosts : 1
I1109 01:24:19.954144<PHONE_NUMBER>21312 train_utils.py:151] host_id : 0
Fatal Python error: Segmentation fault

Current thread 0x00007f33fa1330c0 (most recent call first):
  File "/opt/conda/lib/python3.7/site-packages/tensorflow/python/framework/load_library.py", line 58 in load_op_library
  File "/opt/conda/lib/python3.7/site-packages/tensorflow_text/python/metrics/text_similarity_metric_ops.py", line 28 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "/opt/conda/lib/python3.7/site-packages/tensorflow_text/python/metrics/__init__.py", line 20 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1035 in _handle_fromlist
  File "/opt/conda/lib/python3.7/site-packages/tensorflow_text/__init__.py", line 21 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "/opt/conda/lib/python3.7/site-packages/dmvr/tokenizers.py", line 21 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1035 in _handle_fromlist
  File "/opt/conda/lib/python3.7/site-packages/dmvr/processors.py", line 20 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1035 in _handle_fromlist
  File "/opt/conda/lib/python3.7/site-packages/dmvr/modalities.py", line 21 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1035 in _handle_fromlist
  File "/workspace/scenic/projects/vivit/data/video_tfrecord_dataset.py", line 9 in <module>
  File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 728 in exec_module
  File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 983 in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006 in _gcd_import
  File "/opt/conda/lib/python3.7/importlib/__init__.py", line 127 in import_module
  File "/workspace/scenic/dataset_lib/datasets.py", line 91 in get
  File "/workspace/scenic/dataset_lib/datasets.py", line 128 in get_dataset
  File "/workspace/scenic/train_lib/train_utils.py", line 153 in get_dataset
  File "scenic/projects/vivit/main.py", line 31 in main
  File "/workspace/scenic/app.py", line 96 in _run_main
  File "/opt/conda/lib/python3.7/site-packages/absl/app.py", line 251 in _run_main
  File "/opt/conda/lib/python3.7/site-packages/absl/app.py", line 303 in run
  File "/workspace/scenic/app.py", line 64 in run
  File "scenic/projects/vivit/main.py", line 44 in <module>
Segmentation fault (core dumped)

Hi @mlpen
This looks like an issue with tensorflow_text, which is a dependency of the DMVR library that we use for data pre-processing.
I think it is described in this open issue for tensorflow_text: https://github.com/tensorflow/text/issues/644

Thanks for replying. I've resolved the error.

Thank you @mlpen. Closing the issue. Feel free to reopen if there is any question.


[WIP] Fix 1012 - remove pointless code

This should be the fix for https://github.com/Microsoft/visualfsharp/issues/1012.  It needs to be tested manually.

This looks good. We know that ParseCanonicalName is slow,
so maybe this method could be optimized as part of this PR? https://github.com/dsyme/visualfsharp/blob/fix-1012/vsintegration/src/FSharp.ProjectSystem.FSharp/Project.fs#L1751
It should only call ParseCanonicalName is propid is one we care about.

@rojepp Thanks for taking a look!  That code is only #if DESIGNER which is old code which should be deleted

Ok then, then LGTM I suppose! :)

The open repo does not Set Design at all so.  Why not remove all of the code under #if Designer?


Move script types to primitives

First patch removes bytes_to_asm_fmt as requested by Kix here: https://github.com/rust-bitcoin/rust-bitcoin/pull/3194#discussion_r1756557768
Second patch does the move. The move is minimal but there is quite a bit of code moved in script/mod.rs - I believe it is as minimal as required as well.

5758abf58e29d8141482d783bceff0bf1f9c4d3a looks good other than the one comment.

Fixed the commit message but did not change the expect message.

I checked locally that the large sections of code that were moved were unchanged

Hey @jamillambert I recently learned of some new git configuration options that make reviewing codes moves like this easier. It makes patches be colorized so that one doesn't have to manually check that large sections of code are unchanged.
Add this to your ~/.gitconfig file

[diff]
	colorMoved = zebra
        colorMovedWs = allow-indentation-change

Face palm, its 4am here and I got out of bed thinking that I really should get this PR done, only to find I did it 4 days ago.
Review please @apoelstra.

Source commit: 4894aadd93b48349b511609311faea6acd81ab6e
Source: /nix/store/j2c1c8r4zfq46c673jw2cqjrf6ik34s3-source
unpacking source archive /nix/store/kr6vgwlly12xkxjp2ikj43vr928ga9z5-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running cd .
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Building src/lib.rs (bitcoin)
Running rustc --crate-name bitcoin src/lib.rs --out-dir target/lib -L dependency=target/deps --cap-lints allow -L native=/nix/store/np4jc4v8lq73r4laf1v92dddx6z2vvg2-rust_secp256k1-sys-0.10.0-lib/lib/secp256k1-sys.out -C debu>
error[E0599]: no method named `to_string` found for reference `&borrowed::Script` in the current scope
   --> src/blockdata/script/borrowed.rs:491:50
    |
491 |         fn to_asm_string(&self) -> String { self.to_string() }
    |                                                  ^^^^^^^^^ method not found in `&borrowed::Script`
    |
    = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
    |
3   | use crate::alloc::string::ToString;
    |

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.

Sorry. I probably ran this several days ago and forgot to dig into and repost the failure.

Bother, I fixed that the other day and put the fix in the wrong commit. Added import of ToString to the first commit.

Will also one-ack merge this since it has no comments from other maintainers and has been open for two weeks (and Kix appears to be offline anyway).


Rancher disconnected from rke cluster after (only) node reboot

Hi there! This is a question about an issue I encountered with my specific rke/Rancher setup.
So I started a single-host cluster using rke (mostly defaults, just increased max-pods, disabled ingress). Since the add-on installation of Rancher seems to be deprecated, I manually started a Rancher container on a separate host (default self-signed certificate), added the cluster and used the setup successfully for a couple of days. In-between I re-ran rke a couple of times to experiment with installing Longhorn, Træfik and Nvidia Device Plugin via the add-ons mechanism.
But only after a reboot of the (only) node for a kernel update, the cluster suddenly didn't want to talk to Rancher any more. The UI says:

Failed to communicate with API server: Get https://<IP_ADDRESS>:443/api/v1/componentstatuses?timeout=30s: waiting for cluster agent to connect

It might be a certificate issue since the Rancher API is definitely reachable via curl:
$ kubectl logs -f -n cattle-system cattle-cluster-agent-[…]
[…]
ERROR: https://[my-rancher]/ping is not accessible (Failed to connect to [my-rancher] port 443: Connection refused)

$ ssh [my-node] curl https://[my-rancher]/ping
curl: (60) SSL certificate problem: unable to get local issuer certificate

$ ssh [my-node] curl -k https://[my-rancher]/ping
pong

And this is where I'm stuck, having no idea how Rancher deploys its generated CA to the nodes during setup, where they should be stored and how to fix this. Is there any built-in way to re-add nodes/clusters?
Versions:

Host OS (node/Rancher): Ubuntu 18.04.1 LTS
Docker: CE 18.09
Kubernetes: v1.12.1-rancher1-1
rke: first 0.1.11, re-ran with 0.1.12
Rancher: 2.1.1 (UI 2.1.4)

Edit: I guess my problem is actually caused by me changing the host name of my Rancher server at some point. And the settings seem to be contained in the K8 metadata of the agent deployment? Anyway, I tried to revert this by patching the node agent (kubectl edit -n cattle-system deployments/cattle-node-agent-[…]) and switching back to the previous host name, but that didn't solve it.

OK thanks for reporting that, changing the server-url/certificates are not propagated to the agents as of today, see https://github.com/rancher/rancher/issues/14731. Let me know if that doesn't solve the issue.

I think that certificates might have not be my problem after all. I removed and reinstalled the whole cluster as well as Docker (nvidia-docker2 actually) a couple of times. I also tried to install from Rancher instead of standalone RKE. The result is always the same. Something is weird tough:
My cattle-cluster-agent throws the errors I mentioned:
# INFO: Using resolv.conf: nameserver <IP_ADDRESS> search cattle-system.svc.cluster.local svc.cluster.local cluster.local mydomain.tld options ndots:5
# ERROR: https://k8.mydomain.tld/ping is not accessible (Failed to connect to k8.mydomain.tld port 443: Connection refused)

But meanwhile cattle-node-agent successfully (!) connects to the same endpoint:
# INFO: Using resolv.conf: nameserver <IP_ADDRESS> search mydomain.tld
# INFO: https://k8.mydomain.tld/ping is accessible
# time="2018-12-07T13:25:03Z" level=info msg="Connecting to wss://k8.mydomain.tld/v3/connect with token blahblahblahblah"
# time="2018-12-07T13:25:03Z" level=info msg="Connecting to proxy" url="wss://k8.mydomain.tld/v3/connect"

So, both of these guys run with different DNS settings and one of them can't reach my Rancher installation. Where do the different DNS settings come from? Is that something I can influence?


CB-16759: Have resource authorization doable on detached DLs in order to enable recovery on detached DLs.

Jira: https://jira.cloudera.com/browse/CB-16759
I recently made an initial change for this in: https://github.com/hortonworks/cloudbreak/pull/12585 thinking it was working as expected, but what I initially thought worked didn't.
Essentially, the resource authorization done by the Recovery API method calls an internal method which obtains the DL in a way that does not allow detached DLs. This makes recovery of detached DLs impossible.
This change makes it so the resource authorization is able to be done on detached DLs as well. I have tested this fully and in the correct manner this time.

retest this please


Added wait_for_controltower parameter to create_account

Added wait_for_controltower parameter to  the "create_account" method, that gives the choice to skip the wait for control tower (to pick up the account creation process that was started by service catalog), in cases where it's not necessary and execution time is a limiting factor.

The issue with this change is that control tower is absolutelly uniprocess for any creating process. If the wait for service catalog is removed, then we potentially create a race condition were upon creating an account, before the service catalog starts running, so there is no way for the library to know that something is executing you can request a creation of another account or an OU which will subsequently fail leaving the creationg requesting process in an inconsistent state without any feedback about the failure either.
The wait for the service catalog should not be more that 1 or 2 seconds at most so I do not expect it to be such an issue. Thoughts?

To elaborate a bit, the library is trying to check if control tower is busy with some heuristics that can be seen here. It is important that if any of those sitiuations occur no active process is tried because it will fail. This decorator makes sure that any action that is active is allowed only if control tower is not busy already and if it is it will raise an exception. For this mechanism to work properly we need to make sure that no action is executed without the process being able to identify if one of the busy heuristics are active. When you create an account a request is made to the control tower control plane that in the background does stuff and eventually trigers the creation of the account via the service catalog product. There is a small time delay between those two steps but the request to the control tower control plane returns imediatelly which leaves a window for a rave condition. That is why that wait is important there.

After debugging it a bit more , I found that the timeout is caused by a bug in the get_changing_accounts method that is used to check if control tower is busy here.  The get_chaning_accounts method is not paginating the results returned from the servicecatalog api, and will only check the first 100 provisioned products (here).
I will close this pull request and create a new one.

Great catch!


[Feature Request] Download lyrics for all selected in library.

LSP3 had a great feature where, if you right clicked on your library with a file or more selected, it would find lyrics for everything selected and add that either via ID3 or .txt next to the file. It would be great to have this feature back as it made adding lyrics to my library of 15,000 songs one click away.

Duplicate of #58


A new car record is shown after re-opening the "Your cars" page

https://user-images.githubusercontent.com/71496479/108511785-0868a200-72c9-11eb-8939-687ce9374f46.mp4
Environment:  Android 11, Samsung Galaxy S10e.
Reproducible: always.
Build found: 1.0.51
Preconditions
The "Car" app is opened
The "My Profile" page is opened
Steps to reproduce

Open the "Your car" page
Click on the  "Add a car" button at the bottom of the page
Entered all required information with valid data
Click on the "Save" button
Click on the "Back" button
Re-open the "Your cars" page.
Observe the result

Actual result
A new car record is shown after re-opening the "Your cars" page
Expected result
A new car record is shown after clicking the "Save" button in the "Your car" list.
User story and test case links
"User story #33
Labels to be added
"Bug" ("bug"), Priority ("pri: high")

Fixed by TetianaLysak


Firewall requirements

Are firewall requirements accurate? This looks inconsistent with the troubleshooting agent issues page : https://docs.microsoft.com/en-us/azure/azure-monitor/platform/agent-windows-troubleshoot. It's not to ideal allow connectivity to/from *.blob.core.windows.net when we want to restrict outbound connectivity; which I think means every customer storage account in Azure would be included, as well as the other wildcard URLs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b71519d-1b94-c489-ce51-7210eb05b109
Version Independent ID: fb6adce7-aa81-28e9-ad54-8c90dd86afa2
Content: Log Analytics agent overview - Azure Monitor
Content Source: articles/azure-monitor/platform/log-analytics-agent.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@jonclyde  Thanks for your comment. We will review the issue and get back to you.

Assigning @bwren for visibility, review, to provide insights and for document enhancement consideration as appropriate.

#label:"CreateAzMonWIFeb2021"

Thank you for your contribution to the Azure Monitor documentation. We have created a workitem for this issue in our internal backlog database. We will prioritize it and make any necessary changes as we are able.
#please-close


"Popped out" documentation page does not print

Describe the bug
A documentation that was opened by poping the sidebar is not allowed to print.

Copy pasting the URL into a new tab fixes the issue.
To Reproduce
Steps to reproduce the behavior:

Go to block editor
Click on Reference
Click on pop out
Click on print icon

Expected behavior
It prints
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 69

Should be fixed in the latest


Update README.md

Changes:

Modify the plugin description
Modify the alt text for images
Cleanup a few grammar & capitalisation issues
Re-order sections to be easier to navigate
Improve descriptions & examples for some config fields
Order configuration fields alphabetically (after Url, Urls, & Keyword)
Other formatting changes

Thanks for your great work!


Feature request:  Named Logs

Description
Docker can collect logs, but only as primary and error logs.  It would be nice to be able to collect more logs, especially from child worker processes.
For example:  php-fpm emits its own main log on stdout; while its children try to open an access.log and error.log.  That's three separate logs; docker can't collect them separately.
It would be nice if Docker allowed an option to name a log file, at which Docker will create a named pipe.  For example:  /var/log/nginx/error.log could be specified, and Docker would create an error.log named pipe which it then recognizes as that file.
By naming these logs, it would be possible to pull that specific log via docker, or to inform log drivers that a particular log is in use.  At the very least, it becomes possible to collect additional logs, and to read them by calling docker logs --name LOGALIAS MYCONTAINER.

I like this idea, but how can we implement for Windows?
IIUC due to the limitation of Windows NPFS, named pipes can be only created under \\.\pipe, and some apps does not accept such a string as a valid file path.
Although we can use regular files instead, but it does not seem work well with large files that need to be rotated.
So, I'd like to suggest a workaround by redirecting {access, error.log} to some syslog container.
i.e.

nginx container --> syslog container (https://nginx.org/en/docs/syslog.html)
syslog container --> docker logger

Another idea is to implement a built-in syslog server which is accessible from a container via a network, but I wonder it is too much

@AkihiroSuda We've definitely talked about the syslog approach in the past.

@docker/core-containerd-maintainers
I think this feature is worth considering as a feature of containerd, although I'm unsure how it would work on Windows
(related: https://github.com/docker/containerd/issues/603)

/cc @crosbymichael @mlaventure ^^

Let me close this ticket for now, as it looks like it went stale.


CI: update submodules

Description
When we switch to the SHA of the PR for test, we should probably also update the submodules, which will hopefully resolve failures like: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/stackrox_stackrox/2991/pull-ci-stackrox-stackrox-master-grouped-static-checks/1568213389635751936
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
CI is sufficient

/test gke-nongroovy-e2e-tests


Week 4 Hacks

CollegeBoard Collaboration Notes and Quiz link
Psychology and the Good Life Talk Notes link
Video link
Shared Repository link

You personalized your website a lot and it looks really good, I also like all the transitions in your video 2.7+

You showed how you personalized your fastpage, and what the results were, which is great. and Overall showed how you know your stuff. Bonus points for transitions, 2.7 +

Great video editing skills and you did a good job showing the process of each required step. 2.7+

nice pace and coordination of key details.   I liked see captions as a good tool.   Nothing extra as far as I can tell.  2.7

2.7
You did a good job at explaining all your steps and showing your knowledge of what you did.

I believe that Edwin deserves a 2.7+ since he has transitions in his video and showed his fast pages site.

I like how you explained is process of making the changes and successfully made the changes, I also like the edits that you made. 2.7+

Great video editing and explanations with tons of personalizations your own page. 2.7+

2.7+, you were very well spoken in your video and it was easy to follow


Kubelet ServiceMonitor creates conflicting time series

What happened?
When we use the provided ServiceMonitor for kubelet, each endpoint produces some identical metrics. In particular, this is the case for metrics that are generated for every scrape, such as scrape_samples_post_metric_relabeling. This is what happens when we graph this metric:

Did you expect to see some different?
Based on the ServiceMonitor manifest, this is expected. The only difference between the endpoints is the metrics path, but this value is not added to the time series labels. However, despite this being expected, it's definitely a bug as it leads to the behavior shown in the image above.
How to reproduce it (as minimally and precisely as possible):
Just apply the ServiceMonitor in any cluster that supports it.

At the end of the graph, you can see the lines smooth out. This was the result of adding this configuration into each of the endpoints:
relabelings:
- sourceLabels: [__metrics_path__]
  targetLabel: metrics_path

As already mentioned on the proposed pull request, I like this improvement a lot. Once fixed in terms of generation, I'm happy to move forward with it.


Assign Azure AD Identity to existing VM in Azure? Possible?

This document mentions:
There are multiple ways you can enable Azure AD login for your Windows VM:
Using the Azure portal experience when creating a Windows VM
Using the Azure Cloud Shell experience when creating a Windows VM **or for an existing Windows VM**

The documentation does not mention how to apply this feature to an existing VM. I can install the extension on my existing VM, but of course the VM did not get created with the --assign-identity switch. I had hoped this would work:
az vm update
--resource-group myResourceGroup
--name myVM
--assign-identity \
But alas it did not. So, my question is, if I have a windows 10, 20H2 VM in Azure, how would I give it an AzureAD Identity using ARM Template, Powershell, CLI, or the Portal UI?
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c946fe0f-e18d-2529-2fbf-bce04759fbca
Version Independent ID: 885a61d1-6096-5aa0-fe8d-f1ec8d55e542
Content: Sign in to Windows virtual machine in Azure using Azure Active Directory (Preview)
Content Source: articles/active-directory/devices/howto-vm-sign-in-azure-ad-windows.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@eggind Thank you for your query. We will investigate and update the thread.

@eggind
Thank you for your time and patience throughout this issue!
From our documentation - to enable an existing VM to use Azure Active Directory authentication, you need to enable System assigned managed identity on your virtual machine before you install the Azure AD login VM extension. You can install AADLoginForWindows extension on an existing Windows Server 2019 or Windows 10 1809 and later VM to enable it for Azure AD authentication.
After enabling your VM for System assigned managed identity and installing the extension, you should be able continue along with the steps in the documentation.

If you're still running into issues, please let me know.
Thank you!

@eggind
I just wanted to check in and see if you had any other questions or if you were able to resolve this issue?


Add support for Elrond (ERD)

Elrond, a top 200 token, is not present on the widget and should be added.

@Sleepy-Pip ERD has been added in 1.4.0.


Add ClonesPlus extension

ClonesPlus adds various blocks to make the cloning features on Scratch far more useful.
Extension thumbnail (image and uncropped SVG):

Are there any more issues with this that I should address before it gets merged?

ended up making quite a few changes to prevent renaming variables from causing as many issues (menus now use variable IDs instead of names); consider taking a look to see if there's any regressions

First of all, I had not even considered renaming variables so I appreciate you not only pointing that out but resolving it yourself, that was impeccably helpful
I just tried it, and I have no problems with it. Try as I might I can't break it lol

LETS GOOOOOOO.

I think you should also add a "touching clone with (var) containing (value)?"

Make this an issue
That block already exists, with limited functionality


Don't override path in NavLink component. Fixes #6613

See comments here.
I added some unit tests in NavLink-test and also removed the location override as a precaution for other interactions.

@timdorr Added tests. Let me know of any feedback you might have.

BTW, you might want to check for any documentation or examples where you show or suggest using  as a wrapper / matching-utensil like in NavLink.

Rebased and added a similar refactoring as #6685 too. I can move that to it's own PR if you want to.

Can you update the size snapshot?

@timdorr  Rebased onto master and corrected the snapshots while doing so.

Great! Thanks!


Allow suppressing install messages

These install messages create a lot of noise if you're doing something like repeatedly running a test suite in dev.  It would be nice to have it so we could make this optional.

Is configuring a no-op logger a possibility?

+1 to being able to suppress these.

https://github.com/open-telemetry/opentelemetry-ruby/pull/831


Add a COMMIT file to the artifacts

Looks good to me, as long as CI agrees.

Just don't merge it yet, I need to verify something first.

Hum the CI on Windows is completely broken but still is green. I'm trying to fix that now ...

#=== ERROR while installing ofs.local =========================================#
# opam-version 1.2.2
# os           darwin
# command      ./configure --prefix /Users/distiller/vpnkit/_build/opam/4.02.3
# path         /Users/distiller/vpnkit/_build/opam/4.02.3/build/ofs.local
# compiler     4.02.3
# exit-code    1
# env-file     /Users/distiller/vpnkit/_build/opam/4.02.3/build/ofs.local/ofs-10031-817288.env
# stdout-file  /Users/distiller/vpnkit/_build/opam/4.02.3/build/ofs.local/ofs-10031-817288.out
# stderr-file  /Users/distiller/vpnkit/_build/opam/4.02.3/build/ofs.local/ofs-10031-817288.err
### stderr ###
# ocamlfind: Package `cstruct.syntax' not found
# W: Field 'pkg_cstruct_syntax' is not set: Command ''/Users/distiller/vpnkit/_build/opam/4.02.3/bin/ocamlfind' query -format %d cstruct.syntax > '/var/folders/jm/fw86rxds0xn69sk40d18y69m0000gp/T/oasis-8dd613.txt'' terminated with error code 2
# E: Cannot find findlib package cstruct.syntax
# E: Failure("1 configuration error")

#=== ERROR while installing tcpip.999 =========================================#
# opam-version 1.2.2
# os           darwin
# command      ./configure --prefix /Users/distiller/vpnkit/_build/opam/4.02.3 --disable-xen --disable-unix
# path         /Users/distiller/vpnkit/_build/opam/4.02.3/build/tcpip.999
# compiler     4.02.3
# exit-code    1
# env-file     /Users/distiller/vpnkit/_build/opam/4.02.3/build/tcpip.999/tcpip-10031-ec53e1.env
# stdout-file  /Users/distiller/vpnkit/_build/opam/4.02.3/build/tcpip.999/tcpip-10031-ec53e1.out
# stderr-file  /Users/distiller/vpnkit/_build/opam/4.02.3/build/tcpip.999/tcpip-10031-ec53e1.err
### stderr ###
# ocamlfind: Package `cstruct.syntax' not found
# W: Field 'pkg_cstruct_syntax' is not set: Command ''/Users/distiller/vpnkit/_build/opam/4.02.3/bin/ocamlfind' query -format %d cstruct.syntax > '/var/folders/jm/fw86rxds0xn69sk40d18y69m0000gp/T/oasis-e1ccde.txt'' terminated with error code 2
# E: Cannot find findlib package cstruct.syntax
# E: Failure("1 configuration error")

:-(

ok, I've removed the artificial dependency of ofs to camp4, add a missing dependency in proto-vmnet and I've added a constraint to force tcpip.999 to use an older version of cstruct. Hopefully this should fix the build issues ...

@yomimono If you improve tcpip.999 to not use camlp4, don't forget to drop the constraint that I have added :-)

I'm cherry-picking stuff for tcpip.999 atm


Link to Next lesson missing

For lesson 8 (changesummaryqueries) the link at the very bottom to the next lesson, lesson 9 is missing. Also on the pages for lessons 9, 10, and 11 the links to previous and next lesson are missing.

⚠ Do not edit this section. It is required for imodeljs.github.io ➟ GitHub issue linking

LINK: Querying-Change-Summaries---iTwin.js-link-to-docs
TAG: imodeljs-docs-question
SOURCE: https://www.itwinjs.org/learning/ecsqltutorial/changesummaryqueries/

Maybe the fix has not yet propagated to the public website? The issue does not appear to be fixed. On the pages for lesson 9, 10, and 11 the links at the bottom are still missing. For lesson 8 it only has a button to go back to lesson 7, not one to proceed to lesson 9.

That's correct, @sypkenssmit - the docs will be republished with the fix soon. Reopened for tracking.

The docs have been updated. Feel free to re-open if you're still seeing an issue.


KEP-2170: Add unit and E2E tests for model and dataset initializers

What this PR does / why we need it:
I added unit tests and e2e tests for model and dataset initializers.
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2305
Checklist:

[ ] Docs included if any changes are user facing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
77

Relevant Lines:
77

💛  - Coveralls

Hi @andreyvelich ,
Could you help review this PR? Or should we wait for the PR of the training client?
Thank you!

@seanlaii Sorry for the delay, sure, I will review it today

Hi @andreyvelich , could you help review the PR? I addressed the comments. Thank you!


Restricting collectives ability to change slug/handle

Who is your user?
collective admins --> fiscal host
What are they trying to achieve?
Currently when a collective changes it's slug/handle it doesn't notify the fiscal host and can cause confusion/ feel like the collective has 'gone missing'
We could either stop collectives from being able to do this or reroute old slugs to new slugs
Comments from @znarf
"We could but preventing or redirecting is a whole feature request.
Preventing is certainly more easy but as there is user demand for this, we would still have to help people willing to change their slug in another way, through support request I imagine. And we're back to the beginning as this can still confuse Fiscal Hosts if they switch. Or we involve Hosts in the process, but this is then a new feature and a new process, with some restrictions and allowance, so complicated again.
Redirecting forces us to keep track of every slug variation in a new indexed table in the database, then we need to have a policy of how long we want to keep redirecting until the slug is free for another account. Note that sometimes, people mess up between their Individual, Collective and Organization accounts (some created by mistake) and move the same slug from one to the other, so in those cases redirection is actually not desired and they would contact support if it was prevented."
How are they currently doing this?
Collectives can change slugs
How well understood is this problem?

[ ] Surfacing: if you feel this is a seed of an idea that needs to be researched.
[ ] Understanding: if you've done some research and feel it is already well understood and ready for shaping.
[ ] Shaping:  if you feel a solution is clearly defined and can be made into a pitch (read more about shaping)
[ ] Pitching: if you feel that it is ready to be presented for prioritisation (read more about pitching)

Issue about implementing redirect: #2283


Is there any plan to support the bbr algorithm?

Is there any plan to support the bbr algorithm?

No plan yet, sorry. The current one is as described in https://datatracker.ietf.org/doc/html/rfc9002
I'd need to make the Recovery supporting different algorithms first.

thanks


bug: visual mode, closing grug & duplicate buffer names

There's four issues I encountered that I'm willing to fix, but I'm not 100% if this was intentional or not:

with_visual_selection does not work when still in visual mode. The util.getSelection always returns the last selection. A fix for this is to do norm! v when still in visual mode, before getting the selection.
When pressing q, grug closes, but an empty grug buffer stays around
When opening grug multiple times, you will eventually get errors about duplicate buffer names
--hyperlink-format should probably be added to blacklisted flags (see https://github.com/LazyVim/LazyVim/pull/4099#issuecomment-2236674297)

Instead of a separate function with_visual_selection, I think it would be cleaner to always use grug_far(), but add an option to start the search with the visual selection?

Thanks for reporting those! 😄

with_visual_selection does not work when still in visual mode. The util.getSelection always returns the last selection. A fix for this is to do norm! v when still in visual mode, before getting the selection.
That seems like a legit bug!
Instead of a separate function with_visual_selection, I think it would be cleaner to always use grug_far(), but add an option to start the search with the visual selection?
I am assuming you mean something like:

require('grug-far').grug_far({ use_visual_selection = true , ... })

I am good with doing that if it enables more elegant keybinding. The reason it's a separate function now is that it affects multiple existing GrugFarOptionsOverride opts (prefills.flags and prefills.search). But am happy with turning it into a GrugFarOptionsOverride option, as long as we deprecate with_visual_selection() and point it to the new call so existing usages are not broken.

When pressing q, grug closes, but an empty grug buffer stays around
Assuming you mean :q. Yes this is on purpose in case you need to refer back to your search later, but need the screen real estate. I got used to "saved searches" from Intellij Idea 😆.  This behaviour is also useful in the case you want to toggle with toggle_instance(). You can close with :bd or <localleader>c (by default). I am not opposed to a "close_on_window_close" (or some better name) option though if people want that type of behaviour.

When opening grug multiple times, you will eventually get errors about duplicate buffer names
Hmm, this is what context.count appended to the title in updateBufName() (farBuffer.lua) is supposed to be avoiding.
It's incremented for each instance when createContext() (grug-far.lua) is called.
I cannot reproduce it myself, but if you can, would definitely appreciate a fixed!

--hyperlink-format should probably be added to blacklisted flags (see https://github.com/LazyVim/LazyVim/pull/4099#issuecomment-2236674297)
Ah, I see the issue, this just need to be forced to --hyperlink-format=none in getArgs.lua. I'll do that!

FYI, fixed (4) in https://github.com/MagicDuck/grug-far.nvim/pull/123

3 is caused by restoring sessions and the fact that q only closes the window and not the grug buffer.
When restoring a session, empty grug buffers will also be restored and that's probably why I got name conflicts.
As for 2, no big deal. I LazyVim, I just make it close the buffer as well. Maybe not needed to make that optional, since it's pretty easy to do yourself.
1 In LazyVim, I have just one mapping. In visual mode I use the visual selection, otherwise the normal call.
I think this might be a keymap that a lot of users might want to have. In that case, the current way of calling two different methods works fine, but is a bit akward.
Thank you for fixing 4!

(3) Ah, I see, on session restore.
I tried setting buftype to nofile on the grug-far buffer, but that does not seem to affect mksession. I guess this is related to https://github.com/neovim/neovim/issues/12242
Might still be valuable to set that option on the grug-far buffer though.
I guess the best we can do is check the list of all buffers for GrugFar - <count> until we hit something that is not used.

FYI, "fixed" 3 in the sense that there new grug buffers will always have unique names, even after session restore.
I could not find a way to completely exclude them from being saved by mksession. I guess that's something that will have to be handled by custom sesssion plugins if people care.
https://github.com/MagicDuck/grug-far.nvim/pull/129

Awesome, thanks.
fyi: grug-far is now included in LazyVim :)

wohoo! nice! 🥳

@MagicDuck congrats 😆

1 In LazyVim, I have just one mapping. In visual mode I use the visual selection, otherwise the normal call.
I think this might be a keymap that a lot of users might want to have. In that case, the current way of calling two different methods works fine, but is a bit akward.
Yes, this makes total sense! That way you don't even need an option to toggle that behaviour, just do it differently in visual mode, dunno why my brain was missing that, haha. I can make a PR to do that in the next few days, depending on when I get the time. Or if somebody else gets to it faster that's good to...

thanks @jacktuck , it's a big milestone for grug-far! 😄

@folke let me know if this works for you on the LazyVim side 😄
https://github.com/MagicDuck/grug-far.nvim/pull/134

lgtm!

@folke awesome! Thanks, it's merged now!


Add binary uuid option #1778

Add useBinaryUuid option in 'uuid' function.
If this option is 'true' use 'binary(16)' type (other than PG).
Closes #1778

Ok, I see the point.
Knex include already uuid package (https://www.npmjs.com/package/uuid#uuidparsestr) so I will check later what I can do.

You should create function to transform uuid-s before inserting and after get. You can use something like uuid-parse package. For example, currently i'm are using query transformer to automatically parse uuid in readable strings for mysql db like this:
function typeCast(field, next) {
	if (field.type === "STRING" && field.length === 16) {
		const buf = field.buffer();
		return buf ? uuidParse.unparse(buf) : null;
	} else {
		return next();
	}
}

this function makes easier to work with uuid-s in backend, but limits some functionality because it will trigger to any varchar(16) columns

As I can see it's not so easy to make that in Knex.
I want to make something generic, where the logic of parse/unparse is defined with column definition (in ColumnCompiler).
When you prepare Insert in querycompiler you dont have any information about the column type and you cant convert your uuid at this time.
Same problem in runner.js when you process the query.
If you have hints about how to get the type of column inside insert compiler and runner I am open @kibertoad.
If it's not possible, I can also make utils to manually convert uuid's before and after inserts.

@OlivierCavadenti Knex should never have any info about column it is inserting to. I would suggest adding util method to knex-utils instead.

@OlivierCavadenti Knex should never have any info about column it is inserting to. I would suggest adding util method to knex-utils instead.

One other option is to provide utils in knex (like knex.raw...) to convert in binary with database specific SQL (like BIN_TO_UUID in MYSQL: https://stackoverflow.com/a/45186851/1535159).  Need more work btw.

yeah, that works too

In cockroachdb, pg types are used and I have to fix the answer with hexadecimal data, I temporarily did this:
const { types } = require("pg");
types.setTypeParser(17, value => Buffer.from(value.replace("\\x", ""), "hex"));

You need to think about a more beautiful solution.

In cockroachdb, pg types are used and I have to fix the response with hexadecimal data, I temporarily did this:
const { types } = require("pg");
types.setTypeParser(17, value => Buffer.from(value.replace("\\x", ""), "hex"));

We need to think about a more beautiful solution.
For insertion the uuid format can be any hex, or formatted with a separator, or guid in curly braces, all of these formats are converted automatically to the specified column type, or text representation, or binary (hex)

Thanks for comments. I need to finish another task before this PR, but as I can see, a lot of people have workaround and wait this. I will find a clean solution to make the use as smooth as possible :D.

@OlivierCavadenti BTW, can you add yourself to the list of maintainers in package.json?

I choose to add two functions in FunctionHelper.js to avoid dependencies and SQL db specific generation.
To use :
Create table with option actived on uuid column:
await knex.schema.createTable('uuid_table', (t) => {
  t.uuid('uuid_col_binary', { useBinaryUuid: true });
});

Insert your uuid in binary format with uuidToBin function:
await knex('uuid_table').insert({
  uuid_col_binary:  knex.fn.uuidToBin('3f06af63-a93c-11e4-9797-00505690773f'),
});

Retreive it and convert it:
const uuid = await knex('uuid_table').select('uuid_col_binary');
knex.fn.binToUuid(uuid[0].uuid_col_binary)

@mishase @intech the solution is good for you (see comment above) ?


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
de9d7f6 -> a4a74ca

github.com/IBM/platform-services-go-sdk
require
patch
v0.69.0 -> v0.69.1

Release Notes

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.69.1
Compare Source
Bug Fixes

build: bump core to 5.17.5 (#357) (8d77a4b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement gumtree-based structural diff

@olafurpg have you implemented diff for scalameta?
If you still need one based on gumtree, please check https://github.com/alexander-myltsev/scalameta/pull/1/files#diff-2a8eb81e44bd555bb5d1f1920a771451 . So many jars are added since gumtree is distributed as a bunch of zipped jars.
The next piece I need is positions of AST nodes. Why are they None at https://github.com/alexander-myltsev/scalameta/pull/1/files#diff-2a8eb81e44bd555bb5d1f1920a771451R39 ?


Contract update changes

@vvisigoth this PR addresses the following issues: #18 #19 #20 #21 #22 #23 #24 #25 #26 #27 #28

Thanks Ben! I’ll take a look and get back to you with comments.
On Wed, May 30, 2018 at 9:52 PM Ben Calder<EMAIL_ADDRESS>wrote:

@vvisigoth https://github.com/vvisigoth this PR addresses the following
issues: #18 https://github.com/urbit/etherwallet/issues/18 #19
https://github.com/urbit/etherwallet/issues/19 #20
https://github.com/urbit/etherwallet/issues/20 #21
https://github.com/urbit/etherwallet/issues/21 #22
https://github.com/urbit/etherwallet/issues/22 #23
https://github.com/urbit/etherwallet/issues/23 #24
https://github.com/urbit/etherwallet/issues/24 #25
https://github.com/urbit/etherwallet/issues/25 #26
https://github.com/urbit/etherwallet/issues/26 #27
https://github.com/urbit/etherwallet/issues/27 #28
https://github.com/urbit/etherwallet/issues/28
You can view, comment on, or merge this pull request online at:
https://github.com/urbit/etherwallet/pull/29
Commit Summary

changes to urbitwallet-master
New partials. Update all functions related to the state and lock
time. Update variable names. Consolidate functions to match smart contracts.

File Changes

M app/includes/urbit.tpl
https://github.com/urbit/etherwallet/pull/29/files#diff-0 (56)
M app/partial/allowtransfer.html
https://github.com/urbit/etherwallet/pull/29/files#diff-1 (2)
M app/partial/buy.html
https://github.com/urbit/etherwallet/pull/29/files#diff-2 (2)
A app/partial/configurekeys.html
https://github.com/urbit/etherwallet/pull/29/files#diff-3 (123)
M app/partial/creategalaxy.html
https://github.com/urbit/etherwallet/pull/29/files#diff-4 (26)
M app/partial/launch.html
https://github.com/urbit/etherwallet/pull/29/files#diff-5 (2)
A app/partial/setspawnproxy.html
https://github.com/urbit/etherwallet/pull/29/files#diff-6 (115)
A app/partial/spawn.html
https://github.com/urbit/etherwallet/pull/29/files#diff-7 (116)
M app/partial/state.html
https://github.com/urbit/etherwallet/pull/29/files#diff-8 (53)
M app/scripts/controllers/tabsCtrl.js
https://github.com/urbit/etherwallet/pull/29/files#diff-9 (7)
M app/scripts/controllers/urbitCtrl.js
https://github.com/urbit/etherwallet/pull/29/files#diff-10 (260)
M app/scripts/main.js
https://github.com/urbit/etherwallet/pull/29/files#diff-11 (28)
M app/scripts/services/templateService.js
https://github.com/urbit/etherwallet/pull/29/files#diff-12 (16)
M dist/js/urbitwallet-master.js
https://github.com/urbit/etherwallet/pull/29/files#diff-13 (99)
M package-lock.json
https://github.com/urbit/etherwallet/pull/29/files#diff-14 (8)

Patch Links:

https://github.com/urbit/etherwallet/pull/29.patch
https://github.com/urbit/etherwallet/pull/29.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/urbit/etherwallet/pull/29, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiQ44HtxG9MFvv5mKz5TmCYRB1IiDaAks5t33b8gaJpZM4UUavM
.

--
—
~poldec-tonteg
http://urbit.org

Gas estimation errors turned out to be caused by the smart contracts validating hasBeenBooted status.


BuildInfo is always saying deploy artifacts is set to false

Describe the bug
I am not able to deploy from a Github Actions workflow file to a Jfrog-GCP repo (hosted at bkjfrog.jfrog.io), because the BuildInfoExtractor keeps deciding that publish flags are set to false:
[main] INFO org.jfrog.build.extractor.maven.BuildDeploymentHelper - Artifactory Build Info Recorder: Saving Build Info to '/home/runner/work/tts-model/tts-model/target/build-info.json'
[main] INFO org.jfrog.build.extractor.maven.BuildDeploymentHelper - Artifactory Build Info Recorder: deploy artifacts set to false, artifacts will not be deployed...
[main] INFO org.jfrog.build.extractor.maven.BuildDeploymentHelper - Artifactory Build Info Recorder: publish build info set to false, build info will not be published..

The relevant part of the Github actions file looks like this:
      - name: push to JFrog
        uses<EMAIL_ADDRESS>        with:
          version: 1.48.1
        env:
          JF_ARTIFACTORY_1: ${{ secrets.JFROG_KEY }}
          M2_HOME: /usr/share/apache-maven-3.8.1
          JFROG_CLI_LOG_LEVEL: DEBUG
          buildInfo.env.publisher.publishArtifacts: true
          buildInfo.env.publisher.publishBuildInfo: true
      - run: |
          M2_HOME=/usr/share/apache-maven-3.8.1 jfrog rt mvnc
          M2_HOME=/usr/share/apache-maven-3.8.1 jfrog rt mvn clean install
          M2_HOME=/usr/share/apache-maven-3.8.1 jfrog rt bp

Versions

Can be seen in the workflow snippet above

Additional context
I am trying setting various buildInfo env vars but without any success.

It looks like the deploy server and repository are not configured.
To configure the deploy server, please provide --server-id-deploy, --repo-deploy-releases, and --repo-deploy-snapshots flags to the mvnc command:
jfrog rt mvnc -server-id-deploy= --repo-deploy-releases= --repo-deploy-snapshots=

For more information see Running Maven Builds.
Please let me know if it helped.

Thanks, that solved the immediate problem and now it's trying to publish to the repository.
However I'm still seeing a "401 Authentication required" error in the publish to repo step (can raise a separate ticket for that if you want).
Is there an end-to-end working example for publishing to a JFrog Artifactory repo? I've temporarily switched to using the artifactory-maven-plugin.

@pramodbiligiri,
Are you sure the credentials encoded inside the JFROG_KEY are correct? I can't think of any other issue that cause a 401 response.

Thanks @eyalbe4 . Will take a look at this again soon.


Retr0h/improved linting

Looks good. This probably addresses, more or less, CIA-133.

Just my 2 cents here, but a comprehension would be nicer here I think:
filenames.append([os.path.join(root, name) for name in files if name.split(os.extsep)[-1] in valid_extensions])

This is just a matter of opinion, so I give :+1:  anyway

Just my 2 cents here, but a comprehension would be nicer here I think:

I agree.  I try to use list comprehension wherever possible.  In this case I thought it was doing a bit much, but after looking at it more, I like it. Updated PR.

:+1:


Components transition enter function not called when using Vue version 2.6.10

Version
2.6.10
Reproduction link
https://github.com/katerlouis/vue-2610-bug
Steps to reproduce
serve or build the app
and press the toggle button
What is expected?
HelloWorld component should call enter function
What is actually happening?
HelloWorld component doesn't call enter function

enter of the transition directly inside App.vue (the logo img) gets called though, which is odd.
With vue v2.5.17 it works as expected (haven't used any other vue version since)

You need to use the appear prop for the animation to play initially

No, it has nothing to do with appearing or not- if you press the toggle button multiple times, the enter function of HelloWorld still isn't called with Vue 2.6.10, as you can see in the provided demo. Please reopen the issue @posva

I have the same problem, and i down to 2.6.8 to get work.

the transition inside HelloWorld needs the prop appear to play at the same time as the parent appears:
  <transition :css="false" @enter="enter" @leave="leave" appear>

For the leave transition it's currently not possible, you can track the feature at https://github.com/vuejs/vue/issues/9328
I hope this helps :)

Wait? Doesn't this also mean the HelloWorld component would animate / call the enter function on first load? What if I don't want that?
And the leave transition isn't the issue here. It works as expected. When the component leaves, its leave-function gets called.
I'm wondering why this change was introduced. We clearly lose functionality here.

@posva could you please look into this again? I'm still under the impression there is a misunderstanding here.
Again: leave is not an issue.
And initial animation is not desired.
I still do not understand why the enter function should be called in this situation
// App.vue
<transition @enter="enter" @leave="leave" :css="false">

</transition>

<HelloWorld msg="Helloooo" />

but not here
<transition :css="false" @enter="enter" @leave="leave">

{{ msg }}

                ....

</transition>

It's hard to believe that this is intended.
Could you please help me understand?

It is intended because the first one is wrapping an element with a v-if while the second isn't and it's directly there when the parent renders. So if you want it to apply the enter transition, you need the appear prop

Okay, if I add appear to the transition inside HelloWorld.vue, its enter-function rightfully/expectedly gets called when toggling. Cool.
But it also gets called on initial load of the app, which is not what I want and what I understand is exactly what appear is there for.
How do you suggest working around that?
Because with this change, as is, I cannot update to the newer vue version in my app.
I read what you are saying, but still not fully understand what you are trying to solve with this new implementation. What was wrong with the way it worked before? What problems did it bring?

The way it works now it the way it was always intended to work.

Without appear, elements are not transitioned in on the first render of the <transition> component(!), only on updates of the transition component (i.e. by switching a v-if inside of the <transition> component
With appear, they are transitioned in on first render as well.

But it also gets called on initial load of the app which is not what I want [...]
That should only be the case if the v-if="show" in App.vue is also true when loading the app, which it isn't in your example.

So I assume it is (or can be) true at the initial load of the app?

How do you suggest working around that?

I would handle this in a global fashion, i.e. set a (non-reactive) flag in the main component to trueafter initial render.
Then each component can check that flag on re-render and determine wether or not appear should be applied.
in App.vue
provide() {
  return {
    isFirstRender: () => { return this.isFirstRender === false }
  }
},
updated() {
  this.isFirstRender = false // do *not* add this prop to `data`!
}

in HelloWorld.vue
<template>
  <transition
    :appear="!isFirstRender()"
    :css="false"
    @enter="enter"
    @leave="leave"
  >

      xxx

  </transition>
</template>

I used provide/inject so this can be re-used in all of the app in different places that need this.

@LinusBorg I think I found a slight thought error in your code.
The pattern works really great, but on initial load your provided function, which asks "Am I the first render?!" returns false, since the flag is still undefined and not false yet;
So if I'm correct the pattern should look like this:
provide() {
  return {
    isFirstRender: () => { return this.isFirstRender === undefined }
  }
},
updated() {
  this.isFirstRender = false // do *not* add this prop to `data`!
}

Atleast that's how it worked for me; now !isFirstRender() is false on first render, as expected;
[EDIT]
There's another issue I found with this pattern; you set the initalRender status only if some updated fires, and that only that only happens when data changes. That's not always the case. So I had to do this.$forceUpdate() in App.vues mounted() .. or you could just set this.isFirstRender = false in mounted() ..
Here's what I don't understand:
After doing this.isFirstRender = false in App.vues mounted()-hook, the slideOver component still doesn't slide on initial render (which is what I want ..) – but the App.vue mounts earlier than the slide component does, so why is this.isfirstRender still undefined by that time?
[EDIT 2]

Why on earth is mounted() of the SlideOver fired before Apps mounted()?!


block: Implement NewBlockEventSubscription

Sub-issue of #25
Implement NewBlockEventSubscription such that requesting the following information from the following Celestia Core endpoints is supported:
Request:

new blocks from the /block endpoint

This is not resolved yet.


Don't hardcode protocol in socketio URL

If InvokeAI is behind a reverse-proxy like nginx using HTTPS, then the frontend can't talk to the websocket unless it is also using HTTPS. Just specifying '//' in the URL will tell the browser to use whatever protocol it already used to load the frontend.

To get my own deployment working behind nginx with SSL, I also had to manually update the generated frontend/dist/assets/index.js, but I don't know how to generate that so I didn't include it in this patch.

@bsima - can you make this PR off the development branch?
Also, to generate frontend files, you’d go to the frontend folder and do yarn build.
will request @psychedelicious to review but please note he’s got a backlog so it may take some time

Hi @bsima , we also have #976 which I believe accomplishes the same thing. I thought that it had been merged but appears it has not.
I'm not sure if the change in that PR or your PR is preferable. Can you comment?
Until we get an automatic build process set up, we will need either an updated bundle via yarn build or a followup PR with the updated bundle from someone who has the frontend environment set up (one of us can do the followup PR, not a problem).

I'm not sure if the change in that PR or your PR is preferable. Can you comment?

They do the same thing, and #976 seems a bit cleaner and was opened first so I'll close this. Thanks!


chore(deps): replace ent with html-entities

Fixes #812
This PR replaces ent with html-entities.

Unfortunately we can't accommodate this request because Node 18 is required for this package, and we're on Node 14. If there's another dependency that would do the trick that supports Node 14, that would work. Or, we can wait until our work to upgrade to Node 16, which should be in the next few months.

@sofisl html-entities has zero dependencies.
The issues actually comes from one of the devDependencies in this repository:
https://github.com/googleapis/nodejs-common/blob/926235906e59324e100c07c7aae4175a7d0255e0/package.json#L46
I have the same error on the main branch if I run the same command as in the CI on Node 16:
npm install --production --engine-strict --ignore-scripts --no-package-lock

So the issue doesn't come from the PR

@sofisl here is a PR to fix the bug: https://github.com/googleapis/nodejs-common/pull/814


[utils] Support Python 3.10

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Use collections.abc.Sequence instead of collections.Sequence
Note that this change is incompatible with Python 3.4.x or earlier.

@xtkoba It is not possible to reliably support py3.10 till we migrate from nosetests. Have a look at #482


Mocked type is missing in @suites/unit

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
Description:
The @suites/unit package does not export the Mocked type as expected. When trying to import the Mocked type from @suites/unit using:
import { TestBed, Mocked } from '@suites/unit';

I receive the following error message:
Module '"@suites/unit"' has no exported member named 'Mocked'.
Minimum reproduction code
no
Steps to reproduce
No response
Expected behavior
Please include the Mocked type in the package's exports, or provide documentation for an alternative way to mock objects if the Mocked type has been deprecated or replaced.
Suites version
3.0.0
Node.js version
20.16.0
In which operating systems have you tested?

[X] macOS
[ ] Windows
[ ] Linux

Other
No response

Hi,
Thank you for submitting this issue. I'll take a look and update here soon!

Plus one on this @omermorad 🙏

I will look into this issue in October and try and solve it.

@roniavi @michaelcai - While @qballer works to resolve this problem, please try the following workaround:
Try importing Mocked from @suites/doubles.x instead of @suites/unit. (In this case, @suites/doubles.jest).
import type { Mocked } from<EMAIL_ADDRESS>
This is a workaround; in order to maintain consistency and library agnostic behavior (mocking library), the Mocked type should essentially be imported from @suites/unit. You may easily modify it back to be imported from @suites/unit after the bug has been fixed.
Tell me whether it was successful please :)

https://github.com/qballer/suites_issue_423
I was able to reconstruct the bug in the above repo relatively easily. I will dig into why this is happening later.

I reconstructed the bug in the exact way described in the issue.
https://github.com/qballer/suites_issue_423
It works out of the box as expected, but after installing an additional package (e.g yarn add get-port) package, for some reason, the following is missing:
in
<EMAIL_ADDRESS>Is missing:
/// <reference<EMAIL_ADDRESS>/>
The same triple slash is missing in<EMAIL_ADDRESS>Manually adding that to the js file fixes the problem.
I've also noticed that the following is missing from<EMAIL_ADDRESS>which is
export type IdentifierMetadata = import('@suites/di.nestjs').IdentifierMetadata;
Digging through the code, these are all added via post-install scripts of doubles.x and di.x. I'm unsure why this is happening and will look into it further ASAP.

Please use yarn install --force after adding a package as a workaround. This is a bug in yarn

@michaelcai @jeffrey-jian @roniavi (also related to #439 - @mbrunoviegas)
Due to a known issue with Yarn v1.x's postinstall script handling (https://github.com/yarnpkg/yarn/issues/5476), an extra step is required to set up reference types for your project. I've updated the docs, please follow: https://suites.dev/docs/overview/installation#for-yarn-v1x-users.
Please, let me know if it worked for you.


add request.awaitNotNull in addition to request.awaitBody()

It might be nice to have a standard method to get a not null request body. Something like:
suspend inline fun <reified T : Any> ServerRequest.awaitNotNull(
    noinline block: suspend (T) -> ServerResponse
): ServerResponse {
    val body = this.awaitBody<T>()
    return if (body != null) {
        block(body)
    } else {
        ServerResponse.badRequest().build().awaitFirst()
    }
}

It is indeed a very common case, maybe I could provide:
suspend inline fun <reified T : Any> ServerRequest.awaitBody(): T =
		bodyToMono<T>().awaitSingle()

suspend inline fun <reified T : Any> ServerRequest.awaitBodyOrNull(): T? =
		bodyToMono<T>().awaitFirstOrNull()

Fixed on Spring Framework side via https://github.com/spring-projects/spring-framework/commit/c5c4ac164b9c942d9e4a539fa55556347b2a14ef, thanks for raising this.


Removing redundant CCE buffers from bp_tile

These are unnecessary because the network is buffered by the wormhole adapters.  Each adapter has a two-fifo (buffer two packets), so it can connect directly to the cce.  I renamed cce_top to cce_buffered to indicate the change.

As for the symlinks, I don’t know why they constantly break. Maybe the old version of git we have on our machine doesn’t truly support them? Is there a solution without symlink? My spitball is using the same TB and passing a parameter to determine the test, similar to PROG

Review addressed.  I think we should revisit the symlinks in a separate issue.  The current build system (having the test logic essentially in bp_common) is a little unwieldy

Let’s remove symlinks. They are always unnecessary and usually result in
unhappiness.
On Thu, Oct 3, 2019 at 11:15 AM Dan Petrisko<EMAIL_ADDRESS>wrote:

Review addressed. I think we should revisit the symlinks in a separate
issue. The current build system (having the test logic essentially in
bp_common) is a little unwieldy
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/pre-alpha-release/pull/268?email_source=notifications&email_token=AEFG5AGHMQO73N3Y5KMAFDTQMYZFDA5CNFSM4I436WP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAJDEUQ#issuecomment-538063442,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEFG5ACUBOWK2QOMALL26B3QMYZFDANCNFSM4I436WPQ
.

This is going to merge in through the tapeout branch, since we wanted it there earlier.


Latest episode

Basically anime and a fix for #25.
Scraping KAT is disabled for now as the site is down, but can be easily re-enabled.
oh and ES6 classes.

Closed because anime genres is not working.


Problem with index=true option set on non-FTS fields

There is a problem with the generation of non-FTS field indices resulting in broken create index statements.

Resolved in release 0.7.1


GoWhichErrs vs GoWhicherrs

The tutorial says "GoWhichErrs", but vim-go recognizes "GoWhicherrs". Which is correct?

Well the one that is recognized of course. Open a PR so we can fix ?

Thanks @stevenblenkinsop, your PR is merged now.


Subscribe topic

I'm subscribing to a topic with the code below:
    iotDataManager.subscribeToTopic("device1/status/#", qos: 0, messageCallback: {
        (payload) ->Void in

        let stringValue = NSString(data: payload, encoding: NSUTF8StringEncoding)!

        print("received: \(stringValue)")
        dispatch_async(dispatch_get_main_queue()) {
            //some code here
        }
    } )

the problem is that when i get a message, i don't know the exactly topic which came from... example "device1/status/on" or "device1/status/value". In the example i'm getting only the payload.
Is there a way to get the full topic and the payload?

Duplicates of this issue. Merging.