Add ability to change source_ip_ranges_to_nat to allow for multiple NATs

Describe the bug
We have a use case where we need to have two NATs for a GKE cluster: one that routes 90% of the traffic through a well-known IP, and another 10% that needs to route via a dynamic IP. In the process of doing this, we tried to declare the net-cloudnat module twice, one handling the 90% case (and would have ["PRIMARY_IP_RANGES", "LIST_OF_SECONDARY_IP_RANGES"] for one set of pods), another handling the 10% case (which should have ["LIST_OF_SECONDARY_IP_RANGES"] for another set of pods.)
Code to be changed here: https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/750cff01cd42564512dccb62f32ac5caeeb35620/modules/net-cloudnat/main.tf#L103-L107
Trying to use the net-cloudnat module as-is will result in this error:
Error: Error creating RouterNat: googleapi: Error 400: Invalid value for field 'resource.nats[1].subnetworks[0].sourceIpRangesToNat[0]': 'PRIMARY_IP_RANGE'. Can not specify PRIMARY_IP_RANGE for the Subnetwork since it is already configured for Nat with the option PRIMARY_IP_RANGE., invalid

We're currently looking into using https://github.com/terraform-google-modules/terraform-google-cloud-nat as a way to work around this limitation.

This is working as documented:

I think Cloud NAT Rules is what you need.

Closing this as the module appears to be functioning correctly.

I don’t think that’s exactly it. We want to be able to access the same destination IPs but have different routing through different NATs based on the source IP range. We are trying to actually do the multi-NAT solution with different source IP ranges, but because the current net-cloudnat module assumes that PRIMARY_IP_RANGE should be on every NAT in the network, the creation fails.

See https://www.googlecloudcommunity.com/gc/Google-Kubernetes-Engine-GKE/Multiple-Egress-IPs-for-one-GKE-cluster/m-p/649467/highlight/true#M1247 for what we’re trying to achieve.

Ok, I see what you're saying. That is indeed a bug :)
Let me see what we can do

@cparedes can you try #2384 and confirm it works for your use case?
You'll probably want to do something like this:
module "nat" {
  source = "./fabric/modules/net-cloudnat"
  # ...
  config_source_subnetworks = {
    all = false
    subnetworks = [
      {
        # only primary range
        self_link     = "mysubnet"
        all_ranges    = false
        primary_range = true
      }
    ]
  }
}

terraform plan looks good, just waiting on a review on my end to actually apply the changes :)

@juliocc just did an apply, works perfectly!

Awesome, merging it then :)


[windows] npm install error:

I am unable to install  zenbot in my windows 10 .
After cloing from repository , I did "npm install" which resulted in following issue.

Error: ENOENT: no such file or directory, scandir 'C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETFramework'

How do i solve this?
Hoping for response soon.
Regards,

I have the same error, what I can do?


comments: support fetching auto-thresholded labels

In order to be able to do an analysis like "X user property by label", I need to know a specific auto-threshold for each predicted label. The idea in this PR is that if a --model-version flag is provided to re get comments --predictions true, instead of fetching the latest predictions the CLI will fetch predictions from the specified model version with the corresponding auto-threshold information (using the predict-comments v1 route).
The output is not roundtrippable---I think that's fine? But happy to change if there are better ideas.

@annesylvie I pushed a change so that the output with --model-version is an AnnotatedComment (same as the output without --model-version) (having updated the definition of labels in AnnotatedComment to optionally include the list of auto-thresholds). I had to set a bunch of things to empty as I don't have them in the predict-comment response (such as assigned/dismissed), but at least the formats are consistent now.
An alternative way to achieve the desired format with all info would be to call the predict-comments API route on top of calling labellings, but I think this is not worth it as it would make downloading a large dataset slower.


Allow the custom ObjectMapper be used for JSON serialization

When using a custom JSON serializer, by setting the property hibernate.types.json.serializer used in com.vladmihalcea.hibernate.type.util.Configuration, the default mechanism doesn't use the custom serializer for Map types (HashMap, ...).
The current code handles Collection-based types but fallbacks on the default behaviour for other types.
The default behaviour check if the value to serialize implements Serializable (and HashMap does), then the underlying Map values aren't handle by the custom serializer because already in the java native clone() behaviour.

Thanks, I'll review it when I have some time.

Thanks, I'll review it when I have some time.

No pb, to avoid being blocked, we switch on a custom serializer which doesn't use your com.vladmihalcea.hibernate.type.json.internal.JacksonUtil anymore. I've just push a PR to share the analyse with you but we aren't expecting any urgent update.
I tested this code on a single local unittest under jvm 8, as the mvn clean install of the project failed due to expected jvm 6 that i haven't install.
Thanks for your project, really useful!

No worries. I'll make surr sll tests pass when integrating it.

Add some modifications, test cases, and apply it upstream.

Thanks, I'll review it when I have some time.

Thanks, I'll review it when I have some time.

@vladmihalcea i think this last comment of you is for the PR #230 opened by @joshiste


input are not controlled by value

IMPORTANT: If you have a question or an idea for a new feature use Github Discussions instead
Describe the bug
I passed a string as value into <input/>. when user type, I didn't change the value, but the value in the input element are still changed.
To Reproduce
see playground
Expected behavior
if I do not change the value, the value in element should not change. (as what is in react)

Yeah this one is pain. React does something special here. I'm not sure who else does. The problem is you need to hack the input to actually maintain this.  I don't think this is something that I intend to ever implement. Someone did an audit a while back and realized only React was doing this out of all the libraries they tested. I don't see us keeping natural DOM behavior and implementing this.
I'm pretty much a won't fix on this. But if there is overwhelming support in other libraries like Preact, Inferno, and Svelte I might consider it (but if memory serves none of these outside of compat do this).

FWIW, my background is mainly in Angular but I find the current functionality expected. In fact, I'd be very surprised if the input value didn't update. From this conversation, I gather that, in React, the input wouldn't update. But if react is re-rendering the function component on every keypress I could see this making sense (as it is effectively re-initializing the input with a static value on every keypress). But the current behavior of Solidjs seems consistent with the DOM itself (e.g. if you create an <input value="fixed" /> you'll find that you can still change the input's value) and is what I would expect to happen.

I'm going to move this to discussions as no activity for 2 weeks and I don't see implementing this.


Correction for missing go generate in run makefile

Follow-up on this issue comment:
https://github.com/bluenviron/mediamtx/issues/3097#issuecomment-1977747645

merged, thanks


Update project version to the latest LTS version?

https://github.com/UnityCommunity/UnityLibrary/blob/4e92323a9ba1add50e282439b635b4780788660f/ProjectSettings/ProjectVersion.txt#L1
Update project version to the latest LTS version?

yeah could upgrade to 2018.4 lts, if somebody wants to check if scripts still compile there ok


Split press release pages

closes #31

@MuhammadAhsan252 Thanks, I'm merging this first. However, why do we separate publicity-and-press-releases vs press-releases? We only want to keep 1 page as press-releases and only one type of content.


[BUG] File Reading Method in the Example script is not appropriate

Describe the bug.
The example script uses relative paths (./examples/input.yaml and ./examples/output.yaml) to handle file reading and writing operations, it will fail if executed from different directories.
Expected behavior
The script should manage file paths using the __dirname variable to ensure consistent behaviour irrespective of the current execution directory. This will ensure correct file referencing at all times.
Screenshots

How to Reproduce

clone the project.
compile it with npm run dev
run cd examples then node index.js

🥦 Browser
Other
👀 Have you checked for similar open issues?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue ?
No, someone else can work on it

/gfi js

Hi @KhudaDad414, can I work on this issue?


Add Docker instructions

Hey, I just recently heard about this project, and I love it! I was wondering how to create docker containers and read through the issue (#241) and discussion (#239). I tried out what works and what seems to be clean to me and wrote it down.
If I understood it correctly, then web apps should (usually) be virtual projects, since they (usually) don't produce a package, so the first part of the guide is a recommendation on how to deal with this case. IMHO "virtual project" isn't the most intuitive name for "doesn't produce a package", and while the documentation on it is alright, it's not very discoverable to me -- I only know about them since I clicked through all the links in the docs. But maybe it's fine to refer to them in the Docker section.
I've refrained from including any sed /^-e/d requirements.lock hacking; I think that would be quite brittle.
I've read somewhere that the lockfile format is not final yet. Is it planned to keep it compatible to requirements.txt? That would influence the guide a lot.
Closes https://github.com/astral-sh/rye/issues/241

(forgot to add a file initially. force-pushed it now)

we have to imagine lockfile outcomes are influenced by what comes out of the python project's own discussions on them https://discuss.python.org/t/lock-files-again-but-this-time-w-sdists/

I think it's a good start.

Maybe needs another issue but I am seeing the following line in my requirements.lock:
The following packages are considered to be unsafe in a requirements file:
setuptools==69.2.0
...despite not needing it and setting:
[tool.rye]
virtual = true
Should I remove this with sed before docker build or is there another way?


Pass factory, client & assets directly in arguments

Currently, there are a few lines at the beginning of each test which allows to get the following variables:
• factory - used for the create_asset methods
• initial_assets - initial assets used in the test
• network - used to get the client(s)
They are set using this line:
factory, initial_assets, network = global_execution_env

The goal of this PR would be to pass directly these variable into the test, instead of getting them into. It avoids duplicated code and makes it easier to read.

@maeldebon did you mean to create this PR as draft or WIP ? The goal of the PR is very well defined but the code doesn't match.

@maeldebon did you mean to create this PR as draft or WIP ? The goal of the PR is very well defined but the code doesn't match.

Sorry, I could have created a draft instead. We are just trying this to possibly implement it later 🙂

Thanks @maeldebon. I think it's a good idea to split the global_execution_env fixture into fixtures doing/returning one thing.


No module named 'pkg_resources' when using pipx

I ran pipx install ytdl-nfo, output:
  installed package ytdl-nfo 0.3.0, installed using Python 3.12.3
  These apps are now globally available
    - ytdl-nfo
done! ✨ 🌟 ✨

Then I ran ytdl-nfo, but I get an error:
Traceback (most recent call last):
  File "/home/simao/.local/bin/ytdl-nfo", line 5, in <module>
    from ytdl_nfo import main
  File "/home/simao/.local/share/pipx/venvs/ytdl-nfo/lib/python3.12/site-packages/ytdl_nfo/__init__.py", line 4, in <module>
    from .Ytdl_nfo import Ytdl_nfo
  File "/home/simao/.local/share/pipx/venvs/ytdl-nfo/lib/python3.12/site-packages/ytdl_nfo/Ytdl_nfo.py", line 3, in <module>
    from .nfo import get_config
  File "/home/simao/.local/share/pipx/venvs/ytdl-nfo/lib/python3.12/site-packages/ytdl_nfo/nfo.py", line 5, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

Python version: Python 3.12.3
OS: Arch Linux x86_64
Kernel: Linux 6.9.4-nitrous-1
Shell: zsh 5.9
CPU: AMD Ryzen 9 3900X (24) @ 4.67 GHz
Locale: en_US.UTF-8

It looks as though this may be an issue with your Python environment, rather than with ytdl-nfo.

This error message is caused by a missing/broken Python setuptools package.

https://stackoverflow.com/questions/7446187/no-module-named-pkg-resources

Did you manage to resolve this? I'm also on Arch Linux and getting the same error, but installing the setuptools package doesn't seem to help (I've tried both through the Arch repositories and through pipx).

Did you manage to resolve this? I'm also on Arch Linux and getting the same error, but installing the setuptools package doesn't seem to help (I've tried both through the Arch repositories and through pipx).

Unfortunately, I have not. Setuptools is installed:
$ pacman -Q python-setuptools
python-setuptools 1:69.0.3-6

I installed ytdl-nfo using pipx.

gh-95299: Do not pre-install setuptools in virtual environments created with venv. This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the activated virtual environment.

https://docs.python.org/3/whatsnew/3.12.html
It is deprecated in 3.12. You may try to manually inject setuptools in the pipx env or you should use a lower python version.
For ytdl-nfo to work with python 3.12 natively, the dependency setuptools must be added to poetry.

@Morikko Thank you for suggesting that fix!
I made the change here:
https://github.com/owdevel/ytdl-nfo/pull/31
https://github.com/pineapplemachine/ytdl-nfo/tree/fix-poetry-2024-07-08
I don't have a ton of time to update my own Python install and test locally at the moment, but if someone were to follow the "Package from source" instructions in the repo's readme with that branch pulled, hopefully the issue will be resolved? (Please report back, if you do)

I encountered this bug, didn't think to check the Issues page, independently arrived at the same solution, and can confirm installing setuptools fixes the issue.


server:watch doesn't do anything

Summary
server watch isn't responding to changes in the source
Steps To Reproduce:

create with ts, and custom express server
yarn watch:server (compiles, starts server as expected)
modify src/server/index.ts

Expected result
server compiles/reloads
Actual result
no compile/reload

Please check with latest beta. Still iterating on some of the mechanics (choosing between nodemon vs. webpack).


Cannot generate payload in winpayloads folder.

Main Menu > 2
[] Press Enter For Default Port(4444)
[] Port>
[] Press Enter To Get Local Ip Automatically(<IP_ADDRESS>)
[] IP>
[] IP SET AS <IP_ADDRESS>
[] PORT SET AS 4444
y*] Try UAC Bypass(Only Works For Local Admin Account)? y/[n]:
[] Windows 7 or 10? 7/[10]:7
[] Creating Payload using Pyinstaller...
Mv: unable to get 'dist / payload.exe' file status (stat): no that file or directory
[*] Payload.exe Has Been Generated And Is Located Here: /root/winpayloads/Windows_Meterpreter_Reverse_Shell.exe
Rm: can not delete 'dist': no that file or directory
Rm: can not delete 'build': no that file or directory
Rm: can not delete ' .spec': no that file or directory`
[*] Upload To Local Websever or (p)sexec? [y]/p/n: n
And its turning on msfconsole. After this I am going to winpayloads folder and its empty. Some days ago its was working but I have to reinstall kali and now its not working. Please help! I was reinstalling this about 5 times and Its still not working. I was looking on another issues and its still not working. I have the newest one version of kali.

Guys! I know how to make generating payloads here! First you have to go to your folder where you are starting the WinPayloads, and you have to open terminal here. After this type chmod 777 WinPayloads.py and after this you can type ./WinPayloads.py


Clean up linear solvers, add StencilDiagonalMatrix and diagonal(), require pc to be LinearOperator

Reduce code duplication in the linear solvers by adding the method __init__ to the common base class InverseLinearOperator. Add new class StencilDiagonalMatrix to be used in combination with the new method diagonal of StencilMatrix and BlockLinearOperator. Require all preconditioners to be LinearOperator objects -- this fixes #343.
Detailed list of changes
All solvers are sub-classes of InverseLinearOperator. As such, they now call now super().__init__ which takes the base arguments for any iterative solver. The methods _check_options and transpose are also moved to the base class. Additional arguments must be checked in the individual solvers.
The base class now has the setter method for linop, which allows to change the matrix A of the solver.
Moreover, changed the handling of preconditioners in InverseLinearOperators. The option pc must now take as value a LinearOperator, which is the preconditioner. If pc=None, an IdentityOperator of the domain space is created automatically.
The new class StencilDiagonalMatrix has been added. This represents a linear operator acting between two StencilVectorSpaces, and which corresponds to a diagonal matrix. This linear operator is completely local.
The method diagonal has been added to the classes StencilDiagonalMatrix and BlockLinearOperator (for which it returns an object of the same class), and to the class StencilMatrix (for which it returns a StencilDiagonalMatrix object). As well as an out optional argument, this method accepts the inverse boolean flag which is useful for creating a Jacobi preconditioner.
The new solver PBiConjugateGradientStabilized (preconditioned BiCGSTAB) has been added from Struphy (does not work for complex).
test_solvers.py has been updated, as well as several API unit tests.
Notes
When passing a preconditioner to DiscreteEquation.set_solver(), this also has to be a LinearOperator now. This means that in the case of a Jacobi preconditioner one needs first to assemble the linear system, then extract its diagonal, and finally pass the new LinearOperator as the pc solver option.

The pc flag can only be passed when the solver is either 'pcg' or 'pbicgstab', otherwise it returns an error.
In the case of solvers like GMRES, we could easily pass a (left) preconditioner P, and then instead of solving A x = b, we solve P @ A x = P.dot(b) with a ComposedLinearOperator.

The pc flag can only be passed when the solver is either 'pcg' or 'pbicgstab', otherwise it returns an error.
In the case of solvers like GMRES, we could easily pass a (left) preconditioner P, and then instead of solving A x = b, we solve P @ A x = P.dot(b) with a ComposedLinearOperator.

AFAIK this was the original behavior prior to this PR. I suggest to defer any further improvements or fixes to a future PR. Please feel free to open new issues.


[NEW] Add CypherCon

Name: CypherCon
Website: cyphercon.com
Date(s): Mar 30-31, 2023
Location: Milwaukee, WI  United States
Twitter Handle:  @cyphercon
Free: N

Thanks! Added.


Terraform workspace support

I am looking to have a pipeline  which selects a Terraform workspace, similar like the instructions below.
- task: TerraformTaskV1@0
        displayName: 'apply terraform'
        inputs:
          provider: 'azurerm'
          command: 'apply'
          workspace: <SELECTED_WORKSPACE>
          customCommand: 'workspace'
          commandOptions: '-input=false -var-file="$(System.DefaultWorkingDirectory)/infrastructure/azure/vars/default.tfvars"'
          environmentServiceNameAzureRM: '${{ variables.backendServiceArm }}'
          workingDirectory: '$(System.DefaultWorkingDirectory)/infrastructure/azure'

Could this functionality please be added to the terraform extension.

Hi, I  will take a look and provide an example how to work with workspaces.

That would be great!

Hi, I think you need to select the workspace first and then do apply. Perhaps something like this:
- task: TerraformTaskV3@3
        displayName: 'select workspace'
        inputs:
          provider: 'azurerm'
          command: 'custom'
          customCommand: 'workspace'
          commandOptions: 'select <SELECTED_WORKSPACE>'
          outputTo: 'console'
          environmentServiceNameAzureRM: '${{ variables.backendServiceArm }}'
          workingDirectory: '$(System.DefaultWorkingDirectory)/infrastructure/azure'

- task: TerraformTaskV3@3
        displayName: 'apply terraform'
        inputs:
          provider: 'azurerm'
          command: 'apply'
          commandOptions: '-input=false -var-file="$(System.DefaultWorkingDirectory)/infrastructure/azure/vars/default.tfvars"'
          environmentServiceNameAzureRM: '${{ variables.backendServiceArm }}'
          workingDirectory: '$(System.DefaultWorkingDirectory)/infrastructure/azure'

I have been using the TF_WORKSPACE variable as a workaround.
- task: TerraformTaskV3@3
        displayName: 'apply terraform'
        env:
          TF_WORKSPACE: <WORKSPACE>
        inputs:
          provider: 'azurerm'
          command: 'apply'
          commandOptions: '-input=false -var-file="$(System.DefaultWorkingDirectory)/infrastructure/azure/vars/default.tfvars"'
          environmentServiceNameAzureRM: '${{ variables.backendServiceArm }}'
          workingDirectory: '$(System.DefaultWorkingDirectory)/infrastructure/azure'

closing this. (inactive)


Add a license

Currently, this library has no explicit license, resulting in a strong copyright.
As you're welcoming contributions in the README, I suspect this to be an oversight.
You can check https://choosealicense.com/ for a simple overview over some free licenses.
Personally, I prefer using the MIT or Apache 2.0 licenses, but the final choice is up to you (and probably partially me because I contributed without noticing it and therefore probably have copyright on my stuff ^^ - but I'll go with any free license).

Okay, I changed the license to the Unlicense License because public domain is cool.


Use factories in cucumber features

@roschaefer I can`t run the tests locally anymore as it states that there is an authentication error with Neo4j. Any idea?

@appinteractive what exactly raises the authentication error? The factories or the UI? This PR is not yet finished, I forgot to add [WIP].


Letters after numbers in body names used as abbreviations for weights & measures in certain voices

Hi Cmdr McDonald,
I'm not sure if this is something you can 'fix', as it seems to depend on the voice used.
I've just been doing some exploring and came across this quirk in the speech output.  For planet designations ending in a G like 'PRO EURL IX-L D7-24 2 G' the speech is saying the G as 'grams'.
I've tried this with 'Ivona Amy' and 'MS Zira Desktop' voices and both say it as grams.  However, when I tried MS Hazel and MS David, they both say it correctly as G.
I'm not sure if you want to bother with something so small, particularly when it depends on the voice used, but I thought I'd report it anyway.
Thanks for your continued development of EDDI, and I can't wait to try the new version! :)
Kind regards,
Darkcyde.
EDIT:
I've also noticed that bodies (stars & planets) also sometimes say 'A' as 'uh' rather than 'ayy' when the A is at the end, like the G above.
...and I just scanned 'PRO EURL IX-L D7-24 2 H' and it said the H as 'hours'! :(

I've tested all the letters of the alphabet now.  With the two voices mentioned, when certain letters are spoken after a number, words are used instead. e.g. "11 t" is 'eleven tonnes'.  The following letters are used as these abbreviations:-
G = grams
H = hours
L = litres
M = meters
T = tonnes
Y = years

I've fixed this now.  I'm passing all instances of body and star names to a new function which corrects the spoken last letter so that the weights & measures are no longer said.
However, if you still choose to correct this internally, that would be great too. :)  I'll leave this open for a day or two in case you wish to mark it as a bug to be fixed.

How are you altering the letter?  It's something that I could add to EDDI, but there are a lot of similar items out there and it's quite voice-dependent (I can't tell a voice not to interpret the text so would have to hard-code each situation).

This is the function I quickly threw together.  You may be able to make it more efficient.  In the four events that call this (Body/Star Scanned and Body/Star Report), where the name was being said, I simply replaced it with a call to this function.
{_ BodyName}
{_ letters said as words after numbers}

{if reportbody.name:
   {set idx to len(reportbody.name)-2}
   {set chk to slice(reportbody.name, idx, 2)}
   {set part to slice(reportbody.name, 0, (idx))}
|elif event.name:
   {set idx to len(event.name)-2}
   {set chk to slice(event.name, idx, 2)}
   {set part to slice(event.name, 0, (idx))}
}

{if chk = " a" || chk = " A":
    {set chk to " ay"}
|elif chk = " g" || chk = " G":
    {set chk to " gee"}
|elif chk = " h" || chk = " H":
    {set chk to " aitch"}
|elif chk = " l" || chk = " L":
    {set chk to " elle"}
|elif chk = " m" || chk = " M":
    {set chk to " emm"}
|elif chk = " t" || chk = " T":
    {set chk to " tee"}
|elif chk = " y" || chk = " Y":
    {set chk to " why"}
|else:
    {set chk to ""}
}

{if chk = "":
   {P(reportbody.name)}
   {P(event.name)}
|else:
   {P(cat(part,chk))}
}

First I find the length of the body/star name and minus two from it.  This gives me the index I need to get the last two characters, and a total length of the part I need to keep.  I then check these to see if they match any of the letters that are spoken as weights & measures.  The space as a first character is important so I don't get every name that ends with one, only names that end with a separate letter.
If a match is found, convert it to a spoken version of the letter. I do understand that this can be a bit of a dirty conversion as it will depend on the voice used, but it will still be better than a totally wrong word (for me anyway).  If no match is found, then the raw name will be spoken, otherwise I put the original first half plus the new converted half together to be spoken.
I've tried this with the three default windows 10 voices (Hazel, David & Zira) and Ivona Amy (which is my primary voice).  Only Amy and Zira seem to use the letters as abbreviations.  Of course, this 'fix' is tuned to Amy, but all voices seem to be ok with my spellings, apart from the one for 'A'.  The three Win10 voices do have a hard time with that one.
I used this in a new script to test with:-
1 a .
ay.

1 g .
gee.

1 h .
aitch.

1 l .
elle.

1 m .
emm.

1 t .
tee.

1 y .
why.

I should also note that in my Body/Star Scanned events, I've set a state variable that I use to prevent the body/star names being spoken when the respective reports are called from them.  It was getting tedious hearing the long names of sectors being read out twice in quick succession.
This is why I've got both the reportbody.name and event.name in the same place as in my scripts, only one will ever be used at any one time.  If used from the default scripts, I believe they would both be spoken when a body is scanned.

The 'enable ICAO' option in EDDI 2.3 beta 2 should allow these letters to be pronounced phoentically.


re-run ID api call fix

Current state:
front end sends a parameter that alters the match set when a user re-runs ID from the sighting page; it needs to be removed
Desired state:
no change in user experience
https://github.com/WildMeOrg/codex-frontend/blob/develop/src/pages/sighting/identification/buildMatchingSetQuery.js#L62-L65 is no longer sent while generating a match set
Can this change be verified in the UI? No, but it can be verified in postman/console
api should respond with 200 (verifying json was valid) and (eventually) id job should finish.
QA:

Verify the parameter is not sent
Verify a 200 response
Verify ID job finishes

Investigation notes
in the frontend ui for re-run identification (sighting page), some json data is created to send to the backend api.  part of this json will be an element like "must_not": {"match": {"encounter_guid": "_MACRO_annotation_encounter_guid "}}} — this should be removed so that it is no longer sent to the backend.

this was fixed in frontend by this PR.  (payload also confirmed correct on QA)


Update aws-java-sdk-bundle to 1.12.518

About this PR
📦 Updates com.amazonaws:aws-java-sdk-bundle from 1.12.510 to 1.12.518
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #2819.


add flag to optionally generate structured output

To use earthmover in an automated data pipeline it would be useful to have it generate structured output noting how many rows it processed for each destination, the run timestamp, and possibly other information. Open questions include:

what should the flag be? perhaps --results-file output.json
what should the output format be? (YAML, JSON, something else?)
besides the items noted above, what else should be included in the results

Tagging @jayckaiser for thoughts.

Based on our conversation today, I'm proposing that

earthmover's structured output is enabled with a cli flag --results-file ./results.json
output format is JSON, like this:{
  "timestamp": "2023-05-15 02:03:11Z00",
  "output_dir": "/path/to/some/dir/",
  "row_counts": {
    "$sources.enrollments": 120,
    "$transformations.enrollments_cleaned": 117,
    "$transformations.enrollments_deduplicated": 100,
    "$destinations.studentSchoolAssociations": 100
  }
}

where only nodes defined with structured_output: True are included in row_counts, and the value is the number of rows in the dataframe after it has been processed - so for sources, after they're loaded; for transformations, after their operation(s) have been run; for destinations, the size of the source dataframe.

We also discussed the exit codes earthmover should return in different circumstances, to trigger the AirFlow BashOperator task to raise an AirflowSkipException or AirflowException (per the Airflow docs). Is it correct that

if earthmover skips running because no input hashes have changed since the last run, should it return exit code 99? (so the Airflow task skips)
if any earthmover source fails a defined expectation should return exit code 1? (so the Airflow task fails)

A couple thoughts:

We may want to rename timestamp to started_at or completed_at or something of that nature. timestamp is already too prolific in the namespace.
I agree that having a built-in exit-code skip return is a good idea. We can also define our own skip_exit_code in the operator to use a different one. I'll want to make sure the exit-code returned is generic and not solely designed around Airflow specifications. Exit code 99 means Cannot assign requested address, which may be confusing to those using Earthmover outside of Airflow. Alternatives may be 17 (File exists) or 42 (No message of desired type), but I'm open to suggestions or pushback.
I think it would be worthwhile to track total run-time of the script. We could include a field runtime_sec or something similar to display this.
Other potentially-interesting information: the number of sources, transformations, and destinations run; the command used to trigger the run.

Closing this issue as it was implemented in this PR.


Expose checkpoint option and save/restore renders in cli

[x] Correctly write buffer weights in the checkpoint EXR
[x] Correctly load weights from the checkpoint
[x] Correctly save filtered AOVs
[x] Correctly save un-filtered AOVs
[x] Correctly load filtered AOVs
[x] Correctly load un-filtered AOVs
[x] Allow only .exr files for checkpoints
[x] Add custom message when a checkpoint is invalid
[x] Compatibility: Check for layer count
[x] Color AOVs: don't recreate the same image multiple times
[x] Support for denoiser AOV
[x] Refactor diagnostic AOVs and pixel_time AOV
[x] close #2127
[x] Reading: use a map containing for each subimage the layer name
[x] Remove filter and keep only last samples in Unfiltered AOVs ?
[x] Factorize all the padding bbox creation snippets
[x] Fix overlap bug in AOVs (don't use crop window because pixels aren't rendered outside of it)
[x] After render finished, rename previously created checkpoint file to not override it
[x] Restore and save from the frame

Future Work

Expose option in studio
Save denoiser checkpoint in the same exr file
Allow to resume progressive rendering

Will need to be rebased.

@est77 Could you review the AOV part of this PR please?

Thanks for the review @dictoon, really appreciated.


Install Code Review Doctor

I think we can use Code Review Doctor to check common mistakes automatically.
https://codereviewdoctor.medium.com/5-of-666-python-repos-had-comma-typos-including-tensorflow-and-pytorch-sentry-and-v8-7bc3ad9a1bb7

Good to know! Would it be better to add to README and MR? BTW, we have 9 issues https://codereview.doctor/line/centraldogma-python

:wave: you can add me via [GitHub marketplace(https://github.com/marketplace/django-doctor/) so your PRs are checked for the issues I look out for :)

@ikhoon @minwoox @syleeeee
It costs $49 per a month for organizations. 😅 As LINE have a few of repositories written in Python, adopting it could be useful if the organization don't mind to pay. However, if not, I want to close this issue. Please tell their opinions.

A small number of pull requests are made in this repo, so I don't think we really need it.

A small number of pull requests are made in this repo

p.s. That I said "As LINE have a few of repositories written in Python" is about their pricing. $49 up to 10 repositories.


Authentication

Authentication/authorization backends belong in haas/auth_mechanisms .  It's
possible that the API of that plugin will have to be expanded to cover what
the CLI needs to do.
WIP

This was excellent work, @gsilvis.
Given the new driver interface as well as the new plugin model, though, I think it would require a bit of refactoring and so I'm closing this out.
Perhaps @zenhack can use some of this as a basis for his work in #491.


Unknown CMake command "AW_CHECK_CUDA".

ase
Starting >>> lidar_point_pillars
--- stderr: lidar_point_pillars
CMake Error at CMakeLists.txt:9 (AW_CHECK_CUDA):
Unknown CMake command "AW_CHECK_CUDA".

Failed   <<< lidar_point_pillars [0.13s, exited with code 1]
Summary: 0 packages finished [0.45s]
1 package failed: lidar_point_pillars
1 package had stderr output: lidar_point_pillars

Hi Dysonsun,
It seems like that you do not have the Autoware Build Flags package inside your workspace. The cmake macro AW_CHECK_CUDA is defined there:
https://github.com/Autoware-AI/common/blob/master/autoware_build_flags/cmake/autoware_build_flags-extras.cmake
So make sure to add this package (and all required packages from the repos in build_depends.repos) to your workspace.


Chai "should" assertions incompatible with Jest.

🐛 Bug Report
Hey Jesters! I was recently attempting to integrate Chai's should assertion syntax into a Jest test suite, and discovered something a little odd. For some reason, tests that work fine in Mocha and in Jest with jest-mocha-runner crash in Jest, with errors indicating that the should methods are no longer defined at various points in the language chain.
I've seen the issue with built-in objects like URL...
● ProsceniumClient › initialization › creates a URL object for the server URL

  TypeError: Cannot read property 'be' of undefined

    13 |   describe('initialization', () => {
    14 |     it('creates a URL object for the server URL', () => {
  > 15 |       pc.serverURL.should.be.an.instanceof(URL)
       |                           ^
    16 |     })
    17 |
    18 |     it('creates a new IFrame', () => {

    at Object.it (spec/client/proscenium-client-spec.ts:15:27)

...as well as custom constructors...
● RPCDispatcher › initialization › stores a reference to the client

  TypeError: Cannot read property 'be' of undefined

    14 |   describe('initialization', () => {
    15 |     it('stores a reference to the client', () => {
  > 16 |       rpc.client.should.be.an.instanceof(ProsceniumClient)
       |                         ^
    17 |     })
    18 |   })
    19 |

    at Object.it (spec/client/rpc/rpc-dispatcher-spec.ts:16:25)

...and objects from libraries like JSDOM...
● IFrame › #initialize › is ignored by screen readers

  TypeError: Cannot read property 'have' of undefined

    45 |
    46 |     it('is ignored by screen readers', () => {
  > 47 |       document.body.querySelector('iframe')
       |       ^
    48 |         .should.have.attribute('aria-hidden')
    49 |         .that.equals('true')
    50 |     })

    at Object.it (spec/client/dom/iframe-spec.ts:47:7)

...but it doesn't affect all should assertions---some work just fine, and I haven't figured out the pattern yet.
should works by manipulating Object.prototype, so it seems likely to me that Jest's environment is making that difficult or unpredictable. However, I don't know Jest's internals well enough to guess what the conflict might be, and I was hoping you might have some insight.
Thanks in advance for any thoughts you have! Let me know if I can provide any more color.
To Reproduce
Steps to reproduce the behavior:

Register Chai's should helpers on the global object by importing chai/register-should or calling chai.should().
Attempt to make an assertion with Chai's fluent language chains.
:boom:

Expected behavior
I would expect that the Object.prototype.should global would remain defined through the entire test suite and allow chaining of its methods, as it does in the Mocha and jest-mocha-runner environments.
Link to repl or repo (highly encouraged)
https://github.com/phyllisstein/expect-should-repro-repo
Run npx envinfo --preset jest
System:
  OS: macOS 10.14
  CPU: x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Binaries:
  Node: 10.4.1 - /usr/local/bin/node
  Yarn: 1.7.0 - /usr/local/bin/yarn
  npm: 6.1.0 - /usr/local/bin/npm
npmPackages:
  @types/jest: ^23.0.2 => 23.0.2
  jest: ^23.1.0 => 23.1.0

N.B. also that I flagged this with the Chai maintainers and they suggested that I take my whinge to you folks. Q.v. https://github.com/chaijs/chai/issues/1165.

I haven't checked, but I'd guess this is due to #2549

Oh wow, thank you so much for weighing in @SimenB! In the course of getting up to speed on the details of #2549, I wound up checking to see what would happen if I moved the environment bootstrapping code from a setupTestFrameworkScriptFile script to a custom environment:
// spec/_should-environment.js

const browserEnv = require('browser-env')
const chai = require('chai')
const chaiDOM = require('chai-dom')
const JSDOMEnvironment = require('jest-environment-jsdom')

class ShouldEnvironment extends JSDOMEnvironment {
  async setup() {
    await super.setup()
    browserEnv()
    chai.use(chaiDOM)
    this.global.should = chai.should()
  }
}

module.exports = ShouldEnvironment

After pointing Jest's testEnvironment option to this file and removing the setupTestFrameworkScriptFile, all my should assertions worked beautifully. (For whatever reason, it was still necessary to import chai/register-should in setupFiles.) Here's the complete changeset: https://github.com/phyllisstein/expect-should-repro-repo/commit/8571f66e7f82624eba6fcabf258fbddd52f5b0e1.
This resolves a greasy headache of long standing and frees me once and for all from Jasmine's clunky assertion style. Thank you for pointing me in the right direction.


frameit the frame name wrong

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
when i download the frame from apple, the name is wrong.
Complete output when running fastlane, including the stack trace and command used
[10:04:28]: You can download new templates from 'https://developer.apple.com/app-store/marketing/guidelines/#images'
[10:04:28]: and store them in '/xxxxxx/.frameit/devices_frames'
[10:04:28]: Missing file: 'iPhone-6s-Plus-Space-Gray-vertical.png'

and download name is iPhone_6_Plus_Vert_SpaceGray_sRGB_0914.psd, how can i know the names?
Environment
fastlane version (run fastlane -v):
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?

I had a similar issue with the iPad Pro silver having a wrong name.
You can fix it by renaming the file you downloaded off Apples website to the one required - In your example that would be:
Rename: iPhone_6_Plus_Vert_SpaceGray_sRGB_0914.psd   to   iPhone-6s-Plus-Space-Gray-vertical.psd (and put it in ~/.frameit/devices_frames )
When you run frameit, it converts the psd to png.
It might be that the offset and width is wrong because of the new file, but you can adjust this in:
/Library/Ruby/Gems/2.0.0/gems/frameit-2.7.0/lib/frameit/offsets.rb - Might need sudo to change the values.
I hope this helps.

@cratrifork Thanks for help

@cratrifork Thanks so much for stepping in on this and helping out. Hope that you have a great day! 👍

I'm actively working on a re-write of frameit that supports all the latest devices with https://github.com/fastlane/fastlane/pull/6597, please subscribe to the pull request to stay up to date. We hope to have a new version ready this week  🚀


C# Performance

Goal
Increase performance of the Csharp builds with minimal impact to original algorithm design.

[x] Inline methods for performance.
[ ] Utilize dotnet methodology for readonly struct
[ ] Review options for internally reusing Lists or direct array assignment.

Results.
BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19044
Intel Core i7-10700 CPU 2.90GHz, 1 CPU, 16 logical and 8 physical cores
.NET Core SDK=6.0.201
  [Host]     : .NET Core 5.0.15 (CoreCLR 5.0.1522.11506, CoreFX 5.0.1522.11506), X64 RyuJIT
  DefaultJob : .NET Core 5.0.15 (CoreCLR 5.0.1522.11506, CoreFX 5.0.1522.11506), X64 RyuJIT

Baseline 96f3cc5be10c5e194b1fbce530ea17252e214451

Method
Mean
Error
StdDev
Gen 0
Gen 1
Gen 2
Allocated

Union_Null_Clip_EvenOdd
1.949 μs
0.0569 μs
0.0031 μs
0.4997
0.0038
-
4.1 KB

Union_Null_Clip_NonZero
1.622 μs
0.1272 μs
0.0070 μs
0.4234
0.0019
-
3.46 KB

Union_Clip_NonZero
3.635 μs
0.1214 μs
0.0067 μs
0.7362
0.0076
-
6.02 KB

Intersect_Clip_NonZero
3.425 μs
0.2235 μs
0.0123 μs
0.6981
0.0076
-
5.71 KB

Intersect_Clip_EvenOdd
3.758 μs
0.1699 μs
0.0093 μs
0.7668
-
-
6.27 KB

InflatePaths_Delta5
1.691 μs
0.1571 μs
0.0086 μs
0.5093
0.0038
-
4.16 KB

InflatePaths_DeltaMinus5
4.234 μs
0.4420 μs
0.0242 μs
0.9995
0.0076
-
8.18 KB

InflatePaths_Delta10
5.100 μs
0.1322 μs
0.0072 μs
1.1597
0.0153
-
9.51 KB

InflatePaths_DeltaMinus10
6.292 μs
0.1274 μs
0.0070 μs
1.3199
0.0229
-
10.8 KB

Inlined methods a48fd27f3546720b43310f9e4c1b7667be6c4f2c

Diff
Method
Mean
Error
Gen 0
Gen 1
Allocated

Old
Union_Null_Clip_EvenOdd
1.809 μs
0.0101 μs
0.4997
0.0038
4.1 KB

New

1.703 μs (-6%)
0.0129 μs
0.5016 (0%)
0.0057 (+50%)
4.1 KB (0%)

Old
Union_Null_Clip_NonZero
1.697 μs
0.0227 μs
0.4234
0.0019
3.46 KB

New

1.558 μs (-8%)
0.0190 μs
0.4234 (0%)
0.0019 (0%)
3.46 KB (0%)

Old
Union_Clip_NonZero
3.665 μs
0.0068 μs
0.7362
0.0076
6.02 KB

New

3.347 μs (-9%)
0.0258 μs
0.7362 (0%)
0.0076 (0%)
6.02 KB (0%)

Old
Intersect_Clip_NonZero
3.457 μs
0.0166 μs
0.6981
0.0076
5.71 KB

New

3.205 μs (-7%)
0.0245 μs
0.6981 (0%)
0.0076 (0%)
5.71 KB (0%)

Old
Intersect_Clip_EvenOdd
3.792 μs
0.0233 μs
0.7629
0.0000
6.27 KB

New

3.494 μs (-8%)
0.0244 μs
0.7668 (+1%)
0.0000
6.27 KB (0%)

Old
InflatePaths_Delta5
1.713 μs
0.0126 μs
0.5093
0.0038
4.16 KB

New

1.593 μs (-7%)
0.0064 μs
0.5093 (0%)
0.0038 (0%)
4.16 KB (0%)

Old
InflatePaths_DeltaMinus5
4.241 μs
0.0236 μs
0.9995
0.0076
8.18 KB

New

3.832 μs (-10%)
0.0312 μs
0.9995 (0%)
0.0114 (+50%)
8.18 KB (0%)

Old
InflatePaths_Delta10
5.045 μs
0.0651 μs
1.1597
0.0153
9.51 KB

New

4.678 μs (-7%)
0.0228 μs
1.1597 (0%)
0.0153 (0%)
9.51 KB (0%)

Old
InflatePaths_DeltaMinus10
6.517 μs
0.0747 μs
1.3199
0.0229
10.8 KB

New

5.858 μs (-10%)
0.0447 μs
1.3199 (0%)
0.0229 (0%)
10.8 KB (0%)

Could you add some detail about the observed performance gain from this change? It would make the PR more immediately informative :)

How opposed would you be to making the C# code consistent between the different clipper CS files?
Clipper.Core.cs, Clipper.Offset.cs and Clipper.cs uses two spaces while Clipper.Engine.cs uses mostly tabs with some spaces mixed in.
Can I make these consistent between each of the source files?  Tabs or spaces don't matter much to me.  The dotnet community has mostly centered around spaces, but any good IDE worth its salt will work just fine either way.   The mixture just becomes irritating sometimes and this seems like a good time to address it.

Could you add some detail about the observed performance gain from this change?

My admittedly brief testing has shown and performance improvement.
Still, I don't want to discourage anyone trying 😁.

Could you add some detail about the observed performance gain from this change?

My admittedly brief testing has shown any performance improvement. Still, I don't want to discourage anyone trying 😁.

That was really to DJGosnell - just to flesh out the PR, which he then did :)


[BUG] Android - Could not invoke RNUsercentricsModule.getConsents

Describe the bug
Exiting the app by using the Android hardware back button sometimes causes a native crash on the next app launch. We show the First Layer on app start and from our observations the crash occurs more likely if we exit the app as fast as possible.
To Reproduce
Steps to reproduce the behavior:

Open the app
Wait for the First Layer
Close the First Layer using the hardware back button
Close the app using the hardware back button
Open the app again
See error

Expected behavior
App shouldn't crash on start.
Screenshots

react-native info

Tested on:

Emulator (SDK 29)
Redmi Note 8 Pro (Android 10)
react-native: 0.67.4
@usercentrics/react-native-sdk: 2.7.10

Note
It seems to be harder to crash the app using the default settings id: Yi9N3aXia. I guess it might have something to do with the size of those returned services and consents arrays - We have now 87 services and 87 consents and a large amount of text and data inside. This is a significant difference in comparison to the default 4 services and 4 consents 😉

Hi @mkierat,
we tried to reproduce the issue but did not manage. Do you think you could provide us with your settingsId for testing (you can maybe email it to rui dot reis at usercentrics dot com)?
If you wish you can also use the SDK to disable the back button by defining the property disableSystemBackButton of the generalStyleSettings.
Cheers,
Rui

Thanks Rui!
disableSystemBackButton doesn't help unfortunately - looks like the issue isn't directly related to the First Layer.
However, I made a minimal repro code in a fresh React Native installation. Just install the Usercentrics npm package and paste the code to App.tsx:
https://goonlinetools.com/snapshot/code/#77kwkd10mnipmqmmdc78x
It should be easier to reproduce the issue with our SettingsID - I just sent it to you via e-mail @userCTest
Just close the app using the hardware back button and open again until you get the result.
Note: Sometimes the app also crashes without any error (force closes and Android asks to report an issue) - it can also have something to do with EXC_BAD_ACCESS exceptions which we get sometimes in our Sentry logs - maybe it's related.

Hey Marcin,
I tried again to replicate the issue with your code (created a repo that you can check out where I used your code and where I enable the disableBackButton property for you to test this property). Putting disableBackButton to false I am unable to replicate the issue (even with your settingsId).
Could you please have a look at the code in the repo and see if you can still reproduce the issue on your side?
Cheers,
Rui

Hey Rui,
Looks like the disableSystemBackButton: true solves the problem, I couldn't get any error or crash today using the latest 2.7.12 sdk version.
But when I set up the disableSystemBackButton: false:
I couldn't reproduce the issue by using your repo, but I could with the exact same code on my test repo (here: repo - maybe a RN version makes a difference).
However I'm able to reproduce a random app crash on both repos if disableSystemBackButton: false (the app force closes and asks if I wish to report the issue). It shows then a log:
  java.lang.AssertionError: Show Banner cannot be used from a finished/finishing Activity
	at com.usercentrics.sdk.ui.extensions.ContextExtensionsKt.safeShowBanner(ContextExtensions.kt:54)
	at com.usercentrics.sdk.UsercentricsBanner.doShowFirstLayer(UsercentricsBanner.kt:55)
	at com.usercentrics.sdk.UsercentricsBanner.showFirstLayer(UsercentricsBanner.kt:45)
	at com.usercentrics.reactnativeusercentrics.api.UsercentricsProxyImpl.showFirstLayer(UsercentricsProxy.kt:48)
	at com.usercentrics.reactnativeusercentrics.RNUsercentricsModule$showFirstLayer$1.invoke(RNUsercentricsModule.kt:40)
	at com.usercentrics.reactnativeusercentrics.RNUsercentricsModule$showFirstLayer$1.invoke(RNUsercentricsModule.kt:34)
	at com.usercentrics.reactnativeusercentrics.RNUsercentricsModule.runOnUiThread$lambda$0(RNUsercentricsModule.kt:201)
	at com.usercentrics.reactnativeusercentrics.RNUsercentricsModule.$r8$lambda$22O9ZH_jsa7et_13boPGdVoyiwM(Unknown Source:0)
	at com.usercentrics.reactnativeusercentrics.RNUsercentricsModule$$ExternalSyntheticLambda0.run(Unknown Source:2)
	at android.os.Handler.handleCallback(Handler.java:914)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:224)
	at android.app.ActivityThread.main(ActivityThread.java:7551)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:995)

Hey Marcin,
good the new repo kinda solves it. I just tried your repo and I can't see any crash, but maybe I am doing the wrong steps to replicate (using the initial steps you provided above). Using an emulator Pixel 4 API 29.
Can you provide me with the steps you are using to get the latest error?
Thanks,
Rui

Steps are quite simple:

open the app
close it by using the hardware back button
repeat

Try to do it as fast as possible.
It usually takes me less than 10 tries to cause a crash (mostly around the 3rd try)

Marcin, managed to replicate this. Will create an internal ticket to solve this.
Will keep you posted and thanks for the effort!

It kinda solves the problem or maybe it's just much harder to reproduce. It's better, but hard to say if the problem has gone completely.
Thanks Rui! I'll be waiting for an update ;)

Hello there! Any updates on this?

Hi Marcin,
sorry, we released a fix for this in the last release, 2.7.13.
Can you have a try and see if you find any issues?
Cheers,
Rui

Hey Marcin,
we corrected the issue with the error  java.lang.AssertionError: Show Banner cannot be used from a finished/finishing Activity, which indeed I am unable to replicate after the upgrade. Can you replicate that one? Or are still having the initial issue with getConsents? Which of those are you still seeing?
Cheers,
Rui

In the meantime did some (appium) automated testing using your test case and repo, using Android API 29 and 33 and never got an error, neither the Activity one nor the getConsents one.
Could you provide us more information/details on how you replicate the issue? Android API used, emulator/device (if device, details of device)?
So we can try to narrow down the issue

The app crash seems to be fixed, but I still have the initial getConsents issue if the back button is enabled. Steps to reproduce are still the same.
Reproduced on:

Android Emulator API 29 / 30
Real device: Redmi Note 8 Pro (Android 10)

Couldn't reproduce on:

Android Emulator API 31 / 33

From what I see the app behaves differently on these SDKs (the first layer doesn't show up on open after the app is closed by using the back button), so I think this is why I can't reproduce it there. But the issue seems to be valid on API 30 and older (or at least on 29 and 30).
Hopefully the video will help a bit (recorded on Redmi Note 8 Pro):
https://user-images.githubusercontent.com/45258735/224661442-09dccf3c-6819-4acd-b147-0f037a8f9de2.mp4

Hey Marcin,
Leo here, software engineer for Usercentrics.
We couldn't reproduce the issue either, so we ask if you can share the integration code with Usercentrics, because we think the problem may be there.
Thanks!

Hi Leo,
do you mean this code? test repo.
There should be all you need to run and reproduce the error and you can also see the integration code.

Thanks for the answer, can you give me access to the repo?

Sure, sorry I forgot to add you :)

Hey Marcin, sorry for the delay, I was on holidays and completely forgot to let you know 😓
would mind inviting me again to the repo and I'll take a look right away! thanks for your patience!

Hey Marcin,
Thanks for it!
I've taken a look into the sample project you sent me and I couldn't reproduce the issue again :/
What I could see it's that you may have the option "Don't keep activities" set to ON in your smartphone, right? Because if this option is off, when you press back twice (first to dismiss the banner and second to dismiss the app), after the app re-launch (from the home screen, for example), it will show the app without the banner (with the exact same previous status, the banner was dismissed with our 1st back button press).
Btw, I have a question: is this happening in production as well? Are you finding any logs on your crash-logging solution?
Thanks again!

Hey Leo, thanks for taking a look!
I have the option "Don't keep activities" set to OFF and I haven't enabled any specific dev options on my devices.
Regarding the production logs - I don't really know if it's related (I guess it might be one of many causes), but we see a lot of EXC_BAD_ACCESS crashes and the number of occurrences increased significantly after upgrading the Usercentrics 2.7.1 -> 2.7.12+.
Example from the last 14 days:

The logs really don't tell us a lot and debugging the EXC_BAD_ACCESS issue gave us a hard time already. We even downgraded the SDK for some time because of that, but now we are again up-to-date and have a lot of events in production.

Thanks Marcin!
Regarding the issue on Android, I'm trying to understand why the banner reappears after you open the app again. Since you have to press back twice and after the app re-launch (meaning going back to foreground) the banner won't reappear.
About the crash that you sent right now, it seems to be an issue not related to our SDK. Can you confirm if the app was in background when this crash happened?
If so, the best idea we have is that the OS is freeing memory and this killed the application by some fault probably caused by RN, why we say that? We did a small research and we saw a lot of open issues across the internet all relating to RN :/

Regarding the issue on Android, I'm trying to understand why the banner reappears after you open the app again. Since you have to press back twice and after the app re-launch (meaning going back to foreground) the banner won't reappear.

I think it's because to close the banner permanently a user should allow or deny consents using the layer buttons, right? So it's not the case if they tap the hardware back button, so the layer reappears.

About the crash that you sent right now, it seems to be an issue not related to our SDK. Can you confirm if the app was in background when this crash happened?

I can't confirm that from our logs, the crash might happen either in background or foreground. However we could reproduce it couple of times and it was always in foreground.
Worth to mention: the EXC_BAD_ACCESS occurs mostly on iOS (on Android we log some similar events, but less and a stable count per day), so it might not be related to the origin Android issue.

If so, the best idea we have is that the OS is freeing memory and this killed the application by some fault probably caused by RN, why we say that? We did a small research and we saw a lot of open issues across the internet all relating to RN :/

This might be true, but as I wrote before: "(...) we see a lot of EXC_BAD_ACCESS crashes and the number of occurrences increased significantly after upgrading the Usercentrics 2.7.1 -> 2.7.12+.". Maybe not directly, maybe due to some more memory expensive changes inside, but for us it looks like the update caused the crash count increase (clearly showed in the chart below).
Significantly means like from "stable" 0-5 per day to even 149 at the peak.

Hey @km4r ,
regarding the iOS issue, do you by any chance have a more detailed stack trace of the error you can provide us with?
Also, have you upgraded to the latest version 2.7.15?
Cheers,
Rui

Hey @userCTest,

Regarding Android, the https://github.com/Usercentrics/react-native-sdk/issues/65#issuecomment-1465824700 you posted was done with some automation tool, right? Meaning the actions are simply too fast for any user to be able to perform them in that sequence, no? Looking at the video this does not seem like a real use case, but just something you can get if you stretch the automation a bit too much?? Sorry if I'm wrong, but it does look like it :P

Not really, you see my job in the video :D I know how it looks like, but as a single user I could reproduce it only that way. But looking on our logs I can't really confirm that's the only way to crash the app. We just conservatively assume that for some devices it could be easier to crash than for others and it won't require then so fast actions and multiple tries like in the video :D And I know people tend to tap a button multiple times fast, especially buttons like: cancel, back, submit.

Regarding the iOS issue, do you by any chance have a more detailed stack trace of the error you can provide us with?

Unfortunately that's pretty much what we have. Besides of the info in the screenshot there are some build and device infos only.

Also, have you upgraded to the latest version 2.7.15?

The latest version we released in our app is 2.7.13, we haven't tried yet 2.7.15.

By the way Marcin, when testing on Android, are you using a bundled apk or are you running the project using metro server (run-android via cli or running on Android studio)?

Fast fast fingers! :P

What can I say, years of experience :P

By the way Marcin, when testing on Android, are you using a bundled apk or are you running the project using metro server (run-android via cli or running on Android studio)?

I tested it using metro server, with a bundled version I would probably experience just a crash and force close the app, but I didn't checked it like that to be honest. However I see in production logs that the issue exists (exact same error message like in the video), but then the app likely just crashes and force closes.

I seem to have been able to replicate it on a real device running API 30, but not quite as you said, Marcin. I see the error, not when clicking the back button, but when relaunching app/moving app to foreground after the double tap on the back button. Can you confirm this is what you see too?

Yes, exactly. The error appears when relaunching app - it also happens in the video. Sorry if my description was misleading.

Managed to replicate it, finally :D
Have created a ticket for the dev team with all details, but we will only be able to tackle it in upcoming sprints.
Now will try to have a look at the iOS issue, but that might be harder, the error being so non-descript... Anyway, will keep you updated.
Thanks for the help ;)
Cheers,
Rui

hey @km4r ,
Sorry for the late reply on this issue.
We did small changes on the native side that may help on this matter, I encourage you to upgrade to the latest version 2.8.0 to see if everything looks good.
Although I might add that the conditions to reproduce this issue are not trivial, especially regarding the Android condition that was previously mentioned (regarding how the banner should behave after the user dismiss it).
To reinforce the idea, the ideal behaviour is this one: after the user presses the back button to dismiss the banner, it will execute the function correctly, the banner will not be visible, by pressing it again it may occur that the app will move to background. After that, the OS will keep the process in background, if the conditions are favourable, so when the user re-launches the app, it will see the very same previous state as it was left.
In the case discussed here (and by the tests executed by @userCTest ), the app was being killed and forced to do a re-initialization, moving away from the ideal (and most common) scenario out there, in the real world. The device used by @userCTest was with this option where the OS kept killing the app, therefore causing Usercentrics to be re-initialized.
The normal behaviour is to have the app moved to background and re-launched with the previous state.
I believe this was issue found during development/testing mode, but if you have more insights about this crash in production, send us the evidence, please!
I'll be closing this issue, if you have any questions don't hesitate to ask us.
PS: regarding the iOS problem, I'll be creating another issue here and tagging you.


how to generate the crowd animation results

hello, how to generate the crowd animation results like the figure in the paper?

Hello,
You can generate multiple motions using the model and render the animations using Blender

Hello, You can generate multiple motions using the model and render the animations using Blender

thank you. i got it.


PIMOB-XXXX: Add Checkout UI Style by UX team

Figma URL
Unit test will be added after approving the PR to save time
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Frames Ios?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Unit test will be added after approving the PR to save time

Now Code is not dead, Please check open PRs


[SVE] [TC-ACL-2.10] Step 10 fails after DUT is rebooted

Reproduction steps
TC-ACL-2.10 fails step 10 after DUT is rebooted in step 9. It appears that this is because TH1 is still attempting to use the the previous CASE session and therefore fails.
If I remove the PICS_SDK_CI_ONLY from the following step in the YAML (the step immediately after the reboot, but before step 10), I can get the test to run successfully:
    - label: "TH1 Connects to the device again"
      PICS: PICS_SDK_CI_ONLY
      cluster: "DelayCommands"
      command: "WaitForCommissionee"
      arguments:
          values:
              - name: "nodeId"
                value: nodeId

I am testing with a Thread DUT.
Bug prevalence
Consistent
GitHub hash of the SDK that was being used
5ccb774e7e5fe7ead3ff85bec1cda31a459c9c37
Platform
raspi
Platform Version(s)
No response
Type
Test Improvement
Testing
YAML tested
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response

Yeah, I am not sure why that PICS_SDK_CI_ONLY is there.  @manjunath-grl please take a look?
Separately, it looks like a lot of that YAML is PICS_SDK_CI_ONLY including some things that probably shouldn't be.

@bzbarsky-apple Yes, for the above step PICS_SDK_CI_ONLY should not exist, we will fix it in the upcoming PR.
And for the rest of the steps using PICS  PICS_SDK_CI_ONLY added because of the issue [768] (https://github.com/ CHIP -Specifications/chip-certification-tool/issues/768), we made the prompt steps for all TH2 steps and for the sample app we made it as automated steps with PICS_SDK_CI_ONLY.

@jrhees-cae fixed in PR 29179 please verify it and close the ticket.

Verified


Bot doesn't work in public conversation

Why simple QnA Bot don't work in public chat or Team? I selected the Group chat and Team check box under the scope section.
1:1 bot working, but with conversation it doesn't. Why?

Сведения о документе
⚠ Не вносите правки в этот раздел. Это необходимо для связывания страницы сайта docs.microsoft.com с вопросом на GitHub.

ID: c1257b9b-73ca-8a97-3f65-a7c8d5937e8c
Version Independent ID: 5f9b5fad-dceb-3f9e-192c-a31ca05e0b83
Content: Добавление ботов для приватных чатов и каналов в Microsoft Teams
Content Source: Teams/add-bots.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@Morgannik8 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@officedocsbot close


TEP-0121: Adds a new field Retries for TaskRun

Changes
This PR adds a new field Retries for v1 and v1beta1 TaskRun, which enables TaskRun reconciler implements the Retries independently from PipelineRun reconciler.
This PR also adds a new member function IsRetriable for TaskRun to indicate whether taskRun.Retries has been exhausted or not.
issue: #5756
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] ~Release notes contains the string "action required" if the change requires additional action from users switching to the new release~

Release Notes
API change: new `Retries` field in `v1beta1.TaskRun` and `v1.TaskRun`.

This PR is the first peice of https://github.com/tektoncd/pipeline/pull/5842 adding API changes, will open another PR for adding the reconciler logic. We targeting at getting both in before cutting the release.

/lgtm


Add matomo again

Legal issues are cleared up.
Changed the info-text according to our lawyer
closes #339

You are checking if the environment variable is set
process.env.VUE_APP_ENABLE_STATISTICS === "true" ||
process.env.VUE_APP_ENABLE_STATISTICS === "True" ||
process.env.VUE_APP_ENABLE_STATISTICS === "1"

But you doesn't set any variable in the environment files? Is that right?

@theErikss0n You are checking if the environment variable is set
process.env.VUE_APP_ENABLE_STATISTICS === "true" ||
process.env.VUE_APP_ENABLE_STATISTICS === "True" ||
process.env.VUE_APP_ENABLE_STATISTICS === "1"

But you doesn't set any variable in the environment files? Is that right?

The APP_ENABLE_STATISTICS is in .env,production


Calculated worker setting

Summary

It would be really cool if the number of workers could be the result of some simple division depending on the maximum threads of the system.
<MSTest>
    <Parallelize>
        <Workers>{MaxCpuThreads}/2</Workers>
        <Scope>MethodLevel</Scope>
    </Parallelize>
</MSTest>

Background and Motivation

We have some tests, that spawn a bunch of threads that we try to parallelize at the method level. For this we are configuring the following in our runsettings file:
<MSTest>
    <Parallelize>
        <Workers>0</Workers> <!-- max cpu threads of the system -->
        <Scope>MethodLevel</Scope>
    </Parallelize>
</MSTest>

But because each test method starts a bunch of threads this isn't really the right number to get good performance. Instead we have the possibility to set a static value like <Workers>4</Workers> but this is not that flexible, if we use many different machines.
It would be perfect if we could say "use half/one fourth of the available CPU threads as the amount of workers."
Proposed Feature
Allow simple calculations (maybe only division) to set the worker amount.
Alternative Designs

C# Hook that can modify the workers before the tests run (Does not seem to be how testfx does configuration anywhere else.)
Extra runsettings property <WorkersScalingFactor>0.5</WorkersScalingFactor> is weird if the worker setting is an absolute number.

Hi @JustusGreiberORGADATA,
Thanks for the feature suggestion. Could you please specify what you min by "maximum number of threads on the system"?

Hi,
physical CPU cores + hyper-threading "cores". If you look at Intel or AMD datasheets this is what they call total number of threads:
https://www.intel.com/content/www/us/en/products/sku/230580/intel-core-i513500-processor-24m-cache-up-to-4-80-ghz/specifications.html
https://www.amd.com/en/product/8456
It is my understanding that if I specify <Workers>0</Workers> this is the number of test workers the test platform will dispatch. But maybe I'm wrong about that 🤔.

When you set 0 we are currently limiting to the number set for Environment.ProcessorCount (see https://github.com/microsoft/testfx/blob/1223683d9b4ee9e2dd784f8315b45a50698281a0/src/Adapter/MSTest.TestAdapter/Execution/TestAssemblySettingsProvider.cs#L44)

It would be great if it was possible to select the exact logical core count automatically

@MarcoRossignoli are you aware of any API in .NET that would give us a logical count?

So I guess it would be better to update the proposal above to say:
<Workers>{Environment.ProcessorCount}/2</Workers>
Then it is 100 percent clear what I want out of this feature.

I prefer to avoid adding too much logic inside the runsettings. I have too much experience of it starts with a few operators and end up as a fully fledge computation expression. For such case, I think we could call a method (register a callback) with MSTest runner that we would call inside MSTest so users could provide any arbitrary logic.
@MarcoRossignoli @nohwnd WDYT?

are you aware of any API in .NET that would give us a logical count?

Environment.ProcessorCount returns the logical count. That is a number of threads that can run at the same time. On a normal CPU with hyperthreading it is physical cores * 2.  Usually this is about the right number of threads to start for CPU bound work.  And we cannot figure out the exact right amount on behalf of the user.
If each test starts additional 3 threads, then they (probably) will get more throughput using logicalCores/3 (minus some that we use for vstest overhead, if this is vstest).
If they start a lot of IO work, and use separate blocking threads for it, then more throughput can be achieved by upping the number workers even above the CPU count (on the expense of memory).
This also assumes that they are running just 1 test process at the same time.

I prefer to avoid adding too much logic inside the runsettings.

I was considering adding this setting to VSTest as well so user can say total cores/2, or total cores-10%. But it seemed too easy to do from commandline via inline runsettings, since the Environment.ProcessorCount is ENV variable.

But it seemed too easy to do from commandline via inline runsettings

But this would not work inside the test explorer in VisualStudio, would it? Because this would be my main use-case.

As a workaround you can subclass the ParallelizeAttribute and calculate the factor in code.
[assembly: ScaleParallelize(0.5, Scope = ExecutionScope.MethodLevel)]

public class ScaleParallelizeAttribute : ParallelizeAttribute
{
    public ScaleParallelizeAttribute(double scalingFactor)
    {
        var workers = (int) Math.Round(Environment.ProcessorCount * scalingFactor, 0, MidpointRounding.AwayFromZero);
        if (workers == 0)
        {
            workers = 1;
        }

        Workers = workers;
    }
}

Just a warning that I don't see anyone doing this (on https://grep.app), so it is not a common scenario and might break later, or not be fully compatible with our analyzers.

Closing as won't implement.


Database creation script error in MariaDB version >= 10.2.1

When you run the script setup-mysql.sh or execute the sql file wct-schema-mysql.sql directly inside the mysql client the following error occurs:
Function or expression 'TO_DATE()' cannot be used in the CHECK clause of CHK_END_TIME
This is probably an issue for MariaDB 10.2.1 and up, since from that version onwards constraints are actually enforced.

This is still a problem after one year, making it impossible to install WCT with the newest MariaDB version.
MariaDB version 10.3.22.

@jmvezic Yeah, it's annoying. There's a fix in the coming release, which upgrades the major frameworks and libraries used in wct. It's in a new repository. This is the commit: https://github.com/WebCuratorTool/webcurator/pull/1/commits/8be81ac36f28a9120cdc72d28efd53068197c29f.
As a workaround, for now, you could replace your version of wct-schema-mysql.sql with the version in that commit, i.e.: https://github.com/WebCuratorTool/webcurator/blob/8be81ac36f28a9120cdc72d28efd53068197c29f/webcurator-db/latest/sql/wct-schema-mysql.sql.
Alternatively, you could wait for the new release, which we're hoping to finish this summer.

Yes, I did exactly that - works perfectly. Does the coming release also cover the OpenJDK 11 support perhaps?

@jmvezic We're not planning to have open-jdk 11 support in the first release, 3.0, but it will be in the first or second minor release after that. It does have a fairly high priority for us.


New version: Microsoft.Skype version 8.82

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Use Gradle ResourceHandler to download text file

Pull Request Details
Gradle has simple functionality for downloading text files.
https://docs.gradle.org/current/dsl/org.gradle.api.resources.TextResourceFactory.html
As well as being simple to view, they are compatible with the Gradle Provider API. Also, I think that these files will be cached and shared - improving performance.
Description

Related Issue

#1114

Motivation and Context

How Has This Been Tested

Types of changes

[x] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have included my change in the CHANGELOG.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

there's a bug so I'll fix this first

That's a really interesting Gradle feature, thanks!
Making it a separated Gradle task makes sense too.


Adding setup JDK 17 step to workflows

Purpose
part fix: https://github.com/wso2/apk/issues/1771

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (fd4451f) 25.58% compared to head (90a6d12) 80.10%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1776       +/-   ##
===========================================
+ Coverage   25.58%   80.10%   +54.52%
===========================================
  Files         222        9      -213
  Lines       21671      548    -21123
  Branches     5120      246     -4874
===========================================
- Hits         5544      439     -5105
+ Misses      15996      109    -15887
+ Partials      131        0      -131

Flag
Coverage Δ

common-controller
?

config-deployer-service
?

idp-domain-service
80.10% <ø> (ø)

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 213 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Question] : How to receive share screen

Hi . im using agora for mobile and macos . im try to share screen from my macos to mobile but nothing happen . the AgoraRtmMessage content was show nothing .

Sorry for the late reply, Our Flutter RTC SDK support sharing screen on the desktop.


Further out of tree build fixes

They slipped me through somehow...

This pull request has conflicts with the master branch.
Please resolve these conflicts on your personal branch and commit the changes, then the pull request should automatically update so I can review/merge the changes.

rebased & build tested

Thanks for making those changes!

Thanks for making this project :)


Added in component and subtask functionality

I required the ability to query both components and subtasks when manipulating Jira issue webhooks and noticed that there wasn't any fields defined in this pack for them. I have slotted them in as optionally requested values.
They don't have the full functionality like comments do where they can be inserted as well as queried, as the jira-python library that this pack is built on does not have that functionality.

Hey Nick,
I believe I should have resolved the issues you had flagged and implemented the simplification changes for the components/subtasks.
Looks like all of the issues from the previous build have been fixed but it still complains about my line containing the new options being longer.
Cheers,
-D

Fixed!
-D

@dylan-bitovi Thanks so much for the PR! Looks like you're a first time StackStorm contributor and wanted to extend an offer for free stickers as part of our Community Sticker Program.
If you're interested please send me your address to my email<EMAIL_ADDRESS>Have a great day and looking forward to reviewing more of your PRs in the future!


Module Installer Zip File Contents

Would it be possible to only use the zip file name as the module folder ? (for Admin -> Module Manager -> Add New)
Please note that :
   Module Folder must be on top level of the zip.
   Name of the zip must be exactly equal to the name of the module folder inside.
Module Zip Structure :
  ModuleName.zip
    ModuleName Folder
      Config
      Console

We can just use the zip filename as the module folder name, it would be much easier to distribute (and update) like the example below.
Please note that :
   Name of the zip must be exactly equal to the name of the module folder.
Module Zip Structure :
  ModuleName.zip
      Config
      Console

ModuleName.zip --> This will be the created folder's name like ModuleName
Reason for this request is simple, when you create a zip file from a github repo (using workflow/actions), you can change the name of file and contents of it but it is not possible to add a new folder in it and put packed release files under that folder.
( If there is a way to do this without changing repository file/folder structure I am not able to find it)

An example release file can be found here
https://github.com/FatihKoz/DisposableRanks/releases

Solved with GitHub actions ;)


[BUG] Uncaught (in promise) TypeError: Cannot set properties of undefined (setting '0')

Describe the bug
Unhandled exception which break the app
To Reproduce
Steps to reproduce the behavior:
I have a collection of cards that I use with obsidian-spaced-repetition plugin. I wanted to to give this plugin a try because of the implementation of a new algorithm. However when  I enable plugin the crashing error occurs. It seems to happen when I put certain tags into the settings of the plugin and when 'FSRS' algo is enabled.
Expected behavior
When I put my tags into settings, the plugin should scan all my cards and show me decks.
Screenshots
If applicable, add screenshots to help explain the bug. This could be the logs in the developer console (CTRL + SHIFT + i).
plugin:obsidian-spaced-repetition-recall:4711 Uncaught (in promise) TypeError: Cannot set properties of undefined (setting '0')
at DataStore.setSchedbyId (plugin:obsidian-spaced-repetition-recall:4711:14)
at eval (plugin:obsidian-spaced-repetition-recall:4913:12)
at Array.forEach ()
at DataStore.setTrackfileCardSched (plugin:obsidian-spaced-repetition-recall:4912:22)
at SRPlugin.findFlashcardsInNote (plugin:obsidian-spaced-repetition-recall:23329:17)
at async SRPlugin.sync_Algo (plugin:obsidian-spaced-repetition-recall:22858:41)
at async SRPlugin.sync (plugin:obsidian-spaced-repetition-recall:22652:7)
at async eval (plugin:obsidian-spaced-repetition-recall:22641:11)
Versions (please complete the following information):

OS: [e.g. iOS]
Obsidian version: [e.g. v0.12.4]
Plugin version: [e.g. v1.4.9]
If on desktop, Installer version: [run this.navigator.appVersion on the developer console, e.g. 5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/0.12.3 Chrome/89.0.4389.128 Electron/12.0.6 Safari/537.36"]

Additional context
Add any other context about the problem here (e.g. the markdown producing the error).

you need change dataLocation, before changing Algorithm to Fsrs

I have changed data location, to plugin folder, to vault folder and to custom folder. The error is still there. Plugin doesn't launch

ooops.
I haven't had this problem before, please backup your vault first, or try it in a separate test vault.

disable the original SR plugin;
restart OB, ctrl+shift+i;
modify the flashcard review tags, modify the DataLocation to plugin folder, then the review time information in the review notes should be gone;
change the algorithm to Fsrs, then it should work properly.

If you still get any errors, please give me your feedback!

hi, the latest release should solve the bug, try it~


how to add custom sampler?

Checklist

I have searched related issues but cannot get the expected help.
I have read related documents and don't know what to do.

Describe the question you meet
I want to make a custom sampler for my own dataset,is there a tutorial can help me to do this?

refer to to this file

but I also want to know how to invoke this sampler in the config file?could you please show more details?Thanks.

here is an example

another question,if I want to train on distributed model,should I customize a sampler that inherits from DistributedSampler class or just from torch.utils.data.sampler.Sampler class?

No, we support the Distributed training, users do not need concern about samper.  Related code is here, DistributedSampler have been implemented in mmcv.


validate host names during build

if host names don't exist in say, nginx.conf, then terminate

A simpler step would be to run nginx -t before systemctl restart nginx. Right now, restart does do a nginx -t, but it then fails to start. May be a way to do this with systemd.
Hostname validation would be best although that's tricky when migrating to a new IP. Perhaps need to add IP-host map to /etc/hosts temporarily.


Vickel: Watch sparshmedia.com

Vickel requests the watch of the watch_keyword sparshmedia\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ


Issue_84_Solution

I have created a webpage ,which requires the client to present their skills along with the ratings for the evaluation of performance.
Issue #84

Hey! I have made the requested changes. Pl check it . Thanks!


Bug: GPS data still present after adding EXIF_REMOVE_GPS .env variable

What happened?
Unsure if I'm doing something wrong here. I added the following to my .env file:
EXIF_REMOVE_GPS=true
EXIF_ENABLED=false

then uploaded an image, but I noticed that the version I downloaded from Zipline still has the embedded GPS data present. When attempting to use the API to get EXIF data, I get error "403: exif disabled" so the changes to the .env file are taking effect, doesn't seem to be removing the GPS data though. Let me know if there's anything else I need to submit, do, or if I'm missing something - the image I'm uploading is a JPG file taken on my Pixel 7 Pro. Thanks!
Version
latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)
What browser(s) are you seeing the problem on?
Firefox
Zipline Logs
No response
Browser Logs
No response
Additional Info
No response

Forgot to add, currently on version 3.7.9

Perfect, that worked. Thanks!


Bot not receiving anything

Bug Report
Current Behavior
The bot does not seem to receive anything.
module.exports = app => {
  // Your code here
  app.log('Yay, the app was loaded!')

  app.on('*', async context => {
    console.log(`Event received: ${JSON.stringify(context)}`);
    //const issueComment = context.issue({ body: 'Thanks for opening this issue!' });
    //return context.github.issues.createComment(issueComment);
  })

Expected behavior/code
Any log message indicating a received event.
Environment

Probot version(s): 7.2.0
Node/npm version: 10.15.3/6.4.1
OS: Windows 10

Additional context/Screenshots

I did follow the tutorial with the manual setup.
I did download the key into the root project.
I did run npm start

Same happens when running on a debian server.

Are the events showing up on smee?

Any update on this issue? I am facing the same issue. I am unable to receive any logs.

Thanks @MaximDevoir for your reply. The events were emitted once I gave the permission to read my code base. Is this how it is supposed to work ? Just curious..

If you have read access on the contents permission, you will be able to read a user's codebase/repository file contents. If you have the push event enabled and no access on contents, you will receive a meta information each time someone pushes to the repo, but you will not have access to the code contents.
Take a look at these resources:

GitHub App Permissions. You can see which permissions you will need to enable to access the resource.
Event Types & Payloads.

Thanks for jumping in to help here @MaximDevoir. @johnsonsamuel, it sounds like you hadn't installed the app on the repository - GitHub Apps work by being installed on a repo to get the access and subscriptions it needs for that given repo. You can learn more about that here: https://developer.github.com/apps/differences-between-apps/#who-can-install-github-apps-and-authorize-oauth-apps
I'll close this out because I think your question has been answered, but if not feel free to reopen!


Not pointing to an official NPM package on the website

Most appropriate sections of the p5.js website?
Libraries
What is your operating system?
None
Web browser and version
No response
Actual Behavior
In the "Download" and "Get started" section, there's no hint how to install it in NPM and more imporantly: There's no mention of the official package name.
I guess it's "p5" but NPM does not prevent any random (evil) guy on the internet to upload and claim a package with the name "p5", so i try to verify what's official or not here.
Would be nice, if you could state that in the docs,
thank you !
Expected Behavior
Not really a bug, see "Actual Behaviour"
Steps to reproduce
Not really a bug, see "Actual Behaviour"
Would you like to work on the issue?
No

p5.js is not currently designed to be used via NPM packages, publishing on NPM mainly is to help with distributing the library on CDNs. We can't guarantee importing p5.js NPM modules will work so it will not be listed on the downloads page at the moment.


Hunter Mongoose Bite Uses Outdated Raptors Fury Value

Value should be updated to 0.15 to reflect recent buffs.  Code should also be refactored to use the common value accessible in runes.go

Hey thanks for reporting this! I've made a fix and it's going out now


Upload to Sondehub from sondemonitor bug

Hi i have been trying to upload to sondehub from my laptop via sondemonitor. the issue is that my station will show up on the map but the data that i am trying to send to sonde hub from sondemonitor seams to not work.
some information about setup the settup i am using is a RTL SDR reciver with Sdrsharp that is sending a audio input to sondemonitor. from there i am using the M10 decoder with a 45 bitrate to extract the data from the sondes used in my area Ørlandet norway, they use M20 sondes
so my station shows up lelun/ lelun SDR but the baloon marker and other infomation dont. are you guys able to tell me if its sonde hub that are having issues or my sondemonitor? i am able to see cordinates and that in sonde monitor but not on sondehub.

I believe Sondemonitor only supports uploading RS41 data to SondeHub at this time.

alright i will try to contact the devs of sondemonitor and ask if they can look in to the ability to upload gps data from the M20 to Sondehub.
its a shame its not already implemented. i am tracking one right now that would be nice to see on sondehub.

I just had a look at the Sondemonitor version logs and it appears SondeHub uploading support has been extended to MeteoModem and Graw radiosondes in versions <IP_ADDRESS> and <IP_ADDRESS> so if you are running one of those versions or higher it should work in theory.

I checked the SondeHub database and haven't actually seen any non-RS41 sondes from SondeMonitor in the last 2 weeks so I'm not sure if this has been tested in reality.

It hasn't been tested, and there are multiple issues that need to be
resolved with both M20 and DFM uploading before it will work.
On Fri, 30 Sept 2022, 11:02 Luke Prior, @.***> wrote:

I checked the SondeHub database and haven't actually seen any non-RS41
sondes from SondeMonitor in the last 2 weeks so I'm not sure if this has
been tested in reality.
—
Reply to this email directly, view it on GitHub
https://github.com/projecthorus/sondehub-tracker/issues/264#issuecomment-1263002150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH57E4KDDOQNNJBDG3NZ7DWAY7LFANCNFSM6AAAAAAQZI4JZY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

probemonitor only supports RS41 and DFM at the moment version 6267

DFM support is also not working. There are a number of issues with the uploaded telemetry which results in the telemetry being dropped by SondeHub. I've reported these issues to Bev.

I'm going to close this issue, as this is not a SondeHub issue. This is a SondeMonitor issue, and you should be taking it up with Bev.

alright ill take it up with them.
thanks for the responce and hopefully they can get sondemonitor to upload the M20 data to sondehub. i decided to post here sence i was not sure where the issue was and decided to start on this end.
i am looking forward to upload the data from my region so the comunity can use it :)
again thanks for the help and i wish you guys a good day!


Propose changes to include.gradle

Your Environment

Plugin version: 1.5.0
Platform: Android
OS version: 7
Device manufacturer / model: 6P GenyMotion
Nativescript version (tns info): 2.5.3
Plugin config (Not sure what this is

I have a few different plugins installed that use google play services.
In some include.gradle files I have to open them up and change:
compile 'com.google.android.gms:play-services-location:+'
to
compile 'com.google.android.gms:play-services-location:10.2.+'
To get around this tweaks can be made to the include.gradle file:
def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : '+'
compile "com.google.android.gms:play-services-base:$googlePlayServicesVersion"
Would you be open to this change?  If so I can submit a pull request.
Thank You,
Randy

NO!

If it is a bad idea can you elaborate please?  I see other plugins use it with no problem.

https://medium.com/@suchydan/how-to-solve-google-play-services-version-collision-in-gradle-dependencies-ef086ae5c75f

Plugin's must not dictate to your app some particular version of play-services to use.  It's your app's responsibility.
One crappy plugin want 9.x.y, some other wants 10.0.2, another 10.2.1 and in a few months, there'll be 11.0.0 and a few weeks after 11.0.1.

Thank You Sir.  Thank looks to be exactly what I need to resolve the issue.
Thank you for your follow up message too.
I will give it a whirl tonight and see how it goes.


Documentation

Ensure the following fundamental changes are complete:

[x] Deploy documentation rendered using the napoleon Sphinx extension at ReadTheDocs
[x] Provide an example of how to use each function

Reference: https://pages.github.ubc.ca/mds-2022-23/DSCI_524_collab-sw-dev_students/materials/assignments/milestone3.html#documentation

Finished this and opened a PR


Any memories/update_memory.json example pls ?~

There are  examples of update_memory.json. But actually, you don't need to manually create this file. When you run the demo code and enter your name to start conversation, if this file doesn't exists, the code will automatically construct update_memory.json in the memories folder.


Dropoff Locations are Hardcoded

Building and floor choices are hardcoded into the chatbot instead of being populated dynamically.
Please see PromptForBuildingStepAsync() and PromptForFloorStepAsync() within ConfirmDropoffDialog.cs.
            return await step.PromptAsync(                 BuildingPromptName,                 new PromptOptions                 {                     Prompt = MessageFactory.Text("In which building did you park the car?"),                     Choices = new List<Choice> { new Choice("M"), new Choice("S1"), new Choice("GS"), new Choice("HX") },                 },                 cancellationToken);
            var floors = new List<string>();             switch (state.Building)             {                 case "M":                     floors = new List<string> { "-1", "-2", "-2.5", "-3", "-3.5", "outdoor" };                     break;                 case "S1":                     floors = new List<string> { "-1", "-2", "-3" };                     break;                 case "GS":                     floors = new List<string> { "-1", "outdoor" };                     break;                 case "HX":                     floors = new List<string> { "-3" };                     break;             }

Thanks! 👍
Same for PWA frontend. Should pull details from the .well-known endpoint at startup and store it in a singleton.


unable to get actual path of the file

Hello Dear Developer, first of All thanks for develop such a great package. But it just give us the content path. How can we get the exist file, to perform different operations over it?

Could you elaborate about which functions you are talking specifically?
Could you provide a code sample?

It does not Provide the actual path of the file.
Suppose we have a file present in "/storage/emulated/0/dcim/camera/test.mp4"
so it provide us the path "content://media/external/video/1234"
Which is not actual path. Is there is any way to get the actual path of the file?.

A short answer is getting the direct path of the file is not possible, and even if it is possible, you would probably end up not being able to actually read or modify it.
I suggest you start here with familiarizing youself with a concept of Android Scoped storage and ContentProvider/ContentResolver contract, along with Content URIs that they use to communicate.
For that I would read through this section of Android documentation, with all subarticles https://developer.android.com/guide/topics/providers/content-providers
To put it shortly for your case, if you want to modify a file, you would need to open it with a file descriptor from ContentResolver, using Content URI (and not an actual file URI, which you don't know and shouldn't need to know), and then modify it via file streams.
Unfortunately, exposing this API in a Flutter plugin is a rocket-science level effort, so I have chosen to not implement yet. It doesn't mean that this isn't possible, but I would rather implement it when there is an actual demand for it and concrete use cases, to better design a solution for it.
Link to the part of the file APIs in ContentResolver that I have chosen to not expose
The only thing that is implemented is a file API inside ContentProvider, because it doesn't require too much effort to implement for a most common use case.
If you have suggestions on how this API could be exposed, I would be glad to read through that.