zjsunit: Undo mock_cjs abstraction violation again

There is still no need for mock_template to reach into the internals of mock_cjs.  Make it a normal caller of mock_cjs.
This is basically the same as 60f5a00c0917232369e88471a049a9f4ab673064 (#18804), because the same abstraction violation was since reintroduced in the same way.
Cc @showell.

Extracting a helper function is not an abstraction violation, and fn is a right name in this context.
Can you please find something more important in our codebase to nitpick about?

It is not an abstraction violation to extract a helper function, but it is an abstraction violation for mock_template to call it. Both the helper function and the module_mocks map are internal to mock_cjs.

It’s not an abstraction violation.

I am not sure you understand how abstractions work @andersk.  If the exported  function has the same behavior after your patch as before, then you really haven’t fixed an “abstraction violation (again)”.

@showell can you explain for me why fn is the right name in the comment above (https://github.com/zulip/zulip/pull/18864/files/14a0b791ca92240c633329550b33caa5c2e67df8#diff-80d7bc9917ab686a299f374205193e7dee0b00f36e7c38b413152d77a0505a66)?
The argument for using request here seemed pretty compelling to me.

Are we really quibbling over using fn as a varname for things that are file names?

request is a terrible variable name

Go ahead and merge this nonsense.  I can work around it.

It is not my intention to force commits through over your objections. I opened a PR and Cc’d you to request your feedback. I consider that especially important since the commits leading up to this (#18802, #18804, #18854) made it clear that there are differences to be resolved. My hope is to resolve them through discussion rather than edit wars. Would you be willing to mark this PR as reopened, so we can continue that discussion in a neutral and productive environment?

I don’t consider these changes to be improvements.  But they are also not the end of the world.  Reopening.

Maybe you can tone down the “abstraction violation” part of the commit message, because that is super irritating.

Once we convert all the node tests to mock templates consistently, this proposed change will probably become moot. I have a plan here.

Thoughts on renaming the parameter to module_path as suggested here?
https://github.com/zulip/zulip/pull/18864#discussion_r652988369

Sure, that’s fine

OK, adding such a commit and merging.


Discontinious paths

Hi Catherine,
First, I want to say that you did an amazing job with this framework.
Now, I'm trying to implement a way which works even for discontinuous paths. Did you already think about how to do this?
What I am thinking :

Sample points for each path.
For each point, compute the normal to the path at this point.
If the normal intersect an even number of paths, then there are no stitches to trace
If it's odd, trace the stitches following the curves and the first intersection.

What do you think ? is it doable?

Hey @styloInt ,
I need to update the example in the readme - if the paths don't intersect, the digitizer is fine - I just digitize every discontinous path individually. However it's still a problem if one path is contained within another - like a donut. In which case, you're right, that's how you would need to test whether one path is within another. svgpathtools has already implemented this: https://github.com/mathandy/svgpathtools/blob/master/examples/determine-if-svg-path-is-contained-in-other-path-example.py#L12 , and their method is kind of similar to what you've described.
Once the paths have been determined to intersecting, I would prefer to carve up the shape into smaller shapes without interior regions, e.g. turning the donut into to two crescents, as the fill algorithm that looks best is the scanlines fill, and that only works with rectangular-ish shapes.
In practice, I haven't worked on this because I haven't had many projects that had intersecting paths. But I imagine it will become a big deal once people start using any old SVG, since most SVGs implement negative regions by just stacking shapes on top of other shapes.
But I'm always open to contributions!

Thanks for you answer.
One thing I don't understand in the function path1_is_contained_in_path2 :
assert path2.isclosed()  # This question isn't well-defined otherwise

Why when the path is closed, the question isn't defined ?  For example, in a donut, we have one closed shape inside another closed shape.
The "intersect" function does not work in this case, but I don't understand why ... (I'm new to the area of  vector images so there are certainly things that I don't get)

We're checking to make sure that path2 is closed. In the donut, path2 would be closed. If the path were open, how would we define what counts as "inside"?

Thanks for your answer.
Actually I'm having trouble implementing the "donut case".
My image example is this one :
img
As you can see this image contains a lot of donuts example. What I'm having trouble doing is following the curves.  I'm thinking by sampling some points along the curves and then following them. What do you think about this idea ?

If I were you, I'd open the image in inkscape, and trace individual segments into polygons without donuts with the pencil tool. It's something you're probably going to need to do anyway as the png-to-embroidery pattern functionality of this library is extremely experimental.

Thanks for the advice, but I'm trying to have an end to end solution without the need of manual manipulation. ^^
In the way that this website does when you decide to personalize the t-shirt: https://www.promotique.com/product/port-authority-tall-stain-resistant-polo/P00W27413
I completely understand that the functionality is extremely experimental but it's a good base to start :)


fix network speeds. closes #287

should afterwards be cherry-picked into v1.1.0 as well.
Needed a bug fix in dat-worker and forgot to convert to kilobytes

Was wondering why builds are failing, turns out Amazon is having an S3 outage which is affecting Travis - https://twitter.com/traviscistatus/status/836639617847681024

+1


Experiment with simple improvements [2w]

The e2e framework is ready for running and evaluating the prototypes in DO. We define a list of configurations of network topologies and load (and other parameters if needed) that we will use to run each optimization.
@hvanz not really clear on the scope here and on the duration.

Closing due to too broad a scope.
Will open issues for individual approaches.


Include metadata views on README.md

Closes: #84
Description
Detailed explanation of the new views and how to use them and where to find the examples.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

[ ] Update the version in package.json when there is a change in the smart contracts

I'm gonna wait to review this until we get my comments resolved in the other PR, there are some bigger changes that might be needed. Also, the target branch for this should be your metadata views feature branch, not master

great and fixed!


Feature/deseng668: Added authoring side nav and bottom nav, modified routing, added authoring context, added base page for banner

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-668
Description of changes:

Feature New authoring content section

Implemented authoring side nav
Implemented authoring bottom nav
Modified routing
Implemented authoring section context
Still working on skeletons
Merged with main
Merged with Nat's feature branch
Made some post-merge fixes

User Guide update ticket (if applicable):
N/A

Codecov Report
Attention: Patch coverage is 45.78313% with 45 lines in your changes missing coverage. Please review.

Project coverage is 75.76%. Comparing base (be4394d) to head (c145283).

Files
Patch %
Lines

...gement/admin/create/authoring/AuthoringSideNav.tsx
33.89%
38 Missing and 1 partial :warning:

...nts/engagement/admin/view/AuthoringTabElements.tsx
20.00%
4 Missing :warning:

.../components/engagement/admin/view/AuthoringTab.tsx
50.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
- Coverage   76.03%   75.76%   -0.28%
==========================================
  Files         609      615       +6
  Lines       22105    22263     +158
  Branches     1797     1838      +41
==========================================
+ Hits        16808    16868      +60
- Misses       5033     5125      +92
- Partials      264      270       +6

Flag
Coverage Δ

metweb
64.66% <45.78%> (-0.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...nt/admin/create/authoring/AuthoringNavElements.tsx
100.00% <100.00%> (ø)

...et-web/src/components/engagement/listing/index.tsx
76.12% <100.00%> (ø)

...eb/src/components/feedback/FeedbackModal/index.tsx
88.73% <100.00%> (ø)

...eb/src/components/layout/Header/InternalHeader.tsx
88.39% <100.00%> (+1.01%)
:arrow_up:

met-web/src/styles/Theme.ts
100.00% <ø> (ø)

.../components/engagement/admin/view/AuthoringTab.tsx
25.92% <50.00%> (ø)

...nts/engagement/admin/view/AuthoringTabElements.tsx
20.00% <20.00%> (ø)

...gement/admin/create/authoring/AuthoringSideNav.tsx
33.89% <33.89%> (ø)

... and 2 files with indirect coverage changes


StorageHasRepoMd.java:33-36: Implement StorageHasRepoMd...

The puzzle 317-5a8b4b93 from #317 has to be resolved:
https://github.com/artipie/rpm-adapter/blob/c0039bb8b9f26d6a5d02a981c608f8bdb73b26d1/src/test/java/com/artipie/rpm/hm/StorageHasRepoMd.java#L33-L36
The puzzle was created by paulodamaso on 09-Sep-20.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Job gh:artipie/rpm-adapter#359 is not assigned, can't get performer


parse error: Invalid numeric literal at line 1, column 14

I just started my own node and run into the problem that shows me this message on monitor:
The only error I can think of is, that I started to configure LND through SSH even though the blockchain was not fully downloaded.
RaspiBlitz v1.7.1 Free Mem 2118M/3844M HDDuse 113G (27%)
CPU load 2.36, 2.16, 2.10, temp 74°C 165°F
bitcoin v22.0.0 mainnet   peers
Blocks - Sync
Wallet 0 sat
/0Channels 0 sat   peers
Fees collected:
@:9736
parse error: Invalid numeric literal at line 1, column 14
(standard_in) 1: syntax error

Found something similar, but does not help since I'm a newbie:
https://stackoverflow.com/questions/63133465/jq-parse-error-invalid-numeric-literal-at-line-1-column-14

Actual setup state:
Blockchain Progress :   28.47% 10 peers
Lightning Progress: 93.41 %      # What is this?
Since I'm here asking questions, I have another one: How can I add emojis in the LN-Name?
I use zram not to wear the sd-card down. Do you consider using zram in the standard image?

now I see it 92.86%, why is it lower after a reboot?

Lightning is percent based on whats already synced by Bitcoin. So this can get lower if bitcoin syncy faster then LND is catching up.

How can I add emojis in the LN-Name?

You can try UTF-8 coded chars fro the alias value in the lnd.conf (MAINMENU > SYSTEM > LNDCONF)

Do you consider using zram in the standard image?

zram is a research topic for possible future versions. If you like you can contribute your experience here:
https://github.com/rootzoll/raspiblitz/issues/2905

About the: Invalid numeric

The whole display data part got a rewrite (separation of data & view) with the upcomming v1.7.2 version. Please recheck once version is out if this error continues for you.

Thanking you for your answer's. I'll try utf-8 as u mentioned. I have successfully running zram already in 80 RPi3 systems and 4 Rpi4 systems. Sure I'll add to #2905 when I set it up with raspiblitz. But for now syncing takes me to long. I now download the bitchain with bitcoin-qt on my desktop and later copy it on my Pi4 system. It's only 24h left there. Next I restart setting up raspiblitz with current (2022-01-28-raspios-bullseye-arm64.zip) and your build_sdcard.sh During the coming week you'll hear more on that later on. Regards, Remo

I run into python problems building SD-Card with build_sdcard.sh but found solution in #2899 (I now took build_sdcard.ch) from dev-branch ant it worked through. with one error I report (btrfs-tools no installation candidate) in #2905

That btrfs-tools error giot addressed now here: https://github.com/rootzoll/raspiblitz/commit/d1cf7ee57ee382b327cc9a477f3dd7843b4488da - should be fixed

closing as fixed


added a very basic os_log (unified logging) logger

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[ ] I have added the required tests to prove the fix/feature I am adding

[ ] I have updated the documentation (if necesarry)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues:
https://github.com/CocoaLumberjack/CocoaLumberjack/issues/765
Pull Request Description
I added a first draft of a logger which uses the new os_log API (https://developer.apple.com/reference/os/logging).
The aim is to be future proof and most of all to be able to log more than 1024chars in the device logs (see: https://github.com/CocoaLumberjack/CocoaLumberjack/issues/765)

Can you take a look at the Travis error?
https://travis-ci.org/CocoaLumberjack/CocoaLumberjack/builds/209397735

Codecov Report

Merging #850 into master will decrease coverage by 0.44%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
- Coverage   23.07%   22.62%   -0.45%
==========================================
  Files          16       17       +1
  Lines        3913     3942      +29
  Branches      279      283       +4
==========================================
- Hits          903      892      -11
- Misses       3008     3048      +40
  Partials        2        2

Impacted Files
Coverage Δ

Classes/DDOSLogger.m
0% <0%> (ø)

Classes/DDTTYLogger.m
18.18% <0%> (-0.88%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca61764...b7ee090. Read the comment docs.

thanks for the merge @rivera-ernesto, can the version be bumped to 3.2 ? Since I reference this pod as a dependency in a podspec, refering to the git master is not possible and a released version is needed.

Again, I leave releases to @bpoplauschi .

@bpoplauschi did you by any chance have time to look into this ?

Not yet guys, I'm a bit busy right now, but I will take a look soon.

bump @bpoplauschi  :) ?

Very useful change. Thanks for doing the fix @acacio88.
We would also require this change. Can you release a newer version @bpoplauschi ?

Sorry guys. I'll make it up with a new release :)

Ok, version 3.2.0 is available. Enjoy :) and again sorry for the delay

Cool, thanks @bpoplauschi


[TM] Add spec for AccessibilityManager

Summary
Part of https://github.com/facebook/react-native/issues/24875

Changelog

[General] [Added] - Add TurboModule spec for AccessibilityManager
Test Plan
Run yarn flow on the root level

looks great! There are some types missing from the android side of things however:
https://github.com/facebook/react-native/blob/09f17a4e298d4cf02fa822e2a6f685f3bc7f0aac/ReactAndroid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java#L102-L110

I think this and AccessibilityInfo leads as separate modules. PR for Android one: https://github.com/facebook/react-native/pull/24891


Add support for embedding containers in images

This adds a stage called org.osbuild.oci-container that installs
and oci-archive tarball into the container storage of the tree
being constructed.
The source can either be a file from another pipeline, for example
one created with the existing org.osbuild.oci-container stage, or
it can be using the new org.osbuild.oci-container input + source
which will download an image of a given name + digest into the
local cache and then use that to install from.
There is an optional option in the install stage that lets you
configure a custom storage location, which allows the use of the
additionalimagestores option in the container storage.conf
to use a read-only image stores (instead of /var/lib/container).
Note: skopeo fails to start if /etc/containers/policy.json is
not available, so we bind mount it from the build tree to the
buildroot if available.

There are no tests yet, but i tried this with the automotive sig using this manifest:
container.mpp.yml
I will look into real tests soon, but would like some overall feedback first.

Hmm, thinking a bit more about this I'm not sure we want both oci-archive.install and docker-archive.install, as I imagine that using this on a higher level, like with osbuild-mpp or image-builder you just want to say "install this container" and point to a named image on a registry, and then it will generate the right kind of source/input for the type of image that is on the registry. So, it makes more sense to have a container.install with a type. Lemme redo that.

After some testing and research I started over with this.
The new approach is that we have a single input/source combo called "org.osbuild.container-image" which handles both docker and oci archive formats. These pull from a registry into a shared cache which is indexex not by the manifest digest, but rather then "image id", which is the digest of the container "config". This is more stable over time (as the outer manifest can change during e.g. transport due to recompression), and is what will be displayed by podman once the image has been installed.
The pull defaults to docker format (as this is compatible with what podman pull would do in terms of image ids), but also allows you to specify the oci format. The cache stores metadata from the pull, such as the image format and name.
The new container-image.install stage can install both from the above cache, using the existing metadata for defaults (but you can override e.g. the image name in the install), as well as regular files (like from oci-archive stage) where you have to manually specify the format and image name in the file metadata.

This depends on this osbuild-ci image update: https://github.com/osbuild/containers/pull/27

Small typo in commit message of obuild-mpp: Add process_stage() helper (obuild). Also in general some small python style issues. Maybe just run in through autopep8.

1. We generally tend to name the modules (sources, stages) after the tools they use; the exception here are inputs which are named after the artefacts they deal with. Thus would suggest to call the source just `org.osbuild.skopeo`, but also the stage `org.osbuild.skopeo`(or maybe this one, more precisely `skopeo.copy`, but we can just assume copy is the default and then have `skopeo.xxx` for other sub-commands if we ever need them).

Ok, this makes sense. I'm not really sure the stage should be "skopeo.copy" really, because it doesn't expose the full power of the "skopeo copy" command. The source is always a container archive, and the destination is always the local container store, so it really is more of an "install". But that is uninteresting if we skip the final part of the name for this default skopeo stage.

2. After some more thoughts and a long discussion with Tom, we concluded that it is ok for content in the store to _not_ (always) be stored with the hash of its current content as long as we make sure during the transfer that we got the object we asked for: it is ok to request a container with the sha256 referring to the docker transport but then storing it as with that sha256 as `oci-archive` as long as skopeo verifies during the copy operations that it got the right manifest it asked for (which I _think_ it does).

Then, as a consequence we can treat the object inside the store as opaque but referred to via its original(!) hash. This allows us to just use oci-archive (and we can even maybe change it in the future to something else, if we wanted). Let's call the content in the store just org.osbuild.container and also the input as such, org.osbuild.containers (which nicely fits with .tree, .files).

Hmm, I think this is a bit confused as to what the code currently does. Lemme start from the beginning.
First of all, a container image has multiple part, and each has its own digest:

A set of uncompressed tar files for the layer
The gzip compressed version of the layer files
The image config manifest, which contains references to 1
The image manifest, which contains references to 2 and 3.
The image list manifest, containing reference to one 4 per arch

When you pull a container image, it resolves either to a 5, which is then matches to a 4 by the os/arch/variant tuple, or a 4 directly. This digest is the one you can specify directly to the podman pull command. However, such digests are somewhat immaterial. For instance if you (re-)compress the layers or add an image to a list they are modified.
The real identifier for the layer is really 3, which is what is listed as the image id if you run "podman images" after pulling the image. This is really the identifier that we're interested in getting right in the caches, etc, as the other part is "merely wrapping".
So, how the source looks is like this:
sources:
  org.osbuild.container-image:
    items:
      "sha256:1dfee2388ff5eb49c7505632d913b422e1d42a3b8f67ff901f151f2c7d1cca46":
        image:
          name: quay.io/containers/skopeo
          digest: "sha256:49faa3348d31faac18679332e6bb2cf4a993dea8d471a38325835566e116bf25"

Where the outer digest is a 3, and the inner a 5. The source then pulls the specified 5 digest from the named registry, then verifies that the pulled data actually has the correct "stable" container id (the 3 digest), and then stores the downloaded image in the store, under the "stable" (3) digest name.
Now, there is one more complexity to this. There are actually two basic manifest formats, the "docker" format and the "oci" format. They are essentially the same, but there are small details that are different in the formats so while the can be easily converted from and back, they will not get identical digests. In particular, the stable/3 digest will be different which will cause the container image id to be different. (The conversion is repeatable though and will get the same digest.)
By default, the source uses docker archive format, which is the same format that is used by default by both "podman pull" and "docker pull". This means the container id you'll get by default is the same as you would normally get. However, the source also supports OCI format, like so:
sources:
  org.osbuild.container-image:
    items:
      "sha256:fcd1aeb3bafd2b8da75dbc802666e8ffc3c4da3e5fa1a2733c8a97020915d722":
        image:
          name: quay.io/containers/skopeo
          digest: "sha256:49faa3348d31faac18679332e6bb2cf4a993dea8d471a38325835566e116bf25"
          format: oci-archive

The above pulls the same image, but then uses an oci-archive as an intermediate storage, which causes the operation to convert to an oci config file which gets you a different container id (as can be seen by the different items key). The resulting image is then stored under a different name in the container cache, combined with metadata that says what format it is so that we can easily install it the right way.
Then using the osbuild-mpp operator there is no need to supply the container id, just the registry digest, and the resolve operation will automatically compute the container ids and put them in the right place, just like we don't have to specify the real rpm nevr or digests:
  - type: org.osbuild.container-image.install
    inputs:
      images:
        type: org.osbuild.container-image
        origin: org.osbuild.source
        mpp-resolve-images:
          images:
            - source: docker.io/library/ubuntu
            - source: quay.io/centos/centos

New version has the renames and other comments fixes as per the above and discussions offline.

One thing I was wondering: if we should not handle the container name as we do with ostree (where it is the ref in the input)

I'm not sure I understand exactly what you mean, but I think this is going to be a problem when using the skopeo stage with a file source.
For example. using a file input you can install an oci-archive like this:
  - type: org.osbuild.skopeo
    inputs:
      images:
        type: org.osbuild.files
        origin: org.osbuild.pipeline
        references:
          "name:container-archive":
            file:
              "auto-container.tar"
            metadata:
              container.format: oci-archive
              container.name: localhost/auto
    options:
      destination:
        type: containers-storage

Compare this to using ta source, defined like:
sources:
  org.osbuild.skopeo:
    items:
      "sha256:b4c44ac30e217065c38c5f25aacb17fc40199e2e71873cf00284f33bb09d72fb":
        image:
          name: quay.io/containers/skopeo
          digest: "sha256:0ac0ae9fe1f2d84a66d8bc638a0826eb5fc959333e3b156f46981eedc72c8847"

Which can be used either with the image name stored in the cache:
  - type: org.osbuild.skopeo
    inputs:
      images:
        type: org.osbuild.containers
        origin: org.osbuild.source
        references:
          "sha256:b4c44ac30e217065c38c5f25aacb17fc40199e2e71873cf00284f33bb09d72fb": {}
    options:
      destination:
        type: containers-storage

Or with an overridden name:
  - type: org.osbuild.skopeo
    inputs:
      images:
        type: org.osbuild.containers
        origin: org.osbuild.source
        references:
          "sha256:b4c44ac30e217065c38c5f25aacb17fc40199e2e71873cf00284f33bb09d72fb":
            metadata:
              container.name: localhost/some-other-name
    options:
      destination:
        type: containers-storage

I guess this later is what you mean with changing the "metadata" stuff to "ref". However, then the generated files input will not be the same as the org.osbuild.files input, which is not great, no?
I guess conceptually the two could be different and the skopeo stage could handle each differently.

I guess, thinking about this, that maybe its not great to store the image name in the cache like that, as it is only keyed of the container id. The same cached item could potentially be pulled from different names, and then the cache use is non-deterministic.

Yeah, that is a good point.

Maybe we should force the input to always list the container name to use to fix this issue.

That was the intention of my comment above and what we do in the ostree input with the ref key, i.e. the commit is "tagged" with the ref in the input not in the source.

I pushed a new version based on the discussion we had in chat. Here is now how using this looks in various usecases:
First, using mpp-embed to install from a registry:
stages:
  - type: org.osbuild.skopeo
    inputs:
      images:
        type: org.osbuild.containers
        origin: org.osbuild.source
        mpp-resolve-images:
          images:
            - source: registry.access.redhat.com/ubi8/nginx-120
              name: localhost/ubi8-nginx
    options:
      destination:
        type: containers-storage

Same without mpp:
sources:
  org.osbuild.skopeo:
    items:
      'sha256:db48dfcd4781dbef840809c1312e68b1bfc253d77d7ae4c37587cd1bcca91916':
        image:
          name: registry.access.redhat.com/ubi8/nginx-120
          digest: 'sha256:1576a3b3b5c0d0965e470f9b4980a0a3c7b8146ea13a351816de2d726c1bb20a'
...
   stages:
      - type: org.osbuild.skopeo
        inputs:
          images:
            type: org.osbuild.containers
            origin: org.osbuild.source
            references:
              'sha256:db48dfcd4781dbef840809c1312e68b1bfc253d77d7ae4c37587cd1bcca91916':
                name: localhost/ubi8-nginx
        options:
          destination:
            type: containers-storage

And when using oci-archive stage:
pipelines:
- name: container-tree
  build: name:build
  stages:
    ...
- name: container-archive
  build: name:build
  stages:
  - type: org.osbuild.oci-archive
    inputs:
      base:
        type: org.osbuild.tree
        origin: org.osbuild.pipeline
        references:
          - "name:container-tree"
    options:
      filename: auto-container.tar
      config:
        Cmd:
          - bash
- name: rootfs
  build: name:build
  stages:
  - type: org.osbuild.skopeo
    inputs:
      images:
        type: org.osbuild.containers
        origin: org.osbuild.pipeline
        references:
          "name:container-archive":
            file: "auto-container.tar"
            format: oci-archive
            name: localhost/auto
    options:
      destination:
        type: containers-storage

This is look great now! ❤
I have one thing about the input when the origin is org.osbuild.pipeline: the current code needs the format and file to find the file in the pipeline. I think we should auto-detect that. Ideally, the oci-archive stage would use api.metadata to set the filename and format as tree metadata (see for example the ostree.commit stage). The input could then use that information. Sadly, the metadata is currently not handed to the store (#273) and thus we cannot access it from the input. We actually want to solve this problem soon, since we want caching, but it might be another few weeks.
In the short term, I think we have two options: 1) do as the ostree.commit stage does and store a metadata.json along the generated container archive and read that file in the input (as ostree input does). Or we just assume for now the format is oci-archive and then just look for the single tar archive that we expect to be there.
Since we keep backwards compatibility in osbuild I very weary of introducing options that we then have to support for x years (where x is in a RHEL timeframe) when we have a possible solution (metadata storage) that would solve that, so I would rather work around that now.

In the short term, I think we have two options: 1) do as the ostree.commit stage does and store a metadata.json along the generated container archive and read that file in the input (as ostree input does). Or we just assume for now the format is oci-archive and then just look for the single tar archive that we expect to be there.

This (one tar file, or a fixed metadata.json name) means that you have to use different pipelines to construct each archive, rather than having a pipeline with multiple oci-archive stages. Maybe that is the best approach anyway though. It is a bit more verbose, but will allow better caching of previously built pipelines in a rebuild (i.e. only the changed archives will be rebuilt).
So, lets say we start of by always assuming that the file-source is an oci archive, and we just pick the first filename alphabetically. Then current manifests work fine as is, with no need for format or file, and in the future these can be extended as needed.


tf.keras MobileNetV2 with weights=None fails to train

System information

Google Colab notebook
TensorFlow version: 2.1.0-rc1
Python version: 3.7
CUDA/cuDNN version: 10.0.130
GPU model and memory: Tesla T4 12 GB

Describe the current behavior
Based on the tutorial: https://www.tensorflow.org/tutorials/images/transfer_learning#format_the_data
Start running the cells inside the notebook of the tutorial.
#Create the base model from the pre-trained model MobileNet V2
base_model = tf.keras.applications.MobileNetV2(input_shape=IMG_SHAPE,
                                               include_top=False,
                                               weights=None)

base_model.trainable = True

Then trained the model for 10 epochs, with the parameters specified in the tutorial, but the validation loss does not go down, the accuracy remains stuck.
The results of training:
Epoch 1/10 582/582 [==============================] - 87s 149ms/step - loss: 0.6606 - accuracy: 0.5788 - val_loss: 0.6953 - val_accuracy: 0.5216 Epoch 2/10 582/582 [==============================] - 80s 138ms/step - loss: 0.6157 - accuracy: 0.6425 - val_loss: 0.7064 - val_accuracy: 0.5216 Epoch 3/10 582/582 [==============================] - 81s 139ms/step - loss: 0.5765 - accuracy: 0.6769 - val_loss: 0.7014 - val_accuracy: 0.5216 Epoch 4/10 582/582 [==============================] - 81s 139ms/step - loss: 0.5378 - accuracy: 0.7143 - val_loss: 0.7488 - val_accuracy: 0.4784 Epoch 5/10 582/582 [==============================] - 81s 139ms/step - loss: 0.5072 - accuracy: 0.7368 - val_loss: 0.8380 - val_accuracy: 0.4784 Epoch 6/10 582/582 [==============================] - 80s 138ms/step - loss: 0.4777 - accuracy: 0.7601 - val_loss: 0.9534 - val_accuracy: 0.4784 Epoch 7/10 582/582 [==============================] - 81s 138ms/step - loss: 0.4354 - accuracy: 0.7894 - val_loss: 1.0138 - val_accuracy: 0.4784 Epoch 8/10 582/582 [==============================] - 81s 138ms/step - loss: 0.3937 - accuracy: 0.8110 - val_loss: 1.2038 - val_accuracy: 0.4784 Epoch 9/10 582/582 [==============================] - 80s 138ms/step - loss: 0.3593 - accuracy: 0.8288 - val_loss: 1.7442 - val_accuracy: 0.4784 Epoch 10/10 582/582 [==============================] - 81s 139ms/step - loss: 0.3166 - accuracy: 0.8547 - val_loss: 1.6888 - val_accuracy: 0.4784

Describe the expected behavior
If MobileNet V1 is used instead, with the same weight initialization and same training parameters, the results are the following:
Epoch 1/10 582/582 [==============================] - 74s 126ms/step - loss: 0.6596 - accuracy: 0.5840 - val_loss: 0.7098 - val_accuracy: 0.5216 Epoch 2/10 582/582 [==============================] - 70s 120ms/step - loss: 0.6310 - accuracy: 0.6248 - val_loss: 0.6099 - val_accuracy: 0.6483 Epoch 3/10 582/582 [==============================] - 71s 122ms/step - loss: 0.6102 - accuracy: 0.6479 - val_loss: 0.6191 - val_accuracy: 0.6858 Epoch 4/10 582/582 [==============================] - 70s 121ms/step - loss: 0.5850 - accuracy: 0.6729 - val_loss: 0.5983 - val_accuracy: 0.6634 Epoch 5/10 582/582 [==============================] - 71s 122ms/step - loss: 0.5620 - accuracy: 0.6954 - val_loss: 0.6043 - val_accuracy: 0.6573 Epoch 6/10 582/582 [==============================] - 71s 122ms/step - loss: 0.5383 - accuracy: 0.7128 - val_loss: 0.5575 - val_accuracy: 0.6935 Epoch 7/10 582/582 [==============================] - 71s 122ms/step - loss: 0.5179 - accuracy: 0.7291 - val_loss: 0.6238 - val_accuracy: 0.7220 Epoch 8/10 582/582 [==============================] - 70s 121ms/step - loss: 0.4906 - accuracy: 0.7491 - val_loss: 0.5965 - val_accuracy: 0.6905 Epoch 9/10 582/582 [==============================] - 70s 121ms/step - loss: 0.4636 - accuracy: 0.7711 - val_loss: 0.5580 - val_accuracy: 0.7310 Epoch 10/10 582/582 [==============================] - 70s 120ms/step - loss: 0.4292 - accuracy: 0.7894 - val_loss: 0.5737 - val_accuracy: 0.7233

In this case, the loss and the accuracy are going into the right direction
Code to reproduce the issue
Opened the Google Colab notebook, run all the cells up to section named Create the base model from the pre-trained convnets. Modified the cell first cell under this heading to the following:
`IMG_SHAPE = (IMG_SIZE, IMG_SIZE, 3)
#Create the base model from the pre-trained model MobileNet V2
base_model = tf.keras.applications.MobileNetV2(input_shape=IMG_SHAPE,
include_top=False,
#weights='imagenet')
weights=None)
base_model.trainable = True
Then proceed by running the following cells inside the notebook, which create the classification head:global_average_layer = tf.keras.layers.GlobalAveragePooling2D()
feature_batch_average = global_average_layer(feature_batch)
print(feature_batch_average.shape)
prediction_layer = keras.layers.Dense(1)
prediction_batch = prediction_layer(feature_batch_average)
print(prediction_batch.shape)
model = tf.keras.Sequential([
base_model,
global_average_layer,
prediction_layer
])
Compile the model as in the tutorial, with the same parameters:base_learning_rate = 0.0001
model.compile(optimizer=tf.keras.optimizers.RMSprop(lr=base_learning_rate),
loss=tf.keras.losses.BinaryCrossentropy(from_logits=True),
metrics=['accuracy'])`
Then train the model. The initial loss is 0.69 and initial accuracy is 0.51:
`num_train, num_val, num_test = (
metadata.splits['train'].num_examples*weight/10
for weight in SPLIT_WEIGHTS
)
initial_epochs = 10
steps_per_epoch = round(num_train)//BATCH_SIZE
validation_steps=20
loss0,accuracy0 = model.evaluate(validation_batches, steps = validation_steps)
history = model.fit(train_batches,
epochs=initial_epochs,
validation_data=validation_batches)
`

I have tried MobileNet V1, MobileNet V2 and ResNet backbone to train the same classification model with weights=None. Only MobileNet V2's validation loss and accuray does not go down.
Finally I figured out that the reason is the default momentum of batch normalization layer of MobileNet V2 is 0.999 which is too large. In pytorch it is default set to 0.9 and in tensorflow2 is default  set to 0.99. After changing batch norm momentum to 0.99, the model works.

@AirBobby do you mind showing how you changed this value from the existing MobileNetV2 model class? Nice find btw, quite tricky to solve.

I solved my issue using @AirBobby's comment, as follows.
for layer in mobilenet_model.layers:     if type(layer)==type(tf.keras.layers.BatchNormalization()):         layer.momentum=0.9

Issue persists on TF2.8, and setting momentum=0.9 seems to solve the issue. But this should be fixed within TensorFlow.

I can reproduce the same issue with TF2.10.0. Interestingly it seems that the problem is related to the inference mode only --- when I call the model with training=True on the test_dataset I get a similar accuracy as for the training_dataset.
I think this is indeed something that requires fixing.


Dataflow FlagStat

FlagStat is a good example of a Reads only walker that has a custom reduction step.  It should be order independent and doesn't require any special keying.

the requirement is that the FlagStatIntegrationTest pass when run on dataflow.


Add support for setting minutes along with days in PAT generation

Feature description 💡
With the addition of team "personal access tokens" it might be good to increase granularity when it comes to token expiry. Sometimes I'd like to create "one off" tokens for a team and keeping that token active for 1 day seems like a long time for these types of tokens.
Anything else?
No response

Hello @sigurdurf
This does not require a lot of work, I just need to add some logic to this part of the code
https://github.com/AzBuilder/terrakube/blob/main/api/src/main/java/org/terrakube/api/plugin/token/team/TeamTokenService.java#L65
https://github.com/AzBuilder/terrakube/blob/main/api/src/main/java/org/terrakube/api/plugin/token/pat/PatService.java#L50
I will try to add it during the following days when I have some free time


stone-kingdoms: 0.5.0 -> 0.6.0

Description of changes
https://gitlab.com/stone-kingdoms/stone-kingdoms/-/blob/0.6.0/CHANGELOG.md
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3459

Result of nixpkgs-review pr 288327 run on x86_64-linux 1

1 package built:

stone-kingdoms


 Low, Medium and High. But there’s a problem. When I adjust the speed to 25%(Low) then medium will go to 26% then 27% to high then back to 28% Low.
Is there a way to stop this behaviour by checking if the requested speed is close to the current speed then no IR signal will be sent. Example, current speed is at 25% then if requested speed is 26% don’t send any new IR signal since is closer to 25% which is already at low speed.
Here’s my config.
{
                    "name": "Fan",
                    "type": "fan",
                    "hideV1Fan": "true",
                    "data": {
                        "on": "26006c0070731b571b571b1e1b571b571b571b1e1b1e1b1e1c1d1c1e1b571b1e1b1e1b571b1e1b1e1c1e1a581b561c561c561a581b1e1c0005266f741c561b571b1e1c561b571b571b1e1c1d1c1e1b1e1a1f1b571b1e1b1e1b571b1e1b1f1b1e1b571b571a581b561c561c1e1b000d05000000000000000000000000",
                        "off": "26006c0070731b571b571b1e1b571b571b571b1e1b1e1b1e1c1d1c1e1b571b1e1b1e1b571b1e1b1e1c1e1a581b561c561c561a581b1e1c0005266f741c561b571b1e1c561b571b571b1e1c1d1c1e1b1e1a1f1b571b1e1b1e1b571b1e1b1f1b1e1b571b571a581b561c561c1e1b000d05000000000000000000000000",
                        "swingToggle": "26006c0070741b571b571b1e1b571a571b571c561c1e1b561c561b571b1f1b1e1a1f1b571b1e1a1f1b1f1b1e1b571b1e1b1e1b1e1b571c00052670731a581b571b1e1b571b561b581b561c1e1a571c561c561b1f1b1e1a1f1a581b1e1b1e1b1f1b1e1a581b1e1b1e1b1e1b571b000d05000000000000000000000000",
                        "fanSpeed25": "26006c0070731b571b571b1e1b571b571b571b1e1b1e1b1e1c1d1c1e1b571b1e1b1e1b571b1e1b1e1c1e1a581b561c561c561a581b1e1c0005266f741c561b571b1e1c561b571b571b1e1c1d1c1e1b1e1a1f1b571b1e1b1e1b571b1e1b1f1b1e1b571b571a581b561c561c1e1b000d02000000000000000000000000",
                        "fanSpeed50": "260036006f751b561c561c1e1b561b571a581b571a581a581a581a571b1f1a1f1a1f1c561a1f1b1f1b1e1b1e1a1f1b1f1a1f1a1f1a581b000d050000",
                        "fanSpeed100": "260036006f751b561c561c1e1b561b571a581b571a581a581a581a571b1f1a1f1a1f1c561a1f1b1f1b1e1b1e1a1f1b1f1a1f1a1f1a581b000d050000"
                    }

That's not something I'm looking to implement at the moment, sorry.
You can make it work with what you have though:
Change "fanSpeed25" to "fanSpeed37"
Change "fanSpeed50" to "fanSpeed62"

Hi, actually I meant is it possible to make the fan speed 'snap' at specific percentage and only send code when at the percentage.
BTW. Thanks for the work and commitment ! I see a lot of releases today and should i update now because v2.5.16 is stable for me.

Ah I see, I'll have a think on that one. I also just noticed you're wrapping quotes around true - make sure true/false use { example: true } rather than { example: "true" }
It's hard to tell - I've just fixed a couple of issues people have raised but there are a lot of options to consider. It's been stable for me though...and I'm around to fix things.
I'll be adding tests in the near future so that I can be more confident about it's stability.

I got this error after i update.
/usr/local/lib/node_modules/homebridge-broadlink-rm/accessories/fan.js:48
if (showRotationDirection !== false) showRotationDirection = true
^
ReferenceError: showRotationDirection is not defined
at FanAccessory.getServices (/usr/local/lib/node_modules/homebridge-broadlink-rm/accessories/fan.js:48:9)
at Server._createAccessory (/usr/local/lib/node_modules/homebridge/lib/server.js:388:36)
at Server. (/usr/local/lib/node_modules/homebridge/lib/server.js:374:32)
at /usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/util/once.js:16:19
at BroadlinkRMPlatform.accessories (/usr/local/lib/node_modules/homebridge-broadlink-rm/node_modules/homebridge-platform-helper/platform.js:40:5)
at Server._loadPlatformAccessories (/usr/local/lib/node_modules/homebridge/lib/server.js:364:20)
at Server._loadPlatforms (/usr/local/lib/node_modules/homebridge/lib/server.js:308:16)
at Server.run (/usr/local/lib/node_modules/homebridge/lib/server.js:85:36)
at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:40:10)
at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)

Hi, how can i fix this?
/usr/local/lib/node_modules/homebridge-broadlink-rm/accessories/fan.js:46
if (showV2Fan !== false) showV2Fan = true
^
TypeError: Assignment to constant variable.
at FanAccessory.getServices (/usr/local/lib/node_modules/homebridge-broadlin                               k-rm/accessories/fan.js:46:40)
at Server._createAccessory (/usr/local/lib/node_modules/homebridge/lib/serve                               r.js:388:36)
at Server. (/usr/local/lib/node_modules/homebridge/lib/server.js:                               374:32)
at /usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/util/o                               nce.js:16:19
at BroadlinkRMPlatform.accessories (/usr/local/lib/node_modules/homebridge-b                               roadlink-rm/node_modules/homebridge-platform-helper/platform.js:40:5)
at Server._loadPlatformAccessories (/usr/local/lib/node_modules/homebridge/l                               ib/server.js:364:20)
at Server._loadPlatforms (/usr/local/lib/node_modules/homebridge/lib/server.                               js:308:16)
at Server.run (/usr/local/lib/node_modules/homebridge/lib/server.js:85:36)
at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:40:10)
at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge                               :17:22)

Fixed in 2.6.4

Sry for bring this issue up again.. since v3 is here will we ever get a ‘snap fan speed’?

Would it work well for you if the fan as to work like the light currently does?

Forget that, it does work like the light does.
I'm still unsure what the issue is sorry!
The following config should allow for low, medium and high hex codes:
{
    "name": "Fan",
    "type": "fan",
    "data": {
        "on": "ON_HEX",
        "off": "OFF_HEX",
        "swingToggle": "SWING_HEX",
        "fanSpeed25": "LOW_HEX",
        "fanSpeed50": "MEDIUM_HEX",
        "fanSpeed75": "HIGH_HEX",
    }
}

Any speed from 1% to  36% will then send LOW_HEX
Any speed from 37% to 62% will then send MEDIUM_HEX
Any speed from 63% to 100% will then send HIGH_HEX

That’s what I did. But the hex code fired every time I adjust the slider regardless of %. Is it possible to not send the same hex code again if the fan speed is already on/within the selected current speed

Got it - version 3.0.3 will prevent the same code from being sent multiple times.

That’s fast! Thank you very much!


Fix image sink override warning

Fixing warning:
[CTest: warning matched] /Users/builder/externalModules/Core/Common/include/itkImageSink.h:140:3: warning: '~ImageSink' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override]
  ~ImageSink() = default;
  ^

This patch should be merged into the release and master branches.

I changed the PR to target the release branch instead of the master branch. Matt's commit is not in the master branch.

Also merged to master.


[WebUI] 2.2.5 Bug Fixes

Fixing up some bugs before the final release.

Fixed Number Input stepper not respecting the min and max values assigned to the number input.
Fixed the Slider input box not accommodating 4 digit numbers in width.
Added RU localization for Model Manager and Tooltips @netsvetaev

@dreglad The EN tooltips were slightly updated by @netsvetaev. Please let me know if the ES ones need any updating. I'll include it in this PR. Thank you.

@lstein This will be the final merge for the WebUI 2.2.5. Please dont release until this is merged. Let me know when you intend to. So I can finalize and merge this.


Escalate privileges if needed

Let's say I want to copy a file owned by a user into root's folder.
Wouldn't it be great to  be asked for a password for that operation?
Thank you.

I'm not sure how to elevate privileges for a running process

I think there's a crate called sudo, with a method named escalate_if_needed, but I'm not sure if this can help.

I've looked at its source code, and it simply calls sudo to start a new process and then exits the current process. These operations need to be done at startup, meaning Yazi must always run as root, rather than truly "on-demand", which is unacceptable in many cases where root privileges are not available.
https://gitlab.com/dns2utf8/sudo.rs/-/blob/main/src/lib.rs?ref_type=heads

You're right

Closing as not possible


enable 'includeAll' directive to work with liquibase resources provided in OSGi bundle

Environment
Liquibase Version: 4.4.0
Liquibase Integration & Version: liquibase-core 4.4.0 as a bundle in Apache Felix OSGi container, Liferay portal 7.4
Liquibase Extension(s) & Version:
Database Vendor & Version: Postgresql 11.4
Operating System Type & Version: Linux
Pull Request Type

[ ] Bug fix (non-breaking change which fixes an issue.)
[x] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
I've succesfully used liquibase-core deployed as a bundle to Liferay Portal. Another sibling bundle provided changelog.xml together with BundleActivator code which executed the changelog.xml just fine.
I wanted to organize migration steps in separate files under a directory and used includeAll changelog.xml directive. The executor code however haven't found any of the migration files except for the entrypoint changelog.xml in which includeAll directive was declared.
BundleActivator.java:
        ...
        ResourceAccessor resourceAccessor = new OSGIResourceAccessor(BundleActivator.class);
        try (Liquibase liquibase = new Liquibase("changelog.xml", resourceAccessor, database)) {
            LockServiceFactory.reset();
            liquibase.update(new Contexts());
        }
        ...

The pull requests contains modification of existing OSGiResourceAccessor class so that it supports traversing of an OSGi bundle directory structure which provides entrypoint changelog.xml and migration resources/paths declared in it.
Steps To Reproduce

Prepare OSGi bundle with following changelog.xml resource:

<?xml version="1.0" encoding="UTF-8"?>

<databaseChangeLog
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd">

    <includeAll path="steps/" relativeToChangelogFile="true"/>

</databaseChangeLog>

Add migration step steps/0001-init.xml:

<?xml version="1.0" encoding="UTF-8"?>

<databaseChangeLog
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd">

    <changeSet id="1_add-initial-schema" author="ktor">
        <createTable tableName="test">
            <column name="id" type="uuid">
                <constraints primaryKey="true" nullable="false"/>
            </column>
        </createTable>
    </changeSet>
</databaseChangeLog>

Actual Behavior
changelog.xml is read however no resources in steps/ bundle directory are loaded.
Expected/Desired Behavior
changelog.xml is read and resources in steps/ bundle directory are loaded.
Screenshots (if appropriate)
n/a
Additional Context
n/a
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Added Test Harness Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel

@ktor thanks for the patch and sorry for the delay to evaluate it. I donwloaded your branch and updated it with master, but I found out that we did some changes to ResourceAccessor inteface that broke your code. Basically search and getAll methods were added while list and openStream were deprecated.

Would you be able to update your code to implement those methods?  I'll keep the pr assigned to me so we can get it moving now. Thanks!

Would you be able to update your code to implement those methods? I'll keep the pr assigned to me so we can get it moving now. Thanks!

Hi @filipelautert, I may get to it over the weekend.

Hi @ktor , do you think you can review it soon? If so we can make it into 4.18 release.

I think this was fixed as part of #3378 that went out in 4.21.0.
If anyone is still having this problem, let us know.


Failure to install the windows preview version

Error: spawn C:\Users\raymond.chiu\AppData\Local\Programs\kit\resources\fallbacks\windows\clipboard_x86_64.exe ENOENT
    at r (C:\Users\raymond.chiu\AppData\Local\Programs\kit\resources\app.asar\main.prod.js:2:543688)
    at n (C:\Users\raymond.chiu\AppData\Local\Programs\kit\resources\app.asar\main.prod.js:2:543859)
    at ChildProcess.e.emit (C:\Users\raymond.chiu\AppData\Local\Programs\kit\resources\app.asar\main.prod.js:2:544000)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)

Kit 1.40.62
Electron 22.0.0
win32 10.0.19044
Locale: en-US

I got the same error - Running the npx command listed on the top of this: https://github.com/johnlindquist/kit/issues/1056 worked for me.
However, upon restarting kit, I get the same error when just opening the program. It seems to look for a kit\resources\fallbacks\windows\clipboard_x86_64.exe file, however I don't see the resources directory. Can you confirm?

@xenoxsis Can you check your logs at:
~/Library/Logs/Kit.app/main.log

The clipboard error is misleading because it's trying to copy the error from the logs to the clipboard.

@xenoxsis Also, did you try the pre-release build? It fixed for this user: https://github.com/johnlindquist/kit/issues/1040#issuecomment-1404167114
Download from here:
https://github.com/johnlindquist/kitapp/releases/tag/v1.40.65


Add dot-product kernel with multiplier reuse

Starting work on #411 with a simple dot-product kernel that expresses multiplier reuse! Tagging @gabizon103 for review!

Okay, this implementation works and has a test now! We should probably generalize the test a bit more and make we can execute Dot multiple times.

@gabizon103 can you take over the merging of this PR. Either:

Decide that your implementation strictly subsumes this and therefore this PR should be closed, or
Add this in a different folder as a comparison point

Yes, will take care of it!


fix(pages): fix type when importing signin component

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: several improvements around

Current dependencies on/for this PR:

main

PR #138   👈

This stack of pull requests is managed by Graphite.


proxy error L curl: (52) Empty reply from server

$ curl http://<IP_ADDRESS>:8081/v1/chat/completions  -H "Content-Type: application/json"  -H "Authorization: Bearer $API_KEY"  -d '{
"model": "gpt-4",
"messages": [{"role": "user", "content": "Say this is a test!"}],
"temperature": 0.7
}'
curl: (52) Empty reply from server
Here's the docker:
$ docker ps -a
CONTAINER ID   IMAGE                               COMMAND         CREATED         STATUS         PORTS                    NAMES
9a49c5c0b3e4   zhu327/gemini-openai-proxy:latest   "/app/gemini"   3 minutes ago   Up 3 minutes   <IP_ADDRESS>:8081->8081/tcp   gemini

curl 'https://generativelanguage.googleapis.com/v1beta/models?key=<YOUR_API_KEY>'
Please confirm that you have access to gemini-1.0-ultra-latest or gemini-1.5-pro-latest

models/gemini-1.0-pro
models/gemini-1.0-pro-001
models/gemini-1.0-pro-latest
models/gemini-1.0-pro-vision-latest
models/gemini-pro
models/gemini-pro-vision
Which OAI model is supported?

Model Mapping:
gpt-3.5-turbo -> gemini-1.0-pro-latest
gpt-4 -> gemini-1.0-ultra-latest
gpt-4-turbo-preview -> gemini-1.5-pro-latest
gpt-4-vision-preview -> gemini-1.0-pro-vision-latest

Can I modify it so that
gpt-3.5-turbo -> gemini-1.0-pro
gpt-4 -> gemini-1.0-pro-latest
gpt-4-turbo-preview -> gemini-1.0-pro-latest
gpt-4-vision-preview -> gemini-pro-vision

You should modify the code by yourself

You should modify the code by yourself

Can you point to the code where it can be changed?


[Bug] onAuthStateChanged gets fired way too many times

More info
https://firebase.google.com/docs/auth/web/start
Repro:

Have a Firebase user created
Make sure that user is logged out of device
Select Sign In With Spotify
Go through the deep link flow
Check logs to see redux flow

Expected Results
The onAuthStateChanged listener in App.js SHOULD be triggered, but our logic to keep it from moving onto the SignInUser action
Actual Results
The onAuthStateChanged listener is fired in App.js and our logic to block it from continuing does not seem to work at all.

FIXED with our somewhat hacky way


(maint) fix spec test failures against puppet master

A recent patch to Puppet broke several of our spec tests. This corrects
the ones that are due to a changed error message. There are some other
failures that are due to what seems like a Puppet bug to me. I'll wait
to get confirmation before changing those ones.

Test PASSed

CLA signed by all contributors.

@wkalt This is failing spec tests in travis

Test PASSed


Tweak description of the search() method

Change the description of the search() method to be consistent with what's used in append() and moveMessage(), i.e. "the currently open mailbox".

Cross-referencing https://github.com/DefinitelyTyped/DefinitelyTyped/pull/33234

thanks!

Thank you for the quick merging :)


office ui fabric core is a dependency not a DEV dependency in 1.5.1

Category

[x] Content fix
[ ] New article

What's in this Pull Request?
Fix Office UI Fabric docs to as CSS core project was implied as a dev dependency when it's not in the latest generator

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/office-ui-fabric-integration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx AC, appreciated.


Make it compatible with browserify/require js

I had to hack waypoints to make it work with browserify, as this is incorrectly set when requiring it in.
The change I made was to the arguments being passed in to the self executing function, on the last line of waypoints:
})(jQuery, 'waypoint', 'waypoints', window);

Looking for an up, i'm on it actually with browserify + vueify (vueJS) :( @cappslock  @cjroebuck  @imakewebthings


Add boolean toggle to download unlimited strength JCE policy files

As anyone who's using Jruby / Rails will know, when you invoke any form of crypto operation through your Rails server on a vanilla install of Oracle JVM, you will normally get the following error:
"OpenSSL::Cipher::CipherError: Illegal key size: possibly you need to install Java Cryptography Extension (JCE) Unlimited Strength Jurisdiction Policy Files for your JRE"
Running on a machine with an Oracle JVM provisioned using this cookbook is no exception, as the cookbook doesn't seem to do anything about these files when it runs the oracle installer.
Would it be possible to add a boolean toggle for the cookbook to automate obtaining these JCE jar files and installing them in the right place? It would default to false to stay in line with US export policy. I envisage it working much like the existing "java" => "oracle" => "accept_oracle_download_terms", so it could be called something like "java" => "oracle" => "accept_unlimited_strength_jce_download_terms".
I don't know if the other JVM variants (e.g. IBM's one) also have this restriction, but if they do, probably best to add it as a provider-specific option in each case, rather than a blanket parameter at the top level, because OpenJDK just seems to turn on unlimited strength crypto by default.
For additional brownie points, when the toggle is set to true, you could log out one of those scary legalese warnings saying that the user has explicitly chosen to turn on unlimited strength crypto, which may put them in violation of US export policy.

:+1: Also need this!

This is in 1.31.0 released today.


Push the runtime filter from HashJoin down to SeqScan or AM.

+----------+  AttrFilter   +------+  ScanKey   +------------+
| HashJoin | ------------> | Hash | ---------> | SeqScan/AM |
+----------+               +------+            +------------+
If "gp_enable_runtime_filter_pushdown" is on, three steps will be run:
Step 1. In ExecInitHashJoin(), try to find the mapper between the var in
hashclauses and the var in SeqScan. If found we will save the mapper in
AttrFilter and push them to Hash node;
Step 2. We will create the range/bloom filters in AttrFilter during building
hash table, and these filters will be converted to the list of ScanKey
and pushed down to Seqscan when the building finishes;
Step 3. If AM support SCAN_SUPPORT_RUNTIME_FILTER, these ScanKeys will be pushed
down to the AM module further, otherwise will be used to filter slot in
Seqscan;
perf:
CPU E5-2680 v2 10 cores, memory 32GB, 3 segments

tpcds 10s off: 865s on: 716s 17%
tpcds 100s off: 4592s on: 3751s 18%

Fixes #ISSUE_Number
What does this PR do?

Type of Change

[ ] Bug fix (non-breaking change)
[ ] New feature (non-breaking change)
[ ] Breaking change (fix or feature with breaking changes)
[ ] Documentation update

Breaking Changes

Test Plan

[ ] Unit tests added/updated
[ ] Integration tests added/updated
[ ] Passed make installcheck
[ ] Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

[ ] Followed contribution guide
[ ] Added/updated documentation
[ ] Reviewed code for security implications
[ ] Requested review from cloudberry committers

Additional Context

⚠ To skip CI: Add [skip ci] to your PR title. Only use when necessary! ⚠

Looks interesting. And I have some questions to discuss.

Beside the seqscan, can the runtime filter apply to other types of scan? such as the index scan.
Looks only when the hashjoin node and seqscan node run in the same process can use the runtime filter. Which means the tables should have same distributed policy on the join columns or one of the table is replicated.

Looks interesting. And I have some questions to discuss.

Beside the seqscan, can the runtime filter apply to other types of scan? such as the index scan.
Looks only when the hashjoin node and seqscan node run in the same process can use the runtime filter. Which means the tables should have same distributed policy on the join columns or one of the table is replicated.

There are codes changed  in MultiExecParallelHash, please add some parallel tests with runtime filter.

There are codes changed in MultiExecParallelHash, please add some parallel tests with runtime filter.

got it.

Looks interesting. And I have some questions to discuss.

Beside the seqscan, can the runtime filter apply to other types of scan? such as the index scan.
Looks only when the hashjoin node and seqscan node run in the same process can use the runtime filter. Which means the tables should have same distributed policy on the join columns or one of the table is replicated.

Beside the seqscan, can the runtime filter apply to other types of scan? such as the index scan.

Theoretically, it is feasible to apply runtime filters to operators such as Index Scan. However, because Index Scan already reduces data volume by leveraging an optimized storage structure, the performance gains from applying runtime filters to Index Scan would likely be minimal. Thus, I think that applying runtime filters to Index Scan would not yield significant performance benefits.

In subsequent work, when we discover that other scan operators can achieve notable performance improvements from pushdown runtime filters, we will support these operators. Our focus will be on operators where runtime filters can substantially decrease the amount of data processed early in the query execution, leading to more pronounced performance enhancements.

Looks only when the hashjoin node and seqscan node run in the same process can use the runtime filter. Which means the tables should have same distributed policy on the join columns or one of the table is replicated.

Yes, the current pushdown runtime filter only supports in-process pushdown, which means that the Hash Join and SeqScan need to be within the same process. The design and implementation of cross-process pushdown runtime filters are much more complex.

This limitation arises because coordinating and sharing data structures like Bloom filters or other runtime filters across different processes involves additional challenges such as inter-process communication (IPC), synchronization, and ensuring consistency and efficiency of the filters across process boundaries. Addressing these issues requires a more sophisticated design that can handle the complexities of distributed computing environments.

Hi, with gp_enable_runtime_filter_pushdown = on, execute SQL below will get a crash:
gpadmin=# show gp_enable_runtime_filter_pushdown;
 gp_enable_runtime_filter_pushdown
-----------------------------------
 on
(1 row)

CREATE TABLE test_tablesample (dist int, id int, name text) WITH (fillfactor=10) DISTRIBUTED BY (dist);
-- use fillfactor so we don't have to load too much data to get multiple pages

-- Changed the column length in order to match the expected results based on relation's blocksz
INSERT INTO test_tablesample SELECT 0, i, repeat(i::text, 875) FROM generate_series(0, 9) s(i) ORDER BY i;
INSERT INTO test_tablesample SELECT 3, i, repeat(i::text, 875) FROM generate_series(10, 19) s(i) ORDER BY i;
INSERT INTO test_tablesample SELECT 5, i, repeat(i::text, 875) FROM generate_series(20, 29) s(i) ORDER BY i;
EXPLAIN (COSTS OFF)
  SELECT id FROM test_tablesample TABLESAMPLE SYSTEM (50) REPEATABLE (2);
FATAL:  Unexpected internal error (assert.c:48)
DETAIL:  FailedAssertion("IsA(planstate, SeqScanState)", File: "explain.c", Line: 4154)
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Succeeded.
psql (14.4, server 14.4)

```sql
gpadmin=# show gp_enable_runtime_filter_pushdown;
 gp_enable_runtime_filter_pushdown
-----------------------------------
 on
(1 row)

CREATE TABLE test_tablesample (dist int, id int, name text) WITH (fillfactor=10) DISTRIBUTED BY (dist);
-- use fillfactor so we don't have to load too much data to get multiple pages

-- Changed the column length in order to match the expected results based on relation's blocksz
INSERT INTO test_tablesample SELECT 0, i, repeat(i::text, 875) FROM generate_series(0, 9) s(i) ORDER BY i;
INSERT INTO test_tablesample SELECT 3, i, repeat(i::text, 875) FROM generate_series(10, 19) s(i) ORDER BY i;
INSERT INTO test_tablesample SELECT 5, i, repeat(i::text, 875) FROM generate_series(20, 29) s(i) ORDER BY i;
EXPLAIN (COSTS OFF)
  SELECT id FROM test_tablesample TABLESAMPLE SYSTEM (50) REPEATABLE (2);
FATAL:  Unexpected internal error (assert.c:48)
DETAIL:  FailedAssertion("IsA(planstate, SeqScanState)", File: "explain.c", Line: 4154)
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Succeeded.
psql (14.4, server 14.4)

Thanks, I'll reproduce the issue and fix it.

Thanks for your detailed explanation.

Looks interesting. And I have some questions to discuss.

Beside the seqscan, can the runtime filter apply to other types of scan? such as the index scan.
Looks only when the hashjoin node and seqscan node run in the same process can use the runtime filter. Which means the tables should have same distributed policy on the join columns or one of the table is replicated.

Beside the seqscan, can the runtime filter apply to other types of scan? such as the index scan.

Theoretically, it is feasible to apply runtime filters to operators such as Index Scan. However, because Index Scan already reduces data volume by leveraging an optimized storage structure, the performance gains from applying runtime filters to Index Scan would likely be minimal. Thus, I think that applying runtime filters to Index Scan would not yield significant performance benefits.

Make sense. When doing hashjoin, index scan or index only scan are often not used on probe node.

In subsequent work, when we discover that other scan operators can achieve notable performance improvements from pushdown runtime filters, we will support these operators. Our focus will be on operators where runtime filters can substantially decrease the amount of data processed early in the query execution, leading to more pronounced performance enhancements.

Looks only when the hashjoin node and seqscan node run in the same process can use the runtime filter. Which means the tables should have same distributed policy on the join columns or one of the table is replicated.

Yes, the current pushdown runtime filter only supports in-process pushdown, which means that the Hash Join and SeqScan need to be within the same process. The design and implementation of cross-process pushdown runtime filters are much more complex.

This limitation arises because coordinating and sharing data structures like Bloom filters or other runtime filters across different processes involves additional challenges such as inter-process communication (IPC), synchronization, and ensuring consistency and efficiency of the filters across process boundaries. Addressing these issues requires a more sophisticated design that can handle the complexities of distributed computing environments.

Exactly, and if  there is any lock  used to solve the problem may even lead bad performance.

 explain analyze
SELECT count(t1.c3) FROM t1, t3 WHERE t1.c1 = t3.c1 ;
                                                              QUERY PLAN

-----------------------------------------------------------------------------------------
----------------------------------------------
 Finalize Aggregate  (cost=1700.07..1700.08 rows=1 width=8) (actual time=32119.566..32119
.571 rows=1 loops=1)
   ->  Gather Motion 3:1  (slice1; segments: 3)  (cost=1700.02..1700.07 rows=3 width=8) (
actual time=30.967..32119.550 rows=3 loops=1)
         ->  Partial Aggregate  (cost=1700.02..1700.03 rows=1 width=8) (actual time=32119
.131..32119.135 rows=1 loops=1)
               ->  Hash Join  (cost=771.01..1616.68 rows=33334 width=4) (actual time=14.0
59..32116.962 rows=33462 loops=1)
                     Hash Cond: (t3.c1 = t1.c1)
                     Extra Text: (seg0)   Hash chain length 1.0 avg, 3 max, using 32439 o
f 524288 buckets.
                     ->  Seq Scan on t3  (cost=0.00..387.34 rows=33334 width=4) (actual t
ime=0.028..32089.490 rows=33462 loops=1)
                     ->  Hash  (cost=354.34..354.34 rows=33334 width=8) (actual time=13.2
57..13.259 rows=33462 loops=1)
                           Buckets: 524288  Batches: 1  Memory Usage: 5404kB
                           ->  Seq Scan on t1  (cost=0.00..354.34 rows=33334 width=8) (ac
tual time=0.180..4.877 rows=33462 loops=1)
 Planning Time: 0.227 ms

runtime_filter has been pushed down to t3 table seqscan, but 'explain analyze' doesn't print them out.
\d t1
                 Table "public.t1"
 Column |  Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
 c1     | integer |           |          |
 c2     | integer |           |          |
 c3     | integer |           |          |
 c4     | integer |           |          |
 c5     | integer |           |          |
Checksum: t
Indexes:
    "t1_c2" btree (c2)
Distributed by: (c1)

 \d t3
                 Table "public.t3"
 Column |  Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
 c1     | integer |           |          |
 c2     | integer |           |          |
 c3     | integer |           |          |
 c4     | integer |           |          |
 c5     | integer |           |          |
Distributed by: (c1)

 explain analyze
SELECT count(t1.c3) FROM t1, t3 WHERE t1.c1 = t3.c1 ;
                                                              QUERY PLAN

-----------------------------------------------------------------------------------------
----------------------------------------------
 Finalize Aggregate  (cost=1700.07..1700.08 rows=1 width=8) (actual time=32119.566..32119
.571 rows=1 loops=1)
   ->  Gather Motion 3:1  (slice1; segments: 3)  (cost=1700.02..1700.07 rows=3 width=8) (
actual time=30.967..32119.550 rows=3 loops=1)
         ->  Partial Aggregate  (cost=1700.02..1700.03 rows=1 width=8) (actual time=32119
.131..32119.135 rows=1 loops=1)
               ->  Hash Join  (cost=771.01..1616.68 rows=33334 width=4) (actual time=14.0
59..32116.962 rows=33462 loops=1)
                     Hash Cond: (t3.c1 = t1.c1)
                     Extra Text: (seg0)   Hash chain length 1.0 avg, 3 max, using 32439 o
f 524288 buckets.
                     ->  Seq Scan on t3  (cost=0.00..387.34 rows=33334 width=4) (actual t
ime=0.028..32089.490 rows=33462 loops=1)
                     ->  Hash  (cost=354.34..354.34 rows=33334 width=8) (actual time=13.2
57..13.259 rows=33462 loops=1)
                           Buckets: 524288  Batches: 1  Memory Usage: 5404kB
                           ->  Seq Scan on t1  (cost=0.00..354.34 rows=33334 width=8) (ac
tual time=0.180..4.877 rows=33462 loops=1)
 Planning Time: 0.227 ms

runtime_filter has been pushed down to t3 table seqscan, but 'explain analyze' doesn't print them out.
\d t1
                 Table "public.t1"
 Column |  Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
 c1     | integer |           |          |
 c2     | integer |           |          |
 c3     | integer |           |          |
 c4     | integer |           |          |
 c5     | integer |           |          |
Checksum: t
Indexes:
    "t1_c2" btree (c2)
Distributed by: (c1)

 \d t3
                 Table "public.t3"
 Column |  Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
 c1     | integer |           |          |
 c2     | integer |           |          |
 c3     | integer |           |          |
 c4     | integer |           |          |
 c5     | integer |           |          |
Distributed by: (c1)

Thanks for your test case. Based on these, I rewrote code to ensure that debug info are always displayed even when the number of filtered rows is zero. And add the test case into gp_runtime_filter.sql too.
fix in https://github.com/apache/cloudberry/commit/98dac6dfc7d5e44e111aa16bdf5948d07ee2eb00

Hi, with gp_enable_runtime_filter_pushdown = on, execute SQL below will get a crash:
gpadmin=# show gp_enable_runtime_filter_pushdown;
 gp_enable_runtime_filter_pushdown
-----------------------------------
 on
(1 row)

CREATE TABLE test_tablesample (dist int, id int, name text) WITH (fillfactor=10) DISTRIBUTED BY (dist);
-- use fillfactor so we don't have to load too much data to get multiple pages

-- Changed the column length in order to match the expected results based on relation's blocksz
INSERT INTO test_tablesample SELECT 0, i, repeat(i::text, 875) FROM generate_series(0, 9) s(i) ORDER BY i;
INSERT INTO test_tablesample SELECT 3, i, repeat(i::text, 875) FROM generate_series(10, 19) s(i) ORDER BY i;
INSERT INTO test_tablesample SELECT 5, i, repeat(i::text, 875) FROM generate_series(20, 29) s(i) ORDER BY i;
EXPLAIN (COSTS OFF)
  SELECT id FROM test_tablesample TABLESAMPLE SYSTEM (50) REPEATABLE (2);
FATAL:  Unexpected internal error (assert.c:48)
DETAIL:  FailedAssertion("IsA(planstate, SeqScanState)", File: "explain.c", Line: 4154)
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Succeeded.
psql (14.4, server 14.4)

hanks for your test case. I fix it in https://github.com/apache/cloudberry/commit/98dac6dfc7d5e44e111aa16bdf5948d07ee2eb00 And add the test case into gp_runtime_filter.sql too.
fix in https://github.com/apache/cloudberry/commit/98dac6dfc7d5e44e111aa16bdf5948d07ee2eb00

Hi @zhangyue-hashdata
I see that previous runtime filter implementation relies on some cost model at try_runtime_filter(). Do I understand it correctly, that this PR does not do any cost evaluation?
Also for TPC-H/TPC-DS can you provide results for each query separately?
Asking mostly out of curiosity, I see here are quite a few reviewers here already :)

Hi @zhangyue-hashdata I see that previous runtime filter implementation relies on some cost model at try_runtime_filter(). Do I understand it correctly, that this PR does not do any cost evaluation? Also for TPC-H/TPC-DS can you provide results for each query separately?
Asking mostly out of curiosity, I see here are quite a few reviewers here already :)

Basically, you're correct. Because our goal is to filter out as much data as possible right at the point of data generation. However, this will lead to very complex evaluations, so we only made a simple estimation based on rows and work memory when creating the Bloom filter.
Furthermore, I have placed the detailed test results for TPC-DS 10s in PR description.

There are codes changed in MultiExecParallelHash, please add some parallel tests with runtime filter.

fix it in https://github.com/apache/cloudberry/pull/724/commits/7ab040ae178e9bb616bd75e0488aa6a2293d4183

from tpcds 10s details table, there are some bad cases.


Upgrade org.apache.maven.plugins:maven-clean-plugin 3.1.0 -> 3.2.0

This PR contains the following updates:

Package
Update
Change

org.apache.maven.plugins:maven-clean-plugin (source)
minor
3.1.0 -> 3.2.0

[ ] If you want to rebase/retry this PR, click this checkbox.

Suggested commit message:
Upgrade maven-clean-plugin 3.1.0 -> 3.2.0

See https://github.com/apache/maven-clean-plugin/compare/maven-clean-plugin-3.1.0...maven-clean-plugin-3.2.0


Removing an Area2D that's overlapping with another one gives annoying warning.

Godot version:

3.0.5
OS/device including version:

MacOS High Sierra
Issue description:

As the title says, removing an Area2D that is overlapping another Area2D spit out this error:
0:00:30:0687 - Condition ' !area_in && !E ' is true.
----------
Type:Error
Description:
Time: 0:00:30:0687
C Error: Condition ' !area_in && !E ' is true.
C Source: scene/2d/area_2d.cpp:262
C Function: _area_inout

And if it's overlapping with a physics body:
0:00:30:0687 - Condition ' !body_in && !E ' is true.
----------
Type:Error
Description:
Time: 0:00:30:0687
C Error: Condition ' !body_in && !E ' is true.
C Source: scene/2d/area_2d.cpp:161
C Function: _body_inout

Steps to reproduce:
For some reason, I can't reliable reproduce it in a new project, but it happens without fail in my main one. Just remove an Area2D that's overlapping with another Area2D or a KinematicBody2D.
I should mention, this doesn't crash the game but it get's pretty annoying since I don't see why doing this should output a warning. Also, some weeks ago I had found a similar issue that was fixed for the 3.0 release if I recall correctly but I think it was only fixed for 3D and not for 2D; unfortunately I can't find that issue now. If I do I'll link it on an edit or on a comment.

Ah, immediately found it. It's #17132. Also, not sure if it matters but physics engine is set to DEFAULT

There's only one physics engine for 2D, so the option makes no difference.

I had this issue when implementing transporters; I could prevent the error from occurring if I turned off monitoring before freeing the area(s), though I'm not sure if the error prints if it's turned back on (since I'm changing scenes, I don't have a chance to check.)

Removing or freeing areas? if removing, try call_deferred.

@vnen Really? I thought there was Bullet and then the one we had before 3.0. Still, the issue is there anyway.
@eon-s  I'm freeing the areas though I'm pretty sure the issue indeed happens at the moment they are removed from the tree. Using call_deferred does not fix the problem. Again, it's just a warning, everything works as intended mechanics-wise, it's just kind of annoying and doesn't seem like something worth warning the user for IMO.

Really? I thought there was Bullet and then the one we had before 3.0.

Only for 3D. Bullet is not used for 2D physics.

ERROR: _body_inout: Condition ' !body_in && !E ' is true.
   At: scene/2d/area_2d.cpp:161

I get this error by dozens everytime I finish a level. In my game, the "end" is an area that "catches" the player like a portal, and the next level is loaded as the player node is still inside (destroying current level, waiting a frame then instancing next one).
However I also have areas throughout the level for things that "grab" the player and shoot it out (like cannons), and I noticed I get way more of these errors the more cannons I have in my level, even though the player definitely exited them when the end is reached.
At the end of the day, when I finish a test session the debugger is filled with hundreds of that^^"

I am trying to fix it, but I honestly can't reproduce it with a simple example.  If you can create a simple project that would be appreciated, else I will have to close it.

It reproduces in 3.1 alpha2 too. I started getting a redux of my project to narrow it down.
So far I found that if I finish a level without taking any pickups, switching to the next level does not cause the error. My pickups have areas.

Here is a mega-redux of my project, which reproduces the error:
wallrider_test_godot31.zip
Just start the project: the character will catch a pickup, then wait until the Next Level button appears. As soon as you click, the error will appear in the console.
Hoping it's simple enough


Error: failed to get core-foundation as a dependency of package myapp

Problem
Hi.
I'm trying to use the core-foundation in a small project, but it is failing at the build stage:
    Updating crates.io index
error: failed to get `core-foundation` as a dependency of package `myapp v0.1.0 (~/myapp)`

Caused by:
  failed to load source for dependency `core-foundation`

Caused by:
  Unable to update registry `crates-io`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to authenticate when downloading repository: git@github.com:rust-lang/crates.io-index

  * attempted ssh-agent authentication, but no usernames succeeded: `git`

  if the git CLI succeeds then `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  no authentication available

Steps

cargo new myapp
cd myapp/
echo 'core-foundation = "0.9.3"' >> Cargo.toml
cargo check

Possible Solution(s)
No response
Notes
jdm from servo/core-foundation-rs commented:

That's an issue with Cargo, not with this package.

Issue: https://github.com/servo/core-foundation-rs/issues/534
Version
cargo 1.66.0 (d65d197ad 2022-11-15)

Fixed by:
eval `ssh-agent -s`
ssh-add
cargo check

Reference: https://github.com/rust-lang/cargo/issues/3381#issuecomment-308460530

Thanks for the report. I believe this is kinda a duplicate of #2078. Close in favor of that.


Email+ substring

Possible implementation to #48.
Don't have much experience with handlebars. For some reason I had to specify the arguments as strings but it works.

Thanks for the PR, Luke! Looks great; a couple of thoughts:

I'm not sure about the arguments-as-strings aspect, could be surprising to use - is there any discussion in the Handlebars.net repo about this? Numeric literals might be a missing feature there....
Could we call it substring, since elsewhere in Seq and .NET this is the function name? Trim() is usually associated with leading/trailing whitespace.

Cheers!

Yep had a look at the handlebars repo & this looks like the issue: https://github.com/rexm/Handlebars.Net/issues/41
I have pulled the latest NuGet locally (1.9.0) & it fixes the numeric literals & handles white space a lot better but the namespace got changed along the way so I needed to update the references as well.
Happy to push the changes but it makes this PR a lot bigger than I thought it was going to be.

Made two little tweaks, LGTM, if the tests pass let's :shipit: 👍

Thanks for the contribution, Luke!


Schedule poster.

Scheduling happens when an institution admin oruser uses the poster management page to add a poster to the sched-ule. When the poster is removed or runs out of time, it becomesinactive.

I don't think we will reach this increment this sprint!


pkg/cri: use marshal wrapper for version convertor

Use wrapper for ReopenContainerLog v1alpha proto.
Ref: #5619
Signed-off-by: Wei Fu<EMAIL_ADDRESS>

=== Failed
=== FAIL: pkg/kmutex  (0.00s)
PASS
FAIL	github.com/containerd/containerd/pkg/kmutex	302.867s

unexpected error in windows...


[mesheryctl] Enhance system dashboard to create a port forward using kubectl's

See mesheryctl Command Tracker for current status of commands.
Current Behavior

Desired Behavior

Enhance system dashboard to create a port forward using kubectl's same approach with Meshery UI when it is deployed in kubernetes cluster
Implementation

Acceptance Tests

Mockups

Contributor Resources

⌨ mesheryctl Contributing Guide
Beginner's guide to contributing to Meshery and mesheryctl
mesheryctl Command Tracker
Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Related https://github.com/meshery/meshery/issues/3035

@suhail34 can you please assign this issue to me?

@saurabh100ni ^

Go On @Jaishree2310

Can I work on this if this isn't assigned to anyone @saurabh100ni?


How can I show the Description in Metadata on the top of my page?

Just like the official website. Thank you.

Unfortunately I'm not sure what you're trying to achieve, can you please further describe what you're trying to do?

You can access a page's meta data (e.g. the page's description) in your Twig template using `{{ meta.description }}``.

I see!


Blocksize fork

Can we get this pulled in for an official release?  Gavin's work is solid here.

Yes, I know, I've been working on the code too. Don't worry, I haven't forgotten ;) There are some bugs that need to be fixed first though. Also, I will write a change to set soft limit=hard limit, as otherwise XT nodes would still create 750kb blocks by default!


Email notifications: "Depositor: New version in progress, not submitted/published"

https://docs.google.com/document/d/1TZVILUrORI25kRZyUZ70vMQYo90Ngp_tqCI7BdU_VyQ/edit#heading=h.awan2wkp6vwt
Example implementation: https://github.com/sul-dlss/happy-heron/pull/673

Leah should have received this notification about this work that has been in draft state since April 5, 2021, but she hasn't. Can someone check on why this isn't going out on schedule? Thanks.

filed new ticket #1420

filed new ticket #1420


Can this work with custom HTML content

Your docs only mention using video and audio. But you can also mirror the entire screen or display different content with AirPlay. As per this article: https://developer.apple.com/library/ios/documentation/WindowsViews/Conceptual/WindowAndScreenGuide/UsingExternalDisplay/UsingExternalDisplay.html
Is this possible with your package? Note: This is for use on a Mac.

good idea, i will try it, if time permits.
Thanks ~

@zfkun You had chance to look at this? Thanks.


Allow string to be passed to hiddenOn & visibleOn

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Thanks


Adding annotations to Associations from ClinVar

Given an RDD of Association objects, trying to add annotations from the ClinVar database providing biological context for these variations.
Annotations will include information about how variant manifests in patients, surrounding genome info, et cetera.
Seethis Google Doc for more information

CC @heuermh most of the functionality for pulling in these annotations should already exist in ADAM's variant annotation codepath.

Right, all the ClinVar annotations in a VCF file will end up in the VariantAnnotation.attributes map.


Add DesktopNames parameter to generated desktop session files

Motivation for this change
Some display managers (e.g. SDDM) set the XDG_CURRENT_DESKTOP variable accroding to this parameter.
If this variable is not defined, there will be some problems (e.g. MATE doesn't have icons on the desktop).
Fixes https://github.com/NixOS/nixpkgs/issues/71427
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Actually forgot to request this when I reviewed the PR that added it.

@ilya-fedin  your commit message don't match the contributing guidelines https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes.
It should be prefixed with the package name or module path.
nixos/display-managers: ...

Good catch. We should probably also check whether the downstream session names match the upstream ones.

@worldofpeace oops, thanks

@ilya-fedin Can you open a backport of this against 20.03 https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes?

Can you open a backport of this to release-20.03

Okay


MSMBuilder is loaded on the RC tag, move to main?

@rmcgibbo @mpharrigan Is there a reason we could not set the msmbuilder package to upload as main instead of rc tag?
We have reports of users who would like to use it on Python 3.6, and in getting 3.6 support going, I did not realize this was uploaded under the rc tag so it cannot be installed without specifying that channel.

Hi,
This is a (custom) option in the recipe. The idea is to test out the binaries before releasing them more widely. @brookehus is taking over as lead maintainer of msmbuilder. Brooke, can you move the python 3.6 packages to the main channel where appropriate?

Historical note: this was inspired by the openmm qa procedure. Others can revisit whether it's necessary.


Recently Played

US
As a user I want to be able to know what videos I had been playing recently, and have those display themselves first so that I can see if I want to keep watching from where I left off.
AC

[ ] Users can watch their videos from where they left off.
[ ] User data is stored anonymously in the DB, and new users are assigned GUIDs.

Tasks

[x] Create recently watched collection in Mongo
[x] Create a reference to the Sermon MessageId that the user was watching.

User Ids will be the Device Id of the requesting device; in swift the syntax is
UIDevice.currentDevice().identifierForVendor!.UUIDString

Considerations; What if a user buys a new device, or what happens when we have a large collection of users because everyone has bought a new device and we just have a huge list of everyone's UIDs in a mongo collection. It should be cleared out every 60 days or so.
However, I still don't think that this will constitute the need for a Microservice. We can do something similar to what we do when we are looking for the expire timer for the livestream. ALSO however, if the API ever goes down - this thread will be lost if it is only initialized from an API request when we create a new log for some user.
As a result, we should include a method that gets called on startup to look in mongo for the device UIDs and sees when the RecentlyPlayedLogging Document was last modified in the new RecentlyPlayedLogging collection.

Will need to flesh out some AC from these new observations

With the new addition of these AC items, the Scope has increased drastically. Might think at making this 2 stories. One with the main thought of recently watched and another for cleanup / threading.


[QUESTION] CSV delimiter messed up when exporting many rows without enclosure

Prerequisites

[X] Have read and understood: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/.github/SUPPORT.md
[X] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[X] Checked that your question isn't already asked before.
[X] Filled in the entire issue template

Versions

PHP version: 7.3.18
Laravel version: 7.13.0
Package version: 3.1

Description
It’s fine when exporting around 1k rows without enclosure. I'm using queue export and CSV delimiter starting mess up when exporting above 4k rows. Rows and Headings contain space. I'm using Query Builder. I want to export my .csv file without enclosure.
Additional Information
ReportsController
class ReportsController extends Controller
{
    public function export()
    {
        (new ReportsExport)->queue('reports.csv');

        return response()->json([
               'download_link' => Storage::url('reports.csv')
        ]);
    }
}

ReportsExport
class ReportsExport implements FromQuery, WithMapping, WithHeadings, WithCustomCsvSettings
{
    use Exportable;

    public function query()
    {
        // Actually, I'm performing complex query behind the scenes
        // and I do not use "get()" as the doc says...
        $record = DB::table('reports')->orderBy('id', 'asc');

        return $record;
    }

    public function map($record): array
    {
        return [
            $record->column_1,
            ...
        ];
    }

    public function headings(): array
    {
        return [
            "Heading 1"
            ...
        ];
    }

    public function getCsvSettings(): array
    {
        return [
            'enclosure' => ''  // no enclosure
        ];
    }
}

I don't understand what you mean with mess up, can you show the output that you think is wrong

Without Enclosure
around 1k rows
Full Name,First Name,Last Name,Location,Email Address
John Smith Doe,John Smith,Doe,15<EMAIL_ADDRESS>Mary Chris Brown,Mary Chris,Brown,15<EMAIL_ADDRESS>about 4k rows
Full,Name,First,Name,Last,Name,Location,Email,Address
John,Smith,Doe,John,Smith,Doe,15,Street,johndoe@example.com,,,,,
Mary,Chris,Brown,Mary,Chris,Brown,15,Aveune,mary@mail.com,,,,,,,
Note: Space disappears and additional commas appear at the end of the rows

Not sure. Think you can better ask on Stackoverflow. We use PhpSpreadsheet behind the scenes and I believe they just use fputcsv. Someone there might be able to explain.

Apparently there was a breaking change in PhpSpreadsheet, our next release will handle empty enclosures again. Hopefully that will also sole your problem.


Change browser support for grab and grabbing cursors

Removed support for chrome on grab and grabbing cursor types

Chrome does support grab and grabbing though, it just needs the -webkit- prefix. Hence my pull-request: https://github.com/anushbmx/CSS-Cursors/pull/16

@Muurtegel is correct, it just the vendor prefix.
Thanks @itsjms for noticing and helping this updated.

I think you are correct @itsjms if this works with vendor prefix it doesn't qualify as CSS property.


This pkg have expo compatibility?

Hi, can you please tell me if this package is compatible with expo for Android and IOS?

Yes, it is compatible with both expo and bare workflow. Regardless of platforms

Bro, you should update this package dependecies. I can do it if you are agree. When you use this component into an Expo app, it display alert message when the component is unmounted.

Hi, I just updated the dependency. I believe the warning is gone in the latest version.
Please update this package to the latest version and check if the issue is still exists.

@roto93 I recently update this pkg and you are right, now the warning is gone! Thank you bro, this pkg is all I need. Hope it make popular.


"Manage" is available for non-owner

Discovered while troubleshooting #650 : dandibot user (non-admin and not owner) since can't "Edit Metadata" still gets that "Manage" icon turned blue for it and can edit the owners list.  But upon "Save" progress bar just keeps spinning:  so api refuses to perform action but due to lack of feedback (#613) it just stays at that until I click Cancel

@sanuann can you take this on?

@sanuann can you take this on?

Sure, will work on it on Monday.


Upgrade Avro to 1.11.3

What
Currently, Druid is using Avro 1.11.1 version. Upgrade to 1.11.3 to address CVE-2023-39410 - When deserializing untrusted or corrupted data, it is possible for a reader to consume memory beyond the allowed constraints and thus lead to out of memory on the system. This issue affects Java applications using Apache Avro Java SDK up to and including 1.11.2. Users should update to apache-avro version 1.11.3 which addresses this issue.

LGTM.

Thank you @KeerthanaSrikanth, for your first contribution.


Fix incorrect DNS entries caused when using multi-dotted gTLDs

Fixes #18

Thanks for the work :)


希望制成安装包

这样才都会用，目前状态不会使用

？

That's it.

Install Python from here.
Once Python is installed, open your terminal or command prompt and run:

pip install markitdown

This way it can all be used, but the current state cannot be used
What? This is not for you to use

That's it.

Install Python from here.
Once Python is installed, open your terminal or command prompt and run:

pip install markitdown

After I installed markitdown, I couldn't export MarkItDown