Any interest in supporting HTTP redirects?

Hello,
First off, thanks for this tool!
I was curious if this project would be interested in adding a --follow-redirects argument to enable InstallApplications to follow HTTP redirects? In my environment, when a request comes in to download a file or package, we return a 301 code and issue a pre-signed URL for the S3 object.
The code change would be pretty easy and I am happy to submit a PR for it, but wanted to ask first!
Example of current behavior:
Hash:
item = {'file': '/Users/myuser/1Password-7.6.pkg', 'hash': '7a9de7f6ab12d2ba2856fb2ba3a456ae332107e4e3120186d6ad9d2a598ea527', 'name': 'Preflight', 'type': 'package', 'url': 'https://frontend.corp.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg'}

Logs from downloadfile(item) the redirect is denied:
2020-09-18 15:01:04.524 Python[95558:3678364] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 15:01:04.525 Python[95558:3678364] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodServerTrust
2020-09-18 15:01:04.525 Python[95558:3678364] Allowing OS to handle authentication request
2020-09-18 15:01:04.539 Python[95558:3678357] [InstallApplications] Downloading Preflight - Percent complete: 0
2020-09-18 15:01:04.545 Python[95558:3678364] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 15:01:04.545 Python[95558:3678364] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodClientCertificate
2020-09-18 15:01:04.545 Python[95558:3678364] Allowing OS to handle authentication request
2020-09-18 15:01:04.764 Python[95558:3678911] URLSession_task_willPerformHTTPRedirection_newRequest_completionHandler_
2020-09-18 15:01:04.765 Python[95558:3678911] Denying redirect to: https://foobucket.s3-us-west-1.amazonaws.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=FOOBAR%FOOBAR%2Fus-west-1%2Fs3%2Faws4_request&X-Amz-Date=20200918T220104Z&X-Amz-Expires=3600&X-Amz-Security-Token=LongTokenString-Amz-Signature=ea04e009fdaaa00b28b4baffd0d2165a354aad8f0d18ad931b871bea522842e7&X-Amz-SignedHeaders=Host
2020-09-18 15:01:04.849 Python[95558:3678357] [InstallApplications] Status: 301

Patch the original dictionary with {'follow_redirects': True} along with some changes in the downloadfile() method:
item = {'file': '/Users/myuser/1Password-7.6.pkg', 'hash': '7a9de7f6ab12d2ba2856fb2ba3a456ae332107e4e3120186d6ad9d2a598ea527', 'name': 'Preflight', 'type': 'package', 'url': 'https://frontend.corp.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg', 'follow_redirects': True}

Logs from downloadfile(item) the redirect is successful:
2020-09-18 14:22:24.145 Python[88440:3637137] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 14:22:24.145 Python[88440:3637137] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodServerTrust
2020-09-18 14:22:24.145 Python[88440:3637137] Allowing OS to handle authentication request
2020-09-18 14:22:24.153 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 0
2020-09-18 14:22:24.182 Python[88440:3638257] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 14:22:24.182 Python[88440:3638257] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodClientCertificate
2020-09-18 14:22:24.182 Python[88440:3638257] Allowing OS to handle authentication request
2020-09-18 14:22:24.394 Python[88440:3638257] URLSession_task_willPerformHTTPRedirection_newRequest_completionHandler_
2020-09-18 14:22:24.395 Python[88440:3638257] Allowing redirect to: https://foobucket.s3-us-west-1.amazonaws.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=FOOBAR%FOOBAR%2Fus-west-1%2Fs3%2Faws4_request&X-Amz-Date=20200918T220104Z&X-Amz-Expires=3600&X-Amz-Security-Token=LongTokenString-Amz-Signature=ea04e009fdaaa00b28b4baffd0d2165a354aad8f0d18ad931b871bea522842e7&X-Amz-SignedHeaders=Host
2020-09-18 14:22:24.475 Python[88440:3637137] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 14:22:24.475 Python[88440:3637137] Authentication challenge for Host: foobucket.s3-us-west-1.amazonaws.com Realm: None AuthMethod: NSURLAuthenticationMethodServerTrust
2020-09-18 14:22:24.475 Python[88440:3637137] Allowing OS to handle authentication request
2020-09-18 14:22:24.770 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 1
2020-09-18 14:22:24.871 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 4
2020-09-18 14:22:24.972 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 8
2020-09-18 14:22:25.074 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 12
2020-09-18 14:22:25.175 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 15
2020-09-18 14:22:25.276 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 20
2020-09-18 14:22:25.377 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 24
2020-09-18 14:22:25.479 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 29
2020-09-18 14:22:25.580 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 33
2020-09-18 14:22:25.681 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 38
2020-09-18 14:22:25.782 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 41
2020-09-18 14:22:25.882 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 46
2020-09-18 14:22:25.984 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 52
2020-09-18 14:22:26.085 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 57
2020-09-18 14:22:26.185 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 63
2020-09-18 14:22:26.286 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 68
2020-09-18 14:22:26.386 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 73
2020-09-18 14:22:26.487 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 78
2020-09-18 14:22:26.587 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 82
2020-09-18 14:22:26.688 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 86
2020-09-18 14:22:26.788 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 91
2020-09-18 14:22:26.889 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 96
2020-09-18 14:22:26.992 Python[88440:3634301] [InstallApplications] Status: 200
2020-09-18 14:22:26.993 Python[88440:3634301] [InstallApplications] Headers: {'Server': 'AmazonS3', 'Content-Type': 'application/octet-stream', 'Last-Modified': 'Wed, 08 Jul 2020 16:09:21 GMT', 'x-amz-request-id': 'BBED53A3E09ED17D', 'Date': 'Fri, 18 Sep 2020 21:22:25 GMT', 'Accept-Ranges': 'bytes', 'x-amz-id-2': 'k7fmSnIULrqlIarY4nLSuV1KANJ/Z4t49Vom0IYR1ezVnqAd0rDRhDcGfC7arLAUTn7Rjy3JANE=', 'x-amz-server-side-encryption': 'AES256', 'Content-Length': '57662381', 'Etag': '"def7a37969860e734b57bdea8d7c39c4-7"'}

It sounds like a great option. How do you perceive implementing it?
Thanks,
Erik Gomez

From: bfreezy<EMAIL_ADDRESS>Sent: Friday, September 18, 2020 5:15:12 PM
To: macadmins/installapplications<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [macadmins/installapplications] Any interest in supporting HTTP redirects? (#76)
Hello,
First off, thanks for this tool!
I was curious if this project would be interested in adding a --follow-redirects argument to enable InstallApplications to follow HTTP redirects? In my environment, when a request comes in to download a file or package, we return a 301 code and issue a pre-signed URL for the S3 object.
The code change would be pretty easy and I am happy to submit a PR for it, but wanted to ask first!
Example of current behavior:
Hash:
item = {'file': '/Users/myuser/1Password-7.6.pkg', 'hash': '7a9de7f6ab12d2ba2856fb2ba3a456ae332107e4e3120186d6ad9d2a598ea527', 'name': 'Preflight', 'type': 'package', 'url': 'https://frontend.corp.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg'}
Logs from downloadfile(item) the redirect is denied:
2020-09-18 15:01:04.524 Python[95558:3678364] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 15:01:04.525 Python[95558:3678364] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodServerTrust
2020-09-18 15:01:04.525 Python[95558:3678364] Allowing OS to handle authentication request
2020-09-18 15:01:04.539 Python[95558:3678357] [InstallApplications] Downloading Preflight - Percent complete: 0
2020-09-18 15:01:04.545 Python[95558:3678364] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 15:01:04.545 Python[95558:3678364] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodClientCertificate
2020-09-18 15:01:04.545 Python[95558:3678364] Allowing OS to handle authentication request
2020-09-18 15:01:04.764 Python[95558:3678911] URLSession_task_willPerformHTTPRedirection_newRequest_completionHandler_
2020-09-18 15:01:04.765 Python[95558:3678911] Denying redirect to: https://foobucket.s3-us-west-1.amazonaws.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=FOOBAR%FOOBAR%2Fus-west-1%2Fs3%2Faws4_request&X-Amz-Date=20200918T220104Z&X-Amz-Expires=3600&X-Amz-Security-Token=LongTokenString-Amz-Signature=ea04e009fdaaa00b28b4baffd0d2165a354aad8f0d18ad931b871bea522842e7&X-Amz-SignedHeaders=Host
2020-09-18 15:01:04.849 Python[95558:3678357] [InstallApplications] Status: 301
Patch the original dictionary with {'follow_redirects': True} along with some changes in the downloadfile() method:
item = {'file': '/Users/myuser/1Password-7.6.pkg', 'hash': '7a9de7f6ab12d2ba2856fb2ba3a456ae332107e4e3120186d6ad9d2a598ea527', 'name': 'Preflight', 'type': 'package', 'url': 'https://frontend.corp.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg', 'follow_redirects': True}
Logs from downloadfile(item) the redirect is successful:
2020-09-18 14:22:24.145 Python[88440:3637137] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 14:22:24.145 Python[88440:3637137] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodServerTrust
2020-09-18 14:22:24.145 Python[88440:3637137] Allowing OS to handle authentication request
2020-09-18 14:22:24.153 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 0
2020-09-18 14:22:24.182 Python[88440:3638257] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 14:22:24.182 Python[88440:3638257] Authentication challenge for Host: frontend.corp.com Realm: None AuthMethod: NSURLAuthenticationMethodClientCertificate
2020-09-18 14:22:24.182 Python[88440:3638257] Allowing OS to handle authentication request
2020-09-18 14:22:24.394 Python[88440:3638257] URLSession_task_willPerformHTTPRedirection_newRequest_completionHandler_
2020-09-18 14:22:24.395 Python[88440:3638257] Allowing redirect to: https://foobucket.s3-us-west-1.amazonaws.com/pkgs/apps/agilebits/1password/1Password-7.6.pkg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=FOOBAR%FOOBAR%2Fus-west-1%2Fs3%2Faws4_request&X-Amz-Date=20200918T220104Z&X-Amz-Expires=3600&X-Amz-Security-Token=LongTokenString-Amz-Signature=ea04e009fdaaa00b28b4baffd0d2165a354aad8f0d18ad931b871bea522842e7&X-Amz-SignedHeaders=Host
2020-09-18 14:22:24.475 Python[88440:3637137] URLSession_task_didReceiveChallenge_completionHandler_
2020-09-18 14:22:24.475 Python[88440:3637137] Authentication challenge for Host: stripe-frontend.s3-us-west-1.amazonaws.com Realm: None AuthMethod: NSURLAuthenticationMethodServerTrust
2020-09-18 14:22:24.475 Python[88440:3637137] Allowing OS to handle authentication request
2020-09-18 14:22:24.770 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 1
2020-09-18 14:22:24.871 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 4
2020-09-18 14:22:24.972 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 8
2020-09-18 14:22:25.074 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 12
2020-09-18 14:22:25.175 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 15
2020-09-18 14:22:25.276 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 20
2020-09-18 14:22:25.377 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 24
2020-09-18 14:22:25.479 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 29
2020-09-18 14:22:25.580 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 33
2020-09-18 14:22:25.681 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 38
2020-09-18 14:22:25.782 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 41
2020-09-18 14:22:25.882 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 46
2020-09-18 14:22:25.984 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 52
2020-09-18 14:22:26.085 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 57
2020-09-18 14:22:26.185 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 63
2020-09-18 14:22:26.286 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 68
2020-09-18 14:22:26.386 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 73
2020-09-18 14:22:26.487 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 78
2020-09-18 14:22:26.587 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 82
2020-09-18 14:22:26.688 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 86
2020-09-18 14:22:26.788 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 91
2020-09-18 14:22:26.889 Python[88440:3634301] [InstallApplications] Downloading Preflight - Percent complete: 96
2020-09-18 14:22:26.992 Python[88440:3634301] [InstallApplications] Status: 200
2020-09-18 14:22:26.993 Python[88440:3634301] [InstallApplications] Headers: {'Server': 'AmazonS3', 'Content-Type': 'application/octet-stream', 'Last-Modified': 'Wed, 08 Jul 2020 16:09:21 GMT', 'x-amz-request-id': 'BBED53A3E09ED17D', 'Date': 'Fri, 18 Sep 2020 21:22:25 GMT', 'Accept-Ranges': 'bytes', 'x-amz-id-2': 'k7fmSnIULrqlIarY4nLSuV1KANJ/Z4t49Vom0IYR1ezVnqAd0rDRhDcGfC7arLAUTn7Rjy3JANE=', 'x-amz-server-side-encryption': 'AES256', 'Content-Length': '57662381', 'Etag': '"def7a37969860e734b57bdea8d7c39c4-7"'}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/macadmins/installapplications/issues/76, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLL6GFS25PC4ZE4SOHHW6DSGPLXBANCNFSM4RSSTCSA.

I figured I'd follow the current convention that basic auth takes.

Add a new option to optparse:

    o.add_option('--follow-redirects', default=False,
                 help=('Optional: Follow HTTP redirects.'),
                 action='store_true')

Add another check in download_if_needed(), after checking for headers:

        # Check if additional headers are being passed and add
        # them to the dictionary.
        if opts.headers:
            item.update({'additional_headers':
                         {'Authorization': opts.headers}})
        # Check if we need to follow redirects
        if opts.follow_redirects:
            item.update({'follow_redirects': True})

Add another check to main(), after checking for headers:

    # Grab auth headers if they exist and update the json_data dict.
    if opts.headers:
        headers = {'Authorization': opts.headers}
        json_data.update({'additional_headers': headers})

    # Add follow redirects to json_data dict.
    if opts.follow_redirects:
        json_data.update({'follow_redirects': True})

Sounds good!
Thanks,
Erik Gomez

From: bfreezy<EMAIL_ADDRESS>Sent: Friday, September 18, 2020 9:56:47 PM
To: macadmins/installapplications<EMAIL_ADDRESS>Cc: Erik Gomez<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [macadmins/installapplications] Any interest in supporting HTTP redirects? (#76)
I figured I'd follow the current convention that basic auth takes.

Add a new option to optparse:

o.add_option('--follow-redirects', default=False,
             help=('Optional: Follow HTTP redirects.'),
             action='store_true')

Add another check in download_if_needed(), after checking for headers:
Check if additional headers are being passed and add
them to the dictionary.
if opts.headers:
item.update({'additional_headers':
{'Authorization': opts.headers}})
Check if we need to follow redirects
if opts.follow_redirects:
item.update({'follow_redirects': True})

Add another check to main(), after checking for headers:

# Grab auth headers if they exist and update the json_data dict.
if opts.headers:
    headers = {'Authorization': opts.headers}
    json_data.update({'additional_headers': headers})

# Add follow redirects to json_data dict.
if opts.follow_redirects:
    json_data.update({'follow_redirects': True})

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/macadmins/installapplications/issues/76#issuecomment-695154746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLL6GAJEGZHR6F5UHE5PE3SGQMW7ANCNFSM4RSSTCSA.

Awesome! I'll get a PR up in the coming days.
Thanks!


Make ECHONET_ALT_MULTI_NIC_MODE command line option default

ECHONETLite2MQTT may not be able to receive notifications from devices in environments with multiple NICs.
To resolve this issue, v2.3.0 provides an alternative communication mode.
This feature seems to be working well, so I'll make this mode the default.
For compatibility, it is possible to revert to the previous mode with a command line option.
Revert to legacy communication mode.(Default:false)

[docker] -e ECHONET_LEGACY_MULTI_NIC_MODE=1
[node.js] --echonetLegacyMultiNicMode 1

This feature was implemented in v3.0.0.


feat: add delete child docs

Not related to Doc set merge.   I rebased this with main, but now having some issue checking out contracts on build server. I will need some help resolving this.

One quick question on the commits, is this a feature or a fix? Seems like missing required behaviour. This branch will need a rebase anyway due to conflicts, this could be resolved as part of a squash rebase with conventional commit rewording.


Update seed crate from 0.4.0 to 0.4.1

Some functions in "seed", like add_class(), now accept and return mutable
reference.

In a lot of these changes chaining has been removed. Will it no longer compile when chaining operations on elements?

In a lot of these changes chaining has been removed. Will it no longer compile when chaining operations on elements?

I think I kept chaining. To my understanding, chaining now operates on mutable references, but still works, like this:
let mut foo = ...;
foo.add_class(...).add_attrs(...);
foo

Maybe *(...) would work, but in most place it was ugly, in the others did not compile and I did not try hard because it was ugly.


Maximum Graphics drawCircle() calls

I can't find the exact cause of this problem. When I render > ~850 circles on a Graphics object with drawCircle(), the next ones overlap the first ones and get joined by a strange line.
You can see an example here: http://urbanoalvarez.es/Nebula/pixi-circles.html
With drawRect() this doesn't happen though: http://urbanoalvarez.es/Nebula/index.html
Those circles are added here, on the file nebula-pixi.js:

Line 207: Calling the function that adds the new circle
Line 474: Drawing the actual circle

The strange part is that this only happens, as I said at the beginning, with more than ~850 nodes, when there are less everything works perfectly.

I've hit this error too.
Interestingly using webGL renderer with drawRect causes the browser to crash after ~5500 drawRect calls.

I observed the same issue here : http://jsfiddle.net/83w5m3xd/
Each tile create a graphicData. About 13108 entries, coordinates still correct but the shape come back to origin in a linear way (like for color).

ok, it's not a problem about length of array. We can see here the same issue with just some line of code : http://jsfiddle.net/bkzchuqc/

This has been address in v3. Should work like a champ as the batch's now get split if they are too large.


Create talk model

Create model file:
title: CharField, max=256
abstract: TextField
type: CHOICES, (talk, workshop)
status: CHOICES, (cfp, draft, approved, rejected, withdrawn)
duration: CHOICES, (30, 45)
primary_speaker: ForeignKey, #5 speaker table, NOT NULL
secondary_speaker: ForeignKey, #5 speaker table, DEFAULT NULL
event: ForeignKey, #2 events table, NOT NULL
Once finished, please cross the issue off in list stored at #1 Create initial DB models and migrations

Finished and PR sent, sorry did not reference the issue


Dropzone.js contains extra, unrelated code for raw text upload

Figure out the correct location for that code.

Let's have that file for handling data upload, so it's in correct place.


ns-train in2n-tiny error, 3D model disappears

The 3D model being trained with the command "ns-train in2n-tiny --data ./lego --load-dir ~/instruct-nerf2nerf/outputs/lego/nerfacto/2023-12-20_174925/nerfstudio_models --pipeline.prompt "change it into a drawing" --pipeline.guidance-scale 7.5 --pipeline.image-guidance-scale 1.5" disappears from the viewer at some point. What did I miss?
before

after

thank for your reply

Not entirely sure why this would be the case. I suspect that the scene has diverged after training for too many iterations. I've seen this issue before with any nerfstudio model, I recommend creating an issue there. The easiest change would be to train the base nerfacto to 20k iters instead of 30k


MQTT client: limit outbox size (IDFGH-7527)

Good day!
It is necessary to add the ability to limit the size of the outbox for mqtt_client or block it altogether (disable it).
The problem is the following. On a "good" WiFi connection, everything works fine, no problems.
But not all devices have a good WiFi connection, some of my devices are at the Wifi limit, -90dBi and below. And sometimes neighbors clog the channel so tightly that packet loss reaches 100%. In this case, mqtt queues messages. And this is good. But not much. The fact is that rather large JSON packets go to MQTT, from 512 bytes and above, sometimes 2-3 kilobytes. I can't quickly determine if there is a connection to the server or not. And the messages are queued. And the memory runs out very, very quickly, the device either freezes or reboots.
It is necessary to somehow limit the size of the outgoing mailbox, after which the "old" messages will be overwritten by new ones. I haven't found such an option yet.
And besides, it is very important that messages in the same topic are not duplicated in the outbox, but are filled with new ones.

Hi @kotyara12 thanks for the suggestion. I'm looking into adding more control over the outbox, but you can already disable it via menuconfig. It's also possible to define a timeout for messages, using these two options you may have a temporary solution for your issue.

Hello @euripedesrocha.
I don't quite understand how to disable the send queue via menuconfig. I understand that in order to use a custom implementation, you need to write it, and I do not have enough knowledge in this matter.
But this is not required. In fact, the send queue is a great feature and avoids problems in some situations when the device generates several packets at once to send to mqtt and "does not have time" to send them all. But there are times when this functionality brings problems. For example, right now the power was turned off, the devices switched to battery operation, but unfortunately the provider's equipment is apparently de-energized.
I've gotten around so far by checking the amount of free heap before JSON is generated and sent. Devices began to work much more stable, failures due to heap exhaustion were no longer observed.
However, if such functionality is at the library level, it will be "much more correct", in my opinion.
Thank you.
PS: In general, I am completely delighted with the multitasking ESP-IDF, after Arduino.

Hi @kotyara12,
we agree that this a good feature to have in esp-mqtt client, and I'm working on it already.
I only pointed the custom outbox route because it's a way for you to not be blocked by our implementation time.

Hello @euripedesrocha.
Pay attention to this mechanism:
Let's say we send a message "{big-big-json}" to the topic "device/topic1"
But there is no connection with the broker (for any reason), it is put in the outbox queue. After some time (but before the message storage timeout expires), another message is added to the SAME topic "device/topic1", but with different data.
In order not to know the extra space in the outbox, you need to somehow replace the data in the queue (deleting the old ones) and update the addition time.
Thank you.

Hello, I also agree that this would be a great feature to have.
@euripedesrocha you mentioned the custom outbox option, which looks quite interesting. Could you point me to some existing implementation to use as "inspiration" for a custom one?
Thanks!

@euripedesrocha
Looks like this feature is implemented in esp-mqtt.
However, the esp-idf still uses a very old version of esp-mqtt (5afa3d347c189217c087a098f1bcfc2d3f52ee1f).
As a result, people cannot test latest esp-mqtt code. Any chance to update esp-mqtt submodule in esp-idf?

@AxelLin, mqtt submodule is in process of update in the latest idf master and 5.1.
For 5.0, that you are referring to, there is still an ongoing discussion about which features will be backported.

(Top) → Component config → ESP-MQTT Configurations → Number of queued events
This is it? How this option works (there is nothing about it in the help yet)

@kotyara12 the outbox limitation is a runtime configuration. You can find the limit configuration in the mqtt client config structure. The availability will depend on which IDF version you are using and the version of esp_mqtt.

@euripedesrocha, many thanks!


[Remote Databases] [Step 0] Add ability to create secrets in oauth

oauth should be extended to allow creating "plain text" secrets.
API should look something like this

Good to close this one right @Fraggle  ?

@fontanierh sorry didn't see your message, yes of course.


refactor(FileAuthDataProvider): Pushed down getUserByUsername

Moved it down so it is a method of FileAuthDataProvider instead of being in AuthDataProvider. Since all other implementors of getUserByUsername instantly return Optional.empty(), I believe it is more appropriate to only implement the method in FileAuthDataProvider.

Thanks for asking! Its a little bit of learning Java, but its mostly about learning how to contribute to open-source software!
I'm trying to focus on refactoring to (hopefully) help improve the maintainability of the project, while avoiding unintentionally breaking anything.

@kdhrubo I suppose the MR's changes are not needed. It brings more problems to support the codebase in the future.

Yes any one installation is expected to only one instance of Auth provider and data provider.


Follow requests icon is misaligned in the navigation panel

Fixed in https://github.com/nileane/TangerineUI-for-Mastodon/commit/e008d74255e3964c5d605893da287987ac0fddd4


Used the Update funciton on 1.7.1 and unable to launch raspiblitz

I get the below error
Starting SSH user interface ... (please wait)
/home/admin/_cache.sh: line 198: redis-cli: command not found
/home/admin/_cache.sh: line 198: redis-cli: command not found
setupPhase(done) state()
FAIL: /home/admin/raspiblitz.info does not exist or missing state.
Check logs & bootstrap.service for errors and report to devs.
It looks like it wiped out some needed info.
Appreciate any assistance.
Thanks.

I have looked at the errors and matched them with the correct file and everything looks correct.  I tried to upgrade to 1.7.2 and it didn't recognize my admin password.  At this point my node is completely down.

Thanks for the reminder.  That allowed me to login and setup the node.  I'm back up and running.  Thank you again.

Hey @mantiev, I'm having the same issue and Im a bit of a dummy. My password seems to work but Im stuck in the loop of getting the same message every time I try and log in. How did you resolve?


Displayed Reasoning changes upstream

I just merged this PR upstream, which should help us out but means basically all proofs using the displayed reasoning module need to be updated. Somebody should take care of that. Make sure to build on https://github.com/maxsnew/cubical-categorical-logic/pull/107 which addresses some earlier upstream changes.

working in #111

closing with #111


Fixes #1205 - updating bicep files for new container environment vari…

…able schema
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:

[X] Read the contribution guide
[X] Commands include options for Linux, MacOS, and Windows within codetabs
[X] New file and folder names are globally unique
[X] Page references use shortcodes instead of markdown or URL links
[X] Images use HTML style and have alternative text
[X] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Updating bicep files with new container environment variables schema
Issue reference
Fixes: #1205

NOTE: these docs changes are dependent on code changes to be merged first: https://github.com/radius-project/radius/pull/7744


Apply to blind SR

Hi, thanks for the excellent work.
I have read the paper, and it seems that the method can only be applied to a simple unknown degradation model with self-defined parameters (i.e., low-light enhancement described in eq. 10) ?
However, if we want to apply the model to more complicated degradations, such as blind SR or natural-image restoration, which are difficult to describe using a simple model with several parameters, then if the method will still work, or how to use the proposed method?

Hi! For more complicated degradations, such as blind SR or natural-image restoration, the type of degradation is still needed to be given, while the parameters of degradation can be optimized along the sampling. Multiple degradations are also supported. But we found that two or more degradations that damage the image content, such as SR and blur, will make the restoration more difficult. The multiple degradations, such as gray + SR, or low-light + SR can work well.

Since there are no more questions, I'll mark it closed. If you still have some questions, please feel free to ask. Thanks!


update .NET Compiler Platform ("Roslyn") link

update .NET Compiler Platform ("Roslyn") link from https://roslyn.codeplex.com/ to https://github.com/dotnet/roslyn

duplicate with #1


html5 mode with mismatching base href causes "TypeError: Cannot read property 'replace' of undefined" error in location.js

Looking at the latest version of location.js (https://github.com/angular/angular.js/blob/4412fe238f37f79a2017ee7b20ba089c0acd73e9/src/ng/location.js)
If the  tag does not match the actual href, $$parseLinkUrl will miss all the conditions and rewrittenUrl will not be defined, which means this.$$parse will not be called and $$absUrl will not be set.
Later on line 902 (https://github.com/angular/angular.js/blob/4412fe238f37f79a2017ee7b20ba089c0acd73e9/src/ng/location.js#L902), trimEmptyHash($location.absUrl()) will be called in a condition, which will end up having trimEmptyHash call .replace on undefined, so we end up halting with:
TypeError: Cannot read property 'replace' of undefined

I'm not sure I understand the problem. In what case would the base tag not match the actual href?

In my case, the html was being served on multiple domains. Granted, we can correct that base url, but it still shouldn't cause a javascript error in angular.

I agree, this shouldn't cause an unknown error. This is happening to us, and we couldn't see it until production, and it simply killed the page.  Having such a low-level JS error seems like something that should have feedback.
(It was a weird case in our situation, a production-only url rewrite that triggered an error.)

Should be fixed by #14488.


⚠ Spryr has degraded performance

In a84ec84, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4252 ms

Resolved: Spryr performance has improved in 7d1f144 after 7 minutes.


Trigger when car is connected

Question
I am having a bit of a broken brain atm so I figured I should just ask.
I am setting up an automation that triggers on change of the electricity price (nordpool integration) an starting/stopping charging based on that price.
However I also want the automation to trigger when I connect the the car so I dont have to wait for the next price change to happen.
There is a State that I can trigger on when the car is disconnected. But what about the opposite?
What version of the integration are you using?
0.9.64
Anything in the logs that might be useful for us?
No response
Additional information
No response

All the different states (that we know about) can be seen here:
https://github.com/nordicopen/easee_hass/blob/a50459831160186c510bda7e69690b44272ddbb2/custom_components/easee/const.py#L938-L962
I think triggering an automation on state and from: "disconnected" is a valid way to see if the charger is changing from disconnected to whatever else? There is a slight chance the charger is in some kind of error state of course, but that probably does not matter since that is something that requires user intervention anyway.
A suggestion though is to run your automation once a minute instead of triggered on state changing alone, and use conditions in the automation to decide if charging should be started or stopped, or just set the circuit dynamic limit depending on some other predetermined template sensor. If you do that, you are not dependant on that the Easee API works every time, and a short outage will not cause any issue.

Many thanks. Will try that.

A followup with regards to triggering every minute.
Wont this spam the API with a request every minute? Or is the integration smart enough to only do something if the value changes?

Depends on what service you call.
All the services for setting current limits are smart and does not call the API if there if the settings has not changed.

So a timebased trigger works great. But I wanted to also have a more "event based" trigger so I looked into the "state change from disconnected".
But it doesnt look like its possible. I am using the GUI and if I use Device-based trigger I dont get the option to select the "State-change" only if its in the Disconnected state.
If I choose the Entitybased trigger I dont have the option to select those states.
Thoughts?

The problem is that the states are not selectable

Can you not type whatever in that field?

😬 Didn't even cross my mind to try.
Works like a charm.
Thanks
Den tors 14 nov. 2024 11:40Ola Lidholm @.***> skrev:

Can you not type whatever in that field?
—
Reply to this email directly, view it on GitHub
https://github.com/nordicopen/easee_hass/issues/509#issuecomment-2476000898,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQKVXQ56O5S3SQTL5I4ZU32AR42LAVCNFSM6AAAAABRTTLMM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGAYDAOBZHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Fix type issues

ghgql/config.py:6: error: Library stubs not installed for "yaml" (or incompatible with Python 3.9)
ghgql/config.py:6: note: Hint: "python3 -m pip install types-PyYAML"

ghgql/demo/variables.py:24: error: Library stubs not installed for "requests" (or incompatible with Python 3.9)
ghgql/demo/basic.py:13: error: Library stubs not installed for "requests" (or incompatible with Python 3.9)
ghgql/demo/basic.py:13: note: Hint: "python3 -m pip install types-requests"
ghgql/demo/basic.py:13: note: (or run "mypy --install-types" to install all missing stub packages)
ghgql/demo/basic.py:13: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

ghgql/lib/__init__.py:10: error: Library stubs not installed for "requests" (or incompatible with Python 3.9)
ghgql/lib/__init__.py:11: error: Skipping analyzing "jinja2": found module but no type hints or library stubs

Found 5 errors in 4 files (checked 19 source files)
make: *** [typecheck] Error 1

This helped
mypy --install-types
Installing missing stub packages:
/Users/mcurrin/.local/virtualenvs/github-reporting-py/bin/python3.9 -m pip install types-PyYAML types-requests

Install? [yN] y

But Jinja fails


When using external JSON materalization: bumping into default maximum_object_size limit.

https://github.com/duckdb/dbt-duckdb/blob/ab16970ba9f616205dcae52a9dcb661c6d8836c6/dbt/include/duckdb/macros/materializations/external.sql#L52
When materializing a table to a JSON file bigger than 30MB, we bump into the following:
Invalid Input Error: "maximum_object_size" of 16777216 bytes exceeded while reading file "s3://xxxxxx.json" (>33554428 bytes).    Try increasing "maximum_object_size".
This is likely due to the select * from '{{ read_location }}' trying to build a view with the default read_json_auto() and default options params.
Would it be possible to pass the read_json/read_parquet/read_csv functions and their options params?

Yes, I think; there would need to be a PR that modified this function to let you override more of the defaults using the rendered_options dictionary (like we do for external materializations that use partitioning): https://github.com/duckdb/dbt-duckdb/blob/master/dbt/adapters/duckdb/impl.py#L166


DMP-1347: replaced field-based injection with constructor-based injec…

…tion

LGTM - keen on getting @chrisbellingham-hmcts thoughts


Refactor: Modularize, remove jQuery, and TEST!

Aight y'all,
I think before we dive too far in to more features we should clean up what we've got. There's three main cleanup items I would like to take care of if we're going to do a refactor:
Modularize
One of the big design goals of an open source project should be modularization.
This will likely feel overkill for the size of the project right now, but I think if we start a modular theme now it will be easy to keep that going as CommonWeb grows.
Remove jQuery
This is a pretty hard one, and I'm quite scared to dive into it. We're using jQuery very heavily right now, but I think the only thing we really need it for is eventing. Most of the other stuff is just convenience.
I think that eventing could be replaced with a mashup of John Resig's addEvent and jQuery's sizzle selector library. I'd like to recreate something similar to jQuery's $(document).on('click', '.selector', function() { }) pattern. This allows us to capture events on elements that are created after the initial track calls.
We don't need to get super advanced with the event adding yet - I don't think namespacing or anything needs to be implemented. Just document-level binding, and selector-based filtering.
Test
Obviously, we need to test this thing. We've already got Gulp in there, we might as well use that for our testing stuff. I'm pretty familiar with karma and jasmine, although I'd be happy to use something else if someone prefers it.
Bonus! Bower! NPM! Browserify!
This might be something to do after the refactor, but I'd also like to get this library up on a package manager, and provide some sane "Getting Started" documentation. Right now it's kind of a mess, and I'm super worried about common-web.min.js getting blown up in a PR.

If anyone has opinions on any of these three items, please drop your feedback here. I'm gonna leave this issue open for a few days (or until we are done discussing), and then I will break it apart to 3 separate issues with a common milestone.

OK, I'm going to start splitting these off in to separate issues, and create a milestone.
If you have thoughts/ideas around a specific point here, please discuss it in the related issue (they will be linked here).


Update LVGL and fix binding for multi-instance and parallel rendering architecture changes

Fix MicroPython binding to use latest LVGL multi-instance and parallel rendering architecture changes.
Based on previous lv_conf.h configuration and feat/multi-instance branch, and LVGL's lv_conf_template.h config.

Thank, but the CI still fails. @amirgon could you take a look at it?

Thank, but the CI still fails. @amirgon could you take a look at it?

Yes, sorry, there was an extra #endif in lv_conf.h file.
Fixed, new commit added.

And it's working :tada: Thank you!


How to add it without composer?

I have a working Slim app (added without composer), and now I want to implement slim-jwt-auth but i can't figure it out how to do it (autoloading, i think)
Is there any option to do this?
If so, what are the steps that I need to follow in order to achieve the integration of Slim and Slim-jwt-auth.
Any help would be very appreciated :+1:

Composer is pretty much the de facto standard these days so you really would be better of installing via composer. It might be possible to do a git clone and include files from the src folder. That is unsupported though.


Add recipes for Symfony2 and extract default Symfony recipes to one with version 3

Closes #201

This PR is point at the wrong branch. Please point it to the master branch.

Thanks!


tenant management api primitives

Pull Request summary:
API primitives for tenant create/delete
Description of changes:

Added methods for creating and deleting tenants in TenantManagementPrimitives: create_tenant create_tenant_async create_tenant_async_bulk delete_tenant_async_bulk delete_tenant get_all_tenant_statuses get_all_tenants get_tenant get_tenant_hosting_capacity_on_vsmarts get_tenant_vsmart_mapping vsession_id

Some supplementary work in APIPrimitiveBase:
All requests methods (request,get,post,put,delete) have now optional payload keyword argument. Which accepts: DataSequence, pydantic.BaseModel and vmngclient.utils.creation_tools.AttrsInstance instances as well as regular sequences of such objects (such as list). Data is then serialized according to type.

Change some fields in SubTaskData to optional as they don't appear in task statuses for tenant related actions

Checklist:

[x] Make sure to run pre-commit before commiting changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/235


feat(breadcrumbs): use css variables for colors

What:
Migrate new Breadcrumbs component to use css vars for colors.

Why:
The Breadcrumbs component has been implemented in main, where our css variables are not yet available, we want to migrate it to use them so that when Wave 2.0 gets released it's using our new css variables.

How:
I've migrated all color values in Breadcrumbs so they are using getSemanticValue. Please review the semantic values that I've chosen and let me know how to improve them, I'm not convinced by the inverted colors 🙏🏽

Media:

Checklist:

[x] Ready to be merged

Closes #361

The reason behind the force pushes is explained here


Update pigweed to 4afe7a4158

Problem
Pigweed should be periodically updated so it doesn't become stale.
Summary of Changes
Updated pigweed repo.

@andy31415 @saurabhst @msandstedt ?

/rebase


Add distribution event

Codecov Report

Merging #415 (fd2339d) into main (d9e2772) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   18.47%   18.50%   +0.02%
==========================================
  Files         142      142
  Lines       22027    22035       +8
==========================================
+ Hits         4070     4078       +8
  Misses      17273    17273
  Partials      684      684

Impacted Files
Coverage Δ

x/incentives/keeper/gauge.go
68.66% <100.00%> (+1.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e2772...fd2339d. Read the comment docs.

Why not using proto events? Much better DevUX. You create a proto type for event and push it, instead of creating dynamic attributes.

@robert-zaremba are proto events ready to use? Do you have an example code of how to use them?

are proto events ready to use?

Yes, although the type is set to the proto type (so it's long).

Do you have an example code of how to use them?

https://github.com/cosmos/cosmos-sdk/blob/master/proto/cosmos/authz/v1beta1/event.proto
https://github.com/cosmos/cosmos-sdk/blob/master/x/authz/keeper/keeper.go#L144

@ValarDragon wdyt of switching to these ^

These are great! I had just thought that they were blocked on sdk v0.43.0


Fix docker-compose appserver port forwarding

1. Why is this change necessary?

When starting the docker-container of this repository via ./psh.phar docker:start port 80 of the appserver is forwarded to 18000 on the local machine, but the command says it should be available under port http://localhost:8088.
After i ssh'd into the appserver and executing ./psh.phar init the shopware instance is running with the shop url localhost:8088 as configured in the .psh.yaml.dist.

So the appserver is available under http://localhost:18000 and after entering this in the browser we get forwarded to http://localhost:8088.
2. What does this change do, exactly?
I adjusted the port forwarding of the appserver to match the message at the end of docker:start and the configured SW_HOST in /.psh.yaml.dist
3. Describe each step to reproduce the issue or behaviour.

Run ./psh.phar docker:start
Look at the shown webserver IP at the end of the command
SSH into the appserver and init shopware with ./psh.phar init
Go into your browser and enter 'http://localhost:18000'
Get forwarded to 'http://localhost:8088'

4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Please revert the unrelated changes and squash your commits afterwards :-)

Hey @nlubisch,
please consider the comment from @teiling88

Done :) Travis might fail, without the code style changes

Hey @nlubisch ,
could you please rebase your Branch. Travis should be now green

Done :)

Hi @nlubisch, your PR was merged in aa5100d8f192770e783874b96cdb854272574a26. Thank you very much for your contribution! 💙 🎉


ServiceWorker supported flag

It would be great if the UpUp library were able to expose a simple flag that indicates whether the current browser supports ServiceWorkers or not.

This is already open as #1.
It would be helpful if you could describe the use case you have for this, so that we can find the best possible API design for this.

This is already open as #1.
It would be helpful if you could describe the use case you have for this, so that we can find the best possible API design for this.

I've added my thoughts to https://github.com/TalAter/UpUp/issues/1

I've added my thoughts to https://github.com/TalAter/UpUp/issues/1


Create DL

Unable to merge even after review
On Fri, 17 Feb 2023, 15:55 Ryko24, @.***> wrote:

@.**** commented on this pull request.
Just for merge
—
Reply to this email directly, view it on GitHub
https://github.com/github/codespaces-jupyter/pull/38#pullrequestreview-1303110346,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYGVWRJA75E2ZUYXBNUTCX3WX5G2NANCNFSM6AAAAAAU7F54IQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Adds node-fetch to fastbootDependencies

Adds node-fetch to fastbootDependencies
This PR fixes Ember Simple Auth from breaking in Fastboot when using the OAuth2PasswordGrant authenticator, as referenced in #1138. The fix is to simply add node-fetch to the addon's whitelisted fastbootDependencies.
"ember-addon": {
  "configPath": "tests/dummy/config",
  "fastbootDependencies": {
    "node-fetch"
  }
}

See below for updated PR info.

I think this won't work because of ember-fastboot/ember-cli-fastboot#188

You're right. I've changed the PR to simply update the README to notify of the need to add node-fetch to the app's whitelisted fastbootDependencies.


Power BI Premium Capacity App role requirements

This is regarding https://docs.microsoft.com/en-us/power-bi/service-admin-premium-monitor-capacity
Not all users can install or access the app. Please mention the role requirement in the documentation for this after confirming from the Product Group. Thanks!

Hi, @haider392 -- thanks for your question! Referring to the author to investigate.

More than 1 year old git issue from internal. Closing.


Keyboard key

Hi,
local set_off_key =  can we assign a keyboard key?
Thanks.

@mcgbg
Yes, but only the special buttons of the Logitech game keyboard. (G key and M key)
You can open C:\Program Files\Logitech Gaming Software\Resources\Doc\G-seriesLuaAPI.pdf, and then modify this statement.
if (event == "MOUSE_BUTTON_PRESSED" and arg == set_off_key) then


:heavy_minus_sign: remove asynctest dependency

Replaces asynctest with unittest in all modules
Includes formatting changes from #448. Marking as draft until that one's merged

For some reason the relay image in redis-events was bumped to pydantic 2, causing the prev test failures. Resolved this by pinning pydantic <2 in redis-events/docker/services/

This one's probably harder to review, but it's all in the 3f7a901 commit!
To help summarise: all of the asynctest imports can essentially be swapped to unittest.
So we had from asynctest import mock as async_mock, and then everywhere that async_mock.MagicMock is used, that can be swapped for unittest.MagicMock. Same with patch, AsyncMock, etc.
Lastly, AsyncTestCase is now IsolatedAsyncioTestCase, and the setUp method had to be renamed to asyncSetUp.
That's it! Works like a charm.
Main motivation is not wanting deprecated dependencies, but also to get the testing framework in sync with ACA-Py (as in https://github.com/hyperledger/aries-cloudagent-python/pull/2566 and https://github.com/hyperledger/aries-cloudagent-python/pull/2755), helps with maintainability across the repos


⚠ Bofrost.de has degraded performance

In eb481d0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1001 ms

Resolved: Bofrost.de performance has improved in 98dd0c5.


Fixed #27678 - Documented that template system isn't safe against untrusted authors

See https://code.djangoproject.com/ticket/27678 for details .

This means that template authors have possibility to access any file on filesystem or
Python package and interpreting them as Python code or text.

That's not what I meant and as far as I know, shouldn't be the case (but maybe you can give an example). I had in mind issues like XSS and arbitrary variable access, e.g. {{ request.user.groups.source_field.opts.app_config.module.admin.settings.SECRET_KEY }}

@timgraham thanks for comment! yeah, I was misled by conversation in corresponding thread. I was unable to reproduce behaviour I mentioned initially, that's why changed documentation according your comment.

@timgraham any updates on this?


Update MD file on new branch 2017-28-28_09-11-13

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


src/README.md is very outdated

See title.
I would fix it myself, but I'm not so sure what should be written in there for the folders with no description.

@mDuo13 is responsible for documentation I think. :-)

@mDuo13 - can we close this? Looks like #2124 addresses this issue.


Beautifier adding unneeded backslash to SASS and SCSS code

Description
The beautifier is adding an unneeded \ to SASS and SCSS code.
The \ makes the code invalid according to stylelint:
×  Unexpected unknown type selector "\:"   selector-type-no-unknown

Input Before Beautification
This is what the code looked like before:
html
  ::selection
    color: white

Expected Output
The beautified code should have looked like this:
html
  ::selection
    color: white

Actual Output
The beautified code actually looked like this:
html
  \::selection
    color: white

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Debug
Here is a link to the debug.md Gist: https://gist.github.com/Richienb/ddfa4898b537eedbff86998849cb2607
Checklist
I have:

[x] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] Reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[x] Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
[x] Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue

It seems from https://github.com/SassDoc/sass-convert/issues/23 that SassConvert is deprecated, it does not look like this defect will be resolved.

@prettydiff Looks like atom-beautify is using sassconvert as a  dependency, not sass-convert. :confused:

Link me to the correct project please,

@prettydiff My bad, I though it was an npm package.
Still I don't see Sassdoc's sass-convert being used here, instead directly the old Ruby Sass binary.


Driver not robust to instrument's watercolumn(?) failure modes

On our most recent dive (nui044), we had an issue where the driver entirely stopped publishing data in the middle of a survey line.
We did not have suffient logging enabled during the dive to definitively say what caused the problem, but I was able to reproduce a similar issue on the bench with tcpdump running, and found an issue with the driver that could explain it.
(On the bench, we got several-second-long freezes, rather than the several-minute-long one we saw in the dive, and which was terminated by us powering off the sonar at the end of the survey line.)
Sometimes the instrument appears to stop sending WC data in the middle of a packet, causing the driver to entirely block. There are a couple of possible solutions to this, but for this cruise, we're simply planning to turn off watercolumn data. Possible future fixes:

Add timeouts to the read so it fails rather than blocking if all data is not available
Run the Range and WaterColumn data in separate threads, using separate io_service objects to service them.
A different implementation of the disconnectTimer concept might also help with this problem -- right now, its callback isn't called until after the read returns, which is later than would be maximally useful.
The current scheme for resynchronization simply checks chunks of 24 bytes for whether they match the 0xDEADBEEF preamble and have the correct version. I'm not sure whether it resets when a new TCP packet arrives, or if we need to worry about winding up with an offset and not ever re-synchronizing.
It doesn't seem to cause any problems, but on restarting the sonar, the data callbacks will often be called with a buffer full of 0's.

Details
I've attached the raw data used while digging into this problem.
Test setup:

sonar_gui3.pcap : running driver + Norbit GUI in parallel.
sonar_no_gui.pcap : running only the ROS driver, GUI not started.

We originally thought the problem might be due to connecting to the sonar from both the Norbit Windows GUI and the ROS driver at the same time, but it seems to be independent.
For both, we logged all packets using tcpdump:
sudo tcpdump -i any port 2210 or port 2209 or port 2211 -w sonar_no_gui.pcap
And then examined them using wireshark.
I also added some additional debug statements to the code; that version is available in the debug_output branch (https://github.com/lauralindzey/norbit/tree/debug_output)
I've attached excerpts of the roslog output as txt files. The easiest way to find correspondences between them is to search for "set_power" in both -- it will appear in the initial configuration and then again whenever the driver is trying to check whether the connection to the sonar is alive.
To search within packet data using wireshark:

edit -> Find Packet
Select "packet bytes" and "string"

Watercolumn data comes in on port 2211, ranges on 2210, and configuration data on 2209.
sonar_gui3
sonar_gui3.txt
In the sonar_gui3 run, the watercolumn packet that is started at 238.736273 is supposed to have
0x00 02 54 c0 = 152678 bytes, but after 11 x 1448 byte packets, there's a [TCP Spurious Retransmission], then no more data.
This header corresponds to the ROS_INFO at<PHONE_NUMBER>.569119496.
After a header is received, the driver calls read(...), requesting the number of bytes in the message. This read blocks until<PHONE_NUMBER>.803330884, but the bytes it eventually received did not correspond to a full message.
sonar_no_gui
sonar_no_gui.txt
At 1623.563757 in the pcap file the driver queries the current status of power with set_power. This corresponds to the ROS_INFO at<PHONE_NUMBER>.920297907.
The header received at<PHONE_NUMBER>.923774134 (ROS) corresponds to a packet at 1617.356318 (pcap/wireshark), which is supposed to have 0xc0a4 = 49316 bytes. After 13 x 1448 byte packets ( = 18824 bytes), there's a gap where a range measurement is reported, then a single packet on port 2211, then more range measurements. The ROS driver blocks for 6 seconds, and then after resetting both streams re-sync up.

Unfortunately, the pcap files are too large to upload via github. They can be downloaded from Dropbox here:
https://www.dropbox.com/scl/fo/q7kr35rl0mewbn7ung0vi/h?rlkey=lsj6owyx03pykuq26bsdhjrll&dl=0

@lauralindzey Thanks for the bug report.   Unfortunately, I won't be able to dig deeply into this for a while as I am not currently supported to work on this project.   If you end up Implementing/testing one the the solutions you listed I encourage you to make a pull request according to our CONTRIBUTING guidelines.
Looking at your sonar_gui3.txt log it seems there are lots of failed versions/preable failure.  In my experience, this is usually an indication of poor network performance.
In the near term,  I would suggest double checking  your cabling or using a spare whip if you have one.     We have had numerous problems with flaky network connections over the whips and connectors supplied by Norbit on Hercules.

Looking at your sonar_gui3.txt log it seems there are lots of failed versions/preable failure. In my experience, this is usually an indication of poor network performance.

Yes -- those correspond to the driver trying to synchronize with the sensor again, and show up whenever a packet is dropped. And when viewing the pcap data with Wireshark, there are long gaps in data to the 2211 port along with warnings about "spurious retransmission" / "duplicate ack".


Relax std constraint of sp-runtime::testing

Hand picks conditional serde or std features and frees everything else for core usage.

Can you explain why you need this?

@bkchr It was about using TestXt in a no_std context.
At the end of the day, I simply copied and pasted the source code to create a new bare-bones TestXt without hard serde dependency so now this PR isn't necessary anymore.
Thanks for you time


Initial offset for iphone X is a bit buggy

iPhone X

Others

Facing the same issue ... Any solution pls??

It's an issue of the demo app rather than an issue of the library itself due to the fact that in SearchViewController, the Visual Effect View is pinned to the safe area bottom constraint.
If you want to fix that, you should

pin that view bottom to the superview bottom
embed the subview in a new view where the bottom is pinned to the safe area bottom
update the pullUpControllerMiddleStickyPoints accordingly.