Resolve callback not registered for key

Hey, thanks for the awesome plugin, it works like a charm but i found one annoying thing, at least on my device.
Describe the bug
Registering for a notification on ios spams the xcode log with
Resolve callback not registered for key:  read|03257878-BEB5-4087-AB68-AE6A82E4C4D9|095AAC41-C04D-436F-93C1-8EF1CEA45016
Resolve callback not registered for key:  read|03257878-BEB5-4087-AB68-AE6A82E4C4D9|095AAC41-C04D-436F-93C1-8EF1CEA45016
Resolve callback not registered for key:  read|03257878-BEB5-4087-AB68-AE6A82E4C4D9|095AAC41-C04D-436F-93C1-8EF1CEA45016
Resolve callback not registered for key:  read|03257878-BEB5-4087-AB68-AE6A82E4C4D9|095AAC41-C04D-436F-93C1-8EF1CEA45016
Resolve callback not registered for key:  read|03257878-BEB5-4087-AB68-AE6A82E4C4D9|095AAC41-C04D-436F-93C1-8EF1CEA45016
Resolve callback not registered for key:  read|03257878-BEB5-4087-AB68-AE6A82E4C4D9|095AAC41-C04D-436F-93C1-8EF1CEA45016

The code actually works but its impossible to read the log while data is received.
To Reproduce
Subscribe to a notification on ios, e.g.:
export async function testble() {
    await BleClient.initialize();
    await BleClient.connect("1D2E8511-890B-1D32-C6EA-C838ADFA652A", (deviceId:string) => onDisconnect(deviceId));
    await BleClient.startNotifications(
        "1D2E8511-890B-1D32-C6EA-C838ADFA652A",
        "03257878-beb5-4087-ab68-ae6a82e4c4d9",
        "095aac41-c04d-436f-93c1-8ef1cea45016",
        (value:DataView) => {
            // something with the data
        }
    );
    setTimeout(async () => {
        await BleClient.stopNotifications("1D2E8511-890B-1D32-C6EA-C838ADFA652A", "03257878-beb5-4087-ab68-ae6a82e4c4d9", "095aac41-c04d-436f-93c1-8ef1cea45016");
        await BleClient.disconnect("1D2E8511-890B-1D32-C6EA-C838ADFA652A");
        console.log('disconnected from device', "1D2E8511-890B-1D32-C6EA-C838ADFA652A");
    }, 10000);
}

Then watch the xcode debug log.
Expected behavior
Should not spam the log output with a wrong message.
Plugin version:

@capacitor-community/bluetooth-le: 1.8.3

Smartphone (please complete the following information):

Device: ipad air 4
OS: 15.7

Additional context
The problem seems to happen in
https://github.com/capacitor-community/bluetooth-le/blob/7eb0a34f2533980f372cb2168cf2a5f6cea2ea86/ios/Plugin/Device.swift#L188

Thank you for reporting this. You are right, on iOS there are always Resolve callback not registered for key logs when using notifications. I will look into this.

This has been fixed in v2.1.0. Also the logs of the plugin now respect the loggingBehavior of the Capacitor config of your app (https://capacitorjs.com/docs/config#schema).


Remove gems until we need them, simplify specs

https://trello.com/c/CPWJzL9y/5-create-skeleton-rails-app
The preference from Tijmen and Kevin is to keep the spec_helper short and avoid having a rails_helper and a spec_helper.

The card for this specifies that we should be adding in sidekiq, rspec, gds-sso and govuk_app_config gems.  Have I missed a conversation that has changed this?

Oops - one too many. We arrived at only including the gems we need right now, so we can lose Sidekiq as we don't have any jobs yet and rake still runs without it. The app_config one we should keep (I'll put it back) as the next thing to do will be to check logs 'n stuff work.


docs: pinned footer to the bottom of page regardless of page size

Checklist

[x] commit message follows commit guidelines.
[x] website builds and runs in production - for information on how to test locally go here.

Description
Adjusted the CSS file to pin the footer to the bottom of the page regardless of page size.
Related Issues
Fixes: https://github.com/appsody/website/issues/136

Footer seems to be half hidden on short documentation

Fixed


[Snyk] Upgrade @docusaurus/preset-classic from 2.0.0-rc.1 to 2.1.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @docusaurus/preset-classic from 2.0.0-rc.1 to 2.1.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released a month ago, on 2022-09-02.

Release notes

Package name: @docusaurus/preset-classic

2.1.0 - 2022-09-022.1.0 (2022-09-01)
🚀 New Feature

docusaurus-theme-classic, docusaurus-theme-common

#8008 feat(theme): ability to use <DocCardList> without items prop, on any doc page (@ slorber)

docusaurus-plugin-content-docs, docusaurus-theme-classic

#7963 feat(docs): allow to configure noIndex per doc version (@ slorber)
#7949 feat(plugin-docs): docs sidebar item link: support "autoAddBaseUrl" attribute (@ slorber)

docusaurus-theme-translations

#7953 feat(theme): adds Ukrainian default theme translations (@ b-ovsepian)

🐛 Bug Fix

create-docusaurus

#8032 fix(create-docusaurus): tutorial and init template improvements (@ slorber)

docusaurus-preset-classic

#8029 fix(preset-classic): broken link in "unrecognized keys" error message (@ mdubus)

docusaurus

#7977 fix(core): preload should support encoded page links (@ adventure-yunfei)
#7996 fix(core): CLI command write-translations should extract translations from @ Docu… (@ slorber)
#7952 fix(core): allow overriding ssr/dev template meta tags (@ slorber)

docusaurus-plugin-sitemap

#7964 fix(sitemap): filter all routes with robots meta containing noindex (@ slorber)

docusaurus-theme-classic

#7910 fix(theme-classic): code block line number display with line wrapping (@ yzhe819)
#7786 fix: collapse siblings when first category is selected (@ whiteand)

💅 Polish

docusaurus-theme-classic

#7982 fix(theme): add aria-label to skip to content link region (@ YoniChechik)
#7940 refactor(theme-classic): split AnnouncementBar, increase z-index, use shadow (@ slorber)
#7876 refactor(theme-classic): make tag text visually certered (@ Kosai106)

docusaurus-utils

#7941 feat(core): add new Webpack file-loader extensions: avif, mov, mkv, mpg, avi... (@ slorber)

docusaurus-theme-classic, docusaurus-types

#7942 feat(theme-classic): use lang attribute in navbar locale dropdown items (@ slorber)

docusaurus-theme-translations

#7928 chore(theme-translations): complete vi translations (@ datlechin)

📝 Documentation

create-docusaurus

#8032 fix(create-docusaurus): tutorial and init template improvements (@ slorber)

docusaurus-plugin-content-blog, docusaurus-plugin-content-docs, docusaurus-plugin-content-pages, docusaurus-plugin-debug, docusaurus-plugin-google-analytics, docusaurus-plugin-google-gtag, docusaurus-plugin-ideal-image, docusaurus-plugin-sitemap, docusaurus-theme-classic

#7905 docs: remove mention of beta (@ Josh-Cena)

Committers: 10

Bagdasar Ovsepyan (@ b-ovsepian)
Joshua Chen (@ Josh-Cena)
Kevin Østerkilde (@ Kosai106)
Morgane Dubus (@ mdubus)
Ngô Quốc Đạt (@ datlechin)
Sébastien Lorber (@ slorber)
Yoni Chechik (@ YoniChechik)
@ whiteand
@ yzhe819
adventure-yunfei (@ adventure-yunfei)

2.0.1 - 2022-08-012.0.1 (2022-08-01)
Fix bad npm publish of 2.0.0
Committers: 1

Sébastien Lorber (@ slorber)

2.0.0 - 2022-08-012.0.0 (2022-08-01)
Bad npm publish, please use 2.0.1
💅 Polish

docusaurus

#7781 refactor(core): log Docusaurus & Node version before exiting (@ Josh-Cena)

Committers: 2

Joshua Chen (@ Josh-Cena)
Sébastien Lorber (@ slorber)

2.0.0-rc.1 - 2022-07-142.0.0-rc.1 (2022-07-14)
🐛 Bug Fix

docusaurus

#7776 fix(core): swizzle --eject js should not copy theme .d.ts files (@ slorber)
#7750 fix(deploy): revert "feat(deploy): copy local git config to tmp repo (#7702)" (@ ghostsquad)

docusaurus-plugin-sitemap

#7774 fix(sitemap): complete gracefully when all pages have noIndex meta (@ Josh-Cena)

docusaurus-theme-classic

#7771 chore: bump Infima to 0.2.0-alpha.42, fix a:hover link bug (@ slorber)
#7755 fix(theme-classic): validate options properly (@ Josh-Cena)
#7752 fix(theme-classic): fix Layout theme height CSS (@ LichLord91)

docusaurus-migrate

#7766 fix(migrate): import siteConfig with file extension (@ Josh-Cena)

docusaurus-theme-search-algolia

#7761 fix(algolia-search): test for canUseIntersectionObserver (@ RoiArthurB)

💅 Polish

docusaurus-theme-translations

#7762 chore(theme-translations): complete ko translations (@ anaclumos)

📝 Documentation

docusaurus-plugin-content-docs

#7706 docs: release process, versioning, breaking changes, public API surface (@ slorber)

🔧 Maintenance

docusaurus-theme-classic

#7777 refactor(theme): fix duplicate page metadata usage (@ slorber)
#7771 chore: bump Infima to 0.2.0-alpha.42, fix a:hover link bug (@ slorber)

Committers: 11

Arthur Brugière (@ RoiArthurB)
Bruce Song (@ recallwei)
Evan (@ DigiPie)
Jeffrey Aven (@ jeffreyaven)
Joshua Chen (@ Josh-Cena)
Sunghyun Cho (@ anaclumos)
Sébastien Lorber (@ slorber)
The Nguyen (@ treoden)
Wes McNamee (@ ghostsquad)
@ LichLord91
凱恩 Kane (@ Gary50613)

    from @docusaurus/preset-classic GitHub release notes

Commit messages

Package name: @docusaurus/preset-classic

be9b094 v2.1.0
26d2b9a chore: backport retro compatible commits for the Docusaurus v2.1 release (#8033)
bb65b5c chore: release v2.0.1 (#7919)
2ef40c2 chore: Netlify branch deploys should only deploy default locale "en" (#7788)
d88f248 chore: add Netlify config for major version branch deploys (docusaurus-v2 branch) (#7787)
e4fc47b Merge branch 'main' into docusaurus-v2
7f40350 chore: fix codesandbox playgrounds, use Node.js 16 version (#7784)
1065e55 refactor(core): log Docusaurus & Node version before exiting (#7781)
965a01e chore: port-2.0.0-rc.1 (#7782)
e78a15e chore: ci tests should run on version branches "docusaurus-vX" (#7783)
c751bc6 chore: regen v2.0.0-rc.1 examples (#7780)
d255389 chore: prepare v2.0.0-rc.1 release (#7778)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Base: 85.15% // Head: 85.25% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (854addc) compared to base (aff1547).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   85.15%   85.25%   +0.09%
==========================================
  Files          34       34
  Lines        2008     2008
==========================================
+ Hits         1710     1712       +2
+ Misses        239      238       -1
+ Partials       59       58       -1

Flag
Coverage Δ

unittests
85.25% <ø> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/pkg/generate/clean_scripts.go
94.24% <0.00%> (+1.43%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Closing this as a duplicate PR was merged to develop


Added support for variable arguments in nn importer. Fixes #328

Also do you mind fixing the 2 code climate issues?

thanks!


Apply an ad-hoc signature after modifying IDs

If we make any changes to a signed binary, we invalidate the signature. Without resigning, the resulting binary is unusable. To my knowledge, there's no disadvantage to signing an unsigned binary using an ad-hoc signature, so we can just do this unconditionally to ensure we don't end up creating bad binaries. The ad-hoc signature should always be available and always work, so this should be safe to do in all circumstances.
I do still need to confirm which OS versions this will work with.

I'm having an issue on the Big Sur beta that fails some ruby gem builds with this error, is it related?:
Error: Failed to read Mach-O binary: /usr/local/Cellar/test-kitchen/2.7.2/libexec/extensions/universal-darwin-20/2.6.0/bcrypt_pbkdf-1.0.1/bcrypt_pbkdf_ext.bundle
Error: An exception occurred within a child process:
  MachO::LoadCommandError: Unrecognized Mach-O load command: 0x80000034

@SMillerDev That's unrelated, but it's also a new change to Mach-O:
#define LC_DYLD_EXPORTS_TRIE (0x33 | LC_REQ_DYLD) /* used with linkedit_data_command, payload is trie */
#define LC_DYLD_CHAINED_FIXUPS (0x34 | LC_REQ_DYLD) /* used with linkedit_data_command */

I'll create a PR for it in a moment.


How config Formatter to show today, yesterday, %d days ago?

I read the source code,
DateInRegionFormatter.colloquial(from fDate: DateInRegion, to tDate: DateInRegion)

still can't figure out how to use colloquialSinceNow() function to format by nature daily, like:
`today`, `yesterday`, `%d days ago`

Is there configrable? Thank you.

You should set allowedComponents to day in order to avoid formatting with lower time components.
Cannot try it right now but it should be:
let fmt = DateInRegionFormatter()
fmt.allowedComponents = [.day]
let formatted = try fmt.colloquial(from: fromDate, to: toDate).colloquial

It works. Thank you so much.


rlimGui.h missing function

Your example "editor.cpp" uses rlImGuiImageRenderTextureFit although this function seems to be missing from rlImGui.h.

After looking at rlImGui.h in the github repository, the function is actually there. Not too sure why the rlImGui.h in my project is missing so many functions.


Is it possible to swap the parser/deserializer?

I've run into some issues where the JSON parser has issues with nested objects, is it possible to swap out the parser that cometd is using in this abstraction?  If not, it might make sense to allow the Consumer to take a String and use message.getJSON() instead to provide better handling there.  Let me know if you want to go the string route, I'm happy to write a PR for that.

I will look at it and see what I can do.

Consumers can get String version of the message and parse it themselves. In future, we'll add support for payload format so consumers will be able to read the message based on an event's schema.


[skip CI][WIP] PoC: Revamp optimizer and scheduler experience using registries

What does this PR do?

Fixes #752
Optimizer and scheduler can currently be an instance but that doesn't comply with the way the code works since you need the model to the instantiate optimizer and need the optimizer to instantiate the scheduler. The main idea is to use the FlashRegistry class for this.

The ultimate idea is provide a zero code experience both during class instantiation and from Flash Zero perspectives.

This PR focuses on fixing this issue using a few ideas:

[x] To pass a partial function which instantiates the optimizer or scheduler given the object it needs to wrap
[x] Use the scheduler registry: So in theory you can select a scheduler with a string.

Some ideas on how we can use the registry is mentioned in the issue #752

On step or Monitor for LR
Still in progress ...
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Dear @karthikrangasai,
I added some modifications. Still wip.
Do you think we should remove entirely optimizer_kwargs and scheduler_kwargs ?
Adding support for a tuple seems slightly counter-intuive as users might want to control arguments through keyword arguments.
Best,
T.C

Hey @SeanNaren @ethanwharris.
Should we drop learning_rate from the Tasks and force kwargs directly ?
Best,
T.C


Problem with partial BleAdapterConfiguration for iOS adapter init

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[X] iOS
[] Android
[] tvOS
[] macOS
[] .NET Standard
UWP IS NOT SUPPORTED DURING THE BETA PERIOD - ONLY PRs ARE WELCOME FOR NOW

Version of OS(s) listed above with issue
noted with iOS 12, probably others. Does not seem iOS version specific
Version of Library
seen in 6.2.3, not present in 6.0.3
Expected Behaviour
When initializing an adapter on iOS, the two options are to provide a config or not provide a config in the call to CrossBleAdapter.Init. In version 6.0.3 there used to be default values assigned to each field in the BleAdapterConfiguration, but they were removed, as was the default config. In our code we used to create a config object (which gave it the defaults) and then only changed the values we wanted differently, for example:
BleAdapterConfiguration adapterconfig = new BleAdapterConfiguration();
adapterconfig.ShowPowerAlert = true;
CrossBleAdapter.Init(adapterconfig);
But when using 6.2.3 this seems to no longer work as expected and instead the adapter status always reports AdapterStatus.Unsupported.
The expected behavior is that the AdapterContext c'tor for Apple, which consumes the config, sets appropriate values, if these aren't provided. It does seem to do so, based on our code review, but something is still amiss. When we change our code to
BleAdapterConfiguration adapterconfig = new BleAdapterConfiguration();
adapterconfig.ShowPowerAlert = true;
adapterconfig.DispatchQueue = new CoreFoundation.DispatchQueue("acrble");
adapterconfig.RestoreIdentifier = "acr";
CrossBleAdapter.Init(adapterconfig);
Then the adapter works again. Our apologies if we missed something!
Actual Behavior
Please see the expected behavior description above. Thank you very much for looking into this! We will try to dig in some more as well.
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
If you have a complaint about the docs, FIX IT - DO NOT FILE IT HERE!  I won't guarantee everything is always 100% up-to-date since I am just 1 person.
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

Same Problem here.
But if run without CrossBleAdapter.Init() in the AppDelegate
the AdapterStatus will always be unknown before I show the alert dialog via
await UserDialogs.Instance.AlertAsync(alertConf);
once I showed the dialog the AdapterStatus come to PowerOn immidiately,then everything working fine as usual.

@liu12010 "Same" replies are unhelpful.  This is a non-critical issue which I will look into with a future version.  In the meantime, you should be using Adapter.WhenStatusChanged() or ScanExtra in any case.

This is resolved in Shiny.BluetoothLE


[Bug]: UI Audit issues

Is there an existing issue for this?

[X] I have searched the existing issues

Description
https://www.notion.so/appsmith/639268ce2a61403cad6471e3ae99dbdc?v=d6182a27446144bfa718875754e3a2b0&p=aed82dfd4579485e866e5ee4c14b207a&pm=s
Steps To Reproduce

Create google sheet datasource
check for all the issues mentioned above

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud/ Self-Hosted - 1.9.15

Creating separate ticket for each issue


script places dh parameters in wrong place

Hi,
the howto says
https://medium.com/@pentacent/nginx-and-lets-encrypt-with-docker-in-less-than-5-minutes-b4b8a60d3a71
use this:
include /etc/letsencrypt/options-ssl-nginx.conf;
ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem;
But the script puts the files in
/etc/letsencrypt/conf/options-ssl-nginx.conf;
At least thats what happened in my case.

Hi,
That is correct, if I am not mistaken, then this is not an issue.
There is a mapping concerning the volume mounting between the two containers nginx and certbot. See relevant lines in docker-compose.yml:
  nginx:
    volumes:
      - ./data/nginx:/etc/nginx/conf.d
      - ./data/certbot/conf:/etc/letsencrypt <-- here!
      - ./data/certbot/www:/var/www/certbot
      . . .
  certbot:
    volumes:
      - ./data/certbot/conf:/etc/letsencrypt
      - ./data/certbot/www:/var/www/certbot
     . . .

so the script saves to hostmachine on $datafolder/conf which is thus ./data/certbot/conf and that is mounted to the nginx container to the path /etc/letsencrypt.
Resolves issue?


[BUG] Broken icons on display

Bug report
When I display the icons, they are broken
I recorder the issue displaying all icons:
https://www.youtube.com/watch?v=-OSxfgaY-6E
Describe the bug
I have added screens for display from HomeAssistant and recorded what is displayed.
I'm using Ulanzi TC001 using ulanzi-easy.yaml configuration (adding the image and animations sections)
I tried tweaking the settings, nothing worked.
Generated html file with icons looks correct to me.
It feels to me that animation frames are correct, but the images themselves are broken, some contains colors not present in original icons, perhaps the problem with RGB565 reading?
Startup animation (extending box) and bootup logo is correct.
I'm new to ESPHOME.
Also sometimes I see crash from console I think on bootup only.
The device is new, I might have new revision, I needed to add mode: INPUT_PULLUP for other buttons to work, and device couldn't be flashed from website with tasmota at first, I used esptool.py, it complained that the device is not in BOOT stage.
Additional information

used Hardware:

Ulanzi TC001 ESP32-D0WD
EspHoMaTriXv2 version: master branch > 2024.12.0, I tried other versions too

To Reproduce
Flash ulanzi-easy.yaml to the clock and attempt to display the icons after fixing missing sections
Expected behavior
Proper icons should be displayed
Screenshots
https://www.youtube.com/watch?v=-OSxfgaY-6E
Logs
Might be unrelated, I think it happens on bootup sometimes.
Guru Meditation Error: Core  0 panic'ed (IllegalInstruction). Exception was unhandled.
Memory dump at 0x401836fc: 9890ef29 00000000 00000000
Core  0 register dump:
PC      : 0x40183701  PS      : 0x00060430  A0      : 0x8018330d  A1      : 0x3ffcda90
A2      : 0x3ffde950  A3      : 0x00000001  A4      : 0x00000005  A5      : 0x00000020
A6      : 0x3ffbfb90  A7      : 0x00060b23  A8      : 0x00000020  A9      : 0x00002009
A10     : 0x00000001  A11     : 0x003fffff  A12     : 0x80084347  A13     : 0x3ffbd110
A14     : 0x00000001  A15     : 0x3ffcc260  SAR     : 0x0000001b  EXCCAUSE: 0x00000000
EXCVADDR: 0x00000000  LBEG    : 0x40089ddc  LEND    : 0x40089df2  LCOUNT  : 0xffffffff

Backtrace:0x401836fe:0x3ffcda900x4018330a:0x3ffcdab0 0x4018338a:0x3ffcdae0 0x40183551:0x3ffcdb00 0x401580f9:0x3ffcdb40 0x4015891b:0x3ffcdb70 0x4018479f:0x3ffcdbb0

Some other warnings
[W][esp-idf:000]: E (228288) system_api: Base MAC address from BLK3 of EFUSE version error, version = 0

No new logs when requesting icon screens or displaying them
Services calls
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      screen_time: 4
      lifetime: 10
      icon_name: error
      text: error
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      icon_name: home_assistant
      text: home_assistant
      lifetime: 10
      screen_time: 4
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      icon_name: temperature
      text: temperature
      lifetime: 10
      screen_time: 4
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      icon_name: lightbulb
      text: lightbulb
      lifetime: 10
      screen_time: 4
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      icon_name: music
      text: music
      lifetime: 10
      screen_time: 4
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      icon_name: phone
      text: phone
      lifetime: 10
      screen_time: 4
  - action: esphome.tclock_rainbow_icon_screen
    metadata: {}
    data:
      default_font: true
      icon_name: car
      text: car
      lifetime: 10
      screen_time: 4
  - action: esphome.tclock_full_screen
    metadata: {}
    data:
      icon_name: sleep8x32
      screen_time: 3
      lifetime: 10
mode: single

Look this https://github.com/lubeda/EspHoMaTriXv2/issues/255

Thank you!
latest branch/tag works correctly


ReferenceError: Reveal is not defined

Getting 404 everywhere

Sounds like bower install did not run on travis 🔴

It worked! 🚀
https://github.com/GabLeRoux/to-pull-or-not-to-pull/tree/gh-pages/bower_components


Debugging in RazorEngine in VS 2015

Hi,
After migrating my project to VS 2015 I can't debug razor cshtml files anymore,
despite of using LoadedTemplateSource and setting the config.Debug to true. I'm also setting the same file I'm setting breakpoint on in the LoadedTemplateSource.
Do you see any possible cause of this problem?
One more note: I'm also getting design-time errors that say that c# 3 features are not available while editing the file in visual studio, but RazorEngine compiles the template properly. Maybe this issue is connected to the debugging problem.

to enable debug go on Tools > Debugging > General
and enable "Suppress JIT optimization on module load"


[Bug][Manager] InlongGroupInfo defined two fields of pulsar, but put them in extension properties

What happened
InlongGroupInfo use  pulsarAdminUrl and pulsarServiceUrl  to specify pulsar parameters.
These two fields will not be init when init InlongGroupInfo bean, but put in extension properties.
The copy from InlongGroupExtEntity to InlongGroupInfo will ignore these two fields cause they are not in
InlongGroupExtEntity, but in InlongGroupExtEntity.
When query table inlong_group_ext, these two params will be put in extList field of InlongGroupInfo, instead of corresponding fields.
What you expected to happen
put them in correct fields.
How to reproduce
When call InlongGroupService::get method
Environment
No response
InLong version
master
InLong Component
InLong Manager
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

db model has been changed , this issue will be closed


[v 0.5] - Obsrv Core

This pull request introduces the core data streaming jobs for the obsrv application. These jobs have been designed to process, enrich, and validate data from various sources, making them highly adaptable to a wide range of datasets.
The data streaming jobs are built with a generic approach that makes them robust and able to handle diverse datasets without requiring significant changes to the underlying code.
Features

Core Streaming Jobs
Unit Test cases (90% Code coverage)
Github actions automation script

The changes look fine.


require('codesnippet') from players personal code snippets book

In order to improve the teaching, please add a CodeSnippetsBook where player can add re-usable CodeSnippets by writing something like:
[CodeSnippetsBook - PAGE [1/N]
// "FindEasyMoney" Snippet
module.exports = function getNextCoin(SELF) {
    var coins = SELF.findByType("coin");
    for(var i=0, gold=[]; i<coins.length; i++) {
        if (coins[i].bountyGold > 1) { gold.push(coins[i]); }
    }
    return SELF.findNearest(gold);
};

[CodeSnippetsBook - PAGE [2/N]
// "MyCleaveAttackStyle" Snippet
module.exports = function attackWithCleave(SELF) {
    for (var i=0, enemies = SELF.findEnemies(), closeEnemies=[]; i<enemies.length; i++) {
        if (SELF.distanceTo(enemies[i]) < 10) {
            closeEnemies.push(enemies[i]);
        }
    }
    if (closeEnemies.length > 2 && SELF.isReady('cleave')) {
        SELF.cleave();
    } else if (enemies) {
        SELF.attack(SELF.findNearest(enemies));
    }
};

Now in his next game mission
With this, the learner could now use his personal "best practices" to come up with solutions.
var attackWithCleave = require('MyCleaveAttackStyle');
var getNextCoin = require('FindEasyMoney');

loop {
    var enemy = this.findNearestEnemy();
    if (enemy) {
        attackWithCleave(this);
    } else {
        getNextCoin(this);
    }
}

(=> Maybe in the future people could even browse other players snippets - just like real developers)

Nice idea!
Perhaps this issue can be merged with #2561? They seem to be duplicates.
I personally like the coding approach using modules more than an UI, but this is up to personal taste.  Since CodeCombat is about teaching how to code, teaching a module syntax could be a very nice addition as well.
Though, I'd personally prefer to see ECMAScript Modules syntax (introduced in ECMAScript 2015/ES6) rather than CommonJS, as the former is now part of the official language specification.

Alternatively, the modules could run with the same this binding as the main script, so you can just augment the this object and forget about the import/export syntax.
E.g., instead of
module.exports = function getNextCoin(SELF) {/*...*/};

Just use:
this.getNextCoin = function () {/*...*/};

I dislike the use of this a lot.
I strongly prefer to minimize the keywords i'm using.
So instead of:
/*
 Requirements:
  - understand 'this'
  - understand 'new'
  - understand 'prototype'
  - understand 'export'
  - understand 'import from'
*/
function Mammal(name){
	this.name=name;
	this.offspring=[];
}
Mammal.prototype.haveABaby=function(){
	var newBaby=new Mammal("Baby "+this.name);
	this.offspring.push(newBaby);
	return newBaby;
};
Mammal.prototype.toString=function(){
	return '[Mammal "'+this.name+'"]';
};
export default Mammal;
// USAGE:
import Mammal from 'Mammal';
var timmy = new Mammal('timmy');
var anna  = new Mammal('anna');

i rather write
/*
 Requirements:
  - understand 'require' (not a special keyword, just a function)
  - understand 'module.exports' (not a special keyword, just an object)
*/
function Mammal (name) {
  var data = { name: name, offspring: [] };
  return {
    haveABaby : function () { return _haveABaby(data); },
    toString  : function () { return _toString(data);  }
  };
}
function _haveABaby (data) {
  var baby = Mammal("Baby " + data['name']);
  data['offspring'].push(baby);
  return baby;
}
function _toString (data) {
  return '[Mammal "' + data['name'] + '"]';
}
module.exports = Mammal;
// USAGE:
var Mammal = require('mammal');
var timmy = Mammal('timmy');
var anna  = Mammal('anna');

Btw, i do not think that es6 import/export syntax will take over.
The vast majority of javascript modules, mainly on npm are written in commonJS style.
...and what is an 'official language specification' anyway. I rather follow what emerges in the community as best practice than to follow some kind of authority that claims to be the main source of truth.
I perceive es6 as a suggestion of a range of features from a certain group of people and i might adopt some of those or maybe i wont.
I need to hear some arguments why es6 features are better than what we already have and for some features i see the benefits but for import/export i fail to see that.

I dislike the use of this a lot.

I personally dislike this as well. However, CodeCombat uses this since the very first level -- it is just a reference to your hero.
You don't need to understand this, constructors and prototypes to play CodeCombat. This is because you can manipulate this to be any value you'd like via Function#call, (and also Function#apply, Function#bind), and that is what CodeCombat does IIRC.
I simply advocated using the same pattern for reusable code snippets, since I believe it would be confusing to have this referencing the hero in the main level editor and having this reference something else in module code -- e.g. copypasting code from the level editor to a module wouldn't work.
If this references the same object in all "modules" (let's consider the level editor code to be a module as well), then perhaps an import/export syntax would be unnecessary. Perhaps not having an import/export syntax would be confusing with regard to what gets exported and what doesn't. This needs more thought.
As for CommonJS vs ES Modules syntax, I'd rather not dive too deep into it as it may derail the thread, but I'll post my 2 cents in the next comment.

The vast majority of javascript modules, mainly on npm are written in commonJS style.

Yep, because CommonJS is so far the only natively supported module system in Node.js, and other tools such as Browserify also adopted it -- after all, CommonJS works great for the majority of use cases and there was no better module system when these platforms/tools were created.

Btw, i do not think that es6 import/export syntax will take over.

The ES Modules syntax has emerged from the shortcomings of the existing module systems. It solves problems such as static analysis of a module's dependency tree, thus offering better support for tooling such as IDEs and bundlers (e.g. Browserify does not handle CommonJS requires which depend on a runtime value).
ES Modules export bindings instead of values, which is overall better with regard to circular dependencies.
ES Modules will also be deeply ingrained in browsers in the not-so-far future (once they implement the Loader spec), playing a key role when HTTP/2 prioritization and server pushing resources from tool-generated dependency trees become mainstream.
The Loader spec will also allow customizing the module resolution logic, how to fetch it and even transform/normalize/transpile the module code on the fly.
The committee behind ES Modules went to great lengths to ensure that ES Modules will be the definitive, universal JavaScript module system. The other module systems paved the way to ES Modules.
... But of course, as far as I know, no JavaScript engine supports ES Modules syntax out of the box yet, hence code using ES Modules syntax must still be transpiled to CommonJS/AMD/UMD for the time being.

Ok, that would be really go into a long discussion.
But regarding the original topic, it's not helpful to leave "this" as something magic.
Currently, no level that i played teaches how to define functions and pass in arguments when calling them and this is not explained at all and remains some magic thingy.
Why?
Why would the game make kids extremely familiar with this, as its probably the most common thing they are going to type, but explain it not at all? They build their mental model around the stuff they learn only to get it ripped apart completely once they leave the game environment?
Wouldn't it be nice to teach them how they can "outsource" some code into functions?
It is horrible to introduce modules to them, but then make them pass in arbitrary state into every module, with no control over what is going to be manipulated on the this object, making the this object some kind of global scope thing in the context of code combat.

I agree with your points regarding this. I'm not sure why this direction was taken, but I can take guesses.
CodeCombat does teach how to use functions -- IIRC the first level to use functions is Vital Powers, which is around the 80~90th free-to-play level.
The default JavaScript code for that level uses this.fn = function() {}; syntax.
So when you call this.fn(), the this inside of the function will still reference the hero, allowing you to easily call the hero's methods with the syntax the player is used to (e.g. this.attack()).
Bu why actually it was decided to use this and not just a variable name (e.g. hero) to reference your hero is beyond me. We can wait for @nwinter to chime in.
I agree that leaving this as a mysterious construct is not good. But note that there are some inherent challenges when trying to explain this:

JavaScript's this is complicated. There are good resources available (as written by Angul Croll and Tim Caswell), but they aren't quite beginner-friendly.

The concept of "this" does not work exactly the same across different languages. Seems like this would require either language-specific levels or the same level would have to teach different concepts depending on the language (or skip over the intricacies and teach just the "basics", which may leave a lot of room for confusion).

Anyway, seeing as functions are a relatively new addition, I'd expect to see constructors/this classes/self explained by the ~130-150th level, and modules around the 180~200th. I'm just guessing though. I wonder if @nwinter has plans for these already?

So, if you break it down to its basics, this is just another argument passed to a function.
If you call a function that doesnt specify parameters, you have two "built in" methods to access whatever is explicitly or implicitly given to the function.

this
arguments

So if you specify the parameters instead, you do not need to rely on arguments, but you cannot specify a name for this and also this is not passed as an argument like ALL OTHER ARGUMENTS. There are multiple ways to pass in the argument for the thisparameter into the function. It could be through abindorcallorapplyor setting it throughnew` or invoking the function as a method of an object.
If it's your code or you know the conventions, then this might work fine, even though you can never be really sure. On top of that, javascript is a huge ecosystem and you need to use code written by others, where you might always end up wondering what this refers to know. The same is true when debugging and stepping through the debugger. You carefully have to think about and keep track of what this is all the time. Its as if i would use a parameter that i call x and use it everywhere - with no clue to what x actually means. This is considered very bad practice with variable names, but for some reason this is popular.
And like you said, another problem is, that this is not helpful to anyone coming from a language in which it works different.
For now, when I'm teaching, I always start out with the first line, letting them write:
var hero = this;

So that they can then move on in a way where everything makes sense, because once you start with utilizing functions or custom objects with methods, you also have to explain them apply or call and all kinds of weirdness they dont need to know to be more productice...

Excellent explanations. :smiley:
I've contemplated using var hero = this as well, as this is a common pattern when dealing with APIs that (ab)use this.


Missing bracket

Getting this error when i login, which then stops the addon from functioning.

That was a typo, fixed now.


Run GRPC Server Error：PHP Fatal error:  Uncaught Error: Class "OpenSwoole\GRPC\Server" not found in

I have checked the PHP extension and configured it numerous times. I'm sure there is no error.
php -m as follows:

php --ri openswoole as follows:

php code as follows:
`<?php
use Microservice\Admin\AdminService;
use OpenSwoole\GRPC\Middleware\LoggingMiddleware;
use OpenSwoole\GRPC\Middleware\TraceMiddleware;
use OpenSwoole\GRPC\Server;
$server = (new Server('<IP_ADDRESS>', 9501))
->register(AdminService::class)
->withWorkerContext('worker_start_time', function () {
return time();
})
// use middlewares
->addMiddleware(new LoggingMiddleware())
->addMiddleware(new TraceMiddleware())
->start();`
Why not? I'll be emotional. :(

Using Composer, the openswoole/grpc and openswoole/core extensions have been loaded.


Camera calibration file

To run the gscam node I am using a camera calibration file created from redtail/tools/camera_rig/widecam_mono_calibration/, yet I am getting a "Failed to parse camera calibration from file" error. It comes from "yaml-cpp: error at line 0, column 0: bad conversion".
Any suggestions? Was the calibration file supposed to be created by other means?

Most likely this happens because OpenCV FileStorage writes YAML file that is not compatible with most other YAML readers (e.g. Python etc). The problem is in the first line of the output file, that's why, for example, in our Python script we have to remove it.
However, there is a bigger issue: the calibration parameters are not actually used to undistort an image. The reason is gscam uses camera_info_manager from image_common which reads the calibration file and publishes it as a topic but does not actually perform undistortion. On the other hand, performing undistortion in our code (i.e. caffe_ros) node is too late as the node is subscribed to the output of gscam which means the image went through GStreamer pipeline like resizing etc so undistorting it does not make sense anymore/too late.
In our case, this was not a problem as our Iris drone used Microsoft HD5000 camera with 66 degrees of diagonal FOV so there was never any noticeable distortions.
For wide angle cameras we would certainly recommend undistorting the image before feeding into caffe_ros. In another scenario where we use ZED camera, the ZED ROS node conveniently provides a topic with rectified image (example).
Hope this clarifies things a little...


delete commandline

Describe what this PR does / why we need it
These documents are outdated, and we have instructions for using them. We don't need these redundant documents.
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

we have instructions for using them

@Stevent-fei I still have not gotten your initial thought on why to remove all these docs. Please explain more?

we have instructions for using them

@Stevent-fei I still have not gotten your initial thought on why to remove all these docs. Please explain more?

I think users prefer the official documentation to understand sealer. Few users will pay attention to this usage documentation, and many functions in the documentation are no longer applicable to the current version, and even affect the user experience

I think users prefer the official documentation to understand sealer.

@Stevent-fei I do agree. While where does official website to get the generated docs?

I think users prefer the official documentation to understand sealer.

@Stevent-fei I do agree. While where does official website to get the generated docs?

@allencloud https://github.com/sealerio/sealer.cool/tree/main/src/docs


Eliminate ':' in summary name of contrib.learn.estimators.

When I run the contrib.learn.DNNRegressor or contrib.learn.DNNClassifier model, I've got the log messages like below.
INFO:tensorflow:Summary name dnn/hiddenlayer_0:fraction_of_zero_values is illegal; using dnn/hiddenlayer_0_fraction_of_zero_values instead.
INFO:tensorflow:Summary name dnn/hiddenlayer_0:activation is illegal; using dnn/hiddenlayer_0_activation instead.
INFO:tensorflow:Summary name dnn/hiddenlayer_1:fraction_of_zero_values is illegal; using dnn/hiddenlayer_1_fraction_of_zero_values instead.
INFO:tensorflow:Summary name dnn/hiddenlayer_1:activation is illegal; using dnn/hiddenlayer_1_activation instead.

Tensorboard show me that the characters ':' in these summary name were replaced by '_'.
I think this change doesn't cause any big incompatibility issues.

Can one of the admins verify this patch?

I think this looks fine to me. Adding Martin for a second look and mostly to make sure that this doesn't cause issues with existing running jobs etc.

I think this is safe to do -- Tensorboard labels may change, but I don't think those are programmatically accessed anywhere.

Jenkins, test this please

Jenkins, test this please.


Elytrians should be rebalanced

To better fit the lore of the Elytrian, they should not be able to wear metal armor like gold, iron, chainmail, and Netherite as that would be too heavy. Instead, they should be able to wear diamond and leather armor, or one piece of heavy armor but nothing else (weight instead of protection). In addition, birds have dense bones instead of brittle bones, so the Elytrians should take 1/2 damage from crashes. To combat these strengths, Elytrians should have the Lean Muscles effect, which makes them take half a heart of damage while attacking in the air (recoil from the hit) and giving them weakness when on the ground.
This would rebalance the Elytrian, making it a much more versatile Origin.

Here's my personal opinion:

Though seemed reasonable, not a very good idea, it will cause more manual work for players to add tags in datapacks to compat with mod armors. In that case, if the player already have the knowledge to make datapacks, they can make a datapack following the doc and override the power themselves. So it's not a work that should be done on the official side.
It does makes sense actually, it is truly weird for elytrian to take more damage from crashes.
The idea of recoil is good, but the weakness part seems duplicated with the current restriction.

Actually, Origins is highly customizable, all of your suggestion can be realized in a simple addon datapack, which is the best part of the mod. You may just read the docs or join the discord server for help on addon making. It's actually not mandatory to ask the author for changes which overrides other's opinions and breaks consistency between versions :)

I think that they should make it so any armor value over "x" causes them to be too heavy to take off. So they can still wear the armor, just lose the ability to fly.

I'll make a datapack to test it out.


Strange view at dd()

Laravel Version: 5.5.17
PHP Version: 7.1.1

Description:
When I use dd(), I get a strange view on website.

Steps To Reproduce:
Just use dd(Auth::user()) for example

This repo is for bug tracking. Use the forums or slack channel for solving your issue

I think it's a bug. Just few versions ago again I hadn't this view.

That's the stylesheet used by dd(). I would guess that you're not rendering the html correctly, or perhaps doing ajax calls and just taking the text content of them into your dom.

looks like it's something in your app, please seek help on the forums.


Feature Request: C220 camera also works

As per title got C220 camera today and it works perfectly. Thank you

Added, thank you!


STSWebIdentity Resolver Bug

Describe the bug
Upstream ticket: https://github.com/awslabs/aws-sdk-swift/issues/1694
Expected Behavior
Refer to upstream ticket
Current Behavior
Refer to upstream ticket
Reproduction Steps
Refer to upstream ticket
Possible Solution
No response
Additional Information/Context
No response
aws-crt-swift version used
0.33.0
Compiler and Version used
Xcode 15.4
Operating System and version
Sonoma 14.6.1

The bug turned out to be due to the provided role session name not following the regex outlined in the docs here. The role session name that was used with this sample project had a white space in it.
After discussion with @waahm7, as CRT does no validation of input parameters and C does not have regex parser, we decided it would be best if we add this input parameter check to SDK wrapper.
Closing this ticket (and the one in downstream CRT repo) as it is not an issue with the SDK / CRT.
I'll be creating a follow-up ticket to this for adding role session name param check in our resolve wrappers.


Delete only the trainedmodel in the namespace where the isvc

Signed-off-by: hehe04<EMAIL_ADDRESS>What this PR does / why we need it:
Delete only the trainedmodel in the namespace where the isvc
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2163
Type of changes
Please delete options that are not relevant.
[*] Bug fix (non-breaking change which fixes an issue)

/ok-to-test

@hehe04 is this intentionally for release 0.8 branch ?

@hehe04 is this intentionally for release 0.8 branch ?

I think all versions have this problem, but I only fixed it in the 0.8 branch

@hehe04 is this intentionally for release 0.8 branch ?

@yuzisun I think all release have this problem, but I only fixed it in the 0.8 branch

@hehe04 Thanks for the fix! But please help check release patch process, we require adding to the fix to master branch before cherry picking to the release branches.

@yuzisun Thanks for your reply.  I have committed a new PR for the fix  #2166


[Nemo-772] Reuse Invariant data

Add InvariantDataProperty to mark invariant data edges.
Make block write occur only once throughout invariant edges group.
Add a few test code in DataTransferTest.

Resolves #772

Thanks! I'll take a look.

@johnyangk Updated PR. Please check!

@johnyangk Updated! Please check out.

@skystar-p Please also update the issue message to use new names. 😄

@johnyangk Addressed PR. Please check out. Thank you!


APEXMALHAR-2034 Adding new Avro Module to encapsulate Container File to Avro GenericRecord to POJO transformations

Adding link to closed PR: https://github.com/apache/apex-malhar/pull/665
New PR is created to ensure forked branch starts with JIRA name

Why is a new Maven project added when goal is to just add the Avro operator/module that combines existing operators? Wouldn't it be more appropriate to add that class to the existing package?
@sandeshh Adding the new project will require more work, including history preserving renames, proper dependency management, documentation, meaningful test coverage for the CI and other things that justify such invasive change.
Most importantly, I think that it would warrant an upfront discussion. What we don't need is a lot of code moved around when the net benefit is small.
Also, will this module work with partitioning? Let's say Kafka -> Avro -> POJO all in a parallel partition?

@tweise Creating a new maven module for Avro is in accordance with the JIRA https://issues.apache.org/jira/browse/APEXMALHAR-1843. Since a new 'apex module' is being created for Avro, we decided to add it strategically in accordance to the above JIRA.
We have ensured that the files that are moved to the new location retain the GIT history.
Unit test for the new 'apex module has been added'
Current users referring to the old location of Avro operators will continue to be able to use them as the operators in old location are not deleted but marked deprecated, and they extend the operators in the new location. This has been tested by the running a sample app using old location operators.

Following combination, Kafka -> Avro -> POJO, is not supported. Avro operator is an input operator which extends AbstractFileInputOperator, so parallel partitioning behavior is same as AbstractFileInputOperator's behavior.

I've updated the JIRA https://issues.apache.org/jira/browse/APEXMALHAR-2034 with all the tests and checks done to ensure proper dependencies, expected behavior of Avro module, and backward compatibility.

@SaumyaMohan addition of the composite Avro operator does not require the creation of a new Maven project and code refactor. You can separate the two if you like, but the project changes need to be discussed on the mailing list first, @sandeshh should be aware of that.

Will merge it tomorrow.

-1 on the PR as it is. I see no justification to create a new Maven project for this change. You can add the composite operator to the existing package.

@tweise thanks for your feedback. I just want to understand why a strategic move to a new package as per existing JIRA https://issues.apache.org/jira/browse/APEXMALHAR-1843 is being discouraged. I understand the functional change is small but through this PR we have tried to not only improve the functionality but also take this opportunity to improve the project structure which was already encouraged in the APEXMALHAR-1843 (unless that JIRA should not be referred to by developers).
We have taken proper steps to ensure file history and backward compatibility is maintained.
We have also started an email chain sending our justification for this move.
Please could you respond with your concerns on that email so all Apache Apex developers are on the same page on what approach to take for development tasks?

Yes, we can continue discussing this on the email thread. It is the recommended process for changes of this extend, to avoid contributors wasting efforts.

@tweise if I've already taken the initiative to make the strategic structural change (as per existing JIRA as mentioned above), please could you elaborate what's the technical reason why this should not be done?
I just want to understand if the move to new package is something not considered strategic or it should not be done right now.

@SaumyaMohan you should really use the mailing list to discuss this ahead of taking up the work, that's part of the collaboration process.
It is correct that the project structure needs to become more modular and in principle this is the right move. But it is not just about moving around existing code. Contrib generally implies lack of maturity/stability and when I tried to use the Avro operator in the past, it was frankly not ready for prime time. Promotion to a separate module needs to come with a base line in readiness, otherwise the entire move is just cosmetical. So before taking up this kind of initiative, you should make the case why it makes sense at this time and propose what needs to be done to provide adequate value to a user. I also agree that the JIRA isn't very helpful, it was created a long time ago and could benefit from some more context based on where the project is today.
As already stated, you could break up your PR into addressing the problem that you originally set out to solve (add new operator) as one change and new project creation separately.

@tweise most of the issues you pointed out are in the existing code which I am not changing. It seems it is easier to make the code change in the old contrib location so I will go ahead and do that and not move it to new location for this PR.
Regarding your question on how parallel partitioning will work for Avro, @sandeshh already replied "Avro operator is an input operator which extends AbstractFileInputOperator, so parallel partitioning behavior is same as AbstractFileInputOperator's behavior."

Creating a new Pull Request with only the code changes and no file move


Bug (?): auto-trim of trailing whitespace on the cursor line

With the "Trim Trailing Whitespace" (files.trimTrailingWhitespace) option enabled, trailing whitespace is removed even on the cursor line (see below). I consider this to be a bug because in #24601 @alexdima indicated that the intended behavior is for trailing spaces to not be deleted in the cursor line. And also, current behavior is quite annoying and to my knowledge, other editors keep the line under cursor intact in similar situations.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.79.1 (4cb974a7aed77a74c7813bdccd99ee0d04901215)
OS Version: macOS Ventura 13.4 (22F66)

Steps to Reproduce:

Create/open any file
Enter several trailing spaces in any line and leave the cursor where it is
Hit Save: the trailing spaces will be removed

Expected behavior: the trailing spaces under the cursor remain.

This issue still occurs in the newer VSCode versions:
Version: 1.81.0
Commit: 6445d93c81ebe42c4cbd7a60712e0b17d9463e97
Date: 2023-08-02T12:38:28.722Z (1 wk ago)
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.6.0 (macOS Ventura v13.5 (22G74))

Totally agree, this has to be considered a bug -- it needs fixing.
N.B. Atom had a similar trailing-whitespace-trimming option, but it did not trim such on the cursor line.

The current line is skipped only in case of auto-save. When explicitly saving via cmd+s, then the entire file is considered and also whitespace where the cursor sits is considered. This is implemented here and hasn't changed since the feature was first implemented.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

@skycommand I suggest it to be a separate tickbox. In my book that wouldn't be a bug, that would be expected behavior.

@bazzilic I think you're taking many things for granted. If you have a habit of leaving trailing spaces that you don't want deleted, the best strategy is to trim on checkout or push, not on save.

I think you're taking many things for granted

@skycommand I don't quite see how you came to that conclusion based on what I wrote.
Here's an example of where this is very annoying:

At this point, I received enough feedback to realize that there are people who enjoy the status quo. There are two schools of thought on this, clearly. Ex-Sublimers, for example, seem to be used to this behavior. Ex-Atomers often find this behavior annoying. Thus, I'm suggesting this to be a setting rather than a blanket change in behavior.

Ex-Sublimers and Ex-Atmoers? They sound like names of villains from a TV series. 😉 Oh, well, I said what I had to say. We just have to wait and see.

Bad idea.
Imagine I'm reading a file. My cursor is at the end of some random line. I save the file and the white space on that line doesn't get trimmed. Now that's a bug.

Your comment makes no sense. Where did that extra white space come from if you really were only reading the file?

You have a habit of saving at the worst moment.

What an absurd take. An editor needs to be able to handle saving of the file at any time, in any state. And without annoying side effects. This is a bare minimum requirement of a decent editor.

Where did that extra white space come from if you really were only reading the file?

Happens a lot during code review. Reviewers mostly make spot-fixes and save the file.

An editor needs to be able to handle saving of the file at any time, in any state. And without annoying side effects.

And a human must know that what they save gets linted, backed up, snapshot, scheduled for review, or if it is a script, run. Not everyone on this planet is an indecisive code writer.
Those who need to save the file in unstable state can postpone linting (including white space triming) from save time to commit time.

You keep mentioning fixing somebody else's code during the review. That's not how code review is typically done.
Also, how is this "spot-fixing", as you call it, different from just regular coding?

You keep mentioning fixing somebody else's code during the review. That's not how code review is typically done.

And you keep saying "usually," as if you represent the majority of humanity, and this majority has the right to trample the minority. My recommended solution caters to all, not just the majority.
If you want to see code review that includes code style review as well, contribute to PowerToys project and deliberately deviate from their style. Or to Microsoft Learn documentations of PowerShell. Or to .NET documentations.

Also, how is this "spot-fixing", as you call it, different from just regular coding?

It doesn't. If it were, I wouldn't have objected to your suggestion in the first place.

Regarding the "code reviewer does not typically edit the code during the review", yeah, I'm pretty sure I do represent the majority :)
The solution I propose (to have an option to not trim under the cursor) also caters to everyone and has an additional benefit that nobody has to change their habits, whereas your solution is to keep the status quo and I should just do things differently.

If you want to see code review that includes code style review

Not sure where this came from.

It doesn't

Huh. Then what is your point at all? How is code review relevant then? You wrote this in the beginning:

My cursor is at the end of some random line. I save the file and the white space on that line doesn't get trimmed. Now that's a bug.

This is a bug for you. For me and people with similar views, the current behavior is a bug.

Lots of "Huh" and "Not sure ..." in your message. Essentially, your entire argument consists of:

Not understanding me, not wanting to understand, or pretending not to. Just FYI, white space trimming is linting, which falls into the "code style review" domain.
Appeal the "majority" in the capacity of a weasel word.

You have a problem, you want it solved at the cost of giving others problems, and you deflect any attempt at compromise. Chances are that when this feature gets implemented you're the first one who disables it because you'll see and feel its consequences.
What if we make this an extension instead of main app's feature? The "majority" who want it can have it. The "other majority" who don't want it don't have it.

Lots of "Huh" and "Not sure ..." in your message

Count again. And what's wrong with that?

white space trimming is linting, which falls into the "code style review" domain

Debatable in the context of this discussion. Code style review as a procedure may request linting, code style guidelines may mandate linting, but linting isn't code style review.

Appeal the "majority"

What is and isn't code review is irrelevant to the discussion at hand, but if you wish:

https://engineering.fb.com/2022/11/16/culture/meta-code-review-time-improving/ - code reviews at Meta: "reviewer requests changes, author submits a new version"
https://www.michaelagreiler.com/code-reviews-at-microsoft-how-to-code-review-at-a-large-software-company/ - code reviews at Microsoft: "Each reviewer can annotate the code and add comments. Once finished commenting, the reviewer sends the annotated code back to Rose. Rose can now work on the comments and prepare a new improved version of the code"
Code review tools generally do not provide extensive tooling for editing the code under review
The term is code REVIEW, not "fixing the code"

solved at the cost of giving others problems, and you deflect any attempt at compromise

How is that? I suggest an option, which will be off by default. At whose cost is this? I did compromise: when I realized there are people who enjoy the status quo, I switched from "fix this" to "make it an option"

you're the first one who disables it

This is how Atom used to do trimming, and it was a much nicer experience (for me).

What if we make this an extension instead of main app's feature?

Would you write an extension? I don't really care how exactly this is solved if it's solved.
And why do you oppose adding this option so much? There are hundreds if not thousands of options in vscode, why does this particular one bother you so much? You literally wouldn't know it's there, unless you go dig in this particular section in the settings.

The "majority" who want it can have it. The "other majority" who don't want it don't have it.

I didn't say the majority of vscode users want this, I don't have any substantial data. The only things I know are: there are 24 upvotes and 1 downvote (from you) on this issue here. In the vscode subreddit, the post about this was hovering at about 0-2 upvotes with a total number of votes around 50-100, so ~ an even number of up- and downvotes.


Add the option to send backup to NUL for Linux hosted SQL servers

On 2019-06-13 you released an update that gave [dbo].[DatabaseBackup] the ability to backup to NUL ( https://github.com/olahallengren/sql-server-maintenance-solution/issues/80 ).
Can you please extend this ability to SQL servers that are running Linux in addition to Windows.
I attempted to use the same command that was posted in the previous feature request and it generated an error saying that the parameter is invalid.  I looked at the TSQL and it is tying the "NUL" directory option to Windows.

Do you know if NUL means the same thing on Linux as on Windows?
Have you tested that it works to back up to NUL on Linux, using a BACKUP DATABASE command?

I have added support for backup to NUL on Linux.
https://ola.hallengren.com/versions.html

Unix / Linux uses /dev/null instead of the NUL or NUL: that Windows uses. However, that does not seem to work for the BACKUP DATABASE command when using SQL Server on Linux:
BACKUP DATABASE [model] TO DISK = '/dev/null' WITH INIT;

/*
Msg 3634, Level 16, State 2, Line XXXXX
The operating system returned the error '31(A device attached to the system is not functioning.)' while
      attempting 'DiskChangeFileSize' on '/dev/null'.
Msg 3013, Level 16, State 1, Line XXXXX
BACKUP DATABASE is terminating abnormally.
*/

However , it does appear that both NUL and NUL: do, in fact, work when using SQL Server on Linux:
BACKUP DATABASE [model] TO DISK = 'NUL' WITH INIT;

BACKUP DATABASE [model] TO DISK = 'NUL:' WITH INIT;

Both worked for me when using the following:

2017 CU22
2019 CU8

@srutzky, that is good to know. Thank you for the testing.

@olahallengren, Thank you for adding this support for Linux.
@srutzky, Thank you for the testing

@olahallengren and @BHubartt38 : you're welcome!
Also, just to have this documented:
I have just confirmed that both NUL and NUL: also work on:

Azure SQL Edge (RTM) - 15.0.2000.1552.

And, just in case it matters, the Linux testing was done on:

Ubuntu 18.04.5 LTS via containers and Docker


Fix: Opening Autodropdown causes scroll to bottom

This update addresses an issue where opening an autodropdown would cause the page to scroll to the bottom.
This issue impacted the autodropdown when the number of items exceeded the threshold that has us render a filterable dropdown menu. That is 15 items by default. It also was only a noticeable issue on pages with a scrollbar. However, when those conditions were met, the dropdown was unusable.
Here is a demo of the problem:

Here is a demo of how things are looking after the fix:

@knicklabs lolol.. mind updating this test?
https://travis-ci.org/helpscout/hsds-react/builds/498916679#L532
:cry-through-pain:

Pull Request Test Coverage Report for Build 1723

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1719:
0.0%

Covered Lines:
6512

Relevant Lines:
6512

💛  - Coveralls


Update bmclib and add support for virtual media

Description
This PR adds an additional task type that updates the virtual media attached to a server.
Why is this needed
Adds flexibility for how boot media is specified.
How Has This Been Tested?
Booted a Dell R640 using a virtual cdrom.
How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

Not sure why this didn't merge. Evidently our bot settings aren't configured properly.


Sniffer name length validation

Hey @ypotter I would like to work on this issue. Can you Please assign me this issue?

I have assigned you to this issue. @Sanket-Arekar
After it is done we can continue further :)


While using the SkyWalking monitoring service, an error was reported while calling a third party interface

Please answer these questions before submitting your issue.

Why do you submit this issue?
[√ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

While using the SkyWalking monitoring service, an error was reported while calling a third party interface
15:32:24.423 [http-nio-11010-exec-6] ERROR c.e.c.s.h.GlobalExceptionHandler - [handleException,56] - HTTP 502 Error:  com.dtflys.forest.exceptions.ForestNetworkException: HTTP 502 Error:  	at com.dtflys.forest.reflection.MethodLifeCycleHandler.handleError(MethodLifeCycleHandler.java:128) 	at com.dtflys.forest.reflection.MethodLifeCycleHandler.handleSyncWithException(MethodLifeCycleHandler.java:60) 	at com.dtflys.forest.reflection.MethodLifeCycleHandler.handleSync(MethodLifeCycleHandler.java:46) 	at com.dtflys.forest.backend.AbstractBackendResponseHandler.handleSync(AbstractBackendResponseHandler.java:36) 	at com.dtflys.forest.backend.okhttp3.response.OkHttp3ResponseHandler.handleSync(OkHttp3ResponseHandler.java:29) 	at com.dtflys.forest.backend.okhttp3.executor.AbstractOkHttp3Executor.retryOrDoError(AbstractOkHttp3Executor.java:280) 	at com.dtflys.forest.backend.okhttp3.executor.AbstractOkHttp3Executor.execute(AbstractOkHttp3Executor.java:257) 	at com.dtflys.forest.backend.okhttp3.executor.AbstractOkHttp3Executor.execute(AbstractOkHttp3Executor.java:288) 	at com.dtflys.forest.http.ForestRequest.execute(ForestRequest.java:1687) 	at com.dtflys.forest.http.ForestRequest.execute(ForestRequest.java:1704) 	at com.dtflys.forest.reflection.ForestMethod.invoke(ForestMethod.java:1175) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:86) 	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java) 	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) 	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:374) 	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) 	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:888) 	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1597) 	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) 	at java.lang.Thread.run(Thread.java:748)
Trying restemplate, OkHTTP, httpClint is the same case
Attempted to disable SkyWalking monitoring, and the interface resumed fetching
The interface returns to normal when these monitoring plug-ins are removed
An attempt was made to filter the endpoint using Trace, and the interface was normal without error
But treating symptoms does not cure the root cause
What is the reason for this?
When I used the same method to call the local interface, everything worked...

This is your codes, we can't tell what are you going on. The only thing could say, the plugin isn't compatible with yours.

Why header affects your codes? If you don't allow that, SkyWalking tracing is not working.

Because the interface does header verification.
thank you for your help

为什么标题会影响您的代码？如果您不允许这样做，SkyWalking 跟踪将不起作用。

Because the interface does header verification.
thank you for your help

OK, then it is your responsibility to change. We have 3 header keys.

When I use the Trace plugin, does it filter only the starting endpoint?
I now have A situation where my microservices are interdialing, and the trace plug-in filters the endpoints that service A needs to filter, but when the link that service B came in is traced to service A, the trace plug-in is invalid

I don't know what is special from your describing. A->B->A is very common. We don't limit it.

我不知道你的描述有什么特别之处。A->B->A 很常见。我们不限制它。

Does SkyWalking's Trace plugin filter only starting endpoints? The incoming link of service A is traced to B, but B cannot filter the endpoint

我不知道你的描述有什么特别之处。A->B->A 很常见。我们不限制它。

Does SkyWalking's Trace plugin filter only starting endpoints? The incoming link of service A is traced to B, but B cannot filter the endpoint

We don't limit this.


Bug: Crawler reached the maxRequestsPerCrawl limit of 1 requests and will shut down soon

Which package is this bug report for? If unsure which one to select, leave blank
@crawlee/cheerio (CheerioCrawler)
Issue description
Cheerio crawler is not crawling when set maxRequestPerCrawl to 1.
Even when I set maxRequestPerCrawl to 10 or 100, after the 10th or 100th request nothing will be crawled again anymore.
I use a new instance of Cheerio for any single request, no parallel requests necessary in my usecases.
However, it counts requests on a global basis, no matter if I use a new instance of Cheerio for every request or if I use a shared instance.
Once the count of all requests is reaching the value of maxRequestPerCrawl, it will deny all further requests. The only solution is to shutdown the full process and start it again.
Code sample
const crawler = new CheerioCrawler({
      minConcurrency: 1,
      maxConcurrency: 1,

      //      proxyConfiguration: {},

      // On error, retry each page at most once.
      maxRequestRetries: 1,

      // Increase the timeout for processing of each page.
      requestHandlerTimeoutSecs: 30,

      // Limit to 10 requests per one crawl
      maxRequestsPerCrawl: 1,

     async requestHandler({ request, $, proxyInfo }) {
            // ...
     }
  )}

    await crawler.run([url]);
    await crawler.teardown();

Package version
3.4.0
Node.js version
18.17.1
Operating system
MacOS
Apify platform

[ ] Tick me if you encountered this issue on the Apify platform

I have tested this on the next release
No response
Other context
Log:
INFO  CheerioCrawler: Starting the crawl
INFO  CheerioCrawler: Crawler reached the maxRequestsPerCrawl limit of 1 requests and will shut down soon. Requests that are in progress will be allowed to finish.
INFO  CheerioCrawler: Earlier, the crawler reached the maxRequestsPerCrawl limit of 1 requests and all requests that were in progress at that time have now finished. In total, the crawler processed 1 requests and will shut down.
INFO  CheerioCrawler: Crawl finished. Final request statistics: {"requestsFinished":0,"requestsFailed":0,"retryHistogram":[],"requestAvgFailedDurationMillis":null,"requestAvgFinishedDurationMillis":null,"requestsFinishedPerMinute":0,"requestsFailedPerMinute":0,"requestTotalDurationMillis":0,"requestsTotal":0,"crawlerRuntimeMillis":190}

Can you try following the steps defined here: https://github.com/apify/crawlee/issues/2031#issuecomment-1715334892, specifically providing a new instance of Configuration per crawler you make, with persistStorage set to false?

Hi @vladfrangu

Can you try following the steps defined here: #2031 (comment), specifically providing a new instance of Configuration per crawler you make, with persistStorage set to false?

I'm happy to try it out. However, there is now Configuration available when importing CheerioCrawler with these imports:
import * as cheerio from 'cheerio';
import { Cheerio } from 'cheerio/lib/cheerio';

How can I import the Configuration-Object?

You have to import things from crawlee, not from Cheerio!

@vladfrangu
Using new Configuration({ persistStorage: false }); will not change the behaviour. It stays the same.


Add custom auditing for expected workspace sharing and auth domain group membership

We have certain expectations about who workspaces should be shared with and who should be members of the auth domain at different parts of the upload cycle. Add custom audits to verify that this is the case, at least for upload workspaces and combined workspaces.

See steps for ending an upload cycle: https://docs.google.com/document/d/1nwz7dwxscirJiUq4UGjFQ8cIv9Q9CtmJry9L8f-p97Q/edit?pli=1


Update index.js

Add option to pass password in arguments list.

Please use the Emitter(client[, opts]) to provide your own Redis client (since we won't update the emitter for each new parameter).

Thankyou. It worked.


Moves to newer versions of logging libraries

Logback 1.3.0-alpha5 is being flagged for CVE-2023-6378, this should resolve the issue.

Merged in version 1.30.7


Support separate dev and production config

As original Vue.js build file is separate between development and production. Can we do in in nuxt.js template?
Solution

Create 2 config file dev and production
import 2 file in nuxt.config.js
use merge to combine config follow env

If you accept this Idea I will try to open Pull request

Hi @thangman22
Actually Nuxt.js handle the dev vs prod webpack configuration automatically for you (nuxt dev and nuxt build).
Into your nuxt.config.js, I recommend you to use environment variables in production to update some values directly inside the file, this is actually a best-practice :)


Zk Client fails to connect to Embedded Zk Server in second connection

My use case is something like this:
EmbeddedKafka.start()
createTopic
pushMessages
check messages
EmbeddedKafka.stop()
In the first test it all works well, but in the second test that does something similar to the first one it fails because the Zk client cannot connect to Zk server. You can see the error below. My guess is that the stop method doesn't clean up. Can you please give me some directions with this ?
11/04/2016 11:13:56.277 -  - WARN  o.a.z.ClientCnxn - Session 0x15404611b1e0001 for server null, unexpected error, closing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[na:1.8.0_60]
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) ~[na:1.8.0_60]
at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) ~[zookeeper-3.4.6.jar:3.4.6-1569965]
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) ~[zookeeper-3.4.6.jar:3.4.6-1569965]

Do you start() and stop()` in every test? Have you got a gist you could share? I start and stop the Embedded ZK multiple times in the tests and I don't seem to have that problem. Possibly you're not restarting the connection to ZK in every test? Just throwing out ideas, a gist could help me in helping you.

Thanks. The Zk client was not reinitialised for each restart.


Action fails when removing a non-existing label

What happened
When using this action to remove a label that doesn't exist from the pr/issue,
The workflow step fails with the following error:
Error: HttpError: Label does not exist
Error: Label does not exist

It gets even more frustrating when trying to remove multiple labels,
and only the first one doesn't exist, while the next ones do.
The workflow step will fail for the first label, before trying to remove the next ones.
What you expected to happen
If anything, I expected this to not fail the workflow.
Much like the action for adding labels, if the label already exists,
nothing happens and the step is marked successful.
I think this should be the case for removing labels as well,
If there's nothing to remove, nothing should happen.
How to reproduce it
For all reproducing examples:

The label status: needs triage is not added to the pr in question,
The label status: needs review is added to the pr in question:

# fails the workflow
- uses<EMAIL_ADDRESS>  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    labels: "status: needs triage"

# fails the workflow without removing `status: needs review`
- uses<EMAIL_ADDRESS>  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    labels: |
      status: needs triage
      status: needs review

Workaround
The following is suggested by GitHub docs for verifying the existence of the label:
# this workaround doesn't work with labels containing special characters
- uses<EMAIL_ADDRESS>  if: contains(github.event.issue.labels.*.name, 'bug')
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    labels: "bug"

I've abandoned this workaround because I use a colon (:) in my label names, e.g. status: ....
And I haven't found a way to incorporate special characters in the expression.
The workaround I ended up with is:
# this is a very bad practice, as I might be suppressing errors I don't want to suppress

- uses<EMAIL_ADDRESS>  continue-on-error: true
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    labels: "status: needs triage"

- uses<EMAIL_ADDRESS>  continue-on-error: true
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    labels: "status: needs review"

Another downside for both of these workarounds,
I can't use one step to remove multiple labels using line breaks,
As the step will fail for the first label and not process the following ones.
# the workflow will not fail and the `status: needs review` label will not be removed
- uses<EMAIL_ADDRESS>  continue-on-error: true
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    labels: |
      status: needs triage
      status: needs review

Environment
runs-on: ubuntu-latest
action-version: 1.0.2

@TomerFi what about labels named automerge && enhancement to be checked both at same time and then if both are there remove them both at once?

@TomerFi what about labels named automerge && enhancement to be checked both at same time and then if both are there remove them both at once?

Sorry for the late response :bow: I've confirmed the errors when I try to remove non-existing labels while haven't seen them when removing existing ones. And as @AraHaan said, this isn't a bug.
Since it seems many people want to ignore errors for non-existing labels, I've added fail_on_error input (https://github.com/actions-ecosystem/action-remove-labels/pull/171), which allows you to ignore errors. The default is false, meaning you'd not see such failures by default while it behaves as previously when setting true. You can try it with actions-ecosystem/action-remove-labels@v1.

@micnncim btw possible you can merge some of the dependency updates that does not break the action?

I have cleaned them up.

Closing this issue. If you find any issues, feel free to reopen it.


on 'layoutend' event fires before nodes were set.

Hello,
I've noticed that after on 'layoutend' event was fired I still don't have access to nodes specs via getSpec() function - it's undefined, but with setTimeout wrapper it works:
  var layoutController = new LayoutController({
    layout: ListLayout,
    layoutOptions: {
       itemSize: 50
    },
    dataSource: surfArray
  });

  layoutController.on('layoutend', function(){
   // setTimeout(function(){  // <----------------setTimeout solves this issue
    	console.log('layoutend ' + layoutController.getSpec(surfArray[0], false).size);
   // }, 500);
  });

Here is codePen proof (see log):
http://codepen.io/Qvatra/pen/EarRxJ
P.S: I've tested on Chrome only.
is it a bug? what is a workaround?

Hi, thanks for reporting this. I've just checked in the fix for this, let me know whether that solves your problem.
Cheers

thx. bug is gone


Permissions for workspaces are not consistent when not a TRE Admin

Currently, a workspace owner can create and modify resources within their workspace, but cannot modify / perform custom actions on the workspace itself. This doesn't feel like it would meet customer expectations, as the 'owner' of an item is usually expected to be able to update that item. One common thing the workspace owner might want to do is update the Overview (markdown) field in their workspace to populate project details. In future, actions such as 'Archive' might be available within custom actions, which the Owner would also want to access.
PROPOSAL:

Update the permissions on the PATCH /workspace/<id> and the POST /workspaces/<id>/invoke-action endpoints to allow workspace owner to execute them
Update the permissions on the GET /workspace-templates endpoint to allow TRE Users to view the workspace templates. We need this as we need to get the template before performing the PATCH above.
Show appropriate buttons in the UI when a user is a Workspace Owner and not a TRE Admin.

RISKS / CONSIDERATIONS:

All users of the TRE would be able to query the workspace templates. All users are currently able to query workspace service templates so I don't think we're adding risk - but a customer would need to ensure they didn't have a workspace template named in a way that could leak sensitive information to other TRE users (such as "Partner X Workspace Template").
The workspace owner could disable (or in future, archive) their workspace. This is a feature and a consideration.

As discussed, will park this currently until we have broader discussions about permissions.

After the permissions discussion, was agreed this is by-design, and for the mean time we want to keep it that way. Closing.


cannot install openssl

Package: openssl-windows:x64-windows
Vcpkg version: 2018.11.23-nohash

D:\dev\vcpkg>vcpkg install openssl:x64-windows
The following packages will be built and installed:
openssl[core]:x64-windows

openssl-windows[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/2: openssl-windows:x64-windows
Building package openssl-windows[core]:x64-windows...
-- Using cached D:/dev/vcpkg/downloads/openssl-1.0.2q.tar.gz
-- Applying patch D:/dev/vcpkg/ports/openssl-windows/ConfigureIncludeQuotesFix.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch D:/dev/vcpkg/ports/openssl-windows/STRINGIFYPatch.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch D:/dev/vcpkg/ports/openssl-windows/EnableWinARM32.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch D:/dev/vcpkg/ports/openssl-windows/EmbedSymbolsInStaticLibsZ7.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Configure x64-windows-rel
-- Configure x64-windows-rel done
-- Build x64-windows-rel
-- Build x64-windows-rel done
-- Configure x64-windows-dbg
-- Configure x64-windows-dbg done
-- Build x64-windows-dbg
-- Build x64-windows-dbg done
-- Installing: D:/dev/vcpkg/packages/openssl-windows_x64-windows/share/openssl-windows/copyright
-- Performing CMake integration test
CMake Error at scripts/cmake/vcpkg_test_cmake.cmake:71 (message):
CMake integration test failed; unable to find_package(OpenSSL MODULE
REQUIRED)
Call Stack (most recent call first):
ports/openssl-windows/portfile.cmake:171 (vcpkg_test_cmake)
scripts/ports.cmake:71 (include)

See https://github.com/Microsoft/vcpkg/pull/5747

Duplicate of https://github.com/Microsoft/vcpkg/issues/5713

Should be fixed

vcpkg_test_cmake() has been disabled by c2ad1ba. With that change openssl-windows will build so I am closing this issue for now. Please re-open if this is still a issue for you. Thank you!


refactor endpoint life cycle

RTC-13118

Disregard. I got what you wanted to do (read a comment in job.h)

I think you are right. It is a weird construct and when I look at how it is used it is in test to pass a param into a method that does nothing.


Appveyor - enable build cache for packages dep on packet.lock

https://www.appveyor.com/docs/build-cache/
This is not a bit deal but it would make our builds a bit faster.

Meh this is not perfectly done but there is some caching happening.


With user snippet loosing ${}

Version: 1.56.0 (user setup)
Commit: cfa2e218100323074ac1948c885448fdf4de2a7f
Date: 2021-05-04T22:09:06.405Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Version: 1.57.0-insider (system setup)
Commit: fe23c2041f848d6c2f6bd27875112a37bcc82f84
Date: 2021-05-06T05:16:25.564Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Steps to Reproduce:

create user snippet for JS (in javascript.json) with this content:

	"object for ... in loop": {
		"prefix": "obj",
		"body": [
			"for (let crewMember in spaceship.crew) {",
			"  console.log(`${crewMember}: ${spaceship.crew[crewMember].name}`);",
			"};"
		],
		"description": ""
	}

in javascript file write "obj" and run snippet. Result:

console.log(crewMember: ${spaceship.crew[crewMember].name});

In simple terms is lost first "${}", for compare:
console.log(`${crewMember}: ${spaceship.crew[crewMember].name}`); -- in json file
console.log(`crewMember: ${spaceship.crew[crewMember].name}`);    -- after using snippet

Does this issue occur when all extensions are disabled?: Yes/No
Yes

In simple terms is lost first "${}",

Unsure what you mean? Do you want the output to contain console.log(${crewMember}:...`?

In simple terms is lost first "${}",

Unsure what you mean? Do you want the output to contain console.log(${crewMember}:...?

Yes, expected result is exact line what defined in json:

console.log(${crewMember}: ${spaceship.crew[crewMember].name});

Yes, expected result is exact line what defined in json:

Well... ${crewMember} is the snippet syntax for referring to a variable called crewMember. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_grammar for more details.
You need to use \ to escape the $ so that this isn't interpreted as variable

For snippet, the line should be:

console.log(\\${crewMember}: ${spaceship.crew[crewMember].name});


Cannot launch on another computer.

Hello, I compile my code to send a .exe to my client and my clients cannot launch my application because Prisma create an error..
This is the error:

Alternatively, copy the node_modules/prisma/query-engine-<platfrom> file to the directory where the exe is located

If your version is before 3.0, then you need to copy .dart_tool/prisma/query-engine to your exe directory.

@AndryHTC @PandaGuerrier Maybe we should consider Docker Image, binary causes copying between different systems and architectures will definitely not work.
If I download the engines of all architectures for selection and copying by default, the files you need to send will be extremely large in the end (usually, you can’t determine the target system and architecture before development, you can only send them all)
I recently optimized the odroe/prisma-dart Docker image, its goal is to build a thin image that only contains the current dependencies through scratch, and I released a new version, the odroe/prisma-dart image The size is only 1.5MB, and supports multiple architectures (all architectures supported by Dart Image)
You can refer to this SQLite example https://github.com/odroe/prisma-dart/blob/main/example/Dockerfile

@AndryHTC I don't have any good method, maybe compiling on the server side is the most direct.

@medz running npx prisma generate directly on the EC2 instance isn't a viable solution for us because it causes the server to freeze.

@AndryHTC What about making a Docker container identical to your EC2? The same system version and the same platform architecture can solve this problem.


Bumps in garden: ign-math7, ign-common5, sdformat13

See https://github.com/ignition-tooling/release-tools/issues/574
Requires

https://github.com/ignitionrobotics/sdformat/pull/805
https://github.com/ignitionrobotics/sdformat/pull/803
https://github.com/ignitionrobotics/ign-rendering/pull/525

All :green_circle: :tada:

Also merging infrastructure PRs:

https://github.com/ignition-release/ign-sensors7-release/pull/5
https://github.com/osrf/homebrew-simulation/pull/1767
https://github.com/ignition-tooling/gazebodistro/pull/75


Security scan

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: channyein87 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix memory leaks in auto_explain

Statistic context wasn't destroyed with query descriptor, so queries with multiple call of sql functions consumed a lot of memory.
Steps to reproduce:
LOAD 'auto_explain';
SET auto_explain.log_nested_statements=true;
SET auto_explain.log_min_duration = 0;
SET auto_explain.log_analyze = true;
explain analyze select information_schema._pg_truetypid(a, t) from (
    select a as a, t as t from pg_type t
    join pg_attribute a on a.atttypid = t.oid
    where typtype = 'd' limit 1
) at join generate_series(1, 9000000) gc on true;

Changes:

Add cdbexplain_showStatCtxFree() function to release memory allocated for statistic context. The function is called from FreeQueryDesc() when the statistic context exists. To check whether the context exists the assigning NULL value to the showstatctx field of query descriptor is moved from ExplainOnePlan() to CreateQueryDesc() and CreateUtilityQueryDesc().
Statistic context in auto_explain isn't created if the context already exists. It may be created in ExplainOnePlan().
When memory is allocated in functions called from explain_ExecutorEnd(), the context of query is used. This memory is released in standard_ExecutorEnd() -> FreeExecutorState().

does this code https://github.com/arenadata/gpdb/blob/66d793cb2a88b02b56ca09af9ea9629d2bf186b2/src/backend/commands/explain.c#L565-L572 hide allocated context?

As we speak about memory consumption, is it possible to write a regression test, which shows that memory consumption is near the equal now for different amount of iterations?

is it possible to write a regression test, which shows that memory consumption is near the equal now for different amount of iterations?

I think, it is possible, like in https://github.com/arenadata/gpdb/pull/362/files#diff-543d141b085b64c62388679d9aabf678e7ac5daac976b958fd02361420f6be8dR1-R39

is it possible to write a regression test, which shows that memory consumption is near the equal now for different amount of iterations?

I think, it is possible, like in https://github.com/arenadata/gpdb/pull/362/files#diff-543d141b085b64c62388679d9aabf678e7ac5daac976b958fd02361420f6be8dR1-R39

Done

Done

Overall OK, but I appreciate any in-test comment about what's going on here, about magic constants and about why it's necessary to tweak some GUCs.


Create C++.gitattributes

"*.out" is debatable, but keep in mind that most compilers creat binaries of "a.out" by default

Thank you :)!


this.quality is always "undefined" for CCWebMEncoder

the quality parameter passed in settings is ignored and not assigned, to this.quality.
so webm is always encoded with the default quality, no matter the passed value

Good catch!

Fixed in https://github.com/spite/ccapture.js/commit/d4a661e27ee50867e24989a00259ed7e792e4f8a
I will update npm later today


Number of test assertions mentioned on the page 58

Hi Alex,
On the page 58 of the PDF, when running tests, you mentioned 19 assertions as per screenshot below.
But in my case, the number if 18.
https://github.com/tenzan/cms-rails-api/tree/3459ebbf5a8a8bf9c02e32e30e773cadd39696aa

Regards,
Askar

Thanks for report, I just commited a correction: 33d499ccdc3a09c2ef6d45c26e4b626d04e1e562


Problem encounter with array fields

Hi,
During my development, I encounter a problem with http_build_query
It encoded an array with [0], [1], ... suffix instead of []
I added :
		$postfields = http_build_query($data);

		// Solve [0] to [] issue

		$postfields = str_replace("%5B0%5D", "%5B%5D", $postfields);
		$postfields = str_replace("%5B1%5D", "%5B%5D", $postfields);
		$postfields = str_replace("%5B2%5D", "%5B%5D", $postfields);
		$postfields = str_replace("%5B3%5D", "%5B%5D", $postfields);

		$parameters[CURLOPT_POSTFIELDS] = $postfields;

But not sure that the good way of doing it (quick and dirty)

Hi.
I commit Mastodon_api.php.
Please check function _post, _get.
Thank you.

Hi there.
That commit might have broken the possibility to toot texts with tags like #25.
I opened a PR #6 that should, without breaking its functionality, fix that.


Base planning refactor

Describe what you want the bot to do
-BasePlanner class instantiated that contains methods that handle main aspects of base planning, utilizing things like room prototypes for the smaller parts
-RampartPlanner class that handles rampart planning
-Stamp rotation
-Stamp anchors recorded in memory, sperate from everything else and not to be used for structure placement purposes
-Planned structures stored in either base plans or rampart plans in memory
-Planned structures stored in memory as string[] where string is String<structureNumberReference, minRCL>
-coordMaps used while planning that persist in room global until deleted when planning is finished
-Abstractor function to read and reference these coordMaps to make things easier
-coordMaps are converted into storage arrays at the end of planning

Shall I plan this out like I did with tasks?


Remove extra multi_json requires

As a response to the comment at https://github.com/rollbar/rollbar-gem/commit/2f1a593faaf0b7354d216738f7a6c023a3e7a4ce

Oo, thanks! Will merge once the build comes back green.

@brianr have a look into my PR https://github.com/rollbar/rollbar-gem/pull/256, I manage to get it green

I'm happy to rebase this PR to rerun tests.

@albertyw version 2.0.1 has been released.
Thanks for this!


vkquake: Persist for the Arcane Dimensions mod

Many including myself consider the mod Arcane Dimensions for Quake as good, if not far greater than the base contents of the game.
This change persists the dir for the mod according to the instructions on its homepage; dir 'ad'.
What package release type is this?

[x] stable

I followed the bucket's manifest standards?

[x] I have read the Contributing Guide.
[x] properly named and capitalized shortcuts?
[x] autoupdate and checkver entry
[x] persist defined with config/data/user/portable/textures/saves folder(s) specific for the app?
[x] a pre_install script to auto-enable portable mode (if needed)?

[x] a pre_install script creates runtime created files specified in persist (ensures symlinks properly get created)

[x] license identifier and url
[x] a short terse description matching existing style.
[x] url to the release along with its sha256 hash
[x] bin entry for main binary

[x] if beta, dev, etc: does bin shim have variant appended to the name? (e.g appname-dev)

[x] passes bin/checkver.ps1 and bin/checkurls.ps1
[x] tested install, checked persist, no errors.
[x] manifest is sorted to spec
[x] manifest follows spec: appname or appname-variant (e.g citra-canary or dolphin-dev)
[x] I tested the package and it runs in portable mode. I have verified the symlinks are correct in the persist folder and working.
[x] I will maintain this manifest and promptly fix it in the event it breaks.

/verify


fixing javadoc error for missing curly braces

This pull request is to fix the build error coz of missing curly braces

Unmatched curly braces looks incorrect to me