fix(validation): Support null fields

Using a schema with a field with type: "null" that has no inputType that differs from "hidden", resulted in an error when performing the schema validation, which ultimately allowed for invalid payload to be submitted.
Example of a schema that presents the invalid behavior:
{
  "additionalProperties": false,
  "type": "object",
  "properties": {
    "name": { "type": "null", "title": "(Optional) Name" },
    "username": { "type": "string", "title": "Username", "maxLength": 2 }
  },
  "required": ["username"]
}

Testing in the playground, without this PR, allows submitting an invalid username value and the following error is logged:

Internal ticket
Additional bug fixes
Includes bug fixes for validations introduced in https://github.com/remoteoss/json-schema-form/pull/87. We got internal pipeline failures due to incorrect file field validations. It no longer forces validations on file objects to be of File instance.

@sandrina-p I've added the schema for the upcoming docs in https://github.com/remoteoss/json-schema-form/pull/91/commits/623c31b5c5d2aedfb1e6ad7f070e3453909cb878
It doesn't contain the ignoreValue config since that's an internal concept and doesn't change the behavior of JSF.


import { User, Credentials, GraphQLConfig } crashes React app

Here are repro steps:

run create-react-app
install Apollo (just following their basic getting started, down to the "Describe your data" step; https://www.apollographql.com/docs/react/basics/setup.html)
change the new ApolloClient(... to point to a ROS. eg.

const client = new ApolloClient({
  link: new HttpLink({ uri: 'http://xxx.yy.zzz.238:9080/graphql/TestRealm' }),
  cache: new InMemoryCache()
});

Also don't forget to wrap the top most div in the render() method with <ApolloProvider>
eg.
return (
      <ApolloProvider client={client}>

Welcome to React

            To get started, edit src/App.js and save to reload.

      </ApolloProvider>
    );

Assuming setup is ok, you can pop a console.log in the client.query(..)
and you'll see the data returned from ROS
UP TO HERE, ALL WORKS FINE

Now, install realm-graphql-client, apollo-client-preset apollo-link-ws subscriptions-transport-ws

add this: import { User, Credentials, GraphQLConfig } from 'realm-graphql-client';

The React app will crash in the browser
Here is the error I saw:
"ReferenceError: AuthenticationHelper is not defined↵    at eval (eval at webpackMissingModule (http://localhost:3000/static/js/bundle.js:46414:150), <anonymous>:1:1)↵    at webpackMissingModule (http://localhost:3000/static/js/bundle.js:46414:150)↵    at Object../node_modules/realm-graphql-client/dist/authenticationHelper.js (http://localhost:3000/static/js/bundle.js:46414:160)↵    at __webpack_require__ (http://localhost:3000/static/js/bundle.js:679:30)↵    at fn (http://localhost:3000/static/js/bundle.js:89:20)↵    at Object../node_modules/realm-graphql-client/dist/graphqlConfig.js (http://localhost:3000/static/js/bundle.js:46518:32)↵    at __webpack_require__ (http://localhost:3000/static/js/bundle.js:679:30)↵    at fn (http://localhost:3000/static/js/bundle.js:89:20)↵    at Object../node_modules/realm-graphql-client/dist/index.js (http://localhost:3000/static/js/bundle.js:46598:10)↵    at __webpack_require__ (http://localhost:3000/static/js/bundle.js:679:30)↵    at fn (http://localhost:3000/static/js/bundle.js:89:20)↵    at Object../src/App.js (http://localhost:3000/static/js/bundle.js:58046:80)↵    at __webpack_require__ (http://localhost:3000/static/js/bundle.js:679:30)↵    at fn (http://localhost:3000/static/js/bundle.js:89:20)↵    at Object../src/index.js (http://localhost:3000/static/js/bundle.js:58272:63)↵    at __webpack_require__ (http://localhost:3000/static/js/bundle.js:679:30)↵    at fn (http://localhost:3000/static/js/bundle.js:89:20)↵    at Object.0 (http://localhost:3000/static/js/bundle.js:58428:18)↵    at __webpack_require__ (http://localhost:3000/static/js/bundle.js:679:30)↵    at ./node_modules/ansi-regex/index.js.module.exports (http://localhost:3000/static/js/bundle.js:725:37)↵    at http://localhost:3000/static/js/bundle.js:728:10

package.json here:
package.json.zip

hi folks, just checking in on this. Is there an eta for a fix of realm-graphql-client ?

It seems like the issue is caused by webpack. It tires to require a module in the authentication helper.

Maybe it would be better if fetch can be provided as optional argument like the apollo-http-link ?

Thanks for investigating this! I think it should be easy to expose it as an optional field in the config. We'd definitely appreciate a PR that fixes it, otherwise I'll try to look into it soon :)

Sure I'll try to provide a PR.

nice one thanks guys!

Hi all, just checking in on when this might be merged?

Hi, i get the same error as @olivereisenhut  when using it in node. I have imported node-fetch, but the same error is there. Trying to use vue.js

sorry about this but i could have sworn i saw an email(?) about this ticket and that a fix was made and ready for testing. searched my email but couldn't find. is there anything out there to test for this fix ? do we need to pull a specific branch/version of ROS ?

We recently merged a PR from @olivereisenhut that worked around this issue, can you upgrade to the latest version and check if the problem is fixed for you?

hey, thanks for that. actually i just updated to the latest builds on ROS & JS client, ran a first test, and had success with both query and mutations. however i couldn't get subscriptions working (which may be my code error or a different issue). but definitely this particular issue (the crash) is resolved - many thanks!

Glad to hear that! If you can't figure out the subscriptions, feel free to open a new issue and we'll take a look.

hi Nikola, i thought id post here as others will benefit too. firstly - the fix is fine and working for me in dev mode. however i just tried to run a prod build to deploy (npm run build) and got the following crash:
Failed to minify the code from this file:

 	./node_modules/realm-graphql-client/dist/authenticationHelper.js:13

detailed error log attached.
hopefully is easy fix appreciate if you can let me know.
errorlog.zip

Hi Nikola,
Apologies but seems to be one issue remaining on this ticket - which is npm run build is crashing due to an issue with authenticationHelper.js:13.
I’ve updated the ticket here (still shows itself as closed atm) https://github.com/realm/realm-graphql/issues/10#issuecomment-390470467
Regards,
Angus Johnston
Lead Developer
SOGO Golf
Mob: +61 400 44 29 23
From: Nikola Irinchev<EMAIL_ADDRESS>Reply-To: realm/realm-graphql<EMAIL_ADDRESS>Date: Sunday, 20 May 2018 at 8:09 pm
To: realm/realm-graphql<EMAIL_ADDRESS>Cc: Angus Johnston<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [realm/realm-graphql] import { User, Credentials, GraphQLConfig } crashes React app (#10)
Glad to hear that! If you can't figure out the subscriptions, feel free to open a new issue and we'll take a look.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@kneth do you have any clue what this could mean?

Following this guide I would suggest to set ES5 in the tsconfig.json file for compiling. But I have to verify if it's working.

I tested it with the "target": "es5" option and it worked for me. I could provide a PR.

Happy to hear about your progress, and thanks for the link.

thanks for quick reply guys. @olivereisenhut  - i'm not using typescript in the React project so don't see a tsconfig.json to edit. is this something that needs to be done on Realm's side and then re-publish a new npm update to realm-graphql-client ?

@nirinchev any idea when this fix will go in ? we need to push the site to production as soon as possible. im happy to do any workaround/s while waiting if that is feasible?

As I said, I'm not super familiar with React, but I tried changing the target of the typescript compiler to es5 and this is the package that got produced. Can you try removing the npm package and installing this one? If it works, I'll publish to npm later tonight.
realm-graphql-client-1.2.0.tgz.zip
Github doesn't support .tgz, which is why I zipped it. You should be able to unarchive and then npm install the .tgz.

No worries totally understand re React.  Ive tested the tgz / update: the build to prod (for React) works great. Thanks for the quick assistance really appreciated.
Cheers,
Angus
From: Nikola Irinchev<EMAIL_ADDRESS>Reply-To: realm/realm-graphql<EMAIL_ADDRESS>Date: Friday, 25 May 2018 at 10:27 pm
To: realm/realm-graphql<EMAIL_ADDRESS>Cc: Angus Johnston<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [realm/realm-graphql] import { User, Credentials, GraphQLConfig } crashes React app (#10)
As I said, I'm not super familiar with React, but I tried changing the target of the typescript compiler to es5 and this is the package that got produced. Can you try removing the npm package and installing this one? If it works, I'll publish to npm later tonight.
realm-graphql-client-1.2.0.tgz.ziphttps://github.com/realm/realm-graphql/files/2039257/realm-graphql-client-1.2.0.tgz.zip
Github doesn't support .tgz, which is why I zipped it. You should be able to unarchive and then npm install the .tgz.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/realm/realm-graphql/issues/10#issuecomment-392041342, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC3bVco12MBaTIDLJAkBOnBfHbS_-KRHks5t1_iWgaJpZM4R4f9l.

Thanks for testing that! I pushed 1.2.0 to npm so this should hopefully resolve this issue 😅


Allow use of config file instead of command line params

I'm getting started using http-server and would like to be able to put my command line params in a config file and have that used instead.
For example: http-server --config my_config.json
where my_config.json would have something like this:
{ port: 8484, gzip: true, brotli: true, proxy: "http:localhost:8484?" }
Which would run as if I typed this at the command line:
http-server ./dist --port 8484 --gzip --brotli --proxy http://localhost:8484?

I'm generally in favor of this, though this is a duplicate of #24 (one of our oldest issues). It did have a PR (#131) attached but it couldn't keep up with changes in master. I'd welcome a new PR for sure.


COG Link Additions

Added links to the Cloud Native Geoguide to COG tutorials in the MAAP Docs
Reference ticket: https://github.com/NASA-IMPACT/active-maap-sprint/issues/880

That's noted - thanks @omshinde!


Authorise with Azure FHIR API

Authorisation and successful bundle submission for Aridhia's managed Azure FHIR API 🎉

Registered this application with a post-authorisation redirect of localhost:3000/new_report so updated routing to match that
Altered SMART workflow to use credentials (but local dev FHIR API on HAPI ignores this so the envs are only required to interact with the managed API)
FHIR API does only accepts batch bundles (we were using transaction so that if one part failed, everything failed).

References need to be changed to be query-based and we shouldn't set the resouce id field, otherwise if a resource exists (e.g. Patient) and we're updating their data then the FHIR API will complain that the id field in our bundle doesn't match what exists in the database
From this, slimmed down types ResourceAndIds -> ResourceAndIdentifier as we'll only use the identifier field, and not the id field. I think that if this was a transaction then using the id would be fine because that's how you managed the referential integrity of the entire transaction.
Bundle entries are rejected if have resourceType at the top level, so removed that

More specific requirements for narrative divs xmlns value: <div xmlns=\\"http://www.w3.org/1999/xhtml\\">

If you want to try this on the Aridhia synthetic FHIR API you'll need to setup LastPass:
You have first to ask for a LastPass account to Information Security Group (ISG). After you get it, let me know and I'll add you to the group shared folder
also added in some extra codes - closes #56

If the error screenshot I posted above is known to you already and not a blocking issue I can go ahead and approve this PR. Let me know otherwise 👍

I have commented where I could, although there's lots of data being returned from helper functions that I'm less confident in evaluating.
The code itself looks good though, and I have tested it locally which all works apart from this error (see screenshot) when I submit the form (perhaps you are aware of this already).

Oh  I missed this sorry, Interesting. That must've slipped in when I added the narrative div. Turns out that the JSON.stringify handles adding escape strings so have removed us adding them


Assignment 04

Checklist

[x] Paste a screenshot of the solution whenever possible (ctrl+v or cmd+v directly on this textbox works)
[ ] Add optional notes/remarks to be taken into account for evaluating the submission

@nrogeau: this is looking great! The one thing I'm missing thou is the last bit of the assignment: storing some of those trajectories (all 3 of them) into a json file.

Thank you for the feedback!


File hash/compare as Explorer add-on

Description of the new feature / enhancement
A quick way to be able to compare 2 files or 2 sets of files for corruption would be nice, crc/sha etc
Scenario when this would be used?
Checking for file corruption/generate hash
Supporting information
No response

/dup #57


TDBank returns "Client up to date" when calling accounts() due to invalid DTACCTUP

https://github.com/captin411/ofxclient/blob/4da2719f0ecbbf5eee62fb82c1b3b34ec955ee5e/ofxclient/client.py#L125
The default for the date parameter causes TD Bank to return "Client is up to date". If that parameter is set to '19700101' it returns the account list successfully.
How is a user supposed to set that parameter though? After instantiating Institution() here...
inst = Institution(
    id='1002',
    org='CommerceBank',
    url='https://ofx.tdbank.com/eftxweb/td.ofx',
    username=tdbank.username,
    password=tdbank.password,
    client_args={
        'ofx_version': '103',
        'app_version': '2200',
        'id': tdbank.clientid,
    }
)

...calling inst.accounts() should just work, but for TD Bank it doesn't.
https://github.com/captin411/ofxclient/blob/4da2719f0ecbbf5eee62fb82c1b3b34ec955ee5e/ofxclient/institution.py#L134
institution.accounts() doesn't take any parameters, so there's no way to override the default date parameter. Wouldn't it make sense to have that method accept **kwargs and pass them on to account_list_query()?
I will provide a PR to do just that. Afterwards, this call should work fine:
inst.accounts(date='19700101')

It looks like TD Bank is violating the OFX spec here; it should accept the full date/time string as well as the date-only string.  See the page with page number 90 at the bottom of http://www.ofx.net/downloads/OFX 2.2.pdf .  The best thing would be to send a bug report to TD Bank and have them fix it, but I imagine it is not too likely that it would be fixed in a timely manner, if ever.
It seems likely that changing the code to always send 19700101 would break a different buggy implementation that expects the hour-minutes-seconds form, so that is probably unwise.  Probably it would be best to do whatever Quicken does; however, I expect Quicken itself is full of special cases for individual banks.
Supporting parameters for this query makes some sense in general, though I'm not sure in practice there is any use in getting only accounts updated since a given date, or if servers even support that functionality.
However, it would be much better if it just worked for TD Bank by default.  One option would be to specifically check for the TD Bank server in client.py --- there is already some special case code for ofx.discovercard.com.  Another option would be to initially send the query with<PHONE_NUMBER>0000 and if it fails, to retry with 19700101.  The advantage of this approach is that it is slightly more generic in that if another bank has the same bug as TD Bank, then this would work for that implementation as well.  However, I'm not sure how likely it is that another bank's server has the same bug.

First of all, I agree completely: A bug report to TD Bank is unlikely to result in a fix, but I may give that a shot.
For the workaround, I like your idea of automatically retrying -- this will work for TD Bank and any others that may have the same fault, and the worst case is querying twice and still failing.

PR updated and tested OK with TD Bank.


[VEN-2872] Deploy VTreasuryV8 to Base Sepolia

Description

Resolves #
Checklist

[ ] I have updated the documentation to account for the changes in the code.
[ ] If I added new functionality, I added tests covering it.
[ ] If I fixed a bug, I added a test preventing this bug from silently reappearing again.
[ ] My contribution follows Venus contribution guidelines.

Package	Line Rate	Branch Rate	Health
contracts	100%	100%	✔
contracts.Admin	88%	41%	✔
contracts.Comptroller	100%	90%	✔
contracts.Comptroller.Diamond	95%	61%	✔
contracts.Comptroller.Diamond.facets	76%	64%	➖
contracts.Comptroller.Diamond.interfaces	100%	100%	✔
contracts.DelegateBorrowers	100%	89%	✔
contracts.Governance	68%	45%	➖
contracts.InterestRateModels	74%	59%	➖
contracts.Lens	45%	37%	❌
contracts.Liquidator	83%	60%	✔
contracts.Oracle	100%	100%	✔
contracts.PegStability	88%	84%	✔
contracts.Swap	88%	58%	✔
contracts.Swap.interfaces	100%	100%	✔
contracts.Swap.lib	81%	55%	✔
contracts.Tokens	100%	100%	✔
contracts.Tokens.Prime	96%	72%	✔
contracts.Tokens.Prime.Interfaces	100%	100%	✔
contracts.Tokens.Prime.libs	90%	76%	✔
contracts.Tokens.VAI	81%	53%	✔
contracts.Tokens.VRT	20%	9%	❌
contracts.Tokens.VTokens	64%	47%	➖
contracts.Tokens.VTokens.legacy	0%	0%	❌
contracts.Tokens.XVS	19%	8%	❌
contracts.Utils	50%	30%	❌
contracts.VAIVault	50%	45%	➖
contracts.VRTVault	49%	36%	❌
contracts.XVSVault	64%	50%	➖
contracts.lib	89%	71%	✔
Summary 62% (3346 / 5369)	46% (1245 / 2736)	➖

Description
Resolves #
Checklist

[ ]  I have updated the documentation to account for the changes in the code.
[ ]  If I added new functionality, I added tests covering it.
[ ]  If I fixed a bug, I added a test preventing this bug from silently reappearing again.
[ ]  My contribution follows Venus contribution guidelines.


update onboarding docs

Signed-off-by: Stanislav Viyachev<EMAIL_ADDRESS>Detailed description:
Which issue(s) this PR fixes:
Fixes #752
Special notes for your reviewer:
Checklist

[x] Documentation added
[ ] Tests updated

Nice work!


About image processing

Hello, I would like to ask why CIFAR-10 was not pre-processed in your code, while the image of ImageNet was pre-processed?
In addition, does the adversarial examples need to be pre-processed (such as normalization) before being fed into the model for reclassification?

Also, I'm not quite sure whether we are attacking the original image or the pre-processed image? There seems to be a contradiction in your code.

The CIFAR10 images are preprocessed, just using a different preprocessing function. Each network defines color_process(), which is called on every predict() for CIFAR images. E.g., https://github.com/Hyperparticle/one-pixel-attack-keras/blob/master/networks/resnet.py#L165.
The ImageNet notebook is experimental for now. It uses imagenet_utils to do the preprocessing instead. This is a more general approach for arbitrary images, but the code isn't finished here.
As for your final point, the first bit of code is simply a demonstration. If it was preprocessed, it would be hard to view it as an image. The actual attack, however, should use the preprocessed image, as in the second bit.
Hope that helps.

The CIFAR10 images are preprocessed, just using a different preprocessing function. Each network defines color_process(), which is called on every predict() for CIFAR images. E.g., https://github.com/Hyperparticle/one-pixel-attack-keras/blob/master/networks/resnet.py#L165.
The ImageNet notebook is experimental for now. It uses imagenet_utils to do the preprocessing instead. This is a more general approach for arbitrary images, but the code isn't finished here.
As for your final point, the first bit of code is simply a demonstration. If it was preprocessed, it would be hard to view it as an image. The actual attack, however, should use the preprocessed image, as in the second bit.
Hope that helps.

Thank you very much. It helps me a lot!


C# System Double Infinity methods not compiling into JS

I noticed that when I use the C# function Double.IsInfinity(double) in code that I compile through JSIL, the browser throws the error: $T02(...).IsInfinity is not a function. The same applies to Double.IsPositiveInfinity(double) and Double.IsNegativeInfinity(double).
Is this a known issue? If so, is there a reason for it? To the best of my knowledge, this is the best way in C# to check for infinities. Do you know of a good workaround?
Thanks!

The methods just aren't implemented in the BCL stubs. They would probably be very easy to implement.

Same as #664.  I managed to work around them in my code but most turned out to be unnecessary safeguards against scenarios that never happened.  You might have to simulate it by testing against a value above something close to double.Max (with the presumption that double.PositiveInfinity > all other doubles).


Outdated example in documentation

In the documentation on this page: https://docs.rs/nvidia-video-codec-sdk/0.2.0/nvidia_video_codec_sdk/safe/struct.Encoder.html#method.get_preset_config
    .get_preset_config(
        NV_ENC_CODEC_H264_GUID,
        NV_ENC_PRESET_LOW_LATENCY_HQ_GUID,
        NV_ENC_TUNING_INFO::NV_ENC_TUNING_INFO_ULTRA_LOW_LATENCY,
    )
    .unwrap();

The low latency preset is deprecated. It seems that low latency tuning is also not allowed even when using presets 1-7. It throws an error (which I think is incorrectly worded) on execution
thread '<unnamed>' panicked at 'called Result::unwrap()on anErr value: EncodeError { kind: InvalidParam, string: Some("NV_ENC_RC_PARAMS::lowDelayKeyFrameScale is supported with P1-P7 presets\n") }';
In cases like this I suppose the best thing to do is to provide a pull request with an updated example. But I am unsure of what error is that comes up as I am under the impression that some sort of low latency encoding should technically be possible with the encoder but I am unable to figure out what to do about it.

All the doc tests pass for me. Can I see the output of nvidia-smi to see which driver version you are using?
The string part (NV_ENC_RC_PARAMS::lowDelayKeyFrameScale is supported with P1-P7 presets) of the error comes from NVIDIA's API. I can try updating the bindings to the newest version of the API - it might fix it.

Alright, I updated the library to the newest version of the NVIDIA Video Codec SDK (12.1). Make sure to cargo clean before trying to rebuild.

Here is the output from nvidia-smi
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 536.67                 Driver Version: 536.67       CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                     TCC/WDDM  | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce RTX 4050 ...  WDDM  | 00000000:01:00.0 Off |                  N/A |
| N/A   44C    P5               7W /  50W |    508MiB /  6141MiB |     32%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A      1988    C+G   C:\Windows\System32\dwm.exe               N/A      |
|    0   N/A  N/A      4392    C+G   ...CBS_cw5n1h2txyewy\TextInputHost.exe    N/A      |
|    0   N/A  N/A     10436    C+G   ...nt.CBS_cw5n1h2txyewy\SearchHost.exe    N/A      |
|    0   N/A  N/A     11280    C+G   ...2txyewy\StartMenuExperienceHost.exe    N/A      |
|    0   N/A  N/A     11444    C+G   ....0_x64__8she8kybcnzg4\app\Slack.exe    N/A      |
|    0   N/A  N/A     13016    C+G   ....0_x64__8wekyb3d8bbwe\HxOutlook.exe    N/A      |
|    0   N/A  N/A     14444    C+G   ...tility\HPSystemEventUtilityHost.exe    N/A      |
|    0   N/A  N/A     14720    C+G   ...2954_x64__8wekyb3d8bbwe\msteams.exe    N/A      |
|    0   N/A  N/A     15660    C+G   ...cal\Microsoft\OneDrive\OneDrive.exe    N/A      |
|    0   N/A  N/A     16960    C+G   ...50.0_x64__v10z8vjag6ke6\HP.myHP.exe    N/A      |
|    0   N/A  N/A     19572    C+G   ...on\116.0.1938.62\msedgewebview2.exe    N/A      |
|    0   N/A  N/A     21560    C+G   ...am Files\Microsoft VS Code\Code.exe    N/A      |
|    0   N/A  N/A     26604    C+G   ...t.LockApp_cw5n1h2txyewy\LockApp.exe    N/A      |
|    0   N/A  N/A     32376    C+G   ...__nzyj5cx40ttqa\AMPLibraryAgent.exe    N/A      |
|    0   N/A  N/A     41780    C+G   ...0_x64__nzyj5cx40ttqa\AppleMusic.exe    N/A      |
|    0   N/A  N/A     43584    C+G   ...__8wekyb3d8bbwe\WindowsTerminal.exe    N/A      |
|    0   N/A  N/A     50112    C+G   ...\Docker\frontend\Docker Desktop.exe    N/A      |
+---------------------------------------------------------------------------------------+

I did the update, but I am still getting the same issue.
Initializing the preset_config with:
let mut preset_config = nv_encoder
                .get_preset_config(
                    nvidia_video_codec_sdk::sys::nvEncodeAPI::NV_ENC_CODEC_H264_GUID,
                    nvidia_video_codec_sdk::sys::nvEncodeAPI::NV_ENC_PRESET_P1_GUID,
                    nvidia_video_codec_sdk::sys::nvEncodeAPI::NV_ENC_TUNING_INFO::NV_ENC_TUNING_INFO_ULTRA_LOW_LATENCY,
                )
                .unwrap();

I am gonna close this. The default tuning is good enough for real time and there isn't any real need for me to figure out the ultra low latency. The GPU usage is also super low providing me with excellent video quality for the resolution I want at 30fps. I will be running this in AWS on a GPU instance which I am pretty sure is more performant than my onboard card.

It seems that the default value conflicts so this fixed the issue for me:
let rc_params = &mut preset_config.presetCfg.rcParams;
rc_params.lowDelayKeyFrameScale = 0;


Implemented Ghost shadow fix provided by mofumofu-san (pasutisu)

Might want to test this before merging, but given it's mofumofu's code, I don't see why it'd be much issue.

@NodokaHanamura
This bug occured when following condition in latest YSFLIGHT.

switching shadow quality to fast from inflight config.
using shadow map supported renderer (means OpenGL 2.0).

This patch includes 2 fixes for it.

In that condition, SimDrawShadowMap try to notify shadow map disabled to shader and switch shadow map texture to default texture to clear 'ghost shadow'.
In that condition, SimDrawShadow try to render old good fast shadow using SimDrawComplexShadow as alternative of SimDrawShadowMap.


Re-enable ShellTest.WaitForFirstFrameTimeout on Fuchsia

This was disabled due to flakes.

(triage) @gw280 Can you please assign this bug to somebody who is working on it or remove it from the march milestone. All bugs in milestones with a month should be assigned to people actively working on it.

Oh, I already fixed this :)

This was fixed in https://github.com/flutter/engine/pull/16718


[Question] Develop Guide Help

What is the development testing process for openyurt? As a new developer, I'm not sure how I should test it quickly after I've modified the code for openyurt. Of course I can test by replacing the image in the openyurt cluster, but that's too slow. Does openyurt have scripts that similar to kubeedge local-up-kubeedge.sh and e2e , and you can use the script to compile the entire openyurt to pull up a new cluster and do  test suits? And we can also use github action to run automated e2e tests to make sure that the code doesn't introduce other bug, link.

@ke-jobs Thank you for raising this issue.
At present, OpenYurt has some e2e test cases but it's not enough, and have not integrated with github action. Would you have interested in taking over this problem and fix it?

https://github.com/openyurtio/openyurt/issues/410

I'm a new openyurt developer and I'm not familiar with openyurt yet. This work can be done later when I am familiar with it. Or by someone else who is already familiar with the project.

I'd like to intergrate e2e tests with github action.

/assign

/assign @Congrool

@Congrool Would you like to apply OpenYurt community member? you can add me as sponsor and here is an apply example: https://github.com/openyurtio/community/issues/25

@Congrool Would you like to apply OpenYurt community member? you can add me as sponsor and here is an apply example: openyurtio/community#25

@rambohe-ch Thanks for your invitation.
I'd like to apply for the membership after finishing this work.

@Congrool Would you like to apply OpenYurt community member? you can add me as sponsor and here is an apply example: openyurtio/community#25

@rambohe-ch Thanks for your invitation.
I'd like to apply for the membership after finishing this work.

@Congrool ok, looking forward to completing this feature.

The work is almost finished. Now we are waiting for #484 .


fixing create issue where this is no repo

Having an issue creating builds, not exactly sure what the issue was.


update dependencies

MathJax 3.1.3 is out but we should really switch to the amermathsoc branch.

Due to https://github.com/mathjax/MathJax/issues/2674, we will switch to the jsdom adaptor.


[web-service] flush any lingering output before issuing command

This commit ensures to flush any received CLI output before issuing
the command to make parsing the output of the command more reliable.

If otbr-web connects to the OT CLI socket, will it prohibit users from opening another ot-ctl command in interactive mode? @bukepo

If otbr-web connects to the OT CLI socket, will it prohibit users from opening another ot-ctl command in interactive mode? @bukepo

Yes. The same is true for the reverse - if ot-ctl command is in interactive mode, it prevents otbr-web from functioning.

If otbr-web connects to the OT CLI socket, will it prohibit users from opening another ot-ctl command in interactive mode? @bukepo

Yes. The same is true for the reverse - if ot-ctl command is in interactive mode, it prevents otbr-web from functioning.

I tend to think that's a bug. Thoughts?

If otbr-web connects to the OT CLI socket, will it prohibit users from opening another ot-ctl command in interactive mode? @bukepo

Yes. The same is true for the reverse - if ot-ctl command is in interactive mode, it prevents otbr-web from functioning.

I tend to think that's a bug. Thoughts?

ot-ctl keeps connection to server, while otbr-web will not. We can enhance this by close connection when Done is received in response and re-establish when a new command is issued. Thoughts?

If otbr-web connects to the OT CLI socket, will it prohibit users from opening another ot-ctl command in interactive mode? @bukepo

Yes. The same is true for the reverse - if ot-ctl command is in interactive mode, it prevents otbr-web from functioning.

I tend to think that's a bug. Thoughts?

ot-ctl keeps connection to server, while otbr-web will not. We can enhance this by close connection when Done is received in response and re-establish when a new command is issued. Thoughts?

I believe it's a good idea.


Date column type

Came across the following using Python 2.7.10 |Anaconda 2.2.0 (64-bit) querying kdb 3.1 l64

r = query_kdb.query(REGION, '([]2#.z.d)')
20150728 15:31:37.612 INFO IPC version: 3. Is connected: True
20150728 15:31:37.612 INFO Querying KDB. port:[kdbtest], host:[1234], username:[user], timeout:[4.0].
20150728 15:31:37.612 INFO     Query: ([]2#.z.d)
r
QTable([(5687,), (5687,)],
dtype=[('d', '<i4')])
r[0]
(5687,)
type(r[0])
<class 'numpy.core.records.record'>
r[0]
(5687,)

result = query_kdb.query(REGION, '.z.d')
20150728 15:24:26.910 INFO IPC version: 3. Is connected: True
20150728 15:24:26.910 INFO Querying KDB. port:[kdbtest], host:[1234], username:[user], timeout:[4.0].
20150728 15:24:26.910 INFO     Query: .z.d
result
<qpython.qtemporal.QTemporal object at 0x7f67c929e3d0>

It seems the type remains an integer from date columns?

By default qPython represents temporal vectors as instances of qcollection.QTemporalList class. This class wraps the raw q representation of temporal data and provides accessors which allow to convert raw data to qcollection.QTemporal instances in a lazy fashion. (Read more...)
>>>    v = q.sync('2#.z.d')
>>>    print '%s dtype: %s qtype: %d: %s' % (type(v), v.dtype, v.meta.qtype, v)
<class 'qpython.qcollection.QTemporalList'> dtype: int32 qtype: -14: [2015-08-03 [metadata(qtype=-14)] 2015-08-03 [metadata(qtype=-14)]]

If a temporal vector is part of the kdb+ table, the lazy conversion to the numpy datetime objects is not available.
>>>    v = q.sync('([]2#.z.d)')
>>>    print '%s dtype: %s qtype: %d: %s' % (type(v), v.dtype, v.meta.qtype, v)
<class 'qpython.qcollection.QTable'> dtype: [('d', '<i4')] qtype: 98: [(5693,) (5693,)]

qPython can be instructed (Read more...) to represent temporal vectors as numpy arrays of numpy.datetime64 or numpy.timedelta64. This also works for tables with temporal columns:
>>>    v = q.sync('([]2#.z.d)', numpy_temporals = True)
>>>    print '%s dtype: %s qtype: %d: %s' % (type(v), v.dtype, v.meta.qtype, v)
<class 'qpython.qcollection.QTable'> dtype: [('d', '<M8[D]')] qtype: 98: [(datetime.date(2015, 8, 3),) (datetime.date(2015, 8, 3),)]


Generate hashes for all available candidates

Generate hashes covering the PyPi index as well as additional candidates available through an extra index of find-links. Currently if PyPi index is available the hashes will be limited to those available in it.

Contributor checklist

[x] Provided the tests for the changes.
[x] Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

[x] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[x] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Fixes #1662

@atugushev wdyt about the current test coverage?
I've had a failing test on Python 3.11 so I added a couple of troubleshooting lines to get more details.

wdyt about the current test coverage?
I've had a failing test on Python 3.11 so I added a couple of troubleshooting lines to get more details.

$ python -VV
Python 3.11.0 (main, Nov  5 2022, 13:30:21) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]

$ pip install  torch-scatter
Collecting torch-scatter
  Downloading torch_scatter-2.0.9.tar.gz (21 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/private/var/folders/l0/lnq1ghps5yqc4vkgszlcz92m0000gp/T/pip-install-atqd84a8/torch-scatter_16f8ceb7339c4e66b1b07d1d16db074c/setup.py", line 8, in <module>
          import torch
      ModuleNotFoundError: No module named 'torch'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

That's because its been installed from PyPI from sdists (note "Downloading torch_scatter-2.0.9.tar.gz"), which has import torch in setup.py.
With others Python version works fine, because they've been installed from wheels from https://data.pyg.org/whl/torch-1.13.0+cpu.html

That's looking better, thanks for the help on the test side @atugushev.


Remove basic auth as an option for Gitea

I suspect this may increase support communication. If this is the case feel free to direct users to the gitea discord where we can help them switch to OAuth2.
Fixes #2704

@bradrydzewski now that Gitea OAuth support has been in Drone since 1.1.0 would it be possible to review this PR for 1.4.0?

as soon as I have the docs updated to include oauth (which should be soon) I will merge this right away. sorry for the delay!

no worries, I completely understand. I know docs aren't public yet, but lmk if I can help with them.

thanks and sorry for the delay.  the docs have also been updated accordingly.


Uncaught TypeError: Cannot read property 'activeElement' of undefined

Hello,
I am using Laravel Mix with Webpack to include js-offcanvas into my vendor.js file. However, when I click the off-canvas-trigger button I get the following error message:
Uncaught TypeError: Cannot read property 'activeElement' of undefined
Here is my setup:
package.js
  "devDependencies": {
    "Modernizr": "https://modernizr.com/download?ambientlight-batteryapi-webp-setclasses",
    "bootstrap": "^4.1.0",
    "js-offcanvas": "^1.2.2",
    "jquery": "^3.1.1",
    "popper.js": "^1.14.3"
     ...
  }

webpack.mix.js
mix.webpackConfig({
    resolve: {
        alias: {
            "jquery": "jquery/src/jquery",
            "popper.js": "popper.js/dist/umd/popper.js",
            "js-offcanvas": "js-offcanvas/dist/_js/js-offcanvas.pkgd.js",
        }
    }
});

mix.autoload({
    "jquery": ["$", "jQuery", "window.jQuery"],
    "popper.js": ["Popper", "window.Popper"]
});

mix.js("resources/assets/js/app.js", "public/js")

mix.extract([
    "jquery",
    "Modernizr",
    "js-offcanvas",
    "popper.js",
    "bootstrap",
]);

HTML
<button type="button" id="js-offcanvas-trigger" class="navbar-toggler">
    <i class="fa fa-bars" aria-hidden="true"></i>
</button>

<aside id="off-canvas-sidenav" class="bg-light d-none">
    ...
</aside>

Javascript
$(function(){

    $(document).trigger("enhance");

    $("#off-canvas-sidenav").offcanvas({
        modifiers: "right,overlay",
        triggerButton: "#js-offcanvas-trigger"
    });

});

More Info
When I try this without Webpack (using CDN) everything works fine. However the package I build doesn't work. Here is the line of code that throughs the error.
if( doc.activeElement ){
    this.lastFocus = doc.activeElement;
}

After looking at the error log the issue seems to be that w.document is a null value. Should this be the window object? If so, it does not seem to be injected in the w variable. It only contains two attributes componentNamespace and utils
Any help getting this to work in Laravel Webpack would be greatly appreciated.
Thanks!

Hey,
can you try to update your modernizr-build (https://github.com/vmitsaras/js-offcanvas/issues/17)
I think you`ve to add: prefixed & feature-detects.
{
  "minify": true,
  "options": [
    "prefixed",
    "setClasses"
  ],
  "feature-detects": [
    "test/css/transitions"
  ]
}

I tried researching how to do that in Laravel Mix but no luck so far. I will let you know if I find a solution.

OK, I will try and let you know.


 That's totally unacceptable!
I trust good sir that you will take corrective action promptly.
Cheers,
The Biggest G

Hi good sirs @Annihil @contrarian
I think we all should learn from this great man @Ffloriel  how to write our packages. I use this package for my new blockchain bleeding edge project "Hello world" and it works perfectly.
Yes, there are some issues with markdown but have you seen package.json? It's a new level of software development.
Relax,
🚫 🚫 🚫

Hi @Annihil @contrarian @alinaish ,
Thank you for creating this issue and letting me know about this problem.
@Annihil , I appreciate you took the time to write the reproducing steps, it helped.
@contrarian I took action as soon as I saw your comment, it should be partially fixed now.
@alinaish, it is perfectly adapted to blockchain bleeding edge project "Hello world". I'm happy to know it's working for you. You will see it works great with new generation artificial intelligence package "Hello world" as well.


Transfer domain to Golang Vietnam community

As you may know, currently I own the domain gophercon.vn and it will expire soon. The registrar is vinahost.vn
Let me know how can I transfer it to Golang Vietnam?

Thanks @plutov. I have completed the transfer


Add MetaMask to list of browser extension wallets

Kindly add MetaMask with documentation link to list of browser extension wallets under Wallet section.

This issue has been fixed. Thanks to @snehasharma76 🎉


Fix path in run.sh to use hack

I think this was missed during a previous PR
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM (LGTM1 label set)

LGTM (LGTM2 label set)

LGTM, merging.


Initializing StaticPrintConfigs Segmentation fault

Description of the issue
I can't run this appimage, it shows these info.
I actually don't know too much about how to use rasperry pi, I just an 3d fan.
I got these info:
./PrusaSlicer-version_2.4.2-aarch64.AppImage
[2022-04-28 11:44:10.056142] [0x0000007fa1682040] [trace]   Initializing StaticPrintConfigs
Segmentation fault
Hardware environment and OS that is being used to run PrusaSlicer-ARM.AppImage

Hardware Raspberry Pi 4 (4GB)
OS [Raspberry Pi OS  (64-bit/aarch64)]:
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian

Hello,
Thank you for reporting the issue. I've tested the AppImage against a freshly imaged Raspberry Pi OS 11 and cannot seem to reproduce the issue.
Unfortunately the message is not descriptive enough to offer good advice as well. Could you try to move /home/pi/.config/PrusaSlicer away to another directory temporarily, re-run and see if that resolves the issue?
If you are willing to, installing and running strace against the AppImage might reveal the source of the issue too:
$ sudo apt install strace -y && strace ./PrusaSlicer-version_2.4.2-aarch64.AppImage

Hello,
With the release of the alpha build of 2.5.0, please consider trying PrusaSlicer-2.5.0-alpha2 ARM AppImages to see if resolves the issue.
I attempted to reproduce this issue under Raspberry Pi OS aarch64 with 2.5.0 but could not.
If the new alpha release does not resolve the issue, I would like to attempt to reproduce this, but would need extra details on what settings cause the issue

Hello,
Seeing that several versions have passed the original issue has likely become stale (or triaged upstream). Will close this issue, but please re-open if the issue reoccurs on more recent versions and is caused by the AppImage packaging/build. Thank you again for reporting!


[e2e]: go workflow_dispatch branch1 config-ldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/7719838510
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Wed Jan 31 01:30:41 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/7734861405
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Thu Feb  1 01:33:51 UTC 2024
Tests are passing now. Closing this issue.


Cosmos: Create CosmosReceiveModal

AC:

create folder structure (if it doesn't exist):   src/features/cosmos/components/Modals

copy src/components/Modals/Receive to src/features/cosmos/components/Modals
Remove all chain specific code from all files (as necessary, leave comment blocks to add Cosmos specific code later)
As possible, break up large components into small re-usable chunks
As possible, move reusable components into src/features/components.

see: https://github.com/shapeshift/web/pull/984/files


OneShot method doesn't call onDraw();

Anyone has idea why OneShot method doesn't call onDraw(); ?
But when i use Emitter example, onDraw called and display the particles...
I've used dispatchDraw, but it still has no particles displayed ...
(*Only happened on some devices)

I'm quite sure it does work. Can you share the code on how you're seeing it up?
There are examples for oneShot on the samples project


[kong] patch dp example

What this PR does / why we need it:
It's my understanding that ca cert and cluster certs are not supposed to be the same thing.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the next branch and targets next, not main
[x] Title of the PR and commit headers start with chart name (e.g. [kong])

Minor thing first: next wasn't updated with the latest commits from main when this was created, and it looks like this was created from main, hence the unrelated commit for the stalebot config. You should be able to fix that by pulling next and rebasing your branch to it.
This example was created before we added PKI mode, hence why it only has the single certificate. If we're going to PKI mode as the de-facto standard, this should be accompanied by updates to https://github.com/Kong/charts/tree/main/charts/kong#hybrid-mode and https://github.com/Kong/charts/blob/main/charts/kong/example-values/minimal-kong-hybrid-control.yaml as well, not just the DP example.
I'm not clear on whether that's the certificate that the data plane needs to trust--intuitively, trusting the CA makes sense, but https://docs.konghq.com/gateway-oss/2.3.x/hybrid-mode/#starting-data-plane-nodes still has:

In addition the cluster.crt file need to be listed as trusted by OpenResty through the lua_ssl_trusted_certificate configuration.

That may not have been updated (it looks like it's unchanged from the 2.0 doc), but the https://docs.konghq.com/gateway-oss/2.3.x/hybrid-mode/#pki-mode section doesn't make any mention of lua_ssl_trusted_certificate. Do you know the reason for that discrepancy/what's actually correct?
Lastly, since lua_ssl_trusted_certificate applies to things other than hybrid mode checks, it should take advantage of the system built-in and support for multiple trust stores from https://github.com/Kong/kong/pull/6342, so something like lua_ssl_trusted_certificate: system, /path/to/hybrid/cert.pem.

Ah seems I may have misunderstood the nature of this change, I was under the impression it was just a potentially misleading example. as it is linked to in the konnect docs in a PKI context. I'll step back on this until docs team has a chance to update the approach. Thanks @rainest !


FSharp.Compiler.Tools.4.1.0 does not work with net46 fsproj in VisualStudio

I want to use the F#4.1 compiler with VS2015.
Repro steps
Create a new F# console project in Visual Studio 2015.
Add the package FSharp.Compiler.Tools.4.1.0.
Run build.
Expected behavior
It should compile the project using the new compiler.
Actual behavior
1>------ Rebuild All started: Project: FsTest, Configuration: Debug Any CPU ------
1>	c:\users\lr\documents\visual studio 2015\Projects\FsTest\packages\FSharp.Compiler.Tools.4.1.0\build\netcoreapp1.0\fsc.dll -o:obj\Debug\FsTest.exe -g --debug:full --noframework --define:DEBUG --define:TRACE --doc:bin\Debug\FsTest.XML --optimize- --tailcalls- --platform:anycpu32bitpreferred -r:"C:\Program Files (x86)\Reference Assemblies\Microsoft\FSharp\.NETFramework\v4.0\<IP_ADDRESS>\FSharp.Core.dll" -r:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.1\mscorlib.dll" -r:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.1\System.ComponentModel.Composition.dll" -r:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.1\System.Core.dll" -r:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.1\System.dll" -r:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.6.1\System.Numerics.dll" --target:exe --warn:3 --warnaserror:76 --vserrors --LCID:1033 --utf8output --fullpaths --flaterrors --subsystemversion:6.00 --highentropyva+ --sqmsessionguid:f4681a33-2fc3-45ca-93a7-c1cdcf856afe "C:\Users\lr\AppData\Local\Temp\.NETFramework,Version=v4.6.1.AssemblyAttributes.fs" AssemblyInfo.fs Program.fs
1>C:\Program Files (x86)\Microsoft SDKs\F#\4.0\Framework\v4.0\Microsoft.FSharp.Targets(155,9): error MSB6006: "fsc.dll" exited with code -532462766.
1>Done building project "FsTest.fsproj" -- FAILED.
1>
1>Build FAILED.
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

notice how it runs fsc.dll
Workaround
I edited packages\FSharp.Compiler.Tools.4.1.0\build\FSharp.Compiler.Tools.props to look like this:
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

  <PropertyGroup>

    <!-- Default to netcoreapp fsc -->
    <FscTaskAssemblyPath>$(MSBuildThisFileDirectory)../tools/FSharp.Build.dll</FscTaskAssemblyPath>
    <FscToolPath>$(MSBuildThisFileDirectory)../tools</FscToolPath>
    <FscToolExe>fsc.exe</FscToolExe>
    <FscToolFullPath>$(MSBuildThisFileDirectory)../tools/fsc.exe</FscToolFullPath>

  </PropertyGroup>

</Project>

Now it correctly calls the compiler, and a simple program compiles correctly:

Notice how the build succeeds, even though intellisense complains about struct because it is Visual Studio 2015.

@0x53A Please submit that as a PR?  (Also if you find a way to NGEN the fsc.exe prior to execution that would be awesome - assuming admin privileges are available)

@dsyme Are you familiar with the package? To be honest, I'm not even sure if my scenario is supposed to work, after looking a bit into it I think this package is primarily meant for net core support?
The tool to run (exe for netfx / dll for netcore) would need to be switched based on some variable, I think I could use $(TargetFrameworkIdentifier) =='.NETCoreApp'. (ref https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/target-dotnetcore-with-msbuild.md)
Roslyn has two packages:
https://www.nuget.org/packages/Microsoft.Net.Compilers/ and https://www.nuget.org/packages/Microsoft.Net.Compilers.netcore/
So maybe the correct solution would be to publish a second package with my changes, FSharp.Compiler.Tools.FullFx (or similar)?
Regarding ngen: I don't think this decision should be taken by the package. If the user want's ngen, they should restore the package and then manually run ngen in the build script.
What roslyn uses is a (optionally enabled by $(UseSharedCompilation)) compiler server, so that the jit cost is only paid once.
@enricosada Do you think I should try to modify this package, or create a second one? My goal is to use something equivalent to Microsoft.Net.Compilers  for full framework in Visual Studio.

@dsyme Are you familiar with the package? To be honest, I'm not even sure if my scenario is supposed to work, after looking a bit into it I think this package is primarily meant for net core support?

The primary intention of the package is .NET Framework support.  .NET Core support was just added recently.   However we have never checked out whether "add package" would wire up the compiler - we just wired up the properties by hand whenever the compiler was actually being used
@enricosada Is the .props file part of the .NET Core support? What do you think the right thing to be doing here is?

@0x53A Note that this package is actually defined in http://github.com/fsharp/fsharp

It should compile the project using the new compiler.

atm is not supported to work like that, just because is not implemented as use case.
old way (and supported), is to use FscToolPath property to point to local installation.
That said, FSharp.Compiler.Tools package can do that, if correctly authored.
NGen can be added probably, but as first run, not at install time (there is no way to do that afaik). but is fragile.
No need to have two packages, roslyn do that because of split needed to embeed in VS and dotnet/cli.
Also we are going to add netcoreapp1.1 fsc there too soon (so net45, netcoreapp1.0, netcoreapp1.1 and future netcoreapp2.0)
anyway ihmo should closed and moved in fsharp/fsharp repo. I'll comment your pr too.


Web shows full offline edit history upon return online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Actual Result:
The chat cycles through all edits that were made
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.24-0
Reproducible in staging?: y
**Reproducible in production?:**y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @dangrous
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667604470708629
https://user-images.githubusercontent.com/43996225/200318415-3564167f-6c34-43d1-aa63-4f90c58832ae.mp4
View all open jobs on GitHub
https://user-images.githubusercontent.com/43996225/200318438-273e53fd-0b88-43ee-ba0b-c665596e5e33.mp4

I was able to reproduce this. Assigning an engineer to triage - can this be worked on by an external contributor?

@marcaaron and I have already noticed and had a discussion about this error here, for now we've agreed not to do anything.
A solution to this would have to involve modifying the SequentialQueue to merge requests that have the same command. For now we've decided this is not a priority, since the final value that it lands on after cycling through all the values is the correct value that was last set.
Therefore, I'm going to close this out for now


Howto recover from bad pubsub channel subscription

Hi,
I use a channel subscription and at some stage I got a lot of the following errors without recovery, I had to restart the application for it to recover. Must I add my own ping pong handler to detect errors like this?
"redis: 2018/10/09 06:27:02 pubsub.go:149: redis: discarding bad PubSub connection: %!s(<nil>)
Im using redis:5.0-rc4.
Thanks!

Please try to upgrade go-redis and use PubSub.Channel API. If this is still a problem please create a program that reproduces it.

Hi, Im struggling to create a small repo to reproduce it but have changed the way I consume subscriptions to only use one PubSub.Channel like you suggested. I also upgraded to the latest master branch now. Will let it run over the weekend and then either close this issue or try again with the small program to recreate to it. Thanks

Hi @vmihailenco ,
It looks like theres a defer missing https://github.com/go-redis/redis/blob/master/pubsub.go#L441 that might cause the issue? It will not send the ping because the timer is stopped immediately. With the latest master branch I get the error that was fixed recently instead of the  like above (ping timeout).

The only way I could reproduce this issue is buy blocking until the message send buffer fills up.


fix:  Use unique id instead of indices as keys for DraggableList

Description

Reordering page list and then renaming a page won't update the targeted page's name due to key mismatch. We were using index as key for the DraggableList component. So changed the list to take unique page ids for the list items keys.

Fixes #9991
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Go to any application, create 3 pages, swap 2nd and 3rd page's order. Now rename the 3rd page, it works as expected. Previously, it was renaming the 2nd page instead of the 3rd page.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/pages-list-rename-bug

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
app/client/src/pages/Editor/PagesEditor/index.tsx
46.81 (-1.02)
42.86 (-17.14)
0 (0)
47.83 (-1.06)

/ok-to-test sha=bd269b3

/ok-to-test sha=102dbcf

This may lead to bugs at other places as pageId is not being passed at all places. Since this is a bug in just one file app/client/src/pages/Editor/PagesEditor/index.tsx you can use something similar here as file app/client/src/components/propertyControls/FieldConfigurationControl.tsx line no. 226 and have send id as well as pageId with both being equal to pageId itself:
const draggableComponentColumns = pages.map(
      ({ identifier, isCustomField, isVisible, label }, index) => ({
        id: identifier,
        index,
        isCustomField,
        isVisible,
        label,
      }),
    );

Thanks @ankitakinger , I have made those changes you suggested. Please review.

/ok-to-test sha=308da3e

@berzerkeer @ankitakinger I actually had another PR in the pipeline for this on a different (duplicate) issue.
Use of items[i].id should have been the best way to solve this but since the component DraggableList is used in a lot more places this breaks few of them, eg, Table Widget's primaryColumns in property Pane. Most of them don't seem to have reliable unique ids. here is a reference to my PR https://github.com/appsmithorg/appsmith/pull/13448.


Interaction Prompt UI being synced between different players

Cogito and Godot Engine Version:
Godot Engine 4.3, Cogito is current branch version
Also tested & issue present in Godot 4.2.2
Description:
Interaction Prompt UI being synced between different players
Reproduction steps:

Launch multiple instances and all join a lobby together
On any instance (seems to be possible for host to client and client to host) walk up to the nearest hint
Interaction Prompt UI may show for all players, doesn't always happen but seems to be most common with Hints & Doors, never seems to happen with any Carryables.

Expected behavior:
Interaction Prompt UI only displays for relevant player
Screenshots:

Adding to this it seems to always be the same interactables that are having this isssue, not random.
However I can't see anything unique about the setup of those  interactables that's causing this issue.
For example with these hints:

The left hint is always fine, and the right one always has this issue.
Changing the text of the readable had no effect, but somehow changing the position of the right hint to 1,1,1 makes it  work fine.
Another thing is that the interaction prompt always works as well, so player A can trigger an interaction in front of player B when this happens. Even possible when player A has a totally different prompt in front of them.

My guess on this would be that since the client players are full players, they have an interactor ray that is also checking for inputs every frame.

See if 39bec90f74dc3b8ee72f7e77583409489683dfe3 fixes this issue. I am simply calling queue_free on client PlayerInteractionComponent.


Shader Issue

I'm no programmer, but I've just noticed something interesting. If i run DW2Net6Win.exe and load up a game, it crashes when i try to load a starbase design. Every time, without fail. I've just ran the default exe, and its started up, said the loader is operational, but the sandbox security thing you've made is disabled. I load the game, and its let me access the spaceport designer...
Every time its crashed (Multiple times over the last 3 days, with the sandbox on), its referenced a shader that doesn't exist on my install, yet when the security sandbox is disabled, it seems to load correctly. I'm in the process of tracking down old logs to see if the shader is now there.
Does this game make shaders (or whatever it is) as it goes along, and is the sandbox you've made for security affecting it doing that?
Im SO sorry i cant explain it better than that. Just an observation I've made this evening.

Yea, super odd. Ever crash (about 8 of them) all reference
"System.AggregateException: One or more errors occurred. (One or more errors occurred. (Access to the path 'C:\Program Files\Steam\steamapps\common\Distant Worlds 2\log\shader_DW_ForwardShader_c6a210f53dd2227dfc02d242c2dd09ae.hlsl' is denied.))"
This file was not present up until this evening, when it was created roughly 15 seconds after i started my save without the sandbox enabled...

Yeah this has been fixed in a prerelease.
You can grab artifacts from the main action and see if it solves your issue.
For example, try the latest main artifact from here: https://github.com/DW2MC/DW2ModLoader/actions/runs/2142325090
A new release will happen some time later.

Ah ace. Nice work dude, 1 step ahead ;)


[Question] Is the response format "Answer the question using a single word or phrase. " used during training?

Question
I tried to search for this response formatting prompt, but I only see it in playground/data/eval/MME/convert_answer_to_mme.py. How is this used during training?

grep Answer the question using a single word or phrase. path_to_llava_v1_5_mix665k.json. And you can find relative conversations. https://huggingface.co/datasets/liuhaotian/LLaVA-Instruct-150K/tree/main

@hill2hill Thanks for providing the link.
You may also refer to Table 7 in the response format prompt used.

@linzhiqiu Anywhere you want, as long as the correct path is provided --data_path ./playground/data/llava_v1_5_mix665k.json
It does not need to be under the same path as your image folder.


Lower all-to-all communication volume in fft transposes

Currently we transpose a complex array before/after doing the fft/ifft in the preconditioner.
The forward transpose before the fft and the backward transpose after the ifft could be on real arrays, which would halve the communication volume. This would need a second pencil/transfer to be created for the real transposes.

The mpi4py-fft module uses Alltoallw for the transpose, which can take different lengths and types of data on each rank. As far as I know this is rarely optimised by vendors because its so general, so is just implemented as a big isend/irecv round.
If we can change this to Alltoallv then it might improve the performance because this is more likely to be optimised for proper nlogn collective performance.

[ ] Benchmark current implementation (all complex transposes and alltoallw)
[ ] Benchmark reduced transpose volume (real-complex transposes and alltoallw)
[ ] Benchmark alltoallv (all complex transposes and alltoallv)
[ ] Benchmark both optimisations (real-complex transposes and alltoallv)


Correction while getting children from dom

When we use for (let el of this.$el.children) { it happens to the for loose it self because this.stack.createCard(el) manipulate the cards list.

So, instead of using just for (let el of this.$el.children) {, I suggest to use:
let children = [].slice.call(this.$el.children);
for (let el of children) {
Just like the original source code from swing.

Thank you for contributing!
Can you write it with a forEach instead? The [].slice.call syntax is a bit obscure. You'll have to convert the HTMLCollection into an array, first, to make it iterable.

Great! I'll merge it in and publish a new version tomorrow when I'm at a computer. Thanks!

Okay.
Thank you!


💅 Variable names are auto fixed in a breaking way

Environment information
CLI:
  Version:                      1.6.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "screen-256color"
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Linter:
  Recommended:                  false
  All:                          true
  Rules:                        a11y/noSvgWithoutTitle = "off"
                                a11y/useAltText = "off"
                                a11y/useButtonType = "off"
                                a11y/useIframeTitle = "off"
                                a11y/useKeyWithClickEvents = "off"
                                a11y/useMediaCaption = "off"
                                a11y/useValidAnchor = "off"
                                complexity/noBannedTypes = "off"
                                complexity/noForEach = "off"
                                complexity/noUselessSwitchCase = "off"
                                correctness/noChildrenProp = "off"
                                correctness/noInnerDeclarations = "off"
                                correctness/useExhaustiveDependencies = "off"
                                nursery/useImportRestrictions = "off"
                                security/noDangerouslySetInnerHtml = "off"
                                style/noArguments = "off"
                                style/noNonNullAssertion = "off"
                                style/noParameterAssign = "off"
                                suspicious/noArrayIndexKey = "off"
                                suspicious/noAssignInExpressions = "off"
                                suspicious/noExplicitAny = "off"
                                suspicious/noPrototypeBuiltins = "off"
                                suspicious/useValidTypeof = "off"

Workspace:
  Open Documents:

Rule name
lint/style/useNamingConvention
Playground link
https://biomejs.dev/playground/?code=ZgB1AG4AYwB0AGkAbwBuACAAbABvAGEAZABXAGkAZABnAGUAdABDAG8AbQBwAG8AbgBlAG4AdAAoAHcAaQBkAGcAZQB0AEkAZAA6ACAAVwBpAGQAZwBlAHQASQBkACkAIAB7AAoAIAAgAGMAbwBuAHMAdAAgAEMAbwBtAHAAbwBuAGUAbgB0ACAAPQAgAGcAZQB0AFcAaQBkAGcAZQB0AEMAbwBtAHAAbwBuAGUAbgB0ACgAdwBpAGQAZwBlAHQASQBkACkAOwAKACAAIABpAGYAIAAoACEAQwBvAG0AcABvAG4AZQBuAHQAKQAgAHIAZQB0AHUAcgBuACAAbgB1AGwAbAA7AAoAIAAgAHIAZQB0AHUAcgBuACAAPABDAG8AbQBwAG8AbgBlAG4AdAAgAC8APgA7AAoAfQA%3D
Expected result
Right now this code:
function loadWidgetComponent(widgetId: WidgetId) {   const Component = getWidgetComponent(widgetId);   if (!Component) return null;   return <Component />; }
Is converted to:
function loadWidgetComponent(widgetId: WidgetId) {   const component = getWidgetComponent(widgetId);   if (!component) return null;   return <Component />; }
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

I want to fix this~

I think the issue is coming from the semantic model that failed to bind the variable Component with the JSX element Component.


File was opened but no data is displayed!

The file was opened with its folder included, but there was nothing in it. Can't save when saving it says file not found.
What happened!
Neovim 0.10

I'm facing the same issue. The file opens but it's empty. @NTTKDeveloper where you able to find a solution?

I updated the troubleshooting section of the readme section accordingly. PR welcome


Create a dockerhub image

Is it possible to create some official dockerhub image?

this is not going to be done in the short term


Render ferry routes

Adds the rendering of ferry routes starting at zoom level 11 (the lowest available)
The absence of them is particularly noticeable in places that heavily rely on ferries for transportation like Puget Sound. For styling I reused the waterLabel color definition to stick with the same palette. I think a navy blue color makes sense as it's a blend of the colors used for roads (black) and water (light blue). Dashed lines seemed like a pretty standard choice in denoting ferry routes and I went with something a bit bolder than the dashes used for boundaries to avoid confusion.
Before:

After:

Initially I thought the line style was a bit thick, but it works a lot better with the labels present.  I'd like to get some opinions from the other maintainers.

I think this looks generally pretty good.  Thanks for working on it!  The lines feel a bit heavy to me, making them stand out from the water color a bit too much.  Maybe a slightly thinner line and/or a lighter shade of blue would help with this.  I also think the labels would look better if they were closer to the styling of the other water labels with dark blue text matching the line color and a much more subtle halo.  The current halos feel like they have an overly high contrast to me.

Maptiler's transportation_name has subclass=ferry but Planetiler has class=ferry.

@zekefarwell maybe it's my bias from living in the Puget Sound area—where most of these ferry routes are technically state highways that would basically have a classification of highway=primary (and in my opinion some should even be connections to some highway=trunk)—that made me go for a heavier design here. But as there's no such tagging hierarchy for ferries, I'm open to suggestions that might better suit more regions!
I also did try out both a subtler halo and using the waterLabel color for the ferry labels, but it didn't look as good to me in the Metropolis Light font at size 12. But here's a preview of what it would look like to more closely match the water styling, I think it looks good on its own, but I don't find it as legible where there are several routes tightly packed (I think this is where the larger halo helps):

I also think we would want to drop one of either the italics or the bold to help distinguish the ferry labels from water labels.

Maptiler's transportation_name has subclass=ferry but Planetiler has class=ferry.

I didn't even see any documentation for using ferry as a value for class (in the transportation layer) and subclass (in the transportation_name layer) in the @OpenMapTiles schema documentation so I had to do some digging to find that these were even usable 🙁

I also think we would want to drop one of either the italics or the bold to help distinguish the ferry labels from water labels.

Here's a style that might work well for the labels, it's pretty much halfway between the road label style and the water label style. It uses Metropolis Regular Italic for the font, a slightly decreased halo width (1.5), a dark blue (same hue and saturation as waterLabel with 8% lower value) for the font color, and a slightly darker halo color (#eee instead of #fff):

I'm going to post this in Slack as well and commit it after hearing feedback ✏

I think the choices you originally made for font, weight (not bold), and style (not italic) were good.  I was only suggesting an adjustment to one or more of the text color, halo color, and halo size.  Using exactly the same text treatment as the water labels as shown in this comment, is definitely not what I'm suggesting.  The last screenshot feels like a definite improvement to me.  To me the text still feels not quite blue enough and the halo feels a bit too strong.  Maybe going further would negatively impact readability though.
Your perspective on the imprortance of these ferry routes, and why they should be prominent makes sense.  Since there aren't different classifications for ferry routes, though, we have to strike a balance that will work well for both important and unimportant ones.  I'll pull down this branch and look at some different areas tonight to get a better feel for the current line weight.

New York City is another good area to look at, with much higher density of ferry routes. I just noticed a couple of issues from looking there...
Overlapping routes cause what appears to be a solid line rather than a dashed one (but I'm not sure if this is fixable on the style side or if there are features that need to be merged in the data):

Body of water labels covered by ferry lines (I'll commit a fix shortly by reordering the layers):

Which begs another question: Should body of water labels or ferry route labels take priority? I think I'd lean toward giving priority to the body of water labels, as those serve as larger navigational aids (in my opinion) than an individual ferry route. At high zoom both should coexist fine.

Maptiler's transportation_name has subclass=ferry but Planetiler has class=ferry.

Pinging @msbarry to see if there might be a planetiler bug exposed here?

On transportation layer, class=ferry in both planetiler and maptiler. Shouldn't the class/subclass on transportation_name match the class/subclass on corresponding lines in transportation?

Shouldn't the class/subclass on transportation_name match the class/subclass on corresponding lines in transportation?

That would be a sensible assumption, but currently in the tiles transportation has class=ferry while transportation_name has subclass=ferry for some reason.  Seems like this may be a mistake, but hard to say since the schema docs don't say anything about ferries at all.

I could see maybe adding subclass=ferry to planetiler output in transportation and transportation_name layers in addition to class=ferry for compatibility but I wouldn't drop class=ferry since this seems like an openmaptiles bug. I think the intent should be for transportation and transportation_name to be in sync. Is this an issue for aerialways or railways too?

I could see maybe adding subclass=ferry to planetiler output in transportation and transportation_name layers in addition to class=ferry for compatibility but I wouldn't drop class=ferry since this seems like an openmaptiles bug. I think the intent should be for transportation and transportation_name to be in sync. Is this an issue for aerialways or railways too?

I tend to agree that this sounds like a bug in OpenMapTiles, and I've opened openmaptiles/openmaptiles#1373 describing this issue.
As a workaround, @Pengor I think we need to modify this PR to match on either class=ferry or subclass=ferry which will ensure that we're compatible with either variant.  Please also add a comment in the code referencing openmaptiles/openmaptiles#1373 so that we can remove the double-match at some future time when this issue is corrected.

Okay, after adding a few suggestions I think this is likely in good shape now. Colors now match @zekefarwell's proposal, I think they worked well ⛴

Preview for Puget Sound:

And New York City:

Ship it!


dataset.search_batch() function outputs all -1 indices sometime.

I am working with RAG and playing around with different faiss indexes. At the moment I use index = faiss.index_factory(768, "IVF65536_HNSW32,Flat").
During the retrieval phase exactly in this line of retrieval_rag.py an error issue when all retrieved indices are -1.  Please refer to the screenshot of a PID worker.

Here, my retrieve batch size is 2 and n_docs is 5. I can solve this by working around np. stack, but I want to ask, why we get an output index of -1. Do you have any idea :) ?
Is this a problem of the index, where the faiss can't find any similar vector?
Is there documentation on the output index being -1?
@lhoestq

Actually, I found the answer here.
So we have to do some modifications to the code for instances where the index doesn't retrieve any IDs.

@lhoestq  @patrickvonplaten
I also found another short bug in the retrieval part.   Especially, when retrieving documents. If Faiss returns the -1 as the index, the retriever will always use the last element in the dataset.
please check def get_doc_dicts function
Does the use of the HNSW guarantee to retrieve valid indexes always?

No it happens sometimes to return -1, especially if your dataset is small.
If your dataset is big enough it shouldn't happen.
Ideally we should ignore all the -1 that are returned. It should be possible to change that in RAG's code

I also checked with some indexes it returns more -1s. Specially with IVF
when nprobr is very low. It doesn't happen when using HNSW though. But at
the moment if it happens, dataset will always return the last element.
Maybe we should change it to repeat the most last valid retrieved doc id.
What do you think?
On Wed, Apr 7, 2021, 21:09 Quentin Lhoest @.***> wrote:

Hi !
No it happens sometimes to return -1, especially if your dataset is small.
If your dataset is big enough it shouldn't happen.
Ideally we should ignore all the -1 that are returned. It should be
possible to change that in RAG's code
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/huggingface/datasets/issues/2175#issuecomment-814746509,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA4FGTENOTLBEZTXEO2RS3THQOMPANCNFSM42PRVYDA
.

That would be an easy way to workaround this issue. Feel free to open a PR on transformers and ping me ! :)

Sure.  Will push everything together with RAG end to end. :) thanks a lot.
On Wed, Apr 7, 2021, 21:16 Quentin Lhoest @.***> wrote:

That would be an easy way to workaround this issue. Feel free to open a PR
on transformers and ping me ! :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/huggingface/datasets/issues/2175#issuecomment-814752589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA4FGWLROCGARKN7WOJYSTTHQPH5ANCNFSM42PRVYDA
.


JFrog.Conan version 1.37.2

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

the PackageName is actually Conan Package Manager, but since the Publisher is not showing up i didn't bother to request a change.


[Flake] storage emulator fails to start

https://pantheon.corp.google.com/cloud-build/builds;region=us-east1/4e2f08d2-c692-4490-9526-39d6a6a0359e;step=3?project=cloud-cpp-testing-resources

Executed 0 out of 8 tests: 8 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 9 total actions
[ -------- ] Integration test environment set-up
Launching Cloud Storage emulator in the background
Cannot connect to emulator; aborting test.
[2021-06-25 22:04:00 +0000] [4360] [INFO] Starting gunicorn 20.1.0
[2021-06-25 22:04:00 +0000] [4360] [INFO] Listening at: http://<IP_ADDRESS>:8585 (4360)
[2021-06-25 22:04:00 +0000] [4360] [INFO] Using worker: gthread
[2021-06-25 22:04:00 +0000] [4368] [INFO] Booting worker with pid: 4368
[ -------- ] Integration test environment tear-down.
Killing emulator server [4360] ... done.
[ ======== ] Integration test environment tear-down.

https://pantheon.corp.google.com/cloud-build/builds;region=us-east1/da3f25f2-9de7-43ed-bac6-5e2280e3a2e3;step=3?project=cloud-cpp-testing-resources
Executed 8 out of 8 tests: 8 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 9 total actions
[ -------- ] Integration test environment set-up
Launching Cloud Storage emulator in the background
Cannot connect to emulator; aborting test.
[2021-07-01 20:14:36 +0000] [26924] [INFO] Starting gunicorn 20.1.0
[2021-07-01 20:14:36 +0000] [26924] [INFO] Listening at: http://<IP_ADDRESS>:8585 (26924)
[2021-07-01 20:14:36 +0000] [26924] [INFO] Using worker: gthread
[2021-07-01 20:14:36 +0000] [26932] [INFO] Booting worker with pid: 26932
[ -------- ] Integration test environment tear-down.
Killing emulator server [26924] ... done.
[ ======== ] Integration test environment tear-down.
==> 🕑 xsan completed in 392.394 seconds

I just realized that this is a duplicate of #6832. Will update that bug.


feat: Added support for memo

Closes #88
Account Number:<PHONE_NUMBER>de48e4bf2ed2a9b4b839e6b2603018ecdfbf4cffdb2065e01a3ed1

@zinoadidi This should work as far as I know, but since I can't test it anywhere it might not work as expected.

will you update when you manage to test it;
also, tests should be updated as well to reflect possibility with memo
and docs
and I saw some places where 'empty string' was used instead of STRING  type didn't pay much attention but could be something to check in code

will you update when you manage to test it;
also, tests should be updated as well to reflect possibility with memo
and docs
and I saw some places where 'empty string' was used instead of STRING type didn't pay much attention but could be something to check in code

Sure, I will update docs and tests when I can confirm that it works.
The empty string is done on purpose since memo isn't mandatory.

ok cool;
Maybe something to check, I remember with TS it doesn't include the file if its not set
as I read in the discord chat, bucky says its possible to omit the field from request if user doesn't provide it.
Its just a theory, we can check it

Yeah that shouldn't be an issue we can test it when the banks are up.

Hey @AbhayAysola there is already a PR on the account manager for the memo.
I think you can use this to implement the memo here since it was made directly from the core team

Here's the PR https://github.com/thenewboston-developers/Account-Manager/pull/615

Here's the PR thenewboston-developers/Account-Manager#615

Yep that's exactly what I did

@AbhayAysola Okay so all that's left is:

check that the memo only has alphanumeric characters by using the
same  regex expression as in the PR:   /^[a-zA-Z0-9_ ]*$/
Remove leading spaces using the .trim() method
And if memo is empty just remove it from the transaction object

Do all of these in the createTransaction() method in the PaymentHandler class
This is the last thing needed for the migration to the account manager. I could make the updates on your branch if you want

I added those in

@AbhayAysola Nice!
@zinoadidi We can merge this in now and create new tasks for test and docs

I tested it and made some changes @zinoadidi @tomijaga
Should I update tests and docs in this PR or will it be in another task?

@AbhayAysola you can go ahead and update test and docs as well; mention me when its ready and we can have this feature released as well;
Good job!

@zinoadidi I updated the docs but there wasn't anything to change in the tests since it is just an addition of a field.

@AbhayAysola seen.
I do think the field should be reflected in the tests and transaction that don't meet the requirements should be included in test / updated to work with and reject memo as well
Else it will be possible to remote the field unknowingly in future and the tests will not catch it

@AbhayAysola seen.
I do think the field should be reflected in the tests and transaction that don't meet the requirements should be included in test / updated to work with and reject memo as well
Else it will be possible to remote the field unknowingly in future and the tests will not catch it

Hmm I guess you're right. I'll add that in

@AbhayAysola confirm your account number

@AbhayAysola confirm your account number

8928526805de48e4bf2ed2a9b4b839e6b2603018ecdfbf4cffdb2065e01a3ed1


Zoom by number of images per row

This PR implements #71, which is to zoom by an integer number of images/thumbnails per row! This allows the app to always use the full space available to it for displaying items! 👍
This also fixes the issue from #95 in a nicer way! 🎉
This PR is going to supersede #160, as I've integrated that change into this one! 😄

This also improves the full view handling! 😄

I'm absolutely loving it! ❤
My first reservation was about scaling images by not-nice fractions (not +50% but things like +37% could look ugly). But resizing to fit the width works just so beautifully!
I wonder if the app should update the screenshot size when the app is resized 🤔 -- unsure how often and when users resize the app (and what they would prefer to happen when they do).
The size increase from 2 screenshots per row to 1 screenshot per row is really large; but I'm guessing there's little reason to want an in-between size 💭 ... only likely to matter in the details view 👌
I think after this merges, we'll need to adjust this feature a bit for the details view, to prevent the details view to expand to full-width (it then hides the details).
I think the app is much better with this feature 👍 ❤ 💯
AMAZING work 🙇


Design Meeting Notes, 3/10/2023

Parsing Octal Literals and Escapes
https://github.com/microsoft/TypeScript/pull/51837/
// allowed outside of strict mode
function loose() {
    // numeric octal
    console.log(0170);

    // octal string escapes
    console.log("\170");
    console.log("\0170");
}

// errors in strict mode
function strict() {
    "use strict";

    // numeric octal
    "use strict"; console.log(0170);

    // octal string escape
    "use strict"; console.log("\170");
    "use strict"; console.log("\0170");
}

function errorsAlways() {
    // octal template string escapes
    console.log(`\170`);
    console.log(`\0170`);
}

// valid ALWAYS
function validAlways() {
    // explicit octal
    console.log(0o170);

    // not even an octal string escape sequence
    console.log("\0o170");

    // Tagged Template Strings
    console.log(String.raw `\170`);
    console.log(String.raw `\0170`);
}

4.9 Playground
PR Build

In JS, octal numeric literals have a leading zero

It is an error to use this in strict mode

Octals also exist in string escape sequences

Don't need a leading zero(!)
It is an error to use this in strict mode

Octals also exist in template strings

It is an error to use this in any mode

You may write 0o170 in any mode
"\0o170" is not a string escape sequence, though.
You may write String.raw`\170` and get the string "slash one seven zero"
TS currently fails to error on \170 in strict mode.
This PR fixes this, but also treats octals in sloppy-mode is if they were in strict mode.
Does anyone want to stand up for sloppy mode?

No.

Think this is technically Annex B, so we can claim your engine technically might not support this.
Steelman case: Someone using TS for JS-only tooling purposes?

Probably rare, and parse errors can be ignored.

Saves some performance.
Conclusion: Ship it!

Testing Node 12.20
https://github.com/microsoft/TypeScript/pull/53194

Made it so 5.0 says Node 12 is a minimum (even though we work on lower than that right now).
But Node 12 is old.

Should we have set our minimum to higher?
Feels like it's a bit too late for that.

Our infra can't use stuff like ?? and ?. if we have to test on Node 12.
Also, stable sort is only mandated in ES2019 (so questionable if Node 12 can "guarantee" that even if it always has)
Could we say "TypeScript 5.x will always support Node 12?"

That's going to be 2.5 years! Node 12 doesn't even get security updates anymore, does it?
Node 12 goes out of maintenance in April.
TypeScript 5.1 goes out just after that - doesn't make sense to support.

Conclusion: should say Node 14 is what's supported in 5.1, so don't add a test runner we'd have to rip out immediately.

Wait, I could have sworn 0oXXX style octals weren't introduced until ES6... weird that 0XXX is disallowed in strict mode since that breaks any ES5 strict-mode code that uses them

Off-topic but I really don't like V8's error message for this:
> function foo() { 'use strict'; 042; }
function foo() { 'use strict'; 042; }
                               ^^^

Uncaught SyntaxError: Octal literals are not allowed in strict mode.

0o42 is allowed so I guess that doesn't count as an octal literal :wink:

I looked it up so I'll post it: The spec calls 017 a "LegacyOctalIntegerLiteral" and 0o17 an "OctalIntegerLiteral"

Also: octal integer literals allow separators!!
const oOoOo = 0O0_0_0_0;

Note discrepancy: Node 12 went EOL last April, it's Node 14 that's going EOL this April.

Hmm, so by the same argument made in the notes, TS 5.1 should have a minimum target of node 16 :wink:

My recollection was that I basically said "TS is more conservative than most projects, so people are likely to have hit other things breaking earlier", but, I do think that we should try and not break the previous EOL version when possible because there really always are people stuck just one version behind.
Once Node 14 is EOL, there should truly be no reason to be using Node 12.

Thank you for bring this to the design meeting — I've just updated the PR. 🎉🚀

Just wanted to add that this breaks VS2019 support with a suggested fix to hack in the registry...
https://github.com/microsoft/TypeScript/issues/54686
I have no idea who could update EOL node in VS2019


proportions in Container (Rows and Columns) do not work

Describe the bug
Container proportions for Rows and Columns are not functioning correctly. All the remaining space is left empty, and the children elements do not get the correct size (e.g., 1/3 of the available space), as demonstrated in the attached picture.
Expected Behavior:
Children should occupy the specified proportions of the available space (e.g., 1/3 each or homogeneous).
Actual Behavior:
All remaining space is left empty, and children elements do not occupy the correct size.
Steps to Reproduce

Create a container with Rows or Columns.
Set the proportions="homogeneous" parameter of e.g. Row for the child elements.
Observe the layout in the browser.

Screenshots/Videos

Operating System
Windows, MacOS, Linux
What browsers are you seeing the problem on?
Chrome, Firefox, Safari, Edge, Opera, Internet Explorer
Browser version
No response
What device are you using?
No response
Additional context
No response

For anyone looking into this, they seem to work fine if the component is visible from the start. They don't work, if the component is added at a later stage

Good point! It behaves the same on Safari.

I'm not completely sure what the cause of this bug is, but I think ResizeObservers don't trigger on every change, which can lead to the calculated flex-grows being out-of-date. We've added a workaround with requestAnimationFrame that solves the issue in most cases, but there will almost certainly be cases where this bug still occurs.

I'm closing this, since we haven't seen the issue pop up anymore. Feel free to re-open, should it emerge from the dead


Can't delete weeds

Expected Behavior
Detected weeds get erased from the plant designer.
Actual Behavior
Toast error message:

Chrome console error message:

My FarmBot API Version
I'm using my.farmbot.io with OS version 6.2.0.
This function was working days ago. I tried to relog and restart a couple times.

@AscendFB I am investigating the issue right now.
On first glance, it looks like one of the points you are trying to delete is in use by a sequence.
If that is the case, I will need to update the error message to be more descriptive.
I will take a deeper look now to see if there are any other factors at play.

@AscendFB Please let me know if we need to re-open this issue or not.

 Looks like I selected such a weed point accidentally in a sequence without even knowing.
Thanks for the investigation and the updated error message 👍


Fix support for PowerShell 5.1 on Windows.

This adds support for PowerShell 5.1 on Windows to VIM internals. This means that all a user has to do is set shell=powershell in their startup file and the shell related options get defaulted to work as required.
I have added new default values for shellcmdflag, shellredir and shellpipe, tidied up the internal checks for "sh" like shells on Windows (fixing tempname() and executable() behaviour) and extended shellescape() to use PowerShell's method for embedding single quotes.
This is only for PowerShell 5.1/.NET as installed as standard on Windows machines, I have not yet looked at PowerShell Core and what that needs on linux.  I'd like to know I am on the right path before I start adding support for that.
This change may cause problems for existing VIM scripts/plugins that have tried to implement support for PowerShell coping with Vim's existing behaviour when shell is set to powershell.  Hopefully it should be possible for them to remove all their workarounds and shell use to just work.

Isn't it better to check "pwsh" to support PowerShell 6.0 or later?

Support for PowerShell Core (6.0 and later) is next. I just wanted to see if I was on the right track for my changes to Vim. PowerShell Core will complicate the code due to needing linux support as well.

Mike Williams wrote:
[...]

And why is the popup filter test failing? It seems to vary by build
and run.

That test is flaky on some systems.  Unfortunately I haven't been able
to figure out how to avoid the flakiness.  I can't even reproduce it.
--
Bumper sticker: Honk if you love peace and quiet.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Can I assume the Test_out_cb() failure on macos is another flaky test?

Yes, the same test passes on other systems.