You don't have an app that can do this

Steps to reproduce
add latest version of package
try to launch a url and then run that in a TV Box
Expected results
I expect to open it in default browser of my TV Box
Actual results
The result I got when get canLaunch method result it is true but when called launchUrl a toast come up that you don't have an app that can do this
Code sample
Code sample
[Paste your code here]

launchUrl(Uri.parse("https://www.google.com"));

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
D/AudioTrack(11512): getTimestamp_l(52): stale timestamp time corrected, currentTimeNanos:<PHONE_NUMBER>761 < limitNs:<PHONE_NUMBER>482 < mStartNs:<PHONE_NUMBER>482
W/AudioTrack(11512): getTimestamp_l(52): retrograde timestamp time corrected,<PHONE_NUMBER>482 <<PHONE_NUMBER>191
I/UrlLauncher(11512): component name for https://www.google.com is {com.google.android.tv.frameworkpackagestubs/com.google.android.tv.frameworkpackagestubs.Stubs$BrowserStub}
Flutter Doctor output
Doctor output
[Paste your output here]

Hi @MohammadAsefPoya
Does it work with LaunchMode.externalApplication mode? Can you share the entire output log here? [^1]
Please also provide flutter doctor -v output that contains info about your TV device (OS version).
[^1]: The output may be too large to be uploaded to GitHub, you may upload it as a txt file or use online tools like https://pastebin.com/ to share it.

Unfortunately no it is not working, that is the only log that I got there is no other logs
Flutter doctor reslut :
C:\Users\My PC>flutter doctor -v
[√] Flutter (Channel stable, 3.24.1, on Microsoft Windows [Version 10.0.19044.5131], locale en-US)
• Flutter version 3.24.1 on channel stable at D:\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5874a72aa4 (3 months ago), 2024-08-20 16:46:00 -0500
• Engine revision c9b9d5780d
• Dart version 3.5.1
• DevTools version 2.37.2
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at C:\Users\My PC\AppData\Local\Android\sdk
• Platform android-35, build-tools 35.0.0
• Java binary at: D:\Android Studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[X] Visual Studio - develop Windows apps
X Visual Studio not installed; this is necessary to develop Windows apps.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2024.1)
• Android Studio at D:\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
[√] Connected device (4 available)
• MiTV AFKR0 (mobile) • <IP_ADDRESS>:5555 • android-arm    • Android 11 (API 30)
• Windows (desktop)   • windows              • windows-x64    • Microsoft Windows [Version 10.0.19044.5131]
• Chrome (web)        • chrome               • web-javascript • Google Chrome 131.0.6778.70
• Edge (web)          • edge                 • web-javascript • Microsoft Edge 130.0.2849.56
[√] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
Device Type : Xiaomi TV Box S 2nd Gen

Can you try running this Android native sample code on your TV? It simply runs an intent:
startActivity(Intent(Intent.ACTION_VIEW, Uri.parse("https://www.google.com")))

what is that for ?

That aims to narrow down the scope of the issue. If it also occurs on Android native app, it could be a device issue. Otherwise, it could be an issue with Flutter package that needs to be investigated further.

launchUrl is behaving correctly here; your registered handler for web URLs is an application called BrowserStub that apparently exists to display that "You don't have an app that can do this" message, so when the plugin passes the URL to the OS for handling, that's the result. That's the OS behavior, not the plugin.
canLaunchUrl is technically behaving correctly because there is a registered handler. However, we already have special handling for one false-positive, and we could consider adding this to that as a second special case. Routing to the Android team to decide whether we want to include that special case, or close this as behaving correctly.

From android triage: Marked as a p3 @MohammadAsefPoya if you want to author a pull request that follows the existing special handling flow for browser stub package, then we would accept that pull request.

Yes I would like to be an author so once I find some solution for this I can add a pull request to solve issue completely Thanks in advance

finally found the issue this is the log

finally found the issue this is the log
I/UrlLauncher( 5818): component name for https://movie.af is {com.google.android.tv.frameworkpackagestubs/com.google.android.tv.frameworkpackagestubs.Stubs$BrowserStub}

Yes, please see my previous comment, which is based on that log line.

Yes, Thanks for the effort. for now I will close this issue


[Announcements] Full release

Hit the subscribe button on the right of this issue if you wish to be notified of the full release.

We now have a project page with the paper and video: https://lamar.ethz.ch/
If you are attending ECCV next week, consider joining our tutorial on Monday to learn everything about LaMAR! https://lamar.ethz.ch/tutorial-eccv2022/

The raw data, which includes the depth maps, has now been released (https://github.com/microsoft/lamar-benchmark/commit/cd182f1a29dbcea80b3e3286b68aa7ab843d52c7) and can be accessed at the same link as previously or by filling in the form linked on our website. Feel free to open a new issue in case you face trouble using the data.


Coalesce.Type() needs to handle type types.Null

Coalesce.Type() only checks if its arguments to have type nil. But NULL constants have type types.Null, and we need to check for that too.

I can't review Golang code. @zachmu or @fulghum ?


Cannot compile for Ubuntu 22.04.2 LTS

Hi, I was trying to compile this on Ubuntu 22.04 and I cannot figure out why it does not find the wayland-client package. I have already tried to install the following packages:

libwayland-dev
libwayland-client++0
libwayland-client0
libwayland-client-extra++0
libegl-dev
libtls-dev

Here is the output log:
The Meson build system
Version: 0.61.2
Source dir: /usr/src/waynergy
Build dir: /usr/src/waynergy/build
Build type: native build
Project name: waynergy
Project version: 0.0.15
C compiler for the host machine: cc (gcc 11.3.0 "cc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0")
C linker for the host machine: cc ld.bfd 2.38
Host machine cpu family: x86_64
Host machine cpu: x86_64
Did not find pkg-config by name 'pkg-config'
Found Pkg-config: NO
Found CMake: /usr/bin/cmake (3.22.1)
Run-time dependency wayland-client found: NO (tried cmake)

meson.build:26:0: ERROR: Pkg-config binary for machine 1 not found. Giving up.

A full log can be found at /usr/src/waynergy/build/meson-logs/meson-log.txt

/usr/src/waynergy/build/meson-logs/meson-log.txt:
Build started at 2023-04-06T17:39:25.059950
Main binary: /usr/bin/python3
Build Options:
Python system: Linux
The Meson build system
Version: 0.61.2
Source dir: /usr/src/waynergy
Build dir: /usr/src/waynergy/build
Build type: native build
Project name: waynergy
Project version: 0.0.15
Sanity testing C compiler: cc
Is cross compiler: False.
Sanity check compiler command line: cc sanitycheckc.c -o sanitycheckc.exe -D_FILE_OFFSET_BITS=64
Sanity check compile stdout:

-----
Sanity check compile stderr:

-----
Running test binary command: /usr/src/waynergy/build/meson-private/sanitycheckc.exe
C compiler for the host machine: cc (gcc 11.3.0 "cc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0")
C linker for the host machine: cc ld.bfd 2.38
Sanity testing C compiler: cc
Is cross compiler: False.
Sanity check compiler command line: cc sanitycheckc.c -o sanitycheckc.exe -D_FILE_OFFSET_BITS=64
Sanity check compile stdout:

-----
Sanity check compile stderr:

-----
Running test binary command: /usr/src/waynergy/build/meson-private/sanitycheckc.exe
C compiler for the build machine: cc (gcc 11.3.0 "cc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0")
C linker for the build machine: cc ld.bfd 2.38
Build machine cpu family: x86_64
Build machine cpu: x86_64
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64
Pkg-config binary for 1 is not cached.
Pkg-config binary missing from cross or native file, or env var undefined.
Trying a default Pkg-config fallback at pkg-config
Did not find pkg-config by name 'pkg-config'
Found Pkg-config: NO
Pkg-config binary for machine 1 not found. Giving up.
CMake binary for 1 is not cached
CMake binary missing from cross or native file, or env var undefined.
Trying a default CMake fallback at cmake
Found CMake: /usr/bin/cmake (3.22.1)
Extracting basic cmake information
CMake Toolchain: Calling CMake once to generate the compiler state
Calling CMake (['/usr/bin/cmake']) in /usr/src/waynergy/build/meson-private/__CMake_compiler_info__ with:
  - "--trace-expand"
  - "--trace-format=json-v1"
  - "--no-warn-unused-cli"
  - "--trace-redirect=cmake_trace.txt"
  - "-G"
  - "Ninja"
  - "-DCMAKE_TOOLCHAIN_FILE=/usr/src/waynergy/build/meson-private/__CMake_compiler_info__/CMakeMesonTempToolchainFile.cmake"
  - "."
Try CMake generator: auto
Calling CMake (['/usr/bin/cmake']) in /usr/src/waynergy/build/meson-private/cmake_wayland-client with:
  - "--trace-expand"
  - "--trace-format=json-v1"
  - "--no-warn-unused-cli"
  - "--trace-redirect=cmake_trace.txt"
  - "-DCMAKE_TOOLCHAIN_FILE=/usr/src/waynergy/build/meson-private/cmake_wayland-client/CMakeMesonToolchainFile.cmake"
  - "."
  -- Module search paths:    ['/', '/opt', '/usr', '/usr/local']
  -- CMake root:             /usr/share/cmake-3.22
  -- CMake architectures:    ['i386-linux-gnu', 'x86_64-linux-gnu']
  -- CMake lib search paths: ['lib', 'lib32', 'lib64', 'libx32', 'share', 'lib/i386-linux-gnu', 'lib/x86_64-linux-gnu']
Preliminary CMake check failed. Aborting.
Run-time dependency wayland-client found: NO (tried cmake)

meson.build:26:0: ERROR: Pkg-config binary for machine 1 not found. Giving up.

It looks like pkgconf is missing.

Nice, that was it! Thanks!


showing push error

Android Code:
final Map<String, Object> params = new HashMap<>();
params.put("message", message);
params.put("userId", ParseUser.getCurrentUser().getObjectId());
ParseCloud.callFunctionInBackground("sendPush", params,
        new FunctionCallback<String>() {
            @Override
            public void done(String result, com.parse.ParseException e) {
                // TODO Auto-generated method stub

                if (e == null) {
                    Toast.makeText(context, "HEHE", Toast.LENGTH_SHORT)
                            .show();
                    Log.d("ANNOUNCEMENT", "SUCCESS");
                } else {
                    Toast.makeText(context, "FAilure " + e.toString(),
                            Toast.LENGTH_SHORT).show();

                    Log.d("ANNOUNCEMENT", "FAILURE" + e.toString());
                }
            }
        });

///////////////////////////////////////////////
main.js
Parse.Cloud.define("sendPush", function(request, response) {
var sendUserId = request.params.userId;
var msg = request.params.message;
var query = new Parse.Query(Parse.Installation);
query.equalTo('userId', sendUserId);
Parse.Push.send({
        where: query,
        data: {
                alert: msg,
                sound: 'default'
        }
}, {
        success: function() {
                // Push was successful
                response.success("Push sent");
        },
        error: function(error) {
                // Handle error
                response.error(error);
        },
        useMasterKey: true
});

});
But not getting push
Here is the verbose //////
verbose: sending push to 1 installations
verbose: sent push! 0 success, 0 failures

What adapter are you using? Which devices are you sending to? Android, iOS? Can you get the _PushStatus object?

I am using parse push adapter; sending to android devices
_PushStatus
{
"_id" : ObjectId("5704f607c87f874d22157520"),
"objectId" : "AJDiHp7HRu",
"pushTime" : "2016-04-06T11:41:59.478Z",
"_created_at" : ISODate("2016-04-06T11:41:59.478+0000"),
"query" : "{"objectId":"rJvrh1s0BH"}",
"payload" : {
"alert" : "4",
"sound" : "default"
},
"source" : "rest",
"title" : null,
"expiry" : null,
"status" : "succeeded",
"numSent" : NumberInt(0),
"pushHash" : "01538e1dfb45c0adc1c4bd63365cf403",
"_wperm" : [
],
"_rperm" : [

],
"numFailed" : NumberInt(0)

}

I'll have a look

2.2.6

thanks

When running with VERBOSE=1, you should have that kind of logs:
verb parse-server-push-adapter GCM sending to 1 device
verb parse-server-push-adapter GCM GCM Response: {
verb parse-server-push-adapter GCM     "multicast_id":<PHONE_NUMBER>291095000,
verb parse-server-push-adapter GCM     "success": 0,
verb parse-server-push-adapter GCM     "failure": 1,
verb parse-server-push-adapter GCM     "canonical_ids": 0,
verb parse-server-push-adapter GCM     "results": [
verb parse-server-push-adapter GCM         {
verb parse-server-push-adapter GCM             "error": "InvalidRegistration"
verb parse-server-push-adapter GCM         }
verb parse-server-push-adapter GCM     ]
verb parse-server-push-adapter GCM }

Can you please provide them?

verbose: POST /parse/push { 'user-agent': 'node-XMLHttpRequest, Parse/js1.8.1 (NodeJS 5.3.0)',
accept: '/',
'content-type': 'text/plain',
host: '<IP_ADDRESS>:1337',
'content-length': '278',
connection: 'close' } {
"where": {
"objectId": "KQPONXtIjb"
},
"data": {
"alert": "Hello",
"sound": "default"
}
}
verbose: {
"response": {
"result": true
}
}
success
verbose: {
"response": {
"result": "Push sent "
}
}
verbose: sending push to 1 installations
verbose: sent push! 0 success, 0 failures

Seems to be a misconfiguration in parse-server-push adapter, how did you set it up?

i have set it up in index.js

Would you care to show it?

what's the version of parse-server-push-adapter? in node_modules/parse-server-push-adapter/package.json

1.0.4

Is latest ',' in emailAdapter-apiKey line relate this bug?
options : {
    ....
    apiKey: 'YOUR_KEY' ,
}

@estylehq elborate please

updated.

means in my index file i have remove the comma that i have instered at the end of the email adapter

yeah. and end of push configuration too.

var api = new ParseServer({
databaseURI: databaseUri || 'mongodb://myadreees:27017/test',
cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
appId: process.env.APP_ID ||'apkeykey',
masterKey: process.env.MASTER_KEY || 'master', //Add your master key here. Keep it secret!
serverURL: process.env.SERVER_URL || 'http://myadreees/parse',  // Don't forget to change to https if needed
verifyUserEmails:true,
publicServerURL:'http://myadreees:1337/parse',
appName: 'Trakie',
emailAdapter:{
module: 'parse-server-simple-mailgun-adapter',
options:{
fromAddress:'',
domain:'',
apiKey:'',}},
push: {
android: {
senderId:'',
apiKey:''
}
},
});
/??//// is this correct

remove comma end of push.

var api = new ParseServer({
databaseURI: databaseUri || 'mongodb://myadreees:27017/test',
cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
appId: process.env.APP_ID ||'apkeykey',
masterKey: process.env.MASTER_KEY || 'master', //Add your master key here. Keep it secret!
serverURL: process.env.SERVER_URL || 'http://myadreees/parse',  // Don't forget to change to https if needed
verifyUserEmails:true,
publicServerURL:'http://myadreees:1337/parse',
appName: 'Trakie',
emailAdapter:{
module: 'parse-server-simple-mailgun-adapter',
options:{
fromAddress:'',
domain:'',
apiKey:'',}},
push: {
android: {
senderId:'',
apiKey:''
}
}
});

Updated index.js but the error is still same

can you please format correctly your index.js configuration? It's impossible to see where your error is.... Also we have many users having a functional push setup.

i have reformated the code of index.js and can you tell me that if want to send push to a specfic user using the object id of that users

That question should be asked over stackoverlow, or any other forum. We're not here to provide support for your implementations.

ok will the client push enable in future use

I don't believe it will ever be enable as this is a very important security problem. Also, many users have worked around it by creating a cloud code function. Look through the issues, and other references, and you should be good to go.
Coming back to your issue, can we have a properly formatted index.js?

yes i have formatted it here it is
var api = new ParseServer({
databaseURI: databaseUri || 'mongodb',
cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
appId: process.env.APP_ID ||'',
masterKey: process.env.MASTER_KEY || '', //Add your master key here. Keep it secret!
serverURL: process.env.SERVER_URL || 'http',  // Don't forget to change to https if needed
verifyUserEmails:true,
publicServerURL:'http:',
appName: 'Trakie',
emailAdapter:{
module: 'parse-server-simple-mailgun-adapter',
options:{
<EMAIL_ADDRESS>domain:'.mailgun.org',
apiKey:'key-',}},
push: {
android: {
senderId:'',
apiKey:''
}
}
});

this is not formatted....
formatted is:
var api = new ParseServer({
  databaseURI: databaseUri || 'mongodb',
  emailAdapter:{
    module: 'parse-server-simple-mailgun-adapter',
    options:{
<EMAIL_ADDRESS>      domain:'.mailgun.org',
      apiKey:'key-'
    }
  }
})

then  what about push notification

what do you mean?

in index,js we have to declare both push adapter , email adapter and server info(master key,app id,mongo db connection string) then the formateed code that have been provided in that where i would add push adapter

this was just an example, to show you how to properly format the code when you share it. Your shared file appear all flat, with multiple } on certain lines... I can't really say what's wrong in your configuration because it's just plain ugly and not readable

i have checked everything again but the problem is steill there
here is my main,js file
Parse.Cloud.define("sendPush2", function(request, response) {
var sendUserId = request.params.userId;
    var msg = request.params.message;

var query = new Parse.Query(Parse.User);
query.equalTo("ObjectId", id);
    Parse.Push.send({
       where : query,
            data: {

                    alert: "msg"

            }
    }, {

useMasterKey:true,
success: function() {
// Push was successful
console.log("success");
response.success("Push sent ");
},
error: function(error) {
// Handle error
console.log("failed");
response.error(error);
}
    });

});

the query on push should be on installations not on users... That's why you're not getting anything...


Tapping on menu drop-down selects button on HTML page underneath it

Description
The materialize code was added to an HTML/CSS/JS project, Cordova produced an Xcode file, then Xcode installed it on my iPod touch. When I tap on long navbar drop-down menu in the upper right, it drops down to show the various options. If an option is covering a button on the page, then sometimes tapping the option selects the underlying button instead. If an option is covering a collapsible accordion button, then sometimes the accordion opens instead of the option executing. This only occurs on my iPod touch, not my desktop or Android devices. I am NOT accidentally touching the button underneath.
Repro Steps
Layout the steps to reproduce your issue.

In HTML page, in head tags, add scripts for jquery-3.1.0.min.js, materialize.js, materialize.min.css.
In body, put < ul id="dropdown1" class="dropdown-content"> then list the options as normal list items, like: < li>< a href="pages/features.html">Features< /a>< /li>
In body, add clickable content in upper right where the menu options could open.
Make an Xcode project of it, such as through Cordova CLI, install it in an iOS device, tap on Menu, then tap on an option that is over a tappable element underneath.

Use this Codepen to demonstrate your issue. http://codepen.io/Dogfalo/pen/xbzPQV
This will not demo the issue. It only appears in an iOS device. Works great on desktop.
Screenshots / Codepen
Add supplemental screenshots or code examples. Look for a codepen template in our Contributing Guidelines.
This issue cannot be shown via screenshots. It won't show tapping of option, for instance, but merely show the option names.

+1
This can also be reproduced by launching device toolbar in Google Chrome. Looks like this got broken in 0.98.0, worked just fine before that. Coding Microsoft style, eh?

In addition, it appears that you have to click/tap on the text of the option. Tapping the blank spot to its right selects anything underneath the option, or nothing. Does the  need CSS of block, I wonder?

Looks like the bug I talk about here : https://github.com/Dogfalo/materialize/issues/3883

Duplicate of #3883. Thanks @gnicol-bzh

Closed and unresolved.

OK guys, here is the fix, pretty complex stuff lol
https://pastebin.com/GKix4xbm


The policy name in the AuthorizeAttribute is not being passed to the GetPolicyAsync method of IAuthorizationPolicyProvider.

Product
Hot Chocolate
Version
14.1.0
Link to minimal reproduction
https://github.com/ChilliCream/graphql-platform/blob/main/src/HotChocolate/Core/src/Authorization/AuthorizeAttribute.cs
Steps to reproduce
IAuthorizationPolicyProvider interface needs to implement three methods:
GetPolicyAsync
GetDefaultPolicyAsync
GetFallbackPolicyAsync
When using the AuthorizeAttribute in Chocolate and setting a Policy, then making requests through Postman, the policy is only passed to GetPolicyAsync during the first query. For subsequent queries, the policy is no longer passed to GetPolicyAsync.
This behavior is different from what occurs in Chocolate version 13, and the issue arises in Chocolate version 14.1.0.
What is expected?
Every time a query is made, the policy will be passed to GetPolicyAsync.
What is actually happening?
The policy is only passed to GetPolicyAsync during the first query. For subsequent queries, the policy is no longer passed to GetPolicyAsync.
Relevant log output

Additional context
No response

I'm sorry, this was introduced by a change I did in #7408. I've just corrected it in #7705.
I'll see to it getting back-ported to 14.2.0.


Select first suggestion when pressing Enter

please complete the following information:

OS version: macOS Monterey 12.1
Editor version: 1.58.0
Programming language: python
TabNine extension version: 40.7

If the issue is related to TabNine failure, please provide log files:
Type TabNine::config in your editor, the logs are located at the bottom of the page.
Issue Details:
When pressing Enter in editor for new line, it automatically selects the first suggestion instead.
gz#10176

Hi @emmadebarros
Thanks for reaching out!
Can you please share a video of what you're experiencing?


Add AF_VSOCK support

"The VSOCK address family facilitates communication between virtual machines and the host they are running on.  This address family is used by guest agents and hypervisor services that need a communications channel that is in‐dependent of virtual machine network configuration." (vsock(7))
It is currently Linux-only here, but it should also be available for other systems, Windows and BSD in particular.

Running the tests in CI seems problematic. Should we mark it ignored?

Running the tests in CI seems problematic. Should we mark it ignored?

Running the tests in CI seems problematic. Should we mark it ignored?

Yes, but please clearly describe what is required to run the test in the ignore reason, e.g. https://github.com/rust-lang/socket2/blob/4130e75c6cb36041839991a26b22c5145cc19d15/tests/socket.rs#L701.

Running the tests in CI seems problematic. Should we mark it ignored?

Yes, but please clearly describe what is required to run the test in the ignore reason, e.g. https://github.com/rust-lang/socket2/blob/4130e75c6cb36041839991a26b22c5145cc19d15/tests/socket.rs#L701.

Thanks @elmarco.

Thanks @elmarco.

yw, thanks!

yw, thanks!


[CWS] Set working directory to config dir in functional tests

What does this PR do?
Set a valid working directory to run the testsuite.

Motivation
Test could fail with
                TestProcessInterpreter/interpreted_exec-docker
[2024-02-29
 process_test.go:2112: could not run /tmp/interpretedExec.sh: exit status 127
 process_test.go:2114: shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
 Executing echo insIDe a bash script
 /tmp/interpretedExec.sh: line 5: pyscript.py: No such file or directory
 Back to bash
 chmod: cannot access ‘pyscript.py’: No such file or directory
 /tmp/interpretedExec.sh: line 15: ./pyscript.py: No such file or directory

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Fix encrypted dataset restore and make backup cron setting optional

As stated in the docs, the cron config should be optional. When not providing a cron config, it was crashing on backup as its dereferenced in the add_job call.

The tool was correctly using the raw method to upload the send binary but on receive / restore, it was first creating a datastore and then forcing a rewrite with the -F flag. This poses a problem on encrypted datasets as you can't restore with -F. See https://github.com/openzfs/zfs/issues/6793 for more information. This change removes the -F but also does not create the dataset, which should be fine as receive would do that anyways. Tested on encrypted datasets and now its working

I can try to add the test for the encrypted case, but this is basically the workflow:
zfs create -o encryption=on -o keylocation=prompt -o keyformat=passphrase ztest/sourceenc
touch /ztest/sourceenc/file

In the config, set this up:
[ztest/sourceenc]
max_snapshots = 7
max_incremental_backups_per_full = 6
max_backups = 7

zfsup backup
zfsup restore ztest/sourceenc --destination ztest/destenc (this datastore does not exist)

result:

root@rover:/etc/zfs_uploader# zfsup restore ztest/sourceenc --destination ztest/destenc
time=2023-01-18T04:25:48.286 level=INFO file_path=config.cfg msg="Loading configuration file."
time=2023-01-18T04:25:48.772 level=INFO filesystem=ztest/destenc snapshot_name=20230118_042500 s3_key=ztest/sourceenc/20230118_042500.full msg="Restoring snapshot."
Traceback (most recent call last):
  File "/usr/local/sbin/zfsup", line 8, in <module>
    sys.exit(cli())
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/zfs_uploader/__main__.py", line 135, in restore
    job.restore(backup_time, destination)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/zfs_uploader/job.py", line 265, in restore
    self._restore_snapshot(backup, filesystem)
  File "/etc/zfs_uploader/env/lib/python3.10/site-packages/zfs_uploader/job.py", line 413, in _restore_snapshot
    raise ZFSError(stderr)
zfs_uploader.zfs.ZFSError: cannot receive new filesystem stream: zfs receive -F cannot be used to destroy an encrypted filesystem or overwrite an unencrypted one with an encrypted one

@rdelcorro Could you merge in master? The zfs receive -F issues should be resolved now.

@ddebeau code is now merged. Thanks!

Corrected the comments. Feel free to merge when possible. I do not seem to have the ability to do so. Do you know why tests are failing?

I don't think your PR has access to the secrets required to run the tests. I'll run the tests before I make a release. Thank you for your help!

@rdelcorro Just made the release:
https://github.com/ddebeau/zfs_uploader/releases/tag/0.8.1

Thanks, I will test it out


PokeStops aren't displaying on the map

Map displays Pokemons and Gyms, but not PokeStops. I know it should, cause I used no-exe python version before and there is an argument for that. -dp if I remember this correctly.

New update you can toggle it now.


How to process.env.PWD

Hi, do you know how i suppose to use Node.js process.env.PWD variable? Cant find it inside process.env :(

process.env.PWD is present in compiled application. Please check again.


Fix link to Mostly Adequate Guide to FP

Hey @mr-mig
just fixing a link.
Cheers!

Hey @mr-mig
just fixing a link.
Cheers!

https://vuuzletvph.com/heads-up-vuco-bounty-programs-are-coming-your-way/

Yes, yes this link has expired. I confirm. Peace ❤

https://vuuzletvph.com/heads-up-vuco-bounty-programs-are-coming-your-way/


[Question]How to join a krustlet node into self-built k8s cluster rather than KinD,Minikube,GKE etc?

😊Hi, New to krustlet.A small noob question. I didn't find how to join a krustlet node into self-built k8s cluster(like 3 nodes in normal) in quickstart tutorial https://github.com/deislabs/krustlet/blob/main/docs/intro/quickstart.md,not Kind or MicroK8s or minikube or GKE etc. I try to follow the https://github.com/deislabs/krustlet/blob/main/docs/howto/bootstrapping.md. But the bootrstrap.sh has kubectl command,so it has to run on master node then can create the config.I don't understand why to run command KUBECONFIG=~/.krustlet/config/kubeconfig krustlet-wasi --port 3000 --bootstrap-file /path/to/your/bootstrap.conf on master node..it should run on another node who wants to join the cluster, isn't it? But I have errors to run this command on a node that wants to join the cluster using krustlet. Is there a way like kubeadm join --token as kubelet to join the cluster?Please correct me if my saying has wrong and how to build a krustlet node to join a self-built k8s cluster.

Hey @JesseStutler!
For the most part, the HOWTO guides provide the same set of instructions:

Get a bootstrap config
Determine the default network gateway
Install and run Krustlet
Approve the Certificate

The same set of instructions should be the same on a self-built kubernetes cluster.
As to your specific questions:

But the bootrstrap.sh has kubectl command,so it has to run on master node

I don't understand why to run command KUBECONFIG=~/.krustlet/config/kubeconfig krustlet-wasi --port 3000 --bootstrap-file /path/to/your/bootstrap.conf on master node..it should run on another node who wants to join the cluster, isn't it?

You run that command wherever you wish to run a new Node.
I don't see where the documentation describes that you need to run those commands on a master node. kubectl does not require you to be on the same node as the master. As long as you have a valid kubeconfig  you should be able to run that anywhere.
Can you please help point where it is required to run kubectl on the master node, or clarify where you're getting confused?

But I have errors to run this command on a node that wants to join the cluster using krustlet.

Would you mind sharing those error messages with us?
Do keep in mind the following from the bootstrap documentation:

Initialization
Krustlet follows the same initialization flow as Kubelet (with the exception of automatic renewal of certs that are close to expiry).

Instructions
In order to join a cluster with the proper permissions, Krustlet requires a valid bootstrap config with a valid bootstrap token. This token can be generated with kubeadm or may already exist depending on your provider. However, in this case, we will be using an easier method for creating a join token. Either way, the examples here should be useful for figuring out how to do it differently depending on your setup.

Can you please help point where it is required to run kubectl on the master node, or clarify where you're getting confused?

Uh....Thanks for your kind sharing. It's my problem....I always use kubectl to run on the master node, never try to use it on worker node....Therfore it gives me illusion that kubectl only can be run on master node😅. After your saying, sure it theoretically can on worker node if it has kubeconfig. I will try to configure it out and if I still have questions I will feed back. Thanks.

It does work.Thanks.Close now.

@JesseStutler @bacongobbler  Hello! Can you share a bit more about how you join a krustlet node to the cluster? I followed this but do you mean all three steps 1) ./scripts/bootstrap.sh 2)   KUBECONFIG=~/.krustlet/config/kubeconfig krustlet-wasi --port 3000 --bootstrap-file /path/to/your/bootstrap.conf 3) kubectl certificate approve <hostname>-tls should all run on a worker node?? But how can kubectl talks to a node that is master (this node is not even in the cluster) So I doing kubectl on a new node does not make sense to me, also error The connection to the server localhost:8080 was refused - did you specify the right host or port?


How can i share builded .net core project between many jobs in Azure pipelines?

I have 2 jobs. First, to restore, test, build and share build files in a build artifact. Second to pack and push nuget packages. First job finished their job with success, but second job failed during pack task. It have a problem with nuget packages, for example:
/usr/share/dotnet/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(234,5): error NETSDK1064: Package Microsoft.CSharp, version 4.6.0 was not found. It might have been deleted since NuGet restore. Otherwise, NuGet restore might have only partially completed, which might have been due to maximum path length restrictions. [/home/vsts/work/1/s/src/Spotio.Leads.Client/Spotio.Leads.Client.csproj]
https://stackoverflow.com/questions/59171421/how-can-i-share-builded-net-core-project-between-many-jobs-in-azure-pipelines

Are you using different agents (or cleaning agent workspaces) when running these stages? I suspect that if you use, for example, hosted agents, then you may have to re-run again the NuGet package restore before running the dotnet pack command.


(DO NOT MERGE)(CLOUD-184, CLOUD-205) Make the region param and ENV var interchangable

(Note that I've put this up just applying to security groups so as to get feedback on whether we should do some/all/none this as much as the implementation)
This allows for creating and deleting resources from puppet resource by
passing the environment variable (which is already used for scoping).
Prior to this change you would have to pass the information twice. If
you do pass both we maintain the same approach as previous, giving the
param a higher precedence.
This also allows for not specifying the region in the DSL, and instead
using the AWS_REGION variable. This matches the standard behaviour of
other AWS tools, and means in the case of not providing anything the
correct error bubbles through.

Agreed. I'm unsure about this too.
I'm tempted to say if the env variable ever doesn't match the region value of a type we fail in the type validation. That blocks the entire run. Thoughts?
I think we should do that whether we merge this PR or not.

Yes @garethr I was talking with @cmurphy and this seems like a tough nut to crack.  At first I suggested that we could use apply a rule that AWS_REGION env var takes over everything... but that's not a very good idea.
So your suggestion is to blow up the run when the resource defined in the manifest has a region that doesn't match the env var?  I think that's probably a good thing to do...

@Iristyle yup. I like the filtering ability. It's a great performance optimisation, and it would allow for scaling out by region if you had lots of ec2 resources. But that power comes with complexity that I don't like.
If we stop the run at compile time if any resource has a region that doesn't match the ENV then I think it's much safer. It means we never hit issues like the one you describe. We also catch issues we're you forget you have the ENV set.

@Iristyle @cmurphy I've changed this as discussed. Let me know if this works for you and I'll expand to the other relevant types.

I've extracted the region type and made a separate PR for just the blocking behaviour https://github.com/puppetlabs/puppetlabs-aws/pull/132

I'm going to close this.  It's hopefully useful as and when the core issue gets some time.


fixe bug for input line below the Original line

 sentence.insertAdjacentHTML(           "beforeend",           '
Translation'         );

https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentHTML

this is a very good practice of using insetAdjacentHTML in different positions.
Here is a relevant recourse: https://www.w3schools.com/jsref/met_node_insertadjacenthtml.asp


There is no document formatter for 'html'-files installed

Version: 1.27.0-insider (user setup)
Commit: 98c83caea995f152003c264658c33186d164dfa8
Date: 2018-08-30T05:19:32.583Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
When trying to format a HTML document. it get the following message:

There is no document formatter for 'html'-files installed

UserSettings.json
{
    "editor.formatOnType": true,
    "editor.formatOnPaste": true,
    "editor.wordWrap": "on",
    "terminal.integrated.shell.windows": "C:\\Windows\\sysnative\\WindowsPowerShell\\v1.0\\powershell.exe",
    "window.zoomLevel": 0,
    "git.ignoreMissingGitWarning": true,
    "editor.fontSize": 12
}

WorkspaceSettings.json
{
	"folders": [
		{
			"path": "s:\\Prod"
		},
		{
			"path": "s:\\Test\\Brecht"
		},
		{
			"path": "c:\\Program Files\\WindowsPowerShell\\Modules"
		}
	],
	"settings": {
		"liveServer.settings.multiRootWorkspaceName": "Brecht"
	}
}

Default user settings says:
// Enable/disable default HTML formatter.
  "html.format.enable": true,

Can you set "html.trace.server": "verbose" and open the 'HTML Language Server' output tab and look our for the following info:
[Trace - 2:43:57 PM] Received request 'client/registerCapability - (1)'.
Params: {
    "registrations": [
        {
            "id": "f99847f6-39fe-4660-adfd-bf65f86290ea",
            "method": "textDocument/rangeFormatting",
            "registerOptions": {
                "documentSelector": [
                    {
                        "language": "html"
                    },
                    {
                        "language": "handlebars"
                    }
                ]
            }
        }
    ]
}

Also try to run without extensions.

Thank you for the help. A bit stuck here, can you tell me how to open the 'HTML Language Server' output tab?

When I go to the HTML document. go to the bottom and select the tab Output with HTML Language Server, and then ask in the palette to Format document nothing is displayed in the Output tab and the pop There is no document formatter for 'html'-files installed appears..

Had to restart, here is what I got:
[Trace - 2:55:10 PM] Received request 'client/registerCapability - (0)'.
Params: {
    "registrations": [
        {
            "id": "2e0da313-e708-4d12-9682-f6aac75feed3",
            "method": "workspace/didChangeWorkspaceFolders",
            "registerOptions": {}
        }
    ]
}

[Trace - 2:55:10 PM] Sending response 'client/registerCapability - (0)'. Processing request took 0ms
No result returned.

[Trace - 2:55:10 PM] Received request 'client/registerCapability - (1)'.
Params: {
    "registrations": [
        {
            "id": "423625c6-a993-45a5-92d9-a0fe28c2dab6",
            "method": "textDocument/rangeFormatting",
            "registerOptions": {
                "documentSelector": [
                    {
                        "language": "html"
                    },
                    {
                        "language": "handlebars"
                    }
                ]
            }
        }
    ]
}

[Trace - 2:55:10 PM] Sending response 'client/registerCapability - (1)'. Processing request took 0ms
No result returned.

@jrieken This is a mystery bug that pops up every month or two. The formatter is is very likely correctly registered, but can not be found by the action

@DarkLite1 If you have time and are familiar with the dev tools: This would help getting to the core of it:

open the dev tools (Developer: Toggle Developer Tools)
in the source tab, press Ctrl + P and select 'format.ts`

set a breakpoint on line 34
invoke Format document
breakpoint should be reached

look at the values of providers (Probably empty in your case) and DocumentRangeFormattingEditProviderRegistry
in the hover of DocumentRangeFormattingEditProviderRegistry, move the mouse over _entries, open context meny and run 'Store as global variable`

that prints to the console and it would be good to know how many entries there are.
In my case in get something like that:

@DarkLite1 What kind of file is that? Can you right click its title, select 'Copy Path', and paste the path here? Is this with VS Live Share?

@jrieken  The Path is S:\Test\Brecht\Set permissions\Settings detail.html
@aeschli I needed to restart VS Code for a project here, and then I tried again after a few minutes. Result, now it works. You still want me to do the dev tools test thing?
It's really weird, because I haven't changed anything at all.

@jrieken The Path is S:\Test\Brecht\Set permissions\Settings detail.html. I don't know what VS Live Share is...

Thanks, question answered.

You still want me to do the dev tools test thing?
only when you see the problem... ;-(

Shame, I really wanted to get to the bottom of this. I'll let you know when I have it again and try your steps. Thanks anyhow for the great help, much appreciated.

I had this issue also.
I believe that it happened after I uninstalled the system wide VS Code, after installing the User version.
I fixed it by installing again the user version.

fixed by #71652


AquariusOne: Blacklist this-is-a-test.io

AquariusOne requests the blacklist of the following website(s):

this-is-a-test.io - MS search

this-is-a-test.io has been seen in 0 true positives, 0 false positives, and 0 NAAs.

This was only a test; we don't need to keep this around.


React 16

React 16 is out.
React Server should support it!

PR is submitted here https://github.com/redfin/react-server/pull/965

React 16 support landed in<EMAIL_ADDRESS>🎉
Thanks @salehhamadeh!


mvn pacakge fails on java-jaxrs

Not sure how to fix this, it seems to be the dependency problem. See the log below.
Also I found that parent pom oss-parent is no longer supported and there is a warning that latest versions of maven does not work. See this link https://github.com/sonatype/oss-parents
kokhom@840G35CG7154KQ2 MINGW64 ~/projects/swagger-samples/java/java-jaxrs (master)
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean

kokhom@840G35CG7154KQ2 MINGW64 ~/projects/swagger-samples/java/java-jaxrs (master)
$ mvn package
[INFO] Scanning for projects...
Downloading: https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/5/oss-parent-5.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for io.swagger:swagger-samples-project:1.0.0: Could not transfer artifact org.sonatype.oss:oss-parent:pom:5 from/to central (https://repo.maven.apache.org/maven2): Connect to repo.maven.apache.org:443 [repo.maven.apache.org/<IP_ADDRESS>] failed: Connection timed out: connect and 'parent.relativePath' points at wrong local POM @ io.swagger:swagger-samples-project:1.0.0, C:\Users\kokhom\projects\swagger-samples\pom.xml, line 2, column 11
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project io.swagger:swagger-java-sample-app:1.0.0 (C:\Users\kokhom\projects\swagger-samples\java\java-jaxrs\pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for io.swagger:swagger-samples-project:1.0.0: Could not transfer artifact org.sonatype.oss:oss-parent:pom:5 from/to central (https://repo.maven.apache.org/maven2): Connect to repo.maven.apache.org:443 [repo.maven.apache.org/<IP_ADDRESS>] failed: Connection timed out: connect and 'parent.relativePath' points at wrong local POM @ io.swagger:swagger-samples-project:1.0.0, C:\Users\kokhom\projects\swagger-samples\pom.xml, line 2, column 11 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

$ mvn --version
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-04T07:39:06+12:00)
Maven home: C:\Program Files\maven
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_131\jre
Default locale: en_NZ, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

my bad, it is the our proxy that forbids connection


Reduced unnecessary DB queries during init

refs https://github.com/TryGhost/knex-migrator/commit/8d9a561cab0b7b7f5745dd36bcfb7a06568d2311

see referenced commit for context but we were doing unnecessary SELECT
queries when initializing the DB and the commit reduces this by half
this commit updates knex-migrator to that containing the commit

Codecov Report

Merging #13765 (c5ee0c2) into main (80d5f89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13765   +/-   ##
=======================================
  Coverage   56.07%   56.07%
=======================================
  Files         550      550
  Lines       45860    45860
  Branches     4101     4101
=======================================
  Hits        25714    25714
- Misses      20102    20103    +1
+ Partials       44       43    -1

Impacted Files
Coverage Δ

core/shared/config/loader.js
97.36% <0.00%> (ø)

core/shared/settings-cache/cache.js
69.44% <0.00%> (ø)

...ore/frontend/services/routing/helpers/templates.js
68.06% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d5f89...c5ee0c2. Read the comment docs.


[0.45.2] Commits to cherry-pick and use prop-types with React 16 instead

react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.
The issue has been fixed in master. @mojodna has indicated interest in getting this cherry-picked into the 0.45 release. Several issues have been opened that seem to be related to this, enough that I think it's worth cherry picking into 0.45.2.

@mojodna do you have a list of the commits in master that need to be cherry picked into 0.45 in order to fix the issue?
I've also opened #14713 as we'll also need to cherry pick them into the 0.46 RC in order to make sure the stable release doesn't suffer from this next month.

I don't, but I'll go hunting now.

50b11aa09b479e5ce8b06de98e02ba1dd6a8cca3
1f3140c4962fbbf9f3a00f977daa64d2940c0c5b
8e9322c65e751dc8e7512874e03e7c4349a28b93

One extant issue in master is that Text is still implemented with React.createClass (for the mixins functionality, I assume). Without this resolved React Native will error out on any attempt to use Text, so it should probably be considered blocking for 0.45.2.
It seems that 0.45.1 is pretty unusable in the meantime. Is there a recommended workaround, or should everybody downgrade to earlier versions? If we should downgrade, is it worth considering withdrawing the release, considering that it's unusable?

Curiously, there have been folks reporting that they've been experiencing this issue intermittently, and I've noticed that two weeks ago I was able to use react-native<EMAIL_ADDRESS>without issue and now am not. It would seem that<EMAIL_ADDRESS>should never have been usable with any version of React Native (including master which still has extant React.createClass references), but there are folks for whom this has worked. Perhaps it has something to do with how React Native or the packager resolves the 'react' package internally?

@Ashoat generally we recommend that people use the release candidate, in order to surface issues like these before a stable release is cut. Since the createClass issue is still present in master, we just need someone to send a PR to fix it. We're less than a week away from a stable release cut, so ideally this would be done within the next 24 hours so that we can get it into the RC early enough for people to test.

@hramos - believe it or not, I have been using the release candidates! But as mentioned before, these issues only randomly started popping up when I tried updating to RN 0.45.1. I'm really not sure what's going on, and why these errors are only triggered in certain situations.
Regarding the React.createClass issue, it's worth understanding just how many components in React Native are defined this way. This is just the portion in the Libraries/Components folder: https://gist.github.com/Ashoat/b68064b091d6389080acdec6ee1e7bd7
I doubt anybody's going to be able to put up a pull request fixing those within 24 hours, which means people will ostensibly continue seeing this error in 0.45.2. The big question in my mind is: why isn't everybody seeing these errors? Based on the claim in the error, it would seem that nobody should be able to use React Native 0.45 with React 16, but for some reason this issue does not occur in certain situations. For instance, my dev environment has been in a working state ever since I reinstalled<EMAIL_ADDRESS>

#14729 (658c7bb9a63632243d1deebe9a5624e002b99d69) should be cherry-picked into the 0.45 branch prior to 0.45.2 to address the React.createClass deprecation. (@hramos - this should probably be its own issue?)

@Ashoat  "The big question in my mind is: why isn't everybody seeing these errors?"
We are, we're just waiting patiently for fixes so we can upgrade w/o issues :D
I'm still on RN v0.44.3 b/c every attempt to upgrade results in an array of errors which seem to stem from a "catch-22" situation of not having the right version of React in sync with the RN and all the stuff that has been depreciated and/or changed (read: PropTypes etc.).
I for one don't know what to do, I'm still using React v16.0.0-alpha.6, tried updating that when I upgrade RN which is automagic since newer versions of RN require newer alpha versions of React_, but alas, no deal.
It would be great to figure out what are the correct update steps we need to keep our codebases up to date, I'm stuck cherrypicking files directly from master so I can at least get the lastest version of some Components, like SectionList, for example.

I'll be releasing new version later today / tomorrow morning with those fixes cherry-picked.

Where is 0.45.2 available?  I don't see it on npm at the moment.

I don't think it has been released yet. You can see there's no 0.45.2 tag on the repo.

Waiting on https://circleci.com/gh/facebook/react-native/19525

https://github.com/facebook/react-native/commit/e7c1cf5b7d2eba9468804635d0c2a0fc6725e42a  resolves https://github.com/facebook/react-native/issues/14838

cc: @hramos build never made it to npm, I believe we should fix it. Do you think there's someone at Facebook that could assist me in making this on npm?

It did not publish to npm due to tests not being green. This will affect any release cut when tests aren't passing. We'll need to make a decision whether tests failing on Circle should block npm releases or not.
If you want to get this out anyway, I believe commenting out the failing tests out of circle.yml should do the trick.


Fix: Website link needs to be updated

The Website link shared in the Readme File on clicking redirects to a github pages link.

However, since the website is deployed in vercel with the link CluelessVercel the readme file needs to be updated.

On checking the Readme File I discovered that no link is provided in the Readme File.

Although this is a small Readme Fix, I would love to work on it.

Sure, @VividhPandey003 go ahead. Assigning you this issue.

Closing this as this is done.

Hey @Rajdip019 I don't know how. I guess there has been a recent push but the issue is already fixed.😂

So I guess you should close this issue.


Wait GMP deployment rollout before applying KubeRay PodMonitorings

kuberay-operator appears to be deployed faster than the gmp-operator, causing kuberay-monitoring to create a PodMonitorings object before the GMP webhook server is ready to validate it.
With the dependency in place, Terraform waits for the gmp-operator (external data source) to be rolled out prior to deploying gmp-engine:
Plan: 2 to add, 0 to change, 0 to destroy.
module.kuberay-monitoring.null_resource.wait_for_gmp: Creating...
module.kuberay-monitoring.null_resource.wait_for_gmp: Provisioning with 'local-exec'...
module.kuberay-monitoring.null_resource.wait_for_gmp (local-exec): Executing: ["/bin/sh" "-c" "while ! kubectl rollout status -n gke-gmp-system deploy/gmp-operator; do sleep 5; done"]
module.kuberay-monitoring.null_resource.wait_for_gmp (local-exec): deployment "gmp-operator" successfully rolled out
module.kuberay-monitoring.null_resource.wait_for_gmp: Creation complete after 0s [id=6180172337812646967]
module.kuberay-monitoring.helm_release.gmp-engine: Creating...
module.kuberay-monitoring.helm_release.gmp-engine: Creation complete after 6s [id=gmp-engine]

Fixes https://github.com/GoogleCloudPlatform/ai-on-gke/issues/402

/gcbrun

/gcbrun

/gcbrun

/gcbrun

Replaced by https://github.com/GoogleCloudPlatform/ai-on-gke/pull/418


[zh-cn] sync blog 2023-04-20-read-write-once-pod-access-mode-beta.md

sync blog 2023-04-20-read-write-once-pod-access-mode-beta.md
link #40710

/approve


Specify version when building

So our production & sandbox environments are currently on 21.3.51409.51575 - no new versions available yet

I've made some code changes and have done a pull request, which fired off the CI/DI etc.
But it failed with an error - i know what the error is, a field has been added in 21.4 - which we are handling, but as we don't have 21.4 yet can we specify which version the CI/DI works, as its trying to use 21.4

So, now I have an update I can't push via AL-Go, even though I know it will work with the current version.

What is the Application dependency in your app.json file?

I don’t have specific one, is that what I’m missing then?
@.***
From: Freddy Kristiansen @.>
Sent: 07 February 2023 13:52
To: microsoft/AL-Go @.>
Cc: Roland Thompson @.>; Author @.>
Subject: Re: [microsoft/AL-Go] Specify version when building (Issue #387)
What is the Application dependency in your app.json file?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/AL-Go/issues/387#issuecomment-1420806894, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABTP3R6ZCEK7KIQHHVSKUN3WWJHPXANCNFSM6AAAAAAUT3VW2E.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Could you paste your app.json here? (or email it to freddyk at microsoft dot com)

Yes thats done it, threw up some other changes i needed to make but all sorted now.


git.add does not allow for specified files to add in another cwd

There needs to be better comprehension around the "files" part of the arguments.
My situation:

I have a repo that is other than the folder from which git.add is invoked, so I need to comprehend either: 1) gulp.src(...) differently, or 2) be able to specify the repo directory, i.e. git.add({ args: ".", cwd: repoDir })

But which does not add the files as expected.
If I pass the full path of the file(s) in question, then Git complains, of course, the file is "outside" the repository.

Considering the current state of the source, it looks to me like you are assuming that the current process.cwd() is where the files are. You overwrite the add cwd during flush, but never did so during the write, where the files are gathered. It would be better to respect the given opts.cwd, or allow for options passed in that include the specific file names that callers want to add.
This is a bit of a rabbit hole for me. If I must, I will submit a PR, but would this be difficult to correct and publish in the near future?

The input from git.add should be just the vinyl files with their own cwd's attached. It may be needed to alter the cwd on each vinyl object prior to passing through the write, rather than just getting the cwd from one file in the src which is causing the issue.
opts.cwd is only respected by the git process on the write, not the source, and is quite limiting as is.
I'm wondering if copying the files to the "new" cwd before passing through the add would work.
I'll definitely accept a PR, thanks

@stevelacy If I understand correctly, add` in this instance is trying to be *"helpful"*. This isn't how git addactually runs, which I do not think any proxy should be any more helpful than that. In other words, the end user decides *what*, *where*, *when*, etc, to *create*, *copy*, *move*, etc, into the repository. Then runsgit add``.

git.add assumes the file already exists inside the git repo, and passes it farther down to git add.
Yes, the user should use copy before git.add


disable travis model_recover tests, fix doc generate failure

@tqchen  what do you think?
the failed model_recover test might also indicate the reason that why we never see rabit recover correctly in xgboost-spark so that xgboost-spark has its own checkpoint mechanism

I am going to merge this in. The recover test is failing because some of the script semantics changed


Add a b3tracecontext.HTTPFormat

Helps with google/knative-gcp#1147.
Changes

Add a b3tracecontext.HTTPFormat.

It will utilize either B3 or TraceContext propagation formats coming in (preferring TraceContext) and while sending both.

This is being created because we found that serving relied on B3 tracing headers. While eventing relied on TraceContext tracing headers. So an HTTP request sent from a Broker to a Knative Service would break into two distinct traces. By creating this superset of the two formats, we have backwards compatibility with both systems.

Maybe it would be better to only set the outgoing headers which are present in the incoming request? This could be a little tricky to implement but it should be possible to wrap the handler with one which inserts a format key into ctx. On the other hand there may be little downside to always writing both formats.

Maybe it would be better to only set the outgoing headers which are present in the incoming request? This could be a little tricky to implement but it should be possible to wrap the handler with one which inserts a format key into ctx. On the other hand there may be little downside to always writing both formats.

I think there is little downside in always writing both formats. Given that, I think writing a new Handler is overkill for this situation.
And even if we did write that Handler, I think we would still need this (write both formats) propagator for situations where something other than HTTP was used as the input. For example an eventing piece reading from Kafka or Pub/Sub. A wrapping handler would not help, as we don't have an incoming HTTP request. We would need to wrap an ochttp.Transport. It seems far easier, and with little downside, to just use the same propagator for both.

/assign @slinkydeveloper  mind taking a look?

Yeah i think that could be interesting for kafka tracing too!
/assign

/lgtm

Similar to the issue @ian-mi raised, I don't get why we should write always in both formats, to me it sounds pretty overkill (and adds unnecessary overhead to the message). We could make it configurable for the egress maybe? Like b3/tracecontext/both and default to tracecontext? I would prefer to stick with one format on egress side, and support both on ingress.

My main hesitation of only outputting one format is that we are more likely to hit a component that speaks the other form of tracing, thus stopping the existing trace. That is what is happening in Knative today (before this PR). Every hop between eventing and serving cuts the trace because they use different tracing formats. Once this PR is in and all the downstream repos are updated and the user has updated to all those new versions, then it would no longer be a problem for Knative itself. But I'm worried about any software downstream of Knative that happens to rely on the existing format.
If we go the route of configurable egress, then I think we need to have serving use B3 output and eventing use TraceContext output, to match what is already present in both places. As both may already have downstream software that relies on it.
I think the additional overhead on the message is small enough (either ~70 or ~100 bytes), that its existence is justified by the increased chance of interoperating with other software.

Also, before merging this one, can you run the e2e tracing tests on eventing with this patch?

Will do.

Every hop between eventing and serving cuts the trace because they use different tracing formats.

To me this sounds like a different problem, because we don't have an alignment between their tracing propagation and our tracing propagation. Also as far as I understood the b3 propagation is specific to zipkin (which, by the way, can understand also traces propagated with trace context), so that's another reason for me to prefer making it configurable (same on serving).
Also as far as I understood we should make the config-tracing the unique source of truth both for serving and eventing, and configure on it the format to use. So all the knative installation will use the same format, and user won't have to worry about which one uses which format. This way, we won't need to use both formats but we can just stick with one of the two (and eventually, as opt-in feature, emit both)

I think the additional overhead on the message is small enough (either ~70 or ~100 bytes)

Well, it's always additional bytes that are potentially not used downstream.

Every hop between eventing and serving cuts the trace because they use different tracing formats.

To me this sounds like a different problem, because we don't have an alignment between their tracing propagation and our tracing propagation. Also as far as I understood the b3 propagation is specific to zipkin (which, by the way, can understand also traces propagated with trace context), so that's another reason for me to prefer making it configurable (same on serving).
Also as far as I understood from the problem, we should make the config-tracing the unique source of truth both for serving and eventing, and configure on it the format to use. So all the knative installation will use the same format, and user won't have to worry about which one uses which format. This way, we won't need to use both formats but we can just stick with one of the two (and eventually, as opt-in feature, emit both)

Makes sense. This PR will lay the ground work for allowing that option. This repo will need to extend the config-tracing format to include that option. Each downstream option will need to ensure all places that trace have the value plumbed through.

I think the additional overhead on the message is small enough (either ~70 or ~100 bytes)

Well, it's always additional bytes that are potentially not used downstream.

Done. Although I still believe it is better to send the extra bytes than to have the trace broken.

/lgtm
/approve


[BUG] 1.3.1 Disiappearing IP addresses in UI / kubectl

Describe the bug
IP addresses can take a while to populate, can be empty for a host sometimes - but eventually shows an IP most of the time... From discussion in slack.
Is there anything we can do to get this to update more reliably, often I see IP's then after a while they disappear from the list then reappear later - VM's are running rocky-linux 9, this is with a new 1.3.1 harvester cluster - 2 workers, 1 witness node.
Network is getting IP addresses from our routers DHCP and those IP's are set as static mappings for the Macs as we find what they are, new VM's can take a little while to appear.
If I login to our router I can see the machines in the DHCP table - so its easy to work out, just frustrating that the UI doesn't seem to show them all the time - they are fine 95% if the time but there is often 1 or 2 missing, is this a symptom of a greater problem - or just the way it is?
Just to add - there is a DNS pod in this list, its not used yet - there is a dedicated DNSmasq machine outside of the cluster serving the network and a backup VM inside an old cluster - and the router reports both IP's for DNS resolution

To Reproduce
Steps to reproduce the behavior:
Simply goto the virtual hosts page or run and watch the output of
kubectl get VirtualMachineInstance -A --watch
Example outputs -
NAMESPACE             NAME                AGE     PHASE     IP                NODENAME   READY
harvester-public      web1-clone          6d      Running   <IP_ADDRESS>   n4         True
web-engine-services   dns                 3h26m   Running                     n5         True
web-engine-services   gitlab              28h     Running   <IP_ADDRESS>    n4         True
web-engine-services   nfs                 77m     Running                     n5         True
web-engine-services   runner-01           4h48m   Running   <IP_ADDRESS>   n5         True
... truncated ...
web-engine-services   nfs                 15m     Running                        n5         True
web-engine-services   nfs                 16m     Running      <IP_ADDRESS>   n5         True
web-engine-services   minio               47h     Running      <IP_ADDRESS>   n5         True
web-engine-services   zabbix              46h     Running                        n4         True
web-engine-services   zabbix              46h     Running      <IP_ADDRESS>   n4         True

Expected behavior
IP Addresses should be stable
Support bundle
supportbundle_4d170f3b-38c0-41ba-b05c-dfef3d4a621a_2024-08-22T14-36-57Z.zip
Environment

Harvester ISO version: 1.3.1
Underlying Infrastructure: Bare metal, custom build x86 processors, 6 nodes, 1 witness, 2 CP managed via separate rancher cluster of 5 low power nodes.

Additional context
Fairly fresh setup - our router has several DHCP servers running - with statically assigned IP's for any nodes/vm's within the cloud (2 separate subnets). We've got router -> 24 port 1GB layer 2 switch (with all tennant networks connected and the mini rancher cluster) -> 24 port spf+ 10GB Layer 3 switch to which the harvester nodes are directly connected with dedicated 10GBSPF for management and one for storage, with a VLAN configured in this switch for the storage network.

There is another issue where the IP address disappears: https://github.com/harvester/harvester/issues/3990

And similar - #5251

SOunds like this in kubevirt.

are you able to please confirm the guest OS and qemu guest agent version in VM?

cc @starbops @mingshuoqiu @rrajendran17

are you able to please confirm the guest OS and qemu guest agent version in VM?

Guest OS's both Debian and EL9 - specifically -
Debian-12-generic-amd64-20240717-1811
debian@admin2:~$ sudo cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
debian@admin2:~$ apt list qemu-guest-agent
Listing... Done
qemu-guest-agent/stable,now 1:7.2+dfsg-7+deb12u6 amd64 [installed]

Rocky-9-GenericCloud-LVM-9.4-20240609
[rocky@nfs ~]$ sudo cat /etc/os-release
NAME="Rocky Linux"
VERSION="9.4 (Blue Onyx)"
ID="rocky"
ID_LIKE="rhel centos fedora"
VERSION_ID="9.4"
PLATFORM_ID="platform:el9"
PRETTY_NAME="Rocky Linux 9.4 (Blue Onyx)"
ANSI_COLOR="0;32"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:rocky:rocky:9::baseos"
HOME_URL="https://rockylinux.org/"
BUG_REPORT_URL="https://bugs.rockylinux.org/"
SUPPORT_END="2032-05-31"
ROCKY_SUPPORT_PRODUCT="Rocky-Linux-9"
ROCKY_SUPPORT_PRODUCT_VERSION="9.4"
REDHAT_SUPPORT_PRODUCT="Rocky Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="9.4"
[rocky@nfs ~]$ yum list qemu-guest-agent
Rocky Linux 9 - BaseOS                                                 6.0 MB/s | 2.3 MB     00:00
Rocky Linux 9 - AppStream                                               18 MB/s | 8.0 MB     00:00
Rocky Linux 9 - Extras                                                  48 kB/s |  15 kB     00:00
Installed Packages
qemu-guest-agent.x86_64                         17:8.2.0-11.el9_4.4                          @appstream

I'll leave a trace running for the day on kubectl get VirtualMachineInstance -A --watch to see if the debian guests are affected - this morning just one of the rocky vm's were showing blank. This is one of those things that seems to come and go - it does seem rare to get a full list of IP's and usually there is one blank.

I'll keep this trace going - so far today the only guest vm's that have triggered this appear to be the RHEL9 based VM's (Rocky 9.4) -
NAMESPACE             NAME                                 AGE    PHASE     IP                NODENAME   READY
harvester-public      web1-clone                           131m   Running   <IP_ADDRESS>   n4         True
web-engine-services   backup                               131m   Running                     n4         True
web-engine-services   dns                                  131m   Running   <IP_ADDRESS>   n4         True
web-engine-services   gitlab                               131m   Running   <IP_ADDRESS>    n5         True
web-engine-services   minio                                131m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  131m   Running   <IP_ADDRESS>   n5         True
web-engine-services   runner-01                            131m   Running   <IP_ADDRESS>   n4         True
web-engine-services   runner-02                            131m   Running   <IP_ADDRESS>   n5         True
web-engine-services   runner-03                            131m   Running   <IP_ADDRESS>   n4         True
web-engine-services   web-engine-c1-pool1-eea087ef-bs6wm   129m   Running   <IP_ADDRESS>   n4         True
web-engine-services   web-engine-c1-pool1-eea087ef-jbf55   129m   Running   <IP_ADDRESS>   n5         True
web-engine-services   web-engine-c1-pool1-eea087ef-qfv4k   129m   Running   <IP_ADDRESS>    n4         True
web-engine-services   web-engine-c1-pool2-c06dc04b-lds9s   129m   Running   <IP_ADDRESS>   n5         True
web-engine-services   web-engine-c1-pool2-c06dc04b-mtllr   129m   Running   <IP_ADDRESS>    n5         True
web-engine-services   web-engine-c1-pool2-c06dc04b-pt7w7   129m   Running   <IP_ADDRESS>    n5         True
web-engine-services   web-engine-c1-pool2-c06dc04b-skl76   129m   Running   <IP_ADDRESS>   n4         True
web-engine-services   web-server-debian                    131m   Running   <IP_ADDRESS>   n5         True
web-engine-services   zabbix                               131m   Running   <IP_ADDRESS>   n4         True
web-engine-services   nfs                                  134m   Running                     n5         True
web-engine-services   nfs                                  135m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  140m   Running                     n5         True
web-engine-services   nfs                                  140m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  145m   Running                     n5         True
web-engine-services   nfs                                  145m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  150m   Running                     n5         True
web-engine-services   nfs                                  150m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  155m   Running                     n5         True
web-engine-services   nfs                                  155m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  160m   Running                     n5         True
web-engine-services   nfs                                  160m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  165m   Running                     n5         True
web-engine-services   nfs                                  165m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  170m   Running                     n5         True
web-engine-services   nfs                                  170m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  175m   Running                     n5         True
web-engine-services   nfs                                  175m   Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  3h     Running                     n5         True
web-engine-services   nfs                                  3h     Running   <IP_ADDRESS>   n5         True
web-engine-services   nfs                                  3h5m   Running                     n5         True
web-engine-services   nfs                                  3h5m   Running   <IP_ADDRESS>   n5         True

This NFS server seems to be particularly "chatty" though the only one in the UI thats blank is "backup" which appears stuck without an IP - in reality it does have an IP and is accessible - DHCP has a static mapping and I can shell into all these VM's reliably. Actually - backup's problem was it had failed to boot and was stuck at grub - so that maybe a different issue I guess,
So this morning the UI is reporting all IP's that were active -  kubectl get VirtualMachineInstance -A --watch showing above, if this is normal or not I've no idea, UI presently looks stable - will keep an eye out to see if it starts happening again.
Only difference today is that we deployed a k8s into this harvester cluster so we have another 7 VM's running using a different DHCP network range (122.X) web-engine-c1-poolX-YYYY above - so maybe when there are more VM's this is happier... if I spot anything more significant I'll update again.

I can see that issue as well on my ixpe cluster.

@rrajendran17 can you see if this a duplication?

Thanks for the report, the issue is duplicated with https://github.com/harvester/harvester/issues/3990 and we can track in that issue.


Basic transport doesn't support errback

When using the basic transport errback is never called when status code isn't 200. This forces you use a try and its confusing that the function parameter doesn't work as expected.

can you target this for develop branch instead, and bump version there to 0.9.2?

Going to push to develop.


Rename MapviewUtils method

In MapViewUtils, replace calculateXfromY by getXfromY.

calculateXfromY does not exist in MapViewUtils

I guess it was already renamed in the meantime :)


Complete implementation of Llama and other LLMs

The Llama implementation seems to be much simpler than the official version meta-llama.generation.py with many parameters (top_p, logprobs) not functioning. Is there any consideration for reproducing a complete version or welcoming other contributors to implement it?

The intention behind these examples is to be simple so that they 1. are educational and 2. serve as a starting point for customizations / more sophisticated techniques.
With that in mind it's a low priority for us to add all of those options. But would be really great to see a community contributed repo that does that!


AEM 6.5.11 with AEM ACS Commons 4.3.2 : issue with multi field component

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.5.11
[ ] ACS AEM Commons Version: 4.3.2
[ ] Reproducible on Latest? yes

Expected Behavior
multifield components should work. When opened in edit mode, dialogue box should show authored content
Actual Behavior
when dialogue box opened, no content seen on it whereas page has the content authored before 6.5.11 update. Previous working version was 6.5.4
Steps to Reproduce
Have AEM 6.5.11
AEM ACS Commons 4.3.2
Use any multifield component to test

Links
NA

Also please let me if coral2UI will still continue work n 6.5.11 . it was working in 6.5.4. Is it mandatory to move to coral3UI with 6.5.11 update


adding language as parameter to NLTK text splitter

Description:
Adding language as parameter to NLTK, by default it is only using English. This will help using NLTK splitter for other languages. Change is simple, via adding language as parameter to NLTKTextSplitter and then passing it to nltk "sent_tokenize".

Issue: N/A

Dependencies: N/A

Looks good to me -- @tarekabouzeid could you lint and add type information? We can merge once it passes linters

Looks good to me -- @tarekabouzeid could you lint and add type information? We can merge once it passes linters

Thanks so much for reviewing, I have applied your suggestion for the type annotation and ran lint, it passed locally.
(langchain) root@9555d04d5e51:/opt/langchain/libs/langchain# make lint
./scripts/check_pydantic.sh .
poetry run ruff .
poetry run black . --check
All done! ✨ 🍰 ✨
1670 files would be left unchanged.
poetry run mypy .
Success: no issues found in 1667 source files
(langchain) root@9555d04d5e51:/opt/langchain/libs/langchain#


tinc: Add notify option to make the systemd service of type "notify"

Motivation for this change
In our production setup of tinc, it is desirable to make other systemd services only start once the VPN is up.
This is possible with the added option, and a tincUp script like the following (Edit: better script in https://github.com/NixOS/nixpkgs/pull/144118#issuecomment-956406822):
    environment.etc."tinc-${cfg.vpnNetworkName}-tincUp" = mkIf cfg.enable {
      target = "tinc/${cfg.vpnNetworkName}/tinc-up";
      # Note $INTERFACE is a magic tinc keyword.
      text = ''
        #!/bin/sh
        ${pkgs.nettools}/bin/ifconfig $INTERFACE ${cfg.vpnIPAddress} netmask <IP_ADDRESS>
        ${pkgs.systemd}/bin/systemd-notify --ready
        # Have to sleep here because systemd cannot act on notify messages
        # if the sending process (this script) has exited;
        # see section `NotifyAccess=` from
        #   https://www.freedesktop.org/software/systemd/man/systemd.service.html
        # Of course this is racy, but 100ms should be enough for
        # systemd to process the notification.
        sleep 0.1
      '';
      mode = "0555";
    };

~As shown by the comment, the systemd-notify approach using UDP isn't perfect, because it's inherently racy.
However, that's not an argument against having this option, as it is still the best operational setup available today.~ Solved in https://github.com/NixOS/nixpkgs/pull/144118#issuecomment-956406822.
Things done

service-only, off-by-default change
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Fits CONTRIBUTING.md.

CC recent tinc service contirbutors @tomberek @lheckemann @minijackson @Mic92 @erictapen @volth

Interestingly, the issue I referred to in the issue description seems to have been addressed in systemd:

        ${pkgs.systemd}/bin/systemd-notify --ready
        # Have to sleep here because systemd cannot act on notify messages
        # if the sending process (this script) has exited;
        # see section `NotifyAccess=` from
        #   https://www.freedesktop.org/software/systemd/man/systemd.service.html
        # Of course this is racy, but 100ms should be enough for
        # systemd to process the notification.
        sleep 0.1

The new feature and default in systemd-notify (--no-block to turn it off) added in https://github.com/systemd/systemd/commit/4f07ddfa9bc2242eaa6c288a15b8bce4e4383931 seems to address exactly that.

:+1: on supporting notify!
However, I think we shouldn't introduce an additional option for this if that's all it's going to do: you can set systemd.services."tinc.yournet".serviceConfig in your nixos config already. I do think a more complete setup, which includes the script for notifying systemd, would be nice to have. Maybe even as a default!
As for configuring the netmask on the interface, that seems like something that should be done by networkd or similar?


feat: get load average from darwin systems

Codecov Report

Merging #48 into next will increase coverage by 1.06%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##             next      #48      +/-   ##
==========================================
+ Coverage   75.47%   76.53%   +1.06%
==========================================
  Files         181      145      -36
  Lines        5288     3456    -1832
  Branches      654      389     -265
==========================================
- Hits         3991     2645    -1346
+ Misses       1033      672     -361
+ Partials      264      139     -125

Impacted Files
Coverage Δ

packages/metrics/src/client/CachedMetricSet.ts
100% <100%> (ø)
:arrow_up:

...kages/metrics/src/metrics/os/SystemLoadGaugeSet.ts
68.08% <48.14%> (-14.27%)
:arrow_down:

packages/metrics/src/trace/SpanContext.ts
60% <0%> (-24%)
:arrow_down:

packages/metrics/src/trace/Tracer.ts
57.44% <0%> (-17.03%)
:arrow_down:

packages/metrics/src/trace/PandoraSpan.ts
71.87% <0%> (-15.63%)
:arrow_down:

...ges/metrics/src/collect/CompactMetricsCollector.ts
68.18% <0%> (-6.82%)
:arrow_down:

packages/pandora/src/daemon/DaemonBootstrap.ts

packages/pandora/src/daemon/SpawnWrapperUtils.ts

...ages/pandora/src/service/ServiceContextAccessor.ts

packages/pandora/src/universal/Helpers.ts

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec67b0b...2e8d7ba. Read the comment docs.


Got error when try to run the example for .Net Core

I am using:

Docker for setup Ledger work with 4 Node.
donet-sdk-2.1
package Hyperledger.Indy.Sdk --version 1.4.0
Ubuntu 16.04

I have this error at step 10 when try to run AnonCredsDemo.cs. You can check this screenshot
@tmarkovski You have updated this example. Can you help me solve this problem?
Thank you

@nbxtruong Which version of libindy do you have installed on your linux machine? The nuget package only works with libindy 1.4.
The samples are updated for 1.5 pending a PR, if you want to check that out.
https://github.com/hyperledger/indy-sdk/pull/953

@tmarkovski I build the package by following this post. But, I got error. You can check this screenshot
Thank you

This error is fixed by updating your rust compiler. You're probably using version 1.24. You need at least 1.26. Try running rustc -V to check. You can update to latest using rustup update

Thank you @tmarkovski I compile success. But, How I use this package after it compiled. Do I need update this file. I do not know how to run this example after this package compiled.

@nbxtruong You should copy the .so file into your library folder, usually /usr/lib under Linux or /usr/local/lib on Mac.

We are using Jira to track issues now, please use this Jira IS-998 ticket for any further discussion.


Add a license

Consider adding one of many open source licenses

The BSD 3-Clause License has been selected and will be included with the initial commit. It's simple and very non-restrictive, allows anyone to use this code as long as the original license and copyright notice are kept.


chore(test): compress the test data

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Reduce size from 16MB to 400KB.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)


Fixed typo.

~ Petty typo fixes are the backbone of OSS ~

@paulk-asert
Amanda(amandasullivan) submitted the PR, but we received jespersm's notification:
http://groovy.329449.n5.nabble.com/GitHub-groovy-pull-request-486-Fixed-typo-tp5738269.html

Yeah, not sure why the mailing list notifications sometimes do that.

Thanks Amanda, PR merged.


ImagePullSecrets configuration support

When I deploy RadonDB, I've no place to set the ImagePullSecrets option so that the images provided in private repository would never be pulled to the current kubesphere node, can't connect to my private repository via the image secret I configured.
Only I load the image on the current K3S node locally, pull images such as mysql-sidecar, xenon will be successful.
Could you support the ImagePullSecrets option?

Thanks for your suggestion, we will evaluate as soon as possible.

Agree with xiaoxia0617!
The ability to store images in a private container registry is blocking feature to me 🥲


feat: added support to pass radio props

If there’s anything I can do to improve or fix, please let me know.

Isnt the RadioProps type from @mui?

Isnt the RadioProps type from @mui?

changed!


Update CONTRIBUTORS.md

adding my name in Contributors.md

Hey there,
Thanks for your PR & contribution :wave:!
Don't forget to join follow me, join our organization, & follow our organization to stay updated with the latest developments 💻
Thank you, and have a good day ahead 😊


hicolor is NOT default on Debian/Fedora when building from source, but it should be

Monochromatic is supposed to be the default.


[UI] [optimization] repo settings page ui can't adaptive the screen size

Gitea version (or commit ref): 1.12.0+dev-336-g530f8963f
Git version: latest
Operating system: docker
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[X] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No
[x] Not relevant

Log gist:

Description
when I resize the screen , UI   is not responding correctly
url:  http(s)://IP/user/repo/settings
...
Screenshots

These tab bars being left-aligned comes from a workaround to prevent overflows on small screens. The proper fix would be justify-content: safe center so they center without overflowing outside the viewport, but the safe keyword currently is only supported on Firefox so another method (wrapper div) would be needed.

This should be fixed on master now.


Adjust the width of a mat stepper at every step

Please describe the feature you would like to request.
Adjust the width of the  horizaontal mat stepper at every step
What is the use-case or motivation for this proposal?
At every step of a horizontal mat stepper, the components change. So the mat stepper should  adjust not only for height but also the width.
Is there anything else we should know?
Currently I am pushing an event on every step label click to the parent and controlling the width of the div or the mat-dialog ( where the mat-stepper is placed).
Can we make this process any simpler?

Can you provide a use case or reproduction showing the width change you wish to see? It's not as common to need dynamic widths so an example would help us understand the use case.

Closing because this issue has been inactive for 2 weeks or more after follow up was requested.


support maplibre-gl-js v4

A few weeks ago maplibre-gl-js has had a new major version: https://github.com/maplibre/maplibre-gl-js/releases
It would be convenient to have this update reflected in maptiles-sdk-js's package.json.
Thanks.

Hello @paulovieira , we are currently updating our SDK so that it benefits from the MapLibre v4.1 updates. We expect to release it as SDK v2.0.0 later this week or early next week

Hello @paulovieira,  version 2.0.0 of the SDK is now available and contains the last version of MapLibre GL JS.


inkcut: fix by using the standard qt5 version

This broke with c1a0dfadea3c0f56d5213a677dbbd7b3e89ee98f

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

this might no longer be relevant


Properly configure CODEOWNERS

I believe this is correct, but it may not be. If it isn't, it can be reverted or repaired.
The goal is to enable maintainers to merge reviews for all files but those in the very top-level directory.


[cryptotest] Add test coverage of HMAC streaming API

Adds test coverage in the cryptotest framework for the HMAC streaming API added in #23335. The testing is modeled after how the streaming coverage was done for SHA-2 in #21281.
The second commit uncomments the hash algorithm tests in the BUILD file, which were accidentally commented out in a previous commit.
See also:  #23471

The test should respect the timeout that's there. If you're timing out, you can try changing long to eternal and see if it works. I don't recall it taking longer than 2 hours to run on my CW310, however.

LGTM, thanks @RyanTorok.
nit: Digest/tag sizes are exposed through cryptolib-API's hash.h now, which is included in mac.h. I recently refactored some other tests to reuse these exposed enums. E.g. kOtcryptoHmacTagBytesSha256 -> kSha256DigestWords.
Because of the amount of vectors in SHA-2, I cannot get past 2h timeout on FPGA. Am I missing another timeout parameters besides the one defined below?
https://github.com/lowRISC/opentitan/blob/ec14811d1bf1454f3434be70a24831201216ec1b/sw/device/tests/crypto/cryptotest/cryptotest.bzl#L39

Refactored to use the constants in hash.h.

I find the timeout very surprising; HMAC should be fast. I'm worried this means we're missing a performance issue in the C code. How many test vectors are there exactly? Is the test progressing through them at a steady rate or taking much longer on some than others?

I find the timeout very surprising; HMAC should be fast. I'm worried this means we're missing a performance issue in the C code. How many test vectors are there exactly? Is the test progressing through them at a steady rate or taking much longer on some than others?

The test timeouts (at 2h mark) at the following test:
[2024-06-04T17:13:20.803Z INFO  harness] Test counter: 632
[2024-06-04T17:13:20.803Z INFO  harness] vendor: nist, algorithm: sha-512, test case: 117
[2024-06-04T17:13:20.803Z INFO  opentitanlib::test_utils::rpc] Sending: "Hash"
[2024-06-04T17:13:20.810Z INFO  opentitanlib::test_utils::rpc] Sending: "Sha512"
[2024-06-04T17:13:20.819Z INFO  opentitanlib::test_utils::rpc] Sending: {"length":64}

There are two immediate things to improve in the driver that I am aware of:

Message bytes are written byte at a time, and needs to be optimized to word-writes as much as possible
One-shot calls are actually broken down into 2 streaming calls, so there is a cost of storing/restoring context even for one-shot calls.

However I am not sure these alone should justify the speed. I will investigate to see why it's taking so long.

I find the timeout very surprising; HMAC should be fast. I'm worried this means we're missing a performance issue in the C code. How many test vectors are there exactly? Is the test progressing through them at a steady rate or taking much longer on some than others?

There's a lot of hash test vectors, and quite a few of them are intentionally very long messages that take on the order of seconds to hash on a CW310. I recall the entire job taking over an hour for me, the last time I ran the whole thing.

Regarding your concern about the performance of HMAC, recall that the hash test job also includes SHA-3 and SHAKE, which are currently software backed, I think. One practical option would be to split the job up by high-level algorithm, i.e. one job for SHA-2, one for SHA-3, and one for SHAKE.

We should make this change so that we can include the SHA2 and HMAC vectors as part of the hmac sign-off. I would prefer if there is a separate target per configuration: e.g. hash_sha2_256_kat, rather than bundling everything up. You can still have a test suite aggregating all tests as hmac_kat.
Let's get this PR in, and then we can work on the required refactoring.

Regarding your concern about the performance of HMAC, recall that the hash test job also includes SHA-3 and SHAKE, which are currently software backed, I think. One practical option would be to split the job up by high-level algorithm, i.e. one job for SHA-2, one for SHA-3, and one for SHAKE.

But according to the printout, it's timing out after 632 tests. I'd expect a hardware HMAC to get through a lot more than that in 2h on an FPGA. I'm still a little worried that we're missing a performance issue here. But it shouldn't block the PR; either the issue is in the test code (in which case it's not a huge deal) or it's not being introduced here, just detected.

But according to the printout, it's timing out after 632 tests. I'd expect a hardware HMAC to get through a lot more than that in 2h on an FPGA. I'm still a little worried that we're missing a performance issue here. But it shouldn't block the PR; either the issue is in the test code (in which case it's not a huge deal) or it's not being introduced here, just detected.

Yes, it timeouts before SHAKE/SHA3 vectors. I think the number of tests do not mean much in this case. The message length seems to be throttling the speed.
For comparison, hmac_kat passes in ~19 mins with 1422 tests. In any case, it's worth looking into. It should not block this PR.

I ran a simple experiment that runs 100 SHA-512 operations with 4KByte message blocks, by modifying sw/device/tests/crypto/hmac_functest.c:

Define an array of 512-bit x_i variables for i in [0, ..., 100]. Set x_0 = 0.
For i in [0, ..., 99] compute:

x_{i+1} = SHA512(x_i || x_i || … || x_i) where the input message is 4KByte. Each x_i is 64 bytes, so the message is concatenation of 64 copies of x_i.

Check that x_100 matches known digest value.

I get the following time measurements on CW340.

When SHA-512 calls are streamed with 64 update calls:

The complete test ends in 8.3s.
Each SHA-512 computation takes “314447 cycles or 54768 us @ 24 MHz” as reported by LOG_INFO.

When SHA-512 calls are one-shot:

The complete test ends in 3.1s.
Each SHA-512 computation takes “29327 cycles or 1221 us @ 24 MHz.” as reported by LOG_INFO.

I suspect that the cryptotest and communicating with FPGA is the bottleneck for tests that have large message inputs.

Thanks for the experiments, @ballifatih ! I agree that given your results (reasonably fast tests even with large, streamed input) it seems likely that communication with the FPGA could be the culprit in terms of performance. It'd still be good to resolve, but that's much better than the bottleneck being in the actual library :slightly_smiling_face:

Rebased to master to resolve merge conflict with #23518


Revised IE: Implement two-handed grasping

For some InteractionBehaviours, it makes sense to allow grasping by multiple hands at once. This is especially true for something like a ship's control yoke, where two-handed grasping is highly intuitive and the placement of the hands may be post-processed by the grab.
It should be possible to deactivate the multiple-hand-grasping behavior, and it should probably be disabled by default. (This issue pertains to the Revised IE, not the current IE.)

Working as of latest leap-gui-interaction.