Morning peer to peer code review

The code looks good so far
The markup gives for a slick presentation of the web app
Good Job

Thank you for your issues

nice UI design  Roshan 👍

Recommend Changes ♻
👍 You have done great work there @roshan-bajgain.
✔ Your project looks nice and very close to being complete, but there are a few changes I would like you to take a look at:

What if you make the input field span 100% width so when a new todo is to be added on can click on any area the input field is and get access to enter a text easily
Also some mark a todo as completed, it would be nice you add a CSS style to clear all todos text to be a pointer when hovered.

Completing those suggestions will make your project more user-friendly. Other than those I think your project is looking good.


Tamagui Recipe

Describe your recipe idea
It would be great to have a recipe for integrating tamagui into the expo ignite repo.

Hey @Silthus thank you for your contribution
TLDR
This will not happen.
tamagui is an awesome project but has deep roots in the monorepo world (mainly because it's a compiler AND a UI kit working with expo AND nextjs).
Ignite is 💯 % focused on react-native
There is no real value because projects diverge a lot:
ignite (quite "simple")

mobx

tamagui (opinionated and overwhelming)

tanstack/react-query
zod
react-hook-form
...

But let's say we spend a lot of time creating such a guide

now we need to maintain the guide and sync with https://tamagui.dev/docs/intro/installation
why not include other UI's kit integration recipes?

I will close it for now but feel free to open it again with a PR 🚀


Rename scan -> plan

Renamed, at the request of @klauer, to differentiate: a plan is an iterable object that yields messages. A scan is a call to process those messages.

I did some careful git commit -p work here and I have decent faith in the tests. The docs will need work -- didn't want to apply sed heavily to that.

:+1: for slightly less confusion

How about simple_scans.py -> scans.py?

@klauer That rename is pretty simple, but it's worrying that scans.AbsScan in the current master would be replaced by scans.AbsScan that is actually a different class. Could we do this later -- say in a cycle or so -- after beamline configs and user code have been updated to scans -> plans?

You're absolutely right, but you'll get much more flak for bikeshedding/renaming things as the userbase grows. Either way, this PR is already an improvement.

If we do want to do the simple_scan -> scan rename before the beam comes up we should do it in a second pass around the ring once we have updated everything else in their beam line configs to work.


Change Python linting version when using Docker

I use vim and ALE in my baseline enviroment, which happens to use Python 2. I am developing something in Python 3 that happens to use Docker. So ALE expects Python 2 when I am editing, but I want it to be linting for Python 3 (similar to this issue).
I tried doing let g:ale_python_flake8_executable = 'python3', but I got this error:
Traceback (most recent call last):
  File "<stdin>", line 13, in <module>
SystemError: Parent module '' not loaded, cannot perform relative import

I don't know what to make of that error. My guess is that ALE cannot find Python 3. If this is the case, then I am not sure how to point it to the Python within a docker image.

ALE doesn't support running programs inside of Docker, so I can't offer much help here. You could try using the b:ale_command_wrapper option for wrapping commands with scripts for running commands in Docker.
For some tools they operate purely via stdin and stdout, so they could work. For most tools, they require a filename to be given to the command at some point, including flake8. If you're running a program inside of Docker, you're dealing with a separate filesystem with different paths for all of the files. ALE would only be able to support running programs in Docker if it had some way of letting you define how to translate filenames between two filesystems.
My recommendation for running linters in Docker is to install both Vim and ALE into the Docker image along with everything else, and start Vim from an interactive session. This is the same as running Vim on a remote server over SSH.
Either that, or don't use Docker, and install the linters on your local machine instead. For Python tools, virtualenv is sufficient.

I found using b:ale_command_wrapper is useful even when we use a combination of pyenv and virtualenv. We can write let g:ale_command_wrapper = "source activate [Your environment name];" and it worked for me.

If anyone's interested, I threw together a quick blog post about setting up ALE + Docker to work together:
https://rymc.io/blog/2019/vim-ale-docker-per-project-linting/
Pretty sure this should be mostly applicable to other scenarios as well, but if anyone's got better ideas I'm all ears. Linking it here because this is the most common linked issue I see for Docker and ALE.

I responded to this here too: https://github.com/w0rp/ale/issues/1201#issuecomment-470863284


Feature/fixed filter order

Changes the behaviour of the Corpus serializer to maintain the order of the fields as they appear in the corpus definition. the read_only setting of the FieldSerializer was causing the order to disappear. This branch also contains the commits from feature/deduplicate-corpora, which was used to split off from (oops).

I know I just approved this, but then I remembered something I wanted to comment. I suspect your solution will not work when the field order in the definition is updated.
Can you verify that this unit test passes?
import shutil
import os

from addcorpus.python_corpora.save_corpus import load_and_save_all_corpora

def test_field_order_python_corpus(small_mock_corpus, admin_client, tmpdir, settings):
	# check field order matches corpus definition
	response = admin_client.get('/api/corpus')
	corpus_data = next(c for c in response.data if c['name'] == small_mock_corpus)
	field_names = [field['name'] for field in corpus_data['fields']]
	assert field_names == ['date', 'title', 'content', 'genre']

	# copy corpus definition into tmpdir
	current_dir = os.path.join(settings.BASE_DIR, 'corpora_test', 'small')
	shutil.copytree(current_dir, tmpdir)

	definition_path = os.path.join(tmpdir, 'small_mock_corpus.py')

	with open(definition_path, 'r') as definition_file:
		definition_str = definition_file.read()

	# replace `fields = [...]` line in file to change field order
	definition_str.replace(
		'fields = [date, title_field, content, genre]'
		'fields = [title_field, content, genre, date]'
	)

	# save edited definition
	with open(definition_path, 'w') as definition_file:
		definition_file.write(definition_str)

	# check order has changed
	settings.CORPORA[basic_mock_corpus] = definition_path
	load_and_save_all_corpora()

	response = admin_client.get('/api/corpus')
	corpus_data = next(c for c in response.data if c['name'] == small_mock_corpus)
	field_names = [field['name'] for field in corpus_data['fields']]
	assert field_names == ['title', 'content', 'genre', 'date']

looks good if you can fix the failing test! Taht should be no problem, feel free to merge after that.

@Meesch  is this ready to merge?


[release-1.11] backports for release-1.11.1

Changes

Fixed parsing of image repositories with more complex hierarchy (sub-paths). Example of such registry: us-central1-docker.pkg.dev/my-gcpproject/team/user.

Fixed possible infinite hang on Windows with "host" builder.

Fixed issue where on cluster build fails because of insufficient permissions on some clusters.

Enabled buildpack on-cluster-build for Go and Rust.

Enabled s2i on-cluster-build on aarch64, ppc64le and s390x clusters.

Updated buildah image reference in s2i tekton task.

Updated Quarkus version in templates.

Updated Spring Boot version in templates.

fix: parsing of image repositories with more complex hierarchy; e.g. 'example.com/org/suborg/user'
fix: issue where on cluster build fails because of insufficient permissions on some clusters
feat: enabled buldpack on cluster build for Go and Rust
feat: enabled s2i on cluster build for aarch64 ppc64le and s390x clusters
feat: the 'func environment' sub-command now reports URLs of used tekton tasks

PTAL @gauron99 @lkingland @jrangelramos

/ok-to-test

PTAL @lkingland @gauron99 @jrangelramos


 :)
It baffles me that editable installs are still a hot topic in the packaging game. Here the simplest diff that can allow these I think, and it still saves time when testing changes against a real world codebase.

I don't use poetry (nor PEP517) for sftpgo-client, and it uses openapi-python-client to generate most of the codebase (but not all). I have both codebases as directories, each with their own virtual environment.
If I want to hack on openapi-python-client and see the diff it generates for sftpgo-client, at the moment I have to either reinstall openapi-python-client in stpgo-client's virtual environment at every change, or do the changes in sftpgo-client's virtual environment directly, but openapi-python-client isn't a git repository here, so I have to backport the changes later so that I can commit them.
With this PR, I can simply run pip install -e ../openapi-python-client inside sftpgo-client virtual environment and avoid all this fuss.


Add mix-blend-mode selector for charts

In order to help eliminate contrast issues, we want to add the following CSS rule to patternfly-charts.scss.
.pf-c-chart svg g[clip-path] { mix-blend-mode: multiply }
See https://github.com/patternfly/patternfly-react/issues/2722

:tada: This issue has been resolved in version 2.31.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use setuptools_scm to derive the version.

This way we don't have to remember to update the version when we make a
release; the version will be derived from the git tag (and stored in the
package info if we make an sdist). We actually forgot this when we
tagged v0.2!

Weird, I get 0.3.dev45+g1709920.

The number followed by 'g' is the commit number which is the same in both cases. Not sure what the rest of the numbers mean.

The number followed by 'g' is the commit number which is the same in both cases. Not sure what the rest of the numbers mean.

If you do git tag, what do you get?

channel-proposal
v0.1
v0.1.1

Based on that, my result is what is expected.

It all makes sense now.

Yeah, that would do it.

@SahilTikale @mosayyebzadeh @izhmash can we get second review on this?

2 sign offs, so merging.


Make HttpInputClient timeout settings changeable via _cluster/settings

 Issue by ann3431
Friday Jul 19, 2019 at 22:14 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/86

The timeout and maximum content length values of HttpInputClient is currently set by  HttpInput of monitors. We should make it changeable from _cluster/settings.

Closing.


Can't search extensions behind a http proxy

VSCode Version: code --version
1.14.2
cb82febafda0c8c199b9201ad274e25d9a76874e
OS Version: Ubuntu 14.04

Reproduces without extensions: Yes
below is verbose：
code -w --verbose
[main 11:26:09 AM] Starting VS Code in verbose mode
[main 11:26:09 AM] from: /usr/share/code/resources/app
[main 11:26:09 AM] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: true,
  w: true,
  diff: false,
  d: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  'skip-getting-started': false }
[main 11:26:09 AM] IPC#vscode-machineId
[main 11:26:10 AM] IPC#vscode-workbenchLoaded
[29370:0810/112613.992523:INFO:CONSOLE(29)] "An unknown error occurred. Please consult the log for more details.", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)
[29370:0810/112613.992710:INFO:CONSOLE(28)] "WARNING: Promise with no error callback:104", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[29370:0810/112613.992733:INFO:CONSOLE(28)] "[object Object]", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[29370:0810/112614.053808:INFO:CONSOLE(28)] "An unknown error occurred. Please consult the log for more details.", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[29370:0810/112624.649312:INFO:CONSOLE(20)] "ApplicationInsights:Sender", source: /usr/share/code/resources/app/node_modules/applicationinsights/Library/Logging.js (20)
WARNING: Promise with no error callback:6
{ exception: Error: net::ERR_NAME_NOT_RESOLVED,
  error: null,
  promise:
   { _creator: null,
     _nextState: null,
     _state:
      { name: 'error',
        enter: [Function: enter],
        cancel: [Function: s],
        done: null,
        then: null,
        _completed: [Function: s],
        _error: [Function: s],
        _notify: [Function: m],
        _progress: [Function: s],
        _setCompleteValue: [Function: s],
        _setErrorValue: [Function: s] },
     _listeners: null,
     _value: Error: net::ERR_NAME_NOT_RESOLVED,
     _isException: true,
     _errorId: 6,
     done: [Function: done],
     then: [Function: then] },
  handler: undefined,
  id: 6,
  parent: undefined }
Error: net::ERR_NAME_NOT_RESOLVED
[uncaught exception in main]: Error: net::ERR_NAME_NOT_RESOLVED

Error: net::ERR_NAME_NOT_RESOLVED
Error: net::ERR_NAME_NOT_RESOLVED

Error: net::ERR_NAME_NOT_RESOLVED
    at Timeout._onTimeout (/usr/share/code/resources/app/out/vs/code/electron-main/main.js:4:78286)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
[29370:0810/112639.061142:INFO:CONSOLE(29)] "net::ERR_NAME_NOT_RESOLVED

Error: net::ERR_NAME_NOT_RESOLVED: Error: net::ERR_NAME_NOT_RESOLVED

Error: net::ERR_NAME_NOT_RESOLVED
    at Timeout._onTimeout (/usr/share/code/resources/app/out/vs/code/electron-main/main.js:4:78286)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (29)

Can you ask your system administrator to give you access to our commonly used domains?
https://code.visualstudio.com/docs/setup/network#_common-hostnames

Seems related to #30850

@DarkLite1 Not the same. I can't get the extensions list.
@joaomoreno I can't.
All of our internet access include DNS lookup have to go through http proxy.
Local dns server only resolve the intranet address.

@pffang That's the problem. ERR_NAME_NOT_RESOLVED means the domain can't be found. This is an issue with your system, not Code itself.

@joaomoreno But it work fine in version 1.6.1
9e4e44c19e393803e2b05fe2323cf4ed7e36880e
I think maybe the old version can do DNS lookup through http proxy.
Many applications can do DNS lookup through http proxy. I wish vscode can do it too.

My issue in #30850 was similar. Everything worked fine one version before and then all of a sudden it stopped working due to the transparent proxy not being recognized. I think this should be investigated deeper. more users will most likely run into this issue.
Secure traffic, with https, should als be supported behind a proxy.

@pffang Does Google Chrome work in your setup?

@joaomoreno Google Chrome works fine.

Open this in Chrome: chrome://net-internals/#proxy what shows up?

@joaomoreno
Proxy server for FTP: <IP_ADDRESS>:3128
Proxy server for HTTP: <IP_ADDRESS>:3128
Proxy server for HTTPS: <IP_ADDRESS>:3128
Bypass list:
  localhost
  <IP_ADDRESS>/8
  ::1
Source: GSETTINGS

The proxy also export to environment variable http_proxy, https_proxy and ftp_proxy.
Most software work fine.

https://code.visualstudio.com/docs/setup/network#_proxy-server-support
Can you try:
code --proxy-server=<IP_ADDRESS>:3128

@joaomoreno I don't  know  why, but it  works fine again on version
1.15.1
41abd21afdf7424c89319ee7cb0445cc6f376959
without the parameter  --proxy-server=<IP_ADDRESS>:3128


Add Cardano PostgRESTed to Builder Tools

Checklist

[x] I have read the How to Contribute.
[x] I have read the Builder Tool Requirements
[x] I have run yarn build after adding my changes without getting any errors.

Builder Tool addition

Title: Cardano PostgRESTed
Description: This a postgrest interface backed by a PostgreSQL database, costantly feeded by cardano-db-sync daemon. You can fetch JSON directly into your web app.
Website:   https://api.cardano.hwl.blue/docs/
Getstarted: /
Tags:

operatortool
http
hosted

Isnt this kinda subset of koios?

Isnt this kinda subset of koios gRest?

just taken a look at koios gRest: yea, sort of. I think we use the same set of backend/frontend interface


Identify V2 API changes by letter

To avoid confusion with the registry version number or other project versions,
the specification updates are now lettered.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

LGTM

LGTM


cherrypick-1.1: sql/pgwire,parser: render non-tz timestamp in its loc, set loc when casting

PR: https://github.com/cockroachdb/cockroach/pull/18764

Covered in https://github.com/cockroachdb/docs/issues/1959


Test Runs PHP-CS-Fixer

Run make cs in test target
Run composer update
Rename appropriate rules to newly renamed rules
Remove deleted rules

Notes
It's difficult to tell what rules were deleted or renamed. I'm attempting to get things passing.

make cs passes on Zeppelin

yaaaaaas

but now.. fix the thing that's breaking the thing.

looks good to me. :+1:

Merging then tagging v0.3.1

@kayladnls @rcatlin
All of these problems could have been avoided - at least in part - by checking in composer.lock.!

All of these problems could have been avoided if we used exact version numbers or SHAs.


Make the username along with the rewards icon clickable in the Navigation Drawer

Summary:
Make the username along with the rewards icon clickable in the Navigation Drawer
Steps to reproduce:
How can we reproduce the issue?
What did you expect the app to do, and what did you see instead?

Open the app's Navigation Drawer.
See the username and the trophy icon.
The trophy icon doesn't appear to be clickable at first glance.
Make the username also clickable as generally clicking the user name open a user's profile in any application.

Commons app version:
2.11.0-debug-master
Would you like to work on the issue?
Opening this as a GCI issue.

@misaochan @neslihanturan @ashishkumar468 could you please provide your views on this? Is it fine for a GCI issue?

Hi @yashk2000. Not sure about this in terms of GCI, but IMO, the feature looks fine to me. It would be nice to have the entire area clickable.

@ashishkumar468 @neslihanturan I have a few more ideas for GCI tasks, but I want to discuss them with you before I create the tasks. So should I just open issues over here, or should I send a list of all my ideas to the mailing list?

I agree this one is not for GCI but would be lovely to have, thanks.

I'm taking up this issue since it hasn't been resolved yet.


Support ipv6

Hi, it would be great if it'll be possible to run geminu-gui on hosts with ipv6 only. The easisest way to do it just using '::' as default host — here https://github.com/gemini-testing/gemini-gui/blob/master/lib/cli.js#L14 instead of 'localhost'.
But may be you have a better solution?

@d4rkr00t Do you have any errors while running gemini-gui on localhost?

No, it only happens when I'm using remote server with ipv6.

@d4rkr00t You should try -h :: option


Where is the centre of the R200?

Required Info

Camera Model
R200

Firmware Version

Operating System & Version
N/A

Kernel Version (Linux Only)

Build System
N/A

On the projection documentation, it says:

Each stream of images provided by librealsense is also associated with a separate 3D coordinate space, specified in meters, with the coordinate [0,0,0] referring to the center of the physical imager

Could you please elaborate on what the 'center of the physical imager' refers to? For the r200, is this the center of the visible lense? Or the center of the physical object? An image would be really helpful.

@mgserafi - Data streams coming out of librealsense (either real or synthetic) can be expressed in several different coordinate systems. One example would be the depth image itself. The origin of this data, expressed in meters, is the center of the left IR camera sensor.

Thanks. Is there documentation that specifies the origin of data for each stream?

Hi @mgserafi - The origin in Z is only really relevant for the depth camera. We provide intrinsic calibration in the library (principal point, focal length) for left/right IR along with the RGB camera, and extrinsic calibration between all 3 sensors.


Modify the log_dir and log_dir_pretrain

What file should to put in the path of log_dir and  log_dir_pretrain

Hi Yao1up, these directories are the parent directories where you store the models, please check the following lines.
https://github.com/charliememory/Disentangled-Person-Image-Generation/blob/e4703860bb1b351050ce50f339985ff0811f1d64/run_market_train.sh#L19
https://github.com/charliememory/Disentangled-Person-Image-Generation/blob/e4703860bb1b351050ce50f339985ff0811f1d64/run_market_train.sh#L48


implement the rest of preaggregated metrics using datastax

This implements the rest of the pre-aggregated metrics IO using datastax driver. Changes are:

created CounterIO, GaugeIO, SetIO, and TimerIO for Datastax (prefixed with 'D')
implemented DPreaggregatedMetricsRW
implemented APreaggregatedMetricsRW for Astyanax driver, it is just wrappers to call the appropriate methods in AstyanaxReader and AstyanaxWriter
used in LocatorIO when writing metrics
merged in tests in service.PreaggregatedMetricsIntegrationTest to io.PreaggregatedMetricsRWIntegrationTest

Coverage increased (+0.6%) to 77.43% when pulling f041a1ef8aba5d0f2d94f110edd1163eda8c046c on shintasmith:datastax_preaggr into ed2cbafb1c8440f28c8fc16cb78658ce46a597d7 on rackerlabs:master.

Coverage increased (+0.7%) to 77.479% when pulling 457f1ef9f225335824b2c9c36be97c25bef0c23c on shintasmith:datastax_preaggr into ed2cbafb1c8440f28c8fc16cb78658ce46a597d7 on rackerlabs:master.

I assume this will be wired into blueflood in a later PR?

Yes, that is the task CMD-1032

Coverage increased (+1.07%) to 77.857% when pulling 8e9565aa673257b914be8b4dc52b5395fc49f107 on shintasmith:datastax_preaggr into ed2cbafb1c8440f28c8fc16cb78658ce46a597d7 on rackerlabs:master.

Coverage increased (+0.9%) to 77.642% when pulling b89588c9ba9d88412ef86d94994de88e16a83206 on shintasmith:datastax_preaggr into ed2cbafb1c8440f28c8fc16cb78658ce46a597d7 on rackerlabs:master.

Coverage increased (+1.03%) to 77.816% when pulling f7835015964f2d50061af563c43e115ec27cbfe8 on shintasmith:datastax_preaggr into ed2cbafb1c8440f28c8fc16cb78658ce46a597d7 on rackerlabs:master.

Coverage increased (+1.3%) to 78.07% when pulling fda112d0a2b3d83887d230e79657d2a3f2e8add8 on shintasmith:datastax_preaggr into ed2cbafb1c8440f28c8fc16cb78658ce46a597d7 on rackerlabs:master.

@usnavi @ChandraAddala @VinnyQ @izrik @drenalin23 I think I am done updating this PR. I incorporated all your feedback. I also fixed the failing testLocatorWritten test in Travis.
Please let me know if you have additional comments/suggestions.

Looks good.

mergy mergy


Add basic sections

Initial pull request to verify process/permissions

@ryjones To get the docs updated rapidly for the hackathon can either

I have permission to push direct  (in which case I can close this PR)
I have permission to merge

I think we need to rapidly iterate... I've raised some issues to get basic info documented for the hackathon


[android-feature] : now can automatically added chat room when other …

…invite you

Wow.. Awesome semi-final result!


Implement brace matcher, commenter, folding builder(for match { ... } else { ... }, "alternatives", extern {...} and enum {...}),  and quote handler

Because they somehow were missing and I consider them essential.

I think it's fine as it is. Alternatively we may want to return an empty list if we find that the braces don't match up. I did some limited testing and didn't see any odd behavior when I removed or added braces. I can clarify the comment so that's documented.

And also here it's the other way around by the way
https://github.com/Mcat12/intellij-lalrpop/commit/ac9fd4c5bf3ba8694932d00fd4b31ed2c3ba03ca#diff-a5e31c273a67464a39b866ae9a09fd4cR27
There are more closing braces than opening ones.
Also there are more opening braces if the stack is not empty at the end.

Ah, you're right, I'll update the comment again.

I'm a little surprised that IntelliJ doesn't automatically find the braces for folding based on the LpBraceMatcher class. I guess it's not always a 1:1 relationship between brace matching and folding.


wrong doc_freq() after deletes

The method searcher.doc_freq() doesn't seem to take all delete operations into account. When I do:

add two documents, one with field=a, one with field=b
delete all where field=a
commit

then searcher.doc_freq(field=a) returns 1 instead of 0
The failing test case is here: https://github.com/brainlock/tantivy/commit/222d8fe03c57f569bb2fd69358b82fc07d629bfa
(it's based on latest master, but I also reproduced it with the version we're currently using (0.11))
I also tried adding a commit() after the two add operations and before the delete, with the same result.
If I close the index and reopen it, I get the same result. From this, I deduced that the frequency information is already incorrect when serialized. I confirmed this by setting breakpoints during commit(), TermInfoStoreWriter is already carrying the wrong frequency.
More potentially useful observations:

if I change the test to add only documents where field=a (1 in the test code), the doc_freq call at the end correctly returns 0

if I change the test to create 100 documents with field=a and then use a multithreaded writer, I get strange results: with 1 thread, the doc_freq at the and returns 100 instead of 0. With 2 threads: 99, with 3 threads: 98, with 4 threads: 97...

Yes we ignore delete in doc_freq. We should update the documentation accordingly.


fix typo in Readme

Thanks!

did you just close this by accident?

Thanks for bringing it up, closed it instead of pressing merge :)

no worries :tada:


Label all the issues

https://github.com/DiamondLightSource/dodal/issues?page=3&q=is%3Aopen+is%3Aissue+no%3Alabel

done


MetaCyc:<IP_ADDRESS>-RXN xref on GO:0000254 C-4 methylsterol oxidase activity

MetaCyc:<IP_ADDRESS>-RXN is a subreaction of RXN-13188 (corresponding to EC:<IP_ADDRESS>)
RXN-13188 would be a better xref for GO:0000254 C-4 methylsterol oxidase activity (=EC:<IP_ADDRESS>)
id: GO:0000254
name: C-4 methylsterol oxidase activity
namespace: molecular_function
def: "Catalysis of the reaction: 4,4-dimethyl-5-alpha-cholesta-8,24-dien-3-beta-ol + 6 Fe(II)-[cytochrome b5] + 5 H+ + 3 O2 = 4-beta-hydroxymethyl-4-alpha-methyl-5-alpha-cholesta-8,24-dien-3-beta-ol + 6 Fe(III)-[cytochrome b5] + 4 H2O." [PMID:9811880, RHEA:55220]
comment: Note that zymosterol is cholesta-8,24-dien-3-ol.
synonym: "4-methylsterol oxidase activity" EXACT [EC:<IP_ADDRESS>]
synonym: "methylsterol hydroxylase activity" RELATED [EC:<IP_ADDRESS>]
synonym: "methylsterol monooxygenase activity" RELATED [EC:<IP_ADDRESS>]
xref: EC:<IP_ADDRESS>
xref: MetaCyc:<IP_ADDRESS>-RXN
xref: RHEA:55220
is_a: GO:0016716 ! oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, another compound as one donor, and incorporation of one atom of oxygen

Also need to tweak current def to match EC/RHEA.


Document workflow

Create documentation for the entire software development lifecycle:

Issue Creation
Branch naming
Commit Structure
PR Process
Test framework (if any)
Version Management

Added documentation for all of these items except testing. That will be covered in the next milestone.


missing step from tutorial

@Coners could you make a pull request to address this? This would make a great open source contribution ✨

I could.. trouble is I couldn't get it to work at all and pulled it and just made a View Controller with images in a column.. not ideal.. I was in swift 5 code 10.4 and there were so many red warnings I gave it 4 hours of my life .. two complete installs.. then just binned it :/

I'm fleshing out the provided example that goes into more detail about the UICollectionViewDelegate and UICollectionViewDataSource protocols. I'll add this change in!

This issue was addressed in #48


Some unit test improvements.

Increased max attempts to spin a Voldemort server in tests from 3 to 10.
Made Voldemort's Time implement Tehuti's Time for easier inter-op.
Fixed a bogus test in DataCleanupJobTest (it was actually failing silently without any assertions).

Was it merged in and just the review needs to be closed ?

I think this change cannot be merged as is. The increased number of attempts for spinning up test servers is already addressed by another commit, IIRC. There is also the discussion on the thread interruption which remains open. It would be worthwhile to drive this to completion so that we get the fix to the DataCleanupJobTest.


Implement helper functions to retrieve ssl paths

Mainly designed to target apache::vhost ssl attributes, these helper functions have been split to be used in various context (mail, nginx, etc.).

What about merging all the code in a single function instead of spreading it in multiple files?
Split functions allow more usage : you can directly use dehydrated::ssl_cert_file directly, for example.

I integrated a new test to custom etcdir

Discussion about chain or fullchain must be closed before merge.

LGTM, feel free to squash the commits when you are ready to merge this!


Restyle the look of application

In responsive view
In mobile the clear button is not placed properly

Sure @aryandeelwal take your time


Add docs on substitutes for dynamic recomposition

@AArnott,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #32 into v15.3 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            v15.3      #32   +/-   ##
=======================================
  Coverage   83.85%   83.85%
=======================================
  Files          70       70
  Lines        5338     5338
  Branches      831      831
=======================================
  Hits         4476     4476
  Misses        635      635
  Partials      227      227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a550b4...f093207. Read the comment docs.


What is the commonly used trascription alphabeta? IPA or ARPA

As mentioned in the title, Do any one know the mostly used alphabeta for Phoneme-based Language Model training? not only the XPhoneBERT.

According to my previous surveys, IPA seems to be more preferred.


Set up provisioning playbook to recreate Dramble on DigitalOcean

Since I'd like to compare baseline Raspberry Pi 2 performance to a 'real' infrastructure setup in the cloud, I'd like to add a DigitalOcean provisioning playbook that builds the servers with 1 GB RAM, 1 CPU, 30 GB HDD, and Debian 7, so I can deploy to them and run performance benchmarks.

FYI, a little informal benchmarking on a set of 1 GB DigitalOcean droplets:
$ wrk -t4 -c24 -d30 http://pidramble.com/
Running 30s test @ http://pidramble.com/
  4 threads and 24 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.01s   698.37ms   3.24s    63.50%
    Req/Sec     5.87      2.08    11.00     65.00%
  770 requests in 30.01s, 2.79MB read
  Socket errors: connect 0, read 0, write 0, timeout 10
  Non-2xx or 3xx responses: 17
Requests/sec:     25.66
Transfer/sec:     95.24KB

So the DO cluster (unoptimized, and I just got everything going on it) is almost 2x faster than the Pi cluster (for this CPU-bound task). Not bad at all!


Removed unwritten section of the documentation.

Summary of changes

This commit involves removing of the unwritten sections of the documentation which refer to deprecated things.
Closes
#1701
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in changelog.d. See documentation for details

@DumbMachine Thank you for your contribution, can you add a news fragment for this?

Here, I have made the new fragment for the change. Let me know if it requires any changes.


Add Anchorpoint to GUI Clients Page

I've added our client anchopoint.app, the artist friendly git client.
I tried to get my head around the ordering, but there are lots of unsorted & dead projects. Getting the ordering right is super tedious. After stumbling upon https://github.com/git/git-scm.com/pull/1706, I've decided to keep it that way. I'd suggest merging https://github.com/git/git-scm.com/pull/1706 first, then I can rebase my changes.

#1706  has been merged. care to rebase @jochenhz ? :)

@pedrorijo91 this PR is now tracked here: https://github.com/git/git-scm.com/pull/1716


VEX validation error for rocket

 INFO [2023-08-31 12:16:02,551] VEX file containertests/sbom-rocket-universal.vex.json generated successfully
None is not of type 'string'

Failed validating 'type' in schema['properties']['vulnerabilities']['items']['properties']['affects']['items']['properties']['versions']['items']['properties']['version']:
    {'description': 'A single version of a component or service.',
     'maxLength': 1024,
     'minLength': 1,
     'type': 'string'}

On instance['vulnerabilities'][22]['affects'][0]['versions'][0]['version']:
    None

version_used is None here somehow
https://github.com/AppThreat/dep-scan/blob/06709ce5b2b20c639e61cdca14bebc85cbe91f5b/depscan/lib/analysis.py#L425

@prabhu I think the version_used is None due to  the parse_purl method in vdb.utils. In trying to replicate this issue, I am noticing that if the purl is used to set fields and it is malformed or incomplete, there is no default value to fall back on.
Under normal circumstances, a dictionary with a length of 6 is returned from parse_purl. In this example, the first attempt to set field values fails, and we parse the string again but only set namespace.
Example:
input purl string: 'pkg:swid/{AppUp.IntelGraphicsExperience_1.100.5185.0_x64__8j3eq9eme6ctt?ms-resource-//AppUp.IntelGraphicsExperience/Resources/System_Item_Title_IntelGraphicsControlPanel'
returns: {'namespace': 'Resources'} when it should also have entries for type, name, version, qualifiers, subpath.
result: The program subsequently errors out when name is assigned a value of None and we then try to call name.lower(). Since we wouldn't call lower() on version,, we can end up with None for versions in vex files as the program will not error out.
I'll make changes to set a default value of "" to avoid this eventuality, and see if there are any improvements I can make to on reparsing the data.

https://github.com/AppThreat/vulnerability-db/issues/67


chore: rename packages in /sdk module

Description:
TBD
Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Hey @jjohannes , do you think it's possible to rename the packages to without breaking the example module?

Renaming a package is technically changing the API. To be consistent, we need to rename everything at once in my opinion:

The packages in sdk

All usages of classes from the packages in tests and examples

The Java Module Names here and here
The group for the Maven Coordinates here (and here in publishing CI config).

Users that switch to the new Hiero version of the SDK will have to adjust there imports to the new package(s). But the classes themselves will work as before. Only the imports need to be adjusted.

@jjohannes I don't know why the examples are not building, i haven't touched them. Do you have any ideas?

I don't know why the examples are not building

With the rename, the examples now automatically use the last published version of the sdk (2.46.0).
That version is without the recent Guava/CheckerQual version update. But the build setup used for the example expects a newer version due to our strict Java Module setup. The newer version has a module-info and this is now expected.
You can update the Guava version in the example directly – dependency constraints block – to make it work with the previous version:
(Not this is only an issue in our strict checking setup, for users of the SDK without these strict checks, the example works)
dependencies.constraints {
    implementation("com.google.guava:guava:33.3.1-android")
    ...
}

The package for the protobuf-generated classes should probably also be changed:
See: https://github.com/hashgraph/hedera-sdk-java/blob/main/sdk/src/main/proto/account.proto#L28-L29
And all other proto files
The content of sdk/build/classes/java/main after building, shows if you still have any com.hedera classes.


Problem in Showdown

If you look at slide 15 in my presentation, there is a problem with Showdown not parsing # overskrift properly when inside a div. This is the code:

  # overskrift

which gets parsed into:

# overskrift

instead of the expected:

overskrift

Showdown however handles lists, urls and other markup inside divs as you can see on the same slide in my presentation.

Actually, parsing Markdown inside a div appear to not be a part of Gruber's implementation, but it is implemented in several Markdown parsers by setting markdown="1" on the div. However, on coreyti/showdown it is specifically noted that this is not supported in Showdown, but that the implementation should be "smart enough" too handle this syntax.
Which version/fork of Showdown is used in remark? I see that attacklab.net/showdown is down and that coreyti/showdown has not added any commits since April, even though there are 3 pull requests present. I thought about checking the code, but I don't want to start before I know which fork is used.

I believe this is the one: https://github.com/coreyti/showdown/blob/master/compressed/showdown.js

Okey, I might have to fork that project and see if I find a solution to the problem. The coreyti fork appears to not be maintained anymore, so we might need to use my fork in remark if I fix the problem.

Nice. Also, it seems indented headings doesn't work either, e.g.       # heading.

Ah, det er det som er bug-en jeg også kom over. Når jeg fjernet space-ene, fungerte overskriften i div-en. Skal få fikset det i Showdown.

I think evilstreak/markdown-js#3 is still a blocker for changing to that library. I'll look at the header indentation issue in Showdown. Hopefully it shouldn't be a problem.

Fixed by c4ec182c50ad01f8bab4619ff8fbc678590a4e2a.


Stubbed responses still call the network.

When I stub a provider, like
let SomeProvider = MoyaProvider<SomeAPI>(stubClosure: MoyaProvider.ImmediatelyStub)

the code in my app is stubbed fine, however it still calls the API.
Is there an easy and clear way to not have stubbed responses make any network calls?
These are typically backends that I'm building simultaneously with the app, so these stubbed calls are now creating unwanted data on my endpoint or creating strange glitches for endpoints that are still under development.
Apologies if this has already been addressed -- I just couldn't find a clear answer in the issues or docs.

Before all, there is nothing to apology, and thank you for addressing this issue :100:
The problem is probably from here, manager.request(urlRequest) will call resume() immediately.
In my opinion, this is a bug and should be fixed. I'll look forward and propose a PR to fix this.

That's unusual! And also bad! That shouldn't happen! A PR to fix this would be most welcomed. Hopefully there's a way to retrieve the AF request object without side-effecting.

I've opened an issue on Alamofire to get this sorted out. We'll see how it goes.
The problem appears to be how we structure the authentication plugins. Maybe we need to rethink the plugin architecture. Actually calling the network while stubbing seems like a serious issue and we should prioritize.

@cnoon has provided valuable feedback: https://github.com/Alamofire/Alamofire/issues/986 I believe we should follow their advice and use a custom manager instead of the shared one (while still allowing devs to pass in their own manager if they want).
Thoughts? Feels?

Hmm, solution is surprisingly simple😂 ... but it do solve our issue.  It's OK for me. I'll update PR #354 if there is no objection.

Sounds good, thanks! In the AF issue, they had some guidelines about how to create a manager with good defaults.
We also need to update our documentation to make it clear that we don't use the shared manager anymore. Since this is a breaking change, the next Moya version will be 6.0.0.

Yeah, in short terms, I think it would be suffice to modify ade1589 with default configuration:
    public final class func DefaultAlamofireManager() -> Manager {
        let configuration = NSURLSessionConfiguration.defaultSessionConfiguration()
        configuration.HTTPAdditionalHeaders = Alamofire.Manager.defaultHTTPHeaders

        let manager = Alamofire.Manager(configuration: configuration)
        manager.startRequestsImmediately = false
        return manager
    }

Yup! I would add a comment pointing to the issue, too, in case someone is curious.

Looks like this is fixed in the current master: https://github.com/Moya/Moya/blob/d2897a91ee3b92214fd6e8d7636cec96a019f2dd/Source/Moya.swift#L306-L314 Going to close, thanks again for opening and the discussion!


chore: bdd-ghfjxy-import-1584912004 to 0.0.1

chore: Promote bdd-ghfjxy-import-1584912004 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Upsun] project:init includes size key

Where size is no longer relevant

This is a duplicate of #176


[Network-Manager] Fix #7143: az network manager connect-config create/update: Fix to allow cross tenant resource id for --hub

Fix #7143

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Network-Manager


Feature- download option in lets draw project

Is your feature request related to a problem? Please describe.
hello, I want to add a download feature to the Let's Draw project so the user can download the painting he/she draws.
Describe the solution you'd like
it will be really beneficial if the user can download the memory he created by drawing on the canvas, I can convert the canvas element into a jpeg image using javascript and then provide the functionality to download it.
Additional context
I am one of the participants of GSSOC'21 it would be really helpful if you can assign this issue to me so I can work on it.
@Vishal-raj-1 @urvashi-code1255

@Engineervinay Sure go for it :)


NOT READY :  (collection_tools): Implement use_alloc feature, cover it with tests

<!-- // zzz : qqq : rid off `#[ cfg( not( feature = "use_alloc" ) ) ]` -->
<!-- // zzz : qqq : rid off `#[ cfg( not( feature = "use_alloc" ) ) ]` -->
// zzz : qqq : rid off `#[ cfg( not( feature = "use_alloc" ) ) ]`
// qqq : xxx : does not work for `use_alloc`, make it working

TODO

[x] Implement use_alloc feature, using alloc / hashbrown crates.
[x] Cover the feature with tests (tests from literally work perfectly)

not ready yet?


More accurate message

i was panicking thinking i deleted my godot project and couldnt get it back with recovery tools. nope, its just in system trash
hence this edit

See also https://github.com/godotengine/godot/pull/41263 and https://github.com/godotengine/godot/pull/47004. I don't know if these issues have been fixed since.

i could add preprocessor checks for !OSX_AVAILABLE to add that note, or specifically mention for linux that not all distros have trash enabled by default. tho im not sure on whether to bloat up the message like that or keep it simple

ironic


fix go.mod to use tagged releases

quick fix for #606

Codecov Report

Merging #607 (215200c) into main (16dba97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   61.70%   61.70%
=======================================
  Files          93       93
  Lines        4969     4969
=======================================
  Hits         3066     3066
  Misses       1581     1581
  Partials      322      322

Impacted Files
Coverage Δ

service/header/p2p_server.go
53.26% <0.00%> (-3.27%)
:arrow_down:

service/header/core_listener.go
57.69% <0.00%> (+5.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dba97...215200c. Read the comment docs.

unfortunately this is blocked on TestSyncLightWithBridge, TestSyncFullWithBridge, TestSyncLightWithFull, TestSyncLightWithTrustedPeers consistently failing.

OK, actually. Same tests above also fail here: https://github.com/celestiaorg/celestia-node/pull/612
So these failures are orthogonal to this PR. Though I think we must fix these tests asap instead of ignoring them.


fix(jest-jasmine2): point to inline snapshot documentation if prettier is unavailable

Summary
Use of inline snapshots requires the project to expose prettier. If prettier is not available, Jest currently fails with a message that does not indicate any required action on the user's part:

These changes append a brief message and a link to the inline snapshot docs to that message (I've since changed prettier to Prettier in the message):

Test plan
To be honest, I have no idea how to write a test for this. To verify the changes manually, I ended up removing the prettier dependency from a test project (https://github.com/theneva/post-utils), and:

Linked jest-jasmine2 into the test project
Made my changes to jest
Built jest
rm -rf node_modules/prettier in jest to prevent it being accidentally made available through the linked dependency
Ran yarn jest in the test project

If it makes sense to write an integration test for this, I'd be happy to do so if someone points me in the right direction :smile:

@theneva mind rebasing this and fixing it for circus as well? As for a test, I think the easiest might be to do prettierPath: 'some-module-that-does-not-exist' in an integration test

@theneva ping, pls rebase this

Closing, since this will soon be fixed by #7792. Thanks!


Added code to recursively replicate s3 bucket

script name - aws_s3_data_download.py
What have you Changed
I have added the code to download data present in a folder of a s3 bucket.
Issue no.(must) - #280
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS
acknowledgement

[x] I have tested the script and distributing it under MIT license.

Please review.


Why was this repository reverted from TM-Vec to DeepBlast?

We're separating out the repos.
On Wed, Aug 17, 2022 at 4:43 PM ArnNag @.***> wrote:

—
Reply to this email directly, view it on GitHub
https://github.com/flatironinstitute/deepblast/issues/105, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA75VXLK7WJ5LPXY7W32WB3VZVFG7ANCNFSM5624CJOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

TM-vec repository has been moved to https://github.com/tymor22/tm-vec to make maintenance more manageable


inspector: always try to pull new image

Fixes #14

@simon3z @pweil-

@enoodle @pweil- can we try to mimic the openshift pull policy through an option? E.g.
$ image-inspector ... --pull-policy [always|when-missing|never]

I am not sure if we need never though. If not then we can just have either --pull or --no-pull depending on what's the default behavior.

can we try to mimic the openshift pull policy through an option

Having all the options the kubelet supports seems reasonable to me with a failure when set to "never" and the image doesn't exist in docker.  Having never makes sense if you're running in a disconnected environment and it would just error out if you tried to pull.
const (
	// PullAlways means that kubelet always attempts to pull the latest image.  Container will fail If the pull fails.
	PullAlways PullPolicy = "Always"
	// PullNever means that kubelet never pulls an image, but only uses a local image.  Container will fail if the image isn't present
	PullNever PullPolicy = "Never"
	// PullIfNotPresent means that kubelet pulls if the image isn't present on disk. Container will fail if the image isn't present and the pull fails.
	PullIfNotPresent PullPolicy = "IfNotPresent"
)

@simon3z @pweil- Do you think we should copy those const definitions or import them from kubernetes? This is important as it might cause us to pull many things in and we need to decide if we want that. (This is the file that we will need to import, and all its imports and theirs..
https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go)

@enoodle I think you should copy them. Because you need a logic to handle them anyway (and importing a large library only for 3 constants that we're not even able to deal with dynamically, it seems a waste).

agree, just copy them in or make our own constants that are the same.

@simon3z @pweil- I moved the pulling logic to its own function and added the pull-policy argument with a default of "when-missing".

I think this is the first in line to be merged next. @pweil- can you review (or remind me if there's still something pending to fix). Thanks.

@simon3z one last question on the display of the skip message and all my feedback has been addressed. :+1:

@enoodle can you rebase? This seems nice to have.

@enoodle can you rebase? I want this in the next milestone. Thanks!

@simon3z Note the new default is going to be to use containers/image lib then we will always have to pull images. This is only effecting pulling with docker.

@simon3z Note the new default is going to be to use containers/image lib then we will always have to pull images. This is only effecting pulling with docker.

@enoodle I'd feel better if we had this meanwhile.


"scss-lint found no lints" sounds like an error

When you run scss-lint over good SCSS, you will see the message:

scss-lint found no lints

I was really confused by this message, because I thought it was an error message. I thought that maybe I had incorrectly configured it to exclude all linters. It took a while to figure out what was really going on.

I wouldn't say it's a confusing message... however I'd prefer the Unix Philosophy's Rule of Silence:

Rule of Silence: When a program has nothing surprising to say, it should say nothing.

As examples, ls, cd, grep, etc. follow this philosophy.

That would definitely resolve the issue.
For reference, this is what RuboCop prints after running:
Running RuboCop...
Inspecting 40 files
........................................

40 files inspected, no offenses detected

And this is what CoffeeLint prints:
  ✓ app/assets/javascripts/users.coffee
  ✓ app/assets/javascripts/documents.coffee

Both tools print green text that indicate the number or files which passed.

I’m closing this. You’re right—it’s not confusing. I just misread it as a configuration issue, thinking that “found no lints” meant “found no linters”.

For the record, I agree that a nice "no offenses detected" message would mitigate confusion here.

Rule of Silence: When a program has nothing surprising to say, it should say nothing.

:+1:

Duplicate of #655 (using that one as canonical as it has a more descriptive title).

:+1:


Update munit, munit-scalacheck to 1.0.0-M10

About this PR
📦 Updates

org.scalameta:munit
org.scalameta:munit-scalacheck

from 1.0.0-M8 to 1.0.0-M10
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Codecov Report
Patch coverage has no change and project coverage change: -0.18% :warning:

Comparison is base (10a338a) 84.92% compared to head (b55d2e8) 84.74%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                Coverage Diff                @@
##           series/0.14.x    #2198      +/-   ##
=================================================
- Coverage          84.92%   84.74%   -0.18%
=================================================
  Files                 76       72       -4
  Lines               2739     2695      -44
  Branches             368      368
=================================================
- Hits                2326     2284      -42
+ Misses               413      411       -2

Flag
Coverage Δ

2.12.18
84.74% <ø> (-0.04%)
:arrow_down:

2.13.11
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rename webpack output from bundle.js to json-formatter.js

Don't want to merge anymore? :)

Hi @PaulBernier I'll merge tonight PT.
Sorry got busy


remove unused tokio dependency

This removes unused dependency on new tokio crate. Considering amount of churn in tokio/futures lately, it makes sense to hold off from migration until both are more stable / proven, e.g. perf is degraded in new tokio as of today, hence hyper in TFB is on fixed pre-tokio crate versions of tokio-core and tokio-io.

closed in favor of https://github.com/MindFlavor/AzureSDKForRust/pull/35


toltecctl reenable when already installed

toltecctl reenable can mess up if it's already installed. Should we do some sort of check and then require a --force flag if we determine it's already installed?
https://discord.com/channels/385916768696139794/385922812121972737/917831080000761906

Yes


docs: postgres >= 13 has built-in  uuid function "get_random_uuid"

Following https://github.com/mikro-orm/mikro-orm/discussions/4403
Since Postgres 13 no additional module is necessary to use 'gen_random_uuid' function.

You forgot to update these lines:
  @PrimaryKey({ type: 'uuid', defaultRaw: 'uuid_generate_v4()' })

Should now be:
  @PrimaryKey({ type: 'uuid', defaultRaw: 'get_random_uuid()' })

It actually looks like both are working nowadays? I was checking the tests that used the uuid_generate_v4 and they are now passing even without enabling the uuid-ossp extension.

Ahh my bad!

Should now be:

Damn, now I know why it wasn't working for me! You got a typo in there, it's gen_random_uuid, not get_random_uuid. And looks like both gen_random_uuid and uuid_generate_v4 are supported nowadays.

I've renamed the pull-request title to gen_random_uuid indeed. Since both gen_random_uuid  and uuid_generate_v4  work @B4nan what do you prefer in documentation? Maybe gen_random_uuid (because it is what is displayed in postgres documentation), with a disclaimer saying that uuid_generate_v4  also works (for people already using it in their codebases, so they know why it works 😄 )?

I'd mention they both work since pg 13, and that in previous versions the extension was required.

The only issue with uuid_generate_v4() is that you need to manually run create extension if not exists "uuid-ossp"; in a migration, which isn't super obvious how to do if it is your first time. I think just recommending gen_random_uuid() in the docs is the way to go, and if someone needs more advanced uuid functions then they can hopefully find uuid-ossp on their own.


Can't GET from api via code but can via browser

My ruby code for this is very simple
require 'Faraday'
conn = Faraday::Connection.new 'https://api.fxtwitter.com/ALEKSEYR554_'
p conn.get

and everytime i get SSL_connect returned=1 errno=0 peeraddr=<IP_ADDRESS>:443 state=error: unexpected eof while reading (OpenSSL::SSL::SSLError) no matter what i do, but opening api link from browser works. GET from telegram bot api works with no problem. I tryed disabling ssl check when sending request, use firefox's cacert.pem nothing worked. And idk if it's problem from my side or server one bc I'm strugling with it for a week i guess. So maybe something went wrong with server, if not i'll look for solution

We're using Cloudflare if that helps at all. I'm not terribly familiar with Ruby or Faraday so I'm not sure if there's additional logging you can turn on and look at or if there are any known compatibility issues between Cloudflare's free SSL certs and Faraday.


[RD] Display Elevate Information when there are no errors on a namespaced org

Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

Tracking W-8549597


MatrixZarrLoader tests are unreliable

Describe the bug
The MatrixZarrLoader tests usually fail on a random one of the jobs in the github actions matrix (i.e., randomly fails for one of these):

Sometimes clicking "Re-run all jobs" will resolve the issue but other times it just fails for one of them again.
It seems like it has to do with  the tests being async and the npm run start:fixtures-concurrently script to serve the anndata-zarr store locally for cypress
To Reproduce
Steps to reproduce the behavior:

https://github.com/vitessce/vitessce/runs/5188095278?check_suite_focus=true

Expected behavior
Should pass on all jobs in the matrix.
Environment:

Release or git hash: 4e16e98
GitHub actions

I think the tests should not depend on a zarr store served via HTTP.
Instead, it should be mocked at a different level. For instance, using a mocked zarr store that is set as this.store here https://github.com/vitessce/vitessce/blob/eae9b02/src/loaders/data-sources/ZarrDataSource.js#L12

This commit https://github.com/vitessce/vitessce/pull/1160/commits/b5a8b7a53df27d318e7a75876d13b05ef38ea651 aims to be a temporary fix.


Unable to download symbols

I am unable to download symbols when generating a container. I am using the following with output, it can ping the container and access the webclient.
PS C:\Windows\system32\WindowsPowerShell\v1.0> New-NavContainer -accept_eula -imageName microsoft/bcsandbox:us
-containerName 'BCTest' -auth NavUserPassword
-updateHosts -doNotExportObjectsToText
-licenseFile c:\docker\kBC.flf -includeCSide
-useSSL -useBestContainerOS
-alwaysPull
NavContainerHelper is version <IP_ADDRESS>
Host is Microsoft Windows Server 2019 Standard - ltsc2019
Docker Client Version is 18.09.6
Docker Server Version is 18.09.6
Pulling image microsoft/bcsandbox:us-ltsc2019
us-ltsc2019: Pulling from microsoft/bcsandbox
Using image microsoft/bcsandbox:us-ltsc2019
Removing BCTest from hosts
Removing C:\ProgramData\NavContainerHelper\Extensions\BCTest
Creating Nav container BCTest
Using license file c:\docker\kBC.flf
Version: 14.0.29537.31808-US
Platform: 14.0.29530.31705
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.17763.437 (ltsc2019)
Host OS Version: 10.0.17763.107 (ltsc2019)
Using process isolation
Creating container BCTest from image microsoft/bcsandbox:us-ltsc2019
1c5cdcba231b71faa6702090d1c9011a98f28c4f0f2f2fea2586974b38daf4dc
Waiting for container BCTest to be ready
Initializing...
Starting Container
Hostname is BCTest
PublicDnsName is BCTest
Using NavUserPassword Authentication
Starting Local SQL Server
Starting Internet Information Server
Creating Self Signed Certificate
Self Signed Certificate Thumbprint 11BFF5A50B55F453C615848E06ADF19966430B0C
Modifying Service Tier Config File with Instance Specific Settings
Starting Service Tier
Registering event sources
Creating DotNetCore Web Server Instance
Enabling Financials User Experience
Using license file 'c:\run\my\license.flf'
Import License
Creating http download site
Setting SA Password and enabling SA
Creating super as SQL User and add to sysadmin
Creating SUPER user
Container IP Address: <IP_ADDRESS>
Container Hostname  : BCTest
Container Dns Name  : BCTest
Web Client          : https://BCTest/NAV/
Dev. Server         : https://BCTest
Dev. ServerInstance : NAV
Files:
http://BCTest:8080/al-3.0.106655.vsix
http://BCTest:8080/certificate.cer
Initialization took 71 seconds
Ready for connections!
Reading CustomSettings.config from BCTest
Creating Desktop Shortcuts for BCTest
Nav container BCTest successfully created
PS C:\Windows\system32\WindowsPowerShell\v1.0> ping bctest
Pinging bctest [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
When I try and download symbols in VS code using:

It sits there until it errors out saying:

You specified useSSL - and the output states that your dev. server is https://bctest
Yet you have http://bctest in your launch.json.
Try to add the s - or remove -usessl (really isn't needed when doing local development)

Thanks. I did not realize usessl, was on the development port, thought it was only on the web client.

Thanks for a very detailed issue description - it makes it so much easier to help people with descriptions like this.


chore: upgrade bsdtar to 3.7.4

Changes are visible to end-users: yes

Searched for relevant documentation and updated as needed: yes
Breaking change (forces users to change their own code or config): no
Suggested release notes appear below: yes

bsdtar is now version 3.7.4 and includes some improvements to how its compiled, see https://github.com/bazelbuild/bazel-central-registry/pull/1916
Test plan

Covered by existing test cases

This still uses the windows .exe from the libarchive distribution, so I guess that doesn't fix #848
@peakschris I think we need to change https://github.com/aspect-build/bsdtar-prebuilt/blob/main/.github/workflows/release.yml to also build .exe - not sure if we can cross-compile for that, or need to add Windows GHA runners

@alexeagle thanks for trying, sounds complex...

This still uses the windows .exe from the libarchive distribution, so I guess that doesn't fix #848 @peakschris I think we need to change https://github.com/aspect-build/bsdtar-prebuilt/blob/main/.github/workflows/release.yml to also build .exe - not sure if we can cross-compile for that, or need to add Windows GHA runners

i believe cross-compilation works now.

Nice, filed https://github.com/aspect-build/bsdtar-prebuilt/issues/3


save the embedding DataFrame

When running locally, the embedding needs to be calculated every time the same PDF is opened, which is somewhat wasteful. It would be best to save the embedding dataframe so that it can be checked before the next use. If the embedding has already been done, it doesn't need to be done again. Additionally, can the embedding dataframe be used as a search index in Zotero?

Hi @goldengrape I have added a way to store embeddings locally using redis. You can find that implementation here. You have to install redis and run redis-serve in a separate terminal for this to work


Add liveness probes to kured, bsc#1145904

Why is this PR needed?
Add initial delay for the liveness probe is intentionally large to
avoid an endless kill & restart cycle if in the event that the initial
bootstrapping takes longer than expected.
Fixes # bsc#1145904

I'm applying this on the 250 worker nodes where this issue occured. I'll try to reproduce once all the pods will be recreated with the probes.


Updated server list

Removed Fivem ( as Dan already announced in news ) and commented Storage because it's not ready yet and some people don't want to understand that

never seen ppl trying to create storage servers tho

never seen ppl trying to create storage servers tho

Quite a few people have asked/ tried to make some.

I Want storage servers!!!


Installation queries use enterpriseId even when not an enterprise install

The problem
Our app stops working for organizations that upgrade to Enterprise Grid.
The cause
This happens when an organization installs an app before they have an enterprise plan (where InstallationQuery.enterprise doesn't exist), and then upgrade to an enterprise plan (where InstallationQuery.enterprise does exist).
In that scenario, a previously stored installation wouldn't have the enterpriseId field, but new requests (events, actions etc.) will have the enterprise object on the InstallationQuery, so fetchInstallation won't find it.
The solution(?)
I think it would make sense to only use enterpriseId when isEnterpriseInstall is false, but I don't know all the considerations intimately like @seratch does. For Mongoose, where the queries are made against a single string field (__appOrgWorkspace__, see here: https://github.com/seratch/slack-bolt-extensions/blob/ef15b443dc429204b757c18bb017ea3047e7a183/packages/bolt-mongoose/src/MongooseInstallationStore.ts#L217) this will probably require a DB migration to work properly for existing installations (or more complex code to query by regex and filter in JS or something similar).
For us, we have previously ported one of the packages here so we can just make a change in our codebase, but we wanted to be good Samaritans and report this, and also get feedback.

Thanks for letting me know this, and I am sorry for my delayed response here. Indeed, supporting this use case would be a great plus.


support PEP 665 -- Specifying Installation Requirements for Python Projects

there's a new PEP about lockfiles https://www.python.org/dev/peps/pep-0665/
pip-tools should support it if the PEP is approved

yeah PEP 665 proposes a standardized lock-file (c. 2021)

Should we close this in favor of #1526?

There are more comments in the other issue so I'm closing this one.


  Thanks for the very clean implementation.  Worked great for me.

Thanks for positive feedback. :) Why not star the repo then? :)
We're also interested in success stories. I'm planning to update the web site. It would be nice to know who's using pywinauto.


LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

@Marcono1234, I am really thankful for all your reviews, not just this particular one. Would you mind sharing your real name, please, so that I can use it rather than Marcono1234 in changes.xml?
I see that you are reading through the sources, if I may say, up to its minute details. I am curious about your motivation. Would you liked to be involved in more? Do you have any other (architectural?) feedback too? If so, please don't hesitate to share them in the dev mailing list.

Would you mind sharing your real name, please, so that I can use it rather than Marcono1234 in changes.xml?

Thanks for crediting me! I am fine with changes.xml crediting me as Marcono1234, so unless that is an issue for you or the Apache Software Foundation, I would like to leave it as is.

I see that you are reading through the sources, if I may say, up to its minute details. I am curious about your motivation.

Some issues I raised were based on me using Log4j 2. However, this one I noticed through a CodeQL query. I have recently been experimenting with CodeQL and wrote a query for finding improper handling of NoSuchAlgorithmException (query can be found here), which spotted this method.

Do you have any other (architectural?) feedback too?

I have created some Jira issues in the past, but I don't have any extensive feedback to share.

If so, please don't hesitate to share them in the dev mailing list.

I am not a big fan of mailing lists, even though your "Pony Mail!" has a pretty neat web-interface. However, maybe I will change my mind regarding joining the mailing list in the future.


Restructure like prototype kit

This PR:

Moves all files into /app
Simplifies the Grunt copy task for govuk assets to govuk_modules
Does preparatory work for converting the template to use Nunjucks

This PR is to be merged after the Express 4 update.
cc. @joelanman, @robinwhittleton.

looks good to me - shall I merge?

Once the tests have run, yes please!


[WIP][ML Agent] Implementation of DBus Pipeline Interface

his patch implements the DBus pipeline interface.
Signed-off-by: Sangjung Woo<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #183. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @again4you, daemon/pipeline-module.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md


Arke bot stops on every 10 hours

Code: 422 Message: Unprocessable Entity

Take a look at rate limiting in arke and your balance. Also make sure that you have at least 4 peatio containers running. Sometimes peatio crashes because of too many requests from arke.

I am using microkube, do you know how to scale peatio to 4 containers?

docker-compose up -d —scale peatio=3 peatio

Balance is enough for arke, rate_limit is 0.2

Now I am trying with docker-compose up -d --scale peatio=6 peatio, also I suggest arke should exit on any error codes

It doesn't work again!

It doesn't work again!

Dont use REST as comm mean. You have options like

Event API (work best)
2 Websocket

We have developed Java based Arke integrated with CCXT and it has been running for at least 2 months now. Use RoR Arke logic to develop Java or even Golang based Arke. There are many examples here