Should I MAKE dmlc-core first? Or directly MAKE xgboost? Window7 + mingw64

Now I have some problems in compiling xgboost in windows7 + mingw64 environment.
I've referred two install tutorial.
The official tutorial tells me to MAKE xgboost directly. Then there are some problems.
I followed these process.
git submodule init
git submodule update
alias make='mingw32-make'
cp make/mingw64.mk config.mk
make -j4

The logfile is as follow.
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/c_api/c_api_error.o src/c_api/c_api_error.cc >build/c_api/c_api_error.d
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/data/simple_dmatrix.o src/data/simple_dmatrix.cc >build/data/simple_dmatrix.d
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/c_api/c_api.o src/c_api/c_api.cc >build/c_api/c_api.d
g++ -m64 -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -MM -MT build/data/sparse_page_raw_format.o src/data/sparse_page_raw_format.cc >build/data/sparse_page_raw_format.d
g++ -m64 -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/c_api/c_api_error.cc -o build/c_api/c_api_error.o
g++ -m64 -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/data/sparse_page_raw_format.cc -o build/data/sparse_page_raw_format.o
g++ -m64 -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/c_api/c_api.cc -o build/c_api/c_api.o
g++ -m64 -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude -DDMLC_ENABLE_STD_THREAD=0  -Idmlc-core/include -Irabit/include -fopenmp -c src/data/simple_dmatrix.cc -o build/data/simple_dmatrix.o
Makefile:97: recipe for target 'build/c_api/c_api_error.o' failed
Makefile:97: recipe for target 'build/data/sparse_page_raw_format.o' failed
Makefile:97: recipe for target 'build/data/simple_dmatrix.o' failed
Makefile:97: recipe for target 'build/c_api/c_api.o' failed

The screenshot is as follow.

Then I referred another Installing XGBoost For Anaconda on Windows
It tells me to MAKE dmlc-core first.
I followed these process.
git clone --recursive https://github.com/dmlc/xgboost
cd xgboost
git submodule init
git submodule update
alias make='mingw32-make'
cd dmlc-core
make -j4

Then it still had some problems.
The logfile is as follow.
g++ -c -O3 -Wall -msse2  -Wno-unknown-pragmas -Iinclude  -std=c++0x -fopenmp -fPIC -DDMLC_USE_HDFS=0 -DDMLC_USE_S3=0 -DDMLC_USE_AZURE=0 -o io.o src/io.cc
g++ -c -O3 -Wall -msse2  -Wno-unknown-pragmas -Iinclude  -std=c++0x -fopenmp -fPIC -DDMLC_USE_HDFS=0 -DDMLC_USE_S3=0 -DDMLC_USE_AZURE=0 -o data.o src/data.cc
g++ -c -O3 -Wall -msse2  -Wno-unknown-pragmas -Iinclude  -std=c++0x -fopenmp -fPIC -DDMLC_USE_HDFS=0 -DDMLC_USE_S3=0 -DDMLC_USE_AZURE=0 -o recordio.o src/recordio.cc
g++ -c -O3 -Wall -msse2  -Wno-unknown-pragmas -Iinclude  -std=c++0x -fopenmp -fPIC -DDMLC_USE_HDFS=0 -DDMLC_USE_S3=0 -DDMLC_USE_AZURE=0 -o config.o src/config.cc
Makefile:75: recipe for target 'recordio.o' failed
Makefile:75: recipe for target 'io.o' failed
Makefile:75: recipe for target 'data.o' failed

The screenshot is as follow.

Could someone tell me how to fix these problems/errors?
Since the directory /windows has been deleted. How to install xgboost on windows with mingw64?

Hi everyone,
I'm who raised this question.
I referred the third tutorial Install xgboost in windows X64 (in chinese)
I followed these process
git clone --recursive https://github.com/dmlc/xgboost
cd xgboost
git checkout 9a48a40
git submodule init
git submodule update

Then I succeeded.
This code is the key to success.
git checkout 9a48a40

Could someone tell me the function of this code? Why it works?

The reason is from MinGW and different distributions of MinGW might be inconsistent.
I will update the building instructions after some more testing.


storagecluster_apis: delete storagecluster doesn't cleanup the opened ports

ays error
Error of job: tcp!tcp_248a07e77520_2007 (install):
*TRACEBACK*********************************************************************************
Traceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/tcp/bd1a1e45c31da21bcd27a1f4faa88cfd.py", line 131, in install
    node.client.nft.open_port(service.model.data.port)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 1989, in open_port
    return self._client.json('nft.open_port', args)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 597, in json
    result = self.sync(command, arguments)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 587, in sync
    raise RuntimeError('invalid response: %s' % result.state, result)
RuntimeError: ('invalid response: ERROR', STATE: ERROR
STDOUT:

STDERR:

DATA:
"rule exists"
)

software version
master : 92d0ba0

software version
master : 9ab91704


Bower 'bin' folder possible renaming

I was looking to use this library for a production-level webapp, but we have strict filtering in place to not allow "bin" folders for security. We are using grunt to automate building and compiling external libraries through bower, and because of these constraints are having problems with this library. It is definitely possible for us to create a workaround in our Gruntfile as to rename the directory ourselves, but I thought I would suggest it as a fix in general because I have not come across other libraries in bower that use the bin directory for the final code. It seems to be more common that 'src', or 'release' is used.
I can understand not wanting to implement something like this so that it will not break anything for other users of the repository, just thought I would suggest it and see if it might be worth doing to keep consistent with other libraries distributed through bower.

I would agree, naming the artifact folder either build, release or dist
seems more appropriate. The name bin usually covers actual executable
javascript files.
What do you think, Martin?
Den 30/01/2015 21.32 skrev "ohmatt"<EMAIL_ADDRESS>
I was looking to use this library for a production-level webapp, but we
have strict filtering in place to not allow "bin" folders for security. We
are using grunt to automate building and compiling external libraries
through bower, and because of these constraints are having problems with
this library. It is definitely possible for us to create a workaround in
our Gruntfile as to rename the directory ourselves, but I thought I would
suggest it as a fix in general because I have not come across other
libraries in bower that use the bin directory for the final code. It seems
to be more common that 'src', or 'release' is used.
I can understand not wanting to implement something like this so that it
will not break anything for other users of the repository, just thought I
would suggest it and see if it might be worth doing to keep consistent with
other libraries distributed through bower.
—
Reply to this email directly or view it on GitHub
https://github.com/mvindahl/angular-pan-zoom/issues/30.

I have created a pull request with the new 'release' folder, but kept the 'bin' folder in tact at the moment, leaving it up to Martin to review and decide if he would like to include these changes. The 'bin' folder should be replaced by the 'release' folder, but I kept it in there to allow Martin to make the decision on keeping or replacing 'bin'.

Seems like a valid request to me. "Release" is a far more suitable name than "bin".
Also, as you point out, no reason to bother other users unnecessarily so I think we'll live with identical code in both the bin folder and the release folder until we do the next major version bump. I could drop a README file into the bin folder explaining that it is deprecated and that people might as well switch right away.
I think this approach would be the best way to fix the problem and keep everyone happy during the transition.

Awesome. Thanks for quickly responding to this as well. Are you able to update the bower configuration now as well? I'm not familiar with that process, so I didn't know if that takes time to update or what.

I'm bumping the version numbers to 1.0.5 in all file headers and in the bower file, I'm just double checking. Once I've committed, I'll add a semver tag in git and bower will pick it up. It's pretty slick.
And happy to be of assistance since you caught me watching silly YouTube videos in the couch anyway :)

Well, thanks again for the quickness. Enjoy the YouTube videos! :)

It's now up to 1.0.5 in the bower registry. Happy programming and have a nice weekend!


Update nitroshare to 0.3.4

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Running script.sh...

>>> brew cask _audit_modified_casks 9a0896aa839c6c80e29ca666e158a32a88219412...14001043bc0eef3cc926ee86f9044bfdce940c4e
==> 1 modified cask: nitroshare
==> Downloading https://launchpad.net/nitroshare/0.3/0.3.4/+download/nitroshare-0.3.4-osx.dmg
==> Verifying checksum for Cask nitroshare
audit for nitroshare: failed
 - only sha256 changed (see: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md)
Error: audit failed for 1 cask: nitroshare

$ gpg --verify ~/Downloads/nitroshare-0.3.4-osx.dmg.asc
gpg: assuming signed data in '[home folder]/Downloads/nitroshare-0.3.4-osx.dmg'
gpg: Signature made Sat 24 Mar 20:59:18 2018 GMT
gpg:                using RSA key A64C4C497081154C9F8F98008D66EFE14AD4CF87
gpg: Good signature from "Nathan Osman<EMAIL_ADDRESS>[unknown]
gpg:                 aka "keybase.io/nathanosman<EMAIL_ADDRESS>[unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 067D 9B60 E117 F795 983D  9BED 743C 5E1A B4A5 3FD1
     Subkey fingerprint: A64C 4C49 7081 154C 9F8F  9800 8D66 EFE1 4AD4 CF87

I found the signature file on the download page.


CP: Use random gcs bucket name (#33151)

Use random gcs bucket name

Linter fixes

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @claudevdm
We need this on our release branch to allow precommits to pass there


Handle empty object returned by nvim_buf_get_extmark_by_id

I was getting errors because sometimes it does give me nothing. Not sure how I could reproduce this though.

I just ran into this myself, fixed in HEAD.


feature: display more cards behind the first one

Description
If you want to use widgets in your cards that don't build instantly, like network images or videos, the cards might take time to appear and if the users swipe fast enough they might experience some lag.
I wrote this code that allows you to build more cards at a time and display them behind the front one, in order to help optimize perfomance and make navigation more fluid.
EDIT
I got tired of fighting with git rebase so I just created a clean new fork and applied my changes, closed the old PR and opened this new one
Related Issues
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.

Visual reference
without the feature:
https://user-images.githubusercontent.com/81298073/220890429-3a363c15-fb0d-4753-8e21-40b0c5c9dc4a.mp4
with the feature (numberOfCardsDisplayed =5):
https://user-images.githubusercontent.com/81298073/220890569-103f4106-3965-4477-947c-0b5e76f06bee.mp4

Your PR is really good, it will be a good addition. Thank you very much! I just left some comments, can you check them, please?

And don't worry about the CI, it breaks because it can't report tests from a fork. I'll fix that later.

Thank you for your review, I did everything you suggested!


Spawn-animation

Can you add a feature called "Spawn-animation" ? look at how the WoW bots spawn in this video for example https://www.youtube.com/watch?v=lNdQBWGik9g √

Some agario clones have it, however because it's client sided, a bug happens when you opened the menu while playing the game and press "Play" - the spawn animation would appear in the middle of the screen, but the cell wouldn't appear because you're already playing.

so you cannot do it?

Yep, it is client sided I'm afraid.

@Megabyte918 It kinda looks server sided to me like the server gives it the mass like 5 seconds after it spawns

@MineMooreALT chack the spawnPlayer function in GameServer.js, try setting the size variable to lower than playerStartSize by default, and then set a timeout on adding playerStartSize to the default size. But something like that would hinder performance.

can you put the lines in github for me so I can understand better thanks

@MineMooreALT https://github.com/Megabyte918/MultiOgar-Edited/blob/master/src/GameServer.js#L933-L976

@Megabyte918 I'm too fucking noob can you just do it for me

@MineMooreALT
Change this line to size = 32;
Then under this line add the following code:

var self = this;
setTimeout(function() {
    cell.setSize(self.config.playerStartSize);
}, 2000);

Players will spawn with 32 starting size by default, then after 2 seconds their size will be set to the value of playerStartSize.

It fucked up bad lmao can you make a separate code for minions because there spawning with 132 mass then going to 43 mass

nvm i fixed it

@MineMooreALT  Plz, give me the code!


ui: Fix detection of narrow window.

Fixes #17280.

Testing plan:
GIFs or screenshots:

Merged, thanks @nishantwrp!


mistralai/Mistral-Nemo-Instruct-2407 vllm-server crashes

vllm server consistently crashes while processing lm-eval requests:
INFO 10-01 09:52:39 engine.py:288] Added request cmpl-270a6c19d13b4fb6aac151b9c8ba44c2-0.
ERROR 10-01 09:52:48 client.py:244] TimeoutError('No heartbeat received from MQLLMEngine')
ERROR 10-01 09:52:48 client.py:244] NoneType: None
INFO 10-01 09:52:48 metrics.py:351] Avg prompt throughput: 2443.7 tokens/s, Avg generation throughput: 4.3 tokens/s, Running: 0 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.0%, CPU KV cache usage: 0.0%.
INFO:     ::1:39238 - "POST /v1/completions HTTP/1.1" 200 OK
CRITICAL 10-01 09:52:48 launcher.py:99] MQLLMEngine is already dead, terminating server process
INFO:     ::1:58624 - "POST /v1/completions HTTP/1.1" 500 Internal Server Error
INFO:     Shutting down
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.
INFO:     Finished server process [2440238]
INFO 10-01 09:52:48 multiproc_worker_utils.py:137] Terminating local vLLM worker processes
(VllmWorkerProcess pid=2440870) INFO 10-01 09:52:48 multiproc_worker_utils.py:244] Worker exiting
(VllmWorkerProcess pid=2440872) INFO 10-01 09:52:48 multiproc_worker_utils.py:244] Worker exiting
(VllmWorkerProcess pid=2440871) INFO 10-01 09:52:48 multiproc_worker_utils.py:244] Worker exiting
/usr/lib/python3.12/multiprocessing/resource_tracker.py:254: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/usr/lib/python3.12/multiprocessing/resource_tracker.py:254: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '```

Related?
https://github.com/vllm-project/vllm/issues/7532


[MiniLLM] Got different results from validation during training and testing after training using the same data

Hi, I just found that when I used the validation set for testing (i.e., running the run_eval.sh), I got a lower Rouge-L result than the one in validation during training. For example, gpt2-base SFT got 25 v.s. 24 during validation and testing. And things also happen for other test sets. So is there any difference between these two processes in your code?

Update: I just found that the difference was in GenerationConfig, where the no_repeat_ngram_size is set to 6 (by default) in testing https://github.com/microsoft/LMOps/blob/daf972124f0699af18acee85473fece80fb405c2/minillm/evaluate_main.py#L57 and is not set in validation.
So is it necessary to use this parameter? It may lower the final Rouge-L score by over 1 point.

We find that the model sometimes outputs repeated stuff after SFT. Therefore, we use this parameter in evaluation. In validation, since we only compare the checkpoints from different steps, we did not use this parameter to keep the process simple.

We find that the model sometimes outputs repeated stuff after SFT. Therefore, we use this parameter in evaluation. In validation, since we only compare the checkpoints from different steps, we did not use this parameter to keep the process simple.

Thanks for your reply!


[MINOR] fix typo

Change Logs
fix typo
Impact
no impact
Risk level (write none, low medium or high below)
none
Documentation Update
fix typo the word "deserialize" in class InternalFilter
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure

@hudi-bot run azure

@hudi-bot run azure

@hudi-bot run azure

@hudi-bot run azure

Hi @bvaradar ,thank you for reviewing my PR, it is my first time participating in the Hudi project, I will contribute more efforts to this project in the future.


[feathr] Move pyspark into test requires

Most users with Azure already have pyspark dependency and pyspark is pretty large. So take it out from dependency and move to test for now.

This is dep move change and blocks the client. So commit with one approval.


spike: investigate react error boundaries

React's default error handling is very coarse-grained: it logs to the console and unmounts the page (under the assumption that no page is better than leaving things in a broken state).
We can use the provided Error Boundaries to refine this a bit, in order to better report or recover from certain errors. We should do some research to figure out what's possible here, and what our strategy should be.
The output of this spike should be another ticket to implement the chosen strategy.

Conclusion:
Error boundaries allow us to catch exceptions that happen during render or lifecycle methods. These almost always represent a bug, and are not easily recoverable. We don't see many of these (fortunately), but when they do happen, we can use this mechanism to report the error gracefully and offer a button to refresh the page.

Spike completed, resulting in #639


[release 2.5] upgrade vulnerable libraries

Signed-off-by: Subbarao Meduri<EMAIL_ADDRESS>

/lgtm

/lgtm


Made icons from Dive into the world of Development section clickable

Description
I have made icons from the 'Dive into the world of Development' section clickable by adding hyperlinks to them to their respective websites.
👇
https://user-images.githubusercontent.com/85431456/198599402-9f33efb2-2b4a-4430-a50a-499fd6586570.mp4

Issue Ticket Number
Fixes #385

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[X] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[X] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes needed to the documentation

Congrats @durgeshm01722 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

My Profile URL - https://www.clueless.tech/profile/103863839958922066506
PR merged by - @Debajyoti14


Error with Angular 8 - 'allowSyntheticDefaultImports' flag

I just updated from vis to vis-network (I only need vis-network since I only use graph in my app) while updating to Angular 8. When I try and compile the app, I get an error:

This module can only be referenced with ECMAScript imports/exports by turning on the 'allowSyntheticDefaultImports' flag and referencing its default export.

in ../node_modules/vis-network/dist/types/index.d.ts:18:25.
Complete error:

ERROR in ../node_modules/vis-network/dist/types/index.d.ts:18:25 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'allowSyntheticDefaultImports' flag and referencing its default export.
18  import * as moment from './module/moment';
../node_modules/vis-network/dist/types/module/moment.d.ts:1:8 - error TS1259: Module '"%LOCATION%/angular/node_modules/moment/moment"' can only be default-imported using the 'allowSyntheticDefaultImports' flag
1 import moment from 'moment'
../node_modules/moment/moment.d.ts:736:1
736 export = moment;
This module is declared with using 'export =', and can only be used with a default import when using the 'allowSyntheticDefaultImports' flag.

vis-network version: 5.2.1
Browser: Chrome 76.0.3809.100, Windows 10
My tsconfig.json:
"downlevelIteration": true,
"outDir": "./dist/out-tsc",
"baseUrl": "src",
"sourceMap": true,
"declaration": false,
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"target": "es2015",
"typeRoots": [
    "node_modules/@types"
],
"lib": [
    "es2016",
    "dom"
],
"paths": {
    "core-js/es7/reflect": ["../node_modules/core-js/proposals/reflect-metadata"],
    "core-js/es6/*": ["../node_modules/core-js/es/*"],
    "core-js/es7/*": ["../node_modules/core-js/es/*"]
}

My package.json (omitted Angular stuff):
--- Angular stuff 8.2.2
"core-js": "3.2.1",
"file-saver": "2.0.2",
"ng2-pdf-viewer": "5.3.3",
"ngx-moment": "3.4.0",
"node-sass": "4.12.0",
"numbro": "2.1.2",
"rxjs": "6.5.2",
"typescript": "3.5.3",
"vis-network": "5.2.1",
"web-animations-js": "2.3.2",
"xlsx": "0.15.0",
"zone.js": "0.9.1"

I just don't see any solution here. Moment is UMD and therefore doesn't work without synthetic default import. I'm open to suggestions though.

This should help:

try adding "allowSyntheticDefaultImports": true in compilerOptions in your tsconfig.json file and then use the syntax

via https://github.com/moment/moment/issues/4397
Or try setting the esModuleInterop flag to true.

With flag esModuleInterop we can import CommonJS modules in compliance with es6 modules spec

via https://stackoverflow.com/a/56348146/722162

Ok, so after testing I can confirm that adding any of allowSyntheticDefaultImports or esModuleInterop to true works. I figured any of those would work, but I didn't want to add them because of moment (which I kinda don't care about)...
I guess we can wait a bit more and see if someone has a different approach, if not then I will close this issue since this fixes it...

Can the es6 export/import syntax be used in the moment type module file?
import * as moment from 'moment';
export default moment;

Hi @JKostov,
no this doesn't work. In the end you are still importing UMD module and that just doesn't work without allowSyntheticDefaultImports.

Bottom line, is there a way to use it with Angular8 without losing some of the Angular 8 benefits (by updating tsconfig)?

What benefits do you lose by enabling synthetic default import? I thought Angular is bundled by Webpack which should handle this transparently without causing any issues.
But if you really don't want to enable it the problem is only in the types (if you use the ESM bundle the code is already converted into ESM). You can convert /…/node_modules/moment/moment.d.ts into ESM format if you want (since I've never tried to do anything like this there's probably a better way to achieve the same result than editing a file that will be repeatedly overwritten by npm).

Since this issue seems to occur only for moment module, if (and when) it is removed then this should work without need for allowSyntheticDefaultImports. There is an issue already created for removing moment (#97) so you can track the progress there.
I will also close this issue since I don't see a reason for not using any of the allowSyntheticDefaultImports or esModuleInterop options.

I am having this problem and I have tried the solutions above but none worked for me. Any idea of what I am doing wrong. It's an angular 8 project.
ERROR in node_modules/vis-network/dist/types/index-legacy.d.ts(18,25): error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'allowSyntheticDefaultImports' flag and referencing its default export.

Any sugestion can help, thanks.

Hi @ricardomga,
do you really need the legacy build? The peer and standalone builds don't reexport Moment at all. Maybe that would help. Also check that you set allowSyntheticDefaultImport in the tsconfig that is actually being used. I don't know much about Angular so this is pretty much all I can say.

Hi @Thomaash thanks for the reply. The  allowSyntheticDefaultImport didn't work for me. I am using the package ngx-vis in my angular app. I don't need the legacy build. but how can I ignore it?

In case your using ngx-vis you should create an issue at https://github.com/visjs/ngx-vis/issues/new/choose. I don't have much of an insight into that.

you have to add allowSyntheticDefaultImports "true" in the tsconfig.json  like tis
  "compilerOptions": {     "allowSyntheticDefaultImports":true, }

As of today, is this still an issue? I mean, if I have a .d.ts TypeScript file referencing the Moment type of moment, do I need to add "allowSyntheticDefaultImports": true to my tsconfig.json? E.g.:
// index.d.ts
import moment from "moment"; // Import moment typings

declare module "my-package" {
  type Dictionary<K extends string, T> = { [P in K]?: T };

  type Moment = moment.Moment; // Reference the Moment type from moment

  // ...
}

Is the only option I have to add "allowSyntheticDefaultImports": true to tsconfig.json or are there any alternatives (perhaps, which would not involve editing tsconfig.json)?
Thank you!

Hi @tonix-tuft and anybody else still tracking this,
we're removing Moment from everything except Vis Timeline (where it's actually used, there were deprecation warning for quite a long time) right now, so this won't be necessary anymore (also, since Moment wasn't actually used at all, less bloat in the bundle).

allowSyntheticDefaultImports

Its works.

This helped us:
Creates some file moment.constant.ts and put this inside:
import * as moment_ from 'moment';
export const moment = moment_;

And then you can use:
import { moment } from 'moment.constant';


Volto - Bootstrapping Plone

In the chapter 3, you say that we need a working Plone instance.
Maybe there are some students that don't know what exactly they need to do.
I tried with a Plone 5.1.4, but i needed to add some extra informations:

plone.restapi
a Plone site with a specific name (Plone) that responds to 8080 port with plone.restapi installed
a conf in instance part to avoid CORS problems

Could it be useful for the students, a link to volto /api section where there are a buildout and docker image ready-to-go? And maybe some infos about how to bootstrap it?

Closing as won't fix because this training has been archived.


US ID24: As a fooled player, I want to see randomly growing bubbles in order to get confused through the other players.

Note: This is part of the game mode ‘trust or bust’ and should be only active, if that was chosen in the game room.

[ ] The bubbles still grow only if another player selects an answer.

[ ] Non-chosen players are not affected.

[ ] For the users who didn’t get selected, if a user chooses a question the right bubble will still always grow.

proposed additional tasks:
Backend:
generate random votes in to be sent to the fools


Replace CloudSdkProjectPropertyTester with expression

@briandealwis 's suggestion:
rather than define our own property tester in com.google.cloud.tools.eclipse.appengine.localserver.deploy.CloudSdkProjectPropertyTester, it's probably better from an extensibility perspective to provide an expression definition (org.eclipse.core.expressions.definition) so we can vary the implementation
WTP provides a facet property tester

custom runtime is gone


Support for installing logging

We need to support installing and setting up Logging stack on OCP post install to be able to test it.

The logging setup can be part of the benchmark in https://github.com/cloud-bulldozer/e2e-benchmarking to avoid any dependency on clusters being installed by scale-ci-deploy.

The logging setup can be part of the benchmark in https://github.com/cloud-bulldozer/e2e-benchmarking to avoid any dependency on clusters being installed by scale-ci-deploy.


Enable WarnAsError for official builds

Fixes a few existing warnings:

Disables semver 2 nuget package version warning
Commented out some test code that is giving warnings
about not being marked as Fact. Will fill a follow-up
issues about those tests.

@Azure/azure-sdk-eng

Filed issue https://github.com/Azure/azure-sdk-for-net/issues/5352 to track the KeyVault test methods I commented out.


Search engine problems

When you try to use the search engine to find files, it never finds the files

Yes, indeed.
Already use everything toolbar to mitigate this.

Yes, indeed.
Already use everything toolbar to mitigate this.

Does turning on the setting to search un-indexed items improve this behavior?

Does turning on the setting to search un-indexed items improve this behavior?

Does turning on the setting to search un-indexed items improve this behavior?

Ready, the search works for me, thanks

Does turning on the setting to search un-indexed items improve this behavior?

Ready, the search works for me, thanks


Suggest to launch Chinese version

first of all I apologize to you. My English is not very good. So my statement may be wrong, I am very sorry. I am a Chinese user. When I found your software, I fell in love with it. I found it to be very easy to use compared to geek. I recommended this software to my Chinese friends. But their English is not good. They can't understand this software, can your company develop a Chinese version? Because this app does not have Chinese, it cannot be promoted well in mainland China. And many people do not know the software. I hope you can launch the Chinese version here. thank you very much.

You can apply for the translation volunteer program

If you open file CONTRIBUTING.md you will find small manual how to contribute in translating this fantastic program. So yes there is the way how community can make translations of this application.

Unfortunately I know no Chinese and I'm a single guy so I don't have the resources to manage a translation myself. If you want to help translate BCU to Chinese, please check the contributing file mentioned above.

Should be solved by https://github.com/Klocman/Bulk-Crap-Uninstaller/commit/9a4f7942309a93df35ed52a31eb2d0364d4d1444


BUG: binary file raw download result in wrong format

when there's binary file in repository, plain view output incorrect format, rendering file unable to execute.

Thanks, fixed by https://github.com/w4/rgit/commit/fcc1871e12c33527e2f766238ca9232a18a4c743


'rangedRegions' is only available in Mac Catalyst 14.0 or newer

There seem to be an issue on Mac Catalyst. I get the following errors compiling for Mac Catalyst:
'rangedRegions' is only available in Mac Catalyst 14.0 or newer
and
startRangingBeacons(in:)' is only available in Mac Catalyst 14.0 or newer
and
'stopRangingBeacons(in:)' is only available in Mac Catalyst 14.0 or newer
There options are only available (and deprecated) in iOS 14. The framework however targets iOS 11, which gives the error.
These checks should either be conditionalized for iOS 14 or better "iOS or MacCatalyst14"

Thank you, I've just merged your PR


polyfill symbol in BlackBerry

@JakeChampion being deliberately conservative with versions given the compatibility problems we've had with symbol before. FT only needs v10 covered. If others want to invest time in verifying Symbol and related polyfills don't blow up in BB<10 then config can be modified in future PRs

@wheresrhys Do you have screenshots of the tests passing on BB10?

not of the tests, but ft.com is fixed by forcing Array.from and Map to be bundled on BB10, which is reasonable evidence that this is ok. I'll work on running the tests this afternoon though

https://mail.google.com/mail/u/0?ui=2&ik=072fc90e6a&attid=0.1&th=1579069e5bc84b13&view=fimg&disp=thd&attbid=ANGjdJ8nTt0JZiou59_R_PeeH-kVedI021rUQWUkW6TK58XMsXEeZ2q3x931i4qpf_ZDuJ9AG_uCgRKshnIqAPaUY6foObEvYf9UL0uoJu01pQXyr4iX5_31rjTHTLI&ats=2524608000000&sz=w2460-h1360

@wheresrhys This is now live on http://qa.polyfill.io - would you be able to report back whether we have fixed your issue?


add darkhorse call for candidate genomes

Coverage increased (+0.3%) to 93.539% when pulling 830f263f73887616a0dd21b7c24baa4513223f5a on ekopylova:issue_23b into ae432b5ca8893afee274bd20a2f104eca69e7fd1 on biocore:master.

👍  don't have any other comments

Coverage increased (+0.3%) to 93.539% when pulling 2a7cf1842f35186446934db212cd160e5f79127b on ekopylova:issue_23b into ae432b5ca8893afee274bd20a2f104eca69e7fd1 on biocore:master.


Add remove functionality on mention input

If i mentioned someone like, @mentionName then if we want to delete any letter from mention text it should be deleted that whole word or start searching again(as use by github.com)..
I am on big trouble Please help me out..
Thanks

@vikas-git - my current fork has fixed it so that when you delete a character, it searches again: https://github.com/richjeffery/jquery-mentions-input


Object Viewer

Descriptive summary
UMedia needs a more user friendly object viewer. The functionality of something like universal viewer is highly desirable. An (ideal) key feature of this viewer is the ability to set 1up or 2up page view at the object-level during upload.
In other words, can TB as the person who uploads material, set the viewer to 1up or 2up based on the content /format to better help the user navigate the object. Further thoughts on this:
Does this become a manual switch that happens during upload?
Can we set up a rule where this is determined by a specific field in CDM? (Specific values in the format field, for example, trigger 1up or 2up; example: photograph = 1up; journal = 2up, etc, etc)

Duplicate of #82


Increase number of http connections for gcp

depends on #163

Codecov Report

Merging #164 into xbrianh-gcp-refactor will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##           xbrianh-gcp-refactor     #164      +/-   ##
========================================================
+ Coverage                 88.09%   88.16%   +0.06%
========================================================
  Files                        13       13
  Lines                       865      870       +5
========================================================
+ Hits                        762      767       +5
  Misses                      103      103

Impacted Files
Coverage Δ

ssds/gcp.py
84.00% <100.00%> (+4.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ccfc8...ad99b13. Read the comment docs.


Update dependabot version updates rules

Codecov Report
Patch and project coverage have no change.

Comparison is base (9789ac6) 81.62% compared to head (9b6e5f0) 81.62%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   81.62%   81.62%
=======================================
  Files           8        8
  Lines        1105     1105
=======================================
  Hits          902      902
  Misses        166      166
  Partials       37       37

Flag
Coverage Δ

local
81.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


data.py: Add sys.prefix in the paths for unix

This is already present in Windows but not for Unix. Hence
Anaconda in Unix doesn't work easily.

@AbdealiJK thank you for proposing this PR. But adding the paths added in this PR might not be desirable, it might be better to advise users to optionally set the data path with nltk.data.append() if needed.
In Unix,

 os.path.join(sys.prefix, str('nltk_data')) will usually point to /usr/nltk_data

I don't think nltk_data should go into that /usr/, it might cause permission problems and might possibly allow malicious stuff

 os.path.join(sys.prefix, str('lib'), str('nltk_data')) will usually point to /usr/lib/nltk_data

which is already on L107

@alvations consider the case when nltk is not installed to the system python but in an anaconda or pyenv python.
In anaconda python the /usr is not sys.prefix

But this should not affect where the nltk_data directory is stored. Perhaps I'm mistaken. Maybe someone with more experience with Anaconda should take a look at this PR =)

sys.prefix for anaconda is: ~/anaconda (the anaconda location)
sys.prefix for system python is: /usr
When using anaconda you want all your files to be modularly kept inside the anaconda folder and not in the system folder. The anaconda folder mimics some of the paths available in the system root: etc, lib, bin, share, var, etc.
Hence, if i am using nltk in a anaconda environment, I'd want to keep my data files in one of the data folders given by anaconda so that data/configs in my anaconda are not affected by data/configs outside it.

@AbdealiJK this is delayed, pending review by someone who has experience with Anaconda. Perhaps you can post a message to nltk-dev to request a review.

CC @danielfrg - perhaps you'd like to review ?

This is great! I had planned to do this PR but forgot. I have a conda recipe for a nltk-with-data conda package and it required exactly this change. The patch and recipe can be found here: https://github.com/danielfrg/conda-recipes/blob/master/nltk-with-data/data.py.patch
The only thing I would add is to add os.path.join(sys.prefix, str('share'), str('nltk_data')) to the list.
Other than that I can confirm that this works perfectly and allows you to download the nltk data to inside an anaconda install and keep everything self contained into those environments.

I do not have any objection to add it as it would be the equivalent of /usr/share/nltk_data in the anaconda environment.
@stevenbird  @alvations - any opinions ?

Adding more paths to automatically search the nltk_data should be okay and I agree that it has to be consistent for both windows/mac/linux for conda.
But I have one more question regarding how nltk_data are used by conda users. Is it common for conda users to put nltk_data with the site-packages? This not exactly related to this PR but possibly if conda users are installing nltk_data like packages, we should move forward with an optional "pip-able" data downloading system (related to #1787  and nltk/nltk_data#84)

The reason a lot of conda users prefer all data, configs, code within the
environment is because they won't have write access to /usr and other
locations...
Now conda does have a local/ and share/ making it easy to save data there.
A pip or conda based data package would be great for some users
specifically those that have proxy constraints and so on.
That's where this discussion came from :
https://github.com/conda-forge/staged-recipes/issues/3615
Having a pypi package for data and hence a conda package for data would be
a +1 from me. Essentially data installable with package managers which are
trackable is a plus from an Operations standpoint.
On Sep 5, 2017 17:38, "alvations"<EMAIL_ADDRESS>wrote:
Adding more paths to automatically search the nltk_data should be okay and
I agree that it has to be consistent for both windows/mac/linux for conda.
But I have one more question regarding how nltk_data are used by conda
users. Is it common for conda users to put nltk_data with the
site-packages? This not exactly related to this PR but possibly if conda
users are installing nltk_data like packages, we should move forward with
an optional "pip-able" data downloading system (related to #1787
https://github.com/nltk/nltk/issues/1787 and nltk/nltk_data#84
https://github.com/nltk/nltk_data/issues/84)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nltk/nltk/pull/1816#issuecomment-327156160, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACGUpwTiPm5Oykl4pmj_MlGMTqrp7pkhks5sfTnTgaJpZM4O7RZ7
.

Yes like @AbdealiJK , its quite common for anaconda users to put everything into the anaconda installation or even just conda environments (basically the same as virtualenv but for conda). The main reason I ended up doing a conda pkg was to ship NLTK to spark jobs, and other type of jobs that required the nltk data to be present, this distributed jobs can be tricky.
That way I was able to have a single pkg with everything I needed for NLTK without having to actually download the nltk data in multiple nodes and manage that which can be a pain.
I would be +1 for a pip-able nltk data package similar to what spacy does.

Yes, +1 for a pip-able data package!

Thank you @AbdealiJK, @danielfrg, @alvations

Any idea when the next release with this is planned?


Add tick style length and padding to options

In the theme generation option theres was no option for tick padding.
Which lead to tick label to not have any padding on the right side of the label making text touch the right border of it.

It's a thing that did not happen when you use a default theme from lcjs.
I addede the option to set this value to allow user to have padding there.

Hey, could you confirm if this happens with the latest versions LCJS v6.0.1 and themes v4.0.2?
I'm under the impression that this issue was caused by a bug on LCJS side, namely:
https://lightningchart.com/js-charts/docs/version-history/v6.0.0/#fixed
"Fixed custom tick label padding sometimes wrong"
If its fixed over there, then better not introduce extra changes.

Indeed you're right. This bug doesn't happen on LCJS version 6.0.1
It happens on the v5.2.1.
I'll do something locally for my project.


Add cargo clean --no-deps

I sometimes find myself wanting to clean out a project without blowing away the dependencies. The -p option works, but can be tedious, especially in a multi-crate workspace.
This PR add a --no-deps option to preserve all non-workspace artifacts. The flag name and docs are modeled after cargo doc --no-deps.
Inspired by: https://github.com/rust-lang/cargo/issues/573#issuecomment-468793358

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks for the PR and sorry for the delay! This seems like a reasonable feature to me, but I think it should mirror the behavior of cargo doc --no-deps. The behavior there is sort of "document the specified packages but not their dependencies", but it means "don't clean workspace members" here. The commands are already somewhat different in that cargo doc doesn't mean "document everything" in the same way cargo clean means "remove everything", though.
Overall I'm not really sure how this would fit in well with the CLI. We've historically wanted to avoid too many flags being added to too many commands for niche purposes. Perhaps the best way to interpret this would be for cargo clean --no-deps to only clean the current package, which more closely aligns with cargo clean a bit.

I'd like to better understand the use case here.  Why is this useful?

The behavior there is sort of "document the specified packages but not their dependencies", but it means "don't clean workspace members" here.

It's the opposite. cargo clean --no-deps would mean clean workspace memebers but not dependencies.

I'd like to better understand the use case here. Why is this useful?

cargo build doesn't generate compile warnings again until the workspace is cleaned or a file is modified. If I want to check multiple crates, i'd have to modify at least one file per crate in the workspace.

cargo build doesn't generate compile warnings again until the workspace is cleaned or a file is modified. If I want to check multiple crates, i'd have to modify at least one file per crate in the workspace.

I would prefer to fix that instead of adding new flags.  There is a fix on nightly via -Z cache-messages for that specifically.

I agree with @ehuss that if the sole motivation for this is to get warnings then I'd say we should wait to stabilize -Z cache-messages behavior as the default.

I don't know if I'd want the default behavior to change. I'd just like a way to opt-in to getting any and all warnings again. The metadata + jq trick works, but having support in cargo makes it easier and cleaner. This change is really just a way to automate the -p option for all workspace packages.
Warning messages aren't the only motivation though. Most of the time that I want to run cargo clean I actually want cargo clean --no-deps. I want to clean my project, but preserve the dependencies so my next cargo build is significantly faster.

I think I would personally prefer to lean on waiting for -Z cache-messages to come along and re-evaluate what's needed here. This seems like a pretty niche feature if that exists which although it's perhaps useful in some circumstances is perhaps not worth the weight it would carry in Cargo.

:umbrella: The latest upstream changes (presumably #7502) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss @alexcrichton It is simpler to clean a sys crate than it is to configure a build.rs to force a rebuild when any C source changes. A sys crate is often a dependency of other crates in a workspace, so it is desirable to do a clean build of just the crates in the workspace.

Ok so caching of messages has been stabilized and the original motivation here I believe is largely fixed. I'm gonna go ahead and close this because we're unlikely to take this, but if there's other more targeted use cases we'd appreciate issues for them!


Typo onReferesh -> onRefresh?

https://github.com/darwin-education/resium/blob/9dca21313e92e24225978429b18228b5c961a703/src/KmlDataSource.ts#L31

Oops, thank you for reporting. I'll fix it soon.


(intermediate value).addEventListener is not a function

I see this error happening a lot, don't really know why.
In discord this was mention It kind of looks like a Hero instance getting shutdown mid-creation, which could definitely happen since there are timeouts on everything, and case something is not fast enough, the instance is closed, and so is hero. This might mean a hero is closed while the core is still doing something on it? This does not seem to crash the core and could probably be ignored, or even better should detect a close, and don't do this.
TypeError: (intermediate value).addEventListener is not a function
    at Tab.addEventListener (/app/service/.yarn/cache/@ulixee-hero-npm-2.0.0-alpha.16-dcd2a28d00-4cf8e995f3.zip/node_modules/client/lib/AwaitedEventTarget.ts:17:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2022-12-07T13:11:28.173Z ERROR [hero-core/index] UnhandledRejection { context: {}, sessionId: null, sessionName: undefined } TypeError: (intermediate value).addEventListener is not a function
    at Tab.addEventListener (/app/service/.yarn/cache/@ulixee-hero-npm-2.0.0-alpha.16-dcd2a28d00-4cf8e995f3.zip/node_modules/client/lib/AwaitedEventTarget.ts:17:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: (intermediate value).addEventListener is not a function
    at Tab.addEventListener (/app/service/.yarn/cache/@ulixee-hero-npm-2.0.0-alpha.16-dcd2a28d00-4cf8e995f3.zip/node_modules/client/lib/AwaitedEventTarget.ts:17:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: (intermediate value).addEventListener is not a function
    at Tab.addEventListener (/app/service/.yarn/cache/@ulixee-hero-npm-2.0.0-alpha.16-dcd2a28d00-4cf8e995f3.zip/node_modules/client/lib/AwaitedEventTarget.ts:17:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Probably similar to #204

Have a fix for this one in latest unblocked. Let's re-test with the next release.

No, I don't think they're related. #204 is in Core.

This is in version 2.0.0-alpha.17

@soundofspace  Is this resolved?

@blakebyrnes yes it is, sorry forgot about this.


[SPARK-25476][SPARK-25510][TEST] Refactor AggregateBenchmark and add a new trait to better support Dataset and DataFrame API

What changes were proposed in this pull request?
This PR does 2 things:

Add a new trait(SqlBasedBenchmark) to better support Dataset and DataFrame API.
Refactor AggregateBenchmark to use main method. Generate benchmark result:

SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.AggregateBenchmark"

How was this patch tested?
manual tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3290/
Test PASSed.

Test build #96338 has started for PR 22484 at commit 649f296.

Test build #96338 has finished for PR 22484 at commit 649f296.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96338/
Test PASSed.

Test build #96473 has started for PR 22484 at commit 42230b6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3380/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96473/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3399/
Test PASSed.

Test build #96500 has started for PR 22484 at commit 2d778a4.

Test build #96500 has finished for PR 22484 at commit 2d778a4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait SqlBasedBenchmark extends BenchmarkBase

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96500/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test build #96502 has started for PR 22484 at commit 2d778a4.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3401/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3403/
Test PASSed.

Test build #96502 has finished for PR 22484 at commit 2d778a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait SqlBasedBenchmark extends BenchmarkBase

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96502/
Test PASSed.

LGTM, cc @dongjoon-hyun for sign-off

@wangyum . Could you make the title and description up-to-date for this PR content? Also, please update JIRA title and description, too.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3416/
Test PASSed.

Test build #96529 has started for PR 22484 at commit 536d4e9.

Thank you for updating, @wangyum .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3417/
Test PASSed.

Test build #96530 has started for PR 22484 at commit f783099.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3418/
Test PASSed.

Test build #96531 has started for PR 22484 at commit d5fecdc.

@wangyum . If you don't mind, could you review my PR to your branch, https://github.com/wangyum/spark/pull/11, which

deduplicates withSQLConf back
runs on AWS EC2 r3.xlarge?

Also, cc @gatorsmile . Since we need withSQLConf in both Benchmark and TestSuite, I want to introduce SupportWithSQLConf trait .

Thanks @dongjoon-hyun. except withSQLConf. We need withTempTable and withTempPath:
https://github.com/apache/spark/blob/d25f425c9652a3611dd5fea8a37df4abb13e126e/sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala#L63-L83

Yep. This PR already is introducing new trait for Benchmark as a part of grand refactoring plan. I think the other new traits also possible at this time. We will see. :)

Test build #96530 has finished for PR 22484 at commit f783099.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96530/
Test PASSed.

Test build #96529 has finished for PR 22484 at commit 536d4e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96529/
Test PASSed.

Test build #96531 has finished for PR 22484 at commit d5fecdc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96531/
Test PASSed.

I made an official PR for withSQLConf SPARK-25534 which reduces the number of withSQLConf from 6 to 3. The three were the minimal different implementations.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3478/
Test PASSed.

Test build #96616 has started for PR 22484 at commit 0fae54d.

Test build #96616 has finished for PR 22484 at commit 0fae54d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait SqlBasedBenchmark extends BenchmarkBase with SQLHelper

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96616/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3483/
Test PASSed.

Test build #96624 has started for PR 22484 at commit 0fae54d.

Test build #96624 has finished for PR 22484 at commit 0fae54d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait SqlBasedBenchmark extends BenchmarkBase with SQLHelper

@wangyum Could you review and merge https://github.com/wangyum/spark/pull/12 , too?

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3516/
Test PASSed.

Merged build finished. Test PASSed.

Test build #96666 has started for PR 22484 at commit 45add92.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3517/
Test PASSed.

Test build #96667 has started for PR 22484 at commit 3439992.

Test build #96667 has finished for PR 22484 at commit 3439992.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #96666 has finished for PR 22484 at commit 45add92.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96667/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96666/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3534/
Test PASSed.

Test build #96686 has started for PR 22484 at commit 3439992.

Test build #96686 has finished for PR 22484 at commit 3439992.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96686/
Test PASSed.

@dongjoon-hyun Other refactorings are waiting for this commit.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3601/
Test PASSed.

Test build #96811 has started for PR 22484 at commit 6c46ad5.

Test build #96811 has finished for PR 22484 at commit 6c46ad5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96811/
Test PASSed.

Merged to master.

Thank you, @wangyum , @cloud-fan and @gengliangwang !


Gate AST

Quantum gates can be built from simpler gates using operations such as taking (normalized) linear combinations, tensor products and compositions. Cirq has a means of representing linear combinations (using LinearDict and related classes), but for now doesn't have an explicit way to represent tensor products or compositions.
One use case for TensorProduct is provided by #1884. Compositions would enable a simple way to represent certain gates, e.g. FSimGate as iSWAP composed with CPhase or YXXY (to be moved in from OpenFermion-Cirq) as FSimGate with Z rotations.
What this means in the bigger picture is that complex gates in cirq could be modeled as abstract syntax trees where inner nodes correspond to operations that combine gates (such a linear combinations, tensor products and compositions) and leaf nodes correspond to a limited set of primitive building blocks (such as Paulis).

This type of representation makes the most sense for general matrices and makes me think we should have a separate class for this, with implicit type conversion when using gates or operations in this class.
It would be nice if we could write code like
(P.X | P.X) | (P.YY + P.YY)
(I used or for tensor product but probably a debate about what that symbol should be).

Python has a "matmul" operator that could be used for tensor product:
P.X @ P.X @ (P.YY + P.YY)

My reason for suggesting | was that it does make sense to matrix multiply two pauli matrices, so that might cause confusion.  Who wants to lobby Python to add the first unicode magic method, ⊗? lol

Closing as it's too complex to implement at this stage.


Expired Pretrained Checkpoints

It seems that the pretrained checkpoint has expired, where can I get it?

i think nothere( did u find analogue?


LPM-5444 int update mulesoft build action to set maven version to 3 8

You need to build the code and check it into the \dist folder as that is what is used by the other repo when building.

You need to build the code and check it into the \dist folder as that is what is used by the other repo when building.

i didn’t fully understand your comment , i am running the /dist/index.js file in the action file , is there something i am missing in the current action.yaml file changes or do you mean to build to src/index first ?

You need to build the code and check it into the \dist folder as that is what is used by the other repo when building.

i didn’t fully understand your comment , i am running the /dist/index.js file in the action file , is there something i am missing in the current action.yaml file changes or do you mean to build to src/index first ?

I am saying do not call<EMAIL_ADDRESS>from the GitHub action but instead copy the javascript code from that repo and then from index.js code call setupMaven function.


DO_NOT_MERGE-trigger-custom-image

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/sane-pdf-reports:<IP_ADDRESS>652
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/sane-pdf-reports/tags
Get started by pulling the image:
docker pull devdemisto/sane-pdf-reports:<IP_ADDRESS>652

Docker Metadata

Image Size: 662.29 MB

Image ID: sha256:b4251a26839d445c6676f15bc94c214bf58d7c20210b871ba3bd6ba457d262f1

Created: 2022-01-02T16:39:32.7228273Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.9.6
PYTHON_PIP_VERSION=21.1.3
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/a1675ab6c2bd898ed82b1f58c486097f763c74a9/public/get-pip.py
PYTHON_GET_PIP_SHA256=6665659241292b2147b58922b9ffe11dda66b39d52d8a6f3aa310bc1d60ea6f7
DOCKER_IMAGE=devdemisto/sane-pdf-reports:<IP_ADDRESS>652

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:4b8a7dea5d85b65af13267641d92730dda45c377
org.opencontainers.image.version:<IP_ADDRESS>652

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/sane-pdf-reports:<IP_ADDRESS>507
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/sane-pdf-reports/tags
Get started by pulling the image:
docker pull devdemisto/sane-pdf-reports:<IP_ADDRESS>507

Docker Metadata

Image Size: 662.69 MB

Image ID: sha256:b505277aba6dab1bf3be67ebb784f4f75da87d06374c935c7a3124536486c9df

Created: 2022-03-14T12:04:43.484915418Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.9.6
PYTHON_PIP_VERSION=21.1.3
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/a1675ab6c2bd898ed82b1f58c486097f763c74a9/public/get-pip.py
PYTHON_GET_PIP_SHA256=6665659241292b2147b58922b9ffe11dda66b39d52d8a6f3aa310bc1d60ea6f7
DOCKER_IMAGE=devdemisto/sane-pdf-reports:<IP_ADDRESS>507

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:6e1b8fe4a9331c1c98d440b2e221c89d506742ec
org.opencontainers.image.version:<IP_ADDRESS>507


Contributing links fixed

fixes #614
Note: I think taht having these files nested into a directory might confuse people not finding them in the root folder.

@tobySolutions done

That is actually an issue. I'll move the files to the root now.

Thank you @FrancescoXX

Could you help do this @FrancescoXX? So I'll just merge your PR at once. What do you think?


DBZ-6317 Document tombstone behavior

Related to https://github.com/debezium/debezium-connector-jdbc/pull/43

@mfvitale Applied, thanks


TODO: Share/save/project functionality

Sometimes I can write whole files using chatcraft. Ideally i'd leave a link to convo that generated them at top of the file.

Going to that link should restore conversation as it was. perhaps link is a hash of conversation stored in s3?
convo should also have a human-written description of what the convo is about..gpt could prefill it.
Restoring basically prefills current msg history

should prompt on whether to erase current history?
perhaps we should have explicit support for named conversations..where importing a convo would create a new convo "imported blabla" which could be renamed

Another interesting approach is to make a comment that summarizes the prompts needed to recreate the file.  This can be done by deleting all the responses, example:

This is cool as it doesn't depend on chatcraft, any gpt implementation could reimplement similar code from such prompts.

This is working now:
https://chatcraft.org/humphd/e9d57776-9617-45b6-bf46-24ab6bd437bc
You can try creating one yourself.  Now we can iterate on the UX.


tests from sdist not working

Hi there,
the tests included in sdist are not working, since not all files are included and one gets the following error:
FileNotFoundError: [Errno 2] No such file or directory: 'tests/numpy_shapes.npz'
...
FileNotFoundError: [Errno 2] No such file or directory: 'tests/samples.json.gz'

So I think, these two files need to be included explicitly in the sdist.
Cheers,
Sebastian

Ayup I'll take a look (can't give a deadline tho, sorry). Will try to merge it with the next version.
--
Alex

14 Feb 2023 22:06:50 Sebastian Müller @.***>:

Hi there,
the tests included in sdist are not working, since not all files are included and one gets the following error:
*FileNotFoundError: [Errno 2] No such file or directory: 'tests/numpy_shapes.npz'
...
FileNotFoundError: [Errno 2] No such file or directory: 'tests/samples.json.gz'
*
So I think, these two files need to be included explicitly in the sdist.
Cheers,
Sebastian
—
Reply to this email directly, view it on GitHub[https://github.com/lmas/opensimplex/issues/41], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABBDCXM23HEHPYNWPLYXCULWXPXWLANCNFSM6AAAAAAU4BR6Z4].
You are receiving this because you are subscribed to this thread.[Tracking image][https://github.com/notifications/beacon/ABBDCXKUKFPSADIRUV7VR7TWXPXWLA5CNFSM6AAAAAAU4BR6Z6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHF45VBCU.gif]

@MuellerSeb I was unable to reproduce your issue, not sure what or how you tried to install the pkg.
At least #43 adds the test data to the sdist tarball when building. Can you confirm that works?

Merging change and closing due to inactivity.


Allow saving edits to a post using Ctrl-Enter like in the old editor

https://meta.stackexchange.com/a/380313/51
https://meta.stackexchange.com/a/360075/51

Ctrl-Enter saves the post in the old editor. Request is for this to be the convention here as well.
Would need to:

Eliminate other uses of Ctrl-Enter (exit code block and exit table)
Wait until keybinds are exposed in the plugin API
Add plugin to attach to this keybind

This will need to be handled in the implementation. You can listen to key events as expected without problem - ProseMirror cancels propagation of all events it handles. In our Core implementation, you can also add a listener to the backing textarea instead, as our implementation forwards all events to it.

Continued on PUBPLAT-3459


ERROR (500) Try To Export Finding Excel

Be informative
ERROR (500) Try To Export Finding Excel
Bug description
Got error when try to export finding to excel format
Steps to reproduce
Steps to reproduce the behavior:

Go to 'product'
Click on 'engagement'
Click on 'Findings'
Click to export excel
See error

Expected behavior
A clear and concise description of what you expected to happen.
Deployment method (select with an X)

[X] Docker Compose
[ ] Kubernetes
[ ] GoDojo

Environment information

Operating System: [e.g. Ubuntu 18.04]
Defectdojo Version v. 2.11.0-dev ( release mode )

Logs
[21/Jun/2022 08:23:03] ERROR [django.request:224] Internal Server Error: /reports/excel_export
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/app/./dojo/reports/views.py", line 939, in excel_export
    worksheet.cell(row=row_num, column=col_num, value=value)
  File "/usr/local/lib/python3.8/site-packages/openpyxl/worksheet/worksheet.py", line 242, in cell
    cell.value = value
  File "/usr/local/lib/python3.8/site-packages/openpyxl/cell/cell.py", line 215, in value
    self._bind_value(value)
  File "/usr/local/lib/python3.8/site-packages/openpyxl/cell/cell.py", line 184, in _bind_value
    raise ValueError("Cannot convert {0!r} to Excel".format(value))

This problem has been fixed with the 2.11.0 release version

Thanks for the support and after update the image the issue resolve
You can close this ticket


Update vpn-gateway-about-vpn-devices.md

Further detail around Route Based VPN's  initiation process which is not currently clear

@samhodgkinson : Thanks for your contribution to the Azure documentation! The author, @yushwang, has been notified to review your proposed change.

Hi, @samhodgkinson
I looked at your suggestion, and it's not clear to me what the issue was. Could you clarify?
Thanks,
Yushun

Hi Yushun
From the documentation, it's not clear that the Azure route base VPN is only initiated on either the Azure gateway or the end VPN device. Although the configuration of the 2nd phase policy configuration does indicate this, it's not clearly stated. I have recently had to connect a customer into a new Azure environment, where the network team where looking for the connection to be established on either side. From my experience, this confusion has been caused by network engineers expecting the Azure VPN to conform to Cisco/Checkpoint.
I was just looking to add a clarifying point to remove this possible confusion for anyone else.
Let me know if you need anything else
Kind Regards
Sam Hodgkinson

#please-close
@samhodgkinson - Sure. Technically speaking, based on the IPsec/IKE protocol definition, both sides can initiate the IKE handshakes. The proposed language is not completely accurate. I'll close this PR for now due to our internal migration schedule. If there's a specific issues on Check Point devices, which we have had a couple, please let me know. I wasn't aware of issues with Cisco devices.
Thanks,
Yushun

Thank you for your consideration
This issues we had with the checkpoint was due to the checkpoint using the universal tunnel proposal.
“When Azure negotiates the tunnel it sends to Check Point universal tunnel proposal which we do not expect. Check Point expect to receive as proposal .../26 network and in some reasons react with sync network IP”. With changing the IPsec configuration around connectivity from DC1 was possible but only when initiated from within DC1.
Kind Regards
Sam Hodgkinson
From: Yushun Wang<EMAIL_ADDRESS>Sent: 24 October 2016 20:56
To: Azure/azure-content<EMAIL_ADDRESS>Cc: samhodgkinson<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-content] Update vpn-gateway-about-vpn-devices.md (#7794)
#please-close
@samhodgkinson https://github.com/samhodgkinson  - Sure. Technically speaking, based on the IPsec/IKE protocol definition, both sides can initiate the IKE handshakes. The proposed language is not completely accurate. I'll close this PR for now due to our internal migration schedule. If there's a specific issues on Check Point devices, which we have had a couple, please let me know. I wasn't aware of issues with Cisco devices.
Thanks,
Yushun
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Azure/azure-content/pull/7794#issuecomment-255847532 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJYtU5y71gyYP9YSIlTjXDvj4aeLIWQfks5q3Q1UgaJpZM4KYl8- .  https://github.com/notifications/beacon/AJYtUzLUTRqOKiZpKI-HvpSLsdP3xV_Jks5q3Q1UgaJpZM4KYl8-.gif


Overriding the default  box and text?

This is more of a support request than an issue, sorry if this is the wrong space for it...I'm attempting to use the vuetify-upload-button component to select the image for upload.  Below is the code I'm trying.  Any ideas?  I've tried a number of variations, such as setting <upload-btn class="fileupload"> and :className="fileupload" etc, but I can't seem to get it to work.
<td>
  <image-uploader
    :debug="2"
    :quality=".7"
    :autoRotate=true
    outputFormat="base64"
    :preview=true
    :className="upload-btn"
    capture="environment"
  >
  </image-uploader>
  <upload-btn></upload-btn>
</td>

I end up with both buttons, and the "upload" button doesn't actually interface with the component.

Hi,
I'm not at all sure if these two components can play nice together. They seem to overlap a bit. As far as I can see, you will be injecting two input-fields to your markup...
However, if you want to inject your custom button to 'vue-image-upload-resize', you should use the input label slot. As in
<image-uploader ... >
	<label for="fileInput" slot="upload-label">
			<!-- custom markup -->
			<upload-btn></upload-btn>
		</label>
	<image-uploader>

And then hide the input as per https://tympanus.net/codrops/2015/09/15/styling-customizing-file-inputs-smart-way/

Hope you figured this out. Feel free to re-open if needed


Refactor docusaurus

https://ci.eionet.europa.eu/job/volto-addons/job/volto-eea-design-system/job/PR-180/12/volto-eea-design-system/

@eea-jenkins build docusaurus

@eea-jenkins build docusaurus

@eea-jenkins build docusaurus

@g-stamatis we are missing body color, link colors (current, active, visited, hover)
https://ci.eionet.europa.eu/job/volto-addons/job/volto-eea-design-system/job/PR-180/12/volto-eea-design-system/docs/webdev/Guidelines/colours/


Viro3DObject onHover repeatedly toggled on/off while hovering on Android

I am having some issues with onHover on Android.
I point at a Viro3DObject and keep the crosshair steady on the object. The onHover callback gets called continuously with about half a second between each call. The isHovering boolean argument changes between true and false for each call.
This does not happen every time, but most of the times I point at an object.
Is it possible that the object is too "thin" for consistent gaze interaction?
The issue does not seem to exist on iPhone.
Device: LG G6 on Android 8
Viro version: 2.7.1

Hey @draperunner, this does sound like an issue with the bounding box associated with the Viro3DObject that is used for determining onHover events. To better diagnose the issue, could you provide:
1 - The 3D model you are using
2 - Sample js code that you have used to scale and position the model in your scene?
3 - If you are using VR or AR scenes.
Much thanks!

Hi!
1 – I have sent you the 3D model on the Viro Slack.
3 – We are using AR scenes only.
2 – Sample code
We are placing the objects in a circle surrounding the user, at a distance of 7 meters. We use billboarding to make the objects face the user. The Viro3DObjects are wrapped in ViroNodes in order to have a ViroText label beneath.
The following code represents a single object with label beneath. See that the Viro3DObject has the onHover prop.
<ViroNode
    viroTag={id}
    key={id}
    position={this.calculateToSector(coordinates, onRadius, -1)}
    physicsBody={{
        type: 'Dynamic',
        mass: 100,
        friction: 900,
        shape: {
              type: 'Sphere',
              params: [shapeSize],
        },
    }}
    transformBehaviors={['billboardY']}
>
    <Viro3DObject
        source={objSource}
        resources={[mtlSource]}
        onHover={isHovering => this.onHover(nearby, isHovering)}
        height={10}
        length={10}
        width={10}
        type="OBJ"
    />
    <ViroText
        text={`${name}\n${(distance || 0) * 1000} m`}
        style={styles.lightText}
        textAlign="center"
        textLineBreakMode="Justify"
        height={5}
        scale={[1, 1, 1]}
        width={3}
        height={10}
    />
</ViroNode>

I have tested on a Samsung S8, and the blinking happens on that one as well. I tried swapping the  onHover prop with onFuse, but then nothing happens at all.

Hey @draperunner, thanks for providing the requested resources. I'm wondering if the ViroText and 3D Object are placed in a way, where the text is in front of the model and thus simply eating up the hover events. Could you try removing the ViroText and see if the hover call back is triggered? If that is the case, you can try putting the hover callback on the ViroNode instead, that encapsulates both components. Let me know how that goes, thanks!

Hey @draperunner, thanks for your reply and code samples. I am having a hard time trying to visualize the bug, it would be great if you could send a video demonstrating the issue (you can use this free recorder app we always use too). Here are a few clarification questions:
To confirm, the desired behavior is that when you hover on the 3D model icon, the table appears on top of it (above it vertically and not overlapping the icon). And then when you hover off, the table should disappear - is this right?

blinking/toggling would happen, even though the entire table is out of of bounds of the reticle.
By blinking, do you mean that the text in the table blinks? Or that it constantly toggles in between the table, then the icon, then the table, etc?

why does this toggle onHover repeatedly when the wrapping table is not even close to the center of the screen
Apologies if i misunderstood here, but isn't the table supposed to appear / disappear only when you gaze on the 3d model, not the table ("wrapping table close to center of screen")?

I guess the faulty ViroText (which is invisible when it fails) somehow goes beyond its bounds so that the reticle overlaps with it.
That's a good question. Actually, when an object is not visible, it should not respond to any events - hover or click - for an examples.

why does onHover get triggered continuously, not just once or twice?
I may have an answer for you here. If your 3D model icon you are using to detect hover events to display the flex table are close together (In particular, the flex table's bounding box overlaps the 3D icon model), it may be possible that the bounding boxes of those two components overlap and z fight:

Firstly, your table appears due to a hover on your 3D icon,
When the table is visible, because of the overlap, the hit test then to fall on the table (hover on table), and the 3D model's hover event to fail (hover off 3D model icon) - resulting in the table to toggle disappear.
Then, when the table disappears, the hit test is then recalculated and falls back on the icon, causing the table to re-appear.
Repeat. (Toggling bug).

You can verify this by disabling any hit events on the flex table by setting ignoreEventHandling prop to true. This will avoid the "fighting" between the flex table and 3D model icon. Another solution here is to move the table back in the Z plane so that they don't overlap. Do let us know if this mitigation works for you. Thanks!

Closing this issue due to inactivity. Please re-open if you are still running into problems with additional comments so we can troubleshoot. Thanks


Add Throw for Cancellation for DeletionService

Description
DeleteMultipleAsync is DeletionService is a long running/looped operation. This PR checks the cancellation token and  throws before starting operations in the loop.
Related issues
Addresses [issue #].
Testing
Describe how this change was tested.
FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)

closing - not needed.


check-googlefonts: Updated Warn message for com_google_fonts_test_075

The previous implementation would produced incredibly long messages for handwitten or display fonts. It would unnecessarily repeat the lengthy description of why this error happens for each glyph. This information is only needed at the end of the test.
Warnings have gone from this:

to this:

Perfect!

Thanks, @m4rc1e !


python-edtf module doesn't follow the latest draft revision of the EDTF spec

The latest spec can be found here:
http://www.loc.gov/standards/datetime/ISO_DIS 8601-2.pdf
Here are some differences I've noticed between the current implementation and the latest spec. (this list may not be complete):

use of % to mean both uncertain and approximate (see 4.2 Uncertain and/or approximate date)
use of capital X instead of lowercase u for unspecified digits (see 4.3 Unspecified)
use of a blank instead of the keyword unknown (see 4.4 Enhanced time interval)
use of .. instead of the keyword open (see 4.4 Enhanced time interval)
use of a capital Y instead of a lowercase y (see 4.5 Year exceeding four digits)
use of uppercase S instead of lowercase p to express significance (see 4.6 Significant digits)
there's also a whole section on recurring dates that may or may not be applicable (see 5 Repeat rules for recurring time intervals)

You can find it on archive.org:
https://web.archive.org/web/20170926052706/https://www.loc.gov/standards/datetime/ISO_DIS 8601-2.pdf

It looks like a new spec has been published.
https://www.loc.gov/standards/datetime/edtf.html
It would be nice to see this library updated to reflect the changes from the earlier draft.

This is resolved by #56


Change Ahemdabad to Ahmedabad (#1585)

This change is

I signed it!

Thanks @gitjeff05!
This looks good, could you update with the latest from master? Then I can merge.

Actually we've already got a fix ready for the next release, since we had accepted https://github.com/googlei18n/libphonenumber/issues/1585. Thanks though!


#545 fix indexing logic

PR Checklist:

[x] Link to related issues: closes #545, relates to #395
[x] Add changelog entry linking to issue, describe API changes
[x] Add tests (optional)
[ ] (If new feature) add to description / readme

@Polleps I've added a test that demonstrates the issue. You had some ideas on refactoring the indexing logic.
After making the changes, test with cargo nextest run db::test::index_invalidate_cache

The issue is gone when we remove the whole chunk that was introduced by #395.
The problem was this:

we have a Query with a filter for blogpost items, and a sort by description
we now have an index item containing the description field
we change the blogpost to recipe. An IndexAtom (containing blogpost) is removed from the indexes.
the IndexAtom does not contain the description field, because that wasn't updated.
the IndexAtom created in step 2 still exists!

I don't think I have a test for this, because right now everything seems to pass locally. So I think this PR, as of now, will re-introcuce #395.
The solution was the chunk below in should_update
    if let Some(sort_prop) = &q_filter.sort_by {
        // Sometimes, a removed atom should also invalidate other IndexAtoms, because the QueryFilter no longer matches.
        // This only happens when there is a `sort_by` in the QueryFilter.
        // We then make sure to also update the sort_by value.
        if let Ok(sorted_val) = resource.get(sort_prop) {
            // Note that updating here is a bit too agressive. It will update the index every time an atom comes by that matches the QueryFilter, even if the value is unchanged.
            if &index_atom.property == sort_prop {
                update_indexed_member(
                    store,
                    q_filter,
                    &index_atom.subject,
                    &sorted_val.to_sortable_string(),
                    delete,
                )?;
            }
        }
    }

But that solution caused the issue described here, so I removed it now.
We need two things:

A failing test for #395
A fix for that that doesnt introduce new bugs like this one

I've just added a failing test for the #395 case. @Polleps feel free to make your changes and run cargo nextest run db::test::index_invalidate_cache

E2E tests passing locally.


Ovewrite reload shortcut without global settings

Global shortcut should be avoided since we don't want to the shortcut work on the OS global scope.

@krolow could you check if it works for you? At least on mac it is working for me.

it does... just that thing that I have mention when I did this solution, when you are at spalsh screen, or at the home/select database, ctrl + r does the reload...

Refs to #287


Detailed Logs in Admin UI

Hello @darrachequesne
Thank you for taking the time in improving our experience with Socket.IO. I wanted to ask if there is any chance we can see the detailed logs (both access and error) of our server in Admin UI?

By "detailed logs", you mean the logs of the HTTP server? Could you please explain what you have in mind?

Yes, it can also contain HTTP logs. Any errors that occurred in the Node process would also be quite helpful. This way, I would not have to switch back to my terminal to see what caused my server to restart unexpectedly.
Any connection errors should also be logged somewhere in the Admin UI.

which number of max clients can log in to admin ui?


Deployment should add plugin and remove on undeploy

This should make sure we won't accidentally remove user deployed plugins during un/deployment of our plugin.

Can you add a description text with some context to your commit please?


feat: added workflow to ensure the web-extension is building

Proposed changes
Added workflow to ensure the web extension is properly building for each pull request
Types of changes

[ ] 🐛 Bugfix (non-breaking change which fixes an issue)
[ ] ✨ New feature (non-breaking change which adds functionality or enhancements)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] ✅ Tests (added tests for an existing feature)
[ ] 📚 Documentation Update (if none of the other choices apply)
[x] 🙌 Other (please, write a clear and concise description of the proposal in the section above)

Checklist

[x] 👀 I have read the CONTRIBUTING doc
[x] ✅ Lint and unit tests pass locally with my changes
[x] 🧪 I have added tests that prove my fix is effective or that my feature works
[x] 📚 I have added necessary documentation (if appropriate)
[x] 🔀 Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #178 (c973a3a) into main (e8d212d) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c973a3a differs from pull request most recent head 9957fa9. Consider uploading reports for the commit 9957fa9 to get more accurate results

@@            Coverage Diff            @@
##              main      #178   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           99        99
  Lines          850       850
  Branches       111       111
=========================================
  Hits           850       850

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d212d...9957fa9. Read the comment docs.


Adds floating point duration attribute

Description
Please include a summary of the change, motivation and context.

Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Codecov Report

Merging #13 (7dc8838) into rzp_main (d65bf95) will decrease coverage by 31.24%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             rzp_main      #13       +/-   ##
===============================================
- Coverage       74.50%   43.26%   -31.24%
  Complexity         69       69
===============================================
  Files              14       14
  Lines             557      557
  Branches           33       33
===============================================
- Hits              415      241      -174
- Misses            126      303      +177
+ Partials           16       13        -3

Flag
Coverage Δ

integration
?

unit
43.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 13 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Question Regarding Cosine Limit in renderer.py

Hi,
Thank you for your excellent work. I have been utilizing it in my projects, particularly in computing sine and cosine values. However, in this line
you've set the limit for the cosine value to (-1000, 0). I'm curious about the rationale behind this decision, as typically, the range for cosine values is (-1, 1). If the cosine value falls below -1, it becomes mathematically invalid to compute the corresponding sine value.
Could you kindly shed some light on why the limit was set to (-1000, 0) instead of the standard (-1, 1)? Understanding this would greatly aid my comprehension and usage of your work.
Thank you very much for your time and consideration.

I have the same question


(demos) ionic 2 config demo uses deprecated @App decorator

Short description of the problem:
The ionic 2 configuration demo is intended to show a user how to make changes to the layout of their application. The example output uses the old @App decorator syntax with the configuration passed in, which was deprecated in beta 8.
Docs for passing Config in to ionicBootstrap: config/Config
What behavior are you expecting?
Documentation should be updated to reflect current API.
I would create a PR, but it's not obvious what the best way to update the documentation would be - maybe just a note that this should be passed in to the ionicBootstrap call?
Which Ionic Version? 2.x

Thanks for the issue! I've pushed a fix for this so it should be live on the site soon. :smile:


What is the type signature of apply?

Scheme (and possibly racket) has function called apply and list. Will these function also be available in hackett? What about their type signatures?
Note:
Even though apply takes a list as an argument in scheme it would make much more sense to take a tuple as an argument. There should be also a tuple variant of list. Also foo and apply foo . tuple should be equal.

It’s unlikely that either of these will exist as functions, but it’s quite possible they will exist as forms. The list form is always available as [ square brackets ], but as you mention, homogenous lists probably aren’t what you’re looking for, anyway. Tuples (of arbitrary size) are not currently implemented, but they are planned.
Addressing apply is a little trickier. Implementing it as a macro probably wouldn’t be too hard, but that would restrict higher-order usage. It’s possible that it could be implemented more cleverly, though, with the use of a special Tuple typeclass and some clever macro machinery.