add nokogiri to omnibus-chef

implements first part of https://github.com/chef/chef-rfc/blob/master/rfc063-omnibus-chef-native-gems.md

@chef/client-core trivial review.  all the hard work got done in omnibus-software libxml/libxslt

:clap: :tada: :+1:

Our long nightmare is over. Now we can find whole new errors to be irrationally tableflip about!

http://manhattan.ci.chef.co/job/chef-12-build/138/

http://manhattan.ci.chef.co/job/chef-12-test/97/ (expected failures in windows + nexus-7 due to other issues on master right now)

For bonus hilarity, nokogiri put out a security release this morning.

that would be more amusing the day after 12.7.0 ships...

actually we already build against our own libxslt/libxml2 so i think we've already fixed those in omnibus-software master...

https://github.com/chef/omnibus-software/pull/550

@lamont-granquist @thommay Did we ever add the rest of the stuff from https://github.com/chef/chef-rfc/blob/master/rfc063-omnibus-chef-native-gems.md?

nope, i still have that written up on my whiteboard as a TODO.
i just got burned out fighting with our build system for awhile.


Multi-Line Environment Variables Validation Errors

In most companies, security policies dictate that we don't store secrets within a simple Git repository, and instead, inject the data via env variables to any CI/CD process that runs and requires the secrets.
While decK allows env variable injection, the injection is done in a simple way using Go Templates, without any regards to formatting of the file format. Subsequently, if the secret is a multi-line secret (such as a private or public RSA key necessary in certain plugins), then this breaks the file formatting and will cause errors in the file validation.
As an example, with a state file that looks like this:
_format_version: "1.1"
consumers:
  - custom_id: consumer_1
    jwt_secrets:
      - algorithm: RS256
        key: consumer_1_iss_key
        rsa_public_key: ${{ env "DECK_RSA_PUBLIC_KEY" }}
        secret: consumer_1_secret
    username: consumer_1_user_name

Running decK validate fails with the following error:
$ DECK_RSA_PUBLIC_KEY=$(cat pubkey.pem) deck validate

Error: reading file: validating file content: unmarshaling file content: error converting YAML to JSON: yaml: line 9: could not find expected ':'
exit status 1

I agree that the injection is a bit simplistic and we should be doing something more.
Very open to new ideas on making this better.
For the specific case, something like this may get work:
_format_version: "1.1"
consumers:
  - custom_id: consumer_1
    jwt_secrets:
      - algorithm: RS256
        key: consumer_1_iss_key
        rsa_public_key: |
          ${{ env "DECK_RSA_PUBLIC_KEY" }}
        secret: consumer_1_secret
    username: consumer_1_user_name

For the specific case, something like this may get work:
Unfortunately that still fails with the same error, since the template is still injecting multiple lines into the file and the subsequent lines aren't indented.

Very open to new ideas on making this better.
@hbagdi What do you think about first unmarshaling the YAML file into a temporary map immediately after reading in the readContent function, and then iterating over the keys and making any replacements you need while iterating? Once you complete the replacements you could then use something like mapstructure.Decode to decode from a map to a Content struct.

Either that, or the template funcs that are passed in need to be a lot more powerful so that they can enable the yaml (and JSON) formatting necessary

Either that, or the template funcs that are passed in need to be a lot more powerful so that they can enable the yaml (and JSON) formatting necessary

That is my current stance since I expect to not have a lot of such cases.
We use a single "env" function in the file today but the hopes and plans are bigger - having injections via other mechanisms.  This would be a step in that direction.

The one downside that I do know of to doing things raw within the template is that it requires a lot of extra overhead... for example, in this case, you not only need to "yaml-ize" the input, but also to ensure that it is indented the correct indentation level, and ensure that each line (since it is a multi-line input) is indented the correct indentation level as well.
It's adds some complexity to know the levels and to know how it will be rendered... which is made even more complicated because of the fact that there's no render command to only render what the actual config will look like pre-validation...

A workaround for this would be to use the JSON format for the configuration file, instead of YAML (please note the backticks around the variable name):
$ cat kong.json
{
  "_format_version": "1.1",
  "consumers": [
    {
      "custom_id": "consumer_1",
      "username": "consumer_1_user_name",
      "jwt_secrets": [
        {
          "algorithm": "RS256",
          "key": "consumer_1_iss_key",
          "rsa_public_key": "${{ env `DECK_RSA_PUBLIC_KEY` }}",
          "secret": "consumer_1_secret"
        }
      ]
    }
  ]
}

$ deck sync -s kong.json
creating consumer consumer_1_user_name
creating jwt-auth consumer_1_iss_key for consumer 73a0b0ef-9f75-4d91-8fbb-093a8ca72fac
Summary:
  Created: 2
  Updated: 0
  Deleted: 0

@probably-not I see what's wrong, my env variable was well formatted but getting it directly from a file is more problematic. Can you try something like this?
$ DECK_RSA_PUBLIC_KEY=$(cat ./auth0_rsa_public.key | jq -sR . | tr -d '"' ) deck --state "./kong.json" sync
Summary:
  Created: 0
  Updated: 0
  Deleted: 0

The workaround, with using the json format on the state files, is working in my case. Thank you!

Good to hear! I'll try it out in my pipeline to see if it works well.

Thank you both for the patience on this!

@GGabriele Looks like this works in our pipeline, the only issue I found is that the tools (jq, tr) are not available in the base deck Docker image, so we had to create our own image and add in tools manually. If we can add these tools to the deck Dockerfile that would be a big help.

@probably-not I just tried with the latest deck image and it seems that tr tool is already part of it:
/ $ deck version
decK kong/deck:v1.12.0 (e6da44844f150ea3d15dfffe00bde471d96bbb4e)

/ $ jq
/bin/sh: jq: not found

/ $ tr
BusyBox v1.34.1 (2022-04-04 10:19:27 UTC) multi-call binary.

Usage: tr [-cds] STRING1 [STRING2]

Translate, squeeze, or delete characters from stdin, writing to stdout

	-c	Take complement of STRING1
	-d	Delete input characters coded STRING1
	-s	Squeeze multiple output characters of STRING2 into one character

Just opened a PR to add jq though: https://github.com/Kong/deck/pull/660
Thanks for confirming this works well with you!

Excellent, thanks 👍

For anyone else coming here having the same problems I had (passing a multi-line public key into the declarative config as an environment variable), I was able to make it work in YAML like this:
Replace newlines with "\n" in the public key and assign that to the environment variable:
export DECK_RSA_PUBKEY="-----BEGIN PUBLIC KEY-----\n..."

And then in the declarative config YAML:
rsa_public_key: "${{ env `DECK_RSA_PUBKEY` }}"

The above usage takes advantage of the fact that double quotes in YAML convert "\n" to newlines. I'm also using the backticks for quoting the environment variable -- apparently this is a Go Template thing.
Anyway... there you have it. Worked for me.


Setting session from TrainConfig doesn't seem to work

I've been trying to modify the DQN example to use a TF session config that only uses 45% of the GPU memory (so I can run two processes at once), however despite setting session_creator in the TrainConfig to use a NewSessionCreator with a custom session I still TF requesting all of my GPU's memory.
I saw that custom session support in training was added relatively recently. Is it supposed to be working?

Could you post the relevant code?

Here's a tiny patch that shows what I'm trying to do. Running DQN.py with this patch I still see almost all of the memory on my GPU being reserved.
code.txt

The config should get passed to tensorflow successfully. This might be a TF issue or the config is not enough to make it control the memory usage.
The allow_growth option in the config may help.

It works for me.
diff --git i/examples/cifar-convnet.py w/examples/cifar-convnet.py
index a8e18dc..8761bb2 100755
--- i/examples/cifar-convnet.py
+++ w/examples/cifar-convnet.py
@@ -10,6 +10,7 @@ import os

 import tensorpack.tfutils.symbolic_functions as symbf
 from tensorpack.tfutils.summary import *
+from tensorpack.tfutils.sesscreate import *
 from tensorpack.utils.gpu import get_nr_gpu

 """
@@ -114,6 +115,13 @@ def get_config(cifar_classnum):
     dataset_train = get_data('train', cifar_classnum)
     dataset_test = get_data('test', cifar_classnum)

+    tf_conf = tf.ConfigProto()
+    tf_conf.gpu_options.per_process_gpu_memory_fraction = 0.05
+    tf_conf.allow_soft_placement = True
+    session_creator = NewSessionCreator(config=tf_conf)
+
+
     def lr_func(lr):
         if lr < 3e-5:
             raise StopTraining()
@@ -127,6 +135,7 @@ def get_config(cifar_classnum):
             StatMonitorParamSetter('learning_rate', 'val_error', lr_func,
                                    threshold=0.001, last_k=10),
         ],
+        session_creator=session_creator,
         max_epoch=150,
     )

Then I can see it consumes only a little memory

Does it work with DQN? I'm wondering if it's not getting passed all the way
through the trainers.
On Apr 7, 2017 20:29, "Yuxin Wu"<EMAIL_ADDRESS>wrote:

It works for me.
diff --git i/examples/cifar-convnet.py w/examples/cifar-convnet.py
index a8e18dc..8761bb2 100755
--- i/examples/cifar-convnet.py
+++ w/examples/cifar-convnet.py
@@ -10,6 +10,7 @@ import os
import tensorpack.tfutils.symbolic_functions as symbf
from tensorpack.tfutils.summary import *
+from tensorpack.tfutils.sesscreate import *
from tensorpack.utils.gpu import get_nr_gpu
"""
@@ -114,6 +115,13 @@ def get_config(cifar_classnum):
dataset_train = get_data('train', cifar_classnum)
dataset_test = get_data('test', cifar_classnum)

tf_conf = tf.ConfigProto()
tf_conf.gpu_options.per_process_gpu_memory_fraction = 0.05
tf_conf.allow_soft_placement = True
session_creator = NewSessionCreator(config=tf_conf)

def lr_func(lr):
if lr < 3e-5:
raise StopTraining()
@@ -127,6 +135,7 @@ def get_config(cifar_classnum):
StatMonitorParamSetter('learning_rate', 'val_error', lr_func,
threshold=0.001, last_k=10),
],

   session_creator=session_creator,
   max_epoch=150,

)

Then I can see it consumes only a little memory
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ppwwyyxx/tensorpack/issues/220#issuecomment-292681287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyIwjiTYh5AKv8WS7rHBHcMcanyNvGLks5rttTTgaJpZM4M20HX
.

The backends are the same for all the examples.

Ok, just tried on cifar and that seems to work while DQN (still) doesn't. Hopefully later today I can figure out what's different about the two that's causing this.

That's interesting.. I'll try DQN.

Thanks for the pointer!
But I don't know anywhere a Session would be created earlier. From that thread it looks like the config issue is quite complicated.

btw, I cannot reproduce this in DQN either (at least not in the first epoch).
I'm using some nightly prebuilt version of TF I downloaded last week.

Huh, that's odd. It's easily reproducible for me and happens right from the first epoch. I'm running a version of TF I compiled, but not that recently. I'll switch to the latest RC in the next few days and see if it's fixed for me.

User reported that this is fixed after reinstalling TF. Closing.


tf.data.Dataset.map() of tf.data.Dataset feat. tf.RaggedTensor causes broken for-loop

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
2.9.2
Custom Code
Yes
OS Platform and Distribution
Windows 10, WSL2 Ubuntu 20.04
Mobile device
No response
Python version
3.8.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.2
GPU model and memory
No response
Current Behaviour?
When using a tf.data.Dataset for tf.RaggedTensors, the .map() functionality seems to break the ability to iterate over the datapoints via for-loop, causing an internal TypeError on the for-loop itself.
The expected behaviour would be for the program not to throw a TypeError as the same function works if used via a simple for-loop over the data instead of the .map() functionality.

Standalone code to reproduce the issue
import tensorflow as tf
ragged_data=tf.ragged.constant([[[[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]]], [[[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]]]])
ds=tf.data.Dataset.from_tensor_slices(ragged_data)
def test_fn(ragged_data):
    for x in ragged_data:
        continue
    return ragged_data
ds.map(test_fn)

Relevant log output
TypeError: Input 'y' of 'Less' Op has type int64 that does not match type int32 of argument 'x'.

@sushreebarsa
I was able to reproduce the issue on Colab using TF v2.11 . Please find the gist here for reference.
Thank you!

Hi, @Tens0rFlaw
Apologize for the delay and I was able to replicate the issue on Google Colab with Tensorflow==2.11 and it's working as expected, for your reference I have added gist-file  and it seems like you're using python map() instead of tf.map_fn() and for your reference I have added official documentation for tf.map_fn() which may help you. If issue still persists please let us know or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!

Hi @gaikwadrahul8
that indeed resolves the issue.
Thank you for you answer!


publish<EMAIL_ADDRESS>

Requested by: @st0012
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.

Document PR: https://github.com/getsentry/sentry-docs/pull/3495


XMLRPC does not properly pass < and > characters

It seems the remote server it not receiving the proper string even though a dump of the request looks right. Is there some kind of encoding going on that breaks < and > in XMLRPC requests?

Could you provide some example code that triggers the issue?

$identifier = "username";
$password = "R(~{tJZwnrOCK6w!Fh{tVg\<>@;Js|yZ5;e+7(c"SVP`'T7eF.^oiHy#UO.=um1n";

$auth = $this->xmlrpc->call('auth', [$identifier, $password]);

This fails even though the password is correct.

Is anyone gonna give this a second look?

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html
New issue can be found at: https://github.com/zendframework/zend-xmlrpc/issues/21


python311Packages.datetime: 5.2 -> 5.4

Diff: https://github.com/zopefoundation/datetime/compare/refs/tags/5.2...5.4
Changelog: https://github.com/zopefoundation/DateTime/blob/5.4/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


darkmode support

It would be great if the project could support darkmode.

Dark mode support is planned, but it's going to be awhile before it's added since it's a fair amount of work to redo the styles. Closing as a duplicate of issue #911.

@rjzupkoii It'll be really amazing if the dark mode switch button could be implemented.


throw if given invalid version [apm]

Closes #1780

Warnings

:warning:

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @RedSparr0w!

  Generated by :no_entry_sign: dangerJS

Something i noticed when working on this badge, Is that it may make more sense if we could apply the category to the preview, As this services file would be ~⅓ of the size.
Is there any badges that this wouldn't work for?

Example
module.exports = class AppVeyor extends BaseJsonService {
  async handle({info, repo}) {
    const apiUrl = 'https://atom.io/api/packages/' + repo;
    const json = await this._requestJson(apiUrl, {}, 'package not found');

    if (info == 'dm'){
        var downloads = json.downloads;
        return {label: 'downloads', message: metric(downloads), color: 'green'};
    } else if (info == 'v'){
        var version = json.releases.latest;
        if (!version)
          throw Error('Invalid version');
        return {message: addv(version), color: versionColor(version)};
    }else if (info == 'l'){
        var license = json.metadata.license;
        if (!license)
          throw Error('Invalid license');
        return {label: 'license', message: license, color: 'blue'};
    }
  }

  static get defaultBadgeData() {
    return { label: 'apm' };
  }

  /*
  static get category() {
    return 'null';
  }
  */

  static get url() {
    return {
      base: 'apm',
      format: '(dm|l|v)\/(.+)',
      capture: ['info', 'repo']
    };
  }
  static get examples() {
    return [
      {
        category: 'downloads',
        previewUrl: 'dm/vim-mode',
        keywords: [
          'atom'
        ]
      },
      {
        category: 'version',
        previewUrl: 'v/vim-mode',
        keywords: [
          'atom'
        ]
      },
      {
        category: 'license',
        previewUrl: 'l/vim-mode',
        keywords: [
          'atom'
        ]
      },
    ];
  }

Something i noticed when working on this badge, Is that it may make more sense if we could apply the category to the preview, As this services file would be ~⅓ of the size....

Personally I'd be in favour of maintaining separation of concerns but reducing duplicated code by using inheritance. For example, another way to factor some common code out here would be like this:
class BaseAPMService extends BaseJsonService {

  async fetch({repo}) {
    const apiUrl = 'https://atom.io/api/packages/' + repo;
    return = await this._requestJson(apiUrl, {}, 'package not found');
  }

  static get defaultBadgeData() {
    return { label: 'apm' };
  }

}

class APMDownloads extends BaseAPMService...
class APMVersion extends BaseAPMService...
class APMLicense extends BaseAPMService...

That's still going to be more lines of code than defining all 3 badges in one class but its more DRY than explicitly defining const apiUrl = 'https://atom.io/api/packages/' + repo; 3 times + so on. This also fits in quite nicely with the discussion in https://github.com/badges/shields/pull/1743 around splitting handle() into fetch() and render().
Any opinions @paulmelnikow ?


Slow in processing files

On average CDT takes 8 seconds and ClaiR 2 seconds to process a "common"/not that huge source file. Can the processing time be improved?

There is little I can do about the time it takes CDT to parse a file. Since ClaiR has to marshall the full AST, it needs to traverse and build the full AST, also leaving little opportunity for speed-ups. I'll have a look whether there is some unnecessary (or no longer needed) functionality that I can prune, but I would only expect marginal improvements, if any.

Is it e.g. faster to process all files in a directory in one go instead of processing separately?

Generating a file that includes a set of files (e.g., a file that consists of just include directives) leads to a significant speed-up compared to processing each file separately; however, the results may be different/incorrect due to, e.g., defined macros, defined typedefs, parse errors due to double forward declarations.

I removed some legacy fragments from ClaiR and moved things around internally a bit. My anecdotal evidence suggests that for a single (large) file, CDT parsing time has been marginally reduced, and marshalling time was reduced significantly.

Closing this for now.


IAM Policy

We could document the required IAM policy to deploy all the resources

Are you aware of any tool that looks at a TF module and generates required IAM permissions?
In my experience TF is usually applied with an admin account in an automated process

I usually do the same, but the CI/CD account was missing a few permissions that came up using this role, hence my request
There's a few tools but I haven't used it nor looked into integrating it with Terraform
I guess admin account is the answer, given the very different things Terraform could be deploying, not only regarding this module

@Lusitaniae here you go
I create a new IAM user and grant it all permission then after it finish the terraform apply I go check event history from cloud trial so now I have all the IAM permission you need in order to run this module
In case anyone need it

Event source
Event name

ec2.amazonaws.com
DescribeAccountAttributes

ec2.amazonaws.com
DescribeSecurityGroups

ec2.amazonaws.com
RevokeSecurityGroupEgress

events.amazonaws.com
DeleteRule

events.amazonaws.com
DescribeRule

events.amazonaws.com
ListTagsForResource

events.amazonaws.com
ListTargetsByRule

events.amazonaws.com
PutTargets

events.amazonaws.com
RemoveTargets

iam.amazonaws.com
DeletePolicy

iam.amazonaws.com
DeleteRole

iam.amazonaws.com
DetachRolePolicy

iam.amazonaws.com
GetPolicy

iam.amazonaws.com
GetPolicyVersion

iam.amazonaws.com
GetRole

iam.amazonaws.com
ListAttachedRolePolicies

iam.amazonaws.com
ListInstanceProfilesForRole

iam.amazonaws.com
ListPolicyVersions

iam.amazonaws.com
ListRolePolicies

lambda.amazonaws.com
AddPermission20150331v2

lambda.amazonaws.com
DeleteFunction20150331

lambda.amazonaws.com
GetFunction20150331v2

lambda.amazonaws.com
GetFunctionCodeSigningConfig

lambda.amazonaws.com
GetPolicy20150331v2

lambda.amazonaws.com
ListVersionsByFunction20150331

lambda.amazonaws.com
RemovePermission20150331v2

logs.amazonaws.com
DeleteLogGroup

logs.amazonaws.com
DescribeLogGroups

logs.amazonaws.com
ListTagsLogGroup

appreciated!
over the top


Conditional types via if/unless

As suggested by @esthedebeste on Discord, this PR allows for conditional (ternary) types to be given by if/else and unless/else expressions, with the usual support for then conditions (with condition delimited by parentheses, or then clause indented, or explicit then).
The else clause is optional, with a default value of never, which I find to be very common when writing conditional types.
Also added support for indenting a type specification in let.

Does typescript support the unless output; !(a extends b)? I haven't seen a ! unary in type context before.

Does typescript support the unless output; !(a extends b)?

It does not.

Thanks for catching this! I fixed unless to instead swap the then/else clauses.

Thanks for catching this! I fixed unless to instead swap the then/else clauses.

There's probably slightly more that needs to be done to support unless since extends is a <= relationship.
For example

ty

I don't think so; if !x then y else z should be equivalent to if x then z else y in all cases.
In particular, A extends B ? B extends A ? false : false : true is equivalent to A extends B ? false : true because the first two cases are both false.

Makes sense, I overthought things and confused myself!


Add ability to search through submissions

Something I frequently used on Google sheets was to ctrl + f for a map to see if it's submitted. Something similar should be present on this website as well, would be a really good QoL feature, especially as the number of submissions continues to grow. In osu!mania it's already a pain to go through, considering they have a whopping 37 pages of submissions.
I've asked around the captains & the general communities in the osu!taiko & osu!mania community servers, as well as the captain+metadata teams and this has unanimous agreement:

the show of hands is kinda pointless cuz like... why would you say anything but "yes"
and none of these screenshots have further info abt wanted feature or use cases etc

The most common use-case I can gather in favor of this feature is primarily to check whether a certain map has been submitted already. Currently it's super tedious to do so, requiring either to either:

(re)submit the map yourself
go through each page individually and ctrl+f the map name to see if its there

First option is generally fine but I'm pretty sure we'd rather not spam map submissions to see if said map has been submitted already. (using myself as an example - I don't want to be the one to submit my own maps to check if anyone submitted one of my maps for Loved)
Second option is incredibly tedious and needlessly time-consuming, especially on osu!standard and osu!mania when there's already like 20+ pages on each game mode with submissions. osu!taiko and osu!catch captains don't see this as a massive priority though, given the low amount of submissions & activity from said captains on those pages.


Skip duplicate actions when pushing in this repository

Currently when creating a pull request (at least, one not in a fork, but at the moment there are no forks anyway), we get two copies of each Github action, one for the branch push and one for the pull request. The change in this commit should skip the action running for the pull request whenever the source branch exists locally in this repository. It shouldn't affect branches coming from other people's forks, if there are forks in the future.
I copied the logic to do this from another project in which I worked out how to do the same thing. The comment I've added to the workflow refers to a blog post I relied on when figuring out how to make this work for that other project.

Actually let's wait on this one - I want to be sure it actually works and that might involve retriggering some CI checks.

I think it's ready to go now...


 error when using NIP07

When opening messages, if you don't have accept automatically for NIP07, you get the <Failed to decrypt message: Error: window.nostr call already executing> error.
20230719002140.webm
But even when i gave all the permissions, some messages still don't load!

This is a known issue, I finally found the solution last week, so it'll be fixed in the next release. Thanks for the report!


View state not persisted properly when switching between workspace and folder

Steps to Reproduce:

have a multi root workspace
open SCM view and click on the second repo
open the second folder
click on SCM view
switch back to workspace

=> :bug: multiple views are now selected in SCM view

Obsolete with the new view UX.


Wrap inline hint style

@th1000s This PR (targeting your branch) adds a new option inline-hint-style and uses it to style the wrap and prefix symbols. The option accepts values using the same style mini-language as the other delta style options.
I haven't pushed this to your branch yet because your suggestion of using syntect ThemeSettings is interesting. Perhaps one consideration there is that some delta users do not use syntax highlighting (e.g. those using the diff-highlight / diff-so-fancy emulation modes, or the villsau delta theme.)

Ok, being able to set the inline-hint-style independent from syntax highlighting seems like a good idea.

Thanks, I've merged this to your branch.


Support claims index page filters

Context
We need to allow our support users to filter the claims.
Two filters, School and Provider filters have 2 search fields where
you can search by school name or provider to get the filter you want.
This is done by javascript in a stimulus controller.
The other 2 filters, Submitted after and Submitted before filters are
date filters and use the govuk_date_field form helper. You cannot set
the value of this helper as it's sending 3 params not just 1. So to
persist the value of these filters we need a form object.
Claims::Support::Claims::FilterForm is a form object that is meant to
just house the params and all the logic that these filters need.
All the params of the filters are in the url.
Changes proposed in this pull request
Claims::Support::Claims::FilterForm
Stimulus controller
Styling changes
Guidance to review
Sign in as colin
Go to support claims index
Filter claims by all the filters
Use the search too
Screenshots
https://github.com/DFE-Digital/itt-mentor-services/assets/11318084/275610e4-c59c-4860-b9c4-d5849f8645d0

 As a Support User, I want to be able to see the list of all Claims and be able to filter through them

This is also a pretty complex change. It would help reviewers if this PR was broken down into step-by-step commits.


Update parallel state branches and foreach states 'workflowid' parameter

Signed-off-by: Tihomir Surdilovic<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[ x] Specification
[ x] Schema
[ x] Examples
[ ] Extensions
[ ] Roadmap
[ ] Use Cases
[ ] Community
[ ] TCK
[ ] Other

What this PR does / why we need it:
While working on a new example I noticed that in parallel state branches and foreach state
the "workflowid" parameter is very weak. It currently references the id of a reusable workflow.
The problem with this however is that it cannot define things like compensation and the subflow states "repeat" ability.

changed the "workflowid" parameter to "subflow"
the "subflow" parameter now points to a SubFlow state (via its name), so that all of the SubFlow additional properties can also be used
in branches and foreach state now
added clause that the referenced SubFlow state cannot be part of the main control flow logic (cannot have incoming/outgoing transitions nor can it end workflow execution)
updated/fixed required parameters in workflow schema for branches subflow state and foreach state

Special notes for reviewers:
Additional information (if needed):

The description of this PR seems to assert that a sub-flow in a parallel state should be directly/individually compensatable and retryable, and thus introduces a reference to a separate sub-flow state instead of a direct reference to the sub workflow where compensation and retry logic can be defined.
It seems that the focus is purely on how to get this behavior specifically for the case where a parallel branch is a sub-workflow.   I question why these concerns for compensation and retry are only being addressed for sub-flow branches, and not other types of branches.
Specifically with regard to compensation, I would like to suggest that we set the expectation that compensation applies to the whole state, and in the case of parallel the workflow implementor should have compensation logic that handles the fact that a parallel state might have done many (or even none) of the branches (it's a responsibility of the workflow user to explicitly define exactly how to compensate the branches of a parallel state).   Otherwise it gets incredibly complex to handle compensation for a parallel state.
Consider the case where we support compensation for a parallel state w/ 3 sub-workflow branches.  When the parallel state fails, in what order should the compensation for those branches be executed?  Must the compensation for all branches be executed in parallel, or is it safe for a runtime to just assume that any order is perfectly safe?

a sub-flow in a parallel state should be directly/individually compensatable: why is that a bad thing? Even if you had workflow written in code that in parallel starts multiple "actions" you would want to be able to compensate each one if needed.

Are you saying that 'action' branches should also be separately compensatable and repeatable?  Because this change completely ignores the fact that you also can't specify compensation or repeat for each action branch.
Imho, if a user wants to compensate a parallel state they should compensate the whole state.  If a customer wants their parallel state to be compensated in parallel, then the compensation state can be a parallel state:
states:
  - name: doParallel
    type: parallel
    branches:
    - workflowId: subWf1
    - actions:
      - functionRef: func1
    - workflowId: subWf2
    compensatedBy: doParallelCompensations

 - name: doParallelCompensations
    type: parallel
    branches:
    - workflowId: cleanupSubWf1
    - actions:
      - functionRef: cleanupFunc1
    - workflowId: cleanupSubWf2

If a user determines that compensation has to occur in a particular order serially, they have that control to even do fancy stuff like some serial and some parallel:
states:
  - name: doParallel
    type: parallel
    branches:
    - workflowId: subWf1
    - actions:
      - functionRef: func1
    - workflowId: subWf2
    compensatedBy: doCompensation1

 - name: doCompensation1
    type: subflow
    workflowId: cleanupSubWf2
    transition: doParallelCompensations
 - name: doParallelCompensations
    type: parallel
    branches:
    - actions:
      - functionRef: cleanupFunc1
    - workflowId: cleanupSubWf1

@tsurdilo =)

@jorgenj yeah the actions is an for compensation atm. will need to address that. I would probably suggest that each branch can have compensation logic

This is adding too much complexity for very little benefit.  The path we're taking here (adding compensation & repeat for branches in parallel) implies that we'll also add compensation at every level of every other state.
Are we then going to add...

Compensation for individual actions in Operation?
Compensation for individual loop inputs in ForEach?
Compensation for individual actions of individual loop inputs in ForEach?
Compensation for individual conditions of Switch / Event?

This is just one guys opinion, but just because we can think of a use-case for how someone might use compensation / repeat, doesn't mean it's a good idea to support that.  I think the bar for adding new features, at least to some degree, should be whether they can accomplish what they need with existing features.

@jorgenj no, only parallel state applies here. parallel state can be seen as a
split -> parallel individual business logic exec -> join
each of those parallel executions is not performed as a "unit of work", each branch can have a totally different
set of business instructions to what it should perform and has the right to define its own compensation imo
foreach state is a single unit of work , meaning its functionalities are not independent in nature, same for operation state.

each of those parallel executions is not performed as a "unit of work", each branch can have a totally different
set of business instructions to what it should perform and has the right to define its own compensation imo

What about this can not be accomplished with compensation at the state level only?   Please share an example that requires compensation for a specific branch.

@jorgenj
Regarding Please share an example that requires compensation for a specific branch.:
simplest example could be 2 branches, 1 with a short-running activity and the other is a long-running one. parallel state has completionType n_of_m where n is 1, meaning as soon as the short activity completes the parallel state can transition while the long one is still active. Before the long one completes the workflow starts compensation.
If you model the compensation of those 2 branches on the state level, you would have to check which activity actually completed. this can be very hard to do and imagine for a parallel state with a ton more branches.
by specifying compensation on the branch level this is much easier as the runtime knows which of the branches completed execution and can be compensated.


Adding @discordjs/rest in dependencies

Because required in deploy-commands.js, Close #86

Closing this PR.
It doesn't seem to me to be the concern in connection with the outcome.


Add Bluedroid A2DP and AVRC profile implementations

Make additional ESP-IDF functionality available: the IDF libraries for Bluetooth profiles Advanced Audio Distribution Profile (A2DP) and Audio / Video Remote Control.

This should bump the version number, I'm not sure if I should include that in my PR.


Button variant="naked" doesn't allow any styling

Repro: https://codesandbox.io/s/great-bardeen-9mmrp?file=/src/App.js

I was looking at this and the issue is because the naked class ends up with less specificity than p-5xl or background-color-primary-500.  0010 vs 0020 respectively. So you can style some properties just nothing that the naked class sets
A possible fix would be to rewrite how the naked buttons gets style so that it ends up not be a "sub-class" of button and is instead a sibling.
IMHO this (hard to get specificity) is a common problem with utility classes. I assume other component would suffer from similar issues but it might not be as common to want to use utility classes. What are the thoughts on the value of tackling this? Is this common?

A work around for this is that we've been using the <Box> component's as prop to create buttons that we can style (almost) however we want. As an example:
https://github.com/palmetto/ux-alchemy-prototype/blob/2b71869808c6f7491dad64e82ae037f68be6a72a/src/dtc/views/Power.jsx#L65-L79
With that, perhaps we should remove this prop?
So we might

I'm running into the same issue. We'd like the Palmetto App to use <Button isNaked> for clickable items that require custom styling. This is very difficult with the current implementation since it creates a high CSS specificity as well as including an inner span element:
<button class="button naked">{children}</button>

this requires CSS to be applied very specifically:
.customButton.customButton > span {
  // custom styles
}

My proposed solution is to not apply any styles with the naked class and to remove the inner span:
https://github.com/palmetto/palmetto-components/pull/624


Output color properties can be either six-digit hexadecimal or RGB. After converting to HTML, 8-digit hexadecimal colors cannot be recognized.

Is there an existing issue for this?

[X] I have searched the existing issues

The question
Output color properties can be either six-digit hexadecimal or RGB. After converting to HTML, 8-digit hexadecimal colors cannot be recognized.

Yes, i am facing same issue while converting delta to html,
i need 6 digit hex code, and new version gives 8 digit code, can we enhance and provide option in config, 6 digit or 8 digit, so user get code as per needed.


Crash doing message counter sync

Problem
Finally got fuzzing stood up, ran the fuzzer, got:
=34895== ERROR: libFuzzer: deadly signal
    #0 0x10e7fff95 in __sanitizer_print_stack_trace+0x35 (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x53f95)
    #1 0x10dac5798 in fuzzer::PrintStackTrace() FuzzerUtil.cpp:210
    #2 0x10daa9473 in fuzzer::Fuzzer::CrashCallback() FuzzerLoop.cpp:233
    #3 0x7fff6838d5fc in _sigtramp+0x1c (libsystem_platform.dylib:x86_64+0x35fc)
    #4 0x10dcfb15f  (<unknown module>)
    #5 0x7fff68263807 in abort+0x77 (libsystem_c.dylib:x86_64+0x7f807)
    #6 0x10d53a419 in chip::Transport::Session::AsSecureSession() Session.cpp:27
    #7 0x10da32851 in chip::secure_channel::MessageCounterManager::SendMsgCounterSyncResp(chip::Messaging::ExchangeContext*, chip::FixedSpan<unsigned char const, 8ul>) MessageCounterManager.cpp:236
    #8 0x10da30a87 in chip::secure_channel::MessageCounterManager::HandleMsgCounterSyncReq(chip::Messaging::ExchangeContext*, chip::System::PacketBufferHandle&&) MessageCounterManager.cpp:261
    #9 0x10da30610 in chip::secure_channel::MessageCounterManager::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) MessageCounterManager.cpp:96
    #10 0x10d4e83e2 in chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::Transport::PeerAddress const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) ExchangeContext.cpp:461
    #11 0x10d4f0b22 in chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::Transport::PeerAddress const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ExchangeMgr.cpp:305
    #12 0x10d545516 in chip::SessionManager::SecureGroupMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) SessionManager.cpp:612
    #13 0x10d544984 in chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) SessionManager.cpp:375
    #14 0x10cfb9ac7 in LLVMFuzzerTestOneInput main.cpp:147
    #15 0x10daaa8c3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) FuzzerLoop.cpp:611
    #16 0x10daaa0da in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) FuzzerLoop.cpp:514
    #17 0x10daab589 in fuzzer::Fuzzer::MutateAndTestOne() FuzzerLoop.cpp:757
    #18 0x10daabfb5 in fuzzer::Fuzzer::Loop(std::__2::vector<fuzzer::SizedFile, std::__2::allocator<fuzzer::SizedFile> >&) FuzzerLoop.cpp:895
    #19 0x10da9adea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) FuzzerDriver.cpp:912
    #20 0x10dac6252 in main FuzzerMain.cpp:20
    #21 0x7fff68194cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)

NOTE: libFuzzer has rudimentary signal handlers.
      Combine libFuzzer with AddressSanitizer or similar for better crash reports.
SUMMARY: libFuzzer: deadly signal
MS: 3 ChangeBinInt-ChangeByte-PersAutoDict- DE: "\007\000\000\000\000\000\000\000"-; base unit: fa91c7912f718cfd3f1e59b25dea323175b722f3
0xe,0x0,0xf1,0xb1,0xf1,0xf1,0xf1,0xf1,0xed,0x73,0x7,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0xc1,0x0,0x0,0x0,0x0,0x0,0x5c,0xf3,0x25,0x0,0x0,0x0,0x0,0x0,
\016\000\361\261\361\361\361\361\355s\007\000\000\000\000\000\000\000\301\000\000\000\000\000\\\363%\000\000\000\000\000
artifact_prefix='./'; Test unit written to ./crash-c9fd2434ccf4a33a7f49765dcc519e1fd529a8e5
Base64: DgDxsfHx8fHtcwcAAAAAAAAAwQAAAAAAXPMlAAAAAAA=

Proposed Solution
Investigate why receiving the given payload:
0xe,0x0,0xf1,0xb1,0xf1,0xf1,0xf1,0xf1,0xed,0x73,0x7,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0xc1,0x0,0x0,0x0,0x0,0x0,0x5c,0xf3,0x25,0x0,0x0,0x0,0x0,0x0,

as a message leads to the above attempt to treat a non-CASE session as a SecureSession.

See also https://github.com/project-chip/connectedhomeip/issues/13397

From the stack trace, it looks like a Message counter sync is received as a group message. Guessing that groups are not a secure session Unlikely to yet they want to get secure counters from secure sessions.

Learning how to investigate this. So far I found:

building target linux-x64-all-clusters-libfuzzer seems to enable all cluster fuzzing
./out/linux-x64-all-clusters-libfuzzer/chip-all-clusters-app-fuzzing -help=1 gives some usage examples

@bzbarsky-apple - Do you by any chance have the reproduction file?
https://github.com/google/fuzzing/blob/master/tutorial/libFuzzerTutorial.md seems to say that to reproduce crashes without re-running fuzzing, one would pass in the crash file (?) as an argument to the binary.

Created a crash file with:
 open('crash-test', 'wb').write(binascii.a2b_base64('DgDxsfHx8fHtcwcAAAAAAAAAwQAAAAAAXPMlAAAAAAA='))

Crash test seems to say just 'Incorrect state' for ble. Did not see an obvious crash, but I may be building the wrong version of the app.

Merging #14514 may have made it much harder for the fuzzer to reach the relevant code, because now we need an actual valid MIC and whatnot to reach it....

I will try to change things to reproduce it. For now ran the fuzzer on 12 cores for about 20 minutes and no crash yet.
Created a fix of 'validate that input argument is indeed a secure session'. I also wonder if this may be a stateful thing as sessions are global state that the fuzzer likely does not reset.

Group sessions are not global state, fwiw...

I checked out ae05dfc82 and then was able to reproduce:
[1644262052.243952][4137057:4137057] CHIP:SPT: VerifyOrDie failure at ../../examples/all-clusters-app/linux/third_party/connectedhomeip/src/transport/Session.cpp:27: GetSessionType() == SessionType::kSecure
==4137057== ERROR: libFuzzer: deadly signal
    #0 0x558813dbacc4 in __sanitizer_print_stack_trace ../staging/llvm_build/tools/clang/stage2-bins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/compiler-rt/lib/ubsan/ubsan_diag_standalone.cpp:31:3

Will cherrypick my fix and validate

I can confirm that the CP made the test not crash.

From discussions with @bzbarsky-apple - it seems that this not really 'fix the crash' and more like 'group messaging does not implement MCSP' and existing code is not correct because it assumes 'secure  session' (non-group) which would generally  not work. This code path is supposed to only apply to groups.


How long it will take to train downstream tasks?

Hi,
thanks for opening source so briliant work!
It said in  PointContrast/issues/12 that

It takes around 40 hours to train scripts/ddp_local.sh (60000 iters with batch size 32) on 8 GPUs (like V100)

I am curious about how long it will take to train downstream tasks, such as semantic segmentation？
Best

@iris0329 Thanks for the question - the downstream task training is much faster, e.g. for semantic segmentation tasks on ScanNet, it takes around 9 hours with 8 V100 GPUs.

Thank you ~


RenderStatePackeger hits MAX_PATH limit on the Windows platform

RenderStatePackeger is hitting MAX_PATH limitation on Windows when opening .json files which are deep in subfolder hierarchy.

This issue should be fixed in the latest version of core module - please try updating it and check if it works now.

It works now.


Dave Camp still shows as head of Ways and Means in committee-membership-current

Or am I misreading it?  It shows Paul Ryan as a member and Dave Camp as Chair.

I think we're paused on committees because the data from the House and Senate are incomplete. See the bottom of #223.

Ahhh... thank you for the explanation.  I'll wait until it's all sorted out and then re-upload.
It seemed strange that Lamar Alexander was still the minority ranking member of HELP as well.

Pretty sure this was solved long ago.


Add fixer to update BaseCommand.requires_system_checks

https://docs.djangoproject.com/en/dev/releases/3.2/#deprecated-features-3-2

Using a boolean value in BaseCommand.requires_system_checks is deprecated. Use '__all__' instead of True, and [] (an empty list) instead of False.

Yeah! 👍👏


Removed  binding to avoid issues with terminal arrow keys

Hello, I'm a new vim-grepper user. I'm really liking this project so far, thank you! 😄
I noticed that arrow keys weren't working properly for me in the :Grepper prompt. e.g. when trying to go back through the search history.
It looks like the code to temporarily rebind the <esc> key is causing problems. I think it must be because pressing an arrow key sends a sequence of characters including an esc character. This stackoverflow question might be relevant..?
Please consider this PR as a workaround since its just deleting the code—but it seems to fix the problem and the esc key still seems to work ok. I'm probably missing something important though. 😅

Some extra info about my vim setup in case it helps:
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jan  1 2017 18:13:09)
MacOS X (unix) version
Included patches: 1-134
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +file_in_path    +mouse_sgr       +tag_old_static
+arabic          +find_in_path    -mouse_sysmouse  -tag_any_white
+autocmd         +float           +mouse_urxvt     -tcl
-balloon_eval    +folding         +mouse_xterm     +termguicolors
-browse          -footer          +multi_byte      +terminfo
++builtin_terms  +fork()          +multi_lang      +termresponse
+byte_offset     -gettext         -mzscheme        +textobjects
+channel         -hangul_input    +netbeans_intg   +timers
+cindent         +iconv           +num64           +title
-clientserver    +insert_expand   +packages        -toolbar
+clipboard       +job             +path_extra      +user_commands
+cmdline_compl   +jumplist        +perl            +vertsplit
+cmdline_hist    +keymap          +persistent_undo +virtualedit
+cmdline_info    +lambda          +postscript      +visual
+comments        +langmap         +printer         +visualextra
+conceal         +libcall         +profile         +viminfo
+cryptv          +linebreak       +python          +vreplace
+cscope          +lispindent      -python3         +wildignore
+cursorbind      +listcmds        +quickfix        +wildmenu
+cursorshape     +localmap        +reltime         +windows
+dialog_con      -lua             +rightleft       +writebackup
+diff            +menu            +ruby            -X11
+digraphs        +mksession       +scrollbind      -xfontset
-dnd             +modify_fname    +signs           -xim
-ebcdic          +mouse           +smartindent     -xpm
+emacs_tags      -mouseshape      +startuptime     -xsmp
+eval            +mouse_dec       +statusline      -xterm_clipboard
+ex_extra        -mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax
+farsi           +mouse_netterm   +tag_binary
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -L/usr/local/lib  -L/usr/local/lib -o vim        -lm  -lncurses -liconv -framework Cocoa   -fstack-protector -L/usr/local/lib  -L/System/Library/Perl/5.16/darwin-thread-multi-2level/CORE -lperl -F/usr/local/Cellar/python/2.7.11/Frameworks -framework Python   -lruby.2.0.0 -lobjc

I'm using iTerm2 for my terminal.

Hi,
First of all, I'm glad you like the plugin. :-)
But I don't see any way around this. The <esc> mapping was demanded by many users, so that the :Grepper prompt can easily be cancelled. In the same way you would cancel command mode (aka switch back to normal mode).
You're right, hitting <up> in Vim probably sends <esc>0a. (Try <c-v><up> in insert mode.)
Possible solutions:

You can change the sequence in Vim (without needing to modify the terminfo database, therefore the entries for your $TERM) and remap those sequences with :imap afterwards: http://vim.wikia.com/wiki/Fix_arrow_keys_that_display_A_B_C_D_on_remote_shell

Using another, more vi-like, combination, e.g. <c-n>/<c-p>.

Use Neovim. It's based on libtermkey and reads <esc> and <up> as distinguishable sequences. (Tested with iTerm2.)

I hope this helps, since removing <esc> mapping is unfortunately no option.
p.s. I should document it as an edge-case, though.

Bummer, that's unfortunate. Fair enough though.
Is this the previous issue? https://github.com/mhinz/vim-grepper/issues/58
Yeah, I can see now that hitting escape will still execute the search.
I might play around with this some more and see if I can work something out. Thanks for the help!

#58 was for the command-line window (q: in normal mode). Here's the first issue about it: #23.
I'd love to have a solution for it, but I just can't see it. Nevertheless, sometimes finding a solution is easier for people from the outside, because authors are always kind of biased. :-)

Yep, totally understand haha. Being an open source project maintainer isn't always easy—respect.
I'll look at some other vim plugins I use and see how they do similar things. They might have similar bugs now I think about it.. 😉

I noticed that vim's input() function will return an empty string when hitting escape. I assume there are cases where this is desirable and so it can't be relied on to detect that a user cancelled the prompt? I'll keep looking. Cheers!

Well, it's also a feature that an empty input means using the word under the cursor as query instead.
In hindsight, I'm not really happy about that implicitness, but I'm also reluctant to remove that feature and tell people to explicitly use :Grepper -cword instead.


ABC Race: Add mode to results page

So, if screenshots are taken, they know what mode they completed.

Added in 5c5010ed890fc9d09147bd1c3a6dc7e5ec5f1cc3


Spike: Basic error handling of recipes using NR Diag

If a recipe errors out and fails to execute, we need to have some basic error handling and display diagnostic information to the user. This is a spike to prove if we can run NR Diag through the CLI for this purpose. We may also want to capture the information from NR Diag and send it over to support whenever necessary. The current thinking is that we can tell the CLI to run specific NR Diag tasks within a recipe in order to handle the errors and display + capture appropriate diagnostic information.
Acceptance Criteria:
Explore the output of the NR Diag tasks run in #VIRTUOSO-58 and come to a conclusion whether we can use NR Diag for basic error handling. After this spike is completed, we should be able to conclude whether we can use NRDiag as is, whether we need to enhance NR Diag to satisfy our use case, or whether we need to take a different approach for error handling all together.
Aha! Link: https://newrelic.aha.io/features/VIRTUOSO-73

Comment added by Joel Worrall in Aha! - View
https://docs.google.com/document/d/1vmKA4zAKzswsKzZCJGnZiauRAav3c0l4Vgbqkhow4Hs/edit#heading=h.k2txyi4d5v4b

Comment added by Rishi Mukhopadhyay in Aha! - View
Capturing some of the discussions in Slack here:

In the case of the cold-start default flow where we install infra, logging and any discovered OHIs, we show success if the Infrastructure agent has installed successfully (even if logging/or other OHI recipes have failed)
In the case that we specify running of a particular recipe name/url using the command line flag we show failure in the case that that recipe has failed.

Comment added by Zach Leslie in Aha! - View
Initial error messaging in https://github.com/newrelic/newrelic-cli/pull/541


cannot use pulimi's aws.ecr or awsx.ecr with ion

hey I am trying to use an ecr within ion and pulumi's awsx provider. I have some code like this
  const repo = new awsx.ecr.Repository("ai_ingest", {
    name:"ai_ingest",
  });

but this throws an error in the sst deploy:
×  Failed
   Invalid component name "ai_ingest". Component names must start with an uppercase letter and contain only alphanumeric characters.

However an ecr's name cannot start with an uppercase letter so I cannot even explicitly set the name to start with an uppercase letter.
 Failed
   AiIngestEcr awsx:ecr:Repository → aiingestecr aws:ecr:Repository
   InvalidParameterException: Invalid parameter at 'repositoryName' failed to satisfy constraint: 'must satisfy regular expression '(?:[a-z0-9]+(?:[._-][a-z0-9]+)
   /)
   [a-z0-9]+(?:[._-][a-z0-9]+)
   ''

can you try setting the name differently from the name in code?
like this
      const repository = new aws.ecr.Repository("DockerRepository", {
        name: [$app.name, $app.stage].join("-"),
        forceDelete: true,
      });

Thanks that works! Why is the forceDelete required?


Unset DISPLAY variable for wayland

See #167
This is the fix that I currently use to get ly to work with sway. I am not sure if this is the proper way to implement it as I have only tested it on bash and zsh. Also to note is that it does not fix the problem of XDG_SESSION_TYPE being set to tty

Why are checks failing? The area highlighted as "failed" was there before I modified the code

@rhysperry111 Well CodeFactor is supposed to generate the quality badge you can see in the readme, but promoted itself to code-reviewing for some reason. Don't pay attention. I am taking a look at the issue with Sway right now, it could take a while.

As explained here, #167 is now fixed internally. Thanks again :)


Improve tour design

Yeah I definitely need to fix that image, will do in a next PR but already got a bunch to validate and release 😬

Yeah I definitely need to fix that image, will do in a next PR but already got a bunch to validate and release 😬


Waypoint: Generate Random Whole Numbers with JavaScript

Challenge Waypoint: Generate Random Whole Numbers with JavaScript has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
var randomNumberBetween0and19 = Math.floor(Math.random() * 10);

function myFunction() {

  // Only change code below this line.

  return Math.floor(Math.random() * 1000);

  // Only change code above this line.
}

A requirement for this exercise is that I change the multiplication of Math.random() of 20 to 10 in order to get a number between 0 and 10. But that makes me change code above the comment "Only change code below this line".
On the other hand, in my actual solution, I multiplied the Math.random() function by a thousand. I guess the exercise was meant to actully make the user change that value there to 10, instead of inserting any random number. Or none at all... it also works, but the result is always 0 ;-)
Thanks for checking!

Humm, looks like we're just matching 10 literally, not making sure there are no characters following.
I'm not sure why you persisted in changing code above the line.  There is not much we can do if you don't follow directions.  I suppose we could add a test to ensure that the 20 is still there.

The code they are looking for is pretty simple...should look something like this...
function myFunction(){
return Math.floor(Math.random()*10);
}

Alright, then I guess I changed it because initially it would not take my solution. I did not multiply by 10 where I had to. Thus I thought I had to change the code above the comment.

I looked back at my solution and ran it again and found it doesn't work any more! My answer is exactly the same as @lbray.
I then checked the test code and found the second-listed test "You should be using Math.random to generate a random number." having the assert statement editor.getValue().match(/Math.random/g).length > 1. This checks that there is greater than one instance of Math.random. However, the solution to this challenge only requires one instance of Math.random (e.g. Math.floor(Math.random()*10)).
So I think to fix this, the greater than signs should be changed to greater than or equal to signs.

Insert this inside the specified lines and it will work
var x = Math.floor(Math.random() * 10);
return x;
I also tried  returning Math.floor(Math.random() * 10) and for some reason it dosen't work.
So initialize a variable x with the function and return x.
It will work.

var randomNumberBetween0and19 = Math.floor(Math.random() * 20);

function randomWholeNum() {

  // Only change code below this line.

  return Math.floor(Math.random() * 10);
}

var randomNumberBetween0and10 = Math.floor(Math.random() * 10);
function randomWholeNum() {
randomNumberBetween0and10 = Math.floor(Math.random() * 10);
return Math.floor(Math.random());
}

`var randomNumberBetween0and10 = Math.floor(Math.random() * 10);
function randomWholeNum() {
// Only change code below this line.
randomNumberBetween0and10 = Math.floor(Math.random() * 10);
return Math.floor(Math.random());
}
`

function myFunction() {
// Only change code below this line.
return Math.random();
// Only change code above this line.
}


Farm Designer Map Tweaks and Tests

add more tests and fix rotated garden map image placement

Coverage increased (+0.2%) to 90.35% when pulling 925de087b2e738da00f705ad051380ecbcfc555d on gabrielburnworth:master into f9eeaeffa1d21ad55557ec186c993e50f41afae1 on FarmBot:staging.


[C++][Parquet] FindZLIB.cmake fails to detect libz.so in the absence of libz.a

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wesm) / @wesm
Note: This issue was originally created as PARQUET-1019. Please see the migration documentation for further details.

Wes McKinney / @wesm:
We're not currently able to link dynamically to libz.so; I am not sure if this is something we want to enable (versus requiring a vendored libz.a, since we statically link the symbols).


Feature: add description for local building and testing with docker

This PR adds a description of how to build and run the website using a docker image.

I will have to take your word on this -- I try to avoid Docker as much as I can!

I will have to take your word on this -- I try to avoid Docker as much as I can!

any suggested alternatives to Docker?

It's fine to use Docker, but I'm probably not the best one to review it. :)

Are you fine with the PR @ahankinson ?

I guess this one is fine to merge @ahankinson ?

I can't say either way -- if it works for you then it's OK?


Go live server is not working

Type: Performance Issue
Hey there this is Jay  and i'm facing one problem i.e., my go live server is not working. Please help me to get out from this issue.
VS Code version: Code 1.77.0 (7f329fe6c66b0f86ae1574c2911b681ad5a45d63, 2023-03-29T10:02:16.981Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

@jay190kumar
I couldn't locate go live server, however, I was able to install Live Server v5.7.9. This might have been a transient issue. I suggest giving it a try again.


UI updates in Android sample app

The UI updates will be discussed and added in this issue's comments.

Create a Figma sketch for reference

Write the stories for #88 update

this example app will be moved to the examples repository


fix(docs): Fix broken links in documentation

Fix broken links in the documentations at:

dev\contributing.md
config\preprocessors.md

Thanks, please change the commit message to docs(config): .. and docs(dev): .. as fix is reserved for actual code fixes.

@dignifiedquire: The commit message has been successfully changed to the preferred commit message format.

Thanks :octocat:


Improve the visibility of Discord channel and add contributions section to readme

Discord badge now better matches dimensions and style of the other badges.
Added Discord as the community entry in the table of contents.
I've removed the link to the gitter since it was never used and likely never will be.

Thanks, pre-commit is failing because of a line too long.

I'll get to this as soon as I can.

It now passes when I run pre-commit run doc8 --all-files, let me know if any further changes are required.

Great thanks!


added the sendAction method

https://developers.facebook.com/docs/messenger-platform/send-api-reference/sender-actions

Hey @tyvdh . I'm sorry I have been so busy to check this PR. I have given you access to this repo and NPM publish to the package so you can merge this and publish it.
I appreciate your work and trust you.


Moving around the window causes white screens on portion or all of the editor

Im using Win11

Is it temporary (like, it starts rendering after you stop moving it), or does it stay blank?

Is it temporary (like, it starts rendering after you stop moving it), or does it stay blank?

yes it starts rendering when i stop moving it

Should be fixed


Merge master into dev 1.21 - 4/7/21

Merge master into dev-1.21 to keep in sync - SIG-Release 1.21 Docs team 4/7/21
/cc @mvortizr @tengqm @PI-Victor @ChandaniM123 @sftim

There was a merge conflict with the zh localization of the feature-gates.
I accepted both changes as the master branch had one additional feature-gate of Sysctls added and the dev-1.21 had additional changes

/lgtm

/lgtm
do we need an approval from zh localization group?

No, @PI-Victor not necessary for sync
/approve


improve grayscale morphology docstrings

The goal of this MR is to make the behavior of the structure argument clearer and avoid confusion as seen, for example, in #19384

Looks like there was an unrelated failure in linalg:
scipy/sparse/linalg/tests/test_expm_multiply.py:35: in wrapped
    with pytest.warns(UserWarning,
E   RuntimeWarning: overflow encountered in multiply
        args       = (<5x5 MatrixLinearOperator with dtype=float64>, array([[ 1.22796439, -1.14500358],
       [-1.02018788, -0.39673356],
       [ 0.71869298, -0.84965727],
       [-0.36083862, -0.3083584 ],
       [-0.84761337, -1.80172566]]))
        func       = <function expm_multiply at 0xe588bc40>
        kwds       = {'endpoint': True, 'num': 2, 'start': 0.1, 'stop': 3.2}
=========================== short test summary info ============================
FAILED scipy/sparse/linalg/tests/test_expm_multiply.py::TestExpmActionInterval::test_expm_multiply_interval_matrix
= 1 failed, 49340 passed, 2580 skipped, 11447 deselected, 566 xfailed, 12 xpassed in 632.01s (0:10:32) =

@rskothari does this help explain things?

@lucascolley Yes it helps. Thank you for the improvements.


iOS 14 Flutter  ImageFilter.blur Crash

Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.4 19E287)
• Flutter version 1.17.5
• Framework revision 8af6b2f038 (10 months ago)
• Engine revision ee76268252
• Dart version 2.8.4

Hi @zilaiyedaren
Can you please upgrade to the latest  stable and try again
flutter channel stable
flutter upgrade --force
flutter doctor -v
If the issue persists, can you please provide your flutter doctor -v, your flutter run --verbose and a minimal complete reproducible code sample?
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Fix escape double quotes on bootstrap install script

Fixes error on creation of a new app using -css bootstrap flag or ./bin/rails css:install:bootstrap
Rails output before this fix
Build into app/assets/builds
       exist  app/assets/builds
   identical  app/assets/builds/.keep
File unchanged! Either the supplied flag value not found or the content has already been inserted!  app/assets/config/manifest.js
Stop linking stylesheets automatically
        gsub  app/assets/config/manifest.js
File unchanged! Either the supplied flag value not found or the content has already been inserted!  .gitignore
File unchanged! Either the supplied flag value not found or the content has already been inserted!  .gitignore
Remove app/assets/stylesheets/application.css so build output can take over
      remove  app/assets/stylesheets/application.css
Add stylesheet link tag in application layout
File unchanged! Either the supplied flag value not found or the content has already been inserted!  app/views/layouts/application.html.erb
      append  Procfile.dev
Add bin/dev to start foreman
   identical  bin/dev
Install Bootstrap with Bootstrap Icons, Popperjs/core and Autoprefixer
   identical  app/assets/stylesheets/application.bootstrap.scss
         run  yarn add sass bootstrap bootstrap-icons @popperjs/core postcss postcss-cli autoprefixer nodemon from "."
yarn add v1.22.19
warning ../../../package.json: No license field
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Saved 8 new dependencies.
info Direct dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>info All dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>✨  Done in 3.72s.
File unchanged! Either the supplied flag value not found or the content has already been inserted!  config/initializers/assets.rb
Appending Bootstrap JavaScript import to default entry point
File unchanged! Either the supplied flag value not found or the content has already been inserted!  app/javascript/application.js
Add build:css:compile script
         run  npm pkg set scripts.build:css:compile="sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules" from "."
         run  yarn build:css:compile from "."
yarn run v1.22.19
warning ../../../package.json: No license field
$ sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules
✨  Done in 2.77s.
Add build:css:prefix script
         run  npm pkg set scripts.build:css:prefix="postcss ./app/assets/builds/application.css --use=autoprefixer --output=./app/assets/builds/application.css" from "."
         run  yarn build:css:prefix from "."
yarn run v1.22.19
warning ../../../package.json: No license field
$ postcss ./app/assets/builds/application.css --use=autoprefixer --output=./app/assets/builds/application.css
✨  Done in 1.40s.
Add build:css script
         run  npm pkg set scripts.build:css="yarn build:css:compile && yarn build:css:prefix" from "."
         run  yarn build:css from "."
yarn run v1.22.19
warning ../../../package.json: No license field
$ yarn build:css:compile && yarn build:css:prefix
warning ../../../package.json: No license field
$ sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules
warning ../../../package.json: No license field
$ postcss ./app/assets/builds/application.css --use=autoprefixer --output=./app/assets/builds/application.css
✨  Done in 4.44s.
Add watch:css script
         run  npm pkg set scripts.watch:css="nodemon --watch ./app/assets/stylesheets/ --ext scss --exec "yarn build:css"" from "."
npm ERR! code EUSAGE
npm ERR!
npm ERR! npm pkg set expects a key=value pair of args.
npm ERR!
npm ERR! Manages your package.json
npm ERR!
npm ERR! Usage:
npm ERR! npm pkg set <key>=<value> [<key>=<value> ...]
npm ERR! npm pkg get [<key> [<key> ...]]
npm ERR! npm pkg delete <key> [<key> ...]
npm ERR! npm pkg set [<array>[<index>].<key>=<value> ...]
npm ERR! npm pkg set [<array>[].<key>=<value> ...]
npm ERR! npm pkg fix
npm ERR!
npm ERR! Options:
npm ERR! [-f|--force] [--json]
npm ERR! [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
npm ERR! [-ws|--workspaces]
npm ERR!
npm ERR! Run "npm help pkg" for more info

npm ERR! A complete log of this run can be found in: /Users/wellington/.npm/_logs/2023-09-16T00_17_17_111Z-debug-0.log
        gsub  Procfile.dev

Rails output after this fix
Build into app/assets/builds
       exist  app/assets/builds
   identical  app/assets/builds/.keep
File unchanged! Either the supplied flag value not found or the content has already been inserted!  app/assets/config/manifest.js
Stop linking stylesheets automatically
        gsub  app/assets/config/manifest.js
File unchanged! Either the supplied flag value not found or the content has already been inserted!  .gitignore
File unchanged! Either the supplied flag value not found or the content has already been inserted!  .gitignore
Remove app/assets/stylesheets/application.css so build output can take over
      remove  app/assets/stylesheets/application.css
Add stylesheet link tag in application layout
File unchanged! Either the supplied flag value not found or the content has already been inserted!  app/views/layouts/application.html.erb
      append  Procfile.dev
Add bin/dev to start foreman
   identical  bin/dev
Install Bootstrap with Bootstrap Icons, Popperjs/core and Autoprefixer
   identical  app/assets/stylesheets/application.bootstrap.scss
         run  yarn add sass bootstrap bootstrap-icons @popperjs/core postcss postcss-cli autoprefixer nodemon from "."
yarn add v1.22.19
warning ../../../package.json: No license field
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Saved 8 new dependencies.
info Direct dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>info All dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>✨  Done in 3.77s.
File unchanged! Either the supplied flag value not found or the content has already been inserted!  config/initializers/assets.rb
Appending Bootstrap JavaScript import to default entry point
File unchanged! Either the supplied flag value not found or the content has already been inserted!  app/javascript/application.js
Add build:css:compile script
         run  npm pkg set scripts.build:css:compile="sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules" from "."
         run  yarn build:css:compile from "."
yarn run v1.22.19
warning ../../../package.json: No license field
$ sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules
✨  Done in 2.75s.
Add build:css:prefix script
         run  npm pkg set scripts.build:css:prefix="postcss ./app/assets/builds/application.css --use=autoprefixer --output=./app/assets/builds/application.css" from "."
         run  yarn build:css:prefix from "."
yarn run v1.22.19
warning ../../../package.json: No license field
$ postcss ./app/assets/builds/application.css --use=autoprefixer --output=./app/assets/builds/application.css
✨  Done in 1.38s.
Add build:css script
         run  npm pkg set scripts.build:css="yarn build:css:compile && yarn build:css:prefix" from "."
         run  yarn build:css from "."
yarn run v1.22.19
warning ../../../package.json: No license field
$ yarn build:css:compile && yarn build:css:prefix
warning ../../../package.json: No license field
$ sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules
warning ../../../package.json: No license field
$ postcss ./app/assets/builds/application.css --use=autoprefixer --output=./app/assets/builds/application.css
✨  Done in 4.42s.
Add watch:css script
         run  npm pkg set scripts.watch:css="nodemon --watch ./app/assets/stylesheets/ --ext scss --exec \"yarn build:css\"" from "."
        gsub  Procfile.dev

I've experienced this error as well. I don't know what changed, previously I was able to run rails new app --css=bootstrap just fine. I hope this gets prioritized, because it's affecting the rails new command.

I've experienced this error as well. I don't know what changed, previously I was able to run rails new app --css=bootstrap just fine. I hope this gets prioritized, because it's affecting the rails new command.

This seems like  a missed testcase for add_package_json_script with the introduction of Bun support.
https://github.com/rails/cssbundling-rails/commit/2673455f3f25e0d29f5286caed739726bee5253b

Seems like the original implementation also had triple backslashes:
https://github.com/terracatta/cssbundling-rails/blob/8b005a2c313f56a4a9590c4b50302892917419d4/lib/install/bootstrap/install.rb#L37


Release actions

This PR adds functionality to add .deb files as part of the regular releases. This is done with the addition of .github/release-deb.yml. The README was also updated to include .deb install instructions, and also had some general updates.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:loudspeaker: Thoughts on this report? Let us know!


Modify broken link

Fix broken link to CIP mentioned in #689

For me, the link is already working in the main branch. Please check via the link I provided below
https://developers.cardano.org/docs/get-started/technical-concepts

For me, the link is already working in the main branch. Please check via the link I provided below
https://developers.cardano.org/docs/get-started/technical-concepts

It redirects to broken page

Happy to approve it but I believe it is again this issue #312 it is a problem when using relative links, it seems the only good way to rule this out is to write /docs/something
This seems to be an ongoing thing, also mentioned a few times now like in #628

thanks @katomm - I didn't know about the background on the relative pathnames & merged https://github.com/cardano-foundation/developer-portal/pull/687 without being aware of this. 😰
If I understand https://github.com/cardano-foundation/developer-portal/pull/312#issuecomment-924725013 correctly, links to markdown files should always be absolute pathnames beginning with /docs until some future version of Docusaurus makes this unnecessary?

... and that the correct href in the case of this PR would therefore be /docs/governance/cardano-improvement-proposals/CIP-0001.md?
... and that this qualification only applies to markdown files?

@rphair Yes, that's my understanding (but I could be wrong)
More insights on linking to markdown files here: https://docusaurus.io/docs/markdown-features/links

@fill-the-fill any update here? Can we just link to /docs/governance/cardano-improvement-proposals/CIP-0001? I'm pretty sure this fixes it.

@fill-the-fill any update here? Can we just link to /docs/governance/cardano-improvement-proposals/CIP-0001? I'm pretty sure this fixes it.

Works 👍


Change from StrictNewVersion to NewVersion to account for the leading v

The leading v in the Zarf version was silently erroring the backwards compatibility for Zarf init package pulling.
Related Issue
Fixes #529
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

Checklist before merging

[X] (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@megamind came to this after some discussions with @YrrepNoj as it will pull the correct init release if we ever needed to go backward on a branch and build something (or if a breaking release was just pushed and someone was working off of an older version of the code).  We cannot completely get rid of the semver package as it is an indirect dependency of another library.

I also removed the spaces so that the Make versions are correct and do not contain a leading space.

I also removed the spaces so that the Make versions are correct and do not contain a leading space.

okay now you're just showing off 😆.


Add Varnish integration saved views

What does this PR do?
Add saved views for the Varnish integration
Motivation
Saved views are now included in integrations
Additional Notes

https://github.com/DataDog/integrations-core/pull/5713
https://github.com/DataDog/integrations-core/pull/5865
https://github.com/DataDog/integrations-core/pull/5866
https://github.com/DataDog/integrations-core/pull/5870
https://github.com/DataDog/integrations-core/pull/5871
https://github.com/DataDog/integrations-core/pull/5872
https://github.com/DataDog/integrations-core/pull/5873
https://github.com/DataDog/integrations-core/pull/6386
https://github.com/DataDog/integrations-core/pull/6393
https://github.com/DataDog/integrations-core/pull/6401
https://github.com/DataDog/integrations-core/pull/6402
https://github.com/DataDog/integrations-core/pull/6403
https://github.com/DataDog/integrations-core/pull/6407
https://github.com/DataDog/integrations-core/pull/6408
https://github.com/DataDog/integrations-core/pull/6410

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Stagging --> ok


Refactoring integration test

Update integration test logic to align with CITF

Codecov Report

Merging #62 into master will decrease coverage by 14.59%.
The diff coverage is 7.4%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   70.73%   56.13%   -14.6%
==========================================
  Files          20       21       +1
  Lines         721     1010     +289
==========================================
+ Hits          510      567      +57
- Misses        170      396     +226
- Partials       41       47       +6

Impacted Files
Coverage Δ

integration_test/ndm_util/ndm_util.go
19.72% <7.4%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece7f5d...8bb2d8f. Read the comment docs.

@a4abhishek I think there are some files which are a candidate for refactoring having 60 or more lines of code.
I think these should be resolved, may be it can cause problems for coming PRs.
cc @kmova

@sagarkrsd please check if current status of bettercodehub is OK. Please feel free to comment if its not.


⚠ Realtime Client API Service has degraded performance

In 8a59bd4, Realtime Client API Service (https://api.ooica.net/feed/status) experienced degraded performance:

HTTP code: 200
Response time: 9758 ms

Resolved: Realtime Client API Service performance has improved in 5f9c457 after 6 minutes.


[downloader/hls] Delegate extraction to ffmpeg when unsupported features detected

This PR introduces the delegation feature for native hls downloader: i.e. native hls downloader will delegate extraction to FFmpegFD when it realizes that it's not capable of downloading requested stream.
This can be useful when:

Some extractor forces entry_protocol='m3u8_native' in InfoExtractor._extract_m3u8_formats but eventually (e.g. due to some change on remote side) incoming manifest start using features hlsnative does not support.
When one forces --hls-prefer-native (e.g. in configuration file) and tries to download stream hlsnative is not capable to.

If we carefully craft the set of unsupported features we can even force m3u8_native=True in InfoExtractor._extract_m3u8_formats though this will require additional request to download manifest all the time when hlsnative is not capable to handle it.

If we carefully craft the set of unsupported features we can even force m3u8_native=True in InfoExtractor._extract_m3u8_formats though this will require additional request to download manifest all the time when hlsnative is not capable to handle it.

i think it's better to keep the default to reduce request if it's possible and enable it by default in places when the first point happen:
examples of the places that it will be usfull to use it:

sites that uses like tf1, tubitv.
sites that depend on other extractors that serve both types(encrypted and non encrypted) like sites that depend on brightcove and theplatform.
so in general if we know that the site always serve encrypted/live manifests than it's better to use ffmpeg by default else use HlsFD downloader.

this will be also helpful for #8201(if pycrypto is not available than it fall back to ffmpeg).


[Bug]: Server Crashes

Describe the Bug
Installed mod on the client, worked perfect however the hitbox didn't work as intended so I installed it on the server and as soon as I log on, and attempt to move, the server crashes.
Mod version(s) affected
1.0.4
Mod loader(s) used
Fabric
Minecraft version(s) used
1.21
Other mods used
Entity Model Features [2.1] Amplified Nether [1.2.5] Sodium Extra [0.5.7+mc1.21] Lithium [0.12.5] EntityCulling [1.6.6] essential-container [1.0.0] Mod Menu [11.0.0-beta.2] Nullscape [1.2.6] Chat Heads [0.12.3] Mouse Tweaks [2.26] Sodium [0.5.9+mc1.21] Yet Another Minecraft BINGO [1.5.0+mc1.21.0] Fabric API [0.100.1+1.21] Architectury [13.0.1] YetAnotherConfigLib [3.5.0+1.21-fabric] Visuality [0.7.4+1.21] Terralith [2.5.3] Sound Physics Remastered [1.21-1.4.3] Xaero's Minimap [24.2.1] Jade [15.0.4+fabric] Freecam [1.3.0-beta1+mc1.21] Indium [1.0.33+mc1.21] No Chat Reports [1.21-v2.8.0] Xaero's World Map [1.38.8] NotEnoughAnimations [1.7.4] Dynamic Crosshair [8.0.1+1.21] Cloth Config v15 [15.0.127] Entity Texture Features [6.1.1] Just Enough Items [<IP_ADDRESS>] Scoreboard Overhaul [1.1.3-mc1.21.0] Reese's Sodium Options [1.7.2+mc1.21] 3d-Skin-Layers [1.6.6] Fabric Language Kotlin [1.11.0+kotlin.2.0.0] BetterF3 [11.0.0] Iris [1.7.1+mc1.21] AppleSkin [3.0.2+mc1.21] Simple Voice Chat [1.21-2.5.16] Configured [2.5.0] Fabric API [0.100.4+1.21] Continuity [3.0.0-beta.5+1.21] Distant Horizons [2.1.2-a] AutoRun [0.6.0] Force Crawl [1.0.4] Searchables [1.0.1] Controlling [18.0.1]
To Reproduce (If applicable)
Have both mod in client and server, try moving, crashes server
Additional Information
I was running shaders and Distant Horizons so my server could just be overloading

Do you have any crash logs?

Do you have any crash logs?

Yeah I do!
crash-2024-07-04_18.23.11-server.txt

Try this release:
https://github.com/FamroFexl/ForceCrawl/releases/tag/v1.0.5
It might have been improper arguments in the network packets.

Try this release: https://github.com/FamroFexl/ForceCrawl/releases/tag/v1.0.5
It might have been improper arguments in the network packets.

Works perfect! And players who don't have this mod can still join the server?

I believe so. Players just won't be able to "force" themselves into a crawling pose without it.


flit install ignores the "exclude" specified in tool.flit.sdist

Let's say I have a pyproject.toml that looks like this:
# ...
[tool.flit.sdist]
exclude = ["src/mypackage/foo.py"]

When I flit install, I noticed that I am still able to import the foo module. I can get around this with flit build and pip installing the wheel since the sdist correctly excludes foo.py.
Just wondering if it's expected that flit install does not take the sdist exclude into consideration.

It's sort of expected, because flit install builds a wheel and then asks pip to install it. But it probably shouldn't be.
Does it exclude the file if you do pip install . instead?


Auth GetEmailByAccountID returned an error on click of message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

click on FAB icon and select Split bill option
enter amount and click Next button
enter email which is not in list
select that user and click on Next button
click on that user from split bill list
click on Message button which will redirect to report screen

Expected Result:
should not show any error
Actual Result:
Auth GetEmailByAccountID returned an error appears
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/c9586650-34ab-47d9-b565-3099db4af839
https://github.com/Expensify/App/assets/43996225/a5eb38ce-4a73-4ce5-b7e5-977857a2b6c8
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690279806141209
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0ddbbb1696d85e7
Upwork Job ID:<PHONE_NUMBER>830935552
Last Price Increase: 2023-07-26

I think this will need to be internal because its probably because we're not creating accounts that don't exist the first time a bill is split. Labeling Internal

I think there's something to fix in frontend as well. Can we open this to contributors or add Engineering to pull up engineer?

Sounds like a plan to me! Adding the help wanted label

PR 23802 disabled clicking on an optimistically generated user for profile page. So I think there is nothing required on front-end for this.

@tgolen does this sounds correct to you? (In which case we actually do not need any contributor for this)

I agree. It sounds like we can simply close this out since it won't be a flow that is possible to trigger moving forward.


Decrypting GnuPG OpenPGP messages sometimes fails due to "No Literal Data found".

To be investigated.

Not a bug in PGPainless. Instead the input was base64 encoded, then ascii armored gnupg output. This is not to be expected as input.