Django CMS Plugin is down ...

https://github.com/mishbahr/cookiecutter-djangocms-plugin returns 404

Hi @mativs! Thank you.
Can you please also remove the according link from README.rst?
:bell: @mishbahr

Looks like we've fixed it already. Thanks :bow:


[✨] Add qwik add command for WebdriverIO

Is your feature request related to a problem?
Providing Playwright as the only solution for e2e testing suggests people it is fine to run tests in browser engines (some of which even modified) which by no means comes close the real browser and many folks have interest in testing in the browser that their users use.
There are whole talks about why testing in a browser engine is just not the same as testing in real browser: https://www.youtube.com/watch?v=Mo6LmFGrtxY
Describe the solution you'd like
Similar to #1926 I would love to help extend the qwik CLI to support the ability to use WebdriverIO.
Describe alternatives you've considered
n/a
Additional context
I am maintaining WebdriverIO and help at the W3C to move standards for browser automation forward. I am disappointed to see that frontend frameworks just go with the "popular" tool and disregard the development of the web platform. I am happy to step in and do the leg work. In my opinion Qwik deserves to be tested in real browser on desktop and mobile, powered by web standards and users should at least have the option to decide which tool to use.

Hi Christian!
This is awesome! i agree with you! and at qwik, we are currently in a good spot to start scaling the integrations, recently we been focusing on this!
I would recommend u to create a Qwik project (pnpm create qwik), then try to add WebDriverIO there, once we have that, it's easy to convert it to an integration, like this:
https://github.com/BuilderIO/qwik/tree/main/starters/features/playwright

Sounds good. I will set up a project and raise a PR.

Thanks @PatrickJS , I am happy to take this one when I get the time.

We moved this issue to qwik-evolution repo to create a RFC discussion for this.
Here is our Qwik RFC process thanks.


Documentation: hardware_uart

The description for uart_read_blocking() says: "This function will block until all the data has been received from the UART".  It is somewhat ambiguous what is meant by "all the data".  The function actually blocks until len (the third parameter) characters are read. May I suggest, "This function blocks until len characters have been read".
The function:  bool uart_is_readable() returns a bool but the description says that it returns the number of bytes with the observation that the number of bytes can only be zero or one.  May I suggest something like, "Returns true if a character can be read, otherwise returns false."  The description for bool uart_is_writable() gets this right.

It looks like I could contribute a fix - its a small change to comments in a header file - but, I've never contributed to an open source project.  I'm mainly unclear on whether to create my own branch or work in the existing develop branch.
Are these steps about right?

Navigate to https://github.com/raspberrypi/pico-sdk/
click the Fork button and uncheck the check box next to "Copy the Master branch only"
open a terminal emulator on my local (plain vanilla Debian Linux) machine
mkdir pico-sdk-contrib
cd pico-sdk-contrib
git clone https://github.com/bradselb/pico-sdk.git .
git remote -v
git remote add upstream https://github.com/raspberrypi/pico-sdk.git
git checkout develop
make edits to comments in header file
compile, test, etc.
git commit -m "revise comments in header file to improve SDK documentation"
git push
open a pull request

It's best to create a new branch for your contribution but that's about right. Make a fork, clone it into some directory, make a new branch, do your thing in said branch, test, commit, push and open a PR.

OK,  I'll give it a go. Thank you!


Create tool to aggregate V3 package issues found by the V3 monitoring job into a report

Currently, because we have so many packages with issues (most of them being very minor), it's hard to parse through the blobs and aggregate the different issues by hand. We should write a tool that will automatically aggregate the issues in a way that is more human readable.

We should fix V3 issues as they come up. On of the prerequisites of running a monitoring job is that it won't be noisy, so there should be nothing to report.
Closing this issue for now. We can reopen in the future if such a report is required.


Cannot longjmp from signal handler to recover from SIG{SEGV,ILL,...} on macOS

What version of Go are you using (go version)?

$ go version
go version go1.16 darwin/amd64

Does this issue reproduce with the latest release?
Yes (downloaded 1.16 from the weebsite)
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/acrichton/Library/Caches/go-build"
GOENV="/Users/acrichton/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/acrichton/code/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/acrichton/code/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/acrichton/code/gorepro/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b0/wd3mrtcj36l61jkqrzpdjds00000gn/T/go-build2517283257=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Given these files:

`go.mod`
module repro

go 1.16

`main.go`
package main

// #include "lib.h"
import "C"
import "fmt"

func main() {
        C.setup_signal_handler()
        for i := 0; ; i++ {
                if i%1000 == 0 {
                        fmt.Printf("%d\n", i)
                }
                C.do_trap()
        }
}

`lib.h`
#ifndef __lib_h
void setup_signal_handler(void);
void do_trap(void);
#endif

`lib.c`
#include <assert.h>
#include <setjmp.h>
#include <signal.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>

#if 0
#define platform_jmp_buf sigjmp_buf
#define platform_setjmp(a) sigsetjmp(a, 0)
#define platform_longjmp(a, v) siglongjmp(a, v)
#else
#define platform_jmp_buf jmp_buf
#define platform_setjmp(a) setjmp(a)
#define platform_longjmp(a, v) longjmp(a, v)
#endif

struct sigaction PREV;
static int MY_TRAP = 0;
static platform_jmp_buf JMP;

static void signal_handler(int signal, siginfo_t *info, void *data) {
  if (MY_TRAP) {
    MY_TRAP = 0;
    platform_longjmp(JMP, 1);
    assert(0);
  }

  // If we don't handle this delegate to the previous handler.
  if (PREV.sa_flags & SA_SIGINFO) {
    PREV.sa_sigaction(signal, info, data);
  } else if (PREV.sa_handler == SIG_DFL || PREV.sa_handler == SIG_IGN) {
    sigaction(signal, &PREV, NULL);
  } else {
    PREV.sa_handler(signal);
  }
}

void setup_signal_handler(void) {
  struct sigaction handler;
  handler.sa_sigaction = signal_handler;
  handler.sa_flags = SA_SIGINFO | SA_NODEFER | SA_ONSTACK;
  sigemptyset(&handler.sa_mask);
  int rc = sigaction(SIGSEGV, &handler, &PREV);
  assert(rc == 0);
}

void do_trap(void) {
  assert(MY_TRAP == 0);
  if (platform_setjmp(JMP)) {
    assert(MY_TRAP == 0);
  } else {
    MY_TRAP = 1;
    *(int*) 3 = 5;
    assert(0);
  }
}

I compiled this via go build. I then ran the resulting binary with ./gorepro. I changed the #if 0 to #if 1 as well and looked at the results.
What did you expect to see?
I expected both binaries to succeed, regardless of #if 0 or #if 1
What did you see instead?
The Go binary would also crash eventually (sometimes taking more time than others). The #if 1 case using sigsetjmp to recover would often crash much faster than the #if 0 case. In the #if 0 case, however, this wouldstill eventually crash.
Here's an example of the crashes:

fatal: morestack on g0
SIGTRAP: trace trap
PC=0x4063b22 m=0 sigcode=1

goroutine 0 [idle]:
runtime: unexpected return pc for runtime.abort called from 0xc000009ee0
stack: frame={sp:0xc000009a68, fp:0xc000009a70} stack=[0x7ffeefb80758,0x7ffeefbff7c0)

runtime.abort()
        /usr/local/Cellar/go/1.15.8/libexec/src/runtime/asm_amd64.s:860 +0x2

goroutine 1 [syscall]:
runtime.cgocall(0x40aa030, 0xc00005bf10, 0xc000000001)
        /usr/local/Cellar/go/1.15.8/libexec/src/runtime/cgocall.go:133 +0x5b fp=0xc00005bee0 sp=0xc00005bea8 pc=0x400465b
main._Cfunc_do_trap()
        _cgo_gotypes.go:41 +0x45 fp=0xc00005bf10 sp=0xc00005bee0 pc=0x40a9ec5
main.main()
        /Users/acrichton/code/gorepro/main.go:13 +0x2f fp=0xc00005bf88 sp=0xc00005bf10 pc=0x40a9f6f
runtime.main()
        /usr/local/Cellar/go/1.15.8/libexec/src/runtime/proc.go:204 +0x209 fp=0xc00005bfe0 sp=0xc00005bf88 pc=0x4035329
runtime.goexit()
        /usr/local/Cellar/go/1.15.8/libexec/src/runtime/asm_amd64.s:1374 +0x1 fp=0xc00005bfe8 sp=0xc00005bfe0 pc=0x4063d01

rax    0x17
rbx    0xc000009a40
rcx    0x41723a0
rdx    0x0
rdi    0x2
rsi    0xc0000099e0
rbp    0xc000009aa0
rsp    0xc000009a68
r8     0x41723a0
r9     0x834d92209e0071b5
r10    0xc000009a40
r11    0x206
r12    0x834d92209e0071b5
r13    0xa
r14    0x200
r15    0x38
rip    0x4063b22
rflags 0x202
cs     0x2b
fs     0x0
gs     0x0

In Go 1.15 I saw different crashes with sigsetjmp than with setjmp, but in Go 1.16 it looks like both crash in the same manner.

For some background this was originally reported as https://github.com/bytecodealliance/wasmtime-go/issues/60. Wasmtime is a WebAssembly runtime where WebAssembly traps translate to ud2 on x86_64 platforms, raising a SIGILL. We were seeing trouble after recently switching from setjmp to sigsetjmp but I've seen crashes for quite some time even using setjmp (as seen here). I've tried to reduce this to not having a whole WebAssembly runtime and instead just having one C file to poke around. The C mirrors what the runtime currently does in a rough manner.

Try setting GODEBUG=asyncpreemptoff=1. If a preemption signal occurs in the middle of a longjmp, it would not surprise me if something weird is going to happen.
(I'm not sure this kind of use of signal handler are supported by the Go runtime.)

Thanks for the tip! I also realized when testing that that I was testing the wrong program from earlier so I edited the description to say that setjmp and sigsetjmp have different crashes.
Testing out asyncpreemptoff=1 it looks like that does indeed fix the crash.
In that case is this something that's officially unsupported? Do we have no recourse to implement this form of a WebAssembly runtime in Go? Or are there perhaps other sycalls/etc we can do to protect against this?

Thanks for the reply. Good to know it works.

In that case is this something that's officially unsupported?

By "this", you mean asyncpreemptoff=1, or longjmp-from-signal-handler? For the former, it is a documented debug flag, so it should do what it says. Technically debug flags are not subject to compatibility, so it may change in future releases, or not.
For the latter, I actually don't know. The Go runtime internally does a lot of stack switches. It would not be surprising if another context switch mechanism (e.g. setjmp/longjmp) works together with it. It may work, or not, I don't know. If it can be supported without much extra complexity, I think we could probably support it.

Or are there perhaps other sycalls/etc we can do to protect against this?

I guess you could block preemption signal (SIGURG) in the code. Perhaps other signals as well, e.g. profiling signals (SIGPROF).

Ah yes sorry to clarify I mean the longjmp or siglongjmp-from-signal-handler and whether that's supported. I'd personally like to know more about it and what's causing the crash and what we can do to prevent it. While we could block some signals on entry/exit into wasm it seems better to figure out a more precise solution if possible. For example why doesn't this crash happen on Linux when it happens on macOS?

(Without looking into the detail) My guess it could be due to something weird of the longjmp and sigaltstack implementation on macOS (possibly bug). It seems the kernel delivers the signal on the user stack while we have sigaltstack set and the signal handler is registered with SA_ONSTACK. I can reproduce this in C.
#include <assert.h>
#include <setjmp.h>
#include <signal.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>

#if 1
#define platform_jmp_buf sigjmp_buf
#define platform_setjmp(a) sigsetjmp(a, 0)
#define platform_longjmp(a, v) siglongjmp(a, v)
#else
#define platform_jmp_buf jmp_buf
#define platform_setjmp(a) setjmp(a)
#define platform_longjmp(a, v) longjmp(a, v)
#endif

struct sigaction PREV;
static int MY_TRAP = 0;
static platform_jmp_buf JMP;

static void signal_handler(int signal, siginfo_t *info, void *data) {
  int x;
  if (MY_TRAP && (signal == SIGSEGV)) {
    MY_TRAP = 0;
    printf("SIGSEGV sp=%p\n", &x);
    platform_longjmp(JMP, 1);
    assert(0);
  }

  // If we don't handle this delegate to the previous handler.
  if (PREV.sa_flags & SA_SIGINFO) {
    PREV.sa_sigaction(signal, info, data);
  } else if (PREV.sa_handler == SIG_DFL || PREV.sa_handler == SIG_IGN) {
    sigaction(signal, &PREV, NULL);
  } else {
    PREV.sa_handler(signal);
  }
}

void setup_signal_handler(void) {
  struct sigaction handler;
  handler.sa_sigaction = signal_handler;
  handler.sa_flags = SA_SIGINFO | SA_NODEFER | SA_ONSTACK;
  sigemptyset(&handler.sa_mask);
  int rc = sigaction(SIGSEGV, &handler, &PREV);
  assert(rc == 0);
}

void do_trap(void) {
  assert(MY_TRAP == 0);
  if (platform_setjmp(JMP)) {
    assert(MY_TRAP == 0);
  } else {
    MY_TRAP = 1;
    *(int*) 3 = 5;
    assert(0);
  }
}

int main() {
  int i;
  stack_t sigstk;
  sigstk.ss_sp = malloc(SIGSTKSZ);
  printf("sigaltstack at %p, sp=%p\n", sigstk.ss_sp, &i);
  sigstk.ss_size = SIGSTKSZ;
  sigstk.ss_flags = 0;
  sigaltstack(&sigstk, 0);
  setup_signal_handler();
  for (i = 0; ; i++) {
    printf("%d\n", i);
    do_trap();
  }
}

On macOS,
sigaltstack at 0x7fb21c500000, sp=0x7ffee30a1988
0
SIGSEGV sp=0x7fb21c51fa84
1
SIGSEGV sp=0x7ffee30a13d4
2
SIGSEGV sp=0x7ffee30a13d4
3
SIGSEGV sp=0x7ffee30a13d4
4
SIGSEGV sp=0x7ffee30a13d4

At the first iteration the signal is delivered on the sigaltstack, but afterwards it is delivered on the main stack.
Whereas on Linux,
sigaltstack at 0x558ea53e62a0, sp=0x7ffd929429ec
0
SIGSEGV sp=0x558ea53e7d6c
1
SIGSEGV sp=0x558ea53e7d6c
2
SIGSEGV sp=0x558ea53e7d6c
3
SIGSEGV sp=0x558ea53e7d6c
4
SIGSEGV sp=0x558ea53e7d6c

The signal is always delivered on the sigaltstack.
The Go runtime requires signals be delivered on the sigaltstack, and it crashes when it is delivered on the user stack.

Oh dear, signals not being delivered on the sigaltstack does indeed sound like a bug in macOS itself! Either that or intended behavior of sigsetjmp/siglongjmp, unsure.
I'd imagine that explains at least some of this, but if setjmp and longjmp are used (changing to #if 0) then this it looks like sigaltstack is indeed used to deliver all the signals, even on macOS, but it still crashes in Go?

According to macOS's published sources siglongjmp namely differs from longjmp in that it doesn't call a function called _sigunaltstack which is changing the kernel's idea of whether or not the sigaltstack is used. This means that the problem with using siglongjmp to exit the signal handler is that on the delivery of the next signal the kernel thinks the sigaltstack is still in use and delivers it on the same stack (which happens to be the main user stack).
That at least explains the problem with using sig{set,long}jmp, but I think we can work around that locally (we use the sig versions since they're much faster than the other versions as they don't save/restore signal masks, which we don't need). The workaround seems to be to actually return from the signal handle (so the _sigunaltstack function is automatically called) but updating the ucontext_t parameter to resume in a "landing pad" which serves to only longjmp.
Implementing that technique appears to fix the issue with Go as well, I'm unable to see any more runtime errors. Notably with this lib.c I'm not seeing any crashes in Go:

lib.c
#include <assert.h>
#include <setjmp.h>
#include <signal.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>

#if 1
#define platform_jmp_buf sigjmp_buf
#define platform_setjmp(a) sigsetjmp(a, 0)
#define platform_longjmp(a, v) siglongjmp(a, v)
#else
#define platform_jmp_buf jmp_buf
#define platform_setjmp(a) setjmp(a)
#define platform_longjmp(a, v) longjmp(a, v)
#endif

struct sigaction PREV;
static int MY_TRAP = 0;
static platform_jmp_buf JMP;

static void do_jump(void) {
    platform_longjmp(JMP, 1);
    assert(0);
}

static void signal_handler(int signal, siginfo_t *info, void *data) {
  if (MY_TRAP) {
    MY_TRAP = 0;
    ((ucontext_t*)data)->uc_mcontext->__ss.__rip = (uint64_t) do_jump;
    ((ucontext_t*)data)->uc_mcontext->__ss.__rsp -= 8;
    return;
  }

  // If we don't handle this delegate to the previous handler.
  if (PREV.sa_flags & SA_SIGINFO) {
    PREV.sa_sigaction(signal, info, data);
  } else if (PREV.sa_handler == SIG_DFL || PREV.sa_handler == SIG_IGN) {
    sigaction(signal, &PREV, NULL);
  } else {
    PREV.sa_handler(signal);
  }
}

void setup_signal_handler(void) {
  struct sigaction handler;
  handler.sa_sigaction = signal_handler;
  handler.sa_flags = SA_SIGINFO | SA_NODEFER | SA_ONSTACK;
  sigemptyset(&handler.sa_mask);
  int rc = sigaction(SIGSEGV, &handler, &PREV);
  assert(rc == 0);
}

void do_trap(void) {
  assert(MY_TRAP == 0);
  if (platform_setjmp(JMP)) {
    assert(MY_TRAP == 0);
  } else {
    MY_TRAP = 1;
    *(int*) 3 = 5;
    assert(0);
  }
}

While it still seems odd that the usage of {long,set}jmp would cause the Go crashes above I'll probably work to implement this fix which will at least make the original issue moot on my end.

Calling longjmp to get out of a signal handler is unsafe.  A signal can occur at any time.  If the Go program happens to be manipulating some runtime data structure or holding a runtime lock at the time that the signal occurs, and the signal handler calls longjmp to jump over the Go code, then the program will fail.  Your program is failing without GODEBUG=asyncpreemptoff=1 because by default Go programs generate a lot of signals, making this failure more likely.  But the failure can still happen on any signal.
I'm going to close this issue because I think the request is impossible to implement in Go.  Please comment if you disagree.

I don't think it's correct to say that longjmp out of a signal handler is always unsafe. It's certainly quite frequently unsafe, and I agree that for async signals or longjmp at arbitrary points it is indeed unsafe, but my use case is a JIT compiler using longjmp to recover from faults in wasm. This means that 100% of the code between the longjmp invocations is controlled by the JIT runtime and signals are filtered so we don't try to longjmp from anything arbitrary, only known locations in JIT code that can fault (and with known signals).
This is not an issue about Go trying to longjmp. It's also not about dealing with Go code at all, the longjmp never crosses Go code and only crosses JIT code. I tried to make this clear in the example above (since the longjmp is entirely self-contained and doesn't cross Go at all). I didn't think it would be too useful have an example with the whole JIT compiler.
FWIW I'm having pretty poor experience reporting issues here having them be quickly deemed not bugs in Go. I tried to do my fair share in reducing, investigating, and documenting how to reproduce this issue. I did so in a different issue which was also deemed not a bug in Go, then was later fixed. I feel like I'm just being brushed off here as if I can't possibly know what I'm doing with signals, and I'm not really sure how to productively work with that.

My apologies for my incorrect assumption.  I jumped from the fact that setting GODEBUG=asyncpreemptoff=1 fixed the problem to assuming that your code was doing something wrong.
Still, this doesn't seem to be a bug in the Go runtime, and I don't see anything that the Go runtime could do to fix it.


Add offset to Bitmap for zero-copy slicing on non-byte boundaries

In addition to the offset field on a Bitmap:

add a rustfmt.toml with some nightly features enabled
modify some workflows to run with a nightly compiler
implement Extend for Bitmap.

bors r+


str/repr blows up for large disjoint states

Description of the issue
The repr and str functions of TrialResult and subclasses all compute the full state of the system as a kron of all disjoint states before displaying. In large disjoint states, this causes the system to hang. This can crop up in unusual places like assertions and stack traces. See https://github.com/quantumlib/Cirq/issues/4360#issuecomment-907514955.
How to reproduce the issue
In the density_matrix_simulator_test::test_large_untangled_okay unit test, change the number of qubits to mismatch. The simulation works fine, but the test then hangs at assert set(result._final_step_result.qubits) == set(cirq.LineQubit.range(59)), because it tries to calculate the repr of result to display. This led to users thinking that the simulation itself was hanging, which was not the case.
I propose we update these to display the individual state spaces and associated qubits, rather than joining into a single space prior to output.

I can take this. It's related to the state separation functionality introduced in #4100. Updating the code to output these as a list of independent state vectors or density matrices should be straightforward.
I think as part of this we should also add a public function to query for the independent state space that contains a qubit too. (e.g. trial_result.get_state(q1).qubits and trial_result.get_state(q1).density_matrix would return the qubits and density matrix for whatever state space q1 is in). Currently that's all private as an implementation detail, but if we're updating the str/repr to display this information, then it seems logical that we should have an easy way for users to get that raw data too. @95-martin-orion @MichaelBroughton thoughts?

I think as part of this we should also add a public function to query for the independent state space that contains a qubit too.

This sounds like a reasonable, low-cost addition to me - though I would prefer get_state_containing_qubit to be clear about what the method is doing. (e.g. to avoid confusion that a state is only associated with the provided qubits)

Updated linked PR with this function.


Automating QnA Generation for Knowledge Contributions using a In-pars style reranking Model

Disclaimer:
The exact implementation details of the proposal are for the team to review. The purpose of the proposal is to pitch an idea which closes the data->qna->knowledge->finetune loop. I want to work on this idea upstream and wanted to see if their is some ideas/suggestion from the ilab team

Currently ilab/taxonomy supports contributing two kinds of data: Knowledge and Skill

While skills are foundational or performative, knowledge is based more on answering questions that involve facts, data, or references. Knowledge is supported by documents, such as a textbook, technical manual, encyclopedia, journal, or magazine.

Based on the information above, knowledge contributors are required to manually read documents and craft relevant question-answer pairs (QnAs). This manual process is time-consuming, error-prone, and not scalable, especially for large or highly specialized datasets like recently published research papers, technical manuals, books and wiki-pages.
To address this limitation, I am proposing integrating an automated QnA generation pipeline using InPars-style re-ranker models. This enhancement will streamline the process of creating high-quality, grounded QnA pairs, enabling efficient generation of instruction data from complex and domain-specific documents.
These are the different stages of the pipeline:

Input Data Parsing (Data -> N chunks)
Breaking down your data (research paper or other textual chunks) into manageable parts, such as paragraphs. This chunking helps in analyzing the content effectively.

Generating Candidate Questions ( Generate 1 Question per chunk)
Utilize a capable LLM model with GBQ (Guided by Bad Questions) prompts from the MS MARCO datasets to get the most relevant question for each chunk of information.

Ranking the Candidate Questions (Get top-K questions)
Use the normalized log sum of the probability assigned by the model when autoregressively generating the ith token of the question. Get the top k questions and their corresponding chunks.

Generating the Ans to the top K questions (Answer top-K questions)
Given the data chunk (context) and the generated question K, generate the most relevant answer by prompting it to only use given information.

Format the QnA to a md file (QnA.md file)
Create a file structure with the provided document, an QnA.md file with the chunk of data as the context, generated Question and Answer

Hence the pipeline given a piece of data is able to generate a ilab/sdg digestible QnA.md ready for them to generate synthetic data and fine tune their model.

If you can automate the writing of qna.yaml from knowledge documents, why not just go all the way and generate fine tuning data from the knowledge documents? I am not sure it makes sense to insert a teacher model in the pipeline to generate synthetic training data from generated qna.yaml files when you could generate actual training data and use that to fine tune the model. Or am I missing something?
I do think there needs to be a way, in InstructLab, for a taxonomy node to provide actual training data (generated in some external process) instead of a qna.yaml (which is used by the sdg process to generate training data). This would allow a hybrid approach to fine tuning a model with a taxonomy approach.

Thank you for your feedback! You bring up an important point about the need for an intermediate step.
Automating the initial QnA generation process is important because of Quality Control and Alignment:
The QnA generation process ensures that each question-answer pair is directly grounded in the content, providing an explicit link between the document and the generated data. This helps maintain quality, consistency, and interpretability, especially when handling highly specialized or nuanced content.
After the QnA generation process is complete, the generated data can be subject to an Intermediate Validation Step:
By generating QnA pairs first, we introduce a validation step where subject matter experts (SMEs) can review and adjust the data, ensuring that the information aligns with domain-specific needs before passing it over to SDG. (It is simpler for SMEs to assess alignment over 10 QnA pairs than thousands generated by the existing SDG pipeline) This layer of validation is crucial for maintaining the quality of the training data.
Hence, the QnA generation step strategically positions humans as validators rather than creators/consolidators, which helps mitigate bias and maintain the integrity of the knowledge source while reducing the human effort.

There seems to be some traction building within the ilab community for an automated QnA generation pipeline. Some suggestions for a POC included utilizing a semantic chunker for a knowledge source and then generating a QnA from the those chunks.
Credits to @noelo for https://github.com/noelo/instruct-generate
I would be happy to work alongside the community to pursue this upstream

Re: chunking, see https://github.com/instructlab/sdg/issues/271

hey, I had this exact idea last night @RishabhSaini and found this issue before I went and created one myself!
I am assigning this to myself to ensure it gets prioritized for 0.20 but would love to collaborate with anyone who wants to work on it

cc @aakankshaduggal @khaledsulayman

@cdoern Great to see this issue being prioritized! I would love to collaborate on the implementation


Rewrite docs (again!)

Another, hopefully final, stab at docs. Supersedes #289 and #140 and will gradually take some content from there. Uses Gitbook for rendering a static website which you can launch by running npm run docs:watch.

Some parts I think are fairly good already:
https://github.com/gaearon/redux/blob/rewrite-docs-again/README.md
https://github.com/gaearon/redux/blob/rewrite-docs-again/docs/API Reference/createStore.md
https://github.com/gaearon/redux/blob/rewrite-docs-again/docs/API Reference/Store.md

All right. You can take a look at preliminary 1.0 docs here: http://gaearon.github.io/redux
There's just a glossary and API reference there. “Getting Started” and “Recipes” coming later.
What do you think?

It is beautiful. Nice work!

really good job @gaearon!

:+1:  @gaearon

This is in master now, closing PR.


Update to latest dependencies. Cleanup signatures in synth module. Add LICENSE and badges to README.

Published as 0.9.1.


Salinity of a salt lake

Greetings @satish1901
I'm using this repository to determine the salinity of a salt lake, but I'm facing trouble differentiating between turbidity and salinity based on the output provided by the code. Also The repository includes four different equations: w_qual_1, w_qual_2, w_qual_3, and w_qual_4. Can you recommend the best equation to use for my case ?
notice: I've discovered that the equation in the paper is different that the one used in code. Am I wrong?

Hello
Sorry for the late response
The correct output is: w_qual_1
Please use that!
I will fix those in the code!
The paper contains the normalized form of these equations, for visualizations, it renders similar results with very less computation.
I hope this helps, Please let me know if there is any other confusion
Thank you


Fix spacing after cloud icon

Description
Added missing space after the cloud icon to be in line with other sections.
Even though in the diff it appears that the space is already there, it's actually some sort of control character that gets rendered as a space in visual text editors (eg. Atom) and the browser, but it's actually not like that in the terminal.
This fixes the issue for me in GNOME Terminal and iTerm2 in macOS.
I did try these troubleshooting configurations but that didn't work.
Screenshot
Screenshot from vim with the original code. You can see how the cursor was standing over a second character to the right of the cloud, but actually over it, with the closing double quote to the right:

How it looks on GNOME Terminal before the fix:

How it looks on GNOME Terminal after the fix:

Sorry, but I don't see the reason to merge this PR. We have consistent spaces in _SYMBOL variables. Merging this PR would possibly break someone else's prompt.


Mistral support

Hello,
I am new to the project and am interested in training Mistral 7b, could someone give me some directions on how to add support for this model?
Thank!

Hi @maximegmd ,
It's unfortunately a bit of a porting exercise, but I think it's not too bad here. We have a general guide for adding new models here: https://levanter.readthedocs.io/en/latest/Port-Models/
Mistral is basically the same as Llama with AFAIK two differences: grouped query attention and sliding window attention.
Implementing sliding window attention efficiently isn't trivial, but we have an implementation here: https://github.com/stanford-crfm/levanter/blob/774464ea8fd7f020998259e3951118207e06731f/src/levanter/models/longformer.py#L11
or we could just use a mask for now and not take advantage of the masking...
GQA shouldn't be too hard, but I haven't thought about it much.
@J38 has expressed interest in taking this on, but lmk if you're interested in trying your hand at it. Happy to consult.

(This is done in #435 )


[SPARK-7304] [BUILD] Include $@ in call to mvn consistently in make-distribution.sh (@vanzin)

Adding the $@ allows the caller of this script to supply additional arguments to the mvn command and is consistent with how mvn is being invoked elsewhere in the scripts

Can one of the admins verify this patch?

LGTM. It's set in every other invocation in the file. I like set -x to print progress too.

ok to test

Merged build triggered.

Merged build started.

Test build #31609 has started for   PR 5846 at commit e5f2adb.

Test build #31609 has finished for   PR 5846 at commit e5f2adb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31609/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Could you remove me from the PR title though? :-)

Sounds good - I can clean up the titel.


add prometheus operator as a part of CI

try to add prometheus operator as a part of CI
reference
https://prometheus-operator.dev/docs/prologue/quick-start/#deploy-kube-prometheus
if we just deploy with bundle(https://github.com/prometheus-operator/prometheus-operator), it will not create namespace as monitor.
hence, we deploy quick start as an all in one solution in CI.
Signed-off-by: Sam Yuan<EMAIL_ADDRESS>

it's a draft so far. will covert to ready status once code complete.

resolve #181

@rootfs , please help re run CI check. fails at
Step 14/21 : FROM quay.io/sustainable_computing_io/kepler_base:latest
Head "https://quay.io/v2/sustainable_computing_io/kepler_base/manifests/latest": Get "https://quay.io/v2/auth?scope=repository%3Asustainable_computing_io%2Fkepler_base%3Apull&service=quay.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
make[1]: *** [Makefile:84: _build_containerized] Error 1
make[1]: Leaving directory '/home/runner/work/kepler/kepler'
make: *** [Makefile:165: cluster-sync] Error 2


MM-16399 Clear current channel when leaving a team

This stops an issue where joining a new team after having no teams marks the previously viewed channel as read.
Redux PR: https://github.com/mattermost/mattermost-redux/pull/931
Ticket Link
https://mattermost.atlassian.net/browse/MM-16399

@hmhealey
Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Fetching origin
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-#3715-upstream-release-5.16-1569437454
Branch 'automated-cherry-pick-of-#3715-upstream-release-5.16-1569437454' set up to track remote branch 'release-5.16' from 'upstream'.
+++ Downloading patch to /tmp/3715.patch (in case you need to do this again)

+++ About to attempt cherry pick of PR. To reattempt:
  $ git am -3 /tmp/3715.patch

Applying: MM-16399 Clear current channel when leaving a team
Using index info to reconstruct a base tree...
M	package-lock.json
M	package.json
Falling back to patching base and 3-way merge...
Auto-merging package.json
CONFLICT (content): Merge conflict in package.json
Auto-merging package-lock.json
CONFLICT (content): Merge conflict in package-lock.json
Patch failed at 0001 MM-16399 Clear current channel when leaving a team
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

+++ Conflicts detected:

UU package-lock.json
UU package.json

+++ Aborting in-progress git am.

+++ Returning you to the master branch and cleaning up.


Translate docs to PT-BR

What problem does this feature solve?
https://vuejs.org/ and https://vuex.vuejs.org/ docs already are translated to PT-BR, would be interesting to Vue-Router be translated to Brazil Portuguese too.
What does the proposed API look like?
I want to start translating, can I make a fork and start working on this? I can start translating the docs/README.md, docs/installation.md and the docs/api/README.md

The translated effort for docs is at https://github.com/vuejs-br/vue-router


Bug/3587 fix parameter examples order

fixes #3587
This pull request ensures that the order that examples are defined in the @Parameter.examples property is the same as the order in the generated openapi document.

Will add tests before marking it ready for review.

@joschi I do not have permission to merge this.  What is the process for getting it merged and where do I find out when the next release will be?

@mandragorn No worries, @frantuma or another maintainer of swagger-core will merge the PR when they have time for it.

:+1: awesome.  Thank you!

Thanks a lot!


Bug: Quarter displays 'Select a value' for TEE when viewing

Issue:
When a user is viewing TEE data, then the Quarter dropdown displays 'Select a value' when the value is Null. It should just be blank
Steps to Recreate:

Access Cert Event and TEE Module, select and open a Configuration
Select Test Extension and Exemption from the 'Test Data' dropdown
Pick a Record where there is no selection made for the Quarter and review how it is being displayed. You will notice that it shows 'Select a value' instead of being blank

Bug Fixed


Fix error: .savedmodel

There is an error while saving the output file using 'savedmodel'. Turns out, it's a small typo.

Thanks for the pull request! Definitely wouldn't have noticed this one for a long time.


runtime: backport CLs 33339 and 35353

If we do a 1.7.5 release, backport CLs 33339 and 35353, which add diagnostics for and may mitigate #16083.

Austin, I'll let you send these two. These aren't trivial like the others.

Submitted to 1.7 branch.


Simple DoFnRunner optimizatons.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @silviulica

I agree with both of you :-) Ben I think Robert is trying to establish a good performance baseline that we will want to keep for the foreseeable future. We should log a bug that this functionality needs to go back.

LGTM

Close manually at your convenience


dark popup icon

would you take a pull request to have a dark mode icon made for people who have dark themes set for the browser? the black is hard to see. i would probably make it the same color as standard gray from the default dark theme:

if you give the go ahead would you want it tied into the current theme selection option or have it as a standalone option?

I actually just fixed it with 55cf1af56433ff536d2df94b4ad10b6a78e4edd6. It was actually supposed to do that already, but I accidentally left a fill="#000000" in the SVG files, so it wasn't working.


How can I load my schema filters by assembly?

The original intention was that library users would typically use a handful of these filters if any - they are extension points as oppose to core usage artifacts (as would be the case with some of the other libraries). But, I’ve no objection to having such a convenience in SB - why don’t you submit a PR?

Closing due to inactivity.

Closing due to inactivity.


[add-resource] New Plugin: nyk-authors

I would like to add my new plugin to the Grav Repository.
Here are the project details: Nykold/nyk-authors
It intends to make it easier to automatically add a string with a specific page's authors in blogs (via page header and Twig) and it is especially made for people that are using the Admin plugin.

Sorry for the delay, this has been added to GPM.


Is there an easy way to change the App name?

Currently it's all under Kindling, if we want to build on top of the kit, are there commands we can run to personalize it to our own project?

We just brute forced it the renaming.

Ended up just renaming manually, would be nice if there was an easier way though.

Oh yes, documenting this is on our todo-list! The app is currently called "Kindling" (the original codename  for the project), we will need to rename it anyway.
The way to go about this will probably be something like running the following in the root directory of your project:
sed -i 's/Kindling/YourAppName/g' *

(Above not tested)

@jevakallio will it work in the cases of com.kindling in android build configuration?
Tested and (for now working):

change the name in package.json
run react-native upgrade

on file conflict, press d to get the diff and locate the name changes (it will be from Kindling to YourAppName or from kindling to yourappname mostly)
once you located the name changes, apply them manually and say no to the upgrader so you don't lose additional stuff brought by Pepperoni

run rm -rf Kindling Kindling.xcodeproj Kindling.xcworkspace KindlingTests (new xcode files should have been generated for your new app name)
edit YourAppName.xcodeproj/project.pbxproj and look for OTHER_LDFLAGS. Change its value to $(inherited) (in my case it was from -ObjC or something)
run (cd ios; pod install)
change Kindling to YourAppName in index.ios.js and index.android.js

And you should be good to go.

@chadrien thanks for the instructions! I'll have to read those through and test for iOS and Android. Ideally we will need a solution that doesn't require running reacf native upgrade, as we will soon have a need for customisation in project files.
I think a shell script or a small cli tool bundled with the Pepperoni repo might be a way to go. This is something we will probably need eventually anyway for helping users bring in latest changes from the template to their projects.

Furthermore we should rename the Kindling directory to something app-independent, so it doesn't need to be renamed by developers.

@jevakallio I will try to write such a shell script and open a PR if it goes well.

@chadrien sweet!

@jevakallio OK I think I'am on something working (run-ios and run-android both start the app and it seems to be functional).
Before opening a PR, could you tell me in which dir you'd like the script file to be, and what would be its name?

@chadrien I think the file could be something like /support/rename.sh, or .js depending on what you wrote it in.
As a part of the PR, could you also do a rename from Kindling to PepperoniAppTemplate, and the same for the lowercase Android strings? That would be clearer and more guaranteed to be unique.


update getPartialStateDiff.ts fullscreen diff

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39288
PROPOSAL: https://github.com/Expensify/App/issues/39288#issuecomment-2027786218
Tests

Go to Profile> Workspaces> Create Workspace.
Go to Members> Invite member> Invite any email address.
Click on invited member section to open Profile page.
Select message user.
Then Go to Profile> Workspaces again.
Click on any workspace to open its settings page and verify that workspace setting page open normally after visiting invited member chat.

[x] Verify that no errors appear in the JS console

Offline tests
N/A.

QA Steps
Same as Tests step.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/41129870/1f893481-93fc-49aa-82db-6da0917072a9

Android: mWeb Chrome
https://github.com/Expensify/App/assets/41129870/c246791a-a959-4f5f-8603-3d882c3988b1

iOS: Native
https://github.com/Expensify/App/assets/41129870/4749a182-47cb-4b98-a50a-98e83ea99c33

iOS: mWeb Safari
https://github.com/Expensify/App/assets/41129870/61f44da9-25e7-469d-a416-be925a80c86d

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/41129870/d4ce9e3d-9c67-4806-b662-7d5a9119681d

MacOS: Desktop
https://github.com/Expensify/App/assets/41129870/4acdd3f8-9111-4818-8c61-8f20bd8cee00

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.61-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.61-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Allow f-string modifications in line-shrinking cases

Summary
This PR resolves an issue raised in https://github.com/astral-sh/ruff/discussions/7810, whereby we don't fix an f-string that exceeds the line length even if the resultant code is shorter than the current code.
As part of this change, I've also refactored and extracted some common logic we use around "ensuring a fix isn't breaking the line length rules".
Test Plan
cargo test

All the UP032 additions are good. The SIM examples are also working as intended. Previously, we didn't consider the indent when calculating the resulting line length.


WRP-3060: Increase code coverage for Button, ColorPicker, ContextualPopupDecorator

Enact-DCO-1.0-Signed-off-by: Stanca Pop<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[x] Documentation was verified or is not changed
[x] UI test was passed or is not needed
[x] Screenshot test was verified or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Increased code coverage for Button, ColorPicker and ContextualPopupDecorator.
Resolution
Additional Considerations
Links
WRP-3060
Comments

can you add some extra tests for ContextualPopup?

set locale to a RTL one  it will hit the adjustRTL function
at least one test with overflow. Check line 494 in order to set the correct props.

Thank you!


Rename postgres provider to postgresql

To adhere to the spec: https://github.com/prisma/rfcs/blob/0002-datamodel-2/text/0002-datamodel.md#supported-fields

Done in the latest version.


Update contributing.md for namespace

This pull request introduces several updates to the documentation and templates to ensure adherence to the PROCESS style guide and improve overall readability and consistency. The most important changes include adding references to the PROCESS style guide in various files, expanding the style guide documentation, and updating naming conventions in the codebase.
Documentation and Templates Updates:

Pull Request Template: Added a checkbox to confirm that changes follow the PROCESS style guide. (.github/pull_request_template.md)
Contributing Guide: Updated to include a reference to the PROCESS style guide for naming variables and functions. (CONTRIBUTING.md)

Style Guide Enhancements:

Style Guide Introduction: Added an introduction to the PROCESS style guide, including adherence to PEP8 for Python and namespace style. (documentation/proc-pages/development/standards.md)
Naming Conventions: Expanded section on naming conventions for functions, switches, constants, and variables, including guidelines for variables representing fractions. (documentation/proc-pages/development/standards.md)
Units and Types: Updated examples and conventions for units and type hints in Python, as well as added new sections for docstrings and comments. (documentation/proc-pages/development/standards.md)

Navigation Update:

MkDocs Configuration: Changed the navigation label from "Reference" to "Models" in the documentation site configuration. (mkdocs.yml)

Checklist
I confirm that I have completed the following checks:

[ ] I have justified any large differences in the regression tests caused by this pull request in the comments.
[ ] I have added new tests where appropriate for the changes I have made.
[ ] If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
[ ] If I have made documentation changes, I have checked they render correctly.
[ ] I have added documentation for my change, if appropriate.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.00%. Comparing base (b68ac63) to head (c919277).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
+ Coverage   27.11%   28.00%   +0.88%
==========================================
  Files          76       76
  Lines       17736    18785    +1049
==========================================
+ Hits         4810     5261     +451
- Misses      12926    13524     +598

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix deprecated splash screen.

Describe the bug
When we build the app this is shown in debug console i.e A splash screen was provided to Flutter, but this is deprecated..

OS: [e.g. iOS/Android]
Android

Are you working on this issue? (Yes/No)
Yes

@aman-singh7 Can you assign this to me ?


raise warning when no external drives added

@cjayb could we perhaps raise a warning when running a simulation with no input drives? And telling users that they must add the drives manually or use add_drives_from_params=True. If they use add_drives_from_params=True, a big fat deprecation warning should be raised.

+1 on both counts.

perhaps we could not add a drive to net.external_drives if in the param file t0 of drive > tstop of simulation?

and

The items in net.external_drives should map 1-to-1 with whatever is specified by a param file or the user via calls to net.add_... so that we don't end up silently loosing track of network drives, gids, etc.

I propose raising a ValueError for drives (from params or otherwise) where t0 > T. The solution is either to fix the param-file (setting weights to zero effectively "removes" the drive), or, preferably, use the new API.

I propose raising a ValueError for drives (from params or otherwise) where t0 > T

I think we agreed in #397 that we'll truncate rather than raise an error?
The warning is easy to tackle?
I'm trying to look at low hanging fruits from 0.2 milestone and get them done to prepare for a release

probably easily bunched with #410 ?

Right, now that tstop is a parameter of the simulation, the t0 of the drives should be allowed to be arbitrary. Perhaps a RuntimeError if simulate_dipole is called on a net without drives?

yeah that sounds good. Not sure if we want an error or warning ... I remember @ntolley saying there were situations where you'd want to simulate a network without driving it

Close issue? I think we've moved towards the opinion that less warnings is good, but maybe this one is worth it.


Create alerts based on the content detected

if the attachment contains more than 200 email addresses. what is the best approach to create an alert and block the user from sharing the file to external users?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e83b77e5-e3ec-6a5f-1f09-e232e2dda483
Version Independent ID: 0b263c72-95a2-d111-20a7-68857f288369
Content: Keyword queries and search conditions for Content Search - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/keyword-queries-and-search-conditions.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@rj192168 There are no content search/eDiscovery functionality that addresses your question. You could look into using Exchange transport rules (ETR) to prevent the message from being sent to external users, but not sure if there is a condition based on number of recipients. You might also be able to use DLP to prevent sensitive info from being sent but again not sure if you can base DLP being triggered based on number of recipients.
For more info:
ETR: https://docs.microsoft.com/en-us/Exchange/security-and-compliance/mail-flow-rules/mail-flow-rules
DLP: https://docs.microsoft.com/en-us/microsoft-365/compliance/data-loss-prevention-policies?view=o365-worldwide
You can also create an alert policy (based on conditions and actions) but this only reactive; it will trigger an alert after the fact; it doesn't prevent email being sent. And not sure you can create a policy using the conditions you want to use: https://docs.microsoft.com/en-us/microsoft-365/compliance/alert-policies?view=o365-worldwide
Hope this helps.


"Seaca de Câmp" is listed in the drop-down menu

Description:
"Seaca de Câmp" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Seaca de Câmp" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Seaca de Câmp, DOLJ".


Fixing shebang in ssllatency.bt and sslsnoop.bt

All other bpftrace programs in tools/ directory have shebang line as /usr/bin/env bpftrace whereas ssllatency.bt and sslsnoop.bt have the shebang line as /usr/bin/bpftrace. This was causing error upon running these scripts when bpftrace is installed at a custom location.

Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

LGTM


Tests that hints are displayed within repeats during conversion

This PR closes issue #73 and presumably as well #74

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   81.19%   81.19%
=======================================
  Files          23       23
  Lines        3106     3106
  Branches      729      729
=======================================
  Hits         2522     2522
  Misses        450      450
  Partials      134      134

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297dee7...d1730b1. Read the comment docs.


Update build setup instructions

Thanks, @rachitnigam. :smiley: I added you to the org, so you should be able to merge this yourself now.

Great, thanks!


VS Code keep crashing on Ubuntu 20.04

VS Code Version: 1.54.1 f30a9b73e8ffc278e71575118b6bf568f04587c8 x64
OS Version: Ubuntu 20.04.1 LTS

Steps to Reproduce:

sudo dpkg -i ./code_1.54.1-1614898113_amd64.deb
code, then VS Code started and then crashed.

Does this issue occur when all extensions are disabled?: Yes
Some extra info:
I installed VS Code about two days ago by dpkg, it's okay. But looks like it cannot update automatically, so I removed it, and use the version on  Ubuntu App Store.
But I cannot use the Chinese input method (sogou pinyin), so I have to uninstall this version and go back to sudo dpkg -i ./code_1.54.1-1614898113_amd64.deb. Then it keep crashing, here is the log:
song@G3-3579:~/Downloads$ code --verbose
[main 2021-03-08T04:55:39.423Z] Starting VS Code
[main 2021-03-08T04:55:39.424Z] from: /usr/share/code/resources/app
[main 2021-03-08T04:55:39.424Z] args: {
  _: [],
  diff: false,
  add: false,
  goto: false,
  'new-window': false,
  'reuse-window': false,
  wait: false,
  help: false,
  'list-extensions': false,
  'show-versions': false,
  version: false,
  verbose: true,
  status: false,
  'prof-startup': false,
  'prof-v8-extensions': false,
  'disable-extensions': false,
  'disable-gpu': false,
  telemetry: false,
  debugRenderer: false,
  logExtensionHostCommunication: false,
  'skip-release-notes': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-keytar': false,
  'disable-crash-reporter': false,
  'crash-reporter-id': '66632704-a6e6-4b9c-8239-625e7c313517',
  'skip-add-to-recently-opened': false,
  'unity-launch': false,
  'open-url': false,
  'file-write': false,
  'file-chmod': false,
  'driver-verbose': false,
  force: false,
  'do-not-sync': false,
  trace: false,
  'force-user-env': false,
  'force-disable-user-env': false,
  'open-devtools': false,
  __sandbox: false,
  'no-proxy-server': false,
  nolazy: false,
  'force-renderer-accessibility': false,
  'ignore-certificate-errors': false,
  'allow-insecure-localhost': false,
  logsPath: '/home/song/.config/Code/logs/20210308T125539'
}
[main 2021-03-08T04:55:39.429Z] Resolving machine identifier...
[main 2021-03-08T04:55:39.429Z] Resolved machine identifier: 2bb5c4d7a1330ebdc1d2630db014846617a300f047847b0b395d3d0d31dfa67b
[main 2021-03-08T04:55:39.430Z] Main->SharedProcess#connect
[main 2021-03-08T04:55:39.447Z] StorageMainService: creating global storage
[main 2021-03-08T04:55:39.448Z] lifecycle (main): phase changed (value: 2)
[main 2021-03-08T04:55:39.449Z] windowsManager#open
[main 2021-03-08T04:55:39.450Z] windowsManager#open pathsToOpen [
  {
    backupPath: '/home/song/.config/Code/Backups/1615178121052',
    remoteAuthority: undefined
  }
]
[main 2021-03-08T04:55:39.452Z] window#validateWindowState: validating window state on 2 display(s) { mode: 1, x: 957, y: 176, width: 1024, height: 768 }
[main 2021-03-08T04:55:39.452Z] window#validateWindowState: multi-monitor working area { x: 0, y: 0, width: 2560, height: 1440 }
[main 2021-03-08T04:55:39.452Z] window#ctor: using window state { mode: 1, x: 957, y: 176, width: 1024, height: 768 }
[main 2021-03-08T04:55:39.490Z] Setting proxy to 'http://localhost:7890', bypassing 'localhost,<IP_ADDRESS>/8,::1,<local>'
[main 2021-03-08T04:55:39.496Z] windowsManager#open used window count 1 (workspacesToOpen: 0, foldersToOpen: 0, emptyToRestore: 2, emptyToOpen: 0)
[main 2021-03-08T04:55:39.497Z] lifecycle (main): phase changed (value: 3)
[main 2021-03-08T04:55:39.498Z] update#setState idle
[main 2021-03-08T04:55:39.498Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
(node:22048) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
[main 2021-03-08T04:55:39.581Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
(node:22102) Electron: Loading non-context-aware native module in renderer: '/usr/share/code/resources/app/node_modules.asar.unpacked/vscode-sqlite3/build/Release/sqlite.node'.   See https://github.com/electron/electron/issues/23506 for more information
[22048:0308/125540.435801:INFO:CONSOLE(626)] "%cTRACE color: #888 Error while resolving configuration file 'vscode-userdata:/home/song/.config/Code/User/settings.json': Unable to read file 'vscode-userdata:/home/song/.config/Code/User/settings.json' (Error: Unable to resolve non-existing file 'vscode-userdata:/home/song/.config/Code/User/settings.json')", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js (626)
[22048:0308/125540.436210:INFO:CONSOLE(626)] "%cTRACE color: #888 Error while resolving configuration file 'vscode-userdata:/home/song/.config/Code/User/tasks.json': Unable to read file 'vscode-userdata:/home/song/.config/Code/User/tasks.json' (Error: Unable to resolve non-existing file 'vscode-userdata:/home/song/.config/Code/User/tasks.json')", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js (626)
[main 2021-03-08T04:55:40.496Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
[22048:0308/125540.537950:INFO:CONSOLE(626)] "%cTRACE color: #888 Settings Sync: Initializing accounts", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js (626)
[22048:0308/125540.538308:INFO:CONSOLE(626)] "%cTRACE color: #888 Settings Sync: Getting accounts for microsoft", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js (626)
[main 2021-03-08T04:55:40.539Z] RequestService#request https://update.code.visualstudio.com/api/update/linux-x64/stable/f30a9b73e8ffc278e71575118b6bf568f04587c8
[22048:0308/125540.559920:INFO:CONSOLE(626)] "%cTRACE color: #888 StartupGettingStarted: undefined", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js (626)
[main 2021-03-08T04:55:40.608Z] SharedProcess: IPC ready
[main 2021-03-08T04:55:40.628Z] Main->SharedProcess#connect: connection established
(node:22138) Electron: Loading non-context-aware native module in renderer: '/usr/share/code/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node'.

Thanks for attaching the reports,
/duplicate https://github.com/microsoft/vscode/issues/116690
Please use https://github.com/microsoft/vscode/issues/116690#issuecomment-791064392 as a temporary workaround.


Added testAndSet to FunctionInterceptor for conenience.

In many cases, we check the data value once and then set it. This helper method makes it more concise.
Also removed DEV for function component name.

We also have https://github.com/facebook/hyperion/blob/main/packages/hyperion-util/src/TestAndSet.ts - is it possible to extend to handle this use case as well?

What do you mean to extend to handle this case? This commit is adding the value to the FunctionInterceptor, that standalone class for standalone values.


UTF8 support

As stated above - if you use UTF8 encoded text - you will see mostly gibberish mess instead of text.

Can you post an example file? All of my files are UTF-8 encoded and these are being ready with the Python standard library


CARGO_PROFILE sometimes does not get resolved

Describe The Bug
When using something like:
cargo make --env-file .env <some-target>
Sometimes, CARGO_PROFILE and CARGO_MAKE_GIT_HEAD_LAST_COMMIT_HASH don't get resolved.
I will try to create a sample project with the issue. At least with version 0.34.0, I don't experience that issue

CARGO_PROFILE - cargo make doesn't set that env var at all actually. it is cargo that does that. Did you mean CARGO_MAKE_CARGO_PROFILE that is defined by cargo-make and can be used in your tasks? or CARGO_MAKE_PROFILE which is not related to cargo at all, but to the cargo-make run?
CARGO_MAKE_GIT_HEAD_LAST_COMMIT_HASH - only set if you are in git repo with value that i'm able to extract. I use the git_info crate (also mine) to do that

same project would be best if you can

closing due to lack of feedback


Support for gpt-4-1106-preview

Describe the need of your request
Request for supporting GPT 4 Turbo model that was just launched https://platform.openai.com/docs/models/gpt-4-and-gpt-4-turbo
Proposed solution
No response
Additional context
No response

+1

New OpenAI models will be added in the next release, 2.2.2.

Thank you, the response is very good, awesome.👍🏻👍🏻👍🏻

Looking forward to the next release! Thanks.
On Tue, Nov 7, 2023 at 8:11 PM, Wei Xiaopeng @.***(mailto:On Tue, Nov 7, 2023 at 8:11 PM, Wei Xiaopeng < wrote:

Thank you, the response is very good, awesome.👍🏻👍🏻👍🏻
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Doesn't look like 2.2.2 added support for it? The dropdown options still look the exact same in the IDE and neither do I see anything in the code diff? Thanks for all your work!
https://github.com/carlrobertoh/CodeGPT/commit/26af45126f82bc281ac821a239f25f8384334fd6

Downloading to disk and then using that worked but updating from inside
PyCharm did not work. Also unable to access previous chats now.
Thanks for all your hard work!
On Wed, 8 Nov 2023 at 9:59 PM, Carl-Robert @.***> wrote:

@theamanbhargava https://github.com/theamanbhargava Are you sure that
you have updated the version correctly? As a last resort, you can manually
download it from here
https://plugins.jetbrains.com/plugin/21056-codegpt/versions.
—
Reply to this email directly, view it on GitHub
https://github.com/carlrobertoh/CodeGPT/issues/261#issuecomment-1802242987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFRBZHJTH7TYQYOWVOXEXBDYDOXMZAVCNFSM6AAAAAA7AW5ENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGI2DEOJYG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Prevent parent scrolling

Dear all,
Is there a way to prevent the scrolling of the whole page (i.e. parent scrolling) when the last line of the code editor is reached? I am using the default editor preferences, but I have seen that behavior with all the scrollbar modes: when I reach the end of the text and keep scrolling down, the whole page starts to scroll down. I do not wish to disable body scrolling, not even on mouse-over, because I do not want the body scrollbars to appear and disappear out of the blue.
Thank you very much in advance!
Best regards,
Pablo.

What kind of scrolling are you talking about? If this is about wheel scrolling, that's just how browsers act—if the pointer is over a scrollable container that's scrolled to the very end, its next scrollable parent is scrolled.

Yes, I was talking about wheel scrolling. I was wondering if there was some
sort of option or setup that prevented the event from being propagated if
the editor was scrolled to the end.
On Mon, 27 Nov 2017 at 17:34, Marijn Haverbeke<EMAIL_ADDRESS>wrote:

What kind of scrolling are you talking about? If this is about wheel
scrolling, that's just how browsers act—if the pointer is over a scrollable
container that's scrolled to the very end, its next scrollable parent is
scrolled.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codemirror/CodeMirror/issues/5097#issuecomment-347239520,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFwrS_nrs9bCnFcoTirkLhOtY1WGlku6ks5s6uSwgaJpZM4Qr3aa
.

You can add your own wheel event handler to do that. CodeMirror itself doesn't do it.


 Taskbar doesn't extend to the second monitor so you end up having to resize the window to fit the screen height every time you re-open.
Steps to Reproduce:

Open vscode
Move to second monitor
Increase window height so that it fills the entire height of the second monitor
Close and re-open vscode

@dozius can you share a video how this exhibits for you on the second monitor?

I can but it will have to wait until I am back at work. No second monitor at home, unfortunately.

video.zip

Thanks, this seems to be https://github.com/Microsoft/vscode/issues/22010

No, I don't think so. It only happens on the second monitor and the "gap" that is introduced on restart is the exact same height as the taskbar on the primary monitor. If I do the same thing on the primary monitor it restores with the correct size.
#22010 looks like the windows 10 coordinate problem. I see that same issue with a lot of different programs on windows 10. https://answers.microsoft.com/en-us/insider/forum/insider_wintp-insider_desktop/desktop-coordinate-system-is-broken/9e6fd9ab-6d27-45e0-bb55-4c868cd6ac45


Hero4 pairing procedure

Hi,
the issue I'm reporting may not be directly linked with these APIs.
I bought a Hero4 few weeks ago, and I'm having a problem using this library. The problem arises from the fact that to be connected to the Hero4 wifi from another device, a pairing procedure is required. Such procedure is performed when you first connect the camera to a mobile device with GoPro App, that requires to insert the pairing code shown by the camera.
Now, I can connect to the Camera Wifi from my macbook (I suppose it's the same with any other laptop, I haven't tried with others yet), but of course I'm not asked for any code. The camera keeps staying in the "Waiting for pairing" state, showing the code to be inserted on the connected device. At this stage, if I try to send a command through the goprohero library, e.g.
camera = GoProHero(password="goprohero")
camera.command('record','on')

it results in a successful message, but the camera disconnect the wifi as it receives a request over the wifi without having completed the pairing procedure. Of course, no action is performed by the GoPro (apart from disconnecting the wifi).
I don't know if this is due to an update in the firmware of the Hero4, as probably this issue wasn't considered while this library was built, and therefore (to the best of my understanding) there's no way to pair the GoPro through the library.
Anyone has any hint about that?
Cheers

Hi. you need to have the camera already paired to the app in wifi app mode.

Are you saying that I need to pair it to a mobile device, also if I want to work with it from a laptop?
As long as I could see there's no proprietary application to be used on a laptop (there are others that you can pay, and might pair the device with the laptop, but a "for free" solution would be better).

Once you pair the camera to the GoPro mobile app you don't need a pairing code. Just turn the WiFi and connect to laptop.

I'm adding camera pairing to my API (gopro-py-api), when I get it working I'll add it here too.

Hey @McKracken and @joshvillbrandt :
I figured how to pair my camera to my PC, take a look:
You put the camera in pairing mode, that is, go to settings > Wifi > turn it on > PAIR > Gopro App. Then a code will show (4 numbers).
Connect your computer to the wifi AP which is GPXXXXXX and the password is "goprohero", then use whatever python library to trigger these URLs:

https://<IP_ADDRESS>/gpPair?c=start&pin=CODE&mode=0

Replace the "CODE" with the code shown in the front display.
This will print a password, make sure your camera is still connected to your computer.
Now on to setup:

http://<IP_ADDRESS>gp/gpControl/command/wireless/ap/ssid?ssid=GOPRONAME&pw=GOPROPASS

You will need to setup a name and password for your GoPro, so decide (see online for the name and password length and character restrinctions).

https://<IP_ADDRESS>/gpPair?c=finish&pin=CODE&mode=0

And then finish the pairing process. This will set the camera to the new name and password so make sure to connect to it before proceeding.

Thank you very much @KonradIT ! I was just about to discover this myself with a little bit of Wireshark and others. You saved me half a day of work! Maybe if I have time, I might integrate this passage in the library if @joshvillbrandt allows that, or is not willing to do it himself!
Thank you again!

@McKracken I'm not contributing new code to this repo myself right now, but I'm happy to review a pull request.
Thanks for the assistance, @KonradIT!
I'll close this for now since it seems to core issue is resolved.


local_reply_config mapper metadata_filter does not match route metadata

Title: local_reply_config mapper metadata_filter does not match route metadata
Description:
I will admit it is quite possible that I don't understand how this is supposed to work, though as far as I can tell from reading the documentation this should work so at the very least there's some improvements to the documentation that could be made.
I want to apply a locale_reply mapper if and only if certain route metadata is set, like so:
local_reply_config:
                  mappers:
                    - filter:
                        metadata_filter:
                          matcher:
                            filter: my_metadata
                            path:
                              - key: my_value
                            value:
                              bool_match: true
                          match_if_key_not_found:
                            value: false

I have set config on my route like so:
routes:
  - match:
      prefix: /
    route:
      cluster: echo-server
    metadata:
      filter_metadata:
        my_metadata:
          my_value: true

But the local reply override never applies.
All responses have the default RBAC body  RBAC: access denied and not the local reply override.
Repro steps:
# docker compose
version: "3"
services:

  # https://github.com/jmalloc/echo-server
  echo-server:
    image: jmalloc/echo-server:0.2.0
    ports:
      - 8080:8080

  envoy-proxy:
    image: envoyproxy/envoy-debug:v1.19.0
    entrypoint: "/usr/local/bin/envoy"
    command:
      - "--service-node proxy"
      - "--service-cluster proxy"
      - "--config-path /etc/envoy/envoy.yaml"
      - "--concurrency 1"
      - "--mode serve"
      - "--log-level debug"
    volumes:
      - ./envoy.yaml:/etc/envoy/envoy.yaml # use full config in tick
    expose:
       - 8888
       - 8001
    ports:
       - 8888:8888
       - 8001:8001

docker-compose up
curl http://localhost:8888/something

Full config:

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Config:
admin:
  access_log_path: "/dev/null"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 8001
static_resources:
  clusters:
    - name: echo-server
      connect_timeout: 1s
      type: STRICT_DNS
      lb_policy: ROUND_ROBIN
      load_assignment:
        cluster_name: echo-server
        endpoints:
          - lb_endpoints:
              - endpoint:
                  address:
                    socket_address:
                      address: echo-server
                      port_value: 8080
  listeners:
    - address:
        socket_address:
          address: <IP_ADDRESS>
          port_value: 8888
      filter_chains:
        - filters:
            - name: envoy.filters.network.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                codec_type: AUTO
                stat_prefix: ingress
                http_filters:
                  - name: envoy.filters.http.rbac
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.rbac.v3.RBAC
                      rules:
                        action: DENY
                        policies:
                          general-rules:
                            permissions:
                              - any: true
                            principals:
                              - any: true
                  - name: envoy.filters.http.router
                    typed_config: {}
                local_reply_config:
                  mappers:
                    - filter:
                        metadata_filter:
                          matcher:
                            filter: my_metadata
                            path:
                              - key: my_value
                            value:
                              bool_match: true
                          match_if_key_not_found:
                            value: false
                      body_format_override:
                        json_format:
                          message: "some message"
                route_config:
                  name: route
                  virtual_hosts:
                    - name: backend
                      domains:
                        - "*"
                      routes:
                        - match:
                            prefix: /
                          route:
                            cluster: echo-server
                          metadata:
                            filter_metadata:
                              my_metadata:
                                my_value: true

Logs:
I can provide some but I don't think they are very useful in this case

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

it would probably be helpful if we had a sandbox that demonstrated advanced usage of the matching api
cc @snowp


Paris–brussels 5.1.2

minor fixes, dep updates and security

Coverage increased (+0.004%) to 98.218% when pulling 6a67de6f6a5adf549e2734f5821b77e84ddbfd6e on Paris–Brussels-5.x.x into a5937ce14225dd52d12fe3b3cb3f8934fd13f367 on master.

Coverage increased (+0.004%) to 98.218% when pulling 6a67de6f6a5adf549e2734f5821b77e84ddbfd6e on Paris–Brussels-5.x.x into a5937ce14225dd52d12fe3b3cb3f8934fd13f367 on master.

Coverage increased (+0.004%) to 98.218% when pulling 6a67de6f6a5adf549e2734f5821b77e84ddbfd6e on Paris–Brussels-5.x.x into a5937ce14225dd52d12fe3b3cb3f8934fd13f367 on master.


when looping queue, the previous song gets added to end of queue twice

This is an error that came about from a fix to another error.  Essentially before when a song would end it would skip ahead 2 songs. In order to fix that I made it so when you use /skip it duplicates the next song if it isn't the same as the currently playing song, adds it next up in queue, skips over the first version, and plays the second version.
Unfortunately when you loop though now it duplicates the song twice instead of once due to the nature of the loop method. I prefer having loop be kind of broken then skip so for now there is no fix.


[Community]: Fixed ArxivAPIWrapper (corrected fitz attribute and not using load_max_docs)

Description: ArxivAPIWrapper was not using load_max_docs which have been fixed, and also fitz.fitz was raising an attribute error which has also been fixed in this PR.

@ccurme

this should use load_max_documents in lazy_load - otherwise, we do the work of loading all the docs and filter after, thats not very efficient
Also - fitz.fitz works with older versions of pymupdf. we need to fix dependencies


Hotfix/issue 101

This change is

Reviewed 46 of 46 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Is there a way to know that my laptop is turned off?

I have lnxlink on my dev laptop. When I shut the laptop down, HA remembers the previous state that lnxlink reported for all of my entities, and they don't go unavailable even after several days. For example, the idle time on my laptop has been "3" ever since I shut it down.
I'm trying to create a template sensor for whether or not I'm currently using my laptop, but so far I can't figure out how to make it accurate.
So far, I've come up with:
{{ (has_value('sensor.dev_laptop_idle') and
      (now() | as_local | as_timestamp - states.sensor.dev_laptop_idle.last_changed | as_local | as_timestamp < 120) and
      (is_state('sensor.dev_laptop_idle', 'OFF') or (states('sensor.dev_laptop_idle') | int) <= 600)) }}

However even that causes issues, because after restarting HA, the last_changed timestamp updates to the current time, and it then says I'm using my laptop for at least the next 120 seconds.
Is there any way to have an MQTT entity from lnxlink that goes unavailable when it stops receiving updates so that I can detect when it's no longer receiving data from lnxlink more accurately?
Side note: Is it a bug that when idle time is 0, Home Assistant reports the state as OFF?

For me when I turn off or restart my PC it automatically becomes unavailable. Could you send me some more info about your system?
Distribution, version, etc...
Unfortunately home assistant doesn't support on MQTT to check if it doesn't get any events for x time, to set unavailable the entity, but you could create an automation similar to the one you created:
alias: lnxlink powered down
description: ""
mode: single
trigger:
  - platform: template
    value_template: >-
      {{ (now() | as_local | as_timestamp -
      states.sensor.desktop_linux_idle.last_changed | as_local | as_timestamp) >
      10 }}
condition: []
action:
  - service: mqtt.publish
    data:
      qos: 0
      retain: true
      topic: lnxlink/desktop-linux/lwt
      payload: "OFF"

As for the idle time, I haven't noticed any report for state OFF, but I will keep it in mind.

My laptop is running Pop_OS! (based on Ubuntu) 22.04, however I'm a bit unclear on how that could affect whether or not the Home Assistant entities go unavailable when it's shut off.
 And what makes them go unavailable since as you mentioned the lack of an MQTT post isn't sufficient?
Regarding a value of 0 being considered 'OFF' for idle time, whenever I'm currently using my laptop so that the idle time would be 0, I see the following log messages:
2023-04-25 16:08:34.627 WARNING (MainThread) [homeassistant.components.sensor] Sensor sensor.dev_laptop_idle has device class duration, state class total_increasing and unit s thus indicating it has a numeric value; however, it has the non-numeric value: OFF (<class 'str'>); Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+mqtt%22
And my template sensor has to account for the state being 'OFF' as otherwise it doesn't match if I just treat it as numeric.

To control when the entities are unavailable, the MQTT topic lwt should be on state OFF. This is controlled by lnxlink which sends this just before the computer shuts down or lnxlink service is stopped.
The errors you get remind me of older versions of lnxlink. You can check which version you have installed from logs or using pip freeze. Make sure you have installed the latest version which at this time is 2023.4.1.
Unfortunately I am not using Pop_OS to test but it should work the same way as Ubuntu that I am using. I've tried to make the project work on any distribution, but if the entities don't go to unavailable, then you can use the automation I mentioned on my previous comment.

I'm on version 2023.4.0, I forgot to update to 2023.4.1. I'll give that a shot and see if it helps. Thank you!

Version 2023.5.0 has many issues fixed, if you still have issues, let me know.

With the new version 2023.6.0 sensors and binary_sensors automatically become unavailable.


Question about the result of layerdiffusion

In the actual operation process, it was found that the current attention has a significant impact on the generation. Is there anything to pay attention to when filling in prompts? Or is there a sampler? Model? etc., to make the generated results as close as possible
The following example parameters remain consistent
use

not used

currently we only maintain automatic1111 samplers (but may test more implementations in the future)
if using other samplers outside automatic1111, users need to use models with their own risk for any quality degradation

See https://github.com/huchenlei/ComfyUI-layerdiffusion/issues/5.


Adding the WSH Felbertal

Institution/School Name
Werkschulheim Felbertal
Instiution/School Website
https://werkschulheim.at
Email Users

[X] Students
[X] Academic/Teaching Staff
[X] Other/Support Staff
[ ] Alumni

Education Levels

[ ] Post-graduate research
[ ] Graduate School
[ ] College (University) or Undergraduate School or equivalent
[X] Community College or equivalent
[X] High School or equivalent
[ ] Elementary School or equivalent

Just as a clarification: only about 4 other persons got a @werkschulheim.at adress all of which but one can be found here
https://werkschulheim.at/index.php/direktion-160.html
The Last one is our IT department

Also I noticed that our English translation is very hidden so here you go: https://werkschulheim.at/index.php/englisch.html

@Algo-ryth-mix Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Add liquid staking module (discussion)

AFAIUI we need to include this in order to have Quicksilver liquid staking work without unbonding times https://github.com/iqlusioninc/liquidity-staking-module

I think that we should write the code, then make the gov prop.

Yeah I think there's a second thing which is AFAIUI we need an ICQ impl for this to work, so we need to land on one of those as well.

This remains a challenging moving target.

This feature did not even make it into SDK-47.
We would be waiting until at least SDK 48 unless we want to only add the module and then being able to safely add it begins with our adoption of SDK 46.
The only other choice is to add support to the LSM itself for 47.


typo fix create odbc resource error msg

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Why would the library not be able to retrieve the os current locale ?

We know that :
pub fn get_locale() -> Option<String>

In theory, it's possible to get a None value.
I did not look at the code in depth, so I don't know if it's really possible to get a None value.
My question is : why would it be possible to not get the locale ? Why would the library not be able to retrieve the os current locale ?
Besides, can I do the following code without being afraid of getting an error at runtime :
get_locale().unwrap();

README.md
Here is the code example I found in README.md :
let locale = get_locale().unwrap_or_else(|| String::from("en-US"));

I've raised questions from here.

Hi there @antoninhrlt,
I wouldn't consider the get_locale function infallible if you plan to distribute software to end users. If you plan to only run it on systems you control/own, this might be reasonable but I would still recommend falling back to a default language instead. If this is user-facing software, you could log a warning (or something like it) that lets someone know why their expected locale isn't being respected. This is exactly 1Password 8 does today, for example (with a fallback to en-US).
UNIX platforms are a good example to demonstrate the failure case with. This library is reliant on either the desktop environment or terminal to set the various locale environment variables. If this code is ran in a very different way, it could return None since the setup may not exist. Moving on to others: In theory get_locale shouldn't fail on Windows and macOS because they get data directly from OS APIs, but its non-ideal to rely on systems behaving perfectly in the real world.
In the end, it comes down to real-world systems being very diverse, which increases the chance of non-documented edge cases. If sys-locale were to panic in these cases, it would make the whole app unusable for users instead of just having a degraded localization experience.

@complexspaces Thanks for your reply, I appreciate it.
It's complete and with many details.
Have a nice day !


Added remote address space to virtual network peering model

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #1453 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
- Coverage   54.62%   54.62%   -0.01%
==========================================
  Files        3142     3142
  Lines       79379    79380       +1
==========================================
  Hits        43362    43362
- Misses      36017    36018       +1

Impacted Files
Coverage Δ

...work/v2017_09_01/models/virtual_network_peering.py
26.66% <50%> (-1.91%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95d529...ec22fa0. Read the comment docs.

The REST API displays the virtualNetworkPeerings remote address space:
    {
      "name": "myNetworkName",
      "id": "/subscriptions/[subscription_id]/resourceGroups/[resource_group]/providers/Microsoft.Network/virtualNetworks/[vnet]/virtualNetworkPeerings/[remote_network_name]",
      "etag": "W/\"[remote_network_id]\"",
      "properties": {
        "provisioningState": "Succeeded",
        "peeringState": "Connected",
        "remoteVirtualNetwork": {
          "id": "/subscriptions/[remote_network_id]/resourceGroups/[remote_resource_group]/providers/Microsoft.Network/virtualNetworks/[remote_network_name]"
        },
        "allowVirtualNetworkAccess": true,
        "allowForwardedTraffic": true,
        "allowGatewayTransit": false,
        "useRemoteGateways": false,
        "remoteAddressSpace": {
          "addressPrefixes": [
            "<IP_ADDRESS>/24",
            "<IP_ADDRESS>/24",
            "<IP_ADDRESS>/24",
            "<IP_ADDRESS>/24"
          ]
        }
      }
    },

The Python SDK doesn't display the remoteAddressSpace:
{
 'peering_state': u'Connected',
 'name': u'[local_name]',
 'use_remote_gateways': False,
 'etag': u'W/"[remote_id]"',
 'allow_forwarded_traffic': True,
 'id': u'/subscriptions/[subscription_id]/resourceGroups/[resource_group]/providers/Microsoft.Network/virtualNetworks/[vnet]/virtualNetworkPeerings/[remote_vnet]',
 'provisioning_state': u'Succeeded',
 'allow_virtual_network_access': True,
 'remote_virtual_network': <azure.mgmt.network.v2017_03_01.models.sub_resource.SubResource object at 0x2f51710>,
 'allow_gateway_transit': False
}

Hi @cr41gc !
I can't unfortunately accept your PR, since the code is generated from an OpenAPI description in JSON.
However, I created an issue in the OpenAPI spec repo, to add the missing attribute. Once it's fixed, I will be able to re-generate Python with the fix (and you just fixed all language SDK at the same time ;))
https://github.com/Azure/azure-rest-api-specs/issues/1704
Thanks!


file descriptors update

This PR updates our minimum and recommended file descriptors limits based on PR https://github.com/cockroachdb/cockroach/pull/9679.
Fixes #704

This change is

@knz, in the original PR, Pete mentioned, " We should recommend using an OS in production which doesn't have issues with that (i.e. Linux)." By that, he meant having lots of open file descriptors.
In the current docs, we have instructions for increasing the limit on Mac and Linux. If I were to put in a suggestion to use Linux in production, is there any particular distribution to recommend?

Debian, CentOS, Fedora, RedHat, SUSE, Ubuntu server, CoreOS, Qubes OS, NixOS, Slackware

Thanks, @knz. So do you think it's sufficient that we state our minimums and recommendations and provide instructions for increasing the limits, and we should avoid listing specific distributions for now?

I'm fine with either really. My gut instinct suggests go for the general requirement and let people search on stackoverflow or other places if they need specifics. If/when we start developing a knowledge base to troubleshoot issues, we'll have distro-specific instructions in there.

@BramGruneir: HTML version is http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d7718e76bc8d6099052b3060e70edb6dd66b65ca/recommended-production-settings.html

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Newegg can load without an Add to Cart button, resulting in a false positive

Description
Newegg loads all the time without an Add to Cart button, but nothing indicating that it's out of stock. This results in a false positive.
Possible solution
Check the website for an add to cart button.

Can you post the positive detection image

https://i.imgur.com/eoNjkjO.png
You shouldn't need the image. There's nothing here I can filter out. We need an inverse filter that checks to see if 'add to cart' is on the page.
Again, the current filter will not work for this issue.

also getting false positive

I have a ton of new awesome false positive detections in my PR.

I ran your PR and it did not fix the issue

We need an inverse filter that checks to see if 'add to cart' is on the page.

This is on latest main now.

Pull that down and run. Let me know if its still and issue. Feel free to close otherwise.
Thanks!

looks like it has been fixed