libcompose{,-cli}/docker-compose "commutable"

Should we be able to start a compose using docker-compose and then using libcompose-cli or directly the API to continue managing those services.
I do think it should be commutable, which is not the case right now.
$ docker-compose up -d
Creating compose_web_1
Creating compose_db_1
$ libcompose-cli ps
# doesn't output anything (except the warning log)

$ libcompose-cli up -d
INFO[0000] Project [compose]: Starting project
INFO[0000] [0/2] [web]: Starting
INFO[0000] [0/2] [db]: Starting
INFO[0000] [1/2] [web]: Started
INFO[0000] [2/2] [db]: Started
$ docker-compose ps
ERROR:
Compose found the following containers without labels:

    compose_web_1
    compose_db_1

As of Compose 1.3.0, containers are identified with labels instead of naming
convention. If you want to continue using these containers, run:

    $ docker-compose migrate-to-labels

Alternatively, remove them:

    $ docker rm -f compose_web_1 compose_db_1

We do generate labels with libcompose but they seem to be outdated and thus not recognized by docker-compose :

with docker-compose

"Labels": {
    "com.docker.compose.config-hash": "9fce3077c9cdae0da859eb66a11677756fcff8703bcbffac810c1ce3ea33eb65",
    "com.docker.compose.container-number": "1",
    "com.docker.compose.oneoff": "False",
    "com.docker.compose.project": "compose",
    "com.docker.compose.service": "db",
    "com.docker.compose.version": "1.5.0"
}

with libcompose{,-cli}

"Labels": {
    "io.docker.compose.config-hash": "f85a1f8e9e5bbde593aed5395ea0a5048ecceb62",
    "io.docker.compose.name": "compose_db_1",
    "io.docker.compose.project": "compose",
    "io.docker.compose.service": "db"
}

Can you please give little details about container-number and oneoff.
I tried to understand PR https://github.com/docker/compose/pull/1356/files, but not much comfortable with python code.


Support ANSI Operating System Commands (OSCs)

See https://conemu.github.io/en/AnsiEscapeCodes.html#ConEmu_specific_OSC
OSC (Operating system commands)
Note. These codes may ends with ‘ESC\’ (two symbols - ESC and BackSlash) or ‘BELL’ (symbol with code \x07, same as ‘^a’ in *nix). For simplifying, endings in the following table marked as ‘ST’.

Sequence	Description
ESC ] 0..2 ; “txt” ST	Set console window title to txt.
ConEmu specific OSC
Sequence	Description
ESC ] 9 ; 1 ; ms ST	Sleep. ms - number, milliseconds.
ESC ] 9 ; 2 ; ”txt“ ST	Show GUI MessageBox ( txt ) for any purposes.
ESC ] 9 ; 3 ; ”txt“ ST	Change ConEmu Tab to txt. Set empty string to return original Tab text.
ESC ] 9 ; 4 ; st ; pr ST	Set progress state on Windows 7 taskbar and ConEmu title. When st is 0: remove progress. When st is 1: set progress value to pr (number, 0-100). When st is 2: set error state in progress on Windows 7 taskbar, pr is optional. When st is 3: set indeterminate state. When st is 4: set paused state, pr is optional.
ESC ] 9 ; 5 ST	Wait for Enter/Space/Esc. Set environment variable “ConEmuWaitKey” to “ENTER”/”SPACE”/”ESC” on exit.
ESC ] 9 ; 6 ; ”txt“ ST	Execute GuiMacro ( txt ). Set EnvVar “ConEmuMacroResult” on exit.
ESC ] 9 ; 7 ; ”cmd“ ST	Run some process with arguments.
ESC ] 9 ; 8 ; “env” ST	Output value of environment variable.
ESC ] 9 ; 9 ; “cwd” ST	Inform ConEmu about shell current working directory.
ESC ] 9 ; 10 ST	Request xterm keyboard and output emulation.
ESC ] 9 ; 10 ; n ST	When n is 0 turn off xterm keyboard and output emulation. When n is 1 turn on xterm keyboard and output emulation. When n is 2 turn off xterm output emulation. When n is 3 turn on xterm output emulation.
ESC ] 9 ; 11; “txt” ST	Just a ‘comment’, skip it.
ESC ] 9 ; 12 ST	Let ConEmu treat current cursor position as prompt start. Useful with PS1.

These are the most interesting and we should consider allowing Terminal.Gui apps to take advantage of them.

ESC ] 0..2; "txt" ST is supported by most terminals. I've tested Console.Out.Write ("\x1b]0;{0}\x07", "Terminal.Gui"); with the WindowsDriver and it works.
ESC ] 9 ; 2 ; ”txt“ ST does not work on Windows Term (but does on conemu).
ESC ] 9 ; 4 ; st ; pr ST works on Windows Terminal - We should add an option to ProgressBar to have it use this!!!

Nice, having the console title showing application name would be a great feature.  And showing progress bar on start menu is pretty neat too.

Relevant
https://github.com/mintty/mintty/blob/master/wiki/CtrlSeqs.md


feat: add codeql workflow for javascript

Issue that this pull request solves
Closes: #15
Proposed changes
Files added

.github/workflows/codeql.yml

To run this workflow you need to enable the following permission:

Go to your project repository settings
On left pane > Actions > General

Scroll down and Go to Workflow permissions > select "Read and write permissions"

Click save and its done.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

@1010varun please review this PR.
Thanks

@1010varun can you please add iwoc24 and difficulty level tag to the PR? Otherwise, my points won't count.


WIP: WFS-T

Initial example using WFS-T to edit a layer with SDK.
This version has the new WFS controller embedded into
the example and not moved into the library.
Warning: This includes PR #632 for which I will have tests written for soon.

WRT: "What's in the demo vs What's in Core", yes, the reducer and the 'controller' will be put into the core.  I started it this was just for my own convenience and also wanted a clean way to tell what needed to change in the existing core to support these changes.  As we're getting increasingly stable and increasingly good coverage I didn't want to have something go sideways with this PR.

cool makes sense @theduckylittle with playback I'm also experimenting the same way to see what needs to be in core and what doesn't need to be there

Coverage decreased (-0.9%) to 96.782% when pulling 26169f9dc82a81ff6617f755cf17eb9d3789f810 on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

Coverage decreased (-0.9%) to 96.782% when pulling 26169f9dc82a81ff6617f755cf17eb9d3789f810 on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

Coverage decreased (-0.9%) to 96.782% when pulling f22aa361562b8023270e60e20fb0d2025c8b1ca8 on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

@bartvde  I think I have all of your requested changes. I know this is missing tests but let me know if you see anything I missed!

Coverage decreased (-1.0%) to 96.662% when pulling f523784a101d0541efc2035fe5e8c9500b913871 on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

@theduckylittle I'd like to get to the bottom of the issue on the geometry name if possible, instead of the workaround. I'll have another look at the code today.

Coverage decreased (-1.0%) to 96.662% when pulling 16b763fe1553f7254b4c7397f683070ca41ac883 on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

Coverage decreased (-1.0%) to 96.662% when pulling 9493fe135b8f5e54cc255d70b0b3433243f0272c on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

Coverage decreased (-1.0%) to 96.662% when pulling 3b8b89622a84c8efc92406ff59dd3462e7586cb4 on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

Coverage decreased (-0.1%) to 97.561% when pulling 80ea1c59fc362fa57c51b9e9f0bbefe7abc5b07c on theduckylittle:feature/wfs-t into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.

Coverage decreased (-0.03%) to 97.649% when pulling 4c3270f119529da1098e797fdd2ba7386d33c970 on theduckylittle:feature/wfs-t into e7b9b66e3b02bb1ae99073b89eb9794579761073 on boundlessgeo:master.

Coverage increased (+0.07%) to 97.751% when pulling e7e753b95ccde6f88f6963edfc27eb1664436be6 on theduckylittle:feature/wfs-t into e7b9b66e3b02bb1ae99073b89eb9794579761073 on boundlessgeo:master.

Coverage increased (+0.07%) to 97.751% when pulling f1df43bea82cfddf3398869f1954ff45653481f0 on theduckylittle:feature/wfs-t into e7b9b66e3b02bb1ae99073b89eb9794579761073 on boundlessgeo:master.

Coverage increased (+0.07%) to 97.783% when pulling 704a2eee9f608ba39065b8a1b1c5c3de94e3f81b on theduckylittle:feature/wfs-t into 1a7464dedc9ef33ca3a9c5dd5bec11b84d017a83 on boundlessgeo:master.

Refs: SDK-621.
Followup work filed in SDK-661


https://leafletjs.com/ is showing over map after some time

After some time (I'm not sure how much) https://leafletjs.com/ website appears over map.
Is there some option to turn that off and why is this happening after all.

Is there some option to turn that off

There is no such feature in Leaflet.
But there is link to website in attribution control, and if someone  tapped on it..
If you observe this behavior without user interaction - it is not Leaflet bug.
BTW, attribution control can be turned off.

That's a... tourist information screen for the croatian city of Omiš. Wow.
Must be a bug in whatever system they got to display a tourist map on that screen. Definitely not the responsibility of the Leaflet maintainers.


Internal factory methods in Ix-Async

Hi,
I'm trying to write a method that continuously pull data from storage based on task api that use paging with continuation token.
I implemented it with Rx Observable, but I prefer to move the control to the consumer.
The methods I saw that felt suitable for the creation of the AsyncEnumbrable were internal:
static IAsyncEnumerator<T> Create<T>(Func<CancellationToken, Task<bool>> moveNext, Func<T> current, Action dispose)

static IAsyncEnumerable<T> Create<T>(Func<IAsyncEnumerator<T>> getEnumerator)

Is there any other recommended way to do it? (Like implementing the interfaces with classes)
What's the reason these methods are internal?

These could be made public. There's no fundamental reason they were kept internal; we just tried to keep API surface minimal back in the day.

Sounds great, we currently solve it by just copying these methods to our project source code, but it's not ideal.
I can create a PR for that.

Hey, just found this issue after doing the same thing (copying the internals into my project). I have come across another OS project that has done a similar thing:
https://github.com/Adamantworks/Amazon.DynamoDB/blob/master/DynamoDB/Internal/AsyncEnumerableEx.cs
This seems such a necessary API to include. I agreed with @Yshayy, those 2 overloads seem the best candidates to make public.


Improve smart search with boolean operators, grouping by parentheses and match operators

I want to be able to do things like "foo-box-1 vlan > 0 vlan < 100" to search for hosts matching foo-box-1 with vlan between 0 and 100.
"core (country=SE OR country=NL)"

@garberg Check it out!!! (and yes, I do have other prefixes and yes, I just created this one :))


use question crate for all questions

https://crates.io/crates/question

e.g. question::Answer::YES


Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

✅ Prerequisites

[ Yes ] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
[ Yes ] Are you running the latest SDK version?
[ Yes ] Are you reporting to the correct repository (magic-sdk)?

🐛 Description
./node_modules/magic-sdk/dist/es/index.js
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
🧩 Steps to Reproduce
yarn add magic-sdk
🤔 Expected behavior
Not have console warnings
😮 Actual behavior
I have console warnings
[If possible, please provide a code repository, gist, code snippet or sample files to reproduce the issue.]
🌎 Environment

Software
Version(s)

magic-sdk
^8.0.1

Browser   -
Chrome 97.0.4692.99 (Official Build) (64-bit)

yarn
1.22.17

Operating System
Linux

Closing as duplicate of https://github.com/magiclabs/magic-js/issues/295
Suggested workarounds are described in that issue 👆


Change the pod name

Currently, the website shows Pod's name as Pod 4.1.X
It should be changed to the Pod's new name(Software Simbas).

The name should be changed to Software Simbas.

@yashika51 can you tag this as a good first issue?

Can I take this issue?

Sure, go ahead!

Thank you! :)


Doesn't seem to work

Hi, I saw this in HACS and decided to try it. Unfortunately I can't get it to work. I've gone into the Edit Dashboard, then Raw Config Editor.
The directions say to add the configuration to the very beginning of the code. Therefore I put it at line 1:
keep_texts_in_tabs:
  enabled: true
title: Home
views:
  - path: default_view
    title: Home
...

But that doesn't work:

I tried adding the code per dashboard page too,
title: Home
views:
  - keep_texts_in_tabs:
      enabled: true
    path: default_view
    title: Home
...
  - keep_texts_in_tabs:
      enabled: true
    title: Weather
    path: weather
    icon: mdi:windsock
...

This also doesn't work, I just see the icons without the title text.
I've tried refreshing the page, force refreshing the page, and restarting Home Assistant. Tried another browser too, just to check.
I'm running docker-based Home Assistant 2023.11.3, Frontend 20231030.2, v1.1.0 of this plugin.

Hi @dziban303,
Let‘s try to find out why it is now working on your side.
First thing to check is if the plugin is executing and there are no errors related to its execution.
Could you look at the console and check that the console.info is there?

And also look in the console and in the logs for any suspicious error.
Regards

By the way, try it only with your first configuration, your second configuration is not valid:
✅
keep_texts_in_tabs:
  enabled: true
title: Home
views:
  - path: default_view
    title: Home

❌
title: Home
views:
  - keep_texts_in_tabs:
      enabled: true
    path: default_view
    title: Home

Hi @dziban303,
A new version has been released with the fix.
Regards

Excellent! Confirmed the issue is resolved. Thank you!


[Bug] Create new repository image shows the wrong repository.

Under step 2 of How to start this course, the image of the new repository page is of a different repository.

Duplicate of #2

Thanks for the issue. We've updated the courses to use a generic image.


Upgrade toochain gcc from 6.3.0 to 6.4.0

I'm embarrassed to say the only thing I've done testing-wise with this is to ensure compilation succeeds. I can put together a buster install with an actual graphical ui to really test the os if you'd prefer.
Also, gcc 6.4.0 regretfully doesn't include the retpoline backport from gcc 7, so it seems toaruos will remain vulnerable to spectre/meltdown for the foreseeable future. I know, it's truly a tragedy.
git commit message below:

This is mainly to address a failure to build from source with gcc 7 (which is
the default gcc on debian buster) unless -fpermissive is set. It turns out gcc
7's error here was very much a real mistake in gcc 6, which is why it got fixed
in 6.4.0. I'd guess there are other such cases that 6.4.0 addresses that I
didn't have the privilege to discover.
Thankfully the current 6.3.0 patches apply cleanly (with zero fuzz) on 6.4.0,
so this commit mainly just moves some names around.
The failure message in question:
g++ -fno-PIE -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/. -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/../include -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/../libcpp/include  -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/../libdecnumber -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/../libbacktrace   -o sanopt.o -MT sanopt.o -MMD -MP -MF ./.deps/sanopt.TPo /home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/sanopt.c
/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/ubsan.c: In function ‘bool ubsan_use_new_style_p(location_t)’:
/home/gerow/repos/toaruos/toolchain/tarballs/gcc-6.3.0/gcc/ubsan.c:1474:23: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
|| xloc.file == '\0' || xloc.file[0] == '\xff'
^~~~
Makefile:1085: recipe for target 'ubsan.o' failed
make[2]: *** [ubsan.o] Error 1

Ok, I was at least able to test in headless mode by convincing qemu to output in -curses mode. Hopefully that's enough 😃


Hugo (BlackFriday) tabSpaceEight enabled by default?

The docs say:

tabSizeEight
default: disabled
Purpose: When enabled, expand tabs to eight spaces instead of four.

But, tabs in my fenced code are being expanded to eight spaces by default.
Is the documentation or the behavior incorrect?
I tried creating a bf-config.toml with the following:
[blackfriday]
extensionsmask = [ "tabSizeEight", "fencedCode" ]

But that doesn't seem to change anything. (I can't even tell if the file is being read.)

Thanks for getting in touch, but it feels like this is a question  that would be better suited to the Hugo Discussion Forum.  We prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug. You may also find the answers you search for in Hugo Documentation.

We prefer to use GitHub issues only for bugs and enhancements

It's not a bug that the documentation says one thing, but the behavior does a different thing?


The change event is triggered twice when using the remove Item button

Describe the bug
If you click the removeItem button (clearing the input) an event is triggered with the current value, then another event is triggered with the new (empty) value.
To Reproduce
Steps to reproduce the behavior:

Go to https://codepen.io/EightArmsHQ/pen/45e90d693e81947159b4cac7caf12abd
Click on the first option in the dropdown
Click the cross
Notice that there have now been 3 events in the console.

Expected behavior
The removeItem button should just fire the change event with the new, empty value.
Desktop (please complete the following information):

OS: iOS
Browser Chrome

Additional context
This bug can be frustrating if you use the change event to trigger a promise, to do something asynchronous, as the results sometimes come back in the wrong order.

any news here?

Any update about this?


Failed url validation

What version of Ajv are you using? Does the issue happen if you use the latest version?
6.6.1, yes
Ajv options object

{ allErrors: true, removeAdditional: true }

JSON Schema
{
  type: "object",
  properties: {
    link: { type: "string", format: "url" }
  }
}

Sample data
{
  link: "http://test.com?ref=text"
}

Validation result, data AFTER validation, error messages
 { keyword: "format", dataPath: ".link", schemaPath: "#/properties/link/format", message: "should match format "url"" }

What results did you expect?
The url should pass.

I think the correct approach is to deprecate "url" format in this package and remove it in the next major version, as it is not part of JSON schema spec.
Either "uri" or a custom definition of "url" format can be used.

#907

I know, that JSON schema spec is uri, but your library supports url as well. It's really hard to force people to add / to the url, if the url without / is perfectly valid. Uri format will pass quite a lot of cases and it's not suited well for urls. I would agree with removing url format from this packag, because it's really confusing. I am using custom url format definition right now.


Create OTel tracing decorator for pagination APIs in storage::Client

The objects are created in the storage::Client, there is no storage::*Connection to insert these things.

Punt

Will require adding a tracing layer to connect all the rpcs.


Chunk Browser toolbar images corrupt when system tool bitmap size option is changed from 16x16

When the system option to change the default toolbar bitmap size in development tools is changed from the default 16x16, the toolbar of the chunk browser shows corrupt images
This is because it uses a toolbar with images populated from a bitmap image strip of fixed size, rather than individual icons, and so can only serve up a single fixed size. Ideally the toolbar would recognise this and still display in the natural size of the bitmaps, but I'm not sure how simple this would be. A simpler alternative would be for this tool to ignore the setting.
Repro Steps

From the System Folder menu bar execute the command Tools/Options/Inspect Options...
Select 'Development System' from the left 'System Options' pane
In the right pane scroll down and double click 'toolbarBitmapSize'
Choose a size other than 16x16 and press the Ok (tick) button
From the System Folder menu bar execute the command Tools/Additional Tools/Chunk Browser

Expected result

Actual result

I'll see what I can do. I can't guarantee decent scaled bitmap icons, but I can at least separate them into their individual elements for the initial 16x16 size. It might take me a few days with the GIMP to create the icons in other sizes.

Okay. I've generated basic pixmaps at all seven sizes for 24 icons. Do you want me to drop them into my repo and issue a pull request? They're all of the form offset-size.png where offset is the bitmap offset within the toolbar, and size is one of 16,20...64. They're not pretty, but it's something to work with, at least.

I think the best thing to do in this case would be to replace the system bitmap icons with other suitable icons from the Dolphin set (there are direct replacements for most, if not all), and to use TextTileIcons for everything else. As the existing icons are mainly just text with a color accent, it won't be much of a visual degradation, and that way all the hard work (and believe me, it is very time consuming) of painting up proper icons can be permanently avoided.

Sounds great. Okay, I'll junk this set then.


Grader convert is not being installed on grader labextension install

Will also update the service and convert packages to use pyproject.toml files instead of setup.py.


Add getNativeSdkVersion to get native sdk version

Summary
Add getNativeSdkVersion to get native sdk version
Motivation
Add getNativeSdkVersion function to reveal the embedded Android/iOS sdk version.
Reference: https://bugs.bbpos.com/browse/SDK-227
Testing

[x] I tested this manually
[ ] I added automated tests

Documentation
Select one:

[ ] I have added relevant documentation for my changes.
[ ] This PR does not result in any developer-facing changes.

@bric-stripe @ugochukwu-stripe could you take a look at the native changes?

iOS bits lgtm


Full width video

Add a full width video component to Topic and Magazine template based on the Screen 9 set up.
Requirements:

Autoplay
Loop
Mute
Options on height size (for discussion - narrow / 2-1 / full screen?)
Ensure spacing top and bottom as per all other components
Accessibility compliant (as all screen9 videos should be)
Alt text description

For discussion:
Parallex behaviour over the video component as user scrolls.
Behaviour on mobile. One alternate size on mobile? 1920 x 1080?
Phase 2:
Add text element overlay (accessibility compliant)
Example:
https://www.apple.com/supplier-responsibility/
https://www.apple.com/careers/us/

@millianapia @meols
Mette can you comment on the accessibility part. What was the conclusion to solve for the top banner? Is it just adding an alt text field?
For parallex, it more, I/we would like to know whats possible, and if it is, then yes likely it would be a wish. The apple example solves this well. Maybe we could have a small meeting on this next week and go through? Could also address the text wish too (although I was thinking we would release first the video without the text, so add that as a phase 2)

@millianapia I see little to no difference in how the video ratios work. I think what nick suggested, using only 3 makes sense. You can copy the height used on the narrow banner for this component.

The setup from full hero image is the expected behaviour i believe:

✅ Removed the extra ratios, but, i actually let the narrow be the same as it was, this is due to it looks better when using on mobile with dynamic height, rather than the fixed 400px height on the narrow banner component.
About the fleeting text - this will be discussed, so i will keep the pr open until all points has been discussed.

@millianapia as discussed Im adding two svgs to this card. Play and pause button. I have left these 100% white but really should be slightly transparent (not sure if you add this? If not I can supply an alt version) Also not sure if you can scale the buttons per screen size or I need to supply specific width x heights, just let me know what you need

thank you @NickHaggerty1, i will be working on this through the #1638 issue

@NickHaggerty1 now the full width video is ready to be tested, this does not include the pause/play button we discussed as this is fixed in the #1638

@NickHaggerty1 you should be able to test this now, there were some problems with deployment to the testsite.

Hey @millianapia @fernandolucchesi Looking great.
One small thing. The play/pause button on desktop should be a little larger. The current size works well on mobile but desktop I would say we scale up up 100%?

@NickHaggerty1 this issue concerns only the full width video component, so i will move this along if that looks ok. I will be fixing the issues regarding the current size of the pause/start button in #1638


TipTap Integration

Built upon the work done by @holtwick in PR #7 .
Made the following changes:

Fix app not working
Add basic editor and menu styling
Add yjs cursor styling (same as that of the ProseMirror demo)

The demo should now run out of the box.

Thanks for this! I updated the scripts a bit to publish it on https://demos.yjs.dev. I'm sure this will be appreciated by a lot of people :slightly_smiling_face:

Glad to hear that!
Good work in yjs by the way.
Keep it up!


Node: devDependencies not installed

I need to compile typescript + run other stuff in postBuild on a package.
After #215 devDependencies seem to be skipped and not installed at all.
I suppose it's caused by this change:
https://github.com/nix-community/dream2nix/pull/215/files#diff-87e8cc4b887cb728b3360960568137ccc5064eeb0e6d0b48976716b999697510L54-R74

After #215 devDependencies are not installed if there is no install script defined in the package.json.
https://github.com/nix-community/dream2nix/pull/215/files#diff-87e8cc4b887cb728b3360960568137ccc5064eeb0e6d0b48976716b999697510R65-R67
Since there is strict convention for splitting dependencies and devDependencies, some packages need devDependencies installed.
Example: typescript in devDependencies needed to build a package.

Fixed by 18c8e247b5036b2bec0cae93d6dd8025c7281b06


Indeterminate Checkbox on Safari w/ VO on MacOS reports state incorrectly

🐛 Bug Report
An isIndeterminate checkbox reports "unchecked" when in the mixed state. If you check using the keyboard it then reports checked (and still looks indeterminate) and then check it again and it reports unchecked (still looks indeterminate)
🤔 Expected Behavior
The state should be the same as that shown visually
😯 Current Behavior
https://reactspectrum.blob.core.windows.net/reactspectrum/41e26fa0f01ee9ab6e5c21edf6f7bb5d498bf40f/storybook/index.html?path=/story/checkbox--isindeterminate-true&providerSwitcher-express=false&providerSwitcher-toastPosition=bottom

Using Safari, Start VO
move to the checkbox and note it is read incorrectly

💁 Possible Solution
I think this is a safari bug as I can reproduce on the indeterminate example at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/checkbox#examples
🔦 Context

💻 Code Sample

🌍 Your Environment

Software
Version(s)

react-spectrum

Browser
Safari 16.3

Operating System
MacOS 13.2

🧢 Your Company/Team

🕷 Tracking Issue (optional)

Does aria-checked fix it? We had it until #3130. We could revert #3687 if that fixes it.

apparently not according to https://github.com/vaadin/web-components/issues/2929

Interestingly this seems to be a webkit issue as this works ok with Chrome+VO

This should be fixed with Safari Technology Preview 161:
https://developer.apple.com/safari/technology-preview/release-notes/

Fixed checkboxes not respecting indeterminate state (258314@main)

If you try STP and still experience this bug, please do post back here (or on bugs.webkit.org).

Thanks - verified.

@jnurthen if aria-checked doesn't fix this, do you know of any other ways we could handle this for older Safari versions?

Closing as there's nothing to be done for older versions of Safari and newer ones work correctly.


Exclude process ID of running tool

Exclude the process ID of the plugin/CLI tool by default. It's not technically incorrect to include the PID from lsps or check_process in the results, but would probably be considered a "gotcha" (e.g., when interpreting the results and continually seeing a running process on a system that is expected to be entirely quiet).
refs https://pkg.go.dev/os#Getpid

NOTE: I'd need to update the README to emphasize the change to make clear that omitting the current running tool is intentional.


chore(ci): notify slack user on “Package & Release” failure

Summary

Notify Slack user on “Package & Release” failure

Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference

Fix KAG-645

Todo: notifiy specific user instead (such as, the relevant person in charge.)

OK ready for review now


Make k6-curl container resources configurable

Feature Description
Hello all,
in our clusters we have team namespaces configured with a LimitRange specifying a maxLimitRequestRatio of 5, cf. OpenShift Container Limits.
However, it seems the k6-operator hardcodes a memory ratio of 100, cf. pkg/resources/containers/curl_start.go (209715200 for limits and 2097152 for requests), and as a result the starter pod cannot start in our team namespaces.
Please make these resources actually configurable. The TestRun CRD already allows setting the resources, but they are not used.
Thanks for considering,
Flo
Suggested Solution (optional)
Most probably a structure similar to handling the Runner resources can be used.
Already existing or connected issues / PRs (optional)
No response

Hi @NT-florianernst, thanks for bringing this up! You're right: this should be a relatively small fix in logic, given that one can already specify resources for jobs 👍


Authentication failure with git dependencies via https on Windows (10)

Summary
Cargo fails to load a git dependency over https on Windows because of not finding the credentials via git's credentials-helper. The credentials are saved in Windows Credentials Manager and a normal git clone works perfectly fine without entering credentials. The problem is not present on Linux using credentials-cache.
What we have tried

including a crate from an private repository via https located on a personal Gitlab instance or Bitbucket using cargo with a dependency like pfwr = { git = "https://git.****.****/****/pfwr.git" }
using plain text credentials-store in the global .gitconfig instead of the credentials-manager

What we expected

cargo should download the dependency from git authenticating via the credential-helper like on Linux when building the project

What happened instead

cargo fails to load the source:

> cargo run --verbose
    Updating git repository `https://git.****.****/****/pfwr.git`
error: failed to load source for a dependency on `pfwr`

Caused by:
  Unable to update https://git.****.****/****/pfwr.git

Caused by:
  failed to fetch into C:\Users\****\.cargo\git\db\pfwr-3bec381543b163f9

Caused by:
  failed to authenticate when downloading repository
attempted to find username/password via git's `credential.helper` support, but failed

Caused by:
  an unknown git error occurred

plain text credentials in global .gitconfig seems to work on one W8.1 machine, but not on two W10 machines tested on

Cargo version

the output of cargo --version on my W10 machine is: cargo 0.25.0 (96d8071da 2018-02-26)

Thanks for the report! Can you share the global .gitconfig you have for the credential helper support?
This is likely due to https://github.com/alexcrichton/git2-rs/issues/274 but I'd just want to confirm!

My .gitconfig is as plain as it could be. After reading your answer I just added the helper = manager line again, but it doesn't change anything.
[user]
	name = ****
	email =<EMAIL_ADDRESS>
[credential]
	helper = manager

Changing the helper to wincred or store or removing the line does not seem to change anything.
Now I tried adding the Git/bin to my ````Path``` variable and I am able to start sh from cmd. But unfortunately cargo still fails.

Ok thanks @spaeger! The fact that updating PATH didn't fix this is quite suspicious!
Would you be willing to try out a custom build of Cargo to see what the issue is? I've just added some debug logging for failed credential helper invocations, testing that out should hopefully be as easy as cloning this repository, adding this to Cargo.toml at the root:
[patch.crates-io]
git2 = { git = 'https://github.com/alexcrichton/git2-rs' }

and then cargo build should build Cargo

Oh and getting the logging out would look like:
$ RUST_LOG=git2=trace path/to/cargo/checkout/target/debug/cargo build

As I added to my comment above, it is now working after a restart. :)

oh oops, sorry I missed that!
I'll look into removing the need to do that.

Thank you for your fast help! 👍

Today I unfortunately found out, that adding the PATH does not seem to work on my other W10 machine. I can open a shell with sh and run cargo run successfully, but directly in PowerShell or CMD it does not work and fails with the same error as above.
I tried to compile Cargo with the following lines added at top of the Cargo.toml:
[patch.crates-io]
git2 = { git = 'https://github.com/alexcrichton/git2-rs' }

but it fails with:
> cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: multiple packages link to native library `git2`, but a native library can be linked only once

package `libgit2-sys v0.7.1 (https://github.com/alexcrichton/git2-rs.git#0c1eb687)`
    ... which is depended on by `git2 v0.7.1 (https://github.com/alexcrichton/git2-rs.git#0c1eb687)`
    ... which is depended on by `git2-curl v0.8.1`
    ... which is depended on by `cargo v0.27.0 (file:///C:/****/cargo)`
links to native library `git2`

package `libgit2-sys v0.7.1`
    ... which is depended on by `cargo v0.27.0 (file:///C:/****/cargo)`
also links to native library `git2`

Did I miss something?

I'm on the latest nightly,
nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.27.0-nightly (eeea94c11 2018-04-06)
cargo 1.26.0-nightly (b70ab13b3 2018-04-04)
This is a fairly 'fresh' install of Ubuntu and cargo. Ubuntu 16.04.3.
error: failed to load source for a dependency on `tower-grpc-build`

Caused by:
  Unable to update https://github.com/tower-rs/tower-grpc-build

Caused by:
  failed to fetch into /home/indie/.cargo/git/db/tower-grpc-build-34ae44599ab52f58

Caused by:
  failed to authenticate when downloading repository
attempted to find username/password via git's `credential.helper` support, but failed

Caused by:
  failed to acquire username/password from local configuration

@insanitybit do you have git's credential helper support configured and has your password previously been cached?

Er, actually, I probably don't have it configured since the system is new. But I pulled down other deps just fine:
tower-grpc = { git = "https://github.com/tower-rs/tower-grpc" }

This works, for example.
I'm unfamiliar with the credential helper/ configuration stuff - if this is on my end I'll happily go sort that out.

If you're cloning a public repo you probably don't need authentication and the way github is set up if you're asked for authentication it may mean that a typo was made?

I just ran into this problem as well.
Each of the following failed

I tried adding Git/bin to path without any luck
I tried nightly and that didn't work either
git config --system credential.helper manager did not work

What did work was this

git config --global credential.helper manager did work

I undid the other changes before I tried the last one, so that seems to be all that's needed. So it looks like git in this case is not picking up the system config settings


Improve column names for disp

This removes the disp_parameter_is_valid column, since it is identical to the disp_tel_is_valid column.
Doing this makes it possible to use the same prefix for both the DispContainer and the ReconstructedGeometryContainer, as filled by DispReconstructor.
As the DispContainer contains the output values of both the regressor (norm) and the classifier (sign) as a single value (sign * norm), I renamed this value to "parameter" to avoid confusion.

HOWEVER: DispReconstructor still creates all the geometry-related columns contained in ReconstructedGeometryContainer even though it only computes altitude and azimuth. But since the creation of such empty columns is not limited to the disp reconstructor, I think it would be better to address this in a different PR.

Related: https://github.com/cta-observatory/ctapipe/issues/2228
We could have a ReconstructedDirectionContainer, a ReconstructedImpactContainer and a ReconstructedGeometryContainer that combines the first two for algorithms that do all on one go.

And some tests and more code has to be adapted, see the test failures.


65 use conan package manager

Changes

Introduce conan package manager, see readme for usage
removed some cmake options. options like MEMILIO_USE_SYSTEM_BOOST or maybe MEMILIO_USE_CONAN could be reintroduced, but I think simple is better for now. I have experimented with this and have a version of this ready if needed that needs only minor fixes.
removed obsolete third party things
new jsoncpp version
test with clang 12 in CI
speed up CI by caching dependencies
moved and fixed cmake install code (#165), installing and using memilio works now, but should be more user friendly, e.g. by making memilio installable with conan (#89 remains open for this)

Closes #65
Closes #165
Closes #88
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:

[x] There is at least one issue associated with the pull request.
[x] The branch follows the naming conventions as defined in the git workflow.
[x] New code adheres with the coding guidelines
[ ] Tests for new functionality has been added
[x] A local test was succesful
[x] There is appropriate documentation of your work. (use doxygen style comments)
[x] If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
[ ] If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ?
is present or referenced. Please provide your references.
[ ] The following questions are addressed in the documentation*:  Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

[ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
[ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
[ ] There are appropriate unit tests and they pass.
[ ] The git history is clean and linearized for the merge request.
[ ] Coverage report for new code is acceptable.

@reneSchm: To help @mknaranja with the review, please try building our project on this branch. Start with a clean build folder and try to follow the README before asking me or before googling - ask me of course if you get stuck. Also try at least a few of the cmake options we provide.
Please check if

everything works, i.e. builds successfully and tests run
the READMEs are complete and understandable. Let me know if you had any problems, even if you managed to solve them yourself

Using a clean install, cmake configures and builds the project without errors, and all tests succed

(except for the occasional bad choice of parameters by random ParameterStudies)

The readme in cpp/ was sufficient to build the project, and could be found via a link from the main readme

Additionally, an existing venv was used to install conan

However, by default a local install of boost is preferred over the conan install, without any indication of this behaviour during configure. In my case, this causes the build to fail.
Unloading the PrgEnv with boost resolves the issue. (The preinstalled version of boost fails to declare variables used in the makro BOOST_OUTCOME_TRY, which causes compilation to fail with "undeclared variables".)
Further remarks on conan:

The first configure step took several minutes, configuring boost for the majority of the time. Without conan, this step is significantly faster (on my machine). Build time appears to be unaffected.
Conan installed all dependencies in ~/.conan/data/.... Should we provide an option/default to place these installs inside the project or build directory?

Thank you for testing.

by default a local install of boost is preferred over the conan install, without any indication of this behaviour during configure. In my case, this causes the build to fail. Unloading the PrgEnv with boost resolves the issue.

This is should not happen. The thirdparty/CMakeLists.txt sets the boost_DIR variable to the build directory, that should be used as a hint by the find_package function. I'll have to investigate that. Which system did you try this on? Do you happen to know if this affected only the headers or the libraries as well? Could you please send me the CMakeCache.txt from the build directory and/or a log of the cmake run? My
guess would be that cmake finds the intended package and adds the correct include paths, but the boost headers are included in the system include path and are found first by the compiler.

(The preinstalled version of boost fails to declare variables used in the makro BOOST_OUTCOME_TRY, which causes compilation to fail with "undeclared variables".)

Out of curiosity, even though I think this probably doesn't need to be fixed, which version of boost was this?

* The first configure step took several minutes, configuring boost for the majority of the time. Without conan, this step is significantly faster (on my machine).

This is expected. A new run should be much faster, though, since it doesn't need to rebuild, it reuses the stuff in ~/.conan

Build time appears to be unaffected.

The build itself should be a bit faster since we don't need to build the dependencies anymore, they are built or downloaded during cmake configure.

* Conan installed all dependencies in `~/.conan/data/...`. Should we provide an option/default to place these installs inside the project or build directory?

The default should be the home directory, since that is almost always what you want. You usually don't want to put the data in the build directory, since then you can't use the same dependencies for multiple builds and everything needs to be rebuilt when you clear the build dir, which is necessary sometimes. Conan itself can be configured in multiple different ways to put the data in a different directory. I don't think we should duplicate that, but maybe we should put a note in our README that the directory can be changed, together with a link to the conan documentation?

Which system did you try this on?

The TeamServer without any modules or PrgEnv loaded, since my go-to PrgEnv has boost included.

Do you happen to know if this affected only the headers or the libraries as well?

The headers are affected, since the compiler errors report the paths /tools/modulesystem/.../<boost header> when expanding the macros - which I assume is supposed to look something like ~/.conan/.../<boost header> instead. But compilation stops at 1%, so I do not think any libraries have benn linked yet.

Out of curiosity, even though I think this probably doesn't need to be fixed, which version of boost was this?

I am using gcc-9.4.0 and boost-1.78.0 (from spack, compiled with gcc-9.4.0).

The build itself should be a bit faster since we don't need to build the dependencies anymore, they are built or downloaded during cmake configure.

I did not do any timings, so it is likely that I just did not notice any speedup when building. Although, reconfiguring is a lot faster using conan.

I don't think we should duplicate that, but maybe we should put a note in our README that the directory can be changed, together with a link to the conan documentation?

I think that would by good. If a user were to not notice the install, the dependecies would be left in home/ when removing the project, which may be unwanted.

resolved merge conflicts

I investigated the issue with boost headers on the teamserver. I was able to reproduce it. It is as I suspected, cmake finds the right package (the one from Conan) but gcc finds the include directory from spack first.
I don't believe there is an acceptable way to fix this from our side. gcc checks directories in this order:

directories specified on the command line with -I
directories in the CPATH environment variable
directories specified on the command line with -isystem
directories in CPLUS_INCLUDE_PATH env var
default paths like /usr/include

spack adds the directories to CPATH. Cmake adds the directories with -isystem. This is usually good, as warnings from headers in system include dirs get automatically ignored. Cmake can be told to use -I instead of -isystem, but of course we would have to deal with warnings from all dependencies. (Also, it feels wrong! :smile:)
The variable that spack adds its directories to can be configured on a per module basis. Maybe this can be fixed on our servers.

I don't think we should duplicate that, but maybe we should put a note in our README that the directory can be changed, together with a link to the conan documentation?

I think that would by good. If a user were to not notice the install, the dependecies would be left in home/ when removing the project, which may be unwanted.

Added a paragraph to cpp/thirdparty/README and a short hint in cpp/README

I am using gcc-9.4.0 and boost-1.78.0 (from spack, compiled with gcc-9.4.0).

I found the problem with boost 1.78. BOOST_OUTCOME_TRY(i, expr) does not declare auto&& i anymore, it assigns an existing variable. There is a legacy macro OUTCOME21_TRY to restore the old behavior.
looks like we will have to upgrade to boost 1.78 anyway. visual studio 2022 (e.g. on the windows 2022 github runner) does not support 1.75, see https://github.com/DLR-SC/memilio/runs/5072775783?check_suite_focus=true

Codecov Report

Merging #187 (8de2e29) into main (25d1129) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   91.29%   91.43%   +0.13%
==========================================
  Files          76       76
  Lines        4697     4680      -17
==========================================
- Hits         4288     4279       -9
+ Misses        409      401       -8

Impacted Files
Coverage Δ

cpp/memilio/io/io.h
71.14% <100.00%> (ø)

cpp/memilio/io/json_serializer.h
85.98% <100.00%> (ø)

cpp/memilio/io/mobility_io.cpp
84.41% <100.00%> (ø)

cpp/memilio/utils/index.h
100.00% <100.00%> (ø)

cpp/memilio/utils/parameter_distributions.h
91.22% <100.00%> (+0.10%)
:arrow_up:

cpp/memilio/utils/type_safe.h
92.98% <100.00%> (ø)

cpp/models/secir/parameter_space.cpp
100.00% <100.00%> (ø)

cpp/models/secir/secir_parameters_io.cpp
89.65% <100.00%> (+1.74%)
:arrow_up:

cpp/models/secir/secir_parameters_io.h
92.59% <100.00%> (ø)

cpp/models/secir/secir_params.h
73.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d1129...8de2e29. Read the comment docs.

I did a clean install on windows. This always led to an error wheni set up cmake with conan. The error output was about only finding a corrupted boost file. I tried some things which didn't help. Then i tried it on linux through nomachine.

Cloned memilio and switched on branch 65-reduced-options.
Created a new virt env through python and upgraded pip to the most recent version.
Installed conan and cmake as descibed in the readme.
Ran cmake in the build directory as descibed in the readme. This is were on windows the error occured. It worked fine in linux. (GNU compiler vs Visual studio build tools).
Build the library with cmake --build . Which worked fine.
./tests/memilio-test worked fine.
./examples/secir-example worked fine.

The Readme was very clearly structured and easily to follow. As described above we should discuss the implementation and description on windows.

A minor nitpick is that the readme code is written for linux. For example mkdir build && cd ./builddoesn't work on windows.

I close this for now.


Machine mac-26 detected errors from monitoring website due to flaky behavior as part of this ongoing issue.

Machine mac-26 detected errors from monitoring website due to flaky behavior as part of this ongoing issue.

Hi @keyonghan, Can you take a look error on machine mac-26?  This is first time I'm seeing this errors.
I have ran errors check from my end and all passed without errors. Thanks.

This bot was just manually quarantined by @ricardoamador to investigate the issue in the quarantine message.
(The bot now supports customized quarantine message: it presents whatever content the file contains)

Hey @ricardoamador Just checking with you.. Are you still looking or working on machine mac-26?

Hi @kentnguyen99, I am not currently, no.

@ricardoamador Is machine mac-26 ready put it back in production?

Hi @keyonghan Are you still working machine mac-26?

From https://github.com/flutter/flutter/issues/121705: Dart GC crash Segmentation fault dart::GCMarker::MarkObjects happened on only this bot, which has been moved to staging.
We should have this bug open to track any potential issue from our infra side. I would wait for updates from the above bug to see if anything should be addressed from dart side first.

I have remove the quarantined file from the bot as it was said the issue has been resolved/not seen for some time. We can leave this issue as tracking or close as we had swapped this bot with another.

The error went away and cleared, machine mac-26 is back online and running normal now. This ticket can be closed.
https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-26


Misspeled "ne sletter" in the top nav svg

@apotonick
This SVG is misspelled https://img.shields.io/badge/TRB-newsletter-lightgrey.svg"
Line 11 https://github.com/trailblazer/trailblazer.github.io/blob/0e61f40cb04364c49abdf72ec4c4b35939643900/_includes/nav.html#L11

P.S.
It should probably be text not image from SEO perspective. IMHO

Thanks, I am changing this to icons soon!


fix: Fix invalid npm package name

Fixes #89

Codecov Report

Merging #90 (2ef9df6) into master (eb486f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.18%   98.18%
=======================================
  Files           1        1
  Lines          55       55
  Branches        8        8
=======================================
  Hits           54       54
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841a12a...2ef9df6. Read the comment docs.


v0.3.0 TODOs

[ ] Fix or remove program filter: issue #103
[x] Layout fixes (overflow not handled correctly by logs and transaction view) -- https://github.com/workbenchapp/solana-workbench/pull/99
[x] Fix analytics -- https://github.com/workbenchapp/solana-workbench/pull/91
[x] Remove non-functional components (Connect to Wallet, Import Account, pause) -- https://github.com/workbenchapp/solana-workbench/pull/90
[x] Styling on account list items (should not alternate gray/white as it's confusing given gray == hover, selected item should be highlighted blue) -- https://github.com/workbenchapp/solana-workbench/pull/90

close, tracking this using milestones: https://github.com/workbenchapp/solana-workbench/milestone/1

🎉

Hate to do this to ya, but I realized there's one more we should do before SHIPIT --

[ ] Bump Docker images to latest Solana 1.9.x

i'm workin on it, PR inbound...

don't mention it here :) just add the 0.3.0 milestone :p
https://github.com/workbenchapp/solana-workbench/milestone/1


Update install-vmware-hcx.md

Adding HCX underlay requirements guidance.

@jjaygbay1

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Modernize the repository

Moves the sources to an src folder
Changes Resin references to balena
README: Repurpose for libraries as the primary use case (but still has a note for standalone projects)
Drops gulp in favor of plain npm scripts
Updates dependencies
Add node & browser async tests as a starting point

Change-type: major

Based on Cameron's heads up in
See: https://github.com/balena-io-playground/typescript-library-skeleton/pull/1#issuecomment-633897517

I think that's fine -- templates are a blueprint, a way to get you up to speed fast, not to enforce guidelines or structures going forward. I remember using create-react-app and hating it immensely because of having to bear the burden of keeping it up to date


Promise seems to be not working

Hello,
It seems the async/await pattern is not working.
  const { request_id: requestId, status, error_text: errorText } = await nexmo.verify.request({
      number: `639151112233`,
      brand,
      code_length: 6,
      format: 'json',
    });

Only the callback pattern is working. Is this a bug or just not supported? Thanks a lot.

Hey @arvi,
Unfortunately only callbacks are supported at the moment. We'll be working on a promise based library later this year

In the meantime you could always wrap the API using promisify (requires Node 8+)
https://nodejs.org/dist/latest-v8.x/docs/api/util.html
Here's an example using the sendSms API
const util = require('util');
...
const sendSms = util.promisify(
  nexmoClient.message.sendSms.bind(nexmoClient.message),
);

async function sendMessage() {
  try {
    await sendSms('bob', TO_NUMBER, 'hello');
    console.log('success!');
  } catch (error) {
    console.log('sad face');
  }
}

sendMessage();

@mheap thanks for the clarification 😄
@fauna5 woaah! I didn't know about promisify. 😄
What I did was to return an ES6 promise like this:
import httpStatus from 'http-status';
import Nexmo from 'nexmo';
import config from './../config';

const { brand } = config.site;
const { apiKey, apiSecret } = config.nexmo;

const nexmo = new Nexmo({
  apiKey,
  apiSecret,
});

export const requestVerification = (mobileCountryCode, mobileNumber) =>
  new Promise((resolve, reject) => {
    nexmo.verify.request(
      {
        number: `${mobileCountryCode}${mobileNumber}`,
        brand,
        code_length: 6,
        format: 'json',
      },
      (err, result) => {
        if (err) {
          const error = new Error(err.message);
          error.code = httpStatus.INTERNAL_SERVER_ERROR;
          reject(error);
        } else {
          const { request_id: requestId, status, error_text: errorText } = result;
          if (status !== '0') {
            const error = new Error(errorText);
            error.code = httpStatus.UNAUTHORIZED;
            reject(error);
          }

          resolve({
            ok: true,
            requestId,
          });
        }
      },
    );
  });

export const verifyPin = (pin, requestId) =>
  new Promise((resolve, reject) => {
    nexmo.verify.check(
      {
        code: pin,
        request_id: requestId,
        format: 'json',
      },
      (err, result) => {
        if (err) {
          const error = new Error(err.message);
          error.code = err.code ? err.code : httpStatus.INTERNAL_SERVER_ERROR;
        } else {
          if (result) {
            const { status } = result;

            if (status !== '0') {
              const error = new Error('Invalid pin. You may have entered a wrong pin or your pin expired.');
              error.code = httpStatus.BAD_REQUEST;
              reject(error);
            }

            resolve({
              ok: true,
            });
          }

          const error = new Error('Invalid pin. You may have entered a wrong pin or your pin expired.');
          error.code = httpStatus.BAD_REQUEST;
          reject(error);
        }
      },
    );
  });

LGTM 👍

In the meantime you could always wrap the API using promisify (requires Node 8+)
https://nodejs.org/dist/latest-v8.x/docs/api/util.html
Here's an example using the sendSms API
const util = require('util');
...
const sendSms = util.promisify(
  nexmoClient.message.sendSms.bind(nexmoClient.message),
);

async function sendMessage() {
  try {
    await sendSms('bob', TO_NUMBER, 'hello');
    console.log('success!');
  } catch (error) {
    console.log('sad face');
  }
}

sendMessage();

Hi @fauna5 , could you let me know what is the nexmoClient.message that you bind for the request?
Thank you in advance.

@nathalieDOXA nexmoClient is the Nexmo instance. Our docs usually have this code for instantiating a client:
const Nexmo = require('nexmo')

const nexmo = new Nexmo({
  apiKey: NEXMO_API_KEY,
  apiSecret: NEXMO_API_SECRET
})

so if you instantiate it with nexmoClient instead, it should work for that code @fauna5 was referencing:
const Nexmo = require('nexmo')

const nexmoClient = new Nexmo({
  apiKey: NEXMO_API_KEY,
  apiSecret: NEXMO_API_SECRET
})

Unfortunately only callbacks are supported at the moment. We'll be working on a promise based library later this year

Using Promise as default is quite a must have to avoid some hacks like https://github.com/Nexmo/nexmo-node/issues/197#issuecomment-409252927 (thanks @arvi BTW!).
Could we re-open the issue until this got implemented?


Port PrimitiveValueTest test for core::Query

(From java.)
Also fix a bug uncovered by the test. (oops)

The travis failure was fixed in #1544. Merge the latest master to fix it.


onViewableItemsChanged, and visibility check

can we have access to flat list props like onViewableItemsChanged, visibility config
we need to track which item is visible now

I think you need to handle onScrollBegin and onScrollEnd.

I think you can use  onScrollBegin and onScrollEnd to do that. If they don't, I'll open the issue again. thx 🍻


use versioneer to set the version of the snap

closes #235.

Thanks for the quick response! Could we have it to python setup.py --version instead of using Versioneer directly? That should be future-proof against changes to setup.py that use something other than versioneer.

The problem is that setup.py requires setuptools. versioneer on the other hand doesn't require any package that are not included in python3.
This version-script executes in the context of the build, so by the time we call the version-script, setuptools is not installed.
We have discussed about a way to set the version at different times during the build cycle, not just at the start. But we don't want to add new features just because they sound cool, before they are really needed by our users.
It would be great f you can explain your use case in forum.snapcraft.io. That will help us assign the right priority for this new feature.
You might find it interesting the discussion that started here:
https://forum.snapcraft.io/t/snapcraft-version-scripts/106

Ah, ok. I guess I was assuming that setuptools is included in the python2/3 package, but of course it's still a separate package.
I'll land this, and I'll check out that forum and explain how Versioneer works. Thanks!


Clicking to remove PD AE, removes checkbox to re-active it.

Add a routine in postupload to double check


nosetests test added for bugzilla utils

I guess you saw that the test is failing:
https://travis-ci.org/mozilla/relman-auto-nag/builds/87835701

@sylvestre : The fix has been done. I couldn't reproduce the issue when I was testing in my environment. So I have added "--nocapture" option also in tox.ini, so that the print messages can also capture.

not sure I understand the action of --nocapture ? Do you have some docs?

--nocapture used to capture stdout
normally it captures stdout only when there is an ERROR
I think she used it for testing and forgot to remove!

@anoopvalluthadam Yeah I have added for testing. But I thought its better to keep. @sylvestre : can we keep --nocapture also?

hmm, seems like --no-capture is going to get less potential information. More info is better, don't you think ? :)

@sylvestre:
Please find the below document:
http://nose.readthedocs.org/en/latest/plugins/capture.html
-s, --nocapture
Don’t capture stdout (any stdout output will be printed immediately) [NOSE_NOCAPTURE]

if we add --nocapture, all stdout output will be printed immediately, So all the "print" statements will get printed. We can understand the flow, if an error occurs, easily we knows where it  breaks.

@sylvestre all changes are done

@anubnair "minor changes" => please avoid this kind of title for a commit :)

@sylvestre All changes are done


Find Familiar - Atack feature does not work.

I can't use the Shocking Grasp spell with my wizard (being within 10ft of the target, even with the familiar being 5ft from the target.

Can you please give the full steps you took to reproduce this?


Add Resource ID to image Path | for indexing

In the current Early_Work/Images folder, the image files in there have been named using an simple sequential index. To improve it, the file naming should include the resource ID.

Depends on issue #25


fix inconsistent base image in Dockerfile and Makefile

Dockerfile was refined in https://github.com/oam-dev/rudr/pull/466, but unfortunately we didn't change the base image used in Makefile, this cause our rudr image can't work #488 .
Our  e2e check didn't find it, because we didn't make the consistent.
fixes #488

LGTM


Add GitHub slack bot for new docs-site repo

docs.royalnavy.io repo added to slack integrations.  pull request notifications added to the design-system-pr channel


build-source-tarball.sh try download SDK, ignoring --with sdk option

I'm trying to build source tarball with already downloadded SDK
But it try to download SDK ignoring already founded
git status
HEAD detached at v3.1.108-SDK
nothing to commit, working tree clean

./build-source-tarball.sh ../tarbals_108/  --with-sdk /home/user/gitlab/libraries/net-bootstrap/
Using custom bootstrap SDK from '/home/user/gitlab/libraries/net-bootstrap/', version 3.1.106
Found bootstrap SDK 3.1.106, bootstrap Arcade 1.0.0-beta.19359.6
+++ dirname /home/user/gitlab/libraries/source-build/build.sh
++ cd -P /home/user/gitlab/libraries/source-build
++ pwd
+ scriptroot=/home/user/gitlab/libraries/source-build
+ '[' false == true ']'
++ date +%m%d%H%M%S
+ /home/user/gitlab/libraries/source-build/eng/common/build.sh --restore --build -c Release --warnaserror false /bl:/home/user/gitlab/libraries/source-build/artifacts/log/Debug/Build_0924162014.binlog /flp:v=diag /p:ArchiveDownloadedPackages=true /p:TarballRoot=/home/user/gitlab/libraries/tarbals_108 /p:PackSourceBuildTarball=true /bl:/home/user/gitlab/libraries/source-build/artifacts/log/Debug/BuildTarball_0924162014.binlog
Downloading 'https://dot.net/v1/dotnet-install.sh'
dotnet_install: Warning: Unable to locate zlib. Probable prerequisite missing; install zlib.
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1.106/dotnet-sdk-3.1.106-linux-x64.tar.gz```

I think this might have the same root cause as https://github.com/dotnet/source-build/issues/1711. We handle --with-sdk differently in different scripts, and I think there are issues in build-source-tarball.sh's implementation.
You might be able to take an idea from https://src.fedoraproject.org/rpms/dotnet3.1/blob/master/f/build-dotnet-tarball, and use build.sh to do your tarball build. The /p:ArchiveDownloadedPackages=true parameter is what does most of the work:
./build.sh /p:ArchiveDownloadedPackages=true  /p:DownloadSourceBuildReferencePackagesTimeoutSeconds=100000 /p:DownloadSourceBuildReferencePackagesTimeoutSeconds=100000
./build-source-tarball.sh "${unmodified_tarball_name}" --skip-build

If you add --with-sdk to the first command, that may get handled by a better implementation of --with-sdk. Then, the --skip-build prevents ./build-source-tarball.sh from trying to download an SDK again there.
Let me know if this workaround helps. (I do want to fix this for real at some point, though.)

--with-sdk in build-source-tarball.sh is specification for the sdk to include in the tarball and is not being passed to build.sh when doing a production build.

In .NET 6 and later, build-source-tarball.sh is gone, the sdk download is handled by prep.sh and the tarball's ./build.sh accepts a --with-sdk option correctly. I think we can close this? I don't expect any changes in 3.1 in the few months before it reaches its end of Life.


Adding a rock paper scissor game

PR Description 📜
Adding a new Stone paper Scissor game
Fixes #4293

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Vaishnavi1047 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @Vaishnavi1047,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

Thank you  @Vaishnavi1047 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Emerald ore producing too many bits, unable to disable

Here is the issue: When i come close to a mountains biome, there are lots of emerald ore. Once i do /seed data bits, it displays hundreds or even thousands of bits. The weird thing here is that:

If you have 32 bits, the bruteforcing may start depending on circumstances
If you have 48 bits, the bruteforcing starts with biomes
If you have 64 bits, you have the seed (very obvious, since all sids are 64 bit)
How come i have more than 64 bits, hundreds or thousand of bits?

Also i can't disable the emerald ores. I do /seed finder type EMERALD_ORE OFF, i do /seed data clear, and after a few minutes of exploring, when i stumble accross emerald ores, the bits SKYROCKET to the hundreds or thousands, leading to the seed to not be found.
Any explanation for too many bits? Why can't it be disabled? It really makes it difficult to find a seed because once you see a mountains biome, the bits skyrocket always leading to the seed to not be found.

You've got it all wrong. To find the seed you need one of 2 things:

32 or more bits of data + the end pillars.
A single dungeon.

You've got it all wrong. To find the seed you need one of 2 things:

32 or more bits of data + the end pillars.
A single dungeon.

Thanks for your reply. Actually the end pillars aren't required, when i find a dungeon it just gives me the seed after 1 minute (very fast).
But the question here is why does emerald ore produces too many bits? And, more importantly, do the hundreds or thousands of bits alter the seedfinding process or not?

That's just how it is... emerald ore gives a lot of information to uniquely identify the seed. It doesn't alter the process in any way.


build error

I was taking a look at this sample. A couple of things

I had to uninstall Windows HPC 2012 client pack from Windows because of node.exe from node.js conflicts node.exe from Microsoft HPC Pack

I got this error, not sure if it's critical or not

Also this error

Hey Don
Thanks for chipping in. Both errors a basically the same (because there is an event store for the conference page as well as one for the dummy page). It tries to open an event store file which is not there yet but it should be working anyway.
The stack trace is printed because I left a printfn in the code
Btw. the second error goes away when you run build.cmd RunFixtures. This will prefill the conference event store with some fixture data and make the conference example usable (and it might even include a proposed abstract from you 😄 )
Regards

Thanks, I didn't read as far as build.cmd RunFixtures

Clean up


Move netty related things to seperator module

There is a hard dependency on netty.   If some legacy app use netty 4.0.x it will cause classpath conflicts

If I remove then it'll be a breaking change. Also, Netty 4.0.x has reached EOL.


Jenkins continues regardless of the test compilation and test execution results

The recent PR https://github.com/AdoptOpenJDK/openjdk-tests/pull/2059 changes the exit code of maketest.sh. As a result, Jenkins continues regardless of the test compilation and test execution results.
In our recent zos test build, the test compilation failed, but the build continued to run all the tests.
Maybe PR https://github.com/AdoptOpenJDK/openjdk-tests/pull/2059 code should be in Post stage https://github.com/AdoptOpenJDK/openjdk-tests/blob/13d113e63e13b21860f453372b97327f6fa440c0/buildenv/jenkins/JenkinsfileBase#L572

Or can just store the $MAKE command exit code.
make_exit_code=$?
'window clean up code'
exit $make_exit_code

yes, we can. But if the build crashes, the Post stage will execute regardless.

Note: the process clean up (#2059) added to maketest.sh is meant to be 'temporary', as in, waiting for PR for https://github.com/AdoptOpenJDK/TKG/issues/45 to land, so that then this check can be moved to TKG setup phase.

Not sure what the ETA for PR for TKG/45 is, if its going to be a while, we can/should take one of the solutions proposed in this issue.

https://github.com/AdoptOpenJDK/openjdk-tests/pull/2121 addresses this, closing this now.


Add PyMutex wrappers

Ref https://github.com/PyO3/pyo3/pull/4504#discussion_r1739869142 and #4265.

Fixes a spelling error in the PyMutex bindings (oops!)
Adds pyo3_ffi::PyMutex::new() to allow pyo3 (and users?) to construct PyMutex instances.
Adds a PyMutex rust wrapper based on the RAII guard pattern.

The test might not be doing anything interesting? I couldn't figure out how to re-acquire the GIL inside of allow_threads and the type errors I was seeing make me think it's not possible.

It wouldn't be obvious to me, if I knew nothing, how or why this mutex works. The design is very unlike the mutex in std or parking_lot.
We should come up with a couple of good use cases and design the api accordingly.

(If it is not ok to move it when unlocked, we will need to do more complicated APIs which make use of pinning, I fear...)

This would be easy, we'd just need to change PyMutex::lock to take self: Pin<&mut Self>

(If it is not ok to move it when unlocked, we will need to do more complicated APIs which make use of pinning, I fear...)

This would be easy, we'd just need to change PyMutex::lock to take self: Pin<&mut Self>

Right, yes. I think however that probably we should change .lock() to take &self and wrap the FFI mutex in UnsafeCell?
That way we still cannot move the mutex while locked, and we also make the API more like std or parking_lot. The &self receiver also seems necessary so that multiple threads can actually interact with the mutex.

Pin would only be necessary if we'd want to enforce that the mutex is never moved once used.
Anyway, this implementation is not an interior mutability primitive. I think most users will expect that.

It wouldn't be obvious to me, if I knew nothing, how or why this mutex works. The design is very unlike the mutex in std or parking_lot.
We should come up with a couple of good use cases and design the api accordingly.

This mutex has the nice feature that if the thread trying to acquire the mutex blocks and holds the GIL, it will release the GIL. The use case is if you need to lock something while still executing arbitrary python code that might trigger releasing or acquiring the GIL.
It's a good point we should wait to add this until we have more of a need for it. Let's see if it we have a need for it in the internal uses of GILOnceCell that may need to be updated.

If we want this to be "like std's Mutex, but it releases the gil while it blocks" that's fine with me, but this PR needs a lot of work in that case.

@colesbury I have a question about the behavior - if we lock it twice on the same thread, say we do
PyMutex mutex = {0};
PyMutex_Lock(&mutex);
PyMutex_Lock(&mutex);
PyMutex_Unlock(&mutex);
PyMutex_Unlock(&mutex);

will this deadlock? I'm guessing yes, because it doesn't say recursive locking is allowed, and it's what I would expect from pthread-like api. I'm asking because if this does not deadlock it is problematic for us (it lets you get multiple MutexGuards and thus aliasing mutable references).

Yes, it deadlocks
On Wed, Sep 4, 2024 at 8:16 PM Bruno Kolenbrander @.***>
wrote:

@colesbury https://github.com/colesbury I have a question about the
behavior - if we lock it twice on the same thread, say we do
PyMutex mutex = {0};PyMutex_Lock(&mutex);PyMutex_Lock(&mutex);PyMutex_Unlock(&mutex);PyMutex_Unlock(&mutex);
will this deadlock? I'm guessing yes, because it doesn't say recursive
locking is allowed, and it's what I would expect from pthread-like api.
I'm asking because if this does not deadlock it is problematic for us (it
lets you get multiple MutexGuards and thus aliasing mutable references).
—
Reply to this email directly, view it on GitHub
https://github.com/PyO3/pyo3/pull/4523#issuecomment-2330360529, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFAD6S4AMRVLMPQ4HBSBF3ZU6PG3AVCNFSM6AAAAABNS3KY3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGM3DANJSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

We could probably write a test that it deadlocks by spawning a thread and allowing that thread to deadlock, and can assert that thread doesn't run to completion after e.g. 1 second.

We could probably write a test that it deadlocks by spawning a thread and allowing that thread to deadlock, and can assert that thread doesn't run to completion after e.g. 1 second.

I'm having trouble writing this test because I run into errors like ``UnsafeCell<pyo3_ffi::PyMutex> cannot be shared between threads safely, so code that calls lock() simultaneously on two threads doesn't compile. It only works if you explicitly move the mutex between threads, as I do in the test.
Am I missing something?

Probably missing unsafe impl<T> Sync for PyMutex<T> {} ?

Probably missing unsafe impl<T> Sync for PyMutex<T> {} ?

This is incorrect, it must be unsafe impl<T: Send> Sync for PyMutex<T> {}

Thanks for the hint! With the last push I can write a test that deadlocks:
    #[test]
    fn test_pymutex_deadlocks() {
        static MUTEX: OnceLock<PyMutex<()>> = OnceLock::new();
        static FINISHED: OnceLock<bool> = OnceLock::new();

        MUTEX.get_or_init(|| PyMutex::new(()));

        let _guard = MUTEX.get().unwrap().lock();

        std::thread::spawn(|| {
            MUTEX.get().unwrap().lock();
            FINISHED.get_or_init(|| true);
        })
        .join()
        .unwrap();
    }

but I have no idea how to write a rust test that safely terminates a deadlocked thread after a timeout. Can you point me to an example I can look at somewhere?

safely terminates a deadlocked thread after a timeout

It doesn't exist because there's no safe way to kill threads in general. This test should be it's own process (is that what integration tests are? I'm unsure).

Thanks for the suggestions!
Can you elaborate about what API surface from std::sync::Mutex you'd like to see implemented? For example, what about poisoning?

This test should be in its own process (is that what integration tests are? I'm unsure).

Ah good point, if I write a small python wrapper I can do this using pytest.

While working on something else, I realized just now that rather than creating a new mutex.rs, maybe this should live in sync.rs along with the other synchronization primitives.

@davidhewitt and I chatted about this today and he convinced me that because PyO3 automatically converts rust panics into Python exceptions, it's actually more important to deal with poisoning, since the default behavior is not to crash the process.
I'm going to take a look at extending this to use LockResult and PoisonError from the standard library, hopefully it won't be too bad.


crashes after completing a level

version: kade engine 1.6.1, played on windows x64
this happens on the downloaded version and website.
reproduce: literally just play the tutorial
https://user-images.githubusercontent.com/64938169/128914375-010636cc-ea1d-4524-b1d8-d51cb2fd1249.mp4
https://user-images.githubusercontent.com/64938169/128915307-557398c0-40df-4295-b56b-d11c1bedeceb.mp4

same

this was already fixed here . https://github.com/KadeDev/Kade-Engine/commit/bbd8599c4675b9f2581c31bba31da411ff6ae70b


please support non-universal (possibly AOT) version of --mobile flag

I love the fact CLI will soon support back the --mobile however I really don't want to use angular universal.
It would be awesome if we can have a non universal (and possibly AOT) version of  seed cli PWA support,
thanks as always,
Sean

correct me if I am wrong but AOT is a better fit for PWA as they give us the smallest runtime, fastest load times and will make angular2 universal irrelevant...  ( traditionally you don't need SEO for apps )
I am really trying to avoid angular universal and if we can have a pure nonuniversal version of this project it would be really helpful...

Universal was only used for generating the app-shell. The app-shell can be done manually like how it's done for polymer and in fact there are other ways to generate the app-shell. Using Universal for pre-rendering causes problems since for Universal we need to isolate state for each request/response. Universal requires applications to at least be testable for it to be universal compatible since the idea is to swap out services using di. For generating the app-shell using the browser is probably the best bet since developers can write any type of code and not worry about rendering fast

gdi2290 are you aware of any angular2 seed project for PWA without universal, just a quick starter with material 2?
regards

https://github.com/webmaxru/pwa-guide-ngpoland/tree/step-dashboard

@gdi2290, thanks for mentioning this repo here. @born2net, please notice - this is not a seed or starter, but more just a proof-of-concept: Mobile Toolkit is possible to experiment with right now (at least some parts of it) and (as a side effect) Angular Material 2 is possible to use with Angular Universal (some components).

tx guys for the comments.
@webmaxru what would it take to remove universal from your project... ?
As I am trying to get away from using universal with my pwa
regards
Sean
FYI @webmaxru
Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/Angular-kitchen-sink
Regards,
Sean

@born2net: just run gulp build-noshell instead of regular build - Universal will not be invoked, but of course you will loose the great possibility to feed totally rendered (incl. inline styles) app shell to the browser (to start paining something meaningful even before JS loaded).

got it, TX!


Cortex-M33 FPU register not saved/restored with GCC

The code available in the Cortex-M33 files tx_initialize_low_level.S and tx_thread_schedule.S depend on macro __ARM_PCS_VFP which is not available in gcc-10.3-2021.10. But gcc defines __ARM_FP that may be sufficient.

Thank you for bringing this to our attention. We will fix this in the next release.

Forgot to mention that this probably also applies to the Cortex-M3, M4 and M7 ports. Since it's related, is the stack setup ok with FPU enabled?

@Ralf264 I will make the change to the M3/4/7 too. When did gnu make this change?

@goldscott I have just learned that the presence of __ARM_PCS_VFP depends on the -mfloat-abi option:

-mfloat-abi=hard defines __ARM_PCS_VFP and __ARM_FP
-mfloat-abi=softfp defines __ARM_FP only
-mfloat-abi=soft both undefined

I've used softfp (for whatever reason) and the compiler was using the FPU registers in a thread as temporary storage.
The CMSIS header files use __ARM_FP only...

Ah, thank you! I have changed our Cortex-M code to use __ARM_FP. It will be in the next release in about a week.

@Ralf264 this has been fixed in 6.1.10, which is now available. Thanks!


flow-remove-types doesn't strip variance sigil

Flow version: "flow-remove-types": "2.157.0"
Input file:
class X {
	static +foo = "abc";
	+bar = "abc";

	run(x: string) {
		return 1;
	}
}

(Reduced from https://github.com/facebook/react-native/blob/f51773ecdedbac19d25eb20894e532edef2cb304/Libraries/Components/DatePickerAndroid/DatePickerAndroid.android.js#L80-L84)
Actual behavior
Output of yarn flow-remove-types flow.js -a:
class X {
	static +foo = "abc";
	+bar = "abc";

	run(x        ) {
		return 1;
	}
}

Expected behavior
The variance sigil of the class fields should also be stripped.

I see two possible solutions:

adding Variance: removeNode, to the visitor:
https://github.com/facebook/flow/blob/f9afdbc9c5971c2517ce96c64d996325cd6e6405/packages/flow-remove-types/index.js#L153-L171
or adding if(node.variance != null) removeNode(context, node.variance); in here:
https://github.com/facebook/flow/blob/f9afdbc9c5971c2517ce96c64d996325cd6e6405/packages/flow-remove-types/index.js#L200-L204

duplicate of #8549


add "email" attribute to "entity.user"

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


storagemover release

https://github.com/Azure/sdk-release-request/issues/3727

/azp run prepare-pipelines

/azp run js - storagemover - mgmt - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-arm-storagemover


[FLINK-30533][runtime] SourceOperator#emitNext() should push records to DataOutput in a while loop

What is the purpose of the change
Improve Flink performance by reducing the average depth of the call stack needed to produce a record.
Brief change log
Updated SourceOperator#emitNext() to push records to the given DataOutput in a while loop. The loop will break when any of the following conditions are met:

The underlying source reader returns DataInputStatus#MORE_AVAILABLE
The mailbox used by the StreamTask has at least one mail.

For the example program provided below, the following 4 function calls will be removed from the call stack needed to produce a record for most records.

StreamTask#processInput()
StreamOneInputProcessor#processInput()
StreamTaskSourceInput#emitNext()
SourceOperator#convertToInternalStatus()

Verifying this change
env.fromSequence(1,<PHONE_NUMBER>L).map(x -> x).addSink(new DiscardingSink<>());

Here are the benchmark results obtained by running the above program with parallelism=1 and object re-use enabled. The results are averaged across 5 runs for each setup.
Prior to the proposed change, the average execution time is 46.1 sec with std=5.1 sec.
After the proposed change, the average execution time is 33.3 sec with std=0.9 sec.
The proposed change increases throughput by 38.4%.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): yes
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@gaoyunhaii Would you have time to review this PR?

@flinkbot run azure

@xintongsong @zhuzhurk Can you review this PR? Thanks!

@zhuzhurk Thanks for the review!
After reading through related source code, I believe this PR won't affect the behavior of multi-input operators, due to the following reasons:

PR only changes the behavior of SourceOperator#emitNext(...).
SourceOperator will only be executed by SourceOperatorStreamTask (see this and this)
SourceOperatorStreamTask only uses StreamOneInputProcessor (see this)

Does this answer your question?

@zhuzhurk You are right. Currently for SQL program executed in batch mode, the program might create a MultipleInputStreamTask that reads from multiple SourceOperator.
I agree it might potentially cause performance for MultipleInputStreamTask. More discussion and benchmarks are needed to understand whether we should make this optimization for MultipleInputStreamTask.
I have updated PR to exclude MultipleInputStreamTask and AbstractTwoInputStreamTask from this optimization. Can you take another look?


Add warnings when working with CVAT v2 servers

Resolves #1599
CVAT is working on a v2 release and cvat.org has recently been updated to v2. There are a lot of changes with v2, one of which is an updated REST API URL. This PR adds support for the v2 API URL and adds warnings when working with a v2 CVAT server.
Example
import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart", max_samples=1).clone()

anno_key = "v2_test"
results = dataset.annotate(
    anno_key,
    label_field="ground_truth",
    url="https://cvat.org",
)

Closed in favor of #1638


Create 'sources' directory explicitly in Pharo

Had a bug being unable to remove the output.json file in NexusDockerVerveineJRunner >> run
The problem was that sources directory where the file is located belonged to root (on linux)
My analysis is that:

the directory <projectDirectory>/sources is used as verveinej source directory
but on a project with no source (parent project for several modules), there is no sources
as the directory did not exist before, I beleive docker (for verveinej) created it automatically
therefore the directory belonged to root (just as the output.json file)

Consequence is it is not possible for a normal user to remove the file

It seems Nexus does not copy the source files in the sources directory, so I am not sure how this is supposed to work?
Does it suppose that source files are always in this place?


New command: rename SharePoint Framework component

Usage
spfx component rename [options]
Description
Renames the particular SharePoint Framework component
Options

Option
Description

--oldName <oldName>
Name of the component to rename

--newName <newName>
New name for the component

-o, --output [output]
Output type. json|text. Default text

--verbose
Runs command with verbose logging

--debug
Runs command with debug logging

Additional Information
Related issue #1327
Command applies the following changes to the project:

*.manifest.json: update id and all name references
config.json: components reference
update React component created by default - rename files and replace names in code
mystrings.d.ts: update references to previous name

Closing due to lack of activity


Add support for client-side default values for models

Sets the specified default value during marshalling when no value is
specified.

https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-client-default for reference


REPdenovo merging fails

Hi,
I tried using REPdenovo and it works fine until merging the different kmer velvet assemblies. While I have 394528 sequences in the contigs.fa_no_dup.fa file, all following merged files and the resulting contigs.fa file is empty. It seems like something in the pipeline is not working correctly.
Any thoughts?
Best,
Philipp

HI Reedwarbler,
I re-compiled TERefiner_1 and ContigsMerger and I am still stuck with the same problem.
Any idea what could be going on here?
Best,
Philipp

Hi Philipp,
I just update the ContigsMerger code, please download and compile. After this, would you please run the following command in terminal and see whether it runs with errors:
./ContigsMerger  -s 0.2 -i1 -6.0 -i2 -2.0 -x 15 -k 8 -t 15 -m 1 -o tmp.gml contigs.fa_no_dup.fa > contigs.fa
You may change the number of threads (-t 15) as you want.
Please let me know how it runs. Thank you.
Best,
Chong

@pbrec , it usually takes a while when running the merging step. It depends on how repetitive and how large the genome is. So I suggests first pick out some contigs from contigs.fa_no_dup.fa, then test whether some error happens.

Hi Chong,
I ran your updated code on a subset of 1226 contigs. There were no errors reported. However, after merging there were 1686 contigs, which is more than before.
the tmp.gml file might indicate where this behavior originates. It seems like multiple merged contigs (NEW_CONTIG_MERGE) are generated including the same sets of original contigs:
NEW_CONTIG_MERGE_114   NODE_640_length_89_cov_3.011236_25_3260_163025 NODE_4113_length_129_cov_2.968992_25_1630_81510_R
NEW_CONTIG_MERGE_115   NODE_640_length_89_cov_3.011236_25_3260_163025 NODE_182_length_134_cov_3.000000_25_815_40755 NODE_1651_length_82_cov_3.231707_25_1630_81510_R NODE_3_length_110_cov_3.154546_25_52168_1043373_R NODE_3099_length_123_cov_3.073171_25_1630_81510
NEW_CONTIG_MERGE_116   NODE_640_length_89_cov_3.011236_25_3260_163025 NODE_182_length_134_cov_3.000000_25_815_40755 NODE_1651_length_82_cov_3.231707_25_1630_81510_R NODE_3_length_110_cov_3.154546_25_52168_1043373_R NODE_3499_length_111_cov_3.378378_25_1630_81510_R
NEW_CONTIG_MERGE_117   NODE_640_length_89_cov_3.011236_25_3260_163025 NODE_182_length_134_cov_3.000000_25_815_40755 NODE_1651_length_82_cov_3.231707_25_1630_81510_R NODE_3_length_110_cov_3.154546_25_52168_1043373_R NODE_101_length_127_cov_3.070866_25_815_40755_R
NEW_CONTIG_MERGE_118   NODE_640_length_89_cov_3.011236_25_3260_163025 NODE_182_length_134_cov_3.000000_25_815_40755 NODE_1651_length_82_cov_3.231707_25_1630_81510_R NODE_1786_length_228_cov_3.026316_25_815_40755_R

Hi Philipp,
Yes, there will be more contigs because after merging we concatenate the original ones after the merged ones. If you run from the pipeline, then after the merging step, there will be a step to remove the contained and duplicate ones. So I think if you run from the pipeline, it should be fine now.
Also, we notice that you have 394528 contigs generated. That's  a large number. Perhaps the genome is quite repetitive. Then merging as many as this number of contigs, it will take quite a long time. My suggestion is you can set the "MIN_REPEAT_FREQ" parameter larger, like 100, which means it will assemble repeats with copy number larger than 100, while the default one is 10.
We are also working on a version that hope can speed up the merging step. Will let you know if done.

Good to know.
Thanks for taking care.
Best,
Philipp

You are welcome and thanks for the feedback. Any other problems just feel free to let us know.
Best,
Chong


[doc/security] Add security/_index.md

Add security index page with introduction to OpenTitan's logical
security features and references to hardware primitives.
Add reference to security/_index.md to landing documentation page.

Synced with @domrizz0 and incorporated his feedback. @asb can you take  a look as well?
Thanks!


New realese with support for python >= 3.10 on Windows

Hello,
latest released version: 0.7 do not contain a PR with fixes for installation on Windows, when python version is greater or equal to 3.10 (actually installation on 3.12 is failing as another issue points out https://github.com/danni/python-pkcs11/issues/165): https://github.com/danni/python-pkcs11/commit/e35e6c45e3dcaaa1511262121ff4ab6769de941e.  Is is feasible to push a new release, so those changes could be included when package is installed with pip install? So installation error could be avoided.
Thanks!

Hello @danni, do you think you could find some time to look into this? I would really appreciate it.

Hi, I'm afraid I don't have a windows box. But could you try running this PR and let me know how it goes for you?

Hi,
Sorry for late response.
I've tested current master ff20b84cf66b176c95034bb4c7ea27c86dc0d3cb and https://github.com/danni/python-pkcs11/pull/144. Master seems to working fine for all version from 3.8 to 3.11. PR is failing for 3.8 and 3.9. Therefore I think that current master could be possible promoted as new release 0.7.1 (or 0.8.0)?
Master:
master commit ff20b84cf66b176c95034bb4c7ea27c86dc0d3cb with pip install . for py38, py39, py310, py311 on Windows machine and it installation is passing for all version.
PR:
Also as you requested I run the same test on https://github.com/danni/python-pkcs11/pull/144.
And here I have errors for py38 and py39.

py39: commands[2]> python -m pip install .
Processing c:\workspace\repos\python-pkcs11
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'error'
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [15 lines of output]
Traceback (most recent call last):
File "C:\Workspace\repos\python-pkcs11.tox\py39\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "C:\Workspace\repos\python-pkcs11.tox\py39\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "C:\Workspace\repos\python-pkcs11.tox\py39\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "C:\Users\c\AppData\Local\Temp\pip-build-env-ufqp2zpc\overlay\Lib\site-packages\setuptools\build_meta.py", line 355, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "C:\Users\c\AppData\Local\Temp\pip-build-env-ufqp2zpc\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in _get_build_requires
self.run_setup()
File "C:\Users\c\AppData\Local\Temp\pip-build-env-ufqp2zpc\overlay\Lib\site-packages\setuptools\build_meta.py", line 341, in run_setup
exec(code, locals())
File "", line 9, in
TypeError: unsupported operand type(s) for |: 'type' and 'type'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

Tox config
I have used tox for those test using  following tox.ini configuration and command py -3.11 -m tox -r -c .\tox.ini -v
However I am not 100% that this is a valid method.

[tox]
env_list = py{38,39,310,311}
[testenv]
skip_install = True
commands =
python -m pip cache purge
python -m pip install .

It worked in my conda python 3.11 environment, but not on the Win native python 3.12. The issue is still there.