Allow caching full response under multiple cache key

E.g. for the iiif-manifest diss service the response is the same for all resources within a given collection. While at the moment the repository resource metadata can be already cached under multiple keys (it's enough if the cache miss handler adds id triples to the handled resource metadata), there is no way to do a similar trick for the whole response.
Same goes for the same resource being requrested with different identifiers (if it has many). Currently we will always regenerate the response and only reuse resource metadata cache.

Solved by<PHONE_NUMBER>397dd958ee4edd613732f1dee5266a with a little different implementation - the response key is always generated from a canonical resource URI (and not the requested one)


 This is a very rough first attempt at ironing some out.
Changes proposed in this pull request

Remove with_site_statuses, subject_count, site_count & course_count
Rebuilt some of the tests to remove

Guidance to review
This is an initial first draft at removing some not all of the dependencies. Right now a bunch of the tests are flagging. I will have to go through each spec manually and later creates to builds or rebuild how the objects are created where necessary.
Just looking for general feedback. Thanks!
Checklist

[x ] Make sure all information from the Trello card is in here
[x ] Attach to Trello card
[ x] Rebased master
[x ] Cleaned commit history
[ ] Tested by running locally

 [M] Improve how we create factories & related data in specs.


upgrade to BrowserUpProxy 2.1.3

It's a fork of BUP, see https://github.com/browserup/browserup-proxy/issues/388#issuecomment-1004097733

@rosolko Yes, mitm-proxy seems to be a better alternative.


Improve support for Sprint Shootout format

Defined session tuples for "race-like" (saw this nomenclature in the docs in a few spots) and "quali-like" sessions which cleans up places where those groupings of sessions are used.
Updated docs to add Sprint Shootout where appropriate.
Added _calculate_quali_like_session_results method to calculate quali and sprint shootout results from laps.
Used _calculate_quali_like_session_results to calculate sprint shootout results since Ergast doesn't support that format yet.
Added some logic to support sprint_shootout event format when loading the schedule. Ergast doesn't support it yet, so for now assuming any sprint race for 2023 should use sprint_shootout format.
Added/updated some tests with sprint shootout scenarios.

Hi, thank you for this contribution. This is very well implemented, tested and documented already. I only have some minor notes that you should address, please.
The remaining CI failure is currently expected and unrelated. You can ignore that.

Everything should be fixed now

I'll merge this as it is. The remaining CI failures are caused by some general problems with the test runs that I'm currently fixing. So they are unrelated.
Thank you very much for your work on this PR!


Install fails on Python 3.5.1

This seems to be due to an older nltk version. nltk 3.2.1 installs fine.
Collecting nltk==2.0.5 (from newspaper)
  Downloading nltk-2.0.5.tar.gz (954kB)
    100% |████████████████████████████████| 958kB 105kB/s
    Complete output from command python setup.py egg_info:
    Downloading http://pypi.python.org/packages/source/d/distribute/distribute-0.6.21.tar.gz
    Extracting in /tmp/tmp_s3pa1pm
    Traceback (most recent call last):
      File "/tmp/pip-build-0cdit31h/nltk/distribute_setup.py", line 143, in use_setuptools
        raise ImportError
    ImportError

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-build-0cdit31h/nltk/setup.py", line 23, in <module>
        distribute_setup.use_setuptools()
      File "/tmp/pip-build-0cdit31h/nltk/distribute_setup.py", line 145, in use_setuptools
        return _do_download(version, download_base, to_dir, download_delay)
      File "/tmp/pip-build-0cdit31h/nltk/distribute_setup.py", line 125, in _do_download
        _build_egg(egg, tarball, to_dir)
      File "/tmp/pip-build-0cdit31h/nltk/distribute_setup.py", line 99, in _build_egg
        _extractall(tar)
      File "/tmp/pip-build-0cdit31h/nltk/distribute_setup.py", line 467, in _extractall
        self.chown(tarinfo, dirpath)
    TypeError: chown() missing 1 required positional argument: 'numeric_owner'

I think you're installing the wrong version of newspaper... the Python 3 version is newspaper3k.
Can you try: pip install newspaper3k?

Whoops! Sorry about that. Didn't realize there was a separate package name. I should have read the documentation more carefully.

No problem, this happens very often... the 2 package names are confusing...

@yprez I think it would be helpful to just stick a big pip install newspaper3k at the top of the README. When I want to mess around with a library this is usually the first thing I do and it probably would have saved me from opening the issue in this case.

@michaelmior True, currently the installation instructions are somewhere far below in the readme...


1.0? Resolves #38 and #39

Ok, there's a lot of changes, but I managed to keep all tests passing.
I ended up replacing the reduce loops with lodash's unionWith. To reflect these changes, I renamed the existing functions to uniteRules and uniteEntries. For prepending, I use differenceWith since those let us control where we put loaders that don't already exist. This also got rid of some weird behaviors that aren't explicitly tested for - I've noticed that the merged results are often in reverse-order for some my configs; also, loaders that get updated show up at the end of the array instead of staying in their original index.
There actually shouldn't be a need for any additional tests related to #38, since in Webpack 2 the loaders property acts purely an alias for use. As long as configs are consistent about picking one, they are both handled correctly.
Besides that, I noticed some code style optimizations to be made. join-arrays.js is now only 35 lines! Everything should be just as or slightly more performant, since the busy work is now being offloaded to lodash.

Thanks a lot! I published 1.0. 👍


Make more packman flags configurable

In particular, the --services_root and --include_path flags for gen-api-package are useful for APIs that are not in the googleapis repo,

Is this obsolete since we are moving away from Packman now?

Yup, let's close this out. (Unlike Packman, the new flow doesn't care whether the input protos are located in googleapis.)


Components: Deck Swiper

Read this: Working on a PR | CONTRIBUTING | Galio's docs
As I've written in our wiki. We're working towards v0.6 and for this thing to happen we need the following components.
Do you want to help? Just comment if you wish to work on:

[ ] Deck Swiper

If anybody has questions please comment them below.
🤙🏽

Do you mean Tinder like collection view layout? I did something similar in native Swift here: https://apps.apple.com/pl/app/the-idea/id1454724260
I can try to pick it ReactNative. Are there any requirements like "data source should be..." etc ?

Hi @Chojecki ! Yeah, Tinder is the best example of this kind of component. It should be a component with the Tinder deck swiping feature which accepts any type of component. So basically if I want 4 Text components to be stacked one on top of the other and I want to swipe them to the left/right in order to get to the next Text component it should work.
Do you have any ideas about how should we go on about this component?
Thanks

@palingheorghe Ye, I guess it could be a Component which takes an array of Components and map them into Stack of animated views wrapper with those components inside. Then all drag and drop logic will go to this animated wrapper. Not perfect as we can't predict the shape of array but should work. I will try to fork the repo and create something

Is this issue still open?
As I have made a horizontalScroller before and I could raise a PR here for it ?

@shubhamkakkar sure, you can take it if you want. I just started doing it in functional components with hooks - I can share you gist if you want, but feel free to pick it instead of me.
mine works like this when we inject just 3 simple Text components into it:

Hey, it would be nice.
Share me the gist
It would be highly beneficial
Thank you

@shubhamkakkar link to my code: https://gist.github.com/Chojecki/5c76675ef2a2889ae6e360d4d8a35846

https://codeburst.io/horizontal-scroll-animations-in-react-native-18dac6e9c720
I was thinking something like this, but with better effects and UX
what's your say?
@Chojecki

Not sure if this is a Deck Swiper as it isn't a "Deck" but just a CollectionView/ListView of elements
No idea. Better ask @palingheorghe

Yup i can relate to it not being a ideal deck type
What's your views about https://link.medium.com/FsQ0zwXqlY

For me its too specific. I can imagine that users will want as much vanilla component as it’s possible to customise it like they want. Like @palingheorghe mentioned, the perfect example is Tinder like deck. But hey, its not mine repo, so do what you consider the best :)

Haha
I get it,
the reason why I dont like tinder's deck is because once the component is swiped of, it goes out and with no way to retrieve it, its actually the concern
Where as   https://link.medium.com/FsQ0zwXqlY this if given proper work could be a better swiper than others, with proper chance of rechecking our old swiped out  factors
@Chojecki  and @palingheorghe

Hi @Chojecki and @shubhamkakkar ! Guys, I'm really happy that these types of conversations are going on in Galio's repo! ❤
I understand your concern @shubhamkakkar and I like the whole 'component shouldn't disappear' thing. Can't we combine those two ideas? We could have a prop like intact which could let the user(the dev using Galio) toggle between a component where the cards disappear  and one where everything re-shuffles as in your example. That's a great point.
Thanks to both of you for your awesome work so far @Chojecki @shubhamkakkar ! This is really awesome and I love it when great ideas get together.
What do you think about the intact prop?

intact props sounds cool, I will try  working on that.
In the mean time I was trying to achieve the monzo card animation and I have come to the requriement of using libraries like react-native-animated and redash
Is there any limitation on extra libraries or not?

@shubhamkakkar sorry for the late reply, I was always trying to avoid more libraries. Do you think we could do this with a lighter library? I know we could add the dependencies in peerDependencies and the user needs to install those only if he's using them. So basically if the user really needs to use the deck swiper I guess he won't mind installing those?
What do you think about this? Would adding those libraries make Galio slower and heavier?

Hi @shubhamkakkar are you still working on this?

@shubhamkakkar imma bump this one more time cause I need to know the progress of this component
thanks ❤

I am sorry, I wasn't able to reply on time,
NO, I am not working in this one !!
Sorry for the inconveniences caused!!
On Mon, Sep 2, 2019, 9:44 PM Petru Alin Gheorghe<EMAIL_ADDRESS>wrote:

@shubhamkakkar https://github.com/shubhamkakkar imma bump this one more
time cause I need to know the progress of this component
thanks ❤
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/galio-org/galio/issues/87?email_source=notifications&email_token=ABGTFMORODBYIYLDQDPXYI3QHU3VLA5CNFSM4HR2RXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WGDMY#issuecomment-527196595,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGTFMPL4OK5EF3SK5VRHK3QHU3VLANCNFSM4HR2RXKQ
.


draft rationale for uTP spec

This is still a draft. I noticed there were some recurring questions about the choice of using uTP, in particular why we can't use TCP. I went through the spec and had some questions of my own, many similar, but I thought it might be useful to include a rationale section to the spec to explain why uTP and why we even need it in the first place. This helped me to understand a lot of things, and might help others in the future understand more easily too.
There are some things that might not be necessary, as there is overlap a bit of overlap with the current spec. There are also some additional questions I have, but I'll open that in an issue here.

Closing this because it's old.  We can revive if there's still something here that should be preserved.


file structure reflecting AX layer structure

Hi Rodrigo,
thanks for your work at gitax.
Anyway, as I think about using git with AX, I find using model-based versioning insufficient:

When overloading single method of a class from another model (or lower layer? srry .. not sure), I have to move whole the class to one model to be able to use VC.
I also can't version the changes in other layers - if update or external contractor changes behaviour of lower layer class, I won't even noticed it

Would it be useful to reimplement the file structure to reflect layer structure of AOT?
Or do you have other solution for such an issue?

hi @weedgarden
thanks for your comments. Can't really answer right now but will do my best to answer by EOD

thanks for immediate readction, I'm looking forward to your answer
as I tried using gitax little more, I found the first bullet is not an issue:

when overriding method of a lower layer class, xpo generated from the class contains changes in current layer only
when overriding method of a class from another model, I simply switch to that model or move whole the class to one model, xpo generated again contains this layer changes only

I think we should have a better repro step for the second bullet.
is this 'another model' a foundation model or custom model?

sorry, I wrote my second post not that clearly I thought: I wrote about the first bullet of my original question - these two bullets at the second post are just the solution I found for the first issue
well, now there remains just the bullet discussing how to version changes in lower layers

@weedgarden let me get my azure vm back and we're going to work on that too

Hi @weedgarden sorry for taking too long to answer your question
If you don't add the model to the version control, when you add the AOT object to the version control it should add the object into the layerfolder/AOTtype/FileName.xpo, example:

Create new job called Excel
Add to the version control in
Check it will add a new file in c:\yourrepositoryfolder\usr\Jobs\Excel.xpo

I think this answer your question, let me know if I can close this issue

Hi @fraga
Thanks for your answer.
I didn't know about possibility to add an AOT object to VC without model versioning, so thanks you clarified me that. Anyway as I tried to version e.g. AbatementCertificate_IN (sys layer, Foundation model) I got an error message:
\Classes\AbatementCertificate_IN can't be added to version control as it does not exists in usr layer
As far as I know it could be limitation of the licence my company has.
The goal of this question was to be able to version also code changes from lower layer - changes of external contractors or MS itself (patches, service packs etc.).
If you don't know about other solution, please, treat this question as closed.

Yeah @weedgarden you really can't add to version control an item that is not in your current layer.
You really don't want to control others code, it makes harder to maintain your own code.
Tks


documentation content improvements

Summary

uses all of vic's existing changes, more changes to come, but at the same time, I'd rather not stall these existing changes.
Checklist

[ ] If code changes were made then they have been tested

[ ] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running black .

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

Reverted, and fully purged from history the docstring commit.
We decided it was not a wanted changed and due to the merge conflicts, rebasing it out of the history was the solution.


Relation of connexion and swagger code generator

Description
Connexion can be used standalone, or you can use the online swagger code generator at http://editor.swagger.io/ . The online generator generates a bunch of files for use with connexion.
My questions are:
Why would you use the code generator at http://editor.swagger.io/ instead of connexion directly?
Can you explain the difference in use case?

I follow mixed approach: models are generated, but the rest of code is custom. Since I dont like the way swagger-codegen gives me the project.

Connexion can be used independently.
The code generator generates a code skeleton for a Connexion application based on your spec. You can use it to speed up your development.


Compilation problem with modules

.../Arduino/libraries/SimpleDHT/SimpleDHT.cpp:72:27: error: no 'int SimpleDHT::getBitmask()' member function declared in class 'SimpleDHT'
 int SimpleDHT::getBitmask() {
                           ^
.../Arduino/libraries/SimpleDHT/SimpleDHT.cpp:76:24: error: no 'int SimpleDHT::getPort()' member function declared in class 'SimpleDHT'
 int SimpleDHT::getPort() {
                        ^

The path is OK, I've modified it
This is the first time i'm trying to use something else but DHT.h
Feel free to ask for any tests

I use:
Debian 9
official IDE v.1.8.5
importing SimpleDHT.h v.1.0.10 with the built-in library manager
and using it like that:
#include <SimpleDHT.h>
int pinDHT22 = 2;
SimpleDHT22 dht(pinDHT22);

having a trouble already (even if never use it in further code - I've removed everything about AM2302 haunting the problem)

Right a moment ago found a new version SimpleDHT.h v.1.0.11 and it makes no problem while being compiled with the same code.
I guess it's not an issue anymore but 1.0.10 should probably be purged from the public library repo.


Particles: System does not update when Emitter Radius is changed

To repro:

Create a sphere emitter
Change the emitter radius

Result:
The particle system does not change

Seems like being fixed some time ago, cannot reproduce using master branch. Please verify so.

You're not following the (very complicated) instructions to reproduce, @Maksims. I can demonstrate tomorrow if you like.

This seems fixed now. Closing...


Question: How to design projects to support versioning?

Hello,
In case we would like to support different versions of our Web API (for backwards compatibility),
do you have a suggestion or an example?
There are suggestions regarding the controllers (https://github.com/microsoft/aspnet-api-versioning), but how can this be applied in Clean Architecture?

Yes, the recommended approach is to not expose the command and queries as DTOs through the API, e.g. don’t expose CreateCustomerCommand. Instead, within each version create request DTOs within the API that are exposed, e.g. CreateCustomerRequest. The API will be responsible for converting these DTOs into the relevant command or query.
You can then support multiple API versions and also modify command and query DTOs without changing the API.
Hope this helps. 😀


pin @salt-ds lab package and pip manually

One for discussion, @joshwooding asked if we could pin the labs version and pip manually.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1239

Relevant Lines:
1723

💛  - Coveralls


Removes logic required to refresh temporary secrets

This PR aims to satisfy OSD-4088 by removing temporary secrets entirely.
Instead of keeping these secrets on hand they should be generated with the osdctl cli.

We'll merge it as soon as we update the SOP for obtaining the console URL using the osdctl. @clcollins can you please update here with a link for the card?

@iamkirkbater can you please rebase?

Ops SOP PR 873 is on hold and should be merged with this.

/retest

/retest

/lgtm


[BUG]: No Save/Download option with VSCode

Issue description
There is no option to save the rendered mapping with the VSCode Extension.  The Save and SaveAs do not seem to have any connection with the generated diagram
Media & Screenshots
No response
Operating system
Version: 1.75.1
Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
Date: 2023-02-08T21:34:59.000Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.6.0
Sandboxed: No
Priority this issue should have
Low (slightly annoying)

Merging under #29


Do not crash when string ends in backslash

The problem was that the parser would read beyond a backslash even if it
was the last character, so rather than reporting it as invalid JSON and
throwing an error it would try to read beyond the string and crash. This
fix just adds a check to ensure that the parser doesn't read out of
bounds.
Also added a test to handle this case.
I'm still not very familiar with the code base, so if there are any styles nits, or any other feedback I'd be grateful!

Addresses #206

Thanks! Sorry for the long delay.


Property "" was accessed during render but is not defined on instance.

Warn: [Vue warn]: Property "shows" was accessed during render but is not defined on instance.

I have a similar situation, could anyone tell how can I fix the v-for loop?
Design:

Template:

{{ show.date }}

{{ show.month }}

{{ show.showName }}

{{ show.showDesc }}

Script:
const activeIndex = ref(0);
const shows = ref([
  {
    date: "15",
    month: "JUN",
    showName: "Piano Duo Recital by Lucas & Arthur Jussen",
    showDesc: "Hong Kong Museum of Art",
  },
  {
    date: "15-18",
    month: "JUN",
    showName:
      "Chinese Opera Festival 2023: Opening Programme - Peking Opera Theatre of Beijing",
    showDesc: "Hong Kong Museum of Art",
  },
  {
    date: "15-30",
    month: "JUN JUL",
    showName: "Chinese Culture and Dance Festival 'Hong Kong Dance Expo 2023'",
    showDesc: "Hong Kong Museum of Art",
  },
  {
    date: "30",
    month: "JUN",
    showName: "4",
    showDesc: "Test",
  },
]);

Originally posted by @Matthew2306 in https://github.com/vuejs/vue/issues/3780#issuecomment-1678364902

Please follow the issue template, otherwise we'll close the issue directly. Thank you.

Please follow the issue template, otherwise we'll close the issue directly. Thank you.

Issue template? What do you mean

See https://new-issue.vuejs.org/

@Matthew2306 did you opened another one?

Yo @Justineo please do not hide behind some bureaucratic rule. This is a real issue that users are bumping into on a daily basis. And there is not a word in the documentation explaining this.

So please consider reopening this issue and explain how we can fix this.


pls add syntax highlight support for solidity, serpent, etc

languages for blockchain ethereum smart contract

We're not taking mode requests (or adding more modes to the main distribution in general). You'll have to implement and distribute them yourself if you want such modes.


[QST] How do i get compressed buffer (or compressed buffer size)?

I follow the high_level_quickstart_example and try to use high level api. In particular i'm facing with the  decomp_compressed_with_manager_factory_example method. I am wondering if it is possible to achieve the compressed buffer (or the seze of compressed buffer),  in order to use it to save on disk (as binary raw data) or to send in on the network.
Thank you in advance
Kind regards

I try to answer my own question. The right code i should look at is low_level_quickstart_example.cpp. I get compressed buffer using device_compressed_ptrs and device_compressed_bytes: to access to these data, a copy from Device to Host needed. Hope to be useful. Kind Regards


Issue with k8s.io/docs/concepts/services-networking/network-policies/

netpol mentioned  at concepts/services-networking/network-policie on kubernetes.io appears to be incorrect.
ports field appears inside to  in egress and from  in ingress. But according to kubectl netpol -h, both ports should appear in ingress and egress section in parallel to to/from. Below is the reference:
[07:25 PM IST 01.10.2021 ☸ <IP_ADDRESS>:54146 📁 .kube 𖦥 ]
 ┗━ ॐ  kubectl explain netpol.spec.egress
KIND:     NetworkPolicy
VERSION:  networking.k8s.io/v1

RESOURCE: egress <[]Object>

DESCRIPTION:
     List of egress rules to be applied to the selected pods. Outgoing traffic
     is allowed if there are no NetworkPolicies selecting the pod (and cluster
     policy otherwise allows the traffic), OR if the traffic matches at least
     one egress rule across all of the NetworkPolicy objects whose podSelector
     matches the pod. If this field is empty then this NetworkPolicy limits all
     outgoing traffic (and serves solely to ensure that the pods it selects are
     isolated by default). This field is beta-level in 1.8

     NetworkPolicyEgressRule describes a particular set of traffic that is
     allowed out of pods matched by a NetworkPolicySpec's podSelector. The
     traffic must match both ports and to. This type is beta-level in 1.8

FIELDS:
   ports	<[]Object>
     List of destination ports for outgoing traffic. Each item in this list is
     combined using a logical OR. If this field is empty or missing, this rule
     matches all ports (traffic not restricted by port). If this field is
     present and contains at least one item, then this rule allows traffic only
     if the traffic matches at least one port in the list.

   to	<[]Object>
     List of destinations for outgoing traffic of pods selected for this rule.
     Items in this list are combined using a logical OR operation. If this field
     is empty or missing, this rule matches all destinations (traffic not
     restricted by destination). If this field is present and contains at least
     one item, this rule allows traffic only if the traffic matches at least one
     item in the to list.

I see the ports filed is in parallel to to/from, ehh...
  egress:
  - to:
    - ipBlock:
        cidr: <IP_ADDRESS>/24
    ports:
    - protocol: TCP
      port: 5978


[WIP] Drag & Drop Navigation Reordering

Closes #4540

Implements drag & drop to reorder navigation items
Adds a sort property to navigation items
Adds a tiny library to enable touch events for drag & drop. It hooks onto jQuery UI.

I just took this for a spin, and it seems like the drag & drop works fine, but adding a new item and pressing save sends that item to position 2 in the list rather than the last position.

Updated, almost complete reworked actually. I've added a sort attribute to the JSON stored in the DB.
There's one little bug, but this is very close I think.

Updated again, and I think I've solved any issues. Here's a gif that shows reordering, and adding multiple news items and reordering, then saving at the end. The order remains.
Because there's now a sort attribute stored in the JSON, we should either sort nav items in the {{nav}} theme helper, or store nav items in the correct order when saving to the database. Thoughts welcome. :)

Looks rad! \o/

Updated again to sort nav items before being saved.

Ember looks fine with me, talked with paul in chat a little about how his jquery is similar to a pattern used in our tab panes for parent/child view interactions.
My only other comment is, can sort be renamed to order or something along those lines?


Add to Awesome Cryosphere list

Description of the desired feature:

Add this to the list of Awesome Cryosphere tools when it's at a more complete stage.
Are you willing to help implement and maintain this feature?

Yes

Closed with https://github.com/awesome-cryosphere/cryosphere-links/pull/36


Establish packaging and docs

This is just a placeholder for what was originally the main branch, in which @glatterf42 and I had reorganized the code into a Python package, added Sphinx documentation, etc.
Because @amastrucci and @Zh-xy continued to work on a parallel branch (originally dev_inputs) that is now the new main, these two branches have conflicts. Fridolin and/or I will need to (at some point) rebase, and re-do the work in order to make it applicable to the new main.

Fridolin and/or I will need to (at some point) rebase, and re-do the work in order to make it applicable to the new main.

This might be doable by:

Create a new tmp branch from main.
Cherry-pick the commits up to but not including "Reorganize STURM R files into a package subdirectory"
Manually re-do "Reorganize STURM R files into a package subdirectory"—this is essentially git mv repeatedly.
Cherry-pick the remaining commits.
Force push this new branch to packaging-docs here.

Superseded by #15


Removed build tools no longer needed on GitHub Actions

Coverage remained the same at 40.969% when pulling a125d9cd491d29172bff239608444ef7fe20b82b on andy/remove-tools into 03c84d3decd99dac1c9b594566206fc1baf50f94 on master.


Support API key name

Support API key name

@albinpa Don't do this, this needs further discussion.


Wrong Version in the latest release - 5.3.0 when it should be 6.0.0.

Hi,
If you download and install version v6.0.0, you will find that after unzipping and installing the workflow, you are getting version 5.3.0.
Link to download: AWS.Console.Services.v6.0.0.alfredworkflow.zip
The source of this issue is the info.plist file, which contains the wrong version:
	<key>version</key>
	<string>5.3.0</string>
	<key>webaddress</key>
	<string>https://ryankoval.com</string>
</dict>
</plist>

Thanks

First, thanks for the great workflow!
I'm seeing the same thing. I bet the workflow is updated and the Alfred version not being bumped just shows the 'please update' notice so it's not a huge deal!


enable precompilation

This enables precompilation on 0.4; as far as I can tell, Conda is precompile-safe.  (Furthermore, Conda will often get precompiled anyway if it is imported by a precompiled package like PyPlot, so this just makes it "official".)
As a separate slight optimization, I made the CHANNELS array const and gave it a concrete type.  You can still modify it with push! etcetera, you just can't assign it to a completely different array. The concrete type is UTF8String, so you can still push any other unicode-compatible string type to the array, and it will just get converted upon assignment.

Thank you !


CLI-Tools concept

As the need for the first cli-tool (user-import) arises we need a rough concept:

Admin-tool / Utilities are shipped within the single-binary i.e ocis tool import-user or ocis i mport-user

Need to be shipped stand-alone in case ocis runs in single-service mode?

Always use ocis on the client-side for administrative tasks?
Need away to send messages to an already running ocis-instance
Authentication? I like the reva-concept where every cli-command is authenticated.

related https://github.com/owncloud/ocis/pull/93#issuecomment-578196068
I vote for a dedicated ocis-cli repo, similar to other extensions. The cli works standtalone and in ocis we can import the cli commands from ocis-cli.


Bounties for 3Box dapp

@michaelsena Thinking of what would be good bounties for the dapp now - in picking a good issue, I'm looking at what features are kind of cleanly separate from the architecture of the app, so they're a manageable chunk of code and can fit in regardless of the way we move forward with the dapp.
With that in mind, I think https://github.com/uport-project/3box-dapp/issues/114 and https://github.com/uport-project/3box-dapp/issues/60 would be good initial issues to have a bounty for!


Product not added in cart according to added quantity when doing buy now

Framework Version: 0.1.1
Test Steps:

Click on product and go to product page.
Update the quantity of Product.
Click on Buy Now.
Check the quantity of product in cart.

The buynow functionality is currently only capable of checking out using single click and single quantity of the product is added to the existing cart.


Add docs about testsing in local environment

Are these enough? https://github.com/yiisoft/yii-db-migration/blob/master/docs/en/testing.md


Personal portfolio website  Template adding

I would like to add my portfolio website to the  project !

@AbhishekRP2002 Link the pr here

Sure

any updates?

@AbhishekRP2002 Any updates?


Refine personal color guide section in user profiles for non-privilegized users

Add a counter for # of used slots & potentially hide the section altogether if none is used.

Implemented in 721538575dc590f8c0aac02fb8bcc58b87e903d8


fix flasky unittest for deformable psroi pooling

Description
This PR aims to fix the problem raised by issue #11713.
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes
The deformable ps roi pooling operator includes several corner cases which the function is not differentiable. Therefore during the unittest, we need to add some check to ensure the input values are within the smooth regions.
Comments
The issue and solution are discussed with @ankkhedia, @sandeep-krishnamurthy, @YuwenXiong and the fix is ran by @ankkhedia for about 2500 times on his local machine.
@ankkhedia could you help review it?

The changes looks good to me and have verified it locally for 2500 runs with random seeds.

@marcoabreu - Your concerns are addressed. This is ready to be merged.

@marcoabreu Your concerns are addressed. Could you please merge this PR?

Everyone, please check  #11713


feat(ISD-260): Add anonymize-user action

Add anonymize-user action by using the same idea of adding an admin user: extends the CLI to anonymize a user using the e-mail list separated by a comma as a parameter.
Fields affected:
User data:

['affiliation', 'email', 'secondary_emails', ] = ""
['favorite_users', 'favorite_categories', 'identities'] = empty
['old_api_keys',] = empty
['first_name', 'last_name', 'phone', 'address',] = hash

Event Registration data:

All text/textarea fields = hash
Email = hash +<EMAIL_ADDRESS>Phone = (+00) 0000000
First name = hash
Last name = hash
Email = hash

Reference:
https://github.com/bpedersen2/indico-cron-advanced-cleaner/

@gregory-schiano this is a good PR to take a look at

There you go, this is the prize for getting to over 100 interactions: 🎆

I'm fine with this PR, I'll approve once the last comments are managed (to avoid my approval being canceled by a new commit 😛 )


pocketbase: 0.23.9 -> 0.23.11

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-reviewd workflow started

Extra args: ``
Free space: true
Who asked: lucasew

TARGETS

x86_64-linux: true
x86_64-darwin: true
aarch64-darwin: true

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12449939755

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366833

x86_64-linux

:white_check_mark: 1 package built:

pocketbase

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366833

x86_64-darwin

:white_check_mark: 1 package built:

pocketbase

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366833

aarch64-darwin

:white_check_mark: 1 package built:

pocketbase


Using .parent()

Is it possible to use .parent() in x-ray?  If so, how?
Thanks.

Also interested in doing this. Related: https://github.com/matthewmueller/x-ray/issues/97

Should be doable by writing selectors.


⚠ Bofrost.at has degraded performance

In 9fe2d42, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1424 ms

Resolved: Bofrost.at performance has improved in 0b6a0d5 after 12 minutes.


Newsletter 11: Add section on Gamelisp

Here's Gamelisp! The crate is brand new, so I just provided the basic information as well as the language's reference guide and roadmap (on the Github Readme).
[GameLisp]
GameLisp (glisp) is a scripting language built for and in Rust and utilizes
syntax from the LISP family of programming langauges. It provides a fast and
efficient garbage collector that runs every frame instead of freezing a thread.
GameLisp also provides [a playground][glisp-playground] to experiment with
different projects. A reference guide is also [available][glisp-reference] as
well as [API documentation][glisp-docsrs] for integration into Rust.
The crate has had its [initial release][glisp-cratesio], a roadmap and ways
to contribute are available on GameLisp's [Github Respository][glisp-github].
[gamelisp] : https://gamelisp.rs/
[glisp-playground] : https://gamelisp.rs/playground/
[glisp-reference] : https://gamelisp.rs/reference/
[glisp-docsrs] : https://docs.rs/glsp/0.1.0/glsp/
[glisp-cratesio] : https://crates.io/crates/glsp/
[glisp-github] : https://github.com/fleabitdev/glsp/

Part of #172 ("Newsletter 11: Coordination/Tracking")

Added a logo

Merged, thanks for the PR!


Added example with tagging

Current coverage is 100.00%

Merging #7 into master will not affect coverage as of e3527b3

@@            master      #7   diff @@
======================================
  Files            2       2
  Stmts          100     100
  Branches         0       0
  Methods         20      20
======================================
  Hit            100     100
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of e3527b3

Powered by Codecov. Updated on successful CI builds.


(Feature request) Accept media from pipes

Example - program link | tplay

Good idea! I'll look into it when I have some time


Fix use-after-free in BPFtrace::get_arg_values

Fixes issues https://github.com/iovisor/bpftrace/issues/194 and https://github.com/iovisor/bpftrace/issues/209.
This finishes the work of @psanford's pull request https://github.com/iovisor/bpftrace/pull/217.
I've rebased onto master, and implemented the review feedback:

avoid copying strings
prefer make_unique
use standard naming convention for private members

We can now successfully use sym() as an argument to printf():
# terminal A
sudo bpftrace -e 'tracepoint:skb:kfree_skb {
  printf("symbol: %s\n", sym(args->location))
}'

# terminal B
curl -s 'http://dtrace.org'

# triggers the following output from terminal A:
Attaching 1 probe...
symbol: unix_stream_connect
symbol: unix_stream_connect
symbol: tcp_v4_rcv

Since people are hitting this... Any objections to merging this, and closing #217?

No objections here. Though I'd appreciate having a C++ veteran double-check that my std::move()s make sense.

I'll take a look tomorrow. I'm a big fan of C++ (for better or for worse...)

@danobi my suspicion is that I am doing an unnecessary std::move() here:
case Type::usym:
  arg_values.push_back(
    std::make_unique<PrintableString>(
      std::move(
        resolve_usym(
          *(uint64_t*)(arg_data+arg.offset),
          *(uint64_t*)(arg_data+arg.offset + 8)))));

because the output of resolve_usym() will be an rvalue already.
can you confirm that it's okay for me to remove this std::move, and that no string-copying will occur?

Regarding std::move, it is unnecessary here. The compiler will copy elide the construction. However, we cannot elide a move because std::make_unique still has to std::move the copy elided parameter into class storage. My suggestion is to take out the std::move because it is redundant.

@danobi thanks for reviewing. we now pass the vector by const ref, and I've switched to using reinterpret_cast.
I removed the std::move()s which surrounded strings returned via copy elision, but kept the std::move responsible for copying into class storage: PrintableString(std::string value) : value_(std::move(value)). Is this what you intended?

Yeah the std::move into class storage is correct.

Looks like runtime tests have been failing for a while. This should be good to merge.

Yuck, forgot to squash and merge. I'll remember next time.


Validate duplicate op check

Add a test for duplicate op merging.

Codecov Report

Merging #148 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0f5b5...ac005fc. Read the comment docs.


Unable to use the model due to Huggingface updated API

Hii.
You might be unable to use the Parrot model due to an error something like this
...is not a local folder and is not a valid model identifier listed on 'https://huggingface.co/models'...
To solve this I already created a pull request. Till then you can open the Parrot Library source code in your code editor and add these update these lines lines (13, 14 lines most probably)
self.tokenizer = AutoTokenizer.from_pretrained(model_tag, use_auth_token = <your auth token>)
self.model     = AutoModelForSeq2SeqLM.from_pretrained(model_tag, use_auth_token = <your auth token>)

I added a new demo notebook, and everything works fine. (check for the link in Readme)


feat: port Analysis.Normed.MulAction + #19053

Both the new file and the other fixes are done in the same PR, since according to the description of leanprover-community/mathlib#19053 "this should be very easy to forward-port".

<EMAIL_ADDRESS><EMAIL_ADDRESS>

bors merge


staging to main

deps: Lock deps
refactor: Read supabase connections out of env file
feat: Add tabs for checkin and desk service
refactor: Cleanup UI
chore(release): 1.1.0-rc.1 [skip ci]
refactor: Enable and managae realtime data
test: Configure test framework
chore: Configure eslint and prettier
docs: Add .env example
test: First tests
fix: User deletion from auth schema
ci: Setup deploy to dev env on supabase
test(supabase): Run supabase for the tests
ci: Rename semantic release config from js cjs
chore: Update codeowners
chore(release): 1.1.0-rc.2 [skip ci]
test: Scores and cron
feat: Add function to compute scores
fix: migration
chore(release): 1.1.0-rc.3 [skip ci]
fix: RLS for update

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bump pydantic from 2.5.3 to 2.6.0 (#7071)

Pull request opened by the merge tool on behalf of #7071

Merged in e7575d82343cc7c42bf97f9e8500de0cabcbd61e


a need help

can I use github as host for dapp(I am not familiar enough with uploading this to github) and do I need an domain for my minting dapp ? please explain.thank you very much

Here is an guide on how to deploy a react app (minting dapp in this case ) for free using vercel:

Make a github repo and upload all the files in the root/ main of the repo.
Make a vercel account and signup....goto dashboard.
Select repo and deploy it ...set framework to others.
Waiting till its deployed and tada! your dapp is deployed.

p.s. : this approach is free at the time of writing ...this gives you free hosting and a free domain but its not a premium domain...if you want to use your own domain....goto domains under the project and edit details for your own domain.


Split packages, update entry_points, add more tests, maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Changes:

[x] update minimum python to >=3.8
[x] fixes entry_points

the existing setuptools derived ones are probably broken on e.g. windows

[x] remove click from python-dotenv

my initial motivation to tidy this up for packages that use dotenv as a library

this has to carry the entry_point, as otherwise setuptools would re-make a broken one, but it won't work because of click

[x] move click dependency to python-dotenv-with-cli subpackage
[x] add pip check
[x] clean up some single use/verbose jinja vars, URLs and fields
[x] add all bot inspection hints for PRs (e.g. grayskull)
[x] add self as maintainer

@conda-forge-admin please rerender

@conda-forge/python-dotenv ready for review

@conda-forge/core: all members of @conda-forge/dotenv are:

unresponsive after a week
appear to no longer be engaged in conda-forge maintenance.

This PR adds additional thoroughness to the recipe, and a new maintainer.


enable automated testing on django 1.9 and python 3.5

We really need to sit down and fix the tests, but this is good. Thanks!


[$500] IOU - Padding below total increases for unread messages on mobile devices

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698067716752699
Action Performed:

Open the app and login with user A
Open the app with any other device and login with user B
From user B, send request money to user A
Open user B request money in user A and mark message as unread
Observe the padding between 'total' and 'New' line
Revisit the request money untill 'New' line disappears and now observe the padding between 'total' and line below total

Expected Result:
App should have equal padding below total irrespective of presence of 'New' line
Actual Result:
On mobile devices, padding between total and 'New' line is way more then padding when there is no 'New' line
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/93399543/c423cdbb-3ac1-4eb8-af75-498b0d6250c3

Android: mWeb Chrome

https://github.com/Expensify/App/assets/93399543/b03f0f45-7820-4581-8c90-c39e124f339f

iOS: Native

https://github.com/Expensify/App/assets/93399543/6f525245-97fc-464d-a2db-70024be49c34

iOS: mWeb Safari

https://github.com/Expensify/App/assets/93399543/803f2b51-f810-4412-8294-b9ac20b7a894

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0158fbfd6d89166dba
Upwork Job ID:<PHONE_NUMBER>665116160
Last Price Increase: 2023-10-25
Automatic offers:

situchan | Contributor | 27456744
dhanashree-sawant | Reporter | 27456747

Proposal
Please re-state the problem that we are trying to solve in this issue.
Padding below total increases for unread messages on mobile devices
What is the root cause of that problem?
The root cause of this problem is found in here:
https://github.com/Expensify/App/blob/cc3c51c1d58ce013e444b59bd06c87e4b750e550/src/CONST.ts#L126-L131
The size of the CONTAINER_MINHEIGHT for SMALL_SCREEN is the same as the size of CONTAINER_MINHEIGHT for WIDE_SCREEN.
What changes do you think we should make in order to solve the problem?
We need to decrease the size of the CONTAINER_MINHEIGHT from 280 to 200 for SMALL_SCREEN sizes. Which is the same as the CONTAINER_MINHEIGHT for reports which are not MONEY_REPORT
The changes should look like this:
  SMALL_SCREEN: {
                IMAGE_HEIGHT: 300,
                CONTAINER_MINHEIGHT: 200, // Update this line
                VIEW_HEIGHT: 220,
            },

What alternative solutions did you explore? (Optional)
NA

@tienifr, I’ve gone through your proposal, and it seems good overall. Regarding the second solution, my only concern is negative spacing. Generally, avoiding such styles is a good idea as they can lead to inconsistency in the future. What are your thoughts on fixing this issue by avoiding negative spacing?

@ArekChr - can you review the responses when you get a chance? Thanks!

@garrettmknight Hello, I am wrapping up some urgent matters today, and I will be OOO from tomorrow to Monday. Can we assign another C+ here so as not to block the task?

I can take over

Thank you @ArekChr for this update!
@situchan you are assigned now. Let's keep this one moving forward.

@tienifr does your solution also fix web as well?
https://github.com/Expensify/App/assets/108292595/150b26c7-e929-4b4b-8a32-c5a9096f12cc

Hey @situchan ,have you got the chance to check my proposal. I would love to get a feedback on it please.

@Nathan-Mulugeta your proposal doesn't make sense to me. The diff is not 80px

@Nathan-Mulugeta please share 4 screenshots on web/native before/after fix

Here you go @situchan:

Native - Before
![Native-before](https://github.com/Expensify/App/assets/111440031/9cca1efb-7ba5-4fc3-bfe2-a582ff9033a5)

Native - After
![Native-after](https://github.com/Expensify/App/assets/111440031/5dfbf52f-bf87-4c73-a2d6-fc87a1325b87)

Web - Before

Web - After

@situchan when you get a chance, can you share feedback here for the next steps? Thanks!

@Nathan-Mulugeta I meant desktop web

Wanna check the padding of unread indicator vs separator line

Ow I see @situchan , here you go then:

Desktop web - Before

Desktop web - After

The desktop web padding remains unchanged before and after the change.

Reassigning another 🐛  team member, I'm going OOO until Tuesday, November 14, and will take it back if it's still open by my return date.
@puneetlath  - Required action from the team:
Please keep an eye out that this one is moving forward and we find a proposal, thanks!

What I wanna confirm is that if positions of unread marker and separator should exactly match on every platform.

Upon further exploration, it became evident to me that the issue has extended beyond mobile devices and now affects the web interface as well. Consequently, I've updated my proposal to address this bug.
Proposal
Updated

I'm back and unassigning my buddy.
@situchan - can you review the updated proposal? Thanks!

I will provide update shortly. I think we need to get confirmation from design team about the expected behavior on https://github.com/Expensify/App/issues/30360#issuecomment-1809139211

@situchan do you have a thread in the Open Source slack room and we can add the link here? If no, I can start one.

I don't have thread yet. You can start new one. Thanks

Reassigning another team member, I'm going OOO until Monday, November 27, and will take it back if it's still open by my return date.
@sonialiap  - Required action from the team:
I didn't get a chance to start the discussion in the Open Source room and get the design to chime in. Can you please start one and keep this one moving forward? Thanks!

posted a comment for design on the original bug report
https://expensify.slack.com/archives/C049HHMV9SM/p1700653488344659?thread_ts=1698067716.752699&cid=C049HHMV9SM

@situchan
Shawn responded with

Yeah, I thought the idea was that the unread marker would replace the exact position of the current horizontal rule that separates the total and the first message

I'm going to remove my buddy and take this one back.
@situchan - based on the feedback received last week, can we continue forward here? If not, can you share why and we can find the answers? Thanks!

@situchan any update here?

I will provide feedback on proposals by tomorrow

@situchan will any of the proposals work?

@situchan any news?

@situchan - any update here?

the unread marker would replace the exact position of the current horizontal rule that separates the total and the first message

Here's feedback from design team.
Based on this, I don't think anyone proposed right solution to meet the expected behavior on all platforms.

Ok, thanks, we need more proposals here then or someone to update their proposal.

@situchan can you review the feedback that @tienifr shared here? Thanks!

@situchan - any update for @tienifr? Thanks!

@situchan can you please review @tienifr's latest reply? Thanks!

No update, still waiting on feedback here.

I will provide update by tomorrow

Thank you!

Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during this period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

@situchan any update here regarding the feedback for @tienifr?

sorry for delay here. I am evaluating again

@situchan is this still open for proposals?

@situchan is this still open for proposals?

yes, if we have another approach than previous proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
Padding below total change when thread is on unred state.
What is the root cause of that problem?
This issue is related to the padding adjustment when threads transition from an unread to a read state. This issue is observed in three distinct views:

MoneyReportView
TaskView
MoneyRequestView

MoneyReportView
https://github.com/Expensify/App/assets/12425932/ca7e84c2-35d9-46bc-9776-e9187cec3a45

TaskView
https://github.com/Expensify/App/assets/12425932/ec20ba57-345e-48a1-9750-be143313679b

MoneyRequestView
https://github.com/Expensify/App/assets/12425932/be9a6411-8c0d-4c09-8d04-1d9f114fe081

Each of these views exhibit a padding inconsistency when displaying thread status changes.
These views are integrated within the ReportActionItem component, using the property shouldShowHorizontalRule={!props.shouldHideThreadDividerLine}.
https://github.com/Expensify/App/blob/b9c2514294d64e969f1eb07a4b75989340ffd06c/src/pages/home/report/ReportActionItem.js#L615-L618
The core of this issue lies in the styling discrepancy between the "New" (green) and (grey) thread divider lines. The shouldHideThreadDividerLine property toggles the visibility of the grey line based on the presence of the green "New" indicator.
shouldHideThreadDividerLine check if the 1st report under the grey line has the green line of the "New" unread.
If there's a green line, then shouldHideThreadDividerLine is true and the the grey line is hidden.
https://github.com/Expensify/App/blob/b9c2514294d64e969f1eb07a4b75989340ffd06c/src/pages/home/report/ReportActionsList.js#L337-L340
The problem arises due to the different styling attributes of these lines, resulting in a noticeable shift in padding when the green line replaces the grey one.
What changes do you think we should make in order to solve the problem?
We need to change the style of the green line "New" only for the 1st report under the green line.
1- On ReportActionItem when the green line component is called here, we need to pass a new props shouldHideThreadDividerLine
<UnreadActionIndicator
  reportActionID={props.action.reportActionID}
  shouldHideThreadDividerLine={props.shouldHideThreadDividerLine}
/>

We will inform the component UnreadActionIndicator that represent the green line in the UI, if it's associated with the first report and if it's replacing the green line. Now the component of the green line (New) will be aware if it will replace the grey line (seperator)
2- Update UnreadActionIndicator component here to have a new style when it's replacing the grey line.
<View
style={[shouldHideThreadDividerLine ? styles.unreadIndicatorContainerFirst : styles.unreadIndicatorContainer, styles.userSelectNone, styles.pointerEventsNone]}
>

if shouldHideThreadDividerLine, then the grey line is hidden and if it's for the 1st report under the grey line, then we will display the green line with the new style I named here unreadIndicatorContainerFirst
We can notice that the green line had an absolute position, so it will not take space, we have to change this to relative position with margin adjustment to have the same space in the UI as the grey line.
unreadIndicatorContainerFirst: {
  position:  'relative',
  top:  0,
  left:  0,
  marginBottom:  8,
  // other part of the style
},

When the grey line is removed it happens with an animation, we can adjust this in PR process if needed.

the unread marker would replace the exact position of the current horizontal rule that separates the total and the first message

As the design team mentioned, this solution will make the grenn line (New) replace the exact position of the grey line (separator).
POC videos:
I am using a virtual rule to make it easu to noyice tha Total is always in same place.

Mobile
https://github.com/Expensify/App/assets/12425932/3f3026f6-5c0e-4f05-8d7d-d8e49ead31e3

Web
https://github.com/Expensify/App/assets/12425932/25783b18-7d65-4b38-bc8e-37dd8340479f

@situchan any feedback for the proposals here? Thanks!

@dragnoir thanks for the proposal. Do you mind sharing test branch for testing purpose?

@situchan this is the one I used for the video DEMO in my proposal: https://github.com/dragnoir/App/tree/30360-mos-test
Let me know if you need any additional editing.

Checking

@dragnoir I don't think your solution works on both web and native based on my testing

@situchan I think native issues can be handled throw PR. What part do you think is not working on native?
I think the main idea here is to catch the reason behinf the issue, describe a solution. Making the solution perfect and tested, can be done throw PR.
I can work more on the solution if you want.

@situchan bump ^

@situchan any update here? Thanks!

@situchan I am updating my code to effect only windows OS, I will post new link in few hours with screenshots from different OS.

@dragnoir I am confused. This is not Windows only issue

@situchan yah sorry, mistake, I just updates my comment. I am sending new updates in few hours with demo from mobile.

Waiting for he new examples from @dragnoir

@situchan I tested the code on native phone and on the Emulator from xcode and it's working, below 2 videos POC
https://github.com/Expensify/App/assets/12425932/1470330e-4d69-4a91-939b-7e61300c27d8
https://github.com/Expensify/App/assets/12425932/a0ff4d39-87b6-45a1-abf1-9945cbc6f3c9

@situchan let me know if you need more details.

Thanks for demo. I will provide feedback asap

No update yet, waiting for feedback.

eta Monday

@situchan friendly bump ^

updating by eod

@dragnoir I don't see any improvement in your solution. As you see, indicator still flickers
https://github.com/Expensify/App/assets/108292595/d3d346a1-8a1c-46a0-8bcb-cd9ab1193cd8

@situchan the issue is not about flickers. The main issue is that the change make an extra padding. My solution solve this.
The flickers effect is due to the animation. Please check QA flow again.

@dragnoir do you think the video above is acceptable? This looks even worse than production behavior

@situchan

Expected Result:
App should have equal padding below total irrespective of presence of 'New' line

my solution is a fix for this. I can solve the flickers effect on PR.

@dragnoir unread indicator should not move
https://github.com/Expensify/App/assets/108292595/0f6c5063-ae1a-496e-8b4d-7087a03aa170

@tienifr can you please update your proposal? No marginBottom logic anymore in ReportActionItem

@situchan Please check the video below, I fixed the flikkering effect (local dev).
https://github.com/Expensify/App/assets/12425932/df44df46-6111-4e51-a711-f650f39d7fd2
The idea is to display the green line is place of the grey on the same area. This solve the issue because boath lines green and grey will be displayed on the same x, y.
Please let me know if you need to see more adjustments.

@dragnoir thanks. That matches the expected behavior (Option 1) we recently discussed:
Option 1. 8px space between separator and first report action
pros: no design change when no unread indicator (current version)
cons: unread indicator (8px space) has different spacing than other report actions (no space)
~Option 2. no space between separator and first report action
pros: unread indicator positions are consistent between all report actions (current version)
cons: design change when no unread indicator~
Everyone, please update proposals accordingly

@situchan I updated my a new alternative solution
I can't access to the link you mentioned

we recently discussed:

Can you please elaborate more on what the Option 1 means, de we need to keep spaces??  Thank you

So your video here looks correct

No update

still waiting for updated proposals based on latest discussion
Meanwhile, I will evaluate @dragnoir's updated solution

Thanks for the update!

Seems like no one (except @dragnoir) is following my request.
@dragnoir would you mind sharing your test branch?

@situchan I will share a test branch by the end of the day.

Thanks!

I have some conflicts to solve and I will share the bransh ASAP.

Not overdue

@situchan sorry for the delay, here the main changes https://github.com/dragnoir/App/tree/30360-fix

@situchan I created a video DEMO for the last updates
https://github.com/Expensify/App/assets/12425932/2604181b-0d6a-402a-8b1e-083934de635c

@situchan, keep us posted if this demo is helpful to keep moving forward here. Thanks!

@dragnoir thanks. I am still checking any possible regressions. I will provide feedback on Monday

@dragnoir I checked your branch. Still not considered all cases. And that solution doesn't seem ideal to me.
It should be responsive to all types of reports - task view, money report view, money request view, normal thread.

@situchan I added support foir all types of reports - task view, money report view, money request view, normal thread. You can check the branch again.

Here's bug to fix in normal thread:

How can I reproduce this bug? I don't have it on my side.

@situchan pls!

that solution doesn't seem ideal to me.

Still same feedback ^

@situchan pls explain why!!! You were asking for DEMOs, updates and branches and when it's perfectly working, you just don't like it!!!

@dragnoir how about trying to add SpacerView in ReportActionItem instead of all other components case by case?

So we can pick up better approach

@situchan thanks for your feedback, but sorry I will not do more updates or branches for demo. The idea is clear، I can enhance in PR if you like the main concept.

@situchan you have every thing to decide. Thanks for your time

Heads up, I will be offline until Tuesday, March 5, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks!

As I haven't heard from @dragnoir for a week, I think this can be open for new proposals.

@situchan, could you please clarify your request?
You inquired about the following:

how about trying to add SpacerView in ReportActionItem instead of all other components case by case?

To which I responded affirmatively, acknowledging that this approach aligns with the workflow I had proposed. Initially, I was integrating the solution into each component individually. However, I concur that centralizing the implementation within ReportActionItem is feasible and I can undertake this adjustment during the PR (Pull Request) review process.

To which I responded affirmatively, acknowledging that this approach aligns with the workflow I had proposed. Initially, I was integrating the solution into each component individually. However, I concur that centralizing the implementation within ReportActionItem is feasible and I can undertake this adjustment during the PR (Pull Request) review process.

https://github.com/Expensify/App/compare/main...dragnoir:App:30360-fix
@dragnoir is this your latest branch? I am not seeing this

We are still open for proposals here.

We are still open for proposals here.

Still open for proposals.

@situchan
Alternative solution updates as per your recommendation.

@dragnoir how about trying to add SpacerView in ReportActionItem instead of all other components case by case?

@situchan can you please review the new alternative here? Thanks!

@dragnoir's proposal looks good to me. I prefer alternative solution.
🎀 👀 🎀 C+ reviewed

The PR is in the works

@dragnoir - is there a PR? I checked the status and don't see one linked yet. Thanks!

Thanks! Regressions are always a priority.

No update here

The PR is in a draft-- making progress

Update: The PR is waiting for @Beamanator to review it.

Update: The PR is moving forward

Weekly Update: The PR is going through some polish updates to help the design.

FYI I'm assigning @DylanDylann as C+ to review - but I haven't unassigned @situchan since they also did a review a bit ago.

Weekly Update: Looks like the PR is going through a final review.

@DylanDylann - can we get an update if this Deploy Blocker is accurate or an error? Thanks!

@alexpensify Yeah, It is a regression

Thank you for this context! It looks like the automation failed here and payment is due for this one. I'll work on that process.

Ok, flagging this notice: https://github.com/Expensify/App/issues/30360#issuecomment-2071630087
@dragnoir, @DylanDylann, and @situchan - can you please apply to the job here: https://www.upwork.com/jobs/~0104d969f5990f36bd
After, I can carry on with the payment process. Thanks!

Please disregard the last comment.
Ok, flagging this notice: https://github.com/Expensify/App/issues/30360#issuecomment-2071630087
@dragnoir please apply here: https://www.upwork.com/jobs/~0104d969f5990f36bd
Everyone else will be paid via this link: https://www.upwork.com/jobs/~0158fbfd6d89166dba
After, I can carry on with the payment process. Thanks!

Payouts due: 2024-05-13 - delayed due to automation failure

[ ] Reported by: $50 @dhanashree-sawant
[ ] Contributor: $500 @dragnoir
[ ] Contributor+: $250 for the partial review @situchan
[ ] Contributor+: $500 @DylanDylann

Upwork job is here. The PR was submitted before the payment changes in April. Also, this issue was created in 2023, so that's why there is a reporter bonus.

@dragnoir - I sent you an offer in Upwork. Please accept, and I can complete the payment process.

All set, everyone has been paid via Upwork!
Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.
If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!


Tayo05_exercse

This was very close, but had some small issues around the edges. The notebook you submitted seemed like it was from exercise 4, so I ignored it. But all the code for exercise 5 was very neatly laid out in functions in your module. Bravo! Rather than calling all the functions at the end of the module, I made a new notebook, imported your module, and then called your functions there. And they worked great! Good job with the graphing.
Check out the new notebook I made, taiwo_exercise05.ipynb, and what I commented out in the module.


Error after upgrading to React 16.1.1 and Popover 0.5.4

I've just tried to upgrade my application and all related dependencies (modal, popover, etc) to React 16. The app mostly works, but all components containing Popovers now fail to render. JavaScript console says:
Failed prop type: Invalid prop `body` supplied to `Popover`, expected a ReactNode.

Below that, the following message appears:
Uncaught Error: Target container is not a DOM element.
    at invariant (invariant.js:42)
    at Object.createPortal (react-dom.development.js:17116)
    at Popover.render (index.js:527)
    at finishClassComponent (react-dom.development.js:10249)
    at updateClassComponent (react-dom.development.js:10226)
    at beginWork (react-dom.development.js:10605)
    at performUnitOfWork (react-dom.development.js:12573)
    at workLoop (react-dom.development.js:12682)
    at HTMLUnknownElement.callCallback (react-dom.development.js:1299)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:1338)

On the face of it, Popover's API is the same as it was in 0.4.6. Or am I missing something?

The Popover starts rendering after adding
appendTarget={document.body}

to Popover props. Apparently, the default value is not good enough anymore.
However, now I'm hitting the infamous #53 bug.

Did not fixed yet actually


Best practices for suppressing alerts for more than 5 servers

Hi Team,
I realize that Alert Rules are in preview, and have been for some time. We have 400+ Azure VMs & Arc servers reporting to 1 Log Analytics Workspace and log alerts have been configured. If we have a maintenance window where a group of 50 servers will be patched by Azure Update Management, what are some ways we can suppress alerts configured for these servers? Currently the filter called Alert context (payload) is limited to a max of 5 values, so we can paste a list of 50 servers here.
To be clear our (log) alerts are configured to look for any of the 400+ servers in the workspace that are over a specific percent of CPU or RAM. Configuring alerts with this approach allows us to easily scale the alerting up or down when servers are added to or removed from the workspace.
Also, is it on the road map to allow suppression based on tags? That would be awesome, and it seems to be something that has been suggested by others like this Azure MVP - Stanislav Zhelyazkov.
https://cloudadministrator.net/2019/11/25/azure-monitor-alert-series-part-11/comment-page-1/?unapproved=70433&moderation-hash=bfa27409b4c3efd3d0e2919845a1e207#comment-70433
Thanks!
Josh

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 529411e8-efc3-73e3-14f4-d002c179a18e
Version Independent ID: 9ee182f1-223a-b1e1-eb8d-c7428ec3c1a1
Content: Action rules for Azure Monitor alerts - Azure Monitor
Content Source: articles/azure-monitor/alerts/alerts-action-rules.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @rboucher
Microsoft Alias: robb

@jwashbur Thanks for your comment. We will review the issue and get back to you shortly.

#reassign: @harelbr.
@harelbr - can you answer this customer question or  direct us to the correct resource?
Thanks,
Abby

The following users don't have valid GitHub IDs, or are not collaborators on this repo: harelbr.

#reassign: @ofirmanor
Assigning to Ofir to help address this.

Hi @jwashbur

alert processing rules are now GA
Currently the limit of values per filter are five. If you want to suppress 50 specific VMs, you will need to create 10 rules. While annoying, you can likely script it using PowerShell / CLI.
Removing this limit (five values per filter) is high on our backlog for this year, though I don't have a specific commitment yet.
Filter by tags - this is also high on our list, but I cannot commit to a specific date.

Hi @jwashbur,
Thank you for your dedication to our documentation. I see that @ofirmanor has answered your questions.We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again.
#please-close


include all .pyi stubs from all packages

Many thanks - https://github.com/erikrose/more-itertools/releases/tag/v8.0.2 .


Fix ToC links

Fixed to ToC links that were not working.

Linux test PASSed.

Linux test PASSed.

Windows test PASSed.

Windows test PASSed.


Cube not placed on the table - incorrect mapping of the space

Hi I'm new to hololens and I'm having some trouble.
I'm following the tutorial : Tutorial: Share spatial anchors across sessions and devices
Everything works fine, when  I run my app and the scene LocalSharedDemo. I create the anchors + I can see that is has been created on my swagger application. But when I try to locate it all the commands seem to work but I can see it anywhere.
What can be the issue ? I looks like the space hasn't been correctly mapped, how do I correct that ? I did not have to map it when following the instructions which seems weird...

@mikkeline-elleby
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!

@pamistel
Could you please review add comments on this, update as appropriate.


Limit on # of processed frames

I tried uploading a multiple minute video, however I ended up with only a 40 second video back. Is this being capped somewhere? I traced it to this line from PHALP.py, but not sure where the end frame is being declared.
list_of_frames = list_of_frames if self.cfg.phalp.start_frame==-1 else list_of_frames[self.cfg.phalp.start_frame:self.cfg.phalp.end_frame]
Thanks

You can pass this as an argument to track.py. For example:
python track.py video.source=my_video.mp4 video.end_frame=3000
Currently the end_frame value is set to 1300.


EntityManager#find() throws IllegalArgumentException for wrong arguments

Shouldn't the test use jpa compliance instead? Maybe we should update the tck-runner with the new compliance settings.

JPA bootstrapping enables compliance by default.  @Jpa uses JPA boostrapping (its the main difference ultimately with @SessionFactory)

My bad it seems the hibernate.jpa.compliance.load_by_id is not set to true when using @Jpa this is causing the issue, so @beikov we have to set this value for the tck-runner

@Jpa should really just set the top-level value.


[<IP_ADDRESS>] SSH protocol error. Possible causes include using the wrong key file or username.

Flintrock version: 11.0
Python version: 3.5.5 / anaconda
OS: Amazon Linux 2 AMI (HVM), SSD Volume Type - ami-0b5a47f8865280111
region of the instance is Singapore

Config.yaml
services:
  spark:
      version: 2.3.3
    # git-commit: latest  # if not 'latest', provide a full commit SHA; e.g. d6dc12ef0146ae409834c78737c116050961f350
    # git-repository:  # optional; defaults to https://github.com/apache/spark
    # optional; defaults to download from from the official Spark S3 bucket
    #   - must contain a {v} template corresponding to the version
    #   - Spark must be pre-built
    #   - must be a tar.gz file
    # download-source: "https://www.example.com/files/spark/{v}/spark-{v}.tar.gz"
      download-source: "https://www.apache.org/dyn/closer.lua?action=download&filename=spark/spark-{v}/spark-{v}-bin-hadoop2.7.tgz"
    # executor-instances: 1
  hdfs:
      version: 2.8.5
    # optional; defaults to download from a dynamically selected Apache mirror
    #   - must contain a {v} template corresponding to the version
    #   - must be a .tar.gz file
    # download-source: "https://www.example.com/files/hadoop/{v}/hadoop-{v}.tar.gz"
    # download-source: "http://www-us.apache.org/dist/hadoop/common/hadoop-{v}/hadoop-{v}.tar.gz"
      download-source: "https://www.apache.org/dyn/closer.lua?action=download&filename=hadoop/common/hadoop-{v}/hadoop-{v}.tar.gz"
provider: ec2

providers:
  ec2:
    key-name: Key-flint
    identity-file: /home/ec2-user/certs/Key-flint.pem
    instance-type: t2.micro
    region: ap-southeast-1
    # availability-zone: <name>
    ami: ami-0b5a47f8865280111  # Amazon Linux 2, us-east-1
    user: ec2-user
    # ami: ami-61bbf104  # CentOS 7, us-east-1
    # user: centos
    # spot-price: <price>
    # vpc-id: <id>
    # subnet-id: <id>
    # placement-group: <name>
    # security-groups:
    #   - group-name1
    #   - group-name2
    # instance-profile-name:
    # tags:
    #   - key1,value1
    #   - key2, value2  # leading/trailing spaces are trimmed
    #   - key3,  # value will be empty
    # min-root-ebs-size-gb: <size-gb>
    tenancy: default  # default | dedicated
    ebs-optimized: no  # yes | no
    instance-initiated-shutdown-behavior: terminate  # terminate | stop
    # user-data: /path/to/userdata/script

launch:
  num-slaves: 1
  # install-hdfs: True
  install-spark: True

debug: false

hello dear @nchammas
Thanks for your efforts to solve the issues about Flintrock.
I have received this issue, and I appreciate it if you help me to solve it.
Many thanks.

Thanks for sharing your Flintrock config.

Can you also share the full launch output of Flintrock itself?
Have you ever successfully launched and SSHed into an EC2 instance (separate from Flintrock)? What identity key and username did you use during that successful attempt?

Thanks for answering :)
(Can you also share the full launch output of Flintrock itself? )-- > This is the Photo of the output while launching. Even it builds the Instances for me, but after a while, this error appears.

(Have you ever successfully launched and SSHed into an EC2 instance (separate from Flintrock)? What identity key and username did you use during that successful attempt?) -- > Not on the Amazon Linux 2, but the centos yes. The process is quite different, though, too many steps :(. The username was Centos. For a passwordless connection, I create a key in .ssh for both, and it worked.

Is that the same, I should connect to instances build by flintrock and create that ssh connection?

I recommend that you first confirm you are able to launch and connect to an instance using the same identity key and username, but outside of Flintrock.
So if you are using Key-flint.pem, ami-0b5a47f8865280111, and ec2-user, try first to launch and connect to an instance with these settings using the AWS CLI or the AWS Web Console, without Flintrock involved at all.
Once you have a working combination, update your Flintrock settings accordingly and try using Flintrock again. Let me know if you still have problems at that point.

Thanks a ton, dear @nchammas
For sure, I will take your advice.
May I ask why you are concerned about launching the instances without Flintrock involved? Did I apply the key mistakenly? Or its a part of the steps should have been done beforehand?

The SSH protocol error you are seeing is typically caused by some problem with the AMI, identity file, or username you are using. So I want to remove Flintrock from the equation and first confirm that you can use the same combination of AMI, identity file, and username without Flintrock involved, before trying again with Flintrock.
This is just a troubleshooting technique to help us understand what is going wrong. Does that make sense?

Thanks, It does make sense.
However, I have seen very few decent tutorials in that regard. I hope I can make it accurate to share a detailed oriented document helpful for novices. :)

There are a few tutorials for using Flintrock linked to from the README.
If you mean a tutorial for launching a barebones EC2 instance, I'm sure there are several of those readily available online, but I don't have any specific recommendations.

I meant using Flintrock :)
Thank you.

Hello
dear @nchammas
You were right about the key problem.
I've applied WinSCP software and transfer the key.pem directly to AWS instance ( /home/ec2-user/.ssh/key.pem).
Then it worked. :)
Thanks a million.

Seems like cannot connect from Southeast

However, through ami-0b8d0d6ac70e5750c, it works and no such error.

Are you always connecting to the same VPC and subnet? These issues all seem like connectivity problems that are not specific to Flintrock, but rather are related somehow to your VPC setup.
If you figure out how to launch and connect to an instance outside of Flintrock, then that same configuration should work with Flintrock.
Are you all set here, or would you like additional assistance debugging SSH connectivity issues?

Dear @nchammas
First of all, many thanks for your reply.
Secondly, I really appreciate it if you help me to solve the SSH connectivity issues.
Now I have two instances
1- the first one is in N. Virginia with the ami-0b8d0d6ac70e5750c.  For this one, I could manage to use flintrock and launch a master and slave. No problem :)
2- the second one is in Singapore with ami-0b5a47f8865280111. For the second one, I received SSH connectivity while launching flintrock.  :(
I really don't know what is VPC.

I have received another error when in the config.yaml shown in the figure below, install-hdfs and install-spark are true

The error that I received is as follows while HDFS and spark are configuring:

If you are using different AMIs then the required username or SSH key may be different. My recommendation is the same as before: First try to launch an instance with ami-0b5a47f8865280111 in the Singapore region using the Amazon Web Console and connect that way. After you figure out how to get that working, then try again in Flintrock with the same settings.

Hello
I have launched an instance with ami-0b5a47f8865280111.
It gives me this error

The screenshot you are showing me is from Flintrock, not from the Web Console. The Web Console looks like this:

The URL is usually something like: https://console.aws.amazon.com/ec2/v2/home
I suggest trying to launch an instance using the web console and connecting to it with plain SSH before involving Flintrock. This will help you understand where the SSH issue is coming from without needing to worry about Flintrock.

Here you are.

Thanks. I will take your advice in that regard.

This is my VPC setup

It seems like your VPC doesn't have an Internet Gateway configured. In other words, it's a private VPC that doesn't have any public IP addresses. (I'm guessing this from the 172. IP addresses shown in your screenshot.)
Can you make sure your VPC has an Internet Gateway attached and that instances launched within it are configured to get public IP addresses?

Hey @fazish, I'm closing this due to its age. If you're still struggling with your setup and think it's related to Flintrock, feel free to reopen this issue!


Selection UX (Insert Below/Right/Moving with Undo/Redo)

Selection UX (Insert Below/Right/Moving with Undo/Redo)
Issue being fixed:
N/A
Changes proposed:

Insert below/right selects the row/column that was inserted (undo selects row/column that the insert was made from)
Moving rows/columns selects the destination (undo selects the original)

Nope it doesn't work, I'll fix that right now


Fast-SAM

Hello again !
Not really an issue with the current version, but more a curiosity about the future improvements :
Have you considered using the Fast-SAM model to decrease the encoding time for large geospatial images ? According to the developer's team, it seems to have comparable performance at 50× higher run-time speed compared to the original SAM model.
Here is the Github repo : https://github.com/opengeos/FastSAM
Thanks

Also I think this SAMHQ model would be a great addition to the project
repo: https://github.com/SysCV/sam-hq

Hi @4del-Yousefi @cycle4 . Thank you for your suggestions. We have actually been paying close attention to these new SAM-based projects for a while: FastSAM, HQ-SAM, MobileSAM. But considering these projects are trained on much smaller datasets compared to the original SAM, their generalization ability may not be as strong as SAM's. Also, since we are not full-time developers and have limited time for development, we have not tried these models yet. However, they are in our plans. We are especially interested in the HQ-SAM project. It seems to address some of SAM's shortcomings to some extent, and has also integrated the work from MobileSAM by releasing Light HQ-SAM that can encode images faster. So we have added it to our Future Works.


JsCreateTypedArray has wrong SAL annotation

JsCreateTypedArray has the following signature in ChakraCore.h:
    CHAKRA_API
        JsCreateTypedArray(
            _In_ JsTypedArrayType arrayType,
            _In_ JsValueRef baseArray,
            _In_ unsigned int byteOffset,
            _In_ unsigned int elementLength,
            _Out_ JsValueRef *result);

However, according to the documentation comment just above that, baseArray can legally be JS_INVALID_REFERENCE (equivalent to NULL), in which case it creates the backing store on the fly:
The base array of the new array. Use <c>JS_INVALID_REFERENCE</c> if no base array.

Therefore the annotation for baseArray should be _In_opt_, not _In_.  There are probably more like this, but this happened to be one I noticed.

Good catch! This is a mistake.
Also similar to https://github.com/Microsoft/ChakraCore/pull/5575, b/c this is also a Chakra API in Windows SDK and fixing it in ChakraCore will trigger a change there as well, we will have to go through an internal simple review process with Windows folks before we merge a fix in.

On a related note, the analyzer gives me a warning for this line in my codebase:
https://github.com/fatcerberus/minisphere/blob/master/src/shared/jsal.c#L206
which I need to do to set up dynamic import to work in script (non-module) code.  Is the SAL annotation wrong there too or is this actually not kosher? (and if it isn’t, how do I set up dynamic import from script before the first module is loaded)

@fatcerberus picking up on that point - From reading the implementations - JsInitializeModuleRecord with a null specifier is safe BUT JsParseModuleSource on a moduleRecord that was created with a null specifier may not be safe - I think it may hit a FailFast. In general the way of setting callbacks for module loading feels janky, I've opened #5875 to suggest an improvement.

Thanks for investigating @rhuanjl, it’s appreciated :)


Stormblessed: Watch customerfeedbacksurvey.info

Stormblessed requests the watch of the watch_keyword customerfeedbacksurvey\.info. See the MS search here and the Stack Exchange search here.

customerfeedbacksurvey\.info has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Could not determine NODE_ADDRESS

Helo.
Cant find why this  doesnt work.
docker service create
--name mysql-seed
--replicas 1
--network web
--env MYSQL_ROOT_PASSWORD=xxxx
--env DISCOVERY_SERVICE=<IP_ADDRESS>:2379
--env XTRABACKUP_PASSWORD=xxxx
--env CLUSTER_NAME=bank
myregistry/abc/bank:mysql seed
Could not determine NODE_ADDRESS: <IP_ADDRESS>
<IP_ADDRESS>
The difference between your and mine example is that I use network.

I think this is the reason
root@3fc57bb509df:/# ip addr | awk '/inet/ && /eth0/{sub(//.*$/,"",$2); print $2}'
<IP_ADDRESS>
<IP_ADDRESS>
where <IP_ADDRESS> is VIP and <IP_ADDRESS> is node ip

What is the output of just "ip addr"?

root@4ec1c2c7abb2:/# ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet <IP_ADDRESS>/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
193: eth0@if194: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue state UP group default
link/ether 02:42:0a:00:00:02 brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/24 scope global eth0
valid_lft forever preferred_lft forever
inet <IP_ADDRESS>/32 scope global eth0
valid_lft forever preferred_lft forever
inet6 fe80::42:aff:fe00:2/64 scope link
valid_lft forever preferred_lft forever
195: eth1@if196: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
link/ether 02:42:ac:12:00:05 brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/16 scope global eth1
valid_lft forever preferred_lft forever
inet6 fe80::42:acff:fe12:5/64 scope link
valid_lft forever preferred_lft forever

I quit using Docker Swarm Mode for a while now so not sure if something has changed but I don't remember there being a separate IP reported by "ip addr" for the VIP and the node IP..
Somehow the script needs to be able to determine which IP to consider to be itself and currently there are two IPs output by the awk script which is the problem.. head or tail could be used to "fix" this but I don't even know which one is proper.. Is "web" just a regular "overlay" network or is there something special/different about it?

web is
docker network create --driver overlay web
the same is for mariadb container
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet <IP_ADDRESS>/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
5935: eth0@if5936: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue state UP group default
link/ether 02:42:0a:00:00:0d brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/24 scope global eth0
valid_lft forever preferred_lft forever
inet <IP_ADDRESS>/32 scope global eth0
valid_lft forever preferred_lft forever
inet6 fe80::42:aff:fe00:d/64 scope link
valid_lft forever preferred_lft forever
5937: eth1@if5938: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
link/ether 02:42:ac:12:00:05 brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/16 scope global eth1
valid_lft forever preferred_lft forever
inet6 fe80::42:acff:fe12:5/64 scope link
valid_lft forever preferred_lft forever
I think is normal behavior

Any ideas about how to reliably distinguish between the VIP and the node IP then? I don't currently have a swarm setup to test with.

Good question. For fast workaround I took first IP. In every services first IP was node IP.
Problem is also with ethX
Look at following example. This is another service called nginx
docker service create
--name nginx
--replicas 1
--publish 80:80
--publish 443:443
--network web
registry.edge.do/tvn/xbank:nginx tasks.web
and look that this time overlay web network address is in eth2
root@4b30b036d3b0:/# ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet <IP_ADDRESS>/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
1966: eth0@if1967: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue state UP group default
link/ether 02:42:0a:ff:00:0d brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/16 scope global eth0
valid_lft forever preferred_lft forever
inet <IP_ADDRESS>/32 scope global eth0
valid_lft forever preferred_lft forever
inet6 fe80::42:aff:feff:d/64 scope link
valid_lft forever preferred_lft forever
1968: eth1@if1969: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
link/ether 02:42:ac:12:00:08 brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/16 scope global eth1
valid_lft forever preferred_lft forever
inet6 fe80::42:acff:fe12:8/64 scope link
valid_lft forever preferred_lft forever
1970: eth2@if1971: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue state UP group default
link/ether 02:42:0a:00:00:1e brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/24 scope global eth2
valid_lft forever preferred_lft forever
inet <IP_ADDRESS>/32 scope global eth2
valid_lft forever preferred_lft forever
inet6 fe80::42:aff:fe00:1e/64 scope link
to be honest I dont know why ingress network is visible here in eth0
I've created all services the same way with web network
I have to ask question on docker forums

You can specify a 'grep -e' pattern like so:
NODE_ADDRESS=^10.0.0.*
Which might help with there being multiple interfaces, but I don't have a solid solution for there being two IPs per interface.. Anything in /etc/hosts that might be helpful?

NODE_ADDRESS=^10.0.0.* is good workaround unless you dont specify custom subnet fe
docker network create -d overlay --subnet=<IP_ADDRESS>/16 web
root@57a2b6d33077:/# cat /etc/hosts
<IP_ADDRESS>       localhost
::1     localhost ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
<IP_ADDRESS>        57a2b6d33077
<IP_ADDRESS>      57a2b6d33077
root@4b30b036d3b0:/# cat /etc/hosts
<IP_ADDRESS>       localhost
::1     localhost ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
<IP_ADDRESS>     4b30b036d3b0
<IP_ADDRESS>      4b30b036d3b0
<IP_ADDRESS>       4b30b036d3b0

Fixed by PR #8