Fix stacked table on mobile for screen readers (A11y fix)

Set the mobile table element to block display.
This CSS change allows screen readers to access the mobile table content, which has already been changed to a block display.

The best solution to this would make tables appear to screen readers the same in all views, regardless of screen width. The regular headings could be displayed to screen readers while tablesaw-cell-label is hidden.

It's worth noting that this may strip the semantic accessibility tree of the table in in older browsers 😢 (source) This fix does however work great on my iPhone and all modern browsers. Unfortunately I cannot find a list of browsers when this was changed.


Be more precise with chown to avoid issues in kubernetes if non-root

I'm having a problem deploying this image into Kubernetes if I'm not using root permissions as the default volume mount (/db) is root owned.

Thanks!


stringify Date object to iso string?

Trying to
const stringify = require('fast-stable-stringify')
stringify(new Date())
// got "{}"
// expect "2017-09-13T16:24:13.631Z"

Just found that
Unlike substack's, it does:
not check for .toJSON() methods on objects

Any way to enable this?

I see the toJSON call is part of the spec. I admit I did not check this back when I created the lib. I just never had to use it. But I acknowledge that it would be better when the lib would adhere to the spec.
I am working on a rewrite right now, and I will include the toJSON case among the tests. My intention was to be done with the rewrite before next monday.
I will post here if there is any progress.

Should work as desired now.
Want to confirm?


Ubuntu 20.04 apt-get upgrade fails on msodbcsql17

Description
The command
Run sudo apt-get update -y
2  sudo apt-get update -y
3  sudo apt-get upgrade -y
4  shell: /usr/bin/bash -e {0}
5  env:
6    TZ: America/Los_Angeles

Fails because
252 Preparing to unpack .../28-msodbcsql17_<IP_ADDRESS>-1_amd64.deb ...
253 ERROR: The EULA was not accepted. Installation aborted.
254 dpkg: error processing archive /tmp/apt-dpkg-install-0rlLDF/28-msodbcsql17_<IP_ADDRESS>-1_amd64.deb (--unpack):
255 new msodbcsql17 package pre-installation script subprocess returned error exit status 1

Area for Triage:
Packages

Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[X ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Image version
Virtual Environment
7  Environment: ubuntu-20.04
8  Version: 20210302.0
9  Included Software: https://github.com/actions/virtual-environments/blob/ubuntu20/20210302.0/images/linux/Ubuntu2004-README.md
10  Image Release: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F

Image version where you are experiencing the issue.

Hello, @jralls
You should set ACCEPT_EULA=Y environment variable - https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-ver15
- run: |
    sudo apt-get update -y
    sudo ACCEPT_EULA=Y apt-get upgrade -y

The apt-get upgrade it too time consuming operation, it's our recommendation always invoke sudo apt-get update -y command and install only necessary packets.

Or maybe packages that need EULAs shouldn't be included in the VM by default.
Regardless, we've resolved this by following your second recommendation and updating only the packages that we depend on directly. Thanks.


Zip job folder after job is complete

(supersedes #474 -- see there for additional details)
During the execution of a job, we need to access the different files (or subfolders - ref #1520) of a job folder.
After a job is complete (independently on whether it ended successfully) there is no use any more of those I/O files and logs, apart from sending a zipped file as a response for the download-log endpoint.
We should start to always zip the job folder, after the job is complete.
The download-logs endpoint would then have a branch: if the zip exists, send it over; if it doesn't exist, create it and send it over.

For a given job in fractal-server 2.3.0a2, with a single task and ~1100 images, we have a 500M folder.
This is split as
# task logs
$ du -ch 10_par*.err | tail -n1
285M	total

# args.json files
$ du -ch 10*args.json | tail -n1
148M	total

# spurious input pickle files
$ du -ch 10*pickle | tail -n1
107M	total

Calling _zip_folder_to_byte_stream on this folder (as it would be done in the API) creates a 55M zipped archive.

Some details:

This applies to V2 only
The operation which is currently done in the dowload-job-log endpoint should be moved at the end of the submit_workflow function (with the additional step of writing to a file, rather than a BytesIO object). The original folder should be removed, afterwards (after appropriate checks that everything worked).
Zipping must take place both in case of success or failure.
By default, the dowload-job-log endpoint should directly send the zip file
If the job is running, the zipped folder doesn't exist yet. In this case, the endpoint should perform the zipping.

For the record, it looks (similar to what we observed in other contexts) that calling unzip directly takes quite shorter than using Python zipfile library to extract a single file from a zipped folder with many files. Of course this can be explored/used as a workaround, if the above-mentioned performance is not acceptable.


Rename to metatensor-models

#3 is changing the naming to metatensor_models. I feel like metatensor-models is more in line with our other packages

We could also have the distribution name be metatensor-models with the corresponding Python module lives in metatensor.models (i.e. the code in this repo is in src/metatensor/models)


python38Packages.pysdl2: 0.9.8 -> 0.9.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.pysdl2 is: "A wrapper around the SDL2 library and as such similar to the discontinued PySDL project"
meta.homepage for python38Packages.pysdl2 is: "https://github.com/marcusva/py-sdl2"
meta.changelog for python38Packages.pysdl2 is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.9.9 with grep in /nix/store/m9jx35rx47wz7hnyg84piwbm66x5363j-python3.8-PySDL2-0.9.9

found 0.9.9 in filename of file in /nix/store/m9jx35rx47wz7hnyg84piwbm66x5363j-python3.8-PySDL2-0.9.9

directory tree listing: https://gist.github.com/0dc4c5e724bb2e84e2ceb6bbd76fdd67

du listing: https://gist.github.com/59f6fe56aacc07e60ab1d016168d2b57

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.pysdl2
python38Packages.pytmx
python39Packages.pysdl2
python39Packages.pytmx
tauon

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m9jx35rx47wz7hnyg84piwbm66x5363j-python3.8-PySDL2-0.9.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.pysdl2 https://github.com/r-ryantm/nixpkgs/archive/3c1e2963dd08af3456a1a1be36e6973345916e57.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m9jx35rx47wz7hnyg84piwbm66x5363j-python3.8-PySDL2-0.9.9
ls -la /nix/store/m9jx35rx47wz7hnyg84piwbm66x5363j-python3.8-PySDL2-0.9.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

Maintainer pings
cc @pmiddend for testing.

Duplicate of #139086


Jan 26 - LWDG - AML

Event Information

Category
Details

Stream Date
Jan 26, 2021

Stream Time
3 - 4 p

Title
In Development

Description
In Development

Speaker
---------

SharePoint ID
12536

SharePoint Status
Generic Published

Additional Resources:

Event Checklist
10 Weeks Prior

[ ] Title & Description Finalized
[ ] Tracking Links/Short links
[ ] Title Screen
[ ] Survey Page
[ ] Info Sheet
[ ] Published
[ ] Calendar Invite

This event has been streamed and data has been captured.


Is it possible to make Response::error_for_status() take  &mut self instead of self?

I'm trying to read the response body for debugging when server returns error status. But I found that Response::error_for_status will eat self when error. I have to check status() first, then read the body, and finally raise error manually.
The response is still available when there's HTTP status error. And I found other methods like json() or text() all take &mut self. But why error_for_status() take self?

I'm not sure there was a specific reason that it had to consume the Response. Changing it is a breaking change, but likely shouldn't actually break anyone, so it can probably just be easily made at part of 0.9. In the meantime, we could provide an extra method, like error_for_status_ref...


VS Code not suggesting prisma client functions

Bug description
Hello,
I am using prisma client and suddenly the code suggestion stopped working. This is my code in typescript file
const express = require('express');
const router = express.Router();
const { PrismaClient } = require('@prisma/client');
const prisma = new PrismaClient();

router.route('/:user/:nonce').get(async function(req, res, next) {
	const user = await prisma.user.findFirst();

	// res.status(200).json({
	// 	user: user,
	// 	success: true
	// });
});

module.exports = router;

When I start typing "prisma." nothing is suggested. It worked fine yesterday. I havent changed anything. I tried restarting VS code, I restarted the computer but nothing works.
Can someone help me?
How to reproduce

Expected behavior
No response
Prisma information

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "mysql"
  url      = env("DATABASE_URL")
}

model User {
  id         Int      @id @default(autoincrement())
  address    String?  @unique @db.VarChar(500)
  nonce      String?  @unique
  updated_at DateTime @default(now())
  created_at DateTime @default(now())
}

Environment & setup

OS: macOS
Database: MySQL
Node.js version: 18.12.1

Prisma Version
prisma                  : 4.11.0
@prisma/client          : 4.11.0
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 8fde8fef4033376662cad983758335009d522acb (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8fde8fef4033376662cad983758335009d522acb (at node_modules/@prisma/engines/migration-engine-darwin)
Format Wasm             : @prisma/prisma-fmt-wasm 4.11.0-57.8fde8fef4033376662cad983758335009d522acb
Default Engines Hash    : 8fde8fef4033376662cad983758335009d522acb
Studio                  : 0.483.0

Fixed it by using
import { PrismaClient } from '@prisma/client';
instead of require.


handle source-OOV words in bilingual

If we have a bilingual word pair and only have a vector for the target: Just map the word straight over, using the co-ordinates in the target space

consider adding a small amount of noise (mean 0; variance dim count^-1)


fix(css): ensure code is valid after empty css chunk imports are removed (fix #14515)

Description

Resolves #14515

Make sure that minified code that chains require calls with the , operator will not result in invalid code when removing one of the chained requires. Previously the last require that terminates with a semicolon was removed with the semicolon. This produced invalid code like require(), /* empty css */const foo =
Now we append either a comma if a next require call was chained, like require(...), require(css), other --> require(...)/* empty css */, other
Or terminate with a semicolon
require(...), require(css); const foo = ... --> require(...)/* empty css */; const foo = ...
Additional context
This also fixes a problem where empty chunks were not removed if chained in the middle with ,.
E.g. this like this: require(...), require(empty chunk), require(...);
(I really would like to add test cases, but it seems pretty hard to mock the plugin state for only testing the output hook)
What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy

We can maybe refactor this empty chunk replacement logic out as a function to unit test and create snapshots. That we can easily compare how this PR affects it. It may be best to do this step in another PR first so we get a starting snapshot.

Done here: https://github.com/vitejs/vite/pull/14528

Hmm I guess that's fair too. We'll compare this change in the snapshots then if it's fine.

@bluwy Tests updated, you can compare it now :)

I used<EMAIL_ADDRESS>and it is still not working. I look this problem up in the changelog, and find that it was fixed in an earlier version beta.13

@emosheeep I don't think moving the comma to behind will work. It will still be a parse error. Is there a reason the code is require-ing CSS and assigning the value of it to the e variable?
Is this only happening in the Vite beta? I'd suggest opening a new issue with a repro so we could look into it.

emmm, sorry I can hardly provide...I encountered this in my company project, which is complex very much. But the most difference usage I think about is that there are so many entries added to build.lib.entries (about 600+), and the problem only exists in cjs file, esm output is normal.

And I found it works at 4.4.11 but doesn't in 4.5.0 and 5.0.0-beta.15.


[WIP] Remove Embedded execution logic

Coverage decreased (-2.5%) to 90.79% when pulling ff0ffff349cafebeb7a75b664779992c63c70b79 on mprimi:GENIE-573-remove-embedded-execution into d989dbf6ba773fa025e6c8b2c1119540d3278911 on Netflix:master.


Trouble implementing .then

<EMAIL_ADDRESS>I added to libraries: $ tsc --lib es2018,dom --target es2018 test-case.ts.

Search Terms:
AsyncIterator, AsyncGenerator, Then, Promise, PromiseLike
Code
/**
 * Promise.prototype.then onfufilled callback type.
 */
type Fulfilled<R, T> = ((result: R) => T | PromiseLike<T>) | null;

/**
 * Promise.then onrejected callback type.
 */
type Rejected<E> = ((reason: any) => E | PromiseLike<E>) | null;

class Waiter<T, TReturn, TNext> implements PromiseLike<T> {
  source: AsyncGenerator<T, TReturn, TNext | undefined>;

  constructor(
      source: () => AsyncGenerator<T, TReturn, TNext | undefined>,
  ) {
    this.source = source();
  }

  then(onfufilled?: Fulfilled<TReturn, T>, onrejected?: Rejected<T>): Promise<T> {
    return this.implementation().then(onfufilled, onrejected);
  }

  private async implementation(): Promise<TReturn> {
    // Drain the async iterator by hand since for-await-of would
    // discard the returned value.
    while (true) {
      const { done, value } = await this.source.next();

      // We know value will be a TReturn as the async iterator
      // has already been exhausted
      if (done) return value as TReturn
    }
  }
}

async function main() {
  let waiter = new Waiter(async function* gen() {
    yield 123;
    return "abc";
  });

  try {
    let result = await waiter;
    console.log(
      `expect ${JSON.stringify(result)} to equal "abc"`,
      result === "abc"
     );
  } catch (error) {
    console.error("Oh no", error)
  }

  let other = await waiter.then(() => 123);
  console.log(`expect ${JSON.stringify(other)} to equal 123`, other === 123);
}

main().catch(console.error)

Expected behavior:
The code to compile, and correctly infer the return type for other in the example above.
Running it with node gives the correct output:
expect "abc" to equal "abc" true
expect 123 to equal 123 true

Actual behavior:
test-case.ts(20,3): error TS2416: Property 'then' in type 'Waiter<T, TReturn, TNext>' is not assignable to the same property in base type 'PromiseLike<T>'.
  Type '<S, E>(onfufilled?: (result: TReturn) => S | PromiseLike<S>, onrejected?: (reason: any) => E | PromiseLike<E>) => Promise<S | E>' is not assignable to type '<TResult1 = T, TResult2 = never>(onfulfilled?: (value: T) => TResult1 | PromiseLike<TResult1>, onrejected?: (reason: any) => TResult2 | PromiseLike<TResult2>) => PromiseLike<TResult1 | TResult2>'.
    Types of parameters 'onfufilled' and 'onfulfilled' are incompatible.
      Types of parameters 'value' and 'result' are incompatible.
        Type 'TReturn' is not assignable to type 'T'.
          'TReturn' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constraint '{}'.

When poking around in VS Code it correctly infers that await waiter is a string, which is nice. But await waiter.then(() => 123) becomes unknown instead of number. I'm guessing it's because of the type error above, but still pretty amazing that it can infer anything at all.
I also tried inlining the definitions of Fulfilled and Rejected, but no dice. I also tried changing all type parameters to T, but again nothing:
test-case.ts(20,3): error TS2416: Property 'then' in type 'Waiter<T, TReturn, TNext>' is not assignable to the same property in base type 'PromiseLike<T>'.
  Type '(onfufilled?: (result: TReturn) => T | PromiseLike<T>, onrejected?: (reason: any) => T | PromiseLike<T>) => Promise<T>' is not assignable to type '<TResult1 = T, TResult2 = never>(onfulfilled?: (value: T) => TResult1 | PromiseLike<TResult1>, onrejected?: (reason: any) => TResult2 | PromiseLike<TResult2>) => PromiseLike<TResult1 | TResult2>'.
    Types of parameters 'onfufilled' and 'onfulfilled' are incompatible.
      Types of parameters 'value' and 'result' are incompatible.
        Type 'TReturn' is not assignable to type 'T'.
          'TReturn' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constraint '{}'.

Playground Link
Related Issues:
#16993
#15599
#33239
#31264

This doesn't seem to be a bug in TypeScript, but rather an issue with the definition of the type.
The T in Waiter<T, TReturn, TNext> isn't actually used in implementation(), and the type variable returned in then should be its own type variable rather than the T in Waiter.  Here's a version with types that match the implementation:
/**
 * Promise.prototype.then onfufilled callback type.
 */
type Fulfilled<R, T> = ((result: R) => T | PromiseLike<T>) | null;

/**
 * Promise.then onrejected callback type.
 */
type Rejected<E> = ((reason: any) => E | PromiseLike<E>) | null;

class Waiter<T, TReturn, TNext> implements PromiseLike<TReturn> {
  source: AsyncGenerator<T, TReturn, TNext | undefined>;

  constructor(
      source: () => AsyncGenerator<T, TReturn, TNext | undefined>,
  ) {
    this.source = source();
  }

  then<TResult1, TResult2 = TResult1>(onfufilled?: Fulfilled<TReturn, TResult1>, onrejected?: Rejected<TResult2>): Promise<TResult1 | TResult2> {
    return this.implementation().then(onfufilled, onrejected);
  }

  private async implementation(): Promise<TReturn> {
    // Drain the async iterator by hand since for-await-of would
    // discard the returned value.
    while (true) {
      // NOTE(rbuckton): The `T` in `AsyncGenerator<T, ...>` is never
      //                 sent: ---------------------v
      const { done, value } = await this.source.next();

      // We know value will be a TReturn as the async iterator
      // has already been exhausted
      if (done) return value as TReturn
    }
  }
}

async function main() {
  let waiter = new Waiter(async function* gen() {
    yield 123;
    return "abc";
  });

  try {
    let result = await waiter;
    console.log(
      `expect ${JSON.stringify(result)} to equal "abc"`,
      result === "abc"
     );
  } catch (error) {
    console.error("Oh no", error)
  }

  let other = await waiter.then(() => 123);
  console.log(`expect ${JSON.stringify(other)} to equal 123`, other === 123);
}

main().catch(console.error)

Playground link


feat: base unit terminology in portfolio selectors

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4203

PR #4152
PR #4204

PR #4205   👈

This comment was auto-generated by Graphite.


Support GHC 9.8.3 and GHC2024

I tried comparing GHC2024 and GHC2021 language extensions.
4a5
> DataKinds
10a12,13
> DerivingStrategies
> DisambiguateRecordFields
16a20
> ExplicitNamespaces
20a25
> GADTs
27a33,34
> LambdaCase
> MonoLocalBinds
37a45
> RoleAnnotations
47d54
< NoExplicitNamespaces

What is the proper specification of dependent package versions? Do I have to check @since?

Wow, GHC 9.8.4 already landed. nixpkgs should support it now.

GHC 9.10.1 seems like unstable for now.

GHC2024 is since GHC 9.10.1. Shall we drop LambdaCase etc from default langauge extensions?

Even if GHC 9.8.4, mimicing GHC 2024 works.

According to [Hackage] Maintainer Notifications, lower package version boundary should be specified with cabal gen-bounds.
base >= 4.19.2 && < 4.20,
ghc-prim >= 0.11.0 && < 0.12,
bitvec >= 1.1.5 && < 1.2,
bytestring >= 0.12.1 && < 0.13,
primitive >= 0.9.0 && < 0.10,
vector >= 0.13.2 && < 0.14,
tagged >= 0.8.9 && < 0.9,
vector-algorithms >= 0.9.0 && < 0.10,
wide-word >= 0.1.6 && < 0.2,

..too restrictive? But some dependencies should respect PVP.


Remove page number

Thanks for all the feedback I received from the last PR and after much consideration, I came up with a more robust solution. In this PR, I removed the old approach and tried a new one. This PR only allows the repo to remove page numbers at the moment, it doesn't remove page 2 of 5 or - 8 - as a whole.
A page number can be present in all four corners of a page, which means it will appear at the very start and very end of the array. To search for the top page numbers, I searched from index 0 to 1/6 * textContent.items.length and check if it is number before putting it into a hashtable. I did the same for bottom page numbers, except the search region was from 5/6 * textContent.items.length to the last index.
(1/6 and 5/6 are just rough estimations, they're arbitrary figures where I thought the page numbers will most likely fall into)
I limit my search to the first ten pages with page numbers in those (very top and very bottom) areas of the page because I don't need all the pages. The results I get can be shown in the objects below, where the keys are pageIndex and values are pageNum. They're not the same because pageIndex is where the file starts, while pageNum may not include the cover page etc.
Figure 1
 {
      20: [3],
      21: [4],
      22: [5],
      23: [6],
      24: [7],
      25: [8],
      26: [9],
      27: [10],
      28: [11],
      30: [13],
 }

Figure 2
{
      2: [19, 86, 1986, 110],
      5: [137, 151],
      9: [1],
      10: [4],
      12: [6],
      13: [8, 7],
      14: [8],
      15: [10, 9],
      16: [11, 12, 10],
      17: [11],
 }

For example, in figure 1, 20: [3] (pageIndex 20 and pageNum 3) is followed by 21: [4]. If that happens twice in a row, I register 20: [3] as the first page. The page numbers are compared across the hashtable with the other pages based on the assumption that page numbers increase.
What if the following page was missing like in figure 2? As you can see for 10: [4] and 12: [6], there's no pageIndex 11 in between. What I did was calculate the page difference and use it to guess that 4 might be a page number, since there's a difference of two in page index and number. Likewise I did the same between 12: [6] and 13: [8, 7] since there's an increment of one. With two valid guesses in a row, I register 10: [4] as the first page.
I use the first page as a guide to where the first occurrence of page number in markdown begins. I then filter and remove pageNumbers that fall into the area where they were first found in the beginning. The page number is increased by one when a new page is being worked on.
There was another approach: I could have strictly only removed pages that appeared in the hashtable (instead of limiting it to the first 10 pages). However, some pages weren't captured properly like [146] [14, 7] [148] in figure 2. If I went with that approach, I might have missed out on removing those pages.
The downside to my approach is that if the same number appears in those areas with the page number, it might accidentally remove those as well. However, it really depends on the nature of the documents. This is particularly tricky in pdfs that have numbers for their mini-chapters that runs along with the page number.

@LoneRifle Added commit to fix requested changes. Please have a look.

Thanks for the changes! I haven't had the chance to inspect the core logic in the PR, and it will take me a while to do so. Do you urgently need this at work?

Nope not urgently, preferably not too long either? I was hoping this could count towards one of the four required PRs for Hacktoberfest.


HP Reverb Controlers problem

Hello I have noticed that HP Reverb controllers don't have binds for undo/redo in advanced mode
Menu button also seams to have no bindings.

Hi, is this using the latest beta (2.0.15) that provides proper support for the WMR controllers?

it is on steam stable - I did not turn on beta of app

I checked beta and it works...

Thanks for checking! We hope to release 2.1 as a hotfix, which will include this fix for your controllers very shortly. Apologies for the temporary inconvenience!


Migrate EIP-712 and signing code in reth-rpc to Alloy

:warning: Base on #4737 (alloy) :warning:
Use alloy-sol-types for EIP-712 in EthSigner, re-implement ethers_core::utils::hash_message in reth-primitives:

https://github.com/paradigmxyz/reth/blob/675c6bfc390b17d274541ef251375741f48dd3c3/crates/rpc/rpc/src/eth/signer.rs#L89-L93
https://github.com/paradigmxyz/reth/blob/675c6bfc390b17d274541ef251375741f48dd3c3/crates/rpc/rpc/src/eth/api/sign.rs#L22-L29

Can I take this

ah I was just starting this! haha
no worries though, you can go for it @supernovahs. I'll find another one


Navigating between 'same domain' modules reloads the content

isNotSameDomain function doesnt  works properly in case the SPA modules use path routing. It resolves if source and target belong to the same domain basing on the existance of hash '#' in the url.
I have used the following  nodes in my sample  application : (path routing)
{
            pathSegment: 'vue',
            label: 'Tractor OverVue',
            viewUrl: 'https://luigi-module-vue.us-east.stage.cf.yaas.io',
            children: [{
                pathSegment: ':id',
                viewUrl: 'https://luigi-module-vue.us-east.stage.cf.yaas.io/:id'
              }
            ]
          }

While navigating between vue and vue/:id, luigi reloads the iframe src and initialises the content from scratch , which looses the SPA benefits of the bundled modules

The solution should introduce additional SPABaseURL property in the navigation configuration


Error when running admin-bro

I've existing application, setup with this way
// admin/index.js
import AdminBro from 'admin-bro';
import AdminBroExpress from 'admin-bro-expressjs';
import AdminBroSequelize from 'admin-bro-sequelizejs';
import models from '../models';

AdminBro.registerAdapter(AdminBroSequelize);

const admin = {};

admin.bootstrap = app => {
  const adminBro = new AdminBro({
    resources: Object.values(models),
    rootPath: '/admin'
  });
  admin.adminBro = adminBro;

  const router = AdminBroExpress.buildRouter(adminBro);
  admin.router = router;

  app.use(adminBro.options.rootPath, router);

  return admin;
};

export default admin;

//index.js
import app from './app';
import rest from './rest';
import admin from './admin';
import { BACKEND_PORT } from './config';
import { logger } from './utils';

rest.bootstrap(app);
admin.bootstrap(app);

app.listen(BACKEND_PORT, () => {
  logger.info('Server is running on port 3000');
});

When I open localhost:3000/admin, I got
AdminBro: bundle ready
Unhandled type: BOOLEAN
Unhandled type: BOOLEAN
Unhandled type: BOOLEAN
Unhandled type: BOOLEAN
Warning: Failed prop type: Invalid prop `resources[0].name` of type `object` supplied to `Sidebar`, expected `string`.
    in Sidebar
    in Context.Consumer
    in Connect(Sidebar)
    in section
    in Context.Consumer
    in StyledComponent
    in application__ApplicationWrapper
    in Fragment
    in App
    in Context.Consumer
    in Connect(App)
    in Context.Provider
    in Router
    in StaticRouter
    in Context.Provider
    in Context.Consumer
    in ThemeProvider
    in Context.Provider
    in Provider
Warning: Failed prop type: Invalid prop `parent.resources[0].name` of type `object` supplied to `SidebarParent`, expected `string`.
    in SidebarParent
    in Sidebar
    in Context.Consumer
    in Connect(Sidebar)
    in section
    in Context.Consumer
    in StyledComponent
    in application__ApplicationWrapper
    in Fragment
    in App
    in Context.Consumer
    in Connect(App)
    in Context.Provider
    in Router
    in StaticRouter
    in Context.Provider
    in Context.Consumer
    in ThemeProvider
    in Context.Provider
    in Provider
Warning: Failed prop type: Invalid prop `resource.name` of type `object` supplied to `SidebarResource`, expected `string`.
    in SidebarResource
    in Context.Consumer
    in withRouter(SidebarResource)
    in ul
    in Context.Consumer
    in Context.Consumer
    in StyledComponent
    in sidebar-parent__ResourcesList
    in li
    in SidebarParent
    in ul
    in section
    in section
    in aside
    in Context.Consumer
    in Context.Consumer
    in StyledComponent
    in sidebar__SidebarWrapper
    in Sidebar
    in Context.Consumer
    in Connect(Sidebar)
    in section
    in Context.Consumer
    in StyledComponent
    in application__ApplicationWrapper
    in Fragment
    in App
    in Context.Consumer
    in Connect(App)
    in Context.Provider
    in Router
    in StaticRouter
    in Context.Provider
    in Context.Consumer
    in ThemeProvider
    in Context.Provider
    in Provider
{ Invariant Violation: Objects are not valid as a React child (found: object with keys {plural, singular}). If you meant to render a collection of children, use an array instead.
    in a
    in Context.Consumer
    in Link
    in Context.Consumer
    in NavLink
    in Context.Consumer
    in Context.Consumer
    in StyledComponent
    in sidebar-resource__ResourceLink
    in li
    in SidebarResource
    in Context.Consumer
    in withRouter(SidebarResource)
    in ul
    in Context.Consumer
    in Context.Consumer
    in StyledComponent
    in sidebar-parent__ResourcesList
    in li
    in SidebarParent
    in ul
    in section
    in section
    in aside
    in Context.Consumer
    in Context.Consumer
    in StyledComponent
    in sidebar__SidebarWrapper
    in Sidebar
    in Context.Consumer
    in Connect(Sidebar)
    in section
    in Context.Consumer
    in StyledComponent
    in application__ApplicationWrapper
    in Fragment
    in App
    in Context.Consumer
    in Connect(App)
    in Context.Provider
    in Router
    in StaticRouter
    in Context.Provider
    in Context.Consumer
    in ThemeProvider
    in Context.Provider
    in Provider
    at /Users/mpj/danacita/reeba/node_modules/react/cjs/react.development.js:1145:30
    at traverseAllChildrenImpl (/Users/mpj/danacita/reeba/node_modules/react/cjs/react.development.js:1148:9)
    at traverseAllChildren (/Users/mpj/danacita/reeba/node_modules/react/cjs/react.development.js:1176:10)
    at mapIntoWithKeyPrefixInternal (/Users/mpj/danacita/reeba/node_modules/react/cjs/react.development.js:1254:3)
    at toArray (/Users/mpj/danacita/reeba/node_modules/react/cjs/react.development.js:1303:3)
    at ReactDOMServerRenderer.renderDOM (/Users/mpj/danacita/reeba/node_modules/react-dom/cjs/react-dom-server.node.development.js:3925:18)
    at ReactDOMServerRenderer.render (/Users/mpj/danacita/reeba/node_modules/react-dom/cjs/react-dom-server.node.development.js:3483:21)
    at ReactDOMServerRenderer.read (/Users/mpj/danacita/reeba/node_modules/react-dom/cjs/react-dom-server.node.development.js:3395:29)
    at renderToString (/Users/mpj/danacita/reeba/node_modules/react-dom/cjs/react-dom-server.node.development.js:3954:27)
    at html (/Users/mpj/danacita/reeba/node_modules/admin-bro/lib/frontend/layout-template.js:57:51)
    at AppController.index (/Users/mpj/danacita/reeba/node_modules/admin-bro/lib/backend/controllers/app-controller.js:14:12)
    at handler (/Users/mpj/danacita/reeba/node_modules/admin-bro-expressjs/plugin.js:56:52)
    at Layer.handle [as handle_request] (/Users/mpj/danacita/reeba/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/mpj/danacita/reeba/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/Users/mpj/danacita/reeba/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/Users/mpj/danacita/reeba/node_modules/express/lib/router/layer.js:95:5)
    at /Users/mpj/danacita/reeba/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/Users/mpj/danacita/reeba/node_modules/express/lib/router/index.js:335:12)
    at next (/Users/mpj/danacita/reeba/node_modules/express/lib/router/index.js:275:10)
    at urlencodedParser (/Users/mpj/danacita/reeba/node_modules/body-parser/lib/types/urlencoded.js:91:7)
    at Layer.handle [as handle_request] (/Users/mpj/danacita/reeba/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/mpj/danacita/reeba/node_modules/express/lib/router/index.js:317:13) name: 'Invariant Violation' }

can you change resources: Object.values(models), to resources: Object.values(models.sequelize.models),
BTW when you pass entire database instead of resources is it working?
const adminBro = new AdminBro({
    //resources: Object.values(models),
    databases: [models],
    rootPath: '/admin'
  });

Hi @wojtek-krysiak,
I tried both your suggestion, the first one doesn't make any difference, it still fails.
However, the second one it works, what I need to do is pass sequelize instance to the databases options as a member of an array.
const adminBro = new AdminBro({
-    resources: Object.values(models),
+    databases: [sequelize],
    rootPath: '/admin'
  });

closing this one - added #153. And I am working on it right now.

I know what your error is: Object.values(models) returns not just models - it also returns Sequelize database object - and this causes an error. Simply pass models one by one. I updated the docs: https://softwarebrothers.github.io/admin-bro-dev/module-admin-bro-sequelizejs.html

NIce info @wojtek-krysiak, thanks for your help.


Improvements for Workerless Shoot

Co-Authored-By: Ashish Ranjan Yadav<EMAIL_ADDRESS>Co-Authored-By: Sonu Kumar Singh<EMAIL_ADDRESS>How to categorize this PR?

/area quality usability
/kind enhancement
What this PR does / why we need it:
This PR improves two things:

The rotate-ssh-keypair annotation is no-op now if the ssh is not enabled for the Shoot.
The extension labels are not added to workerless shoots for globally enabled extensions if they are not supported.

Which issue(s) this PR fixes:
Part of #7635
Special notes for your reviewer:
Release note:

NONE

/lgtm

/lgtm


Productize Supersim

Supersim should be installable from the CLI without directly building from source. We have a couple of distribution options that could be good:

Homebrew: users can install Supersim via brew install
Go Modules: let users install with go install github.com/ethereum-optimism/supersim

There are more options like Docker, Github releases with pre-built binaries, etc.
The purpose of this issue is (1) to decide on one or multiple ways for devs to install Supersim from their CLI, and allow them to update the tool witjh supersimup and user it with supersim and (3) to implement.
Definition of Done

[ ] Users can install Supersim via the chosen distribution method.
[ ] Users can use a command like supersimup to update and supersim to use Supersim in their CLI.
[ ] Supersim documentation has been updated to reflect this change.

For brew setup we can update our goreleaser config to also publish to homebrew https://goreleaser.com/customization/homebrew/
For supersimup I think the script only needs too

Verify if you have anvil installed and potentially run foundryup
Detect which arch & os the user is running on
Pull the correct binary based on what arch the user is running from our latest github release https://github.com/ethereum-optimism/supersim/releases
Add the binary to the users path


test_hybrid.cpp: Fixing buffer overrun that was failing clang -fsanitize...

test_hybrid.cpp: Fixing buffer overrun that was failing clang -fsanitize=address checks.

Merged after rebase, thanks!


Kea DHCP: DNS server addresses disappear in subnet settings

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
DNS server addresses disappear in Subnet settings.
To Reproduce
Steps to reproduce the behavior:

Add several DNS servers (<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>) to Subnet.
Click the Save button.
Open Subnet settings.
See only <IP_ADDRESS>.

Environment
Software version used and hardware type if relevant, e.g.:

OPNsense 24.1.1-amd64
FreeBSD 13.2-RELEASE-p9
OpenSSL 3.0.13

looks like using "Auto collect option data"

looks like using "Auto collect option data"

The issue is resolved. I forgot about this checkbox. My mistake.

@KaiKimera no problem, I've added https://github.com/opnsense/core/commit/bf9996989ee653ce1cc4c0df03f2405d78c30721 to make it more explicit from the users perspective. (hide when automatically collected on save)


fixed https check, respect basic auth parameters in url

Fixes https protocol selection and adds support for basic auth parameters.

Out as 1.2.1


Change class User to old class name FirebaseUser

class User is general for almost project, but when use with firebase_auth, the old version name is FirebaseUser. Now almost file we need to refactor like this import 'package:firebase_auth/firebase_auth.dart' as firebase_auth; and use firebase_auth.User, it's a bad name. And almost class need to change like
firebase_auth.FirebaseAuth.instance.signOut
firebase_auth.GoogleAuthProvider
firebase_auth.AuthCredential
.....
....

Idk who's idea was to change FirebaseUser to User... knowing that pretty much all projects have their own "User" class :/


VSCode extension XSLT/XPath fails to auto tag-close

Copied from DeltaXML's Support Portal:

VSCode on Ubuntu 24.04.
auto tag-close works fine with RedHad XML extension for VSCode, but not with XSLT/XPath.

Is this a problem when you're editing XSLT or just general XML?
If this occurs when editing XSLT please supply an XSLT file with a missing tag that can't be auto-closed so I can reproduce this issue. If this occurs when editing general XML, it's possible RedHat's auto tag-close is conflicting with DeltaXML's XSLT/XPath extension (or vice-versa).
Please note, by design, DeltaXML's XSLT/XPath extension only performs an auto-tag-close when '</' is typed. Completing a start-tag does not trigger the auto tag-close.

Thanks for responding pfearo.
I will try to give more details, but I do not know the best way to write about xml files in Markdown.
The problem is the same when editing XML with the XSLT/XPath editor, but it shows up to me, when editing XSLT, e.g. the simple file test.xsl:
test.txt
(I renamed it to test.txt, as github would not accept .xsl as file extension)
I was expecting that </example> is automatically inserted when I type the > of <example>.  But nothing happened. When I go on an type </ I was expecting that VSCode automatically completes the closing tag to </example>. But nothing happened.
In the meantime I have installed VSCode with XSLT/XPath extension to Win11. The expected behavior of the XSLT/XPath editor is missing there as well.

I've created a .xsl test file from your test.txt attached file. This is the behaviour I get:

When I type the > of <example> no auto close-tag is inserted as you expected. This is actually by design because I find it annoying to undo the close-tag for the many cases where I don't want to close the tag immediately.
When I go on to type </ I get the </example>  close-tag inserted automatically as I would expect, but you are not seeing the same behaviour.

To resolve (2) to see if this is caused by another extension you've installed, please could you try your example in a new workspace but after disabling all extensions in that workspace and then enabling just the DeltaXML XSLT/XPath extension? (There's a 'disable all installed extensions for this workspace' command that should help).

Sorry for answering late. I changed to a different project with a different laptop, win10. And have the same issue.
XSLT/XPath is - afaics - the only installed and enabled extension to VSCode. And I get no auto close offer with your 2. method as you do.
What could be different?

still missing a solution


Fetch logs by property value

I'd like to achieve something like this:
$activity = Activity::all()->whereProperty(['company_id' => '123'])->last();

Suggestion for improvement

If you're using json fields you can do this:
$activity = Activity::where('property->company_id, '123')->orderBy('created_at', 'desc')->first();


What about introducing contextual selectors?

We often use rules like this one:
.menu-on .menu-button {
    display: block;
}

What if we created atomic classes to take care of this and remove the need of most of these rule?
Imaging this:
<button class="menu-on--D-b" ..>

Such class would produce this in atomic.css:
.D-b,
.menu-on .menu-on--D-b {
    display: block;
}

Pros:

selectors are grouped, there is no declaration redundancy
it's declarative, the logic is in the class itself

Cons:

if the contextual class changes, then authors would need to search and replace it in many places.

I don't think this would be a good idea after all, but it was worth writing it down :)

As we discussed offline, we will add contextual selectors inspired by XPath Expressions in the form of:
Parent:

        <button class="menu-on//D-ib">

.menu-on .menu-on\/\/D-b {
    display: block;
}

Parent and direct child:

    <button class="menu-on/D-ib">

```css
.menu-on > .menu-on\/D-b {
    display: block;
}

We shouldn't encourage this approach though (Maybe we shouldn't even add). But if you are using a component framework, you want your component to not be tightly coupled with stuff outside of its domain. By allowing contextual selectors, we would be allowing this bad practice, while not only making the component less reusable but also the CSS class itself (.menu-on > .menu-on\/D-b isn't reusable).
This means that <Button> shouldn't know anything about its parent. If it needs to be different based on the context, then the parent component <Menu> should control what it does with <Button>, by passing additional classes or not.

This would only be useful if you're not using a component-based framework (or no framework at all) and/or don't have much control over the markup.

Yeah, as I was saying to @renatoi offline, it feels like this would violate the spirit of Atomic CSS somewhat, in that you could end up bloating the CSS with all these contextual selectors (the combined declarations are like what you'd get out of sass...)

This would only be useful if you're not using a component-based framework (or no framework at all) and/or don't have much control over the markup.

There's something to be said for focusing on a specific problem space we want Atomic to address and own, and I think that's component-based frameworks.  That's Atomic's strength, and we shouldn't water it down to accommodate legacy development practices.

As we discussed offline, we could have this "offering" in a advance section. Not something we'd promote but something that would answer some people question:

so Atomic cannot do contextual selectors, so dumb!

See what I mean? Besides... who knows? There could be use cases where it could be handy...

As we discussed offline, we could have this "offering" in a advance section. Not something we'd promote but something that would answer some people question:

so Atomic cannot do contextual selectors, so dumb!

See what I mean? Besides... who knows? There could be use cases where it could be handy...

If we don't want people to use it because we're focusing on a problem space that doesn't require them, then I think this is the wrong route to go down, and a waste of valuable time.  Better to open an issue like this, get a conversation going with real users, and then re-evaluate the need for it down the road.
I'm not saying 'never', but for now it seems like an unnecessary diversion.

No, but providing extra stuff that people could ask for somehow shows that we have thought the whole thing through (kinda). Which in my opinion is a good thing as people going through the docs could see this not as something they could use, but something that proves the solution covers a lot of ground.
And once again, this is not something we would promote in any way, could be small print in the advanced section...

ok, one more try... :)
This is a valid use case which would not promote bad practice (to the contrary); when authors want to reveal elements on mouseover.

    ...
    <button class="Op-0 Op-1:f trigger:h//Op-1">foo</button>
    <button class="Op-0 Op-1:f trigger:h//Op-1" class="">bar</button>

And the above example shows that - contrary to what I suggested before - there are times where it makes no sense to pair :hover with :focus, so may be better to make things more explicit as it was suggested in another thread yesterday.
I think this is a valid example that makes my case for supporting descendant selectors stronger, no?

The context can be easy handled by React, i think this feature would be more usefull if it allowed users some how to write less code:

...

...

...

...

@3den that's interesting but not related to what we're discussing here. What you show suggests targeting children instead of the node itself via an ancestor).
We could use a syntax that follows the approach we have taken so far:
<ul class="myList myList<W-25 myList<Fl-start">

...

...

...

...

.myList > * {
    width: 25%;
    float: $LEFT;
}

It is the exact reverse of what we are doing to target ancestors but this serves a very different purpose which is DRYNESS in the markup. Something that goes against Atomic philosophy because this would lead to bloating the style sheet because either we will end up with duplicate declarations OR grouped selectors, as it shows below:
.Fl-start {
    float: $LEFT;
}
.W-25\% {
    width: 25%;
}
.myList > * {
    width: 25%;
    float: $LEFT;
}

or
.Fl-start,
.myList > * {
    float: $LEFT;
}
.W-25\%,
.myList > * {
    width: 25%;
}

I like the approach above the d you think it is possible to group the the styles:

W-25|Fl-start">

...

...

...

...

It's possible but it would create CSS bloat which goes against Atomic's philosophy.
Redundancy in the markup is not as bad as redundancy in the CSS.

The css generated could be exactly the same one that you sugested above

We just need to make the parser/compiler smarter...

@3den

The css generated could be exactly the same one that what you suggested above

Yes, and this is the reason we do not want to go this route, because we do not want redundancy in the style sheet (declarations or selectors does not matter).

Following our latest offline discussions, the syntax would not follow XPath Expressions; we would instead use _ for descendant combinator and > for child combinator, like so:
Descendant selector:

.menu-on .menu-on_Td-u {
    text-decoration: underline;
}

Child selector:

    <button class="menu-on>D-ib">

.menu-on > .menu-on\>D-ib {
    display: inline-block;
}

on the example above case above we will have CSS duplication the same way...
D-ib {
    display: inline-block;
}

.menu-on > .menu-on\>D-ib {
    display: inline-block;
}

.menu-on .menu-on_D-ib {
     display: inline-block;
}

There is duplication on the CSS and HTML... Seems like the decedents and child selectors server the same purpose IMHO the child reads better maybe we can use it for both:
D-ib {
    display: inline-block;
}

.menu-on .menu-on\>D-ib {
    display: inline-block;
}

But I think it would be nicer to have some way of avoiding code duplication on the markup, that would be very useful to create grids:

W-1/3|Fl-start|D-ib">

...

...

.grid\>W-25%\|Fl-start\|D-ib > * {
    display: inline-block;
    float: $start;
    width: 25%;
}

IMHO redundancy on the markup is as bad as redundancy in css, because there is no cnd for the markup and it is much harder to cache than CSS.

on the example above case above we will have CSS duplication the same way...

There is a big difference between the 2. We cannot solve the first problem with a plain vanilla approach while we can simply add classes where needed to solve the need of targeting children.
In other words, we "accept" redundancy because there is no other/better way to create classes targeting ancestors.
Allowing "shortcuts" as you propose could result in outputting rules grouping many different declarations (as your example suggests) which will create unnecessary bloat in the style sheet.

Addressed in pull #108


Updating the title for the consistency.

Updating the title for the consistency.
Interaction design - Gaze
Interaction design - Gesture
Interaction design - Voice

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/gaze-targeting.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@cre8ivepark Same as the note I made on "Voice design." There is already a core article titled "Gaze" and this isn't it. This should be "Gaze design" or something along those lines if "targeting" isn't the right word.


Executing a stored Procedure asks to bind variables

System information:

Ubuntu 18.4
6.0.2
openjdk version "1.8.0_191"

Connection specification:

MSSQL 2017
MS SQL Server / SQL Server

Describe the problem you're observing:
Since version 6.0.2, when executing a stored procedure, it asks me to bind variables. So, I need to repeat in the bind variable window the name of the variables. This seems unecessary.
Steps to reproduce, if exist:
Open a new SQL-Editor. Write a script that executes a Stored Procedure:
EXEC [MyDB].mySchema.myStoredProcedure @parameter1 = 'test', @parameter2 = 42;
GO

Click "Execute Script". The following window comes  up:

I need to retype the variable names.
Afterwards the script gets executed as:
EXEC [MyDB].mySchema.myStoredProcedure @parameter1 = 'test', @parameter2 = 42;
Why is there this time wasting step in between with the binding of the variables? They don't need to be binded.

The same in Windows 10:
DECLARE @Vclie TABLE 	( ID VARCHAR(20) )
INSERT 	INTO 		@Vclie 	VALUES('171')

@zelite, can you disable the "Enable SQL parameters" and test again?

It's working for me now.

This looks like a bug. In 6.0.2 symbol @ is evaluated as parameter prefix by default (for SQL Server)). It shouldn't.

Verified


Question: Is this still supported?

Hi, thanks for this library, but I'm wondering is it still supported? @elithrar @boj
I see that there is broken CI:
https://travis-ci.org/github/boj/redistore/jobs/687555984
https://travis-ci.org/github/boj/redistore/jobs/687555985
https://travis-ci.org/github/boj/redistore/jobs/687555989
and abandoned open PR's without maintainers responses, so my question is should I switch to another library?

Hello @iamolegga
@elithrar and @kisielk took over this project awhile back, although I am unsure if they actively support it any longer (likely not given the PR queue). I have not worked in this language for years now and don't really monitor this repo outside of direct mentions.
Happy to add new contributors, or perhaps add a notice this is no longer maintained.

Sorry but I've also been fairly inactive in the Go world for the last few years, originally I took on this because I was maintaining the Gorilla packages but I am no longer active in that either.

Partially. The PRs have been non-critical from my perspective - I’ve been “triaging” most projects in this way.

(Also IIRC I didn't have admin rights to fix the CI problem - I'd just port it to CircleCI as per all of the other Gorilla repos)


Branch 140903864

Windows failure looks legit.
@mrry It looks like some cuda stuff is leaking into non-cuda build?

Apparently yes. I don't recognize the symbols CudaRoot and LibdeviceRoot… perhaps they're new and whatever CL added them will make it clear what's wrong. (I'm not sure why this wouldn't fail to link on Linux CMake CPU as well, but maybe MSVC is more strict about unused symbols?)

Maybe this one?
https://github.com/benoitsteiner/tensorflow/commit/e1f44d854e9e6db6ce1f7c70b81d0fef03e4a932

It'd probably be possible to fix this up by moving this file https://github.com/benoitsteiner/tensorflow/blob/e1f44d854e9e6db6ce1f7c70b81d0fef03e4a932/tensorflow/core/platform/posix/cuda_libdevice_path.cc to ../default (and modifying the necessary paths in the build config).

I've fixed the CudaRoot and LibdeviceRoot compilation errors on windows.

Jenkins, test this please.

@martinwicke I see experiment_test failures here.
Maybe this PR does not contain the rollback?

Not included. Was waiting for LGTMs -- it's being submitted now.

Andrew will push the changes


feat: adding homebrew formula

Added a homebrew formula and updated the README to include steps on how to add the tap and install with brew

This is so cool.


New Datasource: github_collaborators

Adding collaborators datasource. Addresses #103
=== RUN   TestAccGithubCollaboratorsDataSource_basic
--- PASS: TestAccGithubCollaboratorsDataSource_basic (6.13s)

closing down in favor of #239


ERROR:  could not access file "$libdir/hypopg": No such file or directory

Getting ERROR:  could not access file "$libdir/hypopg": No such file or directory
when running
tail -F -n +1 log/postgresql.log | dexter --min-cost-savings-pct 30

Hey @k2xl, this error means there's an issue with the HypoPG installation. Try reinstalling it.

Solved it by reinstalling hypopg, then DROP EXTENSION hypopg and CREATE EXTENSION again


Microsoft.Insights.VMDiagnosticsSettings resource error

In this section:
//Start of section to add
"resources": [
{
"type": "extensions",
"name": "Microsoft.Insights.VMDiagnosticsSettings",
"apiVersion": "2017-12-01",
It should be:
//Start of section to add
"resources": [
{
"type": "Microsoft.Compute/virtualMachines/extensions",
"name": "[concat(variables('vmName'), '/', 'Microsoft.Insights.VMDiagnosticsSettings')]",
"apiVersion": "2017-12-01",

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 246015be-e47a-87e1-b027-efdc0c6a3ad1
Version Independent ID: fbfbb69a-7435-2d69-d13a-5a7e0a05431f
Content: Send Guest OS metrics to the Azure Monitor metric store using a Resource Manager template for a Windows virtual machine
Content Source: articles/azure-monitor/platform/collect-custom-metrics-guestos-resource-manager-vm.md
Service: azure-monitor
Sub-service: metrics
GitHub Login: @anirudhcavale
Microsoft Alias: ancav

"type": "extensions",
results following errors:
Deployment template validation failed: 'The template resource 'Microsoft.Insights.VMDiagnosticsSettings' at line '1' and column '4503' is not valid. The type property is invalid. Please see https://aka.ms/arm-template/#resources for usage details.'.
"name": "Microsoft.Insights.VMDiagnosticsSettings",
results following errors:
Deployment template validation failed: 'The template resource 'Microsoft.Insights.VMDiagnosticsSettings' for type 'Microsoft.Compute/virtualMachines/extensions' at line '1' and column '4503' has incorrect segment lengths. A nested resource type must have identical number of segments as its resource name. A root resource type must have segment length one greater than its resource name. Please see https://aka.ms/arm-template/#resources for usage details.'.

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

@anirudhcavale  -  any input on this please?

@femsulu or @yeswps can you submit a PR with this update

@anirudhcavale
I tried to fork it and created a PR  #35150, but i guess I'm not authorized :)

@yeswps I saw the PR and I have approved it. Thanks for the contribution!


feature: allow passing auth params

Summary
Allow passing params to feathers.authenticate() via auth module authenticate action.

[x] Tell us about the problem your pull request is solving.
[x] Are there any open issues that are related to this?

no

[x] Is this PR dependent on PRs in other repos?

no

Other Information
Should this be mentioned in the docs?

Love to see the tests, too!  Thank you so much!


Fix IndentationError works differently with cpython in interective shell

Fixes #3892  #4400
Removed the automatic continuing logic that was in place for code that needs multiple lines in the shell to parse correctly. Now we check if full_code can be parsed after each line of input given, but ignoring specific EOF and IndentationLevel errors.
I am working on a way to do this without modifying errors.rs, if I should not be modifying that.
Edit: I think my edits to errors.rs may have improved EOF error handling.

I think this PR might have been a bit more complex than needed. As far as I can tell, the main issue here could of been solved by just tweaking the ShellExecResult::Continue case to check if an empty line was the input (and only an empty line).
There's also a couple of little issues here, the Indentation Error isn't exactly the right one and now any line containing a comment or space/tabs results in an indent error.
The changes to error seem right though, but it can also be slightly tweaked to simplify (matching against it in shell_exec as the others do. For this we probably could use an IndentError with a wrong token value that we only use for the match.

@DimitrisJim I agree this fix was too complex, I simplified it in #4406 . The improved fix does exactly what you said with checking for an empty line. There are also cases in continue mode when a non-empty line is given where an error should be thrown, so I accounted for those too.
I'll look into what you mentioned about the indentationerror


Add a new Download Button with Circular Progress Bar

This is a(n):

[ ] Update to an existing Animated Button
[ ] Any Error
[x] Proposal to the Repository
[ ] Documentation / README.md changes

Details:

I would like to add a button similar to the below attached screenshot

I would to work on this issue as part of GSSOC'23 contribution.

Please assign to me as GSSoC'23 Contributor

@Uma-95 Assigned to you.
All the best.
@iLakshya You can work on another issue or create one.
Make sure to ⭐ the repo and follow me.
I would love to connect with you all. ❤
https://www.linkedin.com/in/om-gawande/


Using Intel Quick Sync

Hi,
I see there are a lot of issues documenting using Nvidia GPUs, I was wondering if anyone had any experience using Intel Hardware Acceleration in applications, notably Intel Quick Sync?
I want to run some IP Camera Surveillance software in a container, but for this to work well it needs to use Intel Quick Sync for hardware acceleration while also supporting VNC for remote access.
Thanks!

Am I right to assume that to achieve what I want I need to use the steps in the VNC example but rather than use dummy or Xvfb, use --xdummy-xwayland ("Using special setup with Weston, Xwayland and xdotool instead of Xdummy or Xvfb to allow GPU access.")

:-D

I was wondering if anyone had any experience using Intel Hardware Acceleration in applications, notably Intel Quick Sync?

I don't know about "Intel Quick Sync" itself. But in general Intel GPU's  work well with MESA drivers on host and in image. For video decoding support you also need libxv1
and va-driver-all in the image. Compare: https://github.com/mviereck/x11docker/wiki/dependencies#dependencies-in-image

I see, so in practical terms I have to use Debian and Ubuntu images (which is fine as I had intended to anyway).
Thanks for pointing me in the right direction :)

Another (noob) question, when I try and run the VNC example:
read Xenv < <(x11docker --xdummy --showenv x11docker/lxde)
I get -sh: syntax error near unexpected token '<'
Any idea why my SSH doesn't recognise this symbol?

I see, so in practical terms I have to use Debian and Ubuntu images (which is fine as I had intended to anyway).

It should work with other systems providing the drivers as well. The dependency tables shows the package names for some systems.

Another (noob) question, when I try and run the VNC example:

Please open new tickets for new issues.

I get -sh: syntax error near unexpected token '<'

read Xenv < <(x11docker ...) is a bash syntax. Likely you tried the command in sh. I am not sure yet how to achieve the same in sh. Try in bash instead.


How to gather the last X indices embeddings before every grouping of False in a boolean mask for every row in a batch

Urgent help needed in doing the below operation. Mask for input is given, its shape is [batch size, no of timesteps]. From this, I need to collect X number of embeddings of shape [batch size, timestep index, embedding size] such that they are grouped just before each grouping of False.
say mask of a batch size of 1 is T,T,T,F,F,F,F,|T,T,F,F,F,F,F and X=2 (by '|', I assumed a break which indicates a row split length=7), then should get list of concatenated embeddings given by indices (1,2) (8, 9). In the case when X is greater than number of Trues, should return the embeddings from index of first True till index which is X away from it.
Should be able to replicate the above when batch size is variable without having to do individually for each batch as my batch size is pretty high. Output should be [ [ (1,2) , (.,.),.. for other batches at first row split (0:7) ] , [ (8,9) , (.,.) for other batches at second row split (7:14)], ..]
Any help will be highly appreciated.

@vyshnavigutta369
Request you to fill issue template.
Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version.
Provide the exact sequence of commands / steps that you executed before running into the problem.Thanks!


TXT record instead of CNAME

Hi.
I'm curious. Why not to use separate DNS TXT record for storing redirecting URL? It will be even simplier than parsing all from CNAME.

Hi @kolobus,
The main reason is my client interfaces, some do not have the TXT option available for use...

@udlei
wow. Never seen a single one dns editor without txt records in this decade - txt are essential for SPF, DKIM, domain validations and tons of other things. It's better not to use such registrars / service providers :)
Anyway consider making txt record for url and hacky cname as a fallback mechanism.
I made it like this:
$dnstxt = @dns_get_record("_url.".$domain, DNS_TXT);
if ($dnstxt) {
        $redirect = $dnstxt[0]["txt"];
}

And in Zones I can put any CNAME/A pointing to host and special subdomain:
_url 3600  IN TXT "https://example.com/some/url"

@kolobus is a harsh reality here ...
There is another redirect, http://redirect.name based in TXT. I will also consider putting in an upcoming release.


nvm 0.1.0

Hi guys,
I've been using Bitrise for a few weeks now and it works great! :)
For npm projects like react-native, it's often nice to be able to exactly select the node version. This is exactly what nvm does!
I wanted to try it on Bitrise.io, so I set my steplib as a custom lib source to then run this step:
---
format_version: 1.2.0
default_step_lib_source: https://github.com/almouro/bitrise-steplib.git
trigger_map:
- pattern: "*"
  is_pull_request_allowed: true
  workflow: primary
workflows:
  primary:
    steps:
    -<EMAIL_ADDRESS>{}
app:
  envs:
  - opts:
      is_expand: false
    BITRISE_PROJECT_PATH: ios-simple-objc/ios-simple-objc.xcodeproj
  - opts:
      is_expand: false
    BITRISE_SCHEME: ios-simple-objc

It runs great, but the UI workflow editor will not work, saying There’s an issue in your bitrise.yml configuration. You have to fix it before you could use the UI editor again.
Error: Cannot read property 'versions' of undefined.
Any idea why? First time I create a step, sorry if I missed something! :[
New Pull Request Checklist

[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run stepman audit --step-yml ./step.yml (in the step's repository - note, stepman is part of the Bitrise CLI, you don't have to install it separately)
[x] I read and accept the Abandoned Step policy

Awesome, thanks a bunch!
Re: "Error: Cannot read property 'versions' of undefined." - you get this in the editor because there's no "nvm" step yet in the library, but this will change soon ;)
We'll do a review asap - first step review takes a bit longer, as we try to advise changes which might be hard to correct later (without breaking compatibility); subsequent version/update shares are way faster (usually just a couple of hours).

Btw you can test & use your step before sharing as described in the step template https://github.com/bitrise-steplib/step-template#how-to-create-your-own-step

Hi @Almouro ,
would you like to fix, the mentioned issues, or should we merge your step?
The issues are not critical, so we can merge it, but it would be great to fix them in the next version of the step.
Thanks for the contribution! 🚀

We decided to merge this version, thank you for the contribution!
Feel free to publish an update once you have the time for adding the linux support, or if you want to add anything else to the step ;)


Make regression tests more flexible

I reviewed this design with @simonbyrne.
Basically, this PR sets up a way for users to "restart" regression tests by updating a reference counter. Here is a sketch of the original plan / design:
Work-flow procedure:
 1) We start off with a self reference: print a new reference counter in `print_new_counter` job
 2) (PR author) copy-paste counter into `ref_counter.jl`
 3) Upon next CI run, before performing CI test,
    we check if the counter indicates a self-reference by
    checking if `ref_counter.jl` in the PR matches
    `ref_counter.jl` in the last merged commit (on central).
    If yes, then it's a self reference, if not, then we
    look-up the dataset based on the counter.

I'll add proper documentation (by adding to #331) if this works as intended, for now I'd like to try it out.

bors r+


Junior is missing examples

There are no examples in TSJ. Need some.

[ ] Add to installer: examples TS Jr.zip
[ ] Add to automated tests

Use separate folder junior in examples to prevent conflicts, and change default path to examples in the config to open this folder by default after installation.


Fix issue #691

Body parser expects this function to return a handler function, rather than an array of handlers.  Currently, requests with Content-Type: text/csv will crash the server unless there is a handler for uncaught exceptions.

Hi, could you please add a unit test for your changes? Please prefix the test name is "#691"

It turns out this escaped detection because its unit tests did not properly check that the was no error returned.


fix: page background colour not changing

🐛 Bug Report

💻 Repro or Code Sample
Repo with example project
🤔 Expected Behavior
When I change the browser theme from light to dark, the text colour changes to white and the background gets dark.

😯 Current Behavior
When I change the browser theme from light to dark, the text colour changes to white but the background stays white. This
makes it hard to read the text.
light mode:

dark mode:

🌍 Your Environment

OS & Device: Windows 10 Enterprise 22H2 on Dell Lattitude
Browser: Microsoft Edge
.NET V8.0 and Microsoft.FluentUI.AspNetCore V4.4.1

You'll have to implement some code to make the theme swithching work. See the demo site source (part of the repo) and the information in https://www.fluentui-blazor.net/DesignTheme

@vnbaaij  I followed the instructions but the background is still white. Do you think you could have a look at my repo?

Sorry, I don't have time to do that. I would recomment to watch out .NET Conf talk and take a look at the source we showed there.

Link to video: https://youtu.be/a0xOqNemRoY
Source used: https://github.com/dvoituron/dotnetconf-2023-fluentui-blazor?tab=readme-ov-file#8-add-themes-colors-dark-and-light

@vnbaaij I was able to solve the problem, thank you 😁


Add catch all code owners for the repo

Add the catch all owners for the repo. In some places we depend on this fallback having an owner (example docs or pipeline ownership) for any paths that do not have a natural owner.
https://github.com/Azure/azure-sdk-for-net/pull/28768#discussion_r891756947_

@weshaggard - Can we confirm behavior to be sure that my mental model is correct? My understanding is that this will essentially end up sending alerts for anything in the repository that doesn't have a more specific path. Assuming that I'm correct, I'm not comfortable having myself here (I'll let Pallavi speak for herself)
I'm still actively working in parts of the repository and rely on GH notifications via email for these. The last I spoke with Alex, he received enough spam from the catch-all notifications that all GH emails were noise to him and were dealt with by filtering into an "ignore" area until someone spoke to him directly. That's not a situation that's going to work for me.
Can we define what areas, specifically, need the leads to watch and add explicit ownership for those areas? Alternately, lets consider creating a GH handle and DG that Pallavi and I can subscribe to which I can use for filtering notifications for catch-all from those that I explicitly opt into.

Moving this conversation over here.
Part of the reason we put the lead(s) as the catch-all is to ensure new directories end-up with owners. Ideally the catch-all wouldn't be noisy once there is a more specific owner path in the file. So if you guys are seeing missing paths then the fix is to add a more specific path and identify the correct owners for that path.
Outside of just being added as code owner in PR reviews other places we use this data is with pipeline failure notifications, and with documentation generation owners. So we really need some way to ensure that this is as complete as possible and we felt the leads would be the best people to help ensure it is complete.

So we really need some way to ensure that this is as complete as possible and we felt the leads would be the best people to help ensure it is complete.

I'm not opposed, in principle.   I'd prefer that we go down the path of creating a GH handle and DG that Pallavi and I can join rather than having this added directly.   That'll allow me to more reliably set Outlook rules and ensure that I don't miss things that I need to see.

We'll try it for now; if it breaks GitHub workflows, I'll remove myself and we can revisit an alias to allow for outlook rules.


Automatically add triage/awaiting to new issues

GitHub Action workflow to automatically add triage/awaiting label on creation of new issues.
Fixes: #8

can you post the working screenshot from your repo with the same action ?

Keeping this on hold as we can implement this functionality using issue form definition too

automatic triage/awaiting label will be achieved with issue templates (PR #18)


docs($httpBackend): enhance readability

In certain parts of the $httpBackend documentation there is a recurring description for $httpBackend methods that I thought reads a bit strange:
"...function that receives the url and returns true if the url match the current definition.".
This is easier to read by changing 'the' to 'a' and 'match' to 'matches':
"...function that receives the a url and returns true if the url match matches the current definition.".

Very nice patch @Yahkob - good change, good commit message - keep them coming!

Thanks @pkozlowski-opensource , will do!


Llama v2 support

Now that Llama has context free grammar integration and can produce valid JSON, we should consider it as an alternative to openai.

https://github.com/go-skynet/LocalAI/pull/726

Added


what kind of image format is read by face_crop.py?

i have created the directories but i could get the mages croped/saved in the destination. please reply fast this is urgent.

I am also getting the problem, when i have run the label.py program through webcam just the face is getting crop and the image saved in the destination and not recognizing the expression.

I didn't use face_crop and just retrained already cropped images I found online. My program works fine. The cropping part isn't very necessary but it does improve the accuracy

No activity for a long time. Closing it now.


add jpgraph

🎉 Feature Request
Summary
how can i add the jpgraph class? Sorry for my English :-(

jpgraph/jpgraph.php

I assume you're talking about this?
https://packagist.org/packages/amenadiel/jpgraph
When you Stroke() your graph, you can add an extra parameter to save it to a file, like $graph->Stroke('/path/to/graph').
Then you can send that file using Request::sendPhoto(['chat_id' => $chat_id, 'photo' => '/path/to/graph']).
Hope that helps!
(I'll close off here, as this is question is not directly related to the library.)

I solved. Thanks :-)


Is there any way to query data through multiple container from Portal?

Hi team,
Is there any way to query data through multiple container from the portal?
I see we can execute query for each container like below, but couldn't find the way to query through multiple containers.

I think above scenario is required when we query the container which data schema is normalized. (Need to use JOIN to get full data)
If there's a way to achieve that, it would be helpful to mention in the doc..!
Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25251833-0b7d-c2cf-9800-337ad6501b7c
Version Independent ID: f587f508-7eaa-777e-d0e1-79f248f474c7
Content: Query containers in Azure Cosmos DB
Content Source: articles/cosmos-db/how-to-query-container.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @markjbrown
Microsoft Alias: mjbrown

@yutaro113 Thank you for the feedback. We are actively investigating and will get back to you soon.

You can't query multiple containers under any circumstances whether via the portal or the SDKs.
Cosmos DB is a NoSQL database. It does not support relational constructs like joins.
Worth checking out a few resources that can help you learn how to design for this type of database.
Take a look at all the docs here
https://docs.microsoft.com/en-us/azure/cosmos-db/modeling-data
Then these two MSL Modules
https://docs.microsoft.com/en-us/learn/modules/model-partition-data-azure-cosmos-db/
https://docs.microsoft.com/en-us/learn/modules/advanced-modeling-patterns-azure-cosmos-db/
Great session from Ignite 2019
https://www.youtube.com/watch?v=utdxvAhIlcY

@markjbrown Thanks for providing the detailed response.
@yutaro113 We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

@AnuragSharma-MSFT , @markjbrown ,
Thank you very much for the quick confirmation and sharing related documents also!
Understood it's not supported via both Portal and SDK due to NoSQL design concept.


Make home-manager and deploy-rs integrations optional

another step towards #137
Right now its very hard to remove devos's home-manager or deploy-rs integration and leaving the inputs is not optimal as it means you will download more code and it will increase your evaluation time.
So the goal is to only add the relevant outputs, and set the options if the each input exists.
The default integrations are really nice and make life easier, but its important to allow them to be removed.
I would also like to set the precedent for future integrations added into devos to be made optional with similar methods:

Don't add a package unless it exists, ex: pkgs ? deploy-rs
Don't set an option unless it exists, ex: options ? home-manager. This one is tricky, it can't be done with mkIf. You have to use a combination of mkMerge and optionalAttrs, the former is usually necessary when your setting other things and the same module and you want to set an option that might not exist. See changes in devosSystem and mkHosts for examples.
Don't export an output that depends on a specific input, unless the input exists: ex: inputs ? deploy
Don't test relevant outputs unless they exist, ex: self ? homeConfigurations. Not sure what to do about this one though, most tests are tightly integrated with devos.

Does process on https://github.com/gytis-ivaskevicius/flake-utils-plus/pull/18 feed any information backnon this?

I actually did that PR with knowledge I gained from working on this.

Just realized, once we implement config generators in a lib, that lib ought to bring its own dependencies. The use of deploy-rs or home-manager will then be optional be the way the user interfaces with that lib's api.

I think the code in mkHosts, is relevant, where we set the home-manager defaults if the option exists. And there are a couple other things, that are useful, for example deploy might not be in the users packages, so we don't want to add it to shell, unless it exists.

Is this still an issue/needed?

We should put it on-hold until we have devos lib and clarity of which delendency can be expected where, we might esle get dead code out of this while refactoring.

Yeah most of this is unnecessary with the move to pkgs-lib. I think we have now forced lib to depend on deploy-rs.
But I do want to keep this PR for the goal of making home-manager to be optional. I think my other goal for this PR was to have a demonstration of how integrations can be optional to encourage it in the future.

planning to rework how mkHosts works, so I might include something similar in that PR. But we'll see where it goes.


Fix build for C++20, Fix #53

As reported in #53:
C++20 removed the deprecated std::result_of in favor of
std::invoke_result.
Switch between usage of those depending on the cpp_lib_is_invocable
feature test macro.
See:

https://en.cppreference.com/w/cpp/types/result_of
https://en.cppreference.com/w/cpp/feature_test#Library_features

An alternative solution would be to use decltype instead of either of those two templates,
if you prefer that I'd be happy to update my PR.

Hi, I need P.R. merged to use clipp in a C++20 project. What is blocking merging it?

please consider merging this pr

If you use vcpkg then this patch is being applied care of microsoft/vcpkg#27167

the patch still doesn't fix the compilation. i still get this error with c++20
Severity	Code	Description	Project	File	Line	Suppression State
Warning	C26495	Variable 'clipp::group::child_t<clipp::parameter,clipp::group>::data::group' is uninitialized. Always initialize a member variable (type.6).		 Always initialize a member variable (type.6).	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	2772
Warning	C26495	Variable 'clipp::group::depth_first_traverser::memento::level_' is uninitialized. Always initialize a member variable (type.6).	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	2831
Warning	C4003	not enough arguments for function-like macro invocation 'max'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	332
Warning	C4003	not enough arguments for function-like macro invocation 'max'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	333
Error	C2589	'(': illegal token on right side of '::'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	332
Error	C2589	'(': illegal token on right side of '::'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	5909
Error	C2589	'(': illegal token on right side of '::'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	6324
Error	C2062	type 'unknown-type' unexpected	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	6324
Error	C2059	syntax error: ')'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	6324
Error	C2589	'(': illegal token on right side of '::'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	6734
Error	C2062	type 'unknown-type' unexpected	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	6734
Error	C2059	syntax error: ')'	C:\dev\vcpkg\installed\x86-windows-static\include\clipp.h	6734

@danyhm That's a different error that you have.
Maybe you can try https://github.com/GerHobbelt/clipp as that seems to be more up to date.


Breathweapon

In this branch I've added the breath weapon back.
I also added a dragon orb - when you point the orb at a target object (creature, block, or a direction) your tamed dragon will move towards the target and breathe fire at the target when it is in range.
The fire weapon will affect any blocks or entities it collides with-

after short exposure, will set fire to flammable objects
will burn grass to dirt
after longer exposure, will smelt blocks (eg sand -> glass)
after even longer exposure, will turn non-smeltable blocks into lava

The code is designed so that different effects can be added for different breath weapons (for example - ice shards for ice dragon; strong wind gusts for aether dragon etc).  Haven't added these yet!
In the next few days I will put some documentation together on the class structure of the new breath weapon code I added.
I've tested the code on multiplayer and also on dedicated server, it seems to work ok.
A couple of strange things still - eg when the dragon lands in water it gets confused - but no serious glitches that I found yet.
The next things I was thinking of working on- in no particular order-

different breath types
making the dragon semi-transparent so you can aim more easily while riding him
fixing the land-in-water problem
adding AI for the dragon to fly around without a rider.

Quick suggestion: Aether dragon lightning breathweapon?

Also, might want to squash those commits a bit.

Well, I'll be damned, that's a lot of commits! And it appears to be in conflict with the main branch. I think I may have to pull that into a testing branch first and go through all that code before putting that into main. I also have to make sure it's not stressing the server too much, I'm curious how you solved that problem.

Hi
Yeah it is a lot of commits, should have squashed first, sorry.
One of the last things I did was to merge from the main branch of your master, so hopefully there are no major conflicts, but it didn't go 100% smoothly and I think you've made a couple more commits since then, which might be the reason for the conflict you saw.
There isn't much communication between the client and the server.
Client sends the current target (eg entityID) to the server, which keeps track of all players' targets and sends them to other clients (via DataWatcher on the corresponding dragon entity) when the dragon starts breathing.  That's the only network traffic related to the breath weapon, i.e. ranging from ten bytes per second to a few hundred bytes per second.
The spawning of EntityFX on the client is done locally based on the DataWatcher target.
The collision calculations between the breath weapon and nearby blocks+entities are done by the server and the results (damage etc) are synchronised to the clients by vanilla; but there is no Entity or EntityFX information exchanged between the two.  The collision calculations themselves have a couple of basic optimisations to speed them up and in my profiling tests they took negligible time - but my machine is pretty quick so doing those tests on your side is probably a good idea!
Briefly how it works:
On client:
DragonOrbControl monitors user input and sends a DragonTargetMessage to the server when the player's target has changed.
On server:
Receives DragonTargetMessage, caches the corresponding BreathWeaponTarget locally (in  DragonOrbTargets)
DragonBreathHelper then uses AI to move the dragon to an appropriate range and to start breathing when ready - the breathing target is sent to nearby clients using a DataWatcher on the dragon.
Back on client:
DragonBreathHelper for each each dragon retrieves the current target from the DataWatcher, then spawns the breath using
BreathWeaponEmitter, which creates a stream of FlameBreathFX for rendering & collision, each with a corresponding BreathNode to model the size, aging, power etc of each FlameBreathFX.
Meanwhile on the server, the effects of the breath weapon are modelled by creating a stream of EntityBreathNodes with corresponding BreathNodes, similar to the client.  (The EntityBreathNodes are not spawned, just stored in a collection).  Collision detection is performed between the EntityBreathNodes and the blocks and nearby entities - once a block or entity has suffered enough collisions with nodes, it takes damage / gets smelted / etc.
The main classes modelling this are DragonBreathHelper, BreathWeapon, BreathNode, EntityBreathNode, BreathAffectedBlock/Entity
The collision detection is in BreathAffectedArea and NodeLineSegment.
Adding new types of breath is intended to be done by overriding
BreathWeapon,
BreathWeaponEmitter, with different equivalents for FlameBreathFX.
BreathNode
but not all the classes implement this fully yet (for example, BreathAffectedArea will need to use BreathWeapon to spawn BreathNodes with the correct speed and size; BreathNode is currently hard-coded values).
Pretty much all the other changes to the code are related to making sure the breath weapon nodes spawn from the dragon's mouth - which is affected by yaw and pitch and size etc - so I moved the positioning code into a common class for both server and client.  That was pretty fiddly to get right.
Oh and I changed from a config file to a config screen - should have put that in a separate branch, sorry about that, didn't think of it until later.
-TGG

You changed the code formatting in some existing classes, I think that's one of the reasons why there are conflicts now. But it can be fixed easily.

Okay, I did some initial testing and I must say... I'm impressed. Good job! :+1:
Can you please also generate a short list of the most relevant changes for the changelog?

Thanks :)  It was good fun that's for sure.
Changelog:

Gave all dragons the ability to breathe fire
Added a "dragon orb" item- a player can point the orb at a target and his/her tame dragons will breathe at it.  (Crafting recipe is an ender eye on top two blaze rods - similar shape to crafting a shovel)
Implemented configuration GUI

Is that what you need?
Cheers
TGG

Yep, pretty much, but I think there are more changes for the AI. Or are these for the orb only?

I just had a look at the diff and you're right, there are a few minor tweaks to some of the AI,  they are all refactorings without symptoms except for

a couple of new AI related to the orb, plus
-minor change to altitude control when riding the dragon - the dragon altitude is now controlled only by the R and F keys, not by where the player is looking.  (The player look only affects yaw).  I did this because my dragon kept crashing into the ground when I was using the orb while flying...

Hi
Just a question - do you have a timeline for merging this branch?  I'd like to continue with the other breath types, but I'd prefer to fork it from your merge rather than mine.
Also, do you plan to release it?  If not, would you mind if I post it separately as an "extension" of yours?
Cheers
TGG

I'm not yet sure if it's ready to be merged into main. I've yet have to do some testing on dedicated servers to make sure it's working there, too. I planned to release it as a side built for testing first, but since you want to continue working on it, I'll merge it now.

keen, thanks!
-TGG


Notify the FAILURE of handling event by Event Watcher

What would you like to be added:
It would be nice to notify the failure to handle the event by the Event Watcher.
Why is this needed:
This is because Event Watcher's event handling is connected from the subsequent Deployment.

/assign @peaceiris

Links

notifyDeploymentTriggerFailed() https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/trigger/trigger.go#L492

Hi @peaceiris, just want to gently ping 😄 Any update on this task? 👀

No updates 😢


Document for generator should clear some step.

http://labs.infyom.com/laravelgenerator/docs/5.8/boilerplates
I read the guide is not clear about step buy step for install fress copy.
Pls show some step in detail for beginner

@quangtynu boilerplates do not need any setup. All installation steps are already done in that.

So pls di like that.

Git clone... Command
Cd to ... Command
Run update... Command
Run php artisan serve .. Commanf
Login user, pass
Localhost:8000????
I mean for beginner.

Yes. do not forget to setup your env.


Print locations using line / col instead of offsets

This commit changes printing of locations to use the format (start_line,start_column)-(end_line,end_column) instead of using offsets.

A more concise format that RubyVM::AST uses is 1:0-1:9, but I think the format in this PR is easier to read :+1:
Columns are currently in number of bytes, that seems the case for RubyVM::AST too.
I think it's fine internally but e.g. in an editor it might not match for a UTF-8 file with non-ASCII characters.

@jemmaissroff could you look into the memcheck failure? Weird that it's failing on this, but I'm hoping it's surfacing something we can fix. I've found spin to be the best way to get access to valgrind.


Fix Enum.NaE test (add test.end())

As I said here https://github.com/metarhia/common/issues/169#issuecomment-414145340, this test wasn't working.

Landed in 7ebab584d1e5149dda8032a59a8faa06839d0099.


Fix #32

siaddr: IP address of next server to use in bootstrap;
Returned in DHCPOFFER, DHCPACK by server.

Yes, siaddr is used for setting the "next server to use in bootstrap".  Not manually setting the value in code will mean that Go sets it to zero - a perfectly valid siaddr.  Additionally, the client doesn't know what the siaddr should be, so mirroring the value set by the client isn't a good idea.
Your change is 'mostly harmless' as valid clients will set their siaddr to zero, but I'd rather not exacerbate problems of poorly written clients.  At best, this makes the code slower.
Please email me, if you want to discuss further.


Change Image Checking Phase to be Faster

Checking the images even if they were already built by a previous Cerberus invocation can take many hours. There should be a way to speed this up -- perhaps by making fewer calls to the Docker API

Fixed in dev, commit a00a21a0ebc


Shorthand Commands

The only commands that have the same first initial is "wtf" and "whereami" so maybe something for them?
"h" for "help"
"k" for "kill"
etc.

Would this be a better alternative then the autocomplete that comes with it now?


There are some problems with the  read3bits  function

In the opendesign specification,  3B is a sequence of 1 to 3 bits. Keep reading bits until a zero bit is encountered or until the 3rd bit is read, whatever comes first.
The implementation of the read3bits function in libredwg project is blow.
/** Read 1-3 bits
 *  Keep reading bits until a zero bit is encountered, => 0,2,6,7.
 *  0: 0, 10: 2, 110: 6, 111: 7. 100 for 4 or 101 for 5 is invalid.
 */
BITCODE_3B
bit_read_3B (Bit_Chain *dat)
{
  BITCODE_3B result = bit_read_B (dat);
  if (result)
    {
      BITCODE_3B next = bit_read_B (dat);
      if (next)
        {
          next = bit_read_B (dat);
          return next ? 7 : 6;
        }
      else
        {
          return 2;
        }
    }
  else
    {
      return 0;
    }
}

Hi @CraneXHu,
The method read3Bits is only used to read a BitLongLong, which is only used in the dwg files with version higher than AC1024, the thing is that in the BitLongLong all 3 bits are needed to read the length of the number, so the 3bits are documented to be read as you say if the file requires it, but this method is not used at all to read the file. Notice that in my code this method is private.
I've looked in librecad and they have a similar issue with that :
bit_read_3BLL (Bit_Chain *dat); /*unused but as documented*/

I'm guessing that this method is there only for the documentation but is not used at all, if they where to use it as the way is written it would fail when reading the BitLongLong length.

@DomCR
I see. Thank you for your reply.


Add license field to package.json

Fixes #6

@tj friendly ping. issue with license checkers is still relevant.


static bing map fix

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] The code follows the code style and conventions of this project.
[ ] The change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

Description of the change
Static Bing Map fix.
...
Motivation for the change

...

@swetha571,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


UX - .tick.thick & calendar year

Extremely minor, but to improve UX / reduce mis-reading of the gantt chart, in monthly view most viewers expect quarters to align with calendar years (eg .tick.thick applied between Dec/Jan, not between Nov/Dec, etc).  Or at least for there to be an additional .tick.extra-thick at the end of calendar years in all views.

Hey - there are already extra thick lines between quarters in the month view. We'll make them more prominent in the upcoming UI revamp.


Thumbnails Should Remain Optional

There are valid reasons why people wouldn't need thumbnails such as if they are uploading archives. LBRY is a file agnostic client therefore for that reason alone it should be optional.

I will work on this.

@ByronEricPerez Do you Still intend to do this?

Hi @ismail6172,  you mean this right?

This is done. Wanted to get it out.

Hello @jessopb , I did not understand your message, do you ask me if I finished it, or did you tell me that it is already finished?

It's all set. I wasn't sure when you'd get to it.


The last character of a string is not colored when while typing

VSCode Version: Code - Insiders 1.6.0-insider (0f7880d7a490ba9aee2b053f3f2e46c19423e7e4, 2016-09-29T14:13:08.930Z)
OS Version: Linux x64 4.4.0-38-generic, Ubuntu 16.04
Theme: Tyriar.theme-glacier-0.0.10

This is happening because the last character is marked as invalid: token string quoted single ts meta function block var expr var-single-variable arrow invalid illegal newline. I guess it's intentional and could be a good thing. Themes can always change.