build fairseq2n fails with "undefined reference to `_gfortran_etime@GFORTRAN_8'"

Describe the bug:
I am trying to install fairseq2 from source using the instruction but getting a fail when building fairseq2n.
Describe how to reproduce:
Env: scratch docker image for python:3.11
> uname -a
Linux 582069085efd 5.15.49-linuxkit-pr #1 SMP PREEMPT Thu May 25 07:27:39 UTC 2023 aarch64 GNU/Linux

apt install -y libsndfile1 libsndfile-dev
git clone --recurse-submodules https://github.com/facebookresearch/fairseq2.git
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu
cd fairseq2
pip install -r fairseq2n/python/requirements-build.txt
cd fairseq2n

> cmake -GNinja -B build

-- Module support is disabled.
-- Version: 9.1.0
-- Build type: RelWithDebInfo
-- CXX_STANDARD: 14
-- Required features: cxx_variadic_templates
CMake Deprecation Warning at third-party/kaldi-native-fbank/CMakeLists.txt:24 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Yes, lib is installed
libgfortran5 is already the newest version (12.2.0-14).

@Kryzpoo ok, just realized that you are on ARM64. Looks like the PyTorch wheel has additional dependencies under "/usr/local/lib/python3.11/site-packages/torch.libs" that do not exists on x64. Let me try to find an ARM machine to test this out.

@Kryzpoo see #222. Thanks for the bug report!


"Must provide document"

Description
When you try to call a graphql route with the incorrect Content-Type the server replies with the follow :
{"errors":[{"message":"Must provide document"}]}

Intended outcome
The error message is misleading and makes it hard to debug.
Hopefully this is the right place for this issue.

I don't think this is the right repo for this. Can you open it on whatever graphql server library you're using? Thanks!


Balance tweaks for the SSG

Some people find it unfair that it's capable of two-shot killing innocents and the vote results are in favor of tweaking it to address it.
One potential idea is to just lower the damage of the ssg to make it impossible to bring a fully healed innocent down to 0 health.

At the moment, the breathing effect is disabled, but not removed.

https://github.com/Dox778/WhoDunIt-Reloaded/commit/7f2d308876f653c2c378a16c45dc15506548b61a

Done https://github.com/Dox778/WhoDunIt-Reloaded/commit/39c0ef0eef6389de43889e31f360b4ef2a1d9358


HBASE-27078 Allow configuring a separate timeout for meta scans (branch-2 backport)

First commit is a cherry-pick from master branch, with some minor conflict resolution.
Second commit re-implements for the blocking client. For this, part of the complexity is that the rpc timeout needs to be pushed way down into ResultBoundedCompletionService's RetryingRpcCaller. What I have now seems like the cleanest way to achieve that, doing the isSystemTable() check in TableBuilder, then passing down into ClientScanner constructors, ScannerCallble constructors, etc. We already had this pattern for replica timeout, but it now adds rpcTimeout and scannerTimeout.
Another piece of complexity, covered by my 3rd commit, is that unfortunately in branch-2 scans use hbase.rpc.timeout instead of hbase.read.rpc.timeout. If anyone thinks its allowed, I'd love to fix that. But I assume it's not allowed, so the 3rd commit handles the case that we want to use hbase.rpc.timeout for normal scans and hbase.client.meta.read.rpc.timeout for meta scans. This will be unified in 3.0.0 where scans will use hbase.read.rpc.timeout and hbase.client.meta.read.rpc.timeout for both AsyncTable and Table.
The tests needed minor changes, mostly to support the different semantics of scanner next() timeouts in blocking client. More details in a comment of testNormalScanTimeoutOnNext

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 25s
branch-2 passed

+1 :green_heart:
compile
2m 58s
branch-2 passed

+1 :green_heart:
checkstyle
0m 50s
branch-2 passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  6s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  3s
the patch passed

+1 :green_heart:
compile
2m 57s
the patch passed

+1 :green_heart:
javac
2m 57s
the patch passed

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 44s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

31m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux bbfbbc2c912f 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bd08ebb21c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 28s
branch-2 passed

+1 :green_heart:
compile
0m 51s
branch-2 passed

+1 :green_heart:
shadedjars
3m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
3m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
1m  5s
hbase-client in the patch failed.

-1 :x:
unit
182m 51s
hbase-server in the patch failed.

202m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 66990c9711d6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bd08ebb21c

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/testReport/

Max. process+thread count
2516 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 15s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 21s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
3m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 15s
hbase-client in the patch failed.

-1 :x:
unit
182m 16s
hbase-server in the patch failed.

203m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f21f8e3372f1 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bd08ebb21c

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/testReport/

Max. process+thread count
2627 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  6s
branch-2 passed

+1 :green_heart:
compile
2m 58s
branch-2 passed

+1 :green_heart:
checkstyle
0m 48s
branch-2 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 59s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

+1 :green_heart:
javac
2m 56s
the patch passed

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 34s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

33m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux b2f8fbbb4647 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bd08ebb21c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 27s
branch-2 passed

+1 :green_heart:
compile
0m 51s
branch-2 passed

+1 :green_heart:
shadedjars
3m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  1s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
shadedjars
3m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
1m  5s
hbase-client in the patch failed.

-1 :x:
unit
183m  7s
hbase-server in the patch failed.

202m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cd21103dc4cc 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bd08ebb21c

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/testReport/

Max. process+thread count
2452 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
branch-2 passed

+1 :green_heart:
compile
1m  0s
branch-2 passed

+1 :green_heart:
shadedjars
3m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
3m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 15s
hbase-client in the patch failed.

-1 :x:
unit
181m 57s
hbase-server in the patch failed.

202m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fd013fdf7c32 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / bd08ebb21c

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/testReport/

Max. process+thread count
2702 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  8s
branch-2 passed

+1 :green_heart:
compile
2m 55s
branch-2 passed

+1 :green_heart:
checkstyle
0m 48s
branch-2 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  0s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 31s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

31m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 2e97de992f99 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e4d2895cad

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
60 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  2s
branch-2 passed

+1 :green_heart:
compile
0m 52s
branch-2 passed

+1 :green_heart:
shadedjars
3m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  3s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
shadedjars
3m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 29s
hbase-client in the patch passed.

+1 :green_heart:
unit
182m 12s
hbase-server in the patch passed.

202m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d94ba066028e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e4d2895cad

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/testReport/

Max. process+thread count
2403 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
branch-2 passed

+1 :green_heart:
compile
1m  1s
branch-2 passed

+1 :green_heart:
shadedjars
4m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
3m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 51s
hbase-client in the patch passed.

+1 :green_heart:
unit
180m 46s
hbase-server in the patch passed.

202m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d44182f9d5cf 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e4d2895cad

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/testReport/

Max. process+thread count
2584 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

that unfortunately in branch-2 scans use hbase.rpc.timeout instead of hbase.read.rpc.timeout. If anyone thinks its allowed, I'd love to fix that.

It is directly fixable in branch-2.5 and branch-2. Just do something like
# Use `hbase.read.rpc.timeout`. Fall back to `hbase.rpc.timeout` if not configured.
readTimeout = conf.getLong("hbase.read.rpc.timeout", conf.getLong("hbase.rpc.timeout", DEFAULT));

When resolving the JIRA add a release note so docmaker will pick up a note about the change.
For branch-2.4, agree, I don't think we should touch it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/4585 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4585

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/4/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 16s
branch-2 passed

+1 :green_heart:
compile
2m 58s
branch-2 passed

+1 :green_heart:
checkstyle
0m 49s
branch-2 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  1s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
2m 59s
the patch passed

+1 :green_heart:
javac
2m 59s
the patch passed

+1 :green_heart:
checkstyle
0m 48s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 41s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

31m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux e8a2705f8a7c 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b543da974a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
65 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 53s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 16s
branch-2 passed

+1 :green_heart:
compile
0m 51s
branch-2 passed

+1 :green_heart:
shadedjars
3m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  3s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
3m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 29s
hbase-client in the patch passed.

+1 :green_heart:
unit
187m  7s
hbase-server in the patch passed.

208m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f663aae74444 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b543da974a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/testReport/

Max. process+thread count
2423 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
branch-2 passed

+1 :green_heart:
compile
1m 10s
branch-2 passed

+1 :green_heart:
shadedjars
3m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
3m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 59s
hbase-client in the patch passed.

-1 :x:
unit
256m 39s
hbase-server in the patch failed.

280m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4585

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e7eb72ef74de 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b543da974a

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/testReport/

Max. process+thread count
2335 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4585/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Application vs Library for SDK-based packages

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/278
Originally created by @edgarrmondragon on 2021-11-23 18:03:35

I want to start the conversation around our (recommended) packaging strategy for SDK-based taps and targets.
A recent conversation in Slack revealed that installing SDK-based taps (e.g. pipx install git+https://github.com/MeltanoLabs/tap-github.git) references the specified dependency versions in pyproject.toml and completely ignores the pinned versions in poetry.lock.
The most relevant discussions around using Poetry to distribute end-user Python applications (like Singer Taps) is happening here and in this PR.

View 6 previous comments from the original issue on GitLab

Still relevant. It's probably worth recommending in the connector developer docs to pin minor versions for tap and target dependencies.

Recently @WillDaSilva pointed me to https://github.com/spoorn/poeblix


Fix image reference in Helm chart

Description of changes:
The public.ecr.aws/aws-controllers-k8s/controller repository is deprecated, and the elasticache-v0.0.4 tag doesn't exist.
This PR updates the default image repository to public.ecr.aws/aws-controllers-k8s/elasticache-controller.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm

thanks @haines! :)

/ok-to-test


Unable to run Embedded Project in latest firefox(114.0b6)

Describe the bug

embedded edtior in https://tanstack.com/router/v1/docs/examples/react/basic?file=src%2Fmain.tsx fails to load.
Link to the blitz that caused the error
https://stackblitz.com/edit/tanstack-router-5h9bdr
Steps to reproduce

Visit https://tanstack.com/router/v1/docs/examples/react/basic?file=src%2Fmain.tsx
Editor fails to load.
Press fork on stackblitz:
Forked editor works.

Expected behavior
Embedded editor works.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform

OS: Linux (Ubuntu 23.04)
Browser: Firefox Developer
Version: 114.0b6

Additional context
No response

Unfortunately, this is expected:
https://developer.stackblitz.com/platform/webcontainers/browser-support#embedding

we only support embedding WebContainers-based projects in Chromium-based browsers.


Add join example between taxonomy term and article

For a taxonomy term page, instead of getting all the articles and filtering them down, you can use a Fragment (or Inline Fragment) to join data between two collections. The relationship already exists thanks to JSON API so we can take advantage of that.

Thanks for the PR @btmash :)
Just a minor comment; can you use $id as variable instead and remove the alias?
- query Tag($path: String!) {
-   tag: drupalTaxonomyTermTags(path: $path) {
+ query Tag($id: ID!) {
+   drupalTaxonomyTermTag(id: $id) {

GraphQL can be a bit overwhelming for some, so we try to keep the examples as simple as possible.
And I see that $id is String! in other query examples. It would be great if you are able to change them to ID! too.

Thanks for the feedback @hjvedvik! I'd used path as my way to filter by the route I was on and id had been unclear as I was trying to put things together. But I've changed it over to that and added a small note to explore graphql to see what you can filter on and how to figure out what properties you want.


PSP IS⊙IS instruments cause "invalid character"

speasy version: 0.1.0 (?)
Python version: 3.9.7
Operating System: Ubuntu 20.04.3 LTS

Description
When trying to address data of Parker Solar Probe's (PSP) particle instruments "IS⊙ISEPI_Hi" or "IS⊙ISEPI_Lo" via dynamic inventory, the special sign "⊙" causes a SyntaxError: invalid character.
What I Did
First create a clean Python 3.9 environment with conda, install latest speasy version from git via pip, and start python:
$ conda create --name speasy python=3.9
$ conda activate speasy
$ pip install git+https://github.com/SciQLop/speasy
Collecting git+https://github.com/SciQLop/speasy
  Cloning https://github.com/SciQLop/speasy to /tmp/pip-req-build-lvjo1tfp
  Running command git clone -q https://github.com/SciQLop/speasy /tmp/pip-req-build-lvjo1tfp
  Resolved https://github.com/SciQLop/speasy to commit 27b9e6c32e890c3bba5d9681459b6a3ffc7e5664
[..]
Successfully installed Click-8.0.3 PyYAML-6.0 appdirs-1.4.4 astropy-5.0.1 attrs-21.4.0 cached-property-1.5.2 charset-normalizer-2.0.11 diskcache-5.4.0 idna-3.3 isodate-0.6.1 lxml-4.7.1 numpy-1.22.1 packaging-21.3 pandas-1.4.0 platformdirs-2.4.1 pyerfa-<IP_ADDRESS> pyparsing-3.0.7 python-dateutil-2.8.2 pytz-2021.3 requests-2.27.1 requests-file-1.5.1 requests-toolbelt-0.9.1 six-1.16.0 speasy-0.9.0 spwc-0.9.0 urllib3-1.26.8 xmltodict-0.12.0 zeep-4.1.0
$ python

Then in python:
Python 3.9.7 (default, Sep 16 2021, 13:09:58)
[GCC 7.5.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import speasy as spz
>>> amda_tree = spz.inventory.data_tree.amda

>>> amda_tree.Parameters.PSP.FIELDSMAG
AMDAPathIndex(name='FIELDS MAG', desc='Fluxgate magnetometer (MAG) of the FIELDS suite
Magnetometer', xmlid='PSP_mag', att='auto/PSP_mag', is_public=True, psp_mag_1min=<DatasetIndex: 1min>, psp_mag_4cyc=<DatasetIndex: 4/cyc>, Venusflybys=AMDAPathIndex(xmlid='psp-venus-flybys', name='Venus flybys', is_public=True, psp_mag_vflyby1=<DatasetIndex: Venus flyby #1>, psp_mag_vflyby2=<DatasetIndex: Venus flyby #2>, psp_mag_vflyby3=<DatasetIndex: Venus flyby #3>, psp_mag_vflyby4=<DatasetIndex: Venus flyby #4>), psp_fld_qfl=<DatasetIndex: quality flag>)

>>> amda_tree.Parameters.PSP.IS⊙ISEPI_Hi
  File "<stdin>", line 1
    amda_tree.Parameters.PSP.IS⊙ISEPI_Hi
                               ^
SyntaxError: invalid character '⊙' (U+2299)

>>> amda_tree.Parameters.PSP.IS⊙ISEPI_Lo
  File "<stdin>", line 1
    amda_tree.Parameters.PSP.IS⊙ISEPI_Lo
                               ^
SyntaxError: invalid character '⊙' (U+2299)

>>> amda_tree.Parameters.PSP.IS0ISEPI_Lo
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'AMDAPathIndex' object has no attribute 'IS0ISEPI_Lo'

>>> amda_tree.Parameters.PSP.ISOISEPI_Lo
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'AMDAPathIndex' object has no attribute 'ISOISEPI_Lo'

>>> amda_tree.Parameters.PSP.ISoISEPI_Lo
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'AMDAPathIndex' object has no attribute 'ISoISEPI_Lo'

Running amda_tree.Parameters.PSP.FIELDSMAG just to verify that it works in general. Trying to replace "⊙" with "0/O/o" doesn't solve the problem.

@jgieseler Nice catch, this indeed come from an incomplete manual sanitizing of such names here.
I didn't find a better solution at that time...
I'll push a fix ASAP. The fun thing here is that you can generate invalid python names using __dict__ but there is no way to use them afterwards (except using __dict__).

@jgieseler if you want to try the fix, you can install what will be the 0.10.0 with
pip install<EMAIL_ADDRESS>

Yes, that seems to work!
>>> import speasy as spz
>>> amda_tree = spz.inventory.data_tree.amda
>>> amda_tree.Parameters.PSP.ISoISEPI_Hi
AMDAPathIndex(name='IS⊙IS EPI-Hi', desc='Energetic Particle Instrument Hi-Energy
SolidStateDetector', xmlid='PSP_epihi', att='auto/PSP_epihi', is_public=True, HET=AMDAPathIndex(xmlid='psp-isois-het', name='HET', is_public=True, psp_het_1hr=<DatasetIndex: HET 1h>, psp_het_1min=<DatasetIndex: HET 1min>), LET1=AMDAPathIndex(xmlid='psp-isois-let1', name='LET1', is_public=True, psp_let1_1hr=<DatasetIndex: LET1 1h>, psp_let1_1min=<DatasetIndex: LET1 1min>), LET2=AMDAPathIndex(xmlid='psp-isois-let2', name='LET2', is_public=True, psp_let2_1hr=<DatasetIndex: LET2 1h>, psp_let2_1min=<DatasetIndex: LET2 1min>))

And I think it's not really a problem; I've seen it written with an "o" already somewhere else. Even the instrument team has to use this workaround for its URL: https://spp-isois.sr.unh.edu 😉


Add translation of CDS

Allow for the input of CDS besides protein sequences

Hi,
Any progress? I want to use mantis to annotate a non-model species transciptome sequences.
Best,
Kun

Currently working on it, it should be ready within this/next week.
Regards,
Pedro


Broken link on Scientific Computing with Python project pages

Affected pages
The link to the Learn Python Video Course is broken on these  pages:

Arithmetic Formatter
Time Calculator
Budget App
Polygon Area Calculator
Probability Calculator

Your code

Expected behavior
When a user clicks on the link "Learn Python Video Course", the home page for the course should be displayed.
Screenshots

System

Device: laptop
OS: macOS Catalina 10.15.7
Browser: Chrome
Version: 96.0.4664.55

Additional context

It is working fine you can check now

I checked again and still get a 404 error for the Learn Python Video Course link on all the project pages.

None of them are broken anymore

I tried the links again and still got 404.  I might not have been clear in my initial issue report. These are the steps I take to reproduce the error:

Go to the Arithmetic Formatter project page.
Click the link Learn Python Video Course  (10 hours).
A 404 page is displayed.

I've cleared my cache and tried different browsers, but I get the same result. If the Learn Python Video Course vi no longer exists, consider removing the link from the project pages.

I am getting this problem too.

@beaucarnes I am not actually sure which resource this is/was supposed to link to. Do you have any idea what happened here?

The missing link is for an article. I think this is the new link for the article: https://freecodecamp.org/news/learn-python-basics-in-depth-video-course/
Someone must have changed the link URL to get better SEO but didn't realize it was in the curriculum.
My suggestions is that we remove that link completely. I think we should remove the following text from all of the challenges linked above:
`We are still developing the interactive instructional part of the Python curriculum. For now, here are some videos on the freeCodeCamp.org YouTube channel that will teach you everything you need to know to complete this project:
Python for Everybody Video Course (14 hours)
Learn Python Video Course (10 hours)`
I think we included that text BEFORE we actually added those very video courses into the curriculum. There is no reason to have that text now since students following the curriculum will already have seen those courses as part of the curriculum.
Do others agree with this?

Do others agree with this?

Yes, I am happy to have that text removed. I cannot imagine it is used/needed much by Campers who have reached the projects page.

@raquelocasio The Curriculum File Structure page should help.


Error in parsing value for ‘all’.  Declaration dropped. org-capture-extension:1:13

Hi,
after upgrading firefox, the extension doesn't work.
Before that everything was working without problem.
Manual saving with bookmarklet works.
javascript:location.href = 'org-protocol://capture?template=p&url='+encodeURIComponent(location.href)+'&title='+encodeURIComponent(document.title || "[untitled page]")+'&body='+encodeURIComponent(document.getSelection())

info
OS: Linux mint 21.1 vera
Firefox 112.0.1 (64-bit)
org-capture extension version 0.2.1
emacs 29.0.60
The error in console is:
Error in parsing value for ‘all’.  Declaration dropped. [org-capture-extension:1:13]
(https://github.com/sprig/org-capture-extension)

test url 1 works:
emacs-capture "org-protocol://capture?template=p&url=https://www.reddit.com&title=ttt"
Waiting for Emacs...

emacs-capture
#!/bin/bash
emacsclient --socket-name=/run/user/1000/emacs/test "$@" 2> /tmp/eclient_error || (emacs --daemon=test && emacsclient -nc -s /run/user/1000/emacs/test)

test url 2 works:
emacsclient --socket-name=/run/user/1000/emacs/test  "org-protocol://capture?template=p&url=https://www.reddit.com/r/Python/comments/12tr2sn/pythoneers_here_what_are_some_of_the_best_python&title=ttt"
Waiting for Emacs...

A bit late; I cannot reproduce this on Firefox 129.0.2 on MacOS.
Since I cannot reproduce and so much time has passed, I will close the ticket but feel free to reopen if you are still experiencing problems.


Use GitHub actions for CI

Signed-off-by: Daniel Egger<EMAIL_ADDRESS>

r? @Emilgardis
(rust_highfive has picked a reviewer for you, use r? to override)

@rust-embedded/tools This is ready now. For now this only adds GitHub actions as a the missing second factor on all PRs. It's not only much faster than Travis but also not taking up any shared resources. And there's still room for optimisation.
Ultimately I'd like to get rid of Travis altogether but that's up for a separate PR/discussion.

We discussed the details quite a bit on the matrix channel. Probably the most GHA experienced person in the team is @adamgreig.

Generally LGTM, thanks for doing this!
on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

I'm not sure about this. I think your intent is to stop GHA building the commit in a PR and then immediately building again once it's merged to master, but I think what actually happens here is only pushes to the master branch (including merging a PR) and only PRs targeting the master branch (most but not all PRs) will get CI. However that means PRs to non-master branches get no CI which doesn't seem desirable. Additionally, we use bors in svd2rust, which requires that CI runs on staging and trying branch pushes, so at the minimum those should be in here. None of this is really all that well documented and I know GHA does various clever things for you (including automatically testing merge commits instead of the PR tip), but I don't know exactly which clever things. I'd suggest for now we try:
on:
  push:
    branches: [ staging, trying, master ]
  pull_request:

And if we then find this does too many builds, look in to reducing them. We could also remove pull_request: to only trigger builds on bors try rather than automatically on all PRs.
I noticed we also use Travis to build release binaries which are uploaded to GitHub releases; we should also do this in GHA before removing Travis entirely.
We'll also want to update both bors and the repo branch protection settings to use GHA; perhaps this PR should also update bors.toml to check against GHA status instead of Travis status.

(most but not all PRs)

Can we even handle those? I think bors will report an error if you attempt to do a PR not aimed at master.
I'd prefer to do this step by step. For now the important thing is to get regular (and reasonably fast) CI for PRs up and running again and then we expand into other directions.

I think your intent is to stop GHA building the commit in a PR and then immediately building again once it's merged to master

No, if you do pull + pr it will always build PRs twice which is very wasteful, cf. the first run on the PR above: All checks have passed 41 successful checks
vs the last one: All checks have passed 22 successful checks

I'd prefer to do this step by step. For now the important thing is to get regular (and reasonably fast) CI for PRs up and running again and then we expand into other directions.

That's fair; I still think we require CI builds on staging and trying branches in that case.

No, if you do pull + pr it will always build PRs twice which is very wasteful

I don't understand what you mean by "pull + pr". What's causing the double build on that commit? Is it because you pushed to a branch on the repository (triggering branch push) and because that branch is a PR? I think my suggested config would also solve this in that case, while still allowing PRs not aimed as master and allowing bors to work:
on:
  push:
    branches: [ staging, trying, master ]
  pull_request:

I don't understand what you mean by "pull + pr". What's causing the double build on that commit? Is it because you pushed to a branch on the repository (triggering branch push) and because that branch is a PR? I think my suggested config would also solve this in that case, while still allowing PRs not aimed as master and allowing bors to work:

Sorry, I meant "push" and "pull_request". If you do both without specifing a branch filter it will trigger twice.
I'm not quite sure how that works but we can try your approach.

@adamgreig Can I get a r+ now? ;)


[Feature Request] Use float window to preview the lua code generated by show_code

As the title, It would be better to preview the lua code generated by Fennel in float window rather than printing in command-line. If so, syntax highlight powered by treesitter can also work.

+1 for this
I was just about to open an issue .
Though I'd prefer opening in a split instead of float So I can keep an eye on that while editing .

I forgot it. Split window is definitely better with side by side view.

Though I'd prefer opening in a split instead of float So I can keep an eye on that while editing.

That's actually why I had planned to not show a preview (the printed stuff was a stopgap just for me really).
My reason against it is it quickly becomes:

I want a split bottom
I want a split right
Well I want a float
I don't want to focus the float
can we get a keybind to refresh the split?
it shouldn't open a new float, it should replace the last
...... :godmode:

Basically it adds a whole lot of window management, window config, blah blah, to Hotpot which I don't think belongs.
Hotpot will provide you a method to compile a file, selection or buffer (to file or string) or get the path to a file or module (#2), and it will probably be up to the user to show that somehow (the code to open a window/split and dump lines is pretty short, and the user can write that however they want).
I hope to keep Hotpot about compiling and evaluating Fennel; and a bit of cache management and that's it.
(Probably I will make a hotpot side plugin that does do all the preview stuff, likely a bit like Lush with live preview, etc. It's just not likely to be part of Hotpot.nvim).
This isn't a hard no, but it's a "I don't really want to".

Ok I agree . I think what I think what will be a good compromise is you allow a function as argument to show_selection() & show_buf And feed the result to that function instead of print when available . That way we can do the window handling ourselves . What do you think of that ?

OK. I just tried conjure. It's so cool. I think we can integrate with it so that without focus on interaction. I would like to know how this plugin works with Conjure?

Ok I agree . I think a good compromise if you add a callback to show_selection() & show_buf And feed the result to that function instead of print when available . That way we can do the window handling ourselves . What do you think of that ?

Yeah that's a nice way to do it, but show_* will probably be removed in favour of compile_* which returns a string, and the user can place that somewhere. I don't think it's practically different for the end user in the end? Not sure. Having a cb passed in does tickle my programmer brain in a good way though :snail:.

OK. I just tried conjure. It's so cool. I think we can integrate with it so that without focus on interaction. I would like to know how this plugin works with Conjure?

Yes I use it with conjure. You can see why I am not so interested in rebuilding something like that when it's so stellar. There is an issue around import-macros (#1), do to with how aniseed works, seems like Olical is planning to rework conjure a bit to make it compat (I haven't deep dived into it but AFAIK it is a conjure qurik not a Hotpot one).

I don't think it's practically different for the end user in the end? Not sure.

They are same for the user .
When I was looking at #2 I thought compile_file will write directly to output file .

Yeah there will be both probably, just thinking about it this very moment.
Right now there's all these https://github.com/rktjmp/hotpot.nvim/blob/shuffle/fnl/hotpot/user/compile.fnl which return strings.
{: compile-string
 : compile-range
 : compile-selection
 : compile-buffer
 : compile-file
 : compile-module}

Probably there will be a /user/build.fnl which will have compile-file in out and compile-dir in out.
I know it's a bit weird to have two functions named the same, but I don't really want to bleed "saving" into the compile module.

Going to close this as discussed, rendering output is beyond hotpots purview.
The new API is mainlined, with some examples on how to replace show_code in the Readme https://github.com/rktjmp/hotpot.nvim#using-the-api. It's reasonably trivial to wire up a float or split or whatever you would like.
And conjure.fun can provide nearly anything someone might want in terms of eval output.


How can I get volume_id when creating pvc.

I create pvc by executing
curl -X POST "http://<IP_ADDRESS>:2002/pvcs" -H "accept: application/json" -H "Content-Type: application/json" -d "{ \"name\": \"pvc-32ze341nncwlczm47bsre\", \"namespace\": \"default\", \"need_format\": true, \"volume_id\": \"32ze341nncwlczm47bsre\", \"volume_type\": \"lun\"}"
but get error: {"error":"can not find lv for wwid 32ze341nncwlczm47bsre"}.
The ouput of multipah -ll is empty. How can I get correct volume_id?

You should get your own shared storage which support SCSI or NVMe protocol


Open Dialog opacity change

When setting the status bar and navigation bar colors the opacity when opening dialogs ignores the status bar and nav bars. Its expected that these would appear faded also. I have attached a screenshot of my result and one of the expected behavior.

@jfdeveloper92 I had same issue and it was solved when i used
SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle(statusBarColor: Colors.transparent));

@amitkhairnar44 are you using the white status bar? I did this and my icons are also white for some reason. I am using
FlutterStatusbarcolor.setNavigationBarColor(Colors.white);
FlutterStatusbarcolor.setNavigationBarWhiteForeground(false);
FlutterStatusbarcolor.setStatusBarColor(Colors.white);
FlutterStatusbarcolor.setStatusBarWhiteForeground(false);

@jfdeveloper92 I'm not using white status bar. If your AppBar's color is white then no need to set white background in status bar. Just set it transparent using
FlutterStatusbarcolor.setStatusBarWhiteForeground(false);

Or see this example code
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_statusbarcolor/flutter_statusbarcolor.dart';

main() {
  runApp(MyApp());
}

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => new _MyAppState();
}

class _MyAppState extends State<MyApp> with WidgetsBindingObserver {
  Key key = new UniqueKey();

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      key: key,
      title: 'Example',
      home: new HomePage(),
    );
  }

  @override
  didChangeAppLifecycleState(AppLifecycleState state) {
    if (state == AppLifecycleState.resumed) {
      _changeStatusBarColor();
    }
    super.didChangeAppLifecycleState(state);
  }

  @override
  dispose() {
    WidgetsBinding.instance.removeObserver(this);
    super.dispose();
  }

  @override
  void initState() {
    super.initState();
    WidgetsBinding.instance.addObserver(this);
    _changeStatusBarColor();
  }
  _changeStatusBarColor() async {
    await FlutterStatusbarcolor.setStatusBarWhiteForeground(false);
    SystemChrome.setSystemUIOverlayStyle(
        SystemUiOverlayStyle(statusBarColor: Colors.transparent));
  }
}

@amitkhairnar44  Thanks. Do you know of a way to set the screen fullscreen while keeping these settings? Im currently using the below code to make the screen full screen while on landscape. However with this code it is ignoring the status bar color.
if (MediaQuery
.of(context)
.orientation == Orientation.landscape) {
SystemChrome.setEnabledSystemUIOverlays([]);
} else {
SystemChrome.setEnabledSystemUIOverlays(
[SystemUiOverlay.bottom, SystemUiOverlay.top]);
}

@jfdeveloper92 In portrait or landscape?

@amitkhairnar44  well im wanting the app to go full screen in landscape then go back to normal on in portrait. Its a video app so im wanting the video to go full screen when you go landscape.

also while keeping the statusbar color


[Feature] Add divider

Description
Add divider

Related Issues
#8
Tests
X
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] Run yarn test or yarn test -u if you need to update snapshot.
[X] Run yarn lint
[X] I am willing to follow-up on review comments in a timely manner.

I don't think there's a problem.


Extract the query string first before parsing the parameters

Description
Extract the query string from the URL before parsing it so that the value doesn't end up only in the last matching parameter.
Split the path at the first question mark before parsing the path and store the result in the query_string value of the match
Enable turning off the behaviour at the router level.
Motivation and Context
Closes #30
How Has This Been Tested?
Unit tests are implemented to cover the use cases
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

This seems decent enough, but I was recently thinking about whether this crate might be used in wasm and be involved with client-side routing. If it does, then this would fail for a fragment containing a ? (e.g. /foo#bar?baz should have no query string and a fragment of bar?baz). And we would probably want to do something similar for the fragment.
An alternative might be to not do this and just document better that users need to be pre-parsing the url into components and only passing the path in to be routed, it looks like Tide at least is already doing this.

This seems decent enough, but I was recently thinking about whether this crate might be used in wasm and be involved with client-side routing. If it does, then this would fail for a fragment containing a ? (e.g. /foo#bar?baz should have no query string and a fragment of bar?baz). And we would probably want to do something similar for the fragment.

I did implement it as being optional, but on by default - so we could also potentially reverse the default too... but when implementing this I was checking out the specification for a URL in itself and the query string concept is only relevant to HTTP urls anyway. So on reflection I think you are correct in this:

An alternative might be to not do this and just document better that users need to be pre-parsing the url into components and only passing the path in to be routed, it looks like Tide at least is already doing this.

This is a library crate so it would be better to document that this is the expected input (and perhaps show an example of using it that way).
I'm planning on getting to the documentation this week - so I'll approach it in that way.


youtube-dl crunchyroll

hi i like your program but i have 1 problem how download premium videos from crunchyroll ( i have a premium account)

Not working now again...
~$ youtube-dl -F http://www.crunchyroll.com/naruto-shippuden/episode-391-madara-uchiha-rises-666343
[Crunchyroll] 666343: Downloading webpage
[Crunchyroll] 666343: Downloading media info
[Crunchyroll] 666343: Downloading subtitles for English (US)
ERROR: No video formats found!; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
mrtj@xenon:~$ youtube-dl -F --verbose http://www.crunchyroll.com/naruto-shippuden/episode-391-madara-uchiha-rises-666343[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-F', '--verbose', 'http://www.crunchyroll.com/naruto-shippuden/episode-391-madara-uchiha-rises-666343']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.6 - Linux-3.13.0-43-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 9.16-6, avprobe 9.16-6, ffmpeg 2.4.3, ffprobe 2.4.3, rtmpdump 2.4
[debug] Proxy map: {}
[Crunchyroll] 666343: Downloading webpage
[Crunchyroll] 666343: Downloading media info
[Crunchyroll] 666343: Downloading subtitles for English (US)
ERROR: No video formats found!; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 603, in extract_info
return self.process_ie_result(ie_result, download, extra_info)
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 649, in process_ie_result
return self.process_video_result(ie_result, download=download)
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 853, in process_video_result
raise ExtractorError('No video formats found!')
ExtractorError: No video formats found!; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

@ajay230ps open a new issue.

@ajay230ps I have fixed the issue in a221f22969843866ad85fd5cdf98160c79d99e9f, it will work in the next version.

Thanks ! :)


Azure Cosmos Encryption : Adds test to verify that update of Client Encryption Policy is not allowed via ReplaceContainer

Port .Net SDK fix : https://github.com/Azure/azure-cosmos-dotnet-v3/pull/2349

@aayush3011  pls take a look at this, thanks!


Update logstash-output-webhdfs.gemspec

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

You should pin vendors version, for instance the snappy version 0.0.13 was broken during during 6 days ;-(

Hi ebuildy,
thanks for your PR. Merged it with commit https://github.com/logstash-plugins/logstash-output-webhdfs/commit/9c6631e391c4970bab3c50882217e82ddf3d82e9.
Once again, thanks and take care!
Björn


Checkstyle fixes for Cloud Monitoring sample tests.

Changed to using Truth for assertions.

LGTM - please merge after tests finish.

Appeas to have broken Jenkernetes. :( @tswast


Color scheme support for invalid.illegal

Sublime Text has a scope for illegal characters in certain contexts. Can you add "angry" colors for invalid or invalid.illegal? It seems typical to use white for the foreground and a color-scheme-appropriate red for the background.
Try the following code with the Javascript syntax in Monokai:
var foo = "asdf
var bar;

Thanks for reporting the issue. I'll fix it just a little bit later today.


feat: support Pipenv - Pipefile.lock

Adds support for Pipefile.lock per #4995.
This currently uses the exact same enable/disable settings as the PipfileAnalyzer - and will supersede the PipfileAnalyzer if bother a Pipefile and Pipefile.lock exist.

Looks like autocorrect messed up your PR message (pipefile / pipelock / bother)
Code looks good to me.
One remark: I think it would be good to add some remark in the javadoc of both analyzers that they operate in tandem on the same activation property (with the new analyzer taking over when a lock file is present), so that when revisiting them in the future it's hinted by the docs that if one changes the other is likely to need change as well.


Fix Table Overflow

This PR fixes issue #420.
The width of the table had caused other elements to have too much space on the right.
My solution was to write media queries using breakpoints between 768px to 320px. A reduction in font-size (and slight increase in line-height, to ensure readability), seemed to do the trick.
Additionally, this approach fixed alignment issues across other pages containing tables.

@bebatut & @yochannah
Do kindly review when you get the chance. Thanks!
Please, note that I made this PR on a different branch (of my fork) to prevent any merge conflicts.

Nice @NPDebs
Sadly, your change make the table hard to read on small screen:

Ah, yes. That's true. 🤦🏽♀
I tried to salvage that by increasing the line height. Apparently, that didn't help much.
What do you recommend, please?

Hi, @bebatut Eureka!
Instead of shrinking the font-size and unreadable extent, I added a horizontal scrollbar to the table. The padding at the bottom is to separate the content from the scrollbar.
Do let me know your thoughts on this approach. Thank you!

Good idea the scrollbar.
But it somehow broke the header:

Hi @bebatut. Thanks for the review.
Everything worked fine when I ran the site locally.
So, on commenting out the code, I noticed the problem had nothing to do with the scrollbar.
Earlier, I had accidentally edited line 65 (instead of 64), changing the header width from 100% to width: 450px.
In other to avoid a merge conflict with my other PR, I was going to change the height from auto to 450px...
In summary: Crisis averted. Everything looks good on this end. 👍
Please review when you get the chance. Thanks again! 🙌

It looks good now. Thanks @NPDebs

Thanks for the detailed review and the merge. 🙌🏼🤸🏽♀🤍 @bebatut


Install instructions

This PR adds installation instructions to the README.rst file for users and contributors

Closes #200


Add CUDA version of the torch extension

This now compile for me both for CPU and CUDA version, but fails to run with  RuntimeError: requested shared memory buffer (52976) exceeds max available on device: Quadro P1000 (49152).


azure-dev.commands.getDotEnvFilePath not getting the correct .env file path(?)

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Clone this repo using VS Code.
After installed all the requirements.txt (run "pip install -r requirements-dev.txt" in the root), click the Debug for "Python: Quart". After a short horizontal scrolling motion, the motion disappears without any messages in the Debug window.
If I change the "envFile": "${input:dotEnvFilePath}" with the path to the .env file like ""envFile": "${workspaceFolder}/.azure/your-azure-env-name/.env", the Debug starts as expected.

Expected/desired behavior

Start debugging for "Python: Quart" with the "envFile": "${input:dotEnvFilePath}" configuration.

OS and Version?

Windows 10, VS Code running locally (and the same issue when running in Dev Container)

azd version?

azd version 1.4.1 (commit 1cbed85cf47ed235b5ed31868eda79619525bfcc)

Mention any other details that might be useful

My guess of the root cause of this issue is that the "azure-dev.commands.getDotEnvFilePath" command in launch.json is not grabbing the correct path to the .env file. I searched online about this getDotEnvFilePath command, but there is nowhere explaining the getDotEnvFilePath command (except "https://techcommunity.microsoft.com/t5/apps-on-azure-blog/part-2-observability-for-your-azd-compatible-app/ba-p/3670040" but it doesn't say much about the command...). I also went through the Azure CLI source code in github ("https://github.com/Azure/azure-dev") but couldn't find this particular command either... Your help is highly appreciated!

Have the same issue with the https://github.com/Azure-Samples/todo-nodejs-mongo-aks sample.

Do you have the Azure Developer CLI VS Code extension installed? I believe it comes from there.

Ah I see the discussion in the linked issue, I'll follow that.

This looks to be a regression in azd 1.4.1. See my comment here. @pamelafox you can close this as external if you want, to https://github.com/Azure/azure-dev/issues/2852

Do you have the Azure Developer CLI VS Code extension installed? I believe it comes from there.

Thank you, @pamelafox for checking this issue. FYI, yes, Azure Dev CLI VS Code extension has been installed. (This issue did not occur until recently...)

It's working now after updated azd to 1.4.2.
Thank you all for your support!


1.21 not working

All commands don't work on 1.21

Released version 1.2.3 for Minecraft 1.21 and 1.21.1.
https://github.com/Stonley890/Compass-Tracker/releases/tag/1.2.3

Released version 1.2.3 for Minecraft 1.21 and 1.21.1.
https://github.com/Stonley890/Compass-Tracker/releases/tag/1.2.3

Thank you!


CASMINST-6665: bump csm-node-heartbeat version

Summary and Scope

Fixes: CASMINST-6665

Issue Type

Bugfix Pull Request

Prerequisites

[x] I have included documentation in my PR (or it is not required)
[x] I have tested this by building an image using this branch HEAD, or this is does not pertain to the node-images pipeline.
[x] I tested this on internal system or this pertains to the node-images pipeline (if yes and not build related, please include results or a description of the test)
[x] I tested this on a vshasta system or this pertains to the node-images pipeline (if yes and not build related, please include results or a description of the test)

Idempotency

Risks and Mitigations

/backport lts/csm-1.5


0.1.14 broke compatibility with rust 1.30.0

https://github.com/alexcrichton/rustc-demangle/commit/d74ae4b56ab6459f05afcb22c32371033cac75ff appears to have broken compatibility with rust 1.30.0. In juniper we see a new CI failure:
Downloading rustc-demangle v0.1.14
error: unable to get packages from source

Caused by:
  failed to parse manifest at `/Users/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-demangle-0.1.14/Cargo.toml`

Caused by:
  feature `rename-dependency` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["rename-dependency"]` to enable this feature

Note that juniper is not using rustc-demangle directly.
I couldn't find anything that said this was intentional so I wanted to flag if it wasn't.

Thanks for the report! This crate however requires 1.31.0 now


HTTP/2 Hpack Encoder Cleanup

Motivation:
The HTTP/2 HPACK Encoder class has some code which is only used for test purposes. This code can be removed to reduce complexity and member variable count.
Modifications:

Remove test code and update unit tests
Other minor cleanup

Result:
Test code is removed from operational code.

this is a minor cleanup ... we loose some ability to control the encoder in tests however I'm not sure if this provides too much value.
@nmittler @normanmaurer @carl-mastrangelo - FYI

No red flags from my pov.  LGTM.

LGTM

4.1 (208893a)


Feat: Add Whatsapp icon to add whatsapp community feature to the website and Email icon for mail

Describe the feature
In the footer there is all social media links but whatsapp community link was not there i would like to add a whatsapp community feature to the website users can follow the whatsapp community as well. In additon to that we can add email icon  for the email sending purpose at the social media place.
Assign me this issue @Its-Aman-Yadav sir and @Kalivarapubindusree  mam to make contribution to the project
Thank you
Add ScreenShots

Here in this place we can add Whatsapp community icon , email id icon and discord as well not to go again top
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I want to work on this issue, please assign it to me.

Thank you for the response sir @Its-Aman-Yadav


Add in remaining TDC1 rung 4 lenses.

In #117 we decided to sprinkle in a set of lenses defined by the TDC1 rung 4, but for run 1 we settled on only sprinkling in the first 200 from that rung. We need to update our sprinkling catalog with the rest of rung 4 since only taking the first 200 left out all quads from the lens catalog.

No quads! Thanks for rectifying this sorry situation, Bryce.
On Thu, Mar 24, 2016 at 1:01 PM, Bryce Kalmbach<EMAIL_ADDRESS>wrote:

In #117
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/117
we decided to sprinkle in a set of lenses defined by the TDC1 rung 4, but
for run 1 we settled on only sprinkling in the first 200 from that rung. We
need to update our sprinkling catalog with the rest of rung 4 since only
taking the first 200 left out all quads from the lens catalog.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/192

Hmm - while putting together this week's meeting agenda it occurs to me that this issue is worth discussing with the group. Fixing the lens sample to include quads is something we could test in Run 2 - if we decide to re-make the images as well as re-do the L2 processing... I'll put this question to the floor tomorrow.


Some small improvements for bindings authors

When interfacing with a libsqlite, i realized we don't really expose some of the types and interfaces that would make interoping with C simpler. This doesn't really address that but just adds some improvements around how we expose reading and writing strings (and adds support for c strings).
Perhaps a longer term solution would be to provide some wrapper interfaces that can wrap the memory. It would be nice to do things like, return a pointer which has these reader and writer methods on it. Like an FFI interface. But i'm not sure that belongs in the Memory class and I think that's a broader tasks. It could get bloated.

At the same time, we have always been thinking about a "higher level API", is it maybe time to start a separate module?

I agree. This is just a temporary add. I think it's time to create a bindings package of some kind. I'll write up an issue for it and we can start working on it.


ParseException when using parse_problem_string()

I met ParseException when using parse_problem_string() to import the problem in PDDL format.

The file is from the ENHSP repo as an example and it gave ParseException: , found '('  (at char 280), (line:19, col:5). As I checked line 19 of the domain file it seems nothing wrong.

The domain and problem file are in the attachment, could you please tell me what's going wrong? Thanks in advance.
car.zip

Hi @CJRzzZ! This is a PDDL+ problem with processes and events and they are currently not supported by the unified-planning library.

 It isn't clearly documented the PDDL features supported.. however the features up to PDDL 2.2 should be quite well supported.


stack using array in c

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm
[x] My submission has the time complexity of the algorithm
[x] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

Hi @Shyam-12,
Please update the fork before opening a pull request.


Fixes #123 : Made website Responsive including Header and Footer

Fixes #123
The website has undergone the following changes:

A navbar now sits at the top of the webpage. As the width of the website decreases, a menu button will appear. Clicking this button reveals all the navbar items.

https://github.com/sk66641/Random-Disco-Light-Simulator/assets/153659573/adddc9bb-f4e4-4a5e-8aae-e959ff5da154

The white line that previously occupied the footer has been removed.

Additionally, when the width decreases, the gap between icons decreases, and the font size of the Copyright statement also decreases to maintain visual harmony.

https://github.com/sk66641/Random-Disco-Light-Simulator/assets/153659573/2a885a11-906c-4ca3-b66f-90ddec4cf1c4

@sk66641 The conflicts have been resolved. Please review and merge my PR at your earliest convenience.
Additionally, please label my PR and add my name to the assignees section before merging.
Thank you!


Inherit format for text entity node

Fixes #3965

Tests tho

Tests tho

Forgot to disable new test for plain text, since it won't have any format to inherit 🤷♂


Add listeners to plugin

Hi,
i would like to receive events from the plugin. I would like to know when a sound is played.
I tried :
NativeAudio.addListener('complete', (info: any) => {
console.log('myPluginEvent complete');
});
because in swift code you are notifying the plugin:
public func audioPlayerDidFinishPlaying(_ player: AVAudioPlayer, successfully flag: Bool) {
NSLog("playerDidFinish")
self.owner.notifyListeners("complete", data: [
"assetId": self.assetId
])
}
but on typescript i have an error :
Property 'addListener' does not exist on type 'NativeAudio'.
How can i do it ?
Thanks

Until it is properly implemented in the NativeAudio typescript interface definition you can receive events by using type any for NativeAudio like this:
this.nativeAudioCompleteListener = (NativeAudio as any).addListener(
'complete',
(info: any) => {
console.log('NativeAudio complete was fired');
},
);

#59 is marked as duplicate but there is just complete event available in the typings and other events seem to be missing - at least start, stop, timeupdate or progress


[Data] Issue - adding a new project

Description: Unable create a new project. Errors displayed in the console.
Note: Video in attachment, where you can also see console error.
https://user-images.githubusercontent.com/92084528/143275288-21307293-13ed-45db-b6dd-f42b7ca7fa91.mp4
s.

Error message is now displayed in a toast message so hopefully we can track this down better if it's still possible.


SyntaxError: missing ; before statement

When I used a JS minifier and I have 2 syntax errors because line breaks are removed:

Line 23 after } and before obj.attachEvent("on"
Line 96 after } and before typeof callback

Which minifier are you using? I copy/pasted the current code into here:
http://jscompress.com/
And loaded it in a test document and I'm not seeing any errors.
Probably also worth asking: which browser?

An old JS minifier... So I have removed it.
You're right, sorry.


Support null-safety

Hello! thanks for the awesome package.
Dart 2.12 and flutter 2.0.0 are now in stable with the null-safety feature.
Migrating this package to null-safety would help a lot. :)

Hi @isorensen, this project doesn't contain any code. I haven't checked, should I do something else? 🤔

Found it. https://dart.dev/null-safety/migration-guide It should be migrated. Thanks for the tip! 👍


Add back in support for compiling MET on an IBM using xlf/xlC

John recently gained access to an IBM machine at the Rhenish Institute for Environmental Research in Cologne, Germany.  Use this access to test MET there.

Ensure that 6.0 compiles on it and, if possible, post patches for version 5.2.

Also update the 6.0 online tutorial with IBM info.

[MET-742] created by johnhg

Original attachment area in JIRA
https://sdg.rap.ucar.edu/jira/browse/MET-742?filter=12903

Closed but will not fix.


feat: new custom popup

Design only, need to implement navigation and how to populate

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (327982c) 48.27% compared to head (6e18e42) 48.32%.

:exclamation: Current head 6e18e42 differs from pull request most recent head de55c2f. Consider uploading reports for the commit de55c2f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   48.27%   48.32%   +0.04%
==========================================
  Files         142      142
  Lines       17215    17215
==========================================
+ Hits         8311     8319       +8
+ Misses       8904     8896       -8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Not going to be used for now


Update http4s-client, http4s-dsl, ... to 0.23.10

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl
org.http4s:http4s-server

from 0.23.3 to 0.23.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #170.


UI fixes

Fixed:

input toolbar visibility for not logged in users
FAB in TagActivity (bug introduced in #27)

Thanks!


[Holographic] Search icon (magnifying glass) sometimes hidden in the NavigationView

Describe the bug
Search icon (magnifying glass) sometimes hidden in the NavigationView
Steps to reproduce the bug
Steps to reproduce the behavior:

Open an application with a NavigationView in Left DisplayMode, with a search box.
Resize the application to make it slightly smaller.
Open the NavigationView so that it is expanded.
Close the NavigationView so that it is compact.
(steps 2-4 may need to be repeated in order to see the behavior)

Expected behavior
The magnifying glass icon should be visible in the compact NavigationView (however, it is not).
Screenshots
N/A, since working on a HoloLens.
Version Info
Windows Holographic: 10.0.18362.1024
NuGet package version:

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop

Mobile

Xbox

Surface Hub

IoT

Additional context

@jskollin can you please attach a picture showing the issue ? Also, are you using WinUI2.3 or 2.4 prerelease ? There are several updates to NavigationView in 2.4 pre-release so it would be great to know if this issue is in the pre-release.

This is what we see (no magnifying class)

This is what is expected (magnifying glass):

@jskollin which version of the WinUI nuget package are you using ?

WinUI2.2

@ojhad can you take a look and see if it repro's on the pre-release after the updates ?

@jskollin I am unable to reproduce this issue.
Is it possible for you to upload a project where I can reproduce this issue?
Also, can you try and update your nuget package and see if that resolves the issue?


[Bug]: unable to use expand_template in v2

What happened?
I upgraded the Aspect bazel-lib from v1 to v2 and was unable to use expand_template because no matching toolchain was found.
Version
Development (host) and target OS/architectures: Host platform is macOS/arm64
Output of bazel --version: bazel 6.3.2
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 2.5.3
Language(s) and/or frameworks involved: none.
How to reproduce
Run bazel --bazelrc=/dev/null build :foo
Results in the following error:
While resolving toolchains for target //build/container:foo:
No matching toolchains found for types @aspect_bazel_lib//lib:expand_template_toolchain_type.
To debug, rerun with --toolchain_resolution_debug='@aspect_bazel_lib//lib:expand_template_toolchain_type'

BUILD.bazel
load("@aspect_bazel_lib//lib:expand_template.bzl", "expand_template")

expand_template(
    name = "foo",
    out = "foo.txt",
    substitutions = {
        "{{FOO}}": "{{FOO}}",
    },
    template = ":foo.txt.tmpl",
    tags = ["manual"],
)

foo.txt.tmpl
{{FOO}}

Any other information?
v2.5.3: fails (latest)
v2.1.2: fails
v2.0.0: fails
v1.42.1: succeeds (latest)
v1.38.0: succeeds

See the release notes, you have to register the toolchain yourself starting in v2.
e.g. aspect_bazel_lib_register_toolchains()


Error in API call to get_network_adapter

Main line in the log

/Users/ryangs/.rvm/gems/ruby-1.9.2-p290@global/gems/virtualbox-0.9.2/lib/virtualbox/com/implementer/ffi.rb:106:in `call_and_check': Error in API call to get_network_adapter:<PHONE_NUMBER> (VirtualBox::Exceptions::InvalidArgException)

rest of the trace https://gist.github.com/1449072
This occurs while running vagrant destroy . There was this issue create on it https://github.com/mitchellh/vagrant/issues/485. You said it was probably a fix in this, and since the error stems from this gem. I'm creating this ticket.
I don't have any marked "inaccessible"
running Virtualbox 4.1.6

Here's a patch to work around the issue: http://dl.dropbox.com/u/164709/Misc/network_adapter.rb.patch.  Unfortunately due to a bug in VirtualBox a special case workaround is needed (https://www.virtualbox.org/pipermail/vbox-dev/2011-August/004454.html).

This patched worked great. Not sure if it is still required on 4.1.8 .. I'll try to test it out in the next day or two.

I can confirm the patch is still needed also on VBox 4.1.8 and worked like a charm in my environment. Thanks jkp


PLUGIN-464 fix flatten to be a no-op on empty lists

Fixed a bug where input rows with an empty list would get
filtered out by the flatten directive.

/gcbrun


Calculate Documentation Percentage

I know some documentation tools have the ability to return the percentage documented. I'd love something like this to include in my CI along with SourceDocs. I am more than willing to help as well and add this feature. Where would something like this be calculated and added?

Hi @leogdion, thank you for the suggestion. This is an interesting topic, and feature.
Where to calculate the percentage will depend on your definition:

Should the total percentage be in the README file?
Should it be on each document file?
Maybe we would want a sourcedocs percentage command that prints the total percentage without generating any other output?

In terms of calculation, SourceDocs loads all entities (classes, methods, etc) from code, whether they are documented or not. We could count the number of entities that have documentation and calculate the percentage. The best place to do that would probably be in MarkdownIndex.swift.

I was thinking something fairly simple:

Maybe we would want a sourcedocs percentage command that prints the total percentage without generating any other output?

In other words just output the value with the command. My intention is to include it as part of my pre-commit hook or CI to ensure my documentation is up to certain threshold similar to how I can use swift-test-codecov in my pre-commit hook to ensure my test code coverage is fulfilled.
Feel free to look at how I do this with MistKit and code coverage. I'm going to look at MarkdownIndex.swift and see what I can do there.
Thanks for the pointers!

Nice. That would be a great tool, for sure. It might require some good amount of refactoring, to separate the documentation extraction logic from the markdown generation (right now it's all tangled together 🙈).
If you want to look into it, I would recommend starting by adding a new command, then running the SourceKitten calls to parse the source files and load documentation. Feel free to duplicate any code, if you want to go this route, we can tidy it up later.

I posted #65
Let me know if it needs any further fixes.

Will take a look, thanks

Cool! Let me know if you have any questions.

Hi @leogdion, just left you a comment on the PR. please try pulling the latest changes from the main branch (master branch is no longer used).
If you don't mind, and have the time, it would be nice to clean up the command, specially all the parameters (arguments) not being used or needed for this command. Instead, you can pass default values to the documentation generator.


Added Shield

Added a shield.io badge for android-libs.com; a repository with hundreds of android libraries!

Reported spam.


fix the wrong rpc channel name

Codecov Report
Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.46%. Comparing base (0100b63) to head (5aed744).
Report is 1 commits behind head on main.

Files
Patch %
Lines

server/cdc_impl.go
62.50%
3 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   66.43%   66.46%   +0.03%
==========================================
  Files          48       48
  Lines        6429     6433       +4
==========================================
+ Hits         4271     4276       +5
+ Misses       1889     1888       -1
  Partials      269      269

Files
Coverage Δ

core/reader/replicate_channel_manager.go
55.60% <100.00%> (+0.03%)
:arrow_up:

server/cdc_impl.go
59.44% <62.50%> (+0.24%)
:arrow_up:


installed package name doesnt match

There appears to be some discrepancy between the pip package name and the name of the installed package
Both prometheus_client and  prometheus-client appear to be valid names to install the package
python3 -m pip index versions prometheus-client
WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning.
prometheus-client (0.20.0)

python3 -m pip index versions prometheus_client
WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning.
prometheus_client (0.20.0)

but the actual installed package is named prometheus_client
prometheus_client      0.20.0

and the files on disk reflect that name
ll /usr/local/lib/python3.8/dist-packages
total 32
 4096 Feb 27 10:26 ./
 4096 Jun 27  2022 ../
 4096 Feb 27 10:26 pip/
 4096 Feb 27 10:26 pip-24.0.dist-info/
 4096 Feb 27 10:26 prometheus_client/
 4096 Feb 27 10:26 prometheus_client-0.20.0.dist-info/

All the documentation suggest using
pip install prometheus-client

but that name doesn't match what is output from pip list
which in my case causes problem for automation scripts as the name in the list of installed packages does not match the name of the package to be installed
which name is the correct one?
why does the package name not match the installed package name on disk or in pip list

Additional note on this: PyCharm always complains that prometheus-client is not installed while at the same time showing that prometheus_client is installed. This doesn't happen with other packages


usbdev: Fix build error with BOARD_USBDEV_SERIALSTR

Summary
Fix build error and warning when enable BOARD_USBDEV_SERIALSTR.
Impact
drivers/usbdev
Testing
on Spresense board.

@xiaoxiang781216
I fix it. Please review again.

@xiaoxiang781216
I fix it. Please review again.


Window tear,

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
This happens only when using additional monitor with my laptop, i will attach video to show issue better.
It happens both in debug and release mode.
I run cargo r on my laptop and iced window shows on my laptop screen, then i drag window to my external monitor, and i see shortly some white lines at bottom right corner of the window.
What is the expected behavior?
White lines should not be visible on the bottom right of the window.
Version
https://user-images.githubusercontent.com/97843623/225921764-4a20de83-e3ae-4482-939a-4c52115e934b.mp4
master
Operative System
Linux
Do you have any log output?
I am using popOS, wayland :
 *-display
       description: VGA compatible controller
       product: Barcelo
       vendor: Advanced Micro Devices, Inc. [AMD/ATI]
       physical id: 0
       bus info: pci@0000:03:00.0
       logical name: /dev/fb0
       version: c1
       width: 64 bits
       clock: 33MHz
       capabilities: pm pciexpress msi msix vga_controller bus_master cap_list fb
       configuration: depth=32 driver=amdgpu latency=0 resolution=2560,1600
       resources: irq:38 memory:d0000000-dfffffff memory:e0000000-e01fffff ioport:e000(size=256) memory:fcd00000-fcd7ffff

CPU model name	: AMD Ryzen 7 5825U with Radeon Graphics

//i am not sure how to get logs but if someone explains i will do it gladly

offtopic but I believe "tearing" is something different


App crashes when using the Menu component on mobile device

Package / App
MAD Components
Version
0.12.5
What happened?
The app crashes when using the Menu component.
**Steps to reproduce: **

Navigate to the Menu component.
Press the menu button and select any values from the menu.
Item is selected and you get a warning: measure cannot find view with tag #7793.
Press the menu again.
App crashes with following error:
[1923, "RCTView",  {"left":"<>", "top":263.5}] is not usable as a native method argument

Think this is caused by the useEffect in Menu.tsx.
Other info
No response
Relevant log output
No response

@Sandtory, think this have to do with the autocomplete fix you did a couple off days ago.
https://github.com/equinor/mad/pull/379


Restore Android client playback ability and upgrade client version

I removed the % symbols from MOBILE_PLAYER_PARAMS, and it is now working fine. Although stream URLs return a 403: Not Success Status Code, they work fine with OAuth.
I noticed that ANDROID_MUSIC always throws a NullPointerException when used for search: https://mystb.in/8e32eef8d377e2282f.
I verified that this PR does not break any other clients using MOBILE_PLAYER_PARAMS. The ANDROID_MUSIC client can't perform searches due to missing keys in the API response, but playback works fine. It can still be used for playback by disabling search and video loading.
The WEB client playback is broken, as stream URLs return a 403: Not Success Status Code, even with OAuth.

I am closing this and making a new pull request with requested changes.


gyp: update gyp to v0.7.0

⚠ BREAKING CHANGES

msvs: On Windows, arguments passed to the "action" commands are no longer transformed to replace slashes with backslashes.

Features

xcode: --cross-compiling overrides arch-specific settings (973bae0)

Bug Fixes

msvs: do not fix paths in action command arguments (fc22f83)
cmake on python 3 (fd61f5f)
ValueError: invalid mode: 'rU' while trying to load binding.gyp (d0504e6)
xcode cmake parsing (eefe8d1)

This is semver-major because of the breaking change.