Type issue while using Nuxt 3, Typsecript and Vue 3

Describe the bug
I'm using Nuxt 3 and Vue 3

While I'm importing the components in viruta 0.23.3 it throws error at just in vs-code and not in production.

Could you show me your tsconfig?
Set moduleResolution: "bundler" to your config may solve the problem for now.

Could you show me your tsconfig? Set moduleResolution: "bundler" to your config may solve the problem for now.

{
	// https://nuxt.com/docs/guide/concepts/typescript
	"extends": "./.nuxt/tsconfig.json",
	"compilerOptions": {
		"types": [
		  "@nuxtjs/i18n",
		]
	  }
}

Which can be customized by nuxt.config.ts.
And inside nuxt config I have this option for bundler resolution.
  future: {
    typescriptBundlerResolution: false
  },

for further information to the latest Nuxt blog explains the Bundler module resolution

Thanks. typescriptBundlerResolution: true may solve the problem because Vue entry point of virtua is using exports of package.json, which can't be handled in TypeScript without moduleResolution: bundler or moduleResolution: nodenext.
We may implement fallback for legacy TypeScript if it's important for Vue ecosystem.


Update: iFlytek.iFlyRecSI version 5.0.1

Microsoft Reviewers: Open in CodeFlow

/azp run

https://github.com/microsoft/winget-pkgs/issues/142854


Support styling, custom icons

Thanks for bringing native tabs!
currently if we use standalone TabView, we could not change style of label text, and can not render custom icons.
like if we want to render for example lottie icons.
also we do not have rtl support.
how could we change direction to RTL?

Hello, thanks for opening the issue.

we could not change style of label text, and can not render custom icons.

What would you like to change when it comes to the style of labels? The native Tab bar sets certain constraints on what can be changed.
Same with custom icons, currently it's not possible to render custom components inside of the tabs (I will investigate adding support for additional types of icons like lottie) but I don't think passing custom components will be supported.

how could we change direction to RTL?

You can try this:
I18nManager.forceRTL(true);

As native components are rendering the views I think RTL should be supported but if not please open a separate issue.

Hello, thanks for opening the issue.

we could not change style of label text, and can not render custom icons.

What would you like to change when it comes to the style of labels? The native Tab bar sets certain constraints on what can be changed.
Same with custom icons, currently it's not possible to render custom components inside of the tabs (I will investigate adding support for additional types of icons like lottie) but I don't think passing custom components will be supported.

how could we change direction to RTL?

You can try this:
I18nManager.forceRTL(true);

As native components are rendering the views I think RTL should be supported but if not please open a separate issue.

For example, font family, color (if not possible),
And Also make text always visible not only for active tabs (on android).
it's a bummer actually if not possible using custom components :(
I used react native tab view before and used lottieView for icons, I don't know if this is possible or not.

@arasrezaei
I did a quick check and it looks like it's possible to support custom fonts + change the size of labels. We can create a feature request for this.
You can control color with current props. You can use tabBarActiveTintColor and tabBarInActiveTintColor.

And Also make text always visible not only for active tabs (on android).

Pass labeled={true} for the navigator. (https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/usage-with-react-navigation.html#labeled)

I used react native tab view before and used lottieView for icons, I don't know if this is possible or not.

Currently it's not. You can either use custom images or vector icons: https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/usage-with-vector-icons.html
For some cases I still recommend to use JS Bottom Tabs, native primitives enforce specific rules that we can't easily change.

Hello, thanks for opening the issue.

we could not change style of label text, and can not render custom icons.

What would you like to change when it comes to the style of labels? The native Tab bar sets certain constraints on what can be changed.
Same with custom icons, currently it's not possible to render custom components inside of the tabs (I will investigate adding support for additional types of icons like lottie) but I don't think passing custom components will be supported.

how could we change direction to RTL?

You can try this:
I18nManager.forceRTL(true);

As native components are rendering the views I think RTL should be supported but if not please open a separate issue.

@okwasniewski If custom components is not supported, is it perhaps possible to render badges (e.g. unread count for messages) on the icons? That seems like a use-case that could be relatively common

@fobos531 Yes, it's possible you can use tabBarBadge option on the screen.
All of the props and features are described in the docs: https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/usage-with-react-navigation.html#tabbarbadge


Documented admonition on when to use custom signals

As discussed on django-developers: https://groups.google.com/d/msg/django-developers/c5sFZ5BEujI/jVLsfSYBAwAJ

Agree on both your suggestions. Both reference and topic docs indeed don't mention anything about the simpler alternatives of overriding the methods.

I filed https://code.djangoproject.com/ticket/30801#ticket to keep track of these ides.


feat(dataset): add dataloader for CIHP dataset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.552%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5547

Relevant Lines:
6639

💛  - Coveralls


Class not found

I am using Clipboard in ionic v3 . While calling copy method it's giving exception Class Not Found.

I have faced with this problem in ionic v4 today

I have faced with this problem in ionic v4 today

It seems like new version of the @ionic-native/clipboard is broken. v5.23 works for me
npm install --save<EMAIL_ADDRESS>

It seems like new version of the @ionic-native/clipboard is broken. v5.23 works for me
npm install --save<EMAIL_ADDRESS>


Added citation of dataset used

Citation for dataset used in screenshot
is added.

@uellue Could you please check the PR, It would be helpful for those who are looking data used in GUI usage.

Hm, strange that the citation triggered a CI error. I'll have to look at it later. Regarding datasets, perhaps it could make sense to collect a number of publicly available ones with a short description?

That would be great!

Regarding datasets, perhaps it could make sense to collect a number of publicly available ones with a short description?

Where can I find the datasets , also where are we planning to add this section in  documentation ?

For a good solution we should probably combine this with the overview table in #670.

BibTeX entry for each dataset
using :cite: instead of a download link in the table
A very short description, which I can take care of since it is application-specific.

All in all, I'd propose to remove the :cite: that is causing issues for unknown reasons at the moment, add BibTeX entries for the other source(s) from #670 here to not create a merge conflict, and then merge both into master.
After that, I can debug the :cite: issue and add descriptions.
Sounds good? :-)

Ah, for context: The goal is not only to give users access to datasets, but also to create visibility and impact for the people who uploaded the data. :cite: and BibTeX entries can create back links that are counted and show impact.
Furthermore, we should always make sure that the authors are visibly credited.
CC #670 :-)

All in all, I'd propose to remove the :cite: that is causing issues for unknown reasons at the moment, add BibTeX entries for the other source(s) from #670 here to not create a merge conflict, and then merge both into master.

I have removed :cite: from usage docs and added BibTeX for the other dataset .

Sounds good? :-)

absolutely :smile:


Please share the code of this plugin.

The screenshot looks (https://qph.is.quoracdn.net/main-qimg-a9f9587674fa068609ff6a48b43d38d2?convert_to_webp=true) great, but how can I contribute if no code is public?
Please tell us, if it is an open source project, and which license applies.

@kamir, currently, it is a closed source however free software but it will be opened very soon (maybe under Apache 2 license)
What license would you suggest?

We usually use Apache 2 a lot. Since it is Hadoop related it seems to be a good idea to be in line with the general Hadoop license. But I am not an expert in licenses. All kinds of open source which allows building a community around a great software sounds like a huge win.
Best wishes,
Mirko

@kamir it's open now
looking forward for your participation


FEATURE REQUEST: Curated content

Some curated content would also be cool. Kinda like how Ultimate Guitar has some suggested song selections. There could be some periodic highlighting of "Classic Rock Rigs" or "Metalcore Must-Haves", etc. or "Amps of the 80s", "Amps of the 90s", etc.
This could leverage organizational tags for decade, genre, amp characteristics, etc.

An idea would be to assign the role of curator to some trustworthy members so that they could feature their choices and work, for example. Steam does that with games.


Add packaging to builds

Builds packages using fpm
Tests the installation of each package with docker

Using dist: trusty

Uploads packages to packagecloud.io/travisci/worker/

[] Need to add docs to README.md

Add docker binary detection and "don't push to packagecloud unless it's building a new version" support to packaging scripts

I think this is ready to merge now that we have a working set of default configs.

Do it!
On Tue, Jul 7, 2015 at 10:10 PM, Brandon Burton<EMAIL_ADDRESS>wrote:

I think this is ready to merge now that we have a working set of default configs.
Reply to this email directly or view it on GitHub:
https://github.com/travis-ci/worker/pull/25#issuecomment-119320924


[lexical-playground] Bug Fix: skip auto-scrolling on table resize

Description
Skip auto-scrolling on table row or column resize.
Test plan
Before
scrolls back to cursor

After
no auto-scroll

Oh! Very cool, didn't know about this tag!

It wasn't used anywhere before, so it took me a while to find it


Does the pro version have a live Visualizer?

Hi, looking at the home page it looks like it has a visualizer?

It does have a live Spectrum Analyzer. Please try the Trial mode (click the Pro button in eqMac top bar) and test it out before committing to the Pro Subscription. You can trial for 5 minutes with a 1 minute timeout unlimited amount of times

Those color bands you see, is not a visualizer like you are thinking, its just a type of "slider" to configure the EQ.  The two "visualizers" are a traditional peak bar, and the sound lines...

I haven't figured out how to remove the color "sliders"...

Is there any Docs?

@Onyx808 there's no Documentation currently, but I'm working on it as well as video showcase/tutorial of eqMac.
The original question has been answered, so closing the issue. Thank you


Ipfrag

This patch modifies system-traffic.at at points of some long lines, that results in the patch getting corrupted by the time it reaches patchwork. Hence, I am submitting as a pull request.
commit 7d8aeabff4253677b8ba889f80f0d2dfabfaa333

some conflict


Break of drag some points

Hi!
How to break of drogging some points? I tried throwing exception on onDragStart callback for cancelling dragging of interest points, but this not working =(
Any ways?

Hey there,
if I get your question right, you want to prohibit dragging of some points, right?
I build a (somewhat) hacky solution as a fiddle that shows how you could achieve this.
I realised that the README does not point out that the onDragStart callback takes two arguments event, element (instead of only event), where element is the ChartJS element that was clicked.
Essentially, I checked if the clicked element is the one we would like to prohibit, store its original value, and keep updating the point with its original value during drag.
Hope this is what you were aiming for?
Best, Christoph

Tnx! =)
This solution are satis for me)

Hey @chrispahm,
I have a slightly more advanced use case than above. I am using Vue and have multiple charts rendered on a single page. Ideally I would like some of the points on each of the charts to be disabled whilst the overs remain draggable. I've tried without success to use the approach above, would you mind taking a look?
https://codepen.io/pen/?template=abBEbNB

Never mind, found the answer I needed in the docs:

To avoid dragging specific data points inside a draggable dataset, you can return false to function onDragStart.

Thanks Chris for such an awesome library!


Feature/dark mode UI v2

Describe your changes
Complete overhaul to implement dark mode on every page.
This inlcudes the following:

Ability to switch to light/dark mode from within the popup

Ability to switch to light/dark mode from the options page

Ability to pick between default and accent mode form within the options page

Synchronization of theme & accent between any inspector page and any other inspector page (including popup)

Load of page with the latest theme and accent (fast-theme.js)

New styling for inspector button (need inspector.css in the manifest) when theme != light && accent != default

While I was working on CSS,

Found some duplicated entries which I've deleted for easier code readability
Stumbled upon a fix for images on the export page to work both on Chrome and Firefox

While I was trying to test on Firefox,

Fixed the error which was coming up with links.js not being recognized as a module (removed from the manifest and renamed to links.mjs)
Updated the readme.md with the newest command for the sf cli.
Found an issue with deploying the Account Settings for relating Accounts and Contacts (this needs fixing)

Issue ticket number and link
Issue #64
Checklist before requesting a review

[x] I have read and understand the Contributions section
[x] Target branch is releaseCandidate and not master
[x] I have performed a self-review of my code
[x] I ran the unit tests and my PR does not break any tests
[x] I documented the changes I've made on the CHANGES.md and followed actual conventions
[x] I added a new section on how-to.md (optional)

As said in the issue, this PR would also touch on  #294

Hi @Astisme,
Thanks for your work !
I can see some updates on the css for the light theme, I would like to keep it as is.

Are you using the accent theme?

Did I understand correctly that you wanted the border color to be subtler?

Hi @Astisme,
Could you remove styling for visited links ?

Keep the grey background on those icons

Keep the input field focus highlight as it was in the releaseCandidate

vs

In fact, I would like to keep the light theme UI as it is today, in the popup but also on the different pages.
For the dark theme, if you could use what chrome suggest in automatic dark mode it would be great !

And how about the accent themes? Do you have any changes you'd like to introduce?

Thanks a lot @Astisme
I've been waiting for this feature.

And how about the accent themes? Do you have any changes you'd like to introduce?

I'm not aware of accent themes, could you detail ?

@tprouvot please have a look at this comment
https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/64#issuecomment-1933088974

Hi @Astisme,
Thanks for the updates 👍
Few remarks, could you :

use the existing toggle component to configure the dark theme and accent theme?
{option: Option, props: {type: "toggle", title: "Enable Dark Mode", key: "enableDarkMode"}},
{option: Option, props: {type: "toggle", title: "Enable Accent colors", key: "enableAccentColors"}},
search and fix every design difference between existing version and your branch ie attached screenshot
remove sun and moon icon from popup to keep the configuration on the option page

Thank you !

Hi I'm not sure if I'll be able to use the standard implementation of the toggle since I have to do more than simply set a localstorage variable.
Also I'd like to show the user what the default and accent look like before they select it; hence the much different selector for the accents (by doing it this way we may even add more accents in the future and not be limited to 2 of them).
For the other points, I'm still not done aligning the styles.
I'll tell you when it's ready 👍

Hi @Astisme,
I understand your point regarding the button on the popup but I would prefer to keep the popup without configuration and add dark mode in the option page since it is not something users will update daily.
Regarding the accent options and dark theme, I'm divided into uniformize the option (and maybe update current toggle component to handle other values than true/false) and providing the preview of the accent theme

@tprouvot I need to understand more clearly what you want to achieve with the borders: do you want them to be of the same color aka an even subtler gray?
Because when I started this mini-project I found waaaay too many colors scattered around the files. Here's a snapshot of when I was starting to look for them.

and this was the file I was using to match them to the new colors
#000000 --inspector-text
#00396B --inspector-accent
#005FB2 --inspector-primary
#006B2D --inspector-success-background
#006DCC --inspector-accent
#0070D2 --inspector-primary
#009999 --inspector-true-boolean
#009DCC --inspector-accent
#00D9FF --inspector-primary
#0176d3 --inspector-primary
#061C3F --inspector-accent
#1589EE --inspector-primary
#16325C --inspector-accent
#54698D --inspector-neutral
#606061 --inspector-neutral
#61FAB8 --inspector-success
#706E6B --inspector-neutral
#777777 --inspector-neutral
#870500 --inspector-error
#990000 --inspector-false-boolean
#990099 --inspector-number
#999900 --inspector-object
#9FAAB5 --inspector-neutral
#A61A14 --inspector-warning
#AAAAAA --inspector-neutral
#B0ADAB --inspector-neutral
#B0C4DF --inspector-export-background
#C0C0C0 --inspector-neutral
#C23934 --inspector-error
#C9C7C5 --inspector-neutral
#CCCCFF --inspector-working
#D8BE5F --inspector-warning
#D8DDE6 --inspector-neutral
#DDDBDA --inspector-neutral
#E0A4B5 --inspector-import-background
#ECEBEA --inspector-background
#EEEEEE --inspector-background
#EEF1F6 --inspector-backgqound
#EEF6F1 --inspector-background
#EF7EAD --inspector-svg-picture
#F3F3F3 --inspector-background
#F4F6F9 --inspector-background
#F7F7FB --inspector-background
#F7F9FB --inspector-background
#FFEE33 --inspector-warning
#FFFFFF --inspector-background

As you can see, I've tried to simplify the colors for easier maintainability and better understanding.
At the current state of the art, we have 5 different types of gray. Do you want to add more? Do you want me to rename them?
    --inspector-black: #000000;
    --inspector-white: #FFFFFF;

    --inspector-dark-white: #F3F3F3;
    --inspector-very-light-gray: #AFAFAF;
    --inspector-subtle-gray: #C9C9C9;
    --inspector-half-gray: #444444;
    --inspector-other-half-gray: #BBBBBB;

Hi @Astisme,
My first goal for this PR is to keep the UI and colors as is when the dark mode is not enabled.
I would like to have no differences between current version and the future one with dark mode disabled.
So I would like to keep the border with their original color.
For the simplification of the colors it's a good point and as you said it will be easier to maintain 👍
I'm ok with the naming of the greys, concerning the number, did you remove some ?
Would that mean that we are missing some and we have a difference with current version  ? If it's the case I would prefer to keep the current UI. If not I'm ok with the one you provided.
We can have a short meeting to discuss about it I think I would be easier.

Yes, I reduced the number of grays.
Send me a message on discord.
@astisme

Hi @Astisme
Friends request seems to be disabled, easiest way would be to add me on Linkedin

Hi @Astisme,
Any updates on this PR ?
Do you have any blocking points ?

Hi yes, I had a little bit of an issue tackling the last points
but the main issue has been not having enough spare time to work on this.
I hope to be able to work on this during the next week

With these commits, I've concluded my development.
I'll only merge the conflicts from now on.

[ ] I ran the unit tests and my PR does not break any tests
[ ] I documented the changes I've made on the CHANGES.md and followed actual conventions

Hi @Astisme ,
Yes I remember this one, I'll definitely take a look

ok, that's all.
feel free to comment

Hi @Astisme,
Thanks for the updates, I have few remarks:

I prefer that the theme of reloaded stays in default mode and let users decide if they want to switch to dark theme or not
The option 'Match Theme to MacOS Appearance' does not work when disabling the option
We still have lots of UI difference with the existing version (you can install beta version and keep the local version to compare UI)

Popup, lots of differences in REST Explore page, Event Monitor, Field Creator

Can you expand on this?

I prefer that the theme of reloaded stays in default mode and let users decide if they want to switch to dark theme or not
Do you mean that a user who wants dark mode, should switch to it for every new session?
Or did you get the black version when testing it again?
If it's the ladder, I believe it's due to your localstorage. I have not changed the default theme from when you install/update the extension.

What do you expect to happen when disabling the option?

The option 'Match Theme to MacOS Appearance' does not work when disabling the option

At the moment, it should stop to follow your browser's theme appearance.
What is happening to you?
I do not have a Mac to test this on, unfortunately.

Sorry for these

lots of differences in REST Explore page, Event Monitor, Field Creator

I've rushed them last minute since they weren't available before.


Fail to import gym_minos

I have installed the gym_minos package by  running pip3 install -e . in the gym directory. It runs successfully, but the gym_minos package is not installed properly. Running python3 demo.py --env_config objectgoal_suncg_mf gives the following error.

➜  gym git:(master) ✗ python3 demo.py --env_config objectgoal_suncg_mf
Traceback (most recent call last):
File "demo.py", line 5, in
import gym_minos
File "/home/nina/work/minos/gym/gym_minos/init.py", line 2, in
from gym.envs.registration import register
ImportError: No module named 'gym.envs'

Is it due to the gym version change? My gym version is 0.10.3. Could anyone importing gym_minos successfully tell me your gym version?

My gym version is 0.9.4. Did you run pygame_client to make sure you install package successfully ??

I think this is because go last pull request of @johny-c.
"init.py" inside gym directory make python find closest gym library, which is the exact minos/gym folder, where "demo.py" is.
See this commit

Yes, @kvas7andy is right.
Importing gym, it turns out the gym module from minos/gym folder. And after deleting the "__init__.py" file, the problem solved.


error while trying to make gif of whole henry Emily monologue form fanf pizzeria sim

Command that caused the error
&caption Connection terminated. I'm sorry to interrupt you Elizabeth, if you still even remember that name. But I'm afraid you've been misinformed.  Although you have indeed been called. You have all been called here. Into a labyrinth of sounds and smells, misdirection and misfortune. A labyrinth with no exit a maze with no prize. You don't even realize that you are trapped. Your lust for blood has driven you in endless circles, chasing the cries of children in some unseen chamber, always seeming so near, yet somehow out of reach. But you will never find them, none of you will. This is where your story ends. And to you my brave volunteer who somehow found this job listing not intended for you. Although there was a way out planned for you I have a feeling that's not what you want. I have a feeling that you are right where you want to be. I am remaining as well I am nearby. This place will not be remembered and the memory of everything that started this can finally begin to fade away. As the agony of every tragedy should. And to you monsters trapped in the corridors Be still and give up your spirits they don't belong to you. For most of you I believe there is peace and perhaps more waiting for you after the smoke clears. Although, for one of you, the darkest pit of Hell has opened to swallow you whole, so don't keep the devil waiting, old friend. My daughter if you can hear me, I knew you would return as well. It's in your nature to protect the innocent.  And then, what became of you. I should have known you wouldn't be content to disappear, not my daughter. I couldn't save you then, so let me save you now. It's time to rest. For you, and for those you have carried in your arms. This ends for all of us. End communication.
Image that caused the error
https://media.discordapp.net/attachments/723387010181627916/932359685716181042/3B08A8E0-0EBE-4776-AADC-058A88097A12.gif
Steps to reproduce

Go to 'discord'
input the command '&caption Connection terminated. I'm sorry to interrupt you Elizabeth, if you still even remember that name. But I'm afraid you've been misinformed.  Although you have indeed been called. You have all been called here. Into a labyrinth of sounds and smells, misdirection and misfortune. A labyrinth with no exit a maze with no prize. You don't even realize that you are trapped. Your lust for blood has driven you in endless circles, chasing the cries of children in some unseen chamber, always seeming so near, yet somehow out of reach. But you will never find them, none of you will. This is where your story ends. And to you my brave volunteer who somehow found this job listing not intended for you. Although there was a way out planned for you I have a feeling that's not what you want. I have a feeling that you are right where you want to be. I am remaining as well I am nearby. This place will not be remembered and the memory of everything that started this can finally begin to fade away. As the agony of every tragedy should. And to you monsters trapped in the corridors Be still and give up your spirits they don't belong to you. For most of you I believe there is peace and perhaps more waiting for you after the smoke clears. Although, for one of you, the darkest pit of Hell has opened to swallow you whole, so don't keep the devil waiting, old friend. My daughter if you can hear me, I knew you would return as well. It's in your nature to protect the innocent.  And then, what became of you. I should have known you wouldn't be content to disappear, not my daughter. I couldn't save you then, so let me save you now. It's time to rest. For you, and for those you have carried in your arms. This ends for all of us. End communication.'
'wait'
See error

Self-hosted instance?
Yes
Error file
Message: Request ended prematurely due to a closed connection

Stack Trace: undefined

Additional context
trying to be funny, i really am

This should be handled by 72efad0 and 593c132, will be pushed to the main bot soon


CPU memory leak during training

There seems to be a memory leak using datasets in the current template. On SLURM, some runs will crash after a time with a OOM error and W&B logs show a monotonically increasing CPU memory usage.

It's not 100% that the data leak is because of datasets but pretty sure. I also had a OOM kill on a very long running job using the transformers.Trainer instead of lightning.


Remove remnants of ccache with --use_docker

Using ccache when building under a docker image isn't useful when
building on kokoro as each build runs on a fresh VM.
Originally ccache builds were used to speed up jenkins builds,
now removing to guarantee build isolation and simplify stuff.
Finishing up the removal that started in https://github.com/grpc/grpc/pull/15483

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,303      Total (=)      2,015,303

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,115,998      Total (>)     11,115,992

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

Python actually uses ccache within a single docker container (because two python versions are built in the same run_test.py invocation), which now doesn't work (the second build should be much shorter):
2018-10-30 12:45:01,808 START: /var/local/git/grpc/tools/run_tests/helper_scripts/build_python.sh
2018-10-30 12:55:13,618 PASSED: /var/local/git/grpc/tools/run_tests/helper_scripts/build_python.sh [time=611.8sec, retries=0:0]
2018-10-30 12:55:13,618 START: /var/local/git/grpc/tools/run_tests/helper_scripts/build_python.sh
2018-10-30 13:05:05,316 PASSED: /var/local/git/grpc/tools/run_tests/helper_scripts/build_python.sh [time=591.7sec, retries=0:0]
2018-10-30 13:05:05,317 failed to detect port server
Traceback (most recent call last):

also see
https://github.com/grpc/grpc/blob/7a3a09cf00f3a0e5982b5699f39973aee1be64a5/tools/run_tests/helper_scripts/build_python.sh#L118 (python-specific enabling of ccache)
I'll investigate how to make ccache work for python inside the docker container without ccache crossing container boundaries.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,494      Total (=)      2,020,494

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,633      Total (>)     11,175,629

 No significant differences in binary sizes

Known failures:
https://github.com/grpc/grpc/issues/17138
https://github.com/grpc/grpc/issues/15599

Even though this PR slows down the python builds by a few minutes, I'll still merge, as I'm unable to establish where the ccache speedup is coming from - it doesn't look like it's coming from the python2.7 and python3.7 extensions having some overlap (otherwise the ccache would work even inside the docker image that builds both python2.7 and python3.7 - which is not the case).
I think hermeticity and simplicity is more important that those few minutes of speedup, so it's still worth merging this PR.


Output voltage toggling on and off in source voltage mode

When doing a constant voltage in SVMI mode, I am seeing the voltage toggle from the command voltage output value and zero every 100ms or so. I am using the latest firmware (2.16 & 2.17) and latest PixelPulse2 software. I tried this using Alice as well with the same results. I also tried this out on multiple ADLM1000 devices and computers, with the same behavior showing on both.
I also observed that moving the PixelPulse2 software from background and foreground changed the duration time from 100ms to maybe 500ms or so, if that helps debug this.
Anyone else experience this before?

Hi!
Sorry, but we cannot reproduce this bug. Can you please give us more information about this issue?

What operating system(s) are you using?
What are your PC's specifications?
What settings do you have in Pixelpulse when this bug appears? ((non-)continuous mode, sample time)
Can you please attach a screenshot with the exact bug's behaviour?

Thanks!

Thank you for quick response. We figured it out, by default "repeated sweep" mode is enabled in  PixelPulse2, after turning it off it worked as expected.


Empty commit

[ ] Have you added to CHANGELOG.md for this PR?

Codecov Report

Merging #56 (38a92c7) into main (833f8a0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          135       135
=========================================
  Hits           135       135

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


create new ark-group crate

As we try to implement some generic arguments, like generic inner-products, we must share common traits between Field and CurveGroup. This issue is meant to track the status of it, and the abstractions done over AdditiveGroup. This issue is a spin-off of #577

[ ] create new ark-group trait
[ ] move AdditiveGroup there

The new crate ark-group should also support MultiplicativeGroup, for multiplicative groups used over fields (and over PairingOutput?)

[ ] create MultiplicativeGroup using the template of AdditiveGroup and base Field it

In #577, @Pratyush  suggests basing PairingOutput over MultiplicativeGroup. However, this would break some arguments. For instance. in a sumcheck-based argument for proving $\langle A, B \rangle$ with $A$, $B$ resp. in $\mathbb{G}_1$,  $\mathbb{G}_2$, the sumcheck messages will be polynomials in the target group, and we'd expect to manipulate them just as sumcheck messages from $\langle a, b\rangle$ with $a$, $b$ both in the field (which are in $\mathbb{G}_1$, that is solely AdditiveGroup


Changes in .java files don't apply

I want to change the Barcode scanner plugin for Cordova a bit, so forked it and changed something rather simple for testing purposes.
On line 87 of URIResultHandler.java, I changed the result_uri to result_text . This way, when I would scan a URL, the information would say I scanned plain text.
Then, I added this plugin to my Ionic project, using cordova plugin add https://github.com/binoculars88/phonegap-plugin-barcodescanner .
Browsing to the files in my text editors does show my edits. But... when I run the application on my device, it keeps saying "URL Found".
It's like my changes don't apply... Anyone knows what to do?
I've tried removing android platform and reinstalling the plugin, but that didn't work.
Update:
I've tried changing the text itself in the strings.xml file, just for testing.
I've noticed that this indeed needs a remove and re-add of the platform. After that, the text is changed.
So changes in strings.xml do apply, but the original problem remains: changes in a .java file don't seem to apply.
The ultimate goal of this testing, is to make the duration time after a code is scanned (and the result text is shown) smaller. In CaptureActivity.java, I've changed DEFAULT_INTENT_RESULT_DURATION_MS = 1500L to DEFAULT_INTENT_RESULT_DURATION_MS = 15L , but the duration time stays the same, even after removing and re-adding android platform.

Closing, inactivity. Please comment/re-open if you have more details.


Add PDF_TO_CSS_UNITS to the PixelsPerInch-structure

Rather than re-computing this value in a number of different places throughout the code-base[1], we can expose this in the API via the existing PixelsPerInch-structure instead.
There's also been feature requests asking for the old CSS_UNITS viewer constant to be made accessible, such that it could be used in third-party implementations.
I suppose that it could be argued that it's somewhat confusing to place a unitless property in PixelsPerInch, however given that the PDF_TO_CSS_UNITS-property is defined strictly in terms of the existing properties this is hopefully deemed reasonable.

[1] These include:

The viewer, with the CSS_UNITS name.
The reference-tests.
The display-layer, when rendering images; see PR 13991.

/botio test

Looks good to me; thanks!


fix: reset PlayerLoop back to DefaultPlayerLoop on ExitingPlayMode in the Editor

When we stop playing in the Editor, registered INetworkUpdateSystems would still be ticked by NetworkUpdateLoop unless they unregister themselves.
Sometimes people might forget to unregister their INetworkUpdateSystems and ticking them after they stopped playing would become problematic and cause a bad user experience (as we encountered recently on RpcQueue stuff).
To mitigate this issue, we simply reset back to default PlayerLoop which doesn't have NetworkUpdateLoop systems injected right after we stop playing in the Editor.
With this hardening fix, hitting play → registering an INetworkUpdateSystem programmatically → stopping play in the Editor should NOT throw any unexpected exceptions.

Can you add a description of how a tester would test this?  I realize it would have to be manual, but can we say something like "hit play on a project, wait for it to get into a certain state, then stop and observe the console to have / not have _____"?

If this is supposed to be a fix for Noel's https://github.com/Unity-Technologies/com.unity.multiplayer.mlapi/issues/558 / MTT-529 can you please note that in the PR description or title somewhere.


Deprecation of WebSocket endpoints

URL, if applicable
https://docs.quantum.ibm.com/start/latest-updates
Describe the new content you are requesting.
Due to low usage, we will be removing the WebSocket endpoints:

GET /stream/jobs
GET /stream/jobs/{id}

The job.stream_results() and job.interim_results() methods in qiskit-ibm-runtime use these endpoints and therefore will no longer work once the endpoints are removed, regardless of the qiskit-ibm-runtime version. job.result() also uses these endpoints, and users will need to upgrade to qiskit-ibm-runtime 0.25 or later before the endpoints are removed.
These features will be removed no sooner than 3 months from now, after which point users will no longer be able to stream intermediate results and job status.
The deprecation period will start when this announcement is live, ideally the week of July 1.
If this new content request is accepted, do you want to write the content?
I can help the team by providing enough information to write the material

We've marked the endpoints as deprecated in the Open API spec (https://us-east.quantum-computing.test.cloud.ibm.com/openapi) and when I checked https://cloud.ibm.com/apidocs/quantum-computing I remembered that we had to make a separate change to reflect it there when we deprecated custom programs. Can that be done as part of this issue?

https://us-east.quantum-computing.test.cloud.ibm.com/openapi#/Jobs/get_stream_job_logs_jid
https://us-east.quantum-computing.test.cloud.ibm.com/openapi#/Jobs/get_stream_jobs_state_updates


remove extra GitLab api scopes permission

not listed on https://docs.gitlab.com/omnibus/gitlab-mattermost/
my testing shows it's unnecessary

Thanks, confirmed it's no longer necessary


[FEATURE] Improve test coverage for MLEngine Class

We need to improve test coverage in our repo.
This issue will target only to improve test coverage for MLEngine.java class
From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2FMLEngine.java

Hi, I'd like to contribute to this but I'm not sure how to start.  Could you help me get started?

@divitr Looks like you are working on this issue. I'm assigning it to you.

@divitr could you please comment on this issue? Otherwise I can't assign it to you.

Sure!


Network Zones - Can't Select Multiple

On the zones page, you should be able to select multiple checkboxes.
This used to be possible, looks like an update to the md-table library broke something.

This is fixed in the latest version of CT but appears to be an issue with Old Tony


Changing drawer position

Hello guys,
Is there any method to change the current drawer position?
Drawer position is left for most of the times, but I want to change it to right in some cases, and then change it back to left.
Thanks!

see the docs https://reactnavigation.org/docs/navigators/drawer#DrawerNavigatorConfig


Allow S3 backend key to be defined in child

It seems very common to specify remote state in the root terraform.tfvars file.  In the context of the S3 backend this works well for the encryption, bucket, region, and lock table settings. However, specifying key = "${path_relative_to_include()}/terraform.tfstate" assumes that I'm never going to change where a child is located in my directory structure.
It would be nice if the key could be set to a fixed value in the child's .tfvars file so that the structure of the state does not depend on the relative location of the child within the Terragrunt directory structure.

However, specifying key = "${path_relative_to_include()}/terraform.tfstate" assumes that I'm never going to change where a child is located in my directory structure.

You can change the child directory, but you should move its remote state in that case too. If you store remote state in S3, that's just a matter of aws s3 --recursive mv s3://<bucket>/<old-path> s3://<bucket>/<new-path>. Keeping the path of the code in sync with the path of the state makes it much, much easier to figure out which state files belong to which code.
Moreover, you can override the remote_state block in any child, so if you really do need something custom, it's possible to do it. The one catch is that, IIRC, it overrides the entire remote_state configuration, so you'd have to copy/paste the other values... I suppose the values could be merged together...

You raise a good point about moving the state in S3. Perhaps the better way to handle this would be to add a 'mv' command to Terragrunt that moves both the local folder and the remote storage location at the same time.

Perhaps the better way to handle this would be to add a 'mv' command to Terragrunt that moves both the local folder and the remote storage location at the same time.

Ah, that's a good idea. I'd definitely welcome a PR for that.


Missing Phoenix Wallet

I have an issue. The Phoenix wallet is missing from the list of wallets. Please add it, thanks!

Hi @bitcoin-eagle we have added Phoenix, but it is a non-custodial wallet which requires a minimum balance in order to create channels. We've set a minimum tip size of 10,000 sats for the Phoenix wallet to be included.

This isn't very visible to tippers unless you open the advanced settings. I'll see if we can improve the form to show this

I have added a warning in the tip form:


Added a try-catch to avoid any crashes with trying to draw icons

So instead of crashing (like it does) this change should mean the icon is just not drawn, which is times better behavior.

It's already in 0.24.3.


Support branching for cohort tracking

Description of feature
https://github.com/adayim/consort supports branching off.
We should also enable that somehow.

CONSORT Flowchart background:
https://www.bmj.com/content/340/bmj.c332
https://jamanetwork.com/journals/jama/fullarticle/2799401


v1.7 backports 2020 09 09

v1.7 backports 2020-09-09

#12920 -- pkg/policy: fix toGroups derivative policy for clusterwide policies (@fristonio)
#13097 -- test: Detect missed tail calls on upgrade/downgrade test (@pchaigno)
#12890 -- fix endpoint selection for wildcard to/fromEndpoint in CCNP (@fristonio)

Once this PR is merged, you can update the PR labels via:
$ for pr in 12920 13097 12890; do contrib/backporting/set-labels.py $pr done 1.7; done

@fristonio This needs to be opened against the v1.7 branch. I fixed it manually, but it's best to use the automated script in general.

test-backport-1.7


Fix git config

Not sure why PRs are successfully rendering and working here, and not in a repo I just cloned from this template. But adding this to be consistent with OTTR_Template.

This is not necessary, I just made a mistake in the other repo. Closing!


keep_alive to be used with requests in yaxil.download

Previous version of Yaxil.download uses requests.get to initiate connection to XNAT API. However, when downloading a large file from XNAT, it often raises ConnectionResetError(104, 'Connection reset by peer'). In order to solve this issue, requests.Session is used with keep_alive = True configuration. This solves the issue in Pronet XNAT.

I've encountered another subject, with large MRI data, raising ConnectionResetError(104, 'Connection reset by peer'). It was resolved when TCPKeepAliveAdapter was used to replace session.keep_alive = True. I'll test more cases with large MRI data.

For another 5 MRI datasets pulled using Yaxil through Lochness, there was no ConnectionResetError anymore.

Asking the obvious--did the latest modification work fine for small MRI data?

Overall, I am aware of this issue. I have set up large timeout in Nginx configuration to allow up/down load of large MRI data for XNAT servers.

Asking the obvious--did the latest modification work fine for small MRI data?

No issue so far, in the Pronet dataflow.

Overall, I am aware of this issue. I have set up large timeout in Nginx configuration to allow up/down load of large MRI data for XNAT servers.

Z tried doing that, but did not fix our issue. But this PR did.


tests: set -e DEBUG=verbose on all docker testing scenarios

Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>

@leseb how can we reduce the impact of debug logging so that DEBUG=verbose does not cause the containers to behave differently?

@leseb I'm confused, enabling debug mode here changes the way the container operates? I was hoping it'd allow us to have more insight on why things fail on the PRs without having to modify the branch to enable debug and do a manual run of the test.
I ran this branch against the purge_docker_cluster test and got the following: https://jenkins.ceph.com/view/ceph-ansible/job/ceph-ansible-scenario/96/console

verbose activates set -x which enables tracing which introduces latency in the code execution. Thus this might hide potential raise conditions.
@andrewschoen I understand the intent and I agree this would be useful. With that I think we are getting back to the discussion about adding "jenkins test  debug", which ended with "boot yourself a slave and try to reproduce" :).

Could we have Jenkins re-run with "-x" if the test fails?

@ktdreyer not easily, as you can see from the diff it takes modifying config options in group_vars to include -e DEBUG=verbose when you deploy the container.
What @leseb is asking for is a way from a pr to say "jenkins debug $scenario" and then that slave that ran the test would stay around for manual debugging. This is non trivial because currently mita has no way to spin up a 'single-use' type of slave. There is also difficulty in knowing when a node that's used in this way should be cleaned up.

@andrewschoen can you have a condition in tox to add more options to ceph_osd_docker_prepare_env if a special flag is passed to the jenkins test line? And then add -e DEBUG=verbose?


[UI] The change role list should filter out the current role name.

As it was fixed. I'll close this issue.


Add chrome-go Dockerfile

Add Dockerfile for new chrome-go image which will be used to run UI components tests

Signed the commit


Reusable parts of the ADVANCE Exporter/Importer

Cool bro ! BTW, I REALLY like this project : https://github.com/SGrondin/unblock.us.org

The diff takes a while to load, but if the code works LGTM.
Thanks Simon !


deploy via Kubernetes

Need some help from people with Kubernetes experience on how to deploy the docker image and make the "gleam agent" know where is the "gleam master".

Have gotten working in https://github.com/chrislusf/gleam/pull/25

@ryanckoch Need your documentation on how to run it on the Kubernetes.

http://kompose.io/index
Kompose is a tool to help users familiar with docker-compose move to Kubernetes. It takes a Docker Compose file and translates it into Kubernetes resources.

Most people use etcd to help with service discovery and even configuration.

They all listen to etcd to be told their config.
If they are dependent on something else like a dB or anything they can also listen for that from etcd.
This makes setup and operations much easier.
See the golang package flagz as this explains it more..

https://github.com/mwitkow/go-flagz

First off, thanks for gleam... it is a fantastic framework! I got my first MapReduce using gleam up and running locally in pretty short order.
Secondly, I'm new to kubernetes myself, and am having the same problem that the agents can't find the master when running the cluster remotely.  I can provide details if you want.  Meanwhile I'll see if I can find some local experts to help me out.


Fix SWARM-1345: Use true

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

retest this please


Скласти інтро

I worked with Angular, have commercial experience with Shopify, WordPress. Now I'm studying Flutter.


How to use example iOS12

Steps to reproduce
I already posted issue #142022, and reporter mentioned #94491 as duplicated issue.
I couldn't understand this thread perfectly, but I understood that this factor is the M1 mac silicon chip.
I tried to use and modify iOS12 example like below:

modify API KEY part
check PRODUCT_BUNDLE_IDENTIFIER

but it doesn't work.
how should I use this example or which example should I use in M1 mac silicon chip?
Expected results
I expect to show google map.
Actual results
google map is not showing.
Code sample
I used this example.
Screenshots or Video
please check #142022
Logs
please check #142022
Flutter Doctor output
please check #142022

@chihiro-yabuta Could you try the workaround at https://github.com/flutter/flutter/issues/94491#issuecomment-1488713501?

@huycozy
I tried to copy and modify:

ios 12 -> 13
comment out arm line

but it also doesn't work.
this is that repo.

I asked my colleague to check this on simulator on her M1 machine. Strange thing that your both examples (in this issue and on https://github.com/flutter/flutter/issues/142022) can render map normally. She checked this on iOS 17.2 simulator. Could you try this on another simulator?

@huycozy
I'll try to check on online simulator. thank you.

I'm not sure if you accidentally closed this or if you already solved the issue. You can try checking if you have installed Rosetta 2 or not:
/usr/bin/pgrep -q oahd && echo Yes || echo No

Please also follow the Software requirements guideline if you haven't done it yet.

I think my mac is satisfied with that requirements.
/usr/bin/pgrep -q oahd && echo Yes || echo No
Yes
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.8, on macOS 13.6 22G120 darwin-arm64, locale
en-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] IntelliJ IDEA Community Edition (version 2023.2.2)
[✓] VS Code (version 1.85.2)
[✓] Connected device (2 available)
[✓] Network resources
• No issues found!

Google Maps SDK for iOS cannot connect or validate APIKey

I'm unsure which project you are running on, but please ensure your API key is still valid with the bundle ID. You can check this as well.

Google Maps SDK for iOS cannot connect or validate APIKey

this error happened both of project.
is it necessary to set bundle ID?
actually I set no limit about my api key and you could get google map.

is it necessary to set bundle ID?
actually I set no limit about my api key and you could get google map.

Does this mean the map only can't load if you restrict API key to a specified iOS app with bundle ID?
I just found this which mentioned Case Sensitive in the bundle ID could cause the error above. Can you try changing bundle ID to all lowercase to see if it works?
Also, just to confirm, did you enable Maps SDK for iOS?

@huycozy
I already mentioned at #142022 , I set Maps SDK for iOS correctly.
and I cannot load map regardless of any restriction.
but you (it means @huycozy and your co-worker) succeeded to load map to use my api key right?
my api key doesn't restrict anything so I guess it's unnecessary to set bundle ID.

but you (it means @huycozy and your co-worker) succeeded to load map to use my api key right?

Yes, map can load well on my Intel machine and my co-worker with her M1 machine.

I already mentioned at https://github.com/flutter/flutter/issues/142022 , I set Maps SDK for iOS correctly.

This is what I meant. It isn't mentioned so I just want to confirm this. You can search Maps SDK for iOS in https://console.cloud.google.com and enable it.

@huycozy

it's enable.


In Android, BlueSky can receive SEND_MULTIPUL intent, but not supported in the app

Describe the bug
When sharing multiple images from other apps, the BlueSky open home screen.
To Reproduce
Steps to reproduce the behavior:

Share multiple images from another app.

Expected behavior
The post screen should open.
Screenshots

🔻🔻🔻🔻🔻🔻🔻🔻🔻🔻🔻🔻🔻🔻

Details

Platform: Android Sony Xperia SOG03
Platform version: Android 13 (API Level 33)
App version: 1.88.0

Additional context
I am unsure if this should be classified as a feature request.

I encountered the same issue. When the Bluesky app is already running in the background, opening the post screen works correctly. However, if the Bluesky app is not running, the intent only launches the app without opening the post screen.


Extend support for environment variable expansion

Description
Use the expandvars library to support different bash parameter expansion methods.
This allows use cases such as providing defaults, offsets and indirection.
To retain compatibility any error in expansion (whether due to missing variable, or invalid syntax) will not raise but simply return the config value as declared in the config file - while logging a warning.
pytest-check was added to development dependencies to use multiple assertions per test case

I'lll close this for now since this doesn't appear to be inline with the spec.


Sometimes when changing the page number, the cards keeps loading and buttons to change pages dissapear

I got the issue on chrome.

Hi @morrys, I hope you're doing great.
We're running into this issue when using loadQuery on version 3.7.0 of relay-hooks.
Specifically when things happen in this order:

prefetch.next(environment, queries[path], query) gets called with queries[path] 1, and query 1.
prefetch.next(environment, queries[path], query) gets called with queries[path] 2, and query 2.
prefetch.next(environment, queries[path], query) gets called with queries[path] 1, and query 1.
prefetch.next(environment, queries[path], query) gets called with queries[path] 1, and query 3.

In the app, this happens when:

You load the first page.
You navigate to a specific profile.
You navigate back to the first page.
You paginate to the second page.

After that last call with the first query, but new variables, I see the network responds correctly, but relay-hooks returns null and never updates.
Any idea what might be going on?

hi @epiqueras & @clesaege,
i just created a PR that solves the problem in version 4.0.0 👍
Soon I intend to officially release the 4.1.0 release with this fix too.
At the moment I prefer not to keep version 3.x active even if in the PR I put a comment how to solve the problem in version 3.7.0

Thanks, @morrys, that's super helpful.
I did try version 4.0.0 before opening this, and I found many other issues. Do you think it would be possible to backport the fix and release 3.7.1?

What kind of issue? I tried it and i just had to edit the useQuery in these files:

I think that the problem is related to the same PR

@epiqueras, your feedback on the version of relay hook currently on the master (4.1.0) would be very helpful.
so, if there are any problems I can help you investigate before officially releasing it 👍

@morrys, when can you release a beta so that I can test it?

@morrys, the fix you described here relay-tools/relay-hooks/pull/154 for v3.7.0 works perfectly.
I tried version 4, but it's slowing the app down a lot, and being this close to a release, I prefer to be safe with a v3.7.1.
I've forked the repo and patched it myself so that it works until you have time for cutting a new release.
Thanks so much for the quick and accurate help :smile:

Small update:
the problem was caused by the incompatibility between relay-hooks 4 and relay-runtime 10.0.1.
To use relay-hooks 4.x you need to have:
"peerDependencies": {
"react": "^ 16.9.0 || ^ 17",
"relay-runtime": "> = 10.1.0"
},


Add telemetry for persistent share

It would be great to understand if people are making use of the persistent share feature.
So, this request would be to add a tick for when people 're-share' their projects (they make an update and publish the change to the persistent link).

This is implemented. Here is the tick. True will tell you users reshared their project.
RawEventsCustomEvents
| where monthofyear(timestamp) == 11
| where cookie == "true"
| where name startswith "share.open.loggedin"
| summarize dcount(user_Id) by tostring(customDimensions.persistent)


Incompatible with 1.20.2

Attempting to start up the game with latest mod causes the client to crash.

Closing this as this LibGUI fork solved the problem.


TLS Passthrough with Kubernetes Gateway API does not work

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
I have been trying to set up TLS passthrough with the new Kubernetes Gateway API. I installed istio with the PILOT_ENABLE_ALPHA_GATEWAY_API=true flag.
Problem
I have Kubernetes Dashboard deployed in the kubernetes-dashboard namespace.
$ kubectl get svc kubernetes-dashboard -n kubernetes-dashboard

NAME                   TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)   AGE
kubernetes-dashboard   ClusterIP   <IP_ADDRESS>   <none>        443/TCP   30h

And I have the following things set up for the ingress:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: dev-gateway
  namespace: istio-ingress
spec:
  gatewayClassName: istio
  listeners:
    - name: k8s-dashboard
      hostname: "k8s.loom-lang.dev"
      port: 443
      protocol: TLS
      tls:
        mode: Passthrough
      allowedRoutes:
        namespaces:
          from: All
---
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: TLSRoute
metadata:
  name: kubernetes-dashboard
  namespace: istio-ingress
spec:
  parentRefs:
    - name: dev-gateway
      namespace: istio-ingress
  hostnames:
    - "k8s.loom-lang.dev"
  rules:
    - backendRefs:
        - name: kubernetes-dashboard
          namespace: kubernetes-dashboard
          port: 443
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: ReferenceGrant
metadata:
  name: kubernetes-dashboard
  namespace: kubernetes-dashboard
spec:
  from:
    - group: gateway.networking.k8s.io
      kind: TLSRoute
      namespace: istio-ingress
  to:
    - group: ""
      kind: Service
      name: kubernetes-dashboard

The gateway seems to register the route (kubectl get gtw -n istio-ingress -o yaml):
apiVersion: v1
items:
- apiVersion: gateway.networking.k8s.io/v1beta1
  kind: Gateway
  metadata:
    annotations:
      gateway.istio.io/controller-version: "5"
    creationTimestamp: "2023-10-13T14:44:18Z"
    generation: 5
    labels:
      kustomize.toolkit.fluxcd.io/name: infra-ingress
      kustomize.toolkit.fluxcd.io/namespace: flux-system
    name: dev-gateway
    namespace: istio-ingress
    resourceVersion: "80522"
    uid: c4857ca8-3e8b-40b5-88d1-3ebac6141e79
  spec:
    gatewayClassName: istio
    listeners:
    - allowedRoutes:
        namespaces:
          from: All
      hostname: k8s.loom-lang.dev
      name: k8s-dashboard
      port: 443
      protocol: TLS
      tls:
        mode: Passthrough
  status:
    addresses:
    - type: IPAddress
      value: <IP_ADDRESS>
    conditions:
    - lastTransitionTime: "2023-10-13T14:44:18Z"
      message: Resource accepted
      observedGeneration: 5
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2023-10-14T15:48:08Z"
      message: Resource programmed, assigned to service(s) dev-gateway-istio.istio-ingress.svc.cluster.local:443
      observedGeneration: 5
      reason: Programmed
      status: "True"
      type: Programmed
    listeners:
    - attachedRoutes: 1
      conditions:
      - lastTransitionTime: "2023-10-13T14:44:18Z"
        message: No errors found
        observedGeneration: 5
        reason: Accepted
        status: "True"
        type: Accepted
      - lastTransitionTime: "2023-10-13T14:44:18Z"
        message: No errors found
        observedGeneration: 5
        reason: NoConflicts
        status: "False"
        type: Conflicted
      - lastTransitionTime: "2023-10-13T14:44:18Z"
        message: No errors found
        observedGeneration: 5
        reason: Programmed
        status: "True"
        type: Programmed
      - lastTransitionTime: "2023-10-13T14:45:42Z"
        message: No errors found
        observedGeneration: 5
        reason: ResolvedRefs
        status: "True"
        type: ResolvedRefs
      name: k8s-dashboard
      supportedKinds:
      - group: gateway.networking.k8s.io
        kind: TLSRoute
kind: List
metadata:
  resourceVersion: ""

But when trying to do curl k8s.loom-lang.dev I get back the following in the logs:
[2023-10-14T20:53:40.228Z] "- - -" 0 NC - - "-" 0 0 1 - "-" "-" "-" "-" "-" - - <IP_ADDRESS>:443 <IP_ADDRESS>:35780 k8s.loom-lang.dev -

Similar, working setup
Using TLS Termination and HTTPRoute with a different service but otherwise the exact same setup works perfectly.
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: dev-gateway
  namespace: istio-ingress
spec:
  gatewayClassName: istio
  listeners:
    - name: https
      hostname: "*.loom-lang.dev"
      port: 443
      protocol: HTTPS
      tls:
        mode: Terminate
        certificateRefs:
          - name: loom-lang-dev-tls
      allowedRoutes:
        namespaces:
          from: All
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: gitops-dashboard
  namespace: istio-ingress
spec:
  parentRefs:
    - name: dev-gateway
      namespace: istio-ingress
  hostnames:
    - "gitops.loom-lang.dev"
  rules:
    - backendRefs:
        - name: weave-gitops-dashboard
          namespace: flux-system
          port: 9001
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: ReferenceGrant
metadata:
  name: weave-gitops-dashboard
  namespace: flux-system
spec:
  from:
    - group: gateway.networking.k8s.io
      kind: HTTPRoute
      namespace: istio-ingress
  to:
    - group: ""
      kind: Service
      name: weave-gitops-dashboard

Version
$ istioctl version
client version: 1.19.3
control plane version: 1.19.3
data plane version: 1.19.3 (7 proxies)

$ kubectl version
kubectl version
Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.0

$ helm version --short
v3.13.0+g825e86f

Additional Information
bug-report.tar.gz

IMO, something like https://github.com/istio/istio/issues/47341. You can try to build the following ReferenceGrant to workaround:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: ReferenceGrant
metadata:
  name: kubernetes-dashboard
  namespace: kubernetes-dashboard
spec:
  from:
    - group: gateway.networking.k8s.io
      kind: HTTPRoute
      namespace: istio-ingress
  to:
    - group: ""
      kind: Service
      name: kubernetes-dashboard

You're right, changing the ReferenceGrant to HTTPRoute fixes the issue.
Thank you for the workaround!

as https://github.com/istio/istio/pull/47342 is merged, the workaround will no longer in effect and the original (and valid) configuration can be used.

marking as resolved

I tried the same (TLS passthrough) with istio 1.21.0 with k8's gateway api. Looks like TLS passthrough does not work. Below is my Gateway config. My backend app seem to work only with passthrough. The same Gateway config seem to work with contour. is there any limitation with istio (gateway api) ?

TLSRoute


Methods of objects in state lost when doing time-travel

I have an object named quizzes in the $store.state, which has a method called remove(). Normally I can access $store.state.quizzes.remove() as following:

But after I did time-travel like this:

I found the remove method is lost:

Having methods in the state undermines many ideas of Vuex, including serializability of the state and ability to track changes to the state to make time travel possible. Mutations and actions is where you should put the behavior instead.

Got it. Thanks~


Add python 3.11 support and test on the CI for all the supported version

Hey, thanks for PR. There seems to be some issues. I believe the 3.7 and 3.8 issues are not caused by your changes. however for 3.11 some issues arise in poetry. Would you mind checking?

This is my first time with poetry, all tests pass for all python version on my laptop.

@cheind Could you please approve running the CI?

thanks!


ifndef/define/`endif

Can current version realize auto-generate ifndef/define/`endif snippets according to filename? It's really a useful snippets to me.

This does not need to be part of this plugin, just define a snippet (save following code in a file with extension .sublime-snippet in your user package directory):
<snippet>
    <content><![CDATA[`ifndef ${TM_FILENAME/(.*)\.(.*)/\U$1\E/g}
`define ${TM_FILENAME/(.*)\.(.*)/\U$1\E/g}
$0
`endif
    ]]></content>
    <!-- Optional: Tab trigger to activate the snippet -->
    <tabTrigger>ifndef</tabTrigger>
    <!-- Optional: Scope the tab trigger will be active in -->
    <scope>source.systemverilog</scope>
    <!-- Optional: Description to show in the menu -->
    <description>ifndef filename</description>
</snippet>


Create Backstage Plugin for Odo CLI to Bootstrap Application Development with Devfiles

/kind feature
As part of improving the developer experience and enabling efficient application development, we propose creating a Backstage plugin that integrates with the Odo CLI to facilitate the quick and easy bootstrapping of applications using devfiles. Devfiles provide a standardized way to describe development environments, making it easier for developers to get started with projects.
Acceptance Criteria:
To consider this issue complete, the following criteria should be met:

Backstage Plugin Creation:

[ ] Develop a new Backstage plugin dedicated to integrating with the Odo CLI.
[ ] Ensure that the plugin is well-documented and follows best practices for Backstage plugin development.
[ ] Add plugin to Janus community

Integration with Odo CLI:

[ ] Implement integration with the Odo CLI, allowing developers to interact with the CLI from within Backstage.

Application Bootstrap using Devfiles:

[ ] Enable the plugin to support the bootstrapping of applications using devfiles.
[ ] Provide a user-friendly interface within Backstage for editing devfile-based application configurations.

Testing and Quality Assurance:

[ ] Include comprehensive unit and integration tests to verify the functionality of the plugin.
[ ] Ensure that the plugin functions correctly with a variety of devfile configurations.

Documentation:

[ ] Document the usage of the Backstage plugin in the official Backstage documentation.
[ ] Include detailed instructions on how to configure and use the plugin for application development with devfiles.

Community Engagement:

[ ] Promote the availability of this new Backstage plugin within relevant communities and forums.

Compatibility:

[ ] Ensure that the plugin is compatible with the latest versions of Backstage and Odo CLI.

Sub-stories/tasks:

[ ] https://github.com/redhat-developer/odo/issues/7086
[ ] https://github.com/redhat-developer/odo/issues/7087

Cabal (2023-09-25)

Template => for creating a new repo + new Devfile
Plugin for 2 different flows:

if project has a Devfile
if project does not have a Devfile

Status Update (as of Oct 19, 2023):
Based on the various discussions that we had, the work has been tackled from different (complementary) perspectives:

https://github.com/redhat-developer/odo/issues/7114 as a separate epic to track the work for the Backstage Golden Path Template creation. This is the current priority.

See https://github.com/rm3l/odo-backstage-golden-path-template and https://github.com/rm3l/backstage-odo-devfile-plugin for further details.

A Backstage plugin (actually both Backend and Frontend Plugins) to support the Devfile Builder editor into Backstage: https://github.com/redhat-developer/odo/issues/7105

Acceptance Criteria: To consider this issue complete, the following criteria should be met:

Backstage Plugin Creation:

[ ]  Develop a new Backstage plugin dedicated to integrating with the Odo CLI.

A custom action plugin has been implemented in https://github.com/redhat-developer/odo/issues/7116, with the goal of using that to execute odo from a Backstage Template (so it would be a means to integrate the Odo CLI).
It currently assumes the odo binary is installed in the environment the Backstage instance is running in.
As commented out in https://github.com/redhat-developer/odo/issues/7116#issuecomment-1771110834, we still need to think of a way to distribute odo alongside the plugin module.
Anyway, to integrate the Devfile Builder Editor (Frontend Plugin) into Backstage, we would need to implement a specific Backend Plugin (https://github.com/redhat-developer/odo/issues/7107). We can think about the odo distribution while working on this specific Backend Plugin..

[x]  Ensure that the plugin is well-documented and follows best practices for Backstage plugin development.

Done in https://github.com/rm3l/odo-backstage-golden-path-template and https://github.com/rm3l/backstage-odo-devfile-plugin

[ ]  Add plugin to Janus community

Integration with Odo CLI:

[ ]  Implement integration with the Odo CLI, allowing developers to interact with the CLI from within Backstage.

Application Bootstrap using Devfiles:

[]  Enable the plugin to support the bootstrapping of applications using devfiles.
Bootstrapping possible via https://github.com/redhat-developer/odo/issues/7114.
See https://github.com/redhat-developer/odo/issues/7114#issuecomment-1771129019 for the remaining items.
Not covered yet: creating Devfile for existing applications with already existing source code.

[ ]  Provide a user-friendly interface within Backstage for editing devfile-based application configurations. #7105

Testing and Quality Assurance:

[ ]  Include comprehensive unit and integration tests to verify the functionality of the plugin.
[ ]  Ensure that the plugin functions correctly with a variety of devfile configurations.

Documentation:

[ ]  Document the usage of the Backstage plugin in the official Backstage documentation.
[x]  Include detailed instructions on how to configure and use the plugin for application development with devfiles.

Community Engagement:

[ ]  Promote the availability of this new Backstage plugin within relevant communities and forums.

Compatibility:

[x]  Ensure that the plugin is compatible with the latest versions of Backstage and Odo CLI.

/remove-lifecycle stale
/lifecycle frozen


lab() and lch() color previews added

Issue #305
Main Repo Issue microsoft/vscode#165207

[x] Added lab() preview
[x] Added lch() preview
[x] Added basic unit tests for lab()
[x] Added basic unit tests for lch()
[x] Fixed logic where negative values inside a color function were not parsed
[ ] Added oklab() preview
[ ] Added oklch() preview

Thanks for the PR, it looks promising. I added comments.

please format the changes with the TypeScript formatter built-in in VS Code
use const when possible

Thank you for this @GauravB159!
I've gone over these changes and the conversions don't seem to be accurate.
Can you share the source of the transforms?
Good reference code can be found here : https://github.com/w3c/csswg-drafts/tree/main/css-color-4
WPT has a bunch of tests : https://wpt.fyi/results/css/css-color?label=master&label=experimental&aligned&view=subtest
We also have a bunch of tests : https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-lab-function/test/basic.display-p3-false.preserve-true.expect.css
And also code that you can take : https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-lab-function/src/css-color-4
But best of all would be to use https://github.com/LeaVerou/color.js, if @aeschli is open to adding this as a dependency?
The authors of this package are the specification editors for most of the things related to color in CSS.

One very important aspect that doesn't seem to be covered here is out of gamut color handling. It is not possible to round trip lab -> rgb -> lab for all colors without changing the channel values. This might be confusing for users if they are not aware of this and just switch to a different color function out of habit.

Hi @romainmenke
I used this webpage for a reference for the formulae. Is there somewhere I could see the correct values?
I was using this online converter to verify my values. It does give values in decimals, but rgb requires whole numbers I guess, so I have rounded the values at the end. Maybe that is causing an issue?
lab -> rgb -> lab is probably inaccurate because of the rounding up right? Is there a workaround to that that I could implement?
Thanks for your help! I'll check out the code you linked, maybe there's some issue with the formula implementation.

Thanks for the great info @romainmenke !
No added dependencies please. It would mean quite some administrative overhead as I have to get legal approvals. Also for maintenance it's easier if we own all the code.

lab -> rgb -> lab is probably inaccurate because of the rounding up right? Is there a workaround to that that I could implement?

Rounding errors might also cause this, but those would be very small deviations.
lab, lch,... however can all express a lot more colors than srgb (even some colors that do not exist). So a valid value in lab might not have a corresponding value in srgb.
I think there are three options :

allow channel values in srgb to go under 0 or above 255. (this options is lossless)
clamp channel values in srgb to 0 - 255. (lossy and gives poor results)
apply a gamut mapping so that colors from lab that are out of gamut for srgb are visually similar. (lossy and gives ok results)

The "right" option depends on the function of this feature in VSCode :

a way to change the format of a color function without changing the value
a way to change a color in one color space to a another
a way to change a modern format to a legacy format or back
....

No added dependencies please. It would mean quite some administrative overhead as I have to get legal approvals. Also for maintenance it's easier if we own all the code.

Got it!
Yes avoiding all that is better.
The code linked from the CSSTools repo is a port to TypeScript from the reference implementation that exists in the csswg-drafts repo.
It has the same W3C license because the only thing I did was add typings.

@romainmenke Yeah, I understand what you're saying. Now that you mention it, I remember there were negative and valuss greater than 255 after converting to sRGB. I clamped those values to 0-255 which might be causing the loss.
@aeschli Which option do you recommend we go with? We could store the negative values and clamp them just while displaying the color possibly.
Although this might still cause issues in a lab->rgb->lab conversion through the color picker since it will pick up the clamped string from the new rule and use that, and not the stored negative values.

Conversion from a wide to a narrow gamut is naturally lossy, so that should not be avoided. In the case of the color picker, the users can be informed that conversion is lossy, like in Chrome's DevTools color picker: https://developer.chrome.com/docs/devtools/css/color#convert-colors This approach may require ditching the click-to-convert in favor of a dropdown.

Conversion from a wide to a narrow gamut is naturally lossy

When displaying a color on a screen or in print, yes.
But wide gamut colors can still be represented in narrow gamut notations by going beyond the  value ranges that describe the boundaries of the narrower gamut.
These round-trip just fine if the implementations are correct.
rgb(300, -20, 0) -> beyond 0 - 255, so out of gamut but otherwise there is nothing weird about these values.
There is no mathematical reason to make these lossy when converting from one notation to another.

Interesting, rgb(300, -20, 0) seems to be valid in CSS, and browsers take care of clamping it to sRGB. This leads me to believe the option 1 @romainmenke suggested

allow channel values in srgb to go under 0 or above 255. (this options is lossless)

fits VSCode usecase the best, though I'm curious how would rgb(300, -20, 0) be converted to hex.


Vite 3 migration

Various changes to migrate to Vite 3.0. Only tested on Windows 11.

Use --api.port instead of --api.
Bind to <IP_ADDRESS> instead of localhost (breaking change)
Fix parsing error by escaping special characters in test names (e.g., "add 1 + 1" => "add 1 \+ 1")
Stop capitalizing the first character of the test file path name. I'm not entirely sure why this was being done originally, but it was creating a mismatch with the way vitest was gathering the test file names. Vitest does a simple case-sensitive .includes() check, so c:\ was not matching the C:\ in the paths that vitest is producing. This case-sensitive matching was breaking the "Debug Test" feature.

that good, hope this will be merge soon

Just tested it on mac. Looks great. Thanks!

@falynx  please take a look, I tested you new code but the case sensitive on window still not working, it's fail on my windows computer on version 0.2.32

[INFO 2:35:05 PM]

><EMAIL_ADDRESS>test:run g:\small-cosmos\losa

> vitest run --config ./configs/vitest/vitest.config.ts "g:/small-cosmos/losa/libs/tester/src/lib/server/register.test.ts" "-t" "Register" "--api.port" "57204" "--api.host" "<IP_ADDRESS>"

[INFO 2:35:05 PM] WS Close

can you make a little change to update the driver to be uppercase on windows? @falynx

I get this, look like pnpm and yarn not recognize, maybe because of this.

@falynx  what is your environment?
I'm thinking of check if it's window we uppercase?

@falynx thank you, it work on the example repo, maybe it happen on my project config, I will try to figure out

I understand now, it must be happen because I'm using vitest 3x instead of 2x which have different path result which cause test fail

@falynx  it simply not work with vite 3, I dont know why :(

the basic project not work sir, I think maybe it computer or something, I try to modify it but give up, I just run vitest manually

https://drive.google.com/file/d/1CkfnobWuEH4k8qTkm5ky7HbP-9RJu_Gn/view?usp=sharing
finaly, the nodejs 18.1 is the problem


Added "Boiler heatpower" and "Total system power" sensors

The "Boiler heatpower" sensor calculates the added heatpower by the boiler when the boiler is active.
The "Total system power" sensor calculates the total heatpower generated by the heatpumps and boiler.
It calculates the waterdelta between the heatpumps (HP1 or HP2 - depending on the configuration) and the temperature of the water at the flowmeter and multiplies it with the flowrate and the conversion factor
BoilerHeatpower = (flowWaterTemperature - heatpumpWaterOut) * flowRate * conversionFactor
With this value and some helper sensors an estamation can be made regarding how much gas has been used by the boiler for heating.
The conversionFactor has been brought in line with the Quatt calculation and "Heat transfer equation"
The Quatt power sensor cannot go negative anymore since CIC version 2.20.2. The calculated heat power sensors now show the same behaviour.

@marcoboers, do you need more information before merge?
Do you have an update regarding timelines?

@patrickvorgers thanks! I will release them!


Cannot assign to read only property 'namespace' of xsd:string

Hi there,
Here is my code, which works locally with node 0.11.14:
return new Promise(function (resolve, reject) {
			//resolve(false);
			if (!iban) {
				reject(new Error('IBAN must be provided'));
			}

			soap.createClient(config.url, function (err, client) {
				var args = {
					iban     : iban,
					user     : config.user,
					password : config.password
				};

				/*jshint camelcase:false*/
				client.validate_iban(args, function (err, result) {
					var blz = false;
					if (_.hasPath(result, 'return.bank_code.$value')) {
						blz = result.return.bank_code.$value;
					}
					resolve(blz);
				});
				/*jshint camelcase:true*/
			});
		});

This is my test:
    it('checks correct iban', function (done) {
        ibanrechner.getBlzByIban('PL2510301944****101620901000').then(function(result){
            console(result);
            expect(1).to.equal(1);
            done();
        }).catch(function(err){
            console.log(err);
            expect(0).to.equal(1);
            done();
        });
    });

And this is what I got when this test performs on my build server:

Could someone tell me what is wrong here?
I've tried another variant with the chai-as-promised lib, but the soap is not working on my build server.
What could be a reason of the error?
Regards,

I've checked, the same issue has place on 0.11.16 .
Any feedback?

Hello @PavelPolyakov - thanks a lot for filing this issue. As you might see from our Travis CI Config File all our test are run against node v0.8 and node v0.10 and we're currently not supporting node v0.11.
From looking at your code samples I can't tell what could be going wrong here - it would help a lot if you could track it down by debugging in MessageElement.postProcess(), at least.

Here is the state of the variables at that point:

Anyhow, thanks for the client, hope soon you would support the node 0.11 as well :)
I'm new to node, so it's hard to say for me which change from 0.11.14 to 0.11.15 could bring this issue on the table.
Currently I do not need any deep SOAP integration, so I would just emulate the SOAP POST query with request.

It also happens on iojs 1.0.4 and 1.1.0.

+1
on node v0.12.0

Likely this is also relate to #555 - @timmckenzie did some research and found a possible related bug in the request library node-soap is using.

This seems to be caused by newer versions of node/iojs enforcing JavaScript strict mode: you can’t declare properties of primitives. I can’t actually find documentation that says that’s a rule exactly, but Node definitely thinks it is.
Here, you are assigning to a property of elem. It looks like elem is usually an object, but sometimes it’s a string primitive, like when the description comes from here. The viable solutions are:

Turn off strict mode in wsdl.js
Refactor the element descriptions such that they always return an object

If you try to assign properties to a primitive when you're not in strict mode, nothing happens:
var primitive = 'foo';
primitive.prop = true;
primitive.prop; // undefined

So I propose just to wrap the offending lines in if (typeof elem !== 'string'). Any issues with that? PR to follow.


SonarQube fixes

Codecov Report

Merging #297 into dev will increase coverage by 0.05%.
The diff coverage is 63.41%.

@@             Coverage Diff              @@
##                dev     #297      +/-   ##
============================================
+ Coverage     37.23%   37.28%   +0.05%
- Complexity     1663     1667       +4
============================================
  Files           103      103
  Lines         23673    23681       +8
  Branches       3882     3880       -2
============================================
+ Hits           8814     8829      +15
+ Misses        13261    13259       -2
+ Partials       1598     1593       -5

Flag
Coverage Δ
Complexity Δ

#JDBC41
37.17% <63.41%> (+0.08%)
1663 <1> (+6)
:arrow_up:

#JDBC42
37.2% <63.41%> (+0.11%)
1664 <1> (+8)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
47.4% <ø> (-1.86%)
9 <0> (-1)

...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../microsoft/sqlserver/jdbc/SQLServerXAResource.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...oft/sqlserver/jdbc/SQLServerParameterMetaData.java
25.64% <0%> (ø)
30 <0> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
36.99% <0%> (-0.04%)
0 <0> (ø)

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
59.08% <0%> (ø)
129 <0> (ø)
:arrow_down:

...java/com/microsoft/sqlserver/jdbc/StringUtils.java
37.5% <50%> (-22.5%)
4 <1> (ø)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
47.15% <82.75%> (+1.28%)
60 <0> (-1)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b87c3...6106de6. Read the comment docs.

@v-afrafi, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

closing this PR to create another one for RTW branch.


Update to quap to Turings MAP

As mentioned before, with Turings new capabilities things get much easier. We don't have to find a starting point and adding return statements to the model is not necessary.
I'm not sure if making a difference between the 1D case and the rest makes sense, it's just a little more convenient because it allows rand(distr, 10) to return a Vector then. But then again, 1D isn't really that special.
I was thinking about adding a QuApResult type so we can have convenient rand(result), precis(result) (or what else have you)  functions.

I just noticed that adding start values for the optimization errors:
https://github.com/TuringLang/Turing.jl/issues/1298

Nice catch! No doubt will be fixed soon! Shall we merge or hold off until this is fixed?

I don't think I have an opinion on this. It's not really used anywhere right now (except by me internally) so I don't think it makes much of a difference.

Ok, I’ll merge it.


feat(Data.Finset): add Finset.filterMap

Zulip thread
I didn't bother translating all of the lemmas from Multiset.filterMap. And there's a couple lemmas I'm not sure about. Feel free to just remove them.

bors r+


[New game]: shape catcher game

🎮 Game Request
All you need to do is catch the element on the screen
Point down the features
Game will be evaluated on the basis of the time taken by the player
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @S-ishita !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @S-ishita!
We are already having a similar game request in #529 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @S-ishita ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Environment broken in 9.3.0

Initialisation of the HDFPanda results in a NameError for Optional (but this works fine in local tests)

I thought it might be due to the requirement pinning, but I rebuilt the environment by hand without the pins and that didn't change anything


Release v0.1.1

What type of PR is this?
Add one of the following kinds:

documentation

What this PR does / why we need it:
Create release branch for v0.1.1 and include CHANGELOG

Hi @ToshiWakayama-KDDI !
please take a look if you have a moment. Thanks!

Sorry for the delay.  I will look at it straightaway.


Usage of broken MIG version

Managed instance groups 1.1.9 is broken (see https://github.com/GoogleCloudPlatform/terraform-google-managed-instance-group/issues/20).
Nat gateway 1.1.10 specifies mig-1.1.9 but nat gateway 1.1.9 does not specify mig version, hence mig-1.1.9 is picked up.
Maybe the mig version should be a variable to allow the client to choose non-broken version should this happen in future.
Either way, there needs to be a new version of nat-gateway that specifies mig-1.1.8 as it is currently unusable.
module.nat-gateway.data.google_compute_zones.available: data.google_compute_zones.available: project: required field is not set

This should be fixed now with 1.1.10 of the managed instance group module. Since it's also the latest, nat gateway 1.1.9 should pick up the latest mig version too.

Updated to 1.1.11 which is working now. Closing.


Upgrade package for use with ST 4132+

This PR suggests a major upgrade to

use latest features and base syntaxes of ST 4132.
upgrade liquid language features
fully support Jekyll syntax tags

Note: This PR requires a change to package_control_channel to limit this changes to ST4132+
Suggestion: Interested in moving the package to SublimeText organization?

@braver: Any thoughts?

Sorry for not responding. Apparently my GitHub account kinda broke and was unable to send me notifications by e-mail, and effectively also unable to notify me about the problem. I was wondering why everything was so quiet 😆

Suggestion: Interested in moving the package to SublimeText organization?

Yes, definitely. Shall I just initiate the move? I haven't used this languages in ages and have no immediate interest in maintaining it all by myself.

Alright, it's all yours. Hit me with a PR over at package_control_channel when you're ready.

Something seems wrong with your invitation link. Can't accept it.
Basically I am done. Just reorganized work into develop branch to keep master clean. Also created a st4126 branch on my end with a backported Markdown syntax, so we can provide all features for latest stable release as well.
As you are already a maintainer of SublimeText organization you should probably be able to move the package and rename it to "Liquid" afterwards. If an admin is required we might ask @FichteFoll to help us out - maybe at least with adding me as contributor/maintainer.
I'd update package control registry to use new location then.

I have renamed the repository and configured permissions for @braver and @deathaxe.

Something seems wrong with your invitation link. Can't accept it.

Yeah, that wasn't necessary. I couldn't find the transfer button and also assumed I couldn't do the transfer myself. But I found out I could and it has already been done. Sorry about the confusion, I'm rusty...

As an aside, you may want to include a license.

As an aside, you may want to include a license.

done


.dll file stays loaded/doesn't get deleted when installer closes

I use the NScurl plugin to download a file like this:
NScurl::http GET "$5" "$6" /SILENT /CANCEL /INSIST /TIMEOUT 30s /CACERT "${TEMP_DIR}\cacert.pem" /RETURN "@ERRORTYPE@:@ERRORCODE@" /END

Everything works fine, but the plugin remains in $PLUGINSDIR even after the installer is finished. All the other files from that folder get removed correctly.
I also tried deleting the folder by myself using
SetOutPath $TEMP
RMDir /r $PLUGINSDIR

on the .onGUIEnd function, but it doesn't work as well.
The only thing that works is setting the /REBOOTOK flag and then rebooting to completely remove it, which is fine, though I'd like to remove it without a reboot, if possible.

This is a known issue and there is no working solution for it yet.
The problem lies in the underlying libcurl framework.
I was forced to block NScurl.dll from unloading (and thus creating this issue) because otherwise libcurl might end up crashing. The crash was actually confirmed on older platforms like Windows XP, Vista, etc.
As mentioned in the curl_global_cleanup documentation, libcurl should not be used in modules that unload dynamically (like NScurl.dll does). So, to prevent potential crashes I came up with this "hack" a while ago...
Let's keep this issue opened and keep looking for a fix...
Thanks for reporting!

Thank you for answering!
I'm somewhat relieved because i thought something isn't working right with my installer.
It definitely makes sense the way you handled this, I'll be looking into this as well, maybe we'll come up with a solution for this at some point.

Hi! I also had this issue and I solved it by calling the FreeLibrary function on the .onGUIEnd callback:
Function .onGuIEnd

  ; Get the NScurl module handle
  System::Call "kernel32::GetModuleHandle(t 'NScurl.dll') i .s"
  Pop $0

  ${If} $0 != 0
    ; Free the NScurl module
    System::Call "kernel32::FreeLibrary(i $0) i .s"
    Pop $0
  ${EndIf}

FunctionEnd

I don't know if this is the correct procedure but it works! The NScurl.dll file is removed along with the TEMP folder and I didn't have any problems/crashes since it was implemented.

@mherrera01: this trick works on recent Windows builds (10, 11) but not on older ones (7, 8)
Here's what happens on Windows 8:

That is unfortunate... I only tested the code with Windows 10/11. Maybe on recent versions a silent crash is happening and Windows handles it correclty. But the problem is still there and it has been an issue since 2016 (a long time ago with no progress as far as I can see).
I understand that the crash happens when you unload the library and there are still libcurl internal threads running. Is there not a way to kill them manually and then call curl_global_cleanup?

I'm not convinced that getaddrinfo_thread is causing our crash.
I can reproduce it without getaddrinfo_thread ever running.
I suspect that the issue (...or multiple issues) lays deep in openssl.
I've found this ticket https://github.com/openssl/openssl/issues/24581
...suggesting that similar problems were fixed recently. Waiting for the next openssl build to see what happens

I've never worked with libCurl/OpenSSL so i cannot help much. The info I found that can be related to this issue is how atexit() behaves when the library unloads [Ref]:

OpenSSL uses atexit() to cleanup after itself. Some OSes will handle this nicely and call the atexit() handler just before the library unloads. Some will not and will call the atexit() handler at process exit, even if the handler has already been unloaded, which leads to a crash. To prevent this issue we forced the OpenSSL libraries to remain loaded until process exit - which was the best of a bad set of options. Mostly this works fine but does cause problems in exactly the scenario you describe, i.e. statically linking an SO to OpenSSL and then trying to dynamically load/unload the SO.

Also, the OpenSSL docs states the following for OPENSSL_thread_stop() on Notes section:

Similarly this message will also not be sent if OpenSSL is linked statically, and therefore applications using static linking should also call OPENSSL_thread_stop() on each thread. Additionally if OpenSSL is loaded dynamically via LoadLibrary() and the threads are not destroyed until after FreeLibrary() is called then each thread should call OPENSSL_thread_stop() prior to the FreeLibrary() call.

Just in case it can help you. Let's wait to see if version 3.4.0 of OpenSSL solves the problem with the ticket you mentioned.
By the way, thank you for this plugin 🙏. Great work! Nice to see that this repository is still active.

Good news, guys
I think I've found a fix for the unload crash
The issue:

openssl calls atexit(OPENSSL_cleanup) to register its automatic cleanup callback (see openssl/crypto/init.c)
OPENSSL_cleanup sits in NScurl.dll since NScurl is statically linked to openssl
at runtime NScurl.dll gets unloaded by the NSIS plugin framework, openssl shuts down, but the OPENSSL_cleanup callback remains registered
at process exit, CRT (C runtime) calls all atexit callbacks, which in our case points inside an unloaded module
process crashes

Notes:
This behavior might differ depending on the OS and/or the compiler

older platforms (XP, Vista, 7, 8) behave as described above. The process crashes at exit
newer platforms (10, 11) somehow mitigate the issue. Could be that atexit callbacks are called at module-detach instead of process-exit, or they are never called if the target function points to an invalid memory page, or something else...
the compiler matters too. NScurl.dll is officially built with mingw-w64 (gcc for windows). The CRT implementation in mingw behaves as described above. The same code compiled with the Microsoft compiler does not crash, not even on older platforms

The fix:

we now build openssl with -DOPENSSL_NO_ATEXIT definition, which prevents it from registering the atexit cleanup callback
we call OPENSSL_cleanup ourselves, while the plugin is still loaded
this way we have a predictable unloading behaviour, regardless of the target platform and the compiler we're using

The fix is included in the latest release
NScurl should now unload correctly and the temp directory should be deleted automatically
Please give it a try and see what happens

Yeah @negrutiu it works! The %temp% is now correctly removed without problems. I even try to quit the installer at the middle of a download and all okay.
What a bizarre issue 🤣. Anyway, thank you for the fix.


URL Editor

docs.plus should have a URL editor similar to google docs:

Google docs does a lot of preview and suggestion things, I think ours can be simpler than that.

I'm surprised there isn't already a prosemirror plugin for this. Maybe it's worth having a look.