HADOOP-17868. Add more tests for BuiltInGzipCompressor

We added BuiltInGzipCompressor recently. It is better to add more compatibility tests for the compressor.

Addressed the comments. Use AssertJ assertions and add exception message.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 38s

trunk passed

+1 :green_heart:
compile
22m 44s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 58s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 50s

trunk passed

+1 :green_heart:
shadedclient
19m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
23m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 54s

the patch passed

+1 :green_heart:
compile
20m 44s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
20m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 9 new + 55 unchanged - 0 fixed = 64 total (was 55)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
18m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m 59s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

192m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux d90836d5231e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0be10caee318d571e217627d9c4fa81b5682aed5

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/2/testReport/

Max. process+thread count
1273 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran @sunchao Please take another look. Thanks!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 20s

trunk passed

+1 :green_heart:
compile
22m 51s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 21s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 24s

trunk passed

+1 :green_heart:
shadedclient
18m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
22m  8s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m  8s

the patch passed

+1 :green_heart:
compile
19m 34s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 8 new + 55 unchanged - 0 fixed = 63 total (was 55)

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 34s

the patch passed

+1 :green_heart:
shadedclient
18m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 10s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

189m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c6bcae0cd4bd 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ec97e9b4424f1f1ec2e4b0ed670ac0afb8a72160

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/3/testReport/

Max. process+thread count
1275 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 30s

trunk passed

+1 :green_heart:
compile
22m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 24s

trunk passed

+1 :green_heart:
shadedclient
18m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
22m  6s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m  6s

the patch passed

+1 :green_heart:
compile
19m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 17s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 8 new + 55 unchanged - 0 fixed = 63 total (was 55)

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 33s

the patch passed

+1 :green_heart:
shadedclient
18m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  7s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

189m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux d957c0992b16 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 09b60c6625d23b85717944dde20bf5dbc7ceb7dd

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/4/testReport/

Max. process+thread count
2060 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran Is this good for you now? Please take another look. Thanks.

kindly ping @steveloughran

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 15s

trunk passed

+1 :green_heart:
compile
22m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 25s

trunk passed

+1 :green_heart:
shadedclient
18m 12s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
18m 32s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
22m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 14s

the patch passed

+1 :green_heart:
compile
19m 29s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 8 new + 56 unchanged - 0 fixed = 64 total (was 56)

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 33s

the patch passed

+1 :green_heart:
shadedclient
18m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 10s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

189m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1335e73c921a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf1baeadec52f540ef65a70776e7f3654f29f0d2

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/5/testReport/

Max. process+thread count
1518 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

As this is test-only change, as I think I should address all comments. If @steveloughran is too busy to response, could we just move forward? @sunchao

LGTM. @viirya could you address the check style issues - I'll merge this after

Thanks @sunchao ! Updated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 12s

trunk passed

+1 :green_heart:
compile
23m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 25s

trunk passed

+1 :green_heart:
shadedclient
23m 51s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 11s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
22m 12s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 12s

the patch passed

+1 :green_heart:
compile
19m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 56 unchanged - 0 fixed = 58 total (was 56)

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 34s

the patch passed

+1 :green_heart:
shadedclient
23m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  5s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

201m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 377f318073fb 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae3e8e0a462cc69323fdae4a70025b750a3da49b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/6/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@viirya there are still two more tiny style issues

Fixed. Weird, I didn't see the two in last report.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 48s

trunk passed

+1 :green_heart:
compile
22m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 24s

trunk passed

+1 :green_heart:
shadedclient
23m 42s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m  3s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
22m 11s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 11s

the patch passed

+1 :green_heart:
compile
19m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
23m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 11s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

201m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 308dcd4ec670 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 217a21e156c170eb15ce320e8fee3d95e0168238

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/7/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 59s

trunk passed

+1 :green_heart:
compile
29m 49s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
27m  2s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
1m 56s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 54s

trunk passed

+1 :green_heart:
shadedclient
26m  4s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
26m 25s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
22m 16s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 16s

the patch passed

+1 :green_heart:
compile
19m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 34s

the patch passed

+1 :green_heart:
shadedclient
24m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 11s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

227m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3336

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0bc571ef90de 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e91252b293dea4f7ef7993099a9ecf8b14559c00

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/8/testReport/

Max. process+thread count
1374 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3336/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

No style issue anymore.

Merged to trunk. Thanks @viirya and @steveloughran !

Thank you @sunchao @steveloughran !


[docs] Updated expo/native section

Use new bootstrapping option
Added notice about emulators
Added info about Expo web support
Related https://github.com/expo/examples/pull/176

thanks evan!

btw, can something be done about expo loaders? that would enable suspense and useLoader: https://github.com/expo/expo-three/issues/171


Bug fixes, new plotting functions, vignette examples, etc.

Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required

[x] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)

[x] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.

This can be checked and addressed by running check_functions.pl and responding to the prompts. Test your code after you do this.

[x] I generated the documentation and checked for errors relating to the new function (e.g. devtools::document()) and added NAMESPACE and all other modified files in the root directory and under man.

Optional but preferred with PRs

[ ] I updated and/or successfully knitted a vignette that relies on the modified code (which ones?)

Checklist for New Functions
Required

[x] I documented my function using ROxygen style.)

[x] All parameters for the function are described in the documentation and the function has a decriptive title.

Example:
#' Use GISTIC2.0 scores output to reproduce maftools::chromoplot with more flexibility
#'
#' @param scores output file scores.gistic from the run of GISTIC2.0
#' @param genes_to_label optional. Provide a data frame of genes to label (if mutated). The first 3 columns must contain chromosome, start, and end coordinates. Another required column must contain gene names and be named `gene`. (truncated for example)
#' @param cutoff optional. Used to determine which regions to color as aberrant. Must be float in the range [0-1]. (truncated for example)

[x] My function uses a library that isn't already a dependency of GAMBLR and I made the package aware of this dependency using the function documentation import statment.

Example:
#' @return nothing
#' @export
#' @import tidyverse ggrepel

Checklist for changes to existing code

[x] I added/removed arguments to a function and updated documentation for all changed/new arguments

[ ] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)

Updates in this PR address resolving existing bugs, quality-of-life updates and the addition of new plotting functions for SVs. The updates include:

get_coding_ssm_status has been updated to call get_coding_ssm to reduce duplicated code.

get_coding_ssm have been updated from seq_type to seq_type_filter (previously returned an error: Error in get_gambl_metadata(from_flatfile = from_flatfile, seq_type = seq_type) : argument 2 matches multiple formal arguments).

In fixing the above-mentioned issue, pretty_lollipop_plot in the vignette is now working the intended way again (issue closed).

prettyOncoplot in the vignette has been fixed, the issue has been closed.

get_coding_ssm with flat_file set to TRUE incorrectly caused the function to try to read from a maf path (non-existing since db is used to retrieve data).

get_ssm_by_region has been updated to make use of recent indexed (tabix) MAFs with respect to selected genome projection. Thus, the chunk that deals with regions has been updated to deal with chr prefixes accordingly.

Flipping colours of SV counts in fancy_ideogram (previously incorrectly labelled deletions as indels and the other way around).

New parameters added to a collection of fancy_x_plots to allow the user to plot an already loaded (MAF-like) df in R, or directly specify a path to such a file. This allows for more flexibility to the affected plotting functions where the user can run these functions in an interactive session without having to run assign_cn_states or get_sample_cn_segments to retrieve plotting data.

New plotting function added - fancy_circos_plot. This function imports RCircos and constructs a highly customizable circos plot. Per default, this plot visualizes translocations (ribbons). Optional arguments will create additional tracks to plot SVs. The user can also annotate the circos plot with gene lists. Optional parameters for VAF filtering, chromosome subsetting and genomic projection is also available. This function calls get_combined_sv to retain SV information (deletions, duplications and translocations).

New plotting function added - fancy_sv_size_plot, Generate plot visualizing SV sizes retreived with get_combined_sv. Subset on variant type, filter on VAF, size etc.

GAMBLR documentation has been updated to reflect the current state and changes included in this PR. All new functions, changes to existing parameters, examples, NAMESPACE etc. have been documented adequately.


[Fix-13917][UI] Fix item, workflow, and task parameters in dependent task nodes can be searched

Purpose of the pull request

this pr closes #13917
fix ui:

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13918 (e2f6b3f) into dev (f9f88cb) will decrease coverage by 0.09%.
The diff coverage is n/a.

:exclamation: Current head e2f6b3f differs from pull request most recent head 4890a2f. Consider uploading reports for the commit 4890a2f to get more accurate results

@@             Coverage Diff              @@
##                dev   #13918      +/-   ##
============================================
- Coverage     38.90%   38.82%   -0.09%
+ Complexity     4458     4439      -19
============================================
  Files          1158     1158
  Lines         42429    42391      -38
  Branches       4776     4751      -25
============================================
- Hits          16506    16457      -49
- Misses        24107    24117      +10
- Partials       1816     1817       +1

see 36 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(input): re-validate when partially editing a date-family input

In date-family input types (date, datetime-local, month, time, week), the user can interact with parts of the value (e.g. year, month, hours etc) independently. Neverhteless, the actual value of the element is empty ('') unless all parts are filled (and valid).
Thus, editing a signle part of the value may result in a change in the validity state of the <input> (see below), without an accompanying change in the actual value of the element. In such cases, no input event is fired by the browser to inform Angular of the change (and the need to
re-validate).

The following scenario describes a series of interactions that would run into the problem (on a browser that supports the date input type):

Initially empty field.

input.value: ''
input.validity: {valid: true, badInput: false, ...}

The user fills part of the value (e.g. the year) using the keyboard.

input.value: ''
input.validity: {valid: false, badInput: true, ...}
'input' event: Not fired   (since input.value hasn't changed)

The user fills the value completely (using either the keyboard or the
date-picker).

input.value: ''
input.validity: {valid: true, badInput: false, ...}
'input' event: Fired

The user deletes part of the value (e.g. the year) using the keyboard.

input.value: ''   (since a partial value is invalid)
input.validity: {valid: false, badInput: true, ...}
'input' event: Fired

The user deletes all parts of the value using the keyboard (i.e. clears the field).

input.value: ''
input.validity: {valid: true, badInput: false, ...}
'input' event: Not fired   (since input.value hasn't changed)

The problematic cases are (2) and (5), because there is a change in the validity state, but no 'input' event is fired to inform Angular of that change and the need to re-validate.

This commit fixes the issue by firing an input event on keyup, correctly triggering re-validation.
Fixes #12207

I wonder if the tests might benefit from the they helper that matsko introduced some time ago. Otherwise it's a lot of repeated code.

I thought that too (having to copy-paste all around and change small things was no fun at all).
The problem is that some of the existing tests are different and some are the same, so onlt some of them could be they'd. And that would result in having tests for each type in two places (some in a dedicated describe block and some in a they block).
That's why I preferred having all tests for each type in a single block (even if that means duplication).
But I'm OK with they'ing as well.

I haven't theyed the tests, though. WDYT (wrt to https://github.com/angular/angular.js/pull/12902#issuecomment-143164271) ?
/cc @Narretz

Regarding the repro comments in the tests: Can we link to this PR instead of repeating them? They are also in the commit message, right?
It just came to my mind, does a similar problem occur when the user cuts / pastes inside the input?

@Narretz, I shortened the comment and added a link to the PR (I want there to be a minimal description, because the test-code is very cryptic imo).
Regarding cut/paste: Theoretically, it could (when not using the keyboard), but (in Chrome at least) you can't cut/paste from/to date inputs.

I just noticed that the second path for older IE that also listens to key events does it a bit differently. For one, it listens to keydown instead of keyup. I think we should do the same, or did you use keyup for a specific reason? The other thing is that the listener not called when modifiers are pressed at the same time. I think we want that, too. Final thing: it uses deferListener, but I am not sure why.

I think it uses keydown because we might want to detect changes before keyup (such as when holding a key but not releasing). I think that makes it more like an input event that fires as soon as a change occurs.
The delay is because on keydown the input value is not updated yet.
In the case of keydown we must also check that the value actually changed to avoid marking an input as dirty from keys that don't actually change anything. Some of those are handled in the keydown handler (arrow or modifier keys) but other things (F#, ?) are not. Might be nice if those 2 different ways of ignoring keydown events were combined somehow, I'd think the one in the keydown handler can be dropped.

As @jbedard explained, on keydown the value is not updated yet. That's why I use keyup (could have gone with keydown and a deferred listener as well).
I wanted to keep this as small as possible, so didn't bother with ignoring not-input keys (I figured the overhead would be minimal). @jbedard, raises an interesting point though, I think: marking the input as dirty when we shouldn't.
@Narretz, @jbedard, do you think I should try to merge the paths for "browsers not supporting input event" and "browsers not supporting the specific type" ?
The problem with the deferListener in the second path is that it only calls listener() is input.value !== origValue, but we will have same value ('') and still want to call the listener.
WDYT ?

I am not sure if the paths need to be merged, but they can probably share some functions.

Digging a little more into this, the problem does only affect Chrome and Opera atm (as they are the only ones that support these types and let you enter values partially.
AFAICT, there is only a limited number of keys that are able to change the value of these fields (monstly numeric keys):
For date, datetime-local, time, week:

0 - 9
numpad 0 - 9
up arrow / down arrow
Backspace, Delete

For month:

0 - 9
numpad 0 - 9
up arrow / down arrow
Backspace, Delete
Some letters (the initials of each month - depends on locale)

I think it's best to only react on these (and still not going to be a perfect solution).
But, I believe it's better than what we have now.

I pushed a new commit with the described changes (basically whitelisting specific keys per input type).
PTAL

Looks good. Adds quite a few lines though ...

And I'm not so sure about the 1000 tests that this adds :/

What is your concern with the number of tests ? We could group them in several ways (e.g. run all keyCodes in a for-loop in one test, all run all input types together), but that wouldn't reduce the number of expectations.

It just feels weird that this simple change adds 1000 expectations.
What I thought was to only test the default keys once (for everything expect datetime-local), and then once again for datetime-local (because it has additional triggers).
@petebacondarwin what do you think about this (the number of tests)?

The expectations are no many because I test every keyCode that shouldn't be ignored (~200 x 5 input types).

I understand your feelings @Narretz but I think we are happier with more tests, especially when they are mostly generated.

I'm not 100% sure about this. Seems weird hardcoding specific key ranges that might effect parts of a date. What if different key ranges are used on different devices or browsers, or locales? What if I use the shift key because my months are capitalized?
Can we not just check for value/validity changes on every keypress? Maybe then this logic could be merged with the keydown logic already present? I haven't actually tried this out though, so I might be completely missing something...

What about something such as 2ffe061e5618cb1b7167451e0cbab925bd66198a instead?
I think this has a few key advantages over the approach in this PR:

avoids hardcoding which keys cause changes (might miss some, i18n issues maybe? different device input types?)
avoids issues where those hardcoded keys do not cause changes (false positives)
also supports other events such as clicking the up/down arrows or using the mousewheel
only invokes listener if the validity actually changes as a result of one of the events (no false positives)

But it still has some issues:

hardcodes event types (might miss some on different types of devices?)
will only change the dirty flag if validity changes - if the input is already invalid, then $setPristine is called, then the user changes the value but it remains invalid then the original bug still occurs

I think those issues are worth the gains and simpler code though...

@jbedard, I think there will be trade-offs in any approach. This will not solve a browser limitation 100%, but improving on the current situation is a big win. I think I like 2ffe061 better (if nothing else it's simpler).
(Funny thing, it seems to be on the angular/angular.js repo, but I can't find it in the commit history - what do I miss ?)

@gkalpak I think that's a github comment bug? If you just put the hash (2ffe061e5618cb1b7167451e0cbab925bd66198a) directly in a comment it seems to always assume it's a commit in this repo, the actual commit is at https://github.com/jbedard/angular.js/commit/2ffe061e5618cb1b7167451e0cbab925bd66198a (in this case I pasted the full URL of the commit).
Should I open a PR? Or do you want to change this one since you have some tests setup?

@jbedard, feel free to open a new PR (or I will later today).

Closing in favor of #13886.


Thanks for raising this issue, @danschef! As you mention in #606, we plan to replace the static coszen from the LUT by the per-pixel value obtained from the Geometry object sometime soon. While that will prevent us from running into the above-mentioned issue, a check of the LUT-based coszen and a useful error message would of course be a needed improvement.


The New-WindowsOnlineImage return Error: Input string was not in a correct format..

When I run the New-WindowsOnlineImage command, it told me the Error formatting string
New-WindowsOnlineImage -ConfigFilePath $ConfigFilePath
6/13/2019 4:53:08 PM - Windows online image generation started.
New-WindowsOnlineImage : Error formatting a string: Input string was not in a correct format..
At line:1 char:1
+ New-WindowsOnlineImage -ConfigFilePath $ConfigFilePath
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Selected switch...ce = true flag.:String) [New-WindowsOnlineImage], R
   untimeException
    + FullyQualifiedErrorId : FormatError,New-WindowsOnlineImage

The PowerShell version：
$PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.17763.503
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.503
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

The config.ini detail:
[DEFAULT]
# The location of the WIM file from the mounted Windows ISO.
wim_file_path=D:\win_server_2016\sources\install.wim
# This is the complete name of the Windows version that will be generated.
# In order to find the possible options, use the Get-WimFileImagesInfo command
# and look for the Name property.
image_name=Windows Server 2016 SERVERSTANDARDCORE
# The destination of the generated image.
image_path=D:\winserver2016.vhdx
# Select between VHD, VHDX, QCOW2, VMDK or RAW formats.
virtual_disk_format=VHDX
# This parameter allows to choose between MAAS, KVM, VMware and Hyper-V specific images.
# For HYPER-V, cloudbase-init will be installed and the generated image should be in vhd or vhdx format.
# For MAAS, in addition to cloudbase-init, the curtin tools are installed
# and the generated image should be in raw.tgz format.
# For KVM, in addition to cloudbase-init, the VirtIO drivers are installed
# and the generated image should be in qcow2 format.
image_type=HYPER-V
# This parameter can be set to either BIOS or UEFI.
disk_layout=BIOS
# The product key for the selected OS.
product_key=""
# A comma separated array of extra features that will be enabled on the resulting image.
# These features need to be present in the ISO file.
extra_features=""
# A comma separated array of extra capabilities that will be enabled on the resulting image.
# These capabilities need to be present in the ISO file.
extra_capabilities=""
# It will force the image generation when RunSysprep is False or the selected SwitchName
# is not an external one. Use this parameter with caution because it can easily generate
# unstable images.
force=False
# If set to true, MAAS Windows curtin hooks will be copied to the image root directory.
install_maas_hooks=False
# Select between tar, gz, zip formats or any combination between these.
compression_format=""
# If this parameter is set, after the image is generated,
# a password protected zip archive with the image will be created.
zip_password=""
# It will stop the image generation after the updates are installed and cleaned.
gold_image=False
# This is the full path of the already generated golden image.
# It should be a valid VHDX path.
gold_image_path=""
# This is a full path to the VMware-tools.exe version that you want to install.
vmware_tools_path=""
# This is the full path of a folder with custom resources which will be used by
# the custom scripts.
# The resources found at this path will be copied recursively to the image
# UnattendResources\CustomResources folder.
custom_resources_path=""
# This is the full path of the folder which can contain a set of PS scripts,
# that will be copied and executed during the online generation part on the VM.
# The PowerShell scripts, if existent, will be started by Logon.ps1 script,
# at different moments during image generation.
# The purpose of these scripts is to offer to the user a fully
# customizable way of defining additional logic for tweaking the final image.
# The scripts files can have the following names: RunBeforeWindowsUpdates.ps1,
# RunAfterWindowsUpdates.ps1, RunBeforeCloudbaseInitInstall.ps1, RunAfterCloudbaseInitInstall.ps1,
# RunBeforeSysprep.ps1, RunAfterSysprep.ps1.
# The script names contain the information on when the script will be executed.
# One can define only some of the hook scripts and it is not mandatory to define all of them.
# If a script does not exist, it will not be executed.
custom_scripts_path=""
# If set to true the Administrator account will be enabled on the client
# versions of Windows, which have the Administrator account disabled by default
enable_administrator_account=False
# If set, it will replace the Cloudbase Solutions wallpaper to the one specified.
# The wallpaper needs to be a valid .jpg/.jpeg image.
wallpaper_path=""
# If set, it will replace the Cloudbase Solutions wallpaper to a solid color.
# Currently, the only allowed solid color is '0 0 0' (black).
# If both wallpaper_path and wallpaper_solid_color are set,
# the script will throw an error.
wallpaper_solid_color=""
# If set to true and the target image format is QCOW2, the image conversion will
# use qemu-img built-in compression. The compressed qcow2 image will be smaller, but the conversion
# will take longer time.
compress_qcow2=False
# A comma separated list of extra packages (referenced by filepath)
# to slipstream into the underlying image.
# This allows additional local packages, like security updates, to be added to the image.
extra_packages=""
[vm]
# This will be the Administrator user's, so that AutoLogin can be performed on the instance,
# in order to install the required products,
# updates and perform the generation tasks like sysprep.
administrator_password=stack@vnet
# Used to specify the virtual switch the VM will be using.
# If it is specified but it is not external or if the switch does not exist,
# you will get an error message.
external_switch=external
# The number of CPU cores assigned to the VM used to generate the image.
cpu_count=4
# RAM (in bytes) assigned to the VM used to generate the image.
ram_size=42949672960
# Disk space (in bytes) assigned to the VM used to generate the image.
disk_size=21474836480
[drivers]
# The path to the ISO file containing the VirtIO drivers.
virtio_iso_path=D:\virtio-win.iso
# The location where the VirtIO drivers are found.
# For example, the location of a mounted VirtIO ISO. VirtIO versions supported >=0.1.6.x
virtio_base_path=""
# The location where additional drivers that are needed for the image are located.
drivers_path=""
[updates]
# If set to true, the latest updates will be downloaded and installed.
install_updates=False
# If set to true, will run DISM with /resetbase option. This will reduce the size of
# WinSXS folder, but after that Windows updates cannot be uninstalled.
purge_updates=False
[sysprep]
# Used to clean the OS on the VM, and to prepare it for a first-time use.
run_sysprep=True
# The path to the Unattend XML template file used for sysprep.
unattend_xml_path=UnattendTemplate.xml
# DisableSwap option will disable the swap when the image is generated and will add a setting
# in the Unattend.xml file which will enable swap at boot time during specialize step.
# This is required, as by default, the amount of swap space on Windows machine is directly
# proportional to the RAM size and if the image has in the initial stage low disk space,
# the first boot will fail due to not enough disk space. The swap is set to the default
# automatic setting right after the resize of the partitions is performed by cloudbase-init.
disable_swap=False
# In case the hardware on which the image is generated will also be the hardware on
# which the image will be deployed this can be set to true, otherwise the spawned
# instance is prone to BSOD.
persist_drivers_install=True
[cloudbase_init]
# This is a switch that allows the selection of Cloudbase-Init branches. If set to true, the
# beta branch will be used:
# https://cloudbase.it/downloads/CloudbaseInitSetup_<arch>.msi, where arch can be x86 or x64
# otherwise the stable branch will be used:
# https://cloudbase.it/downloads/CloudbaseInitSetup_Stable_<arch>.msi, where arch can be x86 or x64
beta_release=False
# Serial log port for Cloudbase-Init.
# If set to null, the first serial port (if any) from the generation VM will be used
serial_logging_port=COM1
# If set, the Cloudbase-Init msi at this path will be used.
# The path needs to be a locally accesible file path.
msi_path=""

Hello
Can you please try to call the New-WindowsOnlineImage function with the actual path of the config.ini instead of the variable?
I have tested your config file with a couple of changes, needed to reflect my system configuration, but it worked just fine.
I changed:

wim_file_path (please be aware of this one, and check if the actual path to install.wim is correct);
image_path (just changed the driveletter because I don't have a D: drive);
external_switch (my external switch has a different name, this shouldn't affect your script);
virtio_iso_path (to point to my .iso file which contains the drivers).

Please also check that you are using the latest master code.
Let us know if you manage to get it working.

It's already returning this Error:
PS C:\windows-openstack-imaging-tools> git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
PS C:\windows-openstack-imaging-tools> Import-Module .\WinImageBuilder.psm1
PS C:\windows-openstack-imaging-tools> Import-Module .\Config.psm1
PS C:\windows-openstack-imaging-tools> Import-Module .\UnattendResources\ini.psm1
PS C:\windows-openstack-imaging-tools> New-WindowsOnlineImage -ConfigFilePath .\config.ini
6/14/2019 9:07:37 AM - Windows online image generation started.
New-WindowsOnlineImage : Error formatting a string: Input string was not in a correct format..
At line:1 char:1
+ New-WindowsOnlineImage -ConfigFilePath .\config.ini
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Selected switch...ce = true flag.:String) [New-WindowsOnlineImage], R
   untimeException
    + FullyQualifiedErrorId : FormatError,New-WindowsOnlineImage

Hi, I have the same issue, my previous Windows version to use to create image was 2012r2, I tried some work around like update PS to latest version but still no luck, I tried to install windows 2016 and it can create the image now, dont know what is the root cause but if you are using VM to create image, try to reinstall it to newer version of windows.

@chaoMaster do you have an English version of Windows?
The error you got might be a string parsing or a Powershell quirk that is a little bit harder to debug.
Thank you,
Adrian Vladu

@chaoMaster  Can you also run only 'Get-WindowsImageConfig $ConfigFilePath'?

The error you got was because of the fact that the VM switch you used was not an external one.
The proper error message was fixed by https://github.com/cloudbase/windows-openstack-imaging-tools/pull/256


Allow readable streams for filenames

Sound's a bit hacky especially the naming. But i would really appreciate this functionality.


SA1500 reported for new arrays

Starting in 1.1.0-beta005 (currently unlisted from NuGet due to this bug), SA1500 is getting reported for lines like the following:
yield return new object[] { $"class Foo\r\n{{\r\n}}" };

It appears to apply to any case of the following:
new Type[] { object, ... }

I'm still seeing this for multiline arrays in 1.1.0-beta006
e.g.
        private static readonly float[,] AtkinsonMatrix =
            new float[,]
            {
               { 0, 0, 1, 1 },
               { 1, 1, 1, 0 },
               { 0, 1, 0, 0 }
            };

Confirmed. As this is a closed issue, I'll file a new one for it.


Example config with setting sync

Hey, great extension.
Can you create an example showing how to sync with setting sync? We can natively sync with vscode without using setting-sync extension now.

Hi. thank you!
The problem with native VS Code setting-sync is that it does not support multiple profiles. So you can backup / sync only one extensions set at a time, and while you are switching your profiles in vscode-profiles, your cloud backups will overwrite each other.
On the other hand, old settings-sync extension stores your backups in a Github gist, so you can create as many of them as you want, and set them to correspond each of your profiles.
Actually, the setup is quite simple, please refer to this (section)[https://github.com/cyberbiont/vscode-profiles#integration-with-other-extensions] in README.
After you create a new profile, you should also create a new gist via settings-sync extension and add this gist's id under '"sync.gist" field in your profile configuration. Since the profile configurations are stored as settings-cycler settings blocks and are switched automatically when you switch profiles,  Sync:Update command will know the correct gist id to sync your profile with, when the profile is active.
I think the section in README explains is it, but if you have more questions, please be more specific what problems you are having with this setup.

@cyberbiont I see with settings-sync we can store the config in different Github Gists. This is a great extension to manage extensions. Thanks

Feel free to ask in case you have more questions


Unable to login using 2FA

I have 2FA enabled on my account and trying to login along with passing the auth code but for some reason the login always fails. I can login to the same account by disabling 2FA

Same here, I'm using Google Authenticator and put in the code, it says the Code is no longer valid and that I should request a new one, although the code is valid.
Code:
cl.login(username="username", password="12345", verification_code="414 603")
Error:
Traceback (most recent call last):
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 298, in _send_private_request
response.raise_for_status()
File "C:\Program Files\Python39\lib\site-packages\requests\models.py", line 953, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/accounts/login/
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\auth.py", line 393, in login
logged = self.private_request("accounts/login/", data, login=True)
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 445, in private_request
raise e
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 432, in private_request
self._send_private_request(endpoint, **kwargs)
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 348, in _send_private_request
raise TwoFactorRequired(**last_json)
instagrapi.exceptions.TwoFactorRequired: Two-factor authentication required
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 298, in _send_private_request
response.raise_for_status()
File "C:\Program Files\Python39\lib\site-packages\requests\models.py", line 953, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://i.instagram.com/api/v1/accounts/two_factor_login/
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Solba\PycharmProjects\Fiverr_and_Others\snuuuuilo1\main.py", line 98, in
logged_in = login_two_fa("player4win", "andre0175", "197 963")
File "C:\Users\Solba\PycharmProjects\Fiverr_and_Others\snuuuuilo1\main.py", line 26, in login_two_fa
login_successful = cl.login(username=username, password=password, verification_code=two_fa_code)  # logging in with 2-fa-code
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\auth.py", line 415, in login
logged = self.private_request("accounts/two_factor_login/", data, login=True)
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 445, in private_request
raise e
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 432, in private_request
self._send_private_request(endpoint, **kwargs)
File "C:\Users\Solba\AppData\Roaming\Python\Python39\site-packages\instagrapi\mixins\private.py", line 354, in _send_private_request
raise UnknownError(**last_json)
instagrapi.exceptions.UnknownError: This code is no longer valid. Please request a new one.


[QUESTION] Why not Terraform 1.3.0?

Please describe your question here
Is there some specific reason you don't support the latest stable release of Terraform? https://github.com/hashicorp/terraform/releases/tag/v1.3.0
https://github.com/aws-observability/terraform-aws-observability-accelerator/blob/main/versions.tf
More

[X] Yes, I have checked the repo for existing issues before raising this question

Just ran into https://github.com/hashicorp/terraform/issues/31692
│ Error: Experiment has concluded
│
│   on .terraform/modules/eks_observability_accelerator.operator.cert_manager/modules/irsa/versions.tf line 4, in terraform:
│    4:   experiments = [module_variable_optional_attrs]
│
│ Experiment "module_variable_optional_attrs" is no longer available. The final feature corresponding to this experiment differs from the experimental form and is available in the Terraform language from Terraform v1.3.0 onwards.

Can't believe Terraform is engineered like this..

I will mark it as a feature request, but as you saw, there's a feature we are using that is not backwards compatible. We'll work on a fix


Possibility to create a series from a list of nils

Should we allow series to be created from a list of nils?
iex(5)> DF.from_columns(a: [1, 2, 3], b: [nil, nil, nil])
** (ArgumentError) cannot create series "b": cannot make a series from a list of all nils
    (explorer 0.1.0-dev) lib/explorer/polars_backend/data_frame.ex:196: Explorer.PolarsBackend.DataFrame.series_from_list!/2
    (explorer 0.1.0-dev) lib/explorer/polars_backend/data_frame.ex:179: Explorer.PolarsBackend.DataFrame.from_columns_handler/1

The current version doesn't allow it - an error sample is displayed above -, so we have to either create the series with one element not being nil, or create the dataframe specifying the dtypes for our columns. My concern is that some datasets may include columns that are empty and may be hard for the user to spot that.
Both py-polars and nodejs-polars treats these series of nils as a series of floats by default.
JS:
> pl.Series("foo", [null, undefined])
Proxy [
  shape: (2,)
  Series: 'foo' [f64]
  [
        null
        null
  ],
  { get: [Function: get], set: [Function: set] }
]

Python:
>>> b = pl.Series("foo", [None, None, None])
>>> b.dtype
<class 'polars.datatypes.Float64'>

So what do you think of having the same behavior for Explorer?
PS: this was another issue spotted by @cristineguadelupe

I'm happy to do that and keep in line with the behaviour of py-polars and nodejs-polars. Makes sense to me!

Nice, I will change that tomorrow :)
Thanks!


meta.end_pos is None regression with propagate_positions, meta=True, earley parser

The follow code passes with lark-parser 0.7.8 but fails in 0.8.0 and 0.8.2.
import lark

g = 'start: "abcd"'

@lark.v_args(meta=True)
class Xformer(lark.Transformer):

    def start(self, kids, meta):
        return meta.end_pos

text = 'abcd'
parser = lark.Lark(g, propagate_positions=True)
tree = parser.parse(text)
result = Xformer().transform(tree)
assert result is not None

The meta parameter passed to the start method has an end_pos property of None.

Hopefully that solves it.

Yes, confirmed works. Thanks again for responsiveness.

I spoke too soon. There seems to be an off-by-1 error in the returned end_pos.
Here's a test that passes on 0.7.8 and fails on 0.8.2 and master:
import lark

g = 'start: "abcd"'

@lark.v_args(meta=True)
class Xformer(lark.Transformer):

    def start(self, kids, meta):
        return meta.end_pos

text = 'abcd'
parser = lark.Lark(g, propagate_positions=True)
tree = parser.parse(text)
result = Xformer().transform(tree)
assert result == 4

You're right, sorry :)  Try now

Yes, it works. Thank you.


function addFriends

whats the maximum number of users can i send request in  function addFriends ???
is 184 ????

@k41ed why so many ?
I dont know, that's something the user has to search
Regards


multi: store KeyLocator in OpenChannel, use ECDH instead of DerivePrivKey

Closes #2659
Related #3929
By adding the RevocationKeyLocator in the same PR, we get away with not adding a version to SCB as we know that if an OpenChannel has a populated RevocationKeyLocator, they are using ECDH derivation for the sha chain root key.
The question then is if this is better, or more confusing down the line and a version would come with the least amount of headaches.

Seems like the windows build is a flake. Outstanding thing is to test this with a node that has the old channels present in a backup

How will we deprecate RevocationProducer? Is the motivation to remove the shachain root from being on-disk? And instead be in memory if possible with ecdh derivation done on startup? Might be missing some context. @Roasbeef @guggero

I don't think we want to deprecate the RevocationProducer. It should still be in the channel and be written to disk. Its content doesn't change during the lifetime of the channel. We just change the way it is created in the first place.

I don't think we want to deprecate the RevocationProducer. It should still be in the channel and be written to disk. Its content doesn't change during the lifetime of the channel. We just change the way it is created in the first place.

My main reasoning is that it creates all the revocations and we ideally don't even have to store that on-disk (only the materials needed for revocation) even though it's encrypted. But I think that's a whole other can of worms and may not even be the most sensitive data stored on disk.

I don't think we can do a legacy recovery in the itests as we can no longer create legacy RevocationProducer with new channels.

Tested locally by:

opening channel on 9e75c3eadede1816d4be19a7923cd5d0b44b78a0
exchange some HTLCs
shutdown node
start node on 900d8042d514e1b5aeea60b7dc95d8c8aa3700e6
initiate DLP (works)
create a new channel with ECDH scheme
exchange some HTLCs
shutdown node
startup and initiate DLP again (works)

Remaining TODO is to write the tlv tests

I don't think we can do a legacy recovery in the itests as we can no longer create legacy RevocationProducer with new channels.

Would it maybe make sense to create a channel backup with an older version and check that into git, together with the seed it was created with? I think making sure we always support old channel backups in the future is probably a worthy test case.

I don't think we can do a legacy recovery in the itests as we can no longer create legacy RevocationProducer with new channels.

Would it maybe make sense to create a channel backup with an older version and check that into git, together with the seed it was created with? I think making sure we always support old channel backups in the future is probably a worthy test case.

I think that's a good idea - we should check in some old backup + seed, but the problem I ran into is that the itests require a full channel restore which requires another node to also have knowledge of this channel to initiate DLP.

Right, we'd probably need to check in a channel.db for the channel peer as well (and the seed for it).

Right, we'd probably need to check in a channel.db for the channel peer as well (and the seed for it).

I think this is a good test to have - I'll start on it

Looked into it a bit. Seems like threading a config flag to initOurContribution where the generation of RevocationProducer takes place will allow us to do full e2e tests with legacy SCBs.

@guggero Stale branch, must update

@guggero Stale branch, must update

Needs a rebase!

Rebased


Improvement in universal_generator/cpp.toml

Why is this change needed?

std::std::vector is a typo.
Although non-qualified scanf works on many systems, we should use std::scanf (unless you do not using namespace std). see: C++17: <IP_ADDRESS>
To be consistent with line 15, we should use long double for float arguments.

What did you implement?
What behavior do you expect?
I leave these sections blank since it is obvious.

Thanks for the contribution.
I gave permission to you to run the automated checks since you were the first contributor to this repo.
For some reason, automated unit tests / style-checking still doesn't work for this PR now.
Can you push some commit or re-create PR?

I found that README.md should also be updated, so I pushed another commit. I can re-create PR if needed.

I'll create new PR.


22w17a stuff

Small PR for non-networking-related 22w17a changes.

I've added javadoc, not sure if this is 100% correct tho.


Migrate to poky morty version

Connects to https://github.com/resin-os/resinos/issues/113

@agherzan @telphan @michal-mazurek

This PR is replaced by https://github.com/resin-os/meta-resin/pull/523
Closing now


Fix broken linkg in crossplane module

What this PR does / why we need it:
It fixes the broken link in kustomization.yaml file in crossplane/application module.
Which issue(s) this PR fixes:
Fixes #
Quality checks

[ ] My content adheres to the style guidelines
[ ] I ran make test or make e2e-test and it was successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the PR @mostafafarzaneh this has surfaced a bug in our test framework which will prevent this slipping through in the future.


WireGuard: Support for Multiple custom setupVars

Just a POC for issue #1496

don't see anything wrong with this feature if implemented properly.
1 - please read https://github.com/pivpn/pivpn/blob/master/CONTRIBUTING.md
2 - please describe clearly what you are trying to do.
3 - make sure your code is shellcheck compliant.
4 - make sure you test your code before submitting PR.
once all criteria are fulfilled, I can take another look at it.

Closing for now, will get back to this once again on the test branch.


Add Parquet user-defined predicates to push down IN and NOT_IN

Parquet cannot currently push down IN and NOT_IN predicates because it has no built-in support. Iceberg should include a user-defined predicate that implements these so they can be pushed down.

HI @rdblue : Is this means implements the IN and NOT_IN predicates into ParquetMetricsRowGroupFilter and ParquetDictionaryRowGroupFilter?

@shawnding, Sorry, this was implemented in #600. I'll close this.
Thanks to @jun-he for fixing this one!

OK


Create a mosaic of 2D images from different 3D images

Axial Scenario:
${SCT_DIR}/python/bin/python create_mosaic.py -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/data/ -i T1w_MTS.nii.gz -s seg.nii.gz -p ax -col 10 -row 5 -o mosaic_ax.png

Sagittal scenario:
${SCT_DIR}/python/bin/python create_mosaic.py -i T1w_RPI_r_flatten.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/data/ -p sag -col 10 -row 10 -o mosaic_sag.png

@charleygros i see there is a "get centerline" function. You don't need it. Assume that the seg is there, and could be input.
typical scenario for sagittal:

input the flatten image
show full FOV

typical scenario for axial:

input the image + seg
select mid slice
crop around seg

note: functions from reports/qc and reports/slice can be used to create mosaic, crop around image, etc.

@jcohenadad : I did not quite understand the typical scenari of the function during the first commits!
Your comments here made it very clear. Will re-factor all that accordingly.

Also note: if you input a path with 250 images, but you ask for a 10x20 matrix, then it will output one mosaic 10x20 and another one 10x5

Axial scenario:
python create_mosaic.py -i T1w.nii.gz -ifolder ~/amu_spineGeneric/ -p ax -s seg.nii.gz -n 2 -o mosaic_ax_2_3.png

with -n the number of rows in the output mosaic.

Axial scenario: python create_mosaic.py -i T1w.nii.gz -ifolder ~/amu_spineGeneric/ -p ax -s seg.nii.gz -n 2 -o mosaic_ax_2_3.png

I would suggest the following modifications:
python create_mosaic.py --path /home/bob/BIDS_dataset/ --image *T1w.nii.gz --seg *seg.nii.gz --plane ax --row 2 --col 5 --output mosaic_ax_2_3.png

explanations:

i've added a * for -i and -s to explicitly show that we need a suffix, in order to include a glob.glob mechanism that fetches the data, because they will have a prefix that includes subject number, e.g. sub-01_T1w.nii.gz so we cannot generalize the entire file name
I replaced amu_spineGeneric by BIDS_dataset, because with the new flat organization, all centers are within the same BIDS dir
we should specify col and row to allow flexibility in the ratio (to fit Keynote slides)

* i've added a * for -i and -s to explicitly show that we need a suffix, in order to include a glob.glob mechanism that fetches the data, because they will have a prefix that includes subject number, e.g. sub-01_T1w.nii.gz so we cannot generalize the entire file name

If the input file is expressed with wildcard *  , can we assume that the seg is the same as the input but with suffix _seg ?
I think it is confusing that the user can for instance input -i *T1w.nii.gz and then -s *T1w_seg.nii.gz, one seg should match one file right ?
What if in the folder there is : sub-01_acq1_T1w.nii.gz sub-01_acq2_T1w.nii.gz and sub-01-T1w_acq2_seg.nii.gz => what file will be match with what seg ?
I suggest not allowing * in both inputs, but I might be missing something, can you tell me what you think ?

@Nicolas-Pinon OK!

@jcohenadad --> You suggested to add col as param. Is it alright to use row_size instead? Since the function in spinalcordtoolbox/spinalcordtoolbox/reports/slice.py uses that parameter.
here.
In that way you can also control the ratio for the KeyNote.

New example:
python create_mosaic.py -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/data/ -i T1w_MTS.nii.gz -s seg.nii.gz -p ax -col 10 -row 5

Axial scenario --> Ready for review
python create_mosaic.py -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/data/ -i T1w_MTS.nii.gz -s seg.nii.gz -p ax -col 10 -row 5

Sagittal scenario --> Ready for review
${SCT_DIR}/python/bin/python create_mosaic.py -i T1w_RPI_r_flatten.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/data/ -p sag -col 10 -row 10 -o mosaic_sag.png

julien-macbook:~/code/spine-generic/processing $ ${SCT_DIR}/python/bin/python create_mosaic.py -i T1w_RPI_r_flatten.nii.gz -ifolder /Volumes/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p sag -col 16 -row 9 -o mosaic_sag.png
Traceback (most recent call last):
  File "create_mosaic.py", line 25, in <module>
    from spinalcordtoolbox.image import Image
  File "/Users/julien/code/sct/spinalcordtoolbox/image.py", line 26, in <module>
    from msct_types import Coordinate
ModuleNotFoundError: No module named 'msct_types'

@charleygros what version of SCT do you have installed? are you under a particular venv?

Got the same problem as @jcohenadad but can't figure out the solution

Got the same problem as @jcohenadad but can't figure out the solution

${SCT_DIR} is in the python path but ${SCT_DIR}/scripts is not, that's what is causing the problem
(Apologies if this is too obvious to be said)

Got this error when trying with different row and col
nicolas@nipin:~/PycharmProjects/spine-generic/processing$ ${SCT_DIR}/python/bin/python create_mosaic.py -ifolder /home/nicolas/unf_spineGeneric -i T2star.nii.gz -s seg.nii.gz -p ax -col 3 -row 2 -o /home/nicolas/mosaic.png

Loading: /home/nicolas/unf_spineGeneric/sub-05/anat/sub-05_T2star.nii.gz
/home/nicolas/PycharmProjects/spinalcordtoolbox/spinalcordtoolbox/reports/slice.py:317: FutureWarning: Default `strict` currently False; this will change to True in a future version of nipy
  nii_r = nipy2nifti(img_r)
/home/nicolas/PycharmProjects/spinalcordtoolbox/python/lib/python3.7/site-packages/skimage/util/dtype.py:135: UserWarning: Possible precision loss when converting from float32 to uint16
  .format(dtypeobj_in, dtypeobj_out))

Loading: /home/nicolas/unf_spineGeneric/sub-03/anat/sub-03_T2star.nii.gz

Loading: /home/nicolas/unf_spineGeneric/sub-04/anat/sub-04_T2star.nii.gz

Loading: /home/nicolas/unf_spineGeneric/sub-02/anat/sub-02_T2star.nii.gz

Loading: /home/nicolas/unf_spineGeneric/sub-01/anat/sub-01_T2star.nii.gz

Loading: /home/nicolas/unf_spineGeneric/sub-06/anat/sub-06_T2star.nii.gz
Traceback (most recent call last):
  File "create_mosaic.py", line 174, in <module>
    main()
  File "create_mosaic.py", line 120, in main
    mosaic = get_mosaic(img.data, nb_column, nb_row)
  File "create_mosaic.py", line 49, in get_mosaic
    matrix[start_row:end_row, start_col:end_col] = images[:, :, i]
ValueError: could not broadcast input array from shape (60,60) into shape (0,60)

@jcohenadad: Not under a particular venv.
My version:
(base) chgroc@bireli:~/sct-py3k$ git log
commit f1662be86fea20736fa6f63f5f0031d9a7ccc7d5
Author: Julien Cohen-Adad<EMAIL_ADDRESS>Date:   Tue Apr 30 20:42:17 2019 -0400

    install_sct: Adapted sed syntax for linux/osx

python create_mosaic.py -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -i T1w_MTS.nii.gz -s seg.nii.gz -p ax -col 15 -row 15 -o mosaic_ax.png

python create_mosaic.py -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -i T1w_RPI_r_flatten.nii.gz -p sag -col 15 -row 14 -o mosaic_sag.png

@charleygros it is possible that you have legacy PYTHONPATH entries to $SCT_DIR/scripts (explaining why it works on your end). What is your output of echo $PYTHONPATH?

if you could also add the name of the site (based on the folder name) that would be fantastic :-)

The flag -s now serves to indicate the suffix of the seg, example :
 -s _seg.nii.gz or -s _seg_manual.nii.gz

if you could also add the name of the site at the top of each vignette (based on the folder name) that would be fantastic :-)

Will do that real quick
There are still some issues when playing with -row -col numbers but the script seems usable right now

@Nicolas-Pinon with version 0943442f609862f6a7381fa15aa343f8f0a79e0a i'm still getting
ModuleNotFoundError: No module named 'msct_types'

did you fix it?

@Nicolas-Pinon with version 0943442 i'm still getting
ModuleNotFoundError: No module named 'msct_types'

did you fix it?

Should I include the ugly fix in the file ?

Should I include the ugly fix in the file ?

it's not ugly ;-)   and yes

Should I include the ugly fix in the file ?

it's not ugly ;-) and yes

Note that the :
import spinalcordtoolbox
spinalcordtoolbox.__sct_dir__
did not work, there is not __sct_dir__ in the spinalcordtoolbox folder

@Nicolas-Pinon
from spinalcordtoolbox.utils import __sct_dir__

tested on 7346772cd4b5e63ab3ac958c33ffd234f756eca6:
julien-macbook:~/code/spine-generic/processing $ ${SCT_DIR}/python/bin/python create_mosaic.py -i T1w_RPI_r_flatten.nii.gz -ifolder /Volumes/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p sag -col 16 -row 9 -o mosaic_sag.png
Traceback (most recent call last):
  File "create_mosaic.py", line 178, in <module>
    main()
  File "create_mosaic.py", line 115, in main
    data = np.stack(slice_lst, axis=-1)
  File "/Users/julien/code/sct/python/lib/python3.7/site-packages/numpy/core/shape_base.py", line 412, in stack
    raise ValueError('need at least one array to stack')
ValueError: need at least one array to stack

tested on 7346772:

I think it's because you forgot to put the * in the input

tested on joplin with 62f60d0ed48b709d9976a2debc616f973997116d:
Traceback (most recent call last):
  File "create_mosaic.py", line 179, in <module>
    main()
  File "create_mosaic.py", line 121, in main
    mosaic = get_mosaic(img.data, nb_column, nb_row)
  File "create_mosaic.py", line 50, in get_mosaic
    matrix[start_row:end_row, start_col:end_col] = images[:, :, i]
ValueError: could not broadcast input array from shape (260,320) into shape (0,320)

tested on joplin with 62f60d0:

This must have been fix with the latest commit. That was precisely the bug I was trying to correct

tested on joplin with 69c7b8b4655f57c49f7d152a43d8fdbf764d784e:
${SCT_DIR}/python/bin/python create_mosaic.py -i *T1w_RPI_r_flatten.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p sag -col 16 -row 9 -o mosaic_sag.png

There is no more crash, however it outputs a single mosaic_sag.png file, with 144 images (9*16) instead of one file with 144 image, and another one with 207-144 images.

another (minor) issue, is that col and row are swapped:
the command below should produce 16 col and 9 rows, but it does the other way around:
${SCT_DIR}/python/bin/python create_mosaic.py -i *T1w_RPI_r_flatten.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p sag -col 16 -row 9 -o mosaic_sag.png

To recap (if @charleygros reads this), there is still 2 things to do:

Output multiple images if "too many subjects for one image"
Row and col dims are inversed

If I have time I will do it this evening, otherwise tomorrow morning

@Nicolas-Pinon --> Alright! Thank you
Row and col dims are inversed --> Solved!
It was actually an issue in the orientation of the sag slices :)

Output multiple images if "too many subjects for one image"

--> Implemented!
Creating: mosaic_000.png

Creating: mosaic_001.png

Creating: mosaic_002.png

Creating: mosaic_003.png

works nicely for the T1w scans :-) now testing the others...
just one question: i feel that some scans are "squeezed" in the AP direction. Are you reinterpolating by taking into account the physical pixel dimension (in case of anisotropic resolution)? see example below:

oopsi! that was the argument for allowing to input the -seg flag ;-)
FileNotFoundError: No such file or no access: '/home/GRAMES.POLYMTL.CA/p101317/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/sub-amu01/anat/sub-amu01_T2star_rms_seg.nii.gz'

(this modality has a _gmseg, not _seg)

Interpolation: The only line that I can think of is that one:
plt.imshow(mosaic, interpolation='nearest', cmap='gray', aspect='equal')

--> will correct this in the next pushed commit

@charleygros could you please use linear interp? it looks much better
thanks!

Is that normal that it takes ~3 min per subject in the axial mode? With 200 subjects that would take 10h (!). Using this command on joplin:
 ${SCT_DIR}/python/bin/python create_mosaic.py -i *T1w_RPI_r.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p ax -col 16 -row 9 -o mosaic_MTS-T1w_ax.png -s _seg.nii.gz

@jcohenadad --> It was way quicker than 10h when I tried on the entire database on bireli (MTS).
The bottleneck is the qcslice loading takes a fairly large amount of time!
I can try to find a workaround. Keep you an update in 15min.

@jcohenadad --> It was way quicker than 10h when I tried on the entire database on bireli (MTS).

just to get a sense if there is something wrong with joplin: how long was it approximately?

@jcohenadad --> ~30s per image

@jcohenadad --> New commit --> Reduced the loading time of axial to ~3s on bireli.
Could you tell me if it works better?

oops! tried on joplin with 63e4bc33a86df28ceff7c417f8f87b6b742556ca:
${SCT_DIR}/python/bin/python create_mosaic.py -i *T1w_RPI_r.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p ax -col 16 -row 9 -o mosaic_MTS-T1w_ax.png -s _seg.nii.gz

oops! tried on joplin with 63e4bc3:
${SCT_DIR}/python/bin/python create_mosaic.py -i *T1w_RPI_r.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p ax -col 16 -row 9 -o mosaic_MTS-T1w_ax.png -s _seg.nii.gz

Are those phase images ?

no they are not-- the algo likely selected a slice in the background, and the CLAHE makes the salt and pepper noise

Salt and peper issue --> the crop of the axial slice fails because the segmentation is empty at the mid slice.
Example:
sub-vallHebron01/anat/sub-vallHebron01_T1w_RPI_r.nii.gz

yeah that's what i though :-(
let me investigate. Normally Nicolas, Valentine, etc. fixed the segs

Ah! OK nevermind-- i though i selected the T1w_MTS (not the T1w...). Sorry, my bad

ah, pb with -s flag, which automatically appends the -i info (in a case where we use a seg coming from another image):
p101317@joplin:~/code/spine-generic/processing$ ${SCT_DIR}/python/bin/python create_mosaic.py -i *acq-MTon_MTS_reg.nii.gz -s *acq-T1w_MTS_seg.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p ax -col 25 -row 10 -o mosaic_MTS-MTon_ax.png

Loading: /home/GRAMES.POLYMTL.CA/p101317/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/sub-amu01/anat/sub-amu01_acq-MTon_MTS_reg.nii.gz
Traceback (most recent call last):
  File "/home/GRAMES.POLYMTL.CA/p101317/code/sct/python/lib/python3.7/site-packages/nibabel/loadsave.py", line 40, in load
    stat_result = os.stat(filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/GRAMES.POLYMTL.CA/p101317/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/sub-amu01/anat/sub-amu01_acq-MTon_MTS_reg*acq-T1w_MTS_seg.nii.gz'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "create_mosaic.py", line 200, in <module>
    main()
  File "create_mosaic.py", line 90, in main
    img, seg = Image(file).change_orientation('RPI'), Image(file_seg).change_orientation('RPI')
  File "/home/GRAMES.POLYMTL.CA/p101317/code/sct/spinalcordtoolbox/image.py", line 238, in __init__
    self.loadFromPath(param, verbose)
  File "/home/GRAMES.POLYMTL.CA/p101317/code/sct/spinalcordtoolbox/image.py", line 321, in loadFromPath
    self.im_file = nibabel.load(path)
  File "/home/GRAMES.POLYMTL.CA/p101317/code/sct/python/lib/python3.7/site-packages/nibabel/loadsave.py", line 42, in load
    raise FileNotFoundError("No such file or no access: '%s'" % filename)
FileNotFoundError: No such file or no access: '/home/GRAMES.POLYMTL.CA/p101317/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/sub-amu01/anat/sub-amu01_acq-MTon_MTS_reg*acq-T1w_MTS_seg.nii.gz'

@jcohenadad  Could you try:
python create_mosaic.py -i *acq-MTon_MTS_reg.nii.gz -s _seg.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/ -p ax -col 25 -row 10 -o mosaic_MTS-MTon_ax.png

ah, pb with -s flag, which automatically appends the -i info (in a case where we use a seg coming from another image):

Should the user input the full name of the segmentation ?
The problem is the use of the * in both im and seg, as we discussed previously

Should the user input the full name of the segmentation ?

not possible because the prefix changes (sub-01, etc.). However, why not simply not appending the image, and doing a glob.glob as it is done for the image?

@jcohenadad --> Happy to try that. I come back

Should the user input the full name of the segmentation ?

not possible because the prefix changes (sub-01, etc.). However, why not simply not appending the image, and doing a glob.glob as it is done for the image?

OK will try that

another problem, on joplin with 63e4bc33a86df28ceff7c417f8f87b6b742556ca:
${SCT_DIR}/python/bin/python create_mosaic.py -i *dwi_crop_moco_dwi_mean.nii.gz -ifolder ~/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/ -p ax -col 25 -row 10 -o mosaic_dwi_ax.png
...
Loading: /home/GRAMES.POLYMTL.CA/p101317/duke/projects/spine_generic/spineGeneric_20190513/spineGeneric_20190513/data/sub-vuiisIngenia06/dwi/sub-vuiisIngenia06_dwi_crop_moco_dwi_mean.nii.gz
Traceback (most recent call last):
  File "create_mosaic.py", line 200, in <module>
    main()
  File "create_mosaic.py", line 125, in main
    data = np.stack(slice_lst, axis=-1)
  File "/home/GRAMES.POLYMTL.CA/p101317/code/sct/python/lib/python3.7/site-packages/numpy/core/shape_base.py", line 416, in stack
    raise ValueError('all input arrays must have the same shape')
ValueError: all input arrays must have the same shape

@Nicolas-Pinon --> Oups did not see your message
@jcohenadad --> I pushed changes for globglob

@jcohenadad --> I think that the last commit fixes the issue for dwi --> could you please let me know?

ok! with f4dda9824bef8a223cd9a12ade4b0aba975ef495 the dwi problem is solved 👍
however there is a glitch with one subject (dimension problem):

also (less urgent), would it be possible to specify CLAHE params, to address the overall shift in intensity

Different results for the new param -winsize (default is 16) :
winsize=16

winsize=32

winsize=64

@Nicolas-Pinon did you try with winsize=8?

I did, here is the result :


Chinese Directory display problem

Chinese language named Directory display problem,not correct,please add this support.

Hello @xiaohelong,
Thanks for taking the time to raise this issue. The Chinese language issue was also raised here https://github.com/alexballas/go2tv/issues/52#issuecomment-1198506691
can you please refer to my comment and let me know if the workaround works for you?
Regards,
Alex


Interception not working

Hello,
thanks for your awesome DLL Wrapper! I've been exactly searching for this and found it through your blog. I'm working on a project with some old game which builds on GDI. I want to intercept a couple of GDI calls.
I followed your guide and I was successful in generating a DLL which export forwards all functions from gdi32.dll. Unfortunately the interception is not working for but and always gives me an error (tried to intercept ExtTextOutA):

I've been playing around with the code all day, but somehow I don't really get the problem / have too little experience in that matter. Do you have an advice or solution for me?
GdiWrapper.zip
Thanks!

Note: I prepended the function name ("ExtTextOutA") with "f_", because else I would have a function redefinition since the original function is imported as well.

So the stack overflow seems indeed to be caused by a calling convention mismatch? Although  the FARPROC you use is an _stdcall it seems to have some issue. When replacing it with the appropriate function pointer (in my case typedef BOOL(_stdcall stfunc)(HDC hdc, int x, int y, UINT options, const RECT* lprect, LPCSTR lpString, UINT c, const INT* lpDx);) the calling convention seems fine.
The problem now is that I get a stack overflow and I can't wrap my head around why.. It doesn't seem to be calling itself.

Setting the calling convention on my hooked method fixed the issue for me.
extern "C" BOOL	WINAPI f_ExtTextOutA(HDC hdc, int x, int y, UINT options, const RECT* lprect, LPCSTR lpString, UINT c, const INT* lpDx)
GdiWrapper.zip


add animation to moved piece

adding animation to moved piece.
issue: https://github.com/chess-mazes/chess-mazes/issues/50
https://user-images.githubusercontent.com/109076747/235306952-37987dea-8fbc-4e77-9781-b7f72acf1659.mov

#50

merging


Altmetrics scores

You can embed the free Altmetric badge for this research output on your website, CV, or blog. Just copy and paste the code below into the HTML of your page:

we might as well, we have good attention scores...
e.g.
Unknowns paper 85
MOD paper 19 (1st percentile (ranked 1st) of the 1 tracked articles of a similar age in BMC Biology)
https://www.pombase.org/about/published-by-pombase

duplicates #1166


WASDK article on apps packaged with external location is missing a hyperlink

There is a hyperlink missing in this article.  The doc currently states:
then you can instead call the bootstrapper API explicitly. More info about that in this topic.
But I don't see a hyperlink.    I'm guessing it's intending to point to https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/win32/_bootstrap/?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f3419ef8-7c06-8d25-45fb-7db9e1757845
Version Independent ID: f3419ef8-7c06-8d25-45fb-7db9e1757845
Content: Use the Windows App SDK runtime for apps packaged with external location or unpackaged - Windows apps
Content Source: hub/apps/windows-app-sdk/use-windows-app-sdk-run-time.md
Product: reunion
Technology: get-started
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Thanks, @houserrob, I'll re-word it because it's not clear enough. It means "this topic" as in "the topic you're currently reading". One of our writing guidelines is never to use text such as "here" or "this topic" as link text (linking someplace else); the reason being that there's no info in link text like that as to where you're being taken (so you don't know until you get there). However, using such language is fairly prevalent across the web, so I can see how the phrase "this topic" has become ambiguous.
I'll say something like, "continue reading this topic for more info about that". The "this topic" part of that might still feel like it should be hyperlinked, but I'm thinking that the "continue reading" part will help.
Thanks again!
-Steve

UPDATE: I ended up changing the wording to "But if you have advanced needs (such as handling errors by showing your own custom UI or logging, or if you need to load a version of the Windows App SDK that's different from the version you built with), then continue reading this topic.". I think that's better than before.
-Steve

Thanks Steve for the super quick response and resolution.

From: Steven White @.>
Sent: Tuesday, January 10, 2023 2:34 PM
To: MicrosoftDocs/windows-dev-docs @.>
Cc: houserrob @.>; Mention @.>
Subject: Re: [MicrosoftDocs/windows-dev-docs] WASDK article on apps packaged with external location is missing a hyperlink (Issue #4230)
Closed #4230https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindows-dev-docs%2Fissues%2F4230&data=05|01||c69360e482bc4c3ee59408daf35ad02a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638089868607447018|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=FW%2B94GPVyslmEbdtuaLDj8%2FqD2Fkhpj%2FTS3pXWcIPfc%3D&reserved=0 as completed.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindows-dev-docs%2Fissues%2F4230%23event-8196490312&data=05|01||c69360e482bc4c3ee59408daf35ad02a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638089868607447018|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=47jiG0m0p9JEQMpPEedw%2FaLWVWJ9xo6MrB%2F%2B40n3Xv8%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA6EXE72ATR7O2H3BAWMLB3WRXPWVANCNFSM6AAAAAATXKLPP4&data=05|01||c69360e482bc4c3ee59408daf35ad02a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638089868607447018|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=u6QGiPpJdyq2M%2BASIKwyd%2FSABVtXPPt2pwsEgX7b3ms%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/733 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 1447012:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-01-29-06-40-16 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1447012:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-01-29-06-40-16 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel