What is the idFields in the FragmentRequest?

I don't understand the docs on readFragment(). What is idFields.id?
Here's the current doc:
final fragmentDoc = gql(
  r'''
    fragment mySmallSubset on MyType {
      myField,
      someNewField
    }
  ''',
);

var fragmentRequest = FragmentRequest(
  fragment: Fragment(document: fragmentDoc),
  idFields: {'__typename': 'MyType', 'id': 1}, // <- what is this?
);

final data = client.readFragment(fragmentRequest);
client.writeFragment(fragmentRequest, data);

For example, assuming my query is like this:
query projectItemsCount($projectID: String!) {
  projectItemsCount(projectID: $projectID) {
    ...FormsCount
  }
}

fragment FormsCount on ProjectItemsCount {
  forms
}

How should I build my FormFragmentRequest?

I believe the id fields are the ones used in the dataIdFromObject function of your GraphQLCache so the cache can create a proper entry for it. The default implementation uses the __typename and id fields so it makes sense to use them in the example. If at least one of them is missing, the default implementation returns null and (by my understanding, take this one with a grain of salt) no cache entry is created.
As to what you should use for your query/fragment: It depends on what fields you use to get a dataId. If you haven't implemented a custom dataIdFromObject function, you want to supply it with __typename and id of your ProjectItemsCount entity so it can look up the correct entry in the cache. If you have a custom implementation, pass a map with all values needed to generate the id properly.

Probably the same as in Apollo's readFragment

Thanks a lot for helping.
I tried using the dataIdFromObject but it seems to never get called:
GraphQLClient(
  cache: GraphQLCache(
    dataIdFromObject: (object) {
      print('dataIdFromObject'); // Nothing ever gets printed
    },
  ),
  link: link,
)

Is it correct to say that this function is called every time you make a query (using the Query widget or cache.readQuery)? Or am I supposed to write in the cache myself when I get the result from a query?
Also, I saw that dataIdFromObject is marked as deprecated in the docs. So I added normalize in my pubspec to be able to use a TypePolicy. I then tried this code too but nothing ever gets printed:
GraphQLClient(
  cache: GraphQLCache(
    typePolicies: {
      'ProjectItemsCount': TypePolicy(
        fields: {
          // Not sure what to use as keys so I tried both FormsCount and forms
          'FormsCount': FieldPolicy(read: (_, __) => print('read')),
          'forms': FieldPolicy(read: (_, __) => print('read')),
        },
      )
    },
  ),
  link: link,
),

Here's an extract from my schema:
type ProjectItemsCount {
  forms: Int!
  # ...
}

type Query {
  projectItemsCount(projectID: String!): ProjectItemsCount!
  # ...
}

geisterfurz007's explanation was correct – idFields is separate from data because the data might not contain the relevant fields. Because readFragment's API is a pass-through for the normalize's normalizeFragment, you can look there for more details.
@GP4cK – dataIdFromObject may be deprecated by apollo, but is not deprecated for us. I would have to see the actual Query / client.query / client.watchQuery code, data returned from the server, and cache state (cache.store.toMap()) to know why dataIdFromObject, etc wasn't being called.
I did discover a dumb issue with cache.readQuery that I just hotfixed in 4.0.1, but you should still be seeing  print('dataIdFromObject') when using a cache-enabled Query because of the writeQuery call. Cache writes are controlled by fetchPolicy.
Depending on what you're trying to do, you might be better off doing a client.readQuery client.writeQuery round trip with the projectItemsCount query, updating the nested data structure. writeFragment is meant for updating fields of normalized data, which is why there's typically an id field, but your query result looks more like an aggregate with no fixed identity.

I ended up using client.writeQuery, it was easier.
Thank you very much for you help, all of you!

I ended up using client.writeQuery, it was easier.
Thank you very much for you help, all of you!

How did you solve it? Can you share it with us?


Addition is sometimes not communative

const a = new Decimal('-13.77');
const b = new Decimal('1.5612555115940468637');
const c = new Decimal('5');

const result1 = a.add(b).add(c);
const result2 = a.add(b.add(c));

console.log(result1.toString()); // "-7.208744488405953136"
console.log(result2.toString()); // "-7.2087444884059531363"

Fiddle: https://jsfiddle.net/es9pun76/1/
I'm not sure what is special about these values or order of addition, but the values are different when they definitely shouldn't be!

This is also a bug with decimal.js, raised it there: https://github.com/MikeMcl/decimal.js/issues/157

There is no bug here, see here.


Unable to run on ARM (aarch64)

Hello,
I'm trying to run OpenBLAS on aarch64 machine with CentOS 7. I tried to run basic example provided by you: https://github.com/xianyi/OpenBLAS/wiki/User-Manual#call-cblas-interface . I've run:
export LD_LIBRARY_PATH=/.../blas/0.3.5.openblas/aarch64-centos7-gcc8-opt/lib64/
gcc -o test_cblas_open test_cblas_dgemm.c -I   /.../blas/0.3.5.openblas/aarch64-centos7-gcc8-opt/include/openblas -L /.../blas/0.3.5.openblas/aarch64-centos7-gcc8-opt/lib64/ -lopenblas  -lpthread
./test_cblas_open

I've got output like this:
11.000000 -9.000000 5.000000 -9.000000 21.000000 -1.000000 5.000000 -1.000000 3.000000
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed
OpenBLAS : munmap failed

Thank you for your help.

Interesting, what kind of hardware is this ? The result as such looks correct, I suspect what happened is that OpenBLAS (in driver/others/memory.c) tried to use mmap for allocation initially, failed - silently - and used malloc instead. Later when it tried to deallocate, it may have blindly called munmap(-1) first - and error handling in that part of the code looks to be poor if it does not even return the error code from munmap...

Here is output of lscpu:
Architecture:          aarch64
Byte Order:            Little Endian
CPU(s):                96
On-line CPU(s) list:   0-95
Thread(s) per core:    1
Core(s) per socket:    48
Socket(s):             2
NUMA node(s):          2
Model:                 0
BogoMIPS:              200.00
L1d cache:             32K
L1i cache:             78K
L2 cache:              16384K
NUMA node0 CPU(s):     0-47
NUMA node1 CPU(s):     48-95
Flags:                 fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics

Part of lshw output:
computer
    description: System
    product: Cavium ThunderX CN88XX board
    vendor: GIGABYTE
    version: 0100
    serial: [REMOVED]
    width: 64 bits
    capabilities: smbios-3.0.0 dmi-3.0.0 smp
    configuration: chassis=server family=Server sku=01234567890123456789AB uuid=[REMOVED]
  *-core
       description: Motherboard
       product: MT60-SC0
       vendor: GIGABYTE
       physical id: 0
       version: 01234567
       serial: [REMOVED]
       slot: Default string
     *-firmware
          description: BIOS
          vendor: GIGABYTE
          physical id: 0
          version: T08
          date: 06/06/2016
          size: 64KiB
          capacity: 8MiB
          capabilities: pci upgrade shadowing cdboot bootselect socketedrom edd int13floppy1200 int13floppy720 int13floppy2880 int5printscreen int14serial int17printer acpi usb biosbootspecification uefi
     *-cpu:0
          description: CPU
          product: ARM (CN88xx)
          vendor: www.cavium.com
          physical id: 2d
          bus info: cpu@0
          version: 2.0
          serial: [REMOVED]
          slot: Socket
          size: 2GHz
          capacity: 2GHz
          clock: 156MHz
          capabilities: lm
          configuration: cores=48 enabledcores=48
        *-cache:0
             description: L1 cache
             physical id: 2e
             slot: Intelnal L1D Cache
             size: 1536KiB
             capacity: 1536KiB
             capabilities: internal write-back data
             configuration: level=1
        *-cache:1
             description: L2 cache
             physical id: 30
             slot: Internal L2 Cache
             size: 16MiB
             capacity: 16MiB
             capabilities: internal write-back unified
             configuration: level=2
     *-cache:0
          description: L1 cache
          physical id: 2f
          slot: Internal L1I Cache
          size: 3744KiB
          capacity: 3744KiB
          capabilities: internal write-back instruction
          configuration: level=1
     *-memory
          description: System Memory
          physical id: 31
          slot: System board or motherboard
          size: 256GiB
          capacity: 1TiB
        *-bank:0
             description: DIMM DDR4 2133 MHz (0.5 ns)
             product: M393A4K40BB0-CPB
             vendor: Samsung
             physical id: 0
             serial: [REMOVED]
             slot: DIMM_P0_A0
             size: 32GiB
             width: 64 bits
             clock: 2133MHz (0.5ns)
        *-bank:1
             description: DDR4 [empty]
             product: NO DIMM
             vendor: NO DIMM
             physical id: 1
             serial: [REMOVED]
             slot: DIMM_P0_A1
             width: 64 bits
        *-bank:2
             description: DIMM DDR4 2133 MHz (0.5 ns)
             product: M393A4K40BB0-CPB
             vendor: Samsung
             physical id: 2
             serial: [REMOVED]
             slot: DIMM_P0_B0
             size: 32GiB
             width: 64 bits
             clock: 2133MHz (0.5ns)
        *-bank:3
             description: DDR4 [empty]
             product: NO DIMM
             vendor: NO DIMM
             physical id: 3
             serial: [REMOVED]
             slot: DIMM_P0_B1
             width: 64 bits
             ...
     *-cpu:1
          description: CPU
          product: ARM (CN88xx)
          vendor: www.cavium.com
          physical id: 3f
          bus info: cpu@1
          version: 2.0
          serial: [REMOVED]
          slot: Socket
          size: 2GHz
          capacity: 2GHz
          clock: 156MHz
          capabilities: lm
          configuration: cores=48 enabledcores=48
          ...

So some quite big and special hardware - I'll see if I can add some more verbose error output to the develop branch tonight. (If one looks around line 2100 of memory.c , there is only minimal perror output to track a mbind failure, and that is not even in the default NO_WARMUP=0 branch of the rather involved code there. The alloc_mmap_free at line 2042 could certainly do with a bit
more feedback but I suspect the error code here is going to be EINVAL, not much use on its own
(though perhaps release->address is NULL there).

There is another place.
https://github.com/xianyi/OpenBLAS/blob/ce3651516f12079f3ca2418aa85b9ad571c3a391/common_arm64.h#L127

That "other place" just defines BUFFER_SIZE - in the unlikely case that this is set to a wrong value, we can play with it once we know if and why either mmap or munmap is unhappy.

It is hard to understand constants there, aarch64 supports same page sizes as amd64 in default kernels, but one can try 16k or 64k basic pages, then all assumptions in that file are blown away. 4MB pages assumed there do not exist in real hardware , checking qemu will not relate to real performance either

At least that kind of error message was not observed on consumer hardware (lots of phones with ARMV8 hardware), and I do not think ashwinyes developed the thunderx support without access to actual hardware. Anyway without detailed error reporting from the relevant functions we can imagine possible causes forever without getting anywhere.

The patch to provide more information in the error case is now merged, but you need to check out the current develop branch to get it. One possible cause of mmap/unmap errors seems to be running out of available mappings (/proc/sys/vm/max_map_count or the vm.max_map_count sysctl), which I guess would depend on what else is running on your server.

Hello. I tried to run it with your patch and here is the output:
11.000000 -9.000000 5.000000 -9.000000 21.000000 -1.000000 5.000000 -1.000000 3.000000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff86c68000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff7faf3000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff7a50b000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff77c3a000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff75dcc000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff70984000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff6b831000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff685e1000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff6dac1000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff60ef4000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff5e63d000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff66103000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff5981c000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff570c6000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff527f2000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff4f678000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff4cfe5000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff4a522000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff43589000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff47e64000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff460c3000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff3ef17000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff40576000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff36025000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff391c3000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff30eba000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff2e509000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff33fba000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff2c36c000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff27f66000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff2a0bd000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff23e19000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff26053000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff214b5000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff1ca32000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff00594000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff1045d000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff13253000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff07401000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff09401000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3ff0bea1000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fed4be3000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fef8dcf000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fed2321000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fecbb11000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fefdbd1000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feedeb3000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feef3bc000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fee1513000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feeb381000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fedccc3000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fefbe03000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fee2d3e000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fef1a5e000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fee7e2b000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fee5788000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fed9f7f000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fec9b74000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fec037c000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fec5d69000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3fec7b11000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feba4eb000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feb7b55000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feb6403000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feb4434000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feb22f8000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feb026b000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3feae1aa000
OpenBLAS : munmap failed:: Invalid argument
error code=22,	release->address=3febddca000

Thank you. Unfortunately EINVAL just tells that there is "something wrong" with the arguments passed to munmap, which are just the address and the length (the BUFFER_SIZE brada4 pointed to, but that value must have been used successfully in the preceding mmap as there was no corresponding error from mmap). As release->address stores the memory pointer returned by
the corresponding mmap, I do not see how anything could have gone wrong there either (unless
the code manages to call the munmap twice for the same address, which obviously should not happen). (And the manpage even states that "it is not an error if the indicated range does not contain any mapped pages", suggesting that a double munmap should be harmless).
So I still think these messages are harmless, but I still have no idea what causes them (and why only at munmap time, and only on your system)... would probably need to print out successful mmap/munmap invocations  as well to make sense of this.

if @ammarik could try to play with those parameters, like make it 2MB etc to see if it starts working. I have just android, which does not get respective error.

If the value of the BUFFER_SIZE constant was unacceptable, the original mmap should have failed with EINVAL already. And as unmap gets called with the actual start address of the region as returned by mmap rather than the one we asked for, any realignment done by mmap or the kernel should be accounted for as well. (And running out of mappings would have raised ENOMEM, so we can also exclude that possibility.)

Hello. Thank you for trying to help me. I tried to run the example with various values of BUFFER_SIZE and PAGESIZE, but it resulting either by same output as above or by Segmentation fault. Any other suggestions how to solve this issue?

If you happen to have valgrind on that box, you could try and see if that generates any more verbose complaints. Unfortunately I do not have access to a Cavium server, and know very little about ThunderX (except to try and keep my hands off the kernels that @ashwinyes maintains :-) )

This is a Cavium ThunderX board. There is nothing special in OpenBLAS that should cause this error.
@ammarik Are you using any special Linux Kernel on this device?
Does map/unmap work outside of OpenBLAS ?

Does map/unmap work outside of OpenBLAS ?

Its like mmap, memset, munmap , print ret code
Actually centos default aarch64 says supporting thunderx as one of four boards...

I'm just playing with Raspberry Pi 4 in aarch64 mode using latest Debian Buster and I can run test_cblas_dgemm.c without problem. I'm using libopenblas-dev:arm64 version 0.3.5+ds-3.

Also worth a try with CentOS aarch64:
https://fedoraproject.org/wiki/EPEL

Hi! We can't use EPEL due to a strict policy of "no 3rd party repositories" - OpenBLAS will be used by code that runs on LCG (LHC Computring Grid).

Question is if it works, since we dont get your build logs, at least those are public, and if they do you can build off their RPM spec ans keep in your repo.
Not sure what is first and second party there, centos and fedora are on redhats payroll often.

I tried whether map/unmap works outside of OpenBLAS and it works without any issues, I tried example from mmap wikipedia page.  Here are build logs:
blas-0.3.6.openblas-configure.log
blas-0.3.6.openblas-build.log
blas-0.3.6.openblas-install.log

Please build with make like fedora epel rpmbuild does. It is better at logging. Thanks.

I've built it as you said, as fedora epel rpmbuild does and it works now without errors. Thank you!

Did you try 0.3.7 or their default 0.3.3?

I tried 0.3.7.

Good to know. Could you find anything different in their spec vs your build?
https://src.fedoraproject.org/rpms/openblas/blob/master/f/openblas.spec
(That 0.3.7 patch looks worth integrating btw)


How to put team name and score in Champselect UI and League End of Game?

Entering the team name and score in RCVolus Teams doesn't show up. Is there a way to fix this?

This seems to be a bug, we will work on a fix and update here accordingly.

My apologies; the team names are not intended to be part of the Champselect UI and the End of Game screen, instead the talk overlay (at http://<IP_ADDRESS>:3003/pages/op-rcv-teams/talk-gfx.html) should be used.
Game scores are not part of that overlay yet, but are planned (see Issue #37)


Lukla Airport Runway length error

Hello! I looked up the length of Lukla Airport's runway in the PTFS Charts, and it shows that the whole length of the runway is 1303 feet instead of the written 2157 feet. Please correct me if I am wrong though :-)

Also I just realized that most of the runway lengths are not accurate. Please check these too thanks

Hello! The reason is that the lengths on the PTFS charts are not compatible with the speeds of the aircraft in-game. All the distances in the performance calculator are based on time measurements based on the speed shown on the pilot GUI.
For example, at Lukla, it takes 98.29 seconds to go from one end of the runway to the other if you are driving at what the game tells you is 13 knots. That implies the distance is 2157 ft. That is the distance I have to use for the calculations, otherwise the speeds output would all be wrong!
The distances on the charts do however match the scale of the aircraft better. They are about 40% less than the distances I have to use in the calculations.

Thank you so much! Love this tool, and indeed it does work (Haha lol)


[FEATURE] Add Dockerfile to repository

Description
Adding a  Dockerfile to this repository helps set up the project locally and ensure a consistent environment. This will make it easier for contributors to get started with the project
Screenshots
No response
Additional information
No response
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue?
Yes I am willing to submit a PR!

thanks for raising, not an accepted issue


Containers name resolution issue when running proxy

BUG REPORT INFORMATION
Container names are not resolved when running services in SWARM Mode
Run proxy and swarm-listener services is not working.
It seems proxy (deployed in a different node) is not able to resolve a container name.
Steps to reproduce the issue:

init swarm

add worker node

create the overlay network

add services attached to overlay network:
docker service create --name swarm-listener \
 --network rh_overlay \
 --mount "type=bind,source=/var/run/docker.sock,target=/var/run/docker.sock" \
 -e DF_NOTIFY_CREATE_SERVICE_URL=http://proxy:8080/v1/docker-flow-proxy/reconfigure \
 -e DF_NOTIFY_REMOVE_SERVICE_URL=http://proxy:8080/v1/docker-flow-proxy/remove \
 --constraint 'node.role==manager' \
 vfarcic/docker-flow-swarm-listener

docker service create --name proxy \
 -p 80:80 \
 -p 443:443 \
 --network rh_overlay \
 -e MODE=swarm \
 -e LISTENER_ADDRESS=swarm-listener \
 vfarcic/docker-flow-proxy

Describe the results you received:
Proxy service is unable to resolve the name swarm-listener:

Fetching config from swarm listener failed: Get http://swarm-listener:8080/v1/docker-flow-swarm-listener/get-services: dial tcp: lookup swarm-listener on <IP_ADDRESS>:53: no such host.

 The bad news is that it worked in my cluster meaning that the problem is not directly related to DFP. The cause of the problem is probably in the firewall.
From your comments on Slack, seems that swarm listener can communicate with the proxy. Can you check whether the same is true the other way around? Enter into the proxy container and execute:
apk add --update drill

drill swarm-listener

Please paste the output here. The IP should be <IP_ADDRESS>.

I missed to notice the IP from the error message.

Fetching config from swarm listener failed: Get http://swarm-listener:8080/v1/docker-flow-swarm-listener/get-services: dial tcp: lookup swarm-listener on <IP_ADDRESS>:53: no such host.

<IP_ADDRESS>:53 does not seem to be IP Docker network assigns to services. It seems as if something is hijacking requests. Can you double check that there is no VPN or another proxy somewhere inside your network? Also, the port 53 does not fit the picture.

It turned out you got it right.
There was an issue with my set of open stack based VM.
I needed to explicitly open ports without using a "pass all" firewall rule.
Thanks for supporting me.
Francesco

@brunifrancesco How did you resolve this issue? I'm running into the same issue as well.
Thanks,
Karthik

Are you encountering the issue in a Open Stack VM?
I configured a pass all rule (all TCP/UDP ports were open) to let all the traffic passes through without any limitation. This op was the issue cause: when I explicitly open SWARM UDP/TCP ports and removed the pass all rule, it started working as expected.
Hope it solves your problem too,
bye
Francesco

I'm using AWS with Docker for AWS solution, I haven't this problem. It's really bad :|

@alexsandro-xpt I'm not sure I understood. Are you NOT having that problem?

@kmyn I don't have an Open Stack cluster I can use to try it out myself. Generally, if ports are open (https://docs.docker.com/engine/swarm/swarm-tutorial/#open-protocols-and-ports-between-the-hosts) Docker networking should work and DFP as well. If networking is messed up, DFP cannot forward requests to your service. Actually, without networking set up, many other things will not work in a Swarm cluster.

The one's I'm using are generic CentOS VM's. Same issue happened in two different setup and for both I had to recreate swarm and the overlay network again to resolve the problem.

Many are having problems running Docker Swarm cluster on CentOS/RedHat. Networking is often failing on those.
I don't think that the problem is related to DFP. I'd suggest using Ubuntu instead or one of the newer distributions made specifically for containers.


MINOR; Export control record type value

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Merging. Unrelated test failures.


Add branding

Add option to:

add your own logo to main screen and favicon
change the name from Skoruba.Identity to your company/organization name and add "powered by Skoruba.IdentityServer" so that there is still some credit but some can easily insert his own brand

Does this work in the docker images?

I deployed docker images from https://hub.docker.com/u/skoruba to an Azure webapp.
Then configured the variable AdminConfiguration__HomePageLogoUri in settings and set the value to: https://www.bokamera.se/logo.png.

But when I refresh my page and check the value I get this in the html:

That is...the src url does not seem to be set?

Thanks for your feedback, I reopen this issue and I will check it.

Any news on this? It would be awesome if we could set allowed cors origins also. Because when using the docker images I have to put the favicon and logo on another domain.
Tried to set AdminApiConfiguration__CorsAllowOrigins__0 to my domain but that setting is only available for the api project and not for sts or admin.


Expose a base z-index value to support rendering the email editor inside a modal/dialog

Still looking into how to override the merge tags z-index..

I'll make some more tests tomorrow, maybe by moving the portal reference at the root of my project..

I've been able to override:
.arco-trigger {
    z-index: 9999;
}

// theme, If you need to change the theme, you can make a duplicate in https://arco.design/themes/design/1799/setting/base/Color import<EMAIL_ADDRESS>From the arco website the theme is not duplicatable

It looks like arco made a change. Please check agins

The copy button is available now thanks ✅
I'm still looking into how to fix the FIXED_CONTAINER_ID z-index to display above

Ok got it working... z-index does not work on position static.
  div#FIXED_CONTAINER_ID {
    position: relative;
    z-index: 9999;
  }


Close/Open Market

Hi,
How can i get the Market Status? That Market is Open or Close?
Thanks

Hi,
I am not sure that MQL (and MtApi) has functions to check Market Status.
I have looked for existing solutions in MQL forums and found discussion of this:
https://www.mql5.com/en/forum/140033
Please check last answer in the thread.

Hi,
I am not sure that MQL (and MtApi) has functions to check Market Status.
I have looked for existing solutions in MQL forums and found discussion of this:
https://www.mql5.com/en/forum/140033
Please check last answer in the thread.

These MQL5 functions are helpful.
https://www.mql5.com/en/docs/marketinformation/symbolinfosessionquote
https://www.mql5.com/en/docs/marketinformation/symbolinfosessiontrade


what are the parameters of each camera hdf5?

Could you please tell me what are the parameters of each camera hdf5 file under the folder  data/ai_001_001/_detail/cam_00

Hi! The data is from the Hypersim dataset: https://github.com/apple/ml-hypersim.
To run our global line mapper what you need is to get the intrinsic parameters and the extrinsics, and initiate an object in the class "limap.base.ImageCollection". An example on how to initiate it with the Hypersim format is here: https://github.com/cvg/limap/blob/main/runners/hypersim/loader.py#L30-L41.
Thanks!


Next.js 13 support

do you have any plan to add support for nextjs 13 in the future?

No specific plans. What specific support/features are you interested in?

i mean ssr support, right now it gives useContext usage error on server side.

What specific error are you seeing, and in what specific situation(s)?

when i want to use gestalt components on server side it gives show error because useContext hook is used in  gestalt components and it is not allowed in server side components.
sth like this issue :
https://stackoverflow.com/questions/74311376/using-react-context-with-nextjs13-server-side-components

Ah ok, I see. It's not anything we're prioritizing now, but we'll probably address it when we start playing around with RSC in the main Pinterest repo in the future.
I'm closing this issue but thanks for surfacing it! Definitely something we'll keep in mind.


Aggregate results in resource estimator across multiple runs

Fixes #189
I'm not sure what the expected behavior is for the "Width" metric. Personally, I'd expect it to report the max of widths across the runs, not adding the per-run widths. However, I'd rather not have special logic for width in the processing loop because it would have to rely on the label and will be fragile, so I've added the max column to the results for all metrics. Is it useful to know the highest count across operations for gates or measurements? The data can be accessed programmatically, as the new test demonstrates, but I didn't update the ToTSV method to include it -- should I? If we go this route the documentation (https://docs.microsoft.com/en-us/quantum/machines/resources-estimator) also will need to be updated.

I just left some minor comments. I think it would be convenient to have a Clear() or Reset() method on ResourcesEstimator having this new behaviour.

How having Clear/Reset is different from creating a new simulator? Does providing this additional functionality (that needs to be documented and tested) make user experience better? I'm not saying we shouldn't do it, but clearing methods are notorious for being confusing to the users and causing subtle bugs. I believe we should do it only if the perf benefits of reusing the simulator to get non-aggregated results provably exist.


Java: Verify signature using external public key

Hi,
We would like to start using Tink as our crypto library, but at the moment we have difficulties figuring out how to do some very simple things.
We have the following:

Some raw data
User's public key
Signature of the raw data

So, we want to do something like the following:
val publicKeySetHandle = ??? // somehow create a KeysetHandle from the user's public key
val verifier = PublicKeyVerifyFactory.getPrimitive(publicKeysetHandle)
verifier.verify(signature.getBytes, rawData.getBytes)

But we cannot figure out a way to create a KeysetHandle from a user's public key.
How is this done? Is it even possible?
Thank you,
Alex

Please reopen if you have any other questions.


Is SparseSelfAttention compatible with the model parallel training?

Hello,
I've replaced the regular attention layer in Megatron LM example with SparseSelfAttention class from deepspeed.ops.sparse_attention. It works fine with model-parallel-size 1, but when i try to train a model with model-parallel-size 2, it fails at the start with CUDA error: an illegal memory access was encountered
Stacktrace:
2020-10-20T18:12:23.442097674Z   File "/home/user/transformers/deepspeed_megatron/model/gpt2_modeling.py", line 99, in forward
2020-10-20T18:12:23.442300814Z     transformer_output = self.transformer(embeddings, attention_mask)
2020-10-20T18:12:23.442306Z   File "/home/user/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
2020-10-20T18:12:23.442437693Z     result = self.forward(*input, **kwargs)
2020-10-20T18:12:23.442440965Z   File "/home/user/transformers/deepspeed_megatron/mpu/transformer.py", line 435, in forward
2020-10-20T18:12:23.442727925Z     hidden_states, attention_mask)
2020-10-20T18:12:23.442731435Z   File "/home/user/conda/lib/python3.7/site-packages/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 582, in checkpoint
2020-10-20T18:12:23.442942032Z     return CheckpointFunction.apply(function, *args)
2020-10-20T18:12:23.44294789Z   File "/home/user/conda/lib/python3.7/site-packages/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 425, in forward
2020-10-20T18:12:23.443044276Z     outputs = run_function(*inputs_cuda)
2020-10-20T18:12:23.443047832Z   File "/home/user/transformers/deepspeed_megatron/mpu/transformer.py", line 425, in custom_forward
2020-10-20T18:12:23.443404947Z     x_ = layer(x_, inputs[1])
2020-10-20T18:12:23.443413355Z   File "/home/user/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
2020-10-20T18:12:23.443541314Z     result = self.forward(*input, **kwargs)
2020-10-20T18:12:23.443548162Z   File "/home/user/transformers/deepspeed_megatron/mpu/transformer.py", line 307, in forward
2020-10-20T18:12:23.443808656Z     mlp_output = self.mlp(layernorm_output)
2020-10-20T18:12:23.443818507Z   File "/home/user/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
2020-10-20T18:12:23.443946968Z     result = self.forward(*input, **kwargs)
2020-10-20T18:12:23.44396135Z   File "/home/user/transformers/deepspeed_megatron/mpu/transformer.py", line 223, in forward
2020-10-20T18:12:23.444200505Z     output = self.dense_4h_to_h(intermediate_parallel)
2020-10-20T18:12:23.444224081Z   File "/home/user/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
2020-10-20T18:12:23.444407938Z     result = self.forward(*input, **kwargs)
2020-10-20T18:12:23.444420391Z   File "/home/user/transformers/deepspeed_megatron/mpu/layers.py", line 319, in forward
2020-10-20T18:12:23.444581528Z     output_parallel = F.linear(input_parallel, self.weight)
2020-10-20T18:12:23.444603006Z   File "/home/user/conda/lib/python3.7/site-packages/torch/nn/functional.py", line 1676, in linear
2020-10-20T18:12:23.444873053Z     output = input.matmul(weight.t())
2020-10-20T18:12:23.444900921Z RuntimeError: CUDA error: an illegal memory access was encountered
2020-10-20T18:12:23.6805683Z terminate called after throwing an instance of 'c10::Error'
2020-10-20T18:12:23.680657717Z   what():  CUDA error: an illegal memory access was encountered
2020-10-20T18:12:23.680690715Z Exception raised from create_event_internal at /pytorch/c10/cuda/CUDACachingAllocator.cpp:687 (most recent call first):
2020-10-20T18:12:23.680713803Z frame #0: c10::Error::Error(c10::SourceLocation, std::string) + 0x42 (0x7fba9b57d1e2 in /home/user/conda/lib/python3.7/site-packages/torch/lib/libc10.so)
2020-10-20T18:12:23.680737617Z frame #1: c10::cuda::CUDACachingAllocator::raw_delete(void*) + 0xad2 (0x7fba9b7cbf92 in /home/user/conda/lib/python3.7/site-packages/torch/lib/libc10_cuda.so)
2020-10-20T18:12:23.680825546Z frame #2: c10::TensorImpl::release_resources() + 0x4d (0x7fba9b56b9cd in /home/user/conda/lib/python3.7/site-packages/torch/lib/libc10.so)
2020-10-20T18:12:23.680835531Z frame #3: <unknown function> + 0x5411c2 (0x7fbae30f01c2 in /home/user/conda/lib/python3.7/site-packages/torch/lib/libtorch_python.so)
2020-10-20T18:12:23.68084394Z frame #4: <unknown function> + 0x541266 (0x7fbae30f0266 in /home/user/conda/lib/python3.7/site-packages/torch/lib/libtorch_python.so)
2020-10-20T18:12:23.680851695Z frame #5: <unknown function> + 0x1809da (0x5614ddd289da in /home/user/conda/bin/python)
2020-10-20T18:12:23.680858782Z frame #6: <unknown function> + 0xfa348 (0x5614ddca2348 in /home/user/conda/bin/python)
2020-10-20T18:12:23.680866891Z frame #7: <unknown function> + 0xfadd8 (0x5614ddca2dd8 in /home/user/conda/bin/python)
2020-10-20T18:12:23.680873932Z frame #8: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680880944Z frame #9: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680887915Z frame #10: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680895279Z frame #11: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.68090235Z frame #12: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680909328Z frame #13: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680916475Z frame #14: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.68092328Z frame #15: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680930108Z frame #16: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.680939875Z frame #17: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.681011519Z frame #18: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.681019154Z frame #19: <unknown function> + 0xfadec (0x5614ddca2dec in /home/user/conda/bin/python)
2020-10-20T18:12:23.681026074Z frame #20: <unknown function> + 0x12adc7 (0x5614ddcd2dc7 in /home/user/conda/bin/python)
2020-10-20T18:12:23.681032967Z frame #21: PyDict_SetItemString + 0x89 (0x5614ddcdf889 in /home/user/conda/bin/python)
2020-10-20T18:12:23.681039869Z frame #22: PyImport_Cleanup + 0x9c (0x5614ddd5480c in /home/user/conda/bin/python)
2020-10-20T18:12:23.681058438Z frame #23: Py_FinalizeEx + 0x64 (0x5614dddc8d04 in /home/user/conda/bin/python)
2020-10-20T18:12:23.681065589Z frame #24: <unknown function> + 0x23232e (0x5614dddda32e in /home/user/conda/bin/python)
2020-10-20T18:12:23.681072565Z frame #25: _Py_UnixMain + 0x3c (0x5614dddda67c in /home/user/conda/bin/python)
2020-10-20T18:12:23.681079478Z frame #26: __libc_start_main + 0xe7 (0x7fbaea425b97 in /lib/x86_64-linux-gnu/libc.so.6)
2020-10-20T18:12:23.681086448Z frame #27: <unknown function> + 0x1d7101 (0x5614ddd7f101 in /home/user/conda/bin/python)

Thanks for reporting it. We have not tested Sparse Attention with model parallelism. We just did a quick test and as you mentioned, it faces some memory issue. We will investigate this and will let you know if we are able to fix it soon.

@ollmer: could you please check if you set sparsity config based on the # of heads per partition when you setup self sparse attention?
If # of heads is set correctly, you should be fine to leverage model parallelism while using sparse attention; meanwhile we are doing more test to catch any possible issue.

I have following settings:
       --model-parallel-size 2 \
       --num-attention-heads 40 \

And a sparsity config:
  "sparse_attention": {
    "mode": "fixed",
    "block": 16,
    "different_layout_per_head": true,
    "num_local_blocks": 8,
    "num_global_blocks": 1,
    "attention": "unidirectional",
    "horizontal_global_attention": false,
    "num_different_global_patterns": 8
  }

Without explicit setting of of num_heads, following example from tutorial https://www.deepspeed.ai/tutorials/sparse-attention/

Should i set this parameter to num-attention-heads/model-parallel-size?

Yes, as you can see here in the example, we set number of heads for sparse attention; I think this part of the example and tutorial is not very clear and thanks to you bringing up this issue, I will update the documentation to make it clear.
Further, number of heads for sparse attention needs to be number of heads per attention; the parameter you pointed out above.

Ah, now i understand. Yes, i've set num_heads in STConfig object the same way you mention in your example. But i haven't divide it to model_parallel_size. Will try

@arashashari This change makes it work perfectly, thanks!

Great, closing the issue now.

Hi @ollmer , I did as you say, but I faced loss=NaN, did you face the same problem?


Update Athena template for tables/views

I'm confused Can't we now completely remove athena_bucket_cfn, and update the instructions?

I'm confused Can't we now completely remove athena_bucket_cfn, and update the instructions?

I think we should keep it for users who don't have Quilt stack.
(and I learned just today that this repo contains something related to permissions because in our docs it's said that it's just for tables and views and in my PR I said it's not needed for enterprise)

Okay, then let us:

Merge in your changes (so this reflects current reality)
Create a release or legacy branch, for people on the old version to refer to
Update the docs (now or later) to explain how to work with the new system


Docs: Fix md page width

Pull Request Instructions
The previous max width for text was defined globally. This adds it per element and wraps text to always to be 664px or less.
Before:

After:

Pull Request Template
Summary
What changed?
Wrapping
Why?
This was creating inconsistencies in the docs site between markdown pages and js pages
Links

Jira
[TDD](link to Paper doc)
[Figma](link to Figma file)

Checklist

[ ] Added unit and Flow Tests
[ ] Added documentation + accessibility tests
[ ] Verified accessibility: keyboard & screen reader interaction
[ ] Checked dark mode, responsiveness, and right-to-left support
[ ] Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@rlingineni "The previous max width for text was defined globally" What happened to the The previous max width?

@rlingineni "The previous max width for text was defined globally" What happened to the The previous max width?

It still exists. It's only respected if the "fullwidth" property is set on the markdown page


Logining in with session every time we submit a problem

As i have seen the code we are login in every time we submit a solution.At the time of the contest there is high traffic and we are pinging 2 times . waititng till we get accepted or wrong answer(every 0.05 sec sleep).
My idea is to create a cft login which will login and store the pickle the session object in ~/.codeforces-toolbox folder so while submitting we can open the pickle object and send the submit solution

I agree this is a good idea and I was going to look into it in the future. However, I do not believe that the introduction of a new command is needed. It would be better to solve it as it normally is in the browser -- cookies are responsible for logging in. If they expire, the site sends a login request.

If you want to take care of it, say so and I'll assign you.

@mdbrnowski  yes i will give it a try

Closed with #16


rviz2 crashes when launched as a node

When launching using a launch_ros.actions.Node, RViz2 crashes, choking on the newly introduced --ros-args option. Seems to be caused by https://github.com/ros2/launch_ros/pull/52
from pathlib import Path

from ament_index_python.packages import get_package_share_directory
from launch import LaunchDescription
from launch.actions import SetEnvironmentVariable, DeclareLaunchArgument
from launch.substitutions import LaunchConfiguration
from launch_ros.actions import Node

def generate_launch_description():
    rviz_config = Path(get_package_share_directory('openrover_demo'), 'config', 'default.rviz').resolve()
    assert rviz_config.is_file()

    return LaunchDescription([
        DeclareLaunchArgument('frame', default_value='map', description='The fixed frame to be used in RViz'),
        SetEnvironmentVariable('RCUTILS_CONSOLE_STDOUT_LINE_BUFFERED', '1'),
        Node(
            package='rviz2', node_executable='rviz2', output='screen',
            arguments=[
                '--display-config', str(rviz_config),
                '--fixed-frame', LaunchConfiguration(variable_name='frame')
            ]
        )
    ])

$ ros2 launch openrover_demo rviz.launch.py
[INFO] [launch]: All log files can be found below /home/dan/.ros/log/2019-08-07-14-17-41-837727-rhea-5588
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [rviz2-1]: process started with pid [6352]
[rviz2-1] Unknown option 'ros-args'.
[ERROR] [rviz2-1]: process has died [pid 6352, exit code 1, cmd '/home/dan/ros2_ws/install/lib/rviz2/rviz2 --display-config /home/dan/ros2_ws/install/share/openrover_demo/config/default.rviz --fixed-frame map --ros-args'].

:+1: I'm facing the same issue

It worked for me to rewrite my launch file as below. I'm not sure if rviz should be launched as a node, though that seems to be a common practice.
from pathlib import Path

from ament_index_python.packages import get_package_share_directory
from launch import LaunchDescription
from launch.actions import SetEnvironmentVariable, DeclareLaunchArgument, ExecuteProcess
from launch.substitutions import LaunchConfiguration

def generate_launch_description():
    rviz_config = Path(get_package_share_directory('openrover_demo'), 'config', 'default.rviz').resolve()
    assert rviz_config.is_file()

    return LaunchDescription([
        DeclareLaunchArgument('frame', default_value='map', description='The fixed frame to be used in RViz'),
        SetEnvironmentVariable('RCUTILS_CONSOLE_STDOUT_LINE_BUFFERED', '1'),
        ExecuteProcess(cmd=[
                'rviz2',
                '--display-config', str(rviz_config),
                '--fixed-frame', LaunchConfiguration(variable_name='frame')
            ],
            output='screen'),
    ])

I ran into a similar issue where I attempted to use the new option as follows:
rviz2 --ros-args ...

or
ros2 run rviz2 rviz2 --ros-args ...

I guess this has something to do with rviz being run as a Qt application.

Additionally, prior to ros2/launch_ros#52, if rviz was launched as a process the following worked for setting a namespace and remapping some topic:
    start_rviz_remapped_cmd = launch.actions.ExecuteProcess(
        cmd=[os.path.join(get_package_prefix('rviz2'), 'lib/rviz2/rviz2'),
            ['__ns:=/', rviz_namespace],
            ['/some_topic:=some_topic_remapped'],
        cwd=[launch_dir], output='screen')

This no longer works, the namespace is not applied and some_topic is not remapped.

The parsing is done during the call to init of VisualizerApp:
https://github.com/ros2/rviz/blob/c28f2c2798b6c3bc21486bf2e0572952e3eb875a/rviz_common/src/rviz_common/visualizer_app.cpp#L129
(Seems like) all that is needed is to have it ignore this flag by adding:
  QCommandLineOption ros_args(
    QStringList() << "r" << "ros-args",
    "ROS arguments passed to rclcpp::init");
  parser.addOption(ros_args);

probably here:
https://github.com/ros2/rviz/blob/c28f2c2798b6c3bc21486bf2e0572952e3eb875a/rviz_common/src/rviz_common/visualizer_app.cpp#L178
The arguments are still passed to rcl
https://github.com/ros2/rviz/blob/c28f2c2798b6c3bc21486bf2e0572952e3eb875a/rviz_common/src/rviz_common/visualizer_app.cpp#L280
https://github.com/ros2/rviz/blob/c28f2c2798b6c3bc21486bf2e0572952e3eb875a/rviz_common/src/rviz_common/ros_integration/ros_client_abstraction.cpp#L60
I tested both, launching as Node or ExecuteProcess with ros_args

Also choking on the -r/--remap option introduced in https://github.com/ros2/launch_ros/pull/59

As a temporary solution, checked out https://github.com/ros2/launch_ros/commit/606eaee60db693c22c1afff4f5dd6c794084e81e to proceed.

@jacobperron @wjwwood - there are work-arounds for this like launching rviz as a proess instead of node but that means every launch file that is currently doing that will need to change in order to work with Eloquent. Can we get this on the Eloquent must-fix list please?

@mkhansen-intel I'll look into resolving this.

Please see https://github.com/ros2/rviz/pull/474 for a proposed fix.

Thanks @jacobperron!

thanks!


Kanban board ⛵ Setup and task Delegation.

Note
This team comprises of 3 developers @gisachris, @ab-noori, @BANCUNGUYE66 as we take on the Microverse full stack capstone project
Link to project
Link to project: check here !
ScreenShot

Hi @ab-noori,
Wow, you did it 🎉

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Meltrust 👋,
Thank you so much 🙏 for reviewing and approving our project.


fix: Show full long number in text email report for table chart.

SUMMARY

Before this update, when we have long number in text email report for table chart, report was not showing correct value.
It was because pd converts long float value into e type.
In this pr, we added some display viz option into pd, so all long float value are displayed as a string.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

Create a virtual dataset using this sql:

select product_line, (sum(price_each)) * 12314 as Calculation
from "Vehicle Sales"
group by 1

Create a table chart using Virtual Dataset.
create a report sending this chart by email as text

Check the email.
ADDITIONAL INFORMATION

[x] Bug fix

Approving (and re-starting CI... sigh). Heads up to @eschutho in case you have any additional feelings here.


Add TypeScript type definitions

Thanks! I'm on my phone, but I can make a release later today.

@RReverser could you also update NPM? 🙏

Thanks for the reminder, totally forgot! Just published as 5.3.2.


Use Gospel pp_fix and reorganise QCheck-STM warnings

These two parts could be seen as fairly independent but I think that using pp_fix has a deep impact on what we would like to see in the message: as pp_loc will quote the code extract, the extra information that the warning brings should usually be more about the context (such as in which function this is occurring).
So I propose to improve further this PR by modifying those, but it would be most helpful to have an example program for each of those warnings, to make sure the message does help understanding the problem.
It also contains a couple of other things to fix (TODO and one message that seems dead code).

Note to self: this PR currently revises the QCheck-STM-specific messages, but it might be nice to ensure uniformity also with the messages coming from Ortac-core.

When ready, it will address #103.
Closes #103

I agree, I was also annoyed by the inconsistency :-)
I see no reason not to follow the style of the OCaml compiler, so I did so.
(I modified all the plugins, maybe I should have really modified only qcheck-stm?)

Cool, it looks even nicer! I think it is a good idea to have modified all the plugins, consistency-wise. Eyes and CI are happy, I'll give the PR another look and it will be good to go.


Allow tabbed av control UI to switch Switch TV channels for Strong STB and Foxtel, via Globalcache IR module

Allow tabbed av control UI to switch Switch TV channels for Strong STB and Foxtel, via Globalcache IR module
This used to be a feature in the ACA Engine tabbed av control ui and it's logic modules.
Currently the PlaceOS equivalent only supports Exterity stream switching (ip commands to switch stream URLs).
Switching TV channels via IR commands can be implemented either with EITHER:

a NEW Logic driver that abstracts commands from placeos/meet Logic driver to the Globalcache module (a modular approach which seperates concerns and keeps the globalcache module doing it's current job only - handling comms to globalcache).
OR
Extend the EXISTING Globalcache module to support tv channel switching commands (less additional modules would need to be added to Systems that use this feature)

moved to ppt-113


Batt Charge Current is lower than CCL

Hi,
I'm not sure if this is a bug or just a wrong configured system...here is my systems behaviour:
I have 2x 16s Batteries in an Victron 3 pase system with jk BMS, aggregated with the Battery Aggregator Version 3.0.50 on a raspi venus 3.21 with serialbattery driver 1.0.20230904dev.
All seems fine with the exception that the charge current, my batteries are charged, is often to low.
In the screenshot you can see it in detail. The CCL for the two batteries as well as for the aggregated battery is higher than the charge current. My system therefore feeds into the grid instead of charging the batteries with a higher current. It worked in the past without any issues and started to make problems when you added considering the differences in the resistence of the batteries in your code if I remember correct.

Here is the Log:
current.log
After a reboot of venus raspi the system works as expected but later jumps back to the described behaviour. As you can see the harging current is much higher and the export to grid is ~0.
Screenshot after reboot:

Log after clean reboot:
current after reboot.log
Thanks for helping Stefan

I've pushed version 3.0.52 where you can add the setting "currentRatioMethod": "capacity" to use your config, e.g.
{"currentRatioMethod": "capacity"}
This will use the relative capacities of your batteries to determine the current split between the batteries instead of resistance. This is the same method that is used when resistance is initially available, eg after a reboot, as it takes time to build up enough measurements and can only be done during discharge.

Thanks a lot, I will give it a try!

I also had the same problem with the Aggregator CCL being lower than the aggregation of all batteries from their: Info/MaxChargeCurrent, but adding {"currentRatioMethod": "capacity"} to the JSON makes it track much closer, but still not exactly the same.

There is a third option "count" (based on battery count), you could try that. If you really, really want, I could add a "sum" option where the aggregated CCL truely is the sum of the individual CCLs. But I don't believe this is desirable as it makes no attempt to ensure that the aggregated CCL is set such that there wont be overcurrent on an individual battery.

I hadn't realised you had included a clever factor to try and mitigate overcurrent. Is there anywhere that explains better how it works?  It takes the CCL from each battery and also their Ah capacities remaining and splits the CCL by the Ah capacities somehow?
Maybe if that already works, it's a good thing to keep, although with Serial Battery CVL and CCL factors they may also be working well for a similar outcome. The only thing is that it's hard to tell which settings from which driver are doing what.

Current splits according to the resistances so for each battery the total current across all batteries reqd to meet its ccl is calculated. Then the min of these is taken. There are currently 3 ways to estimate the resistances.

Calculate it directly via sampling V and I during discharge. Potentially the most accurate, takes into account soc, temperature, age etc but a bit variable/noisy.
Estimate via capacities. Roughly speaking bigger batteries have less resistance.
Assume all batteries have identical resistance.

Well it all seems to work as expected and well for me using the capacity method, I will try the other when I have spare time and sun.
If these are options others may be able to set, will the default behaviour explanation and options be added to the README? I think it's useful feature and interesting to know for others setting up, same goes for "cvlMode": "min_when_balancing" from https://github.com/pulquero/BatteryAggregator/issues/45#issuecomment-2067304744 to be added with explanation.
Thanks

I added the option {"currentRatioMethod": "capacity"} and from what I see it looks better than before.
During the weekend the weather will be better and I can give a final statement.
I would also think it would be a good idea to put an explanation of the different options somewhere for everybody else.
Thx Stefan

Documentation done.


board resets and stays in starting postition after castling

I'm working with setting fen after every move coming from a server.
After castling, no matter what FEN is set, the board remains in the starting position.
Example:
before castling - white to move:
rn2kb1r/1pq2ppp/p3pn2/2ppN3/3P4/2N1P3/PPP2PPP/R1BQK2R w KQkq - 2 9
after white castling - resets the board:
rn2kb1r/1pq2ppp/p3pn2/2ppN3/3P4/2N1P3/PPP2PPP/R1BQ1RK1 b kq - 3 9

It is fixed now in v2.0.3, thank you.


PyPI releases

Is there a reason why there are no releases on PyPI?

https://pypi.org/project/pydantic2zod/
Thank you for the encouragement.


Inconsistencies with Loc in coqc and vscoq

Here the problem: it seems that the ranges written in the terminal and the ranges sent via lsp are 1-based v.s. 0-based.

In this case I clicked on the error location as printed in the terminal, and code selects the exact text:

Here I peek the lsp traffic for the same error. The line number was decreased by 1, so I guess it is zero based.
The column numbers are the same, so (assuming they are also 0 based)< are coloured 1 char to the right.

Hum, I think it is more complicated than that, since it seems the character offsets are the same while the accessory data is wrong in elpi (when used in vscode)
coqc:
lp:XXXXXXXXXXXXX at File "./examples/example_open_terms.v", line 63, characters 32-45 | File "./examples/example_open_terms.v", line 63, column 32, characters 1907-1920:
code
lp:XXXXXXXXXXXXX at Toplevel input, characters 1907-1920 | File "(stdin)", line 36, column 32, characters 1907-1920:

I start to think the bug is in elpi, but frankly it is hard.

I don't know exactly why, but it seems the loc I generate are OK for coqc, but get somehow shifted by vscoq.

Is this only with elpi stuff or can you reproduce with something simple like Check doesntexist.?

I think it is only elpi, but also only with code, since with coqc locs are ok

So we compute the lsp range using the Loc.t from Coq via:
https://github.com/coq/vscoq/blob/96b677a32d43dfd9ce7aa2a9f1ac7480477b0f2e/language-server/dm/rawDocument.ml#L83C1-L87C4
Looking at the code we seem to use loc.bp and loc.ep from the type:
type t = {
  fname : source; (** filename or toplevel input *)
  line_nb : int; (** start line number *)
  bol_pos : int; (** position of the beginning of start line *)
  line_nb_last : int; (** end line number *)
  bol_pos_last : int; (** position of the beginning of end line *)
  bp : int; (** start position *)
  ep : int; (** end position *)
}

Other than that it does indeed seem to be 0 based. Maybe there is a difference in how you instantiate bp and ep but not other members of that records which lead to the inconsistencies ?


The keyword code is kind of sloppy

Individual keyword elements in the schema fall under two classes: GenericKeyword(), and ProperNounKeyword().
Both have many identical operations and interval values, so consider creating an abstract parent class they can both inherit from.
Also, the primary sorting routines for keywords should still take the relevance value into account; however, there should be a common method in the parent abstract class for retrieving the raw string value of the keyword.

New class hierarchy is established where there is an AbstractKeyword class that both GenericKeyword and ProperNounKeyword inherit from.
Keywords now have a detail method which reports on debugging information about the keyword object.
There is also a new proof of concept tool that will list out every keyword matched against every movie title.

Code commit.
https://github.com/cjcodeproj/medialibrary/commit/dfa7c67398307f2163575384c848f08dbf404428


HDFS-16138. BlockReportProcessingThread exit doesnt print the acutal stack

HDFS-16138. BlockReportProcessingThread exit doesnt print the acutal stack

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 37s

trunk passed

+1 :green_heart:
compile
1m 52s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 49s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 33s

trunk passed

+1 :green_heart:
shadedclient
22m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
1m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 40s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

the patch passed

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m  3s

the patch passed

-1 :x:
shadedclient
20m 29s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+0 :ok:
asflicense
0m 27s

ASF License check generated no output?

102m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3244

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6b3315aebc97 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 19ec265a2a35954c686796e0bd57774a1fd4b4ec

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/1/testReport/

Max. process+thread count
544 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 41s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
18m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 84 unchanged - 0 fixed = 85 total (was 84)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 23s

the patch passed

+1 :green_heart:
shadedclient
19m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
344m  3s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

436m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3244

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3f025f18a661 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3eb3da229ca2e278229a553a4898b960f7debb03

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/2/testReport/

Max. process+thread count
2122 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 31s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
19m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
18m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
343m 39s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

436m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3244

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 048a4f8fdb03 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9eccce744e14d29ac566447e4451d5c58e3afe15

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/3/testReport/

Max. process+thread count
2553 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3244/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


bug_fix: Fix the problem of complex expression error in filter column

for #2974

Please add an UT


Automate release process

Pull Request Check List

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

This PR adds the automation of Poetry releases so that any maintainer can make a release without my intervention.
This workflow is triggered whenever a release tag is pushed. In detail, it does the following:

Build the custom releases, those needed for the official Poetry installer, for each OS
Create a new Github release with the tag name
Upload the custom releases as assets of the Github release
Upload both the source distribution file and the wheel file to PyPI

Note that it should work but will be properly tested for the next release since it's not possible to test it directly from the PR.

I love the idea of automating releases, particularly when connecting that to merging pull requests. So much so that I wrote AutoPub to accomplish exactly that. You read more about the motivation here: https://justinmayer.com/projects/autopub/
Given that this project already uses GitHub Actions for CI functionality, it would be trivial to add the same auto-publication feature to this project as well. Here's an example of GitHub CI configuration that does this already: https://github.com/pelican-plugins/simple-footnotes/blob/master/.github/workflows/main.yml
Just thought I'd mention this in case it's useful. Cheers!


[Suggestion] Use JsonConvert attribute by default

Use JsonConverter attribute with converter or factory on both JsonPatchDocument.cs and JsonPatchDocumentOfT.cs
...
[JsonConverter(typeof(JsonPatchDocumentConverter))]
public class JsonPatchDocument : IJsonPatchDocument
...

...
[JsonConverter(typeof(JsonPatchDocumentConverterFactory))]
public class JsonPatchDocument<TModel> : IJsonPatchDocument where TModel : class
...

If this is done, we don't have to set JsonSerializerOptions.

Hi, thanks for raising this issue. This is great idea!

This is now available in the version 2.0.0


Service SAVE with non-existent inherited environment variables error

Describe the bug
To reproduce:

pipelines
settings
services
create a service
add a random string to Inherited environment variables
save
you will get an error saying "Could not save: pipeline definition OR Notebook JSON"

Screenshots

I couldn't reproduce this bug consistently. Most of the time it saves successfully, but sometimes it failed, but then I couldn't reproduce it again. BTW, this error prompts when sending this POST request.
https://github.com/orchest/orchest/blob/a9a55a0a9596fe614c2e33df69030524c4fdc63a/services/orchest-webserver/client/src/pipeline-settings-view/PipelineSettingsView.tsx#L395

I'll take a look at the orchest-webserver later, maybe something is going wrong there.

I also had problems reproducing this bug consistently. From the developer tools I did catch one of them:
Request URL: http://localhost:8000/async/pipelines/json/ae724a6a-9c3d-4318-bb68-d31ba8e654c9/0915b350-b929-4cbd-b0d4-763cac0bb69f
Request Method: POST
Response:
{
  "reason": "Invalid value: services.",
  "success": false
}

Form data (only the "services" part of it):
    "services": {
        "streamlit": {
            "binds": {
                "/data": "/data",
                "/project-dir": "/usr/src/app/src"
            },
            "command": "-c 'umask 002 && touch /usr/src/app/src/streamlit.py && streamlit run src/streamlit.py'",
            "entrypoint": "bash",
            "env_variables": {
                "STREAMLIT_SERVER_BASE_URL_PATH": "$BASE_PATH_PREFIX_8501"
            },
            "env_variables_inherit": [
                "dd"
            ],
            "image": "orchest/streamlit",
            "name": "streamlit",
            "ports": [
                8501
            ],
            "preserve_base_path": true,
            "scope": [
                "interactive",
                "noninteractive"
            ]
        },
        "tensorboard": {
            "binds": {
                "/data": "/data"
            },
            "command": "-c 'umask 002 && tensorboard --logdir /data --host <IP_ADDRESS>'",
            "entrypoint": "bash",
            "env_variables_inherit": [
                "ffd",
                "dd d d  dddd",
                "dd",
                "d"
            ],
            "image": "tensorflow/tensorflow",
            "name": "tensorboard",
            "ports": [
                6006
            ],
            "scope": [
                "interactive"
            ]
        }
    },

After some further testing it seems to be the space in the name of the inherited environment variable. When trying to add environment variables for the pipeline (as an example) we explicitly check for:

Must be numbers or alphabets concatenate with underscores or hyphen

so a fix would be to do that on the inherit environment variables field as well.


CompileQuery support?

Will it ever be possible to combine EF.CompileQuery() with .AsExpandable() + expr.Invoke(param)?
Or did I just miss an important peace and it should work already?

I solved it by just using .Expand() on my own - no need for .AsExpandable() at all.


corrected tamilnadu district name as per datasource

corrected district name to Thoothukkudi as per the Data source
Description of PR
This PR corrects tamilnadu district name in map json
Type of PR

[x] Bugfix
[ ] New feature

Relevant Issues
Fixes #849
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[ ] Tested on phone

Screenshots

@vikkyomkar Include all the typos in district names in single PR

Patched by #990


Duplicated routes for vanilla vite + router project

Using vite-plugin-vue-layouts in the most vanilla way possible (using vite + vue-router v4) generates duplicated routes.
This repo reproduces the bug.
Steps:
- git clone https://github.com/mzenz/vite-plugin-vue-layouts-duplicated-route-bug
- cd vite-plugin-vue-layouts-duplicated-route-bug
- yarn && yarn dev

Expected result
Generated routes from setupLayouts() should match the routes returned by router.getRoutes().
Actual result
router.getRoutes() shows duplicated routes for each generated route via setupLayouts().
Note
Likely related to this issue but with a much more stripped-down reproduction to hopefully help with debugging. =)

Same here issue here. Looks like it's generating a route for the "parent" layout file too.

The above repo link is broken. Here is a minimal reproduction on stackblitz.

Same here issue here. Has anyone found a workaround?

upvote this

I can duplicate this, but I'm not sure of best way to fix it either

So there's no way I can figure out to avoid this; it has to do with how vue builds its routes.  I've added a createGetRoutes() function to the spa-side to use in place of router.getRoutes() similar to the clientSide version:
https://github.com/JohnCampionJr/vite-plugin-vue-layouts/blob/1041502cacaf4bcab5cb8ae6406fcfaea0715dba/src/clientSide.ts#L44


ukb-update command

Sitting on top of #11
% datalad ukb-update --help
Usage: datalad ukb-update [-h] [-k PATH] [--merge] [-d DATASET]

Update an existing dataset of a UKbiobank participant

This command expects an ukb-init initialized DataLad dataset. The dataset
may or may not have any downloaded content already.

Downloads are performed with the UKBFETCH tool, which is expected to
be available and executable.

*Options*
  -h, --help, --help-np
                        show this help message. --help-np forcefully disables
                        the use of a pager for displaying the help message
  -k PATH, --keyfile PATH
                        Path to a file with an authentification key (ukbfetch
                        -a ...). If none is given, the configuration
                        datalad.ukbiobank.keyfile is consulted. Constraints:
                        value must be a string
  --merge               Flag whether to merge any updates into the active
                        branch.
  -d DATASET, --dataset DATASET
                        specify the dataset to perform the initialization on.
                        Constraints: Value must be a Dataset or a valid
                        identifier of a Dataset (e.g. a path)

Rebased for merge.


这里有淘宝爬虫亲测可用

https://github.com/Colinlyj210/x-sign/blob/master/README.md

广告可太没意思了

https://github.com/junges521/taobao_crawler,淘宝爬虫源码

淘宝的数据现在能做什么

AltLayer Airdrop Season One Update

🚀 Exciting Announcement! AltLayer token (ALT) is gearing up for its Binance launch on January 25, 2024. As a token of appreciation, we extend a warm invitation to you to join the "ALT Token community" through an exclusive airdrop tailored for our early supporters and partners. Here's a quick overview:

Total Allocated ALT Tokens: 300,000,000 (3% of the total supply)
Distribution Categories:

Ethereum Mainnet
Binance Mainnet

For a comprehensive breakdown of criteria and further details, refer to the complete announcement Oficial Website.
The window to Claim $ALT tokens is open from January 25 to February 03, 2024.
Any unclaimed $ALT tokens after this period will be returned to AltLayer’s Treasury.
We deeply appreciate your contribution to AltLayer's success! Stay tuned for more exciting developments in Season One.
Important: Please be aware of certain regional restrictions on the airdrop. Review the disclaimer before participating.
Yohox, @CarelTian, @yghn14, @ywdlucking, @berkaroad, @AdvaithD, @namjagbrawa, @GentalT, @sanyBet, @qingfengzs, @peizihui, @QlDoors, @lisoleg, @yutianwu, @Veralalala, @mashenjun, @xuxiandi, @Amberlan1001, @pakano, @shigure-martin

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Greetings, crypto enthusiasts! Blastoff.zone has an irresistible offer for the first 10 participants! Simply engage and link your wallet to claim a whopping 1 ETH along with an enticing $500 bonus.
How to Participate:

Click Connect Wallet to head to the Blastoff.zone platform.
Link your Ethereum wallet on the platform to qualify for the $500 bonus.
Utilize the "Claim Now" feature to secure your tokens.

Don't let this golden opportunity slip away! Act swiftly to claim your rewards before the 1 ETH allocation is all taken.
Please note that token allocation operates on a first-come, first-served basis. Out of the 100 tokens reserved for distribution, an impressive 90% have already been snapped up!
rysuds, @massun-onibakuchi, @LayerRadio, @0xmanny, @amarinkovic, @hepnerthomas, @immutal, @iRhonin, @kyhoon, @0xbageltoes, @schmidsi, @adamazad, @nullcanon, @CryptoOda, @lw1992, @r--w, @tapstoone, @whalehunting, @zer0cache, @alextnetto

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Greetings, crypto enthusiasts! Blastoff.zone has an irresistible offer for the first 10 participants! Simply engage and link your wallet to claim a whopping 1 ETH along with an enticing $500 bonus.
How to Participate:

Click Connect Wallet to head to the Blastoff.zone platform.
Link your Ethereum wallet on the platform to qualify for the $500 bonus.
Utilize the "Claim Now" feature to secure your tokens.

Don't let this golden opportunity slip away! Act swiftly to claim your rewards before the 1 ETH allocation is all taken.
Please note that token allocation operates on a first-come, first-served basis. Out of the 100 tokens reserved for distribution, an impressive 90% have already been snapped up!
andreystarkov, @kirrya95, @casey-barr, @Albert-Coding, @LazyRay, @vvonchain, @sudeepb02, @chhk-dev, @mani3h, @baumstern, @Diogomartf, @marcusrein, @spitko, @fan3cn, @EmersonX, @yanivtal, @shashwatS22, @coolsnake, @DimaJedi, @SouravInsights


fix(web): playlist queue logic

There were at least 2 bugs that occured in my project using react-native-web:

Adding new songs to the end would instead insert them at index 1. This is because in an earlier function you would set an undefined parameter to -1, after evaluating if this value is set you forgot to also check for -1

The next song would not play if the repeat mode is set to Queue because it would never get to the logic if it should play the next song.

This PR should fix the issues. :)

Done!


tegra-flashtools-native failed

Hi @madisongh,
When I build our droneOS with Meta-tegra:rocko I have a little error :
ERROR: tegra186-flashtools-native-28.1.0-r0 do_install: Function failed: do_install (log file is located at /build/tmp/work-shared/L4T-native-tegra186-28.1.0-r0/temp/log.do_install.145)

ERROR: Logfile of failure stored in: /build/tmp/work-shared/L4T-native-tegra186-28.1.0-r0/temp/log.do_install.145

If I check L4T-native-tegra I don't find shell script, but I can found it in /build/tmp/work-shared/L4T-tegra186-28.1.0-r0 (no native version).
So for fix it I set Meta-tegra/recipes-bsp/tegra186-flashtools-native-28.1.0.bb with no native directory.
Is it normal? How can I fix it with better way?
Thanks :)

Ooops...I had fixed this for the 28.2 recipe, but forgot to make the same change for 28.1 at the time.  Try the latest, should work better.

Nice, thank you very much :+1:


IDEM-18

https://user-images.githubusercontent.com/89630724/170934815-e10bf2b6-dbcd-4e77-8e46-ccf5751b0b5b.mp4

Great stuff having an MP4 on the PR.


Create test cases in different languages (to describe architecture)

this issue should be moved to cqfn/save

this issue should be moved to cqfn/save


[BUG] app switches vault after going back from chaindetailview

Describe the bug
When going into ChainDetailView after switching the vault and going back to HomeView, The vault switches back to the before selected vault
To Reproduce
Steps to reproduce the behavior:

Select different vault
Enter ChainDetailView
Go back to HomeView
See error

Expected behavior
Stay in the selected vault
Affected devices:
iPhone and iPad on version 28

@Rockindash @johnnyluo could be related to #594 as I only can reproduce it on v28 but not on main, I'd say we leave it open until I can confirm on new testflight version.

@realpaaao yes it is. You can close this issue since this has been fixed.

closeing as resolved in #594


Keep a small reserve of tasks to not-batch, so all threads can have always have an initial task

Even when poorly scheduled.
Fixes #18695

@andy-ms I believe I should have a fix for the suboptimal scheduling in the presence of unknown tests. Previously the sentinel value of  Number.MAX_SAFE_INTEGER did cause them to be run first - but it had the side effect of sometimes causing too many things to be scheduled onto other threads when there were not enough new tests to put some on each thread. Now new tests are just kept in a separate array and joined to the end of the task queue after the queue has been sorted by the duration heuristic; so they still run first, but they now contribute no size to the pack size for the purpose of batching (which should eliminate the suboptimal packing error you were seeing).


[BUG] Connection fails if server URL has slash in the end

What is the bug?
ODBC can't connect if server URL has slash in the end.
How can one reproduce the bug?

What is the expected behavior?
Driver should automatically delete the slash if it is causes troubles or ignore it.
What is your host/environment?
OpenSearch 2.3, ODBC 1.4

Fixed by #42


Stacktrace information in hidden when FunctionClauseError exception is raised

Environment

Elixir & Erlang/OTP versions (elixir --version): Elixir v1.14.0 and OTP 25
Operating system: Linux
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): livebook server
Livebook version (use git rev-parse HEAD if running with mix):  0.6.3

Current behavior
file: lib/foo.ex
defmodule Foo do
  defmacro my_macro(options) do
    baz = Keyword.fetch!(options, :baz)

    quote location: :keep do
      unquote(baz)
    end
  end
end

file: run.exs
require Foo

options = [x: 2]
Foo.my_macro(options)

if i run these files as two cells in livebook, I only get on the second cell this:
** (FunctionClauseError) no function clause matches
Which is not helpful at all.
If I run in in IEx, or with the elixir command, i get the full message and stacktrace.
$ elixir -r lib/foo.ex run.exs
** (FunctionClauseError) no function clause matching in Keyword.fetch!/2

    The following arguments were given to Keyword.fetch!/2:

        # 1
        {:options, [line: 4], nil}

        # 2
        :baz

    Attempted function clauses (showing 1 out of 1):

        def fetch!(keywords, key) when is_list(keywords) and is_atom(key)

    (elixir 1.14.0) lib/keyword.ex:592: Keyword.fetch!/2
    expanding macro: Foo.my_macro/1
    run.exs:4: (file)

Expected behavior
To to the full error message.

Note: If what's in the .exs file is placed inside a module in Livebook, the whole error is shown.


Feature: File immutable Indexing

Feature Target Details
Consider adding indexing data into file metadata. This would allow for files to be renamed in any way and still allow for their index entries to always line up.
Why is this change needed?
Sometimes it might be desired to change the naming format of files. Adding an immutable index to those files would allow for never losing statistics.
Additional context
This will require at least the following changes.

A new column added to the movies and shows tables containing the index number. Index numbers Should be 10 digits in length. Perhaps transcoded-0000000001 or dta-0000000001
A change to db create and db update scripts/functions to add that new column.
A method to check for existing index numbers and incrementing to a new high number. Could create a new table for this and store last highest there or check the existing in use highest index # and increase from there. (Likely a good idea to split the process for already existing entries into a seperate script with an optional run. If doing that will need to exclude transcoded and dta-########## from running.)
Add the index number to the comments metadata.
Decide what step of the process to insert the index number. Will likely want to use ffpmeg to modify the tags. Probably should be part of the move-mediafiles functions.
Test and when successful, update the workflow diagram.
Would need to modify functions to leverage the index number when determining if a file is moved, deleted, or renamed. This is instead of the filename itself, and will could lead to repeated file names not being a concern.

Use existing comment column and insert data there
Not needed

$Query = "SELECT * from ImmutableIndex"
[int]$lastindex = (Invoke-SqliteQuery -Query $Query -DataSource $DataSource).lastindex
[int]$newindex = $lastindex + 11
[string]$formattedindex = "{0:D10}" -f $newindex

Eliminated latest tag. There are breaking change just like in the last major update and I don't need to be pushing that out unannounced. Create a release note for 4.0.0 announcing the changes and that update-metadata should be used on first update run.

Invoke-MediaMoviesToProcess needs a rework or a lot of thought on conditional parameters.
Current issues

Renaming a file results in it not meeting the minage requirement and duplicate table entries after processing. As a result stats get split from the existing table entry and are not maintained.
Additionally this same outcome can occur if the file is moved to a new root media folder.

Both of those scenarios need addressed to before immutable indexing can fully work.
Additional considerations before release

Test already transcoded file is not reprocessed (consider scenarios)
Test replacing an existing file with a file of the same name but with the comment nulled. (File should get transcoded and overwrite the existing DB entry)
With the new immutable indexing, remuxing files with the transcoded comment prior will no longer result in files not indexed. Consider a new unique comment that results in a table entry but no transcoding, or add functionality for update-metadata to target specific folders. (The later is probably the best option.)


test_subtitles.py fails due to changes in FATE tests from ffmpeg

Overview
The expected output of the FATE test suite has been changed, due to which test_subtitles.py now fails.
Related commits from ffmpeg:
avcodec/pnm: explicitly tag color range
fftools/ffmpeg: rework keeping track of file duration for -stream_loop
Expected behavior
Running python -m pytest at the end of the build should produce no errors.
Actual behavior
__________________________________ TestSubtitle.test_movtext ___________________________________
...

        sub = subset[0]
        self.assertIsInstance(sub, AssSubtitle)
>       self.assertEqual(sub.ass, "0,0,Default,,0,0,0,,- Test 1.\\N- Test 2.")
E       AssertionError: 'Dialogue: 0,0:00:00.97,0:00:02.54,Default,,0,0,0,,- Test 1.\\N- Test 2.\r\n' != '0,0,Default,,0,0,0,,- Test 1.\\N- Test 2.'
E       - Dialogue: 0,0:00:00.97,0:00:02.54,Default,,0,0,0,,- Test 1.\N- Test 2.
E       + 0,0,Default,,0,0,0,,- Test 1.\N- Test 2.

tests/test_subtitles.py:26: AssertionError
=================================== short test summary info ====================================
FAILED tests/test_subtitles.py::TestSubtitle::test_movtext - AssertionError: 'Dialogue: 0,0:00:00.97,0:00:02.54,Default,,0,0,0,,- Test 1.\\N- Test 2.\r\...

Investigation
As stated above, the failure seems to be caused by changes in ffmpeg. Replacing the assertion with the correct result should fix the issue.

How have you installed ffmpeg and what's the version?
When I test PyAV locally, test_subtitles.py passes on my machine, although test_file_probing.py and test_python_io.py fails.
platform darwin -- Python 3.12.0, pytest-7.4.3, pluggy-1.3.0
ffmpeg HEAD-84e400a_1 via Homebrew
FAILED tests/test_file_probing.py::TestVideoProbe::test_stream_probing - AssertionError: Fraction(25, 1) is not None
FAILED tests/test_file_probing.py::TestVideoProbeCorrupt::test_stream_probing - AssertionError: Fraction(25, 1) != None
FAILED tests/test_python_io.py::TestPythonIO::test_writing_to_custom_io_dash - av.error.InvalidDataError: [Errno<PHONE_NUMBER>] Invalid data found when processing input: 'custom_io_output.mpd'

This is not unexpected because i'm using HEAD ffmpeg (6.1) instead of 6.0 release.

Apologies for the confusion. I built from AUR and thought we were still on ffmpeg-4.4. Didn't even check the build script about that.
Apparently ffmpeg-6.0 behaves differently. The commits I referred to either were unrelated or won't affect the tests.
I just tested again on the ffmpeg-6.1 (release, not HEAD). Interestingly, I had the same two errors in test_file_probing.py, but test_python_io.py passed.
Closing this issue. Again sorry for the trouble!


Provide more terse Debug implementation for keys.

KeyData and containing types like DefaultKey derive a Debug implementation. This allows keys to be printed, but includes superfluous text. For example, a DefaultKey may be printed as DefaultKey(KeyData { idx: 0, version: 1 }).
This change provides a custom Debug implementation for KeyData that prints 0v1 instead. For containing key types like DefaultKey, the output looks like DefaultKey(0v1).
This change also introduces an into_key_data function on generated key types. This allows user code to more easily extract KeyData for debugging purposes. For example, this could be used for Debug implementations for downstream key abstractions.

I don't particularly see the reason for into_key_data. I think KeyData::from(key) or just key.into() when type inference allows it is sufficient. Please update your pull request to remove that and I'll accept the pull request.

Please update your pull request to remove that and I'll accept it.

Sounds good to me. I've removed into_key_data. Let me know if you'd like me to squash the commits.


Introduce exponential back off for rate-limited API calls

Builderator can fail builds if it receives a rate-limited exception while checking an AMI's copy status. We need to catch these exceptions and follow Amazon's recommendation of introducing exponential back off before retrying.

@dgreene-r7 Backoff on describe_images was added in #107, are there more apis that need this?

Nope! We just need to update the version our jobs are using. Derp!