Fix unit tests

Fix unit tests after removing fdescribes.

Codecov Report

Merging #4037 into master will increase coverage by 11.02%.
The diff coverage is 74.43%.

@@             Coverage Diff             @@
##           master    #4037       +/-   ##
===========================================
+ Coverage    52.2%   63.22%   +11.02%
===========================================
  Files         868      998      +130
  Lines       29254    32074     +2820
  Branches     4297     4519      +222
===========================================
+ Hits        15271    20279     +5008
+ Misses      13983    11795     -2188

Ooops


[a11y] Adding aria role to alerts

• Adding an aria role of "alert" to the clr-alert component
• Also added unit test to make sure they are there
Tested in:
✔ Chrome
Closes: #2582
Signed-off-by: Scott Mathis<EMAIL_ADDRESS>

Once this is merged into master, I can backport to 0.13, 0.12, and 0.11.
I will submit changes for the website as well to document best practices in latest documentation.


Codes not being generated correctly

Hey,
probably this is an issue on my end, but I didnt find a discussion forum here.
I try to generate codes, but the codes dont seem to be correct. I think it is related to any time zone issues or something. I am located in germany, means UTC+1, and I use the following code to generate the codes:
String code1 = totp.now(Clock.system(TimeZone.getTimeZone("UTC+1").toZoneId()));
It then generates a code, but when I try to verify it it fails.
E.g. current codes are (the second one is with 30 seconds delay):

But correct one would be:

Do you have any ideas on that?
Thanks!

The issue seems to be with SHA1 and SHA512. SHA1 is deprecated, so I went to SHA512. But e.g. the Microsoft Authenticator uses SHA1 although the URL says otpauth://totp/test?period=30&digits=6&secret=XSWRT4OXZSTURKQXSFFTMYII55ITYK2Z&issuer=test&algorithm=SHA512


Introduce permit/forbid attributes matchers

Add permit_attribute and permit_attributes to match actions API and deprecates *_mass_assignment_of which will be removed in the next major version of Pundit Matchers
Close #94

There is only a caveat, I don't know if it is worth to document it
In order to test if a nested attribute is assignable, permitted attribute can also accept a hash, and inside a hash you can insert multiple attributes. Checking the number of parameters sent to the matcher is possible but not trivial, what should we do?

Also, should the description be mass assignment of?

For permit_attribute, accepting a single attribute (without children) would be the use case. If checking an attribute with children, we should require that permit_attributes is used since we are testing more than one attribute.

I've created another beta for 3.0. I'd like to get that stable and released first to avoid scope creep, but we can release this soon after as 3.1.

Rebased on main, updated changelog, bumped up version number to 3.1.0

Also, should the description be mass assignment of?

The code looks good. We should change the Readme section titles to reflect new naming, e.g.

Testing if an Attribute is Authorised
Testing if Multiple Attributes are Authorised
Testing if Attributes are Authorised for Particular Actions

I also think we should demonstrate the permit_mass_assignment_of syntax as an alternative at the bottom of each of these three sections, similar to the "The following examples are equivalent" section for forbid_actions.


what is time release the code?

+1

No description provided.

Thanks for your interest! We are cleaning up the code and will release it in a few days.

Very nice work, interested in the MMC part of the paper, looking forward to your code

+1

No description provided.

Thanks for your interest! We are cleaning up the code and will release it in a few days.

How long will it take approximately


push_constant struct not decompiled correctly

Hi All,
I'm using the latest commit 1ae2b58 of SPIRV-Cross, as well as the VulkanSDK <IP_ADDRESS>
If my shader contains the following snippet:
layout(push_constant) uniform PushConstants {     mat4 projection;     mat4 modelview; } pc;
and I compile it via the glslangValidator to the .spv format and decompile it again, it results in:
`struct PushConstants
{
mat4 projection;
mat4 modelview;
};
uniform PushConstants pc;
`
Which is not the correct decompilation, since non-opaque uniforms outside a block are not allowed when using GLSL for Vulkan. The decompiled code cannot be compiled again.

By default, spirv-cross targets GL semantics, which does not support push_constants, and the closest analog is plain uniforms. Try --vulkan-semantics or its alias -V and it will compile back again to push constants.


Prefer mono.map over mono.flatMap(x -> Mono.just())

Based on a suggestion from here.
Adds a Refaster template to prefer mono.map(x -> valueTransformation(x)) over the mono.flatMap(x -> Mono.just(valueTransformation(x)))
This avoids an unnecessary inner inner subscription.

Thanks @Stephan202  for the changes!


Fix placement connection failures

Description

Note: Placement and its connection code in runtime do not have enough tests. This PR doesn't include the test to focus on the existing issues. Once this PR is merged, I will make the code testable and add unit-tests in the next PR.

This PR includes multiple fixes:

In self-host mode, actor cannot be discovered if multiple actor service dapr instances run because placement uses only ip address as a unique host.name -> Use IP:Port as host.name to distinguish the actor service instances which use the same ip address.
When the connection between dapr and placement is down, receiver loop and sender loop are trying to reconnect new grpc stream. It will establish duplicated stream channels. reconnection needs to happen in the single place to avoid this duplicated connections.
Unnecessary send/retrieve retries -> use grpc.WithBlock() option and connection liveness flag to avoid the unnecessary retries.
In ReportDaprStatus(), using context.Done() may skip member removal step -> remove switch case and check the connection status only with stream.recv() error response to ensure that placement removes member from host list.
Add table version to the log
Add /healthz endpoint to actorload stateactor service.

Issue reference
#1732
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

I plan to refactor the code and add unit-test later. but I have to do it now :) @yaron2 This focuses on the issue fix. but I will create new PR to make the code testable and add more test.

I plan to refactor the code and add unit-test later. but I have to do it now because of codecov :) @yaron2 This focuses on the issue fix. but I will create new PR to make the code testable and add more test.

@yaron2 @wcs1only / I tried to refactor the code with the unit-test, but I may not have a time to finish and validate it again. this change has been validated by @KaiWalter
https://github.com/dapr/dapr/issues/1732#issuecomment-697434814
in 0.12.0 milestone, I will bring the better fix to address the problems in our load test.


documentation to import harbor_config_auth  is missing

I cannot find the documentation to import harbor_config_auth even though it's mentioned in this issue #360 that it was implemented.
Could you please point me to the documentation or add one if it doesn't exist?
Thanks in advance!

hi @nafaa-tayachi,
something like this should work :
terraform import harbor_config_auth.my_conf /configurations
indeed there is no documentation, I will update it

thanks for the quick reply @flbla !
I wasn't able to import it using the command you shared .. does it require some kind of suffix after /configurations/${name/id/whatever}
if yes what should it be?

no, there is no name/id, because there is only one endpoint for configurations
can you copy the error you get?
I'll try to take a look at it this week

I tried to reproduce but was not able to :
resource "harbor_config_auth" "db" {
  auth_mode          = "db_auth"
}

If I 1rst try to plan it :
  # harbor_config_auth.db will be created
  + resource "harbor_config_auth" "db" {
      + auth_mode             = "db_auth"
      + id                    = (known after apply)
      + ldap_group_membership = "memberof"
      + ldap_group_scope      = "subtree"
      + ldap_scope            = "subtree"
      + ldap_verify_cert      = false
      + primary_auth_mode     = false
    }

Then I do the import command :
terraform import harbor_config_auth.db /configurations
harbor_config_auth.db: Importing from ID "/configurations"...
harbor_config_auth.db: Import prepared!
  Prepared harbor_config_auth for import
harbor_config_auth.db: Refreshing state... [id=/configurations]

Import successful!

The resources that were imported are shown above. These resources are now in
your Terraform state and will henceforth be managed by Terraform.

Try to plan again :
  # harbor_config_auth.db will be updated in-place
  ~ resource "harbor_config_auth" "db" {
        id                    = "/configurations"
      + ldap_group_membership = "memberof"
      + ldap_group_scope      = "subtree"
      + ldap_scope            = "subtree"
      + ldap_verify_cert      = false
        # (2 unchanged attributes hidden)
    }

Looks good (except the update on ldap, as I'm doing a DB auth it should not display, I'll try to check why)
Does the user you configured on the harbor terraform provider is an admin user ?

Hi @flbla , I am using a robot account, what kind of permissions does robot account needs to manage the auth configuration?

hi @nafaa-tayachi,
I think it's not possible to manage the auth configuration with a robot account
can you add your use case here : https://github.com/goharbor/harbor/issues/20076 ?

I just posted my case there. I was able to import the resource using an admin user.
thanks @flbla!


[bug]: .embassy names do not resolve [033 pi]

Prerequisites

[X] I have searched for existing issues that already report this problem.

embassyOS Version
0.3.3
Device
Laptop/Desktop
Device OS
Linux
Device OS Version
5
Browser
Firefox
Browser Version
108.0.1
Current Behavior
On a 4GB Embassy One, I installed FileBrowser and the latest Syncthing (1.23) from the beta marketplace.
The Syncthing Health check spins forever saying the health check has never run.  Apparently this is because its health check script is failing to resolve syncthing.embassy.
root@embassy-b9e3aba4:~# docker ps|grep syncthing
6171daa2bdae   start9/syncthing/main:1.23.0        "tini entrypoint.sh"     13 hours ago   Up 13 hours   8384/tcp, 8384/udp, 22000/tcp, 22000/udp   syncthing.embassy
root@embassy-b9e3aba4:~# curl -svk https://syncthing.embassy:8384
* Could not resolve host: syncthing.embassy
* Closing connection 0

It seems this points to an issue with systemd-resolved:
root@embassy-b9e3aba4:~# dig syncthing.embassy

; <<>> DiG 9.16.33-Debian <<>> syncthing.embassy
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 24081
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SECTION:
;syncthing.embassy.						IN	A

;; ANSWER SECTION:
embassy-b9e3aba4.local.	0	IN	A	<IP_ADDRESS>
embassy-b9e3aba4.local.	0	IN	A	<IP_ADDRESS>
embassy-b9e3aba4.local.	0	IN	A	<IP_ADDRESS>

;; Query time: 3 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Tue Jan 10 18:17:42 UTC 2023
;; MSG SIZE  rcvd: 99

Expected Behavior
.embassy should resolve
Steps to Reproduce
dig does not return A records for .embassy
Anything else?
No response

This is still happening and I'll leave the box up in case you would like me to do anything.
				IN	A

;; ANSWER SECTION:
electrs.embassy.	0	IN	A	<IP_ADDRESS>

;; Query time: 43 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Thu Jan 12 01:50:14 UTC 2023
;; MSG SIZE  rcvd: 49

A build + boot + Recover + Use existing drive of the latest master seems to have alleviated this issue.  Could be a fluke since I didn't seem to be having this problem until a week ago, but it was persistent until I just built and flashed that latest master build.  Closing...


Add cosigner url field to CreateAccountMultiSigRequest

We want the user to specify the URL of the cosigner to interact with when managing a mutisig account.

I think it a duty of the asset issuer to decide for his own asset which cosigner(s) to enable for their assets


Feat/yield

added tests

Great work! Looks good to me

I think here are the last steps to get the remaining stuff done. @zgorizzo69 . hope this makes sense and its not much work for you. 🙏

[ ] move packages/contracts/yield-aggregator/contracts into packages/contracts/src/yield-aggregator. If you just move them, there could be some conflicts in interfaces contracts. I hope you should be able to handle them
[ ] move packages/contracts/yield-aggregator/test into packages/contracts/test/yield-aggregator. that would be great to fix interface/mock contract duplication issue
[ ] Remove packages/contracts/dollar directory
[ ] Remove packages/contracts/yield-aggregator directory


Partially fix CC entry size reported in build operations

Fixes https://github.com/gradle/gradle/issues/30798
The fix is "partial" with respect to being able to report the full size of the CC entry that is possible to find on disk. However, the fix should be "complete" with respect to restoring the previous behavior (before the per-project and deduplication files were split out).
More specifically, there are a number of files that are added to the CC entry at the end of the build, which is much later than the current "CC store" build operation is issued. The files are: entry.bin, buildfingerprint.bin, projectfingerprint.bin. These files are written (or moved in) into the entry directory at the time of committing the CC entry -- at the end of the build. Their size does not seem to be too large in practice, but they introduce a discrepancy between the build-operation reported size and what the users can find on disk, if they summed up the actual size of files.
Eventually, we would want to report the complete size.

Opened https://github.com/gradle/gradle/issues/30809

@wolfs, thanks for the reminder. I added an explanation to the PR description. I hope that clarifies it.


Standard deviation aggregation

The aggregation over time in the repo seems to be only mean aggregation, instead of both mean and std aggregation as stated in the paper. Did I miss anything there? Thanks.
https://github.com/facebookresearch/efm3d/blob/3e02fd8f4870260f2d0246e54edbd691170e32a6/efm3d/model/lifter.py#L379-L396

Hi @iammarvelous the model we released is not exactly the same model config used to run the eval results in the paper. Your understanding is correct. The released code use mean aggregation instead of mean_std in the paper.


webpack errors out of the box

Been trying to make the AureliaSpa work for a while now with different methods but none seem to work out of the box. This was one of those tries:

node v6.11.0
npm 3.10.10

(clean directory)
PS# npm install -g yo generator-aspnetcore-spa
PS# yo aspnetcore-spa

framework -> Aurelia

Everything seems to go fine until it calls webpack (the second step, vendor config seems to run fine):
    ERROR in e:/code/todo/~/bootstrap/dist/fonts/glyphicons-halflings-regular.eot
    Module parse failed: e:\code\todo\node_modules\bootstrap\dist\fonts\glyphicons-halflings-regular.eot Unexpected character '�' (1:0)
    You may need an appropriate loader to handle this file type.
    (Source code omitted for this binary file)
     @ e:/code/todo/~/bootstrap/dist/css/bootstrap.css 6:4445-4497 6:4520-4572
     @ e:/code/todo/ClientApp/boot.ts
     @ e:/code/todo/~/aurelia-webpack-plugin/dist/aurelia-entry.js
     @ multi aurelia-webpack-plugin/dist/aurelia-entry aurelia-polyfills aurelia-loader-webpack aurelia-bootstrapper

This x4 for bootstrap fonts: .eot, .woff2, .woff, and .ttf files.
All the methods I tried, including dotnet new, ended up with this error. Executing dotnet run will give similar errors on the browser console, both in development and production modes.
Any clue on what's going on and what I can try to fix this?

Figured out how to run it. See the "e:/code...." path in the error? I'm actually running on "c:/code" which is a junction to e:/code. (my e: drive is much faster).
Running from e: (after cleaning up the dist directory) makes everything run properly.
I'll close this issue as I doubt it has to do with JavaScriptServices but any tip on which project the actual bug is in order for me to report it?


Fixing FIXME issues in ClusterStateConfig

Pull Request
Title
Code improvements in ClusterStateConfig to address FIXME issues identified by formatters and pylinters

Description
Add proper exception handling and add more tests

Issue link: (optional) Link the relevant issue number or GitHub Issue link if applicable (e.g., #123).

Type of Change

🔄 Refactor
🧪 Tests

Testing
Unit tests

Codecov Report
Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (9ebe0a6) to head (db9628e).

Files with missing lines
Patch %
Lines

...ender/cluster_state_provider/ClusterStateConfig.py
53.33%
5 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   77.16%   77.65%   +0.48%
==========================================
  Files          24       24
  Lines        1073     1083      +10
  Branches      135      137       +2
==========================================
+ Hits          828      841      +13
+ Misses        194      190       -4
- Partials       51       52       +1

Flag
Coverage Δ

unittests
77.65% <53.33%> (+0.48%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bcrypt and Babel dependencies

Why the Build (Docker) is going well without them when they are required for development ?

because you don't have it on your mac, bizut !


Remove race condition from socket input that could stall reads

Also remove flakiness from tests that are closed forcefully from the server

:ship:

Merge from the slopes!


上传json格式的材料有问题

应该是前端页面的方法有问题

Hello～ 可否提供下问题的详细内容呢～
烦请提供 “期望 Behavior” 与 “实际 Behavior”～

Issue has been closed due to inactivity. Please feel free to re-open when needed.


ParameterlessEndpoint keeps being unitialized

Hi, when I use a parameterless endpoint, it doesn't initialize. Using Endpoint instead, with an argument that doesn't get used fixes the issue for now, but is of course not the way this should be done.
My API implementation:
`
public class Api
{
private readonly ILoggingBroker loggingBroker;
private readonly IUserViewService userViewService;
public Api(ILoggingBroker loggingBroker, IUserViewService userViewService)
{
    this.loggingBroker = loggingBroker;
    this.userViewService = userViewService;

    var defaultOptions = new EndpointOptions()
    {
        DefaultStaleTime = TimeSpan.FromSeconds(60),
        RetryHandler = RetryHandler.Simple(1),
        OnFailure = e => Console.WriteLine(e.Exception.StackTrace),
    };

    GetUserViews = new(
        async (cancellationToken) => (await this.userViewService.RetrieveAllUsersAsync()),
        options: defaultOptions
    );
}

public ParameterlessEndpoint<IEnumerable<UserView>> GetUserViews { get; }

`
My component:
`
@inject Api Api;

Users retrieved

<Condition Evaluation="@(query.IsLoading)">
    <Match>

Loading...

    </Match>
</Condition>

<Condition Evaluation="@(query.IsError)">
    <Match>

@query.Error?.Message

    </Match>
</Condition>

Query: @query

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Uninitialized: @query.IsUninitialized

@code {
}
`

I think you missed some of your component code in the description (e.g. where is "query" defined?) so I can't tell exactly what's going on, but:

If you're creating the query with endpoint.Use(...), you'll need to explicitly call query.Fetch() to make it initialize. This is by design (to enable use-cases where people don't want it to fetch immediately), but I agree that it's not the most intuitive.
If you're using <UseEndpoint/>, you should replace it with <UseParameterlessEndpoint/>, which will fetch it automatically without needing an Arg.

I'll definitely make sure to update the doc comment for the ParameterlessEndpoint.Use() so that this is more clear, and maybe consider changing the default behaviour in the next update. It actually used to initialize by default until I decided it was cleaner not to, but the library has changed a lot since then.

Also a very tiny note which is unrelated to this issue:
Since you're not using the CancellationToken, you can replace
    GetUserViews = new(
        async (cancellationToken) => (await this.userViewService.RetrieveAllUsersAsync()),
        options: defaultOptions
    );

with
    GetUserViews = new(
        userViewService.RetrieveAllUsersAsync,
        options: defaultOptions
    );

which is functionally equivalent.

Hi Jcparkyn,
I was using <UseEndpoint /> instead of <UseParameterlessEndpoint />, so that's where I went wrong. Would be nice to see that explained more clearly in the documentation.
Thanks for your help!


Add from to EthereumCall object passed to handlers

The EthereumCall object passed to handlers does not include a property for the sender of the call.

https://github.com/graphprotocol/graph-ts/pull/66
https://github.com/graphprotocol/graph-node/pull/976


Trouble with javascript map on a Sprig request

Support Request
I have a Sprig component where you can switch between views -- one of which is a map, using Leaflet.js:
{% set selectedView = selectedView ?? 'list' %}

<button sprig s-val:selectedView="list" s-replace="#swapThis">List View</button>
<button sprig s-val:selectedView="map" s-replace="#swapThis">Map View</button>

  {% if selectedView == 'list' %}
    List View
  {% endif %}

  {% if selectedView == 'map' %}
    {% css<EMAIL_ADDRESS>%}

  {% endif %}

This works fine is map is the default view (therefore, the first sprig request). However, if my other view is the first one loaded, and I switch to the map view, the map doesn't load. It obviously feels like an order problem...but I'm not sure how to correct it. Per the docs, I've tried various htmx events (most of the after~ ones) but no luck so far.
Do you have any thoughts on what I could try?
Plugin Version
3.0.2

As per the docs at https://putyourlightson.com/plugins/sprig#s-val

Since HTML attributes are case-insensitive, the name should always be lower-case and in kebab-case.

So you should be using s-val:selected-view=. Does that solve it for you?

Ah, that was probably just my attempts to simplify the code. Confirmed that doesn't make a difference here.

Ok it seems like it's just a timing thing...? Wrapping the var map part in setTimeout(function() {...}, 500) works......kind of. The map is loaded but it's broken and displays like this for some reason:

It feels like that part might be crossing into Leaflet support territory, but is there something better I could be doing with HTMX to only load  after a couple of seconds?

Got it working! I had to move the CSS into my base layout template -- it wasn't being loaded properly otherwise. Then I did this:


Possible memory leak in sqlite3MemMalloc (node-v11-linux-arm, maybe others)

While valgrinding our app, we found a possible leak:
==16916== 69,504 bytes in 53 blocks are possibly lost in loss record 117 of 120
==16916==    at 0x480D014: malloc (vg_replace_malloc.c:291)
==16916==    by 0x4F52843: sqlite3MemMalloc (in .../node_modules/sqlite3/lib/binding/node-v11-linux-arm/node_sqlite3.node)

Thoughts? Actual leak here? I'll be characterizing this a little more.

I'm trying to figure out how sqlite3MemMalloc gets pulled in... not source in this repo.

Can you provide a reduced testcase to replicate?

Yeah, let me mod an existing test and get a little more specific. I found out it's a one time leak, so I don't think it's a big issue at all. Just would be a code clean thing.

Closing as the issue is stale but welcome any memory issues in the future 🙂


Addon Name

Addon Manifest URL
https://google.com/
Addon Description
testing publishing
Language of Content
Albanian (sq-AL)
Choose labels

[X] anime
[ ] debrid support
[ ] http streams
[ ] live tv
[ ] metadata
[X] misc
[ ] movies
[X] music
[ ] nsfw
[ ] radios
[ ] subtitles
[ ] torrents
[ ] tv shows
[ ] video games

This was just for testing


Removed Lessons and Quizzes from the header in the Dashboard page

I removed the Lessons and Quizzes headers from the Dashboard page. I removed lines 86 to 91 from the base.html file.
This is how the Dashboard looks now:

@zgarada please add Leaderboard as one of the links on the header, also resolve current conflicts

Hi Zain there’s a conflict so try and reso,ve it and we can merge after


Support regenerate-certs command from docker-machine

Having a docker-machine VM running messes up dinghy. DHCP will give a new IP to dinghy and the certs are only valid for <IP_ADDRESS>. So docker-machine regenerate-certs <machine name> is what you run to work around it in docker-machine. Can the same thing be supported in dinghy?

Since dingy is on top of docker-machine I could issue docker-machine regenerate-certs dinghy and dinghy restart and I was back. Maybe document this?

I had that happen once just restarting the dinghy VM too, without any other VM in docker-machine. I think the real fix needs to come from docker-machine (maybe just regenerate automatically when necessary on VM start?) but adding it to the docs for now seems like a good plan.

This has been merged in and released, thanks again

Whoops correction, merged but not released to latest quite yet, my bad

It does not seem that command exist?

@kevinsimper Which command do you mean?

@michaellopez I just thought that dinghy would have all commands that docker-machine had, but I see it now!


obtaining ScJwtToken

Hello, thank you for this repo!
I am not receiving all cookies during the last authentication step and only receiving dtCookie. Have you seen this before? any tips?

I'll check into this and let you know

Couple of questions:

What company is your account from

Is the library throwing any errors?  Do you have any logs?

Sorry, to be clear, I got it working in node, running into the issue in python.
Would you have any guidance there? I know this isn't the proper place for the question but there is no other way to reach out to you. Thanks again, either way.

No worries, the more libraries the better.
Just to get it out of the way, this is an unofficial API and is derived from how the website gets it data.
Do you have any source code?  Normally if you aren't getting the correct cookie then the server isn't receiving the correct data or you're posting to the wrong url.
The auth code was updated a couple months ago but I'm not sure if the readme's explanation has been updated to match.

Also just for awareness, I am looking to obtain the https://customerservice2api.southerncompany.com/api/Billing/getAllBills data as my client oversees and pays for a whole apartment building. If I get it working properly for node, I will fork your repo and add it for your approval.
As for python, I will clean up the code and get it posted publicly, then share it with you. It will be a single script though, not a python library at this time.
PS: just FYI, in your readme URL /LogginValidated/JwtToken
has a typo with too many g's.

Sounds good!
I've been testing and it looks like that url should just work once you get the Authorization header with the JWT in place.   This should be pretty easy to integrate into the current library, just never ran into that url in my web interface.  Thank you :)
Thanks for the heads up.  The readme was actually correct but SoCo corrected their API typo and I corrected the typo in the code just not the readme.

Yeah I just got it working, but in my case it is a lot of data so I may leave the function call commented out in main.js. I also added a line to download the json which is what i need.
I will try to fork your repo tonight and add it. Thanks again.

Merged PR! Thanks!


Information Security and Quality Assurance Certification always shows today's date

related: #18128

HOOK ME UP

@METALMAN01 If you're asking for this to be assigned to you, @ahmadabdolsaheb is already working on it. Feel free to have a look around on the other issues though!

@METALMAN01 thanks for your interest. I am working on a similar issue that might resolves this as well. If it did not, I will give you more context so you could work on this more efficiently.

Some users have this issue and some do not.
It is likely that the id of certification has been changed and the backend fails to find that record for  since it looks for the new id.

Thanks to @moT01 for investigation.
The issue might be caused because of the id change here.
https://github.com/freeCodeCamp/curriculum/commit/4c650a6d8544f56904a6a0a287df1465ee1d72e9#diff-83023cc91e4914f72a3af824e2bcc2e9L7

The issue seems to be non-existent. Please feel free to re-open this issue if anyone comes across an inaccurate date on an Information Security and Quality Assurance Certification.


URL checker gets thrown off by parantheses in a URL

I don't have a great solution for this problem right now. But the url checker doesn't handle it when URLs have parantheses.
https://github.com/jhudsl/Ethical_Data_Handling_for_Cancer_Research/pull/46#issuecomment-1481543211

@cansavvy this broken url is confusing me... I think it has to do with having parentheses in the url again... maybe this repo just needs updating?

Unfortunately the URL checker get thrown off if there are parantheses in the URL. I dont think the URL is actually broken. We can try to add it to ignore-urls.txt to have it ignored. I'll make sure that this is recorded as an issue on OTTR_Template.

Oh, I filed a similar issue in https://github.com/jhudsl/ottr-reports/issues/17 , although in my case I was trying to put the url inside parentheses.

Hey @howardbaek This is a problem that's been plaguing OTTR lately, we should chat about it. It would be great if you could look into a better solution for this.

See this example: https://github.com/jhudsl/Ethical_Data_Handling_for_Cancer_Research/blob/preview-46/check_reports/url_checks.tsv

For example: https://en.wikipedia.org/wiki/Cache_(computing fails because it has parantheses in it.

The change is going to need to be done in this script that is used by the ottr-reports: https://github.com/jhudsl/ottr-reports/blob/main/scripts/url-check.R
We need all ways of specifying URLs as discussed in https://github.com/jhudsl/OTTR_Template/blob/main/02-chapter_of_course.Rmd to be covered.
We want to only pull out the URL but not the other parts of the place we specified it.
Currently we try to pull the URLs from the markdown documents, but after the rendering happens we could also pull the URLs from there but that would mean switching the order of doing rendering first and then checking for URLs.
This might be fine but this would take a lot longer for some books that are big.

resolved by https://github.com/jhudsl/ottr-reports/pull/18

Sorry I couldn't get to this earlier! Glad to know its fixed.

Sorry I couldn't get to this earlier! Glad to know its fixed.

No worries! It had been on my todo list a very long time before that. But @avahoffman got it done!


Update requirements.txt

The lib markupsafe  has deprecated the method soft_unicode since 2.1.0. So 2.0.1 version is recommended.
It will cause the error below:
    from .debug import traceback_response
  File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/quart/debug.py", line 6, in <module>
    from jinja2 import Template
  File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/jinja2/__init__.py", line 12, in <module>
    from .environment import Environment
  File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/jinja2/environment.py", line 25, in <module>
    from .defaults import BLOCK_END_STRING
  File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/jinja2/defaults.py", line 3, in <module>
    from .filters import FILTERS as DEFAULT_FILTERS  # noqa: F401
  File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/jinja2/filters.py", line 13, in <module>
    from markupsafe import soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/ubuntu/anaconda3/lib/python3.8/site-packages/markupsafe/__init__.py)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I have signed the CLA. Thank you

I have signed the CLA. Thank you

thansk for your improvement.

There are some errors in ci, can you try to fix it. Thanks city you later commit.


DASH SAI objects getting appended multiple times to header file

DASH SAI generator: Every time "make sai" is run, the generator is appending duplicate objects to the _sai_object_key_entry_t union.
:~/DASH/dash-pipeline$ grep "sai_direction_lookup_entry_t" SAI/SAI/inc/saiobject.h
    sai_direction_lookup_entry_t direction_lookup_entry;
    sai_direction_lookup_entry_t direction_lookup_entry;
    sai_direction_lookup_entry_t direction_lookup_entry;

Subsequent build of vnet_out fails:
In file included from /SAI/SAI/inc/sai.h:48,

                 from vnet_out.cpp:5:

/SAI/SAI/inc/saiobject.h:122:34: error: redeclaration of 'sai_direction_lookup_entry_t _sai_object_key_entry_t::direction_lookup_entry'

  122 |     sai_direction_lookup_entry_t direction_lookup_entry;

      |                                  ^~~~~~~~~~~~~~~~~~~~~~

/SAI/SAI/inc/saiobject.h:95:34: note: previous declaration 'sai_direction_lookup_entry_t _sai_object_key_entry_t::direction_lookup_entry'

   95 |     sai_direction_lookup_entry_t direction_lookup_entry;

      |                                  ^~~~~~~~~~~~~~~~~~~~~~

Fixed by:
https://github.com/Azure/DASH/pull/149


2023 Santa Fe HEV support

To support 2023 Santa Fe HEV, add the following lines to values.py
transmission:
b'\xf1\x8795441-3D120\x00\xf1\x89E16\x00\x00\x00\x00\x00\x00\x00\xf1\x82TTM2H16SA3',
engine
b'\xf1\x87391312MTL0',

Please open a PR against master branch of comma.ai's openpilot to add support for your car. All merged PRs with openpilot will be brought over to sunnypilot.


 Need to add write-mode.

first of all i can make write mode for single images of mkdosfs disks. not hdd images....
Will with be enough to get you stated?


Rendering input with bootstrap but without wrapper

Useful when real field value specified indirectly:
f.form_group :user do
  f.email_field :email, wrapper: false
end

Hi, thanks for the PR! Bonus points for the included unit test. Awesome. 👍
I'm considering merging this but first I want to understand a little more about your use case. Could you give a more detailed example/explanation of why this new feature is useful?

@mattbrictson, I think this feature could be used to address issue 89.  Unless there's a better way to solve that issue.

I think this feature could be used to address issue 89

Good point!

@yevhene Could you update this PR with a CHANGELOG entry? Thanks!

@mattbrictson done

Hmm, looks like there are some test failures in Travis (above and beyond the known issue in #329).
E.g. https://travis-ci.org/bootstrap-ruby/rails-bootstrap-forms/jobs/229914661
  1) Failure:
BootstrapFormGroupTest#test_rendering_without_wrapper [/home/travis/build/bootstrap-ruby/rails-bootstrap-forms/test/bootstrap_form_group_test.rb:250]:
--- expected
+++ actual
@@ -1 +1 @@
-"<input class=\"form-control\" id=\"user_email\" name=\"user[email]\" type=\"text\"<EMAIL_ADDRESS>/>"
+"<input class=\"form-control\" type=\"text\"<EMAIL_ADDRESS>name=\"user[email]\" id=\"user_email\" />"

@yevhene Can you rebase on the latest master and also update your test to use assert_equivalent_xml instead of assert_equal? I think that should fix it.
Thanks for your help! 🙇

@mattbrictson done

@mattbrictson I don't understand what CI wants now.

Like I said, it is the known problem reported in #329. Don't worry about it! Thanks

Is there any plan to integrate this feature into the next version? It fits perfect to my issue :) ty

Thanks for bringing this to my attention. It sounds worthwhile. Apologies that we haven't merged it already. I will look into it and see what we can do.

Closing and re-opening to force a re-run of Travis.

Reopen to force Travis.

The Travis failure is fixed now.


Access to modal-trigger

How to access to modal-trigger within ready function?
$('.modal-trigger').leanModal({
      ready: function() { alert('Ready'); }
});

Could you explain this more? I'm not sure what you mean.

Maybe he want to pop up a modal when the DOM are ready? :confused:

I am sorry for this poor description (and my English) of what i want.
For example, there is modal-trigger:
Delete record #42

So, I want have access to this modal-trigger in ready-callback of modal.
$('.modal-trigger').leanModal({
    ready: function() {
        console.log('Are you sure want to delete record #' + $(modal).attr('data-id') + '?');
    }
});

I need something exactly like this through some access to the modal that can exactly be triggered, in  the likes of:
'''
$('.modal-trigger').leanModal({
  ready: function() { $(this).addClass('animated bounceOutLeft'); }, // Callback for Modal open
  complete: function() { $(this).addClass('animated bounceOutLeft'); } // Callback for Modal close
})

'''

@maziey93, I know how to get access to modal, but I need get access to modal-trigger.

Closed due inactivity, feel free to reopen it if it is still necessary.


Warning message at input parsing

Log a warning when the expected type of a the content of a column does not match the expectation.
Example of this is AccidentYear in CF,ACT,OP,SimpleImport:
Expected input of type int, if a double is provided the value is not parsed without any warning to the user.

A PR for this issue has been here #316 targeting a feature branch (ExternalStakeholderPostProd4) which will eventually be merged to main (and develop).


Adding Playlists derivative project

Updated lists.ts to add Playlists derivative project
Playlists
Etherscan link: https://etherscan.io/address/0xc9ff11b733fcc652bbbfde5cbdc46aea007197e5#writeContract
Website: https://playlists-for-adventurers.carrd.co/

Thanks for the PR! Small nit: could you shorten the description to make it fit on one like the others?

Thanks @Anish-Agnihotri, all done

Looks good. Thank you!


fatal.test.py autest: make it more reliable

The fatal.test.py test has been flaky because of a race condition between the process shutdown caused by TSFatal and the autest shutting down the process because the Default Process print statement finished. This patch adds a FileContaines ready condition for the TSFatal log message before ending the TestRun which makes it run correctly more reliably.

[approve ci autest]

On second thought, I'm just going to make one PR that fixes the related test inconsistency issues.


Fix browser native validation message

Fix for issue #4990
The problem was in css properties that prevents native browser validation bubble.
Tested in Safari, FF, Chrome on macOS.

So, we need MD guidance on this as we currently don't have any guidance on checkbox/radio error states. As it is, they simply shouldn't be shown at all and developers should find other UX ways to inform users about these problems.
As things are, the current behavior is what is expected. Even if unfortunate that developers need to do more work on their end. :frowning:

Since we don't have guidance from the team here I'm going to err on since this is not strictly defined we shouldn't make a decision on UX here.
If you want to show the native UX, these modifications can be applied in custom application code.
Therefore, this merge request won't be accepted. Thank you for your time.


server.crontab fails if there is no existing crontab

Describe the bug
If there is no existing crontab for the user on the host (e.g. someone ran crontab -r) then the server.crontab operation will fail.
To Reproduce
See above.
Expected behavior
I would expect a new crontab to be created with the specified job listing from the server.crontab operation.
Meta

Include output of pyinfra --support.

❯ pyinfra --support
--> Support information:

    If you are having issues with pyinfra or wish to make feature requests, please
    check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
    When adding an issue, be sure to include the following:

    System: Darwin
      Platform: macOS-10.14.6-x86_64-i386-64bit
      Release: 18.7.0
      Machine: x86_64
    pyinfra: v1.3.5
    Executable: /Users/----/.virtualenvs/05-hz-pyinfra-d0Faa_8y-py3.9/bin/pyinfra
    Python: 3.9.1 (CPython, Clang 10.0.1 (clang-1<IP_ADDRESS>))

How was pyinfra installed (source/pip)? Virtualenv via poetry

Thanks for spotting this @taranlu-houzz; it's a bug in the crontab fact that incorrectly errors when there is no existing crontab; fixed in https://github.com/Fizzadar/pyinfra/commit/77232297fc3bbce9c90ede3599863b3283a8d848 and released just now in v1.3.6 :)


@arco-plugins/vite-react is invalid

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>Framework version:  "@arco-plugins/vite-react": "^1.3.3",
Browser: chrome<IP_ADDRESS>

What is expected?
this is not increment dist/assets/ArcoDateRange.5d14a6ee.css        109.62 KiB / gzip: 12.99 KiB
Steps to reproduce
// ArcoDateComponent.tsx
import { DatePicker, RangePickerProps } from '@arco-design/web-react'

// https://vitejs.dev/config/
export default defineConfig(() => {
  return {
    plugins: [
      react({ fastRefresh: false }),
      vitePluginForArco({
        style: 'css',
      }),
    ],

    resolve: {

    },
    build: {
      // sourcemap: true,
      rollupOptions: {
        plugins: [
          process.env.Analyze === '1'
            ? visualizer({
                gzipSize: true,
              })
            : null,
        ].filter(Boolean),
      },
    },

  }
})

@vaynevayne Could you provide a full demo?

ArcoDateRange.5d14a6ee.css 109.62 KiB The file is too large. I thought it was a packaging problem. However, according to the extracted css file name, which has the same name as the component, it is inferred that the packaging is not a problem. This component css itself is 109.62kib.


Yes.
I created this GitHub account only to open this issue.
Please use Jax or Pytorch or anything else. Don't use Tensorflow.
Don't report me. Don't mad at me. Don't ask me why.
Because I don't want to talk about it anymore.
I. FUCKING. HATE.  HATE. BITCHES. LIKE. YOU.

I'm sorry you feel about Tensorflow this way, but that doesn't mean you can open an issue and just trashtalk Tensorflow.

I. FUCKING. HATE. BITCHES. LIKE. YOU.

ok boomer

I. FUCKING. HATE. BITCHES. LIKE. YOU.

ok boomer

I believe you miss understand.   Yes.  I created this GitHub account only to open this issue. Please use Jax or Pytorch or anything else. Don't use Tensorflow. Don't report me. Don't mad at me. Don't ask me why. Because I don't want to talk about it anymore.
I. FUCKING. HATE. TENSOR-FUCKING-FLOW.

This man is exceedingly based

The type of people who can't afford a GPU lmaooo

Don't ask me why. Because I don't want to talk about it anymore.

very constructive :D

When and why are you so mad at TensorFlow? Installing it?

thanks for the feedback LGTM 👍

Ë

Why though?

I. FUCKING. HATE. BITCHES. LIKE. YOU.

ok boomer

I believe you miss understand.   I think this is going viral on twitter, you can only expect more inane comments

See https://www.reddit.com/r/ProgrammerHumor/comments/rpkxg2/an_honest_guy/ for some explanation

based


[WIP] next: Add auth handlers test

connect #686

Using mockgen for all the dependencies makes the test of handlers less meaningful. I am going to update some mock dependencies with minimal implementation (e.g. using in memory map for store) like v1.

Agree. I think we need to write down what category of provider/services should:

mock
testing implementation
fixture with real implementation

@rickmak @Steven-Chan Updated! Since we migrated more handlers now, here only includes some of the handlers. I can help add more test after this is merged.


Article added for Circular Linked list

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
(Write your answer here.)
Checklist

[ ] I've read the contribution guidelines.
[ ] I've checked the issue list before deciding what to submit.
[ ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes : #74

@HarshCasper I have made the changes. Please review.


Inconsistent font rendering

Issue Type: Bug

Create new Jupyter notebook
Create Markdown cell
Enter in the cell:

This is default Markdown text.
#### Heading 4
### Heading 3
## Heading 2
# Heading 1

Observe ginormous headings.

Extension version: 2022.1.1001614873
VS Code version: Code - Insiders 1.64.0-insider (23664355e61f3fb614932a5cb16613b4d987cfb7, 2022-01-21T13:26:52.572Z)
OS version: Linux x64 5.13.0-25-generic
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1500)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.22GB (0.95GB free)

Process Argv
--unity-launch --crash-reporter-id 2273c5d1-5f55-44d1-afd8-13c81c1bf0ca

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

For comparison, this is how the Markdown preview extension renders the headings:

And here is how Google Colab renders them:

Notice that Heading 4 is nearly identical to the default text size. Whereas, Jupyter renders Heading 4 significantly larger.
Even further, notice how github renders Heading 4 below:
Heading 4

This is what I am seeing with Markdown preview for Heading 3 and Heading 4. The extension is keeping the default font sizes set by the browser.

Jupyter notebook on the other hand forces weird sizes. Why?
This seems to be the commit responsible for it: https://github.com/microsoft/vscode/commit/d1f2d0a7296a4747fe1ba4c3b01633e78392b15e

From https://github.com/microsoft/vscode/issues/105900, it looks like they are tweaked mostly to keep consistent within the notebook markdown renderer.
Is the issue that it doesn't look the same as other renderers?

@amunger yes they look too big and inconsistent with (1) Markdown Preview extension, (2) Google Colab, (3) Jupyter, (4) GitHub, etc. See comparison in the beginning of the issue (1st and 2nd comments).
The complaint in https://github.com/microsoft/vscode/issues/105900 was that the headers were bold and had nothing to do with the size.

FWIW, haxxoring the following file fixes the sizes so that they match the rest of the world:
dimitry@linux:~$ diff -u /usr/share/code-insiders/resources/app/extensions/markdown-language-features/notebook-out/index.js{.orig,}
--- /usr/share/code-insiders/resources/app/extensions/markdown-language-features/notebook-out/index.js.orig	2022-01-21 19:13:23.050386852 -0500
+++ /usr/share/code-insiders/resources/app/extensions/markdown-language-features/notebook-out/index.js	2022-01-21 20:00:17.911510199 -0500
@@ -48,37 +48,7 @@
 			border-bottom: 2px solid;
 		}

-		h2, h3, h4, h5, h6 {
-			font-weight: normal;
-		}
-
-		h1 {
-			font-size: 2.3em;
-		}
-
-		h2 {
-			font-size: 2em;
-		}
-
-		h3 {
-			font-size: 1.7em;
-		}
-
-		h3 {
-			font-size: 1.5em;
-		}
-
-		h4 {
-			font-size: 1.3em;
-		}
-
-		h5 {
-			font-size: 1.2em;
-		}
-
-		h1,
-		h2,
-		h3 {
+		h1, h2, h3, h4, h5, h6 {
 			font-weight: normal;
 		}

Here is an actual patch to fix it in source:
From 70639788a864fac58a85674aeb979fb4ecb1e8fd Mon Sep 17 00:00:00 2001
From: Dimitry Ishenko<EMAIL_ADDRESS>Date: Fri, 21 Jan 2022 23:11:17 -0500
Subject: [PATCH] Fix Jupyter notebook header sizes

---
 .../notebook/index.ts                         | 32 +------------------
 1 file changed, 1 insertion(+), 31 deletions(-)

diff --git a/extensions/markdown-language-features/notebook/index.ts b/extensions/markdown-language-features/notebook/index.ts
index fe25756c0ea..57c88733b19 100644
--- a/extensions/markdown-language-features/notebook/index.ts
+++ b/extensions/markdown-language-features/notebook/index.ts
@@ -62,37 +62,7 @@ export const activate: ActivationFunction<void> = (ctx) => {
 			border-bottom: 2px solid;
 		}

-		h2, h3, h4, h5, h6 {
-			font-weight: normal;
-		}
-
-		h1 {
-			font-size: 2.3em;
-		}
-
-		h2 {
-			font-size: 2em;
-		}
-
-		h3 {
-			font-size: 1.7em;
-		}
-
-		h3 {
-			font-size: 1.5em;
-		}
-
-		h4 {
-			font-size: 1.3em;
-		}
-
-		h5 {
-			font-size: 1.2em;
-		}
-
-		h1,
-		h2,
-		h3 {
+		h1, h2, h3, h4, h5, h6 {
 			font-weight: normal;
 		}

--
2.32.0


o with no filename given is waiting for data on stdin

I have installed o using the go install command, but if I'm trying to run it using $ o command nothing happens. What I'm doing wrong or what I'm missing?

The issue is that it waits for input on stdin. This is a bug. Thanks for reporting!

It's fixed in main now. :+1:

I have updated to the latest code base, but the editor is still not showing up. I have tried also to build it directly.

If I'm running the project without building it I'm getting an error message that I should provide a file. So this means that the editor is not opening without a provided file? I would expect this message to show up even in the case of running the executable.

Is this the same result as you get?

Exactly.

Currently the editor is single-file only,

Thanks for the clarification. Maybe this information could be specified explicitly in the README file.

Sure, now it's mentioned in the README.
Out of curiosity, what type of workflow needs many files to be open in one editor, as opposed to opening many files in many instances of an editor?


Doesn't work, it hangs up

When I give the link, I write snapchat-dl “https://story.snapchat.com/s/ story I want.
In the output it says that this following user has, for example, 10 stories.  After that no more happens.  Neither the program reports nor the terminal aborts the process.  Also the option with "-c".  It says there that this user suddenly has no more stories ?!
I also had difficulty finding the program after "pip3 install snapchat-dl", because it was not in / usr / local / bin but in /Library/Frameworks/Python.framework/Versions/3.6/bin/snapchat-dl.
Even if it has a few bugs it is still a great program, especially because I don't have to keep entering python3 snapchat-dl, but it runs as cleanly as "youtube-dl". The parameters are also kept very nice.
Do you think it is also possible to download the story from private people by logging into your account?

Currently single story download is not implemented, you need to supply username to download available stories. (e.g. snapchat-dl <username>)
Use --user flag on unix to install the package
-c options scans clipboard for valid username and attempts to download stories

Currently single story download is not implemented, you need to supply username to download available stories. (e.g. snapchat-dl <username>)
Use --user flag on unix to install the package
-c options scans clipboard for valid username and attempts to download stories

Now I see that it really works with usernames. Apparently it doesn't support a single story yet, unfortunately I wasn't aware of that.
Thank you for your helpful answer.
Hope you will add private story downloading later, I would definitely assist you. Unfortunately, that should be very difficult

Now I see that it really works with usernames. Apparently it doesn't support a single story yet, unfortunately I wasn't aware of that.
Thank you for your helpful answer.
Hope you will add private story downloading later, I would definitely assist you. Unfortunately, that should be very difficult

Hello it's me again.  I didn't want to create another problem.  It's been almost a year now and I love snapchat-dl and use it every day.  But I need support for private accounts.  Please insert that in the code and as a thank you I'll send you $ 10 in BTC.  Greetings and stay healthy

@UnixCro Thank you for using snapchat-dl, currently, exploring Snapchat's private API would require a considerable amount of time and effort. Will keep you posted on any progress related to this.


migrate Bot command API to GraphQL

In order to register, update, delete, and perform other actions to slash commands the Bot is required to authenticate and call the Discord API. Currently functionality is added and attached to /api/commands as separate routes, however this would be better suited for GraphQL for ease of use and versatility.

Will be closing in favor of the migration to an Express-based handler for the existing REST API


DeviantArt downloader and ArtStation downloader malfunctions

Ripme version: 1.7.86
Java version: 1.8.0_211
Operating system: 6.1.7601
Exact URL you were trying to rip when the problem occurred: Multiple, listed below, may contain NSFW images

https://www.deviantart.com/ralphhorsley/gallery/?catpath=/
https://www.deviantart.com/orcbruto/gallery/?catpath=/
https://www.deviantart.com/jamesryman/gallery/?catpath=/
https://www.deviantart.com/rntentn/gallery/?catpath=/
https://www.deviantart.com/rogierb/gallery/?catpath=/
https://www.artstation.com/maxbanshees

Please include any additional information about how to reproduce the problem:

Expected Behavior
The images get downloaded.
Actual Behavior
ArtStation links get skipped immediately, and DeviantArt downloader spews errors such as "No image found in (link)"

DA's malfunctions are a known thing already. The devs are waiting for DA to finish up the system. Frankly, I doubt they'll get it done anytime soon, which is increasingly a massive problem.

Yeah. Now I'm wondering if a custom login function, which was requested a
while ago, could be implemented. That might cut down on the rate limit
problem (if that was the issue)
On Tue, Aug 13, 2019, 12:24 AM Jouni Järvinen<EMAIL_ADDRESS>wrote:

DA's malfunctions are a known thing already. The devs are waiting for DA
to finish up the system. Frankly, I doubt they'll get it done anytime soon,
which is increasingly a massive problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RipMeApp/ripme/issues/1398?email_source=notifications&email_token=AC2JFIANTCQUGWMTLMJZ3YLQEF6CNA5CNFSM4IK5TOVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C4JBI#issuecomment-520471685,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2JFICVNKDSSTEZMDXOIDTQEF6CNANCNFSM4IK5TOVA
.

I'm wondering why the ArtStation links are skipped without leaving any log behind.

I have a similar problem I try to download from the DeviantArt gallery of my favorite artist but all I get is null

I still get the null error on DeviantArt downloader and ArtStation links are just straight-up ignored. I gave it 50 or so links and it ignored all of them.

Downloading https://www.deviantart.com/kittew/gallery/all
Rip complete, saved to C:\DownLoads\rips\deviantart_kittew_gallery_unknown
null

same, was looking for a DA downloader, but no luck so far ;_;


rand_win.c: BCryptGenRandom() used incorrectly on Windows Vista

In #8639 the version requirements for BCryptGenRandom were loosened from Windows 7 to Windows Vista. Subequently, it was reported by @matbech, the original author (see #1142), that Windows Vista does not support calling BCryptGetRandom with the BCRYPT_USE_SYSTEM_PREFERRED_RNG flag. Instead, BCryptGenRandom() needs to be called with the handle of an algorithm provider, obtained using BCryptOpenAlgorithmProvider().
Instead of reverting #8639 as requested, my plan is to make BCryptGenRandom() behave correctly for Windows Vista. The idea is to attempt calling BCryptGenRandom(..., BCRYPT_USE_SYSTEM_PREFERRED_RNG) first, and failing that to fall back to using the Microsoft CNG provider.
(I'll need to set up a Vista VM first to to be able to test it properly, so please hang on...)
See also

#1142 - Use BCryptGenRandom on Windows 7 or higher

#2168 - rand_win.c may use BCryptGenRandom with BCRYPT_USE_SYSTEM_PREFERRED_RNG

#8639 - rand_win.c: loosen version requirements for BCryptGenRandom

Microsoft Docs - BCryptGenRandom

Microsoft Docs - BCryptOpenAlgorithmProvider

A bit off-topic, but:
Wouldn't it be safer to first check if bcrypt.dll exists, then use GetProcAddress to get BCryptGenRandom, and if unsuccessful (Windows XP) use the old method? I'm asking, because I personally had to use "-D_WIN32_WINNT=0x0501" just for this function in libcurl ( https://github.com/openssl/openssl/issues/8635 ). Some developers might compile for XP to make it possible to start, even when 99% of users use Windows 7 or newer. In my opinion it could be good to allow BCryptGenRandom whenever possible. Not sure if that wouldn't complicate it too much or affect consistency of the code... just sharing my thoughts.

I instrumented openssl with some printf's (see mspncp/openssl#7) and tested it on Windows Vista SP2. It seems that the MSDN Documentation is outdated, at least for SP 2.  The BCryptGenRandomCall() succeeded.
If nobody objects, I will consider this issue resolved and close it tomorrow.
(@HerMajestyDrMona concerning Windows XP: I would consider it a waste of energy to make any efforts to 'fix' openssl for Windows XP, because Windows XP is EOL since 2014 and nowadays hopelessly insecure.)

Ok, I consider this issue resolved for the moment.
If anyone suspects that BCryptGenRandom() does not work on his Windows Vista machine, he might compile his own instrumented openssl application from mspncp#7 and run the
openssl rand -hex 10

command. If it does not show STATUS_SUCCESS as below, please post the output here, together with the Windows version.
Microsoft Windows [Version 6.0.6002]
Copyright (c) 2006 Microsoft Corporation. Alle Rechte vorbehalten.

C:\Users\msp>openssl rand -hex 10
_WIN32_WINNT = 0x00000603
BCryptGenRandom() returned STATUS_SUCCESS
37a655fb82d04c43e694

A bit off-topic, but:
Wouldn't it be safer to first check if bcrypt.dll exists, then use GetProcAddress to get BCryptGenRandom, and if unsuccessful (Windows XP) use the old method? I'm asking, because I personally had to use "-D_WIN32_WINNT=0x0501" just for this function in libcurl ( #8635 ). Some developers might compile for XP to make it possible to start, even when 99% of users use Windows 7 or newer. In my opinion it could be good to allow BCryptGenRandom whenever possible. Not sure if that wouldn't complicate it too much or affect consistency of the code... just sharing my thoughts.

I'd would even prefer to GetModuleHandleA("bcrypt") before using bcrypt. This way at least it would be less intrusive and would allow to delay load bcrypt.dll

Do you realise that both calls are identical underneath the API layer?  BCryptGenRandom isn't a security improvement, it is a usability improvement.
We've got to support the legacy call BTW.

Do you realise that both calls are identical underneath the API layer? BCryptGenRandom isn't a security improvement, it is a usability improvement.
We've got to support the legacy call BTW.

Can you please clarify what are you referring and replying to?

The older CryptGenRandom will exist and is the same as BCryptGenRandom.
There is no need to call the first if the second fails.
Yeah, my comments are too late to change this PR.

I think 2621e6405d7f4765bc57c86ec441129e7d367f14 is not quite complete - there are certain win-SDK's (regardless which windows version used) where BCRYPT_USE_SYSTEM_PREFERRED_RNG is not defined at all in bcrypt.h.
So either it should be:
 # ifdef USE_BCRYPTGENRANDOM
 #  include <bcrypt.h>
+#  ifndef BCRYPT_USE_SYSTEM_PREFERRED_RNG
+#    undef USE_BCRYPTGENRANDOM
+#  endif
 # endif

or something like that:
 # ifdef USE_BCRYPTGENRANDOM
 #  include <bcrypt.h>
+#  ifndef BCRYPT_USE_SYSTEM_PREFERRED_RNG
+#    define BCRYPT_USE_SYSTEM_PREFERRED_RNG 2
+#  endif
 # endif

Otherwise the build can fail with undeclared identifier 'BCRYPT_USE_SYSTEM_PREFERRED_RNG'.

SP2

MSDN states: Windows Vista:  This flag ( BCRYPT_USE_SYSTEM_PREFERRED_RNG) is not supported without SP2.
@mspncp i would take @HerMajestyDrMona idea (GetProcAddress) advice.


DELETE retried multiple times

What happened?

I'm using provider-http version 1.0.3.
I have the following Request
apiVersion: http.crossplane.io/v1alpha2
kind: Request
metadata:
  name: port-team
spec:
  forProvider:
    waitTimeout: "5m"
    headers:
      Content-Type:
        - application/json
      Authorization:
        - Bearer {{${id}-port-token:crossplane-system:token}}
    payload:
      baseUrl: https://api.getport.io/v1/teams
      body: |
        {
          "name": "cost-center-${id}",
          "users": [user.email for user in parameters.users],
          "description": "Cost Center ${id} team"
        }
    mappings:
      - method: POST
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: .payload.baseUrl
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{${id}-port-token:crossplane-system:token}}
      - method: GET
        url: (.payload.baseUrl + "/" + .response.body.team.name)
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{${id}-port-token:crossplane-system:token}}
      - method: PUT
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: (.payload.baseUrl + "/" + .response.body.team.name)
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{${id}-port-token:crossplane-system:token}}
      - method: DELETE
        url: (.payload.baseUrl + "/" + .response.body.team.name)
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{${id}-port-token:crossplane-system:token}}

When I delete the MR, the Team is actually deleted successfully once but then the DELETE is retried and it fails with 404, see events order:
Events:
  Type     Reason                        Age                    From                                Message
  ----     ------                        ----                   ----                                -------
  Warning  CannotCreateExternalResource  3m40s (x6 over 3m40s)  managed/request.http.crossplane.io  something went wrong: failed to get secret 123-port-token:crossplane-system: Secret "123-port-token" not found
  Normal   CreatedExternalResource       3m39s                  managed/request.http.crossplane.io  Successfully requested creation of external resource
  Normal   UpdatedExternalResource       97s (x3 over 3m38s)    managed/request.http.crossplane.io  Successfully requested update of external resource
  Normal   DeletedExternalResource       94s                    managed/request.http.crossplane.io  Successfully requested deletion of external resource
  Warning  CannotDeleteExternalResource  28s (x6 over 93s)      managed/request.http.crossplane.io  something went wrong: HTTP DELETE request failed with status code: 404

How can we reproduce it?

What environment did it happen in?
Crossplane version: 1.17.0

Hi,
Thanks for the details. I tried to reproduce the issue with the latest provider version, but couldn’t replicate it. I recommend upgrading and testing again. If the issue persists, feel free to share more details, and I’ll take another look.

Hi @arielsepton
I've just retried with provider 1.0.5 and Crossplane 1.17.1, the issue persists.
Here you can find the manifests I've tried (replace elements within <...>):
apiVersion: http.crossplane.io/v1alpha2
kind: DisposableRequest
metadata:
  name: port-token-request
spec:
  deletionPolicy: Orphan
  forProvider:
    url: https://api.getport.io/v1/auth/access_token
    method: POST
    body: |
      {
        "clientId": "{{ port:crossplane-system:port_client_id }}",
        "clientSecret": "{{ port:crossplane-system:port_client_secret }}"
      }
    headers:
      Content-Type:
        - application/json
    shouldLoopInfinitely: true
    nextReconcile: 1h
    secretInjectionConfigs:
      - secretRef:
          name: port-token
          namespace: crossplane-system
        secretKey: token
        responsePath: .body.accessToken
        setOwnerReference: true
---
apiVersion: v1
kind: Secret
metadata:
  name: port
  namespace: crossplane-system
type: Opaque
stringData:
  port_client_id: <PORT_CLIENT_ID>
  port_client_secret: <PORT_CLIENT_SECRET>
---
apiVersion: http.crossplane.io/v1alpha2
kind: Request
metadata:
  name: port-team
spec:
  forProvider:
    waitTimeout: "5m"
    headers:
      Content-Type:
        - application/json
      Authorization:
        - Bearer {{port-token:crossplane-system:token}}
    payload:
      baseUrl: https://api.getport.io/v1/teams
      body: |
        {
          "name": "cost-center-test",
          "users": ["<EMAIL>"],
          "description": "Cost Center test team"
        }
    mappings:
      - action: CREATE
        method: POST
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: .payload.baseUrl
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: OBSERVE
        method: GET
        url: (.payload.baseUrl + "/" + .response.body.team.name)
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: UPDATE
        method: PUT
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: (.payload.baseUrl + "/" + .response.body.team.name)
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: REMOVE
        method: DELETE
        url: (.payload.baseUrl + "/" + .response.body.team.name)
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}

Hi, I looked into this and found the issue.
All jq expressions used in the Request resource need to return null when a field is missing. Instead, gojq is returning an empty string, which is causing the problem.
To fix this, you can update your jq expression like this:
url: (.response.body.team.name|tostring)

Adding tostring ensures that missing fields are handled correctly across all requests. Please let me know how it goes!

Thanks @arielsepton I managed to get it working like this:
apiVersion: http.crossplane.io/v1alpha2
kind: Request
metadata:
  name: port-team
spec:
  forProvider:
    waitTimeout: "5m"
    headers:
      Content-Type:
        - application/json
      Authorization:
        - Bearer {{port-token:crossplane-system:token}}
    payload:
      baseUrl: https://api.getport.io/v1/teams
      body: |
        {
          "name": "cost-center-test",
          "users": ["redacted"],
          "description": "Cost Center test team"
        }
    mappings:
      - action: CREATE
        method: POST
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: .payload.baseUrl
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: OBSERVE
        method: GET
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: UPDATE
        method: PUT
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: REMOVE
        method: DELETE
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}

But I'm facing the same problem now with PUT requests, which are repeated every minute:
Events:
  Type    Reason                   Age               From                                Message
  ----    ------                   ----              ----                                -------
  Normal  CreatedExternalResource  63s               managed/request.http.crossplane.io  Successfully requested creation of external resource
  Normal  UpdatedExternalResource  1s (x3 over 63s)  managed/request.http.crossplane.io  Successfully requested update of external resource

I had a look here, and I tried to configure the jq expression like this:
apiVersion: http.crossplane.io/v1alpha2
kind: Request
metadata:
  name: port-team
spec:
  forProvider:
    waitTimeout: "5m"
    headers:
      Content-Type:
        - application/json
      Authorization:
        - Bearer {{port-token:crossplane-system:token}}
    payload:
      baseUrl: https://api.getport.io/v1/teams
      body: |
        {
          "name": "cost-center-test",
          "users": ["redacted"],
          "description": "Cost Center test team"
        }
    expectedResponseCheck: # <----- see here
      type: CUSTOM
      logic: |
        if .response.body.team.name == .payload.body.name
         and .response.body.team.users == .payload.body.users
         and .response.body.team.description == .payload.body.description
         then true
         else false
         end
    mappings:
      - action: CREATE
        method: POST
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: .payload.baseUrl
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: OBSERVE
        method: GET
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: UPDATE
        method: PUT
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: REMOVE
        method: DELETE
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}

But without success. PUT requests are repeated.
Also if I may give you a suggestion, it would be much more helpful having the status field reporting not just the response of the last request.

The PUT request is being retried because your expectedResponseCheck expression is returning false—the team.users field doesn’t exist in the GET response.
To fix this, you can update the jq expression like this:
expectedResponseCheck:
  type: CUSTOM
  logic: |
    if .response.body.team.name == .payload.body.name
    and .response.body.team.description == .payload.body.description
    then true
    else false
    end

As for your suggestion about adding status, could you explain a bit more about how you think it would help? Since the status only holds the latest response, I’m curious about what extra benefit you're thinking it might provide.

Thanks @arielsepton for the updates.
But what happens if I change a user in the users  field? The logic you suggested  would consider the resource updated because it doesnt't use that field right?
In that case I think that's a flaw in the API.
About the status field, as you said it reports the status of the latest response. I was thinking that it would be good to know the status of the previous requests as well, because if I have an error I can't see any details about it by inspecting the resource itself.

I spoke with a tech lead at Port @danielsinai, and it turns out if you add the query parameters ?fields=name&fields=description&fields=users.email, you can retrieve the users in this format:
"team": { "users": [{"email": "<email>"}, {"email": "<email>"}] }

You can update your resource like this:
apiVersion: http.crossplane.io/v1alpha2
kind: Request
metadata:
  name: port-team
spec:
  forProvider:
    waitTimeout: "5m"
    headers:
      Content-Type:
        - application/json
      Authorization:
        - Bearer {{port-token:crossplane-system:token}}
    payload:
      baseUrl: https://api.getport.io/v1/teams
      body: |
        {
          "name": "test",
          "users": ["<email>"],
          "description": "Cost Center test team"
        }
    expectedResponseCheck:
      type: CUSTOM
      logic: |
        if .response.body.team.name == .payload.body.name
         and (.response.body.team.users | map(.email) | sort) == (.payload.body.users | sort)
         and .response.body.team.description == .payload.body.description
         then true
         else false
         end
    mappings:
      - action: CREATE
        method: POST
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: .payload.baseUrl
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: OBSERVE
        method: GET
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring) + "?fields=name&fields=description&fields=users.email")
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: UPDATE
        method: PUT
        body: |
          {
            "name": .payload.body.name,
            "users": .payload.body.users,
            "description": .payload.body.description
          }
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}
      - action: REMOVE
        method: DELETE
        url: (.payload.baseUrl + "/" + (.response.body.team.name|tostring))
        headers:
          Content-Type:
            - application/json
          Authorization:
            - Bearer {{port-token:crossplane-system:token}}

This should solve the issue.
Regarding the status field, while tracking previous request statuses could be helpful for debugging, it might make the field too large and hard to manage.  I think adding more detailed logs could give you the info you need without cluttering the resource, making it easier to trace past requests while keeping status focused on the current state.

Thanks @arielsepton , that worked.
For me having the requests logs e.g. at provider level is fine.


Autocompletion problem??

Hi,
When I tried the example, I type "d" for state and Nevada was highlighted and I was expecting "Delaware" be highlighted. Same for "w", which highlights "Hawaii" instead of "Washington". Is there a way to change this behavior?
Thanks!!

This is the expected behaviour of Select2, it sorts results in the order that they are given (DOM order or AJAX order). You may be interested in the following Stack Overflow questions, depending on what you are looking for:

Select2 - Sorting results by query
Select2 search - match only words that start with search term


Increase button padding to adhere to primary button specification.

Fixes #1720

Obviously, code LGTM. Will give it the cross-browser treatment tomorrow.

Obviously, code LGTM.

If it isn't I'd wonder about both of our sanity. :tongue:

Cross-browser is looking good. Merging :+1:


Added the algorthms

hey @ajay-dhangar
Fixes #568
Hey i have added all the algorithms i mentioned in the issue in the respective folders
please check and tell me if any changes required
Thankyou
Pls add the labels gssoc extd , hacktoberfest ,level 3(if u like my work)

@ajay-dhangar  can u please check and tell me if its fine

@ajay-dhangar can u please add a higher label?

ill do it @ajay-dhangar

@ajay-dhangar kindly check now !

Hey @ajay-dhangar please add a higher label

@ajay-dhangar can u please add a higher level label ?

@ajay-dhangar  please add a higher level label


Implement GPG related api

In order to implement go-gitea/gitea#425
I added all the api call that should be implemented and struct needed to format requests and responses.
I follow the github format as a example: https://developer.github.com/v3/users/gpg_keys/

LGTM

As said on gitter, I hesitate to use PublicGPG... in place of GPG... since it will only contain the public part of the keys like the ssh keys. I don't know what you think of it.

Could we give an option to let user chose and we can use one as default?

@lunny You are saying to let the possibility to users to add a private gpg key to gitea ? From my point of view it would not be a good idea normally you limit the existence of your gpg keys only on trusted media.
My question was just for the format of object and function name to be as https://github.com/go-gitea/go-sdk/blob/master/gitea/user_key.go#L15 since it's the same case (gitea only need the public key)

I think that GPG is clear enough, since we don't have the private key

Ok perfect i will stick with this to continue in the next part (API and UI) in gitea.

LGTM

@sapk Is this done?

It follows the spec so I'm merging it anyway 😂


Unknown provider: $ionicHistoryProvider <- $ionicHistory

I have started brand new project but immediately got stuck here
app.controller('MyCtrl', function($ionicHistory) {
console.log('testing')
})
with this error:
Unknown provider: $ionicHistoryProvider <- $ionicHistory
any idea?

Greetings @fgrs!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Any solution??


23.2.0 to 23.3.0 10x slower

💥 Regression Report
I upgraded jest from 23.2.0 to 23.5.0 and now my tests run 10x slower.
I am using typescript with ts-jest.
The only difference is the version of jest.
Last working version
Worked up to version: 23.2.0
Stopped working in version: 23.3.0
To Reproduce
Steps to reproduce the behavior:
clone https://github.com/asafigan/jest-upgrade-issue
yarn install
yarn test --watch
press a to run all tests
after they run press enter to re run tests
I get a time of 0.736s
yarn upgrade<EMAIL_ADDRESS>yarn test --watch
press a to run all tests
after they run press enter to re run tests
I now get a time of 7.681s
Feel free to use the docker-compose configuration provided in the repo.
Expected behavior
time to run tests should stay about the same.
Link to repl or repo (highly encouraged)
https://github.com/asafigan/jest-upgrade-issue
Run npx envinfo --preset jest
Paste the results here:
  System:
    OS: Linux 4.9 Debian GNU/Linux 8 (jessie) 8 (jessie)
    CPU: x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
  Binaries:
    Node: 8.11.3 - /usr/local/bin/node
    Yarn: 1.6.0 - /usr/local/bin/yarn
    npm: 5.6.0 - /usr/local/bin/npm
  npmPackages:
    jest: ^23.2.0 => 23.2.0

There's instruction on how to link Jest in Contributing guide in the root of the project, setup watch for rebuilding and then one can use git bisect.


fix: service without ports defined

Hi Team,
As describe in #54 , jobs fails when there is a service and this service don't have ports specified.
Closes #54

Hey @claveaur,
I branched from your PR and made some changes. Let me know what you think. I added few guards just in case we receive them from the hook call


Get color code just will use for echoed recipe commands?

Sometimes in shebang recipes it is useful to be able to echo some individual commands before running, the same as just echoes commands during a non-shebang recipe.  Prior to https://github.com/casey/just/pull/1670 , simply using bold color when echoing those commands would do the job.  Now, it's no longer known in advance how echoed commands would look.
Could a just function to help this please be added?
Perhaps it could wrap a string in color codes same as just would wrap an echoed recipe line?  Or, alternatively, perhaps it could take no arguments and return the color code just would use for echoing recipe lines?
Thanks :slightly_smiling_face:

+1 - I am finding myself using bash scripts more and more in justfiles - I'd like to have a way to echo commands and match just. Currently I have a just echo recipe that just assumes that the command is bold:
echo $text:
    #!/usr/bin/env bash
    bold=$(tput bold)
    normal=$(tput sgr0)
    echo "${bold}$text${normal}"

We could expose color codes as constants, like we do with HEX and friends. So you could do:
foo:
  echo {{GREEN}}whatever{{NORMAL}}
```

Colors could be exposed both by their color name, like `GREEN`, and by their role in just's color formatting, like `ERROR`. Constants cannot be removed after they are added, so the names would need careful thought.

I just did a little testing, and they do need to be quoted, but not escaped, since the shell interprets both [ and ; as special characters.
So you need to do:
foo:
  echo 'foo {{CYAN}}bar{{NORMAL}} baz'

There are also other useful escape sequences, like clearing the screen, bold text, and cursor manipulation. Foreground and background can also be manipulated independently.
There are a few different kinds of color codes. There are eight standard colors (red, green, black, etc), eight high-intensity colors, 216 colors in a sort of color cube, 24 grayscale colors in steps, and 24-bit colors, which are arbitrary RGB values.
Maybe we should have constants for the eight standard colors, as well as things like bold, normal style, and clear screen, and a function which can be used for constructing arbitrarily complex escape sequences.
So this:
style('bold', 'fg:red', 'bg:#00f')

Would produce the escape sequence:
\x1b[1;31;48;2;0;0;255m

This is bold (1), red foreground color (31), blue background color as 24-bit color (48 is set background color, 2 introduces a 24-bit RGB color code with arguments 0, 0, and 255).
In addition to the standard color codes, a few more "semantic" color codes, which match just would be useful. These would match common colors used in just output. WARNING and ERROR, which are bold yellow and red respectively.

@laniakea64 What do you think about the above for getting semantic escape sequences which may change dynamically based on config and settings, or are semantic in nature, like warning?

Added in #2462. Initial named styles are command, warning, and error. Pretty much anything else can be easily added going forward, like RGB colors.


util/unescape: Escape \xFF sequences to a byte.

When using the unescape function, strings within the format '\xFF' or
'\xff' will be converted a single byte.
resolves #3149

Interesting, there is an unchecked version of the str conversion which we can use because of the assertion that the function panics on invalid input. So, we should be ok using each byte in an unchecked manner as a str.
I did notice that this was only faster in release mode but in debug mode the str method is slightly faster. I'm ok with either implementation.

@kbacha Interesting! If the performance gain is remarkable, I think you can keep your current implementation.

/ok-to-test

/run-integration-tests

Thanks all! I've removed the doc-tests and left the current implementation.

@BusyJay @disksing  PTAL

@BusyJay PTAL

/run-integration-tests

/run-integration-tests


docs: Update OWNERS

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.62%. Comparing base (cd3a641) to head (96775a3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   48.74%   48.62%   -0.12%
==========================================
  Files          52       52
  Lines        3342     3342
==========================================
- Hits         1629     1625       -4
- Misses       1573     1578       +5
+ Partials      140      139       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update README.md

Changed "all-convolutional" to "fully convolutional". I think that the second name is more common in the literature. Thanks for your work!

I agree with you; although the paper we usually refer to is called "Striving for Simplicity: The All Convolutional Net" (https://arxiv.org/abs/1412.6806). I don't have a strong preference, but am happy to merge this, because "fully" sounds at least better language-wise. Thanks!

You are welcome! and also you are completely right then. I have not worked directly with them, but I have always heard my partners using "fully" so I suggested you the change.
Maybe you could link the papers you used to create those models in each section. I could help you if you need.
Thanks again for sharing your knowledge to the community!


Fix inconsistency in 3D editor navigation

Fixes #97103. Maybe fixes other inconsistencies with other input methods.

Thanks!


[Bug]: Copying and pasting notes not working

Apache Hop version?
2.5 Stable
Java version?
openjdk version "<IP_ADDRESS>" 2020-11-04 OpenJDK Runtime Environment AdoptOpenJDK (build <IP_ADDRESS>+1) OpenJDK 64-Bit Server VM AdoptOpenJDK (build <IP_ADDRESS>+1, mixed mode)
Operating system
Windows
What happened?
Copying and pasting notes not working
When I copy a note and try to paste it, one of two things happens:

If I copied some text before and it's still in the clipboard, it pastes that text (not the note).
If the clipboard is empty, I get a null-pointer exception

Link to Mattermost convo.
Issue Priority
Priority: 3
Issue Component
Component: Hop Gui

I'd like to take this opportunity to add an gui action