Improvements to new address generation

Feedback on the new address generation highlighted 2 cases that we could improve:
A) (existing) factory contracts that create new instances may run into address collusions with static labels
B) Overloading the label to be used as a salt may damage the label use case
See https://github.com/CosmWasm/wasmd/issues/942 for context
Some solutions to discuss would be:
A) adding the Init Message to the hash generation
B) adding an optional salt or nonce field to the MsgInstantiateContract. When sent from a contract or not set by the CLI we default to
B1) a constant or empty string
B2) sender, label or init message again
// tag: @the-frey , @ethanfrey , @webmaster128

I fully support (A) and had raised that issue before. I never saw a reason explaining why it was not included, so adding it in before tagging v0.29.0 seems very obvious improvement.
For (B) I am open to adding a field, but it should be optional and would only be set by the client, as it would be api breaking on the contract interface. I have a contract which uses a different label with the same initMsg to create multiple sub-contracts. I have been recommending this pattern to get multiple addresses controlled by one contract, and cw1-whitelist doesn't really offer meaningful differences in initMsg in such cases.
In order to maintain the control of the prehash space, I strongly suggest (B2) with label.
I think we need (A) + (B2) with label in order to avoid breaking existing factory contracts.

Issue A is a good point. I'm not convinced Issue B is a problem. The label is an instance description and any outtomated system can put some nice human readable counter there.
Adding the init message does not help to prevent Issue A. It might make it less likely but you can have a factory that uses constant init messages. Trying to add a binary representation of the init message can lead to all sorts of problems as there is an infinite amount of valid binary representations of the init message. You need to have certainty to know the exact init message not only in object form but byte-by-byte when generating the address. That's easy to get wrong. Now, even if it works, you cannot pre-generated addresses and remain flexible with the init message later.
Adding a field to a protobuf message is a breaking change (as discussed here: https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-044-protobuf-updates-guidelines.md).

Adding fields to Msgs. Adding fields is a not a Protobuf spec-breaking operation. However, when adding new fields to Msgs, the unknown field rejection will throw an error when sending the new Msg to an older node.

If we want to do that, we should create a second MsgInstantiateContract message type.

Adding the init message does not help to prevent Issue A. It might make it less likely but you can have a factory that uses constant init messages. Trying to add a binary representation of the init message can lead to all sorts of problems as there is an infinite amount of valid binary representations of the init message.

This is the semantics of CREATE2, which we had been following in the issue and seems to cover the Ethereum use cases well. I did not hear any disagreement of it until it was somehow missing in the implementation.

You need to have certainty to know the exact init message not only in object form but byte-by-byte when generating the address. That's easy to get wrong.

If you use the same client code to pre-generate the address as you use to claim it, it should make the same JSON and will work. For contracts, we don't really care if you can pregenerate it, just that it is different. Some factory contracts I have seen use different initMsg, but a constant label. Others use the same initMsg but custom labels. I haven't seen one in the wild that leaves them both the same.
The above argument is in practice a negligible problem and much outweighed by not breaking a large number of existing factory contracts.

Now, even if it works, you cannot pre-generated addresses and remain flexible with the init message later.

That is actually a point in favor. If you try to pre-generate one on the client side (not the contract side), you are committing to the actual contract that will be placed there. If you say it will be some escrow contract with certain rules, you can show someone your sender, label, the code hash and the initMsg and they can verify that it generates the address and thus you have a provable content without deploying. That is a feature, not a bug.

For the record, I am against adding the salt. I think it is unnecessary complexity with minimal utility. But I figured adding an optional field couldn't hurt and if someone wanted it, my feeling wasn't strong enough to block it.

I'm not suggesting to ignore the issue. But I don't think it is reasonable to break instantiations with constant init message. So I guess we need to stick to the old behaviour for MsgInstantiateContract and have a different message for the predictable address generation.
You have a good point there regarding fixing the init message. It can be done, sure. But I think we first need to address the bigger issue.

I'm not suggesting to ignore the issue. But I don't think it is reasonable to break instantiations with constant init message. So I guess we need to stick to the old behaviour for MsgInstantiateContract and have a different message for the predictable address generation.
You have a good point there regarding fixing the init message. It can be done, sure. But I think we first need to address the bigger issue.

If introducing a new message keep deployed contracts behavior intact, I'm in favor of that. Is there any drawback in this case?

Thanks for the feedback and discussions!
IMHO we should accept for A) that the creator needs to submit the exact same bytes for the init message. There is risk to get it wrong as @webmaster128 pointed out but we are in good company doing the same as CREATE2.
We could look into normalization of the init message later, to address this risk better.
I would expect predictable addresses are not the main use case and only a very small number of accounts will exists before the contract instantiation in practice. I want to assume that in these cases people know what they do and tested it proper before.
There are some good benefits this feature brings and we can iterate on this.
About B) let's stick to the plan and use the label only

If introducing a new message keep deployed contracts behavior intact ...

This would be the cleanest solution but is not compatible with the wasmvm v1 api.

We can use SortJSON to normalize the initMsg. It is also used in getSignBytes

Great idea. hash(normalize(initMsg)) makes a lot of sense

We can use SortJSON to normalize the initMsg. It is also used in getSignBytes

Is this function doing a deep sort? I think it's really hard in practice to enforce that with nested structures. Perhaps better to treat the initMsg as opaque json blob.

I don't understand why we putting any focus on details of a solution that is not solving the full problem described in this ticket. If we do not restore the old behavior for MsgInstantiateContract, we break instantiations with constant init message and label that worked before. This can have disastrous efects for deployed contracts. If you agree to ignore those, please be explicit about it.

If introducing a new message keep deployed contracts behavior intact ...

This would be the cleanest solution but is not compatible with the wasmvm v1 api.

Why? I don't think so. We need to restore the old behaviour for MsgInstantiateContract. Then we can create a second MsgInstantiateContract2 which implements the new address derivation. Initially MsgInstantiateContract2 will not be usable from a contract but support for it can be added. A client then has to decide which message they prefer to use.

I don't understand why we putting any focus on details of a solution that is not solving the full problem described in this ticket. If we do not restore the old behavior for MsgInstantiateContract, we break instantiations with constant init message and label that worked before. This can have disastrous efects for deployed contracts. If you agree to ignore those, please be explicit about it.

If introducing a new message keep deployed contracts behavior intact ...

This would be the cleanest solution but is not compatible with the wasmvm v1 api.

Why? I don't think so. We need to restore the old behaviour for MsgInstantiateContract. Then we can create a second MsgInstantiateContract2 which implements the new address derivation. Initially MsgInstantiateContract2 will not be usable from a contract but support for it can be added. A client then has to decide which message they prefer to us

I agree, this approach has less friction with the existing semantic. Similarly to the new EVM (disclaimer: I'm definitely not a fan of EVM but think that their approach to extending the VM is great) opcode, we would then have a new WasmMsg::Instantiate2 variant right?

Based on the feedback we had another round of discussion (@webmaster128 , @webmaster128  and me) an came up with the plan to:

support 2 ways of address generation: classic and predictable addresses (not available to contracts, yet)
add new MsgInstantiate2 for predictable addresses with fields: salt, include_init_msg (default false)
init msg is taken as raw bytes without normalization for MsgInstantiate2

The implementation work was started in #1014.
Biggest open question to me is the shape and size of the salt. Bytes can be inconvenient to work with. Looking at the CLI and test code, I wonder if we better make this a string instead of bytes. Then the spec allows no salt > 255 bytes. I think we should fix this and don't make it configurable by the app because the rest of the spec is also not configurable.
On Ethereum the salt is a fixed length binary value (bytes32). It is often provided in the integer form (uint is the same as uint256, which again is the same as bytes32). Using an integer is nice in CLIs. We don't have easy access to uint256 here and I guess uint64 would be too small if you want collision free salt generation using an RNG.
Any thoughts on that matter?

size of the salt.... don't make it configurable

👍 Any preferences on the value?

string instead of bytes.

A string would be more convenient on the CLI but in the API I see strings for humans while bytes are for machines. There should not be any semantic attached to the salt other than raw data.
Using an integer is a smart way for the CLI!  I would still postpone this for a quick solution, now. There are other places where people enter encoded bytes, too.

👍 Any preferences on the value? I would start with 255 (to not be blocked on this) but this can be modified easily

I'd say 64 bytes is a reasonable max size. This allows you to encode counters up to uint512 or use the hash result of both sha256 and sha512 as the value. Anything above that just encourages doing strange things.

Do we need predictable address generation for gov proposals in this first iteration? I would prefer to add this later if needed

Please also note https://medium.com/cosmwasm/dev-note-3-limitations-of-instantiate2-and-how-to-deal-with-them-a3f946874230 for important updates on Instantiate2


C2 fails to compile on FastLED with this repo

Let me know if I'm doing anything wrong. Here is my board defs for this product:
ESP32_C2_DEVKITM_1 = Board(
    board_name="esp32-c2-devkitm-1",
    platform_needs_install=True,  # Install platform package to get the boards
    platform="https://github.com/Jason2866/platform-espressif32",  # No support from PIO, have forked repo
)

CI example compiles fine with the C2
https://github.com/Jason2866/platform-espressif32/blob/fc0da1b9edc2548cbe882b65e6e3df794d1c51d2/examples/arduino-blink/platformio.ini#L23
https://github.com/Jason2866/platform-espressif32/actions/runs/10937501644/job/30363510554
Don't know what you show. Not a usual Platformio setup.

Don't know the context but this is not a valid platform entry
platform="https://github.com/Jason2866/platform-espressif32

use
platform="https://github.com/Jason2866/platform-espressif32.git

Closing since not reproducable. C2 compiles successfully and flashing does work as expected

So the issue here is that pio ci won't run, but pio run will.


Give salvage borgs a tool module.

About the PR

Gave salvage borgs a tool module round start.
Why / Balance

Salvage borgs end up needing tools during expeditions/on debris and wrecks to pry open doors, or unanchor/disassemble lockers.
Technical details

Added BorgModuleTool to salvage body. Removed Crowbar from the Mining Module.
Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

no CL as borg chassis switching aint on stable yet

add a changelog
some forks are based on master, not stable, so they should be informed


[LIVE@STREAM]*#!FREE]!F1 British Grand Prix 2023 Rica LIVE STREAM BROADCAST@FREE ON MOBILE 09 July 2023 #5834

F1 BRITISH GRAND PRIX FULL RACE REPLAY 09.07.2023 FORMULA ONE
F1 2023 Season Round 10
F1 British Grand Prix Full Race Replay July 9, 2023
Race details
Race 10 of 22 in the 2023 Formula One World Championship
Date: 9 July 2023
Formula 1 Aramco British Grand Prix 2023
Location: Silverstone Circuit, Silverstone, United Kingdom
Course: Permanent racing facility
Course length: 5.891 km (3.660 miles)
Scheduled distance: 52 laps, 306.198 km (190.263 miles)
F1 2023 Austrian Grand Prix Race Highlights
Watch Formula 1 2023 British Grand Prix 07/09/23 Full Race Replay online free in HD. Do not miss the 2023 British Grand Prix Formula 1 full race replay and best moments highlights.
You can watch F1 Full Races Replays Online live videos and enjoy every moment of this exciting sports event on FullRaces.
DISCLAIMER: This content is provided and hosted by a 3rd party server. Sometimes these servers may include advertisements. FullRaces does not host or upload this material and is not responsible for the content.

f


Fixing CalendarDatePicker's template

CalendarDatePicker's default template currently references two properties added in later versions of XAML without using conditional XAML.  This adds conditional XAML to the template in those cases.

While we're here, is there a way to make warnings-as-errors for the MUX solution so we don't introduce these again?

While we're here, is there a way to make warnings-as-errors for the MUX solution so we don't introduce these again?

Was this manifesting as test failures? Runtime warnings?

@jevansaks @chrisglein It's showing up in VS as error WMC0151.  I can't seem to find any way to turn that warning into an error - the warning-as-errors directive /wennnn only appears to apply to warnings prefixed with C (which I think are C++ compiler warnings?).
Do you know if there's a way to do the same thing for XAML warnings?  I'm coming up empty, and a search for "WMC warnings Visual Studio" or similar turned up absolutely nothing.

Do you know if there's a way to do the same thing for XAML warnings? I'm coming up empty, and a search for "WMC warnings Visual Studio" or similar turned up absolutely nothing.

@danzil Any ideas on this?

There's no such feature that I know of - that will turn XAML Warnings into Errors (when enabled). It may be possible to write an after-build targets that will look at the warnings emitted and raise an error if needed. We could also take this a feature request and create proper support for it in the Xaml Compiler targets, if there's enough interest.

Roslyn?

@danzil Do you have any examples for after-build targets that alter the warnings/errors reported?  I didn't actually know you could do that in a target.
@mdtauk I'm not too familiar with Roslyn, but isn't it specifically for C# and VB?  This is a warning returned by the XAML compiler.

@danzil Do you have any examples for after-build targets that alter the warnings/errors reported?  I didn't actually know you could do that in a target.

I do not have an example. My recommendation was based on a purely theoretical example. I can't tell exacly how you would do that without actually trying to do it. :-)

@jevansaks @danzil So it turns out that there's actually an MSBuild feature as of 15.3 that I've only just now heard about, in which you can just turn an arbitrary warning into an error (or into a message), regardless of origin, instead of relying on the C++ compiler's /we syntax:
https://github.com/microsoft/msbuild/pull/1928
I tested this out and this does exactly what we wanted, so I've added that to this change.


GEODE-3876: refactor expiry options for create region and alter regio…

…n command

add ExpirationActionConverter for client side validation/conversion
reworked ExpirationAttr
fix buggy behavior of altering expiration attributes
add more tests

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@jdeppe-pivotal @PurelyApplied @sboorlagadda @pdxrunner  please review. Thanks!

@PurelyApplied changes pushed. Precheckin green


[FLINK-12274] Fix documentation to enable Queryable State

What is the purpose of the change
Queryable state, since 1.8, now need to be enable through configuration. This add the right documentation to help people using it.
Brief change log

add reference to configuration parameter

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers:  no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? now, yes!

@flinkbot approve description

@flinkbot attention @eaglewatcherwb
@eaglewatcherwb: do you agree with this change? (since you introduced the config flag)

@flinkbot attention @eaglewatcherwb
@eaglewatcherwb: do you agree with this change? (since you introduced the config flag)

It seems good to me.

Thank you!
@flinkbot approve all
I'll merge the PR then


100% CPU usage

Issue Description
When running king-phisher consumes 100% cpu all the time.
Reproduction Steps

Start King Phisher

Environment Details
Linux kali 4.6.0-kali1-amd64 #1 SMP Debian 4.6.4-1kali1 (2016-07-21) x86_64 GNU/Linux
Error Details
As far as I can tell it could relate to a busy wait on the network interface.
Using strace I get the following with a huge amount of selects timing out.
<snip>
bind(5, {sa_family=AF_INET, sin_port=htons(80), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 0
<snip>
select(6, [5], [], [], {0, 0})          = 0 (Timeout)
select(6, [5], [], [], {0, 0})          = 0 (Timeout)
select(6, [5], [], [], {0, 0})          = 0 (Timeout)
select(6, [5], [], [], {0, 0})          = 0 (Timeout)
<snip>

Thank you for this bug report, it's probably one of the best I've seen for King Phisher. I think I have an idea of what the problem is and should be able to test it later this week.

Alright so this was an issue with select.select being used to poll in zeroSteiner/AdvancedHTTPServer (which powers King Phisher). The problem was that select was being used to repeatedly poll the different subservers used for multiple port binds.
I fixed this in commit 6909dadd by using a wakeup file descriptor, removing the need to poll and check for shutdown requests. The fix is available in AdvancedHTTPServer v2.0.6 and can be applied to King Phisher immediately by using the command: sudo python3 -m pip install --upgrade advancedhttpserver. I'll push up a commit to the dev branch to use this patched version shortly.

Fixed and merged into master. Thanks again for the bug report. Go ahead and upgrade King Phisher and this should be resolved for you.


⚠ Bofrost.lu has degraded performance

In 4a3acbc, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1650 ms

Resolved: Bofrost.lu performance has improved in 1e67380 after 8 minutes.


[Meta] Easiest way to package a Go app for Sandstorm?

I'll be doing exactly this very soon.  Thanks!

Setting up a go app for sandstorm shouldn't be much different from any other kind of app. I tend to use vagrant-spk so that I can develop on my mac. Vagrant-spk has 'stacks' but does not include go, since I don't think there's a consistent enough deploy strategy to need it. (at least, compared to something like php or rails) I'd use the diy stack.
Then, it's just a matter of modifying setup.sh to get the go build toolchain and then doing the build in build.sh. It's easiest if your app just listens on port 8000, which is what vagrant-spk expects by default.
If you run into issues or have further questions, the sandstorm-dev google group is a great place to ask them.

@mnutt Ha ha, sorry about that!  I looked at the source of Davros and https://github.com/zombiezen/filedrop at about the same time and thought Davros was written in Go, which is why I bothered asking about packaging Go apps here :-).


Adding support for ESW03-USA outlet (10A)

Adding support for ESW03-USA outlet (10A) - treated the same as the ESW03-EU

This is in response to issue https://github.com/webdjoe/pyvesync_v2/issues/5

Thanks for the PR. It looks like you forked from the previous version of the library.  The 10A switch is now supported, the pypi package will be updated shortly.


Document how to debug antora extensions

This repo defines a couple of antora extensions that are used during the website build, [reference-antora-extension], rego-antora-extension, and tekton-task-antora-extension.
When making a change to these extensions, I don't know how to try out my changes in order to verify they are working properly.
Acceptance Criteria

Document the process of executing antora extensions locally. Ideally, this includes executing them as part of a local website build.

I thought documenting this on the website end would be better option, here is a PR for that.


Does not work with latest moment-timezone

The moment-weekday-calc methods no longer properly attach to moment-timezone when upgrading to 0.5.14
You can still access them if you import moment directly but doing so causes all sorts of timezone conversion issues.

Hi! Could you please provide an example of failing code (with dependencies list)?

Sorry about the delay :)
I dug more into this and it looks like I was thrown off by a yarn bug https://github.com/yarnpkg/yarn/issues/3967 which was creating two instances of moment. This caused moment-weekday-calc to attach to the wrong instance of moment.
Which brings me to a different point, while modifying globals in javascript seems fairly par for the course it does not seem like a great practice. It would be awesome if moment-weekday-calc instead exposed an api directly.
Thanks!

@jason-krypton as far as I remember it exports WeekDayCalc, I'll have a look, thanks

similar problem on react-native where i need to import import moment from 'moment/min/moment-with-locales'
is there a static method which can be applied to moment to attach this functionallity?


ARROW-16609: [C++] xxhash not installed into dist/lib/include when building C++

This PR changes CMakeLists .txt files so that xxhash, portable-snippets are also installed. Plus it changes the name of  int_util_internal.h to int_util_overflow.h for the same reason.
This step is needed for Python code to be moved to PyArrow in https://issues.apache.org/jira/browse/ARROW-16340.

A file (to be moved out of C++) python_to_arrow.cc uses next functions:

MultiplyWithOverflow
AddWithOverflow
SubtractWithOverflow

I do not mind moving only these parts to int_util.h. But am not sure if leaving other overflow functions where they are makes sense?

How about moving only them and DivideWithOverflow() to int_util.h?

How about moving only them and DivideWithOverflow() to int_util.h?

I do not mind. @pitrou can you also share you thoughts on this?

Judging by the comment:

// "safe-math.h" includes <intsafe.h> from the Windows headers.

We don't want to move these functions to int_util.h. OTOH, the other functions (UpcastInt and CheckSliceParams) can be moved to int_util.h.

I do not think the fails are connected to the changes in this PR.
@pitrou @kou I added UpcastInt and CheckSliceParams to int_util.h and kept int_util_internal.h renamed to int_util_overflow.h. This should be ready for another look. Thanks!

I think the CI error isn't related.
Could you have another look at this PR pls? @kou @pitrou


Packages on GitHub dos not match the release on libsdl.org

The packages here on GitHub do not match what was uploaded to libsdl.org:
sdl_image-populate-prefix/src/release-2.0.5.tar.gz
    does not match expected value
      expected: 'f26f3a153360a8f09ed5220ef7b07aea'
        actual: '3446ed7ee3c700065dcb33426a9b0c6e'

libsdl.org is currently down and I'm trying to use GitHub for dependencies in the build system.
My guess is that there is a build process in preparing the builds and the builds simply where not uploaded to GitHub for the various tags (from the release page).

Tarballs made available automatically for each tag by Github are basically a git export. They are done by default by Github whenever a tag is pushed, and cannot be controlled or disabled by individual projects, even if the project has its own tarball releases with different content. (This is a frequent request.)
For projects that use Autotools, the canonical source release is a make dist tarball, which includes some extra convenience files. That is almost certainly what was uploaded to libsdl.org.
If future releases are done using Github's "Releases" feature, then those could include their own assets identical to the ones uploaded to libsdl.org, which can come from make dist or whatever. These will be in addition to the tarballs made available automatically by Github (which, again, cannot be turned off or controlled: this is a feature request for the Github service itself, and cannot be resolved by individual projects).
For example, Flatpak has https://github.com/flatpak/flatpak/releases which is produced by following the Github-related parts of https://github.com/flatpak/flatpak/blob/master/doc/release-checklist.md. The Source code (tar.gz) is produced automatically by Github and should be ignored; the one labelled flatpak-1.12.2.tar.xz or similar is the correct source-code release artifact.

The packages here on GitHub do not match

A git export is not guaranteed to be deterministic, even for the same git commit, so the tarballs that are made automatically by Github can never be guaranteed to remain identical over time.


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit ebd5cd8:
:clock10: Full build: the average full build time is 5 min(s) 9 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit ebd5cd8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/testing.md

[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add is-promise npm package

It can currently be used in deno via:
import isPromise from<EMAIL_ADDRESS>
if (isPromise({then: () => {}})) {
  console.log('it is a promise');
} else {
  console.log('it is not a promise');
}

I'm not sure if there's anything else I should be doing to properly support deno.

@ry is that an intentional choice not to allow - in the module name? It seems like that's quite a significant restriction for people moving from node.

Yes that is an intentional choice

Closing because red. Start a new PR if you want to get this in.

Given that you do not support - in package names, I don't really see a path forwards here. In addition, the number of people who simply down-voted the PR, leads me to conclude that deno is a toxic community. I will not be supporting deno in my packages for the foreseeable future. I do sincerely hope both problems can be fixed, as there's a lot to like about deno.

@ForbesLindesay I didn't down-vote but to provide context, the recent history of your package renewed a sentiment amongst the community that Deno would be a chance to address some problems with the existing ecosystem, particularly discouraging trivial dependencies.
Maybe it will, maybe it won't. But down-voting packages like this is unfortunately the only way people have of steering towards the first case.
I agree about - given that we have an "npm" type. I disagree that the community is toxic for simply down-voting 🤷♂

In which world is - not a valid URL character? It's literally the only idiomatic way to separate words in a URL. This is a really weird decision to make, especially without justifying it, and especially in an ecosystem like Deno where ALL PACKAGES are loaded from URLs.
Why is the Deno community attempting to get rid of the harmless dash character, and slow down interop/migration from Node for no apparent reason?

@Pointotech By definition - isn't an alphanumeric character. _ is.

@Pointotech We allow only a single separator character (-). This is to avoid many modules having a similar name: e.g. is_even and is-even. The decision was made over a year ago, and won't me changed. If you don't like deno.land/x because of this, host your packages somewhere else. The beauty of standard URL imports is that you are not forced to use any specific registry like deno.land/x :-)

@ForbesLindesay not that it's relevant, but I hardly disagree with your statement:

leads me to conclude that deno is a toxic community
You should really give it a try to our Discord chat.

That last comment is hardly fair, though. Every Discord chat is a toxic mess, because of Discord.


Investigate compatibility with certain Windows versions

A small update on this: The latest version seems to be incompatible with Windows version 1709 and 1803 (haven't tested 1809 yet). I've been using an Azure VM to test these for older version incompatibilities.
Ref for Windows versions: https://en.wikipedia.org/wiki/Windows_10_version_history
It appears to immediately crash upon release build, however using Microsoft.Data.Sqlite 2.2.6 and winsqlite3 1.1.14 in a sample app succeeds in the release builds and runs (on version 1709).
Enabling native debugger gives a slightly nicer debug error, which is Entry Point not found. Aside from this, the debugger fails to attach itself to the exe as it crashes instantly.
Originally posted by @Dacarnix in https://github.com/ericsink/SQLitePCL.raw/issues/298#issuecomment-539080781

Closing old/stale issue.


Go 1.12 requires GODEBUG tls13=1 in order to opt-in to TLS 1.3

Noticed that this is a new requirement to make Go use TLS 1.3:
https://github.com/golang/go/commit/48bb61166711f47eb401f245c704a5a4887d4503

Thanks for the heads up!


s/OpenWRT/OpenWrt/g

Just nitpicking but in theory OpenWrt is written with uppercase O and W only :)

Thanks for pointing this out!


[yasm] Fix feature tools

When building dynamic yasm, its tools need to dynamically call the library yasmstd, so manually copy the library to tools.
Add support with arm / linux /osx.
Related: https://github.com/microsoft/vcpkg/pull/18816.

I didn't get a reply from Robert but this didn't seem to be an over-his-dead-body thing so I just merged this


Reset the interceptor queue

Is there a way to reset the interceptor queue after all interceptors have been used, eg an .after() after the last inceptor and a call to resetAll().
I have 2 different responses from the same API call, a valid response and an error. Because the request i want to Nock is a 3rd party API call (Stripe) within the API call i'm testing (my express API), i have used Nock as part of starting up the test server, in a file before the server to mock the 3rd party API call.
This works great for the first run of tests and passes both valid and invalid Stripe responses as expected but when the tests run again they fail and i have to restart the server to restore the interceptors. If it was only one call and response the .persist() option works great but i need to test a few different responses.
Any ideas how to get around this prob?
Thanks.

@cw6365 would a call to nock.cleanAll() before each test work?

@pgte Yes it works. You can close the issue :)


Can't find variable: player

This happens only the first time after running the app.
 Error evaluating injectedJavaScript: This is possibly due to an unsupported return type. Try adding true to the end of your injectedJavaScript string. Error Domain=WKErrorDomain Code=4 "A JavaScript exception occurred" UserInfo={WKJavaScriptExceptionLineNumber=1, WKJavaScriptExceptionMessage=ReferenceError: Can't find variable: player, WKJavaScriptExceptionColumnNumber=7, WKJavaScriptExceptionSourceURL=undefined, NSLocalizedDescription=A JavaScript exception occurred}

Hi
Thank you for reporting this problem.
We are working on it. We will get back to you very soon.

Could you provide us the snippet of code that make this error happen?


Remove Element Finder and update value not working.

Hi
I test on https://dev.getautoclicker.com/
1 Remove element does not working.
When I click on the trash icon to delete an element,  it deletes the wrong
For example, I click to delete element 9 but it deletes element 1 instead.
Is the remove element index button sometimes incorrect?
2 Value not update
When i update the value of Element Finder, Action saved successfully!  ,
after browser reload the value is not update.

https://github.com/Dhruv-Techapps/auto-clicker-auto-fill/assets/1191385/47cea67f-9269-4080-9b73-3c3629a8e7d8

Thank you for letting us know this issue


Add iPega 9069 Bluetooth profile for Linux.

Hi, could you remove the second commit (xboxdrv and udev rules)? This repo is only for controller entries in the database. Thx.
PS. If you post the instructions somewhere online, I'll link to them in the readme. Or I can link to the issue you opened previously as well.

Sorry, git still confuses me.

No worries :) You can just open a new PR with the change if that is easier. Cheers


feat: visibility for modules

Description
Problem
Part of #4515
Summary
Additional Context
I made most of the stdlib modules public. These are all except the test modules and some modules that I thought were just implementation details of some other modules.
I'm adding very short documentation for each of these. I'm thinking that once we get all visibility done it should be documented in its own section, with examples.
Documentation
Check one:

[ ] No documentation needed.
[x] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

fn main(x: Field) {
    let y = foo::bar::baz();
    assert_eq(x, y);
}

mod foo {
    mod bar {
        pub fn baz() -> Field {
            2
        }
    }
}

This program currently throws two warnings rather than one.
warning: bar is private and not visible from the current module
  ┌─ temp/src/main.nr:2:18
  │
2 │     let y = foo::bar::baz();
  │                  --- bar is private
  │

warning: bar is private and not visible from the current module
  ┌─ temp/src/main.nr:2:18
  │
2 │     let y = foo::bar::baz();
  │                  --- bar is private
  │

@TomAFrench it seems that duplicate error also happens with private functions... which means that this error already existed a long time before this PR. Do you think I should try to fix it in this PR?

If it's a preexisting error then there's no reason to block this PR over it. We can sort it in a separate PR.

Looks good, we should add a bunch of frontend tests for this to show that behaviour matches that of rust

Do you know what things we could test? To be honest I don't know all the details of Rust's visibility... but if module visibility behaves the same as functions, structs, etc., then it probably works fine as the visibility check is the same for any item.

I'd just want to test that you can't reach through private modules to access public contents (except for direct submodules). That's the main case I'd want to test (how I noticed that we threw multiple warnings)


Some helpful packages for Blue

I'd really like to have mjpg-streamer and avahi-utils installed by default. While it is generally easier to get on a network in a classroom setting now, having avahi-utils really helps find other boards on the network and mjpg-streamer gives a nice quick demo.

mjpg-streamer is already installed in the iot and lxqt-4g, i'll add avahi-utils now..

@RobertCNelson, mjpg-streamer and avahi-utils are definitely nice to have but there is something uncomfortable about adding packages out of the blue just because we like them.
What if some users don't want this?
What worries me is that each time more additions like this happen, the images built with the omap-image-builder deviate more and more from a standard Ubuntu and Debian installation but they are branded as such.
I encountered this problem not too long ago when conman was added to the image. It seriously messed up the network configuration we were used to using and it took a couple of days to find out that conman was the cause.
My point is, @RobertCNelson do you think it would be a good idea to offer a virgin Ubuntu installation along side the spiced Ubuntu and Debian you currently offer?
It would really help those that expect those distros to be as Debian or Canonical intended instead of being surprised by these extra additions when no one is expecting them.
I can help make a PR that allows to do this if you think it would be a worthy contribution.
Thanks,

I can see that conman was just removed 1 hour before I made the previous comment. I'm happy about that, but it's also a surprise. I just know that because I happen to read this issue. And that's kind of my point. Now that the beaglebone is being used by so many people, for education, industry and hobbyist surprises can be huge sinks of time.
@RobertCNelson @jadonk thoughts?

@JochiPochi for a more virgin install, just use the netinstall
https://github.com/RobertCNelson/netinstall

Regards,

@RobertCNelson, Thank you. This clarifies a lot. I think I got a bit confused because all the images on elinux.org and beaglebone.org have very similar names so I didn't realize
https://github.com/RobertCNelson/netinstall
produced what I was looking for.
I'm going to start playing with it right away.


[BUG] Cannot update endpoint priority using Azure.ResourceManager.TrafficManager: PATCH vs PUT

Library name and version
Azure.ResourceManager.TrafficManager 1.0.0
Describe the bug
I'm trying to set the priorities of an Azure Traffic Manager profile, but I'm getting an error message that hints at a bug in Azure.ResourceManager.TrafficManager - it's apparently using the wrong HTTP method.
Expected behavior
The REST API request towards Azure ResourceManager should succeed, and Traffic Manager endpoints' priority should get modified.
Actual behavior
$ AZURE_TENANT_ID=xxxx dotnet run
TM hasData=True name=myAtmProfile TM num of endpoints=2
EP=MyEndpointName prio=1 status=Online weight=1
EP=MyEndpointName2 prio=2 status=Online weight=1
Unhandled exception. Azure.RequestFailedException: The 'endpoints' property cannot be specified when updating a profile using PATCH. Please use PUT to update the profile instead.
Status: 400 (Bad Request)
ErrorCode: BadRequest

Content:
{"error":{"code":"BadRequest","message":"The 'endpoints' property cannot be specified when updating a profile using PATCH. Please use PUT to update the profile instead."}}

Headers:
Cache-Control: private
X-Content-Type-Options: REDACTED
Strict-Transport-Security: REDACTED
x-ms-request-id: 31a87cad-627b-48bf-83e9-bfd7ded778f2
Server: Microsoft-IIS/10.0
X-AspNet-Version: REDACTED
X-Powered-By: REDACTED
x-ms-ratelimit-remaining-subscription-resource-requests: REDACTED
x-ms-correlation-request-id: REDACTED
x-ms-routing-request-id: REDACTED
Date: Mon, 03 Apr 2023 13:47:29 GMT
Content-Length: 171
Content-Type: application/json; charset=utf-8

   at Azure.ResourceManager.TrafficManager.ProfilesRestOperations.Update(String subscriptionId, String resourceGroupName, String profileName, TrafficManagerProfileData data, CancellationToken cancellationToken)
   at Azure.ResourceManager.TrafficManager.TrafficManagerProfileResource.Update(TrafficManagerProfileData data, CancellationToken cancellationToken)
   at Program.<<Main>$>g__Update|0_1(ResourceIdentifier atmResourceId, <>c__DisplayClass0_0& ) in Program.cs:line 25
   at Program.<Main>$(String[] args) in Program.cs:line 10

### Reproduction Steps

```csharp
using Azure.Core;
using Azure.Identity;
using Azure.ResourceManager;
using Azure.ResourceManager.TrafficManager;

var armClient = new ArmClient(new DefaultAzureCredential(true));
var atmResourceId = TrafficManagerProfileResource.CreateResourceIdentifier(subscriptionId: "MY SUBSCRIPTION ID", resourceGroupName: "MY RESOURCE GROUP", profileName: "MY ATM PROFILE");

Print(atmResourceId);
Update(atmResourceId);
Print(atmResourceId);

void Print(ResourceIdentifier atmResourceId)
{
    var tm = armClient.GetTrafficManagerProfileResource(atmResourceId).Get().Value;
    Console.WriteLine($"TM hasData={tm.HasData} name={tm.Data.Name} TM num of endpoints={tm.Data.Endpoints.Count}");
    foreach (var ep in tm.Data.Endpoints)
        Console.WriteLine($"EP={ep.Name} prio={ep.Priority} status={ep.EndpointMonitorStatus} weight={ep.Weight}");
}

void Update(ResourceIdentifier atmResourceId)
{
    var tm = armClient.GetTrafficManagerProfileResource(atmResourceId).Get().Value;
    tm.Data.Endpoints[0].Priority += 2;
    tm.Update(tm.Data);
}

Environment
Hosting platform: console app on a dev box.
IDE and version: dotnet command line on Linux, Visual Studio 2022 on Windows have the same behavior.
$ dotnet --info
.NET SDK (reflecting any global.json):
 Version:   6.0.405
 Commit:    27ab36058b

Runtime Environment:
 OS Name:     nixos
 OS Version:  22.11
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /nix/store/b9hr18bqz7c291psihs0hl7p84qhj8ib-dotnet-sdk-6.0.405/sdk/6.0.405/

global.json file:
  Not found

Host:
  Version:      6.0.13
  Architecture: x64
  Commit:       1af80ba017

.NET SDKs installed:
  6.0.405 [/nix/store/b9hr18bqz7c291psihs0hl7p84qhj8ib-dotnet-sdk-6.0.405/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.13 [/nix/store/b9hr18bqz7c291psihs0hl7p84qhj8ib-dotnet-sdk-6.0.405/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.13 [/nix/store/b9hr18bqz7c291psihs0hl7p84qhj8ib-dotnet-sdk-6.0.405/shared/Microsoft.NETCore.App]

Download .NET:
  https://aka.ms/dotnet-download

Learn about .NET Runtimes and SDKs:
  https://aka.ms/dotnet/runtimes-sdk-info

Actually this code works:
void Update(ResourceIdentifier atmResourceId)
{
    var tm = armClient.GetTrafficManagerProfileResource(atmResourceId).Get().Value;
    // tm.Data.Endpoints[0].Priority += 2;
    // tm.Update(tm.Data); <- crashes
    var ep = tm.GetTrafficManagerEndpoint("azureEndpoints", tm.Data.Endpoints[0].Name).Value;
    ep.Data.Priority += 2;
    ep.Update(ep.Data);
}

I find that the SDK is very short on documentation and code samples.
Also, may we please get a less confusing error message?

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @cizra , Thank you for using Azure SDK for .NET.
The error message is returned from service side.
In this case, if the Patch - Update method is not support by the service, we could try to use Put - CreateOrUpdate method.
Since you have solved the the problem, I'll close the issue.
Feel free to reopen it if you have any further questions.


#688: thread pools documentation

Please note that my #165 PR is required before this can be merged.

Reading the doc and reading the comment from @chrisdennis about repeated warning in call out, I am wondering if we should not simply bite the bullet and make having a default thread pool mandatory. I have the impression that while not perfect it helps the user make a proper config faster.

I'm not fond of the idea of making the default thread pool mandatory.
When a user want total control of the thread pools, not configuring a default one is an easy way to make sure that you haven't overlooked anything as you'll get an exception during initialization.
On the other hand, I do agree that it's quite an annoyance to have to configure a default thread pool for events even when you don't even register a listener.


Behind a proxy and bypass proxy for internal url

Hello
i'm behind a corporate proxy
I export HTTP_PROXY and HTTPS_PROXY environment value in the script which start the Symphony Hubot.
We have a Local KeyManager, and  we setup the environment variable HUBOT_SYMPHONY_KM_HOST to the correct value. When Symphony redirec to the KM url , the Hubot  reach the Proxy as well...and should not for internal url.
So we need to bypass proxy settings for internal url. How can we do that ?
Thanks for your help

Try NO_PROXY as described here https://github.com/request/request/blob/master/README.md#proxies


No durability guarantee (benchmark is misleading)

I was wondering why nutsdb is so fast, so I did a quick review on your code, and there is no flush/sync call in the code, you should call it to ensure durability and update the benchmark.  💪
Also, the README should mention the byte endianness issue as well, and the isolation level is not clear.

@damnever hi ,thanks your advices,
as man2 said about mmap : The file may not actually be updated until msync(2) or munmap(2) are called. Actually i called munmap in this code, so data will be updated.
if you can give me your pr to improve it， it will be better；）
BTW, about the README i will  continue to improve.

YES, but nutsdb declares to support ACID, so you should call it in each Commit, without it, the most important part about nutsdb is wrong.

Also, the simple lock cannot fully guarantee the ACID.

@damnever ，thanks :)
i have updated the README about transaction in  the Caveats & Limitations，and i will rethink your advises , and i will continue to update the README, especially about the transaction.

Still, it is a misleading README, you should remove the benchmark part and all other contents those declares nutsdb is faster than others, if you remove their flush/fsync/fdatasync part, they are fast too! And anyone can write a fast kvstore.
As I mentioned before, you maybe understand the ACID properties, but you implement it wrong, and what is a non-standard transaction?
As a self-learning project is ok, but DO NOT mislead others!

@damnever thanks to review my README，i have updated the README about the benchmark part and its conclusion.
i mean  a transactional database like mysql that provides the ACID properties , i can call it a a standard transaction. If a database not completely including ACID properties，like redis ，i call it a
non-standard transaction.
if have any question, Welcome to give me advises.
BTW,  i never want to mislead others.  if have any mistake about README or code etc.  Welcome to submit issue and give me PR.
thanks again！

I glad to see you make some changes.
From the context:

Finally i did it and named NutsDB

@damnever hi, now the master branch of nutsdb has supports persistence  , i have use sync function in my code to ensure durability and update the benchmark,
benchmark result:
badger 2019/03/11 18:06:05 INFO: All 0 tables opened in 0s
goos: darwin
goarch: amd64
pkg: github.com/xujiajun/kvstore-bench
BenchmarkBadgerDBPutValue64B-8    	   10000	    112382 ns/op	    2374 B/op	      74 allocs/op
BenchmarkBadgerDBPutValue128B-8   	   20000	     94110 ns/op	    2503 B/op	      74 allocs/op
BenchmarkBadgerDBPutValue256B-8   	   20000	     93480 ns/op	    2759 B/op	      74 allocs/op
BenchmarkBadgerDBPutValue512B-8   	   10000	    101407 ns/op	    3271 B/op	      74 allocs/op
BenchmarkBadgerDBGet-8            	 1000000	      1552 ns/op	     416 B/op	       9 allocs/op
BenchmarkBoltDBPutValue64B-8      	   10000	    203128 ns/op	   21231 B/op	      62 allocs/op
BenchmarkBoltDBPutValue128B-8     	    5000	    229568 ns/op	   13716 B/op	      64 allocs/op
BenchmarkBoltDBPutValue256B-8     	   10000	    196513 ns/op	   17974 B/op	      64 allocs/op
BenchmarkBoltDBPutValue512B-8     	   10000	    199805 ns/op	   17064 B/op	      64 allocs/op
BenchmarkBoltDBGet-8              	 1000000	      1122 ns/op	     592 B/op	      10 allocs/op
BenchmarkNutsDBPutValue64B-8      	   30000	     53614 ns/op	     626 B/op	      14 allocs/op
BenchmarkNutsDBPutValue128B-8     	   30000	     51998 ns/op	     664 B/op	      13 allocs/op
BenchmarkNutsDBPutValue256B-8     	   30000	     53958 ns/op	     920 B/op	      13 allocs/op
BenchmarkNutsDBPutValue512B-8     	   30000	     55787 ns/op	    1432 B/op	      13 allocs/op
BenchmarkNutsDBGet-8              	 2000000	       661 ns/op	      88 B/op	       3 allocs/op
BenchmarkNutsDBGetByHintKey-8     	   50000	     27255 ns/op	     840 B/op	      16 allocs/op
PASS
ok  	github.com/xujiajun/kvstore-bench	83.856s

visit https://github.com/xujiajun/nutsdb#benchmarks for detail.

I didn't go into details, as your benchmark shows, nutsdb is the simplest and fastest, it suites for the small projects.
Here is a bit of advice, do some setup and clean up work for each test case.

@damnever  thanks your advice，but i don't know what you mean about doing some setup and cleaning up work for each benchmark case. I have use b.ResetTimer() to reset timer for each benchmark case  and clean the remove data before the begining

@damnever I think you should be less ambiguous and clearly state the issues.

I am not gonna to say more about nutsdb.  :simple_smile:
https://github.com/xujiajun/gokvstore-bench/blob/801c0e9f172127f44b3831fc240f9e956740eb0e/bench_badgerdb_test.go#L109-L111
https://github.com/xujiajun/gokvstore-bench/blob/801c0e9f172127f44b3831fc240f9e956740eb0e/bench_nutsdb_test.go#L129-L133

@damnever  hi, if have no more advises about this issue, i will close it.


UI fails when analytics/tracking is enabled

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1936
Originally created by @DouweM on 2020-04-02 17:26:30

Regression introduced by https://gitlab.com/meltano/meltano/-/merge_requests/1581

View 2 previous comments from the original issue on GitLab


Return all picker font sizes to small text

I thought only search had small text. But also I don't see why. There's no semantic point.

there is a semantic meaning. let me know if you have any questions.
i think going forward i won’t tag you in these 1-2 line CSS changes. probably better for both of us if you aren’t tempted to overanalyze them ;)


Practice service contract deployments

This issue keeps track of practicing creation of

UserDepositContract
ServiceRegistry contract
MonitoringService contract
OneToN contract
on
kovan and
Ropsten.

This issue does not cover the initialization calls that have to be made on the created contracts.
Target date 2019-02-04.

create ServiceRegistry (requires token address)
create UDC (requires token address)
create MonitorinigService (requires token address, Service Registry address and UDC address)
create OneToN (requires UDC address)

The remaining tasks:

[ ] get #503 merged (I've tried it on Kovan)
[ ] try the script on Ropsten

Now our Ropsten node is up, so I can try the script and close.

Yes, the script on master works with Ropsten.
 python -m raiden_contracts.deploy services --rpc-provider <snip> --private-key <snip> --gas-price 30 --gas-limit 6000000 --token-address 0xc778417e063141139fce010982780140aa0cd5ab


Unpin pulumi cli 3

Before this change, we used an outdated Pulumi CLI version to test the provider against. With this change we start using the latest 3.x release like most other bridged providers. While it would be my preference to have it pinned and automatically updating via PRs to move toward Hermetic Builds that's more work and for now this change is a quick improvement.

Eh. I pushed a commit to the wrong branch. Apologies, fixing.


Add rage shake to report bugs

Version 1.10.0 (1554)
Device: iPhone 7 Plus (iOS 10.3.3)

Really necessary? It has it's own button in Settings already.

I actually like the idea of not having to leave your current action to report. Plus we could auto upload screenshots maybe?

Is this still in the pipeline? 😄

Closed it bc it’s probably overkill, but could be neat @kimdv if you want to peel it off 🙏
Sent with GitHawk

With both native new issue and (hopefully soon) image uploading for bug reports this is now a hella lot more simple!

@rnystrom nothing is to overkill for GitHawk 🚀🚀😎😎😎
Sent with GitHawk

I'll wait until #475 is done 🚀


Not rendering template on production

Not sure where I'm doing it wrong, but /redis-browser/js/angular.min.js fails to load and angular triggers ReferenceError on and only on production.
Thoughts?

What's inside Network tab? Are there any 404's ?

It's no longer reproducible. Maybe that was a config issue?


⚠ Bofrost.at has degraded performance

In 1b7377f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1370 ms

Resolved: Bofrost.at performance has improved in 6ec0ec4.


Fix #160 Enable optimizations

Gist of analysis: https://gist.github.com/blopker/9fff37e67f14143d2757f9f2172c8ea0
Fixes #160

The commits still need to be squashed, but the PR is ready for review now.

@blopker thanks for giving this a try. Those build times are really long, though 😞.
Maybe you could make a separate PR just to do the FFI/Expat stuff for Python 2.7? It seems like a good idea to fix that and I don't think we should let the --enable-optimizations discussion get in the way of that.

Here you go: https://github.com/docker-library/python/pull/358
The build times are longer, but how often are builds run? It looks like around monthly. As an added benefit, with the optimization flag we found an issue with the current images. If there's another issue at some point, running the tests may catch it.

I looked around a little and it turns out Travis CI has granted some open source projects more concurrent builders. WordPress has 15: https://make.wordpress.org/core/2017/05/18/increased-concurrent-jobs-on-travis-ci-builds/
Here https://github.com/travis-ci/travis-ci/issues/4668 they mention sending an email to<EMAIL_ADDRESS>to ask about raising the limit. Might be worth a try.

Travis is only used here for basic smoke tests to ensure the real builds
will work properly (and is not the primary issue with build times here,
although it's certainly a strong consideration). The real builds will take
closer to that 12 hour mark (if not longer, since that official infra often
has io contention issues).

Oh, that's too bad. I didn't know there was another build system. I usually just use Travis to push images once built: https://docs.travis-ci.com/user/docker/
May be worth asking support for more workers anyway.
I do want to note that I just rolled out a Python 2.7 with optimizations to a production system at work (not Docker though) and we saw a visible minimum 10% performance gain across all endpoints. Endpoints with heavy database access saw the least gain, of course.
If this change doesn't go through I'll definitely set up optimized images for internal use, but I'd love to share it with the world :)

Closing since we cannot handle the ~16x on build times.
Since these optimizations are only based on running the test suite it would make sense that they could be all pre-created and released with the source, rather than having distributions recreate what is, in essence, a static optimization.

See the comment on the issue, you don't need to use the default overly-long PROFILE_TASK setting to see a large benefit.


Make it possible to keep temp files for debugging purposes when pipe fails

Type of Issue
[ ] Bug Report
[x] Feature Request

Description
To investigate issues that occur on running the pipe, it would be cool to have a flag in the cli that prevents the temp files from being deleted on fail.
From time to time i get errors like this:
BUILD ERROR
Unexpected token (15076:4) in <workspace>\.ng_pkg_build\<name>\esm5\client.js
...

However i cannot look into the file that is causing the error because it already got deleted.

Investigating the file led me to the solution on this one: https://github.com/dherges/ng-packagr/issues/367
Was kinda hard to get the file though.

Yes, good point.
Why not have a build directory like gradle? with sub-folders for the npm dist folder and the intermediate temp files. Or keep the ng_build directory after packaging.

This probably should be configurable if allowed.

In current version (2.0.0-rc.8), the working directory is no longer pruned when the pipeline fails.
https://github.com/dherges/ng-packagr/blob/master/src/lib/ng-packagr.ts#L55-L57
Whether a build directory should be "visible" is a separate discussion. Gradle does it. On the Java world, it's common to have class files and jars and ears and aar or apk files written to disk ... let's discuss this elsewhere :earth_africa:


Public v1.0.0-alpha.1

Prequsitions

All high-priority tickets should be done
Docs should be updated to match the latest turms
All known bugs in 1.0.0 should be fixed
All smoke tests pass

Prequsitions

All high-priority tickets should be done
Docs should be updated to match the latest turms
All known bugs in 1.0.0 should be fixed
All smoke tests pass


Click on the tab on the lapce settings interface to switch to the wrong position

Lapce Version
v0.3.1
System information
Windows11
Describe the bug
Click on the tab on the lapce settings interface to switch to the wrong position
Additional information

Here I chose the markdown plugin option, but I switched to the UI position

Duplicate of https://github.com/lapce/lapce/issues/2759


Import whatwg-fetch to VirtualizedSelectExample to avoid Safari issue

https://github.com/bvaughn/react-virtualized-select/issues/34

Hi @vidaaudrey,
Thanks for the contribution!
The whatwg-fetch dependency should be added to devDependencies though, since it's only used in the demo site. (No need to add that dependency for all users installing react-virtualized-select.) 😁

Makes sense. Will update my.


Fixed not writing specs to directory

The code had problems at every stage:
Fetching stage
During fetching, it wasn't writing anything to the directory, because it was trying to write a keymap to file, instead of a string.
Also, the key for the spec listings in the discovery file changed from url to discoveryRestUrl.
I changed the with statements to case, just so I could get it working, and I understood it. Uglier, but it works.
Conversion stage
Similar problem as fetching, but it wasn't writing, because the directory openapi had never been created
Build stage
Just had to state what the current docker image should be.
However, had a question here...once I generated the client, it had all these new empty files that were generated. Is that suppose to happen?

Thanks for the PR!
For fetching, the 404s will go away when I remove the APIs that should not be there.
For converting, we should ensure that the openapi directory exists, or create it.
For generating the client, you are getting empty files and not the latest generated code as we are using the fork from the pending PR to swagger-codegen (so it's not in the master image).


Error with @sel.path.quote when followed by another quoted argument

Item Configuration
item(
	title='Title'
	cmd='c:\path\to\file.bat'
	args='--some --argument @sel.path.quote "c:\path\to\some\other\file.txt"'
)

Expected Command Line
Above item is supposed to produce the following command line:
c:\path\to\file.bat --some --argument "c:\path\to\selected\file.txt" "c:\path\to\some other\file.txt"

Where the last two arguments are c:\path\to\selected\file.txt and c:\path\to\some other\file.txt.
Actual Command Line
The space between the last two arguments gets ignored:
c:\path\to\file.bat --some --argument "c:\path\to\selected\file.txt""c:\path\to\some other\file.txt"

The two quotes "" (rather than " "!) are a escaped quote (literal string ") and hence the last two arguments become one:
c:\path\to\selected\file.txt"c:\path\to\some other\file.txt.
Workaround
If the @sel.path.quote is replaced with<EMAIL_ADDRESS>it works as expected:
item(
	title='Title'
	cmd='c:\path\to\file.bat'
	args='--some --argument @sel.path.quote "c:\path\to\some\other\file.txt"'
)

Do not use escape sequences in single quotes
Single quotes
item(
	title='Title'
	cmd='c:\path\to\file.bat'
	args='--some --argument<EMAIL_ADDRESS>"c:\path\to\some\other\file.txt"'
)

Use escape sequences
item(
	title='Title'
	cmd="c:\\path\\to\\file.bat"
	args="--some --argument " + sel.path.quote + " \"c:\\path\\to\\some\\other\\file.txt\""
)

quote func
item(
	title='Title'
	cmd='c:\path\to\file.bat'
	args="--some --argument " + sel.path.quote + quote(' c:\path\to\some\other\file.txt')
)

https://nilesoft.org/docs/expressions/string

I understand. To be honest, the documentation is still quite confusing to me .... :-)

Do not use escape sequences in single quotes

As a matter of fact, I added those escape sequences just in the issue here. I indeed used it exactly as you wrote (have now updated the original post):

Single quotes
item(
	title='Title'
	cmd='c:\path\to\file.bat'
	args='--some --argument<EMAIL_ADDRESS>"c:\path\to\some\other\file.txt"'
)

However, this still causes the error.

I understand. To be honest, the documentation is still quite confusing to me .... :-)

Perhaps this is due to Google Translate, as I use it to translate my Arabic language into English

If the @sel.path.quote is replaced with<EMAIL_ADDRESS>it works as expected:

To avoid this issue use this method or the previous one
args='--some --argument @(sel.path) "c:\path\to\some\other\file.txt"'

This issue will be fixed

This issue has been fixed: debug

This issue has been fixed: debug

Yes, this seems to be solving the issue! Fantastic!


UDP in Railgun

Kong 2.2 introduces support for UDP routes.
From a KIC implementation standpoint, TCPIngress has fields similar to what UDP routes will require, i.e. a hostname (handled via TLS SNI) and a port.
The user interface is an open question. Service APIs propose HTTPRoute and TCPRoute resoruces. In our current model, we could introduce a new UDPIngress CRD or augment TCPIngress to support protocols other than TCP, despite the name.
Upstream TLS is an open question. On the Kong end, there are tls, tcp, and udp services, and all are implemented via NGINX streams: https://github.com/Kong/kong/commit/967043e3b7df39fd98fad7f0b4588795b1d35609

TBD: whether the scope of this issue is only plain UDP (without DTLS) or UDP with DTLS support (DTLS offloading, SNI, etc.).
TBD: whether kubernetes (kube-proxy, networking) works nicely with UDP (including ICMP Port Unreachable, etc.)

We need to figure out whether to implement this on top of service-apis or existing KIC APIs.

We need to figure out whether to implement this on top of service-apis or existing KIC APIs.

Blocked by #1010 which will give us an answer whether to implement this on top of service-apis or not.

Blocked by #1010 which will give us an answer whether to implement this on top of service-apis or not.

Blocked by #1043 - we need to understand whether this should go to KIC 2.0 or 1.x or both

I took a first pass at UDPRoute this in this branch and wanted to share for posterity (but we still do need to complete #1043 before we can move forward).

We're going to follow up on my previous branch work and spike a v1alpha1.UDPIngress in railgun.

Merged in v1alpha1 and continued work on the UDPIngress API is covered by follow-up issues in the UDPIngress milestone.


[Feature Request] parse HTML in el-popover

Existing Component
Yes
Component Name
el-popover
Description
Hi,
I am using render-header to create custom headers in el-table:
<el-table-column :render-header="renderCustomHeader">
renderCustomHeader(h, {column, $index}) {
        return h('span', [
          h('span', {
            domProps: {
              innerHTML: column.label
            }
          }),
          h('el-popover', {
              props: {
                placement: 'top',
                trigger: 'hover',
                content: this.getHeaderTooltip(column.label)
              },
            },
            [
              h(
                'span',
                {
                  slot: 'reference',
                  class: 'tooltip-icon-white',
                  style: 'font-size: 11px; margin-left: 7px;'
                },
                ''
              )]
          )
        ]);
      },

My getHeaderTooltip contains HTML tags.
Is there a way to parse content as HTML in content (I tried to use domProps without luck)?
Thanks.

The content  of the popover is expected to be a String. If you want to custom content, you can use slot.
It's painful to write render functions, I recommend you use JSX. https://vuejs.org/v2/guide/render-function.html#JSX

thank you for replying.
As you can see from my example, I already use slot.
Lets ignore the render function. How would you use slot in this simple
example?
https://jsfiddle.net/zmxhgbfo/
On Mon, Oct 22, 2018 at 9:51 AM hetech<EMAIL_ADDRESS>wrote:

The content of the popover is expected to be a String. If you want to
custom content, you can use slot.
It's painful to write render functions, I recommend you use JSX.
https://vuejs.org/v2/guide/render-function.html#JSX
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ElemeFE/element/issues/13105#issuecomment-431752713,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKc-1ZakRmmTe2dEhGEIabMSnz_elvr3ks5unWrhgaJpZM4XyejB
.


vscode should not try to contact the internet when computer is disconnected

From @aybabtme on August 9, 2017 18:54
When I go offline, on planes or whatever, I want to be able to use my editor without issues. Currently, parts of VS Code appear to be trying to check for upgrades or things like that, and does so even when my wifi is completely off. When those upgrades fail, it shows pops up that are distracting.
VS Code should detect that there's no connectivity and avoid spamming user with connection error messages.
Copied from original issue: Microsoft/vscode-go#1137

@aybabtme Can you share one of the error messages that you see?

@ramya-rao-a yup next time I see the pop-up, I'll try to take a screenshot and loop back.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!


Issue with CAS server URL starting with "login"

When using a CAS server with URL starting with "login" (e.g. "login.example.com"), the library removes the string "login" when making the request to the CAS server in order to verify the token provided by client (i.e. it tries to connect to ".example.com").
Behaviour observed when using the following dependencies:
"org.pac4j" % "pac4j-cas" % "1.8.1-SNAPSHOT",
"org.pac4j" % "pac4j-core" % "1.8.1-SNAPSHOT",
"org.pac4j" % "play-pac4j-java" % "2.0.1-SNAPSHOT",

<dependency>
   <groupId>org.pac4j</groupId>
   <artifactId>spring-security-pac4j</artifactId>
   <version>1.3.0</version>
</dependency>
<dependency>
   <groupId>org.pac4j</groupId>
   <artifactId>pac4j-cas</artifactId>
   <version>1.7.1</version>
</dependency>
<dependency>
   <groupId>org.pac4j</groupId>
   <artifactId>pac4j-core</artifactId>
   <version>1.7.1</version>
</dependency>

Notice pac4j v1.8.1 has been released (no more SNAPSHOTs).
I guess the problem is here: https://github.com/pac4j/pac4j/blob/master/pac4j-cas/src/main/java/org/pac4j/cas/client/CasClient.java#L269
Would you mind submitting a PR for that?

Thanks, I created a PR with a fix which seems to work for me (I hope I understood the idea of that string replacement correctly).

OK. Can you thus a simple test to check it works to protect us against any regression? Using your example...

new PR...https://github.com/pac4j/pac4j/pull/421


How to get QR bytes in Blazor app .NET8?

In non-windows .NET8 project "new QRCode()" has an empty constructor. How to get QR bytes from a string?
I've looked at .NET5 Blazor example but it's outdated, does not work in .NET8.

This might be it:
            var qRCodeGenerator = new QRCodeGenerator();             var qRCodeData = qRCodeGenerator.CreateQrCode(text, QRCodeGenerator.ECCLevel.Q);             var qRCode = new BitmapByteQRCode(qRCodeData);             var bytes = qRCode.GetGraphic(5);

Alternatively you could use the PNG renderer:
using (QRCodeGenerator qrGenerator = new QRCodeGenerator())
using (QRCodeData qrCodeData = qrGenerator.CreateQrCode("The text which should be encoded.", QRCodeGenerator.ECCLevel.Q))
using (PngByteQRCode qrCode = new PngByteQRCode(qrCodeData))
{
    byte[] qrCodeImage = qrCode.GetGraphic(20);
}

In addition check the compatibility matrix. Every renderer listed in the "Net 6.0" column should work in your .NET8 environment: https://github.com/codebude/QRCoder/wiki/Advanced-usage---QR-Code-renderers#2-overview-of-the-different-renderers


add compression middleware

Adding compression middleware

Don't know much about this but it looks good to me! Merging


Add pull request template and issue templates

This is an automatic batch pull request.

Pull-request updated, HEAD is now 7103e46f299068e8a56241b8e15617396375b866


Issue loading checkpoints

Hello!

While trying to use the viewer to load trained models, it gives an error that the directory does not exist. Even after specifying the checkpoint file directly, it is not able to load. Perhaps it could be a basic error with the directory path.  But the path seems to be correct.
Would appreciate any insight on this !

It was path specification(😅)  + having to disable drawing training images and loading train dataset.
The checkpoints are being loaded now.

Nice, glad this is solved! Feel free to open a PR with your forked code that does this check pointing.

I could train the ros_nerfacto and save the files. But when I try to export them to pointcloud or mesh, I get the following error. I believe it is something related to checkpoint but I am not sure as well. I am using ROS1 with orbslam3.
I double-checked that I am using the correct version of nerfstudio as well.
I also tried @bharath-k1000  's nerf_bridge repo for saving the checkpoints and tried to export, still the same error. Any insights could be really helpful. Did you manage to export them @bharath-k1000  ?
Loading latest checkpoint from load_dir ✅ Done loading checkpoint from outputs/ros_nerfacto/2024-04-08_225800/nerfstudio_models/step-000029999.ckpt ☁ Computing Point Cloud ☁ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ {'image': tensor([], size=(0, 1440, 1920, 3)), 'image_idx': tensor([], dtype=torch.int64)} ☁ Computing Point Cloud ☁ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ☁ Computing Point Cloud ☁ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━   0% --:-- Traceback (most recent call last):   File "/root/miniconda3/envs/nerftest/bin/ns-export", line 8, in <module>     sys.exit(entrypoint())   File "/root/miniconda3/envs/nerftest/lib/python3.8/site-packages/nerfstudio/scripts/exporter.py", line 463, in entrypoint     tyro.cli(Commands).main()   File "/root/miniconda3/envs/nerftest/lib/python3.8/site-packages/nerfstudio/scripts/exporter.py", line 139, in main     pcd = generate_point_cloud(   File "/root/miniconda3/envs/nerftest/lib/python3.8/site-packages/nerfstudio/exporter/exporter_utils.py", line 129, in generate_point_cloud     ray_bundle, _ = pipeline.datamanager.next_train(0)   File "/root/test/test19/nerf_bridge/nsros/ros_datamanager.py", line 121, in next_train     batch = self.train_pixel_sampler.sample(image_batch)   File "/root/miniconda3/envs/nerftest/lib/python3.8/site-packages/nerfstudio/data/pixel_samplers.py", line 274, in sample     pixel_batch = self.collate_image_dataset_batch(   File "/root/miniconda3/envs/nerftest/lib/python3.8/site-packages/nerfstudio/data/pixel_samplers.py", line 172, in collate_image_dataset_batch     collated_batch = {   File "/root/miniconda3/envs/nerftest/lib/python3.8/site-packages/nerfstudio/data/pixel_samplers.py", line 173, in <dictcomp>     key: value[c, y, x] for key, value in batch.items() if key != "image_idx" and value is not None IndexError: index is out of bounds for dimension with size 0                                                    (nerftest) root@nipg17:~/test/test19/nerf_bridge#

Unfortunately, I'm no longer actively working with any of the ROS1 implementation. However, in other work I've done similar checkpointing, and these were the steps that were required.

Save the camera poses somewhere. Exporting requires the training poses and camera intrinsic, but not the images.
Modify the exporter script to load the pipeline with these saved poses.

Sorry I can't go into more detail but the related code is in a codebase that is going to be submitted for publication later this year so I can't release it quite yet!


Make the library more compatible with type checkers

While the library has lots of type hinting (yay! thanks!) it doesn't mark itself as being typed, so when it comes to running mypy over code that uses the library (for example) you get told things like this:
error: Skipping analyzing "aiopinboard": module is installed, but missing library stubs or py.typed marker  [import-untyped]
error: Skipping analyzing "aiopinboard.bookmark": module is installed, but missing library stubs or py.typed marker  [import-untyped]
Skipping analyzing "aiopinboard": module is installed, but missing library stubs or py.typed marker  [import-untyped]
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

In passing, this PR also includes a line of code in __init__.py to "export" API.

Let me know if you have other items coming, or if you'd like me to cut a release soon.

I think that's it. As you might have realised, I'm working on a Pinboard client built around this library and the PRs have been little things I've run into (and I must stress: it's been a great body of code to work with, thanks again for building this!). As best as I can tell I've covered most of what I'll be using so I think it's safe to cut a release.
Thanks for being so quick with this too; very much appreciated. :-)

You got it! I'll cut one later this morning and will ping you here when it's done. Glad you're finding the library useful!

@davep 2023.11.0 is cut!

Awesome! Thanks; I'll give it all a good test out later on.
Once again: really appreciate the library and the update. Thanks!

All updated here and looking good, thanks!


Release download blocked as a virus

Chrome/Edge and maybe Windows defender blocks the setup download falsely flagging as a virus for being an uncommon install.

Yes, sadly, I am encountering this as well. I have tried everything I know to force download the file. Do you know of any workaround?

Looks like I just have to sign the installer - https://stackoverflow.com/questions/76248724/windows-saying-my-msi-installer-is-a-virus

Great. let us know when you have done that. This tool has a lot of promise!

I'm looking for a cheaper option than $429 for 3 years for code signing certs for all my open source projects.
https://www.sectigo.com/ssl-certificates-tls/code-signing
Self-signed certs did not work.

I'm going to switch back to Innosetup which has a warning but it won't be blocked. CA cert fees are insane!

I switched to an InnoSetup installer. There's a warning to accept that I didn't use a code signing certificate, but it's not blocked as a virus.

Windows started blocking the new installer as a virus again.


unrecognized selector sent to instance

//this used is ok

(nullable NSURLSessionDataTask *)POST:(NSString *)URLString
parameters:(nullable id)parameters
success:(nullable void (^)(NSURLSessionDataTask *task, id _Nullable responseObject))success
failure:(nullable void (^)(NSURLSessionDataTask * _Nullable task, NSError *error))failure DEPRECATED_ATTRIBUTE;

//this error :  POST:parameters:progress:success:failure:]: unrecognized selector sent to instance 0x7f93f2606080

(nullable NSURLSessionDataTask *)POST:(NSString *)URLString
parameters:(nullable id)parameters
progress:(nullable void (^)(NSProgress *uploadProgress)) uploadProgress
success:(nullable void (^)(NSURLSessionDataTask *task, id _Nullable responseObject))success
failure:(nullable void (^)(NSURLSessionDataTask * _Nullable task, NSError *error))failure;

please tell me why?
POST:parameters:success:failure:]
it can work well ,but it is DEPRECATED.
i want to user "POST:parameters:progress:success:failure:"

Deprecated simply means it will be removed in the future, and allows you to migrate to the new API without breaking your current app.
:beers:

POST:parameters:progress:success:failure:
This method has not been implemented yet?

I agree with you. @dzenbot

Thanks.
------------------ Original ------------------
From:  "Ignacio Romero<EMAIL_ADDRESS>Date:  Tue, Feb 16, 2016 07:24 AM
To<EMAIL_ADDRESS>Cc:  "Peter<EMAIL_ADDRESS>Subject:  Re: [AFNetworking] unrecognized selector sent to instance (#3274)
Why is it that POST:parameters:success:failure: is flagged to be deprecated exactly?
It's a very convenient method, when you don't need the request's progress callback.
—
Reply to this email directly or view it on GitHub.


Only import pip if needed

In some systems pip is not installed and the parse_requirements() function
is not needed. So only import pip if needed. Otherwise this fails with:
from ryu.base import app_manager
File "/usr/lib/python2.7/site-packages/ryu/base/app_manager.py", line 34, in
from ryu import utils
File "/usr/lib/python2.7/site-packages/ryu/utils.py", line 23, in
from pip import req as pip_req
ImportError: No module named pip

Coverage decreased (-0.04%) to 67.504% when pulling f6efd9754e90c4b5394d69c6055de775ba9fb303 on toabctl:pip-optional into 0c0656f95a646756df5caae10734c2e561ff7b56 on osrg:master.

Hi @toabctl
Thank you for posting your patch! It looks good to me!

Coverage decreased (-0.002%) to 67.542% when pulling f6efd97 on toabctl:pip-optional into 0c0656f on osrg:master.

I guess we can ignore this warning, it should not be fatal error.
BTW, as you can see on CONTRIBUTING.rst, Ryu project does not use PR on GitHub.
Would you mind sending your patch to<EMAIL_ADDRESS>

BTW, as you can see on CONTRIBUTING.rst, Ryu project does not use PR on GitHub.
Would you mind sending your patch to<EMAIL_ADDRESS>
Done

@toabctl
Thanks a lot!


AlaSQL Code Examples 0.0.1 is released (AlaSQL Codex)

Codex is available at:
http://alasql.org/codex/
Please, leave you comments and suggested features. The repository is https://github.com/agershun/alasql-codex
Known issues:

Ctrl-Enter to run query is not working now.
List of samples is very short

Looks awesome !!!

The "prev" and "next" buttons are not working on my chrome.

Is the idea that one shall be able to edit the options

Would be nice if clicking on a folder automaticly opened it and selected the first test

Is search working for you? its not for me...

Would be awesome to have word "Result" or "Output" close to the top left of the results (maybe the prev and next could go to the center?)

What is the status on codex?


Tx tail

I'm trying to track down the reason for the TX transmitting a ~200ms ~54Hz tone when the PTT is released. I have STE turn off, roger turned etc, nothing is enabled that specifically generates anything when the PTT is released.
I think it's on the QS software as well, but trying to rack down the cause to fix the problem is difficult as I don't yet know the BK radio chip.

ah, so far tracked it down to "RADIO_EnableCxCSS()", which is called from the "APP_EndTransmission()" function.

Fixed the bug, I now do this in radio.c ..
It was enabling CTCSS tail and adding a 200ms delay when it shouldn't have been.
`
void RADIO_EnableCxCSS(void)
{
switch (gCurrentVfo->pTX->CodeType)
{
case CODE_TYPE_OFF:
break;
	case CODE_TYPE_CONTINUOUS_TONE:
		BK4819_EnableCTCSS();
		SYSTEM_DelayMs(200);
		break;

	case CODE_TYPE_DIGITAL:
	case CODE_TYPE_REVERSE_DIGITAL:
		BK4819_EnableCDCSS();
		SYSTEM_DelayMs(200);
		break;
}

}
`

It is indeed a QS bug. Nice catch!
From Ghidra:
void RADIO_EnableCxCSS(void)
{
CODED_SQUELCH_TYPE CVar1;
     CVar1 = gCurrentVfo->pReverse->CodeType;
     if ((CVar1 == CODE_TYPE_DIGITAL) || (CVar1 == CODE_TYPE_REVERSE_DIGITAL)) {
              BK4819_EnableCDCSS();
     }
     else {
              BK4819_EnableCTCSS();
     }
     SYSTEM_DelayMs(200);
     return;

}

I bet QS will never fix the bugs in their own firmware.

I will probably fork the repo or make a branch, to have all these QS bugs fixed so that people forking OEFW inherit them.

I started what I just mentioned. If you rebase your tree with the "fixes" branch then you will inherit all fixes like the ones you found and ones+improvements that QS releases in newer updates.
"main" will remain a copy paste of the original, including the original bugs.

I'm getting old these days, I have several decades of experience in hardware/software design but when it comes to github my head turns to mush, so I never really do anything with github apart from simple uploads to it.

I was like that for a while, but at my last job I had the luck of having git pros that taught me how it really works instead the usual garbage you see in most tutorials online. Now I can manage pretty well, although I rely on a GUI for certain operations (Sublime Merge is very good) because it makes it less confusing. But in summary, git only works well if you have 2 branches. A little long to explain, but it is the only way with git. Single branch only really works if you are the only person to work on the tree.
A FYI, I started playing with the Radtel RT-890 recently and I'm probably going to give it the K5 treatment. I don't have one yet, but I was able to dump its firmware remotely from a unit and confirm SWD/JTAG etc works and that the 890 is suitable platforms. I only spent a couple of hours in Ghidra and I already have a lot mapped out and the code is a little better than K5.

What processor does that radio use ?

Cortex M4, up to 120MHz :) much more expanded instruction set. Entire chip is also well documented + freely available SDK (AT32F421C8T7).

This tail tone elimination is still very broken.
The idea of it is to send a reverse polarity CTCSS tone to get the receiving RX to cut audio before the carrier is dropped, but the firmware isn't doing that at all, it just sends a bit of a strange 54Hz, what it should be sending is a reverse phase (180 deg) same frequency CTCSS at the end of TX.
This is what the radio is actually sending, it's got the correct CTCSS (254.1Hz) during TX, but then at the end the 200ms 54Hz appears in place of a proper reverse phase CTCSS tone ..
(the menu STE setting has no effect)

hmmm, the 55Hz tail tone is QS's own method.
They're not following the standard reverse phase same freq ctcss way :(

It's OK, I've found the solution to making the radio compliant with usual CTCSS tails, I think do anyway, just a matter of figuring out the BK chip registers, which I think I'm OK with now. The lack of detailed data sheets etc makes things awkard.

Done it OK, the radio can be set to conform to normal CTCSS methods :)

Yes sure, I just need to test it in RX mode first.
The first fix is to fix the STE option. This is what I have for that bit, it's in "app.c" ..
void APP_EndTransmission(void)
{
	RADIO_SendEndOfTransmission();

	if (gCurrentVfo->pTX->CodeType != CODE_TYPE_OFF)
	{	// CTCSS/DCS is enabled

		//if (gEeprom.TAIL_NOTE_ELIMINATION && gEeprom.REPEATER_TAIL_TONE_ELIMINATION > 0)
		if (gEeprom.TAIL_NOTE_ELIMINATION)
		{	// send the CTCSS/DCS tail tone - allows the receivers to mute the usual FM squelch tail/crash
			RADIO_EnableCxCSS();
		}
		#if 0
			else
			{	// TX a short blank carrier
				// this gives the receivers time to mute RX audio before we drop carrier
				BK4819_ExitSubAu();
				SYSTEM_DelayMs(200);
			}
		#endif
	}

	RADIO_SetupRegisters(false);
}

I know, it's fine, I know what human beings are really like, a few decades of life teaches us that, it's just that I don't want it in my life anymore, prefer to let the world glide by doing it's usual worst whilst I do my own little things in life.

Yes close away.
Most are using mine ? .. oh dear lol

cripes !


Document downloading DEM datasets

The goal would be to create a new tab with information with different datasets and how to download them.

Currently in progress here: https://github.com/apache/incubator-baremaps-site/pull/42


Conditions for Guards [WIP]

See #262.
So far this only applies to the RoutePermissionGuard as a proof of concept.
Can I have your feedback @bakura10 before I proceed to finishing it off with the other guards and docs.
It's a shame that this guard specifically was created with an AND default whereas an OR would have made more sense (like the RouteGuard).

@bakura10 Just noticed this one - can you get it merged now?

Hi,
Sorry about this, we should definitely start to merge it :p. @danizord could you have your own quick review please ?

Great - we have been using in production for some time now. Works grand.

Ok, I'm going to merge than Monday if nothing complain about it. Can you remind me if I forget?

I think you can simplify the logic to something like that:
if (GuardInterface::CONDITION_AND === $condition) {
    foreach ($permissions as $permission) {
        if (!$this->authorizationService->isGranted($permission)) {
            return false;
        }
    }

    return true;
}

if (GuardInterface::CONDITION_OR === $condition) {
    foreach ($permissions as $permission) {
        if ($this->authorizationService->isGranted($permission)) {
            return true;
        }
    }

    return false;
}

throw new InvalidArgumentException(sprintf(
    'Condition must be either "AND" or "OR", %s given',
    is_object($condition) ? get_class($condition) : gettype($condition)
));

I agree with @danizord change, more efficient and way easier to read.

Coverage decreased (-0.82%) to 93.27% when pulling 41ce33ff43b1891dc634a12522fe77ffbf92e6d3 on davidwindell:issue-262 into 02a5593a916554cda9d6497b3dd9da0512935c8d on ZF-Commons:master.

Thanks!
Just a few more CS fixes to make travis happy: https://travis-ci.org/ZF-Commons/zfc-rbac/jobs/56477072

Coverage decreased (-0.82%) to 93.27% when pulling f56b0b8efeaf9fbf10836687445fb4b81f97c2bf on davidwindell:issue-262 into 02a5593a916554cda9d6497b3dd9da0512935c8d on ZF-Commons:master.

Coverage decreased (-0.82%) to 93.27% when pulling f56b0b8efeaf9fbf10836687445fb4b81f97c2bf on davidwindell:issue-262 into 02a5593a916554cda9d6497b3dd9da0512935c8d on ZF-Commons:master.

:+1:

Thanks! I've tagged ZfcRbac as 2.5.0 :).
Hopefully someone will be able to backport this feature for other guards !


fix(useRowSelect): do not throw if toggleRowSelected id not found in current instance

Encountered an exception when a component callback held reference to a row that was deleted by the time it was executed. This PR adds a small change to bail early in the reducer if the toggleRowSelected action's row id is not found in the current instance.

what's the status of this PR? is it going to be merged anytime soon?

+1 we are looking to have this fixed for our implementation as well


Localized system properties

There is an issue with the System.Title and other "named" properties.
If you have a localized Solid Edge, those properties will be translated into the user language.
The actual method looks for the exact name and it will return a property not found error.
A possible solution would be to create a map SystemPropertyName --> PropertyIndex and use the index to get the correct property. This issue is present only when editing properties through Solid Edge; the structured storage method is not affected.

Sounds like a good idea to me.  That must be a recent change.  I had a user early on who discovered he had to use English for those properties, even though they were presented in Polish in SE.

I recently saw a list of system properties that SE actually supports.  Was that from you?
Also, the property indices you mention, would those be the item number in whatever stream holds the property, or something else?

I have created the list in combo box for system properties, but not created a mapped index to use in the PropertySet
Structured storage is always in English so the problem occurs only when edit on Solid Edge

fixed with #118
I haven't created a specific function that returns the property but wrote it directly inside the GetProp sub.
It may be useful for other usage to create a proper function.

Did a quick test and all seems to be working.  I'll do some more before I close this out.
I added Material and Sheet Metal Gage to the checks in GetProp.
In TaskEditProperties, at one point I have:
If (PropertyName.ToLower = "material") And (PropertySetName.ToLower = "system")
Correct me if I'm wrong, but since the ComboBox entries are in English, this should still work even if a user is running in Localized mode, right?

Yes, It works and you don't need the toLower statement at the combo box entries are not editable.
The problem is on the property name that SolidEdge APIs returns localized and therefore you need the mapping.
Material it's a strange beast anyway. Even if through API is present in the PropertySet it's not in the UI and not in the Structured Storage. Said that I don't know if it come localized or not, I have to check it but can't till next Tuesday.

It's gonna be a huge release the next one 😀🔝

@farfilli When you get to it, let me know what you find about the language for Material, etc.  If they're localized, I have a few things to fix.

@rmcanany the property Material is not localized and it is in MechanicalModelling.Item(1)

OK.  Thank you.
Same with the rest of them, too?  (Density, Coefficient of Thermal Expansion, etc.)

That's a mix of translated and English.
I will send you a screenshot tomorrow, not in front of PC now.
I was thinking that for standard properties we could map them all, there will be no need to find them in this way.

Yeah, mapping them sounds like better way to go.  I'll look into it.

I have highlighted the localized properties; by the way density is not part of the properties but its an exposed variable

Very helpful.  Thank you!

@farfilli @ChrisClems @lrmoreno007
Hey All, I'm going to take a look at this today.  Once this one is fixed, I think we're ready to do a release.  I have been working on the release notes.  When you get a chance, please look over your sections and let me know if I got anything wrong or left anything out.  Thank you!

@rmcanany the link on DirectEdit leads to the wrong position.
Thoughts:
To be able to implement the expression editor I have used those 2 components:

CoreCLR-NCalc
FCTB(FastColoredTextBox)

To be able to implement the Direct edit of properties I have used this component:

OpenMcdf

I would check on license terms if you need to mention them on the ReadMe; I would mention them anyway they are all great components

Good points, especially about the external components.  I'll get that fixed.

Superseded with https://github.com/rmcanany/SolidEdgeHousekeeper/issues/123.  Closing.