DC-2590: Correct Fossa project ID

SonarCloud scan results:
 0 Bugs
 0 Vulnerabilities
 0 Code Smells

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker/5/ : SUCCESS in 29s
https://checklist.intgdc.com/job/compliance/job/sonarcloud-scan-PR-check/5/ : SUCCESS in 59s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/343/ : SUCCESS in 6s

LGTM

SonarCloud scan results:
 0 Bugs
 0 Vulnerabilities
 0 Code Smells

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-merge-compliance-check/180/ : SUCCESS in 28s
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker/6/ : SUCCESS in 32s
https://checklist.intgdc.com/job/compliance/job/sonarcloud-scan-PR-premerge/2/ : SUCCESS in 1m 01s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-fossa-scanning-zuul/4/ : FAILURE in 2m 08s (non-voting)


service status is wrong

In GitLab by @wknet123 on Sep 21, 2017, 16:25

In GitLab by @yhua123 on Nov 8, 2019, 07:37
no pic, close now

In GitLab by @sokril on Nov 8, 2019, 08:10
closed


Show the log viewer of the last stage by default

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #908
Does this PR introduce a user-facing change?:

Show the log viewer of the last stage by default

Great job. Thank you.
/approve


[RecordReplay] How to wait for promise to fulfil

Browser/version (+device/version): Chrome / 86
Steps to reproduce the problem:
I am trying to find the Selector using DOM element using the below mentioned code. However this code is not waiting for promise to fulfil and continue with execution as this is async call.
Please let me know how can I wait for promise to fulfil and then proceed with further execution.
var promiseObject = sap.ui.test.RecordReplay.findControlSelectorByDOMElement({ domElement: element });
promiseObject.then(function(result) {
//Processing on result
}
After exploring RecordReplay.js I have found this "waitForUI5" method. And inserted this below line at positions to wait for promise to resolve but still no luck.
sap.ui.test.RecordReplay.waitForUI5({ interval:1000 });
//Position 1
var promiseObject = sap.ui.test.RecordReplay.findControlSelectorByDOMElement({ domElement: element });
//Position 2
sap.ui.test.RecordReplay.waitForUI5({ interval:1000 });
promiseObject.then(function(result) {
//Processing on result
}
Can you tell me how to make this findControlSelectorByDOMElement synchronous or wait for promise to fulfil.
Regards,
Chirag

Hi @chiragjn3,
obviously we can't implement findControlSelectorByDOMElement to be sync and thats why we have made it async. The correct way is to wait for the promise just like you do (.then() and process the result in the handler. But of course, your whole code flow should be async. Please make yourself familiar with promises and how to work with them: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise


CM->RMC Retagging of IDs

About the PR

I am going to change many ID's in these files from CM to RMC. I am not touching the code so much as a chunked rewrite of IDs. This is not an all encompassing rewrite but rather to reduce future workload
See https://github.com/RMC-14/RMC-14/pull/3583/files for details
Why / Balance

Longstanding TODO's of changing stuff from CM to RMC.


[WIP][SPARK-31889][BUILD] Docker release script does not allocate enough memory to reliably publish

What changes were proposed in this pull request?
Allow overriding the zinc options in the docker release and set a higher so the publish step can succeed consistently.
Why are the changes needed?
The publish step experiences memory pressure.
Does this PR introduce any user-facing change?
No
How was this patch tested?
[WIP] Running test locally with fake user to see if publish step (besides svn part) succeeds

cc @srowen @cloud-fan

Test build #123388 has started for PR 28698 at commit a599699.

Also seems fine.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28007/
Test PASSed.

Test build #123388 has finished for PR 28698 at commit a599699.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123388/
Test FAILed.

Two failures are spurious (failures in Java unit tests).
Jenkins retest this please.

Ran locally as<EMAIL_ADDRESS>seems to work fine.


node-gyp gets confused by MSBuild on the %PATH%

Node-gyp Version: v3.8.0
Node Version: v11.7.0
Npm Version: 6.5.0
Platform: Windows 8.1 Enterprise / 6.3.9600 N/A ビルド 9600 / x64-based PC

I tried to build build a simple module on msvs 2017, but that failed as long as an old MSBuild
c:\Program Files (x86)\MSBuild\14.0\Bin\amd64
was on the %PATH%
When I removed the path, node-gyp build built just fine. It also worked, when I added the latest MSBuild to the %PATH%
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\amd64
So node-gyp configure doesn't seem to care if there is an MSBuild.exe on the path, but node-gyp build stumbles upon an insufficient MSBuild on the path, although it does work fine if there is none at all on the path.
As this took me hours to figure out, I would suggest node-gyp build just ignore any MSBuild on the path. (Otherwise, what's the point of node-gyp configure going to great pains to find a suitable MSBuild in the first place?)
Judging from stackoverflow and github issues, i'm not the only one stumbling on this. In fact, several other developers had "success" after uninstalling (!!) their old Visual Studios - I'm assuming what cured it was that the uninstall also fixed their %PATH%.
Verbose output:
C:\Projects\node>node-gyp configure --verbose --target=v0.12.18 --msvs_version=2017
[...]
gyp verb find vs2017 Found installation at: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise
gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.Windows10SDK.14393
gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.Windows10SDK.17763
gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.VC.Tools.x86.x64
gyp verb find vs2017   - Found Microsoft.VisualStudio.VC.MSBuild.Base
gyp verb find vs2017   - Using this installation with Windows 10 SDK
gyp verb find vs2017 using installation: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise
[...]
gyp info ok

C:\Projects\node>node-gyp build
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp info spawn msbuild
gyp info spawn args [ 'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64' ]
このソリューション内のプロジェクトを 1 度に 1 つずつビルドします。並行ビルドを有効にするには、"/m" スイッチを追加してください。
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v141 (Platform Toolset = 'v141') cannot be found. To build us
ing the v141 build tools, please install v141 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and
then selecting "Retarget solution".  System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\me\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "build"
gyp ERR! cwd C:\Projects\node
gyp ERR! node -v v11.7.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok

In the meantime, I've switched over to using cmake-js, but thanks nonetheless for addressing the issue this quickly!


Possible to download video to local file?

The Offline Storage and Playback tutorial seems to address saving the video with shaka.offline.Storage, but I can't find any information on downloading it locally.

Hi Lisa,
In short, you can't do that.  At least, you can't do that in a consistent, standard way.  There's no standard API for filesystem access across browsers, so you can't save content to the filesystem and then play it back with MediaSource.
If you have a specific use case in mind, we would be happy to discuss it and help you find the best solution.


flag: include flag is not present in the latest version.

It seems like there has been a couple of changes, one of which is addition of -include flag, since the last release v0.1.6. In module-aware set-up, go get fetches and installs the latest version found where -include is missing for the time being.  Would you mind bumping a release with the latest changes?

In the meantime you can use go get github.com/rakyll/statik@master to install the tip of the master branch.

After https://github.com/rakyll/statik/pull/94 gets merged I will release a new version.


Unbind from a specific version

Was having dex issues when using this with other libraries that also ask for play services. This will fix those issues

We've resolved this issue following README recommendation https://github.com/idehub/react-native-google-analytics-bridge#android-build-problem

I've been unsure wether or not to merge this pull request. I've seen some libraries depend on truly old versions of play-services, which I cannot faithfully guarantee will work alongside this module. At the same time this seems like a continueing problem, and it may actually be prudent to put the burden of matching versions between different modules on the consuming developer.
Since I don't see any specific features we need from v8+, I think we can give this a try.


what is y_train in tensorflow

what is the meaning of y_train in this line of code?
(x_train, y_train), (x_test, y_test) = tf.keras.datasets.cifar10.load_data()

y_train is the set of labels of all the data present in x_train
similarly, y_test  is the set of labels of the data present in x_test

This is a question for StackOverflow as it is not related to a bug in the code / feature request.


color option does not work

Hi! The code below produces two plots colored in the default blue. Am I missing something?
# cell 0
import holoviews as hv
import numpy as np
from holoviews import opts as ho
hv.extension('bokeh')

# cell 1
hv.Distribution(np.arange(100)).opts(color='green')

# cell 2
hv.Distribution(np.arange(100)).opts(ho.Distribution(color='green'))

macOS: 10.14.3
HoloViews: 1.11.3
NumPy: 1.16.2
Bokeh: 1.0.4
JupyterLab: 0.35.4

Try
hv.Distribution(np.arange(100)).opts(fill_color='green', line_color='red')

Usually 'color' is an alias for setting both the fill and line colors, so I'm surprised this doesn't work.

The problem here is the default definition, color only works as an alias if no explicit fill or line color are specified but since the default defines both it ends up having no effect:
options.Distribution = Options(
    'style', fill_color=Cycle(), line_color='black', fill_alpha=0.5,
    muted_alpha=0.2
)

There are a number such issues which should be addressed. In this case I would suggest changing fill_color=Cycle() to color=Cycle(). This will make sure that color will work as an alias for fill_color.

I got it. Thank you all for the answers!

Thanks for closing, but this is definitely a bug and should be fixed.


dbTable parameter should be removed

https://github.com/hussien89aa/KotlinUdemy/blob/801f3e7987e04ba67860a47ecac9d0eb027906a6/Android/NoteApp/StartUp/app/src/main/java/com/hussein/startup/AddNotes.kt#L12
This parameter is redundant and better to remove it not to confuse readers

working on it.


Complete migration to Boost.Beast

The development of what became Boost.Beast began inside the rippled codebase. Several artifacts from that development history continue to exist within our codebase and are actively used.
Among them are:

ssl_bundle, a class which predates Boost.Beast and was written to address problems with the moveability of socket objects. Starting with Beast.Boost 1.71.0, we can use [ssl_stream](https://www.boost.org/doc/libs/1_71_0/doc/html/boost_asio/reference/ssl__stream.html) instead.
Code to inspect bytes on the wire to perform SSL detection, allowing a single port to serve both unencrypted and encrypted connections. This should be replaced with new Boost.Beast functionality using composed operations.
A workaround for waitable timers to support both versions of Boost before and after 1.70.0. We should remove the workaround since we now require a minimum of 1.70.0.

All the sub-issued described here have been fixed.


contributing: update Go and Node.js versions in Dockerfile

Updates the OS and Go to the latest, and Node.js to the latest LTS versions.

Hey @wheinze, thanks for the PR!
Could you motivate these changes a bit? Why the current Dockerfile needs improvement, etc.

Hey @wheinze, thanks for the PR!
Could you motivate these changes a bit? Why the current Dockerfile needs improvement, etc.

Sure, added some more info ;)

I'm sold. Let me know what you think of the above, otherwise I think it's pretty much ready to go!

Excellent, thank you Waldemar!


[1.5.0] Movie details view for TV's

Description
Add special layout for big screen devices

Fixed at https://github.com/odin3/Avi/commit/8407a30e2037f94e55576156ab2a5d71902f509d


Not showing pending grants anymore in order details page

Description
Our new order details page no longer shows pending grants which can be the case for Discord & GitHub benefits where the user has received an email & nudge to connect their account, but have not done so yet. Before we used to show the benefit and nudged them to connect their account on this page too. That is required in order for the benefit to be fully granted, i.e a GitHub/Discord invite to be completed.
This causes a UX issue where the user believes they have not received the benefit until they first check their email & complete the steps there.
Replicate

Create a product with GitHub/Discord benefit
Buy product from a user without GitHub/Discord connected
You won't see the GitHub/Discord benefit in your orders detail page anymore since it hasn't been fully granted yet. We used to show it along with a nudge to connect GitHub/Discord directly on the page for the user.

Not applicable anymore


LE Audio: BAP Broadcast Assistant support for multiple connections

Is your enhancement proposal related to a problem? Please describe.
The current implementation of the BAP Broadcast Assistant only supports a single connection.
Describe the solution you'd like
The broadcast assistant should, like all the other LE Audio GATT client implementations, support multiple servers (BAP Scan Delegators).
Describe alternatives you've considered
N/A
Additional context
Ideally it should also handle bonding.

https://github.com/zephyrproject-rtos/zephyr/pull/67629 and https://github.com/zephyrproject-rtos/zephyr/pull/66874 will conflict with the changes necessary to implement this, and it's suggested to wait with this until those have been merged


Displays relationships for a resource.

closes #3227
Why was this change made?
BF-goodness
How was this change tested?
Which documentation and/or configurations were updated?


fix(macos_m1): Added PATH setting to run aws commands

Added AWS into PATH where it is needed to upload release asset.
The jobs were failing
Successful job with this change

It is additional fix to the https://github.com/espressif/idf-python-wheels/pull/17 PR.

@jakub-kocka , Just out of curiosity, do we know what has changed since 71a219316f72, because it seems that the workflow was passing then. Thank you

@jakub-kocka , Just out of curiosity, do we know what has changed since 71a2193, because it seems that the workflow was passing then. Thank you

@fhrbata it could be that the self hosted runner with M1 was reinstalled completely (a week ago) and probably GH actions logic change. The AWS is installed in the runner, but not in the workflow PATH and it is not remembered between steps of the job.
I haven't done a further investigation of GH action logic nor used
the environmental variable because I have already started the rewriting of the wheel builds, so I will try to improve it as the new version comes to that point.


ModuleNotFoundError: No module named 'grapheneapi.grapheneclient

Traceback (most recent call last):
File "Dbot5.py", line 12, in
from grapheneexchange import GrapheneExchange
File "/usr/local/lib/python3.6/dist-packages/graphenelib-0.4.2-py3.6.egg/grapheneexchange/init.py", line 1, in
File "/usr/local/lib/python3.6/dist-packages/graphenelib-0.4.2-py3.6.egg/grapheneexchange/exchange.py", line 1, in
ModuleNotFoundError: No module named 'grapheneapi.grapheneclient'

Use a current version of graphenelib and update the code that calls it.


mapfile: fix absolute path mapping, downcase all letters

Before this commit: We include the default upstream rules file.
It remaps non-absolute files to /tftpboot/, which really means
/tftpboot/tftpboot/ since we use the --secure /tftpboot option.
After this commit:

Maintain our own mapfile. Remap non-absolute files to /,
which is really /tftpboot due to the --secure option.

Remap all filenames to lowercase. This means we do not
care whether PXE clients use uppercase or lowercase.

https://app.wercker.com/#build/54ef7c127bfa4da46421f0d4 is clean; :ship:


[DevTools / JS / Get Started / (5) Console Evaluation Is Correct]

VM1120:1 Uncaught ReferenceError: addend1 is not defined
at eval (eval at  (:1:1), :1:10)
at :1:1
This is the error which i get when i execute parseInt(addend1) + parseInt(addend2) on the console window.

duplicate of #4783


properly handle collision replace behavior

completes the item collision handling behavior in
exchange by turning replace handling into a post-delete process.

Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :sunflower: Feature

Issue(s)

#3562

Test Plan

[x] :zap: Unit test
[x] :green_heart: E2E

we will end up creating the missing item multiple times(one for each restore) as the "original' item is not available in both runs

The collision identifier should be able to track item identity across restorations to avoid duplication.  There is a strange case we could technically hit where the same item across multiple restores fails to delete its original version after creating the backup replacement, true.  But the likelihood of that happening multiple times for the same item is effectively zero unless we generate a pathological bug.
On the other hand, there's the question of how much trouble the two-step action can cause even without it being the same item each time.  And, yeah, I don't particularly like the pattern either.  Would be much nicer if graph api provided a PUT method.  Kinda stuck between two unhappy options here.  This picks one to get us moving forward, but it's a two-way door and we can always replace it with a patch if this causes distress.

The collision identifier should be able to track item identity across restorations to avoid duplication. There is a strange case we could technically hit where the same item across multiple restores fails to delete its original version after creating the backup replacement, true. But the likelihood of that happening multiple times for the same item is effectively zero unless we generate a pathological bug.

My question is a bit different. In this situation, the original file was deleted in OneDrive some time between backup and restore. Now, every time we run a restore, we will end up restoring the file as the original is never preset and our collision id is based on the id of the original file.

My question is a bit different. In this situation, the original file was deleted in OneDrive some time between backup and restore. Now, every time we run a restore, we will end up restoring the file as the original is never preset and our collision id is based on the id of the original file.

Oh, that!  That won't stick.  The id-as-placeholder is only there temporarily while we pin down the correct identifier.  Rest assured it'll be a more stable aggregation of data before we implement this handling.


automation: advanced ansible support

Summary
I would like to contribute the followings:

Introduce a dedicated ansible-collection that includes roles for high-level automation tasks.
Create a dedicated page for showcasing ansible automation use cases.

@zhijian-pro @Suave How do you guys think?

Cool, that's really helpful, please go ahead.

Really appreciate this kind of contribution!

Introduce a dedicated ansible-collection that includes roles for high-level automation tasks.

It'd help to list what you're planning to improve (or features to add) specifically, we can take a peek and give advices.
For example one may find it useful to include an ansible task to add JuiceFS mount to /etc/fstab, and there's a specific cli feature developed for that (see pending docs pr).

This following link is some of the work I've done in the past regarding ansible-galaxy-collection, so maybe we can start from here - https://github.com/techprober/galaxy-collections
cc @davies @timfeirg

If you'd like to share your ansible work that people can just grab and use, consider adding a link in community integrations or user articles, and maybe also reference them directly in other doc sections.
If you'd like to create dedicated documentation on deploying JuiceFS with ansible-galaxy, you could create a page under the "deployment" section, write in whatever language you prefer and we can help with the translation.

If you'd like to share your ansible work that people can just grab and use, consider adding a link in community integrations or user articles, and maybe also reference them directly in other doc sections as you see fit.
If you'd like to create dedicated documentation on deploying JuiceFS with ansible-galaxy, you could create a page under the "deployment" section, write in whatever language you prefer and we can help with the translation.

Thanks for the information. I will keep you guys updated along the way.

FYI we're planning on copying content from https://juicefs.com/docs/zh/cloud/automation/#ansible to CE docs, will probably put under this chapter.

Yah sure. I will contribute once I got a solid blueprint for this.


214 toast component

What is the context of this PR?
Adds Toast and ToastList components.
How to review
Review code, run tests, play with stories

Toast component looks good to me in general. Although I guess it wouldn't be a major issue in practice, wonder if we should limit the maximum number of toasts shown on the screen and queue up any extra ones. Otherwise you run the risk of having something like this.

@samiwel i can't imagine that happening in practice. In any case, I think logic for something like queuing is better placed outside of the Toast component itself, perhaps in a container component (e.g. mapStateToProps could select only the 5 oldest notifications at a time).


[Text component] Missing ellipsis when text contains line breaks (\n)

Description
Hi,
I noticed a potential bug which results in missing ellipsis when limiting lines on the Text component if passed text contains line breaks (\n).
The text is being truncated properly to the set numberOfLines but it's missing the ... at the end (ellipsizeMode set to tail).

React Native Version
0.72.6
Output of npx react-native info
Bug reproducible at https://snack.expo.dev/QXsCyRwYN
Expo 49.0
Steps to reproduce

Import React Native Text component
Use component e.g.

<Text numberOfLines={2} ellipsizeMode="tail">
  {text}
</Text>

Set text const as e.g.

const text = "Change code \n in the editor and \n watch it change on your phone!"

*The text should contain at least the same number of line breaks (\n) as the set limit in the numberOfLines prop
Snack, screenshot, or link to a repository
https://snack.expo.dev/QXsCyRwYN

The issue still exists in v0.72.6

Hello,
Thanks for the issue. I have been contributing to facebook/react-native for 4 years and specialize in the Text/TextInput components. I currently have 58 facebook/react-native PRs:
https://github.com/facebook/react-native/pulls?q=is%3Apr+author%3Afabriziobertoglio1987+
The idea was suggested from the react-native core team in this discussion .
I'm publishing several fixes for Text and TextInput component in a separate library react-native-improved.

The Component is based on ReactTextView, it is the same implementation from react-native.
It will include several bug fixes.
You can use the library until the PR is merged and released with react-native.
You can use side by side both components from react-native and react-native-improved, depending on where you need the fix.
I will also publish the PR to facebook/react-native

The advantages would be:

Increased engagement with the community, issues are quickly fixed.
No limitations when merging PRs (react-native main branch is used on facebook marketplace).
Only Meta employees can merge and review facebook/react-native PRs.
Allows us to further experiment and develop react-native.

 I'm working on a list of priorities. Thanks

I can confirm that this is still an issue on react-native 0.73.4

this is still happens on react-native 0.73.5

Ran into this issue as well! Does anyone have a good workaround?

+1

+1

+1

+1


Error when sending using private key

(error_07) Please enter a valid password. TypeError: Cannot read property 'length' of undefined

@ATouhou is the issue still happening?

I'll close this for now. Feel free to open if the issue is still persists.


Create a plugin for designing X callback URLs/links

I haven't gotten that deep into using NP URLs, but I found this tool super interesting/useful.
https://culturedcode.com/things/support/articles/2803573/
Thought that someone could write up a plugin that, through a sequence of options choices, helps you generate URLs.
https://noteplan.co/faq/General/X-Callback-Url Scheme/

https://github.com/NotePlan/plugins/tree/main/np.CallbackURLs


One or several metadata.jsonl were found, but not in the same directory or in a parent directory

Describe the bug
An attempt to generate a dataset from a zip archive using imagefolder and metadata.jsonl does not lead to the expected result. Tried all possible locations of the json file: the file in the archive is ignored (generated dataset contains only images), the file next to the archive like here leads to an error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\builder.py:1610, in GeneratorBasedBuilder._prepare_split_single(self, gen_kwargs, fpath, file_format, max_shard_size, split_info, check_duplicate_keys, job_id)
   1609 _time = time.time()
-> 1610 for key, record in generator:
   1611     if max_shard_size is not None and writer._num_bytes > max_shard_size:

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\packaged_modules\folder_based_builder\folder_based_builder.py:370, in FolderBasedBuilder._generate_examples(self, files, metadata_files, split_name, add_metadata, add_labels)
    369     else:
--> 370         raise ValueError(
    371             f"One or several metadata.{metadata_ext} were found, but not in the same directory or in a parent directory of {downloaded_dir_file}."
    372         )
    373 if metadata_dir is not None and downloaded_metadata_file is not None:

ValueError: One or several metadata.jsonl were found, but not in the same directory or in a parent directory of C:\Users\User\.cache\huggingface\datasets\downloads\extracted\f7fb7de25fb28ae63089974524f2d271a39d83888bc456d04aa3b3d45f33e6a6\ff0745a0-a741-4d9e-b228-a93b851adf61.png.

The above exception was the direct cause of the following exception:

DatasetGenerationError                    Traceback (most recent call last)
Cell In[3], line 1
----> 1 dataset = load_dataset("imagefolder", data_dir=r'C:\Users\User\data')

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\load.py:1791, in load_dataset(path, name, data_dir, data_files, split, cache_dir, features, download_config, download_mode, verification_mode, ignore_verifications, keep_in_memory, save_infos, revision, use_auth_token, task, streaming, num_proc, storage_options, **config_kwargs)
   1788 try_from_hf_gcs = path not in _PACKAGED_DATASETS_MODULES
   1790 # Download and prepare data
-> 1791 builder_instance.download_and_prepare(
   1792     download_config=download_config,
   1793     download_mode=download_mode,
   1794     verification_mode=verification_mode,
   1795     try_from_hf_gcs=try_from_hf_gcs,
   1796     num_proc=num_proc,
   1797     storage_options=storage_options,
   1798 )
   1800 # Build dataset for splits
   1801 keep_in_memory = (
   1802     keep_in_memory if keep_in_memory is not None else is_small_dataset(builder_instance.info.dataset_size)
   1803 )

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\builder.py:891, in DatasetBuilder.download_and_prepare(self, output_dir, download_config, download_mode, verification_mode, ignore_verifications, try_from_hf_gcs, dl_manager, base_path, use_auth_token, file_format, max_shard_size, num_proc, storage_options, **download_and_prepare_kwargs)
    889     if num_proc is not None:
    890         prepare_split_kwargs["num_proc"] = num_proc
--> 891     self._download_and_prepare(
    892         dl_manager=dl_manager,
    893         verification_mode=verification_mode,
    894         **prepare_split_kwargs,
    895         **download_and_prepare_kwargs,
    896     )
    897 # Sync info
    898 self.info.dataset_size = sum(split.num_bytes for split in self.info.splits.values())

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\builder.py:1651, in GeneratorBasedBuilder._download_and_prepare(self, dl_manager, verification_mode, **prepare_splits_kwargs)
   1650 def _download_and_prepare(self, dl_manager, verification_mode, **prepare_splits_kwargs):
-> 1651     super()._download_and_prepare(
   1652         dl_manager,
   1653         verification_mode,
   1654         check_duplicate_keys=verification_mode == VerificationMode.BASIC_CHECKS
   1655         or verification_mode == VerificationMode.ALL_CHECKS,
   1656         **prepare_splits_kwargs,
   1657     )

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\builder.py:986, in DatasetBuilder._download_and_prepare(self, dl_manager, verification_mode, **prepare_split_kwargs)
    982 split_dict.add(split_generator.split_info)
    984 try:
    985     # Prepare split will record examples associated to the split
--> 986     self._prepare_split(split_generator, **prepare_split_kwargs)
    987 except OSError as e:
    988     raise OSError(
    989         "Cannot find data file. "
    990         + (self.manual_download_instructions or "")
    991         + "\nOriginal error:\n"
    992         + str(e)
    993     ) from None

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\builder.py:1490, in GeneratorBasedBuilder._prepare_split(self, split_generator, check_duplicate_keys, file_format, num_proc, max_shard_size)
   1488 gen_kwargs = split_generator.gen_kwargs
   1489 job_id = 0
-> 1490 for job_id, done, content in self._prepare_split_single(
   1491     gen_kwargs=gen_kwargs, job_id=job_id, **_prepare_split_args
   1492 ):
   1493     if done:
   1494         result = content

File ~\PycharmProjects\testproj\venv\lib\site-packages\datasets\builder.py:1646, in GeneratorBasedBuilder._prepare_split_single(self, gen_kwargs, fpath, file_format, max_shard_size, split_info, check_duplicate_keys, job_id)
   1644     if isinstance(e, SchemaInferenceError) and e.__context__ is not None:
   1645         e = e.__context__
-> 1646     raise DatasetGenerationError("An error occurred while generating the dataset") from e
   1648 yield job_id, True, (total_num_examples, total_num_bytes, writer._features, num_shards, shard_lengths)

DatasetGenerationError: An error occurred while generating the dataset

Steps to reproduce the bug

Organize directory structure like in the docs:
folder/metadata.jsonl
folder/train.zip

Run load_dataset("imagefolder", data_dir='folder/metadata.jsonl', split='train')

Expected behavior
Dataset generated with all additional features from metadata.jsonl
Environment info

datasets version: 2.11.0
Platform: Windows-10-10.0.22621-SP0
Python version: 3.9.0
Huggingface_hub version: 0.13.4
PyArrow version: 11.0.0
Pandas version: 1.5.3

Also, when generated from a zip archive, the dataset contains only a few images. In my case, 20 versus 2000+ contained in the archive. The generation from folders works as expected.

Thanks for reporting, @blghtr.
You should include the metadata.jsonl in your ZIP archives, at the root level directory.
I agree that our documentation is not clear enough. Maybe we could improve it.

You can find a dummy dataset example here: https://huggingface.co/datasets/albertvillanova/tmp-imagefolder-metadata


Hostname mapping does not support mapping /

See PR for more details https://github.com/cardinal-labs/cardinal-staking-ui/pull/106

Unfortunately it has 2 shortcomings which is the domain HAS to add your pools name on the path, it will not allow for rewriting / so there is both a rewrite and redirect rule added. In addition nextJS support for importing a ESM module into next.config.js does not work so right now you have to take 1 extra step to define the hostname mapping. Eventually we will figure out a way to have all pool config in one place

This issue is to track support mapping from / without a name in the path as well as consolidating the config objects

Resolved with this PR https://github.com/cardinal-labs/cardinal-staking-ui/pull/181
Changed the way we handle custom hostnames registering domains on vercel and handling mapping the subdomain to the correct hostname with a global StakePoolMetadataProvider


Fix ref in stateless containers

This is a fix for adding the component to stateless containers, without compiled files in lib. For example, a ref issue occurs when adding to a stateless container such as the Golden Layout component. The following error is shown:
addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

Released in version 0.8.1.

Fantastic, thank you @dreyescat


Webpart doesn't render correctly

Issue
I have followed the tutorial (Add jQueryUI Accordion to your SharePoint client-side web part) and can not get the html to render into the accordion style.

I'm sure this is something that I've done wrong, but I cannot find the issue.
Here is a .txt file containing the code that I am using.
JQueryWebPart.txt

Can you open up Developer tools (F12), I suspect there is an error in your console that will provide you some information on the issue.

Does this help?

Ya you definitely have errors loading JQuery. Can you confirm you accurately followed the steps in the tutorial and didn't miss a step? Possibly an incorrect value in your config.json?

I'm pretty confident. I went through and watched the video to ensure that there wasn't anything else that I missed. I made sure to copy and paste everything to avoid any silly errors. I have put the important documents into notepad files for you to see.
JQueryWebPart.txt
MyAccordionTemplate.ts.txt
config.json.txt
I have attached a wetransfer link for you to see the files yourself. I'm not sure if this is allowed, but thought it's the best way to get them over to you
https://we.tl/t-Jol1spA4uT

Im having trouble opening the zip. Did you include the node_modules folder? If you did, could you delete that folder, re-zip it and send it again? Thanks

Yes, of course. I hope this helps!!
Let me know if this doesn't work and I'll try it on we transfer.
jquery-webpart.zip

You have a typo.

Your import should be a capital Q.
import * as jQuery from 'jquery';


Custom KFP component labels are not used to name steps

Describe the issue
A clear and concise description of what the issue is.
Node labels in Elyra were introduced to provide users with the ability to assign KFP steps / AA tasks a more meaningful value than the default component/operation name.
It appears that for KFP the user-specified value is currently not used, as shown in this pipeline, comprising two nodes, each of which is implemented by the same filter text component:

Generated graph:

To Reproduce
Steps to reproduce the behavior:

Create a KFP pipeline
Add the same custom component to the pipeline twice, assigning a custom label to each node instance.
Run the pipeline and observe the generated graph.

Expected behavior
A clear and concise description of what you expected to happen.
Deployment information
Describe what you've deployed and how:

Elyra version: 3.0/master

Looks like this should be fairly easy to implement! Luckily, KFP DSL provides a set_display_name() function for the ContainerOp object that we create during pipeline processing


Determination of pointer size is unreliable

In src/lv_misc/lv_types.h, the preprocessor logic used to determine the size of a pointer (and therefore set the typedef of lv_uintptr_t) is unreliable. The logic is based on preprocessor macros which are compiler dependant. It would be much more reliable to use the definitions provided in <stdint.h>.  Sadly, those are only available in C99 and newer, but we can check availability of this as well in the preprocessor.
The code for determining architecture should probably look like this:
#if __STDC_VERSION__ >= 199901L  // If c99 or newer...

  #include <stdint.h>

   // Use the definition of uintptr_t directly
  typedef uintptr_t lv_uintptr_t

  #if UINTPTR_MAX > 0xFFFFFFFF
    #define LV_ARCH_64
  #endif

#else
  // existing compiler-based determination
#endif

Your solution looks good to me. Can you send a pull request?

Done
https://github.com/littlevgl/lvgl/pull/1450


Add continuous integration script

We currently don't have CI working because the changes were set up but the branches were not merged into main properly.
This PR cherry picks commits from the CI branches made previously to get things working again.
Implements #58.

Tests are added properly in #47 so I've removed the tests from this branch. That makes the test command fail, just so you know what's happening @Harjot1Singh


Enable logging messages created before BuildManager.BeginBuild

Should enable https://github.com/microsoft/msbuild/pull/5007 to log places where msbuild searches for command line arguments.

Merging this since master has snapped to 16.6.


Create api variant

What happened
✅ Create the api variant
Insight

Setup localization from the Accept-Language header

Proof Of Work
Spec should pass 🌲

How about adding a few more gems that we use like fast_jsonapi and json_matchers ?


Migrate updated posting features to the new app root

As we're sunsetting gigs-board brand, changes made in #288 must be repopulated within the devhub app root

We are going to incorporate the scope of this ticket into: https://github.com/near/neardevhub-widgets/issues/469


Flow ignores dotfiles

Running flow in a project that has .eslintrc.js or any other JS dotfile will silently skip these files, even if they have the @flow pragma.
Even flow check .eslintrc.js silently fails. As a test, run flow check .test.js with the following content:
/* @flow */

const num: number = 'string'

Related #7673


Waiting for first release

Hi,
when do you plan to release the first version of caddy-ratelimit? Or do you not plan to introduce releases at all?
Regards

Haven't really had requests for it. Releases for Caddy plugins isn't always needed because you can build from any commit so easily with xcaddy or our download page. Why would you like a release?

Because if gives the user a feeling of safety. I would suggest that a release is more stable/used/tested as a continues repository.

That's just your perception though. That's not the truth. There's no practical difference between there being releases or not.
But having releases is one extra step we'd have to take every time if we start doing it. If we have one release, we need to continue making releases forever, adding a bit of work to maintaining this repo, because of how Go modules determine which git ref to use.

Yep, a release only means something if it means something. If we just tag a release but don't do anything else differently, then we're not really helping anything.


Is there a way to get the authorization token through http requests?

I'm trying to read my Outlook emails and every example has me visiting a url and signing into my account using a frontend UI. Is there a way I can do all of this through http requests instead? Where I can sign in by sending in some kind of request payload?

Closing this issue as we are archiving this repository. Please see https://github.com/microsoftgraph/msgraph-training-pythondjangoapp for a Python sample.


wrong result

If we have this format 2023-05-08T22:30:00+00:00
and want to formating this string to this format YYYY-MM-DD, the result is 2023-05-09 while I want 2023-05-08 as result . why?
moment('2023-05-08T22:30:00+00:00').format('YYYY-MM-DD'), get this result => 2023-05-09

Looks like a timezone issue. Since your input time is in UTC (+00:00), I think your machine timezone is in Tehran (+03:30), which changes the date to the next day.


[CHALLENGE SUBMISSION]

Please provide the following information for your submission:
What is your name (First, Last): Bart Billiet
Where is your GitHub Repo (with your challenge solution): https://github.com/bartbilliet/ColdStart-Challenge-2021/tree/main/challenges/challenge4/completed
What Challenge is this for (challenge number between 1 and 6): 4
(Optional) Anything else we should know? e.g., language used, location, blog post?

The webshop is published at: https://calm-forest-037926d03.azurestaticapps.net
The order tracking app is published at: https://lemon-pond-0fddb6c03.azurestaticapps.net
The driver app must be run locally, and is to be found here: https://github.com/bartbilliet/ColdStart-Challenge-2021/tree/main/challenges/challenge4/completed/DriverApp

Thanks for participating in our coding challenges ❤! To claim your Raspberry PI device, please DM me on Twitter to get the link for providing your shipping details. https://twitter.com/nicktrog

Thanks, received it today! :)


Updated the copyright

Fixed the copyright in the headers...

@bherd-rb This PR can be approved as is.  Note that I did not change the headers for the files that you have contributed.


Fix scala type check

Running mvn scala:doc-jar gave the error:
ScioOperator.scala:37: error: overloaded method value key with alternatives:
14:02:22 [INFO]   [T](x$1: String, x$2: com.spotify.flo.TaskBuilder.F0[T])com.spotify.flo.TestContext.Key[T] <and>
14:02:22 [INFO]   [T](x$1: String)com.spotify.flo.TestContext.Key[T]
14:02:22 [INFO]  cannot be applied to (String, () => com.spotify.flo.contrib.scio.ScioOperator.Mocking)
14:02:22 [INFO]   private val MOCK = TestContext.key("mock", () => new Mocking())

Explicitly declaring the lambda as a TaskBuilder.F0 type fixes that

@danielnorberg ptal

This seems to be due to scaladoc not picking up the -Xexperimental argument.

I think the real fix is this https://github.com/spotify/flo/pull/122

Closing in favor of #122


Strange Behavior on Modal (Only in the ios)

I noticed an error in Modal, the modal simply disappears a few times, the error only occurs if the "transparent" attribute is set to true. In the emulator it is easier to see it happen.
I am using the latest version of React Native: 0.63.2
React Native version: 0.63.2
Steps To Reproduce

Create an simple modal like (It is important that it is always visible and transparent):

<Modal
        transparent={true}
        visible={true}
      >
            <View style={{ flex: 1 }}>
                <Text>I am the modal content!</Text>
            </View>
</Modal>

Install in the ios emulator, check if you started with the modal open, now save the file where the modal is to cause an update in the app. Keep saving the file to force the app to update, in my emulator the Modal is disappearing and reappearing, with each save I give it disappears and in the next save it reappears.

Expected Results
The expected results are that it will never be "gone". When I change the "transparent" attribute to "false", the error goes away.

@pedrohcdo The same thing happens to me, but slightly different scenario.
In my case it doesn't mind if the modal is transparent or not. It happens all the time when I just closed previous modal.
So it goes like this:

I have 2 modals in my render function, one of them is invisible.
When I close the first one it gets invisible, the second is now visible.
The expected behavior is that the second modal appears, but it's not.

When I'll have some more time I'll try to make some repro project.

@pedrohcdo The same thing happens to me, but slightly different scenario.
In my case it doesn't mind if the modal is transparent or not. It happens all the time when I just closed previous modal.
So it goes like this:

I have 2 modals in my render function, one of them is invisible.
When I close the first one it gets invisible, the second is now visible.
The expected behavior is that the second modal appears, but it's not.

When I'll have some more time I'll try to make some repro project.

Try the @miotplugin answer,
Change this file React/Views/RCTModalHostViewManager.m  with this commit https://github.com/facebook/react-native/pull/29953/commits/47fd3489db3086d560209bd78641b45d74194200

@pedrohcdo The same thing happens to me, but slightly different scenario.
In my case it doesn't mind if the modal is transparent or not. It happens all the time when I just closed previous modal.
So it goes like this:

I have 2 modals in my render function, one of them is invisible.
When I close the first one it gets invisible, the second is now visible.
The expected behavior is that the second modal appears, but it's not.

When I'll have some more time I'll try to make some repro project.

i have the same error; but in my case, 2nd modal not appear if 2 modals set transparent, and if i set transparent=false is work;  and if i evoke 2nd modal use setTimeout(timeout = 0) is work...
is there any solution?

The same error occurs for me as well on iOS. The Modal is not visible if I have set transparent to true.

My first Modal is set to true and then to false, if any text is clicked
Second Modal is set to true when the first one is invisible.
Also the error occurs frequently for me. Any solution for this?

For me the this error was caused because i was having one modal visible and I was making another modal visible without closing the one.


In FireFox 35.1 the beforeRender is called twice

I have defined a beforeRender my extended view from the backbone.layoutmanager and noticed that in FireFox 35.1 the beforeRender is called twice.

That sounds like a bug! Can you share a reduced script that demonstrates the problem?

This problem is caused in FireFox by the cancelAnimationFrame(), which caused that the finish() is still called once, while canceled.
Scenario
created a mainView and and childView,
The childView should take longer to render than the mainView
render both views quckly after each other.
The mainView will finish earlier qnd it will cancel the childviews RAF using cancelAnimationFrame()
and call the finish for the child directly (from _registerWithRAF)
This will work fine in Chrome, but in FireFox, the finish() will still be handled from the RAF!
Trace Chrome:
Register RAF: MainView
Register RAF: ChildView
Finish: MainView
render: MainView
Cancel RAF: ChildView
Register RAF: ChildView
Finish: ChildView # directly called from _registerWithRAF()
render: ChildView
Trace FireFox:
Register RAF: MainView
Register RAF: ChildView
Finish: MainView
render: MainView
Cancel RAF: ChildView
Register RAF: ChildView
Finish: ChildView  # directly called from _registerWithRAF()
render: ChildView
Finish: ChildView  # Called from the RAF !!!!!!!
render: ChildView
If added a test in test set
// https://github.com/tbranyen/backbone.layoutmanager/issues/463
asyncTest("Test if before render is called twice in FireFox, because cancelAnimationFrame is not working properly", 1, function() {
var count = { before: 0 };
var ChildView = Backbone.Layout.extend({
	viewName: 'ChildView',

	beforeRender: function(){
		count.before++;
	},

	render: function(){
		wait();
	},

	wait : function() {
		for (var i = 0; i++; i <<PHONE_NUMBER>999) {
			var c;
			c += Math.cos(12) * Math.sin(4) / Math.PI;
		}
	},
});
var childView = new ChildView();

var MainView = Backbone.Layout.extend({
	viewName: 'MainView',

	beforeRender: function() {
		this.addChildView();
	},

	addChildView: function() {
		new Backbone.Layout().insertView(childView).render();
	},
});

new MainView({ model: new Backbone.Model() }).render();
childView.render().then(function() {
	childView.once("beforeRender", function(){
		equal(count.before, 1, "beforeRender is called more than once");
		start();
	})
});

});

i change the test a little bit to be able to stop the test for Chrome. (the second childView render does not come for Chrome)
// https://github.com/tbranyen/backbone.layoutmanager/issues/463
asyncTest("Test if before render is called twice in FireFox, because cancelAnimationFrame is not working properly", 1, function() {
var count = { before: 0 };
var ChildView = Backbone.Layout.extend({
	viewName: 'ChildView',

	beforeRender: function(){
		count.before++;
	},

	render: function(){
		wait();
	},

	wait : function() {
		for (var i = 0; i++; i <<PHONE_NUMBER>999) {
			var c;
			c += Math.cos(12) * Math.sin(4) / Math.PI;
		}
	},
});
var childView = new ChildView();

var MainView = Backbone.Layout.extend({
	viewName: 'MainView',

	beforeRender: function() {
		this.addChildView();
	},

	addChildView: function() {
		new Backbone.Layout().insertView(childView).render();
	},
});

new MainView({ model: new Backbone.Model() }).render();
childView.render().then(function() {
    var timeoutID = setTimeout(stopAndValidateTest, 400);
	childView.once("beforeRender", function(){
		clearTimeout(timeoutID);
		stopAndValidateTest();
	});
});

function stopAndValidateTest()
{
	equal(count.before, 1, "beforeRender is called more than once");
	start();
}

});

issue can be closed, it was not caused by FireFox, but cause in my own application code, where the child view was rendered 2 times.


fix: patch reanimated to fix crash when using useAnimatedScrollHandler()

Small patch that makes sure animatedRef is a function before calling in regards to https://github.com/bluesky-social/social-app/issues/2185
This seems like a check that should be there in any case, but there could also be something else with the implementation. This is mainly just a reference as to what's causing the issue 👍

Thanks for looking into it! I think this should do: https://github.com/bluesky-social/social-app/pull/2195

Really appreciate the assists @haileyok


Openj9 11.0.6 for Windows x86 is missing (hotspot still provides one)

Hi,
I'm wondering that, despite the effort the OpenJ9 team made for supporting 32bit Windows with the splitheap option (which makes it rather unique for using large heaps on that platform), exactly that build is missing for the Java 11 platform.
Could this be added again?
Thanks!

@patric42 I came here wanting the same. See https://github.com/eclipse/openj9/issues/8773


3007.0 - salt-master seems to have plenty of breakage.

Describe the bug
3007.0 salt has breakage ... this is mostly just some notes that might help someone get things working.
to install python mysql module try:
salt-pip install mysqlclient

if using eauth_acl_module: alcali
you will want to update an import.
try:
    import salt.ext.six as six
except ImportError:
    import six

if using 'rest_cherrypy' i had seen logs on master like:
[TRACE   ] Request POST Data: {'password': 'xxxxxxxxx', 'username': 'admin'}
[DEBUG   ] Using selector: EpollSelector
[DEBUG   ] Authentication module threw Cannot run the event loop while another loop is running
[TRACE   ] Process manager iteration
[WARNING ] Authentication failure of type "eauth" occurred.

to hack around the "cannot run the event loop" "error" putting the following at the top of  /opt/saltstack/salt/lib/python3.10/site-packages/salt/auth/__init__.py gets the "Salt WebSocket" returning OK on the webpage.
# first run: salt-pip install nest_asyncio
import nest_asyncio
nest_asyncio.apply()

At this point i hit a wall. The "Salt WebSocket" is returning OK but I see no minions.

Hi
since salt version 3006 netapi have new config parameters in master config file
netapi_enable_clients:

local
local_async
local_batch
local_subset
wheel
runner
runner_async

hope that help !

@jpisard yep im using netapi_enable_clients
strange that im seeing these issues. The test system has ubuntu22.04, I'll give it another test using ubuntu24.04.

same issues on ubuntu24.04. However did confirm that using the /run view works! I was able to send a test.ping to minions and see the return data.
however views like jobs, minions, events fail.
XHRGET
http://alcali :8088/api/minions/
[HTTP/1.1 500 Internal Server Error 77ms]
Uncaught (in promise) Error: Request failed with status code 500

logs in salt-api and salt-master not giving any good hints that I'm able to follow.

ah after running in debug mode i noticed had my database incorrectly setup.
working now.
So the takeaway is if using rest_cherrypy you likely still need that nest_asyncio hack but his should be reported to the salt devs so it can be fixed for the 3008.0 LTS... shrug.. resolved.


Adapt to Coq 8.16

I've tried what I can, but I now hit an assertion error, and I'm out of my waters…

done, I pushed your branch to this repo now


Create a community page for Apinf

New Apinf frontpage will contain a link to a community page that invites others to contribute to the project.

Discourse added as a discussion portal for community.


Add static weights for rule sorting

This succeeds #786 by adding more test cases and using a slightly more complicated rule.
Fixed pallets/flask#331, #185, #652 & #727
CC @davidism

The failing tests doesn't seem to be concerned with this PR.

Right, something seems to be off with PyPy and cryptography. Don't worry about those tests.

Thanks. I will pull this.


update the vendored functions

The vendored functions have become out-of-date.

[x] Closes #100
[ ] Tests added
[x] Passes isort . && black . && flake8
[ ] User visible changes (including notable bug fixes) are documented in changelog.rst

no tests, yet, but I guess for that I would need to refactor __main__ (I imagine using pytest to test a cli to be really difficult) – see #3 and #46


Fixed #35145 -- Corrected color scheme of vanilla HTML widgets in admin.

Ticket
https://code.djangoproject.com/ticket/35145
Description
The Django Admin uses some unstyled vanilla HTML widgets in a few cases.  In these cases, those elements are displayed with the browser's default "light mode" styles, even when dark mode is enabled. This PR adds the color-scheme property and sets it to light when in light mode , and dark when in dark mode.
Screenshots
Before the changes

After the changes

@erosselli Hi, and thank you for your work! Please remember to set the proper Trac flags in the ticket as described in patch checklist when this is ready for review.

How do we normally test colors in Django?

We don't :upside_down_face: I don't mind merging it with neither.

@erosselli Thanks :+1: Welcome aboard :boat:

@nessita could you explain what you are expecting as far as tests for this pull request? It’s the addition of a CSS property to existing declarations, to change colors. How do we normally test colors in Django?

Hey @thibaudcolas, originally I set the flag "needs_tests" in the ticket because Eliana submitted the PR with this comment:

--- This PR is in draft mode because it's missing some tests ---

so I was making sure the proper flags were set on the ticket. We don't test colors as Mariusz mentioned.

Thank you 👍 Is this something we could update the docs for then? @erosselli and I have spent a fair bit of time on Submitting patches, and weren’t sure how to approach the requirement for tests described in:

[…] A good patch should also include a regression test to validate the behavior that has been fixed and to prevent the problem from arising again. […]

The unit tests page linked here has info about JavaScript tests – perhaps we can add something about CSS on there?

Thank you 👍 Is this something we could update the docs for then? @erosselli and I have spent a fair bit of time on Submitting patches, and weren’t sure how to approach the requirement for tests described in:

[…] A good patch should also include a regression test to validate the behavior that has been fixed and to prevent the problem from arising again. […]

The unit tests page linked here has info about JavaScript tests – perhaps we can add something about CSS on there?

Maybe, yes! I'm not 100% sure what we would add though, would you have any suggestion?


Plugin Support for OpenSearch

AWS has released OpenSearch with ALv2 license: https://github.com/opensearch-project/OpenSearch
Is there any plan to support this analyzer for OpenSearch ?

@soosinha To support OpenSearch, we just build and test the plugin for Elasticsearch 7.10.2 is enough, isn't it?

@soosinha I've created the repo https://github.com/duydo/opensearch-analysis-vietnamese for supporting OpenSearch, but maven cannot find  dependencies, can you please look at it?

@duydo Thanks for taking the OpenSearch changes. Currently AWS team is working publishing OpenSearch to public maven repos. So maven is not able to find OpenSearch dependency. We need to build and publishly OpenSearch locally to resolve this. This process is mentioned here: https://github.com/opensearch-project/opensearch-plugins
I have created a pull request to update the documentation: https://github.com/duydo/opensearch-analysis-vietnamese/pull/1
There are still some compilation failures after resolving the OpenSearch dependency issue. Can you look into those ?

@soosinha Sure, I'll look at it.
Btw, I'll close this ticket. Any issues relates to OpenSearch should be opened on opensearch-analysis-vietnamese repo.

@soosinha I've just fixed the compilation failures and updated the repo, now it is able to compile.


Reformat plugin is misbehaving with spaces

The autoformat plugin is formatting code like this:
    expect(
            bigqueryRpcMock.open(
                new com.google.api.services.bigquery.model.Job()
                    .setJobReference(JOB_INFO.getJobId().toPb())
                    .setConfiguration(LOAD_CONFIGURATION.toPb())))
        .andThrow(ex);

That is, it is indenting code eight spaces on continuation lines, possibly in concert with Eclipse. I'm not sure why.

Issue raised in google-java-format: https://github.com/google/google-java-format/issues/430.

As noted in ticket raised -- this is expected formatting behavior. https://github.com/google/google-java-format/wiki/FAQ#google-java-format-always-follows-the-rectangle-rule-right-no-exceptions


chore: update api url to phrase.com

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @amardon for your contribution!


Test with JDK 19-ea+7

It looks like Gradle cannot run a Java 19 toolchain for some reason... I'll need to dig a bit.
Hey @DavideD I see reactive is still using Gradle 6.9, which is kinda old (May 2021). Any plans to upgrade soon-ish? (see releases)

I've sent a PR for Gradle 6.9.2:
https://github.com/hibernate/hibernate-reactive/pull/1170

I've sent a PR for Gradle 6.9.2: #1170

Ok, thanks. I guess upgrading to 7.x was too much work?
I rebased on main, let's see how it goes.

6.9.2 was fast and easy. I will check if we can upgrade to 7 soon

Merged via https://github.com/hibernate/hibernate-reactive/pull/1177


HidOverUDP

I wonder how to use HidOverUDP to detect software solos.
I tried the "software" way and my solo sw is listening on udp/8111.
~$ solo version
0.0.24

solo$ ./main
[DEBUG] Using UDP backing
state file exists
[ERR] Current firmware version address: 0x556e63ef61f0
[ERR] Current firmware version: <IP_ADDRESS> (<IP_ADDRESS>)
[STOR] Auth state is initialized
[STOR] pin not set.

~$ ss -uapn
State  Recv-Q Send-Q          Local Address:Port     Peer Address:Port Process
UNCONN 0      0                     <IP_ADDRESS>:8111          <IP_ADDRESS>:*     users:(("main",pid=4997,fd=3)

>>> from solo import fido2
>>> fido2.force_udp_backend()

>>> import solo
>>> solo.client.find()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/h8h/.local/lib/python3.8/site-packages/solo/client.py", line 52, in find
    raise solo.exceptions.NoSoloFoundError("no Solo found")
solo.exceptions.NoSoloFoundError: no Solo found

The following works:
>>> a = fido2.HidOverUDP("localhost:8111")
>>> a.Write(0xff)

I received:
[ERR] ctaphid.c:500: ignoring random cont packet from 0000

But this is not very convenient :)

I'm not sure I understand.  why isn't it convenient?  What is it not convenient for?

Excuse me for not making myself clear.
I want to use python-solo with all of its commands like
solo ls  # lists all Solo keys connected to your machine
solo version  # outputs version of installed `solo` library and tool


Integrate Concurrent HCL containers into ChronoLog repo

the code for concurrent HCL containers that Aparna implemented live on the feature branch of HCL repository.
We need to bring theim into the ChronoLog repository and incorporate into the build

HCL is also developed in our group by Hari. Currently, HCL is added to a submodule to ChronoLog from a forked repo under scs-lab. We, specifically Jaime and Anthony, have the full control of the forked repo under scs-lab. For better development in the future, we need to release Aparna's changes in the scs-lab/hcl and point the submodule to it.

pending hcl team review and approval

this is only for git repo, not any code changes

@ibrodkin @aparnasasidharan2017 I accidentally updated the HCL repo in my current branch for API stuff. Since this is a minor update in the submodule. I put it also in PR#44. Pls take a look.
FYI, the submodule in ChronoLog repo is linked to the dev branch of this HCL repo from scs-lab: https://github.com/scs-lab/hcl. As you can see from its title, it is forked from Hari's private repo at https://github.com/hariharan-devarajan/hcl. Itself is forked from HDF-group's repo, which we do not need to care about.

merged into develop


Guard entry with if __name__ == '__main__' incantation.

Commits in this PR

Guard entry with if __name__ == '__main__' incantation.

PR chain

#427 Set default params for NO_GUI_DEV_MODE.
#428 Refactor controller_debug's debug command.
#429 Sort includes in controller_debug.py.
#430 controller_debug: Print help for trace.
#431 Fix typo: seperate -> separate.
#432 Add readline to list of imports.
#433 Get rid of most "global" statements.
#434 Get rid of crc16 global variable.
👉 #435 Guard entry with if __name__ == '__main__' incantation. 👈 YOU ARE HERE
#436 Add documentation for exec command.
#437 Tighten up trace documentation a bit.
#438 Use argparse for trace download and console.

Merged


metadata ingestion example throws avro encoding error.

Describe the bug
running the metadata ingestion throws avro encoding error.
To Reproduce
Steps to reproduce the behavior:
follow the exxample steps from here: https://github.com/linkedin/datahub/tree/master/metadata-ingestion and you should see the following error
 mce-cli git:(master) python mce_cli.py produce -d bootstrap_mce.dat Producing MetadataChangeEvent records to topic MetadataChangeEvent. ^c to exit. Traceback (most recent call last):   File "mce_cli.py", line 108, in <module>     main(parser.parse_args())   File "mce_cli.py", line 88, in main     produce(conf, args.data_file, args.schema_record)   File "mce_cli.py", line 32, in produce     producer.produce(topic=topic, value=content)   File "/Users/jsenjaliya/Library/Python/3.7/lib/python/site-packages/confluent_kafka/avro/__init__.py", line 80, in produce     value = self._serializer.encode_record_with_schema(topic, value_schema, value)   File "/Users/jsenjaliya/Library/Python/3.7/lib/python/site-packages/confluent_kafka/avro/serializer/message_serializer.py", line 107, in encode_record_with_schema     schema_id = self.registry_client.register(subject, schema)   File "/Users/jsenjaliya/Library/Python/3.7/lib/python/site-packages/confluent_kafka/avro/cached_schema_registry_client.py", line 217, in register     body = {'schema': json.dumps(avro_schema.to_json())}   File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/__init__.py", line 231, in dumps     return _default_encoder.encode(obj)   File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/encoder.py", line 199, in encode     chunks = self.iterencode(o, _one_shot=True)   File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/encoder.py", line 257, in iterencode     return _iterencode(o, 0)   File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/encoder.py", line 179, in default     raise TypeError(f'Object of type {o.__class__.__name__} ' TypeError: Object of type mappingproxy is not JSON serializable
Expected behavior
should have ingested some sample records.
Desktop (please complete the following information):

OS: MAC 10.14

Additional context
avro python library is not compatible with confluent kafka library.

I also face this issue.. it's python 3.7 version compatibility with python Avro lib.
please let me know if you need this fix
@jhsenjaliya

@animeshinvinci @jhsenjaliya has already submitted a PR fixing this: https://github.com/linkedin/datahub/pull/1605 Could you check and see if it's the same fix you have?


Saving/Updating a page is saved chronologically

Is your feature request related to a problem? Please describe.
Lately if you check the options page, you will notice all the the URLs stored and displayed are in chronological order, with respect to the URL of the saved/updated page. For example, if you save several pages of, say, www.github.com, they will be saved together in a group rather than been separated in other convenient order as per they were saved.

Describe the solution you'd like
What really is needed, for better user convenience, is that the URLs should be saved in an order as per the time they were saved/updated. Where the list is sorted in ascending order of the time, rather than the chronological order of the URL.
Describe alternatives you've considered
Primarily, I feel that this could be sorted in the save.js file, where you create a new Date() object for every new URL saved.
Additional context
Here is the screenshot with the URLs been displayed for better understanding, please note that all these pages were saved over a different span of time. The user would be more interested in the most recent articles rather than the chronologically arranged articles, that's why this issue has been opened.

Hey, I submitted a PR for another issue. Can I work on this as well?

Hi @YuvrajSharma07 , if the issue is still open, I'd like to work on it. I think I'll be able to implement a solution.

Yeah sure!

Hello, @YuvrajSharma07
I've opened a PR that fixes this issue, kindly have a look at #83


MethodStreamManager: Type Mismatch in onTimeout callback for closeAllStreams() Method

Describe the bug
When a connection with a stream that has a controller defined in the endpoint gets cut, the closing errors out instead of being handled gracefully causing all the cancel or addWillCloseListener not to run. Specifically, the error is:
2024-10-02 13:15:35.798186Z Internal server error. Zoned exception.
type '() => void' is not a subtype of type '(() => Future<Null>?)?' of 'onTimeout'
#0      Future.timeout (dart:async/future_impl.dart:925:54)
#1      MethodStreamManager.closeAllStreams.<anonymous closure> (package:serverpod/src/server/websocket_request_handlers/helpers/method_stream_manager.dart:169:38)
#2      MappedListIterable.elementAt (dart:_internal/iterable.dart:425:31)
#3      ListIterator.moveNext (dart:_internal/iterable.dart:354:26)
#4      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189:27)
#5      new _GrowableList.of (dart:core-patch/growable_array.dart:150:28)
#6      new List.of (dart:core-patch/array_patch.dart:39:18)
#7      MethodStreamManager.closeAllStreams (package:serverpod/src/server/websocket_request_handlers/helpers/method_stream_manager.dart:175:23)
#8      MethodWebsocketRequestHandler.handleWebsocket (package:serverpod/src/server/websocket_request_handlers/method_websocket_request_handler.dart:89:33)
<asynchronous suspension>

To Reproduce
To reproduce the behavior create the following endpoint, listen to it on from the app and then quit the app.
class PokemonStreamEndpoint extends Endpoint {
  // ensure that the user is logged in (serverpod functionality)
  @override
  bool get requireLogin => true;

  // Stream Methods
  final pokemonStreamController = StreamController<PokemonDTO?>.broadcast(
    onCancel: () {
      print(" CANCELLING POKEMON STREAM");
    },
    onListen: () {
      print("LISTENING TO POKEMON STREAM");
    },
  );

  Stream<PokemonDTO?> pokemonStream(Session session) {
    return pokemonStreamController.stream;
  }
}

Expected behavior
The code should execute without a type mismatch, allowing the onTimeout function to run without causing an error.
Screenshots
If applicable, add screenshots to help explain the problem.
Serverpod versions

CLI Version: [2.1.3]

Additional context
This error is related to differences between void and Future<Null>, possibly due to a mismatch in Dart SDK expectations vs Serverpod implementation.

Any plans for shipping a hotfix for this?
As long as the PR is not released, all close-listener streams will not work if a broadcast stream is involved


Nested Text nodes do not render margin or padding in their layout

Summary
I'm trying to intend a nested list (ul > li > ul) using Text with paddingLeft applied. On nested Text nodes neither margin or padding seems to be applied to the layout. I'm not totally sure if this is a bug or if this is the expected behavior with the relative Text layout (but it still seems less than ideal).

Example
https://rnplay.org/apps/5_STOQ
Versions
I'm using 0.23.1, but the issue is also present in RNPlay using 0.24.1. I'm not sure about 0.25.0.
Platforms
iOS, Android
Development env
OSX

This is due to the way nested text renders (for convenience). Think of nested text as inline elements and the (most) outer text to be a block element.
You can use Views to get the same effect, it's just the text is not nested:
<View style={styles.ul}>
  <Text style={styles.li}>
    {BULLET}
    item one
  </Text>
  <Text style={styles.li}>
    {BULLET}
    item two
  </Text>
  <View style={[styles.ul, styles.nestedUl]}>
    <Text style={styles.li}>
      {BULLET}
      nested one
    </Text>
    <Text style={styles.li}>
      {BULLET}
      nested two
    </Text>
  </View>
</View>

https://rnplay.org/apps/vf1slA


Prepare for localization automation

First, we need to keep the id's up to date…

Cleanup SPA templates slightly

add missing descriptions
add id for postActions
add and correct $schema properties
generalize vs-2017.3.host.json filename to ide.host.json

Add templatestrings.*.json files

step 3/4 (yeah, not just of 3) for https://github.com/dotnet/aspnetcore/issues/36998 in this repo
without this, id's are not automatically kept up to date
see https://github.com/dotnet/templating/wiki/Localization
see also dotnet/aspnetcore#38867 (a similar update in dotnet/aspnetcore)

Move existing translations from old files to new

{lang}/strings.json to templatestrings.{lang}.json

Remove redundant strings.json files

templatestrings.{lang}.json files are enough
see also dotnet/aspnetcore#40128 (a similar update in dotnet/aspnetcore)

You probably want to add displayName property to all the parameter-type symbols as well.

@mkArtakMSFT @adityamandaleeka @rafikiassumani-msft, I could do this but it would be pretty blind. Should we wait i.e. defer to follow-ups from your teams, split between teams now, or go w/ my blunders for now❔

Thanks for handling this, @dougbu!
I'm wondering if a faster way would be to merge this and get CTI to report all the issues where the localization didn't work?

@MackinnonBuck what do you think will take to get this change validated? I mean, how much time will it require?

In terms of speed, adding .../displayName properties might not take that much time. We have less than 50 strings in src/content/Angular-CSharp/.template.config/localize/templatestrings.en.json and src/content/React-CSharp/.template.config/localize/templatestrings.en.json combined and a lot of the symbols look like duplicates.
Having CTI complain about "ExcludeLaunchSettings instead of Exclude launch settings" also doesn't seem viable since this PR shouldn't change the lack of display names in the template.json files. Why haven't they complained about what's displayed in VS before❔

They did and you see several such issues linked from the issue tracking the localization work.

I see the issues linked to #36998 but nothing sounds similar to the "ExcludeLaunchSettings instead of Exclude launch settings" case @bekir-ozturk described. Is that because CTI hasn't been looking at the two SPA templates❔

Not sure where that option is exposed, so they may have not seen it either or may have simply missed.

You probably want to add displayName property to all the parameter-type symbols as well. Otherwise, the symbol ExcludeLaunchSettings will show up in VS as ExcludeLaunchSettings instead of Exclude launch settings.

I see minimal use of displayName in the dotnet/aspnetcore repo. Is it true that the property matters only for parameters made visible by ide.host.json❔ Just want to make sure I catch all the places where we need display names.

[ ] name and description properties (these will be pulled in from templatestrings.json.
[ ] learn more link can be removed, it is no longer used
[ ] uiFilters section can be removed - no longer uesed
[ ] supportedAuthentications can be removed - no longer used.. we just use the "auth" in the template.json
[ ] ports - no longer used - we use the port generators in template.json
[ ] excludeLaunchSetttings - no longer used
[ ] minFullFrameworkVersion - no longer used.

If I'm understanding correctly, the ide.host.json files are now short enough we don't need more displayName settings in template.json files.

In the dotnetcli.host.json files, can "shortName": "" be removed❔ I'm guessing that means the same thing as leaving the property out.

I'm not seeing what you suggest @phenning. It instead appears like longName is what matters for dotnet new e.g.
> dotnet new angular -h
...
Template options:
  -au, --auth <Individual|None>    The type of authentication to use
                                   Type: choice
                                     None        No authentication
                                     Individual  Individual authentication
                                   Default: None
  --exclude-launch-settings        Whether to exclude launchSettings.json in the generated template.
                                   Type: bool
                                   Default: false
  --no-restore                     If specified, skips the automatic restore of the project on create.
                                   Type: bool
                                   Default: false
  -P, --ProxyPort <ProxyPort>      Port number to use for the SPA front-end development proxy.
                                   Type: integer
  --no-https                       Whether to turn off HTTPS. This option only applies if Individual, IndividualB2C,
                                   SingleOrg, or MultiOrg aren't used for --auth.
                                   Type: bool
                                   Default: false
  -uld, --use-local-db             Whether to use LocalDB instead of SQLite. This option only applies if --auth
                                   Individual or --auth IndividualB2C is specified.
                                   Type: bool
                                   Default: false
  -f, --framework <net5.0|net7.0>  The target framework for the project.
                                   Type: choice
                                     net7.0  Target net7.0
                                     net5.0  Target net5.0
                                   Default: net7.0
  --use-program-main               Whether to generate an explicit Program class and Main method instead of top-level
                                   statements.
                                   Type: bool
                                   Default: false

So, the worst bug here is w/ --ProxyPort versus --proxy-port and I'm not going to worry about it because the short and long names in the CLI aren't localized. That's something others on @mkArtakMSFT's team can handle, once they check the CLI and VS in more detail.

Oddly @bekir-ozturk's approval isn't enough. Could someone else please approve❔


Don't reuse the first issue to file a regression even though a regression issue is already filed

Regression issues should be managed in other new issues. Otherwise discussion and issue management will be confused. Therefore you should use #28523 instead of #26247.

We'll do this when appropriate to clear up confusion, but don't need it to be a blanket policy. Thanks for the feedback!


Cannon alignment issue

cannon does not point directly at the cursor when cursor is below or above the center line.

Fixed


Internal: Release (or press) a number of buttons in one action

Describe the feature
An action to release a range of buttons simultaneously either as a list (1,3,4,7,8,10) or as a range (1-5) or ideally both (1-3,6,9-10). Perhaps the ability to use logic too so an inclusion and exclusion list can be made.
Usecases
When using eventmaster instance to load presets to preview I like to be able to visually track which button has been pressed by using latched keys with colour changes, if the standby is changed I need to select a different key which would release whichever other key is currently latched. For a whole page of presets this currently requires up to 28 actions (full page less page up, down, name and a take key).
This is clearly an extreme case but would be very useful from my own POV for Eventmaster, Spyder, Watchout, disguise at least for speed of programming as shotbox.

Nice workaround - simple but effective 👍🏻


[Excel] (Custom functions) Associate call is no longer necessary unless you hand-author JSON

I got rid of the "best practices" article because we could consolidate information into other areas instead!

Docs Build status updates of commit b974e74:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/excel/custom-functions-batching.md
:warning:Warning

Details

docs/excel/custom-functions-json-autogeneration.md
:warning:Warning

Details

docs/excel/custom-functions-json.md
:warning:Warning

Details

docs/excel/custom-functions-overview.md
:warning:Warning

Details

docs/excel/custom-functions-parameter-options.md
:warning:Warning

Details

docs/excel/custom-functions-save-state.md
:warning:Warning

Details

docs/excel/custom-functions-troubleshooting.md
:warning:Warning

Details

docs/excel/custom-functions-web-reqs.md
:warning:Warning

Details

docs/excel/custom-functions-requirements.md
:warning:Warning

Details

docs/excel/custom-functions-runtime.md
:warning:Warning

Details

docs/quickstarts/excel-custom-functions-quickstart.md
:warning:Warning

Details

docs/excel/make-custom-functions-compatible-with-xll-udf.md
:warning:Warning

Details

docs/excel/custom-functions-architecture.md
:warning:Warning

Details

docs/excel/custom-functions-debugging.md
:warning:Warning

Details

docs/excel/custom-functions-localize.md
:warning:Warning

Details

docs/excel/custom-functions-naming.md
:warning:Warning

Details

docs/toc.yml
:warning:Warning

Details

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-best-practices.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

docs/excel/custom-functions-batching.md

Line 219: [Warning] Invalid file link:(~/excel/custom-functions-best-practices.md).

docs/excel/custom-functions-json-autogeneration.md

Line 315: [Warning] Invalid file link:(~/excel/custom-functions-best-practices.md).

docs/excel/custom-functions-json.md

Line 14: [Warning] Invalid file link:(~/excel/tutorials/excel-tutorial-create-custom-functions.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 03f04e7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/excel/custom-functions-json.md
:warning:Warning

Details

docs/quickstarts/excel-custom-functions-quickstart.md
:warning:Warning

Details

docs/toc.yml
:warning:Warning

Details

docs/excel/custom-functions-architecture.md
:white_check_mark:Succeeded

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded

docs/excel/custom-functions-best-practices.md
:white_check_mark:Succeeded

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json-autogeneration.md
:white_check_mark:Succeeded

docs/excel/custom-functions-localize.md
:white_check_mark:Succeeded

docs/excel/custom-functions-naming.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded

docs/excel/custom-functions-requirements.md
:white_check_mark:Succeeded

docs/excel/custom-functions-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-save-state.md
:white_check_mark:Succeeded

docs/excel/custom-functions-troubleshooting.md
:white_check_mark:Succeeded

docs/excel/custom-functions-web-reqs.md
:white_check_mark:Succeeded

docs/excel/make-custom-functions-compatible-with-xll-udf.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json.md

Line 14: [Warning] Invalid file link:(~/excel/tutorials/excel-tutorial-create-custom-functions.md).

docs/quickstarts/excel-custom-functions-quickstart.md

Line 113: [Warning] Invalid file link:(~/excel/custom-functions-best-practices.md).

docs/toc.yml

Line 0: [Warning] Invalid file link:(~/excel/custom-functions-best-practices.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6fa5535:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-architecture.md
:white_check_mark:Succeeded

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded

docs/excel/custom-functions-best-practices.md
:white_check_mark:Succeeded

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json-autogeneration.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json.md
:white_check_mark:Succeeded

docs/excel/custom-functions-localize.md
:white_check_mark:Succeeded

docs/excel/custom-functions-naming.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded

docs/excel/custom-functions-requirements.md
:white_check_mark:Succeeded

docs/excel/custom-functions-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-save-state.md
:white_check_mark:Succeeded

docs/excel/custom-functions-troubleshooting.md
:white_check_mark:Succeeded

docs/excel/custom-functions-web-reqs.md
:white_check_mark:Succeeded

docs/excel/make-custom-functions-compatible-with-xll-udf.md
:white_check_mark:Succeeded

docs/quickstarts/excel-custom-functions-quickstart.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 61a0850:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-architecture.md
:white_check_mark:Succeeded

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded

docs/excel/custom-functions-best-practices.md
:white_check_mark:Succeeded

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json-autogeneration.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json.md
:white_check_mark:Succeeded

docs/excel/custom-functions-localize.md
:white_check_mark:Succeeded

docs/excel/custom-functions-naming.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded

docs/excel/custom-functions-requirements.md
:white_check_mark:Succeeded

docs/excel/custom-functions-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-save-state.md
:white_check_mark:Succeeded

docs/excel/custom-functions-troubleshooting.md
:white_check_mark:Succeeded

docs/excel/custom-functions-web-reqs.md
:white_check_mark:Succeeded

docs/excel/make-custom-functions-compatible-with-xll-udf.md
:white_check_mark:Succeeded

docs/quickstarts/excel-custom-functions-quickstart.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


selection.select and data inheritance.

I'm hesitant to open this as an issue because I know the behaviour of having selection.select inherit data from corresponding nodes in the parent selection is totally deliberate.  But I think it's at least worth discussing so here goes.
This side effect of select is something that confused me when I was first starting out with d3.  And I regularly find myself explaining the behaviour to colleagues who are surprised by it.  These explanations never seems to stop at the "what happens" but invariably continue into queries of "why would it do that"?  I take this repeating pattern as a red flag that there is a rough edge in the API.
I think the confusion stems from 2 points:

The term select has strong connotations of being read-only from popular usage in SQL and other query languages.  This seems to run pretty deep for people (myself included).
All other instances of select and selectAll in d3 besides selection.select are read only.

I understand that changing this would be a pretty severe backward compatibility break, but just as a thought experiment, do you see any other issues with the following?:

Make all select/selectAll operations to be read only only.
Introduce selection.update(selector) to handle the update workflow where you truly do want to propagate data across nodes. This would essentially work just like selection.select does today.

It's maybe not as seamless but there is something nice (to me) about having mutating operations be explicit even if it means sacrificing some convenience.
BTW, I posted a StackOverflow question a little while ago, but that was more targeted at techniques for working around practical issues we were hitting.  It adds some relevant context to this topic, though, so here's a link.

In the d3-graphviz library there is never a 1-to-1 relationship between parents and children and it is never  the case that the parent and child are bound to the same data. Thus the propagation of data is never desired.
Since the application where I use d3-graphviz frequently wants to access nodes and edges of the generated graph without affecting bound data, I've added an extension to d3-selection, selection.selectWithoutDataPropagation which does d3.select(this.node().querySelector(name))
I also added a note to the library documentation to avoid the use of selection.select when building applications with d3-graphviz in order to avoid propagating incorrect data by mistake.
Would you we willing to accept a PR to d3-selection adding this function? If so, would you prefer a different name, e.g selectPure?
Even if this function is simple enough to implement outside d3-selection, its pure existence would further highlight that selection.select does more than just pure selection.


Product install fails when run under System account

Cookbook version
4.2.1
Chef-client version
13.2.20
Platform Details
Windows Server 2008 R2
Scenario:
Trying to install 'WDeploy36' package with webpi cookbook.
Steps to Reproduce:
Add webpi_product resource with install action to cookbook and update on Chef Server.  Next scheduled run of chef-client will pickup new resource and attempt to run under System account.
Expected Result:
Product is installed successfully.
Actual Result:
Product install fails with errors:
Chef Log:

Install completed (Failure): 'Web Deploy 3.6'
WDeploy_Only_3_6 : Failed.
Error opening installation log file. Verify that the specified log file location exists and is writable
...
Web Deploy 3.6                                     False
Log Location: C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\Web Platform Installer\logs\install\2017-08-02T12.46.29\WebDeploy_amd64_en-US.txt
...

Further notes:
If I run chef-client as my user the install completes successfully.  I expect it has something to do with permissions to the System temp directory.

Found an old post with more details -
https://stackoverflow.com/questions/29723429/chef-webpi-cookbook-fails-install-in-azure

It's a bit strange because an MSI error 1622 refers to a problem writing a log file.  Which is strange because it should be writable by SYSTEM.  If you know of a specific workaround we can look at making changes to the cookbook.  I'll try and carve out some time to give it a test myself.

The SO link I posted yesterday has the workaround.  THanks!

This workaround is a bit intrusive as it temporarily changes the AppData path for all users but does set it back to the default after the WebPI install.  That being said the alternative is to ask WebPI package authors to update their packages to respect the log path.  Many of these package authors are long gone or have moved on to other work and are not likely to fix it.  We could make this an optional step and force consumers to explicitly choose to enable it to avoid unintended consequences.
WebPI is a very common package manager on Windows, and I think its important to make this situation easier for those new to Chef on Windows.


Add dependency information for including in project.

Added dependency information for Maven and SBT so that it is easier for the developers who are new to the library.

Hi @satendrakumar06,
Sorry about the slow response on this PR.
We've actually moved away from including the latest version number in the README because it quite a manual process to update it each release, and it often was out of date.
Instead, we have added the buttons:

Which link to a search on the Maven repository. When you click through to a particular version, you get to info for each of the build tools:

Unfortunately, this isn't very discoverable. Perhaps we could include some instructions on this process in the README as a compromise? WDYT?

@retronym Thanks for response.
I agree it makes sense to not include the exact versions. In order for people to know we can add a line that once you click on the button then you would reach the repo.

FWIW, I was just about to submit a PR doing the exact same thing. Buttons aren't really the default in the community and thus surprising. You also can't cmd-f for them...

@retronym Should I close this pull request ?

Sorry about the delay, I'd forgotten about this PR. I've merged it and will figure out a way to keep the version up to date.

@retronym Thanks


Datagrid[ExpandableRows]: expanded area should be tr element

What package(s) are you using?

[X] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.

The expanded area should be a tr element, currently our expanded area is div. As we're going through the expandable row design reviews, prepping for release reviews, this seems like an appropriate time to make this update.

Is this issue related to a specific component?

Datagrid

What did you expect to happen? What happened instead? What would you like to
see changed?

Expect expanded area to be a tr

What browser are you working in?

Chrome

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?

Latest

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

N/A
Steps to reproduce the issue

Step one
Step two
Step three
etc.

Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/github/carbon-design-system/ibm-products/tree/main/examples/carbon-for-ibm-products/SidePanel

Additional information

Screenshots or code
Notes

Completed in https://github.com/carbon-design-system/ibm-products/pull/3551 and https://github.com/carbon-design-system/ibm-products/pull/3550


Livewire Uncaught (in promise) ReferenceError: L is not defined

When including the component inside a livewire component with an @if tag, the component throws a Uncaught (in promise) ReferenceError: L is not defined in the console and fails to render the rest of the page.
It works inside the livewire component if not inside an @if tag.
I'm guessing this has to do with the order the scripts are loaded? Any help would be hugely appreciated. Thanks!

Hi! Thx for creating an issue.
I have not yet tried to do any livewire things with this package.
Maybe livewire does not like the script tag that is included in the component?
what you could do is instead of
@if(someCondition) <x-maps-leaflet></x-maps-leaflet> @endif
do this:
<x-maps-leaflet class="@if(someCondition) display-none @endif"></x-maps-leaflet>
A test repository would help identifying what is going wrong.
Do you know how to set that up?

The issue was fixed by including the
<script<EMAIL_ADDRESS>
after the livewire scripts at the bottom of the page. It must be to do with the order they are loaded.

Cool, thx for getting back and posting your solution.
In the future we might include a default livewire component.
Closing the issue for now.