[SPARK-11937][SPARK-11922][PYSPARK][ML] Python api for ml.feature.quantile discretizer

Add Python API for ml.feature.QuantileDiscretizer.
One open question: Do we want to do this stuff to re-use the java model, create a new model, or use a different wrapper around the java model.
cc @brkyvz & @mengxr

Test build #47026 has started for PR 10085 at commit 2540101.

Test build #47026 has finished for PR 10085 at commit 2540101.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol):\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47026/
Test FAILed.

Test build #47030 has started for PR 10085 at commit 1145ec4.

Test build #47030 has finished for PR 10085 at commit 1145ec4.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol):\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47030/
Test FAILed.

Test build #47031 has started for PR 10085 at commit 2afd197.

Test build #47031 has finished for PR 10085 at commit 2afd197.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol):\n

Merged build finished. Test PASSed.

cc @yanboliang who filed the JIRA for this.

Can you please only link to the specific JIRA, not the umbrella?

Hi @holdenk, I think the PR is duplicated with mine: https://github.com/apache/spark/pull/10007

OK, I was not realized that there is an umbrella JIRA for this. I'll close mine.

@holdenk For your questions, I first tried to modify the interface of Bucketizer, making it to a JavaModel other than a JavaTransfomer. But I finally decided not to touch the Bucketizer, and added a inner class of QuantileDiscretizerModel to get the splits.
But I recommend to test the getSplits of Bucketizer that generating from the QuantileDiscretizer, since I got a serialization error, and I added a getJavaSplits to avoide it. JIRA issue here.

I vote for make Bucketizer to a Model rather than Transformer which is consistent with Scala code. @yinxusen Could you explain the reason that you give up this scenario?

@yanboliang I am OK to change Bucketizer to a JavaModel. At that time I just do not want to change that piece of code. That's also why I closed my PR because I think @holdenk's implementation is better. But like what I said, be careful with getSplits. :)

Ok - just to make sure do you see any issues with the current approach for getSplits? Its tested a bit in the doctests but if there is a potential issue I can add some more tests.

@holdenk No more issue in getSplits. It looks good.

@yinxusen thanks :)

cc @yanboliang if you have a chance to take a look

re-ping @yanboliang or @jkbradley if you've got the time to look at this (already been reviewed a bit).

Test build #48495 has started for PR 10085 at commit 601a9ea.

Test build #48495 has finished for PR 10085 at commit 601a9ea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48495/
Test PASSed.

Merged build finished. Test PASSed.

Test build #49177 has started for PR 10085 at commit 798798c.

Test build #49177 has finished for PR 10085 at commit 798798c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49177/
Test PASSed.

Merged build finished. Test PASSed.

re-ping @jkbradley ?

I'll try to check this soon, but have some others first.  It will be great if someone else can review this PR in the meantime.  @yinxusen Would you have time?  Thanks!

@jkbradley I'll help you reviewing this.

@jkbradley LGTM except for the version labels.

@yinxusen /@jkbradley updated the version added tag to 2.0.0 :)

Test build #49534 has started for PR 10085 at commit 5e18778.

Test build #49534 has finished for PR 10085 at commit 5e18778.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49534/
Test PASSed.

LGTM as well! Thanks.

Those are the only issues I see.  Thanks everyone for reviewing & @holdenk for the PR!

Test build #49694 has started for PR 10085 at commit f21ebef.

Test build #49694 has finished for PR 10085 at commit f21ebef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49694/
Test PASSed.

Merged build finished. Test PASSed.

Test build #49719 has started for PR 10085 at commit f9e3086.

Test build #49719 has finished for PR 10085 at commit f9e3086.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49719/
Test FAILed.

Test build #49726 has started for PR 10085 at commit 194ec6d.

Test build #49726 has finished for PR 10085 at commit 194ec6d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49726/
Test PASSed.

Merged build finished. Test PASSed.

Think I addressed all of @jkbradley's comments

Test build #50015 has started for PR 10085 at commit 463aa37.

Test build #50015 has finished for PR 10085 at commit 463aa37.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50015/
Test FAILed.

Merged build finished. Test FAILed.

seems unrelated, jenkins retest this please.

Test build #50037 has started for PR 10085 at commit 463aa37.

Test build #50037 has finished for PR 10085 at commit 463aa37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50037/
Test PASSed.

Merged build finished. Test PASSed.

LGTM
Merging with master
Thanks for the PR!


Clarify formValueSelector docs intro

Inspired by #1699. I remember I was initially confused too on first read. I think this makes the sentence subject formValuesSelector more explicit when mentioning the concept of a selector api.

Codecov Report

Merging #3236 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3236   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          68      68
  Lines        1519    1519
======================================
  Hits         1519    1519

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 066e753...2f7ea7d. Read the comment docs.


Fix minor typo "remaining" in README

Fixes a minor typo in the README.
Great project, and thanks for the inspiration section! Haha.
cc @rwz

Thanks!


[Feature]: Add tooltip properties for form input widgets

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Users would like to see tooltip option for following widgets - Text / Input / Select / MultiSelect
Why should this be worked on?
This should be an easy solve with good value addition. One of our customers has brought this to our attention.

Radio Group


electron density on 3D grid

Dear Mihail,
I am Chenru Duan, a graduate student at Prof. Heather Kulik group at MIT. I read your NatComm2020 paper about predicting the DFT/CC energies with electron densities and found it very interesting! Impressive work! It is also very kind of you that you open-sourced the code and dataset to let other people play with it. I am able to reproduce the results using your code and plug it into a workflow that I am building up. But I have a  question related:
I am a bit puzzled by the electron density file (dft_densities.npy) that you shared, especially by the fact that the density contains negative values in the 3D tensor and that one cannot see the shape of a water molecule in it. Is there any post-processing step needed from the raw valence electron density to derive the density you uploaded?
Thanks in advance,
Chenru

Thanks to the reply of Mihail from another channel, where he clarifies that the tensors in the density files are actually those transformed to the Fourier series.


Use alternate icon for mainnet build

get the latest full color logo from https://decred.org/brand/

@raedah I updated the icons for App Store. Can I share them here?


Issue with k8s.io/docs/tutorials/hello-minikube/

This is a Bug Report

Problem:
Some command ouputs are out-of-date (from an old version minikube). We need to update the command outputs with current version minikube (v1.5.2) to avoid confusion.

The output for "minikube addons list" is outdated. e.g. "coredns" is not a default addon in current version minikube.

The output for "kubectl get pod,svc -n kube-system" is incorrect.
"service/kubernetes-dashboard" is no longer in kube-system namespace. It's in its own namespace kubernetes-dashboard and should not be listed in this output.

Proposed Solution:
Update the command output example with current version minikube.
I can assign this issue to myself and update this page with my new minikube environment.
Page to Update:
https://kubernetes.io/docs/tutorials/hello-minikube/

/assign

Thanks @chenxuc
/kind cleanup

update is merged.


Fix Issue 16206 - traits getOverloads fails when one of the overload is a templatized function

Spec change for https://github.com/dlang/dmd/pull/8195

CircleCi failure is unrelated and sorry for the unexpected problems.
The fix and explanation is here -> https://github.com/dlang/dlang.org/pull/2371


Bug fix/recalculate count (#11759)

Scope & Purpose
Fixed a bug in the internal recalculateCount() method that could lead to count adjustments being applied with the wrong sign.
Added tests.

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This PR adds tests that were used to verify all changes:

[x] Added new integration tests (i.e. in scripts/unittest recovery)

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10256/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10261/

Tests blue except unrelated knowd failures on Windows.


FID Evaluation not matching paper results for VQ-16 checkpoint

Hi! Thanks for the great repo. I've tried reproducing some of your numbers on ImageNet val (256x256) and specifically the rFID isn't matching, both for your checkpoint and for a tokenizer I've trained with your settings.
With your VQ-16 I get:
PSNR: 20.793026, SSIM: 0.675290 (this matches your paper exactly)
Inception Score:<PHONE_NUMBER>9160156
FID: 4.284650117003025
sFID: 5.144700494258814
Precision: 0.73054
Recall: 0.6533
(the model-based evals are systematically worse than the results in your paper)
After re-running your training script and performing eval, I get:
PSNR: 20.625670, SSIM: 0.664614
Inception Score:<PHONE_NUMBER>3242188
FID: 4.243560592613846
sFID: 5.425596037757714
Precision: 0.72864
Recall: 0.6552
(very similar to your results)
Given that the PSNR/SSIM match exactly, I believe I'm producing the reconstructions and npz files correctly. For running the evaluator, my command looks like:
python evaluator.py ~/assets/VIRTUAL_imagenet256_labeled.npz VQ-16-flatdataset-size-256-size-256-codebook-size-16384-dim-8-seed-0.npz

Could you advise where I've gone wrong? I'm just using the OpenAI evaluation code provided in this repository. Thanks!

An update, when using the clean-fid repo (which I trust more than OpenAI evals), I get an rFID score of 2.11, which is actually lower than the reported number in the paper. I'm curious what exact evaluation commands/scripts you used to produce the numbers in your paper?
Thanks :-)

Hi~
Please first generate val.npy by runing val.sh, which contains 50k imagenet validation images. Then replace VIRTUAL_imagenet256_labeled.npz with val.npz

This worked for me, thanks! I have separate problems replicating LlamaGen-B results, but I'll make that a separate post.


Add missing implementation

I believe you need to include this in the dependencies list because the lib is imported here:
https://github.com/boundstate/capacitor-branch-deep-links/blob/master/android/src/main/java/co/boundstate/BranchDeepLinks.java#L5
I had a conversation in Android United on slack about this here:
https://android-united.slack.com/archives/C0406TZT5/p1572942522027200
Without this, jetifier can't correctly identify the import over in BranchDeepLinks.java and do its magic re-writing for androidx support.
I suppose to verify, you need to migrate your whole project to androidx which might be a bit of a beast.

Hmm - I thought this had fixed the issue, but now I'm not so sure.  My project is migrated to androidX.  I am still getting this error when building my app.
error: package android.support.annotation does not exist

I'll keep investigating...

Thanks for the pr, I'm on vacation currently but I can try help investigate when I'm back in a few days

We're already using the appcompat library, and says in the annotations docs:

If you're using the appcompat library, you do not need to add the support-annotations dependency. Because the appcompat library already depends on the annotations library, you have access to the annotations.

Have you checked out the answers to this StackOverflow issue that sounds related? Unfortunately I don't have experience with androidx or the use case.

You're definitely right. This had something to do with my build process.
Thanks for the excellent plugin!  You might consider adding it to the list of capacitor community plugins.


~/.sparrow dir created despite use of --dir

I'm trying to run two instances of Sparrow 0.9.9, one each for mainnet and testnet. To keep them segregated, I run the testnet instance like so (on Ubuntu Desktop 20.04.1):
/opt/sparrow/bin/Sparrow --dir /home/user/.sparrow-testnet --network testnet

Most files then get created in /home/user/.sparrow-testnet -- but it still creates a directory /home/user/.sparrow with one file sparrow.log.
Shouldn't the log file also go in the specified --dir?

Indeed! Fixed in d722c49

Indeed! Fixed in d722c49


Allow adding import statement after existing imports

Describe the feature
Currently imports added (with $add) prepends before any other import statements in the file. There's also a TODO to consider appending instead:
https://github.com/unjs/magicast/blob/7b3f0bd9bdbc07d7c66408645a5dcd309511119e/src/proxy/imports.ts#L155-L165
It would be nice if we can add import statements after existing imports.

There's a comment at https://github.com/unjs/magicast/issues/45#issuecomment-1506670632 that suggests adding $append and $prepend to all the nodes. Maybe we can apply the same idea for .imports only for now?

I'm trying to migrate Astro to use this, but I think this issue is the only blocker before it's ready: https://github.com/withastro/astro/pull/11772. There's other new lines formatting difference, but I think it's not a big deal.
Additional information

[X] Would you be willing to help implement this feature?

Yeah sure! $append and $prepend sounds good to me.


Project logs are output to the project folder instead of the specified folder.

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; <IP_ADDRESS>13) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)
Issue description
This is my project folder.

This is my Log Path setting. Didn't change it.

If you start Godot.exe as an administrator, no logs will be generated in the project folder (but I don’t know where they are). But I haven't started it as an administrator in the past few months and haven't seen this behavior. This is what I just discovered today.
Steps to reproduce
Create a new project and start it.
Minimal reproduction project
N/A. This problem occurs in all new projects I created, as well as old projects that have not been touched for several months.

Given the file names, these are actually logs for the Godot editor instance itself, and not for the game specifically. So the path configured in project.godot isn't used here, that one is for when you run the game itself (you should be able to find those logs in %APPDATA%\Godot\app_userdata\<Game Name>).
But I don't know where those editor logs come from. The naming pattern doesn't seem familiar, as Godot usually adds a suffix with ISO formatted timestamps, like this: godot2023-08-02T14.39.36.log
CC @bruvzg @KoBeWi

same here , suddenly appeared yesterday, i did nothing but update Windows 11

If you use Project > Open Project Data Folder at the top of the editor, do you end up in a folder that has a logs folder inside?

If you use Project > Open Project Data Folder at the top of the editor, do you end up in a folder that has a logs folder inside?

Yes, this is what I got.
C:\Users\TypeAlpha\AppData\Roaming\Godot\app_userdata\RuntimeFeeCollector

This is the contents of the "logs" folder.

I have started this project in administrator mode before, but I don't remember if the modification time of this log matches the startup time.

I'm having the same issue, normal project logs are generated at the specified file path, but these strange log files are also generated inside the project folder.
These log files are generated when you open a project file or debug a game. However, when you run Godot in administrator mode, these logs don't seem to be generated.
By the way, these log files do not seem to open properly, and commonly used encoding formats will show garbled characters.
Also, if you export the game in exe, these log files are also generated in the game floder when the packaged game is not running in administrator mode.

See also:

https://github.com/godotengine/godot/issues/79098

#79098 is definitely the same issue.
Both involve weird log files in project folder that contain garbage.
Both are fixed by running as administrator.
And another detail is that all reports come from Chinese version of Windows.
I think we had similar issue in Lumencraft; I don't remember the exact details, but it affected Chinese players and the solution was running the game in administrator mode.
The logs seems to be specific to a certain language version of Windows and they don't look like coming from the engine. Not sure what we should do on our side to avoid it.

It does indeed seem to not be related to Godot as such
Might be related to debugging or something with visual studio

Out of curiosity, which Windows edition are you using? Press Windows + R and enter winver to see. (If this doesn't suffice, you'll have to navigate to the system settings to find an "About your PC" section or similar.)
Windows 10 exists in 3 standard editions, aside of pro/enterprise/education:

Windows 10
Windows 10 N ("no codecs")
Windows 10 Single Language

Like Windows 10, but you can't change language after installation.

I believe windows 10 Single Language is relatively prevalent in China, which may explain this.

I'm using Windows 11 Home Chinese ( Single Language )

which Windows edition are you using?

@Calinou This is what I got.

I can't reproduce this and I'm using Windows 10 Home. Some users can also reproduce this on Windows 11 Pro for Workstations edition. So probably not related to Single Language.
#79098 provided some of those log files, but they are actually binary files and I don't recognize the format.

Seems like Godot create this file.

If you try to delete the latest Log, it will prompt that GodotEngine is occupying it.

I solved this problem on my computer. Here is what i do.
I find that the problem disappeared when Renderer switched from Forward+ to Compatibility. So I think there must something with vulkan.
I use Process Monitor to find what process created the log file.

And when i find the Stack information, i find the CrossVulkanLayer do this.

This layer is used by WeGame. I uninstall WeGame, and the issue fixed.

Seems confirmed by WeGame (League of Legends client in China by Tencent).
But why this file is created by Godot, does it affect the normal process of Godot?

It's true, and my problem disappeared after uninstalling WeGame (Goodbye League of Legends).
However, if players with WeGame installed on their computers still generate this log after my game is packaged, is there any way to avoid this problem? Almost every League of Legends player in China will install WeGame.

Maybe we can try disabling that layer for the editor at least.

It's almost certain that WeGame's vulkan implicit layer has a problem.
These strange log files are not only generated in Godot's project files, in fact, other applications that call Vulkan produce similar log files, such as steam.
This is what my steam folder looks like now.

So I recommend that people who have this problem check other folders and clean up these garbage logs.

Might be something to report up-stream if it's a vulkan issue

Upstream here would likely be the WeGame developers, as their implicit Vulkan layer seems to be bad / unnecessarily affecting non WeGame applications.

First, this is a WeGame bug.
Second, that doesn't mean there's nothing we can do.
All layers (implicit and explicit) can be found via vkEnumerateInstanceLayerProperties.
We currently use that function to enable the explicit layers we want (validation).
Due to the number of complaints, in this PR https://github.com/KhronosGroup/Vulkan-Loader/pull/984 the Vulkan Loader was updated to support filtering out implicit layers via the env variable VK_LOADER_LAYERS_DISABLE.
See Layer Filtering.
We can do the same: Review all layers, find known problematic ones, and set the env variable VK_LOADER_LAYERS_DISABLE before creating the instance.
And if that doesn't work (e.g. the loader required us to have the env. variable set much earlier), we can do the following (upon detecting problematic layers):

Log this situation and say that "Godot will attempt to relaunch itself with VK_LOADER_LAYERS_DISABLE=blahblah godot.exe"
Set the environment vars.
Relaunch ourselves w/ "VK_LOADER_LAYERS_DISABLE=blahblah godot.exe"

The main reason for logging first is that if relaunching fails, the user experience is horrible because all they will see is that double clicking the icon does nothing (the app will launch and close itself before even a window appears).

Hey guys, does this issue fixed?

And there is no WeGame on my PC

The issue is still open so it isn't fixed
If it happens to you even without WeGame that's something to investigate, but could simply be that something else uses the same layers

We currently use that function to enable the explicit layers we want (validation).
Due to the number of complaints, in this PR KhronosGroup/Vulkan-Loader#984 the Vulkan Loader was updated to support filtering out implicit layers via the env variable VK_LOADER_LAYERS_DISABLE.
See Layer Filtering.

Thanks, i use this env variable VK_LOADER_LAYERS_DISABLE, it successfully solves the problem of generating useless logs.
For me, the steps to solve the problem are:
(window 11, wegame)

Enter Vulkaninfo in CMD to display Vulkan's waring, and then copy the layer that was be warned(like: VK_LAYER_TENCENT_wegame_cross_overlay)

Add VK_LOADER_LAYERS_DISABLE = VK_LAYER_TENCENT_wegame_cross_overlay to the env variable

Restart godot

So, it will not output this log files, but only outpupt warnning like: Layer "VK_LAYER_TENCENT_wegame_cross_overlay" forced disabled because name matches filter of env var 'VK_LOADER_LAYERS_DISABLE'. At least this won't output annoying log files


ci: fix the checkout action on the release workflow

:tada: This PR is included in version 1.0.0-dev.1 :tada:
The release is available on:

v1.0.0-dev.1
GitHub release

Your semantic-release bot :package::rocket:


As a CIF user, I can submit changes to any attribute of a project, with a reason for the change

Description:
The project_revision table will allow us to draft and record revisions/amendments to a project. Storage of projects history will use a hybrid delta/snapshot approach:

A project revision should only contain the delta of records changed, i.e. form_change records should only be created for the forms that are updated within a project revision. This will prevent the creation of unnecessary "update" records, and will make summarizing revisions easier (i.e. displaying a list of the entities changed in a revision without showing the details)
A project revision's form_change records contain a snapshot of each form, facilitating insertion, validation and retrieval with jsonschema-form

Acceptance Criteria:
Given that I am viewing the "view" page for a project
When I click the "Amend Project" button
Then a new project revision is started, and I am redirected to the edit form
Given that I am viewing the "view" page for a project
When a project revision for this project is in progress,
Then
a message explaining that a project amendment was started
and a "Resume project amendment" button
are displayed
Given that I am viewing the "edit" form for a project
When I edit the input for any project attribute
Then the new values are saved as a "pending change"
Given that I am viewing the "edit" form for a project
When I edit the input for any project attribute
Then I can enter a "reason" for the changes
Given that I am viewing the "edit" form for a project
and I edited the input for any project attribute
When I enter a "reason" for the changes
Then the "Submit" button is enabled
Given that I am viewing the "edit" form for a project
When I click the "Discard Project Amendment" button
Then the project_revision and its changes are deleted
Development Checklist:

[ ] a required "change reason" box on the edit page

[ ] computed columns for project revisions should either return the form_change for the current project revision, or the form_change for the previous project revision if it does not exist.

[ ] the forms should use an "upsert" mutation on change, that creates a form_change if it does not exist, and updates it otherwise.

[ ] deletion of records (e.g. contacts) should be handled and tested

[ ] revisions can be resumed

[ ] revisions can be discarded

Meets the DOD

Personas:

Program Development Team
Operations Team
Tech Team

Notes :

Adding applicable Personas to the ticket
Program Development Team - CIF Persona
Operations Team - Persona
Tech Team - CIF Persona

Hey team! Please add your planning poker estimate with ZenHub @AlexZorkin @dleard @pbastia

Copied the attached wireframes to ticket #240.

I think I've tried to test to early. Has this been pushed to dev yet?

Operators: I was able to edit and save changes; discard changes
Contacts: I was able to edit, save changes; discard changes
Projects: I didn't see an edit button?

Other observations:

Contacts: when I go to edit a contact, all the pre-populated contact info is removed and all fields are blank. I'm not sure if this is because that was our generated data or if it is a bug? As a user, I might not be updating all fields and would expect the previous information to be displayed until I edited.
Contacts: After I made an update, I couldn't find that contact in the contacts table. For example, I updated a contact to have the name as Bob the builder. But I couldn't find that contact using the filter.

Looks like this deployed after you posted your message. #275 prevented it from deploying automatically.
Operators and Contacts edition was done earlier, so it's not part of this issue.

Contacts: when I go to edit a contact, all the pre-populated contact info is removed and all fields are blank. I'm not sure if this is because that was our generated data or if it is a bug? As a user, I might not be updating all fields and would expect the previous information to be displayed until I edited.

Yes, this will be fixed in #301. For this reason you won't be able to edit one of the pre-made projects

Contacts: After I made an update, I couldn't find that contact in the contacts table. For example, I updated a contact to have the name as Bob the builder. But I couldn't find that contact using the filter.

You have to refresh the page for things to update in the table, this will be fixed with #285

Thank you @matthieu-foucault ! Looks great.
Tested in dev:

Entered new project, then edited by updating project status, and Tech Team primary project manager. Worked as expected.
Edit an existing project (i.e., one that was pre-existing, used project "test project 006), received a 500 error.

Overall observations:

As a user, it wasn't clear to me that I was on the 'edit' page after selecting the edit button as the page title remains as "Project Overview". It would be nice to make that more clear in the heading (or some other mechanism)
The 'reason for change' box/field wasn't present - are we pulling that into a separate issue/ticket?
order of project managers listed in table and on project overview page don't match order on the create/edit pages for a project

Team provided updated at this mornings stand-up: the system wasn't designed to allow edit on the 'existing data' as it isn't true data. The comments field will be included in another ticket as opposed to this one due to some design questions and it made more sense to include it at that time.


[BUG] taskbar image too small

I compare version 2.6.x vs 2.7.x and most of the icons looks the same,
but taskbar image shrines down:

Thanks! You might maybe want to check my older files (which I've created by myself), to compare. Anyways, it might be related to SVG's padding, in my specific case, so you should definitely check it on some default icons. Anyway, it's not a big deal for me, generated icons are in any case better than doing the same thing manually :)

hey:)
i publish new version (2.8.0) that solve the small icon problem,
and also trim the image so the transparent padding will not affect the icons size.
the .svg format is deprecated for now, but there are few more other format, please se the CHANGELOG
hope its will help, thank you 👍


Bokeh plot does not show up in VBox (and possibly other containers)

Using this simple script with 2 plots, the first one appears normally, but the other one inside a tabbed VBox does not; if the second one is moved out of the VBox, it appears as second tab normally. This is an adapted MWE based on with_bokeh.py:
import numpy as np
from bokeh.plotting import figure
from flexx import app, ui, event
from flexx.pyscript import window

N = 1000
x = np.random.normal(0, np.pi, N)
y = np.sin(x)+np.random.normal(0, 0.2, N)
p1,p2=figure(),figure()
p1.scatter(x,y)
p2.scatter(x,y)

class Example(ui.Widget):
    def init(self):
        with ui.TabPanel():
            self.plot1=ui.BokehWidget(plot=p1, title='Scatter 1')
            with ui.VBox(title='Container'):
               self.plot2=ui.BokehWidget(plot=p2, title='Scatter 2')

if __name__ == '__main__':
    m=app.launch(Example)
    app.start()

Reproduced. Thanks!

The example now looks likt this, and the issue is still there:

import numpy as np
from bokeh.plotting import figure
from flexx import app, ui, event
from flexx.pyscript import window

N = 1000
x = np.random.normal(0, np.pi, N)
y = np.sin(x)+np.random.normal(0, 0.2, N)
p1,p2=figure(),figure()
p1.scatter(x,y)
p2.scatter(x,y)

class Example(app.PyComponent):
    def init(self):
        with ui.TabLayout():
            self.plot1 = ui.BokehWidget.from_plot(p1)
            with ui.VBox(title='Container'):
                self.plot2 = ui.BokehWidget.from_plot(p2)

        self.plot1.set_title('Scatter 1')
        self.plot2.set_title('Scatter 2')

m=app.launch(Example)
app.start()

With #465 (to be merged), the Bokeh plot also has a minimum size. A HBox will still not fill the widget up if it has a flex=0 though. So either use VFix, or self.plot2 = ui.BokehWidget.from_plot(p2, flex=1).


Documents should mention this!

If your code activity don't have any input parameters, you cannot select the step for debug!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ae2bca0-76de-3f98-b0e7-65a137baafa2
Version Independent ID: eb803d04-bddc-0c43-3dcb-110187fbf379
Content: Debug Workflow Activities (Common Data Service) - Power Apps
Content Source: powerapps-docs/developer/common-data-service/workflow/debug-workflow-activites.md
Service: powerapps
GitHub Login: @JimDaly
Microsoft Alias: jdaly

Fair enough.
But let me ask you: Why create a custom workflow activity with no input parameters?
Wouldn't a plug-in serve the same purpose?

As there is no further response, closing this issue.


Mobile view: the language icons are split to two lines

I wonder if we should decrease the size of the language icons for mobile view

I don't think this is something we can effectively solve.
Because these language icons are interactive, it is good practice to give them a large enough size for mobile users to click. It's pretty unavoidable that these will wrap to another line, and bumping the size down is not a guaranteed fix for all mobile phones, nor will it work once we add Go support (meaning another icon will be added).

Re-verified, looks like the line wrapping doesn't occur on current iPhones which have a width of 375px


Investigate memory corruption when using tarfs

When switching out an ext2 ramdisk for a tar ramdisk, an issue rather consistently shows up when launching the compositor, causing crashes and even complete corruption of the VM environment. Initially, the tarfs driver itself was suspected, but a thorough analysis has cleared it of any wrongdoing - bounds checking and strict limits on copy lengths all checked out.
To start investigating this issue, I built a new set of memory allocation tracking tools. After several revisions and improvements to these tools, I believe the issue is has been narrowed down to a corruption of memory used for kernel stacks, as well as corruption of memory used for file descriptor tables (the latter may be caused by the former, it's hard to tell). The addition of guard pages around kernel stacks suggests that something - possibly page directory management - is touching regions it should not be touching.

This was a fun one.
After extensive investigation in GDB and the QEMU monitor, it was discovered that the compositor was getting mappings to low physical memory (where the kernel resides) when it called sbrk. Further investigation showed that the physical frame bitmap had been cleared. This eventually led to the discovery of a bug in the ramdisk freeing code, which was freeing frames it did not full own (and which had been allocated through the placement pointer allocator... to the frame bitmap). ext2 ramdisks were always a multiple of page size. The tarfs ramdisks are only multiples of 512, so there was a 1 in 8 chance everything would be fine.

10:49:35 <... klange> So I do this thing on my CDs where I take a read-only
                      ramdisk and extract it out into my in-memory read-write
                      tmpfs.
10:49:57 <... klange> Obviously if I have a ~20MB ramdisk, I want the space
                      that was used to hold that to be available for the
                      system after the move to the read-write tmpfs.
10:50:14 <... klange> So naturally I clear out the frames it was using so they
                      can be reclaimed by the pmm.
10:50:33 <... klange> I recently switched to using tarballs for those
                      ramdisks, from mini ext2 filesystems.
10:50:42 <... klange> The tarballs are easier to create and have less overhead.
10:51:09 <... klange> An interesting property of the ext2 filesystems is that
                      they were always a multiple of page size, due to block
                      requirements in ext2.
10:51:16 <... klange> Tarballs are only multiples of 512 bytes.
10:52:19 <... klange> The tarfs ramdisks are the last thing that gets loaded
                      by the bootloader, and the early placement pointer
                      allocator starts immediately afterwards.
10:52:36 <... klange> And the next that gets allocated is... the page frame
                      bitmap.
10:52:44 <... klange> That the pmm uses... for allocations...
10:53:34 <... klange> So everything's fine until the startup says "okay you
                      can remove the ramdisk now I'm done with it" and the
                      kernel goes and frees... the frame with the start of the
                      frame bitmap.
10:54:10 <.. klange> Which then gets reallocated to something stupid like a
                     bitmap with a font in it.
10:54:29 <.. klange> Which then marks larges swaths of the kernel as available
                     for the PMM.


Add 25 HCTSA Algorithms to BAP

| Category | HCTSA Function | Randall Function Name | Input Timeseries | Input Parameters | Output Parameter
-- | -- | -- | -- | -- | -- | --
1 | Top5 | FC_Surprise | How Suprised? | HR | (default) | out.mean
2 | Top5 | SB_MotifTwo | Probability of successive Increases | HR | (binarizeHow = ‘diff’) | out.uu
3 | Top5 | PH_Walker | STD of random walk | SpO2 | (walkerRules = ‘momentum’, walkerParam = 2) | out.sw_stdrat
4 | Top5 | EX_MovingThreshold | Average Threshold | HR | (a = .25, b = .1) | out.meanq
5 | Top5 | EX_MovingThreshold | Average Threshold | SpO2 | (a = .25, b = .1) | out.meanq
6 | Centroid | CO_tc3 | Correlation HR mean | HR | tau = 1 (tc3 didn't work on HR   with their options I edited code to allow for custom tau. Description on   function made it seem that was acceptable) | out.denom
7 | Centroid | DN_cv | Distribution HR SD (CV?) | HR | k = 3 | out
8 | Centroid | DN_Cumulants (skew2) | Distribution HR skewness | HR | cumWhatMay = 'skew2' | out
9 | Centroid | DN_Quantile | Distribution HR max | HR | p = .99 | out
10 | Centroid | ST_LocalExtrema | Stationarity HR min | HR | lorf = 'n', n = 100 | out.minabsmin
11 | Centroid | SB_TransitionMatrix | Symbolic transforms HR autocorrelation | HR | howtocg = 'quantile', numGroups = 2, tau = 3 | out.stdeigcov
12 | Centroid | SB_MotifThree | Symbolic transforms HR entropy | HR | cgHow = 'quantile' | out.hhhh
13 | Centroid | MF_arfit | Wavelet HR wavelet autoregressive model | HR | default | out.sbc_7
14 | Centroid | SB_MotifThree | Symbolic transforms HR first differences of coarsely-grained series | HR | cgHow = 'diffquant' | out.hhhh
15 | Centroid | PH_Walker | SpO2 STD | SpO2 | (walkerRules = ‘momentum’, walkerParam = 2) | out.sw_stdrat
16 | Centroid | CO_tc3 | Correlation SpO2 mean | SpO2 | tau = 1 (tc3 didn't work on HR   with their options I edited code to allow for custom tau. Description on   function made it seem that was acceptable) | out.denom
17 | Centroid | SY_StdNthDer | STD of 17th derivative of time series | HR | n = 17 | out
18 | Centroid | ST_LocalExtrema | Stationarity SpO2 ratio of minimum to range | SpO2 | lorf = 'n', n = 100 | out.minabsmin
19 | Centroid | DN_RemovePoints | Distribution SpO2 mean | SpO2 | removeHow = 'min' p = .2 | out.mean
20 | Centroid | SB_BinaryStats | Symbolic transforms SpO2 interquartile ranges of ?? | SpO2 | binaryMethod = iqr | out.pstretch1
21 | Centroid | MF_arfit | Wavelet SpO2 wavelet autoregressive model | SpO2 | default | out.sbc_7
22 | Centroid | SB_TransitionMatrix | Symbolic transforms SpO2 eigenvalues of transition matrix | SpO2 | howtocg = 'quantile', numGroups = 2, tau = 2 | out.mineig
23 | Centroid | CO_AutoCorr | Correlation SpO2 autocorrelation coefficient at lag = 4 | SpO2 | tau = 4, whatMethod = 'TimeDomainStat' | out(4)
24 | Centroid | SB_MotifThree | Symbolic transforms SpO2 entropy | SpO2 | cgHow = 'diffquant' | out.hhh
25 | Centroid | SB_TransitionMatrix | Symbolic transforms SpO2 binary state transitions | SpO2 | howtocg = 'quantile', numGroups = 2, tau = 1 | out.T3

[ ]

[ ] 1
[ ] 2
[ ] 3
[ ] 4
[ ] 5
[ ] 6
[ ] 7
[ ] 8
[ ] 9
[ ] 10
[ ] 11
[ ] 12
[ ] 13
[ ] 14
[ ] 15
[ ] 16
[ ] 17
[ ] 18
[ ] 19
[ ] 20
[ ] 21
[ ] 22
[ ] 23
[ ] 24
[ ] 25

Asked Justin about duplicate PH Walker algorithms and if he has any output distribution data.

Justin said that the PH Walker algorithms are actually the same: "In that case they are the same algorithm. Sorry about that confusion that particular algortihm happened to be both a center and a “Top 5”." Thus, we only have 24 algorithms to implement!

Conversation with Justin on algorithm 25:
My email to Justin:

I implemented algorithm 25 (SB_TransitionMatrix), but when I set numGroups=2, the algorithm doesn’t output out.T10, which is supposed to be the output parameter for that algorithm. Is numGroups supposed to be 10? That is what would make sense to me given the following code block from SB_TransitionMatrix
% ------------------------------------------------------------------------------
%% (((3))) output measures from the transition matrix
% ------------------------------------------------------------------------------
% (i) Raw values of the transition matrix
% [this has to be done bulkily (only for numGroups = 2,3)]:
if numGroups == 2; % return all elements of T
    for i = 1:4
        out.(sprintf('T%u',i)) = T(i);
    end
elseif numGroups == 3; % return all elements of T
    for i = 1:9
        out.(sprintf('T%u',i)) = T(i);
    end
elseif numGroups > 3 % return just diagonal elements of T
    for i = 1:numGroups
        out.(sprintf('TD%u',i)) = T(i,i);
    end
end

Justin's Response:

I see what I did here. I deviated a little in the numbering. T was a 2x2 matrix they labeled each point T1-T4 I called them T00-T11 where first number was row second was column. So T10 would be equal to T3 for them.

I have updated the table above to reflect his response.

Output of CO_AutoCorr should not be out(4), it should just be out when running the algorithm with a single value of tau

MF_arfit algorithm dataverse data is available in randomDailySample_matlab_HR/SP.csv

The code to run the test is located here: CAMA\Amanda\PreVentPostProcessing\makehctsafigures.m.
A figure showing the comparison between PreVent data and Justin Dataverse data is stored here: CAMA\Amanda\PreVentPostProcessing\HCTSA_Comparison_Figures\Justin_vs_PreVent50_Zoom.png


Tests seemingly executed on host

Hi!
I'm trying to execute a test that queries the database which runs in its own container.
The database is Postgres and I configure it using environment variables in my docker-compose.yml.
The test currently fails since I can't connect to the database.

SEVERE: Connection error:
org.postgresql.util.PSQLException: The connection attempt failed.
...
Caused by: java.net.UnknownHostException: postgresForScalaJsExample

For debugging, I print out the name and value of each environment variable in the test suite. This should contain the credentials for the database.
When I executed dockerComposeTest skipPull I was in for a surprise: I saw the environment variables of my Windows host system.
Is this a bug? I'm not sure anymore where the tests are executed, on the host or inside the Docker VM?
Thanks a lot in advance!

Hi @mb720, the tests are executed on the host machine against the running Docker compose instance. The endpoint host/post mappings for each Docker service are passed to the test cases via the ScalaTest configMap. Check out the basic-with-tests example.

Hi Kurt!
Thanks for clearing that up.
I got my tests running.
This is amazing, thanks! :-)

Happy to hear. I'm glad everything is working now!


🪲 NavContent-bug-fix and added-name-to-contributors

Improved/Fixed 'Contribute Now ->' button in NavContent.js to function appropriately in Dark and Light mode!
Added my Card to Contributors.js!

Can you give a screenshot what have you changed in Navbar and also resolve the merge conflicts and update the PR? @ishtails

Good job @ishtails
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐

SignIn / SignUp in ClueLess Website .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

sure! On hovering the button was not working as expected, so i did few changes to fix that!

My Clueless profile URL: https://www.clueless.tech/profile/admin/96720944
@Rajdip019


Problem unmarshalling consumer group offset on existing topic after upgrade

After upgrading the Aiven Terraform provider, when I run terraform plan, I get the following error:
Error: error waiting for Aiven Kafka topic to be ACTIVE: cannot unmarshal JSON
`{"topic":{"cleanup_policy":"delete","config":... more ...
"replication":2,"retention_bytes":-1,"retention_hours":1,"state":"ACTIVE","topic_name":"accp.ais-nmea"}}`,
error: json: cannot unmarshal number<PHONE_NUMBER>6 into Go struct field
ConsumerGroup.topic.partitions.consumer_groups.offset of type int

I upgraded the Aiven Terraform provider from 1.2.2 to 2.1.4.
The resource did already exist for months, and worked fine with the 1.2.2 version.
Could not find the definition of that struct field, but the actual offset is bigger than the regular int32.
I also upgrade terraform from 0.12.29 to 0.12.30, but suspect that has nothing to do with it.

@martijnblankestijn thanks for reporting this bug, this issue is related to the go-client that we are using under the hood of Terraform provider. We did already fix that, and the solution will be available with the new release.

@martijnblankestijn thanks for reporting this bug, this issue is related to the go-client that we are using under the hood of Terraform provider. We did already fix that, and the solution will be available with the new release.

Okay, thx! I'll keep an eye on new releases

Okay, thx! I'll keep an eye on new releases

I tried it with the latest release (2.1.5), but now I get an error saying
Error: error waiting for Aiven Kafka topic to be ACTIVE: couldn't find resource (51 retries)

I tried upgrading to the latest of the 1.x (1.3.5) and that worked fine.

I tried it with the latest release (2.1.5), but now I get an error saying
Error: error waiting for Aiven Kafka topic to be ACTIVE: couldn't find resource (51 retries)

I tried upgrading to the latest of the 1.x (1.3.5) and that worked fine.

Hi @martijnblankestijn, yep we know about this issue and currently working on a solution

Hi @martijnblankestijn, yep we know about this issue and currently working on a solution

Ok, thx! Let me know when it's fixed, Eager to try it out ;-)

Ok, thx! Let me know when it's fixed, Eager to try it out ;-)

@martijnblankestijn, can you please try v2.1.6?


Provide some way to see what unit tests failed and why

Perhaps there's some way to do this that I'm missing, but when unit tests fail, I'm not sure how to see which ones or why.
At a minimum it would be great to have the results copied somewhere so the failures can be viewed. As shown in the logs, they're being written somewhere, but I don't know how to get that file (yes, I'm also a completely bitrise newbie!)
Here's the log extract with the file I'd like to see:
Execution failed for task ':core:testDebugUnitTest'.
> There were failing tests.
> See the report at: file:///bitrise/src/core/build/reports/tests/testDebugUnitTest/index.html

Thanks!

Hi, @mikemee
Thanks for reporting an issue, we'll check it ASAP.

will be good to upload test results report somewhere and provide link to it from Artifacts

I think about Amazon S3 bucket upload... free and can store many versions of the same file

Good idea @OleksandrKucherenko , exactly what we're thinking about (to upload it as an Artifact) ;)

Hey @mikemee & @OleksandrKucherenko !
We will rework this in a new step completely very soon. Thank you for reporting the issue. Please keep an eye on our changelog section, the new unit test step can appear anytime now! 🙂

No reports found with pattern: *build/reports

Files are : app/build/reports/tests/testDebugUnitTest/index.html
is any easy way to verify the path expressions?

Also needed ability to add extra parameters to gradle as its in gradle unit tests build step https://github.com/bitrise-io/steps-gradle-unit-test

@trapacska @doomsayer13 ^

@OleksandrKucherenko the report might not be found because it is already there and it's modification time is not int the range of the test task started and finished. I will discuss about this with the team. Also I understand that an additional parameters field would be handy. I'll discuss this with the team, and I'll ping you as soon as we have a decision about that.

Hey @OleksandrKucherenko!
The new version of the step(0.9.1) will be released soon. Please try it with the new version and please let us know if it fixes your issues.

I solve it changing
classpath "org.springframework.boot:spring-boot-gradle-plugin:2.1.8.RELEASE"
to
classpath "org.springframework.boot:spring-boot-gradle-plugin:2.2.0.RELEASE"


CASMINST-5068 - Script for section 3.1, 3.2 and 3.3

I don't think this PR is still needed -- these changes merged under a different PR.


snapshot policy should allow specifying indices

 Issue by wyllys66
Monday Jan 11, 2021 at 22:50 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/index-management/issues/382

Currently, (release 1.12.0), it appears that we cannot specify what indexes to include in a snapshot when the snapshot is triggered by a policy. The policy action for "snapshot" only includes the repository and the name of the snapshot. It should allow for additional parameters related to snapshot operations.

 Comment by lav-kush
Tuesday May 25, 2021 at 15:18 GMT

Currently, it appears that we cannot specify dynamic snapshot name in ISM policy. The policy action for "snapshot" only includes the repository and the static name of the snapshot, and it creates separate snapshot for each indices with name -.  It should allow to pass dynamic snapshot name say for each index something like ctx.index var as used in message template.

 Comment by wyllys66
Wednesday Jan 20, 2021 at 17:22 GMT

While it is possible to create index_templates that assign a snapshot policy to a list of matching indices, the problem with that approach is that it results in a separate snapshot for each index.  It would be so much better if there was a single snapshot that included the matching indices.  This is pretty significant.

I agree totally with this. Actually we still using script with curator to aggregate with some logic indexes in one daily snapshot. And we cannot migrate to ISM because a snapshot for every index create a proliferation inside a S3 repository and after that will be difficult to retrieve and manage all snapshots with snapshot api caused by slowness of response do to the high number of snapshots.

Please check snapshot management feature https://opensearch.org/docs/latest/opensearch/snapshots/snapshot-management/


Edited the website title, metadata, and added Twitter card

closes #41
Changed title to Weather App by Hack2gether
Changed description to App to check the weather at any location, made with ❤ by Hack2gether
Added Twitter card that would appear when sharing website link on other platforms

Can do 🤔
I'll open a Discord thread for suggestions

@Yuehan-Wang
Changed to a shorter title "Hack2gether Weather"


Pull policy logic out of show in the garden crop controller and into the relevant mutations.

@rickcarlino says:

If it works now, let's just ship it, but this logic probably could've gone into a mutation since there is branched logic going on and a couple of places where an API user might make a formatting error.

It would also keep our API error format consistent, which will be useful for things like front end flash alerts.

here.
This isn't just happening in the garden crop controller but also in a couple of other places.
Places:

[ ] api/users_controller
[ ] api/gardens_controller
[ ] api/garden_crops_controller

test comment

@RickCarlino does it make sense to put "view" logic (for show/index) in a mutation since nothing is being changed?

@simonv3 Looks like things have changed quite a bit since I made that comment. I think (but can't confirm) that this was probably related to having authorization logic in a controller at the time. If you are using Pundit now, that should be good enough to get the job done. I think it looks pretty good since all the auth logic is composed elsewhere.

That's what I figured. I didn't dig too deep into when you had made the comment, but looking at the files it seemed okay to me. Thanks for checking in on it!


Issue with Instance Scan

Hello @chiarnglin
I am trying to work on Instance scan functionality via pipeline and i get the following error.
"Exit code 1 returned from process: file name '/home/vsts/agents/2.187.2/externals/node/bin/node', arguments '"/home/vsts/work/_tasks/ServiceNow-CICD-Scan-Instance_daa79da8-c2e8-4a02-bbec-b94b8809432f/2.0.5/index.js"
Can you help me with this ?

Hi @vinay2099, does this happen on every run?
I haven't seen this before, I wonder if it's something wrong with the runner for Azure Pipelines.
I tried Googling the error, but nothing really definitive showed up.
I tried comparing different task files, not seeing anything really pop out.
For example

https://github.com/ServiceNow/servicenow-cicd-azure-extension/blob/master/src/extension/Tasks/ScanInstance/task.json
https://github.com/ServiceNow/servicenow-cicd-azure-extension/blob/master/src/extension/Tasks/AppPublish/task.json

I don't currently have more development budget for these right now, might need your team's assistance to figure this one out if it's recurring.

Hello @chiarnglin
Below is my pipeline code i used and now i get error : "Scan failed
##[error]Not found. The requested item was not found.
"
trigger:

main

stages:

stage: Test
condition: eq(variables['Build.SourceBranch'], 'refs/heads/main')
jobs:

job: Scan_Instance
steps:

checkout: self
task: ServiceNow-CICD-Scan-Instance@2
displayName: ServiceNow CI/CD Scan Instance
inputs:
connectedServiceName: '${Instance_name}'
scanType: suiteScoped
suiteSysId: ''
appScopeSysIds: ''

@vinay2099
Would you mind double checking inputs with the API documentation?
https://developer.servicenow.com/dev.do#!/reference/api/quebec/rest/cicd-api#cicd-POST-instancescan-ss-sa
Also, try single quote marks around your scanType value
And I'm assuming you're putting in the suiteSysID and appScopeSysIds values, just redacted for this comment?
For example if I try adding the build step, it comes up as follows
- task: ServiceNow-CICD-Scan-Instance@2   inputs:     connectedServiceName: 'chiarngtestdemo'     scanType: 'suiteScoped'     suiteSysId: '12415151'     appScopeSysIds: '61646461'

Hi @chiarnglin
I had a look at the documentation and tried using scanType: 'suiteScoped' but still i am getting the same error.
I had provided the service connection, app sys id and appScopeSysIds as well.
Also I assume the error will be given properly in case of wrong.

Thanks, @vinay2099
Would you mind trying out the same input for the REST API Explorer on your instance, and let me know what the response is?
The response you noted sounds like it's coming from the API, rather than the build step, but want to verify.

Hi @chiarnglin
I did tried in REST API Explorer and it works fine. Returns the scan id and status as pending. Later when i try to check with id, i get the results using "Get Scan results"
For me the issue looks like its either on the extension code or the input 'appScopeSysIds'. (As it is an array and not string).

@vinay2099
Sorry for the delayed response. I've been trying to find time to dig more into this but it's been tough on bandwidth.
I don't currently have more budget for vendor engineering work on debugging and fixing this issue. In the spirit of open-source, is it possible for your team to take on submitting a PR to fix?
As you've tested, if the values are working in REST API Explorer, then there must be something wrong with how the extension is making requests for Instance Scan API specifically to get error responses. I'm a little concerned on if this is actually a problem of submitting as request body vs request header.

Hello @chiarnglin
Sure.Thanks for your response.
I will try to fix it and send PR(As i do not have complete knowledge on this). In the mean while if you get some budget, kindly let me know.
Kind regards,
Vinay

In the end the issue was fixed and we now using the ServiceNow-CICD-Scan-Instance@2 task without any issues.
Regards
Mike


Miscellaneous improvements and code refactor

This PR contains a misc of contributions. Below is a summary, the reasons for each of them are described in their respective commits:

Use $(...) instead of `...`
Inside a function, first, fetch all data, then print all data
Consistently use 4 spaces for code tabulation
Remove duplicated data to keep logs concise
Standardize print style and use print functions for formatting
Fetch and print some additional data, such as hostname and serial
Use the ShellCheck linter to improve code quality
Generalize some code to allow the script to run on other hardware and architecture
Unify bootloader data in a separate section

I know it's a lot of different stuff. I was a bit lazy to create one PR for each of them :P hope it's ok, but if it isn't, please let me know.
Also, there may be many things that are polemic. I'll rework the PR accordingly if you guys think something is not worth adding/removing/reworking.


Update models and add plugin for the auto-generation of deployment artifacts

This PR introduces the following new features:

the rosmodel was updated to define the link to the repository that contains the source code, which goal is to be able to auto-generate rosinstall files for deployment
new plugin was created to auto-generate the deployment infrastructure following the concept:

where:

Base layer: it collects the commands that are used for compile workspace (catkin_make, colcon build), check dependencies (python-rosdep/ python3-rosdep2), install packages and so on. I
Extra layer: If there are packages that are not released yet, rostooling generated *.rosinstall file. These packages are compiled and installed in this layer.
Rossystem layer: If all needed packages are released, the rossystem will be compiled base on base layer. If not, it will be built based on extra layer.

The new plugin can be called using the right-click menu for .rossystem files

@ipa-rwu please review

@ipa-rwu please review and test this PR, I would like to include the "FromGitRepo" attribute definition in the new Release

I finished the review. I updated this PR https://github.com/ipa-nhg/ros-model/pull/10

Tested for the agriculture demo example, with the ComponentStacks options and without it and it works as expected for the both cases.
@ipa-rwu  Thanks!
I will merge 😃


[SPARK-7862][SQL]Fix the deadlock in script transformation for stderr

[Related PR SPARK-7044] (https://github.com/apache/spark/pull/5671)

Merged build triggered.

Merged build started.

Test build #33507 has started for   PR 6404 at commit c419a64.

Test build #33507 has finished for   PR 6404 at commit c419a64.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33507/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33554 has started for   PR 6404 at commit d9677e1.

Test build #33554 has finished for   PR 6404 at commit d9677e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33554/
Test PASSed.

Merged build finished. Test PASSed.

cc @rxin  @liancheng @marmbrus

/cc @chenghao-intel

LGTM

Merged build triggered.

Merged build started.

Test build #34742 has started for   PR 6404 at commit 8418c97.

Test build #34742 has finished for   PR 6404 at commit 8418c97.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thanks, merging to master.

After this patch, the pull request builder logs show 50000 lines of stdout output, which makes them hard to read:
[info] - test script transform for stdout (3 seconds, 806 milliseconds)
17:26:41.401 WARN org.apache.spark.scheduler.TaskSetManager: Stage 1316 contains a task of very large size (2246 KB). The maximum recommended task size is 100 KB.
1	1	1
2	2	2
3	3	3
4	4	4
5	5	5
6	6	6
7	7	7
8	8	8
9	9	9
10	10	10
11	11	11
12	12	12
13	13	13
14	14	14
15	15	15
16	16	16
17	17	17
18	18	18
19	19	19
20	20	20
21	21	21
22	22	22
23	23	23
24	24	24
25	25	25
[...]

At least I think that this is the patch that caused this issue.  If that's the case, could someone open up a followup PR to fix this?

Oh, sorry @JoshRosen the meaningless output is caused by #5671, I will fix it with a followup PR.


[incubator/elasticsearch] Add option to add additional ES_JAVA_OPTS parameters

What this PR does / why we need it:
Add option to add additional ES_JAVA_OPTS parameters to the whole cluster.

cc @simonswine @icereval @rendhalver

Can you do this with the env var that already exists?
What does this allow us to do that can't be done with the env setup?

Actually, it can't be done using the env var already existing (or if it can, one would have to completely override ES_JAVA_OPTS envvar).
Use case was to have some upgrade requiring temporary "non-secure" features only using a flag:
elasticsearch:
  cluster:
    additionalJavaOpts: "-Des.allow_insecure_settings=true"

Ok cool.
Let's get this tested then.
/ok-to-test

Rebased.

Rebased again. Can we get this merged @rendhalver or do you need more informations ?

/lgtm


Fix: additional notes broken URLs

The parsing of links beginning with http:// https:// into <a href=""> HTML anchors fails with URLS that contain forward slashes.
For example:
https://github.com/Defacto2/defacto2.net/issues/new will be parsed to https://github.com-Defacto2-defacto2.net-issues-new.

fixed in v2020

More broken examples:
https://defacto2.net/f/ab20c18


Environment Request for pra-register

Environment details
pra-register
Description of application
The Parental Responsibility Agreement Register (PRA) application is a business critical application that allows HMCTS Central Family court staff to register all Parental Responsibility Agreements (PRAs)  submitted to Central Family Court. Staff users can also view submitted PRAs within the lifecycle of the Agreement and search for agreements using selected criteria.
GitHub team slug
dts-legacy
Environments

Environment
Access level

[X] Development
[ ] view-only[ ] developer[X] sandbox

[ ] Test
[ ] view-only[ ] developer

[X] Preproduction
[ ] view-only[X] developer

[X] Production
[ ] view-only[X] developer

Tags

tag
value

application
pra-register

business-unit
HMCTS

infrastructure-support
<EMAIL_ADDRESS>

owner
<EMAIL_ADDRESS>

Networking options
Subnet sets

[X] General - this application will use the same subnet as other applications in your business unit
[ ] Isolated - this application has highly sensitive data which must have its own isolated subnet with no network connectivity

How do users connect to the application?

[X] Over the public internet
[ ] With a purple cabled device (please give details)
[X] With a MoJ Official device

Connectivity to other applications or external parties

Additional features

[ ] Additional VPC Endpoints
[ ] Extended DNS Zones
[ ] Other - please specify

Other information

Definition of done

[ ] account created
[X] customer informed

https://github.com/ministryofjustice/modernisation-platform/pull/4524

environment complete


WIP: Make dimensions graph retrieval more efficient with recursive CTE

Summary
This change makes getting a node's dimensions graph more efficient by switching from the current graph traversal approach to a single recursive CTE query. The current approach causes us to issue dozens of calls to the database via retrieval of various relational objects using the ORM, which is inefficient. The new approach just retrieves the exact info needed through a single query.
We should be able to get the full DAG for a node with three recursive CTE queries: get_downstream_nodes, get_upstream_nodes, and get_dimensions. The only non-recursive CTE query at this point is the upstreams call (still a graph traversal).
This is the raw SQL query (which I started with and then translated to be SQLAlchemy-compatible):
WITH RECURSIVE dimensions_graph AS (
    SELECT
        initial_node.id AS path_start,
        c.name AS col_name,
        dimension_node.id AS path_end,
        initial_node.name || '.' || c.name || ',' || dimension_node.name AS join_path,
        dimension_node.name AS node_name,
        dimension_rev.id AS node_revision_id,
        dimension_rev.display_name AS node_display_name
    FROM noderevision initial_node
    JOIN nodecolumns nc ON initial_node.id = nc.node_id
    JOIN column c ON nc.column_id = c.id
    JOIN node dimension_node ON c.dimension_id = dimension_node.id
    JOIN noderevision dimension_rev
    ON dimension_rev.version = dimension_node.current_version
        AND dimension_rev.node_id = dimension_node.id
    WHERE initial_node.id=77

    UNION ALL

    SELECT
        ng.path_start,
        c.name AS col_name,
        next_node.id AS path_end,
        ng.join_path || '.' || c.name || ',' || next_node.name AS join_path,
        next_node.name AS node_name,
        next_rev.id AS node_revision_id,
        next_rev.display_name AS node_display_name
    FROM dimensions_graph ng
    JOIN node current_node ON ng.path_end = current_node.id
    JOIN noderevision current_rev ON current_rev.version = current_node.current_version AND current_rev.node_id = current_node.id
    JOIN nodecolumns current_columns ON current_columns.node_id = current_rev.id
    JOIN column c ON current_columns.column_id = c.id
    JOIN node next_node ON c.dimension_id = next_node.id
    JOIN noderevision next_rev ON next_rev.version = next_node.current_version AND next_rev.node_id=next_node.id
),
dims AS (
    SELECT * from dimensions_graph
)
SELECT
    dims.node_name,
    dims.node_revision_id,
    dims.node_display_name,
    c.name,
    dims.join_path
FROM dims
JOIN nodecolumns nc ON nc.node_id = dims.node_revision_id
JOIN column c ON nc.column_id = c.id

Test Plan

[ ] PR has an associated issue: #
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan

Wow, that's a lot of tables to glue together but I agree this particular use case is good to rewrite. Because we need it often. Thanks @shangyian for doing this!


MIRI_NO_STD can lead to very confusing errors

To reproduce, consider the following crate:
[package]
name = "embeddedMiri"
version = "0.1.0"
edition = "2021"

[profile.dev]
panic ='abort'

[profile.release]
panic ='abort'

[dependencies]
panic-semihosting = "0.6.0"

with main.rs being
#![no_std]
#![feature(start)]

use panic_semihosting as _;

#[start]
fn main(_argc: isize, _argv: *const *const u8) ->isize{
    panic!("hello")
}

It turns out panic_semihosting actually needs std on targets that do not satisfy all(target_arch = "arm", target_os = "none").
When running this with a truly no-std target such as  x86_64-unknown-none, this is very clear from the error:
error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-unknown-none` target may not support the standard library
  = note: `std` is required by `panic_semihosting` because it does not declare `#![no_std]`
  = help: consider building the standard library from source with `cargo build -Zbuild-std`

However, when one does MIRI_NO_STD=1 cargo miri run to run this without std on a target that has std, the error is pretty bad:
error[E0463]: can't find crate for `panic_semihosting`
 --> src/main.rs:4:5
  |
4 | use panic_semihosting as _;
  |     ^^^^^^^^^^^^^^^^^ can't find crate

error[E0463]: can't find crate for `panic_semihosting`
 --> src/main.rs:4:5
  |
4 | use panic_semihosting as _;
  |     ^^^^^^^^^^^^^^^^^ can't find crate
  |
  = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`

error: `#[panic_handler]` function required, but not found

error: aborting due to 3 previous errors

I don't know exactly why that is. But my current inclination is to just remove the MIRI_NO_STD env var; it shouldn't be needd as -none targets get built without std automatically...

Amusingly, MIRI_NO_STD=1 cargo +miri miri run --target i686-unknown-linux-gnu actually gives a nice error. It is only MIRI_NO_STD=1 with the host target that produces a bad error.

Somehow https://github.com/rust-lang/rust/pull/124582 did not help, this still prints the same bad error. I don't know why things behave different for the host target vs anther target.

Ah, the issue arises when first doing cargo miri run and then later MIRI_NO_STD=1 cargo miri run. There's stuff cached in the target dir that seems to confuse rustc. cargo miri clean fixes this.
I think that's good enough for now; though if MIRI_NO_STD keeps confusing people maybe we should entirely remove it.


ts: Migrate bot_data.js to TypeScript

Add type annotations. Create custom types for Bot and Service.
TODOs:

Non-null assertions: currently I added non-null assertions (!) at a few places, but I think I need to think carefully whether an (minimalist-) assertion is neccessary.
Borrowing from test cases, I added extra data field in type Service. However, whether extra property should appear in the test case is a question. I understand that the author's was about to create a field that does not belongs to the fields that _.pick allowed (so called "extra").

Fixes:

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I think a strategy to avoid as and _.pick here is to define zod schemas so that bot_fields and service_fields are no longer needed.

@remove "mentor review"

@zulipbot add "integration review"

@zulipbot remove "mentor review"

Fixed the snake case thing and merged this, thanks @jychen630 and @PIG208!


ppbrowse/ncview functionality

The CLI has options available to allow [FILE [FILE ...]] additional arguments. The main program should be upgraded to take advantage of this added interface.

De-coupling the control menu from whether a SQL database or a list of files seems to be most elegantly solved by the redux concept of middleware

Reducers combine state and action into a new state, while middleware components generate new actions based on existing state/action events

Getting closer to the point where the SQL and FileSystem navigation middlewares can control the application state without stepping on each others toes

This should also solve #105 too


feat: support qovery-container-names input

Using names is more convenient than IDs for us

Hello @Thiht !
Sorry I've missed that, we will have a look.
Cheers

@Thiht  Here you go, thanks again for your contribution :)
https://github.com/Qovery/qovery-github-actions/releases/tag/v0.15.7

Happy to contribute! thanks for the release


Virtual slide not working with ngFor loop ANGULAR

 <swiper-container class="swiper-container" virtual="true" slides-per-view="1" navigation="true">
          <swiper-slide class="swiper-slide">Slide 3</swiper-slide>
          <swiper-slide class="swiper-slide">Slide 1</swiper-slide>
          <swiper-slide class="swiper-slide">Slide 2</swiper-slide>
          <swiper-slide class="swiper-slide">Slide 3</swiper-slide>
          <swiper-slide class="swiper-slide">Slide 1</swiper-slide>
          <swiper-slide class="swiper-slide">Slide 2</swiper-slide>
          <swiper-slide class="swiper-slide">Slide 3</swiper-slide>
          ......
</swiper-container>

The above code is working but when I am using virtual slide with ngFor it not working and load the entire DOM
<swiper-container class="swiper-container" virtual="true" slides-per-view="1" navigation="true">
          <swiper-slide class="swiper-slide" *ngFor="let slide of slides; let i = index;">Slide {{i}}</swiper-slide>
</swiper-container>

The above mentioned code is not working

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


Rework menus #144

Not sure about how to implement the single event listener per menu. It works, but I don't think it's good.
I can't get the unit test to work on it: simulate('click') is not a function

Even though the name would imply this simulates an actual event, .simulate() will in fact target the component's prop based on the event you give it. For example, .simulate('click') will actually get the onClick prop and call it.

ObjectHome still needs fixing with the new Menu

Nice PR @brunottonurb


Test build fails on iOS

For more info, contact @zoskar

Some context: spent ~2 hrs trying to fix this bug on Monday (Match 6th), but all tricks known to me failed and the problem persists.
Gonna make another try soon.

We encountered similar problem with @KmlBaranowski , pls contact him as well, maybe you'lol discover something there.

    /Users/bartek/dev/leancode/REDACTED/mobile/ios/Runner/GeneratedPluginRegistrant.m:12:9: fatal error: module 'app_settings' not found
    @import app_settings;
     ~~~~~~~^~~~~~~~~~~~
    1 error generated.

Second project (by @KmlBaranowski) fails with:
/Users/bartek/dev/leancode/REDACTED/mobile/ios/Runner/AppDelegate.swift:3:8: error: no such module 'GoogleMaps'
	import GoogleMaps

oh man, I just wanted to give up and go to sleep, but then got the idea to pass --configuration it worked
@zoskar here's your magic line
$ patrol test -t integration_test/daily_mission_test.dart -v --configuration Debug-dev

This was fixed in #1089 and released in patrol_cli v1.1.0.


srb tc crashes with segmentation fault error

I can't reproduce this issue on sorbet.run, so I created a repo for reproduction. The main script looks like this:
# typed: true
# frozen_string_literal: true

class Foo
  extend T::Generic

  X = type_member { { fixed: Object } }
end

class Bar < Foo
  X = type_template { { fixed: Object } }
end

Gemfile
# frozen_string_literal: true

source "https://rubygems.org"

gem "tapioca", require: false
gem "sorbet-static-and-runtime", "0.5.10560"

On sorbet.run, it passes type-checking.
But when I run it locally, it crashes:
$ bundle exec srb tc
/Users/hung-wulo/.gem/ruby/3.1.2/gems/sorbet-0.5.10560/bin/srb: line 46: 17653 Segmentation fault: 11  "${sorbet}" "${args[@]}"

Expected behavior
It doesn't crash.

Duplicate of #5719


DOMA: consider clearing VALPOS

If the domain contains a lot of fixed values, and then inserting a new value in the top, it will trigger a very long diff due to the VALPOS field.
The value position is implicitly part of the XML, so we should consider clearing the VALPOS field

This maybe impact on this code, because it's use VALPOS.
      lt_dd07v_tmp = it_dd07v.
      LOOP AT lt_dd07v_tmp ASSIGNING <ls_dd07v>.
        READ TABLE lt_dd07_texts ASSIGNING <ls_dd07_text>
          WITH KEY ddlanguage = <lv_lang> valpos = <ls_dd07v>-valpos.
        CHECK sy-subrc = 0. " ! no translation -> master translation remain (maybe not OK)
        MOVE-CORRESPONDING <ls_dd07_text> TO <ls_dd07v>.
        DELETE lt_dd07_texts INDEX sy-tabix. " Optimization
      ENDLOOP.

I tried to create some test to analyze, but nothing I did goes through this part of the code.
What's I18N_TEXT on DOMA? I translated the doma texts but don't generated this files.

I got it.
I think we can change the READ using DOMVALUE_L and DOMVALUE_H instead of VALPOS.

@ibnbr example of DOMA translation

Suggest this approach:
add the code to fill the empty values now -> PR #3083
In 4(?) months: add the code that clears the fields
This way users will have a chance to update to latest abapGit, and we can avoid some problems

It's been >7 months ;-)

todo: clearing VALPOS

https://github.com/abapGit/abapGit/pull/4283 serializes and deserializes everything properly. I don't think a "large diff" when inserting a value is a problem. It won't happen often, and it will be very obvious that only the VALPOS numbering has changed.

Developer A inserts a value at position 10, developer B inserts a value at position 20, in separate pull requests, this will lead to conflicts with VALPOS, without VALPOS in the XML it might be possible to merge it
tho, it might not be something that happens often, if there is a lot of changes in a DOMA a value table might be the right thing to use

closing, no progress


converter from wit-parser Resolve to wit-encoder packages

Also improves the interface use api

I think the test might be due to line endings, so perhaps having it as an in-file literal instead?

@alexcrichton can confirm that line endings are indeed the problem here.
How do you feel about a manual .replace("\r\n", "\n")? I don't think that wit-parser can just read text without a file.

Would Resolve::push_str work for that?

Missed that one. Should work!


Warning message when there are no peaks

macs2 writes empty files rather than failing.
GEM fails when there are no peaks.
Ideally, they wouldn't fail but would warn when there are no peaks.

make sure contrasts part of the pipeline is not run.


"RedisCommandTimeoutException: Command timed out" report on one of redis cluster nodes severely

lettuce's version 4.5.0.Final
the redis cluster has 8 nodes
every backends(switched jedis to lettuce) visit the 7th node(get setex) will time out all the time
but jedis is ok

If you would like us to spend some time helping you to diagnose the problem, please spend some time describing it and, ideally, providing a minimal sample that reproduces the problem.

com.lambdaworks.redis.RedisCommandTimeoutException: Command timed out after 15000 MILLISECONDS
at com.lambdaworks.redis.ExceptionFactory.createTimeoutException(ExceptionFactory.java:39)
at com.lambdaworks.redis.LettuceFutures.await(LettuceFutures.java:118)
at com.lambdaworks.redis.LettuceFutures.awaitOrCancel(LettuceFutures.java:96)
at com.lambdaworks.redis.cluster.ClusterFutureSyncInvocationHandler.handleInvocation(ClusterFutureSyncInvocationHandler.java:117)
at com.lambdaworks.redis.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
at com.sun.proxy.$Proxy46.setex(Unknown Source)

it's not reproduced by simple unit test
but,if I deploy the backend with lettuce, the time out occur

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Add all in output when option a is selected

Associated Issue

Closes #50
Implemented Solution

string literal all was missing in generate_endpoint.

@all-contributors please add @Godson-Gnanaraj for code


Drop redundant configMapNameForConfig/Scripts

These functions contain only a single line logic and are used in only a single place.

This is still used in one more place... Probably we should create a method in pkg and use it.


CLI command analytics

the download counts on crates.io were never a really great way to see how often wasm-pack is used, since you only need to download it once per version. now that we have an installer, we have even less insight into this download count.
i'd like to have analytics of some sort so we can see adoption. i also don't want to use some sort of evil service. any thoughts? my naive thought is google analytics on the website with a measurement of folks following the download wasm-pack call to action.
i was at npm when analytics for the cli tool was added, that would give us more insight into how often the tool is used. that might be a bit out of scope for this, but if people have thoughts i would welcome them here.

Generally I'm a huge fan of non-evil analytics so I think this is a great idea!
I think starting with more accurate download analytics from the wasm-pack site is the best way to go and then follow up with CLI level analytics if we feel like we need more. I could see some people being put off by having a tool collect data on their usage even if it is super benign. Analytics always seems to open a huge can of worms when it comes up and I would hate for that to detract from how awesome wasm-pack is.

@iarna and @zkat (former npm buddies) - do you have any insight or lessons learned from when you did this?

We never really got around to doing anything with them because it needed more dev on the registry side and that work never got scheduled :( Rebecca might have more insights on that.

There were the very basic opt-in crash-rate data, which were being stored in S3, but we never got around to pulling the data back out. Possibly more useful is the approach we took to audit data, which I went to some trouble to make impossible to infer private information from--anything not hosted on the npm registry was hashed in a non-reversable way (that is, with a one-time session key), such that npm's servers could never learn anything they didn't already know.
Overall, I think people are actually pretty ok with this stuff, you just have to take care to be very explicit about what's being sent and always be looking at it in terms of "if all of this data were going to an attacker, what would they learn?" Having these discussions in public, and publishing documentation on both the data, and the mitigations, quell most of the fears.


Sample GlobalSuppression Entry

Would it be possible to provide a sample entry for GlobalSuppressions.cs to suppress this at the namespace level?

@sarajang Does this section give you the info you need? https://docs.microsoft.com/en-us/visualstudio/code-quality/in-source-suppression-overview?view=vs-2019#global-level-suppressions
[module: SuppressMessage("Microsoft.Design", "CA1020:AvoidNamespacesWithFewTypes", Scope = "namespace", Target = "MyNamespace")]
Note that when you suppress a warning with namespace scope, it suppresses the warning against the namespace itself. It does not suppress the warning against types within the namespace. There's a new scope in VS 2019 namespaceanddescendants that might suit your needs better.

@gewarren  I think so. Thanks.


please release a new version of this crate

Currently rbspy has rbspy-testdata = { git = "https://github.com/rbspy/rbspy-testdata", branch = "master" } in its Cargo.toml, which makes packaging tricky, as the latest published version of rbspy-testdata doesn't contain all necessary changes for it to compile. Consider cutting a new release and uploading it to crates, then updating the dependency in rbspy to something like
rbspy-testdata = { version = "0.1.3" } to make things easier down the road.

@davide125 We can do a new release. I'm curious how this repo affects packaging, though, since rbspy's Cargo.lock includes the respective commit from rbspy-testdata master that's needed for a reproducible build. Does every dependency need to be packaged separately for your distro?
@jvns, it looks like you're the sole owner of the rbspy-testdata and rbspy-ruby-structs crates. Could you add me to those, please?

Thanks! Fedora packages every crate separately, and every crate has only one version within the entire distribution. Cargo.toml is parsed to figure out dependencies (and patched if needed), and to my understanding Cargo.lock is ignored.

Oops, I invited you as an owner! I also added @rbspy/owners as an owner of those crates

Thanks!
I tagged version 0.1.4, but we've exceeded the maximum crate size (10MB) for crates.io, so the crate hasn't been updated yet. I emailed them to ask for an increase.

The crate size limit is now 50MB. 0.1.4 is published.


File type .xcf (GIMP file) causing uncatchable error

When resize and upload a file .xcf it can crash the nodejs process as error below. The problem is due to imagemagick generated multple files for individual layers after resized .xcf . The file name with suffix -n.jpg unmatched with the version path in _upload function. fs.createReadStream(version.path)  emitted error not catchable inside aws-sdk.
======================================================
events.js:141
throw er; // Unhandled 'error' event
^
Error: ENOENT: no such file or directory, open 'uploads/92c4fce2-e7f0-4ff7-8e3c-9245e3f7ea26/arrow_4_xxl-thumb1.jpg'
at Error (native)
[nodemon] app crashed - waiting for file changes before starting...
======================================================
Temporary fix suggestion (validate the existence of version.path):
Image.prototype._upload = function _upload(dest, version, cb) {
fs.stat(version.path, function (err_file) {
if (err_file) return cb(err_file);
......
});
};

@georgezhang If you have a solution for this problem, feel free to publish a pull request.


Latest beta (3.5.0 - 7423) crash

ATEM connection crashes on MscOS when not attached to ATEM unit. Not a major issue but it didn't crash before :) Unable to provide logs or do anything as the module is on a permanent retry loop.

Is this still happening?

No - all working as it should under 3.5.0 7532. Gets a connection failure (which is correct) but the actions and variables are now available to work with while off-line. Very many thanks.

I've not done anything to the module since you reported this, so sounds like macos being annoying 🤷

Very possibly...or perhaps underlying Companion code changed (don't know enough about the infrastructure to know what code manages what functionality!)


Settings

-"Settings" title needs to be smaller, maybe bolded, more padding above and below
-"Paradigm labels" needs to be changed to "Display Mode", text underneath also needs to be changed
-Examples need to be italicized
-"Show Morpheme Boundaries" needs to be changed to "Morpheme Boundaries", text underneath also has slight difference
-small differences in a lot of the text, will not list them all here
For every section:
-Text under title of section needs to be smaller
-Different label types need to be bolded ("Plain English labels", etc)
-Eliminate grey lines in between choices
-Bullet for selected choice looks different - should be filled with blue with thin blue border hovering above

Fonts have been updated in PR #27

Resolved in PR #39


Add word dictionary project

Related Issue
Want to add word dictionary project
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
write issue no. here #245
Email id used to register for VSoc'24
<EMAIL_ADDRESS>Description
I have successfully added the project "Word Dictionary" to our repository
Type of PR

[ ] Bug fix
[x ] Feature enhancement
[ ] Documentation update
[ ] Security enhancement
[ ] Other (specify): _______________

check in issue by entering [X] in boxes
Screenshots / Videos (if applicable)
https://github.com/dhairyagothi/50_days_50_web_project/assets/147842418/c33e363c-5d0f-4984-91b1-557ab07193bb
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x ] I have performed a self-review of my code.
[x ] I have read and followed the Contribution Guidelines.
[x ] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x ] I have commented my code, particularly in hard-to-understand areas.
[x ] I have followed the code style guidelines of this project.
[x ] I have checked for any existing open issues that my pull request may address.
[ x] I have ensured that my changes do not break any existing functionality.
[x] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[x ] I have read the resources for guidance listed below.
[ xI have followed security best practices in my code changes.

check in issue by entering [X] in boxes
Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation

Limit on Issues:

Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

Basic Contributions:

This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
For these tasks, issues will be assigned the Easy label.

Acknowledging Hard Work:

If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.

Feature Additions and Component Work:

Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

Easy:

Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.

Medium:

Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.

Hard:

Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

i am getting this check failing again and again please help me , i also removed the API key
from this code.


[Bug] npm installation fails

Hello,
Having trouble with the installation.
Update: When I've tried to install it in my React project then it worked without any problems. The problem occurs when I've tried to install it in an empty folder, alone.
After running the npm install react-grid-layout I get this message:
C:\www
+-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
+-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
`--<EMAIL_ADDRESS>  +-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
  `-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0

npm WARN enoent ENOENT: no such file or directory, open 'C:\www\package.json'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN www No description
npm WARN www No repository field.
npm WARN www No README data
npm WARN www No license field.

I've tried manually installing react and react-dom but to no avail.
I've tried with these node versions 6.5.0 and 5.7.0.
Windows 10.

Yeah, it seems this package wasn't meant to be installed via npm install. I'm seeing the same error:
$ npm install react-grid-layout
/tmp/empty
├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
  ├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>|| ^15.0.0
  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
npm WARN enoent ENOENT: no such file or directory, open '/tmp/empty/package.json'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN empty No description
npm WARN empty No repository field.
npm WARN empty No README data
npm WARN empty No license field.

$ npm --version
4.0.3

$ node --version
v6.9.2

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.1 LTS
Release:	16.04
Codename:	xenial

This is probably due to prepublish running after install (classic npm bug), will investigate.

The prepublish run is fixed in d5c6cb8baaf10ff689f0d5a5e18375b4eb886f1d - otherwise the peerDep errors are quite intentional - we don't want to risk installing an extra version of React - this is similar to how most React component packages work so this is not a bug.


isSuccess.value

Why does this happen？

This happens because onSuccess is called before listeners are notified.
onSuccess gets fresh data as a parameter.
https://github.com/TanStack/query/blob/main/packages/query-core/src/queryObserver.ts#L683
As a side note please migrate to https://github.com/TanStack/query/tree/main/packages/vue-query