Xamarin.Android .NET 6 not passing min SDK version to Aapt2Link

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
I have a simple Xamarin.Android .NET 6 app that has API levels set as follows:
<TargetFramework>net6.0-android31</TargetFramework>
<SupportedOSPlatformVersion>26</SupportedOSPlatformVersion>

Its AndroidManifest.xml file doesn't specify android:minSdkVersion so in the generated obj\Debug\net6.0-android31\AndroidManifest.xml is this:
<uses-sdk android:minSdkVersion="26" android:targetSdkVersion="31" />

I have an adaptive icon in Resources\mipmap-anydpi but when I build I get the following error:
APT2000: <adaptive-icon> elements require a sdk version of at least 26.

As a workaround I currently use this in my .csproj file:
<AndroidAapt2LinkExtraArgs>--min-sdk-version $(SupportedOSPlatformVersion)</AndroidAapt2LinkExtraArgs>

This imo confirms that the min API version is not correctly passed to (at least) the Aapt2Link task.

Original Comments
Feedback Bot on 12/23/2021, 09:59 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Feedback Bot on 1/3/2022, 08:39 AM:
Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at: https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem?view=vs-2019#faq. In case you need answers to common questions or need assisted support, be sure to use https://visualstudio.microsoft.com/vs/support/. We’ll keep you posted on any updates to this feedback.
Jonathan Peppers [MSFT] on 1/3/2022, 09:29 AM:
I wrote a quick test for this scenario:
https://github.com/xamarin/xamarin-android/compare/main…jonathanpeppers:dotnet-adaptiveicon
But it seems to work for me, I get obj\Debug\net6.0-android\android\AndroidManifest.xml with <uses-sdk android:minSdkVersion="26" android:targetSdkVersion="31" />
Full contents:
<?xml version="1.0" encoding="utf-8"?>
<!--
    This code was generated by a tool.
    It was generated from C:\src\xamarin-android\bin\TestDebug\temp\AdaptiveIcon\AndroidManifest.xml
    Changes to this file may cause incorrect behavior and will be lost if
    the contents are regenerated.
    -->
<manifest xmlns:android="https://schemas.android.com/apk/res/android" xmlns:tools="https://schemas.android.com/tools" android:versionCode="1" android:versionName="1.0" package="com.xamarin.adaptiveicon">
  <uses-sdk android:minSdkVersion="26" android:targetSdkVersion="31" />
  <uses-permission android:name="android.permission.INTERNET" />
  <application android:label="UnnamedProject" android:name="android.app.Application" android:allowBackup="true" android:icon="@drawable/icon" android:debuggable="true" android:extractNativeLibs="true">
    <activity android:icon="@drawable/icon" android:label="UnnamedProject" android:name="com.xamarin.adaptiveicon.MainActivity" android:exported="true">
      <intent-filter>
        <action android:name="android.intent.action.MAIN" />
        <category android:name="android.intent.category.LAUNCHER" />
      </intent-filter>
    </activity>
    <provider android:name="mono.MonoRuntimeProvider" android:exported="false" android:initOrder="1999999999" android:authorities="com.xamarin.adaptiveicon.mono.MonoRuntimeProvider.__mono_init__" />
  </application>
</manifest>

Do you have a <uses-sdk/> element in your AndroidManifest.xml? You can remove it if you are using $(SupportedOSPlatformVersion) instead.
Can you attach a diagnostic MSBuild log when you this this issue?
I think we need to see the version of the Android workload, and maybe if there is something else in your project causing this. Thanks!
Why do we ask for more info?
We try to reproduce all issues reported with the information provided in the description and comments. When we can’t reproduce the issue, we ask you for more information so we can resolve the issue as quickly and efficiently as possible.
In our guidelines, you can get tips on how to provide clear and simple reproducible steps.
Marian Dolinský on 1/8/2022, 05:14 PM:
I don’t know how to get the workload version but I ran dotnet workload update then opened VS, cleaned and rebuilt a few days ago but got the same result 😕
But the problem doesn’t seem to be in the AndroidManifest.xml generation. The file is generated correctly. Original (in my project) doesn’t have the <uses-sdk/> tag and the generated does. Only the adaptive icon resource is not processed correctly.
There’s one difference in the test though. I believe it would fail if you change this line
new AndroidItem.AndroidResource("Resources\\mipmap-anydpi-v26\\adaptiveicon.xml")

to be like this:
new AndroidItem.AndroidResource("Resources\\mipmap-anydpi\\adaptiveicon.xml")

That’s how I have it in my project. Since the min SDK of my app is higher than 26 I removed the v26 suffix in the folder name and that’s why it doesn’t build.
Feedback Bot on 1/19/2022, 01:19 PM:
Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at: https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem?view=vs-2019#faq. In case you need answers to common questions or need assisted support, be sure to use https://visualstudio.microsoft.com/vs/support/. We’ll keep you posted on any updates to this feedback.

Original Solutions
(no solutions)

Surprising this doesn't have more activity. I've been updating our app to the latest dotnet Android. Targeting sdk 35 and no problems. But I look to add an adaptive icon and I get this message.
I can confirm the workaround does the trick - thank you! It would be great if this wasn't needed.

This imo confirms that the min API version is not correctly passed to (at least) the Aapt2Link task.

Workaround is:

<AndroidAapt2LinkExtraArgs>--min-sdk-version $(SupportedOSPlatformVersion)</AndroidAapt2LinkExtraArgs>

@dellis1972 do you think this is still the case? The issue is from .NET 6.

My guess is this happens in _UpdateAndroidResgenAapt2.
So yes this will still be a problem.

So the reason this is a problem is because the call to aapt2 to generate the R.txt for the designer code is not using the customers AndroidManifesst.xml, its using one that is auto generated.


Problem with my table and my connection

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
Hi i'm using the linuxserver/bookstack: https://hub.docker.com/r/linuxserver/bookstack to have bookstack i copy and paste the docker compose after add the column that in my log in bookstack said that i do not have i have this error SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'type' (SQL: ALTER TABLE activities CHANGE key type INT DEFAULT NULL)
2023-12-04 10:27:38
2023-12-04 10:27:38 at /app/www/vendor/laravel/framework/src/Illuminate/Database/Connection.php:760
2023-12-04 10:27:38 756▕ // If an exception occurs when attempting to run a query, we'll format the error
2023-12-04 10:27:38 757▕ // message to include the bindings with SQL, which will make this exception a
2023-12-04 10:27:38 758▕ // lot more helpful to the developer instead of just the database's errors.
2023-12-04 10:27:38 759▕ catch (Exception $e) {
2023-12-04 10:27:38 ➜ 760▕ throw new QueryException(
2023-12-04 10:27:38 761▕ $query, $this->prepareBindings($bindings), $e
2023-12-04 10:27:38 762▕ );
2023-12-04 10:27:38 763▕ }
2023-12-04 10:27:38 764▕ }
2023-12-04 10:27:38
2023-12-04 10:27:38 +9 vendor frames
2023-12-04 10:27:38 10 /app/www/database/migrations/2020_11_07_232321_simplify_activities_table.php:17
2023-12-04 10:27:38 Illuminate\Support\Facades\Facade::__callStatic()
2023-12-04 10:27:38
2023-12-04 10:27:38 +25 vendor frames
2023-12-04 10:27:38 36 /app/www/artisan:35
2023-12-04 10:27:38 Illuminate\Foundation\Console\Kernel::handle()
2023-12-04 10:27:38 [custom-init] No custom files found, skipping...
2023-12-04 10:27:38 [ls.io-init] done. I have try to change key in boolean and varchar no difference so what i need to do?
Exact BookStack Version
default latest
Log Content
THIS IS MY BOOKSTACK LOG
GID/UID
2023-12-04 10:27:35 ───────────────────────────────────────
2023-12-04 10:27:35
2023-12-04 10:27:35 User UID:    1000
2023-12-04 10:27:35 User GID:    1000
2023-12-04 10:27:35 ───────────────────────────────────────
2023-12-04 10:27:35
2023-12-04 10:27:35 using keys found in /config/keys
2023-12-04 10:27:36 App Key found - setting variable for seds
2023-12-04 10:27:36 Running config - DB_HOST set
2023-12-04 10:27:36 Waiting for DB to be available
2023-12-04 10:27:38
2023-12-04 10:27:38    INFO  Running migrations.
2023-12-04 10:27:38
2023-12-04 10:27:38   2020_11_07_232321_simplify_activities_table ..................... 321ms FAIL
2023-12-04 10:27:38
2023-12-04 10:27:38    Illuminate\Database\QueryException
2023-12-04 10:27:38
2023-12-04 10:27:38   SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'type' (SQL: ALTER TABLE activities CHANGE key type INT DEFAULT NULL)
2023-12-04 10:27:38
2023-12-04 10:27:38   at /app/www/vendor/laravel/framework/src/Illuminate/Database/Connection.php:760
2023-12-04 10:27:38     756▕         // If an exception occurs when attempting to run a query, we'll format the error
2023-12-04 10:27:38     757▕         // message to include the bindings with SQL, which will make this exception a
2023-12-04 10:27:38     758▕         // lot more helpful to the developer instead of just the database's errors.
2023-12-04 10:27:38     759▕         catch (Exception $e) {
2023-12-04 10:27:38   ➜ 760▕             throw new QueryException(
2023-12-04 10:27:38     761▕                 $query, $this->prepareBindings($bindings), $e
2023-12-04 10:27:38     762▕             );
2023-12-04 10:27:38     763▕         }
2023-12-04 10:27:38     764▕     }
2023-12-04 10:27:38
2023-12-04 10:27:38       +9 vendor frames
2023-12-04 10:27:38   10  /app/www/database/migrations/2020_11_07_232321_simplify_activities_table.php:17
2023-12-04 10:27:38       Illuminate\Support\Facades\Facade::__callStatic()
2023-12-04 10:27:38
2023-12-04 10:27:38       +25 vendor frames
2023-12-04 10:27:38   36  /app/www/artisan:35
2023-12-04 10:27:38       Illuminate\Foundation\Console\Kernel::handle()
2023-12-04 10:27:38 [custom-init] No custom files found, skipping...
2023-12-04 10:27:38 [ls.io-init] done.
I already tried to change key in boolean and varchar
THIS IS MY BOOKSTACK_DB LOG
Brought to you by linuxserver.io
2023-12-04 10:27:34 ───────────────────────────────────────
2023-12-04 10:27:34
2023-12-04 10:27:34 To support LSIO projects visit:
2023-12-04 10:27:34 https://www.linuxserver.io/donate/
2023-12-04 10:27:34
2023-12-04 10:27:34 ───────────────────────────────────────
2023-12-04 10:27:34 GID/UID
2023-12-04 10:27:34 ───────────────────────────────────────
2023-12-04 10:27:34
2023-12-04 10:27:34 User UID:    1000
2023-12-04 10:27:34 User GID:    1000
2023-12-04 10:27:34 ───────────────────────────────────────
2023-12-04 10:27:34
2023-12-04 10:27:34 [custom-init] No custom files found, skipping...
2023-12-04 10:27:34 231204 10:27:34 mysqld_safe Logging to '/config/databases/46987b1c16f7.err'.
2023-12-04 10:27:34 231204 10:27:34 mysqld_safe Starting mariadbd daemon with databases from /config/databases
2023-12-04 10:27:35 [ls.io-init] done.
Hosting Environment
Docker-compose yml with VISUAL STUDIO CODE

Solved

Since this is reported solved I'll close it off.


variable camera viewpoints

Dear authors,
congrats on the excellent work! I noticed that the camera viewpoints are fixed for all instances. I wonder if you have tried to use variable camera viewpoints instead. Much appreciated if you could shed some light on this topic.

Hi, I do not try this because this requires rendering images of arbitrary viewpoints. If random viewpoints are used, the construction of the 3D feature volume should be invariant to the order of the input camera viewpoints. This could be achieved by taking the mean and variance of features from different views. However, I'm not sure this could work well with the VAE of SD or not.


Need docs for individual component release process

Future Deis Workflow releases will not be "all-or-nothing" affairs; instead, each component will release with a new semver tag on-demand, as often as is practical, without particular regard to the overall Workflow release cadence.
There should be idiot-proof documentation around exactly how to execute a Deis component release (which ideally isn't a lot more complicated than "push a new tag," but we shall see). The docs can live centrally here in workflow, or be distributed to each repository (although beware copy-paste maintenance tradeoffs).

This was implemented in #410 and #420.


Adding signature for methods

Motivation

Following up on https://github.com/sorbet/sorbet/pull/7754#pullrequestreview-1932898717, I added the sig to the methods in which the return type was defined.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Pnu6onyZS8hct5
→ https://go/builds/bui_Pnu6XGL6ssuyqT
→ https://go/builds/bui_Pnu6Y3BbkaY68J

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_PoKvCb2tqnGDWs
→ https://go/builds/bui_PoKvvVZNmsxm94
→ https://go/builds/bui_PoKvJYYZGy8eRn


add anytime to Date module

like https://fakerjs.dev/api/date.html#anytime

PR made #947

Good changes, please fix some failing tests

@cieslarmichal new fix and tests added! We had an unexpected case of Y2K38 (which explains why its visible here and not in the js version)


Reverse Linked List

Algorithm: To reverse a linked list.
Languages supported:

C++
C [@Sohailsaifi]
GO
Python
Java [@parjanyaacoder]
Javascript
C#

I would like to work on this issue in Java. @ricardoprins @VijayaGB98 Please assign this issue.

Anybody please assign me this issue? Please assign I am looking forward for some serious contribution.

I would like to work on this issue in C++

Alright! Looking forward to see your contributions!

Solved by #296

I would like to work on this issue in C and Python.

I would like to work in javascript version

can you assign this issue to me I can work on this for c language?

@Sohailsaifi go ahead with C

i would like to solve it in java please assign me
(java)

I would like to solve it in python

I will do this in Java.
Please assign me this task when contribution begin after 16th .

I would like to do this in java. Please assign me on 16th August

Would like to do in c++.
please assign me.

@sonukushwaha403 Go ahead with Java.
@infoarpit @Himanshu44626748 First come first serve basis so I'm assigning the issue to @sonukushwaha403 .
Please follow the contribution guidelines @sonukushwaha403 when submitting your code.

@Alifbhanvadiya14 go ahead with python.
Please follow the contribution guidelines when submitting your contribution.

@yashaswibiyahut Go ahead with C++.
Please follow the contribution guidelines when submitting your contribution.

I would like to work on this issue and solve using the language C

I would like to solve this in C !!!!

@neha07kumari and @riya-joshi-401, Please check the first post to see if the issue has been taken by someone else. As C has been taken, I cannot assign you the task.
The languages you can choose are Go and C#.

I have PR the Reverse Link list in c++..Kindly review it @VijayaGB98

@plazzy99 the code is implemented but the code is not working thats why it assigned to me so that i can resolve the errors.
You can check the previous code and mine code before closing the PR.

@plazzy99 the code is implemented but the code is not working thats why it assigned to me so that i can resolve the errors.
You can check the previous code and mine code before closing the PR.

I have reopend the request and will check soon both the code


Unit Test - Pizza

Codecov Report

Merging #95 (2d159dd) into main (e257bc5) will increase coverage by 6.99%.
The diff coverage is 41.50%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   26.80%   33.80%   +6.99%
==========================================
  Files          20       21       +1
  Lines         791      997     +206
  Branches      395      512     +117
==========================================
+ Hits          212      337     +125
+ Misses        398      340      -58
- Partials      181      320     +139

Impacted Files
Coverage Δ

tests/unit_tests/Pizza/Pizza_test.cpp
41.50% <41.50%> (ø)

src/Core/Pizza.cpp
65.62% <0.00%> (+65.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e257bc5...2d159dd. Read the comment docs.


Corrupted MathJax in StackEdit 4.3.11. StackEdit 4.3.10 OK

StackEdit 4.3.11 produces corrupted mathjax, with most MathJax missing (it briefly displays, then disappears); 4.3.10 does not. I'm afraid to refresh my chrome browser.

I can't reproduce the probleme here. Can you provide your browser/OS versions and a way to reproduce?
Thx

Sorry: now I cannot reproduce the problem either, after refreshing StackEdit. I'm using Mac OSX 10.10.1.
The browser is Chrome Version 40.0.2214.94 (64-bit). It may have been my use of footnotes--I don't recall. What I've done is create the page http://deniallogic.blogspot.com/p/stackeditio-test-page.html to track changes in StackEdit.io as the version number changes. If the page fails to display properly, I'll have something to show.


Uninjecting not working properly

When you uninject it goes away, but the dll stays "hooked" to csgo, and you can't delete / rebuild the dll

You haven't unloaded something, maybe you have added a new hook that you forgot to unload/unhook when uninjecting


[pulsar-websocket] remove getters and setters from websocket config

Motivation
Removing Getters and Setters from websocket proxy config and use lombok instead.

/pulsarbot run-failure-checks


Add GeoRegion property to DeletedSite model

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[X] The OpenAPI Hub was used for checking validation status and next steps.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node


Add Mailchimp Access, Progress Bar

What's Changed

Added a progress bar to image uploads
Update seed.rb to make admin user confirmed_at
Add gibbon integration to link to Mailchimp.

What's next.
I don't know how to stub the gibbon call to fake this as a test. Anyone have any ideas? (@RickCarlino, @md5, @guitsaru)

Coverage decreased (-0.12%) to 99.81% when pulling 3ec993052d25a84cc78dbf1d56ceb78c51cb756f on simonv3:small-fixes into e253e8f737911c65d2893ed5d8081f3d9d27d78d on openfarmcc:master.


Add end-to-end encryption

Some self-hosted photo libraries offer end-to-end encryption (e.g., Ente), while others store photos unencrypted (e.g., Immich).
This may be considered an asset (enhanced privacy) or an issue (the server is unable to see/read photos, so most features must be done in the client, for example face detection).
At least to me, this is an important thing to consider when choosing a photo library.

Yes, it seems to be the same. I apologize for not being able to find it in my search before opening this one.
Even though I believe the title of the linked issue is a bit misleading: from my understanding, encryption for data at storage may be implemented in different ways (e.g., the server may hold all the encryption keys), while end-to-end encryption (e2ee) strictly implies the client to hold the keys. However, reading the linked issue in Immich repo and the discussion in #68, it is clear that it actually refers to e2ee.
I will close this issue.


Some grouped objects has no anchor for arrows

Hello,
I draw a computer with the line tool. My drawing is composed with lines and polygons. Then, I group all the lines and polygons to have an unic object.
But then, my unic object has no anchor for an arrow.
The only way I found to have an anchor, is to use a square or a circle in my drawing. Then the grouped object has an anchor zone around the included square or circle.
It's not clean

Yea, I agree. We should probably allow groups to be bindable irrespective of what shapes they're comprised of.

Any suggestions on how to get started on this please?


bibtex引用 jieba

作者你好, 我要在毕业论文中使用jieba, 有引用的格式吗?
像pkuseg提供了如下格式
@inproceedings{DBLP:conf/acl/SunWL12,
author = {Xu Sun and Houfeng Wang and Wenjie Li},
title = {Fast Online Training with Frequency-Adaptive Learning Rates for Chinese Word Segmentation and New Word Detection},
booktitle = {The 50th Annual Meeting of the Association for Computational Linguistics, Proceedings of the Conference, July 8-14, 2012, Jeju Island, Korea- Volume 1: Long Papers},
pages = {253--262},
year = {2012}}

我找了下, 没找到jieba的.

我有相同的问题

估计没有，可以加个脚注


Rel v1.2.19

Log from successful switch from UEFI to Heads on v1.2.19-rc2: https://paste.dasharo.com/?f0dfe52c8d0783ef#7K3rBu4sCqMS9ggyQkDfBwAhhSpzaSFN4BzEE82ejbf


Update issues ~ it won't update

Operating system: Windows 10
Messenger for Desktop version: I have no idea, but...

Since it keeps asking me to update to 2.02, I assume I have whatever version before 2.02. The problem is that it doesn't actually update.  Then it'll say something about nwjs being unresponsive and asking me to restart, which just gets stuck on the loading animation again.
Does the update just take long to install and I should just wait for it to finish eventually or would I just be staring at the loading screen for nothing?

Same issue here, at startup.

Same here. Downloading the installer also doesn't help as it's the same exact size as the previous version, so it doesn't seem like it was updated to 2.0.2

Where did you get the version 2.0.2??

I didn't, that's the problem.

@ForumLiker I'm pretty sure the version displayed by this popup has nothing to do with the version of the app. It's more about a Javascript runtime, or a component from Electron.

@ForumLiker Read our request again. We don't have 2.0.2. I tried with both 2.0.1 and beta, and both are asking me to upgrade to 2.0.2 on startup.

@Laliat @hickscorp @PixelPolish
There's no issues, but you guys are starting the old application instead of the new one.
Just uninstall the messerger (all of them you can find), and install the latest release from the dev here - v2.0.1

@TheHaso & @ForumLiker I think I get what's going on. The version set for download on the main website is 1.5. Maybe that old version had problems. I'm trying to download the 2.0.1 now, but the S3 bucket is slow as a slug, my download stall around 5MB.

Ok,i have same problem ..i updated my version,and  i start program  from :internet"s programs-as administrator..Work for me now..

Heh, yeah, seems like it was a problem with 1.5.0 from the site. Fixed now ;)

Its work fine with my Zorin Os

I updated to 2.0.2 and got a virus, I'm pretty sure 2.0.2 is a fake, don't update!
I entered another issue for that: https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/804

@mikegron
There is no v2.0.2, i dont know what you downloaded, but that thing you reffer to is an ad and skipable.

@TheHaso
That's my point. If you open the app version 2.0.1, it tell you there is an update for version 2.0.2, and clicking the "ok" button doesn't do anything. I didn't know 2.0.2 didn't exist until I checked the releases here but the download link on the website includes a virus.

@mikegron
I see, thats very bad if its the case. Im currently sticking with Rambox and have top-notch experience.
Posted about it at #805 so others can be aware.

Please try the latest version: https://github.com/aluxian/Messenger-for-Desktop/releases


Comments link to non-existing repository

We have a team (private) repository owned by the team's leader, and a bunch of Github users having access to it and proposing Pull Requests. In the comment, @pep8speaks links to the changed files and lines having errors. Unfortunately, the link (generated here: https://github.com/OrkoHunter/pep8speaks/blob/master/pep8speaks/helpers.py#L217) points to the PR authors' non-existing repositories rather than the team's repository.

@jasiekmarc I believe the bot runs on the branch of the author of the PR. So, if the branch is on the fork of the user, it would like over there. I did not get the part when you say that the author's repository does not exist. How does he create a Pull Request then? Is it created from the same repository with a different branch?

Exactly. We just create branches in the original repository, and them merge them to master.

Okay thanks. I'll take a look in the github payload and modify which url to use. If you have the fix, it'd be great if you could submit a PR.

Closing this issue. Please re-open if the error still persists.


can we set maximum allowed line length to 120 please

https://github.com/tortellini-tools/action/blob/05858fd84966ddaecbb8a0d8a1c636d58dea715e/.prettierrc.json#L2

I decided that we should keep it as it is.


Updates velero to be overrideable but set during install

From @karthikperu7's PR yesterday I built off of that and the feedback that @drewandersonnz had to initialize velero with a sane default, but check on container initialization to see if the env is overridden and then reconfigure velero from there.

Previous PR: https://github.com/openshift/ocm-container/pull/22

Previous PR: https://github.com/openshift/ocm-container/pull/22


Interface for GPU

If I understand  the code correctly , currently it would only run on CPU.  It would be nice and necessary for run.py to accept an optional parameter that specifies the GPU number and to run the code on the corresponding GPU.

Caffe runs on both GPU or CPU. It is specified in your solver.prototxt. See for example the line from the the default MNIST experiment. CWSM only starts the Caffe instances (which run on GPU), so for CWSM itself CPU is enough.

Right, I understand. But in our case we have several GPUs in the lab and we usually use "--gpu 2" for example to specify which GPU it should run so that people in the lab don't interference with each other. It's a minor feature though, I admit.

Ah, I see now. You can use gpu: 2 as a parameter in the solver.prototxt.

Hm, I didn't know I could specify it in solver.txt. Thanks! And it should actually be device_id : 2


Remove mysqlclient from requirements.txt

The following is listed in the main requirements.txt file:
mysqlclient==2.0.1
Which ties all installations to MySQL, this should be removed to make the project more database agnostic.

This is a great point. I would say if we want to execute a PR, it should include appropriate documentation updates to the current deployment documentation so that this oversight doesn't create further deployment issues. I think inserting the requirement in the current documentation at the right place would be a sufficient change to accompany the removal from the requirements.txt file.

You can see the updates to the documentation in https://github.com/PowerDNS-Admin/PowerDNS-Admin/pull/1302 not going to say I've gotten all of it out but the database dependencies are being moved out to the database setup guides.

@dmcken This looks good.
Would you mind addressing this minor issue in the MySQL DB setup documentation? If you need help with the command I can provide but I imagine you already know Yum.

PR #1310 should resolve that.


Request received from pocketbase but a timeout error is received

I am currently trying to grab a task record from the collection task using pocketbase. The request is being sent to pocketbase and I can see the result in pocketbase but it is still getting sent to the application as a UND_ERR_CONNECT_TIMEOUT error
Below is the code that is being used to call the response.
I am also using NextJS, react and typescript if that helps at all.
async function getTasks() {
  const client = await createClient('http://<IP_ADDRESS>:8090/api/');
  let res = await getOneTask(client, "zzh8h375zryoko6")
  let data = res.json();
  return data?.items as any[];

import pocketBase from 'pocketbase'

export const dynamic = 'auto',
  dynamicParams = true,
  revalidate = 0,
  fetchCache = 'auto',
  runtime = 'nodejs',
  preferredRegion = 'auto'

export function createClient(endpoint:string) : pocketBase {
   return new pocketBase(endpoint);
}`

import PocketBase from 'pocketbase'
import { Task } from '../../typings'

export function getOneTask(db: PocketBase ,  id: string) : Promise<any>{
    return db.collection('tasks').getOne(id);
}

This is also the full error message I am receiving:

event - compiled successfully in 267 ms (499 modules)
(node:79488) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
ClientResponseError 0: Something went wrong while processing your request.
    at new i (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:152:23)
    at eval (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:1364:31)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getTasks (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:23:15)
    at async TasksPage (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:28:19) {
  url: '',
  status: 0,
  data: {},
  isAbort: false,
  originalError: TypeError: fetch failed
      at Object.processResponse (node:internal/deps/undici/undici:5555:34)
      at node:internal/deps/undici/undici:5877:42
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:203:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    cause: ConnectTimeoutError: Connect Timeout Error
        at Timeout.onConnectTimeout [as _onTimeout] (node:internal/deps/undici/undici:2316:28)
        at listOnTimeout (node:internal/timers:566:11)
        at process.processTimers (node:internal/timers:507:7) {
      code: 'UND_ERR_CONNECT_TIMEOUT'
    }
  }
}
ClientResponseError 0: Something went wrong while processing your request.
    at new i (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:152:23)
    at eval (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:1364:31)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getTasks (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:23:15)
    at async TasksPage (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:28:19) {
  url: '',
  status: 0,
  data: {},
  isAbort: false,
  originalError: TypeError: fetch failed
      at Object.processResponse (node:internal/deps/undici/undici:5555:34)
      at node:internal/deps/undici/undici:5877:42
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:203:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    cause: ConnectTimeoutError: Connect Timeout Error
        at Timeout.onConnectTimeout [as _onTimeout] (node:internal/deps/undici/undici:2316:28)
        at listOnTimeout (node:internal/timers:566:11)
        at process.processTimers (node:internal/timers:507:7) {
      code: 'UND_ERR_CONNECT_TIMEOUT'
    }
  }
}
ClientResponseError 0: Something went wrong while processing your request.
    at new i (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:152:23)
    at eval (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:1364:31)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getTasks (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:23:15)
    at async TasksPage (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:28:19) {
  url: '',
  status: 0,
  data: {},
  isAbort: false,
  originalError: TypeError: fetch failed
      at Object.processResponse (node:internal/deps/undici/undici:5555:34)
      at node:internal/deps/undici/undici:5877:42
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:203:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    cause: ConnectTimeoutError: Connect Timeout Error
        at Timeout.onConnectTimeout [as _onTimeout] (node:internal/deps/undici/undici:2316:28)
        at listOnTimeout (node:internal/timers:566:11)
        at process.processTimers (node:internal/timers:507:7) {
      code: 'UND_ERR_CONNECT_TIMEOUT'
    }
  }
}
ClientResponseError 0: Something went wrong while processing your request.
    at new i (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:152:23)
    at eval (webpack-internal:///(sc_server)/./node_modules/pocketbase/dist/pocketbase.es.mjs:1364:31)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getTasks (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:23:15)
    at async TasksPage (webpack-internal:///(sc_server)/./app/Tasks/page.tsx:28:19) {
  digest: '52118215'
}

Are you sure that you are using the correct url?
If it is not a typo, http://<IP_ADDRESS>:8090 should be http://<IP_ADDRESS>:8090.


(maint) Bump to latest trapperkeeper/jetty9/kitchensink

This bumps us to the latest revision of TK/jetty9 for the purposes of bumping
the schema dependency. I've also upgraded to the latest kitchensink just for
maint purposes mainly.
Signed-off-by: Ken Barber<EMAIL_ADDRESS>

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1040/


Add Log analytics query execution API support

Feature Request

Currently working on a project that requires us to track resource usage on an ACI virtual node within an AKS cluster. Log analytics workspaces allows us to execute KQL queries to get the usage, but we require programmatic access to this feature.

The data-plane spec for this is https://github.com/Azure/azure-rest-api-specs/blob/main/specification/operationalinsights/data-plane/Microsoft.OperationalInsights/stable/v1/OperationalInsights.json

Is there any ETA for this feature? Would be good to know when this API can be expected in the new SDK.

Is there any ETA for this feature? Would be good to know when this API can be expected in the new SDK.

Well, it'd be great to get it ASAP. I don't have a particular ETA. For now, we're using this feature by making a plain HTTP request to Query Execute endpoint.(I works, but still looks hacky)

Le lun. 18 juil. 2022 à 10:24 AM, Rohit Rajak @.***> a
écrit :

Is there any ETA for this feature? Would be good to know when this API can
be expected in the new SDK.
Well, it'd be great to get it ASAP. I don't have a particular ETA. For
now, we're using this feature by making a plain HTTP request to Query
Execute endpoint.(I works, but still looks hacky)
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-go/issues/18443#issuecomment-1186909954,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYUHILT4N5RQJOTHOK6XKF3VUUICDANCNFSM5ZK7XUDA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@Rohitrajak1807
want to share the code? is there any good way to use the new azure-sdk to send requests?

@Rohitrajak1807 want to share the code? is there any good way to use the new azure-sdk to send requests?

https://gist.github.com/Rohitrajak1807/b1605d8ec8dc0fb8a58faa1e14ed9943
This is a working example.

any progress here?
the old sdk is deprecated and there is no replacement currently.

Please take a look at the azquery` module as it contains some of this functionality (and other).

Please take a look at the azquery module as it contains some of this functionality (and other).

Thank you @jhendrixMSFT will check it out.

@Rohitrajak1807 can you confirm you were successful with the azquery package.

@Rohitrajak1807 can you confirm you were successful with the azquery package.

I'll need some time. The project that required this feature is no longer being developed (it was a fast to fail product). I'll create a setup manually and go through the steps

Hi @Rohitrajak1807! I assume your use of the azquery module was successful since you released your module with azquery as a dependency. The azquery module is officially GA this week. We hope azquery addresses your needs and would love to hear any feedback you have.


discord stuck in square and not rectangle

current behavior on discord
intended behavior isnt supposed to be cropped

Just noticed I'm getting the same thing. Should be a full poster.


Not all servers serve all the jwk keys

This issue is imported from pivotal - Originaly created at Oct 23, 2019 by Bart Geesink
In production there are 4 servers for oidcng. Only 1 of them serves the key that has been rolled today.
That's also the machine that is the oidcng_cronjobmaster

New OIDC-NG 1.0.3 release where prior to returning all public keys a call to a sequence collection is done to ensure the latests key(s) are loaded from the database. The same check is performed when decrypting / encrypting / signing and verifying. (Okke Harsta - Oct 24, 2019)


Update base image

In base image, a new provider random is added per the request from
users

@wonderflow @lowkeyrd Please help review the change.


Audio/SAI Redux C++

Summary
Rewrote SAI/Audio with pimpl approach.
SAI can now be configured with various samplerates (8k, 16k, 32k, 48k, 96k)
Adjusted PLL3P Clock output to be at a high enough rate for all of those samplerates.
Moved the conversion functions (i.e. s242f(), etc.) to daisy_core.h instead of daisy.h, and added signed 32 bit conversion functions as well.
SAI can now be used independently without using the AudioHandle (if one desires), by passing in buffers, and a User callback. This callback is called directly from the SAI DMA Interrupts, and passes the data as int32_t in the bitdepth/format specified by the SAI config.
Previously the Audio handle was actually where nearly all of the audio code was. Now it's essentially a wrapper around the SAI that provides interleaved/non-interleaved callbacks. Not sure if we should leave this separate, or just merge it with the SAI. (Since the actual device driver is now separately configured outside of both of these classes this might just be redundant abstraction).
Given the magnitude of these changes I propose we (finally) begin to version libdaisy. So those concerned with backward compatibility or breaking changes can be aware if/when they occur.
In Progress

[ ] Multi-codec operation still hasn't been added back in (so the patch examples will only be the first two channels right now.
[ ] DaisySeed interface should allow configuration for setting the samplerate/blocksize since that can only be set at Init time.
[ ] Changing Callbacks while running should still be possible without having to stop/start the DMA as it will be just a function pointer change. The functions just need to be implemented.
[ ] Checks for max block size, etc. in Audio Init

Impact on Examples/Existing Code
This should not break compatibility with previous code that used the DaisySeed, or other breakout board APIs. However, code that did not use that level of abstraction will require some adjustments to work.
Nearly all examples still build (A few old seed examples that use the dsy_audio_* functions need to be adapted)
Multi-Codec support needs to be added for the Patch examples to work correctly again.
DSY_AUDIO_SAMPLE_RATE was removed, and should be deprecated as samplerate can now be configured.
Other Notes/Issues
The Internal Callback in the AudioHandle class is very long, and adds a lot of potentially unnecessary code size for handling the various possible bit-depths from the SAI. I'm very open to alternatives on handling this.
I hard coded buffers for the Audio handle so that this continues to be easy for beginner users to get audio up and running quickly without them having to configure buffers in the correct RAM section.
Originally, I wanted the Audio Handle to be able to handle the SAI, and Device based on some configuration, but this would require passing in loads of different configs for the various peripherals (sai, gpio, and potentially i2c for certain codecs). So for right now the device should be initialized between the SAI init and the AudioHandle Init.
Protocol/Bitdepth are tied together for now, this could be separated (maybe it should) into separate config options (i.e. bitdepth as-is, and protocol options such as I2S_STANDARD, I2S_MSB_JUSTIFIED, etc.) I was attempting to provide as much flexibility while still keeping it practical to the expected/common use-cases.
The I2C peripheral uses a global init to configure its software DMA dispatching, but I didn't see this as necessary for the SAI so it was ommited.
Not directly related, but the DMA stream organization is only going to turn into a bigger mess as we add more functionality to libdaisy. This is a better topic for a new github issue, or something, but there is no easy way to tell what streams are for what peripherals, purposes right now without jumping through a bunch of files. Even with only 6 DMA streams set up it's already confusing.

@TheSlowGrowth curious on your thoughts on some of this. 😄

 Audio Update (CPP, SampleRates, etc.)


Add Windows Instructions for LAME

Just for those of us who like to test on Windows, and then distribute using Linux.

Thank you for your contribution. And I apologize for my late response. I'll apply your changes.


Remove pry

Probably don't want it by default, no?

@isaacseymour - I've also set up travis to track, so we'll get a build report for this PR.

@isaacseymour - I've also set up travis to track, so we'll get a build report for this PR.

This means you have to explicitly require 'pry' whenever you want to use binding.pry which is a bit of a pain :/

This means you have to explicitly require 'pry' whenever you want to use binding.pry which is a bit of a pain :/

Yep, but not sure the gem should be opinionated on how to do debugging. Up to you!

Yep, but not sure the gem should be opinionated on how to do debugging. Up to you!

True!

True!

Failure is unrelated. Should be fixed by https://github.com/gocardless/activejob-retry/pull/8

Failure is unrelated. Should be fixed by https://github.com/gocardless/activejob-retry/pull/8

Also, we'll need to special case on the Ruby version if you want to keep this in. See https://travis-ci.org/gocardless/activejob-retry/jobs/45612172

Also, we'll need to special case on the Ruby version if you want to keep this in. See https://travis-ci.org/gocardless/activejob-retry/jobs/45612172

Ugh, definitely not worth it. Let's merge.

Ugh, definitely not worth it. Let's merge.


Permissions grant prompt links to sketchy empty organization

In addition to the extremely broad permissions this extension requests, I also found another part of the permission grant process concerning.

GitHub for VS Code by Visual-Studio-Code

wants to access your sparr account

That link goes to a completely empty organization. It has a name and two links (website and twitter). No repos, no projects, no members. It looks exactly as it would if a malicious actor created an empty org, which they could right now with a name like VisualStudio-Code (which is available).
On top of that, it's also a little strange that the extension from this repo is requesting permissions using a key/cert/whatever for an organization that doesn't own this repo, with a name that doesn't match this extension.
I'd feel a lot better about granting this extension at least some permission (in a future where #167 makes some progress) if this was addressed in some way.

On top of that, it's also a little strange that the extension from this repo is requesting permissions using a key/cert/whatever for an organization that doesn't own this repo, with a name that doesn't match this extension.

That is the official VS Code organization used by the VS Code GitHub login flow, it's nothing this extension can control.

In addition to the extremely broad permissions this extension requests,

Unless you enable organization features, the extension shouldn't request any additional permissions besides what the VS Code GitHub integration requires.

it's nothing this extension can control.

It's probably not a reasonable approach and not one I'd request or recommend, but this extension could do its own github auth, using its own cert/key. Or, more reasonably and as requested in #167, it could optionally just not talk to github at all.

the extension shouldn't request any additional permissions besides what the VS Code GitHub integration requires.

I don't know if there's a way for a user to tell that it's the integration requiring the permissions in question.

https://github.com/cschleiden/vscode-github-actions/blob/main/src/auth/auth.ts
Code rearranged and clipped for clarity:
const DEFAULT_SCOPES = ["repo", "workflow"];
const ORG_SCOPES = [...DEFAULT_SCOPES, "admin:org"];
function getScopes(): string[] {
  if (orgFeaturesEnabled()) {
    return ORG_SCOPES;
  }

  return DEFAULT_SCOPES;
}
export async function getSession(): Promise<vscode.AuthenticationSession> {
  const existingSession = await vscode.authentication.getSession(
    AUTH_PROVIDER_ID,
    getScopes(),
    {
      createIfNone: true,
    }
  );

The repo scope you're requesting is the one that "Grants full access to public and private repositories including read and write access to code, commit statuses, repository invitations, collaborators, deployment statuses, and repository webhooks. Note: In addition to repository related resources, the repo scope also grants access to manage organization-owned resources including projects, invitations, team memberships and webhooks. This scope also grants the ability to manage projects owned by users."

Can you recommend a more appropriate place to file an issue against the integration this extension is using?

The official github authentication extension lives here: https://github.com/microsoft/vscode/tree/b72671133b00473ea3494c01d8dea71965fda5a2/extensions/github-authentication

Regarding the repo scope: yes, it's true that this gives a lot of access. However, there is no alternative if you want to access any repository information at all: https://docs.github.com/en/developers/apps/building-oauth-apps/scopes-for-oauth-apps
In an ideal world, there would be a way to get only read access to public repos, or to get only read access to the workflow APIs for public repositories, and only request write access when needed but currently that's not possible.
As mentioned above, the only thing that could be done is to provide only the static YAML editing features without displaying workflows and runs and dynamic auto-completion as suggested in #167


🐞 [BUG & FEAT] - Add Txt at correct place and also add ad blocker to the site and requesting message too!

Description

here is the code-
google.com, pub-6172950963478417, DIRECT, f08c47fec0942fa0
Current behaviour
No txt file
Expected behaviour
add txt file
Reproduction steps
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots
![DESCRIPTION](LINK.png)

Logs
No response
Browsers
Chrome
OS
Mac
Are you contributing for a program ?
GSSoC2023
Code of Conduct

[X] I have read and agree to the CONTRIBUTING GUIDELINES of this project.

I would like to work on this issue, Can you assign me this issue. Also can you elaborate a little on issue.

Can you please tell more about this issue. I would love to work on this. I'm a GSSoC23 contributor.

I changed the issue! Now who so ever comment first..issue will be assigned to him/her

I would like to work on the issue, please assign me under GSSoC'23

ok!

what's the update? it was the easy one?

Adding an ad blocker to the site and Requesting a message is yet pending, other than that the file is added in the right directory. Will update accordingly @anmode

Hey @anmode I have added the ad blocker detector and the requesting message too, How are we going to verify whether it's working or not? I need a help in this bit. Thanks!

Hi @Ayan-M-Dev. Sorry I got a bit busy.
so yes there are ads on site. actually today many browser has adblocker...
So Idea is to show overlay scrren with the message "Somethings like we provide notes free and we needs to have ads for site maintance. we have to pay hosting price" you can use ai for message btw.
so when the use remove adblocker site should be continue working.

To test:
run the on localhost on browser with adblocker.... the code should prompt this type of message

Hey @anmode I have implemented the code part but it is still not working or maybe I am not able to verify it. Little help on this part would be great. I have done all the changes in the forked project. Thanks!

please create PR.. Then I would be able to provide some. thanks

Created PR, Pl. check. Thanks! @anmode

Created PR, Pl. check. Thanks! @anmode

create new issue and tag issue in pr


framework-core: cannot use with octokit v16

Other integrations may use different versions of octokit. For example, probot applications use octokit v16

This may just be a typescript thing - trying casting between octokit v18 and v16 types and it might just work.


Include binary in the release

User Story

As a user
I want a binary included in the release
So that it can be tested without building it

Acceptance Criteria

Include Binary in the release

Build Binary in CL-pipeline

Definition of Done

Code has been tested
Optional Logging has been added
No errors (syntax, unit tests, etc.)
Peer reviewed by at least one additional person
Acceptance criteria met
The code was merged into the main branch via pull request

I would suggest the usage of pkg: see https://blog.sivamuthukumar.com/vercel-pkg-nodejs
Our Github Actions file is here: https://github.com/amosproj/amos2022ss08-openid-connect-doctor/blob/main/.github/workflows/continous-integration.yml

This issue has been fixed. There were minor errors that were fixed, I have triggered the job and it generates the binaries and get attached to the release.


Round2 update

KpqC Round2 submission 0a733db
a few changes applied (hwt.h)

from 0a733db`` v3.0.1-submit-kpqc-round2-0228


[kueuectl] Add Pass-through commands

What would you like to be added:
Kueuectl Pass-through commands as described in  https://github.com/kubernetes-sigs/kueue/tree/main/keps/2076-kueuectl#pass-through.
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

/assign


SOS Request for Urgent Help

In certain situations, my request may be extremely urgent and I may be in immediate danger. In these cases I need ways of communicating information to my org that maintains my safety and communicates the severity of the problem.
SOS Request
If I indicate a severity level of Urgent, I want additional features to pop up:

[ ] I want to be able to intidicate an urgent SOS that says I need help

[ ] I want my device to start recording audio when I make an SOS

[ ] I want my device to constantly broadcast my location when I make an SOS

[ ] As a user I want to indicate if it is safe to reach me or not

[ ] As a user I want to set a "safeword" that indicates I need help but doesn't compromise me if I am in danger

[ ] As a user I want a way to submit a request for help without sacrificing my safety (maybe shake or triple click or something interesting)

So I've started to look at/think about this.
The first step here is to try and find a good place for a button that will start the SOS process:
https://xd.adobe.com/view/4c48f65a-1a75-46d0-7498-f1c877d4e218-3a79/
The next part will be confirming that the button press is not accidental. The design here will feel really weird because the emphasis is on a simple question
'Are you in immediate danger?' -> Yes/No
No takes you back to TenFour, Yes will take you through some steps to send this SOS.
We need to huddle on what functionality is good for v1 of this. I propose:
A standard 'I'm in immediate danger' check-in is sent to a configurable set of people (configured by the admin) or it's sent to everyone in the app on that account.
If GPS location is enabled by the user sending the checkin, it's included in the checkin info.
The next step is really who not in danger is responding to this SOS? The default answers to an SOS check in from people not in immediate danger could be: 'I am not available to help' 'I'm available to help'
This enables the org to start co-ordinating the help effort.
Next questions re scope. are:
Do we allow the person in immediate danger to either type or record audio of details about what is happening? How is audio parsed? Can we offer huge buttons that describe things like 'Fire' 'Flood' 'Crime' 'Attack'
Do we only send the SOS to people in close proximity to the person in SOS danger?
Do/how do we notify the person in danger that help is either on the way or still pending? (Our Design Jam's raised the importance of feedback to the person in danger to receive updates and/or tips to ensure safety e.g. not moving location unless the environment is dangerous.
I have more questions but I think a group thinking session is needed with this feature.


Use arrow functions where possible to help with minification

This should help reduce the size of the package by using implicit returns and allow minifiers to declare multiple constants with just one const keyword.
Example:
with functions:
function one(){return "1"};
function two(){return "2"};
function three(){return "3"};

with arrow functions:
const one=()=>"1", two=()=>"2", three=()=>"3";

Hey @VIKTORVAV99! 👋
Thanks for your PR, I appreciate it a lot!
I'm not yet sure whether it would make sense to add this change. I assumed that minifiers already change them to arrow functions when possible to compress their size. But on the other hand I just checked Skypack (source) and Bundlejs (source) and they indeed preserve the function declarations. 🤔

Just checked the size report in https://github.com/dcastil/tailwind-merge/actions/runs/10058157215/job/27879795604?pr=449#step:9:33. In comparison to the last size report in https://github.com/dcastil/tailwind-merge/pull/444#issuecomment-2212489002 it looks like this reduces the size by around 0.4% uncompressed, 2.4% minified and 1.2% when miniifed and brotli-compressed.
Nothing too crazy, but looks like an improvement. Let's just do it then. 👍

Terser goes one step further than most other minifyers but I think this makes sense as plenty of people use Vite with ESBuild for example (like we do at Electricity Maps) since there is a big difference in performance. So I'm glad to see you think it makes sense as well!

Yeah we also use Vite like many others at my work, so makes sense to go the extra mile. Thanks again for the PR!
By the way just compared the results:
Before: https://cdn.skypack.dev/tailwind-merge@2.4.0?min imports https://cdn.skypack.dev/-/tailwind-merge@v2.4.0-SLvupcG2OtzkOsjfrv7s/dist=es2019,mode=imports,min/optimized/tailwind-merge.js which is 21.5 kB minified. 51 function keywords, 62 return keywords.
After: https://cdn.skypack.dev/tailwind-merge@2.4.0-dev.38db48d362b45aab9ba7e2e05aef4c36abab6edb?min imports https://cdn.skypack.dev/-/tailwind-merge@v2.4.0-dev.38db48d362b45aab9ba7e2e05aef4c36abab6edb-8NJ5BgX8RdAs58xjlwlX/dist=es2019,mode=imports,min/optimized/tailwind-merge.js which is 21.0 kB minified. 7 function keywords, 40 return keywords.

A small reduction but considering how many people use your package the collective savings will be significant!


nixos/lidarr: Add dataDir option

Motivation for this change
This will bring this module to a state to be consistent with how the
other forks (sonarr & radarr) works.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg test lidarr


Data locality

remaking from notional-labs repo.
This PR is for stage 1 of

#548

thanks!

Hey, sorry about that guys.  I began this branch from the branch for the earlier pr #554
I'll close and re-open from main.
I'm currently on vacation, but I've asked Tuan (@baabeetaa ) Khanh (catshark) and Vuong to have a look at this over the weekend.  BRB with a fresh one.


Proposal: allow for multi-inspect of images and containers through remote-api

Currently we can only inspect a single image or container. It would be great as part of the listing of all images or containers to be able to specify a parameter, something like '/images/json?inspect=true' which will return all images/containers in their 'inspected format' instead of the summary we get now. Thoughts?

ping @crosbymichael - is there any reason why we don't just return the full json for each image?
If we're concerned about performance for docker images -a and we want to keep this summary form, I think what @cdancy suggests make sense but I would rename it to ?full=true instead.
Thoughts?

ping @icecrime @crosbymichael ^^ https://github.com/docker/docker/issues/9596#issuecomment-121427605

Closing as there does not seem to be much talk going on around this area.

I think the main reason is that the /images/json and /containers/json only return information that's actually needed for the endpoint.
Having said the above, while the API doesn't have an option to inspect all containers/images at once, it is possible by combining some commands, e.g.;
docker image ls -aq | xargs docker image inspect

@thaJeztah that makes sense it would just be nice to have a paged version of these like other restful api's do is all.

Yes, pagination has definitely been discussed a couple of times (possibly using a graphql API), but there's a lot of work involved in that, and I don't think anyone had the bandwidth to turn that into reality 😅

@thaJeztah that would be very nice indeed :)


Use std::array instead of C-style arrays

Description
This PR replaces C-style arrays in sf::Tranform and sf::priv::Matrix with std::array.
The main motivation is to make testing the Transform class easier. I created this to contribute to the discussion in #1973.
By having the underlying matrix as an std::array, it makes it possible to compare matrices in a single statement using comparison operators on std::array which plays nice with doctest macros.
As floating-point values need a tolerant comparison for tests and doctest::Approx only handles single values, the utility class ApproxArray is proposed to compare floating-point arrays.
I looked for other opportunities to replace C-style arrays with std::array. There are other places where C-style arrays are used, but I feel replacing them with an std::array brings no benefit, so I did not do it.
Many functions are taking a pointer and a size, but this is not where std::array would be useful. This is where std::span would be nice but it is not available with C++17, only from C++20.
Tasks

[x] Tested on Linux
[ ] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?

CI
Checking debug strings are sensible when running ./test-sfml-graphics --success --test-case=sf::Transform*

I like this! It's great how this lets us keep using the CHECK macro which gives us line number info without us having to write any macros.

SFMLBuildMaster: Build this please.

Thank you for your quick feedback. I think it is ready now so I converted the draft PR into a regular PR. I will squash my commits when we agree.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

As having std::array in sf::Transform's interface does not seem so elegant after all, I tried another approach with just a few additional testing utilities. I looks better now in my opinion.

I find it odd that we're keeping a C-style API detail in spite of how much work it imposes on us trying to test it. The fact that we have to jump through hoops to test this function should be an indication that a raw pointer maybe isn't the best return type we can pick. I think std::array is our best bet currently but it's worth looking into if there should be a sf::Span that handles cases like this.

SFMLBuildMaster: Build this please.

I am sorry for the back and forth (and that the branch name is not relevant now), but I feel std::array without std::span does not bring much.
In the meantime, this PR makes tests simpler, which was my original goal, with little changes.

In the meantime, this PR makes tests simpler, which was my original goal, with little changes.

Select parts of the tests are simpler at the cost of more hidden complexity elsewhere. We're slowly building an ad hoc testing library. If our intention is to have a private library for implementing tests (including stuff like all the operator<< overloads) then let's lean into that idea and make it an intentional choice instead of an incidental one.
I'd argue that if you need an extra library to test your library then that highlights issues with the library you're testing. We should be thinking harder about why we need everything inside TestUtilities instead of simply adding more and more to that directory.

I'd argue that if you need an extra library to test your library then that highlights issues with the library you're testing. We should be thinking harder about why we need everything inside TestUtilities instead of simply adding more and more to that directory. In an ideal world, TestUtilties wouldn't need to exist.

I think it is more an issue with the programming language than the library. Ideally, a testing framework like doctest would not be needed.
Anyways, I will start over after #1979 gets merged.


helm install process gives different names for ingress controller

In the basic configuration the ingress controller is named ingress-nginx:
helm install **ingress-nginx** ingress-nginx/ingress-nginx `

but in both of the customized configurations (internal IP and the normal "Create an ingress controller") the ingress controller is named nginx-ingress:
helm install **nginx-ingress** ingress-nginx/ingress-nginx `

This causes problems if you continue on to the Use TLS with an ingress controller page, which tells you to modify the ingress controller named ingress-nginx:
helm upgrade **ingress-nginx** ingress-nginx/ingress-nginx \

These should all be consistent.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fd0e7d5a-37e9-07dc-f395-9cb5bb580e45
Version Independent ID: 7e4faf70-9724-7e7b-832b-1cd99a974920
Content: Create an ingress controller in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/ingress-basic.md
Service: azure-kubernetes-service
Sub-service: aks-networking
GitHub Login: @asudbring
Microsoft Alias: allensu

@mcarson75
Thanks for your feedback! We will investigate and update as appropriate.


[vendor-change] CloudWatch Mixer adapter

Adding an adapter to send metrics to cloudwatch

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ldemailly
Assign the PR to them by writing /assign @ldemailly in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @narehayrapetyan. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I wasn't able to push to vendor to add a cloudwatch dependency. As far as I understand it I need to push to a new branch in vendor and not my fork correct? When I try to do that I get permission denied.

/ok-to-test

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
ef0993f47ebcccfec691c586b282bf2eb09218de
link
/test istio-presubmit

prow/istio-unit-tests.sh
ef0993f47ebcccfec691c586b282bf2eb09218de
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan have you read through: https://github.com/istio/istio/wiki/Vendor-FAQ#how-do-i-add--change-a-dependency ?

can you redo the vendor part ?
I just merged #4231 which synced up with the master of vendor-istio

updated vendor and rebased

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ef0993f47ebcccfec691c586b282bf2eb09218de
link
/test istio-unit-tests

prow/istio-presubmit.sh
1ec973c91b749327d6876633d7720ff52d76a600
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1ec973c91b749327d6876633d7720ff52d76a600
link
/test istio-presubmit

prow/istio-unit-tests.sh
1ec973c91b749327d6876633d7720ff52d76a600
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

in theory we need to make a branch in vendor-istio for the build to work; let me add you as collaborator  in that repo so you can make that branch

@narehayrapetyan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
dfd151fa139207d519dad79bec9d3bdab7148cbf
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
dfd151fa139207d519dad79bec9d3bdab7148cbf
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
dfd151fa139207d519dad79bec9d3bdab7148cbf
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
13e81db8ef83efb1184334ba83ab4b5ea52e62fa
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
13e81db8ef83efb1184334ba83ab4b5ea52e62fa
link
/test istio-pilot-e2e-v1alpha3

prow/istio-presubmit.sh
2c84f275733fd7db7f94c83cd84370c34652612b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
13e81db8ef83efb1184334ba83ab4b5ea52e62fa
link
/test istio-pilot-e2e-v1alpha3

prow/istio-presubmit.sh
2c84f275733fd7db7f94c83cd84370c34652612b
link
/test istio-presubmit

prow/istio-unit-tests.sh
2c84f275733fd7db7f94c83cd84370c34652612b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly done but I pushed out of order, how do I restart the tests?

/retest

for prow /retest but for circle you'd have to click rebuild on each build
it may be easier to just change 1 comment and push

aka add a commit

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
13e81db8ef83efb1184334ba83ab4b5ea52e62fa
link
/test istio-pilot-e2e-v1alpha3

prow/istio-presubmit.sh
2c84f275733fd7db7f94c83cd84370c34652612b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

you need to have your vendor/ be 03fdbfd431206e29b48d3fa4edeab41d4a3f2ff8
and the Gopkg.* match

I'm not sure why the e2e tests are failing - the only errors I see are
error	Failed to port forward: dial tcp :9090: getsockopt: connection refused
error	Failed to complete Init. Error dial tcp :9090: getsockopt: connection refused
but then the tests continue it seems successfully.
Also, do I need to add anything to e2e to include the new adapter in the tests?
And for the racetest it says "Your build ran 3561 tests in unknown with 0 failures" but it still fails.

@narehayrapetyan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e36e64cb1de034f5e5d128b8e860acc29a7a75e4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-simple

prow/istio-unit-tests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-simple

prow/istio-unit-tests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
23d950d87970e4c5921779137a7fb2d7d74a91b9
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
162a7d19b5de20f73d4f75c89f73c50df3b7fbf9
link
/test e2e-simple

prow/istio-unit-tests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
af5e3b2efab9970b977c22cda0f695494747eb33
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

there are 3 or 4 in flight vendor changes, we need to decide the order
if this pr is otherwise ready to go it could go first (but you need to redo/update the vendor part)

I'm sorry that serialization is so painful. I did find a way to short cut 1 step by doing merge instead of squash and merge
So can you just get your istio PR in sync one more time with master, then redo this PR in vendor after pulling master of vendor

@ldemailly done

Sounds good to me, and apologies about all the churn on vendor
So you needed changes to go-control-plane or that just happened?
It's a bit odd there are files changed there without SHA change in the .lock
https://github.com/istio/istio/pull/4617/files#diff-bd247e83efc3c45ae9e8c47233249f18
vs for instance
https://github.com/istio/istio/pull/4617/files#diff-bd247e83efc3c45ae9e8c47233249f18
@kyessenov @nmittler  ^

@ldemailly FYI those two links are identical
Also note that the vendor adds for envoyproxy/go-control-plane aren't really due to this PR.  See #5076
It's not clear to me why Gopkg.lock isn't updated .... I would think it would be unless they were only transitive dependencies.
@narehayrapetyan have you tried reverting vendor and Gopkg.lock and then re-running dep ensure?

@ldemailly @nmittler I didn't add envoyproxy/go-control-plane specifically i just ran dep ensure. Let me rerun it see if there are any changes.

reverted vendor and Gopkg.lock and reran dep ensure but Gopkg looks the same

no worries, it's all good vendor wise

@geeknoid / @douglas-reid can you /lgtm this PR if it's good to go from your perspective as well
it's been open a while and would be great to merge!

@narehayrapetyan: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@narehayrapetyan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67d52c82c684be8a29e1d6cabbad5727127e38e6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@narehayrapetyan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67d52c82c684be8a29e1d6cabbad5727127e38e6
link
/test istio-unit-tests

prow/istio-presubmit.sh
67d52c82c684be8a29e1d6cabbad5727127e38e6
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

Just rebased the PR, no new changes added.

@narehayrapetyan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
a5ebe74bbfb651c08ee9d36ae4615bf4f88984e9
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

🎉

Thanks for all the help getting this merged, everyone.

Hi
Do you have an working example to send metrics to CloudWatch, I can not find much details in the istio documents on it


New proposal discovery system

Step:

Search topic tc39-proposal
see https://github.com/search?q=topic%3Atc39-proposal
Get Content (filename tbd)
Use individual proposal schema parse it
Record to dataset

CC @codehag

The non-prose source of truth is not the individual repos, but only the proposals repo itself (which represents the notes which represent plenary consensus, ofc). Adding a topic to each individual repo seems fine, but i don’t think data should be scraped from individual repos (which are often much slower to update than the main list anyways)

Sometimes the repos themselves are out of date, but the proposals repository is usually up to date, as more people are paying attention to it than individual repositories.


2021429: Guid should contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx).

$api->setCredentials("[".$integrator_key."]"<EMAIL_ADDRESS>"xxxxxxxxx");

my integrator key has precisely 32 digits with 4 dashes


Feature/flutter admob example

Implements the example for AdMob initialization with UMP.

@Harshit933 Thank you for your contribution! Adding here some comments about the code:

https://github.com/tiki/examples/blob/feature/flutter-admob-example/flutter/admob/lib/home_screen.dart#L107
The loadAd function should be just called once on widget initialization. If it is done in the onTap callback, it will be triggered in every button tap, causing unnecessary calls and potencial errors. You can call it in the initState as in this example

https://github.com/tiki/examples/blob/feature/flutter-admob-example/flutter/admob/lib/home_screen.dart#L89
In the onAccept callback you are using the loadAd method again.

https://github.com/tiki/examples/blob/feature/flutter-admob-example/flutter/admob/lib/home_screen.dart#L64
looks like this method is not used anywhere and could be removed

https://github.com/tiki/examples/blob/feature/flutter-admob-example/flutter/admob/lib/home_screen.dart#L77-L92
Avoid doing anything that is not UI related in the build method, because we don't have any control of how many times it will be called or when. In a stateful widget, the best option is to use the initState method, that is called only once, or in the constructor of the Widget class.

https://github.com/tiki/examples/blob/36859b51b9ce14acb04e67b3693b5aa53d5872b5/flutter/admob/lib/home_screen.dart#L133
We don't need the settings button anymore. You can remove it.

https://github.com/tiki/examples/blob/36859b51b9ce14acb04e67b3693b5aa53d5872b5/flutter/admob/lib/home_screen.dart#L35
Is this method necessary?

The thing with loadAd in initState is that the ad can only be loaded once on the page and after that ad is ran. We have to re start the app to load another ad. I agree with you that it would cause potential errors in the app when we are calling the same functions in the onTap and onAccept method . What can we do here?
loadBanner method was used to generate the id for the test ads to run on the test devices (in main.dart MobileAds.instance.updateRequestConfiguration(RequestConfiguration(       testDeviceIds: ['A9BFA2CD58BFD0F412F9B597C5C5B380'])); . We can still have it to generate test device id to test the ads. What do you think?
_setFullScreen method would make more sense in the real life applications. Sure I'll remove it.
Also I should've kept in mind about the build function and it's ability to refresh its content everytime the build reconstructs. I'll switch the offer to initState.

@Harshit933

The thing with loadAd in initState is that the ad can only be loaded once on the page and after that ad is ran. We have to re start the app to load another ad. I agree with you that it would cause potential errors in the app when we are calling the same functions in the onTap and onAccept method . What can we do here?
Got it, we need to load a new ad, that is why you call in onAccept. The issue here is that we don't know how long will it take to load the ad. Since we are loading one ad per screen, what do you think about using the Navigator pop from reward screen to load a new ad? We could load an ad in initState, and load a new one when the user comes back. In line 58 we can await on Navigator.push and then call _loadAd again.

@Harshit933 About the loadBanner method, it is not called anywhere. That is why I asked about it. If everything works without it, maybe it is unnecessary.

Sure, I will update the code tomorrow only. Thank you for the feedback!

@Harshit933 thanks for your PR. I will grab it from here since some requirements from the original issue changed.

Sure, let me know if there is anything that I can do

@mike-audi Flutter is ready for review


Add @nodesecure/ci-action to GitHub workflow

Seems to work : https://github.com/NodeSecure/cli/runs/5073363709?check_suite_focus=true


double master

simple scenario:
start node1, node2, node3 => node1 is the master, as seen by nodes 2 and 3
stop node1 => node2 becomes master, as seen by node3
restart node1 => node1 declares itself as a master. node2 still the master, as seen by node3
restart node3 => node1 master, node2 master, node3 sees node1 as master
when a new node becomes active, it is needed to come back to INITIALIZATION state.

fixed in branch dev-0.5


macOS xcode projects will require additional inputs to correctly skip the script phase

Switching build modes does not re-trigger the script. I don't believe this is currently an issue because the dart build is identical for release/debug, but this needs to be fixed before I can land full release mode support.
Alternatively, I could temporarily remove the xcfilelist inputs/outputs. The flutter tool would still correctly cache artifacts, so it wouldn't be a complete loss.

Actually, I might just have forgotten to add a dependency on the prebuilt engine...

Can the frameworks build to different directories depending on the Xcode build configuration?
Example: App framework output, embedding and linking at macos/Flutter/${CONFIGURATION}/App.framework.

(this would be awesome on iOS too)

This should handle custom build configurations, i.e. "App Store Release" (with spaces!) directory gets created and the release bits get generated and copied there.  New build configs should gracefully get added.

The way I've handled this for the build caching is by hashing all configuration to generate a unique build directory. I originally tried to update the macOS project to use whatever the last build directory but that a) requires a ton of coordination between xcode & flutter due to the re-entrant calls and b) doesn't work when you update the configuration from xcode.
One issue with specifying these output paths ahead of time is that the set of possible configurations is quite large due to the ability to specify an arbitrary entrypoint file.
I'd be interested in trying to find an xcode-idiomatic way to express these inputs/dependencies. But at the very least, we do have caching at the flutter tool level of the dill/assembly artifacts.


Support for multiple instances of same object

After the review, I'll proceed to update all examples containing this parser
@Mircho


feat: add filter based on a list of values

closes #993

I really don't like my in_values.insert(0, value);

This is fine :D If you want more idiomatic Rust, some of these might look better:
let mut new_vals = Vec::new();
new_vals.push(value);
new_vals.extend(in_values);

let new_vals = [vec![value], in_values].concat();

let new_vals: Vec<_> = Some(value)
    .into_iter()
    .chain(in_values.into_iter())
    .collect();

Thank you @eitsupi! Please tell me if the changelog looks ok to you


missing text line recognition alphabet

Hi, thanks for publishing code. when I try to use text recognition checkpoint, find that the alphabet generated by mine is different from yours. This could be due to the fact that I only used part of the data for training master test recongnition model.  Could you provide the ./tools/data/alphabet/textline_recognition_alphabet.txt file?

你好，请问你解决这个问题了吗？我也找不到这个文件

TableMASTER-mmocr/table_recognition/demo/alphabet/


Generator: Update SDK /services/elasticsearch

Generated from GitHub run<PHONE_NUMBER>

The service has been deprecated.