Fix beneficial owner form is not shown after revisiting the page

Details

The beneficial owner form depends on the form input values state. When revisiting the page, the form is mounted with an empty input values state. This PR initialize the state with the form draft values.
Fixed Issues

$ https://github.com/Expensify/App/issues/31848
PROPOSAL: https://github.com/Expensify/App/issues/31848#issuecomment-1828052447
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open Settings > Workspaces > Select any workspace > Bank account
Start the bank account process and fill the first 3 steps
On the 4th step, check the "Somebody else owns more than 25% of ..."
Verify a beneficial owner form is shown
Close the bank account page
Reopen the bank account and press "Continue with setup". The 4th step will open
Verify "Somebody else owns more than 25% of ..." is checked and the beneficial owner form is shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/6f6805dd-1179-4eb1-b33f-ce5cc95ab512

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/4cad75f0-0810-4853-9422-f1ff6f1fcf96

iOS: Native

https://github.com/Expensify/App/assets/50919443/fcab043b-aa1b-4082-b68a-b9d6ba8cec34

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/bde22995-1f13-4a89-8fdf-ed03ad3462d0

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/b4f5dfbd-a968-4edf-be50-3fd91022ccb9

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/8059b52c-a058-4614-a966-1c807217d791

@bernhardoj Is it the only place in the app where this bug occured? Or is there any way to skip the Onfido flow?

I have this issue (a "launching loop"):
https://github.com/Expensify/App/assets/2590174/1cb43b0b-6d56-42ce-b2a3-9f1d137ba9c1
I'm copying the link from the browser before the request completes, I'm not sure if it matters. I used my custom "Extreme" network delay profile in Chrome.

I never tried opening a /transition route deep link, but it should be unrelated to our issue, right?

This was supposed to land in another issue. Too many open Expensify tabs. Sorry!

Charleson

Doesn't skip Onfido for me 🙁

 ERROR  Warning: Failed prop type: Invalid prop `draftValues.beneficialOwners` supplied to `Form`, expected one of type [string, boolean, number].

@bernhardoj I wasn't aware that this occurred on main; it sounded related to our changes. Let's treat this as unrelated.

Please merge main

@tylerkaraszewski All yours 🙂

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


correct (same) assembly name for all aspnet (publishing) projects, up…

…date dockerfile

 (7) Maintain existing pipelines according to project changes

 (7) Maintain existing pipelines according to project changes


Typo in Results of Classic CV?

Looking at the results table for classic_cv, i noticed that for cifar10 there was a cifar10_4000 column.

But with regards to the explanations you gave in the README.md of Semi-supervised-learning/results/, it should be 4, 25 and 100 labels per class and therefore cifar10_40, cifar10_250 and cifar10_1000 or am i missing something?
Greetings,
Paul

The setting CIFAR-10 is slightly different from other settings. It is meant to have 4, 25, and 400 labels, while others have 4, 25, and 100 labels.

Alright, thanks for the quick answer! Than this should probably be changed

Fixed in 69a2afc8ecc9ec29cbf6afb123035d2be3443568


image: p_conv2d: Add function implementation

A rather naive implementation.
Written with the assumption of odd sized kernel.
Using p_sum, p_inv and p_dot from math module API.

Why the need for inv? Here is the implementation we had internally previously. Thought I pushed this into repo already, may have missed it??
void cvlib_conv2d(float * restrict A, int na, int ma, float * restrict M, int nm, int mm, float * restrict B)
{
int ia, ja, im, jm;
float S;
float *pa, *pb, *pm;
pa = A;
pb = B;

for (ia=1; ia<=(na-(nm-1)); ia++) // ia - row number
{
	for (ja=1; ja<=(ma-(mm-1)); ja++) // ja - col number
	{
		S = 0;
		pm = M;

		for (im=0; im<nm; im++)
		{
			for (jm=0; jm<(mm>>1); jm++)
			{
				S += (*pa++)*(*pm++);
				S += (*pa++)*(*pm++);
			}
			S += (*pa++)*(*pm++);
			pa += ma - mm;
		}

		*pb = S;

		pa += 1 - nm * ma; // advance mask matrix in one column.
		pb++;
	}

	pa = pa + (mm-1); // at the last column in a row, advance pointer to the beginning of next row.

//		pb = pb + (mm-1);
}
return;

}

inv is there for the sake of multiplication (normalization) of output pixel to maintain the relative magnitude of resulting image (compared to the input one) -- just in theory.
If there's already been a working code, then it should land in repo.

The was written and tested by yaniv (not me)...but it should work. No normalization inside function.


Update Tomahawk to 0.8.4

This updates Tomahawk to 0.8.4 and adds a commit for the missing 0.8.3 as well.

We don't need an interim commit for the missed version. In future please only add one commit that updates the cask straight to the latest version.


Add a Tile Preview

It would be nice if martin served a tile preview. Right now we are hosting a ngnix container along with martin which only serves the debug.html. If martin served this by default would be quite handy.

There has been a lot of interest in this - help is needed to push this forward:

https://github.com/maplibre/martin/issues/1120 (dup of this one, so closing)
https://github.com/maplibre/martin/pull/1142


Properly handle non-existent channels

Channels that don't exist or used to exist should prompt the normal "stream not found" error

Hmm, I can't reproduce this. With a fresh database, going to /destiny properly displays the 404 page.


Fake.js not working

Hi,
I am trying to use this project with the Fake.js setup with x2 Raspberry pi's; one with Homebridge (<IP_ADDRESS>) and the other pi running the fake.js (<IP_ADDRESS>), but am not getting any communication between the two.
Is this an issue with my setup somewhere or an issue with the code?
Homebridge is configured with the following and has a Thermostat appearing in Homekit
        "accessories": [{
                "accessory": "Thermostat",
                "name": "Thermostat",
                "apiroute": "http://<IP_ADDRESS>:12000"
        }]

The other pi has the fake.js running with the only change being the port number, as follows:
var server = app.listen(12000, function () {
  var host = server.address().address;
  var port = server.address().port;
  console.log('Global : app listening at', host, port);
});

The fake.js prints the following when executing: Global : app listening at :: 12000 - which doesn't seem to specify a host prior to the port, but not sure if this is normal.
I can't see any other configuration/setup I am missing, could this be a code issue?
Thanks
James

I just found an issue with the API line. I don't understand it, but when editing it again via ssh the cursor position seemed to be offset from the actual column that was edited. Deleting the entire line and rewriting it seemed to fix my issue.

Hello,
Quite a long time I haven’t work on this project ^^ It’s now a bit far in my head ^^ I feel it’s a port issue. What do you get when visiting http://<IP_ADDRESS>:12000 with your browser ?
If you have a result, set the port 80 and try
http://<IP_ADDRESS>
If again you have a result change the other rpi config.
If everything works, I guess the port parameters should be added in another method.
Pierre-Julien Cazaux,
Sent from my mobile device.

Le 22 juil. 2019 à 23:43, JamesKnevitt<EMAIL_ADDRESS>a écrit :
http://<IP_ADDRESS>:12000


rest-client depends on http-accept

Hello.
I'm the developer of http-accept and I'd like to open a dialogue regarding the project. I see it's currently in your latest rc.
I don't really have much to add, but it would be good to establish a point of contact for both projects.

Hello. Thanks for creating http-accept!
rest-client has barely been maintained for the past two years, but I'm planning to look for a couple of new maintainers in the near future.


🙉Monke Good

improve test names (shown below)
make pytest output be verbose by default
add ability to load runners by path
improved code loading

Maybe outside scope but should get the id in the name or folder somehow for spot testing single failures

What's with the deletion of the test?

Maybe outside scope but should get the id in the name or folder somehow for spot testing single failures

yes,

What's with the deletion of the test?

its a test in the wrong directory, the null agent test file is not needed anymore with the code analyzsis


Fix array index out of bounds

This array access might be out of bounds, as the index might be equal to the array length.

LGTM. Can we add a simple testcase to KerberosNameTest?


gpu: improve demo run instructions

Include the image building and pushing in the steps. Also notes about the need to modify the job yaml.
Signed-off-by: Tuomas Katila<EMAIL_ADDRESS>

This addresses #1173

/lgtm
(All my comments were resolved / can be marked as such.)

Should we edit/set:
Closes: #1173 in the initial comment?


List cmdlets

Added new cmdlets to set list properties, break role inheritance and set list permissions.
Updated some inner workings of group cmdlets.

Thanks Erwin


[Get /transactions/id]trusted delegate call is marked as untrusted

"trustedDelegateCallTarget": false, instead of the "trustedDelegateCallTarget": true,
Nest JS curl:
curl -X 'GET' \   'https://safe-client-nest.staging.5afe.dev/v1/chains/1/transactions/multisig_0xfF501B324DC6d78dC9F983f140B9211c3EdB4dc7_0xdc19004c346f7b2037e920294d3251dfe8c6b4ae92367255e9d5d69d349aa54b' \   -H 'accept: application/json'
Check the same request in the old CGW:
curl -X 'GET' \   'https://safe-client.staging.5afe.dev/v1/chains/1/transactions/multisig_0xfF501B324DC6d78dC9F983f140B9211c3EdB4dc7_0xdc19004c346f7b2037e920294d3251dfe8c6b4ae92367255e9d5d69d349aa54b' \   -H 'accept: application/json'

verified


power-flow-card-plus always in front

The power-flow-card-plus is not in the background. The circles are still visible.

I have 15 cards on this dashboard. The cards include power-flow-card-plus as number 8, Bubble-Cards as numbers 12, 13, and 14, and a Bubble-Pop-Up card as number 15.
Regarding the second issue: When I open one of the Bubble-Cards, I can see the bubbles from the Bubble-Pop-Up card on all cards except for the last one, number 14. Why is this happening?

I have 15 cards on this dashboard. The cards include power-flow-card-plus as number 8, Bubble-Cards as numbers 12, 13, and 14, and a Bubble-Pop-Up card as number 15.

In that case this issue is caused by power-flow-card-plus, you should open an issue on its GitHub page. Or change the z-index to 0 with card-mod on this card, that should fix it.

Regarding the second issue: When I open one of the Bubble-Cards, I can see the bubbles from the Bubble-Pop-Up card on all cards except for the last one, number 14. Why is this happening?

Check your configuration for this pop-up, also check that the entities are correct.

I added this, but it is still in front.
type: custom:mod-card
style: |
  :host {
    z-index: 0;
  }
card:
  type: custom:power-flow-card-plus

Try to add !important at the end of that line, like this z-index: 0 !important;

This works:
type: custom:mod-card
style: |
  ha-card {
    z-index: 0;
  }
card:
  type: custom:power-flow-card-plus

When the horizontal-bubble-stack is in its own column, then this column remains empty even after exiting the edit mode. In this case, the bubbles sometimes appear and sometimes do not at the bottom of the screen. If I change the view mode to sidebar, the bubbles at the bottom of the screen remain visible all the time. If I move a different card to position 14, filling the third column as well, it works correctly.

I would be happy to demonstrate it via Teams as well. I am readily available tomorrow.

It really depends on the position of the cards. I have now moved them to the first, second, and third positions and it works. However, in edit mode, a pop-up card is alone in a column. In the dashboard, it's hidden, but an empty column is displayed.


[incubator/cassandra] Remove duplicate name for servicemonitor

What this PR does / why we need it:
Removes duplicate name tag for ServiceMonitor Resource
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @maorfr


Commit to add our  own name page and fix Doctos to Doctors

Hello bro, let my code in, I fixed a typo

This commit is not going to get approved


accessibility

It would be useful to have a page with tips on accessibility and ways to improve code, images and documentation to make it easier and more accessible for people

closed with #34


Deploy blog as static web app on Azure

Description
Tried hosting blog articles on the Github wiki space included in our subscription, but it doesn't provide basic functionality such as ordering by blog post date or displaying posts in a navigation component.
Easiest option is to use a default blog theme for a static site generator such as Astro.
Additional Information
No response
Tasks
## Tasks
- [x] Install Azure Static Web Sites extension for VS Code
- [x] Login to Azure
- [x] Use wizard to deploy new static site, Github action added to repo automatically
- [x] Adjust nodejs engine version

Time spent:

transfer content: 15 minutes
generate article images using Dall-E 3: 5 minutes
create dedicated repository: 5 minutes
publish static site to Azure: 10 minutes

Temporary blog site address: https://mango-sand-0c39e9803.4.azurestaticapps.net/


Identify the node provider

Feature Request
In a CI environment with different type of agents, such as:

static workers
ephemeral workers.

And also different cloud providers, such as:

GCE
EC2
K8s

I'd like to identify the node spans with their provider therefore I can easily monitor the providers easily.
I don't know if the FlowNode can provide those details, but if it's possible, should the span have a new label like the ones specified in:

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/cloud.md
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/k8s.md

Done by the libraries
https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/gcp-resources
https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/aws-resources


[FLINK-18884][python] Add chaining strategy and slot sharing group in…

What is the purpose of the change
Add start_new_chain(), disable_chaining() and slot_sharing_group() interfaces for Python DataStream API.
Brief change log
Added the following interfaces for Python DataStream API:

start_new_chain()
disable_chaining()
slot_sharing_group()

Verifying this change
This change has test cases covered by test_chaining_strategy() and test_slot_sharing_group() in test_data_stream.py
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? ( not documented)

@hequn8128 Thank you for your comments, I have updated the PR according to your comments, please have a look at it.


Fixed a couple bitstream corruption issues from applying grain

Looks fine as far as I can tell. If you could fix lu-zero's suggestion, we can get this merged. Thanks!


have current_user return a NullObject

Has anyone thought about having the devise current_user method return a NullObject rather than nil?
I see a related SO post:
http://stackoverflow.com/questions/27169260/guest-user-for-devise-using-null-object-pattern
I was just seeing that a nil current_user is at the source of a lot of checks we are doing in our rails code, and I wonder if current_user might be made a little more confident a la:
http://stackoverflow.com/questions/16077115/rails-replacing-try-with-the-null-object-pattern

There are no plans for such although you can change it as you wish in your apps.

aha https://forum.upcase.com/t/null-object-pattern-with-devise/1684/6 looks good with:
  def current_user
    if devise_controller?
      @current_user = super
    else
      @current_user ||= super || AnonymousUser.new
    end
  end

would it make sense to build such a thing into devise?

ah posted across you - no plans - thanks @josevalim


Allow users to edit events

This PR allows users to edit events they've created. The doGet function checks if the event belongs to the user trying to access the link, and then populates the fields in the JSP form with the information on datastore. The doPost updates the information in datastore.
I added two functions for formatting to Utils.java because they are used in both the EventServlet and EditEventServlet. I also updated the tests for EventServlet and UserServlet. I plan on implementing the tests in the next PR.

Codecov Report

Merging #57 into master will decrease coverage by 16.01%.
The diff coverage is 42.67%.

@@              Coverage Diff              @@
##             master      #57       +/-   ##
=============================================
- Coverage     75.22%   59.21%   -16.02%
- Complexity       76       90       +14
=============================================
  Files             9       14        +5
  Lines           452      760      +308
  Branches         46       67       +21
=============================================
+ Hits            340      450      +110
- Misses          100      292      +192
- Partials         12       18        +6

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/com/google/sps/Firebase.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...java/com/google/sps/servlets/EditEventServlet.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...java/com/google/sps/servlets/LoadEventServlet.java
12.69% <0.00%> (-9.53%)
5.00 <0.00> (ø)

...main/java/com/google/sps/servlets/TaskHandler.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

src/main/java/com/google/sps/SecretHandler.java
20.68% <11.76%> (+20.68%)
2.00 <1.00> (+2.00)

src/main/java/com/google/sps/Recommend.java
54.54% <54.54%> (ø)
2.00 <2.00> (?)

src/main/java/com/google/sps/Utils.java
61.90% <72.41%> (ø)
10.00 <3.00> (?)

...in/java/com/google/sps/servlets/SearchServlet.java
92.47% <75.00%> (-2.16%)
18.00 <0.00> (ø)

...main/java/com/google/sps/servlets/UserServlet.java
82.57% <75.36%> (+0.57%)
20.00 <0.00> (ø)

src/main/java/com/google/sps/Interactions.java
80.00% <100.00%> (ø)
9.00 <0.00> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c5c09...a591c13. Read the comment docs.


HACS Install No Longer Works

Hi, great integration - I've been using it for a while.
However, HACS recently said a newer version was available, so I clicked to upgrade. What was weird was the version number had changed from something like V0.7 to V0.005. Anyways, it didnt work and in troubleshooting I uninstalled reolink and tried to reinstall it through the custom repositories per the instruction on this page. It doesn't work for me as the it says the repository file structure isn't valid. I tried the manual install, but the reolink_dev folder isn't part of the reolink-master.zip file.
Any ideas on what is going on here?

arch
x86_64

chassis
vm

dev
false

docker
true

docker_version
19.03.12

hassio
true

host_os
HassOS 4.16

installation_type
Home Assistant OS

os_name
Linux

os_version
5.4.75

python_version
3.8.6

supervisor
2020.11.0

timezone
America/Chicago

version
0.117.6

virtualenv
false

I know, I move the repository. Please see the other issues about this. You can uninstall-reinstall. This should work. I'm moving this to the HA repository, pull request is opened already. ;-)

Ok, that didnt work yesterday, but for some reason it works today. Back up and running!!


[SPARK-48336][PS][CONNECT] Implement ps.sql in Spark Connect

What changes were proposed in this pull request?
Implement ps.sql in Spark Connect
Why are the changes needed?
feature parity in Spark Connect
Does this PR introduce any user-facing change?
yes:
In [4]: spark
Out[4]: <pyspark.sql.connect.session.SparkSession at 0x105136390>

In [5]:     >>> ps.sql('''
   ...:     ...   SELECT m1.a, m2.b
   ...:     ...   FROM {table1} m1 INNER JOIN {table2} m2
   ...:     ...   ON m1.key = m2.key
   ...:     ...   ORDER BY m1.a, m2.b''',
   ...:     ...   table1=ps.DataFrame({"a": [1,2], "key": ["a", "b"]}),
   ...:     ...   table2=pd.DataFrame({"b": [3,4,5], "key": ["a", "b", "b"]}))
/Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/utils.py:1018: PandasAPIOnSparkAdviceWarning: The config 'spark.sql.ansi.enabled' is set to True. This can cause unexpected behavior from pandas API on Spark since pandas API on Spark follows the behavior of pandas, not SQL.
  warnings.warn(message, PandasAPIOnSparkAdviceWarning)
/Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/utils.py:1018: PandasAPIOnSparkAdviceWarning: The config 'spark.sql.ansi.enabled' is set to True. This can cause unexpected behavior from pandas API on Spark since pandas API on Spark follows the behavior of pandas, not SQL.
  warnings.warn(message, PandasAPIOnSparkAdviceWarning)

   a  b
0  1  3
1  2  4
2  2  5

How was this patch tested?

enabled UTs
also manually tested all the examples

Was this patch authored or co-authored using generative AI tooling?
No

cc @itholic and @HyukjinKwon

merged to master

Late LGTM. Thanks for addressing this!


[SMALLFIX] Minor code improvement for Client project

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4923/
Test PASSed.

+1 LGTM

@yupeng9 Could you resolve the merge conflicts please? Also for documenting variables, try to use /** description */ if possible. Looks good otherwise.

Thanks for reviewing. Addressed your comments.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4988/
Test FAILed.

Jenkins, test this please

LGTM +1

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4995/
Test PASSed.


Device crashs and restarts after installing and setting up CWA

Hi, an issue was reported in the Play Store with the following device:
Cat S41, Android 8
The user wrote:

After the installation and initial setup + activation of Bluetooth everything is ok. Then when working on the smartphone a sudden crash and the device restarts completely. The whole thing is repeated several times. I didn't see any connection with a specific app or function. There was no error message. After uninstalling the Corona app, the spook was over immediately.

This is the only reviewer with this device who reported a problem like this. Let me know if I should ask the user for more details.
Steps to reproduce:

Download CWA
Open the App
Finish the initial setup for the app
Close the CWA
Use your phone as usual

Expected Result
App works correct in the background and the device is working as usual.
Actual Result
Device crashs and restarts automatically.

Hey @ucmichan,
The Play Store and AppStore are also monitored by the Community Management Team, so mirroring the issues of other users to here is not necessary. You can still report it here if you experience the issue yourself, of course, but if that is not the case it's better to let the Store community managers handle this.
I'll close this issue for now. If you have any questions regarding this, you can still ask them here.
Regards,
CH

Corona-Warn-App Open Source Team


Examples object name change: DaisySeed seed -> DaisySeed hw

updated libDaisy with latest GPIO update and renamed all DSP seed objects for ambiguity conflict.

With the new update to GPIO we're trying to simplify syntax usage for the pinout, while avoiding breaking changes to existing code.
This sort of goes against that in that any project based on our examples that called the DaisySeed object seed has to be updated, but otherwise all GPIO code can stay the same. I'd probably consider that a breaking change, but it is a pretty minor one (esp. since there will only ever be one object called.
In any case, this updates all object names to be compliant with the new added namespace.

this also handles any updates to the new FatFSInterface


merge from template-arlac77-github

.github/workflows/ci.yml

chore(deps): add 20.8.0 remove 20.7.0 (jobs.test-node.strategy.matrix.node-version)

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.11.0
GitHub release

Your semantic-release bot :package::rocket:


Confliction of 10.2-KOR and 9.9-TWN

10.2-KOR results:
strHidUser: 00325091
refHidUser: 0030b784
hidObj: 0035fda0
{'gxFlushDCahce': '0x12ddc4', 'fsOpenFile': '0x163790', 'mountArchive': '0x12bf58', 'userFsTryOpen': '0x22b860', 'nnInitCardUpd': '0x118cc0', 'regArchive': '0x227e58', 'fsOpenArchive': '0x21e950', 'fsWriteFile': '0x16386c', 'mountRom': '0x10ed70', 'hidObj': '0x35fda0', 'fsReadFile': '0x12c090', 'getServiceHandle': '0x2354f4', 'aptStartApplet': '0x12e8fc', 'fsUserHandle': '0x32dfa4'}
if (t == 0xe12fff1e ) {
ntrConfig->HomeMenuVersion = SYSTEM_VERSION(INSERT_YOUR_VERSION_HERE);
ntrConfig->HomeMenuInjectAddr = 0x12ddc4;
ntrConfig->HomeFSReadAddr = 0x12c090;
ntrConfig->HomeCardUpdateInitAddr = 0x118cc0;
ntrConfig->HomeFSUHandleAddr = 0x32dfa4;
ntrConfig->HomeAptStartAppletAddr = 0x12e8fc;
}
0xe12fff1e is the same as 9.9-TWN, but has different offsets.

it finally happened... I will solve this issue in the future.

@44670 maybe you could simply use the region to identify this, its not to hard to get it.


After 1st discussion, the app looks hung up.

app version 3.1.2
After 1st disucussion, the state of among us capture was still DISCUSSION, discord voice states were unmuted and speaker unmuted in spite of the game state was not discussion.
The log of among us capture has these exceptions.
{
  "guildID": ****,
  "userID": ****,
  "parameters": {
    "deaf": true,
    "mute": true
  },
  "taskID": "****"
}Status: RanToCompletion, Exception: , Faulted: False

and
System.NullReferenceException: Arg_NullReferenceException
   at AmongUsCapture.GameMemReader.RunLoop()

This case was reproduced through every 4 games.

This should be fixed in capture version 3.1.3, please try upgrading to that version. This issue belongs in that repository anyways

This should be fixed in capture version 3.1.3, please try upgrading to that version. This issue belongs in that repository anyways

No troubles occured Until a few days ago.
I updated among us capture today (probabry from 6.10.1)
However, my windows environment may be changed yesterday. after installing other software, communicating between apps may have trouble like discord app cannot capture another app sound.

No troubles occured Until a few days ago.
I updated among us capture today (probabry from 6.10.1)
However, my windows environment may be changed yesterday. after installing other software, communicating between apps may have trouble like discord app cannot capture another app sound.

Thank you.

Thank you.

I mistook the repository.
I am sorry for opening issue about among us capture.

I mistook the repository.
I am sorry for opening issue about among us capture.

No problem! :)

No problem! :)


Support for Blue Iris

Hi
I am trying to make a rtsp connection from Blue Iris, but somehow Blue Iris is not able to read the stream. I guess it has something to do with the stream not being compatible....
Stream works fine in VLC...
Nice project by the way....

I've got the same issue, via the serial, i can read :
Created streamer width=800, height=600
Creating RTSP session
RTSP received DESCRIBE
RTSP received SETUP
RTSP received PLAY
The blue iris server oper the videoflow but display a black screen, no image ...
Any idea ?

Never get it work in 800 x 600, even in VLC. (Using AI_THINKER 2640 CAM)


Build Fail

I'm running on MacOs and the above error occurred

Does this happen with the release version as well?

Does this happen with the release version as well?

yes , it's the latest code base

Same here.

Add set(CMAKE_CXX_STANDARD 17) to solve this problem


RateLimit issue

Hi, I ve been using this library to get different informations from League of Legends API and when I do, I get:

RateLimitException: Rate limit exceeded

What is the proper way to handle the rate limit and get 100 % of it ?

The DefaultRateLimitHandler of this library only handles rate limits after it is too late. So basically if you already got a 429 response from the Riot Api, it will try to respect the Retry-After header for the given service, method or app.
There is also a BufferedRateLimitHandler in the current version of this library that, when configured properly, will try to prevent 429 responses by stopping to fire new requests early. Basically what it does is after a request it reads the rate limit headers from the Riot Api's response, and if the current usage is above X%, it will issue a manual X second cooldown on making requests to the given endpoint(s).
In a later version we also want to provide an AtomicRateLimitHandler (currently WIP) that tries to properly keep track of your rate limits by counting the requests you make and stopping a request when it would exceed the rate limit.
You can also write your own rate limiting logic by implementing the RateLimitHandler interface or extending the DefaultRateLimitHandler class. To use a non-default RateLimitHandler, use the #setRateLimitHandler() method of your ApiConfig.
In any case, regardless of if the Riot Api throws a 'real' RateLimitException or if the RateLimitHandler of your choice prevents making a call (in which case it will throw a RespectedRateLimitException, which inherits RateLimitException), your request will fail and you will not get a response from it. What you can do is catch RateLimitException when you do a request. On that RateLimitException object you can call #getRetryAfter() which will give you an integer that is the amount of seconds you need to wait before you can fire the request again.
It depends on the specific application if your best choice would be to sleep and retry the request, or drop it entirely.


[RHBXMSQE-418] - added testcases

please do not merge PR yet, I am adding more testcases

@manstis , please do you have any idea, why in this test [1], in presenter URIUtil.isValid("abc") returns true, but if I run web-app and I fill "abc" as Git URL, I obtain message about invalid url format.
[1]
https://github.com/jomarko/guvnor/blob/RHBXMSQE-418/guvnor-structure/guvnor-structure-client/src/test/java/org/guvnor/structure/client/editors/repository/clone/CloneRepositoryFormTest.java#L239

@jomarko It is probably because when compiled into the GWT application we substitute the URIUtil class with this one https://github.com/uberfire/uberfire/blob/master/uberfire-api/src/main/resources/org/uberfire/jre/org/uberfire/util/URIUtil.java which delegates to a JavaScript library; whereas when run as a test it's using https://github.com/uberfire/uberfire/blob/master/uberfire-api/src/main/java/org/uberfire/util/URIUtil.java.

Desired testcases completed.

I squashed the commits into one and merged.
http://github.com/droolsjbpm/guvnor/commit/a6355c362
When you next submit a PR (assuming you might look at the "Create Repository" form too; can you please be sure to sync your fork with origin/master? This PR contained changes that were different to what it at origin/master (when I fixed the CDI problem yesterday I made a few formatting changes - i.e. I used our default code-style formatting before committing).

Sorry that my inattention caused additional work for you. Thanks for merge. Sure I can do the same with "Create Repository Form".

@manstis - when it comes to the URIUtil class and the fact that it is different between tests and production... is this standard practice, something that we're recommending to do? (It concerns me - because this is something that forces us to continue using Selenium.)

@triceo It's not standard practice for sure.. URIUtil is the only case I know of.
Looking at the code it appears the class is made available to both client (browser) and server side; however the client side implementation is "overlayed" with an implementation that uses http://github.com/garycourt/uri-js instead of java.net.URLEncoder (that is not available client side).
@porcelli was the originator of this code.. if anything the issue is that there is a difference in behaviour of the two implementations.. which really should not be the case. The ideal solution is to obviously ensure both implementations are consistent.

@manstis, @triceo: there's an old issue with the URIUtil -- it was in a library that we stopped using, I think? We created our own local copy, I think?
That's probably part of the reason for the issue with URIUtil here.


Tests from previous commits on the PR should be canceled. I've sent you a PM with an example.


Swift version

Hi,
I've found this repository and it's really cool.
Have you any plan to convert this code to Swift ?
Thank you!

Hi, I think there is no need for converting the code to swift. You can use the control in swift projects, too. Either by using a bridging header or by using frameworks (for example with cocoapods).

I know it's possible using bridging header but I tend to avoid ObjectiveC in my project.


try_clone method for UI text and image bundles

Objective
ImageBundle, AtlasImageBundle and TextBundle don't implement Clone because ContentSize has a measure_func: Option<MeasureFunc> field which isn't cloneable.
But ContentSize should always be set to its default (where measure_func is None) with these bundles, anything else is a bug.
Solution
Manually implement Clone for each bundle and add an assertion that panics if a MeasureFunc is present.

Hopefully with Taffy 0.4, measure functions will be trait based. So it should be possible to make them properly Clone.

Hopefully with Taffy 0.4, measure functions will be trait based. So it should be possible to make them properly Clone.

I was thinking about this, and don't think it's worth it. Since the systems only query for changes in content, if you clone a node with a ContentSize the MeasureFunc will be overwritten anyway, making the cloning pointless.
Maybe cloning a ContentSize should just ignore the inner value, and always return ContentSize { measure_func: `None` }.

It would make sense to return Result<Self, Self>, where both the Ok and Err variant lack the MeasureFunc, but in the Ok case because the original had None already and the Err variant because that field was set to None. That way the method is more useful.


Update README.md

Description
Improvement.
This PR explicitly guide user to use action/checkout with clean: false option.
Background
Please correct me if my understand is wrong. DeNA/setup-job-workspace-action is to achieve Jenkins checkout strategy "keeps .git for each node & job" on GitHub Actions by "keep .git for each runner & workspace". Therefore actions/checkout still expected to be used with clean: false option to avoid git clean -ffdx.
Current README.md not indicate actions/checkout to use with clean: false, however it may reduce confusion to explicitly show example.
Related issue:
Contributor License Agreements

[x] By placing an "x" in the box, I hereby understand, accept and agree to be bound by the terms and conditions of the Contribution License Agreement.

@guitarrapc I agree with your diff.
However, I think that if you set clean: false, you will need to run git clean -ffd yourself. Without running git clean, files that generated by the previous run may affect the current run.
Therefore, we should also add run: git clean -ffd in example.
@srz-zumix @VeyronSakai What do you think? How do you do this in your actual Unity workflow?

@srz-zumix @VeyronSakai check-dist job blocked to merge. Since check-dist job will not trigger if the pull-request has only *.md diff, check-dist job should be removed from branch protection rules.

What do you think? How do you do this in your actual Unity workflow?

@srz-zumix @VeyronSakai  Since I don't use Unity anymore, can you guys tell me about your actual workflow?

We are using as a below
- name: Switch workspace
  uses: DeNA/setup-job-workspace-action@v2
  with:
    # Change path by build option
    suffix: "${{ (inputs.enable_XXX && '-XXX') || '' }}"
- uses: actions/checkout@v3
  with:
    # For clean everything
    clean: ${{ inputs.clean || false }}
- name: Git clean without Library
  run: git clean -xffd --exclude Library

I thought it would be fine without clean:false in Usage.
Because this is an input for the checkout action and not for the setup-job-workspace-action.
How about adding a section like Example and adding the above Unity example there?

@srz-zumix I've reverted usage, and added Example section as you mentioned. May I ask you review change?


Disable HTML escaping across all templates

Don't think we ever want HTML escaping, and having it on by default
causes problems whenever API names contain, e.g., a hyphen.

Current coverage is 88.56% (diff: 100%)

Merging #75 into master will not change coverage

@@             master        #75   diff @@
==========================================
  Files             3          3
  Lines           717        717
  Methods         150        150
  Messages          0          0
  Branches        106        106
==========================================
  Hits            635        635
  Misses           82         82
  Partials          0          0

Powered by Codecov. Last update ca3577a...4410ce1

LGTM


UTA transcript conversion needs to provide cds_start/cds_end for pyhgvs

If you don't provide cds_start/cds_end then it defaults to transcript start/end
We should patch cdot.pyhgvs.pyhgvs_transcript.AbstractPyHGVSTranscriptFactory.get_pyhgvs_data to generate the cds_start/cds_end off the start/stop - so existing data will get fixed
It's possible to get this, but you need to instantiate the transcript first, so will have to do it twice I guess
# Should detect whether we have start_codon but not cds_start - then if:

In [18]: start_codon = CDNACoord(coord=192)

In [19]: pt_37.cdna_to_genomic_coord(start_codon)
Out[19]: 5568963

In [20]: stop_codon = CDNACoord(coord=1320)

In [21]: pt_37.cdna_to_genomic_coord(stop_codon)
Out[21]: 5567187

Then also fix generation of data going forward

Working on branch uta_cds_start_end


Adds enable/disable functionality

Fixes #36. Env var ENABLE added to dev/prod configs already.

Wait a sec, there's a lot of things here that I didn't add. I'm going to try this again.


JDA-Data

For some reason, I decide to share the data I have collected. I wish this can help you and help me. If you want the data, you can send me an email and I will reply with the URL and Password to access these data.
If you have any question about the data, ask me in this issue or send me an email.

Can you share the data with me at<EMAIL_ADDRESS>

Can you share the data with me at<EMAIL_ADDRESS>

Hi @ardeal , I already sent an email to you. If you doesn't receive it, send an email to me<EMAIL_ADDRESS>

hi, @luoyetx , can u share me the dataset u have collected<EMAIL_ADDRESS>thanks a lot!

hi, Can you share the data with me at<EMAIL_ADDRESS>thanks very much!!!

hi, @luoyetx , can u share ur datasets with me? my e-mail address is<EMAIL_ADDRESS>thank you very much!

If you want the data, send an email to<EMAIL_ADDRESS>please don't paste your email in this issue.

Those who has trouble to extract the files, please try this software 好压. I used this software to compress the data and it should be ok. Sorry for the trouble :(

I need thanks<EMAIL_ADDRESS>

Can you share the data with me at<EMAIL_ADDRESS>thank you very much!

Hi, Can you share the data with me at<EMAIL_ADDRESS>

@JihanFan @hengliangzhu I have send the email to you :)

Hi, Can you share the data with me at<EMAIL_ADDRESS>

Hi, can you share dataset with me too<EMAIL_ADDRESS>

Hi, can you share dataset with me too<EMAIL_ADDRESS>thank you very much.

Hi, can you share the dataset with me too?
<EMAIL_ADDRESS>

Hello, could you please share the data ?
<EMAIL_ADDRESS>thanks in advance.

Hi, luoyetx ，could you share the dataset with me<EMAIL_ADDRESS>thank you very much.

Hi,luoyetx, could you please share the dataset with me? My e-mail is<EMAIL_ADDRESS>

Hi, could you please share the data with me? My e-mail is<EMAIL_ADDRESS>Thanks!

Hi Luoyetx, could you please share me the data? My e-mail is<EMAIL_ADDRESS>Many thanks in advance!

Hi, can you send me a copy, thx. my email is<EMAIL_ADDRESS>

Hi Luoyetx, could you please share me the data? My e-mail is<EMAIL_ADDRESS>

Hi, could you please share me the data? thx. My email is<EMAIL_ADDRESS>

Hi, Can you share the data with me at<EMAIL_ADDRESS>.
Thanks!

Hi, Can you share the data with me? my email is<EMAIL_ADDRESS>Thank you very much !

Thanks for sharing the data:my<EMAIL_ADDRESS>

Hi, Please share the data with me at<EMAIL_ADDRESS>

hi, Can you share the data with me at<EMAIL_ADDRESS>thank you.

Hello,could you share the data to me? Thank you very much!

hi, @luoyetx , can u share me the dataset u have collected<EMAIL_ADDRESS>thanks a lot!

Hi Luoyetx, could you please share the data with me<EMAIL_ADDRESS>thank you.

Hi Luoyetx, can u share me the data with me at<EMAIL_ADDRESS>Thanks a lot!

Could you please share the data you collected? My email is<EMAIL_ADDRESS>Thanks a lot!

NEED NEED , thank you<EMAIL_ADDRESS>

Hi @luoyetx, can you share the data with me at<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Much thanks!!

HI, @luoyetx,could you share the data to<EMAIL_ADDRESS>Thank you very much!

Hi Luoyetx, Please share me the data<EMAIL_ADDRESS>Thanks!

Hi Luoyetx, can you share the data to me<EMAIL_ADDRESS>Thank you very very much!
Thanks!

Please send an email to<EMAIL_ADDRESS>I will not reply to your email address in this issue.

Hi, could you please share me the data?  My email is<EMAIL_ADDRESS>Thank you very much.

Hey,
Can you please share with me the data, my mail<EMAIL_ADDRESS>Thanks

hi, @luoyetx , can u share ur datasets with me? at<EMAIL_ADDRESS>thank you very much!

Thank you ！@luoyetx.<PHONE_NUMBER>@qq.com.

Hi @luoyetx Can you share your data with me?
<EMAIL_ADDRESS>thanks!

Hello, Can you share for me? @luoyetx
<EMAIL_ADDRESS>Appreciate ！

Hi,could you share the data to me<EMAIL_ADDRESS>? Thank you very much!

Hello, Can you share for me<EMAIL_ADDRESS>very Appreciate ！

Hi, can you share your data with me<EMAIL_ADDRESS>thank you very much.

Hello!! Can you share data of yours for me? It would be very helpful!:D Thx
<EMAIL_ADDRESS>I appreciate!

您好，麻烦您把您收集的图片发给我一份好吗？非常感谢。
Hello，Can you share your pictures to me? I would appreciate it very much.
mail<EMAIL_ADDRESS>

Hi Luoyetx, can you share the data to me<EMAIL_ADDRESS>Thank you very very much!
Thanks!

Hello, Can you share for me? @luoyetx
<EMAIL_ADDRESS>Appreciate ！

Hello, Can you share for me? @luoyetx
<EMAIL_ADDRESS>Appreciate ！

hi, @luoyetx , can you share me the data you have collected ?
<EMAIL_ADDRESS>Thanks!

Hello ,@luoyetx,can you share the data with me<EMAIL_ADDRESS> Thank you very much

to @all, I now directly put the url below.
Hi,
I have uploaded the data to two websites Baidu Driver and MEGA Driver. The data is so big that I have zipped the file into several zip files, and you should download them all and can unzip the file. There's a brief introduction of the data in a text file.
If you are not in China, I recommend you to download the data from MEGA Driver.
Baidu Driver
url: http://pan.baidu.com/s/1eSsHYrK
password: 2st0
MEGA Driver, since the limitation of 50G space, I uploaded the data into two part.
url: https://mega.nz/#F!3ltAUbxZ
password: !OW_PK17ASUnJr2BjLrbtgw
url: https://mega.nz/#F!8kE00C5Z
password: !EAVOhv7T23-jISmdSGAM8A
If you have trouble to extract the files, please try this software 好压. I used this software to compress the data and it should be ok.
Best regards,
Zhang Jie

hi, @luoyetx , can you share me the data you have collected ?
<EMAIL_ADDRESS>Thanks.

Hi @luoyetx, can you share your data?
<EMAIL_ADDRESS>Thank you very much (for data and code :) )

Hi @luoyetx, can you share the data with me at<EMAIL_ADDRESS>

Hi @luoyetx, can you share the data with me<EMAIL_ADDRESS>thanks!

hi, @luoyetx , can u share ur datasets with me? my e-mail address is<EMAIL_ADDRESS>thank you very much!

I already put the url in this issue, please view this comment.
I'm locking this issue.


targetUpdatedProperties do not reflect old and new values

When updating a user profile such as the user's title, the targetUpdatedProperties does not reflect the attribute that was changed, the old value or the new value.  This is not the expected behavior.  Viewing the JSON through Event Hub, Activity Details in the portal, and the CSV output yield the same result.
"modifiedProperties": [
{
"displayName": "Included Updated Properties",
"oldValue": null,
"newValue": """"
},

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b651a95f-7c34-a979-f97e-e4feedb47487
Version Independent ID: ff679d7a-0bc5-692f-8ef8-72e24d402f23
Content: Interpret the Azure Active Directory audit log schema in Azure Monitor (preview)
Content Source: articles/active-directory/reports-monitoring/reference-azure-monitor-audit-log-schema.md
Service: active-directory
GitHub Login: @priyamohanram
Microsoft Alias: priyamo

@BrianJackson
Thanks for your feedback! We will investigate and update as appropriate.

@BrianJackson I am able to reproduce this issue at my end as well. I will work with the engineering team and will provide an update here.

@BrianJackson We will now proceed to close this thread. If you have further questions, please tag me in the comments and I will gladly continue the conversation.


WOQL 'get' should return literal wrapped elements.

Currently we are giving raw strings which is awkward and error prone. We don't want to be required to specify types when they are already strings or numbers, and we don't want to accidentally put random strings in to URI positions.

Fixed in dev and master


Improve accuracy of geof:distance() calculation over large distances

Hi,
Running the same GeoSPARQL query against GraphDB v.8.6.1 and RDF4J v.2.4.1 I get different results.
The repo can be empty. The query is:
PREFIX geof: <http://www.opengis.net/def/function/geosparql/>
SELECT  (geof:distance("POINT ( 45.0 77.90424715741715)"^^<http://www.opengis.net/ont/geosparql#wktLiteral>, "POINT(45 45)"^^<http://www.opengis.net/ont/geosparql#wktLiteral>, <http://www.opengis.net/def/uom/OGC/1.0/metre>) as ?dist)
 WHERE {
}

Th result in GraphDB is  "3666199.6343142693"^^xsd:double and in RDF4J Workbench is 3658790.3862683764
Regards

Hi Bart,
I was aware that GraphDB v8.6.1is based on RDF4J 2.3.2, but it does not use the RDF4J GeoSPARQL implementation. They are using (in a large part) the uSeekM library, which they also give credit to in the ${GraphDB_BaseDir}/doc/README_GeoSPARQL.txt file of their distribution.
Our team's tool, Strabon, uses PostGIS 2.0 to do most of its calculations, so it does agree with the GraphDB v8.6.1 result.
To be honest, I don't know which calculation is the most accurate one! I just run the same benchmark queries with various systems and since I got this difference I thought it would be nice to report it.
I shouldn't have rushed into a conclusion though.
I will report any new findings on the issue, if it will be of any help.
Regards

I'm not a GIS expert, but I guess in this specific example (moving towards the pole) the answer could actually be more closely to 3650600 (using a polar radius of 6356.75 km)...

Hi Theofilos,
I'm not a GIS export, but GraphDB and PostGIS are likely to be more accurate, since they probably take into account that Earth isn't a perfect sphere but an ellipsoid, so a difference of one degree latitude near the pole is slightly larger in meters than a one degree difference near the equator.
@jeenbroekstra probably knows more about this, but IIRC RDF4J uses Spatial4J and always uses the mean radius (i.e. assumes the Earth is a sphere), which is easier to calculate and arguably good enough for short distances, but less accurate.
Maybe the accuracy can be increased using Lucene's Geo3D  ?
Best regards

Bart is correct, Rdf4j relies on Spatial4j/JTS for the math, and this only has support for a mean radius/spherical earth assumption. Adding support for increased accuracy over long distances would involve another third party library (possibly Lucene, possibly something else) and is quite a bit of development work. I'm not currently available to address this, but if someone else wants to have a crack at it, I can certainly point them in the right direction, code-wise.

Related issue: #2936


Issue with metadata in cirrusCreationTime

Describe the bug
Adding metadata to cirrusCreationTime in Json file is throwing this error :
("(InvalidRequestContent) The request content was invalid and could not be deserialized: 'Could not find member 'metadata' on object of type 'DeploymentParameterDefinition'. Path 'properties.parameters.cirrusCreationTime.metadata', line 1, position 8724.'.\nCode: InvalidRequestContent\nMessage: The request content was invalid and could not be deserialized: 'Could not find member 'metadata' on object of type 'DeploymentParameterDefinition'. Path 'properties.parameters.cirrusCreationTime.metadata', line 1, position 8724.'.",)
Related command
azure powershell command to run a script
Errors
("(InvalidRequestContent) The request content was invalid and could not be deserialized: 'Could not find member 'metadata' on object of type 'DeploymentParameterDefinition'. Path 'properties.parameters.cirrusCreationTime.metadata', line 1, position 8724.'.\nCode: InvalidRequestContent\nMessage: The request content was invalid and could not be deserialized: 'Could not find member 'metadata' on object of type 'DeploymentParameterDefinition'. Path 'properties.parameters.cirrusCreationTime.metadata', line 1, position 8724.'.",)
Issue script & Debug output
NA
Expected behavior
Above error should not be thrown
Environment Summary
azure-cli                         2.46.0 *
core                              2.46.0 *
telemetry                          1.0.8
Dependencies:
msal                              1.20.0
azure-mgmt-resource             21.1.0b1
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\ksadhana.azure\cliextensions'
Python (Windows) 3.10.10 (tags/v3.10.10:aad5f6a, Feb  7 2023, 17:05:00) [MSC v.1929 32 bit (Intel)]
Legal docs and information: aka.ms/AzureCliLegal
Additional context
NA

Thank you for opening this issue, we will look into it.


[8.x] Adds soundex search to Mysql

This PR is the same as #40211, since it doesn't contain breaking changes.

This PR adds  implements soundex search for mysql, adding whereSoundex and orWhereSoundex methods to the Illuminate\Database\Query\Builder class.
In mysql, the SOUNDEX() function in MySQL is used to return a phonetic representation of a string, which represents the way the string will sound.
Schema::create('users', function (Blueprint $table) {
    $table->id();
    $table->string('email', 200);
    $table->string('first_name');
    $table->string('last_name');
});

// Search users where their first name sounds like 'tailor'
$users = DB::table('users')->whereSoundex('first_name', 'tailor')->get();

// Search users where their last name sounds like 'otuel':
$users = DB::table('users')->whereSoundex('last_name', 'Otuel')->get();

If this PR gets merged, we can also add soundex support for other database engines:

https://docs.microsoft.com/pt-br/sql/t-sql/functions/soundex-transact-sql?view=sql-server-ver15
https://wiki.postgresql.org/wiki/Soundex

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Default reduction always applied by Metric, even when requesting 'none' reduction

🐛 Bug

Metric reduction doesn't behave the same between the functional and class API when using reduction='none'. The functional API applies no reduction as expected, but the class API seems to apply the default reduction regardless.
I haven't investigated the code yet to find the specific cause of the bug, so I'm not sure how widespread this bug is, but I've encountered it using both the DiceCoefficient and my own implementation of the differentiable dice, inheriting from TensorMetric.
To Reproduce
Given a pair of pred and target, I get the following behavior with 3 class + background segmentation data:
>>> from pytorch_lightning.metrics import DiceCoefficient
>>> from pytorch_lightning.metrics.functional import dice_score
>>> DiceCoefficient(reduction="none")(pred, target)
tensor(0.0800)
>>> dice_score(pred, target, reduction="none")
tensor([0.0876, 0.0937, 0.0586], device='cuda:0')

where I would have expected both version to give the same result.
The class API seems to apply the default reduction of 'elementwise_mean' even though I requested 'none', since:
>>> dice_score(x_hat, x, reduction="none").mean()
tensor(0.0800, device='cuda:0')

Expected behavior
Reduction behavior should be consistent between class and functional API, and to behave like the current functional API.
Environment
I just now installed Lightning from Git to ensure that it's not a bug that's already been solved since the last release.

CUDA:
- GPU: TITAN Xp
- available:         True
- version:           10.2
Packages:
- numpy:             1.19.2
- pyTorch_debug:     False
- pyTorch_version:   1.6.0
- pytorch-lightning: 0.9.1rc4
- tqdm:              4.49.0
System:
- OS:                Linux
- architecture: 64bit, ELF
- processor:         x86_64
- python:            3.8.5
- version:           #51~18.04.1-Ubuntu SMP Sat Sep 5 14:35:50 UTC 2020

Hi @nathanpainchaud, running your code example on master produces the correct result (your issue was probably solved by PR #3517). Could you please try upgrading?

Hi @SkafteNicki. I can confirm that master now runs fine on my end as well. Thanks for the follow up!


Explicitly namespace OS-specific definitions

There are reexports at the top level that are only available in Unix or Windows:
#[cfg(unix)] pub use consts::os::sysconf::*;

#[cfg(unix)] pub use funcs::posix88::mman::*;
#[cfg(unix)] pub use funcs::posix88::dirent::*;
#[cfg(unix)] pub use funcs::posix88::net::*;
#[cfg(unix)] pub use funcs::posix01::stat_::*;
#[cfg(unix)] pub use funcs::posix01::unistd::*;
#[cfg(unix)] pub use funcs::posix01::resource::*;

#[cfg(windows)] pub use funcs::extra::kernel32::*;
#[cfg(windows)] pub use funcs::extra::winsock::*;
#[cfg(windows)] pub use funcs::extra::msvcrt::*;

For clarity, and following the convention in std, these are better exported for public use in explicitly OS-specific modules os::unix and os::windows, and the top-level reexports deprecated.

Thanks for the report! This repo is actually currently slated for a revamp, as detailed in an RFC: https://github.com/rust-lang/rfcs/pull/1291. The intention is to slate this library as platform-specific by default rather than platform-agnostic by default, but comments on the RFC are always welcome!


Missing sample for using Azure as a DRM server only

The "Scenarios and samples" section has 5 scenarios, but only 4 of them have samples.  Please can you add a sample for the 5th scenario?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9748e5ed-18e3-b840-3e4b-1c0f821b6511
Version Independent ID: 03afa3ed-d47b-bd41-6b85-d5f24462a11d
Content: Hybrid design of DRM subsystem(s) using Azure Media Services
Content Source: articles/media-services/previous/hybrid-design-drm-sybsystem.md
Service: media-services
GitHub Login: @willzhan
Microsoft Alias: willzhan;juliako

Hi @Jon-Work , thanks for bringing this to our attention. I have assigned the issue to the content author to evaluate and update as appropriate

We are no longer recommending using Azure for just DRM license delivery only.  That capability was removed in the v3 API.
#please-close

@johndeu In that case, please can you fix the documentation to make it clear that's no longer supported?  This document has 2 tables that list that option, please can you remove (or mark as "No longer supported") the relevant row in each table?

@Juliako  - can you make the adjustments to the tables noted above. Looks like folks are still looking and finding the older legacy API docs for DRM where this is recommended.  Mark it as no longer supported in V3 API


Add postgresql recipe

This allows rsyslog to be run with a PostgreSQL backend. It currently assumes that rsyslog will run on the same instance as PostgreSQL. Changing this will probably require the recipe to be split in two.
I would have liked to have used peer authentication, negating the need for the database user to have a random password assigned but the database cookbook currently prevents this. This is being discussed.
Common server configuration (currently just RELP) has been moved into 34-server.conf with 35-postgresql.conf holding the PostgreSQL-specific parts. Given that 35-server-per-host.conf should not exist at the same time, I considered having these share the same name but I didn't want to break existing installs.
Bats tests have been added and these pass on CentOS 5.10 and 6.5. The Chef run fails on Fedora but this is to be due to problems with the postgresql cookbook.
I bolstered the Bats tests by sharing some of the tests between suites. I would have used "load" but Busser only copies the specific suite to the instance so symlinks seemed like the best solution, short of simply duplicating the tests. This cookbook is not relevant to Windows so hopefully this is not a problem.
NOTE: This needs #38, #50, and #53 to be merged first. These are all simple fixes.

This change is really out of the scope of the 99.9% use for this cookbook and adds to the complexity of the overall cookbook.  It's a useful scenario, but it should probably be part of it's own cookbook.


Chart 0.3.0: istio sidecar, new team label, updated hookConfigJob

Mainly the istio-sidecar for egress-filtering (DBRE-3882), and also a few minor optimizations #boyscout-mode

And I tagged it manually:
$ git tag redash-bbcfork-v0.3.0
$ git push origin redash-bbcfork-v0.3.0


WIP Create wiki.yml

Allow the creation of wiki files automatically for documentation purposes

:white_check_mark: Build carball 0.6.41-wofdvtnx completed (commit https://github.com/SaltieRL/carball/commit/fb8cecebbb by @dtracers)

:white_check_mark: Build carball 0.6.41-wofdvtnx completed (commit https://github.com/SaltieRL/carball/commit/fb8cecebbb by @dtracers)

:white_check_mark: Build carball 0.6.42-ltddqwas completed (commit https://github.com/SaltieRL/carball/commit/db84445af2 by @dtracers)

:white_check_mark: Build carball 0.6.42-ltddqwas completed (commit https://github.com/SaltieRL/carball/commit/db84445af2 by @dtracers)

:white_check_mark: Build carball 0.6.50-kwjogfjg completed (commit https://github.com/SaltieRL/carball/commit/ca6a954eb7 by @Sciguymjm)

:white_check_mark: Build carball 0.6.50-kwjogfjg completed (commit https://github.com/SaltieRL/carball/commit/ca6a954eb7 by @Sciguymjm)

:white_check_mark: Build carball 0.6.50-dpktlwol completed (commit https://github.com/SaltieRL/carball/commit/385e40eec7 by @dtracers)

:white_check_mark: Build carball 0.6.50-dpktlwol completed (commit https://github.com/SaltieRL/carball/commit/385e40eec7 by @dtracers)

:white_check_mark: Build carball 0.6.50-enajsggu completed (commit https://github.com/SaltieRL/carball/commit/26503cd84c by @dtracers)

:white_check_mark: Build carball 0.6.50-enajsggu completed (commit https://github.com/SaltieRL/carball/commit/26503cd84c by @dtracers)

:white_check_mark: Build carball 0.6.50-qwbsbewx completed (commit https://github.com/SaltieRL/carball/commit/09fde398c6 by @dtracers)

:white_check_mark: Build carball 0.6.50-qwbsbewx completed (commit https://github.com/SaltieRL/carball/commit/09fde398c6 by @dtracers)

:white_check_mark: Build carball 0.6.50-muysosqr completed (commit https://github.com/SaltieRL/carball/commit/1284f69b8c by @dtracers)

:white_check_mark: Build carball 0.6.50-muysosqr completed (commit https://github.com/SaltieRL/carball/commit/1284f69b8c by @dtracers)

:white_check_mark: Build carball 0.6.50-uxctfyas completed (commit https://github.com/SaltieRL/carball/commit/13559bab42 by @dtracers)

:white_check_mark: Build carball 0.6.50-uxctfyas completed (commit https://github.com/SaltieRL/carball/commit/13559bab42 by @dtracers)

:white_check_mark: Build carball 0.6.50-aixusogb completed (commit https://github.com/SaltieRL/carball/commit/aeaa02afe3 by @dtracers)

:white_check_mark: Build carball 0.6.50-aixusogb completed (commit https://github.com/SaltieRL/carball/commit/aeaa02afe3 by @dtracers)

:white_check_mark: Build carball 0.6.50-lulwmrir completed (commit https://github.com/SaltieRL/carball/commit/8ca4495cb3 by @dtracers)

:white_check_mark: Build carball 0.6.50-lulwmrir completed (commit https://github.com/SaltieRL/carball/commit/8ca4495cb3 by @dtracers)

:white_check_mark: Build carball 0.6.50-uefciadw completed (commit https://github.com/SaltieRL/carball/commit/65c0c5cc8c by @dtracers)

:white_check_mark: Build carball 0.6.50-uefciadw completed (commit https://github.com/SaltieRL/carball/commit/65c0c5cc8c by @dtracers)

:white_check_mark: Build carball 0.6.50-ngwuruhh completed (commit https://github.com/SaltieRL/carball/commit/187f87b559 by @dtracers)

:white_check_mark: Build carball 0.6.50-ngwuruhh completed (commit https://github.com/SaltieRL/carball/commit/187f87b559 by @dtracers)

:white_check_mark: Build carball 0.6.50-tgaxflxl completed (commit https://github.com/SaltieRL/carball/commit/3addce9b7d by @dtracers)

:white_check_mark: Build carball 0.6.50-tgaxflxl completed (commit https://github.com/SaltieRL/carball/commit/3addce9b7d by @dtracers)

:white_check_mark: Build carball 0.6.50-niyviohw completed (commit https://github.com/SaltieRL/carball/commit/9a36757803 by @dtracers)

:white_check_mark: Build carball 0.6.50-niyviohw completed (commit https://github.com/SaltieRL/carball/commit/9a36757803 by @dtracers)

:white_check_mark: Build carball 0.6.50-ovhbgbny completed (commit https://github.com/SaltieRL/carball/commit/82414fc47a by @dtracers)

:white_check_mark: Build carball 0.6.50-ovhbgbny completed (commit https://github.com/SaltieRL/carball/commit/82414fc47a by @dtracers)

:white_check_mark: Build carball 0.6.50-bmguqqlk completed (commit https://github.com/SaltieRL/carball/commit/143e018113 by @dtracers)

:white_check_mark: Build carball 0.6.50-bmguqqlk completed (commit https://github.com/SaltieRL/carball/commit/143e018113 by @dtracers)

:white_check_mark: Build carball 0.6.50-dyntemma completed (commit https://github.com/SaltieRL/carball/commit/bb274f76c8 by @dtracers)

:white_check_mark: Build carball 0.6.50-dyntemma completed (commit https://github.com/SaltieRL/carball/commit/bb274f76c8 by @dtracers)

:white_check_mark: Build carball 0.6.51-eotsjljt completed (commit https://github.com/SaltieRL/carball/commit/8846c12438 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-eotsjljt completed (commit https://github.com/SaltieRL/carball/commit/8846c12438 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-ydjulapw completed (commit https://github.com/SaltieRL/carball/commit/dcda7008b1 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-ydjulapw completed (commit https://github.com/SaltieRL/carball/commit/dcda7008b1 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-uguxwoeb completed (commit https://github.com/SaltieRL/carball/commit/522179d0c6 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-uguxwoeb completed (commit https://github.com/SaltieRL/carball/commit/522179d0c6 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-wdxpbybr completed (commit https://github.com/SaltieRL/carball/commit/6e1776a7cf by @DivvyCr)

:white_check_mark: Build carball 0.6.51-wdxpbybr completed (commit https://github.com/SaltieRL/carball/commit/6e1776a7cf by @DivvyCr)

:white_check_mark: Build carball 0.6.51-parusyhu completed (commit https://github.com/SaltieRL/carball/commit/99281ed0bb by @DivvyCr)

:white_check_mark: Build carball 0.6.51-parusyhu completed (commit https://github.com/SaltieRL/carball/commit/99281ed0bb by @DivvyCr)

:white_check_mark: Build carball 0.6.51-lhmboree completed (commit https://github.com/SaltieRL/carball/commit/904e784801 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-lhmboree completed (commit https://github.com/SaltieRL/carball/commit/904e784801 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-yhwartbc completed (commit https://github.com/SaltieRL/carball/commit/6446eb41c1 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-yhwartbc completed (commit https://github.com/SaltieRL/carball/commit/6446eb41c1 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-uxytictm completed (commit https://github.com/SaltieRL/carball/commit/2ecbb226ea by @DivvyCr)

:white_check_mark: Build carball 0.6.51-uxytictm completed (commit https://github.com/SaltieRL/carball/commit/2ecbb226ea by @DivvyCr)

:white_check_mark: Build carball 0.6.51-wiboxmpo completed (commit https://github.com/SaltieRL/carball/commit/853fcbddd5 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-wiboxmpo completed (commit https://github.com/SaltieRL/carball/commit/853fcbddd5 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-ywaocxld completed (commit https://github.com/SaltieRL/carball/commit/2d589c067c by @DivvyCr)

:white_check_mark: Build carball 0.6.51-ywaocxld completed (commit https://github.com/SaltieRL/carball/commit/2d589c067c by @DivvyCr)

:white_check_mark: Build carball 0.6.51-swnjdfft completed (commit https://github.com/SaltieRL/carball/commit/fe1d03a45c by @DivvyCr)

:white_check_mark: Build carball 0.6.51-swnjdfft completed (commit https://github.com/SaltieRL/carball/commit/fe1d03a45c by @DivvyCr)

:white_check_mark: Build carball 0.6.51-uyxaloxx completed (commit https://github.com/SaltieRL/carball/commit/1d3d41fe6b by @DivvyCr)

:white_check_mark: Build carball 0.6.51-uyxaloxx completed (commit https://github.com/SaltieRL/carball/commit/1d3d41fe6b by @DivvyCr)

:white_check_mark: Build carball 0.6.51-vcytnkok completed (commit https://github.com/SaltieRL/carball/commit/affd050bc9 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-vcytnkok completed (commit https://github.com/SaltieRL/carball/commit/affd050bc9 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-dafrmdij completed (commit https://github.com/SaltieRL/carball/commit/a18faa28d7 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-dafrmdij completed (commit https://github.com/SaltieRL/carball/commit/a18faa28d7 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-lkoobfwh completed (commit https://github.com/SaltieRL/carball/commit/c3dee37806 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-lkoobfwh completed (commit https://github.com/SaltieRL/carball/commit/c3dee37806 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-tsgfnogc completed (commit https://github.com/SaltieRL/carball/commit/24aa55e982 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-tsgfnogc completed (commit https://github.com/SaltieRL/carball/commit/24aa55e982 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-tmxujgua completed (commit https://github.com/SaltieRL/carball/commit/24aa55e982 by @DivvyCr)

:white_check_mark: Build carball 0.6.51-tmxujgua completed (commit https://github.com/SaltieRL/carball/commit/24aa55e982 by @DivvyCr)

Woop Woop FeelsGoodMan

:white_check_mark: Build carball 0.6.51-imjcdkuf completed (commit https://github.com/SaltieRL/carball/commit/f5329dd84c by @DivvyCr)

:white_check_mark: Build carball 0.6.51-imjcdkuf completed (commit https://github.com/SaltieRL/carball/commit/f5329dd84c by @DivvyCr)

:white_check_mark: Build carball 0.6.51-mobtmqrg completed (commit https://github.com/SaltieRL/carball/commit/1bee3624ff by @DivvyCr)

:white_check_mark: Build carball 0.6.51-mobtmqrg completed (commit https://github.com/SaltieRL/carball/commit/1bee3624ff by @DivvyCr)


Searching a Hashtag fails with a 404

The following will result in a 404 - Page not found error message, with the "Alice in wonderland maze" image.
https://stacker.news/search?q=#bitcoin
I would think words for that string without the "#" hashtag prefix would be included in the search results, but probably exact matches including that "#" prefix should get ranked higher in the search results.
There are some instances, such as Episode #123, where the matches without the "#" prefix are probably nearly as close (e.g., "Episode 123".  There are probably other quirks with hashtags, I can imagine.

I see there was discussion about using hashtags to identify a sub as well, so wanted to share that here as well;
https://stacker.news/items/7767

One possible solution: when a user searches using a hashtag, for example "#Bitcoin", we can convert to URL encoded parameters and send "%23Bitcoin" to the browser instead. This would at least squash the bug. I'm thumbing through the code now to see where one could enter this functionality - perhaps in search.js

@nickkrauts that's what I did and it was in fact in components/search.js
Fixed locally.


[Fix] Focus search input only for real characters

Description
Change the test to determine which key typed anywhere on the website can trigger the focus on the main search input.
Instead of excluding some (not enough) special keys, test that the key corresponds to a real printable character, and ignore all other keys.
The test for a real printable character can be made using the key property of a KeyboardEvent, which is a string with these values:

the Unicode printed representation of the key pressed, if it exists (so its length should equal 1. There may be special cases where it's not true, like if you imagine a Keyboard able to enter Emojis, but I think we can safely ignore them)
a standardized multi-char string otherwise: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values

So we trigger the focus only when the key length is 1.
Why
The current test isn't restrictive enough, so many commonly used special keys set the focus on the field:

Esc
AltGr
Cmd (MacOS)
Windows key (Windows)
'F*' Function keys
PageDown/Up,
etc.

Related to ticket QMAPS-1677 (can you please use the ticket number in your branch names / commit messages?)

However, I noticed that when the field already has something inside, and is unfocused, typing a letter empties the content of the field, instead of appending the letter.
Is this the desired behavior? Maybe something to discuss with the team :)

I think this is for now matching the specs. But it's an interesting point, could be asked separately to the design team.


Command history and incsearch

Hi,
here is an issue that I spotted.
In my command history I have an Ex command that operates on a visual range ('<'>). I open a new file to edit. Visual range was never set on this file. I use : to access previously used commands, and when '<'> command comes in command line, it triggers E20. It could be related to incsearch option that is set by defaults.vim

Vim version is 8.1.784

FWIW, I handle the issue with this autocmd:
augroup fix_E20
    au!
    au CmdlineEnter : if ! line("'<")
        \ |     call setpos("'<", [0,line('.'),col('.'),0])
        \ |     call setpos("'>", [0,line('.'),col('.'),0])
        \ | endif
augroup END

Whenever the command-line is entered, it checks whether the visual marks are set; if they are not, it sets them on the current cursor position.
However, it doesn't fix the issue entirely.
The latter can be triggered by other marks, and sometimes be raised multiple times for the same command (every time you edit a command-line with an unset mark):
$ vim -Nu NONE -i NONE +'set is'
:'ss/p
:'ss/pa
:'ss/pat
...

Here, E20 is raised when you insert p, then a, then t, ...
One way to fix the issue entirely would be to set all possible marks when the command-line is entered:
augroup fix_E20
    au!
    au CmdlineEnter : call s:fix_e20()
augroup END
fu s:fix_e20() abort
    let marks = range(48, 57) + range(65, 90) + range(97, 122)
    let marks = map(marks, {_,v -> nr2char(v)})
    let marks += ['<', '>', '[', ']', '^', '.']
    let [lnum, col] = getpos('.')[1:2]
    let l:Set_marks = {_,v -> getpos("'"..v) == [0,0,0,0] && setpos("'"..v, [0,lnum,col,0])}
    call map(marks, l:Set_marks)
endfu

But that seems too much; so instead, I'm experimenting with this:
augroup fix_E20
    au!
    au CmdlineEnter : if ! line("'<")
        \ |     call setpos("'<", [0,line('.'),col('.'),0])
        \ |     call setpos("'>", [0,line('.'),col('.'),0])
        \ | endif
    au CmdlineChanged,CmdlineLeave : call s:fix_e20()
augroup END
fu s:fix_e20() abort
    if v:errmsg is# 'E20: Mark not set' && !exists('s:incsearch_save')
        let v:errmsg = ''
        let s:incsearch_save = &incsearch
        set nois
        au CmdlineLeave : ++once let &is = s:incsearch_save
        \ | unlet! s:incsearch_save
        \ | call histdel(':', histget(getcmdline()))
    endif
endfu

It still fixes E20 for the visual marks, but not for the other ones.
However, it prevents E20 from being raised again and again for the same command.
Using the same example as before:
$ vim -Nu <(cat <<'EOF'
augroup fix_E20
    au!
    au CmdlineEnter : if ! line("'<")
        \ |     call setpos("'<", [0,line('.'),col('.'),0])
        \ |     call setpos("'>", [0,line('.'),col('.'),0])
        \ | endif
    au CmdlineChanged,CmdlineLeave : call s:fix_e20()
augroup END
fu s:fix_e20() abort
    if v:errmsg is# 'E20: Mark not set' && !exists('s:incsearch_save')
        let v:errmsg = ''
        let s:incsearch_save = &incsearch
        set nois
        au CmdlineLeave : ++once let &is = s:incsearch_save
        \ | unlet! s:incsearch_save
        \ | call histdel(':', histget(getcmdline()))
    endif
endfu
EOF
) -i NONE +'set is'
:'ss/p
:'ss/pa
:'ss/pat
...

E20 is only raised when p is inserted; not afterward. So you can insert a, t, ... without being interrupted on each keystroke; and later you can press C-b to move to the start of the command-line, and fix the line specifier.
Besides, the code prevents the command from being saved in the history. Otherwise, when you would quit the command-line (no matter how: Escape, C-c, Enter) while the latter contains a command with an unset mark, it would be saved in the history. Then, when you would press Up to retrieve another old command, you might get back to the buggy command and E20 could be raised again.


SMB mount dailed

What version of Music Assistant has the issue?
2.3.0b15
What version of the Home Assistant Integration have you got installed?
2024.8.1
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
After upgrading to 2.3.0b15, my "Filesystem (remote share)" music provider fails to start with the error:
2024-08-30 15:19:25.372 WARNING (MainThread) [music_assistant] Error loading provider(instance) Filesystem (remote share): Connection failed for the given details: SMB mount failed with error: mount: mounting //titan.lexam.internal/Media/Music-tagged on /tmp/filesystem_smb--cLdtRifQ failed: Permission denied
(will be retried later)
If I downgrade to 2.3.0b8, it works fine.
How to reproduce
Just upgrade to 2.3.0b15 (it also happened in 2.3.0b12 and 13 IIRC)
Music Providers
Filesystem (remote share)
Player Providers
N/A
Full log output
music-assistant.log
Additional information
No response
What version of Home Assistant Core are your running
2024.8.3
What type of installation are you running?
Home Assistant Container
On what type of hardware are you running?
Linux

This is working fine here on beta 15. There have been library changes so settings may need to be adjusted. Check the server settings under advanced for the local provider. Recheck your login credentials

It's fixed in 2.3.0b16. Closing, thanks!


Missing config.h file for building drv_htc_vive directory?

Hi,
I have added options to cmake to build drv_htc_vive directory because I would like to read rotational data from the Vive.
I am on the htc-vive branch and getting the error below. I cannot locate the "config.h" file in the project.  Is this file and any others missing from the branch?
Thanks in advance for your help.
Shaun
Changes to CMakeLists.txt
if(OPENHMD_DRIVER_VIVE)
set(openhmd_source_files ${openhmd_source_files}
${CMAKE_CURRENT_LIST_DIR}/src/drv_htc_vive/vive.c
${CMAKE_CURRENT_LIST_DIR}/src/drv_htc_vive/packet.c
)
add_definitions(-DDRIVER_VIVE)
find_package(HIDAPI REQUIRED)
include_directories(${HIDAPI_INCLUDE_DIRS})
set(LIBS ${LIBS} ${HIDAPI_LIBRARIES})

endif(OPENHMD_DRIVER_VIVE)
Error:
C:\workplace\OpenHMD>make
Scanning dependencies of target openhmd
[  8%] Building C object CMakeFiles/openhmd.dir/src/drv_htc_vive/packet.c.obj
C:\workplace\OpenHMD\src\drv_htc_vive\packet.c:2:20: fatal error: config.h: No such file or directory
#include "config.h"
^
compilation terminated.
make[2]: *** [CMakeFiles\openhmd.dir\build.make:238: CMakeFiles/openhmd.dir/src/drv_htc_vive/packet.c.obj] Error 1
make[1]: *** [CMakeFiles\Makefile2:67: CMakeFiles/openhmd.dir/all] Error 2
make: *** [Makefile:83: all] Error 2

I think @TheOnlyJoey has forgotten to add the files to the repo.

Thanks @noname22 .
@TheOnlyJoey could you please add source files and a few instructions on compiling the htc-vive driver or using "simple" example for reading IMU data from Vive.
Cheers

Should be fixed, forgot to add the file, updated the CMake as well.
Both autotools and CMake both build the simple example by default, info is in the readme.


when batch ID not specified should be an alert

when you do this, you'll be read only on the mounted pod, and only can retrieve broken files, their names appear btw

Specifying fairos gateways will also not require batchID... What should be the expected behaviour? @crtahlin @tfius @darkobas2

Right now you can determine bee or gateway-proxy  by querying /health

i dont see a problem with mounting fuse read only without a batch

I think in the original description there are a couple of issues described (you should split these into independent issues as a rule, to avoid confusion @tamas6 ).

what the app should do when no BatchID is specified
some kind of corrupt files in the pod (there would need to be more info about this to have a reproducible scenario that a developer can tackle).

Unless further information is given (in a separate issue, @tamas6 ? ), we can only tackle number 1 here.
I am inclined not to change the logic for the release we have now, but only have a warning somewhere "Without providing stampID(batchID?) you will not be able to write to Fairdrive."
In the longer run, what @darkobas2 has suggested, with the added note
"if user doesnt enter a batch OR checkbox that stamp is provided by gateway is TRUE, you should fuse mount read only"

made a separate issue #100

i would suggest a checkbox like.. stamp provided by gateway and then disable batch field.

this looks like a good solution

I am inclined not to change the logic for the release we have now, but only have a warning somewhere "Without providing stampID(batchID?) you will not be able to write to Fairdrive."

we shall add this for now

If the user does not specify "batchID", we mount as ReadOnly.


Update xlc compiler version for jdk11 builds on AIX

Due to some recent changes related to the Harfbuzz library version used to build jdk11, building jdk11 will now require xlc version 16.1. This change is expected to remedy the build break first observed here.
Further discussion on this issue and the changes required can be found at the links below:

https://bugs.openjdk.java.net/browse/JDK-8282588
https://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2022-March/004145.html

I've managed to get this to build outside the build process but I had to adjust the memory limit below 7000 in aix.sh in order for it to build on the "adopt06" machine with XLC16 FP 11. We will now look at deploying that on the main temurin build machines in order to recover the builds.

Good news. Thanks for your work on this @sxa!

JDK11 is now building with XLC16. Closing.


L&D Integration

# This PR will not be merged in to this repo. Submitted for the purpose of feedback
What does this PR do? Please provide some context
1) GET access token from Azure tenant using MSI
2) GET secrets from Azure keyvault using the access token
3) GET the Course catalog data from OpenEdx using the secrets obtained from Azure key vault
4) Map and process the OpenEdx course catalog data with L&D Catalog_UpdateMultipleCatalogAsync API request body
5) POST the mapped data to L&D Catalog_UpdateMultipleCatalogAsync API

Where should the reviewer start?
deploy MSI enabled linux machine and run the script sync_course_catalog.py in python3 environment
How can this be manually tested? (brief repro steps)
create a course in the edx platform and running the script will make the course catalog data available in L&D services.
use the following API with course_id to test the course availabulity in L&D
https://ldserviceuat.portal.azure-api.net/docs/services/Catalog/operations/58d4f57055915813c8fa7fc3
What are the relevant TFS items? (list id numbers)
102357
Definition of done:

[ ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[ ] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage

Reminders BEFORE merging

Get at least two approvals
If you're merging from a feature branch into the development branch then "flatten" or "squash" commits
If merging from the development branch into master (or porting changes from upstream) then use github's UI to get review feedback, but use the git command line interface to complete the actual merge.

Reminders AFTER merging

Delete the remote feature branch
Resolve relevant TFS items
(reverse merge) If you merged from the development branch into master then check to see if there are any changes in master that can be merged down to the development branch (like hotfixes, etc). In this case, use github's UI for feedback and the git command line interface for the actual merge.

i'll review this today

i think you should consider scheduling a 30 or 60 minute meeting to review this with others. ~550 lines of python is a lot to go through. it'd give reviewers a "forcing function" to give this time it deserves and directly ask questions as they make their way through it.
in any event: i promise i'll finish my review today

Sure @sdolenc  i will schedule some time for in-person review

closing this PR, as the implementation is completely changed  and some of  the feedback is on first version.
will submit a new PR in VisualStudio Online internal.


Added sample-config feature

[x] Fixes #120
[x] Fixes #24
[x] Fixes #122
[x] Fixes #100
[x] Tests
[x] Documentation

Nice, thanks!


Add 'azure batch account login' command to enable aad auth.

@derekbekoe Thank you for the suggestion. I updated the test to use the mocked config.


Issues 3/4/24

The character can walk through some of the furniture inside the house (bed, bookshelf, side table with spellbook).
The character can walk on water.
I accidentally threw a potion on the other potions on the "ingredients shelf" - the potion that gets hit flies/rolls away into infinity and it didn't stop.
I couldn't mix the potions together or even put them in the cauldron, so I couldn't play that much into the game.

Suggestions if there is time:

Maybe we should implement more guidelines on how /when to use E or mouse click.
Add dialogue on what to do, like "hm, maybe I should to try mix some potions to get past the cursed plant", to understand the narrative.

(leif)edit:
need collider: det nye trærne, sengen, bokhyllen, garderoben og sidebordet med spellbooken 🙂

note to self, re: floating item, "dispencer" items, rigidbody, disable/kinematic/freeze posrot

When you pause and press continue, if you have an object selected in the hotbar, the character throws it away. I accidentally threw it on the ingredients shelf, which resulted in the potions/pots flying around like they're in space, and can no longer be picked up.

Not possible to mix and store (in hotbar) several of the same potion.


Allow specifying password and database number

When using this with CakeResque, I needed to set password and database number.
After a very quick look, this feature does not seem available.  So, at the moment, I hardcoded the $this->auth(password) and $this->select(n) in RedisApi::establishConnection() directly.
Would appreciate if this can be configurable when used together with CakeResque`.

Added in 1.3.0