handle user updated metadata settings

metadata settings related to k8s versions current, default and deprecated
shouldn't get overridden once user updates them
https://github.com/rancher/rancher/issues/22572

@kinarashah would adding a test be possible? Also is there a way to restore to the default settings, once modified? If so, would be nice to add a test for it as well.

What happens if user modifies settings and kontainer-driver-metadat gets updated to deprecate some k8s version - will that rancher setup still keep allowing the deprecated versions?

@prachidamle it's going to be up to user/admin to be aware of that and adjust the setting. That's an implication of using a custom setting values.
Think of it similar to UI tag setting - if user adjusts it to some custom value, and then something changes in the backend code and the custom UI no longer works. Same for default docker version and other settings.

@alena1108 @prachidamle made the following changes:

earlier, no default value for settings was set since they were updated dynamically. Now, on every sync, we also update default value so user can see what's the current default value based on system sync.
if user updates value, we validate to make sure default k8s version is present in k8s-versions-current
for user updated values, we make sure not to override them and use them to calculate other values like version-to-images, ui-default-range etc
similar to other settings in rancher, when user updates value to empty, the setting would would fallback to default value. we set the label io.cattle.user.updated to false
added tests to cover these scenarios
refactored a bit of code to handle these changes

LGTM


Stream encoding

The encoding package now works with readers and writers instead of byte slices. This is how json and gob do things, and I can see why.
Also some minor fixes that didn't make it into the last PR.

Also, the build is randomly timing out. No idea why, but we should investigate for sure.

Is this ready to go?
I too have noticed the build randomly timing out. I'm 98% sure it started when I flipped the subscription model of the wallet. I think there's an api call that tries to wait for an update which has already happened. It hasn't shown up on travis ci yet though so I've mostly ignored it.
It's not currently super high on my todo list, but it'll get fixed when I move the api package over to the new testing paradigms. I don't think it's a simple fix but I also don't think it's a difficult fix. It'll just take time.

Yep, good to go.
If you want to hunt down the bug you can use git bisect. Might be tedious waiting for all those tests to time out though.


OSVRDisplayConfiguration::activeResolution() return by copy

Can we have OSVRDisplayConfiguration::activeResolution() return a copy of the Resolution?
Right now I have to instantiate a const copy of the OSVRDisplayConfiguration on the stack just to call activeResolution() so I can inspect the Resolution.
I don't want to change the resolution, just see what it's set to. My usual instantiation of OSVRDisplayConfiguration is copied to a non-const member variable. So I can't call activeResolution() on that because the non-const version of that member function is private.

I don't recognize any of those calls, so maybe this should be an issue for Core?

Or is this one of the structures I copied into RenderManager to fix and haven't put back yet?  If so, go ahead and change it.


Switch to US English

We're going with US English instead of UK/Aust English on this site, so let's stick with "flavor".

switching -ise -> -ize (-isation -> -ization) & other stuff as appropriate

Booooo...
:-)
(Of course, the UK/AU English is all me...)


Add IncludeErrorDetail for exposed logs in tests

Please consider to add IncludeErrorDetail and/or IncludeErrorDetails into generated connection strings to be able to inspect more logs, when tests with IntegreSQL are failed.
See these flags documentation
Example, why it can be usefull:

https://github.com/mcctomsk/IntegreSql.EF/blob/6dd563bc03063849d15eb07f94bb0b1f0794db60/src/MccSoft.IntegreSql.EF/NpgsqlDatabaseInitializer.cs#L191

Can you provide a Pull Request for that? :)

Okay (:


Add OneGameLauncher (Free Store App)

Added One Game Launcher:
https://apps.microsoft.com/store/detail/one-game-launcher-free/9PB82SFMMGRB

Thanks for the PR! Looking now.

Quick questions actually. Do you generally use the stand alone window, or the Game Bar widget?

If you think it makes sense, in the future I can add more Launchers like Heroic (https://heroicgameslauncher.com/), GOG Galaxy, Google Play Games and Epic Games.

And I already advance my apologies if something is not satisfactory. My contact with C# was only ASP.NET and Windows Forms. At most I've tried something from MAUI recently, but nothing too in-depth

Since the focus is controller first, I would prefer a controller friendly interface but it's not strictly necessary

Nice, I will ignore Epic games Launcher and GOG Galaxy for now and I will bring Heroic Games Launcher as it has controller support.

You can count on me for Brazilian Portuguese translation

Sweet!


Async Loading Framework

Create a framework for asynchronously loading cubes and columns from disk. In the interest of keeping PRs manageable, I tried to avoid changing code to actually using async loading where possible. A second PR for that should be coming soon.

um... I actually meant something cliser to cubicchunks/server/chunkio/async/forge package. Using exact forge backage is usually a bad idea. Does it even load? I would think forge would have some classloader special case to prevent that.

I actually meant something closer to cubicchunks/server/chunkio/async/forge package, to separate the code from forge. Using exact forge backage is usually a bad idea. Does it even load? I would think forge would have some classloader special case to prevent that.

Works fine for me, but I can rename it again

I don't see any check for trying to load a cube synchronously while it's already being loaded asynchronously, forge does it. According to Forge code, it will cause weird chunk breakages. WOuld be good to add that check.

That passage applies to non-anvil chunk loading, where somewhere a chunk load is called outside the main thread. This does not apply to us, or forge in their async implementation - AsyncWorldIOExecutor.syncLoadChunk also finishes outstanding async loads


fix: incorrect behaviors in Batch Entity Upsert endpoint

noOverwrite option is not handled whereas it should be passed when in update mode
replace mode was only replacing the attributes of the entity (and thus was missing all the other needed actions: replace types and scopes, send events...)

@thomasBousselin OK for you?


python setup.py egg_info did not run successfully. Error Installing CorpTools-Moons

Pretty Straight forward issue will try and PR later today if i can but for now reporting the issue on a Fresh Install of AA with Corp-tools and onvoices already installed.
(auth) allianceserver@localhost:~/myauth$ pip install allianceauth-corptools-moons
Collecting allianceauth-corptools-moons
  Using cached allianceauth-corptools-moons-0.3.4.tar.gz (718 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [3 lines of output]
      error in allianceauth-corptools-moons setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
          allianceauth-corptools>=2.1.2allianceauth-invoices>=0.1.1
                                ~~~~~~~~^
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Good pickup, not sure how it went this long without being noticed.

No idea either, feel free to install from master for this, should work fine.


handle patterns in exclude list

Codecov Report

Merging #409 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #409      +/-   ##
============================================
+ Coverage     91.32%   91.36%   +0.03%
- Complexity      204      205       +1
============================================
  Files            10       10
  Lines           519      521       +2
============================================
+ Hits            474      476       +2
  Misses           45       45

Impacted Files
Coverage Δ
Complexity Δ

src/Tools/RouteMatcher.php
97.43% <100%> (+0.13%)
17 <1> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5267dc...0622141. Read the comment docs.

This is great work! I think we should add it for includes too, for consistency's sake. Also, please update the documentation.

Thanks! I updated the readme and the config template, and I also add this functionality to includes.

Thanks for this excellent PR.


Standardise on requirements.txt rather than Pipfile

Most other Infra Python projects use a requirements.txt file rather than a Pipfile.

Ugh. I didn't even know about the Pipfile. I recently added a new requirement to pyproject.toml and missed Pipfile. ... I don't even know what uses Pipfile.
pyproject.toml is the appropriate place to put dependencies, as that's what is used to build the package for upload to PyPI. Note sure if pip can read a .toml

Pipfile was used for pytest coverage and only that. I believe this is now covered by the TOML and Poetry, so it should have obsoleted itself by now. I'll verify with Wells.

We have decided to standardize on pyproject.toml and the Poetry tool.


IdentityServer4 does not redirect to client after login - #1885

I'm opening this bug to relate to #1885 since that one got locked and it's never been fixed.
I'm experiencing the same issues described there where you try to login with your credentials and IdSrv4 keeps redirecting me right back to login page, but only with one browser while with another it just works perfectly.
Right now it's happening to me with Chrome being the faulty scenario, while with Firefox it just works as expected. Other users give me the same feedback, with different browsers.
Differences in logs between faulty and successful scenarios:
Faulty:
2020-08-19 12:44:52.632 +02:00 [DBG] Request path /connect/authorize/callback matched to endpoint type Authorize
2020-08-19 12:44:52.633 +02:00 [DBG] Endpoint enabled: Authorize, successfully created handler: IdentityServer4.Endpoints.AuthorizeCallbackEndpoint
2020-08-19 12:44:52.633 +02:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.AuthorizeCallbackEndpoint for /connect/authorize/callback
2020-08-19 12:44:52.634 +02:00 [DBG] Start authorize callback request
2020-08-19 12:44:52.634 +02:00 [DBG] No user present in authorize request  <== ** HERE **
2020-08-19 12:44:52.634 +02:00 [DBG] Start authorize request protocol validation

Successful:
2020-08-19 12:44:06.064 +02:00 [DBG] Request path /connect/authorize/callback matched to endpoint type Authorize
2020-08-19 12:44:06.065 +02:00 [DBG] Endpoint enabled: Authorize, successfully created handler: IdentityServer4.Endpoints.AuthorizeCallbackEndpoint
2020-08-19 12:44:06.066 +02:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.AuthorizeCallbackEndpoint for /connect/authorize/callback
2020-08-19 12:44:06.068 +02:00 [DBG] Start authorize callback request
2020-08-19 12:44:06.072 +02:00 [DBG] User in authorize request: 7a15d666-bb80-43ea-b882-ab90015ae21b  <== ** HERE ***
2020-08-19 12:44:06.072 +02:00 [DBG] Start authorize request protocol validation

After the call to the ProcessInteractionAsync, logs diverge, but up until there, both logs are exactly the same with the exception of the log line detailed before.
How comes that one browser works and not the other? I already cleared cookies from sites and even tried on Incognito.
I even went only for the /grants page I implemented from the Quickstarts to try and test that it wasn't some configuration for my client application, and it happens the same, so it's not a client misconfiguration. And it's also pretty random, because I could work with Chrome on this site for a few months and only this week it started to misbehave like this.
Any idea anyone?

I suspect it's something about how you';re issuing your cookie and the cookie is not sticking in the browser. Are you using SameSite=none but not using HTTPS, perhaps?

Hi Brock.
I am indeed not using HTTPS because it's deployed in an environment for which the company doesn't have certificates, but I'm not specifically setting anything about SameSite. I'm just using it as it is.
Looking at the cookie I see the following

I still wonder how comes it worked until last week on the same browser and now it doesn't... But still on another browser it still works. No new deploy was made in the meantime and all of a sudden, this started to happen to me as well. Some people already experienced it before me.

@CesarD I'm having this exact issue. Did you find any fix?

@CesarD I'm having this exact issue. Did you find any fix?

I couldn't find any specific reason or fix for the scenario I had. So I just went ahead and changed my servers to make all of them use HTTPS like @brockallen suggested and so far I haven't experienced this issue again...
I'd really like to figure out why with only HTTP it creates that kind of really random behavior, but oh well, I don't have the time right now to tinker with that. I only know that it's not really a client side issue, because aside of the HTTP -> HTTPS change, I haven't had to change anything else on my environments.


Update experimental qos_policy_config_test.go

Added experimental qos scheduler-policies config

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.611%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1663

Relevant Lines:
2389

💛  - Coveralls

The static analysis error is from different file which should be fixed by the tool due to import module update.


hide sapp iframe until it loads completely

closes #1008.

Travis automatic deployment:
https://pr1020--safereact.review.gnosisdev.com/app

Looks good, The Apps are no longer loading at the bottom of the page

Travis automatic deployment:
https://pr1020--safereact.review.gnosisdev.com/app

Please also add types for styled-components
yarn add -D @types/styled-components

Travis automatic deployment:
https://pr1020--safereact.review.gnosisdev.com/app

please, do not merge yet

Travis automatic deployment:
https://pr1020--safereact.review.gnosisdev.com/app

done, I fixed a regresion

Travis automatic deployment:
https://pr1020--safereact.review.gnosisdev.com/app


Use lodash.assign instead of Object.assign polyfill for this to work on react-native

There is the infamous react-native issue with react-native's Object.assign polyfill where this error is triggered when spreading anything with a prototype chain. https://github.com/facebook/react-native/blob/master/Libraries/polyfills/Object.es6.js#L48-L62.
It looks like other projects like apollo-client avoid this (and get react-native compatibility) by using lodash assign.
Is this something you'd be open to?

@neoziro what about https://www.npmjs.com/package/xtend?


allow more modern ecto versions as well

@eikes I want to stick with pessimistic versioning for the time being. Ecto is moving fast and I want to make sure I test / update scrivener based on any of the changes they make in minor versions before the 1.0 bump. After ecto goes 1.0 I'll probably relax the version requirements to ~> 1.0.

Ok, that makes sense.


Flit core readme

Provide additional context for flit-core, fixes https://github.com/pypa/flit/issues/612.

Close-reopen to test with the CI fix in #615.


tests/kernel/common failed on iotdk board.

Describe the bug
tests/kernel/common failed on iotdk board, this issue occurred after the commit ID 3fe53db.
To Reproduce
Steps to reproduce the behavior:

west build -b=iotdk tests/kernel/common
west flash

Screenshots or console output
***** delaying boot 500ms (per build configuration) *****
***** Booting Zephyr OS build zephyr-v2.0.0-474-ga077bdd417d5 (delayed boot 500ms) *****
Running test suite common
starting test - test_verify_bootdelay
PASS - test_verify_bootdelay
starting test - test_irq_offload
PASS - test_irq_offload
starting test - test_byteorder_memcpy_swap
PASS - test_byteorder_memcpy_swap
starting test - test_byteorder_mem_swap
PASS - test_byteorder_mem_swap
starting test - test_sys_get_be64
PASS - test_sys_get_be64
starting test - test_sys_put_be64
PASS - test_sys_put_be64
starting test - test_sys_get_be32
PASS - test_sys_get_be32
starting test - test_sys_put_be32
PASS - test_sys_put_be32
starting test - test_sys_get_be16
PASS - test_sys_get_be16
starting test - test_sys_put_be16
PASS - test_sys_put_be16
starting test - test_sys_get_le16
PASS - test_sys_get_le16
starting test - test_sys_put_le16
PASS - test_sys_put_le16
starting test - test_sys_get_le32
PASS - test_sys_get_le32
starting test - test_sys_put_le32
PASS - test_sys_put_le32
starting test - test_sys_get_le64
PASS - test_sys_get_le64
starting test - test_sys_put_le64
PASS - test_sys_put_le64
starting test - test_atomic
Unimplemented system call
[00:00:00.717,000] [1;31m os: >>> ZEPHYR FATAL ERROR 3: Kernel oops[0m
[00:00:00.724,000] [1;31m os: Current thread: 0x80000df0 (unknown)[0m
[00:00:00.731,000] [1;31m os: Halting system[0m
Environment (please complete the following information):

OS: Fedora28
Toolchain: Zephyr-sdk-0.10.3
Commit ID: a077bdd

What implementation of atomic operations is this board using?

@chen-png are you sure that problem started to happen after that commit #3fe53db ? Because it seems that commit wasn't connected with any of the core changes of the kernel.

@andrewboie @ioannisg
Do you have any concerns where is the problem? Today I tried to use GDB to debug it, and program crashes in line 47 of the file atomic.c atomic_add function.
I commented that function out from the file atomic.c,
	/* atomic_add() */ 	target = 1; 	value = 2; 	zassert_true((atomic_add(&target, value) == 1), "atomic_add"); 	zassert_true((target == 3), "atomic_add");
and also deleted call of that function from the main.c file.
Then I ran a test again, it was passed successfully.
I decided to dig deeper, opened file zephyr/kernel/atomic_c.c, checked how that function is implemented.
atomic_add is not working (we receive that error "Unimplemented system call"), but atomic_sub works well, logic of that functions is absolutely the same and code for that functions is the same except one function has "+", another has "-" in the code.
I also tried to change setting in prj.conf file and changed CONFIG_TEST_USERSPACE setup, but still the same error.
Any thoughts about it?

@vonhust Let's try to solve that issue together.

@maksimmasalski the root cause of this issue is #19370. I will provide a fix soon


Updated KUBE_GIT_VERSION_FILE and bumped prod RELEASE for 1.20-2

Issue #, if available:
Description of changes:
Hold until release
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold
Until release is ready to be cut

Deleting in favor of https://github.com/aws/eks-distro/pull/413


some rules with psr-12 preset seems incorrect

Pint Version: 0.2.3
PHP Version: 8.0.17

Description:
psr-12 preset is using incorrect if block structure with exclamation mark.
Steps To Reproduce:
run the linter with an if statement with exclamation mark.
1-
-            if (!empty($toRemove)) {

2-
+            if (! empty($toRemove)) {

also with docblocks:
1-
@param string $id
to
2-
@param  string  $id

and
1-
@param $id
to
2-
@param    $id

I would say 1st examples supposed to be correct or am I missing something here ?
another issue is the removal of spaces before and after the . is half compliant with PSR-12
as it only recoomends to do it the same throughout the project -> and we used to use " . " and not "." what is it converted to now:
https://stackoverflow.com/a/66033448/1194797
https://xoops.gitbook.io/xoops-modules-cookbook/coding-standards/standards/styleguide#concatenation
-                echo "Usage:" . PHP_EOL;
+                echo 'Usage:'.PHP_EOL;

thanks in advance.

The code snippet you suggested on the "docblocks" tells me that you are using the Laravel preset. Can you double check that?

@mirzazeyrek Can you share the full console output please?

I will re-open this issue once you share the console output.


Dependency updates

There are breaking changes going from syntex_syntax 0.17.0 to 0.18.0. You need to change the code too.

I forgot to run local tests, all tests pass now.

Nice, thanks @pmarcelll !


[9.x] No need to implement an interface twice.

There is no need mentioning that a class implements an interface, when its parent class already implements it.

@taylorotwell we could simplify the docs for custom transports as well.

@driesvints will do


Add Styled Profile Template to Profile View

Summary
Adding a very basic template for example stats to show off on a profile page. Added basic CSS styling for the profile directory view.
Resolves issue #72
Reviewer Guidance
Would like feedback on how to proceed with Profiles/edit (POST/PATCH) in profile_controller. Currently, the edit form is not updating any values upon submission. (Try modifying the profile description).
Demo
When signed in:

Signed out:

@GitRepsOfficial Fixed the controller issues that were causing the description not to save. Also removed the custom CSS classes. Ahmed is going to work on top of this branch to add better UI styling and organization, but just wanted to make sure everything else looks good.

Use Tailwinds Assets: https://www.figma.com/file/h7PH5bBzhsb7A87ZOi1T0w/Tailwind-UI-Components-for-Figma-|-TailGrids-(Community)?type=design&node-id=72-303&mode=design&t=tvXCn0r1hexB3tT8-0
Here is the Figma File I will be using:
Once This FIgma is completed, I will be building on top of these with the new assets


Fix wording in PR template

Any of the checked boxes below indicate that I took action:

[x] Reviewed the Contribution Guidelines.
[x] Signed the Gradle CLA.
[x] Ensured that basic checks pass: ./gradlew quickCheck

Thanks @fejese!


maxBuffer should be passed to exec() correctly

Fixes danielgtaylor/atom-api-blueprint-preview#44
{env, options} was previously incorrectly expanding to "options: {options: {maxBuffer: ...}}" when being passed to child.process.exec()
now it's passed correctly as "options: {maxBuffer: ...}"
maxBuffer is still not "infinity" but at least it is being passed correctly now and works for much bigger files
solving "stdout maxBuffer exceeded" issue

@danielgtaylor can this be merged anytime soon? This would solve issues with previewing larger apiblueprints which is not possible at the moment.

@danielgtaylor can this be merged anytime soon? This would solve issues with previewing larger apiblueprints which is not possible at the moment.

Yes please. Been anxiously looking forward to the resolution.


[RFC] Set display: none on hidden docks

Sometimes, it's useful to be able to tell if your item is currently visible to the user or not. This can be used to back off of work, for example.
After talking to @nathansobo and @maxbrunsfeld, we decided the best way forward was to be able to use IntersectionObserver for this…but there are some issues.
The first is that—in its current iteration, at least—it doesn't seem to observe when visibility changes as a result of being masked by an overflow: hidden parent, which is how docks do it. (See pen.)
To work around this, I put together this commit which toggles the display of the wrapper element when the dock is shown and completely masked. This guarantees that the IntersectionObserver will broadcast notifications at the appropriate time. However, this too has an issue: the intersectionRatio property (which I'd assume people would use to determine if the element was visible) is 0 at the beginning of the show animation. This kinda makes sense because, well, yeah, it isn't actually shown at all yet at the point when the animation to show it starts. I'm assuming that this is why the isIntersecting property was added (but I'm a n00b wrt the API so maybe not). After some playing around, though, I discovered that there was a way to distinguish between the visible and hidden states as, in the case of the item being shown, the width + height was nonzero.
So I wrote up some tests to verify the behavior and they pass…
but then I ran my tests without my dock changes and they still pass. That would seem to imply that the overflow: hidden masking is actually triggering an IntersectionObserver notification?? 😖 (It doesn't if you observe the tree view and toggle the dock.)
@nathansobo @as-cii Any guidance you could give about this inconsistent IntersectionObserver behavior would be super appreciated.

Hey, sorry, this has been sitting in my inbox for way too long. I honestly don't have a ton of experience with IntersectionObserver. My only use of it is in the text editor where I don't rely on any of the data on the event. I simply use it as an opportunity to check that visibility has changed by inspecting offsetHeight and offsetWidth. It sounds like that might be useful in your case as well, so maybe these tests should simply indicate that an intersection event was fired without making claims about its contents.
Anyway, if you're still interested in getting this in, I am down to keep interacting on it. First step would be a green build.

Hey @matthewwithanm. Apologies for not looking into this on time. I know this PR has been here for a very long time, during that time Atom has seen a number of changes. Due to the changes, this PR has now become outdated. Is it possible for you to resolve the conflicts?

Thank you for your PR!
We haven't gotten a response to our conflict resolution request. I'm going to close this but don't hesitate to reach out if you have or find time to resolve the conflicts, we'll be happy to reopen the PR.


Receiving a direct message in Windows 10 causes window to relocate and resize

My Setup

Operating System: Windows 10.0.18362

App Version: 2.16

Installation type:

[X] I have tested with the latest version

[X] I can simulate the issue easily

Description
When the rocket chat is visible, but not with focus and someone sends me a direct message or notify me in a room, the application screen is resized.

Current Behavior
The desktop app resizes and someone sends me a direct message, or notify me in a room.
Expected Behavior
The desktop app should not be resized.

Same issue : https://github.com/RocketChat/Rocket.Chat.Electron/issues/1321
Really annoying behavior, especially on multiscreen configuration.

Very annoying indeed, get crazy because it

@williamjamir  @Silimilikim Does this happen exclusively when using 2 screens or have you seen this happening with only one screen as well?

@MartinSchoeler, first of all, thanks for your time to investigate this issue!
Unfortunately, I cannot reproduce more this issue (tested on 2.17), and I don't know if was a complete reinstall or a simple update that fixed this issue.
BTW, sorry for not updating this issue with this information 😞
Either way, let's wait for @Silimilikim and @Dunexus to see if they still have this problem otherwise I think that we can this issue and  #1321

@MartinSchoeler only one screen for me

I use it at work in a two/three screen configuration. It still happens on 2.17

May have been fixed by #1810


fix the figure style in https://baguasys.github.io/tutorials/performance-autotuning/index.html to be consistent with other pages

closed by https://github.com/BaguaSys/tutorials/pull/26


node js template is getting published but azure bot is showing (gateway timeout and internal server error)

the node js template are working fine in local. Whenever deployed in azure hitting error (gateway timeout and internal server error) in test in web chat. In the case of .NET projects the deployment is working fine in  testing webchat.
I tried to make the app logs also. i will add the images below.
I tired of reinstalling the node modules also but no change. I tried of publishing the bots from different system to azure all the system are hitting with the same issue. we are stuck for past 2 weeks. can anyone suggest a solution

Might be related to #9577
Could you please try publishing using the latest Composer Nightly build version:
https://github.com/microsoft/BotFramework-Composer-Nightlies/releases
Note, the initial publishing attempt failed as the azure resources were not fully ready after provisioning. Then after publishing again, the second attempt of deployment was successful.

Closing due to inactivity.


chore: Rewrite promotion strategy

Codecov Report
Attention: Patch coverage is 40.36145% with 99 lines in your changes missing coverage. Please review.

Project coverage is 46.76%. Comparing base (26f7c99) to head (447a493).

Files with missing lines
Patch %
Lines

...nternal/controller/promotionstrategy_controller.go
36.30%
83 Missing and 10 partials :warning:

internal/utils/utils.go
70.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   50.14%   46.76%   -3.38%
==========================================
  Files          15       15
  Lines        1041     1052      +11
==========================================
- Hits          522      492      -30
- Misses        450      486      +36
- Partials       69       74       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix: Tooltip not displaying when value from BackgroundBarChartRodData is less than zero

Added backDrawRodData's y-axis to take in account when calculating pixels.
close #1345

Thank you very much!


OpenAIAuth.init() got an unexpected keyword argument 'cf_clearance'

Getting the following error, probably related to https://github.com/acheong08/OpenAIAuth/commit/cfb9a17bb4138ce05fd63cde53c685c5381b6a1a
Traceback (most recent call last):
  File "/code/project/slack.py", line 16, in <module>
    chatbot = Chatbot(config, conversation_id=None)
  File "/code/project/slack.py-ggXW00PY/lib/python3.10/site-packages/revChatGPT/revChatGPT.py", line 96, in __init__
    self.refresh_session()
  File "/code/project/slack.py-ggXW00PY/lib/python3.10/site-packages/revChatGPT/revChatGPT.py", line 352, in refresh_session
    raise exc
  File "/code/project/slack.py-ggXW00PY/lib/python3.10/site-packages/revChatGPT/revChatGPT.py", line 349, in refresh_session
    self.login(self.config["email"], self.config["password"])
  File "/code/project/slack.py-ggXW00PY/lib/python3.10/site-packages/revChatGPT/revChatGPT.py", line 375, in login
    auth = OpenAIAuth(email, password, use_proxy=bool(
TypeError: OpenAIAuth.__init__() got an unexpected keyword argument 'cf_clearance'

You have to set cf_clearance now. It's due to https://github.com/acheong08/ChatGPT/issues/261#issuecomment-1346019919

You have to set cf_clearance now. It's due to acheong08/ChatGPT#261 (comment)

set where exactly?

In the config: See https://github.com/acheong08/ChatGPT/wiki/Setup

In the config: See https://github.com/acheong08/ChatGPT/wiki/Setup

thanks, wasn't following the development during the weekend. Looks like cookie is the only available auth for now


Sharepoint folder - Power Query Authentication issue

Hi,
Your article indicates that I should be able to do what I want, which is to specify the contents of a Sharepoint Folder as a source for a Power Query. I have followed your steps as best I can but keep running into an authentication issue.
My Excel interface is slightly different from yours, but I start with Get Data - From Web, (no Sharepoint specific option).
I paste my Sharepoint URL into the address box. My Sharepoint address is of the form https://.sharepoint.com/sites/FinanceRecords31/Shared Documents/General/Time Journal Engine/Current TS
I don't believe that contains any invalid characters. I have entered a specific pathname, rather than one higher up the tree, to reduce the number of items the PQ tries to load.
I have several different organisational MS365 accounts on my desktop, but am only signed in to the one corresponding to this sharepoint site. In Data Source Settings / Global Permissions I have credentials set to Organisational Account. But quite often the system is forgetting the Organisation Account setting, and also telling me I'm not signed in (when I am).
When I try to Connect is just get the message 'We couldn't authenticate with the credentials provided. Please try again.'
In the same project I am reliably accessing specific files within the same folder using
Source = Excel.Workbook(Web.Contents("https://<site-name>.sharepoint.com/sites/FinanceRecords31/Shared%20Documents/General/Time%20Journal%20Engine/Current%20TS/AB-TS.xlsx"), null, true),

I see this has the invalid character % automatically inserted several times. Yet this works.
It would be great if you could help me resolve this.
Thanks,
Andy

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b7fa007-53f0-1fa5-bbff-b59fe142c804
Version Independent ID: acb9ddd9-08ea-79ea-3537-cf8bda64282b
Content: Power Query SharePoint folder connector - Power Query
Content Source: powerquery-docs/Connectors/SharePointFolder.md
Service: powerquery
GitHub Login: @DougKlopfenstein
Microsoft Alias: bezhan

Hi @andymcw
This appears to be a customer support issue rather than a documentation issue. For information about customer support for Power Query connectors, go to Power Query connector feedback.


[Feature Requests] some blogish features

Hey love the theme, it's really fresh and interesting, i feel some parts are missing like:

direct links to post(s)
tag support
pagination

etc,
besides that the concept is amazing, works well on destop and phones/tablets

Hello, @marteaurouge
Sincerely speaking, this theme (I think it's not even a theme, just a page with some placeholders) was never supposed for blogging. I've ported it for a page with contacts. There are no styles for rich text, no layouts and no desire to write them. Choose from many great  blogging themes here, please, or fork this repository and do it yourself! You are right, concept is good, well, everything is in your hands:)

okay :) thanks for sharing this btw!


Auto import of React components not working if no previous import of React module...

TS Template added by @mjbvz
TypeScript Version: 4.4.1-rc
Search Terms

auto import
jsx
react

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.59.0
OS Version: Windows 10

Steps to Reproduce:

Start to write a new component (.tsx file)
Try to import a component inside your component, from another file

Details:
When using auto import of components, vscode do not display the import line unless I have imported React before (import React from "react";);
But, since React 17, importing react is no longer needed and so I don't see why we still need to have this import to make the auto import work.
Please refer to this article about the new JSX syntax: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html
Note that I am using TypeScript, that's why my files are .tsx files instead of .jsx.

We need an actual concrete repro, including things like:

Your tsconfig
The layout of files on disk

Where the file you created is
Where the file you're expecting to import from is

Where your cursor was in the importing file
etc

I am using Next.js 11, without any specific configuration. Only the one recommended on the official website to switch from js to ts.
I can create a repro repository if you like.

A repository would be great, thanks!

Here we go: https://github.com/Odonno/repro-45449
Clone the repo, open the index.tsx file (https://github.com/Odonno/repro-45449/blob/main/pages/index.tsx) and try to import the  component with auto import.

try to import the component with auto import.

What is "the" component? What are you typing, and where?

Sorry, I made a mistake when writing my previous message. Trying to import the <Footer /> component using CTRL+. shortcut.

You need to set "jsx" to "react-jsx" in your tsconfig if you're intending to depend on the React automagic importing

Can you give me more info?
I have tried this but this is not working:
{
  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "downlevelIteration": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "react-jsx": "preserve"
  },
  "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"],
  "exclude": ["node_modules"]
}

Did I miss anything?

Ok. Working fine. Thank you!


Improvement of the Check xml tag (OFBIZ-12821)

Added features :

Pre-select / Pre-check
-> Chose which should be pre-check
Pre-unSelect / Pre-unCheck
-> All checked and select whose should not be checked

EDIT :
OFBIZ-12821
Thanks:
Néréide

Hi @MaximeFlame,
Xml attributes checked-by-default and unchecked-by-default seems to add only code complexity without most value.
With the possibility to check form a pk list, you have natively this functionality through the prepare statement.

Code updated @nmalin

Hi @MaximeFlame,
Do your code changes answer to @nmalin's suggestion? BTW I don't clearly understand your suggestion Nicolas :)
Also there is a test issue...

Hi @JacquesLeRoux, I shared with him on IRL,
I said we can have the same functionnality to precheck or uncheck easly with set the good id list on the context. So  adding two attributes to do that is redundant and finally add unnecessary code.

Nicolas, do you mean in the screen or java methods? Maybe we could document that it's still not crystal clear to me, sorry :)

Hi @MaximeFlame,
Do your code changes answer to @nmalin's suggestion? BTW I don't clearly understand your suggestion Nicolas :) Also there is a test issue...

Yes

Hi @nmalin,
Thanks for the explanation, I got it looking at QuoteForms.xml where OTHER_QUOTE and PROPOSAL are preset.
I simply amended the doc in widget-form.xsd. I'll commit from my machine


Remove unnecessary null pointer checks

Extra null pointer checks are not needed in functions like the following.

CmSurface
CmSurfaceManager::Destroy
CmTask_RT::Destroy
CmThreadSpace::Destroy

Agree, we'll clean it up.


Set a retry limit

For some reason wayback seems to trip on certain URLs, and it always returns an error.
The target URL <url> returned a Bad Gateway error. (HTTP status=502).

This causes the job to keep retrying, even when it keeps getting the same error back. Ideally we should stop retrying after 5 failures or so. Interestingly this is a wayback issue since the url does eventually appear in the archives.

In practice, the script relies on SPN returning the "this URL has already been captured 10 times today" error message to limit the number of retries for URLs that always return a theoretically recoverable error. There is technically a limit that is already in the script, but it relies on failed.txt being exactly the same as the previous copy (i.e. the same URLs failed in the exact same order), which evidently doesn't work for many cases.
Currently the script does not explicitly track how many times each URL has failed, although it could be determined by counting the number of appearances of each URL in the failed*.txt files. I don't really understand awk code but I was able to find a Stack Exchange answer that could potentially be adapted to this use case.
In some cases it is possible that a URL would only be successfully archived after 6 or more attempts, though this would only happen if the probability of the captures failing is particularly high. Since there is technically already a measure built into SPN to prevent URLs from being endlessly retried, I would probably implement this as an optional flag where the user can choose the maximum number of retries (i.e. if -m 1 then after 1 retry the URLs are added to max-retries.log).


Small image display

https://github.com/kreshuklab/teaching-dl-course-2019/blob/master/Webinars/exercise1/image_manipulation.ipynb?short_path=a1d32b1#L385
Doing this results for me in very small images; it is hard to see anything.
For me, it is better to use two times cv2_imshow.

Have you tried using the matplotlib functionality instead?
In general, I would discourage using the openCv python bindings, the combination of skimage
and matplotlib is easier to set up and much more common in the python image analysis community.

Yes, we're switching to matplotlib afterwards. I just wanted to generally show them what you can do with images, but thanks, I didn't know what's more common. I wouldn't change the library now (the exercises were sent off like 4 days ago already), but we'll consider it for the next year


Make availability zone configurable for rds aurora

Please add another input variable availability_zones to aws rds cluster
resource "aws_rds_cluster" "default" {
  availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
}

Thanks

I believe that it was removed intentionally. Please check https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/10 to get more details.

Closing this one, according to what @kozub refers to.

So what is the alternative is AZs are now removed how is it possible to select an AZ or doesn't it matter?

You need to specify the DB subnet group and don't use the availability zone. See this, for example: https://github.com/hashicorp/terraform/issues/16724#issuecomment-400353356


feat: add support for span id and custom key for trace id and span id for otelzap

fixes #109

Thanks for the PR, but otelzap now uses Otel Logs API which has top-level fields for trace & span ids.

Hi @vmihailenco could you clarify that? this PR is backward compatible, it happens that many vendors don't follow the same API yet and this would be required to support New Relic for example.

@pragmaticivan otelzap now does not inject trace_id/span_id and instead relies on Otel Logs API to do it automatically: https://github.com/uptrace/opentelemetry-go-extra/blob/main/otelzap/otelzap.go#L164-L196
And Otel Logs API will set trace/span ids on the log.Record structure directly without using attributes.

would be required to support New Relic for example.

New Relic would just need to support OpenTelemetry Logs API.


Cannot get svg from file.

I like your solution and it works with url, but I try to use with file like resources.
Can you please create an example how to add file svg to the project and then use it? I tried many ways and no success.
Many thanks in advanced.
Alex

I found how to do that.

Create a folder Resources in your main project, not .Droid or .iOS
Make all files as Embedded
your image =  SvgImageSource.FromSvgResource("tiger.svg");


[Group-2] Update rest.md Part2

What is the purpose of the change
add English docs of RESTful Remoting
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Test your code locally by running docsite start, and make sure it works as expected.
[x] Make sure no files under build directory is added.
[x] If this contribution is large, please follow the Software Donation Guide.

Follow the step-by-step approach. You could add the “Prepare” module before the “Quick Start” to introduce the dependencies and installation methods of the relevant environment, and reduce the entry threshold for beginners.
You can add a “Vocabulary” at the end to explain some key words.


V1.0.5 error message in install

I got an error message when I tried to install the driver:
user@LokalWiki:~$ wee_extension --install weewx-weatherlink-live-v1.0.5.tar.xz
Request to install 'weewx-weatherlink-live-v1.0.5.tar.xz'
Extracting from tar archive weewx-weatherlink-live-v1.0.5.tar.xz
Traceback (most recent call last):
File "/usr/share/weewx/wee_extension", line 88, in
main()
File "/usr/share/weewx/wee_extension", line 80, in main
ext.install_extension(options.install)
File "/usr/share/weewx/weecfg/extension.py", line 123, in install_extension
self.install_from_dir(extension_dir)
File "/usr/share/weewx/weecfg/extension.py", line 181, in install_from_dir
shutil.copy(source_path, destination_path)
File "/usr/lib/python3.8/shutil.py", line 415, in copy
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/usr/lib/python3.8/shutil.py", line 261, in copyfile
with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/weewx/user/weatherlink_live/init.py'

I'm able to reproduce your issue when my user account has insufficient access rights.
Please try to execute wee_extension with sudo or similar. I.e:
sudo wee_extension --install weewx-weatherlink-live-v1.0.5.tar.xz /etc/weewx/weewx
.conf

Sorry. You are right. I was not careful.

I'm glad I could help you.


Using absolute path in FLASK_APP can't run flask db init cli module error

when I specify absolute path like this D:\personal\prjs\cfblog2\cfblog2\app.py in FLASK_APP, run flask db init will raise a exception:
Traceback (most recent call last):
  File "c:\userprograms\python35\Lib\runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\userprograms\python35\Lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "D:\personal\local\cfblog2\lib\site-packages\flask\__main__.py", line 15, in <module>
    main(as_module=True)
  File "D:\personal\local\cfblog2\lib\site-packages\flask\cli.py", line 479, in main
    cli.main(args=args, prog_name=name)
  File "D:\personal\local\cfblog2\lib\site-packages\flask\cli.py", line 346, in main
    return AppGroup.main(self, *args, **kwargs)
  File "D:\personal\local\cfblog2\lib\site-packages\click\core.py", line 696, in main
    rv = self.invoke(ctx)
  File "D:\personal\local\cfblog2\lib\site-packages\click\core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "D:\personal\local\cfblog2\lib\site-packages\click\core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "D:\personal\local\cfblog2\lib\site-packages\click\core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "D:\personal\local\cfblog2\lib\site-packages\click\core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "D:\personal\local\cfblog2\lib\site-packages\click\decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "D:\personal\local\cfblog2\lib\site-packages\flask\cli.py", line 229, in decorator
    with __ctx.ensure_object(ScriptInfo).load_app().app_context():
  File "D:\personal\local\cfblog2\lib\site-packages\flask\cli.py", line 210, in load_app
    rv = locate_app(self.app_import_path)
  File "D:\personal\local\cfblog2\lib\site-packages\flask\cli.py", line 90, in locate_app
    __import__(module)
ImportError: No module named 'D'

It seems like function locate_app can't handle win-style path correctly.
And also please consider using command-line arguments to specify flask startup file/module instead of using environment.

@future0906 could you put together the smallest possible example that reproduces this error? i'll try to reproduce the issue on my windows system, but depending on your setup, maybe there are other sources for this error.

@wgwz sorry for false reported issuse.I double checked my settings.It turns out was my app.py file been move away.Still this exception message miss-lead me thought it's path/module split issue.
Anyway,thantks for testing this issue, I will close it.


Docs hyperlink on Rancher UI points to Archived docs

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Click on the Docs hyperlink on the global clusters page in 2.5-head rancher server
User is redirected to - https://rancher.com/docs/rancher/v2.x/en/

Expected Result:
This docs page is Archived, user should be redirected to 2.5 docs instead.
Other details that may be helpful:
This is seen on dashboard also.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5-head commit id: 118f9996
Installation option (single install/HA): single

on 2.5.8-rc7, the docs link point to https://rancher.com/docs/rancher/v2.5/en/


flyway - updated to 5.2.1 - MH

Updated to current latest version of flyway.
I did not update the notes in the nuget package. I am not sure if this is needed.

Thanks for your update. I merged the PR and pushed the choco package.


[Feature] Coin Transfer

This PR brings:

a new Transaction View
moves Onboard Account to a Modal dialog
enables Coin Transfer with input check and error handling
translates new feature to Portuguese
improves app UX

Before merging this PR, we need to merge that PR: https://github.com/OLSF/libra/pull/995 otherwise Carpe is cannot be built.

Before merging this PR, we need to merge that PR: OLSF/libra#995 otherwise Carpe is cannot be built.

It is done. Thanks.


ImageService is missing @type for IIIF2 services

The type hints for the ImageService type only have the type field specified, but as per the examples in the Presentation API 3 specification, IIIFv2 image services use @type instead. The field is completely missing from the ImageService2 type as well.
    {
      "@id": "https://example.org/iiif2/image1/identifier",
      "@type": "ImageService2",
      "profile": "http://iiif.io/api/image/2/level2.json"
    }

https://iiif.io/api/presentation/3.0/#service

Ah I guess that is a bug in the types. Although the ImageService2 type does confuse me a bit. I think I assumed that either it would match the 2.1 spec and be:
{
  "@context": "http://iiif.io/api/image/2/context.json",
  "@id": " ... ",
   "profile": "http://iiif.io/api/image/2/level2.json"
}

without a type, and a context instead.
Or perhaps:
{
  "id": "https://example.org/iiif2/image1/identifier",
  "type": "ImageService2",
  "profile": "http://iiif.io/api/image/2/level2.json"
}

PR: https://github.com/IIIF-Commons/presentation-3-types/pull/8 (possibly incomplete)

Closing for now


Use Black8 as default project formatter

It is good practice to use the same code prettier for the whole project,
It will be cool to configure it with some tool, that performs code formatting before each commit,
So for a developer - there is no need to remember about code style, just write as you like, and Black8 will do the thing

Indeed 👍


Feature Request: Quick cite workflow

Feature Requested
This is a great plugin for Alfred, thank you for your awesome work. 😇
I think it would be really helpful if we can make search-add-cite workflow more fluently: invoke Alfred, search some content in search bar on arXiv or Google scholar (this is for computer science, or user can custom sources), pick the article you want, and hit a enter key, boom, the bibtex of that article add to .bib file automatically (arXiv and Google scholar has open relative APIs), and you can then easily cite it with + in Alfred.
What I want to say is the data collect function of this plugin is a little weak, and it is very important for me to add bibtex and cite it to rush a paper, this process is time-consuming and painful for now, so I really want this plugin can solve it. 😊
Relevant Screenshot
No response
Checklist

[X] The feature would be useful to more users than just me.

This is a great plugin for Alfred, thank you for your awesome work. 😇
Thanks 🙏

What I want to say is the data collect function of this plugin is a little weak

well, this tool is a citation picker after all 🤣
What you are describing goes more into references adder like the Zotero Connector, which isn't really the goal of the project. It also would require a completely different code base to accomplish that, so I don't think I'm gonna implement this.
But since are doing Computer Science, you could probably build such a tool yourself? 😛


fix: permission builder exception

Update reactjs-components to resolve issue with permissions builder

Closes DCOS-48704

Testing

Create a user account
Open the permissions builder for the new user
Select Mesos -> Master -> Quota
Select both read & Update
Change Quota -> Executor
Verify modal doesn't crash

Trade-offs

Dependencies

Screenshots

:tada: This PR is included in version 2.109.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove weak attribute from function declarations

Weak attributes are attributes for functions; Not for function declarations.  We have __attribute__((weak)) in some header files and they must be removed.

This is not true.
If the functions are not declared as weak, it is impossible to test for their implementation like this
__attribute__((weak)) void csp_reboot_hook(void);

if (csp_reboot_hook) {
    csp_reboot_hook();
}

Removing the weak from the declaration produces this warning:
../lib/csp/src/csp_service_handler.c:300:37: error: the address of ‘csp_reboot_hook’ will always evaluate as ‘true’ [-Werror=address]
  300 |                                 if (csp_reboot_hook) {

What is the point of checking the function pointer?  We always supply the weak version of the function as default.  We use weak attribute so that user will override the default function we supply.  Otherwise, we don't even have to use weak attribute.  Have a function pointer and let user set it.

main.c
void csp_reboot_hook(void);
int main()
{
	csp_reboot_hook();
	return 0;
}

weak.c
#include <stdio.h>
__attribute__((weak)) void csp_reboot_hook(void)
{
	printf("weak\n");
}

strong.c
#include <stdio.h>
void csp_reboot_hook(void)
{
	printf("strong\n");
}

build
gcc -Wall -Wextra -g main.c weak.c && ./a.out
weak
gcc -Wall -Wextra -g main.c weak.c strong.c && ./a.out
strong

Okay, i see your point; That if we always provide a weak implementation and if people remember to use --link-whole then we do not need to check. One of the reasons the CI was crashing (segfaulting) was that i called a weak function (csp_print) when the program was linked with libcsp.a without --link-whole. Which waf does not support.
I have added default implementations to all hook functions. Even just empty ones. So we do not need to perform the check. We should keep an eye out for crashes now.


Implement "edit-plan"

Implement "edit-plan" command
Implement test cases

Moving this issue to V1.3


should report double space

DATA: ls_item    TYPE zif_abapgit_definitions=>ty_item.
double space is before "TYPE"

currently the double_space rule gives up if the statement is chained

nah


Make pageCursor publicly available in the Designer

Is your feature request related to a problem? Please describe.
When working with multiple pages it's impossible to tell which page we're currently on without inspecting the dom or writing your own page scroll observer making it unnecessarily difficult to use a schema for each page individually.
Describe the solution you'd like
The pageCursor property already exists, it would just be a matter of exposing it as a public property of the Designer class.
Describe alternatives you've considered
/
Additional context
I'd be happy to create a pr for this.

Hey @Letsmoe, Could you explain a bit more why we should add this feature?

If I'm not mistaken it's not currently possible to tell which page the user is on in the designer, right? That makes it practically impossible to put new fields into the correct schema objects and since there is no way to move fields between pages in the designer you basically cannot place objects on the pages following the first one. Is there maybe another way that I simply overlooked?
Otherwise having the current page available would be a major thing especially when creating new pages on the fly and auto-generating page numbers for them.

Thank you @Letsmoe ,
Does the following PR seem to solve your problem?
https://github.com/pdfme/pdfme/pull/445?

Yep, sure does!

Perfect!!!

This Request was handled by https://github.com/pdfme/pdfme/pull/446
We can use getPageCursor from<EMAIL_ADDRESS>


Uncaught TypeError: Cannot assign to read only property '__esModule' of object '#'

Hello Radix,
First of all thanks for this fantastic icon set.
I've set up a new Next.js 13 project along with the new app directory but whenever I try to import one Icon from the installed npm package I get the following error
error - TypeError: Cannot assign to read only property '__esModule' of object '#<Object>'
     at eval (webpack-internal:///(sc_server)/./node_modules/@radix-ui/react-icons/index.js:3:27)
     at<EMAIL_ADDRESS>([REDACTED])
     at __webpack_require__ ([REDACTED]/.next/server/webpack-runtime.js:33:42)
     at eval (webpack-internal:///(sc_server)/./components/ui/Icons/Icons.tsx:5:79)
     at Object.(sc_server)/./components/ui/Icons/Icons.tsx ([REDACTED]/.next/server/app/(auth)/login/page.js:708:1)
     at __webpack_require__ ([REDACTED]/.next/server/webpack-runtime.js:33:42)
     at eval (webpack-internal:///(sc_server)/./components/ui/Icons/index.tsx:5:64)
     at Object.(sc_server)/./components/ui/Icons/index.tsx ([REDACTED]/.next/server/app/(auth)/login/page.js:719:1)
     at __webpack_require__ ([REDACTED]/.next/server/webpack-runtime.js:33:42)
     at eval (webpack-internal:///(sc_server)/./app/(auth)/login/page.tsx:8:78) {
   type: 'TypeError',
   page: '/login'
}

Here is the small utility component that is referred to as thecomponents/ui/Icons/Icons.tsx
import {
    ExclamationTriangleIcon,
    Cross1Icon,
    UpdateIcon,
    ChevronLeftIcon,
    ChevronRightIcon,
    TrashIcon,
    FileIcon,
    FileTextIcon,
    ImageIcon,
    GearIcon,
    DotsVerticalIcon,
    PlusIcon,
    PersonIcon,
    ArrowRightIcon,
    QuestionMarkCircledIcon,
    GitHubLogoIcon,
    TwitterLogoIcon,
    CheckIcon
} from '@radix-ui/react-icons';
import type {IconProps} from '@radix-ui/react-icons/dist/types';

import Logo from '@/components/ui/Logo'

export type Icon = IconProps

const Icons = {
    logo: Logo,
    close: Cross1Icon,
    spinner: UpdateIcon,
    chevronLeft: ChevronLeftIcon,
    chevronRight: ChevronRightIcon,
    trash: TrashIcon,
    post: FileTextIcon,
    page: FileIcon,
    media: ImageIcon,
    settings: GearIcon,
    ellipsis: DotsVerticalIcon,
    add: PlusIcon,
    warning: ExclamationTriangleIcon,
    user: PersonIcon,
    arrowRight: ArrowRightIcon,
    help: QuestionMarkCircledIcon,
    gitHub: GitHubLogoIcon,
    twitter: TwitterLogoIcon,
    check: CheckIcon,
}

export default Icons;

Getting the same error. This is due to line 2 in index.js of the package:
module.exports = require('./dist/index.js');
module.exports.__esModule = true;

Is there a workaround to use in the meantime?

Is there a workaround to use in the meantime?

"Well... I went into the @radix-ui/react-icons folder inside node_modules and commented out the line containing module.exports.__esModule = true;. It worked for me."

Is there a workaround to use in the meantime?

Just got the same error. Overcome it by 'use client' directive in the component which uses icon.

Hey, sorry for the delay. Just released 1.2.0 with @shuding's fix, let me know if it works.

Confirm, this does work in 1.2.0


Remove DS button class on introduction page

What is the context of this PR?
Fixes an issue described on this card. Removes button class on introduction page after DS update so there are no spacing issues.
How to review
Test relevant schema, check spacing.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Padding on introduction start button (0.5 SP)


AIX: Testing fails because it cannot "make genParallelList"

Summary
All testing fails due to this error:
22:18:23  + cd ./aqa-tests/TKG
22:18:23  + make genParallelList TEST=sanity.openjdk TEST_TIME=120 NUM_MACHINES=
22:18:23  "makefile", line 19: make: Dependency line needs colon or double colon operator.
22:18:23  "makefile", line 20: make: Dependency line needs colon or double colon operator.
22:18:23  "makefile", line 21: make: Dependency line needs colon or double colon operator.

Details
This happens consistently but only recently, implying a syntactic intolerance of a new machine setup.
Next step
One solution is to implement the fix found here: https://github.com/adoptium/aqa-tests/issues/621
Will raise a PR.

Examples
https://ci.adoptium.net/job/Test_openjdk11_hs_sanity.openjdk_ppc64_aix/697/console
https://ci.adoptium.net/job/Test_openjdk21_hs_sanity.system_ppc64_aix/139/console
https://ci.adoptium.net/job/Test_openjdk24_hs_special.openjdk_ppc64_aix/7/

Thanks @adamfarley, can you add information about when this started failing so we can pinpoint the regression.

Sure thing Shelley.
Ok, I'm assuming that the change affected different hosts at different times, based on these jobs that happened on the 23rd of August:
test-osuosl-aix72-ppc64-1 - 10pm - Job Link - Result: PASSED.
test-osuosl-aix72-ppc64-4 - 11am - Job Link - Result: FAILED.
Most affected tests seem to be passing around the 15th-21st of August (example) and failing from the 23rd-28th of August example.

Tagging @Haroon-Khel as recommended in the recent Adoptium Community Call.
Haroon, Stewart suggested you may know something about the change that caused this?
May be related to a path change on the AIX machines.

The potential cause would be https://github.com/adoptium/infrastructure/pull/3716
Haroon posted on the 20th in the infrastructure slack channel which would have been when the change started to take effect.

Yeah the path change might have caused this, taking a look on the machines

@sxa to clarify, we want to use /opt/freeware/bin/make? At the moment with the new PATH variable, as a result of https://github.com/adoptium/infrastructure/pull/3716, it is using /usr/bin/make

It needs to be GNU make - /opt/freeware/bin/make should be GNU make so that would be the one to use. I'll be honest I thought we had that special cased most of those invocations fro AIX but maybe we haven't done all of them yet.

Do we ever need to use /usr/bin/make for anything? Because we can simply force /usr/bin/make to point to /opt/freeware/bin/make, instead of forcing the tests to use gmake in https://github.com/adoptium/aqa-tests/pull/5550

Current setup
root@adopt08:[/root]ls -la `which make`
lrwxrwxrwx    1 bin      bin              17 May 30 2023  /usr/bin/make -> /usr/ccs/bin/make
root@adopt08:[/root]ls -la `which gmake`
lrwxrwxrwx    1 root     system           27 May 30 2023  /usr/bin/gmake -> ../../opt/freeware/bin/make

Do we ever need to use /usr/bin/make for anything? Because we can simply force /usr/bin/make to point to /opt/freeware/bin/make, instead of forcing the tests to use gmake in #5550

We need to get away from changing default system behavior - that was part of why we made the change to the PATH - we don't want anything relying on the AIX system tools to see differences.
https://github.com/adoptium/infrastructure/pull/1979 is related to that topic too :-)

Then a solution could be to set the make path in the jenkins config for each machine

I've added a PATH variable to the jenkins config of https://ci.adoptium.net/computer/test-osuosl-aix72-ppc64-4/, on which the sanity system test failed to compile, https://github.com/adoptium/aqa-tests/issues/5542#issuecomment-2328860300
https://ci.adoptium.net/job/Test_openjdk21_hs_sanity.system_ppc64_aix/140/console
Looks like it finds the right make

I've updated the jenkins config of the machines that did not have that PATH variable to have it

I've updated the jenkins config of the machines that did not have that PATH variable to have it

Thanks Haroon. I still think it's a good idea to explicitly call gmake, so the user knows what we're expecting to run, but that's a "would be nice" rather than a "need".

I've updated the jenkins config of the machines that did not have that PATH variable to have it

👍🏻
The other option would be to have the AQA tests set the path (or call gmake explicitly) since that would make it "just work" outside jenkins.


Maybe add an autopurge?

Hello! I've been using your module and think that I need the cache to delete its contents from time to time, because 'dead' objects start to accrue in a long running process.
A tiny looping fibre that just runs purge_stale+sleep is all I needed to add.. but it would be cool if you had it builtin to the module, possibly turned on/off with a flag.
Alternatively you could clean out old values every 'x' calls to set/get, similar to a memory garbage collector.
Thoughts?

how's this?
.set_purge_interval(interval : Time::Span, stale_only : Bool = true)
Sets an interval where key/value pairs will automatically be purged.
Example:
cache_hash = CacheHash(String).new(1.minute)
cache_hash.set_purge_interval(10.minutes) # stale_only defaults to true

cache_hash = CacheHash(String).new(1.minute, stale_only: false)
cache_hash.set_purge_interval(10.minutes) # deletes all values, not just stale ones

PR https://github.com/samueleaton/cache-hash/pull/8

Ooo, that was fast! Yeah that seems cool.. Except maybe use a loop construct to do the looping, it would be a disaster if llvm didn't optimize the recursive call.
.. It might also be a good idea to make it something you can pass in to new(), but that's just my preference and I geuss it doesn't matter too much.

so you're saying something like this?
cache_hash = CacheHash(String).new(1.minute, purge_interval: 1.hour, purge_stale_only: true)

Sorry, just woke up.
That looks good -- I suggested it because autopurge is probably a highly desirable feature worth enabling at creation time. It also means I don't need to 'tweak' the object which feels less "side-effecty" (uhh highly technical functional programming term).

To be clear though, it's your library and you can design it however the heck you want. The current MR definitely works as-is


Update go to 1.18

Which problem is this PR solving?
Update go to latest version.
Short description of the changes

Updates go to v1.18 in both go.mod and circle CI image used to build binaries

CircleCI has released their go 1.18.1 image (1.18 also resolves to the same image tag).


Bah 2962 | Added token auth for api hit from backend

Added token auth for api hit from backend

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: atish3101:x: anubhavBeehyvYou have signed the CLA already but the status is still pending? Let us recheck it.

Moved the changes to new PR


[build]: ci against version 3.10

closes #11.

@sndoja thank you for your contribution! :christmas_tree:


Remove JoinConversation call

When an incident is opened we call the slack-go.JoinConversation, but this is no longer necessary.
Cleanup
What should be cleaned up or changed:
Remove JoinConversation call on open_incident command (internal/commands/open.go)
Provide any links for context:

Can I do this one?


Added bar width getters to macd renderer and bar series

#881
This addresses bar series and macd.
I'd be happy to add this to other stuff if you think this is the right approach.

I'm happy with the general idea behind this PR, unification of the series interfaces makes sense, but the way that it is being proposed for bar looks a bit risky


Add comment to Jira issue when slug provided in opslog entry

It would be really handy if Imbi could add a comment to the Jira issue identified by the slug provided when creating/updating an opslog entry, so that folks reviewing the ticket can easily find related maintenance/operational tasks.

I've thought about that particular feature a few times now. It would be super handy. I would implement this as a "create-opslog" automation and a jira integration. I described what this currently looks like in the the description of https://github.com/AWeber-Imbi/imbi-api/pull/65 and https://github.com/AWeber-Imbi/imbi-schema/pull/19.
We would add a new automation type in imbi/automations/models.py and the schema. I don't like the way that automation types work today since they are tightly coupled between the UI, API, and DB ☹  ... definitely room for improvement here
As for the integration, we would have to look into the Jira API and figure out how to get user-bound tokens working similar to what @in-op did with Google+AWS. I would prefer user-bound authentication instead of an API key even if the API supports it.


Question about answer+"#"

Hi, Thank you for sharing the wonderful work in the medical field. I have one question.
In QCR_PubMEDCLIP.lib.utils.create_label.py <line 200>
What is the reason for adding the "#" string to the answer file in an open answer? (for Slake dataset)
for answer in open_answers:         if answer in ans2label:             ans = answer + "#"

So there are overlaps between the answers in open and close end types. E.g., lung is used as answer both for open-end questions (like what is the organ in the image?) and for closed-end questions (like which organ in the image is bigger, lung or heart?). This # was my initial attempt to separate these two cases.

Thank you for your quick response. So, during training with the cross-entropy loss, the ground truth is the one-hot vector including the ans + "#"? For example, the candidate answer list has 4 answers: lung, lung#, MRI, MRI#. If the ground truth is MRI from open-end (MRI#), the one-hot vector will be [0, 0, 0, 1]. Is this correct? If so, will this hurt the performance of the model because the model can also answer MRI? (MRI# and MRI are the same in semantics).

Hello, I have another question about this issue.
In your code, it handles open and close answers differently, but MEVF github [github] doesn't seem to differentiate them.
Is it correct that the preprocessing to run the MEVF code should be done in the same way as the QCR model?