Cannot get Axios or Fetch to work in Clasp Upload

Hi Labnol,
thanks for the awesome work. I have setup the project as described in your youtube video and the setup works fine.
Now I want to work with Rest APIs and be able to work with the output both in Node.js as well as in the Google Sheets Addon I am building.
In order to do this, I am using Quokka.js + Node within VS Code for prototyping.
Given the following premises:

Node doesn't support UrlFetchApp.fetch
GAS doesn't support native fetch (due to lack of the window and dom objects)

I decided to test out Fetch Polyfills (like cross-fetch) and axios + use babel-polyfill to handle promises, in order to allow the prototyping in node yet also get the same outcome in the browser.
Within node, everything works as expected, however once I add
const axios = require('axios'); to any .js file in my project I receive the following error when trying to push the code via Clasp.
  code: 400,   errors:    [ { message:         'Syntax error: Missing name after . operator. line: ....,        domain: 'global',        reason: 'badRequest' } ] }
On the given line throwing the error it states module.exports.default = axios;
Once I comment out this line, the Clasp push works, but axios isn't working in the GAS environment.
Any ideas would be greatly appreciated!
Best regards
Mattis

This error likely happens when the npm library uses a dot before the default key.
Replace variable.default with variable["default"] and the error should be fixed.


phantomjs renamed to phantomjs-prebuilt

Following npm warning was reported while executing npm install.
npm WARN deprecated<EMAIL_ADDRESS>Package renamed to phantomjs-prebuilt. Please update 'phantomjs' package references to 'phantomjs-prebuilt'

Is it necessary/needed to update the package.json?

We do not use PhantomJS any more. Ref: https://github.com/mermaidjs/mermaid.cli


why is 160160? not 224224?

hi, @davidsandberg,
You really did a great job. And I have learned much from you. I am a little confused about the input size of the  inception-v1-resnet.   It should be 224224, why is 160160 in your code. have you changed the architecture of inception-v1-resnet?

I don't think it really matters that much what size of the image we start with. As long as we follow the architecture of the net, performance should be similar

@vudung45 ,
ok, got it, thank you for your answer. as far as i know. the inception-resnet-v1 architecture in this project is not exactly same as in other projects.  So inception-resnet-v1 is just the idea, not the architecture? as far as i know, v1 has the conv 5*5, but i can not find it in this project.

I checked the paper that describes the (inception-resnet-v1 architecture](https://arxiv.org/pdf/1602.07261.pdf) but I see no mentioning of any 5x5 covolutions.

Closing this for now. Reopen if needed.


Subscriptions fail when owner claim uses custom attributes

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
16.14.2
Amplify CLI Version
8.0.2
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Added a custom attribute to cognito group.
Amplify Categories
auth
Amplify Commands
push
Describe the bug
#10199 introduces const roleClaims = role.claim!.split(':'); in packages/amplify-graphql-auth-transformer/src/resolvers/subscriptions.ts
This breaks using custom attributes for owners, as custom attributes are prefixed with custom:
Possible solutions would be:

Revert #10199
Do not split the role claim, if it starts with custom:

Expected behavior
The generated auth template should look like
## [Start] Authorization Steps. **
$util.qr($ctx.stash.put("hasAuth", true))
#set( $isAuthorized = false )
#if( $util.authType() == "User Pool Authorization" )
  #if( !$isAuthorized )
    #set( $ownerEntity0 = $util.defaultIfNull($ctx.args.owner, null) )
    #set( $ownerClaim0 = $util.defaultIfNull($ctx.identity.claims.get("custom:tenant"), "___xamznone____") )
    #if( $ownerEntity0 == $ownerClaim0 )
      #set( $isAuthorized = true )
    #end
  #end
#end
#if( !$isAuthorized )
$util.unauthorized()
#end
$util.toJson({"version":"2018-05-29","payload":{}})
## [End] Authorization Steps. **

but it currently looks like
## [Start] Authorization Steps. **
$util.qr($ctx.stash.put("hasAuth", true))
#set( $isAuthorized = false )
#if( $util.authType() == "User Pool Authorization" )
  #set( $ownerEntity0 = $util.defaultIfNull($ctx.args.owner.split(":")[0], null) )
  #if( !$isAuthorized )
    #set( $ownerClaim0_0 = $util.defaultIfNull($ctx.identity.claims.get("custom"), "___xamznone____") )
    #if( $ownerEntity0 == $ownerClaim0_0 )
      #set( $isAuthorized = true )
    #end
  #end
  #if( !$isAuthorized )
    #set( $ownerClaim0_1 = $util.defaultIfNull($ctx.identity.claims.get("tenant"), "___xamznone____") )
    #if( $ownerEntity0 == $ownerClaim0_1 )
      #set( $isAuthorized = true )
    #end
  #end
#end
#if( !$isAuthorized )
$util.unauthorized()
#end
$util.toJson({"version":"2018-05-29","payload":{}})
## [End] Authorization Steps. **

Reproduction steps

Create an amplify project
Add auth to amplify
Add a custom attribute to cognito group
Add a graphql API
Add owner auth with an identity claim using the custom attribute

GraphQL schema(s)

type Productl
  @model
  @auth(
    rules: [
      {
        allow: owner
        identityClaim: "custom:tenant"
        operations: [create, update, read, delete]
      }
    ]
  ) {
  owner: ID @index(name: "byOwner", sortKeyFields: ["id"])
  id: ID!
  name: String!
}

Log output

# Put your logs below this line

Additional information
No response

Hello @MatthiasF999, Thank you for informing us on this. marking this as bug.


how to train BertForMaskedLM model with custom corpus?

Hi ,
i have custom data set with 50k sentences ,how to train BertForMaskedLM model with this custom corpus for masked word prediction?There are no documentation for training BertForMaskedLM  model.

@ajbot2019  did you find a way to do it?


Model not traced in the cpp example project

🐛 Describe the bug
When you follow the instructions for building and running the c++ hello_world example project, you will get the message error loading the model printed to the console.
This is because trace_model.py is never called, so the model file resnet18.pt is never created and also never copied over to the build folder where the compiled binary expects it to be.
Versions
PyTorch version: 2.0.1+cu117
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 14.0.0-1ubuntu1.1
CMake version: version 3.22.1
Libc version: glibc-2.35
Python version: 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-6.2.0-32-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 11.5.119
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA RTX A2000 8GB Laptop GPU
Nvidia driver version: 525.125.06
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.4
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      46 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             24
On-line CPU(s) list:                0-23
Vendor ID:                          GenuineIntel
Model name:                         12th Gen Intel(R) Core(TM) i9-12950HX
CPU family:                         6
Model:                              151
Thread(s) per core:                 2
Core(s) per socket:                 16
Socket(s):                          1
Stepping:                           2
CPU max MHz:                        5000.0000
CPU min MHz:                        800.0000
BogoMIPS:                           4992.00
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb intel_pt sha_ni xsaveopt xsavec xgetbv1 xsaves split_lock_detect avx_vnni dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req hfi umip pku ospke waitpkg gfni vaes vpclmulqdq tme rdpid movdiri movdir64b fsrm md_clear serialize pconfig arch_lbr ibt flush_l1d arch_capabilities
Virtualization:                     VT-x
L1d cache:                          640 KiB (16 instances)
L1i cache:                          768 KiB (16 instances)
L2 cache:                           14 MiB (10 instances)
L3 cache:                           30 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-23
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Versions of relevant libraries:
[pip3] numpy==1.25.1
[pip3] pytorchvideo==0.1.5
[pip3] torch==2.0.1
[pip3] torchvideo==0.0.0
[pip3] torchvision==0.15.2
[pip3] triton==2.0.0
[conda] Could not collect

Thanks for the report @abstractionmage! In our CI job we do
https://github.com/pytorch/vision/blob/0b41ff0b0a08229a10cfe1ca6987b4386d68bd9c/.github/scripts/cmake.sh#L55-L59
and
https://github.com/pytorch/vision/blob/0b41ff0b0a08229a10cfe1ca6987b4386d68bd9c/.github/scripts/cmake.sh#L107-L123
We accept a PR fixing the README to include the tracing step.


Move support from Gitter to Discourse

https://discourse.drone.io/
We are moving support from Gitter to Discourse. The reasons for this change are largely summarized in this blog post. Note that I will be deleting the following rooms:

https://gitter.im/drone/drone
https://gitter.im/drone/drone-dev

I was slowly learning golang and wanted to get involved in drone a bit more to contribute.
With the chat going away, I loose the ability to ask stupid questions to the developers about obvious things ( that are not so much for a golang beginner ).
I'm now unsure where I should ask those kind of questions/discuss implementation, share pull requests, (which are not support related), and feel like I won't get the chance to build a correct relation with the devs team.
This is a good move for getting support requests async and keep the history.
This is a bad move to attract any kind of developers or contributors to drone since they'll get lost in the support sea.
Please at least keep a open dev channel at least !
Those were my 2cents :)

I personally feel this is a bad decision. I don't think the reasons stated in the blogpost have much grounds for removing live chat entirely. As an open-source project, I think having a live chat channel, like on Freenode #drone-ci would prove to be an easier way of getting fast responses.
Hell, why is it even needed for us to choose? There's nothing saying we can't use both. Live for easy questions like how to install it and Async for harder ones like compiling from source.

We have a section dedicated to development questions so that they do not get lost in the sea of support requests. https://discourse.drone.io/c/development

I think having a live chat channel, like on Freenode #drone-ci would prove to be an easier way of getting fast responses.

I fully encourage the community to create an IRC channel

@bradrydzewski I've done so on Freenode, #drone-ci, would help if you supported my decision as well ^_^

I have created on Gitter drone-plugins/Lobby, but it's dedicated to plugin development, I won't accept any kind of support request! It's really only to discuss development details and I'm pretty sure brad won't join these conversation.

I am happy to promote the IRC channel in our official developer documentation, but I will be unable to participate in live chat support.
Please try to understand what it is like having a chatroom with thousands of people messaging you at all hours of the day and night because people are in every timezone. I am constantly getting messages and alerts on my phone. I am constantly re-answering the same questions over and over. The chatroom is a major source of burnout. It has prevented me from having any level of work life balance and impacted my personal health.
Because this is a matter of personal health, and a personal decision, I ask you to please respect my decision even if you disagree.

/thread? I don't think any further discussion in here will be constructive.


[PENDING] Windows binary

Dear David,
Could you be so kind to generate .exe for the rest of us who are mere Windows users w/o compiler?

Err… Hello?


'No Service Found' item has context menu of regular Service item

There should be no context menu available for 'No Service Item'

this has been fixed for a while, closing


Add liquidity option Token stuck

What happened?
Adding liquidity option token causes browser warning:
Property undefined was accessed during render but is not defined on instance.
The warning loops infinitely until the browser crashes。
justify-content: flex-end;
At the same time, some places use justify-content: end;
This will bring a warning, it is recommended to modify to flex-end
How can we reproduce it?
Mac platform or mobile device,
chrome or firefox browser,
dex-ui latest version,
click pool,
add token
mobile
Both
What browsers are you seeing the problem on?
Firefox, Chrome, Safari
Anything else you want us to know?
No response

@Lfh2msn could you please provide more details?
I can't get any of those issues described above

@Lfh2msn any update? Otherwise we close this ticket :)


Update to v2.7.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@millsks, as promised in https://github.com/conda-forge/airflow-feedstock/issues/115#issuecomment-1684384266, I'm going to explain my process and you can decide if you want to become a maintainer.
A long time ago, I forked this repo.  I have a location on my laptop where I have both the main airflow-feedstock repo and my fork available as remotes.
In this location, I first created a branch for 2.7.0 off of main.  That was the starting point for this branch.
In another location, I downloaded and untarred the source from GitHub for both the current and the previous versions of Airflow:
wget https://github.com/apache/airflow/archive/refs/tags/2.7.0.tar.gz
wget https://github.com/apache/airflow/archive/refs/tags/2.6.3.tar.gz
tar xvf 2.7.0.tar.gz
tar xvf 2.6.3.tar.gz

(Normally, I would just look at the changes directly on GitHub but in this case there are ~1,500 files changed so that isn't practical).
I got the sha256 hash with:
sha256sum 2.7.0.tar.gz

The changes to the main package's dependencies are in setup.cfg, so I did:
diff airflow-2.6.3/setup.cfg airflow-2.7.0/setup.cfg

The relevant changes are:
39d38
<     Programming Language :: Python :: 3.7
58c57
< python_requires = ~=3.7
---
> python_requires = ~=3.8
76d74
<     cached_property>=1.5.0;python_version<="3.7"
98c96
<     flask-appbuilder==4.3.1
---
>     flask-appbuilder==4.3.3
114c112
<     jsonschema>=4.0.0
---
>     jsonschema>=4.18.0
122a121,123
>     # Pip can not find a version that satisfies constraints if opentelemetry-api is not pinned.
>     opentelemetry-api==1.15.0
>     opentelemetry-exporter-otlp
124c125
<     pathspec~=0.9.0
---
>     pathspec>=0.9.0
128,129c129,131

I can see that Airflow has dropped python 3.7 support, but this isn't relevant to us because conda-forge dropped 3.7 support a long time ago.  I made the other changes corresponding to the dependencies in recipe/meta.yaml in my 2.7.0 branch.
The next part is to handle the "extras" that are not providers.  These are the airflow-with-* packages produced here.  The dependencies for these are in setup.py:
diff airflow-2.6.3/setup.py airflow-2.7.0/setup.py

It's pretty easy to pick out the parts that relate to dependency changes.  Here are what I noticed:
268,270c299,301
<     # Click 8.1.4 breaks our mypy checks. The upper limit can be lifted when the
<     # https://github.com/apache/airflow/issues/32412 issue is resolved
<     "click>=8.0,<8.1.4",
---
>     # click 8.1.4 and 8.1.5 generate mypy errors due to typing issue in the upstream package:
>     # https://github.com/pallets/click/issues/2558
>     "click>=8.0,!=8.1.4,!=8.1.5",
276,278d306
<     # Without this, Sphinx goes in to a _very_ large backtrack on Python 3.7,
<     # even though Sphinx 4.4.0 has this but with python_version<3.10.
<     'importlib-metadata>=4.4; python_version < "3.8"',
296c324
<     "flask-appbuilder[oauth]==4.3.1",
---
>     "flask-appbuilder[oauth]==4.3.3",
320c348
< otel = ["opentelemetry-api==1.15.0", "opentelemetry-exporter-otlp", "opentelemetry-exporter-prometheus"]
---
> otel = ["opentelemetry-exporter-prometheus"]
352c380
<     "mypy==1.0.0",
---
>     "mypy==1.2.0",
376d403
<     "asynctest~=0.13",
401a429
>     "pytest-mock",

Some of these relate to providers, others to documentation and others to testing.  We don't need any of those.  But I searched for the packages listed here and any that are in an airflow-with-* output I updated following these diffs.  In this case, it was just the flask-appbuilder changes that are relevant.
This seems like a pretty easy update.  Sometimes, there are new dependencies that aren't on conda-forge and we need to add them.  Sometimes, new versions of dependencies required by airflow (or its providers) are not available and we need to help maintain the dependencies, too.
Then, I made this PR.  Following the instructions in the checklist, I rerendered.
When the testing failed, I found out that the licenses needed to be updated.  I put in the new list of licenses in the licenses directory in the source code.
Fingers crossed that things work now...


Log file creation not working because of file permissions

The process is started as the tatooine user, inside the user's home directory. Not sure why the app doesn't have permissions to create the file.

Fixed.


Added Example + Demo converted to Null Safety

Added example to understand more
Null safety added to example

Thank you so much :) Hope PR will be merged soon.

LGTM


PHOENIX-7056 Update the LAST_DDL_TIMESTAMP of the parent table/view when we add/drop an index.

@tkhurana @palashc  Can you please help review the patch?

@palashc  The patch is ready to review now.

Will wait for jenkins build before merging.


Add auto update support

Currently there is some code in place to manage auto updating, but it's mostly a noop.
We should look into picking an auto update system and integrate into the desktop app.
The most promising approach is to use the "simplified auto updater" of electron-builder (instead of Squirrel): https://www.electron.build/auto-update.
The pro of this approach is that we don't need to run a Squirrel server and can host the updates on github directly (making it also a bit more censorship resistant).

This is done.


Load nested SASS with alias throws error

Describe the bug
When vite load a nested sass (not scss) file with an alias, if the file has @import sass compiler will throw an error. However, it works when not using an alias.
Same for load a sass with @import from node modules.
And this doesn't apply to SCSS.
Reproduction
https://github.com/axe-me/vite-sass-alias-bug
System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: macOS 11.2.2
    Memory: 95.30 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.7.0/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v14.16.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 89.0.4389.90
    Firefox: 79.0
    Safari: 14.0.3
  npmPackages:
    vite: ^2.1.2 => 2.1.2

Used package manager: pnpm

I checked the reason, sass needs to be converted to scss when generating contents. I tried to convert sass to scss, and it works. But this process is more complicated, so I wonder if there is a better way to deal with this problem
https://github.com/vitejs/vite/blob/b4bbc675b2a45c12dec76f8295acd0506d95cb69/packages/vite/src/node/plugins/css.ts#L978-L990


removing margins from top and bottom

I removed the margin at the top and bottom.
This will close #78

It should be good now so far I can see @fmalcher can you verify this?

LGTM, thank you @Jefiozie !


Add "device orientation" extension

Proposed Changes
Add extension for detecting the device orientation (gyroscope, compass, accelerometer). This could be done with DeviceMotionEvent and DeviceOrientationEvent API.
Reason for Changes
This would be useful if the project needs better support for phones. For example, instead of using a keyboard to move/rotate/control things on the computer, you could use phone orientation to do this. In combination with #2012, this would allow better support for mobile projects.
This was already requested here.

Hi @filips123, can I work on this feature?
Back in 2014, I created my first game with a project same like this, but it was by Microsoft. So, recently, I started exploring my old game, which lead me to Google/Blockly and ultimately here.
Upon, linking on here I remember I even explored it in my college days.
I would be happy to contribute to projects like these, which are similar to what bought me the very first happiness of creating something from code.

Sure, but maybe first ask maintainers of this repository if they would actually want this feature...


Differentiate between creating and updating users

POST

Create user
Validate username (if username already exists, return error)

PUT

Update user
Validate user (if username does not exist, return error)

Not needed right now.


Stable

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[ ] No, this is not a breaking change.

@qinliwei123 - please take a look at https://github.com/flutter/flutter/wiki/Release-process, which describes how we promote changes to stable.
This change is not suitable for stable, or for master at this point. It may help if you filed an issue describing what you're hoping to achieve, although it seems like you may want to mark desktop as not experimental on stable, which is not quite ready.
I'm going to close this as it's currently not mergeable, and would likely not be accepted even if fixed up.  But please feel free to open an issue to discuss.


LFS-250 / LFS-284: Vocabulary term suggestions ignore the current vocabulary / Vocabulary widgets should use locally installed vocabularies

LFS-250 Jira link / LFS-284 Jira link
To test: Create a new Demographics form. The vocabulary used will now rely on the locally installed versions, which means that e.g. the Co-morbidities question will not work by default. To get them to work, install the Human Phenotypes Ontology from the Vocabularies admin section on the left. Similarly, the Chemotherapy Agent question in Chemotherapy will require the CHEBI vocabulary to be installed.
Note that none of the vocabulary questions will work by default anymore.

Works well.
I would like to be able to select Incomitant strabismus from the Related terms

I would like to be able to select Incomitant strabismus from the Related terms

Please create a task @sashaandjic . Thanks!

When using CHEBI there is a delay displaying info box as well as related term box.

It would be nice to have a focus back at the new line after selecting a vocabulaty term. This behaviour is already present for multi value entries without lookup.

Upon successful selection of HPO term Melasma, the Melasma tooltip gets displayed on the blank line below the term

Upon successful selection of HPO term Melasma, the Melasma suggestion gets displayed on the blank line below the term even though I haven't typed anything.

@OrdiNeu I think this may be triggered by commit c28c94c0ba2a5d, can you look into it?

If HP isn't indexed first, the error is a bit uninformative and unintuitive:

@sdumitriu LFS-347, we discussed it and decided it was out of scope.

Problem found: the vocabulary entries do not get saved . See the blank "Co-morbidities..."  for http://<IP_ADDRESS>:8080/content.html/Forms/c9bd1247-a287-481c-9c1c-fbec1df740d1

Problem found: the vocabulary entries do not get saved . See the blank "Co-morbidities..." for http://<IP_ADDRESS>:8080/content.html/Forms/c9bd1247-a287-481c-9c1c-fbec1df740d1
@sashaandjic I just fixed it in commit 4b13619.


Inconsistent naming...

Given the code:
public var nearestHourQuarter: Date {

...
public var nearestHalfHour: Date {
Shouldn't the first function be named "nearestQuarterHour", to match nearestHalfHour? Truthfully, when I was reading the code, I thought the function was named incorrectly even before I got to the second function. It just seems like it would be better to be consistent.

@rpural I agree with you!
Will be updated in the next release

Fixed in #54


style(locale): Translate to French Batch 2

A second batch of translation for French locale.
The translation should be roughly 2/3 to completion.
Bellow is a non exhaustive list of changes.
Diff.SyntaxHighlight
RevealFile
Revert
Reword
Running
Save
Stash
URL
UpdateSubmodules
Warn
WorkingCopy
Worktree
Some extra sentences
Include small fixes for
CodeEditor : missing accent
Include a fix mentioned in the previous PR #405 but not merged. (non -> nom for name in a string)

Good evening.
Can I use the occasion to ask a question.
In the confirmation dialog to drop a stash, I see a "On" term I cannot understand where it comes from.

There are 2 strings that contain such text but they are both followed by a colon (:) and changing them did not help.
I should translate this to "sur"
The code seems to be located in Views/DropStash.axaml but I can't find where the "On" comes from.
      <StackPanel Grid.Column="1" Orientation="Horizontal">
        <Path Width="12" Height="12" Margin="0,0,8,0"
              HorizontalAlignment="Left" VerticalAlignment="Center"
              Data="{StaticResource Icons.Stashes}"/>

        <TextBlock VerticalAlignment="Center" Classes="primary" Text="{Binding Stash.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}" Foreground="DarkOrange"/>
        <TextBlock VerticalAlignment="Center" Text="{Binding Stash.Message}" Margin="8,0,0,0"/>
      </StackPanel>

I suggest you work with the authors of PR #424 to merge the changes into a final PR.

Good evening.
Can I use the occasion to ask a question?
In the confirmation dialog to drop a stash, I see a "On" term I cannot understand where it comes from.

There are 2 strings that contain such text but they are both followed by a colon (:) and changing them did not help.
I should translate this to "sur"
The code seems to be located in Views/DropStash.axaml but I can't find where the "On" comes from.
      <StackPanel Grid.Column="1" Orientation="Horizontal">
        <Path Width="12" Height="12" Margin="0,0,8,0"
              HorizontalAlignment="Left" VerticalAlignment="Center"
              Data="{StaticResource Icons.Stashes}"/>

        <TextBlock VerticalAlignment="Center" Classes="primary" Text="{Binding Stash.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}" Foreground="DarkOrange"/>
        <TextBlock VerticalAlignment="Center" Text="{Binding Stash.Message}" Margin="8,0,0,0"/>
      </StackPanel>

It's the stash message and added by git automatically. You can see:

OK Thanks.
So this can't be helped.

I suggest you work with the authors of PR #424 to merge the changes into a final PR.

I saw that. And at first I thought the same. However after a second thought I think we can merge my changes (delta any potential thing to fix) 1st and then go for the improvement batch.
I did comment about it in the other PR too.
I will review the lines submitted there and halt progress with the remaining 3rd of translations.


Visual Studio Professional 2015

When using this extension on Visual Studio Professional 2015.  On Existing and new Projects.
I, and a few work colleagues receive multiple errors when clicking the yellow Bulb.
After enabling them, the same error occurs.
Screenshot attached.

@davebeaumont What VS 2015 version are you using? RTM? If it is RTM it will not work and raise all types of errors. We will release a version compatible with RTM today. AFAIK these analyzers are not raising errors, I need an specific solution where the problem is raised for each, if you can help us pinpoint the problem.

@giggio Thanks for your help and such a quick reply, I can confirm this is RTM.  I will try again after the next release.  Thanks again.

Ok, I will close the issue. If you find the problem on the next version let us know.

@davebeaumont Nugets and Extensions have been updated to work with RTM. Current version is 1.0.0-rc1. Please try it out and let us know if you find any problem.

This is now working well after updating, however I have noticed one small issue this morning that is generating the same error as in the above screenshot.
Code example is:
   static void Main()
    {
        Application.EnableVisualStyles();
        Application.SetCompatibleTextRenderingDefault(false);
        Application.Run(new Form1()); --This Line States Form1 should be disposed
    }

Once clicking the lightbulb I get:

Bug confirmed.

To repro:
Method(new MemoryStream());

The disposable problem is being tracked on #432.


Missing module chalk

$ ember fastboot
version: 0.2.0-beta.1
Built project successfully. Stored in "dist".
Cannot find module 'chalk'
Error: Cannot find module 'chalk'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/brandon/code/myapp/node_modules/ember-cli-fastboot/lib/models/server.js:2:13)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)

Nothing in there except a completely bare ember app, I followed the directions as per the README.

@brandonparsons Really sorry about that, I was doing some last-minute hacking at EmberConf and inadvertently put some dependencies in devDependencies instead. This should be fixed in 0.0.4, let me know if you're still having issues! Sorry again.

Haha no problem :) Just wanted to play around with it!


Build: add type check using typescript --checkJs

This errors are found by typescript's --checkJs feature. It pull types from jsdoc and typecheck. It is great. CI can be setup by running tsc.

Let's add an npm run-script for that, then, and a separate travis.yml job that does it, and the appropriate dev deps.

It might make sense to add eslint-plugin-jsdoc. The errors it catches includes: 1. Missing or superfluous jsdoc param. 2. Unmatched Jsdoc param name and actual name. 3. Enforce presence of types annotation.

I don't know why it this is closed. Maybe I did something wrong with force push. Apologies.

Thanks for the thorough review!


Error in make compile: modules/feature/version-control/config.el

Using master:

In toplevel form:
modules/feature/version-control/config.el:3:1:Error: featurep! was used incorrectly (doom--module wasn’t unset)
Failed to compile modules/feature/version-control/config.el

Similar error when enabling haskell:

In toplevel form:
modules/lang/haskell/config.el:35:1:Error: featurep! was used incorrectly (doom--module wasn’t unset)
Failed to compile modules/lang/haskell/config.el

My bad, this was fixed in https://github.com/hlissner/doom-emacs/commit/42e7f56a1fb6fb9b0dc455e02ba0bc7f1bbac1a9 (in develop), and develop is far overdue for a merge. It'll happen this weekend.


Add option to exchange clippy with my own custom avatar image.

Add option to exchange clippy with my own custom avatar image.

Not planned


Carthage Binaries

Would it be possible to add binaries to your releases? This would speed up our build time. Thanks!

Great idea!
Submit a pull request with them added :-)
I will work on it when I get a chance if I don't see anything come through, no guarantees on timing though


fix(client): Update tests with new traverser apis

Purpose of the PR

related PR #542

Main Changes
Updata api tests with new traverser structure

Verifying these changes

[ ] Trivial rework / code cleanup without any test coverage. (No Need)
[ ] Already covered by existing tests, such as (please modify tests here).
[ ] Need tests and can be verified as follows:

xxx

Does this PR potentially affect the following parts?

[ ]  Nope
[ ]  Dependencies (add/update license info)
[ ]  Modify configurations
[ ]  The public API
[x]  Other affects (typed here)

Documentation Status

[ ]  Doc - TODO
[ ]  Doc - Done
[x]  Doc - No Need

ci error
2023-12-09T14:30:28.1358860Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)
2023-12-09T14:30:28.1359093Z Caused by: com.fasterxml.jackson.core.JsonParseException:
2023-12-09T14:30:28.1359682Z Unexpected character ('#' (code 35)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
2023-12-09T14:30:28.1359848Z  at [Source: (StringReader); line: 1, column: 2]
2023-12-09T14:30:28.1360258Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)

ci error
2023-12-09T14:30:28.1358860Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)
2023-12-09T14:30:28.1359093Z Caused by: com.fasterxml.jackson.core.JsonParseException:
2023-12-09T14:30:28.1359682Z Unexpected character ('#' (code 35)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
2023-12-09T14:30:28.1359848Z  at [Source: (StringReader); line: 1, column: 2]
2023-12-09T14:30:28.1360258Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)

due to changes in MetricsAPI.java
cc @imbajin


undefined is not a function (evaluating '(0, _reactNativeImagePicker2.default)')

Description
Error react-native-image-picker. Library is es5 my script is es6

My library edit.

Additional Information

React version: 16.0.0-alpha.12
React Native version: 0.51.0
Platform: Android
Development Operating System: Linux
Dev tools: Android SDK 24

same on iOS, project rebuild doesn't help

@Nullable
  @Override
  public List<ReactPackage> createAdditionalReactPackages() {
    return Arrays.asList(
      .........
      new ImagePickerPackage()   // <-- add this to your application class people!
    );
  }


x64 MSI for x64 Rust

Prevents installing x64 MSI to i686 systems and allows to install both i686 and x64 MSIs to x64 systems

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)

LGTM

Thanks!


Docker buildx bake - The Sequel

2 distros: bullseye and alpine 3.17
Main Dockerfile + distro specific builder dockerfiles
Bake definition file which can be extended to more PHP versions and distros
.dockerignore file updated
Simple buildx bake GHA workflow (no push enabled, just showing) See run: https://github.com/back-2-95/frankenphp/actions/runs/3917789332/jobs/6697797558
Supersedes https://github.com/dunglas/frankenphp/pull/64

TODO / TBD

Add Docker Hub log into GHA workflow and enable push
Builder dockerfiles can be also combines into one multistage dockerfile

Notes

Uses named build contexts introduced in buildx 0.8.0 - No more ARGS

Testing
Show what is about to go down:
docker buildx bake -f docker-bake.hcl --print

Build all images locally for arm64 arch (with --load and --set "*.platform=linux/arm64" flags):
docker buildx bake -f docker-bake.hcl --pull --load --set "*.platform=linux/arm64"

Same as previous but build only 1 target from docker-bake.hcl:
docker buildx bake -f docker-bake.hcl --pull --load --set "*.platform=linux/arm64" bullseye

Build locally and override image name:
IMAGE_NAME=my/frankenphp docker buildx bake -f docker-bake.hcl --pull --load --set "*.platform=linux/arm64" --progress plain

Build and push all images with override image name (needs you logged in to Docker Hub or some other registry):
IMAGE_NAME=my/frankenphp docker buildx bake -f docker-bake.hcl --pull --push

I rebased your branch and fixed and issue with the Dockerfile versions.


Schema preload_order cannot be overriden by passing ordered query

Elixir version
Elixir 1.17.3 (compiled with Erlang/OTP 27)
Database and Version
PostgreSQL 17.0
Ecto Versions
ecto 3.12.4
Database Adapter and Versions (postgrex, myxql, etc)
postgrex 0.19.2
Current behavior
# in Blog.Comment schema
   ...
   field(:likes, :integer)

# in Blog.Post schema
  ...
  has_many(:comments, Comment, preload_order: [asc: :likes])

# in Blog context
  query = from(p in Post, preload: [comments: ^from(c in Comment, order_by: [desc: :likes])])
  Repo.all(query)

# => results ordered by ascending likes
  comments: [%Comment{likes: 1, ...}, %Comment{likes: 42, ...}]

Expected behavior
I would have expected the order_by from the preload query (^from(c in Comment, order_by: [desc: :likes])]) to take precedence over the schema ordering preload_order: [asc: :likes].
If however, it is not a bug but an expected feature, would it be possible to achieve this in some other way?

setting some default ordering in the schema, which works most of the times
in some specific function, we need a different ordering overriding the default

I think you could argue for both behaviours. And that's exactly the issue with these "default" values: at some point you end-up wanting to customize them, and now you need to provide mechanisms to undo the defaults. Lost of information could be equally confusing. :( It partially feels the best course of action here is to remove preload_order altogether?

and now you need to provide mechanisms to undo the defaults

Indeed, but to be fair in this case the mechanism already exists, in the sense that preloading using an ordered query is already in the absence of a default.

Lost of information could be equally confusing.

I agree in more complex cases involving query composition this could happen, but given that the "normal way" of preloading using the default is that simple (preload: [:comments]), people who go out of their way to write preload: ^(from ..., order_by: [...]) are probably nor expecting the default preload. Besides, making it impossible to override here makes it strictly less powerful that the other way around.

It partially feels the best course of action here is to remove preload_order altogether?

In my case this works indeed, so this is not a blocker. But I figured it would be nice to at least open an issue for the visibility in case somebody else ends up here, even if we keep the status quo 🙂

and now you need to provide mechanisms to undo the defaults

Indeed, but to be fair in this case the mechanism already exists, in the sense that preloading using an ordered query is already in the absence of a default.

Lost of information could be equally confusing.

I agree in more complex cases involving query composition this could happen, but given that the "normal way" of preloading using the default is that simple (preload: [:comments]), people who go out of their way to write preload: ^(from ..., order_by: [...]) are probably nor expecting the default preload. Besides, making it impossible to override here makes it strictly less powerful that the other way around.

It partially feels the best course of action here is to remove preload_order altogether?

In my case this works indeed, so this is not a blocker. But I figured it would be nice to at least open an issue for the visibility in case somebody else ends up here, even if we keep the status quo 🙂


Using the main menu to shutdown while the blockchain is still synching

Hey,
As the synch take a long time I'm looking for a way to use the build-up shutdown option from the main menu when the synch is still in progress.
Yet you can only ctrl+c to the terminal, you cannot enter the main menu. Is there a command or way to safely shutdown the node while still in synch progress?

Yes the command from the terminal to safely shutdown is called off.


Video Optimization: Display toolltip in media  library

Feature Description
In addition to the snackbar message, there should be a tooltip when hovering over a local media item in  the library that is currently being uploaded/processed.

Figma link
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Isn't this ticket blocked by https://github.com/google/web-stories-wp/issues/5982 ?

@swissspidy I don't seem to have access to the figma link here. Any chance you can grant me access?

No, it's not blocked by #5982 — we don't need % progress, just need to know whether it's in progress or not.
It is blocked by #6088 though (as stated) — and probably the adoption of the new design system as well.

Verified in QA


[FEATURE] Improvement - add a link to github discussions in FAQ page

Description
This issue is to add a section explaining BioDrop Github discussions page and adding a link. This can go at the end of the current FAQ's
FAQ page url
Wording to be used:
(In bold) My question is not answered by the FAQs/Where can I start a discussion about a feature or idea for BioDrop?
(text below) BioDrop uses github discussions to have community conversations about anything related to the BioDrop project that does not fit into an issue.  An example of a github discussion could be proposing an idea for BioDrop that isn't ready for issue creation yet because it needs more details and input from the community.
Take a look at the discussions and join the conversation
Screenshots
No response
Do you want to work on this issue?
No
Additional information
No response

@amandamartin-dev i want to work on this

Please assign it to me

I would like to work on this issue can you please assign it to me

@MeenuyD I have assigned this to you.  Please check the Issue description as I have updated this.

is this issue is still open?

is this issue is still open?

@Anuragwagh this issue has been assigned to someone else and they are working on the PR - you van see this from the comment history and also the Assignees box at the top of the page.  Please check this in future before raising to avoid noise and extra notifications for maintainers.

@SaraJaoude Thanks for confirming, IK about github PR and assigness , this issue is begineer friendly and will not take much time and sometime folks just assign the task and don't work on it. So , I just confirmed is anyone is still working on it or not.

SaraJaoude Thanks for confirming, IK about github PR and assigness , this issue is begineer friendly and will not take much time and sometime folks just assign the task and don't work on it. So , I just confirmed is anyone is still working on it or not.

@Anuragwagh - I am not sure from your message whether you are still asking if someone is still working on this issue.  If you take a look at the PR changes were requested a few days ago and in this project we like to give our contributors time to respond as we appreciate that people have other commitments. As reflected in our Contributing Guide  and issue will be unassigned if there has been inactivity for two weeks.  I suggest you check back in then, to reduce extra notifications for maintainers and everyone else.


Use consistent title case capitalization for headers.

CMS with articles (a, an, the), coordinating conjunctions (and, but, or, for, nor), and prepositions, regardless of length, are lowercased unless they are the first or last word of the title?


Add cluster access API, reassignment

Contributes to https://github.com/microsoft/reverse-proxy/issues/126#issuecomment-1024494147
This provides the minimal infrastructure necessary to build your own A/B testing or rolling upgrade system.
A) You can now directly look up routes and clusters
B) You can re-assign a request to a new cluster
That should allow a developer to provide their own custom middleware that examines requests, chooses a cluster, and assigns the request accordingly.
Note: Changing the cluster can cause some issues with Session Affinity if the two clusters have different affinity configurations, especially if it's enabled in one and disabled in the other. I've left this as a warning for now, not sure if anyone will need different settings across A/B clusters.

I was really hoping one of you would call me out on the terrible name of IProxyStateLookup 😆. Still hoping to find a better name.


Add availableAttributes to CAS discovery endpoint.

This PR adds the configured list of available attributes to the CasServerProfile to be returned by the cas/status/discovery endpoint.

Coverage decreased (-0.03%) to 45.519% when pulling ff765518d48c956e732b49779af1ef07f603527a on discovery-attributes into 3d5595eebb1b4f3b9d210447ddea83956a3135d8 on master.


(BKR-860) - Adding support for vagrant to quick start tasks.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2774/

since this is part of a quick-start type guide, should this Rakefile perhaps be overly verbose about what it's doing?
e.g.: {{i'm about to run command beaker-hostgenerator blah}}
and/or
should it have tasks for running with preserved-hosts and args for preserving hosts in some tasks?
and/or
should it spit out some info about where the preserved-hosts, hosts.yaml and log files end up?

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2819/

my intention for this doc is to use it as the immediate quick-start doc, to use just after installation is complete. With that in mind, I've got some general feedback about the doc:

We should start with the introduction "How to Use Them" (HUT) section first, as people don't really need a listing of the tasks until they've got the system up and running
In the HUT section, we should explain how to use them for both installation methods. This can be as simple as saying "if you've installed from gem, put this in the top of your project's rake file" vs "if you've cloned beaker, you can start by running rake --tasks"
In the HUT section, we say that installing Beaker is a prerequisite, but we don't talk about hypervisors or hypervisor pre-reqs. We shouldn't go too deep into the rabbit hole, but I think we should give a glossary introduction to hypervisors, something just like "Hypervisors are services that provision SUTs for Beaker", and then a similar one-line introduction to the two hypervisors available to start with: vmpooler & vagrant. For both, you have to set things up (unless you're internal). We can link to the hypervisor docs for them, and just reference the steps to follow in those docs to get setup.

Something that I found a little confusing is that it's not clear to me the first time you mention it how you're supposed to surround the hypervisor name in the CLI from these docs:
rake beaker_quickstart:gen_hosts[provisioner]

Am I actually supposed to say rake beaker_quickstart:gen_hosts[vmpooler], or rake beaker_quickstart:gen_hosts['vmpooler'], or rake beaker_quickstart:gen_hostsvmpooler? An example with a value here would clear that up. I can understand not wanting to hand-hold that much, but I think it's worth it in tutorial docs to over-communicate.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2834/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2835/

@kevpl I've made changes re your comments. For the second point above, I found I needed to require that path at the top of the rakefile whether I had cloned the repo or was using the gem?

@er0ck I have added more verbose output. I didn't add the ability to preserve hosts or use preserved hosts as we wanted to keep these quick start tasks as simple as possible. @kevpl @tvpartytonight @ferglor unless you think we should?

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2839/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2836/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2840/

i think we should have preserve/run-against-preserved, but it's totally fine as a later PR

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2841/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2838/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2847/

@kevpl I think I've made all the necessary edits.


Update Set-AzureADUserThumbnailPhoto.md

minor text fix

Docs Build status updates of commit cd1d3b2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0/AzureAD/Set-AzureADUserThumbnailPhoto.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Hi @eveerman
Per the read me file:
Please be aware that if you have any updates to automatically generated reference content, you should create an issue and not a PR.  The issue will then be created into a bug and triaged accordingly.  We do this because the reference content must mirror the *dll-help.xml file and subsequent updates to the reference content may overwrite any changes made through the repo.  Capturing it in the source code ensures that this does not occur.  Any PR with changes to automatically generated reference content will be closed.
Automatically generated reference content is any of the content under this Reference node, such as Get-AzureADUser
This only applies to reference content and not conceptual content.  Pull requests for changes to conceptual content are accepted and encouraged.  An example of the conceptual content is the Overview or a scenario such as importing data.
Thank you!
Bill


Overlapping/Flashing Video Seams

I had a video conference call this morning.
The edges of each person's video feed were flickering and exceedingly distracting/annoying.
On closer inspection I noticed that the seams, i.e. joins between video feeds, were slightly mismatched with the overlaid black grid lines. The flicker was specific to the thin overlapped area, where one person's feed pokes into the area of another's. It's out by up to about 3 pixels. If these overlaid lines were lined up accurately it would probably hide the flicker.
Possibly relevant is that my screen resolution is 5120 x 1440. Not sure if it's maybe a precision/rounding issue in the UI / layout?
Attaching a screenshot showing the overlap...

For queries related to Teams Product, Could you please reach out to Product Support Channel.


WIP: feat: implement first crate version

In this PR, the first version of the crate is implemented.

Codecov Report
Base: 100.00% // Head: 42.44% // Decreases project coverage by -57.55% :warning:

Coverage data is based on head (2026ef8) compared to base (98084ef).
Patch coverage: 42.44% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##              main       #1       +/-   ##
============================================
- Coverage   100.00%   42.44%   -57.56%
============================================
  Files            1       25       +24
  Lines            3      695      +692
============================================
+ Hits             3      295      +292
- Misses           0      400      +400

Impacted Files
Coverage Δ

src/models/additional_expected_response.rs
0.00% <0.00%> (ø)

src/models/data_schema/array_schema.rs
0.00% <0.00%> (ø)

src/models/data_schema/integer_schema.rs
0.00% <0.00%> (ø)

src/models/data_schema/number_schema.rs
0.00% <0.00%> (ø)

src/models/data_schema/object_schema.rs
0.00% <0.00%> (ø)

src/models/data_schema/string_schema.rs
0.00% <0.00%> (ø)

src/models/expected_response.rs
0.00% <0.00%> (ø)

src/models/security_definition/ace.rs
0.00% <0.00%> (ø)

src/models/security_definition/api_key.rs
0.00% <0.00%> (ø)

src/models/security_definition/basic.rs
0.00% <0.00%> (ø)

... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Invoking function returned by bindNodeCallback causes unexpected compiler error

RxJS version:
5.0.0-beta9
Code to reproduce:
import * as fs from 'fs';
var readFileAsObservable = Rx.Observable.bindNodeCallback(fs.readFile);
var result = readFileAsObservable('./roadNames.txt', 'utf8');
result.subscribe(x => console.log(x), e => console.error(e));

Expected behavior:
Compile without error
Actual behavior:
Compiling causes error:

bug.ts(5,14): error TS2346: Supplied parameters do not match any signature of call target.

Additional information:
The "Code to reproduce" here is exactly the sample code from the docs that demonstrate how to use bindNodeCallback.

This is caused by current type definition's of bindNodeCallback infers type to readFile to <string, buffer> automatically, falls back to returning function to (in: string) => Observable<Buffer>.
As an immediate workaround, you may specify type explicitly such  as
var readFileAsObservable = Rx.Observable.bindNodeCallback<string>(fs.readFile);
but feeling type definition might need to be updated, especially current generic <T> is hiding generic type of class Observable.

Thanks! Y'all do excellent work!

/cc @david-driscoll for visibility also.
At first sight (haven't explored yet), there isn't simple way to support function could have different return types (for example, fs.readFile(): string | buffer) by parameters. I'd like to use this issue to enhance type definition at least, such as removing repeated generics <T>.

current generic  is hiding generic type of class Observable.

: I've visited this and just noticed it's mostly by static method not able to reference class type params.
At this moment, it's required to explicitly casting where necessary, closing issue. Once if I find better way to enhance, I'll come up with separate PR.


Update change logs to list style

Summary

Back by popular demand, another change log update pull request. This time we switch to a list style and I'm not doing this again.

Closes #
Deployment Link

https://terra-framework-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Please merge PR #1198 so that the build passes.


built by msys2 with gcc 10.2.0, usShell module crash and segment fault

MINGW64 ~
$ gcc --version
gcc.exe (Rev6, Built by MSYS2 project) 10.2.0

gdb usShell3
(gdb) set args -llibusShellService0d.dll
(gdb) r
Starting program:
\tmp\github\CppOSGi\build10\bin\usShell3.exe -llibusShellService0d.dll
[New Thread 11684.0x15d8]
[New Thread 11684.0xb38]
[New Thread 11684.0x3a50]
Installing libusShellService0d.dll
[New Thread 11684.0xba4]

Thread 5 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 11684.0xba4]
0x00007ffd65dc5117 in alloc_cellseg (sc=0x2ad7e1a45a0, n=3)
    at \tmp\github\CppOSGi\third_party\tinyscheme\scheme.c:596
596                   typeflag(p) = 0;
(gdb) l
591                  sc->cell_seg[--i] = p;
592              }
593              sc->fcells += CELL_SEGSIZE;
594              last = newp + CELL_SEGSIZE - 1;
595              for (p = newp; p <= last; p++) {
596                   typeflag(p) = 0;
597                   cdr(p) = p + 1;
598                   car(p) = sc->NIL;
599              }
600              /* insert new cells in address order on free list */
(gdb) bt
#0  0x00007ffd65dc5117 in alloc_cellseg (sc=0x2ad7e1a45a0, n=3)
    at \tmp\github\CppOSGi\third_party\tinyscheme\scheme.c:596
#1  0x00007ffd65dd22bc in scheme_init_custom_alloc (sc=0x2ad7e1a45a0, malloc=0x7ffd65de4180 <malloc>,
    free=0x7ffd65de41c8 <free>) at \tmp\github\CppOSGi\third_party\tinyscheme\scheme.c:4670
#2  0x00007ffd65dd2115 in scheme_init (sc=0x2ad7e1a45a0)
    at \tmp\github\CppOSGi\third_party\tinyscheme\scheme.c:4636
#3  0x00007ffd65dd2079 in scheme_init_new ()
    at \tmp\github\CppOSGi\third_party\tinyscheme\scheme.c:4616
#4  0x00007ffd65de5301 in cppmicroservices::ShellService::Impl::Impl (this=0x2ad7e1a4530)
    at \tmp\github\CppOSGi\shellservice\src\ShellService.cpp:281
#5  0x00007ffd65dc3028 in cppmicroservices::ShellService::ShellService (this=0x2ad7e186ce0)
    at \tmp\github\CppOSGi\shellservice\src\ShellService.cpp:320
#6  0x00007ffd65de60b4 in __gnu_cxx::new_allocator<cppmicroservices::ShellService>::construct<cppmicroservices::ShellService> (this=0xeb247fee6f, __p=0x2ad7e186ce0) at /msys64/mingw64/include/c++/10.2.0/ext/new_allocator.h:150
#7  0x00007ffd65ded3b0 in std::allocator_traits<std::allocator<cppmicroservices::ShellService> >::construct<cppmicroservices::ShellService> (__a=..., __p=0x2ad7e186ce0)
    at /msys64/mingw64/include/c++/10.2.0/bits/alloc_traits.h:512
#8  0x00007ffd65dee2cb in std::_Sp_counted_ptr_inplace<cppmicroservices::ShellService, std::allocator<cppmicroservices::ShellService>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<>(std::allocator<cppmicroservices::ShellService>)
    (this=0x2ad7e186cd0, __a=...) at /msys64/mingw64/include/c++/10.2.0/bits/shared_ptr_base.h:551
#9  0x00007ffd65dec35f in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<cppmicroservices::ShellService, std::allocator<cppmicroservices::ShellService>>(cppmicroservices::ShellService*&, std::_Sp_alloc_shared_tag<std::allocator<cppmicroservices::ShellService> >) (this=0xeb247fefb8, __p=@0xeb247fefb0: 0x0, __a=...)
    at /msys64/mingw64/include/c++/10.2.0/bits/shared_ptr_base.h:682
#10 0x00007ffd65deb926 in std::__shared_ptr<cppmicroservices::ShellService, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<cppmicroservices::ShellService>>(std::_Sp_alloc_shared_tag<std::allocator<cppmicroservices::ShellService> >) (this=0xeb247fefb0, __tag=...) at /msys64/mingw64/include/c++/10.2.0/bits/shared_ptr_base.h:1371
#11 0x00007ffd65de9da0 in std::shared_ptr<cppmicroservices::ShellService>::shared_ptr<std::allocator<cppmicroservices::ShellService>>(std::_Sp_alloc_shared_tag<std::allocator<cppmicroservices::ShellService> >) (this=0xeb247fefb0,
--Type <RET> for more, q to quit, c to continue without paging--
    __tag=...) at /msys64/mingw64/include/c++/10.2.0/bits/shared_ptr.h:408
#12 0x00007ffd65df2bc0 in std::allocate_shared<cppmicroservices::ShellService, std::allocator<cppmicroservices::ShellService>>(std::allocator<cppmicroservices::ShellService> const&) (__a=...)
    at /msys64/mingw64/include/c++/10.2.0/bits/shared_ptr.h:860
#13 0x00007ffd65df252e in std::make_shared<cppmicroservices::ShellService> ()
    at /msys64/mingw64/include/c++/10.2.0/bits/shared_ptr.h:876
#14 0x00007ffd65de5555 in cppmicroservices::ShellActivator::Start (this=0x2ad7e189f30, context=...)
    at \tmp\github\CppOSGi\shellservice\src\ShellActivator.cpp:37
#15 0x00007ffd4d868fa9 in cppmicroservices::BundlePrivate::Start0 (this=0x2ad7e188b60)
    at \tmp\github\CppOSGi\framework\src\bundle\BundlePrivate.cpp:532
#16 0x00007ffd4d8737f2 in cppmicroservices::BundleThread::Run (this=0x2ad7e186850, fwCtx=0x2ad7e1a2630)
    at \tmp\github\CppOSGi\framework\src\bundle\BundleThread.cpp:134
#17 0x00007ffd4d9556ef in std::__invoke_impl<void, void (cppmicroservices::BundleThread::*)(cppmicroservices::CoreBundleContext*), cppmicroservices::BundleThread*, cppmicroservices::CoreBundleContext*> (__f=
    @0x2ad7e186be8: (void (cppmicroservices::BundleThread::*)(cppmicroservices::BundleThread * const, cppmicroservices::CoreBundleContext *)) 0x7ffd4d8733a0 <cppmicroservices::BundleThread::Run(cppmicroservices::CoreBundleContext*)>,
    __t=@0x2ad7e186be0: 0x2ad7e186850) at /msys64/mingw64/include/c++/10.2.0/bits/invoke.h:73
#18 0x00007ffd4d963b73 in std::__invoke<void (cppmicroservices::BundleThread::*)(cppmicroservices::CoreBundleContext*), cppmicroservices::BundleThread*, cppmicroservices::CoreBundleContext*> (__fn=
    @0x2ad7e186be8: (void (cppmicroservices::BundleThread::*)(cppmicroservices::BundleThread * const, cppmicroservices::CoreBundleContext *)) 0x7ffd4d8733a0 <cppmicroservices::BundleThread::Run(cppmicroservices::CoreBundleContext*)>)
    at /msys64/mingw64/include/c++/10.2.0/bits/invoke.h:95
#19 0x00007ffd4d92e0fe in std::thread::_Invoker<std::tuple<void (cppmicroservices::BundleThread::*)(cppmicroservices::CoreBundleContext*), cppmicroservices::BundleThread*, cppmicroservices::CoreBundleContext*> >::_M_invoke<0ull, 1ull, 2ull> (this=0x2ad7e186bd8) at /msys64/mingw64/include/c++/10.2.0/thread:264
#20 0x00007ffd4d92e127 in std::thread::_Invoker<std::tuple<void (cppmicroservices::BundleThread::*)(cppmicroservices::CoreBundleContext*), cppmicroservices::BundleThread*, cppmicroservices::CoreBundleContext*> >::operator() (
    this=0x2ad7e186bd8) at /msys64/mingw64/include/c++/10.2.0/thread:271
#21 0x00007ffd4d92dd0c in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (cppmicroservices::BundleThrea--Type <RET> for more, q to quit, c to continue without paging--q
Quit
(gdb) p p
$1 = (pointer) 0x7e1a5660
(gdb) x /4b p
0x7e1a5660:     Cannot access memory at address 0x7e1a5660
(gdb) p newp
$2 = (pointer) 0x7e1a5660
(gdb) p *sc
$3 = {malloc = 0x7ffd65de4180 <malloc>, free = 0x7ffd65de41c8 <free>, retcode = -1163005939, tracing = -1163005939,
  alloc_seg = {
    0x2ad7e1a5650 "\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r", <incomplete sequence \272>...,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
    0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>}, cell_seg = {0x7e1a5660,
    0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d,
    0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d, 0xbaadf00dbaadf00d}, last_cell_seg = 0,
  args = 0xbaadf00dbaadf00d, envir = 0xbaadf00dbaadf00d, code = 0xbaadf00dbaadf00d, dump = 0xbaadf00dbaadf00d,
  interactive_repl = 0, _sink = {_flag =<PHONE_NUMBER>, _object = {_string = {
        _svalue = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
        _length = -1163005939}, _number = {is_fixnum = 13 '\r', value = {ivalue = -1163005939,
          rvalue = -4.8366978272229995e-26}}, _port = 0xbaadf00dbaadf00d, _ff = 0xbaadf00dbaadf00d, _cons = {
        _car = 0xbaadf00dbaadf00d, _cdr = 0xbaadf00dbaadf00d}}}, sink = 0x2ad7e1a4688, _NIL = {_flag =<PHONE_NUMBER>,
    _object = {_string = {_svalue = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
        _length = -1163005939}, _number = {is_fixnum = 13 '\r', value = {ivalue = -1163005939,
          rvalue = -4.8366978272229995e-26}}, _port = 0xbaadf00dbaadf00d, _ff = 0xbaadf00dbaadf00d, _cons = {
        _car = 0xbaadf00dbaadf00d, _cdr = 0xbaadf00dbaadf00d}}}, NIL = 0x2ad7e1a46a8, _HASHT = {_flag =<PHONE_NUMBER>,
    _object = {_string = {_svalue = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
        _length = -1163005939}, _number = {is_fixnum = 13 '\r', value = {ivalue = -1163005939,
--Type <RET> for more, q to quit, c to continue without paging--
          rvalue = -4.8366978272229995e-26}}, _port = 0xbaadf00dbaadf00d, _ff = 0xbaadf00dbaadf00d, _cons = {
        _car = 0xbaadf00dbaadf00d, _cdr = 0xbaadf00dbaadf00d}}}, T = 0x2ad7e1a46c8, _HASHF = {_flag =<PHONE_NUMBER>,
    _object = {_string = {_svalue = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
        _length = -1163005939}, _number = {is_fixnum = 13 '\r', value = {ivalue = -1163005939,
          rvalue = -4.8366978272229995e-26}}, _port = 0xbaadf00dbaadf00d, _ff = 0xbaadf00dbaadf00d, _cons = {
        _car = 0xbaadf00dbaadf00d, _cdr = 0xbaadf00dbaadf00d}}}, F = 0x2ad7e1a46e8, _EOF_OBJ = {_flag =<PHONE_NUMBER>,
    _object = {_string = {_svalue = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
        _length = -1163005939}, _number = {is_fixnum = 13 '\r', value = {ivalue = -1163005939,
          rvalue = -4.8366978272229995e-26}}, _port = 0xbaadf00dbaadf00d, _ff = 0xbaadf00dbaadf00d, _cons = {
        _car = 0xbaadf00dbaadf00d, _cdr = 0xbaadf00dbaadf00d}}}, EOF_OBJ = 0x2ad7e1a4708,
  oblist = 0xbaadf00dbaadf00d, global_env = 0xbaadf00dbaadf00d, c_nest = 0xbaadf00dbaadf00d,
  LAMBDA = 0xbaadf00dbaadf00d, QUOTE = 0xbaadf00dbaadf00d, QQUOTE = 0xbaadf00dbaadf00d, UNQUOTE = 0xbaadf00dbaadf00d,
  UNQUOTESP = 0xbaadf00dbaadf00d, FEED_TO = 0xbaadf00dbaadf00d, COLON_HOOK = 0xbaadf00dbaadf00d,
  ERROR_HOOK = 0xbaadf00dbaadf00d, SHARP_HOOK = 0xbaadf00dbaadf00d, COMPILE_HOOK = 0xbaadf00dbaadf00d,
  free_cell = 0x2ad7e1a46a8, fcells = 5000, inport = 0x2ad7e1a46a8, outport = 0x2ad7e1a46a8,
  save_inport = 0x2ad7e1a46a8, loadport = 0x2ad7e1a46a8, load_stack = {{kind = 13 '\r', rep = {stdio = {
          file = 0xbaadf00dbaadf00d, closeit = -1163005939, curr_line = -1163005939,
          filename = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>}, string = {
          start = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
          past_the_end = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>,
          curr = 0xbaadf00dbaadf00d <error: Cannot access memory at address 0xbaadf00dbaadf00d>}}} <repeats 64 times>}, nesting_stack = {-1163005939 <repeats 64 times>}, file_i = -1163005939, nesting = 0, gc_verbose = 13 '\r',
  no_memory = 0 '\000',
  linebuff = "\255\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r"...,
  strbuff = "\255\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r--Type <RET> for more, q to quit, c to continue without paging--
\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272\r\272", <incomplete sequence \360>, tmpfp = 0xbaadf00dbaadf00d,
  tok = -1163005939, print_flag = -1163005939, value = 0xbaadf00dbaadf00d, op = -1163005939,
  ext_data = 0xbaadf00dbaadf00d, gensym_cnt = 0, vptr = 0x7ffd65df68c0 <vtbl>, dump_base = 0xbaadf00dbaadf00d,
  dump_size = -1163005939}

when i come to msys2 with gcc 10.2.0 32-bit, there is no problem.
i have no idea why msys2 with mingw64 build the modules would crash.

Hi @bbqz007 , thank you for taking the time to report this issue! I will try to reproduce the issue you are experiencing and if I have any questions, I will reach out.


Decoupling: Move meta boxes to wp-story-editor

Context
Move meta boxes to wp-story-editor and refactor code for decoupling the story-editor
Summary
Relevant Technical Choices

It would probably be better to have a central store in a different package like Gutenberg for maintaining some global states like isSaving, so they can be accessed and modified by both story-editor andwp-story-editor. Though the current approach of assembling the header components and overriding their isSaving logic would work for us for now.
Currently isSaving is being used in the following areas/components. We have got the first 5 items covered in this PR, however we would either need to revisit and think of the last two items or we think about better solution as mentioned above.

Loader
Update Button
Preview Button
Publish Button
SaveDraftButton
Author selection dropdown.
StoryAMPValidationErrors

Use Slot/Fill for appending metabox and its menu items instead of querying the DOM before using React Portal.

To-do

[x] Export Layout as InterfaceSkeleton and use in wp-story-editor
[x] Export all header items.
[x] Assembel header pieces in wp-story-editor
[x] Drill down header prop from InterfaceSkeleton to NavLayer component from the integration.
[x] Update Buttons component unit test and integration test.
[x] Remove unused code titleMissingDialog
[x] Pass metaboxes component from <InterfaceSkeleton> children.
[x] Remove metabox menu item from MenuItem component and use Slot/Fill or an ID for it.
[x] Insert Menu Item from the wp-story-editor.
[x] Move useSaveMetaBoxes to wp-story-editor.
[x] Handle isSaving and isEnabled in wp-story-editor.
[x] Move metaboxes related API callbacks to wp-story-editor.
[x] Manual testing the functionality

User-facing changes

Testing Instructions
This PR can be tested by following these steps:
Test if

Meta boxes fields saving - Yes
When saving in progress, is the preview button disabled: Yes
Is a loader visible in the meta box when saving in progress: Yes

Action
Loading State  ( main/current branch )
Enabled State  ( main/current branch )

Click on Publish Button
True/True
True/True

Click on Update Button
True/True
True/True

Click on Switch To Draft Button
True/True
True/True

Click on Draft Button
True/True
True/True

[x] This is a non-user-facing change and requires no QA

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Partially addresses https://github.com/google/web-stories-wp/issues/2918
See https://github.com/google/web-stories-wp/issues/8952

@swissspidy
( To be done later )
What if we export all panels from Document and assemble them in wp-story-editor like below
import {
  PublishPanel,
  ExcerptPanel,
  SlugPanel,
  StatusPanel,
  PageAdvancementPanel,
  BackgroundAudioPanel,
  TaxonomiesPanel,
} from '@web-stories-wp/story-editor';

const Document = () => {
  function DocumentInspector() {
    const enabledTaxonomies = useFeature('enableTaxonomiesSupport');
    return (
      <>
        <StatusPanel />
        <PublishPanel />
        <ExcerptPanel />
        <SlugPanel />
        <PageAdvancementPanel />
        <BackgroundAudioPanel />
        {enabledTaxonomies ? <TaxonomiesPanel /> : null}
      </>
    );
  }
}

function Layout() {
  return (
    <MetaBoxesProvider>
      <InterfaceSkeleton
        header={<Header />}
        inspector={ {
            document: {
              component: <Document />,
            },
          }
        }
      >
        <MetaBoxes />
      </InterfaceSkeleton>
    </MetaBoxesProvider>
  );
}

That will help us in a couple of ways

We would have more control over individual components like PublishPanel, so we can easily pass more configuration options ( props ) to handle isSaving or passing labels, etc.
It would be possible to remove/add panels from a third-party integration.

Just a thought that may be later the entire inspector panel may be configured from the third party integration using the following.
      <InterfaceSkeleton
        header={<Header />}
        inspector={ {
          design: {
            title: __( 'Design', 'web-stories' ),
            component: <Design />
          },
          document: {
            title: __( 'Document', 'web-stories' ),
            component: <Document />,
          },
          ...
        } }
      >

@sayedtaqui Good idea! It's similar to what Gutenberg does, but of course there the block-editor package is more low-level than our story-editor.
I opened #9070 to track & discuss this future enhancement

Ah, there are now quite a few merge conflicts after #8990 got in.

@swissspidy Fixed the test, the PR is ready!

Don't know why percy is complaining, I used https://www.diffchecker.com/image-diff/ and there seems to be no difference in the menu items.
Before & After Difference

@googlebot I consent

Don't know why percy is complaining, I used diffchecker.com/image-diff and there seems to be no difference in the menu items.
Before & After Difference

There was some small difference because that spacer span was not inside MenuItems anymore but nested inside MenuItem within additional-primary-menu-items where it has no effect
The zoom dropdown was also a bit smaller because of this.
Pushing some changes now to simplify the menu items alignment a bit.


Set env vars when initializing process.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1403  👈
#1401
#1402
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite


Cannot build 2.0 on Fedora 22

I installed all of the packages you have on the documentation, as well as libx11 and libX11-devel, from a clean working directory I cannot build because of the following error:
g++ -fdebug-types-section -Wl,-O1 -Wl,-rpath,/home/ispence/Development/phantomjs/src/qt/qtwebkit/lib -o ../../bin/jsc .obj/jsc.o   -Wl,-whole-archive -lJavaScriptCore -Wl,-no-whole-archive -L/home/ispence/Development/phantomjs/src/qt/qtwebkit/Source/JavaScriptCore/release -Wl,-whole-archive -lWTF -Wl,-no-whole-archive -L/home/ispence/Development/phantomjs/src/qt/qtwebkit/Source/WTF/release -licui18n -licuuc -licudata -L/home/ispence/Development/phantomjs/src/qt/qtbase/lib -lQt5Core -lpthread -lz -licui18n -licuuc -lm -ldl -lrt -lpthread
/home/ispence/Development/phantomjs/src/qt/qtwebkit/Source/JavaScriptCore/release/libJavaScriptCore.a(JSArray.o): In function `JSC::JSArray::push(JSC::ExecState*, JSC::JSValue)':
JSArray.cpp:(.text+0x3171): undefined reference to `void JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes<(unsigned char)20>(JSC::ExecState*, unsigned int, JSC::JSValue)'
collect2: error: ld returned 1 exit status
Makefile.jsc:97: recipe for target '../../bin/jsc' failed
make[2]: *** [../../bin/jsc] Error 1
make[2]: Leaving directory '/home/ispence/Development/phantomjs/src/qt/qtwebkit/Source/JavaScriptCore'
Makefile.JavaScriptCore:122: recipe for target 'sub-jsc-pro-make_first-ordered' failed
make[1]: *** [sub-jsc-pro-make_first-ordered] Error 2
make[1]: Leaving directory '/home/ispence/Development/phantomjs/src/qt/qtwebkit/Source/JavaScriptCore'
Makefile:87: recipe for target 'sub-Source-JavaScriptCore-JavaScriptCore-pro-make_first-ordered' failed
make: *** [sub-Source-JavaScriptCore-JavaScriptCore-pro-make_first-ordered] Error 2

You should try to update your source codes. @zackw had the same issue as you and landed the fix for that - https://github.com/ariya/phantomjs/commit/fe2c6bb5fdf776b718422a104e6babe67dbf2629


New site for "Built With" Page: http://kagami-tokyo.myshopify.com

Hi,
This is just a recap of #29 , to follow the process.
Our theme can be bought here in the Theme Store: https://themes.shopify.com/themes/kagami/styles/kyoto
Preset Kyoto: https://kagami-tokyo.myshopify.com
Preset Baptiste: https://kagami-paris.myshopify.com
(I know, URLs don't match preset names, Shopify just forgot to check the uniqueness of it and asked us to modify the preset names after releasing :D)

@bakura10, the theme looks incredible! You guys have done an amazing job, and I'm really glad Cart.js was able to help.
:+1:

Thanks Gavin. We'll likely build other themes with it. Hopefully you'll be able to add support for shipping soon ;)
Envoyé de mon iPhone

Le 22 août 2015 à 12:34, Gavin Ballard<EMAIL_ADDRESS>a écrit :
@bakura10, the theme looks incredible! You guys have done an amazing job, and I'm really glad Cart.js was able to help.
—
Reply to this email directly or view it on GitHub.

It's high on the list :).


♻🐛 [Trusted Types] Make loadScript, writeScript, and addAttributesToElement Trusted Types compatible

This change updates AMP's loadScript, writeScript, and addAttributesToElement functions to be Trusted Types compatible, partial fix to https://github.com/ampproject/amphtml/issues/37297. The functions were acting as wrappers for some functionality for the setAttribute function and were used extensively throughout the codebase with a variety of different values so it made sense to implement legacy conversions to amend the TT violations.

moved to #8 because of rebase issues


Add partialVisiblity property.

If partialVisibility is set then element is considered visible if only part of it is visible.

Nice idea, thanks @kompot ! Sorry I'm not merging straight away, I'd just like to take a bit of a closer look tomorrow morning and explore more how it impacts existing functionality.  Probably write a new test case too.  Will respond to this soon.

Thanks, great!

Suggestion: rename isVisible property to visibility which can have values: 'visible', 'hidden', 'partial'  or similar ...

onChange(visibility, rect)

@kompot @kof all good suggestions.
I'm wondering whether we can find something backwards-compatible.  What would you all think about leaving onChange to mean a change from "fully visible or not", and also adding a new optional onPartialChange callback which indicates a change from "at least partially visible or not visible at all".
@kompot would that work for your use-case?

onPartialChange would work ok for me, so any way everybody agrees on.
But there might be some confusion. Consider element is fully visible, then it becomes partially visible.  According to the name — may be. But logically I guess no. In my case definitely not.
@kof 's suggestion to make it enum instead of boolean seems reasonable to me.

@kompot yeah the reason I'm thinking 2 separate callbacks instead of a single with enum value is that question of "when is the callback called?".  I'm thinking that in most cases you would either care about full visibility or partial visibility, but not so much the transition from partial-to-full.
But I agree the naming I proposed could be tightened up to be clearer.

Another option that would preserve backwards-compatibility:

add a threshold prop, which has a default value of 1.0.
the check function will calculate what percentage of the sensor is visible and give a value between 0.0 (fully hidden) and 1.0 (fully visible).
the onChange callback is only called when visibility crosses the threshold in either direction.

What do you think?

I think with proper versioning and changelog, breaking changes are not an issue at all.
:-1:  for 2 callbacks, makes api more complex
Libs should not be opinionated. I can perfectly think of use cases where its important to know when element changes from partial to visible or hidden states.

Sure, I agree that we don't want to overly complicate things here.
@kompot I've had a closer look and I think the way you've implemented it is good as it won't change the behaviour until you opt-in with the partialVisibility prop.
I'd like to consider a more comprehensive solution that allows you to get notifications about both partial and full visibility.  Possibly removing the partialVisibility prop and making this the default behaviour. But as this will possibly be a breaking change I'll merge this PR for now.  We'll want to add a test-case for partial visibility moving forward as well.
Thanks!

@kompot published as v2.1.0

@joshwnj I think @kompot agreed on my enum proposal, lets move it in this direction and release 3.0

Yes, I think it's a good plan. We can also see if there are any other breaking-changes needing to be made to roll into 3.0
Before then, it's a good opportunity to try partial visibility some more and see how it affects things. Eg. I'm thinking a "threshold" prop will definitely be useful because at the moment even 1px of visibility will trigger onChange, and in a lot of cases you'd want it to be less sensitive.
I'll create a new issue to discuss any other things people want to see in 3.0


Update README.md

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Checks are failing. Will not request review until checks are succeeding.

Checks are failing. Will not request review until checks are succeeding.

R: @lostluck for label go.

Oops - sorry @lostluck, was testing out my pr bot and got a little excited - you can ignore this!


net: l2: wifi_mgmt: Fix non-ip-offloaded iface

IP offload has nothing to do with WiFi mgmt offload.
Just remove this unecessary tests for now, fixing wifi op for
(upcoming) non-ip-offload WiFi interfaces.
note: all Wifi drivers implement wifi-mgmt interface
Signed-off-by: Loic Poulain<EMAIL_ADDRESS>

Codecov Report

Merging #10427 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10427   +/-   ##
=======================================
  Coverage   53.14%   53.14%
=======================================
  Files         210      210
  Lines       25745    25745
  Branches     5673     5673
=======================================
  Hits        13681    13681
  Misses       9754     9754
  Partials     2310     2310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e98fa...10599ad. Read the comment docs.

Isn't this the same as #8703?

@jukkar, indeed!


UI Window Size Fix

Fixed window size based on visual bounds of the system.
Also fixed the send button hiding bug.
Closes  #162
Closes #160
Closes #158
Closes #151
Closes #150
Closes #140
Closes #134
Closes #124
Closes #123

LGTM


C#: Native number types

Historically, C# number types have a size defined by the language, regardless of the CPU architecture.
This feature would introduce new types whose size is dictated by the CPU architecture where the code runs.
dotnet/csharplang#435

Changed the title as this did not make the 7.3 release

Closing pending acceptance of the feature.


[Service Bus] Test for cancelScheduledMessages should not depend on peek()

The tests we have for cancelScheduledMessage and cancelScheduledMessages rely on peek  to test whether the cancel went through or not.
We now know that scheduled messages will show up on peek, but not on receive until their scheduled time is reached. So we should use receiveMessages instead of peek to test that the cancel actually worked
This might help with the issue of this test case failing once in a while

Closed with #3897


Changed several ComponentMapping with IComponentMapping

When using ComponentBaseInspector.Components I got the following
Unable to cast object of type 'FluentNHibernate.MappingModel.ClassBased.ReferenceComponentMapping' to type 'FluentNHibernate.MappingModel.ClassBased.ComponentMapping

I wasn't sure if ReferenceComponentMapping should derive from ComponentMapping or not so I left that alone. Instead I've changed several ComponentMapping to IComponentMapping so that no casting was needed.
I ran the rake tests and tested the built DLL in my employer's code.

Also can this commit be cherry-picked back into 1.4.

Thanks, released as part of #326 and #327


JobCreator crashing on CERN agents - oracle issue

And oracle issues are hitting us again and bringing components down. Right now I see vocms0281 JobCreator down, here is the traceback [1].
It seems those come from the SQLAlchemy update in the latest WMAgent release. It now wraps the exception from the DBAPI, thus the error message is now somehow different and the exception handler is not able to find those anymore:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/Database/DBExceptionHandler.py#L9
[1]
2019-06-13 06:54:02,923:139664752584448:INFO:JobCreatorPoller:Found end in iteration over subscription 6180
2019-06-13 06:54:03,019:139664752584448:ERROR:base:Error closing cursor
Traceback (most recent call last):
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/external/py2-sqlalchemy/1.3.3/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1333, in _safe_close_cursor
    cursor.close()
InterfaceError: not connected
2019-06-13 06:54:03,062:139664752584448:ERROR:JobCreatorPoller:Failed to execute JobCreator. Error: (cx_Oracle.InterfaceError) not connected
(Background on this error at: http://sqlalche.me/e/rvf5)
Traceback (most recent call last):
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py", line 414, in algorithm
    self.pollSubscriptions()
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py", line 549, in pollSubscriptions
    wmbsJobGroups = next(jobSplittingFunction)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py", line 87, in runSplitter
    groups = jobFactory(**splitParams)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMCore/JobSplitting/JobFactory.py", line 94, in __call__
    self.algorithm(*args, **kwargs)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMCore/JobSplitting/EventAwareLumiBased.py", line 103, in algorithm
    lDict = self.getFilesSortedByLocation(avgEventsPerJob)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMCore/JobSplitting/JobFactory.py", line 460, in getFilesSortedByLocation
    lDict = self.sortByLocation()
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMCore/JobSplitting/JobFactory.py", line 237, in sortByLocation
    fileset = self.loadFiles(size=self.limit)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMCore/JobSplitting/JobFactory.py", line 339, in loadFiles
    newResults = resultProxy.fetchmany(size=length)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/external/py2-sqlalchemy/1.3.3/lib/python2.7/site-packages/sqlalchemy/engine/result.py", line 1247, in fetchmany
    e, None, None, self.cursor, self.context
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/external/py2-sqlalchemy/1.3.3/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1466, in _handle_dbapi_exception
    util.raise_from_cause(sqlalchemy_exception, exc_info)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/external/py2-sqlalchemy/1.3.3/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 383, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/external/py2-sqlalchemy/1.3.3/lib/python2.7/site-packages/sqlalchemy/engine/result.py", line 1241, in fetchmany
    l = self.process_rows(self._fetchmany_impl(size))
  File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/external/py2-sqlalchemy/1.3.3/lib/python2.7/site-packages/sqlalchemy/engine/result.py", line 1157, in _fetchmany_impl
    return self.cursor.fetchmany(size)
InterfaceError: (cx_Oracle.InterfaceError) not connected
(Background on this error at: http://sqlalche.me/e/rvf5)

257 was just restared... error was:
Error in worker algorithm (1):
Backtrace:
<WMComponent.JobCreator.JobCreatorPoller.JobCreatorPoller object at 0x7f6511518e50> <@========== WMException Start ==========@>
Exception Class: JobCreatorException
Message: Failed to execute JobCreator. Error: (cx_Oracle.InterfaceError) not connected
(Background on this error at: http://sqlalche.me/e/rvf5)
ModuleName : WMComponent.JobCreator.JobCreatorPoller
MethodName : algorithm
ClassInstance : None
FileName : /data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py
ClassName : None
LineNumber : 435
ErrorNr : 0
Traceback:
File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py", line 414, in algorithm
self.pollSubscriptions()
File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-package

Same issue again on vocms0282. I'm creating a fix and will apply it to all production agents.

 Error: (cx_Oracle.InterfaceError) not connected
(Background on this error at: http://sqlalche.me/e/rvf5)
ModuleName : WMComponent.JobCreator.JobCreatorPoller
MethodName : algorithm
ClassInstance : None
FileName : /data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py
ClassName : None
LineNumber : 435
ErrorNr : 0
Traceback:
File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-packages/WMComponent/JobCreator/JobCreatorPoller.py", line 414, in algorithm
self.pollSubscriptions()
File "/data/srv/wmagent/v1.2.2.patch2/sw/slc7_amd64_gcc630/cms/wmagent/1.2.2.patch2/lib/python2.7/site-package


Support for Torque/PBS

Hi,
I would like to use dcblast to submit jobs to PBSpro. It could use a template file and replace the variables. For my purposes the following template would be enough.
#PBS -S $my_shell
#PBS -q $queue_name
#PBS -N ${job_prefix}_${chunk_id}
#PBS -l select=1:ncpus=24,walltime=144:00:00
#PBS -A $project_name
#PBS -M $email
#PBS -m ea

cd $PBS_O_WORKDIR || exit 255

$blastcmd" "${args}" "${other_user_opts}"

The command to submit a job is:
qsub "${pbs_script_filename}"

We don't have Torque/PBS.
But you can fix the code and pull request.


Cheap HyAB-type distance

https://doi.org/10.1002%2Fcol.22451 describes a pretty cheap geometric color distance formula that performs better than DE76 on larger distances in CIELAB. The formula is quite simple:
function de_hyab({L1, a1, b1}, {L2, a2, b2}) {
  const dL = L1 - L2, da = a1 - a2, db = b1 - b2
  return math.sqrt(da ** 2 + db ** 2) + abs(dL)
}

I guess this will be a new form of distance called .distanceHyAB or something. Might be interesting to try it with Oklab, among other things.

It's very easy to add a new deltaE method, you can look at the existing ones and send a PR, what do you think?

Thanks for citing the reference, although sadly that publication is paywalled. Happily one of the authors wants people to read their publications


Re-factor the arraysToBytes helper function (PR 16032 follow-up)

Change WorkerTasks, in WorkerMessageHandler.createDocumentHandler, to a use a Set
This is a tiny bit more compact, thanks to the Set.prototype.delete method.

Re-factor the arraysToBytes helper function (PR 16032 follow-up)
Currently this helper function only has two call-sites, and both of them only pass in ArrayBuffer data. Given how it's implemented there's a couple of code-paths that are completely unused (e.g. the "string" one), and in particular the intended fast-paths don't actually work.
This patch re-factors and simplifies the helper function, and it'll no longer accept anything except ArrayBuffer data (hence why it's also re-named).
Note that at the time when arraysToBytes was added we still supported browsers without TypedArray functionality, and we'd then simulate them using regular Arrays.

Move the arrayBuffersToBytes helper function into the worker-thread
Given that this helper function is only used on the worker-thread, there's no reason to duplicate it in both of the built pdf.js and pdf.worker.js files.

/botio test

For the MOZCENTRAL build, this PR saves about 1.3 kB in bundle size (which isn't a lot but still can't hurt).

[...] seeing where this function is used it would be good to have some (simple) unit tests for this function given that it's currently uncovered

That's a fair comment; I've added a couple of basic unit-tests :-)

/botio unittest

Nice work!