159818353: Dynamic Links causes a warning banner to appear under iOS 14

[REQUIRED] Step 1: Describe your environment

Xcode version: Version 11.5 (11E608c)
Firebase SDK version: 6.10.0
Firebase Component: Dynamic Links
Component version: 6.10.0
Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem
When launching my app on a device running the iOS 14 or iPadOS 14 beta, when I've copied something on another device, I get this system generated banner:

This appears to be caused by Firebase Dynamic Links, which attempts to check for a dynamic link saved in the pasteboard by a previously visited landing page.
Not sure what the best solution here is, but we're definitely going to get complaints when users update to iOS 14, launch our app, and immediately see something that looks like us harvesting their data.

There are new  iOS 14 Pasteboard API available on, this should probably be used now to avoid getting this banner https://developer.apple.com/documentation/uikit/uipasteboard/detectionpattern/3618951-probableweburl?changes=latest_major

Thanks for the report! And thanks @PycKamil for pointing out the new Pasteboard API. We'll look at getting this resolved quickly because you're right - that's not a good user experience at all.

Internal tracking: b/159818353

May be we should be able to query the pasteboard with new api (https://developer.apple.com/documentation/uikit/uipasteboard/detectionpattern?changes=latest_minor) before trying to access it.

Hey everybody,
While we are still exploring potential solutions, we would appreciate feedback on a current approach we are exploring. Feel free to pull in the below version of 'Firebase/DynamicLinks' and let us know if this reduces the issue in your tests.
pod 'Firebase/DynamicLinks', :git => 'https://github.com/firebase/firebase-ios-sdk.git', :branch => 'nc-dl-ios14'

We'll keep this thread updated with future developments!

@ncooke3 Out of transparency could we have some questions officially answered regarding this feature.

When does the SDK currently (production version) access the Pasteboard to check for a DL? Every foreground? On Interval? First Launch Only? Other Events.
Is the contents of the pasteboard sent off device for any reason? If so why?
If the SDK didn’t access the pasteboard at all what features of DL would stop working? It makes sense that the pasteboard is used to complete the journey when the user goes from the landing page of a DL to the App Store then to first run. What other features of DL are enabled by the pasteboard?

Thanks

Internally tracked at b/159818353

@ncooke3 Out of transparency could we have some questions officially answered regarding this feature.

When does the SDK currently (production version) access the Pasteboard to check for a DL? Every foreground? On Interval? First Launch Only? Other Events.
Is the contents of the pasteboard sent off device for any reason? If so why?
If the SDK didn’t access the pasteboard at all what features of DL would stop working? It makes sense that the pasteboard is used to complete the journey when the user goes from the landing page of a DL to the App Store then to first run. What other features of DL are enabled by the pasteboard?

Thanks

This would be very helpful for companies investigating what is happening with there apps. Do you have a time frame for clarification on this topic?

Hey everybody,
While we are still exploring potential solutions, we would appreciate feedback on a current approach we are exploring. Feel free to pull in the below version of 'Firebase/DynamicLinks' and let us know if this reduces the issue in your tests.
pod 'Firebase/DynamicLinks', :git => 'https://github.com/firebase/firebase-ios-sdk.git', :branch => 'nc-dl-ios14'

We'll keep this thread updated with future developments!

I've been trying with this branch, but I still get the warning banner.
No further research yet, but just used the pod from that specific branch, ran pod install and build the app in the simulator. When the app is completely closed (not running in background) and started while having something on the clipboard, the warning banner shows up.

I saw that a fix was merged into master that will first check pasteboard.hasURLs before accessing it, which is awesome.
In the case of reopening the app and the pasteboard happens to have a URL in it, I believe the pasteboard banner would be shown again which could be confusing for the user. I have a feature request in for this through support, but I'll mention it here for discussion purposes:
It would be nice for the API to allow us to turn off pasteboard checks if the app logic no longer needs to check initial launch dynamic links from the pasteboard (unless I'm mistaken and the check already won't be triggered by subsequent app opens).

@ncooke3 I updated by Podfile to target the nc-dl-ios14 branch as you suggested, but am not seeing those changes after running pod install. Do the podspec files need to be updated for that branch so that I don't keep pulling the latest production release?

@phungkytown You would also need to point all of the dependencies of FirebaseDynamicLinks to their podspec versions in the branch.
An easier way to try is likely to just update a standard Firebase 6.27.* installation with the diffs from https://github.com/firebase/firebase-ios-sdk/pull/5905/files

Figured it out. Thanks for the assist, @paulb777!

There appears to be a blessed way to do this now on iOS 14+: UIPasteboard.DetectionPattern. Is there any plan to use this?

@noremac When I accessed the pasteboard using that API it still showed the banner.

Hi @rasod , Please find official answers for your questions inline below:

@ncooke3 Out of transparency could we have some questions officially answered regarding this feature.

When does the SDK currently (production version) access the Pasteboard to check for a DL? Every foreground? On Interval? First Launch Only? Other Events.

During the very first launch of the app (post-install), FDL sdk will check the pasteboard to see whether the app was installed as a result of clicking on an FDL.
It is possible that some apps might have misconfigured their FDL integration, where the pasteboard is checked at every app launch.  This happens when the app fails to call dynamicLinkFromCustomSchemeURL method described in FDL docs.

Is the contents of the pasteboard sent off device for any reason? If so why?

If the SDK identifies pasteboard content as an url (and the contents look like a FDL short url), the url from the Pasteboard is sent to FDL servers to validate and report the installation count back to the app developer. This data is processed in accordance with the Firebase DPST.

If the SDK didn’t access the pasteboard at all what features of DL would stop working? It makes sense that the pasteboard is used to complete the journey when the user goes from the landing page of a DL to the App Store then to first run. What other features of DL are enabled by the pasteboard?

FDL SDK uses the pasteboard for deep-linking post app install (deferred deep-linking, where the link is copied on the app preview page) and app install attribution;  otherwise, FDL does not use the pasteboard for anything else.
Disabling pasteboard access affects the app in the following ways:
Deferred deep-linking will not work as reliably.  At best, your app receives weak matches for deep-links.
App install attribution stats will be less accurate (potentially undercounting app installs).
To disable pasteboard access, set the Info.plist property FirebaseDeepLinkPasteboardRetrievalEnabled to false.

Thanks

@eldhosembabu thank you for the info. For clarity the plist option is available starting on version 6.28.0 of the iOS SDK correct?

@rasod Yes the plist option was released with 6.28.0. Leaving this issue open for a more complete solution.

@paulb777 Solution on 6.28.x is good enough for now, however maybe it was good to consider add there a condition that disables it only on iOS 14?

As we know, one of the main selling features of DL is the first run experience, where you can take a new user directly to the place that caused them to install the app. That being a social link or a marketing campaign or coupon. Disabling that feature ends up gutting DL. Having the paste notification on the other hand, even only on first launch, is not the best first impression to make. Even if your intentions are good users will assume the worst, and that you are “spying” on them. “No good deed goes unpunished”.
I did file a radar with Apple to suggest an additional detection pattern similar to the current WebURL one, but specific only to the apps associated domains. That way the app would only need to access the pasteboard if the url contained was a DL/URL for that apps website, possibility asking for permission first if it does contain a DL.
Ultimately the writing is on the wall and using the pasteboard for simple inter-app communication is not a viable solution anymore. In the long run App Clips may end up being better approach allowing the app to take the user directly to a specific journey - coupon redemption page, article page, video player etc.
Thanks

I'm not able to see this plist attribute after updating to the most recent version. I added the attribute myself but it didn't affect the reading of the clipboard upon launch.

I'm not able to see this plist attribute after updating to the most recent version. I added the attribute myself but it didn't affect the reading of the clipboard upon launch. Any guidance would be very helpful.

Yeah I just tried the same thing, same experience.  This is really bad.

Same here... using SDK above 6.28 and added the property FirebaseDeepLinkPasteboardRetrievalEnabled to false, yet nothing seems to happen...

I'm not able to see this plist attribute after updating to the most recent version. I added the attribute myself but it didn't affect the reading of the clipboard upon launch. Any guidance would be very helpful.

Same here ...but solved by clearing the cache and DerivedData.

Use the SDK above 6.28 and add the property FirebaseDeepLinkPasteboardRetrievalEnabled to false.
Run the command below

watchman watch-del-all &&
rm -rf node_modules/ &&
rm -rf ios/Pods ios/build ios/Podfile.lock &&
yarn cache clean —force &&
rm -rf $TMPDIR/react-* &&
rm -rf $TMPDIR/haste-* &&
rm -rf $TMPDIR/metro-* &&
rm -rf ~/Library/Developer/Xcode/DerivedData/

then my project works fine now.

I had no success with your solution @impl-kano

No success here either

@GracieJP @nnarayann it may be that the issue is with some other library. Investigate for instance Google’s Mobile Ad SDK which has also been linked with this issue.
I don't think there is a way of knowing which is the offending library without doing something like this: https://hugotunius.se/2020/06/05/snooping-on-the-clipboard-snoopers.html

@joaoffcosta
I removed dynamic links from my project and the alerts stopped.

Thank you very much @joaoffcosta. At the end, it was a problem in our side, but you helped us out to find what the real issue was.

With FirebaseDeepLinkPasteboardRetrievalEnabled dynamic links stopped working on the first app install. On other hand, displaying the user that the app is reading from his pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

After updating Firebase to version 7.3.0 the warning banner does not show up any more in my app. Does this mean that this issue has been fixed ?
Also I did not set the FirebaseDeepLinkPasteboardRetrievalEnabled flag to false.

After updating Firebase to version 7.3.0 the warning banner does not show up any more in my app. Does this mean that this issue has been fixed ?
Also I did not set the FirebaseDeepLinkPasteboardRetrievalEnabled flag to false.

any update on this?

any update on this?

Any update on this topic? I think the bug still remains because I have not seen that they have recently released an update of the firebase ios sdk library :/

Any update on this topic? I think the bug still remains because I have not seen that they have recently released an update of the firebase ios sdk library :/

With FirebaseDeepLinkPasteboardRetrievalEnabled set to false dynamic links stopped working on the first app install. On other hand, displaying that the app is reading from the user's pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

hi @agordeev could you please let me know whether you are not at all receiving any links after FirebaseDeepLinkPasteboardRetrievalEnabled set to false? You are supposed to get FDL working with a weak/default match. Please let us know if thats not the case. thanks

With FirebaseDeepLinkPasteboardRetrievalEnabled set to false dynamic links stopped working on the first app install. On other hand, displaying that the app is reading from the user's pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

hi @agordeev could you please let me know whether you are not at all receiving any links after FirebaseDeepLinkPasteboardRetrievalEnabled set to false? You are supposed to get FDL working with a weak/default match. Please let us know if thats not the case. thanks

With FirebaseDeepLinkPasteboardRetrievalEnabled set to false dynamic links stopped working on the first app install. On other hand, displaying that the app is reading from the user's pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

hi @agordeev could you please let me know whether you are not at all receiving any links after FirebaseDeepLinkPasteboardRetrievalEnabled set to false? You are supposed to get FDL working with a weak/default match. Please let us know if thats not the case. thanks

Hi, how to get the weak/default match?  Is there any code sample?

With FirebaseDeepLinkPasteboardRetrievalEnabled set to false dynamic links stopped working on the first app install. On other hand, displaying that the app is reading from the user's pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

hi @agordeev could you please let me know whether you are not at all receiving any links after FirebaseDeepLinkPasteboardRetrievalEnabled set to false? You are supposed to get FDL working with a weak/default match. Please let us know if thats not the case. thanks

Hi, how to get the weak/default match?  Is there any code sample?

With FirebaseDeepLinkPasteboardRetrievalEnabled set to false dynamic links stopped working on the first app install. On other hand, displaying that the app is reading from the user's pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

hi @agordeev could you please let me know whether you are not at all receiving any links after FirebaseDeepLinkPasteboardRetrievalEnabled set to false? You are supposed to get FDL working with a weak/default match. Please let us know if thats not the case. thanks

Hi, how to get the weak/default match? Is there any code sample?

@yz Hi, You can get the weak/default match info like this.
// DynamicLink
if let dynamicLink: DynamicLink = DynamicLinks.dynamicLinks().dynamicLink(fromCustomSchemeURL: url) {
    print(" \(dynamicLink.matchType)") <---------
}

I can guess that the match(weak/default) is based on the device information here.
https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseDynamicLinks/Sources/FIRDynamicLinkNetworking.m#L208

With FirebaseDeepLinkPasteboardRetrievalEnabled set to false dynamic links stopped working on the first app install. On other hand, displaying that the app is reading from the user's pasteboard is unacceptable. Looks like we need to wait for a better solution :-/

hi @agordeev could you please let me know whether you are not at all receiving any links after FirebaseDeepLinkPasteboardRetrievalEnabled set to false? You are supposed to get FDL working with a weak/default match. Please let us know if thats not the case. thanks

Hi, how to get the weak/default match? Is there any code sample?

@yz Hi, You can get the weak/default match info like this.
// DynamicLink
if let dynamicLink: DynamicLink = DynamicLinks.dynamicLinks().dynamicLink(fromCustomSchemeURL: url) {
    print(" \(dynamicLink.matchType)") <---------
}

I can guess that the match(weak/default) is based on the device information here.
https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseDynamicLinks/Sources/FIRDynamicLinkNetworking.m#L208

Any update on this?
I have done following:

Added FirebaseDeepLinkPasteboardRetrievalEnabled and set it to false in Info.plist.
Perform diagnosis :

[FIRDynamicLinks performDiagnosticsWithCompletion:nil];
Output : performDiagnostic completed successfully! No errors found.
Then also, it is showing popup of paste board.

Has there been any update on this topic?

I am a bit lost with this.
In our project I have set the FirebaseDeepLinkPasteboardRetrievalEnabled to false.
I don't see the warning banner anymore but then also the dynamic link doesn't survive the app install.
This is how we are handling the link.
        let linkHandled = DynamicLinks.dynamicLinks().handleUniversalLink(incomingURL) {( dynamicLink, error ) in
            guard error == nil else {
                Log.message("Dynamic link error: \(error!.localizedDescription)")
                return
            }

            if let dynamicLinkUrl = dynamicLink?.url {
                self.redirect(universalLink: dynamicLinkUrl)
            }
        }

When opening the link with a previously installed app, the dynamic link works fine.
When opening the link with the post install flow, the dynamic link does not work.

Is there any updates on this?

I'm going to close this issue, since the original problem was addressed with the plist option in 6.28.0.  Please open another issue for related or other questions and issues.


feat(explore): Implement data panel redesign

SUMMARY
This PR implements the redesign of data panel in Explore (below the chart container).

Removed the "Data" header that expands/collapses on click
Moved expand/collapse functionality to tabs header. When collapsed, clicking on expand button opens tabs showing "Results" by default OR the last active tab before collapsing
When collapsed, user can also click on tab name to expand with that tab active
When expanded, user can hide the tables by clicking on collapse button OR by clicking on active tab name
Moved row count, copy button and search from tabs header to tab content - now they look more in context of currently displayed table
Now Results and Samples have separate searches - the search text is no longer shared between those 2 tables
Refactored ChartPanel - now we no longer manually calculate widths and heights of chart panel and tables panel. It's all based on css flex.
Tables functionality remains unchanged - the request is sent only when the table is activated the first time or there were changes to query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS

Create a chart
Verify that collapsing/expanding works as described in PR's summary
Verify that copy button and row counter work as before for both results and samples
Verify that typing search text in 1 table doesn't affect search filter in second table
Verify that chart panel and data table panel don't overflow on each other and scale well when window width changes

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

CC @kasiazjc

/testenv up


connectivity_plus updated to 1.0.5

Describe the purpose of the pull request:
The connectivity_plus team fixed the naming collision issue in 1.0.2: https://github.com/fluttercommunity/plus_plugins/issues/260#issuecomment-855823911
That mean if some people were still on the deprecated connectivity for whatever reason, they could have received a warning after flutter_graphql moved to connectivity_plus.
1.0.2 eliminates this concern without introducing any breaking changes. I think it is worth the minor revision increment on this package.
Breaking changes

N/A

Fixes / Enhancements

Eliminates risk of naming collision with deprecated connectivity package for web enabled flutter apps using flutter_graphql.

We have released a new version version 1.0.5 so please consider adding this version instead of 1.0.4 which was a bit problematic for some users.

@mhadaily Thanks I updated the PR. I can't merge them unfortunately so might take a while until this is actually applied.

Thanks for contributing, unfortunately, this update is not completed, because it only partially updates the dependencies list.
This PR https://github.com/zino-app/graphql-flutter/pull/978 contains a full upgrade of all dart dependencies and will restore the sanity inside the repository.
We hope to see you back to contribute to this repository.


grpc context propagation with task name

Make outer grpc context and task name available to logging etc in user code (process fn).

👍


Geowave 999 mak438

unit tests for landsat8 cli

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.

Coverage increased (+0.5%) to 52.469% when pulling 9181435f1d90a01ebef0c2f09ef26693a814be43 on GEOWAVE-999-mak438 into f8baf178a2a26a715289bcba990b9d2369f61792 on master.


fails to load w/o nvim-lsp-installer

nvim-lsp-installer is supposed to be optional (for now).

fixed on main.


Bot throws exception when it doesn't have a profile pic.

When the bot doesn't have a profile picture, url=self.bot.user.avatar.url is None.
This causes anyone_embed.set_thumbnail(url=self.bot.user.avatar.url) to throw an exception, as it's being passed in None as an argument.

Thank you for the feedback.
Given that it's only intended to work as a single instance on the BOTC Unofficial (as far as I'm aware) right now, we're not looking to replace all the instances another solution.


[hyperscan] Update the portfile to remove debug/share file

Describe the pull request
The hyperscan library cannot be installed on my Mac (macOS 10.15) with the following error below. I am on master branch commit 101452334cf0f1ba5329fd07f8b8f37f81fa2fc1. It looks like the debug/share file should be removed so that post-install validation can pass, and I managed to pass the post-install validation check by following the instructions given in the error message.
vcpkg install hyperscan
The following packages will be built and installed:
    hyperscan[core]:x64-osx
Starting package 1/1: hyperscan:x64-osx
Building package hyperscan[core]:x64-osx...
-- Using cached ~/dev/tools/vcpkg/downloads/intel-hyperscan-v5.1.0.tar.gz
-- Using source at ~/dev/tools/vcpkg/buildtrees/hyperscan/src/v5.1.0-e80f138a71
-- Configuring x64-osx-dbg
-- Configuring x64-osx-rel
-- Building x64-osx-dbg
-- Building x64-osx-rel
-- Installing: ~/dev/tools/vcpkg/packages/hyperscan_x64-osx/share/hyperscan/copyright
-- Performing post-build validation
/debug/share should not exist. Please reorganize any important files, then use
    file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)
Found 1 error(s). Please correct the portfile:
    ~/dev/tools/vcpkg/ports/hyperscan/portfile.cmake
-- Performing post-build validation done
Error: Building package hyperscan:x64-osx failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: hyperscan:x64-osx
  Vcpkg version: 2019.09.12-unknownhash

What does your PR fix? Fixes issue #
NA

Which triplets are supported/not supported? Have you updated the CI baseline?
Not changed.

Does your PR follow the maintainer guide?
Yes.

Hi there, I saw the bot reported some regression. I am new to vcpkg and this is my first PR, could some one confirm if this is a regression caused by this PR? Thanks.

Hi @niyue thanks for this PR.
Could you please open an issue here for this problem?
So others may replicate this problem.
Please also bump the version as  5.0.1-3 in ports/hyperscan/CONTROL file?
You can learn about the version naming rules in this doc.

As for the regressions on osx pipeline, you don't need to care about.
Since these regressions are not related with this PR.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: niyue sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@NancyLi1013 thanks for your guidance and I've made the change according to your guidance, please have a look.

Thanks for your update.
I'm so sorry, I didn't notice that the version was wrong before.
The port used version 5.1.0. So it should be 5.1.0 in CONTROL file too.
So could you please update the version as 5.1.0-3 in CONTROL again?

@NancyLi1013 Sure. Done.


Debugging the scripts

Hello,
what do I have to change in the sample project in order to enable debugging into the script that is called by the sample application?
In the Debug → Windows → Modules of Visual Studio I can see, that the assembly was created without symbols. Therefore I assume, that debugging is not possible with the current settings/code.
So what I ask for is that pressing F11 in the line greeter.Greet("Hello MEF!"); - I want to step into the Greet Method that is defined in the Text.csx
I use Win10 64 bit OS and Visual Studio 2019.
Best regards
Kilian

Hi,
It's been a while since I step a foot in this project, but if I remember correctly the debug is indeed not possible, sorry.
It is one of the con of a script.

Hi @laedit,
this is not the answer I'd hoped for :(
I found out, that the ScriptCsCatalogOptions class has a ScriptArgs property which takes for example "-loglevel" as input.
I think this parameter will be used as cmdline argument for the scriptcs.exe, which has to be called at some point, correct?
So scriptcs.exe does have a "-debug" parameter, too. This parameter "emits PDB symbols allowing for attaching a Visual Studio debugger" as written in the documentation. Does the ScriptCsCatalog not forward this parameter to the scriptcs.exe?
Best regards
Kilian

The ScriptArgs property is just args for the scripts imported through MEF.
This repository only allows to use MEF to "import" scripts, it doesn't launch ScriptCs.
I think for debugging scripts launched through ScriptCs you better be asking on the main repository.


[pay with] Bank transfers should be disabled when available quantity < 100

Describe the bug
Currently the UI shows the bank transfer options even when the total amount available is less than 100. This puts the UI in an invalid state.
To Reproduce
Steps to reproduce the behavior:

Go to https://www.carbonmark.com/projects/VCS-1883-2018/retire/pools/bct
Click on USDC and login
Enter a valid amount (0.001)
Select bank transfer
See amount change to 100 (more than available)

Expected behavior
Bank transfer option is disabled.
Screenshots
https://github.com/KlimaDAO/klimadao/assets/138768831/168a6619-7f86-4684-9aa0-59e4d793b3ce

thanks @sprrwhwk
the quantity < 0 issue will be addressed in #1035 and then we will no longer see those listings.
however, good catch that if min of 100 > available quantity we should show a warning message and keep RETIRE CARBON button greyed out.
cc @0xMakka

Nice catch @sprrwhwk, missed this one in our testing. Will provide a fix for this.


Update DonationSite Edit to Use New Theme

Theme update
We're upgrading our bootstrap theme to use a bootstrap 4 template and need to upgrade the various pages in our site.
This issue is the update the app/views/donation_site/edit.html.erb view file to use the new bootstrap theme. When submitting your PR please include a screenshot of the completed page!
If you get stuck please refer to the following pages have been done and can be used as a reference in the new theme:

app/views/requests/index.html.erb
app/views/distributions/index.html.erb
app/views/donation_sites/new.html.erb

As this is a work an progress and we can't go live until all the pages have been converted please submit your PR against the new_theme branch.

I'm going to work on this! 💖


update engin-polat

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: polatengin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:warning: Validation status: warnings

File
Status
Preview URL
Details

rd/engin-polat.yml
:warning:Warning

Details

rd/about/index.md
:warning:Warning

Details

rd/adam-cogan.yml
:warning:Warning

Details

rd/adam-jorgensen.yml
:warning:Warning

Details

rd/ahmed-bahaa.yml
:warning:Warning

Details

rd/alex-tumanov.yml
:warning:Warning

Details

rd/alexander-wechsler.yml
:warning:Warning

Details

rd/allen-tuladhar.yml
:warning:Warning

Details

rd/alois-reitbauer.yml
:warning:Warning

Details

rd/alon-fliess.yml
:warning:Warning

Details

rd/amanda-perran.yml
:warning:Warning

Details

rd/andre-carlucci.yml
:warning:Warning

Details

rd/andrea-saltarello.yml
:warning:Warning

Details

rd/andrewj-brust.yml
:warning:Warning

Details

rd/andrey-ivashentsev.yml
:warning:Warning

Details

rd/andy-cross.yml
:warning:Warning

Details

rd/ayman-el-hattab.yml
:warning:Warning

Details

rd/benjamin-niaulin.yml
:warning:Warning

Details

rd/benny-tritsch.yml
:warning:Warning

Details

rd/billy-hollis.yml
:warning:Warning

Details

rd/brian-bourne.yml
:warning:Warning

Details

rd/brian-noyes.yml
:warning:Warning

Details

rd/carlos-dossantos.yml
:warning:Warning

Details

rd/carlos-mattos.yml
:warning:Warning

Details

rd/carsten-rachfahl.yml
:warning:Warning

Details

rd/chan-park.yml
:warning:Warning

Details

rd/chris-kinsman.yml
:warning:Warning

Details

rd/christian-weyer.yml
:warning:Warning

Details

rd/ciprian-jichici.yml
:warning:Warning

Details

rd/claudenir-andrade.yml
:warning:Warning

Details

rd/colin-melia.yml
:warning:Warning

Details

rd/conrad-akunga.yml
:warning:Warning

Details

rd/damir-dizdarevic.yml
:warning:Warning

Details

rd/damir-dobric.yml
:warning:Warning

Details

rd/damir-tomicic.yml
:warning:Warning

Details

rd/dan-thyer.yml
:warning:Warning

Details

rd/dan-wahlin.yml
:warning:Warning

Details

rd/dana-epp.yml
:warning:Warning

Details

rd/daniele-bochicchio.yml
:warning:Warning

Details

rd/danieltibor-fuchs.yml
:warning:Warning

Details

rd/daron-yondem.yml
:warning:Warning

Details

rd/dave-nel.yml
:warning:Warning

Details

rd/david-yack.yml
:warning:Warning

Details

rd/destin-joy.yml
:warning:Warning

Details

rd/drgreg-low.yml
:warning:Warning

Details

rd/duxraymond-sypmp.yml
:warning:Warning

Details

rd/edgar-sanchez.yml
:warning:Warning

Details

rd/eduardo-castro.yml
:warning:Warning

Details

rd/eric-overfield.yml
:warning:Warning

Details

rd/ericd-boyd.yml
:warning:Warning

Details

This comment lists only the first 50 files in the pull request.

rd/engin-polat.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/about/index.md

[Warning] the value rd.microsoft.com is undefined for metadata site_name

rd/adam-cogan.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/adam-jorgensen.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/ahmed-bahaa.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/alex-tumanov.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/alexander-wechsler.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/allen-tuladhar.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/alois-reitbauer.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/alon-fliess.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/amanda-perran.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/andre-carlucci.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/andrea-saltarello.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/andrewj-brust.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/andrey-ivashentsev.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/andy-cross.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/ayman-el-hattab.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/benjamin-niaulin.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/benny-tritsch.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/billy-hollis.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/brian-bourne.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/brian-noyes.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/carlos-dossantos.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/carlos-mattos.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/carsten-rachfahl.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/chan-park.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/chris-kinsman.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/christian-weyer.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/ciprian-jichici.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/claudenir-andrade.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/colin-melia.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/conrad-akunga.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/damir-dizdarevic.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/damir-dobric.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/damir-tomicic.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/dan-thyer.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/dan-wahlin.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/dana-epp.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/daniele-bochicchio.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/danieltibor-fuchs.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/daron-yondem.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/dave-nel.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/david-yack.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/destin-joy.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/drgreg-low.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/duxraymond-sypmp.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/edgar-sanchez.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/eduardo-castro.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/eric-overfield.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

rd/ericd-boyd.yml

[Warning] the value rd.microsoft.com is undefined for metadata site_name
[Warning] the value Profile is undefined for metadata pagetype

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Capitalize the items in your tagline to be consistent with all other RDs.

:warning: Validation status: warnings

File
Status
Preview URL
Details

rd/engin-polat.yml
:warning:Warning

Details

rd/engin-polat.yml

[Warning] the value Profile is undefined for metadata pagetype

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Breaks action in Ember 0.2.7

Actions dont get triggered for some reason with Ember 0.2.7.

here's more info on the fix:
Looks like Ember 0.2.7 requires a target when calling triggerAction
    this.triggerAction({
      action: actionName,
      target: this.get('controller'),
      actionContext: contexts
    });

added this line but now in the template the controller has to be specified

Looks like this might be a problem with Ember itself...
https://github.com/emberjs/ember.js/issues/11402

https://github.com/IvyApp/ivy-sortable/blob/7dd3d825df83998fa4da616edff2fcc9f0d6e22d/addon/views/ivy-sortable.js#L107-L110 needs to be updated to account for the fact that _parentView doesn't exist in Ember 1.13+.

Looks like its not :)

Yeah, the idea was to make ivy-sortable masquerade as a component even though under the hood it's actually a CollectionView, so that code was lifted directly from Ember.Component. I've changed it to reference parentView instead, which seems to work both with Ember 1.13 and older.

Awesome! Thanks

:+1:

Hi @omghax I tested out the component with your fix. Seems like the action target object is the content item.
This is my example where content is a list of items in a model:
// app/templates/card-view.hbs
{{#collection "ivy-sortable" content=content moved="moveCard" parentView=controller revert="200" }}
  {{card details=this}}
{{/collection}}

// app/controllers/card-view.js
  import Ember from 'ember';

  export default Ember.ArrayController.extend({
    actions: {
      moveCard(card, oldIndex, newIndex) {
        console.log("CARD MOVED", card, oldIndex, newIndex);
      }
    }
  });

moving this to a new issue


Improve AKS Swagger documentation

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify: Improving documentation

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

On the breaking changes mentioned: All 3 of the 1006 "Removed Definitions" were not actually removed AFAIK. Each definition was of a primitive type - my understanding is that this style of definition is for reuse within the Swagger specification. There is no fundamental change in the API shape (what was a string is still a string). Nor should there be a change in SDKs AFAIK because those fields are not rendered as types in SDKs?
The min/max/default stuff I may revert (although actually the values are the values accepted by the service so I don't think there's really a functional breaking change there either).

/azp run

/azp run

Closed this PR and opened #14934 to clear breaking change tags that are no longer appropriate as all breaking changes have been removed.


Should send AIVDO messages instead of AIVDM

"AIVDM packets are reports from other ships and AIVDO packets are reports from your own ship." as per http://catb.org/gpsd/AIVDM.html#_introduction.

Ah, ok, see it now. Thanks!


Channels do not play?

Hi, just checked about 5 channels and none seem to work (does not play in VLC). Can you please check?

The Zee5 api trick no longer works. 😢😢

The Zee5 api trick no longer works. crycry

Ok, thanks!


Don't hold lock around volume driver for volume create.

Hi Brian @cpuguy83,
Unfortunately the commit for #14242 broke the behavior introduced in #15684, namely that a volume plugin can run in a container across docker restart. #15684 allowed this by not holding a lock across volume driver initialization.
This PR fixes and allows that again, by not holding a lock in the new volume create code path introduced in #14242 across the volume driver initialization.
With this fix, plugins are allowed to initialize and start in parallel with containers that depend on them, and allow a volume plugin in a container across docker restart.
Thanks!
Signed-off-by: Stephen Rust<EMAIL_ADDRESS>

Can you add this test to make sure we don't do this again?
diff --git a/integration-cli/docker_cli_start_volume_driver_unix_test.go b/integration-cli/docker_cli_start_volume_driver_unix_test.go
index 0cc5192..b29c09e 100644
--- a/integration-cli/docker_cli_start_volume_driver_unix_test.go
+++ b/integration-cli/docker_cli_start_volume_driver_unix_test.go
@@ -9,8 +9,10 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"strings"
+	"time"

 	"github.com/go-check/check"
 )
@@ -271,3 +273,40 @@ func (s *DockerExternalVolumeSuite) TestStartExternalNamedVolumeDriverCheckBindL
 	c.Assert(s.ec.mounts, check.Equals, 1)
 	c.Assert(s.ec.unmounts, check.Equals, 1)
 }
+
+// Make sure a request to use a down driver doesn't block other requests
+func (s *DockerExternalVolumeSuite) TestStartExternalVolumeDriverLookupNotBlocked(c *check.C) {
+	specPath := "/etc/docker/plugins/down-driver.spec"
+	err := ioutil.WriteFile("/etc/docker/plugins/down-driver.spec", []byte("tcp://<IP_ADDRESS>:9999"), 0644)
+	c.Assert(err, check.IsNil)
+	defer os.RemoveAll(specPath)
+
+	chCmd1 := make(chan struct{})
+	chCmd2 := make(chan error)
+	cmd1 := exec.Command(dockerBinary, "volume", "create", "-d", "down-driver")
+	cmd2 := exec.Command(dockerBinary, "volume", "create")
+
+	c.Assert(cmd1.Start(), check.IsNil)
+	defer cmd1.Process.Kill()
+	time.Sleep(100 * time.Millisecond) // ensure API has been called
+	c.Assert(cmd2.Start(), check.IsNil)
+
+	go func() {
+		cmd1.Wait()
+		close(chCmd1)
+	}()
+	go func() {
+		chCmd2 <- cmd2.Wait()
+	}()
+
+	select {
+	case <-chCmd1:
+		cmd2.Process.Kill()
+		c.Fatalf("volume create with down driver finished unexpectedly")
+	case err := <-chCmd2:
+		c.Assert(err, check.IsNil, check.Commentf("error creating volume"))
+	case <-time.After(5 * time.Second):
+		c.Fatal("volume creates are blocked by previous create requests when previous driver is down")
+		cmd2.Process.Kill()
+	}
+}

Sure. Thanks for the test case!
Passed for me:
PASS: docker_cli_start_volume_driver_unix_test.go:278: DockerExternalVolumeSuite.TestStartExternalVolumeDriverLookupNotBlocked	0.128s
Pushed new commit.

LGTM

LGTM


Support to create new tables from parquet files

Feature request
Is your feature request related to a problem? Please describe.

Parquet is a portable file format for heterogeneous data warehouse migration, which has table metadata embedded, is self-described, and high data compression ratio.
SparkSQL and ClickHouse are already convenient for creating new tables from parquet files.
For example in SparkSQL :
    CREATE TABLE  table_identifier
    [ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
    USING parquet LOCATION path

https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-table-datasource.html
in ClickHouse:
CREATE TABLE imported_from_parquet
ENGINE = MergeTree
ORDER BY tuple() AS
SELECT *
FROM file('data.parquet', Parquet)

https://clickhouse.com/docs/en/integrations/data-formats/parquet#creating-new-tables-from-parquet-files
SparkRocks is expected to support this feature.

https://docs.starrocks.io/en-us/latest/data_source/file_external_table
Can this feature meet your requirement?
Also, starrocks will release a table function feature in version 3.1

https://docs.starrocks.io/en-us/latest/data_source/file_external_table Can this feature meet your requirement?
Also, starrocks will release a table function feature in version 3.1

Hi, I Read the docs above,  below SQL statement requires specifying the column name and column type, but in spark SQL and clickhouse, those are not required. Both column name and column type information are loaded from self-described parquet files, which are much more convenient.
CREATE EXTERNAL TABLE <table_name>
(
    <col_name> <col_type> [NULL | NOT NULL] [COMMENT "<comment>"]
)
ENGINE=file
COMMENT ["comment"]
PROPERTIES
(
    FileLayoutParams,
    StorageCredentialParams
)

I think you're looking for this. https://docs.starrocks.io/docs/3.2/sql-reference/sql-functions/table-functions/files/


⚠ Bofrost.be has degraded performance

In 14cdebe, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 994 ms

Resolved: Bofrost.be performance has improved in 69f0139 after 13 minutes.


Fix: Corrected naming conflict.

Newer versions of leveldown's AbstractIterator have a _end function which was conflicting with an implementation variable in the redisdown implementation.
Losely referenced in #31  .
Still exploring why databases are not being created with independant document spaces.

@seigel apologies for letting this simple but crucial change waiting for so long here.
Many thanks!


Calling java method with incorrect params crashes with a JNI exception

Problem:
After trying to implement a library (http://writingminds.github.io/ffmpeg-android-java), and trying to call a method with the incorrect parameters

Calling the native API
ffmpeg.execute('-version', new MyCustomExecuteBinaryResponseHandler());

the application crashes abruptly with the following JNI exception:
JNI DETECTED ERROR IN APPLICATION: bad arguments passed to void com.github.hiteshsondhi88.libffmpeg.FFmpeg.execute(java.lang.String[], com.github.hiteshsondhi88.libffmpeg.FFmpegExecuteResponseHandler) (see above for details)

The exception indicates that the method was called with the wrong parameter types. The problem here is that the runtime should have thrown an exception which can be handled in debug configuration, showing an error activity instead.
Error: java.lang.Exception: Failed resolving method execute on class com.github.hiteshsondhi88.libffmpeg.FFmpeg

Debugging the callstack reveals that the CallJavaMethod https://github.com/NativeScript/android-runtime/blob/8d849ea6f15ab492ab83767eb15c429d8f9b7e04/runtime/src/main/jni/CallbackHandlers.cpp#L210 reads the method as resolved, as marked by the metadata generator, and doesn't compare the incoming parameters to those expected by the Java method in order to find the best-matching proper method, if any.
Repro steps:
Given the following simple Java class:
package com.tns;

public class TestJavaClass {
    public void callMeWithAString(java.lang.String[] cmd, Runnable arbitraryInterface) {
        String res = "I lied, call me with an array!";
        android.util.Log.d("Log", "callMeWithAString called.");
    }
}

Call in Js like so:
    let myClazz = new com.tns.TestJavaClass();

    myClazz.callMeWithAString("Here!", new java.lang.Runnable({ run: () => { }}));

Solution:
Investigate further why the method is considered resolved and doesn't check the arguments against the expected method signature.

Evaluate whether this "optimization" should remain, or go in favor of always resolving method overloads against the parameters passed. - Unlikely
Add signal handlers and throw an exception explaining how the user can debug the problem.

Registering signal handlers using NDK's signal() doesn't work the same between versions 17 and 26, tested on emulators. Also, if a signal handler is called, the signal may not necessarily be raised by a method that is not called correctly.

What we did was to implement signal handling for API versions > 25 as they don't crash after handling that signal. For now we've decided to go this way as adding additional logic for determining which overload exactly to call might result in a performance hit.

Does this mean that it just will silently ignore the issue on API > 25?   Or what exactly?

Nope it will show the Nativescript Exception page with the stack trace there instead of crashing the application.


Does feature selection filter tags and geometries?

Is it only a tag filter or also a geometry filter? Seems so, bu eg I created this job http://hot.geoweb.io/fr/exports/11625c6b-3eb2-4c2e-b800-2b7fa79c6d0b/ with only the transportation tag scheme, but the shp attribute tables, either with the generic OSM or with the HDM tag schemes, shows objects without any tag except building=yes what prevents to understand how they are supposed to be part of the transportation scheme. Missing an extra tag or missing in the transportation scheme?

I see the building=yes in planet_osm_point and planet_osm_polygon tables.. not sure what's happening there as they should not be included. Needs more investigation.

I tried to replicate this issue with the following export as the one that you created @severinmenard no longer exists:
http://export.hotosm.org/en/exports/c8abd4fa-e865-4db4-8ef2-8bf9de4f44be/
It seems as though the building tags are no longer being exported. Was this fixed in a release @bjohare or is it still happening elsewhere?

This should be resolved with the new YAML tag definition and the replacement of the "Thematic Shapefile" format, as well as the reimplementation of the tree tag filters.


global: migration to invenio-records-rest

Supersedes #6

It needs https://github.com/inveniosoftware/invenio-records-rest/pull/24


Added entry for contributor release

Updated index.md with the release notes of marketplace contributor application

We want it to be published on the release date. Also in case the release date changes will inform in advance.
Thanks


[cert-manager-1.14] CM-359 : Update operator CSV as required for the konflux

Changes are required for building images using konflux to comply with enterprise policy contract.

/test ci-index-cert-manager-operator-bundle

/test e2e-operator

/test e2e-operator

/label qe-approved

/lgtm
/approve

/label docs-approved
/label px-approved
No user facing chanages.


I'm trying to download Microsoft .Net 7 and when I got to the last step entering in code in the program.cs file and saving it into MyApp folder then it stated to run "dotnet run" again and I got an error message. How do I fix this? I'm only installing it because ArcGIS requires it for install.

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/edit
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

What is the error message that you got?
Also, this tutorial is more for people trying to learn how to code. If you're trying to install .NET because an application is required, can you share what is the dialog you get when you try to run the app?


Fixed issue #152

Summary
Changed the behaviour of Update state modal to show permission error just after opening
Ticket Link
https://github.com/mattermost/mattermost-plugin-servicenow/issues/152

Would you please merge master into your PR?

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (1746ccd) 65.40% compared to head (f2156e2) 65.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   65.40%   65.40%
=======================================
  Files          17       17
  Lines        2064     2064
=======================================
  Hits         1350     1350
  Misses        674      674
  Partials       40       40

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@mickmister Gentle reminder to review the PR.


Wrong checkout branch in the changelog action?

\begin{rant}
Sooo..... I have been having some issues with my release today (as always)....
I noticed, that:
https://github.com/ansys/actions/blob/d294898f629b4c0af8105659350fb24f83d08973/doc-deploy-changelog/action.yml#L321-L341
The branch pr_branch=maint/v${{ env.TAG_VERSION }}-changelog is created FROM main. See:
https://github.com/ansys/actions/blob/d294898f629b4c0af8105659350fb24f83d08973/doc-deploy-changelog/action.yml#L339
I do not think it should be like that... it should be from the tagged branch (release/v*** branch, or main if you are tagging main) to avoid conflicts in case you have to do quick commits to the release branch.
You might think "it is a bad practice commit to release branch"... I know but sometimes it is needed.
Context

The begining.
I had changelog rendering issues because some PR title were:
docs: adding warning about *mwrite. Update *vwrite warning to include *mwrite

Which of course, renders pretty badly in markdown... Don't blame me... it is MAPDL command style....

The "quick fix".
So I said... "OOkk.... The bot already opened the PR for the changelog in main, and I already merged it... okkkk well job German"....
(NOTE_1: can we change that?? to not open the PR updating main until the release is done?)....
I thought, "Ok... i will change quickly the markdown on the release branch, and I wil re-tag...." .. Oh man, I was naive.

The disaster.
Because what I mention above... the maint/v****-changelog branch being created from main... I have cherry-picking conflicts....

The solution.
I guess I could go to main, revert the changelog PR (to get back the changelog files), do the markdown changes there, and merge again in release... but that will bring the full commit history with it (changelog PR and its revert)... a mess....

\end{rant}
Requests
If possible, I would like to see the follwing changes:

Create maint/v${{ env.TAG_VERSION }}-changelog from the tagged branch (release or main)
[Extra] Delay opening changelog PR to main until the release is done.

Pinging @klmcadams @RobPasMue

The [extra] cannot be done easily: https://github.com/actions/runner/issues/1478

Technically, the only difference between the release branch and main should be the missing towncrier files, right? There's not a chance that there could be other code changes in the release branch that aren't reflected in main?

There might - I wouldn't perform this assumption @klmcadams - sometimes hot fixes are needed on release branches that are not  reflected on main.

The [extra] cannot be done easily

This is hard to control IMO - I would just "hold" merging it until the release is done so that you can close it in case something went wrong... You shouldn't be merging it until you are 100% sure your release went well - that's why we open a PR and not automatically merge to main @germa89 😄

I think your logic @klmcadams is right.. in theory, it should be OK.. but as @RobPasMue mentioned, sometimes you need to do small fix in release branches. Ofc this is not desirable, nor recommended, but sometimes you have to do it.
Furthermore, if don't think it

Since #598 has been closed, how are we going to address this?

Might be worth explaining it @klmcadams in tomorrow's meeting

Or next week xDDD


RANN indexing

Pretty good first cut at this function. Seems to work pretty good. Will get a vignette showing how it works in before merging.
This was fun -- just linking up the work to the issue. https://github.com/r-spatial/sf/issues/321#issuecomment-402198139

Thanks @jefferis !! RANN::nn2() is 💯 !!
https://github.com/jefferis/RANN


Honda Nidec: HUD set cruise speed doesn't always match UI

Fix bug - Affects only Honda Nidec with comma pedal: HUD set cruise speed doesn't always match UI max cruise speed when units is set to mph.
Description
Set cruise speed in KPH is rounded before sent to the HUD resulting in the HUD's conversion to MPH showing +-1 when the HUD is set to MPH. This happens at only specific set cruise speeds, such as 49 and 54mph are displayed on the HUD as 48 and 53 respectively. This only affects Honda Nidec vehicles with the comma pedal. Converting the speed to a MPH rounded integer and back to KPH before rounding the KPH and sending it over CAN ensures the HUD's conversion from KPH to MPH is correct. This fix takes into account if the units are set to metric or imperial.
Verification
I applied this fix and tested that the vehicle's HUD from 25mph to 70mph is matching comma's UI.

Will test this shortly. Has also bugged me to no end, thank you for doing these fixes @gadjex ! Up next, make the pedal actually accurate to the longitudinal plan. Currently it's terribly slow from a stop ;)

This doesn't work on my Nidec Honda. The set speed shown on the dash gets offset by 1 or 2 mph at all times, and is worse than before this PR. There still is a rounding issue on certain speeds like 84mph which you can reproduce in the comma Civic. It's probably a slightly off DBC scaling factor.

Closing since it's reported to not work on a Civic


Permit patching Operator Mono to succeed despite missing glyphs

In support of https://github.com/powerline/fonts/issues/154
Patching Operator Mono produced the following errors due to attempting to remove missing glyphs:
Traceback (most recent call last):
File "./powerline-fontpatcher", line 144, in
raise SystemExit(main(sys.argv[1:]))
File "./powerline-fontpatcher", line 141, in main
return patch_fonts(args.source_font, args.target_fonts, args.rename_font)
File "./powerline-fontpatcher", line 133, in patch_fonts
patch_one_font(source_font, target_font, rename_font)
File "./powerline-fontpatcher", line 117, in patch_one_font
target_font[0xFB01].removePosSub('*')  # fi ligature
TypeError: No such glyph
This commit first checks for the existence of glyphs 0xFB01 and 0xFB02 before attempting to remove them.

That think should be merged. I've lost like 2 hours trying to convert my 'operator mono' font.

@pie6k how to use fontpatcher ? I dowload the fontpatcher project and let the font in fontpatcher folder , i input the command in terminale
fontforge -script /Users/imac/Downloads/fontpatcher/setup.py OperatorMono-Book.otf

but console errorinvalid command name 'OperatorMono-Book.otf'
how to use fontpatcher ?

I don't know why this patch isn't merged. It works great.
Here's how I got things working (new install of MacOS X High Sierra 10.13.4).

Install Homebrew according to the one-liner on the brew.sh homepage
Install Fontforge and Python: brew install fontforge
Download the fontpatcher script and .sfd file from Github
Edit the fontpatcher script and change first line to: #!/usr/local/bin/python
Apply @emanuelhouse patch to the fontpatcher script
Patch all .otf files: ./powerline-fontpatcher.py --source-font powerline-symbols.sfd *.otf

This should be merged. I even covered this in a blog post I wrote two years ago. https://jsatk.us/vim-tmux-italics-and-insanity-9a96b69eeca6

can this be merged?


'NerfMLP' object has no attribute 'register_module'

@ldzhuang Maybe update your Pytorch version?

thank you very much


Staff of the Dreamlands

The Major & Greater versions include spell names that don't link to their actual spells.

Foundry 12.331
PF2 6.6.2

The non-linked spells are heightened versions of already linked spells in the item description. They're probably not linked as it would be redundant to include the links twice.

Fair; I wasn't sure how that was handled.


Clear cookies before loading dash app

Fixes https://github.com/plotly/streambed/issues/10938
This ensures that any auth related cookies are not re-used for different users.

[x] Tested on On Prem

@etpinard Please review..
cc: @chriddyp ..

Were you able to reproduce the situation @chriddyp experienced, and can you confirm that this fixes that exact issue?

Were you able to reproduce the situation @chriddyp experienced, and can you confirm that this fixes that exact issue?

Yes.

FWIW @chriddyp and I had discussed this on slack PM last-night, so it was easy to replicate the issue (and test the fix)

@JamesCropcho https://ci.appveyor.com/project/JamesCropcho/image-exporter/build/0.1.375 is failing for some reason off @tarzzz latest commit.
Could you (1) try to rebuild (2) give me access rights that allow rebuilding runs on AppVeyor.
Down the road, you should transfer that AppVeyor project to the plotly org or AppVeyorDashAdmin like falcon. Thank you.

thanks @JamesCropcho
Nice PR @tarzzz :dancer:


Add Sealed Secrets installation guide and usage example

Added installation instructions for Sealed Secrets using Kustomize along with example

QQ - If we're using Vault, why do we need this?


Texhnitium DNS

Hi,
Could you create an addon for Technitium DNS I do see they have an official docker image. I tried to create one but can't get it working? I'm a bit of a noob and don't want. To. Run it in. Portaner

Hi, Thanks for your interest in my addons. Usually I avoid creating a new addon when something similar already exists, and it seems to me adguard home already fulfils the need for a DNS based adguard. This is why it is preferable to use the Request templates : it sets labels and prevents it being closed as stale, and ensure that such questions are pre-checked. Hope you enjoy the repo! Have a nice day

Hi, thanks for the reply. Awesome Repo.


Use newer ARMv7 images from docker

Use the newer buster/sid base images as listed here instead of resin images (which are based on the deprecated armv7hf base images).
The distro variants also include a "slim" type. Not sure what changes it has.

Testing arm32v7/debian:sid-slim now.

Done in https://github.com/hamon-in/librtcdcpp/commit/f1ba6f130e415503a9664df5b0c2dd82d272e866


Need help with AUTH proxy!

Hi. First of all nice app! :)
Second i would like to ask you, how to proceed when a proxy has authentication (username and password). Can you kindly help me out, please?
Thanks

The VPNservice part is transplant from forbe/tun2http which written by C
It don't support AUTH proxy, and I'm unable to do secondary development
You can do transforming in nodejs (coding more easily than in C)
Just add 'Proxy-Authorization' to request headers
tunhttp <=> local NON-AUTH proxy (nodejs) <=> remote AUTH proxy


How can we apply tooltip for row data in dynamic react-bootstrap-tabel2

We have implemented Bootstrap Table dynamically but we are not able find how to set the tooltip to the row data for the particular column.

Hi @AllenFang ,
We have implemented Bootstrap Table dynamically but we are not able find how to set the tooltip to the row data for the particular column.
Thanks,
Keerthi.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 6d7277c, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 7842 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 6e6173f.


Media Element on iOS doesnt work when served redirected url

So, I made a sample test. I placed an 2 copies of audio file on my webserver. One copy of the file is in an easily accessible location, while the other copy can only be accessed via a php script. The php "redirection" is how i add a lil bit of obscurity to my media so anyone cant just steal my content.
Heres the issue, Android and Windows have no issues accessing the media using the php script but iOS cant. However, when the media is in an easily accessible location, the iOS version of mediaElement works just fine.
I think this also applies to IAudioPlayer since I'm getting the same behavior.
I'll also add that only in iOS, when I use a media element on an mp4 (served from that php file) i haven't played before, the video will play just fine the first time. However, when I leave that page and then return to that page (its a transient) to watch the same video, I get the play button with the arrow crossed out. I do not have this problem If I try to play that video in a webview on iOS.
So, I have a test project I can show this with, but Im not sure if what Im trying is "allowed" on iOS and I need to change my approach or change the settings or if its just a bug,

Thank you for the detailed explanation. You will likely get more information if you raise this as a bug on the toolkit repository https://github.com/CommunityToolkit/Maui. This is just the repository for the documentation and isn't monitored as well.

Indeed not a docs issue, please raise with the appropriate repository. Thanks!

sorry about that guys, here is the new link:
https://github.com/CommunityToolkit/Maui/issues/1898
you can close this one.


Where is the point of entry for the packet?

Hi,
I want to benchmark the time of treatment from the entry of the packet to the acknowledgement, and I'm searching the very begining breakpoint where the packet is received.
Thank you

Actual point of entry is somewhere in the Netty library. If we are talking about Traccar code, you can try frame decoder if the protocol you want to benchmark has it.


Bump builder-base EKS Go versions

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

DO NOT MERGE; we're holding this until after the EKS Go prod releases.

Could be a different pr, bur we need to bump the minimal images versions as well.

this is done


Game will not open

Thank you for your efforts at making a fantastic mod! I am a fan of you. Moving on, I have an issue with your mod. The game does not launch when menumode is set to 2 in the ini file. I assume this is because I do not have reshade. I think people who don't use reshade would find it helpful to know changing the menumode value to 1 or 0 in the ini will resolve this issue. If the game will not launch without reshade, then reshade should be listed in the requirements section. You say that it is only a requirement if certain mods are enabled, but my experience contradicts that. I had no other mods enabled and the issue persisted. I also cleansed the overwrite folder. Keep in mind I had SKSE build 2.0.20 correctly installed throughout this troubleshooting process.

Also made sure I was using Skyrim 1.5.97 and the current skse version

It has been stated many times, try MenuMode 0 or 1 and if it still fails install ReShade... the issue resides on the user end having external tools active on the system or even been messing with Steam itself.
Now I am no graphics expert (never said I was) but I know ReShade fixes whatever issue is happening. It would be nice if Bethesda would give me a break and stop updating the damn 10yr old game for no apparent reason I could actually research into it and other stuff instead of rewriting Improved Camera (third time now!)... Hint apparently there is another update coming but I think if it breaks IC again, I will only support 1.5.97/1.6.640/1.6.659.


some error thing on someone's mod

Describe your bug here.
states/TitleState.hx (line 125)
states/TitleState.hx (line 100)
flixel/util/FlxTimer.hx (line 230)
flixel/util/FlxTimer.hx (line 320)
flixel/FlxGame.hx (line 748)
flixel/FlxGame.hx (line 680)
flixel/FlxGame.hx (line 559)
openfl/events/EventDispatcher.hx (line 426)
openfl/display/DisplayObject.hx (line 1398)
Uncaught Error: Null Object Reference
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no. just putting some scripts

would you mind telling me what version it is
can't help you otherwise

0.7.3 sorry the problem fixed because i delete the save file


Added Terraform Container Apps Module

Additions:

New Terraform folder and files allows for deployment of the app to Azure.
Revised Dockerfile allows for preparing and building a suitable app image for use on Azure Container Apps.
New docker-compose.development.yml file to allow easy deployment of local Docker containers for testing.
New .env.development file to support docker compose deployment.

Adding @tim-wilde-nimble & @dneed-nimble


Manila: Add StorageClass parameter to specify NFS share client

The NFS share created by Manila provisioner is by default read/write by the world. This is not always welcome behaviour. I have added a new StorageClass option that allows to specify the NFS clients that would have access to the share.
Moreover the default value ('<IP_ADDRESS>/0') doesn't work with Ganesha NFS server as it doesn't seem to like the '/0' part so I changed the default to '<IP_ADDRESS>'
Manila provisioner recognizes a new StorageClass option to specify allowed NFS share client.

/lgtm

cc @dims

/approve

/lgtm


⚠ Jenkins Plugins Artifactory has degraded performance

In f0664c7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1221 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 11678de after 19 minutes.


release notes: high level sig-auth release notes for 1.8

cc @kubernetes/sig-auth-misc

/lgtm

Hope it's OK to take this one to merge; there was a conflict and I didn't want to perpetuate any more.

Argh, sorry, didn't notice this was merged.


Remove --allow-all-external

It's been removed in Pip version 10 and was deprecated (and no-oped) in
version 8
Fixes #509

Build setup fixed, but it has revealed more bugs.


Removing possible empty initialization of Granite.author

https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/905efac7fda3509f5535c05fc60fd2f5eb776846/content/src/main/content/jcr_root/apps/acs-commons/touchui-widgets/source/touchui-limit-parsys.js#L157
If someone who helped contribute to this item can help verify, that would be great!  Not positive why this initialization is there, and it's causing issues.
This line causes Granite.author to be initialized no matter what.  However, in all.js's setup of the file uploader, Granite.author (called ns.author there) is checked for initialization before proceeding.  Its empty initialization, then, breaks file uploader dialogs that are loaded in fullscreen dialogs.
For example, try loading up we.retail on a server with ACS commons installed, then try editing any image while your window is small enough that the editor opens in a full-screen separate URL.  The image uploader will not function due to a console error here:
    function getAllowUploadFromDesign(element) {         // In case the dialog has been opened outside of the Editor context, be conservative and restrict the upload         if (!ns.author) {             return;         }
This is not the case on any server where the above linked line has been removed.
Seems like any lines above referencing gAuthor already must be resilient enough to not need further error handling since they would already be failing on the empty object, so I'm just turning off the empty initialization here.

Coverage remained the same at 31.093% when pulling 47a767d5cd2c4b0f120731355eca682c69fa4bd7 on bkowalk:master into 476ff509666323ff055a5bbb3f36bbccd2f02798 on Adobe-Consulting-Services:master.

Coverage remained the same at 31.093% when pulling 47a767d5cd2c4b0f120731355eca682c69fa4bd7 on bkowalk:master into 476ff509666323ff055a5bbb3f36bbccd2f02798 on Adobe-Consulting-Services:master.

Coverage remained the same at 31.093% when pulling 47a767d5cd2c4b0f120731355eca682c69fa4bd7 on bkowalk:master into 476ff509666323ff055a5bbb3f36bbccd2f02798 on Adobe-Consulting-Services:master.

This was originally implemented in #677. Looking at that issue, I think @paul-bjorkstrand identified the root cause -- these widgets aren't in the right client library category. However, changing that at this point presents some compatibility challenges. So I think instead we need to just be careful about using the Granite.author object and use it as late as possible. So I created #1157 to address that more holistically. Can you take a look and confirm that fixes your issue (I tested based on your description and it seems to)? If so, I'd rather go that route and close this PR.

Closed since replaced by new and improved #1157


Flkelly powershell greenfield

Overview/Summary
This PR add PowerShell functionality to the greenfield deployment option.
This PR fixes/adds/changes/removes

Adds PowerShell functionality to the greenfield deployment
Breaks down greenfield into smaller pieces of code similar to "modules"

Breaking Changes

None

Testing Evidence

Run in FastTrack for Azure environments multiple times and is now the default tool for creating an SDDC in EMEA

As part of this Pull Request I have

[X] Checked for duplicate Pull Requests
[X] Ensured my code/branch is up-to-date with the latest changes in the main branch
[X] Performed testing and provided evidence.
[X] Updated relevant and associated documentation.

@prasad3017 - could you review when you get a chance?

@fskelly  kindly let us know @aarhoden-msft @fguerri  are able to test the code so that I can request Rene to review the code.

still awaiting feedback from @aarhoden-msft  @fguerri , will let everyone know once i have received this.

@sblair01 this is still going through testing. It looks like merged but will let @fskelly  confirm if we need to have a PR with the testing feedback


OneShot GPUParticles keep emitting in AnimationTree

Tested versions
Encountered after upgrading to Godot 4.3
System information
Godot v4.3.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 with Max-Q Design (NVIDIA; <IP_ADDRESS>61) - AMD Ryzen 9 4900HS with Radeon Graphics (16 Threads)
Issue description
When using an AnimationTree to play an animation which sets "emitting" to true on a one_shot GPUParticles3D, the particles keep emitting.
Steps to reproduce
Create a new scene.
Add GPUParticles3D node.
Set one_shot to TRUE,
Add a new ProcessMaterial, and draw_pass,

Add an AnimationPlayer,
Create a new animation with duration of ex. 3seconds. (make it bigger than the particle duration)
At 1 second, insert a property track and set the emitting property to true.

Add an AnimationTree with a new BlendTree as root
Add an animation node with the created animation. connect to the output node and done.
https://github.com/user-attachments/assets/4626451d-c3bb-4c74-9611-be4d58863305
Minimal reproduction project (MRP)
godot-4.3-test.zip

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

This looks like the same from #89730, so setting CallbackModeDiscrete to Dominant should do the trick


Signer can't sign on testing-preview network

Issue
On of the 2 signers of the testing-preview network can't sign at epoch 104 and generates this error message: ProtocolInitializerNotRegistered(CoreRegister(UnregisteredInitializer))
On the signer that does not sign:

The verification key associated to the protocol initializer matches the verification key sent with the pending certificate
The signer does not have a verification key for the next epoch in the aggregator, but it has one for the epoch after

It seems that the signer registration was affected to the wrong epoch

Short-term fix
⚠ We must re-genesis the certificate chain as an epoch gap has occurred

testing-preview network was re-genesis:
{"msg":"Started","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.045227835Z","hostname":"6449cac24273","pid":2617,"run_mode":"dev"}
Genesis bootstrap for test only!
{"msg":"BOOTSTRAP GENESIS command","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.077404763Z","hostname":"6449cac24273","pid":2617,"config":"GenesisConfiguration { cardano_cli_path: \"/app/bin/cardano-cli\", cardano_node_socket_path: \"/ipc/node.socket\", db_directory: \"/db\", network_magic: Some(42), network: \"preview\", protocol_parameters: ProtocolParameters { k: 2422, m: 20973, phi_f: 0.2 }, data_stores_directory: \"/mithril-aggregator/mithril/stores\", genesis_verification_key: \"5b3132372c37332c3132342c3136312c362c3133372c3133312c3231332c3230372c3131372c3139382c38352c3137362c3139392c3136322c3234312c36382c3132332c3131392c3134352c31332c3233322c3234332c34392c3232392c322c3234392c3230352c3230352c33392c3233352c34345d\", store_retention_limit: Some(5) }"}
{"msg":"check database version, database file = '/mithril-aggregator/mithril/stores/aggregator.sqlite3'","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.077670123Z","hostname":"6449cac24273","pid":2617}
{"msg":"database up to date","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.098289971Z","hostname":"6449cac24273","pid":2617}
{"msg":"New MithrilCertificateVerifier created","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.098652482Z","hostname":"6449cac24273","pid":2617}
{"msg":"New MultiSignerImpl created","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.098858991Z","hostname":"6449cac24273","pid":2617}
{"msg":"Update current_beacon to Beacon { network: \"preview\", epoch: Epoch(104), immutable_file_number: 2090 }","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.133944969Z","hostname":"6449cac24273","pid":2617}
{"msg":"Get next signers with stake","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.135159769Z","hostname":"6449cac24273","pid":2617}
{"msg":"Get next stake distribution","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.135424739Z","hostname":"6449cac24273","pid":2617}
{"msg":"Get stake distribution at epoch","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.135622879Z","hostname":"6449cac24273","pid":2617,"epoch":"Epoch(\n    104,\n)"}
{"msg":"Get next protocol parameters","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.135817379Z","hostname":"6449cac24273","pid":2617}
{"msg":"Get protocol parameters at epoch","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.136002249Z","hostname":"6449cac24273","pid":2617,"epoch":"Epoch(\n    104,\n)"}
{"msg":"Create clerk","v":0,"name":"slog-rs","level":20,"time":"2023-02-06T16:50:32.136183429Z","hostname":"6449cac24273","pid":2617}
Verify genesis certificate #3f81c17fd07016acbefd1dff7d3dd9acaf7f4c70bfb3d2a9f00325eef9fa7435 @ epoch #104

It looks like the error occurred in version 2304.0-prerelease as mentioned in the discord channel: https://discord.com/channels/826816523368005654/1014019542504185876/1068265164035604550


insert_all with source (+ update syntax)

Closes https://github.com/elixir-ecto/ecto/issues/4464
I also think we can make it work with selecting just a source. This could be useful if for instance you are trying to move data to a new table.

I messed up. fields is already translated to :source. I'll try to see if there's anything else I can do.

@josevalim thanks for the great feedback. i believe i addressed all of it :)

@greg-rychlewski I have been thinking about this PR and I am not really sure if we should support the update the syntax. The biggest issue is that, if you write this:
select: %{p | foo: 321}

It tells me you are selecting *all of p and updating the value of :foo. The fact we are selecting only a subset is a bit awkward to me, even though it is the most logical. What would we do if the user really wants to select all of them in the future? Sorry for not noticing this earlier, but we can probably keep the other warts of this PR (except the update)?

@josevalim I'll get the read_only -> writeable change done this week so we are not stuck not being able to release for long. In case someone asks you to


Added a login page (v25)

I have made a login page using HTML & CSS.

I have made this contribution for HacktoberFest - 2021.
Please review my PR #76 @Karl-LoginRadius @abhir9
Also, please add the hacktoberfest-accepted tag.
Thank you!


Enable HTTPS

I've never done that — is letsencrypt.org a good idea? I feel like I'd like to pair with someone else to get that up and running because all this is new to me.

Let's encrypt is a great idea, I'll help if you like. I've never implemented it either but feel confident about it.

AFAIK we need to get the keys from Let's Encrypt and them config the server… this second part, the server part is where I have no idea where to start. Would you like to get together to tackle this issue? We can set up a pair programming to check what we can get…

Do you control the server? Having ssh access is best but we can do it manually if we need to.

Yep, I have root access to our server (a droplet at Digital Ocean). The nginx config file I'm using is in the repo here for reference (just in case)…

Ok, I'm at work ATM. For another 6hrs unfortunately. I can be of more help when I get home. Have you seen the custom instructions here https://certbot.eff.org ?
Select nginx and then your operating system to get a head start.

I read over the ones for debian real quick and think after that you will just have auto renewing certificates installed. Then it's just a matter of setting up nginx.

Many thanks for the reference, @robjloranger! And don't worry about being available, we can talk asynchronously ; )
I read the nginx Certbot docs you sent and that clarified a bit… but I still have doubts when they say $ letsencrypt certonly --webroot -w /var/www/example -d example.com -d www.example.com -w /var/www/thing -d thing.is -d m.thing.is.
How does that work when nginx is used as a proxy for a gunicorn (Django) application? I mean where should I place files that are supposed to be in the root of the server when the root requests are handled by a gunicorn (or uwsgi) application?
Maybe the answer is the standalone version of the command (but that bit still unclear for me).

LetsEncrypt its a awesome option but CloudFlare is not enought?

I don't know the difference between encrypting stuff via Let's Encrypt and CloudFare (and TBH I just know CloudFare because of their CDN service).
My concern here is that people can browse documents from Brazilian government behind a HTTPS protocol to keep their privacy. This is what really matters.

@cuducos if you want to enable end-to-end HTTPS you need to enable it directly into server's nginx and its can be done with #12 when we deploy the new infra.
Anyway, I think CloudFlare is a good option to hide the servers location in case of DDoS.

CloudFlare is a good option to hide the servers in case of DDoS

That's important too. Do they offer this for free?

enable end-to-end HTTPS you need to enable it directly into server's nginx and its can be done with #12 when we deploy the new infra.

Awesome, gonna wait for #12 then!

Yep, they offer it on free but if you apply as an ONG we should get the ultimate master blaster hyper plan for free.

Yep, they offer it on free but if you apply as an ONG we should get the ultimate master blaster hyper plan for free.

Great, gonna get started then!

Just a quick note on this. On #18 I started a discussion about splitting the front-end and backend of Jarbas into (potentially) their own repository. @cuducos agreed to discuss that further after other issues on the repo got sorted (specially #12 ). If we were to host the front-end on Firebase, they give HTTPS free by default.
I'm not able to help much with the backend though, as all I ever did was buying certs and setting them up with Apache. But if we were to pair up for something, I'd be keen to actually get some hands on with lets encrypt or at least follow this issue and learn a bit more about it from what you guys manage to achieve 😉 (I'm not that sharp with Python or nginx, unfortunately).

Many thanks @leomeloxp.

If we were to host the front-end on Firebase, they give HTTPS free by default.

We got free droplets as a kind of sponsorship from Digital Ocean, so we're sticking with them.

But if we were to pair up for something, I'd be keen to actually get some hands on

Yay! I like that. As @pedrommone pointed out probably this issue is strictly related to #12, so I'll wait for it before spending time studying how to config nginx for HTTPS. But let's get back to that in a week maybe ; )

@cuducos let me know when you get there, I'll be happy to help

How Shared SSL Certificate for Cloud Flare Works? He delivery a domain like: someone.cloudflare.com or we can config mydomain.com to use https?

the only downside of letsencrypt, is that it does not support wildcards.
It supports unlimited number of domains and sub-domains.
But the sub-domains can not be dynamics.

@gwmoura they offer a full and customized SSL for you domain :)

excellent @pedrommone, I gonna test the service :smile:

Cloud Flare is non Tor friendly :(

I think CloudFlare was on the table just as a measure to protect ourselves from DDoS as raised by @pedrommone. I wasn't aware CloudFlare wasn't Tor friendly. But to be honest we might be too much worried with things that might happen, or might not happen (DDoS). I think privacy is a must (then HTTPS) and that Tor might help with privacy. So if I had to choose I'd leave the DDoS shield for later.
We're fully open source, if we're down anyone could serve the same thing with a few clicks — distributed systems are more reliable than centralized ones (that's one reason why we do open source with open data).

hello @cuducos i would like to help, i configured a https with a self signed certificate in my cloud service.
I too aplied to a  letsencrypt.org certificate but as i do not had a domain, (I use IP only for access). I could not use in my domain.
We can do it (in pair) and make some tests to see if it work.
I'm confident in trying to make a deploy with https protocol.

Many thanks, @danizavtz! In fact @gomex, @gwmoura and others are advancing with a Docker infrastructure for deploy. I think that you could coordinate to work with them there (we're using extract-nodejs branch) instead of thinking of the architecture currently in use at master — does that make sense to you?

Yes no problem. I was not aware of what was happening on that branch, latter I saw the discussion about docker integration.
I will try to coordinate better with them.
First I will try to make it run on my machine.
Thanks.

Many thanks @danizavtz! Soon (maybe later today) Docker stuff will me merged to master ; )

UPDATE: Docker stuff is already on master branch.

@danizavtz are you working on it? What are you did?
In my mind we can automate the generation of the certificate to be used by nginx and update the jarbas nginx image with the new certificate.

Hello, yesterday i tried run the jarbas locally on my machine, but i could not run this docker....
It gave me an error.
When i run the project with succes I will start a branch and do this job.
At night  will try again.

@danizavtz What was the error? Share it and we might fix it or help you get started ; )

Here is the error:
Removing intermediate container d8653fc3d5b4
Step 6 : COPY .env /code/.env
ERROR: Service 'jarbas' failed to build: lstat .env: no such file or directory
this directory [.env] does not exist in my jarbas folder.

Yay, you just helped us figuring out something wrong in nour documentation. The Settings is relevant to Docker users too, whe should reorganize that in the README.md. Thanks ; )

Hey @cuducos shall we create a new issue, with this error?
I should follow the rules for the local install to succeed?

@danizavtz its already created: #59

Now I copied the .env config and I could build the project using docker with success.
Now it gives me an error when i run the command:
docker-compose run --rm jarbas python manage.py loaddatasets
Here is the error:
return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: relation "core_document" does not exist
LINE 1: SELECT COUNT(*) AS "__count" FROM "core_document"
But i didn't run the command migrate, or make migrations, to create the tables in the database.

@danizavtz can you open an issue about the problem you're facing? Let's maintain the discussion here about the HTTPS. Thank you :)

But i didn't run the command migrate, or make migrations, to create the tables in the database.

No need to run makemigrations and migrate is aleeady in ran by the Dockerfile. Is your .env overriding docker-compose.yml's DATABASE_URL by any chance?
Please, let's follow @pedrommone's excellent suggestion: report that in a new issue to make it easier for the community ; )


Programming exercises: Fix instructions to prepare the tests for Gradle exercises locally

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context
The steps in the README for Gradle exercises that explains to instructors how they can set up the test, solution, and template repositories locally did not work.
Description
The issues in documentation were:

Missing settings.gradle file in the PLAIN_GRADLE repositories. ⇒ Gradle does not recognise the name when defining the dependency on the other template/solution module.
Adding the dependency to the plugins block in build.gradle does not work. ⇒ It has to be added to the dependencies block.

Additionally, instead of having the instructor to copy-paste from the readme, I already placed the relevant changes into the settings.gradle and build.gradle but commented them out.
Steps for Testing

Prerequisites:

1 Instructor

Create a new Java+Gradle programming exercise.
Clone the three -exercise, -solution, and -tests repositories.
Follow the steps in the readme.md of the -tests repository and make sure they work as intended.

At least for me locally, only four of the 13 defined tests pass for the solution.
This seems to be an issue with how the structural tests are handled in combination with Ares.
As long as ./gradlew test can be started without compiler errors, the fixes relevant for this PR work as intended.

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[x] Test 1
[x] Test 2

@SimonPaul02  That's another (not directly related) issue. The structural tests (the test that verify the test.json) seem to expect the student's classes in the assignment/src folder. With the described solution this is not the case. I personally don't think that that's a big issue though, since you can automatically generate this file on Artemis. There should be not much need to run these tests locally.

@SimonPaul02 That's another (not directly related) issue. The structural tests (the test that verify the test.json) seem to expect the student's classes in the assignment/src folder. With the described solution this is not the case. I personally don't think that that's a big issue though, since you can automatically generate this file on Artemis. There should be not much need to run these tests locally.

To give some context. Before executing the build plan, the source files from the template, student, or solution-repository are copied into assignment/src of the test repo, and then the actual build execution starts.
You could fix the behavior locally by setting the value to point to the source folder in the solution repository. E.g:
def assignmentSrcDir = "../oletestgradle-solution/src" (l. 23, build.gradle in test repository).
You could consider also adding this in some form to the README but I think it is not a big issue.

As the tests can be fixed by explaining the necessary change of just one option in the build.gradle, I now added it to the readme.


Added a few new Background Images to the Title Screen

Added 3 new Background Images for the Title Screen

@Flustix what do you think about those images? Do they fit?

yesh