Installation failed due to missing system dependencies missing

System:
Debian 10
node v14.16.1 and v16.1.0 (installed via nvm)
On my machine installation failed due to missing dependencies of the canvas package, the log file did not  contain anything useful.
I fixed that by installing the relevant system dependencies for canvas, see instructions here: https://www.npmjs.com/package/canvas
janus@janus-latitude:~/grundfos/zap$ npm install
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

><EMAIL_ADDRESS>postinstall /home/janus/grundfos/zap
> electron-builder install-app-deps && husky install

  • electron-builder  version=22.10.5
  • loaded configuration  file=package.json ("build" field)
  • rebuilding native dependencies<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>platform=linux arch=x64
  ⨯ cannot execute  cause=exit status 1
                    out=
    ><EMAIL_ADDRESS>install /home/janus/grundfos/zap/node_modules/bufferutil
    > node-gyp-build

    ><EMAIL_ADDRESS>install /home/janus/grundfos/zap/node_modules/canvas
    > node-pre-gyp install --fallback-to-build

    Failed to execute '/home/janus/.nvm/versions/node/v14.16.1/bin/node /home/janus/.nvm/versions/node/v14.16.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/home/janus/grundfos/zap/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/home/janus/grundfos/zap/node_modules/canvas/build/Release --napi_version=7 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=electron-v12.0' (1)

                    errorOut=node-pre-gyp WARN Using request for node-pre-gyp https download
    node-pre-gyp WARN Tried to download(404): https://github.com/Automattic/node-canvas/releases/download/v2.7.0/canvas-v2.7.0-electron-v12.0-linux-glibc-x64.tar.gz
    node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(electron-v12.0 ABI, glibc) (falling back to source compile with node-gyp)
    Package pixman-1 was not found in the pkg-config search path.
    Perhaps you should add the directory containing `pixman-1.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'pixman-1' found
    gyp: Call to 'pkg-config pixman-1 --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
    gyp ERR! configure error
    gyp ERR! stack Error: `gyp` failed with exit code: 1
    gyp ERR! stack     at ChildProcess.onCpExit (/home/janus/.nvm/versions/node/v14.16.1/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
    gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
    gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
    gyp ERR! System Linux 5.10.0-5-amd64
    gyp ERR! command "/home/janus/.nvm/versions/node/v14.16.1/bin/node" "/home/janus/.nvm/versions/node/v14.16.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--module=/home/janus/grundfos/zap/node_modules/canvas/build/Release/canvas.node" "--module_name=canvas" "--module_path=/home/janus/grundfos/zap/node_modules/canvas/build/Release" "--napi_version=7" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=electron-v12.0"
    gyp ERR! cwd /home/janus/grundfos/zap/node_modules/canvas
    gyp ERR! node -v v14.16.1
    gyp ERR! node-gyp -v v5.1.0
    gyp ERR! not ok
    node-pre-gyp ERR! build error
    node-pre-gyp ERR! stack Error: Failed to execute '/home/janus/.nvm/versions/node/v14.16.1/bin/node /home/janus/.nvm/versions/node/v14.16.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/home/janus/grundfos/zap/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/home/janus/grundfos/zap/node_modules/canvas/build/Release --napi_version=7 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=electron-v12.0' (1)
    node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/home/janus/grundfos/zap/node_modules/canvas/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
    node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
    node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1048:16)
    node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
    node-pre-gyp ERR! System Linux 5.10.0-5-amd64
    node-pre-gyp ERR! command "/home/janus/.nvm/versions/node/v14.16.1/bin/node" "/home/janus/grundfos/zap/node_modules/canvas/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
    node-pre-gyp ERR! cwd /home/janus/grundfos/zap/node_modules/canvas

```    node-pre-gyp ERR! node -v v14.16.1
    node-pre-gyp ERR! node-pre-gyp -v v0.15.0
    node-pre-gyp ERR! not ok
    npm ERR! code ELIFECYCLE
    npm ERR! errno 1
    npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
    npm ERR! Exit status 1
    npm ERR!
    npm ERR! Failed at the<EMAIL_ADDRESS>install script.
    npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

    npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/janus/.npm/_logs/2021-05-06T10_07_44_904Z-debug.log

I also just tried to install zap on windows, where it failed because I dont have MSVS for compiling canvas :/

@janusheide : there is a document doc/faq.md in the repo, and it has a section "How to make this work on Windows?"
Did you try that and it still failed?
I will admit that we do not have a lot of Windows users. Entire development team is on Windows or Macs. But that should not be an excuse. We have to make this work on Windows as well.

@tecimovic Personally I am running on Linux, but I am sitting in a department where Windows is the default, hence my attempt at Windows.
I did not read the specific guide for Windows, I just followed the readme :) Thanks for the pointer! It looks a bit manual, I know one of my collegues have it up and running via WSL(2) I dont know if that would be sufficient Windows support for you, but it might be easier than a "native" Windows install?

Yeah, Windows at this point is a problem. I am also 100% on Linux, and every other contributor to zap, from what I know, is also on Linux or Mac.
We are running an internal build at Silicon Labs on a Jenkins that makes Windows and Mac binary packages and out of each build. I have not yet figured out how to make that run on a public github CI, so github CI currently still just serves the Linux .deb and .rpm binaries.
So if you need a Windows binary I can definitely send it to you, but in the long run, obviously, we have to figure out how to make github itself build it and make it available.
If you figure anything out and make life for Windows users easier, PLEASE, do add any instructions to that faq MD right there!
The core team which is developing this is sorely lacking any Windows users, so we'd be more than happy to get any kind of help in that area.


updates for 0.9.1

I did this pretty mechanically, following warnings and errors and fixing them appropriately.

@Thimoteus Thanks you! The build is not passing, however. Can you look into that?

Looks like the package.json needs a few updates for a new pulp and purescript.
While you're in there, could you:

Add a purescript-psa dependency, and build with pulp build --censor-lib --strict please? Something like we have in strongcheck.
Update Travis to build first then test, also like we have in strongcheck. (This ensures we're not accidentally relying on a devDependency in the library).

Thanks!

Wow, that package.json had some old stuff. I'll try to get this working on travis then squash once it works.

@Thimoteus Thanks!
@garyb This looks good to me, any comments?

Looks great, thanks!


Report

Ch6: KhattTech Mobile Application (Ahmad)

[ ] Integration and Testing
[ ] User Interface
[ ] User Manual

[ ] Ch4: KHATT Data Analysis
[ ] Descriptive Analysis
[ ] Assessing Data Quality
[ ] Data Processing

Edit: Contents, Figures, Acknowledgments, Abstract, Technologies used, Overview of the Report, Relevant Theory, Systematic Literature Review, Related Works, Comparative Analysis(mobile apps), Product Description, Functional Decomposition, Optimization, Conclusion. ((References: Journals Papers, Websites Articles Appendices)) (Add GitHub Organization)

Ch5: Data Modeling

[ ] Model Archeticture,
[ ] Model Training and Testing,
[ ]  Model Evaluation and Fine-Tuning,
[ ] Exporting Model &  Deployment


UnauthorizedAccessException updating file

Hi, I hit the following error:
Debug	Creating Temp directory C:\Users\Tomer\AppData\Local\Temp\149a22f3-9195-4577-aab9-43f79a89c9d0
Debug	FileUpdateTask: Downloading foo.exe with BaseUrl of http://localhost:8888 to C:\Users\Tomer\AppData\Local\Temp\149a22f3-9195-
Debug	FileUpdateTask: Prepared successfully; destination file: C:\Users\Tomer\bar\foo.exe
Debug	Starting to process cold updates...
Debug	Update process name: 'NAppUpdateProcess'
Debug	Loading C:\Users\Tomer\AppData\Local\Temp\149a22f3-9195-4577-aab9-43f79a89c9d0\foo.exe
Debug		Skipping (part of current execution)
Debug	Loading C:\Users\Tomer\AppData\Local\Temp\149a22f3-9195-4577-aab9-43f79a89c9d0\NAppUpdate.Framework.dll
Debug		Skipping (part of current execution)
Debug	The application has terminated (as expected)
Debug	Got 1 task objects
Debug	Task "": RequiresAppRestart
Debug		Executing...
Error
Could not replace the file
System.UnauthorizedAccessException: Access to the path 'C:\Users\Tomer\bar\foo.exe' is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.File.Delete(String path)
at NAppUpdate.Framework.Tasks.FileUpdateTask.Execute(Boolean coldRun)
Debug		Task execution failed
Error	Update failed
Debug	Re-launching process C:\Users\Tomer\bar\foo.exe with working dir C:\Users\Tomer\bar
I am using the latest sources from github.
Thanks,
Tomer

The problem seems to be when updater is faster to try to replace files than the OS is to release locks on the files after the mutex has been released.
I have proposed a fix in #86

This fix has been merged and will be released in <IP_ADDRESS>

Awesome, looks great! Thanks!


Use a NAM icon instead of the iPlug2 icon

Thanks!
IMO (as someone who's not done this before), this is a surprising number of changes. Mind if I ask while we're here how to know all of the things that have to be done in order to change the icon?
I'd love to have a checklist to go on in case we make changes here in the future. Or is there any "secret" to lighten the cognitive load vs looking at the changes here and trying to mimic them move-for-move from the bottom up?

For windows, it's just one file, the .ico. .icns is the old macOS format, which is still used as part of the build scripts. .iconset folder is the new approach for iOS and macOS. On iOS it just requires a 1024x1024 image nowadays, but on macOS, it requires multiple different files. Fortunately, you can use various programs and websites to spit out all of these files from a single input file. Bear in mind, however, that nowadays, the iOS icon kits rounded corners from the OS, where as the other platforms require you to include the rounded corners in the image.


Update Set-SPOTenant.md

EnableVersionExpirationSetting parameter is now disabled but not removed, since the Version History Policy is generally available for all tenants (automatically enabled featured)

@microsoft-github-policy-service agree company="Microsoft"


[QUE] Incorrect behaviour when job fails

In case a job fails the agent incorrectly considers that as a delay in a queue. In results, a queue gets scaled up to the limits.

Thanks @meceo! I'll get a fix out today.

@meceo I have a fix for this in a branch. Are you able to see if this fixes the issue?
gem 'rails_autoscale_agent', github: 'adamlogic/rails_autoscale_agent', branch: 'que-ignore-retries'


[Doc] add examples of "

Add examples for how to use metrics
Reference: https://github.com/streamnative/apache-pulsar-grafana-dashboard/tree/master/dashboards

@Anonymitaet  same to #13588 ?

Oh yes, it's a mistake, I'll close this. Thanks for reminding me. @mattisonchao


GO term GO:0031297 (replication fork processing) Definition Issue

When I look on QuickGO and AmiGO, the definition for the term GO:0031297 (replication fork processing) is "The process in which a DNA replication fork that has stalled is to a functional state and replication is restarted..." I believe that there is an error in this definition and it should read "The process in which a DNA replication fork that has stalled is RESTORED to a functional state and replication is restarted..."

also reported in #12626

Fixed


New command: spo file version get

Usage
m365 spo file version get [options]
Description
Retrieves specified version of a file from version history
Options

Option
Description

-w, --webUrl <webUrl>
The URL of the site where the file is located

--versionLabel <versionLabel>
Version label of version which will be retrieved

-u, --fileUrl [fileUrl]
The server-relative URL of the file to retrieve. Specify either fileUrl or fileId but not both

--fileId [fileId]
The UniqueId (GUID) of the file to retrieve. Specify either fileUrl or fileId but not both

Examples
Lists file specified version from version history by id
m365 spo file version get --webUrl https://contoso.sharepoint.com/sites/project-x --versionLabel "0.1" --fileId 'b2307a39-e878-458b-bc90-03bc578531d6'

Lists file specified version from version history by url
m365 spo file version get --webUrl https://contoso.sharepoint.com/sites/project-x  --versionLabel "0.1" --fileUrl '/sites/project-x/documents/Test1.docx'

Additional Info
we may reuse spo file get command with asListItem option to get the item id and then we may use this endpoint to achieve this (filled with sample data)
/_api/web/Lists/getbytitle('Documents')/items(18)/versions/?$filter=VersionLabel eq '1.0'&$top=1

@pnp/cli-for-microsoft-365-maintainers any comments?

Haven't checked it yet, but can't you use a specific API request like
.../items(18)/versions/<version number>?

Haven't checked it yet, but can't you use a specific API request like
.../items(18)/versions/<version number>?
Or GetByLabel(...)
Besides that, looks good 👍

Thanks for the comment. Will double check 👍🙂

you can get a version based on the versionId parameter like
/_api/web/Lists/getbytitle('Documents')/items(18)/versions(512)
where version 1.0 is equal to 512, version 2.0 is equal to 1024 and so on

you can get a version based on the versionId parameter like
/_api/web/Lists/getbytitle('Documents')/items(18)/versions(512)
where version 1.0 is equal to 512, version 2.0 is equal to 1024 and so on
There seems not to be a resource for request with GetByLabel(...) but you could use /_api/web/Lists/getbytitle('Documents')/items(18)/versions/?$filter=VersionLabel eq '1.0'

Thanks @nicodecleyre for the double check 👍.
I had versionlabel in mind that's why used them in the examples, but forgot to update the endpoint url in the additional info 😉.
I think it's better we base on version labels rather then id

I think it's better we base on version labels rather than id

Indeed, just looked a bit around, I think there is no better way to get a version by label so 👍

One small remark is that versionLabel should be called label according to our naming convention.

One small remark is that versionLabel should be called label according to our naming convention.

Corrected 👍
Thanks 🤩

Opening this up 💪

Can I work on this one?

Sure @nicodecleyre!
Thank you!


is there a way  we can show the  existing screen in the background  and just the spinner on top of it ?

Here it keeps the old screen there , it just adds the spinner on the screen

@jpca999 if using react-navigation, try setting the cardStyle backgroundColor to 'rgba(0,0,0,0). Or in general, make sure your new screen has an opaque background so the previous stack / route can stay visible.


Feature/like functionality

For this feature, the following changes were introduced:

When the page loads the number of likes for each item is requested to the involvement API and displayed below each corresponding like button
Clicking on the like icon generates a POST request to the involvement API to register a new like for the given item and updates the displayed counter. For now, this event only triggers once

Optional To-do: The info about what items the user has liked is not registered in any way yet. After we finish the mandatory requirements let's try to persist this data with localStorage  👨💻

Your feature branch is complete! 👍💯🎉
Highlights:
Well-written PR description ✔
Proper use of Gitflow ✔
💯 great job 👏
I like the UX design that is changed when the like button is clicked 👍


Rubocop 1 47

Updates Rubocop and Rubocop extensions
Fixes some new offenses
Updates the Rubocop todo file

Coverage: 93.527%. Remained the same when pulling 1f17406d64feb21a17709587ed7e4c26c4cad326 on jdc-rubocop-1_47 into 4f05d9bffb43c278285785bf982e820d1db29672 on main.


memory leak of direct memory

Bug Report
io.lettuce.core.RedisException: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 524288000 byte(s) of direct memory (used: 553648128, max:<PHONE_NUMBER>)"}.
Current Behavior
when springboot application with lettuce to connect redis to retrieve big key It happens

use lettuce pool  to connect redis

Allocating big chunks of direct memory can cause these issues if the memory setup doesn't match your capacity. You can try to switch to heap buffers by setting -Dio.netty.noPreferDirect=true.


powermanager - Allow forcing monotonic battery voltage/percentage

Thanks! As @rigrig says, please could you add a Math.round(...) call in there? It's possible that other things (eg widgets that just print the percentage) will get broken by having non-integer values

Thanks!


Mixed datatypes Dataset.to_netcdf()

Not sure if this is intended, but when I try to save a Dataset to netCDF using Dataset.to_netcdf(), it produces the following error: ValueError: could not convert string to float: 'a'
This seems to be due to forcing datatypes to be equal to the datatype of the first column encountered. See below a simple working example.
MCVE Code Sample

import pandas as pd
import xarray as xr

df = pd.DataFrame()
df['Values' ] = [1.0,2.0,3.0]
df['Strings'] = ['a','b','c']

da = xr.DataArray(df)
ds = xr.Dataset()
ds['A'] = da
ds.to_netcdf('A.nc')

Expected Output
Gianmarcos-MacBook-Pro-2:examples gian$ python3 test_xarray.py
Traceback (most recent call last):
File "test_xarray.py", line 11, in
ds.to_netcdf('A.nc')
File "/usr/local/lib/python3.7/site-packages/xarray/core/dataset.py", line 1232, in to_netcdf
compute=compute)
File "/usr/local/lib/python3.7/site-packages/xarray/backends/api.py", line 749, in to_netcdf
unlimited_dims=unlimited_dims)
File "/usr/local/lib/python3.7/site-packages/xarray/backends/api.py", line 792, in dump_to_store
unlimited_dims=unlimited_dims)
File "/usr/local/lib/python3.7/site-packages/xarray/backends/common.py", line 261, in store
variables, attributes = self.encode(variables, attributes)
File "/usr/local/lib/python3.7/site-packages/xarray/backends/common.py", line 347, in encode
variables, attributes = cf_encoder(variables, attributes)
File "/usr/local/lib/python3.7/site-packages/xarray/conventions.py", line 605, in cf_encoder
for k, v in iteritems(variables))
File "/usr/local/lib/python3.7/site-packages/xarray/conventions.py", line 605, in
for k, v in iteritems(variables))
File "/usr/local/lib/python3.7/site-packages/xarray/conventions.py", line 241, in encode_cf_variable
var = ensure_dtype_not_object(var, name=name)
File "/usr/local/lib/python3.7/site-packages/xarray/conventions.py", line 201, in ensure_dtype_not_object
data = _copy_with_dtype(data, dtype=_infer_dtype(data, name))
File "/usr/local/lib/python3.7/site-packages/xarray/conventions.py", line 160, in _copy_with_dtype
result[...] = data
ValueError: could not convert string to float: 'a'
Problem Description
It should be able to save the file into netcdf format?
 If you create two arrays, it can be written to disk:
a = df["Values"].to_xarray()
b = df["Strings"].to_xarray()
ds = xr.merge([a, b])
ds.to_netcdf('A.nc')

Thanks @mathause .
Closing, please reopen with outstanding questions

Thank you both.


add config option to hide powered by

hide powered by header by default but allow a header to be passed. Alternately it can be explicitly turned on with a true config value.

#124 was closed because it was to the wrong target branch.

issue fixed and on the slate for release in Amstel Gold Race 2.1.0


Typo:fix some duplication problems in docs

Coverage increased (+0.004%) to 24.595% when pulling 42c87744ee6be7aa87d0aea8defeb653082f9f7b on JaredTan95:patch-1 into cc664175e29e7584960bf5b1f9eaa880602e4fa2 on apache:master.


Saved stories dissappear when filtering by 'like'

Saved stories are filtered out when the full feed is filtered to 'liked' stories only (slider moved to green).
See video at: http://dl.dropbox.com/u/83288/newsblur_favourites.7z

This has been fixed. Thanks for letting me know.


Feature Request: Lines of Code warning

I didn't see a rule about this.
Could we have a rule that gave a warning/info if the number of lines of code in a procedure exceeds a definable value?  I would default it to something like 40 or 50 and have a setting for it in LinterCop.json.
Too many lines of code in a procedure can imply that the code could be functionalized better.

I think rule LC011 might cover that mostly, not? 😊
The maintainability index incorporates the "lines of code" in the calculation.

I agree but a lot of things go into Maintainability Index.  A Lines of Code metric is a simpler measure to understand.  Reducing lines of code will affect Maintainability Index without having to try and dissect what goes into the Maintainability Index.

Not so sure how much value that rule would be of.
From my experience, when a procedure has a warning about complexity, and you refactor that function to be less complex, you do not need to care what exactly is used to calculate complexity.
Can you give an example where you would consider a procedure nice an readable but still get the warning?

I just feel it is a simpler metric than MI or CC to understand.  With a "good" MI ranging from 20 - 100 it is difficult to explain that it can be made better.  If MI is over 20 then a developer thinks great, that is good code, but it can have 40 lines of code in a procedure and that is likely less good than it could be.

Then again, 40 maybe even 80 lines of code in one procedure may be perfectly valid at one point but a complete mess in another point.
Expecially when moving data and filling a lot of fields, you quickly have a lot of code. In such an example, for me, it would be bad code if that gets split just to avoid a no of lines warning.
I dont think that I would want to add this to the linter, because 1 its (mostly) covered by the Code Complexity warning we already have, and 2 because I think this metric could be even too simple and generate to many false postives.
But I do plan to do a stram/video maybe session at Dynamics con or something where I show how everyone can create their own analyzers and this maybe a good example rule

That's fine @StefanMaron.  Sounds like a great idea for a session.


Add path to Netlify CMS invite email

Description
Currently, Netlify Identity invite email link points to wargabantuwarga.com/#invite_token=xxxxx, which does not do anything as the netlify-identity-widget script is in the admin page.
Expected Behaviour
The invite email link should point to the admin page instead of the home page: wargabantuwarga.com/admin/#invite_token=xxxxx
This can be low priority; but in the meantime we should inform contributors who are given Netlify CMS access via email invite to open the admin page with the invite_token hash if they are unable to login.
Additional Information
Reference: https://answers.netlify.com/t/common-issue-netlify-cms-git-gateway-email-not-confirmed/10690

In the meantime, as long as they watch my videos here, they should be able to overcome this issue manually. 😅


feat: add the sprocket format command.

This commit adds the format command to sprocket.
The command will format a single WDL document.
Also updated the existing commands to the latest WDL API and corrected the environment variable name for publishing crates.
Included the analysis rules in sprocket explain; the list of rules is now sorted by id.
Before submitting this PR, please make sure:

[x] You have added a few sentences describing the PR here.
[x] You have added yourself or the appropriate individual as the assignee.
[x] You have added at least one relevant code reviewer to the PR.
[x] Your code builds clean without any errors or warnings.
[x] You have added tests (when appropriate).
[x] You have updated the README or other documentation to account for these changes (when appropriate).

Once the wdl crate publishes, I'll update this to reference it from crates.io.

I'll update it to replace the file; perhaps add a --print option to print it to stdout instead?

I was looking forward to running sprocket format . from the root of the workflows repo and timing it 😅 but I can see a new user running a similar command (without source control) and being really pissed at us for reformatting every WDL file. I'm conflicted on the right approach.

How about we default to printing, which can only be done with a single file (it errors if you pass it a path that's a directory).
We add a --overwrite option that overwrites the file instead of printing it; if that option is supplied, we allow it to operate on a path that is a directory.

How about we default to printing, which can only be done with a single file (it errors if you pass it a path that's a directory).
We add a --overwrite option that overwrites the file instead of printing it; if that option is supplied, we allow it to operate on a path that is a directory.

Yea I like that. I think that's reasonable.


Add default tag

@FL33TW00D Brought up a good point about defaults.  I think that after the Option, Box switch is made we should try to add the Default tag to the generated structs, just like we do with Debug.
Thoughts?

I agree. The fundamental tradeoff with this library is the size of the crate due to the massive volume of code that serde generates. This will obviously exacerbate things further, however for the minute, while we are using Box everywhere, I believe the tradeoff is worth it.

Also, as a sidenote, I've been ill with COVID over the holidays so that big block of time I was hoping to spend on this disappeared :( but I have managed to clear out the pull request backlog and close some issues.

I had some time to have a look at the implications of adding default to the code. My assumption was that this was negligible, but I wanted to get some data on it:
# current
> cargo expand --features runtime-async-std-surf | wc -l
730432
# with default
> cargo expand --features runtime-async-std-surf | wc -l
740943

Relatively minimal cost for a fairly major benefit imo


[Proposal] keep ui and raster thread on fast CPUs, keep work threads on slow CPUs

On many mobile devices, the L1 caches reside on specific CPUs, and L2 caches reside on the set of CPUs that share a clock.
Keeping ui and raster thread on fast CPUs will help to maximize L2 cache hits and operate at faster speed.
There is a trade off to this as we will incur more power usage when running on fast CPUs.
See also:
https://developer.android.com/games/optimize?hl=zh-tw#keep-mem-heavy-threads-one-cpu
https://developer.android.com/games/optimize?hl=zh-tw#defer-work-to-slow-cpus
I create this PR as a proof of concept implementation base on swappy.
Here's the flutter_gallery__transitions_perf benchmark report on a HUAWEI ELS AN00 phone
Before
 "average_frame_build_time_millis": 6.579668269230771,
  "90th_percentile_frame_build_time_millis": 10.818,
  "99th_percentile_frame_build_time_millis": 23.7,
  "worst_frame_build_time_millis": 140.948,
  "missed_frame_build_budget_count": 9,
  "average_frame_rasterizer_time_millis": 16.873414457831323,
  "90th_percentile_frame_rasterizer_time_millis": 20.421,
  "99th_percentile_frame_rasterizer_time_millis": 53.492,
  "worst_frame_rasterizer_time_millis": 104.351,
  "missed_frame_rasterizer_budget_count": 181,
  "frame_count": 416,
  "frame_rasterizer_count": 415,

  "average_frame_build_time_millis": 6.523223277909746,
  "90th_percentile_frame_build_time_millis": 10.393,
  "99th_percentile_frame_build_time_millis": 33.673,
  "worst_frame_build_time_millis": 124.373,
  "missed_frame_build_budget_count": 10,
  "average_frame_rasterizer_time_millis": 16.824433333333342,
  "90th_percentile_frame_rasterizer_time_millis": 19.946,
  "99th_percentile_frame_rasterizer_time_millis": 52.629,
  "worst_frame_rasterizer_time_millis": 101.326,
  "missed_frame_rasterizer_budget_count": 177,
  "frame_count": 421,
  "frame_rasterizer_count": 420,

After
 "average_frame_build_time_millis": 4.494899521531101,
  "90th_percentile_frame_build_time_millis": 8.089,
  "99th_percentile_frame_build_time_millis": 14.804,
  "worst_frame_build_time_millis": 107.017,
  "missed_frame_build_budget_count": 4,
  "average_frame_rasterizer_time_millis": 17.21504086538461,
  "90th_percentile_frame_rasterizer_time_millis": 21.238,
  "99th_percentile_frame_rasterizer_time_millis": 56.181,
  "worst_frame_rasterizer_time_millis": 87.671,
  "missed_frame_rasterizer_budget_count": 186,
  "frame_count": 418,
  "frame_rasterizer_count": 416,

  "average_frame_build_time_millis": 4.61509478672986,
  "90th_percentile_frame_build_time_millis": 8.691,
  "99th_percentile_frame_build_time_millis": 15.92,
  "worst_frame_build_time_millis": 123.315,
  "missed_frame_build_budget_count": 4,
  "average_frame_rasterizer_time_millis": 16.785314285714286,
  "90th_percentile_frame_rasterizer_time_millis": 20.222,
  "99th_percentile_frame_rasterizer_time_millis": 52.744,
  "worst_frame_rasterizer_time_millis": 101.359,
  "missed_frame_rasterizer_budget_count": 181,
  "frame_count": 422,
  "frame_rasterizer_count": 420,

We can see the obvious optimization of frame_build_time, but no  effect of frame_rasterizer_time.
I use perfetto to see which cpu the thread runs on, before the ui thread runs on slow cpus, and after it runs on  fast cpus.

I'm curious about how much value we really get out of the raster thread having affinity on the big cores - I don't think I've seen a lot of evidence that it's doing particularly CPU intensive work commonly.


Few seconds Lags with BotFramework / Facebook

Hi,
Here is my architecture:

LUIS Server
Small Azure server
MSBot Framework Server
Facebook Bot Serveur
Desktop / Mobile apps

When I test my bot (since few months) I see lot's of lags, few seconds to get an answer.
With the emulator on my machine it's very fast.
Do you have the same issue ? Is there a parameter ? Few month ago there was a delay in the MSBot code.

You might consider App Insights to track the time spent in your dependencies to narrow down the time spent to a single component.

I'm using NodeJS not C#.
I tried some test, it seems the delay is dispatch between Facebook and my
server.
I know at the begining of MSBot Framework thre was a parameter to delay the
answer somewhere. But I don't know if it's still there.
On Thu, Sep 1, 2016 at 8:09 PM, Will Portnoy<EMAIL_ADDRESS>wrote:

You might consider App Insights to track the time spent in your
dependencies to narrow down the time spent to a single component.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder/issues/1144#issuecomment-244163241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFog5KJ8rluTBDyoawBFT62Z90UMXCDks5qlxS_gaJpZM4JywZk
.

--
Jean-Philippe Encausse - R&D / IoT / Innovations
http://www.encausse.net - http://arm-avocats.fr
Twitter: @JpEncausse - Mob: +33 6 82 12 56 99
Do it Once, Use it Twice ~ Do it Twice, Make It Once

Right, I believe the node version will "latency batch" the messages for 250 ms.  @Stevenic or @muzahmed  can you comment more?

@JpEncausse you can play around with the autoBatchDelay on the IUniversalCallBotSettings
its defaulted to 250ms as @willportnoy mentioned, but you can configure as needed
I'm closing this issue, but feel free to open/comment if you're having other issues


Logger levels cannot be changed

We are using the Knapsack rake task to start our RSpec test suite:
rake knapsack:rspec

Knapsack is putting a lot of information into our build output, due to the Knapsack.logger.level begin set to INFO. I've tried changing this level to a lower setting, but because Knapsack is calling the logger from the rake task, there is no way to influence the logger level.
Is there any way to lower the logger level for the rake task? Maybe an environment variable can be introduced to influence the log level?

Maybe an environment variable can be introduced to influence the log level?

Sounds like a good idea. Could you prepare a PR, you can control logger level here:
https://github.com/ArturT/knapsack/blob/master/lib/knapsack.rb#L51

@edwinv Could you try the newest knapsack gem version and check the readme to adjust log level https://github.com/ArturT/knapsack#how-can-i-change-log-level


[Suggestion] Specific message for incorrect decryption password

Hi,
Nice work:
Maybe a suggestion for delivering a specific message when the entered  decryption password is incorrect:
Instead of Decryption failed: OperationError: The operation failed for an operation-specific reason something like a basic Wrong password, try again!
When testing my first thought was that the failure was that of the code itself ...

Error in decryption throws a generic error. I cannot tell with certainty the password was wrong.
It's possible that it's by design. And from what I remember the error may even be browser-specific.
That said,  I'm a total noob with Javascript, if anyone has suggestions on improving error handling in general I'd appreciate it.


Add ignoreOrder option to avoid the OrderUndefinedError

Following the discussions in:
webpack/extract-text-webpack-plugin/issues/80
webpack/extract-text-webpack-plugin/pull/81
https://github.com/css-modules/css-modules/issues/12
This commit adds an ignoreOrder option to avoid the OrderUndefinedError when the order doesn't matter.

Would be fantastic to get this merged.

We really need this! :)

Hey @sokra, I hate having to mention people on github issues, but we need to get some attention somehow.
I've noticed that there are quite a lot of pull requests open (like this one), and most are very useful things to have in this module. I understand that you and other contributors are very busy, but this is an essential package for webpack users.
Is there any way you could have a look into this? Or at least give some feedback?
Thank you ;)

Thanks @MicheleBertoli, this works perfectly for us - using composes without this is a massive pain. It'd be great if we could get it merged :).

This PR got the compilation to succeed for me. Here’s the command I use to install it:
npm i --save-dev 'MicheleBertoli/extract-text-webpack-plugin#614c3bb1ed72587218aa644df12bbf514fb77a06'

I'm hitting this as well.
I think this is a fairly meaningful problem – even in cases where there are no conflicts (i.e. no undefined behavior), this still causes problems with getting builds to succeed.

This PR has solved the problem I had with React CSS Modules when building the production dist:
ERROR: Order in extracted chunk undefined
Steps to solve it:

Install this PR with the command @dtinth has indicated.
In your webpack file:
new ExtractTextPlugin('styles.css', {
allChunks: true,
ignoreOrder: true   // <- Add this
})

Is this still a problem with the latest beta 2.0.0-beta.3? In my limited testing I haven't seen the issue occur since switching back off MicheleBertoli's  ignoreOrder branch

I have rebased @MicheleBertoli's order-undefined-error branch to master of this repo and added some pull requests: https://github.com/grrowl/extract-text-webpack-plugin/tree/order-undefined-error

https://github.com/webpack/extract-text-webpack-plugin/pull/241
https://github.com/MicheleBertoli/extract-text-webpack-plugin/pull/1

@MicheleBertoli is the blocker to merging this the CLA?

@grrowl is the blocker to merging this the CLA?

👍  not sure what's going on here but definitely busted

This especially makes sense with CSS modules because CSS modules doesn't guarantee any deterministic ordering anyway

So what is going here? People is creating PRs and not a single word. Is anyone going to merge it? Should we create another solution? Something else? @sokra

why does this happens? i don't have circular dependencies

@felixsanz - We need to get a stable 2.0 out. This has been added to the 2.1 milestone, which we will begin working on as soon as 2.0 is @latest
For reference, if you need something addressed you will have more success directing the request to either myself or bebraw.
You can ping me on here, or if it's pressing on twitter (same name) which will ding my cell

I'm still kinda confused, does literally no one use css modules in production? Or is there a workaround?

It works for some cases I guess. At least I have used it in production. It stopped working as soon as I introduced variables aka values.

I have a temporary fork on npm under my namespace with this code. We've been running with that for the last several months.

https://www.npmjs.com/package/@taion/extract-text-webpack-plugin in case I was unclear

@tj I've been doing the same as @taion.

@tj I don't know what's changed since I last had this issue, but since upgrading to webpack 2.2.0, version 2.0.0-beta.5 of this plugin has been working fine for me in production. :/

@sunny-g interesting! I'll try upgrading soon and see how that goes

I updated to the latest versions today and it's not fixed.
@tj, if you want a nice workaround, try this:

Install postcss-modules-values plugin. https://github.com/css-modules/postcss-modules-values
Create a single css file where you import all your shared stuff. For example index.css, and it should contain this:

@import "./layout.css";
@import "./typography.css";
@import "./elements.css";
@import "./animations.css";

This way, this is the only place where you import those files, so the order will be always the same. (No more issue).

To make use of them, in your components use something like:

@value typography: "../../styles/composition/index.css";
@value elements: "../../styles/composition/index.css";

.whatever {
  composes: defaultLink from typography;
  composes: defaultInput from elements;
}

What happened is that you import your files only 1 time in your code, and then you create values for those classes. And with the postcss plugin you can compose those shared classes from the value (not directly from the file).
Of course, since you are importing from values from index.css, in my example typography is just a copy of elements, both have all the shared classes, but if you don't duplicate the shared classes names it works fine. You can just do:
@value shared_classes: "../../styles/composition/index.css";

.whatever {
  composes: defaultLink from shared_classes;
  composes: defaultInput from shared_classes;
}

But i prefer duplicating them because when i compose the classes it's more clear the original location of the shared class.
Hope it helps.

Included in 2.0.0-rc3. I prioritized this a bit as it's just a flag and the issue affects a lot of people.

Hi @bebraw
So this issue is only fixed for webpack 2?

@MatteoGabriele Correct.

@bebraw any chance of a workaround for webpack1 "owners"? I need to put in production a project today and I don't know how to fix it.

@MatteoGabriele Probably the fastest way for you would be to fork the webpack 1 branch and patch that. If you have time, PRing that fix could be nice so you could consume an official version after that.

@bebraw I was thinking about that one. is this the only line i need to change?
https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/10781f5ad308a35b417a35336efc4086e0fdcd7f/index.js#L312

@MatteoGabriele Correct. The fix itself is very simple. 👍

@bebraw Thanks man! I'm going to do it!

You can also use<EMAIL_ADDRESS>

Any progress on this?! This is quite annoying!

@delijah I don't think we'll see a webpack 1 specific release. Maybe the fastest way to get the fix there is to branch the webpack 1 version and apply the fix there although migrating to webpack 2 is the preferred way.

But this is not really fixed in webpack 2, isn't it?

@delijah Please open a separate issue if the PR didn't work for you.

By using version 2.1.0 of extract-text-webpack-plugin, webpack 2.4.1 and the config options
new ExtractTextPlugin('styles.css', {
  allChunks: true,
  ignoreOrder: true   // <- Add this
})

it seems to work for me now. Sorry for the confusion, i have got lost in dependencies and the sheer amount of pullrequests and issues regarding this issue.
Thank you soooo much for providing a solution for this!!!

This works for me:
new ExtractTextPlugin({ filename: 'quikly-admin-ui.css', disable: false, allChunks: true, ignoreOrder: true }),
Per: https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/index.js#L112-L124
PR: To update this error text, here:
https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/539
Versions in use:
"webpack": "2.4.1",
"extract-text-webpack-plugin": "2.1.0",

@bebraw @MicheleBertoli - Can you explain how ignoreOrder: true would affect regular css imports?
facebookincubator/create-react-app/pull/2285 allows both css modules and regular css in the same project. To fix cssmodule errors we'd like to add ignoreOrder: true, but I am unsure if this will negatively affect those who aren't using css modules (or are using both).


mirror_example.py issue ?

Hello,
when I try mirror_example.py, I get this error, and don't receive mirrored message :
MIRROR
ERROR:root:[Errno 2] No such file or directory: 'notify-send'
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/pushbullet/listener.py", line 75, in on_message
    self.on_push(json_message)
  File "mirror_example.py", line 71, in watcher
    push["push"]["body"], image_path)
  File "mirror_example.py", line 78, in notify
    subprocess.Popen(["notify-send", title, body, "-i", image or ""])
  File "/usr/lib/python3.5/subprocess.py", line 676, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.5/subprocess.py", line 1282, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'notify-send'

Any idea ?

Hey! You need the notify-send command in your path: https://ss64.com/bash/notify-send.html


GNU ld wants executable stack

Hi devs, I recently noticed that GNU ld complains about executable stack with the following warning:
x86_64-solo5-none-static/solo5_xen.o: requires executable stack (because the .note.GNU-stack section is executable)

As there is a /DISCARD/ section in the linker scripts https://github.com/Solo5/solo5/blob/8d8517b12dbfdbe1e2e61e9a2fa07a2038a6b8b7/bindings/solo5_hvt.lds#L155, maybe it possible/needed to also add .note.GNU-stack?
I don't currently have access to my laptop, but it may be possible to find where's needed executable stack following https://www.redhat.com/en/blog/linkers-warnings-about-executable-stacks-and-segments?

As we use a tender for running the unikernels, the permissions are set in the tender and the warning is probably not alarming, but I think it's best to remove if possible and easy :)

This change was introduced by #402 (/cc @Kensan) but I think it's unrelated to muen if I understand correctly and it's just a porcelain change to not pollute the final executable with what gcc can put. Let's try to resolve that before the next release.

I did some reading [1] on this because I noticed we have this warning as well when linking certain components in the Muen project. Since the warning is emitted by the linker, I don't think not discarding the section helps. Does #570 fix the issue?
My understanding is that one would rather have to add a .note.GNU-stack section to the assembler files. I hacked something together, which is compiled-tested only(!). With this change, the linker warnings go away. Not sure if this is also needed on Aarch64, thus I did not change cpu_vectors_aarch64.S.
[1] - https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart


Getting started vignette

Both as a full vignette and perhaps building out the how-to in the Readme. If expanding the readme, consider moving the a Rmd readme that renders in GHA.

I used to really like how tos in the README but multiple devs I have worked with have pushed to keep it very sparse and signposted and to have the code getting started be in a specific place

I'm surprised to hear that. R culture is pretty vignette-oriented. But see e.g., ripgrep, ruff, or duckdb. I'd think a lightweight readme to help potential uses identify whether reading the vignette would be worth it is a good idea?

I'm not disagreeing it isn't something people do I am just pointing out a counter view which I have seen a lot recently in epi silos. I think both are valid choices.

Hey @zsusswein  This project looks super interesting.
I'd love to see a full featured getting started vignette; or a simpler one and a more "in the weeds" example. It would help as an entry point for people having a glance (i.e. me).

I'm working on it for the v0.2.0 release! I'm hoping to have that out this week.
Or in other words, ask and you shall receive...


removed provider configuration

what
removed provider block
why
While using this module a terrform plan always requested to specify the region, although the variable region is set in the module.
provider "aws" {
  assume_role {
    role_arn = "${var.aws_assume_role_arn}"
  }

  region = "${var.region}"
}

module "subnets" {
  source              = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.11.0"
  availability_zones  = ["${data.aws_availability_zones.available.names}"]
  namespace           = "${var.namespace}"
  stage               = "${var.stage}"
  name                = "${var.name}"
  attributes          = "${var.attributes}"
  tags                = "${local.tags}"
  region              = "${var.region}"
  vpc_id              = "${module.vpc.vpc_id}"
  igw_id              = "${module.vpc.igw_id}"
  cidr_block          = "${module.vpc.vpc_cidr_block}"
  nat_gateway_enabled = "true"
}

>terraform plan
provider.aws.region
  The region where AWS operations will take place. Examples
  are us-east-1, us-west-2, etc.

  Default: us-east-1
  Enter a value:

Relates to #56

@svenwb can you try this instead? https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/57/files#diff-ef22b8f4f3d3aa4da77d8e2297dbb1fcR74

@svenwb can you try this instead? https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/57/files#diff-ef22b8f4f3d3aa4da77d8e2297dbb1fcR74

@osterman thanks that worked for me. I didn't know about that concept in terraform +1

@osterman I think this is still necessary fix because if this module is included in other higher level module, it won't work.
For example:
# module: network

module "vpc" {
  ...
}

module "dynamic-subnets" {
  ...
}

Using this module like this:
module "network" {
  providers = {
    aws = "aws"
  }
  ...
}

Still gives an error.

@svenwb

I'm afraid it will affect end users anyway unless the constraint is changed to use >= syntax

Yes, we are concerned about this too given how quickly the provider revs.
I think we'll start with this and then loosen it as necessary.

@svenwb will close for now; please re-open or create a new issue if problems arise.
FYI, we merged #57 which adds basic tests

Ok cool. Thanks for the feedback


Unable to add pull to refresh functionality to the webview_flutter

I have been trying to implement pull to refresh functionality to the web view by having it as a child for RefreshIndicator, but  couldn't accomplish this. Below is the code snippet. Please provide your suggestions.
Widget _buildWebViewWidget() {
    return WebView(
      initialUrl: 'https://flutter.dev',
      javascriptMode: JavascriptMode.unrestricted,
      debuggingEnabled: true,
      onWebViewCreated: (WebViewController webViewController) {
        _controller.complete(webViewController);
      },
      onPageStarted: (String result) {
        print('onPageStarted ' + result);
        setState(() {
          _isLoading = true;
        });
      },
      onWebResourceError: (WebResourceError webviewerrr) {
        print('-----' + webviewerrr.description);
        if (webviewerrr.description.contains('ERR_NAME_NOT_RESOLVED') ||
            webviewerrr.errorCode == -1009) {
          // net::ERR_NAME_NOT_RESOLVED
          setState(() {
            _hasWebViewErrorOccured = true;
          });
        }
      },
      onPageFinished: (String result) async {
        print('onPageFinished ' + result);

        setState(() {
          _isLoading = false;
        });
      },
    );
  }

This is how the _buildwebviewwidget is used inside RefreshInidicator.
  RefreshIndicator(
            child: _buildWebViewWidget(),
            onRefresh: () async {
              return await Future.delayed(Duration(seconds: 3));
            },
          );

Hi @bharathiselvan
Looks like RefreshIndicator isn't compatible with webview_flutter.
Related
https://github.com/flutter/flutter/issues/56724
https://github.com/fluttercommunity/flutter_webview_plugin/issues/606
https://stackoverflow.com/questions/57171434/is-there-a-way-to-add-pull-down-to-refresh-to-the-webview-flutter-widget https://stackoverflow.com/questions/59744142/flutter-pull-to-refresh-on-a-webview
It's not working when modifying official example with following

stable & master flutter doctor -v
[✓] Flutter (Channel stable, 1.22.4, on macOS 11.0.1 20B29 darwin-x64, locale
    en-GB)
    • Flutter version 1.22.4 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 1aafb3a8b9 (2 weeks ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E            • ios • iOS
      14.2
    • iPhone 12 (mobile)   • BBCEDCF6-A80B-49DC-86EE-C9B542A9AD1B • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.24.0-8.0.pre.374, on macOS 11.0.1 20B29
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-8.0.pre.374 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 183f0e797a (4 days ago), 2020-11-26 19:12:28 +0100
    • Engine revision 20caf54969
    • Dart version 2.12.0 (build 2.12.0-76.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (6 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D                     •
      android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E            • ios
      • iOS 14.2
    • iPhone 12 (mobile)   • BBCEDCF6-A80B-49DC-86EE-C9B542A9AD1B • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • macOS (desktop)      • macos                                • darwin-x64
      • macOS 11.0.1 20B29 darwin-x64
    • Web Server (web)     • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)         • chrome                               •
      web-javascript • Google Chrome 87.0.4280.67

• No issues found!

Did anyone found a solution for this?

@bharathiselvan have you found any other solution to do reload?

@wahyu-handayani and @boucoding
I did implement this with the native views themselves and I'm currently waiting for the PR #https://github.com/flutter/plugins/pull/3695 to be reviewed.
If you want to use my version, replace your webview_flutter reference with the one bellow.
  webview_flutter:
    git:
      url: https://github.com/sageata/plugins.git
      ref: pull-to-refresh
      path: packages/webview_flutter

Issue is reproducible on master 2.5.0-6.0.pre.63 and stable 2.2.3 with webview_flutter: ^2.0.12.

 code sample
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() => runApp(MaterialApp(home: RefreshTest()));

class RefreshTest extends StatelessWidget {
  final Completer<WebViewController> _controller = Completer();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: RefreshIndicator(
        onRefresh: () async {
          return await Future.delayed(Duration(seconds: 3))
              .then((value) => print('onRefresh called'));
        },
        child: Builder(builder: (BuildContext context) {
          return WebView(
            initialUrl: 'https://flutter.dev',
            javascriptMode: JavascriptMode.unrestricted,
            onWebViewCreated: (WebViewController webViewController) {
              _controller.complete(webViewController);
            },
          );
        }),
      ),
    );
  }
}

 flutter doctor -v
[✓] Flutter (Channel master, 2.5.0-6.0.pre.63, on macOS 11.5.1 20G80 darwin-arm,
    locale en-GH)
    • Flutter version 2.5.0-6.0.pre.63 at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 047d35d8ba (2 hours ago), 2021-08-12 12:47:05 +0800
    • Engine revision a2e60472a9
    • Dart version 2.15.0 (build 2.15.0-5.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.59.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (4 available)
    • M2007J20CG (mobile)         • 5dd3be00                  • android-arm64  •
      Android 11 (API 30)
    • sdk gphone64 arm64 (mobile) • emulator-5554             • android-arm64  •
      Android 12 (API 31) (emulator)
    • Nexus’ IPhone (mobile)      • 00008020-001875E83A38002E • ios            •
      iOS 14.6 18F72
    • Chrome (web)                • chrome                    • web-javascript •
      Google Chrome 92.0.4515.131

• No issues found!

[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.1 20G80 darwin-arm, locale
    en-GH)
    • Flutter version 2.2.3 at /Users/nexus/dev/sdks/flutter
    • Framework revision f4abaa0735 (6 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.59.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (4 available)
    • M2007J20CG (mobile)         • 5dd3be00                  • android-arm64  •
      Android 11 (API 30)
    • sdk gphone64 arm64 (mobile) • emulator-5554             • android-arm64  •
      Android 12 (API 31) (emulator)
    • Nexus’ IPhone (mobile)      • 00008020-001875E83A38002E • ios            •
      iOS 14.6
    • Chrome (web)                • chrome                    • web-javascript •
      Google Chrome 92.0.4515.131

• No issues found!

Hi! I found a easy way to integrate RefreshIndicator completely w/o SingleChildScrollView  which changes the scolling behavior of the webview_flutter in a not usable way.
originally stackoverflow question
github code example

@TahaTesser is pull-to-refresh ever going to be baked into webview? What is best solution right now?

Hello everyone, I'm a dev from Vietnam, have a nice day everyone
I'm having trouble pulling down to refresh with webview, I'm following this tutorial
https://stackoverflow.com/questions/68870975/flutter-how-to-make-pull-down-to-refresh-flutter-webview-using-the-official-web
it works fine the first time i scroll down, then it gives error :
'package:flutter/src/gestures/recognizer.dart': Failed assertion: line 401 pos 12: '_team == null': is not true.

Hi! I found a easy way to integrate RefreshIndicator completely w/o SingleChildScrollView  which changes the scrolling behavior of the webview_flutter in a not usable way.
originally stackoverflow question github code example

What webview_flutter version you use? Cant trigger the refresh with webview_flutter 4.2.2

@cefaci I'm afraid your solution doesn't work anymore.


Change arrow position on mobile

I noticed that the scroll arrow is malpositioned on my phone. It should be closer to the bottom right corner of the screen.

Fixed in #214


social media release plan

https://docs.google.com/document/d/1AwPQdSKqP53fz3Lyz5heWR5KGDDoIAU-2hSUzWd43kU/edit
To do:

[x] create content
[x] approve content w/ team
[x] complete forms for USGS accounts to share these
[ ] make a Gif and send to Scott Horvath

To do:

[ ] complete forms for USGS accounts to share these

@eread-usgs please review the social media release plan and edit/provide feedback. Lower priority for today, but I would like to submit the forms on Wednesday/Thursday.

Hi @lindsaycarr I reviewed the plan, looks great. thank you

I would like to label this as priority but don't see how on mobile (and I don't have wifi at the moment.) @lcarr just noting this for you and I'll change it when I get on my laptop

Can we/someone tweet this out with an AGU hashtag at some point since @eread-usgs is giving a talk on it?

@eread-usgs what is the title of your talk?

Maybe someone/some organization that is involved in the data viz session could tweet/retweet to promote the session?  Maybe a session chair?

@lindsaycarr it is Maximizing Impact: Pairing interactive web visualizations with traditional print media
at noon PT on Thursday (2pm your time)

are their size (dimensions or file size) restrictions for twitter gifs?

@wdwatkins this has some additional info: https://dev.twitter.com/rest/media/uploading-media#gifrecs

this is just under the dimension limit

with new data and 10ms less delay

@wdwatkins from Scott Horvath:
Is it possible to have this graphic redone to either just be wall water supply (blue) or
to at least pause on the other 4 categories of water supply usage for about 3 seconds
each? Those last few items flip through so fast I had to watch it at least 5 times to be
able to read any of the wording and figure out what's what.

I just want to make sure our followers and those they share it with can see everything.


⚠ Turnos 24x7 has degraded performance

In 51c2efc, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Turnos 24x7 performance has improved in 347fe9f.


profanity: enable tray icon support

Motivation for this change
Profanity can show a tray icon, e.g. showing that messages were received. This enables support for the feature.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Sorry, had to edit the history of the commit a bit. Should now have changed everything that was wrong.


useBaseUrl description a tad confusing

📚 Documentation
useBaseUrl is described as a "React hook to automatically append baseUrl to a string automatically."
Pedantic, but I think it actually prepends baseUrl to the supplied string. (Reporting here since this confused me a bit, not because I'm trying to be pedantic.)
Have you read the Contributing Guidelines on issues?
Yes
Steps to reproduce:
View the core docs for useBaseUrl here. See that the word used is "append". Expect instead to have seen "prepend".
Discussion
Alternatively, perhaps the docs should read as follows. (Note I'd also take out the second "automatically".
React hook to automatically append a string to the baseUrl.

You're totally right. It's a blind spot for us because we know what it does and didn't notice that it doesn't really mean what it does. We'll fix it if nobody beats us to it!


Change or allow configuration of split chunk filename delimiter - currently tilde (~)

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
Split Chunks are output to a filename containing tilde (~) characters, e.g. vendors~app-ui.js.
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
Change, or allow configuration of the character used.
If this is a feature request, what is motivation or use case for changing the behavior?
I am packaging solutions for use with SharePoint and tilde (~) is not a valid filename character in that environment.
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Node 9.7.0
Webpack 4.1.1
Windows 7

Created a pull request for this feature :)
For more info see: https://github.com/webpack/webpack/pull/6712

I've got the same issue, any update on the status of this?

The delimiter can be configured as of version 4.2.0 using splitChunks.automaticNameDelimiter.

Awesome, thanks!

Just putting a note here for search engines as this was a valid workaround to an issue we had.
On just one of our dev boxes (a dell laptop), IIS 10 on windows 10 would 404 for any chunks which had a tilde followed by a number.  Fine for chunks that were tilde followed by a letter.
ie
~2 doesn't work
~a works
Changing windows 8point3 settings in FSUTIL did not help.  Uninstalling and reinstalling IIS making sure all windows components were the same as other working installs did not help.
It is likely one machine had some different security settings given it was a windows install from a different manufacturer rather than a clean install.  Tilde followed by a number was reportedly a security vulnerability in IIS.
So we ended up changing the delimiter using this option.


doc: update the community page

Subtask of #257, we could use a TODO tag to check the status: (click the button directly to mark it as done)

[x] update the EN&CN community page
[x] update the EN page with README in  subscriber page
[x] update the EN page with README in  subscriber-cn page & translation
[x] enhance the content with GPT/New Bing
[x] update the README info

After:

@msgui some improvement: [TODO]

remove extra unsubscribe desc here

UI not unify in EN/CN


drivers: counter: nrfx_rtc: Fix lack of interrupt when CC=0

According to documentation Compare event will not be triggered
if CC=0 and CLEAR task is set. Added handling of that situation.
Signed-off-by: Krzysztof Chruscinski<EMAIL_ADDRESS>

@carlescufi can you merge?

please create a bug for 1.14


RNA degradation rate

increased rate of RNA catabolic process during vegetative growth
PMID:12062100

increased rate of RNA catabolic process during vegetative growth FYPO:0007845


Specify a label with a prompt function

Hello, I'm trying to specify labels so that I can use different prompts with different models (as described here: https://www.promptfoo.dev/docs/configuration/parameters#different-prompts-per-model) but also use prompt functions (https://www.promptfoo.dev/docs/configuration/parameters#prompt-functions).
Is that possible? I tried the naive thing of specifying the javascript file as the prompt id and providing a label, but that led to the prompt being ignored and nothing being executed. To double check my setup, I then swapped the javascript file with a text file and that worked correctly.

Looks like the label property is not supported in two cases:

Native Javascript provider functions
Referencing a Javascript file

Both fixed in #875!

This change is released in 0.62.0

Hm - I see that we can now add a label to a provider when that provider is specified with javascript, but can we provide a label to a prompt specified by js? I apologize if I misunderstood, but I was thinking that something like this would be supported:
prompts:
  - id: prompts/prompts.js:v1
    label: simple
  - id: prompts/prompts.js:addAssumptions
    label: simple
  - id: prompts/prompts.js:addAssumptionsFixThreshold
    label: simple

providers:
  - id: bedrock:anthropic.claude-3-sonnet-20240229-v1:0
    config:
      region: 'us-east-1'
      temperature: 0.0
      max_tokens: 4096
    prompts:
      - simple

When I try that, it doesn't fail exactly, but it finds no test cases


Remove returned guild from GuildDelete

Delete Guild returns 204 (No Content), with no content.. This PR updates the GuildDelete method to not attempt an unmarshal, and only return an error.
Extract from a recent test run:
2023/02/12 00:13:08 API REQUEST   DELETE :: https://discord.com/api/v9/guilds/***
2023/02/12 00:13:08 API REQUEST  PAYLOAD :: []
2023/02/12 00:13:08 API REQUEST   HEADER :: [Authorization] = [Bot ***]
2023/02/12 00:13:08 API REQUEST   HEADER :: [User-Agent] = [DiscordBot (https://github.com/bwmarrin/discordgo, v0.25.0)]
2023/02/12 00:13:09 API RESPONSE  STATUS :: 204 No Content
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Date] = [Sun, 12 Feb 2023 00:13:08 GMT]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [X-Ratelimit-Remaining] = [3]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Cf-Cache-Status] = [DYNAMIC]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Nel] = [{"success_fraction":0,"report_to":"cf-nel","max_age":604800}]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Set-Cookie] = ***
2023/02/12 00:13:09 API RESPONSE  HEADER :: [X-Ratelimit-Bucket] = [***]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Via] = [1.1 google]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [X-Content-Type-Options] = [nosniff]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Server] = [cloudflare]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Content-Type] = [text/html; charset=utf-8]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Strict-Transport-Security] = [max-age=31536000; includeSubDomains; preload]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [X-Ratelimit-Reset-After] = [278.305]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Alt-Svc] = [h3=":443"; ma=86400, h3-29=":443"; ma=86400]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Cf-Ray] = [79811dde0ffa3859-LHR]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [X-Ratelimit-Limit] = [5]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [X-Ratelimit-Reset] = [1676161066.543]
2023/02/12 00:13:09 API RESPONSE  HEADER :: [Report-To] = [{"endpoints":[{"url":"***"}],"group":"cf-nel","max_age":604800}]
2023/02/12 00:13:09 API RESPONSE    BODY :: []

panic: json unmarshal: unexpected end of JSON input

does this check err != nil

never mind, naked error returns sigh


[UI][Container] Entry Point field is being saved

v0.15.0
Steps:

Create a container and add something into the Entry Point Field
Add container and view Advanced options

Results:
The Entry Point field is being saved.  Since this is in advanced options should we be saving this without the user being able to see it?
Expected:
Not to save across add containers.

v0.15.1
Verified fixed


⚠ GitLab Server has degraded performance

In c7ad6b9, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6995 ms

Resolved: GitLab Server performance has improved in ff5cbdc.


Update dependencies

Pull Request Test Coverage Report for Build 2410

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 69.104%

Totals

Change from base Build 2400:
0.007%

Covered Lines:
7857

Relevant Lines:
10702

💛  - Coveralls


Data archiving fails with 65Gb of data

Test Submission: f623e7ad-83d0-4d4a-9326-a9afc6ce3fac
Spreadsheet: PENDING
Data File Locations:
- Submission Location: f623e7ad-83d0-4d4a-9326-a9afc6ce3fac
- Upload Area Location: PENDING

@ke4 can you add the location on the spreadsheet and data file info to the ticket body please.


test(happo): Update to happo v1.0

Description
Recent updates on happo.io and the happo.io client has made the CI
integration a bit simpler. Instead of having to write your own CI
script, ready-made scripts are included in the happo.io npm client. The
one for Travis, happo-ci-travis [1] is the one we're going to use. It
is mostly just a straight up copy-paste of what we used to have in
scripts/happo-ci.sh, with a few adjustments to make it more generic and
a little more robust.
The comment posting is no longer needed. Happo will automatically post a
build status back to the PR. If there are diffs, Happo will show a
"failure". If there are no diffs, the Happo status is green. In order to
turn a failed Happo status into a success, you go to the
details/comparison page and hit the (newly added) success button at the
top. Happo will then post back a green status to the PR.
With the new status, there's no longer a need for the comment posted to
the PR. So I removed that bit of code, including the dependency on the
github client (which is now @octokit/rest by the way).
The pre-release/rc version will be updated to a proper release as soon
as I've seen this script in action a bit more. I'll push a separate PR
following up with that change later.
[1] https://github.com/enduire/happo.io/blob/master/bin/happo-ci-travis
Motivation and context
We no longer have to maintain our own complicated happo scripts, including posting back status to the PR.
Screenshots, videos, or demo, if appropriate
Happo status on a PR on github.com:

Happo status inside happo.io:

How to test
Since happo tests aren't run on outside PRs, I think it might be best for someone with push access to convert it to a PR posted from inside the project. That way, we can make sure things are okay before merging.
Types of changes
Mainly a refactor.
How does this PR make you feel?

The commits from this PR have been merged via #617

Thanks for following the template, Henric. 😃
For those who also wanted to see the gif: https://media.giphy.com/media/26u4cr0ttdswXKgNy/giphy.gif


Deep learning applied to lidar point cloud classification

Context
Classification of lidar point clouds is resource-intensive as it generally involves human interaction to obtain decent results.  Furthermore, it has been shown that classification results and accuracies vary between data producers.  Finally, classification amounts to about 30% of lidar data acquisition costs.
Given that context, how can Deep Learning (DL) help in the classification process ?
Issues
DL architectures used in imagery are mostly CNNs.  Convolution implies pixels.  However, lidar cloud points do not correspond to pixels and therefore CNNs are likely not applicable in this case.
Thoughts
Could we use prior data (DEM, imagery, etc.) to initialize weights in a scene-specific rough manner rather than using a random initialization ?
Could we use standard unsupervised clustering algorithms like K-Means or DBSCAN ?  If so, what is the minimum number of points we can run clustering algorithms against ?
References & projects
Classifying airborne LiDAR point clouds via deep features learned by a multi-scale convolutional neural network  Paywalled, unfortunately ...
Deep Semantic Classification for 3D LiDAR Data.  Key to using CNNs with point clouds: "The input to our network is a set of three channel 2D images generated by unwrapping 360^^0 3D LiDAR data onto a spherical 2D plane".
PyLidar; based on not well-known libraries ([SPDLibb[(http://www.spdlib.org/)), but developed by a government organization (New South Wales, Australia) and still looks pretty interesting: "Supported formats are: SPD V3, SPD V4, Riegl RXP, LAS, LVIS, ASCII and Pulsewaves"
Deep learning-based tree classification using mobile LiDAR data
Deep Semantic Classification for 3D LiDAR Data.  Key to using CNNs with point clouds:  "The input to our network is a set of three channel 2D images generated by unwrapping 360^^0 3D LiDAR data onto a spherical 2D plane"
PointNet : "Deep Learning on Point Sets for 3D Classification and Segmentation" and it's based on this work from stanford University.

Hi @ali-robot,
The goal is to be able to apply DL to any pointcloud, regardless of the sensor.  At this point, we only started with a literature review to figure the best way to add this feature to Geo-deep-learning.
That being said, our main concern is to apply this to aerial LiDAR, mainly for cartographic purposes.

Some other infos were in a duplicate ticket: #69

Independent project, not related to GDL.


Remove reference to old dependency in LICENSE.

@jonparrott Is "removes" or "removing" the right way to say it?

Remove.
On Tue, Aug 2, 2016, 3:57 PM Danny Hermes<EMAIL_ADDRESS>wrote:

@jonparrott https://github.com/jonparrott Is "removes" or "removing"
the right way to say it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/oauth2client/pull/584#issuecomment-237074780,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc2ONBDvsbC7RjGVqdERbvA2I2Qvwks5qb8tDgaJpZM4JbIB1
.

Aw man

Oooh, are we keen on commit message perfection in this pull request? Because your subject line should be without trailing punctuation.

OK I'm putting a moratorium on non-change content opinions until I hear if the change LGT someone

The change content looks fantastic.

OK got rid of the trailing punctuation. Am I good to merge?

Merge away!


update webscalesqlclient submodule to facebook/mysql-5.6

Summary:
Manually changed .gitmodules then:
git submodule update --init --recursive
git pull origin webscalesql-<IP_ADDRESS>
git add webscalesqlclient
   hhvm-third-party/webscalesqlclient/src $ git log

   commit 896ecfc2e5d141dbab451a104c24da644ac5ea6b
   Author: Dan Reif<EMAIL_ADDRESS>   Date:   Thu Oct 8 21:35:38 2015 -0700

cc: @jwatzman (current on-call)
According to an email thread, @fredemmott seems onboard with this change. We would have accept this patch and then update the HHVM third-party hash.
I think that this is fine.

Yeah, I want to make sure to test this on Linux and OS X, and haven't gotten around to that yet. Probably later today.

The way this is done fails to update existing trees. From inside the third-party directory:
$ git pull https://github.com/drilibo/hhvm-third-party.git updatewebscale
From https://github.com/drilibo/hhvm-third-party
 * branch            updatewebscale -> FETCH_HEAD
Updating 2500669..8ea182b
Fast-forward
 .gitmodules                       | 2 +-
 CMakeLists.txt                    | 3 +--
 libzip/zipint.h                   | 2 +-
 thrift/CMakeLists.txt             | 3 +++
 webscalesqlclient/CMakeLists.txt  | 5 +++--
 webscalesqlclient/webscalesql-5.6 | 2 +-
 6 files changed, 10 insertions(+), 7 deletions(-)
$ git submodule update --init --recursive
fatal: reference is not a tree: 896ecfc2e5d141dbab451a104c24da644ac5ea6b
Unable to checkout '896ecfc2e5d141dbab451a104c24da644ac5ea6b' in submodule path 'webscalesqlclient/webscalesql-5.6'

It does seem like you need to clean the repo to make this work without
changing the submodule path. I tried changing just the name of the
submodule in a already initialized git repo and it failed.
On Tue, Oct 20, 2015 at 8:02 AM, Josh Watzman<EMAIL_ADDRESS>wrote:

The way this is done fails to update existing trees. From inside the
third-party directory:
$ git pull https://github.com/drilibo/hhvm-third-party.git updatewebscale
From https://github.com/drilibo/hhvm-third-party

branch            updatewebscale -> FETCH_HEAD
Updating 2500669..8ea182b
Fast-forward
.gitmodules                       | 2 +-
CMakeLists.txt                    | 3 +--
libzip/zipint.h                   | 2 +-
thrift/CMakeLists.txt             | 3 +++
webscalesqlclient/CMakeLists.txt  | 5 +++--
webscalesqlclient/webscalesql-5.6 | 2 +-
6 files changed, 10 insertions(+), 7 deletions(-)
$ git submodule update --init --recursive
fatal: reference is not a tree: 896ecfc2e5d141dbab451a104c24da644ac5ea6b
Unable to checkout '896ecfc2e5d141dbab451a104c24da644ac5ea6b' in submodule path 'webscalesqlclient/webscalesql-5.6'

—
Reply to this email directly or view it on GitHub
https://github.com/hhvm/hhvm-third-party/pull/90#issuecomment-149594133.

Yeah, and we can't insist that everyone with every checkout should re-clone it, particularly since the error message is pretty inscrutable. Is there something else we can do here, ideally without changing the paths?

abandoning this one
https://github.com/hhvm/hhvm-third-party/pull/91 tried another approach


Fix relative path for robot test script in Dockerfile

Added my results when testing these changes
odscicontissuesolved.txt


I would drop the description of the script. The description is needed in the job form, but in the idle/running/finished job view it kinda just takes up space.

Migrated from #42 (@bertfrees )
"I would drop the description of the script. The description is needed in the job form, but in the idle/running/finished job view it kinda just takes up space."


[lineageos] Fix date (again)

The date at https://lineageos.org/Changelog-26/ is 26th April
It also applies to the EoL for 17.1

See #1101
cc @usta

@captn3m0 oppps , i missed that part sorry , thank you for patch/fix.
LGTM

I'd made the date change of marking 17.x as EOL here based on builds for 17.1 being stopped.


prolfqua_merged Vignette DIA-NN Output

@wolski Thank you for such a great package! I just wanted to see if you could point me in the right direction of using prolfqua_merged on my DIA-NN output file?

@wolski I just wanted to circle back and see if you had some insight into this query as I'd love to be able to use your fantastic tool?

@wolski Hope you are doing well. I  wanted to check in and see if you had a chance to review my query so that I may utilize your wonderful tool?

@abadgerw I'm sorry for not replying earlier. Unfortunately, since the end of July, the email notifications from Git Hub have been in my email client's spam folder.
Did you have a look at this vignette?
https://fgcz.github.io/prolfqua/articles/CreatingConfigurations.html
Also, have a look at this discussion:
https://github.com/fgcz/prolfqua/discussions/85
Also, we now have a bioarxv
preprint, which describes a command line interface to prolfqua.
There, you have out-of-the-box DIA-NN support.


ENH: insert the gradunwarp workflow in anat template workflow

Working on https://github.com/nipreps/fmriprep/issues/1550.
Relies on an updated version of the gradunwarp https://github.com/bpinsard/gradunwarp/tree/fix/mem_leaks.
Unwarping is inserted in the anat_template_wf and is thus applied to T1w and T2w.
It is applied after denoising to avoid messing with noise structure with interpolation.

Does it make sense?

Cool! I suspect that we can't use FSL warps directly with antsApplyTransforms. @oesteban can nitransforms translate these yet?
Some quick googling shows the SCT folks have the transform going the other way, which we could look at if we don't already support this: https://github.com/spinalcordtoolbox/spinalcordtoolbox/pull/2529

Right I wrongly assumed these were compatible. Regarding the transforms, I think it would be possible to make gradunwarp output in a nitransforms compatible format maybe skipping/simplifying that step.

can nitransforms translate these yet?

It would be experimental, but the implementation is there mostly thanks to @smoia :)

Glad to hear I did something useful in my life - I'm not sure I did though. When I was trying not to break nitransforms, I was working with FSL 5.x transformations, but FSL 6.x transforms were breaking the code. I did open an issue about it, but can't find it now...
Also happy to chime in again though!

I upgraded the workflow in niworkflow to convert the warp from fsl to itk, based on the code of nitransforms. As nitransforms.io only inputs transforms, I inverted the itk input function to output in itk format (flipping sign of the 1st and 2nd dimensions) and from what I understand itk deformation fields are relative. It seems to warp in a sensible way, though the gradient correction transforms are very subtle.
sMRIPrep doesn't use the warp field as it directly pass the corrected image in the anat template workflow so that's only used in fMRIPrep when combining all transforms for one-step interpolation.
Side question: do you have specific datasets you use for testing fmriprep with sdcflows? (small datasets with different types of fieldmap) I noticed that sdcflows ones are generated on the fly during testing, but I suppose you have integration tests that do not run on github actions.
Thanks for all the feedback!

FSL 6.x transforms were breaking the code.

You left it working for FSL 5. Then I realized that FSL 6 started to break all tests across the board and discovered a nasty bug in their interpolation. I reported the bug to FSL, and they must have fixed it (it wasn't the most transparent process tbh).
See? you did something :)
@bpinsard, @effigies - I don't know if in this PR or a separate one, but I would like to see sMRIPrep pick up corrected files when available.
I don't know this is the PR where that logic would go in (why not?), but if it helps, we are calling our T1w as follows:
sub-pilot_ses-16_acq-original_T1w.nii.gz
sub-pilot_ses-16_acq-undistorted_T1w.nii.gz

Is there any interest in using the command from TORTOISE that directly creates an ITK displacement field from coef files? It works for all scanner manufacturers  and has a permissive license

@mattcieslak thanks for this information.
When you say displacement field from coeffs files you mean as a replacement to gradunwarp?
Do you have a link to the documentation of the tool in TORTOISE which allows doing that?
I plan to work on this feature during the upcoming nipreps sprint.
I am not think that adding a new binary dependency would be ideal, but better have all the info to make that decision.
Thanks!

@bpinsard here is the code. I would be interested in helping out on this during the nipreps sprint too

Is there any interest in using the command from TORTOISE that directly creates an ITK displacement field from coef files? It works for all scanner manufacturers and has a permissive license

This should be implemented and functional in nitransforms already, and the dependency is already included. As an additional perk, it makes the transform compatible with BIDS' X5 file format.

I'm pretty sure we haven't implemented gradient coefficients in nitransforms. It should be possible to adapt gradunwarp, though.

ok, rebase was way too difficult after fit/apply refactor, restarted from scratch.
There are added changes to pass BIDSLayout to get per-contrast/per-file metadata indicative of scanner distortion correction.
If all files distortion metadata for one contrast (T1w/T2w) are not consistent, it raises a RuntimeError to avoid any kind of crazy branching where a set of files have to be corrected while the other do not.

Giving it more thought, I think the step should be inserted after denoising but before conform to keep the affine intact.

the failing CI will require niworkflows PR to be merged.


Need a Spark.awaitStopped() method

The Spark.stop() method stops the server, setting the internal initialized variable to false. The problem is that this is all done asynchronously, in a separate thread (in the Spark.Service class):
/**
 * Stops the Spark server and clears all routes
 */
public synchronized void stop() {
    new Thread(() -> {
        if (server != null) {
            routes.clear();
            server.extinguish();
            latch = new CountDownLatch(1);
        }

        staticFilesConfiguration.clear();
        initialized = false;
    }).start();
}

However, I found no way of checking whether the service has actually stopped. This is problematic because Spark creates a singleton service, so shutting down a server and restarting it without actually finishing the server process may lead to problems. In a more concrete use case, this creates problems when running several unit tests, where each unit test starts a server, runs the test, and shuts the server down.
This issue would be solved by providing a method like Spark.awaitStopped() that returned only when the thread started in Spark.Service.stop() had finished.

I did some quick experimenting, shouldn't be too hard to implement.

My quick hack of an implementation basically does a join() on the thread if waiting is required. Sound okay (@perwendel @tipsy)? Need to write tests at least before raising a PR.

I think a better way to go would be with a condition variable with a lock on the initialized field... At the end of the stop thread, you'd signal the condvar. The awaitStopped() would get the lock, check the value of initialized, waiting on the condvar if necessary, then releasing the lock.

@kdubezerra sounds more complicated than necessary, what benefits would the added complexity bring?

@jakaarl That's a good question. To me, it looks like a textbook example of when a condition variable should be used: all it depends on is the initialized variable being false (hence the condition). And, fwiw, using the condvar will consist of ~5 (10 at most) lines of code. But maybe using a Thread.join would be just as correct and probably simpler.
I have another question though: what if you call Spark.awaitStopped() before starting the server? What if it's called after the Thread spawned by Spark.stop() has already finished? Do you keep a reference to that thread just in case someone calls awaitStopped()?. My 2 cents is that the condvar would cover all these cases, but I'm just as happy with whatever implementation you guys provide :)

My implementation of awaitStopped() actually stops and waits for it to finish, instead of waiting on a separate call to stop() to finish. Very simple, but doesn't quite do what was asked or what the name implies. I'll take a new look at this when time allows. But would a blocking version of stop() that I implemented be desirable feature as well?

Yeah, that would definitely help! I actually remembered of guava services... As another suggestion, one can extend AbstractService and implement doStop() (the blocking version) as well as stopAsync() (similar to Spark's current one). The awaitRunning() and awaitTerminated() methods would come for free.

Hey guys,
I am having a similar issue. Here is my code for it
port(Integer.parseInt(mci_port));
try {     fhirPatientValidator = new FhirPatientValidator(mciProperties); } catch (Exception e) {     logger.error("Unable to create FHIR Patient Validator",e);     Spark.stop(); }
Actually, I am trying to construct an object, if that fails I want the server to be stopped and do nothing. But I figured out  it is still going and executing lines after that. I was thinking of putting System.exit(statusCode), but not sure whether that will be a good way of stopping it or not.
Thanks in advance.

Fixed in #730


Tvheadend stops at Adding Repo

Many thanks for providing these scripts and sorry to trouble you.
I copied your link to install TVHeadend but unfortunately it only gets as far as "Adding Tvheadend Repo" and then just seems to stop:
 ✔  Updating LXC Template List...  ✔  Downloading LXC Template...  ✔  Creating LXC Container...  ✔  Starting LXC Container...  ✔  Setting up Container OS...  ✔  Updating Container OS...  ✔  Installing Prerequisites...  ✔  Adding Tvheadend Repo...
Any suggestion gratefully received please,
Thanks
Grahame

Apologies, I've retried this and it now doesn't get any further than:
✔  Updating LXC Template List...
✔  Downloading LXC Template...
✔  Creating LXC Container...
✔  Starting LXC Container...
✔  Setting up Container OS...
✔  Updating Container OS...
✔  Installing Prerequisites...
✔  Installing Tvheadend...
Thanks

This is the problem:

That is why the script stops
Unfortunately, I don't know how to fix this. I'll remove the tvheadend scripts.

Ah, ok, that's a shame. Thanks for looking into it.