Enhancement: Line up bottom of unit of measure and value

Expected behavior and actual behavior:
Would like there to be more padding between KPI title and value, so unit of measure and value will have the same baseline.
Screenshots (optional, but very helpful):
Actual:

Request:

Hi @hannav95 - are you customizing/overriding any variables or constraining the space around the KPI in some way? The component's default state looks more like your Requested picture than the Actual one. Can you also confirm that the proper font is being loaded? It looks like Inspira Sans, but just want to double check, because the positioning of this component is unfortunately based heavily on the baseline of the font in use.
From the demo page:

@randyaskin I use the KPI within a px-card and only add a padding to the top and margin the left. I still see what I have in the actual image even with those styles removed. The font family is set to GE Inspira Sans,Helvetica,Arial,sans-serif.


RAC-6412: fix original FIT test cases for ucs-service

Add ucs option to "docker_local_run" which is the stack used to run FIT.
Fix error : the api /catalog?identifier=switch-B is not supported.

@pengz1 @anhou @geoff-reid @tannoa2

BUILD RackHD #545 : FAILURE

Jenkins failure can be ignore because it's disabled now.

ignore Jenkins result and merge


refactor(Chat): enable Children API

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


optimize syslog speed

Summary
Save the syslog prefix to the buffer and use streamsyslog_puts to output it at one time
patch 1 adds puts method to streamsyslog
patch 2 replace lib_sprintf with sprintf, put syslog prefix into buffer, and reduce the number of syslog_putc calls
Impact
The average syslog single time is shortened by 30% when all formatting options are turned on
output  syslog(LOG_INFO, "Hello, World!!\n");     37%   97 us->  61 us
Testing
Any configuration, enable format options
Test Conditions:
Hardware : STM32H743ZI nucleo
config:
enable all syslog format options,
enable CONFIG_RAMLOG_SYSLOG,
disable CONFIG_SYSLOG_DEFAULT
#define COUNT 10000

int main(int argc, FAR char *argv[])
{
  struct timeval start, end;
  gettimeofday(&start, NULL);

  for (size_t i = 0; i < COUNT; i++)
    {
      syslog(LOG_INFO, "Hello, World!!, %s:%d\n", __FILE__, __LINE__);
    }

  gettimeofday(&end, NULL);
  printf("microsecond: %ld\n", (end.tv_sec * 1000000 + end.tv_usec) - (start.tv_sec * 1000000 + start.tv_usec));

  return 0;
}

@Gary-Hobson please double check why format to char buffer fast than iob buffer

After confirming that after opening the iob buffer, the optimization effect is not obvious, and the tmp_buffer is removed in the latest patch
After enabling SYSLOG_BUFFER, the average increase is about 4us

@Gary-Hobson please double check why format to char buffer fast than iob buffer

After confirming that after opening the iob buffer, the optimization effect is not obvious, and the tmp_buffer is removed in the latest patch


Error getting access-token when using code flow + pkce

Hello,
I'm trying to use the library with the code flow + pkce. I use Azure AD B2C as identity provider. For testing purposes, I have created a new test app (Angular 8), with the following code in the AppComponent:
@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {

  constructor(readonly oauthService: OAuthService){
    this.oauthService.configure(authCodeFlowConfig);

    this.oauthService.tokenValidationHandler = new JwksValidationHandler();

    this.oauthService.loadDiscoveryDocument("https://<<app-name>>.b2clogin.com/<<tenantId>>/v2.0/.well-known/openid-configuration?p=B2C_1_LocalAccountSignIn").then( resp => {
      return this.oauthService.tryLoginCodeFlow();
    }).then(_ => {
      if (!this.oauthService.hasValidAccessToken()) {
        this.oauthService.initCodeFlow();
      }
    })
    .catch(err => {
      console.log('error: ', err)
    });
  }
}

When browsing to http://localhost:4200, it does redirect to the oauth server login page (login.microsoftonline.com/...) and after having logged in succesfully, it redirects back to localhost:4200, but Chrome console logs shows this error from angular-oauth2-oidc.js:
'Error getting token' with the message: 'Http failure response for https://<<app-name>>.b2clogin.com/<<tenantId>>/oauth2/v2.0/token?p=b2c_1_localaccountsignin: 0 Unknown Error'
The funny thing is that the identity provider does return a 200 OK response including the expected payload, but either Angular or the framework still interpret it as an Http Error Response.
When replaying the exact same POST using Postmen, it returns the expected 200 OK response including an access_token, refresh_token. etc) in the response body.
So it seems like the library isn't able to pick up the response...

Thx for the extensive report, sorry to hear you're having trouble.
Nonetheless, a rather specific server setup seems needed to reproduce the issue (at least, I've never seen this case before with other IDS solutions) - so we might be relying on you or another community member with easy access to the same setup to debug this problem...

I'm using keycloak idp with ngrx and when doing code flow I get neither access token nor identity claims.
Removing the response_type: 'code' then works as expected.

I'm trying the same. AccessCode + PKCE with AAD B2C.
I'm getting an access code. But when I want to get a token with this code I get the error
{"error":"invalid_client","error_description":"AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'.\r\nTrace ID: 1bd0543d-fc82-4412-8da4-e9fb578d0200\r\nCorrelation ID: 8441dd3b-13e3-456a-bb20-59f42a7aabac\r\nTimestamp: 2020-03-03 10:11:42Z","error_codes":[7000218],"timestamp":"2020-03-03 10:11:42Z","trace_id":"1bd0543d-fc82-4412-8da4-e9fb578d0200","correlation_id":"8441dd3b-13e3-456a-bb20-59f42a7aabac","error_uri":"https://login.microsoftonline.com/error?code=7000218"}

I'm trying the same. AccessCode + PKCE with AAD B2C.
I'm getting an access code. But when I want to get a token with this code I get the error
{"error":"invalid_client","error_description":"AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'.\r\nTrace ID: 1bd0543d-fc82-4412-8da4-e9fb578d0200\r\nCorrelation ID: 8441dd3b-13e3-456a-bb20-59f42a7aabac\r\nTimestamp: 2020-03-03 10:11:42Z","error_codes":[7000218],"timestamp":"2020-03-03 10:11:42Z","trace_id":"1bd0543d-fc82-4412-8da4-e9fb578d0200","correlation_id":"8441dd3b-13e3-456a-bb20-59f42a7aabac","error_uri":"https://login.microsoftonline.com/error?code=7000218"}

Same for my application switching from implicit flow to code flow when authenticating with AAD (at least trying with Postman). Using the web application I get the same error as the creator of this thread together with a CORS error.

I happened to stumble across this a few minutes after struggling the same issue as well.

However, after removing responseType: 'code', the errors seemed to disappear 🤔
This isnt a solution this is just my 2 cents, still looking for a solution :)

Concerning the CORS error: Azure AD B2C does not currently support CORS on the token endpoints. Therefore it's not possible to use the code flow in a browser app and you'll need to use the implicit flow.
They seem to be working on it though: https://feedback.azure.com/forums/169401-azure-active-directory/suggestions/37689847-cors-for-token-endpoint

Yes, unfortunatelly. Honestly, I would change to code flow as it can be configured quite easily and as implicit flow will be deprecated by OAuth 2.1


Add CI tests

When this project is open-source and publicly available we should create a free CI server and add linting and other build-time tests.

Sass linting
Javascript linting
Visual regression tests
CSS stats

[] Sass linting
[ ] Javascript linting
[ ] Visual regression tests
[ ] CSS stats

I’ll remove the css stats entry, as that’s not a test it should be run locally and checked in deliberately by devs.

I’ve added styleguide generation to the list of items we should be testing on travis (just check the styleguide is correctly generated), as a result of #233.


ReadOptions are not exposed?

New to rust so apologies if this is a misfile, but it seems that ReadOptions only exist in db.rs and aren't exposed. The docs also don't reference the type (ie. http://docs.rs).
Sorry for the lack of PR - like I said, I'm not quite sure on the preferred fix / if this issue is valid.

Thanks for adding this!


Freezes

We have written the needed data into your clipboard because it was too large to send. Please paste.
It freezes on the start up page. When I open up visual studio, it does not load

It freezes on the start up page. When I open up visual studio, it does not load

I met this issue too.

/gifPlease

@lramos15 gif uploaded

My code version and environment:
Version: 1.65.2
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
Date: 2022-03-10T15:36:26.048Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.16.0-4-amd64

Hey @deepak1556, this issue might need further attention.
@Victorriv, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

@quanzhuo Thanks for the update. Can you try VS Code insiders https://code.visualstudio.com/insiders/ which is using a new electron version to see if that fixes your issue

Closing since issue has not been updated with info required for https://github.com/microsoft/vscode/issues/145181#issuecomment-1153999880


Support of Azure Resource Management mode (ARM)

Azure has two management mode. The 'legacy/classic' (ASM) one is currently supported by this tool and Microsoft recommends using ARM moving forward.
Request for support of new deployment mode.

ASM support would definitely be welcome. Would you be interested in contributing?

Yes, sure. I'll happy to contribute.


APIView - Reduce number of requests sentd to Devops to get pipeline details

We should cache connection and pipeline name to definition mapping to reduce number of calls we make to Azure devops to optimize sandboxing requests we send to Azure Devops.

@praveenkuttappan there is a nice model on devops definition caching that @hallipr built out for pipeline witness. It may be more than you need here, but it could be useful to share techniques/code.


News post for IronHacks blog

Use the article written by Marketing and create a news post!
https://polytechnic.purdue.edu/newsroom/brunswicker’s-ironhacks-data-science-challenge-predicted-social-crowding-it-occurred
We should also agree on the process and the documentation of these activities!

Blog/social media potential posts: https://drive.google.com/drive/folders/12mkf4GLy39fZMSsXbUqXJ1UiMFKe1MoL?usp=sharing

Here is the draft: https://github.com/ironhacks/ironhacks-blog/tree/master/content/post/2021-IH-SS-2021-hack here is the last commit related to this: 49a4fc08bfd2c122f0df457feaca4b8c61da12b1


Update CTPicker.m

when runing in lastest ios 9.3.1 , that would be report an error
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'accessing _cachedSystemAnimationFence requires the main thread

I'm experiencing this issue as well. Any chance of fixing conflicts to merge this?


Fix some grammar in messages/errors

I went through and just fixed any grammatical errors I noticed. This includes things like, "Sorry does not any Definition Found" in the attached screenshot. (Love your work by the way!)

finder bug had fixed.

finder bug had fixed.


Update Python 3.9.17, 3.10.12, 3.11.4

Updates our Python version to: 3.9.17, 3.10.12 & 3.11.4
fixes #221
fixes https://github.com/bosch-thermostat/home-assistant-bosch-custom-component/issues/301

Hello @frenck,
i wanted to kindly inquire if there is any information available regarding a release date for the Home-Assistant container with Python 3.11.4?
Alternatively, if there is a possibility of obtaining a development version of the container that includes Python 3.11.4, I would be more than grateful.
Best regards

i wanted to kindly inquire if there is any information available regarding a release date for the Home-Assistant container with Python 3.11.4?

Ther is no such information available. It will be available as soon as possible.
../Frenck


feat: Add Expandable Store Hours/Details component

issue: https://github.com/brandingbrand/flagship/issues/339
Added new component StoreHours, that show store schedule.
StoreHours component is integrated into the LocationItem component.

@bweissbart  Linter error fixed.

Closing as we've decided to go a different direction with components.


mentropy and mnoise CSRs

Added GetNoise per input from Stephan Müller (Atsec / BSI). Explicitly stated that both PollEntropy and GetNoise are machine/mode CSRs. Names of the CSR words modified to match Ben's suggestion.

Hey @mjosaarinen  - Thanks for this. I'll have proper look and merge it tomorrow when I'm no longer suffering from an acute case of "Monday".


DataSet (and MultiDataSet) toString issues

DataSet.toString():

Will throw a NPE if features or labels are null
Does not display any info about mask arrays

MultiDataSet.toString()

Doesn't exist (i.e., MultiDataSet does not implement a .toString() method, other than that provided by Object.toString())

This is also related to the issue I just closed. Will close this out when I add support the separator.

https://github.com/deeplearning4j/nd4j/pull/1042
Added mask info for dataset
Added toString for multidataset


What are the rules for  ?

Can you clarify what the rules for the <resources /> object is? I'm not sure when I can access a resources from a different part of my component tree, etc. Some specific questions are below.

In individual component, can I reference a resourceId declared a parent component?
Can I use a resource not defined in a parent component, but defined in a sibling component? As in, are resource names considered global to the render tree?
Can I define multiple <resouce> tags in the same component?
What happens if, in any place, I duplicate a resource / resourceId between components? Will the user of the resource look up the render tree until it finds one, or are they global and the "last" one wins?
To what degree does render order matter for resources? If I referenceId a resource in a sibling component, the sibling might not have been created yet. Will this fail, or does it all get batched together at render time and sorted before render?
What happens if I modify runtime properties of a resource at runtime? For example, I want to change the opacity of a material. Is this allowed / safe / efficient?

Yes
Not siblings, resources aren't global
<resource-like> (all within https://github.com/toxicFork/react-three-renderer/wiki/Resource-Types) tags can go only within <resources> in a component, and yes you can have multiple <resource-like> tags inside a <resources> tag. I have not tried multiple <resources> tag within a component.
This is a fun one. If a parent P has let's say resource for id 'foo', and a child C has resource for id 'foo', the references within the child C (and its children and grandchildren and so on) will use the inner foo. The parent's children (e.g. any siblings of child and these siblings' children) excluding this child C will use the outer one. So the 'nearest above' wins.
Resources within a sibling cannot be referred to.

<parent>
  <child a>
    <resources>
    </resources>
  </child a>
  <child b>
    You cannot refer to anything in `<child a/>` here
  </child b>
</parent>

It's not only safe and efficient, it's even recommended! That's one of the main purposes for resources. You can use resources to change the color of a material for any number of meshes this way, e.g.

<group>
  <resources>
    <meshBasicMaterial resourceId="mat1" color={>>change this<<}/>
    // ... geometry... resourceId="geom1"
  </resources>
  <Meshes/>
</group>

Meshes.prototype.render = () => {
  // all meshes refer to the same material and geometry instances
  return (<group>
    <mesh>
      <materialResource resourceId="mat1"/>
      <geometryResource resourceId="geom1"/>
    </mesh>
    <mesh>
      <materialResource resourceId="mat1"/>
      <geometryResource resourceId="geom1"/>
    </mesh>
    <mesh>
      <materialResource resourceId="mat1"/>
      <geometryResource resourceId="geom1"/>
    </mesh>
    // ... and so on
  </group>)
}

I will add these in a FAQ :) It's a complex little beast!

Updated comment above


added debian-12 flist in micro_vm.vue

Added debian-12 flist in micro_vm.vue
As of now, this branch is using @xmonader's FList

https://hub.grid.tf/ahmedthabet.3bot/threefolddev-debian-12.flist

But if needed, we set it as draft and wait until we have the official threefoldtech's FList

https://hub.grid.tf/tf-official-apps/threefoldtech-debian-12.flist

But if needed, we set it as draft and wait until we have the official threefoldtech's FList

https://hub.grid.tf/tf-official-apps/threefoldtech-debian-12.flist

yes, please create the official one, and let's use it instead

just ping @maxux to promote it

Sorry, issue were lost in email: https://hub.grid.tf/tf-official-apps/threefoldtech-debian-12.flist.md

@xmonader
The link with the tf-official-apps for debian has been updated.
Thanks @maxux and Thabet.


[SelectMenu] @click.stop not working on first item clicked

Description
Hi,
I try to create a redirect link for each item in my select, but the redirect doesn't work all the time. If no item is selected, then for the first one it will select it rather than redirect the user :
<USelectMenu
  v-model="selected"
  :options="contacts"
>
  <template #option="{ option }" >
    <span>{{ option.name }}</span>
    <NuxtLink :to="localePath({name: 'contacts-id', params: { id: option.id }})" @click.stop>Show</NuxtLink>
  </template>
</USelectMenu>

Much appreciated help!
Thanks

Ok it's because my SelectMenu is in a UFormGroup. If I take it outside, it works.
Is this a bug that needs fixing @benjamincanac? I'll look for a workaround in the meantime.

Honestly, the SelectMenu has never been thought to have a link inside. Have you tried .prevent?

I understand, @click.prevent alone doesn't work. But I have found a workaround using absolute strategy on popper also:
:popper="{ strategy: 'absolute' }"


chore: create docker image and compose for dev using the watch feature

This commit create new image and compose file for dev mode. It use new compose feature watch released in version 2.22.0 (september 2023) to automatically reload container when changes are detected
Video demo (password: tamagokill)
https://vimeo.com/952926923?share=copy
There is just a small delay for the API after the change; the time it takes to rebuild.
Don't forget --watch flag in docker compose command to enable this.
Example : docker compose -f compose.dev.yaml up --build --watch
Resources :

Cargo watch : https://crates.io/crates/cargo-watch
Docker compose watch : https://docs.docker.com/compose/file-watch/

Added  2 new env for compose API_PORT and WEB_PORT to define the local port of these services

Ach too bad I dumped docker for podman, I can't test the feature ... well I guess a nix devShell wouldn't be a bad thing then lol silly me :p

Both solutions can very well coexist to include as many people as possible!

Why would you use a Dockerfile.dev ?
Multistage is made to avoid having multiple files and would be great to use here

Using a multistage build is a viable approach, but having a separate Dockerfile.dev significantly enhances the readability and maintainability of our Docker setup. The distinct files allow developers to differentiate between development and production environments, making it easier to understand and modify the build process for each use case.

Some fixes :

Fix the default port for the web app
Remove useless instructions on Dockerfile.dev (ty @lilymonad for the Rust side)
Retrigger build when dockerfile changes


test_reactions: Cache stores reactions data after formatting.

Reactions data should always be formatted before it saved in cache,
otherwise clients receive malformed data.
This is followup on a53daa6f8c7cb06ea4119a3e7c4063a47e2e7c41

This is great, merged, thanks @amanagr!


fix  Uncaught TypeError: webComponentRef.current is null

In some cases, I see the error  Uncaught TypeError: webComponentRef.current is null.
The fix avoids this.

Codecov Report

Merging #9 (b8ef482) into master (e4211cf) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           54        55    +1
  Branches         9        10    +1
=========================================
+ Hits            54        55    +1

Impacted Files
Coverage Δ

src/index.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4211cf...b8ef482. Read the comment docs.


active-state class being added to every element

Framework7 version: 4.4.3

Describe the bug
Hello!
I've found that the .active-state class is being applied to every element, not just those defined in app.params.touch.activeStateElements.
Looking at line 39 of touch.js the findActivableElement function:
  function findActivableElement(el) {
    const target = $(el);
    const parents = target.parents(params.activeStateElements);
    let activable;
    if (target.is(params.activeStateElements)) {
      activable = target;
    }
    if (parents.length > 0) {
      activable = activable ? activable.add(parents) : parents;
    }
    if (activable && activable.length > 1) {
      const newActivable = [];
      let preventPropagation;
      for (let i = 0; i < activable.length; i += 1) {
        if (!preventPropagation) {
          newActivable.push(activable[i]);
          if (activable.eq(i).hasClass('prevent-active-state-propagation')
            || activable.eq(i).hasClass('no-active-state-propagation')
          ) {
            preventPropagation = true;
          }
        }
      }
      activable = $(newActivable);
    }
    return activable || target;
  }

If neither the target element nor any of its parents are activable elements, the function returns the target. This seems to be a bug. Or is this expected behaviour?
I've been debugging an intermittent issue with delegated click events not firing in certain scenarios, this seems to be the culprit.
Changing the function to return activable || $(); fixes the issue & doesn't seem to have any adverse side-effects.
Cheers,
Morgan

Also, a minor issue with the docs.
The default touch.activeStateElements at https://framework7.io/docs/app.html#app-parameters are listed as a, button, label, span, .actions-button
For me in v4.4.3 the defaults are a, button, label, span, .actions-button, .stepper-button, .stepper-button-plus, .stepper-button-minus, .card-expandable, .menu-item, .link, .item-link

If neither the target element nor any of its parents are activable elements, the function returns the target. This seems to be a bug. Or is this expected behaviour?

This is expected behavior, not a bug.
Docs are fixed


Cancel and cancelAll upload

Current behavior:
(type: cancel) = On a list of files, when I cancel the current uploading file, it cancel the uploading but don't pass to the next uploading.
(type: cancelAll): It cancel all the list but when I import new files it doesn't restart the uploading.
Expected behavior:
When I cancel one or more downloads, it must cancel (it is already the case) but when we import other files, it must restart the download.
Version:

ngx-uploader: 4.2.2
Angular: 5.2.0

What is the status here? I ran into the issue by cancelAll, but can not find the solution anywhere. Is there a workaround?

@jkuri this one is not the same as #9 because it happens when there are more cancelled (and/or running) uploads than the value of the concurrency option. Let me explain why this one happens:

uploadScheduler is a Subject and every started upload Observable is merged by mergeMap operator but limited by concurrency option
on completion of the Observable returned by startUpload method mergeMap cleans up normally so far so good
on cancel the actual Subscription is subs array is unsubscribed (as it should) so when xhr is aborted and change to XMLHttpRequest.DONE state then although observer.next() and observer.complete() calls run they will not call complete because observer is already stopped
because observer have not been completed nor errored out so the observer in startUpload have not been completed (because neither error nor complete functions have been called)
because the observer of startUpload is the mergeMap operator (it maintains inner subscriptions) then the mergeMap operator can not clean up this Observable causing a hang up (and probably a memory leak too) when there are cancelled uploads

Subscription provides a method to add a tear down logic which is called on unsubscribe. We can use that to complete observer when unsubscribe happens. It won't complete it twice because completing it sets it to stopped and when it is stopped it won't do anything again.
I will create a PR today and post it here too. (Where can I find the CLA which I should sign?)

OK, I can not reproduce this kind of behavior with the demo app which uses Angular 7 and RxJS 6. I use Angular 5.2 too and when I upgrade ngx-uploader to 7.1.0 then if I would like to upload a new file after cancel then it won't start until the previous one completes. My fix would solve that but the upload still completes in the background then (devtools show pending request instead of cancelled). I am not aware the changes between the two versions (namely the 4.2 line and 7.1.0) but since this makes it possible to bypass concurrency limits (or maybe I am missing something) then probably upgrading to Angular 7, RxJS 6 and ngx-uploader 7.1.0 can solve this issue in my case.


Lazyload support

It looks like ofi interferes with Lazyload functionality.
Is there a way to solve this?

A LazyLoad solution in WP-Rocket (cache module) http://docs.wp-rocket.me/article/278-common-issues-with-lazyload
One of the common issues they mention: JavaScripts that try to calculate spaces based on image size
I have seen the problem in IE 11 since I updated OFI to the recent version.

OFI doesn't set the image size, it just sets the src
What's the issue exactly? Can you show me the broken dom? Even better, can I see the site with the issue?

Images are not visible when they enter the viewport.
I can see them load when I scroll down, but then immediately are hidden again.
You can see the effect on http://www.photosessions.nl/fotoshoot/koppels/romantische-fotoshoot-koppels/
Scroll down and look for the empty spaces in the long text element on the page. (In IE 11)
You can see a correct version of the page in Chrome, Safari, Firefox

I see there is a data-lazy-src in there that gets removed.

Along with a data-lazy-srcset.
Sry for the double post

Why are you using object-fit in the first place? It's best that you load the correctly-sized image instead of something so big<EMAIL_ADDRESS>

Yes that's true, and also not the point of the topic. There are more situations, but this was merely an easy example to point to.
Will it be possible to add support for the 'lazy-src' tags?

Op 17 mei 2017 om 05:09 heeft Federico Brigante<EMAIL_ADDRESS>het volgende geschreven:
Why are you using object-fit in the first place? It's best that you load the correctly-sized image instead of something so big<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I looked into the code of your plugin and I couldn't find a way to make it work automatically.
A solution I could think of is enabling OFI on the lazy images after they're loaded:
objectFitImages('img:not([data-lazy-src]')); // instead of your objectFitImages() call
$('[data-lazy-src]').one('lazybeforeunveil', function (e) {
  $(e.target).one('load', function () {
    objectFitImages(e.target);
  })
});


cf cli hard to uninstall because name not set in Windows Programs and Features

On a new Windows 7 machine I installed CF CLI from https://cli.run.pivotal.io/stable?release=windows64&version=6.10.0&source=github-rel.
On Windows, we use "Control Panel\All Control Panel Items\Programs and Features" to list and uninstall applications.
CF CLI is listed as:
Name: 6.10.0
Publisher:
Size:
Version: 6.10.0

Please correct the name, publisher and size fields.

added installer label so when we start on installer themed work, this will be included.  Closing issue since this is represented in CLI tracker now

This seems to have been resolved since.


Implement Additional Solutions into Log Analytics

Azure SQL Analytics
DNS Analytics
Logic Apps Management Analytics

Resolved in #189


Fix minor bugs

Pull Request Test Coverage Report for Build 3148

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.185%

Totals

Change from base Build 3147:
0.0%

Covered Lines:
1450

Relevant Lines:
1492

💛  - Coveralls


ARROW-6863: [Java] Provide parallel searcher

For scenarios where the vector is large and the a low response time is required, we need to search the vector in parallel to improve the responsiveness.
This issue tries to provide a parallel searcher for the equality semantics (the support for ordering semantics is not ready yet, as we need a way to distribute the comparator).
The implementation is based on multi-threading.

Thank you @liyafan82, I just have a few suggestions/questions

Thanks a lot for your valuable comments. I have replied them accordingly.
If there is anything we can do, or any other requirements, please let us know.

@TheNeuralBit are you still reviewing this?

@TheNeuralBit  ?

Sorry for the extreme delay on this. This LGTM, just one small comment on the docstring, I would still like it if this could highlight the differences from #linearSearch

I have highlighted the difference in the JavaDoc. Thanks a lot for all the valuable comments.


software

hey man, found your videos on youtube and excited about the site - was thinking it would be cool to know what software you're using for 3d modeling/design. Hope this is useful feedback! (feel free to close)

solidworks!  and many users are on Fusion360.  Hop into our discord!  Is your name Willis?  Hope to see you there.
Link is on my youtube page =)


Phones array on form

Phone doesn't have to be required. Not all defibrillators have a phone. It's need to be fixed on the front and server side in DB.


🍒 Cherry pick PR #10856 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/10856 to staging 🍒

🚀 Cherry-picked to staging by @OSBotify in version: 1.1.97-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by @OSBotify in version: 1.1.97-3 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.


Some(WrongType ... Type(Uuid)) error

Hey 👋 ,
I am trying to create an instance in the database and also provide an id field data.
model:
model locations {
  id        String   @id
  latitude  Float
  longitude Float
  tweets    tweets[]
}

error:
prisma-client Requests: +111ms
  prisma-client [
  prisma-client   'mutation {\n' +
  prisma-client     '  createOnelocations(data: {\n' +
  prisma-client     '    id: "f70c6744-c2cb-5a28-b4c6-5aa0680dac0c"\n' +
  prisma-client     '    latitude:<PHONE_NUMBER>09.4528\n' +
  prisma-client     '    longitude: -352645828260.6592\n' +
  prisma-client     '  }) {\n' +
  prisma-client     '    id\n' +
  prisma-client     '    latitude\n' +
  prisma-client     '    longitude\n' +
  prisma-client     '  }\n' +
  prisma-client     '}'
  prisma-client ] +0ms
  prisma-client Results: +593ms
  prisma-client [
  prisma-client   PrismaClientUnknownRequestError: Error occurred during query execution:
  prisma-client   ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(Error { kind: ToSql(0), cause: Some(WrongType { postgres: Type(Uuid), rust: "alloc::borrow::Cow<str>" }) }) })
  prisma-client       at NodeEngine.graphQLToJSError (/Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/runtime/index.js:1:16029)
  prisma-client       at /Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/runtime/index.js:1:14963
  prisma-client       at Array.map (<anonymous>)
  prisma-client       at /Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/runtime/index.js:1:14930
  prisma-client       at processTicksAndRejections (internal/process/task_queues.js:97:5)
  prisma-client       at Dataloader.loader (/Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/index.js:55:23)
  prisma-client ] +0ms
  prisma-client Error: Error occurred during query execution:
  prisma-client ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(Error { kind: ToSql(0), cause: Some(WrongType { postgres: Type(Uuid), rust: "alloc::borrow::Cow<str>" }) }) })
  prisma-client     at NodeEngine.graphQLToJSError (/Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/runtime/index.js:1:16029)
  prisma-client     at /Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/runtime/index.js:1:14963
  prisma-client     at Array.map (<anonymous>)
  prisma-client     at /Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/runtime/index.js:1:14930
  prisma-client     at processTicksAndRejections (internal/process/task_queues.js:97:5)
  prisma-client     at Dataloader.loader (/Users/maticzavadlal/Code/work/prisma/prisma-test-utils-automation/dbs/basic-twitter/node_modules/prisma-client/index.js:55:23) +3ms

What code are you executing exactly?

Could not reproduce: https://github.com/janpio/repro512
What are you doing differently?

@maticzav If you share the SQL dump of the database, that would be useful for triaging this.

@janpio try running src/test.ts in prisma-test-utils-automation. I also set up a debugging environment there.
To reproduce: pull, install dependencies and yarn ts-node src/test.ts

@pantharshit00 Matic refers to https://github.com/prisma/prisma-test-utils-automation here, so if you have the time you could do what he suggested for me.

@pantharshit00 any progress with this one? I can't do much without your help here. 🙂

@maticzav Could you please look into https://github.com/prisma/prisma-client-js/issues/512#issuecomment-589326658 and see where your code differs? Having a minimal reproduction is always much easier than "look into my giant project to figure it out" as I am sure you know.

@janpio I prepared a one-file reproduction with a debugger enabled. I am not sure how much further I can go with making reproduction more approachable. The difference with your case is in the production of id value. As described above and as I've asked in the Slack thread the problem I am having is with the id verification.

I am unable to boot the script :/,

This is related to https://github.com/prisma/prisma2/issues/479
Right now the implementation of @id @default(uuid()) in postgres marks the database field as a text(See https://github.com/prisma/migrate/issues/114). The query engine uses an internal implementation of the UUID type. So when you introspect a UUID, the introspection engine maps it to a String, but the query engine does not understand the postgres UUID type so it panics. We ignored this in the past we are waiting on native database type support as mentioned in #47
So either you can change the database type from uuid to string or you will need to wait till we release support for postgres uuid in the query engine here.

We can close this as a duplicate but I don't know as this issue concerns an internal project.

@maticzav Workaround: Do not use/support UUID types for now.

Let's keep this around @pantharshit00, as it shows the exact outcome in Prisma Client. Also might be tackled outside of context of other native database types work.

@janpio @pantharshit00 this is an introspection result - how can I determine which schemas use uuid and which don't?

this is an introspection result - how can I determine which schemas use uuid and which don't?

You can use a GUI like https://tableplus.io to see the postgres schema. It is a bit of manual work though.

You can not really, and these schemas failing is exactly what we want to find out with test-utils so I would say this is fine for now. Make it work with other schemas that do not have this (e.g. MySQL)

This is fixed in the latest version.


Made the state-initialization a bit easier

BTW you might want to re-benchmark against OrdinaryDiffEq since it had a few performance regression fixes. You might want to make use of https://github.com/YingboMa/FastBroadcast.jl internally as well.

Thanks for letting me know! I should indeed do a proper benchmark soon. I'll also have a look at FastBroadcast.jl, I just need to find out where and how to best use it since we have a lot of matrix-matrix and matrix-vector multiplications in here. But thanks for the pointing me to it!

Codecov Report

Merging #36 (c4dcd46) into main (159409e) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   93.12%   93.34%   +0.21%
==========================================
  Files          19       19
  Lines         640      646       +6
==========================================
+ Hits          596      603       +7
+ Misses         44       43       -1

Impacted Files
Coverage Δ

src/state_initialization.jl
100.00% <100.00%> (ø)

src/priors.jl
100.00% <0.00%> (ø)

src/ProbNumDiffEq.jl
72.22% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159409e...c4dcd46. Read the comment docs.

Oh yes, you should look into https://github.com/JuliaLinearAlgebra/Octavian.jl for those if they are small-ish.

Wow, thanks again for that recommendation, never heard of Octavian.jl before. I'm still struggling to find the right balance between functional, generic code, and optimizing internal solver operations, since as you said many things depend on the actual problem size, number types, etc. Anyways, I think next month I'll do some refactoring and look a bit more into code optimizations again.


Guidebooks are now spawning in bookshelves.

About the PR

Guidebooks were hard to obtain. Cargo hardly ever ordered a crate of guidebooks. Now guidebooks can be found in (library) bookshelves
Why / Balance

Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Guidebooks can now be found in random bookshelves.

Thank you for your contribution!


appendLabel/appendDescription rendering out of order in PDOM

Found while using Checkboxes in Gravity Force Lab. Checkbox.js sets both to true, and this results in the LABEL_SIBLING being added after the DESCRIPTION_SIBLING. Here's a screenshot

Should we always default to having the label before the description? Is there ever a case where we may want the description first? Is this even an issue since the <label> tag is linked to the <input> element?

Should be fixed in the above commit and I added unit tests to verify. @zepumph since you worked on these options can you please check to make sure this looks OK?

This looks good. Thanks for verifying with unit tests.
Why did you choose to use Array.prototype.indexOf.call( bElementParent.childNodes, bElement ); instead of just calling the method on childNodes?
Otherwise it's very nice!


Migrate Qdrant to CustomComponent

would like to give this a try. I have been using langflow locally for a while, definitely try to contribute.


ol.interaction.Translate: Features moved over the date line are not selectable

If you move a feature over the date line and deselect it you won't be able to select it again.
You can try this in the translate interaction example (http://openlayers.org/en/master/examples/translate-features.html).

duplicate of https://github.com/openlayers/ol3/issues/4158


Added Staircase Search in 2D Array in Java.

I have done with PR . Please review it and let me know if any corrections needed.

I have made PR  on issue #385 . Please Review it @tarun26091999  .
Thanks!!

@AasthaGoyalgit do it soon


Rename Locale for Chinese (China) to zh-CN

Received some useful hints from our friends at Transifex and I think this approach is the  way to go forward.
This PR applies revised naming convention from https://github.com/ipfs/ipfs-gui/issues/50#issuecomment-419430520

Renames Chinese locale from zh to zh-CN,  which is supported by i18next and match value from Accept-Language:

I smoke tested this PR and strings that are already translated rendered correctly:

ps. In the future we can add pt-BR and  en-GB using the same convention :)

This is basically https://github.com/ipfs-shipyard/ipfs-webui/pull/784 but with changed code, so safe to merge.


Deal more gracefully with an empty SearchResult

This PR ensures Lightkurve fails more gracefully when search_targetpixelfile or search_lightcurvefile return no results.
Before:

After:

Codecov Report

Merging #331 into master will increase coverage by 0.05%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   89.56%   89.62%   +0.05%
==========================================
  Files          28       28
  Lines        4065     4087      +22
==========================================
+ Hits         3641     3663      +22
  Misses        424      424

Impacted Files
Coverage Δ

lightkurve/tests/test_search.py
100% <100%> (ø)
:arrow_up:

lightkurve/search.py
93.22% <95%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8460ee2...4a39cb5. Read the comment docs.


update rgdal to 1.4-4

See https://cran.r-project.org/web/packages/rgdal/index.html

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Segmentation Fault in CTGAN Execution, Resolved by Upgrading scikit-learn

Description
A segmentation fault error occurs when running the CTGAN model using the provided example code in the example/ directory with the SDG framework.
This error was resolved by upgrading the scikit-learn version from 1.4.3 to 1.5.1.
Reproduce

Clone the SDG repository and navigate to the example/ directory.
Ensure the xxx_training_data.csv file is present in the directory.
Run the sdg_script.py script using Python 3.12 with the command: python -X faulthandler sdg_script.py.

Expected behavior
The script should run without errors and produce the following log output:
2024-07-30 08:52:24.002 | INFO     | sdgx.models.ml.single_table.ctgan:fit:221 - CTGAN training finished.
2024-07-30 08:52:24.002 | INFO     | sdgx.synthesizer:fit:324 - Model fit... Finished

Context

Operating System and version: macOS 14
Python version: 3.12
SDG version: 0.2.1(dev)
scikit-learn version: 1.4.3 (issue), 1.5.1 (resolved)

Error message

(base) mooocat@mooocatsiMac example % python -X faulthandler sdg_script.py
2024-07-29 22:42:12.776 | INFO     | sdgx.data_models.metadata:from_dataloader:289 - Inspecting metadata...
2024-07-29 22:42:12.852 | INFO     | sdgx.data_models.metadata:update_primary_key:491 - Primary
...
2024-07-29 22:42:13.097 | INFO     | sdgx.data_processors.transformers.column_order:convert:52 - Converting data using ColumnOrderTransformer... Finished (No action).
2024-07-29 22:42:13.098 | INFO     | sdgx.models.components.optimize.sdv_ctgan.data_transformer:fit:114 - Fitting continuous column ELEC_CUST_NO...
2024-07-29 22:42:13.102 | INFO     | sdgx.models.components.optimize.sdv_ctgan.data_transformer:_fit_continuous:57 - Fitting continues column ELEC_CUST_NO in <_fit_continuous>.
Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault
Thread 0xThread 0x00007ff84764dfc000007ff84764dfc0 (most recent call first):
(most recent call first):
File   File ""/opt/anaconda3/lib/python3.12/site-packages/sklearn/cluster/_kmeans.py/opt/anaconda3/lib/python3.12/site-packages/sklearn/cluster/_kmeans.py"", line , line 754754 in  in _kmeans_single_lloyd_kmeans_single_lloyd
File   File ""/opt/anaconda3/lib/python3.12/site-packages/sklearn/cluster/_kmeans.py/opt/anaconda3/lib/python3.12/site-packages/sklearn/cluster/_kmeans.py"", line , line 15361536zsh: segmentation fault  python -X faulthandler error_script.py

sdg_script.py

from sdgx.data_connectors.csv_connector import CsvConnector
from sdgx.models.ml.single_table.ctgan import CTGANSynthesizerModel
from sdgx.synthesizer import Synthesizer
from sdgx.data_loader import DataLoader
from sdgx.data_models.metadata import Metadata
from pathlib import Path
file_path = './xxx_training_data.csv'
path_obj = Path(file_path)
data_connector = CsvConnector(path=path_obj)
data_loader = DataLoader(data_connector)
loan_metadata = Metadata.from_dataloader(data_loader)
synthesizer = Synthesizer(
metadata= loan_metadata,
model=CTGANSynthesizerModel(epochs=2),
data_connector=data_connector,
)
synthesizer.fit()

The problem seems to be only on macos? I tried to pin the version at greater than 1.4.3, but python 3.8 doesn't support it.
Maybe we cloud pin this when python 3.8 end of life(2024-10)

The issue has been resolved.


UserPresenter里面使用的adapte和userList和UserActivity里面使用的是同一个内存地址的吗?

Look at here

→ Did you conform to the Rules?
→ Did you read the Wiki Carefully?
→ Did you search in Google?
→ Did you search in openned&closed Issues?
→ Receive only bugs and suggestions

Environment

[x] MVPArms Version:
[x] AndroidStudio Version:
[x] Gradle Plugin Version:
[x] Target Android Version:
[x] Device Model:

Bug Description:

Related Code:

Bug Log:

Others:

肯定是啊，如果不是同一个，Demo 中怎么能完成更新 ui 这个操作呢，自己打打断点看看


Feedback on saves

After I did this I realized it did actually save!
Maybe we could have a little toast saying it was succesful? Or disable the save button because there are no longer unsaved changes?

The pipeline will now save automatically. You can save using ctrl+s (or cmd+s on mac?) to save. When the pipeline is "dirty", you'll see

and when it saved you'll see

Confirming that this is enough?


Can the client of program-101 be writied your solana-go-sdk?

This is a very great project for me to learn Solana dapp develop.
May I ask you to provide a example to use solana-go-sdk to implement a clint for one of the program101 examples, It will help me a lot!

hi there. I will try to make it later!


Random category?

I was doing tests in an android app and I liked it.
Is there a way to get random categories? https://waifu.pics/api/sfw/random

I already did it through code, thanks for developing this api

No problem, yeah random is not a priority as its supposed to be organized, just pick randomly out of the endpoints list. You can get the list at https://waifu.pics/api/endpoints


useSerialized now returns the latest value from the HtmlManager

Description
The current memoization of the serialized value inside of the useSerialized hook means that calling setSerialization will never reach the component unless it completely remounts.
The memoization doesn't look necessary as it's only preventing reading a value from a Map instance, which should not be more expensive than the memoization lookup anyway.
Then, removing this memoization ensures that the hook returns the latest value whenever it renders. Note that setting the serialization client-side doesn't trigger any re-render, as expected.
Reasoning
Inside storybook stories, if we want to update the serialization, it's currently not possible to get the latest values. This change should at least make it possible to have specific stories for different serialization use-cases.

While this PR wouldn't hurt, it's not worth the effort to merge it so I'm going to close it.


HUBDEV-1728

Bug fix in rate service.

SonarQube analysis reported 2 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 RateService.java#L26: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
 RateService.java#L133: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.


Still suffer from slightly drifting using KITTI data with RTK+RT3000

Hi, I am trying to use cartographer building the outdoor map with KITTI raw data. Since the scanmatch
in LocalTrajectoryBuilder constantly produces erroneous pose estimation in street scenarios, I just bypass the scanmatch here, and hope the high precision pose data produced from RTK+RT3000 would still help guarantee the quality of the map. However, when the car came back to a loop, the street will drift randomly at around 5 meters...
I am using the odometry data and fixed pose data from KITTI bag, is there any clue about the causes?

Have you tried it without odometry? Using the real-time scan matcher rather than Ceres?

Thanks! Thinks has improved much since #533 ,  before that fix I have to skip the spg add_odometry(). I 've tried the real-time scan matcher. Without odometry it cannot produce acceptable results. With odometry data, the performance of real-time version is still inferior to that of ceres version. However, the results show that odometry data, though captured from high precision INS system, still drifts (of around 3-5 meters) and require scan matcher to correct the predicted poses (most of the time it can). I am afraid whether the odometry data was not corrected by the rtk? or the calculated time slice for dead reckoning is not accurate enough? I will investigate ways to use fixed frame poses directly.

The KITTI data is hard for us since we do not fully support pure scan matching and they threw away most of their IMU data - sampling it at only 10 hz, instead of the 100 Hz the IMU was providing. You can get decent maps out of it, but they are not super great.
See my comments here. I also posted my tunings there:
https://github.com/googlecartographer/cartographer_ros/issues/264#issuecomment-337916432


Add Sklearn containers for ONNX models

Codecov Report

Merging #231 into master will decrease coverage by 0.85%.
The diff coverage is 86.53%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   94.23%   93.38%   -0.86%
==========================================
  Files          39       39
  Lines        2012     2086      +74
  Branches      361      376      +15
==========================================
+ Hits         1896     1948      +52
- Misses         57       75      +18
- Partials       59       63       +4

Flag
Coverage Δ

#unittests
93.38% <86.53%> (-0.86%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...erters/_array_feature_extractor_implementations.py
100.00% <ø> (ø)

...gbird/ml/operator_converters/onnx/onnxml_scaler.py
100.00% <ø> (ø)

hummingbird/ml/_topology.py
87.20% <75.00%> (-3.84%)
:arrow_down:

hummingbird/ml/_container.py
92.35% <91.04%> (-1.62%)
:arrow_down:

...mmingbird/ml/operator_converters/_base_operator.py
100.00% <100.00%> (ø)

.../ml/operator_converters/_linear_implementations.py
100.00% <100.00%> (ø)

...rd/ml/operator_converters/_tree_implementations.py
98.15% <100.00%> (ø)

...mmingbird/ml/operator_converters/sklearn/skl_sv.py
97.14% <100.00%> (ø)

...l/operator_converters/onnx/onnxml_tree_ensemble.py
84.10% <0.00%> (-7.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810ba11...c9d5555. Read the comment docs.

This PR introduces a breaking change because we are now returning a container rather than a onnx model as result. I added an option to disable the converter, but by default I would like to have containers on because they give us a uniform API. We will have to update the onnxmltools if this PR is merged as is.
@ksaur


Tetsuya Yamamoto: Watch buttwelding-pipe-fittings

Tetsuya Yamamoto requests the watch of the watch_keyword buttwelding-pipe-fittings. See the Metasmoke search here and the Stack Exchange search here.

buttwelding-pipe-fittings has been seen in 1 true positive, 0 false positives, and 0 NAAs.

!!/approve

Coverage remained the same at 65.573% when pulling 149260ce9ce25a74b4443d57090984247e3991ca on auto-blacklist-1513318610.4403212 into 9226f82835e3af397e32223ad52c6ce58b3c4135 on master.


Day Use displaying Back Country Cabins

When a user navigates to enter data for a Day Use activity on any subarea the title of the page shows as Back Country. This ticket is to update that title to the correct wording.
Acceptance Criteria

Day Use page has correct title

Tested on TEST: Passed

Verified that this issue has been fixed.


OSGI Implementation

Hi, I have created some OSGi support for liquibase.
The main piece of "payload" code is "OSGIPackageScanClassResolver.java". That provides (what I believe to be) multi platform osgi support. I have also included a sub project to produce a usable bundle with a different name. To me that seems easier than trying to include more functionality in the core. Feel free to merge this back into the core project if you prefer. The major change this required was making ServiceLocator a "less strong" singleton so I could inject the right implementation during bundle activation.
I also did not test, and wouldnt be surprised, if other advanced features like hibernate or spring support wouldn't work inside OSGi but I do know that it handles changelog files correctly and will update a database (which is really all you need inside the container).
If you accept this patch you should remove the osgi.bnd file and maven-bundle-plugin from the core project.
LICENSE: all changes are licensed under Apache 2, if you want a CLA let me know.
Disclaimer: I looked at the other osgi support pull request but I believe this is a better approach that should be more portable. I can only test this in karaf/felix container but I believe it should work in Equinox. If not the activator can be made to detect the framework and use the FileLocator implementation for that container.

Looks like this could close:
http://liquibase.jira.com/browse/CORE-706

Hi Sam,
I'm excited to see cross-platform OSGi support.  I'd be happy to test this on Equinox and report back my findings.  I'll try to get back to you by the end of the week.
Thanks,
Michael

Looks good, thanks!


LateInitializationError: Field '_cameraController' has not been initialized.

The field _cameraController should be nullable to prevent that dispose is called before the controller has been initialized.
void startPreview(
  ResolutionPreset resolutionPreset,
) async {
    await _cameraController.dispose();
    ...

    _cameraController = CameraCameraController(
      ...
    );

Sent a PR https://github.com/gabuldev/camera_camera/pull/52
Before it gets merged and released can be installed from github directly:
camera_camera:
    git:
      url: https://github.com/mattermoran/camera_camera.git
      ref: master

MERGED GUYS! Thanks @mattermoran


closeOnExcept -> withResources in MetaUtils

Signed-off-by: Alessandro Bellina<EMAIL_ADDRESS>This fixes a couple of leaks in MetaUtils. It also replaces the use of ArrayBuffer with Array such that the appropriate impl of withResources is picked.
Thanks to @jlowe to help triage this.

build

This is breaking related tests locally and in CI also. I had machine troubles so didn't run the tests beforehand until now. Please hold on reviewing until that is fixed.

Ok sorry for the confusion, this one looks better now. Will trigger CI again.

build


False positive fix for "Remove the '?'"

If we have code like
UnknownType? getValue() {
  return null;
}

if (getValue() case final valueX?) {
  return Text(valueX);
}

When my UnknownType type is InvalidType because like in cases when maybe imports are wrong, or generated code is not generated, fix (we have auto fix on save) removes the ?.
The fix is there because of this code https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/lib/src/services/correction/dart/remove_question_mark.dart#L45 which is probably missing some check for InvalidType in which case it should not suggest the fix.

I tried to implement this change to not suggest this fix (removing ?) when the type of condition is InvalidType.
Maybe something like this
    if (targetNode is NullCheckPattern) {
      var targetIfStatement = targetNode.enclosingIfStatement;
      var condition = targetIfStatement?.expression;
      // Ignore if the condition is of invalid type.
      if (condition?.staticType is InvalidType) {
        return;
      }

      var questionMark = targetNode.operator;
      await builder.addDartFileEdit(file, (builder) {
        builder.addDeletion(range.token(questionMark));
      });
    }

But the issue is with test -- I cannot figure out how to make it work. I tried something like this:
  Future<void> test_casePatternInvalidType() async {
    await resolveTestCode('''
UnknownType? getValue() => null;
void f() {
  if (getValue() case final valueX?) {
    print(valueX);
  }
}
''');
    await assertNoFix();
  }

When I try to model the example, and assert that no fix is suggested, it keeps crashing with "Undefined class 'InvalidType'":
00:00 +2 -1: RemoveQuestionMarkTest | test_casePatternInvalidType [E]

  Expected one error, found:
    /home/test/lib/test.dart(0..10): Undefined class 'InvalidType'. [CompileTimeErrorCode.UNDEFINED_CLASS]
    /home/test/lib/test.dart(46..56): Undefined class 'InvalidType'. [CompileTimeErrorCode.UNDEFINED_CLASS]
    /home/test/lib/test.dart(108..108): The null-check pattern will have no effect because the matched type isn't nullable. [StaticWarningCode.UNNECESSARY_NULL_CHECK_PATTERN]

  package:matcher/src/expect/expect.dart 149:31                                              fail
  pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart 63:7               BaseFixProcessorTest._findErrorToFix
  pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart 400:23             FixProcessorTest.assertNoFix
  pkg/analysis_server/test/src/services/correction/fix/remove_question_mark_test.dart 80:11  RemoveQuestionMarkTest.test_casePatternInvalidType

So if somebody can help me how I can do the test so I can ignore this error and test that in such cases no fix is suggested, I would appreciate it because then I will be able to finish a PR for this fix.

Implemented in https://dart-review.googlesource.com/c/sdk/+/394403

@bwilkerson sorry for maybe misleading error message. The error was about my UnknownType (I just used InvalidType before directly first that is why it's confusing). I also noticed I can filter this error in the test.
But I will check that StaticWarningCode.UNNECESSARY_NULL_CHECK_PATTERN later. It sounds as a better approach. Thanks.

@bwilkerson I made changes so we don't report StaticWarningCode.UNNECESSARY_NULL_CHECK_PATTERN in this case. But I kept tests in remove ? since we probably wanna make sure this will not change. :)

We generally don't have tests for situations that are known to not occur. I haven't looked at the updated CL yet, but if there are tests to ensure that the diagnostic isn't reported when it shouldn't be, then we don't need tests to ensure that the fix isn't offered in those cases.


Only some videos can be downloaded from Lecturio

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.01.03
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl -v --cookies cookies.txt https://app.lecturio.com/#/lecture/c/8466/8468/29284
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--cookies', u'cookies.txt', u'https://app.lecturio.com/#/lecture/c/8466/8468/29284']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.01.03
[debug] Python version 2.7.18 (CPython) - Linux-4.4.0-19041-Microsoft-x86_64-with-Ubuntu-20.04-focal
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[Lecturio] 8468: Downloading JSON metadata
ERROR: An extractor error has occurred. (caused by KeyError(u'content',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/lecturio.py", line 122, in _real_extract
    for format_ in video['content']['media']:
KeyError: u'content'
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 803, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 824, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 545, in extract
    raise ExtractorError('An extractor error has occurred.', cause=e)
ExtractorError: An extractor error has occurred. (caused by KeyError(u'content',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Some videos from this platform can be downloaded, but the vast majority cannot, I tried to download this and other videos and I always got this problem.
I attach video with a video that I can download and another that I cannot download
https://user-images.githubusercontent.com/58005697/103598392-19e81d00-4ec8-11eb-83b0-dc8b1a18979e.mp4

I saw that they added a tag, I have a Lecturio account, but I don't know how to log in to download the videos.

I saw that they added a tag, I have a Lecturio account, but I don't know how to log in to download the videos.

Having the exact same issue:
youtube_dl\extractor\lecturio.py", line 122, in _real_extract KeyError: 'content'


write_all() missing 1 required positional argument: 'options'

I get this error when transcribing my video in google drive.
Traceback (most recent call last)
 in <cell line: 102>()
111
112     # Save output
--> 113     whisper.utils.get_writer(
114         output_format=output_format,
115         output_dir=video_path_local.parent
TypeError: write_all() missing 1 required positional argument: 'options'

I just tried this for the first time and I got the same error.

i think error from this commit: https://github.com/openai/whisper/commit/43940fc9780cb91c4f94899755b4648e19d7b977

i think error from this commit: openai/whisper@43940fc

I think so. But this project also needs to be fixed.

You may use my version. to wait for the main version to update.
https://github.com/naruepanart/google-colab-whisper

You may use my version. to wait for the main version to update.
https://github.com/naruepanart/google-colab-whisper

OK thanks. I will feedback.

You may use my version. to wait for the main version to update.
https://github.com/naruepanart/google-colab-whisper
the application takes no action.

Thanks for raising the issue and finding the source of the bug! I fixed the problem in 63088b9c9cf98b10ef6218cc33a2e98678833c5f.


Links in cache-logs not working

As mentioned in #1033 the not working links in TB-logs are also an issue for cache-logs:
Example GC2Y6EQ , I attached a GCVote link to my log from 24.01.2012.

I'm not even sure if there really was a bug here. For me it looked more like it takes several tries to click only the link, but not the surrounding text.

That was why I initially not raised this issue, because I just thought my fingers are to fat :-)
I will try it again with your change


Remove unused methods from ElementNode

This clean up seems correct, since it's only used in ListItemNode and can be defined there and taken outside of 'Core', however ultimately leaving to @acywatson and @zurfyx to decide if happy with this clean up or there was a plan to use this method in some fashion beyond lists.

Just noticed a similar situation with canReplaceWith and canInsertAfter. They aren't even used anywhere, only defined on both ElementNode and ListItemNode. Probably, there is more. It'd be good to clean up this stuff. The ElementNode API page looks a bit intimidating because of all these methods that don't have any description. They look especially suspicious when you subclass ElementNode and have to wonder whether you need to override any of those.

Wow, I didn't realize we aren't using these. Great to clean this up.
I wonder when the callsites were removed...

As these are part of the public API, it's probably best to formally deprecate them, then remove them in a later version.

@acywatson is it good now?


Completed Challenge along with additional bonus code

Thanks @donricouga Really appreciate your work. Matt should be reaching out to you about next steps.


terminalizer render error

On: Debian 10
I get an error running terminalizer render test
***@j***debian-gnu-linux:****/$terminalizer render test.yml test.gif
Error:
  Error: [6406:0819/224214.857920:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /usr/lib/node_modules/terminalizer/node_modules/electron/dist/chrome-sandbox is owned by root and has mode 4755.

I have set the owner of that folder to root and the mode to 4755, I also try as root
agl@jakka351-debian-gnu-linux:~/can0swc$ sudo terminalizer render test.yml test.gif
Error:
  Error: [6420:0819/224220.463392:FATAL:atom_main_delegate.cc(211)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.

Hint:
  Use the --help option to get help about the usage
agl@jakka351-debian-gnu-linux:~/can0swc$

Any ideas?

You can check that the directory exists
 ls /usr/lib/node_modules/terminalizer/node_modules/electron/dist/chrome-sandbox
If it does, change the owner to root as it says
sudo chown -R root /usr/lib/node_modules/terminalizer/node_modules/electron/dist/chrome-sandbox

Error:
  Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/terminalizer/render/frames'

Hint:
  Use the --help option to get help about the usage

got it working thanks

got it working thanks

I have this problem, how did you solve it?


add a new option in $ getEmbed

add something in $getEmbed in the fvalue example there are 2 addFields the A B example fvalue: A and so on

It has been added.


Be able to use workspaces dependencies and tsconfig paths in contentlayer.config.ts

Hello.
I think it would be great to be able to use workspaces and Typescript paths related dependencies in contentlayer.config.ts.
For instance, if I try it in my tailwind.config.ts
// tailwind.config.ts
import { buildPathFromParts } from '@repo/shared-lib/str';
console.log(buildPathFromParts('hello', 'world'));

All works as intended.
But if I do the same in contentlayer.config.ts
Then, I get an error:
ConfigReadError (/home/me/Delivery/project/contentlayer.config.ts): Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/me/Delivery/project/node_modules/@repo/shared-lib/str' imported from /home/me/Delivery/project/.contentlayer/.cache/v0.3.4/compiled-contentlayer-config-KYFR5QIE.mjs
ConfigReadError (/home/me/Delivery/project/contentlayer.config.ts): Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/me/Delivery/project/node_modules/@repo/shared-lib/str' imported from /home/me/Delivery/project/.contentlayer/.cache/v0.3.4/compiled-contentlayer-config-KYFR5QIE.mjs

It's quite annoying because I can't do anything other than imports with absolute or relative paths.
I can't use the paths in my tsconfig.json, and I can't use some of my third-party libraries, unless I adapt them entirely and have to write everything in relative or absolute path in them too.

:<

.

.

:cry:

.

Hi, I have met a similar issue. Do you find any solutions?

no, sorry


feat: Upgrade Swagger UI to 5.0.0 with OpenAPI 3.1 support

Pull Request Checklist

[ ] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description
Close Issue(s)

So, we also have a workaround in the controller that needs to be removed. Namely, there is a modified version of the schema

Rolls back the changes from this PR: https://github.com/litestar-org/litestar/pull/892

@cofin this needs removing - https://github.com/litestar-org/litestar/blob/main/litestar/openapi/controller.py#L290


Broken dashboard

There seem to be changes in the data graphs due to the new adguard home update.

I have updated to v0.107.44 and I don't see any issues on the graphs

I have updated to v0.107.44 and I don't see any issues on the graphs

Try holding down

I don't see any issues with the tooltip. Can you attach a screenshot of the problem?

I don't see any issues with the tooltip. Can you attach a screenshot of the problem?

https://github.com/JGeek00/adguard-home-manager/assets/75412448/c96a68fe-b7b7-45e3-9fdc-deb47c7d4b8e
This is where I mean, you see the range when I hold it down. Also the graph was not like this before, it was sharper.

Same for PC version

By the way, the result is the same after a clean installation.

By the way, the result is the same after a clean installation.

I think that depends on the statistics retention time that you have configured

I think that depends on the statistics retention time that you have configured

Yes, both set for 7 days. But I would like to point out that this happened after the update.

In that case there's nothing wrong there. You see that "jumps" when you hold the chart because the data points that draw the chart are very separated from each other. There are 7 data points, one for each day.

In that case there's nothing wrong there. You see that "jumps" when you hold the chart because the data points that draw the chart are very separated from each other. There are 7 data points, one for each day.

I found an old screenshot, it shows daily, but before it was showing hourly

Ok I think I understand now, is this the change on adguard home?

Ok I think I understand now, is this the change on adguard home?

I thought it was a mistake at first, I just checked the web panel now and realized the difference... For me the old version was better


Split DNS proxy to docker embedded dns

Is this possible? Trying to find a way to set this up

As far as I know, in its internal DNS server Docker only exposes containers that the container you are running in can access.
To get the addresses for all containers, you could use the Docker API to extract this information, and serve this with your favorite DNS recursor or dnsdist.


Outgoing Messages

I wanted to query a database and then transform the data to a ADT message and send it out. I saw a lot about receiving messages in the documentation, but I'm not sure exactly where to plug-in to send out messages that is not already in native HL7 format.

Hi!
Well... It's kinda depending on the rest of your architecture. HL7Fuse was mostly build with receiving messages in mind, either through the network or through files. Of course it would be possible to write a new plugin that read the database and take it forward from there.
You might be interested in taking a look at the NHaptiTools project https://github.com/dib0/NHapiTools. You can write the database handling and the creation of the HL7 message (using NHapi) and use the SimpleMLLPClient class to send the message to the system you'll need to communicate with. NHapiTools is used for this purpose in HL7Fuse as well.
Hope that helps!

Thanks, for such a quick turnaround. Just a follow-up will SuperSockets/NHapi be able to poll the database on an interval is something like that built-in or do I have to create that mechanism?

SuperSockets and NHapi won't do that for you. SuperSockets (used as a basis for HL7Fuse) is used for event based communication. For example the fileServer (https://github.com/dib0/HL7Fuse/blob/master/HL7Fuse/FileServer.cs) is a bit out of character. Of course you can use that as a basis to create a polling mechanism for a database table and use HL7Fuse like that.
NHapi and NHapiTools (as a addon on NHapi) are purely for creating and interpreting HL7 messages. So if you don't go the HL7Fuse way, you will have to build that part yourself.
But if you are polling a database, take a look at the HL7Fuse FileServerr implementation it might be enough to use that as a basis and create the database polling that suits your need.


Distro interfaces

Introduce new interfaces to represent a distro at a given architecture, and each image type for a architecture/distro pair. Methods on the ImageType object are used rather than passing in architecture and image type to methods on the distro objects, simplifying the code and making the need for much of the common package redundant.
As discussed with @msehnout and @larskarlitski .

Thanks for the reviews! I addressed most, but left some for future work, just because there is so much clean-ups that can be done anyway.
@msehnout I have a pending patch doing all the renames. I will also delete all the redundant code from each of the distro packages (there is now a lot), so shouldn't add much overall.

Travis is green, but forgot to tell Github. Merging it now so we can move forward.


Define timeline for goodtables.io EOL

Reminder that we need to think about this.
@amercader
@lwinfree

I think we can announce it after the successful migration (cc @aivuk)

@sapetti9
@lwinfree
@aivuk
Our migration is going well I think we can sent the second email next week. WDYT?

I agree, all my tests at https://new.goodtables.io and https://try.new.goodtables.io were successful. I think we are good to go.

great!

Email sent.


Show both individual and group results

[x] Group results are displayed after 5 different answers with group tag
[x] Figure out what the summary page looks like without group results
[x] Display group averages
[x] hide group results when not in group
[x] Automatic reload of group stats component
[x] backend test to the group service
[ ] frontend cypress, does group results show correctly

All results (the donut) now show, so there is essentially only the tests left.

Blocked by lack of proper e2e test setup. work in progress.
Backend unit tests can be made by refactoring the function that counts the points.

Backend tests made, now only blocked by test setup


Feedback UI template

Is your feature request related to a problem? Please describe.
We sometimes want our customers to give feedback on our website or some event, etc.
Describe the solution you'd like.
So, we can make a standard feedback UI template which can be used whenever needed.
Describe alternatives you've considered.
.
Add any other context or screenshots about the feature request here.

Something like this. But with better CSS and more pleasant looking.

Please assign this issue to me


_.matches only validates own properties[fix #1986]

I have changed _.matches to only match properties which are declared
directly on the object being passed to the predicate function generated
by _.matches.
I have accomplished this by testing the property on the object passed in
using the method hasOwnProperty method instead of the in operator.
I have included specs to demonstrate how this functionality works and
when it should return true or false.

I'm -1 for this, it's pretty common in my experience for variables to be set on the prototype that I would expect to be found by matches
Here's a shotty example (as I'm in the middle of writing a report and can't think of something more appropriate)
var Cla = Backbone.Model.extend({
   idAttribute: "foo"
})

var c = new Cla();
_.matches(c, {
  idAttribute: 'foo'
})

I would expect that to yield true not false

I think that having a consistent behavior with comparisons (matches & isEqual) is a good thing and allows for expansion into partial deep comparisons. The addition of #2045 would handle your case in a much more efficient way. This also keeps a clear distinction between property style methods like pluck, omit, pick and comparison methods like matches and isEqual.

Closing with #1986.


Whitespace normalization

Issue Type: Feature Request
It would be awesome if the Python extension helped me keep my whitespace correct according to flake8, namly auto-trimming whitespace at the end of lines and leaving only one blank line at end of file...
Extension version: 2019.4.11987
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17763

Why not use a formatter.
Right click on a file and format the file, then select a formatter.
https://code.visualstudio.com/docs/python/editing#_formatting
You can configure VSCode to save files automatically and format on save.
This way, as you make changes to a file, it's formatted automatically.

Perhaps it is a bug in the formatter then, I'm using this formatter, but it does not strip whitespace from the end of lines:

This can be done using the VS Code editor settings, see below:

ah, I should have found that, perfect thanks.


Adding GUI mssautoplot CLI tool

Adding GUI to the mssautoplot CLI tool.
Following changes are made:

Adding the ui_mssautoplot_gui.py, ui_mssautoplot_gui.ui files corresponding to the GUI.
Refactoring the mssautoplot main function so that the GUI can make functional calls to it.
changing QtCore.Signal() and QtCore.Slot() to QtCore.pyqtSignal() and QtCore.pyqtSlot() as they are no longer supported in PyQt5 (https://github.com/picotech/picosdk-python-examples/issues/2).
Minor fix in wms_control.py regarding attribute fig.

Pretty cool!

Some questions:

How do I access the GUI? I can call it directly in the qt5/ui folder. Is this intended?
There seems to be a mistype with self.config_edit. Should this be self.ConfigPathlineEdit ?
I am a bit lost. Could you supply a working example with necessary files for loading in etc?

Hi @joernu76 ,

Some questions:
1. How do I access the GUI? I can call it directly in the qt5/ui folder. Is this intended?

It is supposed to be called as mssautoplot --gui. I haven't implemented that yet. Will do soon.

2. There seems to be a mistype with self.config_edit. Should this be self.ConfigPathlineEdit ?

Ah, I'll look into it.

3. I am a bit lost. Could you supply a working example with necessary files for loading in etc?

Sure.
I just realized that some work needs to be done in the side view part. Side view in the GUI doesn't work as of now. I'll write a detailed documentation after that.


[WIP] API registrations

:star: Registration endpoints will be absorbed into draft_registrations.  DraftRegistration model is undergoing more changes.  Therefore, this PR will most likely close and a new one will be opened, with #3476 as a dependent.
 Purpose
References Issue #3046.  API needs to reflect upcoming changes to registration functionality.  User will be able to view draft registrations of a node, and create a draft registration of a node.   Then, the user can update that draft registration, get draft registration detail, get all draft registrations, and delete a draft registration.  Finally, the user can view all registrations, and create a registration from a draft registration.
Note: Creating a registration from a draft registration will be a two-step process.

User sends a POST request for registration containing draft id.
 Server returns 202 response with a message telling them they are about to register the project and a new URL containing a token.
 User submits second POST request to new URL.
 Registration is created provided tokens match.

 Changes
New endpoints:

[X] GET /v2/nodes/{node_id}/draft_registrations/
[X] POST /v2/nodes/{node_id}/draft_registrations/
[X] GET /v2/draft_registrations/
[X] GET /v2/draft_registrations/{draft_reg_id}/
[X] PUT /v2/draft_registrations/{draft_reg_id}/
[X] PATCH /v2/draft_registrations/{draft_reg_d}/
[X] DELETE /v2/draft_registrations/{draft_reg_id}/
[X] GET /v2/registrations
[X] POST /v2/registrations/
[X] POST /v2/registrations/{token}

Remaining issues:

[ ] Handling case when schema version does not exist
[x] DraftRegistration field registration_schema is not persisting (ensure_schemas is deleting)
[ ] Registering node is simultaneously setting node.is_deleted equal to True (archiver failing?, Sam fixing)
[ ] Registering node is not setting node.registered_from (related to above, registered_from set to null, Sam fixing)
[x] Tests require use of eval to access fields within response fields.  For example, branched_from returns the node fine, but to access that node's title, I need eval
[x] Hide extra serializer fields for creating registrations from drafts

 Side Effects
New swagger documentation:

Outdated PR.  Registrations have changed a great deal.  Will open a new one.


AttributeError: 'NoneType' object has no attribute '_getBearerToken'

I'm having a problem trying to create a node in lavapy.
Task exception was never retrieved
future: <Task finished name='Task-1' coro=<initialiseNodes() done, defined at C:\Users\Admin\Desktop\spaced_retention\testing discord.py:276> exception=AttributeError("'NoneType' object has no attribute '_getBearerToken'")>
Traceback (most recent call last):
File "C:\Users\Admin\Desktop\spaced_retention\testing discord.py", line 282, in initialiseNodes
await lavapy.NodePool.createNode(client, "<IP_ADDRESS>", 2333, "youshallnotpass",identifier='TEST',region=discord.VoiceRegion.singapore)
File "I:\Python\Python310\lib\site-packages\lavapy\pool.py", line 135, in createNode
await node.spotifyClient._getBearerToken()
AttributeError: 'NoneType' object has no attribute '_getBearerToken'
Help is appreciated 👍🏿

The PyPi version is not the same version as this version so it doesn't include the Spotify extension. Also I'm still actively developing this branch so its very unstable right now.


[Question] syntax highlight for yard comments in visual studio code

This is not a bug but a question to yard community.
Did one of you found a way to have color syntax highlight for yard comments in visual studio code (vscode)?
Else it is hard to read the documentation in the source code.

I have read the Contributing Guide.

Hi @noraj I noticed that it might be the theme you are using in VS Code.  I am using Night Owl and I can see the comments pretty clearly/ .

@shoesCodeFor I think you didn't understand. Your example is all green because your theme put comments in green, my example is all grey because my theme put comments in grey.
I didn't say it was not easy to read because of the color but because there is no syntax highlight of teh yard documentation as VSCode is seeing it as a simple comment.

@noraj you are right I misunderstood.  I think the functionality you are requesting would be a VS Code plugin like Document This.  My mistake :)

I think I can do this.
I'll get on it.

Will post updates to this issue.

So the most popular Ruby support plugin for VS Code identifies most Yard components save for leading comments.
Here are examples of highlighting applied to all identified elements.

Can I get thoughts/input?

@tcd Yeah something like the first screenshot would be awesome.

@noraj Just pushed the changes.

@noraj I actually rolled the changes back... they were a bit distracting.
But if you want the highlighting from those screenshots, you can put this in your settings.json:
(first screenshot)
"editor.tokenColorCustomizations":
   "textMateRules": [
      {
          "scope": [
              "comment.line.keyword.punctuation.yard.ruby",
              "comment.line.keyword.yard.ruby",
              "comment.line.parameter.yard.ruby",
              "comment.line.type.yard.ruby",
              "comment.line.string.yard.ruby",
              "comment.line.punctuation.yard.ruby",
           ],
           "settings": {"foreground": "#608b4e"},
      },
   ]
}

(second screenshot)
"editor.tokenColorCustomizations":
   "textMateRules": [
      {
         "scope": [
             "comment.line.keyword.punctuation.yard.ruby",
             "comment.line.keyword.yard.ruby",
             "comment.line.parameter.yard.ruby",
             "comment.line.type.yard.ruby",
             "comment.line.string.yard.ruby",
          ],
          "settings": {"foreground": "#608b4e"},
      },
      {
          "scope": "comment.line.type.yard.ruby",
          "settings": {"foreground": "#4ec9b0"},
      },
      {
          "scope": "comment.line.parameter.yard.ruby",
          "settings": {"foreground": "#9cdcfe"},
      },
      {
          "scope": "comment.line.punctuation.yard.ruby",
          "settings": {"foreground": "#505050"},
      },
   ]
}

Or you can change the foreground colors to anything you'd like.

@tcd I installed dark-plus-syntax and add the following to my settings but I still have default comments.
    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": [
                    "comment.line.keyword.punctuation.yard.ruby",
                    "comment.line.keyword.yard.ruby",
                    "comment.line.parameter.yard.ruby",
                    "comment.line.type.yard.ruby",
                    "comment.line.string.yard.ruby",
                ],
                "settings": {
                    "foreground": "#608b4e"
                },
            },
            {
                "scope": "comment.line.type.yard.ruby",
                "settings": {
                    "foreground": "#4ec9b0"
                },
            },
            {
                "scope": "comment.line.parameter.yard.ruby",
                "settings": {
                    "foreground": "#9cdcfe"
                },
            },
            {
                "scope": "comment.line.punctuation.yard.ruby",
                "settings": {
                    "foreground": "#505050"
                },
            },
        ]
    }

Anyway I won't keep this theme, I love one dark pro too much. Yard syntax should be added in a dedicated syntax highlighter plugin not in a theme.

@noraj that's fair, I too like one dark pro.
Regarding the groups, though, they're added by this plugin, not my theme. (Which I pointed out back in this comment😉).  Themes typically don't define groups, they just assign colors to them.

@tcd Thanks I try this plugin immediately. And if not too complicated i'll try to create a Yard syntax plugin.

Marking this as closed since this seems unrelated to YARD but there is some great work in here, would love to see it published to the marketplace 👏🏻👏🏻