perf(crypto/merkle, crypto/tmhash): simplify+optimize SHA256 hashing of multiple byteslices

This change adds a more efficient API in tmhash with "SumMany" whose job is to produce the SHA256 sum of multiple byteslices. It is used inside crypto/merkle.innerHash which used a naive and inefficient way of hashing multiple byteslices. Benchmark results reflect these improvements:
$ benchstat before.txt after.txt
name         old time/op    new time/op    delta
InnerHash-8     161µs ± 1%     160µs ± 5%     ~     (p=0.143 n=10+10)

name         old alloc/op   new alloc/op   delta
InnerHash-8    69.1kB ± 0%    60.1kB ± 0%  -12.98%  (p=0.000 n=10+9)

name         old allocs/op  new allocs/op  delta
InnerHash-8      24.0 ± 0%      23.0 ± 0%   -4.17%  (p=0.000 n=10+10)

Fixes #1881

/cc @ValarDragon @elias-orijtech @thanethomson @lasarojc

LGTM, thanks for reducing allocation overhed! Though the changelog comment of "much more efficient" seems a bit odd. Its a non-existent time speedup, and a 10% allocation reduction!

Thanks for the reivew @ValarDragon! I don't follow what you mean by "non-existent time speedup and 10% allocation reduction" precluding efficiency -- innerHash is called a whole lot inside crypto/merkle which is a critical package, in fact even if it were a 5% allocation reduction I'd call it that because the API change means no wastage of CPU cycles but also the runtime doing less work. Also we've had quite the rhetoric in the Cosmos community of "optimizations must be huge updates or re-engineer the whole thing" but sadly that leads to a ton of inefficient code patterns that linger for 7+ years, moreover very few people (except yourself and Osmosis) actually profile code but even then folks aren't looking at profiles intently hence massive bloats.
Thanks for the code reviews @ValarDragon and @melekes!

@odeke-em could you please fix the build error:
# github.com/cometbft/cometbft/crypto/merkle [github.com/cometbft/cometbft/crypto/merkle.test]
Error: crypto/merkle/bench_test.go:4:2: "bytes" imported and not used


webview: adding page-title-set event

Fixes #1316 , currently we have worked around getURL to return the right value using setVirtualURL , this event will not be fired when there is no title explicitly set as it will shortcut here since the value of final_title will be blank not the file name.

:heart: :tada: :bow:

@steelbrain nope.

@deepak1556 You should :wink:

There is a page-title-updated event in BrowserWindow, I think we should use the same name in WebContents to keep consistent.

@zcbenz Yup but the payload for both these events were quite different and you cant cancel the event. So didnt wanted to create confusion.

It sounds reasonable to me, thanks!


NETOBSERV-915 add conversation direction

This PR adds direction fields to conversation tracking
Also it disable TCP flags that generates duplicated events in Pod to Pod conversations. That may be related to out of order flows
Related PRs:

https://github.com/netobserv/network-observability-console-plugin/pull/317
https://github.com/netobserv/flowlogs-pipeline/pull/413
https://github.com/netobserv/flowlogs-pipeline/pull/430

/hold

/hold

updated operation names https://github.com/netobserv/network-observability-operator/compare/34061af2b98ecc5371c41526939e7637675f71e4..a659f27b573a14ce30f35d4f06b7edeffe8a88ff

/lgtm

/ok-to-test

/ok-to-test

rebased https://github.com/netobserv/network-observability-operator/compare/5b14c6c542de1d6dcf4377d3cf54fe630709c7ba..3ce1b5bacf6a25927ba2fd1c39e95e563b14a651

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/label qe-approved

/lgtm

/approve


Added renames from Windows -> WindowsApp

Renaming Windows namespace to WindowsApp.

/azp run

/azp run

Did you run the TAEF tests and the demo app as part of this change?

Did you run the TAEF tests and the demo app as part of this change?

Yes. All tests passed with the namespace changes.

/azp run

/azp run

/azp run

You'll want to hold off completion until you hear the latest guidance

Guidance was to leave as Windows.


added virtualenv indication to the python module

I don't know if not including it was intentional but I think it's useful

Thanks @jaredmontoya


Fix build_debs to add signing directory to PYTHONPATH

Signed-off-by: Jamie Jason<EMAIL_ADDRESS>

This is a temporary fix so that PR 188 can pass.

@peterschwarz Yes, I have some build stuff in the works.


Ceedling not working with Ruby 3.2.2

I did a fresh install of Ceedling, and it is incompatible with Ruby 3.2.2.
ceedling example temp_sensor
C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/ceedling-0.31.1/bin/ceedling:12:in `<top (required)>': undefined method `exists?' for File:Class (NoMethodError)

  project_found = File.exists?(main_filepath)
                      ^^^^^^^^
Did you mean?  exist?
        from C:/Ruby32-x64/bin/ceedling:32:in `load'
        from C:/Ruby32-x64/bin/ceedling:32:in `<main>'

I tried making changes manually in the ceedling Ruby files, but there's only so many things I can fix without breaking other things in a codebase and a language I know nothing about. And I am also finding it difficult to downgrade Ruby.
I do understand that Ceedling is compatible with Ruby 2.something and that it cannot be made compatible with the latest Ruby release. My request is to kindly include the specific instruction to install the compatible Ruby version in the tutorial at your website and where to download it from. And if possible, also instructions on how to downgrade to the correct Ruby version.
Thanks in advance.

Ceedling CAN be made compatible with Ruby 3 and IS already. There's an in-progress gem working towards the next release which has Ruby 3 compatibility under Releases. It seems to work solid for anyone not using preprocessing at the moment, but the preprocessor support is currently being updated and isn't working in that branch.

I had exact same error with Ruby 3.2. It seems to be due to the use of exists? method, which is deprecated. I think that since ruby 3.2 only the exist? one is recognized.

Correct. As I mention above, it's been fixed already if you grab the pre-release gem.

Noted, I will try the pre-release gem whenever I get the time to do so. In the meantime should this issue be closed?

Sorry, where can I find pre-release gem?

https://github.com/ThrowTheSwitch/Ceedling/releases

Hi, I've just installed ceedling 0.31.1 and it does not work with ruby 3.2.2 as stated in this issue.
It should be better documented which ruby version ceedling is compatible to.
https://rubygems.org/gems/ceedling/versions/0.31.1 mentions REQUIRED RUBY VERSION: >= 2.4.0

As mentioned above, that was true when this version was released. This issue has been resolved. Just grab the pre-release gem.

I took the 0.32 version and it does not work. "ceedling test" does not compile foo.c even if test_foo.c includes foo.h.
I then installed ruby 2.7.8 and got the ceedling 0.31 and the issue is gone. I will stick with these versions then.

Im facing the same issue. I installed as suggested the pre-release version, to be precise i installed 0.32.0-c67c010 , but its still broken. When can we expect a fix?
ruby vendor\ceedling\bin\ceedling clobber  vendor/ceedling/bin/ceedling:12:in ': undefined method `exists?' for File:Class (NoMethodError)
project_found = File.exists?(main_filepath)
                  ^^^^^^^^

Did you mean?  exist?`
eedling version Welcome to Ceedling!                                                                                Calling DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call DidYouMean.correct_error(error_name, spell_checker)' instead.                                                                       Ceedling:: 0.32.0                                                                                CMock:: 2.5.4                                                                                Unity:: 2.5.4                                                                                CException:: 1.3.3
ruby -v                                                                                ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x64-mingw-ucrt]

Thanks for the swift reply. You are right, i did update my gem by running: gem update ceedling. I have now reverted everything. But i still get the error ruby vendor\ceedling\bin\ceedling clobber  vendor/ceedling/bin/ceedling:12:in ': undefined method `exists?' for File:Class (NoMethodError)
project_found = File.exists?(main_filepath)
                  ^^^^^^^^

Did you mean?  exist?`
How do i do this:  "You can delete and re-import the vendored ceedling"?

Our upgrade process isn't awesome yet. The easiest way at the moment would be to do this:

delete your vendor directory and everything in it
outside of your project, run ceedling new temp_project --local
copy the vendor directory from the new temp_project to your project

There are also some breaking changes in the latest release that you run into, primarily regarding the way includes are handled. If you were relying on your headers being found in your source paths, then you will need to clone them to an include entry in your project.yml as well, like this:
:paths:
  :source:
    - folder1
    - folder2
  :include:
    - folder1
    - folder2

@mvandervoord I still get an issue with 'SPELL_CHECKERS' being deprecated:

I pulled the most recent release of the 0.32.0 pre-release candidate:
https://github.com/ThrowTheSwitch/Ceedling/releases/tag/0.32.0-c67c010

Thanks  @mvandervoord for the upgrade process, it solved most of the wierd errors. Now it almost works and looks clean only that i get this when i run once of my test module:
`D:\temp\Test\Deploy\test\ceedling_test>ruby vendor\ceedling\bin\ceedling test:test_fls.c --trace
#<Thread:0x000001f6e96d1460 D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/par_map.rb:8 run> terminated with exception (report_on_exception is true):
Preparing Build Paths...
Extracting Build Directive Macros
Parsing test_fls.c...
D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:168:in `gsub!': invalid byte sequence in UTF-8 (ArgumentError)
content.gsub!(/\/\/.*$/, '')
              ^^^^^^^^^^^^^
from D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:168:in `remove_comments'
from D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:111:in `extract_build_directives'
from D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:22:in `collect_build_directives'
from D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/preprocessinator.rb:29:in `extract_test_build_directives'
from D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_invoker.rb:76:in `block (2 levels) in setup_and_invoke'
from D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/par_map.rb:11:in `block (2 levels) in par_map'

rake aborted!
ArgumentError: invalid byte sequence in UTF-8
D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:168:in gsub!' D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:168:in remove_comments'
D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:111:in extract_build_directives' D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_context_extractor.rb:22:in collect_build_directives'
D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/preprocessinator.rb:29:in extract_test_build_directives' D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/test_invoker.rb:76:in block (2 levels) in setup_and_invoke'
D:/temp/Test/Deploy/test/ceedling_test/vendor/ceedling/lib/ceedling/par_map.rb:11:in `block (2 levels) in par_map'
Tasks: TOP => test:test_fls.c
(See full trace by running task with --trace)

OVERALL TEST SUMMARY
No tests executed.
`
my include paths look okay i guess:
:paths:   :test:     - +:test/**     - -:test/support   :source:     - ../../input/swc_bsw/core/mcal/fls     - ../../input/swc_bsw/pjspec/mcal_cfg/fls_cfg     - ../../input/swc_bsw/pjspec/autosar_stack/integration/src     - ../../input/swc_bsw/core/fls_if   :include:     - ../../input/swc_bsw/**     - ../../src/**     - ../../input/swc_com/**     - ../../input/swc_sbc/**   :support:     - test/support   :libraries: []
Do you have any hints here? Thanks in advance

I have put lots of effort in writing my testcases its unfortunate that Ceedling is broken with Ruby 3.2.0, And the amount of attention that this issue is given is quite low. Ill have to downgrade my Ruby installation, its too frustrating. The statement  REQUIRED RUBY VERSION: >= 2.4.0 is just misleading! How unfortunate for such a great tool.

It appears the issue above is that the mentioned file contains an illegal character. Often this is a character from a foreign language or the like. Ruby has changed the way they handle these issues over time. The newer versions of Ruby are stricter about these issues.

Thanks, i cleaned up the non UTF-8 characters, now it almost works. But the change of the of how includes are handled brings up this error: `reparing Build Paths...
Extracting Build Directive Macros
Parsing test_fls.c...
Ingesting Test Configurations
Collecting search paths, flags, and defines for test_fls.c...
Collecting Testing Context
Extracting #include statements via preprocessor from test_fls.c...
Using fallback regex #include extraction for test_fls.c...

And exited with status: [pid 14080 exit 1].

` command-line string limitation because of many include paths. Is there a way to go about this? I didnt have this problem in the older version.

Yes. The new Ceedling introduces more flexible includes handling, actually to handle exactly the sort of problem that you've run into. Here are two phases:
(1) Update your :paths: :include: section of your project yaml file to only include the directories that you want the majority of your tests to include.
(2) For tests that need additional include files, you can add the required directory(ies) to that test directly. For example, if I wanted to add the directory ../../src/project_versions to one of my test files, then in that test file (likely after it's #include statements), I'd add the following:
TEST_INCLUDE_PATH("../../src/project_versions")

In this way, you can control which include paths are used in each test. This keeps the list from getting too long. It also allows you to handle situations where there are multiple header files called the same thing, but located in different folders, etc.
This also lays the groundwork for future automatic optimizations, but those are not included at this time.

Ok, thanks. That's actually a very good idea. I've already started updating my include paths, but I've hit another obstacle.
So I've noticed something that doesn't work anymore as expected (before). Let's say I have a folder ../../src/common/inc with a bunch of include files, and since these files are used a lot, I would add this to the project.yml as my common include path. Inside this folder, I have a header file header_a.h (some legacy code) which has some weird includes, and I don't want to deal with them. So normally, I would add a new file with the same name in the support folder and remove the wierd includes. This way, when my test module is compiled, it would always use the new file located under support. Now this doesn't work anymore. It looks as if the support path is no longer default. How can I deal with this in the new Ceedling version?

No, this isn't intentional. Thanks for bringing it up.
Just to clarify:

the part where you ignore header_a.h seems to be working.
the part where support is automatically added to your path no longer seems to be working.

Correct?

I would like to second that gem install ceedling which installs ceedling 0.31.1 for me on Windows 11 does not work with Ruby 3.2.2. Until this issue is fixed, I request the README be modified accordingly and/or a check added to Ceedling to check for version compatibility.

Or you google and find this issue which clearly states there is a problem.

I test Ceedling for a new project and run into the same issue. Thanks for this thread which helped me to get it running with Ruby 2.7.8. This works fine and the Ceedling evaluation is positive. But I am now unsure whether I should really use ceedling for a new project when it only works with an end of life marked version of ruby. What is the perspective on solving the issue?

Hi @RickCaspar -- as you can see scrolling up further, it's already been solved. The new ceedling (0.32) works with new Ruby (3.0+). It's just working through the release process at the moment. :)

Hi Mark -- Thanks for your work! Sounds great and I look forward to the release while I continue working with 2.7.8.
Von: Mark VanderVoord @.>
Gesendet: Dienstag, 31. Oktober 2023 13:27
An: ThrowTheSwitch/Ceedling @.>
Cc: RickCaspar @.>; Mention @.>
Betreff: Re: [ThrowTheSwitch/Ceedling] Ceedling not working with Ruby 3.2.2 (Issue #782)
Hi @RickCaspar https://github.com/RickCaspar  -- as you can see scrolling up further, it's already been solved. The new ceedling (0.32) works with new Ruby (3.0+). It's just working through the release process at the moment. :)
—
Reply to this email directly, view it on GitHub https://github.com/ThrowTheSwitch/Ceedling/issues/782#issuecomment-1787121551 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BDUNHZBP2COQSMV5EYXOSRLYCDVB7AVCNFSM6AAAAAAZT4BGISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGEZDCNJVGE .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/BDUNHZCNWYB5RGPVICCLL4DYCDVB7A5CNFSM6AAAAAAZT4BGISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKQVHY6.gif Message ID: @.*** @.***> >

For those unfamiliar with Ruby gems, here is the step-by-step to fix the issue:

go to the Code tab in this repo.
On the right side of the screen, select "Releases".
0.32.0-xxxxxxx -> open Assets under the latest "Pre-release"
Download the ceedling-0.32.0-xxxxx.gem
Use: gem install --local path_to_gem/filename.gem

That fixed my issue with the "undefined method 'exists'"

I can't find the ceedling-0.32.0-xxxx.gem file. The latest I can see is the 0.31.1, what am I doing wrong?
github.com/ThrowTheSwitch/Ceedling/releases

There are only tags (wow, many of them, so probably some cleanup would be nice) and you can find it there:
https://github.com/ThrowTheSwitch/Ceedling/tags?after=1.0.0-088c460


Diacritics

Because I'm using KbdEdit which is more powerful than MSLKC, I did not realize that I introduced syntax errors in the file. This PR fixes the syntax errors.
It also adds support for subscript and superscript digits.

Thanks!


fleetctl: set --driver=etcd if --endpoint is etcd-like

There is one remaining wart of the switch from --driver=etcd to --driver=API. If someone had been using fleetctl with a custom endpoint like so:
fleetctl --endpoint http://example.com:4001 list-machines

They now all of a sudden get directed to the fleet API rather than etcd. Given that we can tell (based on the port) that the user wants to use etcd, the default of --driver in this case should remain "etcd".

LGTM


LWRP support?

I'm guessing this isn't on the table at all for the developers, but since they incredibly added single pass stereo support, I had to ask. :)

VR not working, both Single Pass and Multipass is not working. Basically it seems like it is working however it is only doing frame blending, No AA.   The jitter does not effect the camera in VR, it's easy to test.


ONAV-973: Hardware kit checklists

Content looks good. I plan to format these files with Prettier before merging this PR.


endpoint.microsoft.com or devicemanagement.microsoft.com

do microsoft change the endpoint.microsoft.com from devicemanagement.microsoft.com?
Currently both of them looks identical.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c87804d7-c76b-509d-eaa0-18b91b0563bd
Version Independent ID: 7dc288f3-939a-590b-fe8b-31a266795fa3
Content: Microsoft security portals and admin centers - Microsoft 365 security
Content Source: microsoft-365/security/mtp/portals.md
Product: microsoft-365-enterprise
GitHub Login: @lomayor
Microsoft Alias: lomayor

@limjianan Thank you for your feedback. I have checked and this is correct, both the URL's will take you the Microsoft endpoint manager admin center. The URL has not been officially changed and you will see the document updated if it happens.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @limjianan Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


HADOOP-16380. S3Guard tombstones can mislead about directory empty status - wip, trying to reproduce

Added a test which would be more robust, but I can't reproduce the failure even after running the test a couple hundred times.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
61
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1105
trunk passed

+1
compile
37
trunk passed

+1
checkstyle
26
trunk passed

+1
mvnsite
41
trunk passed

+1
shadedclient
722
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
61
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
59
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
31
the patch passed

+1
javac
31
the patch passed

-0
checkstyle
19
hadoop-tools/hadoop-aws: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)

+1
mvnsite
34
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
777
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
65
the patch passed

_ Other Tests _

+1
unit
283
hadoop-aws in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

3460

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1077

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6ad6c34d2cca 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ccaa99c

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/1/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I've checked this out & will work on it. Not failing for me either.
What I'm thinking of doing

Create a dir DIR with files AAAA BBBB
Delete AAAA (+assert tombstone)
PUT AAAA/child to store
Assert that LIST DIR returns AAAA as a prefix
do a getFile status with empty dir flag

I can replicate the problem when the dir being worked on is actually the root path /. This is consistent with all the failures happening in the root directory tests. I'd feared it was because the root dir is the one place where any file-under-a-tombstone would cause problems, but it could be that it is the sole place where our filtering breaks, because the prefix returned in the LIST == the name of a file just deleted

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1077
trunk passed

+1
compile
36
trunk passed

+1
checkstyle
23
trunk passed

+1
mvnsite
39
trunk passed

+1
shadedclient
743
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

0
spotbugs
63
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
61
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
31
the patch passed

+1
javac
31
the patch passed

+1
checkstyle
18
the patch passed

+1
mvnsite
36
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
725
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
66
the patch passed

_ Other Tests _

+1
unit
280
hadoop-aws in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3371

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1077

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1b8972b59f7a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 18ee109

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/2/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

the test testRootTombstones will pass if I change the return new S3AFileStatus(Tristate.TRUE, path, username); to return new S3AFileStatus(Tristate.FALSE, path, username); at org.apache.hadoop.fs.s3a.S3AFileSystem#s3GetFileStatus (org/apache/hadoop/fs/s3a/S3AFileSystem.java:2760). I'll update my PR with a test against this.
Although we will have the following errors after the change:
ITestS3GuardToolDynamoDB.testDynamoDBInitDestroyCycle:250->Assert.assertFalse:64->Assert.assertTrue:41->Assert.fail:88 s3guard.test.testDynamoDBInitDestroy-403465466 still exists;
ITestS3GuardDDBRootOperations.test_400_rm_root_recursive:237->Assert.assertTrue:41->Assert.fail:88 Root directory delete failed;
ITestS3AContractRootDir>AbstractContractRootDirectoryTest.testRmEmptyRootDirNonRecursive:118 ? PathIO
So at least we are checking for this. It would be better if we had a unit test for this imho. I'll create one if I can - I'll check the feasibility.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
64
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1065
trunk passed

+1
compile
38
trunk passed

+1
checkstyle
27
trunk passed

+1
mvnsite
41
trunk passed

+1
shadedclient
750
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

0
spotbugs
61
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
58
trunk passed

_ Patch Compile Tests _

+1
mvninstall
33
the patch passed

+1
compile
31
the patch passed

+1
javac
31
the patch passed

+1
checkstyle
17
the patch passed

+1
mvnsite
34
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
731
patch has no errors when building and testing our client artifacts.

+1
javadoc
25
the patch passed

+1
findbugs
62
the patch passed

_ Other Tests _

+1
unit
279
hadoop-aws in the patch passed.

+1
asflicense
30
The patch does not generate ASF License warnings.

3380

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1077

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8852c8090b0f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 5446308

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/3/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I found the out why the listing and recovering from an OOB after what @steveloughran described is not working as expected: we don't do the tombstoned entry filtering when getting a listing.
To do this I have to add HADOOP-16383 to this PR because of the metadata store has to know the TTLprovider to filter out outdated (expired) entries.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
112
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 13 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1312
trunk passed

+1
compile
40
trunk passed

+1
checkstyle
25
trunk passed

+1
mvnsite
45
trunk passed

+1
shadedclient
799
branch has no errors when building and testing our client artifacts.

+1
javadoc
26
trunk passed

0
spotbugs
72
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
70
trunk passed

_ Patch Compile Tests _

+1
mvninstall
33
the patch passed

+1
compile
30
the patch passed

+1
javac
30
the patch passed

-0
checkstyle
18
hadoop-tools/hadoop-aws: The patch generated 1 new + 66 unchanged - 2 fixed = 67 total (was 68)

+1
mvnsite
35
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
826
patch has no errors when building and testing our client artifacts.

+1
javadoc
22
the patch passed

+1
findbugs
65
the patch passed

_ Other Tests _

+1
unit
279
hadoop-aws in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3855

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1077

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 720cab6bfb1e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1411513

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/4/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/4/testReport/

Max. process+thread count
328 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
122
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1058
trunk passed

+1
compile
37
trunk passed

+1
checkstyle
28
trunk passed

+1
mvnsite
41
trunk passed

+1
shadedclient
741
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

0
spotbugs
62
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
61
trunk passed

_ Patch Compile Tests _

+1
mvninstall
33
the patch passed

+1
compile
30
the patch passed

+1
javac
30
the patch passed

-0
checkstyle
19
hadoop-tools/hadoop-aws: The patch generated 2 new + 66 unchanged - 2 fixed = 68 total (was 68)

+1
mvnsite
35
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
766
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
64
the patch passed

_ Other Tests _

+1
unit
280
hadoop-aws in the patch passed.

+1
asflicense
30
The patch does not generate ASF License warnings.

3488

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1077

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux daa3ffbc403a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c5e3ab5

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/5/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/5/testReport/

Max. process+thread count
443 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1077/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Properly escape paths during installation

Fixes #481

:tada: This PR is included in version 0.48.0 :tada:
The release is available on:

v0.48.0
GitHub release

Your semantic-release bot :package::rocket:


How do I use flags (scale and crop) with other arguments in ImagePutWindow? (More/more detailed examples please.)

The main reference for ImagePutWindow documents the arguments (title, pos, style, etc.) individually but doesn't discuss calling the function with keyword instead of positional arguments. Then in the documentation for the flags, we get examples with keyword arguments for the image and the flags, but no examples/discussion of how to include other arguments (pos, title, etc.) when calling with flags.
I couldn't figure it out — my AHK is occasional — so I took the long way round: scaled with ImagePutBuffer first, then called ImagePutWindow with positional arguments, starting with the buffer pointer.
Additional examples using all the arguments, in both positional and keyword versions, would be appreciated, for those of us beginners, with perhaps a little explanation. Thanks.

Feel free to suggest any changes to the documentation.
ImagePutWindow({image: "cats.jpg", scale: 2}, "My Title", [0, 0])

You can replace the image parameter with an object. Positional arguments are handled normally.

For examples, please suggest what you would like to see. And if they are included as a download, file, or as text in the documentation.

https://github.com/iseahound/ImagePut/wiki/Input-Types-&-Output-Functions#usage

Those examples are very helpful, thanks.
A short explanation as to when and how the different types of parameters are used and how they are combined (and maybe what not to do) would also be nice. After seeing the examples, I think the basic idea is that if you use any of the flags, then you must use a keyword argument for the image type and the flags, and place the combination of the image type and flag keyword arguments in curly brackets as the first positional argument in your call. I'm sure there's a simpler way to say that.
Appreciate very much your work.

I'm sure there's a simpler way to say that.

I'm not too sure about that. I'd have to resort to phrases like positional arguments, keywords, wrapper objects, generic types. So, I deleted that. I think Examples short and succinct can do the trick.
I'll close this ticket for now.


feat: ipfs origin

Why

Nodes should request content from origin on cache miss after bitswap queries.
Resolves #134
What

Added OriginBehaviour allowing optimized origin requests
Added service test and rpc tests

Demo

Cli

Tests

Notes

concurrent requests for a cid that does not exist in the store (for both bitswap and origin) will be grouped and all will resolve as soon as any request for a cid comes back. if someone requests for a cid while someone else already did, they would both get the response from the first request

Checklist

[x] I have performed a self-review and commented my code, particularly in complex areas
[x] I have made corresponding changes to the tests
[x] I have made corresponding changes to the documentation
[x] I have run the app using my feature and ensured that no functionality is broken

btw: requested @b0xtch @kckeiks not sure why it says removed botch ^

Noticed an issue, marking draft for now

Looking good. I see some unresolved conversations though, are we good to move forward with this PR?

To unblock this I'll do as suggested here: https://github.com/fleek-network/ursa/pull/278#discussion_r1071470631
But I'm still unconvinced that we should skip over making sure the root cid is present. I'll put together a little showcase of the potential issue separately and address it from there

To unblock this I'll do as suggested here: #278 (comment) But I'm still unconvinced that we should skip over making sure the root cid is present. I'll put together a little showcase of the potential issue separately and address it from there

You can still check the root cid, like suggested after using the load_car file. To see if it returns the same root cid. Then we can wait or pr this https://github.com/filecoin-project/ref-fvm/issues/1522


feat(arguments): Add message argument

Allows the user to fetch a message by ID and allows specifying context.channel as an optional channel from which to fetch the message. Works On My Machine:tm: using a simplified port of Skyra's quote command.
import type { PieceContext } from '@sapphire/pieces';
import { Message, MessageEmbed } from 'discord.js';
import { Command } from '../../lib/structures/Command';
import type { Args } from '../../lib/utils/Args';

export class QuoteCommand extends Command {
	public constructor(context: PieceContext) {
		super(context, {
			description: 'Displays the message at the specified message ID.',
			detailedDescription: 'Fetches the message with the given ID, optionally within the given channel, and displays it within an embed.'
		});
	}

	public async run(message: Message, args: Args) {
		const channel = await args.pick('guildChannel').catch(() => message.channel);
		const remoteMessage = await args.pick('message', { channel });
		const embed = new MessageEmbed()
			.setAuthor(remoteMessage.author.tag, remoteMessage.author.displayAvatarURL({ size: 128, format: 'png', dynamic: true }))
			.setColor(0x992d22)
			.setTimestamp(remoteMessage.createdAt);

		const content = this.getContent(remoteMessage);
		if (content) {
			embed.setDescription(`[Jump!](${remoteMessage.url})\n${content}`);
			return message.channel.send({ embed });
		}

		return message.channel.send('I was unable to quote this message.');
	}

	private getContent(message: Message): string | null {
		if (message.content) return message.content;
		for (const embed of message.embeds) {
			if (embed.description) return embed.description;
			if (embed.fields.length) return embed.fields[0].value;
		}
		return null;
	}
}

Last comment before I'll let you actually review, but should I also add support for specifying messages through the direct message link? As far as I know, you should be able to specify a message through link following a regex that looks something like this:
^(?:https:\/\/)?(?:ptb\.|canary\.)discord(?:app)?.com\/channels\/(@me|\d{17,19})\/(\d{17,19})\/(\d{17,19})$.

Last comment before I'll let you actually review, but should I also add support for specifying messages through the direct message link? As far as I know, you should be able to specify a message through link following a regex that looks something like this:
^(?:https:\/\/)?(?:ptb\.|canary\.)discord(?:app)?.com\/channels\/(@me|\d{17,19})\/(\d{17,19})\/(\d{17,19})$.

If anything, this should limit to same-guild channel, or within the DMs, probs even limiting the channels to those the author can read.

Status on this?
Also,

probs even limiting the channels to those the author can read

While it definitely should limit to same-guild channels, I'm fairly sure the risk of someone getting the message ID from a channel they don't have access to is quite slim. Nevertheless, I guess it's better to be safe than sorry.
@Alcremie do you have active plans to continue working on this so it can be implemented, or should someone else take over? I'm available if you so desire.

@Nytelife26 I've already written this and have ensured that it only allows specifying same-guild channels that are both viewable by the bot and the message author, but I still wasn't sure how to proceed with crediting kyra, since it was largely inspired by the getFromUrl function in Skyra's quote command. I'll push what I have at the moment, though; I just got caught up with work and final exams.

With the code above, here's a few different ways this argument can be used:

Specifying a channel for the MessageArgumentContext only matters when using message IDs; for obvious reasons, it's ignored when fetching messages from direct message links.

Another part of the holdup was that I'm still unsure as to whether or not we're pursuing a discord-utilities package, where this (and various other regexes used across the arguments I've implemented) would be better placed (and more easily credited); I guess that can be a question answered another day, though.

@Alcremie please add a dependency of @sapphire/discord-utilities and replace the regexes

thanks git. thanks

Okay, I'm just reopening a PR because I appeared to have fucked everything up.


It appears only the first  (closing script) tag is unescaped in html files using playground-ide

When I have a sandbox with code like the following:
https://codesandbox.io/s/naughty-kalam-i5e6h?file=/src/index.js
<playground-ide editable-file-system line-numbers resizable>
  <script type="sample/html" filename="index.html"><!doctype html>
  <html>
      <head>
          <script src="script1.js"></script>
          <script src="script2.js"></script>
      </head>
      <body>
          <script src="./script3.js"></script>
      </body>
  </html></script>
  </playground-ide>

The resulting HTML in the IDE looks like:
<!doctype html>
  <html>
      <head>
          <script src="script1.js"></script>
          <script src="script2.js"></script>
      </head>
      <body>
          <script src="./script3.js"></script>
      </body>
  </html>

Only the first script tag is "unescaped" the rest remain with </script>

Thank you for this report! I believe I have a fix implemented with https://github.com/google/playground-elements/pull/260


Active/Standby routes do not update correctly in the API

Describe the bug
When deploying an active/standby environment, the build and deploy process does not update the active/standby routes back into the API for kubernetes based deployments
To Reproduce
Steps to reproduce the behavior:

Trigger a deployment for an active/standby environment
Watch the logs and see that ACTIVE_ROUTES and STANDBY_ROUTES are correctly populated
Once the build completes, the routes do not get updated into the API

Expected behavior
The routes should be added in the API

Resolved in #2172

This has been solved (now)


Automatically show the treat cam for a donation

If a user donates for a treat, make sure the treat camera is in one of the windows and make sure the camera is on the treats.

Introduced in v1.3.0


Typo in "submit application" form

The placeholder for the Long description field says "Eneter a full description..."
Talking about labels, after submitting the application it shows with a label "on approval". I'm not sure if that's CSS shortening it, but "Pending approval" or "Waiting for approval" would likely be more appropriate.

Thank you for the notice, we have changed the wording!


[User Story] Add public keys to data model

[User Story]
Add public keys to data model

Epic Title
#333

User Story Title
Add public keys to data model

T-shirt size: S(mall), M(edium), L(arge)
M

Story Points - Fibonacci (1,2,3,5,8,13)

User Story
The proof of concept established that a user's public key is their user_id. This does not permit a key to be changed or revoked if compromised, and should not pass a security audit.

Description
We need to store key assignment separate from object_id and validate signatures using that new record.

Details

Additional User Story

Acceptance Criteria/Tests

Definition of Done

Applications or Systems impacted

Dependencies

Assumptions

Performance Considerations

Security Considerations

Questions/Clarifications

Needs an estimate...
I get that this is a security issue and needs to be done before launch.  Does it need to be done in Sprint 8?


SIGABRT: Application tried to present modally a view controller <RCTModalHostViewController: 0x10412f400> that is already being presented by <UIViewController: 0x1032142e0>.

Description
We are experiencing this error recently within our application, it came after updating to latest version of React Native. Do you have any suggestions for me on how to debug this, I can't seem to reproduce this myself.
React Native Version
0.71.7
Output of npx react-native info
System:
OS: macOS 13.3.1
CPU: (10) arm64 Apple M1 Pro
Memory: 216.97 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.12.1 - /opt/homebrew/lib/ruby/gems/2.7.0/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode: 14.3/14E222b - /usr/bin/xcodebuild
Languages:
Java: 17.0.4 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.7 => 0.71.7
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Havn't found a way yet to reproduce it all I get to from the crash is:
SIGABRT: Application tried to present modally a view controller <RCTModalHostViewController: 0x10412f400> that is already being presented by <UIViewController: 0x1032142e0>.
Snack, code example, screenshot, or link to a repository
"dependencies": {
    "@microsoft/applicationinsights-react-native": "^3.0.2",
    "@microsoft/applicationinsights-web": "^3.0.1",
    "@react-native-async-storage/async-storage": "^1.18.1",
    "@react-native-community/netinfo": "^9.3.9",
    "@react-native-cookies/cookies": "^6.2.1",
    "@react-navigation/bottom-tabs": "^6.5.7",
    "@react-navigation/native": "^6.1.6",
    "@react-navigation/native-stack": "^6.9.12",
    "appcenter": "4.4.5",
    "appcenter-analytics": "4.4.5",
    "appcenter-crashes": "4.4.5",
    "date-fns": "^2.30.0",
    "fbjs": "^3.0.4",
    "immer": "^10.0.1",
    "jwk-to-pem": "^2.0.5",
    "ky": "^0.33.3",
    "lottie-ios": "3.4.0",
    "lottie-react-native": "5.1.5",
    "moti": "0.25.3",
    "react": "18.2.0",
    "react-hook-form": "^7.43.9",
    "react-native": "0.71.7",
    "react-native-big-list": "^1.6.1",
    "react-native-biometrics": "^3.0.1",
    "react-native-blob-util": "^0.17.3",
    "react-native-bugsee": "^3.0.10",
    "react-native-collapsible": "^1.6.1",
    "react-native-device-info": "^10.6.0",
    "react-native-fast-image": "^8.6.3",
    "react-native-geolocation-service": "5.3.1",
    "react-native-gesture-handler": "^2.9.0",
    "react-native-idle-timer": "2.1.7",
    "react-native-keyboard-aware-scroll-view": "^0.9.5",
    "react-native-linear-gradient": "^2.6.2",
    "react-native-lottie-splash-screen": "^1.1.1",
    "react-native-maps": "^1.7.1",
    "react-native-modal": "^13.0.1",
    "react-native-pdf": "^6.6.2",
    "react-native-permissions": "^3.8.0",
    "react-native-reanimated": "^2.17.0",
    "react-native-render-html": "^6.3.4",
    "react-native-rsa-native": "^2.0.5",
    "react-native-safe-area-context": "^4.5.2",
    "react-native-scanbot-barcode-scanner-sdk": "3.5.1",
    "react-native-screens": "^3.20.0",
    "react-native-share": "^8.2.2",
    "react-native-svg": "^13.9.0",
    "react-native-swipe-list-view": "^3.2.9",
    "react-native-text-ticker": "^1.14.0",
    "react-native-url-polyfill": "^1.3.0",
    "react-native-uuid": "^2.0.1",
    "react-native-webview": "^12.0.2",
    "styled-components": "^5.3.10",
    "styled-tools": "^1.7.2",
    "suncalc": "^1.9.0",
    "swr": "^2.1.5",
    "use-debounce": "^9.0.4",
    "use-immer": "^0.9.0",
    "zustand": "^4.3.7"
  },
  "devDependencies": {
    "@babel/core": "^7.21.8",
    "@babel/plugin-transform-template-literals": "^7.18.9",
    "@babel/runtime": "^7.21.5",
    "@svgr/webpack": "^7.0.0",
    "@types/jwk-to-pem": "^2.0.1",
    "@types/react": "^18.2.0",
    "@types/styled-components-react-native": "^5.2.1",
    "@types/suncalc": "^1.9.0",
    "@typescript-eslint/eslint-plugin": "^5.59.2",
    "babel-loader": "^9.1.2",
    "babel-plugin-module-resolver": "^5.0.0",
    "babel-plugin-styled-components": "2.1.1",
    "babel-plugin-transform-remove-console": "^6.9.4",
    "eslint": "^8.39.0",
    "eslint-config-react-native-wcandillon": "^3.10.0",
    "eslint-plugin-prettier": "^4.2.1",
    "metro-react-native-babel-preset": "^0.76.3",
    "patch-package": "^7.0.0",
    "prettier": "2.8.8",
    "react-native-svg-transformer": "^1.0.0",
    "swagger-typescript-api": "^12.0.4",
    "typescript": "^5.0.4"
  }

The crash happened when we tried to hide the modal window and navigate with react-navigation to another page simultaneously, which is almost always reproducible in my case, could you tag me if any additional info is needed?
as a weird workaround - setTimeout

same issue and can not be sloved by setTimeout. any progress? @koloboid @Hmoulvad

I havn't been able to make any progress yet @Symous

@Hmoulvad I found this may happen when we open a Modal component inner Text component in iOS, but I can't find the reason.

@Symous can you shared some of that code, then I might be able to look through my own stuff too :-)

I'm running into the same type of issue as:

The crash happened when we tried to hide the modal window and navigate with react-navigation to another page simultaneously, which is almost always reproducible in my case, could you tag me if any additional info is needed?

The tough part for me is, on some screens hiding the modal beforehand (its visibility is toggled by state) consistently works prior to navigating, and in other cases not.
In the cases where this works, I am doing something like:
setIsProcessing(true);
props.route.params.save(selectedRef.current.map(value => value.value))
  .then(() => {
    setIsProcessing(false);
    props.navigation.goBack()
  });

where the state setting toggling the visibility of the modal open and closed is prior to an async callback.
In the cases where it doesn't work, the state had been set in a previous useEffect hook, and I am hiding and navigating in a separate useEffect. I had a hunch that perhaps React needed an extra "tick" between closing and navigating to give it time to clear the modal, and so I put the code that navigates inside a setTimeout() call with no timeout value.
I'm getting better with React every day but I'm still not entirely sure where the race condition is. But if you must hide a modal prior to navigating away it seems like putting the navigation call in an immediately-resolved setTimeout() might be an option.
In that sense I don't think this is a React bug so much as a race condition related to RN's processing of state updates and the native components created from them. I guess there could be a bug there, but anyway, this is my experience and perhaps an elaboration on the setTimeout() (with no timeout) workaround.

This is happening on RN 0.70.12 as well.

same issue

same in here

+1

same issue

hi @luccaroli , would you mind to share your approach of solving this issue using useIsFocused hook?

actually I can only solve it with settimeout @7dp :/

The problem in my case was that a modal from "react-native-modal" was being rendered on top of another rendered modal (from a different lib). Once I replaced the "react-native-modal" with the one from another UI lib it worked just fine.

The problem in my case was that a modal from "react-native-modal" was being rendered on top of another rendered modal (from a different lib). Once I replaced the "react-native-modal" with the one from another UI lib it worked just fine.

I'm getting this error when using the Modal component provided by React Native.

The crash happened when we tried to hide the modal window and navigate with react-navigation to another page simultaneously, which is almost always reproducible in my case, could you tag me if any additional info is needed?
as a weird workaround - setTimeout

setTimeout might work in a situation where you navigate explicitly, however, if the react-navigation navigates under the hood implicitly based on various actions (for example, one screen gets removed based on certain conditions and thus react-navigation navigates to another one implicitly), there's no way for me to use the setTimeout workaround. I'm facing the exact same issue with navigating while showing a modal and I still haven't found any workaround. I must hide the modal way before the navigation starts, which makes the UI less pretty.

For me the issue appeared when I tried to navigate to another screen, while the Modal I have is present. So what I did to fix this was moving the code navigating to a screen, to the OnModalHide function, so it happens after the Modal is closed. Hope it helps you guys.

For me the issue appeared when I tried to navigate to another screen, while the Modal I have is present. So what I did to fix this was moving the code navigating to a screen, to the OnModalHide function, so it happens after the Modal is closed. Hope it helps you guys.

But is that an accepted behaviour? This should be a bug right?

In my case, it was because I set isVisible to false in the finally block of the try/catch and in the try block, I navigated to another screen with react navigation

something like this can help
const first = () => {
    setShowModal(false);

    setTimeout(() => {
      then();
    }, 1000);
  };

I had the same issue when navigating to the app using a deep link and a Modal was showing for the user. To solve it I added the prop transparent={true} for the modal.

Hi guy. I had faced same issue until know on 24/08/19 RN 0.74.4, with React-Native-Element-Dropdown, React-native-google-mobile-ads
I think this is a problem with rendering life cycle between React and IOS
If you try to render a nested View Controller (On Ios) this issue occur.
In my case the error code looks like this :
Attempt to present <RCTRedBoxController: 0x13a57ede0> on <UIViewController: 0x11d609580> (from <UIViewController: 0x11d609580>) which is already presenting <RCTModalHostViewController: 0x12ebbe380>.
so the simple solution this problem is control rendering order. JS Native API like setTImeout or queueMicroTask after close modal or something like it.

// ex)

onChange={item => {
                  store.setFromCurrencyMeta(item);
                  fromDropdownRef.current?.close();

                  setTimeout(() => {
                    showInterstitialAd();
                  }, 1000);
                }}

Hi @cortinico, sorry for tagging you here.
Would you mind to take a time to look on this bug for us?

Would you mind to take a time to look on this bug for us?

We don't monitor closed issues. Please open a new issue against React Native 0.75 with a reproducer, and we can look into it


how to prepare with fieldname in database different from model

I have a query like this:
SELECT con_id,con_question FROM questions where con_id = :id

and a model that has :
ID           uint    `db:"con_id"`
Question     *string `db:"con_question"

and model.ID has value 1
But I get an error:
&errors.errorString{s:"could not find name id in Model{ID:0x1, Question:(*string)(nil)"}

but it's unclear to me what I am doing wrong :-(

I now have a query with a join to another tbale (postgres), so I have to give tablenames with all fields
SELECT mytable.con_id,mytable.con_question,mysubtable.other FROM questions
inner join on mysubtable ON mysubtable.field = mytable.subkey
where con_id = :con_id

No clue on how to fix the error that I'm getting:
missing destination name id in *myMainModel
But in myMainModel the key ID has a db-tag like this "con_id"
So why does it complain about id?

the strange thing is, when I leave the subfields out like this:|
SELECT mytable.con_id,mytable.con_question FROM questions
inner join on mysubtable ON mysubtable.field = mytable.subkey
where con_id = :con_id

it works....
(btw: If I put the query in my database client (table plus), I can type the value for the con_id and it gives me a row from my database, so there is nothing wrong with the query itself. It has something to do with the mapping of db-fields, is my guess.

After half a day of playing Sherlock Holmes and walking through the caverns of SQLX, I found what was wrong. The message is misleading I found out.
It has nothing to do with "id", but it was something else.
It had to do with the fact that my main-model didn't have the same db-tag as my sub-model.
Hope again that this will help someone.


fix: certification icon order

SUMMARY
In the dataset crud view, the table icon comes first, so we should use the same order here
TEST PLAN
CI
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

to: @ktmud

yeah, working on it now


Could you add Skyward Sword HD please?

Or if you could give a tutorial on how to add games that'd be cool :D

Hello,
I aded this game in the 0.9.0 release of the application that is out now. Thanks for checking out the application, and thanks for the feedback!


Rasa X: Getting TimeoutError, MaxRetryError, ConnectionError when calling HTTP API

Rasa version: 1.0.1
Rasa SDK version (if used & relevant): --
Rasa X version (if used & relevant): --
Python version: 3.7
Operating system (windows, osx, ...): Ubuntu
Issue:
Hi,
I am trying to call the /api/conversations/<conversation_id> api to get the tracker/conversation history for a given conversation_id but I am getting a bunch of errors when I make a request call:
---------------------------------------------------------------------------
TimeoutError                              Traceback (most recent call last)

...

TimeoutError: [Errno 110] Connection timed out

During handling of the above exception, another exception occurred:

NewConnectionError                        Traceback (most recent call last)

...

NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7f3b29df5cc0>: Failed to establish a new connection: [Errno 110] Connection timed out

During handling of the above exception, another exception occurred:

MaxRetryError                             Traceback (most recent call last)

...

MaxRetryError: HTTPConnectionPool(host='localhost.com', port=5002): Max retries exceeded with url: /api/conversations/<OMITTED> (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f3b29df5cc0>: Failed to establish a new connection: [Errno 110] Connection timed out',))

During handling of the above exception, another exception occurred:

ConnectionError                           Traceback (most recent call last)
...

ConnectionError: HTTPConnectionPool(host='localhost.com', port=5002): Max retries exceeded with url: /api/conversations/<OMITTED> (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f3b29df5cc0>: Failed to establish a new connection: [Errno 110] Connection timed out',))

Context:
This is with rasa x (rasa=1.0.1). Was working seamlessly before but since I got a few thousand conversations, it started giving these errors. What goes along with this is that the rasa x front-end does not load as well and keeps giving 502s and 504s when trying to log in, polling errors and takes prohibitively large time to scroll down on the /conversations page.
My guess is that since rasa x uses SQLite as the frontent DB, this is the one that's giving timeouts. Storage sizes: rasa.db -> 120MB, tracker.db -> 80MB.
Would love to know the reason for this.
Apologies, selected wrong category last time https://github.com/RasaHQ/rasa/issues/4937

Thanks for raising this issue, @amn41 will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

hi @psds01 ! Rasa X only uses sqlite in local mode, do you have a few thousand conversations in local mode? Might be a good idea to hook up a proper database.
we are aware of performance issues on the conversations screen, @eibhleag is on it and a patch is coming very soon.

Hi @amn41 , hope you are doing good!
I have around 5000-6000 conversations in local mode.
Might be a good idea to hook up a proper database. Any idea how can I do that?
...a patch is coming very soon. Awesome!
Also, any plans to make Rasa X open source? I love the frontend but would like to use my own database of choice (thinking about ElasticSearch with indexing and all) or customisation if any.


feat(system_error_monitor): output emergency reason for debugging

Related Issue(required)
Resolves https://github.com/autowarefoundation/autoware.universe/issues/508

Description(required)
output latent fault (as rclcpp warn) and single point fault (as rclcpp error) in system_error_monitor

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[ ] Documentation with description of the package is available
[ ] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[x] Commits are properly organized and messages are according to the guideline
[x] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Just launching autoware with simple psim, no debug message is output every 5s cycle.

After positioning the ego vehicle, debug message is output every 5s cycle as follows

After putting the goal pose, no debug message is output every cycle.

When putting the ego out of lane, single point fault of lane_departure_checker occurs, and debug message is output every 5s cycle as follows

a bit long error output every 5 sec, after positioning ego pose

put ego pose out of lane, and error output every 5 sec for lane_departure_checker

Thank you. I retested, and confirmed it works well.
My concern is after positioning ego pose and before positioning goal pose, a bit long error is output every 5 secs.
How do you feel?

@takayuki5168 In that case, you can add some states to ignore.

Ideally, we should extend system_error_monitor to understand which diagnostics can be ignored in each state respectively.
But since it takes time we can ignore them globally (apply the same settings for all diagnostics) for now.

I think planning_error_monitor does not have to output error for no messages coming, since whether there are required messages or not is seen in another monitoring.

https://github.com/autowarefoundation/autoware.universe/pull/515
I created another PR to suppress error of planning_error_monitor.
I'll merge this PR after planning_error_monitor's PR is merged.


jbom 1.1 fails to scan dirs with URL encoded characters in name

jbom appears to be over-eagerly URL-decoding directory names so that this works:
$ java -jar jbom-1.1.jar -f test/test.jar
2022-03-14 14:52:52:974 TRACE --- [jbom]
2022-03-14 14:52:52:975 TRACE --- [jbom]                       _ __
2022-03-14 14:52:52:975 TRACE --- [jbom]                      (_) /_  ____  ____ ___
2022-03-14 14:52:52:975 TRACE --- [jbom]                     / / __ \/ __ \/ __ `__ \
2022-03-14 14:52:52:975 TRACE --- [jbom]                    / / /_/ / /_/ / / / / / /
2022-03-14 14:52:52:975 TRACE --- [jbom]                 __/ /_.___/\____/_/ /_/ /_/
2022-03-14 14:52:52:976 TRACE --- [jbom]                /___/
2022-03-14 14:52:52:976 TRACE --- [jbom]
2022-03-14 14:52:52:976 TRACE --- [jbom]      by Contrast Security - https://contrastsecurity.com
2022-03-14 14:52:52:976 TRACE --- [jbom]
2022-03-14 14:52:52:976 TRACE --- [jbom]       jbom generates SBOMs for all JVMs running on a host
2022-03-14 14:52:52:976 TRACE --- [jbom]          https://github.com/Contrast-Security-OSS/jbom
2022-03-14 14:52:52:977 TRACE --- [jbom]
2022-03-14 14:52:52:977 TRACE --- [jbom] Analyzing file test/test.jar
2022-03-14 14:52:53:093 TRACE --- [jbom] Saving SBOM with 1 components to /Users/tellison/sbom/jbom-test.json
2022-03-14 14:52:53:566 TRACE --- [jbom]
2022-03-14 14:52:53:566 TRACE --- [jbom] jbom complete

but this fails (note the dir is now called test+1/ but the scan is running on test 1):
$ java -jar jbom-1.1.jar -f test+1/test.jar
2022-03-14 14:53:05:008 TRACE --- [jbom]
2022-03-14 14:53:05:008 TRACE --- [jbom]                       _ __
2022-03-14 14:53:05:008 TRACE --- [jbom]                      (_) /_  ____  ____ ___
2022-03-14 14:53:05:009 TRACE --- [jbom]                     / / __ \/ __ \/ __ `__ \
2022-03-14 14:53:05:009 TRACE --- [jbom]                    / / /_/ / /_/ / / / / / /
2022-03-14 14:53:05:009 TRACE --- [jbom]                 __/ /_.___/\____/_/ /_/ /_/
2022-03-14 14:53:05:009 TRACE --- [jbom]                /___/
2022-03-14 14:53:05:009 TRACE --- [jbom]
2022-03-14 14:53:05:009 TRACE --- [jbom]      by Contrast Security - https://contrastsecurity.com
2022-03-14 14:53:05:009 TRACE --- [jbom]
2022-03-14 14:53:05:010 TRACE --- [jbom]       jbom generates SBOMs for all JVMs running on a host
2022-03-14 14:53:05:010 TRACE --- [jbom]          https://github.com/Contrast-Security-OSS/jbom
2022-03-14 14:53:05:010 TRACE --- [jbom]
2022-03-14 14:53:05:010 TRACE --- [jbom] Analyzing file test+1/test.jar
2022-03-14 14:53:05:022 TRACE --- [jbom] The jbom project needs your help to deal with unusual CodeSources.
2022-03-14 14:53:05:022 TRACE --- [jbom] Report issue here: https://github.com/Contrast-Security-OSS/jbom/issues/new/choose
2022-03-14 14:53:05:022 TRACE --- [jbom] Please include:
2022-03-14 14:53:05:022 TRACE --- [jbom]   CodeSource: /Users/tellison/test+1/test.jar
java.io.FileNotFoundException: /Users/tellison/test 1/test.jar (No such file or directory)
	at java.base/java.io.FileInputStream.open0(Native Method)
	at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
	at com.contrastsecurity.Libraries.addAllLibraries(Libraries.java:90)
	at com.contrastsecurity.Libraries.runScan(Libraries.java:39)
	at com.contrastsecurity.Jbom.doLocalFile(Jbom.java:171)
	at com.contrastsecurity.Jbom.run(Jbom.java:95)
	at picocli.CommandLine.executeUserObject(CommandLine.java:1939)
	at picocli.CommandLine.access$1300(CommandLine.java:145)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2358)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2352)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2314)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2316)
	at picocli.CommandLine.execute(CommandLine.java:2078)
	at com.contrastsecurity.Jbom.main(Jbom.java:68)
2022-03-14 14:53:05:058 TRACE --- [jbom] Saving SBOM with 1 components to /Users/tellison/sbom/jbom-test.json
2022-03-14 14:53:05:537 TRACE --- [jbom]
2022-03-14 14:53:05:537 TRACE --- [jbom] jbom complete

and just for fun:
...
2022-03-14 15:00:26:350 TRACE --- [jbom]   CodeSource: /Users/tellison/test%23/test.jar
java.io.FileNotFoundException: /Users/tellison/test#/test.jar (No such file or directory)
...

Resolved by applying URL decoding only to real codesources, not file system references.


A molecular single-cell lung atlas of lethal COVID-19 - GSE171524

Project short name:
LethalCovidLungAtlas
Primary Wrangler:
Wei Kheng
Secondary Wrangler:

Associated files

Google Drive:
https://drive.google.com/drive/folders/1PVVRZ3OiNyBI79lFkXfl43VLaCk4FMF5

Published study links

Paper: https://www.nature.com/articles/s41586-021-03569-1#code-availability

Accessioned data: https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE171524

Key Events

[x] Convert published metadata to HCA spreadsheet
[x] Manually curate dataset to meet HCA metadata standard
[x] Collect any matrix and cell-type annotation files
[x] Upload sheet to validate metadata
[x] Check linking using ingest graph validator
[ ] Transfer raw files to ingest to validate data files
[x] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[x] Submit dataset to Production
[x] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

This looks good @Wkt8 , some comments, mostly minor, below!

Project tab: I would add the project accession: PRJNA719842

Contributors: maybe add the orchid id for the contributing authors

Publication authors: the format appears as First Name, Surname Initial. I think it should be Surname, First Name Initial

Donor organism: I think you might need to replace 'unknown' with a blank for it to validate as it expects an integer. The BMI ranges might also not validate. I have filed the ability to add a range in BMI in the metadata schema updates ticket, as I was unable to validate a range of BMI values for a dataset I worked on recently.

For ethnicity, I think the cells with 'unknown' or 'not hispanic or latino' should left blank with no ontology, as uncategorised population isn't the same as unknown or not hispanic or latino. Maybe also see what @ESapenaVentura thinks?

Row 8: 'year' should be removed as the age unit as no age in years is given.

I thin the COVID-19 infected donors should have COVID-19 included as a disease ontology in the disease list

Specimen from organism tab: I would only include the disease that affects the specimen organ (lungs). So, lung disease. And include COVID-19 ontology to the disease list.

The collection protocol column isn't complete

Dissociation protocol: maybe add a space or underscore in between dissociation and protocol in the protocol id. Same with other protocol ids.

Replace comma with full stop in Description.

Enrichment protocol: the description "FACS protocol for sorting cells." is quite brief. Is there any more detail given in the publication methods or GEO metadata file? And what makers or stains were used for enriching cells?

Cell suspension: are there experiment accessions (SRX...) that you can add for the cell suspensions?

Sequencing protocol: paired-end should be 'no' for 10X.

Thank you!
I have added the project title, ORCID ID, changed the publication authors, removed the donor organism BMI, removed the 'unknown' and 'not hispanic or latino' ontologies, removed the 'year' age unit, included the COVID-19 disease ontology, only included the diseases affecting lungs, added more detail to the collection protocol column, added underscores to the protocol ids, replaced comma with full stops, and changed paired-end to 'yes' for 10X.
For the enrichment protocol, the FACS protocol was actually used for immunofluorescence, not for the rna cell sequencing, so I have removed it.
There were unfortunately no experiment accessions - only biosample accessions.
Now syncing the analysis_files to the S3 bucket.

@Wkt8 I added the SCEA brokering label and I will remove the Dataset label. That will remove this dataset from this board and only show it in the SCEA brokering board for tracking that independently. Please, let me know if it's not ok and I will revert it back. Thanks

Performing the brokering to SCEA and capturing time!

This dataset is not suitable for SCEA because the raw sequencing data is not available. Moving this to finished.


[Docs] fix advanced_guides

config, datasets and visualization of user_guides
advanced_guides/transforms.md
advanced_guides/dataset.md
advanced_guides/losses.md
migration.md
model_zoo.md
notes: contribution, faq, projects

faq.md is intended for  Frequently Asked Questions.
Please refactor it by listing some questions and answers (You may list some popular issues here)

There are multiple dataset-related files under user_guides/dataset.
You can merge them into one if necessary.
Besides, provide the commands or the link to tools for data preparation in the documentation of the dataset.

About user_guides/config, in each documentation, you can divide the snippet of config code into multiple snippets and explain each snippet briefly. For example, dive a single config file into the parts of the model, train_dataloader, test_dataloader, etc.


What to do for spoofed user-agents?

This isn't exactly a bug or a feature-request. It's more of a problem (and hopefully the start of a discussion).
We recently switched a site to Polyfill.io and started getting lots of reports of errors like Promise.all is not a function and Promise.resolve is not a function.
The user-agents are varied, but all for fairly modern browsers (that should definitely have Promise):

Mobile Safari 12.1.2: Mozilla/5.0 (iPhone; CPU iPhone OS 12_4_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.2 Mobile/15E148 Safari/604.1
Mobile Safari 13.1: Mozilla/5.0 (iPhone; CPU iPhone OS 13_4_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Mobile/15E148 Safari/604.1
Mobile Safari 13.0.5:  Mozilla/5.0 (iPhone; CPU iPhone OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Mobile/15E148 Safari/604.1
Chrome Mobile 81.0.4044: Mozilla/5.0 (Linux; Android 9; SM-G950U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Mobile Safari/537.36

All the IPs come from within Facebook. I assume these are requests from Facebook's crawler with a spoofed user-agent.
On the one hand, you might argue that a spoofed user-agent isn't a problem for Polyfill.io. It's meant to work for "well-behaving clients." On the other hand, (like it or not) Facebook is critical to the success of many businesses.
One possible solution would be to add support for a query-param like &flags=gated-sync-request that (1) ships the detect.js logic to the client, then (2) requests the necessary polyfills using one or more synchronous XHRs.

The Facebook crawler has two documented user-agents that it uses

facebookexternalhit/1.1 (+http://www.facebook.com/externalhit_uatext.php)
facebookexternalhit/1.1

That makes me think it is not the Facebook crawler. Have you tried contacting Facebook to see if they know what is causing these requests to your website?
We've been hesitant in the past to implement a feature detection based api like the one you have suggested because of the negative performance impact a snyc xhr has(also sync xhr can be blocked via the feature policy).

That makes me think it is not the Facebook crawler.

That was my initial thought. When I look at our logs, though, these requests come from exactly the same IPs as facebookexternalhit requests. Of course, this could be legitimate users behind a NAT or using a proxy. My current guess is that this isn't the crawler per se, but rather some sort of internal "prerender" service that forwards real user requests on, possibly to show a preview.

Have you tried contacting Facebook to see if they know what is causing these requests to your website?

I've reached out to some friends who work there. I've looked all over for a way to contact them about technical issues like this but can't find a form anywhere.

We've been hesitant in the past to implement a feature detection based api like the one you have suggested because of the negative performance impact a snyc xhr has

Absolutely. This is the only idea I've come up with, but I don't love it.

My current hypothesis is that this was due to Cloudflare not respecting the Vary header and thus delivering the same polyfill bundle to different user-agents. If I find out anything more, I'll repoen.

FWIW, we resolve the Vary issue and now only see exceptions on pages with ?fbclid. I think this has something to do with a Facebook bot, but I don't care that much.


Quotation marks

Thanks for the great package!
I am facing an issue with the way quotation marks are parsed using unicode_to_latex.
See the following example:
>>> from pylatexenc.latexencode import unicode_to_latex
>>> print(unicode_to_latex('Hello "world".'))
Hello ''world''.

Whereas I would expect to get
Hello ``world''.

because in LaTeX left quotation marks are represented by backticks (per https://www.maths.tcd.ie/~dwilkins/LaTeXPrimer/QuotDash.html for example).
Is this an issue that can easily be solved?

From what I saw by quickly going through the code, the replacement of " by '' is done here: https://github.com/phfaist/pylatexenc/blob/7b44351acecf305873023c1b7c667518b0e0b64a/pylatexenc/latexencode/_uni2latexmap.py#L61
Since you replace single characters, I understand why you cannot distinguish left quotation marks from right quotation marks.
Do you think there's a way to do it with the existing code, or would it require additional development?

Actually I think I have found the answer to my own question.
What I want can be achieved by adding a custom regex rule:
import re

from pylatexenc.latexencode import RULE_REGEX, UnicodeToLatexConversionRule, UnicodeToLatexEncoder

u = UnicodeToLatexEncoder(
    conversion_rules=[
        UnicodeToLatexConversionRule(
            rule_type=RULE_REGEX, rule=[(re.compile(r"\"(.*?)\""), r"``\1''")]
        ),
        "defaults",
    ]
)
print(u.unicode_to_latex('Hello "world".'))
# This prints: Hello ``world''.

Yes, I've meant to keep the pylatexenc.latexencode package simple (to avoid slowing it down) and that's why the encoding is done character-by-character using a python dictionary lookup by default. But your issue is also exactly the type of reason why I recently revised the package and added support for more interesting rules, such as REGEX rules or callback rules. As you noticed, they are more powerful, but the regex is tested at each point in the string which can slow down the encoding. Thanks for your interest in pylatexenc!


Updated_Public_permissions

@yuval-hazaz - I'm not able to ascertain why this failed. Please help.


chore: move build-utils to devDependencies

Problem
@waku/relay has build-utils as a dependency which during installation of peer packages that rely on relay were trying to install build-utils which is a dev-only package.
% npm i --save @waku/create
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@waku%2fbuild-utils - Not found
npm ERR! 404
npm ERR! 404  '@waku/build-utils@*' is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/attila/.npm/_logs/2023-05-24T14_16_35_687Z-debug-0.log

Solution
Move build-utils to devDepdenencies
Notes

related to https://discord.com/channels/864066763682218004/865466694554484738/1110934752862666934
ideally to be a followed up with a release as certain current releases will not work as expected 🙏 cc @weboko

I am wondering if it can wait till the next release (next week, 7th of June)


Fullscreen doesnt work on vertical screens when having a vertical + horizontal screen setup

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 10
Bug description
I have a dual monitor setup where one monitor is vertical and one is horizontal, the bug comes from enabling fullscreen on the vertical monitor. What happens is Runelite is still trying to fullscreen itself by getting the window boundaries of a horizontal screen.
This issue is caused by having the setup of one vertical and one horizontal, im guessing some sort of which screen-type is runelite present on would be required for this bug to be fixed!
Note: I did test just using a vertical screen and it works as intended, hence the problem occurs when using both in one setup!
Screenshots or videos
Image of fullscreen already enabled:

Video of enabling fullscreen:
https://github.com/runelite/runelite/assets/1779288/8105a0a5-56ea-46c9-ba43-45c9bae35b97
RuneLite version
RuneLite version: 1.10.1
Launcher version: 2.1.0
Logs
client.log
launcher.log

There is a chance this is fixed in the latest launcher version, try that first.

There is a chance this is fixed in the latest launcher version, try that first.

This was indeed fixed in the latest launcher version! Thanks for the quick reply and sorry about not testing that first!


Doesn't work as expected when programmatically calling babel

I'm making a custom build process that handles calling babel-core's transform itself for each file, each time with a custom extractCss property. This plugin looks like it's setting it's options only once instead of each time babel.transform is called so effectively the options passed to that call are actually irrelevant except for the 1st call.
Separately, there should be a way to print the css modules errors instead of just reporting nothing. It makes it difficult to debug css issues. I'd be willing to work on the PR but figured there could be a discussion first

also the post function runs after each call to babel.transform so for each consecutive call, it will write all .css files processed up to that point

For anyone else with this issue, a temporary solution is to reset the plugin before each call so something like:
const pathToPlugin = path.resolve(
    process.cwd(),
    'node_modules/babel-plugin-css-modules-transform/build/index.js'
);
if (!!require.cache[pathToPlugin]) {
    delete require.cache[pathToPlugin];
}

@PeteJodo Thank you! It is caused because:

this plugin can export css file so it has to somehow keep a track of compiled files
this plugin relies on css-modules-require-hook so basically options are passed to this hook.

This plugin was not intended to be used outside of babel-cli.

also the post function runs after each call to babel.transform so for each consecutive call, it will write all .css files processed up to that point which ends up being a lot of duplicate work

Yes because when you start babel-cli in normal or watch mode you don't have any way how to detect if compilation ended so I need to write files on every post compilation. At least I haven't found a way how to do it properly. I'm open to any ideas how to do it properly.

Separately, there should be a way to print the css modules errors instead of just reporting nothing. It makes it difficult to debug css issues. I'd be willing to work on the PR but figured there could be a discussion first

This is strange because I'm just requiring css files, so if css-modules-require-hook does not throw an error I don't have any way to report it. But maybe I have a bug here and I suppress errors.

Hey thanks for answering.

Yes because when you start babel-cli in normal or watch mode you don't have any way how to detect if compilation ended so I need to write files on every post compilation. At least I haven't found a way how to do it properly. I'm open to any ideas how to do it properly.

Yeah I see the issue here. I'd need to do research myself about the differences between babel.transform and babel-cli so I can't really comment on that either.

this plugin can export css file so it has to somehow keep a track of compiled files
this plugin relies on css-modules-require-hook so basically options are passed to this hook.

It's not so much the config being passed to the require-hook that's the issue, it's the extractCss property which looks like the plugin's config and not a css-modules config. extractCss could be set in pre but ergonomically, it would be weird that only part of the passed-in config would update on each call to babel.transform. Personally I don't think/expect a user to change the css-modules portion of the config (or at least I don't think it's a good idea anyway).

This is strange because I'm just requiring css files, so if css-modules-require-hook does not throw an error I don't have any way to report it. But maybe I have a bug here and I suppress errors.

So the way I've been temporarily doing this so that I can see any errors (i.e. an incorrect scss @import path) is just editing the built build/index.js in my node_modules, adding console.log(e) in this try/catch
Thanks again!

@michalkvasnicak bumping specifically for this point...

This is strange because I'm just requiring css files, so if css-modules-require-hook does not throw an error I don't have any way to report it. But maybe I have a bug here and I suppress errors.

So the way I've been temporarily doing this so that I can see any errors (i.e. an incorrect scss @import path) is just editing the built build/index.js in my node_modules, adding console.log(e) in this try/catch. I figure something could error out here but I don't know the behavior when using just through babel-cli

Any errors caused by either generateScopedName, preprocessCss, and any other extension that is passed off to css-modules-require-hook gets caught in that try/catch.

Also about your response...

Yes because when you start babel-cli in normal or watch mode you don't have any way how to detect if compilation ended so I need to write files on every post compilation. At least I haven't found a way how to do it properly. I'm open to any ideas how to do it properly.

why doesn't

sorry, didn't mean to close.... pressed wrong button >.<

Ok so basically we need to detect if the error is from ignoring file or is normal error. I will take a look but I have free time only on weekend.

Looking at css-modules-require-hook, they have this exception checker which gets passed into their attachHook method which gets used here.
It looks like by ignoring it, they assume they can just call the existing require extension but I feel like there should be a check there to see if the require extension even exists. I think that's why there's errors thrown for ignored files...because Node doesn't know how to import it.
This is just from glancing at their code. My knowledge on require.extensions isn't extensive so I could be mistaken

I confirmed via your test suite that this is exactly what is happening. I'm going to open a PR on css-modules-require-hook and then once that's in, you can just throw all errors

actually the error may be intended... I started a discussion here

@PeteJodo maybe if we catch only the error with specific message and rethrow all other errors? But this solution is error prone by itself.

yeah I don't like that solution. Currently, the only thing you could do really is...
if (e.message === 'existingHook is not a function') { /* ... */ }

I'm going to propose having the require hook throw its own error so it's actually catch-able. That's technically a breaking change for them though (because someone else could be doing the same thing in the above code)

I just opened a new issue since I didn't get a response in the closed issue, https://github.com/css-modules/css-modules-require-hook/issues/92


[Style guide] Grammar and Formatting

Created new folder for the style guide and moved over all pages in "grammar and formatting"
@patriciasantaana

some broken links are causing the compiles check to fail


Add note about critical section to readme

As noted in #68, I think it would be useful to provide a bit of guidance here as well.
Please feel free to add improvements.
Fixes #68

bors r+

bors r=newAM

hmm, it seems bors is having some difficulties

Ok now this can be merged.


[github-auth] accept API token instead of user/pass

@bcomnes do you think https://github.com/rvagg/ghauth will do the trick? might also mean gh-release wouldn't need to rely on the github package.

Uh oh, getting errors on the head of auth now (https://github.com/ngoldman/gh-release/commit/cf511edd4379fc00b642dae654227caadc23462c):
Bret-MBR:gh-release-test bret$ gh-release
{ tag_name: 'v1.0.1',
  target_commitish: '40c8e8708a315a00b7673eabbc27a83438305c10',
  name: 'v1.0.1',
  body: '* Made another release\n\n',
  owner: 'bcomnes',
  repo: 'gh-release-test',
  draft: false,
  prerelease: false }
? does this look right? Yes
{ [Error: {"message":"Server Error","documentation_url":"https://developer.github.com/v3"}]
  message: '{"message":"Server Error","documentation_url":"https://developer.github.com/v3"}',
  code: 500 }

Looks ready to merge to master to me if your cool with that.

@bcomnes I'm still doing a little work on auth -- I'll open a PR in a little bit.

@bcomnes I ran into the 500 error from github too when forgetting to push for https://github.com/bcomnes/gh-release-test -- note to self to check if the commit being released is on github first then display a better error message.


Need a basic template.

I kindly request a modification to the basic template dashboard "No. 3 (https://sidebar-template.reflex.run/)." Currently, the sidebar is presented in button form, which may not be optimal. I would appreciate it if the sidebar could be presented in menu form instead. Furthermore, I've noticed that the detail pages are set to expand widely by default, which may not be ideal. Additionally, the content appears skewed to the left side of the monitor. Your attention to these matters would be greatly appreciated.

Dear @helpotcreator,
Please make your modifications to this repo and make a pull request. Then, the maintainers will review it and merge it if they find it any good. I recommend creating your own if you can by tweaking the existing template.


Add BetterReflection to work with classes without invoking non-existing ones

Related

Add BetterReflection 2.0 to reflect classes without invoking other classes in them

Changes Unknown when pulling fa980a52ccc8087bbf5c4804f14cee4d6fe6955e on deprecation-scan into ** on master**.


feat(h3): allow multi impl

Relates to https://github.com/seanmonstar/reqwest/issues/1558
other impls of hyperium/h3 can implement the H3ConnectionProvider trait allowing use of more than one h3 impl and also further customization of the default quinn transport.
I couldn't work out how to let the user provide a dyn trait without exposing the generic h3 types everywhere. maybe someone who knows rust a bit better can help. the trait should be moved to a user facing package too, but I'd like to get the impl sorted first.

Thanks for thinking about this! I feel this is similar to the conversation in #1786. In short, I worry about exposing too much of the internals, because then we can't change things around.

my goal with this was to allow users to provide “something that implements h3”, which I think is still in the spirit of not too much internals. I just couldn’t get the trait to work without inflecting the rest of the library with generics for the h3 concrete type, despite the dyn trait box.

from what I can tell because the h3 traits have associated types, they are not object safe and cannot be referenced without knowing specifying those impl types.
https://stackoverflow.com/questions/67213532/vector-of-polymorphic-structs-with-an-associated-type-in-trait


feat: add session start limit data

Summary
Pretty self-explanatory; adds session start limit data to the client object, which was previously just dropped.
The contained max_concurrency value isn't being used, but given how the shard launching process currently works it's not really necessary.
resolves #390
Checklist

[x] If code changes were made, then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running task lint
[x] I have type-checked the code by running task pyright

[ ] This PR fixes an issue
[x] This PR adds something new (e.g. new method or parameters)
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)

HTTPClient.get_bot_gateway return type changed

[ ] This PR is not a code change (e.g. documentation, README, ...)

I think session start limit could be a named tuple

Named tuple doesn't make much sense, after thinking about it. Good choices


Parse yaml directories as key=value pairs

Hellow I work on https://github.com/snakemake/snakemake/issues/1186
I would like that the YAMLConfigFileParser would parse yaml directories to key-value pairs.
config.yaml
default_resources:
  mem_mb: 10
  time:300

would be parsed to:
--default_resources mem_mb=10 time=300
Do you think this is a reasonable feature request?

I think complicated values like this with compound / non-primitive types are too complex for the main configargparse repo. You're welcome to create a subclass or fork of configargparse for these more specialized use cases.

Could you show me where in the code I would need to check if the input is a dict.