Failing to reproduce similar results like the demo

Hi! I am trying to evaluate the pre-trained model for spoken EEG using the test samples, however, the outcome is not nearly as good as the demo (very far away). Could you please ensure that the original config files (used for the pre-trained model) was shared in this repo? Any pointer on why reproducing similar results is not being possible would be highly appreciated!
Thank you so much!

Thank you for having an interest in our study!
We could not find the problem yet, but could you please confirm that you are using 'inference.py' for evaluating the model?

@youngeun1209 Thank you for your reply.
Yes, I used the 'eval.py' for evaluating the model. Just to point out, there is no "--trained_model" argument in eval.py, so I used the "model_config" argument instead to avoid the error.

You can place the trained model in 'loc_g' according to the arguments of logDir, sub, and task.


VNSWRR should limit the number of virtual peers when init

Why you need it?
VNSWRR generates peeking sequence according NGINX SWRR. After fully expanded, the number of virtual nodes are the sum of weights (named total_weight).
But before initialization completes, some request will fill n elements where n is the number of peers. And each time element filled, it will use SWRR (which is O(n)) to peek the element with best effective weight, it means the cost of some request before initialization completes is O(n^2). It's not acceptable when we have a very large cluster!
How it could be?
Limit the number of virtual peers each time init to a fixed value, so we could spread the cost over different requests.
The time complexity will be O(c*n), where c is a fixed value.
Other related information
I implemented similar functionality in Spring Cloud, cost is spread over every request before initialization completes. The time required for fully expanding increased, but the latency per request is greatly reduced.
https://github.com/jizhuozhi/spring-cloud-commons/blob/main/spring-cloud-loadbalancer/src/main/java/org/springframework/cloud/loadbalancer/core/LazyWeightedServiceInstanceList.java#L68-L78

Add an optional argument max_init to limit the number of virtual peers when init
    upstream h {
        vnswrr max_init=10;
        server <IP_ADDRESS>:8081 weight=100;
        server <IP_ADDRESS>:8082 weight=101;
        server <IP_ADDRESS>:8083 weight=102;
    }


[native-filter]charts not showing in native filter modal scoping tree structure

Expected behavior:
In this video,  you can see that Tree map..., Map... , 2 heat maps and Sunburst... are not showing in the tree structure, while some charts have duplicate.
It's not a consistent issue, other dashboards seems ok...@villebro @simcha90 please investigate 🙏
https://user-images.githubusercontent.com/67837651/119771993-5dd9bf80-be73-11eb-9483-4286ff9ecacb.mov
@villebro @simcha90 please coordinate a fix. 🙏

This is caused by the charts having been renamed on the dashboard. For instance, the chart "Sunburst of Country & Clinical Stages" is actually the "Vaccine Candidates per Country & Stage" chart. The appropriate fix is to display the overridden chart name in the scoping panel where available.


Tagging Hypershift clusters for tracking

When we run this wrapper from our forked repo: this will look like this:

2023-06-07 14:56:38.359 DEBUG rosa-hosted-wrapper - _build_cluster: Attempting cluster installation
2023-06-07 14:56:38.359 DEBUG rosa-hosted-wrapper - _build_cluster: Output directory set to /tmp/bea96cda-815c-4d0d-804e-dc5d44aa2b9b/chktag-njc-0001
2023-06-07 14:56:38.361 DEBUG rosa-hosted-wrapper - _build_cluster: ['/root/rosa/rosa', 'create', 'cluster', '--cluster-name', 'chktag-njc-0001', '--tags=User:krishvoor', '--replicas', '3', '--hosted-cp', '--sts', '--mode', 'auto', '-y', '--output', 'json', '--oidc-config-id', 'abcd', '--subnet-ids', 'subnet-XXX,subnet-YYY,subnet-ZZZ,subnet-xxx,subnet-yyy,subnet-zzz', '--properties', 'provision_shard_id:8c3bcd1f-xxxx', '--version', '4.12.15', '--operator-roles-prefix', 'chktag-njc']

You can do the same just passing the tag you want on the extra params.
This change requires that the command will be launched from a git based folder, which is not mandatory at this moment

You can do the same just passing the tag you want on the extra params.

We need this tag <User:GITHUB_USERNAME> for better consolidation of cloud-expenses as defined here, this takes away the fact that user will have to pass tags for every-run
However, will implement supplying extra-tags via argsparse in case.

Im not saying I want to tag, but if we are going to do it, we need to also add this tags on:

vpcs created by terraform
oidc-config objects
operator-roles
machinepool

Im not saying I want to tag, but if we are going to do it, we need to also add this tags on:

vpcs created by terraform
oidc-config objects
operator-roles
machinepool

Thanks, @morenod this would mean it will be easy to find all "resources" in the AWS belonging to the same cluster.

@morenod @dry923: Based on the discussions, I have implemented
--extra-tags parameter will also tag operator-roles, machinepool, oidc-config objects & vpcs.
as --wildcard_options will only be limited to tag resources created during the _build_cluster() function.

@krishvoor Can you please attach the steps in detail on how these changes were tested? I am somehow unable to reproduce the steps mentioned in README.md


"Continuous Integration" section in the CONTRIBUTING.md is out of date

Description
The @swift-ci please smoke test directive does not appear to work.  We should bring the "Continuous Integration" section in the CONTRIBUTING.md up to date.
Additionally, we should look at a process that would "trigger" the need to update the documentation should the "directives" change.

https://github.com/swiftlang/swift-package-manager/pull/8187


ak.count with axis=0 is producing invalid arrays

I am trying to count the number of elements in a nested data structure using awkward1.count following the docs, I tried to apply different axis values to count elements at different levels of nesting.
axis (None or int) – If None, combine all values from the array into a single scalar result; if an int, group by that axis: 0 is the outermost, 1 is the first level of nested lists, etc., and negative axis counts from the innermost: -1 is the innermost, -2 is the next level up, etc.

Here is how I proceed:
import uproot
import numpy as np
import awkward1 as ak1

fit = ak1.Array(uproot.open(my_file)["E/Evt/trks/trks.fitinf"].array())
print(fit)
>>> [[[0.00496, 0.00342, -295, 142, 99.1, 1.8e+308, 4.24e-12, 10, ... [], [], [], []]]
type(fit)
>>> awkward1.highlevel.Array

Counting the outermost level of nesting: axis=0

I tried the following to get the outermost level of nesting:
ak1.count(fit, axis=0)

this raises the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/IPython/core/formatters.py in __call__(self, obj)
    700                 type_pprinters=self.type_printers,
    701                 deferred_pprinters=self.deferred_printers)
--> 702             printer.pretty(obj)
    703             printer.flush()
    704             return stream.getvalue()

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/IPython/lib/pretty.py in pretty(self, obj)
    392                         if cls is not object \
    393                                 and callable(cls.__dict__.get('__repr__')):
--> 394                             return _repr_pprint(obj, self, cycle)
    395
    396             return _default_pprint(obj, self, cycle)

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/IPython/lib/pretty.py in _repr_pprint(obj, p, cycle)
    682     """A pprint that just redirects to the normal repr function."""
    683     # Find newlines and replace them with p.break_()
--> 684     output = repr(obj)
    685     lines = output.splitlines()
    686     with p.group():

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/highlevel.py in __repr__(self, limit_value, limit_total)
   1134         value = awkward1._util.minimally_touching_string(limit_value,
   1135                                                          self._layout,
-> 1136                                                          self._behavior)
   1137
   1138         name = getattr(self, "__name__", type(self).__name__)

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/_util.py in minimally_touching_string(limit_length, layout, behavior)
    997             leftlen += len(l)
    998
--> 999         r = next(rightgen)
   1000         if r is not None:
   1001             if (leftlen + rightlen + len(r)

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/_util.py in forever(iterable)
    976
    977     def forever(iterable):
--> 978         for token in iterable:
    979             yield token
    980         while True:

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/_util.py in backward(x, space, brackets, wrap)
    938                 sp = ""
    939                 for i in range(len(x) - 1, -1, -1):
--> 940                     for token in backward(x[i], sp):
    941                         yield token
    942                     sp = ", "

ValueError: in ListArray64 attempting to get 27, starts[i] != stops[i] and stops[i] > len(content)

It seems like there is an error with the repr of the returned object, I tried the following:
t = ak1.count(fit, axis=0)
print(t.shape)
>>> (56,)

So this did not raise an error, but the shape of t can't be 56.
The expected result of the outermost nesting level count is 10:
ak1.num(fit, axis=0)
>>> 10

same with
len(fit)
>>>10

Counting the first level of nesting: axis=1

counts = ak1.count(fit, axis=1)
counts
>>> <Array [[20, 20, 20, 20, 20, ... 1, 1, 1, 1]] type='10 * var * int64'>
np.array(counts)
>>> array([[20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [19, 19, 19, 19, 19, 19, 19, 19,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [18, 18, 18, 18, 18, 18, 18, 18,  2,  2,  2,  1,  1,  1,  1,  1,
         1],
       [20, 20, 20, 20, 20, 20, 20, 20,  2,  2,  2,  1,  1,  1,  1,  1,
         1]])

So I understand from this result that fit has 10 elements (the outermost nesting level), in element 0, there are 17 elements (let's call this the first nesting level):
counts[0]
>>> <Array [20, 20, 20, 20, 20, ... 1, 1, 1, 1, 1] type='17 * int64'>

But I am not sure if this result actually makes sense? I am not able to interpret these values.
When I check to verify if this counting is correct, I do the following:
np.array(ak1.num(fit, axis=1))
>>> array([56, 55, 56, 56, 56, 56, 56, 56, 54, 56])

both results don't match? am I misundersting something here?
same with
[len(i) for i in fit]
>>> [56, 55, 56, 56, 56, 56, 56, 56, 54, 56]

Counting the second level of nesting: axis=2

This one seems to work fine:
counts = ak1.count(fit, axis=2)
>>> <Array [[17, 11, 8, 8, 8, ... 0, 0, 0, 0, 0]] type='10 * var * int64'>
counts[0]
>>> <Array [17, 11, 8, 8, 8, 8, ... 0, 0, 0, 0, 0] type='56 * int64'>

checking the results with awkward1.num
counts_with_num = ak1.Array([ak1.num(i, axis=1) for i in fit])
counts_with_num
>>> <Array [[17, 11, 8, 8, 8, ... 0, 0, 0, 0, 0]] type='10 * var * int64'>
counts_with_num[0]
>>> <Array [17, 11, 8, 8, 8, 8, ... 0, 0, 0, 0, 0] type='56 * int64'>

and with a simple loop
[len(i) for i in fit[0]]
>>> [17, 11, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]

I also tried to apply awkward1.count  on one element of my fit data using axis=1 and it worked just fine:
ak1.count(fit[0], axis=1)
>>> <Array [17, 11, 8, 8, 8, 8, ... 0, 0, 0, 0, 0] type='56 * int64'>

I also noticed that the same behaviour is true for awkward1.count_nonzero, when axis=1 is specified:
np.array(ak1.count_nonzero(fit, axis=1))
>>> array([[20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [19, 19, 19, 19,  1,  1, 19, 19,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [17, 17, 18, 18,  1,  1, 18, 18,  2,  2,  2,  0,  0,  1,  1,  1,
         1],
       [20, 20, 20, 20,  1,  1, 20, 20,  2,  2,  2,  0,  0,  1,  1,  1,
         1]])

when axis=2 it works just fine:
counts_nonzero = ak1.count_nonzero(fit, axis=2)
counts_nonzero[0]
>>> <Array [15, 9, 6, 6, 6, 6, ... 0, 0, 0, 0, 0] type='56 * int64'>

when axis=0 an error is raised:
ak1.count_nonzero(fit, axis=0)
>>> ---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/IPython/core/formatters.py in __call__(self, obj)
    700                 type_pprinters=self.type_printers,
    701                 deferred_pprinters=self.deferred_printers)
--> 702             printer.pretty(obj)
    703             printer.flush()
    704             return stream.getvalue()

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/IPython/lib/pretty.py in pretty(self, obj)
    392                         if cls is not object \
    393                                 and callable(cls.__dict__.get('__repr__')):
--> 394                             return _repr_pprint(obj, self, cycle)
    395
    396             return _default_pprint(obj, self, cycle)

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/IPython/lib/pretty.py in _repr_pprint(obj, p, cycle)
    682     """A pprint that just redirects to the normal repr function."""
    683     # Find newlines and replace them with p.break_()
--> 684     output = repr(obj)
    685     lines = output.splitlines()
    686     with p.group():

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/highlevel.py in __repr__(self, limit_value, limit_total)
   1134         value = awkward1._util.minimally_touching_string(limit_value,
   1135                                                          self._layout,
-> 1136                                                          self._behavior)
   1137
   1138         name = getattr(self, "__name__", type(self).__name__)

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/_util.py in minimally_touching_string(limit_length, layout, behavior)
    997             leftlen += len(l)
    998
--> 999         r = next(rightgen)
   1000         if r is not None:
   1001             if (leftlen + rightlen + len(r)

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/_util.py in forever(iterable)
    976
    977     def forever(iterable):
--> 978         for token in iterable:
    979             yield token
    980         while True:

~/miniconda3/envs/km3pipe/lib/python3.7/site-packages/awkward1/_util.py in backward(x, space, brackets, wrap)
    938                 sp = ""
    939                 for i in range(len(x) - 1, -1, -1):
--> 940                     for token in backward(x[i], sp):
    941                         yield token
    942                     sp = ", "

ValueError: in ListArray64 attempting to get 27, starts[i] > stops[i]

The file I am reading data from is attached to this git issue.
aanet_v2.0.0.root.zip
Thank you for your help.
I ping @tamasgal

What you're showing is consistent with the original fit array being malformed—having starts and stops that point beyond its contents. The repr will fail if this is the case. You might want to try

ak.is_valid: returns False if malformed.
ak.validity_error: returns a string describing the error if malformed.

Both of these accept exception=True to halt execution if you have a malformed array. Perhaps validity checking should be part of repr, but it's a potentially expensive operation because it has to scan all fields of an array, which might be a big "events" dataset with lots of fields.
The second question is how did it get into this state? I hadn't thought of passing an Awkward0 array (from Uproot) directly into the ak.Array constructor; there's a

ak.from_awkward0: converts from Awkward0 to Awkward1

function for that, but it shouldn't be allowed to do crazy things like this. I'd like to see this file.
Finally, you might not be interested in

ak.count: a reducer that follows NumPy reduction rules for each axis

rather than

ak.num: returns the number of values at some level of depth.

For example,
>>> array = ak1.Array([[[0, 0, 0, 0, 0],
...                     [0, 0, 0],
...                     [0, 0, 0, 0]],
...                    [[0, 0],
...                     [0, 0, 0, 0, 0]]])
>>> ak1.count(array, axis=None)
19
>>> print(ak1.count(array, axis=0))
[[2, 2, 1, 1, 1],
 [2, 2, 2, 1, 1],
 [1, 1, 1, 1]]
>>> print(ak1.count(array, axis=1))
[[3, 3, 3, 2, 1],
 [2, 2, 1, 1, 1]]
>>> print(ak1.count(array, axis=2))
[[5, 3, 4],
 [2, 5]]

All axis != -1 (i.e. axis != 2 for this doubly jagged array) count laterally across objects. If you have a jagged array of particles in events, axis = 0 asks questions like, "How many first particles are there, added up across all events?" and "How many second particles are there?"
The ak.num function gives you something you can use in cuts, like
>>> print(ak1.num(array, axis=0))
2
>>> print(ak1.num(array, axis=1))
[3, 2]
>>> print(ak1.num(array, axis=2))
[[5, 3, 4], [2, 5]]

Regarding the new title, it's this line
fit = ak1.Array(uproot.open(my_file)["E/Evt/trks/trks.fitinf"].array())

that I'm worried might be producing invalid arrays, and it's probably taking the ak.from_iter path.

I just noticed that you do, in fact, provide data. Triaging now.

I was wrong. ak.from_iter is producing valid arrays; ak.count with axis=0 is producing invalid ones.
>>> ak.validity_error(ak.count(fit, axis=2))
>>> ak.validity_error(ak.count(fit, axis=1))
>>> ak.validity_error(ak.count(fit, axis=0))
'at layout (ListArray64): start[i] > stop[i] at i=20'

and we see crazy values in the ListArray's starts and stops by looking at the low-level layout:
>>> ak.count(fit, axis=0).layout
<ListArray64>
    <starts>
        <Index64 i="[0 17 34 51 68 ... 510 520 530 540 549]" offset="0" length="56"/>
    </starts>
    <stops>
        <Index64 i="[17 28 42 59 76 ... 1 1 1 1 1]" offset="0" length="56"/>
    </stops>
    <content>
        <NumpyArray format="l" shape="331" data="10 10 10 10 10 ... 8 8 8 8 8"/>
    </content>
</ListArray64>

(Sometimes those 500-ish numbers are like<PHONE_NUMBER>4849.) Looking into it.

Sorry my issue was probably too cluttered with lots of unecessary information.
But the main problem is that both ak.count and ak.count_nonzero seem to provide invalid outputs when used with axis=0 and axis=1 when the data had 2 levels of nesting.

In fact, all reducers do; it shows up when axis is less than the nesting depth and there are trailing empty lists in the output. The starts and stops of the trailing lists were left uninitialized, rather than being set to equal values (indicating an empty list).
I just fixed it. Actually, the new system is quite nice to debug! Since there are for loops at the deepest level, I can insert print statements. :)

Oh great! Thank you very much for the prompt reply! I will test the fix :)
Looking forward to the official release of version 1 of awkward1 :)

It will be in the next release, which will probably wait for #216. I'm deploying releases a little less often than I used to because these include a lot of binaries and PyPI is instituting a quota.
What you want for your analysis/framework is probably not ak.count with axis=0. I don't know exactly what you want to do, but it probably involves ak.num.

Okay, good. You might want to write axis=-1, which will always be the last one, no matter how deep.
Negative axis has been implemented for reducers and will be for everything else, but some of them rely on a soon-to-be-written function.
Thanks for reporting the issue!


\i command, bufio.Scanner: token too long

When attempting to import a large sql file (mine was over 2 GB), I would eventually get the following error:
bufio.Scanner: token too long

We might try to use bufio.Reader.ReadLine() instead of a Scanner in https://github.com/xo/usql/blob/b376ee5b963de0c820bf2c05bf67035a6ea24fa2/handler/handler.go#L1139 but huge lines might cause issues in other places.
Until we address this, I'd recommend using tools dedicated to a particular DB for loading a large amount of data, as usql might not have the best performance for this.

I'd like to echo @nineinchnick  -- perhaps one day usql will be ready to deal with bulk-loading data into any database, unfortunately it isn't ready for that yet. I'm quite familiar with this specific hack I wrote. I'l try to push out a fix, but as above, for bulk-loading data, I'd suggest relying on the database's native client.

@pricheal + @nineinchnick I just pushed a commit changing to bufio.Reader.ReadLine. I don't have a multi-gigabyte file to test with, but I'll try to generate one later. My guess is if the original SQL script involved was trying to import a multi-gigabyte entry into a single row, this is going to cause the same problem. Either way, the new implementation is likely better. All of my superficial tests/checks are passing using this changed implementation, but requires more scrutiny.

@pricheal were you able to test this change?

@pricheal were you able to test this change?

If I remember correctly I tested it and experienced the same issue


xScheduleTask: Cannot disable already present tasks

It's not possible to disable already present tasks because it needs to set required parameters that should not be changed (and might be unknown per target node).
        xScheduledTask 'DisableMyTask'
        {
           TaskName = 'MyTask'
           TaskPath = '\Company'
           Enable = $false
        }

Hi @johlju - ah - I see. You're talking about the ActionExecutable and ScheduleType parameters being required parameters. I'll see what I can do - how urgent is this one?

Not urgent at all for me. Worked around it by using Script-resource instead. But rather use this when it is resolved.

Hi @johlju - I'll try to get onto this one once PR #98 has been merged.

Sounds great. I hope it will be a small change :) I can review when you are done :)

Issue is the same for deleting existing tasks. The following DSC action fails requiring ActionExecutable and ScheduleType parameters.
Fix needed to automate optimization of Citrix XenDesktop and Microsoft RDS Virtual Desktop Infrastructure master images as described in https://virtualfeller.com/2017/05/04/optimize-vdi-windows-10-scheduled-tasks-original-anniversary-and-creator-updates/
xScheduledTask 'DeleteMyTask'
{
TaskName = 'MyTask'
TaskPath = '\Company'
Ensure= 'Absent'
}
Tasks like Microsoft\Windows\Application Experience\ProgramDataUpdater don't have a valid ScheduleType for the xScheduledTask DSC resource. Executing the same DSC action while setting the ActionExecutable and ScheduleType values also fails with a Trigger type $_ not recognized as the ScheduleType is not one of the ScheduleTypes defined in the switch/case of the GET function.
switch ($trigger.CimClass.CimClassName)
        {
            'MSFT_TaskTimeTrigger'
            {
                $returnScheduleType = 'Once'
                break
            }

            'MSFT_TaskDailyTrigger'
            {
                $returnScheduleType = 'Daily'
                break
            }

            'MSFT_TaskWeeklyTrigger'
            {
                $returnScheduleType = 'Weekly'
                break
            }

            'MSFT_TaskBootTrigger'
            {
                $returnScheduleType = 'AtStartup'
                break
            }

            'MSFT_TaskLogonTrigger'
            {
                $returnScheduleType = 'AtLogon'
                break
            }

            default
            {
                New-InvalidArgumentException -Message "Trigger type $_ not recognized." -ArgumentName CimClassName
            }
}

@PlagueHO Hey Daniel, I'm running into issues trying to use DSC and xScheduleTask to delete the "Xbox" scheduled tasks that Server 2016 creates... (I know, right?)... I was wondering if you have any cycles to take a look at the necessary changes to support deleting these tasks?
From what I'm able to glean, the ActionExecutable and ScheduleType parameters being required parameters is what is causing this issue... perhaps we can make them not required when deleting?
If there is any further detail or assistance I can provide, please let me know!

Hi @ttdgcp - Now that I've finished updating this module to HQRM I'll begin working on the features like this one. I actually started this a little while back so I'll try and work on this one this weekend (as well as some stuff on WsManDsc).


add auth and storage to demo app

it's weird all these other PRs are included, I wonder if I should pull change from master to my dev branch.

Close this as the branch is off sync, use this one instead: https://github.com/firebase/firebase-ios-sdk/pull/7711


Make sure the appropriate error message is returned when creating a token while authentication is disabled (#4199)

Pull request opened by the merge tool on behalf of #4199

Merged into branches iso5 in 7f28c5889681ea3fa55b8cbb289dfbbac15e927a


rkt, config: Add loading configuration from user directory

Fixes #1568.
This is rather a complete fix code-wise, though untested. Still need to update the documentation where necessary and probably add some functional tests.

[ ] tests
[ ] documentation
[ ] changelog

Do we have a test that fetch images from several different users? E.g. 1 image fetched by 1 user, and deleted by another user, etc.

The local configuration directory path is passed down to stage1. Should user config be passed there as well? This would allow us to override networking configuration. Not sure about the overriding semantics, that would be up to the stage1 implementation to decide I guess.

Non-root users can run rkt fetch but not rkt run so they cannot do anything with stage1. So I don't think stage1 needs to have access to user config.

So I don't think stage1 needs to have access to user config.

hmm? what about for the aforementioned network example?

Non-root users can run rkt fetch but not rkt run so they cannot do anything with stage1. So I don't think stage1 needs to have access to user config.

I think that the problem here is that you think of --user-config's value as a config provided by non-root user, which is not a point. It is just a name (I'd like to hear suggestions for better names, though, that would convey that it is going to override local config, like local config is overriding system config). You could use --user-config flag as a root like sudo rkt --user-config=${HOME}/test-cfg run coreos.com/etcd:v2.0.10.

Right. We need this for #1992

ping @robszumski about possible better name for the --user-config flag.

--user-config sounds ok because it matches the existing flags. Ideally it would indicate that it was a directory, so something like --user-config-dir, but its fine as is.

Do we have a test that fetch images from several different users? E.g. 1 image fetched by 1 user, and deleted by another user, etc.

How about this test - https://github.com/coreos/rkt/blob/master/tests/rkt_non_root_test.go#L91 Is root there somehow special or can be treated as any other users in this case?

@krnowak ok. So the test already exists :)

Updated, for now I decided not to forward the user config path to stage1. This needs a bit more work.

LGTM after the nits

About config for stage1 - #2013.


convention for running locally (spring-boot:run) versus on kubernetes/openshift (mvn install fabric8:deploy)

I wonder if we should have a goal mvn fabric8:run that's the cluster equivalant of mvn spring-boot:run for locally running things which also ensured that the install goal was run?
I've been setting the <defaultGoal/> for funktion stuff to be spring-boot:run for local stuff; wonder if we should add a profile to act as a simple alias for mvn install fabric8:deploy as its quite a mouthful to type.
Not sure of a concise catchy name yet though ;). Any good suggestions?
How about:
mvn -Pf8

Aggree that there should be an single goal for doing the whole workflow. However I'm still not sure whether to sacrifice the fabric8:run slot for this :). I'm still thinking whether it would make sense to bring in docker:run in some form into this plugin for easy local, docker based development and testing but withouth Kubernetes:

All images with a <build> (either explicitely configured or determined by a customizer) are started as container sharing a single container's networks space (that's how pod works, with a network mode 'container')
All images without a build section (but a <run> section as known from d-m-p) are started along in a custom network, which also the app-pod joins
Integration tests can run against this, you can develop against this and use nicely docker:watch (or the fabric8 equivalent).

This is just an idea, don't know whether it make sense and whether it in scope of this plugin. It would make only sense, if for the development its 'close enough' to the target platform and if the developing against the target platform (k8s/os) is to painful to that this mode would add some value.
Back to the original question, some name suggestions for a combined goals:

fabric8:fabric8
fabric8:all
fabric8:go
fabric8:bring-it-on :) ....

The profile would be also an alternative but is not combinable with other goals, so I'd prefer a dedicated goal.
docker:source will include the other phases, too, by forking the lifefcyle, there will be soon a docker:source-nofork for attaching this to an execution (where forking doesnt make sense). Could this be an option for fabric8:deploy, too ?
E.g.
@Mojo(name = "deploy", defaultPhase = LifecyclePhase.INSTALL)
@Execute(phase = LifecyclePhase.INSTALL)
public class DeployMojo extends AbstractFabric8Mojo {
// ...
}

We've experimented with no-kubernetes local machine stuff before; e.g. auto-generating environment variables to simulate being inside kubernetes (e.g. the old mvn fabric8:create-env command).
The thing is things soon break down on any vaguely real world app due to secrets, ConfigMap, Service Accounts, volumes, service discovery, load balancing, scaling or use of the kubernetes API. Given that anyone on a mac or windows machine needs to run a VM to run docker anyways; it seems simpler to just focus on really running things in kubernetes all the time; rather than trying to plug all the leaky abstractions? If folks wanna focus on pure docker, there's the docker-maven-plugin for that. I'd rather the fabric8 plugin focus 100% on running on kubernetes/openshift (even if thats just 1 local VM).
Even if 'pure docker' was an option; its easy to really run kubernetes on docker anyways  too ;) - plus I suspect its going to be rarer to use pure docker than kubernetes; so I'd sooner have fabric8:run be 'run my app on kubernetes' and have fabric8:docker-run to remove all the kubernetes stuff but just run some docker images as best you can - ignoring most of the kubernetes manifest metadata that doesn't apply to docker?
I do like, whatever we call the goal, (deploy/run/whatever) - having it bind to install so it can be a single goal. I'm kinda liking fabric8:run TBH; as folks tend to think of deploy as installing jars in a remote mvn repo; which we don't tend to do when running things on k8s - we just make a local docker image and run it (via rolling upgrade / create / apply of resources).

Convinced :)
I agree, that we shouldn't go the leaky abstraction route, its just too painful and maintenance intensive and probably doesnt add much value anyway.
I'm also ok with fabric8:run (docker:run was introduced only recently as an alias for docker:start mostly because I constantly typed it wrong :). So lets introduce a fabric8:run. The question is how to do this best:

An alternative to fabric8:deploy but forking the lifecycle. But then you have to ensure that fabric8:resource and fabric8:build is bound to the executions (in some parent pom), otherwise they wouldn't be called.
Dispatching internally to the Mojos (or the functionality behind it). E.g. RunMojo would call into ResourceMojo, BuildMojo and DeployMojo (if this is technically possible, but should be because I had sth similar for a postWatchGoal in d-m-p. However, any Maven phases in between (like compile) would be skipped here. Maybe not what we want.

So the most simple way is probably to fork the lifecycle. As said, we need to ensure that then
       <executions>
          <execution>
            <goals>
              <goal>resource</goal>
              <goal>build</goal>
            </goals>
          </execution>
        </executions>

need to be present. Or we define an own packaging fabric8 which includes this in its lifecycle description.
Are there any other options ?
btw, mixing d-m-p and f-m-p in one pom.xml is probably not so a good idea, because there is no easy way to share the configuration (and hence would need to be duplicated).

I guess we could add fabric8:docker-run for the pure docker case if we needed it. Not sure its worth it TBH though.
I do like the fabric8 packaging option for spring boot apps on kubernetes & would like to try it out. Until then I've been putting those executions into projects already; so we should be in good shape if we fork the lifecycle to ensure the run/deploy Mojo ensures the install phase is done first?

@jstrachan yep, guess its worth a try. its only subclassing DeployMojo and add the proper annotation.
Would you like to do it, or should I give it a try ? (its really a quick one).

I'm a bit knee deep in jboss forge stuff right now but can have a try later if you like; feel free to dive in if you want ;). The funktion quickstarts or the spring boot quickstarts are handy apps we can use to try things out now BTW

https://github.com/fabric8-quickstarts/spring-boot-camel
https://github.com/fabric8-quickstarts/funktion-java-example

cool, so I will pick up this one.

I think this is all sorted now


Qingwei/debug

Coverage decreased (-0.1%) to 36.883% when pulling fc6dfd93d3710d24865f8e378c09085d1581ab16 on qingweibinary:qingwei/debug into af2d20b082b4b1db68ecc6a377f1ee007a5d9d2b on binary-com:master.

Coverage decreased (-0.1%) to 36.883% when pulling fc6dfd93d3710d24865f8e378c09085d1581ab16 on qingweibinary:qingwei/debug into af2d20b082b4b1db68ecc6a377f1ee007a5d9d2b on binary-com:master.


Fixes #30507

Fixes https://github.com/microsoft/TypeScript/issues/30507
I saw, that when the object expression has incorrect properties, that don't exist on the type, the autocompletion works fine.
The decision, if the constraint type should be taken as the default or not is being made in checker.ts:15733 and as this is about 10 function calls deep when coming from https://github.com/microsoft/TypeScript/blob/master/src/services/completions.ts#L1457 I had to introduce a parameter in all these functions that can be passed down.
I saw, that there was already a ContextFlags type, which can be passed in to getContextualType, so I extended it and to make it accessible from the completions.ts, I had to add it to the TSChecker types in https://github.com/microsoft/TypeScript/compare/master...timsuchanek:genericObjectExpressionCompletion?expand=1#diff-4b8bd1eea29904f1be39cd864e1a45c0R3335
Let me know if I could have achieved this in a different way, but after many hours of debugging, this looked like the "most minimal" change to achieve the goal.
I added 2 tests, all tests are green.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: timsuchanek sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Very excited to see this fix! Thanks for your work on this @timsuchanek!

@typescript-bot run dt

Sorry to bother, but maybe @ahejlsberg you can have a look as you introduced the ContextFlags. Not sure if I'm "misusing" them.

Does it also fix #28470?

@AviVahl from my understanding yes! I'll fix the new conflicts tomorrow, then it's again ready to get merged.

@AviVahl I added a fix so that your use-case with the constructor arguments is also supported and also added the 2 examples from https://github.com/microsoft/TypeScript/issues/28470 as test cases.
@weswigham @ahejlsberg can you prioritize this PR so that it doesn't get stale again? Thanks 🙏

@timsuchanek would you also be able to add a test for string literal completions too?
declare function get<T, key: K extends keyof T>(obj: T, key: K): T[K];

get({ hello: 123, world: 456 }, "/**/");

This is one of the most-maddening and longest-standing issues we've had in completions for a long time. It would be really great to get this reviewed @ahejlsberg @weswigham @andrewbranch.

@DanielRosenwasser I just simplified the "binary and" statement and also added your example as a test.
Important to note: Your example also worked before my PR, I added it to the tests nonetheless.

Thanks @andrewbranch! Is there a way that I can accept the baselines?
Locally on my machine the tests succeed, can't reproduce the baseline failure.

Pass --skipPercent=0, and, failing that, set the CI environment variable.

(also rebase/merge with master)

I fixed the baseline merge. @weswigham @ahejlsberg any reservations about exporting ContextFlags in the public API?

Thanks a lot @andrewbranch. Can’t wait to see this merged! (This is a big deal for us at @prisma.) 🎉

@typescript-bot pack this

Hey @timsuchanek, I took a stab at addressing @weswigham’s concerns with some guidance from @DanielRosenwasser. I didn’t want to push a more substantial change here so I branched off of this PR and pushed a new one up at #33937. Would greatly appreciate your input there. Thanks!

@timsuchanek, thanks for championing this through! Your commits here have been merged into master via #33937. 🏆

Thanks a lot, @andrewbranch for pushing this over the finish line!


Mentions Velocity UI Pack in Installation section

Based on feedback from @basrat in #42.

Approved.


Problems in training

After the training, I did not save any training results when I tried the test. Could you please tell me the reason? At last, thank you very much for the code you provided.

I have the same issue.

Training will not call the predict function. You should RUN the file test_epoch.sh to eval instead of running eval.py directly.


No indication show when using filter by province

When I use filter by province and enter province name, there's no indication that I type incorrectly.
Should we add some kind of the alert or province's name "autocomplete" to choose?

maybe we can use CSS to style the input box when such cases happen.

maybe we can use CSS to style the input box when such cases happen.

Like this?


Make tests more stable in gateway mode

Description

It happened really often that tests for Gateway mode are failing on CI. We should make them more resilient.
Things to consider:

retry in gateway mode - communication with GCP/Azure
force Kind version

Expected result

Tests are stable
Actual result

Tests are failing on communication with GCP/Azure
Steps to reproduce

Execute tests on PR
Troubleshooting

Please do that together https://github.com/kyma-project/rafter/issues/50


ModelViewer move UiHelper to constructor

Moving UiHelper to the constructor which allows for more composable control of the underlying views & surface.
More specifically, I needed to set the opacity of the underlying views within ModelViewer.

Android studio auto imported import android.animation.Animator without me realizing so had to delete that


enhance signup/login/access ui

improve the ui of /(auth)/access/page.tsx

Hello,
Is there an administrator account?
How should I log in
How to delete the created short link URL?

by clicking on setting icon of created short link, there is no administrator account as of now

Hey is the below something that you would be interested in? Was this what you meant by the issue or do you need more login providers?

If it is login providers could you create a new issue and then I could work on that within 2 weeks?

hey, sorry for late response

above looks good, just keep consistent we site colors (not yellow)
can add github as a login provider

feel free to make a commit

Yepp. I'll add that as well


x/sys/unix: copy ParseDirent fixes from CL 23780

CL 23780 fixed unsafe use of unsafe in syscall.ParseDirent (see #15653). This patch never made it to x/sys/unix.

Side note: is there any automated process to ensure patches migrate from syscall to x/sys/unix? I had been moving all my code away from syscall, but this sort of thing makes me wonder if that's a bad idea because syscall might get more scrutiny than x/sys/unix.

Side note: is there any automated process to ensure patches migrate from syscall to x/sys/unix?

No, but with the latest progress in x/build/maintner it seems pretty easy to write a tool to find candidates that didn't get moved over. I'll write more about that tool ~next week. But on the other hand, there aren't too many such changes.

@cespare  @bradfitz I can work on it.Should I wait for the automation process to be completed?

@niconegoto, no, don't wait. Any automation would only find missing work, but not do the work.


[DNM] Auction

TODO:

[ ] Run in test env.

Changes on fee service and auction listener look great, I tried to test it locally but contracts test are failing, not sure why.
Let me know if I can help with anything.


Extend mock_all() to work as a context manager

Codecov Report

Merging #4596 (4d87f3c) into master (32b2a90) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4596      +/-   ##
==========================================
- Coverage   95.19%   95.19%   -0.01%
==========================================
  Files         527      527
  Lines       59290    59292       +2
==========================================
+ Hits        56441    56442       +1
- Misses       2849     2850       +1

Flag
Coverage Δ

servertests
47.83% <100.00%> (+<0.01%)
:arrow_up:

test_responses
32.42% <100.00%> (-0.03%)
:arrow_down:

unittests
95.10% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/__init__.py
98.63% <100.00%> (+0.01%)
:arrow_up:

moto/dynamodb/models.py
93.80% <0.00%> (-0.83%)
:arrow_down:

moto/awslambda/models.py
93.01% <0.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b2a90...4d87f3c. Read the comment docs.


Update readme

Change gap-{spacing} to gap-{gap} because gap has its own key.
Added a link to tailwind theme configuration reference to quickly see available options for patterns configuration.

Thanks!


Issue with /docs/getting-started-guides/minikube/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
OS X xhyve driver, broken link
Proposed Solution:
Link to https://github.com/zchee/docker-machine-driver-xhyve
Page to Update:
http://kubernetes.io/...

Fixed.


Added missing functions

Type

[ ] Bug Fix
[x] Functions: $isChannelManageable , $isRoleEditable, $setRolePosition, $isServerDeafened, $isServerMuted, $isVideoOn, $isStreaming, $isSelfDeafened, $isSelfMuted, $readyTimestamp, $packageName
[ ] Callbacks: <Callback Name>
[ ] Handlers: <Handler Type>
[ ] Others: ______

Dependencies (Third Party Modules) needed: <Name | Github Link> (Maximum: 20MB~ size)
Want a credit? Discord tag or other social media link: BEAST#0001
Referenced Issue: #NaN (Answer for an issue, if any)
Description
Pull Request Description Here

Ok done merged all the functions to 1 pr

Ok added all required missing functions

Done all the changes u said. Now see if i need anything more to do

Ok

Ok done removed $packageName

Now u can merge


Add unit tests for PackedScene

Adding test suite that covers PackedScene. I never wrote unit tests before so this is my first attempt 😄, feedback is appreciated.
Link back to #43440

Thanks!


Travis builds failing

Removing gemfile to attempt to fix

Failed, recreating gemfile without gemspec reference

rip, just gonna revert to original gemspec

[] Fixed


bad words script: hopefully make this a bit faster through reuse of compiled regexes

Very short term improvement for https://trello.com/c/5IGQchTX/
The number of terms we use is probably greater than the re module's cache size, causing continual re re-compiling.
No tests! :balloon:  But appears to work.

I've now also added logging of every 100th service or supplier to give the user some idea of progress.


Added restartButton to main screen

Fixes Issue #68
In JS_game.html:
I have added the button for restartgame in buttonWrapper div.
It's onClick is restartGame() .
In Game.js, I have added restartGame() function which stops gameArea and calls startGame(). I have also made space bar to work anytime. Instead of refreshing the page, it now calls restartGame()

Except those changes there aren't changes anywhere else. I think the changes includes so much extra lines as changed because of tab vs space inconsistency with my editor?

@govindbalaji-s Sorry about the delay looking at your PR, thanks for your contribution. The restart button works fine but could you position it lower on the screen so that it is separated from the control buttons.

Will it be good if the restart button is placed next to the level message at the top?

@govindbalaji-s My thought was that it would be best on a new line below the on screen controls. If you want to try it next to the level message we can see what it looks like.

I will try to zoom things out.

@govindbalaji-s The restart button looks good at the top. Can you adjust your CSS, when the window is re-sized the button does not stay fixed. Looks good though!

I am sorry for the delay. Check this out now.

@govindbalaji-s Thanks for sorting the CSS issue with the restart button. The changes to the control button sizes make it difficult when played on a mobile device. When the screen is shrinked the buttons become very small and difficult to touch. This is the reason their size was fixed.
The restart button isn't as important for game play, and obviously if it is on the game screen it does need to shrink with the screen size.
Can you set the control buttons sizes back to fixed.
Sorry if this seems trivial but its important to make sure its playable on all devices. Otherwise your work is awesome!

I am a newbie so I am slow sorry. I have fixed that and now only restart button resizes. the buttonImages class looks a bit unnecessary but I haven't removed them for now incase in future if any css for all button images is needed. If you think they can be removed now, I will do that.

@govindbalaji-s Thanks, works great now! Can you pull down the recent changes to your branch and then push again, i cant merge your branch as it is out of date.

Thank you for being patient throughout and guiding me.

@govindbalaji-s No problem, thanks for your contribution!


Cache unnormalized intersection types

When creating intersection types we first normalize combinations of intersection and union types to place union types topmost. For example, this process turns X & (A | B) into the equivalent X & A | X & B. The normalization process can be very costly for intersections involving large union types. With this PR we cache both unnormalized and normalized intersection types, where previously we would only cache the latter. This means that for a particular set of unnormalized input types, we will only perform the potentially expensive normalization process once.
The improved caching lowers the check times for react and styled-components by ~25% and makes our performance better than 3.3:

3.3
3.4
Master
This PR

react
3.57s
4.25s
4.61s
3.42s

styled-components
4.70s
7.55s
5.84s
4.44s

@typescript-bot test this & run dt

@typescript-bot run dt

Should we consider doing the same for unions, since they potentially repeatedly invoke subtype reduction and/or literal reduction when normalized (which we likewise know is costly for large unions)?

Should we consider doing the same for unions ... ?

I tried. It doesn't seem to make much of a difference. In fact, since UnionReduction.Literal is fairly efficient the caching actually had a negative effect (because computing keys takes time). But even when just caching UnionReduction.Subtype there wasn't a measurable effect.


Replace the Cosmos SDK package version from Osmosis' fork to the actual Cosmos SDK

We have become reliant on Osmosis' fork of Cosmos SDK. This allowed us to easily and fully support the Osmosis modules listed here.
We need to move away from this fork, though. It is getting pretty out of sync with current Cosmos SDK feature sets that we need to support. See this issue for one example: https://github.com/DefiantLabs/cosmos-tax-cli/issues/413#issuecomment-1548764555

The first part of this will be the following: Removing our dependency on Osmosis Cosmos fork in Lens
We are going about this in the following manner:

Create a smaller repo containing blockchain querying functionality inspired by Lens - probe
Depend on Cosmos SDK 0.47
Import all required module Codecs that the app will depend on. Build the Message interface defintions as needed.
Strip out Osmosis Cosmos Fork of this repo, depend on the new probe codebase and fix all issues as they arise.


Add more HFP command suppport

Support all Call Hold Operation
Support CLI Presentation
Support Voice Recognition
Support RING and Volume Changes
[AG] Support Enhanced Call Status
Minor fixes

@barbibulle We got the same issue in workflow https://github.com/actions/setup-python/issues/850


Remove env defaults from code

Currently, some env variables are technically optional as there are defaults for them in various TS files. This means that we have these env variables duplicated in the code, the env files, and then the Docker configs.
Env design will be updated in #67. Let's rely on the env and remove the defaults from the code. We can then update docker and the docs accordingly, leaving us with only 2 places for the variables.

Can leave as is in case something breaks


warehouse_ros: 0.9.1-0 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository warehouse_ros to 0.9.1-0:

upstream repository: https://github.com/ros-planning/warehouse_ros.git
release repository: https://github.com/ros-gbp/warehouse_ros-release.git
distro file: melodic/distribution.yaml
bloom version: 0.6.7
previous version for package: 0.9.0-0

warehouse_ros
* fix missing return value (#40 <https://github.com/ros-planning/warehouse_ros/issues/40>)
* update include statements to use new pluginlib and class_loader headers (#38 <https://github.com/ros-planning/warehouse_ros/issues/38>)
* Contributors: Mikael Arguedas, Robert Haschke

Holding for sync


Set a flake8 rule for unused imports.

Let us take advantage of a flake8 rule F401 to detect unused imports.

LGTM 👍


Fix test_trainer_seq2seq.py

What does this PR do?

In test_trainer_seq2seq.py, the model is instantiated before training args are set and thus before the method adapt_transformers_to_gaudi is called. This leads to an error when this test is executed alone. This PR fixes that.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Removing non-responsive reviewers may leave review in hung state

I believe this is because Review.update_go() is called when a review is created, but not when assignees are changed at a later date. The latter can leave the review forever waiting for the next decision to be taken.
(though I may be wrong)

You are both correct and wrong. Review.update_go is only called when a decision is changed.
But yes, adding this call to ReviewAssignView's form_valid could be the solution. (Which would be a nice easy fix).
Does require some testing to be sure.

Alternatively, hooking into Django's delete object signal might work

Fixed in #119

Fixed in #119


Running Colab code does not give output.

When I run the colab demo code, it does not produce the correct predictions. In the image titled 'Predictions', there are no bounding boxes or labels that appear.

What was your IOU score? If it's low you need to set threshold to be low.
To increase IOU score you probably need to train for more epochs.

Ok I am running your code once more. The dataset you you used in the demo is in Pascal XML VOC format right?

Ok my AP is 0 when running the demo. Any idea why?

Can you give me a link to the colab notebook ?

 No change

Wait let me check I think I made some changes to the API but forget to update the notebook

Did you change these ?
# INSTANTIATE LIGHTNING-TRAINER with CALLBACKS :
# ============================================================ #
# NOTE:
# For a list of whole trainer specific arguments see :
# https://pytorch-lightning.readthedocs.io/en/latest/trainer.html

lr_logger  = LearningRateMonitor(logging_interval="step")
early_stop = EarlyStopping(mode="min", monitor="val_loss", patience=8, )

#instantiate LightningTrainer
trainer    = Trainer(precision=16, gpus=1, callbacks=[lr_logger, early_stop], max_epochs=50, weights_summary="full", )

Whats your loss ?

I did make one change.  Instead of litModel = RetinaNetModel(hparams=hparams), i used litModel = RetinaNetModel(hparams)

The loss is 5.2

That's okay I changes the name of the argument to conf any ways...
I think it will be better if you give me a link to you colab
save colab as github gist and give me the link .... I wil get back to you

5.2 after how many epochs ? It's too high...

In 10 epochs with early stopping

I am now running without early stopping but max epochs=50

I am using Pascal XML VOC format  from roboflow.

I just ran it again without early stopping but max_epochs = 50 , I am getting loss of 5.28.

Mine loss if less than 2 even in 1 epoch same basic params. Let it train for some more ill share the gist

Are you using the BCCD dataset in the Pascal VOC XML format?

Yes

So i did a bit of tunning my optimizer config looks like this now
hparams.optimizer = {
    "class_name": "torch.optim.SGD",
    "params"    : {"lr": 0.005, "weight_decay": 0.0001, "momentum":0.9},
    }

Current epoch 14 and loss=0.37

ok thanks

Please check this : https://colab.research.google.com/gist/benihime91/00996411c8174a81f6c1389750012103/github-retinanet-demo.ipynb
40 epochs, loss = 0.543 , classification_loss=0.233, regression_loss=0.153, val_loss=0.435
coco-evaluation results:
IoU metric: bbox
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.322
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.751
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.154
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.333
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.321
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.491
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.272
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.405
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.451
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.433
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.398
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.567

I will run it now and let you know.

If it still doesn't work try installing pytorch-lightning=1.0.0 (but i don't think that should be an issue 😌) and share me your notebook

Yeah sure :)

I ran your notebook exactly and I am getting poor results.
40 epochs, loss=2.91, v_num=0, classification_loss=2.39, regression_loss=0.518, val_loss=2.88]
IoU metric: bbox
Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.000
Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.000
Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.000
Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.000
Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.000
Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = 0.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.000
Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = 0.000

DATALOADER:0 TEST RESULTS
{'AP': tensor(0., dtype=torch.float64),
'val_loss': tensor(2.8816, device='cuda:0')}
[{'AP': 0.0, 'val_loss': 2.8816070556640625}]

I mean just opened the link and ran the notebook and I am getting the above poor results

Can u try with pytorch-lightning version 1.0.0.. Just to pip install pytorch-lightning=1.0.0

If it doesn't work please share me your notebook.. Or else I'm afraid i won't be able to do anything more

Did you run your notebook on colab or someother platform?

on colab itself

can you list the versions of all the essential libraries that you used such as pytorch lightining, pytorch, torchvision, etc?

The only library that may cause conflicts in pytorch-lightning beacause they had some massive changes... So that why i am saying try with pytorch-lightning version 1.0.0. Other libraries are all deafult installed in colab and Omegaconf and albumentations should not cause conflicts
!pip install pytorch-lightning=1.0.0

ok I will do that now

and also please share your notebook or i am out of options

Its working now. You are right. Its due to the pytorch-lightning version. Thanks for your help,
So I was comparing the original image and the predictions. Some of the bounding boxes do not align. Any tips how to fix this?

That's to be expected you need to do hyper-parameter tuning try using Adam/AdamW optimizer , train more more epochs. As your AP increases the accuracy of the bounding boxes will also increase.

Ok I will look into that. Again thanks for your help

I have updated the colab notebook and requirements.txt be sure to get the latest ones

Hey man:
I get this error
ValueError: Expected y_max for bbox (0.009765625, 0.94140625, 0.05859375, 1.001953125, 1) to be in the range [0.0, 1.0], got 1.001953125.


[Feature][K8S] add prometheus serviceMonitor

Purpose of the pull request
Adding prometheus serviceMonitor will help improve the overall project observability

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
enable serviceMonitor with values
master:
  service:
    serviceMonitor:
      enabled: true

worker:
  service:
    serviceMonitor:
      enabled: true

alert:
  service:
    serviceMonitor:
      enabled: true

api:
  service:
    serviceMonitor:
      enabled: true

prometheus's target page will see the following effect

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14539 (810ba07) into dev (484f841) will decrease coverage by 0.03%.
The diff coverage is n/a.

:exclamation: Current head 810ba07 differs from pull request most recent head ba45390. Consider uploading reports for the commit ba45390 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14539      +/-   ##
============================================
- Coverage     38.73%   38.70%   -0.03%
+ Complexity     4579     4574       -5
============================================
  Files          1237     1237
  Lines         43537    43458      -79
  Branches       4823     4803      -20
============================================
- Hits          16863    16822      -41
+ Misses        24804    24762      -42
- Partials       1870     1874       +4

see 63 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @EricGao888, would you like to take a look?


Error on patrol test " No .xctestrun file was found"

Steps to reproduce
When I run a simple integration test, with patrol test --target integration_test/patrol_config_test.dart --verbose --release, on iOS, I get:

2023-06-30 09:43:30.947 xcodebuild[9959:92788] Writing error result bundle to /var/folders/05/kl3dm3yn3j78c5vll7jttq5r0000gp/T/ResultBundle_2023-30-06_09-43-0030.xcresult
xcodebuild: error: Failed writing xctestrun file: The folder “Runner_iphoneos16.4-arm64.xctestrun” doesn’t exist..

This looks similar to #1105, but I have the fix from that one; I'm using patrol_cli v2.0.0.
To answer the questions from that other bug, I do have Rosetta enabled, I'm on an M1 Mac, and here's the output of ls -lAh build/ios_integ/Build/Products:

ls: build/ios_integ/Build/Products: No such file or directory

... and here are my architecture settings:

... please let me know if there's any other info that will help.
Actual results
Test runs successfully.
Logs

Logs
> patrol test --target integration_test/patrol_config_test.dart --verbose
Verbose mode enabled. More logs will be printed.
Received 1 test target(s)
Received test target: /Users/csabbey/code/sqsurvey-flutter/integration_test/patrol_config_test.dart
Bundled 1 test(s) in /Users/csabbey/code/sqsurvey-flutter/integration_test/test_bundle.dart
$ flutter --no-version-check devices --machine
No device specified, using the first one (Craig’s iPhone (2))
Received 1 device(s) to run on
Received device: Craig’s iPhone (2)
Received 7 --dart-define(s) (0 custom, 7 internal)
Received internal --dart-define: PATROL_WAIT=0
Received internal --dart-define: PATROL_APP_PACKAGE_NAME=com.signalquest.survey
Received internal --dart-define: PATROL_APP_BUNDLE_ID=com.signalquest.survey
Received internal --dart-define: PATROL_ANDROID_APP_NAME=SQSurvey
Received internal --dart-define: PATROL_IOS_APP_NAME=SQSurvey
Received internal --dart-define: INTEGRATION_TEST_SHOULD_REPORT_RESULTS_TO_NATIVE=false
Received internal --dart-define: PATROL_TEST_LABEL_ENABLED=true
• Building app with entrypoint test_bundle.dart for iOS device (release)...
$ flutter build ios --no-version-check --config-only --no-codesign --release --target /Users/csabbey/code/sqsurvey-flutter/integration_test/test_bundle.dart --dart-define PATROL_WAIT=0 --dart-define PATROL_APP_PACKAGE_NAME=com.signalquest.survey --dart-define PATROL_APP_BUNDLE_ID=com.signalquest.survey --dart-define PATROL_ANDROID_APP_NAME=SQSurvey --dart-define PATROL_IOS_APP_NAME=SQSurvey --dart-define INTEGRATION_TEST_SHOULD_REPORT_RESULTS_TO_NATIVE=false --dart-define PATROL_TEST_LABEL_ENABLED=true
        The plugin `flutter_midi` uses a deprecated version of the Android embedding.
        To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
        If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.
        Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
        Building com.signalquest.survey for device (ios-release)...
$ xcodebuild build-for-testing -workspace Runner.xcworkspace -scheme Runner -configuration Release -sdk iphoneos -destination generic/platform=iOS -quiet -derivedDataPath ../build/ios_integ OTHER_SWIFT_FLAGS=$(inherited) -D PATROL_ENABLED
        2023-06-30 09:43:26.635 xcodebuild[9959:92788] DVTCoreDeviceEnabledState: DVTCoreDeviceEnabledState_Disabled set via user default (DVTEnableCoreDevice=disabled)
        note: Building targets in dependency order
        /Users/csabbey/code/sqsurvey-flutter/ios/Runner.xcodeproj: error: Signing for "RunnerUITests" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'RunnerUITests' from project 'Runner')
        warning: Run script build phase 'xcode_build embed_and_thin' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'RunnerUITests' from project 'Runner')
        warning: Run script build phase 'xcode_build backend' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'RunnerUITests' from project 'Runner')
        warning: Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'flutter_blue_plus' from project 'Pods')
        note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner')
        note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner')
        warning: no rule to process file '/Users/csabbey/code/sqsurvey-flutter/native/ntrip/CMakeLists.txt' of type 'text' for architecture 'arm64' (in target 'Runner' from project 'Runner')
        warning: no rule to process file '/Users/csabbey/code/sqsurvey-flutter/native/sq_gis/README.md' of type 'net.daringfireball.markdown' for architecture 'arm64' (in target 'Runner' from project 'Runner')
        warning: no rule to process file '/Users/csabbey/code/sqsurvey-flutter/native/cop/CMakeLists.txt' of type 'text' for architecture 'arm64' (in target 'Runner' from project 'Runner')
        warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')
        warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')
        2023-06-30 09:43:30.947 xcodebuild[9959:92788] Writing error result bundle to /var/folders/05/kl3dm3yn3j78c5vll7jttq5r0000gp/T/ResultBundle_2023-30-06_09-43-0030.xcresult
        xcodebuild: error: Failed writing xctestrun file: The folder “Runner_iphoneos16.4-arm64.xctestrun” doesn’t exist..
✗ Failed to build app with entrypoint test_bundle.dart for iOS device (xcodebuild exited with code 70) (14.7s)
Error: xcodebuild exited with code 70
#0      throwToolExit (package:patrol_cli/src/base/exceptions.dart:7:3)
#1      IOSTestBackend.build.<anonymous closure> (package:patrol_cli/src/ios/ios_test_backend.dart:127:9)
<asynchronous suspension>
#2      DisposeScope.run (package:dispose_scope/src/dispose_scope.dart:46:7)
<asynchronous suspension>
#3      IOSTestBackend.build (package:patrol_cli/src/ios/ios_test_backend.dart:67:5)
<asynchronous suspension>
#4      TestCommand._builderFor.<anonymous closure> (package:patrol_cli/src/commands/test.dart:231:9)
<asynchronous suspension>
#5      _NativeTestRunner.run.runTestsOnDevice (package:patrol_cli/src/test_runner.dart:232:13)
<asynchronous suspension>
#6      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
<asynchronous suspension>
#7      _NativeTestRunner.run (package:patrol_cli/src/test_runner.dart:260:5)
<asynchronous suspension>
#8      TestCommand.run (package:patrol_cli/src/commands/test.dart:194:21)
<asynchronous suspension>
#9      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#10     PatrolCommandRunner.runCommand (package:patrol_cli/src/runner/patrol_command_runner.dart:314:18)
<asynchronous suspension>
#11     PatrolCommandRunner.run (package:patrol_cli/src/runner/patrol_command_runner.dart:258:18)
<asynchronous suspension>
#12     patrolCommandRunner (package:patrol_cli/src/runner/patrol_command_runner.dart:73:20)
<asynchronous suspension>
#13     main (file:///Users/csabbey/homebrew/Caskroom/flutter/3.0.0/flutter/.pub-cache/hosted/pub.dev/patrol_cli-2.0.0/bin/main.dart:6:20)
<asynchronous suspension>

See the logs above to learn what happened. Also consider running with --verbose. If the logs still aren't useful, then it's a bug - please report it.
 FAIL  test_bundle.dart on Craig’s iPhone (2)

Patrol version
patrol: ^2.0.0
Patrol Doctor output

Patrol Doctor output
Patrol CLI version: 2.0.0
Program adb found in /Users/csabbey/Library/Android/sdk/platform-tools/adb
Env var $ANDROID_HOME set to /Users/csabbey/Library/Android/sdk
Program xcodebuild found in /usr/bin/xcodebuild
Program ideviceinstaller found in /Users/csabbey/homebrew/bin/ideviceinstaller

Flutter Doctor output

Flutter Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.2, on macOS 13.4 22F66 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.79.2)
[✓] Connected device (1 available)
[✓] Network resources

• No issues found!

Hi @sqcsabbey, this looks like a code signing issue. From your logs:
/Users/csabbey/code/sqsurvey-flutter/ios/Runner.xcodeproj: error: Signing for "RunnerUITests" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'RunnerUITests' from project 'Runner')

Thank you, @bartekpacia!
If anyone else gets stuck here... here were my steps to get this running:

Selected a development team for signing
Edited my Test Scheme in Xcode to pass the -allowProvisioningUpdates argument
Ran a flutter clean
Ran this test with my original invocation, above (patrol test --target integration_test/patrol_config_test.dart --verbose --release)

Happy to hear that you've found a solution! :)


BUG: Eliminate Unwanted Scrollable Space in MyCart Page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
While exploring you website, I noticed an issue on the MyCart page where there is unwanted scrollable space. This unnecessary space detracts from the website's aesthetics and usability, making the MyCart page appear less professional and more difficult to navigate.
To address this issue, I propose the following changes:

Identify and remove the elements or CSS properties causing the unwanted scrollable space on the MyCart page.
Adjust the layout and styling to ensure that all elements fit within the visible area without causing unnecessary scrolling.

Screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@deepak00944 Assigned!


Accessing the world within a System

Is it good practice to access the world inside a System?
The type definitions do not expose it.
What I mean is something like this:
class SpawnSystem extends System {
  execute(delta, time) {
    // Some logic
      this.world.createEntity() // ...
  }
}

If not, how would you achieve something similar i.e. creating new entities during the life of the World?

Ecsy's type definitions are pretty incomplete at the moment, but I think the intention is to expose the world.
https://github.com/nejcjelovcan/ecsy/commit/2ee42045c012528c747a497fe556552f754c8b96 adds a typedef for it, I've messily combined it and the other types PR on https://github.com/Nebual/ecsy/commits/staging

You are right, is ok to use world. If we find that this could cause problems in the future we will just revisit it and add an explainer.


Unable to configure jupyterlab_widgets / ipywidgets with jupiterWith

Describe the bug
Following the docs, I've generated a shell.nix and used generate-directory but the widgets won't load
To Reproduce

shell.nix

let
  jupyter = import (builtins.fetchGit {
    url = https://github.com/tweag/jupyterWith;
    rev = "45f9a774e981d3a3fb6a1e1269e33b4624f9740e";
  }) {};

  iPython = jupyter.kernels.iPythonWith {
    name = "python";
    packages = p: with p; [
      beautifulsoup4
      ipywidgets
      matplotlib
      Keras
      pillow
      tensorflow
      tqdm
      jupyterlab-widgets
    ];
  };

  golang = jupyter.kernels.gophernotes {
    name = "Go";
  };

  jupyterEnvironment =
    jupyter.jupyterlabWith {
      kernels = [ iPython golang ];
      directory = /home/doug/src/ml-playground/jupyterlab;
    };
in
  jupyterEnvironment.env

Run generate-directory jupyterlab_widgets
Enter this into a jupyterlab cell:
import jupyterlab_widgets
from ipywidgets import interact, interactive, fixed, interact_manual
import ipywidgets as widgets
def f(x):
    return x
interact(f, x=10)

Expected behavior
The cell output should be an interactive slider
Environment

Debian latest with home manager
Version of the code: (git hash in shell.nix)

Additional context
doug@doug-laptop:~/src/ml-playground$ jupyter-labextension list
JupyterLab v3.1.6
Other labextensions (built into JupyterLab)
   app dir: /nix/store/wijndwf354w2i7fx7j30w7pgl3vqh4f0-jupyterlab
        jupyterlab_widgets v0.3.1 enabled OK

In next version we wont support generate-directory command anymore, but we will focus on packaging extensions with Nix.


[comp:pagination] button size has invalid value

Reproduction link

https://github.com/IDuxFE/idux/blob/78738c2b819beaa5b52e15fc41ba518b99bb05d4/packages/components/pagination/src/Item.tsx#L85
Steps to reproduce

The value of the size field small is illegal. And I get the warning say: "Invalid prop: custom validator check failed for prop 'size'. "
What is expected?

no warning.
What is actually happening?

show warning
Any additional comments? (optional)

Environment
Info

@idux

Browser

re #466


feat: Buttons dropdown

Fixes #429
My PR closes #429
👨💻 Changes proposed(What did you do ?)
worked on making dropdowns for css/tailwind button and png/svg  buttons
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots
https://github.com/Dun-sin/Code-Magic/assets/68906510/62d21619-de87-4916-a6ee-30bdadb79366

there some issues here:

no indication that it's a dropdown like the menus have
the content are not well aligned

there some issues here:

no indication that it's a dropdown like the menus have
the content are not well aligned

OK, noted.
Yes, I just realised the issue with the alignment,I will fix it.

But, you are OK with how they are arranged horizontally, right? Or you want them stacked up like the image above?

there some issues here:

no indication that it's a dropdown like the menus have
the content are not well aligned

OK, noted. Yes, I just realised the issue with the alignment,I will fix it.

But, you are OK with how they are arranged horizontally, right? Or you want them stacked up like the image above?

doesn't matter, justify-content-center gap-3 align-items-center should make it aligned universally

Please look at the changes requested

Just pushed again

:tada: This PR is included in version 2.62.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

One more thing, I noticed the download buttons for png and svg do not show on other browsers apart from firefox. Would you mind telling me why you did it that like that?

One more thing, I noticed the download buttons for png and svg do not show on other browsers apart from firefox. Would you mind telling me why you did it that like that?

because only firefox allows for elements to be converted from elements to images, on other browsers it doesn't work

One more thing, I noticed the download buttons for png and svg do not show on other browsers apart from firefox. Would you mind telling me why you did it that like that?

because only firefox allows for elements to be converted from elements to images, on other browsers it doesn't work

Oh, I see. Thanks


Check for all-NaN partitions

Check for all-NaN partitions when calling set_index with sorted=True, and raise a more specific/helpful error.
Partially addresses https://github.com/dask/dask/issues/6721

[ ] Tests added / passed
[x] Passes black dask / flake8 dask

This looks good and works as expected. Would you be able to add a test?

Thanks, added!


[T4A2][F10-B2]Ravi Shwetha

Ready for Review

Sorry about the extra commits, I was merging branches for the previous tutorial to my master before every pull request but I reverted those changes (I tried deleting the forked repo then forking again but the commits were saved for some reason?), so the git diff just shows the changes for this tutorial.

Overall good in code quality and using of access modifiers :)

@ravishwetha : Some comments added. Please close the PR after reading comments


Refractor: move permission control service to workspace directory and keep saved objects as clean as possible

Description

Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

Codecov Report

Merging #166 (cd37f8f) into workspace (f350eb3) will decrease coverage by 23.10%.
Report is 1 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           workspace     #166       +/-   ##
==============================================
- Coverage      65.71%   42.61%   -23.10%
==============================================
  Files           3336     1591     -1745
  Lines          64652    32336    -32316
  Branches       10316     6076     -4240
==============================================
- Hits           42484    13780    -28704
+ Misses         19688    17513     -2175
+ Partials        2480     1043     -1437

Flag
Coverage Δ

Linux_1
?

Linux_3
42.61% <ø> (+0.07%)
:arrow_up:

Linux_4
?

Windows_1
?

Windows_2
?

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

src/core/server/index.ts
100.00% <ø> (ø)

src/core/server/legacy/legacy_service.ts
0.00% <ø> (-75.39%)
:arrow_down:

src/core/server/plugins/plugin_context.ts
0.00% <ø> (-45.46%)
:arrow_down:

...server/saved_objects/saved_objects_service.mock.ts
70.83% <ø> (-29.17%)
:arrow_down:

...core/server/saved_objects/saved_objects_service.ts
0.00% <ø> (-86.49%)
:arrow_down:

... and 2290 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Splitting FirebaseUI

I a using FirebaseUI for quick add a login interface to my app.
I am using e-mail and google sign in for now.
Is there any way to remove the reference to other sdks like Twitter and Facebook?
They are just increasing my apk size

Are you finding that these classes are retained in your APK even after
ProGuard?  Normally that should strip the unused classes.
On Sun, Nov 27, 2016, 3:27 PM Porfirio<EMAIL_ADDRESS>wrote:

I a using FirebaseUI for quick add a login interface to my app.
I am using e-mail and google sign in for now.
Is there any way to remove the reference to other sdks like Twitter and
Facebook?
They are just increasing my apk size
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-Android/issues/423, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIEw6monYah0f0fQXICC2XC2n1zy_4DHks5rCeetgaJpZM4K9PyQ
.

If i open the apk in Android Studio, i can ser allot of resources, drawables etc. From twitter ans facebook.
I tried to hard remove dependencies with gradle but then some of firebaseui resources are tied to Facebook and Twitter resources.

@porfirioribeiro I see, that's a good point about the resources (ProGuard can't do very much about those).  Right now the design of FirebaseUI would make it very hard to allow selective inclusion of the 3p SDKs but we can keep this issue open and see if we think of anything to improve the situation.

Ok, i see the problem, i hope in the future you can find some solution for this!
It's not a big issue, but i don't like to see the apk size grow so much, but in the other end i dont want to the implementation all by myself :wave:

Even with the shrinkResources true I can see all twitter resources in my apk. I just checked through Android Studio's APK Analyzer. Or with some proguard rules or something which can remove those resources or classes. Because I can see a lots of methods and resources.
Here is the screenshot:

What I like about Square's Retrofit is that it only loads what you need:
com.squareup.retrofit2:converter-gson
com.squareup.retrofit2:converter-jackson

FirebaseUI could do something like this.
com.firebaseui:firebase-ui-auth:1.0.1
com.firebaseui:firebase-ui-auth-twitter:1.0.1
com.firebaseui:firebase-ui-auth-facebook:1.0.1

Yes, that's was what i was suggesting, split the library into smaller ones

In addition to the benefits mentioned above, it would also be great if we (and anyone downstream from us) didn't need to add the Fabric repository if we aren't using anything related to Twitter.

Hello everyone, in FirebaseUI v2.0 the Facebook and Twitter libraires aren't included by default so there's no APK size increase unless you use Facebook or Twitter auth.
@samtstern I believe the underlying issue of increased APK size has been resolved.

Yep I think the original issue is resolved.  You can now leave out the Twitter and Facebook SDK if you're not using those sign in options.


Change README.md explaining unofficial Windows Support

I'm not sure if it's a good time to say this, but seeing as there is now experimental support (see #800) we should potentially update the README.md explaining that it's theoretically possible.

Thanks, @weaversam8!


Make sign up invite only

Block sending of initial email in signup flow if they are not in the invite service

Before merging this can we make sure the micro m3o signup test still works?

Before merging this can we make sure the micro m3o signup test still works? ie. this https://github.com/micro/micro/blob/master/test/m3o_test.go#L24

Have lined up a PR for updating the tests since we now need to run invite service too.


Construct NVR string early and fail in pre_koji if build was already submitted

TODO:

[x] Add tests

Coverage increased (+0.002%) to 87.058% when pulling af352e419504ef84ac2b952e10b16cb12859a5e3 on vrutkovs:pre_check_nvr into 3ad3f105b2314bc6ceea961cb4fbbfc9a9223538 on projectatomic:master.

Coverage decreased (-5.8%) to 81.266% when pulling 8cda218f638be69a9105437a46c228ff954cb4dc on vrutkovs:pre_check_nvr into 3ad3f105b2314bc6ceea961cb4fbbfc9a9223538 on projectatomic:master.

This plugin doesn't get run at all if a yum repourl is specified for the build, so the check won't be performed when building with signed packages.

Right, we probably don't need it if https://github.com/release-engineering/koji-containerbuild/pull/38 will be accepted, although it might help if osbs cli is used.

We probably don't need this one after koji-containerbuild change has landed?

Probably not.

Closing this one for now - this is implemented in k-cb now


[Snyk] Upgrade @walletconnect/web3wallet from 1.10.2 to 1.10.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @walletconnect/web3wallet from 1.10.2 to 1.10.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released a month ago, on 2024-03-19.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@nathanklick @hedera-eng-infrastructure these are failing DCO checks.
Also, is this redundant with dependabot?


feat: restructure spi by component

What this PR changes/adds
move all the spi folders into the spi folder, grouped by the component they are needed for.
spi
├── common
│   ├── auth-spi
│   ├── catalog-spi
│   ├── core-spi
│   ├── identity-did-spi
│   ├── oauth2-spi
│   ├── transaction-datasource-spi
│   ├── transaction-spi
│   ├── transport-spi
│   └── web-spi
├── control-plane
│   ├── contract-spi
│   ├── control-plane-spi
│   ├── data-plane-transfer-spi
│   ├── policy-spi
│   └── transfer-spi
├── data-plane
│   └── data-plane-spi
├── data-plane-selector
│   └── selector-spi
└── federated-catalog
    └── federated-catalog-spi

Why it does that
To accomplish project structure review
Further notes

this PR only moves modules, it does not change packages or class names, so it shouldn't conflict with other PRs, as the modifications regard only gradle files
got rid of the spi BOM module as it will lose meaning as no extension should refer to the "generic" spi but to the component-relative one or to a specific one
extensions/dataloading seems to be an spi more than an extension, will create an issue to inline it (as it was already discussed)
common/token-generation-lib and token-validation-lib seem to contain spi code that's actually extended by some extensions, I propose to introduct a token-spi module, related issue will be created
all the policy thing is pretty confusing, I will create a discussion about how to improve its structure, now we have:

policy-spi that only contains two interfaces, one used only by the transfer process, and the other is the repository for PolicyDefinition
core-spi/policy package, that contains interfaces for the policy-engine
policy-evaluator that contains all the policy related model classes (no logic)
policy-engine that contains the PolicyEvaluator class and accessors
base-core/policy package, that contains the policy-engine implementation

My gut feeling is that core-spi contains too different kind of classes, need to be reviewed, probably a better view will come when #1809 will be done

Linked Issue(s)
Closes #1808
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1832 (28a5336) into main (f4743b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage   67.27%   67.27%
=======================================
  Files         777      777
  Lines       16594    16594
  Branches     1084     1084
=======================================
  Hits        11163    11163
  Misses       4966     4966
  Partials      465      465

Impacted Files
Coverage Δ

...nnector/api/auth/AllPassAuthenticationService.java
0.00% <ø> (ø)

...onnector/api/auth/AuthenticationRequestFilter.java
100.00% <ø> (ø)

...g/eclipse/dataspaceconnector/spi/EdcException.java
50.00% <ø> (ø)

...dataspaceconnector/spi/agent/ParticipantAgent.java
0.00% <ø> (ø)

...ceconnector/spi/asset/AssetSelectorExpression.java
60.86% <ø> (ø)

...paceconnector/spi/command/BoundedCommandQueue.java
100.00% <ø> (ø)

...clipse/dataspaceconnector/spi/command/Command.java
54.54% <ø> (ø)

...taspaceconnector/spi/command/CommandProcessor.java
0.00% <ø> (ø)

.../dataspaceconnector/spi/command/CommandRunner.java
0.00% <ø> (ø)

.../eclipse/dataspaceconnector/spi/entity/Entity.java
56.25% <ø> (ø)

... and 210 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[WIP] Refactor tests concerning AddCommand out from LogicManagerTest #327

Improves #327.

Decided to go a different trajectory while doing this PR, resulting in PR becoming too bug. Will split this PR up.


fix types of swiper-effect-utils.d.ts

This PR fix two type issues of swiper-effect-utils.d.ts.
1. change import of .d.ts file to import type
related: https://github.com/nolimits4web/Swiper/commit/30ce8e0c9c7ce32025275469e9480ca8c81f30a7

A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file './types/index.ts' instead?

2. Fix invalid optional parameter declaration of createShadow.
In making this correction, I checked that suffix parameter is specified at all places in this repo where createShadow is called.

A required parameter cannot follow an optional parameter.

t0ggles-create swiper

Merged, thanks!


KAFKA-6512: Discard references to buffers used for compression

ProducerBatch retains references to MemoryRecordsBuilder and cannot be freed until acks are received. Removing references to buffers used for compression after records are built will enable these to be garbage collected sooner, reducing the risk of OOM.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma Can you review, please? Thank you!

retest this please

@ijuma Thanks for the review.
@hachikuji Can you take a quick look to see if it looks ok? Thank you!

LGTM

@ijuma @hachikuji @Lothsahn Thank you for the reviews. Merging to trunk and 1.1.


[Bug]: Find root cause for missing plugin id and plugin type in JS action objects

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Find root cause for #11927 - ie why plugin id and plugin Type go missing in some JS actions.
Steps To Reproduce
Not available.
Public Sample App
No response
Version
cloud

Closing it as RCA can be found here in detail as mentioned by Subrata above.


[Feat]: Improve Navbar responsiveness on small devices

What feature?
On small devices like mobile phones, the navbar components are aligned to the left. Instead, if the components are aligned at the center, it will look more standard are appealing to the user.
Add screenshots

I want to work on this feature implementation.
Please assign me the task under GSSoC'23.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

we removed from the center. which device are you using? I'm not facing any issues

@priyankarpal I'm using the Chrome DevTools.
It's just a suggestion to center the components so as to look good since most of the websites have centered navbar components and the page looks filled and even makes more appealing to the user.
Thanks!

@priyankarpal I'm using the Chrome DevTools. It's just a suggestion to center the components so as to look good since most of the websites have centered navbar components and the page looks filled and even makes more appealing to the user. If not possible, then atleast some icons can be added in front of the names. Please let me know... Thanks!

can you give us a demo?

@priyankarpal

Similar to this... There are alignment issues in this image... It's just for illustration!

@priyankarpal
Similar to this... There are alignment issues in this image... It's just for illustration!

we had icons previously & we removed them.

@priyankarpal
As these changes are not required, are there any other updates to be made in the navbar?
Please let me know... I will work on the implementation of there are any...
Or else this issue can be closed.

@priyankarpal As these changes are not required, are there any other updates to be made in the navbar? Please let me know... I will work on the implementation if there are any... Or else this issue can be closed.

ig we don't need to add/change anything in the navbar. if we need we will create an issue.


Virtualbox 6.0 ?

You will support the new version of Virtualbox 6.0 in near future ?
Thanks

Later in January, maybe. Configuration scripts should work the same way already (except parts of ACPI tables, roms etc).

UEFI support need binary patch of VBoxVgaDxe module in VBoxEFI64 file. See http://www.kernelmode.info/forum/viewtopic.php?p=27460#p27460

Oh yes, what I wanted to say more specifically is about the bin "VBoxEFI64_5.2.18.fd" does not support the new version Virtualbox 6.0

@Whibelf2
If you want you can try this VBoxEFI64. Rename it to VBoxEFI64.fd and overwrite that file in "Program Files\Oracle\VirtualBox".
VBoxEFI64.patched.zip

@Whibelf2
If you want you can try this VBoxEFI64. Rename it to VBoxEFI64.fd and overwrite that file in "Program Files\Oracle\VirtualBox".
It is taken from https://download.virtualbox.org/virtualbox/6.0.0/VirtualBox-6.0.0-127566-Win.exe
VBoxEFI64.patched.zip

After all done, copied VBoxEFI64.fd and overwrite, But when i start VM just get Blackscreen:

Does tsugumi.sys loaded?

This version of VBox contain a bug that causes any EFI enabled guest to show black screen with any type of virtual display adapter other than VBoxVGA which is not default setting. If you want set the EFI option for guest, you should also go to Display settings and change video adapter type to VBoxVGA manually. Updated version of VBox loader will be posted later. However the above bug need to be resolved by Oracle.

See https://github.com/hfiref0x/VBoxHardenedLoader/commit/117fc0b63cd9c0d838475bd3dd5308334370d2ae commit for 6.0 support.
Make sure to load tsugumi.sys (if it wasn't loaded) and use loader.exe before starting any VM.
Regarding to temporary workaround for Oracle bug, make sure to select VBoxVga for EFI OS install.

Please create new issue to address any new/other bugs etc.


System error delete_file error: SPIO_E_FILE_ACCESS

Launching a complex MAS this error may show up.

This means the local host performance does not allow to launch too many agents, so their startup should be distributed over time.
To slow down the MAS startup procedure, edit the file :
for Windows
DALI/Examples/basic)/startmas.bat

at line 10:
set WAIT=ping -n 4 <IP_ADDRESS>

increase the n parameter, number of seconds between agent bootstratps, at your will.
for Linux and macOS
DALI/Examples/advanced)/startmas.sh
at line 10:
WAIT="ping -c 4 <IP_ADDRESS>"

increase the c parameter, number of seconds between agent bootstratps, at your will.


feat(deps): new step one of verified in person flow

New step 1 content of verified in person flow (alt person flow)
Includes the recommended patterns of preferring components over screens, letting screens only handle navigation mechanics, and modularizing group sections of code. Tests included, snapshot and UI. Here's what it looks like:

@bryce-mcmath , is there a dev mode toggle to enabled/disable this new flow?

@bryce-mcmath , is there a dev mode toggle to enabled/disable this new flow?

@cvarjao yes, that was done in a previous PR. It only uses this flow if store.developer.enableAltPersonFlow is true, which is toggleable in developer mode and by default off